Issue #SB-13810 fix: Publish Pipeline Issue Fix

Codecov Report

Merging #521 into release-2.1.3 will not change coverage.
The diff coverage is n/a.

@@               Coverage Diff                @@
##             release-2.1.3     #521   +/-   ##
================================================
  Coverage            32.11%   32.11%
  Complexity            1220     1220
================================================
  Files                  172      172
  Lines                15118    15118
  Branches              2399     2399
================================================
  Hits                  4855     4855
  Misses                9537     9537
  Partials               726      726

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4235ea7...ab724de. Read the comment docs.


EntityListener utilities for Ashley

Add an EntityRemovalListener for removal-only
Add an EntityAdditionListener for addition-only
Kotlin lambda utils for similar functionality

The same could be applied to the interface - instead of providing an interface that is basically a no-op listener and gives no guarantees that the user implements the actual logic, we could add EntityAdditionListener and EntityRemovalListener interfaces with one no-op method implementation instead.

Thanks for your feedback! I agree, EntityAdditionListener and EntityRemovalListener would be better.
I'll make a PR for this in the coming few days, excuse me for the late reply.

No problem, take your time.

I've rewritten some docs and added missing tests for all system extension methods. In general, we should aim for tests of every public API, even if some of them might seem redundant.
Thanks for the contribution @RedGrapefruit09, nice job. It should be available via the snapshot release shortly.

I've rewritten some docs and added missing tests for all system extension methods. In general, we should aim for tests of every public API, even if some of them might seem redundant.
Thanks for the contribution @RedGrapefruit09, nice job. It should be available via the snapshot release shortly.

Thanks for your corrections!

I think I removed that part since it seemed a bit redundant - all methods are already mentioned in the first section. I can add it as a comment to the code sample, since example sections usually do not provide any API listings.


Missing license file

Hi, thank you for your valued work! Would you mind adding a license file? I would like to build on top of your work, which I currently can't without the license... MIT license would be preferable, but it's of course your choice.

Ok, thanks for your interest @hrosspet , I just added the MIT license file. Best.


Apply black formatter to existing files

Reformat all current files using black. Better do it in one go, otherwise it will muddle the changes made in future commits.

But that's what the last commit (bd1497be9d9733844a5bbb2b532965be5f79c059) is supposed to do 🤔

I chose to use a --line-length of 90 with Black so maybe that's why you still get formatting if you don't have the same settings.
https://github.com/GrayTurtles/Clueless/blob/bd1497be9d9733844a5bbb2b532965be5f79c059/.vscode/settings.json#L13-L14

Oh wait, my bad ^^'
You should probably set up a pyproject.toml so the config is editor-independent, and can be picked up by the command-line tool directly.


Invoke Jena RDF Parser with target Graph URI as the base parameter

Jena Model parser has a base field that is used to resolve relative URIs in the JSONLD.
In Java this looks like this:
 RDFDataMgr.read(model, inputStream, base, Lang.JSONLD);

Would be great to use the graph URI as the base parameter to resolve relative URIs to absolute uris.
E.g. if graph URI is https://gstore.de/whatnot/somedoc.jsonld, then
"@id" : "#mod"

would resolve to
"@id"  : "https://gstore.de/whatnot/somedoc.jsonld#mod"

in the virtuoso. Since the document is usually made retrievable via its graph URI, the relative URIs resolve correctly for common JSON-LD parsers.
If a doc does not use any relative URIs, then the parameter is ignored and won't break anything existing.

Could you provide some example document, which I could use to test that?

should we have the resolved uris or relative ones in the saved files on the drive (in git)?

Example
{
  "@context" : "https://raw.githubusercontent.com/dbpedia/databus-moss/dev/devenv/context2.jsonld",
  "@id" : "",
  "wasGeneratedBy" :  {
      "@id" : "#layer",
      "@type" : "DatabusMetadataLayer",
      "version" : "1.0.0",
      "name": "simple",
      "created" : "2024-03-01 14:37:32",
      "used" : "https://databus.dbpedia.org/lrec2024/linguistics/wordnet/2023#wordnet_lang=en.ttl.gz"
  },
  "subject" : [ "oeo:OEO_00020033" ]
}

We cannot resolve, because piping it through the parser would mess up the Document again. If it can be done without messing with the Document structure and losing non-RDF, then it could be a Setting. I think easiest way is to not resolve it and save as is.

It did not work in the first attempt. Specifying base did not do anything and Jena reads the document as empty... I will need to get a deeper look into it.

We are using
RDFDataMgr.read(model, dataStream, baseUrl, lang);

in moss, maybe that's a working method

@holycrab13 this method should be not working as well, as I anticipate, but didn't check it yet

@holycrab13 okay, I got what is the problem... needs some time to understand how to fix in a best way... it is due to caching context and using cached ones

Since we needed it now for dev, I made a branch where it' working. It's on the jan branch and the main edit is in SparqlClient in
 def readModel(data: Array[Byte], lang: Lang, baseUrl: String, context: Option[util.Context]): Try[(Model, List[Warning])] = Try {

    log.debug(s"Parsing with base url: ${baseUrl}")

    val model = ModelFactory.createDefaultModel()
    val dataStream = new ByteArrayInputStream(data)
    val dest = StreamRDFLib.graph(model.getGraph)

    RDFDataMgr.read(model, dataStream, baseUrl, lang);
    val eh = newErrorHandlerWithWarnings

    (model, eh.warningsList)
  }

where I also pass the baseUrl. Then in the ApiImpl I pass the graphId in the saveFile function
override def saveFile(repo: String,
                      path: String,
                      body: String,
                      prefix: Option[String],
                      author_name: Option[String],
                      author_email: Option[String])
                     (request: HttpServletRequest): Try[OperationSuccess] = {

  val pa = gitPath(path)
  val graphId = generateGraphId(prefix.getOrElse(getPrefix(request)), repo, pa)
  val ct = Option(request.getContentType)
    .map(_.toLowerCase)
    .getOrElse("")
  val lang = mapContentType(ct, defaultLang)
  val ctxU = contextUrl(body.getBytes, lang)
  val ctx = ctxU.map(cu => jenaJsonLdContextWithFallbackForLocalhost(cu, request.getRemoteHost).get)
  validateEmail(author_email).flatMap(email =>
    readModel(body.getBytes, lang, graphId, ctx)
      .flatMap(model => {
        saveToVirtuoso(model._1, graphId)({
          saveFiles(repo, Map(pa -> body.getBytes), author_name, email)
              .map(hash => OperationSuccess(graphId, hash))
        }).transform(Success(_), e =>
          if (model._2.isEmpty) {
            Failure(e)
          } else {
            val ee = new RuntimeException(
              s"Error saving data, potentially caused by: ${model._2.map(_.message).fold("")((l, r) => l + '\n' + r)}",
              e)
            ee.setStackTrace(Array.empty)
            Failure(ee)
          })
      })
  )

@holycrab13 okay, so I managed to finally integrate the relative uri resolution, the question here is:
should we save in the git resolved Uris or not? -> also return in read the resolved Uris or not?

No and no, we should test the second one with the jsonld playground first. Afaik, this should be resolved locally.

I managed to achieve what you want with Uris! Hurray! Soon will be delivered

should work now in dev branch


Fix the pacu alias in the pacman module.

Since the deprecation of abs [1], the call for the pacu alias was resulting in a rsync error.
This PR just updates the alias with the equivalent command, asp update.
[1] https://www.archlinux.org/news/deprecation-of-abs/

Thanks for the contribution! Looks good!


Binary for Mac 10.15 Catalina

Hello,
Would you be able to build the binary file for Catalina?
Thanks,

Hi,
we shall be able to deliver a package installer ... i guess
Cause to build it, you have to change many things in build script
i'll try to build it soon
Regards

Hi,
Also interested in Catalina binaries for libusb and sane-backends.
Could you share the build script ?

Is there any progress on this? I've got a charity that's desperate to get their Macs to talk to their scanner again, which is connected to a Linux server running SANE and accessed across the network. All their Macs are running 10.15.

Hi everyone !
Since last year, i had some sad and some good news ...
As you know this repo is still based on a old release of the Sane Project;  i'll switch progressively to newest release from them
Dear ICloud (bird daemon) periodcly crashes, so i loss most of sources, on tools i've created for automating configuration on this project ....
The Good News is, whatever thoses loses, i've got a 25% backup and i know what lack in th build process.
@blegay with some understand in compiling, you can achieve the installation ... but if you want to deploy it, you need a PKG for easy replication
@lord-aerion Now i got a 10.15 Mac, i should be able to test and provide PKGs
So ... Originally, XCode configurations are used to build sources to PGK and i've just finished to install MacOS Catalina(10.15) on THE OLD GOOD bench test MacBook ;)
Promise i'll spend some of my time to provide you some PKGs for Catalalina 10.15
And Still providing for 10.9++ era, cause i still have one 10.9-10.10'ish ...
Regards


Other Basis Sets

This may be far outside your interest so feel free to just close this but have you considered allowing other basis sets, eg atomic orbitals, ...

Atomic orbitals use significantly different techniques, so having both in a single project would just make things more complicated without significant code sharing (plus there's pyscf which is apparently pretty good). Finite element/differences might be interesting and could probably have a nice unified codebase, but no immediate plans on my end.

ok, then I'll just close this for now

I'm not sure I fully agree with @antoine-levitt. I think it could be interestingto  make sense to add atomic basis sets at some point
I'd be interested in adding atomic-orbital type basis sets at some point, but that's definitely talking quite long-term and only once

The point is that the structure of the code right now (SCF plus application of the hamiltonian) is more suited to "large" basis sets (PW/FE/FD) than "small" basis sets (eg gaussians), where the tradeoffs are different. I think the relevant question is which current functions would be shared with another basis set. I can see a lot of functions that would be usable in an FE/FD implementation (SCF, iterative diagonalization, pseudos, hamiltonian application), but barely any that would be in a gaussian implementation (essentially just lattice and kpoint handling). Putting two mostly orthogonal codes in a single framework just leads to bloat IMO (because then you're naturally led to build "fake abstractions" that are convoluted ways to abstract on two completely different things). But then I guess the situation is not that clear-cut with other types of basis sets, like wavelets of sturmians or whatever, and we'll probably want at some point to have some kind of interface with localized functions (eg to compute projected DoS, Wannier functions, etc.) so there might be some merit to the idea. Might be interesting to see eg what GPAW does here.

So maybe a better idea would be to have an AbstractDFT package that provides a unified interface to various concepts that DFT packages would implement.

@antoine-levitt With these arguments I can agree. An additional aspects, where I expect benefit in code-sharing would be the SCF fixed-point solvers. As you know I worked on abstracting this a while ago, but it definitely became too convoluted in my previous attempts. I still feel it can be done better.
@cortner I like the idea of trying to generalise to an abstract interface. That way common structure and code can be expressed and specific details kept in the individual implementations, keeping them simple and without bloat. I'm not sure AbstractDFT is the right name as other SCF-like approaches (e.g. Hartree-Fock) are basically the same ... let's keep that in mind for the future, however.

Re fixed-point, I definitely agree about that, but the place to do that is in NLsolve I think
Re abstract interface: we'll see if and when we have multiple "user" codes (julip-like) calling multiple "producer" codes (dftk-like)

Yes NLsolve sounds better.
For sure, I agree :smile: ... but as you know ... sometimes I like to envision the distant future.


add replicate block command

receives target-name for the new block
receives a name and type that matchs another block to replicate from
receives a regex pattern to match on the source code file paths, defaults to (name from source block) blockname.[test.]js
receives a value to put into those file path matches, defaults target-name (name from target block)

gddify replicate --target-name myblock --name mysourceblock --type blocktype --pathPattern /myfeatureExample/ --valuePath myfeature
Maybe later we can support special value variables

93a455d61d302a2a1af84c3b7f05889c93e8a79f


Add option to disable metrics collection logging

~Will also need to bump the actual version number but I'm not really sure how to do that in Go.~ Maybe I bumped the version correctly?
References #81
For some reason this seems to segfault on my setup, but I'm not really sure if that's because of a code issue or because of a build issue, since I'm cross-compiling.

Hi @rfox-codecov! Thank you for your contribution! And sorry for the late reply 😅
Well, I've tested it locally and 'it works on my machine' 😄 Will merge and update chart repo.


Big gene_presence_absence file

Hello! I am trying to use phandango for getting a tree against the gene presence absence matrix from Roary. It all worked fine when I had smaller data sets, but now I have more genomes and a larger gene presence absence file (250 MB). When I try loading the csv, the site crashes (I tried with Chrome and Firefox). Is there a way to fix this? Thank you :)

James have a simple python script here  which minimises this file

Thank you! Now I can load everything, but phandango crashes when I try to export a svg file. Do you maybe know how to solve this?

Hi @ivaatanas - i'm guessing that the file is just too large to be handled by the code we use to construct the SVG. Perhaps @simonrharris can solve this, but I would suggest using screenshots as I think this will be extremely hard to fix (SVGs with millions of tiles would be really hard to work with as well).
Thanks, james


Simple dry run

This is a simplification of my previous dry run pull request https://github.com/martine/ninja/pull/178 (which I'll close)

Great, thanks!


Add TypeScript definitions

Summary
Hey, pretty straight-forward: Adding some TypeScript definitions.

Thanks for creating a TypeScript definition. 🙌 Can you follow this styleguide?
Some examples:

https://github.com/sindresorhus/semver-regex/commit/039944bb5b3876913171b895488874b5c200e458
https://github.com/sindresorhus/global-dirs/commit/0aae4d64887f77af94c4fb7ca12aa9f93c0a8291
https://github.com/sindresorhus/md5-hex/commit/bbbfeff840f26973fbffc16d4863ae6d120079f3

Hey, I updated the PR by documenting the types in index.d.ts.
Just pointing out some things in the PR:

I used any over unknown to match Node's definition: https://github.com/DefinitelyTyped/DefinitelyTyped/blob/master/types/node/globals.d.ts#L192.
I used the example from the README.md which uses 2 separate files. I wasn't sure how to document it so I used two sets of ```s.

I went over the styleguide and didn't find anything that's missing, is there anything specific I should fix?
Thanks!

I used any over unknown to match Node's definition: DefinitelyTyped/DefinitelyTyped:types/node/globals.d.ts@master#L192 .

The Node.js type definitions are not very good nor strict.

Looks good. Thanks :)


Support for MQTT 5

Is your feature request related to a problem? Please describe.
MQTT v5 is the latest version of the MQTT protocol.
Describe the solution you'd like
Adding v5 support to the existing MQTT protocol support so that there is one pub/sub client to support all version of the protocol.
Additional context
Version 5 of the MQTT protocol is published by OASIS at the following link:
https://docs.oasis-open.org/mqtt/mqtt/v5.0/mqtt-v5.0.html
The Eclipse PAHO project has open source client reference implementations supporting version 5 in a number of languages:
http://www.eclipse.org/paho/

@rlubos any plans to implement this in the near/mid term?

@carlescufi Not on my schedule, at least for now. We might consider it though as it seems like a valuable improvement.

I think MQTT 5 is particularly important for IoT devices, as it has some  unique features, like "Maximum message size" or "Negative Acknowledgements", which tell the client why a massage could not be delivered.

Looking forward to implementing this plan, it is very meaningful

As for Nordic, it's not on our schedule (yet), but other contributions are welcome.

@rlubos Amazon AWS now supports MQTT 5: https://docs.aws.amazon.com/iot/latest/developerguide/mqtt.html#mqtt5. The maximum packet size and receive maximum properties of the CONNECT packet are desirable.

Any upddate on this? Mqtt 5.0 is light years ahead of 3.1.1. They have added significant features that address all of the most common IoT pain points.

Any upddate on this?

No progress according to my knowledge.

Any update on supporting MQTT 5? Is anyone using 3rd party libraries on Nordic microcontrollers?

Any update on supporting MQTT 5?

No update.


[Bug] Dialogs don't work on platform WorkerUI

Bug, feature request, or proposal:
Bug
What is the expected behavior?
A dialog should work on all platforms.
What is the current behavior?
A dialog causes an error when the platform is worker ui.
ERROR ReferenceError: document is not defined     at Overlay../node_modules/<EMAIL_ADDRESS>(material.es5.js:2816)     at Overlay../node_modules/<EMAIL_ADDRESS>(material.es5.js:2801)     at MdDialog../node_modules/<EMAIL_ADDRESS>(material.es5.js:17843)     at MdDialog../node_modules/<EMAIL_ADDRESS>(material.es5.js:17811)     at AppComponent../src/app/app.component.ts.AppComponent.openDialog (
What are the steps to reproduce?
Run Angular in a webworker and try to use the Angular Material dialog.
I've made a repo to show this behavior.
https://github.com/Owain94/material-dialog-error
Which versions of Angular, Material, OS, TypeScript, browsers are affected?
Angular ^4.0.0
cdk ^2.0.0-beta.8
material ^2.0.0-beta.8

Angular Material doesn't support Angular's experimental web-worker feature


[routing] Added type aliases for vector-of-edges.

Main purpose here is to avoid small std::vector in frequent GetEdgeList.
Checked that average edges count from node is 2, so use buffer_vector<T, 8>

PTAL


Format and lint

enable eslint for all exercises
format all files the same way
fix a stub (simple-linked-list)

@SleeplessByte This is so good! :green_heart:

enable eslint for all exercises

Do we need the .prettierrc file? I am a little confused here because I don't see prettier anywhere in the codebase.
Will CI check for lint be added in separate PR?

I didn't yet decide if we wanted to add it by default, but first wanted to see your reaction hehehehe.
I'll add it to the maintainers workflow and I'll add the CI. We already have it for v3, so easy copy.

/format

@tejasbubane

It now checks formatting in CI
It forces the same consistent version of prettier for formatting and checking it
It adds npx babel-node scripts/format to run prettier
It adds instructions in the docs about that new action
It adds instructions in the docs about how to set-up your editor to "automatically" do it.

In reality, code formatted between version 2.x and 2.y is going to be very similar if not the same, so most of the time prettier will "just work" in editors. We just don't want to auto-install a version that has to be kept in sync with the repo unless that's necessary. We can later decide to add it as devDependency (but remove it in the exercises, like shelljs).
Bonus. On any future pr, add a comment with:
/format

and it will auto-format the code and commit it. No need to install/run anything.

Amazing work @SleeplessByte :+1:


#region not always folding

// #region label1
var x;
// #endregion label1

Actual:

Note: I got these from tests\cases\fourslash\getOutliningSpansForRegions.ts, so seems like the test is not testing the right thing.

@mhegazy When stepping through the test, it is actually testing the right thing. Seems that the regex match works in mocha but not otherwise. I can easily fix the issue in general, but am concerned that we don't know what changed. (@DanielRosenwasser)

not sure i follow.. so the test is working correctly? if so why is it failing for VS/VSCode?

There seems to be a difference in the way line endings are handled in mocha and otherwise. When attaching a debugger to tsserver, I can see that the regex is failing on the string "// #region label1\r", which is clearly my mistake, I should have handled line endings better. But when attaching a debugger to the mocha test, it reads the string as "// #region label1" and passes fine.


Running in Docker

Hi, any idea how to get this running inside a docker container? Currently integrated as part of WebGL unit testing which works perfectly. Except, fails on the CI/CD side since this is a docker environment. Makes sense since there are no GPU drivers. But even emulation would be acceptable since performance is a non-issue. This is all under Ubuntu. Any help is much appreciated.

Solved by installing xvfb (apt) and xvfb-maybe (npm). Then as part of package.json "test": "xvfb-maybe jest"


How to do an update on a model using join ?

I have 2 tables A,B now I want to update the fields in A having some relation in a filed of table B.
Does knex support update on join ? The database is postgres. The query is something like this:
UPDATE A AS a
SET a.price = true
FROM B AS b
WHERE a.id = b.id ;

You could use the query using knex.raw
http://knexjs.org/#Raw-Queries

Any option other than that ?

.update and .join doesn't seem to work well together. I would recommend using subquery instead... Maybe this is what you are trying to do?
knex('A').update({price: true}).whereIn('id', function () { this.select('id').from('B'); });

Thanks it helped. :)

This is how you can use the join with the update method in knex.
knex("organizationCardDetail AS orgCard")
				.update("orgCard.isCardDefault",0)
				.join('productscard AS prodCard','prodCard.cardId','=','orgCard.cardId')
				.where({"prodCard.organizationId":organizationId,"prodCard.productId":productId})``

@aadilraza339 I'm confused, given #2796, are you sure your solution works?


Item_filter format changed, supports itemcount

Short Description:
you can now limit how many items you want to keep

This looks awesome. Merging to my personal branch :)
It might be worth adding some info to the README: https://github.com/PokemonGoF/PokemonGo-Bot#advance-configuration about the format.

This is very needed !  Readme update please if possible.


CI Integration

[x] Travis CI for OSX
[x] Appveyor for Windows (32/64)
[ ] Coveralls.io

Can't seem to generate a coverage report that works using electron-mocha. Coffee-coverage looks like the best option however, waiting on reply on issue. https://github.com/benbria/coffee-coverage/issues/60


Add support for Chrome scaling.

Summary
This PR fixes/implements the following feature:

[X] Support for the "Scale" PDF print option

This came up as part of an unrelated use-case in which the resulting PDF needed to be printed at 85% scale.  I noticed that Gotenberg did not yet support the PrintToPDFArgs.Scale.  This change implements it as option scale.
Test plan (required)
Output for make lint tests is attached: lint-tests-output.txt.  One unrelated failure (also in the master branch) occurred.
End-to-end results manually verified in the resulting PDF, but by running the built Docker image with a port-forward:
curl -XPOST http://localhost:3000/convert/html -H'Content-Type: multipart/form-data' --form<EMAIL_ADDRESS>--form scale=0.85 --form marginTop=0 --form marginBottom=0 --form marginLeft=0 --form marginRight=0 -o printed.pdf
Checklist

[X] Have you followed the guidelines in our CONTRIBUTING guide?

[X] Have you written new tests for your core changes, as applicable?
[X] Have you successfully ran tests with your changes locally (make tests)?
[X] Have you updated the documentation (Markdown files under build > docs > content and then make doc)?
[X] I have squashed any insignificant commits
[X] This change has comments for package types, values, functions, and non-obvious lines of code

Hello @mdjward
Sorry for the delay (⛷).
Thank you very much for those PRs 👍 I'll try to check them asap 😉


changes made

PR Description 📜
Please include summary related to the issue you have fixed and describe your PR in brief over here by specifying the issue number on which you were working below
Fixes # 4156

Mark the task you have completed ✅

[ ] I follow CONTRIBUTING GUIDELINE & CODE OF CONDUCT of this project.
[ ] I have performed a self-review of my own code or work.
[ ] I have commented my code, particularly in hard-to-understand areas.
[ ] My changes generates no new warnings.
[ ] I have followed proper naming convention showed in CONTRIBUTING GUIDELINE
[ ] I have added screenshot for website preview in assets/images
[ ] I have added entries for my game in main README.md
[ ] I have added README.md in my folder
[ ] I have added working video of the game in README.md (optional)
[ ] I have specified the respective issue number for which I have requested the new game.

Add your screenshots(Optional) 📸

Thank you soo much for contributing to our repository 💗

Hey @Parth20GitHub, you can't open another pull request before completing the previous one 😀
You already have the following 1 open pull request(s):
#4928

Thank you @Parth20GitHub ,for creating the PR and contributing to our GameZone 💗
Review team will review the PR and will reach out to you soon! 😇
Make sure that you have marked all the tasks that you are done with ✅.
Thank you for your patience! 😀

Thank you  @Parth20GitHub , for your valuable time and contribution in our GameZone 💗.
It’s our GameZone, so Let’s build this GameZone altogether !!🤝
Hoping to see you soon with another PR again 😇
Wishing you all the best for your journey into Open Source🚀


$elemMatch (projection)

First, thank you for the great tool.
This is not an issue but a question.
Currently NeDB delivers all items of array field. Is it possible to fetch specific item by providing query with projection object using $elemMatch like MongoDB does?
https://docs.mongodb.org/manual/reference/operator/projection/elemMatch/
Thank you.

I'm not sure if this will help your exact situation, but I remembered seeing this a little while ago:
https://github.com/louischatriot/nedb/pull/364

$elemMatch if working fine for queuing documents but does not work as projection. What I need is selecting specified by query in projection phase array element:
{ doc: "A", items: [    {name: "Item1", color: "green"},    {name: "Item2", color: "red"} ] }
collection.find({doc: "A"}, {$elemMatch: {'items.color': 'red'}}, (err, docs) => {    // returns:    // {doc: "A", "items": [{name: "Item2", color: "red"}]} });

Indeed the $elemMatch operator is not implemented as a projection so you would need to do so manually.


feat(AS-Prepends): added AS-Prepends latest

:tada: This PR is included in version 0.35.0 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


fix: wrong updation of DocsNavItem

Description
Validated the logic for the case : when slug of a section is equal to its parent section's Slug.
Related issue(s)
#1179

/rtm


Problem with api/v2/import-scan

Hello
I have an issue with using api/v2/import-scan from one pod (gitlab-runner) to defectdojo django pod in the same namespace.
I have installation of defect-dojo from helm chart, added my domain values to ingress to access the web interface and everything was successfull but i can't load my reports in json using API using service inside kubernetes namespace, but loading files from remote machine via ingress name is successful.
For example my service name is defectdojo-django, and i added it to DD_ALLOWED_HOSTS, so trying to use this service via cURL from inside of a gitlab runner pod is successful,connection successfully established, but when i try to use cURL to load my report json file with the service_name (not ingress name)  i have an errors such :
expecting value: line 1 column 1 , bad request
Bad Request - /api/v2/import-scan
when i try to load this file with all the same parameters via cURL from remote machine, using ingress, loading is successfull.
Also other methods of API work properly when i use cURL from gitlab runner pod via service inside namespace, only /apy/v2/import-scan doesnt work.
Does it mean that i should use only ingress name to load the peport to defectdojo , not service?
Thanks!

Have you tried reimport-scan instead of import-scan?  Assuming you are using the same scan, of course.. Import =/= Reimport, but Reimport = Import.

Have you tried reimport-scan instead of import-scan? Assuming you are using the same scan, of course.. Import =/= Reimport, but Reimport = Import.

i tried it , reimport-scan returns same error -
dojo.importers.base_importer - Expecting value: line 1 column 1 (char 0)
django.request - Bad request - api/v2/reimport-scan

I can confirm import-scan and reimport-scan does work.  I'm using them as we speak for other tests I'm running on my Dev Dojo stack.  I don't use Helm, so it sounds like you have something else going on.  If it works with the ingress name and not service name, I'd use ingress name.

I can confirm import-scan and reimport-scan does work. I'm using them as we speak for other tests I'm running on my Dev Dojo stack. I don't use Helm, so it sounds like you have something else going on. If it works with the ingress name and not service name, I'd use ingress name.

Yes, my problem depends on restrictions of my k8s cluster when i cant use ingress inside the cluster between pods in the same namespace, only services..


fix emailLib in the error handler

Merging this, since this is blocking any error emails from production. @xdamman pls review post-merge.


Error on regexp: The provided regular expression is using multiline anchors

first thanks for the update! The installation runs now. But now there is a problem with rails >4.0. When I open a site there is an error:
ActionView::Template::Error (The provided regular expression is using multiline anchors (^ or $), which may present a security risk. Did you mean to use \A and \z, or forgot to add the :multiline => true option?):
1: <%- if<EMAIL_ADDRESS>-%>
2:
<%= l(:label_milestone_plural) %>
3: <%- @project.milestones.sort.each do |milestone| -%>
4: <%= link_to_milestone(milestone) %>
5: <%- end -%>
6: <%- end -%>
I think there was a chang with ^ and $ in rails 4.

Works well now. Thank you!


Jsonify always returns datetime objects as GMT timezone

Issue
Jsonify always returns datetime objects as GMT timezone. Seems like this has been a problem in the past with these issues:

https://github.com/pallets/flask/issues/2392
https://github.com/pallets/flask/pull/2374

Environment

Python version: 2.7.5
Flask version: 1.0.2
Werkzeug version: 0.14.1
pytz version: 2018.5

Testcode
#!/usr/bin/env python2.7

from werkzeug.http import http_date
from datetime import datetime
import pytz

from flask import Flask, jsonify

app = Flask(__name__)

@app.route('/')
def root():
    # Localize time
    local_time = pytz.timezone("America/Chicago")
    time = datetime.utcnow().replace(microsecond=0).replace(tzinfo=pytz.utc)
    time = time.astimezone(local_time)

    print("iso format:", time.isoformat())
    print("object:", time.tzinfo)
    print("http date:", http_date(time))

    result = [time]

    print("Test object: %s" % result)

    return jsonify(result)

app.run(host='<IP_ADDRESS>', port=8080, debug=False)

Console output:
Test object: [datetime.datetime(2018, 7, 10, 11, 45, 20, tzinfo=<DstTzInfo 'America/Chicago' CDT-1 day, 19:00:00 DST>)]

Jsonify output:
["Tue, 10 Jul 2018 16:45:20 GMT"]

That's the correct behavior. The default JSONEncoder accepts times with any timezone as input, but always outputs UTC (GMT) in RFC 1123 format.
In the vast majority of cases, you should be working with UTC at boundaries and converting to local time only when displaying to users.
If you want to change the format that dates are serialized, including supporting other timezones, override app.json_encoder with your own flask.json.JSONEncoder subclass.

According to this Stack Overflow answer, ISO 8601 is the preferred standard over RFC 1123/822/2822. This link further defines the current best practice.


[BUG] Skips songs on Spotify?

Sometimes I will be listening to Spotify on my Chromecast Ultra and the song will skip for no reason.
Image below is of debug logs when my Spotify songs get skipped with no user interaction.
Error messages start right when song gets skipped and then end when next song starts.

Happens intermittently, sometimes multiple songs quickly right after each other.
Command I use to run:
docker run --rm --privileged --network host erdnaxeli/castblock --debug --mute-ads --category sponsor --category outro --merge-threshold 3 --offset 2
Below is debug output of it skipping two songs in a row (and then I killed the process)
2021-12-18T00:59:13.084886Z  DEBUG - castblock.blocker: Received message -- application: "Spotify"
...
2021-12-18T00:59:23.145886Z  DEBUG - castblock.blocker: Received message -- application: "Spotify"
2021-12-18T00:59:23.158139Z  DEBUG - castblock.blocker: Checking for new devices
2021-12-18T00:59:23.158147Z  DEBUG - http.client: Performing request -- method: "GET", host: "<IP_ADDRESS>", port: 8011, resource: "/devices"
2021-12-18T00:59:25.158975Z  DEBUG - castblock.blocker: Received message -- application: "Spotify"
...
2021-12-18T00:59:37.235668Z  DEBUG - castblock.blocker: Received message -- application: "Spotify"
2021-12-18T00:59:38.171069Z  DEBUG - castblock.chromecast: Unhandled payload: Missing JSON attribute: customData
  parsing Castblock::Chromecast::WatchMessagePayload::PayloadStatus at line 1, column 34
  parsing Castblock::Chromecast::WatchMessagePayload#status at line 1, column 24
2021-12-18T00:59:38.829504Z  DEBUG - castblock.chromecast: Unhandled payload: Missing JSON attribute: customData
  parsing Castblock::Chromecast::WatchMessagePayload::PayloadStatus at line 1, column 34
  parsing Castblock::Chromecast::WatchMessagePayload#status at line 1, column 24
2021-12-18T00:59:39.275785Z  DEBUG - castblock.blocker: Received message -- application: "Spotify"
2021-12-18T00:59:40.299491Z  DEBUG - castblock.chromecast: Unhandled payload: Missing JSON attribute: customData
  parsing Castblock::Chromecast::WatchMessagePayload::PayloadStatus at line 1, column 34
  parsing Castblock::Chromecast::WatchMessagePayload#status at line 1, column 24
2021-12-18T00:59:40.627964Z  DEBUG - castblock.chromecast: Unhandled payload: Missing JSON attribute: customData
  parsing Castblock::Chromecast::WatchMessagePayload::PayloadStatus at line 1, column 34
  parsing Castblock::Chromecast::WatchMessagePayload#status at line 1, column 24
2021-12-18T00:59:41.288511Z  DEBUG - castblock.blocker: Received message -- application: "Spotify"
2021-12-18T00:59:43.456009Z  DEBUG - castblock.blocker: Received message -- application: "Spotify"
2021-12-18T00:59:43.627732Z  DEBUG - castblock.chromecast: Unhandled payload: Missing JSON attribute: customData
  parsing Castblock::Chromecast::WatchMessagePayload::PayloadStatus at line 1, column 34
  parsing Castblock::Chromecast::WatchMessagePayload#status at line 1, column 24
2021-12-18T00:59:44.127668Z  DEBUG - castblock.chromecast: Unhandled payload: Missing JSON attribute: customData
  parsing Castblock::Chromecast::WatchMessagePayload::PayloadStatus at line 1, column 34
  parsing Castblock::Chromecast::WatchMessagePayload#status at line 1, column 24
2021-12-18T00:59:45.129031Z  DEBUG - castblock.chromecast: Unhandled payload: Missing JSON attribute: customData
  parsing Castblock::Chromecast::WatchMessagePayload::PayloadStatus at line 1, column 34
  parsing Castblock::Chromecast::WatchMessagePayload#status at line 1, column 24

Experienced issue while castblock was disabled, not a bug.


Add Remix Product Gallery example

Closes #52.

hey @Insidiae this example doesnt seem to be working for me, can you help me figure out whats going on?
to start, i was getting an error about --manual being included in the in the dev script, so removed that, and the server started, but i got a bunch of warnings, and the server won't render the page

using node v18

@colbyfayock Hmmm, I can't reproduce the error on my end (tried both PNPM and NPM to setup the project). What was the error you got about --manual in the dev script?
I used pnpm dlx create-remix to setup the example project (I also tried using npx create-remix@latest to recreate the same project to see if PNPM was causing the issue, but the relevant files all remained the same), i suspect the --manual is a new thing in Remix v2 🤔
I'm also using node v18 (v18.15.0 to be exact)

ah i figured out the issue! you mentioning v2 made me think of it
i think its a dependency issue with the other remix project in there and using yarn workspaces. i need to think of a new strategy for that, but anyways, using npm install locally to that project worked
ill spin up a new ticket to migrate the other remix project to v2
thanks for the add @Insidiae

@all-contributors please add @Insidiae for code

@Insidiae congrats on the merged PR! since it was merged during Hacktoberfest, you're eligible for some free swag. Please email<EMAIL_ADDRESS>with your Github username and a link to this PR where we'll follow up with you there.
https://cloudinary.com/blog/hacktoberfest-celebrate-open-source-sdks


Why am I stuck during dist training and the CPU usage rate is 100%？

When I train my custom model on coco, I always get stuck after several iterations, sometimes not, it will appear on different machines. And it always happens when i use the dist train.
Here is message when I interrupt.
`
^CTraceback (most recent call last):
File "/home/zpf/miniconda3/envs/solotr/lib/python3.7/runpy.py", line 193, in _run_module_as_main
"main", mod_spec)
File "/home/zpf/miniconda3/envs/solotr/lib/python3.7/runpy.py", line 85, in _run_code
exec(code, run_globals)
File "/home/zpf/miniconda3/envs/solotr/lib/python3.7/site-packages/torch/distributed/launch.py", line 261, in
main()
File "/home/zpf/miniconda3/envs/solotr/lib/python3.7/site-packages/torch/distributed/launch.py", line 254, in main
process.wait()
File "/home/zpf/miniconda3/envs/solotr/lib/python3.7/subprocess.py", line 1019, in wait
return self._wait(timeout=timeout)
File "/home/zpf/miniconda3/envs/solotr/lib/python3.7/subprocess.py", line 1653, in _wait
(pid, sts) = self._try_wait(0)
File "/home/zpf/miniconda3/envs/solotr/lib/python3.7/subprocess.py", line 1611, in _try_wait
(pid, sts) = os.waitpid(self.pid, wait_flags)
KeyboardInterrupt
`

It seems like a deadlock problem. But I don't know how to solve it

i got the same problem, sometimes it happened after several dozen steps, sometimes it happend after several epochs.
2021-04-29 01:11:06,095 - mmdet - INFO - Epoch [16][810/1676]   lr: 1.000e-02, eta: 3:48:26, time: 0.958, data_time: 0.007, memory: 8059, loss_cls: 0.5132, loss_bbox: 0.2357, loss_bbox_rf: 0.2942, loss: 1.0430
^CTraceback (most recent call last):
File "/home/ai/anaconda3/envs/torch/lib/python3.7/runpy.py", line 193, in _run_module_as_main
"main", mod_spec)
File "/home/ai/anaconda3/envs/torch/lib/python3.7/runpy.py", line 85, in _run_code
exec(code, run_globals)
File "/home/ai/anaconda3/envs/torch/lib/python3.7/site-packages/torch/distributed/launch.py", line 260, in
main()
File "/home/ai/anaconda3/envs/torch/lib/python3.7/site-packages/torch/distributed/launch.py", line 253, in main
process.wait()
File "/home/ai/anaconda3/envs/torch/lib/python3.7/subprocess.py", line 971, in wait
return self._wait(timeout=timeout)
File "/home/ai/anaconda3/envs/torch/lib/python3.7/subprocess.py", line 1601, in _wait
(pid, sts) = self._try_wait(0)
File "/home/ai/anaconda3/envs/torch/lib/python3.7/subprocess.py", line 1559, in _try_wait
(pid, sts) = os.waitpid(self.pid, wait_flags)
KeyboardInterrupt

the GPU usage rate is  also 100%

the GPU usage rate is also 100%

I solved it by modify my model forward code where may cause gradient inconsistent between multi gpus. In my case , I replace the logic block(if while) with matrix form.
This blog may help.https://www.cnblogs.com/Xiaoyan-Li/p/14451547.html

It seems like a deadlock problem. But I don't know how to solve it

i meet the same issue when num_fg_imgs = 0 in loss function.


Allow QueryAndEncodeDatabaseAuthenticationHandler to be optional

Closes #1691

ticketRegistry also have this problem

You will need to:

Open up a separate issue
Attach logs
Your configuration

Thanks.

I am so sorry.
Maybe I forgot copy some dependency jar into lib.
Finally I replace all jar in lib.
It now works fine.
thanks.


USDZ support ?

Is there any plan to support USDZ files to render using Sceneform? This will be great for developing cross platform experiences and asset management.

I will track this as a feature request.

Any update on this track? Would like to know a date for this to be supported.

found this one: https://googlewebcomponents.github.io/model-viewer/


chore: update dependencies

Thanks for the PR!
Deployments, as required, will be available below:
Any successful deployments (not always required) will be available here
Please create PRs in draft mode.  Mark as ready to enable:

Analysis Workflow

After merge, new images are deployed in:

Merge Workflow

Seems like there's a couple of dependency issues. Looks like (as usual) carbon dependencies are not being resolved or changed


Fix Catch::toString() linker error when main() is compiled as C++

Closes #278

Thanks - sorry for the delay in getting to this.


Calling sleeps causes an error

Calling (sleep 1) in the evaluator available from the official web site triggers the following error : BiwaScheme.assert_real is not a function [sleep].

Fixed on git HEAD. The website will be fixed when next version (v0.7.6) is released. Thanks for reporting!


Import script

Make the import script parallel so that importing can happen a bit quicker.

I'm having trouble running this against both staging and production:
Staging: requests.exceptions.SSLError: [Errno 1] _ssl.c:510: error:14090086:SSL routines:SSL3_GET_SERVER_CERTIFICATE:certificate verify failed
Prod: requests.exceptions.SSLError: [Errno 1] _ssl.c:510: error:14090086:SSL routines:SSL3_GET_SERVER_CERTIFICATE:certificate verify failed

Merging this, note that the requirement to supply certs may be removed once we have real certs for all environments.


CI: partial move from CircleCI

What does this PR do?
partial move jobs from CircleCI to GH actions
PR review
Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.
Did you have fun?
Make sure you had fun coding 🙃

does anyone have experience how to configure dvipng?
/opt/hostedtoolcache/Python/3.7.7/x64/lib/python3.7/site-packages/recommonmark/parser.py:75: UserWarning: Container node skipped: type=document
  warn("Container node skipped: type={0}".format(mdnode.t))

Warning, treated as error:
dvipng command 'dvipng' cannot be run (needed for math display), check the imgmath_dvipng setting
The name of the builder is: htmlMakefile:19: recipe for target 'html' failed
make: *** [html] Error 2


Addin elevation data to LuSTScenario

How changed is LuSTScenario from the real Luxemburg? I need to add elevation data to the scenario but it looks pretty difficult to adapt the data of an osm of Luxemburg, with 3D information, to this scenario.

The OSM map used is from 2014 and it's heavily changed to achieve a smooth simulation. Now SUMO largely improved and it requires fewer modifications, but at the time, it was different.
Anyway, the only thing that you can do it's to try and see if it fits. I spoke with others that tried it, but I don't know how complex was it for them and from what elevation datasets they started.  You can try to contact the authors of http://dl.ifip.org/db/conf/wons/wons2018/12-11-On-the-Necessity-Brummer-5188217.pdf and see if they can help you.


Migration from 3.x to 4.x

Add a migration to update the data format from 3.x to 4.x.
We check each entry, and if it can be parsed with EJSON.parse, we parse it, and then store it again using EJSON.toJSONValue
Fixes #37 and #45
@pauldowman

@rgould - Would you like me to try this out, and verify it ?

This scenario did not result in being able to retrieve objects after the 4.x migration
Scenario:
// clear local storage, use 0.3.5
Session.set("ben-kills-birds", [true, false])
Session.set("dean-kills-birds", "no")
Session.get("dean-kills-birds")
> "no"
Session.get("ben-kills-birds")
> [true, false]

// git checkout master
Session.get("ben-kills-birds")
> "[true,false]" // <-- string, not array
Session.get("dean-kills-birds")
> ""no"" // <-- string, not array

// git checkout migration-3x-to-4x
Session.get("ben-kills-birds")
> "[true,false]"
Session.get("dean-kills-birds")
> ""no""

// FYI PSDATAVERSION is {"data":4,"expires":null}, showing that a migration ran, but values are still strings when retrieved..

@deanius Okay, updated. Note that if you call localStorage.clear() and then Session.set without refreshing the page, things will get into a bad state that I believe won't be seen in the wild, so make sure to reload the page after calling localStorage.clear()

Yup - that worked! Objects are deserialized across the migration. :+1:
Session.get("ben-kills-birds")
[true, false]
Session.get("dean-kills-birds")
"no"


RFC: Merge default navigationOptions with screen navigationOptions.

I'd like to propose that this behaviour (by design according to https://github.com/react-community/react-navigation/issues/170) change.
I completed expected them to be merged, and I am not really convinced they shouldn't be. It seems a very common use case that I'd want to change the color of the navigation bar globally, and then add some left/right buttons on various screens.
The current way forces users to manually merge in the default header config for every screen.
I even think that this can be added w/o affecting backwards-compatibility all that much. If header is a function, the user can manually handle the parent values. But if header is given as an object literal, then merge it.

We had this feature working for a while but turned it off as there were a lot of discussions regarding that.
CC: @ericvicenti @satya164

cc @skevy too

I agree with this, we should merge them

We already do merge at the top level navigationOptions, so if we had a headerColor navigation option rather than header.color option, you would have the expected behavior. This is exactly why I wish we had a flatter list of nav options, rather than having them name-spaced into header, tabBar, etc.
@miracle2k, to make this proposal more clear, can you write a brief code sample, (maybe your header color example), with a comment saying what would change, ("this would be red, but I think we should change the behavior so it is blue").
Is the leading proposal to do a deep merge of navigation options? Or only merge one more level? Or should we add logic to only merge the "header" option?
If you need the merging behavior in the mean time, you can implement it here like @satya164 demonstrated: https://github.com/react-community/react-navigation/issues/170#issuecomment-277286638

Closing as options are now flat.


Provide RTL support

I am creating an app with Arabic language. Placeholder should be RTL, but it is showing on left side.
Typing text displays correctly RTL

Support for RTL layout direction was added in the version 3.1.0. What version of RSKPlaceholderTextView are you using?

@khawars Just checked RTL layout direction in the version 5.0.1. It is working. Please, check the latest version and re-open the issue if the problem still persists.


Python 3.7 failing in npm run check

Specs

Leon version: Master 360d1020c4bd8bf1df3764645c635c64e0364702
OS (or browser) version: Linux 4.4.0-140-generic
Node.js version:  node --version -> v11.1.0
Complete "npm run check" output:

╰─➤  npm run check

><EMAIL_ADDRESS>check /mnt/storage0/overminddl1/leon/leon
> babel-node scripts/run-check.js

⠋
---

.: CHECKING :.

➡ /bin/sh -c node --version
✔ v11.1.0

➡ /bin/sh -c npm --version
✔ 6.4.1

➡ /bin/sh -c pipenv --version
✔ pipenv, version 2018.11.26

✖ Error: Command failed: /bin/sh -c pipenv run python --version
Warning: Python 3.6 was not found on your system…
You can specify specific versions of Python with:
  $ pipenv --python path/to/python

And yet running that command manually:
╰─➤  /bin/sh -c 'pipenv run python --version'
Loading .env environment variables…
Python 3.7.2

Expected Behavior
Python 3.7 should work.  Downgrading the system version is... not safe.
Actual Behavior
npm run check is failing the python check.
How Do We Reproduce?
Use the updated version of python.

 ⬆ Upgrade to the latest Python version

Hello @OvermindDL1,
Thanks for your issue. Today Leon must have Python 3.6 to work. For a future Leon's version, Python will anyway be upgraded to the latest Python version on that moment.
I added it to this roadmap card.

All good, it ended up running well in Docker.  :-)
It might be good to add a Dockerfile to the project with everything auto-acquired and so forth so someone can just git clone ... && cd ... && docker build ... and get a fully operational setup ready to go.  :-)

As you already noticed there is a PR for Docker file #9.
Alright, I will close this issue then.

 ⬆ Upgrade to the latest Python version

What do we need to do to support 3.7 as well?

 🔧 [1.0.0-beta.3] Support for Python version >= 3

The reason why I preferred to have one dedicated Python version was due to Leon modules writing and backward compatibility.
But finally by adding the pipenv --three command in the Leon setup process, Pipenv will ensure to take the latest Python 3 version available on the machine. Today, I believe OSes have quite recent Python versions and people usually setup the latest Python version when it is not already installed.
So, now Leon allow any Python 3 versions.
Does it make sense?

The reason why I preferred to have one dedicated Python version was due to Leon modules writing and backward compatibility.
But finally by adding the pipenv --three command in the Leon setup process, Pipenv will ensure to take the latest Python 3 version available on the machine. Today, I believe OSes have quite recent Python versions and people usually setup the latest Python version when it is not already installed.
So, now Leon allow any Python 3 versions.
Does it make sense?

Makes sense to me

Alright, I'm gonna close this issue then.
Feel free to reopen it or create a new one if necessary.


feat: introduce pem registry

:tada: This PR is included in version 1.0.0-beta.5 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


spike netrc support

This is an aggressive implementation of #8, wholly removing ~/.habiticarc support, and not really adding proper error handling.
A real implementation would:

[ ] support ~/.netrc and ~/.habiticarc
[ ] document precedence between them
[ ] pull the machine name from a variable to support local habitica instances
[ ] raise a friendly error message if neither the default nor habitica.com authenticator is found
[ ] raise a friendly error message if login or password is None

This makes a lot of sense. I'm going to switch to .netrc only for v0.0.12.


Remove demo classes from Storybook to align with Carbon grid

Updated task description
In both Web components and React, the Storybook stories often contain demo classes that help with adjusting the position of components. This should be removed, and we will rely on bx--grid or Carbon grid to position the component in storybook canvas.
From Kenny:

we probably can go into the stories and remove all demo classes. we still have the carbon grid classes in the stories. once the demo classes are gone we can adjust the presentation layouts using carbon grid only

Some history
Clean storybook's viewport grid layout in Web Components
Update since huddle April 20:
Components should be positioned in Storybook canvas like described here:
https://github.com/carbon-design-system/carbon-for-ibm-dotcom/wiki/Storybook-format-standard#3-rendering-in-viewport
From what I understand from Ian’s comment, there's some grid issue within storybook and need to fixed globally:

To be discussed in the Team Huddle on Tuesday, April 20.

Comments from the April 20 Team Huddle:

Shixie will make an issue defining guidance for UI vs Layout components

Link to the Team Huddle Box Note:  https://ibm.ent.box.com/notes/797086649110

Confirmed with dev that we need to address grid alignment in several stories through out storybook.

Remove demo classes
Adjust grid alignment using bx--grid only

We have a new issue to track this work with updated info.


Enhance the build experience of envoy.

Today build envoy from github is not trivial. And it's even harder to build its tests.
Shall we?

Add envoy dependencies as its submodules?
Bazel support?
Single command to build?

If you can use docker to build, it is not hard and just one command to build and test:
https://lyft.github.io/envoy/docs/install/building.html
We have bazel BUILD files in https://github.com/istio/proxy , @mattklein123 are you open to merge it into envoy repo?

Bazel support does not enhance build experience in any manner (not from our experience so far!). As @lizan pointed out, there is already a simple one line docker build command, and the docker image comes with all the dependencies installed in it.

We have been using bazel in istio/proxy for a while, and I do think bazel enhanced the build experience, especially for attaching debuggers, working with tools doesn't work well with docker. It provides dependency resolution without changing the system environment.

IMHO what needs to be done here is to fix the CMakeLists.txt to take care of dependencies. That way compiling from the repo would be as easy as setting your CXX/CC and
$ cmake .. && make

or even
$ cmake .. && ninja

I have a working branch that I'm planning to push when I have some time to polish

@Reflejo , agreed, the deps is the most painful part.
Can we add those deps as submodules of envoy if they are available on github?

Per offsite meeting, here is I think where we landed here:

We don't mind multiple build systems, but we need a single source of truth.
It's possible we can look at gRPC build system to see how they do both bazel and cmake.
We are open to switching to Bazel IFF it doesn't make any of the existing flows worse and does not make CI any longer than it already is (given how slow Travis is and the fact that right now we don't have any other options).

@htuch I believe is going to take the lead on a proposal/investigation here. Going to assign to him.

As long as one can build the system in a docker container, bazel or not
doesn't matter. Building in a container makes things easier to develop on
different platforms (use your favorite ide on the host, mount volume in the
container and build).
@htuch if you do go down the bazel in a container path, you would have to
give folks a fair warning that all of the bazel caching stuff will be
negated. And oh, if you could also provide the bazel/clion scripts that
folks at Google use, it would be great. :)
On Sat, Feb 25, 2017 at 1:24 PM Matt Klein<EMAIL_ADDRESS>wrote:

Per offsite meeting, here is I think where we landed here:

We don't mind multiple build systems, but we need a single source of
truth.
It's possible we can look at gRPC build system to see how they do
both bazel and cmake.
We are open to switching to Bazel IFF it doesn't make any of the
existing flows worse and does not make CI any longer than it already is
(given how slow Travis is and the fact that right now we don't have any
other options).

@htuch https://github.com/htuch I believe is going to take the lead on
a proposal/investigation here. Going to assign to him.
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/lyft/envoy/issues/415#issuecomment-282502397, or mute
the thread
https://github.com/notifications/unsubscribe-auth/AH0qd1anD26m7v7ERTAedETSCjZ9lAiDks5rgHHHgaJpZM4L1zJY
.

--
~shriram

build in docker can make it easier for multiple platforms release, but not
for IDE. For example, if I'm using eclipse cdt, I would prefer to get a
make file which can be imported directly. Today people has to manually
configure their environment and install different kinds of dependencies,
which is the pain point. GitHub submodules are preferred.
On Sun, Feb 26, 2017 at 10:01 AM Shriram Rajagopalan <
<EMAIL_ADDRESS>wrote:

As long as one can build the system in a docker container, bazel or not
doesn't matter. Building in a container makes things easier to develop on
different platforms (use your favorite ide on the host, mount volume in the
container and build).
@htuch if you do go down the bazel in a container path, you would have to
give folks a fair warning that all of the bazel caching stuff will be
negated. And oh, if you could also provide the bazel/clion scripts that
folks at Google use, it would be great. :)
On Sat, Feb 25, 2017 at 1:24 PM Matt Klein<EMAIL_ADDRESS>wrote:

Per offsite meeting, here is I think where we landed here:

We don't mind multiple build systems, but we need a single source of
truth.
It's possible we can look at gRPC build system to see how they do
both bazel and cmake.
We are open to switching to Bazel IFF it doesn't make any of the
existing flows worse and does not make CI any longer than it already is
(given how slow Travis is and the fact that right now we don't have any
other options).

@htuch https://github.com/htuch I believe is going to take the lead on
a proposal/investigation here. Going to assign to him.
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/lyft/envoy/issues/415#issuecomment-282502397, or
mute
the thread
<
https://github.com/notifications/unsubscribe-auth/AH0qd1anD26m7v7ERTAedETSCjZ9lAiDks5rgHHHgaJpZM4L1zJY
.

--
~shriram
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/lyft/envoy/issues/415#issuecomment-282574143, or mute
the thread
https://github.com/notifications/unsubscribe-auth/AT1vm5DILo90Aacx5cyAyZxLnSwnuPGcks5rgb4KgaJpZM4L1zJY
.

I'll start looking into this during the week. I agree that submodules could be an idea to consider, but I don't think we want to be in the business of building every single transitive dependency, even if this works today, this will put future constraints on what dependencies we can add feasibly. Envoy might have a wider set of dependencies than the gRPC core libraries which use this approach.
Whatever the outcome, the Docker build will be maintained - this is necessary for CI and some developers (including me) use this as their primary workflow. It's also orthogonal to the choice of the use of (i) submodules (ii) build system (iii) IDE, we should always be able to encapsulate the build flow in a Docker image.

jamessynge@ mentions that it would also be useful to not build all tests as the only option.

Latest discussion on this and a proposal is being tracked at https://docs.google.com/a/google.com/document/d/1XG1F38tZXTaWlrDXZFNoH-0xVm0d4HlrZJ4JXbMWqHo/edit?usp=sharing

Also my +1 for a better dependencies management. Using find_package() should be the first step and submodules even better so you can still have a full static build.
It would ease up a lot setup'ing dev environment.

I started to look at adding bazel to the Docker image as the first step in Bazelifying Envoy.
Following the instructions at https://bazel.build/versions/master/docs/install.html#ubuntu led me to installing Oracle JDK 8, as Ubuntu Trusty doesn't have OpenJDK 8 support as a starter. This comes with a big scary license http://www.oracle.com/technetwork/java/javase/terms/license/index.html, IANAL and unclear if this will fly for Docker redistribution by Lyft.
It'll probably be more sane to move to a newer Ubuntu version rather than explore unofficial OpenJDK ports, does this sound sane @mattklein123?

@htuch Are you trying on Ubuntu 15.10 or 14.04? AFAIK 16.04 with OpenJDK has no problem with bazel.

This is 14.04, the version of Ubuntu used for the Docker image. If folks are on-board, I will upgrade it to something more recent like 15.10 or 16.04 where there is OpenJDK 8 support.

16.04 should be fine. If possible can we still build with GCC 4.9? I think this is available on 16.04 pretty easily, though from my own machine, there might be some build issues (I have no idea why this would be the case but I recall potentially having an issue when trying), but let's give it a shot.

We should add support to generate a textual representation of the build dependency graph once done. This will provide a sanity check that we could in future support other build systems and also provide support to those who want to carry out proprietary integrations. @mattwoodyard.

So, we have an issue with the Bazel WiP where the Istio Bazel includes Envoy in https://github.com/istio/proxy/blob/master/src/envoy/repositories.bzl#L751. When Envoy is built (using our new rules envoy_build_system.bzl, the copts that are relative to the root of the Envoy build don't make sense, since the compiler's PWD is not there.
It seems it's basically dangerous to use relative paths in copts, as they don't get adjusted appropriately when a Bazel repository is included in another project. I don't see a direct way to get Bazel to provide me useful source tree base path information either.

@htuch as part of this ticket, can we also do up some very basic docs on how to interact with bazel. I think most non-google people have never used it. Whether that is in docs, a few slides, etc. doesn't really matter to me.

Sure, I will put this together when we're at the point we can build the full Envoy binary and run the tests. It would make sense to put this in some Markdown as developer docs I reckon.

The developer-local repositories.bzl will have to depend on a private branch of protobuf at https://github.com/htuch/protobuf/tree/default-shell-env until https://github.com/google/protobuf/pull/2508 is merged.

Documenting the observed existing cmake build flags for different build types so we can then determine what the Bazel equivalents should be:
debug: -DDEBUG -DTCMALLOC -ggdb3 -fno-omit-frame-pointer -Wall -Wextra -Werror -Wnon-virtual-dtor -Woverloaded-virtual -Wold-style-cast -std=c++0x -O0 -Winvalid-pch
normal: -DNDEBUG -DTCMALLOC -ggdb3 -fno-omit-frame-pointer -Wall -Wextra -Werror -Wnon-virtual-dtor -Woverloaded-virtual -Wold-style-cast -std=c++0x -O2 -Winvalid-pch
server_only:  -DNDEBUG -DTCMALLOC -ggdb3 -fno-omit-frame-pointer -Wall -Wextra -Werror -Wnon-virtual-dtor -Woverloaded-virtual -Wold-style-cast -std=c++0x -O2  -Winvalid-pch
asan:
coverage:

So, the common cmake flags (which are also discoverable from common.cmake) are:  -ggdb3 -fno-omit-frame-pointer -Wall -Wextra -Werror -Wnon-virtual-dtor -Woverloaded-virtual -Wold-style-cast -std=c++0x -Winvalid-pch
Each build type then adds the following..
debug: -DDEBUG -DTCMALLOC -O0
normal: -DNDEBUG -DTCMALLOC -O2
server_only: -DNDEBUG -DTCMALLOC -O2 (this is really just normal with strip)
asan: -DNDEBUG -O2 -fsanitize=address
coverage: -DCOVERAGE -DNDEBUG -DTCMALLOC --coverage -O0

As link options, -static-libstdc++ -static-libgcc are also set across all build types.

Remaining items before Bazel hits cmake parity (at the request of @mattklein123, putting it here as I can't edit the top-level comment):

[ ] Setup desired production, debug, fastbuild, asan, etc. build flag and build types. Document how to get a stripped, optimized production build.
[ ] Coverage builds with Bazel
[ ] tcmalloc and gperftools external dep.
[ ] Figure out why ASAN tests fail under Bazel but not cmake
[ ] Validate all tests executed under the cmake build are included in bazel //test/...
[ ] Looks into what options exist for ccache and modules/headers to improve build performance.

@lizan You mentioned in an early comment that Bazel does well "especially for attaching debuggers". @mattklein123 and I were wondering what the best practice is for getting an interactive gdb session with a Bazel test, do you know? I'm familiar with --run_under, but there is no stdin so you have to script gdb for that.

For debugging, I think the best experience is use eclipse cdt instead of a
gdb script. That will need a make file which works locally instead of in a
docker container. Today, I have to install all the dependencies manually,
and it's cumbersome. Ideally it should be initialize all submodules and
make. All envoy dependencies are able to be downloaded by git already.
On Sat, Apr 8, 2017 at 3:12 AM htuch<EMAIL_ADDRESS>wrote:

@lizan https://github.com/lizan You mentioned in an early comment that
Bazel does well "especially for attaching debuggers". @mattklein123
https://github.com/mattklein123 and I were wondering what the best
practice is for getting an interactive gdb session with a Bazel test, do
you know? I'm familiar with --run_under, but there is no stdin so you
have to script gdb for that.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/lyft/envoy/issues/415#issuecomment-292708446, or mute
the thread
https://github.com/notifications/unsubscribe-auth/AT1vmxpdSMRHXtd2WItagEYG2zoR99yvks5rt12TgaJpZM4L1zJY
.

Thanks @fengli79. I don't think it will fly to tell developers to use Eclipse, many (including myself) prefer standard CLI tools for their development flow (without getting into religious wars over IDEs vs. editors). We also have no immediate plans to have a make file going forward, we want a 100% native Bazel build now that we've invested the time in getting to this point.

You can always use gdb with bazel test binaries, e.g. gdb bazel-bin/test/server/server_test, of course this runs test out of sandbox. I usually use gdbserver with CLion attached to it.

@lizan I believe that will not work for tests that require setup commands, env vars, etc. Is that not the case? I think it's a blocker if we cannot easily run gdb against all tests, including ones that have setup.

@mattklein123 It will work as long as we don't need the setup_cmds business in the envoy_cc_test. I think we need to get rid of setup_cmds in any case to build a single unified test binary for https://github.com/bazelbuild/bazel/issues/1118, so I'll look at this today.

@mattklein123 For tests require setup commands you might need to setup env vars manually, but it should run if you do that.
@htuch For coverage, I don't think you need a single unified test binary. FYI, we have bazel run multiple nginx-tests (perl tests runs nginx binary, all bazel built) and aggregate them into one. However, it needed some hacks, so it would be nice to see it can be solved from bazel side.

I've verified the Bazel test cases are a strict superset of those in the cmake build:
diff --git a/debug_cases.txt b/coverage_cases.txt
index ae34d64..bd26739 100644
--- a/debug_cases.txt
+++ b/coverage_cases.txt
@@ -57,6 +57,7 @@ AsyncClientImplTest.StreamAndRequest
 AsyncClientImplTest.StreamTimeout
 AsyncClientImplTest.StreamWithTrailers
 AsyncClientImplTest.Trailers
+Backward.Basic
 BadHttpRouteConfigurationsTest.BadRouteConfig
 BadHttpRouteConfigurationsTest.BadRouteEntryConfig
 BadHttpRouteConfigurationsTest.BadRouteEntryConfigPrefixAndPath
@@ -161,6 +162,23 @@ ConnectionManagerUtilityTest.UserAgentSetWhenIncomingEmpty
 ConnectionManagerUtilityTest.generateStreamId
 DateProviderImplTest.All
 DateUtil.All
+Default/ConfigSchemasTest.CheckValidationExpectation/0
+Default/ConfigSchemasTest.CheckValidationExpectation/1
+Default/ConfigSchemasTest.CheckValidationExpectation/10
+Default/ConfigSchemasTest.CheckValidationExpectation/11
+Default/ConfigSchemasTest.CheckValidationExpectation/12
+Default/ConfigSchemasTest.CheckValidationExpectation/13
+Default/ConfigSchemasTest.CheckValidationExpectation/14
+Default/ConfigSchemasTest.CheckValidationExpectation/15
+Default/ConfigSchemasTest.CheckValidationExpectation/16
+Default/ConfigSchemasTest.CheckValidationExpectation/2
+Default/ConfigSchemasTest.CheckValidationExpectation/3
+Default/ConfigSchemasTest.CheckValidationExpectation/4
+Default/ConfigSchemasTest.CheckValidationExpectation/5
+Default/ConfigSchemasTest.CheckValidationExpectation/6
+Default/ConfigSchemasTest.CheckValidationExpectation/7
+Default/ConfigSchemasTest.CheckValidationExpectation/8
+Default/ConfigSchemasTest.CheckValidationExpectation/9
 DetectorHostSinkNullImplTest.All
 DispatcherImplTest.DeferredDelete
 DnsImplTest.Cancel
@@ -191,6 +209,7 @@ DynamoRequestParser.parsePartitionIds
 DynamoRequestParser.parseTableNameBatchOperation
 DynamoRequestParser.parseTableNameSingleOperation
 DynamoUtility.PartitionIdStatString
+ExampleConfigsTest.All
 FaultFilterBadConfigTest.BadAbortPercent
 FaultFilterBadConfigTest.BadDelayDuration
 FaultFilterBadConfigTest.BadDelayPercent
@@ -854,6 +873,8 @@ SdsTest.NoHealthChecker
 SdsTest.PoolFailure
 SdsTest.Shutdown
 ServerInstanceImplTest.NoListenSocketFds
+ShTest.hotrestart_test_sh
+ShTest.route_tests_sh
 ShadowWriterImplTest.All
 SslConnectionImplTest.ClientAuthBadVerification
 SslConnectionImplTest.GetCertDigest


Leptos Book - 02_getting_started -

Describe the bug
When following along with the book
The browser doesn't render the expected "Hello, world!" and instead returns a blank page.
Leptos Dependencies
Cargo.toml:
[package]
name = "leptos-tutorial"
version = "0.1.0"
edition = "2021"

[dependencies]
leptos = "0.4.1"

To Reproduce
cargo install trunk
cargo init leptos-tutorial

rustup toolchain install nightly
rustup default nightly
rustup target add wasm32-unknown-unknown

cargo add leptos```

Follow 02_getting_started steps:
Create index.html in the root of leptos-tutorial.
Add "hello world" to main.rs

l```shell
trunk serve --open

The shell opens <IP_ADDRESS>:8080 in the browser,
rendering a blank page.
Expected behavior
Rendered text saying "Hello, world!" at localhost:8080/
Screenshots

Additional context
rustup version 1.26.0
cargo version 1.72.0-nightly
trunk version 0.17.1
Browser: Microsoft Edge Version 114.0.1823.58 (Official build) (64-bit)
installed targets for active toolchain
wasm32-unknown-unknown
x86_64-unknown-linux-gnu
active toolchain
nightly-x86_64-unknown-linux-gnu (default)
rustc 1.72.0-nightly (330727467 2023-06-29)

Thanks. This was just fixed in the docs in #1256. Use cargo add leptos --features=csr,nightly (if you're using nightly Rust) or cargo add leptos --features=csr (if you're using stable). I changed the features and forgot to update that part of the book.

Awesome! Can't wait to check it out, now.


chore: bdd-sbhg-1592448132 to 0.0.1

chore: Promote bdd-sbhg-1592448132 to version 0.0.1

[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by:
To fully approve this pull request, please assign additional approvers.
We suggest the following additional approvers:
If they are not already assigned, you can assign the PR to them by writing /assign  in a comment when ready.
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@cjxd-bot-test: The following test failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

promotion-build
04f758c2aa50d08532d245ceb96c67f9b5263401
link
/test this

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.


Move Shields recipes to "Equipment" tab in crafting table

Hello.
I don't know how to do pull requests, so please add a line
json.addProperty("category", "equipment");
at 81 line in /java/com/github/crimsondawn45/basicshields/util/ModRecipe.java
Without this it defines "Misc" category by default and it looks strange when vanilla shield is in Equipment and other shileds are in other tab with tables, food, etc.
It will look like
public static JsonObject createShieldRecipe(ArrayList<TagKey<Item>> tags, Identifier output) {
        //Creating a new json object, where we will store our recipe.
        JsonObject json = new JsonObject();
        //The "type" of the recipe we are creating. In this case, a shaped recipe.
        json.addProperty("type", "minecraft:crafting_shaped");
        //This creates:
        //"type": "minecraft:crafting_shaped"
        json.addProperty("category", "equipment");
        //This creates:
        //"category": "equipment"
       ...

Add same lines in function
public static JsonObject createShapedRecipe


Basic layergroup validation on named map creation/update

Now validation checks is an array, it's not an empty array and each layer has at least options, what do you think now? :smiley:


Spawn VS Code on demand to avoid overhead

Introduced in #4414
@code-asher may have more details.

Since code-server is currently used in the product for editors other than VS Code I think forcing all users to increase memory/CPU usage because an editor they may not use is running is a regression.


Consent to nomination by a minor

Not going to work on making this a fully sensible standalone version yet, but the use is really different.

If the person is filling it in together with the petition, it can list multiple people, and we need to ask about all of the guardians.
If the person is filling it in after the petition was filed, it's more likely to list just one person.
Statutorily, the "I don't consent" checkbox is equivalent to the Petition for Removal that we already have.

@RamiLorca going to merge this one as well


WIP: LogicalPlan::TableScan now refers to table provider by name

Which issue does this PR close?

Closes https://github.com/apache/arrow-datafusion/issues/2247.
Note that this is an early WIP and not functional yet.
I am putting up this PR in an early state to get feedback on the general approach.
Rationale for this change

The logical plan currently depends on the physical plan, which prevents us from moving the logical plan into its own crate alongside the logical expressions (which is needed in order to support subqueries, and also to better support the use case where DataFusion is being used just for SQL query planning and then using a different execution engine).
The reason that the logical plan depends on the physical plan is that LogicalPlan::TableScan has a reference to a TableProvider which has a scan method that returns ExecutionPlan.
What changes are included in this PR?

[x] TableScan struct no longer has a direct reference to a TableProvider instance. The TableProvider is looked up when needed, based on table_name.
[x] CatalogList is now passed to optimizer rules, allowing tables to be resolved during optimization
[x] TableScan now contains full_filters, partial_filters and unsupported_filters so that we can still show them in fmt::Display without having access to the TableProvider
[ ] Fix Ballista serde
[ ] Update many tests to provide a valid CatalogList

Are there any user-facing changes?

Yes, this is an API change.

@andygrove would you be able to provide color on the use case for passing CatalogList to optimizer rules / resolving tables during optimization?


Help for blocks in Functions drawer open in new tab

To Reproduce

Open a MakeCode project (in Arcade)
In the toolbox, expand "Advanced"
Open the Functions drawer
Make a function
Back in the Function drawer, right-click on your function block and choose Help
Notice the help page opens in a new tab. This also happens for the 'return' block's help page.

Expected behavior
The help page would open in the side doc panel.

covered by #2255


ID not working in listSearchableFields

Link to reproduction
pnpm dev admin
Describe the Bug
If id is included in listSearchableFields, the expected result is not returned.
To Reproduce
Using the monorepo,

Add id to listSearchableFields in test/admin/collections/Posts.ts
pnpm dev admin
Open Posts list view, try searching for a document using an ID

Payload Version
2.1.0
Adapters and Plugins
No response

I've been having the same issue as in this related bug-report: #4227 Any updates to this?
A little extra detail:
This only seems to be an issue when searching by ID on collections whose ID's are created automatically by Payload. I have several collections where the ID is created based on required fields of that record and I'm not seeing any issues when searching by ID on those collections.


Sticky plug-in not calculating stickiness when initialized programmatically.

Some odd behavior when initializing the Sticky plugin programmatically. Result is a partially initialized plug-in where changes to the DOM have been made, however the end result is not the expected behavior as stickiness is not calculated.
How to reproduce this bug:

Step one.
Attempt to initialize the plug-in programmatically, per doucmentation.

var elem = new Foundation.Sticky( $someElement );

What should happen:
Plugin should initialize and stickiness should be calculated identical to the manner that occurs when the data-sticky attribute is present on the DOM element stored in $someElement when Foundation is first initialized.
What happened instead:
Plugin initializes partly. Classes and Data attributes are added and a sticky-container wrapper is created if one didn't previously exist. However the stickiness of the element is not calculated.
Foundation Version(s) you are using:
v6.3., v6.4.
Workaround:
I've found that creating an event handler that catches "init.zf.sticky" events and forces the element to run the _calc function resolves the issue.
An example for Foundation 6.4: (where the data-sticky-container wrapper bug has been fixed)
$(document).foundation().ready( function() {
  // To keep things tidy I've assigned my intended element to a variable. Optionally,
  // I'm isolating it to the first item found, in case my selector matches more than
  // one item.
  var $header = $( '#sticky-thing' ).first();

  // This is the odd behaviour I'm reporting.. It seems as though the sizes
  // aren't being calculated when initialized programmatically. We're catching the
  // "init" event sent by the Sticky plugin when it's successfully initialized on the
  // element. Then we're forcing it to run the "_calc" function manually.
  $header.one( 'init.zf.sticky', function() {
    console.log( 'Sticky initialized!');
    $(this).foundation( '_calc', true );
  });

  // We're ready to initialize the plug-in, just like described in the documentation.
  $header.$sticky = new Foundation.Sticky( $header );
} );

Just a follow-up, this appears to also happen when Sticky is initialized in-line and options are at to act on particular breakpoints.
Per this thread on the ZF support forums:
http://foundation.zurb.com/forum/posts/53884-641-sticky-issues

We are also seeing this issue and it looks to be tied to running Foundation 6.4.x with jQuery 3.x.
import { Sticky } from "foundation-sites/js/foundation.sticky";
let sticky = new Sticky($(someElement));

Doing this in an environment that has jQuery 3.x means the stickies aren't initialized and thus do not stick. When I downgraded to jQuery 2.0 I noticed that the stickies started working. Debugging the source on each shown that the load.zf.sticky event was NOT getting fired off with jQuery 3.x. Thus a workaround that we are pursuing is adding the following after Sticky() initialization:
$(window).trigger("load.zf.sticky");

Any thoughts on what in jQuery 3.x might have caused these events to no longer be triggered in the Foundation source?
Thanks!

Hi @gaulrobe,
That's an excellent find. I've been poring through the code assuming that it had something to do with the migration Webpack. I came to a similar conclusion regarding the load.zf.sticky event, since everything that is set to happen on _init is executed correctly with the exception _set_sizes/_calc
Just to confirm, when you downgraded jQuery you just reinstalled the older npm package, correct while leaving the remainder of foundation-sites intact? Version 6.4.2?

@pandymic there may have been some other oddities going on in our code. We had been initializing the Stickies like this:
(function() {
    $(function() {
        new Sticky()
    });
}());

And that, for whatever reason was working with jQuery 2.0 and not 3.x. We got rid of the nested function definitions and the Sticky was working fine no matter the version of jQuery. Extremely odd!
We remained at Foundation 6.4.2 the entire time.

Hi, we need a codepen to reproduce this issue.


UI: Tweak tab text and icon colors

This adds a hover highlight and fades out inactive tabs.
Before

After

After (Dark)

Updated. Turns out the dark theme already had this hover effect implemented, so I removed the styling there and simplified it a bit.

Codecov Report

Merging #6760 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #6760   +/-   ##
=======================================
  Coverage   40.97%   40.97%
=======================================
  Files         421      421
  Lines       57934    57934
=======================================
  Hits        23739    23739
- Misses      31035    31036    +1
+ Partials     3160     3159    -1

Impacted Files
Coverage Δ

modules/log/event.go
64.46% <0%> (-1.53%)
:arrow_down:

modules/sync/unique_queue.go
89.28% <0%> (+10.71%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e8f4c77...61ca6eb. Read the comment docs.

Sorry, had to do one more minor tweak. Inactive tabs are faded out a tiny bit more now (.5 over .6):

Anything blocking the merge here?

@silverwind once the conflict has been resolved, I can merge this.

It's the damn CSS file as always, rebased, regenerated and force-pushed.

Merged. Thanks for your contribution 😄. I will also take this time and suggest to you that you'd make a great candidate for a maintainer of Gitea. One benefit would be you'd be able to provide reviews on other PRs. The only requirement is that you participate in one PR review every few months, or contribute code in the same time frame (which you already meet). I understand it is asking for a minor time commitment, and so please don't feel pressured to accept.

Guess I can do that. Just put up a PR to add myself to maintainers file?

@silverwind yup


pull request for e2e test at 01/12/2017 21:45:11

:white_check_mark: Validation status: passed
For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.


Add skip cases

RuntimeError: Double and complex datatype matmul is not supported in oneDNN

updated https://github.com/intel/torch-xpu-ops/issues/253


[RESOLVED] Unavailable by ICMP ping

Problem started at 06:20:23 on 2022.11.16
Problem name: Unavailable by ICMP ping
Host: VILLA CONSUELO
Severity: High
Operational data: Down (0)
Original problem ID: 4232
Event details in Zabbix: http://<IP_ADDRESS>/tr_events.php?triggerid=23167&eventid=4232

Problem has been resolved in 1m 0s at 06:21:23 on 2022.11.16
Problem name: Unavailable by ICMP ping
Host: VILLA CONSUELO
Severity: High
Original problem ID: 4232


Some emojis do not work

Some of the emojis which can be found here https://getemoji.com in the section "New 2017 Emojis released in June 2017" are not detected at all or are detected as "two emojis" (face plus modifier).
furthermore a lot of the people emojis with skin color modifier are detected incorrectly and rendered as two emojis (face plus modifier).
How can I fix this?
btw why are some huge blocks commented out in the Unicode.swift file?
I am using twemoji image files as they are supplied in the twemoji repo. I did not change the file names.
Tested with iOS 11.

Yes, admittedly the Unicode 10 standard hasn't been implemented into the framework as of now, but I'll make sure to do that as soon as possible (give it a week or so). I'll also look into Emoji 5.0 specifics at the same time.
As for the 'huge blocks' commented out in the Unicode.swift file: the code points present in the ignored code are accounted for in other methods. The commented blocks are somewhat specialised and aren't really essential to the functionality of the framework, you can read a more detailed description at line 1262 onwards in the same file.

sound great, thanks!
do you have any idea why all the emojis with the skin and gender modifiers do not seem to work? can you confirm that?

@ltblueberry0 I'll have to look into it, so give me a day or two to investigate. If you could give me specific code points at which the conversion fails, that would be very helpful.

most of these emojis are not working:
let emojica = Emojica()
somelabel.attributedText = emojica.convert(string: " 👱🏾♀ 👱🏾 👴🏾 👵🏾 👲🏾 👳🏾♀ 👳🏾 👮🏾♀ 👮🏾 👷🏾♀ 👷🏾 💂🏾♀ 💂🏾 🕵🏾♀ 🕵🏾 👩🏾⚕ 👨🏾⚕ 👩🏾🌾 👨🏾🌾 👩🏾🍳 👨🏾🍳 👩🏾🎓 👨🏾🎓 👩🏾🎤 👨🏾🎤 👩🏾🏫 👨🏾🏫 👩🏾🏭 👨🏾🏭 👩🏾💻 👨🏾💻 👩🏾💼 👨🏾💼 👩🏾🔧 👨🏾🔧 👩🏾🔬 👨🏾🔬 👩🏾🎨 👨🏾🎨 👩🏾🚒 👨🏾🚒 👩🏾✈ 👨🏾✈ 👩🏾🚀 👨🏾🚀 👩🏾⚖ 👨🏾⚖ 🤶🏾 🎅🏾 👸🏾 🤴🏾 👰🏾 🤵🏾 👼🏾 🤰🏾 🙇🏾♀ 🙇🏾 💁🏾 💁🏾♂ 🙅🏾 🙅🏾♂ 🙆🏾 🙆🏾♂ 🙋🏾 🙋🏾♂ 🤦🏾♀ 🤦🏾♂ 🤷🏾♀ 🤷🏾♂ 🙎🏾 🙎🏾♂ 🙍🏾 🙍🏾♂ 💇🏾 💇🏾♂ 💆🏾 💆🏾♂ 🕴🏾 💃🏾 🕺🏾 🚶🏾♀ 🚶🏾 🏃🏾♀ 🏃🏾 🏋🏾♀ 🏋🏾 🤸🏾♀ 🤸🏾♂ ⛹🏾♀ ⛹🏾 🤾🏾♀ 🤾🏾♂ 🏌🏾♀ 🏌🏾 🏄🏾♀ 🏄🏾 🏊🏾♀ 🏊🏾 🤽🏾♀ 🤽🏾♂ 🚣🏾♀ 🚣🏾 🏇🏾 🚴🏾♀ 🚴🏾 🚵🏾♀ 🚵🏾 🤹🏾♀ 🤹🏾♂ 🛀🏾")

(scroll to the right ;-))

Thanks! I'll get back to you shortly.

some more info:
for this example
let emojica = Emojica()
var test123 = emojica.convert(string: "👱🏾♀👱🏾")

renders 4 images instead of two. it shows 3 images for the woman and one correct one for the man. I will do some more debugging later.
events:
private func replacement(for emoji: EmojiHandler) -> NSAttributedString?
-> name "1f471-1f3fe-2640" -> no image found
private func fallback(for emoji: EmojiHandler) -> NSAttributedString
-> name "2640" -> image found
-> name "1f3fe" -> image found
-> name "1f471" -> image found
private func replacement(for emoji: EmojiHandler) -> NSAttributedString?
-> name "1f471-1f3fe.png" -> image found

@ltblueberry0
All of the above should now work with the version on the master branch, and I pushed the update to Cocoapods as well.
I'll also fix the warnings as soon as possible, so don't panic.

And as for this:

I am using twemoji image files as they are supplied in the twemoji repo. I did not change the file names.

You'll need to run the renaming script for all twemoji glyphs to work properly, just follow the instructions here.


Update Brew Terraform installation instructions

I went around in circles a little trying to work out why I couldn't get some new Terraform features to deploy. Turns out I had installed Terraform with Brew from a community maintained version, which is quite out of date.
Terraform recommend using their signed maintained installation instead: https://developer.hashicorp.com/terraform/tutorials/aws-get-started/install-cli

I will re-add the comment myself, as I'm doing a release now, so merging.


i18n(ko-KR): create fleek.mdx

Description (required)

create fleek.mdx

Related issues & labels (optional)

Closes #
Suggested label:

Lunaria Status Overview
🌕 This pull request will trigger status changes.

Learn more
By default, every PR changing files present in the Lunaria configuration's files property will be considered and trigger status changes accordingly.
You can change this by adding one of the keywords present in the ignoreKeywords property in your Lunaria configuration file in the PR's title (ignoring all files) or by including a tracker directive in the merged commit's description.

Tracked Files

Locale
File
Note

ko
guides/deploy/fleek.mdx
Localization added, will be marked as complete.

Warnings reference

Icon
Description

🔄
The source for this localization has been updated since the creation of this pull request, make sure all changes in the source have been applied.


Weights of Gigagan Upscaler

Hi @lucidrains, are the weights of gigagan released, specially for upscaler?
If weights not available then on which dataset i can train the upscaler as not mentioned in readme file. And the format of images to make it for the dataloader

@dheerajpant700 The paper seems to say that they trained on:
For text-to-image synthesis, we train our models on the union of LAION2B-en [88] and COYO-700M [8] datasets, with the exception of the 128-to1024 upsampler model trained on Adobe’s internal Stock images.
It seems to me that figuring out what image set to swap out the Adobe stock images with will be a tricky part.


resizeManager() thread memory leak

The resize manager for ConsoleEditor results in a memory leak when launched as a separate thread process. Disabling the initialization of the manager in the initialize() method prevents the memory leak. This will be dealt with later on since I plan to replace the resize manager polling thread with a Windows message loop thread.

After modifying the resize manager system to stack allocation, Visual Studio still reports a memory leak in the test program. I did further testing with threads in general within Visual Studio and I believe that the reported memory leaks are false positives. A simple thread program with no dynamic memory allocations still produced memory leaks.
I intended to replace the resize manager loop implementation with a Windows message loop to manage window resize events, but I was unable to setup the SetWinEventHook() function to only receive events from the program's console window. This is because the program itself doesn't own the console window, but rather by Windows itself. The message loop can still receive events from the console window resizing, but also receives resizing events from all programs currently running on Windows.