LARGE uploads to S3 "works" but server says:  NoSuchUpload...

Wen the server is finished with READ CHUNK it ends with:
W20140403-23:24:34.736(2)? (STDERR) NoSuchUpload: The specified upload does not exist. The upload ID may be invalid, or the upload may have been aborted or completed.
W20140403-23:24:34.737(2)? (STDERR)     at Request.extractError (/Users/kjetil/.meteorite/packages/cfs-s3/CollectionFS/Meteor-cfs-s3/8db294ab28729e9dd8d49daaa7d8fdf144abda1a/.build/npm/node_modules/aws-sdk/lib/services/s3.js:235:35)
When I check the bucket, the 1,7 GB file is there! (using chunkSize 320).
This only happens when uploading large video files.

Hi,
Has anyone had any luck at all uploading files greater than 5MB onto S3 using cfs:s3? As of 10 Jan 2015, I'm still encountering this issue.
Any help will be very much appreciated.
Server side:
FS.debug = true;

var fileStore = new FS.Store.S3("files", {
	// region: 'ap-southeast-1',
	accessKeyId: 'xxx',
	secretAccessKey: 'xxx',
	bucket: 'files'
});

Uploads = new FS.Collection("files", {
	stores: [fileStore],
	chunkSize: 2048000
});

Meteor.startup(function() {
	Uploads.allow({
		insert: function(userId, doc){
			return true;
		},
		update: function(userId, doc, fields, modifier) {
			return true;
		},
		remove: function (userId, doc){
			return true;
		},
		download: function () {
			return true;
		}
	});
});

Client side:
var fileStore = new FS.Store.S3("files");

Uploads = new FS.Collection("files", {
	stores: [fileStore],
	chunkSize: 2048000
});

With FS.debug = true, the server side console looks like this:
I20150110-04:55:32.064(8)? FileWorker ADDED - calling deleteChunks for JzQGCRxeyaD7gP6ha
I20150110-04:55:32.067(8)? _tempstore FileSystem mounted on: /Users/ethans/Desktop/dk/dk-atlas-web/trunk/src/.meteor/local/cfs/files/_tempstore
I20150110-04:55:32.067(8)? TempStore is mounted on storage.filesystem
I20150110-04:55:32.079(8)? FS.HTTP.unmount:
I20150110-04:55:32.080(8)? {}
I20150110-04:55:32.081(8)? Registered HTTP method URLs:
I20150110-04:55:32.081(8)? /cfs/files/:collectionName/:id/:filename
I20150110-04:55:32.081(8)? /cfs/files/:collectionName/:id
I20150110-04:55:32.081(8)? /cfs/files/:collectionName
=> Meteor server restarted
I20150110-04:56:13.074(8)? token: eyJhdXRoVG9rZW4iOiJ1aV9Fd3FTVEpjeFNCbC1IY25BSlBBYndPV0JCTTRyZE41N3lsZ3plSWZ0In0=
I20150110-04:56:13.076(8)? HTTP PUT (update) handler received chunk:  0
I20150110-04:56:13.077(8)? GET FILERECORD: XF5riet3EdZ3Zwg8u
I20150110-04:56:13.081(8)? createWriteStream _tempstore, internal: true
I20150110-04:56:13.082(8)? createWriteStreamForFileKey _tempstore
I20150110-04:56:13.094(8)? -----------FINISH STREAM _tempstore
I20150110-04:56:13.095(8)? SA FileSystem - DONE!! fileKey: "files-XF5riet3EdZ3Zwg8u-0.chunk"
I20150110-04:56:13.096(8)? -----------STORED STREAM _tempstore
I20150110-04:56:13.096(8)? -----------CLOSE STREAM _tempstore
I20150110-04:56:13.098(8)? TempStore progress: Received 1 of 5 chunks for Kevin Pool - Tibco - Big Fast Operational Data.pdf
I20150110-04:56:13.098(8)? UPDATE: {"$set":{"chunkCount":1}}
I20150110-04:56:13.567(8)? token: eyJhdXRoVG9rZW4iOiJ1aV9Fd3FTVEpjeFNCbC1IY25BSlBBYndPV0JCTTRyZE41N3lsZ3plSWZ0In0=
I20150110-04:56:13.574(8)? HTTP PUT (update) handler received chunk:  1
I20150110-04:56:13.575(8)? GET FILERECORD: XF5riet3EdZ3Zwg8u
I20150110-04:56:13.584(8)? createWriteStream _tempstore, internal: true
I20150110-04:56:13.585(8)? createWriteStreamForFileKey _tempstore
I20150110-04:56:13.597(8)? -----------FINISH STREAM _tempstore
I20150110-04:56:13.598(8)? SA FileSystem - DONE!! fileKey: "files-XF5riet3EdZ3Zwg8u-1.chunk"
I20150110-04:56:13.598(8)? -----------STORED STREAM _tempstore
I20150110-04:56:13.599(8)? -----------CLOSE STREAM _tempstore
I20150110-04:56:13.602(8)? TempStore progress: Received 2 of 5 chunks for Kevin Pool - Tibco - Big Fast Operational Data.pdf
I20150110-04:56:13.602(8)? UPDATE: {"$set":{"chunkCount":2}}
I20150110-04:56:14.075(8)? token: eyJhdXRoVG9rZW4iOiJ1aV9Fd3FTVEpjeFNCbC1IY25BSlBBYndPV0JCTTRyZE41N3lsZ3plSWZ0In0=
I20150110-04:56:14.077(8)? HTTP PUT (update) handler received chunk:  2
I20150110-04:56:14.078(8)? GET FILERECORD: XF5riet3EdZ3Zwg8u
I20150110-04:56:14.082(8)? createWriteStream _tempstore, internal: true
I20150110-04:56:14.083(8)? createWriteStreamForFileKey _tempstore
I20150110-04:56:14.090(8)? -----------FINISH STREAM _tempstore
I20150110-04:56:14.092(8)? SA FileSystem - DONE!! fileKey: "files-XF5riet3EdZ3Zwg8u-2.chunk"
I20150110-04:56:14.092(8)? -----------STORED STREAM _tempstore
I20150110-04:56:14.092(8)? -----------CLOSE STREAM _tempstore
I20150110-04:56:14.097(8)? TempStore progress: Received 3 of 5 chunks for Kevin Pool - Tibco - Big Fast Operational Data.pdf
I20150110-04:56:14.098(8)? UPDATE: {"$set":{"chunkCount":3}}
I20150110-04:56:14.612(8)? token: eyJhdXRoVG9rZW4iOiJ1aV9Fd3FTVEpjeFNCbC1IY25BSlBBYndPV0JCTTRyZE41N3lsZ3plSWZ0In0=
I20150110-04:56:14.614(8)? HTTP PUT (update) handler received chunk:  3
I20150110-04:56:14.614(8)? GET FILERECORD: XF5riet3EdZ3Zwg8u
I20150110-04:56:14.616(8)? createWriteStream _tempstore, internal: true
I20150110-04:56:14.617(8)? createWriteStreamForFileKey _tempstore
I20150110-04:56:14.624(8)? -----------FINISH STREAM _tempstore
I20150110-04:56:14.630(8)? SA FileSystem - DONE!! fileKey: "files-XF5riet3EdZ3Zwg8u-3.chunk"
I20150110-04:56:14.632(8)? -----------STORED STREAM _tempstore
I20150110-04:56:14.632(8)? -----------CLOSE STREAM _tempstore
I20150110-04:56:14.633(8)? TempStore progress: Received 4 of 5 chunks for Kevin Pool - Tibco - Big Fast Operational Data.pdf
I20150110-04:56:14.633(8)? UPDATE: {"$set":{"chunkCount":4}}
I20150110-04:56:15.075(8)? token: eyJhdXRoVG9rZW4iOiJ1aV9Fd3FTVEpjeFNCbC1IY25BSlBBYndPV0JCTTRyZE41N3lsZ3plSWZ0In0=
I20150110-04:56:15.078(8)? HTTP PUT (update) handler received chunk:  4
I20150110-04:56:15.078(8)? GET FILERECORD: XF5riet3EdZ3Zwg8u
I20150110-04:56:15.080(8)? createWriteStream _tempstore, internal: true
I20150110-04:56:15.081(8)? createWriteStreamForFileKey _tempstore
I20150110-04:56:15.086(8)? -----------FINISH STREAM _tempstore
I20150110-04:56:15.087(8)? SA FileSystem - DONE!! fileKey: "files-XF5riet3EdZ3Zwg8u-4.chunk"
I20150110-04:56:15.087(8)? -----------STORED STREAM _tempstore
I20150110-04:56:15.088(8)? -----------CLOSE STREAM _tempstore
I20150110-04:56:15.092(8)? TempStore progress: Received 5 of 5 chunks for Kevin Pool - Tibco - Big Fast Operational Data.pdf
I20150110-04:56:15.092(8)? UPDATE: {"$set":{"uploadedAt":"2015-01-09T20:56:15.092Z"},"$unset":{"chunkCount":1,"chunkSum":1,"chunkSize":1}}
I20150110-04:56:15.093(8)? Kevin Pool - Tibco - Big Fast Operational Data.pdf was successfully uploaded. You are seeing this informational message because you enabled debugging and you have not defined any listeners for the "uploaded" event on the files collection.
I20150110-04:56:15.099(8)? FileWorker ADDED - calling saveCopy files for XF5riet3EdZ3Zwg8u
I20150110-04:56:15.100(8)? saving to store files
I20150110-04:56:15.100(8)? createWriteStream files, internal: false
I20150110-04:56:15.100(8)? createWriteStreamForFileKey files
I20150110-04:56:15.135(8)? FS.TempStore creating read stream for XF5riet3EdZ3Zwg8u
I20150110-04:56:15.139(8)? createReadStream _tempstore
I20150110-04:56:15.140(8)? createReadStreamForFileKey _tempstore
I20150110-04:56:15.173(8)? createReadStream _tempstore
I20150110-04:56:15.173(8)? createReadStreamForFileKey _tempstore
I20150110-04:56:15.177(8)? createReadStream _tempstore
I20150110-04:56:15.178(8)? createReadStreamForFileKey _tempstore
I20150110-04:56:15.182(8)? createReadStream _tempstore
I20150110-04:56:15.182(8)? createReadStreamForFileKey _tempstore
I20150110-04:56:15.196(8)? createReadStream _tempstore
I20150110-04:56:15.197(8)? createReadStreamForFileKey _tempstore
I20150110-04:56:19.491(8)? -----------FINISH STREAM files
I20150110-04:56:19.492(8)? -----------FINISH STREAM files
I20150110-04:56:19.646(8)? SA S3 - DONE!!
I20150110-04:56:19.646(8)? -----------STORED STREAM files
I20150110-04:56:19.646(8)? -----------STORED STREAM files
I20150110-04:56:19.646(8)? SA files stored files/XF5riet3EdZ3Zwg8u-Kevin Pool - Tibco - Big Fast Operational Data.pdf
I20150110-04:56:19.647(8)? FS.File._saveChanges: files
I20150110-04:56:19.647(8)? UPDATE: {"$set":{"copies.files":{"name":"Kevin Pool - Tibco - Big Fast Operational Data.pdf","type":"application/pdf","size":5275648,"key":"files/XF5riet3EdZ3Zwg8u-Kevin Pool - Tibco - Big Fast Operational Data.pdf","updatedAt":"2015-01-09T20:56:19.645Z","createdAt":"2015-01-09T20:56:19.645Z"}}}
I20150110-04:56:19.648(8)? Kevin Pool - Tibco - Big Fast Operational Data.pdf was successfully saved to the files store. You are seeing this informational message because you enabled debugging and you have not defined any listeners for the "stored" event on the files collection.
I20150110-04:56:19.652(8)? FileWorker ADDED - calling deleteChunks for XF5riet3EdZ3Zwg8u
I20150110-04:56:19.653(8)? ---SA REMOVE
I20150110-04:56:19.653(8)? ---SA REMOVE
I20150110-04:56:19.654(8)? ---SA REMOVE
I20150110-04:56:19.654(8)? ---SA REMOVE
I20150110-04:56:19.654(8)? ---SA REMOVE
I20150110-04:56:22.659(8)? SA S3 - ERROR!!
I20150110-04:56:22.661(8)? -----------ERROR STREAM files The specified upload does not exist. The upload ID may be invalid, or the upload may have been aborted or completed.
I20150110-04:56:22.661(8)? -----------ERROR STREAM files The specified upload does not exist. The upload ID may be invalid, or the upload may have been aborted or completed.
W20150110-04:56:22.661(8)? (STDERR)
W20150110-04:56:22.662(8)? (STDERR) /Users/ethans/.meteor/packages/cfs_s3/.<IP_ADDRESS>lql3wn++os+web.browser+web.cordova/npm/node_modules/aws-sdk/lib/request.js:32
W20150110-04:56:22.662(8)? (STDERR)           throw err;
W20150110-04:56:22.662(8)? (STDERR)                 ^
W20150110-04:56:22.676(8)? (STDERR) Error: Error storing file to the files store: The specified upload does not exist. The upload ID may be invalid, or the upload may have been aborted or completed.
W20150110-04:56:22.677(8)? (STDERR)     at [object Object].<anonymous> (packages/cfs:collection/common.js:88:1)
W20150110-04:56:22.677(8)? (STDERR)     at [object Object].emit (events.js:106:17)
W20150110-04:56:22.677(8)? (STDERR)     at Writable.<anonymous> (packages/cfs:storage-adapter/storageAdapter.server.js:203:1)
W20150110-04:56:22.678(8)? (STDERR)     at Writable.emit (events.js:117:20)
W20150110-04:56:22.678(8)? (STDERR)     at Response.<anonymous> (packages/cfs:s3/s3.upload.stream2.js:152:1)
W20150110-04:56:22.678(8)? (STDERR)     at Request.<anonymous> (/Users/ethans/.meteor/packages/cfs_s3/.<IP_ADDRESS>lql3wn++os+web.browser+web.cordova/npm/node_modules/aws-sdk/lib/request.js:350:18)
W20150110-04:56:22.678(8)? (STDERR)     at Request.callListeners (/Users/ethans/.meteor/packages/cfs_s3/.<IP_ADDRESS>lql3wn++os+web.browser+web.cordova/npm/node_modules/aws-sdk/lib/sequential_executor.js:100:18)
W20150110-04:56:22.679(8)? (STDERR)     at Request.emit (/Users/ethans/.meteor/packages/cfs_s3/.<IP_ADDRESS>lql3wn++os+web.browser+web.cordova/npm/node_modules/aws-sdk/lib/sequential_executor.js:77:10)
W20150110-04:56:22.679(8)? (STDERR)     at Request.emit (/Users/ethans/.meteor/packages/cfs_s3/.<IP_ADDRESS>lql3wn++os+web.browser+web.cordova/npm/node_modules/aws-sdk/lib/request.js:604:14)
W20150110-04:56:22.679(8)? (STDERR)     at Request.transition (/Users/ethans/.meteor/packages/cfs_s3/.<IP_ADDRESS>lql3wn++os+web.browser+web.cordova/npm/node_modules/aws-sdk/lib/request.js:21:12)

I am also seeing the same issue (100+ MB file and cfs:s3). Investigating.

@aldeed, could you point me in the direction of where this error message is generated? I couldn't find it searching the various repos.
Error storing file to the <storename> store: The specified upload does not exist. The upload ID may be invalid, or the upload may have been aborted or completed.

Update: I couldn't fix it by checking out previous versions of my app (even though I have reason to believe large uploads worked last month), by downgrading various packages and dependencies, or by forking cfs:s3 to depend on the latest aws-sdk.

I'm having the exact same issue. I was thinking there might be a mistake with the incrementation of the partNumber or similar and that it tries to upload an extra chunk after the last one. Tried to fiddle with it, but alas no solution. I might dive into the code a bit more, but in the meantime any help/insights would be awesome.

@Nlammertyn The s3 storage adapter got 3 different implementations, its currently using the "correct" streaming method - but theres a chunk limit at 5mb on s3 uploads so I'm thinking theres an issue with the partial upload.
We could switch to one of the other solutions (comments in the package.js) but I havent got time atm to look in to it.
Any attempts on debugging this would be awesome - if anybody feels up to it it would be nice to have some unit test/qa test for storage adapters in general.

@raix Thanks for the reply, I'll test out the other methods tomorrow. If one of them works I'll use that for now and I'll take a look at the stream2 implementation as I do agree that method is ideal. Will keep you posted.

I found the part where something goes wrong: https://github.com/CollectionFS/Meteor-cfs-s3/blob/master/s3.upload.stream2.js#L140
It's executed two times. Once when the next to last chunk has been uploaded and once when the last one has been uploaded.
In other words uploadedSize === receivedSize when it shouldn't yet.
I'll go over the calculations of both tomorrow and should be able to work out the problem

Awesome, thanks @Nlammertyn!

Kudos @Nlammertyn. FWIW I just made an awful grody hack to ignore the initial execution on large files, and it fixes it for me (so I have faith that if you figure out the underlying double execution issue that'll solve the problem).

@Nlammertyn cool :+1:

Fixed it, I'l fork and make a pull request now.

For those interested: https://github.com/CollectionFS/Meteor-cfs-s3/pull/44

This also resolves issues #243 (definitely the best of the 3 now), #254, #464 and #481


fix: delay avatar hover card hooks rendering

Why
While working on Trending 2.0 and the "Claimed by" component, I realized that our AvatarHoverCard for the web was spamming our servers. Although Radix-UI is clever enough to render the Avatar Card lazily, we made the mistake of putting all the data fetching hooks in the root component. This resulted in every small avatar triggering 2 API fetches, and at times, we had more than 20 visible Avatar Cards

How
I moved the content of the Avatar Hover Card into a separate component, and now both the fetches and the content are rendered lazily, resulting in a nearly 30% reduction in XHR requests on the web. Also optimized the closing behavior a bit.

Test Plan

@alantoa @intergalacticspacehighway merging, since its a tiny change with big impact.

Good catch sir 🫡


Imgbot savings, v2

@edent This replaces #482 to account for latest minimal repo SVGs.  This still saves ~40 bytes over 15 SVGs, again mostly whitespace, but the odd leading 0.→., &c, conversion.  Thoughts?

Thanks. Because of the formatting, it'll take me a little time to go through these.

@edent A couple thoughts:

I'd like to open an issue upstream w/ SVGO &/or ImgBot re: the newline issue.  I understood what you meant by the replacing the CR LF line endings w/ \n.  Technically most of the time, CR=\r & LF=\n, so I think there might/should be an option to preserve the newline while not wasting bytes.
Once that's resolved, would you be interested in ImgBot?   I realize this PR was onerous, but I think it's because it was so many files & the above \nproblem.  If so, it wouldn't be bad to merge the .imgbotconfig before subscribing.  @ worst, it creates only PRs & an imgbot branch, anyway — no automatic merges.

Yes, very happy to have imgbot running - if it can preserve the existing newlines.
This is a brilliant resource and I want to thank you for taking the time to submit these PRs.

I've opened https://github.com/svg/svgo/issues/1300 re: the \n (& I threw in \t for good measure) concern.


Query regarding penalizing incorrect detections

My data set has only one object per image. The background of each image is white. Whereas my test set can have images on random background (includes text besides other shapes).
My query is do you penalize incorrect detection on the validation set?
I mean in case, my validation set had random objects and text and if they get wrongly detected as one of the classes, whether there would be any penalty imposed

@prantiksen4 Yes, they do get penalized. You may consider adding random backgrounds to the images in the training set.

Thanks for the reply. Actually a few undesired objects are also getting detected in my test set. My training set has nicely cropped images of just the object. So i suppose I need to have a few images similar to the test images so that it penalizes incorrect detection and learns weights that neglect them.


fix(aws): raise NoMatchingProductType if no product found to download

Handle correctly situations with aws plugin when no data to download is found on s3.

Added test to verify that NoMatchingProductType is raised.


Error executing HWI - F39 Silverblue

Hi everyone, I'm on Fedora 39 Silverblue and I'm using the latest version of Sparrow (1.8.2).
I'm running Sparrow binary extracted from the tar.gz file.
I have this error when trying to connect my hardware wallet:

Here's the stack trace:
2024-02-11 15:29:14,770 ERROR Error executing hwi-2.3.1
java.io.IOException: [5519] Error loading Python lib '/tmp/_MEIwXyyyE/libpython3.9.so.1.0': dlopen: libcrypt.so.1: cannot open shared object file: No such file or directory

	at com.sparrowwallet.sparrow@1.8.2/com.sparrowwallet.sparrow.io.Hwi.getProcessOutput(Unknown Source)
	at com.sparrowwallet.sparrow@1.8.2/com.sparrowwallet.sparrow.io.Hwi.execute(Unknown Source)
	at com.sparrowwallet.sparrow@1.8.2/com.sparrowwallet.sparrow.io.Hwi.enumerateUsb(Unknown Source)
	at com.sparrowwallet.sparrow@1.8.2/com.sparrowwallet.sparrow.io.Hwi.enumerate(Unknown Source)
	at com.sparrowwallet.sparrow@1.8.2/com.sparrowwallet.sparrow.io.Hwi$ScheduledEnumerateService$1.call(Unknown Source)
	at com.sparrowwallet.sparrow@1.8.2/com.sparrowwallet.sparrow.io.Hwi$ScheduledEnumerateService$1.call(Unknown Source)
	at javafx.graphics@18/javafx.concurrent.Task$TaskCallable.call(Unknown Source)
	at java.base/java.util.concurrent.FutureTask.run(Unknown Source)
	at javafx.graphics@18/javafx.concurrent.Service.lambda$executeTask$6(Unknown Source)
	at java.base/java.security.AccessController.doPrivileged(Unknown Source)
	at javafx.graphics@18/javafx.concurrent.Service.lambda$executeTask$7(Unknown Source)
	at java.base/java.util.concurrent.ThreadPoolExecutor.runWorker(Unknown Source)
	at java.base/java.util.concurrent.ThreadPoolExecutor$Worker.run(Unknown Source)
	at java.base/java.lang.Thread.run(Unknown Source)
2024-02-11 15:30:05,873 ERROR Error executing hwi-2.3.1
java.io.IOException: [5532] Error loading Python lib '/tmp/_MEIaqX8t9/libpython3.9.so.1.0': dlopen: libcrypt.so.1: cannot open shared object file: No such file or directory

Obviously the file is not existent, but why the library is searched in the /tmp folder?

Obviously the file is not existent, but why the library is searched in the /tmp folder?

The reason for the /tmp folder is that HWI uses pyinstaller, which extracts a new executable to a temporary folder every time it runs. It's not searching for libcrypt in the /tmp folder, but libcrypt is a dependency that libpython3.9 is looking for from the /tmp folder where it was extracted.
It looks like you'll need to install libcrypt separately. See https://support.oneidentity.com/safeguard-authentication-services/kb/4259532/fedora-32-error-opt-quest-bin-vastool-error-while-loading-shared-libraries-libcrypt-so-1-cannot-open-shared-object-file-no-such-file-or-directory for example.

Thank you for your response.
I fixed by installing libxcrypt-compat inside the toolbox (since Silverblue is an immutable system) using sudo dnf install libxcrypt-compat and running Sparrow inside the toolbox.
The hardware wallet is working fine since I was able to sign a message with Sparrow.


Add graceful restart to BIRD config, and use confd prefix to minimize config churn

All the requests for comments on the v4 template apply to the v6 template too. Happy for you to merge once you've beefed up the commenting a bit.


Update URL for cw20-stake-reward-distributor

Line 19 - URL was pointing to contracts/staking/cw20-stake-external-rewards Changed to contracts/staking/cw20-stake-reward-distributor

Codecov Report
Base: 90.65% // Head: 90.65% // No change to project coverage :thumbsup:

Coverage data is based on head (00b4157) compared to base (403f5cf).
Patch has no changes to coverable lines.

:mega: This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more
Additional details and impacted files
@@           Coverage Diff           @@
##             main     #633   +/-   ##
=======================================
  Coverage   90.65%   90.65%
=======================================
  Files          56       56
  Lines        4835     4835
=======================================
  Hits         4383     4383
  Misses        452      452

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

thank you!!!


fixes #2239 addes suricata eve.json as input

fixed the spelling issue thanks for the quick feedback

Merged, thanks!


Daemon crashes right at the beginning

Describe the bug Sometimes the daemon seems to crash at the beginning with no apparent reason. And the logs are not useful since it panics
There are two errors here. One is the original error that prevents the daemon to load, and then is the panic for not handling the error correctly the

Initial error it's usually because some port is already taken (listen tcp :56002: bind: address already in use). Weirdly enough when I bypassed the below point 2, I saw that it was trying to listen the grpc server in a port that was supposedly taken. But it was not. After changing the port it worked (of course) but when I changed back the port to the one that was supposedly taken it worked as well.
Panic: Daemon panics here on nil a.clean, when one of the initializations did not succeed since setupLogging is at the bottom of the initializations. However setup logging needs some of the servers to log their ports.

julio@workstation:~/Documents/mintter$ ./dev run-backend -site.hostname http://<IP_ADDRESS>:56001 --http-port 56001 -grpc-port 56002 -p2p.port 56000 -repo-path /home/julio/.mttsite -site.owner-id bahezrj4iaqacicabciqfnrov4niome6csw43r244roia35q6fiak75bmapk2zjudj3uffea -site.title testSite -identity.no-account-wait -syncing.disable-inbound
panic: runtime error: invalid memory address or nil pointer dereference
[signal SIGSEGV: segmentation violation code=0x1 addr=0x0 pc=0x1228aff]

goroutine 1 [running]:
mintter/backend/daemon.loadApp.func1()
        /home/julio/Documents/mintter/plz-out/tmp/backend/mintterd._build/backend/daemon/daemon.go:122 +0x3f
mintter/backend/daemon.loadApp({0x1b3d690, _}, {0xdac1, 0xdac2, {0x7fff2e19716c, 0x14}, {{0x1b27d68, 0x0}, 0x1}, {0x0}, ...}, ...)
        /home/julio/Documents/mintter/plz-out/tmp/backend/mintterd._build/backend/daemon/daemon.go:157 +0x94f
mintter/backend/daemon.Load({0x1b3d690, _}, {0xdac1, 0xdac2, {0x7fff2e19716c, 0x14}, {{0x1b27d68, 0x0}, 0x1}, {0x0}, ...}, ...)
        /home/julio/Documents/mintter/plz-out/tmp/backend/mintterd._build/backend/daemon/daemon.go:106 +0x185
main.main.func1()
        /home/julio/Documents/mintter/plz-out/tmp/backend/mintterd._build/backend/cmd/mintterd/main.go:68 +0x68f
github.com/burdiyan/go/mainutil.Run(0xc0000061a0?)
        /home/julio/go/pkg/mod/github.com/burdiyan/go/mainutil@v0.0.0-20200124222818-6f87e0e684b6/mainutil.go:28 +0x22
main.main()
        /home/julio/Documents/mintter/plz-out/tmp/backend/mintterd._build/backend/cmd/mintterd/main.go:26 +0x25
    ```

I have some ideas for refactoring all of this init logic + lazy initialization in a much nicer way (I think :)), which should get rid of all those nasty futures and other complexity. So this issue might get fixed as a side effect of this refactor. But I won't do it until the breaking change is finished.
So, if this error only happens when there is actually an error (like a port being used), is it tolerable enough to wait couple weeks?
Regarding the seemingly used port, it might be that there was a zombie process left, which then somehow got terminated, that's why the second time it worked ¯_(ツ)_/¯

Yes, It's fine to do the rework after the breaking change. As for the used port, I don't know. Because I ran lsof -i -P -n | grep LISTEN while getting the port error and the output was
systemd-r     858 systemd-resolve   13u  IPv4    31511      0t0  TCP <IP_ADDRESS>:53 (LISTEN)
sshd         1108            root    3u  IPv4    37867      0t0  TCP *:22 (LISTEN)
sshd         1108            root    4u  IPv6    37869      0t0  TCP *:22 (LISTEN)
mysqld       1138           mysql   21u  IPv4    34411      0t0  TCP <IP_ADDRESS>:3306 (LISTEN)
postgres     1215        postgres    3u  IPv4    39169      0t0  TCP <IP_ADDRESS>:5433 (LISTEN)
docker-pr    1891            root    4u  IPv4    41752      0t0  TCP *:3456 (LISTEN)
docker-pr    1899            root    4u  IPv6    42928      0t0  TCP *:3456 (LISTEN)
Discord    233927           julio  153u  IPv4  3791949      0t0  TCP <IP_ADDRESS>:6463 (LISTEN)
code      1550996           julio   65u  IPv6 23531307      0t0  TCP *:43155 (LISTEN)
code      1550996           julio   71u  IPv4 23572504      0t0  TCP <IP_ADDRESS>:44259 (LISTEN)
java      1551724           julio   57u  IPv4 23531327      0t0  TCP <IP_ADDRESS>:64120 (LISTEN)
cupsd     1605448            root    6u  IPv6 24451643      0t0  TCP [::1]:631 (LISTEN)
cupsd     1605448            root    7u  IPv4 24451644      0t0  TCP <IP_ADDRESS>:631 (LISTEN)
mintterd- 1669553           julio   39u  IPv6 25716066      0t0  TCP *:55002 (LISTEN)
mintterd- 1669553           julio   40u  IPv6 25716067      0t0  TCP *:55001 (LISTEN)
mintterd- 1669553           julio   42u  IPv4 25715322      0t0  TCP *:55000 (LISTEN)
mintterd- 1669553           julio   45u  IPv6 25715323      0t0  TCP *:55000 (LISTEN)

So no one was listening on 56002... I had another daemon running on different ports, though. However I am not the only one experiencing those crashes (related https://github.com/mintterteam/mintter/issues/740), since @GaboHBeaumont commented me, that sometimes the app keep crashing at the beginning and somehow at the nth trial it worked. I' am sure it had to do with the lazy initialization of the interfaces, because was right at the beginning. Nevertheless, when we can trace the actual error (instead of the panic) it would be much easier to debug.

I think this was solved with @burdiyan breaking change. I will close it until we come across again.

This is not solved, just open two daemons at the same time and de second one will panic


How to change the size of this circle?

Today's circle and the circle of the selected date look too big.

This isn't customizable currently. You can only change its color. I didn't think that this could be useful.
Would you like to give PR for this one?

Oh，Thank you

Hi, I need this update as well.

Was this ever fixed?  This circle gets cut off on some devices for me.


enabling Flexbox Mode gives an ActionView::Template::Error

Using Foundation <IP_ADDRESS> installed via Gem, I enable flex box as per the documentation and my site won't load. It's getting stuck loading application.css.scss.
_settings.scss
$global-flexbox: true;
foundation_and_overrides.scss
// @include foundation-grid;
@include foundation-flex-grid;
@include foundation-flex-classes;
returns the following error:

ActionView::Template::Error (Properties are only allowed within rules, directives, mixin includes, or other properties.):
6:
7:     <%= content_for?(:title) ? yield(:title) : "Title" %>
8:
9:     <%= stylesheet_link_tag    "application" %>
10:     <%= javascript_include_tag "application", 'data-turbolinks-track' => true %>
11:     <%= csrf_meta_tags %>
app/views/layouts/application.html.erb:9:in `_app_views_layouts_application_html_erb__73442163__584527848'

Further investigation seems that the setting of $global-flexbox: true; in _settings.scss is the main cause of the problem.
If I set this to false but leave @include foundation-flex-grid; and @include foundation-flex-classes; the site will load.
I also reordered the includes as was mentioned here: https://github.com/zurb/foundation-sites/issues/8278

Upon further investigation I found enabling flexbox mode as per the documentation http://foundation.zurb.com/sites/docs/flexbox.html
Then, if I comment out @include foundation-top-bar assets are compiled and the site loads.
Looking at localhost:3000/assets/application.css I can see display: flex is set for numerous things but obviously top-bar is missing.
So it appears the error lines within _top_bar.scss.

you are right; there is an open issue https://github.com/zurb/foundation-sites/issues/8325 for this

I'm closing this as not related to foundation-rails.
Thanks :kissing:


Improve terminal navigation

Navigating to the right terminal for me is harder than it should be.
I can switch to the terminal panel easily, but from there I need to get to the right terminal. I can use shortcuts for that but they are "unstable" because they depend on the sequence in which I opened my terminals.
I can use Open View but it's suboptimal because it's a long list. Good thing is terminals have ids, so I can use it to filter the list quickly.
I'd like to get an Open Terminal command that opens a quick pick just for terminals. It should also be available as global command from Cmd+P? as terminal.

This should be relatively straightforward to implement, at least using the "title" information we expose at the moment. The problem is that the title information is not very descriptive currently as it shows the current program on Linux/macOS (eg. bash, node, python) on Windows it will only ever show the shell that the terminal was launched with, so unless you're using an extension such as https://marketplace.visualstudio.com/items?itemName=Tyriar.shell-launcher, it will only ever be "powershell.exe" for example (whatever the selected shell is).
So to clarify, on Linux/macOS you might get a list like this:
1: /bin/bash
2: node
3: /bin/bash

On Windows:
1: powershell.exe
2: powershell.exe
3: powershell.exe

I can imagine this being a lot more useful when we improve the information attached to the terminal. Ideally this would contain something like "(program) (args) (cwd)". There is no event we can hook into for fetching the cwd, however on Linux/macOS we can use a trick with the lsof command to fetch the cwd:
# 12345 is the PID of the shell
lsof -p 12345 | grep cwd | tr -s ' ' | cut -d ' ' -f9-

I'm not sure if this works well with nested shells (launching zsh from bash).
For Windows, I'm not aware of how to get this information apart from scanning each line for a prompt with a regex which is bad for perf and not very reliable.

There is also the issue of finding a keybinding for this, the reason there aren't keybindings for most of the terminal commands is because most good keybindings were already taken at the time they were added.

Being able to use the cwd would be a nice step forward. Another thought: We now have the Rename Terminal command. If we find a way to make this easier discoverable - maybe we could integrate it into this switcher itself - it would give users a way to work around the non-descriptive names.

@kieferrm not sure we have buttons in the quick open right now, would this be a new concept?

As a first step, I was thinking about including the rename terminal action in the quick-pick list below a separator. That  would make it easier discoverable.

Ah OK. Currently it renamed the current terminal, do you think it should launch it's own quick pick as well?

We have to try it out what would work best/ Since the issue we want to solve is that all terminals are named the same, showing a quick pick with terminal names that are all the same does not really help.

Fixed in #30968


Convert FERC-714 ETL to use Dagster

Create dagster assets for the raw and transformed FERC 714 data so the partially cleaned tables can be accessed in the pudl.sqlite DB. Once the ETL has been converted to dagster #2104 we can start to persist partially cleaned tables from new data sources.
- [x] Create a `@multi_asset` in `pudl.extract.ferc714` that extracts the raw data.
- [x] Convert `pudl.transform.ferc714.respondent_id_ferc714()` into an `@asset`
- [x] Convert `pudl.transform.ferc714.demand_hourly_pa_ferc714()` into an `@asset`
- [x] Ensure `respondent_id_ferc714` loads into SQLite
- [ ] ❌ Ensure `demand_hourly_pa_ferc714` loads into SQLite (`utc_datetime` failing CHECK constraint???)
- [x] Remove the `PudlTabl.etl_ferc714()` method.
- [x] Remove `PudlTabl.etl_ferc714()` methods for the truly raw tables.
- [x] Update `PudlTabl` methods for finished tables to read from the DB
- [ ] Update FERC-714 output tests to use the DB.
- [ ] Modify `Ferc714Settings` to reflect current situation (no tables... what about years?)
- [ ] Verify that `pudl.output.ferc714` methods still work.
- [ ] Verify that `state_demand` still works.
- [ ] Update README and RTD documentation to reflect availability of FERC-714.
- [ ] Update release notes.

Out of Scope

Creating metadata for the raw tables. If we feel the need to store the raw ferc714 tables in the database we'll have to create resource metadata for the raw tables.
Any additional transformation of FERC-714 data.

I don't think there's any harvesting that needs to be done on these tables.
There are some extremely useful FERC 714 output tables which we should load into the DB alongside the PudlTabl outputs, see pudl.output.ferc714.Respondents and maybe also pudl.analysis.service_territory
Right now only respondent_id_ferc714 and dhpa_ferc714 (and maybe a table linking FERC 714 to EIA) are getting transformed, so to load any of the other tables into the DB in their extracted state, we'll need to define metadata for them. IIRC there are not a crazy number of columns though.

Not sure what the issue is with utc_datetime failing its CHECK constraints... I've verified it's NOT NULL, and there are also no duplicate primary key values.
The table CREATE statement is below (minus a very long list of timezones...)
 I think this check formats the utc_datetime (which is stored as TEXT by SQLite using ISO-8601) and compares it to the contents of the utc_datetime column, requiring them to be the same? Maybe there's a rounding error / different number of sigfigs? DATETIME() formats without fractional seconds.
CHECK ("utc_datetime" IS DATETIME("utc_datetime"))

From the SQLite docs:

All other date and time functions can be expressed in terms of strftime():

Function

Equivalent (or nearly) strftime()

date(...)

strftime('%Y-%m-%d', ...)

time(...)

strftime('%H:%M:%S', ...)

datetime(...)

strftime('%Y-%m-%d %H:%M:%S', ...)

julianday(...)

strftime('%J', ...) -- (numeric return)

unixepoch(...)

strftime('%s', ...) -- (numeric return)

I commented out the bit of code that adds:
CHECK ("utc_datetime" IS DATETIME("utc_datetime"))

and it was able to load into the DB, so I think that was the issue.
However, it took 19 minutes to load the ~15M records in this one table into the DB so maybe this is another table that should get written to Parquet.

Maybe we should add a type conversion layer into the SQLiteIOManager, that can do things like:

Convert datetime64[ns] columns into an appropriately formatted string from SQLite (whole seconds).
Apply PUDL dtypes to all the columns being read out of SQLite before returning it to the user.


Add hostname information below IP (for example SSHBruteforce)

Hi, it will be helpful to show on screen hostname below IP address on screen.

If it possible to add information about process SSH Bruteforce?
Like....
2/10 (login)
4000/10000 (pass)
or less space
20%/40%   .... mean (20% of logins and 40% passwords is tested)
It will be helpful to estimate time to end

Working on it

Thanks!!!


add Brett, Jeremiah, Tom to team.js

I haven't touched the FE code before and forgot about the develop branch with my first push. Fixed with git push -f.


Blurred Background

I see that there exists  PKHUD.sharedHUD.dimsBackground = true
How about a PKHUD.sharedHUD.blurredBackground: Bool ???? :)

I think is not necessary. Can you explain why you need it?

Sorry.. when our app first starts up, I want to blurr the background while getting information from the server, not dim the background (know the effect is the same, but with blurred background was wondering if it was possible to add it like dimsBackground)

Thanks.. I'll give it a shot.


UTCTest.testOffsetDateTime() test failure locally

running this test locally by itself or with a local build throws the same exception:
Not equals : -05:00 != Z
java.lang.AssertionError: Not equals : -05:00 != Z
	at io.vertx.ext.unit.impl.TestContextImpl.reportAssertionError(TestContextImpl.java:362)
	at io.vertx.ext.unit.impl.TestContextImpl.assertEquals(TestContextImpl.java:258)
	at io.vertx.ext.unit.impl.TestContextImpl.assertEquals(TestContextImpl.java:245)
	at org.hibernate.reactive.UTCTest.lambda$testOffsetDateTime$5(UTCTest.java:118)
	at org.hibernate.reactive.UTCTest.lambda$testField$10(UTCTest.java:161)

It doesn't appear to fail in the CI builds.
Note I'm in the America/Chicago time-zone with an offset of  -05:00

@DavideD I don't understand the use the constant: ZoneOffset.UTC in the assertion that's failing?

Which assertion is failing?
On Thu, 22 Jul 2021, 19:25 Barry LaFond, @.***> wrote:

@DavideD https://github.com/DavideD I don't understand the use the
constant: ZoneOffset.UTC in the assertion that's failing?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/hibernate/hibernate-reactive/issues/901#issuecomment-885137231,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AAEIQ5PBZLD7CVO4S4ZNKSLTZBPB5ANCNFSM5A2RFCKQ
.

line 118:  context.assertEquals( entity.offsetDateTime.getOffset(), ZoneOffset.UTC );

In the configuration of the test we set the property hibernate.jdbc.time_zone to UTC.
So the timezone of the date should be set to UTC before saving it to the database.
This is what I see when I debug.
You can add a break point here: https://github.com/hibernate/hibernate-reactive/blob/main/hibernate-reactive-core/src/main/java/org/hibernate/reactive/adaptor/impl/PreparedStatementAdaptor.java#L172
The Calendar parameter, used to set the timezone, should be set to UTC.
We also set the time zone to UTC when we read the value in ResultSetAdaptor (as far as I can see). So I'm not sure why you have a different time zone.

OK, I can recreate the error if I change the time zone on my machine. As an experiment, I think it will work if you set the time zone  on your pc to UTC

I think this is a bug in ORM. When it converts the Timestamp to the OffsetDateTime, it uses the system default time zone instead of the one we set with the property.
Could you create a test for ORM and ask the team, please?
FIY: This is the code that's setting the wrong time zone.

I'm susprised nobody else had this failure before, I think I'm the only one in the UTC zone

Hrm. But if you're using OffsetDateTime it's because you want the database to decide the timezone, right? unless I've forgotten something, we should be ignoring hibernate.jdbc.time_zone in that case, shouldn't we?
Trying to remember how all that stuff worked...

Yeah, I mean, we made hibernate.jdbc.time_zone work (sorta) for Time and Timestamp, which are types which don't carry a timezone. But OffsetDateTime is a whole different kettle of fish. An OffsetDateTime already has a welldefined timezone. We shouldn't just overwrite it.

Would it matter in this case? As far as I understand, during the conversion from Timestamp  to OffsetDateTime the time zone is always set to the system default. No matter what value we used originally.

during the conversion from Timestamp to OffsetDateTime the time zone is always set to the system default. No matter what value we used originally.

Well that sounds definitely-wrong.
OTOH, I recall that H5 never really had proper support for timestamp with timezone (I added it in H6) so this behavior might be because of that.
I can tell you what should be the correct behavior in H6. But not in H5, which is a bit of a black box in this area as far as I'm concerned.

I can tell you what should be the correct behavior in H6

OK, what should be the correct behaviour?
It's a bit weird but I'm ok saying that Hibernate Reactive will always use the system default timezone if that's what's happening. As long as we are clear with the user. They can always store it using a custom user type if that doesn't work for them.

OK, what should be the correct behaviour?

Well the timezone should be preserved across all operations.
But I'm pretty sure that doesn't work in H5, because I did rather a lot of work to make it work in H6.

Well the timezone should be preserved across all operations.

your initial sentence sounded much more mysterious :-D

I would say, let's update the tests so that it checks that the time zone is the system default, add a note to the documentation and close this issue

BTW, when I run the test, I get the following:
Not equals : -07:00 != Z
java.lang.AssertionError: Not equals : -07:00 != Z

In case you haven't figured this out yet, I'm posting the following stuff...
In order to get consistent results, I think you will have to set the default JVM time zone on the test, similar to what is done in the ORM test for OffsetDateTime, OffsetDateTimeTest#testRetrievingEntityByOffsetDateTime.
Notice that in the superclass, AbstractJavaTimeTypeTest, the default time zone is set for each test by AbstractJavaTimeTypeTest#withDefaultTimeZone, then reset to the original time zone in the finally block at the end.
I am relying on my memory about this, but I think that hibernate.jdbc.time_zone is only used for converting a value from the default JVM timezone to the JDBC timezone for storing in the database, and for converting the value returned from the database from the JDBC time zone to the JVM default time zone.
I could be totally wrong about that though.
I think that @yrodiere would be the best person to ask about this.

I think that @yrodiere would be the best person to ask about this.

Not sure I'm the best for that (the people who originally implemented this stuff would know best) but I can try to answer, provided there's a question :)

I am relying on my memory about this, but I think that hibernate.jdbc.time_zone is only used for converting a value from the default JVM timezone to the JDBC timezone for storing in the database, and for converting the value returned from the database from the JDBC time zone to the JVM default time zone.

That's right, but the purpose of this property is actually to prevent the JDBC driver from relying on the JVM default timezone. So, depending on how reactive drivers work, it might be relevant in Hibernate Reactive as well.
For reference:

Reference documentation
Relevant blog post

I don't think the issue here is about the hibernate.jdbc.time_zone. I might have a better look at it later but it seems to work as expected in Hibernate Reactive.
The problem here is to define what happens when we save a type with a time zone and clarify that in the documentation. It seems to me that the time zone is always returned using the system default.
Unless we want to test that the built-in type works for every possible time zone, I think we could close this issue applying one of these two fixes:

Set the default time zone to UTC at the beginning of the test that's failing, or
Check that the time zone returned when loading the entity is the system time zone (and not necessarily UTC)

I think I prefer option 2 a bit better, because if somebody runs the test in a time zone that causes issues, the test will fail.
@blafond Could you have  a look at this and suggest a fix, please? You could also check what happens with ORM when you run the same test that's failing for HR.

@DavideD I was able to reproduce the error using ORM session.
I can make both 1. and 2. work, but for the latter I came up with is this assertion:
	context.assertEquals(
			entity.offsetDateTime.toZonedDateTime().getZone(),
			OffsetDateTime.now( ZoneId.systemDefault() ).toZonedDateTime().getZone()
	);

Please, when you send the PR, add a comment in the test so that we don't forget why we need this extra logic


ImplicitExpect should also prefer not_to over to_not.

When only running the RSpec/ImplicitExpect cop, it auto-corrects should_not to is_expected.to_not instead of is_expected.not_to. It should instead prefer not_to, like the RSpec/NotToNot cop.

Auto-correction using a subset of your enabled cops may sometimes generate output that doesn’t satisfy some of the disabled cops. I would generally recommend only using auto-correct without the --only option.


VSPI as master not working! (IDFGH-1768)

I use the ESP32-WROVER module VSPI as master,and try to send and receive data from a slave chip,but doesn't work.
I can't even get the CLK signal on oscilloscope. any one can help me figure out what problem it is ?
my init code is as below:
#define GPIO_VSPI_MOSI 23
#define GPIO_VSPI_MISO 19
#define GPIO_VSPI_SCLK 18
#define GPIO_VSPI_CS 5
void spi_master_init()
{
esp_err_t ret = ESP_OK;
spi_device_handle_t spi;
//Configuration for the SPI bus
spi_bus_config_t buscfg={
.mosi_io_num=GPIO_VSPI_MOSI,
.miso_io_num=GPIO_VSPI_MISO,
.sclk_io_num=GPIO_VSPI_SCLK,
.flags = SPICOMMON_BUSFLAG_NATIVE_PINS,
.quadwp_io_num=-1,
.quadhd_io_num=-1
};
//Configuration for the SPI device on the other side of the bus
spi_device_interface_config_t devcfg={
.command_bits=0,
.address_bits=0,
.dummy_bits=0,
.clock_speed_hz=510001000, //Clock out at 5 MHz,
.duty_cycle_pos=128, //50% duty cycle
.mode=0,
.spics_io_num=GPIO_VSPI_CS,
.cs_ena_posttrans=3, //Keep the CS low 3 cycles after transaction, to stop slave from missing the last bit when CS has less propagation delay than CLK
.queue_size=3
};
//Initialize the SPI bus and add the device we want to send stuff to.
ret=spi_bus_initialize(VSPI_HOST, &buscfg, 1);
assert(ret==ESP_OK);
ret=spi_bus_add_device(VSPI_HOST, &devcfg, &spi);
assert(ret==ESP_OK);
printf("[SPI] spi_master_init ok! SPI Type: %d ,mode: %d, speed: %d\r\n",VSPI_HOST,devcfg.mode,devcfg.clock_speed_hz);
uint8_t sendbuf[1] = {0x40};
uint8_t recvbuf[1] = {0};
spi_transaction_t t;
memset(&t, 0, sizeof(t));
t.length=8;
t.tx_buffer=sendbuf;
t.rx_buffer=recvbuf;
ret=spi_device_transmit(spi, &t);
printf("Received: %#x\n", recvbuf[0]);
}

@Erichao990 Thanks for reporting the issue. Would you please help provide more details as suggested in the issue template? Information like elf, sdk configuration, backtrace, log outputs, commit ID and etc. would help us debug further. Thanks.

My develop Environment is as below:
Module or chip used: [ESP32-WROVER|
IDF version : v4.0-dev-1287-gd7e659d
Build System: [Make|
Compiler version : // xtensa-esp32-elf-gcc (crosstool-NG esp32-2019r1) 8.2.0
Operating System: |Linux|
Power Supply: [USB|

@Erichao990 Thanks for reporting the issue. Would you please help provide more details as suggested in the issue template? Information like elf, sdk configuration, backtrace, log outputs, commit ID and etc. would help us debug further. Thanks.

My develop Environment is as below:
Module or chip used: [ESP32-WROVER|
IDF version : v4.0-dev-1287-gd7e659d
Build System: [Make|
Compiler version : // xtensa-esp32-elf-gcc (crosstool-NG esp32-2019r1) 8.2.0
Operating System: |Linux|
Power Supply: [USB|
My chip type is :ESP32-DOWDQ6

I can not be sure, but I do notice something here.
You do not initialize all fields of the spi_bus_config_t.
These do not default to 0x00 they are on the stack.

typedef struct {
    int mosi_io_num;                ///< GPIO pin for Master Out Slave In (=spi_d) signal, or -1 if not used.
    int miso_io_num;                ///< GPIO pin for Master In Slave Out (=spi_q) signal, or -1 if not used.
    int sclk_io_num;                ///< GPIO pin for Spi CLocK signal, or -1 if not used.
    int quadwp_io_num;              ///< GPIO pin for WP (Write Protect) signal which is used as D2 in 4-bit communication modes, or -1 if not used.
    int quadhd_io_num;              ///< GPIO pin for HD (HolD) signal which is used as D3 in 4-bit communication modes, or -1 if not used.
    int max_transfer_sz;            ///< Maximum transfer size, in bytes. Defaults to 4094 if 0.
    uint32_t flags;                 ///< Abilities of bus to be checked by the driver. Or-ed value of ``SPICOMMON_BUSFLAG_*`` flags.
    int intr_flags;    /**< Interrupt flag for the bus to set the priority, and IRAM attribute, see
                         *  ``esp_intr_alloc.h``. Note that the EDGE, INTRDISABLED attribute are ignored
                         *  by the driver. Note that if ESP_INTR_FLAG_IRAM is set, ALL the callbacks of
                         *  the driver, and their callee functions, should be put in the IRAM.
                         */
} spi_bus_config_t;

set some values for intr_flags and flags and for max_transfer_sz maybe that will help.

I can not be sure, but I do notice something here.
You do not initialize all fields of the spi_bus_config_t.
These do not default to 0x00 they are on the stack.

typedef struct {
    int mosi_io_num;                ///< GPIO pin for Master Out Slave In (=spi_d) signal, or -1 if not used.
    int miso_io_num;                ///< GPIO pin for Master In Slave Out (=spi_q) signal, or -1 if not used.
    int sclk_io_num;                ///< GPIO pin for Spi CLocK signal, or -1 if not used.
    int quadwp_io_num;              ///< GPIO pin for WP (Write Protect) signal which is used as D2 in 4-bit communication modes, or -1 if not used.
    int quadhd_io_num;              ///< GPIO pin for HD (HolD) signal which is used as D3 in 4-bit communication modes, or -1 if not used.
    int max_transfer_sz;            ///< Maximum transfer size, in bytes. Defaults to 4094 if 0.
    uint32_t flags;                 ///< Abilities of bus to be checked by the driver. Or-ed value of ``SPICOMMON_BUSFLAG_*`` flags.
    int intr_flags;    /**< Interrupt flag for the bus to set the priority, and IRAM attribute, see
                         *  ``esp_intr_alloc.h``. Note that the EDGE, INTRDISABLED attribute are ignored
                         *  by the driver. Note that if ESP_INTR_FLAG_IRAM is set, ALL the callbacks of
                         *  the driver, and their callee functions, should be put in the IRAM.
                         */
} spi_bus_config_t;

set some values for intr_flags and flags and for max_transfer_sz maybe that will help.

Thanks for your answering,but I read all the examples of SPI init,no one use these two flags,I am not sure the correct value to config them,did you know that?

I may have spoken too soon.
I have looked at C standards and it seems that doing something like this
`
typedef struct {
int a;
int b;
int c;
} bus_t;
bus_t bt = { .b=2 };
`
should initialise all members to 0x00 and bt.b to 2.
However, my recent experience with the ESP32 ESP-IDF 4.x (latest git) and gcc 8.2 tells me something else.
I will try to find an example later.
I will try to

Hi @Erichao990 and all,
gd7e659d is not a valid IDF commit, did you modify it yourself?
About this code, I can see the clock output on my IDF commit b08dcefaf. however, .clock_speed_hz=510001000, //Clock out at 5 MHz, results in a output clock of 80MHz (510MHz rounded to 80MHz, the maximum supported by ESP32), maybe you should check whether this frequency is supported by your slave (usually ESP32 cannot read at such high speed, even when the slave is ideal, see https://espressif-docs.readthedocs-hosted.com/projects/esp-idf/en/latest/api-reference/peripherals/spi_master.html#timing-considerations)
Also, the C standard guarantee that the following statement will clear all other members than member_a. It's also the suggested way to initialize the spi driver configuration structures.
type_t t = {
.member_a = X,
};

Hi @Erichao990 and all,
gd7e659d is not a valid IDF commit, did you modify it yourself?
About this code, I can see the clock output on my IDF commit b08dcefaf. however, .clock_speed_hz=510001000, //Clock out at 5 MHz, results in a output clock of 80MHz (510MHz rounded to 80MHz, the maximum supported by ESP32), maybe you should check whether this frequency is supported by your slave (usually ESP32 cannot read at such high speed, even when the slave is ideal, see https://espressif-docs.readthedocs-hosted.com/projects/esp-idf/en/latest/api-reference/peripherals/spi_master.html#timing-considerations)
Also, the C standard guarantee that the following statement will clear all other members than member_a. It's also the suggested way to initialize the spi driver configuration structures.
type_t t = {
.member_a = X,
};

Thank you  so much for your detailed answer,I've got the problem and it's working now,hha.

@ginkgm  https://github.com/espressif/esp-idf/commit/d7e659d
I thought .clock_speed_hz=510001000, was just a problem with a markdown parser removing the asterisks from .clock_speed_hz=5*1000*1000, but maybe not

@negativekelvin thanks for your clue~.
@Erichao990 Do you want to share the cause & can we close this thread?


sort learning materials for display in cal event details.

fixes ilios/frontend#1377.

@stopfstedt Looks like you need to modify:
https://github.com/ilios/calendar/blob/master/addon/components/ilios-calendar-single-event-learningmaterial-list.js#L38
to be return Ember.A(lm);
Which will make this an ember enumerable.  This is necessary in an addon because ember doesn't automatically extend the array prototype like we do in the app.

superseded by #41


Get the current region (#1148)

Get the current region, i.e. the smallest region that contains the current time.
If several such regions exist, we take the first.
Return null if none exist.
Implements https://github.com/katspaugh/wavesurfer.js/issues/1148
Signed-off-by: Dimid Duchovny<EMAIL_ADDRESS>

Can you add a unit test for the function?

Sure, where should the tests be? In the regions plugin itself or in spec?
2017-08-18 15:54 GMT+03:00 Martin Spencer<EMAIL_ADDRESS>
Can you add a unit test for the function?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/katspaugh/wavesurfer.js/pull/1180#issuecomment-323345775,
or mute the thread
https://github.com/notifications/unsubscribe-auth/ADhEtlpfuejzmaiMOI0GH9V7nI5yjANXks5sZYmZgaJpZM4OoTYc
.

I just saw we don't have any tests yet. Either you create a regions.spec.js in /spec and add your tests there. Or leave it out and the person that adds all the other tests for the regions plugin (at some point) also adds it.


weed/shell: Cluster check other disk types

What problem are we solving?
The cluster.check command only took the empty ("") and hdd disk types into consideration, but a cluster with only ssd or nvme disk types would be equally valid.
How are we solving the problem?
This commit simply checks that any disk type is defined, and that some volumes are available for it.
How is the PR tested?
Spawned a cluster and ran cluster.check on it.
Checks

[ ] I have added unit tests if possible.
[ ] I will add related wiki document changes and link to this PR after merging.

The original intention is to ensure there is a hdd disk type defined, which would be used by the filer metadata logs.

The original intention is to ensure there is a hdd disk type defined, which would be used by the filer metadata logs.

I see. In that case, perhaps it would make sense to check the empty and hdd disk types when len(filers) > 0, so that we don't error out when filers aren't even deployed?
But in principle, I think it would make sense for the metadata logs to prefer hdd disk type but fall back to ssd or nvme if those are the only available volume types. I haven't looked at that part of the code yet though.

@chrislusf Is this better?


Ruby support

It would be nice to support Ruby the same way we support Haskell and Bash. This probably will look like a combination of those two script runners, since we'll need to close over gem dependencies but provide an interpreter.

I wonder if these additional wrappers should use nix-script-haskell itself :slightly_smiling_face: . I'm new to Nix Flakes and not yet sure how to package nix-script based scripts themselves. But this wrapper works for me:
#!/usr/bin/env nix-script-haskell
#!haskellPackages optparse-applicative

import Data.List
import Data.Maybe
import Options.Applicative
import System.Environment
import System.Exit
import System.Process

optionsParser :: ParserInfo (FilePath, [String])
optionsParser =
    info
        ( (,)
            <$> strArgument (metavar "SCRIPT" <> help "Path to script to run")
            <*> many (strArgument (metavar "ARGS" <> help "Arguments to pass to your script"))
        )
        ( fullDesc
            <> progDesc "Same as nix-script-haskell, but for Ruby"
            <> forwardOptions <> noIntersperse  -- allow passing --flags like options in args
        )

main :: IO ()
main = do
    (target, args) <- execParser optionsParser
    rubyPackages <- getRubyPackages target
    setEnv "BUILD_COMMAND" "chmod +x $SCRIPT_FILE"
    setEnv "RUNTIME_INPUTS" . intercalate " " $
        ["(ruby.withPackages (ps: with ps; ["] ++ rubyPackages ++ ["]))"]
    setEnv "INTERPETER" "ruby"
    execProc "nix-script" (target:args)

execProc :: FilePath -> [String] -> IO ()
execProc cmd args = do
    (_, _, _, ph) <- createProcess (proc cmd args){ delegate_ctlc = True }
    waitForProcess ph >>= exitWith

getRubyPackages :: FilePath -> IO [String]
getRubyPackages target = do
    headerLines <- takeWhile ("#!" `isPrefixOf`) . lines <$> readFile target
    return $ mapMaybe (stripPrefix "#!rubyPackages ") headerLines


File menu not showing correctly

Prerequisites

[x] Put an X between the brackets on this line if you have done all of the following:

Reproduced the problem in Safe Mode: https://flight-manual.atom.io/hacking-atom/sections/debugging/#using-safe-mode
Followed all applicable steps in the debugging guide: https://flight-manual.atom.io/hacking-atom/sections/debugging/
Checked the FAQs on the message board for common solutions: https://discuss.atom.io/c/faq
Checked that your issue isn't already filed: https://github.com/issues?utf8=✓&q=is%3Aissue+user%3Aatom
Checked that there is not already an Atom package that provides the described functionality: https://atom.io/packages

Description
When I open the File menu in the menu bar at the top it opens but does not show correctly.

Steps to Reproduce

Open the menu

Expected behavior:
Showing all options correctly
Actual behavior:
The menu opens but it does not show correctly
Reproduces how often:
Every time I open it
Versions

Additional Information
I am using a 4K Monitor. When I move Atom to another 1920x1080 Screen the menu works as expected. It also works if I resize Atom on my Main screen.

I am having a similar issue as well

I have this same issue as well. Any worksround?

I have this same issue as well. Any workaround?

For me the menu is working if I switch to windowed mode. You could do that, do something in the menu and maximize the window again

@Lenni0451 Is there any permanant solution to this?

@Lenni0451 Is there any permanant solution to this?

I have not found a permanent solution for this. I am using the workaround at the moment. I just hope it gets fixed at some point.

Just to post some more about the issue. I am using a dual monitor (Resolution 1920x1080) setup with my laptop pc. If both laptop screen and monitor are set at same 1920x1080 resolution, this issue is there. But if I lower the resolution on the laptop screen (let's say 1280 x 720), then atom file menu is displaying just fine in the extended monitor. Hope this is helpful to the maintainer.

This issue seems to be fixed now.

@apicgg I'm still having this issue on the latest stable version 1.57.0. Are you running the beta or nightly?

Nope I am using the stable one. I am actually not sure how it got fixed for me but it did. :D

Still not fixed for me as well

Problem still present in 1.58.0. Also have a 4K monitor with a resolution of 3840 x 2160. Text scaled to 150% in Windows.

This issue seems to be only with multi monitor set-up!!

Is there any workaround to fix this one?

I have a similar issue. I have a dual monitor setup and different DPI scaling values for the two screens. I experience the problem when Atom is maximized on the right screen (i.e. with the File menu "touching" the other screen).

The problem does not occur in window mode on either screen, or when I enforce "System" scaling in the high DPI compatibility.

This issue for me occurs when you have a laptop set to 150% scaling and connect an external main monitor set to a different scaling factor.
The file menu will appear fine on the laptop screen but no the main monitor.

Still having this issue on 1.60.0 (latest version). Quite annoying! Specific to dual monitor setup as someone already mentioned; however, the "rearrange so they're slightly misaligned" trick @SKYWVRD proposed did not solve the issue for me.


Certain characters in markdown code incorrectly parsed (e.g., &)

I encountered a similar issue as #372, originally found in https://github.com/omnilib/sphinx-mdinclude/issues/19. I did some digging and found that the issue lays in mistune.util.escape_url indeed as @torokati44 points towards, but only because its behavior is different depending on whether html is installed (this happens in the import, at least of mistune 2.0.5):
https://github.com/lepture/mistune/blob/cb580e89e67ef9b4827daf43afd2058bdf5e58d2/mistune/util.py#L22-L31
Some code to reproduce:
from urllib.parse import quote
import html

link = "https://sonarcloud.io/api/project_badges/measure?project=Deltares_ddlpy&metric=alert_status"

# code from: def escape_url(link):
safe = (
    ':/?#@'           # gen-delims - '[]' (rfc3986)
    '!$&()*+,;='      # sub-delims - "'" (rfc3986)
    '%'               # leave already-encoded octets alone
)
out_nonhtml = quote(link.encode('utf-8'), safe=safe)
out_withhtml = html.escape(quote(html.unescape(link), safe=safe))
out_withhtml_noescape = quote(html.unescape(link), safe=safe)

print(out_nonhtml)
print(out_withhtml)
print(out_withhtml_noescape)

This gives different results. The first one is returned if html is not installed, the second one if html is installed. The third one is correct again:
https://sonarcloud.io/api/project_badges/measure?project=Deltares_ddlpy&metric=alert_status
https://sonarcloud.io/api/project_badges/measure?project=Deltares_ddlpy&metric=alert_status
https://sonarcloud.io/api/project_badges/measure?project=Deltares_ddlpy&metric=alert_status

Therefore, what I think should fix the issue is to remove the html.escape() from the escape_url function so the behaviour is always consistent and according to expectations.
Update for newer mistune versions
The escape_url function looks different in the master branch (>3.0.0):
https://github.com/lepture/mistune/blob/93fd197c6c24353011974110378b738596cde5a1/src/mistune/util.py#L32-L39
In this case omitting escape does the trick.
Originally posted by @veenstrajelmer in https://github.com/lepture/mistune/issues/372#issuecomment-2210640694

Okay, I've taken a closer look. TL;DR: we need to move the call to escape out of escape_url and into the HTML renderers.
This is another case of HTML-escaping being applied in the parse stage, instead of during HTML rendering, resulting in HTML-specific escapes leaking into non-HTML outputs/uses:
>>> md = mistune.Markdown()
>>> md('[hi](https://example.com/xyz?a=b&foo=bar)')
[{'type': 'paragraph', 'children': [{'type': 'link', 'children': [{'type': 'text', 'raw': 'hi'}], 'attrs': {'url': 'https://example.com/xyz?a=b&foo=bar'}}]}]

(The same kind of issue as for inline code spans - different code paths, but same abstract "shape".)
The current logic of escape_url is correct for HTML, but so we don't want to just delete the call to escape from inside it, we want to move it to every spot that renders URLs to HTML. Funny enough, the include Image directive plugin is already doing this (meaning it's currently buggy and will also get fixed by this change).
PR soon.

Thanks a lot for this elaborate analysis and the reproducible example!


conn_pool: renaming TCP pool

Leaving the unit test where it is.   It will be made into TEST_P and used to test both the old and the new.
Risk Level: Low (only minor clang refactors)
Testing: tests pass
Docs Changes: n/a
Release Notes: n/a
Part of #11528

Ok, CI sorted, should be good to look at :-)


Change health via difficulty

You might want to merge this functionality with the gameplay changers, resulting in gameplay settings per difficulty.

You should still put this in options or gameplay changers. This PR changes gameplay not just for the engine, but every mod you'll ever play on psych, making some harder mods impossible to beat (also mentioning that this will just break most mod compatibility in general)

fine.. i'll work harder on it.

This is pretty useless considering you can just use gameplay modifiers and/or setProperty


Change parse_infix_expression to use combinator style.

Change parse_infix_expression to use combinator style.
Change parse_infix_expression and parse_expression to take 1 arg and return a parser.
Make some things Clone so that the above works.

LGTM! Just some train-of-thought comments. I could delete them, but w/e.

Haha, it's cool, I operate the same way. :)


nix-shell warn when -p used with no arguments

This cost me a little time in  GuillaumeDesforges/haskell-nix-dev-template#7.
A warning is correct for -p with no arguments I believe, not sure about nix-shell -p in a directory with shell.nix.
Maybe a notice that shell.nix isn't being used?

Probably should be opened in https://github.com/NixOS/nix.
I actually do use nix-shell -p occasionally to just get gcc, binutils, etc.


[feat] no-multi-spaces

Made some modifications to the test helper so that we may do something similar to what eslint is doing. That is, being able to create different configurations for a particular test. I have added all the tests from eslint and other tests that I caught while testing with my IDE.

Forgot to mention that it closes #102.

If possible lets try to merge #108 before this one, I'd rather do the updates to this branch than the other one. It would also show the usage of the gulp readme task.

And its ready for a review/merge.


[chores] Added CSS for inline-link-container

Changes

#Please explain changes made in your PR#

Screenshots

#For UI changes, please share a screenshot#

Checklist

[ ] I have read the contributing guidelines.
[ ] I have manually tested the proposed changes.
[ ] I have written new test cases to avoid regressions. (if necessary)
[ ] I have updated the documentation. (e.g. README.rst)
[ ] I have added [change!] to commit title to indicate a backward incompatible change. (if required)
[ ] I have checked the links added / modified in the documentation.

#Closes #(issue-number)#

coverage: 98.395%. remained the same
when pulling 5c59223798d6a57984b25e425ae09ffa64b1f68e on add-admin-inline-ctb-css
into 81d8e7ac62539e0b11bf14a610bee64d1637e8e6 on master.


Suggestion: Use Repo Releases section

Hi just a suggestion, rather then putting the releases in to the wiki section you could use the release section for this repo at https://github.com/alexrainman/CarouselView/releases :)
It will be easier and simpler for devs to track new releases :)

OK


Sync process hangs at 99% for a long time when recovering a wallet whist lnd scans blocks for recoverable addresses

Description
Sync process hangs at 99% for a long time when recovering a wallet whist lnd scans blocks for recoverable addresses.
Expected Behavior
Sync screen should factor in the additional time it takes to scan old blocks for recoverable addresses.
Actual Behavior
Sync screen hangs at 99% whilst old blocks are scanned.
Log output from lnd shows what is happening in the background:
zap:lnd [INF]  2019-04-22 13:04:08.973 [INF] LNWL: RECOVERY MODE ENABLED -- rescanning for used addresses with recovery_window=250 +759ms
  zap:lnd [INF]  2019-04-22 13:04:08.983 [INF] LNWL: Seed birthday surpassed, starting recovery of wallet from height=567221 hash=0000000000000000002e2998f76507736d96df2f2cb45a744795d7316bea2b8a with recovery-window=250 +10ms
  zap:lnd [INF]  2019-04-22 13:04:08.996 [INF] LNWL: Scanning 780 blocks for recoverable addresses +13ms
  zap:lnd [INF]  2019-04-22 13:04:12.097 [INF] BTCN: Waiting for more block headers, then will start cfheaders sync from height 570000... +3s
  zap:lnd [INF]  2019-04-22 13:04:12.097 [INF] BTCN: Starting cfheaders sync from (block_height=570000, block_hash=0000000000000000000822cf76247f1ecec0a82dbecb3b482ec4d2d154e0cd1d) to (block_height=572746, block_hash=000000000000000000281a467a2f64f5b0283f9fd40c0bc3678776d33cf75723) +1ms
  zap:lnd [INF]  2019-04-22 13:04:12.099 [INF] BTCN: Starting cfheaders sync for filter_type=0 +2ms
  zap:lnd [INF]  2019-04-22 13:04:12.227 [INF] BTCN: Fetching set of checkpointed cfheaders filters from height=570000, hash=620f1c748b3965f3e8eed33d74bbaead8b2b584a028a7040f202277817ffbd5c +127ms
  zap:lnd [INF]  2019-04-22 13:04:12.227 [INF] BTCN: Starting to query for cfheaders from checkpoint_interval=570 +1ms
  zap:lnd [INF]  2019-04-22 13:04:12.227 [INF] BTCN: Attempting to query for 2 cfheader batches +0ms
  zap:lnd [INF]  2019-04-22 13:04:12.687 [INF] BTCN: Verified 83000 filter headers in the last 12.22s (height 570001, 2019-04-03 11:22:56 +0200 CEST) +460ms
  zap:main [INF]  Sending message to renderer process: { msg: 'lndCfilterHeight', data: 570001 } +0ms
  zap:lnd [INF]  2019-04-22 13:04:15.714 [INF] BTCN: Fully caught up with cfheaders at height 572746, waiting at tip for new blocks +3s
  zap:lnd [INF]  2019-04-22 13:04:15.715 [INF] BTCN: Attempting to fetch set of un-checkpointed filters at height=572746, hash=000000000000000000281a467a2f64f5b0283f9fd40c0bc3678776d33cf75723 +0ms
  zap:lnd [INF]  2019-04-22 13:07:07.455 [INF] LNWL: Recovered addresses from blocks<PHONE_NUMBER>00 +3m
  zap:lnd [INF]  2019-04-22 13:07:07.613 [INF] LNWL: Scanning 2000 blocks for recoverable addresses +157ms
  zap:lnd [INF]  2019-04-22 13:08:27.351 [INF] LNWL: Fetching block height=568358 hash=0000000000000000001e2c52b041dc46c93a00a6e123ac6ff2935beb31469b90 +1m
  zap:lnd [INF]  2019-04-22 13:08:51.196 [INF] LNWL: Fetching block height=568457 hash=0000000000000000001e4cb64e17b65f2654e5807a2cb5845c3def034d8a54df +24s
  zap:lnd [INF]  2019-04-22 13:14:32.727 [INF] LNWL: Fetching block height=569987 hash=00000000000000000005f95125bd5c19e874ef3517b180c4c71f537acd529045 +6m
  zap:lnd [INF]  2019-04-22 13:14:42.384 [INF] LNWL: Recovered addresses from blocks<PHONE_NUMBER>00 +10s
  zap:lnd [INF]  2019-04-22 13:14:42.495 [INF] LNWL: Scanning 2000 blocks for recoverable addresses +111ms
  zap:lnd [INF]  2019-04-22 13:17:59.718 [INF] LNWL: Fetching block height=570859 hash=0000000000000000002a31f50dde965d8c929e1e34be72efa3bbd791a1ea7051 +3m
  zap:lnd [INF]  2019-04-22 13:20:08.451 [INF] LNWL: Fetching block height=571439 hash=0000000000000000000f87c05c462d3874844cc161c6b0d5bc744d53c3937ef1 +2m
  zap:lnd [WRN]  2019-04-22 13:20:14.210 [WRN] LNWL: Could not parse output script in b858e36898d32ddb853875b10fe3d263524bbcb338b62b63649c000abdc1475b:2: opcode OP_DATA_75 requires 76 bytes, but script only has 39 remaining +6s
  zap:lnd [INF]  2019-04-22 13:22:17.653 [INF] LNWL: Recovered addresses from blocks<PHONE_NUMBER>00 +2m
  zap:lnd [INF]  2019-04-22 13:22:17.777 [INF] LNWL: Scanning 746 blocks for recoverable addresses +124ms
  zap:lnd [INF]  2019-04-22 13:22:50.524 [INF] BTCN: Processed 2426 blocks in the last 18m53.68s (height 572747, 2019-04-22 13:22:23 +0200 CEST) +33s
  zap:main [INF]  Sending message to renderer process: { msg: 'lndBlockHeight', data: 572747 } +1ms
  zap:main [INF]  Sending message to renderer process: { msg: 'currentBlockHeight', data: 572747 } +0ms
  zap:lnd [INF]  2019-04-22 13:22:50.538 [INF] BTCN: Attempting to fetch set of un-checkpointed filters at height=572747, hash=0000000000000000001a82cd1b7adc2192568b26517378ff6360fd8c38cef320 +13ms
  zap:lnd [INF]  2019-04-22 13:22:51.366 [INF] BTCN: Verified 2746 filter headers in the last 18m38.64s (height 572747, 2019-04-22 13:22:23 +0200 CEST) +828ms
  zap:main [INF]  Sending message to renderer process: { msg: 'lndCfilterHeight', data: 572747 } +1ms
  zap:lnd [INF]  2019-04-22 13:25:06.420 [INF] LNWL: Recovered addresses from blocks<PHONE_NUMBER>46 +2m
  zap:lnd [INF]  2019-04-22 13:25:06.429 [INF] LNWL: Started rescan from block<PHONE_NUMBER>00000000281a467a2f64f5b0283f9fd40c0bc3678776d33cf75723 (height 572746) for 0 addresses +9ms
  zap:lnd [INF]  2019-04-22 13:25:06.430 [INF] BTCN: Registering block subscription: id=2 +0ms
  zap:lnd [INF]  2019-04-22 13:25:06.430 [INF] BTCN: Canceling block subscription: id=2 +1ms
  zap:lnd [INF]  2019-04-22 13:25:06.431 [INF] LNWL: Catching up block hashes to height 572747, this might take a while +0ms
  zap:lnd [INF]  2019-04-22 13:25:06.431 [INF] BTCN: Registering block subscription: id=3 +1ms
  zap:lnd [INF]  2019-04-22 13:25:06.442 [INF] LNWL: Done catching up block hashes +10ms
  zap:lnd [INF]  2019-04-22 13:25:06.442 [INF] LNWL: Rescanned through block<PHONE_NUMBER>000000001a82cd1b7adc2192568b26517378ff6360fd8c38cef320 (height 572747) +1ms
  zap:lnd [INF]  2019-04-22 13:30:03.043 [INF] BTCN: Processed 1 block in the last 7m12.53s (height 572748, 2019-04-22 13:29:26 +0200 CEST) +5m
  zap:main [INF]  Sending message to renderer process: { msg: 'lndBlockHeight', data: 572748 } +1ms
  zap:main [INF]  Sending message to renderer process: { msg: 'currentBlockHeight', data: 572748 } +1ms
  zap:lnd [INF]  2019-04-22 13:30:03.054 [INF] BTCN: Attempting to fetch set of un-checkpointed filters at height=572748, hash=000000000000000000241cd3be362ef6ad3286996db1a07002282a53f69dca2d +10ms
  zap:lnd [INF]  2019-04-22 13:30:03.346 [INF] BTCN: Verified 1 filter header in the last 7m11.99s (height 572748, 2019-04-22 13:29:26 +0200 CEST) +292ms
  zap:main [INF]  Sending message to renderer process: { msg: 'lndCfilterHeight', data: 572748 } +0ms
  zap:lnd [INF]  2019-04-22 13:30:03.347 [INF] LNWL: Catching up block hashes to height 572748, this might take a while +1ms
  zap:lnd [INF]  2019-04-22 13:30:03.358 [INF] LNWL: Done catching up block hashes +11ms
  zap:lnd [INF]  2019-04-22 13:30:03.358 [INF] LNWL: Finished rescan for 0 addresses (synced to block<PHONE_NUMBER>00000000241cd3be362ef6ad3286996db1a07002282a53f69dca2d, height 572748) +1ms
  zap:lnd [INF]  2019-04-22 13:30:04.298 [INF] LTND: Chain backend is fully synced (end_height=572748)! +938ms
  zap:main [INF]  Neutrino sync finished +1ms
  zap:main [INF]  Sending message to renderer process: { msg: 'lndSyncStatus', data: 'complete' } +0ms

Possible Fix
Factor recovery process into the sync progress calculations and progress bar display
Steps to Reproduce
Import an old wallet and monitor the lnd logs whist the sync is happening.
Your Environment

Zap version: 0.4.1
Operating System and version: all

Closed via https://github.com/LN-Zap/zap-desktop/pull/2133


Prepare release of v0.8.3

@philss / @billylanchantin just curious if you ran into an issue holding this release up?
FWIW, I'm trying to avoid having to add the entire rust nightly toolchain to our build pipeline, as I'm not aware of any way to force the use of one of the NIFs that were built here. Maybe there's a way to do that?
Anyways, thanks for your work on this! 🙏

@mlineen Sorry yes we did hit a snag. We forgot https://github.com/elixir-explorer/explorer/pull/903 was breaking, so we'd either need to do 0.9 or add something for backwards compatibility. https://github.com/elixir-explorer/explorer/pull/924 hopefully fits the bill but we're still working on it.

@mlineen we just published a new version :)


formating files

Issue Type: Bug
there is a problem in  (format on save) setting
VS Code version: Code 1.69.1 (b06ae3b2d2dbfe28bca3134cc6be65935cdfea6a, 2022-07-12T08:21:24.514Z)
OS version: Windows_NT x64 10.0.19044
Restricted Mode: No

System Info

Item
Value

CPUs
Intel(R) Core(TM) i5-6600 CPU @ 3.30GHz (4 x 3312)

GPU Status
2d_canvas: enabledcanvas_oop_rasterization: disabled_offdirect_rendering_display_compositor: disabled_off_okgpu_compositing: enabledmultiple_raster_threads: enabled_onopengl: enabled_onrasterization: enabledraw_draw: disabled_off_okskia_renderer: enabled_onvideo_decode: enabledvideo_encode: enabledvulkan: disabled_offwebgl: enabledwebgl2: enabled

Load (avg)
undefined

Memory (System)
7.88GB (4.06GB free)

Process Argv
--crash-reporter-id 697f4e65-e15a-4936-83c0-7d41a84160b1

Screen Reader
no

VM
0%

Extensions (10)

Extension
Author (truncated)
Version

vscode-html-css
ecm
1.13.0

vscode-html-format
moh
0.0.4

python
ms-
2022.10.1

vscode-pylance
ms-
2022.7.30

jupyter
ms-
2022.6.1101950301

jupyter-keymap
ms-
1.0.0

jupyter-renderers
ms-
1.0.8

format-html-in-php
rif
1.7.0

LiveServer
rit
5.7.5

html5-boilerplate
sid
1.1.1

/needsMoreInfo
Please describe the problem.
Please also use the Start Extension Bisect command to investigate whether one of your extensions is causing it.

Thanks for creating this issue! We figured it's missing some basic information or in some other way doesn't follow our issue reporting guidelines. Please take the time to review these and update the issue.
Happy Coding!

/needsMoreInfo
Please describe the problem.
Please also use the Start Extension Bisect command to investigate whether one of your extensions is causing it.

hi @gjsjohnmurray , you can find more information on #155154

Hey @jrieken, this issue might need further attention.
@O-X-Y-G-EN, you can help us out by closing this issue if the problem no longer exists, or adding more information.


Docs/#1 english document

Types of PR

[x] New Features

Description

add English document

How to review this PR
mkdocs serve
# then access to localhost:8000

Others
closes: #1

I will review the PR today :eyes:

Thanks for the review.
I will check the suggested revisions.

@kielczykowski-rai
I have ported the documentation that I had already submitted to autoware-documentation to this repository.
https://github.com/tier4/driving_log_replayer/tree/docs/%231-english-document/docs/quick_start
The PR for autoware-doucmentaiton is now just a link to this repository.
https://github.com/autowarefoundation/autoware-documentation/pull/217/files

The content that was created for autoware-documentation was added as quick_start.
This has changed the chapter structure.

index
quick_start
overview
scenario_format
result_format
use_case

@kielczykowski-rai
Thank you for reporting.
<< show test result >>
test case 1 / 1 : use case: sample
--------------------------------------------------
TestResult: Failed
ReliabilityError: Convergence: NotTested Reliability: NVTL Sequential NG Count: 10 (Total Test: 256)

This result happens when ndt is not convered.
This can be caused by CPU load conditions or other reasons.
In this case, you will see the following warning in the terminal.
[ndt_scan_matcher-36] [WARN] [1667540698.508454926] [localization.pose_estimator.ndt_scan_matcher]: Nearest Voxel Transformation Likelihood is below the threshold. Score: 1.840985, Threshold: 2.300000
[ndt_scan_matcher-36] [WARN] [1667540698.508579569] [localization.pose_estimator.ndt_scan_matcher]: Not Converged

I built the latest versions of galactic and humble in my environment to check the operation, and it was working fine.


Filtering on the extended attributes defined in the stitched schema

Is your feature request related to a problem? Please describe.
Would like to use filtering on the extended attributes defined in the stitched schema
Describe the solution you'd like
Would like to use filtering on the extended attributes defined in the stitched schema
Describe alternatives you've considered
Tried Adding .AddFiltering(); in Startup.cs. in the schema stitching project
But not getting filter support on the new attributes defined in Extensions.graphql
Additional context
Add any other context or screenshots about the feature request here.

Hi @antonix1
Thank you for your feature request! :)
There are a couple of things that make this difficult. Stitching makes use of the execution engine to resolve the fields that are requested. Filtering works on the resolver and the middleware pipeline of a field. These two things do not yet know from each other.
Even though we would like to have support for said feature, this is at the moment not possible. We will keep this in mind though, when we design further steps

@PascalSenn Does that limitation also apply to fields that uses ResolveWith?
e.g. we cannot use the LastActivityTimestamp field as filter input when configured like so:
descriptor
    .Field(_ => _.LastActivityTimestamp)
    .ResolveWith<MyResolver>(_ => _.LastActivityTimestampAsync(default!, default!, default))
    .UseDbContext<MyDbContext>();

// MyResolver
public async Task<DateTime?> GetLastActivityTimestampAsync(
    MyModel model,
    [ScopedService] MyDbContext ctx,
    CancellationToken cancellationToken)
{
    var time =
         await ctx.Time
        .Where(_ => _.ModelId == model.Id)
        .OrderByDescending(_ => _.OutTimestamp ?? _.InTimestamp)
        .FirstOrDefaultAsync(cancellationToken);

    return t?.OutTimestamp ?? t?.InTimestamp;
}

Is there a workaround or different approach to solve the said issue?
Thank you!

Do you have plans (backlog) to solve this problem in version 13, where the target is stitched?
Thank you!

@elmanav Not this feature in particular. We might be able to do this at some point. but distributed filtering is a complex topic.

@elmanav Not this feature in particular. We might be able to do this at some point. but distributed filtering is a complex topic.

Thanks.

Is there any workaround to solve this problem. I need to apply sort/filter on parent node based on child attributes where the child node is extended from stitched schema.


Basic production Docker build and run directions in README

I need to update and remove the TAR file. Will want to just have the README for directions.


Access denied for 'password'

Hi ,
When I trying to use the passwd to connect the server ,got below error:
[2022/03/23 17:08:34.980945, 3] ssh_packet_process:  Dispatching handler for packet type 51
[2022/03/23 17:08:34.980992, 1] ssh_packet_userauth_failure:  Access denied for 'none'. Authentication that can continue: publickey,password
[2022/03/23 17:08:34.981042, 2] ssh_packet_userauth_failure:  Access denied for 'none'. Authentication that can continue: publickey,password
nc VERBOSE: Publickey athentication.
nc VERBOSE: No key pair specified.
nc WARNING: Authentication denied.
nc VERBOSE: Password authentication (host "localhost", user "san").
san@localhost password:
[2022/03/23 17:08:40.755445, 3] ssh_socket_unbuffered_write:  Enabling POLLOUT for socket
[2022/03/23 17:08:40.755504, 3] packet_send2:  packet: wrote [type=50, len=56, padding_size=9, comp=46, payload=46]
[2022/03/23 17:08:40.755902, 3] ssh_packet_socket_callback:  packet: read type 51 [len=32,padding=7,comp=24,payload=24]
[2022/03/23 17:08:40.755941, 3] ssh_packet_process:  Dispatching handler for packet type 51
[2022/03/23 17:08:40.755971, 1] ssh_packet_userauth_failure:  Access denied for 'password'. Authentication that can continue: publickey,password
[2022/03/23 17:08:40.755997, 2] ssh_packet_userauth_failure:  Access denied for 'password'. Authentication that can continue: publickey,password
nc WARNING: Authentication denied.
nc ERROR: Unable to authenticate to the remote server (all attempts via supported authentication methods failed).
[2022/03/23 17:08:40.756105, 3] ssh_socket_unbuffered_write:  Enabling POLLOUT for socket
[2022/03/23 17:08:40.756135, 3] packet_send2:  packet: wrote [type=1, len=32, padding_size=11, comp=20, payload=20]
cmd_connect: Connecting to the localhost:830 as user "san" failed.
>

I could make sure that the passwd is correct,But don't know why could not connect to the server.
When I try to using the publickey to login the server and get success,But I want to login via the passwd.
Could you help me with that?
release info :

Run the server with -d -v2 parameters and you will see its output with the reason why it failed. Impossible to tell from the side of the client.

Hi,
please check this out
[INF]: LN: Accepted a connection on <IP_ADDRESS>:830 from <IP_ADDRESS>:34978.
Jul 11 10:23:57 M2-O daemon.info netopeer2-server[3347]: Accepted a connection on <IP_ADDRESS>:830 from <IP_ADDRESS>:34978.
[INF]: SR: Session 31175 (user "root", CID 2) created.
Jul 11 10:23:57 M2-O daemon.info netopeer2-server[3347]: Session 31175 (user "root", CID 2) created.
[INF]: LN: Received an SSH message "request-service" of subtype "ssh-userauth".
Jul 11 10:23:57 M2-O daemon.info netopeer2-server[3347]: Received an SSH message "request-service" of subtype "ssh-userauth".
[INF]: LN: Received an SSH message "request-auth" of subtype "none".
Jul 11 10:23:57 M2-O daemon.info netopeer2-server[3347]: Received an SSH message "request-auth" of subtype "none".
[INF]: LN: Received an SSH message "request-auth" of subtype "password".
Jul 11 10:24:01 M2-O daemon.info netopeer2-server[3347]: Received an SSH message "request-auth" of subtype "password".
[INF]: LN: Failed user "root" authentication attempt (#1).
Jul 11 10:24:01 M2-O daemon.info netopeer2-server[3347]: Failed user "root" authentication attempt (#1).
[2023/07/11 10:24:01.562974, 1] ssh_packet_disconnect_callback:  Received SSH_MSG_DISCONNECT: 11:Bye Bye
[ERR]: LN: Communication SSH socket unexpectedly closed.
Jul 11 10:24:01 M2-O daemon.err netopeer2-server[3347]: Communication SSH socket unexpectedly closed.

So it seems you have simply failed the authentication. You have no SSH keys set for publickey authentication and have input the wrong password for password authentication. And it seems you have turned off keyboard-interactive authentication so there are no more methods for the client to try and it disconnects.

Hi,

Hi,
please check this out

That is all fine but the authentication information on the server is read from the system. Meaning only system users can be used and their system password must be presented. If using public keys, only those present in authorized_keys file of the user can be used for authentication.

We are using the system user, and logged into the system via ssh, which already exists before the connection.


Add an option to filter output by date

Hi,
thank you very much for that handy tool!
I don't want to preserve all database content, but just certain conversations. Hence I would love some options to filter, especially by date. Additionally filtering by contact/group would be nice, too.

Thanks for the suggestion @th1l6f! We'll take it into consideration. In the meantime, a workaround could be to manually edit the HTML and remove the messages that you don't want to keep.


Crafting Recipe

What's the crafting recipe? All the images that show it are broken.

Fixed and thanks for the report.


Kube 1.22 API deprecations

Current subcharts that are consumed make use of the following Ingress API: "Ingress" in version "extensions/v1beta1
which is removed in Kubernetes 1.22.
as per chart: 1.0.0-SNAPSHOT, from develop branch
commit f3c86f41175acbf99faa048d28c069c8c13fa182 (HEAD -> develop, origin/develop)
Chart.yaml
apiVersion: v2
name: ahoy
version: '1.0.0-SNAPSHOT'
dependencies:
  - name: postgresql
    version: "8.10.4"
    repository: "https://charts.bitnami.com/bitnami"
  - name: keycloak
    condition: keycloak.install
    version: "9.0.1"
    repository: "https://codecentric.github.io/helm-charts"
  - name: argo-cd
    condition: argo-cd.install
    version: "2.14.7"
    repository: "https://argoproj.github.io/argo-helm"
  - name: sealed-secrets
    condition: sealed-secrets.install
    version: "1.15.0-r1"
    repository: "https://bitnami-labs.github.io/sealed-secrets"

for example argo-cd
apiVersion: networking.k8s.io/v1beta1

This has been fixed; but on master branch.
It was intended to have a develop branch on this repo as it is not suitable to a normal release cadence as it contains charts for various projects.
This is something we need to sort out; but in the meantime please use master branch for ahoy chart related work.
Note; the helm repo releases are also published off of the master branch; so the code equivalents reside in master.


Calico-node daemonset register node with its IP address at first run instead of specified nodename and then crash

I have a kubernetes cluster up, running Calico policy controller and Calico node daemonset with its install-cni sidecar. I adapted calico-node container with a NODENAME env variable. (I'm also using ip autodetect and method can-reach).
# basically a copy/rename of CALICO_K8S_NODE_REF declaration
          - name: NODENAME
            valueFrom:
              fieldRef:
                apiVersion: v1
                fieldPath: spec.nodeName

When I launch a new node after the cluster is already up and running, one of calico-nodes component writes the node with the detected IP address as the nodename. Soon after that, calico-node crashes with message "Calico node '<IP_ADDRESS>' is already using the IPv4 address <IP_ADDRESS>".
If I delete the IP-named node with calicoctl delete node <IP_ADDRESS> calico-node is able to rerun and it recreates the entry correctly respecting NODENAME definition.
Expected Behavior

Expected it to Just Works!tm
Current Behavior

Pod from Daemonset Calico-node crashes until I remove the faulty entry manually.
Possible Solution

No idea until I figure out who's writing the IP-named nodename on etcd.
Steps to Reproduce (for bugs)

Deploy cluster kubernetes;
Deploy calico kube controller deployment and calico-node daemonset on existing cluster
Create new nodes.
Wait to see if it happens.

Context

Trying to write the simplest 'bootstrap' automation for a in-house kubernetes cluster using terraform and calico kubernetes entities. This really bit me because I'll have to do all the magistral work the daemonset did another way.
Your Environment

Calico version: 2.6.5
Orchestrator version (e.g. kubernetes, mesos, rkt): kubernetes 1.7.11
Operating System and version: CoreOS 1576.5.0

Relevant kubelet logs:
kuberuntime_manager.go:463] Container {Name:calico-node Image:myhub/repo/calico-node:v2.6.5 Command:[] Args:[] WorkingDir: Ports:[] EnvFrom:[] Env:[{Name:ETCD_ENDPOINTS Value: ValueFrom:&EnvVarSource{FieldRef:nil,ResourceFieldRef:nil,ConfigMapKeyRef:&ConfigMapKeySelector{LocalObjectReference:LocalObjectReference{Name:calico-config,},Key:etcd_endpoints,Optional:nil,},SecretKeyRef:nil,}} {Name:CALICO_NETWORKING_BACKEND Value: ValueFrom:&EnvVarSource{FieldRef:nil,ResourceFieldRef:nil,ConfigMapKeyRef:&ConfigMapKeySelector{LocalObjectReference:LocalObjectReference{Name:calico-config,},Key:calico_backend,Optional:nil,},SecretKeyRef:nil,}} {Name:CLUSTER_TYPE Value:k8s,bgp ValueFrom:nil} {Name:CALICO_DISABLE_FILE_LOGGING Value:true ValueFrom:nil} {Name:FELIX_DEFAULTENDPOINTTOHOSTACTION Value:ACCEPT ValueFrom:nil} {Name:CALICO_K8S_NODE_REF Value: ValueFrom:&EnvVarSource{FieldRef:&ObjectFieldSelector{APIVersion:v1,FieldPath:spec.nodeName,},ResourceFieldRef:nil,ConfigMapKeyRef:nil,SecretKeyRef:nil,}} {Name:FELIX_IPINIPMTU Value:1440 ValueFrom:nil} {Name:ETCD_CA_CERT_FILE Value: ValueFrom:&EnvVarSource{FieldRef:nil,ResourceFieldRef:nil,ConfigMapKeyRef:&ConfigMapKeySelector{LocalObjectReference:LocalObjectReference{Name:calico-config,},Key:etcd_ca,Optional:nil,},SecretKeyRef:nil,}} {Name:ETCD_KEY_FILE Value: ValueFrom:&EnvVarSource{FieldRef:nil,ResourceFieldRef:nil,ConfigMapKeyRef:&ConfigMapKeySelector{LocalObjectReference:LocalObjectReference{Name:calico-config,},Key:etcd_key,Optional:nil,},SecretKeyRef:nil,}} {Name:ETCD_CERT_FILE Value: ValueFrom:&EnvVarSource{FieldRef:nil,ResourceFieldRef:nil,ConfigMapKeyRef:&ConfigMapKeySelector{LocalObjectReference:LocalObjectReference{Name:calico-config,},Key:etcd_cert,Optional:nil,},SecretKeyRef:nil,}} {Name:IP Value:autodetect ValueFrom:nil} {Name:IP_AUTODETECTION_METHOD Value:can-reach=<IP_ADDRESS> ValueFrom:nil} {Name:FELIX_HEALTHENABLED Value:true ValueFrom:nil} {Name:NODENAME Value: ValueFrom:&EnvVarSource{FieldRef:&ObjectFieldS
kubelet-wrapper[938]: elector{APIVersion:v1,FieldPath:spec.nodeName,},ResourceFieldRef:nil,ConfigMapKeyRef:nil,SecretKeyRef:nil,}} {Name:NO_DEFAULT_POOLS Value:true ValueFrom:nil}] Resources:{Limits:map[] Requests:map[cpu:{i:{value:250 scale:-3} d:{Dec:<nil>} s:250m Format:DecimalSI}]} VolumeMounts:[{Name:lib-modules ReadOnly:true MountPath:/lib/modules SubPath:} {Name:var-run-calico ReadOnly:false MountPath:/var/run/calico SubPath:} {Name:etcd-certs ReadOnly:false MountPath:/calico-secrets SubPath:} {Name:calico-node-token-z81xr ReadOnly:true MountPath:/var/run/secrets/kubernetes.io/serviceaccount SubPath:}] LivenessProbe:&Probe{Handler:Handler{Exec:nil,HTTPGet:&HTTPGetAction{Path:/liveness,Port:9099,Host:,Scheme:HTTP,HTTPHeaders:[],},TCPSocket:nil,},InitialDelaySeconds:10,TimeoutSeconds:1,PeriodSeconds:10,SuccessThreshold:1,FailureThreshold:6,} ReadinessProbe:&Probe{Handler:Handler{Exec:nil,HTTPGet:&HTTPGetAction{Path:/readiness,Port:9099,Host:,Scheme:HTTP,HTTPHeaders:[],},TCPSocket:nil,},InitialDelaySeconds:0,TimeoutSeconds:1,PeriodSeconds:10,SuccessThreshold:1,FailureThreshold:3,} Lifecycle:nil TerminationMessagePath:/dev/termination-log TerminationMessagePolicy:File ImagePullPolicy:IfNotPresent SecurityContext:&SecurityContext{Capabilities:nil,Privileged:*true,SELinuxOptions:nil,RunAsUser:nil,RunAsNonRoot:nil,ReadOnlyRootFilesystem:nil,} Stdin:false StdinOnce:false TTY:false} is dead, but RestartPolicy says that we should restart it.

Docker logs from calico-node container:
Skipping datastore connection test
Using autodetected IPv4 address <IP_ADDRESS>/23, detected by connecting to <IP_ADDRESS>
Calico node '<IP_ADDRESS>' is already using the IPv4 address <IP_ADDRESS>:
 -  Check the node configuration to remove the IP address conflict
Terminating
Calico node failed to start

@mrrandrade do you have any update on your end for this issue?

I'm closing this as stale since there has been no response. We can reopen if we get new information to continue investigation.


[Feature]: Adds support for scrolling on datatable

This is a quick experiment to show how UX on QueryDataTable can be improved by listening to vertical wheel event on table and updating the rows rendered accordingly.
https://user-images.githubusercontent.com/14029371/202231411-9e3c85ba-924c-438c-9a69-21370a21bdbe.mov

Note: This only adds scroll to QueryDataTable. Would need to apply the same changes to DataTable component

I think we could hold fire on that - we are currently redoing the DataTable component completely so I'm not sure if we'll even have a scroll bar in the new implementation

@afzalsayed96 what do you think of this?
Works pretty well with my mouse. Anything I should be watching out for here?

This makes scrolling on my device way too dramatic with an external mouse:-
https://user-images.githubusercontent.com/14029371/207923198-18353f6a-2d5f-42b0-a297-90d8ff2a5e80.mov
So, I'm guessing it will vary from users to users.

Thanks, I'm going to revert and merge as before then
🙏 for all your help on this!

Thanks @Archie for all your inputs. Enjoyed brainstorming on this.
On Fri, Dec 16, 2022 at 1:31 AM Archie @.***> wrote:

Merged #465 https://github.com/evidence-dev/evidence/pull/465 into main.
—
Reply to this email directly, view it on GitHub
https://github.com/evidence-dev/evidence/pull/465#event-8050675849, or
unsubscribe
https://github.com/notifications/unsubscribe-auth/ADLBEO2ITQW4YOWEZBAZFL3WNN2JNANCNFSM6AAAAAASCMV2VM
.
You are receiving this because you were mentioned.Message ID:
@.***>


Make rack-mini-profiler opt-in

This gem has a small but sometimes noticeable effect on load times and local resources when providing profiling information, so it makes sense to only invoke it when we're going to make use of that information.
Set the env var RACK_MINI_PROFILER to true when you want to see profiling information (or if you want to put it back to how it was).
Before

After

Link to Trello card
https://trello.com/c/0M84STpQ/695-speed-up-app-development

 Speed up app development


fix: tiny typo in AggregatedStats

Description
This PR fix typo in AggregatedStats.
Related Issue(s)

closes #1515

Documentation

Thanks for doing this; this seems obvious right but I'm concerned about the fact that our unit tests didn't catch this. We are testing min values here:
https://github.com/delta-io/delta-rs/blob/549a74a4d9be0edb49c20e00e1817035f495e91b/rust/src/writer/stats.rs#L662-L664
Do you know why this missed this? Is this a different code path?

@wjones127
Our unit tests have only one row group, so we couldn't test the cases which use add_assign for AggregatedStats. I added new commit to fix it.