Add initial metrics to v0.4

Under this issue we will add initial metrics to the new architecture approach in v0.4.
An initial file with metrics calculations is available in the playground at: https://github.com/RTIInternational/teehr/blob/v0.4-beta/playground/pyspark/pandas_udfs_complete.py  Note this file contains both useful (e.g., NSE, KGE, etc.) and likely not useful UDFs (e.g., count, min, max) which are certainly already available in PySpark.  This file adds the decorator to the function definition, but that nis likely not a good idea since testing and utilizing these functions outside of PySpark will be more difficult if we continue this pattern.  A better pattern would be to define the function then create a new function with the decorator, something like this:
from pyspark.sql.functions import pandas_udf

def nse():
    # some code to calculate nse.
    pass

nse_udf = pandas_udf(nse, "float")

Then in PySpark we should first try the simplest approach of using the DataFrame API.  In some initial tests the SQL API was faster, but I think we should try to utilize and optimize the DataFrame API approach because it is much simpler to understand and extend.  Using this approach, we would have something like (note code is lazy so nothing actually happens until the end):
joined_df = (# Read in joined dataset using methods already in code.)

# apply one or more filters using methods already in code
# we are able to loop over filters and apply them one at a time using apply_filters()
joined_df = joined_df.filter()

# apply user requested grouping
grouped_df = joined_df.groupBy("some", fields") # our group by fields

# Assuming we will write an "calculate_metrics" function that loops over user requested metrics,
# reads the user provided input if any (e.g., name to use, bootstap parameters, perhaps a fields to use for a threshold, etc.)
# and adds them one at a time to the metrics_df using .agg(), like this:
metrics_df =grouped_df.agg(nse_udf("value_field", value_field"), alias="new_field_name"))

Note there will also likely be a step to run some "post metric" metrics.  For example, there may be a metric that takes other metrics as input.  So it might be filter -> group_by -> initial_metrics -> metric_postprocessing.  I will find an example, but in this case we will need to know the names of the initial_metrics that go into the metric postprocessing steps.  Also if the user requests a metric that must be calculated in post-processing we need to make sure that any initial metrics that are required are added.  Probably need some structure around this idea.
I'm sure there is more to say here...

@samlamont Just FYI incase you didn't see this: https://spark.apache.org/docs/3.1.1/api/python/user_guide/arrow_pandas.html#pandas-udfs-a-k-a-vectorized-udfs


Newlines within comments

Hello,
Currently the default behavior is (like in classic Markdown) to make new paragraphs from double newlines but to discard single newlines.
Is there a simple way to create  from newlines like in GitHub's flavored Markdown?
Thanks!

This should be fixed by the introduction of html render flags for misaka (hard-wrap  / HTML_HARD_WRAP)
See https://github.com/posativ/isso/blob/e6dbd21819f8fdca9fdace447e9ba01276e8d6a9/docs/docs/configuration/server.rst#markup

This should be fixed by the introduction of html render flags for misaka (hard-wrap  / HTML_HARD_WRAP)
See https://github.com/posativ/isso/blob/e6dbd21819f8fdca9fdace447e9ba01276e8d6a9/docs/docs/configuration/server.rst#markup


When I install scikit-optimize, "No matching distribution found for scikit-optimize"

I do pip install scikit-optimize, but it shows that,
Collecting scikit-optimize
Could not fetch URL https://pypi.python.org/simple/scikit-optimize/: There was a problem confirming the ssl certificate: [SSL: TLSV1_ALERT_PROTOCOL_VERSION] tlsv1 alert protocol version (_ssl.c:661) - skipping
Could not find a version that satisfies the requirement scikit-optimize (from versions: )
No matching distribution found for scikit-optimize
How can I deal with this problem?

Hello @jiangniao26 ,
Just tried in Ubuntu 16.04 container with python2.7 and pip v8.1.1, installation seems to work. Could you share more details about your system, in particular pip and python versions, and OS that you use?

Thanks @iaroslav-ai. It works now.


[compute/postgres] feature: PostgreSQL 17

Problem
We don't yet support PostgreSQL v17
Summary of changes
PG17 support, based on https://github.com/postgres/postgres/commit/07b828e9d4aa916f1763774787440d914eea69c4 (RC1 / 2024-09-04)

[x] Rebase our changes on top of v17
[x] Get v17's patches into separated commits per target area

[ ] Polish the commits to be actually separate: Several of them need some more work, and PG doens't compile for many of the intermediate commits.

[x] Update extension code to compile against v17
[x] Update Neon's code to compile against v17
[ ] Update & validate Pageserver's and Safekeeper's version-specific code for PG17
[ ] Update & validate pg_ffi/pgxn code
[ ] Patch PG17's ReadStream API internals to always prefetch calls, so including for sequential reads
[ ] Patch Neon's WALReader to pull WAL-pages from buffers (where possible) in PG17.
[x] Rebase on top of 17beta3 and/or 17rc0 if/when they release before this PR is merged

NOTICE: The data produced by this version of the PostgreSQL fork WILL NOT BE
COMPATIBLE with the future full release of PostgreSQL 17 due to expected
future changes in magic numbers.
DO NOT EXPECT DATA IN V17-TENANTS TO BE COMPATIBLE WITH THE 17.0 RELEASE!
Part of https://github.com/neondatabase/cloud/issues/12088
Checklist before requesting a review

[ ] I have performed a self-review of my code.
[ ] If it is a core feature, I have added thorough tests.
[ ] Do we need to implement analytics? if so did you add the relevant metrics to the dashboard?
[ ] If this PR requires public announcement, mark it with /release-notes label and add several sentences in this section.

Checklist before merging

[ ] Do not forget to reformat commit message to not include the above checklist

It was useful whille developing the test. It could be removed now, although it doesn't do any harm either


Find schema.org connection point for SOSA classes and properties

SOSA has 3 kinds of classes across 3 kinds of processes
Sensor             Sampler          Actuator                  - Agents
Observation    Sampling        Actuation                 - Activities or processes
Result              Sample           [change of state]      - Entities
In order to add SOSA terms into schema.org we should find connection points (or not) in current schema.org Types and Properties

http://schema.org/AchieveAction for activities and processes

http://schema.org/Thing                   for entities
http://schema.org/IntangibleThing   for observation results

http://schema.org/agent
http://schema.org/instrument
(properties of


Security.Config query

Hi James,
Thanks for an amazing product. It's such a great plugin and it's integration/use in Umbraco is a life saver.
I was wondering if you could provide some advice, I'm trying to see how I can have different settings in the settings.config file for different environments. Ideally I would like to keep using the LocalFileImageService for local developers, but then on the deployed environments use the CloudImageService, or another service, such as a the blob storage one. However I'm not sure of the best way to go about achieving this so thought I'd reach out.
Hope you can help/provide an idea?
Do you think having both enabled but with different prefixes (and changing the prefix depending on environment) would be a sensible approach?
Thanks,
Nik

You should use environment-specific config transforms for this, e.g. using SlowCheetah or Umbraco Cloud config transforms (if you're hosting the live-environment on UC).
In the config transform, you'd remove the LocalFileImageService and add the CloudImageService (or other required services).


Wavesurfer.js region events

I am trying to extend the region and timeline implementation from the example in the documentation linked here. I want to run a function on "region-click" or on "region-play" but to no avail. Is there a specific way to do this?
The Wavesurfer region events can be found here

This is how I tried on Angular 9

@DManujaya take a look at https://collab-project.github.io/videojs-wavesurfer/#/methods?id=wavesurferjs
And try:
player.wavesurfer().surfer.on('region-click', function(region, e) {
  console.log("YES!");
});

I also updated the plugin example to include this change.

Yup that works like a charm. Thanks a lot


fix core db imports in migrations

!test

Refer to this link for build results (access rights to CI server needed):
http://jenkins.2gis.local/job/vmmaster.staging.regression/278/
Test PASSed.

:+1:


using KMS for managing secrets for database credentials

I'm trying to run a rails application on appengine and connecting to cloudsql. is there any plan to use KMS to manage secrets for appengine?

Please take a look at this documentation: https://cloud.google.com/kms/docs/accessing-the-api#appengine. This might help you to get started to work on KMS with App Engine.


Add extended open multilingual wordnet reader

Related issue: https://github.com/nltk/nltk/issues/1611
Related NLTK data issue: https://github.com/nltk/nltk_data/issues/179
Extended open multilingual wordnet: http://compling.hss.ntu.edu.sg/omw/summx.html

Hey! We use pre-commit hooks to ensure code quality through our pre-commit config, which runs pyupgrade, black, isort and some other hooks. Using it is as simple as pip install pre-commit and then running pre-commit install. From then onwards, any time you commit to https://github.com/ExplorerFreda/nltk, it will run these hooks before committing.
The first time you might not have any changes to turn into a commit, so you can do pre-commit run --all or try to create an empty commit, and it will format your changes. You can then push this to make the CI stop complaining.

I recognise that this is a bit of an annoying situation, because any (automated) tests will fail due to extended_omw not yet existing in nltk_data, but perhaps you can provide a bit of sample code that should work if we (manually) download extended_omw and place it in our nltk_data folder?
Beyond that I added some small nitpicks. I can't really comment on the "real functionality", because I haven't been able to run it.

Hi @tomaarsen, thanks for the review and suggestions! I've changed the code correspondingly.
Below is the script for downloading the required data that should work:
cd $NLTK_DATA_DIR/corpora/
wget http://compling.hss.ntu.edu.sg/omw/wn-wikt.zip -O extended_omw.zip
unzip extended_omw.zip
mv data/ extended_omw/

It would be nice to add the following capabilities:

Loading the English wiktionary wordnet. This requires small modifications in the wordnet module because it does not anticipate English wordnets from alternative provenances at this moment.

Loading different wordnets for the same language separetely would allow to compare the quality of different provenances. The reason why the 'wikt' and 'cldr' provenances did not go into the official OMW 1.4 package was that their quality was deemed uncertain. For each language, this PR uses the set union of all provenances, which may be appropriate for some uses, but it would be nice to also support different use cases.

Combining extended_wordnet with newer wordnet packages like wordnet31 and wordnet2021. This would be easier if the extended_omw corpus reader was a leaner class, that could be added to any English Wordnet, including the forthcoming ones like Open English Wordnet 2022.

For completeness, maybe also consider adding back the Persian wordnet and the alternative Chinese wordnet from the old OMW package (in the 'pas' and 'qcn' directories), which were left out of OMW 1.4 for quality reasons though it is possible that some users miss them.

Resolved in #2946

@ExplorerFreda thanks for your work, which is appreciated even though we ended up accepting a different PR.


Xbox controller Elite 2 crash

Hi, recently purchased an Xbox Elite 2 controller and I connected it with Bluetooth to my MBP 2017 13” Touch Bar (macOS Ventura 13.6.4). I read of the issue with Feral games, so yesterday I downloaded your .plist files, changed “ProductID” to 2821 and everything was fine (except Select button).
Unfortunately, some hours later and after a reboot, the game crashes on startup if I have the controller connected with these files inside the specific game folder, specifically if “ProductID” is 2821 (instead of 2835 like your original files that doesn't work). I tried to use SteamInput without success and no way to solve the isse even uninstalling/reinstalling the game thought Steam or make an integrity check after download.
Feral told me to select go to System settings > Game Controllers, add Tomb Raider to the list of games and turn on the “Increase controller compatibility” toggle, but I still not see any kind of toggle: there isn't anything.

OK, let's try some troubleshooting.

Try the "old" version of the plist files linked in the readme
firmware update controller
factory reset controller
reboot mac one more time
make sure steam input is OFF. reread the readme to make sure no step was skipped.

I don't see that toggle either, maybe its only for mac app store version.
The select button not working is interesting, too bad I can't test it myself. I'd play around with the ButtonBack field in the plist.

I reply point to point.

I tried both new and old ones, changing "ProductID" to 2821. The game crashes on startup or, when the controller is turned on while the game is running, it crashes instantaneously (both on pre-game window and "in-game").
I can't update the controller firmware: I haven't an Xbox or Windows PC; I tried to use Windows inside a VM, but there's probably a recent bug in Xbox accessories app (crashes even without a controller connected).
I can't find a way to reset the controller.
Multiple MBP reboot doesn't solve anything.
I carefully read the guide, Steam Input is off.

Yes, I confirm that is the controller in the picture, only in White (I bought core version that is a bit cheaper).
I'm also emailing with Feral in order to try to solve the issue. After the compatibility toggle that I already tried, they told me to delete the "Preferences Data" file inside the game folder and restart my Mac, but even this solution isn't fine. So I reported to Feral (and I'm report to you) below some of other tests that I did.

If I connect the Elite 2 controller to my MBP with USB cable the controller isn’t recognized by any software, but inside System Information macOS recognize the controller: probably macOS doesn’t support USB game controllers.
The controller is successfully recognized inside a Windows VM on Parallels or some others virtualization software.
I can’t update controller firmware (actually version 9.0.3 according to your support report) in Windows VM on Parallels: when I open “Xbox Accessories” app, the app crash instantaneously… even without the controller connected, I tried all of this like reinstall app, reinstall Windows OS, change from Windows 11 to 10, etc. It is probably a bug from Microsoft..?
Uninstall and reinstallation of Steam solved nothing.
Installing Steam in beta version solved nothing.
I tried to remove manually ALL of kexts of Steam inside macOS (Steam Input, Steam Audio, Ambrosia Audio, etc.) but the issue is still here.
If I use Steam Input, Steam recognize the controller (only connected via Bluetooth) and it works partially: if I run Tomb Raider, it recognize a fake “Xbox 360 Controller” but it doesn’t work.
If I use Steam Input + Steam Stream to my Apple TV and I connect the controller via Bluetooth to my Apple TV, if I run Tomb Raider it recognize a fake “Xbox 360 Controller” and it works (ironically, the audio on Apple TV doesn’t work).
On Rise of Tomb Raider the controller works ONLY if I use Steam Input (I haven’t tried yet on Shadow of Tomb Raider).

Hmmm, what does the System Report from the Tomb Raider launcher say about your controller? Mine says:

Xbox Wireless Controller:
Vendor ID: 0x045E
Product ID: 0x0B20
Firmware Version: 5.17.3202.0

If you have the latest then we can rule that out.

Do you happen to have forced Metal HUD running? Maybe disable it. https://www.reddit.com/r/MacOS/comments/16ptjpi/comment/k58bx53/?utm_source=reddit&utm_medium=web2x&context=3

Oh, factory reset doesn't seem to be a thing. Try holding the sync button until it vibrates, pair it to something else, then repeat pairing back to mac.

Run the system report when the controller is connected wired, the wired ProductID is different for my Xbox One S controller. Then modify the XboxOne plist that corresponds to the wired controller.

I've used a wired Xbox One S controller in Tomb Raider 2013 in the past with no problems. (In fact I didn't need to modify anything.)

yea, steam link from a mac not having audio is a steam issue. :cry:

If none of these work I have no more ideas. Maybe Xbox One controllers have better support...

Ok, now I have some good and bad news. I successfully update my Elite 2 controller via a Windows VM with VMWare Fusion, so the firmware version is now 5.17.3202.0; interestingly, also the ProductID in wireless changed from 2821 to 2850. Now, editing .plist file, the controller works in wireless without Steam Input ONLY on Shadow and Rise of Tomb Raider, instead on Tomb Raider the issue still persists. It is probably due to the additional buttons of Elite series controllers, so I mailed again Feral and I'm waiting if they can help me.
1a. Wireless System Report

Xbox Wireless Controller:
Address: [hide]
Vendor ID: 0x045E
Product ID: 0x0B22
Battery Level: 100%
Firmware Version: 5.17.3202.0
Minor Type: Gamepad
Services: 0x400000 < BLE >

1b. Wired System Report

Controller:
Product ID: 0x0b00
Vendor ID: 0x045e  (Microsoft Corporation)
Version: 5.11
Serial Number: [hide]
Speed: Up to 12 Mb/s
Manufacturer: Microsoft
Location ID: [hide]
Current Available (mA): 500
Extra Operating Current (mA): 0

Metal HUD is still disabled.
Now I tried but don't solved the issue.
I tried but via USB the controller isn't recognized by macOS: I googled a bit, probably Apple removed the .kext, so any wired controller don't work anymore on macOS and you should use only wireless controller. There was an experimental project on GitHub in order to make new .kext, but there isn't anything new with the change of Apple to DriverKit APIs to replace the "old-fashioned" kernel extension.
For Steam Link: RIP.

Try restarting Tomb Raider to see if controller starts working. Glad to hear that the others work. I just redownloaded Tomb Raider and controller only worked second time.
Try modifying XboxOneController.plist with the productID with the wired variant. My Xbox One S controller works wired even if I remove the bluetooth plist. Even though macOS doesn't recognize it, the game recognizes it. It's game level support, not OS level support.

Cool! Just to confirm is this the software you used to update the firmware?
https://www.vmware.com/products/fusion.html
I'm pretty disappointed that Tomb Raider 2013 doesn't detect it over Bluetooth while the rest do. Can you try again just one more time? It doesn't show up in the launcher at all?
(Also, the changing from hex to decimal step might not be necessary.)
Also, can you upload the plists that worked for you to this repo? Just fork the repo, upload files, and pull request.

Yes, the virtualization software is VMWare Fusion (plus: the license is free for home use).
Via Bluetooth, I confirm that there is a crash immediately... I can't see anything, just the TR icon in the Dock which suddenly disappears and macOS opens the "Crash Feedback to Apple" window (I don't remember what exactly it's called).
Sure... but I'm a newbie GitHub user, I'm not a programmer at all, I attached the file here and I hope it's ok: I had to change the extension to .txt otherwise I couldn't upload it, just change the extension to .plist. XboxOneController.txt
I'm not sure, but I seem to have already deleted inputdevices.json from TR during my numerous tests over the past few days.... however, I can confirm that it does not exist in Rise/Shadow of TR.

Interesting, I wonder if it would work if you added the json back then. You can probably just verify to get it to redownload.

Hi guys, first, thanks a lot for these findings.  I had trouble connecting my Xbox One Controller via BT and found this thread. If it helps somebody, finally it works, and my result: you need only two actions to achieve it:

Download the XboxOneControllerSBluetoothv5.plist file from this repository and place it into the .../InputDevices/Digital folder.
Delete inputdevices.json from the root of the repository.

@axu2: thanks a lot for the hints!

@stimg please edit the readme with a note that deleting the JSON might be needed.

Could anyone test whether the new macos 14 feature of "increase controller compatibility" works? It will map a modern controller to the 360 plist.


Serenity/JS 3.0 - Report graph errors due to missing bootstrap minified files for datatables v1.10.20

When reporting using Serenity-js version 3.0.0-rc.19, the folder generated does not include the bootstrap datatables files minified. Instead, it includes the following folder tree

when the report search for the bootstrap version 1.10.20 it fails

Hi @maxe2y, I use this version of Serenity/JS on my own and my report works fine. So maybe you can provide a bit more context of your project setup?
What Serenity/JS modules do you use?
I assume, this report has worked before for you. With which version did it worked the last time for you?
It's hard to tell what's the problem here, without knowing more.
Would you be able to create a minimal reproducible example in a repo on GitHub? I tried to reproduce the issue using the cucumber template.

clone the repo
switch to the main branch
delete the package-lock.json (because of some old references in there)
run npm install
run npm test

In my case the report was created including all graphs.

Yes sure
It worked for latest version 2
I'm using yarn test  in this project
https://github.com/maxe2y/Serenity_V3
you can check on your local it uses the webdriver template , but with Serenity V3 applied
the report is uploaded and you can check each file generated.
In the index.html file lines 87-88
image
it requires datatables dependencies that do not exist in the report folder as I mentioned before
also there are more dependecies error in the browser console

I was able to reproduce this with your repo, partly, though the project is taken from the 'master' branch, which is still on 2.x and does not include the changes, as it would be on the 'main' branch. So tests won't run at all.
But I think I got a least a trace. Do you have something like
[test:execute] [0-0] error: unknown option '--strict'

in your console log when running yarn test?
Can you check your wdio.conf.ts and set strict: false in the cucumberOpts?

Do you have a fully functional branch of webdriver with serenity 3

At least I thought so ;)
Just use the main branch of the template instead of the master: https://github.com/serenity-js/serenity-js-cucumber-webdriverio-template/tree/main
Then delete the package-lock.json and I would assume, that a yarn install and yarn test should work, as well.

If you’d like to rule out cucumber, there would be also an example using mocha: https://github.com/serenity-js/serenity-js-mocha-webdriverio-template/tree/main

https://github.com/serenity-js/serenity-js-cucumber-webdriverio-template/compare/main...maxe2y:main
failing the same way same lines

 🤔
can you confirm this text is printed out in the scenario on your side too?

I will try out again 👍

Hi @maxe2y,
so, just to be sure, this is the report you've generated and the last screenshot is taken from this report, right?
Because then it's getting even more weird:
If I just clone your repo, switch to the main branch containing the report, open it locally in Firefox (or Chrome, doesn't matter) I see a report that looks quite good to me. Don't can confirm the issues from your screenshot, though I assume we're looking at the same report. 🤔

As provided by the report, you are on Mac OS X, right. I'm on Windows 11, and not used to Mac OS at all. Could it be, that some css stuff or something is blocked or old stuff is cached in your browser cache.

Great!
Now just focus in the main issue we are talking about
"Report graph errors due to missing bootstrap minified files for datatables v1.10.20"
those errors appears in the dashboard and the dependency is missing
Did you check the index.html file generated?

So, one step closer - I have nearly the same errors in the dashboard.
No difference between the files, you've provided and when I would generate the report on my own.
Though, my dashboard looks ok.

What is missing on my side is the very first error which can be seen in your screenshot from the issue description:
Refused to apply style from '<URL>' because its MIME type ('text/html') is not a supported stylesheet MIME type, and strict MIME checking is enabled..

Do you access the report from a file, directly, or from a web server?
@jan-molak, can you please check? This is most likely an issue with the serenity-bdd reporter, right?  Have a look here:  https://github.com/serenity-bdd/serenity-core/issues/1971
I  already tried latest Serenity-BDD cli 3.2.5 using the artifact parameter - but with that I got even more errors in the console log ... 🤔
(Just to make the relation: Update of the cli is blocked by https://github.com/serenity-js/serenity-js/issues/1147 anyway).

@maxe2y , as a workaround, you could always try to apply the artifact parameter to force usage of an older version, aka the version of the bdd cli which worked for you before with Serenity/JS 2.x

I'm not migrating to Serenity V3 until is stable 👍

@maxe2y - out of curiosity, could you please try with Serenity BDD CLI version 3.2.5?
"test:update-serenity": "serenity-bdd update --ignoreSSL --artifact=net.serenity-bdd:serenity-cli:jar:3.2.5",
"test:report": "serenity-bdd run --artifact=net.serenity-bdd:serenity-cli:jar:3.2.5"

I will be a try

Yup
looks better

Great, thanks for confirming @maxe2y. Please let me know if you spot any errors.
I'm doing some exploratory testing with it now, but if neither of us find any issues I'll update Serenity/JS 3.0.0-rc to use Serenity BDD 3.2.5

@jan-molak, please wait with the update. Remember, there is still this pending issue https://github.com/serenity-js/serenity-js/issues/1147
I can retry with latest 3.2.5 version though and give feedback.

@jan-molak , issue with mocha specs is still not solved in 3.2.5, see #1147

Thanks for confirming @aukevanleeuwen, glad 3.2.5 is working for you.
@viper3400 - let's finish #1236 and see what can be done about #1147.

@aukevanleeuwen - it looks like the issue with the broken report might have been caused by a bug fixed in c5ca1bf and released in 3.1.4.
Serenity BDD does not escape HTML tags present in the json reports, so Serenity/JS had to escape them before handing the data over to Serenity BDD.
Please let me know if you come across this (or any other issue) again. Thanks!

release 3.15.0 fixes the issues with css, now that it comes with serenity-cli-4.0.43.


Remove Keybase form the mobile wallet

Keybase support will be removed. I will keep bridge interfaces but put asserts there.
So you will need to get rid from those calls.
When this ticket will be done, I will continue and remove the bridge interfaces.

@bayk I removed all keybase related things in mobile in https://github.com/mwcproject/mwc-qt-wallet/pull/669
So now you are fine to remove the bridge interfaces.

done, closed

done, closed


Add v2 context

See: https://github.com/w3c/vc-data-integrity/tree/main/contexts/data-integrity

Closing, addressed #4


Feat cli help command

No breaking changes have been made in the "Why.ts" file, I just removed the \n from the command description.

recheck

CLA Assistant Lite bot: Thank you for your submission, we really appreciate it. Like many open-source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution. You can sign the CLA by just posting a Pull Request Comment same as the below format.

I have read the CLA Document and I hereby sign the CLA

You can retrigger this bot by commenting recheck in this Pull Request

I have read the CLA Document and I hereby sign the CLA

@all-contributors please add @Nazeofel for code

@all-contributors please add @Nazeofel for code

@all-contributors please add @Nazeofel for code

@all-contributors please add @Nazeofel for maintenance


README.md code fix (deepgram -> deepgramClient)

Updates the readme with a code fix.

Thanks for cleaning this up @edandersen!


Menu bars aren't flashed when keyboard shortcuts are used

Halp ticket

support/3c957af0c7a211e39af58f4647ff645a

As a Mac user, in general, I expect the appropriate menu bar item to flash blue (or, I guess the system highlight color) when I use a keyboard shortcut. Without this visual feedback, I constantly find myself second-guessing whether or not I've hit the keys for the shortcut hard enough to actually trigger the shortcut.

Woah, this is a OSX feature?

Some of us expect it, and use it as a visual proof that we hit the correct shortcut : )
I just spent a few seconds hitting CMD+C repeatedly, thinking it wasn't working because the menu didn't flash ; )

@bomberstudios You know what, I must say I've definitely become more accustomed to it these days. I still don't need it there, but I wouldn't quite call it "stupid flashing" any more.
In fact I occasionally use it (not in Atom) to work out where a given keyboard shortcut's original menu item is located - seeing which menu flashes can narrow it down a fair bit.


ext: debug: segger: Add missing include directories

Fix #11812 by adding include paths to the CMakeLists.txt
Signed-off-by: Sigvart M. Hovland<EMAIL_ADDRESS>

Codecov Report

Merging #11813 into master will decrease coverage by 0.76%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master   #11813      +/-   ##
==========================================
- Coverage   48.29%   47.53%   -0.77%
==========================================
  Files         280      280
  Lines       43333    43303      -30
  Branches    10375    10366       -9
==========================================
- Hits        20929    20583     -346
- Misses      18252    18654     +402
+ Partials     4152     4066      -86

Impacted Files
Coverage Δ

include/net/ethernet.h
31.25% <0%> (-25%)
:arrow_down:

include/net/net_if.h
46.15% <0%> (-16.67%)
:arrow_down:

include/net/net_linkaddr.h
28.57% <0%> (-14.29%)
:arrow_down:

subsys/net/ip/net_if.c
50.23% <0%> (-12.66%)
:arrow_down:

subsys/net/ip/ipv6_nbr.c
20.37% <0%> (-9.16%)
:arrow_down:

subsys/net/l2/ethernet/ethernet.c
48.08% <0%> (-7.93%)
:arrow_down:

subsys/net/ip/ipv6.c
50.38% <0%> (-3.85%)
:arrow_down:

subsys/net/ip/icmpv6.c
27.06% <0%> (-3.76%)
:arrow_down:

include/net/net_ip.h
65.38% <0%> (-2.75%)
:arrow_down:

subsys/net/ip/net_core.c
63.81% <0%> (-1.98%)
:arrow_down:

... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a127984...b88d8c7. Read the comment docs.

I guess I should add an use case why it could be nice to have <> include for the SEGGER_RTT_Conf.h
My current use case is that I want to have a separate SEGGER_RTT_Conf.h file which differs from what is included in Zephyr but I don't want to modify the code which is included in Zephyr so I want use a from of INCLUDE BEFORE directive in Cmake. However this won't work with the current setup as it uses relative to file includes instead of INCLUDE_SEARCH_PATH so it's impossible to override the file selection for config. So this patch does not fix all the problems but i thought I would split it up into two.
As this is more a correctness patch which doesn't fix anything but doesn't break anything either it just sets the CMakeLists.txt to be as expected by the user.


WIP: Add textarea

Close #18
Blocked by #19

I know it's not specified in design, but fixed height is not much usable. What about props that sets number of rows?

The question is if the UI team will ever use different height in their design. I asked on the Slack.

I think I resolved all comments.

But we're still waiting for the info about the height. https://skypicker.slack.com/archives/C9B1H0ACW/p1519387170000322

@VaclavSir Please resolve merge conflicts.

[x] Merge conflicts resolved.


Add a security.txt and link to the footer

Signed-off-by: Paulo Lopes<EMAIL_ADDRESS>This PR adds a link to allow security reports to be visible from the footer or using the RFC:
https://datatracker.ietf.org/doc/html/draft-foudil-securitytxt-12

The builds works on my machine, I've requested a review just to ensure that I don't break the aesthetics of the footer and that the content on the security.txt is ok

@pmlopes I've moved the link to the "Resources" column in the footer because I think it makes more sense there. According to https://securitytxt.org/, the date format has recently changed to ISO 8601, so I fixed that too.


How to get dataset?

Amazing work. I wonder how to get the dataset.

Sorry, some datasets (multiview cars and planes) are required for the open-source license and we are applying for it.
The other datasets are open-sourced dataset, such as nerf_synthetic, DTU, nerf_real, mip-nerf360.


Accessing and Uploading Files in MyData Using upload_api and add_file_api

Problem Description:
I am uploading files to the MyData folder through the UI. The sources_dir already contains text files related to the LLM, UserData, and MyData which has information related to the files name. However, I am facing difficulty accessing the MyData folder and its files similarly to how I can access the user_path that contains documents uploaded to UserData through the UI.
Expected Behavior:
I would like to:
Access the MyData folder and retrieve the files stored in it, just like I can with the user_path for UserData.
Upload files to both MyData and UserData using the existing upload_api and add_file_api.
Current Behavior:
I am able to upload files to UserData via the UI, but I cannot access or interact with MyData in a similar manner.
Unclear on how to use the APIs to upload files directly to MyData and UserData.
Request:
Could you provide a solution or example code demonstrating how to:
Access and retrieve files from the MyData folder.
Upload files to both MyData and UserData using upload_api and add_file_api.
Sample Code Request:
I would appreciate a code example illustrating the following use cases:
Uploading files to MyData and UserData using upload_api and add_file_api.
Accessing and listing files in the MyData directory similarly to how it’s done with the user_path.

Personal scratch collections like MyData are not persisted unless you use enable the auth db so that users can login.
I have a FAQ for the item you are asking about I think: https://github.com/h2oai/h2ogpt/blob/main/docs/README_LangChain.md#per-user-database


Terraform 12

This is an attempt to get "terraform 12" hcl (should be good for future versions) working.  Most notably, you do NOT need to wrap up values from other terraform resources in interpolation if there is no other string to include.

I am aware that not all tests are passing yet, there are some reorderings still necessary (the newer tool used for parsing returns modules in alphabetical order) in tests, as well as terragrunt fixes I still have to investigate.

Thanks for diving into this @jmahowald! Would this approach support both versions? I don't think so, right? Typically that's what we've been trying to do with these major version updates, but in this case since HCL 1 doesn't really seem to be used that much anymore, we might be able to drop support for it when we upgrade. I'll try to pull some usage data on this, but also curious to hear your thoughts.

This should work with both, most of the spec tests are working unchanged, the two parsers simply return a different ordering for modules.    I've used hcl2json on both versions of terraform in other contexts as well.

😢 Unless I'm missing something this is a dupe of https://github.com/dependabot/dependabot-core/pull/1388
@jmahowald time might be better spent getting tf014 support added to 1388 or to @patrickjahns' fork. I would, but I don't have the cycles

😢 Unless I'm missing something this is a dupe of #1388
@jmahowald time might be better spent getting tf014 support added to 1388 or to @patrickjahns' fork. I would, but I don't have the cycles

@jurre  after having to watch team members update 20 some repos with simple version updates I'm certainly willing to move my energy to seeing if I can help along #1388 but that issue appears stalled. I'm not sure if that stalling is because of the issue that @userhas404d  has found, or if it's just stalled for other reasons. I understand you can't make a commitment, but do you think that if we can resolve the issues there you'd likely be able to look at it in the nearish future?

😢 Unless I'm missing something this is a dupe of #1388
@jmahowald time might be better spent getting tf014 support added to 1388 or to @patrickjahns' fork. I would, but I don't have the cycles

There weren't meaningful language changes that I'm aware of that should be different from 12 to 14 from an HCL parsing perspective, though it certainly would make sense for dependabot in terraform 13+ to handle the new ways of declaring provider versions.  Are there language changes you're thinking that should be there for 14 that would require other changes than what you made to support HCL 2?

Are there language changes you're thinking that should be there for 14 that would require other changes than what you made to support HCL 2?

thinking specifically about the new dependency lock file: https://www.terraform.io/docs/language/dependency-lock.html lock file specific update logic either needs to be added to the terraform update workflow or ignored outright.

@jurre after having to watch team members update 20 some repos with simple version updates I'm certainly willing to move my energy to seeing if I can help along #1388 but that issue appears stalled. I'm not sure if that stalling is because of the issue that @userhas404d has found, or if it's just stalled for other reasons. I understand you can't make a commitment, but do you think that if we can resolve the issues there you'd likely be able to look at it in the nearish future?

It's mostly stalled because we haven't been able to get to it yet. We have planned to add support for Terraform HCL 2 this quarter, but have committed to a few other ecosystem upgrades (npm/bundler) before that. Given that the team working on these updates is pretty tiny, we're focussing on one upgrade at a time.
Any issues that you're able to tackle are definitely very much appreciated, we just might be a little slow to respond/review. 💛

Terraform 12 (HCL 2) support is now available, thank you so much for this PR, it was instrumental in landing this.


New feature suggestion: correlating calendars

Hi @nikhil-001mehta ,
I'm glad to see the new useful features you've added and the nice work that are you doing.
So today I'm here to suggest a new feature.
Is it possible to "connect/correlating" the two calendar? Let me explain it better:

in the first calendar, we have January and in the second February.

If the user selects the next month, both calendars update, so the first has February, and the second has March.
If the user selects the previous month, both calendars update, so the first has December, and the second has January.

I can choose the start date and the end date on the same calendar.

I give you a working example to make you understand better  what I mean -> http://airbnb.io/react-dates
Do you think that this is a possible implementable option? Maybe the logic you've used on your datePicker is not "compatible" with this scenario? Or maybe my suggestion is completely out of scope?
Let me know what you thinks.
Thanks

@MFava91 Thanks a lot. I am glad that my work it helping to reduce efforts.
regarding your suggestions, Yes that can be done. Will have to look how much efforts it will take.
It is can be done easily I guess I will give it a try.

Wonderfull!!! Let me know if/when you look at it.
Also, in the next few weeks, I have some free time after work so I can take a look at the code and help if you need.
So, keep me up to date and good work.


[FEATURE] Securely erase data when deleting volumes, trim FS volume

Is your feature request related to a problem? Please describe (👍 if you like this request)
There are two cases to consider when providing an option for users to erase their data securely.

The replicas should be securely erased when deleting a volume, especially v1 volumes running on host FS.
When trimming an FS volume, securely erase replica disks instead of zero punching holes only.

Describe the solution you'd like

Describe alternatives you've considered

Additional context

What is the specification of secure erase?  Is it sufficient to overwrite once with zeros?  Or multiple passes with random data?


Allow "cache-and-network" fetch policy with useQuery again

In<EMAIL_ADDRESS>the cache-and-network fetch policy has been removed from the FetchPolicy type, as documented here: https://github.com/apollographql/apollo-client/blob/master/CHANGELOG.md#apollo-client-260-1
This results in type errors in any project that tries to use the cache-and-network fetch policy with useQuery using<EMAIL_ADDRESS>(currently the latest release). To be clear, this very simple (valid!) use-case now results in a type error:
const { data } = useQuery(gql`...`, {
  fetchPolicy: 'cache-and-network', // Type '"cache-and-network"' is not assignable to type '"cache-first" | "network-only" | "cache-only" | "no-cache" | "standby" | undefined'.
})

It also results in the following type errors in the project:

(7 type errors, click to expand...)
><EMAIL_ADDRESS>typings-check /Users/harry/node_modules/react-apollo-hooks
> tsc --noEmit

node_modules/react-testing-library/typings/index.d.ts:13:46 - error TS2344: Type 'typeof import("/Users/harry/node_modules/react-apollo-hooks/node_modules/dom-testing-library/typings/queries")' does not satisfy the constraint 'Queries'.
  Property 'findByLabelText' is incompatible with index signature.
    Type 'FindByText' is not assignable to type 'Query'.
      Type 'Promise<HTMLElement>' is not assignable to type 'HTMLElement | HTMLElement[] | null'.
        Type 'Promise<HTMLElement>' is missing the following properties from type 'HTMLElement[]': length, pop, push, concat, and 26 more.

13 export type RenderResult<Q extends Queries = typeof queries> = {
                                                ~~~~~~~~~~~~~~

node_modules/react-testing-library/typings/index.d.ts:28:52 - error TS2344: Type 'typeof import("/Users/harry/node_modules/react-apollo-hooks/node_modules/dom-testing-library/typings/queries")' does not satisfy the constraint 'Queries'.

28 export interface RenderOptions<Q extends Queries = typeof queries> {
                                                      ~~~~~~~~~~~~~~

src/__tests__/getMarkupFromTree-test.tsx:163:15 - error TS2322: Type '"cache-and-network"' is not assignable to type '"no-cache" | "cache-first" | "network-only" | "cache-only" | "standby" | undefined'.

163               fetchPolicy="cache-and-network"
                  ~~~~~~~~~~~

  node_modules/apollo-client/core/watchQueryOptions.d.ts:18:5
    18     fetchPolicy?: FetchPolicy;
           ~~~~~~~~~~~
    The expected type comes from property 'fetchPolicy' which is declared here on type 'IntrinsicAttributes & UserWrapperProps'

src/__tests__/getMarkupFromTree-test.tsx:180:15 - error TS2322: Type '"cache-and-network"' is not assignable to type '"no-cache" | "cache-first" | "network-only" | "cache-only" | "standby" | undefined'.

180               fetchPolicy="cache-and-network"
                  ~~~~~~~~~~~

  node_modules/apollo-client/core/watchQueryOptions.d.ts:18:5
    18     fetchPolicy?: FetchPolicy;
           ~~~~~~~~~~~
    The expected type comes from property 'fetchPolicy' which is declared here on type 'IntrinsicAttributes & UserWrapperProps'

src/__tests__/useQuery-test.tsx:512:9 - error TS2322: Type '"cache-and-network"' is not assignable to type '"no-cache" | "cache-first" | "network-only" | "cache-only" | "standby" | undefined'.

512         fetchPolicy="cache-and-network"
            ~~~~~~~~~~~

  node_modules/apollo-client/core/watchQueryOptions.d.ts:18:5
    18     fetchPolicy?: FetchPolicy;
           ~~~~~~~~~~~
    The expected type comes from property 'fetchPolicy' which is declared here on type 'IntrinsicAttributes & TasksWrapperProps'

src/__tests__/useQuery-test.tsx:531:7 - error TS2322: Type '"cache-and-network"' is not assignable to type '"no-cache" | "cache-first" | "network-only" | "cache-only" | "standby" | undefined'.

531       fetchPolicy="cache-and-network"
          ~~~~~~~~~~~

  node_modules/apollo-client/core/watchQueryOptions.d.ts:18:5
    18     fetchPolicy?: FetchPolicy;
           ~~~~~~~~~~~
    The expected type comes from property 'fetchPolicy' which is declared here on type 'IntrinsicAttributes & TasksWrapperProps'

src/useQuery.ts:95:7 - error TS2367: This condition will always return 'false' since the types '"no-cache" | "cache-first" | "cache-only" | "standby" | undefined' and '"cache-and-network"' have no overlap.

95       actualCachePolicy === 'cache-and-network')
         ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

Found 7 errors.

This issue has actually been reported here: https://github.com/apollographql/apollo-client/pull/4849
The fix is to simply change the QueryOptions type to WatchQueryOptions, as useQuery uses watchQuery (which allows the cache-and-network fetch policy), and not query (which doesn't).
This exact change is implemented in the commit https://github.com/trojanowski/react-apollo-hooks/commit/184a7b5a6cb13e99064409fc86ca359e12535bc1 (check this diff to look at the actual code changes!)
As a separate commit, I also ran npm run format. I initially did this to ensure that I did not introduce new style errors, but I actually found style errors in unrelated files. I hope this is not too controversial to add, if not I can revert/rebase.
When running npm run check-typings, I now only get 2 type errors, none of which are related to the fetch policy, and actually seem completely unrelated to the project:

(2 type errors, unrelated to this change, click to expand...)
><EMAIL_ADDRESS>typings-check /Users/harry/node_modules/react-apollo-hooks
> tsc --noEmit

node_modules/react-testing-library/typings/index.d.ts:13:46 - error TS2344: Type 'typeof import("/Users/harry/node_modules/react-apollo-hooks/node_modules/dom-testing-library/typings/queries")' does not satisfy the constraint 'Queries'.
  Property 'findByLabelText' is incompatible with index signature.
    Type 'FindByText' is not assignable to type 'Query'.
      Type 'Promise<HTMLElement>' is not assignable to type 'HTMLElement | HTMLElement[] | null'.
        Type 'Promise<HTMLElement>' is missing the following properties from type 'HTMLElement[]': length, pop, push, concat, and 26 more.

13 export type RenderResult<Q extends Queries = typeof queries> = {
                                                ~~~~~~~~~~~~~~

node_modules/react-testing-library/typings/index.d.ts:28:52 - error TS2344: Type 'typeof import("/Users/harry/node_modules/react-apollo-hooks/node_modules/dom-testing-library/typings/queries")' does not satisfy the constraint 'Queries'.

28 export interface RenderOptions<Q extends Queries = typeof queries> {
                                                      ~~~~~~~~~~~~~~

Found 2 errors.

Anyway, hope this is useful for anyone who accidentally upgraded to<EMAIL_ADDRESS>& broke their TypeScript projects! :)

Took a look at the CI results - I'm just realised that this repo has<EMAIL_ADDRESS>as a dependency (accidentally used npm instead of yarn which obviously ignored the lock file... #jslife). Upgrading that dependency to<EMAIL_ADDRESS>results in some other type errors that I don't really understand at first glance.

(type errors, click to expand)
$ tsc --noEmit
node_modules/apollo-client/core/QueryManager.d.ts:73:117 - error TS2707: Generic type 'FetchResult' requires between 0 and 2 type arguments.

73     observeQuery<T>(queryId: string, options: WatchQueryOptions, observer: Observer<ApolloQueryResult<T>>): Promise<FetchResult<T, Record<string, any>, Record<string, any>>>;
                                                                                ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

src/useQuery.ts:134:5 - error TS2345: Argument of type '() => { data: undefined; error: undefined; loading: false; networkStatus: undefined; fetchMore: (fetchMoreOptions: FetchMoreQueryOptions<TVariables, string | number | symbol> & FetchMoreOptions<TData, TVariables>) => Promise<...>; refetch: (variables?: TVariables | undefined) => Promise<...>; startPolling: (pollInte...' is not assignable to parameter of type '() => QueryHookResult<TData, TVariables>'.
  Type '{ data: undefined; error: undefined; loading: false; networkStatus: undefined; fetchMore: (fetchMoreOptions: FetchMoreQueryOptions<TVariables, string | number | symbol> & FetchMoreOptions<TData, TVariables>) => Promise<...>; refetch: (variables?: TVariables | undefined) => Promise<...>; startPolling: (pollInterval: ...' is not assignable to type 'QueryHookResult<TData, TVariables>'.
    Type '{ data: undefined; error: undefined; loading: false; networkStatus: undefined; fetchMore: (fetchMoreOptions: FetchMoreQueryOptions<TVariables, string | number | symbol> & FetchMoreOptions<TData, TVariables>) => Promise<...>; refetch: (variables?: TVariables | undefined) => Promise<...>; startPolling: (pollInterval: ...' is not assignable to type 'QueryHookResult<TData, TVariables>'.
      Types of property 'updateQuery' are incompatible.
        Type '(mapFn: (previousQueryResult: TData, options: UpdateQueryOptions<{}>) => TData) => void' is not assignable to type '<TVars = TVariables>(mapFn: (previousQueryResult: TData, options: UpdateQueryOptions<TVars>) => TData) => void'.
          Types of parameters 'mapFn' and 'mapFn' are incompatible.
            Types of parameters 'options' and 'options' are incompatible.
              Type 'UpdateQueryOptions<{}>' is not assignable to type 'UpdateQueryOptions<TVars>'.
                Type '{}' is not assignable to type 'TVars'.

134     () => {
        ~~~~~~~

src/useSubscription.ts:82:23 - error TS2345: Argument of type '{ data: ExecutionResultDataDefault | undefined; error: undefined; loading: boolean; }' is not assignable to parameter of type 'SubscriptionHookResult<TData>'.
  Types of property 'data' are incompatible.
    Type 'ExecutionResultDataDefault | undefined' is not assignable to type 'TData | undefined'.
      Type 'ExecutionResultDataDefault' is not assignable to type 'TData'.

82             setResult(newResult);
                         ~~~~~~~~~

src/useSubscription.ts:86:17 - error TS2322: Type '{ data: ExecutionResultDataDefault | undefined; error: undefined; loading: boolean; }' is not assignable to type 'SubscriptionHookResult<TData>'.

86                 subscriptionData: newResult,
                   ~~~~~~~~~~~~~~~~

  src/useSubscription.ts:20:3
    20   subscriptionData: SubscriptionHookResult<TData>;
         ~~~~~~~~~~~~~~~~
    The expected type comes from property 'subscriptionData' which is declared here on type 'OnSubscriptionDataOptions<TData>'

Found 4 errors.

If someone has pointers how to resolve those, that'd be great - otherwise maybe a workaround for now could be just to set theapollo-client peerDependency from  * to ^2.4.7?
Nice one, thank you :)

If someone has pointers how to resolve those, that'd be great - otherwise maybe a workaround for now could be just to set theapollo-client peerDependency from * to <2.6.0 or similar?

When I opened PR #169 just now I took the easy way and upgraded to a recent TypeScript version. Seems like something else changed in apollo-client and this looks like the easiest fix.

Sounds good, thanks for taking a look! Guess this PR can be closed then? (cc #163)

Fixed in version 0.5.0.

Excellent, thanks a lot @trojanowski and @sgoll!


xtensa: intel_s1000: turn on XTENSA_ASM2

Turns on XTENSA_ASM2 by default for intel_s1000.
Fixes #11034
Signed-off-by: Daniel Leung<EMAIL_ADDRESS>

Codecov Report

Merging #13510 into master will decrease coverage by <.01%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master   #13510      +/-   ##
==========================================
- Coverage    52.5%    52.5%   -0.01%
==========================================
  Files         318      318
  Lines       46527    46527
  Branches    10755    10755
==========================================
- Hits        24429    24428       -1
  Misses      17199    17199
- Partials     4899     4900       +1

Impacted Files
Coverage Δ

arch/posix/core/posix_core.c
90.9% <0%> (-1.02%)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 406dc2c...982b1af. Read the comment docs.


[WIP] Update code

Update code

          1 Warning

:warning:
PR is classed as Work in Progress

  Generated by :no_entry_sign: Danger


Crashtracker receiver is spawned on crash

What does this PR do?
Changes the way the crashtracker receiver works

Uses an anonymous AF_UNIX socketpair for communication instead of a stdio pipe
Eliminates some of the public API, such as being able to initialize with a named UDS
Binds the lifetime of the receiver to the signal handler, being very careful to manage certain signals
Increases the altstack size to accommodate the slightly higher stack utilization
Tries really hard to reap the receiver exit status, so other PIDs do not
Other miscellanea

This PR isn't yet complete, as it requires more tests and an RFC.  But please feel free to comment on what you see!
Motivation
Some runtimes actually call waitpid(-1,... anticipating an ECHILD, which is incompatible with the idea of a long-lived receiver process.  We also wanted to improve some of the safety around how signals work.
Additional Notes
Anything else we should know when reviewing?
How to test the change?
Describe here in detail how the change can be validated.

How does this interact with the PHP sidecar?

How does this interact with the PHP sidecar?

It should not.  In a future PR I think many of us hope to harmonize the two implementations, but there are a few questions about how packaging would work in that universe.  Right now I think the priority is to fix the outstanding defects, provide a sane assessment of risk for the runtimes which will rely on this implementation of crashtracking, and then harmonize over a more relaxed timeline.

Curiously, I see here that vfork availability isn't what I thought it was on macos.  Will check that out after I finish writing some documents and tests.

Codecov Report
Attention: Patch coverage is 0% with 242 lines in your changes missing coverage. Please review.

Project coverage is 71.72%. Comparing base (a4d6b05) to head (266ac64).

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #692      +/-   ##
==========================================
- Coverage   71.76%   71.72%   -0.05%
==========================================
  Files         271      270       -1
  Lines       41011    41034      +23
==========================================
- Hits        29433    29431       -2
- Misses      11578    11603      +25

Components
Coverage Δ

crashtracker
19.77% <0.00%> (-0.51%)
:arrow_down:

crashtracker-ffi
9.48% <0.00%> (+0.41%)
:arrow_up:

datadog-alloc
98.73% <ø> (ø)

data-pipeline
91.92% <ø> (ø)

data-pipeline-ffi
0.00% <ø> (ø)

ddcommon
82.74% <ø> (ø)

ddcommon-ffi
69.12% <ø> (ø)

ddtelemetry
59.10% <ø> (ø)

ddtelemetry-ffi
22.13% <ø> (ø)

dogstatsd
88.86% <ø> (ø)

dogstatsd-client
79.77% <ø> (ø)

ipc
82.65% <ø> (ø)

profiling
84.30% <ø> (ø)

profiling-ffi
77.46% <ø> (ø)

serverless
0.00% <ø> (ø)

sidecar
36.09% <ø> (ø)

sidecar-ffi
0.00% <ø> (ø)

spawn-worker
50.36% <ø> (ø)

tinybytes
94.77% <ø> (ø)

trace-mini-agent
72.45% <ø> (ø)

trace-normalization
98.25% <ø> (ø)

trace-obfuscation
95.77% <ø> (ø)

trace-protobuf
77.67% <ø> (ø)

trace-utils
93.08% <ø> (ø)

:wave: adding @bwoebi and @kevingosse as subject matter experts.  I'd really appreciate a review of the systems interactions in crash_handler.rs to make sure we're doing what we said we would on the tin.


@parent directive does not require arguments

[BLADE_V013] Required arguments missing for [@parent] on line 4

@parent directive is just a placeholder that does not have any arguments.  I feel the need for tests against official documentation, but the official documentation is more focused on use cases rather than specifications, so there's currently no clear guidance on how to construct tests.
See also:

https://github.com/laravel/framework/blob/2af985e2c26496f2870535b9079dbb207b1dde9a/src/Illuminate/View/Compilers/Concerns/CompilesLayouts.php#L61-L71
https://laravel.com/docs/10.x/blade#extending-a-layout

@extends('layouts.app')

@section('title', 'Page Title')

@section('sidebar')
    @parent

This is appended to the master sidebar.

@endsection

@section('content')

This is my body content.

@endsection

feel the need for tests against official documentation

Current test cases were based on the official test suite, but thank you for the contribution; they are always appreciated.


Feature flagging

Team needs to work out its approach to feature flagging. More detail and conversation to follow!

#656 is a good example of where we need to be able to view and test features before they get released to everyone. Need to kick this up the priority list for when @jamesgorrie returns. @gestchild @davidpmccormick is there anything we can sensibly get started on this week in the meantime?

Decided to initially use feature flagging to:

help us iterate more quickly with fewer code conflicts etc.
allow us to quickly kill features if they cause problems
make it possible for non tech team members to enable/disable features

In the future we will probably want to:

release features only to selected groups of users.
potentially use as a way of A/B testing (although we have other methods to accomplish this)?

Superseded by #841 and #845


ROX-3791: Fix grammar for ADD default policy

Description
Single character added to correct grammar for the description of the policy "ADD Command used instead of COPY"
Feel free to remove this section if it is overkill for your PR, and the title of your PR is sufficiently descriptive.
Checklist

[ ] Investigated and inspected CI test results
[ ] Unit test and regression tests added
[ ] Evaluated and added CHANGELOG entry if required
[ ] Determined and documented upgrade steps
[ ] Documented user facing changes (create PR based on openshift/openshift-docs and merge into rhacs-docs)

If any of these don't apply, please comment below.
Testing Performed
Not tested - changes only a string value for description
In addition to reviewing your code, reviewers must also review your testing
instructions and make sure they are sufficient.

This will need a migration for existing customers who upgrade to get the fix.

This will need a migration for existing customers who upgrade to get the fix.

@srcporter Does it matter if existing customers see the new wording?

This will need a migration for existing customers who upgrade to get the fix.

@srcporter Does it matter if existing customers see the new wording?

While I understand it might seem overkill for a single letter change, I would not advise diverging policies in a fresh install vs upgrade to same tag path. Also +1 to what @theencee - we must not change any migration. A migration is frozen once released.

@clickboo There's a ticket (https://issues.redhat.com/browse/ROX-16950) for adding some more exclusions in 4.1. While not ideal, I think I could probably just combine a migration for this onto that one

Reminder: Merge this PR once https://github.com/stackrox/stackrox/pull/6036 is merged.
If it'll miss RC0 cutoff for 4.1, be sure to add it to RC1

/retest


[BUG] on_page is called not being called for the first new_page() in _initialize_session

Summary
I am trying to create MyBrowserContext(BrowserContext) class so that I can override the _add_new_page_listener method and write my own on_page listener to run some code when context.new_page() is being called.
However, when running async def _initialize_session(self) in browser_use/browser/context.py the on_page in _add_new_page_listener is not triggered for the first new page, only for later pages.
This is problematic in when I need to run some logic on EVERY new page.
I used the default example with a new browser context as an example:
import asyncio

from langchain_openai import ChatOpenAI
from playwright.async_api import (
	BrowserContext as PlaywrightBrowserContext,
)
from playwright.async_api import Page

from browser_use import Agent, Browser, BrowserConfig
from browser_use.browser.context import BrowserContext

class MyBrowserContext(BrowserContext):
	def _add_new_page_listener(self, context: PlaywrightBrowserContext):
		async def on_page(page: Page):
			# My implementation for on_page to allow for custom logic
			print(page.url)

		context.on('page', on_page)

async def main():
	browser = Browser(config=BrowserConfig(headless=True))
	browser_context = MyBrowserContext(browser=browser)
	agent = Agent(
		task='Find a one-way flight from Bali to Oman on 12 January 2025 on Google Flights. Return me the cheapest option.',
		llm=ChatOpenAI(model='gpt-4o-mini'),
		browser=browser,
		browser_context=browser_context,
	)
	result = await agent.run()
	print(result)

asyncio.run(main())

I am unable to see my print().

Hi Tom, the first new_page() call in _initialize_session happens before the on_page listener is attached. So the "first page" event is never caught by the custom listener. You can fix this by registering the on_page listener before calling context.new_page():
async def _initialize_session(self):
playwright_browser = await self.browser.get_playwright_browser()
context = await self._create_context(playwright_browser)
# Register listener before the first new_page() call
await self._add_new_page_listener(context)

page = await context.new_page()
...

This way, the on_page callback is triggered for the very first page as well.
try this:
class MyBrowserContext(BrowserContext):
async def _initialize_session(self):
playwright_browser = await self.browser.get_playwright_browser()
context = await self._create_context(playwright_browser)
await self._add_new_page_listener(context)
page = await context.new_page()
initial_state = BrowserState(
element_tree=None,
selector_map={},
url=page.url,
title=await page.title(),
screenshot=None,
tabs=[],
)
self.session = BrowserSession(
context=context,
current_page=page,
cached_state=initial_state,
)
return self.session
async def _add_new_page_listener(self, context: PlaywrightBrowserContext):
    async def on_page(page: Page):
        print("[MyBrowserContext] New page opened:", page.url)
    context.on('page', on_page)

async def main():
browser = Browser(config=BrowserConfig(headless=True))
browser_context = MyBrowserContext(browser=browser)
agent = Agent(
task="Find a one-way flight from Bali to Oman on 12 January 2025 on Google Flights. Return me the cheapest option.",
llm=ChatOpenAI(model='gpt-4o-mini'),
browser=browser,
browser_context=browser_context,
)
result = await agent.run()
print("Result:", result)
if name == "main":
asyncio.run(main())

Thanks! Thats exactly the problem, I have created a PR a few days ago to fix it without requiring me to override the _initialize_session: https://github.com/browser-use/browser-use/pull/105/
Let me know what do you think about it


output.path configuration property has no effect

I'm attempting to start using the purescript loader using your example as a starting point. However, changing 'filename' appears to have no effect… the file is simply compiled to the output directory in a directory named after the module itself, as index.js
Is this intended? I can omit the filename property with no apparent change in behavior. While its compiling, its a little unsettling.
    path: path.join(__dirname, 'output'),
    filename: 'app.js'
}, ```

The way that the purescript file is compile is such that it creates a commonjs module, which is the behaviour you describe. A directory is created with the name of the purescript module, and inside is an index.js file containing the compiled JS.
When you specify the output in your webpack config, this should determine the path and filename of the resulting webpack bundle when you run the webpack command.
Also, as a heads up, I am on the verge of deprecating the purs-loader. Previously, I thought I had a use-case for this. However, I don't know if this type of loader makes sense anymore. The reason is that the loader will compile each purescript file independently. I think it makes sense to compile all the purescript files up-front, then require them via webpack. The purs-loader is not necessary to achieve this.
If you have a use-case for the purs-loader, I'd be happy to chat more about the best direction to take with this loader.

Thanks very much for the example.  The entry.js boilerplate was the key that I was missing.
The next issue I've encountered is that this doesn't seem to find any purescript libraries installed using bower, and there doesn't appear to be any to set a path variable to get psc-make to search for them.
I'm specifically trying to use Data.Maybe, installed from bower package purescript-maybe.
Thanks for the heads up that you are considering deprecating it.  Totally understand but I'll be sorry to see it go.  In my JavaScript work I moved from grunt to gulp to gulp+browserify to webpack.  I couldn't certainly go back to using grunt, as that seems to be what's best supported / encouraged in the PureScript community, but doing so feels like something of a step backwards.

Glad that the example helped.
Regarding the issue with purescript libraries installed with bower, I have a tentative solution in at branch topic/bower-components (please see the updated example). I don't know if this is ultimately the best approach, but it might work for your use-case. As an alternative, we could make the glob pattern a query parameter instead.
I am still on the fence about this library. I'd like to keep it if we can figure out the best use-case for it. It might actually be something to run with if we can iron these issues, which would be great!

Wow, awesome, thank you!  I will give it a try soon.
For what it's worth, after fiddling around I've ended up with a setup I'm reasonably happy with.  The main reason I wanted webpack was for --watch because gulp.watch wasn't working well (it would just exit if there were compilation errors).  I eventually found this issue: https://github.com/deepak1556/gulp-browserify/issues/29 and now have a gulp setup using gulp-plumber that makes gulp.watch work correctly, even if there are purescript compile errors.
It seems that psc is effectively building a single JS bundle so somewhat subsumes the role of webpack or browserify....I take it that's why you're on the fence about this project?
Anyway, thanks for all the help and effort here.  Happy to share my gulp setup if you are interested.

I've published version 0.0.3 of purs-loader to include your suggestion for the example and the fix for handling the purescript libraries. I am thinking that a good use-case might be the one you mention, where one only wants to use webpack, and not use it in conjunction with gulp or grunt. In any case, I will keep the loader, but I am open to moving it in another direction if the need arises.
Thank you for your feedback and help in improving this loader.


Statement after else with comment not indented

unittest
{
    if (0)
    {
    }
    else // comment
-        e = (*arguments)[0];
+    e = (*arguments)[0];
}

One of my other indentation changes must have fixed this. I'm no longer able to reproduce this issue.


Feature/add options limit

 The page freezes when loading the list of "Conjointly response ID" in segmentation


Redesign Badged Events section

Change this under the https://badging.chaoss.community/badged-events

to this:

Hi there
Please assign this to me

There you go @Sky-De. Please create a Draft Pull Request as soon as you make the first commit so that we can have progressive review

i finished it
but when i try to commit something happens which im not fammilar with
can you help me about this?

inform me about anything which i can do to fix it
i spent couple of hours on it
its result:

hello, @Sky-De  this looks awesome. I am not sure why the linting is failing. could you try running npm run format independently without first committing so that you see what errors are there?


fix(prettier) Fix debug printing if IfBreak` doc

Current dependencies on/for this PR:

main

PR #1560

PR #1561   👈

PR #1562

This stack of pull requests is managed by Graphite.

Merge activity

Nov 27, 9:29 PM: @Boshen started a stack merge that includes this pull request via Graphite.


Bootswatch themes

Hi Angelll
Great work and thanks for the new features !
I suggest to use bootswatch like the fork of EduardoOliveira
https://github.com/EduardoOliveira/simple-file-manager
what do you think ?
Cheers

@nibreh, Great! I think this can be added to backlog.
Currently I thinking about more elegant refactor for current php code.


Streamlit comp updates

This updates the streamlit-comparisson article to use shiny express.

Any idea why there doesn't seem to be a deployment preview available?

I think we need to build the dev version of shinylive, which Winston was going to work on. We definitely should have that for the whole transition branch so we can look for bugs.

@gshotwell I just realized the docs/helpers.py here has some overlap with what @gadenbuie is proposing in #66.
Maybe it would make sense to use the infrastructure in #66 here as well? I think this article will also need some updates to reflect recent changes in Express, like from shiny.express import layout -> from shiny.express import ui

@gshotwell just a heads up, I made some fixes and updates in e3bca01.

@cpsievert your changes look good, I pushed a couple of fixes to avoid duplicate "Since," sentences. I think the best thing to do is merge #66, then I'll refactor this to use that pattern.


feat(FOROME-1572): add showing preset kind to remove collisions

Task
As back end accepts dtrees and presets with same name for dataset and as it is different entities, it seems wrong to restrict this for user. To resolve bug I add checking kinds of preset on choosing and add showing type of preset if it has name collisions.

I think the name of types should be discussed with the customer. Dtree and preset are obvious for developers but could confuse the user.

I think we should come up with aliases, but they need to be discussed with Michael


Create a post specifically for introducing people to the directory.

Will do stuff like current overview of the whole directory, describe why the directory is here, how best of bots function, how to help with it, how the links in the directory work etc.

Noting this here b4 I forget: When making a list of bot accounts ran by the community mark which ones are set to be NSFW by default to let the users know.


Spotify stops playing after few songs

Hey guys! I've been having some problems with raspotify, we have 3 pi's connected in a hotel(I'm the manager of the IT deparmente) and been using raspotify for about 1 week already in the hotel but since we have this devices with raspotify after some few songs the pi just doesn't send any music signal at all and this happens with all 3 devices, it can play without a problem for at least 3 o 4 hours but we need them to work all day straight with no problem, can someone help me out please! I have my boss quite mad about it and need a solution or alternative.
Thanks!

This is usually the wrong repository to open the issue in, check out https://github.com/librespot-org/librespot/issues and check if someone else has the same issue as you. If you open an issue like this it's also helpful to provide logs as otherwise it's speculation.
This build currently hangs a bit behind librespot, they implemented quite a bit in the last days (@dtcooper :) )

Hey guys! I'm with the same issue. And I've tried to build the package myself with the latest commit of librespot and the build fails.
@dtcooper , could you please make a new build with the latest version of librespot, please?

removing pulseaudio with
sudo apt-get remove pulseaudio
seems to have done the job for me, as suggested in another issue, but I can not find it again, sorry for that.

While I didn't test the @kingma1999 solution, for me the issue was with playing the audio over HDMI cable
In headless mode by default, HDMI signal is turned off after 600 seconds, thus the audio sink gets lost as well.
I've posted my solution in #112

sudo apt-get remove pulseaudio
seems to have done the job for me

I don't have installed pulseaudio and currently have the same problem that spotify stop after a few songs.

ERROR:librespot_core::session: Os { code: 104, kind: ConnectionReset, message: "Connection reset by peer"


PIKA-277: Enable codecov for this repo

Context
We're turning on codecov for this repo
Approach

Set CODECOV_TOKEN secret in travis
Turn on xml coverage report
Run codecov-bash snippet

References
JIRA: https://zendesk.atlassian.net/browse/PIKA-277
@zendesk/pikachu
Risks
[None] CI-only change

For this fork even?

For this fork even?

It was listed in this spreadsheet: https://docs.google.com/spreadsheets/d/1l0s19ZSHP_ZgKGyZ-Dl0YUKK4Il8rceVaZSSkle3lk0/edit#gid=2140251269 :man_shrugging:

I left a comment on the spreadsheet, let's see what Lata says.


Add authentication to Hasura

Use the gateway to authenticate a user via CAM and create a session we can use to authenticate Hasura requests. Our default deployment should continue to be auth: none to make it easy for first time users. We found an old internal ticket tracking this issue.

Duplicate of https://github.com/NASA-AMMOS/aerie/pull/849


Implement tilde expansion for paths

Unix-style abbreviations for home directories ("~johndoe" for "/home/johndoe/") should be supported in the arguments to --gitrepo and --g4tree. Maybe the following would help?
http://hackage.haskell.org/packages/archive/HSH/1.2.6/doc/html/HSH-ShellEquivs.html

An interesting idea... I'll try to investigate it.

...or at least irt should fail with some explicative error message if the given directories "do not exist".


Add API to access watchers

Following @philippjfr's comment in https://github.com/holoviz/param/pull/766#issuecomment-1614500690, we have identified the need to provide an API to access watchers.
More precisely, it seems like we do not have an API to access watchers on an instance, which are currently available through the private attribute _param_watchers:
import param

class P(param.Parameterized):
    x = param.Parameter()

    @param.depends('x', watch=True)
    def d(self): pass

p = P()
print(p._param_watchers)
# {'x': {'value': [Watcher(inst=P(name='P00005', x=None), cls=<class '__main__.P'>, fn=<function _m_caller.<locals>.caller at 0x118fa5c10>, mode='args', onlychanged=True, parameter_names=('x',), what='value', queued=False, precedence=-1)]}}
print(p.param['x'].watchers)
# {}

There is a sort of public API to access the watchers set on class Parameters:
import param

class P(param.Parameterized):
    x = param.Parameter()

P.param.watch(lambda e: print(e), 'x')
print(P.param['x'].watchers)
# {'value': [Watcher(inst=None, cls=<class '__main__.P'>, fn=<function <lambda> at 0x103f3b1f0>, mode='args', onlychanged=True, parameter_names=('x',), what='value', queued=False, precedence=0)]}

There is the public .param.watchers that under the hood returns the watchers queue defined on _parameters_state, that holds transient data:
import param

class P(param.Parameterized):
    x = param.Parameter()

    @param.depends('x', watch=True)
    def d(self): pass

p = P()
p._param_watchers

print('start', p.param.watchers)
with param.parameterized.batch_call_watchers(p):
    print('   start cm', p.param.watchers)
    p.x = 1
    p.x = 2
    p.x = 3
    print('   end cm', p.param.watchers)
print('end', p.param.watchers)

Output:
start []
   start cm []
   end cm [Watcher(inst=P(name='P00005', x=3), cls=<class '__main__.P'>, fn=<function _m_caller.<locals>.caller at 0x118fa5c10>, mode='args', onlychanged=True, parameter_names=('x',), what='value', queued=False, precedence=-1)]
end []

Among those _param_watchers is likely the one the most required by users. It's accessed in Panel and Lumen, I've found one other usage on Github https://github.com/grepler/sqlmodel-panel-poc/blob/bf8b3ab1b3e31476f6fcbb451a7dc78fb555d29d/helpers.py#L215.

Do you have any opinion on this @philippjfr ? It seems it's unfortunate that .param.watchers is already used, as it seems more like an internal API made public.


UI: Need to check auto-layouts (and fix if necessary) on iPad and other devices with different screen

identified some issues - new tickets will be created


Helm chart does not output alert config for Telegram

Describe the bug
When using the Helm chart with only the Telegram provider for alerts, no alert map is output. This is due to an if-statement that does not check for the telegram map here
To Reproduce
Deploy using the Helm chart with this set of values:
kwatch:
  config:
    configTemplate:
      alert:
        telegram:
          token: "${token}"
          chatId: "${chatId}"

The generated ConfigMap will not contain the expected alert section.
Version/Commit
Kwatch v0.6.1

@drzero42 could you please check the latest version of chart?

@eremeevfd The telegram-values work now, thank you!
Unfortunately the newly added clusterName and the disableUpdateCheck values do not make it through the configmap templating in the chart. I'll open another ticket for that! :)


[common][samza-producer] Add a new option in stream job to leverage multiple producers

Summary
In a recent experiment, we noticed two issues:

KafkaProducer compression is quite time consuming for large records.
KafkaProducer is not scalable when using it in a multiple-thread env.

Streaming job typically runs in a container to process the upstreaming topic partition, and they need to process these events sequentially even these events belong to different Venice partitions, and the single-threaded KafkaProducer is limiting the total throughput and cpu resources are mostly under utilized.
To get round of this issue, in this PR, we add a capability to use multiple producers even in a single-threaded streaming application. And we don't want to disable compression as we would like to reduce pubsub usage and cross-colo replication bandwidth.
Two new options in VeniceWriter:

venice.writer.producer.thread.count : default 1
venice.writer.producer.queue.size: default 5MB

Stream job can configure it with a higher number of producer thread count to reduce the latency of Producer#send invocation, which is a blocking call, so that the total throughput will be improved.
The config: venice.writer.producer.queue.size is used to control the queue size between writer thread and the producer thread and if the queue is full, the writer thread will be blocked.

How was this PR tested?
CI

Does this PR introduce any user-facing changes?

[x] No. You can skip the rest of this section.
[ ] Yes. Make sure to explain your proposed changes and call out the behavior change.

LGTM! Thanks Gaojie!

Thanks for the review!


Extend threebot and VDC testsuite

need to extend testsuite with more scenarios:
threebot:

[ ] add 3bot admin and deploy container.
[ ] deploy an ubuntu and push the container logs onto an external redis channel.
[ ] deploy a kubernetes with enable public IP.
[ ] deploy a container then ssh to it.
[ ] deploy a s3 minio with SSD and HDD.
[ ] deploy a s3 minio with a global IPv6 address.
[ ] expose solution with TRC and NGINX.
[ ] expose solution with custom domain.
[ ] deploy virtual machine.
[ ] deploy a container with attach an extra volume to the container.
[ ] deploy a container with environment variables.

VDC:

[ ]  VDC api:

[ ] generate api keys
[ ] delete api keys
[ ] add admin
[ ] list all admins
[ ] remove admin
[ ] list alerts
[ ] add zdb
[ ] list zdbs
[ ] delete zdb
[ ] get wallet info
[ ] list VDCs
[ ] get VDC info
[ ] delete VDC

[ ] VDC backup:

[ ] create backup
[ ] restore backup
[ ] delete backup

@mhost39 @ramezsaeed what's the progress here? is it done?

vdc API: https://github.com/threefoldtech/js-sdk/issues/3146#issuecomment-913164176
threebot done for happy path and extend unhappy path not worked on it yet

there should be no issue handling two products (3bot, VDC) i'll close and let's do it properly


AllowAnonymousAttribute not working as expected with CORS request.

I'm Running ASP.NET Core 3 (Azure Web App) and have a CORS policy set up like so, in Startup.cs:
                services.AddCors(options =>
                {
                    options.AddPolicy("TestCors",
                        builder =>
                        builder.WithOrigins(allowedDomains.ToArray())
                        .AllowAnyHeader()
                        .AllowAnyMethod()
                        .AllowCredentials());
                });

I have an AJAX endpoint in a controller defined as such:
[EnableCors("TestCors")]
[AllowAnonymous]
public async Task<IActionResult> MyAjaxEndpoint(int parm1)
{
}

When I attempt to call this controller method using JQuery AJAX method like so:
                $.ajax(
                {
                    url: 'otherdomain.com/MyAjaxEndpoint',
                    cache: false,
                    type: "POST",
			crossDomain: true,
                    data: {parm1: 0},
			xhrFields:
                    {
                        withCredentials: true
                    },
                    async: false
                });

, I get a 302 redirect to the login page.  This does not happen if I happen to be authenticated through the standard Identity cookie.
I have some tokens (JWT) stored in a http-only cookie that I want sent with AJAX requests, and I was under the impression that requirement necessitated withCredentials: true in the AJAX options (is that correct?).  I'm not sure if that's what's causing the problem.
At any rate, I assumed that [AllowAnonymous] would have bypassed any authentication requirements by the ASP.NET pipeline.
Is there an issue with the AllowAnonymousAttribute or am I (ab)using it wrong?

Could you also share Configure method in startup.cs?

@SimonOrdo thanks for contacting us.
As @Kahbazi could you share your startup configuration with us?

Here, I believe, are the relevant bits:
services.Configure<CookiePolicyOptions>(options =>
            {
                // This lambda determines whether user consent for non-essential cookies is needed for a given request.
                options.CheckConsentNeeded = context => false;
                options.MinimumSameSitePolicy = Microsoft.AspNetCore.Http.SameSiteMode.None;
            });

  services.AddAuthorization();
  services.AddSession(o => // session resolves to use IDistributedCache
            {
                o.IdleTimeout = TimeSpan.FromMinutes(60);
            });

services.AddIdentity<ApplicationUser, IdentityRole>()
                .AddEntityFrameworkStores<AppContext>()
                .AddUserManager<UserManagerEx<ApplicationUser>>()
                .AddDefaultTokenProviders();

   // Add Custom Claims processor
            services.AddScoped<IUserClaimsPrincipalFactory<ApplicationUser>, CustomClaimsPrincipalFactory>();

            services.Configure<IdentityOptions>(options =>
            {
                // Password settings
                options.Password.RequireDigit = false;
                options.Password.RequiredLength = 5;
                options.Password.RequireNonAlphanumeric = false;
                options.Password.RequireUppercase = false;
                options.Password.RequireLowercase = false;

                // Lockout settings
                options.Lockout.DefaultLockoutTimeSpan = TimeSpan.FromMinutes(30);
                options.Lockout.MaxFailedAccessAttempts = 20;
                options.Lockout.AllowedForNewUsers = true;

                // User settings
                options.User.RequireUniqueEmail = false;
            });

            services.ConfigureApplicationCookie(options =>
            {
                options.ExpireTimeSpan = TimeSpan.FromHours(4);
                // Cookie settings
                options.Cookie.SecurePolicy = Microsoft.AspNetCore.Http.CookieSecurePolicy.None;
                options.Cookie.HttpOnly = true;
                // If the LoginPath isn't set, ASP.NET Core defaults
                // the path to /Account/Login.
                options.LoginPath = "/Account/Login";
                // If the AccessDeniedPath isn't set, ASP.NET Core defaults
                // the path to /Account/AccessDenied.
                options.AccessDeniedPath = "/Home/Index";
                options.SlidingExpiration = true;
                options.Events.OnRedirectToAccessDenied = context =>
                {
//---> Code Never reached, regarding this CORS issue
                    if (context.Request.IsAjaxRequest())
                    {
                        context.Response.StatusCode = StatusCodes.Status403Forbidden;
                        return Task.CompletedTask;
                    }
                    context.Response.Redirect(context.RedirectUri);
                    return Task.CompletedTask;
                };

                options.Events.OnRedirectToLogin = context =>
                {
//---> Code Never reached, regarding this CORS issue
                    if (context.Request.IsAjaxRequest())
                    {
                        context.Response.StatusCode = StatusCodes.Status401Unauthorized;
                        return Task.CompletedTask;
                    }
                    context.Response.Redirect(context.RedirectUri);
                    return Task.CompletedTask;
                };
            });

services.AddCors(options =>
                {
                    options.AddPolicy("TestCors",
                        builder =>
                        builder.WithOrigins(portalDomains.ToArray())
                        .AllowAnyHeader()
                        .AllowAnyMethod()
                        .AllowCredentials());
                });

 services.AddControllersWithViews()
                .AddNewtonsoftJson(options =>
            {
                options.SerializerSettings.ContractResolver = new CamelCasePropertyNamesContractResolver();
                options.SerializerSettings.ReferenceLoopHandling = ReferenceLoopHandling.Ignore;
            })
                .AddRazorRuntimeCompilation();

            services.AddRazorPages()
                .AddRazorRuntimeCompilation();

And the configure method looks like:
public void Configure(IApplicationBuilder app, IWebHostEnvironment env, ILoggerFactory loggerFactory)
        {
            app.UseHttpsRedirection();
            var rwoptions = new RewriteOptions();
            rwoptions.Rules.Add(new RedirectToWwwRule());
            app.UseRewriter(rwoptions);

            if (env.IsDevelopment())
            {
                app.UseDeveloperExceptionPage();
                app.UseDatabaseErrorPage();
            }
            else
            {
                app.UseExceptionHandler("/Home/Error?statusCode=777");
                // The default HSTS value is 30 days. You may want to change this for production scenarios, see https://aka.ms/aspnetcore-hsts.
                app.UseHsts();
            }
            app.UseCors("TestCors");
            app.UseFileServer();

            app.UseSession();
            app.UseStatusCodePagesWithReExecute("/Home/Error", "?statusCode={0}");

            // Kludge: https://github.com/aspnet/AspNetCore/issues/13715
            app.Use((context, next) => {
                context.SetEndpoint(null);
                return next();
            });

            app.UseRouting();
            app.UseAuthentication();
            app.UseAuthorization();

            app.UseEndpoints(endpoints =>
            {
                endpoints.MapControllerRoute(
                    name: "default",
                    pattern: "{controller=Home}/{action=Index}/{id?}");

                endpoints.MapControllerRoute(
                  name: "areaRoute",
                  pattern: "{area:exists}/{controller=Home}/{action=Index}");

                endpoints.MapRazorPages();
            });
  }

@SimonOrdo thanks for the details.
@HaoK I believe that the issue here is that the Identity cookie is set to SameSite=Strict and that would prevent it from being sent to the other domain. Can you take a look at it?

Given that the same site changes are in 3.1 no, it's not related to that work.

I believe that the issue here is that the Identity cookie is set to SameSite=Strict and that would prevent it from being sent to the other domain. Can you take a look at it?

I believe SameSite is set to None here, not Strict, unless I'm not seeing something you are:
options.MinimumSameSitePolicy = Microsoft.AspNetCore.Http.SameSiteMode.None;

Fiddler traces, plus the browser versions would be useful here.
Also if you are sending a JWT token in a cookie, and there's no identity cookie, because it's cross domain, that's simply not going to work.

@blowdart  I will gather the requested diagnostic data.
To clarify, the JWT token isn't being used to authenticate against Identity.  It's passed for an unrelated reason.   Sorry if that was needlessly confusing things, but ultimately the root issue (I believe) is that the CORS AJAX request can't reach the controller due to the request not being authenticated even though I've set the AllowAnonymous attribute on the method.
Correct me if I'm wrong, please, but I thought that there being a JWT token (incidentally) stashed in a cookie should be irrelevant at that point, no?
Diagnostic data to follow shortly.

Ah in that case, yea JWT in a cookie isn't affecting anything.

I attempted to build a small project to repro the issue and was unable to do so, although I'm not seeing some other inconsistencies related to UseCors() now.  I'll close this issue for the time being and will re-open once I can describe the symptoms in an independently reproduceable manner.

@blowdart , I don't know why or how, but if I remove the following work-around ( https://github.com/aspnet/AspNetCore/issues/13715#issuecomment-528929683 ) suggested by @Tratcher , everything works as expected.  I won't re-open the issue at this time, frankly because I can't describe the problem beyond the symptoms.
I just wanted to document the resolution I stumbled across.
Remove the following:
 ```
   // Kludge: https://github.com/aspnet/AspNetCore/issues/13715#issuecomment-528929683
        app.Use((context, next) => {
            context.SetEndpoint(null);
            return next();
        });

... and all is well (except, obviously, the problem that that the workaround is fixing).

Just guessing, but perhaps nulling out the endpoint has the effect of getting rid of the endpoint metadata (aka the allowanonymous)


copy tweaks

A few copy changes following initial peer review

I've moved the sentence out from the hint text, back to the bottom. We don't think it's necessary for this to be read before answering the question.

Have also set a threshold on the word count, so that you don't see it until hitting 85% of the limit.


Fix hero attributes class on README

Hi
Thanks for this library, I found a class in the readme that does not exist.
Should it be PhotoViewHeroAttributes?

BTW is there any chance that you add a label hacktoberfest-accepted to this PR so it counts for this https://hacktoberfest.digitalocean.com ?

Sorry for that delay, I was out last month.


Bump cosmos-sdk to v0.45.6

Upgrade to v0.45.6

Requires #815 before

We should unblock it: https://github.com/CosmWasm/wasmd/pull/866

This can be skipped in favour of v0.45.7


Can not find container by name

Frakti reports Can not find container by name sometimes, while the container does exist in hyperd, and the container name in log is actually the containerID.
Related frakti logs:
Aug 09 08:08:22 ubuntu-1 frakti[29731]: E0809 08:08:22.895300   29731 container.go:187] Get container info for 6d74d9c1ea5c585aefefbc76f6863173fa920ea923aa5845effa2751018ae129 failed: rpc error: code = 2 desc = Can not find container by name(6d74d9c1ea5c585aefefbc76f6863173fa920ea923aa5845effa2751018ae129)
Aug 09 08:08:22 ubuntu-1 frakti[29731]: E0809 08:08:22.895486   29731 manager.go:330] ListContainers from hyper runtime service failed: rpc error: code = 2 desc = Can not find container by name(6d74d9c1ea5c585aefefbc76f6863173fa920ea923aa5845effa2751018ae129)
Aug 09 08:08:23 ubuntu-1 frakti[29731]: E0809 08:08:23.903836   29731 container.go:187] Get container info for 6d74d9c1ea5c585aefefbc76f6863173fa920ea923aa5845effa2751018ae129 failed: rpc error: code = 2 desc = Can not find container by name(6d74d9c1ea5c585aefefbc76f6863173fa920ea923aa5845effa2751018ae129)
Aug 09 08:08:23 ubuntu-1 frakti[29731]: E0809 08:08:23.903862   29731 manager.go:330] ListContainers from hyper runtime service failed: rpc error: code = 2 desc = Can not find container by name(6d74d9c1ea5c585aefefbc76f6863173fa920ea923aa5845effa2751018ae129)

cc/ @laijs @gnawux

Fixed via https://github.com/hyperhq/hyperd/pull/656.


tbi(ui5-info): includeMaintained and includeDefault combination finds the next maintained version

Ticket: #2165

@Klaus-Keller We would rather to the update you suggest in a separate PR.   From discussions with the AppGen team, this might not be straightforward to not use versionoverview.json.
You ok if we keep this for the original issue and have a follow up to replace 'versionoverview.json'?

@Klaus-Keller We would rather to the update you suggest in a separate PR. From discussions with the AppGen team, this might not be straightforward to not use versionoverview.json.
You ok if we keep this for the original issue and have a follow up to replace 'versionoverview.json'?

Can we check whether it is straight forward or not? I did a brief check and could not find any other property than support to be used from versionoverview.json.

@Klaus-Keller We would rather to the update you suggest in a separate PR. From discussions with the AppGen team, this might not be straightforward to not use versionoverview.json.
You ok if we keep this for the original issue and have a follow up to replace 'versionoverview.json'?

Can we check whether it is straight forward or not? I did a brief check and could not find any other property than support to be used from versionoverview.json.

I spent some time with this on Friday, and this is no trivial task by any means. It would involve completely changing how parser works and potential caching changes too.
I believe that there is very high chance of introducing a regression, and this suggestions should be explored further for potential issues that could stem from it.

@IainSAP @mikicvi-SAP, fine to remove versionoverview.json separate, I've created https://github.com/SAP/open-ux-tools/issues/2186 for this. Would be great if it could be accomplished right after this PR has been merged.


GDS ERROR: DeprecatedConfig in setup.cfg (HDL project)

The gds action gives me the following error while building:
× Getting requirements to build wheel did not run successfully.
│ exit code: 1
╰─> [62 lines of output]
/tmp/pip-build-env-nu699e_u/overlay/lib/python3.10/site-packages/setuptools/config/setupcfg.py:293: _DeprecatedConfig: Deprecated config in setup.cfg
!!
          ********************************************************************************
          The license_file parameter is deprecated, use license_files instead.

          By 2023-Oct-30, you need to update your project and remove deprecated calls
          or your builds will no longer be supported.

          See https://setuptools.pypa.io/en/latest/userguide/declarative_config.html for details.
          ********************************************************************************

  !!
    parsed = self.parsers.get(option_name, lambda x: x)(value)
  running egg_info
  writing lib3/PyYAML.egg-info/PKG-INFO
  writing dependency_links to lib3/PyYAML.egg-info/dependency_links.txt
  writing top-level names to lib3/PyYAML.egg-info/top_level.txt
  Traceback (most recent call last):
    File "/home/runner/openlane/venv/lib/python3.10/site-packages/pip/_vendor/pyproject_hooks/_in_process/_in_process.py", line 353, in <module>
      main()

Tested and reproduced, thanks for reporting!
This might be related to yaml/pyyaml#601, but needs further investigation

It does seem related to this, I have an ugly workaround (that doesn't require changing the OL docker image).
Maybe you can make a tidy version :)
https://github.com/TinyTapeout/tt-gds-action/compare/main...dlmiles:tt-gds-action:tt04-dlm

Should be fixed by TinyTapeout/tt-gds-action@038cad4121d5ee39f3323ddae153641cad107079.
Can you please try again and report?

Everything run smoothly, thanks for the quick fix! Appreciate all your help.

Since it is resolved, I'm closing it


add some test for interview

Pull Request Test Coverage Report for Build 307

0 of 0 (NaN%) changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 72.711%

Totals

Change from base Build 301:
0.0%

Covered Lines:
2502

Relevant Lines:
3441

💛  - Coveralls


console error - png bug

Hi there,
are there any restrictions to PNG format?
i get error message in console:
=== CHROME
(index):1 Uncaught TypeError: Cannot read properties of undefined (reading 'previousSibling')
at HTMLImageElement.onload ((index):1)
=== FIREFOX
Uncaught TypeError: this.add is undefined
when i use JPG file everything works fine ...

thank you.
although I now believe that it has nothing to do with the file type.
the error described occurs when i use the "gallery feature".

This error seems to be caused by line 97:
onload += /\.png/.test(src) ? this.add.previousSibling.remove() : '';
I just commented it out and the error is gone.
No idea what this line was doing tho

This has been resolved in v1.7.10