GM fix 'Controls Failed' on resuming after cycling main cruise switch

Feature
GM fix 'Controls Failed' on resuming after cycling main cruise switch
Description
The GM ECM independently tracks two cruise states, 'main on' and 'speed is set'.
Both must be true when resuming or the ECM generates a cruise fault. If
the ECM is driven to the main off state by the main cruise switch,
the set speed state is reset to false.
The OEM GM flow is if main cruise is cycled, the ASCM resets its speed
to 0, and the ECM goes into the no set speed state. 'Resume' presses will be
ignored (as the ASCM has a resume speed of 0). The 'Set' Button must be
pressed while meeting the minimum speed requirements to drive the ECM
and ASCM into the correct states to allow for ACC to operate.
Currently in OP controlsd remembers previously set speeds when cycling
the main cruise switch. This causes controlsd and the GM ECM's
respective state machines to get out of sync.
For example if we have a set speed of 55 mph, we press main cruise button once,
controlsd goes into a disabled state, the GM ECM goes into the 'main
off' and 'no speed set' state. We press the main cruise button a second time,
controlsd goes into the enabled state with the remembered speed of 55
mph, while the GM ECM goes into a 'main on' and 'no speed set' state. The UI
presents the user with the controlsd remembered 55 mph, so it is logical to
press 'Resume' if that is desired, however due to the GM ECM still being
in the 'no speed set' state, the ECM generates a cruise fault. Currently this
results in a frightening 'Controls failed' message on the Eon.
This pull request adds a new controlsd event RESET_V_CRUISE
which allows the gm interface to keep controlsd in sync with the GM ECM.
On 'main on' presses, the gm interface triggers a reset of v_cruise_kph
back to 0. On pressing 'Resume' the GM interface now also checks to make
sure that v_cruise_kph has been set before sending a ENABLE event on Resume
presses.
Testing
Tested on 2018 Cadillac ATS, Cycled main switch and attempted resumes. No 'Controls Failed' messages were able to be generated. Due to a one off giraffe being used, along with other custom code, this should also be tested by Volt users.

I tested this change on my Volt and it works as expected. When the main cruise on/off switch is toggled, the previously set cruise speed is "forgotten" on both the car side and EON, so pressing RES (+) on the wheel is a noop (as opposed to previously an error). Furthermore, pressing RES (+) on first ignition is now also a noop. This now mimics the behaviour of the stock GM ACC system.

nice. Can this be done without adding a new event type? That's a pretty invasive change.

@rbiasini I've attempted to solve the problem within the GM specific code, however I think the best we can do there is what Vasily has already done here: https://github.com/commaai/openpilot/pull/466
Sadly the questions in #gm have gone from "why doesn't op accelerate?" to "My op is totally broken I'm getting 'Controls Failed' all the time."
I understand that this is a change in the shared logic for the entirety of openpilot. My hope was GM isn't the only car that has the CC UI of cycling main off/on causes a previously set speed to be forgotten. I believe this is how most cars function as a hold over from days when cars didn't have LCD screens to communicate detailed state to the user. Possibly this could be an issue for other brands as their communities try to get full lat+long support?
Any thoughts on an alternative that might have a better chance of being upstreamed, or any improvements to this strategy that would make it more palatable to upstream?

@rbiasini I think I might want to try a little more around this. I still think we need to be able to reset the v_cruise_kph in controlsd whenever main switch is toggled, but I've discovered this isn't the only case that results in a Controls Failed message.
Another case is if you set OP while the gas is depressed. The ECM also sets an ACC state of 3 in this case too, which we've labeled as ACC Fault. I don't think its actually a fault state. I think its actually more of a signal to the ASCM that the ECM is overriding its request for acceleration. Ie in the OEM system if you have ACC enabled, and you depress the accelerator, you don't get a disengage or an an error, you get a message that says that ACC braking is unavailable during manual acceleration. The ACC state on the ECM is set to 3, but as soon as the accelerator pedal is released, the message goes away ACC takes over again and the ECM ACC state goes back to 1 (enabled).
I think OP should also mimic the ASCM in this case as well. If we simply ignore the ACC state of 3, the system doesn't recover automatically like the OEM system. I need to do some more digging into the OEM can logs to figure out how the ASCM and ECM work together to handle recovery of ACC control when the driver presses and releases the gas.

@rbiasini I don't know if it is a no go to add a new event type, but I cleaned things up a bit and fixed a bug on first startup.
I realized that v_cruise_kph's initial state is 255 not 0. So I updated the reset event to set it back to its initial value of 255.
I thought more about if there are any other options that don't involve creating a new event type. We could have a state machine in the GM code that tracks this and overrides what we display on the dash/hud, but then the OP UI could end up displaying one speed while the dash would display no set speed, so it would be a bit confusing.

Would anyone like to re-open this? It seems like it may be causing a large portion of ACC faults with GMs still.


New Compile time warnings with PubSubClient 2.7.0 in Arduino IDE 1.8.7

Just returned to my project after 6 months, and updated PubSubClient to 2.7.0 and now get 5 warnings in PubSubClient package at compile time.  Went back to 2.4.0 and these warnings disappear.
C:\Users\ianh4\Documents\Arduino\Sketchbooks\libraries\PubSubClient\src/PubSubClient.h:88:7: warning: type 'struct PubSubClient' violates one definition rule [-Wodr]

 class PubSubClient : public Print {
       ^

C:\Users\ianh4\Documents\Arduino\Sketchbooks\libraries\PubSubClient\src\PubSubClient.h:88:7: note: a different type is defined in another translation unit

 class PubSubClient : public Print {
       ^

C:\Users\ianh4\Documents\Arduino\Sketchbooks\libraries\PubSubClient\src/PubSubClient.h:91:39: note: the first difference of corresponding definitions is field 'buffer'

    uint8_t buffer[MQTT_MAX_PACKET_SIZE];
                                       ^

C:\Users\ianh4\Documents\Arduino\Sketchbooks\libraries\PubSubClient\src\PubSubClient.h:91:39: note: a field of same name but different type is defined in another translation unit

    uint8_t buffer[MQTT_MAX_PACKET_SIZE];
                                       ^

lto1.exe: note: array types have different bounds

In regard to MQTT_MAX_PACKET_SIZE, I do define that as 256 (this produces a warning in 2.4.0 (fixed in 2..7.0) but that I can fix) otherwise it is all a standard code as below (just a snippet)
#include <SPI.h>
#include <Ethernet2.h>
#define SS     10U    //D10 ---- SS
#define RST    11U    //D11 -----Reset

//MQTT Client Libraries
#define MQTT_MAX_PACKET_SIZE 256
#include <PubSubClient.h>

Target Environment is Leonardo with W5500 Ethernet.
I haven't got to loading and running again to see if this runs OK, I have a few things to build and more Code to write.
Any idea why I get these warnings?

Commented out the #define and warnings went away.  Found I could
#define MQTT_MAX_PACKET_SIZE 128
but set it to any value smaller or larger and you get the warnings?
Maybe an issue to fix next time as the .h file has a #ifndef MQTT_MAX_PACKET_SIZE  switch on it which I thought would stop it overwriting the buffer size set in the sketch.
Thanks for your help


[BEAM-6766] Metadata file implementation for Sort Merge Bucket source/sink

This PR is a small, discrete chunk of the larger SMB branch/PR, extracted into a smaller PR for easier reviewing as suggested in the JIRA ticket. It contains a JSON-serializable BucketMetadata abstract class and specific implementations for JSON, Avro, and TensorFlow (org.tensorflow.example.Example) collections. The intention here is that during an SMB write, a metadata.json file will be written alongside the bucketed record files, and read again at join time to ensure compatibility, reconstruct key coders, etc.
CC @kennknowles @nevillelyh @reuvenlax @kanterov

Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

[x] Choose reviewer(s) and mention them in a comment (R: @username).
[x] Format the pull request title like [BEAM-XXX] Fixes bug in ApproximateQuantiles, where you replace BEAM-XXX with the appropriate JIRA issue, if applicable. This will automatically link the pull request to the issue.
[x] If this contribution is large, please file an Apache Individual Contributor License Agreement.

What do you think about having a design doc for the metadata format and discussing it on dev@? Not saying that there is anything wrong, but it would be a good way to collect feedback before being invested in the approach, you can find inspiration and template on desing-documents.

Something you might find useful is the design proposal for cost-estimation.

@kanterov are you planning to review this change?

@aaltay no, I want to get feedback from dev@ before we proceed

That makes sense. I pinged the thread today, hopefully there will be some feedback.

Please say "PTAL" and/or reach out to reviewers of this change (@kanterov) once this PR is ready for review. Thank you.

@tvalentyn , @kanterov , PTAL?

Ping. Just back from vacation and noticed the email thread. @kanterov or @tvalentyn if you don't have time now can you comment so we know? or recommend someone?

I am not sufficiently familiar with these bits of code, so I'd prefer to find another reviewer to merge this faster. My earlier comment was to make sure that this PR receives attention once ready.

@kennknowles we are having discussions (internally) on a few changes to the structure of metadata


Correct some issues with TS typings

exec seems to return an object, not true
getMatchingChildren no longer exists
Link in the root doesn't have activeClassName handling, and should have a generic parameter on HTMLAttributes (see also #445)

Looks like that test needs a slight adjustment, if you wouldn't mind. Or I can take care of it in a day or two myself.
Thanks for working on this stuff


[Bug] [dolphinscheduler-api] The pages of project management, workflow instance and task instance are accessed slowly

Search before asking

[X] I had searched in the issues and found no similar issues.

What happened
The pages of project management, workflow instance and task instance are accessed slowly

What you expected to happen
When the amount of data is large, the SQL query statement is slow
How to reproduce
Optimize SQL query statements
Anything else
No response
Version
2.0.0
Are you willing to submit PR?

[ ] Yes I am willing to submit a PR!

Code of Conduct

[X] I agree to follow this project's Code of Conduct

Hi @janeHe13, we plan to inspect and fix this issue in 2.0.2, if you want to join our community, maybe you could try to fix it by yourself.

I want to fix it.

I found that the SQL behind this interface is very slow. The main table is large, but there is no index to use. By add the index, the all mode in the query plan can be changed into a more efficient ref mode. If this optimization still fails to meet the requirements, please contact me and I will continue to optimize。


python-version: bump to 3.8.9

This bumps the minor version to the latest in the 3.8 series.
Justification: pyenv struggles to build 3.8.2 on recent macOS versions, thanks to Apple's shenanigans.

https://github.com/pypa/warehouse/pull/10828 allows to bump only two files.


Use gitattributes to control git's autocrlf handling on ceremony outputs

Description
I just spent an hour debugging this on sigstore-python, so I figured I'd share here as well in case it ever bites someone trying to consume this repository on Windows 🙂
A lot of Windows users have core.autocrlf = true set in their git configurations (and GitHub Actions does it automatically for checkouts as well). This is normally the right behavior (since it fixes line endings to match what Windows expects), but it will break any TUF metadata stored as JSON, since the file sizes on disk will no longer match their specified sizes in the root metadata.
To fix it, this repo can add a .gitattributes file like this:
ceremony/** binary

...which will tell git to treat everything under ceremony/ as if its a binary file, meaning that autocrlf won't apply to it.
For context, here's the bug as it manifested in sigstore-python: https://github.com/sigstore/sigstore-python/pull/433

Oh wow, thank you so much for filing this report! I will definitely add this fix.
Ahhhhh so this is likely going to affect anyone who is pulling in these files into github repositories.
I vaguely remember hitting this at some point in this repository too. Or in cosign. And having to manually update the newline and then it never happened again for some reason.
Thank you!! I didn't know about this config.

No problem, happy to help! I too didn't know about it, until I spent an hour debugging it on high-latency Windows CI runners 🙃


feat: System Searchd

Optionally, deploys a Searchd statefulset
Makes the current Sphinx statefulset optional
Allows defining a Search Server in the System config, in order to point to one or the other

/kind feature
/priority important-soon
/assign

/lgtm

/lgtm

/approve


[Enhancement] Add compilation/running of multiple files

Future feature to be implemented: running code with multiple files.
This seems fairly straight forward with compiled languages. For example, for c/cpp we can send the code as an array of strings, have the file for each code string created, and the g++ command should take care of the rest in creating the executable. Some minor accomodations may need to be made to differentiate b/w header and non-header files, but that is not a big deal.
For interpreted languages, like python, I am not sure its as straight forward with the current mechanism. This is because if a python file imports from a file called "x", the imported filename will be modified to a UUID with the current set-up and thus the import statement will be broken. However, I might be misunderstanding and welcome criticism/solutions.

@YasserDbeis I think you guys would need some sort of "module resolver" mechanism to create a dependency graph of the files before sending it to the server.
Later the server can flatten that data structure to resolve and load any missing modules.
But because there is no concept of a filesystem right now (I guess?) its more like a single evaluation call.
In a ideal architecture, the client could establish a WS connection with the server which can then be multiplexed to send different types of data like when the first time a enviornment loads, the client can send a Tree of files to the server which it can use to resolve file content.
This will also allow the server to pipe the STD inputs and outputs with using the WS with the client which can then be used to show a terminal view using something like https://xtermjs.org/
Haha these are just my suggestions from some experience with building such tooling, feel free to use if anything is useful to u. 😄


How can we engage?

Question
We decided to use ngx-formly in our project revaedge.com  and instead of forking it thought we can engage and contribute to the main repo. My only concern is the release or PR speed and how fast we can have the codes back into the released version.
what we are going to work on for now is full nebular components support. we can also discuss any other common point of interest that we can contribute to.

We decided to use ngx-formly in our project revaedge.com

:+1:

forking it thought we can engage and contribute to the main repo

PR welcomed!

how fast we can have the codes back into the released version.

That depends on our availability but not more than ~2 weeks and for bug fixes ~1 week.

what we are going to work on for now is full nebular components support

That's on our roadmap so that would be a good addition from your side :), for now, we may accept only the basic types (ng-zorro-antd example) to keep our codebase maintainable.


feat: Updated popular_tables endpoint to allow optional user_id

Signed-off-by: Josh Howard<EMAIL_ADDRESS>
Summary of Changes
The popular_tables endpoint has been updated to allow for an optional user_id. The idea is that the popular tables response should be able to be user specific.
Tests
Minor updates to fix assert_called_with calls.
CheckList
Make sure you have checked all steps below to ensure a timely review.

[-] PR title addresses the issue accurately and concisely. Example: "Updates the version of Flask to v1.0.2"

In case you are adding a dependency, check if the license complies with the ASF 3rd Party License Policy.

[-] PR includes a summary of changes.
[-] PR adds unit tests, updates existing unit tests, OR documents why no test additions or modifications are needed.
[-] In case of new functionality, my PR adds documentation that describes how to use it.

All the public functions and the classes in the PR contain docstrings that explain what it does

[-] PR passes make test

Codecov Report

Merging #232 (46263e1) into master (2752492) will increase coverage by 2.59%.
The diff coverage is 70.65%.

@@            Coverage Diff             @@
##           master     #232      +/-   ##
==========================================
+ Coverage   74.10%   76.69%   +2.59%
==========================================
  Files          25       27       +2
  Lines        1255     1326      +71
  Branches      136      159      +23
==========================================
+ Hits          930     1017      +87
+ Misses        297      265      -32
- Partials       28       44      +16

Impacted Files
Coverage Δ

metadata_service/api/popular_tables.py
100.00% <ø> (ø)

metadata_service/api/user.py
100.00% <ø> (ø)

metadata_service/proxy/shared.py
28.57% <28.57%> (ø)

metadata_service/proxy/neo4j_proxy.py
71.46% <56.45%> (-3.54%)
:arrow_down:

metadata_service/api/badge.py
61.29% <61.29%> (ø)

metadata_service/proxy/base_proxy.py
67.08% <75.00%> (-0.06%)
:arrow_down:

metadata_service/proxy/atlas_proxy.py
80.34% <79.19%> (-3.97%)
:arrow_down:

metadata_service/__init__.py
76.47% <100.00%> (ø)

metadata_service/api/dashboard.py
81.81% <100.00%> (+8.48%)
:arrow_up:

metadata_service/api/table.py
100.00% <100.00%> (ø)

... and 10 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3a96f7f...46263e1. Read the comment docs.

Hi @joshthoward, thanks for this. Appreciate your contribution to Amundsen and apologies for the delay in responding.
I think this is a step in the right direction. Often what's popular in the whole company doesn't matter to an analyst in one team. What's popular in their team, or what's popular personalized to them is more relevant.
Perhaps, I missed it but this code seems to add the end point to allow the user_id but I don't have a good sense of how that user_id will be used. Can you help me understand how you are thinking about that, or if you already have a working example of that?

I love this, this is super helpful @joshthoward. I could see personalization happen on a per-team basis as well e.g. show the most queried tables used by this team as a whole. But I don't see why that needs to block this.
So, I am supportive of this. In terms of how customizations should be made, I don't have an opinion on, right now. I noticed that @feng-tao already requested some maintainers to look, I will ping them again and will take a look myself too.
This is a +1 from my side, let me know if anyone else has any feedback on this. cc'ing some people who may: @feng-tao @Golodhros @verdan

@markgrover
Well thanks!
Based on your comment "I could see personalization happen on a per-team basis as well e.g. show the most queried tables used by this team as a whole.", I am going to close the PR on the frontend until we best figure out how to display both.

Sounds good. I see popularity calculation evolving and that's ok. Thinking
more, I like the per person approach better since there may be other people
not in your team, plus team data is pretty messy in many organizations and
there's no standard.
So, all in all, I am all in favor of being scrappy and moving forward here.
On Tue, Nov 24, 2020 at 4:27 PM Josh Howard<EMAIL_ADDRESS>wrote:

@markgrover https://github.com/markgrover
Well thanks!
Based on your comment "I could see personalization happen on a per-team
basis as well e.g. show the most queried tables used by this team as a
whole.", I am going to close the PR
https://github.com/amundsen-io/amundsenfrontendlibrary/pull/765 on the
frontend until we best figure out how to display both.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/amundsen-io/amundsenmetadatalibrary/pull/232#issuecomment-733358440,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AANBLC5SW6EW72G2WMIC26TSRRFONANCNFSM4TUAJCIQ
.

let me take a look tonight.

@joshthoward , lgtm in high level. A fe comments:

given we take the user_id as input, i think we should just change the popular table query (neo4j) to take the user id into account if it is provided and remain the same if it is None.
For FE, I think we should set it through a config to allow user to change it whether to display global popular table vs personal popular table. The reason is that for new hires, they may not have frequent used tables which they could use the global popular table for reference.

wdyt?

@feng-tao It would be my recommendation to move forward with this PR as is.

I agree, but I want to do further experimentation on building a real recommender system. I don't have users to experiment with, but if someone could run the following query on a production Neo instance, that would give me what I need for that:
MATCH (n:User)-[FOLLOW]->(t:Table) RETURN apoc.util.sha256([n.key]),apoc.util.sha256([t.key])
I'm thinking that the config should go on the frontend because a user might want global views, personalized views, or both which could result in a frontend change.

@feng-tao It would be my recommendation to move forward with this PR as is.

I agree, but I want to do further experimentation on building a real recommender system. I don't have users to experiment with, but if someone could run the following query on a production Neo instance, that would give me what I need for that:
MATCH (n:User)-[FOLLOW]->(t:Table) RETURN apoc.util.sha256([n.key]),apoc.util.sha256([t.key])
I'm thinking that the config should go on the frontend because a user might want global views, personalized views, or both which could result in a frontend change.

yeah, when i said the config, I mean FE config (the PR you closed).


Feat: Allowing users to read blogs in different languauges

Describe the feature
This feature helps the website to target the user all over the world which will help to increase in the website traffic.
Add ScreenShots
adding more languages
Record

[X] I agree to follow this project's Code of Conduct
[X] I'm a GSSOC'24 contributor
[X] I want to work on this issue

@Suchitra-Sahoo assign this issue to me as soon as possible

@Suchitra-Sahoo
I want to add more agro blogs such as
1)7 tips to get the best Wheat produce
2)All you need to know about grape farming in India
3)Food Transparency: Meeting Consumer Demands by Enhancing Ingredient Labels with Traceable Insights into Food Production
(if possible i will try to try to put other good blogs if i came across any)
can u assign this small issue?
I am beginner to open source and i know web development ,
if possible i would like collaborate with @prakharsingh-74 so that blog section look good..
can u assign this small issue?

@prakharsingh-74 how will you implement it?

@Suchitra-Sahoo by using html css and js


⚠ SkipTheCommericals has degraded performance

In ac4436f, SkipTheCommericals ($STC) experienced degraded performance:

HTTP code: 200
Response time: 2548 ms

Resolved: SkipTheCommericals performance has improved in 5dad629.


Elisp cleanups

Motivation for this change
Things done

Built on platform(s)

[ ] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
[ ] Tested execution of all binary files (usually in ./result/bin/)
21.11 Release Notes (or backporting 21.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[ ] Fits CONTRIBUTING.md.

@AndersonTorres When this PR is done could you assign me? I'd be happy to review once changes stop coming in :)

@adisbladis feel free to review it. I have finished it.

This breaks the tarball job. a3c0347b944342995677f46b6c5dc0c02c21e3ac contains invalid syntax.


maDateField timezone adjustment. Fixes #1271 #1305

There's an infinite loop $watching value and rawValue, because the Date object adjust the yyyy-mm-dd value to the user's timezone, then modifying the original value +- the timezone. This patch adjust the timezone, so the rawValue is kept as the original value.

There is an infinite loop, but it isn't due to the timezone but by a circular watch between two fields of the same scope.
I fix it with the PR #1318, which supersede this one.
Thanks for contributing!

Infinite loop  caused by the timezone changing the original value, indeed, inside the circular watch. Once Date() changes the rawValue, it's all messed up, but the angular.equals check seems legit to prevent that too.
I confirmed that 1.0.1 works, thanks a lot!
It would be nice if we can get some help with reference_many #1311 and embedded_list #786 too please?
Best regards


[SPARK-19949][SQL][follow-up] move FailureSafeParser from catalyst to sql core

What changes were proposed in this pull request?
The FailureSafeParser is only used in sql core, it doesn't make sense to put it in catalyst module.
How was this patch tested?
N/A

cc @gatorsmile

Test build #75156 has started for PR 17408 at commit 76b938b.

Test build #75156 has finished for PR 17408 at commit 76b938b.

This patch fails Scala style tests.
This patch merges cleanly.
This patch adds no public classes.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/75156/
Test FAILed.

Merged build finished. Test FAILed.

LGTM pending Jenkins

Test build #75215 has started for PR 17408 at commit 7100ec3.

Test build #75215 has finished for PR 17408 at commit 7100ec3.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/75215/
Test PASSed.

Thanks! Merging to master.


Default to workspace folder when saving nbs

For #9331

Codecov Report

Merging #10020 into master will decrease coverage by 0.01%.
The diff coverage is 0%.

@@            Coverage Diff             @@
##           master   #10020      +/-   ##
==========================================
- Coverage   61.19%   61.17%   -0.02%
==========================================
  Files         564      564
  Lines       30147    30148       +1
  Branches     4561     4562       +1
==========================================
- Hits        18448    18444       -4
- Misses      10667    10670       +3
- Partials     1032     1034       +2

Impacted Files
Coverage Δ

...ient/datascience/interactive-ipynb/nativeEditor.ts
56.86% <0%> (-0.13%)
:arrow_down:

src/client/common/utils/platform.ts
64.7% <0%> (-5.89%)
:arrow_down:

src/client/linters/pydocstyle.ts
86.66% <0%> (-2.23%)
:arrow_down:

src/client/datascience/debugLocationTracker.ts
76.56% <0%> (-1.57%)
:arrow_down:

src/client/common/process/proc.ts
14.49% <0%> (-0.73%)
:arrow_down:

src/client/constants.ts
80% <0%> (ø)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ead69d5...6cca7b4. Read the comment docs.


Create JWT GraphQL authentication mechanism

User Auth
Posted to GraphQL endpoint to check if user is logged out and grab the viewer object.
If someone wouldn't mind further splitting these off into separate issues/branches that would be great.
This project can provide a url for grabbing auth token.
https://github.com/jpadilla/django-jwt-auth
AuthenticatedQuery
Happens when ever auth is required on a page or to load the viewer object and data

user ID,
username
token

Sign Up

username
email
password
password confirmation

Login

username or email
password

Log out
Viewer object

user account
todos

https://auth0.com/blog/getting-started-with-relay/
It looks like the standard procedure is to check for a JWT client side, and provide it in the header's under Authorization whenever a post request is made to the relay server.


Feature request: Display outlines only at keyboard interaction

OpenUI5 version
All
Browser/version (+device/version)

Desktop, Windows 10 (ver. 1607)
Chrome 55.0.2883.87 m (64-bit)

URL (minimal example if possible)
https://openui5.hana.ondemand.com/#/entity/sap.m.IconTabBar/sample/sap.m.sample.IconTabBar
Any other information? (attach screenshot if possible)

This feature request may be controversial, but IMHO it is aesthetically unappealing to see those dotted lines every time wherever I click. This unfortunately encourages app developers to remove the focus ring completely. [1] [2] [3] [4]
It would be nice, if outlines are shown only when the user presses certain keys (like tab, arrows, etc.), and are hidden again when the user interacts with a mouse. I am not asking for complete removal of the focus indication. I hope this feature request is not against some a11y standards.
Thank you.

Edit: fixed broken screenshot link, added questions people attempting to remove the focus ring completely.

Hi,
I understand your need, but this really goes against accessibility standards. In general the focus must be visible(determinable) without user interaction.
If for instance, you have multiple inputs (or interactive elements) you wouldn't know which is the focused one, right?
On that ground I would reject the request here.
p.s. without any recommendation here, but you could have a look at this post and see if you can't workaround it in your case
cheers
Vladimir (OpenUI5)

Hi,
As per the comment abnove, I am closing this issue.
Best Regards,
Hristo

@vladimir-velinov: Thank you for the answer. I agree that the outline should be always visible for inputs. Apart from that, and also apart from the outline being displayed on the first focusable element when the page is ready, I request again to consider:

Hiding the outline when the user interacts via a mouse, and
Making it only visible when a keyboard is used
All of this, except for input-based controls which should have the outline always displayed on focus.

This is typically how most browsers handle the outline on "native" HTML elements which can be tested here. Chrome on Windows for example, when interacted via a mouse, doesn't display the outline on "native" buttons, radios, checkboxes, etc. whereas the outline is always shown on select and input elements regardless of the type of the interaction.
I suggest to adapt the browser's heuristic by making use of focus-ring (when available) to UI5 when it comes to displaying the outline. This would also improve consistency across web pages. I certainly fail to see how displaying an outline on a just-pressed-button gives any a11y value to a mouse user.
The basic polyfill for focus-ring from WICG explains the issue further and also why focus-ring was introduced in the first place.

I agree with @boghyon on the idea. Maybe a better/nicer/more discrete/less invasive implementation would be acceptable ?

In general the focus must be visible(determinable) without user interaction.

Actually, I'm curious which part of a11y standards supports the above requirement, or that focus indicator needs to be visualized also in pointer mode (mouse or finger).
Just went through various WCAG 2.x success criteria but couldn't find any statements that hiding the focus indicator in pointer mode would fail the success criterion.[1] And afaik, other standards such as VPAT or BITV base on WCAG as well when it comes to web content.
If it's not clearly defined by any standards, wouldn't it be acceptable to make the current behavior optional while adapting UA's behavior as default?

Also worth reading:

WICG discussion about having different focus indicator behavior for mouse and keyboard users
Explainer for the upcoming :focus-visible

If anyone is interested: UI5 Web Components will look into the idea of adopting the :focus-visible specification. https://github.com/SAP/ui5-webcomponents/issues/3986#issuecomment-1231386810


remove support for pre-5.26 Perl

Motivation for this change
remove support for pre-5.26 Perl
The older versions have been removed in https://github.com/NixOS/nixpkgs/pull/47416

LGTM. Please rebase on master, no need to go to staging with zero rebuilds :smile:

Please rebase on master, no need to go to staging with zero rebuilds

It might result in merge conflict, because perl-packages.nix is changed heavily on staging
And there is no hurry to remove the lines


Update Pepr Operator Docs

Describe what should be investigated or refactored
This PR demonstrates a better way to track status of CR's through events. We should update the Pepr operator tutorial to demonstrate this way as well.

Looking into addings helpers into Pepr Core or somewhere before we re-do these docs.


Gltf Examples have inconsitent behavior for rendering gltf

Bevy version
Cloned from github, currently on d1e5c507614e7c5da51349bc72c898a2ce9232be
[Optional] Relevant system information

Windows 11 Pro
cargo 1.63.0 (fd9c4297c 2022-07-01)
AdapterInfo { name: "NVIDIA GeForce RTX 2070 SUPER", vendor: 4318, device: 7812, device_type: DiscreteGpu, backend: Vulkan }

What you did

Run the example load_gltf with a custom GLTF exported from Blender
Run the example scene_viewer with the same model

What went wrong
Expected
Both the examples should render the model
Found

Model is visible in scene_viewer
Model is not visible in load_gltf

Additional information
I have tested the model with various other sources:

This online viewer
Using this example of rend3 crate which also uses wgpu (I had to comment the tangents part here as the model doesn't contain tangents)

Model seems to be rendering properly in these
Screenshots
From load_gltf

From scene_viewer

Changes
Only the paths of the models were changed in both examples.
In load_gltf
commands.spawn_bundle(SceneBundle {
        scene: asset_server.load("demo/house03.gltf#Scene0"),
        ..default()
    });

In scene_viewer:
 let scene_path = std::env::args()
        .nth(1)
        .unwrap_or_else(|| "assets/demo/house03.gltf".to_string());

Model info
I cannot share the model as it falls under a commercial license that prohibits sharing the model.
Model was exported by keeping textures outside the GLTF : .bin + .gltf + textures.
Troubleshoot
Disclaimer that I'm pretty new to rust and bevy
I tried to find the cause but couldn't pinpoint it. I believe the issue should be somewhere in GltfLoader.
I can try to find a solution if someone can point me in the right direction.

Example load_gltf is a basic example that just loads the file and displays it.
scene_viewer tries to be a little more clever and has a better camera. In this case, the important point is that it will compute the size of the model, and move the camera to make sure it is completely visible.
The load_gltf camera may be looking inside the house, or too far away, or just not in the right direction

Hi @mockersf
I've considered that case and have tried to change the scale and position of items for the same. I've also played with the camera position and look_at for the same. Other models (of similar size in blender) are working fine.
I'll try to integrate the camera used in scene_viewer to the load_gltf example and see if I missed something earlier.

You can try putting debug print for the values at https://github.com/bevyengine/bevy/blob/2eb9dd9dd9ae88c8adaf39bf7159b6832fd4e98f/examples/tools/scene_viewer.rs#L246-L249
That will show you the camera used in scene_viewer

Thanks for the help.
It was an issue with the position. Gltf has provided the translation value which I missed, and that's why I had this issue. Setting the translation in the gltf fixed it.
Closing this, as it's not an issue with bevy


Exported variables reset to default on non-tool scripts when saving a scene

Godot version:
db31445b905d94f055ffd210aee6d93cc39b8c96
OS/device including version:
Windows 10
Issue description:
Any variable you mark as @export with a script will get its value reset to its default any time you save a scene. If the script is marked as a tool script, the variable will save as intended though.
Steps to reproduce:

Open the project and main scene
Set the 'test_property' property in the root node to any value other that 0
Save the scene

Minimal reproduction project:
godot_4_export_variables_test.zip

Duplicate of https://github.com/godotengine/godot/issues/41690.


refactor: Plugin naming schema update

Packer updated their naming schema for plugins, and now it should be prefixed with packer-plugin-, for example packer-plugin-arm-image. While it may be a breaking change, it comes from upstream, so I think it should be followed.

fixed by #109


Ensure application status can always be changed to any available status

Describe the bug

If a submission does not have a status (eg, no default status was set), the submission cannot be changed to a different status.
If a submission has Status A, and Status B was created after the submission was submitted, the submission's status cannot be changed to Status B.

Expected behavior

Admins are able to add status to a submission that currently does not have a status. The same status dropdown shows for submissions without a status as for submissions with a status.
Admins are able to change a submission to any current status, including statuses created after the submission.

Additional context
This is needed as part of our bulk status updates work.

Pausing deployment on this until early July (when Swathi is back in).

Changes should the in the program's preview pdf button as shown in the screenshot -


Create temporary-storage-for-azure-app-service.md

Edit Review per CI 154209

@przlplx : Thanks for your contribution! The author(s) have been notified to review your proposed change.


Document what we do about unwinding and leaks

In https://github.com/rust-lang/rust/pull/67290 we added drop guards to collections that will attempt to continue dropping in case dropping an item unwinds. That means collections will either not leak if an item unwinds during drop, or will abort.
In https://github.com/rust-lang/rust/pull/75644 we've looked at preventing leaks if an unwind happens partway through initializing a MaybeUninit (usually for arrays).
We should come up with some concrete guidance on how we want to deal with leaks and unwinding

Has the perf impact of this been considered? I suspect that the necessary additional loops are not exactly zero-cost. I clicked through the linked issue and as far as I can tell there's not really a motivating statement why this should be done. The thing that started it was merely the finding that there are some leaks during a drop, but no discussion why that should be changed.

@the8472 Hmm, I don't remember what consideration it had, but I think avoiding leaks where possible is important to keep a healthy runtime. The performance impact is still important, but secondary to that.


[virtualbox] Win10 VM increase the disk size

Win10 VM for my work has 32GB, which is almost full.

Using Global Tools option on askubuntu.com then hit the issue:
Failed to resize the storage unit of the hard disk .../win10_64b/win10_64b.vmdk from 32.00 GB to 65.16 GB.

Resizing to new size<PHONE_NUMBER>2 is not yet supported for medium '/home/n130s/data/Dropbox/pg/VMWare/vm_active_notsynched/win10_64b/win10_64b.vmdk'.

Result Code: VBOX_E_NOT_SUPPORTED (0x80BB0009)
Component: MediumWrap
Interface: IMedium {4afe423b-43e0-e9d0-82e8-ceb307940dda}

According to this, I guess the file format is not compatible in my case.
$ ll
total 32G
drwxrwxr-x 4 n130s n130s 4.0K Feb 22 12:23 ./
drwx------ 2 n130s n130s 4.0K Feb 22 12:23 Logs/
drwx------ 2 n130s n130s 4.0K Feb 22 12:23 Snapshots/
-rw------- 1 n130s n130s  32G Feb 22 12:23 win10_64b.vmdk
drwxrwxr-x 3 n130s n130s 4.0K Feb 22 12:15 ../
-rw------- 1 n130s n130s 8.9K Feb 22 12:15 win10_64b.vbox
-rw------- 1 n130s n130s  13K Feb 22 12:15 win10_64b.vbox~
-rw------- 1 n130s n130s 8.9K Feb 22 12:15 win10_64b.vbox-prev

Giving up as the file format vmdk or vbox don't seem to what I can resize. Closing.
I'll install a new VM...


Outdated

This is no longer the publication process and should be updated to reflect the current state. Partners sign up through Partner Center, and the AppSource form has been retired. Registration happens here: aka.ms/joinmarketplace

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: a771ce0b-c24d-d9e1-c7bd-8aba7c77e3c1
Version Independent ID: 16927105-150c-cd9f-3b82-9e1d0125b54d
Content: Step 1: Fill the app submission form on AppSource (Common Data Service) - PowerApps
Content Source: powerapps-docs/developer/common-data-service/fill-app-submission-form-appsource.md
Service: powerapps
GitHub Login: @shmcarth
Microsoft Alias: jdaly

@BrianLevenson Content updated. Thanks.


feat(events): add scroll to top button

Demo:

This functionality would not be necessary in iOS devices, because touching the status bar, the view scrolls to top. 🤔
What do you thing?

Good point @ocarreterom. I still kinda like the button, but I guess either way works for iOS.

So, do we keep this for iOS, or do we restrict it for Android only? 🤔

@machour I still like it as is – keep the button on iOS.

@andrewda in my opinion if you want quick action to scroll to top, touching the current active tab is the best improvement. Android and iOS have this feature in common. I don't use any app that use a floating button to scroll.

Since we haven't come to a consensus here, going to close this for now (thank you thank you @lex111 for putting the work to make this work).
Let's keep the discussion flowing if somebody happens to think this would be nice to have and worthwhile. Thoughts @machour @chinesedfan?

I came up with a compromised solution that only setting the button visible when users scroll to top.

To be honest, I've never been a fan of this kind of button on websites, but I'm fine living with it if it's implemented (maybe a togglable configuration?)


Insert "pypi": "yes" into cookiecutter.json

This is needed to prevent the cookiecutter from removing the PyPI support from this project now that PyPI is optional. See: https://github.com/hypothesis/cookiecutters/pull/104

Don't want this: commando isn't supposed to have PyPI support


Add remote backups (presumably to AWS)

We should save the remote backups somewhere else. To be honest, the exact "somewhere else" doesn't matter at all (as long as it's secure)--- it just needs to be somewhere else, so that we aren't out of luck if something bad happens to our server itself.

This is assigned to me, since this is really something only I can do (since I have the AWS account)

aws s3 sync /home/silentselene/backups s3://silentselene-backup uploads backups to AWS. Next steps:

write a cron job to run this nightly
add a TTL to the s3 bucket

I added the TTL.


Start Flake8 checking of Numba source

A long-standing goal for Numba is enforcing code style using a tool like flake8.  To avoid disrupting the code history by trying to bring the entire code base up to compliance at once, this PR instead introduces a flake8 task into the Azure CI testing, but excludes all currently failing source files (which is most of them).
With this PR, the new policy will be:

New files need to be compliant.
When doing substantial edits to a file, remove it from the exclude list and fix the style errors.  Do this as a standalone commit to make the PR easier to review.
Reviewers should check that the above two rules are followed.

In the Numba 0.42 dev cycle, we'll be reviewing files for other issues (code that doesn't follow current Numba best practice, etc), at which time we'll also fix the style issues.  For now, reformat-only PRs are not desired.

Codecov Report

Merging #3495 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #3495   +/-   ##
=======================================
  Coverage   80.59%   80.59%
=======================================
  Files         392      392
  Lines       79592    79592
  Branches     9052     9052
=======================================
  Hits        64150    64150
  Misses      14030    14030
  Partials     1412     1412

Also, the flake8 configuration is taken from Dask's setup.cfg.  Open to suggestions about how to tweak it, if people have opinions.

Seems like numba/rewrites/ir_print.py needs adding to the ignore list as merge to master pulls in non-compliant version. Else change is good, thanks.

These error codes don't seem to flag any additional files, so I re-enabled them:
    E4,    # Import formatting
    E721,  # Comparing types instead of isinstance
    F811,  # redefinition of unused name

btw, this failed Azure because one of the jobs experienced a random 502 gateway error.  The job with the flake8 check did pass.

Thanks @seibert, I checked the Azure failure/pass state too, looks fine and correct as noted. Happy for this to be merged as a start to a long process. Thanks for doing the set up.


⚠ Text Filter API Endpoint has degraded performance

In 4fdb9a5, Text Filter API Endpoint (http://textfilter.roblox.com/) experienced degraded performance:

HTTP code: 200
Response time: 2402 ms

Resolved: Text Filter API Endpoint performance has improved in ed6034d.


make React.as_json public

Changes:

React.as_json is now a public method

Coverage remained the same at 100.0% when pulling bbb4862849159d2b6b07f6e0bfd64b372841f180 on feature/react_as_json into 206244601ac1bf496128c095afb3be5d1c879b02 on master.


Resource Binding for multiple Lambda Functions

I just noticed that lambda types are generated only once in the .sst folder for all lambda functions in our project.
I would expect to see separate types for each lambda because we bind different resources to the respective functions.
Is this intended our is something misconfigured in our project?

Hmm is there an issue you are running into?

No, its just a conceptional question as while I'm coding one particular lambda function, the typescript type definitions suggest an environment variable is available whereas it is not available because it was bound to another function. This gives a false sense of security when one of our devs forgets to check the actual bindings in the infrastructure part. So its more like a maintenance issue than a functional one.
Thus I am asking whether I set it up wrong or this case was not taken into consideration yet.
If it is intended, I think a quick note in the Resource Binding docs would be nice to raise awareness.
Anyway, thanks for your quick response Jay! Love your work here!

We are transition this repo to https://github.com/sst/v2 and are closing this issue for now. If it is still relevant please reopen it there - sorry for the trouble


Add vim-nox to ci/docker/install/ubuntu_core.sh

Description
Adds vim-nox package to ubuntu so the vim editor can be launched inside the container when needed.
Checklist
Essentials
Please feel free to remove inapplicable items for your PR.

[x] The PR title starts with [MXNET-$JIRA_ID], where $JIRA_ID refers to the relevant JIRA issue created (except PRs with tiny changes)
[x] Changes are complete (i.e. I finished coding on this PR)
[x] All changes have test coverage:
Unit tests are added for small changes to verify correctness (e.g. adding a new operator)
Nightly tests are added for complicated/long-running ones (e.g. changing distributed kvstore)
Build tests will be added for build configuration changes (e.g. adding a new build option with NCCL)
[x] Code is well-documented:
For user-facing API changes, API doc string has been updated.
For new C++ functions in header files, their functionalities and arguments are documented.
For new examples, README.md is added to explain the what the example does, the source of the dataset, expected performance on test set and reference to the original paper if applicable
Check the API doc at http://mxnet-ci-doc.s3-accelerate.dualstack.amazonaws.com/PR-$PR_ID/$BUILD_ID/index.html
[x] To the my best knowledge, examples are either not affected by this change, or have been fixed to be compatible with this change

@mxnet-label-bot add [CI, pr-awaiting-review]

@zachgk @lanking520 Can you take a look?


Fix memory leak from use of get/setToolOptions

Fixes #309

Coverage decreased (-0.006%) to 4.217% when pulling 739827cc825e9f34690ed38ec5b1ba36317e201b on nspin:bf-309-toolOptions-memory-leak into b9e70792d1b0621fdf6014a9ae4572d3fb4ae1f2 on cornerstonejs:master.

@nspin thanks for this! Almost positive this will get merged here soon. Bonus points if I can persuade you to write unit tests to cover this new functionality?

Looks good! Thanks! As @dannyrb said, if you feel like adding some tests and / or jsdoc comments, we would be very happy to merge that as well.

For sure - I'll write some tests and jsdoc.


when use 'flutter doctor'   alert  env: bash\r: No such file or directory

Steps to Reproduce

follow your doc download flutter.zip
unzip
run

flutter doctor

then alert
bash\r: No such file or directory

Logs
bash\r: No such file or directory

This error occurs if you download and unzip the WINDOWS version into MAC or UNIX!

Please make sure you have download for the RIGHT operating system!

This error occurs if you download and unzip the WINDOWS version into MAC or UNIX!

I downloaded the Linux version (v1.9.1) and I still get the error "/usr/bin/env: ‘bash\r’: No such file or directory" :/

I'm getting a similar error, but when trying to run flutter run inside spacemacs editor.
And this is important, I'm using zsh not bash and it returns this message making reference to bash for no reason I know. :(
This is my PATH in a Linux machine:
/home/aislan/Development/flutter/bin/cache/dart-sdk/bin:/usr/local/android-studio/bin:/home/aislan/Development/flutter/bin:/home/aislan/.asdf/shims:/home/aislan/.asdf/bin:/usr/local/sbin:/usr/local/bin:/usr/sbin:/usr/bin:/sbin:/bin:/usr/games:/usr/local/games:/path/to/elixir/bin:/home/aislan/.asdf/installs/nodejs/10.8.0/.npm/bin:/usr/lib/dart/bin:/home/aislan/.pub-cache/bin:/home/aislan/.pub-cache/bin/dart_language_server

Got this error today. I googled and found that it is probably related to line endings in the flutter script. Haven't found a solution yet.

I'm getting a similar error, but when trying to run flutter run inside spacemacs editor.
And this is important, I'm using zsh not bash and it returns this message making reference to bash for no reason I know. :(
This is my PATH in a Linux machine:
/home/aislan/Development/flutter/bin/cache/dart-sdk/bin:/usr/local/android-studio/bin:/home/aislan/Development/flutter/bin:/home/aislan/.asdf/shims:/home/aislan/.asdf/bin:/usr/local/sbin:/usr/local/bin:/usr/sbin:/usr/bin:/sbin:/bin:/usr/games:/usr/local/games:/path/to/elixir/bin:/home/aislan/.asdf/installs/nodejs/10.8.0/.npm/bin:/usr/lib/dart/bin:/home/aislan/.pub-cache/bin:/home/aislan/.pub-cache/bin/dart_language_server

I use zsh on macOS Catalina and was confused by that as well. Although I fixed it by editing the gradlew file in an android folder:
vim gradlew
:set fileformat=unix
:wq

Faced the same issue. Tried the below and that fixed it:

Clean build

flutter clean

Make the gradlew bin runnable in unix.

vim gradlew
:set fileformat=unix
:wq

Fix the flutter pub packages cache built from earlier session in windows

flutter pub cache repair

When I changed android folder and inside files line separator to CRLF, again get bash\r error. When android folder line separator is LF, its fixes problem. In windows there is no problem, project working fine but in Mac or Linux android folder line separator should be LF.

For fix problem just change line separator to LF this file :  project_folder/android/gradlew

I had the same issue, because my PATH included
/mnt/c/src/flutter/flutter/bin
before my manual include at the end of  PATH like this:
export PATH=$PATH:$FLUTTER_HOME/bin
I fixed the issue, by adding it to the front of PATH like that:
export PATH=$FLUTTER_HOME/bin:$PATH
Now my flutter path is called before the other path is reached.
I am not sure thow, where the other include is coming from.

If anyone else is having this issue even though you followed the official guide here: https://flutter.dev/docs/get-started/install/linux#update-your-path
This is how you fix it:
rm -rf flutter
git config --global core.autocrlf false
git clone git@github.com:flutter/flutter.git

For whatever reason, I got windows crlf in linux (wsl2). Git is installed and run from WSL2; not windows.

This error occurs if you download and unzip the WINDOWS version into MAC or UNIX!
Please make sure you have download for the RIGHT operating system!

100% True

Weirdly enough, I'm here again giving it another try. This time, I also had to add this to ~/.bash_aliases:
alias dart=~/flutter/bin/dart


parse and check command line before firing up Spark

@tpoterba: You did this, right?

We do the parsing.  We don't do file checking, but this will come later in a query optimizer


[polymer-editor-service] Completions at an empty attribute value are wrong

This is a bug in astFromSourcePosition. Given this code:

The cursor location should be an attribute value, as typing at that point would yield an attribute value, even though it's not quoted.
Originally posted at Fri, 18 Nov 2016 02:40:19 GMT at https://github.com/Polymer/polymer-editor-service/issues/31

Should also test

Originally posted at Fri, 18 Nov 2016 02:42:24 GMT at https://github.com/Polymer/polymer-editor-service/issues/31#issuecomment-261434190

Related: https://github.com/inikulin/parse5/issues/166
Originally posted at Fri, 18 Nov 2016 03:36:50 GMT at https://github.com/Polymer/polymer-editor-service/issues/31#issuecomment-261440977


Zoom multiplier on train not working

Describe the Bug
Zoom multiplier is a config option that change zoom when you are on train in F5. When you on the standing train zoom multiplier working as intended, but when train is moving it's not working and looks like normal F5. I'm not sure is it a speed of train that causing it or turning, but it's happening after a few seconds after train starts.
Reproduction Steps

Sit on train
Press F5
train starts
Zoom multiplier is'n working anymore

Expected Result
Expected that zoom remains after train starts.
Screenshots and Videos
No response
Crash Report or Log
No response
Operating System
Windows 10
Mod Version
0.5.1f
Minecraft Version
1.20.1
Other Mods
No response
Additional Context
No response

can't reproduce. Please send the game log next time it happens. it's at .minecraft/logs/latest.log.

Tested a few things
First of all, nothing appears in the logs.
Next, strangelly, it appears only in world that i played and where discovered that bug. I actually play with a lot of mods, but I tried without any other mods, just create and fabric api, in my world, and bug is still there. But in a new world, same create and fabric api - bug is not happening. Very very strange.

Video:
https://drive.google.com/file/d/1uK10nE1KfxTyjcf1MmCNWBqDfwHCfVJm/view?usp=sharing

I have observed this same issue too, I jumped into a train and after a few seconds the camera zoomed back in. For me I was guessing it was because I was playing on a multiplayer server that uses velocity proxy, so I figured a packet may be getting lost. However, this might not have been the case. The only known packet loss happens during login as with the proxy the client is already in the PLAY phase when the server receives the connection, thus forge config lib api port fails to send packets.
However, this doesn't seem applicable here thinking about it again as in my experience all packets sent during runtime arrive without issue.

I'm having the same issue.
The situation is the same as described by HB-Stratos, and there is nothing in the logs.

Still can't reproduce, might've been fixed. If anyone can get it to happen with patch J let me know and provide a world download.


Fix (possibly just update) reactotron

After updating the redux-saga package, app still crashes
Cannot read property 'startedAt' of undefined
Possibly https://github.com/infinitered/reactotron/issues/917
Commenting the line
https://github.com/Kamahl19/react-native-wallet/blob/6509e3cc28549f6608705aa3d69de553729d5d72/src/app/store/configureStore.dev.js#L13
fixed it

just remove reactotron altogether, no need for it

I love removing things.


ci: remove duplicate debug logs upload step

Motivation
https://github.com/ChainSafe/lodestar/actions/runs/8006063823/job/21866912900#step:19:20

Description
Remove duplicate debug logs upload step causing 409 error. See related issue https://github.com/actions/upload-artifact/issues/478, previously v3 would just override files while v4 now throws an error.

:tada: This PR is included in v1.17.0 :tada:


ai

whoops.  apologies.

Whew. For a moment I was worried that the recent parser regression made tap self-aware and we had a skynet situation on our hands.


How to make POST request with XML body

[X] I've read, understood, and done my best to follow the *CONTRIBUTING guidelines.

What did you do?
Trying to make a post request with xml body, I would like to know if that is the correct way to make it (check demo section below).
What did you expect to happen?
I'm still testing it.
What happened instead?
Still testing.
Alamofire Environment
Alamofire version: 4.9.0
Xcode version: 10.2.1
Swift version: 4
Platform(s) running Alamofire: iOS
macOS version running Xcode: macOS Mojave
Demo Project
let parameters = "<XML>........"
let sampleURL = URL(string: "http://<IP_ADDRESS>:8009")
var sampleReq = URLRequest(url: sampleURL!)
sampleReq.httpBody = parameters.data(using: String.Encoding.utf8, allowLossyConversion: sampleReq.httpMethod = "POST"
sampleReq.addValue("application/xml", forHTTPHeaderField: "Content-Type")
 Alamofire.request(sampleReq).responseData { (response) in
      print("Sample request: \(response.request)")
 }

You can clean it up a bit:

You can get Data from a String more easily: Data(string.utf8).
In Alamofire 5, you can set headers more easily: sampleReq.headers.update(.contentType("application/xml")).
I'd recommend using a real encoder for converting types to XML. There are a few available that would work with Codable types.

In the future, questions like this are better suited for our Swift forums.


Add a way to configure the Snipcart version

At the moment, the version of Snipcart is hardcoded, it could be nice to make it configurable, however, since the Snipcart team can change the markup / CSS classes, it might causes some issues with your cart customization.
Feel free to dismiss this issue if you prefer the keep the control on the version used by this theme.

The theme is aimed at developers so they should be able to take ownership and change it as they see fit. BUT I think it's a nice idea for testing or hotfixes.
I'll add a snipcart version overwrite in the theme settings in the upcoming v0.9.2
Thanks!

Done 😃


Delete organization

Is your feature request related to a problem?

Describe the solution you'd like.
Deletion button on the organization (settings) page. Ideally with a warning about lost resources, maybe even a way to specify which user/org they should be moved to or if they should be deleted as well.
Maybe with manual staff approval to avoid abuse.
Describe alternatives you've considered.
Pestering staff members 👀
Other
No response

Alternative for resources: Require that projects owned by the organization be removed or reassigned (manually) before organization deletion is allowed.


frame-support is still in the dependency tree

$ cargo tree -i frame-support

frame-support v4.0.0-dev (https://github.com/paritytech/substrate.git?tag=monthly-2023-06#6ef184e3)
├── frame-system v4.0.0-dev (https://github.com/paritytech/substrate.git?tag=monthly-2023-06#6ef184e3)
│   └── pallet-transaction-payment v4.0.0-dev (https://github.com/paritytech/substrate.git?tag=monthly-2023-06#6ef184e3)
│       ├── node-template v4.0.0-dev (/home/joshy/ProgrammingProjects/tuxedo/node)
│       └── pallet-transaction-payment-rpc-runtime-api v4.0.0-dev (https://github.com/paritytech/substrate.git?tag=monthly-2023-06#6ef184e3)
│           └── pallet-transaction-payment-rpc v4.0.0-dev (https://github.com/paritytech/substrate.git?tag=monthly-2023-06#6ef184e3)
│               └── node-template v4.0.0-dev (/home/joshy/ProgrammingProjects/tuxedo/node)
└── pallet-transaction-payment v4.0.0-dev (https://github.com/paritytech/substrate.git?tag=monthly-2023-06#6ef184e3) (*)

It looks like at least one reason this happens is because we have the rpc for pallet transaction payment. We definitely don't want that, so a first step is to rip that out.

Solved in #83

We still depend on frame-metadata unfortunately, and I've followed up about that in https://github.com/paritytech/substrate/issues/14296


Issue #12

Add a new Footer and add responsiveness to the website

You can still edit your issue title @Bryson69. use a naming convention - good practice for naming things. Btw, thanks for creating PR #29, will merge it now.


"Document size equals or is greater than" - unit of measure

For the condition "Document size equals or is greater than" there's no unit of measure included, and the Security and Compliance console doesn't specify when adding the condition to a rule, either.
Is this measured in bytes?
[Enter feedback here]

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 28be949f-8589-8f7c-8e08-c029389a1f6e
Version Independent ID: f5928319-0360-41fa-dda0-5473b4e1a5b2
Content: DLP policy conditions, exceptions, and actions (preview) - Microsoft 365 Compliance
Content Source: microsoft-365/compliance/dlp-conditions-and-exceptions.md
Service: o365-seccomp
GitHub Login: @chrfox
Microsoft Alias: chrfox

from the New-DLPComplianceRule cmdlet
The DocumentSizeOver parameter specifies a condition for the DLP rule that looks for messages where any attachment is greater than the specified size.
When you enter a value, qualify the value with one of the following units:

B (bytes)
KB (kilobytes)
MB (megabytes)
GB (gigabytes)
TB (terabytes)


Erro API

Source information
Slimeread
Source language
Português (Brazil)
Steps to reproduce
Entra no app
Tente entra na extensão SlimeRead
Expected behavior
Deveria entrar normalmente
Actual behavior
Deu erro de API
Mihon/Tachiyomi version
0.17.1
Android version
13
Other details
.
Acknowledgements

[X] I have searched the existing issues and this is a new ticket, NOT a duplicate or related to another open or closed issue.
[X] I have written a short but informative title.
[X] I have updated the app to version 0.15.3.
[X] I have updated all installed extensions.
[X] I have tried the troubleshooting guide.
[X] If this is an issue with the app itself, I should be opening an issue in the app repository.
[X] I will fill out all of the requested information in this form.

Add a :+1: reaction to issues you find important.

Duplicate of #6673, as I mentioned in your previous incorrect/duplicate issue request

Duplicado de #6673 , como mencionei em sua solicitação anterior de problema incorreto/duplicado

Como posso resolver???


"Turburea" is listed in the drop-down menu

Description:
"Turburea" is listed in the drop-down menu alongside its corresponding county, according to the law
Precondition:
The website is up an running.

Step 1
Type "Turburea" in the search bar.

Expected results
The location is listed in the drop-down menu as "Comuna Turburea, GORJ".


Fix components

This PR fixes the tests for the components.
Also, it fixes the component Sidebar. I changed the API, because it seems more logical to only use the make method for columns.
Unfortunately, it removes compatibility for V2. If you think that it's better to have both version I have to problem to improve this PR.
Fixes https://github.com/ralphjsmit/laravel-filament-components/issues/23

Hey @alexmanase, thanks for the PR, appreciated!
I am a bit hesitant to change the Sidebar syntax, because I do not really like breaking changes. But on the other hand, the new syntax is more in line with the other Filament syntax. Do you mind to add a little UPGRADE.md document with the change, so that people know about it?
Thanks!

Hi, @ralphjsmit
I added the UPGRADE.md file. I hope it's fine.

Thank you! Released in 2.0.0.


Non Puppet fragments should be ignored

I have a custom FrameLayout view which serves as a container for a Google map fragment. The SupportMapFragment gets added to the FrameLayout which in turn is used all over my implementation.
The problem arises when BackClick is triggered on an Activity or Fragment containing my custom FrameLayout. Rigger tries to invoke the back callbacks on non stacked fragments, which includes the SupportMapFragment of my custom view. This fragment is without a tag, so it isn't found in the mRiggerTransaction object and thus, a NotExistException is thrown.
The problem lies in _Rigger.java, on the dispatchBackPressed function. If a tag in the fragmentsWithoutStack array is null, it should be ignored. Or going back a step, when the fragmentsWithoutStack array is populated, in the getFragmentsWithoutStack of the FragmentStackManager.java it should not include tags that are null or tags that don't belong in Puppet fragments.

@iFanie  the tag added into FragmentStackManager should never be null , it only add the Fragment with @Puppet annotation,  please show me the code to help me understand your problem.

I have the following custom FrameLayout in the xml layout of my MapFragment. MapFragment is annotated with Puppet. The FrameLayout adds a GoogleMap fragment in itself, which obviously is not annotated with Puppet. Yet, I can see SupportMapFragment included in the FragmentStackManager its tag is null.
class GoogleMapView(context: Context, attributeSet: AttributeSet) : FrameLayout(context, attributeSet) {

    private var mapSubject: BehaviorSubject<GoogleMap>? = null

    init {
        if (!isInEditMode) {
            val mapFragment = SupportMapFragment.newInstance()
            val fragmentTransaction = (context as BaseActivity).supportFragmentManager.beginTransaction()

            fragmentTransaction.add(id, mapFragment)
            fragmentTransaction.commit()

            mapSubject = BehaviorSubject.create<GoogleMap>()

            Observable.create<GoogleMap> { emitter ->
                mapFragment.getMapAsync { map ->
                    emitter.onNext(map)
                }
            }.subscribe(mapSubject ?: throw RuntimeException("Uninitialized Google map"))
        }
    }

}

@iFanie It's weird, i will test on weekend and solve the problem ASAP, please tell me the version of Rigger lib.

@JustKiddingBaby, im using the latest version, 1.4.0
Thanks a lot, let me know if i can help you somehow.

mFm has the fragment with a null tag, neither mFragmentContainerMap nor mFragmentStack have the map fragment. So, i guess, a null check on line 192 would be sufficient.

@iFanie sorry for late, please update Rigger lib to 1.4.2 and try again.

@JustKiddingBaby it has been fixed, thank you


Basic color re-export does not work as intended

Bevy version
https://github.com/bevyengine/bevy/commit/c2ae51d13a012df0ed2cca0389511e91a323fc95
What you did
Attempted to use bevy_color::palettes::css::BLUE.
What went wrong
No type was found.
Additional information
This was attempted in #12172, but apparently did not work correctly. The unused_imports warning was probably indicative of that.

Investigating further... This may not be the issue I'm encountering.

Yeah, this isn't the case. Great!


Model Fails when we change batch size

For Cora dataset if I change the batch size to say 100 the model fails to run.
Traceback (most recent call last):
File "/anaconda3/lib/python3.7/site-packages/tensorflow/python/client/session.py", line 1334, in _do_call
return fn(*args)
File "/anaconda3/lib/python3.7/site-packages/tensorflow/python/client/session.py", line 1319, in _run_fn
options, feed_dict, fetch_list, target_list, run_metadata)
File "/anaconda3/lib/python3.7/site-packages/tensorflow/python/client/session.py", line 1407, in _call_tf_sessionrun
run_metadata)
tensorflow.python.framework.errors_impl.InvalidArgumentError: Cannot multiply A and B because inner dimension does not match: 2708 vs. 100.  Did you forget a transpose?  Dimensions of A: [100, 2708).  Dimensions of B: [100,1433]
[[{{node graph_convolution_1/SparseTensorDenseMatMul/SparseTensorDenseMatMul}}]]

This implementation does not support mini-batch training or changing the
batch size.
On Tue, Jul 2, 2019 at 12:41 AM tayalkshitij<EMAIL_ADDRESS>wrote:

For Cora dataset if I change the batch size to say 100 the model fails to
run.
Traceback (most recent call last):
File
"/anaconda3/lib/python3.7/site-packages/tensorflow/python/client/session.py",
line 1334, in _do_call
return fn(*args)
File
"/anaconda3/lib/python3.7/site-packages/tensorflow/python/client/session.py",
line 1319, in _run_fn
options, feed_dict, fetch_list, target_list, run_metadata)
File
"/anaconda3/lib/python3.7/site-packages/tensorflow/python/client/session.py",
line 1407, in _call_tf_sessionrun
run_metadata)
tensorflow.python.framework.errors_impl.InvalidArgumentError: Cannot
multiply A and B because inner dimension does not match: 2708 vs. 100. Did
you forget a transpose? Dimensions of A: [100, 2708). Dimensions of B:
[100,1433]
[[{{node
graph_convolution_1/SparseTensorDenseMatMul/SparseTensorDenseMatMul}}]]
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/tkipf/keras-gcn/issues/48?email_source=notifications&email_token=ABYBYYBSBEAA3DAVQA2K6YLP5KB3NA5CNFSM4H4WQ7QKYY3PNVWWK3TUL52HS4DFUVEXG43VMWVGG33NNVSW45C7NFSM4G4X6B4A,
or mute the thread
https://github.com/notifications/unsubscribe-auth/ABYBYYDLNW42ZPQP6SRBPNTP5KB3NANCNFSM4H4WQ7QA
.

Thanks for the reply. Does Pytorch or Tensorflow version supports mini-batch ?

No, but you might want to have a look here: dgl.ai
On Tue, Jul 2, 2019 at 7:52 AM tayalkshitij<EMAIL_ADDRESS>wrote:

Thanks for the reply. Does Pytorch or Tensorflow version supports
mini-batch ?
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/tkipf/keras-gcn/issues/48?email_source=notifications&email_token=ABYBYYGDXXMNQIXY3W2RCN3P5LUITA5CNFSM4H4WQ7QKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODZAEO2Y#issuecomment-507529067,
or mute the thread
https://github.com/notifications/unsubscribe-auth/ABYBYYHHGIGIDYO6GKF4Y4LP5LUITANCNFSM4H4WQ7QA
.

Thanks


Being able to make your bot advertise in trade.tf

I would like that the tf2-automatic bots would be able to make advertisments in the site trade.tf for more chances of your items being bought instead of just advertising on backpack.tf

As far as I'm aware trade.tf does not allow advertising on it's own, it only searches other community sites like backpack.tf, bazaar.tf, etc. Trade.tf also doesn't provide any API which would making any listings be pain in the ass, and it is unlikely any collaborator would want to spend time on this when there are better suggestions.


v0.2.0 arrived.

More functions, more flexible library and colourful outputs :3

This closes #3 , closes #4 , closes #5 , closes #6


Reduce code duplication (DRY) in favor of interface casting?

Hey,
this is not a real issue. More like a small discussion what you think about.
First of all thanks for this package. Very useful and well written.
After i had a look into the code i stumbled upon a lot of code duplication for very similar methods like

define the url
add options
get a request
allocate a pointer to a struct
make the request
return it

Like in:
func (s *IssuesService) ListByRepo(owner string, repo string, opt *IssueListByRepoOptions) ([]Issue, *Response, error) {
	u := fmt.Sprintf("repos/%v/%v/issues", owner, repo)
	u, err := addOptions(u, opt)
	if err != nil {
		return nil, nil, err
	}

	req, err := s.client.NewRequest("GET", u, nil)
	if err != nil {
		return nil, nil, err
	}

	issues := new([]Issue)
	resp, err := s.client.Do(req, issues)
	if err != nil {
		return nil, resp, err
	}

	return *issues, resp, err
}

All this can be stripped down to something like (attention: this code is not from this repo, but it shows an example:
func (s *ProjectsService) GetCommit(projectName, commitID string) (*CommitInfo, *Response, error) {
    u := fmt.Sprintf("projects/%s/commits/%s", projectName, commitID)
    p := new(CommitInfo)
    v, resp, err := test(s, u, p)
    return v.(*CommitInfo), resp, err
}

func test(s *ProjectsService, u string, v interface{}) (interface{}, *Response, error) {
    req, err := s.client.NewRequest("GET", u, nil)
    if err != nil {
        return nil, nil, err
    }

    resp, err := s.client.Do(req, v)
    if err != nil {
        return nil, resp, err
    }

    return v, resp, err
}

Something like this can avoid a lot of code duplication and reduce the code base.
I started a small discussion on the go-nuts mailing list. See Reduce code duplication for pointer allocation: Pro and Cons. But sadly there was no such a big discussion about this.
That is the reason why i try this way. I want to get your opinion about this or maybe an answer why this way wasn`t chosen.
Or maybe: Does it make sense for you?

There was some discussion some time ago about refactoring some of that duplicate code... it's probably on a pull request or issue somewhere.  I think the way we had talked about doing it was to add a new method onto the Client type that combined the NewRequest and Do calls.  So, using a modified version of your func, something like:
func (c *Client) Call(u string, v interface{}) (interface{}, *Response, error) {
    req, err := c.NewRequest("GET", u, nil)
    if err != nil {
        return nil, nil, err
    }

    resp, err := c.Do(req, v)
    if err != nil {
        return nil, resp, err
    }

    return v, resp, err
}

One downside of this approach is that there are a handful of functions in the go-github library that don't fit the mold... many that send custom Accept headers in the request and such.  You could use the above approach for the simpler methods and then let the outliers do the full work, or just pass an http.Header to the Call method (though that is kind of annoying since most cases won't use it).
I'm not sure that there would be much benefit to changing the go-github library at this point, since the work has already been done, but for other libraries it seems like a reasonable approach.

oh, you would also need to add the request body, so that would make the signature more like:
func (c *Client) Call(u string, req interface{}, resp interface{}) (*Response, error) {

You should also be able to drop the returned interface{}... it's a pointer anyway, so the caller already has a copy of it.

ah, missed the http method too, so now you're up to:
func (c *Client) Call(method, u string, req interface{}, resp interface{}) (*Response, error)

You should also be able to drop the returned interface{}... it's a pointer anyway, so the caller already has a copy of it.
Yes you are true.

But thanks for your answer. Your answer proves (to me) that there is no real technical issue here (as disadvantage).
Of course you can generalize it more and more, like making the method (GET, etc.) exchangeable as well.

For me this issue can be solved / closed, because you answered all my points.
And maybe a change in this direction would be a micro optimization, so this decision is more up to you. :)
But thanks for your feedback.


[Shell History] Fix multi line command issue

Description

Show detail of a command history
Fix multi line command history search

Screencast

Checklist

[x] I read the extension guidelines
[x] I read the documentation about publishing
[x] I ran npm run build and tested this distribution build in Raycast
[x] I checked that files in the assets folder are used by the extension itself
[x] I checked that assets used by the README are placed outside of the metadata folder

Hi!
Thank you for your contribution! My name is Milena and I will be reviewing it today.
It all looks good to me, so far. Just one small thing: when one of the params is too long, it breaks the UI. Maybe it should be trimmed. What do you think? I saw this happening a lot with my git commits with messages, so it seems like a frequent thing.

Hi @mil3na. Thanks for the suggestion, have submitted a commit to shorten the overly long command character. Please continue to review.


Resilient write streaming

Is your feature request related to a problem? Please describe.
Writing a file to Alluxio is not resilient against worker losses mid-streaming.
Describe the solution you'd like
Writing a file should hold on to an entire block buffer until it is properly written to a cache space.
AlluxioFileOutStream can take data-stream replication responsibility from BlockOutStream and uses the held buffers to replay write for a replacement worker in case of mid-streaming failures.
Describe alternatives you've considered
Holding to the full block might make memory pressure in write-heavy workloads.
However, holding on the full block is inevitable because the worker-side block store does not allow chunk/page level commits.
Urgency
Writes are getting lost in environments that experience worker unavailability due to overload.

I think this issue is more nuanced once you start considering more of the underlying features Alluxio provides over some of the UFSes. Alluxio has the concept of WriteType which has THROUGH and CACHE_THROUGH types.
For these, we write files to the UFS via a single stream on the designated worker. If we are to lose that worker, then the file would only ever be half complete. UFSes currently don't support append operations, so if we are to make writes resilient by retrying on a different worker, we would need to consider how to join data already written to the UFS via the lost worker, data which may have been streamed to the worker and not written to the UFS, and then finally the rest of the data in the file in order to get the *THROUGH write types working properly.

Discussion moved to https://github.com/Alluxio/alluxio/issues/14041


Issue with /docs/concepts/cluster-administration/out-of-resource/

This is a...

[ ] Feature Request
[x] Bug Report

Problem:
The last section of Configuring Out Of Resource Handling, "How kubelet ranks pods for eviction in response to inode exhaustion" mentions
https://github.com/google/cadvisor/issues/1422 as future work, but this issue is closed. Is the doc up to date?
Proposed Solution:
@dashpole @derekwaynecarr is this entire page up to date regarding that issue?
Page to Update:
https://kubernetes.io/docs/concepts/cluster-administration/out-of-resource/

Bumping for tech review.

/remove-lifecycle stale


Change element option to be an input instead of a container

<label for="medical-condition-input">What is your medical condition?</label>
<input id="medical-condition-input" type="text">

AccessibleTypehead({
  element: document.querySelector('#medical-condition-input'),
  source: suggest
})

I don't think it is possible to do this in a seamless way (which is the point of this issue).
The typeahead's plain JS api works by using the Preact render method, which appends to a container. It can reuse existing DOM, but if there is anything different from the component's initial render() and the existing DOM it's attempting to reuse, the existing DOM will be flushed.
The other way is to carry over every attribute from the specified input to the one in the component. Doing this without a whitelist so they don't override existing attributes we care about sounds buggy. Moreover, you would need to carry over event listeners that are attached to that specified input, which may not be possible.
The other way is to despite all of this find a way to reuse the specified input. However, because of virtual DOM, there's no guarantee that will stay that way for long and it won't be replaced with another instance, which doesn't have all the state attached to the original one.
I feel the work required to make this work is too complex and bug-prone so I'd prefer to stick to the current API for now.


Fix flaky WellKnownTypesTest junit tests

WellKnownTypesTest pass in local development environment, but fails in CI

This is actually not a flaky test, you wrote the tests regarding to your timezone. Those tests did not work in my local because I live in GMT+3.
The LocalDateTime is actually independent of timezone. Thus it should be converted using UTC time.

#20

@Dogacel You're right 😓 These tests would only succeed in UTC+9:00 which is my local timezone. Thanks for pointing it out 🙇♂


support redirect to url when not authenticated

when a protected url is called and the user is not authenticated, support redirecting the user to a particular URL, typically one that shows a login box. After login, make it possible to be redirected again to the URL that was protected...

Done!


Update about and terms of use

About and terms of use texts have been modified, per Jon Lund's request.

LGTM!