required error

I found an mistake, then i give an expression or callback for required attribute, other methods forget this param and work incorrect.
For example:
MyField {
required: "#Tmp:checked",
min: 10
}
then element #Tmp is not checked, means that value of MyField can be less then 10, how i understand, but it give an error.
i fixed it like this:
depend: function (param, element) {
	this.dependParam = param || this.dependParam;
	return this.dependTypes[typeof this.dependParam]
	? this.dependTypes[typeof this.dependParam](this.dependParam, element)
	: true;
},

dependParam: undefined,

dependTypes: {
	"boolean": function (param, element) {
		return param;
	},
	"string": function (param, element) {
		return !!$(param, element.form).length;
	},
	"function": function (param, element) {
		return param(element);
	}
},

optional: function (element) {
	var required = $.validator.methods.required.call(this, $.trim(element.value), element, this.dependParam);

	return !required || required == "dependency-mismatch";
}

I don't understand the problem nor your solution - what did you change?

I have just experienced this issue and think that the issue is an extra '!' in the following function. The result of the problem is that the required attribute breaks IE forms. I haven't extensively tested this BUT it appears to have solved the problem.
This is the original line of code I have changed return !!$(param, element.form).length;
dependTypes: {
    "boolean": function (param, element) {
        return param;
    },
    "string": function (param, element) {
        return !$(param, element.form).length;
    },
    "function": function (param, element) {
        return param(element);
    }
}


Fail to load capturing image to crop

With gallery, everything is ok. But when i open camera to capture, I have the issue be like this: java.lang.RuntimeException: Failed to load sampled bitmap: file:///storage/emulated/0/MyDir/img_1463316925324.jpg. I'm using newest version

Can you reproduce it in the sample app?
Can you post the full exception stack.

D/Error: java.lang.RuntimeException: Failed to load sampled bitmap: file:///storage/emulated/0/MyDir/img_1463625998776.jpg.
I/dalvikvm: Could not find method android.content.Context.checkSelfPermission, referenced from method com.theartofdev.edmodo.cropper.CropImage.isReadExternalStoragePermissionsRequired.
But i'm still use permission ReadExternalStorage in Manifest ??

Using marshmallow? see Pick image for cropping from Camera or Gallery

No, i'm using 4.4.2 (API 19). Any suggestion ?

Can you reproduce it in the sample app?
On Thu, May 19, 2016, 18:34 lingboo<EMAIL_ADDRESS>wrote:

No, i'm using 4.4.2 (API 19). Any suggestion ?
—
You are receiving this because you commented.
Reply to this email directly or view it on GitHub
https://github.com/ArthurHub/Android-Image-Cropper/issues/73#issuecomment-220362698

ye, here is my sample app: https://github.com/lingboo/CropImage

Can't reproduce it on Nexus 5 (19), Moto X (23) or emulators...
So first change the exception log to Log.d("Error", "failed", exception); instead of Log.d("Error",error.toString()); to get the full error.
Second try changing the camera output uri to:
File file = new File(getExternalCacheDir() + File.separator + "MyDir" + File.separator);

P.S. Originally I meant if you can reproduce it in the sample app of the library.

Your sample project a bit different with my project(i wanna as simple as possible):(
Full exception stack following:
D/Error: failed
java.lang.RuntimeException: Failed to load sampled bitmap: file:///storage/emulated/0/Android/data/life.kiwi.cropimage/cache/MyDir/img_1463821262675.jpg
at com.theartofdev.edmodo.cropper.BitmapUtils.decodeSampledBitmap(BitmapUtils.java:130)
at com.theartofdev.edmodo.cropper.BitmapLoadingWorkerTask.doInBackground(BitmapLoadingWorkerTask.java:87)
at com.theartofdev.edmodo.cropper.BitmapLoadingWorkerTask.doInBackground(BitmapLoadingWorkerTask.java:26)
at android.os.AsyncTask$2.call(AsyncTask.java:288)
at java.util.concurrent.FutureTask.run(FutureTask.java:237)
at android.os.AsyncTask$SerialExecutor$1.run(AsyncTask.java:231)
at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1112)
at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:587)
at java.lang.Thread.run(Thread.java:841)
Caused by: java.io.FileNotFoundException: /storage/emulated/0/Android/data/life.kiwi.cropimage/cache/MyDir/img_1463821262675.jpg: open failed: ENOENT (No such file or directory)
at libcore.io.IoBridge.open(IoBridge.java:409)
at java.io.FileInputStream.(FileInputStream.java:78)
at java.io.FileInputStream.(FileInputStream.java:105)
at android.content.ContentResolver.openInputStream(ContentResolver.java:627)
at com.theartofdev.edmodo.cropper.BitmapUtils.decodeImageForOption(BitmapUtils.java:268)
at com.theartofdev.edmodo.cropper.BitmapUtils.decodeSampledBitmap(BitmapUtils.java:117)
at com.theartofdev.edmodo.cropper.BitmapLoadingWorkerTask.doInBackground(BitmapLoadingWorkerTask.java:87)
at com.theartofdev.edmodo.cropper.BitmapLoadingWorkerTask.doInBackground(BitmapLoadingWorkerTask.java:26)
at android.os.AsyncTask$2.call(AsyncTask.java:288)
at java.util.concurrent.FutureTask.run(FutureTask.java:237)
at android.os.AsyncTask$SerialExecutor$1.run(AsyncTask.java:231)
at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1112)
at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:587)
at java.lang.Thread.run(Thread.java:841)
Caused by: libcore.io.ErrnoException: open failed: ENOENT (No such file or directory)
at libcore.io.Posix.open(Native Method)
at libcore.io.BlockGuardOs.open(BlockGuardOs.java:110)
at libcore.io.IoBridge.open(IoBridge.java:393)
at java.io.FileInputStream.(FileInputStream.java:78)
at java.io.FileInputStream.(FileInputStream.java:105)
at android.content.ContentResolver.openInputStream(ContentResolver.java:627)
at com.theartofdev.edmodo.cropper.BitmapUtils.decodeImageForOption(BitmapUtils.java:268)
at com.theartofdev.edmodo.cropper.BitmapUtils.decodeSampledBitmap(BitmapUtils.java:117)
at com.theartofdev.edmodo.cropper.BitmapLoadingWorkerTask.doInBackground(BitmapLoadingWorkerTask.java:87)
at com.theartofdev.edmodo.cropper.BitmapLoadingWorkerTask.doInBackground(BitmapLoadingWorkerTask.java:26)
at android.os.AsyncTask$2.call(AsyncTask.java:288)
at java.util.concurrent.FutureTask.run(FutureTask.java:237)
at android.os.AsyncTask$SerialExecutor$1.run(AsyncTask.java:231)
at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1112)
at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:587)
at java.lang.Thread.run(Thread.java:841)

File not found, it is possible that the camera app failed to save the captured image
Try changing the path

Thank you, but i don't see any wrong in my Uri or file path. I go into my file manager in my device and see the file display, and in android studio still error.

ok... but is changing the path works?
The library doesn't do anything special, it just opens the stream to the file so I'm not sure how I can help

Ok, thanks for fast reply. :+1:

I have the same issue as well ! working on build tools 26.0.2, support version 26.1.0.


[5.9 🍒][Compile Time Constant Extraction] Refactor collection of opaque type requirements

Cherry-pick of https://github.com/apple/swift/pull/67034
To reduce duplication of logic with other parts of the compiler, instead of destructuring the constraint type, write the requirements in the opaque type declaration's generic signature.

@swift-ci test

@swift-ci test


dense image captioning

how do I add region descriptions to an image (grounded image descriptions)? I would like to annotate my images using bounding boxes for the different regions and two or more text descriptions for each region instead of just a single label. How do I go about it?

Are text attributes https://openvinotoolkit.github.io/cvat/docs/manual/basics/creating_an_annotation_task/#labels suitable for your needs?


[prim,fpv] Fix delays in assertions of prim_fifo_async_sram_adapter

Rather strangely, these were originally correct but became wrong with commit 1ebc7a9de3d (which was made as the author brought up an FPV environment). Make them right again.

Yeah judging by the commit message on that later change, I think this may have been merged accidentally.
Changes LGTM.

CHANGE AUTHORIZED: hw/ip/prim/rtl/prim_fifo_async_sram_adapter.sv
SVA-only change.


Range support for matrices

Because why not?
var a = MathS.Matrix(new Entity[]
{
    { 1, 2, 3 }
    { 4, 5, 6 }
    { 7, 8, 9 }
});

Then
a[1..]

would return
Matrix[2x3]
4 5 6
7 8 9

Forcing
a[1.., ..]

would be much clearer.

We can have both, right?


The user license doesn't allow the permission: Delete

I am having issues installing 2.12 into a full sandbox. I installed it without any issues into a partial sandbox a few weeks ago and now when installing it into a full sandbox, I am receiving the following problem from the failed package install email:

The user license doesn't allow the permission: Delete dlrs__LookupRollupSummary__c
LookupRollupSummariesFull: The user license doesn't allow the permission: Delete dlrs__LookupRollupSummary__c

I am a system admin with full access so not sure why I'm getting this error. I am getting it when I try to install for admins as well as for all users.

Figured it out, was due to one of the permission sets from the package being assigned to a guest user.


Zero-shot accuracy on ImageNet (in the CLIP setting) is lower than the number reported in the paper

Zero-shot accuracy on ImageNet (in the CLIP setting)
Top-1 accuracy: 77.15
Top-5 accuracy: 95.51
Paper reported accuracy on ImageNet is (Top-1): 88.5

The 88.5 accuracy mentioned in the paper here should be the 10B model, which seems to have not been announced yet. The published 0.4b model looks at the data in the paper and is (Top-1) 78.5.

How do I load the 10B model? Is it open-sourced yet?

How do I load the 10B model? Is it open-sourced yet?

All models are released here: https://www.modelscope.cn/organization/M_Square. Meanwhile, we provide a simple example at https://github.com/alipay/Ant-Multi-Modal-Framework/blob/main/prj/M2_Encoder/run.py. By modifying cfg['model_config'], you can switch to different-sized models.

Thank you.


Errors on npm run build - fix

fixes #516

I think adding an extra generic type parameter to filterProperties is a better solution here. I have https://github.com/Microsoft/TSJS-lib-generator/pull/518 up with that change.

closing in favor of https://github.com/Microsoft/TSJS-lib-generator/pull/518


Project Settings not being maintained/requiring relaunch

Platform: Windows 11 / Godot 4.2 Dev 4 (I know, sorry)
It appears several, possibly all project settings for Jolt 3D do not take effect until the editor is restarted.
Easy enough to test by trying to tweak sleep settings and getting no change until a restart.

I'm fairly confident that this is not an issue with this extension, and rather a general problem with Godot. It's not really something that I can mess up in the first place, as far as I know.
I've noticed when changing many project settings that the actual saving of them won't take effect until you've mashed the save button a couple of times, although it's not perfectly consistent across all settings for some reason.
An easy/obvious way to test it is by changing something like the Display > Window > Mode setting and the running the application. I always end up with the old display mode on the first run, unless I save like 3+ times before running, but then the setting will typically apply on the second run.
I'm seeing the same behavior when changing the sleep settings of this extension. Let me know if that sounds similar to what you're observing.


It doesn't work at all

It's not working at all I'm so sad

It's not showing any signs nor auto Play I m so disappointed i always felt proud of myself by using this but now it feels as though I lost one of my body organ please revive it again


[SPARK-47549][BUILD] Remove Spark 3.0~3.2 pyspark/version.py workaround from release scripts

What changes were proposed in this pull request?
This PR aims to remove Spark 3.0~3.2 pyspark/version.py workaround code from release scripts.
This is a logical revert of SPARK-38411 because Spark 3.0~3.3 are the end of support status.

https://github.com/apache/spark/pull/36803

Why are the changes needed?
To simplify the release script for Apache Spark 4+
Does this PR introduce any user-facing change?
No.
How was this patch tested?
Manual review.
Was this patch authored or co-authored using generative AI tooling?
No.

cc @HyukjinKwon

Merged to master.

Thank you, @HyukjinKwon !


Relation with no back-reference failing on deploy

Current behavior
When using an @relation with a name, and no back-reference, it still fails with the error "A relation directive with a name must appear exactly 2 times."
Reproduction
type Transaction {
  ...
  buy_amount: Float
  buy_currency: Currency @relation(name: "BuyCurrency")
  sell_amount: Float
  sell_currency: Currency @relation(name: "SellCurrency")
}

type Currency {
  id: ID! @unique
  name: String!
  symbol: String!
}

Expected behavior?
Back-references are supposed to be optional.

Hey @mburak, this is currently expected if there are at least 2 relations to the same outgoing type - Currency in this example. A feature request to allow this situation exists here: #1907.


[TOKENOMICS, DO NOT MERGE] - Draft6 Line Comment Feedback!

@Valdorff I think you can just close this now. I will replace it once we're at a final review stage.

Closing as said above. If you land here looking for a place to comment on the tokenomics proposals, feel free to DM or post in the  discord thread and we can direct you somewhere up-to-date.


Color mode

Bright color mode for all elements. (Some design changes still needed, line thickness, etc)

Merged in #28.


Allow PathType for ingress to be defined other than Prefix

From Kubernetes 1.22, i think, the  the PathType on the Ingress needs to be ImplementationSpecific when using regex.
https://kubernetes.github.io/ingress-nginx/faq/#validation-of-path

When "ingress.spec.rules.http.pathType=Exact" or "pathType=Prefix", this validation will limit the characters accepted on the field "ingress.spec.rules.http.paths.path", to "alphanumeric characters", and "/," "_," "-." Also, in this case, the path should start with "/."
When the ingress resource path contains other characters (like on rewrite configurations), the pathType value should be "ImplementationSpecific".

thank you @fulgas for @ypoplavs to check it out


fix: untracked files preventing checkout

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

AWS CodeBuild CI Report

CodeBuild project: GitHubPipelineAutoBuildProj-eNGjrh4O6eRH
Commit ID: 3c9617f6085b48123b045841d3d19b0480e4144c
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository


asdf does not support sh

David Sweeney in this Elixir Forum post recently discovered the issue that our language_server.sh is no longer sh compatible because asdf (added in https://github.com/elixir-lsp/elixir-ls/pull/78) is not currently sh compatible.
The error manifests itself with an error like:
/home/my_home/.asdf/asdf.sh: 8: /home/my_home/.asdf/asdf.sh: Bad substitution
I have raised an issue on asdf to determine if asdf is meant to support sh/dash, or only bash and other shells.
I see a few possible ways forward but would like to collect other's thoughts about them:

Change language_server.sh to run bash instead of sh (via #!/usr/bin/env bash)
Revert #78
Wait for asdf to support sh

I'm currently leaning towards option 1 because bash is very widespread at this point and I'd imagine most systems will have it and for any that don't, the user will most likely understand how to fix the error.

I think it's fine to require bash on a system running elixir-ls --- sh compatibility is desirable, but not a need for us. As you said, bash is pretty much today's sh.

Agreed


IOU - Save button is not above keyboard when waypoint input is in focus

If you haven’t already, check out our contributing guidelines for onboarding and email<EMAIL_ADDRESS>to request to join our Slack channel!

Version Number: 1.4.77-0
Reproducible in staging?: Y
**Reproducible in production?:**N
If this was caught during regression testing, add the test name, ID and link from TestRail: https://github.com/Expensify/App/pull/42464
Issue reported by: Applause - Internal Team
Action Performed:
Precondition:

Recent destinations list has a few addresses

Go to staging.new.expensify.com
Go offline
Go to FAB > Submit expense > Distance
Tap Start
Tap on the input
Note that Save button does not appear above the keyboard
Tap system back button (or swipe) to dismiss the keyboard while the input is still in focus

Expected Result:
In Step 5, Save button will appear above the keyboard (production behavior)
In Step 7, Save button will appear at the bottom when keyboard is dismissed and input is still in focused
Actual Result:
In Step 5, Save button does not appear above the keyboard (production behavior)
In Step 7, Save button is missing at the bottom when keyboard is dismissed and input is still in focused
Workaround:
Unknown
Platforms:

Which of our officially supported platforms is this issue occurring on?

[x] Android: Native
[ ] Android: mWeb Chrome
[x] iOS: Native
[ ] iOS: mWeb Safari
[ ] MacOS: Chrome / Safari
[ ] MacOS: Desktop

Screenshots/Videos
Add any screenshot/video evidence

https://github.com/Expensify/App/assets/78819774/102574c5-553c-4820-8c1f-2f67d156bf93
View all open jobs on GitHub

@trjExpensify  FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors

We think that this bug might be related to #wave-collect - Release 1

The Start and Stop inputs don't work at all for me 🤨
https://github.com/Expensify/App/assets/6833644/380c3a8d-ded3-4383-9dad-f71d3cb7c701
Same thing online or offline.

Yeah, I've got an infinite spinner after entering the waypoints when online.

^^ looks like that might be similar to another deploy blocker reported here and potentially related to this PR.

Alright this is caused by https://github.com/Expensify/App/pull/35045. Reverting fixes the issue:
https://github.com/Expensify/App/assets/6833644/1b4036c4-1822-4f64-a99a-43c7963bfe94

@arosiclair Looks like the submit button is being hidden intentionally.

That's definitely not true. We always show submit buttons above the keyboard.

Revert was merged and CP'd so this is all set


[BEAM-351] Add DisplayData to KafkaIO

Be sure to do all of the following to help us incorporate your contribution
quickly and easily:

[x] Make sure the PR title is formatted like:
[BEAM-<Jira issue #>] Description of pull request
[x] Make sure tests pass via mvn clean verify. (Even better, enable
Travis-CI on your fork and ensure the whole test matrix passes).
[x] Replace <Jira issue #> in the title with the actual Jira issue
number, if there is one.
[ ] If this contribution is large, please file an Apache
Individual Contributor License Agreement.

R: @dhalperi / @bjchambers

Coverage decreased (-0.007%) to 69.316% when pulling 49624248f4547652b3bd8104d1596c68c3db2a58 on aviemzur:kafkaio-display-data into 4bba380cb011e38bd78c1ec899a6672a6b02fd05 on apache:master.

R: @rangadi  @amitsela     can you take a look?
Amit, would you mind handling merging of this one? I'm swamped and you use Kafka more than I do ;)

@dhalperi no problem!

@rangadi @amitsela addressed your comments in my latest commit.

Coverage decreased (-0.1%) to 69.189% when pulling 8829d01e3ca094c9c84346a2008134aa0af9534b on aviemzur:kafkaio-display-data into 4bba380cb011e38bd78c1ec899a6672a6b02fd05 on apache:master.

LGTM, pending Travis.

@aviemzur can you please rebase and push so Travis would do us the courtesy of running ? thanks!

Rebased on master.

Coverage increased (+0.003%) to 69.193% when pulling 7fd48d43ea8b154b63820e62438d3b55e53c4daa on aviemzur:kafkaio-display-data into d66029cafde152c0a46ebd276ddfa4c3e7fd3433 on apache:master.

Merging.


Allow queue selection for fetching orders on the Orders and Products Page

What is the motivation for adding/enhancing this feature?
Currently, users fetch both orders from the pre-order and backorder queues on the Orders and Products page. We want to enable users to select other virtual queues as well for fetching orders from OMS on the Orders and Products page.
What are the acceptance criteria?

[ ] ...

Can you complete this feature request by yourself?

[ ] YES
[ ] NO

Additional information

Will add UI in sometime

https://www.figma.com/file/wK5FMs4z2zXQR9VfHV9ycE/Dhiraj's-Ionic-6-Material-UI-Kit-(Community)?type=design&node-id=28225%3A110223&mode=design&t=rN4Dk3mylbjH7oZD-1


bump playwright from 1.40.1 to 1.42.1

Pull Request Test Coverage Report for Build<PHONE_NUMBER>
Details

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 99.584%

Totals

Change from base Build<PHONE_NUMBER>:
0.0%

Covered Lines:
11974

Relevant Lines:
11978

💛  - Coveralls


There is no error information bar when trying to open one expired table attachment whose SAS URL is generated by an access policy

Storage Explorer Version: 1.31.0-dev
Build Number: 20230628.1
Branch: main
Platform/OS: Windows 10/Linux Ubuntu 20.04/MacOS Ventura 13.4.1 (Apple M1 Pro)
Architecture: x64/arm64
How Found: From running test cases
Regression From: Previous release (1.30.0)
Steps to Reproduce

Expand one storage account -> Tables.
Create a table -> Right click the table.
Click 'Manage Stored Access Policies...' -> Add one access policy (set to expire after 2 minutes).
Attach the table via SAS URL generated by the access policy.
Open the table attachment after it expires.
Check whether there is an error information bar.

Expected Experience
There is an error information bar.

Actual Experience

There is no error information bar.
The table explorer displays as blank.

Additional Context
This issue doesn't reproduce for other services.

My best guess is that this is related to recent networking work. I will investigate and reassign if needed.

This is not related to the recent networking changes. It seems that error handling was changed in commit a2b4a8695a6d39c69b4287adeccec9819e7b3cb0. The error handling code introduced in this commit results in an exception in the scenario described by the issue.

@MRayermannMSFT I'm not sure the commit ID you mentioned is the right one. That has a very small change in TopLevelNodesProvider.ts which does not appear to be related to error handling code at all.

Verified this issue on the build main 20230709.3. Fixed.


BlackBox tests on Cavium arm64 box are failing currently

For example: https://jenkins.edgexfoundry.org/view/blackbox-testing/job/blackbox-testing-cavium-arm64-master/2/console
In particular this line in the console logs: The mongoSeed variable is not set. Defaulting to a blank string.
I believe the fix is to add an entry for mongoSeed in blackbox-testing/bin/arm64_env.sh

@weichou1229 @cloudxxx8 what are your thoughts on this issue. Do you agree with @JPWKU proposed fix ?

@andyf1967 yes , he's right ,
but consul and mongo-seed are not require deploy independently  in https://wiki.edgexfoundry.org/display/FA/Get+EdgeX+Foundry+-+Users  ,
must update https://github.com/edgexfoundry/blackbox-testing/blob/master/deploy-edgeX.sh and https://github.com/edgexfoundry/blackbox-testing/blob/master/docker-compose.yml to meet the document

@JPWKU it looks like the mongo-seed environment variable is missing in https://github.com/edgexfoundry/blackbox-testing/blob/master/bin/arm64_env.sh
In current design, we only need "mongo-seed" instead of "mongo" docker image.
Do we have mongo-seed docker image for arm64?

fixed by https://github.com/edgexfoundry/blackbox-testing/pull/42/files


Updated instructions to create an nginx ingress controller build

This change is

Coverage remained the same at 45.509% when pulling 4daa03cdbd5b61687a5e819d2010ee69ecb6c7e5 on lihan:584-build-doc-update into c36d6ffbff265955eafd619e1b2db817b9dc33e8 on kubernetes:master.


feat(translations): add new ko labels

added translations from client

we are still missing two more label translations. Will wait until end of week

Still missing translations. Will merge this for now. Opening a PR for the second part when client is done.


Error detected while processing function 19_SetStatusLine[4]..19_hi_statusline[2]..19_hi:

Error detected while processing function <SNR>19_SetStatusLine[4]..<SNR>19_hi_statusline[2]..<SNR>19_hi:
line   15:
E417: missing argument: guibg=
Press ENTER or type command to continue
E417: missing argument: guibg=
Press ENTER or type command to continue

I think something wrong with my vim statusline but I can't find the reason.
VIM - Vi IMproved 8.1
Ubuntu 18
Thanks.

This does not seem to be about vundle. Are you sure you didn't mean to raise this issue somewhere else?

@davidlowryduda I noticed it's cauesed by a plugin https://github.com/tpope/vim-fugitive , not vundle.

Thanks for letting me know. Good luck!


window mount for all user

We use the juicefs client on Windows, but only the current session can use the mounted drive. The drive cannot be used by other remote desktop sessions.

This is a known issue, we will provide a script and document on how to use net use to mount it as a network drive, then it can be accessed by multiple users.

If you run juicefs.exe as SYSTEM the mount point if available for all users.   There are multiple ways of doing this.  NSSM/etc, but if you have sysinternals installed.
psexec -s -i cmd.exe  will allow you start a cmd.exe shell as system and you can start juicefs.exe from there.  (note: you can directly start juicefs.exe as part of the command line but I didn't illustrate that here.)

@Arcyne Cool! Do you know the underlying details? I'm thinking of is it possible to have a option --allow-other for Windows without running as SYSTEM?


Remove wrong event binding

The method onFiles is not available in this directive, the events are bound in method initEvents.
This removes the following runtime error:

angular2.dev.js:23501 EXCEPTION: Error during evaluation of "change"
angular2.dev.js:23501 TypeError: this.directive_9_0.onFiles is not a function
    at AbstractChangeDetector.ChangeDetector_ProfileComponent_0.handleEventInternal (viewFactory_ProfileComponent:1841)
    at AbstractChangeDetector.handleEvent (angular2.dev.js:8036)
    at AppView.triggerEventHandlers (angular2.dev.js:10736)
    at eval (viewFactory_ProfileComponent:2181)
    at angular2.dev.js:13905
    at angular2.dev.js:13254
    at Zone.run (angular2-polyfills.js:1243)
    at Zone.run (angular2.dev.js:13456)
    at NgZone.run (angular2.dev.js:13418)
    at HTMLDivElement.outsideHandler (angular2.dev.js:13253)

Not really tested but I think without that the directive won't work.

This combination of dropzone and file selection is causing the error at my side

Drop your file here...

    <input type="file" [ng-file-select]="uploadOptions" (onUpload)="handleUpload($event)">

And the error onFiles is not a function is telling correctly that there is no method onFiles in the NgFileDrop directive.
I think this could be a copy&paste error because this method exists in the NgFileSelect directive.

I'm using the exact same setup as @JulianH and I can say this fixes the error. But the file-drop and file-select work.

Okay, merging then.


Logos in white?

The initial idea was to have only monochrome (i.e. white) logos in the 'Who is using Vert.x' section. Any objections?

+1

Changes can be previewed here: http://vert-x3-preview.michel-kraemer.com/

Michel - I have a bunch more logos to convert to monochrome.
If you can tell me how to do it (Don't have photoshop but do have Gimp) I can do the rest myself so as not to bother you each time :)

Increase brightness to 100% and decrease saturation to 0%. The RedHat logo needed some extra work because not all elements could be differentiated well in monochrome. So if you don't get good results, send me the logo(s).
If you add the images to the webpage, please follow these 'guidelines':

make them 180px wide (see the other logos already there)
set correct width and height in the HTML file to avoid stretching the images
if the logo seems too large (i.e. too dominant compared to the others) add a small transparent border to the left and right in Gimp but keep the 180px. (see jClarity_logo.png for example).

By the way, it's much fun for me working on the website. You may send me as many logos as you like :-)
Hope this helps,
Michel

Oh, and I sorted the logos alphabetically by the way.

I tried to edit some logos myself in GIMP but couldn't get them right, so If you could do it, it would be a great help :)

Sure thing. I received two logos by mail. You can send me the others as well if you like.
By the way: I still don't have the right permissions to commit to this repository. I'm wondering if I should send you a PR for such small changes. I don't want to keep you away from more important work. :-)

I messed up the teams, but you should be ok to push now :)

Works perfectly. I just pushed my first commit! :-) I moved the highlight.pack.js file to the correct location to fix the syntax highlighting.

I just added new logos of Bosh, Cyanogen and Groupon.


Incorrect problems history count

Describe the bug
I'm using Query Mode: Problems -> History. It returns 2 resolved and 1 active problem. Then I'm applying Count transformation, and the resulting calculation is 2 instead of 3. Which implies that it's not calculating active problems.
Expected behavior
I expect both resolved and active problems to be calculated.
Screenshots

Software versions

Grafana
Zabbix
Grafana-Zabbix Plugin

7.3.6
5.0.7
4.1.1

I have a similar problem. I need sum problems from multiples zabbix sources. As below:

do you help me?


Update client libraries to Kubernetes 1.13

Signed-off-by: Tamal Saha<EMAIL_ADDRESS>

travis-e2e.sh test is timing out. This seems unrelated to this pr.

I restarted the job, but lately we've had very little flakes, if the same thing happens I think it'll need a look.

seems to have failed again. restarting once more. we may need to dig into the failures as other PRs are not flaking this much

Looks like something is off.

@brancz , sorry it took me a while to research the issue. But the tests are passing now. The problem was that the new k8s.io/klog library requires the glog flags to be explicitly initialized.
PTAL.

lgtm thanks!

@tamalsaha thanks a lot indeed! :+1:


fix(ipfs-service-provider): Synced with upstream repo

:tada: This PR is included in version 1.8.16 :tada:
Your semantic-release bot :package::rocket:


Feature/select dataverse

Purpose
Allows users to select between different Dataverse repositories or input their own. We have currently been exclusively using dataverse.harvard.edu, but there are currently 10 repositories listed at http://dataverse.org, as well as an unknown number of local installations (e.g., http://apitest.dataverse.org for testing).
Note that we are only compatible with Dataverse 4.0+, and the majority (if not all) Dataverses listed on http://dataverse.org have not yet been upgraded. The preset selectable list of Dataverses can be configured at website/addons/dataverse/settings.
Resolves https://github.com/CenterForOpenScience/osf.io/issues/2636
Changes

Switch to use of external accounts

Allows multiple Dataverse accounts per user
Allows users to select Dataverse repository when connecting an account
Note: Because ExternalAccount was OAuth-specific and Dataverse does not use OAuth, there are several unintuitive workarounds that allow Dataverse to store account information on ExternalAccount objects. These instances should all be documented.

Switch to use of serializer

Side effects

Clean up routes to be more consistent with other addons using external accounts
Fix permissions for several routes
Migration will need to be run to move old style auth to external accounts

Migration at scripts/dataverse/migrate_to_external_account.py
Tests at  scripts/tests/test_dataverse_migrate_to_external_account.py

1st pass finished. :point_up:

Changes made, with a couple comments/questions for @sloria.


Wild card urls

Customers has reservation whitelisting request especially for wildcard URLs below. Can we provide strong technical justification for these wildcards. Otherwise, is it possible to provide the extended list of URLs without wildcards (e.g. https://*.windows.net  = 50 URLS)?
• https://.windows.net
• https://.microsoftonline.com
• http://.passport.net
• https://.azureedge.net

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 6bad26a7-056d-6855-1bca-39be98071659
Version Independent ID: b438f290-83cd-6a24-6549-d12d45ac0ed8
Content: Required URLs for Asia/Pacific area-based organizations - Power Platform
Content Source: power-platform/admin/internet-url-asia-pacific.md
Service: power-platform
GitHub Login: @jimholtz
Microsoft Alias: jimholtz

@avi-dev-git
Please contact technical support for this issue. https://powerapps.microsoft.com/support/


WFLY-14326 Replace 'Java Architecture for XML Binding|JAXB, Java API …

Issue: https://issues.redhat.com/browse/WFLY-14326
(Replace "Java Architecture for XML Binding|JAXB, Java API for JSON Binding|JSON-B, Java API for XML-Based Web Services|JAX-WS" references in java doc with corresponding Jakarta EE ones)
Link with: https://github.com/wildfly/wildfly/pull/13808

CC- @asoldano @scottmarlow

CC- @asoldano @scottmarlow

@jimma please review

Hi @RanabirChakraborty,
It looks fine, but I can find more uses of JAXB, etc. E.g.,

./docs/src/main/asciidoc/_javaee-guide/Jakarta_XML_Web_Services.adoc:35:(JAXB)]
./docs/src/main/asciidoc/_javaee-guide/Jakarta_XML_Web_Services.adoc:48:JAXB 2.0
./docs/src/main/asciidoc/_javaee-guide/Jakarta_XML_Web_Services.adoc:94:payload and thus require being compatible with JAXB2. Actually you
./docs/src/main/asciidoc/_javaee-guide/Jakarta_XML_Web_Services.adoc:95:wouldn't need any JAXB annotations for this particular example, because
./docs/src/main/asciidoc/_javaee-guide/Jakarta_XML_Web_Services.adoc:96:JAXB relies on meaningful defaults. For the sake of documentation we put
./docs/src/main/asciidoc/_javaee-guide/Jakarta_XML_Web_Services.adoc:146:http://java.sun.com/webservices/jaxb/[JAXB documentation].
./docs/src/main/asciidoc/_javaee-guide/Jakarta_XML_Web_Services.adoc:214:    -b, --binding=        One or more Jakarta XML Web Services or JAXB binding files
./docs/src/main/asciidoc/_javaee-guide/Jakarta_XML_Web_Services.adoc:251:|ObjectFactory.java |JAXB XML Registry
./docs/src/main/asciidoc/_javaee-guide/Jakarta_XML_Web_Services.adoc:252:|package-info.java |Holder for JAXB package annotations
./docs/src/main/asciidoc/_javaee-guide/Jakarta_XML_Web_Services.adoc:256:Basically wsconsume generates all custom data types (JAXB annotated

I have an old script, rgrep, which does a recursive scan of a directory of files. The first argument is the string your looking for, and the second argument is a template of files you're looking at. For example, if you want to look at every file, use '*'. To get the lines above, I used

rgrep 'JAXB' '*' |grep -v 'No such file'|grep -v JAXBElement | grep -v JAXBException | grep -v JAXBContext

Here, I'm looking for JAXB in every file. Then I send the list of lines through some filters that remove lines I'm not interested in. "grep -v JAXBElement" will filter out every line that doesn't have the Class name JAXBElement, .

Hello @ronsigal I'm following this document for changing Java EE specs to Jakarta EE specs https://access.redhat.com/documentation/en-us/red_hat_jboss_enterprise_application_platform/7.3/html-single/development_guide/index#java-ee-specifications-and-the-corresponding-jakarta-ee-specifications_default
Here for Java Architecture for XML Binding or JAXB the Jakarta one is also JAXB.

Hey @RanabirChakraborty,
I was editing my comment - you're too fast for me. ;-)
It looked like you were replacing every instance of "JAXB" with "Java Architecture for XML Binding", so I just did a brute force search for occurrences of "JAXB". I may well have found instances that didn't need to be changed.
-Ron

Hmmm, that's strange. I see

Java Architecture for XML Binding
JAXB
JAXB

Java API for JSON Binding
JSON-B
Jakarta JSON Binding

so it says to change "Java Architecture for XML Binding" to "JAXB" but to change "Java API for JSON Binding" to "Jakarta JSON Binding". But there's no reference to "Jakarta JSON Binding Specification" ...

Anyway, I was just thinking that it may be worth doing a mechanical scan to catch loose ends.

Sure @ronsigal I'll run the query and follow the steps as you have mentioned.

I got this for JAX-WS:

Looking for JAX-WS in files matching *
./.git/objects/pack/pack-45510e776812605434b659c1b4473494e3a5c792.pack
Binary file ./.git/objects/pack/pack-45510e776812605434b659c1b4473494e3a5c792.pack matches
===========
./docs/src/main/asciidoc/_developer-guide/Jakarta_XML_Web_Services_User_Guide.adoc
./docs/src/main/asciidoc/_developer-guide/Jakarta_XML_Web_Services_User_Guide.adoc:5:Services (JAX-WS / JSR-224)] defines the mapping between WSDL and Java
./docs/src/main/asciidoc/_developer-guide/Jakarta_XML_Web_Services_User_Guide.adoc:7:publishing them. JBossWS implements the latest JAX-WS specification,
./docs/src/main/asciidoc/_developer-guide/Jakarta_XML_Web_Services_User_Guide.adoc:659:API for XML-Based Web Services (JAX-WS) 2.2]
===========
./docs/src/main/asciidoc/_developer-guide/wsconsume.adoc
./docs/src/main/asciidoc/_developer-guide/wsconsume.adoc:290:|target |The JAX-WS specification target. Allowed values are 2.0, 2.1
===========
./testsuite/integration/ws/src/test/java/org/jboss/as/test/integration/ws/wsrm/generated/ReliableService_Service.java
./testsuite/integration/ws/src/test/java/org/jboss/as/test/integration/ws/wsrm/generated/ReliableService_Service.java:50://    //This constructor requires JAX-WS API 2.2. You will need to endorse the 2.2
./testsuite/integration/ws/src/test/java/org/jboss/as/test/integration/ws/wsrm/generated/ReliableService_Service.java:51://    //API jar or re-run wsdl2java with "-frontend jaxws21" to generate JAX-WS 2.1
./testsuite/integration/ws/src/test/java/org/jboss/as/test/integration/ws/wsrm/generated/ReliableService_Service.java:57://    //This constructor requires JAX-WS API 2.2. You will need to endorse the 2.2
./testsuite/integration/ws/src/test/java/org/jboss/as/test/integration/ws/wsrm/generated/ReliableService_Service.java:58://    //API jar or re-run wsdl2java with "-frontend jaxws21" to generate JAX-WS 2.1
./testsuite/integration/ws/src/test/java/org/jboss/as/test/integration/ws/wsrm/generated/ReliableService_Service.java:64://    //This constructor requires JAX-WS API 2.2. You will need to endorse the 2.2
./testsuite/integration/ws/src/test/java/org/jboss/as/test/integration/ws/wsrm/generated/ReliableService_Service.java:65://    //API jar or re-run wsdl2java with "-frontend jaxws21" to generate JAX-WS 2.1
===========
./testsuite/integration/ws/src/test/java/org/jboss/as/test/integration/ws/cdi/interceptor/CdiInterceptorTestCase.java
./testsuite/integration/ws/src/test/java/org/jboss/as/test/integration/ws/cdi/interceptor/CdiInterceptorTestCase.java:42: * [JBWS-3441] Support CDI interceptors for POJO JAX-WS services
===========
./testsuite/integration/xts/src/test/java/org/jboss/as/test/txbridge/fromjta/service/FirstServiceATService.java
./testsuite/integration/xts/src/test/java/org/jboss/as/test/txbridge/fromjta/service/FirstServiceATService.java:37: * This class was generated by the JAX-WS RI. JAX-WS RI 2.1.6 in JDK 6 Generated source version: 2.1
===========
./webservices/server-integration/src/main/resources/schema/jboss-as-webservices_1_2.xsd
./webservices/server-integration/src/main/resources/schema/jboss-as-webservices_1_2.xsd:44:        be used for JAX-WS client and JAX-WS endpoint implementations, elements client-config and
./webservices/server-integration/src/main/resources/schema/jboss-as-webservices_1_2.xsd:45:        endpoint-config respectively.  These configurations can include JAX-WS handlers and key/value
./webservices/server-integration/src/main/resources/schema/jboss-as-webservices_1_2.xsd:238:          Defines the name of the JAX-WS handler. The name must be unique within the handler chain.
./webservices/server-integration/src/main/resources/schema/jboss-as-webservices_1_2.xsd:247:          Defines a fully qualified class name for the JAX-WS handler implementation.
===========
./webservices/server-integration/src/main/resources/schema/jboss-as-webservices_1_1.xsd
./webservices/server-integration/src/main/resources/schema/jboss-as-webservices_1_1.xsd:177:          Defines the name of the JAX-WS handler. The name must be unique within the handler chain.
./webservices/server-integration/src/main/resources/schema/jboss-as-webservices_1_1.xsd:186:          Defines a fully qualified class name for the JAX-WS handler implementation.
===========
./webservices/server-integration/src/main/resources/schema/jboss-as-webservices_2_0.xsd
./webservices/server-integration/src/main/resources/schema/jboss-as-webservices_2_0.xsd:44:        be used for JAX-WS client and JAX-WS endpoint implementations, elements client-config and
./webservices/server-integration/src/main/resources/schema/jboss-as-webservices_2_0.xsd:45:        endpoint-config respectively.  These configurations can include JAX-WS handlers and key/value
./webservices/server-integration/src/main/resources/schema/jboss-as-webservices_2_0.xsd:282:          Defines the name of the JAX-WS handler. The name must be unique within the handler chain.
./webservices/server-integration/src/main/resources/schema/jboss-as-webservices_2_0.xsd:291:          Defines a fully qualified class name for the JAX-WS handler implementation.
===========

I'll run the query

Cool. Let me know if you have any trouble. And I'll come back and look again.

Hello, @ronsigal I ran the script as well as the command you have provided and found out the left places where JAX-WS is mentioned. I have done the changes in a few places. but in most of the places, I think changing will be a bit out of scope.
1.
===========
./testsuite/integration/ws/src/test/java/org/jboss/as/test/integration/ws/wsrm/generated/ReliableService_Service.java
./testsuite/integration/ws/src/test/java/org/jboss/as/test/integration/ws/wsrm/generated/ReliableService_Service.java:50:// //This constructor requires JAX-WS API 2.2. You will need to endorse the 2.2
./testsuite/integration/ws/src/test/java/org/jboss/as/test/integration/ws/wsrm/generated/ReliableService_Service.java:51:// //API jar or re-run wsdl2java with "-frontend jaxws21" to generate JAX-WS 2.1
./testsuite/integration/ws/src/test/java/org/jboss/as/test/integration/ws/wsrm/generated/ReliableService_Service.java:57:// //This constructor requires JAX-WS API 2.2. You will need to endorse the 2.2
./testsuite/integration/ws/src/test/java/org/jboss/as/test/integration/ws/wsrm/generated/ReliableService_Service.java:58:// //API jar or re-run wsdl2java with "-frontend jaxws21" to generate JAX-WS 2.1
./testsuite/integration/ws/src/test/java/org/jboss/as/test/integration/ws/wsrm/generated/ReliableService_Service.java:64:// //This constructor requires JAX-WS API 2.2. You will need to endorse the 2.2
./testsuite/integration/ws/src/test/java/org/jboss/as/test/integration/ws/wsrm/generated/ReliableService_Service.java:65:// //API jar or re-run wsdl2java with "-frontend jaxws21" to generate JAX-WS 2.1

Here I can't replace JAX-WS API 2.2 with Jakarta XML Web Services 2.2 because there is nothing like that (https://jakarta.ee/specifications/xml-web-services/)
2.
===========
./webservices/server-integration/src/main/resources/schema/javaee_web_services_1_2.xsd
./testsuite/integration/vdx/target/wildfly/docs/schema/javaee_web_services_1_2.xsd:223:This element also associates a WSDL service with a JAX-WS Provider
./testsuite/integration/vdx/target/wildfly/docs/schema/javaee_web_services_1_2.xsd:269:port components that are JAX-WS Provider implementations.
./testsuite/integration/vdx/target/wildfly/docs/schema/javaee_web_services_1_2.xsd:282:components that are JAX-WS Provider implementations
./testsuite/integration/vdx/target/wildfly/docs/schema/javaee_web_services_1_2.xsd:359:To be used with JAX-WS based runtime only.
./testsuite/integration/vdx/target/wildfly/docs/schema/javaee_web_services_1_2.xsd:671:This is not required when JAX-WS based runtime is used.

Here also I can't change the presence of JAX-WS because javaee_web_services_1_2.xsd is own by oracle and maybe it'll not be a good idea to replace with Jakarta EE specification names (https://www.oracle.com/webfolder/technetwork/jsc/xml/ns/javaee/javaee_web_services_1_2.xsd).

Hi @RanabirChakraborty,

I have done the changes in a few places

Great!

in most of the places, I think changing will be a bit out of scope.

Sure, it throws a wide net.
Did you also search for the other names / phrases, e.g., JAXB, "Java API for JSON Binding", etc.?
-Ron

@ronsigal Yes! Did the same for JAXB and JSON-B :)

@ronsigal can you please confirm if you're fine with this PR contents now? Thanks

Hi @RanabirChakraborty,
Thank you for doing the extra checks. Looks good to me!
-Ron


[BUG] Helm repo add not working as expected

Describe the bug
Helm repo add not working as expected in https://github.com/opensearch-project/helm-charts#installation
To Reproduce
$ helm repo add opensearch https://opensearch-project.github.io/helm-charts/
Error: looks like "https://opensearch-project.github.io/helm-charts/" is not a valid chart repository or cannot be reached: failed to fetch https://opensearch-project.github.io/helm-charts/index.yaml : 404 Not Found
Expected behavior
Helm repo added
Chart Name
All
Screenshots
If applicable, add screenshots to help explain your problem.
Host/Environment (please complete the following information):

Helm Version: [version.BuildInfo{Version:"v3.7.0", GitCommit:"eeac83883cb4014fe60267ec6373570374ce770b", GitTreeState:"clean", GoVersion:"go1.16.8"}]
Kubernetes Version: [Server Version: version.Info{Major:"1", Minor:"21", GitVersion:"v1.21.1", GitCommit:"5e58841cce77d4bc13713ad2b91fa0d961e69192", GitTreeState:"clean", BuildDate:"2021-05-21T23:01:33Z", GoVersion:"go1.16.4", Compiler:"gc", Platform:"linux/amd64"}]

Additional context
Add any other context about the problem here.

@peterzhuamazon It appears the GitHub pages branch is private. Do you mind confirming that it is set to public?

You will first need to create a branch named gh-pages and push it. Then the branch will be available in the "Pages" settings of this repository.

@peterzhuamazon It seems the chart releaser workflow is failing.

Thanks @mprimeaux for the detailed comments.
Thanks for that.
I will try to enable this tomorrow.

If you’d like to pair on it, then please let me know. Happy to jump on a Zoom or whatever.

@mprimeaux For now we have reverted the PR, after creating the branch, we will merge the PR again.

Here is a minor update to watch. While I do not believe it applies to us since we have a public repository, we ran into the issue in our private repository.

Hi @mprimeaux another question if you dont mind.
Please bare with me as I am still learning about this cr thing.
I assume gh-pages branch is synced with main.
Then is there any reasons to create branches like 1.0.0 for OpenSearch 1.0.0, and so on?
If user wants to install specific version such as 1.0.0, 1.0.1, or later 1.1.0, will this be supported by helm repo?
If so, how do we approach to enable that?

PS:
I also realize our description of opensearch helm chart is still:
description: A Helm chart for Kubernetes

Probably needs to rename it once I bump versions.
Thanks.

@peterzhuamazon No worries. Happy to provide more detail.
The Chart Releaser Github action is what pushes the index to the gh-pages branch and after creating releases for the related charts.
There is not a need to create and maintain version-specific branches but more of a stylistic question to be answered by the maintainers. The Chart Releases tags with the version number and then generates release artifacts. Here is an example.
Yes, agree the description should be updated.

Thanks @mprimeaux this does raise a concern from me.
The release show as opensearch-dashboards-1.0.2 and so on which is chart version, internally use dashboards 1.0.0.
This is quite confusing to users as they can probably take it as dashboard version 1.0.2.
In reality we havent even release dashboards 1.0.2 yet.
I am wondering if we can have a fix to this before we enable the repo?
I can already see people opening issues asking why opensearch-dashboards-1.0.2 install 1.0.0.

@peterzhuamazon The reason for the versions at 1.0.2 is because I was playing around in my forked repository.

@mprimeaux @peterzhuamazon Till we have it working end to end can we revert the commit for linting and releasing as we have put the wrong installation instructions in the README. Once we fix we can re-merge.

@peterzhuamazon The reason for the versions at 1.0.2 is because I was playing around in my forked repository. You can see I updated the chart versions here and here (again, in my forked repository).
One option to avoid confusion is for me to delete my forked repository or at least make it private.

I understand that is your own fork, but still if Semver version bumping is required now, you will have situation where opensearch-1.0.9 is actually using docker image 1.0.0 internally. And if the release show as opensearch-1.0.9 community can mistakenly think it is running docker image 1.0.9 which doesnt exist.

@peterzhuamazon I would sincerely prefer to work through this simple fix, which I described in this comment.
The version attribute of the chart is on a separate lifecycle from the appVersion and the image in the values.yaml.
A way forward would be to disable the version checking in the Helm Chart releaser action but, as I agree with @smlx , it is critical to enforce Semver in charts so the community using it understands the impact of changes.
Can we please work through this?

I understand that is your own fork, but still if Semver version bumping is required now, you will have situation where opensearch-1.0.9 is actually using docker image 1.0.0 internally. And if the release show as opensearch-1.0.9 community can mistakenly think it is running docker image 1.0.9 which doesnt exist.

@peterzhuamazon This is usual as the version is the Chart Version, appVersion is the backing "applications" version and the image attribute in the values.yaml is the container image (i.e. Docker image).

@mprimeaux

The Chart can be at version: 1.0.1, appVersion: 2.0.0, and imageTag: 1.0.0 and this expected and usual. It is important that these lifecycles be capable of being managed separately.

I reel chart version and imageTag should match. It makes things clearer and simpler, and I don't care much about the appVersion though.

@TheAlgo and I have some concerns on release happen on every small changes.
It is a moving target on every release and it becomes uncertain if the release is stable.
We can probably remove the auto release workflow and just release manually, but keep the repo function of helm.
@DandyDeveloper @smlx please let us know your thoughts on this.
I apologize that I am not fully aware of the complete picture initially.
Should we keep bumping versions and release every push, or we should proceed with a more stable way.

I reel chart version and imageTag should match. It makes things clearer and simpler, and I don't care much about the appVersion though.

Please take this comment as nothing but constructive as it is often difficult to understand tone and intention in written words but this is not how the Kubernetes community broadly works. I can provide countless examples (i.e. here and here for the kube-prometheus-stack and here and here for the AWS Load Balancer Controller) where there is an expectation that the lifecycles of the Helm chart, the application, and the related image remain distinct because the lifecycles operate at different frequencies.
I sincerely appreciate your understanding and hearing me out on this point. Please let me know how I can support as many of us are eager to use the Helm charts.

I reel chart version and imageTag should match. It makes things clearer and simpler, and I don't care much about the appVersion though.

Please take this comment as nothing but constructive as it is often difficult to understand tone and intention in written words but this is not how the Kubernetes community broadly works. I can provide countless examples (i.e. here and here for the kube-prometheus-stack and here and here for the AWS Load Balancer Controller) where there is an expectation that the lifecycles of the Helm chart, the application, and the related image remain distinct because they do operate at different frequencies.
I sincerely appreciate your understanding and hearing me out on this point. Please let me know how I can support as many of us are eager to use the Helm charts.

Not sure if I am understanding correct but the chart version and the underlying docker image version is matching for 2 latest versions of AWS Load Balancer Controller.

@TheAlgo I believe you are comparing the appVersion and the imageTag attributes and not the version attribute and the imageTag, which are 1.2.8 and v2.2.4, respectively.

@mprimeaux Apologies I believe I mis-interpreted at first 😅. Need to restart myself. appVersion and imageTag I wanted to refer to at start.
I think chart version and imageTag should match. It makes things clearer and simpler, and I don't care much about the appVersion though

@TheAlgo No worries, mate. Ah yes, that sounds good. I do believe quite a few Helm charts do also prefer to keep the appVersion and imageTag the same for simplicity.  IMHO, and to reduce the conversation a bit, I think it is important to allow the chart's version to evolve at a different pace than that of appVersion and imageTag.

@TheAlgo As a follow-up and for completeness, the Helm Chart Releaser only validates the version attribute in Chart.yaml and does not consider the appVersion or imageTag.

Assuming I'm reading right, I agree wholly with @mprimeaux on this. Version is distinctly different from the imageTag referenced by the appVersion and its much easier to trace changes and automated things if we define chart version increments in a PR.
Example, just to be clear. I make a PR updating the StatefulSet with some simple changes, and I update the Chart.yaml -> version field from 1.0.0 to 1.0.1 as this is a simple patch. Once merged, GitHub actions auto deploys and releases this new version (we could arguably also create a GitHub release for that, which references the issue/PR that made the change).
That way, when the PR is merged, we have a history of where something broke and exactly what happened to break it.
The linting from ct lint inherently supports this by default as well. As does the chart releaser.
If I'm misunderstood, disregard and let me know. I'll read again and give a better more coherent answer.

I agree with @DandyDeveloper and @mprimeaux. The Helm community and tooling is highly opinionated regarding development and release workflow:

Chart version is critically important and must follow SemVer. Chart versions are immutable and version bumps are required for any change. Major version bumps are required for breaking changes. Consumers of the chart rely on this to determine upgrade safety. Review of PRs should also consider if the version is bumped correctly.
appVersion is totally decoupled from chart version and simply indicates the default image tag.
imageTag is only there for end users to override the default appVersion of a chart, if necessary. It should not be populated in the default values.yaml.

The prometheus community repo is a good example of how the ct and cr tooling is supposed to work: https://github.com/prometheus-community/helm-charts
See in particular their contribution guidelines: https://github.com/prometheus-community/helm-charts/blob/main/CONTRIBUTING.md

@smlx @mprimeaux @DandyDeveloper I understand the view point of some of the community charts.
Also,
Chart version can be bumped but we should have a description of the Changelog we did. We should have a consensus on what changes we should bump. Also it should mention the underlying docker image powering it. Sometimes people think those versions as OpenSearch/Dashboards versions so a proper description will suffice the confusions.
@anuragsarkar97 opinions on this?

@TheAlgo I agree and recommend for consideration that we embrace the Keep A Change Log format, which, in a nutshell, covers:

Added for new features.
Changed for changes in existing functionality.
Deprecated for soon-to-be removed features.
Removed for now removed features.
Fixed for any bug fixes.
Security in case of vulnerabilities.

@peterzhuamazon @TheAlgo @smlx @DandyDeveloper If you are supportive, I will submit a PR tomorrow (US Central Time) to address this thread and issue. I appreciate your consideration.

In the meantime @TheAlgo has raised a #60 PR so that users wont get confused on issues with helm add.
They can still use the old package method to install.

@TheAlgo I agree and recommend for consideration that we embrace the Keep A Change Log format, which, in a nutshell, covers:

Added for new features.
Changed for changes in existing functionality.
Deprecated for soon-to-be removed features.
Removed for now removed features.
Fixed for any bug fixes.
Security in case of vulnerabilities.
This format also subscribes to Semver.
This is neat and clean @mprimeaux . I am fine with this.

Please ignore PR #62 as it was an inadvertent mistake on my part. PR #61 is ready for review. Thanks again for your help and support.

Hi @mprimeaux this page is now working but still could not add helm repo
https://opensearch-project.github.io/helm-charts/
Error: looks like "https://opensearch-project.github.io/helm-charts/" is not a valid chart repository or cannot be reached: failed to fetch https://opensearch-project.github.io/helm-charts/index.yaml : 404 Not Found

Seems like the yaml still not existing.
Thanks.

Thanks, @peterzhuamazon . I will review it now. Would you please confirm the gh-pages branch is not set to private access?

It works @mprimeaux:
$ helm repo add opensearch https://opensearch-project.github.io/helm-charts/
"opensearch" has been added to your repositories

$ helm repo update
Hang tight while we grab the latest from your chart repositories...
...Successfully got an update from the "opensearch" chart repository
...Successfully got an update from the "opensearch-mprimeaux" chart repository
Update Complete. ⎈ Happy Helming!⎈

$ helm repo list
NAME                	URL
opensearch-mprimeaux	https://mprimeaux.github.io/helm-charts/
opensearch          	https://opensearch-project.github.io/helm-charts/

Great news! I sincerely appreciate you and all of the maintainers diligence and help. Once you're comfortable then I will submit a PR with the new installation instructions.

Thanks everyone in the thread for help, especially @mprimeaux who put such efforts into getting it running.
I will close this issue soon as we can already install it.
However, I want to check out if there is any extra steps beside the installation instructions that we want to add?
Thanks.

However, I want to check out if there is any extra steps beside the installation instructions that we want to add?

I am not aware of any other steps in this repository other than to update the installation steps. I do see the OpenSearch docs also would need to be updated to reflect the new installation steps but believe this is outside the scope of this repo.
Will wait for @smlx @DandyDeveloper and @TheAlgo to review.

I will contact the doc team to make the changes on OpenSearch docs once we have installations steps ready in this repo, so they can update with the same process.
Thanks.

Thanks, @peterzhuamazon. In advance, I'll submit a PR for review and should any of the maintainers prefer additional changes then I'm happy to address in the PR. Again, thanks for your support and coordination.

@peterzhuamazon I did notice that CHANGELOG.md needs to reflect chart versions 1.0.3 so I'll add that to the PR for alignment.

@peterzhuamazon There are a few other observations:

The opensearch-dashboard chart does not have a README.md in its directory.
There is a README.md in the /charts directory but it looks fairly out of date or, at least, needs a bit of cleanup.

I'll address bullet 1 in the PR. However, it seems to me that we'd want to merge the contents of the README referring to in bullet 2 into the repository root README.md.  Thoughts on this?

@peterzhuamazon I did notice that CHANGELOG.md needs to reflect chart versions 1.0.3 so I'll add that to the PR for alignment.
Question is do we want to remove CHANGELOG.md from the root since we have CHANGELOGs for each chart in their respective folders? Less maintenance to remove the root one since the README already points to the respective folders.

If each chart folder has a corresponding changelog, I am in support of removing the root changelog.

@peterzhuamazon There are a few other observations:
1. The `opensearch-dashboard` chart does not have a `README.md` in its directory.

2. There is a `README.md` in the [/charts](https://github.com/opensearch-project/helm-charts/blob/main/charts/README.md) directory but it looks fairly out of date or, at least, needs a bit of cleanup.

I'll address bullet 1 in the PR. However, it seems to me that we'd want to merge the contents of the README referring to in bullet 2 into the repository root README.md. Thoughts on this?

I think @TheAlgo worked on the README of charts, needs his input on 2 here.

I think @TheAlgo worked on the README of charts, needs his input on 2 here.

Absolutely. The content of the README in the charts folder seemed more applicable to the opensearch chart and not the opensearch-dashboards charts so I 'took a chance' but expected a review. No worries at all.


Question about save of dense depth map

Hello, JiaxiongQ!
When I run test.py, I am a little bit confused about the save of dense depth image,  can u tell me what u consider about the save process. ( I always like to use cv2.imsave() to save pngs)

as we see, pred is dense depth map,
and * 256, get pred_show to minimize the error of saving?
and buffer from tobytes()&&T.shape is for what reasons and meanings.
can you tell us what happened in the save process.
Thanks for your reply!

This is a ordinary process for PIL to save 16-bit image. We tried the cv2.imsave() but only get 8-bit image.

in order to be more precise in depth map,  I think we can save as .npy format and use np.load&&np.save to avoid any loss in saving.

Good idea! But the KITTI benchmark requires to upload the ‘.png’  format image to evaluate.

Yes. For KITTI, .png file is fixed. But in my own dataset, I think I can use .npy to avoid loss. The only problem is .npy files are always 10x times bigger than .png files.


Switch to bump-my-version and update to 1.4.0-dev

Ref: This will cover some part of the issue in #776 until a new release.


How to cite keras in research paper?

In the future, we may release a paper for the purpose of citations, in the spirit of this one (which, incidentally, mentions Keras but does not cite it).
For now, we don't have a paper, so you can simply cite the Github repo. Here's an example.

For example:
@misc{chollet2015,
author = {François Chollet },
title = {keras},
year = {2015},
publisher = {GitHub},
journal = {GitHub repository},
howpublished = {\url{https://github.com/fchollet/keras}},
commit = {5bcac375530eda2650fff962073a29b07b3b1926}
}
commit will be changed though.

Updating this issue with a link back to the FAQ.
https://keras.io/getting-started/faq/
@misc{chollet2015keras,
  title={Keras},
  author={Chollet, Fran\c{c}ois and others},
  year={2015},
  publisher={GitHub},
  howpublished={\url{https://github.com/fchollet/keras}},
}

Always throws me how Keras is upper case. Way to break the trend!
Cheers

This BibTex is not working in my LaTex!

The citation on https://keras.io/getting-started/faq/ does not work on Endnote.
Please advise,

It worked on BibTex after I modified in https!
On Sat, 31 Mar 2018, 20:16 annanurov<EMAIL_ADDRESS>wrote:

The citation on https://keras.io/getting-started/faq/ does not work on
Endnote.
Please advise,
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/keras-team/keras/issues/247#issuecomment-377679107,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AiK86hA2rpiiTKLtGAscceT2KtbgxsEuks5tj0mCgaJpZM4FG5dO
.

Could you please post the modified version here?

I seen this : https://guides.github.com/activities/citable-code/
It seems to provide a DOI from a github repo


Rust-to-PlonK compiler

I think we should be able to compile any Rust code without dynamic jumps (i.e., completely unrolled) to a PlonK circuit that is much more efficient than running the computation in RISC-V assembly.
Consider, for example, the Keccak permutation: It consists largely of bitwise operations and shift operations. These map well to RISC-V instructions and we already have custom machines to accelerate them. However, we could save memory operations and compile this to a circuit with very few columns, compared to the RISC-V machine.
The transformation would be as follows:

There would be 3 witness columns (as in standard PlonK): Two inputs and one output for each gate.
Each (used) RISC-V instruction becomes a gate. Ideally, we could just re-use the instances of the Binary and Shift machines we already have in our RISC-V machine (#1200)
Any memory or move instructions can be removed. Instead, copy constraints are added to connect inputs and outputs. For example, if the program writes the result of a shift to address 0xf00 and later reads address 0xfoo to XOR it with some value, the output of the shift gate can be connected directly to the input of the XOR gate.

So, we'll end up with only 3 extra witness columns (and quite a few extra fixed columns + constraints), but we'll even use fewer rows than we would in the main machine.

The devil is probably in the detail. Just to mention a few:

We probably need an extra column with constants, and copy-constrain them to the right cells. For example, if an instruction is shr x12, 1, the 1 would be stored in a fixed column and copy-constrained to the right cell.
I think currently also allow additions (e.g. shr x12 + x13 + x14, x15). These would have to be split apart into separate gates. Not sure if that happens in practice though.
Probably, the memory addresses used in the program are dynamic, not sure how to deal with that.

I think this is doable. We would need to heavily analyze the assembly. Maybe the best approach would be to implement a symbolic riscv-executor that spits out the circuit representation. We could use a memory model where addresses need to be concrete but values can be symbolic. The executor would start out with some register and memory values being symbolic (the inputs) and others being concrete (i.e. stack pointer is concrete, initial memory values are zero etc). This way we can even run code that starts out by copying some constant data to memory.
This way, we could even deal with jumps and even conditional jumps and loops as long as they do not depend on our symbolic inputs.


README: Stress annotations on Pod template spec

A common error when using the sidecar injector is to set the configurable parameters on the top level annotations, perhaps on a Deployment. The configurable parameters must be set as annotation on the Pod template spec. This commit updates the README to stress this point.

Resolves #23


Update recovery-process.md

Why

Closes #[Issue Number]

Changes

Thank you for your contribution, @SanDeo-MSFT


Remove unused graphviz package

graphviz pkg is only used by Octant plugin which is already removed, so remove this package too.

I just realized that Antrea UI should still use this package, so close this PR.

@luolanzone Antrea UI doesn't use this package. Traceflow graphs are rendered client-side in Javascript, using the Traceflow CR. Feel free to re-open this PR.

Thanks @antoninbas I just re-opened the PR.

/test-all


Diff only

Build.Reason:Manual by Michael Jin
Build.Url:https://apidrop.visualstudio.com/Content CI/_build/results?buildId=318702&view=results

Docs Build status updates of commit 883ea78:
:x: Validation status: errors
Please follow instructions here which may help to resolve issue.

File
Status
Preview URL
Details

:x:Error

Details

[Error: CannotMergeCommit] Cannot merge commit 883ea78ed50331c2e2d38ef5507cc630218c77c1 in branch michael/pr-param-dup-2 of repository https://github.com/MicrosoftDocs/azure-docs-sdk-python into branch main (commit 71cec97854b4494dec878b8f52a6146d01a83407). Please follow this documentation: https://help.github.com/articles/resolving-a-merge-conflict-using-the-command-line/ to use git.exe to resolve you content conflicts locally and then push to remote.

For more details, please refer to the build report.
If you see build warnings/errors with permission issues, it might be due to single sign-on (SSO) enabled on Microsoft's GitHub organizations. Please follow instructions here to re-authorize your GitHub account to Docs Build.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
Note: Your PR may contain errors or warnings or suggestions unrelated to the files you changed. This happens when external dependencies like GitHub alias, Microsoft alias, cross repo links are updated. Please use these instructions to resolve them.
For any questions, please:Try searching the docs.microsoft.com contributor guidesPost your question in the Docs support channel


Config save problem

Hi. I have written cfg name then create but it has not been created juts pop-on and off? Thank you.

Please disable "Controlled Folder Access" in Windows Security. If that's not the case, check for any anti-virus software which protects the encryption of some common locations, eg. C:/Users/Documents, C:/Users/Pictures etc.
That was my issue and it's how I got it fixed.


Accepting projects for Hacktoberfest 2022 💯

Everyone can now participate in Hacktoberfest 2022 and contribute to this repository. 🥇
Pull requests are always welcome 👍
Make sure you add your codes in a structured way i.e by creating a folder-->file/files.
Happy Hacktoberfest 💯

Hey! Can you please assign this to me? I would like to add basic programs like swap two numbers etc under a Beginner-friendly programs folder

Hey! Can you please assign this to me? I would like to add basic programs like swap two numbers etc under a Beginner-friendly programs folder

Sure go for it 👍  , no need to assign individuals in this issue .
Everyone can create a separate issue and get assigned, Or else directly create a pull request.
All ideas and pull requests are welcomed 💯
Thanks


support specify admin password when deploy

What's it about?

What's the reason why we need it?

I believe this is an important feature for KubeClipper. There're a few use cases:

case one
case two
...

Please leave your comments below if there's anyone agrees with me. Or just give me a thumb up.
Area Suggestion

/kind feature-request

/assgin @Xvv-v

/close


Form reload in Enketo Express cuts off top of form

In the new Enketo Express on zebra.ona.io, if you submit a form, the page reloads to a blank form.  In this case, it cuts off the top of the form where it says "Offline-enabled forms....":

closing this, reopen if it will be recreated


perf: Clear all TestingServer and replace it with global registry center

What is the purpose of the change
Clear all TestingServer and replace it with global registry center
Brief changelog

Replace TestingServer with global registry center
Remove all dependencies of TestingServer in pom

Verifying this change

Checklist

[x] Make sure there is a GitHub_issue field for the change (usually before you start working on it). Trivial changes like typos do not require a GitHub issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
[x] Each commit in the pull request should have a meaningful subject line and body.
[x] Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
[x] Check if is necessary to patch to Dubbo 3 if you are work on Dubbo 2.7
[x] Write necessary unit-test to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add sample in dubbo samples project.
[ ] Add some description to dubbo-website project if you are requesting to add a feature.
[x] GitHub Actions works fine on your own branch.
[ ] If this contribution is large, please follow the Software Donation Guide.

Codecov Report

Merging #9231 (46a7c0b) into 3.0 (bfef39b) will decrease coverage by 0.01%.
The diff coverage is 100.00%.

@@             Coverage Diff              @@
##                3.0    #9231      +/-   ##
============================================
- Coverage     64.96%   64.94%   -0.02%
+ Complexity      328      327       -1
============================================
  Files          1206     1206
  Lines         51799    51766      -33
  Branches       7725     7692      -33
============================================
- Hits          33650    33622      -28
+ Misses        14515    14490      -25
- Partials       3634     3654      +20

Impacted Files
Coverage Δ

...k/AbstractRegistryCenterTestExecutionListener.java
80.00% <100.00%> (+2.72%)
:arrow_up:

...ache/dubbo/remoting/transport/AbstractChannel.java
75.00% <0.00%> (-12.50%)
:arrow_down:

...dubbo/common/status/support/LoadStatusChecker.java
50.00% <0.00%> (-11.54%)
:arrow_down:

...mmon/threadpool/support/fixed/FixedThreadPool.java
80.00% <0.00%> (-7.50%)
:arrow_down:

.../threadpool/support/limited/LimitedThreadPool.java
83.33% <0.00%> (-5.56%)
:arrow_down:

...ng/zookeeper/curator5/Curator5ZookeeperClient.java
61.35% <0.00%> (-5.32%)
:arrow_down:

...mmon/threadpool/support/AbortPolicyWithReport.java
78.94% <0.00%> (-5.27%)
:arrow_down:

...o/rpc/protocol/injvm/DefaultParamDeepCopyUtil.java
57.89% <0.00%> (-5.27%)
:arrow_down:

...pache/dubbo/remoting/transport/AbstractServer.java
57.14% <0.00%> (-4.29%)
:arrow_down:

...on/threadpool/support/cached/CachedThreadPool.java
85.71% <0.00%> (-4.29%)
:arrow_down:

... and 37 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bfef39b...46a7c0b. Read the comment docs.


fix(setup): disallow python 3.6 for pip install

SUMMARY
Disallow python 3.6 for pip install: https://packaging.python.org/guides/distributing-packages-using-setuptools/#python-requires
ADDITIONAL INFORMATION

[ ] Has associated issue:
[ ] Changes UI
[ ] Requires DB Migration.
[ ] Confirm DB Migration upgrade and downgrade tested.
[ ] Introduces new feature or API
[ ] Removes existing feature or API

Codecov Report

Merging #11825 (6450d3b) into master (bac84a3) will decrease coverage by 4.40%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master   #11825      +/-   ##
==========================================
- Coverage   67.56%   63.16%   -4.41%
==========================================
  Files         916      459     -457
  Lines       44545    28159   -16386
  Branches     4227        0    -4227
==========================================
- Hits        30098    17786   -12312
+ Misses      14344    10373    -3971
+ Partials      103        0     -103

Flag
Coverage Δ

cypress
?

javascript
?

python
63.16% <ø> (-0.94%)
:arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files
Coverage Δ

superset/db_engines/hive.py
0.00% <0.00%> (-85.72%)
:arrow_down:

superset/databases/commands/create.py
32.65% <0.00%> (-59.19%)
:arrow_down:

superset/db_engine_specs/hive.py
54.08% <0.00%> (-29.97%)
:arrow_down:

superset/views/database/mixins.py
59.64% <0.00%> (-22.81%)
:arrow_down:

superset/db_engine_specs/presto.py
69.76% <0.00%> (-12.53%)
:arrow_down:

superset/db_engine_specs/mysql.py
79.59% <0.00%> (-12.25%)
:arrow_down:

superset/databases/commands/update.py
85.71% <0.00%> (-8.17%)
:arrow_down:

superset/databases/dao.py
94.11% <0.00%> (-5.89%)
:arrow_down:

superset/databases/api.py
83.67% <0.00%> (-5.31%)
:arrow_down:

superset/views/database/validators.py
78.94% <0.00%> (-5.27%)
:arrow_down:

... and 476 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bac84a3...6450d3b. Read the comment docs.

Check line 25 too (Perhaps we can remove this?):
if sys.version_info < (3, 6):
    sys.exit("Sorry, Python < 3.6 is not supported")

Nice catch, updated


Feature: Include container uptime in API/UI

I think it would be nice to be able to access the uptime stats for a container through rancher.

We are adding usage data for containers in the near future.

With the release of Rancher 2.0, development on v1.6 is only limited to critical bug fixes and security patches.


Stdlib feature: counter for # of VASP child addresses

Needed to support proof of solvency + limit number of child accounts (https://github.com/libra/libra/issues/3949).

Thanks!


Infer returns wrong type in 4.2.*

Bug Report
With a particular type-setup, infer does not provide the correct type. When you open the playground link, you will see the type Opts and the types ExtractReq and ExtractOpt. Opts takes two type parameters, Required and Optional and ExtractReq and ExtractOpt will extract these two types using infer. However, the extracted types are, for the most part, incorrect.
🔎 Search Terms
infer, generic
🕗 Version & Regression Information
After updating TS to version 4.2.*. I have tried the nightly version and the problem did still arise.

This changed between versions 4.1.2 and 4.2.2

⏯ Playground Link
Playground link with relevant code
💻 Code

// Opts type:
type Opts<
    Required extends Record<string, unknown> | Never = Never,
    Optional extends Record<string, unknown> | Never = Never
> = Required & Partial<Optional>;

// extract types
type ExtractReq<T> = T extends Opts<infer Required, any> ? Required : never;
type ExtractOpt<T> = T extends Opts<any, infer Optional> ? Optional : never;

// shortand for Opts type with specific type parameters
type Opts3 = Opts<{ a: string }, { b: string }>;

// this type is Partial<{ a: string }> & Partial<{ b: string }> although { a: string } was expected.
type Req3 = ExtractReq<Opts3>;

// this type is Never | Record<string, unknown> although { b: string } was expected.
type Opt3 = ExtractOpt<Opts3>;

🙁 Actual behavior
The types that are inferred by ExtractReq and ExtractOpt are incorrect (see code above / playground link).
🙂 Expected behavior
The type { a: string } in the case of Req3 and { b: string } in the case of Opt3.

@RyanCavanaugh is there any other, more proper, way to "unmix" the types of a composed type as mentioned by OP.
E.g., from a type that is a Opts<T, Q>, obtain the particular T and Q.
I also had (important) code relying on this feature, and it stopped working after updating TS to 4.2.
It would be good to put a big red warning in TS documentation: https://www.typescriptlang.org/docs/handbook/release-notes/typescript-2-8.html#type-inference-in-conditional-types
AFAIK, this is a listed feature, not just a "happens to work" feature.


KYLIN-4539 Spark build failed due to com.codahale.metrics.json.Metric…

…sModule loaded from kylin job jar
Proposed changes
Describe the big picture of your changes here to communicate to the maintainers why we should accept this pull request. If it fixes a bug or resolves a feature request, be sure to link to that issue.
Types of changes
What types of changes does your code introduce to Kylin?
Put an x in the boxes that apply

[x] Bugfix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[ ] Documentation Update (if none of the other choices apply)

Checklist
Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.

[x] I have create an issue on Kylin's jira, and have described the bug/feature there in detail
[x] Commit messages in my PR start with the related jira ID, like "KYLIN-0000 Make Kylin project open-source"
[x] Compiling and unit tests pass locally with my changes
[ ] I have added tests that prove my fix is effective or that my feature works
[x] If this change need a document change, I will prepare another pr against the document branch
[x] Any dependent changes have been merged

Further comments
If this is a relatively large or complex change, kick off the discussion at user@kylin or dev@kylin by explaining why you chose the solution you did and what alternatives you considered, etc...

Codecov Report

Merging #1237 into master will increase coverage by 0.00%.
The diff coverage is n/a.

@@            Coverage Diff            @@
##             master    #1237   +/-   ##
=========================================
  Coverage     25.91%   25.92%
+ Complexity     6597     6596    -1
=========================================
  Files          1475     1475
  Lines         90168    90168
  Branches      12580    12580
=========================================
+ Hits          23369    23373    +4
+ Misses        64527    64522    -5
- Partials       2272     2273    +1

Impacted Files
Coverage Δ
Complexity Δ

...org/apache/kylin/rest/util/QueryRequestLimits.java
35.71% <0.00%> (-4.77%)
5.00% <0.00%> (-1.00%)

...he/kylin/job/impl/threadpool/DefaultScheduler.java
76.74% <0.00%> (+2.32%)
12.00% <0.00%> (ø%)

...g/apache/kylin/metrics/lib/impl/MetricsSystem.java
68.33% <0.00%> (+6.66%)
17.00% <0.00%> (ø%)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 52edac1...cf289c9. Read the comment docs.

Pull Request Test Coverage Report for Build 5954

0 of 0   changed or added relevant lines in 0 files are covered.
1 unchanged line in 1 file lost coverage.
Overall coverage increased (+0.006%) to 28.446%

Files with Coverage Reduction
New Missed Lines
%

server-base/src/main/java/org/apache/kylin/rest/util/QueryRequestLimits.java
1
47.62%

Totals

Change from base Build 5952:
0.006%

Covered Lines:
25649

Relevant Lines:
90168

💛  - Coveralls

Approved


Export Package + License-Details in a JSON-Format

Hi @wgnf,
What do you think about starting contributing with this enhancement issue?
if it's ok, could you please provide more details? such us:

the json will be provided through a web api or just on the console output
what are the target output information we are expecting
... etc.

Thanks :)

Hey Tarek,
Because this Tool (which will contain 3 tools: dotnet-CLI-Tool, Cake-AddIn (see https://cakebuild.net) and Nuke-AddIn (see https://nuke.build)) is meant for projects to extract and validate the licenses for the packages they're dependent on (preferably run in a CI/CD pipeline) this output as a JSON File would be one of the few ways to consume the information that are gathered by the tool.
So after the Pipeline (Project/Solution Input -> Extract Projects -> Extract Dependencies -> Extract Licenses) is done, this would output a JSON File (provided by the ExtractLicensesSettings and a CLI argument (I thought something like --output-json).
But the Pipeline is not completed yet and with that we/I don't know what information are meant to be exported for now.
With that being said, I don't think that's the best starting point for now, as this should be done later on, when the Pipeline is (nearly) finished.
I'd suggest you take a look at #5. Let me know what you think about that and hit me up when you need any help/direction

merged into release branch


[Scope change] Abort signal PCS queries

Description
Please include a summary of the change and which issue is fixed.
List any external dependencies that are required for this change.
Completes: AB#FILL_IN_YOUR_ISSUE_ID
Checklist:

[ ] I have performed a self-review of my own code.
[ ] I have linked my DevOps task using the AB# tag.
[ ] My code is easy to read, and comments are added where needed.
[ ] My code is covered by tests.

skal den være draft


New release with email assertion

Is it possible to do a new release with email assertion? We really need it!

A new release has been tagged as 1.5.0

Thank you!!!


Add function to create bins

Add function to create bins for overlapped transcripts.

Please remove dependencies to tibble and plyranges. Use data.frame instead. You can convert it into a GRanges as follows
with(df,GenomicRanges::GRanges(seq,IRanges::IRanges(start = start, end = end)))


allow beforeCreate to return a promise

In my scenario I need to make a get request to a remote api to fetch some extra data, this change allows user to return a Promise from beforeCreate callback in case some async work is needed. This may be my very specific case but maybe it can be used by others. Only difference is that beforeCreate must now return a value instead of just modifying data in newUser parameter.

thanks for the PR - I am slightly confused about your comment

Only difference is that beforeCreate must now return a value instead of just modifying data in newUser parameter.

does this mean that it is not backwards-compatible ? If so, that would break all existing apps that use this lib and we won't be able to merge it in.
We really would like to include this functionality, but it does need to not break any existing app out there already ;)
thanks again !

thanks!

That was quick, I was about to reply.
Yes it was breaking backwards compatibility but fix was rather easy to implement, I tested it in old scenario and with return value and promise.
I would like to add some tests to this project but before I do just wanted to check it's something you would merge and if so if mocha/chai/sinon are ok to be added as dev dependencies.

I would be extremely grateful if you would take the time to add some tests ! please ;) Thanks for the offer.


README: Write down some guidelines

These guidelines were adapted from https://github.com/rostedt/libccli.
For people like me who generally work in the Linux kernel, it's hard to
apply some practices common to other projects. This is not as strict as
rules to contribute to Linux kernel, but at least give a hint on how
to make it easier for the PR to be reviewed and applied.

Clear and concise, I like it. It's actually how I want contributions to my project to be. (Even though we sometimes have different thoughts on how small the steps should be.


wrong focus/context?

(this will be a bit fuzzy, but maybe it triggers an idea)
sometimes, when I try to populate inside a certain document, it jumps to another open document and asks me to select the layers i'd like to populate. If that happens, it's 100% reproducible.

that's a Sketch Runner issue.


could you please add new feature for password strength check?

show password is weak, so-so, stronger, very strong

@philipabc  See react-password-strength-bar.


can FormData be added

while using hypercore-fetch, i see that using formdata is not possible. it would be good to support FormData just like the bt-fetch pr and js-ipfs-fetch.

Finally getting around to this. ty for the patience. 😅

Added in 8.6.0 🎉


Client GUI is not closing after kicking out

When I kick out a user.  GUI of that user is not responding and not closing.
To Recreate it

use kick command to kick out a user
That user gets a notification of the kick out
Click ok

Then the GUI of that user is not responding.
Also, the 'ban' command is not working. It's showing Invalid command after entering

GUI Not Responding issue
It was caused by a thread working on the background, we finally able to fix it
Remember there is auto closing the application after the client got kicked out (you want to do it manually)
Ban Invalid issue
The Func was incomplete, that's the reason it showing invalid,
We will update u when it is fixed

GUI Not Responding issue
It was caused by a thread working on the background, we finally able to fix it
Remember there is auto closing the application after the client got kicked out (you want to do it manually)
Ban Invalid issue
The func was incomplete, that's the reason it showing invalid,
We will update u when it is fixed


It is not possible to assure the app is genuine

Because the source code is available it may be downloaded, modified, built and installed on a smartphone. The modifications may be done to perform several type of frauds. The main problem is that a person showing his green pass QR to a verifier is not able to distinguish a valid and genuine app by an altered app.
So, I think is mandatory to modify/enhance the app in a way to assure it is genuine and its code is not different from the official one.
Without this feature this sw is an open door to potentially access and save personal and private data of every italian citizen in violation of privacy and GDPR rules and a facilitation to commit other crimes and frauds.

Do you think it's possible to do this on an open source app like this?

I can demonstrate you that, even without the source code, everyone is able to modify and build a different version of this app.
 This is a basic concept of cybersecurity. I don't think that you have any cybersecurity skill.
GDPR is not violated in this app, as this app won't save the result. Can the GDPR be violated in other apps? Yes, however there is no way for the maintainer of this app to block others to violate the GDPR.
Everyone can read a QR code and save all data inside a QR code.
Also, a verifier MUST see your data to verify that the EU green pass is valid for your identity. How they are supposed to verify that the QR code that you're using is actually yours?
This issue is full of non-sense.


Property 'addImageDef' does not exist on type 'DxfWriter'

I'm using this package in a typescript project and i'm not able to use .addImageDef
I'm getting the error
Property 'addImageDef' does not exist on type 'DxfWriter'
Below is the screenshot - in the screenshot this.exporter is the DxfWriter

Hi,
If you are using the alpha version, the image entity still not implemented.
Its only supported in the v2
Regards

I'm using version ^2.8.9

Ok cool
You should call that method on the objects object like this:
this.exporter.document.objects.addImageDef("...")

The docs are messy sorry.
Regards


Updates regression detector instructions and a lading patch version bump

What does this PR do?
Updates the regression detector documentation and a small lading version bump.
Motivation
Keep docs up to date
Additional Notes
Possible Drawbacks / Trade-offs
Describe how to test/QA your changes
n/a

/merge

/merge


"such" in legalese: D? Determiner?

CGEL p. 1546 characterizes "such" as an adjective (even when a predeterminer). Footnote 54 notes legal register uses like "such term" meaning 'this term', but doesn't explicitly comment on the category or function. It seems to be filling the Determiner slot, so maybe Det:AdjP?

e.g. https://github.com/nert-nlp/legal-cgel/pull/34 "If the adverse party is a resident of the district within which the award was made, such service shall be made..."

I guess I thought it was a determinative 16 years ago:
https://simple.wiktionary.org/wiki/Talk:such

I guess AdjPs cannot otherwise be determiners (p. 355), so it is reasonable to explain this by adding "such" to the determinative category.

agreed

Also: "said" as in "said term"

Also: "said" as in "said term"

I know @BrettRey has opinions on this. :)

Really seems like such is a D: PROVIDED, HOWEVER, That this article shall not be so construed as to forbid the employment by the state of a chaplain for such of the state custodial, correctional, and mental institutions, or by a county's or public hospital district's hospital, health care facility, or hospice, as in the discretion of the legislature may seem justified.

And, yes, said too.

@bwaldon suggested demonstrative substitution as a test for D:

such criterion/criteria => this criterion, these criteria => D
such is... => this is... => D
such a criterion => *this a criterion => Adj
the third such criterion => *the third this criterion => Adj

But there are cases where this is tricky:

one/no/any such criterion => *this such criterion
all such criteria => all these criteria (but "all these" is informal?)

If we find such criterion without any other plausible DP, then I think it has to be a D there. The other contexts seem less clear.


enhancement: add helmRepoURLRegex to git repo creation workflow

Setup

Rancher version: v2.7.2-rc7
Browser type & version: chrome

Describe the bug

the variable helmRepoURLRegex is now available for fleet via yaml, but is not surfaced in the UI options
To Reproduce

deploy a git repo using continuous delivery / fleet through rancher
Result
no option for helmRepoURLRegex is available in the UI
Expected Result

helmRepoURLRegex should be available in the UI
Screenshots

Additional context

https://github.com/rancher/fleet/issues/978

Duplicate of https://github.com/rancher/dashboard/issues/8584


Step 3 in Replace a certificate that has the same subject name

Is a } needed at the end of the script in step 3?

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 6602ac3d-0e6f-fe0f-d3f8-84c399c2bfb5
Version Independent ID: 4ad95f3a-2e01-6fff-39a4-7eefaaa104fa
Content: Troubleshooting server-based authentication for Dynamics 365 for Customer Engagement apps
Content Source: ce/admin/troubleshooting-server-based-authentication.md
Service: crm-online
GitHub Login: @Mattp123
Microsoft Alias: matp

@AndrewMaisey - Thank you for your feedback and help to improve the documentation. You request has been incorporated into the topic. Closing issue.


Running the demo app

Just pulled the master branch and tried to npm i. Many packages error during the install and I'm not sure if I'm doing something wrong. Are there any docs on running the demo-app?
Also will it ever be moved from gulp to the CLI? Thanks for your time on my question.

Please keep GitHub issues for bug reports / feature requests. Better avenues for troubleshooting / questions are stack overflow, gitter, mailing list, etc.
(this is a canned response)


Release Google.Cloud.DevTools.Common version 3.2.0-beta01

Changes in this release:
New features

Change netstandard2.1 target to netstandard2.0 (commit 82bea85)

This one was accidental.


Move to django-app-helper

Moving to experimental django-app-helper (rename of djangocms-helper)

Coverage remained the same at 95.747% when pulling 4aa232b3d80497af5539807c5642efbb39a1189c on feature/app-helper into c624e242d0e557692a8f1fd2be003a649a5ce0ae on develop.


Problem running counterfit Ubuntu

Hi,
Until today I was able to install and run counterfit on my VM Ubuntu 20.04 with python3.8.10.
Today after a successful counterfit installation (pip install CounterFit) when I try to run it I get the following error:
ubuntu@ubunu2004:$ counterfit
Traceback (most recent call last):
File "/home/ubuntu/.local/bin/counterfit", line 5, in
from CounterFit.counterfit import main
File "/home/ubuntu/.local/lib/python3.8/site-packages/CounterFit/counterfit.py", line 9, in
from eventlet import event
File "/home/ubuntu/.local/lib/python3.8/site-packages/eventlet/init.py", line 17, in
from eventlet import convenience
File "/home/ubuntu/.local/lib/python3.8/site-packages/eventlet/convenience.py", line 7, in
from eventlet.green import socket
File "/home/ubuntu/.local/lib/python3.8/site-packages/eventlet/green/socket.py", line 21, in
from eventlet.support import greendns
File "/home/ubuntu/.local/lib/python3.8/site-packages/eventlet/support/greendns.py", line 66, in
setattr(dns, pkg, import_patched('dns.' + pkg))
File "/home/ubuntu/.local/lib/python3.8/site-packages/eventlet/support/greendns.py", line 61, in import_patched
return patcher.import_patched(module_name, **modules)
File "/home/ubuntu/.local/lib/python3.8/site-packages/eventlet/patcher.py", line 132, in import_patched
return inject(
File "/home/ubuntu/.local/lib/python3.8/site-packages/eventlet/patcher.py", line 109, in inject
module = import(module_name, {}, {}, module_name.split('.')[:-1])
File "/home/ubuntu/.local/lib/python3.8/site-packages/dns/zone.py", line 86, in
class Zone(dns.transaction.TransactionManager):
File "/home/ubuntu/.local/lib/python3.8/site-packages/dns/zone.py", line 757, in Zone
) -> dns.rdtypes.ANY.SOA.SOA:
AttributeError: module 'dns.rdtypes' has no attribute 'ANY'
ubuntu@ubunu2004:$
Can I get some help solving this issue?
Thanks.

@jcaldeira1977 - I found a temporary solution, it has to do with the package dnspython.
Run pip install dnspython==2.2.1
This should fix the issue.
Ref - https://stackoverflow.com/questions/75137717/eventlet-dns-python-attribute-error-module-dns-rdtypes-has-no-attribute-any

@vipulrai91 I managed to solve the problem with the same solution you propose.
Glad you managed it too, I forgot to post it when I found it.