Plain output: render confidence

Follow-on to #18: we render the severity, but not the confidence currently. Need to figure out a way to shoehorn the latter into annotate_snippets's data model.

Hey @woodruffw ! I was exploring how we could achieve something around this, how about using Message::footer?
I gave a small try on it, and I've managed to get something like

$> cargo run -- tests/test-data/artipacked.yml

🌈 completed artipacked.yml
warning[artipacked]: credential persistence through GitHub Actions artifacts
  --> tests/test-data/artipacked.yml:13:9
   |
13 |       - uses: actions/checkout@v4
   |         ------------------------- does not set persist-credentials: false
   |
   = note: audit confidence → Low

We can customize what we have in the footer message, including colors and etc (no strong opinion here).

We can customize what we have in the footer message, including colors and etc (no strong opinion here).

Nice, that looks great! Thanks for looking into it; send a PR and I'll do a full review 🙂

Closing for now; we can iterate on the display in a follow-up.


Anonymous types response model support

Hello,
Is there support to show the anonymous types response model? In my controller I am returning these anonymous to avoid the exposure of certain properties and the creation of DTO's, exemple:
var result = from r in rooms
select new
{
roomId = r.Id,
roomCapacity = r.Capacity,
roomPrice = r.Price
};
return Ok(new { availabilities = result });
So, must I always return typed objects to have the documentation?
Thank you.

Take a look at SwaggerResponse, that might be what you need:
https://github.com/heldersepu/SwashbuckleTest/blob/master/Swagger_Test/Controllers/IHttpActionResultController.cs#L24

That's my problem, I don't have a typed object as return. I am always returning anonymous and SwaggerResponse requires a typed object.
The thing is, I received a requirement where I must to return the same object with different property names. Instead of creating another class (DTO), I just returned an anonymous one with the required properties but this doesn't help. So imagine that you have the following class into your project:
public class Home { public int Id, public int Name }
And you receive a requirement that you must return Home objects with the following properties:
{ homeId: "", homeFullName: ""}.
I dont want to change my properties or create a DTO to answer specifically to this requirement. I would like to be able to create a response type model showing this "new type" return.

You can create spaghetti code or proper code the choice is yours.

Exactly, so that's why I am asking:  Is this scenario supported or no?

Think about what you are asking.
Let's try with an analogy:
How can we document the name of something that can't have a name?

I want to be able to show a response exemple without a type. There is no naming involved:
Response Class (Status 200)
OK
Model Example Value
[
{
"homeId": 0,
"homeFullName": 0,
}
]

You can hardcode the example with an IDocumentFilter. that allows you to modify the resulting json document to. But that is a bad idea as you will need to maintain code on two different locations

I know this is an horrible idea, but don't worry, I am working on something dead. Thank you, I will give it a try.

@Bemjamin  good job! I had same problem now, is there any progress?

You can hardcode the example with an IDocumentFilter. that allows you to modify the resulting json document to.
But that is a bad idea as you will need to maintain code on two different locations

I'm thinking of doing the following myself. But if you still think it's a bad approach, I would like to know from you.
I'm thinking I could iterate over the anonymous objects and group together any identical ones.
[ProducesResponseType(new{Text = "", Id=0}, 200)]
Then in the IDocumentFilter map anonymous objects to documentation?
public class AnonDescriptionsDocumentFilter : IDocumentFilter
{
    public void Apply(SwaggerDocument swaggerDoc, DocumentFilterContext context)
    {
        // Add logic to give matching anonymous classes some global documentation
        // var anon1 = new{Text = "", Id=0};
        // var anon2 = new{Text = "", Id=0};
        // if ( anon1 ~= annon2) {
        //     assign anon documentation for this anon object.
        // }
        // Else have a global anonymous names with hash id of some kid. So developers are aware of
        // everything potentially returned by their application
    }
}

Any Progress ?

Seems like no progress?
I totally get you @Bemjamin and don't understand why @heldersepu sees this a spagetticode or bad practice.
The reason I want anonymous types as the result of my REST API, is that it's much harder for me or others to break.
If we have "DTO" class, which I guess most have, the problem is that that class is indirectly a part of your API interface. Remember, the consumer of the API is getting JSON - not a class. They might map it to a matching class on their end, but they don't get a class/object with a class name returned.
So, the way you can easially break your API if you are not very careful is when you want to rename properties on your "dto" class. This can happen with anonymous types too, but you are rigth there in the API method once you do the rename, so there should be a bell ringing :)
Renaming a property of a DTO, might not be that obvious, as the dto might be in a different file, different library or maybe it's in the controller itself (which is at least better as it's closer).
Then you rename a property on your dto, by VS magic and bam! "Name" is now "Firstname". You don't see a problem, because your test, if you have that, might rely on the same dto, so that knows the renaming too...expect when you deploy it, all your consumers, that only see the actually JSON, not have a broken API, as they dont have the expected "Name" property.
I know, there are other ways and multiple ways to avoid this - however - what I'm trying to get at is that there is a valid argument for returning anonymous types in a REST API :)
However, I am here because this is still not supported as I can see, so have to fo it some other way :)

The Reflection API cannot go into a method's body. ( https://stackoverflow.com/questions/2693881/can-i-use-reflection-to-inspect-the-code-in-a-method )
So, when the code is return new{a=1,b=2}, Reflection API cannot get the structure of the anonymous type.
What is able to do this is Roslyn API. Analyzers (e.g. FxCop) use RoslynAPI, and VisualStudio refactor
functions also use RoslynAPI.
Fortunately VisualStudio provides a way to convert anonymous type to class. Just press CTRL+. (or right-click and choose the first item) and follow the instructions, vs will generate a class for you.
If your anonymous type is nested, like new{a=1,b=new{c=2}}, you shold first convert the inner type to a class, then the outter class.
Is you want to add some properites in the future, you can modify the generated class. The converting function of VS is just like a scaffold function.
By the way, I think explicit type is good, its act as a document. If you are using https://github.com/OpenAPITools/openapi-generator to generate front end client code, the front end developers can benifit a lot from it. Also the back end developer will spend less time communicating with the front end developer.

putting
[ProducesResponseType(typeof(object),StatusCodes.Status200OK)]
works for me


 primitive not loading hexmap JSON assets

<a-hexgrid/> does not work with any of the following:
          src="#hexmap"
          src="url(#hexmap)"
          src="hexmap.json"
          src="url(hexmap.json)"

See Reproduction
In fact, a hexgrid only appears when no src is set (src=""), assuming it's to a default mesh value.
When a src is set, the error below is thrown:
TypeError: this.addMesh is not a function[Learn More] aframe-extras.min.js:1:288442
I'm currently using aframe 0.7.1 and aframe-extras 3.13.1, but I haven't had luck with previous versions, either, or at least haven't found a working combination.
See comments in the Thimble index.html for more notes.

This has been fixed on the master branch, any of the things you tried above should work. The branch isn't quite stable yet, so YMMV switching over before next release.

Right on. I'll give it a go in the morning. Thanks for the speedy response, Don.


Feature Request: Support for GitHub Enterprise

Our university uses GitHub Enterprise (https://github.uiowa.edu/) rather than github.com.  I'd like to be able to connect my repos on GitHub Enterprise to my OSF account, but currently OSF doesn't support GitHub Enterprise.  I would like to add that as a feature request.  Thanks!

Sorry for the delay here, @isaactpetersen! Others have requested an integration with GitHub Enterprise, as well, and I'll add your request to our internal tracker. If/when this becomes available in the future, we'll let you know!


Added verification of checksum using checksum flag, Fixes #3

We can now use the checksum flag in the following manner
cargo run LICENSE checksum eb3d7b5485466acbd81f2b496f595ab637d2792e268206b27d99e793bdb6754
It will either produce matches or doesn't match
there are no -- before the checksum flag
Fixes #3

Good job, here's your points

!bounty 20


chore(deps): upgrade dependencies

Upgrades project dependencies. See details in workflow run.

Automatically created by projen via the "upgrade-main" workflow

Codecov Report

Merging #225 (93189d7) into main (2974dfe) will increase coverage by 8.43%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main     #225      +/-   ##
==========================================
+ Coverage   83.33%   91.76%   +8.43%
==========================================
  Files           2        1       -1
  Lines         126      340     +214
  Branches       31       31
==========================================
+ Hits          105      312     +207
- Misses         21       28       +7

Impacted Files
Coverage Δ

src/index.ts
91.76% <100.00%> (+9.76%)
:arrow_up:

example/src/main.ts

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7055f71...93189d7. Read the comment docs.


Crash fixing.

Crash fixing.

When we run the app in first time, the array is empty.
PathAbsoluteFromApp(pmru->pszItems[i],wchItem,COUNTOF(wchItem),TRUE);
Will crush.
void PathAbsoluteFromApp(LPWSTR lpszSrc,...) {
...
if (StrCmpNI(lpszSrc,..) == 0) {
...
}
else
lstrcpyn(wchPath,lpszSrc,COUNTOF(wchPath));
Here lpszSrc can not be null.

First time to run app. The registry is empty. The app will crash.

Have tested with version: Notepad2-mod.<IP_ADDRESS>5
Both x64 and x86.
I have tried to reproduce by running the exe file with and without the initial ini file present but am unable to make it crash.
Have also looked at the code. No obvious execution path that leads to calling MRU_AddFile.
Can you please describe the steps to make it crash.

Drag and drop a file to the editor, this moment it try to add the file path to the MRU. If the MRU array is empty. The app will crush.

I did drag and drop a txt file when I tried to reproduce the crash. It didn't crash.
To be sure I retried again. Both ways starting without the initial ini file present.
Way 1:
start notepad2-mod
Settings->Save settings now
Settings->Remember recent files
Drag and dropped from explorer a txt file.
No crash.
Way 2:
start notepad2-mod
Drag and dropped from explorer a txt file.
No crash.
More details are needed.
What operating system are you running?
If you are willing, able to and have time perhaps a video recording of it will help.
Myself is running Windows 7 ultimate x64.

Please look the following image.
https://pbs.twimg.com/media/CxMoWmLUAAAbsNz.jpg:large

I've stepped through the code both in debug and release using Visual Studio 2010 with platform toolset v100. It doesn't crash but it really should! In lstrcpyn when it should crash it just jumps out of the function and continues as if nothing have happened.
https://postimg.org/image/f6y5pxaan/
First I thought you might be running a debug version of Windows or it's the newer Visual Studio or the lstrcpyn behaves differently internally.
I didn't manage to get it to crash on its own but I did make it to admit something were wrong.
By default Visual Studio 2010 settings, Menu, Debug->Exceptions... are set to ignore such exceptions and pass is it to the software, anyway somehow Notepad2-mod is just ignoring the exception and potentially leaving itself in a corrupt state.
https://postimg.org/image/zd1not5y7/
By any chance do you compile your own version or do you use the official one already compiled? Might explain why it crash for you and not me.
You're correct there needs to be a NULL check but shouldn't it be first? Like so:
  for (i = 0; i < pmru->iSize; i++) {
+	if (pmru->pszItems[i] == NULL) {
+		break;
+	} else
	if (lstrcmpi(pmru->pszItems[i],pszFile) == 0) {

Apologize, I got really confused with that it didn't crash or popup an exception dialog for me on it's own. Had to free up some hd space (took time), use visual studio, rebuild to get pdb file and use vs2010 to catch the exception.
@XhmikosR , you know notepad2-mod better than me. Do you have any idea of why it doesn't behave as it should?
This code also needs some serious TLC. Perhaps a rewrite to catch all the issues like for example this one. More or less luck that it runs.
A bit off topic: Would be nice if you made the pdb file available for download for each new release. Would be convenient.

Yes. Because the project file is VS 2012, I can't convert it to my VS 2015 format. So I create a new project file from scratch. And I run it under debug mode, so I meeting with the crush.

I see no reason one would still use VS 2012. If the crash doesn't happen with 2015 this is obsolete.


Scope Capture Receipt as an API product

Reason
The Capture Receipt is currently used as a library that enables the App Receipt to capture data from scanning physical receipts, scraping email accounts and connecting online retailer accounts.
Now we want to transform this library in a standalone product that makes it possible not only the capturing of the data but its licensing and publishing. It will simplify our internal usage, moving the business logic out of the apps layer, and will allow other organizations to use with their users.
Description
Create the documentation and the API definitions for Capture Receipt.
Features:

Get data from physical and digital receipts with Microblink
Handle data licensing and payables with TIKI
Publish data to TIKI

Success criteria

[x] API documentation
[ ] Stories to implement

Android initial docs and setup
https://github.com/tiki/capture-receipt-ios/tree/6f2846652a134a9df0ecffec28ae95f63808e447
iOS initial docs and setup
https://github.com/tiki/capture-receipt-ios/tree/6f2846652a134a9df0ecffec28ae95f63808e447

Config

This should just take in a string for the legal terms. There is no UI (other than the scan camera) so the agreement templating needs to happen before calling the capture sdk.

Don't we need to add an optional google id for supporting oauth?

Receipts

We should rename the receipts endpoint to scrape for naming consistency with scan since scan also returns receipts.

Config

This should just take in a string for the legal terms. There is no UI (other than the scan camera) so the agreement templating needs to happen before calling the capture sdk.
👍

Don't we need to add an optional google id for supporting oauth?
There is optional config for that
Android: https://github.com/tiki/capture-receipt-android/blob/main/README.md#initialize-gmail-andor-outlook-apis:
iOS: https://github.com/tiki/capture-receipt-ios/tree/6f2846652a134a9df0ecffec28ae95f63808e447

Receipts

We should rename the receipts endpoint to scrape for naming consistency with scan since scan also returns receipts.
Yes, I am stuck on ideas with that... Microblink uses digital/ereceipt. I thing that digital is good, but I am not very excited with it...

Config

This should just take in a string for the legal terms. There is no UI (other than the scan camera) so the agreement templating needs to happen before calling the capture sdk.

👍

Don't we need to add an optional google id for supporting oauth?

There is optional config for that Android: https://github.com/tiki/capture-receipt-android/blob/main/README.md#initialize-gmail-andor-outlook-apis: iOS: https://github.com/tiki/capture-receipt-ios/tree/6f2846652a134a9df0ecffec28ae95f63808e447

Receipts

We should rename the receipts endpoint to scrape for naming consistency with scan since scan also returns receipts.

Yes, I am stuck on ideas with that... Microblink uses digital/ereceipt. I thing that digital is good, but I am not very excited with it...

Just use either read or scrape since that's what it actually is.

Android specs
tiki/capture-receipt-android/issues/1
tiki/capture-receipt-android/issues/2
tiki/capture-receipt-android/issues/3
tiki/capture-receipt-android/issues/4
tiki/capture-receipt-android/issues/5
tiki/capture-receipt-android/issues/6
tiki/capture-receipt-android/issues/7
tiki/capture-receipt-android/issues/8


fix : mediator add to alias should not store duplicated alias

ATL-5002

Makes sense to me. But I am concerned about what is the mediator replying to the user when this happens. (there are zero changes on DB) We use that number sometimes or at least I intended but I need to check the code.

Currently, the reply is the message is success, We can discuss tommorow

okay that looks awesome thanks


Can't get courier via sbt

[warn]  ::::::::::::::::::::::::::::::::::::::::::::::
[warn]  ::          UNRESOLVED DEPENDENCIES         ::
[warn]  ::::::::::::::::::::::::::::::::::::::::::::::
[warn]  :: ch.lightshed#courier_2.12;0.1.4: not found
[warn]  ::::::::::::::::::::::::::::::::::::::::::::::
[warn]
[warn]  Note: Unresolved dependencies path:
[warn]          ch.lightshed:courier_2.12:0.1.4
...
[trace] Stack trace suppressed: run last :update for the full output.
[error] (:update) sbt.ResolveException: unresolved dependency: ch.lightshed#cou
rier_2.12;0.1.4: not found
build.sbt:
resolvers += "lightshed-maven" at "http://dl.bintray.com/content/lightshed/maven"
libraryDependencies += "ch.lightshed" %% "courier" % "0.1.4"

Hi @vangogh500,
How you resolve this issue?


Volines ignore magma cream held

Describe the Bug
The wiki seems to imply volines will ignore you if you hold a magma cream, this does not currently work
Reproduction Steps

Hold a magma cream
Walk next to a voline
proceed to be ankle bitten

Expected Result
Ankles to be left in tact
Screenshots and Videos
No response
Operating System
I use Arch, btw
Mod Version
2.5.1
Minecraft Version
1.18.2
Forge Version
40.1.73
Other Mods
No response
Additional Context
No response

So that's actually a mistake on the wiki. That was never meant to be a mechanic, but the person who wrote the wiki thought it was. Sorry about the confusion!


Log application_name everywhere

For frontend and meta, the application_name should be the value in the session.
For batch and streaming task, the application_name should be the snapshot value when the query is created.
For storage part, we can discuss later.
Will add detail design later :)

Just FYI, we can put some fields in a tracing span and enter it, so all logs will be able to embed them in the final message. :)


run-unit-test-docker.sh: Enable SSH support

There is a need to clone repository via SSH.
When I run script with EXTRA_DOCKER_RUN_ARGS="-v /home/user/.gitconfig:/home/user/.gitconfig -v /home/user/.ssh:/home/user/.ssh",
I have this error message:
/bin/sh: 1: exec: socat: not found
Connection closed by UNKNOWN port 65535
fatal: Could not read from remote repository.

Can I add some EXTRA_DOCKER_RUN_ARGS to install socat?

Can I add some EXTRA_DOCKER_RUN_ARGS to install socat?

We can add socat to the container directly if it is necessary for running git-over-ssh?  But ... what is socat being used for in this context?  I don't have socat installed on my development box and use git-over-ssh all the time.
I do see some code in build-setup.sh that is leveraging socat for HTTP proxying, but that's slightly surprising to me because git also has the http.proxy config option.

Hi @williamspatrick,
Thank you for your quick response. We are using socat in the SSH configuration according to our company guide.
Could you please add socat to the container?

@ewalkusx Is this something you can contribute (via Gerrit). It sounds like you have more context on what the utility of this is.
https://github.com/openbmc/openbmc-build-scripts/blob/88dd792924df8d1173404f83ecda7ccf6fa6af38/scripts/build-unit-test-docker#L825


crash on cloudflare_ruleset import with empty serve_stale

Confirmation

[X] This is a bug with an existing resource and is not a feature request or enhancement. Feature requests should be submitted with Cloudflare Support or your account team.
[X] I have searched the issue tracker and my issue isn't already found.
[X] I have replicated my issue using the latest version of the provider and it is still present.

Terraform and Cloudflare provider version
Terraform v1.7.5
on darwin_arm64

provider registry.terraform.io/cloudflare/cloudflare v4.37.0
provider registry.terraform.io/hashicorp/aws v5.43.0
provider registry.terraform.io/hashicorp/http v3.4.3

Affected resource(s)
cloudflare_ruleset
Terraform configuration files
import {
  to = cloudflare_ruleset.http_request_cache_settings
  id = "zone/${cloudflare_zone.<redacted>.id}/2a26e884f96549fe9f93d500447e823d"
}

resource "cloudflare_ruleset" "http_request_cache_settings" {
  kind    = "zone"
  name    = "http_request_cache_settings"
  phase   = "http_request_cache_settings"
  zone_id = cloudflare_zone.<redacted>.id
  rules {
    action = "set_cache_settings"
    action_parameters {
      cache = true
      edge_ttl {
        mode = "bypass_by_default"
      }
      browser_ttl {
        mode = "respect_origin"
      }
      serve_stale {
        disable_stale_while_updating = false
      }
    }
    description = "<redacted>"
    enabled     = true
    expression  = "(starts_with(http.request.uri, \"/v1/<redacted>\"))"
  }
}

Link to debug output
see below
Panic output
panic: runtime error: invalid memory address or nil pointer dereference
[signal SIGSEGV: segmentation violation code=0x2 addr=0x0 pc=0x1038af5fc]

goroutine 46 [running]:
github.com/cloudflare/terraform-provider-cloudflare/internal/framework/service/rulesets.toRulesetResourceModel({0x1049cce68, 0x14000e3da40}, {0x40?, {0x14000c81ec0?, 0x14000c81ea0?}}, {0x20?, {0x0?, 0x0?}}, {{0x14000bc501b, 0x20}, ...})
	github.com/cloudflare/terraform-provider-cloudflare/internal/framework/service/rulesets/resource.go:624 +0x305c
github.com/cloudflare/terraform-provider-cloudflare/internal/framework/service/rulesets.(*RulesetResource).Read(0x14000c84610, {0x1049cce68, 0x14000e3da40}, {{{{0x1049d4208, 0x14000e7eb40}, {0x1043ed4a0, 0x14000e7db60}}, {0x1049d7838, 0x14000d98230}}, 0x14000c84620, ...}, ...)
	github.com/cloudflare/terraform-provider-cloudflare/internal/framework/service/rulesets/resource.go:209 +0x3e4
github.com/hashicorp/terraform-plugin-framework/internal/fwserver.(*Server).ReadResource(0x140005f0000, {0x1049cce68, 0x14000e3da40}, 0x14000e3dad0, 0x14000d7b608)
	github.com/hashicorp/terraform-plugin-framework@v1.10.0/internal/fwserver/server_readresource.go:117 +0x698
github.com/hashicorp/terraform-plugin-framework/internal/proto6server.(*Server).ReadResource(0x140005f0000, {0x1049cce68?, 0x14000e3d920?}, 0x14000e103c0)
	github.com/hashicorp/terraform-plugin-framework@v1.10.0/internal/proto6server/server_readresource.go:55 +0x314
github.com/hashicorp/terraform-plugin-mux/tf6muxserver.(*muxServer).ReadResource(0x1049ccea0?, {0x1049cce68?, 0x14000e3d620?}, 0x14000e103c0)
	github.com/hashicorp/terraform-plugin-mux@v0.16.0/tf6muxserver/mux_server_ReadResource.go:35 +0x184
github.com/hashicorp/terraform-plugin-go/tfprotov6/tf6server.(*server).ReadResource(0x14000ba0320, {0x1049cce68?, 0x14000e3ce10?}, 0x140005cd8f0)
	github.com/hashicorp/terraform-plugin-go@v0.23.0/tfprotov6/tf6server/server.go:784 +0x224
github.com/hashicorp/terraform-plugin-go/tfprotov6/internal/tfplugin6._Provider_ReadResource_Handler({0x1048d3760?, 0x14000ba0320}, {0x1049cce68, 0x14000e3ce10}, 0x14000e0ae80, 0x0)
	github.com/hashicorp/terraform-plugin-go@v0.23.0/tfprotov6/internal/tfplugin6/tfplugin6_grpc.pb.go:482 +0x164
google.golang.org/grpc.(*Server).processUnaryRPC(0x14000c04200, {0x1049cce68, 0x14000e3cd80}, {0x1049d5220, 0x14000a58300}, 0x14000e3b200, 0x14000934de0, 0x1057f3ae8, 0x0)
	google.golang.org/grpc@v1.63.2/server.go:1369 +0xba0
google.golang.org/grpc.(*Server).handleStream(0x14000c04200, {0x1049d5220, 0x14000a58300}, 0x14000e3b200)
	google.golang.org/grpc@v1.63.2/server.go:1780 +0xc80
google.golang.org/grpc.(*Server).serveStreams.func2.1()
	google.golang.org/grpc@v1.63.2/server.go:1019 +0x8c
created by google.golang.org/grpc.(*Server).serveStreams.func2 in goroutine 52
	google.golang.org/grpc@v1.63.2/server.go:1030 +0x150

Expected output
resource import and diff
Actual output
crash
Steps to reproduce
create a cache rule in the ui and select "Add setting"
This will expand the rule like this:

In the API, this causes the following response:
    "action_parameters": {
      "cache": true,
      "edge_ttl": {
        "mode": "bypass_by_default"
      },
      "browser_ttl": {
        "mode": "respect_origin"
      },
      "serve_stale": {}
    }

Note the empty serve_stale map.
When looking at the panic, it crashes while it's trying to read DisableStaleWhileUpdating / disable_stale_while_updating
https://github.com/cloudflare/terraform-provider-cloudflare/blob/master/internal/framework/service/rulesets/resource.go#L624
Additional factoids
No response
References
No response

Alternatively someone needs to address this to CF.
After removing the flag and having it set through terraform, the api reports it as follow:
      "serve_stale": {
        "disable_stale_while_updating": false
      }

This is now also parseable by the provider and doesn't panic anymore.

Can confirm this issue, adding disable_stale_while_updating section via UI without enabling it crashes terraform provider

you'll need to provide the full debug log; not your snipped version of it.


Thoughts on building esm at python packaging time

What are your thoughts on a pattern like this?
In the future, when I care about bundle sizes of my widget, I would prefer not to ship sucrase in the bundled JS.  My _esm cproperties are very small, essentially shims between my component library and ipyreact.  What would it look like if there was no sucrase shipped with js bundle.  (I'm not worried about the time it takes to execute sucrase, this should be minimal.
What if the _esm blocks were hashed and compiled in a step.  Then there was a shipped dictionary from _esm_hash to compiled js.  The frontend code references this dictionary in production mode, and the 1mb sucrase dependency doesn't ship.
This is a pretty advanced optimization that I don't think I'll get to for a while, if ever.  but curious on your thoughts

As I think about it, I'm trying to figure out if I will need to fork ipyreact to suit my needs.  I'd prefer not to.  I'm just thinking about plans for my roadmap.
Here are the things I'd like to do which would require js changes to ipyreact

Easier CSS importing.  Nice to have.  I figured a widget side workaround.  related to this bug
Importing custom css #39
Passing custom messages back and forth to the kernel.  Is custom message passing possible? #70
This bug. building esm at python packaging time #71 - the least important of the core changes I'd like


Restore suggestedOptionComponent argument.

This PR fixes a regression (Issue #121) that I assume happened when upgrading to glimmer components.  This adds back the ability to pass in the suggestedOptionComponent argument.

Hey @cibernox, can we please merge this change? 😊

Sorry I missed this. Merged and released in 0.9.1.
Thanks!


Fix typo

PR checklist

[ ] Addresses an existing issue: #0000
[x] New feature, bugfix, or enhancement

[ ] Includes tests

[ ] Documentation update

Overview of change:
Is there anything you'd like reviewers to focus on?

CHANGELOG.md entry:

Thanks for your interest in palantir/tslint, @liuxh0! Before we can accept your pull request, you need to sign our contributor license agreement - just visit https://cla.palantir.com/ and follow the instructions. Once you sign, I'll automatically update this pull request.

Thanks @liuxh0!


AJ-1451: More pacts with workspacemanager

AJ-1451
Add additional contract coverage to WsmPactTest to cover interactions with workspacemanager.

@davidangb mind giving one more look at 31e70fb180ea462b07d088dd77c580e1594e12c1 ?


Create cnrg.txt

Colegiul Național Radu Greceanu, Slatina, Olt, România
cnrg.ro

@alinDum First stage of verification passed, official domain for Colegiul Național Radu Greceanu is cnrg.ro as far as I verified. This is just an informational note. Pull request is still in the review. I appreciate your patience while waiting for the final decision.

@alinDum First stage of verification passed, official domain for Colegiul Național Radu Greceanu is cnrg.ro as far as I verified. This is just an informational note. Pull request is still in the review. I appreciate your patience while waiting for the final decision.

Thanks a lot Philip!
Waiting for your feedback!

@alinDum Thank you for your patience while waiting for a review and processing your request. Pull request merged.


Environment Variable on External Service Alias

External Service Alias (and internal alias too) is a nice way to externalise and consolidate your backend references. The problem is that each backend service usually has its own specific settings, e.g. bearer token, access-key, port numbers, etc that the linking service needs to know about.
Typically when you link to a (docker) service, you could define those settings as environment variables of the linked service, to be consumed by the linking service.
However, I can't seem to find a way to define environment variables to a linked external service. Definitely not from the UI. When I tried defining it using docker-compose.yml, even thought the environment variables do get created within the agent-instance container, these variables aren't getting transported across to the linking service.
Any possibility to support environment variables in (external and internal) service aliases?

When you are referring to "external service alias", what exactly are you referring to?
Are you referring to external services or service aliases?
Are you trying to link to a docker container that is hosted outside of Rancher and have environment variables passed to that container?

I was referring to both. But let's have a look at the use case for external services specifically first.
What I need is the opposite of what you were describing. I need to pass certain metadata information from the external services onto the consuming containers. In the docker world, this is normally achieved by environment variables.
Example:
Imagine I have a docker-compose where ServiceA has a link pointing to ServiceB. (ServiceA and ServiceB are managed by 2 different teams). On the ServiceB, I have an env called "bearer-token", and this env becomes visible to ServiceA. This is a way for ServiceA to know what bearer-token to use when communicating with ServiceB. This way, you have a decoupling between ServiceA and ServiceB, where the bearer token can differ for every environment, but regardless of which ServiceB that ServiceA is pointing to, it always gets the correct bearer-token without needing any reconfiguration.
This seems to be a common integration pattern I've seen used in the docker world.
In rancher, when I try to link to an external-service, I noticed that I could not define any env variable on external-services, and was wondering whether there's any specific reason for this.

Is this concept actually possible in docker-compose? Can you really have a service A that reads environment variables from serviceB?

When you link to a container in Docker you automatically get all is environment variables to (which is a terrible idea because they're used for passwords and secrets alk the time, but it is what it is).

@deniseschannon Yes this is the current behavior of docker-compose, i.e. when you link A to B, the env of A gets imported to B (with a specific prefix).
Rancher-compose also does that, although for some reason it changes the prefix format, which breaks many third-party docker-based components that are making use of this feature. But I suppose that's a separate issue.

This functionality would be great to have. I was thinking of using an external service in rancher as a way to inject environment specific ENV variables into any container that links to it. unfortunately this is not currently possible since the environment variables of external service do no get injected into the containers they link to. Any update on if this will be added?

With the release of Rancher 2.0, development on v1.6 is only limited to critical bug fixes and security patches.


[WIP] Series plot accessor

As mentioned in #293 , this PR creates Series.plot functions for plotting data in Koalas.Series.
The idea is to use pandas.plotting._core as base for inheritance as well to copy some functions/methods from and then adjust them to compute the necessary summarized data using Spark.

@dvgodoy thanks for the first PR! I know this is WIP, but can you describe (either in code or just as comments here) the summary algorithm you use to the type of plots? I think eventually we should document those in code as part of the docstring, but it'd be great to discuss them here too.

@rxin Sure, I've added comments on the code, but I can outline them here as well.
I am currently focusing on 3 plots: bar, hist and box - scatter should be on DataFrame, not Series, my mistake when listing it on the issue.
The idea is to create Koalas specific classes that inherit from pandas plotting originals BarPlot, HistPlot and BoxPlot. A lot can be accomplished implementing the method _compute_plot_data, and it turns out it is the only change needed for the BarPlot. HistPlot demand some changes to other methods as well (_plot and _args_adjust), while BoxPlot demands a whole lot of copying and adapting functions from pandas plotting.
Regarding the summarizing algorithms:

BarPlot: it just limits the number of values to 1k and converts it into pandas to use default plotting capabilities - it was thought to be typically used in combination with value_counts() like
kdf.x.value_counts().plot.bar()
At first, I thought of performing value_counts inside the method, as it would make sense for assessing distributions of categorical variables, but it would break compatibility with pandas functionality.

HistPlot: Spark methods are invoked at two different moments
2.1) bins: if user provides number of bins, instead of the actual bins, the method will compute min and max values of the corresponding column and split the interval into equally spaced bins.
2.2) histogram: it creates a Bucketizer with the computed (or informed) bins, transforms the dataframe and groups by the newly created column to get the corresponding counts. Then it transforms into a pandas DF (as there are only as many rows as bins). After getting the number of counts, it is possible to use ax.hist with those counts as weights, thus generating the histogram.

BoxPlot: this plot requires a lot more of data handling to be built
3.1) statistics (median, Q1, Q3): it uses approx_percentile SQL function to compute those statistics with a default precision of 0.01 (100) to make it fast - it is possible to use precision as a kwarg to fine-tune it. These statistics allow for the computation of Tukey's fences and the corresponding fliers / outliers.
3.2) Using Tukey's fences, it creates a column to flag rows as fliers / outliers.
3.3) For the non-outliers, computes min and max values - these are the whiskers.
3.4) If showfliers, it sorts outliers in descending order by the their absolute values and limits it to 1k points - plotting more than that would be pointless. The purpose of sorting is to make sure the most extreme values are plot, should we run into a case of having more than 1k points.

One question: any preferred way to handle testing for plots?
In the past, I've handled this by converting the figures to base64 and then comparing them, generated and expected - it worked fine for Histogram and Bar plots, as both Spark and pandas produced exactly the same numbers.
It was a bit trickier for the boxplot, given the approximate statistics... in these cases, I just compared pixel by pixel and assessed the differences, comparing to those I knew to be derived from the approximation.

@dvgodoy do you know how pandas test plots? base64 probably works but it'd be somewhat difficult to inspect if anything goes wrong.

Also cc @falaki who's been our in-house plotting experts (although more on the R side).

@dvgodoy I also just went through your algorithms. They make intuitive sense to me. I'm going to talk with couple more people tomorrow to get their thoughts as well.
For bar plots -- if a DataFrame has more than 1000 values, can we show some text in the generated plot saying we only take the first 1000 values? That'd be a useful message to get. We can also do that without computation overhead by just taking the first 1001 values, and if it is greater than 1000, we know we have more than 1000 values.

@dvgodoy I talked with @falaki today and one thing he suggested was to make it more explicit in code that there are two parts to visualization: (1) the summarization step, which is unique to big data, and (2) the visualization part, which is almost identical to pandas.
We can then write unit tests specifically for summarization, and just have limited integration tests verifying the pixels like you stated with base64 encoding.

@rxin Thanks for the suggestions. I've made changes in that direction already.

added a message "showing top 1,000 elements only" when we do get 1001 values returned
split Spark and plotting code into two different classes for both Hist and Box plots (Bar plot is so straightforward there was no need for it)
I checked pandas testing, it uses ax.get_lines() and then get_xydata() for each line it draws to compare plots - I like this better than my initial base64 idea, and I will follow this when implementing tests

Cool. I know this is still WIP, but I tested the three plots. Two questions:

bar failed. Is this expected?
Why is "frequency" for hist 1000?

BTW - depending on how complex the PR gets, we might ask you to split it into three separate PRs so we can review and merge faster.

It is a problem indeed, I need to fix it.
Frequency is 1,000 because the default for bins is 10, so the points were evenly split in 10 bars of 1,000 each.
I am working on the developing the tests now, so hopefully it will be ok soon.

@rxin I've fixed the bar plot, added tests and documentation - so, it is possible to plot values for a single column (no groupby supported yet). The next step (in another PR) is to add support to groupby and, after that, go for dataframes and multiple columns.
I've been struggling with the Travis build, though. At first I made some mistakes with the docstrings, cause the example was incomplete. Then I fixed it, but I kept getting failing builds, regardless of several attempts to figure what is going on.
For some reason, it just crashes after databricks/koalas/tests/test_dataframe_conversion.py::DataFrameConversionTest::test_csv - next test would be to_clipboard.
And, of course, in my local setup, it works. Do you have any idea of what I am doing wrong?

@dvgodoy can you try the suggestion above?

Also, can you solve the merging conflicts?

@thunterdb Thanks, I will do it!
What I find puzzling is that I use Travis with my HandySpark and even though I do not set the backend as you suggested there, I never had these problems. That's why I would never think about this as an issue here.

@thunterdb I've tried your suggestion but Travis is still crashing at the same point - right after databricks/koalas/tests/test_dataframe_conversion.py::DataFrameConversionTest::test_csv.
It never gets to output the result of test_to_clipboard.

Codecov Report

Merging #294 into master will decrease coverage by 1.29%.
The diff coverage is 78.89%.

@@            Coverage Diff            @@
##           master     #294     +/-   ##
=========================================
- Coverage   94.66%   93.37%   -1.3%
=========================================
  Files          42       44      +2
  Lines        4615     5011    +396
=========================================
+ Hits         4369     4679    +310
- Misses        246      332     +86

Impacted Files
Coverage Δ

databricks/koalas/missing/series.py
100% <ø> (ø)
:arrow_up:

databricks/koalas/tests/test_series_plot.py
100% <100%> (ø)

databricks/koalas/plot.py
71.32% <71.32%> (ø)

databricks/koalas/series.py
92.44% <75%> (-0.42%)
:arrow_down:

databricks/koalas/tests/test_indexes.py
94.33% <0%> (-1.89%)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e5d7bd8...9f0e291. Read the comment docs.

@thunterdb I've finally passed all checks! :-)
The build was crashing (without a message) due to this QXcbConnection: Could not connect to display :0.0.
It turns out, setting the backend was not enough, as the functions that copied to the clipboard were triggering the error, whenever Matplotlib was imported (even if there was NO code using MPL at all!).
I was able to fix this including - export QT_QPA_PLATFORM="offscreen" at the before_script section of travis' yaml file.
This PR should be good to go now, could you please review it?

@dvgodoy my apologies for the delay, glad to hear that you found a solution.
I am a bit constrained in time the next weeks. @HyukjinKwon can you assist in the review?

Also, @dvgodoy , would you mind resolving the conflicts?
I think that this PR adds enough functionality that we do not need further features for now. Additional plots can happen separately.

Hi @thunterdb @HyukjinKwon
I've solved the conflicts and the checks passed :-)
I agree this is too big already, so we can leave other plots/groupby to a different PR.

I’m going to merge this. We can improve the functionality and add new features as follow-up PRs.
Thanks @dvgodoy!

This is nice!


Added exploit protection setting requirements.

Added a few requirements for system-wide Exploit Protection/Process Mitigation settings which affect Windows Defender Application Guard, per issue #4798.

@e0i : I presume you will be assigning this PR to the appropriate MS Docs team member.
@JohanFreelancer9 : Are you available for copy review, in case I overlooked something?


update slack links to K8s slack

Ref: https://github.com/openebs/openebs/issues/3053
Updating the slack sign-up page to slack.k8s.io and also added a direct link to OpenEBS channel.

Fixed by https://github.com/openebs/website/pull/36


Possible to trigger auto-center without touch the rect ?

I'm editing an image and apply a ratio on the image created like this :

When the user is validating the crop on saved button clicked without moving the rect I'm getting this :

I would like to force the auto-center when the user is validating without moving the rect.
Is it possible to do this ?
Thanks is advance

sorry, i didn't get it

sorry for delay reply, there is no way to do this for now


Creating a new node sometimes places it at a random location

Discord username
No response
What type of issue is this?
Intermittent – Ocurring irregularly
Is this issue blocking you from using Enso?

[ ] Yes, I can't use Enso because of this issue.

Is this a regression?

[ ] Yes, previous version of Enso did not have this issue.

What issue are you facing?
Most of the time creating a new node, by creating a new tab, places it at a location where the current mouse pointer is. Except... when it doesn't. See screenshot.
It's not clear what governs the rules for that and forces the user to move around the new node.
Expected behaviour
Should always create the new node under the mouse pointer.
How we can reproduce it?
No response
Screenshots or screencasts
Position 1. Where the mouse pointer was.
Position 2. Where the node was created and the mouse pointer was moved.

Enso Version
develop
Browser or standalone distribution
Chrome
Browser Version or standalone distribution
110.0.5481.100
Operating System
Linux
Operating System Version
No response
Hardware you are using
No response

This is known issue, but I can't find it. Our border weights in auto-placing algorithmm are too big, or the auto-placing has bugs.

@hubertp could you post your project, or screenshot without Component Browser?

The project seem to be changed since the screenshot was taken, and I cannot reproduce it the same way.

As we no longer auto move nodes, think all fixed.


upgrade zookeeper jar in examples to match secure version in main pom

Fixes #3267
// Describe your PR here; eg. Fixes #issueNo

Make sure that:

[X] You have read the contribution guidelines.
[ ] You submit test cases (unit or integration tests) that back your changes.
[ ] Your local test passed mvn clean install -Dmaven.javadoc.skip=true.

Codecov Report

Merging #3268 (5c9cde9) into master (993f86a) will decrease coverage by 0.16%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##             master    #3268      +/-   ##
============================================
- Coverage     58.43%   58.26%   -0.17%
+ Complexity     4646     4640       -6
============================================
  Files           744      744
  Lines         21047    21047
  Branches       1925     1925
============================================
- Hits          12298    12264      -34
- Misses         7662     7688      +26
- Partials       1087     1095       +8

Impacted Files
Coverage Δ

...ache/shenyu/plugin/grpc/cache/GrpcClientCache.java
87.50% <0.00%> (-12.50%)
:arrow_down:

...a/org/apache/shenyu/common/utils/VersionUtils.java
67.85% <0.00%> (-10.72%)
:arrow_down:

...yu/plugin/logging/utils/LogCollectConfigUtils.java
66.66% <0.00%> (-8.89%)
:arrow_down:

...henyu/plugin/grpc/resolver/ShenyuNameResolver.java
54.25% <0.00%> (-8.52%)
:arrow_down:

...gin/logging/rocketmq/RocketMQLogCollectClient.java
68.00% <0.00%> (-8.00%)
:arrow_down:

...che/shenyu/sync/data/http/HttpSyncDataService.java
78.04% <0.00%> (-5.70%)
:arrow_down:

...rg/apache/shenyu/plugin/rewrite/RewritePlugin.java
50.00% <0.00%> (-5.56%)
:arrow_down:

...in/response/strategy/NettyClientMessageWriter.java
69.56% <0.00%> (-4.35%)
:arrow_down:

...he/shenyu/plugin/grpc/client/ShenyuGrpcClient.java
8.00% <0.00%> (-4.00%)
:arrow_down:

...henyu/admin/service/impl/UpstreamCheckService.java
70.14% <0.00%> (-1.50%)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 993f86a...5c9cde9. Read the comment docs.


Replace deprecated django.conf.urls.url() with path() and re_path()

django.urls.path() and re_path() have been available since Django 2.0.
django.conf.urls.url() is deprecated in Django 3.1. When testing against
Django 3.1, fixes warning of the form:
RemovedInDjango40Warning: django.conf.urls.url() is deprecated in
favor of django.urls.re_path().

Thanks!


dead link to mets example in user guide

The user_guide links to an 404 https://ocr-d.de/en/example_mets.md as example mets.xml

The example here is https://github.com/OCR-D/assets/blob/master/data/SBB0000F29300010000/data/mets.xml But I am not  even sure whether that is a good example anymore, maybe this would be a good moment to replace it. @EEngl52 @bertsky Any proposals for "the archetypical OCR-D METS file"?

what about this one? https://digital.staatsbibliothek-berlin.de/werkansicht?PPN=PPN895878739&PHYSID=PHYS_0005&view=overview-info


Change quickstart/BUILD files to use top-level build targets

See https://github.com/googleapis/google-cloud-cpp/pull/3702
We want the google/cloud/*/quickstart/BUILD files to reference the bazel build targets that are defined in the top-level BUILD file. However, they cannot do this until that top-level BUILD file is included in a release.

I have moved this to the post-monorepo cleanups, it is distracting in the current milestone and not actionable.

SGTM. For future us, this is only waiting for any new release of -cpp. So anytime after the May release this could be done.


AVX2 for ppv-lite86

Will require new implementations of all the vector traits; impl-sharing with SSE2 versions would add more complexity that it's worth.

Also see #17.

Right, status update: implemented for u32x4x4 in #17; the rest of the trait matrix uses the SSE2 code for now (but compiles to vex-encoded versions, aka "AVX128")


Question: best way to implement verbose errors on custom authenticate handler

So, I was wondering how I can create errors in the same manner as the built-in way -
for example, when I try to POST to a route and don't pass validation, i get a response like this:
{
  "jsonapi": {
    "version": "1.0"
  },
  "meta": {
    "copyright": "Blah"
  },
  "links": {
    "self": "http://localhost:16006/rest/comments/"
  },
  "errors": [
    {
      "status": "403",
      "code": "EFORBIDDEN",
      "title": "Param validation failed",
      "detail": {
        "name": "ValidationError",
        "details": [
          {
            "message": "\"title\" must be a string",
            "path": "title",
            "type": "string.base",
            "context": {
              "value": 2,
              "key": "title"
            }
          }
        ],
        "_object": {
          "id": "cfdccd45-6395-4b44-b540-41b45b4f3746",
          "type": "comments",
          "title": 2,
          "body": "whatever!!!?"
        }
      }
    }
  ]
}

but when I try to make my custom authenticate route respond like thus:
var currentClientSecret = process.env.CB_CLIENT_SECRET;
jsonApi.authenticate(function(request, callback) {
// console.log(request.headers.authorization);
var authorization = _.get(request, 'headers.authorization', '');
var isBearerToken = authorization.indexOf('Bearer ') > -1;
if(isBearerToken){
var token = authorization.slice(7);
console.log(token);
    try {
      var decoded = jwt.verify(token, new Buffer(currentClientSecret, 'base64'));
      console.log(decoded);
      callback();
    } catch (e) {
      console.log(e);
      callback(e);
    }
  } else {
    var badFormat = new Error('')
    var otherData = {
      status: 401,
      code: 'ENOAUTH',
      title:'Authorization header not in correct format. should be \'Bearer {{token}}\''
    }
    _.assign(badFormat, otherData);
    callback(badFormat);
  }

});

so when I try to test it by submitting a request without the authorization header, I don't get back a verbose response, I get back just a blank 401, no body. is there a way to tap into the nice pattern from above? or should I be implementing authentication differently?

looks like I just should just use the server and client - sorry for the spam!


Stop inspecting configurations, keys are enough

Previously, if the ActiveRecord::AdapterNotSpecified exception was raised, the whole configurations object would be inspected - including information like shard sets and credentials for accessing the mysql cluster.
This PR fixes the above by only inspecting the keys inside the configurations hash.
@bquorning @pschambacher please review

cc @v4lproik this fixes the issue from happening to other applications that use this gem.


cpptools extension load slowly

Env

VSCode Version: 1.20.0
OS Version: windows 7
extension installed: ms-vscode.cpptools 0.14.6

My Case
I open a c++ project and press F5 to debug. But after pressing F5,  it needs to wait 20 seconds to start debug process. So i check the startup performance and find the ms-vscode.cpptools use 20s to activate. I don't know whether it is normal.
Startup Performance Measurement :
OS: win32 (6.1.7601)
CPUs: Intel(R) Xeon(R) CPU E5-2680 v4 @ 2.40GHz (4 x 2394)
Memory (System): 3.99GB (0.97GB free)
Memory (Process): 199.38MB working set (199.45MB peak, 183.18MB private, 42.98MB shared)
VM (likelyhood): 0%
Initial Startup: false
Screen Reader Active: false
Empty Workspace: false

(index)
Topic
Took (ms)

0
"[renderer] window.loadUrl() => begin to require(workbench.main.js)"
423

1
"[renderer] require(workbench.main.js)"
707

2
"[renderer] create extension host => extensions onReady()"
565

3
"[renderer] restore viewlet"
46

4
"[renderer] restore editor view state"
0

5
"[renderer] overall workbench load"
196

6
"------------------------------------------------------"

7
"[main, renderer] start => extensions ready"
1726

8
"[main, renderer] start => workbench ready"
1350

(index)
startup
codeLoadingTime
activateCallTime
activateResolvedTime
activationEvent

vscode.emmet
true
147
6
0
"*"

vscode.git
true
186
24
0
"*"

vscode.merge-conflict
true
26
4
0
"*"

ms-vscode.cpptools
true
240
26
21300
"*"

Steps to Reproduce:

install ms-vscode.cpptools 0.14.6
open a cpp file
execute task "startup performance" to check the cpptools plugin activation stats

This sounds more like a cpp extension issue.
As I can see, you already opened an issue in their repository.
Please reopen this issue, if it should turn out to be VS Code specific.


chore: add back button to AddTokenScreen

[x] issue #104
[x] follows contribution guide
[x] code change includes tests
[ ] breaking change

@trbutler4 I've resolved conflicts


netty session lost when two client connected with the same clientid

Hi guys,
There is something wrong when two client mistakenly connected with the same id.
broker attempt to force close the previous session if a newcomer has the same client id.
but, the later session maybe inconrrectly removed by processConnectionLost()  event of previous session, for this may be happened after the newcomer's processConnect() event.
In this case, the previous mqtt client is fully disconnected, but the broker lost the handler of newcomer's  netty session

Have you give a look at issue #108?
Have tried with latest sources? If yes could you provide the logs at DEBUG level?
Andrea

Yes，it's the same problem，but the fix doesn‘t work。
Sorry i lost the log，the event sequence is processConnect() of client Y finished in thread A，and then processConnectionLost() of client X happened in thread B。
In this situation，evt.sessionStolen of client X is true, and m_clientIDs.remove(clientID) != null remove the session of client Y.
I fix this bug by:

moving subscriptions.deactivate(msg.getClientID()) from processConnectionLost() into processConnect()
delete m_clientIDs.remove(clientID) != null in processConnectionLost() for it's already replaced by m_clientIDs.put(msg.getClientID(), connDescr) in processConnect()

BTW: i am a freshman of github, when i try to submit my changes, i got a error of "git-receive-pack not permitted"，is this because of i doesn't have permission to submit to this project，or something wrong with my git？

This is identical case of issue #116


Only remove folder in sentencepiece check if it was created

Hi there,
as promised, here is the PR!
Fixes #1119.
Reviewer: @danielhanchen.
Best,
Giulia

Thanks again!


Create file at General/DBMS.md

Instructions:
Open folder General
Inside that folder make a file General/DBMS.md
Write content for it

Hey @Iliveinbianries
I am eager to make a contribution to this, and I respectfully request that you assign me this issue.

Hello @Iliveinbianries I would like to work on this issue can you please assign it to me

I would like to contribute as well. Pls assign thanks

Hello, @Iliveinbianries ,
I would like to kindly remind you that I made the initial request for this issue. Therefore, I respectfully request that you assign it to me.
Thank you for your consideration.

Nothing to worry @rishirajm007 :) just allowing new contributors to collaborate as well, will soon be opening more issues to work on, you having experience with this repo are always welcome to open up more of more issues and work on them independently. Therefore I would suggest you to open more issues and work on them, learn more here : https://youtu.be/Ht7ml2fpF4M
Have a great day! :)

Thank you for your understanding and the opportunity to contribute further, @Iliveinbianries. I appreciate your guidance and will certainly consider opening up more issues and working on them independently. I look forward to continued collaboration. Have a wonderful day! :)

Pls review this PR @Iliveinbianries


Remove Delete button from a Form

I assume that its done in the MyTableDialog.cs, and Ive tried the method listed in the tutorial for removing buttons from the grid:
protected override List<ToolButton> GetButtons()
        {
            var buttons = base.GetButtons();
            buttons.RemoveAt(0);
            return buttons;
        }

On the Dialog.cs page, but it seems to be having a problem with the GetButtons()
Figured it out, GetToolbarButtons()

if u want to remove all buttons u can do like that;
protected override List GetToolbarButtons()
{
var buttons = new List();
return buttons ;
}
But i suppose u just try to remove "delete" buttons. then ur methot is runing with me may be it needs rebuild .
protected override List GetToolbarButtons()
{
var buttons = base.GetToolbarButtons();
buttons.RemoveAt(2);
return buttons ;
}


Allow manual forced update of field information

example:
value, err := db.Model("user").Fields("passport").Where("id=3").Value()
......
if _, err := db.Exec(ctx, "ALTER TABLE user ADD COLUMN newField1 varchar(50) NULL")        err != nil { 		gtest.Error(err) 	}
......
_, err := g.DB().TableFields(context.WithValue(ctx, "refresh_fields", true), "user")
    if err != nil {
	    return err
    }

@rzhghost CI failed.

Codecov Report

Merging #2113 (7110979) into master (c866b50) will decrease coverage by 0.08%.
The diff coverage is 68.35%.

@@            Coverage Diff             @@
##           master    #2113      +/-   ##
==========================================
- Coverage   76.47%   76.39%   -0.09%
==========================================
  Files         517      517
  Lines       46868    46930      +62
==========================================
+ Hits        35842    35851       +9
- Misses       9046     9094      +48
- Partials     1980     1985       +5

Flag
Coverage Δ

go-1.15-386
?

go-1.15-amd64
?

go-1.16-386
?

go-1.16-amd64
76.33% <66.34%> (-0.07%)
:arrow_down:

go-1.17-386
?

go-1.17-amd64
76.34% <68.35%> (-0.11%)
:arrow_down:

go-1.18-386
?

go-1.18-amd64
76.29% <66.34%> (-0.09%)
:arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files
Coverage Δ

contrib/drivers/pgsql/pgsql.go
60.42% <61.53%> (-1.48%)
:arrow_down:

contrib/drivers/mssql/mssql.go
82.85% <63.41%> (-3.05%)
:arrow_down:

contrib/drivers/sqlite/sqlite.go
73.98% <67.56%> (-3.79%)
:arrow_down:

contrib/drivers/clickhouse/clickhouse.go
68.38% <68.75%> (-1.85%)
:arrow_down:

contrib/drivers/mysql/mysql.go
62.12% <70.00%> (-4.00%)
:arrow_down:

contrib/drivers/oracle/oracle.go
83.33% <81.25%> (-0.93%)
:arrow_down:

os/gfsnotify/gfsnotify_watcher_loop.go
78.15% <0.00%> (-5.05%)
:arrow_down:

encoding/gcompress/gcompress_gzip.go
49.49% <0.00%> (-1.03%)
:arrow_down:

... and 5 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

fixed

@rzhghost Thanks for PR, but it is duplicated with https://github.com/gogf/gf/pull/2128

@gqcn  It is better to specify a table name to clear the cache to avoid frequent execution of "SHOW FULL COLUMNS"


Optimize Wallet Connect - Support Camera for WC

Version test: https://file.cdmteck.com/s/4oimk9zDJ8R5Aai/download?path=%2F&files=./upgrade-ui-pr-1613-build-1.1.1-2023-07-06T12-49-23UTC.zip
Validation passed.


Show toast message when a student is added

@Bam92 I believe this is already a part of #119

It does not work. Have you tried it with students ("apprenants") ?

I see why it was not working. The redirection was being made before the toast message. Now fixed


Decouple electron, electron-builder and electron-packager versions from this package

Suggestion: allow users to override the version of electron, electron-builder and electron-packager in their ./desktop/settings.json.

Hey,
I've been thinking about this, but not sure yet how to do this properly. I mean not sure whats the correct approach in this situation.
I can strip those from meteor-desktop dependencies and when meteor-desktop is run check if they are already added to the project (so it would respect the already installed ones). If not meteor-desktop would install the default ones adding them to package.json of the meteor project.
One thing is that I will always be supporting one major.minor version of electron, so probably I should display a warning if you are using an older or newer one. Also there should be a command that will update your deps to the latest supported ones.
Any thoughts on that?

@wojtkowiak I think for now a minimal implementation would suffice; relying on the current installed dependencies and only installing the default versions in the parent project whenever they are not installed yet.
I don't think the first implementation of this feature would require any notifications about unsupported versions. Simply listing the supported versions on the Readme would suffice, I think.

Has there been any more thought around this?
I've got a chrome issue that's introduced with newer versions of electron, but would still like to take advantage of other improvements in meteor-desktop

This should land soon on 2.0

@wojtkowiak I just tested this functionality creating a build of our application running on Electron 3.0.3 and it worked flawlessly.
Will be testing in the wild soon, but I'm not expecting significant difficulties.
I guess we can mark this complete!


Exposing metadata map

Exposing metadata map
My team and I are currently working on an internal framework for our company.
We are trying to create a solution for multi inheritance in javascript and we are almost there, the only problem we have left to solve is extending the metadata from typescript class properties without default values or assignments in the constructor.
In order to have access to those properties, I'm exposing the MetadataMap. This will make it possible to iterate over the properties and use that metadata without knowing the actual property name.
Example:
class {
    @Reflect.metadata('metadataKey', {value: 'value'})
    property: string;
}

I don't plan to take this PR, as I'm concerned that exposing the underlying metadata map directly could cause problems in the future as I make under-the-hood changes to eventually support interop with the Stage 3 Decorator Metadata proposal.


Update Oracle documentation

This PR updates OCI instructions to install required dependencies with and without Docker (using OS package manager).

Merging so we can publish a new version.


Add /onthisday command using ZenQuotes API

Command Name
/onthisday
Public API Resource
https://today.zenquotes.io/
Description
This command will return the history events happened on the same date in the past by fetching from the API.
Implementation Details

Add a new javascript file in the commands folder
Use axios fetch the data from your public API
Format the data in a readable way and send it to the user
Use the discord.js docs to get started

Code of Conduct

[X] I agree to follow this project's Code of Conduct

Can I take this one, please? Thanks!

Nice idea! @oktak Sure, go ahead.

@oktak Great contribution 🚀
I approved your pr #95 and labeled it with the hacktoberfest-accepted label.
Keep contributing ❤


Review docs

This needs rebasing, since I refactored the is_array interfaces

This was never rebased and thus cannot be merged.


can i make a custom Date Picker Control

You have said that you are going add the Date picker control but that's about 4 or 5 months later
so I was wondering what is taking so long please let me know.

There is a community DatePicker already: https://github.com/flet-dev/examples/tree/main/python/community/datepicker
and we are going to implement Flutter built-in DatePicker widget as well: https://github.com/flet-dev/flet/issues/86


[#30083][prism] Factor out hold tracking to dedicated structures

Refactor out hold tracking to dedicated structures, so the logic is not replicated everywhere. Document the purpose of watermark holds within that.
This is yet another change to make the processing time change easier to read. In particular, event time watermark hold management is critical for correct behavior when waiting for processing time triggers.

Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

[ ] Mention the appropriate issue in your description (for example: addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment fixes #<ISSUE NUMBER> instead.
[ ] Update CHANGES.md with noteworthy changes.
[ ] If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.
To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md
GitHub Actions Tests Status (on master branch)

See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.

R: @damondouglas

Thanks! PTAL


Add smoother scaling to album covers

By default, the only scaling mode that GtkImage supports is nearest-neigbour, which means that downscaled images have a pixelated look:

We can work around this by using GIcon to display the album cover images. With some smart tweaks, we might also be able to slightly reduce memory usage by only loading the GIcon once, then using it in all places.

The better solution here is to use GdkPixbuf.Pixbuf.new_from_file_at_scale to load the image.


[Bug]: after firmware update <IP_ADDRESS>h everything seems to be read-only

Version
1.6.2
Node version
18.17.0
Operating System type
Docker
Operating system version
Raspbian 11.7
Describe the bug
After HomeBase 2 was updated to firmware version <IP_ADDRESS>h it looks like everything is read-only from now.
I can set the guardMode that is being confirmed, but it doesn't switch the actual alarm mode.
I can issue a reboot command thats being confirmed but station doesn't reboot.
When I switch the guardMode with the app I can see alarm mode changes in the server. When I reboot the station from the app, I can see it rebooting.
To reproduce
Let the update be installed and try reboot.
Screenshots & Logfiles
Log from server with DEBUG=1 when issuing reboot command

2023-08-17 10:23:33.604  DEBUG [Station.rebootHUB] Sending reboot command to station T8010NXXXXXXXX
2023-08-17 10:23:33.608  DEBUG [P2PClientProtocol._sendCommand] Sending p2p command...
{
station: 'T8010NXXXXXXXX',
sequence: 5,
commandType: 1034,
channel: 255,
retries: 0,
messageStatesSize: 1
}
2023-08-17 10:23:33.628  DEBUG [P2PClientProtocol.handleMsg] Station T8010NXXXXXXXX - ACK DATA - received from host x.x.x.x:23072 for sequence 5
2023-08-17 10:23:33.640  DEBUG [P2PClientProtocol.handleMsg] Station T8010NXXXXXXXX - DATA DATA - received from host x.x.x.x:23072 - Processing sequence 5...
2023-08-17 10:23:33.642  DEBUG [P2PClientProtocol.parseDataMessage] Station T8010NXXXXXXXX - Received data
{
seqNo: 5,
header: {
commandId: 1034,
bytesToRead: 132,
channel: 255,
signCode: 0,
type: 1
},
bytesRead: 132,
bytesToRead: 132,
firstPartMessage: true,
messageSize: 148
}
2023-08-17 10:23:33.647  DEBUG [P2PClientProtocol.handleData] Station T8010NXXXXXXXX - Received data
{
commandIdName: 'CMD_HUB_REBOOT',
commandId: 1034,
resultCodeName: 'ERROR_PPCS_SUCCESSFUL',
resultCode: 0,
message: '\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00',
data: '000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000',
seqNumber: 6,
energySavingDeviceP2PDataSeqNumber: 0,
offsetDataSeqNumber: 0
}
2023-08-17 10:23:33.654  DEBUG [P2PClientProtocol.handleData] Station T8010NXXXXXXXX - Result data for command received
{
message: {
sequence: 5,
commandType: 1034,
nestedCommandType: undefined,
channel: 255,
acknowledged: true,
retries: 0,
returnCode: -133,
data: <Buffer d1 00 00 05 58 5a 59 48 0a 04 84 00 00 00 01 00 ff 00 00 00 00 00 00 00 38 31 66 34 35 31 37 39 62 30 39 31 38 36 66 39 30 61 61 39 35 30 37 38 63 39 ... 102 more bytes>,
customData: {
command: {
name: 'stationReboot'
}
}
},
resultCodeName: 'ERROR_PPCS_SUCCESSFUL',
resultCode: 0
}
2023-08-17 10:23:33.659  DEBUG [Station.onCommandResponse] Got p2p command response
{
station: 'T8010NXXXXXXXX',
commandType: 1034,
channel: 255,
returnCodeName: 'ERROR_PPCS_SUCCESSFUL',
returnCode: 0,
customData: {
command: {
name: 'stationReboot'
}
}
}
2023-08-17 10:23:33.667  DEBUG [P2PClientProtocol.handleMsg] Station T8010NXXXXXXXX - DATA DATA - Received expected sequence (expectedSeqNo: 6 seqNo: 5 queuedData.size: 0)
2023-08-17 10:23:33.671  DEBUG [P2PClientProtocol.handleMsg] Station T8010NXXXXXXXX - DATA DATA - received from host x.x.x.x:23072 - Processing sequence 5...
2023-08-17 10:23:33.673  DEBUG [P2PClientProtocol.handleMsg] Station T8010NXXXXXXXX - DATA DATA - Received already processed sequence (expectedSeqNo: 6 seqNo: 5 queuedData.size: 0)

Additional context
No response

just to mention, my homebase is Firmware: <IP_ADDRESS>h and everything is working as normal. So defently somethin changed with the new firmware

As @kvanbiesen points out, something has been changed with the latest firmware version and that is that P2P encryption has been made mandatory.
Until then, the firmware supported and accepted unencrypted P2P communication.
I had known for some time that some P2P commands are now sent encrypted, but as long as there was something else to implement and it was not mandatory to encrypt, I did not invest any time in it.
Now I have also partially implemented this part (see here).
In the next release, P2P communication will work again.

Fixed in version 1.6.3.

Wow .. don't know what happened but suddenly my rtsp cameras respond so much quicker, better than it ever was. Hope it lasts and eufy won't break it again.
Many thanks!


Blazor GetJsonAsync call returns html instead of json

I am using VS 2019 preview with all updates applied and all necessary Nuget previews installed.
In my Blazor app I have a number of API calls in pages (called index.razor) where the calls are similar to:-
sectors = await http.GetJsonAsync<ICBSector[]>("api/ICBSectors");
Instead of returning json they all return the index.html page from the 'wwwroot' and promptly cause a json exception for obvious reasons.
Error:-
WASM: System.Text.Json.JsonException: '<' is an invalid start of a value. Path: $ | LineNumber: 0 | BytePositionInLine: 0. ---> System.Text.Json.JsonReaderException: '<' is an invalid start of a value. LineNumber: 0 | BytePositionInLine: 0.
Any thoughts on possible causes and/or solutions?

Thanks for contacting us, @CliffConway.
Please share the server logs here.

Apologies for the late reply. I am executing this directly from VS. Where would the server logs be stored?

Are you referring to IIS logs or ?

You should see the logs in the Output windows of the VS.

Discovered my problem was related to using old class entities generated by non-core EF (the lazy option used to create my database table classes) . They were helping to generate extra column names in the EF Core Sql queries (due to artifacts related to foreign keys) that didn't exist. Now working ok. Thanks for your help with this.


Add asciidoc guide for using in Angular-CLI webpack applications

Note for reviewers: The Webpack Version of Angular-CLI is a pre-release. We should probably not publish the guide on vaadin.com/docs until it is an official stable release. Hence the webpack asciidoc guide doesn’t have the docs website header.
Fixes #21

This change is

Overall very understandable and a good tutorial, nicely done. :+1:
Added some minor line comments and created #68. :smile:
In addition I would also add a line break after every sentence instead of having very long lines with multiple sentences. This makes the source file easier to maintain (without horizontal scrolling or having to enable line wrapping). This was also a convention originally suggested by @magi42

Reviewed 2 of 2 files at r1.
Review status: 1 of 2 files reviewed at latest revision, 9 unresolved discussions.

docs/ng-cli-webpack.adoc, line 26 [r1] (raw file):

[subs="normal"]
----
[prompt]#$# [command]#npm# install angular-cli -g@webpack

I think this would be more readable by having the version next to the package name, like the following example.
npm install -g angular-cli@webpack
Although I guess the @webpack version specifier will be removed when the next version of Angular CLI is released.

docs/ng-cli-webpack.adoc, line 37 [r1] (raw file):

[prompt]#$# [command]#ng# build
[prompt]#$# [command]#ng# test
[prompt]#$# [command]#ng# serve

Should we mention that after this the app is running at http://localhost:4200? It is mentioned in the output, but might be lost in the verbose logging.

docs/ng-cli-webpack.adoc, line 52 [r1] (raw file):

----

By default, Bower installs dependencies in the [filename]#bower_components# folder. But Angular-CLI expects static stuff to be in the [filename]#public# directory. Thus, create the [filename]#.bowerrc# file in the root directory, with the following content:

I think this should be "installs dependencies to the".

Maybe the .bowerrc file should be elaborated a bit more. Something along the lines of:
"Create a .bowerrc file to instruct Bower to install dependencies inside the directory expected by Angular."

docs/ng-cli-webpack.adoc, line 82 [r1] (raw file):

====

Next we will modify the application index file to load the web components polyfill and import the Polymer elements. Open the [filename]#src/index.html# file and append the following lines to the [elementname]#head# section as follows:

Not sure if the "index file" needs to be mentioned here. IMO the text would flow better with just "we will modify the application to load the web components...".

The src/index.html is mentioned in the next sentence anyways.

Repeated "following/follows". Maybe just say "append the following lines to the head section." (with removing the "as follows").

docs/ng-cli-webpack.adoc, line 98 [r1] (raw file):

----

In Angular-CLI Webpack projects, the main application file is automatically bundled and appended to the end of the [elementname]#body# section in the application’s [filename]#index.html# file. It means that the Angular application is imported and bootstrapped synchronousely. Meanwhile, the Polymer elemnts are loaded from the HTML Imports, which are processed asynchronousely in browsers that do not have a native support.

Couple of typos.
synchronousely → synchronously
asynchronousely → asynchronously

docs/ng-cli-webpack.adoc, line 100 [r1] (raw file):

In Angular-CLI Webpack projects, the main application file is automatically bundled and appended to the end of the [elementname]#body# section in the application’s [filename]#index.html# file. It means that the Angular application is imported and bootstrapped synchronousely. Meanwhile, the Polymer elemnts are loaded from the HTML Imports, which are processed asynchronousely in browsers that do not have a native support.

In order to use Polymer elements from javascript with cross-browser support, we have to wait for the Polymer elements to be loaded and registered before running the application code. Therefore, we have to postpone the Angular application import after the [eventname]#WebComponentsReady# event is dispatched. Add the loader script file [filename]#src/main-polymer.ts# with the following contents:

javascript → Javascript
The last sentence sounds a bit weird. I would reword this a bit. Maybe something like:
"Create a new file src/main-polymer.ts with the following loader script."

docs/ng-cli-webpack.adoc, line 143 [r1] (raw file):

== Using Polymer Elements

Now that everything is set, we can add any polymer elements to our application using their element names in templates, and the [classname]#PolymerElement# directive in code.

polymer → Polymer

docs/ng-cli-webpack.adoc, line 162 [r1] (raw file):

@Component({
  moduleId: module.id,

I had to remove this line moduleId: module.id, to make the app work.
Got this error otherwise:
https://github.com/angular/angular/issues/10626

docs/ng-cli-webpack.adoc, line 208 [r1] (raw file):

----

Finally, you can use Polymer custom CSS properties and custom CSS mixins either: in the [filename]#app.component.ts# file for the scoped styles, or in the [filename]#index.html# file for the global ones.

The word "either" looks a bit weird here. Maybe just remove it?

Comments from Reviewable

Review status: 1 of 2 files reviewed at latest revision, 9 unresolved discussions.

docs/ng-cli-webpack.adoc, line 100 [r1] (raw file):
Previously, tehapo (Teemu Pöntelin) wrote…
> javascript → Javascript
>
> The last sentence sounds a bit weird. I would reword this a bit. Maybe something like:
> "Create a new file src/main-polymer.ts with the following loader script."

Actually "javascript" → "JavaScript" :smile:

Comments from Reviewable

Review status: 1 of 2 files reviewed at latest revision, 9 unresolved discussions.

docs/ng-cli-webpack.adoc, line 26 [r1] (raw file):
Previously, tehapo (Teemu Pöntelin) wrote…
> I think this would be more readable by having the version next to the package name, like the following example.
> `npm install -g angular-cli@webpack`
>
> Although I guess the `@webpack` version specifier will be removed when the next version of Angular CLI is released.

Done.

docs/ng-cli-webpack.adoc, line 37 [r1] (raw file):
Previously, tehapo (Teemu Pöntelin) wrote…
> Should we mention that after this the app is running at `http://localhost:4200`? It is mentioned in the output, but might be lost in the verbose logging.

Done.

docs/ng-cli-webpack.adoc, line 52 [r1] (raw file):
Previously, tehapo (Teemu Pöntelin) wrote…
> 1) I think this should be "installs dependencies _to_ the".
>
> 2) Maybe the `.bowerrc` file should be elaborated a bit more. Something along the lines of:
> "Create a .bowerrc file to instruct Bower to install dependencies inside the directory expected by Angular."

1) Done.

No action. If I extend the last sentence, it will become too complex. And if I make a separate sentence, it duplicates the meaning of the other sentences in this paragraph.

docs/ng-cli-webpack.adoc, line 82 [r1] (raw file):
Previously, tehapo (Teemu Pöntelin) wrote…
> 1) Not sure if the "index file" needs to be mentioned here. IMO the text would flow better with just "we will modify the application to load the web components...".
>
> The `src/index.html` is mentioned in the next sentence anyways.
>
> 2) Repeated "following/follows". Maybe just say "append the following lines to the head section." (with removing the "as follows").

1) Reworded as "index HTML file". Just "modify the application" feels too unspecific. Repeating is not an issue here IMO.

Done.

docs/ng-cli-webpack.adoc, line 98 [r1] (raw file):
Previously, tehapo (Teemu Pöntelin) wrote…
> Couple of typos.
> synchronousely → synchronously
> asynchronousely → asynchronously

Done.

docs/ng-cli-webpack.adoc, line 100 [r1] (raw file):
Previously, tehapo (Teemu Pöntelin) wrote…
> Actually "javascript" → "JavaScript" :smile:

Done.

docs/ng-cli-webpack.adoc, line 143 [r1] (raw file):
Previously, tehapo (Teemu Pöntelin) wrote…
> polymer → Polymer

Done.

docs/ng-cli-webpack.adoc, line 162 [r1] (raw file):
Previously, tehapo (Teemu Pöntelin) wrote…
> I had to remove this line `moduleId: module.id,` to make the app work.
>
> Got this error otherwise:
> https://github.com/angular/angular/issues/10626

Done.

docs/ng-cli-webpack.adoc, line 208 [r1] (raw file):
Previously, tehapo (Teemu Pöntelin) wrote…
> The word "either" looks a bit weird here. Maybe just remove it?

Done.

Comments from Reviewable

Reviewed 1 of 1 files at r2.
Review status: all files reviewed at latest revision, 3 unresolved discussions.

docs/ng-cli-webpack.adoc, line 37 [r1] (raw file):
Previously, platosha (Anton Platonov) wrote…
> Done.

Good idea to also add Ctrl+C there. :+1:

docs/ng-cli-webpack.adoc, line 52 [r1] (raw file):
Previously, platosha (Anton Platonov) wrote…
> 1) Done.
>
> 2) No action. If I extend the last sentence, it will become too complex. And if I make a separate sentence, it duplicates the meaning of the other sentences in this paragraph.

2) Fair enough, I'm ok with that.

docs/ng-cli-webpack.adoc, line 82 [r1] (raw file):
Previously, platosha (Anton Platonov) wrote…
> 1) Reworded as "index HTML file". Just "modify the application" feels too unspecific. Repeating is not an issue here IMO.
>
> 2) Done.

1) Ok, that's sounds also good.

Comments from Reviewable

Merging this documentation now. As mentioned in the PR description, this will not appear in the official documentation until we uncomment links and add a proper header metadata. This should be done after Angular CLI releases the Webpack version.

Review status: all files reviewed at latest revision, 3 unresolved discussions.

Comments from Reviewable


Master to Live

Docs Build status updates of commit d26fee8:
:clock10: Full build: the average full build time is 12 min(s) 34 sec(s), this is based on the last 1000 build(s) for this repository.

Docs Build status updates of commit d26fee8:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

exchange/exchange-ps/exchange/encryption-and-certificates/Set-OMEConfiguration.md
:white_check_mark:Succeeded
View (exchange-ps)

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.

Docs Build status updates of commit bb29532:
:clock10: Full build: the average full build time is 12 min(s) 35 sec(s), this is based on the last 1000 build(s) for this repository.

Docs Build status updates of commit bb29532:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

exchange/exchange-ps/exchange/encryption-and-certificates/Set-OMEConfiguration.md
:white_check_mark:Succeeded
View (exchange-ps)

skype/skype-ps/skype/Set-CsConferencingPolicy.md
:white_check_mark:Succeeded
View (skype-ps)

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.

Docs Build status updates of commit 71a09be:
:clock10: Full build: the average full build time is 12 min(s) 35 sec(s), this is based on the last 1000 build(s) for this repository.

Docs Build status updates of commit 71a09be:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

exchange/exchange-ps/exchange/encryption-and-certificates/Set-OMEConfiguration.md
:white_check_mark:Succeeded
View (exchange-ps)

sharepoint/sharepoint-ps/sharepoint-pnp/Set-PnPClientSidePage.md
:white_check_mark:Succeeded
View (sharepoint-ps)

skype/skype-ps/skype/Set-CsConferencingPolicy.md
:white_check_mark:Succeeded
View (skype-ps)

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.

Docs Build status updates of commit 734becc:
:clock10: Full build: the average full build time is 12 min(s) 35 sec(s), this is based on the last 1000 build(s) for this repository.

Docs Build status updates of commit 734becc:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

exchange/exchange-ps/exchange/encryption-and-certificates/Set-OMEConfiguration.md
:white_check_mark:Succeeded
View (exchange-ps)

sharepoint/sharepoint-ps/sharepoint-pnp/Set-PnPClientSidePage.md
:white_check_mark:Succeeded
View (sharepoint-ps)

skype/skype-ps/skype/Set-CsConferencingPolicy.md
:white_check_mark:Succeeded
View (skype-ps)

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.


fix(rust): get default node stop manual error handling

Closes #3558
Current Behavior
As mentioned in #3558 : The current implementation is calling std::process::exit, which is something we want to stop using to handle errors properly and give the user a better-formatted output when a command fails.

Proposed Changes
Propogate errors to the caller and call system::error::exit only once with appropriate error code.

Checks

[x] All commits in this Pull Request are signed and Verified by Github.
[x] All commits in this Pull Request follow the Ockam commit message convention.
[x] I accept the Ockam Community Code of Conduct.
[x] I have accepted the Ockam Contributor License Agreement by adding my Git/Github details in a row at the end of the CONTRIBUTORS.csv file in a separate pull request to the build-trust/ockam-contributors repository.

Hey @akki1306 thanks for submitting another PR! It looks like the lint stage is not passing. Make sure to run cargo fmt --all to fix any formatting errors.