collectCoverageFrom didn't work in react components

🐛 Bug Report
when i set jest config in package.json like this
"jest": {
        "verbose": true,
        "collectCoverage": true,
        "globals": {},
        "testEnvironment": "jest-environment-jsdom-global",
        "moduleFileExtensions": [
            "js",
            "jsx",
            "json"
        ],
        "moduleNameMapper": {
            "^@/(.*)$": "<rootDir>/src/$1",
            "\\.(css|less)$": "<rootDir>/__mocks__/styleMock.js"
        },
        "transform": {
            "^.+\\.(js|jsx)$": "<rootDir>/node_modules/babel-jest",
            "\\.(jpg|jpeg|png|gif|eot|otf|webp|svg|ttf|woff|woff2|mp4|webm|wav|mp3|m4a|aac|oga)$": "<rootDir>/__mocks__/fileTransformer.js"
        },
        "transformIgnorePatterns": [
            "<rootDir>/node_modules/"
        ],
        "setupFiles": [
            "jest-canvas-mock"
        ],
        "testMatch": [
            "<rootDir>/**/*.(test|spec).js"
        ],
        "coverageDirectory": "<rootDir>/test/unit/coverage",
        "collectCoverageFrom": [
            "<rootDir>/**/util.js"
        ],
        "coveragePathIgnorePatterns": [
            "<rootDir>/node_modules/",
            "<rootDir>/test",
            "<rootDir>/tasks",
            "<rootDir>/config"
        ]
    },

when i run yarn run jest, i get this
To Reproduce

Expected behavior
is should only collect util.js , but it collect react components,
i set react components test
it('renders correctly', () => {
        expect(toJson(wrapper)).toMatchSnapshot();
    });

is this impact collectCoverageFrom
Link to repl or repo (highly encouraged)
sorry,i can't provided it

envinfo

System:
    OS: macOS High Sierra 10.13.4
    CPU: x64 Intel(R) Core(TM) i7-7700K CPU @ 4.20GHz
  Binaries:
    Node: 10.15.3
    Yarn: 1.16.0
    npm: 6.4.1
  npmPackages:
    jest:
      wanted: ^23.2.0
      installed: 23.6.0

Can you try on the latest version of Jest? Also please try to form the issue a bit clearer, because I have troubles understanding :<

i have update jest 24.9.0 version, it also has this problem.
the problem is collectCoverageFrom didn't work.
i set jest config
collectCoverageFrom: ['<rootDir>/**/util.js']
so i want to collect Coverage the files named 'util.js' ,
but it collect all the files

I have the same issue, have you found a solution?

@vcheeney not yet

@z2014  - I guess your regex is not working correctly not sure with your code.
but I am able to ignore files using below code .
collectCoverageFrom: ['/src//*.{js,jsx,ts,tsx}', '!/src//*css.ts'],
try add in collectCoverageFrom: ['/src/**/*util.js'],

@SunilSalve
['/src//*.{js,jsx,ts,tsx}', '!/src//*css.ts']
is css.ts right ?
can you provide a complete code, thanks

Any update one this one?

collectCoverageFrom still doesn't collect coverage for React components? I'm trying it with "src/**/*.{ts,tsx}" and it indeed doesn't cover React components.


Safari initial render issue

Running into a strange issue with Safari.  Chrome and Firefox are fine.
On a hard refresh the doc remains blank but other connected browsers display this initial render correctly.  If i navigate to another doc Safari behaves correctly.
Every once in a while i can get Safari to display the initial content if it originated from Safari (super rare though).
I've noticed in the sync-plugin.js line 146 changedInitialContent is always false view.state.doc.content.size is always 2 and emptySize is always 2 where chrome will be the same until if finally syncs.
https://github.com/yjs/y-prosemirror/blob/master/src/plugins/sync-plugin.js#L146

Looks like https://github.com/yjs/yjs/commit/4b08c67e06e351d6af5e624821f52b7ae54c39c1 this commit fixes it!  Thank you!!!!

Awesome, I was just going to ask ^^

@dmonad I'm not 100% sure if this issue is back.  But we are now seeing the same behavior in Chrome and Safari.

Can you make sure that you are using the latest version of lib0?
Safari's TextEncoder has an issue with utf8 encoding. How do you reproduce this issue in Chrome and Safari?
In one of the "incomplete" documents,  can you log doc.share. Does it have duplicate keys?

So I'm not 100% convinced this is the same problem.  This issue seems to only happen when the user is connected to the same doc multiple times. It throws this error
Cannot read property 'matchesNode' of null from https://github.com/yjs/y-prosemirror/blob/master/src/plugins/sync-plugin.js#L244

Then there seems to be something wrong with the initial transaction. Can you please log some more information?
• The transaction changes.
• Maybe the output of view.state.apply(tr), if that even computes.
• The full error stack
I can't really help with this issue if I can't reproduce it.

Yea i totally understand.  I can't actually reproduce it either.  It's a person on the team that runs into it at will.  I'll see what i can give ya.

Gonna close this for now. Please reopen if you can reproduce it and make sure to specify which version of lib0 you are using.


Find out sensitive data used on CI

Find out sensitive data used on CI

Done, no sensitive data have been found.


Elastalert missing

Elastalert no more part of this project?

@bbatmandakh No, it was discontinued in favor of ELK Built-In Alerts (requires TLS to be enabled).


disable telemetry of yarn and next by default

I personally prefer disabling telemetry by default.
What do you guys think about it? Is it a good idea for you?
@mikecao @hugomd

Out of interest, why do you prefer disabling telemetry?
I'm fine with the change, I really don't mind. Is there a way to make this change at the project level, so it affects users who aren't deploying with Docker?

Out of interest, why do you prefer disabling telemetry?
I'm fine with the change, I really don't mind. Is there a way to make this change at the project level, so it affects users who aren't deploying with Docker?

Yes, run these two changes at your development environment.

Yes, run these two changes at your development environment.
I understand that, but I mean is there anything we can set in package.json to set no telemetry by default?

Yes, run these two changes at your development environment.
I understand that, but I mean is there anything we can set in package.json to set no telemetry by default?

no no such config in package.json.
if you go through.

https://yarnpkg.com/advanced/telemetry
https://nextjs.org/telemetry


Hotfix

Fixes #826 (or at least, fixes the panic that we think is the cause of 826)

Hmm..   I guess the previous fail was a flake...
cargo nextest run -p darkside-tests
   Compiling zingolib v0.2.0 (/home/nattyb/src/zingolabs/zingolibs/dev/zingolib)
   Compiling zingo-testutils v0.1.0 (/home/nattyb/src/zingolabs/zingolibs/dev/zingo-testutils)
   Compiling darkside-tests v0.1.0 (/home/nattyb/src/zingolabs/zingolibs/dev/darkside-tests)
    Finished test [optimized] target(s) in 38.93s
    Starting 14 tests across 5 binaries (2 skipped)
        PASS [   0.005s] darkside-tests constants::test::abandon_to_darkside_orch_10_000_000_zat
        PASS [   0.005s] darkside-tests constants::test::abandon_to_darkside_sap_10_000_000_zat
        PASS [   0.005s] darkside-tests::advanced_reorg_tests test_read_tree_state_from_file
        PASS [   0.006s] darkside-tests::advanced_reorg_tests test_read_block_dataset
        PASS [   2.356s] darkside-tests::network_interruption_tests interrupt_initial_tree_fetch
        PASS [   2.360s] darkside-tests::tests simple_sync
        PASS [   2.458s] darkside-tests::advanced_reorg_tests reorg_changes_incoming_tx_height
        PASS [   2.511s] darkside-tests::advanced_reorg_tests reorg_expires_incoming_tx
        PASS [   2.557s] darkside-tests::advanced_reorg_tests reorg_changes_incoming_tx_index
        PASS [   6.421s] darkside-tests::tests reorg_away_receipt
        PASS [   6.443s] darkside-tests::advanced_reorg_tests reorg_expires_outgoing_tx_height
        PASS [   6.902s] darkside-tests::advanced_reorg_tests reorg_changes_outgoing_tx_height
        PASS [   7.132s] darkside-tests::advanced_reorg_tests reorg_changes_outgoing_tx_index
        PASS [  13.426s] darkside-tests::tests sent_transaction_reorged_into_mempool
------------
     Summary [  13.429s] 14 tests run: 14 passed, 2 skipped

We don't yet have functional network-interrupt tests in CI.  I have feature gated the test that was added to detect and fix this bug.

hey hold your horses! im about to run these on my box. did you do the same?

why is it flaky?

Well, the feature gate didn't work with "cargo nextest run --archive-file", so I have reverted to ignore.


Backport issue(#1156) and issue(#1057) to branch opendistro-1.7

opensearch-security pull request intake form
Please provide as much details as possible to get feedback/acceptance on your PR quickly

Category: (Enhancement, New feature, Bug fix, Test fix, Refactoring, Maintenance, Documentation)
Backporting

Github Issue # or road-map entry, if available:

Description of changes:

Why these changes are required?

What is the old behavior before changes and new behavior after changes? (Please add any example/logs/screen-shot if available)

Testing done: (Please provide details of testing done: Unit testing, integration testing and manual testing)

Setup Instructions

8.Is it backport from main branch? (If yes, please add backport PR # and commits #)
Yes,

#1156  and commit hash is : 9adcd2010ad7d0d693704227eb7db31ae72e841d

#1057 and commit hash is : 70a4f700518c06fb24cac1b01a22dad33d6fad8e
By making a contribution to this project, I certify that:
(a) The contribution was created in whole or in part by me and I
have the right to submit it under the open source license
indicated in the file; or
(b) The contribution is based upon previous work that, to the best
of my knowledge, is covered under an appropriate open source
license and I have the right under that license to submit that
work with modifications, whether created in whole or in part
by me, under the same open source license (unless I am
permitted to submit under a different license), as indicated
in the file; or
(c) The contribution was provided directly to me by some other
person who certified (a), (b) or (c) and I have not modified
it.
(d) I understand and agree that this project and the contribution
are public and that a record of the contribution (including all
personal information I submit with it, including my sign-off) is
maintained indefinitely and may be redistributed consistent with
this project or the open source license(s) involved.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Codecov Report

Merging #1265 (96382b2) into opendistro-1.7 (8e6cfe7) will increase coverage by 0.15%.
The diff coverage is 77.77%.

@@                 Coverage Diff                  @@
##             opendistro-1.7    #1265      +/-   ##
====================================================
+ Coverage             62.71%   62.86%   +0.15%
- Complexity             2951     2967      +16
====================================================
  Files                   229      231       +2
  Lines                 16326    16377      +51
  Branches               3057     3062       +5
====================================================
+ Hits                  10239    10296      +57
+ Misses                 4509     4497      -12
- Partials               1578     1584       +6

Impacted Files
Coverage Δ

...arch/security/ssl/OpenDistroSecuritySSLPlugin.java
82.05% <0.00%> (ø)

...ort/OpenDistroSecuritySSLTransportInterceptor.java
0.00% <0.00%> (ø)

...lasticsearch/security/support/ConfigConstants.java
90.00% <ø> (ø)

...rch/security/setting/OpenDistroDynamicSetting.java
60.00% <60.00%> (ø)

...ticsearch/security/configuration/CompatConfig.java
38.23% <66.66%> (+10.64%)
:arrow_up:

.../security/setting/TransportPassiveAuthSetting.java
80.00% <80.00%> (ø)

...ecurity/configuration/ConfigurationRepository.java
74.54% <80.39%> (+4.84%)
:arrow_up:

...ty/transport/OpenDistroSecurityRequestHandler.java
71.64% <83.33%> (+0.91%)
:arrow_up:

...arch/security/filter/OpenDistroSecurityFilter.java
64.33% <88.88%> (+3.14%)
:arrow_up:

...asticsearch/security/OpenDistroSecurityPlugin.java
82.35% <100.00%> (+0.11%)
:arrow_up:

... and 12 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7bce37a...96382b2. Read the comment docs.


Can assess go to definition and peek does not work

VSCode Version: Code 1.8.1 (ee428b0eead68bf0fb99ab5fdc4439be227b6281, 2016-12-19T14:49:23.350Z)
OS Version: Windows_NT ia32 6.1.7601
Extensions:

Extension
Author
Version

python
donjayamanne
0.5.4

Steps to Reproduce:

We need more information to investigate: what is the expected behavior? actual behavior? repo steps?
Thanks

Hi,
Selecting a variable and right clicking it, the menu does not show the go
to definition, etc. This happens in a enterprise computer which is highly
restricted so I don't have many means of sending you metrics, etc. I fill
this issue in the hope if any one else has experienced the same.
There is only one extension installed which is the recommended python
extension.
Hope this helps.
[image: Inline image 1]
On Wed, Jan 11, 2017 at 6:40 PM, Matt Bierner<EMAIL_ADDRESS>wrote:

We need more information to investigate: what is the expected behavior?
actual behavior? repo steps?
Thanks
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/Microsoft/vscode/issues/18406#issuecomment-271956058,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AWalNUuGqXITAFH6EITXx0WmnieMXXI2ks5rRSIkgaJpZM4Lgou0
.

--
João Beja Pedro


Pause device audio when recording starts❓

Question
If I have music playing on my device (iOS and Android), when I record using the native camera app the audio will pause until the recording has finished. However, when using this package the audio continues in the background when recording. Are there any methods or variables available for setting the audio mixing properties?
In this closed issue it shows that .playAndRecord is already implemented. Is this a bug and should external audio be paused during recording?
What I tried
Recording video on iOS and Android with music app playing in the background. Audio continues. Then try the same using native camera app, audio pauses and recommences when recording complete
VisionCamera Version
3.6.13
Additional information

[ ] I am using Expo
[X] I have read the Troubleshooting Guide
[X] I agree to follow this project's Code of Conduct
[X] I searched for similar questions in the issues page as well as in the discussions page and found none.

This is per design! Audio is automatically muxed to provide a seamless user experience - just like in Snapchat or Instagram.

There is currently no way to configure that behaviour, so please create a feature request or contact me through my agency so we can develop that feature for you :)


MINOR: remove KTable.to from the docs

KTable#to was already removed and should not be mentioned in the docs any longer.
Call for review @bbejeck

Merged to trunk and cherry-picked to 2.8.


Fixed parsing of ld.so.cache on new glibc.

Since glibc 2.32, ld.so.cache now defaults to the "new" format, instead
of the "compat" format which was in use since glibc 2.2 (around 20 years
ago). It is now the default on e.g. Debian bullseye, and any recent Linux
distribution.
The code change adds support for the "new" format along with the existing
support for the "compat".
Before:
root@thinkpad:/home/cf/src/mesos/build# ldconfig -c new
root@thinkpad:/home/cf/src/mesos/build# ./bin/mesos-tests.sh --gtest_filter=*Ld*
[...]
[==========] Running 4 tests from 2 test cases.
[----------] Global test environment set-up.
[----------] 1 test from LdcacheTest
[ RUN      ] LdcacheTest.Parse
../../src/tests/ldcache_tests.cpp:43: Failure
cache: Invalid format
[  FAILED  ] LdcacheTest.Parse (0 ms)
[----------] 1 test from LdcacheTest (0 ms total)

[----------] 3 tests from Ldd
[ RUN      ] Ldd.BinSh
../../src/tests/ldd_tests.cpp:43: Failure
cache: Invalid format
[  FAILED  ] Ldd.BinSh (0 ms)
[ RUN      ] Ldd.EmptyCache
[       OK ] Ldd.EmptyCache (1 ms)
[ RUN      ] Ldd.MissingFile
../../src/tests/ldd_tests.cpp:77: Failure
cache: Invalid format
[  FAILED  ] Ldd.MissingFile (0 ms)
[----------] 3 tests from Ldd (1 ms total)

[----------] Global test environment tear-down
[==========] 4 tests from 2 test cases ran. (8 ms total)
[  PASSED  ] 1 test.
[  FAILED  ] 3 tests, listed below:
[  FAILED  ] LdcacheTest.Parse
[  FAILED  ] Ldd.BinSh
[  FAILED  ] Ldd.MissingFile

 3 FAILED TESTS

After:
root@thinkpad:/home/cf/src/mesos/build# ldconfig -c new
root@thinkpad:/home/cf/src/mesos/build# ./bin/mesos-tests.sh --gtest_filter=*Ld*
[...]
[==========] Running 4 tests from 2 test cases.
[----------] Global test environment set-up.
[----------] 1 test from LdcacheTest
[ RUN      ] LdcacheTest.Parse
[       OK ] LdcacheTest.Parse (529 ms)
[----------] 1 test from LdcacheTest (529 ms total)

[----------] 3 tests from Ldd
[ RUN      ] Ldd.BinSh
[       OK ] Ldd.BinSh (3 ms)
[ RUN      ] Ldd.EmptyCache
[       OK ] Ldd.EmptyCache (0 ms)
[ RUN      ] Ldd.MissingFile
[       OK ] Ldd.MissingFile (0 ms)
[----------] 3 tests from Ldd (3 ms total)

[----------] Global test environment tear-down
[==========] 4 tests from 2 test cases ran. (541 ms total)
[  PASSED  ] 4 tests.

Closes #10220.
@asekretenko @andreaspeters

For me it looks fine. How about @asekretenko ?

FWIW it's breaking other things:
[ RUN      ] HealthCheckTest.ROOT_HealthyTaskWithContainerImage
../../src/tests/health_check_tests.cpp:505: Failure
(testImage).failure(): Failed to create docker test image rootfs: Failed to parse ld.so cache: Invalid format
[  FAILED  ] HealthCheckTest.ROOT_HealthyTaskWithContainerImage (26 ms)

@bmahler

@qianzhangxa

FWIW it's breaking other things:
[ RUN      ] HealthCheckTest.ROOT_HealthyTaskWithContainerImage
../../src/tests/health_check_tests.cpp:505: Failure
(testImage).failure(): Failed to create docker test image rootfs: Failed to parse ld.so cache: Invalid format
[  FAILED  ] HealthCheckTest.ROOT_HealthyTaskWithContainerImage (26 ms)

@cf-natali Did you run this test in the same machine with the other tests (like LdcacheTest.Parse), all of these tests will call ldcache::parse() internally, so it does not make sense that one succeeds but the other fails.
In another hand, there are a couple of places in ldcache::parse() which will error out with Invalid format, maybe we should use distinct error message in each places so that we can better troubleshooting this issue.

On Sat, 29 May 2021, 14:24 Qian Zhang, @.***> wrote:

FWIW it's breaking other things:
[ RUN      ] HealthCheckTest.ROOT_HealthyTaskWithContainerImage
../../src/tests/health_check_tests.cpp:505: Failure
(testImage).failure(): Failed to create docker test image rootfs: Failed to parse ld.so cache: Invalid format
[  FAILED  ] HealthCheckTest.ROOT_HealthyTaskWithContainerImage (26 ms)
@cf-natali https://github.com/cf-natali Did you run this test in the
same machine with the other tests (like LdcacheTest.Parse), all of these
tests will call ldcache::parse() internally, so it does not make sense
that one succeeds but the other fails.

I'm not sure what you mean - this test is an example of failing tests,
among many others.
In another hand, there are a couple of places in ldcache::parse() which

will error out with Invalid format, maybe we should use distinct error
message in each places so that we can better troubleshooting this issue.

Dunno, the issue seems pretty clear to me, it affects anything parsing
ldcache due to the format change. And the attached change fixes it.
—

You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/apache/mesos/pull/384#issuecomment-850833193, or
unsubscribe
https://github.com/notifications/unsubscribe-auth/AB75O43IY5HF3SVBGXFFSS3TQDTIZANCNFSM443EOPDA
.

Dunno, the issue seems pretty clear to me, it affects anything parsing ldcache due to the format change. And the attached change fixes it.

NVM, I thought HealthCheckTest.ROOT_HealthyTaskWithContainerImage failed after your code changes in this PR was applied, sorry for the confusion.

Dunno, the issue seems pretty clear to me, it affects anything parsing ldcache due to the format change. And the attached change fixes it.

NVM, I thought HealthCheckTest.ROOT_HealthyTaskWithContainerImage failed after your code changes in this PR was applied, sorry for the confusion.

Aha no worries it happens!

Ah and by the way, here's how I tested it:
compat format - until 2.32/2.31:
root@thinkpad:/home/cf/src/mesos/build# ldconfig -c compat
root@thinkpad:/home/cf/src/mesos/build# ./bin/mesos-tests.sh --gtest_filter=*Ld* 2>&1 | tail -n13

[----------] 3 tests from Ldd
[ RUN      ] Ldd.BinSh
[       OK ] Ldd.BinSh (2 ms)
[ RUN      ] Ldd.EmptyCache
[       OK ] Ldd.EmptyCache (0 ms)
[ RUN      ] Ldd.MissingFile
[       OK ] Ldd.MissingFile (1 ms)
[----------] 3 tests from Ldd (3 ms total)

[----------] Global test environment tear-down
[==========] 4 tests from 2 test cases ran. (548 ms total)
[  PASSED  ] 4 tests.

new format - supported by this change:
root@thinkpad:/home/cf/src/mesos/build# ldconfig -c new
root@thinkpad:/home/cf/src/mesos/build# ./bin/mesos-tests.sh --gtest_filter=*Ld* 2>&1 | tail -n13

[----------] 3 tests from Ldd
[ RUN      ] Ldd.BinSh
[       OK ] Ldd.BinSh (3 ms)
[ RUN      ] Ldd.EmptyCache
[       OK ] Ldd.EmptyCache (0 ms)
[ RUN      ] Ldd.MissingFile
[       OK ] Ldd.MissingFile (1 ms)
[----------] 3 tests from Ldd (4 ms total)

[----------] Global test environment tear-down
[==========] 4 tests from 2 test cases ran. (550 ms total)
[  PASSED  ] 4 tests.

old format - never supported - as a sanity check:
root@thinkpad:/home/cf/src/mesos/build# ldconfig -c old
root@thinkpad:/home/cf/src/mesos/build# ./bin/mesos-tests.sh --gtest_filter=*Ld* 2>&1 | tail -n13
cache: Invalid format
[  FAILED  ] Ldd.MissingFile (0 ms)
[----------] 3 tests from Ldd (1 ms total)

[----------] Global test environment tear-down
[==========] 4 tests from 2 test cases ran. (7 ms total)
[  PASSED  ] 1 test.
[  FAILED  ] 3 tests, listed below:
[  FAILED  ] LdcacheTest.Parse
[  FAILED  ] Ldd.BinSh
[  FAILED  ] Ldd.MissingFile

 3 FAILED TESTS

I think all comments are addressed now, let me know if you need anything else :).

Just posted a minor comment, otherwise I think we are good to merge :)

The commit in this PR has been merged, and I also marked https://issues.apache.org/jira/browse/MESOS-10220 as resolved, thanks @cf-natali for your contribution!


Convert dom-particle-base to typescript

Addresses #1765

PTAL.  Added throws where needed.  The single store method implemented in handle.ts was only added recently, so removing it preserves original behavior.


Remove old deploy_contract cheatcode

*deprecate

Nah, we can remove it, new interface is compatible.

Did you mean removing old deploy_contract code?
"deploy_contract": build_deploy_contract(deployment_manager),

Currently, deploy_contract is an abstraction over declare, prepare and deploy.

#358 I will wait until this one is merged, as it will require using data transformer in the new deploy_contract cheatcode

@kasperski95 It's probably done, is it?


Update version in theme.yml

Questions
Answers

Description?
Update version in theme.yml

Type?
improvement

BC breaks?
no

Deprecations?
no

Fixed ticket?

Sponsor company

How to test?
CI 🟢

This release won't be compatible with PS 8.0.x?

No 2.1.x is made for 8.1.x and 2.0.x is made for 8.0.x.


Update sbt to 1.4.7

Updates org.scala-sbt:sbt from 1.4.5 to 1.4.7.
I'll automatically update this PR to resolve conflicts as long as you don't change it yourself.
If you'd like to skip this version, you can just close this PR. If you have any feedback, just mention me in the comments below.
Configure Scala Steward for your repository with a .scala-steward.conf file.
Have a fantastic day writing Scala!

Ignore future updates
Add this to your .scala-steward.conf file to ignore future updates of this dependency:
updates.ignore = [ { groupId = "org.scala-sbt", artifactId = "sbt" } ]

labels: library-update, semver-patch

Superseded by #30.


⚠ SceneTime has degraded performance

In 5c4c1f4, SceneTime ($ST) experienced degraded performance:

HTTP code: 200
Response time: 1887 ms

Resolved: SceneTime performance has improved in 7261dea after 12 minutes.


Implement new Khiops versioning scheme

In the end we were already compatible with a fourth digit. The thing that needed to be addressed were the new Khiops versioning scheme.

In the end we were already compatible with a fourth digit. The thing that needed to be addressed were the new Khiops versioning scheme.

Yes, ok, I got it. So, no need for extra provisions for the fourth digit


Kylesayrs/green or bust

TODO
https://www.notion.so/Green-or-Bust-1152d96e7ea18087af94c36af6aede6e?pvs=4
Needs CT merges
https://github.com/neuralmagic/compressed-tensors/pull/185

Is green with https://github.com/neuralmagic/compressed-tensors/pull/185


Custom BL  (IDFGH-5787)

Environment

Development Kit:      [none]
Module or chip used:  ESP32-WROOM-32
IDF version ESP-IDF v4.3
Build System:      idf.py
Compiler version xtensa-esp32-elf-gcc (crosstool-NG esp-2020r3) 8.4.0
Operating System:    Windows
(Windows only) environment type:ESP Command Prompt
Using an IDE?: no
Power Supply:  USB

Problem Description
Hi!
I need to replace the bootloader to make some modifications that are needed in a project.
According to this link titled Custom bootloadercopying the folder bootloader from components to the user project folder, also under components should allow to modify the behavior for the bl.
So I chose an example, I compile it without any mod, and was OK. Then, I copied the bootloader folder to example/components and tried to compile again.
This is the error that throws
-- Adding linker script C:/esp-idf/components/esp32/ld/esp32.peripherals.ld
CMake Error at components/bootloader/CMakeLists.txt:15 (esptool_py_flash_project_args):
Unknown CMake command "esptool_py_flash_project_args".
-- Configuring incomplete, errors occurred!
Code to reproduce this issue
example: esp-idf-master\examples\wifi\fast_scan

components/bootloader folder from esp-idf-master\components\bootloader

I tried also the custom BL from the example. It compiled OK, but then I realized that c files from bootloader_components/main folder are not being included in the compilation (I've inserted a couple of syntax errors in the c file, and all the project compile the same).
Thanks in advance!

Environment

Development Kit:      [none]
Module or chip used:  ESP32-WROOM-32
IDF version ESP-IDF v4.3

Problem Description
Hi!
I need to replace the bootloader to make some modifications that are needed in a project.
According to this link titled Custom bootloadercopying the folder bootloader from components to the user project folder, also under components should allow to modify the behavior for the bl.

Above link is for master tree.
For v4.3, please reference https://docs.espressif.com/projects/esp-idf/en/v4.3/esp32/api-guides/bootloader.html#custom-bootloader

Hi! Thanks for you fast response.
You are right ! I think I copied the wrong link to add to the issue.   However, the link you provided describes the copy/paste procedure that I've tried unsuccessfully.

@fbucafusco Sorry for the late response.
I've just tested on v4.3 according to what the docs says (copy the whole component to /your_project/components/bootloader/) and everything seems OK. It compiles and flash the "custom" bootloader as expected.
Note that customizing the bootloader should be even easier on the latest IDF master, including two new examples showing two different approaches to achieving this: https://docs.espressif.com/projects/esp-idf/en/latest/esp32/api-guides/bootloader.html#custom-bootloader

Closing this one due to lack of activity, but feel free to reopen if my answer didnt fully solve your issue.


refactor: use secrets repo as a submodule

colmena do not support git submodule, closed this: https://github.com/zhaofengli/colmena/issues/181


test:Preferences in the Menu Bar opens the Settings page

Summary

e2e test:Preferences in the Menu Bar opens the Settings page
Ticket Link

Fixes https://github.com/mattermost/desktop/issues/1893
Checklist

[ ] Added or updated unit tests (required for all new features)
[ ] Has UI changes
[ ] read and understood our Contributing Guidelines
[ ] completed Mattermost Contributor Agreement
[ ] executed npm run lint:js for proper code formatting

Device Information
This PR was tested on:
Screenshots

Release Note

NONE

Hello @codedsun,
Thanks for your pull request! A Core Committer will review your pull request soon. For code contributions, you can learn more about the review process here.

@devinbinnie One question, how do i close the settings window which is opened by shortcut. I tried settingsWindow.close() but it throws error
Timeout of 30000ms exceeded. For async tests and hooks, ensure "done()" is called; if returning a Promise, ensure it resolves

@devinbinnie @M-ZubairAhmed The doc also says that closing the window can be done by win.close() https://www.electronjs.org/docs/v14-x-y/api/browser-window#winclose

@devinbinnie @M-ZubairAhmed I just resolved using the shortcuts to close the window. Please review. Thanks

@M-ZubairAhmed Please review when time allows. Thanks

@codedsun Can you resolve conflicts? Then I can merge this :)

@devinbinnie Yes i will do it tomorrow. Thanks

@devinbinnie Done the changes..


Update dependencies and client api for hive udb

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Alluxio-Pull-Request-Builder/7209/
Test PASSed.

alluxio-bot, merge this please

alluxio-bot, cherry-pick this to branch-2.1 please


add HnhInstaller

Hi,
This pull request will enable the Hnh framework custom installer.
Thanks :)

Thanks for PR. Please, add to README.md ("Current Supported Package Types") information about your plugins.


very slow on hd graphics 5000

Hi@ganyc717
Thank you for your project, I have tested on my intel hd graphics 5000, it is very slow, about 8 seconds for 1 single image, e.g, the dog.jpg
I have never modified your source code.

Hi@anguoyang
As far as I am concerned, the performance issue is heavily depend on the hardware. For this project, I tested on GTX 970, the work that yolo.cfg to detect dog.jpg spend about 0.18 seconds. About double time cost compared with the origin cuda project on the same hardware(GTX 970).
Thank you for giving me this ticket.

Hi@anguoyang
What mode did you use ? Debug or Release ?
Check Release mode in Visual Studio.

hi@AndrewSivrit, I used Release mode in vs, thank you

hi@ganyc717 , yes maybe, but I want to use intel GPU instead of nvidia, which is cos-efficient for production. thank you for your quick reply.

double time cost compared to cuda is acceptable and reasonable, however, my test result is...really slow, almost hundreds over cuda(similar hardware), so I suppose there maybe something wrong with my program?

D:\Darknet-On-OpenCL\x64\Release>darknet_cl detect cfg/yolo.cfg yolo.weights data/dog.jpg
layer     filters    size              input                output
0 conv     32  3 x 3 / 1   608 x 608 x   3   ->   608 x 608 x  32
1 blas_kernels_1.cl build log:
1:82:37: warning: double precision constant requires cl_khr_fp64, casting to single precision
1:82:58: warning: double precision constant requires cl_khr_fp64, casting to single precision
fcl build 1 succeeded.
fcl build 2 succeeded.
bcl build succeeded.
max          2 x 2 / 2   608 x 608 x  32   ->   304 x 304 x  32
2 conv     64  3 x 3 / 1   304 x 304 x  32   ->   304 x 304 x  64
3 max          2 x 2 / 2   304 x 304 x  64   ->   152 x 152 x  64
4 conv    128  3 x 3 / 1   152 x 152 x  64   ->   152 x 152 x 128
5 conv     64  1 x 1 / 1   152 x 152 x 128   ->   152 x 152 x  64
6 conv    128  3 x 3 / 1   152 x 152 x  64   ->   152 x 152 x 128
7 max          2 x 2 / 2   152 x 152 x 128   ->    76 x  76 x 128
8 conv    256  3 x 3 / 1    76 x  76 x 128   ->    76 x  76 x 256
9 conv    128  1 x 1 / 1    76 x  76 x 256   ->    76 x  76 x 128
10 conv    256  3 x 3 / 1    76 x  76 x 128   ->    76 x  76 x 256
11 max          2 x 2 / 2    76 x  76 x 256   ->    38 x  38 x 256
12 conv    512  3 x 3 / 1    38 x  38 x 256   ->    38 x  38 x 512
13 conv    256  1 x 1 / 1    38 x  38 x 512   ->    38 x  38 x 256
14 conv    512  3 x 3 / 1    38 x  38 x 256   ->    38 x  38 x 512
15 conv    256  1 x 1 / 1    38 x  38 x 512   ->    38 x  38 x 256
16 conv    512  3 x 3 / 1    38 x  38 x 256   ->    38 x  38 x 512
17 max          2 x 2 / 2    38 x  38 x 512   ->    19 x  19 x 512
18 conv   1024  3 x 3 / 1    19 x  19 x 512   ->    19 x  19 x1024
19 conv    512  1 x 1 / 1    19 x  19 x1024   ->    19 x  19 x 512
20 conv   1024  3 x 3 / 1    19 x  19 x 512   ->    19 x  19 x1024
21 conv    512  1 x 1 / 1    19 x  19 x1024   ->    19 x  19 x 512
22 conv   1024  3 x 3 / 1    19 x  19 x 512   ->    19 x  19 x1024
23 conv   1024  3 x 3 / 1    19 x  19 x1024   ->    19 x  19 x1024
24 conv   1024  3 x 3 / 1    19 x  19 x1024   ->    19 x  19 x1024
25 route  16
26 conv     64  1 x 1 / 1    38 x  38 x 512   ->    38 x  38 x  64
27 reorg              / 2    38 x  38 x  64   ->    19 x  19 x 256
28 route  27 24
29 conv   1024  3 x 3 / 1    19 x  19 x1280   ->    19 x  19 x1024
30 conv    425  1 x 1 / 1    19 x  19 x1024   ->    19 x  19 x 425
31 detection
mask_scale: Using default '1.000000'
Loading weights from yolo.weights...Done!
im2col_kernels.cl build log:
2:36:18: warning: '/*' within block comment
fcl build 1 succeeded.
fcl build 2 succeeded.
bcl build succeeded.
activation_kernels.cl build log:
4:21:12: warning: double precision constant requires cl_khr_fp64, casting to single precision
fcl build 1 succeeded.
fcl build 2 succeeded.
bcl build succeeded.
maxpool_layer_kernels.cl build log:
fcl build 1 succeeded.
fcl build 2 succeeded.
bcl build succeeded.
blas_kernels_2.cl build log:
fcl build 1 succeeded.
fcl build 2 succeeded.
bcl build succeeded.
data/dog.jpg: Predicted in 7.806060 seconds.
dog: 82%
car: 28%
truck: 64%
bicycle: 85%

Hi @anguoyang
I have tested on my laptop with intel HD 4600, seems the majority of kernel time spend on sgemm function, this is BLAS function, and I suggest not modify this. But I noticed that clBLAS have special optimization with AMD GPU, and didn't include it in this repo, you may change another GPU and tried again. Or just choose a smaller scale of network like tiny-yolo.
Best Regards!

OpenCL is not platform independent so you would need to tune any CL code to the target platform to avoid register spilling, local memory overflow, etc..


Update South African Consulate email address in Marriage Abroad smart answer

Trello card
Description
Changes<EMAIL_ADDRESS>to<EMAIL_ADDRESS>for all Marriage Abroad outcomes where the user is from South Africa.
Factcheck links

Live version on gov.uk
Preview version for factcheck

Expected Changes
Before

After

LGTM 👍


Question about PDB

Why we not always use 1st eigenvector?
https://github.com/FengZhenhua/Wing-Loss/blob/master/pdb.m#L27

@mrgloom Hi, in general, the 1st eigenvector controls pose variations. But, I visualised the results by changing the weights of the first 3 eigenvectors for different datasets. I found that, for AFLW, the 2nd one controls pose variations. This is why I used the 2nd for AFLW and 1st for the others.

What does it mean 'controls pose variations' in terms of pitch, yaw, roll?

@mrgloom Hi, here the term pose' is a general term. But, in our method, we focus on the yaw rotation for the term 'pose'. You can also do data balancing for any other poses' or a mixture of different `poses'.


can't set breakpoints when using ports

https://github.com/ruby/debug/blob/7b062e6844f7230e604aafa2932178a00f922985/lib/debug/server_dap.rb
If you try you get the message "#{path} is not available". That comes from
    when 'setBreakpoints'
          req_path = args.dig('source', 'path')
          path = UI_DAP.local_to_remote_path(req_path)

          if path
            SESSION.clear_line_breakpoints path

            bps = []
            args['breakpoints'].each{|bp|
              line = bp['line']
              if cond = bp['condition']
                bps << SESSION.add_line_breakpoint(path, line, cond: cond)
              else
                bps << SESSION.add_line_breakpoint(path, line)
              end
            }
            send_response req, breakpoints: (bps.map do |bp| {verified: true,} end)
          else
            send_response req, success: false, message: "#{req_path} is not available"
          end

and it's because local_to_remote_path is
  def self.local_to_remote_path path
      case @local_fs_map
      when nil
        nil
      when true
        path
      else # Array
        @local_fs_map.each do |(remote_path_prefix, local_path_prefix)|
          if path.start_with? local_path_prefix
            return path.sub(local_path_prefix){ remote_path_prefix }
          end
        end

        nil
      end
    end

and @local_fs_map is nil

    # true: all localfs
    # Array: part of localfs
    # nil: no localfs
    @local_fs_map = nil

    def self.remote_to_local_path path
      case @local_fs_map
      when nil
        nil
      when true
        path
      else # Array
        @local_fs_map.each do |(remote_path_prefix, local_path_prefix)|
          if path.start_with? remote_path_prefix
            return path.sub(remote_path_prefix){ local_path_prefix }
          end
        end

        nil
      end
    end

  def dap_setup bytes
      CONFIG.set_config no_color: true
      @seq = 0

      case self
      when UI_UnixDomainServer
        UI_DAP.local_fs_map_set true
      when UI_TcpServer
        # TODO: loopback address can be used to connect other FS env, like Docker containers
        # UI_DAP.local_fs_set if @local_addr.ipv4_loopback? || @local_addr.ipv6_loopback?
      end

They have vscode specific things in there, so they'd probably accept some neovim stuff too?

Oh found this

        when 'attach'
          send_response req
          UI_DAP.local_fs_map_set req.dig('arguments', 'localfs') || req.dig('arguments', 'localfsMap')
          @is_launch = false

so if you send "localfs" as part of the attach message it'll then let you do breakpoints
    {
      type = "ruby",
      name = "run current spec file",
      bundle = "bundle",
      request = "attach",
+     localfs = true,
      command = "rspec",
      script = "${file}",
      port = 38698,
      server = "<IP_ADDRESS>",
      waiting = 1000,
    },

@will
Thank you. I'm not sure, but does https://github.com/suketa/nvim-dap-ruby/pull/20 work?

It looks like it should for sure. It's pretty much wha I did. I'm not direclty using this as a proper plugin but used it as a great staring point to figure out how to get going with nvim-dap and the ruby debugger, but just in my own config.


[Jest]@react-native-community/netinfo: NativeModule.RNCNetInfo is null.

Environment

• Run react-native link @react-native-community/netinfo in the project root.
• Rebuild and re-run the app.
• If you are using CocoaPods on iOS, run pod install in the ios directory and then rebuild and re-run the app. You may also need to re-open Xcode to get the new pods.
• Check that the library was linked correctly when you used the link command by running through the manual installation instructions in the README.
* If you are getting this error while unit testing you need to mock the native module. Follow the guide in the README.
If none of these fix the issue, please open an issue on the Github repository: https://github.com/react-native-community/react-native-netinfo

  at Object.<anonymous> (node_modules/@react-native-community/netinfo/lib/commonjs/internal/nativeInterface.ts:15:9)
  at Object.<anonymous> (node_modules/@react-native-community/netinfo/lib/commonjs/internal/state.ts:11:1)

Platforms

[Jest]
Versions

Android:
iOS:13.2
react-native-netinfo:5.8.0
react-native:0.62.2
react:16.11.0

Description

Reproducible Demo
Tried to test and mock react-native-netinfo for writing unit test. But it's showing the above error.

Not a bug. Jest is a pure javascript environment, you have to mock out native modules for it to work, as there is no native execution environment. This will happen with every native module you try.
Unlike most other native modules this one even provides a mock though - try it out? https://github.com/react-native-community/react-native-netinfo/blob/master/jest/netinfo-mock.js

Thanks @mikehardy
Solved this way..
import mockRNCNetInfo from<EMAIL_ADDRESS>jest.mock('@react-native-community/netinfo', () => mockRNCNetInfo);


About making botocore an optional dependency

Describe the improvement
I am installing cohere-python in a docker image. I don't use any AWS service, nevertheless the library still installs the boto3 dependency that takes around 25 MB of space. Removing the dependency or making it optional can reduce size of the image.
Example of optional dependencies when using poetry.
Thank you!

Hello! Just checking again to see if there's any interest :)

This would be a nice change, and it also seems like this is actually intended.
If you look at their poetry.toml, it's clear that boto3 and sagemaker are both listed as part of the "aws" extra that should only be installed with that flag. Looking in the actually METADATA of the package though, I see that it lists:
Requires-Dist: boto3 (>=1.34.0,<2.0.0) Requires-Dist: sagemaker (>=2.232.1,<3.0.0)
It is a bit obnoxious that these two optional dependencies are sneaking in and bloating the build right now. I'm resolving this by manually excluding them when I pip-compile, but it'd be nice to have a less hacky fix.


Adding new Merge Fields in Word Documents...

Hello,
I have spent a few hours researching how to create Merge Fields within a .docx using Python.
My use case is I have a list of students (or hotels, or activities, or dates, or cities, or a number of other possible fields) and I have documents that outline these lists, like a participant list of students for group trips but each of these trips tend to have different numbers of students.
I can go in and manually create the Merge Fields to have the exact number of students needed for each trip  but it would be best to be able to do this through using the python-docx package in order to automate it.
If anyone has any tips or suggestions on how to use the python-docx package to do this would be much appreciated.
With kind regards,
T

There's no API support for this yet. The general capability is known as "fields" on this issues list. If you do a search on "field" you'll find other issues that have some detail that might be useful to you. Basically you'd have to insert the required XML for a field using lxml calls and so forth. Closing this as duplicate.


This  change add a new method to the DockerUtil API to retrieve the v…

…ersion from the docker server you are using. This is a blocking operation, so when you call the method you wait until the docker version is retrieved (or try it at most 10 times).
This method is called during the setup operation (both native and non native setup procedure), so you have to have a real connection to your docker daemon before you can go forward and this way to avoid synchronization issues as they are described on issue https://github.com/docker/kitematic/issues/1355
Signed-off-by: Alexandre Vázquez<EMAIL_ADDRESS>

Added some comments, thanks for the PR!

Fixed the issues both of you comment and I squash the commits to leave one only comment.
Sorry about the style things. I don't know why the ESLint plug-in for Atom didn't warn me and about the console log I only leave it to keep the style of getting the IP that has a console log.
Sorry!

New on this PR?

I second Alex's comment. Any news on this?

It would be good to have some of the users with the no container listed QA this. I can't tell if it helps or not.
Ping @klousiaj @dbartow

Would love to test it!  I might need some instructions on how to do so, though.  Since it's not in Master yet (I think) and Im not set up as a local developer, and just a generally unskilled developer, how do I go about that lol :)  Thanks!

When running off @alexandrev's branch issue-1355 I could not reproduce the issue described in #1331. Kitematic seems to reliably wait for default to start completely before populating the container list.

Thanks @klousiaj and @dbartow for your comments. @dbartow you only have to change the PR, or if you are facing problems you can do it doing a checkour of my fork: https://github.com/alexandrev/kitematic and the branch name it is: alexandrev:issue-1355

@klousiaj thanks for the qa - @dbartow I'll try to make an exe/dmg for you to test this and see if it solves your issue.
Once you're both happy with it, then we'll merge it. :)
Thanks @alexandrev for the on-going help!!

why this is not merged if it it is confirmed that fix the issue?

@alexandrev I pulled it into a local branch with other fixes in place. I have to do all cross-platform checks manually and replicate previous issues/actions,
As mentioned in the other posts, it's a time consuming task :[

I'm not sure because there is no specific work depending on the result of the function. But I think you should ask to the person who is implementing the Linux support.

@alexandrev I took the above changes as part of some cleanup of the linux distro - It's basically in https://github.com/docker/kitematic/pull/1442 - If you don't mind we'll use that branch over this one, as it contains a lot of small fixes that should make some of the linux support easier.
Is it ok for me to close this PR in favor of the above?

You can do everything that you consider helpful for the project or your
work :). No problem on my side.
On Thu, Feb 4, 2016 at 10:35 PM, French Ben<EMAIL_ADDRESS>wrote:

@alexandrev https://github.com/alexandrev I took the above changes as
part of some cleanup of the linux distro - It's basically in #1442
https://github.com/docker/kitematic/pull/1442 - If you don't mind we'll
use that branch over this one, as it contains a lot of small fixes that
should make some of the linux support easier.
Is it ok for me to close this PR in favor of the above?
—
Reply to this email directly or view it on GitHub
https://github.com/docker/kitematic/pull/1365#issuecomment-180062369.

:+1: Thank you for being understanding :) - Trying to push things forward!


Users who are inactive in the system should not be sent emails

For instance, an old Jackson site member was still being emailed when one of the other site staff now makes comments on Slice sheets.

Moving this back to 0.29.0. I'm going to have to simplify how user's specify if they like emails in the system before being able to make the change for admins to enable/disable emails.


fixed infinite while loop in cross_validation_wrapper

I noticed that this problem was marked as TODO in the learning.py code, so I tried fixing it. I hope it will be working fine now i.e. no more forever running while loop.

Hey, what I see you are doing is, converging the training error to 0. But in that case, it would just be overfit on the training set, loosing the generality. For example:, let's say we have 4 data sets and four labels. The model might take a polynomial of higher degree (greater than 4) and easily classify all four of them correctly, but that would perform horribly on the validation set and test set.
I hope I'm making sense to you.

Thanks for your suggestion @SiluPanda, but I want to clear thet after checkin convergence of training error, I am selecting the size which yielded the best val. error, so, it won't be choosing the overfitted solution.
Plus, please suggest a good threshold for train error, if close to 0 is not a good one.

There are a lot of ways to add a threshold (not the optimal one, but a reasonably sub optimal).
There are a lot of discussions on this already. I believe, deviating from pseudocode should be with the concern of @norvig sir.

But the code is similar to the pseudocode provided here https://github.com/aimacode/aima-pseudocode/blob/master/md/Cross-Validation-Wrapper.md

but the code is similar to the pseudocode at https://github.com/aimacode/aima-pseudocode/blob/master/md/Cross-Validation-Wrapper.md

Yes, it is similar. Let's wait for contributors to add their feedback.


Markdig migration

:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

docs/consume-packages/ways-to-install-a-package.md
:white_check_mark:Succeeded
View

docs/create-packages/Publish-a-package.md
:white_check_mark:Succeeded
View

docs/create-packages/Symbol-Packages.md
:white_check_mark:Succeeded
View

docs/docfx.json
:white_check_mark:Succeeded
View

docs/index.md
:white_check_mark:Succeeded
View

docs/install-nuget-client-tools.md
:white_check_mark:Succeeded
View

docs/policies/Dispute-Resolution.md
:white_check_mark:Succeeded
View

docs/quickstart/create-and-publish-a-package-using-the-dotnet-cli.md
:white_check_mark:Succeeded
View

docs/quickstart/create-and-publish-a-package-using-visual-studio-net-framework.md
:white_check_mark:Succeeded
View

docs/quickstart/create-and-publish-a-package-using-visual-studio.md
:white_check_mark:Succeeded
View

docs/quickstart/install-and-use-a-package-using-the-dotnet-cli.md
:white_check_mark:Succeeded
View

docs/reference/ID-Prefix-Reservation.md
:white_check_mark:Succeeded
View

docs/reference/analyzers-conventions.md
:white_check_mark:Succeeded
View

docs/reference/msbuild-targets.md
:white_check_mark:Succeeded
View

docs/reference/nuspec.md
:white_check_mark:Succeeded
View

docs/reference/target-frameworks.md
:white_check_mark:Succeeded
View

docs/release-notes/NuGet-2.1.md
:white_check_mark:Succeeded
View

docs/release-notes/NuGet-2.5.md
:white_check_mark:Succeeded
View

docs/release-notes/NuGet-2.7.md
:white_check_mark:Succeeded
View

docs/release-notes/NuGet-2.8.md
:white_check_mark:Succeeded
View

docs/release-notes/NuGet-3.5-RC.md
:white_check_mark:Succeeded
View

docs/release-notes/NuGet-4.0-RTM.md
:white_check_mark:Succeeded
View

docs/tools/Package-Manager-UI.md
:white_check_mark:Succeeded
View

docs/tools/cli-ref-environment-variables.md
:white_check_mark:Succeeded
View

docs/tools/cli-ref-restore.md
:white_check_mark:Succeeded
View

docs/tools/nuget-exe-CLI-Reference.md
:white_check_mark:Succeeded
View

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.


fix: PackMutual: Eta-Expand as needed

The packMutual code ought to reliably replace all recursive calls to
the functions in preDefs, even when they are under- or over-applied.
Therefore eta-expand if need rsp. keep extra arguments around.
Needs a tweak to Meta.transform to avoid mistaking the f in
f x1 x2 as a zero-arity application.
Includes a test case.
This fixes #2628 and #2883.

Builds upon #2892. Might be worth to merge #2892 first for bisectability.

I’ll get #2926 in first, and then merge this.


[Fix] fix quantization arg when using marlin

#3331 fix when using marlin model

@zhuohan123 please, could you help me to merge it?

@zhuohan123 @WoosukKwon please, could you help me to merge it?

After the fix is merged, it can run normally.

Thanks for your contribution! @DreamTeamWangbowen Could you fix the code style following CONTRIBUTING.md ?

Thanks for your contribution! @DreamTeamWangbowen Could you fix the code style following CONTRIBUTING.md ?

Okay, I submit a new issue and fix it.

please use sh format.sh to format your code. And then i can merge this.

@DreamTeamWangbowen Do we need this btw? IIUC, the Marlin kernel is automatically used for GPTQ models when the condition is met (act_order=False, etc.).

please use sh format.sh to format your code. And then i can merge this.

I've finished formatting my code.

@DreamTeamWangbowen Do we need this btw? IIUC, the Marlin kernel is automatically used for GPTQ models when the condition is met (act_order=False, etc.).

Yes, we need it, I did not find the act_order parameter in the code and model configuration file.

Yes, we need it, I did not find the act_order parameter in the code and model configuration file.
The model address I use is https://huggingface.co/neuralmagic/Nous-Hermes-2-Yi-34B-marlin

@DreamTeamWangbowen IIUC, the Marlin kernel should be automatically used (without specifying quantization=marlin):
https://github.com/vllm-project/vllm/blob/654865e21df8ac6fe95de926625306e5756c2c0d/vllm/config.py#L174-L176
While the condition was not actually about act_order (sorry for the wrong information), the mode configuration file meets the above condition.

Yes, we need it, I did not find the act_order parameter in the code and model configuration file.
The model address I use is https://huggingface.co/neuralmagic/Nous-Hermes-2-Yi-34B-marlin

@DreamTeamWangbowen IIUC, the Marlin kernel should be automatically used (without specifying quantization=marlin):
https://github.com/vllm-project/vllm/blob/654865e21df8ac6fe95de926625306e5756c2c0d/vllm/config.py#L174-L176
While the condition was not actually about act_order (sorry for the wrong information), the mode configuration file meets the above condition.

If I do not specify marlin, but specify gptq, the following error will occur
File "/usr/local/lib/python3.10/dist-packages/vllm/config.py", line 130, in init
self._verify_quantization()
File "/usr/local/lib/python3.10/dist-packages/vllm/config.py", line 204, in _verify_quantization
raise ValueError(
ValueError: Quantization method specified in the model config (marlin) does not match the quantization method specified in the quantization argument (gptq).

Yes, we need it, I did not find the act_order parameter in the code and model configuration file.
The model address I use is https://huggingface.co/neuralmagic/Nous-Hermes-2-Yi-34B-marlin

@DreamTeamWangbowen IIUC, the Marlin kernel should be automatically used (without specifying quantization=marlin):
https://github.com/vllm-project/vllm/blob/654865e21df8ac6fe95de926625306e5756c2c0d/vllm/config.py#L174-L176
While the condition was not actually about act_order (sorry for the wrong information), the mode configuration file meets the above condition.

Look at the code here 178~185, there is a judgment here
           if self.quantization is None:                 self.quantization = hf_quant_method             elif self.quantization != hf_quant_method:                 raise ValueError(                     "Quantization method specified in the model config "                     f"({hf_quant_method}) does not match the quantization "                     f"method specified in thequantization argument "                     f"({self.quantization}).")

@DreamTeamWangbowen I think you can run your server without pass -q or --quantization args since vLLM will detect quant method from config.json.

@DreamTeamWangbowen I think you can run your server without pass -q or --quantization args since vLLM will detect quant method from config.json.

Yes, but if the quantization parameter is specified as gptq or marlin, an error will occur when the server is running.

@DreamTeamWangbowen
Marlin kernels use a special serialization method that are different from exllama. So the model must be saved on disk in Marlin format to be loaded by vLLM. vLLM currently does not support converting formats on the fly (though this is something we are working on). The model must be saved to disk in Marlin format to run in vLLM.
I added the functionality to save models in Marlin format to AutoGPTQ. Here's an example here:

https://github.com/robertgshaw2-neuralmagic/marlin-example/blob/master/apply_gptq_save_marlin.py

Also here's a model I saved in this format:

https://huggingface.co/neuralmagic/zephyr-7b-beta-marlin

I will add a doc to vLLM about this
Note --> Marlin currently requires group_size=128 act_order=False. We are working on expanding this
@WoosukKwon FYI

@DreamTeamWangbowen
Marlin kernels use a special serialization method that are different from exllama. So the model must be saved on disk in Marlin format to be loaded by vLLM. vLLM currently does not support converting formats on the fly (though this is something we are working on). The model must be saved to disk in Marlin format to run in vLLM.
I added the functionality to save models in Marlin format to AutoGPTQ. Here's an example here:

https://github.com/robertgshaw2-neuralmagic/marlin-example/blob/master/apply_gptq_save_marlin.py

Also here's a model I saved in this format:

https://huggingface.co/neuralmagic/zephyr-7b-beta-marlin

I will add a doc to vLLM about this
Note --> Marlin currently requires group_size=128 act_order=False. We are working on expanding this
@WoosukKwon FYI
Passing marlin to this argument will not work

yeath, the model I use is in marlin format https://huggingface.co/neuralmagic/Nous-Hermes-2-Yi-34B-marlin

@DreamTeamWangbowen
Marlin kernels use a special serialization method that are different from exllama. So the model must be saved on disk in Marlin format to be loaded by vLLM. vLLM currently does not support converting formats on the fly (though this is something we are working on). The model must be saved to disk in Marlin format to run in vLLM.
I added the functionality to save models in Marlin format to AutoGPTQ. Here's an example here:

https://github.com/robertgshaw2-neuralmagic/marlin-example/blob/master/apply_gptq_save_marlin.py

Also here's a model I saved in this format:

https://huggingface.co/neuralmagic/zephyr-7b-beta-marlin

I will add a doc to vLLM about this
Note --> Marlin currently requires group_size=128 act_order=False. We are working on expanding this
@WoosukKwon FYI
Passing marlin to this argument will not work

yeath, the model I use is in marlin format https://huggingface.co/neuralmagic/Nous-Hermes-2-Yi-34B-marlin

Nice - vllm will use marlin by default if you pass this model. You do not need to pass the --quantization argument explicitly

@DreamTeamWangbowen
Marlin kernels use a special serialization method that are different from exllama. So the model must be saved on disk in Marlin format to be loaded by vLLM. vLLM currently does not support converting formats on the fly (though this is something we are working on). The model must be saved to disk in Marlin format to run in vLLM.
I added the functionality to save models in Marlin format to AutoGPTQ. Here's an example here:

https://github.com/robertgshaw2-neuralmagic/marlin-example/blob/master/apply_gptq_save_marlin.py

Also here's a model I saved in this format:

https://huggingface.co/neuralmagic/zephyr-7b-beta-marlin

I will add a doc to vLLM about this
Note --> Marlin currently requires group_size=128 act_order=False. We are working on expanding this
@WoosukKwon FYI
Passing marlin to this argument will not work

yeath, the model I use is in marlin format https://huggingface.co/neuralmagic/Nous-Hermes-2-Yi-34B-marlin

Nice - vllm will use marlin by default if you pass this model. You do not need to pass the --quantization argument explicitly

Yes, the marlin model I am using is act_order=True and group_size=128.
But I understand that the -q parameter does not tell vllm to specify the type of quantization method used, such as awq, gptq, so I added marlin

@DreamTeamWangbowen IIUC, Marlin is not a quantization method. It's a fast kernel implementation for GPTQ.
I've updated the PR so that it fixes the bug that quantization="gptq" raises an error when Marline is enabled.

@DreamTeamWangbowen IIUC, Marlin is not a quantization method. It's a fast kernel implementation for GPTQ.
I've updated the PR so that it fixes the bug that quantization="gptq" raises an error when Marlin is enabled.

Yeath, you are right, thank you very much.


video format

Is it possible to generate videos in another format rather than 3gpp (e.g. mp4)?

It seems that even passing the extension (e.g mp4), it keeps saving 3gpp on android.

It saves it as what the phone takes. There is an open bug about the file format which it saves it as already.


Shouldly message should be more useful

The code:
var logs = _logger.GetLogs();
logs.ShouldBeEmpty();

failed a test with:

Shouldly.ShouldAssertException
logs
    should be empty but had
1
    item and was
[Stravaig.Extensions.Logging.Diagnostics.LogEntry (13278513)]

Fix the way that the log entry is rendered so Shouldly gives a more useful message.

PR merged into main


BUG: honor MACOSX_DEPLOYMENT_TARGET

Signed-off-by: Filipe Laíns<EMAIL_ADDRESS>

Should we also fallback to sysconfig.get_config_var('MACOSX_DEPLOYMENT_TARGET')?

@rgommers thoughts on this? I am unsure about the implications.

I was just looking at it. I think this is correct as is. I do not think we need to use sysconfig.get_config_var('MACOSX_DEPLOYMENT_TARGET'). That is the platform for which the Python interpreter was built. I don't see a reason why that would be relevant.

Alright, thanks!

Let me try to play with this a bit locally. I want to make sure that I understand where the original input comes from.

Okay. distutils/setuptools does fallback to it, that's why I was asking.
https://github.com/pypa/setuptools/blob/a86428cfef419e9ef3f04a04bde2d64d395936b8/setuptools/_distutils/util.py#L88
After looking into it a bit more, I think we only have to mimic Meson's behavior though.

Ah I see, right now we start from sysconfig.get_platform(). That does not look correct to me. On my machine, which is on macOS 12.4:
>>> sysconfig.get_platform()
'macosx-11.0-arm64'

The logic should probably be:

If MACOSX_DEPLOYMENT target is set, honor that
Otherwise, build for the current OS version (to check if minor versions are to be taken into account or not)

Otherwise we get strange issues when we different Python interpreters are built for different targets. What needs checking first though is how Meson makes its choices. Because in the end the tags need to match what the packaged extension modules are actually built for.

This is a little nontrivial, we should add to the docs how this works. We discussed this previously in https://github.com/FFY00/meson-python/issues/91#issuecomment-1175477386.
There is more to it though. MACOSX_DEPLOYMENT_TARGET is an environment variable, it has to be translated to what a compiler understands somewhere. There are differences per compiler:

GCC actually honors MACOSX_DEPLOYMENT_TARGET itself, no flag needed
Clang does not, it wants a flag: --macosx-version-min
For other compilers, YMMV

On modern macOS systems, Clang is the default and is what the majority of folks are going to be building with. Extra complication: Clang has no good Fortran compiler, so we often end up with clang/clang++/gfortran as a combo. Which may explain build warnings about target mismatches I've been seen in the SciPy builds.
So that leaves the question for Clang: who is going to be translating the env var to a compiler flag? There's various options:

Meson does nothing here
CMake does: https://cmake.org/cmake/help/latest/envvar/MACOSX_DEPLOYMENT_TARGET.html
It may also be compiler packagers; conda-forge does handle the env var in its activation script for Clang: https://github.com/conda-forge/clang-compiler-activation-feedstock/blob/b52f54576e9947e65196adef73ee5d550eafe1f1/recipe/activate-clang.sh#L101. What is done there is:

if [ "${MACOSX_DEPLOYMENT_TARGET:-0}" != "0" ]; then
  CPPFLAGS_USED="$CPPFLAGS_USED -mmacosx-version-min=${MACOSX_DEPLOYMENT_TARGET}"
fi

_CMAKE_ARGS="${_CMAKE_ARGS} -DCMAKE_OSX_DEPLOYMENT_TARGET=${MACOSX_DEPLOYMENT_TARGET}"

I don't know why it only adds -mmacosx-version-min to clang++ and not to clang.
So I think that we cannot know for sure what will happen when MACOSX_DEPLOYMENT_TARGET is not set. Most likely, the build does not use any SDK and is therefore for the local OS version. If the env var is set, then we should assume that it is honored somewhere, and this is up to the compiler & compiler packager to do.
What the deployment target for the Python interpreter was at the time that that interpreter was built should not be relevant at all for us. That distutils code was probably written with the assumption that everyone is only using the python.org provided Python, and hence let's all target that. But that's a bad assumption.

We could potentially just set MACOSX_DEPLOYMENT to the sysconfig value when invoking Meson if not set, this would force Meson to target that version and would, I hope, override any fallback logic they may have. What do you think?

Given what I wrote above about how MACOSX_DEPLOYMENT_TARGET is translated into -mmacosx-version-min for Clang, I don't think that will do anything as of right now. The compiler activation script has already run. We may want to check if Meson should start handling the env var - that would probably be a good idea. After that is done, we could potentially do what you suggest here.

I'm still not sure if we should be doing that though. At that point, it becomes impossible to build a wheel only for the current OS version - which is what should be fastest and most performant. If you build for yourself, you don't want to have compat shims or older versions of functions linked in for you.
The right design I think is to build for the current OS version, and redistributors should explicitly target the minimum OS they want or can support. We already had problems with what setuptools does now in SciPy - we need macosx_12_0_arm64 wheels because 11.0 did not work. But setuptools doesn't listen, so we manually have to rename the wheels afterwards.

For pypa/build to set MACOSX_DEPLOYMENT_TARGET is perhaps more reasonable, because that is often the tool of choice for packagers. However, we don't want pip install . to target older versions.

Given what I wrote above about how MACOSX_DEPLOYMENT_TARGET is translated into -mmacosx-version-min for Clang, I don't think that will do anything as of right now.

IIRC from my previous research about this, clang did used to honor MACOSX_DEPLOYMENT_TARGET but started not to in newer versions in favor of -mmacosx-version-min.

The compiler activation script has already run.

I don't follow, we can set this env var before running Meson.

We may want to check if Meson should start handling the env var - that would probably be a good idea.

Agreed.

After that is done, we could potentially do what you suggest here.

Given that GCC already does respect it, and if I am correct older Clang versions too, I think if we want to do this, we can start doing it right now. I think MACOSX_DEPLOYMENT_TARGET not being considered for clang should essentially be as a Meson bug.

However, we don't want pip install . to target older versions.

Why not? Older version should be compatible with newer ones AFAIK.

I don't follow, we can set this env var before running Meson.

Activation scripts are run on environment activation, not each time the binary for the compiler is called.

Why not? Older version should be compatible with newer ones AFAIK.

It's extra overhead and compile flags, and possibly lower performance. It's also not good design from first principles. If I'm building on my system, for my OS, and not for redistribution (which is the vast majority of builds I think), a packaging library should not force me to target an older OS version.

I think MACOSX_DEPLOYMENT_TARGET not being considered for clang should essentially be as a Meson bug.

Yes, I agree. I need to verify with a non-conda Python/environment. We need it to be correct and consistent for at least python.org installers, system Python, conda and Homebrew.

If Meson doesn't handle this correctly, this PR itself will be problematic.

This PR does improve things (it will fix things for conda-forge and probably also for Homebrew clang), but yes it's still wrong.

Did some testing:
# Homebrew clang was already installed; can be done with `brew install llvm`
% export MACOSX_DEPLOYMENT_TARGET=11.4
% export CC=/opt/homebrew/Cellar/llvm/14.0.6_1/bin/clang
% export CXX=/opt/homebrew/Cellar/llvm/14.0.6_1/bin/clang++
%<EMAIL_ADDRESS>install ninja
% cd ~/code/meson/test cases/osx/1 basic
% meson setup build

Then searching build/build.ninja shows no -mmacosx-version-min version used. Full output:

# This is the build file for project "osx fundamentals"
# It is autogenerated by the Meson build system.
# Do not edit by hand.

ninja_required_version = 1.8.2

# Rules for module scanning.

# Rules for compiling.

rule c_COMPILER
 command = /opt/homebrew/Cellar/llvm/14.0.6_1/bin/clang $ARGS -MD -MQ $out -MF $DEPFILE -o $out -c $in
 deps = gcc
 depfile = $DEPFILE_UNQUOTED
 description = Compiling C object $out

# Rules for linking.

rule c_LINKER
 command = /opt/homebrew/Cellar/llvm/14.0.6_1/bin/clang $ARGS -o $out $in $LINK_ARGS
 description = Linking target $out

# Other rules

rule CUSTOM_COMMAND
 command = $COMMAND
 description = $DESC
 restat = 1

rule REGENERATE_BUILD
 command = /Users/rgommers/mambaforge/bin/meson --internal regenerate '/Users/rgommers/code/meson/test$ cases/osx/1$ basic' '/Users/rgommers/code/meson/test$ cases/osx/1$ basic/build'
 description = Regenerating build files.
 generator = 1

# Phony build target, always out of date

build PHONY: phony

# Build rules for targets

build prog.p/main.c.o: c_COMPILER ../main.c
 DEPFILE = prog.p/main.c.o.d
 DEPFILE_UNQUOTED = prog.p/main.c.o.d
 ARGS = -Iprog.p -I. -I.. -fcolor-diagnostics -Wall -Winvalid-pch -O0 -g

build prog: c_LINKER prog.p/main.c.o
 LINK_ARGS = -Wl,-dead_strip_dylibs -Wl,-headerpad_max_install_names -Wl,-undefined,error

# Test rules

build test: phony meson-internal__test

build meson-internal__test: CUSTOM_COMMAND all PHONY
 COMMAND = /Users/rgommers/mambaforge/bin/meson test --no-rebuild --print-errorlogs
 DESC = Running$ all$ tests.
 pool = console

build benchmark: phony meson-internal__benchmark

build meson-internal__benchmark: CUSTOM_COMMAND all PHONY
 COMMAND = /Users/rgommers/mambaforge/bin/meson test --benchmark --logbase benchmarklog --num-processes=1 --no-rebuild
 DESC = Running$ benchmark$ suite.
 pool = console

# Install rules

build install: phony meson-internal__install

build meson-internal__install: CUSTOM_COMMAND PHONY | all
 DESC = Installing$ files.
 COMMAND = /Users/rgommers/mambaforge/bin/meson install --no-rebuild
 pool = console

build dist: phony meson-internal__dist

build meson-internal__dist: CUSTOM_COMMAND PHONY
 DESC = Creating$ source$ packages
 COMMAND = /Users/rgommers/mambaforge/bin/meson dist
 pool = console

# Suffix

build ctags: phony meson-internal__ctags

build meson-internal__ctags: CUSTOM_COMMAND PHONY
 COMMAND = /Users/rgommers/mambaforge/bin/meson --internal tags ctags '/Users/rgommers/code/meson/test$ cases/osx/1$ basic'
 pool = console

build uninstall: phony meson-internal__uninstall

build meson-internal__uninstall: CUSTOM_COMMAND PHONY
 COMMAND = /Users/rgommers/mambaforge/bin/meson --internal uninstall
 pool = console

build all: phony meson-test-prereq meson-benchmark-prereq prog

build meson-test-prereq: phony prog

build meson-benchmark-prereq: phony

build clean: phony meson-internal__clean

build meson-internal__clean: CUSTOM_COMMAND PHONY
 COMMAND = /opt/homebrew/bin/ninja -t clean
 description = Cleaning

build build.ninja: REGENERATE_BUILD ../meson.build meson-private/coredata.dat
 pool = console

build reconfigure: REGENERATE_BUILD PHONY
 pool = console

build ../meson.build meson-private/coredata.dat: phony

default all

Now what I can't check is if the produced binary works on an older OS version. It shouldn't though.

I guess a pain point is that MACOSX_DEPLOYMENT_TARGET used to be honored by XCode / Apple tools, but is no longer. It seems that Apple has decided that it's not a thing. So what we are left with is a lot of outdated info, and an environment variable that is basically specific to GCC and some build/packaging tools that support it in an inconsistent way (CMake/distutils/conda-forge do, Make/Meson/Clang/Homebrew/XCode do not).
Having every project reinvent the wheel by passing a compiler flag is not a reasonable thing to do I think. So it has to be handled somewhere, somehow. Argh ....

 I think the assumption made there is that users should pass the right compiler flags. But that's going to be a major pain.
xref https://cibuildwheel.readthedocs.io/en/stable/cpp_standards/#macos-and-deployment-target-versions for some useful info

The cibuildwheel link above shows another problem with always setting it to an older version: you may break usage of modern C++ standard. The page shows what is needed up to C++17, but probably C++20 requires something newer than what sysconfig.get_platform() returns.


do you have the yolo3 classify example

do you have the yolo3 classify example

What exactly do you mean by that?

i would like to predict with the model of darknet19 network, it is only a classify network,
but i can not find a example that how to call the model to predict

I think you must ask this question by https://github.com/AlexeyAB/darknet
This project is a wrapper project.


Improved UI: Shadows, buttons, table, card width

This PR adds improvements for a more natural and clean UI. Also fixed some bugs.
Related to #5

@agonzalezio Please provide screenshots of what you did comparing before and after :smile:

You can preview the changes in the deploy preview: https://deploy-preview-7--hackrcdu.netlify.app/
Basically: added more whitespace between sections, added more natural shadows to cards (the old ones were too darken), added hover transitions on button and theme cards, adjusted some widths to be responsive on mobile, and removed some unused CSS.
BTW, when designing for mobile you should only add the changing properties inside the @media elements, when you copy the entire desktop properties and modify or add some for mobile, it's more dificult to edit and maintain, because you must edit the same styles two times; ej. for changing card's with or background.

@agonzalezio Thank you for your contributions 👍🏻


code review: remove deprecated @Service annotation in java doc or comment.

[x] I have searched the issues of this repository and believe that this is not a duplicate.
[x] I have checked the FAQ of this repository and believe that this is not a duplicate.

Environment

Dubbo version: xxx
Operating System version: xxx
Java version: xxx

Steps to reproduce this issue
remove @Service in java doc or comment instant of @DubboService
Pls. provide [GitHub address] to reproduce this issue.
Expected Result
What do you expected from the above steps？
Actual Result
What actually happens?
If there is an exception, please attach the exception trace:
Just put your stack trace here!

by the way, when to remove @Service annotation?  in 3.0 or the further branch?


[FEATURE] Service first workflow

Is your feature request related to a problem? Please describe.
A clear and concise description of what the problem is. Ex. I'm always frustrated when [...]
When use a service
mysvcv1.NewProviderService("provider-server-name", client)

but the consumer do not care provider-server-name or provider-alt-server-name, the service name is already know hen gen grpc
var ProviderService_ServiceDesc = grpc.ServiceDesc{
        // micro should allowed registry by this service name
	ServiceName: "wener.mysvc.v1.ProviderService",
}

ignore the provider server name make micro more service oriented.
Describe the solution you'd like
A clear and concise description of what you want to happen.
use grpc ServiceName, per service registry entry.
same service can provided by different server.
mysvcv1.NewProviderService(client)

micro gen should include some basic metadata.
Additional context
Add any other context or screenshots about the feature request here.

@xpunch what do you think?

The grpc do provide ServiceDesc, but it only intended for direct use with grpc.RegisterService(Source).
So it only used to handle single service defined in proto files, which already implemented by go micro.
The service name in go micro is used to handle service registration and service discovery, and a micro service may provide multiple grpc services, so use grpc.ServiceDesc as service name is not acceptable, which I think is a misunderstand between micro service name and grpc service name.

micro's server is a set of services, but when consuming service, consumer should not care the producer's server name.
micro should provide a way for consuming service by FQDN, like in java world, every service is identified by a FQDN name, e.g com.wener.crm.CustomerService.
current registry is based on server name, but should be ok to support service name ?

What do you mean:

current registry is based on server name, but should be ok to support service name ?

manually register service by FQDN, consuming by FQDN, like
registry.Register(&registry.Service{
    Name: agentv1.AgentService_ServiceDesc.ServiceName,
})
as := agentv1.NewAgentService(agentv1.AgentService_ServiceDesc.ServiceName, client.DefaultClient)

not tested.

I still don't think we should support this.

As I said, a micro service may provide multiple grpc service, there is no need to register every single grpc services.
Same grpc service can provide different service with different configuration, ServiceDesc.ServiceName cannot always represents the real service.
As I know, in spring cloud service name is defined by developers in poml files.

I used to work in java env, really like consuming service by interface, interface imply the destination service name.
like in dubbo https://dubbo.apache.org/en/docs/v2.7/user/recommend/
<dubbo:service interface="com.alibaba.hello.api.HelloService" version="1.0.0" ref="helloService"
    timeout="300" retry="2" loadbalance="random" actives="0"
/>

this xml consume com.alibaba.hello.api.HelloService .
nowadays, grpc is the interface.

I think what @xpunch is trying to say is the model differs here. We treat grpc services as handlers and the service name could differ. With grpc you still have to register against a server and the client has to dial a destination. We use service names to resolve that so you're just doing it by name.
If we removed that it would 1. Be backwards incompatible and 2. Would lose the ability to specify multiple handlers on one service because the client code wouldn't allow for calling I'm happy to potentially accept some new signature function that lets you do it without names but just noting it should clash with any existing functions or grpc generated functions.

As I said, you misunderstand the grpc service name and micro service name.
The "grpc service name" is implemented by go micro in (different way)[https://github.com/asim/go-micro/blob/c5be9f560cdbc478130ee9e45d8906295f8b478f/plugins/server/grpc/handler.go#L28], clients do not care grpc service name, what the client need to care is micro service name.
go micro service name is more like:
<dubbo:application name="myalibaba" >

Yes, I know current micro's server & service, this is a feature request or proposal, wandering how to make micro work in this situation.
Like micro's registry can index grpc Endpoint of service, when GetService told to find by grpc service name, return the correct registry.Service .
This is just some thoughts.

Well if you have some ideas, feel free to show us example code of how it would work without breaking backwards compatibility


Enable support for WSSC

This change adds support for WSSC which is an IBM Websphere product that acts as a reverse proxy

+1, this looks good

@mbarlock, thanks for the PR!


How can I scale the SVGView?

I'm using the following code to scale up the svg file:
`class SVGExampleView: MacawView {
required init?(coder aDecoder: NSCoder) {
    super.init(node: SVGParser.parse(path: "Animals/duck50x50")!, coder: aDecoder)

    self.transform = CGAffineTransform(scaleX: 5, y: 5)
}

}`
But I get a pixelated image

How can I scale properly because form what I know svg should scale without loosing any quality.

@karimfikani thanks for using Macaw! To scale without losing quality you have to use Macaw transformations:
class SVGExampleView: MacawView {
	required init?(coder aDecoder: NSCoder) {
        	let duck = SVGParser.parse(path: "duck")!
        	duck.place = .scale(sx: 2, sy: 2)
		super.init(node: duck, coder: aDecoder)
	}
}

For more info you can check Transform section in Getting started guide.

@karimfikani please let me know if any questions remain. I will close this issue for now.

Scaling a Shape doesn't seem to change the bounds of it. is there a way?

Hi Kevin,
Shape.bounds is not affected by a node's place. If you want to apply transformation, if you may use following code:
let bounds = shape.bounds!.applying(shape.place)

P.S. it's better to create a new issue for a question, otherwise it might be missed.


Add New ProtobufEncodingMode for Nullable and Google-Compatible Types

Add ProtobufEncodingMode

VERTX_NULLABLE,
In this encoding mode, the converter uses a non-standard protobuf encoding to allow boxed types (e.g., Integer, Double) and String to be nullable. This encoding mode is intended for use when communicating with another Vert.x converter that supports nullable values.

GOOGLE_COMPATIBLE
In this encoding mode, the converter uses the standard protobuf encoding, which is compatible with Google's protobuf ecoder. Null values are not allowed for boxed types and String in this mode.

is this ready for review @lwlee2608 ?

@vietj yes


Duplicate package for Apache Kafka

Hi,
While updating the version for the Apache Kafka package that I maintain, I noticed a duplicate of this package was added recently.
apache-kafka (original):
https://github.com/NixOS/nixpkgs/blob/master/pkgs/servers/apache-kafka/default.nix
(also used by the nixos service: https://github.com/NixOS/nixpkgs/blob/master/nixos/modules/services/misc/apache-kafka.nix)
kafka (duplicate):
https://github.com/NixOS/nixpkgs/blob/master/pkgs/servers/kafka/default.nix
The latter was added in this PR:
https://github.com/NixOS/nixpkgs/pull/6121
I'm not sure what the policy for this is but having duplicate packages seem confusing.

Actually it's in pkgs/servers/apache-kafka/default.nix and pkgs/servers/kafka/default.nix.

@iElectric Yeah, original issue had incorrect link, have updated since.

Reverting servers/kafka.


Power BI Automation (tools): "This extension is not installable on any currently installed products."

The download is not working. We believe we have the necessary installations (Report Builder, Desktop). Is there something else we need installed before this download to be able to use the extension?
dd_VSIXInstaller_20220616145303_46f0.log
Thanks,
Mike Mc

Hi @mmccarthy19, seems like you are trying to install this on your computer
this extension is for Azure DevOps to provide custom tasks to be run on Azure DevOps Pipelines / releases.


annotations per segment are not fetched, if meta injection is not present

The meta injection is considered optional and it is a dead end road. However, fetching the annotations per segment is done on the meta payload of the post message event from the shown document.
Find better hook to fetch the annotations per segment.

added to epic SCDH&21


mesh shader example

could you add an example to show how to use mesh shader,thanks a lot

Thanks for the suggestion.  Mesh shader example has been added to the list of samples for future consideration.  In the meantime, NVIDIA has a nice example on Github here: https://github.com/nvpro-samples/gl_vk_meshlet_cadscene.  You can also find examples on Geeks3D.

Also please add HLSL for this example

We now have a mesh shading example, and another one doing mesh shader culling is in the works (see #624).
HLSL support is also being worked on, but will require large changes to the framework.


Adding support for elementary OS distro in install script.

I've tried not hard coding the corresponding Ubuntu versions, but as far as I know and I've researched, there's no way to do that without hard coding. I've asked this first at: http://elementaryos.stackexchange.com/questions/761/determine-base-ubuntu-version/766#766
NodeSource has hard coded it at: https://github.com/nodesource/distributions/blob/master/deb/setup_0.12
So, here you are support for elementary OS distro in installer script. It supports all currently existing elementary OS versions and has been tested in my elementary OS 0.3 (freya) platform.

Please sign your commits following these rules:
https://github.com/docker/docker/blob/master/CONTRIBUTING.md#sign-your-work
The easiest way to do this is to amend the last commit:
$ git clone -b "master" git@github.com:fmoliveira/docker.git somewhere
$ cd somewhere
$ git commit --amend -s --no-edit
$ git push -f

Ammending updates the existing PR. You DO NOT need to open a new one.

Sorry, I've skipped the contributing guidelines. I'll read the rules and amend my PR. Thanks for the notes.

What do you think of this @jfrazelle ?

Please wait. Someone have answered me at Stack Exchange about a form to do this without hard coding the base versions. I'll amend my pull request as soon as I've finished it.

I'm unable to reopen this pull request because I've force-pushed my branch.
A new pull request has been opened at #15001.


Objective-c version

Is objective-c compatibile?

Of course, you can install it to your project with cocoapods.
Just add the pod to your podfile
pod 'TVOSSlideViewController'


Get which client is you in usePresence

Right now there is only this information for each client:

but how do I find out which one is "me"?

Hey @ChocolateLoverRaj, thank you for reaching out and sorry for the late response! The best way to do this currently is to test against the PresenceMessage.clientId field. If you already know the clientId then it should be as simple as presenceData.find(x => x.clientId === myClientId). If you're using token authentication and the clientId is not known until after the token has been received then the best way to do this would be to pass in your own ably client:
import { useChannel, Realtime } from '@ably-labs/react-hooks'

const realtime = new Realtime(options);

const [presenceData] = usePresence({ channelName: "your-channel-name", realtime: realtime })

const myPresenceData = presenceData.find(x => x.clientId === realtime.auth.clientId);

Let me know if you have any further questions


add support for LSPS-based LSP's

Adds support for both Voltage and LSPS style LSP's.
If lsp_url configuration option is set, it adds voltage style lsp's as it does today.
If lsp_connection_string option is set, it adds lsps style lsp's.  If the lsps lsp requires a token then lsp_token must be set and the index of the token must match the index of the corresponding lsp_connection_string.  It's a little janky. One idea could be to incorporate the token into the connection_string... something like pubkey:token@ip:port and let it be optional when parsing.  This isn't standardized anywhere but might be a nice way to do it? Though it does go against the typical connection string someone might copy and paste from other software for their LSP (amboss/mempool.space/etc).  though maybe if someone's willing to go add a custom LSP they can handle this whereas most users will just use one of the predefined one's you guys populate in a list somewhere. I'll let you guys make final call on how to handle this.
The compute_opening_fee fn should be exported from the lightning-liquidity crate soon enough so we can remove the copy-pasted version here.
An alpha release of the crate is also expected to land shortly, not sure if we want to wait for that before merging something like this or if you guys are fine with keeping a dependency on a specific git commit for now.

Got that PR merged upsteam so I was able to simplify this significantly.  Now it's just the message handler, setting up the types, and instantiating the liquidity manager.
Will do the actual implementation next.

needs rebase


Improve clang arm64 compile time

Alternative implementation of #1297 (see discussion in #1317)
clang's arm64 register allocator really doesn't like that giant switch statement, and making it codegen the switch statement tons of times as a part of a template function isn't helping.

Author etang-cw not on autobuild list. Waiting for curator authorization before starting CI build.

CI gfxreconstruct build queued with queue ID 67316.

CI gfxreconstruct build # 3406 running.

CI gfxreconstruct build # 3406 passed.


add support for 0 sized matrices in svd

closes #2371

I have tested it. The tests are passing.

Jenkins, test this please.

Jenkins CI test (for commit 0d40ad1cc99f482984ea8aac445a7660b63b4cc8, target branch master) succeeded!

LGTM!


Categorical data not surviving a repartition

When creating categorical columns with
df[column] = df[column].astype('category')
df = df.repartition(npartitions=n)

seems to result in partitions that have the old datatype for the column and one partition that has the correct category datatype.
This is with dask 15.2, I have not tested older versions.

This boils down to pd.concat not propagating categories when they don't match
In [1]: import pandas as pd

In [2]: df = pd.DataFrame({'x': [1, 2, 3, 4], 'y': ['a', 'b', 'a', 'c']})

In [3]: df2 = pd.DataFrame({'x': [1, 2, 3, 4], 'y': ['a', 'b', 'a', 'e']})

In [4]: df['y'] = df['y'].astype('category')

In [5]: df2['y'] = df2['y'].astype('category')

In [6]: df.dtypes
Out[6]:
x       int64
y    category
dtype: object

In [7]: df2.dtypes
Out[7]:
x       int64
y    category
dtype: object

In [8]: pd.concat([df, df2]).dtypes
Out[8]:
x     int64
y    object
dtype: object

@TomAugspurger is there a way around this?
(my test case for future use)
@pytest.mark.parametrize('npartitions', [1, 4])
def test_repartition_on_categoricals(npartitions):
    df = pd.DataFrame({'x': [1, 2, 3, 4], 'y': ['a', 'b', 'a', 'c']})
    ddf = dd.from_pandas(df, npartitions=2)
    ddf['y'] = ddf['y'].astype('category')
    ddf2 = ddf.repartition(npartitions=npartitions)

    df = df.copy()
    df['y'] = df['y'].astype('category')
    assert_eq(df, ddf)
    assert_eq(df, ddf2)

Isn't that surprising from repartition, where the partitions were known beforehand and do not get recoded?

This might be fixed by replacing the calls to pd.concat with dask.dataframe.methods.concat (which handles mixed categories).

Yep, PR coming momentarily.

Thank you @jcrist

For reference, here's the pandas issue about concat and categoricals https://github.com/pandas-dev/pandas/issues/14177 (we weren't sure whether unioning, converting to object, or raising was "correct").

Should be fixed by #2676.


External workloads - install-external-workload.sh

<!--

After using cilium cli to create install-external-workload.sh

the ./install-external-workload.sh on the VM just continually cycles *waiting for cilium daemon to come up"

Additionally looking at the install script, it doesn't populate the correct ip address and node port when using nodeport, it

CLUSTER_ADDR=${2:-ip:port}

In testing it is grabbing the wrong ip address of the port exposed, looks to be grabbing the control node which is not exposing that port, as the clustermesh api server is exposed on a different ip on the worker node.

I've tested using loadbalancer and it still cycles as well.

Hi @cccsss01, I'm closing this issue since it is empty. Feel free to reopen if not intentional.


Null Reference (Unity Player)

Describe the issue
I'm facing a Null Reference on the Sample scene.
I'm trying to use the Canvas player.
I haven't changed anything, just logged in, selected (from inside) recent videos, and took the last one.
The video is from our dev account and is private, with file access (I'm not sure if I've done it right).
Steps to reproduce the problem
Open the Canvas Player Canvas Screen.
Login with Token
Tried to reproduce my video:
https://vimeo.com/306040507/dd4982ae5c
I've noticed if I turn off autoplay, it just gives me the erros once I press Play.
Unity version
2018.2.13f1
Operating system
Windows 10

Hi @andersonaraujodl - sorry for the trouble. This is actually the same issue that is reported here.
When developing/testing, I suggest using a token that is generated from the Get Token button in the Unity editor (or just click this link). This should fix your issue.
Since you are using your own Vimeo developer app with your own token, you will need to make a patch to the VimeoVideo.cs to support the files API response.
I'm going to close this as it is a duplicate to #54

Thanks a lot for your reply!
By the way: great job you're doing on this! Congrats!


[Bug]: Strings cut - unplanned/undocumented behaviours

Apache Hop version?
2.10.0
Java version?
17.0.2
Operating system
Linux
What happened?
Undocumented behaviours:

Set Cut from = 0 or lower, Cut to = a value greater than the string length: the entire string will be returned
Set Cut from = greater than 0, Cut to = a value greater than the string length: the substring from the "Cut from" index (+1) to the end of the original string will be returned
Set Cut from = 0, Cut to = a negative number (e.g. -10): the substring composed of the last (10) characters will be returned

Unexpected behaviour:

Set Cut from and Cut to both negative (e.g. -10 and -5): NULL will be returned, even if Cut to is greater (lower absolute value) than Cut from -> probably a better choice should be returning the substring from length - (10) to length - (5)

Issue Priority
Priority: 3
Issue Component
Component: Documentation, Component: Transforms

The cutString logic:
private String cutString(String string, int cutFrom, int cutTo) {
    String rcode = string;

    if (!Utils.isEmpty(rcode)) {
      int lenCode = rcode.length();

      if ((cutFrom >= 0 && cutTo >= 0) && cutFrom > lenCode) {
        rcode = null;
      } else if ((cutFrom >= 0 && cutTo >= 0) && (cutTo < cutFrom)) {
        rcode = null;
      } else if ((cutFrom < 0 && cutTo < 0) && cutFrom < -lenCode) {
        rcode = null;
      } else if ((cutFrom < 0 && cutTo < 0) && (cutFrom < cutTo)) {
        rcode = null;
      } else {
        if (cutTo > lenCode) {
          cutTo = lenCode;
        }
        if (cutTo < 0 && cutFrom == 0 && (-cutTo) > lenCode) {
          cutTo = -(lenCode);
        }
        if (cutTo < 0 && cutFrom < 0 && (-cutTo) > lenCode) {
          cutTo = -(lenCode);
        }

        if (cutFrom >= 0 && cutTo > 0) {
          rcode = rcode.substring(cutFrom, cutTo);
        } else if (cutFrom < 0 && cutTo < 0) {
          rcode = rcode.substring(rcode.length() + cutTo, lenCode + cutFrom);
        } else if (cutFrom == 0 && cutTo < 0) {
          int intFrom = rcode.length() + cutTo;
          rcode = rcode.substring(intFrom, lenCode);
        }
      }
    }

    return rcode;
  }


fix: remove header from spec file

Description
Bug caused due to additional header.
Removed it for the time being.
Related issue(s)

#273

@aayushmau5 the header is in the original spec in spec repo, what is your approach for the future once we enable automation?

:thinking: Perhaps use JS in the automation to remove the # AsyncAPI Specification  line.

@aayushmau5 yup, in the action on spec 👍🏼


Add a namespace validation check to our CI scripts

Overview
Our AssetRetargetting phase in our CI build depends on all of our code to have a namespace. This isn't checked anywhere during PR validation, which means it's really easy to check in an error like this and then have it fail in a very un-understandable way once things have already been checked in for a while. On particularly crazy days this means that the build will probably get hosed for a while as you don't find out the error until your change has gotten through the queue and has finally run the ongoing CI.
This makes it so that we have some basic validation that there is SOME sort of namespace check (i.e. that it exists in the file). We don't check here that it necessarily begins with Microsoft.MixedReality.Toolkit in case there's ever some situation where we pull in some other code that needs to maintain its original namespace.
Changes

Fixes: https://github.com/microsoft/MixedRealityToolkit-Unity/issues/7699

/azp run

We don't check here that it necessarily begins with Microsoft.MixedReality.Toolkit in case there's ever some situation where we pull in some other code that needs to maintain its original namespace.

I think the AssetRetargeting step that fails when a namespace isn't defined also fails if the namespace isn't an "approved" one:
https://github.com/microsoft/MixedRealityToolkit-Unity/blob/67cc3a392ba81f91a0ab05d2a27556f148873f08/Assets/MRTK/Tools/MSBuild/Scripts/AssetScriptReferenceRetargeter.cs#L377-L381

Should this be going into stabilization?

/azp run

Should this be going into stabilization?

I opted to not move this there because I didn't think that there's a super high risk of adding new stuff to stabilization that would trigger this, and generally my default is go to mrtk_development.
In general you really could go either way though