Make output file name optional

To be able to just do
ttf2woff somefont.ttf

The main motivation to be that lazy is to easily convert many files at once:
for f in *.ttf ; do ttf2woff $f ; done

I understand reason, but don't like suggestion. In many cases lack of explicit output file means use of stdout. App-specific behaviour would be confusing (amount of added value does not worth it, IMO).


Docs(web, web-twig, web-react): Extend TextFields README.md about missing section inputWidth

coverage: 96.371%. remained the same
when pulling d788ea20b4d27adeb5f8f5470a1ff5ea306b3fe2 on docs/extend-textfield-readme-about-input-width-section
into 7cfdc205cfc5102a386fbca78c0956ac19bd8d7f on main.

We've discussed with @adamkudrna and we suggest slightly change the API.

do not set range between 2-4 characters for size, but enable to pass any numeric value (Web BC)
size property won't be used at all (Web BC), instead of it we will use inputWidth
extend React APIs about inputWidth (React feature)
inputWidth pass as custom property in Twig (Twig fix, see this comment)

We've discussed with @adamkudrna and we suggest slightly change the API.

do not set range between 2-4 characters for size, but enable to pass any numeric value (Web BC)
size property won't be used at all (Web BC), instead of it we will use inputWidth
extend React APIs about inputWidth (React feature)
inputWidth pass as custom property in Twig (Twig fix, see this comment)

Resulting CSS could look like this:
.TextField__input--customWidth {
    box-sizing: content-box;
    width: calc(
        var(--width, 3) * 1ch + var(--arrows-width, 0px)
    );
}


[Fix#9923] The alarm instance management interface is always in the loding state

Purpose of the pull request
Brief change log
close #9923
Verify this pull request
Manually verified the change by testing locally

@SnowMoon-Dev When a request error has been caught and logged, this operation is useless

@SnowMoon-Dev When a request error has been caught and logged, this operation is useless
Yes, I know, I think our current handling of exceptions is a bit simple. In order to cope with subsequent changes, I have added log printing, and I will modify it.

Codecov Report

Merging #9924 (b23e7b5) into dev (8562f6a) will decrease coverage by 0.00%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##                dev    #9924      +/-   ##
============================================
- Coverage     40.31%   40.31%   -0.01%
  Complexity     4532     4532
============================================
  Files           835      835
  Lines         33750    33750
  Branches       3727     3727
============================================
- Hits          13606    13605       -1
- Misses        18857    18858       +1
  Partials       1287     1287

Impacted Files
Coverage Δ

...r/plugin/task/sqoop/parameter/SqoopParameters.java
53.33% <0.00%> (-1.34%)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8562f6a...b23e7b5. Read the comment docs.

@songjianet make sure this issue also close #10207

Hi @SnowMoon-Dev, if you could solve one issue in one single PR, you should not separate them into two or more, unless the issue contain more than one issue

Hi @SnowMoon-Dev, if you could solve one issue in one single PR, you should not separate them into two or more, unless the issue contain more than one issue

Hi @SnowMoon-Dev, if you could solve one issue in one single PR, you should not separate them into two or more, unless the issue contain more than one issue

Okay, I know

@SnowMoon-Dev When a request error has been caught and logged, this operation is useless

I modified the relevant code, please help me review again


[Suggestion] Add "Icon detail" view

:information_source: If you're interested in this feature, please leave comment or add a :+1:

Kind of issue

[x] Feature
[ ] Bug
[ ] Design
[ ] Other, namely:

Description
As per this comment, add an "icon detail view". This would display a particular icon at a larger size and potentially give download options such as #31, #32, #33 for that particular icon, as seen in this example mockup.
I'm not sure how useful this is. The larger icon can be nice, but if that is the only benefit I'm not sure something like the mockup below is suitable. The icon-specific download options can be nice, but I would expect that everyone would nearly always want the same download option for all icons.
What it may allow us to do is things like:

Show everything that is already in the card (the SVG, color, brand guidelines URL, license name & URL)
Show aliases (https://github.com/simple-icons/simple-icons/issues/4797)
Show the SVG source URL
Show the brand website URL
Option to copy the brand name
Option to copy the brand slug
Option to copy the font class
Option to copy the font code point
Option to copy the entire SVG (even though that is already possible)
Option to copy the path data
Option to copy code to use in NPM
Download svgs in the brand color (https://github.com/simple-icons/simple-icons-website/issues/32)
Show the icon in a variety of sizes (https://github.com/simple-icons/simple-icons-website/issues/40)
More? (Suggestions are welcome)

I'm working on a project wich basically is a list of links, and it uses Simple Icons if one for the link is available. Because of that I sometimes just scroll through your icon list to look for inspiration for more useful links. When doing so I sometimes find logos I don't know. Then I wish there was a link to the website of that product or company to find more information. Would that be a good idea?

Thanks for the suggestion @alinnert, that is something we could include in this view, yes!
However, getting this data (the homepage of the brand for each brand) is not that straightforward as the main project doesn't track it (more on this below) so I'm not quite sure how we would go about implementing it.
For completeness, I believe we shouldn't keep track of this data. Every data point we track adds to the size of the project and ideally it is as small as possible. Storing the URL of a brand that is, by the definition of simple icons, popular seems illogical to me; it's popular so you should be able to find it just by searching its name.
In that regard, the redesign is actually already an improvement on the original. The new website allows you to select and copy the name, whereas the old one doesn't (at least not nicely) because it's part of a download link.

I just realized the array already includes a source property that's almost what I was asking for. I also didn't expect this to be part of the main project after what you've said. But I'd say including this information is close enough, maybe?
With "as small as possible" do you mean the overall collected data and time to manage all that? Or from a performance perspective because the array and space requirements grow bigger?
If it's the latter: In principle it would be possible to add more data per icon in the website project (that's similar to what I do in my project, just with a subset of the icons). Or a build step could map the array to a more basic version (that includes only title and hex). The latter is easier to manage I guess, but the size of the project itself grows again.

it's popular so you should be able to find it just by searching its name.

I don't think that's true for all names. Especially searching for names like bit, byte, RTL (If you don't know it: right-to-left?), Julia, Jasmine, Go (yes, no results about golang on the first page of Google results!), Ghost, Gitter (means grid or lattice in German), HERE, Hey, Highly, and other common words or names probably won't give you the desired results. Then I have to search for (just an example) "Gitter service" in hope that it is some kind of service and not a company or a code library or framework. Do you see what I mean?

I just realized the array already includes a source property that's almost what I was asking for. I also didn't expect this to be part of the main project after what you've said. But I'd say including this information is close enough, maybe?

Though it often lines up with what you're looking for, it is explicitly not indented for that (see the Contributing Guidelines) - it's just that many companies don't have branding guidelines and often their homepage is the best place to find an SVG of their logo. That said, it is definitely something I think we should include in whatever comes out of this issue :slightly_smiling_face:

With "as small as possible" do you mean the overall collected data and time to manage all that? Or from a performance perspective because the array and space requirements grow bigger?

If it's the latter: In principle it would be possible to add more data per icon in the website project (that's similar to what I do in my project, just with a subset of the icons). Or a build step could map the array to a more basic version (that includes only title and hex). The latter is easier to manage I guess, but the size of the project itself grows again.
Both (i.e. reduce "management" and space requirements). Of course we can map that data out if we want, in fact any extra data that appears in the data file - including the new guidelines field - is not published to NPM (as JavaScript, the datafile itself is publisehed in any case, but we don't advice importing that directly).
I do think we can add it, but I'm still personally still against it for the reason that the brands are supposed to popular (regardless of your last argument). I can give two reasons for this, but I don't think they are particularly satisfactory. The first is that I think we should keep to scope of this open source project limited, and making simple-icons a "discovery" tool is not something we should invest our time in. The second is that I don't see any value in the data field for anything other than this website (and other website with the same goal).
That said, this is just my point of view. If you still believe we should add this information to the project, or if you just want to open the discussion to a broader audience, do feel free to open an issue on this topic in the main project :slightly_smiling_face:

I don't think that's true for all names. Especially searching for names like bit, byte, RTL (If you don't know it: right-to-left?), Julia, Jasmine, Go (yes, no results about golang on the first page of Google results!), Ghost, Gitter (means grid or lattice in German), HERE, Hey, Highly, and other common words or names probably won't give you the desired results. Then I have to search for (just an example) "Gitter service" in hope that it is some kind of service and not a company or a code library or framework. Do you see what I mean?

Fair enough, can't say anything against that really. But, as per what I said before, I don't think this project is intended for "discovery" so it doesn't seem to big a problem to me personally.

Alright. Then I'm also for the inclusion of the source and guideline fields in the detail view. Even if it's not intended for discovery, it's still a very helpful starting point. (btw: to me personally the original website is not important, I just wanted a hint in the right direction so I know what a logo or name is referring to. I didn't plan to use that url in my project because I add even more data than that and it's not always a 1:1 match.) On the other hand those guidelines sure are also of potential interest for other users of Simple Icons.

On the other hand those guidelines sure are also of potential interest for other users of Simple Icons.

Agreed, see https://github.com/simple-icons/simple-icons/issues/4900 :+1:

I think this is becoming increasingly necessary with all we're planning to add to the project and packages; trying to display everything on the cards is going to cause too much clutter. We could, as one example, show the slug here and/or the code to retrieve the icon through NPM. Another feature could be providing more options for for copying - see the sidebar on https://petershaggynoble.github.io/MDI-Sandbox/ for some possible examples.

I think this is becoming increasingly necessary with all we're planning to add to the project and packages; trying to display everything on the cards is going to cause too much clutter.

So far, i.e. with only guidelines and licenses, it is still manageable I think.
With the addition of custom slugs and https://github.com/simple-icons/simple-icons/pull/5002, including slugs in the card may get a bit messy.
Regarding aliases, I think it depends what we want but my take is that it won't effect the design of the cards much. Namely:

Duplicates: can be displayed as separate card, just with the same SVG.
Localisation: can be a global option, if your localisation matches for an icon, than we can display the localised name (admittedly, this may cause confusion w.r.t. the slug, so we should definitely display that on the website if we choose to do this)
Also known as: should be limited to search and hidden from the user.
Old: should either be ignored altogether or limited to search and hidden from the user.

Any other things we're planning to add that I'm forgetting here?

or the code to retrieve the icon through NPM. Another feature could be providing more options for for copying - see the sidebar on https://petershaggynoble.github.io/MDI-Sandbox/ for some possible examples.

Those are some interesting ideas, nice :+1:

Is this supppaes to be a separate page or a modal? And what's the trigger, a click on the icon? I suppose that does away with the copy button. Or should both buttons be kept?
We are going to need design suggestions here to proceed to coding this feature.
@PeterShaggyNoble @ericcornelissen @adamrusted @mondeja @sachinraja

I like the sidebar design in https://github.com/simple-icons/simple-icons/issues/980#issuecomment-547591284 and I think that would be a great way to proceed. I think we can do away with the copy button and instead include that next to the download options.

I like the sidebar design in simple-icons/simple-icons#980 (comment) and I think that would be a great way to proceed. I think we can do away with the copy button and instead include that next to the download options.

a sidebar that moves the layout of the tickets, or that slides out on top of the page?

I think one that slides out on top of the page would be fine.

I think one that slides out on top of the page would be fine. Layout shift is not ideal.

agreed. Thank you


New image for README

Generated this image via the Google Collab sheet and I was really impressed. Thought it'd fit in well.

Sorry, inexperienced github guy here: How does this work? I do have very interesting image I'd like to share. But neither can I see your image nor can I seemingly upload one. :(

Sorry, inexperienced github guy here: How does this work? I do have very interesting image I'd like to share. But neither can I see your image nor can I seemingly upload one. :(

Essentially I forked my own branch in the top right, uploaded my image to the samples directory, modified the README to include it and then created a pull request.
If you want to see the image then click on the "Update README.md" commit just above your comment and click "Display the rich diff".


BUG: read_pickle and period data

I can pickle dataframes with periods but after import Period format becomes corrupted. After pickle Period stride appears to be none instead of 'Q' in the following example.

import pandas as pd

df = pd.DataFrame({'period': [pd.Period('2014Q4')] * 5})
msk = df['period'] == pd.Period('2014Q4')
print msk

df.to_pickle('tmp.pkl')
df = pd.read_pickle('tmp.pkl')

msk = df['period'] == pd.Period('2014Q4')

Traceback (most recent call last):
  File "/Users/scarrucciu/Downloads/period_pickle_test.py", line 11, in
    msk = df['period'] == pd.Period('2014Q4')
  File "/Users/scarrucciu/anaconda/lib/python2.7/site-packages/pandas/core/ops.py", line 614, in wrapper
    res = na_op(values, other)
  File "/Users/scarrucciu/anaconda/lib/python2.7/site-packages/pandas/core/ops.py", line 562, in na_op
    result = lib.scalar_compare(x, y, op)
  File "pandas/lib.pyx", line 696, in pandas.lib.scalar_compare (pandas/lib.c:12434)
  File "das/src/period.pyx", line 743, in pandas._period.Period.__richcmp__ (pandas/src/period.c:11121)
ValueError: Cannot compare non-conforming periods

INSTALLED VERSIONS
commit: None
python: 2.7.6.final.0
python-bits: 64
OS: Darwin
OS-release: 13.4.0
machine: x86_64
processor: i386
byteorder: little
pandas: 0.16.2

ATM, Period doesn't have ANY pickle support so not really sure what it is doing.
pull-requests are welcome! (basically need to add __reduce__/__setstate__), see for example pandas/tslib.pyx/Timestamp on how to do it.
Also not tested. PeriodIndex has support for this, but I don't think tested either.


installing yarn completions under .local/share/bash-completion fails

I'm uncertain if this issue should be files under bash-completion or on this directory, or possibly somewhere else. I already created an issue under bash-completions so I'm going to paste that link here in case it is actually related to this repo: https://github.com/scop/bash-completion/issues/416

Okay, so after digging around, it was due to my own lack of understanding. I was using wget instead of curl and misread the curl options. Sorry for the bother. Everything seems to be fine.


Add SecTrustSettings bindings

This allows a consuming crate to enumerate macos trusted certificates via SecTrustSettingsCopyCertificates, and then learn whether they're suitable for use in TLS via SecTrustSettingsCopyTrustSettings.
I've done some manual testing of this by twiddling keychain trust settings and observing the results.
Sample calling code is here if you're interested: https://github.com/ctz/rustls-native-certs/blob/master/src/macos.rs

Thanks for the time you spent reviewing this. I think I've addressed all your comments in some remedial commits; let me know if you prefer these to be squashed.

Great. Thank you!


textcomplete crashes when the replace value equals the current value

To reproduce, register a strategy without any tags and write out the full word suggested by textcomplete. If the suggested word is selected and if it equals the string that would replace it, textcomplete crashes the browser.
This is my strategy:
 textcomplete.register([{
        match: /(\s|^)([A-Za-z\-\,\s]+)$/i,
        search: function (term, callback) {
          callback(dictionary.filter(card => {
            return card.startsWith(term);
          }));
        },
        replace: function (value) {
          return '$1' + value;
        }
      }]);

Other minor issues I've been facing are that flags are not working on the regex. Like above, the case insensitivity flag i is not registered by the matcher. Another issue is that when textcomplete has started suggesting words, there is no way of stopping the suggestions other than selecting an item in the dropdown list. It would be better if textcomplete stops matching if a user moves focus from the textarea. Even if the textarea is destroyed, the matching continues.

Changed to this in textarea.js, it's not crashing anymore.
if(this.getBeforeCursor() !== replace[0]) {
	this.el.focus();
	 if (Array.isArray(replace)) {
		(0, _update2.default)(this.el, replace[0], replace[1]);
		this.el.dispatchEvent(new Event('input'));
	 }
}

I can also report that when the replacement string is the same as the existing string the javascript locks up.
However it seems like it's always a usage error when this occurs, because it means that you won't get rid of the dropdown? Instead better to ensure that the matcher doesn't match the replacement (in our case we always ensured a space at the end of replacements, and ensured that the match -- then we didn't need to fix this).

Thanks for the comments. I think the issue was came from undate (textcomplete depends on the npm package) and it has been fixed by https://github.com/yuku-t/undate/pull/7<EMAIL_ADDRESS>includes the patch, so please update it.
I'll update dependency version.


KeyAction parameter opts is unused

Raising an issue as I'm not sure if this is on purpose. Could be a bug, since the other funcs receiving options do apply them properly. Found with unparam:
cmd/chromedp-gen/internal/types.go:370:44: (*Type).RetNameList - d is unused
cmd/chromedp-gen/internal/types.go:370:55: (*Type).RetNameList - domains is unused
cmd/chromedp-gen/templates/templates/extra.qtpl:7:80: StreamExtraTimestampTemplate - d is unused
cmd/chromedp-gen/templates/util.go:35:23: formatComment - chop always receives ""
input.go:154:29: KeyAction - opts is unused
runner/runner_linux.go:46:13: Rlimit - res is unused

The runner/runner_linux.go is also a bit suspicious.

The API was written to be forward compatible. In the past, there were key options such as the "shift" key being applied, and is an artifact from a previous, incorrect implementation of the KeyAction. The API should keep this, as it might change in the future, to specify things like the delay between a key press. I had pulled out the actual application of the opts against the "real" key event call (returned from kb.Encode), because for testing I needed it to be a "pure" implementation. This also harks back to the issue that the chromedp package itself, is really a high-level implementation, and if people needed more precise control over how the key events get sent, then they should likely call the kb.Encode func directly, for the associated string they want to send, and modify the returned parameters, before dispatching them via .Do().


PostUp, PostDown, PreDown truncated

When setting very long command for PostUp, PostDown or PreDown, or command containing shell variables reference, after applying config, command is truncated.
Example:
iptables -A FORWARD -i %i -j ACCEPT; iptables -A FORWARD -o %i -j ACCEPT; iptables -t nat -A POSTROUTING -o eth+ -j MASQUERADE; WGUI="<IP_ADDRESS>"; TARGET="<IP_ADDRESS>; forward_port () { iptables -t nat -A PREROUTING -p "$1" -d "$2" --dport "$4" -j DNAT --to "$3:$5"; iptables -A FORWARD -p "$1" -d "$3" --dport "$4" -j ACCEPT; }; forward_port udp "$WGUI" "$TARGET" 53 10153; forward_port tcp "$WGUI" "$TARGET" 80 10080; forward_port tcp "$WGUI" "$TARGET" 443 10443;

After reapplying config it becomes (shown in web ui):
iptables -A FORWARD -i %i -j ACCEPT; iptables -A FORWARD -o %i -j ACCEPT; iptables -t nat -A POSTROUTING -o eth+ -j MASQUERADE; WGUI=

Example 2:
iptables -A FORWARD -i %i -j ACCEPT; iptables -A FORWARD -o %i -j ACCEPT; iptables -t nat -A POSTROUTING -o eth+ -j MASQUERADE; iptables -t nat -A PREROUTING -p "udp" -d "<IP_ADDRESS>" --dport "53" -j DNAT --to "<IP_ADDRESS>:10153"; iptables -A FORWARD -p "udp" -d "<IP_ADDRESS>" --dport "53" -j ACCEPT; iptables -t nat -A PREROUTING -p "tcp" -d "<IP_ADDRESS>" --dport "80" -j DNAT --to "<IP_ADDRESS>:10080"; iptables -A FORWARD -p "tcp" -d "<IP_ADDRESS>" --dport "80" -j ACCEPT; iptables -t nat -A PREROUTING -p "tcp" -d "<IP_ADDRESS>" --dport "443" -j DNAT --to "<IP_ADDRESS>:10443"; iptables -A FORWARD -p "tcp" -d "<IP_ADDRESS>" --dport "443" -j ACCEPT

After reapplying config it becomes (shown in web ui):
iptables -A FORWARD -i %i -j ACCEPT; iptables -A FORWARD -o %i -j ACCEPT; iptables -t nat -A POSTROUTING -o eth+ -j MASQUERADE; iptables -t nat -A PREROUTING -p

which makes absolutely unuseful specifying long custom configuration for iptables.
I've checked wg0.conf after first apply - command matches original. After opening settings in web ui, command is truncated in settings and truncated after second config apply.
I'm using portainer and don't know how to add external files in it unlike in standalone docker on host, so it's important to use long command for custom forwarding rules (preferrable with shell functions to make them shorter), but I can't.
UPD: When settting same config without quotes, everything works

I had the same problem and I also have a lot of iptables commands. In my opinion, the cleanest solution is to outsource the commands to a script. The script is then executed via PostUp or PostDown
PostUp = /etc/wireguard/ifscript.sh up
PostDown = /etc/wireguard/ifscript.sh down
`if [ "$1" = "up" ]; then
.... your PostUp Commands
elif [ "$1" = "down" ]; then
.... your PostDown Commands
fi`


How to request new certificate or certificate update

I got kube-lego to work quite effortlessly with a first ingress, but then ran in to an issue with a second where the logs told me the .well-known/ 404'ered. In that situation, how do I make kube-lego try again after I have fixed whatever is wrong? Will it just keep trying with every change to an ingress, or do I have to bring the ingress down and up again? Or the whole ingress+service+pod or something? I didn't find a pattern, so what worked was to bring everything down and up again and wait some time, but I dunno if it had happened if I had just waited instead of doing anything manually.
Another place where this could happen is if I have kube-lego configured to use the staging environment of Lets Encrypt and then want to change to production. I update the config and then what? Should kube-lego notice the change automatically or do I have to do something manually?

Seems I can simply delete the tls to get kube-lego to fetch a new one.


Tarmak should validate if SSH key for an environment has the right permissions

Is this a BUG REPORT or FEATURE REQUEST?:

Uncomment only one, leave it on its own line:
/kind bug

What happened:
The id_rsa key file for an environment has to wide permissions (eg. 0644).
What you expected to happen:
Tarmak should be transparent about the error or eventually even attempt to fix the permissions
How to reproduce it (as minimally and precisely as possible):
chmod 0666 ~/.tarmak/<myenv>/id_rsa
tarmak cluster apply

Anything else we need to know?:
Should fit in somewhere here: https://github.com/jetstack/tarmak/blob/d903aa794a1176f27006602d007ee89a4e4018f4/pkg/tarmak/environment/environment.go#L124
I think 0600 and 0400 should be both acceptable

/assign


using data set from irregular grid

I have datasets that are from a irregular grid. Should I interpolate it on to a regular grid of some resolution (say xres* yres) and feed it to LCS tool or I can feed it directly as a irregular data.

LCS Tool requires data on a regular grid. The theory upon which LCS Tool is based can handle irregular grids. If you provide a representative sample from the irregular dataset you have, it may be easier to determine if LCS Tool can process it.


Update LaravelRatingServiceProvider.php

I've got this error :
Can't locate path: DIR/src/../migrations/create_ratings_table.php>
Can't locate path: DIR/src/../migrations/add_type_column_to_ratings_table.php>

Thanks for taking the time to create this PR!


Added new sample - Empty SharePoint Online site Recycle Bin

Q
A

New sample?
yes

What's in this Pull Request?
Added a new script sample which demonstrates how to empty SharePoint online site first stage and second stage recycle bin using PnP PowerShell.

Sorry it took a while, another great sample! This will be live shortly 😁


Unable to crossref when using short-captions filter

Hello,
Using quarto, I am unable to crossref using regular citation syntax, with short-captions.lua pandoc filter. Figures without the short caption filter can be crossreferenced but not with that filter. I am forced to use the latex alternative which is less practical for another reason.
I am not sure if the problem comes from quarto or this filter.
![**Bold caption** [@Armas.2004]](figure.jpeg){#fig-cap short-caption="**short-cap**"}

@fig-cap

This returns ?@fig-cap
Anything that is not @fig- breaks as quarto expects a bibliography citation instead.
See (fig:test<empty citation>).
\ref{fig-cap} works.

Just to confirm: did I understand correctly that this works without the short-captions filter, but fails if the filter is invoked?
Also, could you post a minimal qmd file? That'd make it easier for us to investigate the issue.

short-captions-test.zip
Yes that is right, when the filter is used, the crossref attached to the filter fails.
Here is a minimal reproductible example, using RStudio to render the quarto file to a pdf format.

Thank you for the excellent example. It seems that Quarto and this filter are just incompatible. As far as I can see this cannot be fixed here.
I suggest to raise this with the Quarto team at https://github.com/quarto-dev/quarto-cli. It will be much easier to support this when Quarto switches from pandoc 2.19 to pandoc 3.x.

For other quarto folks looking at this. In quarto, you don't need to use short-captions.lua. Instead, you use the fig-scap attribute directly in the figure:
![This is the long R logo caption.](R_logo.png){#fig-R-short-cap fig-scap="R logo"}


Upgrade Electron to 1.8.4

Before submitting, please confirm you've

[x] read and understood our Contributing Guidelines
[x] completed Mattermost Contributor Agreement
[x] executed npm run lint:js for proper code formatting

Please provide the following information:
Summary
Upgrade Electron to 1.8.4.
As far as looking changelogs, important changes not found in functionality.

https://electronjs.org/releases#1.8.4
https://electronjs.org/releases#1.8.3

Issue link
#739
Test Cases
General usecases.
Additional Notes
https://circleci.com/gh/yuya-oc/desktop/704#artifacts

Thanks!


Support Programmatic Creation/Deletion of Custom Fields

The new CustomFieldHelper is useful for adding a custom field(s) to a case or case template, but cannot be used to create a new custom field in TheHive. There are several fields missing such as reference, options, and description - all of which are required fields in TheHive GUI. This PR provides the ability programmatically create (or delete) Custom Fields. This feature is useful for deploying TheHive in multiple environments and wanting to utilize a standardized naming convention.
This PR adds the following support:

Implements new exception CustomFieldException
Adds create_custom_field and delete_custom_field methods to TheHive4py API
Adds a static method named create_new_field to CustomFieldHelper - returns a dict that can be passed to create_custom_field.
Added example file test-custom-field-create-delete to demonstrate adding and deleting custom fields using the methods above.

This PR is an updated version of PR #52 (now closed).

Closed as 1.x is not supported anymore and feature exists in 2.x


spirv-opt: New crash at glslang known_good spirv-opt with previously working SPIR-V shader

I am using spirv-tools to commit 99cd25c4139e0dc914ab8a5a3b75e6fed0ad1329 marked in known_good.json in glslang repository.
The attached shader crashes in spirv-opt with the following callstack:
>	vfx_gl.dll!spvtools::opt::AggressiveDCEPass::AggressiveDCE(class spvtools::ir::Function *)	C++
 	vfx_gl.dll!spvtools::opt::Pass::ProcessCallTreeFromRoots(class std::function<bool > &,class std::unordered_map<unsigned int,class spvtools::ir::Function *,struct std::hash<unsigned int>,struct std::equal_to<unsigned int>,class std::allocator<struct std::pair<unsigned int const ,class spvtools::ir::Function *> > > const &,class std::queue<unsigned int,class std::deque<unsigned int,class std::allocator<unsigned int> > > *)	C++
 	vfx_gl.dll!spvtools::opt::Pass::ProcessEntryPointCallTree(class std::function<bool > &,class spvtools::ir::Module *)	C++
 	vfx_gl.dll!spvtools::opt::AggressiveDCEPass::ProcessImpl(void)	C++
 	vfx_gl.dll!spvtools::opt::PassManager::Run(class spvtools::ir::Module *)	C++
 	vfx_gl.dll!spvtools::Optimizer::Run(unsigned int const *,unsigned __int64,class std::vector<unsigned int,class std::allocator<unsigned int> > *)	C++
 	vfx_gl.dll!CVfxShaderValidatorGLslang::GetBinaryShader(unsigned char * * ppBinaryOut, unsigned int * pBinarySizeOut) Line 856	C++
 	vfx_gl.dll!CVfxGL::CompileShaderAndGetVariables(unsigned __int64 nStaticComboIndex, unsigned __int64 nDynamicComboIndex, const CVfx * pVfx, VfxCompileTarget_t compileTarget, VfxProgram_t programType, VfxCompiledShaderInfo_t * pCompiledShaderInfoOut, bool bUseShaderCache, unsigned int nVfxCompileShaderFlags) Line 2861	C++
 	vfxcompile.dll!Worker_OnIndividualShader(IVfx * pVfxInterface, CVfx * pShaderGeneralHeader, unsigned __int64 nStaticCombo, unsigned __int64 nDynamicCombo, VfxCompileTarget_t compileTarget, VfxProgram_t programType, CVfxByteCodeManager & byteCodeManager, CShaderStats & shaderStats) Line 361	C++
 	vfxcompile.dll!Worker_ProcessWorkUnitFn(int iThread, unsigned __int64 nWorkUnit, MessageBuffer * pBuf) Line 596	C++
 	vfxcompile.dll!Local_ProcessWorkUnitFn(int iThread, int iWorkUnit) Line 736	C++
 	vfxcompile.dll!ThreadWorkerFunction(int iThread, void * pUserData) Line 85	C++
 	vfxcompile.dll!InternalRunThreadsFn(void * pParameter) Line 170	C++
 	tier0.dll!ThreadProcWrapped(unsigned __int64(*)(void *) pFunc, void * pParam) Line 535	C++
 	tier0.dll!ThreadProcConvert(void * pParam) Line 588	C++

This can reproduced from the command-line using the following command:
spirv-opt.exe --inline-entry-points-exhaustive --convert-local-access-chains --eliminate-local-single-block --eliminate-local-single-store --eliminate-insert-extract --eliminate-dead-code-aggressive --eliminate-dead-branches --merge-blocks --eliminate-local-single-block --eliminate-local-single-store --eliminate-local-multi-store --eliminate-insert-extract --eliminate-dead-code-aggressive --eliminate-common-uniform -o test0024_opt.spv test0024.spv

The previous known good in glslang did not have this crash.  I suspect due to the location of the crash that it may be related to PR #863.
test0024.zip

Claiming it.

Thanks.  I'll watch for a PR.

PR #883 fixes this problem. I have pushed a fix for the only problem that was noted to this point.
I know this PR fixes what ultimately will be dead code, but I would rather switch over to the cfg cleanup code in a more orderly manner and not in answer to a bug.

If possible, please merge PR #883 to master.  @greg-lunarg believes he has addressed the concerns from code review and this issue is currently causing a crash in our shader compilation workload so is gating us from taking the latest glslang.

@danginsburg An alternative to waiting for a merge of #883 is to move up to 5834719fc17d4735fce0102738b87b70255cfd5f and add CreateCFGCleanupPass after CreateDeadBranchElimPass. In general, you can leave this in your recipe as it will soon be added to the general recipe. I have a PR in to glslang that makes this commit the latest known good and adds CreateCFGCleanupPass to the recipe for legalization and optimization.

Fix has been pushed into master as e3a720933046
Sorry for the delay.
I'll close this but please re-open if the same issue arises.

Confirmed fixed.  Thanks all.


Add await in index.js:9

I don't know if is the problem but i think that hit don't wait of input end to start other robots.
Note: I'm Mateus of Discord

Don't is it the problem


How are run apps for sideloading with a commercial trusted certificate

Hello,
Do we need to enable the developer mode and to import manually the certificate if the UWP app has been signed with an official trusted certificate bought on a certification site?
Regards,

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: e9d1c88d-24b1-0eda-b458-105db02dca36
Version Independent ID: c5d1634a-0ead-f68a-e5be-89acf0eef0a6
Content: Packaging UWP apps - UWP app developer
Content Source: windows-apps-src/packaging/packaging-uwp-apps.md
Product: uwp
GitHub Login: @mcleanbyron
Microsoft Alias: mcleans

We are facing a issue in sideloading app in our production environment. we have signed the app with enterprise trusted certificate. on each user login we run the script to install the appx. but for some users we are getting a error like below
Add-AppxPackage : Deployment failed with HRESULT: 0x80073CFF, To install this application you
need either a Windows developer license or a sideloading-enabled system.
Deployment of package Microsoft.VCLibs.140.00_14.0.26706.0_x64__8wekyb3d8bbwe with package origin
Unsigned failed because no valid license or sideloading policy could be applied. A developer
license (http://go.microsoft.com/fwlink/?LinkId=233074) or enterprise sideloading configuration
(http://go.microsoft.com/fwlink/?LinkId=231020) may be required.
the min target version of appx : 10586
max version : 17134
could you help us here ?

Hi @jashif - Requests for technical troubleshooting and assistance are out of scope for this repo, which is specifically about feedback on the docs. I recommend that you ask your question on the MSIX deployment forum.


Utvideo14.2.1 (New formula)

Utvideo 15.0.0 and later couldn't link with ffmpeg.(See umezawatakeshi/utvideo#1 (in Japanese) or https://trac.ffmpeg.org/ticket/5511)
So 14.2.1 is last version to link with ffmpeg today.
$ otool -L /usr/local/Cellar/ffmpeg/3.0.2/lib/libavutil.55.17.103.dylib |sed -n -e "/(/s/(.*$//p" |sort -r

/usr/local/opt/zeromq/lib/libzmq.5.dylib
/usr/local/opt/x264/lib/libx264.148.dylib
/usr/local/opt/utvideo14/lib/libutvideo.14.2.1.dylib
...
/usr/lib/libc++.1.dylib
...

And this do not provide QuickTime component. Please use newer version one.

I think we'll pass on this as it doesn't have a proper homepage and the latest version isn't working. Sorry!

If you can read Japanese, I`ll see URL is correct.
And upstream say UtVideo is just a plug-in since 15.0.0. So we never build latest version to library.

The URL is correct but it's not a dedicated homepage.


Code in the correct CPI typesetting provided, including the fonts

The fonts should be coded into the tool so that anyone looking at the tool is seeing the correct fonts without having to install them on their own computer.
When the tool was viewed by several people the CPI typesetting provided did not stay consistent with the original typesetting, which is probably because the typesetting wasn't coded in properly with the fonts coded.

Update to this @Keristiena @wlcobb
We are talking through the final name of this tool so, for now, please just use the existing typesetting that is in the google folder: https://drive.google.com/file/d/1JlGWgYJYtc86aspnMyTdjZCwUWFTpaqO/view?usp=sharing
Until we know the final name of the tool we are not going to have an updated typesetting for the header.


Originated channel is now added to a bridge.

The program checks for an available bridge. If a bridge is available,
then that bridge is reused. If no bridges are active, a new bridge
is created. Once the bridge is created, a channel is originated to
a designated endpoint, and upon answering the call, the channel is
added to the bridge.

Overall, instead of having a function that calls another function, which in turn calls another function and so on, consider having small functions responsible for a single thing that expect a callback so you can get the value you need (the bridge to add to, the channel object) and having the main export function call these in turn. This will make the module more readable and will help in maintenance down the line.

At this point, it would be a good idea to switch from callbacks to promises. You should use promises both internally to handle calling async APIs and also return a promise to users of your module that will eventually be resolved if everything works as expected, or rejected if an error occurs. You should take some time to read about promises and pick a library that implements them in Node.js.
Each of your method should have a single purpose, and should return a promise that can be used by the caller to determine if the module should be rejected, or if the next method should be called to handle the next part of the module's responsibilities.
In other words, the main function exposed as your module should look something like the following (note that I'm just reusing your current method names as an example, you may want to design the API differently):
return designateMixingBridge(args)
.then(function(result) {
// do one of these
return createBridge(args);
return createChannel(args);
})
.then(function(result) {
return addChannelToBridge(args);
});
Note that .done is not called on the promise since it is returned to the user of the module.
You will need to look into converting the Node.js style callback API of ari-client to a promise one using something like Q's denodeify method so you can call ari-client methods and get back promises.

Running jshint found the following errors:
lib/sla.js: line 2, col 1, Missing semicolon.
lib/sla.js: line 10, col 0, Identifier 'bridge_type' is not in camel case.
lib/sla.js: line 41, col 52, Mixed double and single quotes.
lib/sla.js: line 44, col 49, Mixed double and single quotes.
lib/sla.js: line 71, col 81, Line is too long.
lib/sla.js: line 72, col 81, Line is too long.
lib/sla.js: line 73, col 86, Line is too long.
lib/sla.js: line 75, col 86, Line is too long.

Looks good. Since you have a lot of commits to address PR comments, I would suggest we walk though squashing the commits into a single commit in a different branch before merging.

Squashed into #6


When I create entities and add components in multiple threads, there are unforeseen concurrency issues

In my actual project, I create monster entities in a System. In order to take advantage of multi-core, I use parallelStream and create monster entities in it, and cache the Entity to Component, but I found that in the next System, the Entity in the Component obtained by the context.findEntitiesWith() method is different from the hashCode of ResultSet.entity()
example code like this.
public enum State {
    S1, S2, S3;
}

public static class C {
    private final Entity entity;

    public C(Entity entity) {
        this.entity = entity;
    }
}

public static class B {

}

public static class A {
    private C c;

    public A(Dominion dominion) {
        c = new C(dominion.createEntity(this));
        c.entity.setState(S1);
    }
}

public static void main(String[] args) {
    final Dominion dominion = Dominion.create();
    final var list = List.<Runnable>of(() -> {
        for (int i = 0; i < 200; i++) {
            final var a = new A(dominion);
            a.c.entity.add(new B());
        }
    }, () -> {
        for (int i = 0; i < 200; i++) {
            final var a = new A(dominion);
            a.c.entity.add(new B());
        }
    }, () -> {
        for (int i = 0; i < 200; i++) {
            final var a = new A(dominion);
            a.c.entity.add(new B());
        }
    });
    final var scheduler = dominion.createScheduler();
    scheduler.schedule(() -> list.parallelStream().forEach(Runnable::run));
    scheduler.schedule(() -> {
        dominion.findEntitiesWith(A.class).stream().forEach(rs->{
            if(rs.entity().hashCode() != rs.comp().c.entity.hashCode()) {
                System.out.println("1111111111111111111");
                System.exit(-1);
            }
        });
        System.exit(0);
    });
    scheduler.tickAtFixedRate(10);
}

If I remove a.c.entity.add(new B());, the program is fine.
If I change paralleStream() to stream(), this program is fine.

when I call rs.entity().getId() in System, I found that the ID of Entity has many repetitions, and the chunkId in the ID still points to the old chunk.
scheduler.schedule(() -> {
    dominion.findEntitiesWith(A.class).stream().forEach(rs->{
        System.out.println(((IntEntity)rs.entity()).getId());
    });
    System.exit(0);
});

hi, @enricostara
I found that this is a very troublesome concurrency issue. this issue may appear in the two methods of remove and copy. since remove will move the Item, the copied data may be wrong. I am not sure if this is the case, and I have not yet known how to fix this issue.

Hi @endison1986 ,
I'm still investigating this issue

Hi @endison1986 ,
please checkout and double-check if it works as expected.
In IntEntityTest I added a unit test derived from your example code

Hi, @enricostara
First of all I must thank you for your work.
Second, I run my project and my previous test code, they all work fine.
But I modified my test code and found some problems, I added unit test in IntEntity
323 @Test
324    public void concurrentConcatenatedAdd2() throws InterruptedException {
325//        System.setProperty("dominion.logging-level", "TRACE");
326//        System.setProperty("dominion.test.logging-level", "TRACE");
327
328        ExecutorService executorService = Executors.newFixedThreadPool(10);
329        EntityRepository entityRepository = (EntityRepository) new EntityRepository.Factory().create("stress-test");
330//        EntityRepository entityRepository = (EntityRepository) new EntityRepository.Factory().create("test");
331
332        AtomicInteger counter = new AtomicInteger(1);
333        Runnable runnable = () -> {
334            for (int i = 0; i < 10000; i++) {
335                int id = counter.getAndIncrement();
336                entityRepository.createEntity(new C1(id)).add(new C2(id));
337            }
338        };
339        Runnable runnable1 = () -> {
340            for (int i = 0; i < 10000; i++) {
341                int id = counter.getAndIncrement();
342                entityRepository.createEntity(new C1(id)).add(new C2(id)).add(new C3(id));
343            }
344        };
345        executorService.execute(runnable);
346        executorService.execute(runnable1);
347
348        executorService.shutdown();
349        Assertions.assertTrue(executorService.awaitTermination(5, TimeUnit.SECONDS));
350
351        entityRepository.findEntitiesWith(C1.class).stream().forEach(rs -> {
352            Assertions.assertNotNull(rs.entity());
353            Assertions.assertNotNull(rs.comp());
354        });
355    }

I get an error message
org.opentest4j.AssertionFailedError: expected: not <null>
<6 internal lines>
at dev.dominion.ecs.test.engine/dev.dominion.ecs.test.engine.IntEntityTest.lambda$concurrentConcatenatedAdd2$13(IntEntityTest.java:352)
at java.base/java.util.Iterator.forEachRemaining(Iterator.java:133)<2 internal lines>
at dev.dominion.ecs.test.engine/dev.dominion.ecs.test.engine.IntEntityTest.concurrentConcatenatedAdd2(IntEntityTest.java:351)<31 internal lines>
at java.base/java.util.ArrayList.forEach(ArrayList.java:1511) <9 internal lines>
at java.base/java.util.ArrayList.forEach(ArrayList.java:1511) <27 internal lines>

Hi @endison1986 ,
I added the new test and improved the code.
Please check again if It works as expected.

Hi @enricostara , it all works fine in my project and test code, thanks.

Thanks you for your tests!


[stable/kiam] Use correct port when generating certificates

The datatype of .Values.server.service.port is float64 by default. So printf "<IP_ADDRESS>:%d" .Values.server.service.targetPort will be evaluated into below:
<IP_ADDRESS>:%!d(float64=443)

We need to cast .Values.server.service.port into integer type before using it.
Reference:
https://helm.sh/docs/chart_best_practices/#make-types-clear
Checklist

[x] DCO signed
[x] Chart Version bumped
[x] Variables are documented in the README.md
[x] Title of the PR starts with chart name (e.g. [stable/chart])

@ewbankkit Thanks for the note. I've closed this PR and opened a new one. https://github.com/uswitch/kiam/pull/288


Custom Backgrounds

Allow the user to upload custom backgrounds. Resolves #320

Nice, I'll upload many gifs 😁
Upload is ok, but the ui should be improved:

Hide the upload button in the themes tab.
Delete button must be next to each image (perhaps an icon near the top), so you don't need to select the image first to delete.
After delete/upload don't call the manageBackgrounds, just update the array.
After delete, update the background to default.

@luciorubeens Thanks for the suggestions! I went ahead and implemented all of them. One issue though is that when clicking the delete button, which is now on the image grid tile, the image is selected for a split second before it is deleted. Do you know how I could fix this?

Hmm I did not noticed but I added preventDefault().. good job! 👍🏻 +5


Add n/w level security guideline to to restrict outbound connections of Publisher node.

Description:
in a WSO2 API-M deployment, we recommend restricting outbound connections of the Publisher node only to the required internal nodes (only to the nodes which Publisher portal is intended to communicate with) of the deployment. So even if privileged user credentials were exploited to a user with malicious intent, they cannot perform network scans using the existing functionalities against the other services exposed in the same private network of Publisher node.

Fixed in

https://github.com/wso2/docs-apim/pull/1246
master

https://github.com/wso2/docs-apim/pull/1257
3.1.0

https://github.com/wso2/docs-apim/pull/1256
3.0.0


Add Same-URL A/B Testing to Examples

Resolves transparent A/B on same URL?#2693 issue.
This example supports the default A/B testing setup shown here, with one key difference. When the /control or /test paths are accessed directly, cookies are ignored, and the request is forwarded directly to the desired environment on the origin.
Please edit the title and summary as y'all see fit. I mostly just wrote them as a placeholder.

Thanks! Can you update this to replace the existing A/B test example

Thanks! Can you update this to replace the existing A/B test example

Done

@jkup can you review this when you have time?


Treat Task<IQueryable/IExecutable> properly in UseDbContext

Fix that unwraps Task<> from result type in UseDbContext
Addresses #2754

I have reworked your code to also allow support for ValueTask.
Moreover, I added some unit tests so that the code is properly under test.

/AzurePipelines run

In graphql-workshop session # 3 Understanding GraphQL query execution and DataLoader, a ToListAsync was applied that avoids an ObjectDisposedException (it was not explicitly mentioned that that is the main reason but I believe it is).
Jump to # 7 here: https://github.com/ChilliCream/graphql-workshop/blob/master/docs/3-understanding-dataLoader.md#configure-field-scoped-services
[UseApplicationDbContext]
public Task<List<Speaker>> GetSpeakers([ScopedService] ApplicationDbContext context) =>
    context.Speakers.ToListAsync();

Does this PR fix the exception if we remove the ToListAsync and leave the IQueryable?
I'll retest when 11.1 gets released.
[UseApplicationDbContext]
public IQueryable<Speaker> GetSpeakers([ScopedService] ApplicationDbContext context) =>
    context.Speakers;

In graphql-workshop session # 3 Understanding GraphQL query execution and DataLoader, a ToListAsync was applied that avoids an ObjectDisposedException (it was not explicitly mentioned that that is the main reason but I believe it is).
Jump to # 7 here: https://github.com/ChilliCream/graphql-workshop/blob/master/docs/3-understanding-dataLoader.md#configure-field-scoped-services
[UseApplicationDbContext]
public Task<List<Speaker>> GetSpeakers([ScopedService] ApplicationDbContext context) =>
    context.Speakers.ToListAsync();

Does this PR fix the exception if we remove the ToListAsync and leave the IQueryable?
I'll retest when 11.1 gets released.
[UseApplicationDbContext]
public IQueryable<Speaker> GetSpeakers([ScopedService] ApplicationDbContext context) =>
    context.Speakers;

yes this should actually be available in 11.0.7

yes this should actually be available in 11.0.7

It looks like the issue I described is not yet fixed as of 11.0.7. I created a sample repo: https://github.com/gojanpaolo/hc-1
All the essential code is in Startup.cs
With the following lines as the main issue:
https://github.com/gojanpaolo/hc-1/blob/62b32d5671f50a2acaa0093da788230a7dbaa284/WebApplication1/WebApplication1/Startup.cs#L35-L36
To reproduce
Run the following query
{
  speakers {
    id
  }
}

and you'll get the following result
{
  "errors": [
    {
      "message": "Unexpected Execution Error",
      "locations": [
        {
          "line": 2,
          "column": 3
        }
      ],
      "path": [
        "speakers"
      ],
      "extensions": {
        "message": "Cannot access a disposed context instance. A common cause of this error is disposing a context instance that was resolved from dependency injection and then later trying to use the same context instance elsewhere in your application. This may occur if you are calling 'Dispose' on the context instance, or wrapping it in a using statement. If you are using dependency injection, you should let the dependency injection container take care of disposing context instances.\r\nObject name: 'ApplicationDbContext'.",
        "stackTrace": "   at Microsoft.EntityFrameworkCore.DbContext.CheckDisposed()\r\n   at Microsoft.EntityFrameworkCore.DbContext.get_DbContextDependencies()\r\n   at Microsoft.EntityFrameworkCore.DbContext.get_Model()\r\n   at Microsoft.EntityFrameworkCore.Internal.InternalDbSet`1.get_EntityType()\r\n   at Microsoft.EntityFrameworkCore.Internal.InternalDbSet`1.CheckState()\r\n   at Microsoft.EntityFrameworkCore.Internal.InternalDbSet`1.get_EntityQueryable()\r\n   at Microsoft.EntityFrameworkCore.Internal.InternalDbSet`1.System.Collections.IEnumerable.GetEnumerator()\r\n   at HotChocolate.Execution.Processing.ResolverTask.<>c__DisplayClass13_0.<ExecuteResolverPipelineAsync>b__0()\r\n   at System.Threading.Tasks.Task`1.InnerInvoke()\r\n   at System.Threading.Tasks.Task.<>c.<.cctor>b__277_0(Object obj)\r\n   at System.Threading.ExecutionContext.RunFromThreadPoolDispatchLoop(Thread threadPoolThread, ExecutionContext executionContext, ContextCallback callback, Object state)\r\n--- End of stack trace from previous location ---\r\n   at System.Threading.ExecutionContext.RunFromThreadPoolDispatchLoop(Thread threadPoolThread, ExecutionContext executionContext, ContextCallback callback, Object state)\r\n   at System.Threading.Tasks.Task.ExecuteWithThreadLocal(Task& currentTaskSlot, Thread threadPoolThread)\r\n--- End of stack trace from previous location ---\r\n   at HotChocolate.Execution.Processing.ResolverTask.ExecuteResolverPipelineAsync(CancellationToken cancellationToken)\r\n   at HotChocolate.Execution.Processing.ResolverTask.TryExecuteAsync(CancellationToken cancellationToken)"
      }
    }
  ],
  "data": {
    "speakers": null
  }
}

It looks like the issue I described is not yet fixed as of 11.0.7. I created a sample repo: https://github.com/gojanpaolo/hc-1
All the essential code is in Startup.cs
With the following lines as the main issue:
https://github.com/gojanpaolo/hc-1/blob/62b32d5671f50a2acaa0093da788230a7dbaa284/WebApplication1/WebApplication1/Startup.cs#L35-L36
To reproduce
Run the following query
{
  speakers {
    id
  }
}

and you'll get the following result
{
  "errors": [
    {
      "message": "Unexpected Execution Error",
      "locations": [
        {
          "line": 2,
          "column": 3
        }
      ],
      "path": [
        "speakers"
      ],
      "extensions": {
        "message": "Cannot access a disposed context instance. A common cause of this error is disposing a context instance that was resolved from dependency injection and then later trying to use the same context instance elsewhere in your application. This may occur if you are calling 'Dispose' on the context instance, or wrapping it in a using statement. If you are using dependency injection, you should let the dependency injection container take care of disposing context instances.\r\nObject name: 'ApplicationDbContext'.",
        "stackTrace": "   at Microsoft.EntityFrameworkCore.DbContext.CheckDisposed()\r\n   at Microsoft.EntityFrameworkCore.DbContext.get_DbContextDependencies()\r\n   at Microsoft.EntityFrameworkCore.DbContext.get_Model()\r\n   at Microsoft.EntityFrameworkCore.Internal.InternalDbSet`1.get_EntityType()\r\n   at Microsoft.EntityFrameworkCore.Internal.InternalDbSet`1.CheckState()\r\n   at Microsoft.EntityFrameworkCore.Internal.InternalDbSet`1.get_EntityQueryable()\r\n   at Microsoft.EntityFrameworkCore.Internal.InternalDbSet`1.System.Collections.IEnumerable.GetEnumerator()\r\n   at HotChocolate.Execution.Processing.ResolverTask.<>c__DisplayClass13_0.<ExecuteResolverPipelineAsync>b__0()\r\n   at System.Threading.Tasks.Task`1.InnerInvoke()\r\n   at System.Threading.Tasks.Task.<>c.<.cctor>b__277_0(Object obj)\r\n   at System.Threading.ExecutionContext.RunFromThreadPoolDispatchLoop(Thread threadPoolThread, ExecutionContext executionContext, ContextCallback callback, Object state)\r\n--- End of stack trace from previous location ---\r\n   at System.Threading.ExecutionContext.RunFromThreadPoolDispatchLoop(Thread threadPoolThread, ExecutionContext executionContext, ContextCallback callback, Object state)\r\n   at System.Threading.Tasks.Task.ExecuteWithThreadLocal(Task& currentTaskSlot, Thread threadPoolThread)\r\n--- End of stack trace from previous location ---\r\n   at HotChocolate.Execution.Processing.ResolverTask.ExecuteResolverPipelineAsync(CancellationToken cancellationToken)\r\n   at HotChocolate.Execution.Processing.ResolverTask.TryExecuteAsync(CancellationToken cancellationToken)"
      }
    }
  ],
  "data": {
    "speakers": null
  }
}

I had the same problem but then I added services.AddScoped(); to the startup file. The actual error was disguised by the one above and it doesn't mention it in the newest documentation.
Query for me was the basic one shown in the official docs


dclexperience: glitched textures spawn on 0,0

Explorer Alpha build version:
Issue Description:
Some weird textures are glitched and spawining on the 0,0 position of the scene (where other avatars get stuck as well)
Unity Renderer

Explorer Alpha

Steps to reproduce:

Expected behaviour:
Current behaviour:
Reproduction rate:

[ ] < 10%
[ ]  < = 25%
[ ]  50%
[ ]  < = 75%
[ ]  100%

Severity:

[ ] Cosmetic
[ ] Minor
[ ] Medium
[ ] High
[ ] Critical
[ ] Blocker

Priority:

[ ] High
[ ] Medium
[ ] Low

Platforms / OS:

[ ] Windows 11
[ ] Windows 10
[ ] Mac Sonoma
[ ] Mac (specify the version on Additional Notes)

Evidence:
Additional Notes:

We need to contact creators. This artifact is also presented in the old renderer, just in another place - at the corner, together with Aisha

🟢 Fixed on latest


[WFLY-7286] Elytron - inconsistency between DMR and XSD representation of mechanism-provider-filtering-sasl-server-factory

Elytron Subsystem: https://issues.jboss.org/browse/WFLY-7286

@honza889 And one more if you could please review the constraints ;-)

This is ok, it is already used with hasDefined(), should be nullable.


Entropy order

When creating entropy for private keys the protocol generates dice entropy first and then computer entropy.
I think it would be better to switch the order - generate computer entropy first and then generate dice entropy. That way you can be more sure that dice entropy you type to scratchpad does not affect computer entropy later.

I don't follow you...how might typing the dice entropy into the scratchpad affect the computer entropy? And if the order were switched, wouldn't the same problem still be there when typing in the computer entropy second (it might affect the dice entropy)?

This assumes that you type dice numbers to scratchpak and that input is later used by the computer as source of entropy.
Not really sure how computer random generator works but AFAIK it uses network traffic, user input and probably some other sources of entropy. When you have network card and WiFi removed and computer isolated then its entropy source is quite limited. From that I conclude that if not just the user input timing but also input values are used for the entropy then entered dice values may affect what computer later generates.
On the other hand when you switch the order then you can be sure that computer entropy was not affected by the dice numbers entered.
This is highly speculative and probably more theoretical than practical issue but I thought it was worth mentioning.

Gotcha. Yes it's conceivable that the random numbers generated by the computer's RNG could be affected by the keystrokes entered for the dice. That would defeat the purpose of mixing two sources of entropy, since the two sources are now somewhat related.
It's a long shot, but I agree with the switcheroo, since there's no reason not to.

Actually, this looks like a sound requirement.
The proof that is cited in the code https://crypto.stackexchange.com/questions/17658/mixing-entropy-sources-by-xor/17660#17660 requires the two XOR'ed sequences to be independent. A claim that cannot be sustained if we actually pass the dice information into the system.


[QST] Why isn't there an API to decompress data as one single chunk ? (ZSTD)

I could see that the current API to decompress the data compressed by ZSTD is nvcompBatchedZstdDecompressAsync.
Are there any plans to provide an API to decompress data as one single chunk (entire data is one single batch) ?
If yes, when can we expect it and if it's no, plans what's reason behind it ?

@shreer1998 do you have a use case for the single chunk decompression on the GPU? For zstd or other formats. Please let us know. So far we’ve been focusing on supporting Apache Parquet/ORC type of files that usually have many chunks, so we’ve been prioritizing the batched interface.

Hi @shreer1998,
Can you help us understand why you can't split the data into many smaller chunks on the CPU? I.e. through multiple calls to the CPU compressor (possibly even with many threads?)
Note, there is no minimum batch size in the nvcompBatchedZstdDecompressAsync API, so you can call it with 1 chunk (up to 2 GB in size).
Unfortunately, the performance will be slow with such a single chunk.

Hello, @eschmidt-nvidia.
Thanks for the response. I didn't have the option to tweak the CPU zstd compression into batched compression as the CPU part was frozen for some reason. Given the fact that chunk sizes can be up to 2GB, it solves my issue for now. I thought it was restricted to 64KB.


⚡ Run akto on a vulnerable app to find a bug.

💭 Introduction
This task involves using Akto to run tests on vulnerable apps like juice-shop, rest-api-goat etc. Users can view the test results and check the vulnerabilities. You can also check and report if we are detecting any false positives, i.e. vulnerabilities that are wrongly detected by Akto. You can add data to Akto dashboard using burp suite, postman etc. For ex - Refer to burp documentation - https://docs.akto.io/add-api-data/integrations/burp-suite.
🎯 Requirements
Setting up a vulnerable application locally and using applications like BurpSuite/Postman etc to send data to Akto
✅ Task summary:

[ ] Ask to be assigned to the issue.
[ ] Wait to be assigned. We will try to assign in less than 2 hours.
[ ] Setup any vulnerable application locally. For ex - Refer https://github.com/juice-shop/juice-shop#docker-container
[ ] Use web interface of application, or hit api's yourself, and add data to akto dashboard. For ex - Refer https://docs.akto.io/add-api-data/integrations/burp-suite on how to send data using Burpsuite.
[ ] Add an attacker token before running tests. Refer - https://docs.akto.io/testing/create-user-config#method-1-adding-token-manually
[ ] Go to your api collection, and click on run tests after selecting what all tests you want to trigger
[ ] View test results. Refer - https://docs.akto.io/testing/test-results

🙋🏼♂ Questions:
If you have questions, need any help, or just want to hang out, make sure to join us on our Discord server.

I'd like to take this one.

Hi, I'd like to work on this. I'd anyways test this on a vulnerable app to look at the efficiency and FP count before I could implement it in our CI/CD. Feel free to assign this to me.

Assigned it to you @mohithkalyan . Happy hacking. Feel free to join our Discord


Closing tricky to close threadpools

There are some threadpools opened in BigtableOptionsFactory that need to be closed when a BigtableConnection is closed.  Setting Closable objects on the ChannelOptions so that the BigtableConnection can close them.  More closable objects will be added later from code that only have access to ChannelOptions making ChannelOptions a better location to keep the Closable objects.

moving this to another PR.


[GLUTEN-3559][VL] Fix Failing UTs of GlutenQueryExecutionErrorsSuite

What changes were proposed in this pull request?
This CL fixes tests failing in GlutenQueryExecutionErrorsSuite
(Fixes: #3559 )
How was this patch tested?
Enabled Tests pass successfully

@PHILO-HE @zhouyuan Please review. Thanks!

===== Performance report for TPCH SF2000 with Velox backend, for reference only ====

query
log/native_4553_time.csv
log/native_master_01_28_2024_d041ce584_time.csv
difference
percentage

q1
32.76
32.99
0.232
100.71%

q2
23.90
23.85
-0.046
99.81%

q3
37.61
37.74
0.129
100.34%

q4
37.74
38.98
1.236
103.27%

q5
68.53
67.95
-0.585
99.15%

q6
5.46
7.02
1.568
128.74%

q7
82.78
80.87
-1.914
97.69%

q8
82.20
84.35
2.151
102.62%

q9
115.84
121.55
5.707
104.93%

q10
44.52
43.06
-1.458
96.72%

q11
19.89
20.27
0.379
101.90%

q12
28.10
27.38
-0.713
97.46%

q13
45.12
45.45
0.335
100.74%

q14
16.96
22.94
5.984
135.28%

q15
26.42
28.71
2.291
108.67%

q16
14.12
14.08
-0.038
99.73%

q17
97.66
102.67
5.016
105.14%

q18
146.65
148.89
2.241
101.53%

q19
12.45
12.47
0.022
100.18%

q20
27.53
26.11
-1.420
94.84%

q21
223.91
226.03
2.126
100.95%

q22
14.83
13.55
-1.285
91.34%

total
1204.97
1226.93
21.958
101.82%


Several files have old uber-go/zap import

query_executor.go still has the old ZAP import github.com/uber-go/zap instead of go.uber.org/zap in master, although this was fixed in #7728.
It is a trivial change so I will send a PR for it right away.

I just analyzed and apparently there are several places where the import is still github.com/uber-go/zap.
Shall I update them all?

Related: #8029

I see, thanks for the info @mark-rushakoff!
The status of this matter is quite confusing, but if there is already an issue where this is being resolved, I will close this one to avoid more confusion.

Closing this issue, will be fixed in #8029


Removing hardcoded node pool quantity

Removed hardcoded value for machine pools to allow users to increase node count in the pool. Changed config struct to allow for NodesAndRoles to accept quantity as a value. Adjusted all tests using RKEMachinePoolSetup helper function to adjust to the new structure.

@timhaneunsoo Can we squash all commits?


Allow Monolog v3

Goal
Laravel v10 will require Monolog v3 (https://github.com/laravel/framework/pull/42311), so we'll also need to allow it so that we can be compatible when it eventually releases. This is required to allow testing against pre-release versions and to allow our nightly "unstable" builds to run again
We only use Monolog in one place and the APIs we use haven't changed in v3, so no other changes are required:
https://github.com/bugsnag/bugsnag-laravel/blob/1853d8335e2c29412abd14e3522fbca0a4351d84/src/BugsnagServiceProvider.php#L289-L293

This PR doesn't do anything because the laravel 9 requirements prevent the tests ever installing monolog 3.

Check the build logs on github actions. :)


crontab not updated on windows

Hi, I installed the whenever gem to my jruby rails application,
Gemfile:
gem 'whenever', require: false

Schedule.rb
set :output, "#{path}/log/cron.log"
set :environment, 'development'

every 1.minute do
  command "echo 'you can use raw cron syntax too'", environment => "development"
end

on the gitbash terminal(windows)
I tried,
jruby -S whenever

/bin/bash -l -c 'echo '''you can use raw cron syntax too''' >> C:/Users/Sriganeshk/Documents/Promaster4Rails/log/cron.log 2>&1'

'## [message] Above is your schedule file converted to cron syntax; your crontab file was not updated.
'##' [message] Run `whenever --help' for more options.
whenever --update-crontab or whenever -i

IOError: Cannot run program "crontab" (in directory "C:\Users\Sriganeshk\Documents\Promaster4Rails"): CreateProcess error=2, The system cannot find the file specified
popen at org/jruby/RubyIO.java:4344
write_crontab at C:/jruby-1.7.15/lib/ruby/gems/shared/gems/whenever-0.9.4/lib/whenever/command_line.rb:72
run at C:/jruby-1.7.15/lib/ruby/gems/shared/gems/whenever-0.9.4/lib/whenever/command_line.rb:35
execute at C:/jruby-1.7.15/lib/ruby/gems/shared/gems/whenever-0.9.4/lib/whenever/command_line.rb:6
(root) at C:/jruby-1.7.15/lib/ruby/gems/shared/gems/whenever-0.9.4/bin/whenever:41
load at org/jruby/RubyKernel.java:1081
(root) at C:/jruby-1.7.15/bin/whenever:23
I dont know where I did wrong. Thanks for looking into this issue and some suggestions please.

The software utility Cron is a time-based job scheduler in Unix-like computer operating systems.

https://en.wikipedia.org/wiki/Cron

Thanks Javan. So it would not work on windows? For example, If I developed on LINUX and deployed to the windows OS, will it work?
Thanks for your response


/raw/language-resource-stopwords.txt corrupted

This file contains corrupted signs. Because of that both output files also contains corrupted letters.

I see. Any chance you could submit a fix for this?

i decided to remove the corrupted source. thanks!


Intents File - Missing Intents?

Trying to set this up and receiving the following error:
Error: There was a problem with your request: The intent 'DoSearch' was not found in the domain definition. Occurred in sample 'DoSearch search for {Artist}' on line 203.

I'll get this fixed tonight. Sorry about that.

No problem! Thanks for the awesome work on this, really appreciate it. Your instructions were nice and easy to follow.

just as appreciative !
getting this error
Error: There was a problem with your request: Unknown slot type 'MUSICARTISTS' for slot 'Artist'
i add MUSICARTISTS as a slot type as well as MUSICPLAYLISTS
and then i get the above error

You need to add the MUSICARTISTS slot type.  Previously, it was called MUSIC, but since I added support for playlists, it made sense to make it more descriptive and make room for other music slot types, too.
If you already had a MUSIC slot type, just make a new one with the same contents called MUSICARTISTS and delete the old MUSIC slot type.  You will also need to add a MUSICPLAYLISTS slot type and populate it with your playlists (kodi-slot-generator has been updated to add these).

Thats great ! thanks for your help. Added those slot types and ended up deleting the dosearch from the list and it solved the problem.

Should be fixed now.

Wait.. what commit fixed the missing DoSearch intent?

Gonna go ahead and say it's the one that's marked as adding the DoSearch intent ;)
https://github.com/m0ngr31/kodi-alexa/commit/d92652f459862c6625c91e520805b86eac1d074d

haha sorry, I guess I checked too soon.


feat: Add Embeds to Workspaces

Please provide enough information so that others can review your pull request:

Based on https://github.com/editor-js/embed this PR extends the functionality of workspaces to allow embedding media content etc from external sites.
Current services: Further services can be added with embed_services.js

youtube
vimeo
aparat
coub
imgur
gfycat
codepen
pinterest
twitter
twitch-video
twitch-channel
miro
yandex-music-track
vine
facebook
instagram

Explain the details for making this change. What existing problem does the pull request solve?

This embed service feature allows an organisation to add their own explainer videos etc into workspaces. Future development may include adding the ability to embed kanban boards and other data views.
The doctype for the Workspace_embed includes a "document_type" Link for future development.

Screenshots/GIFs

Can someone help me out here? I must have selected the wrong branch or something. I only have about 5 commits to merge.


Migrate code to Apache github

Once the SGA is submitted and the binaries are removed from third_party/ we can plan the move of the codebase from twitter github to apache github.
Via slack (Matteo Merli in the apache-incubator room) this can be done by renaming github twitter/heron to apache/heron-incubator`, by filing an apache INFRA request and granting Heron github admin access to the infra person helping out.

when setting up for Pulsar in incubator, last month, we have transferred the repo from yahoo/pulsar to apache/incubator-pulsar
and then asked INFRA to setup gitbox integration.
That makes the github repo to be the source of truth (all commits are merged on github and synced back into an ASF mirror)
also it controls the committers access through github account. Committers needs to link their github account with the apache id (on the gitbox setup page) and they’ll get write access to the github repo
(the nice part about transferring the repo, is that all the PRs issues are transferred as they are, with no disruptions. Also all the links to the old repo are still valid and will redirect to the new repo)

You just need to give admin access to the twitter/heron to someone from ASF INFRA. At that point he will be able to change the organization for the repo. For reference, that’s the jira issue we have created for it: https://issues.apache.org/jira/browse/INFRA-14376

Via discussion on the apache mailing list, the code can be migrated to Apache gitbox without the SGA, and non-Apache releases can be still made a that point, so consensus was reached that we should move forward on this.
@maosongfu we will need to coordinate this move so Twitter's CI can change the location of the git repo. When would be best to do this?

@maosongfu any comments on this? This is a blocker for the Apache migration.

@billonahill I have reported this to Twitter Lgeal and they are still working on it.

Thanks @maosongfu. Just to clarify, this ticket is to move the code to apache git which can be done in parallel with legal working on the SGA. The latter doesn't block the former.

Done.


Nuke MessagesDecoder

          You will NOT have the `l2ToL1Msgs`, the entire `MessagesDecoder` can be purged when this pr is in.

Originally posted by @LHerskind in https://github.com/AztecProtocol/aztec-packages/pull/5292#discussion_r1531900185

This is part of the #5073, closing this and expending the issue in #5073.


Add delayacct_blkio_ticks in /proc/[pid]/stat

sysstat(pidstat) use delayacct_blkio_ticks which is in /proc/[pid]/stat for computing process io delay, add this field to procfs will be nice.

 Go requires Linux >= 2.6.23 so we can for sure parse up to that field.
We would need to implement variable parsing to pull out the rest of the fields.


Update thanos engine and Prometheus dependencies

This commit bumps thanos/promql-engine to latest main and resolves breaking changes from the prometheus/prometheus dependency.

[x] I added CHANGELOG entry for this change.
[ ] Change is not relevant to the end user.

Changes
Update:

thanos/promql-engine to latest main
prometheus/prometheus to 2.46.1

Verification
Relying on tests.

Oh, can we merge thsi with https://github.com/thanos-io/thanos/pull/6648 together?  I have some wal compression fixes too there

Ah sorry, completely missed that PR. Maybe we can merge this one since the tests are now passing, and we can use the other one to enable subqueries in the engine.

Ah sorry, completely missed that PR. Maybe we can merge this one since the tests are now passing, and we can use the other one to enable subqueries in the engine.

Yeah lets do that ill just do the small changes in querier in a followup PR!


Incrementing hits in reports on ignored statements

Here is an new implementation of pull request #211.
By now it doesn't create new coverage object. Is there any implementation of extend() that I can use?

Any updates this PR?

LGTM except that the file coverage object is modified in place. We could use the clone library (https://www.npmjs.com/package/clone) to do the clone but that means that the object-utils file won't work on the browser.
For now could you just do a JSON.parse(JSON.stringify(obj)) to implement the clone? We can make it more fancy later by separating the cloner used for node versus browser.

It would be great to get this progressed and merged in. I just lost an hour trying to figure out why my /* istanbul ignore next */ statements seemed to be being ignored until I figured out that currently only the HTML reporter respects them.

This is affecting us as well because our CLI reporting is different from our CI reporting so I'd love to see this progress.

Sorry for delay, I'll finish work on this PR asap.

Same as @sh1mmer :smile:


HADOOP-18714. Wrong StringUtils.join() called in AbstractContractRootDirectoryTest

What changes were proposed in this pull request?
Fix assertion message in AbstractContractRootDirectoryTest by calling join(Object[], String) instead of join(T...) (where T was calculated to be Serializable).
Steps to reproduce:

Make AbstractContractRootDirectoryTest fail by commenting out the assertDeleted call inside the loop:

https://github.com/apache/hadoop/blob/964c1902c8054dfe13c787222a12fb0daf1aaab9/hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/fs/contract/AbstractContractRootDirectoryTest.java#L194-L201

Run TestHDFSContractRootDirectory:

$ mvn -DfailIfNoTests=false -am -pl :hadoop-hdfs -Dtest=TestHDFSContractRootDirectory clean test
...
[ERROR] Tests run: 9, Failures: 1, Errors: 0, Skipped: 0, Time elapsed: 1.708 s <<< FAILURE! - in org.apache.hadoop.fs.contract.hdfs.TestHDFSContractRootDirectory
[ERROR] testListEmptyRootDirectory(org.apache.hadoop.fs.contract.hdfs.TestHDFSContractRootDirectory)  Time elapsed: 0.011 s  <<< FAILURE!
java.lang.AssertionError:
listStatus on empty root-directory returned found:
[Lorg.apache.hadoop.fs.FileStatus;@73344c46 expected:<0> but was:<1>
	at org.junit.Assert.fail(Assert.java:89)
	at org.junit.Assert.failNotEquals(Assert.java:835)
	at org.junit.Assert.assertEquals(Assert.java:647)
	at org.apache.hadoop.fs.contract.AbstractContractRootDirectoryTest.testListEmptyRootDirectory(AbstractContractRootDirectoryTest.java:199)

https://issues.apache.org/jira/browse/HADOOP-18714
How was this patch tested?
$ mvn -DfailIfNoTests=false -am -pl :hadoop-hdfs -Dtest=TestHDFSContractRootDirectory clean test
...
[ERROR] Tests run: 9, Failures: 1, Errors: 0, Skipped: 0, Time elapsed: 1.711 s <<< FAILURE! - in org.apache.hadoop.fs.contract.hdfs.TestHDFSContractRootDirectory
[ERROR] testListEmptyRootDirectory(org.apache.hadoop.fs.contract.hdfs.TestHDFSContractRootDirectory)  Time elapsed: 0.011 s  <<< FAILURE!
java.lang.AssertionError: listStatus on empty root-directory returned found: HdfsLocatedFileStatus{path=hdfs://localhost:37225/test; isDirectory=true; ...} expected:<0> but was:<1>
	at org.junit.Assert.fail(Assert.java:89)
	at org.junit.Assert.failNotEquals(Assert.java:835)
	at org.junit.Assert.assertEquals(Assert.java:647)
	at org.apache.hadoop.fs.contract.AbstractContractRootDirectoryTest.testListEmptyRootDirectory(AbstractContractRootDirectoryTest.java:199)

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Logfile
Comment

+0 :ok:
reexec
0m 34s

Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s

No case conflicting files found.

+0 :ok:
codespell
0m  1s

codespell was not available.

+0 :ok:
detsecrets
0m  1s

detect-secrets was not available.

+1 :green_heart:
@author
0m  0s

The patch does not contain any @author tags.

+1 :green_heart:
test4tests
0m  0s

The patch appears to include 1 new or modified test files.

_ trunk Compile Tests _

+1 :green_heart:
mvninstall
40m 46s

trunk passed

+1 :green_heart:
compile
23m 58s

trunk passed with JDK Ubuntu-11.0.18+10-post-Ubuntu-0ubuntu120.04.1

+1 :green_heart:
compile
21m  1s

trunk passed with JDK Private Build-1.8.0_362-8u362-ga-0ubuntu1~20.04.1-b09

+1 :green_heart:
checkstyle
1m 14s

trunk passed

+1 :green_heart:
mvnsite
1m 42s

trunk passed

+1 :green_heart:
javadoc
1m 14s

trunk passed with JDK Ubuntu-11.0.18+10-post-Ubuntu-0ubuntu120.04.1

+1 :green_heart:
javadoc
0m 47s

trunk passed with JDK Private Build-1.8.0_362-8u362-ga-0ubuntu1~20.04.1-b09

+1 :green_heart:
spotbugs
2m 50s

trunk passed

+1 :green_heart:
shadedclient
23m 15s

branch has no errors when building and testing our client artifacts.

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
0m 59s

the patch passed

+1 :green_heart:
compile
24m 18s

the patch passed with JDK Ubuntu-11.0.18+10-post-Ubuntu-0ubuntu120.04.1

+1 :green_heart:
javac
24m 18s

the patch passed

+1 :green_heart:
compile
22m 36s

the patch passed with JDK Private Build-1.8.0_362-8u362-ga-0ubuntu1~20.04.1-b09

+1 :green_heart:
javac
22m 36s

the patch passed

+1 :green_heart:
blanks
0m  1s

The patch has no blanks issues.

+1 :green_heart:
checkstyle
1m  2s

the patch passed

+1 :green_heart:
mvnsite
1m 46s

the patch passed

+1 :green_heart:
javadoc
1m  7s

the patch passed with JDK Ubuntu-11.0.18+10-post-Ubuntu-0ubuntu120.04.1

+1 :green_heart:
javadoc
0m 47s

the patch passed with JDK Private Build-1.8.0_362-8u362-ga-0ubuntu1~20.04.1-b09

+1 :green_heart:
spotbugs
2m 55s

the patch passed

+1 :green_heart:
shadedclient
24m  7s

patch has no errors when building and testing our client artifacts.

_ Other Tests _

+1 :green_heart:
unit
18m 43s

hadoop-common in the patch passed.

+1 :green_heart:
asflicense
1m  0s

The patch does not generate ASF License warnings.

217m 20s

Subsystem
Report/Notes

Docker
ClientAPI=1.42 ServerAPI=1.42 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5578/1/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/5578

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell detsecrets

uname
Linux 8f8bb88f193d 4.15.0-206-generic #217-Ubuntu SMP Fri Feb 3 19:10:13 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/bin/hadoop.sh

git revision
trunk / f9c575d04f98585d3a5ba118929dc1a9aac8edbb

Default Java
Private Build-1.8.0_362-8u362-ga-0ubuntu1~20.04.1-b09

Multi-JDK versions
/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.18+10-post-Ubuntu-0ubuntu120.04.1 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_362-8u362-ga-0ubuntu1~20.04.1-b09

Test Results
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5578/1/testReport/

Max. process+thread count
3154 (vs. ulimit of 5500)

modules
C: hadoop-common-project/hadoop-common U: hadoop-common-project/hadoop-common

Console output
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5578/1/console

versions
git=2.25.1 maven=3.6.3 spotbugs=4.2.2

Powered by
Apache Yetus 0.14.0 https://yetus.apache.org

This message was automatically generated.

what about moving it to an assertj assert, something like
Assert.assertThat(fs.listStatus(root))
  .describedAs("ls /")
  .hasSize(0)

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Logfile
Comment

+0 :ok:
reexec
1m  4s

Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s

No case conflicting files found.

+0 :ok:
codespell
0m  1s

codespell was not available.

+0 :ok:
detsecrets
0m  1s

detect-secrets was not available.

+1 :green_heart:
@author
0m  0s

The patch does not contain any @author tags.

+1 :green_heart:
test4tests
0m  0s

The patch appears to include 1 new or modified test files.

_ trunk Compile Tests _

+1 :green_heart:
mvninstall
44m 37s

trunk passed

+1 :green_heart:
compile
25m 24s

trunk passed with JDK Ubuntu-11.0.18+10-post-Ubuntu-0ubuntu120.04.1

+1 :green_heart:
compile
22m 45s

trunk passed with JDK Private Build-1.8.0_362-8u362-ga-0ubuntu1~20.04.1-b09

+1 :green_heart:
checkstyle
1m 13s

trunk passed

+1 :green_heart:
mvnsite
1m 47s

trunk passed

+1 :green_heart:
javadoc
1m 18s

trunk passed with JDK Ubuntu-11.0.18+10-post-Ubuntu-0ubuntu120.04.1

+1 :green_heart:
javadoc
0m 50s

trunk passed with JDK Private Build-1.8.0_362-8u362-ga-0ubuntu1~20.04.1-b09

+1 :green_heart:
spotbugs
3m  3s

trunk passed

+1 :green_heart:
shadedclient
25m 21s

branch has no errors when building and testing our client artifacts.

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
1m  7s

the patch passed

+1 :green_heart:
compile
25m 45s

the patch passed with JDK Ubuntu-11.0.18+10-post-Ubuntu-0ubuntu120.04.1

+1 :green_heart:
javac
25m 45s

the patch passed

+1 :green_heart:
compile
23m  4s

the patch passed with JDK Private Build-1.8.0_362-8u362-ga-0ubuntu1~20.04.1-b09

+1 :green_heart:
javac
23m  4s

the patch passed

+1 :green_heart:
blanks
0m  0s

The patch has no blanks issues.

+1 :green_heart:
checkstyle
1m  4s

the patch passed

+1 :green_heart:
mvnsite
1m 46s

the patch passed

+1 :green_heart:
javadoc
1m  9s

the patch passed with JDK Ubuntu-11.0.18+10-post-Ubuntu-0ubuntu120.04.1

+1 :green_heart:
javadoc
0m 46s

the patch passed with JDK Private Build-1.8.0_362-8u362-ga-0ubuntu1~20.04.1-b09

+1 :green_heart:
spotbugs
2m 49s

the patch passed

+1 :green_heart:
shadedclient
25m 28s

patch has no errors when building and testing our client artifacts.

_ Other Tests _

+1 :green_heart:
unit
18m 46s

hadoop-common in the patch passed.

+1 :green_heart:
asflicense
0m 59s

The patch does not generate ASF License warnings.

230m 36s

Subsystem
Report/Notes

Docker
ClientAPI=1.42 ServerAPI=1.42 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5578/2/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/5578

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell detsecrets

uname
Linux c36dbe882dd6 4.15.0-206-generic #217-Ubuntu SMP Fri Feb 3 19:10:13 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/bin/hadoop.sh

git revision
trunk / 1af28d0222ac44b523e1acba119666e0bb4dbb72

Default Java
Private Build-1.8.0_362-8u362-ga-0ubuntu1~20.04.1-b09

Multi-JDK versions
/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.18+10-post-Ubuntu-0ubuntu120.04.1 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_362-8u362-ga-0ubuntu1~20.04.1-b09

Test Results
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5578/2/testReport/

Max. process+thread count
3153 (vs. ulimit of 5500)

modules
C: hadoop-common-project/hadoop-common U: hadoop-common-project/hadoop-common

Console output
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5578/2/console

versions
git=2.25.1 maven=3.6.3 spotbugs=4.2.2

Powered by
Apache Yetus 0.14.0 https://yetus.apache.org

This message was automatically generated.


Integrate gatewayapi.com for SMS sending

We need to create sys_objects_smsproviders table which will store all possible SMS integrations, so 3rd-party modules will be able to add own integrations.
sys_objects_editor can be used as example of similar method.

[ ] remake SMS sending to use universal class
[ ] integrate gatewayapi.com

I work for gatewayapi.com. Let me know if you have issues integrating.


GMIC not installing on Affinity Photo V2

Hi, it's not appearing in the Plugins list.  Not that Nik Collection 7 is either and I've emailed DxO about that.
I've followed the instructions that Nick Hayes (think that is his name) wrote in 2021.
Thanks for any help resolving this.

That sound like a bug in Affinity Photo 2. You should take it up with that program's developers.
I don't know if they changed the plugin install process since I wrote those instructions.

Thank you Nicholas for your reply. I'll do that.


Unable to create source: Error contacting source

After running docker-compose up or sandbox up and trying to add a new source I'm getting this error message.
level=error msg="Error message Error contacting source" component=server http_status =400

I'm facing the same problem

Is it possible that you have something running on the following ports: 8888 or 3010?

Experiencing the same issue (assuming this is from the chronograph logs, since mine show the same error) - when the sandbox is down nothing is running on 8888, 8086, or 3010. I'm able to get to Chronograph on port 8888 when it's up, but I can't create a new connection to the default http://localhost:8086 with a blank username and password.
InfluxDB seems to be running fine on that port, and I'm able to connect to it -
./sandbox influxdb
Entering the influx cli...
Connected to http://localhost:8086 version 1.4.3
InfluxDB shell version: 1.4.3

Docker port says the influxdb container is mapping 8086/tcp -> <IP_ADDRESS>:8086 just fine. I've tried restarting the sandbox as well.

hmmm... the data source configuration should appear like this:

try doing a ./sandbox docker-clean and then ./sandbox up

Ok, i figured out the problem...
just like @timhallinflux  mentioned, i changed localhost:8086 to influxdb:8086. it's working.
Anyone knows why??

We've eliminated the need to manually configure this.  Fixed by #27


Fix module objectfiles handling

Before adding new features and new modules, please go to issues to submit the relevant feature description first.
Write good commit messages and use the same coding conventions as the rest of the project.
Please commit code to dev branch and we will merge into master branch in feature
Ensure your edited codes with four spaces instead of TAB.

增加新特性和新模块之前，请先到issues提交相关特性说明，经过讨论评估确认后，再进行相应的代码提交，避免做无用工作。
编写友好可读的提交信息，并使用与工程代码相同的代码规范，代码请用4个空格字符代替tab缩进。
请提交代码到dev分支，如果通过，我们会在特定时间合并到master分支上。
为了规范化提交日志的格式，commit消息，不要用中文，请用英文描述。

need https://github.com/xmake-io/xmake/pull/5375

https://github.com/xmake-io/xmake/pull/5240 will no longer be necessary as this test is included in this PR

#5240 will no longer be necessary as this test is included in this PR

I will close it when this patch is merged.


Resolve merge conflicts

https://github.com/microsoft/OpenAPI.NET/pull/1704 looks like the correct PR yes?


Unsanitized Input

Hi guys how are you? It seems that in the execute_ws_function method there is a possible vulnerability.  the "text" parameter is being passed  without  any  sanitation or validation.  to implement appropriate measures for sanitizing and validating the input before utilizing it within the function, like for example subprocess module with the shlex.quote in python

Hey @0x5FE 👋
Thank you for opening this issue. I think actix should do some validation under the hood. However, I would like to give a deeper look in the issue 😄


Cydia Impactor completes, no unc0ver app

Describe the bug
Was able to finally get the Cydia Impactor to run without any errors. Looked at my homescreen, didn't see an unc0ver app. Went into Settings > General > Device Management > Choose my Developer App and Trusted. I see the unc0ver app as "verified", however, I don't see the app anywhere on my homescreen.
To Reproduce
Steps to reproduce the behavior:

Install
Read the description above

Screenshots
N/A
Device (please complete the following information):

iOS Version: 12.1.2
iOS Device: iPhone 6S+
unc0ver Version: ?

Place an "x" between the brackets if true:

[ ] this is a bug others will be able to reproduce
[ ] this issue is present with all tweaks uninstalled(except for default packages) or disabled
[ ] this issue is present after a rootfs restore
[ ] this issue is present on the latest version of unc0ver

Logs
N/A

The app showed up after a hard reboot.


Add option for shibboleth to get groups from LDAP only

Implementation for issue: https://github.com/rancher/rancher/issues/46258

Ping, any review?


use Colons instead of Backticks

In Azure Devops usually colons are used to surround mermaid diagrams in markdown files. Espacially in the Wiki colons are mandatory because backticks do not work there. Can you add the recognition of colons to the plugin so its behavior is identical to the Azure Devops default and the same syntax (and files) can be used in all locations?

Yes, it really makes sense recognition of colons. I'll try to add it.


upgrade sentry

to reproduce:
$ cargo upgrade sentry sentry-log sentry-panic sentry-anyhow                                                                                Upgrading sentry-panic v0.23.0 -> v0.24.1
    Upgrading sentry-anyhow v0.23.0 -> v0.24.1
    Upgrading sentry v0.23.0 -> v0.24.1
    Upgrading sentry-log v0.23.0 -> v0.24.1

In release notes there are breaking changes but I believe we're fine.

r? @Nemo157


Release GitHub Action does not work if release starts as draft

https://github.com/orgs/community/discussions/7118


TypeError: Cannot read properties of undefined (reading 'documentClass')

Hello!
I tried to change the default token settings on "token overrides" and it would not let me submit it and this error appears on the console:
foundry.js:5836
TypeError: Cannot read properties of undefined (reading 'documentClass')
at ClientDatabaseBackend._preUpdateDocumentArray (foundry.js:12586)
at ClientDatabaseBackend._updateDocuments (foundry.js:12533)
at ClientDatabaseBackend.update (commons.js:6320)
at async Function.updateDocuments (commons.js:5674)
at async TokenDocumentT20.update (commons.js:5771)
I managed to change it only on tokens that were already on scenes, and once I do I could not modify it anymore in any way.
I'm a noob, but tried to re-install everything, am I doing something wrong?

Could you please post the full versions of Foundry, the system you're playing, and the modules you have installed. If anything, try disabling other modules to make sure it's not Token-Ease.

I got it working!
I was changing configurations only on: Configure Settings>DefaultTokenSettings>TokenEase (Although I still could not change anything here)
In other hand on the Settings>TokenEase it functions normally without any errors detected. (I completely missed the configuration page)
Foundry version: https://foundryvtt.com/releases/10.285
System, Tomernta20 v1.4.006: https://foundryvtt.com/packages/tormenta20

I tested Token-Ease without any modules on, and got the same results.
But I think overall it's solved ^^ Thanks!

Closing as it cannot be reproduced


HHH-18327 Add Agroal and HikariCP settings constants

https://hibernate.atlassian.net/browse/HHH-18327

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license
and can be relicensed under the terms of the LGPL v2.1 license in the future at the maintainers' discretion.
For more information on licensing, please check here.

Could you squash all those commits into a single one please; you could, arguable, leave 820b1b8 as a separate one, but the rest is really about one single thing.


06/10/2018 21:47 : Create Pull Request for branch master -> prTesting1_2018061021

:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

split/updateTestCon1.md
:white_check_mark:Succeeded

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.


Jenkins builds timeout while waiting for executor

Description
We have a 15 minute timeout set for the "Build Release Tarball" phase. Occasionally time spent waiting for an executor seems to be counted against this budget, e.g.
https://builds.apache.org/blue/organizations/jenkins/CouchDB/detail/jenkins-cpse-debugging/14/pipeline/
I don't think that's the intention. I don't have time (hah!) to dig into it right now but wanted to file for posterity.
Expected Behaviour
The timeout should only start once an executor is allocated to that stage of the pipeline.

Rediscovered this and fixed it in #3913