feat(proto): Wrap string and int32 fields where necessary

feat(kubernetes): Add missing Kubernetes fields
A few fields were missing from KubernetesAccount. Add these.

feat(proto): Wrap string and int32 fields where necessary
This commit goes through all string and int32 fields, wrapping them where necessary. The only changes necessary were a few string fields.

Just enums left after this one!


Revert hosting startup packages to netcoreapp2.0 only

Fixes: https://github.com/aspnet/AzureIntegration/issues/66

Looks good to me.

?? The feature still works for net461, only the assembly discovery is different.

Hm, I thought hosting startups were for core only. Closing.

Should we cross-compile this project in that case?

Why is it required?

Microsoft.AspNetCore.ApplicationInsights.HostingStartup references the net461 build of Microsoft.Extensions.DiagnosticAdapter (which is cross-compiled for netcoreapp2.0 and net461). I'd rather we cross-compile and avoid the warning.

@Tratcher is cross-compiling fine?

Cross compiling should be fine.


[stable/atlantis] Atlantis v0.7.1

What this PR does / why we need it:
v0.7.0 release implements Server-Side Repo Config. Instead of values like requireApproval, requireMergeable, allowRepoConfig, Helm Chart should implement the Server-Side Repo config. Server-Side Repo Config is disabled by default and the default values are used. Similar to aforementioned values, which were set to false and therefore they didn't have any effect on Helm Chart.
Which issue this PR fixes
(optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close that issue when PR gets merged)

fixes #

Special notes for your reviewer:
Checklist
[Place an '[x]' (no spaces) in all applicable fields. Please remove unrelated fields.]

[X] DCO signed
[X] Chart Version bumped
[X] Variables are documented in the README.md

@hajnej Do you plan on addressing @lkysow's feedback? If yes, do you have an ETA? If not, would you be OK with someone else picking up and finishing this PR? E.g. I could pull your branch into my fork and create a replacement PR...

@sryabkov I apologize I was out of office. I would like to address @lkysow comments today.

Oops... looks I completely screwed the PR. I'll open the new one...


Linux groundwork

Allow to download dependencies and start kitematic under Linux using npm start.
ref #49

Thanks! It does run now once you have Node 0.10 installed, and then running npm install, npm start.
That being said, there is still some work for Kitematic to work on Linux.

Yes I know but I stopped here because next steps are not the same as mac and windows. From what I read on the bug report, most users (including me) would prefer to have kitematic talking directly to Linux host docker and not use VirtualBox + Boot2Docker. Which mean skipping setup screen and different code path for Linux. Any pointers on how it should be done ?
In the meantime can we merge this ? It is a least a first step and can help other devs looking to improve Linux support.

@moimael Thanks! I agree. Docker can run native on Linux, and it's unideal to run it in a VM.
@jeffdm can you review the code when you have a chance?

@moimael and @mchiang0610 when will this be merged in master ?

The merge has conflict now, it is related to the switch to Grunt. Btw why did kitematic switched to Grunt ?

Ha, this explain why my linux portage is working anyway without your merge request. This would mean that since the project has switched to Grunt, your pull request is no more needed, right ?

Looking!
In the meantime, sorry for the fast switch to Grunt. Many of the electron and atom community tools are written in Grunt and to keep up we'd need to maintain gulp-rewritten forks.

Hi, what is the status of this pull request, any chance to be merged ?
An ubuntu user who love good UI :)

@zedtux Any plan to merge your linux work ?

My pull request is over here: https://github.com/kitematic/kitematic/pull/696.

@moimael Would you mind closing this PR in favor of @zedtux 's PR https://github.com/kitematic/kitematic/pull/696 ?

Not at all, his work seems much more advanced !

:+1:


wip: verifier request signer

TBD if this PR is relevant given delegated verifier or if will be required for the verifier on the mobile device.

This is not needed for the DelegatedVerifier. The DelegatedVerifier hosts the DID document, and therefore the signing key for the request.

This is not needed for the DelegatedVerifier. The DelegatedVerifier hosts the DID document, and therefore the signing key for the request.

Do we need this for the verifier side on the mobile?

Closing, we can revive as needed.


Docs: Authentication Entity Updates For .NET

(docs): Making changes to the Authentication Entity documentation page to account for the differences between .NET and Node.js authentication implementations.
This PR takes care of #489.

@mulygottlieb - As discussed, and since the .NET auth behavior is different from the Node.js one- please share a doc with us that describes the auth behavior on .NET. Thanks!
@dericksozo - FYI

Thanks, @PazYanoverr @mulygottlieb. I'll keep posted for any additional materials.


Unhelpful error when running action

Hi, I'm trying to use your linting action but even though i've followed your set up steps, and running eslint locally, I get the below message. Any ideas?

hey @daniel-vc
Looks like it's a problem with your tests themselves regarding promise chaining.
Just to clarify: does it reproduce locally?

Hi, I have the same issue, and no, it is only in the actions. I don't have those messages locally. For me, it comes from your action!
You can see it right here: https://github.com/Skript-MC/Swan/runs/533285405?check_suite_focus=true

Hi there, I can confirm I'm getting the same warning.

Yes I also experienced this issue and found that it is caused by this issue https://npm.community/t/npm-ci-produces-a-tonn-of-excess-warnings-on-install/3261.
This can be fixed by upgrading the nodejs image used in the docker file. I tested using nodejs 12 (current LTS) and this issue went away. I Opened up #10 to help resolve the issue.

I had to remove this action from the workflow due to the same error. I'll be watching this issue to verify it's fixed with proposed solution (node upgrade)

I would actually recommend running ESLint without this action, because out of the box the ubuntu runtime of Github Action has everything we need now, like so:
name: CI
on: push
jobs:
  build:
    runs-on: ubuntu-latest
    steps:
    - uses: actions/checkout@v2
    - name: Install modules
      run: yarn
    - name: Lint
      run: eslint .

Now in the end, all this action is doing is running eslint inside a docker container. I'd say that we would be better off just not using docker at all and run eslint inside the normal runtime (which I hope is regularly updated)

Yes if we could just use ubuntu-latest that would be great.


Dynamic quote generator

Is your feature request related to a problem? Please describe.
A clear and concise description of what the problem is. Ex. I'm always frustrated when [...]
Describe the solution you'd like
A clear and concise description of what you want to happen.
Additional context
Add any other context about the feature request here.

I would like to work on this issue

this issue will count in crosswoc?

this issue will count in crosswoc?

Yes, But everytime specify the programs!! So that I can add the label

What level this project will be of?

This PR has been merged.


[CHALLENGE SUBMISSION] - Challenge7

Please provide the following information for your submission:
What is your name? (First, Last)
Franz Helmberger
Where is your GitHub Repo ?(With your challenge solution)
https://github.com/FranzHelm/hlc.25daysofserverless.chall7.git
What Challenge is this for? (Challenge number between 1 and 25)
7
(Optional) Anything else we should know? e.g., language used, location, blog post?

From all of us on the Cloud Advocacy team at Microsoft, thank you @FranzHelm for creating this issue!
Have a Happy Holiday season!

We checked out your repository. We're thrilled to say your solution is now listed in our Hall of Fame
Thank you for your contributions!
This issue is now resolved! 🎉


Update to monaco 0.33 & vscode 1.65

@mofux if you're still around here, I'd like you review as well

it looks like there is a CI/travis issue, can you merge it and release the next version @kaisalmen ?

Yes, I will merge and produce a release. The CI seems to not working at all. Something for the needs fixing list.

@CGNonofr On thing I overlooked. Shouldn't @types/vscode and "engines": { "vscode": "^1.50.0" } (client) be aligned. I could update and commit this on the master together with CHANGELOG.

I admit I have no idea what that engine if for

you rock

btw, what about taking back the @codingame/monaco-jsonrpc library as well?

Yes, good idea. that's already on the list for #315. I was even thinking about putting it as a sub-package in here?

By sub-package, do you still mean it will be a separate package on npmjs?


ux: clearer Find Groups copy

When the search times out, it could be due to multiple root causes.
This clarifies the message as it has caused confusion in UC Help a few times now:

Resolves #1666.
Preview
Before

After

@e-shee Any thoughts on the updated copy?
@urcades Any thoughts on the aesthetique?

Any suggestion for improvement I'd have is dependent on copy recommendations from @e-shee , but my gut instinct is to render this as a single line of discretionary text. I sketched this out -really- quickly here:

https://www.figma.com/file/sCFYLlAGjehlYXUkT2rarg/branch/yonw9FxqhTxghFHdjHkLBH/Product-Handoffs-(Locked)?node-id=2638%3A95369&t=Y7zMQLvWKMEbX23q-1
Ideally, if we had robust FAQ/Support capability, I'd also recommend a "Learn more" link, for people who are curious about the edges of p2p networking and its implications on product design.
Lastly, if you look to the frames below the linked one above, there are some additional search states that might be worth considering that we have yet to implement — in some cases (like a search that may have been mis-spelled, but comes close to a match in your network), I think the best outcome would be to find -something- we could recommend to people.

Hopefully this is helpful!

Any suggestion for improvement I'd have is dependent on copy recommendations from @e-shee , but my gut instinct is to render this as a single line of discretionary text. I sketched this out -really- quickly here:

https://www.figma.com/file/sCFYLlAGjehlYXUkT2rarg/branch/yonw9FxqhTxghFHdjHkLBH/Product-Handoffs-(Locked)?node-id=2638%3A95369&t=Y7zMQLvWKMEbX23q-1
Ideally, if we had robust FAQ/Support capability, I'd also recommend a "Learn more" link, for people who are curious about the edges of p2p networking and its implications on product design.
Lastly, if you look to the frames below the linked one above, there are some additional search states that might be worth considering that we have yet to implement — in some cases (like a search that may have been mis-spelled, but comes close to a match in your network), I think the best outcome would be to find -something- we could recommend to people.

Hopefully this is helpful!

@urcades Thanks for the prompt review and design. Just made the change and updated the screenshot above. I love both ideas for the FAQ link and the enhanced discoverability. Will create new follow up issues to track both.


Draw Root Handles Where They're More Visible

The root handles are often drawn under the dockable handles. This makes it impossible to use the root handle. Same goes for the new pin handles I'm adding.
I know it's probably impossible to fix this in every situation. But surely there's a way to improve it a bit.

Same for this situation. Can't dock to the bottom of a dockable that's really small at the bottom of the screen. Should make sure the handles stay on screen. Which might not really be possible with how we do mouse overs.

I've noticed that sometimes the center docking handles don't draw in the middle of the dockable panel. Seems to be something with floating a panel too early at startup, but then the handle locations never update again.

Same for this situation. Can't dock to the bottom of a dockable that's really small at the bottom of the screen. Should make sure the handles stay on screen. Which might not really be possible with how we do mouse overs.

I think this case is better addressed now that the handles are in the center of the JScrollPane viewport and not the center of the dockable. The painting is also better too.

What isn't better is the root handles. They're going to stay where they are for now. Finding a good place for them is difficult and moving them around isn't a little confusing as a user.

Closing this one for now. I don't think it's a big deal that they root handles are covered sometimes.


Bug: "Open in new window" follows the startup settings

Description
When I open a folder with "Open in new window", I expect only that folder to be opened in the new window. However, if the startup settings is "Continue where you left off", tabs in the original window are opened together.
Steps To Reproduce

Set the startup settings other than "Open a new tab".
Open a folder with "Open in new window".
Tabs other than the folder you want to open are also opened according to the startup settings.

Requirements
Only the selected folder should be opened in a new window.
However, if the user starts the app by specifying a folder from the command line, it should follow the startup settings as before.
Files Version
<IP_ADDRESS>
Windows Version
10.0.22621.1848
Log File
n/a

Thank you for reporting this issue.


Automatically generate prev/next

Is it possible to automatically generate the prev and next paths in the front matter?
I'm working on a site with a lot of content and manually setting these on each page is not feasible.  Is there some way to automatically generate the links (alphabetically ordering them, perhaps)?

Hello @zmb3 , it's not possible at the moment (and the website of Hugo does the same).
It's obviously a good idea but I'm not sure it's feasible with Hugo + Go templates. I'll look into it, unless you want to contribute on that ;)
For example, Position is a start. I don't think it was available when I created this theme.
Anyway, we should not generate it from alphabetical order, but from :

the weights of the pages in section > then by alphabetical order
menu order for chapter sections.

It's not so easy but if we can generate arrows at least for pages in the same section, it could be great !
Note : prev and next are optional and the theme is working well without them (but you loose the arrows).

Thanks for the response. I agree that even 1) would be a huge win.
I'm definitely willing to help out, but I'm not super familiar with hugo and themes so I'll need some guidance.

@zmb3 Done by @lierdakil !


Add JAX-RS PATCH annotation

What was changed? Why is this necessary?
From issue 21 JAX-RS does not have a PATCH annotation for supporting HTTP patch method like it does for others like GET or POST. We should add a PATCH annotation that can be used for handling the patch HTTP method.
How was it tested?
The PATCH annotation was tested by consuming this change in a test branch of a project that already consumes beadledom. In this project, a simple resource that uses the PATCH annotation was used to manually make sure that the behavior performed as expected. Two unit tests were also added to the project to 1. Ensure that PATCH is used and behaves as expected and 2. PATCH is used and performs an operation on the server to ensure that serialization works as expected.
How to test

[ ] mvn clean install -U

Reviewers

[ ] John Leacox
[ ] Sundeep Paruvu
[ ] Nimesh Subramanian
[ ] Supriya Lal
[ ] Brian van de Boogaard

I'm not sure exactly what we would say about it, but it seems like we would want to add the fact we added a @PATCH annotation to the manual for the jax-rs module

@b-boogaard what do you think of this? a1fac9f

I think I would add it either above or below the Correlation-Id header. I think I would want to link to https://tools.ietf.org/html/rfc5789 the rfc that added PATCH to HTTP. Then give an interface like example of a resource using it, pointing out it can be used just like the others that are defined by JAX-RS.
@johnlcox @sparuvu @lal-s @nimeshsubramanian thoughts?

@b-boogaard Interface example and link to RFC

How about something like:
JAX-RS 2.0 (see section 3.3 for Resource Methods) does not require implementations to support the PATCH HTTP method. This is likely do to the fact that PATCH was introduced in a later rfc that added the new HTTP method to the already existing HTTP/1.1 specification.
@PATCH was added to beadledom-jaxrs to allow services to support partial updates without the need of overloading @POST. The annotation has no opinion on how the service decides to implement the resource performing the PATCH operation. Implementing services have the freedom to support JSON Patch and/or JSON Merge Patch.
As long as a service has beadledom-jaxrs as a dependency @PATCH can be used just like any of the HTTP method annotations defined by JAX-RS. Below is a small example of @PATCH being used in an interface for a resource.
code example here
I think this could use a bit a clean up but I feel like it reads a bit better. Thoughts?

@sparuvu comments addressed here. @b-boogaard I went with Sundeeps description of the annotation in the jaxrs.rst. Concise, simple and exactly what the user needs to know. I removed the git url that was linked in the description because don't see how it relates to PATCH at all...

@sparuvu comments addressed here. @b-boogaard I went with Sundeeps description of the annotation in the jaxrs.rst. Concise, simple and exactly what the user needs to know. I removed the git url that was linked in the description because don't see how it relates to PATCH at all...

I think I like what Brian has. It is more detailed and more importantly it points that implementing services have the freedom to implement whatever PATCH algorithm they want to go with.

@sparuvu brian's version of jaxrs.rst bb8be52

+1 to @b-boogaard's doc text.

Will it be desired for beadledom to include a class with additional mediatypes like json-patch and json-merge-patch that can be used similarly to MediaType.APPLICATION_JSON?
This questions came to mind while looking at this review, but I think it would be a separate code change if it is desired.

@johnlcox we are planning to use json-merge-patch in our application so yes I would say that is a desired behavior.

I think adding the media types for patch is a good idea.

Is there any reason that adding the media types could not be done in this code change?

I'd rather see it as a separate code change because I think there needs to be some discussion on the strategy we want to use for supporting additional media types in general. This probably warrants starting with an issue for that discussion prior to any code changes.

+1

+1

I logged #37 for the media type discussion.

+1

+1


feat: port Analysis.Complex.UnitDisc.Basic

I (j-loreaux) marked this as resolved and just removed the norm_cast attribute. I think here norm_cast is justified in its complaint because both sides have a head coe. Note that this doesn't break anything downstream because this file has no dependents.

[x] coe_conj has a norm_cast error
Complex.UnitDisc.coe_conj (z : 𝔻) : ↑(conj z) = ↑conj' ↑z

bors merge


cleanup old examples

Remove old, broken examples in packages/examples/old. Some of these are V1, many are broken in both V1 and V2. I skimmed through them looking for examples that were worth preserving or translating to V2. I didn't see any which were particularly interesting, but open to suggestions.
There was also a site directory which contained a literal "lorem ipsum" placeholder page. I removed that too.
Red code is the best code :fire:
All Submissions:

[x] Have you followed the guidelines in our Contributing document?
[x] Have you checked to ensure there aren't other open Pull Requests for the same update/change?
[x] Does your submission pass tests?

@SimonClark might be interested in some of these. let's see if he is still following. ;)


remove interpolation in reader

Issue
The interpolation was originally implemented to fill striping in the S1 SD observations that appeared after regridding in the reader. However in combination with the wet snow mask the filling of empty pixels caused pixels that were masked for wet snow conditions to be filled with S1 SD values from its neighbors (in case the neighboring pixels have dry snow or no snow according to the S1 SD retrievals).
Solution
The interpolation was removed from the reader. If a pixel is classified as wet snow by the S1 SD retrieval algorithm, the gap will not be filled with values from its neighbors, and no SD observation will be assimilated.
However, when the LIS grid and the S1 SD retrieval grid don't match, some pixels might not have observations.
Testcase
A testcase was done and showed improved performance of DA after the interpolation was removed.

I adjusted the reader according to the comments.


[WIP] Some fixes to webhook logic and test e2e

Description

The pod namespace is read from the admissionReview.Request.
Some fixes in the nodeport update (peering_e2e).

/ok-to-test


SliverPersistentHeader docs need correction

https://api.flutter.dev/flutter/widgets/SliverPersistentHeader-class.html
"A sliver whose size varies when the sliver is scrolled to the leading edge of the viewport."
is incorrect.  The sliver changes its size when scrolled to the edge of the viewport that is in the opposite direction of the sliver's orientation.

Please assign to me


CSIS: RSI: General problem with RSI in privacy 1.2

Statement
Once the RPA changes, the new RSI (Resolvable Set Identifier) shall be generated and AD/SD data shall be updated as well with the new RSI value. This shall be done to avoid the tracking device. There shall not be condition that result in advertising old RSI using new RPA.
Background
If controller-based privacy is used, the HCI_LE_Set_Resolvable_Private_Address_Timeout is used to set "the length of time the Controller uses a Resolvable Private Address before a new resolvable private address is generated and starts being used" (Core 5.3 | Vol 4, Part E, 7.8.45).
Core 5.3 | Vol 3, Part C <IP_ADDRESS> Privacy feature in a Peripheral with Controller-based privacy
"If the advertising data or the scan response data change regularly then those changes should be synchronized with any changes in private addresses (both local and remote). For this purpose, the Host should either instruct the Controller to synchronize address changes with those data changes or, if the Controller does not support that feature, generate private addresses as described in Section <IP_ADDRESS> instead of offloading private address generation to the Controller."
Problem
The lack of synchronization in private addresses changes between controller and host. The host does not really know when RPA changed and when to provide new RSI.
Is it guaranteed that the RPA_Timeout is reset on HCI_LE_Set_Extended_Advertising_Enable/HCI_LE_Set_Advertising_Enable?
Maybe Controller might have a global RPA Timer, so that *_Enable command will cause to generate RPA for this advertising only, but the RPA might not last RPA_Timeout but change earlier. Such behavior makes the host impossible to track RPA changes even if it set and knows RPA_Timeout.
The synchronization would require some HCI vendor event so that the host would know when to change RSI.
Core says, that if there is no such synchronization, then Section <IP_ADDRESS> should be used (<IP_ADDRESS> Privacy feature in a Peripheral with Host-based privacy).
I see two options here:

To stop using Controller-based privacy at all when CSIS is enabled and just fall-back to Host-based.
1 + To have a HCI Zephyr-specific event that provides synchronization in private addresses generation, that could be used with Zephyr controller only.

Moreover, maybe this would require to raise an errata to Core.

ping @cvinayak @jhedberg @Emil-Gydesen-Bose @sjanc @rymanluk

Hi @MariuszSkamra
I remember this being discussed at the GAWG (ping @asbjornsabo @Rasmus-Abildgren-Bose) multiple times, and IIRC it would considered to be an implementation specific challenge.
IMO Coordinated Sets should never have been a GATT profile, as there so many challenges with the data that CSIS requires (LTK, RPA update, etc.).
I had not previously considered the approach of using a VS event to get the RPA; that's a good idea I think.
Perhaps a combination of the two options?
if (controller == Zephyr) {
    use vendor specific event to update RSI
} else {
    require host-based privacy
}

Removed the bug label: It's not really a bug, but a missing feature.

@jhedberg @alwa-nordic
We need to either be able to force Host privacy, or to use a Zephyr specific event to let an application to always know of RPA changes. Does CONFIG_BT_PRIVACY enable host privacy (rpa_expired is guarded by CONFIG_BT_PRIVACY)?

We need to either be able to force Host privacy, or to use a Zephyr specific event to let an application to always know of RPA changes. Does CONFIG_BT_PRIVACY enable host privacy (rpa_expired is guarded by CONFIG_BT_PRIVACY)?

We do not have a API for forcing Host privacy. CONFIG_BT_PRIVACY enables both host and controller privacy. But my understanding is that the current Host implementation does not use Controller privacy for advertising, except for directed advertising. So the problem does not exist yet. However, the all the points for concern stand. To be safe, we have to explicitly assert somewhere in code that we don't use Controller privacy when an rpa_expired event listener is installed.
The search term for finding the code that enables Controller privacy in the Host is "OWN_ADDR_RPA". For advertising, the following is the relevant bit of code.
https://github.com/zephyrproject-rtos/zephyr/blob/1eb9d36d46b6fcfff2696332ca51fd714eb788dc/subsys/bluetooth/host/id.c#L1595-L1606
For context, the following is the call watershed from Host API to bt_id_set_adv_own_addr.

@alwa-nordic Is it correctly understood that updating the RPA only happens in the host then?
We do have something like bt_rpa_create which is also called from the controller and called from ull_filter_rpa_update, which would indicate the the controller may also update an RPA for an advertising set.

@alwa-nordic Is it correctly understood that updating the RPA only happens in the host then?

For non-directed advertising, yes.

We do have something like bt_rpa_create which is also called from the controller and called from ull_filter_rpa_update, which would indicate the the controller may also update an RPA for an advertising set.

This should be controlled by own_addr_type from the HCI command. The Host will never set own_addr_type to "Please generate an RPA" for non-directed advertising.

Alright, thanks
@cvinayak Do you agree with Aleksander's comments?

This is no longer handled by the stack and should be handled by the application. Closing due to this.


Profile Card UI changes

Description
Dear Gitea developers!
I highly appreciate your afforts in Gitea development and wanted to thank you for its creation. This platforms is wonderful and had finally provided me an alternative to most Git hosting platforms like GitHub, GitLab. It's highly configurable, lightweight and has easy to use UI.
Nevertheless, with upcoming 1.13 release(which I am really hyped about because of Kanbans), I'd like to suggest you some changes in general UI. This change includes a new profile card which is shown on the profile page of user.
I’ve played with CSS of this profile card and, as a result, got a cleaner look on it: removed these gray/white borders around the whole card, made background to match page’s background, put description right under the profile picture and nickname, made profile picture rounded and made nickname/name fonts bigger a little bit so other users wouldn’t be overwhelmed by profile picture’s sizes. Also I removed icon from profile description because I though it’d look cleaner without any icons, except the ones included in profile description itself.
Why had I done so? Well, to be honest, I can’t fully answer to this question. Not because I have something to hide or pursue my personal goals but because I did so just because I had a feeling of GitHub’s UI looking somewhat stylish and clean. Not going to lie, I really like how GitHub looks like. That’s why this profile card UI reminds GitHub’s so much - I made it with minimalism and informativeness in mind while being inspired by GitHub’s design decisions.
I don't want to say that the whole UI code should be refurbished. But there could be little changes made so Gitea's general look could be improved a bit, made more minimalist, clean and kept highly informative.
I am looking forward for your feedback and opinions on these changes. Thank you for paying attention.
Screenshots

This screenshots shows current profile card which is a default for Gitea(the screenshot was taken from Codeberg website:

This screenshot shows a new profile card which is used on my own Gitea instance:

This screenshot shows a profile card which is currently used on GitHub and from which I've taken my inspiration:

This screenshot shows a profile card which is used by GitLab:

Last two screenshots were provided as a comparison to the changes I've made.

There're also other variants which would distinguish Gitea from other platforms in terms of profile page layouts and design - by using tear drops:

In my humble opinion, such kind of profile card looks even more stylish and distinguishing than using circled or boxed profile pictures

This is how the whole page would look like with arc-dark:

And this is the whole page with default gitea theme:

Should I change semantic.min.css file in the Gitea repository for this and make a pull request? And where would it be better to do - gitea.com website or on GitHub?

Should I change semantic.min.css file in the Gitea repository for this and make a pull request? And where would it be better to do - gitea.com website or on GitHub?

It will need to override any semantic styles, as semantic.min.css is pulled in directly.
Probably in _user.less.
The PR can be to here on GitHub, currently the repo on gitea.com is a mirror. 🙂

I personally like the teardrop. Could we use a instance-wide setting to control the shape of the profile picture?

@Extarys you can always add additional CSS to your deployment to customize your instance look

I like to stay square-shaped, if you like teardrops or circles, you can use gimp to modify your avatar. The other way around is mouch harder(you will get tiny images :( )
If liked I can provide some examples ...

I think https://codeberg.org/Codeberg/build-deploy-gitea/pulls/30#issuecomment-76507 got it the best ... let users deside themselve how they like to represent themselve
@unknownguydk just an idear: add a function to specify the shape on upload, may be an option to get all users happy?

I will be closing this issue for now because it has been inactive for nearly 3 months and I have nothing to add here. I highly appreciate your replies and suggestions, thank you for them! As far as I gain enough experience in web development, I will open a pull request with function in settings which would allow user to determine the shape of his profile card, therefore I would adopt @6543's suggestion.
Again, thank you and stay healthy 😄


How do I build without accessing to<EMAIL_ADDRESS>repogitory?

I want to build xen, domD, and domU for R-Car Starter Kit Premier(H3ULCB). (https://elinux.org/R-Car/Boards/H3SK)
And this repogitory supports H3ULCB as a target device.
However, the build with ninja process fails with an access denied error to get proprietary drivers.
After reading this issue, I understand that I can not access without NDA.
There is two questions.

But, how do I modify the build steps?
Is proprietary drivers different from this drivers?

Build environment
I used docker(devcontainer).

Please make sure you have the correct access rights
and the repository exists.
[16/30] git clone
ninja: build stopped: subcommand failed.

@tbistr
Unfortunately, mentioned prebuilt binaries can't be used, because they have no support for virtualization.
We have a few requests for work without proprietary repo, and we are working on the product without graphics - just a console with required backends.
We will inform you of updates when the product is ready. Very rough estimation - few weeks.


Missing text and segfault

With current git using remoteapp to 2008R2, the program starts ok, but various buttons that should have "ghosted" text are blank and xfreerdp segfaults as soon as I try to actually do anything. I get the same behavior with --gdi software or hw.
When using a complete desktop the font problem still occurs, but the segfault does not.

@meosborne: did this appear after yesterday's commits? try using --gdi sw with --no-bmp-cache to get the previous graphical rendering and see if it changes anything.

Just using --no-bmp-cache (without the --gdi sw) fixes the missing fonts. However the segfault still occurs.

@meosborne: for the missing fonts, do you have a particular failure case I could attempt to reproduce?
as for the segfault, could you compile with #define WITH_DEBUG_ORDERS 1 in orders.h and see what is the last graphical order before the segfault?

Done.  The two last messages are RemoteApp-specific. If you have a way to make it a crash everytime it would be perfect, so I could reproduce it.

@meosborne: I think I found what the source of the problem was for the missing text: the server sends a mem3blt message for text that is grayed out. since it was unimplemented I just disabled it.

The missing text problem is solved, but I still a segfault under remoteapp. The program main screen appears and it pops up a small window for a login. I can fill in this window and login and the program attempts to redraw the background of the main window.  The background should be a picture of the company logo.

still get segfault using remoteapp with current git.

Can you compile using WITH_DEBUG_RAIL? I never could reproduce the issue

Done.


snap-add-pmat naming inconsistancy Warning

Hi there
I have this problem appearing when running the following command
$ snaptools snap-add-pmat --snap-file possorted_bamwt.snap --peak-file peaks.combinedWT.bed
***** WARNING: File /tmp/tmp9ff841ln has inconsistent naming convention for record:
b'chr13'	64267370	64267591	AAACGAAAGCAACTGG-1
***** WARNING: File /tmp/tmp9ff841ln has inconsistent naming convention for record:
b'chr13'	64267370	64267591	AAACGAAAGCAACTGG-1

Hi,
I'm having a similar issue. Depending on which sample I run, the line/chromosome returned will be different. In the peaks.combined.bed file there was no b in front of the chromosome identifier. Might this be the cause?
bed:
chr1 | 3061013 | 3061213
chr1 | 3094639 | 3095566
chr1 | 3113486 | 3114089
error:
***** WARNING: File /tmp/tmpukodzuzj has inconsistent naming convention for record:
b'chr10'	13594002	13594363	AAAAAAAAAAAAAAAA
***** WARNING: File /tmp/tmpukodzuzj has inconsistent naming convention for record:
b'chr10'	13594002	13594363	AAAAAAAAAAAAAAAA

Hi this is an issue caused by python 3.6 or above. I am aware of this issue for a while but did not have a time to fix it. Would it be possible to used python 2.7 for now? I will try to fix once I got sometime
--
Rongxin Fang, Ren Lab
Ludwig Cancer Research
Bioinformatics Ph.D. Student
University of California, San Diego

On Sep 23, 2019, at 12:58 AM, Camiel Mannens<EMAIL_ADDRESS>wrote:
Hi,
I'm having a similar issue. Depending on which sample I run, the line/chromosome returned will be different. In the peaks.combined.bed file there was no b in front of the chromosome identifier. Might this be the cause?
bed:
chr1 | 3061013 | 3061213
chr1 | 3094639 | 3095566
chr1 | 3113486 | 3114089
error:
***** WARNING: File /tmp/tmpukodzuzj has inconsistent naming convention for record:
b'chr10'	13594002	13594363	AAAAAAAAAAAAAAAA
***** WARNING: File /tmp/tmpukodzuzj has inconsistent naming convention for record:
b'chr10'	13594002	13594363	AAAAAAAAAAAAAAAA
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub https://github.com/r3fang/SnapTools/issues/17?email_source=notifications&email_token=ABT6GGYCACMGUQQI4PDHYP3QLBZKVA5CNFSM4IWGOOX2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD7KCDGQ#issuecomment-533995930, or mute the thread https://github.com/notifications/unsubscribe-auth/ABT6GG5OWHR3OQJN3VB7LO3QLBZKVANCNFSM4IWGOOXQ.

Hi there
I confirm that it was due to running Snaptool on python 3.7. I have run it again on python 2.7 and it worked flowlessly
thanks

Thanks for letting me know.
Sent from my iPhone

On Sep 24, 2019, at 10:37 AM, yasserIRCM<EMAIL_ADDRESS>wrote:
Closed #17.
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub, or mute the thread.

Hi Dr. Fang,
I also came into this issue when using 'snap-tools snap-add-pmat' under python 3.7. My snap-tools version is 1.4.8. I notice that snap-tools over 1.4 should work with python 3.
The reporting warning is identical to the issue reported here. It appears one 'b' in front of ever read.
***** WARNING: File /tmp/tmp9qreqg_y has inconsistent naming convention for record:
b'chr1' 47904687        47904739        AAAAAAGAACCTAATT
***** WARNING: File /tmp/tmp9qreqg_y has inconsistent naming convention for record:
b'chr1' 47904687        47904739        AAAAAAGAACCTAATT
Could please help me with it? Thanks a lot!


paste with keyboard shortcut into window not possible

pasting text with keyboard shortcut (cmd-V) into a window is not possible now, for reasons explained here:
http://stackoverflow.com/questions/970707/cocoa-keyboard-shortcuts-in-dialog-without-an-edit-menu
(there is also a workaround here).

Has this ever been solved?

I solved this by overriding NSTextField like explained on StackOverflow. Overriding NSApplication should also work but needs changes in your Info.plist which was not practicable for me.
You can check my changes in the following commit: https://github.com/cbenhagen/rumps/commit/1c00fa2edb5eb46ae89bf883b9661e67be5d4995


check for existing messages before attempting to resume

since resume option is default, dump_messages
will raise an exception the first time it runs
because there are no existing messages
this PR adds a line to check for existing messages before adding the after param
alternatively, this could be handled by failing with an error message instructing the user to disable resume for the first run. not sure which is best!

@rgaudin :thumbsup:
great work btw. this is awesome


Build Error: C1010

Screenshot
https://drive.google.com/file/d/1ZxdY_cPAB0tMYQR5dG5GkCwyU0XyZXrK/view?usp=sharing
Severity	Code	Description	Project	File	Line	Suppression State
Error	C1010	unexpected end of file while looking for precompiled header. Did you forget to add '#include "pch.h"' to your source?	VAC-Bypass	C:\Users\calvi\source\repos\VAC-Bypass\VAC-Bypass\dllmain.c	24
Severity	Code	Description	Project	File	Line	Suppression State
Error	C1010	unexpected end of file while looking for precompiled header. Did you forget to add '#include "pch.h"' to your source?	VAC-Bypass	C:\Users\calvi\source\repos\VAC-Bypass\VAC-Bypass\Hooks.c	95
Severity	Code	Description	Project	File	Line	Suppression State
Error	C1010	unexpected end of file while looking for precompiled header. Did you forget to add '#include "pch.h"' to your source?	VAC-Bypass	C:\Users\calvi\source\repos\VAC-Bypass\VAC-Bypass\Utils.c	61

Cant help you if you password protect it. Upload to imgur or paste it in here.

Woops. I didn't know that. It should now allowed for open access.

Hmm, im going to pull latest and see if I have that issue

Seems to be an issue with building x64, try doing x86 since that what csgo is.

Build as x86 and close

I finally able to build the VAC-Bypass.dll
How to inject to Steam.exe?

I have tried to use VAC-Bypass-Loader https://youtu.be/K7JP-5fMwZU
but it did not work.

This tool doesn't unban you. VAC can see your steamid so you will stay banned and will be kicked from VAC secured servers.

Then what is the purpose of this VAC Bypass?

To disable VAC client-side so you don't get banned.

I tested on Left 4 Dead 2 my Single Player still get a VAC ban


had to set domain to make it work

Using React & Express.js, the examples were not enough for me.
Took me a while before I figured out I had to do the following on the serverside (after installing the middleware) to make it work:
req.universalCookies.set('name','value', { domain:req.headers.origin,path: '/' });

Have you tried to only include the path? It's pretty much the first time I see this problem.

ok, it's now also not working with the code I posted above, something else must be going on.
My server setup:
import * as cookiesMiddleware from 'universal-cookie-express';
....
this.app = express();
this.app.use(cookiesMiddleware());

When a login request turns out to be successful at the server:
req.universalCookies.set('cdlAuth', hash, { path: '/' });

The response in the chrome debugger Network tab shows that a cookie was returned

However in the Application tab under cookies I don't see it listed, even after pressing the refresh button in that panel.

When I refresh there is no cookie found:
const Cookies = require("universal-cookie");
//....
componentWillMount() {
    const cookies = new Cookies();
    var hash= cookies.get('cdlAuth');
    if (hash) {
         //this doesnt trigger on refresh
   }

Ive turned off any plugin that may be blocking the cookies, and I've tried adding a domain as posted initially. Any idea what Im doing wrong?

@flyon It looks like your cookie is being set on your AJAX domain, which is different than your Website domain am I right?
If you don't need the data and only need to save it for subsequent requests, you can use the withCredentials option. This is by far better if it needs to be secure. You might want to use httpOnly cookies too.
If you really need the data, I would suggest returning it somewhere in the body or header of the request and then saving it in the cookies in JavaScript.
Hope it helps

@eXon I think the domains are the same, but I switched to setting the cookie in the browser, and that works. Thanks!


How to require subproperties

Given the following spec:
swagger: '2.0'
info:
  title: Title
  version: 1.0.0
paths:
  /a:
    post:
      parameters:
        - in: body
          name: A
          required: true
          schema:
            $ref: '#/definitions/A'
      responses:
        201:
          description: Success

definitions:
  A:
    type: object
    properties:
      b1:
        $ref: '#/definitions/B'
      b2:
        $ref: '#/definitions/B'
  B:
    type: object
    properties:
      num:
        type: integer
      str:
        type: string

Is it possible to require A.b1.num and A.b2.str (but not A.b1.str and A.b2.num)?
I know I can set either property of B to be required, but then it will be required for A.b1 and A.b2.

I tried the following with no luck:
swagger: '2.0'
info:
  title: Title
  version: 1.0.0
paths:
  /a:
    post:
      parameters:
        - in: body
          name: A
          required: true
          schema:
            $ref: '#/definitions/A'
      responses:
        201:
          description: Success

definitions:
  A:
    type: object
    properties:
      b1:
        $ref: '#/definitions/C'
      b2:
        $ref: '#/definitions/D'
  B:
    type: object
    properties:
      num:
        type: integer
      str:
        type: string
  C:
    allOf:
      - $ref: '#/definitions/B'
    required:
    - num

  D:
    allOf:
      - $ref: '#/definitions/B'
    required:
    - str

You're close, but have some syntax errors in your definition.  This is the right approach:
swagger: '2.0'
info:
  title: Title
  version: 1.0.0
paths:
  /a:
    post:
      parameters:
        - in: body
          name: A
          required: true
          schema:
            $ref: '#/definitions/A'
      responses:
        201:
          description: Success

definitions:
  A:
    type: object
    properties:
      b1:
        $ref: '#/definitions/C'
      b2:
        $ref: '#/definitions/D'
  B:
    type: object
    properties:
      num:
        type: integer
      str:
        type: string
  C:
    allOf:
      - $ref: '#/definitions/B'
      - required:
        - num

  D:
    allOf:
      - $ref: '#/definitions/B'
      - required:
        - str


[Bug]:The model will return wrong or duplicate data

As shown in the figure, use XDPX-based one-click inference

There is a bug in the data processing pipeline. We will work on fixing it as soon as possible.

@kdy1999 the issue has been fixed. You can now pull from the latest branch.


PWM on PB8 and PB9 do not work on Cerb

Although missing 2 PWMs in define (issue PORT #37) but PB8 and PB9 are not 2 last, so it should not raise exception "Out of Array".
But fixing PORT #37 can correct this issue.

Issue could not reproduce. Similar ghi-electronics/TinyCLR-Ports/issues/37


HSEARCH-1917 Don't add null or empty values to the facet field

great! merged, but also backporting to 5.5 now..

We recently started upgrading to hibernate search 5.5 from 5.0 and ran into this same issue.  What is the timeline for releasing the backport version 5.5.3.Final as this is blocking our upgrade plans.

@xyloman good to now!
We can make a release happen soon; With some luck I could manage tomorrow, otherwise beginning of next week should be possible.

Hello, it was released yesterday.
On Wed, 20 Apr 2016, 22:34 xyloman<EMAIL_ADDRESS>wrote:

We recently started upgrading to hibernate search 5.5 from 5.0 and ran
into this same issue. What is the timeline for releasing the backport
version 5.5.3.Final as this is blocking our upgrade plans.
—
You are receiving this because you modified the open/close state.
Reply to this email directly or view it on GitHub
https://github.com/hibernate/hibernate-search/pull/1001#issuecomment-212616353


Annotation error: CHEBI:34393 is not an antibiotic (only antiseptic / disinfectant)

4-chloro-3,5-dimethylphenol (CHEBI:34393) should not be a CHEBI:36047 (antibacterial drug / antibiotic).
See https://en.wikipedia.org/wiki/Chloroxylenol
for the compound and
https://en.wikipedia.org/wiki/Antiseptic and https://en.wikipedia.org/wiki/Disinfectant for distinctions.

Hi Bastien,
Sorry it took so long to get to this!
Thanks for pointing out the error, which has now been corrected.
Best regards,
Gareth


Prevent self variables from leaking into global namespace

Fixes #288
There was a missing step in the instructions of that issue. The problem only occurs after running validation. Prior to this change toolbar.js was leaking the variable self into the global namespace and that variable was overwritten later on by validation.js. The fix is to keep those variables properly scoped.

Great to catch this. It probably explains behaviour I couldn't figure out, where I was trying to fix function and data references and seemingly having to resort to this." vs. "self. ____ vs this.dh. etc. patches.  Looking forard to testing this later today or tomorrow morning.

Looking good!


Copy-DbaDatabase force/withreplace issue fix

Fixes #1270 #1271
Changes proposed in this pull request:

Withreplace parameter now pushed into restore
Force parameter sets/implies withReplace
underlying issue where the restore smo connection was being closed also fixed (this is the bit that took the time)

How to test this code:

[ ]
[ ]

Has been tested on minimum requirements:

[ ]  Powershell 3
[ ]  Windows 7
[ ]  SQL Server 2000

Has been tested on maximum requirements:

[ ]  SQL Server vNext
[ ]  Windows 10
[ ]  Azure Database

Tests for tester:

[ ] Working/useful help content, including link to command on dbatools web site
[ ] All examples work as advertised
[ ] Does not contain template content
[ ] Does not contain excessive/unnecessary amounts of comments
[ ] Works remotely
[ ] Works locally
[ ] Works on lower versions or throws error specifying version not supported
[ ] Works with named instances
[ ] Works with clustered instances
[ ] Handles offline/read only databases
[ ] Supports multiple servers (at the command line or piped from Get-SqlRegisteredServerName)
[ ] No un-handled errors which stop the command working with multiple servers

You're the best 🏅 (really! thank you.)


Can't access Page on Page close event

Page close event should fire before unload Page.
Steps to reproduce
What steps will reproduce the problem?
Please include code that reproduces the issue.
  page.once('close', () => {
    console.log('Page closed!');
    let cookies = await page.cookies();
    console.log(cookies );
  });

What is the expected result?
print out cookies.
What happens instead?
error

We don't have an event that page is about to close; if we were to have one, it wouldn't work since there'll be a race condition between page closing and your script querying for cookies.
However, since cookies are stored inside browser context, it will be enough to just query context for cookies. There's a FR for this: #645
Closing this in favor of #645.


Bump package_info_plus dependency range

Would be great to get this released fast.

LGTM

@mateusfccp Could you release this please when you get a chance.

Released as 3.0.1.

Thanks!


Latin charset missing recognition

Current Behaviour (for problems)
When loading csv file with latin char inside, char are not recognised
Expected Behaviour
Latin charset should be recognised ;-)
Steps to Reproduce

Open Data Curator using the icon
File - Open - Semi colon separated

comcant.txt
(I had to rename csv file to .txt to upload)
Your Environment

Data Curator version: 0.13.2
Operating System and version: Windows 10

I confirm, as you can see in screenshot below, accents appears in original csv file:

Sorry I can't replicate the error

or as a header

Yep, it seems there's an encoding issue. I have to:
1- Save xlsx as text unicode file
2 - Open txt file into notepad
3- Ensure encoding is set to utf8
4 - Replace all tab by semi-colon
5 - Save ac csv
A little bit boring ;-)
Do you have any shortest way?
By the way, I hope that with xls issue fixing, I could forget this way in many case.

When I save as CSV I have only:

Closing as this appears to be a data source issue. Please reopen if problem with Data Curator can be demonstrated


Can't delete meeting using API.

Hello,
I created a meeting using API and now trying to delete it using API.
I am using this document https://docs.microsoft.com/en-us/graph/api/onlinemeeting-delete?view=graph-rest-beta&tabs=http  to delete meeting.
But it throws this error while deleting-
Array
(
[error] => Array
(
[code] => BadRequest
[message] => Invalid meeting id<EMAIL_ADDRESS>[innerError] => Array
(
[request-id] => b4492244-bf52-4454-896b-79257377774a
[date] => 2020-05-11T11:47:35
)
)
Thanks.

@Digesha , What endpoint you are trying to call? Could you please try to call:
DELETE: https://graph.microsoft.com/beta/me/onlineMeetings/{id}
It works at our end. Let me know how it goes

Please feel free to reopen if you have further query


docs(alwaysdata): fix casting

alwaysdata starts with lowercase a. It is there naming convention I think
https://www.alwaysdata.com/en/
https://www.linkedin.com/company/alwaysdata/

In docs, for consistency, first case is always upper


Fix for issue #108

Thanks!

My pleasure. Do you have plans already when this will be released on nuget?


[bug] assetScope is inconsistent between absolute and relative paths

Describe the bug
(Report after discussion on Discord with @FabianLars and @lucasfernog)
When using relative paths with assets protocol in the current tauri version, you need to explicitly specify paths to have files whitelisted.
Indeed, when using absolute path, you use glob patterns:
/home/myUser/myapp/* => Works for every file in this folder
/home/myUser/myapp/myimage.png => Works for this specific file

But when using a relative to binary path, glob doesn't work
mySubfolder/* => 403 for every file in this folder
mySubfolder/myimage.png => Works for this specific file

There are possible workaround e.g.:

Specifiying every file manually inside assetScope array
Adding the folder at runtime

Reproduction

Create an empty app
Enable asset protocol
Specify CSP to allow asset URL
Put the picture inside the subfolder (in debug CLI, this folder will be relative to src-tauri/, in release mode relative to .exe file)
Add this picture to html body (using convertFileSrc to get asset.localhost or asset:// url)
Reproduce both scope configuration to notice the bug

Expected behavior
No response
Platform and versions
Environment
› OS: Windows 10.0.22621 X64
› Webview2: 108.0.1462.54
› MSVC:
- Visual Studio Build Tools�2019
› Node.js: 16.17.1
› npm: 8.15.0
› pnpm: Not installed!
› yarn: Not installed!
› rustup: 1.24.3
› rustc: 1.63.0
› cargo: 1.63.0
› Rust toolchain: stable-x86_64-pc-windows-msvc
Packages
› @tauri-apps/cli [NPM]: 1.2.2
› @tauri-apps/api [NPM]: 1.2.0
› tauri [RUST]: 1.2.2,
› tauri-build [RUST]: 1.2.1,
› tao [RUST]: 0.15.8,
› wry [RUST]: 0.23.4,
App
› build-type: build
› CSP: default-src 'self'; img-src 'self' asset: https://asset.localhost
› distDir: ../dist
› devPath: http://localhost:1420/
› framework: React
› bundler: Vite
App directory structure
├─ .git
├─ .github
├─ dist
├─ node_modules
├─ public
├─ src
└─ src-tauri
Stack trace
No response
Additional context
No response

I'm trying to reproduce this with the API example. So I modify the configuration to allow "src/lib.rs" on the allowlist scope. Then I run fetch(window.__TAURI__.tauri.convertFileSrc('src/lib.rs')).then(console.log) and it gives me a 403 since we canonicalize the path before checking if it's allowed. So relative paths shouldn't work at all. Can you share a repo I can use to see what you've done?

Here's a minimal example:
https://github.com/Elanis/tauri-5896-example
If you replace "assets/img/achievements.png" by "assets/img/*" for example, it doesn't work anymore

So I think this is only an issue on Windows, on macOS it always gets rejected. The fallback here might be the problem. I can check this after the holidays, I don't have Windows access right now.

Thanks for the investigation !
Indeed, I didn't try on Linux or MacOS, might be Windows only.

Specifying the relative path assets/img/achievements.png in the scope works because we canonicalize the path, and since it exists it will return the absolute form of it, which can be matched against the path given in the asset protocol. In this case, this is the scope:
Scope { allowed_patterns: ["\\\\?\\C:\\Users\\username\\projects\\tauri\\tauri\\tauri-5896-example\\src-tauri\\assets\\img\\achievements.png", "assets\\img\\achievements.png"], forbidden_patterns: [] }

When we change the scope to allow assets/img/*.png, the *.png file does not exist in that folder, so the scope is different:
Scope { allowed_patterns: ["\\\\?\\assets\\img\\*.png", "assets\\img\\*.png"], forbidden_patterns: [] }

We should either block relative paths from the scope (I believe this was a concern raised by @tweidinger but we didn't handle this case) or prepend the CWD path in the scope so instead of \\\\?\\assets\\img\\*.png it would be \\\\?\\C:\\Users\\username\\projects\\tauri\\tauri\\tauri-5896-example\\src-tauri\\assets\\img\\achievements.png.


[improve][pip] PIP-343: Use picocli instead of jcommander

Fixes #xyz

Main Issue: #xyz

PIP: #xyz

Motivation

Modifications

Verifying this change

[ ] Make sure that the change passes the CI checks.

(Please pick either of the following options)
This change is a trivial rework / code cleanup without any test coverage.
(or)
This change is already covered by existing tests, such as (please describe tests).
(or)
This change added tests and can be verified as follows:
(example:)

Added integration tests for end-to-end deployment with large payloads (10MB)
Extended integration test for recovery after broker failure

Does this pull request potentially affect one of the following parts:

If the box was checked, please highlight the changes

[ ] Dependencies (add or upgrade a dependency)
[ ] The public API
[ ] The schema
[ ] The default values of configurations
[ ] The threading model
[ ] The binary protocol
[ ] The REST endpoints
[ ] The admin CLI options
[ ] The metrics
[ ] Anything that affects deployment

Documentation

[x] doc
[ ] doc-required
[ ] doc-not-needed
[ ] doc-complete

Matching PR in forked repository
PR in forked repository:

Due to the large scope of refactoring, I need to split the PR:

[x] https://github.com/apache/pulsar/pull/22209

bin/pulsar-admin
bin/pulsar-client
bin/pulsar-shell

[ ] TODO

bin/pulsar
bin/pulsar-perf

When #22209 is merged, I apply to refactor pulsar-perf module


feat(blob): add clientPayload and tokenPayload

This PR allows clientPayload during upload, so you can attach
metadata to the file uploaded to Vercel Blob. This metadata will be sent as
tokenPayload by default in uploading completed callbacks. And you can also enrich
it/configure it/verify it.
Usage:
// client.ts
import { upload } from '@vercel/blob/client';

upload(
  'file.txt',
  {
    access: 'public',
    handleUploadUrl: '/api/upload',
    clientPayload: JSON.stringify({ postId: 123 })
  }
);

const jsonResponse = await handleUpload({
  body,
  request,
  onBeforeGenerateToken: async (pathname, clientPayload) => {

    return {
       tokenPayload: clientPayload // this is the default, ideally you would verify the clientPayload (format, authorization) before generating the token, so no files are uploaded without first verifying the client claims
    };
  },
  onUploadCompleted: async ({ blob, tokenPayload }) => {
    console.log('blob upload completed', blob, tokenPayload);
  }
});

An example use-case of this feature would be to allow editing the images of a
blog post. To do so you would use clientPayload: JSON.stringify({ postId: 345 }) in the browser. Then, either in onBeforeGenerateToken or in onUploadCompleted
you would verify that the client making the call is allowed to modify this
postId (authorization) and update your database accordingly.
BREAKING CHANGES:

metadata in onBeforeGenerateToken and onUploadCompleted has been renamed to tokenPayload

TODO before release:

[ ] modify edge-functions to accept tokenPayload AND metadata
[ ] test on staging for real
[ ] update front PR documentation

I just noticed we need to update edge-functions to send the tokenPayload instead of the metadata to the webhook (not the webhook itself luckily)


feat: server compression

This PR adds in support for Http Content Compression in ZIO-HTTP's Server.
What could be improved

Support for CompressionOptions

Demo
https://user-images.githubusercontent.com/21025968/152762392-06621810-89cf-4759-8354-9a697f0f6dbf.mov

Codecov Report

Merging #971 (b3aeda9) into main (c2ed52e) will increase coverage by 0.00%.
The diff coverage is 60.00%.

@@           Coverage Diff           @@
##             main     #971   +/-   ##
=======================================
  Coverage   55.73%   55.74%
=======================================
  Files          71       71
  Lines        2232     2237    +5
  Branches       56       57    +1
=======================================
+ Hits         1244     1247    +3
- Misses        988      990    +2

Impacted Files
Coverage Δ

zio-http/src/main/scala/zhttp/service/Server.scala
45.58% <33.33%> (-0.57%)
:arrow_down:

...io-http/src/main/scala/zhttp/service/package.scala
100.00% <100.00%> (ø)

...http/service/server/ServerChannelInitializer.scala
94.11% <100.00%> (+0.36%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c2ed52e...b3aeda9. Read the comment docs.

Closing this PR for now. Will raise after fixing issues.


Missleading documentation

In the readme:
"cas.lua will return 1 if the element is added, 0 otherwise."
But cas return 0 if element not in the filter and 1 otherwise.

You are right, it's fixed now. Thanks.

Thank you for such a good implementation. I'm using it in production. cas is great.
By the ways, the same wrong description is in the cas.lua header comments.

Thanks. Also fixed in cas.lua.


Assert that OnICEConnectionStateChange doesn't incorrectly report disconnected

Your environment.

Version: 20f2d1899ebbbdb3879444a03a7dc956a3b51126
Browser: Chrome 78.0.3904.97
Other Information - running Pion in a remote docker container.

What did you do?
Established a connection with a remote server.
What did you expect?
The peer to stay connected with the server until it decides to close the connection.
What happened?
On Chrome, the connection is being closed (going to a disconnected state) 30 seconds after being established.
After some debugging it seems this method is responsible for closing the connection:
https://github.com/pion/ice/blob/37bfc6f4d997e5a6d9e836fd9607b9c9aefbc2b6/agent.go#L769
Some lines that appear to be relevant from the debug log:
ice INFO: 2020/02/04 13:25:33 Setting new connection state: Checking
ice DEBUG: 13:25:33.768620 agent.go:1143: adding a new peer-reflexive candidate: $remote:43116
ice TRACE: 13:25:33.816489 agent.go:639: Set selected candidate pair: prio<PHONE_NUMBER>314175487 (local, prio<PHONE_NUMBER>) host $local:39823 <-> prflx $remote:43116 related :0 (remote, prio<PHONE_NUMBER>)
ice INFO: 2020/02/04 13:25:33 Setting new connection state: Connected
ice DEBUG: 13:25:34.015233 agent.go:1143: adding a new peer-reflexive candidate: $remote:1619
ice DEBUG: 13:25:34.253331 agent.go:1143: adding a new peer-reflexive candidate: $remote:48095
ice DEBUG: 13:25:34.446345 agent.go:1143: adding a new peer-reflexive candidate: $remote:42324
....
ice INFO: 2020/02/04 13:26:05 Setting new connection state: Disconnected
ice INFO: 2020/02/04 13:26:05 Setting new connection state: Closed

In this example, after the call to adding a new peer-reflexive candidate: $remote:1619, I see no more traffic coming from $remote:43116 but I still see traffic coming from the other candidates.
The selected candidate pair candidate pair doesn't change though which results in the connection timing out.
While the connection is established I can receive the audio/video tracks in the browser as expected.
For some reason Firefox doesn't seem to have the same problem.
Albeit I'm seeing a single adding a new peer-reflexive candidate in that case :thinking:
Any suggestions to further debug this?

Apparently our handling of the Disconnected state was incorrect.
The connection can still be reestablished after moving to that state.
There is still a disconnect the first time the client connects but I suppose that's expected for some reason?

We have just encountered the same problem and after A LOT of debugging, we found this case happens when multiple ICE candidate pairs are marked as valid.
One of them goes to disconnected or failed, and because we hooked OnConnectionStateChange (webrtc.ICEConnectionStateDisconnected) to our cleanup function, the connection was torn down.
Is this a bug or just the weird/bad WebRTC API causing problems?

Oof sorry about that @LanderN
Let me write a test that asserts that Disconnected only gets fired when ALL are disconnected. Disconnected is also not a fatal state, pion/webrtc will try to reconnect so maybe I wouldn't hang up right away.
Thanks for reporting the bug, and will get that fixed this weekend!

Hey Sean, that sounds great!
Reading the linked issue and the discussion around it, would you suggest a manual call to peerConnection.Close() after the ConnectionState has gone to failed or would that be unnecessary in the proposed implementation? I do have some other state attached to each connection that I would like to clean up when possible, I assume this should be dealt with on a change to closed?

Sorry I haven't dealt with this yet :( I just haven't had the bandwidth.
If people are interested in contributing a simple test would be great here! Using vnet establish two valid candidate pairs, but then cause one to go to disconnected.
You should assert that webrtc.ICEConnectionStateDisconnected is not fired.

@rahulnakre @scorpionknifes if either of you are interested I think this would be a fun issue to look into! Even if this bug doesn't happen anymore this would be a great test to have :)

hey, I'll take a look when I get the chance, thanks!

Go for it @wtsiamruk! Sean is super friendly and open to community participation! Given that no one else has picked this one up for over a year I think you're good to give it a go.

Fixed by https://github.com/pion/ice/commit/67cc918a518d3b3dd1887b07434331dabc846702
pion/ice internally would spawn a new goroutine for each ICEConnectionState. This could cause things to get delivered out of order. We now use one routine and deliver in order.


CORE-10678 Make subsequent MGM Registrations Fail

Make subsequent MGM Registration's fail. When registering the MGM check if there is already a registered MGM for a given holding identity and fail if it has status approved. Prevent concurrent registrations for the same holding identity by keying the registrations request topic by holding id short hash.
To help with robustness. I have also made the database operations: PersistGroupPolicy and PersistMemberInfoHandler idempotent (PersistGroupParametersInitialSnapshot was made idempotent as apart of CORE-10347). I have also MGM Registration so that we persist the registration request with status approved as the last database operation. Previously we were doing that at the beginning, this means that MGMRegistration will now be retried, if database operations fail (see CORE-9972).
Examples
Registration status endpoint after registering an MGM twice:
curl --fail-with-body -s -S --insecure -u admin:admin -X GET  https://localhost:8888/api/v1/membership/A1BA22CF875E/7a52b4fd-3593-4f2a-917c-430db3a0bd75
{"registrationId":"7a52b4fd-3593-4f2a-917c-430db3a0bd75","registrationSent":"2023-03-07T12:16:48.063Z","registrationUpdated":"2023-03-07T12:16:50.668Z","registrationStatus":"INVALID","memberInfoSubmitted":{"data":{"registrationProtocolVersion":"1","corda.session.key.id":"4B31A4AC802E","corda.ecdh.key.id":"6EBA7116B94D","corda.group.protocol.registration":"net.corda.membership.impl.registration.dynamic.member.DynamicMemberRegistrationService","corda.group.protocol.synchronisation":"net.corda.membership.impl.synchronisation.MemberSynchronisationServiceImpl","corda.group.protocol.p2p.mode":"Authenticated_Encryption","corda.group.key.session.policy":"Combined","corda.group.pki.session":"NoPKI","corda.group.pki.tls":"Standard","corda.group.tls.version":"1.3","corda.group.tls.type":"OneWay","corda.endpoints.0.connectionURL":"https://corda-p2p-gateway-worker.williamvigor-mgm:8080","corda.endpoints.0.protocolVersion":"1","corda.group.truststore.tls.0":"-----BEGIN CERTIFICATE-----\nMIIBSzCB8aADAgECAgECMAoGCCqGSM49BAMCMB4xCzAJBgNVBAYTAlVLMQ8wDQYD\nVQQDDAZyMy5jb20wHhcNMjMwMTEzMTYyNzU0WhcNMjMwMjEyMTYyNzU0WjAeMQsw\nCQYDVQQGEwJVSzEPMA0GA1UEAwwGcjMuY29tMFkwEwYHKoZIzj0CAQYIKoZIzj0D\nAQcDQgAEXUeAx/hgsvduAG3I6mNJ3a21gngAqNEgEpx/t8x+U32Ja4mfjaYDlEDt\ngxu8m2qLTDB1p31/XwLJsZXxRLTrNqMgMB4wDwYDVR0TAQH/BAUwAwEB/zALBgNV\nHQ8EBAMCAa4wCgYIKoZIzj0EAwIDSQAwRgIhAMaucrweYGt9GeIpmDz3TztcZswe\nQ16vXJ+vyaCgFDVoAiEAlNAhrytnZiCHfyJ76X+h5bEokvPcxsODFJpM765+Vd8=\n-----END CERTIFICATE-----\n","corda.group.truststore.session.0":"-----BEGIN CERTIFICATE-----\nMIIBSzCB8aADAgECAgECMAoGCCqGSM49BAMCMB4xCzAJBgNVBAYTAlVLMQ8wDQYD\nVQQDDAZyMy5jb20wHhcNMjMwMTEzMTYyNzU0WhcNMjMwMjEyMTYyNzU0WjAeMQsw\nCQYDVQQGEwJVSzEPMA0GA1UEAwwGcjMuY29tMFkwEwYHKoZIzj0CAQYIKoZIzj0D\nAQcDQgAEXUeAx/hgsvduAG3I6mNJ3a21gngAqNEgEpx/t8x+U32Ja4mfjaYDlEDt\ngxu8m2qLTDB1p31/XwLJsZXxRLTrNqMgMB4wDwYDVR0TAQH/BAUwAwEB/zALBgNV\nHQ8EBAMCAa4wCgYIKoZIzj0EAwIDSQAwRgIhAMaucrweYGt9GeIpmDz3TztcZswe\nQ16vXJ+vyaCgFDVoAiEAlNAhrytnZiCHfyJ76X+h5bEokvPcxsODFJpM765+Vd8=\n-----END CERTIFICATE-----\n"}},"reason":"Registration failed, there is already an approved registration for A1BA22CF875E with id 967022b7-b550-48ec-ac60-1f98d7afa334."}%

Merge https://github.com/corda/corda-api/pull/904 first.

A couple of comments at the high-level approach:

It would be good to have some more user-friendly reason messages when the registration is declined. An easy way could be to just check if there's already a successful registration for the MGM in the DB with a different ID. This could maybe help us make the behaviour a bit more reasonable too, i.e. fail follow-up registration requests regardless of their content. Alternatively, we could perform the same checks on member info / group policy with a query from within the mgm registration service where we'll be able to provide better messages, but the first approach sounds better to me.
Inside the persist group policy handler, I agree with you that we need to have a serial number. For now, we could read the latest, increment it and update. When we get to MGM re-registration, we can see what we do at the user level, i.e. if we expose the version there too (I think it might make things a bit more complicated because they will have to provide two versions, one for member info and one for group policy, but we can see then).
It seems we currently publish the registration requests into Kafka with a registration ID as a key (see MemberResourceClientImpl.startRegistration()). We could use the short hash of the registering identity as a key to ensure requests for the same identity are processed sequentially, which could help generally (but more specifically with the check described above against previously approved registrations). Worth checking with @yift-r3 on whether there was a specific reason for using the registration ID as a key first.

I rebased so I could change the base branch (original unrebased branch kept here WillV/CORE-10678-Duplicate-Registrations-Should-Be-Invalid-original):
git rebase -i --onto origin/release/os/5.0-Beta2 origin/release/os/5.0 WillV/CORE-10678-Duplicate-Registrations-Should-Be-Invalid
Conflicts when applying ec3055999:
diff --cc components/membership/membership-persistence-service-impl/src/test/kotlin/net/corda/membership/impl/persistence/service/handler/PersistMemberInfoHandlerTest.kt
index dc5ae6b92,8faa1033c..000000000
--- a/components/membership/membership-persistence-service-impl/src/test/kotlin/net/corda/membership/impl/persistence/service/handler/PersistMemberInfoHandlerTest.kt
+++ b/components/membership/membership-persistence-service-impl/src/test/kotlin/net/corda/membership/impl/persistence/service/handler/PersistMemberInfoHandlerTest.kt
@@@ -1,7 -1,7 +1,8 @@@
  package net.corda.membership.impl.persistence.service.handler

  import net.corda.crypto.cipher.suite.KeyEncodingService
 +import net.corda.crypto.core.ShortHash
+ import net.corda.data.CordaAvroDeserializer
  import net.corda.data.CordaAvroSerializationFactory
  import net.corda.data.CordaAvroSerializer
  import net.corda.data.KeyValuePairList

fa9f922fc:
diff --git a/gradle.properties b/gradle.properties
index 2d3f8aa49..ad2a06185 100644
--- a/gradle.properties
+++ b/gradle.properties
@@ -40,7 +40,7 @@ bouncycastleVersion=1.72
 # Corda API libs revision (change in 4th digit indicates a breaking change)
 # Change to 5.0.0.xx-SNAPSHOT to pick up maven local published copy
 #cordaApiVersion=5.0.0.xxx-SNAPSHOT
-cordaApiVersion=<IP_ADDRESS>3-Gecko-beta+
+cordaApiVersion=<IP_ADDRESS>3-alpha-1677769862520

 disruptorVersion=3.4.2
 felixConfigAdminVersion=1.9.26
@@ -112,7 +112,7 @@ unirestVersion = 3.14.1
 jettyVersion = 9.4.49.v20220914
 # Enables the substitution of binaries for source code if it exists in expected location
 # Default behaviour is false.
-compositeBuild=false
+compositeBuild=true
 cordaApiLocation=../corda-api
 cordaCliHostLocation=../corda-cli-plugin-host
 jibCoreVersion=0.22.0

9dd0d11d8:
diff --cc components/membership/membership-persistence-service-impl/src/test/kotlin/net/corda/membership/impl/persistence/service/handler/PersistGroupParametersInitialSnapshotHandlerTest.kt
index 6d97a2de4,0a5d588b3..000000000
--- a/components/membership/membership-persistence-service-impl/src/test/kotlin/net/corda/membership/impl/persistence/service/handler/PersistGroupParametersInitialSnapshotHandlerTest.kt
+++ b/components/membership/membership-persistence-service-impl/src/test/kotlin/net/corda/membership/impl/persistence/service/handler/PersistGroupParametersInitialSnapshotHandlerTest.kt


fix(cover): disable pause button if not in motion

A small UX/UI improvement given that you cannot pause while in a stopped state.
Examples:
In a closed state pause is disabled:

While opening pause is available:

While closing pause is available:

In a opened state pause is disabled:

Some covers, like zwave ones, only reports their state at the end of the movement. Disable the button will remove the stop feature for this kind of cover.

I see. Well the most important aspect I imagine is to maintain maximum compatibility with devices. Not sure there is really an easy solution unless you actually made it user controlled if they know what their device supports which doesn't seem nice to clutter the edit interface either. I'll go ahead and close this. I may merge it into in my fork still for my use case and keep the fork in sync with your upstream changes since I know my cover supports progression tracking.


Metadata Mapping?

Hello!
My use case is slightly different, but I'm wondering:
I have multiple plugins on my WP site that all require the same metadata. This requires a lot of cutting and pasting.  I'm looking for a way to map selected metadata fields from one post_type (in my case, "podcast" to "videos") to another to reduce the amount of cutting and pasting.
Can metacopy handle this?

Hi Michael, your use case is not currently supported, but it would make an interesting new feature to add to the plugin.
Theoretically an option to just choose the destination post type and then the specific post would work, but it would still be one-by-one. The "select which fields you want to copy over" is a good thing to add to the current process as it would allow a more fine-grained use (maybe an "Advanced" button or something like that).
To do it in bulk I think it could be implemented as a wizard, first you choose the source and the destination post types, then it enumerates the metadata fields present in the source that will be copied and then you specify something to actually match the posts in both types, for example the title so that metadata from podcast "December 22, 2023" can be copied to video "December 22, 2023" (multiple fields could be used too but it may be overkill). The tricky part would be making it work as a background process to avoid hitting the max request timeout (thus making it usable on shared hosting providers).
So in complexity terms there isn't too much to solve, the thing is having time to actually implement it.
What do you think, which option would be better?

Thanks for the interest!
I'd envision where the user has drop downs to select the source metadata fields - with (user provided) sample metadata in the fields so the user doesn't have to know the exact name of the source metadata fields.
There would then be the same option for the destination.
This could then be set as a template. That way the next time this needs to be done, the process could be replicated.
Mapping one at a time isn't an issue if they are all on the same page. However, I can see if someone uses this for 100 fields, they're going to ahve to click "execute" 100 times which would be undesireable.
I'd also have an option to create a new post in that specific post_type so the user doesn't have to create the post, then use this tool. Essentially, this tool can also create a new post and then map the metadata.
I don't know how common this request is, but....using WP as a Content Management System, I have multiple podcast destinations present on the same post_type Post.  This means I often need to copy and paste the same data on the same page into multiple fields.  Thus, your plugin would also need the ability to map metadata to the same post type on the same post.
Happy to do a screen record to showcase this.
Thanks again!


update to go1.18

Summary

update to go1.18

Ticket Link
n/a
Release Note
update to go1.18

if we approve this, i will update the github check


SSH key is not associations with worker nodes

Welcome to Amazon EKS Blueprints!

[X] Yes, I've searched similar issues on GitHub and didn't find any.

Amazon EKS Blueprints Release version
latest
What is your environment, configuration and the example used?
Terraform v1.1.9
self_managed_node_groups = {
linux = {
node_group_name = "linux"
subnet_type            = "private"
launch_template_os     = "amazonlinux2eks" # amazonlinux2eks or bottlerocket or windows
remote_access = true
public_key   = "key-3"
ec2_ssh_key   = "key-3"
ssh_security_group_id = aws_security_group.ssh_sg.id
What did you do and What did you see instead?
I am trying to create self managed node with association  SSH key. But after creation  EC2 node does not have SSH key
Additional Information
No response

@vara-bonthu mind taking a look at this one?

Closed in #876


Details page to display the configuration of a project

This PR implemented a new project details page that shows the configuration at the time of project creation. Currently, only the project title, authors, and description can be changed. Close #823

Nice!
I would expect to see the model stuff also grouped into a grey box with a title. Do you agree?

Thanks for the changes. I think we can merge, isn't it?


Add scope components

hmm this should already be the case because of https://github.com/Astrocoders/bs-react-native-paper/blob/master/bsconfig.json#L14


Improve make_timeline.py

util/make_timeline.py is super useful for making timelines, but a few things that could be improved.
(1) delete abilities with the same name at the same time (or within <0.25 or some tolerance) to avoid spamming.
(2) if an ability has no name, label it --sync-- instead of blank
(3) handle overlapping syncs.  By default, everything without a window looks 2.5 seconds behind and 2.5 seconds ahead.  If there's an ability that triggers every second repeatedly (multiple explosions, etc), then the timeline will have multiple lines whose syncs overlap with each other.  I think in these cases, the syncs should be commented out and maybe a #collision comment added.
If anybody wants to contribute some small fixes, these sorts of things would be super appreciated! <3

look up unknown abilities from xivapi
have test_timeline.py find and auto-test against N fflogs fights so you don't have to specify them all individually
have test_timeline.py auto-test against N fights and be able to print out average deviation of when things happen (and then be able to adjust the timeline to match them?)

if a parameter is valid for make_timeline but not test_timeline (or vice versa) allow those parameters to silently (or with a warning?) be ignored, rather than not running at all (so that you can switch from make to test and vice versa without having to edit the command line)

Any chance you would be willing to turn all this into a checklist? (Or, if you like, I guess I could open a new and more generic issue to cover all the timeline stuff.) I'll probably look at more of this in a month or so after I finish Heavensward's dungeons out.
I think it might also be worth folding some of check_translation's functionality into translate_fight, maybe expanding that a little in some way, and writing up some documentation on it (maybe similar to what I did for documenting trigger construction?) I know for me right now the translations are a bit of a pain because there's no built-in functionality to arrange/format them as I prefer, so there's a decent bit of (admittedly technically unnecessary) effort there.
And then I guess maybe a first-pass naive auto-generation of Oopsy files via a scan through the log for E0000000::?

[ ] delete abilities with the same name at the same time (or within <0.25 or some tolerance) to avoid spamming.
[ ] handle overlapping syncs. By default, everything without a window looks 2.5 seconds behind and 2.5 seconds ahead. If there's an ability that triggers every second repeatedly (multiple explosions, etc), then the timeline will have multiple lines whose syncs overlap with each other. I think in these cases, the syncs should be commented out and maybe a #collision comment added.
[ ] look up unknown abilities from xivapi
[ ] if a parameter is valid for make_timeline but not test_timeline (or vice versa) allow those parameters to silently (or with a warning?) be ignored, rather than not running at all (so that you can switch from make to test and vice versa without having to edit the command line)
[ ] -lf should be able to autopick the zone and find the timeline without passing -t when using test_timeline
[ ] have test_timeline.py find and auto-test against N fflogs fights so you don't have to specify them all individually
[ ] have test_timeline.py auto-test against N fights and be able to print out average deviation of when things happen (and then be able to adjust the timeline to match them?)

Ooh, thanks. I'd forgotten about "unknown lookup from XIVAPI", that might affect what I'm doing with the translation tools right now, so definitely something to think about.
On auto-selecting the timeline for test_timeline, that's probably doable but would require a bit of restructuring. Currently, the script has no way of "knowing" which instance an encounter takes place in at any given pair of timestamps. Further, because -lf is simply looking for any ability to start the encounter, there's no good way to say "this line tells you which timeline to use". Off the top of my head, I'm seeing the algorithm working sort of like this:
encounter_start = zone_seal_or_attack_line
if encounter_start is zone_seal:
    search_timelines_for_zone_seal(zone_seal)
else search_timelines_for_attacker_NPC(attack_line)

That's probably not the best way to go about it, but given that there is no standard convention on how to name timeline/trigger files, I don't see a way to avoid reading through the raidboss directory to find the start line if we do something like this.
The other option is to build a map of instance/filename pairings and keep it updated. Then we could just have -lf silently include the instance name when an encounter is specified, look it up from the map, and select the timeline file from there. It would be more manual work to update this every patch, but it would save time iterating through the raidboss folder to find the appropriate timeline every time the script is called. (The other other option here would be to save state across calls, but that's well beyond what I'm able to do.)

I think many of these have been done at this point, so I'm going to close this issue.


Drop usage documenation from README.md

Closes #119

Perhaps converting the documentation page to markdown and using jekyll would help?


Created Guide in markdown

Did some visual modifications.
Need to think of how to add pictures on guides, currently left a placeholder.

I need to close this pull request. Requests have not been signed. Changes have been included in another branch. https://github.com/Project-Catalyst/project-catalyst.github.io/tree/add-proposal-guide


[BUG] Inconsistent order when retrieving assets from gallery in iOS

Describe the bug
The assets retrieved from the gallery ("recent" album), returned by both getAssetListPaged and getAssetListRange are not in the correct order shown in the Photos app gallery from iOS.
To Reproduce
Steps to reproduce the behavior:

Call PhotoManager.getAssetPathList(onlyAll: true) to get the path to the "recent" album in iOS
Using the path, call either getAssetListPaged or getAssetListRange
Display the assets retrieved in a grid/list view and check the ordering of the assets against the ordering in the gallery from Photos in the iPhone
The assets retrieved from either getAssetListPaged or getAssetListRange have a different order than the assets shown in the Photos app for the same album ("recent").

Expected behavior
The same ordering from the Photos app in iOS is expected for the assets retrieved to show them to the user.
Flutter version

Smartphone (please complete the following information):

Device: iPhone XR
OS:iOS 14.6

I was not aware that filterOption can provide ordering capabilities as well, if anyone encounters this, please do as following:
// configure here the type of ordering you wish and if it should be in ascending or descending order
final filterOption = FilterOptionGroup()
      ..addOrderOption(
        const OrderOption(type: OrderOptionType.createDate),
      );

    final paths = await PhotoManager.getAssetPathList(onlyAll: true, filterOption: filterOption);


re-architure into a SSR-capable spa in CF worker or pages

frontend should be built with vite + preact

maybe honox

or monkey patched SSR , by mangling serverStatic in hono middleware

https://github.com/cloudflare/wrangler-action


pass arges to bad_acme so it can print acme path in error

What does this PR do?
passes args to functions so path can be printed

Motivation

was using the wrong version of the script and the error messages were not being printed correctly
More

[ ] Added/updated tests
[ ] Added/updated documentation

Additional Notes

Hello @butlerx,
Many thanks for your interest in the project.
Your PR seems to be a duplicated of #3116
This PR fix the probelm by deleting the $1 option which is not needed.
I close your PR.


Places Panel Resize Bug

Fix issue where the Places Panel's style errs after moving panel and resizing from small to large width.

Closed by #33.


int8_t scroll wheel movement (not used)

How would I implement scroll wheel? I'm guessing the USB Host library needs to be updated in order for HID reports to show.

Actually, I was able to implement it for my gaming mouse (6 buttons, 16bit x,y and wheel) by following your library examples and treating my mouse as a joystick. Thrustmaster example is easy to modify. Thanks for the helpful library and okay to close this issue.

Actually, I was able to implement it for my gaming mouse (6 buttons, 16bit x,y and wheel) by following your library examples and treating my mouse as a joystick. Thrustmaster example is easy to modify. Thanks for the helpful library and okay to close this issue.

Oh, and another quick note: wheel is signed char and not int8_t as I had originally stated.

Oh, and another quick note: wheel is signed char and not int8_t as I had originally stated.


Option to set TCP_NODELAY

Recently, I have noticed my query preparations and executions take ~50ms but I could not tell why.
Today, I got the luck to find this.
I checked and this is the issue I have with skunk and postgres.
To lower my query latencies, I would like to set TCP_NODELAY in skunk. The option is supported in fs2 Socket and it should only be a matter of making it available in Session.pooled.

The fs2 socket options changed between CE2 version of fs2 and the CE3 version of fs2.
For better API stability, we may need to migrate skunk to cats effect 3 before making the socket options available in the Session API.

Thanks, I will look into this. I haven't really spent any time optimizing yet.


Getting "Fatal: Fatal: config cannot be loaded: ciphertext verification failed"

Output of restic version
This is a version with with I get the errors still:
restic 0.16.4 compiled with go1.21.6 on linux/amd64
This was the version I was running prune (while B2 hit the capability cab), that started the problem:
restic 0.13.1 compiled with go1.18 on linux/amd64
What backend/service did you use to store the repository?
Regular B2.
Problem description / Steps to reproduce
Not entirely sure.
I was running a prune of a big backup (about 40TB of size), just during the prune, the B2 backend hit the download limits and stopped providing data.  Attached a log while this happened:

After this probably a faulty initialization of a snapshot, see another screenshot below.
After this I am just getting  ciphertext verification failed for all operations I try.
Expected behavior
Any interupted operations should not corrupt the repository.
Actual behavior
Getting "Fatal: Fatal: config cannot be loaded: ciphertext verification failed"
Even if I try unlock or unlock --remove-all from a different host.
Do you have any idea what may have caused this?
The B2 hit the download capability limit, and didn't provide anymore downloads during the prune operation.
I was using resticker container, which does some weird initialization try if operations fail, so it could have tried to re-initialize, see below:

So a combination of these could have caused this. Ie first downloadcap reached, then resticker trying to-reinitialize without an ability to download anything.
Did restic help you today? Did it make you happy in any way?
Love restic anyway, I hope there is a way to recover.

O.o . Judging from the error messages your repository is currently a mix of the original state and some reinitialized files. Please check whether there's still an old version of the config file stored at B2. If yes, please restore it and also remove the new key file created on 05/28/2024 from the keys folder.  That should be sufficient to revive the repository.
(It is sort of possible to recreate a fake config file if absolutely necessary. That would allow reading from the repository, however, it would break deduplication for new backups).
The init command checks that there is no config file before initializing a repository. However, before restic 0.15.0 the error handling in the B2 backend for that particular check was broken. It considered errors to mean that no config file exists. Apparently, I've accidentally fixed that bug in restic 0.15.0 while simplifying the backend implementation. So please use restic 0.16.4 everywhere to avoid this bug in the future.


Extra Shorthands

I think we forgot to mention shorthands for flex and flex-flow.

Also:

grid
overflow
outline
list-style

Not really sure if I simply did something wrong on my side, but couldn't get these to work, while border-top etc. worked fine, maybe they are missing as well:

border-block-start
border-block-end
...

Tokens in outline shorthand are not working for me, e.g. outline: '2px solid $green600'

We've published a pre-release of Stitches beta 🚀
Core:
npm install<EMAIL_ADDRESS>
React:
npm install<EMAIL_ADDRESS>
This issue should have been resolved in the beta version. We'd appreciate it if you could verify it.
⚠ Please refer to this migration guide as there are some breaking changes.


Add a --no-tail option to fig logs

I'd prefer to have --tail be explicit for fig logs, but this would break backwards compatibility. The motivation behind wanting this is so I can redirect the output of fig logs into a file (e.g. on a CI server where I want the logs as an artifact).
Signed-off-by: Ben Taitelbaum<EMAIL_ADDRESS>

Didn't mean to close this PR (accidentally deleted the remote branch), so reopening.

I would be in favour of making no-tail the default and adding a --tail flag. We can merge it in for the Compose release, which is an opportunity to get breaking changes in.

@aanand I created #807 with the breaking change you're mentioning. I agree that it feels more intuitive (and is a command I tried several times before realizing it didn't exist).

+1 on this one.

I believe this was replaced by #807


new package changes

switching from Example.Stytch to Stytch.net

Let's make the title of the PR more descriptive.


Toast message units in 7 days view

When I click a day in "This Week's Weather" view the toast message units are F even if I switch to C.

@sniperle that's an easy fix. i'll add it into the coming update.

@sniperle this has been fixed in the 2.0.2 release that i just pushed. it all depends on when fdroid adds it so you can get the update. :smile:


Add warmup step to OSB procedures

The warmup API is used to load nmslib/faiss indices into native memory before search. In order to avoid costly initial queries, our benchmark procedures should have a step to warmup the indices before search.

@navneet1v Can I get assigned to this issue?

@navneet1v Can I get assigned to this issue?

Done

@navneet1v @jmazanec15 I am quite new to the repo, can you provide a little bit more about the repo's structure and the direction I should look to resolve this issue?

@TrungBui59 Check this custom refresh step: https://github.com/opensearch-project/k-NN/blob/main/benchmarks/osb/extensions/runners.py#L16-L17
We need to add a step for warmup which hits the warmup API: https://opensearch.org/docs/latest/search-plugins/knn/api/#warmup-operation

Closed - already completed in OSB


Adds SPICEApplications.jl as subpackage

I have previously released SPICEApplications.jl, which provides hooks into SPICE Toolkit executables (applications) provided by CSPICE_jll. I think it might fit in nicely with this package, and if you agree, I would be interested in helping to maintain it.
What do you think?

Sounds good 👍 I will look into this in more detail over the weekend.

Sorry for the delay @cadojo. As you can see, help with the maintenance of this package is desperately needed 🙈

No worries, thank you! I will need to do a bit more work here to fully port SPICEApplications into the SPICE repo. I'll add another PR which merges the documentation branches too, and updates CI, etc. If you're comfortable making me maintainer, I can add CI workflow dispatch for my own debugging in getting that up and running. Either way works for me :)

@helgee I understand you are on a hiatus from @JuliaAstro work. Is there another primary maintainer of this repository who I should contact? I would like to be added as a maintainer so I can setup and debug CI for SPICEApplications.

Granted you maintainer rights @cadojo


Looking into enabling Hotjar again

on hold while hotjar account gets updated

@vabarbosa @JRussellHuffman - we seem to be getting responses again, in Hotjar. I think this issue can be closed, but please let me know if there's anything you'd like to review.
I'm able to see results by doing the following:

log into Hotjar
select the qiskit.org > Workspace #1 dashboard
view Scratchpad surveys or other recordings

you're right. that's so interesting that it has magically come back. But I suppose I won't complain! I think we can close this.


Machine mac-8 lost external connection from iPhone device.

Machine mac-8 lost external connection from iPhone device.

External connection has been restored by rebooting machine.


Could not execute entrypoint stage 'client' at startup

Minecraft version: 1.20.1
Fabric version: 0.15.3
Mod version: 2.1.0
Crashlog: https://0x0.st/H6Dl.txt
Mods: https://0x0.st/H6D0.txt

outdated YACL mod


chore(executor): add tx hash to evm error

Add transaction hash to evm error

Codecov Report

Merging #1714 (111f849) into main (a4a80a7) will decrease coverage by 28.20%.
The diff coverage is 75.00%.

:mega: This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more
@@             Coverage Diff             @@
##             main    #1714       +/-   ##
===========================================
- Coverage   73.08%   44.88%   -28.20%
===========================================
  Files         388      388
  Lines       46437    46439        +2
===========================================
- Hits        33938    20845    -13093
- Misses      12499    25594    +13095

Flag
Coverage Δ

integration-tests
20.43% <0.00%> (+<0.01%)
:arrow_up:

unit-tests
35.81% <75.00%> (-32.04%)
:arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files
Coverage Δ

crates/interfaces/src/executor.rs
0.00% <ø> (ø)

crates/executor/src/executor.rs
66.16% <75.00%> (-27.80%)
:arrow_down:

... and 185 files with indirect coverage changes
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.


Building on MacOS fails

As of now, MacOS still fails (PR #368 did not fix it, sorry I messed that up).
I forked the repo and made quite a lot of changes trying to make std::isblank work on hillmich/cxxopts. The main change is to replace std::isblank by explicitly checking for space and tab as the standard dictates for the C locale. This fork also includes

CI on MacOS and Windows
Assume header regexp is always there since cxxopts requires c++11 or higher (and eliminate a large chunk of code)
Remove some unused headers
Get around requiring cstring
Add std:: to instances of size_t

@jarro2783 are you interested in these changes and would you accept them as PR?

sounds good, make a PR and I'll take a look.

Progress on this? I'm in need of this fix.

Sorry I got distracted by something else, I'll follow up on that PR.


Chromium ContentBrowserclient Embedder api  IsHandledUrl was not impl…

Chromium ContentBrowserclient Embedder api IsHandledUrl was not implemented. Add the implementation for the same. This should be in sync with registered protocol handlers.
fix https://github.com/brave/browser-laptop/issues/10644

Addressed all the review comments.

++

forgot to merge this for 4.4.26, I'll get it in 4.4.27


Command line debugging tests fail when compiling multiple umple files for one test

Brief Description
Refer to Issue #882 to see changes made for command line debugging. (See all ignored tests in testbed/test/cruise.compiler.CompilerErrorOutputTests)
The command line debugging tool seems to be functioning correctly for the issues these tests test for, but for some reason the tests themselves fail to execute correctly. When Umple compiles multiple files in order to generate one or more Java files, it claims that it cannot find a symbol from a file that is used by the main file being compiled.
Minimum Steps to Reproduce
There are already 3 tests created in cruise.compiler.CompilerErrorOutputTests, simply removing the @ ignore annotation and running the JUnit test will show you the error

Navigate to the following file: testbed/cruise.compiler.CompilerErrorOutputTests
Find "MultipleClassesTest" and remove the @ ignore annotation above it
Run the JUnit test for the file and observe the failure message

Expected Result
You can view the expected results for the three tests in testbed/test/cruise.compiler.expected

I am raising the priority on this, since this is an important problem.

In particular, the build of Umple itself, which operates on multiple files has this problem

See also #1173


Write small report on RAG vs FineTuning

This report includes the following points:

Brief Introduction
Components Explanation
Pros & Cons
When to use?
Summarized Comparison

Note: Resources used are referenced at the end of the document

I think would be better if we briefly explain (in the README file) based on this report why is RAG preferable choice than finetuning for our project.