Update Apicurio Registry Operator to 0.0.3-v1.2.3.final (community)

Thanks submitting your Operator. Please check below list before you create your Pull Request.

Flat operator directory structure is obsolete from 23-rd of October 2019, only nested directory structure will be accepted.

New Submissions

[x] Does your operator have nested directory structure?
[ ] Have you selected the Project Community Operator Submissions in your PR on the right-hand menu bar?
[x] Are you familiar with our contribution guidelines?
[x] Have you packaged and deployed your Operator for Operator Framework?

[x] Is your submission signed?

Updates to existing Operators

[x] Is your new CSV pointing to the previous version with the replaces property?
[x] Is your new CSV referenced in the appropriate channel defined in the package.yaml ?
[x] Have you tested an update to your Operator when deployed via OLM?
[x] Is your submission signed?

Your submission should not

[x] Modify more than one operator
[x] Modify an Operator you don't own
[x] Rename an operator - please remove and add with a different name instead
[x] Submit operators to both upstream-community-operators and community-operators at once
[x] Modify any files outside the above mentioned folders
[x] Contain more than one commit. Please squash your commits.

Operator Description must contain (in order)

[x] Description about the managed Application and where to find more information
[x] Features and capabilities of your Operator and how to use it
[x] Any manual steps about potential pre-requisites for using your Operator

Operator Metadata should contain

[x] Human readable name and 1-liner description about your Operator
[x] Valid category name1
[x] One of the pre-defined capability levels2
[x] Links to the maintainer, source code and documentation
[x] Example templates for all Custom Resource Definitions intended to be used
[x] A quadratic logo

Remember that you can preview your CSV here.
--
1 If you feel your Operator does not fit any of the pre-defined categories, file an issue against this repo and explain your need
2 For more information see here

@jsenko, Can you please fix name of the version form  0.0.3-v1.2.3.finalto 0.0.3. This version naming could cause some problems in the future. Thank you very much

@mvalahtv hi, the idea is to include the operand version in the CSV as a suffix, since operator and operand could evolve (partially) independently. I made sure the version string matches the valid version regex. Are there any specific reasons that would make this approach risky? Are there plans to change this regex in the future?

@jsenko we agreed that we will any semantic version compatible strings.


create and update application not returning the response

I noticed that in the current version the response from UpdateApplication or CreateApplication is only the error. For my use case, I would need these 2 operations to also return the deserialized Application (which is already available in those methods) so as to know the deployment ids.

An alternative could be to add to 2 other methods for Creating and Updating the application so as not to break folks already using the library

Yep, it make's sense! - and it's kind of pointless for both Create and Update to both decode the response and never return it, which is the case now. I've pushed the PR #51 and will merge shortly
func (client *Client) CreateApplication(application *Application, wait_on_running bool) error {
	result := new(Application)
	client.log("Creating an application: %s", application)
	if err := client.apiPost(MARATHON_API_APPS, &application, result); err != nil {
		return err
	}
        ..

Thanks!


Made changes to work with latest node(v0.12.4) and latest angular (v1.4)

Made changes in bower.json,  package.json and Fixed JS and CSS issues after updating to latest node(v0.12.4) and latest angular (v1.4)

Seems perfect :+1:


Service to get first valid tile location

Added service to get the first tile meta from the layer.


improve globbing (fixes #91)

Partly addresses #92

integrations test pass, too: http://awsbuild.phraseapp.io/job/phraseapp-integration/723/

@alexanderwilling lgtm


High CPU usage

Hi there,
When running rpi-led-matrix-painter-examples, I noticed that it the CPU usage is considerably higher then kitchen-sink.
Any thoughts on how to reduce the cpu usage?

Hi @PhantomRay ,
You can definitely change the interval at which we call the paint() method.  It's currently 5ms which is kind of ridiculous.  I guess 33 would be more reasonable.  Even 100 would still give you 10 fps.  It depends on the refresh rate you're going for.
Going from 5 ms to 33 ms I do see a reduction in CPU usage, but still not quite as good as the kitchen-sink example from the rpi-led-matrix library.  100ms seems to be fairly close.
https://github.com/wesleytabaka/rpi-led-matrix-painter-example/blob/8c758bb8d648c54ca3206c6075f17b852b69f463/src/index.ts#L312
Hope this helps!


Typo?

All your variables have prefix GITLBA instead of GITLAB. I thought it was a typo, but it is repeated everywhere consistently, so is it deliberate?

I will update the repo.

@thejohnfreeman Done.


Question: does this also work with Slack.NetStandard.RequestHandler?

Hi,
Awesome work!
I see this approach helps us with socket mode. How can I combine socket mode and what you build for RequestHandler? Do you have somesort of an example on how both projects could work together? Or should I write my own dispatch mechanism?
Kees

Hi @KeesCBakker
The two can absolutely work together. Given a pipeline from Slack.NetStandard.RequestHandler of type object, there is a Process method which accepts an Envelope, so you end up with a SocketModeClient event loop that looks something like....
so your pipeline would look something like
var pipeline = new SlackPipeline<object>(new ISlackRequestHandler<object>[]
            {
                new AppHomeEvent(),
                new DirectMessageReceived()
                //...whatever you've called your handlers here
             });

and then your main event loop for your SocketModeClient would look something like like....
var socketMode = new SocketModeClient();
 await socketMode.ConnectAsync(socketToken);

 var token = new CancellationTokenSource();

logger.LogDebug("opened socket");
await foreach (var msg in socketMode.EnvelopeAsyncEnumerable(token.Token))
{
     var response = await pipeline.Process(msg);
     await socketMode.Acknowledge(msg.EnvelopeId, response, token.Token);
}
 socketMode.Dispose();
logger.LogDebug("socket closed");

of course depending on your throughput and speed etc you might just immediately acknowledge the event so you hit the Slack time limits and process the Envelope some other way - but that's the kind of idea you can go with.


[SPARK-44430][SQL] Add cause to AnalysisException when option is invalid

What changes were proposed in this pull request?
This PR adds cause to AnalysisException when option is invalid.
Why are the changes needed?
Makes it easy to locate the incorrect options.
Does this PR introduce any user-facing change?
No.
How was this patch tested?
Unit test.

Merged to master.


Bug: Citation stops after changing the Document Similarity Threshold.

It appears that if you adjust the Document Similarity Threshold the UI stops presenting citations.
Running latest version in a Docker container.
Also, this software is amazing. Thank you!!!

That is the intention (technically).
When you have a higher threshold less document context will pass through the filter to be inserted into the chat prompt, therefore no citations appear.
But if you are in a chat session and there was a previous answer above in the chat history, that is also used in formulating an answer so it may still get it right, but only if you asked it prior.
If you were to have high similarity thresholds, and run /reset to reset the session, and ask the same question it wont know what you are talking about since no context passed through the filter + no available answers in the history!

Ah, I see now. Thank you for the clarification!
Is /reset the only command or are there other ones that the user can use as well in the chat dialogue?
Greatly appreciate your efforts on this project. It's by far the most robust Chatbot solution for querying docs, that I have come across. Thank you.

Currently just the /reset command is available. We will make the future ones more known/discoverable with a context menu! We know that the /reset command is currently hidden 😄


Hermes: collecting monitoring stats from all deployment nodes

https://ocd.appscale.com:8080/job/Daily Build/1206/

Example:
{'timestamp': datetime.datetime(2016, 3, 10, 17, 47, 18, 933969), 'deployment_id': 'test', 'all_stats': {'<IP_ADDRESS>': '{"cpu":{"idle":100.0,"system":0.0,"user":0.0},"disk":[{"/":{"used":3598614528,"free":5661908992}}],"memory":{"available":1186271232,"used":2883387392},"swap":{"used":0,"free":0},"services":{"zookeeper":"running","cassandra":"running","flower":"running","backup_recovery_service":"running","datastore_server":"running","memcached":"running","groomer_service":"running","celery-appscaledashboard":"running","blobstore":"running","app___appscaledashboard-8002":"running","nginx":"running","controller":"running","app___appscaledashboard-8001":"running","hermes":"running","haproxy":"running","app___appscaledashboard-8000":"running","rabbitmq":"running","taskqueue":"running","ejabberd":"running","uaserver":"running","iaas_manager":"running","appmanagerserver":"running"},"apps":{},"public_ip":"<IP_ADDRESS>","private_ip":"<IP_ADDRESS>","roles":["load_balancer","taskqueue_master","zookeeper","db_master","taskqueue","memcache","shadow","login","appengine"]}'}}

https://ocd.appscale.com:8080/job/Daily Build/1210/

https://ocd.appscale.com:8080/job/Daily Build/1211/


sidenav overlay on top of the sidenav

I think this only happens on a fixed sidenav which is hidden due to screen size.
In that case, when you click the collapse button, the overlay is above the sidenav, although its z-index is lower.

Seems to be fixable by using a specific nav structure..
https://github.com/Dogfalo/materialize/issues/3918

You can put navbar-fixed class on nav and close nav as soon as top navigation bar code ends

http://fiddle.jshell.net/oepn5ccc/

Not sure why this is still open


feat: support user-defined retry interceptors

This commit provides a pluggable way for users of the java core
to supply their own retry interceptor implementation in order
to customize the conditions under which retries are automatically
attempted.
Included in these changes is the notion of a "retry strategy",
which is a factory for creating retry interceptor instances.
Users of the java core (e.g. an SDK project) can implement
their own retry strategy and then set it with the
HttpClientSingleton.setRetryStrategy() static method.
Once set, the registered factory's createRetryInterceptor()
method will be called whenever the java core needs to initialize an
http client instance when retries are enabled.
The factory's createRetryInterceptor() method returns an implementation
of the IRetryInterceptor interface (which is itself a subclass of
the okhttp3 Interceptor interface).
User's might find it convenient to define their retry interceptor
class as a subclass of the java core's RetryInterceptor class,
thereby relying on RetryInterceptor for most of the functionality,
while overriding specific methods as needed.

@richellis Rich, just wanted to alert you to this PR in case you have any comments.

:tada: This PR is included in version 9.16.0 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


[MC: 1.17.1] [BE: 0.10.5] BetterEnd skybox rendering over end islands at a certain distance

Mods:
  [✔] 1.17-flesh2leather-1.0.2
  [✔] Adorn-2.1.3+1.17.1-fabric
  [✔] antiqueatlas-6.0.0-fabric-mc1.17.1
  [✔] architectury-2.2.21-fabric
  [✔] atbyw-1.17-1.5.3
  [✔] backslot-1.2.0
  [✔] bclib-0.2.4
  [✔] bedspreads-fabric-1.4.0-1.17
  [✔] better-end-0.10.5-pre
  [✔] better-nether-5.1.3
  [✔] blockus-2.2.7+1.17.1
  [✔] clickthrough-1.17.1-fabric0.36.1-0.4
  [✔] Couplings-1.5.1+1.17
  [✔] Croptopia-1.17-FABRIC-1.6.0
  [✔] extraorigins-1.17-6
  [✔] fabric-api-0.37.1+1.17
  [✔] fabric-furnaces-2.0.1-1.17
  [✔] fabric-language-kotlin-1.6.2+kotlin.1.5.20
  [✔] FabricShieldLib-1.3.5-21w05b
  [✔] figura-0.0.6-1.17.x
  [✔] FirstPersonMod-2.0.2
  [✔] gate-of-babylon-1.5.0-1.17
  [✔] grind-enchantments-1.2.1+1.17
  [✔] here-be-no-dragons-1.0.0
  [✔] immersive-portals-0.17-mc1.17.1-fabric
  [✔] improved-stations-2.0.7
  [✔] inmis-2.3.1-1.17
  [✔] InventorySorter-1.7.9-1.17
  [✔] krypton-0.1.4
  [✔] medievalweapons-1.1.6
  [✔] moborigins-1.6.0
  [✔] modmenu-2.0.4
  [✔] MoEnchantments-1.17.4
  [✔] mostructures-1.2.1-1.17
  [✔] noplayerlabels-2.0.2
  [✔] notenoughanimations-1.3.0
  [✔] notenoughcrashes-3.4.0+1.17-fabric
  [✔] Origins-1.17-1.0.3
  [✔] Pehkui-2.2.1+1.14.4-1.17
  [✔] TRansliterationLib-1.1.0
  [✔] trinketofundying-fabric-2.0.0-1.17
  [✔] trinkets-3.0.2

No errors in logs that are related to better end

This would be a really cool effect if there was a fog, but this instance is is fresh with only three settings changed
MC GUI Scale = 2
MC Music Vol = 0
MC Autojump = False

Changing Render distance does not appear to affect it at all
RD = 8

RD = 12 (default)

RD = 16

For reference, here is my F3 while taking these screenshots

And here is what it looks like if i move forward a bit, (all i did was press w)

Standing ONE BLOCK BACK FURTHER

Each line is set at the corner of a chunk
Effective render distance is 7 chunks and 2 blocks

This issue happens with some mods that are not setting sky rendering GL options to default (which vanilla do), the fix was already implemented, but not released yet, and it will be in the next version (0.11.0)

Fixed in 0.11.0


sequenceAttributes incrementBy has wrong type in XSD

Environment
Liquibase Version: 4.3.1
Liquibase Integration & Version: n/a
Liquibase Extension(s) & Version: n/a
Database Vendor & Version: n/a
Operating System Type & Version: n/a
Description
In the XSD in the attribute group sequenceAttributes the incrementBy attribute has a type of xsd:string, but if you put in any arbitrary string, you get a NumberFormatException at execution time. It should probably be xsd:long like the other incrementBy attributes or at least restrict the xsd:string to digits-only.
┆Issue is synchronized with this Jira Bug by Unito

And same for maxValue, minValue, startValue and cacheSize

Thanks @Vampire for writing up this issue.  We will add this one to the list of issues that we are processing.


Don't import paste

My tsx files cannot import folders created inside src in Visual Studio Code

/needsMoreInfo
What is OS, VSCode, TS versions?
Do you have tsconfig,json file that includes those files?


[Assistant Builder] Add tool name when not default

Description
Fixes https://github.com/dust-tt/tasks/issues/1807

Risks
na
Deploy
front

Updated pics with @Duncid 's preferred solution


Help:discord rpc yce

When I run the config.bat I get a error on discord_rpc_yce that says Error: Could not Clone git repository.
I checked the github on YoshiCrafter29 but it didn't have discord_rpc_yce it had haxelib git discord_rpc https://github.com/YoshiCrafter29/linc_discord-rpc.
here's the photo:

https://git-for-windows.github.io/

https://git-for-windows.github.io/

I tried to download that and it still didn't work

try this instead
https://git-scm.com/downloads

try this instead https://git-scm.com/downloads

It still didn't work
I don't know if the git exist so it can clone it.

try this instead https://git-scm.com/downloads

It still didn't work I don't know if the git exist so it can clone it.

make sure you added it to PATH https://docs.oracle.com/en/database/oracle/machine-learning/oml4r/1.5.1/oread/creating-and-modifying-environment-variables-on-windows.html#GUID-DD6F9982-60D5-48F6-8270-A27EC53807D0

if that still doesn't work, then Idk


Usage

Could you provide Usage section in your project's main 'Readme.md' file?

https://github.com/zaggino/brackets-npm-registry#how-to-use-brackets-npm-registry


Added 'exposed' field to ClassInfo for registered classes

Closes #11913
This is my proposal at fixing the issue I describe here.
It's a radical change because it forces classes to be registered manually in order to be exposed to scripting languages. However, I think this is the way to go.
I didn't change anything regarding the class reference generation myself, but it should ignore classes that are not exposed.

@reduz WDYT of this?

It seems fine to me

Ready to merge then, unless anyone disagrees.


Add settings option to add custom overlayer

Add settings option to add custom over layer, so that users can combine a base map layer with custom over layer.

Done


Fix: Display approve instead of cross-check

Prior to this change, cross-check partial templates were used on
approval.
This change introduce approval partial templates
Resolves: https://uktrade.atlassian.net/browse/TARIFFS-370
Before:

After:

I think this can be achieved in a much simpler way without duplicating all of the partials.
I can look into this later.

I believe so, and I agree :)


Base class conditional iterator

Adds a templated ForEach function to Panku, that allows to apply a functor to all classes that are derived from the same parent.
This same format could be used to iterate and apply functors based on any other type_traits criteria (potentially passing the criterion as a strategy).

Yeah metaprogramming code is always very obscure... I can't really test the Panku struct part itself as it's heavily macroed, but I can add a test for the conditional functor, so I will do that :)


Cognitive - Translator for JavaScript (January-June 2021)

This tracks the work for Cognitive - Translator for JavaScript.

No work was done for Cognitive - Translator during Jan - June 2021


feature: add mapping to toggle full window width

Did you check the docs?

[X] I have read all the zen-mode.nvim docs

Is your feature request related to a problem? Please describe.
While a window width of 120 is perfect for most code it would be nice to toggle to full width when checking a log file.
Describe the solution you'd like
I suggest a key mapping like f to toggle full width. The mapping should be restricted to the zen window.
Describe alternatives you've considered
I've tried to add a mapping via on_open but I failed due to 2 problems:

I don't know how to change window.width config while the window is open
I don't know how to restrict the mapping to the zen window. I can only restrict it to the buffer but then the f mapping is also still active when the zen window is closed.

Additional context
No response

This is a comment to avoid closing :-/

This is another comment to avoid closing :-/

.

.

!

.

👋

@majordoobie Well you're basically just configuring the width. What I wanted was a way to toggle the width while in zen-mode, e.g. from 120 (for a nice centered view) to 1 (==100%) for full width.

@majordoobie Well you're basically just configuring the width. What I wanted was a way to toggle the width while in zen-mode, e.g. from 120 (for a nice centered view) to 1 (==100%) for full width.

The toggle I made disables zen, doesn't that do the same thing? Gives you 100% of your view.

Not sure I can follow: I already have a mapping for :ZenMode. So I can already activate/deactivate Zen mode.
But what I want is, when zen mode is active I still want more control over the window width. E.g. I want to go from 120 width to 100% width (and back).


chore(api,robot-server): allow OT-3 sim configs

We have a lovely submodule for creating simulated hardware controllers based on json config files, which is great, but that was never extended to handle the OT-3. This PR does that by

Splitting the config into types since the configurations are slightly different
Making the appropriate controller class get loaded based on the machine type from the configuration
Adding a configuration file for the robot server integration tests that use an OT-3

I don't believe any integration tests actually use this server right now, but they will in #12731 which I'm going to rebase on top of this.

simulator_setup

Ughhhh guess so


Fix or disable user registration email confirmation

Emails have broken HTML, which means their buttons aren't clickable. I don't know why this is happening.
Before deploying to production, we should either fix it or disable email confirmation temporarily.

I cannot reproduce this issue. Confirmation email button works fine for me :)


Flutter Web : platformViewRegistry reference error with v1.18.0-11.1pre

Steps to reproduce :
import 'dart:ui' as ui;
// ignore: avoid_web_libraries_in_flutter
import 'dart:html' as html;
// ignore: avoid_web_libraries_in_flutter
.
.
ui.platformViewRegistry.registerViewFactory(
      'iframeElement',
      (int viewId) => _iframeElement,
    );

Expected results:
Should show no errors. It works fine in v1.15 beta
Actual results:

Logs

The name 'platformViewRegistry' is being referenced through the prefix 'ui', but it isn't defined in any of the libraries imported using that prefix.
Try correcting the prefix or importing the library that defines 'platformViewRegistry'.

[√] Flutter (Channel beta, 1.18.0-11.1.pre, on Microsoft Windows [Version 10.0.19041.329], locale en-US)
    • Flutter version 1.18.0-11.1.pre at C:\flutter
    • Framework revision 2738a1148b (7 weeks ago), 2020-05-13 15:24:36 -0700
    • Engine revision ef9215ceb2
    • Dart version 2.9.0 (build 2.9.0-8.2.beta)

[!] Android toolchain - develop for Android devices (Android SDK version 29.0.3)
    • Android SDK at C:\Users\blesi\AppData\Local\Android\sdk
    • Platform android-29, build-tools 29.0.3
    • Java binary at: C:\Program Files\Android\Android Studio\jre\bin\java
    • Java version OpenJDK Runtime Environment (build 1.8.0_212-release-1586-b04)
    X Android license status unknown.
      Try re-installing or updating your Android SDK Manager.
      See https://developer.android.com/studio/#downloads or visit visit https://flutter.dev/docs/get-started/install/windows#android-setup for detailed instructions.

[√] Chrome - develop for the web
    • Chrome at C:\Program Files (x86)\Google\Chrome\Application\chrome.exe

[√] Android Studio (version 3.6)
    • Android Studio at C:\Program Files\Android\Android Studio
    • Flutter plugin version 44.0.2
    • Dart plugin version 192.7761
    • Java version OpenJDK Runtime Environment (build 1.8.0_212-release-1586-b04)

[√] VS Code (version 1.46.1)
    • VS Code at C:\Users\blesi\AppData\Local\Programs\Microsoft VS Code
    • Flutter extension version 3.12.0

[√] Connected device (2 available)
    • Web Server • web-server • web-javascript • Flutter Tools
    • Chrome     • chrome     • web-javascript • Google Chrome 83.0.4103.116

! Doctor found issues in 1 category.

duplicate of https://github.com/flutter/flutter/issues/41563


http://<IP_ADDRESS>:8000/#/ledgers 查看帐本时，状态一直为未加载.

安装指导文档说启动完成状态会变更，多次安装，单台机器和多台机器安装均无法正常显示已加载。
-------- lib jars --------
0: file:/opt/jdchain-peer-1.3.0.RELEASE/libs/utils-web-1.3.0.RELEASE.jar
0: file:/opt/jdchain-peer-1.3.0.RELEASE/libs/utils-serialize-1.3.0.RELEASE.jar
0: file:/opt/jdchain-peer-1.3.0.RELEASE/libs/utils-http-1.3.0.RELEASE.jar
0: file:/opt/jdchain-peer-1.3.0.RELEASE/libs/utils-common-1.3.0.RELEASE.jar
0: file:/opt/jdchain-peer-1.3.0.RELEASE/libs/tools-keygen-booter-1.3.0.RELEASE.jar
0: file:/opt/jdchain-peer-1.3.0.RELEASE/libs/tools-keygen-1.3.0.RELEASE.jar
0: file:/opt/jdchain-peer-1.3.0.RELEASE/libs/tools-initializer-booter-1.3.0.RELEASE.jar
0: file:/opt/jdchain-peer-1.3.0.RELEASE/libs/tools-initializer-1.3.0.RELEASE.jar
0: file:/opt/jdchain-peer-1.3.0.RELEASE/libs/tomcat-embed-websocket-9.0.31.jar
0: file:/opt/jdchain-peer-1.3.0.RELEASE/libs/tomcat-embed-el-9.0.31.jar
0: file:/opt/jdchain-peer-1.3.0.RELEASE/libs/tomcat-embed-core-9.0.31.jar
0: file:/opt/jdchain-peer-1.3.0.RELEASE/libs/storage-service-1.3.0.RELEASE.jar
0: file:/opt/jdchain-peer-1.3.0.RELEASE/libs/spring-webmvc-5.2.4.RELEASE.jar
0: file:/opt/jdchain-peer-1.3.0.RELEASE/libs/spring-web-5.2.4.RELEASE.jar
0: file:/opt/jdchain-peer-1.3.0.RELEASE/libs/spring-security-web-5.2.2.RELEASE.jar
0: file:/opt/jdchain-peer-1.3.0.RELEASE/libs/spring-security-core-5.2.2.RELEASE.jar
0: file:/opt/jdchain-peer-1.3.0.RELEASE/libs/spring-security-config-5.2.2.RELEASE.jar
0: file:/opt/jdchain-peer-1.3.0.RELEASE/libs/spring-jcl-5.2.4.RELEASE.jar
0: file:/opt/jdchain-peer-1.3.0.RELEASE/libs/spring-expression-5.2.4.RELEASE.jar
0: file:/opt/jdchain-peer-1.3.0.RELEASE/libs/spring-core-5.2.4.RELEASE.jar
0: file:/opt/jdchain-peer-1.3.0.RELEASE/libs/spring-context-5.2.4.RELEASE.jar
0: file:/opt/jdchain-peer-1.3.0.RELEASE/libs/spring-boot-starter-web-2.2.5.RELEASE.jar
0: file:/opt/jdchain-peer-1.3.0.RELEASE/libs/spring-boot-starter-validation-2.2.5.RELEASE.jar
0: file:/opt/jdchain-peer-1.3.0.RELEASE/libs/spring-boot-starter-tomcat-2.2.5.RELEASE.jar
0: file:/opt/jdchain-peer-1.3.0.RELEASE/libs/spring-boot-starter-security-2.2.5.RELEASE.jar
0: file:/opt/jdchain-peer-1.3.0.RELEASE/libs/spring-boot-starter-log4j2-2.2.5.RELEASE.jar
0: file:/opt/jdchain-peer-1.3.0.RELEASE/libs/spring-boot-starter-json-2.2.5.RELEASE.jar
0: file:/opt/jdchain-peer-1.3.0.RELEASE/libs/spring-boot-starter-2.2.5.RELEASE.jar
0: file:/opt/jdchain-peer-1.3.0.RELEASE/libs/spring-boot-autoconfigure-2.2.5.RELEASE.jar
0: file:/opt/jdchain-peer-1.3.0.RELEASE/libs/spring-boot-2.2.5.RELEASE.jar
0: file:/opt/jdchain-peer-1.3.0.RELEASE/libs/spring-beans-5.2.4.RELEASE.jar
0: file:/opt/jdchain-peer-1.3.0.RELEASE/libs/spring-aop-5.2.4.RELEASE.jar
0: file:/opt/jdchain-peer-1.3.0.RELEASE/libs/snakeyaml-1.25.jar
0: file:/opt/jdchain-peer-1.3.0.RELEASE/libs/slf4j-api-1.7.25.jar
0: file:/opt/jdchain-peer-1.3.0.RELEASE/libs/sdk-rpc-1.3.0.RELEASE.jar
0: file:/opt/jdchain-peer-1.3.0.RELEASE/libs/sdk-base-1.3.0.RELEASE.jar
0: file:/opt/jdchain-peer-1.3.0.RELEASE/libs/runtime-context-1.3.0.RELEASE.jar
0: file:/opt/jdchain-peer-1.3.0.RELEASE/libs/rocksdbjni-6.3.6.jar
0: file:/opt/jdchain-peer-1.3.0.RELEASE/libs/reflections-0.9.10.jar
0: file:/opt/jdchain-peer-1.3.0.RELEASE/libs/procyon-reflection-0.5.35.jar
0: file:/opt/jdchain-peer-1.3.0.RELEASE/libs/procyon-expressions-0.5.35.jar
0: file:/opt/jdchain-peer-1.3.0.RELEASE/libs/procyon-core-0.5.35.jar
0: file:/opt/jdchain-peer-1.3.0.RELEASE/libs/procyon-compilertools-0.5.35.jar
0: file:/opt/jdchain-peer-1.3.0.RELEASE/libs/netty-all-4.1.45.Final.jar
0: file:/opt/jdchain-peer-1.3.0.RELEASE/libs/manager-explorer-1.2.0.RELEASE.jar
0: file:/opt/jdchain-peer-1.3.0.RELEASE/libs/log4j-slf4j-impl-2.12.1.jar
0: file:/opt/jdchain-peer-1.3.0.RELEASE/libs/log4j-jul-2.12.1.jar
0: file:/opt/jdchain-peer-1.3.0.RELEASE/libs/log4j-core-2.10.0.jar
0: file:/opt/jdchain-peer-1.3.0.RELEASE/libs/log4j-api-2.10.0.jar
0: file:/opt/jdchain-peer-1.3.0.RELEASE/libs/ledger-model-1.3.0.RELEASE.jar
0: file:/opt/jdchain-peer-1.3.0.RELEASE/libs/ledger-database-1.3.0.RELEASE.jar
0: file:/opt/jdchain-peer-1.3.0.RELEASE/libs/kvdb-protocol-1.0.1.RELEASE.jar
0: file:/opt/jdchain-peer-1.3.0.RELEASE/libs/kvdb-client-1.0.1.RELEASE.jar
0: file:/opt/jdchain-peer-1.3.0.RELEASE/libs/jul-to-slf4j-1.7.25.jar
0: file:/opt/jdchain-peer-1.3.0.RELEASE/libs/jnats-2.2.0.jar
0: file:/opt/jdchain-peer-1.3.0.RELEASE/libs/jedis-2.9.0.jar
0: file:/opt/jdchain-peer-1.3.0.RELEASE/libs/jboss-logging-3.4.1.Final.jar
0: file:/opt/jdchain-peer-1.3.0.RELEASE/libs/javassist-3.19.0-GA.jar
0: file:/opt/jdchain-peer-1.3.0.RELEASE/libs/jakarta.validation-api-2.0.2.jar
0: file:/opt/jdchain-peer-1.3.0.RELEASE/libs/jakarta.annotation-api-1.3.5.jar
0: file:/opt/jdchain-peer-1.3.0.RELEASE/libs/jackson-module-parameter-names-2.10.2.jar
0: file:/opt/jdchain-peer-1.3.0.RELEASE/libs/jackson-datatype-jsr310-2.10.2.jar
0: file:/opt/jdchain-peer-1.3.0.RELEASE/libs/jackson-datatype-jdk8-2.10.2.jar
0: file:/opt/jdchain-peer-1.3.0.RELEASE/libs/jackson-databind-2.10.2.jar
0: file:/opt/jdchain-peer-1.3.0.RELEASE/libs/jackson-core-2.10.2.jar
0: file:/opt/jdchain-peer-1.3.0.RELEASE/libs/jackson-annotations-2.10.2.jar
0: file:/opt/jdchain-peer-1.3.0.RELEASE/libs/httpcore-4.4.13.jar
0: file:/opt/jdchain-peer-1.3.0.RELEASE/libs/httpclient-4.5.1.jar
0: file:/opt/jdchain-peer-1.3.0.RELEASE/libs/hibernate-validator-6.0.18.Final.jar
0: file:/opt/jdchain-peer-1.3.0.RELEASE/libs/guava-19.0.jar
0: file:/opt/jdchain-peer-1.3.0.RELEASE/libs/fastjson-1.2.67.jar
0: file:/opt/jdchain-peer-1.3.0.RELEASE/libs/eddsa-0.1.0.jar
0: file:/opt/jdchain-peer-1.3.0.RELEASE/libs/disruptor-3.4.2.jar
0: file:/opt/jdchain-peer-1.3.0.RELEASE/libs/deploy-peer-1.3.0.RELEASE.jar
0: file:/opt/jdchain-peer-1.3.0.RELEASE/libs/crypto-sm-1.3.0.RELEASE.jar
0: file:/opt/jdchain-peer-1.3.0.RELEASE/libs/crypto-framework-1.3.0.RELEASE.jar
0: file:/opt/jdchain-peer-1.3.0.RELEASE/libs/crypto-classic-1.3.0.RELEASE.jar
0: file:/opt/jdchain-peer-1.3.0.RELEASE/libs/contract-jvm-1.3.0.RELEASE.jar
0: file:/opt/jdchain-peer-1.3.0.RELEASE/libs/contract-framework-1.3.0.RELEASE.jar
0: file:/opt/jdchain-peer-1.3.0.RELEASE/libs/consensus-mq-1.3.0.RELEASE.jar
0: file:/opt/jdchain-peer-1.3.0.RELEASE/libs/consensus-framework-1.3.0.RELEASE.jar
0: file:/opt/jdchain-peer-1.3.0.RELEASE/libs/consensus-bftsmart-1.3.0.RELEASE.jar
0: file:/opt/jdchain-peer-1.3.0.RELEASE/libs/commons-pool2-2.7.0.jar
0: file:/opt/jdchain-peer-1.3.0.RELEASE/libs/commons-logging-1.2.jar
0: file:/opt/jdchain-peer-1.3.0.RELEASE/libs/commons-io-2.4.jar
0: file:/opt/jdchain-peer-1.3.0.RELEASE/libs/commons-collections4-4.1.jar
0: file:/opt/jdchain-peer-1.3.0.RELEASE/libs/commons-codec-1.13.jar
0: file:/opt/jdchain-peer-1.3.0.RELEASE/libs/classmate-1.5.1.jar
0: file:/opt/jdchain-peer-1.3.0.RELEASE/libs/binary-proto-1.3.0.RELEASE.jar
0: file:/opt/jdchain-peer-1.3.0.RELEASE/libs/bft-smart-0.6.3.RELEASE.jar
0: file:/opt/jdchain-peer-1.3.0.RELEASE/libs/bcprov-jdk15on-1.61.jar
0: file:/opt/jdchain-peer-1.3.0.RELEASE/libs/bcpkix-jdk15on-1.61.jar
0: file:/opt/jdchain-peer-1.3.0.RELEASE/libs/base-1.3.0.RELEASE.jar
0: file:/opt/jdchain-peer-1.3.0.RELEASE/libs/annotations-2.0.1.jar
0: file:/opt/jdchain-peer-1.3.0.RELEASE/libs/amqp-client-5.7.3.jar
-------- system jars --------
0: file:/opt/jdchain-peer-1.3.0.RELEASE/system/storage-rocksdb-1.3.0.RELEASE.jar
0: file:/opt/jdchain-peer-1.3.0.RELEASE/system/storage-redis-1.3.0.RELEASE.jar
0: file:/opt/jdchain-peer-1.3.0.RELEASE/system/storage-kvdb-1.3.0.RELEASE.jar
0: file:/opt/jdchain-peer-1.3.0.RELEASE/system/storage-composite-1.3.0.RELEASE.jar
0: file:/opt/jdchain-peer-1.3.0.RELEASE/system/runtime-modular-booter-1.3.0.RELEASE.jar
0: file:/opt/jdchain-peer-1.3.0.RELEASE/system/runtime-modular-1.3.0.RELEASE.jar
0: file:/opt/jdchain-peer-1.3.0.RELEASE/system/peer-1.3.0.RELEASE.jar
0: file:/opt/jdchain-peer-1.3.0.RELEASE/system/deploy-peer-1.3.0.RELEASE.jar
Load configuration,ledgerBindConfigFile position=/opt/jdchain-peer-1.3.0.RELEASE/config/ledger-binding.conf
▄▄▄▄▄▄▄▄▄▄▄  ▄▄▄▄▄▄▄▄▄▄        ▄▄▄▄▄▄▄▄▄▄   ▄            ▄▄▄▄▄▄▄▄▄▄▄  ▄▄▄▄▄▄▄▄▄▄▄  ▄    ▄       ▄▄▄▄▄▄▄▄▄▄▄  ▄         ▄  ▄▄▄▄▄▄▄▄▄▄▄  ▄▄▄▄▄▄▄▄▄▄▄  ▄▄        ▄
▐░░░░░░░░░░░▌▐░░░░░░░░░░▌      ▐░░░░░░░░░░▌ ▐░▌          ▐░░░░░░░░░░░▌▐░░░░░░░░░░░▌▐░▌  ▐░▌     ▐░░░░░░░░░░░▌▐░▌       ▐░▌▐░░░░░░░░░░░▌▐░░░░░░░░░░░▌▐░░▌      ▐░▌
▀▀▀▀▀█░█▀▀▀ ▐░█▀▀▀▀▀▀▀█░▌     ▐░█▀▀▀▀▀▀▀█░▌▐░▌          ▐░█▀▀▀▀▀▀▀█░▌▐░█▀▀▀▀▀▀▀▀▀ ▐░▌ ▐░▌      ▐░█▀▀▀▀▀▀▀▀▀ ▐░▌       ▐░▌▐░█▀▀▀▀▀▀▀█░▌ ▀▀▀▀█░█▀▀▀▀ ▐░▌░▌     ▐░▌
▐░▌    ▐░▌       ▐░▌     ▐░▌       ▐░▌▐░▌          ▐░▌       ▐░▌▐░▌          ▐░▌▐░▌       ▐░▌          ▐░▌       ▐░▌▐░▌       ▐░▌     ▐░▌     ▐░▌▐░▌    ▐░▌
▐░▌    ▐░▌       ▐░▌     ▐░█▄▄▄▄▄▄▄█░▌▐░▌          ▐░▌       ▐░▌▐░▌          ▐░▌░▌        ▐░▌          ▐░█▄▄▄▄▄▄▄█░▌▐░█▄▄▄▄▄▄▄█░▌     ▐░▌     ▐░▌ ▐░▌   ▐░▌
▐░▌    ▐░▌       ▐░▌     ▐░░░░░░░░░░▌ ▐░▌          ▐░▌       ▐░▌▐░▌          ▐░░▌         ▐░▌          ▐░░░░░░░░░░░▌▐░░░░░░░░░░░▌     ▐░▌     ▐░▌  ▐░▌  ▐░▌
▐░▌    ▐░▌       ▐░▌     ▐░█▀▀▀▀▀▀▀█░▌▐░▌          ▐░▌       ▐░▌▐░▌          ▐░▌░▌        ▐░▌          ▐░█▀▀▀▀▀▀▀█░▌▐░█▀▀▀▀▀▀▀█░▌     ▐░▌     ▐░▌   ▐░▌ ▐░▌
▐░▌    ▐░▌       ▐░▌     ▐░▌       ▐░▌▐░▌          ▐░▌       ▐░▌▐░▌          ▐░▌▐░▌       ▐░▌          ▐░▌       ▐░▌▐░▌       ▐░▌     ▐░▌     ▐░▌    ▐░▌▐░▌
▄▄▄▄▄█░▌    ▐░█▄▄▄▄▄▄▄█░▌     ▐░█▄▄▄▄▄▄▄█░▌▐░█▄▄▄▄▄▄▄▄▄ ▐░█▄▄▄▄▄▄▄█░▌▐░█▄▄▄▄▄▄▄▄▄ ▐░▌ ▐░▌      ▐░█▄▄▄▄▄▄▄▄▄ ▐░▌       ▐░▌▐░▌       ▐░▌ ▄▄▄▄█░█▄▄▄▄ ▐░▌     ▐░▐░▌
▐░░░░░░░▌    ▐░░░░░░░░░░▌      ▐░░░░░░░░░░▌ ▐░░░░░░░░░░░▌▐░░░░░░░░░░░▌▐░░░░░░░░░░░▌▐░▌  ▐░▌     ▐░░░░░░░░░░░▌▐░▌       ▐░▌▐░▌       ▐░▌▐░░░░░░░░░░░▌▐░▌      ▐░░▌
▀▀▀▀▀▀▀      ▀▀▀▀▀▀▀▀▀▀        ▀▀▀▀▀▀▀▀▀▀   ▀▀▀▀▀▀▀▀▀▀▀  ▀▀▀▀▀▀▀▀▀▀▀  ▀▀▀▀▀▀▀▀▀▀▀  ▀    ▀       ▀▀▀▀▀▀▀▀▀▀▀  ▀         ▀  ▀         ▀  ▀▀▀▀▀▀▀▀▀▀▀  ▀        ▀▀
09:56:41.283 INFO  org.springframework.boot.StartupInfoLogger 55 logStarting - Starting application on localhost.localdomain with PID 6558 (started by root in /opt/jdchain-peer-1.3.0.RELEASE/bin)
09:56:41.533 INFO  org.springframework.boot.SpringApplication 651 logStartupProfileInfo - No active profile set, falling back to default profiles: default
09:56:43.197 INFO  org.springframework.boot.web.embedded.tomcat.TomcatWebServer 92 initialize - Tomcat initialized with port(s): 7080 (http)
09:56:43.222 INFO  org.apache.juli.logging.DirectJDKLog 173 log - Initializing ProtocolHandler ["http-nio-<IP_ADDRESS>-7080"]
09:56:43.223 INFO  org.apache.juli.logging.DirectJDKLog 173 log - Starting service [Tomcat]
09:56:43.224 INFO  org.apache.juli.logging.DirectJDKLog 173 log - Starting Servlet engine: [Apache Tomcat/9.0.31]
09:56:43.303 INFO  org.apache.juli.logging.DirectJDKLog 173 log - Initializing Spring embedded WebApplicationContext
09:56:43.303 INFO  org.springframework.boot.web.servlet.context.ServletWebServerApplicationContext 284 prepareWebApplicationContext - Root WebApplicationContext: initialization completed in 1721 ms
09:56:43.557 INFO  org.reflections.Reflections 229 scan - Reflections took 55 ms to scan 5 urls, producing 16 keys and 49 values
09:56:43.863 INFO  org.springframework.boot.autoconfigure.security.servlet.UserDetailsServiceAutoConfiguration 86 getOrDeducePassword -
Using generated security password: f231a578-b4b4-4c24-ba01-a08f6667ad38
09:56:43.984 INFO  org.springframework.security.web.DefaultSecurityFilterChain 43  - Creating filter chain: any request, [org.springframework.security.web.context.request.async.WebAsyncManagerIntegrationFilter@22ebccb9, org.springframework.security.web.context.SecurityContextPersistenceFilter@529c2a9a, org.springframework.security.web.header.HeaderWriterFilter@ed91d8d, org.springframework.security.web.authentication.logout.LogoutFilter@527fc8e, org.springframework.security.web.savedrequest.RequestCacheAwareFilter@26bbe604, org.springframework.security.web.servletapi.SecurityContextHolderAwareRequestFilter@80bfa9d, org.springframework.security.web.authentication.AnonymousAuthenticationFilter@5875de6a, org.springframework.security.web.session.SessionManagementFilter@1cf0cacc, org.springframework.security.web.access.ExceptionTranslationFilter@59bbe88a, org.springframework.security.web.access.intercept.FilterSecurityInterceptor@2d4608a6]
09:56:44.149 INFO  org.springframework.scheduling.concurrent.ExecutorConfigurationSupport 181 initialize - Initializing ExecutorService 'applicationTaskExecutor'
09:56:44.279 INFO  org.springframework.boot.autoconfigure.web.servlet.WelcomePageHandlerMapping 54  - Adding welcome page: class path resource [META-INF/resources/index.html]
09:56:44.351 INFO  org.springframework.scheduling.concurrent.ExecutorConfigurationSupport 181 initialize - Initializing ExecutorService 'taskScheduler'
09:56:44.381 INFO  org.apache.juli.logging.DirectJDKLog 173 log - Starting ProtocolHandler ["http-nio-<IP_ADDRESS>-7080"]
09:56:44.424 INFO  org.springframework.boot.web.embedded.tomcat.TomcatWebServer 204 start - Tomcat started on port(s): 7080 (http) with context path ''
09:56:44.428 INFO  org.springframework.boot.StartupInfoLogger 61 logStarted - Started application in 3.635 seconds (JVM running for 4.617)
09:56:44.537 WARN  com.jd.blockchain.provider.ProviderManager$NamedProviders 156 install - The provider[com.jd.blockchain.crypto.service.classic.ClassicCryptoService] already exists.
09:56:44.538 WARN  com.jd.blockchain.provider.ProviderManager$NamedProviders 156 install - The provider[com.jd.blockchain.crypto.service.sm.SMCryptoService] already exists.
------ [[ max-parallel-dbwrite-size=500 ]] ------
09:56:44.874 INFO  com.jd.blockchain.consensus.bftsmart.service.BftsmartNodeServer 631 start - =============================== Start replica ===================================
09:56:44.874 INFO  com.jd.blockchain.consensus.bftsmart.service.BftsmartNodeServer 643 start - Start replica...[ID=0]
09:56:44.924 ERROR bftsmart.communication.server.ServerConnection$ReceiverThread 621 run - [ServerConnection.ReceiverThread] I will waitAndConnect connect with 3
09:56:44.926 ERROR bftsmart.communication.server.ServerConnection$ReceiverThread 621 run - [ServerConnection.ReceiverThread] I will waitAndConnect connect with 1
09:56:44.926 ERROR bftsmart.communication.server.ServerConnection$ReceiverThread 621 run - [ServerConnection.ReceiverThread] I will waitAndConnect connect with 2
09:56:45.117 INFO  bftsmart.communication.client.netty.NettyClientServerCommunicationSystemServerSide 104  - -- ID = 0
09:56:45.117 INFO  bftsmart.communication.client.netty.NettyClientServerCommunicationSystemServerSide 105  - -- N = 4
09:56:45.118 INFO  bftsmart.communication.client.netty.NettyClientServerCommunicationSystemServerSide 106  - -- F = 1
09:56:45.118 INFO  bftsmart.communication.client.netty.NettyClientServerCommunicationSystemServerSide 107  - -- Port = 6300
09:56:45.118 INFO  bftsmart.communication.client.netty.NettyClientServerCommunicationSystemServerSide 108  - -- requestTimeout = 60000
09:56:45.118 INFO  bftsmart.communication.client.netty.NettyClientServerCommunicationSystemServerSide 109  - -- maxBatch = 2000
09:56:45.119 INFO  bftsmart.communication.client.netty.NettyClientServerCommunicationSystemServerSide 110  - -- Using MACs
09:56:45.119 INFO  bftsmart.tom.ServiceReplica 344 init - -- In current view: ID:0; F:1; Processes:0(/<IP_ADDRESS>:6300),1(/<IP_ADDRESS>:6300),2(/<IP_ADDRESS>:6300),3(/<IP_ADDRESS>:6300),
09:56:47.482 INFO  bftsmart.communication.server.ServerConnection 463 authenticateAndEstablishAuthKey - I am proc 0, -- Diffie-Hellman complete with proc id 1, with port 6301
09:56:49.094 INFO  bftsmart.communication.server.ServerConnection 463 authenticateAndEstablishAuthKey - I am proc 0, -- Diffie-Hellman complete with proc id 2, with port 6301
09:56:49.926 ERROR bftsmart.communication.server.ServerConnection$ReceiverThread 621 run - [ServerConnection.ReceiverThread] I will waitAndConnect connect with 3
09:56:49.934 INFO  bftsmart.statemanagement.strategy.BaseStateManager 254 currentConsensusIdReceived - -- Replica state is up to date
09:56:50.002 WARN  com.jd.blockchain.peer.web.LedgerLoadTimer 109 ledgerLoad - --- Can not get semaphore of load ledger !!!
09:56:50.154 INFO  com.jd.blockchain.consensus.bftsmart.service.BftsmartNodeServer 650 start - =============================== Replica started success! ===================================
09:56:50.890 INFO  bftsmart.communication.server.ServerConnection 463 authenticateAndEstablishAuthKey - I am proc 0, -- Diffie-Hellman complete with proc id 3, with port 6301
10:15:45.819 INFO  org.apache.juli.logging.DirectJDKLog 173 log - Initializing Spring DispatcherServlet 'dispatcherServlet'
10:15:45.820 INFO  org.springframework.web.servlet.FrameworkServlet 525 initServletBean - Initializing Servlet 'dispatcherServlet'
10:15:45.828 INFO  org.springframework.web.servlet.FrameworkServlet 547 initServletBean - Completed initialization in 7 ms
10:15:46.025 INFO  com.jd.blockchain.consensus.bftsmart.service.BftsmartNodeServer 252 getOuterTopology - [BftsmartNodeServer.getOuterTopology] PartiNode id = 0, host = <IP_ADDRESS>, port = 6300
10:15:46.037 INFO  com.jd.blockchain.consensus.bftsmart.service.BftsmartNodeServer 252 getOuterTopology - [BftsmartNodeServer.getOuterTopology] PartiNode id = 1, host = <IP_ADDRESS>, port = 6300
10:15:46.051 INFO  com.jd.blockchain.consensus.bftsmart.service.BftsmartNodeServer 252 getOuterTopology - [BftsmartNodeServer.getOuterTopology] PartiNode id = 2, host = <IP_ADDRESS>, port = 6300
10:15:46.065 INFO  com.jd.blockchain.consensus.bftsmart.service.BftsmartNodeServer 252 getOuterTopology - [BftsmartNodeServer.getOuterTopology] PartiNode id = 3, host = <IP_ADDRESS>, port = 6300
这个是节点

@galnt  网关节点有报什么错误吗？

由于提供的信息有限，难以进一步帮助您进行定位，故此先关闭此问题，如果补充信息欢迎再次反馈。
另外，目前 1.4.0.RELEASE 版本已经发布，新增了共识节点的动态添加移除功能，并且在共识算法的稳定性上有重大提升，欢迎关注。

由于提供的信息有限，难以进一步帮助您进行定位，故此先关闭此问题，如果补充信息欢迎再次反馈。
另外，目前 1.4.0.RELEASE 版本已经发布，新增了共识节点的动态添加移除功能，并且在共识算法的稳定性上有重大提升，欢迎关注。


Heroes can't be copied.

Please check my documents carefully.

This is a derivative version based on the Japanese version.


feat: add displayName to component in status

What type of PR is this?
/kind feat

What this PR does / why we need it
Which issue(s) this PR fixes

Fixes #300
Special notes for your reviewer
For HTTP/HTTPS repo
For a component with this Chat.yaml
apiVersion: v2
name: core
annotations:
  core.kubebb.k8s.com.cn/displayname: "内核"
description: Kubebb Core provides core implementations on Component Lifecycle Management.Our design and development follows operator pattern which extends kubernetes APIs.
type: application
version: v0.1.11
appVersion: v0.1.4
icon: https://avatars.githubusercontent.com/u/85277200
keywords:
  - repository
  - helm
  - lifecycle-management
sources:
  - https://github.com/kubebb/core
maintainers:
  - name: bjwswang
    url: https://github.com/bjwswang
  - name: Abirdcfly
    url: https://github.com/Abirdcfly
  - name: 0xff-dev
    url: https://github.com/0xff-dev

The component synced by repository watcher will be
apiVersion: core.kubebb.k8s.com.cn/v1alpha1
kind: Component
metadata:
  creationTimestamp: "2023-08-28T02:31:36Z"
  generation: 1
  labels:
    kubebb.component.repository: chartmuseum
  name: chartmuseum.core
  namespace: kubebb-system
  ownerReferences:
  - apiVersion: core.kubebb.k8s.com.cn/v1alpha1
    kind: Repository
    name: chartmuseum
    uid: dde61679-dac8-4b20-8702-5818ceb749dc
  resourceVersion: "375033"
  uid: 73ecdd02-1cc6-47ae-ab3a-c8c66bfd1811
spec: {}
status:
  description: Kubebb Core provides core implementations on Component Lifecycle Management.Our
    design and development follows operator pattern which extends kubernetes APIs.
  displayName: 内核
  icon: https://avatars.githubusercontent.com/u/85277200
  keywords:
  - repository
  - helm
  - lifecycle-management
  maintainers:
  - name: Abirdcfly
    url: https://github.com/Abirdcfly
  - name: 0xff-dev
    url: https://github.com/0xff-dev
  - name: bjwswang
    url: https://github.com/bjwswang
  name: core
  repository:
    apiVersion: core.kubebb.k8s.com.cn/v1alpha1
    kind: Repository
    name: chartmuseum
    namespace: kubebb-system
    uid: dde61679-dac8-4b20-8702-5818ceb749dc
  sources:
  - https://github.com/kubebb/core
  versions:
  - annotations:
      core.kubebb.k8s.com.cn/displayname: 内核
    appVersion: v0.1.4
    createdAt: "2023-08-28T02:30:31Z"
    deprecated: false
    digest: c79d061434011b6815c8c8cb4013bc16233ebb6c58c0fd3ec59cee13cf7eaa4c
    updatedAt: "2023-08-28T02:31:36Z"
    version: v0.1.11

When there is a new version detected with different displayname, the component will keep the latest one.
apiVersion: core.kubebb.k8s.com.cn/v1alpha1
kind: Component
metadata:
  creationTimestamp: "2023-08-28T02:31:36Z"
  generation: 1
  labels:
    kubebb.component.repository: chartmuseum
  name: chartmuseum.core
  namespace: kubebb-system
  ownerReferences:
  - apiVersion: core.kubebb.k8s.com.cn/v1alpha1
    kind: Repository
    name: chartmuseum
    uid: dde61679-dac8-4b20-8702-5818ceb749dc
  resourceVersion: "379412"
  uid: 73ecdd02-1cc6-47ae-ab3a-c8c66bfd1811
spec: {}
status:
  description: Kubebb Core provides core implementations on Component Lifecycle Management.Our
    design and development follows operator pattern which extends kubernetes APIs.
  displayName: 内核升级版
  icon: https://avatars.githubusercontent.com/u/85277200
  keywords:
  - repository
  - helm
  - lifecycle-management
  maintainers:
  - name: bjwswang
    url: https://github.com/bjwswang
  - name: Abirdcfly
    url: https://github.com/Abirdcfly
  - name: 0xff-dev
    url: https://github.com/0xff-dev
  name: core
  repository:
    apiVersion: core.kubebb.k8s.com.cn/v1alpha1
    kind: Repository
    name: chartmuseum
    namespace: kubebb-system
    uid: dde61679-dac8-4b20-8702-5818ceb749dc
  sources:
  - https://github.com/kubebb/core
  versions:
  - annotations:
      core.kubebb.k8s.com.cn/displayname: 内核升级版
    appVersion: v0.1.4
    createdAt: "2023-08-28T02:48:14Z"
    deprecated: false
    digest: 3e8c9fa7f6ce5c25c0f76536e93c06732051a35f109469f71f3d1e57e6f593c6
    updatedAt: "2023-08-28T02:49:37Z"
    version: v0.1.12
  - annotations:
      core.kubebb.k8s.com.cn/displayname: 内核
    appVersion: v0.1.4
    createdAt: "2023-08-28T02:30:31Z"
    deprecated: false
    digest: c79d061434011b6815c8c8cb4013bc16233ebb6c58c0fd3ec59cee13cf7eaa4c
    updatedAt: "2023-08-28T02:49:37Z"
    version: v0.1.11

OCI not tested yet

@Abirdcfly @0xff-dev pls review. OCI repo do not support upgrade yet,so  I can't test this casedisplayName update upon different version


ts errors / addMissingImports / checkJS , AllowJs / "javascript.validate.enable": false

Type: Bug
I use js/jsx . I want to use the function "source.addMissingImports": true , but the problem is that it only works for me when I enable checkJS . For me, check JS causes the error ts (2339) and not only, but without check JS, adding imports does not work. Allow Js doesn't work either. "typescript.validate.enable": false,
""javascript.validate.enable": false, I also tried to set, but if I disable "javascript.validate", then adding imports stops working for me again.
What should I do so that this function works and there is no error?
VS Code version: Code - Insiders 1.78.0-insider (3ad5774eb8123d4224eb55629df9e5f82fe13b99, 2023-04-14T05:25:56.476Z)
OS version: Windows_NT x64 10.0.19045
Modes:
Sandboxed: Yes

System Info

Item
Value

CPUs
Intel(R) Core(TM) i5-7200U CPU @ 2.50GHz (4 x 2712)

GPU Status
2d_canvas: enabledcanvas_oop_rasterization: disabled_offdirect_rendering_display_compositor: disabled_off_okgpu_compositing: enabledmultiple_raster_threads: enabled_onopengl: enabled_onrasterization: enabledraw_draw: disabled_off_okvideo_decode: enabledvideo_encode: enabledvulkan: disabled_offwebgl: enabledwebgl2: enabledwebgpu: enabled

Load (avg)
undefined

Memory (System)
15.89GB (4.89GB free)

Process Argv
--crash-reporter-id 8d5950e0-2632-4265-9569-e267bad308c4

Screen Reader
no

VM
0%

Extensions (41)

Extension
Author (truncated)
Version

better-comments
aar
3.0.2

vscode-color-picker
Ant
0.0.4

htmltagwrap
bra
0.0.9

npm-intellisense
chr
1.4.4

path-intellisense
chr
2.8.4

vscode-eslint
dba
2.4.0

vscode-faker
dee
2.0.0

gitlens
eam
13.5.0

vscode-html-css
ecm
1.13.1

prettier-vscode
esb
9.10.4

auto-close-tag
for
0.5.14

auto-complete-tag
for
0.1.0

auto-rename-tag
for
0.1.10

backticks
fra
1.7.0

todo-tree
Gru
0.0.226

google-translate
han
1.2.8

stylelint-plus
hex
0.56.6

vscode-htmlhint
HTM
1.0.4

discord-vscode
icr
5.8.0

hungry-delete
jas
1.7.0

styled-components-snippets
jon
0.10.0

google-fonts
lio
0.0.1

vscode-scss
mrm
0.10.0

css-responsive-jsx-tsx
MrO
1.1.3

vscode-language-pack-ru
MS-
1.77.2023041209

color-highlight
nau
2.5.0

px-to-rem
sai
1.3.1

svg-preview
Sim
2.8.3

guides
spy
0.9.3

autoimport
ste
1.5.4

code-spell-checker
str
2.20.4

code-spell-checker-russian
str
2.0.9

vscode-styled-components
sty
1.7.8

vscode-stylelint
sty
1.2.4

highlight-matching-tag
vin
0.11.0

intellicode-api-usage-examples
Vis
0.2.7

vscodeintellicode
Vis
1.2.30

vscode-icons
vsc
12.3.0

vscode-import-cost
wix
3.3.0

change-case
wma
1.0.0

material-theme
zhu
3.15.8

A/B Experiments
vsliv695:30137379
vsins829:30139715
vsliv368cf:30146710
vsreu685:30147344
python383cf:30185419
vspor879:30202332
vspor708:30202333
vspor363:30204092
vslsvsres303:30308271
pythontb:30258533
pythonptprofiler:30281269
vshan820:30294714
pythondataviewer:30285072
vscod805:30301674
bridge0708:30335490
bridge0723:30353136
cmake_vspar411:30581797
vsaa593:30376534
pythonvs932:30404738
cppdebug:30492333
vsclangdf:30492506
c4g48928:30535728
dsvsc012cf:30540253
pynewext54:30618038
pylantcb52:30590116
nodejswelcome1:30587009
pyind779:30611226
vscrp:30624060
pythonsymbol12:30651887
6233i204:30659907
functionswalk:30687959
pythonms35:30671666
pythonfmttext:30710679
pythonclientmv:30700173

I've also read the vs code documentation. Why are you refactoring code only for TypeScript. I understand that for developers it is more gentle than regular javascript, but the organization of imports and the addition of non-existing ones is needed everywhere and it would be great to take it out as a separate function. (in code Action)

   I tried to prescribe "ignoreDeprecations": "5.0", "suppressExcessPropertyErrors": true, "suppressImplicitAnyIndexErrors": true, but he doesn't care and he doesn't remove the error

can you make addMissingImports work separately from checkJS? I have a lot of incomprehensible errors flying out because of checks.

I use js/jsx . I want to use the function "source.addMissingImports": true , but the problem is that it only works for me when I enable checkJS .

Yes, checkJS signals that you want more advanced type checking. That signals that we can more confidently make fixes to your code too. Otherwise we'd be applying fixes to code that may silently contain coding patterns that we can't analyze, resulting in incorrect fixes

I understand that check JS is made for type checking and much more, but the addMissingImports function does not relate to checkJS.

I have addMissingImports does not work without checkJS and it seems to me that this is wrong. This is a very useful feature and it would be great if it is possible to use it without check JS. I think many people will thank you, because it's convenient.

because addMissingImports refers to Code Actions, not to check JS and it's strange that it doesn't work without checkJs

cool you solved the problem. You have a very useful function by itself does not work, but you are normal, close my posts

is there any way to leave an assessment of your help?

You understand that you just have completely disconnected functions. What is the relationship between type checking in javascript and adding imports of regular files or libraries?


Replace Visual C# 2008 tokens

I wonder if those should be replaced with the "well-known" c# version? C# 2, 3, 4?

I agree, @pkulikov.

Thanks, @NextTurn, for making the additional changes. I'll merge your PR now.


[i2c, dv] Support stress_all test

This PR includes

Add stress_all_vseq test
Update required *_vseq to support stress_all_vseq
Update i2c_testplan.md and i2c_sim_cfg.hjson files

Signed-off-by: Tung Hoang<EMAIL_ADDRESS>

@rswarbrick @weicaiyang since adding some stuff of stress_all_with_rand_reset  test is confusing review process thus I will remove those things in the updated PR.

@weicaiyang @rswarbrick I temporally pull down this PR then submit another one which significant changes for stress_all and stress_all_with_rand_reset. Your valuable comments in this PR will be adopted in the next one.


Log warnings when workers have different commands

The command passed to a native test runner is now cryptographically hashed
and stored alongside a run ID. If a worker connects and has
a command different from the command given to the worker that
initialized run, log a warning on both the worker and the server.
This is backwards compatible. Older runs loaded on a queue won't have
their command hashes checked.

This unfortunately took a bit longer than expected, because I false-started with saving the command as a string, and had forgotten that we persist run information between instances.


cli: add YAML syntax similar to HCL

add a YAML syntax that is similar to HCL. For example, a workflow similar to the minimal-python one when written in YAML:
steps:

- uses: "popperized/bin/curl@master"
  args: [
    "--create-dirs",
    "-Lo workflows/minimal-python/data/global.csv",
    "https://github.com/datasets/co2-fossil-global/raw/master/global.csv"
  ]

- id: 'analysis 1'
  uses: "jefftriplett/python-actions@master"
  args: "workflows/minimal-python/scripts/get_mean_by_group.py"
    "workflows/minimal-python/data/global.csv",
    "5"
  ]

- id: 'analysis 2'
  uses: "jefftriplett/python-actions@master"
  args: "workflows/minimal-python/scripts/analysis2.py"

- uses: "jefftriplett/python-actions@master"
  needs: ['analysis 1', 'analysis 2']
  args: [
    "workflows/minimal-python/scripts/validate_output.py",
    "workflows/minimal-python/data/global_per_capita_mean.csv"
  ]

some comments:

if no id for a step is given, an internal one is generated (e.g. 1 for the first step above).
if no needs attribute is given for a step, the steps list is used to determine the order in which the step is executed. In the example above, analysis 1 executes after the first step.
if a needs attribute is given, then that is used to determine the order in which to execute steps. For example, in the above, the last step references analysis 1 and analysis 2 as the steps needed to execute before it.
all the other attributes of HCL syntax action (env, secrets, etc..) are supported.

steps list is used to determine the order in which the step is executed.

@ivotron I am confused about what will be the execution order for the above workflow.  Can you please tell me like how should steps without needs attribute be connected to the graph generated by the steps having needs attribute?

hey @JayjeetAtGithub, sorry for the confusion.

Is it like we generate a DAG as far as possible connecting as many steps as possible to and then connect the remaining steps(actions) with the root of the forward edged graph in the order given in which they are given in the steps list?

yes. Another way to think about is like this: if a step doesn't have a needs entry, it has to wait for all previous steps to finish before it executes. So a more illustrative example (I ignore args for simplicity) would be:
steps:

- uses: "popperized/bin/curl@master"

- id: 'analysis'
  uses: "jefftriplett/python-actions@master"

- id: 'I run concurrently with last step'
  needs: ['analysis']
  uses: "docker://alpine:3.8"

- id: 'I have to wait for the above to finish'
  uses: "docker://alpine:3.8"

- id: 'I can run before the above'
  needs: ['analysis']
  uses: "jefftriplett/python-actions@master"

using numbers, the order looks like:
1 -> 2 -> (3, 5) -> 4

note that in the above workflow we can remove the id attribute from the last three steps and the order of execution is the same. In general, the goal is to mimic google cloud build's way of handling this.
please let me know if you have any other question

Thanks a lot for the clarification @ivotron.


feat(deprecation): Add requirement on documentation

Add requirement on documentation.
Checklist

[x] Commits are signed with Developer Certificate of Origin (DCO)

We have concensus, merging. But feel free to raise concerns async if any rise.


[Event Request] report 595 "Adjust Exchange Rates" - Function AdjustVendorLedgerEntry - OnAdjustVendorLedgerEntryOnChangeVendorPostGroup

Could You please, add the following event to the report 595 "Adjust Exchange Rates"
Object: Report 595 "Adjust Exchange Rates"
Function: AdjustVendorLedgerEntry
Publisher Event: OnAdjustVendorLedgerEntryOnChangeVendorPostGroup
Reason: To implement custom business logic and change the Vendor Posting Group to be taken into account when the adjust will be made
Where is the event placed (see image attached)?:

after the line
if AdjAmount <> 0 then begin
Insert the call to the event
OnAdjustVendorLedgerEntryOnChangeVendorPostGroup(Vendor, VendLedgerEntry);
Note: Vendor is the name of the DataItem for Table 23
Event Code:
[IntegrationEvent(false, false)]
local procedure OnAdjustVendorLedgerEntryOnChangeVendorPostGroup(var Vendor: Record "Vendor"; VendLedgerEntry: Record "Vendor Ledger Entry");
begin
end;
Thanks in Advance

Thanks for reporting this. We agree, and we’ll publish a fix asap, either in an update for the current version or in the next major release. We will update this issue with information about availability.


Add a screen shake effect

What problem does this solve or what need does it fill?
Adds a nice effect to games.
What solution would you like?
Add some kind of component or animation to a Camera to add a screen shake.
Additional context
See also: https://shaggydev.com/2022/02/23/screen-shake-godot/

there is already bevy_camera_shake for 0.8.1 but with the 0.9 release on the horizon it looks like it could do with an update.

this definitely feels like it fits an ecosystem implementation rather than something in Bevy itself. Unreal is the only engine I can find which provides builtin camera shake. Unity and Godot both leave it up to the user.

Going to second the opinion that this is ideal for an ecosystem crate solution. Not every game needs it and the implementation is relatively simple to maintain separately from the core engine. Might even be doable via just normal animation systems or user-made game code.

this definitely feels like it fits an ecosystem implementation

Agreed. Bevy would need to have quite extensive video-sequencing and camera tools in-house before it starts to make sense to first-party supply camera effects.

Related: https://github.com/bevyengine/bevy/issues/15564


Feature Request: add --ignore-forward-fees-below and --ignore-rebalance-fees-below

in addition to --ignore-forwards-below and --ignore-rebalances-below, for channels that have a zero fee, or very low fee (heavy source channels), a node operator might want to suppress getting alerted every time that channel receives funds, even if it's over the forwards-below threshold since it results in 0 (or close to zero) fees earned. Likewise, it would be nice to be able to ignore rebalances of even high amounts if the cost for those rebalances is under a certain threshold.
.option("--ignore-forward-fees-below <amount>", "Ignore forwards that earn fees below value", INT)
.option("--ignore-rebalance-fees-below <amount>", "Ignore rebalances that cost fees below value", INT)

I'd like to be able to remove alerts for any transactions below a limit, forwards, rebalances or receipts.
As part of Podcasting 2.0 I sometimes get dozens of 1 sat transactions every minute. This gets rather noisy.


Support Azure Spot instances prices

Thank you for this contribution @Subreptivus . Could you share a little bit more about how this was tested? @Sean-Holcomb to review!

Hmm, quite simple - on our AKS clusters, as simple as that. The simplest approach would be to get the price thru api and compare it to what Prometheus has as a metric node_total_hourly_cost for spot node.

Ok, first about why it isn't happening in DownloadPricingData(). Because it would be massive waste of time. The regular approach of using spot instances is to add them to one or few nodepools in your cluster. So all the spot nodes will be pretty much the same. So we can get the prices in single or few queries. To have it as a final loop which populates the spot prices in the the az.Pricing map will add so much logic to it. Because retail prices api can't give you full data as ratecard api, there will be paginations and so on. And ratecard api can't do so narrowed filtering to get prices for just one type of instances, hence we need to download all the data.
And those two apis aren't interchangeable, we can't just substitute one by another, the values are different.

Sounds reasonable enough, I had some sort of aggressive filtering in mind which might not work for that api. And I know that the ratecard api is account specific and the pricing one is not, so there is that disadvantage. Hopefully in the future they will just add spot pricing to the ratecard api as you said in your comment.
Once you change those couple nits we talked about I am more than happy to approve this PR. We appreciate you contribution!

@Subreptivus I have merged this branch into another where I have made the changes that we have suggested here. Please take a look.

Hey @Sean-Holcomb!
It's very nice of you to make code cleanup and other refactoring, thank you very much!
And it's kind of my bad, I was expecting to have some finished decision between you and Niko Kovacevic about how this PR should be changed. Time went by and I've forgotten about it successfully. Sorry about that.
One more thing about testing. I was doing that prior of making this PR, and everything was ok, calculated price was the same as in Azure Portal, etc. But you can finish your tests just to be sure.


[CWS] Prevent a segfault on ebpfless mode startup

What does this PR do?
Bug introduced in The PR "Add is_public field to IP addresses"
In the actual state, systemprobe segfault at startup.
Motivation
Describe how to test/QA your changes
Possible Drawbacks / Trade-offs
Additional Notes

/merge


falcon-container-sensor-pull does not grab the latest version

A simple tail assumes that the results returned are already ordered.

That's because they should be ordered.. is this not working for you?

This is not working for me. When I use the script with parameters:
--region us-gov-1 --type falcon-imageanalyzer
I receive the following results (removed the tail -1):

name
falcon-imageanalyzer
tags
0.42.0
1.0.10
1.0.11
1.0.12
1.0.13
1.0.3
1.0.8
1.0.9
name
falcon-imageanalyzer
repository
registry.laggar.gcw.crowdstrike.com
falcon-imageanalyzer
gov1
release
falcon-imageanalyzer
tags
0.42.0
1.0.10
1.0.11
1.0.12
1.0.13
1.0.3
1.0.8
1.0.9

So 1.0.9 is selected despite 1.0.13 being available. There are also a lot of other strings which I guess the formatting function ensures will not be the last items? I think using awk/sed may be the wrong approach

Appreciate you posting the issue and example! I will definitely look into this and see if we can clean it up. I assume you are running the latest version of the script correct? Just want to make sure I can emulate this in my end.

So running the latest I'm not seeing that issue:
$ ./falcon-container-sensor-pull.sh -t falcon-imageanalyzer --list-tags -r us-gov-1 | awk -v RS=" " '{print}' | grep "$SENSOR_VERSION" | grep -o "[0-9a-zA-Z_\.\-]*"
name
falcon-imageanalyzer
repository
registry.laggar.gcw.crowdstrike.com
falcon-imageanalyzer
gov1
release
falcon-imageanalyzer
tags
0.42.0
1.0.3
1.0.8
1.0.9
1.0.10
1.0.11
1.0.12
1.0.13

and with tail -1:
$ ./falcon-container-sensor-pull.sh -t falcon-imageanalyzer --list-tags -r us-gov-1 | awk -v RS=" " '{print}' | grep "$SENSOR_VERSION" | grep -o "[0-9a-zA-Z_\.\-]*" | tail -1
1.0.13

My guess is you are using an older version of the script that doesn't have the changes for version sorting.

Ah, yes. The latest version sorts the versions properly. Sorry about that.

Ah, yes. The latest version sorts the versions properly. Sorry about that.


EF fails to SQL-ize a cast in a checked function

Entity Framework Core fails to transform an expression containing a cast into equivalent SQL when that cast is inside a checked function.
Steps to reproduce
Run the following repro case with SQL Server Profiler attached.
using System;
using System.Data.SqlClient;
using System.Linq;
using Microsoft.EntityFrameworkCore;

namespace EFCoreChecking
{
	class Program
	{
		static void Main(string[] args)
		{
			Console.WriteLine("Creating database...");

			using (var connection = new SqlConnection(GetConnectionString("master")))
			{
				connection.Open();

				Execute(connection, "IF EXISTS(select * from sys.databases where name='EFCoreRepro') DROP DATABASE EFCoreRepro");
				Execute(connection, "CREATE DATABASE EFCoreRepro");
				connection.ChangeDatabase("EFCoreRepro");
				Execute(connection, "CREATE TABLE Records (Id int, RecordType int, Created DateTime, Data varchar(256))");
			}

			Console.WriteLine("Finding oldest record...");

			using (var context = CreateContext())
			{
				var checkedResult = FindOldestRecordChecked(context, DummyRecordType.Foo);
				Console.WriteLine("Checked: {0}", checkedResult?.ToString() ?? "<no data>");
			}

			using (var context = CreateContext())
			{
				var uncheckedResult = FindOldestRecordUnchecked(context, DummyRecordType.Foo);
				Console.WriteLine("Unchecked: {0}", uncheckedResult?.ToString() ?? "<no data>");
			}
		}

		static DateTime? FindOldestRecordChecked(DummyContext context, DummyRecordType type)
		{
			checked
			{
				var matchingRecords = context.Set<DummyRecord>()
					.Where(r => r.RecordType == (byte)type);

				return matchingRecords
					.Select(r => r.Created)
					.OrderBy(d => d)
					.Take(1)
					.ToArray()
					.Cast<DateTime?>()
					.FirstOrDefault();
			}
		}

		static DateTime? FindOldestRecordUnchecked(DummyContext context, DummyRecordType type)
		{
			unchecked
			{
				var matchingRecords = context.Set<DummyRecord>()
					.Where(r => r.RecordType == (byte)type);

				return matchingRecords
					.Select(r => r.Created)
					.OrderBy(d => d)
					.Take(1)
					.ToArray()
					.Cast<DateTime?>()
					.FirstOrDefault();
			}
		}

		static DummyContext CreateContext()
		{
			var context = new DummyContext(GetConnectionString("EFCoreRepro"));
			return context;
		}

		static string GetConnectionString(string databaseName)
		{
			var csb = new SqlConnectionStringBuilder
			{
				DataSource = ".",
				InitialCatalog = databaseName,
				IntegratedSecurity = true,
				ApplicationName = "EFCoreRepro"
			};
			return csb.ToString();
		}

		static void Execute(SqlConnection connection, string command)
		{
			using (var cmd = connection.CreateCommand())
			{
				cmd.CommandText = command;
				cmd.ExecuteNonQuery();
			}
		}
	}

	class DummyContext : DbContext
	{
		public DummyContext(string connectionString)
			: base()
		{
			this.connectionString = connectionString ?? throw new ArgumentNullException(nameof(connectionString));
		}

		readonly string connectionString;

		public DbSet<DummyRecord> Records { get; set; }

		protected override void OnConfiguring(DbContextOptionsBuilder optionsBuilder)
		{
			optionsBuilder.UseSqlServer(connectionString);
		}
	}

	enum DummyRecordType
	{
		Foo,
		Bar,
		Baz
	}

	class DummyRecord
	{
		public int Id { get; set; }
		public int RecordType { get; set; }
		public DateTime Created { get; set; }
		public string Data { get; set; }
	}
}

I expect the following query, or equivalent to be generated from both functions:
SELECT TOP 1 Created
FROM Records
WHERE RecordType = 0
ORDER BY Created

The query generated by the unchecked function is:
exec sp_executesql N'SELECT TOP(@__p_1) [r].[Created]
FROM [Records] AS [r]
WHERE [r].[RecordType] = @__type_0
ORDER BY [r].[Created]',N'@__p_1 int,@__type_0 int',@__p_1=1,@__type_0=0

The query generated by the checked function is:
SELECT [r].[RecordType], [r].[Created]
FROM [Records] AS [r]
ORDER BY [r].[Created]

The query generated by the checked function loads all records, not just the most recent one. In my case, this unneccesarily loads all five million records from a table.
Further technical details
EF Core version: 1.1.1, 1.1.2, 2.0.0-preview2-final
Database Provider: Microsoft.EntityFrameworkCore.SqlServer
Operating system: Windows 10 v1703
IDE: Visual Studio 2017 15.3 Preview 7.0

checked keyword introduces the overflow checking. Therefore when you use create query insider checked block all the cast will create ConvertCheckedExpression whereas in unchecked block it will cause ConvertExpression. The ConvertCheckedExpression needs to check for overflow in C# which cannot be translated to server hence we cannot translate the Where predicate to SQL. This causes all data to be loaded in memory so that filter can be applied & appropriate overflow exception will be thrown at runtime.
Since ConvertExpression does not need exception throwing behavior, we translate it to server (with implicit or explicit cast as needed) hence the whole query is translated in unchecked case.

QueryModels just for info:
checked
Optimized query model:
      '(from DummyRecord r in DbSet<DummyRecord>
      where r.RecordType == ConvertChecked(ConvertChecked(__type_0))

      order by r.Created asc
      select r.Created)
      .Take(__p_1)'

unchecked case
Optimized query model:
      '(from DummyRecord r in DbSet<DummyRecord>
      where r.RecordType == (int) (byte) __type_0
      order by r.Created asc
      select r.Created)
      .Take(__p_1)'

Is this intended to be a breaking change when compared with EF6?
Most of my assemblies are fully checked with the “Enable arithmetic overflow/underflow checking” project propert. I’d now have to find every query with a similar cast and convert those expressions to unchecked.

@yaakov-h - In EF6,

either this query did not work since it fails to translate (EF did not have client eval feature)
or if it did work then it ignored the checked node.

Effectively, there is no way to translate ConvertChecked to SQL and still give the same exception as you would except from C# at run-time. Hence EF Core evaluates it on client to throw exception. In this special case of query since your cast is around a closure variable only, it could be improved a bit (filed #9361). Though if the casting is around any range variable coming from database then EF Core cannot translate it.
As a work-around, you need to use unchecked around all queries. This is what compiler brings in and nothing specific EF can do about.

EF6 does translate this query, so it probably just ignores the checked-ness.
Thanks.


Bug: not all images are processed in Firefox 38. Resulting image is clipped.

The resulting png is full size, but after ~94,5 images the remainder is whitespace. This happens when composing a sprite of 117 jpg's (80px square) with the following settings:
offset: 5px
direction: horizontal
filetype: png
browser: Firefox 38.0.5
Google Chrome seems to handle this without any problem. Perhaps Firefox has some kind of processing limit that needs a workaround?
Result:

It's possibly a bug in Firefox, although I can't reproduce it with 100+ 80x80 jpeg files.  Did you do anything else in the site UI that might be causing the bug?  For reference, I just dragged around 100 80x80 images onto the page, then changed direction to horizontal, then changed offset to 5px, and this is what I see (no clipping):

Oops forgot to check this...it seems not be an issue anymore: mark as solved.


[BUG]: Unable to build

Is there an existing issue for this?

[X] I have searched the existing issues.

🐞 Describe the Bug
Unable to build this npm package
😕 Current Behavior
NPM run build give an type error:
🤔 Expected Behavior
npm build compiles fine.
🔬 Minimal Reproduction
npm run build

🌍 Environment
| Software         | Version(s) |
| ---------------- | ---------- |
| react-paypal-js  |  7.6.0          |
| Browser          |            |
| Operating System |            |

Relevant log output
./node_modules/@paypal/react-paypal-js/dist/types/components/braintree/BraintreePayPalButtons.d.ts:1:15
Type error: ',' expected.

> 1 | import { type FC } from "react";
    |               ^
  2 | import { type BraintreePayPalButtonsComponentProps } from "../../types";
  3 | /**
  4 | This `<BraintreePayPalButtons />` component renders the [Braintree PayPal Buttons](https://developer.paypal.com/braintree/docs/guides/paypal/overview) for Braintree Merchants.

Code of Conduct

[X] I agree to follow this project's Code of Conduct

➕ Anything else?
I have never seen this before.

I am having exactly the same problem in version 7.7.0. Maybe a workaround to exclude these files from type checks?

@krik-chry
Im using react-paypal-button-v2 now. This is working for me.

What is your typescript version? Updating from 4.3.2 to 4.5.5 fixed this issue for me

good to know! My version is 4.6.2

Thanks for reporting this issue. The PayPal team is investigating and testing with different versions of TS to see what's going on.

@KoesterJannik can you test out the latest release 7.8.1 and see if it fixes your issue?
Here’s the related PR that should have fixed it
https://github.com/paypal/react-paypal-js/pull/277

@gregjopa Glad that you had a look. I'll have a look as soon as possible too, test it with the latest version

Thanks. For me it is working with the latest version.


Add Android push

PR made to wrong branch. Correct one is https://github.com/Fiksuruoka-fi/capacitor-intercom


[FIX] (regress_testcase) fix sync with stream load

Proposed changes
Issue Number: close #xxx
Problem summary
when query from slave node , here maybe can not select the stream load result , even the publish version is visible , so make a sync sql to enable result in slave node.
Describe your changes.
Checklist(Required)

[ ] Does it affect the original behavior
[ ] Has unit tests been added
[ ] Has document been added or modified
[ ] Does it need to update dependencies
[ ] Is this PR support rollback (If NO, please explain WHY)

Further comments
If this is a relatively large or complex change, kick off the discussion at<EMAIL_ADDRESS>by explaining why you chose the solution you did and what alternatives you considered, etc...

run buildall

run buildall

run buildall

please merge @morningman


[Event Hubs Client] Connection String SAS Support

Summary
The focus of these changes is to add support for a precomputed shared access signature token to be used as part of the connection string.
Last Upstream Rebase
Thursday, September 3, 2:40pm (EDT)
References and Related Issues

Shared Access Signature Connection String Support (#14711)
[Event Hubs Client] Connection String SAS Support (Preview.3 Base) (#14796)

/azp run net - eventhub - tests


How to deal with dynamic propery in one class?

If a class has a dynamic type propery,The Swagger UI Example Value is {} ,For example
Class B{ public string BP1 {get;set;} public string BP2 {get;set;}}
Class A{ public dynamic Data {get;set;} public string Content {get;set;}}
the example would be  {{"data": {},"content":""},but how to accomplish this value {{"data": {"BP1":"","BP2":""},"content":""}

Is this related to Swashbuckle?
I think that we all agree that dynamic properties should be used sparingly.


P/Invoke Fusion.dll works in .NET Framework, but not in .NET Core

P/Invoke Fusion.dll works in .NET Framework, but not in .NET Core
General
I have an app that uses P/Invoke to call functions inside of Fusion.dll to enumerate .NET Framework assemblies in the Global Assembly Cache.
It works just fine when I target net472 but - the exact same code - does not work when I target netcoreapp2.2:
class Program
{
    static void Main(string[] args)
    {
        GacUtility.CreateAssemblyCache(out var x, 0);
    }
}

public class GacUtility
{
    [DllImport("Fusion.dll")]
    public static extern int CreateAssemblyCache(out object asmCache, int reserved);
}

Error Message
The error message I get (in .NET Core) is:
Unhandled Exception: System.DllNotFoundException:
Unable to load DLL 'Fusion.dll' or one of its dependencies:
The specified module could not be found.
(Exception from HRESULT: 0x8007007E)

NB: I know that the correct signature of CreateAssemblyCache expects an IAssemblyName and I have that correct in my code, and gives me the same error. The code above is a simplified example that reproduces the error the same way...

.NET Core can do P/Invokes just as .NET Framework, but the Probing path that we use to find assemblies is different. In order for that to work, Fusion.dll would need to be part of the probing path for core, Have you tried having Fusion.dll copy-pasted right next to your app?

Thank you for following-up @joperezr. It works if I use the full path of Fusion.dll, so I'm sure if I would to put  Fusion.dll  inside my apps folder, it would work too (provided I copy any dependencies it has, if any)
[DllImport(@"C:\Windows\Microsoft.NET\Framework64\v4.0.30319\fusion.dll")]
public static extern int CreateAssemblyCache(out IntPtr asmCache, int reserved);

My issue now is how to make this work properly:

How do I determine the correct path of Fusion.dll as location may differ at least for x86/x64?
Once I know the path of the Fusion.dll I want, how do I add that path to .NET Core's probing path?

The ideal case is that you should ship all your native dependencies along with your app. I'm not familiar with Fusion.dll, but if it is possible to get it as a NuGet dependency, that would be great so you can package that with your app and not requiring fusion.dll to be installed somewhere in the machine.

@joperezr Fusion.dll is part of the .NET Framework... I don't think it would be possible to ship it with my app. I have to check if the .NET Framework is installed on the machine, if it is is, I know it has Global Assembly Cache there...

Fusion.dll does not seem to be part of .NET Core, only Framework, so I'm not entirely sure it's expected to work, or if we support it.
What functionality are you trying to get from that DLL, @Lindsey1986 ? We might have something in Core that replaced it.
Are you still having this problem?

Since there was no response in 3 weeks, I'll go ahead and close this issue. @Lindsey1986 feel free to reopen if you have any more questions.

I am running into the same issue here for .NET 5.0, I have a .net5.0-windows application that needs to load a specific assembly from the GAC, to do that we need to query the cache via the above mentioned method:
     [DllImport("Fusion.dll")]
    public static extern int CreateAssemblyCache(out object asmCache, int reserved);

If the probing path is the issue how I can I modify that to work?

So Fusion.dll is a .NET Framework sub-system responsible for locating and loading assemblies. We probably have APIs in .NET 5.0 that can achieve the same results.
@GrabYourPitchforks @steveharter is this something that falls in the System.Reflection area that you could help with?

Use NativeLibary.Load(string), passing in the full path ("c:\blahblah\mymodule.dll") to the DLL you wish to load. Do this before attempting to p/invoke into the DLL. Once the unmanaged DLL is loaded in-process, any future p/invokes decorated with [DllImport("mymodule.dll")] will bind to the already-loaded DLL.
To get the full path to fusion.dll, query the registry key listed at https://docs.microsoft.com/en-us/dotnet/framework/migration-guide/how-to-determine-which-versions-are-installed#detect-net-framework-45-and-later-versions.

I'm closing this issue because I believe the question has been answered. Please reopen the issue if further discussion is needed. Thanks!

Just a note that the following "hack" worked for me. That is, if .NET Core/5+ then use NativeLibrary.Load directly to load fusion.dll from fixed full paths in static constructor before calling P/Invoke as mentioned above. We need this to interact with third party library that can change version and is only available in GAC.
    public static class AssemblyResolving
    {
#if NET5_0_OR_GREATER
        static AssemblyResolving()
        {
            var fusionFullPath = Environment.Is64BitProcess
                ? @"C:\Windows\Microsoft.NET\Framework64\v4.0.30319\fusion.dll"
                : @"C:\Windows\Microsoft.NET\Framework\v4.0.30319\fusion.dll";
            NativeLibrary.Load(fusionFullPath);
        }
#endif

        /// <summary>
        /// Gets an assembly path from the GAC given a partial name.
        /// </summary>
        /// <param name="name">An assembly partial name. May not be null.</param>
        /// <returns>
        /// The assembly path if found; otherwise null;
        /// </returns>
        public static string GetAssemblyPath(string name)
        {
            if (name == null)
            { throw new ArgumentNullException(nameof(name)); }

            var hr = CreateAssemblyCache(out var assemblyCache, 0);
            if (hr >= 0)
            {
                var assemblyInfo = new AssemblyInfo();
                assemblyInfo.cchBuf = 1024; // should be fine...
                assemblyInfo.currentAssemblyPath = new string('\0', assemblyInfo.cchBuf);

                hr = assemblyCache.QueryAssemblyInfo(0, name, ref assemblyInfo);
                if (hr >= 0)
                {
                    return assemblyInfo.currentAssemblyPath;
                }
            }
            return null;
        }

        [ComImport, InterfaceType(ComInterfaceType.InterfaceIsIUnknown), Guid("e707dcde-d1cd-11d2-bab9-00c04f8eceae")]
        private interface IAssemblyCache
        {
            void Reserved0();

            [PreserveSig]
            int QueryAssemblyInfo(int flags, [MarshalAs(UnmanagedType.LPWStr)] string assemblyName, ref AssemblyInfo assemblyInfo);
        }

        [StructLayout(LayoutKind.Sequential)]
        private struct AssemblyInfo
        {
            public int cbAssemblyInfo;
            public int assemblyFlags;
            public long assemblySizeInKB;
            [MarshalAs(UnmanagedType.LPWStr)]
            public string currentAssemblyPath;
            public int cchBuf; // size of path buf.
        }

        // System.DllNotFoundException: Unable to load DLL 'fusion.dll' or one of its dependencies: The specified module could not be found. (0x8007007E)
        // https://github.com/dotnet/core/issues/3048
        [DllImport("fusion.dll")]
        private static extern int CreateAssemblyCache(out IAssemblyCache ppAsmCache, int reserved);
    }


globalVueStyles not working with Stylus

Looks like globalVueStyles is specific to a sass implementation. Anyone have a work around?
I'd be happy to submit a pull request in order to include stylus, but my client's requirement is global stylus variables in Vue components and I've got a bit of a short deadline.
https://github.com/JeffreyWay/laravel-mix/blob/adc09a87f7390deea2b9431057cfca0826b307d2/src/components/Vue.js#L60

For those interested, you must use webpack.LoaderOptionsPlugin.
mix.webpackConfig({
	plugins: [
		new webpack.LoaderOptionsPlugin({
			options: {
				stylus: {
					import: [resolve(__dirname, 'path/to/variables.styl')]
				}
			}
		})
	]
})


Option for explicit () return type

Something like:
explicit_unit_return_type = ["Never" | "Keep" | "Always"]

would result in reformatting:
// "Never" would turn
fn main() -> () {}
// into
fn main() {}

// "Always" would turn
fn main() {}
// into
fn main() -> () {}

the Keep option wouldn't affect the formatting of either, which is the current behavior

Thank you for sharing, but I'm going to close.
The presence of the unnecessary unit is flaggable via an existing clippy lint (unused_unit, and that means that one could remove such cases using rustfix.
As such I see no reason why we should extend rustfmt to provide that duplicative functionality, and I'd be opposed to enhancing rustfmt simply to support adding an unnecessary unit.


the change dialog-renderer: let click events bubble (6a03bbd) causes a click event not to be handled by the target

I'm submitting a bug report

Operating System:
linux 4.10.13-1-ARCH

Node Version:
v7.5.0

NPM Version:
3.8.9
4.1.2

JSPM OR Webpack AND Version
JSPM 0.16.32 | webpack 2.1.0-beta.17
webpack 2.4.1

Browser:
all | Chromium Version 58.0.3029.81 (64-bit)

Language:
all

Current behavior:
  <ux-dialog class="import-dlg">     <ux-dialog-body>      <md-file                    md-on-change.delegate="readFile($event)">>           </md-file>      ....
Expected/desired behavior:
after the change of ai-dialog -> ux-dialog (https://github.com/aurelia/dialog/commit/6a03bbd) if i click on the file input, all worked fine.
now the click event is not handled by the target.
tyhe same goes for example for a 1<md-radio> tag. i dont think its a aurelia-materialize-bridge issue, the same behaviour is if i use <input type="file"/> -- it does not open the dialog, (i suppose) because the event.preventDefault() is called on the event
P.S. also the examples in your repo, were not updated according to your changelog (https://github.com/aurelia/dialog/tree/master/doc/example -- still use ai-dialog instead of ux-dialog)

Duplicate of #281 - awaiting release.


[Feature] Support for 1.16.3 please

Hi,
latest Version for 1.16.2 crashes the game on 1.16.3

Soon:tm:

2.0.0 is out! And with it, 1.16.3 compatibility.


Annotate generated classes with @Generated

Describe the solution you'd like
Annotate generated classes with @Generated, like openapi-generator-maven-plugin does.

Duplicate of #56


immediately quit browser if failed to create it

/cc @sipayRT @SevInf

:+1:

Build fails because of lint in old code. Need to rebase from master when #306 will be merged.


Enter Pin and/or FaceID Served on All Cold Opens

Current behavior
In 1.26.0 Face ID / Pin entry is attempted on all app opens even if require pin on app open is disabled.
Desired behavior
Face ID / Enter pin should not served on cold app opens if not enabled by the user.
Steps to Reproduce

(Optional) Enable FaceID from settings.
Disable require pin on app open from settings.
Close and open the app.
Observe FaceID / Pin prompt

Versions
iOS v1.26.0
Notes

These should not be served on app opens as they provide the user with a false sense of security as opposed to the 'Require Pin on App Open Prompt'
These prompts be easily bypassed with 2 Failed Face ID's and tapping Pin Back. Screens such as the backup phrase or if 'Require Pin on App Open' is enabled cannot be bypassed this way.

Hey @MuckT , We have Verified this issue using Latest iOS Test flight Alfa jores Build V1.26.0 & observed that the above issue is not reproducible for us. When we Enable use face ID toggle & Disable require PIN for app open toggle and cold open the app no enter pin and/or face id is appearing and also on kill and relaunch the app face ID and/or enter pin is not appearing.
Also, when we Enable both use face ID & require pin for app open toggles and then we cold open valora app enter pi and/or face ID pop is not served, but when we kill and relaunch the app after that face ID popup appears
Devices: iPhone 13 mini (15.1.1), iPhone 12 (14.7.1)
Attachment:
Disable Require PIN toggle.mp4
Both Toggle Enabled.mp4
Thanks..!!


Refactor CloseAccountPage to functional component

Details

This refactors the CloseAccountPage into a functional component.
A few of the things in the existing component aren't necessary (ex: the lifecycle method) so I did not port those over.
Fixed Issues

$ https://github.com/Expensify/App/issues/16298
PROPOSAL: GH_LINK_ISSUE(COMMENT)
Tests

[x] Verify that no errors appear in the JS console

Logged in and closed an account and ensured it closed properly
Logged in and went to the close account page and added a message and submitted the form and ensured the message showed up in the logs:2023-05-22T21:18:48.854700+00:00 expensidev2004 php-fpm: gNqtRg /api.php<EMAIL_ADDRESS>!ecash1.3.16-7! ?api? [hmmm] Account closed with parting message ~~ email<EMAIL_ADDRESS>message: 'fffffasdf'

Offline tests

Logged in, forced offline mode, went to the close account page and ensured I wasn't able to submit since this functionality requires network access.

QA Steps

[x] Verify that no errors appear in the JS console

Log into an account you are able to close without major repercussions (ie: not an admin/owner of workspace)
Force offline mode and attempt to close the account, ensure you're not allowed to submit the form.
Go back online, attempt to close the account and ensure you're able to submit it properly
When you are redirected to the login/sign in page ensure the Green Dot Road message of Account closed successfully appears correctly:

PR Author Checklist

[x] I linked the correct issue in the ### Fixed Issues section above
[x] I wrote clear testing steps that cover the changes made in this PR

[x] I added steps for local testing in the Tests section
[x] I added steps for the expected offline behavior in the Offline steps section
[x] I added steps for Staging and/or Production testing in the QA steps section
[x] I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
[x] I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
[x] I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).

[x] I included screenshots or videos for tests on all platforms
[x] I ran the tests on all platforms & verified they passed on:

[x] Android / native
[x] Android / Chrome
[x] iOS / native
[x] iOS / Safari
[x] MacOS / Chrome / Safari
[x] MacOS / Desktop

[x] I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
[x] I followed proper code patterns (see Reviewing the code)

[x] I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
[x] I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
[x] I verified that comments were added to code that is not self explanatory
[x] I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
[x] I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method

[x] If any non-english text was added/modified, I verified the translation was requested/reviewed in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:

[x] I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
[x] I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
[x] I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
[x] I verified the JSDocs style guidelines (in STYLE.md) were followed

[x] If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
[x] I followed the guidelines as stated in the Review Guidelines
[x] I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
[x] I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
[x] I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
[x] I verified that if a function's arguments changed that all usages have also been updated correctly
[x] If a new component is created I verified that:

[x] A similar component doesn't exist in the codebase
[x] All props are defined accurately and each prop has a /** comment above it */
[x] The file is named correctly
[x] The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
[x] The only data being stored in the state is data necessary for rendering and nothing else
[x] For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
[x] Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
[x] All JSX used for rendering exists in the render method
[x] The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions

[x] If any new file was added I verified that:

[x] The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory

[x] If a new CSS style is added I verified that:

[x] A similar style doesn't already exist
[x] The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG))

[x] If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
[x] If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
[x] If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
[x] If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
[x] If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
[x] I have checked off every checkbox in the PR author checklist, including those that don't apply to this PR.

Screenshots/Videos

Web

Mobile Web - Chrome

Mobile Web - Safari

Desktop

iOS

Android

okay publishing this for review.
One thing that was curious to me locally which I would love for someone to confirm is whether or not you get the proper "account was successfully closed" message on the log in page after closing the account.
I could see in the onyx data the the data was present but I think pusher was failing for me locally and so the GBR wouldn't show up until I refreshed the page.

updated and reverted some of the broader changes and made this hopefully work more inline with how the class component was working.
testing I still don't see the GBR "account closed successfully" but still 🙏 that's due to some weird pusher thing locally.
I did figure out one way you could trigger an error is to submit an IOU from the account your trying to close and then pay it from the account you submitted to

ah I bet this wasn't throwing before because the default key was error: '' not errors: '', i'll update that too.

oh woohoo whatever was bork'd with pusher I think is fixed now too, got the GBR message after I closed the account locally

updated with most of the latest suggestions but didn't add the empty dependencies array to the end of the useEffect hook since my understanding is that it's unnecessary but if we decided to always add it for some reason let me know and I can add that too.

okay updated again, ready for review 🙏

😭 i'll fix the merge conflict tomorrow

oops sorry bondy looks like there is another conflict. Can you address and ping me on newDot so i can quickly review/merge it.

I could but then i won't be able to merge the PR since i pushed commits. Then we would have to find another internal engineer to review/merge it (or maybe you could merge it).
Either way, i hit up bondy about this last week and i believe he said the merge conflicts changes are a bit tricky so he would need some time for it. But with that said i would have expected it to be done by now. I see him online on slack everyday and according to his calendar he's working 50% this whole week except thursday. So @bondydaa, could you give us an ETA for this PR?
Let's wait till tomorrow to hear back from him. If we don't we'll plan something else.

I spoke to @bondydaa about this PR. He says his plate is pretty full and he won't be able to get to this PR this week. He says that there isn't much rush on this PR so he should be able to get to it next week.

okay believe i've fixed the merge conflict and pulled in changes from the various PRs. i tried to label each commit I pulled in manually as a separate commit to hopefully make it more clear and easier to follow instead of a single big "fix merge conflicts".
tested it and seems to still be working as expected so ready for another review now.

:hand: This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

🚀 Deployed to staging by https://github.com/chiragsalian in version: 1.3.35-0 🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
success ✅

🕸 web 🕸
success ✅

Yeah, none of them are holding the release. Moving forward 👍

🚀 Deployed to production by https://github.com/Julesssss in version: 1.3.35-5 🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
failure ❌

🕸 web 🕸
success ✅

🚀 Deployed to production by https://github.com/Julesssss in version: 1.3.35-5 🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
failure ❌

🕸 web 🕸
success ✅

Hey folks, we have a new report (https://github.com/Expensify/App/issues/21951) that a user can trigger the form in Offline Mode with the Enter key on their keyboard. Is that a regression from this issue?


Feature Suggestion: use a dotfile for configuration

As a terminal user, dotfiles are a big part of my workflow. I use .vimrc to customize vim, .bashrc to customize my shell – you get the picture. Dotfiles are great because I can throw them up on GitHub and keep all of my customizations up-to-date on all of my machines.
One thing that I've never been able to customize through dotfiles is my terminal. For each new computer I set up, I need to download and install a colorscheme file, set up how I want my windows and tabs to behave, etc.
I think it would be great to read configuration for Black Screen from a configuration file - something like .blackscreenrc, .config/blackscreen, or .blackscreen.json. Maybe we could even go the route that Phoenix took, and allow the user to write their own .js script that gets loaded at application boot.
I love the project, and I'm really looking forward to integrating it into my workflow. I'm sure this feature will be a big effort and require a bunch of discussion, so I'm really interested in hearing your thoughts on it.
Thanks for all your work!

:+1: Love this idea. I like doing the same thing of keeping my Dotfiles in a git repo.


⚠ Bofrost.be has degraded performance

In 765f2a8, Bofrost.be (https://www.bofrost.be) experienced degraded performance:

HTTP code: 200
Response time: 1448 ms

Resolved: Bofrost.be performance has improved in f462d87.