Clothing information - matching Important information with filter language. Other types of clothing info

We should match the words used to describe they type of clothing (the 'occasions' data field) with the terms you can search for on the filter page.
GoGetta uses the occasions Everyday and Job Interview
Apart from the ability to select from Everyday and Job Information, the form also provides a text field to describe any other type of occasion clothing may serve, e.g., School, or Wedding. It's plasuble to use this for "Infant" or "Baby"
(Example of GoGetta's clothing occasion field here.)
YourPeer uses the occasions Casual and Professional
When showing clothing ocassions on the detail pages of YourPeer make the following changes:

[ ] Everyday ––> Casual
[ ] Job Interview ––> Professional

@jbeard4 not done


Reject certain code that should return but doesn't

What was wrong?
As described in #497 the following code does compile in master but should generate a user error instead. It needs to error because the code is missing a return statement since it is not guaranteed that the execution follows the arm of the if statement.
contract Foo:
    pub def bar(val: u256) -> u256:
        if val > 1:
            return 5

How was it fixed?
The check in all_paths_return_or_revert is wrong because it counts a missing else branch as if the code returns when clearly a missing else branch shouldn't indicate such thing.

Codecov Report

Merging #502 (a8d7d53) into master (71a2430) will increase coverage by 0.00%.
The diff coverage is 100.00%.

:exclamation: Current head a8d7d53 differs from pull request most recent head 17e434f. Consider uploading reports for the commit 17e434f to get more accurate results

@@           Coverage Diff           @@
##           master     #502   +/-   ##
=======================================
  Coverage   87.72%   87.73%
=======================================
  Files          80       80
  Lines        5272     5274    +2
=======================================
+ Hits         4625     4627    +2
  Misses        647      647

Impacted Files
Coverage Δ

crates/analyzer/src/traversal/functions.rs
91.17% <100.00%> (ø)

crates/test-files/src/lib.rs
66.66% <100.00%> (+16.66%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 71a2430...17e434f. Read the comment docs.


fix: Add to doc information about firewall issues on RedHat

:tada: This PR is included in version 1.1.1-beta.1 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:

:tada: This PR is included in version 1.3.0-beta.1 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:

:tada: This PR is included in version 1.3.0 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


fix: typos in documentation files

Corrected "crated" to "created".

Closing due to suspected bot activity.


🎨 Add possibility in Tags in gatsby-helpers to return tags without separators

no issue
It was simply not possible to get tags without a separator. Either the default value (", ") was used or, if no separator was specified, an empty span tag was created.

Hey @Juuro 👋
Thank you very much for the PR. I don't think it makes sense to merge this one, as we want to have the ", " separator as a default value. See here and here. This mirrors the behaviour of our handlebars Tags helper, which you can read about here: https://docs.ghost.org/api/handlebars-themes/helpers/tags/#description
If you wanted to have no separator, you can simply pass separator="" as a prop. Or, if you'd wanted it separated with a whitespace separator=" ". This will work 😄

Hello @AileenCGN ,
thank you for your review. But I have objections.

If you wanted to have no separator, you can simply pass separator="" as a prop.

That is what I am doing right now. But if you have a look at the else path here you see that if props.separator is an empty string it will still return a <span> tag. That tag is empty and right now I use the separatorClasses prop to add a class to that <span> to be able to display: none it. But I think that is a bit ugly. Wouldn't it be much nicer if there exists a possibility to render nothing if someone really doesn't want a separator?

@Juuro Thanks a completely valid concern! We have two requirements here:

The default separator should always be ", " if nothing is passed as separator
Return an empty <span> is indeed ugly and when you pass separator="" to prevent falling back to the default one, it should simply not be returned.

Do you want to update your PR to reflect that? Happy to merge it 🤗

@AileenCGN Thank you for opening the PR again. I will have another look at it this week!

👋 Hey @Juuro, just checking in if you'll have some time to pick the PR in coming week(s) for the update, will be good to get this fix in before anyone else trips on it. 😄

Hi @rishabhgrg,
sorry for the delay. 😞 In the week after next week at the latest I will have some time to finally do that. Maybe even at the coming weekend. I definitely didn't forget about it. 🙂

Hey @rishabhgrg @AileenCGN, I think I'm done here and ready for review for now.

@Juuro thank you so much for this 🎉! Will try to make some time for this next week 👌🏼

@Juuro this works just fine!! Thank you so much, also for adding that many tests 🤗🙏🏼


Startup secrets keys created in lowercase

Bugs should be filed for issues encountered whilst operating bank-vaults.
You should first attempt to resolve your issues through the community support
channels, e.g. Slack, in order to rule out individual configuration errors.
Please provide as much detail as possible.

Describe the bug:
The latest version of bank-vaults creates startup secrets, but they appear in lowercase in Vault resulting in vault-env not finding them when applying our default resources we use for testing.
Expected behaviour:
Getting this:
vault kv get secret/accounts/aws
Handling connection for 8200
====== Secret Path ======
secret/data/accounts/aws

======= Metadata =======
Key                Value
---                -----
created_time       2023-06-28T09:21:21.574452303Z
custom_metadata    <nil>
deletion_time      n/a
destroyed          false
version            1

============ Data ============
Key                      Value
---                      -----
AWS_ACCESS_KEY_ID        secretId
AWS_SECRET_ACCESS_KEY    s3cr3t

instead of this:
vault kv get secret/accounts/aws
Handling connection for 8200
====== Secret Path ======
secret/data/accounts/aws

======= Metadata =======
Key                Value
---                -----
created_time       2023-06-28T08:48:28.447984417Z
custom_metadata    <nil>
deletion_time      n/a
destroyed          false
version            1

============ Data ============
Key                      Value
---                      -----
aws_access_key_id        secretId
aws_secret_access_key    s3cr3t

/kind bug

The issue was introduced by a viper version upgrade, turns out it was a bug that it allowed uppercase characters in the first place (see issue). Short term solution is to revert the upgrade.


Disabled flaky test test_operator.test_prelu

Description
Disabled flaky test test_operator.test_prelu. Tracked in #12885

Duplicate of #13060

@marcoabreu I had opened my PR 15 hours ago with the same change as #13060 can I know why mine was considered duplicate and the other wasn't?

Its a fair question. It could be an honest mistake and @marcoabreu probably missed this PR.


feature: close select dropdown after the change step

See https://crbug.com/1302492

@jrandolf PTAL. Do you think there could be some other approach to this?

@jrandolf PTAL. Do you think there could be some other approach to this?

From looking at other cases such as this, refocusing tends to fix these type of issues. WDYM by "other approach"? Do you want to fix the location of the drop down?


fs-bq-import-collection - ENOENT error with a non-root collection path

Describe your configuration

Extension name: firestore-bigquery-export
Extension version: 0.1.12
Configuration values (redact info where appropriate):

Cloud Functions location: us-central1
BigQuery Dataset location: us
Collection path: config/recurring/recur_act
Dataset ID: tick8s
Table ID: bqfs_tbl_recur_act

Describe the problem
Running the command @firebaseextensions/fs-bq-import-collection throws an error (see command and output below).  The exact parameters (see "configuration" section above) do work for the extension -- changing a doc in Firestore does have the record sync to BigQuery.  But running this command to import existing docs to BigQuery fails.  The exact same command works fine for a --source-collection-path whose collection is a top-level (a "root") path.
This fails:
npx @firebaseextensions/fs-bq-import-collection --non-interactive --project tick8s-test --source-collection-path 'config/recurring/recur_act' --query-collection-group false --dataset tick8s --table-name-prefix bqfs_tbl_xxx --dataset-location us --batch-size 300
{"severity":"WARNING","message":"Warning, FIREBASE_CONFIG and GCLOUD_PROJECT environment variables are missing. Initializing firebase-admin will fail"}
Importing data from Cloud Firestore Collection: config/recurring/recur_act, to BigQuery Dataset: tick8s, Table: bqfs_tbl_xxx_raw_changelog
{"severity":"INFO","message":"BigQuery dataset already exists: tick8s"}
{"severity":"INFO","message":"Creating BigQuery table: bqfs_tbl_xxx_raw_changelog"}
{"severity":"INFO","message":"Created BigQuery table: bqfs_tbl_xxx_raw_changelog"}
{"severity":"INFO","message":"Creating BigQuery view: bqfs_tbl_xxx_raw_latest\nQuery:\n-- Retrieves the latest document change events for all live documents.\n--   timestamp: The Firestore timestamp at which the event took place.\n--   operation: One of INSERT, UPDATE, DELETE, IMPORT.\n--   event_id: The id of the event that triggered the cloud function mirrored the event.\n--   data: A raw JSON payload of the current state of the document.\n--   document_id: The document id as defined in the Firestore database\nSELECT\n  document_name,\n  document_id,\n  timestamp,\n  event_id,\n  operation,\n  data\nFROM\n  (\n    SELECT\n      document_name,\n      document_id,\n      FIRST_VALUE(timestamp) OVER(\n        PARTITION BY document_name\n        ORDER BY\n          timestamp DESC\n      ) AS timestamp,\n      FIRST_VALUE(event_id) OVER(\n        PARTITION BY document_name\n        ORDER BY\n          timestamp DESC\n      ) AS event_id,\n      FIRST_VALUE(operation) OVER(\n        PARTITION BY document_name\n        ORDER BY\n          timestamp DESC\n      ) AS operation,\n      FIRST_VALUE(data) OVER(\n        PARTITION BY document_name\n        ORDER BY\n          timestamp DESC\n      ) AS data,\n      FIRST_VALUE(operation) OVER(\n        PARTITION BY document_name\n        ORDER BY\n          timestamp DESC\n      ) = \"DELETE\" AS is_deleted\n    FROM\n      `tick8s-test.tick8s.bqfs_tbl_xxx_raw_changelog`\n    ORDER BY\n      document_name,\n      timestamp DESC\n  )\nWHERE\n  NOT is_deleted\nGROUP BY\n  document_name,\n  document_id,\n  timestamp,\n  event_id,\n  operation,\n  data"}
{"severity":"INFO","message":"Created BigQuery view: bqfs_tbl_xxx_raw_latest"}
{"severity":"INFO","message":"Inserting 13 row(s) of data into BigQuery"}
{"severity":"INFO","message":"Inserted 13 row(s) of data into BigQuery"}
Error importing Collection to BigQuery: Error: ENOENT: no such file or directory, open '/Users/greg/.npm/_npx/55957/lib/node_modules/@firebaseextensions/fs-bq-import-collection/lib/from-config/recurring/recur_act-to-tick8s-test_tick8s_bqfs_tbl_xxx_raw_changelog'

Steps to reproduce:

Create a Firestore collection that is NOT at the root.  Any path such as a/b/c will do.
Install the firestore-bigquery-export extension to your project
Run the command as above using --source-collection-path "a/b/c"

The docs from a/b/c get imported as rows to BigQuery, but you get the "ENOENT" error as above.
Expected result
No errors.
Actual result
ENOENT error as per above.

Hi @gregfenton.
Thanks for this. I'll attempt to recreate from the data provided above to see if I can reproduce the issue.

Hi @gregfenton
It's my understand based on the following that you will need collectionGroup set to true to access documents not at the root.
--query-collection-group true

This ensures that a collectionGroup is selected as part of the query...
  if (queryCollectionGroup) {
    query = firebase.firestore().collectionGroup(sourceCollectionPath);
  } else {
    query = firebase.firestore().collection(sourceCollectionPath);
  }

Additionally you may need the required indexes setup for queries in order for the documents to be found https://firebase.googleblog.com/2019/06/understanding-collection-group-queries.html
Rules guide is also here
https://firebase.google.com/docs/firestore/security/rules-query#secure_and_query_documents_based_on_collection_groups

I do not believe the documentation discusses that the import only works for collections at the root?  If it does, it isn't clear.
I believe this is simply an issue with the script trying to create its cache file by using the sourceCollectionPath value thus failing because the SCP in this use case has / in it.  It looks like the actual import itself works (though I didn't try with a large volume of data, so maybe it would fail on the second "page" of values?).
This is not a collection-group-query situation, or at least IMO should not be considered as such.  I am grabbing a specific collection at a specific path, it just so happens that the path has a / in it.
I believe that the code "is close to correct", but needs a tweak around the cache file naming and clean-up.

Thanks @gregfenton.
You are correct, i've added a PR above.


Routing

Before you open an issue
If the issue is with an ASP.NET Core document:

Do not open a new issue using this form.
Open the issue with the This page button and form at the bottom of the document's page.

Using the This page button and form to open an issue:

Adds article metadata for tracking, which indicates the article that you're commenting on.
Automatically notifies the article's author about your issue.

^^^ I Don't know wtf you're talking about and there is not use this page button or whatever. Learn 2 doc.
Now to the issue.
https://github.com/dotnet/AspNetCore.Docs/blob/main/aspnetcore/fundamentals/routing.md?plain=1
Routing system is broken. Fix it or document it.
Even a midschooler could write a better routing system, but whatever.
Now, these routes apparently are ambigous:
[HttpGet]

[Route("retrieveInvoicesToPay")]

public async Task<IActionResult> RetrieveInvoicesToPayAsync(

CancellationToken cancellationToken = default

)

and
[HttpGet]

[Route("retrieveInvoicesToValidate")]

public async Task<IActionResult> RetrieveInvoicesToValidateAsync(

CancellationToken cancellationToken = default

)

Now, given that they have the same signature, they have different route attribute. This is totally infuriating.
Not only, I've added
[ActionName()] with the same name given to the Route attribute, so

[ActionName("retrieveInvoicesToPay")]

[ActionName("retrieveInvoicesToValidate")]

Still nothing. MVC sees them different.

I had to add a prefix to the route like pay/retrieveInvoicesToPay and it's totally ridiculous.

We're sorry that the template language wasn't updated. I'll take care of that right now.
What that text should say is to open this issue using the Open a documentation issue link/feedback form at the bottom of the article. Use of the form adds metadata to your GitHub issue that cross-links the topic and indicates the author. For some articles, it will even ping the author automatically for a faster response.
What I'll do here for your issue is get the metadata and manually place it into this issue. The doc author will respond after that. Stand-by .......


IE11: Object doesn't support this action

Details
In IE11 (and probably prior IE versions), if you have a time picker (noCalendar: true, enableTime: true), when you click one of the arrows, it gives the error: "Object doesn't support this action" at like 264 (var ev = new Event("increment", { "bubbles": true });).

Reproduction Link
https://jsfiddle.net/aj6k3f1v/12/
I tried to reproduce in jsfiddle, but it's broken even worse on there than it was on my site. Whenever the time picker is clicked, it immediately closes.
Your Environment

flatpickr version used: 2.4.4
Browser name and version: Internet Explorer 11 (works fine in most recent version of Chrome)
OS and version: Windows 10

If it helps: this happens in IE10 as well.

Why was this issue closed? The bug still exists.


Unbalanced load balancing

Bug Description
Hi,
We have 6 replicas of a service running behind istio in an EKS cluster. We are noticing that the APIs are getting routed to one of the 6 replicas a lot more than the other 5, like 70% of an API is landing on one of the replicas and the other 30% on the remaining 5. I do understand that the routing will not happen uniformly but the deviation we are seeing here is significant.
We did try and debug the routing as per the instructions provided in https://www.youtube.com/watch?v=FbYBO7Pi2d8 but could not find anything wrong.
Kindly let us know any further steps that we can take here and also any more info I can furnish that might be helpful.
Regards
Yasha C
Version
$ istioctl version
client version: 1.12.2
control plane version: 1.11.4
data plane version: 1.11.4 (60 proxies)

$ kubectl version --short
Client Version: v1.22.4
Server Version: v1.21.5-eks-bc4871b

$ helm version --short
v3.6.3+gd506314

Additional Information
In the following pic, we can see that one of the replicas got almost 10 times more request than the other:

Destination rule:
kind: DestinationRule
metadata:
  labels:
    argocd.argoproj.io/instance: a-service
  name: a-service
  namespace: ns
spec:
  host: a-service.ns.svc.cluster.local
  subsets:
    - labels:
        version: stable
      name: stable
  trafficPolicy:
    connectionPool:
      tcp:
        connectTimeout: 1000ms
        maxConnections: 400
        tcpKeepalive:
          interval: 75s
          time: 60m
    loadBalancer:
      simple: LEAST_CONN
    outlierDetection:
      baseEjectionTime: 5m
      consecutive5xxErrors: 0
      consecutiveGatewayErrors: 10
      interval: 30s

Looks like they are being distributed as per locality. Please refer to https://istio.io/latest/docs/reference/config/networking/destination-rule/#LocalityLoadBalancerSetting

Thanks @ramaraochavali. We are not using LocalityLoadBalancerSetting specifically and all our pods run on AWS us-west-2 region. Is there a chance that there are some default values that are getting used here?

Thanks, @ramaraochavali. I tried searching through the docs and this fact is not quite apparent. Can the document please be updated to explicitly mention that LocalityLoadBalancerSetting is enabled by default?


Doesn't work for older versions

Only downloads icons and audio for beta 1.7.3. Probably related to different assets structure (didn't look into the source code, not too familiar with Java).

Fixed, was only extracting assets that began with with assets/, but older JARs had assets in the root directory


Added support for full domain urls for cached images

I needed to add support for cookieless domain, static files domain. Now you have new attribute in config cache_url where you can add external url like http://static.example.com. If this is set then  that url is used. I think i am not the only one who needs it.

Can you add tests to show me that it works?

I like the overall idea. Thanks!

Changed the code more elegant. Im not really a test writer and i dont really know how. I can do it from scratch but not when you have errors in there when i run phpunit before i even have done something. Im using it in my project and it is working fine. Feel free to write test and show me how its done so i can maby learn something about it.

@icansurvive Please checkout the official documentation of phpunit. It is very easy.  I will tell you an interesting thing. The first time I ever used phpunit was in this module. Since that, there was no turning back.
You can just see the current tests to learn how to write tests.

Not sure how the tests does not run, the builds did not show any problem with tests.

@ojhaujjwal dunno i went console to tests dir and run command phpunit and i got PHP Fatal error:  Class 'Phine\Test\Property' not found etc.

Okay. Did test and and everything passed. No failures.I am not sure it is the right way. Let me know is it ok.


[DO NOT MERGE] Auto PR to update dependencies of istio

This PR will be merged automatically once checks are successful.

@istio-testing: The following test failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/e2e-suite-rbac-no_auth.sh
df220a7678a743115966c6eed52bfb3c0e94d19d
link
/test e2e-suite-rbac-no_auth

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@istio-testing: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/e2e-suite-rbac-no_auth.sh
df220a7678a743115966c6eed52bfb3c0e94d19d
link
/test e2e-suite-rbac-no_auth

prow/e2e-suite-rbac-auth.sh
df220a7678a743115966c6eed52bfb3c0e94d19d
link
/test e2e-suite-rbac-auth

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

Out of date, replaced by https://github.com/istio/istio/pull/731


A PyTorch-Based Framework for Deep Learning in Computer Vision

https://github.com/CVBox/PyTorchCV

Hi @youansheng
Sorry for late reply. I don't want to add pytorch-based frameworks.
Please find other repo for pytorch ecosystem.
Thank. :)


Support fractional mirroring

Closes: https://github.com/istio/istio/issues/14437
Depends on: https://github.com/istio/api/pull/1079

@jwendell: The following test failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

racetest_istio
fe53cd30ea34a65a590ac913a02e49bebb2379cf
link
/test racetest_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@jwendell: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

integ-mixer-k8s-tests_istio
eb2a14471b2050a8b0eb4d5015c721ed19e6667c
link
/test integ-mixer-k8s-tests_istio

integ-new-install-k8s-tests_istio
35090397ac5f39c8c1eb748221979356d895db9a
link
/test integ-new-install-k8s-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@jwendell: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

integ-new-install-k8s-tests_istio
35090397ac5f39c8c1eb748221979356d895db9a
link
/test integ-new-install-k8s-tests_istio

integ-mixer-k8s-tests_istio
35090397ac5f39c8c1eb748221979356d895db9a
link
/test integ-mixer-k8s-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@jwendell: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

integ-new-install-k8s-tests_istio
35090397ac5f39c8c1eb748221979356d895db9a
link
/test integ-new-install-k8s-tests_istio

integ-mixer-k8s-tests_istio
35090397ac5f39c8c1eb748221979356d895db9a
link
/test integ-mixer-k8s-tests_istio

e2e-dashboard_istio
f2268dadd2c34440d7c20edb9f3b5710ec2cc2b9
link
/test e2e-dashboard_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@jwendell: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

integ-mixer-k8s-tests_istio
35090397ac5f39c8c1eb748221979356d895db9a
link
/test integ-mixer-k8s-tests_istio

e2e-dashboard_istio
f2268dadd2c34440d7c20edb9f3b5710ec2cc2b9
link
/test e2e-dashboard_istio

integ-new-install-k8s-tests_istio
f2268dadd2c34440d7c20edb9f3b5710ec2cc2b9
link
/test integ-new-install-k8s-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@jwendell: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

e2e-dashboard_istio
f2268dadd2c34440d7c20edb9f3b5710ec2cc2b9
link
/test e2e-dashboard_istio

integ-new-install-k8s-tests_istio
f2268dadd2c34440d7c20edb9f3b5710ec2cc2b9
link
/test integ-new-install-k8s-tests_istio

integ-mixer-k8s-tests_istio
f2268dadd2c34440d7c20edb9f3b5710ec2cc2b9
link
/test integ-mixer-k8s-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@jwendell: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

integ-new-install-k8s-tests_istio
f2268dadd2c34440d7c20edb9f3b5710ec2cc2b9
link
/test integ-new-install-k8s-tests_istio

integ-mixer-k8s-tests_istio
f2268dadd2c34440d7c20edb9f3b5710ec2cc2b9
link
/test integ-mixer-k8s-tests_istio

codecov_istio
af21123b6d66fdc8c6f2d130761e7c2ebdce2c26
link
/test codecov_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@jwendell: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

integ-mixer-k8s-tests_istio
f2268dadd2c34440d7c20edb9f3b5710ec2cc2b9
link
/test integ-mixer-k8s-tests_istio

codecov_istio
af21123b6d66fdc8c6f2d130761e7c2ebdce2c26
link
/test codecov_istio

integ-new-install-k8s-tests_istio
af21123b6d66fdc8c6f2d130761e7c2ebdce2c26
link
/test integ-new-install-k8s-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@jwendell: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

codecov_istio
af21123b6d66fdc8c6f2d130761e7c2ebdce2c26
link
/test codecov_istio

integ-new-install-k8s-tests_istio
af21123b6d66fdc8c6f2d130761e7c2ebdce2c26
link
/test integ-new-install-k8s-tests_istio

integ-security-k8s-tests_istio
af21123b6d66fdc8c6f2d130761e7c2ebdce2c26
link
/test integ-security-k8s-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

Please use the integration test framework tests/integration and do not time.Sleep during tests.

@howardjohn What do you mean? I just changed a test that already exists by adding new capabilities due to this new feature being added.
That sleep call I think is necessary to give some time for the changes applied via yaml (creation of a virtual service) to be propagated to the sidecars...

the e2e tests are legacy at this point and we are trying to transition everything to the integration test which allow running locally as well as on kube, and have some more help functions to make it so we don't have to sleep for config to propagate. 100% of the time you do a sleep in a test it will flake eventually

Please use the integration test framework tests/integration and do not time.Sleep during tests.

@howardjohn done :)

@jwendell: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

codecov_istio
af21123b6d66fdc8c6f2d130761e7c2ebdce2c26
link
/test codecov_istio

integ-new-install-k8s-tests_istio
af21123b6d66fdc8c6f2d130761e7c2ebdce2c26
link
/test integ-new-install-k8s-tests_istio

integ-security-k8s-tests_istio
af21123b6d66fdc8c6f2d130761e7c2ebdce2c26
link
/test integ-security-k8s-tests_istio

lintmodern_istio
b3708855c77ab10727e479452577afed4bd7642b
link
/test lintmodern

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@jwendell: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

codecov_istio
af21123b6d66fdc8c6f2d130761e7c2ebdce2c26
link
/test codecov_istio

integ-new-install-k8s-tests_istio
af21123b6d66fdc8c6f2d130761e7c2ebdce2c26
link
/test integ-new-install-k8s-tests_istio

integ-security-k8s-tests_istio
af21123b6d66fdc8c6f2d130761e7c2ebdce2c26
link
/test integ-security-k8s-tests_istio

lintmodern_istio
b3708855c77ab10727e479452577afed4bd7642b
link
/test lintmodern

lint_istio
b3708855c77ab10727e479452577afed4bd7642b
link
/test lint

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@jwendell: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

integ-security-k8s-tests_istio
af21123b6d66fdc8c6f2d130761e7c2ebdce2c26
link
/test integ-security-k8s-tests_istio

lintmodern_istio
b3708855c77ab10727e479452577afed4bd7642b
link
/test lintmodern

lint_istio
b3708855c77ab10727e479452577afed4bd7642b
link
/test lint

integ-new-install-k8s-tests_istio
b3708855c77ab10727e479452577afed4bd7642b
link
/test integ-new-install-k8s-tests

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@jwendell: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

integ-security-k8s-tests_istio
af21123b6d66fdc8c6f2d130761e7c2ebdce2c26
link
/test integ-security-k8s-tests_istio

lintmodern_istio
b3708855c77ab10727e479452577afed4bd7642b
link
/test lintmodern

lint_istio
b3708855c77ab10727e479452577afed4bd7642b
link
/test lint

integ-new-install-k8s-tests_istio
b3708855c77ab10727e479452577afed4bd7642b
link
/test integ-new-install-k8s-tests

integ-mixer-k8s-tests_istio
b3708855c77ab10727e479452577afed4bd7642b
link
/test integ-mixer-k8s-tests

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@jwendell: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

lintmodern_istio
b3708855c77ab10727e479452577afed4bd7642b
link
/test lintmodern

lint_istio
b3708855c77ab10727e479452577afed4bd7642b
link
/test lint

integ-new-install-k8s-tests_istio
b3708855c77ab10727e479452577afed4bd7642b
link
/test integ-new-install-k8s-tests

integ-mixer-k8s-tests_istio
b3708855c77ab10727e479452577afed4bd7642b
link
/test integ-mixer-k8s-tests

e2e-bookInfoTests-trustdomain_istio
3905422bc17ff6f659a3936613d978c59f116ec3
link
/test e2e-bookInfoTests-trustdomain

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@jwendell: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

integ-mixer-k8s-tests_istio
b3708855c77ab10727e479452577afed4bd7642b
link
/test integ-mixer-k8s-tests

e2e-bookInfoTests-trustdomain_istio
3905422bc17ff6f659a3936613d978c59f116ec3
link
/test e2e-bookInfoTests-trustdomain

integ-new-install-k8s-tests_istio
3905422bc17ff6f659a3936613d978c59f116ec3
link
/test integ-new-install-k8s-tests

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@jwendell: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

e2e-bookInfoTests-trustdomain_istio
3905422bc17ff6f659a3936613d978c59f116ec3
link
/test e2e-bookInfoTests-trustdomain

integ-new-install-k8s-tests_istio
3905422bc17ff6f659a3936613d978c59f116ec3
link
/test integ-new-install-k8s-tests

integ-mixer-k8s-tests_istio
3905422bc17ff6f659a3936613d978c59f116ec3
link
/test integ-mixer-k8s-tests

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

The integ-new-install-k8s-tests_istio test is failing because it's not deploying istio from this PR, but it's using istio from master:
https://github.com/istio/istio/blob/20a04fedd22ec6228965188eb5909f610996bf04/tests/integration/tests.mk#L67-L68
@howardjohn What should we do in this case?

Yeah the new installer test is broken in that regard - that is exactly why
it's not required. We can just merge and make sure it passes tomorrow. The
test is just a stop gap solution until we have tests installing using the
operator
On Wed, Sep 18, 2019, 7:46 AM Jonh Wendell<EMAIL_ADDRESS>wrote:

The integ-new-install-k8s-tests_istio test is failing because it's not
deploying istio from this PR, but it's using istio from master:
https://github.com/istio/istio/blob/20a04fedd22ec6228965188eb5909f610996bf04/tests/integration/tests.mk#L67-L68
@howardjohn https://github.com/howardjohn What should we do in this
case?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/istio/istio/pull/16939?email_source=notifications&email_token=AAEYGXPCKBEANUASHTKEQV3QKI5NXA5CNFSM4IU57EL2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD7AKGRQ#issuecomment-532718406,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAEYGXI6PEI35Q6PMZH6PBLQKI5NXANCNFSM4IU57ELQ
.

/retest

@jwendell: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

integ-mixer-k8s-tests_istio
3905422bc17ff6f659a3936613d978c59f116ec3
link
/test integ-mixer-k8s-tests

integ-new-install-k8s-tests_istio
3905422bc17ff6f659a3936613d978c59f116ec3
link
/test integ-new-install-k8s-tests

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.


kali

Expected behavior
Actual behavior
Information about the Issue
Steps to reproduce the behavior

...
...

the_1

No information provided or steps to replicate - Closing


refactoring to allow module flexibility on naming resources

Description
features:

exposed var.force_delete to allow consumers to change default value
exposed var.key_protect_plan to allow consumers to change default value
removed var.prefix and made var.key_protect_instance_name mandatory if var.create_key_protect_instance is true (This mandates a major version bump)

examples / tests:

moved the existing resources test into pr_test.go and deleted other_test.go
cleanup

documentation:

cleanup of readme + variable descriptions

Check the relevant boxes:

[x] Bug fix (nonbreaking change that fixes an issue)
[x] New feature (nonbreaking change that adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[ ] Examples or tests (addition or updates of examples or tests)
[ ] Documentation update
[ ] CI related update (pipeline, etc.)

Checklist

[ ] If relevant, a test for the change has been added or updated as part of this PR.
[ ] If relevant, documentation for the change has been added or updated as part of this PR.

Merge

Merge using "Squash and merge".
Make sure to use a relevant conventional commit message that is based on the PR contents. The commit message determines whether a new version of the modules needs to be released, and if so, which semver number to use).

:tada: This PR is included in version 3.0.0 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


restructure codebase

This is a big PR that essentially makes the codebase more organized an nice. It's cleared what happens in 'core side' and 'view side', what is the app code, what is the build and what is dist.
Also fixes some things that were not handled correctly + removes dead code.
I believe that there might be some space to improve the structure of each react component (privilege reusability), but I would prefer to tackle that as the rest of the features get developed and bugs fixed, using this as the code structure from now on, therefore, PR'ing :)

LGTM!  :+1:

Muuuuuuuch nicer

woooot ! :D \o/ Thank you :)


Tinted Theming github organization

Hi @mnussbaum, Tinted Theming (previously base16-project) is a maintained and community run version of base16: https://github.com/tinted-theming/home/issues/51
A discussion around creating a base16 organization originally took place in 2016 on an issue in the original base16 repo: https://web.archive.org/web/20220603173440/https://github.com/chriskempson/base16/issues/74. The repo was subsequently nuked and most git history as well as PRs and issues were destroyed (which is why I linked the web archive version of the issue).
I was wondering if you would be interested in joining the Tinted Theming org and continuing to maintain base16-waybar under that umbrella? It would also be good to get your repo hooked up, like the rest of our repos, to a weekly template builder bot using the latest the latest schemes in the schemes repo.
If you're interested let me know and I can send an org invite.

I am using waybar and this this styles worked great for me. Would be great to have it regenerated, since in the last 6 years, many new themes. Would it help if I would do it an create a PR?

We could fork the PR under Tinted Theming so we could have some control over the repo since it seems like the maintainer isn't interested in joining Tinted Theming. @laenzlinger if we did that, would you be interested in being the maintainer of the tinted-theming/base16-waybar repo?

@JamyGolden Yes I would be willing to maintain it. I am interested, because I am using it already.


changed flux-system to app1

Around line 167, In step 1 of moving a file from ks app1  to ks app2 it appears flux-system was accidentally used instead of app1?

I don't think this is an error.
The app1 and app2 Kustomization resources are both defined in the flux-system namespace, so that is the one that needs to be reconciled in order to be sure that the definition is made fresh from the source.


Question regarding saving models [keras-cv]

Hello,
I have been looking for information but I still am unclear about how to save and load the models obtained through the
object detection guide . I am running my experiment using colab.
I would like to deploy the model on other computers, or even to load it on my own, but i run into custom object issues while trying to load  models with the prediction layer as it appears to not be defined:
ValueError: Unknown layer: 'PredictionHead'. Please ensure you are using a keras.utils.custom_object_scope and that this object is included in the scope. See https://www.tensorflow.org/guide/keras/save_and_serialize#registering_the_custom_object for details.
Furthermore, I have tried saving used the SavedModel format as it appears to be able to load custom layers  but i guess they are not compatible as they give the following error when running the load model function:

new_model = tf.keras.models.load_model(model_path)

ValueError: RetinaNet does not accept a loss to compile(). Instead, please pass box_loss and classification_loss. loss will be ignored during training.
I am guessing I would need to load the custom object, but as I have not defined the layer, I am feeling quite confused about how to proceed.
Would really appreciate some advice,
Thank you.

Hi @dwmar, thanks for raising this issue! Do you mind providing a colab repro of your issue? I've tested saving and loading with the object detection guide and the models seem to work on my end.

Hello @nkovela1!
Thanks for reaching out, I will provide a minimal reproduction of the issue, although the error output does not match, I am still unable to save the model and load them.
https://colab.research.google.com/drive/1WkB0GYU7vlnLrOnqk90gOWNlDR88aeil?usp=sharing

@dwmar I would like to help you with this issue, I am working on it, Thank you!!


sendMessage is not working

Hi, sendMessage is not working, return sendMessage is not a function

Use:
driver.chat_send_message(chat_id, text)

or
dest =<EMAIL_ADDRESS>send = driver.send_message_to_id(dest,text)


Trying to apply transform to WriteBatcher throws server-side exception

 ServerTransform serverTransform = new ServerTransform(transform);

        WriteBatcher whb = dataMovementManager.newWriteBatcher()
                .withBatchSize(100)
                .withThreadCount(20)
                .withTransform(serverTransform)
                .onBatchSuccess((batch) -> {
                    logger.debug("batch # {}, so far: {}", batch.getJobBatchNumber(), batch.getJobWritesSoFar());
                })
                .onBatchFailure((batch,throwable) -> throwable.printStackTrace() );

My transform successfully deployed and tested independently over REST API call.
Also, applying the same transform to XmlDocumentManager.write(...) works flawlessly.
Exception thrown:
com.marklogic.client.FailedRequestException: Local message: failed to apply resource at documents: Internal Server Error. Server Message: XDMP-AS: (err:XPTY0004) $input-type as xs:string -- Invalid coercion: () as xs:string . See the MarkLogic server error log for further detail.
	at com.marklogic.client.impl.JerseyServices.checkStatus(JerseyServices.java:4257)
	at com.marklogic.client.impl.JerseyServices.postResource(JerseyServices.java:3269)
	at com.marklogic.client.impl.JerseyServices.postBulkDocuments(JerseyServices.java:3357)
	at com.marklogic.client.impl.DocumentManagerImpl.write(DocumentManagerImpl.java:618)
	at com.marklogic.client.impl.GenericDocumentImpl.write(GenericDocumentImpl.java:23)
	at com.marklogic.client.impl.DocumentManagerImpl.write(DocumentManagerImpl.java:611)
	at com.marklogic.client.impl.GenericDocumentImpl.write(GenericDocumentImpl.java:23)
	at com.marklogic.client.datamovement.impl.WriteBatcherImpl$BatchWriter.run(WriteBatcherImpl.java:962)
	at java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:511)
	at java.util.concurrent.FutureTask.run(FutureTask.java:266)
	at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1142)
	at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:617)
	at java.lang.Thread.run(Thread.java:745)

Welcome, Sasha, to the project!  Nice work adapting your code to the latest despite the changes since EA3.  I'm taking a look now that I have your transform, and I'll get back to you shortly.

@sashamitrovich can you please provide the exact version of MarkLogic (xdmp.version()) and the Java Client (git rev-parse HEAD)?

I've verified it on java client api e6e20d7997a158fe17ef8509be7b0436853864ad and server 9.0-20161130

Thanks, @sammefford.

Looks like the error is not in DMSDK, but in bulk write.  I can get the same error with this code using bulk write:

I'm assigning this to Alex to troubleshoot from the REST layer.
Alex, here's the relevant wire trace showing the single document write (PUT), which works, then the bulk write (POST) which gives the error:
[DEBUG] wire - >> "PUT /v1/documents?transform=myTransform&category=content&uri=test1.txt HTTP/1.1[\r][\n]"
[DEBUG] wire - >> "Content-Type: */*[\r][\n]"
[DEBUG] wire - >> "Authorization: Digest username="admin",realm="public",nonce="11a9c7e9984dfdafb9f257ee12f6e750",opaque="41358e97bbdf2bc6",qop=auth,uri="/v1/documents",cnonce="7b92c484",nc=00000002,response="d3078ebb07d296131c6e35ad195a0cd1"[\r][\n]"
[DEBUG] wire - >> "Transfer-Encoding: chunked[\r][\n]"
[DEBUG] wire - >> "Host: <IP_ADDRESS>:8000[\r][\n]"
[DEBUG] wire - >> "Connection: Keep-Alive[\r][\n]"
[DEBUG] wire - >> "[\r][\n]"
[DEBUG] wire - >> "4[\r][\n]"
[DEBUG] wire - >> "test"
[DEBUG] wire - >> "[\r][\n]"
[DEBUG] wire - >> "0[\r][\n]"
[DEBUG] wire - >> "[\r][\n]"
[DEBUG] wire - << "HTTP/1.1 204 Content Updated[\r][\n]"
[DEBUG] wire - << "Server: MarkLogic[\r][\n]"
[DEBUG] wire - << "Content-Length: 0[\r][\n]"
[DEBUG] wire - << "Connection: Keep-Alive[\r][\n]"
[DEBUG] wire - << "Keep-Alive: timeout=5[\r][\n]"
[DEBUG] wire - << "[\r][\n]"
09:11:16.596 [main] DEBUG c.m.client.impl.JerseyServices - Posting documents
09:11:16.603 [main] DEBUG c.m.client.impl.JerseyServices - Sending multipart for /v1/documents
[DEBUG] wire - >> "POST /v1/documents?transform=myTransform HTTP/1.1[\r][\n]"
[DEBUG] wire - >> "Content-Type: multipart/mixed; boundary=Boundary_1_459848100_1480608676603[\r][\n]"
[DEBUG] wire - >> "Authorization: Digest username="admin",realm="public",nonce="11a9c7e9984dfdafb9f257ee12f6e750",opaque="41358e97bbdf2bc6",qop=auth,uri="/v1/documents",cnonce="47e7dd30",nc=00000003,response="920214266ef749c4da3744cb4ab78839"[\r][\n]"
[DEBUG] wire - >> "Transfer-Encoding: chunked[\r][\n]"
[DEBUG] wire - >> "Host: <IP_ADDRESS>:8000[\r][\n]"
[DEBUG] wire - >> "Connection: Keep-Alive[\r][\n]"
[DEBUG] wire - >> "[\r][\n]"
[DEBUG] wire - >> "72[\r][\n]"
[DEBUG] wire - >> "--Boundary_1_459848100_1480608676603[\r][\n]"
[DEBUG] wire - >> "Content-Disposition: attachment; filename="test2.txt"[\r][\n]"
[DEBUG] wire - >> "Content-Type: */*[\r][\n]"
[DEBUG] wire - >> "[\r][\n]"
[DEBUG] wire - >> "[\r][\n]"
[DEBUG] wire - >> "2e[\r][\n]"
[DEBUG] wire - >> "test[\r][\n]"
[DEBUG] wire - >> "--Boundary_1_459848100_1480608676603--[\r][\n]"
[DEBUG] wire - >> "[\r][\n]"
[DEBUG] wire - >> "0[\r][\n]"
[DEBUG] wire - >> "[\r][\n]"
[DEBUG] wire - << "HTTP/1.1 500 Internal Server Error[\r][\n]"
[DEBUG] wire - << "Content-type: application/json; charset=UTF-8[\r][\n]"
[DEBUG] wire - << "Server: MarkLogic[\r][\n]"
[DEBUG] wire - << "Content-Length: 258[\r][\n]"
[DEBUG] wire - << "Connection: Keep-Alive[\r][\n]"
[DEBUG] wire - << "Keep-Alive: timeout=5[\r][\n]"
[DEBUG] wire - << "[\r][\n]"
[DEBUG] wire - << "{"errorResponse":{"statusCode":500, "status":"Internal Server Error", "messageCode":"INTERNAL ERROR", "message":"XDMP-AS: (err:XPTY0004) $input-type as xs:string -- Invalid coercion: () as xs:string . See the MarkLogic server error log for further detail."}}"

@sammefford, any idea why this didn’t show up earlier? Is this a gap in the existing tests?

I'm looking into it.  But this appears to be doing the same thing but successfully.

The plot thickens…

Looks to me like the issue is only when Content-Type: /.  It works fine when I change my writeSet.add line to this (where I specify the format is text).  It also works fine if the format is set to XML (of course, that's what the TestBulkWriteWithTransformations.testBulkLoadWithXQueryTransform test does).
writeSet.add("test2.txt", new StringHandle("test").withFormat(Format.TEXT));

Then the wire trace looks like this:
[DEBUG] wire - >> "POST /v1/documents?transform=myTransform&trans:value=English&trans:name=Lang HTTP/1.1[\r][\n]"
[DEBUG] wire - >> "Content-Type: multipart/mixed; boundary=Boundary_1_459848100_1480610416451[\r][\n]"
[DEBUG] wire - >> "Authorization: Digest username="admin",realm="public",nonce="6610a669859d7332add14b44e8e3c3ed",opaque="9940f403a18b76a6",qop=auth,uri="/v1/documents",cnonce="0294f046",nc=00000003,response="f47f156c98dfb68becf2a4d59bf8a203"[\r][\n]"
[DEBUG] wire - >> "Transfer-Encoding: chunked[\r][\n]"
[DEBUG] wire - >> "Host: <IP_ADDRESS>:8000[\r][\n]"
[DEBUG] wire - >> "Connection: Keep-Alive[\r][\n]"
[DEBUG] wire - >> "[\r][\n]"
[DEBUG] wire - >> "79[\r][\n]"
[DEBUG] wire - >> "--Boundary_1_459848100_1480610416451[\r][\n]"
[DEBUG] wire - >> "Content-Disposition: attachment; filename="test2.txt"[\r][\n]"
[DEBUG] wire - >> "Content-Type: text/plain[\r][\n]"
[DEBUG] wire - >> "[\r][\n]"
[DEBUG] wire - >> "[\r][\n]"
[DEBUG] wire - >> "2e[\r][\n]"
[DEBUG] wire - >> "test[\r][\n]"
[DEBUG] wire - >> "--Boundary_1_459848100_1480610416451--[\r][\n]"
[DEBUG] wire - >> "[\r][\n]"
[DEBUG] wire - >> "0[\r][\n]"
[DEBUG] wire - >> "[\r][\n]"
[DEBUG] wire - << "HTTP/1.1 200 Bulk Change Written[\r][\n]"
[DEBUG] wire - << "vnd.marklogic.document-format: xml[\r][\n]"
[DEBUG] wire - << "Content-type: application/xml; charset=utf-8[\r][\n]"
[DEBUG] wire - << "Server: MarkLogic[\r][\n]"
[DEBUG] wire - << "Content-Length: 258[\r][\n]"
[DEBUG] wire - << "Connection: Keep-Alive[\r][\n]"
[DEBUG] wire - << "Keep-Alive: timeout=5[\r][\n]"
[DEBUG] wire - << "[\r][\n]"
[DEBUG] wire - << "<rapi:documents xmlns:rapi="http://marklogic.com/rest-api"><rapi:document><rapi:uri>test2.txt</rapi:uri><rapi:category>metadata</rapi:category><rapi:category>content</rapi:category><rapi:mime-type>text/plain</rapi:mime-type></rapi:document></rapi:documents>[\n]"

@sashamitrovich can you confirm that you're attempting to call whb.add or whb.addAs with content that doesn't have a clear format?  Ideally, could you share your code that calls whb.add or whb.addAs?

My code:
 FileInputStream docStream = new FileInputStream(uri);
        InputStreamHandle handle = new InputStreamHandle(docStream);

        DocumentMetadataHandle meta = new DocumentMetadataHandle();
        meta.withCollections("importWithTransform");

        whb.add (uri, meta, handle);

The input file:
<?xml version="1.0" encoding="UTF-8"?>
<Placemark>
	<name>Zum Adler</name>
	<Point>
		<coordinates>8.6492332,50.1440883</coordinates>
	</Point>
	<ExtendedData>
		<Data name="@id">
			<value>node/32419990</value>
		</Data>
		<Data name="amenity">
			<value>restaurant</value>
		</Data>
		<Data name="cuisine">
			<value>german</value>
		</Data>
		<Data name="microbrewery">
			<value>yes</value>
		</Data>
		<Data name="name">
			<value>Zum Adler</value>
		</Data>
		<Data name="website">
			<value>http://www.zumadler.net/</value>
		</Data>
		<Data name="wheelchair">
			<value>limited</value>
		</Data>
	</ExtendedData>
</Placemark>

And my transform code:
xquery version "1.0-ml";
module namespace dmsdk =
"http://marklogic.com/rest-api/transform/myTransform";

declare function dmsdk:transform(
        $context as map:map,
        $params as map:map,
        $content as document-node())
as document-node()
{
    let $log:=xdmp:log($content)
    let $doc := $content
    let $coordinates:=fn:tokenize($doc/Point/coordinates,",")
    let $newContent:=

            element Poi {
                element type {$doc//Data[@name = "amenity"]/value/text()},
                element coordinate {
                    element lat {$coordinates[2]},
                    element long {$coordinates[1]}
                },
                element name {$doc//Data[@name = "name"]/value/text()},
                element address {
                    element street {$doc//Data[@name = "addr:street"]/value/text()},
                    element housenumber {$doc//Data[@name = "addr:housenumber"]/value/text()},
                    element postcode {$doc//Data[@name = "addr:postcode"]/value/text()},
                    element city {$doc//Data[@name = "addr:city"]/value/text()}
                },
                element website {$doc//Data[@name = "website"]/value/text()},
                element phone {$doc//Data[@name = "phone"]/value/text()},
                element cuisine {$doc//Data[@name = "cuisine"]/value/text()},
                element microbrewery {$doc//Data[@name = "microbrewery"]/value/text()},
                element wheelchair {$doc//Data[@name = "wheelchair"]/value/text()},
                element wheelchair-description {$doc//Data[@name = "wheelchair:description"]/value/text()}
            }

    let $log:=xdmp:log($newContent)
    return document { $newContent }

};

I can confirm that adding
handle.withFormat(Format.XML);

to my code fixes the issue. I'll leave you to decide whether this is a bug or should just be slightly better documented. Thanks!

@sashamitrovich can you tell us what is the value of "uri"?
I'm thinking this is a bug because if we need you to set the format, we should tell you that, not give a cryptic error.

private static String uri = "src/test/resources/w1aab7b1.xml";

I want to confirm similar behaviour for JSON content. If
handle.withFormat(Format.JSON)

not specified, the document doesn't get persisted into the db AND no error message is thrown server-side.

I can now reproduce this with:
xquery version "1.0-ml";
xdmp:http-post(
   "http://localhost:8000/v1/documents?transform=simple",
   <options xmlns="xdmp:http">
      <authentication method="digest">
         <username>admin</username>
         <password>admin</password>
      </authentication>
      <headers>
         <content-type>multipart/mixed; boundary=xyzzy</content-type>
      </headers>
   </options>,
   xdmp:multipart-encode(
   "xyzzy",
   <manifest>
   <part>
   <headers>
   <Content-Type>*/*</Content-Type>
   <Content-Disposition>attachment; filename="test.txt"</Content-Disposition>
   </headers>
   </part>
   </manifest>,
   document { "test"}
   )
)

The content type isn't being guessed even though the filename parameter has been set.  The failure comes from Modules/rest-api/models/document-model-update.xqy#3457 as the call to eput:make-context() expects a content type at the value is ().
The content type should always be guessed from the filename in the Content-Disposition header.

I believe this was fixed on March 1st under server bug 43944.
Ajit, if you're not the right person to test this issue, please reassign.

Bug 43944 has been shipped. All tests with transforms run fine. However, as for the file extension issue, I have another Bug Track issue filed (44971).


PHP 7.3+

Hi,
I see this project hasnt been updated for a few years.  We are wanting to upgrade our site that uses this library to PHP 7.3 and later versions down the track.  Will it be compatible?
Cheers
Greg J

Sadly, composer.json does not specify this constraint directly. BTW I'm using this in a project of mine that's on PHP 7.3.<can't remember> and I didn't faced any issue yet.
TBH, as this lib seems to be completely inactive, I'm planning to make a new one that leverage microsoft official SDK (the library itself would be bridge for OAuth2.0 client library).

In case you haven't seen it, it's worth noting that Jan Hajek has written a Provider for MSFT AAD. It currently defaults to the V1 authorization and  token endpoints but has support for V2.  See https://github.com/TheNetworg/oauth2-azure

@decomplexity didn't noticed it, however there's some work to do on https://github.com/thephpleague/oauth2-client in order to make it works with V2 (I'll provide a PR later)


refactor: minor refactor on create/alter source

I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.
What's changed and what's your intention?

Checklist

[ ] I have written necessary rustdoc comments
[ ] I have added necessary unit tests and integration tests
[ ] I have added test labels as necessary. See details.
[ ] I have added fuzzing tests or opened an issue to track them. (Optional, recommended for new SQL features #7934).
[ ] My PR contains breaking changes. (If it deprecates some features, please create a tracking issue to remove them in the future).
[ ] All checks passed in ./risedev check (or alias, ./risedev c)
[ ] My PR changes performance-critical code. (Please run macro/micro-benchmarks and show the results.)

[ ] My PR contains critical fixes that are necessary to be merged into the latest release. (Please check out the details)

Documentation

[ ] My PR needs documentation updates. (Please use the Release note section below to summarize the impact on users)

Release note
If this PR includes changes that directly affect users or other significant modifications relevant to the community, kindly draft a release note to provide a concise summary of these changes. Please prioritize highlighting the impact these changes will have on users.

#18619  👈
main

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @xxchan and the rest of your teammates on  Graphite


add ethgastracker

What changed? Why?
Add ETH Gas Tracker - a tool to monitor and track Ethereum and L2 gas prices, including Base
https://www.ethgastracker.com/network/base
Notes to reviewers
Messed up previous PR #1145 when trying to sign commits. Clean history here

🟡 Heimdall Review Status

Requirement
Status
More Info

Reviews

🟡
0/1

Denominator calculation

Show calculation

1 if user is bot
0

1 if user is external
0

From .codeflow.yml

1

Additional review requirements

Show calculation

Max
0

0

From CODEOWNERS

0

Global minimum
0

Max

1

1

1 if commit is unverified
0

Sum
1


Current Value in the Positions section of the Portfolio pg not working

displaying only 0.000s
Both for long and short positions

better...shows both dates in market creation

after the last fix no longer showing me zeros, but showing me incorrect value.
I sold 11 at .27 and last trade price was .28, my current value s/b 7.92= (1-.28)*11
it currently shows me with -7.02 value which is incorrect

seems like getUserTradingPositions is sending back the wrong currentValue

This might have been addressed with newest change to currentValue

this is working correctly now...closing


Incorrect sflow parsing TCP/UDP ports in case of IP fragment

When sflow packet contains an IP fragment (FragmentOffset != 0), goflow still parses the srcPort and dstPort fields. This is incorrect because in such cases, the TCP/UDP header is missing, and garbage data ends up in the srcPort/dstPort fields.
Workaround:
if len(data) >= offset+4 && (nextHeader == 17 || nextHeader == 6)  && (fragOffset & 8191) == 0 {
			srcPort = binary.BigEndian.Uint16(data[offset+0 : offset+2])
			dstPort = binary.BigEndian.Uint16(data[offset+2 : offset+4])
		}

Good catch! Will have a look. Thank you


Please build arm compatible image

We would love to use this project on arm devices without having to do our own custom build. I checked everywhere I could and it doesn't appear you have a publicly available arm build that we can use on a raspberry pi.

If I may suggest, use a manifest image. This way, Docker decides the correct image to deliver based upon the architecture. Docker has updated all of it's own images to use this and it makes life much easier.
I wrote a technical blog post on this https://simonemms.com/2017-12-03/docker-swarm-compatible-multiarch-builds-with-manifest, but there are plenty of tutorials out there on this now

+1

I did build a multi-arch image for my own needs (actually, I'm interested in a downstream, logdna) (for arm6, armv7hf, arm64, amd64).
Just a hack at this point but does demonstrate feasibility.
Changeset is here: https://github.com/dubo-dubon-duponey/docker-gliderlabs-logspout/commit/fdf15b0fc2f983bab2698dcfa292a29194d84a1a
This is leveraging buildx (means you need docker 19.03+), albeit the go binary is being cross-compiled using the go toolchain and NOT qemu.
The main issue with the current state of affairs IMO is that people customizing logspout using the extension model (ONBUILD triggers + build.sh / modules.go) will NOT get multi-arch images themselves without doing their homework as well (see the corresponding logdna changes: https://github.com/logdna/logspout/pull/12)
Something more stream-lined could be achieved, but I can't think of a way to not break compatibility with the current extension mechanism...
Either way, 2 cents. Hope that helps.

Would love this as well for my Raspberry Pi based IoT use case. Currently having to use https://github.com/emdem/raspi-logspout

This may be addressed now by #512 and/or #514?


Referencing issues

Hello i tried compiling this code for traffic analysis but i kept giving me errors referencing errors i used vs2019 <-> 22

Sorry for late reply....
I haven't lately played with it.
Also haven't tried with vs2022...
Can't say much...
If u did get something to share pls open a issue regarding that, thanks btw :)


extractValueSpaces clobbers previously identified values

I noticed that when parsing css-shapes-2, reffy fails to extract the syntax for several valuespaces.  After reviewing the code in extract-cssdfn.mjs, it appears that reffy is capable of identifying these values.  The issue however, is that any later matches of the same syntax name will clobber any previously identified value.
This is true in both parseProductionRules:
https://github.com/w3c/reffy/blob/eba2d3069851bbf8b6d8215d6eddc0c296260ef2/src/browserlib/extract-cssdfn.mjs#L134-L136
And the final parsing rule:
https://github.com/w3c/reffy/blob/eba2d3069851bbf8b6d8215d6eddc0c296260ef2/src/browserlib/extract-cssdfn.mjs#L227-L235
I'm not sure if this is intended or not but instead of clobbering existing rules, reffy should consider only storing new results.  For example:
if (!space.name in res) {
  res[space.name] = {};
}

if (space.prose && !res[space.name].prose) {
  res[space.name].prose = space.prose;
}
if (space.value && !res[space.name].value) {
  res[space.name].value = space.value;
}

I ran a test run where I don't clobber existing definitions.  Here's the result:
diff -ru reports/ed/css/css-page-floats.json reports.patched/ed/css/css-page-floats.json
--- reports/ed/css/css-page-floats.json	2021-02-03 13:29:05.963975153 -0500
+++ reports.patched/ed/css/css-page-floats.json	2021-02-03 12:56:35.775098217 -0500
@@ -63,10 +63,10 @@
   "descriptors": {},
   "valuespaces": {
     "<snap-block()>": {
-      "value": "snap-block()"
+      "value": "snap-block( <length> , [ start | end | near ]? )"
     },
     "<snap-inline()>": {
-      "value": "snap-inline()"
+      "value": "snap-inline( <length> , [ left | right | near ]? )"
     }
   }
 }
diff -ru reports/ed/css/css-shapes-2.json reports.patched/ed/css/css-shapes-2.json
--- reports/ed/css/css-shapes-2.json	2021-02-03 13:29:05.967975213 -0500
+++ reports.patched/ed/css/css-shapes-2.json	2021-02-03 12:56:35.779098346 -0500
@@ -36,27 +36,35 @@
       "value": "<move-command> | <line-command> | <hv-line-command> | <curve-command> | <smooth-command> | <arc-command> | close"
     },
     "<coordinate-pair>": {
+      "value": "<length-percentage>{2}",
       "prose": "Defines a pair of coordinates, representing a rightward and downward offset, respectively, from a specified reference point. Percentages are resolved against the width or height, respectively, of the reference box."
     },
     "<by-to>": {
+      "value": "by | to",
       "prose": "Every command can be specified in \"absolute\" or \"relative\" coordinates, determined by their <by-to> component. to indicates that any <coordinate-pair>s in the command are relative to the top-left corner of the reference box, while by indicates that the <coordinate-pair>s are relative to the command’s starting point. Note: In either case, <percentage> values in <coordinate-pair>s are always computed relative to the reference box’s size."
     },
     "<move-command>": {
+      "value": "move <by-to> <coordinate-pair>",
       "prose": "Adds a moveto command to the list of path data commands, with an ending point specified by the <coordinate-pair>. This draws nothing, and merely \"moves the pen\" for the next command. Note: This starts a new subpath, for the purpose of the close command."
     },
     "<line-command>": {
+      "value": "line <by-to> <coordinate-pair>",
       "prose": "Adds a lineto command to the list of path data commands, with an ending point specified by the <coordinate-pair>. This draws a straight line from the command’s starting point to its ending point."
     },
     "<hv-line-command>": {
+      "value": "[hline | vline] <by-to> <length-percentage>",
       "prose": "Adds a horizontal (for hline) or vertical (for vline) lineto command to the list of path data commands. This is equivalent to a line command with the <length-percentage> given as the horizontal or vertical component, respectively, of the <coordinate-pair>, and the other component specified appropriately to make the line horizontal or vertical."
     },
     "<curve-command>": {
+      "value": "curve <by-to> <coordinate-pair> via <coordinate-pair>{1,2}",
       "prose": "Adds a Bézier curve command to the list of path data commands, ending at the point specified by the first <coordinate-pair>. The via component specifies control points for the curve: if a single <coordinate-pair> is provided, the command specifies a quadratic curve; if two <coordinate-pair>s are provided, it specifies a cubic curve."
     },
     "<smooth-command>": {
+      "value": "smooth <by-to> <coordinate-pair> [via <coordinate-pair>]?",
       "prose": "Adds a smooth Bézier curve command to the list of path data commands, ending at the point specified by the first <coordinate-pair>. The via component specifies control points for the curve: if it’s omitted, the command specifies a smooth quadratic curve; if it’s provided, if specifies a smooth cubic curve. Note: A smooth command is equivalent to a curve command with the first control point automatically specified as the reflection of the previous curve’s second control point around the starting point, or as the starting point if the previous path data command wasn’t a curve. This ensures G1 continuity with the previous command, so the curve appears to smoothly continue from the previous command, rather than possibly making a sudden direction change."
     },
     "<arc-command>": {
+      "value": "arc <by-to> <coordinate-pair> of <length-percentage>{1,2} [ <arc-sweep> || <arc-size> || <angle> ]?",
       "prose": "Add an elliptical arc command to the list of path data commands, ending at the point specified by the <coordinate-pair>. The of component specifies the size of the ellipse that the arc is taken from. The first <length-percentage> provides the horizontal radius of the ellipse and the second provides the vertical radius. Like for <coordinate-pair>s, <percentage> values are resolved against the width or height of the reference box, as appropriate. If only one <length-percentage> is provided, both radiuses use the provided value. In that case, <percentage> values are resolved against the direction-agnostic size of the reference box (similar to the circle() function). Note that SVG has some specific error-handling for the ellipse radiuses: if the endpoint is the same as the starting point, the command does nothing if either radius is zero, the command is equivalent to a <line-command> to the ending point if either radius is negative, its absolute value is used instead if the radiuses don’t describe an ellipse large enough to intersect both the starting point and ending point (after rotation by the specified <angle>), they are scaled up uniformly until the ellipse is just large enough to reach. The ellipse described by the specified radiuses defaults to being axis-aligned, but can be rotated by specifying an <angle>. Similar to the rotate() transform function, positive angles specify a clockwise rotation, and negative angles specify a counterclockwise rotation. If omitted, this defaults to 0deg. The ending point, radiuses, and angle, taken together, usually define two possible ellipses that intersect the starting point and ending point, and each ellipse can be traced in either direction, for a total of four possible arcs. The <arc-sweep> and <arc-size> components specify which of these arcs is desired: <arc-sweep> can be cw or ccw, indicating that the arc that is traced around the ellipse clockwise or counter-clockwise from the center, respectively, must be chosen. If omitted, this defaults to ccw. Note: In the SVG arc command, cw corresponds to the value 1 for the sweep flag, and ccw to the value 0. <arc-size> can be large or small, indicating that the larger or smaller, respectively, of the two possible arcs must be chosen. If omitted, this defaults to small. Note: In the SVG arc command, large corresponds to the value 1 for the large flag, and small to the 0. Note: If the starting and ending points are on exactly opposite sides of the ellipse, both possible arcs are the same size, but also there is only one possible ellipse. In this case, the <arc-sweep> distinguishes which of the two possible arcs will be chosen, and <arc-size> has no effect. A depiction of the two possible ellipses, and four possible arcs, that can be chosen between."
     },
     "<arc-sweep>": {
diff -ru reports/ed/css/css-shapes.json reports.patched/ed/css/css-shapes.json
--- reports/ed/css/css-shapes.json	2021-02-03 13:29:05.963975153 -0500
+++ reports.patched/ed/css/css-shapes.json	2021-02-03 12:56:35.775098217 -0500
@@ -59,6 +59,7 @@
       "value": "path( [<'fill-rule'>,]? <string> )"
     },
     "<shape-radius>": {
+      "value": "<length-percentage> | closest-side | farthest-side",
       "prose": "Defines a radius for a circle or ellipse. If omitted it defaults to closest-side. closest-side uses the length from the center of the shape to the closest side of the reference box. For circles, this is the closest side in any dimension. For ellipses, this is the closest side in the radius dimension. farthest-side uses the length from the center of the shape to the farthest side of the reference box. For circles, this is the farthest side in any dimension. For ellipses, this is the farthest side in the radius dimension."
     }
   }

@pyoor this sounds like a net improvement indeed - could you bring your proposed changes to the code as a pull request?


change cases into titled exhibits

changed to Case #: "Title" (could still remove "Case #" if better)


fix(python): ValueError: write to closed file

Fixes #2527

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

AWS CodeBuild CI Report

CodeBuild project: AutoBuildProject89A8053A-6Jw05QLuWWwe
Commit ID: f24e80a91280b03b9d5307c49ca90a8dc16929c7
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@all-contributos add @aniljava for code

@all-contributors add @aniljava for code


chore: use cli 12.x for testing

Description of changes

Updates the CLI dependency we use for running tests.
CDK / CloudFormation Parameters Changed

Issue #, if available

Description of how you validated changes
Checklist

[x] PR description included
[x] yarn test passes
[x] Tests are changed or added
[ ] Relevant documentation is changed or added (and PR referenced)
[ ] New AWS SDK calls or CloudFormation actions have been added to relevant test and service IAM policies
[ ] Any CDK or CloudFormation parameter changes are called out explicitly

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

The other 2 tests are already fixed and merged in https://github.com/aws-amplify/amplify-category-api/pull/1475. We should have a green pipeline once this is merged in.


Fixed Arbitary Code Execution

📊 Metadata *
DeepFriedBot is a telegram bot that sends random deep fried memes, the package is vulnerable to Arbitrary Code Execution.
Bounty URL: https://www.huntr.dev/bounties/1-other-DeepFriedBot
⚙ Description *
Vulnerable to YAML deserialization attack caused by unsafe loading.
💻 Technical Description *
Fixed by avoiding unsafe loader.
🐛 Proof of Concept (PoC) *
Create the following PoC file:
exploit.py
import os
os.system('git clone https://github.com/xdf8/DeepFriedBot')
os.chdir('DeepFriedBot/')
payload = """cmd: !!python/object/new:type
  args: ["z", !!python/tuple [], {"extend": !!python/name:exec }]
  listitems: "__import__('os').system('calc.exe')"
"""
open('credentials.yml','w+').write(payload)
os.system('python3 bot.py')

Execute the commands in another terminal:
python3 exploit.py

xcalc will pop up.
🔥 Proof of Fix (PoF) *
After fix it will not popup a calc.
👍 User Acceptance Testing (UAT)
After fix functionality is unaffected.
🔗 Relates to...
https://www.huntr.dev/bounties/1-other-DeepFriedBot

👋 Hello, @xdf8 - @Anon-Artist has opened a PR to us with a fix for a potential vulnerability in your repository. To view the vulnerability, please refer to the bounty URL in the first comment, above.
Ultimately, you get to decide if the fix is 👍 or 👎. If you are happy with the fix, please write a new comment (@huntr-helper - LGTM) and we will open a PR to your repository with the fix. All remaining PRs for this vulnerability will be automatically closed.
If you have any questions or need support, come and join us on our community Discord!
@xdf8 & @Anon-Artist - thank you for your efforts in securing the world’s open source code! 🎉

@huntr-helper Cool stuff.
@Anon-Artist I have added you on LinkedIn, I would like to learn more! Thanks for the fix.

@xdf8 - can you create a new comment with the LGTM statement?
This will properly fire off our automation - cheers! 🍰

LGTM

like this? sorry I'm completely new to this 😅

I'll help you out! 🎉
@huntr-helper - LGTM!
@xdf8, if you stick our badge on your README.md, you can let security researchers know that they can win bounties protecting your repositories.
Copy this small code snippet...
[![huntr](https://cdn.huntr.dev/huntr_security_badge.svg)](https://huntr.dev)
👇 👇 👇

@xdf8 already accepted the invitation and added you as a connection 😀
@huntr-helper - LGTM
You can type exactly like above as a cooment so the huntr bot create a pull request to your repository so you can easily merge and fix the issue .
Thanks


Issue 697 v2

Addresses the issue of creating a new restart key each time we submit the cloudformation template.

Awesome. Looks great to me 👍

closing for the second time in favor of an updated branch 🙈


Could not to change background colour of Fullscreen view

Could not to change background colour of Fullscreen view. How to change it ?
tried like
`open func didTap() {
let fullScreenController = imageSlideShow.presentFullScreenController(from: self)
fullScreenController.backgroundColor = .white
}`

And it possible use another images for fullscreen loading?

This should do the trick:
let fullScreenController = imageSlideShow.presentFullScreenController(from: self)
fullScreenController.view.backgroundColor = .white

You can use another images for fullscreen by configuring the inputs property on FullScreenSlideshowViewController.

Doesn't seem to work solution proposed.

let fullScreenController = imageSlideShow.presentFullScreenController(from: self) fullScreenController.view.backgroundColor = .white
Is the only working solution, and using white hides the close button which uses a white icon, so after the code above I had to replace image of close button which a reversed one made in a photo editor.
       fullScreenController.closeButton.setImage(UIImage(named: "ic_cross_black"), for: UIControlState())


⚠ Bofrost.de has degraded performance

In 3216080, Bofrost.de (https://www.bofrost.de) experienced degraded performance:

HTTP code: 200
Response time: 1317 ms

Resolved: Bofrost.de performance has improved in 53459bb.


Unpredictable "missing input file" error

Twice we have seen an error looking like this:
ERROR: missing input file '@org_apache_httpcomponents_httpclient//jar:httpclient-4.0.1.jar'
ERROR: [SNIP]/src/java/BUILD.bazel:105:1: //src/java:cloud_registry: missing input file '@org_apache_httpcomponents_httpclient//jar:httpclient-4.0.1.jar'
ERROR: [SNIP]/src/java/BUILD.bazel:105:1 1 input file(s) do not exist
INFO: Elapsed time: 420.080s, Critical Path: 127.06s
FAILED: Build did NOT complete successfully

The missing jar is not always the same. Retrying the build doesn't help, but bazel clean --expunge does. Unfortunately I don't have a way to reproduce it, but it seems to happen when the system hasn't rebuilt the Java targets in a while (maybe due to changes in the version on Maven?)
I know this isn't a very helpful bug report :) I'm posting in case anyone else is experiencing the same issue.

I had the same problem, also have no idea how to reproduce it, and bazel clean --expunge fixed it.

I had the same problem too

I met this problem in following case: do NOT specify executable=True in rule but return DefaultInfo provider with executable inside


Packages - force python 3.9

On stock 20.04 python3 refers to python 3.8 - we need 3.9.
This PR explicitly lists 3.9 as a reference.

@SchrodingersGat this would be ready for review and merge


Box Station - Now more festive!

About the PR

Made Box station more festive
Why / Balance

Tis the season
(no other reason :godo:)
Technical details

Media

HoP line has received some astro snow

Tools room and locker room has some neat decorations. Also hey look there's now a tile under that laundry room door.

Gave the bridge some much-needed love

Sec got a little festive to complement their santa outfits

Gave the bar some astro snow as well, and lined the north side of this hallway with more holiday cheer!

Including evac!
Requirements

[x] I have read and am following the Pull Request and Changelog Guidelines.
[x] I have added media to this PR or it does not require an ingame showcase.

Breaking changes

Changelog

Damn, we just branched off staging for the next release. Maybe we can hotfix this into stable, otherwise this will have to wait until the next release on the 22th.

It's not a big deal at all. I made this purely to fix the tile missing under the laundry room door, the festive decorations are a bonus.


Filter (or discard) notices based on user agent

Hello,
I've first suggested it in errbit/errbit#1081 , but the author suggested it sould be done on the client library, not on the Errbit server. The official AirBrake API already expects that, as noted in https://github.com/errbit/errbit/issues/1081#issuecomment-209599417
Also, we've found that there is a "shouldNotify" function that could be extended with this filter:
https://github.com/emgiezet/errbitPHP/blob/master/src/Errbit/Errbit.php#L165
If you prefer, I can do the necessary changes and open a pull request. What do you say?
Kind regards,
Daniel

Hi!
Thanks for contribution! I will merge it today with the new tag 1.1.1
Cheers!
Max

Ok, thank you!
I am using it on two live sites and it is working as expected.
Kind regards,
Daniel


preprocessors.shift(...) is not a function

I think this commit is giving me this error:

27 07 2015 15:21:53.351:ERROR [karma]: [TypeError: preprocessors.shift(...) is not a function]
TypeError: preprocessors.shift(...) is not a function
at nextPreprocessor (/Users/kentcdodds/Developer/alianza/admin-portal/node_modules/karma/lib/preprocessor.js:73:28)
at /Users/kentcdodds/Developer/alianza/admin-portal/node_modules/karma/lib/preprocessor.js:96:7
at /Users/kentcdodds/Developer/alianza/admin-portal/node_modules/karma/node_modules/graceful-fs/graceful-fs.js:76:16
at FSReqWrap.readFileAfterClose [as oncomplete] (fs.js:380:3)

Anything off the top of your head? Everything's working fine with version 0.13.1 but breaks with version 0.13.2. Do you know what might be the problem? Or do you need me to dig more?

Thanks for reporting, you are probably right with the commit, but I have no idea how this could happen, as even [].shift() should not throw this error. So if you could find some details, on how this occurs I would be very grateful.

This is the code that I'm looking at that's blowing up:
preprocessors.shift()(content, file, nextPreprocessor)

I believe that what's being shifted isn't a function. That's what the error means... Digging...

It looks like the line:
instances[name] = injector.get('preprocessor:' + name)

is actually assigning instances[name] to undefined which ultimately gets pushed into the preprocessors (as undefined) and then this error gets thrown.
The preprocessor I'm working with is webpack (I'm using version 1.6.0).

Right, I see, thanks a lot for digging. So the best thing is probably to a) not do the assignment when it fails and b) ensure when pushing into preprocessors that the element is not undefined.

I agree. In addition, I don't think that this fix will resolve my ultimate issue. Do you know why the webpack preprocessor isn't getting added? Will things work when webpack hasn't yet been added?

karma-webpack won't work unless you use my fork https://github.com/webpack/karma-webpack/pull/63 that is probably what you are running into

Ah, I see. Sounds good. I'll subscribe to that PR so I know when it's merged. Thanks for your work on karma! It's beyond invaluable. And thanks for the quick response.

I just hit this issue today with Karma 0.13.10, upgrading from an older version and tyring to get karma-sourcemap-loader to work. Has there been any progress on fixing this?

Same error here with 0.13.11 :/

The same error with 0.13.11 on Linux. It works for me on Windows :(
I'm using preprocessor webpack

npm install karma@canary fixed the problem for me

Also seeing this issue.  Any suggestions on how to fix/work around?

@gep13 I've also run in this error when i was using karma-sourcemap-loader cause i forgot to add it to the plugins property.
plugins: [
  …
  'karma-sourcemap-loader'
],

So recheck your karma.conf.js.

+1 for karma-live-preprocessor

Same issue with 0.13.16. :crying_cat_face:

Please everyone can you test if https://github.com/karma-runner/karma/pull/1777 works for you? I'm not able to reproduce the issue myself, so I can only guess atm.


refactor: enable more lints clippy rules

currently we only enable a very small sets of lint rules and clippy actually provides lots of rules that's not only useful for style but also for performance, we should adopt more clippy rule.
a good start is  to learn from biome's rules https://github.com/biomejs/biome/blob/main/Cargo.toml#L15

Clippy lints: https://rust-lang.github.io/rust-clippy/rust-1.80.0/index.html

closed as finished


Cleanup tests in pipeline_test.

Notably, the runner_name parameter has been obsolete since the removal
of DiskCachedRunnerPipelineTest and is an inferior version of what
TestPipeline provides.
Be sure to do all of the following to help us incorporate your contribution
quickly and easily:

[ ] Make sure the PR title is formatted like:
[BEAM-<Jira issue #>] Description of pull request
[ ] Make sure tests pass via mvn clean verify. (Even better, enable
Travis-CI on your fork and ensure the whole test matrix passes).
[ ] Replace <Jira issue #> in the title with the actual Jira issue
number, if there is one.
[ ] If this contribution is large, please file an Apache
Individual Contributor License Agreement.

R: @markflyhigh

Changes Unknown when pulling 9ae97134c0160f29159a813e036bdf34c49934d4 on robertwb:testing into ** on apache:python-sdk**.

R: @aaltay
From the first commit message: Notably, the runner_name parameter has been obsolete since the removal
of DiskCachedRunnerPipelineTest and is an inferior version of what
TestPipeline provides.

LGTM


[WIP] Support traffic in the overlay network when pod traffic leaving a node is not SNATed

…g to the overlay network in the gateway pod
Description
Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.
Fixes #(issue)
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Please also note any relevant details for your test configuration.

[ ] Test A
[ ] Test B

Closed in favor of #584.


Provide API for @RestController Spring Beans

What needs to be done
A FindRestControllerBeans finder  should find all classes annotated with @RestController and return them as RestControllerBeans offering an API dedicated to @RestControllers.
Why it needs to be done
This API will ease creating Tests for @RestController, introducing Spring Cloud Contract and all sorts of Spring web-related recipes.
Acceptance Criteria
The API should provide all information provided by @RestController or any method annotated with request mapping annotations like @GetMapping or RequestMapping(...)
A RestControllerBean has a set of RestMethod.
RestMethod provides an API to retrieve all information provided through request mapping annotations.
Additional Information

Enhance RestControllerSpring Bean support to handle RequestMapping on type level with all supported attributes
The implementation currently only handles @RequestMapping/Get/Post/...Mapping annotations.

Supported at the type level as well as at the method level!

	/**
	 * The HTTP request methods to map to, narrowing the primary mapping:
	 * GET, POST, HEAD, OPTIONS, PUT, PATCH, DELETE, TRACE.
	 *
Supported at the type level as well as at the method level!
	 * When used at the type level, all method-level mappings inherit this
	 * HTTP method restriction.
	 */
	RequestMethod[] method() default {};


Include webhook cert provisioning scripts in release tarball

The following scripts need to be included in the release tarball.
https://github.com/istio/istio/blob/master/install/kubernetes/webhook-create-signed-cert.sh
https://github.com/istio/istio/blob/master/install/kubernetes/webhook-patch-ca-bundle.sh

Duplicates https://github.com/istio/issues/issues/178

Any plan to include and ship the same files in Windows version? https://github.com/istio/istio/releases/download/0.5.0/istio_0.5.0_win.zip

webhook-create-signed-cert.sh and webhook-patch-ca-bundle.sh weren't included in any of the 0.5.0 release zip/tarballs. They should be included whenever the next release is cut. You can also download them directly with the links belows.
https://raw.githubusercontent.com/istio/istio/master/install/kubernetes/webhook-create-signed-cert.sh
https://raw.githubusercontent.com/istio/istio/master/install/kubernetes/webhook-patch-ca-bundle.sh


How to test concurrent rendering?

@Raynos @neonstalwart @Matt-Esch How to test concurrent rendering?
Question is similar to testing of main-loop: http://stackoverflow.com/questions/34862892/test-concurrent-call-of-the-same-function
See, please! Thanks!

@kuraga I'm sorry, I still have no idea what you mean? What do you expect to test?
Because raf ticks asynchronously you can execute unit tests in between tests to assert values; just wrap the tests themselves in raf calls to make them execute on the same tick. Does that answer your question?

@yoshuawuyts big thanks for reading and reply!
I want to test that "render call delays longAction call until current render ends". Every man says "async" but means different :smile:
var value = 0;
raf(function () {
  console.log(value);  // logs:<PHONE_NUMBER>
});
for(var i = 0; i <<PHONE_NUMBER>; ++i);

So I can't (without some magic I ask about) start render during render...


Update mkdocs.yml in Status writing style guide to Material insiders build

The mkdocs.yml configuration file for the writing style guide should keep in synch with the one under the config/en directory.

Apparently, there is already the Insiders label on the footer of our Style guide. So here is the differences info:
en/mkdocs.yml

31 line, color option: primary: white
94 line, html plugin: md_in_html
96 line, headers level: toc_depth: 2
127 line, inherit line: INHERIT: '../../overrides/mkdocs.insiders.yml'

style-guide/mkdocs.yml

31 line, color option: primary: deep purple
83 line, snipets plugin: pymdownx.snippets

Each config file contains color option with different values. Other lines are unique for the relevant config files.

Thanks, @exebeeche ,
I double-checked the Jenkins script and yes, the Style Guide is now built using Insiders.
Regarding the changes to do, could you please take care of these?

[ ] in style-guide/mkdocs.yml:
Adding the md_in_html option and INHERIT: '../../overrides/mkdocs.insiders.yml directive.
[ ] in en/mkdocs.yml
No changes; the pymdownx.snippets option exists in en/mkdocs.yml.

Thanks.

No problem, I will fix the style-guide/mkdocs.yml file.


Installation of kazu[webserver] from Mac with Python 3.11

Issue:
Installing with
pip install kazu[webserver]

does not work on MacOS with the following error message:
KAZU % pip install kazu[webserver]
zsh: no matches found: kazu[webserver]

Any settings in the brackets do not seem to be recognized by the Mac environment (zsh and pip).
I found an explanation for this here: https://stackoverflow.com/a/30539963
Roundabout:
pip install 'kazu[webserver]'

Additional Issue with Hydra Installation:
When using Python 3.11, there is an issue with installing the hydra package.
I found a Stack Overflow page, saying that using Python 3.10 avoids this problem.

Thank you for reporting, we have updated the docs to reflect this in https://github.com/AstraZeneca/KAZU/pull/69.


Support for Wagtail 3 and 4 and Django >= 3.2

Bring wagtailnews up par with Wagtail 3 and 4 and Django >= 3.2. The version compatibilities are taken from here: https://docs.wagtail.org/en/stable/releases/upgrading.html
This PR will fix all the deprecation warnings and is tested to work with Django 3.2 and higher. The admin layout is a little off, mainly the action menu in the bottom, but the library works and does not give errors. Future work is required to bring the class based views to wagtailnews admin and thus achieve similar look with the rest of the Wagtail.
This PR removes support for Wagtail < 3 but the wagtailnews 2.x version should be upkept for that.
This PR does not contain any new features.

Fixes #34

I've just released 4.0 of wagtailnews which includes WT4/5 compatibility. It was  bit of a heavier rewrite than I expected taking advantage of the new generic admin views built into wagtail. Your two merge requests help me figure out some of the weird edge cases, thanks for the help!