Update the histological description of the dorsal vessel

This PR uses recent anatomical and histological studies (notably Lehmacher et al., 2012 [FBrf0219200]) to give more precise descriptions of the cell types that make up the dorsal vessel in both the larva and the adult.
closes #1289
closes #17

We should also probably merge embryonic dorsal vessel (FBbt:00005680, no definition, used in 71 records) with embryonic/larval dorsal vessel (FBbt:0001673, with a complete definition, used in 554 records).
However I am unsure about what to do with the EmbDevSlim subset annotation carried by embryonic dorsal vessel but not by embryonic/larval dorsal vessel. What is this annotation for, and if we merge the two terms, can we simply move the annotation to the “surviving” term?

I would not do this merge as part of this PR as it will probably require a bit of extra research (and informing the curators), which can be done as part of #1138


Wrong meta.total when applying filters

I ran into the issue that the API returns a total of 2 pages when I only have 2 items matching the filters. Do I got anything wrong or is this an issue?
Thanks in advance!

This wasn't an issue. I misunderstood the total as the total of pages but it's the total of items instead 👍


Settings window is just a white box, mpvnet questions

On windows when I press the little gear icon above the mpv icon a little white box opens which I assume is the settings menu, but nothing is displayed it's just a white box that stays there. I do have some other extensions in use but as of yet have not been able to narrow it down. Also, I find that using mpvnet is a far better option for most people in that, titles on the window and in general player ui is far better so I went with that, and all seems mostly ok so you might recommend that. The command prompt that pops up after the play icon is pressed says some stuff about hardware acceleration errors and it try to play 4k stuff which I can't handle on this machine so I need to be able to get to the settings to change that and I can't. Any help appreciated, logs and screenshots available if you need. I really like the idea of this project but the settings window not showing up is making it hard to use.

On windows when I press the little gear icon above the mpv icon a little white box opens which I assume is the settings menu, but nothing is displayed it's just a white box that stays there.

Please tell me your environment. such as:

browser (and version)
userscript manager (greasemonkey? tampermonkey? violentmonkey? and version)
os version

Edge 127.0.2651.98, Tampermonkey, Windows 11 10.0 22631 x86_64

Edge 127.0.2651.98, Tampermonkey, Windows 11 10.0 22631 x86_64

Reproduced, the issue is due to YouTube adding a new TrustedHTML rule that prevents the use of certain JavaScript objects.
Uncaught TypeError: Failed to set the 'innerHTML' property on 'Element': This document requires 'TrustedHTML' assignment.
    at create (Play with MPV.user.js:515:25)
    at buildConfigWin (Play with MPV.user.js:257:33)
    at HTMLIFrameElement.<anonymous> (Play with MPV.user.js:382:15)

I will look for a solution soon. For now, please modify the settings on other supported sites, such as bilibili.com

Also, I find that using mpvnet is a far better option for most people in that, titles on the window and in general player ui is far better so I went with that, and all seems mostly ok so you might recommend that.

If mpv.net's command line is compatible with mpv, you can use it directly. Just modify config.toml and set mpv to mpv.net

Please try v2024.08.11


Add support for Cloud Monitoring Distributions in the metrics exporter

The current implementation for ValueRecorderInstrumentKind is lastvalue. This prevents clients from having an effective way to chart latency metrics.
By populating the RPC request as described in https://cloud.google.com/monitoring/api/ref_v3/rest/v3/TypedValue#Distribution, it should be possible to implement these distribution metrics.

This last value behavior has been changed to histogram in the OTel metrics specification, but the Go SDK hasn't implemented it yet. This will probably take a while, but we will definitely send distribution metrics once it is ready.

The spec-compliant go SDK is tracked in https://github.com/orgs/open-telemetry/projects/22.  Once that is done, we will update this exporter--including supporting distributions.


v 4.2.0 - Swift 3+ : Extra argument 'method' in call

Alamofire.request("String URL Convertible", method: <Alamofire.HTTPUrlMethod>, parameters: parameters, encoding:URLEncoding.default, headers: header).responseJSON { (response) in
Showing an error as extra parameters <Alamofire.HTTPUrlMethod> in request.
Xcode 8.2

Sorry, we use our GitHub project for bug reports and feature requests. In the future, you should open questions like this on Stack Overflow and tag alamofire.
Cheers. 🍻

From our Contribution Guidelines
Asking Questions
We don't use GitHub as a support forum. For any usage questions that are not specific to the project itself, please ask on Stack Overflow instead. By doing so, you'll be more likely to quickly solve your problem, and you'll allow anyone else with the same question to find the answer. This also allows maintainers to focus on improving the project for others.

Hi jshier, It's not a Stackoverflow question. It's an Alamofire source bug. When you start writing "Alamofire.request("
it will show/allow you to add these many params, "String URL Convertible", method: <Alamofire.HTTPUrlMethod>, parameters: parameters, encoding:URLEncoding.default, headers: header
But when you compelete this line and build, it shows an error like extra parameter in arguments/call.


Remove inflate compilation options from CMake script

Instead I now just pass them through CMAKE_C_FLAGS in CI yaml. No reason to support two extra options if we don’t have to.

Rebased

I kinda feel like this should remain as an option, rather than embedding in the CFLAGS.
Perhaps hide behind "advanced options"?

I think this should remain as an option too...

I think there will be some options that dont need to be CMake options because they are rarely used or only used for testing, like -DUSE_MMAP.

Passing things through CMAKE_C_FLAGS is bad practice, as it is cache variable, that should not be used by external code... The correct external variable is CFLAGS.

Ok I have modified it to use CFLAGS. I other PRs I plan to also:

Add CI instance with -DUSE_MMAP using CFLAGS
Remove ZLIB_DUAL_LINK cmake option and make it a ctest if zlib package is found.

I feel like these two options might be useful in some very rare corner-cases, such as attempting to recover data from a compressed stream/file that has been corrupted and compliance checking of a compressed stream/file. I admit that those cases are likely very very rare, but it is a possibility, and that is also why I haven't removed those from the code altogether.
Maybe we should put those and any really special-purpose options like those into a separate options table in the readme file, to deter users from thinking those are good to have enabled.

I think the interface/option set looks cleaner without them. We could have a table in the wiki with all the advanced compiler defines like USE_MMAP, etc and remove mention of them in the readme altogether.

Btw these options are already in the "Advanced Options" table in readme.


Fix 2PC bugs

Codecov Report

Merging #66 into release-rc4 will decrease coverage by 0.09%.
The diff coverage is 50.00%.

@@                Coverage Diff                @@
##             release-rc4      #66      +/-   ##
=================================================
- Coverage          59.48%   59.39%   -0.10%
+ Complexity           315      313       -2
=================================================
  Files                 35       35
  Lines               2826     2827       +1
  Branches             208      208
=================================================
- Hits                1681     1679       -2
- Misses               997      999       +2
- Partials             148      149       +1

Impacted Files
Coverage Δ
Complexity Δ

...a/com/webank/wecross/stub/fabric/FabricDriver.java
60.03% <40.00%> (-0.12%)
31.00 <0.00> (ø)

...m/webank/wecross/stub/fabric/FabricConnection.java
55.73% <100.00%> (ø)
47.00 <1.00> (ø)

.../wecross/stub/fabric/ChaincodeResourceManager.java
79.56% <0.00%> (-2.16%)
21.00% <0.00%> (-2.00%)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cdf5ba4...0b2236c. Read the comment docs.


Fixed the observable collection thread pool indicator

Add the code removed by "Feature/3.2 rest protocol provider (#11640)"

Codecov Report

Merging #12087 (43b9044) into 3.2 (7e3064f) will decrease coverage by 0.27%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##                3.2   #12087      +/-   ##
============================================
- Coverage     69.97%   69.71%   -0.27%
+ Complexity      340        2     -338
============================================
  Files          3385     1583    -1802
  Lines        159024    65251   -93773
  Branches      26500     9501   -16999
============================================
- Hits         111277    45487   -65790
+ Misses        38100    15399   -22701
+ Partials       9647     4365    -5282

see 1829 files with indirect coverage changes
:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more


Release EKS Go: v1.20.14-16

Increment release file to publish new EKS Go artifacts for v1.20.14-16

Release artifacts built in: https://github.com/aws/eks-distro-build-tooling/pull/1367

/lgtm

/approve


Firebase support for AdServices Framework - AppleSearchAds tracking

Description
Reopening the issue in https://github.com/firebase/firebase-ios-sdk/issues/7860
We integrated AdServices framework and is on a supported firebase version, but did not find AppleSearchAds campaign being tracked.
Reproducing the issue
No response
Firebase SDK Version
10.11.0
Xcode Version
15.3
Installation Method
N/A
Firebase Product(s)
Analytics
Targeted Platforms
iOS
Relevant Log Output
No response
If using Swift Package Manager, the project's Package.resolved

Expand Package.resolved snippet

Replace this line with the contents of your Package.resolved.

If using CocoaPods, the project's Podfile.lock

Expand Podfile.lock snippet

Replace this line with the contents of your Podfile.lock!

Same problem here. I searched the SDK but didn't find anything related to AAAttribution and attributionToken.
The document is still suggesting the old IDFA way.


Docker setup DB

Started on this in DockerDatabase branch

Possible consideration - Our target audience is probably more likely to use PostgreSQL already? Is there a way to catch the failure and try again with a backup port configuration? If not, look into selecting an unusual port (doubt it will be an issue as we're not requiring access across a network

Added DB constructor file & made first attempt at switching ETL over, still needs testing


CVE-2016-7954 secondary sources

Hi,
I'm just wondering where the code is at re this vulnerability? Is there a fix?
http://seclists.org/oss-sec/2016/q4/18
Apologies if I missed the answer to this q elsewhere.
Thanks, ben

Hi there. No one has contacted the Bundler team in any way regarding this vulnerability yet. We believe that we have already fixed the issue in an upcoming release, but there is no way to tell, since no one has bothered to give us the details of the supposed CVE.

What I could find:

2015-05-21 This issue was reported that appears to be the same thing. Closed; as it's fixed in 2.0 (but not 1.x).
2016-04-01 The blog post below suggests the Bundler team was contacted in April by email. No details of the contact. Searching the mailing list for "secondary source" and "CVE-2016-7954" comes up with nothing.
2016-10-04 CVE was requested and "reserved".
2016-10-04 Reed Loden's comment says further contact was made with the response that the 2.0 fix can't be backported to 1.x due to lockfile incompatibility.
2016-10-06 Steve Richert wrote this blog post about the CVE which he reported (I saw it on twitter). There are GIFs that appear to show a replication (I realise GIF immediately suggests ✨🐱✨ but it seems convincing).

Could this be a security issue in real world production environments? One thing that springs to mind is Rails Assets so I've opened a feeler issue there. Of course GitHub and Bitbucket inline sources are common too.
If it could be a real security issue, and assuming a fix can't be backported, should a warning be added suggesting the no top level source using only blocks workaround?
Was the team contacted, what was the actual response? How does RubyTogether fit into this, would additional funds from concerned parties help? Does RubyTogether prioritise security fixes (I don't see it on the site)?
I'm just collating info that may or may not be helpful, not trying to stir alarm or anything. You all do a great job, and it's really appreciated 💟

I've been able to verify this affects git and github remotes too - all gemspecs in that single repo will be considered for all global gems. https://github.com/sfcgeorge/gem_clash
However I'm struggling to think of a real world way this could be exploited. It would be easier for a rogue gem author to add malicious code to their own gem than add a second fake gem for "rails" or whatever.

Here is our plan to address this so far: https://github.com/bundler/bundler/issues/5062

This issue has been quiet for a while now and i feel that there is nothing left to add to this specific ticket. I'm going to close it for now.


the  response Runs.RunCreateAsStream not match the doc of open api

Describe the bug
The Assistant API returns multiple different objects when called as a Stream. The library should be able to handle these other response types as well.
the response of run api
the link
event: thread.run.created
data: {"id":"run_123","object":"thread.run","created_at":1710330640,"assistant_id":"asst_123","thread_id":"thread_123","status":"queued","started_at":null,"expires_at":1710331240,"cancelled_at":null,"failed_at":null,"completed_at":null,"required_action":null,"last_error":null,"model":"gpt-4-turbo","instructions":null,"tools":[],"metadata":{},"temperature":1.0,"top_p":1.0,"max_completion_tokens":null,"max_prompt_tokens":null,"truncation_strategy":{"type":"auto","last_messages":null},"incomplete_details":null,"usage":null,"response_format":"auto","tool_choice":"auto","parallel_tool_calls":true}}

event: thread.run.queued
data: {"id":"run_123","object":"thread.run","created_at":1710330640,"assistant_id":"asst_123","thread_id":"thread_123","status":"queued","started_at":null,"expires_at":1710331240,"cancelled_at":null,"failed_at":null,"completed_at":null,"required_action":null,"last_error":null,"model":"gpt-4-turbo","instructions":null,"tools":[],"metadata":{},"temperature":1.0,"top_p":1.0,"max_completion_tokens":null,"max_prompt_tokens":null,"truncation_strategy":{"type":"auto","last_messages":null},"incomplete_details":null,"usage":null,"response_format":"auto","tool_choice":"auto","parallel_tool_calls":true}}

event: thread.run.in_progress
data: {"id":"run_123","object":"thread.run","created_at":1710330640,"assistant_id":"asst_123","thread_id":"thread_123","status":"in_progress","started_at":1710330641,"expires_at":1710331240,"cancelled_at":null,"failed_at":null,"completed_at":null,"required_action":null,"last_error":null,"model":"gpt-4-turbo","instructions":null,"tools":[],"metadata":{},"temperature":1.0,"top_p":1.0,"max_completion_tokens":null,"max_prompt_tokens":null,"truncation_strategy":{"type":"auto","last_messages":null},"incomplete_details":null,"usage":null,"response_format":"auto","tool_choice":"auto","parallel_tool_calls":true}}

event: thread.run.step.created
data: {"id":"step_001","object":"thread.run.step","created_at":1710330641,"run_id":"run_123","assistant_id":"asst_123","thread_id":"thread_123","type":"message_creation","status":"in_progress","cancelled_at":null,"completed_at":null,"expires_at":1710331240,"failed_at":null,"last_error":null,"step_details":{"type":"message_creation","message_creation":{"message_id":"msg_001"}},"usage":null}

event: thread.run.step.in_progress
data: {"id":"step_001","object":"thread.run.step","created_at":1710330641,"run_id":"run_123","assistant_id":"asst_123","thread_id":"thread_123","type":"message_creation","status":"in_progress","cancelled_at":null,"completed_at":null,"expires_at":1710331240,"failed_at":null,"last_error":null,"step_details":{"type":"message_creation","message_creation":{"message_id":"msg_001"}},"usage":null}

event: thread.message.created
data: {"id":"msg_001","object":"thread.message","created_at":1710330641,"assistant_id":"asst_123","thread_id":"thread_123","run_id":"run_123","status":"in_progress","incomplete_details":null,"incomplete_at":null,"completed_at":null,"role":"assistant","content":[],"metadata":{}}

event: thread.message.in_progress
data: {"id":"msg_001","object":"thread.message","created_at":1710330641,"assistant_id":"asst_123","thread_id":"thread_123","run_id":"run_123","status":"in_progress","incomplete_details":null,"incomplete_at":null,"completed_at":null,"role":"assistant","content":[],"metadata":{}}

event: thread.message.delta
data: {"id":"msg_001","object":"thread.message.delta","delta":{"content":[{"index":0,"type":"text","text":{"value":"Hello","annotations":[]}}]}}

...

event: thread.message.delta
data: {"id":"msg_001","object":"thread.message.delta","delta":{"content":[{"index":0,"type":"text","text":{"value":" today"}}]}}

event: thread.message.delta
data: {"id":"msg_001","object":"thread.message.delta","delta":{"content":[{"index":0,"type":"text","text":{"value":"?"}}]}}

event: thread.message.completed
data: {"id":"msg_001","object":"thread.message","created_at":1710330641,"assistant_id":"asst_123","thread_id":"thread_123","run_id":"run_123","status":"completed","incomplete_details":null,"incomplete_at":null,"completed_at":1710330642,"role":"assistant","content":[{"type":"text","text":{"value":"Hello! How can I assist you today?","annotations":[]}}],"metadata":{}}

event: thread.run.step.completed
data: {"id":"step_001","object":"thread.run.step","created_at":1710330641,"run_id":"run_123","assistant_id":"asst_123","thread_id":"thread_123","type":"message_creation","status":"completed","cancelled_at":null,"completed_at":1710330642,"expires_at":1710331240,"failed_at":null,"last_error":null,"step_details":{"type":"message_creation","message_creation":{"message_id":"msg_001"}},"usage":{"prompt_tokens":20,"completion_tokens":11,"total_tokens":31}}

event: thread.run.completed
data: {"id":"run_123","object":"thread.run","created_at":1710330640,"assistant_id":"asst_123","thread_id":"thread_123","status":"completed","started_at":1710330641,"expires_at":null,"cancelled_at":null,"failed_at":null,"completed_at":1710330642,"required_action":null,"last_error":null,"model":"gpt-4-turbo","instructions":null,"tools":[],"metadata":{},"temperature":1.0,"top_p":1.0,"max_completion_tokens":null,"max_prompt_tokens":null,"truncation_strategy":{"type":"auto","last_messages":null},"incomplete_details":null,"usage":{"prompt_tokens":20,"completion_tokens":11,"total_tokens":31},"response_format":"auto","tool_choice":"auto","parallel_tool_calls":true}}

event: done
data: [DONE]

fixed with 8.5.0


UserStore throws JS Expn when signing up

Looks like there is a change to react-addons-update module. It now directly returns 'update' module.
Currently, it is doing:
import {update} from 'react-addons-update';
It should be doing:
import update from 'react-addons-update';

Fixed in e25e83c, thank you!


add helm chart.

ref: https://github.com/open-cluster-management-io/OCM/issues/34
Signed-off-by: morvencao<EMAIL_ADDRESS>

/hold

@yue9944882 I added chart release workflow in this PR to upload chart tarball to the helm-charts repo, but I have some questions, do I need to set PAT_TOKEN, if yes, what permission should grant to it? Write permission to the helm-charts repo?
Appreciate it if you could help in this.

@morvencao Can you help to update the solution in https://github.com/open-cluster-management-io/OCM/issues/34?

cc @qiujian16 for requesting a PAT token for @ocm-bot

I can set a org wide pat token so every repo can use？

/unhold

/lgtm


Docstring change only to PartitionConsumer.

As per the discussion in https://github.com/Shopify/sarama/issues/920,
I've added some verbiage to the docstrings around Close & AsyncClose
on interface PartitionConsumer.

This looks really nice, thanks. Just one typo and one other comment.

Thanks, Evan. Updated as per your suggestions.

Thanks!


Update to Swift 5

Hi! I love this library, will it be updated for Swift 5? Can we, its users, help in any way? Thank you.

You might be better off using the native iOS ways for arranging UI. This library is ok, but at some points just feels like an unnecessary wrapper. Maybe that's why the authour seems to have lost interest in continuing to keep it updated too.
If you really want to use it, you can make a local copy and customise it to your liking. It'll migrate easily to Swift 5.

I think LBTAComponents is a much, much better way of doing things and I hope I can continue to use it. @bhlvoong thank you very much for making it and sharing it here!

Actually it should be pretty easy to update. However, brian doesn't seem interested in doing so. I opened a PR for Swift 4.2 quite some time ago and no response there. Maybe just for it and update it yourself :)

I didn't know so many people were still interested in using this library.  I've diverged a little from the logic in these libraries so a full update would introduce a lot of breaking code....

@bhlvoong I can't speak for anyone but myself, but I'd be very happy to see a full update, despite the breaking changes.

Now compatible with Swift 5. However, I am deprecating this library in favor of LBTATools.


False positive unused_element in Dart 2.17

When a value for an optional parameter is only given in a super constructor invocation, it seems like the analyzer now considers that parameter unused:
class _Foo {
  final String x;
  final int? y;

  _Foo(this.x, [this.y]); // Diagnostic: Value for parameter y isn't ever given
}

class Bar extends _Foo {
  Bar(String x) : super(x, 0); // but it is given here
}

On Dart 2.17, analyzing that file reveals this false-positive:
Analyzing foo.dart...                  1.2s

  error • foo.dart:5:22 • A value for optional parameter 'y' isn't ever given. Try removing the
          unused parameter. • unused_element

1 issue found.

As far as I remember that didn't happen in Dart 2.16.

@srawlins

Thanks for filing!

@simolus3 this is not a false positive. This tip is shown when a parameter is never called and not only if it's used into the class.


Make bot more resilient against server errors

Currently the bot will fail and hang on server errors.

After 3 retries it should just gracefully bail out and let the schedule restart it.

tagged with v0.9.16


Remove trailing whitepaces from .py files

Part of https://github.com/quantumlib/OpenFermion/issues/416

@kevinsung I haven't added or removed code. All I did was format. Is this one of those false positives you were talking about?


Middleware to switch the upload handler and use HDFSfileUploadHandler for document upload

What changes were proposed in this pull request?
Middleware to switch the upload handler and use HDFSfileUploadHandler for document upload. When the chunked_file_uploader and task_server config is enabled, the document uploads tries to use FineUploaderChunkedUploadHandler. Since user's don't upload large files in document upload's page (small json files with saved queries are uploaded), the chunked_file_upload implementation isn't needed. So adding a middleware to switch the upload handler in Documents upload page to HDFSfileUploadHandler even when the HDFS, S3, Azure FS might use the FineUploaderChunkedUploadHandler.
How was this patch tested?
Tested on mac, docker based system. Tested uploading a document concurrently during HDFS, S3, Azure file uploads.
Please review Hue Contributing Guide before opening a pull request.

Why are we adding a dedicated middleware only for this specific use-case? Can't we do this closer to the core document import code section?


web_app: Fix inconsistent naming

A few names where missed in the #1319 refactor. This should complete the refactor.
Ref: #1318

CC @DavidKorczynski

The changes should be reflected on introspector.oss-fuzz.com in ~18 hours


Feature/mark users as spammy [OSF-6878]

Purpose
Allow admin users to remove Spam users and mark all of their projects as Private. This is a fairly safe a quick way to deal with individuals who create a lot of spam projects on a small number of accounts. If an overzealous admin accidentally marks a non-spam project as private, that is easily changed.
Changes

Add a 'Remove Spam User' button to the admin user editor
When clicked and confirmed, mark all public non-registration nodes owned by that user as private, then call the existing Delete User function
Hidden logs on the nodes about them being marked as private, and admin logs about marking the nodes private on the admin app
Test

Side effects
If a user is a contributor to a real project that is public, that project will be marked private. Any contributor to the project with sufficient permission will still be able to make the project public again. The spam user will not, of course.
Ticket
https://openscience.atlassian.net/browse/OSF-6876

Pass complete, no blockers. I would like some feedback on why the webpack version was bumped up, but otherwise LGTM. No bugs found ⭐

I fixed the indentation and the cryptic message while I was here.


Eraser tool missing in Drawing pad

Is your feature request related to a problem? Please describe.
We have to directly clear the whole pad instead of erasing one by one.
Describe the solution you'd like.
I would like to add an eraser tool which will enable users to erase any drawing one by one.
@swapnilsparsh Can i please work on this issue under GSSoC'24?
I have already one PR merged in the same repo :)
Describe alternatives you've considered.
An eraser tool
Add any other context or screenshots about the feature request here.

@AtharvKasar04 All the best 👍🏻

@AtharvKasar04 Any update on this ?

Yess @swapnilsparsh actually My end-sems exams are going on and i replied regarding this in my other issue as well, Apologies for the delay caused but I'll start working on the issues ASAP in just 1-2 days

@AtharvKasar04 Any update on this ?


ncaab boxscore not pulling with IDs

Describe the bug
boxscore is not consistently pulling game info (IndexError: list index out of range).
To Reproduce
Sample code which causes an issue.
from sportsipy.ncaab.boxscore import Boxscore
game_data1 = Boxscore('2021-03-28-14-gonzaga')

#issue also exists for example from the readthedocs website:
game_data = Boxscore('2018-04-02-21-villanova')

Expected behavior
Script should create detailed game boxscore.
Desktop (please complete the following information):

OS: MacOS 12.2.1 (Monterey)
Sportsipy Version: 0.6.0

Additional context
Wondering if this is error with HTML formatting. The following script does work:
from sportsipy.ncaab.boxscore import Boxscore
game_data2 = Boxscore('2016-02-02-michigan')

Code is being run in Google Colab.

i get the same issue, and think you are right it is something to do with format of html

i'll try to put a pull request at some point. it's actually not a bad fix. seems to be that section_header needs to be table_wrapper in scheme.

Any solve @jkoestner? Don't want to open another issue as there are a handful already.

@reaganking yeah there is quite a few issues listed as you saw, and there was actually even an alternative solution that i didn't see #598.
It's a pretty easy fix, just changing 2 lines of code shown in #720.


Adding the pod affinity and Anti-affinity test cases under kube-batch e2e tests

Adding test cases for Pod Affinity/Anti-Affinity under the kube-batch e2e test cases.
refer PR #749

/ok-to-test

/assign @TommyLike

Please review #825 and try your patch later.

/retest

/retest


Get this package building on conda-forge

This is a key step toward https://github.com/brian-rose/climlab/pull/163

a PR is now open for this here: https://github.com/conda-forge/staged-recipes/pull/18985


Ionic 2 project working fine in browser but will not build for Android

Short description of the problem:
When I develop with "ionic serve", the app works fine.
But when I run "ionic build android", then got errors. I don't know why, it works fine in browser but failed in build.
My problem just like this{:target="_blank"}
What behavior are you expecting?
I think if working fine in browser, it should build fine also.
If something not right, please show error in browser when developing.
Steps to reproduce:

ionic serve
works fine in browser
ionic build android

Got errors.
Code is like this:
import { Component } from '@angular/core';

import { NavController, ModalController } from 'ionic-angular';
import { FormBuilder, Validators, FormGroup} from '@angular/forms';

import { TabsPage } from '../tabs/tabs';
import { NetSettingPage } from '../net-setting/net-setting';

@Component({
  selector: 'page-login',
  templateUrl: 'login.html'
})
export class LoginPage {

  loginForm: FormGroup;

  constructor(form: FormBuilder, public navCtrl: NavController, public modalCtrl: ModalController) {
    this.loginForm = form.group({
        'username': ['', Validators.compose([Validators.required, Validators.minLength(4)])],
        'password': ['', Validators.compose([Validators.required, Validators.minLength(4)])],
        'rememberMe': [false]
    });
  }

  login(evt,username,password,rememberMe) {
    console.debug("do login...");
    this.navCtrl.setRoot(TabsPage);
  }

  netSetting() {
    console.debug("do net setting...");
    let modal = this.modalCtrl.create(NetSettingPage);
    modal.present();
  }
}

Error is like below:
[23:48:19]  ionic-app-scripts 0.0.39
[23:48:19]  build prod started ...
[23:48:19]  clean started ...
[23:48:19]  clean finished in 4 ms
[23:48:19]  copy started ...
[23:48:19]  ngc started ...
[23:48:20]  copy finished in 662 ms
[23:48:20]  lint started ...
[23:48:22]  lint finished in 2.29 s
[23:48:35]  Error: Error at /Users/samliu/gits/jing-xi-h5/.tmp/pages/login/login.ngfactory.ts:1054:68
[23:48:35]  Property 'username' does not exist on type 'LoginPage'.
[23:48:35]  Error at /Users/samliu/gits/jing-xi-h5/.tmp/pages/login/login.ngfactory.ts:1054:90
[23:48:35]  Property 'password' does not exist on type 'LoginPage'.
[23:48:35]  Error at /Users/samliu/gits/jing-xi-h5/.tmp/pages/login/login.ngfactory.ts:1054:112
[23:48:35]  Property 'rememberMe' does not exist on type 'LoginPage'.

[23:48:35]  Error at /Users/samliu/gits/jing-xi-h5/.tmp/pages/net-setting/net-setting.ngfactory.ts:1054:69

[23:48:35]  Property 'remote' does not exist on type 'NetSettingPage'.
[23:48:35]  Error at /Users/samliu/gits/jing-xi-h5/.tmp/pages/net-setting/net-setting.ngfactory.ts:1054:89
[23:48:35]  Property 'local' does not exist on type 'NetSettingPage'.
[23:48:35]  Error at /Users/samliu/gits/jing-xi-h5/.tmp/pages/net-setting/net-setting.ngfactory.ts:1054:108
[23:48:35]  Property 'isRemote' does not exist on type 'NetSettingPage'.
[23:48:35]  Error at /Users/samliu/gits/jing-xi-h5/.tmp/app/app.module.ngfactory.ts:443:133
[23:48:35]  Argument of type 'IonicErrorHandler' is not assignable to parameter of type 'ErrorHandler'.
[23:48:35]  Property 'handleError' is missing in type 'IonicErrorHandler'.
[23:48:35]  ngc failed
[23:48:35]  ionic-app-script task: "build"
[23:48:35]  Error: Error

npm ERR! Darwin 16.1.0
npm ERR! argv "/usr/local/bin/node" "/usr/local/bin/npm" "run" "build"
npm ERR! node v6.3.1
npm ERR! npm  v3.10.3
npm ERR! code ELIFECYCLE
npm ERR! ionic-hello-world@ build: `ionic-app-scripts build`
npm ERR! Exit status 1
npm ERR!
npm ERR! Failed at the ionic-hello-world@ build script 'ionic-app-scripts build'.
npm ERR! Make sure you have the latest version of node.js and npm installed.
npm ERR! If you do, this is most likely a problem with the ionic-hello-world package,
npm ERR! not with npm itself.
npm ERR! Tell the author that this fails on your system:
npm ERR!     ionic-app-scripts build
npm ERR! You can get information on how to open an issue for this project with:
npm ERR!     npm bugs ionic-hello-world
npm ERR! Or if that isn't available, you can get their info via:
npm ERR!     npm owner ls ionic-hello-world
npm ERR! There is likely additional logging output above.

npm ERR! Please include the following file with any support request:
npm ERR!     /Users/samliu/gits/jing-xi-h5/npm-debug.log
Caught exception:
 undefined

Mind letting us know? https://github.com/driftyco/ionic-cli/issues

Which @ionic/app-scripts version are you using?
Other information: (e.g. stacktraces, related issues, suggestions how to fix, stackoverflow links, forum links, etc)

Fixed. Cause the login(evt,username,password,rememberMe) function params wrong.
Remove unnecessary params it build works.


Make status in responses optional

We are already only checking the StatusCode if it has a value. So the following was already accepted:
samlp:Statussamlp:StatusCode/</samlp:Status>
This commit also accepts the entire Status node not existing in the response.
This occurs if only the Assertion in a SAMLResponse is signed and the reduce_to_signed_xml function removes the unsigned status element.
If this occurs the reduced response will not pass the serialization round-trip due to the now missing Status node being required.

I approved this a while back, but you never merged it, so I'm coming back to merge 😜
Thanks for your contribution @erikescher 🎉

Hey @erikescher, not sure if either of you were planning on making any more contributions or not, but just in case, I wanted to let you know that I've updated the build instructions in the README to lay the groundwork for reproducible builds.
Right now I'm just using it for reproducible dev environments and CI builds, which I hope will make contributing less of a pain in the butt 😜

Ah I didn't see the approval (and still don't?), otherwise I would have merged it already.
Not sure what's going on, as it did look weird, but also showed up as approved.

I used a simple apt install libxml2 openssl xmlsec1 libxmlsec1* on Ubuntu 20.04 which was already pretty painless :smile: .
Scares away lots of people, and having a reproducible dev env with the same versions of all relevant libraries seemed like it would prevent weird system library specific issues. If you have everything setup, and CI passes, then all is well 👍


How can i use fmi4cpp in VS2013

Thanks for your generous replying!

I've never used VS myself, so I can't offer a very specific answer.
I guess you have some options:

Build fmi4cpp from commandline (see .github/workflows for example) and include/link manually.
Recommended. Use fmi4cpp as a CMake submodule (Assuming you can do that in VS)
Use conan (https://github.com/markaren/FMI4cpp-conan). However I see that this receipt out of date.

There is also an old unmaintained version available on vcpkg.


[Feature request] Consider using DAE apply effect function when DAE is installed and active

Hello,
A lot of foundry users use DAE/Times Up.
Using DAE apply effect function would also make use of the special DAE fields such as:

Force display on token
Stackable (especially this one)
Special duration

The DAE function is: https://gitlab.com/tposney/dae/-/blob/master/src/module/dae.ts#L1331

I believe all of the data from the origin effect is transferred to the target tokens, I wouldn't have expected the DAE data to rely on a specific application.
I'll take a look to double check that. I'm not terribly interested in doing any module detection to change application behavior but I might be convinced otherwise upon investigation

@akrigline Might be only for the Stackable option if not for the rest.
I tested that. With DAE application, it's ok, but not with this module.

@akrigline Sorry, didn't mean to close the issue -_-


get all records of type...

Hi,
passing through the Ponsu documentation. Can't seem to find ...is there an option for fetching all the records of one content type?
For instance, I have a type Author. Can I retreive all authors with 1 GET call?
Best,
Tomaz

Hi @tomazbracic -
See here for reference to this endpoint: https://docs.ponzu-cms.org/HTTP-APIs/Content/#get-contents-by-type


WIP - Chore/initial working tests

What: Initial setup of src code and working tests

Why: There isn't any working code in repo yet.

How: Copying existing files from existing apps and updating them to generic package to be used by other projects.

Checklist:

[ ] Documentation
[ ] Tests
[ ] Ready to be merged
[ ] Added myself to contributors table

:tada: This PR is included in version 1.0.0 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


How to evaluate for a limited range of experiment

Hi,
Thank you for sharing your code,
if I have detection boxes in a limited range, for example, I restricted my range to 0 - 50 meters in the x-direction, so while evaluation, do I have to remove boxes in ground truth manually after this range?
Thanks In advance
Best Regards,
Ansab

@ansabsheikh9
from my understanding :  yes. clean up the ground truth labels. delete all objects not within the limited range. without deleting these lines in the labels you will get additional false negatives, your recall suffers and the evaluation is not accurate.

thank you for your prompt reply.


Feature proposal:Provide BackgroundDownloader in Windows App SDK

Describe the bug
Please provide BackgroundDownloader in Windows App SDK
In the Windows UWP namespace, there is an API called BackgroundDownloader that can download files in the background, however, this API can only run in the container, which is limited in desktop applications and difficult to call. I hope the Windows App SDK team will seriously consider redesigning a BackgroundDownloader API for downloading files in the Windows App SDK. This API breaks through the limitations of UWP BackgroundDownloader and can download files smoothly. When downloading files, you can call the newly added delivery optimization interface of Windows 10 1809.
在 Windows UWP 命名空间中，有一个 API 叫 BackgroundDownloader 可以在后台下载文件，然而，这个 API 只能在容器中运行，这在桌面应用中存在限制，很难调用。希望 Windows App SDK 团队能认真考虑一下，重新设计一个在 Windows App SDK 下载文件的 BackgroundDownloader API，该 API 突破 UWP BackgroundDownloader 的限制，可以顺利下载文件，下载文件时，可以调用 Windows 10 1809 新添加的传递优化接口。
UWP BackgroundDownloader API:https://learn.microsoft.com/zh-cn/uwp/api/windows.networking.backgroundtransfer.backgrounddownloader?view=winrt-22621
Desktop app use BackgroundDownloader API problem:https://github.com/microsoft/microsoft-ui-xaml/issues/6952
Delivery optimization API : https://learn.microsoft.com/zh-cn/windows/win32/api/_delivery_optimization/
Steps to reproduce the bug
See describe
Expected behavior
Provide Microsoft.Windows.Networking.Backgroundtransfer namespace and BackgroundDownloader class API
Screenshots
None
NuGet package version
Windows App SDK 1.5.3: 1.5.240428000
Packaging type
Packaged (MSIX)
Windows version
Windows 11 version 22H2 (22621, 2022 Update)
IDE
Visual Studio 2022
Additional context
None

Just to ask, is BITS not viable for you?
If you just don't like the COM API then I totally understand.

Just to ask, is BITS not viable for you? If you just don't like the COM API then I totally understand.

Compared to bits, we found that delivery optimization supports p2p, and the minimum supported version of delivery optimization is the same as the minimum supported version of Windowsappsdk, and is widely used for Windows updates and store app downloads.
Also, I don't like to call the com api directly because it's a pain to write with net core comwrappers

I did some tests and I could use BackgroundDownloader in an unpackaged Desktop app with CreateAppContainerProfile as explained in MSDN (https://learn.microsoft.com/en-us/windows/win32/secauthz/appcontainer-for-legacy-applications-)
But it is complicated : I added
<WindowsAppSDKSelfContained>true</WindowsAppSDKSelfContained>
otherwise I got
ERROR 0x80070490: Bootstrapper initialization failed while looking for version...
then I relaunch the app with CreateProcess and STARTUPINFOEX to start it inside the AppContainer if isAppContainer is false at startup
... and I get 0x80070005 (E_ACCESSDENIED)  when I try to download a file (maybe Internet capability...)

... and I get 0x80070005 (E_ACCESSDENIED) when I try to download a file (maybe Internet capability...)

That all depends on where you are trying to download it to. When you are running in an AppContainer, you don't have write access to the majority of your user profile. The profile is running as low integrity after all. The only guaranteed writable location you have is actually the AppContainer profile for the application.

... and I get 0x80070005 (E_ACCESSDENIED) when I try to download a file (maybe Internet capability...)

That all depends on where you are trying to download it to. When you are running in an AppContainer, you don't have write access to the majority of your user profile. The profile is running as low integrity after all. The only guaranteed writable location you have is actually the AppContainer profile for the application.

Yes, I tried to download to KnownFolders.PicturesLibrary (like the MSDN sample), although I added the ACL (FileSystemRights.FullControl), but useless apparently
Now I tried with GetAppContainerFolderPath and I could create a file... but it is empty with error 0x80070490, which seems to be ERROR_NOT_FOUND from Google...

Yeah, the security principle you want is all application packages.

It is badly named because it comes from the Windows 8 days where packages and app containers were not separable.
For the HRESULT, the there indicates that it is a Windows API error code. From the System Error Codes documentation, error 1160 (0x490) is indeed ERROR_NOT_FOUND. But that doesn't actually mean much here.

BITS didn't work when trimming was enabled last time I tried.

BITS didn't work when trimming was enabled last time I tried.

trimming?

yes. BITS doesn't work when the property PublishTrimmed is set to true. Also, when using HttpClient to save a file in a controlled folder I get an exception and I'm unable to do so until I approve my app in windows security. Doesn't happen with BITS, so I guess anyone could save files to those folders if they want to without asking permission 😬

yes. BITS doesn't work when the property PublishTrimmed is set to true. Also, when using HttpClient to save a file in a controlled folder I get an exception and I'm unable to do so until I approve my app in windows security. Doesn't happen with BITS, so I guess anyone could save files to those folders if they want to without asking permission 😬

Based on the description you provided, and based on my own use of BITS, provide a feasible solution.
You're probably using the built-in COM support, and if you need to support cropping and support AOT, you'll need to switch to ComWrappers, which is an example of my code.
https://github.com/Gaoyifei1011/GetStoreApp/blob/main/GetStoreApp/WindowsAPI/ComTypes/IBackgroundCopyCallback.cs
https://github.com/Gaoyifei1011/GetStoreApp/blob/main/GetStoreApp/WindowsAPI/ComTypes/IBackgroundCopyManager.cs
https://github.com/Gaoyifei1011/GetStoreApp/blob/main/GetStoreApp/WindowsAPI/ComTypes/IBackgroundCopyJob.cs
https://github.com/Gaoyifei1011/GetStoreApp/blob/main/GetStoreApp/WindowsAPI/ComTypes/IBackgroundCopyError.cs
https://github.com/Gaoyifei1011/GetStoreApp/blob/main/GetStoreApp/Services/Controls/Download/BitsService.cs

Thank you!


URGENT - Convert endpoints to GET

For better performance and to be able to achieve this #60 we need to have fetch endpoints as GET instead of POST.
For dashboard

fetch courses
fetch units
fetch topics
fetch media contents

For client

fetch units
fetch topics
fetch media contents
fetch individual media content.

@brianmuks this is blocking #60 it would be great if we can start on this especially dashboard links.

@OlivierJM I have take note of this and I will start working on it asap.

I hit a broker on this one. Submitting a solution tonight.


Give explicit reg exp for filtering comments for minification.

Fixes bug #3283: moment.min.js download contains comments .

Heads up. Because we came under JS Foundation management, we need a CLA signed for this to be merged. Should be just a couple clicks.

@skfd can you please sign the CLA. I can not proceed otherwise.

closing as stale

That might have been fixed upstream. Can be fixed by updating uglify package.

Can we get this merged?  https://github.com/moment/moment/issues/3461 has been closed but should be reopened.

Merged in d28a819dc668f107566f306f827df07d43e30287


Removed configure

When I made the workflow, I didn't notice that there wasn't a configure script. So, here's a fix! :slightly_smiling_face:

I fixed this one. Thanks for the help.


Module appregistry is not a registered callable module on material tab navigator

module appregistry is not a registered callable module on material tab navigator

Closing since not related to this library


Implement Mailgun's o:deliverytime to schedule email delivery

Mailgun has a handy o:deliverytime property which allows you to schedule email delivery in the future.
Personally I needed it to send a feedback request email after users complete some task.
Here is a quick example:
one_hour_from_now =
  DateTime.utc_now()
  |> DateTime.add(3600)

email
  |> MailgunHelper.deliverytime(one_hour_from_now)

CircleCI doesn't like sigils, closing this for an alternative implementation without sigils.


Create hands on loops and if-else in python.py

simple calculator using python

@srinidh-007 can u please look and approve it.

@JayanthSriram27 can u please merge my commits?

@ishitakarandikar please check it and approve it.


Fix problem with initial retrieval of cachedNames

Fix issue where initial retrieval of cachedNames returns an empty object which is considered to have a property with the same name

Thank you @ramlmn! :tada:


Use GCS Cache not Zenodo API in CI

Direct access to the Zenodo API is pretty slow and flaky. We have a cache of the raw data stored on GCS, and the Datastore can prioritize accessing that instead, while creating a local cache on the GitHub runner, which will stick around for 2 weeks. We may be able to set that cache to last longer too. Switching to using the GCS Cached version of our raw inputs would incur a small data egress expense, whenever the GitHub runner cache expires and it has to be repopulated, but would make our tests much less likely to fail because of fragile external API issues.
In combination with the EIA API issues outlined in #1343 these Zenodo API failures are now resulting in CI failing the majority of the time, without anything being wrong with our code, which seriously degrades the usefulness of running CI.
Tasks

[x] Authenticate the GitHub runner to read data from gs://zenodo-cache.catalyst.coop
[x] In the tox-pytest workflow set ZENODO_CACHE_PATH to gs://zenodo-cache.catalyst.coop
[x] Whenever the CI environment variable is set, use ZENODO_CACHE_PATH to initialize the datastore for the tests.
[x] Figure out how to make the GCS credentials available to Python code running inside the tests...
[x] Authenticate the Zenodo Cache Manager within Tox/pytest so it can upload new archives if needed.
[x] Set the Zenodo API specific tests to skip (they're currently xfail, but we'll want them in the datastore specific repo)
[ ] Extend the cache expiration time for the local datastore on the GitHub runner.

As far as I can tell from the GitHub Actions caching documentation the cache eviction policy is hard coded:

GitHub will remove any cache entries that have not been accessed in over 7 days. There is no limit on the number of caches you can store, but the total size of all caches in a repository is limited to 10 GB.

This issues was closed by #1858.


Obsidian on iOS fails to load plugin

The following error pops up when trying to enable the plugin. I'm on the latest Obsidian release available (1.6.7):

I apologize for not sending any logs; I have no idea where these are stored on my phone.

Fixed in https://github.com/mnaoumov/obsidian-better-markdown-links/releases/tag/2.4.0

Thanks for the quick response!


Include stac_version in include recommendations

Proposed Changes:

Add stac_version to the list of fields recommended to include by default

PR Checklist:

[x] This PR has no breaking changes.
[x] I have added my changes to the CHANGELOG or a CHANGELOG entry is not required.

Closing this, as #5 should supersede it.


Is redraw necessary on panel refresh?

coqtail#panels#refresh runs :redraw at the end.
https://github.com/whonore/Coqtail/blob/358747255db85579498dfc6e03dcd808d5b81d34/autoload/coqtail/panels.vim#L324
This has various side effects such as flickering cursor (Vim) and disappearing IncSearch highlights (both Vim and NeoVim), which are quite annoying.
I have been using Coqtail for a few days with that line removed, and it seems to work well.
So I think it makes sense to remove that line if there is no specific need for it (which I could not find from git history).

The origin of that redraw command seems to date back to the first commit, which was copied from when I forked Coquille, so it very well may not be necessary. I would imagine that the worst removing it could do is to slightly delay updating the highlighting for the checked region, but there's already a bit of delay because of how the async code works so it should be fine. Maybe keep testing it a couple more days and I will too and if everything seems fine we can remove it.

I may have spoken too soon because I'm still seeing the error even with redraw, though much less frequently.


[Identity] AuthorizationCodeCredential possibly misbehaving with personal accounts.

Our friend, Nikitha Udaykumar, has tested our AuthorizationCodeCredential, and she has the following feedback:

I tested the AuthorizationCodeCredential sample using app registrations on a demo test account. It worked fine on my office laptop.
My work laptop browser holds multiple microsoft accounts, that is, my work account and my testing demo accounts. On running the sample, it loads the sign in page with the user account options and when I select the demo account for testing it runs fine with an OK response and logs the access token.
However, I tried this on my personal mac where my microsoft work account is logged into . When I run the sample, I directly land on the error page instead of getting the user account options to sign in. The error says that my work account does not exist in my demo tenant.
Hope this helps!!

I want to investigate this. I’m not sure if it’s a bug, but if it’s not a bug we should add it to our new troubleshooting guide.

I couldn’t reproduce this. I believe that Nikitha was logged into her personal account while she was trying this credential in her personal mac, and the login flow therefore couldn’t find her personal account in the demo tenant. I’m closing this issue.


Expanding RingVM htable functionalities

Hello Ring Team
After this conversation with Ilir Liburn while facing a problem in returning a hashtable via Ring C API.
I decided to expose the hash table functionalities to the ringworld to facilitate extension developers' work.
So I expanded its functionalities in order to expose them.
My update includes :-

Expanding the item's data types
Adding insert/update/delete/clone/compare/find functions
Adding functions facilitates traversing the table
Adding functions exposes some information about the table like haskey? and getkeys
Fix issues like the counter not decrementing when an item is deleted and the insert function not checking whether the new key already exists inside the table resulting in table pollution

My updates don't break any old functions.
I have tested it well on a Linux machine and it works as expected.
I am currently working on the extension, and I already finished it but I wanted to send PRs separately to avoid confusing the reviewers.
Best regards,
Abdallah Mohamed.

Hello Abdallah
I think that these updates should be developed as an extension that can be installed using RingPM
So, I am not interested in integrating these updates with Ring Compiler/VM
If you need it, you can have it in your fork.
Greetings,
Mahmoud

Hello Mahmoud
I'm currently working on an extension for Ring, this extension has a function that needs to return a hashtable ( That's very common, and future extensions definitely will need that ).
So from that standpoint, I decided to do it myself after discussing with Ilir to facilitate the development of future extensions, and those functionalities are very useful for the VM itself.
Without expanding the core hashtable functionalities, the extension developers wouldn't be able to deal with it and return it to the high-level.
The case I'm trying to explain is as follows: An extension needs to return a hashtable, so it uses those functions and returns a managed pointer. On the other hand, the high-level developers interact with it using an embedded extension with the VM like list_e or a separate extension, that extension also relies on the hashtable core functionalities.
So I ask you to review your decision again or tell us an appropriate solution for this problem.
Thanks.

Hello Abdallah
Don't update Ring VM HashTable implementation (It's designed to be a small implementation for specific purpose, i.e. to be used by Ring Compiler/VM to manage tables for functions/classes) - Being small implementation is a design goal.
Solution: Just keep all of the code that you need in your extension folder, develop the extension as an external extension in your GitHub account, once finished create a package for your extension then we can add it to RingPM registry: https://github.com/ring-lang/ring/tree/master/tools/ringpm/registry
Greetings,
Mahmoud


10 gb logs :trollface:

mod throws this exception whenever a player is loaded regardless if player rendering is enabled or not
[14:23:17] [Render thread/ERROR]: Error executing task on Client
java.lang.IllegalStateException: Invalid entity data item type for field 21 on entity class_745['Steve'/362448, l='ClientLevel', x=69, y=69.00, z=69]: old=false(class java.lang.Boolean), new={}(class net.minecraft.class_2487)
	at net.minecraft.class_2945.method_12785(class_2945.java:204) ~[client-intermediary.jar:?]
	at net.minecraft.class_2945.method_12779(class_2945.java:191) ~[client-intermediary.jar:?]
	at net.minecraft.class_634.method_11093(class_634.java:529) ~[client-intermediary.jar:?]
	at net.minecraft.class_2739.method_11808(class_2739.java:46) ~[client-intermediary.jar:?]
	at net.minecraft.class_2739.method_11054(class_2739.java:10) ~[client-intermediary.jar:?]
	at net.minecraft.class_2600.method_11072(class_2600.java:22) ~[client-intermediary.jar:?]
	at net.minecraft.class_1255.method_18859(class_1255.java:156) ~[client-intermediary.jar:?]
	at net.minecraft.class_4093.method_18859(class_4093.java:23) ~[client-intermediary.jar:?]
	at net.minecraft.class_1255.method_16075(class_1255.java:130) ~[client-intermediary.jar:?]
	at net.minecraft.class_1255.method_5383(class_1255.java:115) ~[client-intermediary.jar:?]
	at net.minecraft.class_310.method_1523(class_310.java:1175) ~[client-intermediary.jar:?]
	at net.minecraft.class_310.method_1514(class_310.java:802) ~[client-intermediary.jar:?]
	at net.minecraft.client.main.Main.main(Main.java:250) ~[minecraft-1.20.1-client.jar:?]
	at net.fabricmc.loader.impl.game.minecraft.MinecraftGameProvider.launch(MinecraftGameProvider.java:468) ~[fabric-loader-0.14.21.jar:?]
	at net.fabricmc.loader.impl.launch.knot.Knot.launch(Knot.java:74) ~[fabric-loader-0.14.21.jar:?]
	at net.fabricmc.loader.impl.launch.knot.KnotClient.main(KnotClient.java:23) ~[fabric-loader-0.14.21.jar:?]
	at org.prismlauncher.launcher.impl.StandardLauncher.launch(StandardLauncher.java:88) ~[NewLaunch.jar:?]
	at org.prismlauncher.EntryPoint.listen(EntryPoint.java:126) ~[NewLaunch.jar:?]
	at org.prismlauncher.EntryPoint.main(EntryPoint.java:71) ~[NewLaunch.jar:?]

Heya @kirikarma, can't say I've seen this before. I don't see antisocial in the stacktrace at all. What all mods do you have installed? What server are you playing on?

Are you certain this mod only occurs when Antisocial is installed? All functions are a no-op when rendering isn't being skipped and I don't mess with packets in anyway (which is where is crash is occurring) so I really doubt Antisocial is the cause...

Yeah, I don't add any extra "entity data items." Feel free to comment with further info but I don't believe my mod is responsible for this so I'm closing this for now.

Forgot to respond sorry :skull:

No worries 🙂


Create new profile

Create a new profile for David Kariuki David Kariuki - Github
Check List (Check all the applicable boxes)

[X ] My code follows the code style of this project.
[X ] My change requires changes to the documentation.
[ X] I have updated the documentation accordingly.
[ X] All new and existing tests passed.
[ X] This PR does not contain plagiarized content.
[ X] The title of my pull request is a short description of the requested changes.

Thank you


Mrtk development

Overview
Changes

Fixes: # .

 Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.:x: kkakosim sign nowYou have signed the CLA already but the status is still pending? Let us recheck it.

wrong fork


Add Team Change Management Features

Is your feature request related to a problem?
In Team Exercises, a team consists of several students. Many changes occur so that the team adds new students or loses students. In addition, the team can also decide to stop completely. These different actions cannot be fully logged, so it is not possible to create statistics on how the behavior of the teams is and how it can be influenced in the future.
Describe the solution you'd like
Here is an extension of the functionality: Team Change Management would be helpful, where a team can be in different states, which can be mapped as an Enum: Pending/Approved/Cancelled. This status is then mapped to an entity TeamHistory and linked with a 1 to n association with the Team, so that per change a logging of date and time as well as the reason for the change can be made.
For example, an evaluation can be run at the end of the semester to check how many teams of those originally enrolled have made the changes: Changes to team Members, Team Cancellation, etc. This evaluation can help to improve the quality of the process.
Describe alternatives you've considered
No response
Additional context
No response

I think this is out of scope at the moment


Can't run project: artifacts.zip & engine.zip fail to download on Linux

Hover doctor
$ hover doctor
hover: Hover version v0.46.3 running on linux
hover: Sharing packaging tools
hover: darwin-bundle is supported
hover: darwin-dmg is supported
hover: To package darwin-pkg these tools are required: mkbom,xar
hover: Install bomutils from your package manager or from https://github.com/hogliux/bomutils
hover: Install xar from your package manager or from https://github.com/mackyle/xar
hover: To still package darwin-pkg without the required tools installed you need to run hover with the `--docker` flag.
hover: To package linux-appimage these tools are required: appimagetool
hover: Install appimagetool from your package manager or from https://github.com/AppImage/AppImageKit#appimagetool-usage
hover: To still package linux-appimage without the required tools installed you need to run hover with the `--docker` flag.
hover: To package linux-deb these tools are required: dpkg-deb
hover: You need to be on Debian, Ubuntu or another distro that uses apt/dpkg as package manager to use this. Installing dpkg on other distros is hard and dangerous.
hover: To still package linux-deb without the required tools installed you need to run hover with the `--docker` flag.
hover: linux-pkg is supported
hover: To package linux-rpm these tools are required: rpmbuild
hover: You need to be on Red Hat Linux or another distro that uses rpm as package manager to use this. Installing rpmbuild on other distros is hard and dangerous.
hover: To still package linux-rpm without the required tools installed you need to run hover with the `--docker` flag.
hover: To package linux-snap these tools are required: snapcraft
hover: Install snapd from your package manager or from https://snapcraft.io/docs/installing-snapd
hover: To still package linux-snap without the required tools installed you need to run hover with the `--docker` flag.
hover: To package windows-msi these tools are required: wixl
hover: Install msitools from your package manager or from https://wiki.gnome.org/msitools/
hover: To still package windows-msi without the required tools installed you need to run hover with the `--docker` flag.
hover:
hover: Sharing flutter version
Flutter 2.2.2 • channel beta • https://github.com/flutter/flutter.git
Framework • revision d79295af24 (23 hours ago) • 2021-06-11 08:56:01 -0700
Engine • revision 91c9fc8fe0
Tools • Dart 2.13.3
hover: Flutter engine commit: https://github.com/flutter/engine/commit/91c9fc8fe011352879e3bb6660966eafc0847233
hover: Finding out the C compiler version
gcc (GCC) 11.1.0
Copyright (C) 2021 Free Software Foundation, Inc.
This is free software; see the source for copying conditions.  There is NO
warranty; not even for MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.

hover: Sharing the content of go.mod
module github.com/siavashs/kubeforward/go

go 1.16

require (
	github.com/go-flutter-desktop/go-flutter v0.43.0
	github.com/pkg/errors v0.9.1
)
hover: Sharing the content of hover.yaml
application-name: ""
executable-name: ""
package-name: ""
organization-name: com.kubeforward
license: ""
target: lib/main_desktop.dart
branch: ""
cache-path: ""
opengl: ""
engine-version: ""
hover: Sharing the content of go/cmd
go/cmd/main.go	go/cmd/options.go

Error output

Using hover run to run my application, I get the following error:
over: Downloading engine for platform linux-debug_unopt at version 91c9fc8fe011352879e3bb6660966eafc0847233...
Download completed in 0.29s
hover: zip: not a valid zip file
Download completed in 0.13s
hover: zip: not a valid zip file
hover: Failed to copy downloaded libflutter_engine.so: lstat /tmp/hover-engine-download381905890/engine/libflutter_engine.so: no such file or directory

Looking at the temp download directory and examining the files:
$ ls /tmp/hover-engine-download381905890/
artifacts.zip  engine.zip

$ file /tmp/hover-engine-download381905890/*.zip
/tmp/hover-engine-download381905890/artifacts.zip: XML 1.0 document, ASCII text, with no line terminators
/tmp/hover-engine-download381905890/engine.zip:    XML 1.0 document, ASCII text, with no line terminators

$ cat /tmp/hover-engine-download381905890/*.zip
<?xml version='1.0' encoding='UTF-8'?>
  <Error>
    NoSuchKey
    <Message>The specified key does not exist.</Message>
    No such object: flutter_infra/flutter/91c9fc8fe011352879e3bb6660966eafc0847233/linux-x64/artifacts.zip
  </Error>

<?xml version='1.0' encoding='UTF-8'?>
  <Error>
    NoSuchKey
    <Message>The specified key does not exist.</Message>
    No such object: flutter_infra/flutter/91c9fc8fe011352879e3bb6660966eafc0847233/linux-x64/linux-x64-embedder
  </Error>

I think they wanted changed the path to flutter_infra_release. Maybe that's related.

It's the problem indeed


Bug in MODEL download directory and launching ollama service  in Linux

I write this post to add more information:
1 - As you mentioned : I edited sudo systemctl edit ollama.service

And the /media/Samsung/ollama_models is empty....

So seems here a bug ( as said before the doc says you have to change the ollama.service file)
2 - ollama serve vs systemd
I run systemd start ollama ( today i booted my computer), and fails

But if i run ollama serve it seems to work ( i again just to be sure i started ollama, then see the status...and executed ollama serve):

And in other tab seems ollama works:

3 - where are the model downloaded:
As posted before /media/Samsung/ollama_models -> as you can see is empty
/home/ollama -> doesnt exist

and /usr/share/ollama ->

im going mad ;)
Thans for your help
Editing post for update: Finally i found the ollama model at /home/eduardo/.ollama, but it shouldnt be there as default directory is /usr/share/ollama/.ollama, and i set the environment variable OLLAMA_MODEL to point to /media/Samsung/ollama_models
Originally posted by @ejgutierrez74 in https://github.com/ollama/ollama/issues/3045#issuecomment-1991349181

Why closed ? problem still happens....
Also commented in other post would be nice to add the ollama stop feature to make a clean stop and kill of ollama server process..
ollama 0.1.32
Ubuntu 22.04 latest updates

@ejgutierrez74 and others, I wanted to use a different directory for models on my Ubuntu 22 since it has larger space. I think you misunderstood how to update the 'ollama.service' file.  In the service file, you added what you want to change above those commented-off lines. those new lines override the default settings. Make changes to those commented lines won't work as they are commented off :-). Anyway, here is my updated service file:
### Anything between here and the comment below will become the new contents of the file

[Service]
Environment="OLLAMA_HOST=<IP_ADDRESS>"
Environment="OLLAMA_MODELS=/new/directory/for/my/local/models"

### Lines below this comment will be discarded

### /etc/systemd/system/ollama.service
# [Unit]
# Description=Ollama Service
# After=network-online.target
#
# [Service]
# ExecStart=/usr/local/bin/ollama serve
# User=ollama
# Group=ollama
# Restart=always
# RestartSec=3
# Environment="PATH=/usr/local/bin:/usr/bin:/bin:/usr/local/games:/usr/games"
....
```.
Then as the document said:
```shell
Save and exit.

Reload systemd and restart Ollama:

systemctl daemon-reload
systemctl restart ollama
```.  I had no problem to restart the ollama service and pulled llama3 again, it was stored to my new directory. Hope it helps.

One thing the service as you can see is opened in nano, and nano in every line puts a # symbol at the begining of each line...if you see the same file in gedit for example:

I got the problem:

I cant start the service, but if i execute in terminal:
$ollama serve it works
( but in the default directory...now id try to add the OLLAMA_MODEL in environment as you suggest)

No luck...can you please when  you execute ollama it appear the new OLLAMA_MODELS environment variable at the beginning....

I correct what you said about //media and change the location of the OLLAMA_MODELS:

Again systemd didnt work:
eduardo@MiPcLinux:~$ sudo systemctl daemon-reload
eduardo@MiPcLinux:~$ sudo systemctl restart ollama
eduardo@MiPcLinux:~$ sudo systemctl status ollama
● ollama.service - Ollama Service
     Loaded: loaded (/etc/systemd/system/ollama.service; enabled; vendor preset: enabled)
    Drop-In: /etc/systemd/system/ollama.service.d
             └─override.conf
     Active: activating (auto-restart) (Result: exit-code) since Fri 2024-05-17 11:19:23 CEST; 6>
    Process: 115059 ExecStart=/usr/local/bin/ollama serve (code=exited, status=1/FAILURE)
   Main PID: 115059 (code=exited, status=1/FAILURE)
        CPU: 26ms

Again as you can see in first picture the ollama serve works....
After running daemon-reload...i look again in
 eduardo@MiPcLinux:~$ sudo gedit /etc/systemd/system/ollama.service
and nothing changes, the OLLAMA_MODELS dont appear, dont know if is ok or wrong...
Also i didnt change or write OLLAMA_HOSTS, as the default location localhost its ok for me.
Hope you can help me.

again, when running sudo systemctl edit ollama.service, it doesn't edit the default /etc/systemd/system/ollama.service file. you can see the first line which states the file opens for edit is called /etc/systemd/system/ollama.service.d/override.conf file.
After running sudo systemctl start ollama, if it shows error again, you can always run  journalctl -u ollama.service to view the log and check if there is any additional information about the error.

Thanks for your help:
1 - I think the config is ok no ? I did now in the right place

2 - This operation: sudo systemctl edit ollama.service and editing the file, should be made every time you boot the computer ? Or only one time and thats all ?
3 - This is my jounalctl -u ollama.service looks like:

I still think that is a bug in ollama, should be easier to change the default directory....
Thanks again

the log clearly shows there were some permission issues. you need to fix it according to those lines:

I dont see any permissions problem, my username is eduardo which is in group root and ollama.

By the way should i edit the ollama.service every time i boot computer ?
Thanks

I have recently needed to shift my models directory and now I face these same problems.
I have run sudo systemctl edit ollama.service and  made the suggested changes. But that doesn't work.
However I have found that I can reach the models directory on a different disk if I start the server by
OLLAMA_MODELS=<path/to/models> ollama serve
But this is not how I want to run ollama. I would rather run it by systemctl.
However doing that generates the response
Jun 15 14:54:19 Fiddler ollama[32949]: Error: mkdir /media/jim/a10TB: permission denied
Jun 15 14:54:19 Fiddler systemd[1]: ollama.service: Main process exited, code=exited, stat>
Jun 15 14:54:19 Fiddler systemd[1]: ollama.service: Failed with result 'exit-code'.
The permissions are:
drwxr-xr-x   4 ollama ollama  4096 Nov 17  2023 models/
Thanks

@jmorganca can be this fixed please ? Its a important bug, because most people need to change the directory of the models because of right permissions, free space, business policy etc...
Thanks

I have recently needed to shift my models directory and now I face these same problems.
I have run sudo systemctl edit ollama.service and  made the suggested changes. But that doesn't work.
However I have found that I can reach the models directory on a different disk if I start the server by
OLLAMA_MODELS=<path/to/models> ollama serve
But this is not how I want to run ollama. I would rather run it by systemctl.
However doing that generates the response
Jun 15 14:54:19 Fiddler ollama[32949]: Error: mkdir /media/jim/a10TB: permission denied
Jun 15 14:54:19 Fiddler systemd[1]: ollama.service: Main process exited, code=exited, stat>
Jun 15 14:54:19 Fiddler systemd[1]: ollama.service: Failed with result 'exit-code'.
The permissions are:
drwxr-xr-x   4 ollama ollama  4096 Nov 17  2023 models/
Thanks
I have found that symlink doesn't work but mount --bind does.
Forget trying to use the Environment Variable.

@ejgutierrez74 @JT-McLeod I face these same problems. Have you solved it?

I have a solution that works for me. As mentioned above it is similar to a symlink but uses the command "mount --bind"
On my ubuntu machine I have a 2nd drive called a10TB, and I want the models placed in folder /models.
sudo mount --bind /media/jim/a10TB/models /usr/share/ollama/.ollama/models
Then start the server without the OLLAMA_MODELS assignment.
To have it happen at restart then
In /etc/fstab after mounting a10TB I have
/media/jim/a10TB/models /usr/share/ollama/.ollama/models none bind,rw 0 0

I think its a bug that have to be solved, and seems not too difficult @jmorganca


Benchmark Allocation Ratios

Right now, the first container allocations set the capacity to about 8 (and other min values), but after that, the capacity is doubled each time.
It's possible that later allocations may need smaller increases in space, if the users aren't filling the structures to their maximum capacity very often.
There's a mathematical principle behind this, but I can't remember the details.

The following structures have internal memory allocations:

Toy_Array
Toy_Table
Toy_Stack
Toy_Bucket

Toy_String also uses malloc(), but only does so when generating a raw buffer with Toy_getStringRawBuffer(), so it's not counted.
Some quick notes:
Toy_Array is not yet used, so there's a possibility that it could be changed to have Toy_Value as it's internal data type. It would also bring it into line with the other basic containers.
Toy_Table is wrapped by Toy_Scope - this design was intentional, and seems to be working well, though the scopes to fiddle with the table's internals. Toy_Table will expand when it reaches 80% capacity.
Toy_Stack was designed to act as the program stack of the VM, but it could be potentially added as a data type within Toy.
Toy_Bucket is a custom allocator structure. It was originally intended only to support Toy_Ast, but has been extended to other parts of the codebase, including strings. In addition, there are some restrictions to using the buckets:

It can only expand until it is freed
It cannot be copied or moved around in memory
It cannot allocate a block of memory larger than it's capacity*

(*capacity refers to a single element within the bucket structure - if any element runs out of space, a new bucket is automatically added to the linked list, so the overall system has no maximum value outside of hardware restrictions.)
Toy_Bucket may leave unused space.
Things to be benchmarked:

Initial sizes of each container
Expansion rates of each container
Expansion thresholds of each container

Prerequisites:

Toy_Array should hold an array of Toy_Value
Add #ifndef definitions to the allocation parameters.


fix(ios): correctly append exif on iOS 14

Platforms affected
ios
Motivation and Context
on iOS 14 if using <preference name="CameraUsesGeolocation" value="true" /> when trying to append the gps data to the exif the image gets corrupted
closes #674
Description

Testing
Used https://github.com/guilhermefarias/cordova-exif plugin to check the exif of the image after capturing on the provided sample app https://github.com/R4yYx/IOSSampleAPP
Checklist

[x] I've run the tests to see all new and existing tests pass
[ ] I added automated test coverage as appropriate for this change
[x] Commit is prefixed with (platform) if this change only applies to one platform (e.g. (android))
[x] If this Pull Request resolves an issue, I linked to the issue in the text above (and used the correct keyword to close issues using keywords)
[ ] I've updated the documentation if necessary

No, but debugging I noticed the data became null/empty on the second CGImageSourceCreateWithData call, while calling it only once didn't, so I used a copy of the data to create the source and the original data for the destination.


Net7Maui binding fails to target property Title, IsComplete

Describe the bug
in MainPage Binding to "TodoMauiApp.ViewModels.MainViewModel" Title and IsComplete fails. The UI is not rendered correctly.
To Reproduce
Steps to reproduce the behavior:

Run TodoMauiApp
view Debug output

Expected behavior
The UI should render the Title and IsComplete values.
What platforms?
Running on Windows in the Maui version 7 example.
Additional context
Comparing the code to the Maui version 6 example (TodoApp.MAUI) the main difference is the ToDoListViewModel has been merged into the MainViewModel. But that shouldn't matter. In MainPage ListView the DataTemplate data type seems correct as "models:ToDoItem", but is not actually being applied to bindings (ie the binding is looking at "MainViewModel" rather than the "MainViewModel.Items" type of "TodoItem" ).

Running the latest code in "Windows Machine", I see the UI rendering title and isComplete.
Can you be specific about:

What version of Visual Studio
What versions of the MAUI workloads
How are you running the app?


Greek in BOESP

@thomasincambodia
You had mentioned in https://github.com/sanskrit-lexicon/PWG/issues/37#issuecomment-906097961 that "there are also 88 translations into Greek (22 in the first volume) that have to be added."
Is it done or still pending?
Probably I can help doing them if not done yet.
And I have seen that Vol.1 had 4 Spruches translated into Greek (rest all are in German); is it not appropriate to render those also into German?
[Footnotes can be in any language (as they could be from many sources), so not to worry about them being uniform (in a single language, I mean).]

@Andhrabharati
they contain sexual matter that was hightly inappropriate to publish in German at the time. Probably nothing much to worry about nowadays in most countries. Would have to be translated  by someone who knows Greek. So you might as well translate them directly from Sanskrit.

translation apart, my query is about having the Greek text itself- is it done?

@Andhrabharati
no. it was actually done in some fashion, but I have removed it.

shall I add it in direct Greek letters (unicode), wihtout encoding of any kind?

@Andhrabharati
please ask @funderburkjim about adding .
(I correct myself. The translations quoted from Galanos were probably  not explicitly sexual.)

Yes, we have Greek text, as Unicode, in several dictionaries.
See issues in https://github.com/sanskrit-lexicon/GreekInSanskrit repository.
If you know how to do the Greek text for BOESP,  that would be great.
You could use this simple format:
<G>123.
ϰαὶ τότ' ἐγὼ Κύϰλωπα προσηύδων ἄγχι παραστάς,
ϰισσύβιον μετὰ χερσὶν ἔχων μέλανος οἴνοιο·
"Κύϰλωψ, τῆ, πίε οἶνον, ἐπεὶ ϕάγες ἀνδρόμεα ϰρέα,
ὄϕρ' εἰδῇς, οἷόν τι ποτὸν τόδε νηῦς ἐϰεϰεύϑει

<G>124.
ϰαὶ τότ' ἐγὼ Κύϰλωπα προσηύδων ἄγχι παραστάς,
ϰισσύβιον μετὰ χερσὶν ἔχων μέλανος οἴνοιο·
"Κύϰλωψ, τῆ, πίε οἶνον, ἐπεὶ ϕάγες ἀνδρόμεα ϰρέα,
ὄϕρ' εἰδῇς, οἷόν τι ποτὸν τόδε νηῦς ἐϰεϰεύϑει

Sure, I will sebd those Greek strings asvsingle line paragraphs.
You may break them into small lines at your end later, as per your style.
Or do you want me to break them at 40 letters or at word ending per line, whichever comes first?

Re line breaks,  my first guess would be to correspond to the line breaks of the text.
However, if these are Greek 'prose', then then line breaks are not significant. If that is the case,
then just choose some convenient line length for break.
Note the blank line after the end of Greek is used to indicate the end of that Greek section.
Also, Are you including Greek translations from all 3 volumes?  If so, I suppose the section numbers
continue throughout the 3 volumes  (as opposed to restarting at 1 in volumes 2 and 3).

@Andhrabharati -- you are fluent in classical Greek also?

@Andhrabharati -- you are fluent in classical Greek also?

Not in the least!
It's just that I try to acquaint myself with just about anything that is necessary, while working on something.
And I do possess a unique strength of "fast learning/grasping" things.

Here is the translations part in boesp-1.
Greek Translations in boesp-1_ansi.txt
If someone likes to cross-check once, giving the extracts from the full book, as a pdf.
Greek translations in boesp-1.pdf
Though I am kind of sure about the text, it is always better to have a third party verification.
Any takers @funderburkjim?
Will takeup the FNs part sometime later, which I had extracted thus-
Greek Notes and Addenda in boesp-1_ansi.txt
-------------
Having the lines with resp. F, V, W no.s will make it easy to go to that place in the book directly.
If similar extracts can be provided from @thomasincambodia files for V.2 and V.3, I can do those as well.
Or if the files are posted by @thomasincambodia, I can extract those lines for further action.
As the identification and marking is already done by his team in the files, I guess I should take that as a basis, instead of repeating it all myself.

We can think of translating those Greek parts into English or German at the end.
First we should strive to get all the material in the book into the digitised form.

Here comes the translations part in boesp-2.
Greek Translations boesp-2.txt
And the corresponding extracts from the full book, as a pdf.
Greek-2.pdf

The files you sent look fine to me.
Have requested @jmigliori to proofread.

@funderburkjim
As Migliori is now accessible, pl. pass on this V.3 files for proofing & get the last 4 translations also filled.
Greek Translations boesp-3.txt
Greek-3.pdf

Here is the Footnotes and VN portions for Greek in boesp-1, @funderburkjim.
Greek Notes and Addenda in boesp-1_ansi.txt
Greek Notes and Addenda boesp-1.pdf
You might get them filled by Jonathan.

If the Devanagari for those FN & VN portions from boesp-1 are given, I can start proofing them.
And if @thomasincambodia can give the files for boesp-2 and boesp-3, the Devanagari and Greek portions can be looked at independent to German proofing in those two volumes..

Here are the corresponding portions from Vol.2 and Vol.3, to be filled.
Greek Notes and Addenda in boesp-2.txt
Greek Notes and Addenda boesp-2.pdf
Greek Notes and Addenda in boesp-3.txt
Greek Notes and Addenda boesp-3.pdf
Against the count of 88 by Thomas, I just got 75 with a quick look for Greek "strings" at the pages.
Vol.x	Tr + FN +	VN
Vol.1: 8 + 14 + 3 (25)
Vol.2: 5 + 19 + 0 (24)
Vol.3: 16 + 10 + 0 (26)
Others could be single letters or words, like at <W>3754, and it should be possible to fill those easily later.

Copies of the corrected Greek verses are in
https://github.com/funderburkjim/boesp-prep/greektext folder.

@jmigliori has finished his corrections for the notes and addenda.  The 'corrected' files also put in the
boesp-prep/greektext folder mentioned above.

I think this issue can be closed -- we have Greek translations courtesy of @Andhrabharati and @jmigliori.
When the time comes, these translations will be inserted into the boesp digitization.

@funderburkjim
Seen that @thomasincambodia has uploaded ansi files for boesp-2 and boesp-3 today.
And there are few leftovers of Greek portions (skipped by me) in both these volumes.
Vol. 2 Balance.txt
Vol. 3 Balance.txt


Scale down doesn't let jobs run gracefully

When a scale down happens I'm finding that a job is aborting mid-test-run with ERROR: Couldn't connect to Docker daemon at http+docker://localunixsocket - is it running?, and the last thing in the buildkite-agent CloudWatch logs is "Gracefully shutting down" but no more logs, but the job successfully uploads artifacts etc after failing, and gracefully shuts down via our API, but is missing any more log lines in CloudWatch.
My guess is that we're not preventing awslogs and docker daemons being shutdown in the autoscale terminating event. lifecycled appears only to be helping buildkite-agent from being shut down.

I don't think awslogs or docker would shut down before the lifecycled hook has returned, they'd only be shutting down on normal system shutdown which happens after the lifecycled hook.
So… perhaps the lifecycled hook doesn't wait properly, and just returns AOK then the agent still hasn't completed it's job.
This could happen if the service stop returned straight away instead of waiting… or if the pgrep isn't working as we expected…


[Outlook] (manifest) exchange token URL in JSON manifest

Learn Build status updates of commit 653064b:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

docs/outlook/inside-the-identity-token.md
:white_check_mark:Succeeded
View

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching the learn.microsoft.com contributor guidesPost your question in the Learn support channel

Learn Build status updates of commit 681b103:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

docs/outlook/inside-the-identity-token.md
:white_check_mark:Succeeded
View

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching the learn.microsoft.com contributor guidesPost your question in the Learn support channel

Learn Build status updates of commit 84c4b79:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

docs/outlook/inside-the-identity-token.md
:white_check_mark:Succeeded
View

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching the learn.microsoft.com contributor guidesPost your question in the Learn support channel

Learn Build status updates of commit ded2217:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

docs/outlook/inside-the-identity-token.md
:white_check_mark:Succeeded
View

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching the learn.microsoft.com contributor guidesPost your question in the Learn support channel


[$250] [Search v2.1] Update search parser grammar to handle special characters

Problem
Coming from here, the search parser grammar doesn't handle some special characters very well, for example it throws an error when ; is added to a text input like keyword
Solution
Update the parser grammar to correctly handle special characters:
; should be treated like any other character
  (whitespace) should be a logic AND operator when separating filter keys, e.g. amount:200 category:travel means amount=200 AND category=travel. It should also be a logical OR when separating free text, e.g. las vegas means keyword=las OR keyword=vegas
, is used as a logical OR operator when separating values for a filter key, e.g. category:travel,hotel,food means category=travel OR category=hotel OR category=food. It should also be treated as a regular character when used in free text, e.g. las, vegas means keyword="las," OR keyword="vegas"
cc @Kicu @adamgrzybowski @289Adam289 @Guccio163 @SzymczakJ
Upwork Automation - Do Not Edit

Upwork Job URL: https://www.upwork.com/jobs/~01cfdc085a6131060b
Upwork Job ID:<PHONE_NUMBER>273416803
Last Price Increase: 2024-08-08
Automatic offers:

ikevin127 | Reviewer | 103492420

Issue OwnerCurrent Issue Owner: @

Hi! I am from SWM and I'd like to work on this issue.

Proposal
Please re-state the problem that we are trying to solve in this issue.
3 separate issues:

; not correctly handled in free-text elements of search queries, results in 'Page not found' error
  (whitespace) characters in keyword filters should be treated as OR operators - all other filters should not be impacted (remain AND as before)
, (comma) characters in all other filters than keyword should be treated as OR operators

What is the root cause of that problem?
All issues originate in searchParser.peggy.

; characters are not supported as a valid character in the identifier grammar rule - hence parser rejects free-text values with ; characters included:

https://github.com/Expensify/App/blob/1adcf8e87fea5dc1d244d828a78190f82f0f8c33/src/libs/SearchParser/searchParser.peggy#L111

searchParser.peggy translates dangling free-text words to keyword filters via this grammar rule:

https://github.com/Expensify/App/blob/1adcf8e87fea5dc1d244d828a78190f82f0f8c33/src/libs/SearchParser/searchParser.peggy#L59
and this conditional component when the field and op are not included:
https://github.com/Expensify/App/blob/1adcf8e87fea5dc1d244d828a78190f82f0f8c33/src/libs/SearchParser/searchParser.peggy#L65-L67
The main filterList rule then combines any identified filters together with AND values:
https://github.com/Expensify/App/blob/1adcf8e87fea5dc1d244d828a78190f82f0f8c33/src/libs/SearchParser/searchParser.peggy#L49-L56
As a result, a search string like either keyword:las vegas or otherwise just las vegas will result in the equivalent of the underlying search string keyword:las AND keyword:vegas.

searchParser.peggy performs comma-delimited filter splitting here:

https://github.com/Expensify/App/blob/1adcf8e87fea5dc1d244d828a78190f82f0f8c33/src/libs/SearchParser/searchParser.peggy#L69-L72
This is performed indiscriminately for all filters types - this includes the keyword filter type, causing a query like keyword:do,not,split to be split into keyword:do OR keyword:not OR keyword:split.
Note that this will only apply for keyword filters where the field name has been explicitly given - it will not apply when only dangling keyword text is provided, e.g. only do,not,split - this is because dangling keywords are translated by default to keyword filters before the comma-delimited handling is applied:
https://github.com/Expensify/App/blob/1adcf8e87fea5dc1d244d828a78190f82f0f8c33/src/libs/SearchParser/searchParser.peggy#L65-L72
What changes do you think we should make in order to solve the problem?

Add ; into the set of characters available to the identifier rule. Note that BE should be checked to ensure this will not present any issues with possible injection attacks - however wrapping identifiers in double-quotes already allows ; values to be successfully sent from front-end, so I do not see this change having wide impact.

Change the allFilters rule definition to condense individual sets of neighbouring keyword filter values into a localised OR tree, prior to AND-ing all other filter nodes together. For example, with a query of category:car keyword:las vegas word, applications of the filter rule will already split this into:

[
  { operator: "eq", left: "category", right: "car" },
  { operator: "eq", left: "keyword", right: "las" },
  { operator: "eq", left: "keyword", right: "vegas" },
  { operator: "eq", left: "keyword", right: "word" }
]

allFilters should be modified to condense the neighbouring keyword filters into a series of ORs, and then AND the result as normal:
{
  "operator": "and",
  "left": { "operator": "eq", "left": "category", "right": "car" },
  "right": {
    "operator": "or",
    "left": {
      "operator": "or",
      "left": { "operator": "eq", "left": "keyword", "right": "las" },
      "right": { "operator": "eq", "left": "keyword", "right": "vegas" }
    },
    "right": { "operator": "eq", "left": "keyword", "right": "word" }
  }
}

One thing to note is that this will not accommodate cases where multiple keyword filters are provided in the query and not co-located. For example, keyword:test value category:car keyword:las vegas will result in the equivalent of (keyword:test OR keyword:value) AND category:car AND (keyword:las OR keyword:vegas). This is also how existing filters function, so this behaviour was maintained (e.g. currently, merchant:test,value category:car merchant:las,vegas will result in a similar equivalent query of (merchant:test OR merchant:value) AND category:car AND (merchant:las OR merchant:vegas)).

keyword filters should skip comma-delimiting in the filter rule in the same way that dangling keywords do - hence a conditional to short-circuit filter before this occurs when the field value is keyword should prevent this issue. Note that this will still allow space-delimiting to occur, so queries such as keyword:test, value will apply as keyword:test, OR keyword:value.

What alternative solutions did you explore? (Optional)
Reminder: Please use plain English, be brief and avoid jargon. Feel free to use images, charts or pseudo-code if necessary. Do not post large multi-line diffs or write walls of text. Do not create PRs unless you have been hired for this job.

Contributor details
Your Expensify account email<EMAIL_ADDRESS>Upwork Profile Link: https://www.upwork.com/freelancers/~012c16fe40faf63452

Thanks for the proposal @MCarlesso  However, we already have someone working on this issue.

No worries! You're correct that that's the regular process. This issue is part of the Search project though and we have an expert agency working with us on this implementation, so they are handling most of the Search issues.

This is being worked on, it will have a 7-day regression period, so I don't feel the need to add another BZ person to this.
I'll be out until 8/21 and will check in on this then.

HI! @luacmartins How to handle cases where keywords are provided in multiple places in an input string. For example:
xxx yyy category:Cat merchant:Mer zzz
in https://github.com/Expensify/App/pull/47328 it is is handled like that:
(xxx OR yyy OR zzz) AND (category:Cat) AND (merchant:Mer)
but I am not sure if this is correct approach.

Yea, that's correct!

@ikevin127 can you please propose a regression test?

@slafortune I've asked (ref1, ref2, ref3) whether regression tests are needed on Search v2.1 related issues and was told (ref1, ref2, ref3) that regression tests will be added later as part of the project wrap up.

@ikevin127 Role c+ - Paid $250 via Upworks
@289Adam289  Role Contributor - does not require payment (Contractor)


Convert nonce storage to a bitmap to reduce gas consumption

I wasn't able to DM @wilsoncusack directly on twitter/warpcast so I guess this thought will go here! Sharing in case the team has not considered this change before and hope this can be helpful :).
There is an opportunity to further optimize the gas cost of using withdraw request nonces without compromising on the ability to process requests in parallel per-account or changing any interfaces. We can do this through a BitMap where instead of the storage being keyed by uint256 nonce and storing a bool, we key by a uint256 bucket and store 256 bits that let us pack 256 nonces into one slot. By reusing the same slot for multiple nonces, we are able to reduce gas cost by converting writing of new state (setting mapping value to true) into updating of existing state (flipping a bit within the word of one bucket).

Some napkin math on savings:
For every 256 nonces, we have to write 1 new word and can update 255 bits thereafter. Writing a new word is ~20k gas and updating an existing word is ~5k gas. The amortized cost of using a nonce becomes (1 • 20k + 255 • 5k) / 256 => 5.06k, which is basically the same ~15k gas savings difference between writing/updating. Of course there are other places of gas consumption in the paymaster flow that will make the net improvement less visible, but I generally rank storage-writing related optimizations worthwhile, especially for the scale of these Coinbase smart accounts.
Note that gas savings will only come if nonces are ordered sequentially by whatever offchain code is preparing withdraw requests to be able to re-use writing to the same slot many times.

Code changes:
The simplest approach is to just use the BitMap library offered by OpenZeppelin (linked above) and update the storage, external view function, and internal validation function:
mapping(address => BitMap) internal _nonceUsed;

function nonceUsed(address account, uint256 nonce) external view returns (bool) {
    return _nonceUsed[account].get(nonce);
}

function _validateRequest(address account, WithdrawRequest memory withdrawRequest) internal {
    BitMap storage bitMap = _nonceUsed[account];
    if (bitMap.get(withdrawRequest.nonce)) {
        revert InvalidNonce(withdrawRequest.nonce);
    }

    bitMap.set(withdrawRequest.nonce);

    // This is emitted ahead of fund transfer, but allows a consolidated code path
    emit MagicSpendWithdrawal(account, withdrawRequest.asset, withdrawRequest.amount, withdrawRequest.nonce);
}

If it's preferable to minimize dependencies or extra code unused from the library, one can also copy the logic in-line. Existing test cases will catch an incorrect copy+paste and auditors should also be able to follow.

Happy to make this contribution directly in a new PR if helpful and otherwise thanks for reading this!

This is a cool idea, thanks for the well written issue. I am hesitant that the gas (especially as we're focused on L2) is worth the added complexity. Open to reviewing a PR and seeing the gas savings if you want to put one up, though.

I don't have permissions to post a new branch/PR so I just made a new repo on my github with the new commits on my branch. If I get perms to make a branch here, I can push my PR for an easy merge if you think it's worth it!
Change summary:

Add new test to do 256 validations
Add new gas snapshot on the current implementation
Made the proposed changes to the paymaster contract

If you run forge snapshot --diff .gas-snapshot, you'll see the gas savings from the change which look like ~50% on validatePaymasterUserOp.

Saving 5,607,028 gas over 256 evaluations averages out to 21,902 gas saved on validatePaymasterUserOp with this change. Note that the first validation per-account will not experience any savings, but subsequent validations will leverage the re-used slot if the offchain nonce preparation just increments per-account.

you can fork it and if you PR it'll show up here :) and ok thanks we'll consider


feat(release-gha): fixing gha for release version

Fix for the error in this GHA run https://github.com/voi-oss/dbt-toolkit/actions/runs/6970266994/job/18967821091

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (d4624ab) 76.05% compared to head (428712a) 76.05%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main       #8   +/-   ##
=======================================
  Coverage   76.05%   76.05%
=======================================
  Files          16       16
  Lines         380      380
  Branches       51       51
=======================================
  Hits          289      289
  Misses         78       78
  Partials       13       13

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.