[AIRFLOW-1354] Fix pool_link() return value

The URL had a copy-paste error
Make sure you have checked all steps below.
Jira

[x] My PR addresses the following Airflow Jira issues and references them in the PR title. For example, "[AIRFLOW-XXX] My Airflow PR"

https://issues.apache.org/jira/browse/AIRFLOW-XXX
In case you are fixing a typo in the documentation you can prepend your commit with [AIRFLOW-XXX], code changes always need a Jira issue.

Description

[x] Here are some details about my PR, including screenshots of any UI changes:
When getting the list of pools at /admin/pool/, the link on the pool name is wrong.

Tests

[x] My PR adds the following unit tests OR does not need testing for this extremely good reason:

Commits

[x] My commits all reference Jira issues in their subject lines, and I have squashed multiple commits if they address the same issue. In addition, my commits follow the guidelines from "How to write a good git commit message":

Subject is separated from body by a blank line
Subject is limited to 50 characters (not including Jira issue reference)
Subject does not end with a period
Subject uses the imperative mood ("add", not "adding")
Body wraps at 72 characters
Body explains "what" and "why", not "how"

Documentation

[x] In case of new functionality, my PR adds documentation that describes how to use it.

When adding new operators/hooks/sensors, the autoclass documentation generation needs to be added.

Code Quality

[x] Passes git diff upstream/master -u -- "*.py" | flake8 --diff

flake8 fails. And is it another issue for www_rbac as well?

I'm closing this because I think I just misunderstood what the link should do. The link will send you to the task instance list view, filtered to only show the task instances that are using this pool.


Incompatibility with systemd cookbook

Cookbook version
2.9.9
Chef-client version
12.16.42
Platform Details
Centos 7.2.
Scenario:
After fa654963a, docker_service_manager_systemd will fail in any environment where the systemd cookbook is also in use. The helper systemd_conf conflicts with the name of a resource in the systemd cookbook, and for whatever reason, the resource method is taking precedence during method dispatch.
Steps to Reproduce:
Add recipe[systemd] to any of the systemd kitchen tests, then try to converge.
Expected Result:
The docker_service_manager_systemd succeeds as it did on 2.9.8.
Actual Result:
* docker_service_manager_systemd[default] action start

  ================================================================================
  Error executing action `start` on resource 'docker_service_manager_systemd[default]'
  ================================================================================

  ArgumentError
  -------------
  You must supply a name when declaring a systemd_conf resource

  Cookbook Trace:
  ---------------
  /tmp/kitchen/cache/cookbooks/docker/libraries/docker_service_manager_systemd.rb:61:in `block (2 levels) in <class:DockerServiceManagerSystemd>'
  /tmp/kitchen/cache/cookbooks/docker/libraries/docker_service_manager_systemd.rb:53:in `block in <class:DockerServiceManagerSystemd>'

  Resource Declaration:
  ---------------------
  # In /tmp/kitchen/cache/cookbooks/docker_test/recipes/service_systemd.rb

    7: docker_service_manager_systemd 'default' do
    8:   host 'unix:///var/run/docker.sock'
    9:   action :start
   10: end
   11:

Fix
Easiest tactic is to just rename the method, docker_systemd_conf. Debugging method dispatch surprises probably isn't worth it ...

thanks for the info! i have renamed systemd_conf to systemd_args and pushed out release v2.9.10. hopefully this resolves it for you!

Yup, b94f1a9 did the trick. Thanks much!


CI: ir/factorial test randomly fails on Travis

I haven't been able to repro this consistently, but sometimes the ir/factorial test fails on they Travis CI build. I need to narrow this down at some point, but VM execution path isn't currently high priority, so the bug will have to wait for when I have the cycles to spare on chasing it down.

I haven’t seen this issue for quite a while. No reason to keep the bug sitting here, since I can re-open if we get it to repro again.


Update presto-hive-apache, with Parquet 1.6.0

@electrum is it OK to update to newer version of presto-hive-apache?

Merged, thanks!


was trying with Manual download

i hv downloaded both the package and put into my app/code folder like other module we install inside magnto website..but there are some issue happening as after installation of the module i am not able see my frontend,whereas the backend works fine.And after disabling the module , its works fine.

i hv done the composer also, in this case it was working fine but the issue happen when i try to do manually


Update publishing the gem documentation

What

Reference to master branch has been changed to main.
Why

We no longer use a master branch.
Visual Changes
None.

Closed in favour of https://github.com/alphagov/govuk_publishing_components/pull/2759.


Some revisions to pg_stat_block

field renames to be more in-line with system catalogs
rename a couple missed blks -> bytes field names
rework the view to actually use the CTE field
add toast_index_* stats as well
remove the relation size filter

Egads, that scoundrel gregs1104 is approving changes in this very official Crunchy repo, how dare he!  (will fix when back on Crunchy acct)


[WIP] Test v13 benchmarks

What does this PR do?
A brief description of the change being made with this pull request.
Motivation
What inspired you to submit this pull request?
Additional Notes
Anything else we should know when reviewing?
How to test the change?
Describe here in detail how the change can be validated.

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Please upload report for BASE (ban/tmp-test-benchmarks-bs@62692cc). Learn more about missing BASE report.

Additional details and impacted files
@@                      Coverage Diff                      @@
##             ban/tmp-test-benchmarks-bs     #627   +/-   ##
=============================================================
  Coverage                              ?   73.17%
=============================================================
  Files                                 ?      252
  Lines                                 ?    35942
  Branches                              ?        0
=============================================================
  Hits                                  ?    26300
  Misses                                ?     9642
  Partials                              ?        0

Components
Coverage Δ

crashtracker
20.53% <0.00%> (?)

datadog-alloc
98.73% <0.00%> (?)

data-pipeline
90.12% <0.00%> (?)

data-pipeline-ffi
0.00% <0.00%> (?)

ddcommon
83.08% <0.00%> (?)

ddcommon-ffi
69.52% <0.00%> (?)

ddtelemetry
59.10% <0.00%> (?)

ipc
83.63% <0.00%> (?)

profiling
84.26% <0.00%> (?)

profiling-ffi
77.42% <0.00%> (?)

serverless
0.00% <0.00%> (?)

sidecar
40.12% <0.00%> (?)

sidecar-ffi
0.00% <0.00%> (?)

spawn-worker
50.36% <0.00%> (?)

tinybytes
91.66% <0.00%> (?)

trace-mini-agent
70.88% <0.00%> (?)

trace-normalization
98.25% <0.00%> (?)

trace-obfuscation
95.73% <0.00%> (?)

trace-protobuf
77.67% <0.00%> (?)

trace-utils
93.28% <0.00%> (?)


Make to prop on Link optional again

A reimplementation of #3803 for v4
Fixes #2319

Thanks for the tests! Just need that question above answered and then LGTM.

I'm not a fan of this. #5240 brought something about this up as well, and I just don't see the point. A <Link> is meant to provide history powered navigation. If you don't want to use to, just render an anchor.

@pshrmn While it looks like a "hack" of component architecture it's pretty pragmatic for something like a list with disabled elements. Otherwise i have to write a wrapper for Link and i think that empty to is easier to understand than additional layer of abstraction with wrapper.
import { Link } from 'react-router-dom';

const ListItem = (props) => {
  var { id, availableQuantity, ...rest } = props;
  var outOfStock = !availableQuantity;

  return (
    <Link className="list-item" to={outOfStock ? null : `/item/${id}`>
      {...}
    </Link>
  );
};

Also i can call preventDefault inside onClick but it's confusing to have an non-clickable item with link in browser status bar.

What kind of issues can occur if we implement this?

@sanniassin if link is not meant to be matched and active why do you need it? Usually you don't need to render anchor at all if , for example, your products are out of stock.
{outOfStock ? (Out of stock) : (<Link to="/item">Item</Link>)}

@zemd It doesn't scale well for more complex components.
<Link to={outOfStock ? null : `/item/${item.id}`} className="item">

{ item.name }

{ item.description }

    { item.tags.map((tag, i) =>

{ tag }

    )}

</Link>

vs
outOfStock ? (
  <Link to={`/item/${item.id}`} className="item">

{ item.name }

{ item.description }

      { item.tags.map((tag, i) =>

{ tag }

      )}

  </Link>
) : (

{ item.name }

{ item.description }

      { item.tags.map((tag, i) =>

{ tag }

      )}

)

@sanniassin it scales indeed as it should scale. if you have some common pieces of code you can always utilize them.

@zemd I guess it depends on a preferred code style. Link is a replacement for an anchor tag and anchor can have no href, so it sounds intuitive for me to expect same behaviour from Link.
Empty to is totally safe. It allows you to write less code without maintenance and readability trade-offs (i think there is no ambiguity in what to={outOfStock ? null : `/item/${item.id}`} means). And it doesn't affect anyone who prefers to always specify to.

An argue to implement in related issue: https://github.com/ReactTraining/react-router/issues/2319#issuecomment-311776799
Any decisions?

@sanniassin
outOfStock ? (
  <ProductItem item={item} />
) : (
  <Link to={`/item/${item.id}`} className="item">
    <ProductItem item={item} />
  </Link>
)

@VladShcherbin Yes, but it means that it's a ProductItemContainer not a ProductItem itself, so you have one more component and one more file in your project. You may also have conflict in styles when Link and ProductItem shares same className. I found empty to much simpler and cleaner.

Thanks for the PR @sanniassin, but I think I'd suggest you do as @VladShcherbin (and others) suggest. If you don't need <Link to>, you should be rendering a <Link> at all.

@mjackson Should we add a note to migration guide then? Because v3 supports empty to.

@sanniassin Yes. I wasn't even aware we had a migration guide! (That's awesome that we do though!)

@zemd I disagree with your assessment. Take a look my comment here for further elaboration: https://github.com/ReactTraining/react-router/issues/2319#issuecomment-311776799
To sum it up (again),  is an interface for an anchor. There is a reason the HTML spec does not require a tags to have href's on them, they could have forced you to always use an href... they recognized you want something to appear as a link if you don't yet have the path. If I have a component that has a bunch of links, but I don't have the paths yet (let's say I'm getting that data from redux or from some data store that doesn't necessarily give me the data the moment the component is visible). It would be a bad user experience to not render them as links, especially if the css of links is different from that of a non link. You wouldn't (and shouldn't) do the 2nd part of @sanniassin 's example. So that's the first half of your argument.
Now technically sure, the user can wrap Link on their own. This is what I do in my repo if my memory is correct:
const CustomLink = props => {
  const buttonElement = props.to ? Link : 'a';
  return <ButtonElement {...props} />
}

That being said,  I think this is a reasonable enough use case and  is a convenience component to begin with, that's essentially supposed to be an abstraction over an anchor anyway. So I think it makes sense that the prop be optional.
Now that being said, I'm not really petitioning for the feature anymore... I'm using some different routing libraries. I just wanted to explain my reasoning, as I made an argument that @sanniassin actually posted in this thread and neither him nor I ever received any response to it.

@reywright No, <Link> is critical to using the Router. It is not just a wrapper or convenience method. A normal  will issue browser navigation events. Only <Link> will connect to the router and use the local history to navigate without loading up a new page.

@timdorr how so? You can very easily have an click handler for the onClick of an anchor, and inside the handler, e.preventDefault,  then use history.push(). In fact if you're working within redux, it makes more sense not to use <Link / > in a lot of cases as you want to fire off an action to load your data first, before you route the user. I did this exact thing in production for quite sometime before ever touching <Link />. It's not necessary to use it, unless this changed in newer version of the Rotuer... I haven't kept up with the newest version. It is quite convenient though.


Fix themes images

:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

docs/design/themes-colors.md
:white_check_mark:Succeeded
View

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.

:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

docs/design/themes-colors.md
:white_check_mark:Succeeded
View

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.


Triage finschia-sdk#983

The subject of the triage:

Finschia/finschia-sdk#983

This PR is related as #43 , if it is necessary, this PR is also necessary.


Integrity check failed: java.security.NoSuchAlgorithmException: Algorithm HmacPBESHA256 not available

I am trying to build an app bundle and getting the following error.

What went wrong:
Execution failed for task ':app:signReleaseBundle'.

A failure occurred while executing com.android.build.gradle.internal.tasks.Workers$ActionFacade
Failed to read key upload from store "/Users/dennisashford/AndroidStudioProjects/fytfeedv10/android/app/upload-keystore.jks": Integrity check failed: java.security.NoSuchAlgorithmException: Algorithm HmacPBESHA256 not available

I believe I have narrowed it down to the Java versions used to generate the key file and Java JDK used to build the app bundle. It appears the key store file was generated using Java 17, and Android Studio is using Java 11 to build the app bundle. However, Java 11 cannot read the encryption. However, I have no idea how to specify within flutter or Android Studio which Java version to use to build the app bundle and sign the app using the uploaded key store file. I cannot regenerate a key either, as the app is already published.
Flutter doctor -v
[✓] Flutter (Channel stable, 2.8.1, on macOS 11.6.1 20G224 darwin-x64, locale en-US)
• Flutter version 2.8.1 at /Users/dennisashford/flutter
• Upstream repository https://github.com/flutter/flutter.git
• Framework revision 77d935af4d (4 weeks ago), 2021-12-16 08:37:33 -0800
• Engine revision 890a5fca2e
• Dart version 2.15.1
[✓] Android toolchain - develop for Android devices (Android SDK version 31.0.0)
• Android SDK at /Users/dennisashford/Library/Android/sdk
• Platform android-31, build-tools 31.0.0
• Java binary at: /Applications/Android Studio.app/Contents/jre/Contents/Home/bin/java
• Java version OpenJDK Runtime Environment (build 11.0.10+0-b96-7281165)
• All Android licenses accepted.
[✓] Xcode - develop for iOS and macOS (Xcode 13.2.1)
• Xcode at /Applications/Xcode.app/Contents/Developer
• CocoaPods version 1.11.2
[✓] Chrome - develop for the web
• Chrome at /Applications/Google Chrome.app/Contents/MacOS/Google Chrome
[✓] Android Studio (version 2020.3)
• Android Studio at /Applications/Android Studio.app/Contents
• Flutter plugin can be installed from:
🔨 https://plugins.jetbrains.com/plugin/9212-flutter
• Dart plugin can be installed from:
🔨 https://plugins.jetbrains.com/plugin/6351-dart
• Java version OpenJDK Runtime Environment (build 11.0.10+0-b96-7281165)
[✓] VS Code (version 1.59.1)
• VS Code at /Users/dennisashford/Downloads/Visual Studio Code.app/Contents
• Flutter extension version 3.25.0
[✓] Connected device (3 available)
• Android SDK built for x86 (mobile) • emulator-5554                        • android-x86    • Android 11 (API 30) (emulator)
• iPhone 12 (mobile)                 • CCFE8FB8-8AEB-4D19-9A7B-B5AEE7F5F411 • ios            • com.apple.CoreSimulator.SimRuntime.iOS-15-2 (simulator)
• Chrome (web)                       • chrome                               • web-javascript • Google Chrome 97.0.4692.71

Hi @DennisAshford, Please ask support questions on the support forums like StackOverflow.  Additionally, you may check if this StackOverflow answer helps resolve the issue https://stackoverflow.com/a/67632064/8253662
Closing as this issue doesn't seem to describe a bug or a feature request in flutter.


Update the internal structure of the formly questions field

The questions field was using a model for each generated internal field. This made
it very difficult to create dependencies between fields.
The generated fields now use a shared model that lives in the generated form. The
parent model is made available on the new shared model at $parent.
This only modifies the internal structure of the question fields data. The structure
of the model and the structure of the data sent to the server remain unchanged.

Made the angular-aria version number match the other angular-* packages

@mafernando

works great, merge away :+1:


Line spacing issue

Hi, i'm using jsPDF and I think is great!
Is just what I need in my project
but im facing some issues using fromHTML function.

In my div I want to print I've a centered image and it's appearing floating to left when I generate the PDF. It also looks like it is not taking the margin I've set for the image.

When I write a document it ignores line spacing (see attached images)

Hope anyone can help
Thanks in advance
----> This is my text editor

-----> This is the generated PDF

fromHTML is not so good as you expect. If you want a precise solution you should not use fromHTML but write it by yourself manually.

And fromHTML is not really updated. So if you hope, that somebody maybe would make changes and updates soon, I am sad to disappoint you.

Thanks for your quick response @arasabbasi
I'll try to write it manually


[AMBARI-26185] Upgrade commons-collections to resolve CVEs

What changes were proposed in this pull request?
upgrading commons-collections to 4.4
(Please fill in changes proposed in this fix)
How was this patch tested?
tested on installing a local cluster.
all services and ambari server was start with no error.
(Please explain how this patch was tested. Ex: unit tests, manual tests)
(If this patch involves UI changes, please attach a screen-shot; otherwise, remove this)
Please review Ambari Contributing Guide before opening a pull request.

@sandeep318kumar Could you submit all these upgrades to the upgrade branch and include them in this issue: https://issues.apache.org/jira/browse/AMBARI-26217?

Sure. I'll raise.


Cleanup volume status based on VM poweroff

This PR handles the issue of updating status of volumes to detached that belong to a VM which was forcefully powered off.
The approach is as follows:

Create a PropertyCollector filter to monitor updates for VM power state
Start a thread and wait for updates from host using the property collector.
In case of updates where the power state was powerOff, find the attached devices to the VM
If the attached devices are docker volumes, set their status to detached in the KV

Testing:
Tested as follows:

Creating a volume and attaching it to a container
force poweroff the VM
The event is captured by vmdkops service and volume status is set to detached. This volume can be attached to another volume.

No side effects: When a VM with no docker volume attached is turned off
Fixes #369

Do we need to take lock before updating the status of vmdk?
What do we do if error occurs during updating the status of vmdk? retry?

You are monitoring VM power event for every VM. For every powered off VM, we will scan through VM Config to see if there are any (dockvols) disks attached. This may be okay for first version but we should explore alternatives to quickly detect and ignore who are not managed by vDVS. Can we attach custom attribute to VM whenever a volume is attached. On powered off event, we can skip processing if custom attribute is set.
I suspect this code may be racing with HA/FDM which is also listening to VM powered off events. Please test with vSphere HA enabled in cluster and kill VMX process.
I don't recall how power state changes are handled with vMotion. Please test with vMotion.

@msterin @govint @pdhamdhere @lipingxue
I have addressed your comments in my latest commit.
Added a unittest which essentially automates steps of testing in PR description.
I have done the following testing:

vmdkops service restart: Works fine. No issues
VM suspend, resume:  No issue. We don't get the poweroff event here.
VM reset: No poweroff event.
Vmotion - cross esx : When a VM is moved to another host, it's still live. No poweroff event either.
Enabling HA on cluster and VM monitoring: Killing the vmx process. VM shows poweroffed on VC. But we don't get the poweroff event. I am not sure what should be the behavior here.

Enabling HA on cluster and VM monitoring: Killing the vmx process. VM shows poweroffed on VC. But we don't get the poweroff event. I am not sure what should be the behavior here

What is the behavior ? Does VM stay available with docker volume still attached ?
If yes, then we are good.

@msterin I have addressed your comments. Regarding the actual disk, I have invoked disk_detach which does actual detach and in turn updates KV as well.
Regarding testing with HA, I think I somehow missed the logs.
In case of killing vmx process, we do get the poweroff event for the VM.

@pshahzeb, please add a comment in the listener code as to the version of the VIM API that you are using.

@govint @pdhamdhere Fixed the hostd restart case.

Getting this merged. Will do a minor PR for nits (Don't want to commit post LGTMs)


Usdt funds not received after 50 hours in my oisy from ledger

Need some support, please. I transfered from ledger nano 50 hours agoʻ Usdt and  after 15,000 blocks confirmations still my usdt funds have not entered to my oisy wallet.  what seems to be the problem?

@leppard73 So sorry for the inconvenience this might have caused, error is probably caused by cloud data glitch and can be fixed. The best way to resolve this is to contact our support team. For the fastest resolution, please click on the link below to our dedicated support line:
Support: Help Center
Note: Click on the live chat icon at the bottom corner of the page to start a conversation

Hello @leppard73
it might be a good idea to double-check the receiving address on your Oisy wallet. If everything looks correct, I’d recommend reaching out to Oisy's support team for help.I'll have to refer you to the official support live chat with the ticket ID OIS07638
Please see the link below to our dedicated support line:
Oisy wallet Network DApps Support Ticket Requests.
Click on the live chat icon at the bottom corner of the page to initiate chat with a live support agent.

Hi @leppard73 can you provide me the transaction hash?
Also pls check if you have the ckUSDT token also enabled (open "Manage list"; filter for USDT; and enable both USDT and ckUSDT). There is a chance that you sent them to your ICP wallet address instead of the Ethereum address, which then converted the USDT into ckUSDT.

0x4aba879fc0f436977ad41f0765051dc55fcb160c11bf8e109b91bad0050c6600 Stefan Berger .. Ticket ID OIS07638 Above please find the hashtag of the failed transaction. dated: Nov. 16 2024 at 06:58:47 PM UTC. Block number 21202203 amount 87.203465 usdt I have double checked the OISY usdt wallet address and it is correct Please revert. Thank you the USDT token is able and also the ckusd. El mar, 19 nov 2024 a las 8:10, Stefan Berger @.>) escribió:
…
Hi @leppard73 https://github.com/leppard73 can you provide me the transaction hash? Also pls check if you have the ckUSDT token also enabled (open "Manage list"; filter for USDT; and enable both USDT and ckUSDT). There is a chance that you sent them to your ICP wallet address instead of the Ethereum address, which then converted the USDT into ckUSDT. — Reply to this email directly, view it on GitHub <#3648 (comment)>, or unsubscribe https://github.com/notifications/unsubscribe-auth/BNBOA3ZIPGXK6SAGC7NZ4NT2BLP73AVCNFSM6AAAAABSAZIAFKVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDIOBUHA3DCMZYGI . You are receiving this because you were mentioned.Message ID: @.>

Please kindly write to the OISY support team regarding your issues OISY SUPPORT so your issue can be escalated.

Hello @leppard73 .  Thank you for reaching out to us.  Can you please post your Oisy ICP principal?  This can be found under:
Your profile (see top right corner of the screen).

"Your addresses"

"ICP Principal"

Need some support, please. I transfered from ledger nano 50 hours agoʻ Usdt and after 15,000 blocks confirmations still my usdt funds have not entered to my oisy wallet. what seems to be the problem?

Hello @leppard73
We sincerely apologize for the delay and any inconvenience this may have caused. It appears that your query would be best handled by our support team.
I’ll need to refer you to the official support live chat, where you can use the ticket ID USD16463 for recovery guidelines.
Please use the following link to access our dedicated support line:
Ledger Network DApps Support Ticket Requests.
Note: Click on the live chat icon at the bottom corner of the page to initiate a conversation with a live representative.
Best regards

Hi @leppard73, following up on this. Could you resolve the problem meanwhile?
If not, please provide the principal ID, so our team can further investigate. Thank you.

@bitdivine somehow the response via email with the principal ID got lost on its way.
I'll send you the principal ID via DM.


how to install pup in raspbian (raspberry pi 2)

Hi!
What version shoud I download? I try with Linux arm but not works.
thanks!

Use https://github.com/ericchiang/pup/releases/download/v0.4.0/pup_v0.4.0_linux_arm.zip

This feels like it should be closed as there is also a go get command in the README, which will build the executable needed for your platform. On rPi, go is an apt install away

The go get command isn't working for me, it runs but nothing happens. Also on raspbian.

If go get runs, and echo $? shows 0, then you've not setup your path to run go executables.
Again not a pup problem.
Have you used go get with any other apps and had them work?
https://github.com/syndbg/goenv/blob/master/INSTALL.md shows setting the PATH as follows (your GOPATH may be different)
 $ echo 'export PATH="$GOROOT/bin:$PATH"' >> ~/.bash_profile
 $ echo 'export PATH="$PATH:$GOPATH/bin"' >> ~/.bash_profile

if you have a GOROOT setup then these two lines should fix it after you either . ~/.bash_profile or exit and re-launch terminal / restart.
If all of the above does not work, please share your specific errors along with your GOPATH, GOROOT and exact commands you run so people on the internet who have not watched your computer are not left guessing at what you might have done wrong.
I've built this on a Pi, I know it works.


Counterfactual Inference for Continuous Treatment

This is a fascinating work! Can this method be extended to the scenario where the treatment is continuous, say, the degree of medication for a patient? One easy modification is to discretize the continuous variable.

Hi @YangBarry, great question! the approach you indicated could be a feasible strategy. Have a look also at this follow up work of ours: https://github.com/d909b/drnet
best wishes,
Patrick


Off delay in Domoticz doesn’t work

Issue description
When i use the option “off delay” in Domoticz the switch should switch off after the given time when it is turned on. This has always worked fine until last update of the plugin (don’t know the number). The on delay works fine and other switches then zigbee2mqtt also works fine, like hue switches or z-wave switches, it is only the Zigbee that doesn’t work.
Additional information
Zigbee2MQTT version: 1.23.0-dev
Python version: python 3
Domoticz version: 2022.1 stable
Plugin version: 3.1.0-beta
Logs
Don’t have any log or error, don’t know how to debug this.

Same issue here

Same issue here so, Please, answer us !!

I am using:
Version: 2022.1 (build 14285)
Build Hash: 7cac83ba6
Compile Date: 2022-03-17 08:46:22
dzVents Version: 3.1.8
Python Version: 3.7.3 (default, Jan 22 2021, 20:04:44) [GCC 8.3.0]
With plugin version 3.0.1 from 13 jun 2021
and the 'off delay' is working as it should.

Many thanks SargonofAssyria for your feedback
It seems it is the 3.1.0 beta who has an issue.
I think I'll try to go back to an older version (after a backup ;-))

I can confirm 3.01 is working thanks to SargonofAssyria.
I also can confirm that this (https://github.com/stas-demydiuk/domoticz-zigbee2mqtt-plugin/issues/325 Switch to DomoticzEx Framework) is the one that breaks the off delay.
Can this be fixed?

Is this a problem in the plugin or in the framework? There were a lot of issues with the framework initially (like it did not trigger devicechanged if the value that was set was the same as current - making push buttons useless). If it is in the framework, then it should be raised as an issue in Domoticz repo.

That’s a valid question, I don’t know and I don’t know how to debug this.
one thing is the Zigbee plugin is the only plugin I have with this problem, others like hue, Bluetooth or zwave don’t show this behaviour.

The framework is only for python plugins afaik. If the other python plugins produce this behavior then I’d say it is the framework.

Closing the issue as it isn't related to the plugin and caused by Domoticz itself, feel free to raise the ticket in the Domoticz repository


haskellPackages.system-fileio: disable checks

Description of changes

This disables tests of system-fileio as they don't typecheck after ghc 8.4.
It seems to be introduced by an api update of the unix library.
Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)

[ ] sandbox = relaxed
[ ] sandbox = true

[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[x] Fits CONTRIBUTING.md.

Add a :+1: reaction to pull requests you find important.

Thank you. I’d much prefer if the explanation you gave would be in a comment (possible with a link to an issue) than in the PR description.

Also please target this PR at the haskell-updates branch and make sure to mark it as draft before switching the target because it might accidentally ping a lot of people.

Thank you. I’d much prefer if the explanation you gave would be in a comment (possible with a link to an issue) than in the PR description.

Couldn't find a matching issue, but I also didn't put enough work in to be certain it doesn't exist.

Yeah, fine. Let’s role with this. Thank you.

Thanks!


chore(deps): bump https://github.com/jenkins-x/jx-cli to 3.0.378

Update jenkins-x/jx-cli to 3.0.378
Command run was ./promote/main

[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by:
To complete the pull request process, please assign abayer
You can assign the PR to them by writing /assign @abayer in a comment when ready.
The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment


New rule: require-newline-before-single-statements

requireNewLineBeforeSingleStatements: New rule
Enforce newlines for expression statements within if/else
Fixes #1829 - issue

Hm, maybe requireNewlineBeforeSingleStatementsInIf name could be more explanatory?

Sure, that makes sense. Could also allow options to work with if/else, for etc... Don't want to make it more complicated than it needs. What do you think?

Could also allow options to work with if/else, for etc...

I think we can consider using different rule for that?

Sure another rule for those makes sense. I'll change the rule name to be requireNewlineBeforeSingleStatementsInIf

I changed the rule name to requireNewlineBeforeSingleStatementsInIf If things look OK I can squash the commits if you'd like.


Disallow creating Big* numbers from infinity or NaN

BigInt, BigFloat, BigRational, and BigDecimal do not support infinity or NaN; trying to construct them will raise SIGFPE or some other less specific Crystal exception. This PR makes such attempts raise ArgumentError.

Majority is not all and does not constitute a mandatory style guide. That's why that issue exists.

True, what's the point of introducing more of the style that's a lesser occurrence though?

If the linked issue is not about stdlib errors, then that means the casing here is not an issue to begin with. Then that issue should be adapted for the stdlibs as well, not this PR.

If the linked issue is not about stdlib errors [1], then that means the casing here is not an issue to begin with [2].

Nope, that's a logical fallacy. [1] does not imply [2] in any way.
Thing is, stdlib errors are title-cased in majority of the cases (remaining minority is probably more of an omission), some of the examples:

https://github.com/crystal-lang/crystal/blob/27f395066e256a162c1c6694c476b23aa2253484/src/gc.cr#L20
https://github.com/crystal-lang/crystal/blob/27f395066e256a162c1c6694c476b23aa2253484/src/csv.cr#L210
https://github.com/crystal-lang/crystal/blob/27f395066e256a162c1c6694c476b23aa2253484/src/env.cr#L57
https://github.com/crystal-lang/crystal/blob/27f395066e256a162c1c6694c476b23aa2253484/src/xml.cr#L56
https://github.com/crystal-lang/crystal/blob/27f395066e256a162c1c6694c476b23aa2253484/src/mime.cr#L160
https://github.com/crystal-lang/crystal/blob/27f395066e256a162c1c6694c476b23aa2253484/src/uuid.cr#L54
https://github.com/crystal-lang/crystal/blob/27f395066e256a162c1c6694c476b23aa2253484/src/range.cr#L375
https://github.com/crystal-lang/crystal/blob/27f395066e256a162c1c6694c476b23aa2253484/src/tuple.cr#L162
https://github.com/crystal-lang/crystal/blob/27f395066e256a162c1c6694c476b23aa2253484/src/deque.cr#L63
https://github.com/crystal-lang/crystal/blob/27f395066e256a162c1c6694c476b23aa2253484/src/complex.cr#L57
https://github.com/crystal-lang/crystal/blob/27f395066e256a162c1c6694c476b23aa2253484/src/io/argf.cr#L57
https://github.com/crystal-lang/crystal/blob/27f395066e256a162c1c6694c476b23aa2253484/src/char.cr#L684
https://github.com/crystal-lang/crystal/blob/27f395066e256a162c1c6694c476b23aa2253484/src/random.cr#L120
https://github.com/crystal-lang/crystal/blob/27f395066e256a162c1c6694c476b23aa2253484/src/io/memory.cr#L351
https://github.com/crystal-lang/crystal/blob/27f395066e256a162c1c6694c476b23aa2253484/src/ecr/lexer.cr#L106
https://github.com/crystal-lang/crystal/blob/27f395066e256a162c1c6694c476b23aa2253484/src/enum.cr#L451
https://github.com/crystal-lang/crystal/blob/27f395066e256a162c1c6694c476b23aa2253484/src/regex/pcre.cr#L11
https://github.com/crystal-lang/crystal/blob/27f395066e256a162c1c6694c476b23aa2253484/src/xml/reader.cr#L128

I don't get why can't you just acknowledge this fact and move along?


The default behavior for state selection should be inclusive

The default behavior for state selection (-s, --state) should be inclusive and not exclusive.  Exclusive should be kept but only used with the addition of another option (-e --exclusive)

This has been addressed in commits c552f10060ac67f9527ee77b82319d662f2712a3 and d19666a70cb43a84a66d9eb0a04bf092cabe6c5a.  Travis CI is passing.  Leaving open until documented.


Document new browser entity format

Opener 1.1 introduces support for opening links in browsers. The changes to the manifest for this are present on master, but the README hasn't been updated documenting the format. It's sort of like mashing the three existing app, action, and format entities into one.

Done in https://github.com/timonus/OpenerManifest/commit/ade3081c9a5fc7fdc7ca5e726e18427bd5a97d24.


Crash in r_quad_create()

I'm experiencing a crash in the debug build when r_ctx_create() creates the default quad. It's setting the use_vto arg to 0 so the returned quad struct has an uninitialized vto value. Setting vto to 0 should fix it.

Hey, I added a few changes in the latest commit. Can you check if these are still present on your machine with the latest commit (91fd57d7c23e57ca9ce87fcb18fabef74882a08c)?

Fixed

Glad to hear! Thank you for taking the time to test & report this! :)


New line added on windows but works fine for linux for 5.0.3

Hi, first thanks for the awesome work on isort,
It seems there is an issue with isort 5.0.3 on Windows.
The example below is failing on Windows but works on Linux.
isort_test_file.py:
try:
    import datadog_agent

    from ..log import CheckLoggingAdapter, init_logging

    init_logging()
except ImportError:
    pass

Command used:
isort --check-only --diff isort_test_file.py

Output on windows:
2020-07-06T10:32:38.8847283Z ERROR: D:\a\1\s\isort_test_file.py Imports are incorrectly sorted and/or formatted.
2020-07-06T10:32:38.8848516Z --- D:\a\1\s\isort_test_file.py:before	2020-07-06 10:30:34.221084
2020-07-06T10:32:38.8850018Z +++ D:\a\1\s\isort_test_file.py:after	2020-07-06 10:32:38.883964
2020-07-06T10:32:38.8850842Z @@ -1,6 +1,7 @@
2020-07-06T10:32:38.8851503Z  try:
2020-07-06T10:32:38.8852062Z
2020-07-06T10:32:38.8852487Z      import datadog_agent
2020-07-06T10:32:38.8852759Z
2020-07-06T10:32:38.8853257Z
2020-07-06T10:32:38.8853464Z
2020-07-06T10:32:38.8854079Z +
2020-07-06T10:32:38.8854581Z      from ..log import CheckLoggingAdapter, init_logging
2020-07-06T10:32:38.8854849Z
2020-07-06T10:32:38.8855776Z
2020-07-06T10:32:38.8855957Z
2020-07-06T10:32:38.8856123Z      init_logging()

Azure Pipeline CI Build link
Example Code
Python version: 3.8.3
Windows image: windows-2019

Possibly same as (or related) https://github.com/timothycrosley/isort/issues/1277

Thanks for reporting this bug! You were correct that it was highly related to #1277. A fix was just released in 5.0.8 with an additional regression test added.

Awesome, thanks!


RTSP server running on Android phone

RTSP server running on Android phone
Instead of hosting the RSP server on a Linux machine, it would be reat if we could run the server on an Android Phone.
Other phones/devices on same network can broadcast and receive the video feeds.

Hello, rtsp-simple-server is full compatible with arm6, arm7 and arm8 architectures, therefore you can already compile it for android and integrate it into any existing app.


Docs - remove extra grid

Check this page https://webpack.js.org/plugins/

@styopdev thanks for your contribution! This was actually fixed in #1429 which I just merged so let's close this one out. Should be deployed within the next few hours.


What version of OCPP complaint stack is supported?

Dear @bigadsoleiman
Does the OCPP complaint Gateway on AWS IOT core supports OCPP  version 1.6J or it is restricted to Ocpp 2.0/2.0.1 ? please advise.
Regards,
Bhuvi-Naveen

It supports both 1.6J and 2.0.x versions of OCPP.

Hi @galinsky,
Thanks for the confirmation.
regards,
Bhuvi-Naveen


container not running properly

I made my own container in /config and ran with the ./docker_run.bash.... command. Then when running $ docker logs -f it tells me there is no such container? But if I use one of the containers already in the config file it runs perfectly.
Sorry I'm brand new to all of this! Thanks for the help!

Had a similar situation. What text editor did you use to write the config file? For me, the issue was writing the config file on a Mac in TextEdit, then copying it to the Pi. Docker didn’t seem to like that. So I ended up just copy pasting the contents inside new files instead, which I had created/edited with the nano command.

Had a similar situation. What text editor did you use to write the config file? For me, the issue was writing the config file on a Mac in TextEdit, then copying it to the Pi. Docker didn’t seem to like that. So I ended up just copy pasting the contents inside new files instead, which I had created/edited with the nano command.


12.0.0.preview-27 banana cake pop editor missing sidebar entry

No null reference exception anymore as related to: #3989, but now missing sidebar entry.

/graphql?sdl is retrievable.

Try clearing your browser cache.

Thanks Michael that worked.


how about the results of using scrl for classification task?

how about the results of using scrl for classification task?  do you have the results?

We have not transferred SCRL to classification tasks, but the results of linear evaluation results reported in the paper could give you a hint for your question. Spatially consistent representation may hurt the performance of the tasks that need global semantic representation. We are working on those problems now as future work. Thanks.


Input clash handling

Problem
Fixes #23.
In many applications, overlapping inputs are special cased, to avoid surprising results, especially with modifier keys.
If Ctrl + V and Ctrl + Shift + V only pastes without formatting, rather than doing that and pasting normally.
Solution
Two inputs are said to clash if one is a strict subset of the other.
Allow users to configure their input maps to decide how they want to handle clashing inputs.
pub enum ClashStrategy {
    /// All matching inputs will always be pressed
    PressAll,
    /// Only press the action that corresponds to the longest chord
    PrioritizeLongest,
    /// If the [`UserInput`] contains a modifier key (defined at the input map level), press that action over any unmodified action.
    ///
    /// If more than one matching action uses a modifier, break ties based on number of modifiers.
    /// Further ties are broken using the `PrioritizeLongest` rule.
    PrioritizeModified,
    /// Use the order in which actions are defined in the enum to resolve clashing inputs
    ///
    /// Uses the iteration order returned by [IntoEnumIterator](crate::IntoEnumIterator),
    /// which is generated in order of the enum items by the `#[derive(EnumIter)]` macro.
    UseActionOrder,
}

To do

[x] actually handle clashes according to the selected strategy
[x] add integration tests to verify that this works as expected
[x] add an example demonstrating how this works

Done! Merging now.


Add license to packages

Add license file to package and wheels.
Closes #16
cc @jakirkham

Looks good. One comment above. Thanks @jacobtomlinson !


changing the short name of the preflightvalidation CRD

Much better than the previous confusing name :)
/lgtm

Codecov Report
Base: 77.83% // Head: 77.83% // No change to project coverage :thumbsup:

Coverage data is based on head (542465b) compared to base (357bb32).
Patch has no changes to coverable lines.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #225   +/-   ##
=======================================
  Coverage   77.83%   77.83%
=======================================
  Files          26       26
  Lines        2689     2689
=======================================
  Hits         2093     2093
  Misses        493      493
  Partials      103      103

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.


Replace regex-based email validation

Describe the enhancement you'd like
Replace regex-based email validation with something more robust & easier to read
Describe why this will benefit the LibrePhotos
It appears the general consensus on email validation is that regex is a suboptimal solution. I'm no expert here, but some compelling arguments I've seen are:

it's difficult to read and maintain
if it's not overly difficult to read, it's likely violating RFC 5322

The current solution for email validation has proven problematic at least twice, including #689, #637; perhaps more.
Additional context
This SO post shows exactly how complicated a "proper" regex-based email validator would be, and it's essentially impossible to read:
(?:[a-z0-9!#$%&'*+/=?^_`{|}~-]+(?:\.[a-z0-9!#$%&'*+/=?^_`{|}~-]+)*|"(?:[\x01-\x08\x0b\x0c\x0e-\x1f\x21\x23-\x5b\x5d-\x7f]|\\[\x01-\x09\x0b\x0c\x0e-\x7f])*")@(?:(?:[a-z0-9](?:[a-z0-9-]*[a-z0-9])?\.)+[a-z0-9](?:[a-z0-9-]*[a-z0-9])?|\[(?:(?:(2(5[0-5]|[0-4][0-9])|1[0-9][0-9]|[1-9]?[0-9]))\.){3}(?:(2(5[0-5]|[0-4][0-9])|1[0-9][0-9]|[1-9]?[0-9])|[a-z0-9-]*[a-z0-9]:(?:[\x01-\x08\x0b\x0c\x0e-\x1f\x21-\x5a\x53-\x7f]|\\[\x01-\x09\x0b\x0c\x0e-\x7f])+)\])

I do agree that regexp for the correct email is complex. But I also want to point out that all variations of the valid email are rarely used. That's why the current implementation is capturing the most commonly used email formats.
Whatever the current solution is, it is not set in stone. If you have an email address that the current pattern does not match, you are free to update the pattern yourself. If you think there is a better solution to verify email address correctness, feel free to share.

You've got a fair point; it sounds like a low-priority (and perhaps low-effort) task. In the meantime I suppose we can continue updating the regex when issues arise.
I'd love to contribute here, but I've got no experience with TypeScript (or any front-end work really), so I'm probably not the best person to work on this issue specifically.
Maybe a good first issue for someone with more experience and interest in TS or front-end development?


R3.5, update recipe, update version to 3.0.0

Hi! This is the friendly automated conda-forge-linting service.
I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

@endrebak @bgruening Ready to merge!


Libs / profitSwitch.Js line 322 , TypeError: response.forEach is not a function

TypeError: response.forEach is not a function at /libs/profitSwitch.js:322:34
Error occcurs when the api connection towards Stex / Crex is not succesfull

Fix does not help.
/root/equihash144/libs/profitSwitch.js:213
if (!response.isArray()){
^
TypeError: response.isArray is not a function

oof

Fix does not help.
/root/equihash144/libs/profitSwitch.js:213
if (!response.isArray()){
^
TypeError: response.isArray is not a function

oof!  I will fix and submit PR!


Schema Compatibility validation is not applied

I have been testing the tool, but it seems that it is not validating the schema compatibility correctly, e.g. if I change the name of a schema field with the compatibility level set to backward it allows me to apply the change:
2022-12-28 14:57:10.672 INFO    ~ schema   {
    "schema" : {
      "properties" : {
        "id" : {
          "type" : "string"
        },
-       "message" : {
+       "messagex" : {
          "type" : "string"
        }
      },
      "required" : [ "message" ],
      "type" : "object",
      "title" : "foo-event"
    },
    "schemaType" : "JSON"
  }
2022-12-28 14:57:10.672 INFO
2022-12-28 14:57:10.672 INFO [SUCCESS] All changes are compatible and can be applied.

I tried using it with the docker image and compiling locally from the master branch and got the same results no schema validation at all.

I close the issue because I realized that the problem was in the schema format I noticed that when my springboot java application did not either validate the schema.


Correct 'Project Ibiza Partners' SG join links - allowing for gallery package uploading

Update the group: Project Ibiza Partners - PMs with a working link
Update the group: Project Ibiza Partners - Engineering teams with a working link

thanks making the docs better! One small bump is that the file you are modifying is an auto-gen file and will get replaced. You'll need to update the source files in our internal repo instead: https://msazure.visualstudio.com/One/_git/AzureUX-PortalFx?path=/docs/portal-sdk/templates/top-onboarding.md


change the command API so as to not lump aggregate and event serialization into a single trait/argument

This is required for analogous changes in surge-ukg

Codecov Report

:exclamation: No coverage uploaded for pull request base (main@da8e0b4). Click here to learn what that means.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main      #13   +/-   ##
=======================================
  Coverage        ?   74.74%
=======================================
  Files           ?      127
  Lines           ?     2178
  Branches        ?       63
=======================================
  Hits            ?     1628
  Misses          ?      550
  Partials        ?        0

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update da8e0b4...dc7f229. Read the comment docs.


Dockerfile added

Description
Add Dockerfile to build and run the Juno in a container
Changes:

Dockerfile added

Types of changes

Build related changes

Testing
Requires testing: Yes
Did you write tests?: No
Documentation
If this requires a documentation update, did you add one? No

do we have the necessary github actions to build docker images as well?

do we have the necessary github actions to build docker images as well?

Yeah you were right, actually there was a GitHub action for building and pushing the image, but it was deprecated and not working - I added and tested a new one.

You can squash or rebase and merge. Please make sure to follow the commit message guideline mentioned here. Your first commit should be reworded to Add Dockerfile instead of Dockerfile Added

Sorry I approved prematurely. Can we merge the docker workflow files as @omerfirmak suggested? We don't want to have duplication.

Files merged.

One last thing, can we enable building docker images on pull requests but not push them? So that we can make sure images build fine before merging them to the branch.

One last thing, can we enable building docker images on pull requests but not push them? So that we can make sure images build fine before merging them to the branch.

Done.


Weight normalization for RNN Cells.

The current RNN implementation executes a user defined
function (the call() method of subclasses of RNNCells) inside a
tf.while() loop. Weight normalisation requires a one-time
normalization of the transition matrices prior to
entering the while loop. The following 2 edits have been made in
tensorflow/python/ops to enable this functionality:

RNNCell now has a prepare() method. It does nothing as implemented
in the base class
A call to cell.prepare() has been added just before entering
_dynamic_rnn_loop()

Subclasses of RNNCell may implement normalization in the cell's
prepare() method. One implementation with BasicLSTMCell
and associated tests have been added to contrib. Note that any
wrappers to be used with a weight-normalized cell need to be
appropriately subclassed, as illustrated with the
PrepareableMultiRNNCell example in contrib.

Can one of the admins verify this patch?

Hi @ebrevdo, the NLP team from Winton will be at the ACL conference next week. We will be happy to meet with someone from the tensorflow team if they are attending. We thought it might be more efficient seeing as this PR proposes an update in core tensorflow and might require further discussion/alternate implementation ideas.

IIRC @ebrevdo just went on vacation for 2 weeks, and he's the best person to look at this change.  Is this urgent, or can it wait for him to get back?  Adding an (optional) API to something as core as the RNN interface probably deserves some careful thought, which I know you've already spent some time thinking about!

The problem is one of optimizing ops out of the while_loop context. I have
a change I'm working on to move ops obviously constant w.r.t the while loop
out of it automatically.  In the meantime you can use:
with tf.control_dependencies(None):
  Add ops that should be executed outside the loop (be very careful)

For example to do the normalization.
On Jul 25, 2017 9:37 PM, "Vijay Vasudevan"<EMAIL_ADDRESS>wrote:

IIRC @ebrevdo https://github.com/ebrevdo just went on vacation for 2
weeks, and he's the best person to look at this change. Is this urgent, or
can it wait for him to get back? Adding an (optional) API to something as
core as the RNN interface probably deserves some careful thought, which I
know you've already spent some time thinking about!
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/tensorflow/tensorflow/pull/11573#issuecomment-317945170,
or mute the thread
https://github.com/notifications/unsubscribe-auth/ABtim5niCLzqFNNmgzqWYaQe-nYRtTxuks5sRsKigaJpZM4ObNVj
.

@ebrevdo Thanks for pointing out the use of control_dependencies. I had a slightly different reading of semantics of the None argument in there - meaning the ops would just run normally as if tf.control_dependencies wasn't there at all.
Not quite sure how the tf.while skips these ops during the loop. But it solved the problem!

Hi @ebrevdo , Hope you've had a nice vacation when you see this.
I've updated the PR with more commits (squashed) to include documentation and formatting, mostly following the pylint template and existing code in contrib. I should mention here that most of the code is adapted from rnn_cell_impl.LSTMCell with an additional norm argument, which if True, does the normalization, else returns the same outputs as rnn_cell_impl.LSTMCell. I've included this information in the docstrings.
Hopefully these changes are in the right direction. Looking forward to your comments.

@ebrevdo could you please take another look?

Back Thursday
On Aug 8, 2017 9:29 AM, "Rasmus Munk Larsen"<EMAIL_ADDRESS>wrote:

@ebrevdo https://github.com/ebrevdo could you please take another look?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/tensorflow/tensorflow/pull/11573#issuecomment-321057363,
or mute the thread
https://github.com/notifications/unsubscribe-auth/ABtim4OttaDpbt8m80sOyfX2FdipD542ks5sWLcUgaJpZM4ObNVj
.

@tensorflow-jenkins  test this please

Hi @ebrevdo , did you get a chance to look at the code? I triggered a Jenkins build earlier which seems to be okay.

Hi @rmlarsen @ebrevdo , any news on this?

@ebrevdo any chance to take a look?

@ebrevdo please take a look

Jenkins, test this please.

Jenkins, test this please

Jenkins, test this please

Jenkins, test this please

Jenkins, test this please

Looks like rnn_cell_test is failing due to this PR:
https://source.cloud.google.com/results/invocation/52c608cb-76cc-4f18-9c65-39e70a9740ce/targets/%2F%2Ftensorflow%2Fcontrib%2Frnn:rnn_cell_test?page=log
exec ${PAGER:-/usr/bin/less} "$0" || exit 1
-----------------------------------------------------------------------------
Traceback (most recent call last):
  File "/tmp/botexec/bazel-out/k8-py3-opt/bin/tensorflow/contrib/rnn/rnn_cell_test.runfiles/org_tensorflow/tensorflow/contrib/rnn/python/kernel_tests/rnn_cell_test.py", line 40, in <module>
    from tensorflow.python.ops.losses import losses_impl
ModuleNotFoundError: No module named 'tensorflow.python.ops.losses'

Maybe missing BUILD dependencies?

Hi @gunan , what would be the preferred way to do this. Should I just add another commit to this PR? Or a new PR/review process will be required?
Thanks
Ashwini

Please add a new commit to this PR. Looks like you will also need to rebase your changes on top of master, as you can see there are some merge conflicts now.

Jenkins, test this please

Jenkins, test this please

Hi @gunan , I've added new commits fixing the merge breaks.
The python tests rnn_cell_test.py and rnn_test.py are running OK with a fresh pip install of tensorflow 1.4. It's a bit strange since the build on your side was failing on tensorflow.python.ops.losses which seems to be fine with the pip install version. Not sure why this difference.
Could you may be try again?
Thanks
Ashwini

@discoveredcheck thanks for the updates.
The tests that are run on the pull request build the pip package from scratch and run the tests on them. So the pip tests do not run on any prebuilt packages.
Jenkins, test this please.

Jenkins, test this please

Hi @gunan , I was able to reproduce the test failure locally with Bazel, it should be fixed after my last commit. I ran the Jenkins build last night but it still seems to be "Waiting for status". All rnn tests should now pass.
Cheers
Ashwini
Jenkins, test this please.

Jenkins, test this please.

Thanks for running the build @gunan . Looks all good for rnn?

Removed lines of commented out code. Have left in pylint and explanatory comments.

Update your PR message, it's outdated.

Thanks for your comments @ebrevdo . I've update the PR message and code accordingly. Squashed the commits as well.
Jenkins, test this please.

@discoveredcheck quick ping on this.

Hi @ebrevdo, I have pushed in commits covering your latest review comments (multiline lambdas, PR message and commented-out lines of code). Is there anything else that needs change?

@discoveredcheck the change has been approved, but you need to pull rebase and push again. Then we'll run the tests.

@discoveredcheck can you please resolve conflicts before we test again and merge the PR?


Extension not working on WSL.

I'm getting this error on WSL side

On Windows side, it's not working either, but not showing any error. It just auto select the color but no picker is prompted.

Extension Version: 0.4.5
VS Code Version: 1.52.1
OS Version: Windows 10 Pro
Node.js Version (result of command node -v): 14.6.0
NPM Version (result of command npm -v): 6.14.6

Steps to Reproduce:

Install extension on WSL
select a color and trigger color picker (ALT + C / P)

Log (All lines):
(Click menu of VS Code "Help > Toggle Developer Tools", and click "Console" tab)
Extension Host
/C:/Users/melio/AppData/Local/Programs/Microsoft VS Code/resources/app/out/vs/workbench/workbench.desktop.main.js:5009 [0126/204917.473:ERROR:registration_protocol_win.cc(103)] CreateFile: The system cannot find the file specified. (0x2)
7/C:/Users/melio/AppData/Local/Programs/Microsoft VS Code/resources/app/out/vs/workbench/workbench.desktop.main.js:5432 [MehediDracula.php-namespace-resolver]: Menu item references the same command as default and alt-command
12/C:/Users/melio/AppData/Local/Programs/Microsoft VS Code/resources/app/out/vs/workbench/workbench.desktop.main.js:5432 [Hridoy.jquery-snippets]: Unknown language in `contributes.jquery-snippets.language`. Provided value: 'javascript'
_logMessageInConsole @ /C:/Users/melio/AppData/Local/Programs/Microsoft VS Code/resources/app/out/vs/workbench/workbench.desktop.main.js:5432
workbench.html:1 A cookie associated with a cross-site resource at https://visualstudio.com/ was set without the `SameSite` attribute. A future release of Chrome will only deliver cookies with cross-site requests if they are set with `SameSite=None` and `Secure`. You can review cookies in developer tools under Application>Storage>Cookies and see more details at https://www.chromestatus.com/feature/5088147346030592 and https://www.chromestatus.com/feature/5633521622188032.
/C:/Users/melio/AppData/Local/Programs/Microsoft VS Code/resources/app/out/vs/workbench/workbench.desktop.main.js:5519 Overwriting grammar scope name to file mapping for scope source.yaml.
Old grammar file: file:///c%3A/Users/melio/AppData/Local/Programs/Microsoft%20VS%20Code/resources/app/extensions/yaml/syntaxes/yaml.tmLanguage.json.
New grammar file: vscode-remote://wsl%2Bubuntu-20.04/home/ilan/.vscode-server/extensions/redhat.vscode-yaml-0.14.0/syntaxes/yaml.tmLanguage.json
register @ /C:/Users/melio/AppData/Local/Programs/Microsoft VS Code/resources/app/out/vs/workbench/workbench.desktop.main.js:5519
/C:/Users/melio/AppData/Local/Programs/Microsoft VS Code/resources/app/out/vs/workbench/workbench.desktop.main.js:310 [Extension Host] (node:9169) [DEP0005] DeprecationWarning: Buffer() is deprecated due to security and usability issues. Please use the Buffer.alloc(), Buffer.allocUnsafe(), or Buffer.from() methods instead.
t.log @ /C:/Users/melio/AppData/Local/Programs/Microsoft VS Code/resources/app/out/vs/workbench/workbench.desktop.main.js:310
/C:/Users/melio/AppData/Local/Programs/Microsoft VS Code/resources/app/out/vs/workbench/workbench.desktop.main.js:310 [Extension Host] Looking for parseable documents...
/C:/Users/melio/AppData/Local/Programs/Microsoft VS Code/resources/app/out/vs/workbench/workbench.desktop.main.js:1779   ERR [MobX] minified error nr: 35. Find the full error at: https://github.com/mobxjs/mobx/blob/mobx6/src/errors.ts: Error: [MobX] minified error nr: 35. Find the full error at: https://github.com/mobxjs/mobx/blob/mobx6/src/errors.ts
    at r (c:\Users\melio\.vscode\extensions\codespaces-contrib.codeswing-0.0.8\dist\extension.js:2:1014430)
    at Timeout._onTimeout (c:\Users\melio\.vscode\extensions\codespaces-contrib.codeswing-0.0.8\dist\extension.js:2:1031908)
    at listOnTimeout (internal/timers.js:531:17)
    at processTimers (internal/timers.js:475:7)
/C:/Users/melio/AppData/Local/Programs/Microsoft VS Code/resources/app/out/vs/workbench/workbench.desktop.main.js:310 [Extension Host] PHP Language Server: DEBUG     Checking PHPLS_ALLOW_XDEBUG
DEBUG     The xdebug extension is not loaded

/C:/Users/melio/AppData/Local/Programs/Microsoft VS Code/resources/app/out/vs/workbench/workbench.desktop.main.js:310 [Extension Host] PHP process connected
/C:/Users/melio/AppData/Local/Programs/Microsoft VS Code/resources/app/out/vs/workbench/workbench.desktop.main.js:310 [Extension Host] swdc-vscode: Loaded softwaredotcom.swdc-vscode v2.4.3
/C:/Users/melio/AppData/Local/Programs/Microsoft VS Code/resources/app/out/vs/workbench/workbench.desktop.main.js:310 [Extension Host] Found all parseable documents.
/C:/Users/melio/AppData/Local/Programs/Microsoft VS Code/resources/app/out/vs/workbench/workbench.desktop.main.js:310 [Extension Host] Parsing documents and looking for CSS class definitions...
/C:/Users/melio/AppData/Local/Programs/Microsoft VS Code/resources/app/out/vs/workbench/workbench.desktop.main.js:310 [Extension Host] swdc-tracker initialized and ready to send events to com-software-prod1.collector.snplow.net
/C:/Users/melio/AppData/Local/Programs/Microsoft VS Code/resources/app/out/vs/workbench/workbench.desktop.main.js:310 [Extension Host] Summary:
/C:/Users/melio/AppData/Local/Programs/Microsoft VS Code/resources/app/out/vs/workbench/workbench.desktop.main.js:310 [Extension Host]% 186 parseable documents found
/C:/Users/melio/AppData/Local/Programs/Microsoft VS Code/resources/app/out/vs/workbench/workbench.desktop.main.js:310 [Extension Host]% 56907 CSS class definitions found
/C:/Users/melio/AppData/Local/Programs/Microsoft VS Code/resources/app/out/vs/workbench/workbench.desktop.main.js:310 [Extension Host]% 4482 unique CSS class definitions found
/C:/Users/melio/AppData/Local/Programs/Microsoft VS Code/resources/app/out/vs/workbench/workbench.desktop.main.js:310 [Extension Host]% 14 failed attempts to parse. List of the documents:
/C:/Users/melio/AppData/Local/Programs/Microsoft VS Code/resources/app/out/vs/workbench/workbench.desktop.main.js:310 [Extension Host] /home/ilan/code/wp-boston/vendor/squizlabs/php_codesniffer/src/Standards/Squiz/Tests/CSS/ShorthandSizeUnitTest.css/home/ilan/code/wp-boston/vendor/squizlabs/php_codesniffer/src/Standards/Squiz/Tests/CSS/MissingColonUnitTest.css/home/ilan/code/wp-boston/vendor/squizlabs/php_codesniffer/src/Standards/Squiz/Tests/CSS/SemicolonSpacingUnitTest.css/home/ilan/code/wp-boston/vendor/squizlabs/php_codesniffer/src/Standards/Squiz/Tests/CSS/ColonSpacingUnitTest.css/home/ilan/code/wp-boston/vendor/squizlabs/php_codesniffer/src/Standards/Squiz/Tests/CSS/ClassDefinitionNameSpacingUnitTest.css/home/ilan/code/wp-boston/vendor/squizlabs/php_codesniffer/src/Standards/Squiz/Tests/CSS/ClassDefinitionOpeningBraceSpaceUnitTest.css/home/ilan/code/wp-boston/vendor/squizlabs/php_codesniffer/src/Standards/Squiz/Tests/CSS/IndentationUnitTest.1.css/home/ilan/code/wp-boston/vendor/squizlabs/php_codesniffer/src/Standards/Squiz/Tests/CSS/DisallowMultipleStyleDefinitionsUnitTest.css/home/ilan/code/wp-boston/vendor/squizlabs/php_codesniffer/src/Standards/Squiz/Tests/CSS/IndentationUnitTest.2.css/home/ilan/code/wp-boston/vendor/squizlabs/php_codesniffer/src/Standards/Squiz/Tests/CSS/DuplicateStyleDefinitionUnitTest.css/home/ilan/code/wp-boston/node_modules/combine-source-map/node_modules/convert-source-map/test/fixtures/map-file-comment-double-slash.css/home/ilan/code/wp-boston/css/style.min.css/home/ilan/code/wp-boston/vendor/squizlabs/php_codesniffer/src/Standards/Generic/Tests/VersionControl/GitMergeConflictUnitTest.2.css/home/ilan/code/wp-boston/vendor/squizlabs/php_codesniffer/src/Standards/Generic/Tests/VersionControl/GitMergeConflictUnitTest.1.css
/C:/Users/melio/AppData/Local/Programs/Microsoft VS Code/resources/app/out/vs/workbench/workbench.desktop.main.js:310 [Extension Host] Start child process...
/C:/Users/melio/AppData/Local/Programs/Microsoft VS Code/resources/app/out/vs/workbench/workbench.desktop.main.js:310 [Extension Host] Check version of: electron-prebuilt
/C:/Users/melio/AppData/Local/Programs/Microsoft VS Code/resources/app/out/vs/workbench/workbench.desktop.main.js:310 [Extension Host] Check version of: comma-separated-values
/C:/Users/melio/AppData/Local/Programs/Microsoft VS Code/resources/app/out/vs/workbench/workbench.desktop.main.js:310 [Extension Host] Check version of: js-yaml
/C:/Users/melio/AppData/Local/Programs/Microsoft VS Code/resources/app/out/vs/workbench/workbench.desktop.main.js:310 [Extension Host] Check version of: process-bridge
/C:/Users/melio/AppData/Local/Programs/Microsoft VS Code/resources/app/out/vs/workbench/workbench.desktop.main.js:310 [Extension Host] Try to send IPC message: 1
/C:/Users/melio/AppData/Local/Programs/Microsoft VS Code/resources/app/out/vs/workbench/workbench.desktop.main.js:310 [Extension Host] Error: write EPIPE    at ChildProcess.target._send (internal/child_process.js:806:20)    at ChildProcess.target.send (internal/child_process.js:676:19)    at /home/ilan/.vscode-server/extensions/anseki.vscode-color-0.4.5/node_modules/process-bridge/process-bridge.js:418:19    at Array.forEach (<anonymous>)    at sendIpc (/home/ilan/.vscode-server/extensions/anseki.vscode-color-0.4.5/node_modules/process-bridge/process-bridge.js:416:18)    at sendMessage (/home/ilan/.vscode-server/extensions/anseki.vscode-color-0.4.5/node_modules/process-bridge/process-bridge.js:430:7)    at /home/ilan/.vscode-server/extensions/anseki.vscode-color-0.4.5/node_modules/process-bridge/process-bridge.js:529:51    at Array.forEach (<anonymous>)    at /home/ilan/.vscode-server/extensions/anseki.vscode-color-0.4.5/node_modules/process-bridge/process-bridge.js:529:23    at /home/ilan/.vscode-server/extensions/anseki.vscode-color-0.4.5/node_modules/process-bridge/process-bridge.js:394:19    at getHostCmd (/home/ilan/.vscode-server/extensions/anseki.vscode-color-0.4.5/node_modules/process-bridge/process-bridge.js:365:5)    at /home/ilan/.vscode-server/extensions/anseki.vscode-color-0.4.5/node_modules/process-bridge/process-bridge.js:394:19    at Object.exports.sendRequest (/home/ilan/.vscode-server/extensions/anseki.vscode-color-0.4.5/node_modules/process-bridge/process-bridge.js:468:34)    at pickConvert (/home/ilan/.vscode-server/extensions/anseki.vscode-color-0.4.5/lib/color-helper.js:187:15)    at exports.pick (/home/ilan/.vscode-server/extensions/anseki.vscode-color-0.4.5/lib/color-helper.js:229:24)    at _executeContributedCommand (/home/ilan/.vscode-server/bin/ea3859d4ba2f3e577a159bc91e3074c5d85c0523/out/vs/server/remoteExtensionHostProcess.js:725:220)    at _.$executeContributedCommand (/home/ilan/.vscode-server/bin/ea3859d4ba2f3e577a159bc91e3074c5d85c0523/out/vs/server/remoteExtensionHostProcess.js:725:595)    at m._doInvokeHandler (/home/ilan/.vscode-server/bin/ea3859d4ba2f3e577a159bc91e3074c5d85c0523/out/vs/server/remoteExtensionHostProcess.js:916:926)    at m._invokeHandler (/home/ilan/.vscode-server/bin/ea3859d4ba2f3e577a159bc91e3074c5d85c0523/out/vs/server/remoteExtensionHostProcess.js:916:618)    at m._receiveRequest (/home/ilan/.vscode-server/bin/ea3859d4ba2f3e577a159bc91e3074c5d85c0523/out/vs/server/remoteExtensionHostProcess.js:915:252)    at m._receiveOneMessage (/home/ilan/.vscode-server/bin/ea3859d4ba2f3e577a159bc91e3074c5d85c0523/out/vs/server/remoteExtensionHostProcess.js:914:6)    at /home/ilan/.vscode-server/bin/ea3859d4ba2f3e577a159bc91e3074c5d85c0523/out/vs/server/remoteExtensionHostProcess.js:912:136    at l.fire (/home/ilan/.vscode-server/bin/ea3859d4ba2f3e577a159bc91e3074c5d85c0523/out/vs/server/remoteExtensionHostProcess.js:46:801)    at v.fire (/home/ilan/.vscode-server/bin/ea3859d4ba2f3e577a159bc91e3074c5d85c0523/out/vs/server/remoteExtensionHostProcess.js:233:787)    at /home/ilan/.vscode-server/bin/ea3859d4ba2f3e577a159bc91e3074c5d85c0523/out/vs/server/remoteExtensionHostProcess.js:1118:104    at l.fire (/home/ilan/.vscode-server/bin/ea3859d4ba2f3e577a159bc91e3074c5d85c0523/out/vs/server/remoteExtensionHostProcess.js:46:801)    at v.fire (/home/ilan/.vscode-server/bin/ea3859d4ba2f3e577a159bc91e3074c5d85c0523/out/vs/server/remoteExtensionHostProcess.js:233:787)    at t.PersistentProtocol._receiveMessage (/home/ilan/.vscode-server/bin/ea3859d4ba2f3e577a159bc91e3074c5d85c0523/out/vs/server/remoteExtensionHostProcess.js:238:1004)    at /home/ilan/.vscode-server/bin/ea3859d4ba2f3e577a159bc91e3074c5d85c0523/out/vs/server/remoteExtensionHostProcess.js:235:927    at l.fire (/home/ilan/.vscode-server/bin/ea3859d4ba2f3e577a159bc91e3074c5d85c0523/out/vs/server/remoteExtensionHostProcess.js:46:801)    at p.acceptChunk (/home/ilan/.vscode-server/bin/ea3859d4ba2f3e577a159bc91e3074c5d85c0523/out/vs/server/remoteExtensionHostProcess.js:231:195)    at /home/ilan/.vscode-server/bin/ea3859d4ba2f3e577a159bc91e3074c5d85c0523/out/vs/server/remoteExtensionHostProcess.js:230:547    at Socket.t (/home/ilan/.vscode-server/bin/ea3859d4ba2f3e577a159bc91e3074c5d85c0523/out/vs/server/remoteExtensionHostProcess.js:240:822)    at Socket.emit (events.js:223:5)    at addChunk (_stream_readable.js:309:12)    at readableAddChunk (_stream_readable.js:290:11)    at Socket.Readable.push (_stream_readable.js:224:10)    at TCP.onStreamRead (internal/stream_base_commons.js:181:23)
t.log @ /C:/Users/melio/AppData/Local/Programs/Microsoft VS Code/resources/app/out/vs/workbench/workbench.desktop.main.js:310
/C:/Users/melio/AppData/Local/Programs/Microsoft VS Code/resources/app/out/vs/workbench/workbench.desktop.main.js:3183 [processBridge]: Error: write EPIPE
onDidChangeNotification @ /C:/Users/melio/AppData/Local/Programs/Microsoft VS Code/resources/app/out/vs/workbench/workbench.desktop.main.js:3183
/C:/Users/melio/AppData/Local/Programs/Microsoft VS Code/resources/app/out/vs/workbench/workbench.desktop.main.js:310 [Extension Host] [STDERR]: /home/ilan/.vscode-server/extensions/anseki.vscode-color-0.4.5/node_modules/electron-prebuilt/dist/electron: error while loading shared libraries: libgtk-x11-2.0.so.0: cannot open shared object file: No such file or directory
t.log @ /C:/Users/melio/AppData/Local/Programs/Microsoft VS Code/resources/app/out/vs/workbench/workbench.desktop.main.js:310
/C:/Users/melio/AppData/Local/Programs/Microsoft VS Code/resources/app/out/vs/workbench/workbench.desktop.main.js:310 [Extension Host] Child process disconnected
/C:/Users/melio/AppData/Local/Programs/Microsoft VS Code/resources/app/out/vs/workbench/workbench.desktop.main.js:310 [Extension Host] Child process exited with code: 127
/C:/Users/melio/AppData/Local/Programs/Microsoft VS Code/resources/app/out/vs/workbench/workbench.desktop.main.js:310 [Extension Host] Error: Child process exited with code: 127    at /home/ilan/.vscode-server/extensions/anseki.vscode-color-0.4.5/node_modules/process-bridge/process-bridge.js:478:19    at ChildProcess.<anonymous> (/home/ilan/.vscode-server/extensions/anseki.vscode-color-0.4.5/node_modules/process-bridge/process-bridge.js:394:19)    at ChildProcess.emit (events.js:223:5)    at Process.ChildProcess._handle.onexit (internal/child_process.js:272:12)
t.log @ /C:/Users/melio/AppData/Local/Programs/Microsoft VS Code/resources/app/out/vs/workbench/workbench.desktop.main.js:310
/C:/Users/melio/AppData/Local/Programs/Microsoft VS Code/resources/app/out/vs/workbench/workbench.desktop.main.js:3183 [processBridge]: Error: Child process exited with code: 127
onDidChangeNotification @ /C:/Users/melio/AppData/Local/Programs/Microsoft VS Code/resources/app/out/vs/workbench/workbench.desktop.main.js:3183
/C:/Users/melio/AppData/Local/Programs/Microsoft VS Code/resources/app/out/vs/workbench/workbench.desktop.main.js:310 [Extension Host] Error: Unexpected SIGPIPE    at process.<anonymous> (/home/ilan/.vscode-server/bin/ea3859d4ba2f3e577a159bc91e3074c5d85c0523/out/bootstrap.js:5:614)    at process.emit (events.js:223:5)
t.log @ /C:/Users/melio/AppData/Local/Programs/Microsoft VS Code/resources/app/out/vs/workbench/workbench.desktop.main.js:310
/C:/Users/melio/AppData/Local/Programs/Microsoft VS Code/resources/app/out/vs/workbench/workbench.desktop.main.js:310 [Extension Host] Error: Child process already exited.    at sendIpc (/home/ilan/.vscode-server/extensions/anseki.vscode-color-0.4.5/node_modules/process-bridge/process-bridge.js:415:31)    at Timeout.<anonymous> (/home/ilan/.vscode-server/extensions/anseki.vscode-color-0.4.5/node_modules/process-bridge/process-bridge.js:394:19)    at listOnTimeout (internal/timers.js:531:17)    at processTimers (internal/timers.js:475:7)
t.log @ /C:/Users/melio/AppData/Local/Programs/Microsoft VS Code/resources/app/out/vs/workbench/workbench.desktop.main.js:310
/C:/Users/melio/AppData/Local/Programs/Microsoft VS Code/resources/app/out/vs/workbench/workbench.desktop.main.js:3183

Hi @IlanVivanco, thank you for the comment.
The error message says that a required library is not found.
Then, the issue might be solved by installing the library.
sudo apt install libgtk2.0-dev

However, the library is old, and that might not be able to be installed into your environment.
I recommend using internal Color Picker instead because VS Code already implements it.

Hi @IlanVivanco, thank you for the comment.
The error message says that a required library is not found.
Then, the issue might be solved by installing the library.
sudo apt install libgtk2.0-dev

However, the library is old, and that might not be able to be installed into your environment.
I recommend using internal Color Picker instead because VS Code already implements it.

Hey, thanks for the reply.
I tried to install the dependency, bur had some errors fetching some libraries.
I'll rely on the VScode option, but I would need something to convert between HSL and Hex values all at once.

Hey, thanks for the reply.
I tried to install the dependency, bur had some errors fetching some libraries.
I'll rely on the VScode option, but I would need something to convert between HSL and Hex values all at once.

Thank you for the information.
So, could you close this issue?

Thank you for the information.
So, could you close this issue?

Well, technically, it's not solved. I just happened to not use it after all. But feel free to close it if you want.

Well, technically, it's not solved. I just happened to not use it after all. But feel free to close it if you want.

Ok.
We can do nothing for this issue. Then it is closed.

Ok.
We can do nothing for this issue. Then it is closed.


Remove ODR violation from filesystem fixture

The variable filesystem::directory had a different value depending on
where the header file was included, resulting in an ODR violation that
did cause some translation units to use the wrong value "SUITE" for
their directory.
$ strace -ff -etrace=file ./bin/compaction-test -v5 -s compactor -- --vast-verbosity=verbose
[...]
[pid 44522] openat(AT_FDCWD, "vast-unit-test/SUITE", O_RDONLY|O_NONBLOCK|O_CLOEXEC|O_DIRECTORY) = -1 ENOENT (No such file or directory)
!! /home/benno/tenzir/event-horizon/vast-plugins/compaction/tests/compactor.cpp:239  vast::test::detail::equality_compare((e), (caf::none)) (error(3, 'vast', ("compactor aborts space-based compaction run due to error: ", error(3, 'vast', ("No such file or directory")))) !! none)

:memo: Checklist

[ ] All user-facing changes have changelog entries.
[ ] The changes are reflected on docs.tenzir.com/vast, if necessary.
[ ] The PR description contains instructions for the reviewer, if necessary.

:dart: Review Instructions

@lava this change unveiled a CMake issue that causes the suite name to be wrongly configured for CTest. This diff fixes it:
diff --git a/libvast/test/CMakeLists.txt b/libvast/test/CMakeLists.txt
index 63d4929d7..5c40e883f 100644
--- a/libvast/test/CMakeLists.txt
+++ b/libvast/test/CMakeLists.txt
@@ -35,8 +35,9 @@ endmacro ()
 foreach (test ${test_sources})
   file(STRINGS ${test} contents)
   foreach (line ${contents})
-    if ("${line}" MATCHES "SUITE")
-      string(REGEX REPLACE "#define SUITE \(.*\)" "\\1" suite ${line})
+    if ("${line}" MATCHES "^ *#define +SUITE +[^ ]+ *$")
+      string(REGEX REPLACE "^ *#define +SUITE +\([^ ]+\) *$" "\\1" suite
+                           ${line})
       list(APPEND suites ${suite})
     endif ()
   endforeach ()


How does it works ?

I will try this awesome plugin but I have errors
first my ide don't find the package

Then, maybe due to the first error

What did I forgot ?

Hi @kl3sk!
Did you install vuetifyjs framework correctly? Because your error log tells on absent exactly vuetify components.
Please read https://vuetifyjs.com/en/getting-started/quick-start

I was sure that was you answer and of course I did.
Every Vuetify components works.

Can you try switch version of compiled package:
vuetify-dialog/dist/vuetify-dialog.js
vuetify-dialog/dist/vuetify-dialog.cjs.js
vuetify-dialog/dist/vuetify-dialog.es.js
vuetify-dialog/dist/vuetify-dialog.min.js
and tell me is one of them will work
otherwise i would need to see your code :(

I’ve tried this too.
I can’t give you code for now. But. I just copy your demo code inside mine.
BTW there is some typo (missing quote)
No template seems needed ?

I have this issue too I think its because of how Vuetify is installed Vue CLI plugin

can you please explain more detail information? What version of vue cli. The best case will be if you show me part of code where you use vuetify and vuetify-dialog

Found the issue when you install vuetify from the Vue CLI plugin "vue add vuetify" more info here it will import Vuetify with import Vuetify from 'vuetify/lib' instead of import Vuetify from 'vuetify'

So to fix it i had to update the file src/plugins/vuetify.js

I've installced @vue/cli and vuetify preset, than I installed vuetify-dialog,
vue create my-app
vue add vuetify
npm i vuetify-dialog

and modified file src/plugins/vuetify.js
import Vue from 'vue'
import Vuetify from 'vuetify/lib'
import 'vuetify/src/stylus/app.styl'
import VuetifyDialog from 'vuetify-dialog'

Vue.use(Vuetify, {
  iconfont: 'md',
})
Vue.use(VuetifyDialog)

Everything works fine
By the way, in your screenshot you use vuetify-confirm instead vuetify-dialog

I agree @xi-osman's answer because it works as he said.
Just remove /lib from the Vuetify import.

Because a solution is found i close this issue for now.

I had the same issue and removing the /lib part works but I like to point out that this increases the bundle size significantly (for my project it jumped from around 120kb to almost 250gb gziped)

I guess I have found solution
Just need to add components VBtn, VCard, VCardActions, VCardText, VCardTitle, VDialog, VSpacer manually:
import Vue from 'vue'
import colors from 'vuetify/es5/util/colors'

import Vuetify, {
  VBtn,
  VCard,
  VCardActions,
  VCardText,
  VCardTitle,
  VDialog,
  VSpacer
} from 'vuetify/lib'

Vue.use(Vuetify, {
  components: {
    VBtn,
    VCard,
    VCardActions,
    VCardText,
    VCardTitle,
    VDialog,
    VSpacer
  },
  theme: {
    primary: colors.blue.darken2,
    accent: colors.grey.darken3,
    secondary: colors.amber.darken3,
    info: colors.teal.lighten1,
    warning: colors.amber.base,
    error: colors.deepOrange.accent4,
    success: colors.green.accent3
  }
})

With this nuxt configuration, it works, but if I want to use other veutify components, like the datatable, I have to add it there or take it alone and I can use it without adding
import Vue from 'vue'
//import Vuetify from 'vuetify/lib'
import colors from 'vuetify/es5/util/colors'
import VuetifyDialog from 'vuetify-dialog'
import Vuetify, {
VBtn,
VCard,
VCardActions,
VCardText,
VCardTitle,
VDialog,
VSpacer
} from 'vuetify/lib'
Vue.use(Vuetify, {
components: {
VBtn,
VCard,
VCardActions,
VCardText,
VCardTitle,
VDialog,
VSpacer
},
theme: {
primary: colors.blue.darken2,
accent: colors.grey.darken3,
secondary: colors.amber.darken3,
info: colors.teal.lighten1,
warning: colors.amber.base,
error: colors.deepOrange.accent4,
success: colors.green.accent3
}
})


Fix private build notice

Reviewers:
@jinruh
Fix private build notice and make sure it only appears when it is actually a private build

r+


display source code

GitHub is meant to be a collection of repositories for open-source projects; not necessarily a medium to access scripts on KA from jsDelivr. it would be preferred by the open-source community if you included the source code for the script updating the data folder repo in a src folder.

Yes, I'll put there the source code as soon as I finish working on this. It's still under development, the code isn't finished yet.

I added the source code now.


Enabling VaryByOrigin in Cors Options

Hi
I was wondering if it could be possible to move the hidden logic of VaryByOrigin out of the count of origins?
https://github.com/aspnet/CORS/blob/fb4d7e5db1ccfcc7c8eaa52cb34b4a21776bf1d3/src/Microsoft.AspNetCore.Cors/Infrastructure/CorsService.cs#L275
  if(policy.Origins.Count > 1)
  {
       result.VaryByOrigin = true;
  }

at the moment i have to use this code WithOrigins("1", "2") for enabling VaryByOrigin  when using SetIsOriginAllowed
services.AddCors(options =>
{
    options.AddPolicy("Policy1",
        builder => builder
            .SetPreflightMaxAge(TimeSpan.FromMinutes(1)) // This enables automatic preflight reponses
            .AllowAnyMethod()
            .AllowCredentials()
            .WithExposedHeaders("LOCATION")
            .WithHeaders("CONTENT-TYPE")
            .WithOrigins("1", "2")// Enables VaryByOrigin
            .SetIsOriginAllowed(IsOriginAllowed(env))
    );
});

Would adding a new variable configurable to override the existing functionality work for you?
Perhaps CorsPolicy.ForceVaryByOrigin    and    ``CorsPolicyBuilder.ForceVaryByOrigin()`?

Would it be better name with just VaryByOrigin()?

The function is made to force override already existing functionality so I believe it suits better.
VaryByOrigin() just sounds like a function enabling the header for a specific request.

@javiercn You are right. I will apply this to the pull request instead.

Closing as a dupe of https://github.com/aspnet/Home/issues/3452.


Architecture change to support configuration cache in a proper way

This isn't a specific issue, rather an opportunity to talk about this plugin architecture.
Let's face it: this project has many issues related to the caching mechanism, like this and this. Now, after bumping Android Cache Fix Plugin and/or Gradle Doctor Plugin, I have the following logs for each module, caused by AboutLibraries behaviour:
Configuration 'debugUnitTestRuntimeClasspath' was resolved during configuration time.
This is a build performance and scalability issue.
See https://github.com/gradle/gradle/issues/2298
Run with --info for a stacktrace.

This is not something that is failing my build, but it is indicating that there is something basically wrong in the way this plugin works. The main issue is probably the way this plugin "injects" itself into every module from the top one, after they are evaluated. I've got a feeling that this approach will cause even more issues over time. Looking at recent Gradle development, it is focused on isolating modules logic from other modules logic, and AboutLibraries plugin is doing something completely opposite.
My idea is: this plugin should be applied in the same way every other multi-module plugin is applied, this is: by adding this plugin to every module separately. Look for example at Detekt Plugin, which works exactly this way, and afaik has no issues with cache. What do you think about this? It is possible for AboutLibraries to adopt the same approach?
I know collecting dependencies from the project is not an easy task, and I appreciate the work you have already done. I just want to still be able to use this library, while keeping all the dependencies up-to-date and benefit from the latest performance improvements. Unfortunately, this task is becoming harder and harder over time.

Good day @ILikeYourHat
Thank you for the report. The last few weeks have been very busy and I haven't had a chance to look more into it, and I am not sure yet when I will be able to.

A possible work-around for all those problems may be to disable the registration as part of the android build pipelines, and having the CI build the dependencies (or making it a step of the release process) with the results to be included as part of the SCM.

I agree though that there are problems to the caching, specifically the configuration cache system. I see that there are updates being made in gradle in regards to retrieving the information we need, but so far past tries have not been sufficient.
At this current time I may not be able to spend the amount of time on this matter, as I'd need to, to find a proper solution for all scenarios.
That being said, if somebody with more time, or more knowledge about gradle would like to look into this. It would be immensely appreciated.


[Components] - Button - loading button loses focus

When clicking or pressing Enter on a button, if it goes into "loading" mode, it loses the focus because we set it as disabled.
We have seen other design system use:

aria-disabled instead of the disabled HTML attribute
aria-busy="true"

We should figure which is best and implement it.
For now, the focus goes back to the top of the page, which breaks the user flow when navigating with the keyboard.

Seems clearer to use aria-disabled here. Also we may be interested in having a shared/common solution for all Spark components that could be disabled :+1:


[mysql-connector-cpp] 9.1.0 with JDBC:x86-windows-static build failure

Operating system
windows 11 24h2
Compiler
VS2022 17.12.0
Steps to reproduce the behavior
`vcpkg install --clean-buildtrees-after-build --clean-packages-after-build --recurse mysql-connector-cpp[jdbc]:x86-windows-static`

Failure logs
install-x86-windows-static-dbg-out-1.log
适用于 .NET Framework MSBuild 版本 17.12.6+db5f6012c
Merge options: /SUBSYSTEM:CONSOLE;/MACHINE:X86

using MSVC tools
jdbc.vcxproj -> F:\vcpkg\buildtrees\mysql-connector-cpp\x86-windows-static-dbg\jdbc\driver\Debug\jdbc.lib
LINK : fatal error LNK1104: cannot open file 'MySQL::client-shared-NOTFOUND.obj' [F:\vcpkg\buildtrees\mysql-connector-cpp\x86-windows-static-dbg\jdbc\connector-jdbc-deps.vcxproj]

Additional context
No response

I didn't work on this partiular issue, but #42586 does revise the port. (WIP.)

the new commit resolve this issue,thanks,but the output lib name changed,now is -mt.lib and -mt-mt.lib,the prefix mysql losted

Oh, that is interesting.
mysql-connector-cpp:x64-windows-static:/lib/-mt-mt.lib
mysql-connector-cpp:x64-windows-static:/lib/-mt.lib

vs. (dynamic, no jdbc)
mysql-connector-cpp:x64-windows:/lib/mysqlcppconnx.lib

Expected:
mysql-connector-cpp:x64-windows-static:/lib/mysqlcppconnx-static-mt.lib
...

How did this ever work?
set(LIB_NAME_BASE "mysqlcppconnx")
set(LIB_NAME_STATIC "${LIB_NAME_BASE}-static")

if(WIN32 AND STATIC_MSVCRT)
  set(LIB_NAME_STATIC "${LIB_NAME}-mt")
endif()

Looks like it should use "${LIB_NAME_[BASE|STATIC]}-mt".

How did this ever work?
set(LIB_NAME_BASE "mysqlcppconnx")
set(LIB_NAME_STATIC "${LIB_NAME_BASE}-static")
if(WIN32 AND STATIC_MSVCRT)
set(LIB_NAME_STATIC "${LIB_NAME}-mt")
endif()
Looks like it should use "${LIB_NAME_[BASE|STATIC]}-mt".

`set(LIB_NAME_BASE "mysqlcppconnx")
set(LIB_NAME_STATIC "${LIB_NAME_BASE}-static")
if(WIN32 AND STATIC_MSVCRT)
set(LIB_NAME_STATIC "${LIB_NAME_STATIC}-mt")
endif()`


Generate deb package on release

Generate deb packages on release using cargo-deb or similar

https://github.com/fujiapple852/trippy/pull/324


About disc's output

Hi @toshikwa
I'm puzzled with your annotation in update_disc(). You said output of discriminator is (-inf, inf), not [0, 1]. Should the output of disc be (-1, 1) when hidden_activation of the disc is nn.Tanh(). I don't know whether I understand it incorrectly.
Looking forward to your reply. Thanks!

Hi @nicholas0717
Output is (-inf, inf) if you don't specify output_activation.
https://github.com/toshikwa/gail-airl-ppo.pytorch/blob/master/gail_airl_ppo/network/utils.py#L15-L16
Does it make sense?

Thank you! I get it. I didn't read the utils.py carefully.
Appreciate your reply!


Family Space

Experience
FamilySpace.zip
Title
Family Space
Screenshots

Description
Welcome to your very own Family Space, where everything you share is reserved solely for those closest to you. Designed knowing that every family is unique, we hope this experience will make communication and organization easy and enjoyable for your family.
Categories
Collaboration, Finance, Home
Language
en-US
Terms

[X] I agree that this Experience is licensed under the MIT License.
[X] I have intellectual property rights and/or permission to contribute the Experience and its content.
[X] I confirm that the Experience does not contain any harmful or malicious content.

/gallery approve


huge blank space around code block in man page

when using ronn to get a man page, ronn produce a man page with at least 2 or 3 blank lines around code block
No more than one blank lines is necessary
It seems ronn insert in the man page redondant information like .IP "" 0 followed by a .P which is basically the same.
and other blank line with .

I think tinkerbot's analysis is correct: the extra lines are added by nroff at its rendering stage, downstream from the .roff output. The single-"." lines are empty lines, and are ignored; they're just used for adding space to make your ROFF document readable. They're not causing this.
So the fix needs to be handled at the pager level, by modifying the default pager command. (And, as a user, making sure you don't have your $PAGER or $MANPAGER set to something that lacks the -s.)
Looks like Ronn development is defunct. But I've made a Ronn-NG fork and addressed this issue over there, if you're still interested.


fix(typings): set correct typing for tsconfig/tsConfig

Summary

Closes #2368
Test plan

Added unit test to verify if the source tsconfig schema changes then we need to update the typings manually
Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information
N.A.

Pull Request Test Coverage Report for Build 584156961

0 of 1 (100.0%)  changed or added relevant line in 1 file are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 93.669%

Totals

Change from base Build 581859437:
0.0%

Covered Lines:
950

Relevant Lines:
980

💛  - Coveralls

Pull Request Test Coverage Report for Build 584156961

1 of 1 (100.0%)  changed or added relevant line in 1 file are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 93.669%

Totals

Change from base Build 581859437:
0.0%

Covered Lines:
950

Relevant Lines:
980

💛  - Coveralls


Update docker login manpage regarding registry lookup

Signed-off-by: TomSweeneyRedHat<EMAIL_ADDRESS>Updates the docker-login man page to better explain how registry lookup works.  This addresses https://bugzilla.redhat.com/show_bug.cgi?id=1556956.  This is the second submit for this.  The fix for docker-1.13.1-rhel was completed in #303
- What I did
Updated the docker-login man page.
- How I did it
vi is my friend.
- How to verify it
After installation, check the docker-login man page for the changes.
- Description for the changelog
Clarify how registries are searched for by docker login.
- A picture of a cute animal (not mandatory but encouraged)

LGTM


Quick fix to typo in test provisioner.

Quick fix to a typo in a comment.

/check-enforcer override

@danieljurek since this is just a comment change figured it was safe to instamerge this one.


Update GazeProvider to use SpatialPointerPose.Head

Overview
This PR adds a new gaze provider interface, IMixedRealityGazeProviderWithOverride, to prevent a breaking change to the existing gaze provider interface. This new interface allows a data provider to override the gaze data with platform-specific values. In this case, the data comes from SpatialPointerPose.Head.
I also reorganized GazeProvider a bit to group implementations by interface.


[useMesure] Error in example using "useLongPress" hook in "useMeasure" page

Reproduction steps:

Visit the "useMeasure" webpage at https://usehooks.com/usemeasure.
Scroll down to the example section
In the example code, observe that the example is referencing the useLongPress hook instead of the expected useMeasure hook.

Expected behavior:
The example on the useMeasure should demonstrate the usage of the useMeasure hook.

Hi, I would like to contribute to this issue.
After reading the docs and the code following is my approach.

Get the right code(App.js) from code sandbox by using the sand box id from useMeasure.mdx file
Update useMeasre.mdx file with the correct.

If my above approach is correct do let me know I will raise a PR.

Fixed in #201


How to create a eos transfer transaction?

I know that I can use 'eosSignTransaction',but how to set the parameter of [EOSTransaction]? The 'Hex tx data', what is the data meaning？

@xwartz  Pls show some examples. thanks

Hello, @limengCode
You can get the hex tx data from the following method:
export const getTxHex = async (actions: <{name: string,
  account: string,
  data: object,
  authorization?: { actor: string, permission: string }[],}>[]): Promise<{ txHex: string, tr: object }> => {
  const { transaction } = await Eos().transaction({ actions }, {
    sign: false,
    broadcast: false,
  })

  const txHex = transaction.buf.toString('hex')
  const tr = transaction.transaction

  return {
    txHex,
    tr,
  }
}

If you want to know more details, you should read EOSJS source code:
https://github.com/consenlabs/eosjs/blob/a0d0dc7e571079a74b1ee6005d763a46f0bc309d/src/write-api.js#L413-L558

thanks

@limengCode
This issue is inactive for long time, I will close it, you can reopen it if come more question.


metadata: Clean up parameters handling

Move eBPF parameters under parameters leaf
Remove GadgetParams

Initially developed as part of #3449

The changes looks good, but it will break compatibility:

Gadgets compiled with ig <= v0.32.0 will no longer work with ig > v0.33.0 or latest because of the change in gadget.yaml
Third-party software using the IG Golang API (and gRPC clients & servers using inconsistent versions): pkg/operators/ebpf/params.go has some compatibility layer to support parameters with prefixes "ebpfParams." and "params.ebpf." but not prefix "params.". For consistency, we should support the 3 forms or just the most recent form, but it seems weird to keep compatibility with the oldest and newest forms.

Could we add a "release note" section in the PR description about it? Then the next release notes should include it. We could have a label in the PR to indicate it contains release notes.

I know the compatibility on this one is weird. d28c76d0ef853f40fa5594b24e3febf044b757d6 added support for ebpfParams and params but the Gadgets weren't updated to use params and the metadata generation continued to use ebpfParams. I don't think there are gadgets using params, that's why I didn't added support for that one but kept the ebpfParams one.
Btw, it's possible to use official gadgets compiled with a previous version of Inspektor Gadget after this PR:
$ sudo ig run trace_open:v0.32.0

# works fine

I still can add a release note, but I'm not sure what to put there.

Btw, it's possible to use official gadgets compiled with a previous version of Inspektor Gadget after this PR:

But does the CLI parameter work?
sudo ig run trace_open:v0.32.0 --help
sudo ig run trace_open:v0.32.0 --uid=1000

I still can add a release note, but I'm not sure what to put there.

Something like: The gadget metadata (gadget.yaml) changed its format: ebpfParams was moved to params.ebpf. As a consequence, the parameters of gadgets compiled with ig <= v0.32.0 are not parsed in ig >= v0.33.0. To avoid any issues, run matching versions of ig and gadgets.

But does the CLI parameter work?