Feature request: PolySynth could expose voice accessor

PolySynth conceptually has a map from Notes to Voices. I need to specify a note when I triggerAttack("C4") and then specify that same note to stop it with triggerRelease("C4").
I would like to implement pitchbending on a polyphonic instrument, for which I tought I could do something like
poly.triggerAttack("C4");

// ...

// Now I want to slightly shift that note. For simplicity, I'll change it to a "D4", but in reality I would like to increment the frequency only slightly.
const voice = poly.getVoice("C4");
if (voice != null) {
  voice.setNote("D4");
} else {
  console.error("Voice not found.");
}

Of course, there is no public getVoice() method.
This example points to an issue, however: If I trigger a C4 and a D4, and then I pitch shift the C4 to also be a D4, how do I address the correct D4? This address scheme practically prevents the same note from being played twice.
There are multiple solutions here:

Expose this voice getter, such that the voice can be controlled beyond triggering attack and release. Accept the tradeoff with not being able to address the same note playing twice correctly.
Keep the same note as the id, even if the actually played note becomes different. (This would enable the special case of shifting the C4 to a D4 from above, but still prevents two triggered D4 notes from being addressed freely.)
Return an id from triggerAttack() that has to be passed to triggerRelease().
Reverse the addressing: Allow the caller of triggerAttack to pass some id. That same id can then also be used in triggerRelease(). (The advantage of this is that the id does not need to be passed back to a remote caller. The disadvantage is that if messages are dropped, the caller might assume that an id is free for reuse, when it has not yet been cleared by the PolySynth. However, the caller can mitigate this in their use of ids.)

What are your thoughts on such a feature?

I will probably implement a PolySynth alternative that handles my requirements. If that works, I can share the code.

Thanks for the question. I'm not sure the added complexity would provide any advantage over simply creating multiple Synths and managing each voice individually which would allow you to have precise control over each voice.
An issue that comes to mind is that since triggerAttack and triggerRelease are both schedulable parameters, getVoice would have to be getVoiceAtTime(note, time). So for example if you schedule multiple notes in the future, getVoice would need to disambiguate which voice you were referring to in order to return the correct one.
If triggerAttack and triggerRelease took an 'id', it might cause some breaking API changes. And returning the original synth voice would break the memory ownership convention in Tone.js. Since currently PolySynth manages all of the voices, so it is able to create and dispose of voices. If a voice were returned, it might not be able to dispose the voice since the caller would have a reference to that voice.
I'm not sure i have a vision for how to build this feature without adding a lot of complexity. And the current alternative of just creating multiple synths seems pretty straightforward. I'd be curious to see your implementation, so please send it along when you've got it to a solid place. It'd be great to see how you tackle this.

You're right. When I tried implementing this, I basically ended up with a "default map", i. e. a map that I could get(id) on and that would simply generate a default voice, if there was none. And even that does not feel flexible enough for the two instruments I'm programming, so I'll probably end up with custom voice management in each instrument.
So I initially thought this would be a simple, straightforward feature, but I realize that it is hard to properly generalize. I agree that it's best to keep PolySynth as is for the common use case of triggering and releasing multiple voices.


Fixes for loadData to support Postgres enums with java.sql.Types.OTHER

Pull Request for Jira Issue - https://liquibase.jira.com/browse/CORE-3576
As part of this pull request, we're adding a data type - OTHER for allowing loadData for Enum types in Postgres, as well as several other datatypes supported by java.sql.Types.OTHER.
┆Issue is synchronized with this Jira Story by Unito

Thanks so much for your contribution! Is there any way you could add a test case to show how this would work? If you cannot, we can probably still merge this in, but it may take longer to get approved.

@SteveDonie I wrote a Unit Test for my changes in LoadDataChange.java. But for the other change, the return type is void and I couldn't figure out where to begin writing the Unit Test for that (I didn't see any other unit test mocking java.sql.Connection either).
So, instead, for that one, I wrote an integration test. However, I see a rollback changelog there as well. I hope we're using a fresh database every time in travis. If not, I'll need your help and some more time to understand how the rollback changelog which is already there is working.

@SteveDonie Is the integration test okay, or do you need me to write a Unit Test for that one too? I could try to figure it out again, if we need it.

Putting this at RiskMed

Is OTHER the word we want to expose for this data type?  Internal time to suss it out if this is the way Postgres should have it done.  What other things come thru (design wise) for Postgres and other DBs?
Changes functionality so prob not a patch but next major release.
The current tests is fine, and thanks!

@ro-rah We could change that OTHER to java.sql.Types.OTHER. That's what I was trying in the beginning, as is stated in the documentation, but isn't actually implemented. But adding java.sql.Types for the other types (other than OTHER) would be extra work, and I didn't need those types when I wrote this, so I kept it simply as OTHER to avoid confusion.

@sudiptosarkar , let's see what our internal team says since it is already in Conditioning.  Thanks for the insight!


Make plugin version optional

The version in package.json of a Hypermode Functions plugin is now optional.
Also now sets<EMAIL_ADDRESS>instead of "library":"<EMAIL_ADDRESS>in the metadata, to simplify and prepare for additional language support.

@SocketSecurity ignore<EMAIL_ADDRESS>


zotcli edit-note returns errors

query and add-note work fine, but I can't I get errors with edit-note.
If I try with a search string I get the following
$zotcli edit-note Chen
Traceback (most recent call last):
  File "/usr/bin/zotcli", line 11, in <module>
    load_entry_point('zotero-cli==0.3.0', 'console_scripts', 'zotcli')()
  File "/usr/lib/python3.6/site-packages/click/core.py", line 722, in __call__
    return self.main(*args, **kwargs)
  File "/usr/lib/python3.6/site-packages/click/core.py", line 697, in main
    rv = self.invoke(ctx)
  File "/usr/lib/python3.6/site-packages/click/core.py", line 1066, in invoke
    return _process_result(sub_ctx.command.invoke(sub_ctx))
  File "/usr/lib/python3.6/site-packages/click/core.py", line 895, in invoke
    return ctx.invoke(self.callback, **ctx.params)
  File "/usr/lib/python3.6/site-packages/click/core.py", line 535, in invoke
    return callback(*args, **kwargs)
  File "/usr/lib/python3.6/site-packages/click/decorators.py", line 17, in new_func
    return f(get_current_context(), *args, **kwargs)
  File "/usr/lib/python3.6/site-packages/zotero_cli/cli.py", line 260, in edit_note
    note = pick_note(ctx.obj, item_id, note_num)
  File "/usr/lib/python3.6/site-packages/zotero_cli/cli.py", line 284, in pick_note
    notes = tuple(zot.notes(item_id))
  File "/usr/lib/python3.6/site-packages/zotero_cli/backend.py", line 212, in notes
    note['data']['note'] = self._make_note(note)
  File "/usr/lib/python3.6/site-packages/zotero_cli/backend.py", line 283, in _make_note
    if data['version'] < note_version:
TypeError: 'NoneType' object is not subscriptable

If I use the query ID I get the following instead
$zotcli edit-note UEUIWFJV
Traceback (most recent call last):
  File "/usr/bin/zotcli", line 11, in <module>
    load_entry_point('zotero-cli==0.3.0', 'console_scripts', 'zotcli')()
  File "/usr/lib/python3.6/site-packages/click/core.py", line 722, in __call__
    return self.main(*args, **kwargs)
  File "/usr/lib/python3.6/site-packages/click/core.py", line 697, in main
    rv = self.invoke(ctx)
  File "/usr/lib/python3.6/site-packages/click/core.py", line 1066, in invoke
    return _process_result(sub_ctx.command.invoke(sub_ctx))
  File "/usr/lib/python3.6/site-packages/click/core.py", line 895, in invoke
    return ctx.invoke(self.callback, **ctx.params)
  File "/usr/lib/python3.6/site-packages/click/core.py", line 535, in invoke
    return callback(*args, **kwargs)
  File "/usr/lib/python3.6/site-packages/click/decorators.py", line 17, in new_func
    return f(get_current_context(), *args, **kwargs)
  File "/usr/lib/python3.6/site-packages/zotero_cli/cli.py", line 260, in edit_note
    note = pick_note(ctx.obj, item_id, note_num)
  File "/usr/lib/python3.6/site-packages/zotero_cli/cli.py", line 284, in pick_note
    notes = tuple(zot.notes(item_id))
  File "/usr/lib/python3.6/site-packages/zotero_cli/backend.py", line 210, in notes
    notes = self._zot.children(item_id, itemType="note")
  File "/usr/lib/python3.6/site-packages/pyzotero/zotero.py", line 127, in wrapped_f
    retrieved = self._retrieve_data(func(self, *args))
  File "/usr/lib/python3.6/site-packages/pyzotero/zotero.py", line 583, in children
    i=item.upper())
AttributeError: 'NoneType' object has no attribute 'upper'

Same here. This is with Zotero 5.0
$ zotcli edit-note CQSG3NYB
Traceback (most recent call last):
File "/usr/bin/zotcli", line 11, in
load_entry_point('zotero-cli==0.3.0', 'console_scripts', 'zotcli')()
File "/usr/lib/python3.6/site-packages/click/core.py", line 722, in call
return self.main(*args, **kwargs)
File "/usr/lib/python3.6/site-packages/click/core.py", line 697, in main
rv = self.invoke(ctx)
File "/usr/lib/python3.6/site-packages/click/core.py", line 1066, in invoke
return _process_result(sub_ctx.command.invoke(sub_ctx))
File "/usr/lib/python3.6/site-packages/click/core.py", line 895, in invoke
return ctx.invoke(self.callback, **ctx.params)
File "/usr/lib/python3.6/site-packages/click/core.py", line 535, in invoke
return callback(*args, **kwargs)
File "/usr/lib/python3.6/site-packages/click/decorators.py", line 17, in new_func
return f(get_current_context(), *args, **kwargs)
File "/usr/lib/python3.6/site-packages/zotero_cli/cli.py", line 260, in edit_note
note = pick_note(ctx.obj, item_id, note_num)
File "/usr/lib/python3.6/site-packages/zotero_cli/cli.py", line 284, in pick_note
notes = tuple(zot.notes(item_id))
File "/usr/lib/python3.6/site-packages/zotero_cli/backend.py", line 210, in notes
notes = self._zot.children(item_id, itemType="note")
File "/usr/lib/python3.6/site-packages/pyzotero/zotero.py", line 128, in wrapped_f
retrieved = self._retrieve_data(func(self, *args))
File "/usr/lib/python3.6/site-packages/pyzotero/zotero.py", line 588, in children
i=item.upper())
AttributeError: 'NoneType' object has no attribute 'upper'

I get the same error.
Traceback (most recent call last):
  File "/usr/bin/zotcli", line 11, in <module>
    load_entry_point('zotero-cli==0.3.0', 'console_scripts', 'zotcli')()
  File "/usr/lib/python3.6/site-packages/click/core.py", line 722, in __call__
    return self.main(*args, **kwargs)
  File "/usr/lib/python3.6/site-packages/click/core.py", line 697, in main
    rv = self.invoke(ctx)
  File "/usr/lib/python3.6/site-packages/click/core.py", line 1066, in invoke
    return _process_result(sub_ctx.command.invoke(sub_ctx))
  File "/usr/lib/python3.6/site-packages/click/core.py", line 895, in invoke
    return ctx.invoke(self.callback, **ctx.params)
  File "/usr/lib/python3.6/site-packages/click/core.py", line 535, in invoke
    return callback(*args, **kwargs)
  File "/usr/lib/python3.6/site-packages/click/decorators.py", line 17, in new_func
    return f(get_current_context(), *args, **kwargs)
  File "/usr/lib/python3.6/site-packages/zotero_cli/cli.py", line 260, in edit_note
    note = pick_note(ctx.obj, item_id, note_num)
  File "/usr/lib/python3.6/site-packages/zotero_cli/cli.py", line 284, in pick_note
    notes = tuple(zot.notes(item_id))
  File "/usr/lib/python3.6/site-packages/zotero_cli/backend.py", line 212, in notes
    note['data']['note'] = self._make_note(note)
  File "/usr/lib/python3.6/site-packages/zotero_cli/backend.py", line 283, in _make_note
    if data['version'] < note_version:
TypeError: 'NoneType' object is not subscriptable

I provided a workaround for this in #27. I tried to provide a more log term solution in #26 , but I am not competent enough in regex to know how to fix it properly. Hopefully @jbaiter can figure it out.
But you should be able to use the branch from #27 without troubles. The only side effect is that all notes will be treated as if they had been modified in the graphical zotero client, so any special markdown that is not supported there would be lost (not sure what that would include exactly).

I should say that I am also using the Zotero5 database, maybe they changed the storage format so that the regex extraction needs to be different. I don't have access to a Zotero4 database to compare.
In case it is helpful, this is what note_html looks like at line 272 of backend.py for me with Zotero5:
'
new-note-is-here
\n
\n
(hidden zotcli data)
\n
'

I just merged @joelostblom's fix (thank you!). I will look into possible changes in the Zotero 5 format in the near future, sorry for keeping quiet for so long.

Confirm recent zotcli from pip and Zotero 5.0.88


GH Issue #49

Implemented using a pseudo-enum mechanism.  Opted not to do a true enum since there's no way to translate an enum to a string name (vote for: https://github.com/dart-lang/sdk/issues/21712).
Please let me know if there are any changes you'd like me to make before merging.

@jonasfj ? CC @mit-mit

er @sortie –  sorry @jonasfj

@kevmoo The ownership of pub has been transferred to @jonasfj. I don't know anything about this repository.

I see that the Firefox test failed on Travis.  When I ran pub run test locally everything passed.  Is there a guide for running the full suite locally so I can diagnose and fix the failure?

@jpeiffer, I think you just do pub run test -p firefox to run on firefox... same for chrome...
Note, the travis file says pub run test -p firefox -j 1.

So, I have to ask, do these false negative a bit?
I did multiple test runs locally.  The results from the first four are:

Everything passed except:

00:17 +0 -1: compiling test/crypto/asn1_test.dart [E]
  Failed to load "test/crypto/asn1_test.dart":
  Failed to run Firefox: No such file or directory
    Command: /Applications/Firefox.app/Contents/MacOS/firefox-bin --profile /private/var/folders/b4/9_t84stn14l7c5f8_8dr4sd00000gn/T/dart_test_VjtwHb http://localhost:59062/zhpfTJPZb1xlNa7lzB3Ezd66MGfR43aX/packages/test/src/runner/browser/static/index.html?managerUrl=ws%3A%2F%2Flocalhost%3A59062%2FzhpfTJPZb1xlNa7lzB3Ezd66MGfR43aX%2F0&debug=false --no-remote.

Everything passed except:

00:16 +0 -1: compiling test/crypto/pem_test.dart [E]
  Failed to load "test/crypto/pem_test.dart":
  Failed to run Firefox: No such file or directory
    Command: /Applications/Firefox.app/Contents/MacOS/firefox-bin --profile /private/var/folders/b4/9_t84stn14l7c5f8_8dr4sd00000gn/T/dart_test_2gfEE7 http://localhost:59141/sEEIU7aPe2iTo3sQhcU5PnkWqOGjbw25/packages/test/src/runner/browser/static/index.html?managerUrl=ws%3A%2F%2Flocalhost%3A59141%2FsEEIU7aPe2iTo3sQhcU5PnkWqOGjbw25%2F0&debug=false --no-remote.

Everything passed except...

00:16 +0 -1: compiling test/crypto/asn1_test.dart [E]
  Failed to load "test/crypto/asn1_test.dart":
  Failed to run Firefox: No such file or directory
    Command: /Applications/Firefox.app/Contents/MacOS/firefox-bin --profile /private/var/folders/b4/9_t84stn14l7c5f8_8dr4sd00000gn/T/dart_test_HFBnGT http://localhost:59216/FghiL97%2B6uW8Pdg%2BwVqpIDSk1wadwsOE/packages/test/src/runner/browser/static/index.html?managerUrl=ws%3A%2F%2Flocalhost%3A59216%2FFghiL97%252B6uW8Pdg%252BwVqpIDSk1wadwsOE%2F0&debug=false --no-remote.

Everything passed except...

00:08 +0 -1: compiling test/crypto/rsa_test.dart [E]
  Failed to load "test/crypto/rsa_test.dart":
  Failed to run Firefox: No such file or directory
    Command: /Applications/Firefox.app/Contents/MacOS/firefox-bin --profile /private/var/folders/b4/9_t84stn14l7c5f8_8dr4sd00000gn/T/dart_test_8yK7UE http://localhost:59289/dV2loqr6WBx%2B8GqJ%2Fj1QAXv1tZsBjjHf/packages/test/src/runner/browser/static/index.html?managerUrl=ws%3A%2F%2Flocalhost%3A59289%2FdV2loqr6WBx%252B8GqJ%252Fj1QAXv1tZsBjjHf%2F0&debug=false --no-remote.

I was able to get the test that Travis failed to fail by re-running several more times, but I don't think the issue is in the code or the test code at this point.  All but one time I received:
02:19 +0 -1: compiling test/oauth2_flows/implicit/gapi_auth_implicit_idtoken_test.dart
Compiled 8,631,118 characters Dart to 1,063,120 characters JavaScript in 7.81 seconds
Dart file (/private/var/folders/b4/9_t84stn14l7c5f8_8dr4sd00000gn/T/dart_test_QchAmJ/runInBrowser.dart) compiled to JavaScript: /private/var/folders/b4/9_t84stn14l7c5f8_8dr4sd00000gn/T/dart_test_cQez7s/test_0vljEI/gapi_auth_implicit_idtoken_test.dart.browser_test.dart.js

@jpeiffer, if you read the error message it says:

Failed to run Firefox: No such file or directory

Which prompts me to ask the obvious, do you have firefox installed? :smile:
I had no problems running pub run test -p firefox on my linux desktop.
You could try to run it in docker under xfvb-run pub run test -p firefox, but installing firefox and xvfb isn't trivial and it could be hard to do. First check if you have firefox installed on your machine, and if so, is it in /Applications/Firefox.app/Contents/MacOS/firefox-bin ?

Ha!  I just had my laptop replaced and just realized FF wasn't installed.  It threw me that a different test failed each time.  I completely overlooked that message.  My bad.  ;)
Trying out your requested changes now.

Thanks for your patience with a newbie on Dart Web.  I found the issue with the test and made the changes you requested.
Please let me know if there are any further changes you'd like.

Note. this is just nits, I think we're good to land this.. if you're quick to fix the nits I can merge and release tomorrow maybe...

Documentation changes done


Dot net templates

New .NET templates that have been created by @josferracapgemini.
@devonfw/cobigen

@jdiazgon, is there any documentation on how to use them?
What is a possible input? Could we add some howto to the documentation in this PR?

Hi @maybeec,
yes, we do have documentation about this. The input file is an OpenAPI specification. However, @JosepFerrandis can you check if the documentation is up to date?

Hi @jdiazgon and @maybeec,
After this template update, the documentation in not 100% align. I'm working on it right now, so I will let you know as soon as I get it and we can add it to the Cobigen documentation.

@josferracapgemini please make sure you are doing the changes within the documentation/ folder of the repository of your PR. The wiki will be overwritten by the changes after merge automatically.

any news on the docs before the release? @josferracapgemini

@maybeec documentation is ready. To me it looks ready to be merged.


Chapter 11 ProductTable creation context change

In the text page 8/33 of chapter 11 we find this quote:

You can ask why we didn’t we modify ProductTable constructor for receiving two table gateways instead of injecting one of the table gateways with a setter method? We can’t change constructor signature because the constructor is inherited.

This is a perfect use case for a Delegated Service.
https://docs.laminas.dev/laminas-servicemanager/delegators/
However, there is no reason why the constructor can not be overridden. Constructor signatures can change, as long as the parent::__construct($arg, $arg2); whatever the use case may be within that context.

This can be a useful note.


Geofencing test case

Describe the issue
Geofencing is one of the main characteristics of the ASEA and seems to be completely baked into its structure. However, currently there is no Test case that checks how to do it
Additional context
Using a VPN to simulate another geographic location. The main problem is how to automate, if possible, this approach
If the technology allows it, traceroute the hops to the target site and check where they are located.
Definition of done

A manual test case to test the Geofencing guardrail
Assessment of how easy/difficult would be to automate it

Contract ends.This task would require a dedicated QA


Right-click on function to apply annotation suggestions

Would be great to make use of dmypy suggest to add annotations to existing code.

Actually you can already do this in some sense. There is a hidden (or rather just not advertised as official) hot key Ctrl+Shift+Y that will launch a script at ./mypy/mypy-suggest (hardcoded) and pass it current file name and current line number and then reloads the doc. You can write a short script that essentially pipes dmypy suggest to pyannontate -w that will apply the suggestion in-place.
But yeah, making it on right click and more automated would be great.

Actually you can already do this in some sense. There is a hidden (or rather just not advertised as official) hot key Ctrl+Shift+Y that will launch a script at ./mypy/mypy-suggest (hardcoded) and pass it current file name and current line number and then reloads the doc.

I see.  I tried this out and it failed with this error:
/bin/bash ./mypy/mypy-suggest: no such file or directory

I started pycharm from a shell where dmypy suggest -h works, and the mypy console in pycharm works correctly as well.  Perhaps what's hardwired is not dmypy suggest?
On a related note, I've been playing around with dmypy suggest and it doesn't seem to take the current scope into consideration when generating annotations.
I get something like this:
dmypy suggest mymodule.myfunc
() -> mymodule:Dict[str, mymodule.Dict[str, module.MyClass]]

When I expect something like this:
dmypy suggest mymodule.myfunc
() -> Dict[str, Dict[str, MyClass]]

The annotations produced by dmypy suggest won't work without being fixed up.  Is this by design, or a bug, or user error?

Perhaps what's hardwired is not dmypy suggest?

Of course it isn't, please read carefully the sentence you quoted.

Is this by design, or a bug, or user error?

I think this is by design. We have been using this extensively internally for long time, and it worked well for pyannotate.


Missing Video URL

The VideoPost type is missing the definition and return of the field video_url. I have copied the source, added the minor changes required and tested the changes from within my application. I have submitted pull request for this change.
I think I did it right. But if I didn't, please let me know what I did wrong so that I can better contribute any further updates I might encounter.

Ok, I guess I did the pull request wrong before, but now I think I added it correctly.

Dupe of https://github.com/tumblr/jumblr/pull/71


Allow JWT header kid to identify the credentials in use

Summary
Currently, the JWT plugin looks at a configured claim (iss by default). I would like to have the key being used to sign the token to be specified as the kid header. This seems like a incomplete implementation since this header is specifically designed for this use-case. If this is a feature that has a go, I'm happy to write a PR.
Steps To Reproduce

Create an API
Enable the JWT plugin
Make a request to this API with a signed JWT with a kid header.

Additional Details & Logs

Kong version (0.11)
Kong configuration (registered APIs/Plugins & configuration file)

host: 'localhost:8001'
headers: []
apis:
  - name: Admin
    plugins:
      - name: jwt
        attributes:
          enabled: true
          config:
            claims_to_verify: {}
            key_claim_name: kid
            anonymous: ''
            secret_is_base64: false
            uri_param_names: {}
    attributes:
      uris:
        - /admin
      strip_uri: true
      preserve_host: false
      upstream_url: 'http://nginx-lb:8001'
      retries: 5
      upstream_connect_timeout: 60000
      upstream_read_timeout: 60000
      upstream_send_timeout: 60000
      https_only: false
      http_if_terminated: false
consumers:
  - username: Floby's app
    custom_id: floby
    acls: []
    credentials:
      - name: jwt
        attributes:
          algorithm: HS256
          key: floby-sym
          secret: salut
plugins: []

If this is a feature that has a go, I'm happy to write a PR.

Happy to receive one!

Hello!
I am looking to use Kong's JWT with Firebase. Am I right in assuming that Kongs JWT can support multiple public keys, each with its own config.key_claim_name? If yes, then it seems like moving the kid to the header would fix this and we can work on PR, but wanted to confirm this is actually the case.

This should have been addressed by #3313 - thank you for the suggestion!

Is there any possibility to get plugin version with this fix not upgrading Kong version?
We are sitting on 0.11.1 and switching right now to newer version is painful because there were breaking api changes.


refactor: factor out paradigm generation as a Python package

@aarppe: please provide a spec

This is what #542 calls for.


Accurate sprite rendering

Still a WIP, code isn't clean yet.
I opened the PR so you could have a look at it and tell me what you think. The idea of the PR is to include de sprites in the rendering pipeline, instead of dumping them near then end. This fixed a bunch of graphics bug in multiple games.
Some remarks:
This greatly reduces performance, to the point that debug builds are unplayable. I'm wondering if we could optimize it a bit.
I implemented Sprite 0 hit "correctly", but I still had to keep the old approximation to check for out of screen hits because Mario was freezing without it.

For Mario, my understanding is that we are supposed to still render during the hblank (aka when cycle_count > 255). There is a single frame during the level loading where the HUD is out of screen and into hblank, alrhough that might be because of a timing issue, so the game hangs forever for sprite 0 hit because it's not detected during hblank because we don't render it at all.
If we optimize the PPU a bit we could probably do something about it (AKA check each pixel in the hblank if it hits sprite 0 and then check the corresponding background pixel), but with the current performance issue I think it's better to keep the approximation for now

I think that, for both accuracy and performance, we should follow this. Whis way we will only check for y at the beggining of the scanline and check a maximum of 8 sprites for the x:
https://wiki.nesdev.com/w/index.php/PPU_sprite_evaluation


[Model] Avoid showing functions that has no graph in the real_time_pipeline tab

Jira ticket: https://iguazio.atlassian.net/issues/ML-2079?filter=11387


Show likes from fediverse

I have the webmention plugin installed and it shows the Likes to toots I made from my day-to-day account where I have a link to a blogpost inside.
Likes made to the post of the blog are shown nowhere (which is a pitty). It would be great if the plugin could store likes received on the post the same way as the webmentions plugin which would display them as well as the likes.

Same for shares :+1:

I would say it's every more interesting to know how many times (and by who) a content was shared :)

!keep

Is there any progress on this? Very interested in this feature.

Keep

On my own site, I just added like and "repost" ("Announce") support by means a couple custom activitypub_inbox_{$type}" callbacks.
Also added an undo callback, so that undoing the like/repost removes the "comment."
Since it's all implemented as action hooks, it would be very easy to add this to the ActivityPub plugin itself.
I do set some dummy content (in case I ever disable my site's "facepile" solution) and a couple comment meta fields allowing likes and reposts to be picked up by said "facepile" block. Maybe there's a better way (like "comment types," the way the Webmention plugin does it).
I think that's the main "challenge": deciding on a meta field "structure." It would be easy enough to update my block to extend compatibility to whichever solution ends up being implemented, so I don't really have a strong preference.
If there's any interest, I wouldn't mind opening a PR.
Also considering a (dynamic) Gutenberg block that would simply display a like and repost (filterable, preferably, so it can be made compatible with, e.g., webmentions) counter.

I would love to see a PR for that!!!
@janboddez btw. thanks for all your work/support so far!

Keep

@janboddez have you also seen #929?

https://github.com/Automattic/wordpress-activitypub/issues/929

If you're already implementing a PR for this for "Like", would you also consider implementing "DisLike"?

@maltfield this is "only" for posts for now, it is not possible to up/down vote comments yet.
I would love to have a more generic approach that it will be possible to implement new activities with simple hooks and filters.


parametrize retry count

Summary
If retry count can be parametrize using workflow parameter it would really help us.
Motivation
We have standard workflow templates which are being used for multiple use cases. We need to set retry count for different usecase depending on user input
Example:
# This example demonstrates the use of retry back offs
apiVersion: argoproj.io/v1alpha1
kind: Workflow
metadata:
  generateName: retry-backoff-
spec:
  arguments:
     parameters:
     - name: retry-count
  entrypoint: retry-backoff
  templates:
  - name: retry-backoff
    retryStrategy:
      limit: {{workflow.parameters.retry-count}}
      backoff:
        duration: "1"       # Must be a string. Default unit is seconds. Could also be a Duration, e.g.: "2m", "6h", "1d"
        factor: 2
        maxDuration: "1m" # Must be a string. Default unit is seconds. Could also be a Duration, e.g.: "2m", "6h", "1d"
    container:
      image: python:alpine3.6
      command: ["python", -c]
      # fail with a 66% probability
      args: ["import random; import sys; exit_code = random.choice([0, 1, 1]); sys.exit(exit_code)"]

Message from the maintainers:
If you wish to see this enhancement implemented please add a 👍 reaction to this issue! We often sort issues this way to know what to prioritize.

@alexec @sarabala1979 If this is already possible, please let me know.

Not possible now. The limit is int type and will not accept string

I am working on a PoC to see if allowing behavior like this is possible. See https://github.com/argoproj/argo/pull/3610

// RetryStrategy provides controls on how to retry a workflow step
type RetryStrategy struct {
	// Limit is the maximum number of attempts when retrying a container
	Limit *int32 `json:"limit,omitempty" protobuf:"varint,1,opt,name=limit"`

	// RetryPolicy is a policy of NodePhase statuses that will be retried
	RetryPolicy RetryPolicy `json:"retryPolicy,omitempty" protobuf:"bytes,2,opt,name=retryPolicy,casttype=RetryPolicy"`

	// Backoff is a backoff strategy
	Backoff *Backoff `json:"backoff,omitempty" protobuf:"bytes,3,opt,name=backoff,casttype=Backoff"`
}

Change limit to intorstr.IntOrStr.

@simster7 to add work-around.

Ugly, but functional, workaround:
apiVersion: argoproj.io/v1alpha1
kind: Workflow
metadata:
  generateName: steps-
spec:
  entrypoint: hello-hello-hello
  arguments:
    parameters:
      - name: retries
        value: 2
  templates:

  - name: hello-hello-hello
    inputs:
      parameters:
        - name: retries
    steps:
    - - name: try1
        template: whalesay
        continueOn:
          failed: true
    - - name: try2
        template: whalesay
        when: "1 <= {{inputs.parameters.retries}} && {{steps.try1.status}} == Failed"
        continueOn:
          failed: true
    - - name: try3
        template: whalesay
        when: "2 <= {{inputs.parameters.retries}} && {{steps.try2.status}} == Failed"
        continueOn:
          failed: true
    - - name: try4
        template: whalesay
        when: "3 <= {{inputs.parameters.retries}} && {{steps.try3.status}} == Failed"
        continueOn:
          failed: true
    - - name: try5
        template: whalesay
        when: "4 <= {{inputs.parameters.retries}} && {{steps.try4.status}} == Failed"
        continueOn:
          failed: true
    - - name: try6
        template: whalesay
        when: "5 <= {{inputs.parameters.retries}} && {{steps.try5.status}} == Failed"
        continueOn:
          failed: true

  - name: whalesay
    container:
      image: alpine:latest
      command: [sh, -c]
      args: ["exit 1"]

@alexec @sarabala1979  is it possible to use if else like condition to decide the retry number based on other parameter. I think, if else is not directly supported in yaml file, but is there any alternate way to do the below?
For example:
retryStrategy:   limit: 1 if "{{workflow.parameters.env}}" == "pre-prod" else 5   retryPolicy: "Always"   backoff:     duration: 30 #30 seconds delay     factor: 2

Not possible. However you can run a step previous to this to compute the condition, then (once this PR is merged) use the result of the computation as a parameter to this step


Refactor run_tests.py

run_test.py uses shell command to invoke unittest module, which is not easy to maintain and reason about.
Behavior difference:

Just check 6379 tcp port instead of calling redis-cli, which may not be a very common tool in developers' machines. Let setUpClass report the connection failure when 6379 is not owned by redis.

Tested OK:

Case normal

Precondition: redis up.
Execution result: command line output OK. Exit status 0

Case bad testcase

Precondition: redis up. Modify test_scheduler.py to make one test bad.
Execution result: command line output with correct error info. Exit status 1

Case no redis server

Precondition: redis down.
Execution result: command line output Redis server is not running. Exit status 1

Case 6379 conflict

Precondition: 6379 listened by nc command
Execution result: command line output redis.exceptions.ConnectionError Failure. Exit status 1

Thanks!


[BSI][20200609] Duplicate Cookies with Missing Secure Flags

Rating: Low
Description:
The server seems to issue some of its cookies twice with the term _LEGACY
appended. On these _LEGACY cookies the server does not set the secure flag.
If the secure flag is not set, the cookies will be transmitted in clear-text
when the user visits any HTTP URLs within the cookie's scope. An attacker may
be able to induce this event by feeding a user suitable links, either directly
or via another web site.
Additionally, the duplicate cookies should be removed.
Proof of Concept:
The following is a communication excerpt that shows the lack of the secure flag:
GET /auth/realms/cwa/login-actions/required-action?execution=update_user_locale&client_id=verification-portal&tab_id=[...] HTTP/1.1
Host: verification-iam-server
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:68.0) Gecko/20100101 Firefox/68.0
Accept: text/html,application/xhtml+xml,application/xml;q=0.9,/;q=0.8
Accept-Language: en-US,en;q=0.5
Accept-Encoding: gzip, deflate
Referer: https://verification-iam-server/auth/realms/cwa/login-actions/authenticate?execution=[...]&client_id=verification-portal&tab_id=[...]

X-XSS-Protection: 1; mode=block
Pragma: no-cache
Location: https://verification-portal-server/sso/login?state=[...]&session_state=[...]
Date: Mon, 08 Jun 2020 18:13:38 GMT
Connection: close
Strict-Transport-Security: max-age=31536000; includeSubDomains
X-Content-Type-Options: nosniff
Content-Length: 0

The LEGACY cookie variants are a workaround for older apple OSs whose browsers ignore cookies with SameSite=None
Keycloak Commit
Keycloak Issue KEYCLOAK-12125

Planned for Version 1.0.x (17.07.2020)

This comment tries to wrap up the current analysis:
Problem Statement
P1 - the IAM duplicates certain cookies by adding  a "_legacy" suffix, it is not desirable to duplicate cookies
P2 - the duplicated cookies do not have a secure flag, so they might be transmitted in clear text
Analysis:
The reason for P1 is to support certain older apple OS (https://github.com/corona-warn-app/cwa-verification-iam/issues/34#issuecomment-645551543). The keycloak developers discuss different approaches which may be used in future releases.
P2 - although the cookies by themselfes do not require to transferred only via TLS. As the current configuration requires HSTS for requests, no browser interaction is done without TLS.
Proposal:
There are two option to react on the issue
A) Patch the existing keycloak application to remove the duplicate cookies until a future release will remove those cookies. The downside is that we would require to create a keycloak fork, which would mean we add additional time and effort to incorporate updates and hotfixes.
B) Wait until an updated version of keycloak will fix the issue.
Asssessment:
From our perspective it is not reasonable to fix the issue, because the fix would create a significant higher security risk than it fixes. We propose to "wont fix" this particular issue.

Is closes with wont fix as per communication with BSI

As keycloak now supports the "require SSL" setting in the realm login settings (which will turn on the Secure flag or rather not send the one without it), was this fixed?

Problem Statement
P1 - the IAM duplicates certain cookies by adding a "_legacy" suffix, it is not desirable to duplicate cookies
What about the P1? Duplicating cookies is still not desirable.
This won't be taken into consideration? Is there any way we can set this as an optional feature, and allow some configuration, particularly allow removing them if that's what someone wants? They can be there by default.
In my case, I'm having issues with the size of these, as I have strict limitations for the size. Is there any approach really to remove these on a deployed server itself, through configuration, SPIs, etc.?


Fix for log1p gpu kernel

Thanks for reacting so quickly!!!

Hey @indradenbakker, I was reviewing your GPU test implementation and data is never moved to GPU.
This is done using tensor.Gpu(shader).
Check out any other test to see how it works and message me (diegoalejogm) in Slack if you have doubts!

Hey @indradenbakker
I've fixed the GPU tests file, it contained the wrong functionality. You can check how to implement GPU tests now!
I also removed the missing Kernel implementation, since the GPU build was broken.
Very sorry for the inconvenient

Thanks @diegoalejogm !


feat: Allow override of protocol in egress rule

Description
Allow override of protocol in egress rule.
Motivation and Context
TCP are insufficient in case of S3 export.
Breaking Changes
No.
How Has This Been Tested?
By creating new SG with protocol set to all.

[ ] I have updated at least one of the examples/* to demonstrate and validate my change(s)
[ ] I have tested and validated these changes using one or more of the provided examples/* projects

[x] I have executed pre-commit run -a on my pull request

This issue has been resolved in version 8.0.0 :tada:


Stop scrolling when dragging on touchscreen

Hello Torstein,
Thank you for your work, the legend is draggable now on a touchscreen.
Is it, additional, possible to block the scrolling of the screen only and when the dragging of the legend is busy? That would would make the dragging of the legend much easier to handle.
Kind regards,
Jan Walhof

Torstein,
Thank you for the quick reply and of course for the solution.
A "world of difference" by a tiny edit.
I understand, I need more practice in js.
Thank you!
Kind regards,
Jan Walhof
2015-11-06 9:35 GMT+01:00 Torstein Hønsi<EMAIL_ADDRESS>
Closed #5
https://github.com/highslide-software/draggable-legend/issues/5 via
3c25f95
https://github.com/highslide-software/draggable-legend/commit/3c25f956d50edaac2b5168c438eec8cf06d8e7c9
.
—
Reply to this email directly or view it on GitHub
https://github.com/highslide-software/draggable-legend/issues/5#event-456679992
.

You're welcome Jan!


Massage config for tests so they can run on a release server

Enforce some of the test configuration assumptions we make.

:blush:


Volume of bar when price values is too small?

I am using this graph to show historic data that has value like this.
{         timestamp:<PHONE_NUMBER>00,         open: 1.0885,         high: 1.08853,         low: 1.08837,         close: 1.08846,     },
the values is small bar is not taking volume I used   volume: 1200, not worked.

i want to increase the height i:e volume of bar.

https://klinecharts.com/guide/faq#the-candle-shows-a-line-no-fluctuation-what-to-do

thanks . I was searching many thinks but did not find  thats why i am asking here.
I want to known can we add future points in graph just time with no values and then update? is it possible

https://klinecharts.com/guide/faq#the-candle-shows-a-line-no-fluctuation-what-to-do

thanks


Parse + generate fxdata.txt

This will be complicated: you'll have to make a whole dang parser to parse the fxdata, then generate the fx data + save.

This was completed in 0.4


Create ShellCommand Imp

What: An IMP in TS that calls a shell command to calculate the impacts from some observations.
Why: So we can have a language agnostic way to interact with models written in any language.
SoW:

[ ] The configuration for this imp is the path/name of a shell command
[ ] The shell command takes as input YAML in STDIN and exports YAML results in STDOUT and STDERR.
[ ] Pass in just the observations and any configuration (i.e. what you see under a component in the IMPL).
[ ] The response will be the same IMPL you passed in but with another sibling node called Impacts that contain your impact metrics.
[ ] The response might also be some errors, these should be parsed and passed out as exceptions.

NOTE: This is going to require some co-ordination between the person making the Python command line IMP caller here https://github.com/Green-Software-Foundation/ief/issues/84 please coordinate with them esp. if there are requirements for how to communicate back and forth between your two processes.
For example, in your calculate function.
create some YAML the represents the inputs to your ShellCommand, like so:
    config:
      <key>: <value>
    observations:
        - timestamp: <timestamp>
          duration: <duration>
          <key>: <value>
        - timestamp: <timestamp>
          duration: <duration>
          <key>: <value>

Spawn the Shell that is configured and pass the YAML as STDIN (see https://stackoverflow.com/questions/37685461/how-to-pass-stdin-to-node-js-child-process)
Parse the repones and pass the data out of your calculate function to the caller.

progress update:
done

basic functionality is implemented in #94, tested locally with a mock pimpl.py exposing a CLI

next

needs to pull path to external model directly from impl/config
Paz and I agreed for pimpl.py to append errors to output yaml for each observation. The shell plugin will parse these out and report to stderr. This requires another sync with Paz as it's dependent upon development of pimpl.py (Monday)
will then require input from @gnanakeethan to integrate this into existing framework and add some appropriate tests

@jmcook1186 Can we close this issue.
cc: @jawache


"NonMatchingChecksumError" when importing 'spider' dataset

Describe the bug
When importing 'spider' dataset [https://huggingface.co/datasets/spider] an error occurs
Steps to reproduce the bug
from datasets import load_dataset
dataset = load_dataset('spider')

Expected results
Dataset object
Actual results
NonMatchingChecksumError: Checksums didn't match for dataset source files:
['https://drive.google.com/uc?export=download&id=1_AckYkinAnhqmRQtGsQgUKAnTHxxX5J0']
Environment info

datasets version: 2.2.2
Platform: Windows-10-10.0.19041-SP0
Python version: 3.7.11
PyArrow version: 6.0.1
Pandas version: 1.3.5

Thanks for reporting, @OmarAlaaeldein.
Datasets hosted at Google Drive give problems quite often due to a change in their service:

#3786

I'm having a look.

We have made a Pull Request to replace the Google Drive URL. This fix will be accessible in our next datasets library release.
In the meantime, once the PR merged into master, you can get this fix by installing our library from the GitHub master branch:
pip install git+https://github.com/huggingface/datasets#egg=datasets

Then, if you had previously tried to load the data and got the checksum error, you should force the redownload of the data (before the fix, you just downloaded and cached the virus scan warning page, instead of the data file):
load_dataset("...", download_mode="force_redownload")


amplify codegen creates incomplete statements

Using amplify version 1.1.7
When I run amplify codegen on my schema, it ends up skipping some of the fields in one model and does not include all of the fields for a related model for the "list" statement. I can always go back and manually edit them, but it is a pain to need to do this every time.
So 2 issues/questions.

It seems to me that it should include all of the model fields in the return results for a list or get query.
I would like it to include as many levels deep as I've configured it to go for the query result items as well.

Here is the model from Schema.graphql:
type Instrument
    @model
    @auth(
    rules: [
      {allow: owner},
      {allow: owner, ownerField: "owner", mutations: [create, update, delete], queries: [get, list]},
      {allow: groups, groups: ["Admin"]}
    ])
{
  id: ID!
  owner: String
  name: String!
  category: InstrumentCategory!
  status: InstrumentStatus
  type: InstrumentType!
  manufacturer: String
  model: String
  color: String
  serialNumber: String
  yearManufactured: String
  description: String
  purchasedAt: String
  purchaseLocation: String
  purchasePrice: Float
  purchaseDate: AWSDate
  soldPrice: Float
  soldDate: AWSDate
  images: [S3Object] @connection(name: "InstrumentImages")
}

type S3Object @model {
    id: ID!
    bucket: String!
    key: String!
    region: String!
    order: Int
    instrument: Instrument @connection(name:"InstrumentImages")
}

When I call amplify codegen, the queries look like this:
export const getInstrument = `query GetInstrument($id: ID!) {
  getInstrument(id: $id) {
    id
    owner
    name
    category
    status
    type
    manufacturer
    model
    color
    serialNumber
    yearManufactured
    description
    purchasedAt
    purchaseLocation
    purchasePrice
    purchaseDate
    soldPrice
    soldDate
    images {
      nextToken
    }
  }
}
`;
export const listInstruments = `query ListInstruments(
  $filter: ModelInstrumentFilterInput
  $limit: Int
  $nextToken: String
) {
  listInstruments(filter: $filter, limit: $limit, nextToken: $nextToken) {
    items {
      id
      owner
      name
      manufacturer
      model
      color
      serialNumber
      yearManufactured
      description
      purchasedAt
      purchaseLocation
      purchasePrice
      purchaseDate
      soldPrice
      soldDate
    }
    nextToken
  }
}
`;

Note that for listInstruments, the category and status fields are missing as is images and for getInstrument, the properties of S3Object are missing.
Every time I do amplify codegen I need to go back and manually fix these items.
Graphqlconfig.yml does have maxDepth set to 2 so I would expect that the images fields are filled in for those queries.

I think you can run amplify codegen configure to set the maximum depth for future codegen runs. You can also specify a --max-depth argument to amplify codegen to get a custom depth beyond what you have configured.

Setting the max level to 3 still doesn't include the info on the images in the statement for listInstruments. Also, it seem like maxLevel of 2 should return them since they are just one level down though it looks like the docs hint that getting the info on the photos is level 3?
From diagram on statement depth
blog { # depth level 3
id
name
posts { # depth level 4
items { # depth level 5
id
title
}
nextToken
}
}

@poppybank

When I call amplify codegen, the queries look like this:

export const getInstrument = `query GetInstrument($id: ID!) {
  getInstrument(id: $id) {
    id
    owner
    name
    category
    status
    type
    manufacturer
    model
    color
    serialNumber
    yearManufactured
    description
    purchasedAt
    purchaseLocation
    purchasePrice
    purchaseDate
    soldPrice
    soldDate
    images {
      nextToken
    }
  }
}
`;

You would see this only if the the max-depth is set to 2. When its max-depth is set to 3 you should get this
export const getInstrument = `query GetInstrument($id: ID!) {
  getInstrument(id: $id) {
    id
    owner
    name
    category
    status
    type
    manufacturer
    model
    color
    serialNumber
    yearManufactured
    description
    purchasedAt
    purchaseLocation
    purchasePrice
    purchaseDate
    soldPrice
    soldDate
    images {
      items {
        id
        bucket
        key
        region
        order
      }
      nextToken
    }
  }
}
`;

In AppSync any field thats an list returns a connection object with items and nextToken to support the pagination and codegen doesn't treat these object as a special object.

Yes, and at level 3 for getInstrument, that is what I get. But listInstruments still does not include the items under images.

@poppybank thats because the listInstruments images is of list type. AppSync converts a lists to connection object so it can support pagination
query ListInstruments(
  $filter: ModelInstrumentFilterInput
  $limit: Int
  $nextToken: String
) {
  listInstruments(filter: $filter, limit: $limit, nextToken: $nextToken) { # level 1
    items { # level 2
      id
      owner
      name
      category
      status
      type
      manufacturer
      model
      color
      serialNumber
      yearManufactured
      description
      purchasedAt
      purchaseLocation
      purchasePrice
      purchaseDate
      soldPrice
      soldDate
      images { # level 3
        items { # level 4
          id
          bucket
          key
          region
          order
        }
        nextToken
      }
    }
    nextToken
  }
}

OK, as a user, this is problematic. In order to consistently get the same information back from calls (I always want instruments to include the images) I need to set maxLevel to 4 for listInstruments to work but then calls like getInstrument will include the instrument data multiple times.  My recommendation would be to include the items as the level for the thing that includes it so that the getInstruments and listInstruments calls would be much more in sync with the data that is returned.

@poppybank Thank you for your feedback. We will discuss this internally. The generation of statements is meant to be used as a starting point. In the mean time I recommend you to write custom queries, if your use case has different max-depth for different statements. You could write your custom queries and drop in its own file and codegen will generate the types for your custom queries.

I just ran into this as well and filed https://github.com/aws-amplify/amplify-cli/issues/1244, which now looks like a dupe of this ticket. I agree with @poppybank that not including items but including nextToken is undesirable and that a list of items with pagination token should be treated as one level rather than 2.

Just ran into this as well. I expected that list and get to return the same data from the items level.

I found that just using
amplify codegen --max-depth 6 does not work.
I had to do amplify codegen configure
and set the max-depth there and then it worked like a charm.

Nice catch @sudeep-quantelai  I was able to get the right depth by using configure.


database size chart in server dashboard is not showing anything

Today's insider build:

Seems to be working for me

Any additional repro steps?

@anthonydresser  I am using today's insider build on Windows, do you have the same config?

Error in the console

Hmm that shouldn't be a packaged version specific error.

I'll take a look

looks like it was caused by 51851efda ; its not immediately obviously to me what about it causes the issue. It might be some weird cascading event.

Verified in today's build the chart is working as expected now.


match docs with crd

This matches the CRD here https://github.com/Opster/opensearch-k8s-operator/blob/main/opensearch-operator/config/crd/bases/opensearch.opster.io_opensearchclusters.yaml#L2877

Hi @rhys-evans. Thanks for noticing this inconsistency. Could you please make sure your commit is signed-off to accept the DCO (https://github.com/Opster/opensearch-k8s-operator/blob/main/CONTRIBUTING.md#developer-certificate-of-origin)? Then we can merge.

Hi, just added the signoff


[Bug]: Group Chat with Customized Speaker Selection Method Does Not Complete Task

Describe the bug
After adding a cell for !pip install and creating the OAI_CONFIG_LIST, I attempted to run the notebook. I was presented with a series of questions to answer which I answered pressing the enter key, the proposal from the planner seemed to remain unchange. At that point, I assumed I was to exit the chat. I have attached the result, which appears to be the Chat Result. I don't see any of the expected output in a readable output form.
Chat_Result.zip
I expected more, or did you not intend to provide formatted output?
Steps to reproduce

Add !pip install function
Create endpoint
Run workbook. At some point, I assume the user would exit the chat.
When that occurs, the Chat Result is displayed.

Model Used
gpt-4", gpt-4-1106-preview as selected by the filter
config_list = autogen.config_list_from_json(
    "OAI_CONFIG_LIST",
    filter_dict={
        "model": ["gpt-4", "gpt-4-1106-preview"],
    },
)

Expected Behavior
Formatted output of the task result, unless you did not mean to present.
Screenshots and logs
No response
Additional Information
Python 3.12
Jupyter Notebook, but not in Colab

cc @yiranwu0


Added the option to change resolution based on an aspect ratio and target megapixel count

This PR adds a feature to change the resolution based on a target aspect ratio & megapixels. It adds a preview of the final resolution before setting it in order to avoid awkward situations.
Preview:

Thanks! I'll clean it up a bit by adding some {} around the if statements and will then release a new binary :)

Specifying a 0.5 in Scale sets it to 5x instead of 0.5x the size :) Will correct that. Will also check about the timer not ruining what one has typed in with width/height

Specifying a 0.5 in Scale sets it to 5x instead of 0.5x the size :) Will correct that. Will also check about the timer not ruining what one has typed in with width/height
(edit) ah, the 0.5 is seen as '5' as my regional settings are set to 'Dutch' which has ',' as fragment separator, not '.'.... I think there's a fix for that in tryparse, will see.

Sorry for the late reply, but yeah, the parse function seems to use the regional separator. For me it was the comma as well. Thanks for looking at those two details!


HPE DL380 Gen9 Smart HBA Update (7.20)

HPE updated it's Smart HBA storage controller version from 7.00. to 7.20 on 2020-09-07:
https://support.hpe.com/connect/s/softwaredetails?softwareId=MTX_26880c85fb3e4f5897e03283cc
$ md5sum firmware-smartarray-ea3138d8e8-7.20-1.1.x86_64.rpm
8d8d0cf7fe0cfab9dc4963384da3041b  firmware-smartarray-ea3138d8e8-7.20-1.1.x86_64.rpm

Request to update update_hp_firmware.py script, both master & ansible-eol branches to accommodate.

I added the firmware update to the script


pixi self-update on v0.27.0 thinks it is updating from v0.1.0

Checks

[X] I have checked that this issue has not already been reported.

[X] I have confirmed this bug exists on the latest version of pixi, using pixi --version.

Reproducible example
To show this is from a fresh pixi install I'll demonstrate from inside a Docker container
$ docker run --rm -ti debian:bookworm
root@09944251b956:/# apt update && apt install -y curl
root@09944251b956:/# curl -fsSL https://pixi.sh/install.sh | bash
This script will automatically download and install Pixi (latest) for you.
Getting it from this url: https://github.com/prefix-dev/pixi/releases/latest/download/pixi-x86_64-unknown-linux-musl.tar.gz
######################################################################## 100.0%
The 'pixi' binary is installed into '/root/.pixi/bin'
Updating '/root/.bashrc'
Please restart or source your shell.
root@09944251b956:/# . ~/.bashrc
root@09944251b956:/# pixi --version
pixi 0.27.0
root@09944251b956:/# pixi self-update
Pixi will be updated from 0.1.0 to 0.27.0
Pixi archive downloaded.
Pixi archive uncompressed.
Pixi has been updated to version 0.27.0.
root@09944251b956:/# pixi self-update
Pixi will be updated from 0.1.0 to 0.27.0
Pixi archive downloaded.
Pixi archive uncompressed.
Pixi has been updated to version 0.27.0.
root@09944251b956:/#

Issue description
For pixi release v0.27.0 if the self-update command is run it will always think it is updating from pixi v0.1.0 and not realize that it is already at pixi v0.27.0
$ pixi --version
pixi 0.27.0
$ pixi self-update
Pixi will be updated from 0.1.0 to 0.27.0
Pixi archive downloaded.
Pixi archive uncompressed.
Pixi has been updated to version 0.27.0.

Expected behavior
For pixi to detect that it is at the latest release and not attempt to update, also for pixi to know it is not v0.1.0, as was the previous behavior.
Example using v0.26.1:
$ pixi self-update --version 0.26.1  # roll back from v0.27.0 to v0.26.1
Pixi will be updated from 0.1.0 to 0.26.1
Pixi archive downloaded.
Pixi archive uncompressed.
Pixi has been updated to version 0.26.1.
$ pixi self-update --version 0.26.1
pixi is already up-to-date (version 0.26.1)

Hey @matthewfeickert, thanks for the ping, we've already fixed this in main: https://github.com/prefix-dev/pixi/pull/1759
Closing this as fixed :smiley:

Ah great! Thanks for being super fast. I missed PR #1759 while checking as it "self-updated" didn't bring it up, but I see why now. :+1:


instance_raw_config_args vm.provision ignored

Issue Type

Bug report

Molecule and Ansible details
ansible 2.10.4
  config file = None
  configured module search path = ['/home/vlad/.ansible/plugins/modules', '/usr/share/ansible/plugins/modules']
  ansible python module location = /home/vlad/.local/lib/python3.8/site-packages/ansible
  executable location = /home/vlad/.local/bin/ansible
  python version = 3.8.5 (default, Jul 28 2020, 12:59:40) [GCC 9.3.0]
molecule 3.2.2 using python 3.8
    ansible:2.10.4
    delegated:3.2.2 from molecule
    vagrant:0.6.1 from molecule_vagrant

Molecule installation method (one of):

pip

Ansible installation method (one of):

OS package

Desired Behavior
I want to install desktop environment on Ubuntu 20.04 using
instance_raw_config_args:
  - 'vm.provision :shell, path: "${MOLECULE_PROJECT_DIRECTORY}/../../environment/scripts/install_gnome_desktop_ubuntu.sh"'

Script looks like:
#!/usr/bin/env --split-string=bash -eux

export DEBIAN_FRONTEND=noninteractive
apt-get update
apt-get install --yes tasksel
tasksel install ubuntu-desktop
``

# Actual Behaviour
No output at all even using --debug
Nothing happen no GUI. But when I run it manually everything works as expected. I done it using prepare.yml but it looks more like workaround

Maybe I'm missing something ... did you try something like (note the change of quotes) that ? :
- "vm.provision :shell, path: '${MOLECULE_PROJECT_DIRECTORY}/../../environment/scripts/install_gnome_desktop_ubuntu.sh'"

I'm also seeing this issue while using inline, example
platforms:
  - name: sles11
    box: wvera/sles11sp4
    instance_raw_config_args:
      - "vm.provision :shell, inline: 'sudo /usr/sbin/useradd usera'"
      - "vm.provision :shell, inline: 'sudo /usr/sbin/useradd userb'"
      - "vm.provision :shell, inline: 'sudo /usr/sbin/useradd userc'"
      - "vm.provision :shell, inline: 'sudo /usr/sbin/useradd userd'"
      - "vm.provision :shell, inline: 'sudo /usr/sbin/usermod -A userc groupa'"

weird. it's supposed to be working, there's even a CI test case using vm.provision, see : https://github.com/ansible-community/molecule-vagrant/blob/master/molecule_vagrant/test/scenarios/molecule/vagrant_root/molecule.yml
Btw, did you ever set 'provision: true' ?

I didn't, I actually didn't know that I needed that set. Looks like that got it working, is there a part of the documentation that indicates one would need to set that option? I found things to be a bit sparse on the instance_raw_config_args in general.

the provision configuration is shown in the example and that's it.  The doc is in pretty bad shape. It's has been on my todo for quite some time but my priority atm is on the proper multi platform support. Feel free to open a bug on molecule-vagrant complaining how bad is the doc.

Roger roger, if there's a donation way to give the docs some priority after you've finished up your current initiative I'd be game for that. Figure it's more polite to pay for your time a bit than just complain via bug report :)

Bug reports are polite and welcome. It's also a way to ensure an issue is not forgotten :)

@VladAdGad Are you still getting the issue ? Do you have provision set ?

Hi. Thank for your solution. Yes it's working now after provision: true

I suggest convert this issue into enchantment to extend the documentation


Multilingual

HIi, can I make it multilingual? I mean the markdown blog.

Sure. Feel free to create a pr.

@vahidtakro Haven't heard from you in a while. Do you still plan on implementing this?

Hello Benjamin, yes of course we can do it, I am just a very basic react learner. but we can try.

No worries! I'll try and help any way I can.

perfect! do you prefer to edit this project or make a new branch or my forked project?

you can clone this repo and then create a new branch.

Benjamin, I can not npm start the project.

I use yarn. So once you clone the repo run "yarn" to install the dependencies and then run "yarn dev"
to start the server.

I already multilingualed the values, about the MDX, I am not sure. Can you help multilingualing it?

Could you submit a pull request so I can see the code so far?

You can simply commit them to GitHub just like any other project. Use the command, git push, or if you are in viscose you can use the ui. Once you do that, if you go to the code of this repo(https://github.com/bjcarlson42/benjamincarlson.io), you should see a button pop up at the top saying something like "create a pull request" Click yes and follow the steps. If you need help you can always check out githubs own learn page: https://lab.github.com

I get this error:
git push origin master
remote: Permission to bjcarlson42/benjamincarlson.io.git denied to vahidtakro.
fatal: unable to access 'https://github.com/bjcarlson42/benjamincarlson.io.git/': The requested URL returned error: 403

You might need to fork it first. Check out this video: https://www.youtube.com/watch?v=8A4TsoXJOs8

You might need to fork it first. Check out this video: https://www.youtube.com/watch?v=8A4TsoXJOs8

thanks,
pull request done,
I just added multilingual feature, already translated menu.
but still need to add language switcher and translate pages and MDX files.


update nix flake environment

Objective
I noticed that when trying to diagnose an issue that we don't compile with the current nix lock, (rust being to old)
error: package `tokio-macros v2.4.0` cannot be built because it requires rustc 1.70 or newer, while the currently active rustc version is 1.65.0-nightly

Solution
ran nix flake update, and now it brings in a recent enough rust nightly for everything to compile

This has a test failure, dont merge this just yet, will need to get an implementation that does not send a packet to the client when it was the client that updated it! thanks for the quick review!


Add more pooling types

Summary:
Added mean pooling and logsumexp pooling; refactored the existing
pooling logic to be more modular.
Reviewed By: jhcross
Differential Revision: D8440150

Already merged


[Package Issue]: JetBrains.IntelliJIDEA.Ultimate when using winget install it installs outdated version 2023.1.5 although 2023.2 exists

Please confirm these before moving forward

[X] I have searched for my issue and not found a work-in-progress/duplicate/resolved issue.
[X] I have not been informed if the issue is resolved in a preview version of the winget client.

Category of the issue
Installation issue.
Brief description of your issue
JetBrains.IntelliJIDEA.Ultimate 2023.2 is available https://blog.jetbrains.com/idea/2023/07/intellij-idea-2023-2/
but winget install JetBrains.IntelliJIDEA.Ultimate installs 2023.1.5
Steps to reproduce
Execute winget install JetBrains.IntelliJIDEA.Ultimate
Actual behavior
2023.1.5 is installed
Expected behavior
2023.2 should be installed
Environment
Windows-Paket-Manager v1.5.1881
Copyright (c) Microsoft Corporation. Alle Rechte vorbehalten.

Windows: Windows.Desktop v10.0.22621.1992
Systemarchitektur: X64
Paket: Microsoft.DesktopAppInstaller v1.20.1881.0

Winget Directories
-----------------------------------------------------------------------------------------------------------------------
Logs                               %LOCALAPPDATA%\Packages\Microsoft.DesktopAppInstaller_8wekyb3d8bbwe\LocalState\Diag…
User Settings                      %LOCALAPPDATA%\Packages\Microsoft.DesktopAppInstaller_8wekyb3d8bbwe\LocalState\sett…
Portable Links Directory (User)    %LOCALAPPDATA%\Microsoft\WinGet\Links
Portable Links Directory (Machine) C:\Program Files\WinGet\Links
Portable Package Root (User)       %LOCALAPPDATA%\Microsoft\WinGet\Packages
Portable Package Root              C:\Program Files\WinGet\Packages
Portable Package Root (x86)        C:\Program Files (x86)\WinGet\Packages

Links
-----------------------------------------------------------------------------------------
Datenschutzerklärung              https://aka.ms/winget-privacy
Lizenzvereinbarung                https://aka.ms/winget-license
Hinweise von Drittanbietern       https://aka.ms/winget-3rdPartyNotice
Startseite                        https://aka.ms/winget
Windows Store-Nutzungsbedingungen https://www.microsoft.com/en-us/storedocs/terms-of-sale

Administratoreinstellung                  Status
-----------------------------------------------------
LocalManifestFiles                        Deaktiviert
BypassCertificatePinningForMicrosoftStore Deaktiviert
InstallerHashOverride                     Deaktiviert
LocalArchiveMalwareScanOverride           Deaktiviert

Screenshots and Logs

I already found out the reason. Manifest for 2023.2 is missing in Winget Package Repo, but main reason for problems is this https://github.com/microsoft/winget-pkgs/issues/113236

I guess this can be closed as this is not a package issue but just a missing manifest, i.e. [Update Request]


test: additional test for get actual revertible state changes with base cache solution

This change is

Related PRs:
https://reviewable.io/reviews/starkware-libs/blockifier/1557#-
https://reviewable.io/reviews/starkware-libs/blockifier/1595#-

Codecov Report
Attention: Patch coverage is 75.00000% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 70.33%. Comparing base (914a1cc) to head (30947f3).

Files
Patch %
Lines

crates/blockifier/src/test_utils/contracts.rs
75.00%
1 Missing :warning:

Additional details and impacted files
@@                                          Coverage Diff                                          @@
##           aner/get_actual_revertible_state_changes_with_base_cache_solution    #1639      +/-   ##
=====================================================================================================
- Coverage                                                              70.43%   70.33%   -0.11%
=====================================================================================================
  Files                                                                     59       59
  Lines                                                                   8401     8389      -12
  Branches                                                                8401     8389      -12
=====================================================================================================
- Hits                                                                    5917     5900      -17
- Misses                                                                  2007     2013       +6
+ Partials                                                                 477      476       -1

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

crates/blockifier/src/transaction/account_transactions_test.rs line 1222 at r9 (raw file):
Previously, aner-starkware wrote…

Neither works (tuple isn't iterable). I could switch to list but then
It doesn't work, unless you want to add second_key (the key needs to appear twice, also in the 3rd position)

Also, I think with this the code would become much less understandable.


Remove yum cache to reduce docker image size

Signed-off-by: Peter Zhu<EMAIL_ADDRESS>Description
Remove yum cache to reduce docker image size
Issues Resolved
#56
Check List

[x] Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Apparently the remove yum cache dir does not make thing better, if you make it a new layer it is 300M bigger
opensearchproject/opensearch                                                                                1.0.0             4708ddc10782   8 minutes ago       1.79GB

And if you dont introduce a new layer just use the same line, it does not show any differences.
Original:
opensearchproject/opensearch                                                           1.0.0              0dd62cfce4c9   27 minutes ago   1.54GB

Now:
opensearchproject/opensearch                                                           1.0.0              bb34cc6f042e   About a minute ago   1.54GB

Will need to research more on this. As this is not a blocker for us now.


Automated code and docstring formatting

This PR adds automated code and docstring formatting mechanism for PRs as in the lenstronomy repo. This PR also adds CodeCov for test coverage statistics.

@ajshajib there are no slight merge conflicts. Hope this is easy to resolve


Istanbul code coverage differs from nyc result

Describe the bug
I tried running Vitest + Istanbul and the result seems to differ from using Istanbul (+ Mocha, but I also tried Cypress) itself.

Vitest seems to output a Linux-style path for coverage-final.json, even when running on Windows, this breaks NYC merge
The branch coverage seems to differ
(_coverageSchema, hash, contentHash are missing, but they are probably not important)

First image: Mocha + NYC, second image: Vitest
I'm not 100% sure if this a Istanbul or Vitest issue
Reproduction
https://github.com/marvin-j97/vitest-windows-path
(I also have a more complex repo trying to merge Vitest + Cypress Typescript coverage reports: https://github.com/marvin-j97/good-next-template/tree/dev)
System Info
System:
    OS: Windows 10 10.0.19044
    CPU: (8) x64 Intel(R) Core(TM) i7-7700K CPU @ 4.20GHz
    Memory: 8.75 GB / 15.96 GB
  Binaries:
    Node: 16.14.2 - C:\Program Files\nodejs\node.EXE
    Yarn: 1.22.18 - ~\AppData\Roaming\npm\yarn.CMD
    npm: 8.5.0 - C:\Program Files\nodejs\npm.CMD
  Browsers:
    Edge: Spartan (44.19041.1266.0), Chromium (104.0.1293.54)
    Internet Explorer: 11.0.19041.1566
  npmPackages:
    vitest: 0.22.1 => 0.22.1

Used Package Manager
yarn
Validations

[X] Follow our Code of Conduct
[X] Read the Contributing Guidelines.
[X] Read the docs.
[X] Check that there isn't already an issue that reports the same bug to avoid creating a duplicate.
[X] Check that this is a concrete bug. For Q&A open a GitHub Discussion or join our Discord Chat Server.
[X] The provided reproduction is a minimal reproducible example of the bug.

The branch coverage seems to differ

I think vitest report is correct.
Only one branch(if at line 2~4) exists [am i right?]
this branch could not be reached. So the result is 0/1
compare branchMap of  coverage-final.json, you will find same if branch is repeated twice in mocha and only one in vitest.
I guess Istanbul is doing "exclude" on branch report so the mocha result is 1/2


In Mobile Safari, taps on teacher links also cause class to expand

Doesn't repro in any desktop browser :-(

Fixed in #228.


Add Avatar component

Fixes #15

Building the library throws a warning:
$ ng build
...
------------------------------------------------------------------------------
Building entry point '@sage-bionetworks/sage-angular/src/lib/avatar'
------------------------------------------------------------------------------
✔ Compiling with Angular sources in Ivy full compilation mode.
✔ Bundling to FESM2015
⠋ Bundling to UMDWARNING: No name was provided for external module 'ngx-avatar' in output.globals – guessing 'i1'
✔ Bundling to UMD
✔ Writing package metadata
✔ Built @sage-bionetworks/sage-angular/src/lib/avatar

I tried specifying umdModuleIds as described by the doc but that does not remove the warning. In ng-package.json
{
  "$schema": "../../node_modules/ng-packagr/ng-package.schema.json",
  "dest": "../../dist/sage-angular",
  "assets": [
    "src/assets",
    "src/styles.scss",
    "src/styles",
    "src/**/*-theme.scss"
  ],
  "lib": {
    "entryFile": "src/public-api.ts",
    "umdModuleIds": {
      "ngx-avatar": "ngx-avatar"
    }
  }
}

I'm not sure about the value ngx-avatar. This comment may help. Does ng-packgr complain because it detects that it's not the correct value?

In ngx-avatar.umd.js:
(global = typeof globalThis !== 'undefined' ? globalThis : global || self, factory(global['ngx-avatar'] = {}, global.ng.core, global.ng.common, global.tsMd5, global.ng.common.http, global.rxjs.operators));

I successfully removed the warning by adding umdModuleIds to the sage-avatar's package.json instead of the library's ng-package.json.
I'm still unable to use my avatar component in the demo app. Here is the error shown in the browser console:
ERROR Error: Uncaught (in promise): NullInjectorError: R3InjectorError(e)[e -> e -> e -> e -> e]:
  NullInjectorError: No provider for e!
get@http://localhost:4200/main.js:1:58176
get@http://localhost:4200/main.js:1:59415
get@http://localhost:4200/main.js:1:59415
get@http://localhost:4200/main.js:1:59415
get@http://localhost:4200/main.js:1:99230
...

ERROR TypeError: this.avatarService.isSource is not a function
    ngOnChanges http://localhost:4200/336.js:1
    xt http://localhost:4200/main.js:1
    _e http://localhost:4200/main.js:1
    be http://localhost:4200/main.js:1
    ye http://localhost:4200/main.js:1
    ws http://localhost:4200/main.js:1
    Bs http://localhost:4200/main.js:1
    ws http://localhost:4200/main.js:1
    ws http://localhost:4200/main.js:1
    Bs http://localhost:4200/main.js:1
    ws http://localhost:4200/main.js:1
    ws http://localhost:4200/main.js:1
    ws http://localhost:4200/main.js:1

Getting the clear error after setting "optimization": false in angular.json:
ERROR Error: Uncaught (in promise): NullInjectorError: R3InjectorError(HomepageModule)[AvatarService -> HttpClient -> HttpClient -> HttpClient -> HttpClient]:
  NullInjectorError: No provider for HttpClient!

Storybook build fails in the CI workflow.
WARN   Failed to load preset<EMAIL_ADDRESS>ERR! Error: Cannot find module '@angular-devkit/architect'
ERR! Require stack:
ERR! -<EMAIL_ADDRESS>ERR! -<EMAIL_ADDRESS>ERR! -<EMAIL_ADDRESS>ERR! -<EMAIL_ADDRESS>ERR! -<EMAIL_ADDRESS>ERR! -<EMAIL_ADDRESS>ERR! -<EMAIL_ADDRESS>ERR! -<EMAIL_ADDRESS>
Later in the logs, there's also this error:
ERR! ModuleNotFoundError: Module not found: Error: Can't resolve '@sage-bionetworks/sage-angular/src/lib/footer' in '/home/runner/work/sage-angular/sage-angular/stories'
ERR!     at /home/runner/work/sage-angular/sage-angular/node_modules/webpack/lib/Compilation.js:1773:28
ERR!     at /home/runner/work/sage-angular/sage-angular/node_modules/webpack/lib/NormalModuleFactory.js:811:13
ERR!     at eval (eval at create (/home/runner/work/sage-angular/sage-angular/node_modules/webpack/node_modules/tapable/lib/HookCodeFactory.js:33:10), <anonymous>:10:1)
ERR!     at /home/runner/work/sage-angular/sage-angular/node_modules/webpack/lib/NormalModuleFactory.js:286:22
ERR!     at eval (eval at create (/home/runner/work/sage-angular/sage-angular/node_modules/webpack/node_modules/tapable/lib/HookCodeFactory.js:33:10), <anonymous>:9:1)
ERR!     at /home/runner/work/sage-angular/sage-angular/node_modules/webpack/lib/NormalModuleFactory.js:442:22
ERR!     at /home/runner/work/sage-angular/sage-angular/node_modules/webpack/lib/NormalModuleFactory.js:124:11
ERR!     at /home/runner/work/sage-angular/sage-angular/node_modules/webpack/lib/NormalModuleFactory.js:673:25
ERR!     at /home/runner/work/sage-angular/sage-angular/node_modules/webpack/lib/NormalModuleFactory.js:882:8
ERR!     at /home/runner/work/sage-angular/sage-angular/node_modules/webpack/lib/NormalModuleFactory.js:1002:5
ERR!     at /home/runner/work/sage-angular/sage-angular/node_modules/neo-async/async.js:6883:13
ERR!     at /home/runner/work/sage-angular/sage-angular/node_modules/webpack/lib/NormalModuleFactory.js:985:45
ERR!     at finishWithoutResolve (/home/runner/work/sage-angular/sage-angular/node_modules/enhanced-resolve/lib/Resolver.js:296:11)
ERR!     at /home/runner/work/sage-angular/sage-angular/node_modules/enhanced-resolve/lib/Resolver.js:362:15
ERR!     at /home/runner/work/sage-angular/sage-angular/node_modules/enhanced-resolve/lib/Resolver.js:410:5
ERR!     at eval (eval at create (/home/runner/work/sage-angular/sage-angular/node_modules/enhanced-resolve/node_modules/tapable/lib/HookCodeFactory.js:33:10), <anonymous>:15:1)
ERR!  ModuleNotFoundError: Module not found: Error: Can't resolve '@sage-bionetworks/sage-angular/src/lib/footer' in '/home/runner/work/sage-angular/sage-angular/stories'
ERR!     at /home/runner/work/sage-angular/sage-angular/node_modules/webpack/lib/Compilation.js:1773:28
ERR!     at /home/runner/work/sage-angular/sage-angular/node_modules/webpack/lib/NormalModuleFactory.js:811:13
ERR!     at eval (eval at create (/home/runner/work/sage-angular/sage-angular/node_modules/webpack/node_modules/tapable/lib/HookCodeFactory.js:33:10), <anonymous>:10:1)
ERR!     at /home/runner/work/sage-angular/sage-angular/node_modules/webpack/lib/NormalModuleFactory.js:286:22
ERR!     at eval (eval at create (/home/runner/work/sage-angular/sage-angular/node_modules/webpack/node_modules/tapable/lib/HookCodeFactory.js:33:10), <anonymous>:9:1)
ERR!     at /home/runner/work/sage-angular/sage-angular/node_modules/webpack/lib/NormalModuleFactory.js:442:22
ERR!     at /home/runner/work/sage-angular/sage-angular/node_modules/webpack/lib/NormalModuleFactory.js:124:11
ERR!     at /home/runner/work/sage-angular/sage-angular/node_modules/webpack/lib/NormalModuleFactory.js:673:25
ERR!     at /home/runner/work/sage-angular/sage-angular/node_modules/webpack/lib/NormalModuleFactory.js:882:8
ERR!     at /home/runner/work/sage-angular/sage-angular/node_modules/webpack/lib/NormalModuleFactory.js:1002:5
ERR!     at /home/runner/work/sage-angular/sage-angular/node_modules/neo-async/async.js:6883:13
ERR!     at /home/runner/work/sage-angular/sage-angular/node_modules/webpack/lib/NormalModuleFactory.js:985:45
ERR!     at finishWithoutResolve (/home/runner/work/sage-angular/sage-angular/node_modules/enhanced-resolve/lib/Resolver.js:296:11)
ERR!     at /home/runner/work/sage-angular/sage-angular/node_modules/enhanced-resolve/lib/Resolver.js:362:15
ERR!     at /home/runner/work/sage-angular/sage-angular/node_modules/enhanced-resolve/lib/Resolver.js:410:5
ERR!     at eval (eval at create (/home/runner/work/sage-angular/sage-angular/node_modules/enhanced-resolve/node_modules/tapable/lib/HookCodeFactory.js:33:10), <anonymous>:15:1)

The build was fine a couple of commit ago. Need to figure out what happened.

https://github.blog/2021-02-02-npm-7-is-now-generally-available/


Fixed page copy with correct relinking of all copied layout blocks and included content blocks

this fixes #725


android: fix build with rn 0.73

Hi
PR fixes error
Execution failed for task ':react-native-image-colors:compileDebugKotlin'.
> 'compileDebugJavaWithJavac' task (current target is 17) and 'compileDebugKotlin' task (current target is 11) jvm target compatibility should be set to the same Java version. Consider using JVM toolchain: https://kotl.in/gradle/jvm/toolchain *

hey, thanks for your contribution!
While the fix is valid, I hope to maintain the same changes as done by the official template this project is based on (expo-module-template):

https://github.com/expo/expo/commit/7ec55dfae4942ced223d1a67950e92ebf8f6c7e3

https://github.com/expo/expo/commit/c8003cb9cec4693e13816550a93a0c4bc41f6e15

hey, thanks for your contribution!
While the fix is valid, I hope to maintain the same changes as done by the official template this project is based on (expo-module-template):

expo/expo@7ec55df

expo/expo@c8003cb

Thanks for the reference, I'll change PR

Heya! do you still plan on working on this? I'd like to get a fix out soon so I'll probably work on this tomorrow unless you still want to.

Closing in favor of https://github.com/osamaqarem/react-native-image-colors/pull/85


Make concordance check deterministic

Not sure what's the best way to proceed here.

Should we just fix a seed? That is pretty straight forward.

Completed in 95cd28d2


Agent.JobName returns "Job"

Agent.JobName returns "Job"...pretty self-explanatory
Here is my powershell task that echo $(Agent.JobName)

Here is the Job:

Is this a bug, or have I done something wrong?
[Enter feedback here]

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 47625b86-abd5-ee15-6d61-8bcf81861b96
Version Independent ID: be9a6174-a69b-7aed-d584-5f602fcc5eb4
Content: Build and Release Agents - Azure Pipelines & TFS
Content Source: docs/pipelines/agents/agents.md
Product: devops
GitHub Login: @andyjlewis
Microsoft Alias: alewis

Which product are you using, Azure Pipelines or TFS? If that later, which version?

The display name isn't the same as the name. I don't think there's a way to choose your own job name in the visual editor, only in YAML. (We also had a bug for a while, but I think that's been fixed.)

Could we have the Display Name as a predefined variable? Or make it possible to choose Name in the visual editor?

It's not an unreasonable request. Could you file a request on the Azure Pipelines agent repo?


feat:Send to Party

An automatic send to chat function is not going to work.
I'd suggest instead to copy the info to the clipboard so the user can paste it themself.


zziplib: 0.13.68 -> 0.13.69

Semi-automatic update generated by https://github.com/ryantm/nix-update tools.
This update was made based on information from https://repology.org/metapackage/zziplib/versions.
These checks were done:

built on NixOS
ran /nix/store/9lh4yxh3lq6mv354jvbd3gqjv4dha740-zziplib-0.13.69/bin/zzcat -h got 0 exit code
ran /nix/store/9lh4yxh3lq6mv354jvbd3gqjv4dha740-zziplib-0.13.69/bin/zzcat --help got 0 exit code
ran /nix/store/9lh4yxh3lq6mv354jvbd3gqjv4dha740-zziplib-0.13.69/bin/zzcat help got 0 exit code
ran /nix/store/9lh4yxh3lq6mv354jvbd3gqjv4dha740-zziplib-0.13.69/bin/zzcat --version and found version 0.13.69
ran /nix/store/9lh4yxh3lq6mv354jvbd3gqjv4dha740-zziplib-0.13.69/bin/zzdir --help got 0 exit code
ran /nix/store/9lh4yxh3lq6mv354jvbd3gqjv4dha740-zziplib-0.13.69/bin/zzdir --version and found version 0.13.69
ran /nix/store/9lh4yxh3lq6mv354jvbd3gqjv4dha740-zziplib-0.13.69/bin/zzxorcat -h got 0 exit code
ran /nix/store/9lh4yxh3lq6mv354jvbd3gqjv4dha740-zziplib-0.13.69/bin/zzxorcat --help got 0 exit code
ran /nix/store/9lh4yxh3lq6mv354jvbd3gqjv4dha740-zziplib-0.13.69/bin/zzxorcat help got 0 exit code
ran /nix/store/9lh4yxh3lq6mv354jvbd3gqjv4dha740-zziplib-0.13.69/bin/zzxorcat --version and found version 0.13.69
ran /nix/store/9lh4yxh3lq6mv354jvbd3gqjv4dha740-zziplib-0.13.69/bin/zzxordir -h got 0 exit code
ran /nix/store/9lh4yxh3lq6mv354jvbd3gqjv4dha740-zziplib-0.13.69/bin/zzxordir --help got 0 exit code
ran /nix/store/9lh4yxh3lq6mv354jvbd3gqjv4dha740-zziplib-0.13.69/bin/zzxordir --version and found version 0.13.69
ran /nix/store/9lh4yxh3lq6mv354jvbd3gqjv4dha740-zziplib-0.13.69/bin/zzxorcopy -h got 0 exit code
ran /nix/store/9lh4yxh3lq6mv354jvbd3gqjv4dha740-zziplib-0.13.69/bin/zzxorcopy --help got 0 exit code
ran /nix/store/9lh4yxh3lq6mv354jvbd3gqjv4dha740-zziplib-0.13.69/bin/zzxorcopy --version and found version 0.13.69
ran /nix/store/9lh4yxh3lq6mv354jvbd3gqjv4dha740-zziplib-0.13.69/bin/unzzip --help got 0 exit code
ran /nix/store/9lh4yxh3lq6mv354jvbd3gqjv4dha740-zziplib-0.13.69/bin/unzzip -v and found version 0.13.69
ran /nix/store/9lh4yxh3lq6mv354jvbd3gqjv4dha740-zziplib-0.13.69/bin/unzzip --version and found version 0.13.69
ran /nix/store/9lh4yxh3lq6mv354jvbd3gqjv4dha740-zziplib-0.13.69/bin/unzzip-mix --help got 0 exit code
ran /nix/store/9lh4yxh3lq6mv354jvbd3gqjv4dha740-zziplib-0.13.69/bin/unzzip-mix -v and found version 0.13.69
ran /nix/store/9lh4yxh3lq6mv354jvbd3gqjv4dha740-zziplib-0.13.69/bin/unzzip-mix --version and found version 0.13.69
ran /nix/store/9lh4yxh3lq6mv354jvbd3gqjv4dha740-zziplib-0.13.69/bin/unzzip-mem --help got 0 exit code
ran /nix/store/9lh4yxh3lq6mv354jvbd3gqjv4dha740-zziplib-0.13.69/bin/unzzip-mem -v and found version 0.13.69
ran /nix/store/9lh4yxh3lq6mv354jvbd3gqjv4dha740-zziplib-0.13.69/bin/unzzip-mem --version and found version 0.13.69
ran /nix/store/9lh4yxh3lq6mv354jvbd3gqjv4dha740-zziplib-0.13.69/bin/unzzip-big --help got 0 exit code
ran /nix/store/9lh4yxh3lq6mv354jvbd3gqjv4dha740-zziplib-0.13.69/bin/unzzip-big -v and found version 0.13.69
ran /nix/store/9lh4yxh3lq6mv354jvbd3gqjv4dha740-zziplib-0.13.69/bin/unzzip-big --version and found version 0.13.69
ran /nix/store/9lh4yxh3lq6mv354jvbd3gqjv4dha740-zziplib-0.13.69/bin/unzip-mem -h got 0 exit code
ran /nix/store/9lh4yxh3lq6mv354jvbd3gqjv4dha740-zziplib-0.13.69/bin/unzip-mem --help got 0 exit code
ran /nix/store/9lh4yxh3lq6mv354jvbd3gqjv4dha740-zziplib-0.13.69/bin/unzip-mem --version and found version 0.13.69
found 0.13.69 with grep in /nix/store/9lh4yxh3lq6mv354jvbd3gqjv4dha740-zziplib-0.13.69
directory tree listing: https://gist.github.com/fec112f9114c98b118a59917224af5ff

@GrahamcOfBorg build zziplib

Success on aarch64-linux (full log)
Attempted: zziplib
Partial log (click to expand)
shrinking /nix/store/y6y52p2wcci4b5cgndw1wf40hnlhzcs1-zziplib-0.13.69/bin/zzcat
shrinking /nix/store/y6y52p2wcci4b5cgndw1wf40hnlhzcs1-zziplib-0.13.69/lib/libzzipwrap-0.so.13.0.69
shrinking /nix/store/y6y52p2wcci4b5cgndw1wf40hnlhzcs1-zziplib-0.13.69/lib/libzzipfseeko-0.so.13.0.69
shrinking /nix/store/y6y52p2wcci4b5cgndw1wf40hnlhzcs1-zziplib-0.13.69/lib/libzzipmmapped-0.so.13.0.69
shrinking /nix/store/y6y52p2wcci4b5cgndw1wf40hnlhzcs1-zziplib-0.13.69/lib/libzzip-0.so.13.0.69
gzipping man pages under /nix/store/y6y52p2wcci4b5cgndw1wf40hnlhzcs1-zziplib-0.13.69/share/man/
strip is /nix/store/3zq400fri5dv7d30lpxlqm2v9y1iis6j-binutils-2.28.1/bin/strip
stripping (with command strip and flags -S) in /nix/store/y6y52p2wcci4b5cgndw1wf40hnlhzcs1-zziplib-0.13.69/lib  /nix/store/y6y52p2wcci4b5cgndw1wf40hnlhzcs1-zziplib-0.13.69/bin
patching script interpreter paths in /nix/store/y6y52p2wcci4b5cgndw1wf40hnlhzcs1-zziplib-0.13.69
checking for references to /build in /nix/store/y6y52p2wcci4b5cgndw1wf40hnlhzcs1-zziplib-0.13.69...

Success on x86_64-darwin (full log)
Attempted: zziplib
Partial log (click to expand)
make[3]: Nothing to be done for 'install-exec-am'.
make[3]: Nothing to be done for 'install-data-am'.
make[3]: Leaving directory '/private/tmp/nix-build-zziplib-0.13.69.drv-0/zziplib-0.13.69/x86_64-apple-darwin16.3.0'
make[2]: Leaving directory '/private/tmp/nix-build-zziplib-0.13.69.drv-0/zziplib-0.13.69/x86_64-apple-darwin16.3.0'
make[1]: Leaving directory '/private/tmp/nix-build-zziplib-0.13.69.drv-0/zziplib-0.13.69/x86_64-apple-darwin16.3.0'
post-installation fixup
gzipping man pages under /nix/store/n49h5rbhxaa4l053ix72myf886avmyg6-zziplib-0.13.69/share/man/
strip is /nix/store/0fzpxnsanc02i4jsb1yhchjp4p62b2n3-cctools-binutils-darwin/bin/strip
stripping (with command strip and flags -S) in /nix/store/n49h5rbhxaa4l053ix72myf886avmyg6-zziplib-0.13.69/lib  /nix/store/n49h5rbhxaa4l053ix72myf886avmyg6-zziplib-0.13.69/bin
patching script interpreter paths in /nix/store/n49h5rbhxaa4l053ix72myf886avmyg6-zziplib-0.13.69

Success on x86_64-linux (full log)
Attempted: zziplib
Partial log (click to expand)
shrinking /nix/store/9lh4yxh3lq6mv354jvbd3gqjv4dha740-zziplib-0.13.69/bin/zzxordir
shrinking /nix/store/9lh4yxh3lq6mv354jvbd3gqjv4dha740-zziplib-0.13.69/lib/libzzip-0.so.13.0.69
shrinking /nix/store/9lh4yxh3lq6mv354jvbd3gqjv4dha740-zziplib-0.13.69/lib/libzzipmmapped-0.so.13.0.69
shrinking /nix/store/9lh4yxh3lq6mv354jvbd3gqjv4dha740-zziplib-0.13.69/lib/libzzipfseeko-0.so.13.0.69
shrinking /nix/store/9lh4yxh3lq6mv354jvbd3gqjv4dha740-zziplib-0.13.69/lib/libzzipwrap-0.so.13.0.69
gzipping man pages under /nix/store/9lh4yxh3lq6mv354jvbd3gqjv4dha740-zziplib-0.13.69/share/man/
strip is /nix/store/fzcs0fn6bb04m82frhlb78nc03ny3w55-binutils-2.28.1/bin/strip
stripping (with command strip and flags -S) in /nix/store/9lh4yxh3lq6mv354jvbd3gqjv4dha740-zziplib-0.13.69/lib  /nix/store/9lh4yxh3lq6mv354jvbd3gqjv4dha740-zziplib-0.13.69/bin
patching script interpreter paths in /nix/store/9lh4yxh3lq6mv354jvbd3gqjv4dha740-zziplib-0.13.69
checking for references to /build in /nix/store/9lh4yxh3lq6mv354jvbd3gqjv4dha740-zziplib-0.13.69...

Success on x86_64-linux (full log)
Attempted: zziplib
Partial log (click to expand)
shrinking /nix/store/i2cpvlv4pk69cabf7806s2nfmvbppfwr-zziplib-0.13.69/bin/zzxordir
shrinking /nix/store/i2cpvlv4pk69cabf7806s2nfmvbppfwr-zziplib-0.13.69/lib/libzzip-0.so.13.0.69
shrinking /nix/store/i2cpvlv4pk69cabf7806s2nfmvbppfwr-zziplib-0.13.69/lib/libzzipmmapped-0.so.13.0.69
shrinking /nix/store/i2cpvlv4pk69cabf7806s2nfmvbppfwr-zziplib-0.13.69/lib/libzzipfseeko-0.so.13.0.69
shrinking /nix/store/i2cpvlv4pk69cabf7806s2nfmvbppfwr-zziplib-0.13.69/lib/libzzipwrap-0.so.13.0.69
gzipping man pages under /nix/store/i2cpvlv4pk69cabf7806s2nfmvbppfwr-zziplib-0.13.69/share/man/
strip is /nix/store/j75dgadrff2d1fyc4fczmcgqkid2imdx-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/i2cpvlv4pk69cabf7806s2nfmvbppfwr-zziplib-0.13.69/lib  /nix/store/i2cpvlv4pk69cabf7806s2nfmvbppfwr-zziplib-0.13.69/bin
patching script interpreter paths in /nix/store/i2cpvlv4pk69cabf7806s2nfmvbppfwr-zziplib-0.13.69
checking for references to /build in /nix/store/i2cpvlv4pk69cabf7806s2nfmvbppfwr-zziplib-0.13.69...

Success on aarch64-linux (full log)
Attempted: zziplib
Partial log (click to expand)
shrinking /nix/store/sap0j2jl24r404rxk6bcc5xzqi9vvj0k-zziplib-0.13.69/lib/libzzipwrap-0.so.13.0.69
shrinking /nix/store/sap0j2jl24r404rxk6bcc5xzqi9vvj0k-zziplib-0.13.69/lib/libzzipfseeko-0.so.13.0.69
shrinking /nix/store/sap0j2jl24r404rxk6bcc5xzqi9vvj0k-zziplib-0.13.69/lib/libzzipmmapped-0.so.13.0.69
shrinking /nix/store/sap0j2jl24r404rxk6bcc5xzqi9vvj0k-zziplib-0.13.69/lib/libzzip-0.so.13.0.69
gzipping man pages under /nix/store/sap0j2jl24r404rxk6bcc5xzqi9vvj0k-zziplib-0.13.69/share/man/
strip is /nix/store/j7d4mr0ikv974ig7yzhknpsq288js4bs-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/sap0j2jl24r404rxk6bcc5xzqi9vvj0k-zziplib-0.13.69/lib  /nix/store/sap0j2jl24r404rxk6bcc5xzqi9vvj0k-zziplib-0.13.69/bin
patching script interpreter paths in /nix/store/sap0j2jl24r404rxk6bcc5xzqi9vvj0k-zziplib-0.13.69
checking for references to /build in /nix/store/sap0j2jl24r404rxk6bcc5xzqi9vvj0k-zziplib-0.13.69...
/nix/store/sap0j2jl24r404rxk6bcc5xzqi9vvj0k-zziplib-0.13.69

Failure on x86_64-darwin (full log)
Attempted: zziplib
Partial log (click to expand)
cannot build derivation '/nix/store/nbb35b7i1ld0zg4drb4xxd2sxs5sm7gq-w3m-0.5.3+git20161120.drv': 10 dependencies couldn't be built
cannot build derivation '/nix/store/hv0licjzdx3jmdywdjd830vrydqbfgid-xnu-osx-10.11.6.drv': 9 dependencies couldn't be built
cannot build derivation '/nix/store/7mq5vk1ch577wx2vghdzjgrhccba0046-IOKit-osx-10.11.6.drv': 3 dependencies couldn't be built
cannot build derivation '/nix/store/jq1y49miypgx1ag7srsa4svg7y7q94ca-configd-osx-10.8.5.drv': 9 dependencies couldn't be built
cannot build derivation '/nix/store/qx40cw37jy1a0xmpl6vlxrxj11b4zm0m-python-2.7.14.drv': 15 dependencies couldn't be built
cannot build derivation '/nix/store/idri609cxqipjp05vcqzbasdajcqj00b-libxml2-2.9.7.drv': 5 dependencies couldn't be built
cannot build derivation '/nix/store/im7wz744yhnl3cr4al81f2vl1avz68fa-libxslt-1.1.32.drv': 5 dependencies couldn't be built
cannot build derivation '/nix/store/jy2jv3vacir2fr7r4l2yv867sx4ydgww-xmlto-0.0.28.drv': 9 dependencies couldn't be built
cannot build derivation '/nix/store/y98wzffsid147wlh83xvaafi8r0522dz-zziplib-0.13.69.drv': 8 dependencies couldn't be built
error: build of '/nix/store/y98wzffsid147wlh83xvaafi8r0522dz-zziplib-0.13.69.drv' failed


Add checks of Python reserved words

Added two more checks if  field's name is not one of Python keywords.

Hi! Thank you for the pull request!
The main motivation to avoid emitting python keywords was to avoid generating invalid mypy. However, for HasField and ClearField, I believe that it is generating Literal arguments of strings. I believe the string "None" is considered valid mypy.
Is there a specific case in which generated mypy on python keywords for HasField and ClearField specifically lead to an issue?
Thanks!
-Nipunn

Thanks for raising the issue! Hopefully this shouldn't be needed going forward. Please feel free to reopen if it continues to be an issue.


docs: blimmer feedback

⚠ WIP ⚠
I got through some of the pages, but there are still others I'd like to review as time permits.

❤

LMK if I can merge these.  Thanks again for reading!

Sure! Go for it as-is. I was hoping to get to the rest of the pages but haven't had time.


Enhance the UI of Power series

Is your feature request related to a problem? Please describe.

A clear and concise description of what the problem is. Ex. I'm always frustrated when [...]

Describe the solution you'd like

A clear and concise description of what you want to happen.

Go ahead
Deadline 20 May,2021


Add TODO comment on validate-app tasks

Project validation doesn't handle failures.  Make a TODO comment to capture this.

@bdurrow let me look at making this into a block. With a block I could do an always line to always delete the project

@bdurrow opened PR #233

Closing due to the blocks