Unable to push

How did you install the Amplify CLI?
npm
If applicable, what version of Node.js are you using?
v16.14.0
Amplify CLI Version
12.0.3
What operating system are you using?
Mac
Did you make any manual changes to the cloud resources managed by Amplify? Please describe the changes made.
No
Describe the bug
I tried amplify push --allow-destructive-graphql-schema-updates and got....
🛑 A deployment is in progress.
🛑 If the prior rollback was aborted, run:
🛑 "amplify push --iterative-rollback" to rollback the prior deployment
🛑 "amplify push --force" to re-deploy
so I tried amplify push --iterative-rollback and got...
An error occurred during the push operation: Cannot iteratively rollback as the following step does not contain a previousMetaKey: {"status":"DEPLOYING"}.
Per https://github.com/aws-amplify/amplify-hosting/issues/2582, I deleted team-provider-info.json in the s3 deployment bucket and tried amplify push again. And I got...
["Index: 0 State: {"deploy":"deploying"} Message: Parameters: [unauthRoleName, OpenSearchEBSVolumeGB, OpenSearchStreamBatchSize, OpenSearchAccessIAMRoleName, OpenSearchStreamingLambdaHandlerName, OpenSearchStreamMaximumBatchingWindowInSeconds, OpenSearchInstanceCount, OpenSearchInstanceType, OpenSearchDebugStreamingLambda, OpenSearchStreamingIAMRoleName, OpenSearchStreamingFunctionName, OpenSearchStreamingLambdaRuntime] do not exist in the template"]
Expected behavior
I would expect it would successfully push.
Reproduction steps
See details.
Project Identifier
No response
Log output

# Put your logs below this line

Additional information
No response
Before submitting, please confirm:

[X] I have done my best to include a minimal, self-contained set of instructions for consistently reproducing the issue.
[X] I have removed any sensitive information from my code snippets and submission.

Hey @LeoReubelt, thank you for reaching out. Just to confirm was the team-provider-info.json removed from you local application or the deployment-state.json file as indicated in the issue provided removed from the S3 bucket?
As Amplify CLI does not store the team-provider-info.json the S3 deployment bucket.
team-provider-info.json is a the file used to share project info within your team and allows the ability to push or pull resources.
if the team-provider-info.json was indeed removed could you add the file back in and retry the push.

Yes @ykethan, my mistake. I removed the deployment-state.json file.  Thank you for your response.

Hey @LeoReubelt, could you try running amplify env checkout <current-env-name>, then run amplify push. this should update your amplify-meta.json.
Do let us know if this does not mitigate the issue.

@ykethan Thanks for the response. I tried that. It worked last time I had this problem. But not this time.

@ykethan - I have sent you the files. We have since abandoned the environment and created a new one. But we are trying to merge in many updates, including a migration to the v2 transformer and a custom resource. The custom resource requires a push from the cli to deploy.  Some of the environments that we are trying to update work correctly, others result in the error listed at the top of the issue. ["Index: 0 State: {\"deploy\":\"deploying\"} Message: Parameters: [unauthRoleName, OpenSearchEBSVolumeGB, OpenSearchStreamBatchSize, OpenSearchAccessIAMRoleName, OpenSearchStreamingLambdaHandlerName, OpenSearchStreamMaximumBatchingWindowInSeconds, OpenSearchInstanceCount, OpenSearchInstanceType, OpenSearchDebugStreamingLambda, OpenSearchStreamingIAMRoleName, OpenSearchStreamingFunctionName, OpenSearchStreamingLambdaRuntime] do not exist in the template"].

Hey @LeoReubelt, thank you for the information. On diving into the files I was unable to find any inconsistencies. The issue appears due to the migration from V1 to V2 with the OpenSearch enabled.
I am going to transfer this to our API repository for further investigation.


Fix x-go-type imports missing

This PR fixes missing imports when using x-go-type extension (issue #1703).

Thanks. Could you please add a unit test, e.g. with your sample spec causing the issue?

fixes #1703

Can you sign this commit? https://help.github.com/articles/about-commit-signature-verification/

Ok, commits squashed and signed with GPG key now.


Only try to start monit once

Precise: https://ocd.appscale.com:8080/job/Daily Build/948/
Trusty: https://ocd.appscale.com:8080/job/Daily Build/949/

:+1:


Mapping to WHO Health workers classification

WHO has an international classification of health workers that is largely based on the International Standard Classification of Occupations (ISCO, 2008 revision):
https://www.who.int/hrh/statistics/Health_workers_classification.pdf
This may be worth exploring and mapping into OMRSE.

Hi Sivarim. Can you please provide a context for how you would like to use this mapping? It would be useful for helping determine how to move forward with this issue. Thank you.

Hi Sivarim. Can you please provide a context for how you would like to use this mapping? It would be useful for helping determine how to move forward with this issue. Thank you.


Istio HTTP2 gRPC: error sending frames: Too many frames in the outbound queue

Bug Description
Have an environment with HTTP Ingress Gateway, Virtual Service, and Service with two POD grpc port servers (come with istio sidecar.
We have another POD that connects in via above Ingress Gateway using secure gRPC. It establishes one channel with many RPCs stream and each with many messages. Don't know the number (wonder if prom metric can show that)
From clients perspective we observe slow retrieval of messages or aborted connections when we trying to establish first connection. It however resolves after 15-20min. If we simulate client or server app failure it would everytime go through the same issue.
Client log example:
{"@t":"2022-08-23T16:06:12.2109788Z","@m": "Error reading message.","@i":"d037f3b0","@x":"System.IO.IOException: The request was aborted.\n ---> System.Net.Http.Http2StreamException: The HTTP/2 server reset the stream. HTTP/2 error code 'NO_ERROR' (0x0).\n   --- End of inner exception stack trace ---\n   at System.Net.Http.Http2Connection.ThrowRequestAborted(Exception innerException)\n   at System.Net.Http.Http2Connection.Http2Stream.CheckResponseBodyState()\n   at System.Net.Http.Http2Connection.Http2Stream.TryReadFromBuffer(Span`1 buffer, Boolean partOfSyncRead)\n   at System.Net.Http.Http2Connection.Http2Stream.ReadDataAsync(Memory`1 buffer, HttpResponseMessage responseMessage, CancellationToken cancellationToken)\n   at Grpc.Net.Client.Web.Internal.GrpcWebResponseStream.TryReadDataAsync(Stream responseStream, Memory`1 buffer, CancellationToken cancellationToken)\n   at Grpc.Net.Client.Web.Internal.GrpcWebResponseStream.ReadAsync(Memory`1 data, CancellationToken cancellationToken)\n   at Grpc.Net.Client.StreamExtensions.ReadMessageAsync[TResponse](Stream responseStream, GrpcCall call, Func`2 deserializer, String grpcEncoding, Boolean singleMessage, CancellationToken cancellationToken)\n   at Grpc.Net.Client.Internal.HttpContentClientStreamReader`2.MoveNextCore(CancellationToken cancellationToken)","EventId":{"Id":17,"Name":"ErrorReadingMessage"},"SourceContext":"Grpc.Net.Client.Internal.GrpcCall","GrpcMethodType":"ServerStreaming","GrpcUri":"/myApp/Subscriber","UserId":35,"TypeId":1}
{"@t":"2022-08-23T16:06:12.2114158Z","@m":"Call failed with gRPC error status. Status code: 'Internal', Message: '\"Error reading next message. IOException: The request was aborted. Http2StreamException: The HTTP/2 server reset the stream. HTTP/2 error code 'NO_ERROR' (0x0).\"'.","@i":"bcfa385f","StatusCode":"Internal","StatusMessage":"Error reading next message. IOException: The request was aborted. Http2StreamException: The HTTP/2 server reset the stream. HTTP/2 error code 'NO_ERROR' (0x0).","EventId":{"Id":3,"Name":"GrpcStatusError"},"SourceContext":"Grpc.Net.Client.Internal.GrpcCall","GrpcMethodType":"ServerStreaming","GrpcUri":"/myApp/Subscriber","UserId":35,"TypeId":1}

Sidecar logs with info logLevel
2022-08-24T08:56:30Z {"x_forwarded_for":"<IP_ADDRESS>","response_code_details":"http2.outbound_frames_flood","upstream_service_time":"215","route_name":"default","upstream_host":"<IP_ADDRESS>:5001","request_id":"90e6053d-7a21-4678-9081-74bef02da6dd","path":"/myApp/Subscriber","authority":"k.mydomain.com","protocol":"HTTP/2","method":"POST","response_code":200,"upstream_transport_failure_reason":null,"connection_termination_details":null,"requested_server_name":null,"response_flags":"DPE","bytes_received":28,"duration":319,"upstream_cluster":"inbound|5001||","start_time":"2022-08-24T08:56:29.623Z","upstream_local_address":"<IP_ADDRESS>:44499","user_agent":"grpc-dotnet/2.47.0 (.NET 6.0.6; CLR 6.0.6; net6.0; linux; x64)","bytes_sent":57826,"downstream_local_address":"<IP_ADDRESS>:5001","downstream_remote_address":"<IP_ADDRESS>:0"}
2022-08-24T08:56:30Z {"upstream_cluster":"inbound|5001||","response_code_details":"http2.outbound_frames_flood","protocol":"HTTP/2","route_name":"default","downstream_local_address":"<IP_ADDRESS>:5001","authority":"k.mydomain.com","upstream_local_address":"<IP_ADDRESS>:44499","bytes_sent":100277,"start_time":"2022-08-24T08:56:29.601Z","connection_termination_details":null,"bytes_received":28,"x_forwarded_for":"<IP_ADDRESS>","duration":340,"user_agent":"grpc-dotnet/2.47.0 (.NET 6.0.6; CLR 6.0.6; net6.0; linux; x64)","path":"/myApp/Subscriber","upstream_host":"<IP_ADDRESS>:5001","downstream_remote_address":"<IP_ADDRESS>:0","requested_server_name":null,"method":"POST","upstream_transport_failure_reason":null,"request_id":"7ba05716-a67f-4853-a033-76c15d3ab8e7","upstream_service_time":"204","response_code":200,"response_flags":"DPE"}
2022-08-24T08:56:30Z {"bytes_sent":1596,"bytes_received":27,"path":"/myApp/Subscriber","requested_server_name":null,"upstream_transport_failure_reason":null,"upstream_service_time":"320","user_agent":"grpc-dotnet/2.47.0 (.NET 6.0.6; CLR 6.0.6; net6.0; linux; x64)","response_code":200,"upstream_local_address":"<IP_ADDRESS>:44499","duration":341,"connection_termination_details":null,"response_flags":"DPE","response_code_details":"http2.outbound_frames_flood","downstream_local_address":"<IP_ADDRESS>:5001","protocol":"HTTP/2","upstream_cluster":"inbound|5001||","downstream_remote_address":"<IP_ADDRESS>:0","authority":"k.mydomain.com","upstream_host":"<IP_ADDRESS>:5001","request_id":"d81497dc-0af0-4f04-b1e0-1e9855889a87","x_forwarded_for":"<IP_ADDRESS>","method":"POST","start_time":"2022-08-24T08:56:29.601Z","route_name":"default"}
2022-08-24T08:56:30Z {"requested_server_name":null,"upstream_cluster":"inbound|5001||","authority":"k.mydomain.com","duration":518,"user_agent":"grpc-dotnet/2.47.0 (.NET 6.0.6; CLR 6.0.6; net6.0; linux; x64)","response_code_details":"http2.outbound_frames_flood","method":"POST","bytes_sent":190981,"downstream_local_address":"<IP_ADDRESS>:5001","connection_termination_details":null,"response_code":200,"protocol":"HTTP/2","upstream_transport_failure_reason":null,"upstream_service_time":"109","route_name":"default","upstream_host":"<IP_ADDRESS>:5001","request_id":"d334c574-ec30-42b9-bf6c-5d77480a89c1","upstream_local_address":"<IP_ADDRESS>:44499","path":"/myApp/Subscriber","response_flags":"DPE","start_time":"2022-08-24T08:56:29.424Z","bytes_received":27,"x_forwarded_for":"<IP_ADDRESS>","downstream_remote_address":"<IP_ADDRESS>:0"}
2022-08-24T08:56:30Z {"response_flags":"DPE","response_code_details":"http2.outbound_frames_flood","authority":"k.mydomain.com","start_time":"2022-08-24T08:56:29.069Z","method":"POST","request_id":"d4fe4ffa-9041-4250-acd1-6b25f0888927","upstream_transport_failure_reason":null,"upstream_host":"<IP_ADDRESS>:5001","x_forwarded_for":"<IP_ADDRESS>","path":"/myApp/Subscriber","bytes_received":28,"downstream_remote_address":"<IP_ADDRESS>:0","connection_termination_details":null,"bytes_sent":494966,"upstream_local_address":"<IP_ADDRESS>:44499","upstream_service_time":"142","user_agent":"grpc-dotnet/2.47.0 (.NET 6.0.6; CLR 6.0.6; net6.0; linux; x64)","route_name":"default","duration":873,"requested_server_name":null,"upstream_cluster":"inbound|5001||","response_code":200,"downstream_local_address":"<IP_ADDRESS>:5001","protocol":"HTTP/2"}
2022-08-24T08:56:30Z {"request_id":"adc5ad67-d5fc-4cab-81ea-69a8e8c42d4c","bytes_received":27,"x_forwarded_for":"<IP_ADDRESS>","duration":1007,"path":"/myApp/Subscriber","requested_server_name":null,"response_flags":"DPE","response_code_details":"http2.outbound_frames_flood","method":"POST","upstream_host":"<IP_ADDRESS>:5001","authority":"k.mydomain.com","upstream_cluster":"inbound|5001||","downstream_local_address":"<IP_ADDRESS>:5001","downstream_remote_address":"<IP_ADDRESS>:0","start_time":"2022-08-24T08:56:28.935Z","connection_termination_details":null,"upstream_service_time":"167","upstream_transport_failure_reason":null,"upstream_local_address":"<IP_ADDRESS>:44499","protocol":"HTTP/2","response_code":200,"route_name":"default","bytes_sent":666795,"user_agent":"grpc-dotnet/2.47.0 (.NET 6.0.6; CLR 6.0.6; net6.0; linux; x64)"}
2022-08-24T08:56:30Z {"response_flags":"DPE","x_forwarded_for":"<IP_ADDRESS>","bytes_sent":691441,"response_code_details":"codec_error:Too_many_frames_in_the_outbound_queue.","downstream_remote_address":"<IP_ADDRESS>:0","protocol":"HTTP/2","method":"POST","connection_termination_details":null,"requested_server_name":null,"upstream_local_address":"<IP_ADDRESS>:44499","route_name":"default","upstream_cluster":"inbound|5001||","downstream_local_address":"<IP_ADDRESS>:5001","request_id":"d2ef3e41-b70b-454a-9267-4cec5869a5e2","upstream_transport_failure_reason":null,"path":"/myApp/Subscriber","authority":"k.mydomain.com","upstream_service_time":"89","bytes_received":27,"response_code":200,"duration":15038,"upstream_host":"<IP_ADDRESS>:5001","user_agent":"grpc-dotnet/2.47.0 (.NET 6.0.6; CLR 6.0.6; net6.0; linux; x64)","start_time":"2022-08-24T08:56:14.904Z"}
2022-08-24T08:56:30Z {"start_time":"2022-08-24T08:56:13.968Z","response_code_details":"codec_error:Too_many_frames_in_the_outbound_queue.","downstream_remote_address":"<IP_ADDRESS>:0","method":"POST","authority":"k.mydomain.com","duration":15975,"response_code":200,"upstream_host":"<IP_ADDRESS>:5001","upstream_local_address":"<IP_ADDRESS>:44499","protocol":"HTTP/2","bytes_received":27,"request_id":"a301b3d2-443f-45fd-ae47-fd96f1520767","upstream_transport_failure_reason":null,"route_name":"default","x_forwarded_for":"<IP_ADDRESS>","upstream_service_time":"48","path":"/myApp/Subscriber","upstream_cluster":"inbound|5001||","requested_server_name":null,"downstream_local_address":"<IP_ADDRESS>:5001","bytes_sent":538744,"response_flags":"DPE","user_agent":"grpc-dotnet/2.47.0 (.NET 6.0.6; CLR 6.0.6; net6.0; linux; x64)","connection_termination_details":null}

No errors on the ingress-gateway, it has info logLevel.
After enabling debug logLevel on ingress-gateway and the sidecar, only sidecar gives some additional valuable error messages:
istio-proxy sidecar log:
[C1291] error sending frames: Too many frames in the outbound queue.
[C1291] error sending data frame: Too many frames in the outbound queue

Tested gRPC connection directly to Kubernetes Service, bypassing IngressGateway, still using sidecars.
Errors and problems don't appear. Everything just works fine.
Disabling mTLS on the sidecar doesn't solve or change the behavior of the problem.
Workaround:
Raising max_outbound_frames from default 10k to 1mil through EnvoyFilter API object for the Istio Sidecar fixes the issue and we no longer see errors.
https://www.envoyproxy.io/docs/envoy/latest/api-v3/config/core/v3/protocol.proto
Raising the max_outbound_frames limit on ingress-gateway had no impact. Issue persisted.
I wonder why this is such an odd behaviour. Connections bypassing ingress-gateway but still going via sidecar don't manifest the problem (without workaround). Is this some kind of a bug related to ingerss-gateway and istio sidecar communication?
Version
#istioctl version
client version: 1.13.7
control plane version: 1.13.5
data plane version: 1.13.5 (12 proxies)

#kubectl version
Client Version: version.Info{Major:"1", Minor:"19", GitVersion:"v1.19.3", GitCommit:"1e11e4a2108024935ecfcb2912226cedeafd99df", GitTreeState:"clean", BuildDate:"2020-10-14T12:50:19Z", GoVersion:"go1.15.2", Compiler:"gc", Platform:"windows/amd64"}
Server Version: version.Info{Major:"1", Minor:"22", GitVersion:"v1.22.11", GitCommit:"3555818fec8c78bae4c1c245ab5e1d2bf836f8c6", GitTreeState:"clean", BuildDate:"2022-07-28T23:33:03Z", GoVersion:"go1.16.15", Compiler:"gc", Platform:"linux/amd64"}

Additional Information
No response

@PowerSurj  I'm seeing a very similar issue but my Ingress is ingress-nginx.
Can you please post an example of the EnvoyFilter yaml you used to override max_outbound_frames.

apiVersion: networking.istio.io/v1alpha3
kind: EnvoyFilter
metadata:
  name: myapp-release-network-filters
  namespace: myapp-namespace
spec:
  configPatches:
    - applyTo: NETWORK_FILTER
      match:
        listener:
          filterChain:
            filter:
              name: envoy.filters.network.http_connection_manager
      patch:
        operation: MERGE
        value:
          typed_config:
            '@type': >-
              type.googleapis.com/envoy.extensions.filters.network.http_connection_manager.v3.HttpConnectionManager
            http2_protocol_options:
              max_outbound_frames: 1000000
  workloadSelector:
    labels:
      app.kubernetes.io/instance: myapp-release

I think on Ingress you need to apply two filter one on the http_connection_manager that accepts connections and one on the upstream cluster.
@howardjohn @hzxuzhonghu We have been dealing with similar issues and it is quite difficult to add envoy filters for this because

We need many on each hop (downstream HCM, upstream cluster, virtual inbound and inbound cluster) to make this reliably work
For the outbound listener, we can not add to a specific service because the HCM is a shared one and routes are identified by domains

I am wondering, if we should expose this in DR and reliably configure this setting for all clients and clusters. WDYT?

How about making the default value unlimited, i think we have done similar for timeout

That would work. But does it have any security implications? I think that was one of the motivations for Envoy to add those limits

Need to check why envoy set that default value

https://github.com/envoyproxy/envoy/commit/b93886ca040795407efc641f8b41eaf35e7bf1bb This is the history of why Envoy added them

https://github.com/istio/istio/pull/41325 can work for this case

I think that does not work. Another idea is set max_outbound_frames to large number in the mesh (sidecars) by default and people can control it at gateway with envoy filter as the gateway has typically a HCM per server.

I donot think we should set large number by default. After reading the context, it is to solve some CVEs

After reading the context, it is to solve some CVEs

I know but that is mostly true for untrusted clients. Not mesh clients typically.

A little bit deeper, how many concurrent frames sent could cause this error to occur? Is this caused mostly by the peer does not receive on the frame?

A little bit deeper, how many concurrent frames sent could cause this error to occur

Any thing beyond 10000 I guess.

Is this caused mostly by the peer does not receive on the frame?

Yes.
Also following up with Envoy folks on best practices
https://github.com/envoyproxy/envoy/issues/17287#issuecomment-1260348184


Error in handshake

Log from example application:
2018/01/31 11:16:38 MAIN: load authentication
2018/01/31 11:16:38 [MM 493794111] start
2018/01/31 11:16:38 [MM 493794111] loadsession of  +79689329901
2018/01/31 11:16:38 [0-5104173340106603236] dial TCP to <IP_ADDRESS>:443
2018/01/31 11:16:38 [0-5104173340106603236] read: start
2018/01/31 11:16:38 [0-5104173340106603236] send: start
2018/01/31 11:16:38 [0-5104173340106603236] send mtproto.TL_invokeWithLayer: {"Layer":71,"Query":{"Api_id":35556,"Device_model":"Unknown","System_version":"linux/amd64","App_version":"0.0.1","System_lang_code":"en","Lang_pack":"","Lang_code":"en","Query":{}}}
2018/01/31 11:16:38 [0-5104173340106603236] read: type: mtproto.TL_crc_bad_msg_notification, data: {6517125814043208060 1 17}, err: <nil>
2018/01/31 11:16:38 [0-5104173340106603236] process: unknown data type mtproto.TL_crc_bad_msg_notification {{}}
2018/01/31 11:16:43 [MM 493794111] connect failure: Handshaking Failure: TL_invokeWithLayer Timeout(5.000000 s)
2018/01/31 11:16:43 [0-5104173340106603236] send: stop
2018/01/31 11:16:43 [0-5104173340106603236] read: wait for inner routine ...
2018/01/31 11:16:43 [0-5104173340106603236] read: type: <nil>, data: <nil>, err: read tcp <IP_ADDRESS>:36862-><IP_ADDRESS>:443: use of closed network connection
2018/01/31 11:16:43 [0-5104173340106603236] read: TCP connection closed (read tcp <IP_ADDRESS>:36862-><IP_ADDRESS>:443: use of closed network connection)
2018/01/31 11:16:43 [0-5104173340106603236] notify MEvent, mtproto.refreshSession: {}, to [0xc420022180]
2018/01/31 11:16:43 [0-5104173340106603236] read: stop
2018/01/31 11:16:43 [0-5104173340106603236] notify MEvent, mtproto.SessionDiscarded: {}, to [0xc420022180]
2018/01/31 11:16:43 [MM 493794111] session discarded<PHONE_NUMBER>106603236
2018/01/31 11:16:43 [MM 493794111] refreshSession<PHONE_NUMBER>106603236
2018/01/31 11:16:43 ERR: Handshaking Failure: TL_invokeWithLayer Timeout(5.000000 s)

$ go version
go version go1.9.2 linux/amd64

$ uname -a
Linux wks-mishkin 4.4.0-112-generic #135-Ubuntu SMP Fri Jan 19 11:48:36 UTC 2018 x86_64 x86_64 x86_64 GNU/Linux

I'm having the same problem as @parserpro:
TL_updates_getState Failure: mtproto RPC error: 401 AUTH_KEY_UNREGISTERED
when trying to run simpleshell.go.
ID and HASH are valid.

Can you make sure you signed-up to Telegram with your phonenumber?
If so, please try it again after removing ${HOME}/.telegram_*** file.
If it still doesn't work, let me know with your environment (e.g., OS, Go version, ...).

@cjongseok Just tested with a fresh Telegram account. Same problem.
I'm on Windows 10 x64, Go version 1.10 (also tried on 1.9.2)

Sorry for that. I have just fixed the issue. Please try the new version.

@cjongseok issue is fixed, thank you!


iterative refinement edge case

Fixes an edge case in iterative refinement for KKT solves.

Codecov Report
Patch coverage: 72.34% and project coverage change: -1.19 :warning:

Comparison is base (50b0c6e) 82.22% compared to head (ba06cdd) 81.04%.

:mega: This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #128      +/-   ##
==========================================
- Coverage   82.22%   81.04%   -1.19%
==========================================
  Files          37       39       +2
  Lines        2701     2817     +116
==========================================
+ Hits         2221     2283      +62
- Misses        480      534      +54

Impacted Files
Coverage Δ

src/cones/coneops_defaults.jl
15.55% <0.00%> (-7.18%)
:arrow_down:

src/equilibration.jl
97.95% <ø> (ø)

src/precompile.jl
0.00% <0.00%> (ø)

src/settings.jl
4.44% <0.00%> (-3.56%)
:arrow_down:

src/variables.jl
77.64% <ø> (+11.64%)
:arrow_up:

src/version.jl
28.57% <0.00%> (ø)

src/Clarabel.jl
55.55% <42.85%> (-44.45%)
:arrow_down:

src/utils/mathutils.jl
81.59% <50.00%> (+4.39%)
:arrow_up:

src/types.jl
85.71% <70.00%> (-0.65%)
:arrow_down:

src/MOI_wrapper/MOI_wrapper.jl
85.11% <85.71%> (+0.14%)
:arrow_up:

... and 16 more

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.


Alternative syntax for colspan to support prettier auto format (vscode)

Would it be possible to add additional colspan syntax so that auto-formatting with prettier is supported out-of-the-box?
When I write following table:
| Header 1 | Header 2 ||
| -- | -- | -- |
| Stuff 1 | Stuff 2.1 | Stuff 2.2 |

prettier will format it to:
| Header 1 | Header 2  |           |
| -------- | --------- | --------- |
| Stuff 1  | Stuff 2.1 | Stuff 2.2 |

thereby removing the colspan. Would it be possible to support something like the following, to avoid this issue:
| Header 1 | Header 2 |>>|
| -- | -- | -- |
| Stuff 1 | Stuff 2.1 | Stuff 2.2 |

Prettier would format it to:
| Header 1 | Header 2  | >>        |
| -------- | --------- | --------- |
| Stuff 1  | Stuff 2.1 | Stuff 2.2 |

So, if the colspan syntax supports | >> | in addition to ||, one could continue using formatOnSave with prettier. Allowing to configure this feature and escaping arrows (\>) when needed, could solve possible conflicts.

Sorry for the extremely late reply. :sweat:
The patch is relatively easy, as the commit above. I'm just considering an appropriate option sets, since it looks inconsistent to have rowspan and colspan_syntax options.
One rational solution lefts {colspan: "", rowspan: undefined} as default. This changes behavior of rowspan and thus have to propogate until v5.0.0; Moreover, the colspan option must treat empty string as the special case, or regex comes in for the alternative syntax: \s*<<\s*.
One compromising solution lefts {rowspan: false, colspan_syntax: undefined, rowspan_syntax: undefined} as default. But it seems somewhat confusing and redundant, and colspan problem still exists.
I've noticed relevant discussion in CommonMark forum, but no conclusion drawn yet. I may left this branch unmerged until other Markdown derivatives proposed other solutions.  :confused:


Misaligned buttons on Android skin

Those arrowses aren't aligned. Not sure if MDL bug or skin bug.

Material specs don't define a button with text and icon

The closest it gets is for -- say -- a dropdown, where the icon aside the text aligns properly.

I don't have this problem... Firefox 45.0a2 and latest Chrome Canary
http://codepen.io/jfily/pen/QjROwd

Those aren't menu indicators. Just icons to enhance the view. I believe it is from custom CSS for that template.
Template work can be handled after the 1.1 release, just like any doc updates that may happen. Right now we are focusing on fixing up the core code for the next patch and getting it out.

Looping in @sgomes as he did the template. Must be a regression, I am pretty sure the template used to look fine. Looks the same in FF btw. Thanks @paullewis

Yup, looks like something changed and those icons got misaligned. Investigating.


declare unwanted but implicit dependency

Until this implicitly dependency is removed (ros2/rmw_opensplice#39) it must be declared correctly declared in order to not break isolated builds.

+1

+1


Security/Use in public repos

From this description it is not yet clear under where hercules ci evaluates effects: https://docs.hercules-ci.com/hercules-ci-effects/guide/deploy-a-nixos-machine/
Could someone add effects as a pull request on my machine and use it to execute commands on my agents?

Effects run on linux in a sandbox with access to configured secrets, but no access to the host file system, except for the Nix store.
Currently the security model is to trust refs that are in the repository itself, meaning only those with write access to the repo can use your configured secrets and Nix store. A pull request from a fork won't be built, until you or a bot like bors "approve" it by pushing it to a local ref.

Ok, but it can still access the network as it can deploy NixOS? Also this means it adds unencrypted secrets to the world-readable nix store?

It will not add unencrypted secrets to the Nix store unless you ask it to. The secrets are written to a regular file that is made available in the effects sandbox, without involving the store.
Only secrets specified in the values of secretsMap will be copied into the sandbox, using the attribute names as secret names. The file is pointed to by $HERCULES_CI_SECRETS_JSON in the sandbox environment.
It can be used by functions like readSecretString.
The runNixOS effect works in the same way. You add an SSH key for the host you want to deploy to your agent's secrets.json, which is unencrypted but only needs to be readable by the agent user (NixOS module: hercules-ci-agent). Now the expressions in your repositories can reference the SSH key for use in an effect.
The sandbox does not have direct access to the host, so it needs to use ssh or similar. For now though, I don't recommend to CD the agent host, because agent restarts interfere with running effects, including the self-deployment. You can follow https://github.com/hercules-ci/hercules-ci-agent/issues/273 for updates about this feature. However, I do find the effects sandbox by itself useful for hermetic deployment, using hci effect run and hci secret add to manage user local secrets for hci in ~/.config/hercules-ci/secrets.

Thanks


Broken Self::borrow link in docs

The docs for PreparedQuery::query_mut() contain a broken link for [`borrow`][Self::borrow].

Thanks for the report!


[Plugin] Fix pod try detection

\c @orta

I don't have enough context to really understand if this is gonna fix it, but if it is, awesome :dancers:
The fails are rubocop.

The realpath is what fixes it var to private/var

Cool, looks mergable on the RuboCop fix :+1:

@orta feel free to do that, ✈ later.

:+1:

<3 thanks Orta!


Android: handle REAL datatype correctly

It looks like on Android big REAL number were put on a float data type, which resulted in incorrect queries results. This PR fixes the issue for my use case. Not sure if it has any negative implications.

Can you post a code that reproduces the problem?

consider the schema:
CREATE TABLE IF NOT EXISTS visits (
id INTEGER PRIMARY KEY AUTOINCREMENT,
date REAL NOT NULL)

lets add a record:
const db = SQLite.openDatabase('visits.db', '1.0', '', 1);
db.transaction((txn) => {
  const date = Date.now() * 1000;
  console.log('insert', date);
  txn.executeSql('INSERT OR IGNORE INTO visits (date) VALUES (?)', [date]);
});

and retrieve it back:
db.transaction((txn) => {
  txn.executeSql('SELECT date FROM visits LIMIT 1;', [], (res, tx) => {
    console.log('retrieved', res.rows.item(0).date);
  });
});

The retrieved value will be different than the one selected.
Changing data type from float to double fixes the problem.

Okay, got it. Thanks!


Message: Can’t render a preview. The Content-Type header is missing or unknown.

A message is appearing: "Unable to render a preview. The Content-Type header is missing or unknown." Why does the result of the GET request not appear?
Example created in C# MVC API REST

Hi there,
I just did a quick test and I am having the same issue with the latest version of the package (1.1.1), which uses the scalar version of 1.22.48. As far as I can see other people also experience similar issues and it was already reported on the Scalar repository. (See here).
For now I would suggest to use 1.1.0 until they fix the problem on their and.

Hi @benirave, looks like this issue is already solved in the latest version of Scalar. Are you able to merge the following PR? https://github.com/benirave/AspNetCore.Scalar/pull/38

Hi @rknubreed,
Actually, I've already tested the latest scalar version (1.23.5) but I tested it again, and you are right it fixed the issue for me, so I most probably missed something previously. Can you double check just in case that the new version of this package (1.1.2) solves this issue?

Hi @benirave @fulviocanducci ,
I just checked the new package and I can confirm that it works as exepcted - preview is generated.

Great news, @rknubreed thanks for taking the time!
I am closing the issue.


service queue

added 4 agents to run a "glue" scripts to setup and report results. That should offload linux queue and, more importantly, don't block lightweight operation on running builds.
for #292

waiting for https://buildkite.com/llvm-project/premerge-checks/builds/36037#45559079-95a3-46d3-8d6f-9c869256c84e to complete


Include SVG

Including SVG in the document like an image.
Maybe using Apache Batik and FOP?

Should be usable using the #IMAGE# thingy

We can try this but I want the result to not be a pixelated graphic which we need to check first.

Pushed to v0.2

Mostly users should be able to export their SVGs to PDF using their software (Adobe Illustrator or Inkscape), thus it does not really make sense to include big dependencies like Batik and FOP.
Nevertheless it will certainly be useful for some users, thus we can allow specifying an SVG in the #IMAGE# thingy when the user has installed inkscape. We can use Inkscape on the command line to produce PDFs from SVGs. Since we should be able to include PDFs using changes from #8 the further process should be familiar.


add other to_parquet examples

It took me longer than I would have liked to work out how to save a dask.dataframe in an Azure blob.
https://stackoverflow.com/questions/60765331/moving-data-from-a-database-to-azure-blob-storage/60773724#60773724
Is there any appetite for adding another example to https://github.com/dask/dask/blob/master/dask/dataframe/io/parquet/core.py#L337?
The example there currently is about as minimal as you can get (which I understand is the idea).
Or there could be a separate page/section for this. i.e. near https://docs.dask.org/en/latest/dataframe-create.html#locations

Docstring examples should be relatively short and self contained, but we should definitely have a section in our docs about writing to external filesystems. I think https://docs.dask.org/en/latest/dataframe-create.html would be a good place. We should probably add a cross reference to https://docs.dask.org/en/latest/remote-data-services.html from that page as well.
Would you be interested in contributing a short docs section?

Happy to do so


Super resolution with cubic sr_mode

Hi there, Great work you have done! Just one small question, when I change the sr_mode from blur to cubic in sisr_demo.yaml. The result seems pretty poor, just wonder if you can share the hyperparameters( such as gamma, lambda, sigma) to restore the results in demo_test. Thanks!

Hi, could you please provide the config of your test code? i.e the modification you’ve made

task: sr
seed: 42
noise_level_img: 12.75
noise_level_model: noise_level_img
model_name: diffusion_ffhq_10m
L_testset_name: Data
H_testset_name: Labels
test_task: cubic_4
num_train_timesteps: 1000
iter_num: 100
iter_num_U: 1
batch_size: 16
save_L: true
save_E: true
lambda_: 1
zeta: 0.1
sub_1_analytic: true
log_process: false
ddim_sample: false
model_output_type: pred_xstart
generate_mode: DiffPIR
skip_type: quad
eta: 0
guidance_scale: 1.0 # effective guidance scale
n_channels: 3
cwd: ''
testsets: 'testsets/demo_test'
calc_LPIPS: true
beta_start: 0.0001
beta_end: 0.02
noise_init_img: max
skip_noise_model_t: false
sf: 4
sr_mode: cubic
inIter: 100
gamma: 0.01

@k101w there is record on this here https://github.com/yuanzhi-zhu/DiffPIR/blob/592826b9db9075763e2ce70d085b14638fffd890/main_ddpir_sisr.py#L63-L64
I just tried zeta:0.25, lambda:2, guidance_scale:1.0, inIter:5, gamma:0.05, which also works well.
You can further finetune these hyperparameters based on this.
Please donot heasitate to ask if you have any further questions :)

Thanks for the response! Let me try it out. Btw I am also curious about the two sr_mode down sampling method. I see for 'blur', you use imresize_np function which you set the kernel_width = 4 and kernel = 'cubic'. For 'cubic', you use Resizer class which has the same kernel setting, what is the difference between these two methods which makes them two seperate sr_mode?

for sr_mode='blur' we adapt the resizer from DPIR, which supports closed-form solution.
(In DPIR, debluring can be considered as a special case of SR with scalar factor=1)
for sr_mode='cubic', we use the Resizer class from DPS.

Thanks! But what is the algorithm difference here?

you's better try them with the solver to check the final results.
anyway, it's recommended to use the blur mode

Thank you! Really appreciate your quick reply, but I still wonder if you can give me intuition of the difference of these two methods algorithmically.

In short, most of the plug & play image restoration with diffusion models decomposes the posterior into prior and likelihood terms. And the difference between different methods lies in the handling of the likelihood term. You can find more on this in the slides.
In our SR cases, we can process the likelihood term with either the iterative back-projection (IBP) in DPIR Eq. (12) or the closed form solution as in DPIR Eq (14).
While in theory the closed form is preferred, in practice it quite depends.
If you are asking for the convergence analysis, I have no idea 🤣

I see.. Thank you for the great answers!


Release build failing

I merged the release patch it looks like the release build is failing.
Additionally, it looks like it is tagging version on each merge (maybe) as opposed to once a week...
Failure here: https://github.com/substrait-io/substrait-java/actions/runs/3544635664/jobs/5952198598
@davisusanibar, can you take a look?

Let me check that

Hi @jacques-n / @westonpace
I'am seeing this error message on the release: https://github.com/substrait-io/substrait-java/actions/runs/3550260556/jobs/5963588183
* What went wrong:
Could not evaluate onlyIf predicate for task ':core:signMaven-publishPublication'.
> Could not read PGP secret key

Could you try to run Sanity Check Environment to test secrets configuration?

Reopening as the release is still failing.

@davisusanibar : https://github.com/substrait-io/substrait-java/actions/runs/3550853020/jobs/5964589379

Please update secret value for SIGNING_KEY
SIGNING_KEY needs to be generated with this command line: gpg --export-secret-keys C8BA52B3 | base64
As the message mention base64: invalid input I could suggest that the current value is invalid, please in case this was created with gpg --export-secret-keys --armor C8BA52B3, please change to use base64 command line mentioned.
@westonpace / @jacques-n

Yes, I had exported the key in --armor format (I think this is what Sonatype wants).  Either way, I have updated they key to be base64 encoded non-armor.  The sanity script now passes.  The release script failed because the signing key was invalid.  It wanted an 8-digit signing key.  I had included the full signing key.  I have changed the signing key secret to the short key.
This is ready to run again.
However, semantic release refuses to create a release because it doesn't see any changes.
So we will either need to create a dummy commit or wait for a change.

An option could be to review https://github.com/substrait-io/substrait-java/pull/104 that is related with promote version from Staging to Production after 14 days old, and use that to test semantic-release process.

Release available at:

Core: https://search.maven.org/artifact/io.substrait/core/0.1.4/jar
Isthmus: https://search.maven.org/artifact/io.substrait/isthmus/0.1.4/jar


Rtsp-simple-server not working

Hi, we are trying to test the sample project with a very well known open source rtsp server/proxy. FFmpeg and other projects work fine. We cannot get rtsp push streaming from any of your samples to work.
You can find the project here, with precompiled binaries:
https://github.com/aler9/rtsp-simple-server
We are using rtsp and trying to simply push video to a server for testing, but we just get immediate retry errors.
Please let us know if you can confirm if it works or not.

I fixed it for RTSP/UDP:
https://github.com/pedroSG94/rtmp-rtsp-stream-client-java/commit/1199744d5218422ae6aba29ea3bfdb6a5351c28a
Open custom rtsp example, in menu select udp and try.
RTSP/TCP is not working for now, I'm looking the reason.

Hi Pedro thanks for the quick reply to the issue above. I have tested the same server/RSTP-UDP streaming configuration and the problem is still there. I suspect that is because the changes you added in the 1199744 commit do not appear in the official maven repository that i am using (https://jitpack.io).  For example the createH264Body in Body.java (from maven) is still using RtpConstants.payloadType instead of the RtpConstants.payloadTypeVideo. If that is the case please update maven. Otherwise why would  the custom rtsp example not work on UDP?

Hi Pedro thanks for the quick reply to the issue above. I have tested the same server/RSTP-UDP streaming configuration and the problem is still there. I suspect that is because the changes you added in the 1199744 commit do not appear in the official maven repository that i am using (https://jitpack.io).  For example the createH264Body in Body.java (from maven) is still using RtpConstants.payloadType instead of the RtpConstants.payloadTypeVideo. If that is the case please update maven. Otherwise why would  the custom rtsp example not work on UDP?

Is it possible to also fix it for TCP streaming?

Is it possible to also fix it for TCP streaming?

I just tested the 1.9.7 release and I can confirm that the RTSP over TCP is fixed. Thank you.
However the UDP is not working yet.

I just tested the 1.9.7 release and I can confirm that the RTSP over TCP is fixed. Thank you.
However the UDP is not working yet.

This is duplicated now. I will close this one and wait for your reply in the other issue.

This is duplicated now. I will close this one and wait for your reply in the other issue.


Routes dashes in URI's to be converted. Fixes #1564

Description
Whether dashes in URI's should be converted to underscores when determining method names.
Checklist:

[x] Securely signed commits
[x] Component(s) with PHPdocs
[x] Unit testing, with >80% coverage
[ ] User guide updated
[x] Conforms to style guide

sorry. I tested your code, but, no change. and please see below my reply.
https://github.com/codeigniter4/CodeIgniter4/issues/1564#issuecomment-443483480


General about REST Services

At this time every REST request gives a 200 - most of the time - when sometimes there has been an error and it should return a status <> 200. Maybe we could follow this suggestions:
"Use HTTP Response Codes to Indicate Status" in
https://www.restapitutorial.com/lessons/restquicktips.html
also here at the end: https://www.vinaysahni.com/best-practices-for-a-pragmatic-restful-api#restful

Also it would be a good idea to inform the user of the API in detail about the problems or what he has done wrong. This can be very helpful for both sides of the API finding the error and solve the problems. Those details can be shorten in production code, means no stack trace and the like.


postcss loader should ignore the --config flag

Got a strange build error today while using a CLI that embeds postcss as a library. The CLI supports passing a --config flag, which was being read by cosmiconfig, which is used by postcss-load-config, which this module uses to load config files. I'm assuming that using the --config flag is desired for postcss-load-config, but I can't imagine a scenario where a user would expect the postcss loader for webpack to use it.
I'll submit a PR soon, but figured an issue should be created too.

Oops, looks like this was fixed in https://github.com/postcss/postcss-loader/pull/174


[Release-1.26] - K3s etcd-snapshot save logs wrong s3 bucket/folder path

Backport fix for K3s etcd-snapshot save logs wrong s3 bucket/folder path

#8925

Validated on release-1.26 branch with commit 3d70c8ad
Followed the same steps and observed the same results as mentioned here: https://github.com/k3s-io/k3s/issues/8925#issuecomment-1894765222
k3s version v1.26.12+k3s-3d70c8ad (3d70c8ad)
go version go1.20.12

Also tested on upgrades


Add a milestone/project for the next release

The last release was 0.4.0. Is there any plans to add a new milestone/project for the next release? It would be handy to see the progression of the release and the issues to be done for the release. Thank you.

Hey @mridang, next week we'll release a new version 0.5.0 - you can read about incoming changes in the changelog file.
As for the next milestones, I didn't plan it yet, because we had to switch over to a different project for some time and we're reorganizing our teams a bit. Unfortunately, that's the case for open-source projects that we're not able to work on them full-time always.
But don't worry - we have big plans about this project and in a week or two I hope I'll be able to give you a more specific update our plans :) What we wanted to focus on next is user profile page, address management, list of user's orders.

Thank you Marcin.


Subname?

I think it would be good to make clear int the application name that this is a branch of the google version.. Something like MyTracks OS or MyTracks Platypus or something

Agree.
This needs some more thinking on what would be all consequences of it; but yes, if this is meant to be published somewhere, I think it will have to be clear this is a community-based  fork of the original Google version.

You will also need to change the package name, or Android will think it's the same app as the original MyTracks. I think it's enough to change the applicationId field in build.gradle.


Should the sidebar color be modified by the Theme?

I'm comparing my Sublime Text appearance with the one you have shown in your screenshot in the README.md file.
My side-bar is still the typical Sublime Text gray. Should this have been changed by installing your theme?
I've included a screenshot for comparison purposes. It shows your screenshot next to my running instance of Sublime Text 3.

+1
missed the directive to add it to user_preferences and landed here.


Are we supposed to implement and supply our own HttpClient in NodeJS env?

Looking at DefaultHttpClient here, I see that it uses XMLHttpRequest implicitly. Is there a simpler workaround, than implementing own HttpClient?

In 1.0.0 you have to always polyfill XMLHttpRequest (or implement your own HttpClient as you pointed out). And there are two other polyfills you need for certain cases, see our npm package readme https://github.com/aspnet/SignalR/tree/dev/clients/ts/signalr#nodejs
In 1.1.0 we're looking at providing default polyfills so Node users can use the library without any extra work.

Would be great to have polyfills in place, so I vote for 1.1.0 roadmap.
Meanwhile I should confess that never pollyfilled anything in NodeJS... is there a way to declare missing objects globally, or will I need to fork the project and add appropriate imports manually?

Here's an example:
https://github.com/aspnet/SignalR-samples/blob/e5daadc2443e54b7e5fab5133bff5f1bdcbd0eb7/StockTickR/NodeClient/app.js#L3-L4
Look at the full app for package.json etc.

Had to write it down as follows to avoid errors in TypeScript.
(global as any).XMLHttpRequest = require("xmlhttprequest").XMLHttpRequest;
(global as any).WebSocket = require("websocket").w3cwebsocket;

We periodically close 'discussion' issues that have not been updated in a long period of time.
We apologize if this causes any inconvenience. We ask that if you are still encountering an issue, please log a new issue with updated information and we will investigate.


Will r.click() work when screen is sleep or locked - visually nope, web id maybe

I heard that for visual automation, it requires a logged in screen that is active, otherwise there is no display to automate visually. For normal web automation it might still work but this is not tested or part of the use case for the package.

Also tagging @uditijain

Yes visual automation does not happen when screen is locked, as for browser automation it works for a minute after a screen is locked and then this also starts giving [RPA Error]

I see.. Gotcha. Yeah this isn't a tested and planned use case for the package. Closing issue but feel free to comment more!


no 0.4.1 tag ?

hello,
I was wondering why a 0.4.1 was advertised on pypi:
https://pypi.python.org/pypi/pep257
altough no corresponding tag is available; last one is 0.3.2 from march 2014

You are right, sir. I just added the tag - you can see it at https://github.com/GreenSteam/pep257/tree/0.4.1


add docs to OnBackButtonPressed

fill <returns> and <remarks> elements
add note that the method will never be called on iOS
fixes #58

Docs Build status updates of commit 658d80e:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

docs/Xamarin.Forms/Page.xml
:white_check_mark:Succeeded

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.

Docs Build status updates of commit 332d146:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

docs/Xamarin.Forms/Page.xml
:white_check_mark:Succeeded

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.

this also fixes #200

this also fixes #96


Software Package: Improved support for usages, versions and licences

Software Package
A represenation of a software package / library

Name
Type
Description

Id
Long
Sequential identifier

Group
String
A group or namespace for this package, could double up as the publisher

Name
String
Name of the package

Description
String
Description

External Id
String
External identifier based on source of package

Created At
Timestamp
-

Created By
User Id
-

Provenance
String
Where this data point came from

Software Package Version
A listing of the licences for the software version.

Name
Type
Description

Id
Long
Sequential identifier

Software Package Id
Long
FK to Software Package

Version?
String
Version of the package (nullable to represent the unknown)

Description
String
Description

External Id
String
External identifier

Created At
Timestamp
-

Created By
User Id
-

Provenance
String
Where this data point came from

Software Package Usage
An application's usage of a software package is version specific, hence will link to this record.

Name
Type
Description

Id
Long
Sequential identifier

Application Id
Long
FK to Application

Software Version Id
Long
FK to Software Package version (a usage will always be for a specific version)

Created At
Timestamp
-

Created By
User Id
-

Provenance
String
Where this data point came from

Software Package Version Licence
A software package usually has a version,

Name
Type
Description

Id
Long
Sequential identifier

Software Version Id
Long
FK to Software Package version (a licence will always be for a specific version)

Licence Id
Long
FK to Licence

Created At
Timestamp
-

Created By
User Id
-

Provenance
String
Where this data point came from

Given the high rate of expected 'unknown' versions should we be explicit and have an unknown_version column, or are we being implicit and having usage which links to a version with a null value in version.
Also think the software package version license table may have missed a vital FK :)

updated, thanks


nixos/nix-daemon: make checkConfig fully disable nix.conf validation

Motivation for this change
I've got a special setup where the check causes issues and need an option to disable it entirely. I don't see much point in checking just for unknown settings and you wouldn't expect one to happen with checkConfig = false.
Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
22.05 Release Notes (or backporting 21.11 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[x] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module
[x] (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes

[x] Fits CONTRIBUTING.md.

I don't see much point in checking just for unknown settings

https://github.com/NixOS/nixpkgs/blob/9363ec256daa0e2b1e51ff124c27e96156d9837c/nixos/modules/services/misc/nix-daemon.nix#L74-L75
It is unforeseeable how errors will be categorized in new Nix versions so the error and warning categories are combined in the validation. The check for "error: unknown settings" is done because the Nix binary does not unambiguously distinguish between syntax errors and invalid data. It was chosen to match the module system behavior when undeclared options are used in the config.
In addition, the "unknown settings" warning is deterministic which is important for debugging as the Nix module is invariably blocking.
I do acknowledge that it is sometimes necessary to disable the validation phase completely and the Nix module currently does not provide this compatibility.

you wouldn't expect one to happen with checkConfig = false.

You are right, I overlooked this on my part. The name of the option is misleading and does not convey what it actually does. I think it can be rewritten as ternary state enum(full, minimal, none) or something similar to reflect its real scope. What do you think?

Sorry for getting back so late. What do you think of this @polykernel?

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:
https://discourse.nixos.org/t/prs-already-reviewed/2617/621

Thanks!


Duplicate reactions in Antimony should generate errors

If you have two reactions with the same ID, e.g.
J0: A -> B; 1
J0: B -> C; 1

then the loada function will happily drop one of the reactions and run the model without errors. The output will be garbage, of course. This case should generate an error. I don't know if Antimony already posts an error which is ignored by the wrapper, hence I'm posting it here.

Because of the way elements from submodels can be replaced, Antimony will
always let you redefine a previously-defined element, even within the same
model.  If you say
p1 = 1
p1 = 2
then p1 will equal 2.  This is so that you can load a submodel, and then
change the values:
A: submod1(p1, p2, p3)
p1  = 2
Whatever p1 was equal to originally, it is now equal to 2.  You can do this
with reactions or with any named element, which results in the unfortunate
situation you found, but I never found a satisfactory way to distinguish
between legitimate redefinitions and accidental redefinitions.
-Lucian
On Tue, Aug 16, 2016 at 11:44 AM, Kyle Medley<EMAIL_ADDRESS>wrote:

If you have two reactions with the same ID, e.g.
J0: A -> B; 1
J0: B -> C; 1
then the loada function will happily drop one of the reactions and run
the model without errors. The output will be garbage, of course. This case
should generate an error. I don't know if Antimony already posts an error
which is ignored by the wrapper, hence I'm posting it here.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/sys-bio/tellurium/issues/129, or mute the thread
https://github.com/notifications/unsubscribe-auth/ABp91k6mZOGRcABpNnhRDd0-iSgrVqhDks5qggUEgaJpZM4JluZU
.

This is an antimony issue / model definition issue and not part of tellurium.
In my opinion expected and correct behavior.
Closing this here.


5.13 OOB - "TLS porting guide" link is broken

The "TLS porting guide" https://os.mbed.com/docs/latest/reference/mbed-tls-entropy.html link forwards the user to https://os.mbed.com/docs/mbed-os/v5.12/reference/index.html.

ARM Internal Ref: ONME-4361


Socket Connection drops when ad is played

I am trying to use rewardedVideo with socketio. When the ad is played on android, the socket connection drops. Works fine with IOS.
Is this expected? Is there a known workaround?

I'm not sure how you're using socketio? If you still have this problem, please elaborate a bit, preferably with some code samples, and I'll be happy to reopen.


controller.clearFocus() does not seem to work on iOS

Not sure if this specific aspect has been addressed in other issues...
The keyboard is still visible and onBlur() callback does not get called.
No console output in IDEA to report any issues.
Works on Android though.
What additional details can I provide, or what additional settings can I apply for this to work?

Are you testing this on a physical device or simulator?

Simulator of iPhone 13, running iOS 15.0, with "Connect Hardware Keyboard" switched off.

Has been reported by QA on physical devices as well.

Hi, has the problem been solved?

Apologies, I haven't had much time this month - I have finals at school and then will be travelling out of state for a new job. Hopefully I will be able to take a look at this soon.

Hi @tneotia, hope you're having a good day. I am facing a similar issue where clearFocus does not work in iOS, could you please check this?

Hi @tneotia, can you place check this issue
Thank you so much.

Hi @tneotia please check the issue

Create a new class, extends the controller, and create this method:
Future<void> hideKeyboard() async {     const js = """     (function() {       document.activeElement.blur();       return true;     })();     """;     await _evaluateJavascript(source: js);   }


Constraint Detection Add-on throws an errorHel

Hello,
We are getting this error message with some workbooks when trying to use the Constraint Add-on: "_**RuntimeError: Due to a SPy issue the add-on can only be executed if you are the workbook owner.
The owner of this workbook is John DOE.
Error found at line 2 in cell 2.**_"
Could you please help?
Best regards,
Sofiane

Hello,
Any updates on this please?
Best regards,
Sofiane

Hello,
sorry for the late response. SPy is the Seeq Python library which is used in the code of the constraint detection add-on. There is an issue within SPy which makes it difficult to create/manipulate asset trees if you are not the workbook owner. Therefore, you can (unfortunately) only use the the add-on if you are working in a workbook that you created yourself. In this case, your colleague John seems to be the workbook owner and John has probably given you access to his workbook. I would recommend that you create a new workbook for yourself, so that you can use the add-on. I hope this helps you out!
Best regards,
Lea


allow_non_nested_indentation not working correctly

It works only for non nested class but everything else within it is being reported as error for not being indented correctly.
Please see screenshot here (Sublime3, OS X).

I'm seeing this too.

I have the same issue as @nenadjelovac.

Fixed by 53494a8.

Excellent! Do you know when this will be released?
On Fri, Mar 20, 2015, 2:07 AM Shane da Silva<EMAIL_ADDRESS>wrote:

Fixed by 53494a8
https://github.com/causes/scss-lint/commit/53494a8d9db54c468f8ef68ec5bac2f1202e2fb7
.
—
Reply to this email directly or view it on GitHub
https://github.com/causes/scss-lint/issues/374#issuecomment-83922814.

Version 0.35.0 includes this fix.


fix minor typo in configure-runasusername.md

no right parenthesis in three parts.
I just directly made PR from https://kubernetes.io/docs/tasks/configure-pod-container/configure-runasusername/
using Edit this page link.

/kind cleanup

Page preview:
https://deploy-preview-28097--kubernetes-io-master-staging.netlify.app/docs/tasks/configure-pod-container/configure-runasusername/

Thanks @jmyung .
/lgtm

/approve


Combination of single and range

I need a date picker that supports single and range dates combined. Just like this one: https://www.uitinvlaanderen.be (click "Datum" to see it).
What happens there is that you click on a single date and it accepts it as such.
Vue-datepicker (which is an excellent plugin btw) expects a range immediately. If you want to select only a single date, you have to click that date twice to select a range of only 1 day.
For a user, that's very confusing.
I'm using the date picker inline with autoApply.
I thought partial-range would do this, but it doesn't seem to work the way I think it would.
Current solution
I don't use the actual v-model variable for this, but I created two others: dateFrom and dateTo.
Than I leverage the @internalModelChange which calls this function:
const updateDates = value => {
    // Reset dates
    dateFrom.value = null;
    dateTo.value = null;

    // Set dates
   if (value) {
        dateFrom.value = value[0];
        if (value[1]) dateTo.value = value[1];
    }
}

This way I always have the correct dates (if one or two are selected).
Then it's just styling. I remove the styling from the dp__range_between class so the user doesn't see that he's actually picking a range. And I add that styling back by ddding :class="{'has-range': dateFrom && dateTo}" to the datePicker and styling .has-range. dp__range_between.
But it would be nice if this could be baked into the plugin.

Adding to this we should be able to clear the internalModelValue property too.
If we select a single date while the datePicker is set to range, the internalModelValue has a value and the picked date is still highlighted. But the actual v-model of the datePicker remains empty if you don't select a second date.
So everything is cleared but the datePicker still shows a selected date.


More expressive shortcut name

[a-zA-Z]+ cannot express some IDs, which are likely to be normal, such as foo_goo, foo-goo, foo', foo1, #foo, etc.

dc36b8215802e5dda6eec822d40cbd9db6cc219e


Split Razor template in several smaller pieces

The TypeGeneration.tt file is very big and will cause unnecessary merge conflicts unless it is split up into pieces.
I suggest the following organization into separate files:

The Storage subclass (btw, it shouldn't need qualification, since it's a nested class).
The basics -- constructors, ToString(), indexer, HType subclass, accessors, various static factories, etc.
Copy and Fill operations.
Tensor manipulation -- resize, transpose, etc.
Element-wise operations, unary operators.
Linear algebra operators

Sounds good to me. I suggest to put 2 and 3 together though.

This sounds like a band aid for the root of the problem.
We probably should sort out not generating the file, and using the NuGet from Mikayla to generate the file.

@migueldeicaza, I'm not sure I understand your proposal. Could you elaborate?

@NiklasGustafsson I agree. In fact, I am trying to follow that logic in my recent PR #57 - I keep all DllImport mappings in the TorchSharp/Raw/ folder, and will define the high-level operations separately. We can do teh same to THTorch_* mappings etc.
P.S. @migueldeicaza I am not sure I can understand it either..
(Meanwhile, I have three PRs ready for issues #21 #22 #23 all using TT) :)

The desire to split this is rooted on the generated file and the conflicts with PR, so what I would rather do is fix the generation of the file than split the file.   It is a tiny file.

Closing, see https://github.com/xamarin/TorchSharp/pull/129


path for android SDK

Hi with the new version of android studio 3.6.3 (on a mac) the path for built in SDK package doesn't include the folder "tools" :
/Users/john/Library/Android/sdk/cmdline-tools/latest/bin/sdkmanager
Is there a way to update the AndroidSdkTools.ts file in order to reflect this change:
/**
   * Installs the build tools into the the Android SDK. Equivalent to running
   *
   * `tools/bin/sdkmanager --install "build-tools;29.0.2"`
   */
  async installBuildTools(): Promise<void> {
    const env = this.getEnv();

    console.log('Installing Build Tools');
    await util.execInteractive(
        /*this.pathJoin(this.getAndroidHome(), '/tools/bin/sdkmanager'),*/
        this.pathJoin(this.getAndroidHome(), '/bin/sdkmanager'),
        ['--install',
          `"build-tools;${BUILD_TOOLS_VERSION}"`],
        env,
    );
  }

It may be easier if the user already have Android Studio with SDK on his machine
Thanks for your help

The trick to make it works is to use the old version of the SDK like describe in this page : https://flutter.dev/docs/get-started/install/macos#install-android-studio

You should also be able to download the command-line tools only, unzip into a different folder and use that one: https://github.com/GoogleChromeLabs/bubblewrap/tree/master/packages/cli#get-the-android-command-line-tools


[Documentation] How to filter pipelines

Release Note Category

[ ] Feature changes/additions
[ ] Bug fixes
[ ] Internal Infrastructure Improvements

Release Note Description

PR: https://github.com/dotnet/arcade/pull/14378

PR of template: https://github.com/dotnet/arcade/pull/14386


Add support for analytics with Angulartics2.

Includes full support and examples for Google Analytics provider (for other providers, only the npm package and module import are done).
Documentation is coming :soon:

Nice, UT are working now 👍


KAFKA-16210: Update jose4j to 0.9.4

Committer Checklist (excluded from commit message)

[ ] Verify design and implementation
[ ] Verify test coverage and CI build status
[ ] Verify documentation (including upgrade notes)

org.bitbucket.b_c:jose4j 0.9.3 is susceptible to Denial of Service per CVE-2023-51775.
This PR updates kafka to use 0.9.4.
Thank you

the CI tests that are failing are unrelated since they don't use SASL (which is impacted by this dependency)

backported to 3.7


Fixed error in fastai in nightly

Description

@SimonYansenZhao there is an error when we execute the GPU nightly. See https://github.com/recommenders-team/recommenders/actions/runs/8031843379/job/21940593196
This will fix the error, but not sure if we have more.
Related Issues

References

Checklist:

[ ] I have followed the contribution guidelines and code style for this project.
[ ] I have added tests covering my contributions.
[ ] I have updated the documentation accordingly.
[ ] I have signed the commits, e.g. git commit -s -m "your commit message".
[ ] This PR is being made to staging branch AND NOT TO main branch.

fastai v2 has changed a lot, so I think there may be more errors 😂


Menubar material

Addressing issue #1059.
Designed the Editor UI using material and CSS
https://user-images.githubusercontent.com/40212568/124360378-118a5800-dc47-11eb-94a1-6b091593d7bc.mp4

Hey @AbhipsaGuru1012, I have added your recommended changes.

Double-clicking it goes away. So try resolving that cause if the user sets something and clicks it again it shouldn't go away.

Actually, I have made it so that the user could toggle through it. The user is supposed to click the option once in order to get the option to set values. If you want the option to remain after a single click then no problem, I can add so.

This should not overlap.
When I assigned the issue, I expected a redesign of the complete menubar and not replacement of certain text with material icons

Hey, @smaranjitghose, I see you have closed the pull request, I can still customize the layout if you want and the overlap issue if you are accepting the pull request.


Recover binary search tree

Coverage remained the same at 100.0% when pulling fb2b82fbab5f85c7528110aca9374b6250bcd4a2 on recover-binary-search-tree into 010e411af911141f3cf627a92d4b5d3c7ea4dba4 on master.


Update UploadersRepository.php

Preventing php artisan optimize issues from not working when config cannot be found.
WHY
BEFORE - What was wrong? What was happening before this PR?
Locally everything works but on development server deployments are not possible because the pipeline gets blocked not able to load the uploaders array. Even if it is present and file has read permission.
AFTER - What is happening after this PR?
checking if config is available otherwise fallback on empty array.
Is it a breaking change?
Only for me
How can we test the before & after?
think not needed with this simple code

Hello @teunes1 thanks for you PR i will ask @pxpm to check it.
Thanks again.
Cheers.

Not sure what the issues was that caused my error in the first place. But doing the composer update on the dev server made it work. Now the pipeline does work as well.
So the core issues was probably with rsync on my end.
Just writing this if everyone else does get this problem.

Thanks for getting back with the answer @teunes1 and for the PR 🙏
I am closing this since it seems you fixed the issue. Please let us know if you find other issues or have any suggestions.
Cheers


Execs should not run every time

The gpg key imports should not run every time that the puppet configuration is applied. They should run only if the key doesn't exist in the keychain.

Thanks for filing this issue. yum will only import a key a single time per repository key chain, so I'm going to close this issue. Let me know if this is causing a problem and I'll be happy to try to think of some alternatives.

Apt does not. It reimports the key every time, which polutes the logs. The apt and yumrepo modules correctly manage this. Because #11 was closed, it seems the wheel needs to be reinvented to solve this, for apt-based distributions at least.

Can you please paste the logs you are referring to @t0xicCode ? I just tried importing the same key multiple times with apt-key and it is imported only once.
apt is incredibly buggy, so I would believe that it fails on other distributions/other versions.


Avoid missing include directory warnings

Only c2000 even uses this include path anymore, so we can remove it for everything else.
Closes #1784

coverage: 99.279%. remained the same
when pulling e45a16d1d2d0780f7087f8d682fe698b6f64627c on thetic:missing-include-dirs
into 49bae1944af67053f7560df3e99cbefc3e120b83 on cpputest:master.

Thanks (again)!


TypeScript rewrite

Nothing too crazy (like a function→class conversion). Just annotated with types, replaced var with let/const, moved to arrow functions, and switched to the new ES6 export syntax.
BTW: With arrow functions I think we can remove all the binds also.

@kornelski Decided to do the crazy function→class conversion.

This is a massive change, not only in the code, but also in the way it's used.
It's nice to see the code mostly works fine with strict(er) types. However, it also has some quirky bits in the state machine that are taking advantage of class-less ad-hoc nature of JS, so some places got nicer, some got less nice.
There are some small wins in syntax, but many of them are also in ES6.
I like TS in general, but I'm not sure if it brings enough to this codebase to be worth the churn and addition of compilation step.

My reasoning for the rewrite was that all the frontend frameworks I use—e.g.: Angular—are developed in TypeScript. Sure, I could write a tiny .d.ts for it, but I decided to go full throttle and rewrite.
Yeah, decided to use class expressions for your quirky state machine.
You can also change the target in the tsconfig.json to emit es6.
As for the advantages of TypeScript, generally it is easier to maintain due to:

[explicit] type safety, via annotations (including interfaces)
code completion (just choose an IDE that supports it)
compile-time errors & tracing
emit for different JavaScript versions
improved minification

(to name just a few… here's Ionic's list)

@kornelski Aww you closed this after 2.5 years
Still keen to get a TS rewrite of your library accepted…

Well, nothing has changed since. It's still a small library. Survived without types so far.


V1.3.x

Highlights:

#50 Add threadmarks from quick reply/reply
#51 Implement require extendability for Word Count support
Expose threadmark cache rebuild to the rebuild cache page
Reduce data fetching on threads with no threadmarks
Fix displaying post user avatar on threadmark preview.
Update jsTree library

@sidane I've had this v1.3.0 deployed on my sites for 1-2 weeks for testing most of the functionality, and this exact release for the last 4-5 days without an issue.
Could you release this? I'll then release Word Count v1.1.0 which supports adding wordcounts to bits of threadmarks

v1.3.0 released on XenForo.com @Xon.
I noticed CHANGELOG.md hasn't been updated since v1.1.5. I think it's worth keeping that up to date or removing it if you don't intend to maintain it.

Updated the changelog. I've got some more changes coming down the pipeline but I'll probably release those next year.


Implement Modify-Date and delivery if modified since of static content

Optimize content delivery for static content.

Done by the deploy subsystem.


implement premium plan

and move all ci instances to proper subaccount

https://github.com/cap-js/audit-logging/pull/61


ios the video player has sound but no image

Is there more detailed information?
On my iPod touch, no problem.


pkt_switch example suggestions

We found several possible problems in the pkt_switch routine under the example folder. Here are my suggestions.
First, in the fifo.cpp file, the pkt_out method lacks the logic to reset the "full", which results in no more data being read after the fifo is full.
Second, in Line 204, 210, 216 in the switch.cpp file, the judgment condition of R1.free, R2.free, R3.free is wrong, which causes some data packets to be lost too early.

Hi, thanks for your contribution, would you mind adding a brief description to the commit message and a signed-of-by line, with your affiliation.
For your contribution to be applicable for consideration by the Accellera working groups, you need to sign-off the Accellera Developer's Certificate of Origin as described in the CONTRIBUTING file.
Thanks

Thanks for the kindly reminder. But I'm not very familiar with Github. I don't know how to add the signed-off-by line. Should I Close this Pull Request and Create a new Pull Request or should I use a local IDE to do it? Thank you very much again.

You just need to amend the commit.
Thanks

I amended my commit to add a signed-off-by line. Did I do it correctly? Thank you.

Hi, I just added the title line and added more details to the commit message. Does it look appropriate now? Thank you.


[SMALLFIX] Update close of RemoteBlockOutStram

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins/job/Tachyon-Pull-Request-Builder/6044/
Test PASSed.

LGTM


Clarify how configuration and rules are deployed

to:
cc: @airbnb/rudolph-maintainers
Background
Context for the change
Changes

Summary of changes
...

Testing
Steps for how this change was tested and verified

Thanks for the updates!


Hid checkbox labels

Fixes #322.
-Hid redundant labels using “sr-only” class.
-The checkbox ended up where the label used to be so I added a class of
“checkbox-label-space” that can be used where that comes into play.
gif:
http://recordit.co/qtt0q8Xwt7
cc @HospitalRun/core-maintainers

@jglovier look good to you?

@jglovier Merge?

@jscottchapman thanks for the PR.  I am going to merge it in.


Removes tests during an unholy ignite.

For Unholy, we use ava currently.  This deletes that __tests__ directory.
If we do switch to jest it won't be before 2.0 launches.
Fixes #724

I merged in the wrong direction and broke your shiiiii
:( I'm sorry

Np!  All good.  Surprised that git got caught with whitespace there to be honest.


Fix references to pNext structs

CI gfxreconstruct build queued with queue ID 286064.

CI gfxreconstruct build # 5173 running.

CI gfxreconstruct build queued with queue ID 286084.

CI gfxreconstruct build # 5174 running.

CI gfxreconstruct build # 5174 failed.

CI gfxreconstruct build queued with queue ID 290966.

CI gfxreconstruct build # 5236 running.

CI gfxreconstruct build # 5236 passed.


Showcase Submission for challenges/179-wolfram-ca

Thank you Koei Ural for your contribution! A member of the Coding Train team will review it shortly.

N-color Wolfram CA with totalistic rule
Koei Ural

Love the colors!!


fix(say): unknown interaction

Unknown interaction due to mishandling of events

:tada: This PR is included in version 9.9.5 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


Indexing referenced mongodb documents

I have my documents like this -
{
_id:ObjectId("56c35a782abeaed0564edfa9"),
//other fields
...
..
field:ObjectId("56c359fa2abeaed0564edfa8") //reference field of doc of another collection in this doc
}
So is it possible to index the fields of the referenced document?

Hi,
Unfortunately there is no way to do what you are asking. Mongo-Connector does not do joins.


Automatically test generated scala template

See #52 , this should've been caught automatically

This is covered by running and testing the example project in #15


webpack-prod vs webpack-dev

those 2 tasks are completely the same in gulpfile
https://github.com/schovi/webpack-chrome-extension/blob/master/gulpfile.babel.js#L37-L39
https://github.com/schovi/webpack-chrome-extension/blob/master/gulpfile.babel.js#L45-L47

One have true as first argument for function configGenerator  and another false :)

Ohhhh, too many hours in front of monitor. :-)
Sorry about that


Add documentation for advanced property migration

Rough draft - I'm sure there needs to be a link in some TOC somewhere.

@AndrewGaspar,
Thanks for your contribution as a Microsoft full-time employee or intern. You do not need to sign a CLA.
Thanks,
Microsoft Pull Request Bot

@windows-driver-content I'm working on this PR out-of-band with Andrew

Thanks for the PR, @AndrewGaspar this update is now live at https://msdn.microsoft.com/en-us/windows/hardware/drivers/network/specifying-configuration-parameters-for-the-advanced-properties-page (note up top)


Running docker command doesn't work

Steps to reproduce:
1)Add a SSH Sampler for localhost
2)Give the credentials in the sampler and in the command give the following command-->docker ps
3)Run the Test Plan
I get the following error:

=== stdin ===
=== stderr ===
bash: docker: command not found

But when I run other command like date,it works fine .Also when I run the docker command from the shell manually.It works fine.

Closing for inactivity


feat: AU-2548: Added new AD-group <-> Drupal role mappings.

AU-2548
What was done
This pull request implements a few new AD-group <-> Drupal role mappings according to the instructions in the ticket. It also implements AD-group <-> INDUSTRY mappings according to the AD-group names.
Other fixes
Fixed and issue in grants_metadata.module where no users other than the ones with the grants_admin role could edit anything on a Webforms third-party settings page.
How to install
Make sure your instance is up and running on correct branch.

git checkout feature/AU-2544-new-ad-group-drupal-role-mappings
make fresh
make drush-cr

How to test

[ ] Check that the new AD-group <-> Drupal role mappings are set according to this.
[ ] Check that the new AD-group <-> INDUSTRY mappings are set according to this.
[ ] Check that the roles grant_producer and grant_producer_industry can access the correct settings on Webforms.
[ ] Take this to the staging environment and let Tero / Pirjo test it.

Korjattu PHPCS virheet.

Jätän tän vielä @jiisuominen katottavaks niin, että pysyy kärryillä näistäkin asioista kun me muut ollaan poissa.


Switch getMetadata to "/" format

getMetadate should support "/" VSSPaths

There also is the question how to implement it, in VISS2 it is mangled with the overcomplex "filter" semantic https://raw.githack.com/w3c/automotive/gh-pages/spec/VISSv2_Transport.html#wss-service-discovery-read which we will definitely not support on kuksa.val  level.
However, it might make sense to use the get call and only parse for this filter specifically. It is ugly, but could be hidden by the viss client library, and would be standard compliant

I will close this issue and opend a new issue for the filter issues: https://github.com/eclipse/kuksa.val/issues/188


[Bug]: API response for a system with two UPS seems to be mixing the two.

Describe the bug
API response showing info about first UPS in the node for the second UPS. The second UPS is a Smart-UPS C 1500, but it shows a few lines referencing the first one: UPS-APC-Back-UPS-ES-750G
Debug Output
[
    {
        "battery.charge": "100",
        "battery.charge.low": "10",
        "battery.charge.warning": "50",
        "battery.date": "2001/09/25",
        "battery.mfr.date": "2012/03/05",
        "battery.runtime": "35550",
        "battery.runtime.low": "120",
        "battery.type": "PbAc",
        "battery.voltage": "13.6",
        "battery.voltage.nominal": "12.0",
        "device.mfr": "American Power Conversion",
        "device.model": "Back-UPS ES 750G",
        "device.serial": "4B1210P05924  ",
        "device.type": "ups",
        "driver.name": "usbhid-ups",
        "driver.parameter.pollfreq": "30",
        "driver.parameter.pollinterval": "1",
        "driver.parameter.port": "auto",
        "driver.parameter.productid": "0002",
        "driver.parameter.serial": "4B1210P05924",
        "driver.parameter.synchronous": "no",
        "driver.parameter.vendorid": "051D",
        "driver.version": "2.7.4",
        "driver.version.data": "APC HID 0.96",
        "driver.version.internal": "0.41",
        "input.sensitivity": "medium",
        "input.transfer.high": "139",
        "input.transfer.low": "92",
        "input.transfer.reason": "input voltage out of range",
        "input.voltage": "121.0",
        "input.voltage.nominal": "120",
        "ups.beeper.status": "enabled",
        "ups.delay.shutdown": "20",
        "ups.firmware": "841.I4 .D",
        "ups.firmware.aux": "I4 ",
        "ups.load": "0",
        "ups.mfr": "American Power Conversion",
        "ups.mfr.date": "2012/03/05",
        "ups.model": "Back-UPS ES 750G",
        "ups.productid": "0002",
        "ups.realpower.nominal": "450",
        "ups.serial": "4B1210P05924  ",
        "ups.status": "OL",
        "ups.test.result": "No test initiated",
        "ups.timer.reboot": "0",
        "ups.timer.shutdown": "-1",
        "ups.vendorid": "051d",
        "BEGIN": "LIST VAR ups",
        "VAR": "ups device.serial 3S1623X01067"
    },
    {
        "BEGIN": "LIST VAR UPS-APC-Back-UPS-ES-750G",
        "VAR": "UPS-APC-Back-UPS-ES-750G ups.vendorid 051d",
        "END": "LIST VAR UPS-APC-Back-UPS-ES-750G",
        "": "",
        "battery.charge": "100",
        "battery.charge.low": "10",
        "battery.charge.warning": "50",
        "battery.runtime": "2100",
        "battery.runtime.low": "120",
        "battery.type": "PbAc",
        "battery.voltage": "27.3",
        "battery.voltage.nominal": "24.0",
        "device.mfr": "American Power Conversion ",
        "device.model": "Smart-UPS C 1500",
        "device.serial": "3S1623X01067  ",
        "device.type": "ups",
        "driver.name": "usbhid-ups",
        "driver.parameter.pollfreq": "30",
        "driver.parameter.pollinterval": "1",
        "driver.parameter.port": "auto",
        "driver.parameter.productid": "0003",
        "driver.parameter.synchronous": "no",
        "driver.parameter.vendorid": "051D",
        "driver.version": "2.7.4",
        "driver.version.data": "APC HID 0.96",
        "driver.version.internal": "0.41",
        "ups.beeper.status": "disabled",
        "ups.delay.shutdown": "20",
        "ups.firmware": "UPS 10.0 / ID=1005",
        "ups.mfr": "American Power Conversion ",
        "ups.mfr.date": "2016/06/07",
        "ups.model": "Smart-UPS C 1500",
        "ups.productid": "0003",
        "ups.serial": "3S1623X01067  ",
        "ups.status": "OL",
        "ups.timer.reboot": "-1",
        "ups.timer.shutdown": "-1",
        "ups.vendorid": "051d"
    }
]

Steps to reproduce

Device Type
Intel NUC
UPS Device
usbhid-ups
Last Working Version
No response

Yep. Seems like a parsing error. I just published a new test version. You can try it by adding the :test tag. (brandawg93/peanut:test). Try it and let me know if that fixes it for you!

Just tried with :test and still seems like an issue persists. Here's a gif of me refreshing the page (see line 50 in the gif)... And also screencap of the extra params visible in the UI.

Can you tell me what the nut upsd server says the name of the ups is?
You should be able to telnet into the server and run LIST UPS.

Ok. I've reworked the parsing algorithm and published :test again. Let me know if it works now.

Issue appears to persist:

Here's what I get via running 'upsc {name}@localhost' on the host (RPi)
pi@rpi0:~ $ upsc UPS-APC-Back-UPS-ES-750G@localhost
Init SSL without certificate database
battery.charge: 100
battery.charge.low: 10
battery.charge.warning: 50
battery.date: 2001/09/25
battery.mfr.date: 2012/03/05
battery.runtime: 35550
battery.runtime.low: 120
battery.type: PbAc
battery.voltage: 13.6
battery.voltage.nominal: 12.0
device.mfr: American Power Conversion
device.model: Back-UPS ES 750G
device.serial: 4B1210P05924
device.type: ups
driver.name: usbhid-ups
driver.parameter.pollfreq: 30
driver.parameter.pollinterval: 1
driver.parameter.port: auto
driver.parameter.productid: 0002
driver.parameter.serial: 4B1210P05924
driver.parameter.synchronous: no
driver.parameter.vendorid: 051D
driver.version: 2.7.4
driver.version.data: APC HID 0.96
driver.version.internal: 0.41
input.sensitivity: medium
input.transfer.high: 139
input.transfer.low: 92
input.transfer.reason: input voltage out of range
input.voltage: 120.0
input.voltage.nominal: 120
ups.beeper.status: enabled
ups.delay.shutdown: 20
ups.firmware: 841.I4 .D
ups.firmware.aux: I4
ups.load: 0
ups.mfr: American Power Conversion
ups.mfr.date: 2012/03/05
ups.model: Back-UPS ES 750G
ups.productid: 0002
ups.realpower.nominal: 450
ups.serial: 4B1210P05924
ups.status: OL
ups.test.result: No test initiated
ups.timer.reboot: 0
ups.timer.shutdown: -1
ups.vendorid: 051d

pi@rpi0:~ $ upsc ups@localhost
Init SSL without certificate database
battery.charge: 100
battery.charge.low: 10
battery.charge.warning: 50
battery.runtime: 2100
battery.runtime.low: 120
battery.type: PbAc
battery.voltage: 27.3
battery.voltage.nominal: 24.0
device.mfr: American Power Conversion
device.model: Smart-UPS C 1500
device.serial: 3S1623X01067
device.type: ups
driver.name: usbhid-ups
driver.parameter.pollfreq: 30
driver.parameter.pollinterval: 1
driver.parameter.port: auto
driver.parameter.productid: 0003
driver.parameter.synchronous: no
driver.parameter.vendorid: 051D
driver.version: 2.7.4
driver.version.data: APC HID 0.96
driver.version.internal: 0.41
ups.beeper.status: disabled
ups.delay.shutdown: 20
ups.firmware: UPS 10.0 / ID=1005
ups.mfr: American Power Conversion
ups.mfr.date: 2016/06/07
ups.model: Smart-UPS C 1500
ups.productid: 0003
ups.serial: 3S1623X01067
ups.status: OL
ups.timer.reboot: -1
ups.timer.shutdown: -1
ups.vendorid: 051d

It's really odd that it changes. The parsing should be the same every time and it explicitly removes VAR from every line.
Could you try using telnet directly and see what you get?
And thanks again for troubleshooting this with me!

Ok. I've pushed another test. This one replaces ALL occurrences of VAR. Let's see what that does.

Thanks for attempting the fix! Hmm... Same issue...  Can you elaborate on where you'd like me to telnet? I use SSH to connect to the raspberry pi running the NUT server. Happy to run whatever commands would be helpful.
In case it helps, this is the output from pi@rpi0:~ $ sudo cat /etc/nut/ups.conf
[UPS-APC-Back-UPS-ES-750G]
    driver = usbhid-ups
    port = auto
    desc = "APC Back-UPS ES 750G"
    vendorid = 051D
    productid = 0002
    serial = 4B1210P05924

[ups]
    driver = usbhid-ups
    port = auto
    desc = "APC Smart-UPS C 1500"
    vendorid = 051D
    productid = 0003

Greetings from just north of Boston, by the way.

Greetings fellow Bostonian!
You can telnet directly into the NUT server by doing something like telnet localhost 3493 replacing the relevant hostname and port. This is how peanut gets its information.
You could also clone this repo and add a few console.logs as well.
My theory is that you will get the same changing info directly from the server. If that's the case, I'm not sure what else could be done to fix it.

I'll see if I can figure that out... And just as a data point, for what it's worth, I am also using this web UI, and it does not experience the same issue. Perhaps the method is different there... https://github.com/teknologist/docker-webnut

Yep. That uses nut2 under the hood. Ok. I've modified the parsing to be EXACTLY like it and made another test. 🤞

I know what it is! The peanut was requesting ups data asynchronously so the two devices were mixing lines. New test is ready!

Getting a 500 with some errors in the logs of the container.
   ▲ Next.js 14.0.4
   - Local:        http://7a6fd986e243:8080
   - Network:      http://<IP_ADDRESS>:8080
 ✓ Ready in 118ms
 ⨯ Error: Invalid response
    at n.getData (/.next/server/app/api/v1/devices/route.js:3:10)
    at process.processTicksAndRejections (node:internal/process/task_queues:95:5)
    at async l (/.next/server/app/api/v1/devices/route.js:1:755)
    at async /node_modules/.pnpm/next@14.0.4_@babel+core@7.23.6_react-dom@18.2.0_react@18.2.0/node_modules/next/dist/compiled/next-server/app-route.runtime.prod.js:6:41960
 ⨯ Error: Invalid response
    at n.getData (/.next/server/app/api/v1/devices/route.js:3:10)
    at process.processTicksAndRejections (node:internal/process/task_queues:95:5)
    at async l (/.next/server/app/api/v1/devices/route.js:1:755)
    at async /node_modules/.pnpm/next@14.0.4_@babel+core@7.23.6_react-dom@18.2.0_react@18.2.0/node_modules/next/dist/compiled/next-server/app-route.runtime.prod.js:6:41960
 ⨯ Error: Invalid response
    at n.getData (/.next/server/app/api/v1/devices/route.js:3:10)
    at process.processTicksAndRejections (node:internal/process/task_queues:95:5)
    at async l (/.next/server/app/api/v1/devices/route.js:1:755)
    at async /node_modules/.pnpm/next@14.0.4_@babel+core@7.23.6_react-dom@18.2.0_react@18.2.0/node_modules/next/dist/compiled/next-server/app-route.runtime.prod.js:6:41960
 ⨯ Error: Invalid response
    at n.getData (/.next/server/app/api/v1/devices/route.js:3:10)
    at process.processTicksAndRejections (node:internal/process/task_queues:95:5)
    at async l (/.next/server/app/api/v1/devices/route.js:1:755)
    at async /node_modules/.pnpm/next@14.0.4_@babel+core@7.23.6_react-dom@18.2.0_react@18.2.0/node_modules/next/dist/compiled/next-server/app-route.runtime.prod.js:6:41960
 ⨯ Error: Invalid response
    at n.getData (/.next/server/app/api/v1/devices/route.js:3:10)
    at process.processTicksAndRejections (node:internal/process/task_queues:95:5)
    at async l (/.next/server/app/api/v1/devices/route.js:1:755)
    at async /node_modules/.pnpm/next@14.0.4_@babel+core@7.23.6_react-dom@18.2.0_react@18.2.0/node_modules/next/dist/compiled/next-server/app-route.runtime.prod.js:6:41960

Hmm. Ok. I've pushed a new test and this time I put lots of console.logs in it. I also disabled the validation so it shouldn't throw that error. We must be getting close!

I was finally able to add dummy ups devices to my personal server. I found the issue and fixed it. Latest test works!

Confirmed fixed!


Dialog js files are missing

I cannot seem to find those two javascript files ( Jquery.Dialog.js & Dialog.js ) that are required for the dialog to be available anywhere in the project
once the build is done, I believe they should exist in this directory

Hey @anasnakawa , this is because of https://github.com/OfficeDev/Office-UI-Fabric/issues/67. Basically, the template used for component demo HTML pages always has a reference to .js and Jquery..js, even if those don't exist. We're working on a fix for this that should be ready soon; I'll close the issue for now since the work for it is already being tracked. Thanks for catching this!

thanks,
but beside that demo pages issue,
the Dialog javascript files mentioned above are not available anywhere in the repository.

Ah, I see, I must have misunderstood. There actually have never been JS for Dialog--the references above are a bit misleading in that sense--but would it be fair to say the issue is that there should be? I could see us including JS to demo how to open/close specific dialogs.

the references above are a bit misleading in that sense

yes they are, and they are not the only thing misleading here,
also the example provided in the same demo page for the dialog is confusing me,
like when I tried to include the whole Fabric UI javascript library,
I cannot seem to find any definition for the following:
fabric['Dialog']; // undefined
$.fn.Dialog; // undefined

Is there any part that I am missing here ?
Thanks.

Nope, I think you've got it. This sounds like what the issue in https://github.com/OfficeDev/Office-UI-Fabric/issues/67 is describing. The problem is that those demo files are generated automatically from a template, and that template includes hard-coded references to component scripts, even if those files don't exist, since not every component has or requires JS to work. You'll notice the same issue for List, ListItem, Callout, and a few others in addition to Dialog.
We know this is pretty confusing, so we'll make sure to update the build & template to only include references to JS files if they exist.
Does this help?

Is it possible you are able to proivide an example of how to open/close a dialog?
Regards

Could you please provide an example of how to open/close a dialog?

Reopening so we can track it.

The Dialog has an overlay, but we don't provide sample JavaScript to show how the dialog can be opened and dismissed. This should be added so that we can help developers use it, and to document the animations.

Turns out there is a demonstration of this (screenshot below) in the samples that are distributed with Fabric. If you download Fabric you'll find it under dist/samples/Components/Dialog/index.html.
Can we get these examples working on the dialog page of our main documentation site?

This should be fixed when we update the documentation site to pull the latest components from Fabric. Leaving this issue open to ensure it gets fixed.

It's working on the docs site now: http://dev.office.com/fabric/components/dialog
You can click the JS tab to see the Javascript in use to open and close the dialog.


Increase minimum Python version to 3.5.3

Closes #3089

As far as I can tell, @shoyer's review has been addressed. Sprinters at scipy would like to have this, so I'm going to merge.


Added property to Route interface for general metadata

Used to store arbitrary metadata associated to a route. Uses cases are text displayed for breadcrumbs, page titles, route specific messages, etc.

Great! Completely forgot about this. :+1:


Windows Authentication - Configure AccessDeniedPath

When an authorization policy fails a completely blank page is returned when using windows auth.  With other authentication options, like cookie authentication, one can configure an AccessDeniedPath to redirect a user too in this scenario.  What is the equivalent for windows authentication?   The documentation seems to gloss over this detail.

@HaoK Any ideas?

@Tratcher what are people supposed to do when windows auth fails?

I think they probably can just do the equivalent manually...  check for authZ failure, and redirect to the "AccessDeniedPage".  Sound reasonable @blowdart ?

I presume you're getting a 403 status? I'm not sure what Windows auth would do at this point to be honest, but yea a redirect works.

You could use the StatusCode middleware to provide content. I don't recommend redirecting, you'd loose the protocol 401/403 semantics.

Ah, I didn't mean redirect as in HTTP redirect :) I figured some magical inline redirect

Ah, yeah, the StatusCodes middleware will do that for you.

Yes, I am getting 403 status.  I was able to configure the StatusCodePages middleware to add the desired error pages.  I do feel like this needs to be noted in the documentation somewhere, even just a link to the StatusCodePages middleware.  Otherwise the documentation feels incomplete.


Hero text is overlapping of background on mobile

On a mobile the "Open Source made right" text is overlapping with the background. That should be changed.

Is this the same issue as in https://github.com/OpenElements/website/issues/33 ?


IsFloat gives Warning: grapheme_substr(): grapheme_substr

When letter is parsed for validation IsFloat, a warning is generated instead of issuing error self::INVALID. The warning is Warning: grapheme_substr(): grapheme_substr: start not contained in string in ..\vendor\zendframework\zendframework\library\Zend\Stdlib\StringWrapper\Intl.php on line 73

I do have the same problem. For me however this is not just a warning but a Fatal error, which makes the IsFloat-validator unusable.
The grapheme_substr is called in IsFloat on line 238 (ZF2 Version: 2.4.7).
The error is a result of passing in a $value that is shorter than $groupSize.
For example you will run into this error if $value is 23 and $groupSize is 3. The call with this assumed values would be $this->wrapper->substr(23, -3). Since 23 is only two digits and you use a negative starting point of -3, the grapheme_substr tries to start at position -1, which of course would fail.
On the other hand this means, that if you provide a $value that has at least a length of $groupSize, everything is fine. Since grapheme_substr(111, -3) results in a start position of 0, which is perfectly correct.
I don't know if this must/should be fixed in the IsFloat-Validator or the Intl-String-Wrapper.

I get the same error when I use barcode:
$barcodeOptions = array('text' => 'TEST');

$rendererOptions = array(
   'imageType' => 'png'
);

$data128 = Barcode::factory('code128', 'image', $barcodeOptions, $rendererOptions)->draw();

I have the same issue with IsFloat validator using ZF2.5.1.
Warning: grapheme_substr(): grapheme_substr: start not contained in string in C:\Users\User\OneDrive\Documents\My Webs\freedomsnew\vendor\zendframework\zend-stdlib\src\StringWrapper\Intl.php on line 73
and
Warning: grapheme_strpos(): grapheme_strpos: Offset not contained in string in C:\Users\User\OneDrive\Documents\My Webs\freedomsnew\vendor\zendframework\zend-stdlib\src\StringWrapper\Intl.php on line 86
As mentioned by alexsawallich the $groupSize variable must not be greater than the values length.  If i enter a value of 10 validation fail's but if I enter 10.00 or 100 validation passes. $groupSize values defaults to 3.

Cannot replicate, neither here or in zend-barcode. If anyone can provide failing testcase I am happy to reopen it.