MONIT-5441: Added code to handle source tags and descriptions.

Added Deocoder and Handler code for sourceTags and sourceDescription metadata.

There are conflicting files, please rebase this PR

I have updated the PR. I have added an AbstractIngesterFormatter as base class and IngesterFormatter and SourceTagIngesterFormatter as sub classes. Also I have created an AbstractWrapper class which provides a wrapper around ReportPoint and ReportSourceTag.

I have removed the 'GZip' logic detection and added generics to the AbstractIngesterFormatter class.

Added the javadoc comments.

Sorry for the delay, please resolve conflicting files and we'll proceed

Resolved the conflicts.

I am going to merge this in but on second thought, we should be able to do this on a single port rather than on two (same is true for aggregated histograms).
Basically if it starts with "@" it's a metadata operation and "!" is a histogram.
That's outside the scope of this ticket but I'll file an issue and assign it to you (should you find yourself wanting a challenge).


Update tab-based-navigation.md

Made a note of the clashing routes issue

hi, thanks for the PR! What is the motivation for this? I find that there is no need to explain that the two tabs need to have different names.

Hi I just wanted to make a note because I ran into an issue where I had a StackNavigator inside a TabNavigator and it threw a mysterious error because they had the same route name. If you feel its obvious that route names have to be unique among navigators then can close this.

Thanks for the PR; I do believe that people intuitively expect that route names have to be unique otherwise the navigator cannot know where to go.


Changed theme colorscheme description to include flavour names

This allows for the different flavours to be differentiated easier when multiple are loaded in at once.

Oh yeah, good point. Thanks.


Can't find SDL on Ubuntu 17.10 Wayland

I've compiled SDL2 from source and, for some reason, Veldrid can't find the lib.
System.TypeInitializationException: The type initializer for 'Veldrid.Sdl2.Sdl2Native' threw an exception. ---> System.IO.FileNotFoundException: Could not find or load the native library: libSDL2-2.0.so

I've tracked the code to: https://github.com/mellinoe/veldrid/blob/444d3295bf97346ffafdbdd0960c96fdce91d0a8/src/Veldrid.SDL2/Sdl2.cs#L19
Switching the library name to libSDL2-2.0.so.0 solved the issue. Maybe adding a regex for the NativeLoader lib that looks like this libSDL2-2.0.so(|.1|.0) would make builds more friendly?

Maybe adding a regex for the NativeLoader lib that looks like this libSDL2-2.0.so(|.1|.0) would make builds more friendly?

Yeah, it shouldn't be too hard to make the library loading a little bit more lenient. There is already an extension point in NativeLibraryLoader that should allow multiple names to be tried (although I forget exactly how I did it).


OnClick method on a Button within a foreach fires one time only

The OnSelectType method is only called the first time a button is clicked. Afterwards, the button shows the tap animation, but the method is not called.
@foreach (var option in Options)
{
    <Button Text="Select" OnClick="(() => OnSelectType(option))" />
}

Sample here: https://github.com/dylanberry/XamarinDynamicUI/tree/master/MobileBlazorBindingsFlags

Also finding that IsVisible isn't being set properly:
@foreach (var option in Options)
{
       <Label Text="✓" IsVisible="option.IsSelected" />
}

Wondering - are you using the preview bits on nuget.org, or are you building from the source in this repo? I wouldn't be surprised at some of these issues being in the bits on nuget.org, but I think some are fixed in the latest source. I'll try both ways and see what I find. Thank you for reporting this!

OK I can reproduce this in the latest sources in the repo. I will investigate.

Interestingly this bug doesn't repro in the todo app, but does repro in the code shown above.
What's happening is this:

On first render:

The first Button.OnClick is mapped to let's say event handler id = 1

On second render:

That same Button.OnClick is overwritten to let's say event handler id = 2 (this is fine)
And then it is un-mapped from event handler id = 1 (this is also fine)
But that Button is now event handler id 2, not 1, and it erroneously un-maps the new event handler id association, so it's not mapped to any event handler

And this seems to happen to all these buttons.
I think the fix will be to ensure that when events are un-mapped during a re-render to ensure they only un-map from the specific event being un-mapped and not to un-map from whatever the current event handler id happens to be. Hopefully an easy fix.

The fix was as straight-forward as I thought and it's checked in now. This was a very interesting issue to investigate so hopefully this fix works for you!
Here's the code I was using to test it:
<Frame CornerRadius="10" BackgroundColor="Color.LightBlue">

    <StackLayout Orientation="StackOrientation.Vertical">

        <Button Text="Increment" OnClick="IncrementCount" />

        <Label Text="@("The button was clicked " + count + " times")"
               FontAttributes="FontAttributes.Bold"
               VerticalTextAlignment="TextAlignment.Center" />

        @foreach (var option in Options)
        {
            <Button Text="@($"Select: {option.Name}")" OnClick="(() => OnSelectType(option))" />
        }

        @foreach (var option in Options)
        {
            <Label Text="@($"✓: {option.Name}")" IsVisible="option.IsSelected" />
        }

    </StackLayout>

</Frame>

@code
{
    class Option
    {
        public string Name { get; set; }
        public bool IsSelected { get; set; }
    }

    List<Option> Options = new List<Option>()
    {
        new Option { Name = "first", },
        new Option { Name = "second", },
        new Option { Name = "third", },
        new Option { Name = "fourth", },
    };

    async Task OnSelectType(Option o)
    {
        o.IsSelected = !o.IsSelected;
        //await Application.Current.MainPage.DisplayAlert("Selected", $"You selected: {o.Name}", "OK");
    }

    int count;

    void IncrementCount()
    {
        count++;
    }
}

Oh, and IsVisible was working fine for me. It was presumably fixed as part of https://github.com/xamarin/MobileBlazorBindings/issues/57, which also was about IsVisible not working.


Fixed Anchor Links on blog pages

It was mainly due to using height 100vh in Navbar. Also removed a lot of formatting cruft from previous attempts to fix this problem.

Looks good.


ch7

Job d2l-zh/PR-611/1 is complete.
Check the results at http://preview.d2l.ai/d2l-zh/PR-611/

Job d2l-zh/PR-611/2 is complete.
Check the results at http://preview.d2l.ai/d2l-zh/PR-611/

Job d2l-zh/PR-611/2 is complete.
Check the results at http://preview.d2l.ai/d2l-zh/PR-611/


Add types definition file

Added basic types definition (d.ts) file, with link to file in package.json.

Thanks for the PR! However, I actually just finished a significant refactor of the library and these type definitions no longer apply.


[core] Fix bug in redirect logic (closes #130)

@tipsy I was going through jetty logic. They allow to redirect using absolute/relative path, though I am not sure if it is needed in this context.

Setting the header manually should also allow for both absolute and relative paths?

Alright, was confused by this Jetty stuff 👍


Adds test case for JSON anomaly logging

This changeset adds tests for JSON anomaly logging (part of issue 2882)
This update adds testing for configurations with packethdr enabled and disabled.
Continuation of #41

Continued in #50


JS function calls fail when returning JSON is larger than 65536 bytes

As far as I understand this is related to maximum Port buffer size but I wasn't able to find the relevant Erlang documentation.
Error example:
         ** (EXIT) an exception was raised:
             ** (Jason.DecodeError) unexpected end of input at position 65536
                 (jason) lib/jason.ex:78: Jason.decode!/2
                 (nodejs) lib/nodejs/worker.ex:39: NodeJS.Worker.decode/1
                 (nodejs) lib/nodejs/worker.ex:32: NodeJS.Worker.handle_call/3
                 (stdlib) gen_server.erl:661: :gen_server.try_handle_call/4
                 (stdlib) gen_server.erl:690: :gen_server.handle_msg/6
                 (stdlib) proc_lib.erl:249: :proc_lib.init_p_do_apply/3

Hmmmm, yeah that's definitely an issue.  Thanks for reporting it. I've obviously never used this for anything with a big response.
Seems like we need to consume the response in chunks, glue them back together, and then decode. One would hope there's a newline in there already to indicate when we have a complete response, but if not then that little part is arbitrary to fix. It's reworking things to receive chunks that'll take a little doing.
I'm frequently the only person who works on this (sporadically as I need to), and I'm not sure when I'll get to it. If you don't want to wait, and taking a stab at chunking piques your interest, I'd be more than happy to review a pull request.
Off the top of my head, I'm not sure what to expect in terms of difficulty because I'm not a GenServer expert. It's either fairly straightforward because multiple concurrent chunked responses won't cross the streams (ballpark 80% chance?), or it's pretty hard because we have to figure out how to keep the right chunks in the right buffers.
(@bryanjos if you have ideas, I'd love some input.)

I don't have any thoughts except what has been mentioned. Hopefully this is a kind of problem that has been solved before and has a known work around

I might try to take a stab at this today.


Feature request: have more information returned with the action chosen

Hi, thank you for your great work. Is it possible to have more information returned with the action chosen? like probability of success, expected reward or anything that could be interesting? thank you

Let totalReward / numVisit be avg_reward_per_visit
Do you think that best child avg_reward_per_visit  / sum of all childs avg_reward_per_visit
can give some sort of confidence in the choice ?
Thanks

Hi, I hope my comment is clear, or maybe a bit more explanation is needed?

Hi Dario,
Thanks for the request, aye, it's clear.  I'm afraid I don't have the bandwidth to work on this myself right now though, but feel free to make a pull request and I'll take a look :)

Yeah I can do that, no problem, but do you think the logic I've mentioned makes sense? it is a bit of a hack, and it is not backed by any theory :)

I am going to add this feature very soon. I am writing a card AI where I need this feature.

I add a parameter needNodeValue=False in search. If it is set to True, search will return the best action and NodeValue, which is the best node's average value. If it is kept False, as default, search will keep its original behavior, making it backward compatible. I will push from my fork to this repo as soon as I finish the tests.

I have added this feature in my fork and pushed my branch to pull request #13.


Support Futures

Allow stubbing methods with and_return_future and and_raise_future
Resolves #86

changelog

LGTM :shipit:

+1

:ship: :it:

Please make sure this is a minor version release, 1.1.0 - we shouldn't be adding features to patch-level releases. semver.org

This was merged in.


[traits] volumes error

Seems it's a bug, could tell about your kubevela version? Would you mind to use the v1.3.3 to have a try?


hotfix/byuWebView -> dev

This change is

Reviewed 1 of 1 files at r1, 1 of 1 files at r2.
Review status: all files reviewed at latest revision, all discussions resolved.

Comments from Reviewable


Confirmation alerts for critical operations

There are some critical operations that don't require confirmation regarding if one is absolutely sure one would want do it. For example, such operations could be

[ ] Delete a job (verv)
[ ] Delete a page

Done.


Config and Version CMake File

Fixes issues #2
progressbar can be included by CMake config files
CMake version by version.hpp
CMake config file description in README

Already a nice job, thanks a lot!
I added some comments, mostly small stuff.
Currently, I think that I prefer the following structure of the repo:
cmake/elegant-progressbars-for-a-more-civilized-ageConfig.cmake
include/elegantProgressbars/version.hpp
include/elegantProgressbars/<some_progressbar>.hpp
examples/...

I know that it is quite unnecessary to have the cmake folder, but dout is already set up like this and I would prefer to keep the structure similar to that. If there are good reasons to change the structure, I would be happy to hear them (and I would probably change dout as well, if your argument convinces me)

(very important?)  Addition:
The project name, as well as the iconfig-file and the folder inside include/ should probably have the same name. Otherwise the cmake will have problems finding the project in some cases.
Since elegant-progressbars-for-a-more-civlized-age is quite long, I propose to rename everything to elegant-progressbars (except the repository itself)

Thank you for your annotations. I included them all into the last commit.

Yay! Thanks so much for putting in the effort!


Adding lightning icon

Adding lightning icon:

looks good to me :) just one thing to ensure - was this icon verified by designers? @codepretty


sync: Don't release unacquired lock

@YuvalEvron this looks broken in the tests. did you look at them?

Instead of checking if self.cond.locked(), we should remove the root bug - the fact the the acquire happens inside the try. If the acquire would happen before the try we wouldn't reach the finally if we fail to get the lock.


(WIP) select replica for forward requests using RegionRequestSender

This PR refactors the RegionRequestSender with state machines to make the logic easier to understand (hopefully).
And it also supports selecting replicas for request forwarding.
WIP for changing tests and doing manual integration tests.

Closing for inactivity. Please reopen it when it is ready.


Get Metadata Activity Exists Field

I am attempting to access the exists field for a folder in Azure Blob Storage via the Get Metadata Activity but I am getting a forbidden 403 error when I attempt to. Do I need anything more then read access on an Azure Blob to be able to access the exists field? I ask because I am able to do this on blob storage where I have the owner role but in this other storage account I have a limited role which I believe may be a source of the error. I do not see any special notes about required roles to access the exists field in the below article.
https://docs.microsoft.com/en-us/azure/data-factory/control-flow-get-metadata-activity

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 8e4997d4-36fd-4f1c-464b-ea3190531e02
Version Independent ID: ebf216ca-d096-549f-3dcc-9442d7c4a8dc
Content: Get Metadata activity in Azure Data Factory - Azure Data Factory
Content Source: articles/data-factory/control-flow-get-metadata-activity.md
Service: data-factory
GitHub Login: @linda33wj
Microsoft Alias: jingwang

@jlaidlawRTS Thanks for reaching out. We are looking into your query and will respond to you shortly.

@jlaidlawRTS One possible cause is that the service principal or managed identity you use doesn't have permission to access the certain folder/file.
Resolution: Grant corresponding permissions on all the folders and subfolders you need to copy. Refer to this doc.
Please refer to the troubleshooting guide  for more info.

@ChiragMishra-MSFT  In this scenario I do not have the option of modifying the permissions on the file/folders in question. I would really just like to know what permissions are required to access Exists field as I assumed they would be similar to the field options in GET METADATA activity but that is not the case. I think this could be useful in the documentation as my situation of not having the ability to modify permissions on files/folders is common.
On a side note I do not have any issues when I copy the same folders/files it is only when I try to access the Exists field in the get metadata activity.

@linda33wj Can we please include a note in the doc for the access prerequisite ?

Thanks for your feedback. Added a note in doc that when using Get Metadata activity against a folder, you need to have LIST/EXECUTE permission to the given folder.
#please-close


[docs] PhpStorm Mutagen file mapping issue with phpunit

Add instructions to fix file permission issues caused by Mutagen
The Issue
Current documentation on setting up PhpStorm leads to a nonfunctioning test runner within PhpStorm
How This PR Solves The Issue
Update documentation with guidance on how to work around the flaws in PhpStorm's directory binding discovery by manually setting a proper path mapping for /var/www/html.

I agree that this is needed in the docs - I had to make this same addition to get things working for me.

Rebased, don't forget to update your remote.

Minor markdownlint complaint,
docs/content/users/install/phpstorm.md:30:19 MD009/no-trailing-spaces Trailing spaces [Expected: 0 or 2; Actual: 1]

When the reviews are responded to and you think this is ready for review, please rebase it either with the github UI or by rebasing against upstream/master, and set it to "ready for review". Thanks! And thanks for chasing all these issues.

I’m sorry, should I be reviewing the docs for this or is @cosmicdreams going to close it?

@mattstein I would wait. I think he's still exploring this territory.

This issues have been sorted out in the PhpStorm extension, and DDEV no longer has a /var/tmp/html in HEAD.
I'd love if it you could take a look at current HEAD DDEV and see what still needs to be done. https://ddev.readthedocs.io/en/latest/developers/building-contributing/#testing-latest-commits-on-head
Closing, happy to continue the conversation here or elsewhere, and thanks for your initiative to get this all sorted out!


Date format not adapting to language/region

The date and time format is here not adapted to my locale (french).
On the side bar, the month is not translated:

Can this string be localised?

I found some string on weblate, but I don't know how to translate, it says there is an error...
https://weblate.skyjake.fi/translate/lagrange/ui/fr/?q=has%3Adismissed-check&offset=2

I found some string on weblate

That one is unrelated to these. At least the first one looks like it needs a new string added to the .po files.

That one is unrelated to these.

Yes it is unrelated, I just mentioned it because it is related to date format and I wanted to debug it xD


ember deprecated sendAction in v3.4

I noticed this just now as I updated to 3.4 ember-source

Should be resolved by #91.
I've just drafted new release 0.1.2 which should fix the problem. Please update your project and feel free to reopen if it's still an issue.


Add parameter axis to tversky loss

Add parameter axis to tversky loss similar to dice loss.
I can implement that if someone give me green light :)

Feel free to create a PR, Keras team would be happy to review. Thanks

https://github.com/keras-team/keras/pull/20563

Merged PR.


docs: add a note about the stability of python 3 formulae

[x] Have you followed the guidelines in our Contributing document?
[x] Have you checked to ensure there aren't other open Pull Requests for the same change?
[x] Have you added an explanation of what your changes do and why you'd like us to include them?

This tweaks the Homebrew-and-Python doc to include a note about the stability of the various Python 3 formulae: we don't have a policy of guaranteeing that /usr/local/bin/python3 (or wherever) remains at the same minor and patchlevels between upgrades, which is a frequent source of confusion for people using the Homebrewed Python with virtual environments. I think this is reasonable behavior on our part (since it's what every other system package manager does), but making an explicit note of it will give us something easy to link to when the question comes up.

Review period will end on 2021-02-05 at 00:35:43 UTC.

Isn't this basically true of any Homebrew formula? Suggest we be terser here and recommend pyenv explicitly:

Important: Python may be upgraded to a newer version at any time. Consider using a version manager such as pyenv if you require stability of minor or patch versions for virtual environments.

Isn't this basically true of any Homebrew formula?

Yep, it is. I think the only reason it's worth mentioning at all is because people are more surprised when it happens to Python than, say GCC.
I like your version much better; will change it!

Review period skipped due to critical label.

:beers:


Timer not running when current tab out of focus

https://hackedbychinese.github.io/ng2-idle/
The example runs continue stopping countdown if I move the focus to other tab or applications.
Max OS X 10.12.4
Chrome Version 59.0.3053.3 (Official Build) dev (64-bit)

Check out Chrome Stable Version


Workbook page redesign

Redesign workbook page
Add logic with changing favorites for workbook entries

After duplicating an entry, some already downloaded entries disappear:

https://github.com/datalens-tech/datalens-ui/assets/29424746/db3bd192-d2e1-423b-9344-4d310d8d996c

Sequential requests for each entry type. Must be parallel:

https://github.com/datalens-tech/datalens-ui/assets/29424746/e6714d24-8b6a-4a86-90ff-b23f8f80c03a

"No objects yet" when loading entries. Need to show loader:

There should be 20px between these two buttons, and the buttons should be the same size:

i18n-check

The following components have not been translated
new-workbooks (en)new-workbooks (ru)

Wait for the reviewers to check your changes in Weblate and try running github action again.

i18n-check

The following components have not been translated
new-workbooks (en)new-workbooks (ru)

Wait for the reviewers to check your changes in Weblate and try running github action again.

i18n-check

The following components have not been translated
components.common.Datepicker (en)components.common.Datepicker (ru)dash.control-dialog.edit (en)dash.control-dialog.edit (ru)dash.dashkit-plugin-control.view (en)dash.dashkit-plugin-control.view (ru)

Wait for the reviewers to check your changes in Weblate and try running github action again.

i18n-check

The following components have not been translated
components.common.Datepicker (en)components.common.Datepicker (ru)dash.control-dialog.edit (en)dash.dashkit-plugin-control.view (en)dash.dashkit-plugin-control.view (ru)

Wait for the reviewers to check your changes in Weblate and try running github action again.

i18n-check

The following components have not been translated
components.common.Datepicker (en)components.common.Datepicker (ru)dash.control-dialog.edit (en)dash.dashkit-plugin-control.view (en)dash.dashkit-plugin-control.view (ru)

Wait for the reviewers to check your changes in Weblate and try running github action again.

i18n-check

The following components have not been translated
components.common.Datepicker (en)components.common.Datepicker (ru)connections.yadocs.view (en)connections.yadocs.view (ru)dash.control-dialog.edit (en)dash.dashkit-plugin-control.view (en)dash.dashkit-plugin-control.view (ru)dash.popup-widgets-order.view (en)dash.popup-widgets-order.view (ru)sql (en)sql (ru)

Wait for the reviewers to check your changes in Weblate and try running github action again.

Here should be underline and bigger gap:

We need to wait for all entries requests before showing the page content, not just the first resolved one:
https://github.com/datalens-tech/datalens-ui/assets/29424746/0624728a-5406-4c1b-b0eb-a25fc352cf7c

i18n-check

The following components have not been translated
components.common.Datepicker (en)components.common.Datepicker (ru)connections.yadocs.view (en)connections.yadocs.view (ru)dash.control-dialog.edit (en)dash.dashkit-plugin-control.view (en)dash.dashkit-plugin-control.view (ru)dash.popup-widgets-order.view (en)dash.popup-widgets-order.view (ru)sql (en)sql (ru)

Wait for the reviewers to check your changes in Weblate and try running github action again.

i18n-check

The following components have not been translated
components.common.Datepicker (en)components.common.Datepicker (ru)connections.yadocs.view (en)connections.yadocs.view (ru)dash.control-dialog.edit (en)dash.dashkit-plugin-control.view (en)dash.dashkit-plugin-control.view (ru)dash.popup-widgets-order.view (en)dash.popup-widgets-order.view (ru)sql (en)sql (ru)

Wait for the reviewers to check your changes in Weblate and try running github action again.

i18n-check

The following components have not been translated
components.common.Datepicker (en)components.common.Datepicker (ru)connections.yadocs.view (en)connections.yadocs.view (ru)dash.control-dialog.edit (en)dash.dashkit-plugin-control.view (en)dash.dashkit-plugin-control.view (ru)dash.popup-widgets-order.view (en)dash.popup-widgets-order.view (ru)sql (en)sql (ru)

Wait for the reviewers to check your changes in Weblate and try running github action again.

i18n-check

The following components have not been translated
components.common.Datepicker (en)components.common.Datepicker (ru)connections.yadocs.view (en)connections.yadocs.view (ru)dash.control-dialog.edit (en)dash.dashkit-plugin-control.view (en)dash.dashkit-plugin-control.view (ru)dash.popup-widgets-order.view (en)dash.popup-widgets-order.view (ru)sql (en)sql (ru)

Wait for the reviewers to check your changes in Weblate and try running github action again.

i18n-check

The following components have not been translated
components.common.Datepicker (en)components.common.Datepicker (ru)connections.yadocs.view (en)connections.yadocs.view (ru)dash.control-dialog.edit (en)dash.dashkit-plugin-control.view (en)dash.dashkit-plugin-control.view (ru)dash.popup-widgets-order.view (en)dash.popup-widgets-order.view (ru)sql (en)sql (ru)

Wait for the reviewers to check your changes in Weblate and try running github action again.

i18n-check
Please merge the Pull Request with the changes from Weblate into your branch.

i18n-check
Please merge the Pull Request with the changes from Weblate into your branch.

i18n-check
Please merge the Pull Request with the changes from Weblate into your branch.

i18n-check
Please merge the Pull Request with the changes from Weblate into your branch.

i18n-check
Please merge the Pull Request with the changes from Weblate into your branch.

i18n-check
Please merge the Pull Request with the changes from Weblate into your branch.

i18n-check
Please merge the Pull Request with the changes from Weblate into your branch.

@Sergey-weber

After duplication, we need to reset the entries count to 10 and show the “Show more” button:

https://github.com/datalens-tech/datalens-ui/assets/29424746/bc861996-3086-4ea1-8ba4-ea5d3cd1ecef

Strange empty placeholder in Dashboards (only in empty workbook):

i18n-check
Please merge the Pull Request with the changes from Weblate into your branch.

i18n-check
Please merge the Pull Request with the changes from Weblate into your branch.

i18n-check
Please merge the Pull Request with the changes from Weblate into your branch.

i18n-check
Please merge the Pull Request with the changes from Weblate into your branch.

i18n-check
Please merge the Pull Request with the changes from Weblate into your branch.

i18n-check

The following components have not been translated
component.dialog-relations.view (en)component.dialog-relations.view (ru)components.common.Datepicker (en)components.common.Datepicker (ru)connections.yadocs.view (en)connections.yadocs.view (ru)dash.control-dialog.edit (en)dash.dashkit-plugin-control.view (en)dash.dashkit-plugin-control.view (ru)dash.popup-widgets-order.view (en)dash.popup-widgets-order.view (ru)new-workbooks (en)new-workbooks (ru)sql (en)sql (ru)

Wait for the reviewers to check your changes in Weblate and try running github action again.

i18n-check

The following components have not been translated
component.dialog-relations.view (en)component.dialog-relations.view (ru)components.common.Datepicker (en)components.common.Datepicker (ru)connections.yadocs.view (en)connections.yadocs.view (ru)dash.control-dialog.edit (en)dash.dashkit-plugin-control.view (en)dash.dashkit-plugin-control.view (ru)dash.popup-widgets-order.view (en)dash.popup-widgets-order.view (ru)new-workbooks (en)new-workbooks (ru)sql (en)sql (ru)

Wait for the reviewers to check your changes in Weblate and try running github action again.

i18n-check

The following components have not been translated
components.common.Datepicker (en)components.common.Datepicker (ru)connections.yadocs.view (en)connections.yadocs.view (ru)dash.control-dialog.edit (en)dash.dashkit-plugin-control.view (en)dash.dashkit-plugin-control.view (ru)dash.popup-widgets-order.view (en)dash.popup-widgets-order.view (ru)new-workbooks (en)new-workbooks (ru)sql (en)sql (ru)

Wait for the reviewers to check your changes in Weblate and try running github action again.

i18n-check

The following components have not been translated
components.common.Datepicker (en)components.common.Datepicker (ru)connections.yadocs.view (en)connections.yadocs.view (ru)dash.control-dialog.edit (en)dash.dashkit-plugin-control.view (en)dash.dashkit-plugin-control.view (ru)dash.popup-widgets-order.view (en)dash.popup-widgets-order.view (ru)new-workbooks (en)new-workbooks (ru)sql (en)sql (ru)

Wait for the reviewers to check your changes in Weblate and try running github action again.

i18n-check
Please merge the Pull Request with the changes from Weblate into your branch.


To steering api updates

Added ability to update and remove filters.
Traffic Ops now returns a 400 (instead of a 200) when you try to update a steering assignment with invalid json.

I noticed that one of the tests still accepts the wrong json PUT data
https://github.com/dneuman64/traffic_control/blob/be93fd85ac0e4f8cef322c446523a419875d5dc4/traffic_ops/app/t/api/1.2/steering_internal.t#L276
The 'filters' attribute is in the wrong place. Can you remove just that one line and have the test assert that we get back a 400? i.e. filters is a required attribute for the PUT data.
The test you came up with for removing filters looks good!
https://github.com/Comcast/traffic_control/pull/1485/files#diff-27ed8be6da922277af8c7baa33b71575R337

hmm, that is not anything I changed, but I will remove the filters from there.  I should probably have a check to make sure weight and deliveryService is included for target.
As for filters, they are not required.  it is perfectly acceptable to submit a json without filters, and I already have tests to validate accordingly.


[ZEPPELIN-2688]. Upgrade ace to 1.2.7

What is this PR for?
Ace 1.2.7 add syntax highlight for pig script. This ticket is to upgrade ace from 1.2.6 to 1.2.7
What type of PR is it?
[Improvement]
Todos

[ ] - Task

What is the Jira issue?

https://issues.apache.org/jira/browse/ZEPPELIN-2688

How should this be tested?
Tested manually
Screenshots (if appropriate)
Before

After

Questions:

Does the licenses files need update? No
Is there breaking changes for older versions? No
Does this needs documentation? No

@minahlee Could you help review it ? Thanks.
Failed test is flaky test.
Results :

Failed tests:
  NotebookServerTest.testMakeSureNoAngularObjectBroadcastToWebsocketWhoFireTheEvent:148
notebookSocket.send(<any>);
Never wanted here:
-> at org.apache.zeppelin.socket.NotebookServerTest.testMakeSureNoAngularObjectBroadcastToWebsocketWhoFireTheEvent(NotebookServerTest.java:148)
But invoked here:
-> at org.apache.zeppelin.socket.NotebookServer.broadcast(NotebookServer.java:494)

@1ambda @minahlee  Could you help review it ? Thanks

Let me review and comment soon.

Tested locally and works well.

Here is a comparison between two versions.

https://github.com/ajaxorg/ace/compare/v1.2.6...v1.2.7

LGTM.

Thanks for review @1ambda

Will merge it if no more discussion.

oh nice


Scale problem

Hello! Tell me, please, is it possible to correctly change the scale of the hand? When I change the scale, the elbow shifts and the arm stretches.

Plugin v 5.7.0
Unity 2020.3.26f1

Please can you check to see if this has just been scaled for one axis? From your image it looks as though the model has been stretched along the X axis.
In addition please ensure that you have unticked the options below and this will allow to scale the hand successfully.

Match joint postions with tracking data
Scale model to tracking data

Thank you for your feedback, we will look at improving our documentation for this to make it a bit clearer. :)


Update config schema to support multiple hostnames

We should support multiple hostnames before merging this.

Let's not merge this until we support multiple hostnames in all cases where hostname is used.

Looking at the other ones, I think it's better to introduce a new config key for alternate hostnames and keep hostnames a single value


Listing resolvers returns more properties

Compared to v1.4, listing resolvers now also return priority, projects and other user-defined fields

Is this an issue? The addition of fields is not an API breaking change, just the removal of them. If it is just a comment, please add it to the list in https://github.com/BlueBrain/nexus/issues/1828

We can talk about it but we removed these properties from the responses from the create/update/deprecate operations so it would make sense to remove them also here

listing is not a write operation, but a read operation. When you fetch a resolver you get those fields, right?

It would be more consistent with the other listings yes

Yes. Since we are using the actual Distributed Data cache to provide with listings in most of the resources, we should be getting the same sort of response (not only metadata fields, but also other fields) for those listings as well.
The exception here are resources for where listings come from Elasticseaarch, since we have a common ES mapping. For those we will keep returning only metadata fields.


feat: add support for tagging

Description
Add support to enable users to set tags on database operations such as reads, queries and transactions.
Background
The statistics of queries, reads and transactions in Cloud Spanner are stored. Providing tags for database operations will allow these statistics to be grouped by a tag and makes queries/transactions easily searchable by tag. This will help make the information provided by the statistics more useful.
TODO

[x] Rebase when RequestOptions proto changes are published.

Note: samples will be handled in a separate PR.

+@syeduguri Please review

@olavloite @thiagotnunes  I re-rebased PR based on #716, I'd like to get your reviews and approval.

The samples build failure is unrelated to this change


Color Theme 'Dark (Visual Studio)' Breaks Syntax Highlighting

Type: Bug
Test Steps
Completed using VS Code - Insiders

On Fresh Install of VS Code (Post Clean Uninstall and Computer Restart)
Open fresh project.
Code shows hightlighting only when using Dark Modern
Switching theme "turns on & off" highlighting present.
Tested with Python and JavaScript Syntax

Suggested Cause
I believe that with the update and the new Dark Modern theme as Default, highlighting for the old theme has broken.
Images

VS Code version: Code - Insiders 1.79.0-insider (Universal) (2c73d2651cc525b27fc697b820743098a204ec01, 2023-05-04T22:14:17.675Z)
OS version: Darwin arm64 22.4.0
Modes:
Sandboxed: Yes

System Info

Item
Value

CPUs
Apple M2 (8 x 24)

GPU Status
2d_canvas: enabledcanvas_oop_rasterization: disabled_offdirect_rendering_display_compositor: disabled_off_okgpu_compositing: enabledmetal: disabled_offmultiple_raster_threads: enabled_onopengl: enabled_onrasterization: enabledraw_draw: disabled_off_okvideo_decode: enabledvideo_encode: enabledvulkan: disabled_offwebgl: enabledwebgl2: enabledwebgpu: enabled

Load (avg)
1, 2, 2

Memory (System)
8.00GB (0.36GB free)

Process Argv

Screen Reader
no

VM
0%

Extensions: none
A/B Experiments
vsliv695:30137379
vsins829:30139715
vsliv368cf:30146710
vsreu685:30147344
python383:30185418
vspor879:30202332
vspor708:30202333
vspor363:30204092
vslsvsres303:30308271
pythontb:30258533
pythonptprofiler:30281269
vshan820:30294714
pythondataviewer:30285072
vscod805cf:30301675
bridge0708:30335490
bridge0723:30353136
cmake_vspar411:30581797
vsaa593:30376534
pythonvs932:30404738
cppdebug:30492333
vsclangdf:30492506
c4g48928:30535728
dsvsc012cf:30540253
pynewext54:30618038
pylantcb52:30590116
pyind779:30611226
pythonsymbol12:30651887
showlangstatbar:30725951
azdwalk:30721579
pythonms35:30671666
03d35959:30680466
ecj1e332:30687743
pythonfmttext:30716741
pythoncmvfstr:30726892
9b8hh234:30694863
fixshowwlkth:30724385
hidesbindicator:30724476
pythongtdpath:30726887

Further testing shows that it also occurs with Golang:

Here too.Python syntax highlighting only work with Dark modern theme WTF vscode???

+1

+1, TypeScript

+1, Php

Have you tried Dark+?
Syntax highlighting works and I don't see differences in color compared to non-plus.

Terraform

Also, just to be 100% clear, are you sure you weren't using Dark+ before, not Dark (Visual Studio). Dark+ was the old default theme not the latter.

For me, Dark + actually works correctly. Dark (Visual Studio) is breaking syntax highligh. This started happening after going back to this theme after trying out the new dark mode

Dark (Visual Studio) has different highlighting behavior than Dark+. The screenshots above look normal to me. My guess here is that you were looking at Dark+ before since that was the default.

Dark (Visual Studio) has different highlighting behavior than Dark+. The screenshots above look normal to me. My guess here is that you were looking at Dark+ before since that was the default.
My understanding is that Dark (Visual Studio) is intended for Visual Studio users coming to VS Code who are used to the highlighting looking like that, especially for C#. @aeschli can confirm.

So, I do not know about anyone else or which theme was in fact being pointed to in the background but I know that 'Dark (Visual Studio)' has always been my colour theme. Up untill the recent update, with no changes on my end, this theme had syntax highlighting - for example: yellow text for Python functions.

Ok, I'll see if we can repro on our end and will report back. No changes to that theme were intended.

Dark (Visual Studio) is much simpler and has no colors for variables and function references. Nothing changed there.
We don't automatically change your theme if you have Dark (Visual Studio) set in the settings. That only happens if you didn't had any theme configured, which defaulted to Dark+.

Okay - I must've been mistaken. Thank you for the help.


187 Repeated DNA Sequences cpp

Pull Request Template
What have you Changed(must)
Added solution to 187 Repeated DNA Sequences in C++
Write here what you have changed in the codebase
added file in the C++ folder
Issue no.(must) - #1139
Pr will be close and marked as spam. If issue number not found or issue was assigned to someone else.
Marking as spam can block your account from HacktoberFest.
Self Check(Tick After Making pull Request)

[x] This issue was assigned to me if not it will be marked as spam.
[x] My file is in the proper folder
[x] I am following clean code and Documentation.
[x] I have added the title and what program will do first in the file
[x] I have named the file as (Problem #). (Problem Title(in Camel Case)).(extension)
ex. 2. AddToNumbers.py

README - How to Contribute

@SSKale1 @Yashica7 @swaingotnochill @JOKUE2002 feel free to merge and check it.


Add nan.nmin

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 91.00%. Comparing base (52e0f24) to head (e0c1c37).
Report is 3 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #37      +/-   ##
==========================================
+ Coverage   90.67%   91.00%   +0.32%
==========================================
  Files          10       10
  Lines         193      200       +7
  Branches       20       22       +2
==========================================
+ Hits          175      182       +7
  Misses         18       18

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


New Release for pip?

New Release for pip? I'm getting the import error from sqlalchemy ExtDeprecationWarning: Importing flask.ext.sqlalchemy. I'm on version 0.10. Thanks!

Please could someone wake up?

Any updates @mgood? Would love to hear your thoughts or possibly have somebody else take over in maintaining this repo. Thanks!

+1 Really think we shouldn't abandon this repo like this.

+1 @mgood - can you make a release? This will also fix warnings about flask.ext

Spent some time cleaning up stuff this evening. I'll try to get a new version out tomorrow on Pypi.

Thank you! :)

It'll have to be this weekend, I didn't get to it today.

Just pushed 0.10.1 to Pypi

wow thanks


Need non-git instructions

This needs to be updated with instructions for people who aren't using git for deployment.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: ef971d21-e72b-7771-d34a-b6da42d602bb
Version Independent ID: f60dc748-8cf9-a8eb-9b96-e30cd13acc56
Content: Create a PHP web app and deploy to App Service on Linux
Content Source: articles/app-service/containers/quickstart-php.md
Service: app-service-web
GitHub Login: @SyntaxC4
Microsoft Alias: cfowler

Hi @atrauzzi, thanks for bringing this to our attention. Your feedback has been shared with the content owner for further review.


Unknown platform: darwin

mac m1 无法运行

File "/opt/homebrew/Caskroom/miniconda/base/lib/python3.10/site-packages/cpm_kernels/__init__.py", line 1, in <module>
    from . import library
File "/opt/homebrew/Caskroom/miniconda/base/lib/python3.10/site-packages/cpm_kernels/library/__init__.py", line 1, in <module>
    from . import nvrtc
File "/opt/homebrew/Caskroom/miniconda/base/lib/python3.10/site-packages/cpm_kernels/library/nvrtc.py", line 5, in <module>
    nvrtc = Lib("nvrtc")
File "/opt/homebrew/Caskroom/miniconda/base/lib/python3.10/site-packages/cpm_kernels/library/base.py", line 59, in __init__
    raise RuntimeError("Unknown platform: %s" % sys.platform)

报错提示 cpm_kernels 不支持 arm

Duplicate of #6

RuntimeError: Error(s) in loading state_dict for ChatGLMForConditionalGeneration:
size mismatch for transformer.layers.0.attention.query_key_value.weight: copying a param with shape torch.Size([12288, 2048]) from checkpoint, the shape in current model is torch.Size([12288, 4096]).
the same error!!!


Upload latest 2.16 version to cs.symfony.com/download link

Feature request
The suggested link to download package phar from https://cs.symfony.com/download/php-cs-fixer-v2.phar contains the 2.15.8 version, but the newest version is v2.16.4.
Maybe because version 2.15.8 published later than 2.16.4 (difference in time - 5 minutes).
Can you upload latest version to cs.symfony.com?

Seems that issue resolved.
Downloaded phar now have a version 2.16.4

I'm having this problem now. https://cs.symfony.com/download/php-cs-fixer-v2.phar is v2.15.8

There is the latest version. Have you tried a link in incognito mode or something like this to avoid hitting browser cache?
To verify there is latest version run this:
<?php
$content = file_get_contents('https://cs.symfony.com/download/php-cs-fixer-v2.phar');
echo substr($content, strpos($content, 'const VERSION') - 44, 70);

it can be seen here: https://paiza.io/projects/HfRtyQCxl5RHJZqXDxnyeg

I'm experiencing this issue too, output of https://paiza.io/projects/HfRtyQCxl5RHJZqXDxnyeg few seconds ago:
class Application extends BaseApplication { const VERSION = '2.15.8';

WTF? Now both paiza URLs, my local PC and the link https://cs.symfony.com/download/php-cs-fixer-v2.phar resulting with 2.15.8.
Yesterday it was 2.16.4.

i guess this is orphan ticket, version in download link is valid
ker@dus:~/Downloads λ php php-cs-fixer-v2.phar --version
PHP CS Fixer 2.18.2 Remote Void by Fabien Potencier and Dariusz Ruminski (18f8c9d)

closing for now, in case of issue re-appearing, please create a new ticket or reach out via gitter


Wrote new tests for faster debugging

Wrote two tests for debugging ovs implementation. Fixed logic switch in cn.go.

tests can be run using go test -run <function-name>


[to-do]   add coverage of rest api

Add  wrappers for common rest api to make them callable from flutter code.
Add tests and sample code for these APIs.

@Sing-Li  Before starting to implement the code right away, I want to ask you a few questions to get a better understanding, which can assist me in delivering a high-quality implementation.

Which specific REST API endpoints do you want me to prioritize when implementing the wrapper? (I can start with authentication, user management, and chat room management endpoints. Please let me know if you have other priorities.)
Are there any specific conventions or style guidelines that you want me to follow when writing the code and tests? (I will follow the Dart style guide, adhere to the Effective Dart guidelines, and use a specific linter configuration. Please let me know your preferences.)
Do you have any preferences or best practices regarding error handling and exception handling in the API wrapper? (I feel custom exception classes will work the best. Please let me know if there is any different approach you prefer. )

Guys, I am having college exams till 4th April. Sorry for the late response. @Sing-Li do you think should me and @yatendra2001 work on the same issue?

@Sing-Li Thank you for the insightful advice! I understand the importance of focusing on the APIs that are relevant to specific example apps rather than attempting to cover every possible API without context. This approach will help us create a more practical and efficient API wrapper implementation.
Based on your suggestion, I have a non-trivial example app in mind, Here's a brief outline of the app features:

User registration and authentication: Users can sign up and log in to the app using their email and password.
User profile management: Users can view and update their profile information, such as username, display name, and avatar.
Chat room creation: Users can create new public or private chat rooms.
Chat room management: Users can join, leave, or invite others to chat rooms. They can also view the list of members in a chat room and manage user roles.
Messaging: Users can send and receive messages in chat rooms, including text, images, and file attachments.
Real-time updates: The app should display new messages and chat room updates in real time.

This would give you a good starting point to cover multiple aspects of the Rocket.Chat platform.

Spectacular!    Please go right ahead and start the coverage.
Only advice is to put some extra focus on 5 and 6.    Especially when it comes to the different connectivity behaviors (mode) of all the platforms that Flutter supports.      For example,  desktop is connect-for-a-few-hours and disconnects-for-a-few-hours;   mobile is connect-disconnect-connect-disconnect-totally.no.connection-connect-disconnect  ALL the time;   browser is connect-on-new-instance on demand.     This will tease out a huge set of APIs that will be both in-context and essential to any users of the SDK to solve real messaging problems  🙏

Guys, I am having college exams till 4th May. Sorry for the late response. @Sing-Li do you think should me and @yatendra2001 work on the same issue?

@subhadeepchowdhury41 please revisit the history of all issues here - including the closed ones.  Read all the comments.
When you have time, do come back and see what issues are outstanding and help (here or on any other repositories in or outside of our ecosystem)   Thanks.


templating

in graphite-web/webapp/graphite/render/glyph.py the method loadTemplate reads the template from the config file. graphite-api doesn't do this.

it has been the case since initial release, yet this is not mentioned anywhere in the changelog (i.e. implying that the behavior is the same as graphite-web).
the docs still mention the template http param and graphTemplates.conf, glyph.py also refers to the file, but the file is not used and the param does nothing.

+1
graphTemplates.conf is usefull


Name change

from Sendence to Wallaroo Labs

[x] Update license files to be "Wallaroo Labs" or "Wallaroo Authors" not Sendence
[x] Move gitbook over to Wallaroo Labs account
[x] Rename GitHub org
[x] Move blog
[x] Twitter account
[x] lib/sendence
[ ] Any references to sendence in Wallaroo repo (this should result in more items being created)
[ ] Switch public docker hub from sendence to wallaroo-labs

push public docker images to wallaroo-labs
update Make commands to use correct images
update Make commands to push to proper docker hub location
update docs after the move has been done

@JONBRWN Where are we with this issue?

@aturley did investigation in what needs to be done as part of the docker move, executing today

Remaining refereces:

sendence-dev AWS S3 bucket
sendence private Docker repo
references to repo in dagon .org and .ini files

closing in favor of #1555 and #1556, the last remaining mentions


Add current week for zh-tw

The day after tomorrow was always determined as next week.
So we should subtract startOfWeek time from current time, and check it is larger then a week.

OK, I add now as parameter in those functions.

Can you please rebase on latest develop? https://github.com/moment/moment/blob/develop/CONTRIBUTING.md

Finish! Thank you :smile:

@davidyen1124 this PR contains 19 commits and 91 changed files. I'm sure your change is simpler than that. It would be easier if you make another PR from scratch -- just apply your changes on top of the develop branch. Also make sure to change src/locale/az.js and src/test/locale/az.js, and no other files (that are automatically generated).

A rebase would work also, instead of opening a new PR

@mj1856 I did say "Can you please rebase" and got "finish", and its far from "finish", so I suggested making a new one :)

:smile:


Filter by recently added

Seen several requests for filtering by date/recently added.

Duplicate of #2


Simple usage questions

I have looked at the source code but can't seem to find easy ways to do these two task.

Can you set the Forms Cached Image to not cache an image? I have tried setting the CacheDuration to zero and that didn't work. My current solution is to create a SucessCommand that calls CachedImage.InvalidateCache for that image.

Is there a way to check if something is already in the cache? I am preloading a bunch of images that might have already been preloaded, not sure since the previous preload might have fail or not have had time to run. FFImage resolves these correctly but you can notice a glitch in the apps UI so maybe I can detect if I need to send it to FFImage if it has already been preloaded.

Can you set the Forms Cached Image to not cache an image? I have tried setting the CacheDuration to zero and that didn't work. My current solution is to create a SucessCommand that calls CachedImage.InvalidateCache for that image.

Not currently, I'll try to add None to CacheType enum / property. You can only disable disk cache with CacheType=CacheType.Memory now.

Is there a way to check if something is already in the cache? I am preloading a bunch of images that might have already been preloaded, not sure since the previous preload might have fail or not have had time to run. FFImage resolves these correctly but you can notice a glitch in the apps UI so maybe I can detect if I need to send it to FFImage if it has already been preloaded.

There's no harm with calling Preload multiple times for the same item. If the item is already in cache, preloading will simply not do anything.
You can check it with:

ImageService.Config.MemoryCache.Get(string key) for memory cache. It will return null when not found.
ImageService.Config.DiskCache.ExistsAsync(string key) for disk cache.

Actually CacheType. Memory makes more sense now that I think of it, thanks I will use that.
Also I know that it doesn't do harm but ImageService.Config.DiskCache.ExistsAsync(string key) is what I am looking for. Thanks!

One more thing I forgot to mention, keys for disk cache are encoded representation, so you should call it like that:
var key = ImageService.Config.MD5Helper.MD5(yourNormalKey);


feat(ckb-indexer): fix loadCells DoS vuln. Support the exact search mode

Description
loadCell or Collector needs exact-search-mode support. otherwise there's the DoS vulnerability about any Dapps rely on the lumos
Fixes #488
Type of change

[ x ] Bug fix ( transfer DoS of lumos )
[ x ] New feature ( support exact-search-mode for collector )

How Has This Been Tested?
git clone git@github.com:LiRiu/lumos.git
cd lumos
yarn build
yarn build-release
yarn ts-node examples/load_cell_test.ts

[ x ] Test bootstrap for prefix_search mode
[ x ] Test exact_cell_collector for exact_search mode which should be used in Dapp's transfer module.

This PR is much refreshing, I find we need to update the test case since the CI failed in unit test

Ah..I did it


Scorecardtest

I fixed an error that I should have trapped. Basically Scorecard assumes k8s cluster configuration.
Also added a scorecard test.

/hold
Revisit when #81 lands

/hold cancel

I'm going to close this PR and add the above check to maybe something like cluster configuration check before we even get into scorecard test.  Premise that all scorecard test will fail if the k8s cluster is not configured.


Bug Report

Environment
Windows build number: Microsoft Windows [Version 10.0.19042.985]
PowerShell version (if applicable): 7.1.3

Steps to reproduce
Run "Get-AzSentinelHuntingRule".
Expected behavior
Hunting Rule information is output.
Actual behavior
Log Analytics workspace function information is output.

Can you provide more detail, what was the output? What was the full command you ran?


New draft

Closes #582

Don't worry about CI failing, there is an issue with Jekyll that I need to fix.

Don't worry about CI failing, there is an issue with Jekyll that I need to fix.


Use public environment settings for demo

Created a separate env group in Render for public applications, without TOOLPAD_BASIC_AUTH_USER and TOOLPAD_BASIC_AUTH_PASSWORD, and using that env group in demo.
Let me know if you think we should use a different solution to exclude basic auth from the demo.

Would it make sense to remove basic auth from toolpad-settings and create a toolpad-basic-auth group that we add to the main deployment?

Yeah that would work too, it's just more of a breaking change but should be fine and has less redundancy.


Fix bug in MultipartArray file

Defining a part using the file syntax and passing in the type for it, it would still default to a String type.
Signed-off-by: Josep M. Blanquer<EMAIL_ADDRESS>

LGTM.


feature: ChatGPT style show/hide panel button, panel state saving in local storage

This PR adds ChatGPT style show/hide panel button and the state is saved in local storage.
In mobile view it hides the button since we have a hamberger menu for that.
Type of change
Please delete options that are not relevant.

[ ] Bug fix (non-breaking change which fixes an issue)
[x] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[ ] This change requires a documentation update
[ ] Documentation update

How Has This Been Tested?
Tested manually in desktop & mobile view.
Checklist:

[x] My code follows the style guidelines of this project
[x] I have performed a self-review of my code
[ ] I have commented my code, particularly in hard-to-understand areas
[ ] I have made corresponding changes to the documentation
[x] My changes generate no new warnings
[ ] I have added tests that prove my fix is effective or that my feature works
[x] New and existing unit tests pass locally with my changes
[ ] Any dependent changes have been merged and published in downstream modules

Great job. I did some manual testing even with some recent changes I made and it works nice. My only feedback is that the focus ring should be eliminated and the same SVG as chat.openai.com should be used, but this can be a separate PR and I can get to it myself.
All e2e tests fail with this change but that is mostly due to nav being invisible by default. this is a 2-line code fix for the setup of e2e tests so no worries there.


[ConstraintSystem] Remove RValueAdjustment locator element

It was used for unresolved member and .dynamicType references
as well as a couple of other places, but now unresolved member
references no longer need that due to new implicit "chain result"
AST node and other places could use more precise locators
e.g. new .dynamicType locator or sequence element for for ... in
loops.

@swift-ci please smoke test

@swift-ci please test source compatibility

Debug configuration is a UPASS, I have opened a PR on swift-source-compat-suite repo to fix that issue.


Issue with react types with render

Description
Implementing this in Needle Codeblock and we face a react type issue:
TS2786: 'CypherEditor' cannot be used as a JSX component.
Its instance type 'CypherEditor' is not a valid JSX element.
The types returned by 'render()' are incompatible between these types.
Type 'React.ReactNode' is not assignable to type 'import(".../Neo4j/neo4j-design/node_modules/@types/react-table/node_modules/@types/react/index").ReactNode'.
Type '{}' is not assignable to type 'ReactNode'.

The types are<EMAIL_ADDRESS>Maybe this is an inconsistency with react v18 provided types, not sure if other products are having an issue yet.
Expected Behavior
Work out of the box for react v17.
Can you propose a solution?
I can see Workspace, OpsManager and Console are still using v17, so we could consider fixing the types to the v17 for some time until products start using v18?
Additional Information
For reproduction pull this commit: https://github.com/neo4j/neo4j-design/pull/496/commits/ccfc7beeadd91bfade8b0b132b5f36125fb20875 and then yarn to install packages and go to CypherCodeblock.tsx

Huh interesting I had a look around at what React versions people are using the new editor with and it turns out, neodash is on React ^17.0.2 and cypher-workbench is on React ^16.9.0.
I tried the repro steps you mentioned above, and did some digging, and I think there are somehow two versions of the react types installed in the neo4j-design repo, which has nothing to do with the cypher editor lol.
You can see the duplicate React package json files here after a yarn install:
neo4j-design/node_modules/<EMAIL_ADDRESS>{
    "name": "@types/react",
    "version": "18.0.26"
}

neo4j-design/node_modules/types/react/package.json:
{
    "name": "@types/react",
    "version": "17.0.52"
}

All react versions can be seen here from yarn why @types/react:
├─ @mdx-js/react@npm:2.3.0 [cb2b6]
│  └─ @types/react@npm:18.0.28 (via npm:>=16)
│
├─ @neo4j-ndl/react@workspace:packages/react [d75d7]
│  └─ @types/react@npm:17.0.52 (via npm:17.0.52)
│
├─ @types/react-dom@npm:17.0.18
│  └─ @types/react@npm:17.0.53 (via npm:^17)
│
├─ @types/react-dom@npm:17.0.19
│  └─ @types/react@npm:17.0.53 (via npm:^17)
│
├─ @types/react-syntax-highlighter@npm:15.5.6
│  └─ @types/react@npm:18.0.28 (via npm:*)
│
├─ @types/react-table@npm:7.7.14
│  └─ @types/react@npm:18.0.28 (via npm:*)
│
└─ @types/react-transition-group@npm:4.4.5
   └─ @types/react@npm:18.0.28 (via npm:*)

I did some more testing, not sure how the typescript compiler is resolving the types for react, but somehow the transitive dependencies are messing up the compiler. Used resolutions field in root package.json of the monorepo, with "@types/react": "^17.0.53" and I can see the error is away now 🤔
Will do a bit more testing and if issue comes up again will re-open! Thanks for taking a look @jharris4


Why do you use 'activate_before_residual'?

Hi,
I am going through this codebase carefully, and I find that the wide-resnet you used is slightly different from the model proposed in the paper. In your model, the last two stages did not include the bn-relu in the residual blocks as in the paper (which makes the shortcut clean). What is the reason of using this structure please? Does this structure help to boost the unsupervised performance ?

We took the code from Realistic Evaluation of SSL algorithm and just refactored it a bit:
https://github.com/brain-research/realistic-ssl-evaluation/blob/master/lib/networks.py
We didn't do any change to it with the purpose of improving accuracy.


dartk: Must evaluate arguments evaluation code even when constructor invocation is replaced with AbstractClassInstantiationError

Language/Expressions/Instance_Creation/New/evaluation_t12

/cc #28263

This test is still failing with fasta.

Fixed by a6ba01e8aa56559ab1a27c2e2e8177a0c1019dfc.


Correct way to pass the application_id

Hi @ests thanks for renaming the gem :)
I tried it and it did not work at first, so I started debugging, and here is what I found out:
To make it work, it needs to be initialized with these options (I'm using devise):
  config.omniauth :amazon_sp_api, ENV['AMAZON_SP_API_CLIENT_ID'], ENV['AMAZON_SP_API_CLIENT_SECRET'], {
    authorize_params: {
      application_id: ENV['AMAZON_SP_API_APPLICATION_ID'],
      version: 'beta',
    },
  }

At first, it did not work because the request_phase was sending the client_id, so I had to add the authorize_params with the application_id so it is passed on the URL, is that correct, or do we have a better way for handling this?

This "renamed" version was not tested by me yet ;) (I plan to do that next week).
Here's the omniauth init I use (before rename) that was working:
  provider :amazon, ENV['client_id'], ENV['client_secret'],
           redirect_uri: "#{Rails.env.production? ? 'PROD_HOST' : 'TEST_HOST'}/auth/amazon/callback",
           authorize_params: { version: 'beta', application_id: ENV['application_id'] },
           client_options: {
             authorize_url: 'https://sellercentral.amazon.com/apps/authorize/consent',
             site: Rails.env.production? ? 'https://sellingpartnerapi-na.amazon.com' : 'https://sandbox.sellingpartnerapi-na.amazon.com'
           }

Regarding your question: I honestly don't know if there is better way..

Thanks. I'll test it out with this new gem version and send a PR if I find issues. I'll also add this information to the README.

@fabioxgn fixed, thnx!


[BEAM-13423] [Bugiix] [Playground]: fix frontend failure if no examples

Fixing app failure if backend does not return examples

Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

[ ] Choose reviewer(s) and mention them in a comment (R: @username).
[ ] Format the pull request title like [BEAM-XXX] Fixes bug in ApproximateQuantiles, where you replace BEAM-XXX with the appropriate JIRA issue, if applicable. This will automatically link the pull request to the issue.
[ ] Update CHANGES.md with noteworthy changes.
[ ] If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.

GitHub Actions Tests Status (on master branch)

See CI.md for more information about GitHub Actions CI.

LGTM


fix: escape strings for logging

More insights to this... noticed that the variable name in fact the name that you provide to the Universal Plugin:
    new UniversalFederationPlugin({
      name: 'host',
      isServer: true,
      library: { type: 'commonjs-module' },
      remotes: {
        RemoteRoutes: 'RemoteRoutes@http://localhost:3002/remoteEntry.js',
      },
      debug: true,
      exposes: {},
      filename: 'remoteEntry.js',
      shared,
    }),

now when it tries to load the code is doing something wrong, instead of this :
var requestedRemote = remoteRegistry[name];

it should do something like this:
var requestedRemote = remotes['RemoteRoutes'];
```
some stuff that i don't know how to do:
1. we are never able to know the remote keys, the current output is:

```
var remotes {
  RemoteRoutes: 'http://localhost:3002/remoteEntry.js',
}
```

without knowing the remote key we will never be able to load the chunks, because we will never be able to evaluate

```
var scriptUrl = new URL(requestedRemote);
```
@ScriptedAlchemy

More insights to this... noticed that the variable name in fact the name that you provide to the Universal Plugin:
    new UniversalFederationPlugin({
      name: 'host',
      isServer: true,
      library: { type: 'commonjs-module' },
      remotes: {
        RemoteRoutes: 'RemoteRoutes@http://localhost:3002/remoteEntry.js',
      },
      debug: true,
      exposes: {},
      filename: 'remoteEntry.js',
      shared,
    }),

now when it tries to load the code is doing something wrong, instead of this :
var requestedRemote = remoteRegistry[name];

it should do something like this:
var requestedRemote = remotes['RemoteRoutes'];

some stuff that i don't know how to do:

we are never able to know the remote keys, the current output is:

var remotes {
  RemoteRoutes: 'http://localhost:3002/remoteEntry.js',
}

without knowing the remote key we will never be able to load the chunks, because we will never be able to evaluate

var scriptUrl = new URL(requestedRemote);

since the variable name is equal to host (project name that you give when you assign the plugin)
@ScriptedAlchemy are you able to help me on how to resolve this last problem?

This only happens if/when someone sets runtimeChunk: 'single', otherwiuse the name will be the name of the runtime, in this case the remote.
if you use single runtime chunk then set federation option runtime:false, so it emits full runtime

  new UniversalFederationPlugin({
      name: 'host',
      isServer: true,
      library: { type: 'commonjs-module' },
      remotes: {
        RemoteRoutes: 'RemoteRoutes@http://localhost:3002/remoteEntry.js',
      },
      debug: true,
      exposes: {},
      filename: 'remoteEntry.js',
      shared,
    }),

you are missing runtime: false and likely using runtimeChunk: single in optimization config, that means remote is only small slice of runtmie, it then does runtime=  require(hostruntime.js); runtime(additionalRuntimeofRemote)

  new UniversalFederationPlugin({
      name: 'host',
      isServer: true,
      library: { type: 'commonjs-module' },
      remotes: {
        RemoteRoutes: 'RemoteRoutes@http://localhost:3002/remoteEntry.js',
      },
      debug: true,
      exposes: {},
      filename: 'remoteEntry.js',
      shared,
    }),

you are missing runtime: false and likely using runtimeChunk: single in optimization config, that means remote is only small slice of runtmie, it then does runtime= require(hostruntime.js); runtime(additionalRuntimeofRemote)

i will perform the changes for the output so we can have a second pass review.

@erickbelfy is this ready for review?


Adding a Content Item Element that renders own form in the Layout Part.

If Content Item displays own form (ex. Product from the Nwazet Commerce Module displays form with "add to basket" button) and if that content is added by Content Item Element to Layout Part Editor that it gives a error after saving.
Error:
The anti-forgery token could not be decrypted. If this application is hosted by a Web Farm or cluster, ensure that all machines are running the same version of ASP.NET Web Pages and that the  configuration specifies explicit encryption and validation keys. AutoGenerate cannot be used in a cluster.

Told you @sfmskywalker. Trying to render front-end UI in the admin can just cause trouble.

Yeah yeah you must hate it being right ;)
I propose we render some abstracted version of the content items. Similar to what we do when rendering a ValidationSummary element, which is rendered as a simple greyish block element. We could display the DisplayText property of the selected content items.

Fixed in 1093e16a81e4a3218f1b7e2d3488901ceda94d18.


Can't override haskellPackages.binary

Issue description
Trying to override binary in haskellPackages causes an infinite recursion error.
Steps to reproduce
Create a default.nix with the following content:
let
  haskellPackages = (import <nixpkgs> {}).haskellPackages.override {
    overrides = self: super: {
      binary = super.callHackage "binary" "<IP_ADDRESS>" {};
    };
  };
in haskellPackages.ghcWithPackages (self: [ self.binary ])

and run nix-build default.nix --show-trace
Technical details

System: Ubuntu 16.04.3 LTS
Nix version: nix-env (Nix) 1.11.15
Nixpkgs version: 17.09.1547.2231575a7d
Sandboxing enabled: no

I believe this is because binary is a boot package that can't be overriden, much like transformers, base itself, containers etc.
((import <nixpkgs> {}).haskellPackages.override { overrides = self: super: { containers = super.callHackage "binary" "<IP_ADDRESS>" {}; }; }).containers

is the problem in a one-liner for nix-repl.

Though this does seem to work...
with (import <nixpkgs> {}); (haskellPackages.override { overrides = self: super: { containers = haskellPackages.callHackage "binary" "<IP_ADDRESS>" {}; }; }).containers

FWIW I need this because I'm trying to build Idris, which overrides binary in stack.yaml. Let me try that second version and see if it gets me anywhere :smile:

It turns out that there is a haskellPackages.binary_0_8_5_1 that I can use instead.

The trick is to use haskell.lib.dontCheck:
let
  pkgs = import <nixpkgs> {};
  lib = pkgs.haskell.lib;
in (pkgs.haskellPackages.override {
  overrides = self: super: rec {
    binary = lib.dontCheck super.binary_0_8_5_1;
  };
}).binary

works without any issues :smile:.


Add an additional parameter in order to be able to pass default timeout handler.

I need to do some actions when a timeout occurs, but seems this isn't possible now.

I want to plan this for the future release. Is this blocking what you want to achieve?

I think yes, because I am not able to find an elegant solution right now

I think the simplest way for now is to add a catch callback and then match the error parameter against timeout string.
qwest.get()
     .then()
     .catch(function(e, xhr, response) {
        if(e.message.indexOf('timeout') != -1) {
          // timeout
        }
     });

So, did it work?

The code above works, but it's not what I was looking for. Instead I reduced timeout fastcgi param and now I am handling the timeout in catch block.

Then I don't exactly understand what was your needs ^^ But since it's working for you, I'll close this.


Getting a value from a collection after setting the entire collection returns 'undefined'

Describe the bug
Getting a value from a collection after setting the entire collection returns 'undefined'
To Reproduce
See nodeJS script below.
Expected behaviour
Getting a value from a collection after setting the entire collection should return the correct/actual value, not undefined.
Versions (please complete the following information):

Environment: nodeJS v16.16.0
yaml: v2.2.1

Additional context
See script below.
// ----------------------------------------------------------------------------
// Using:
//   -<EMAIL_ADDRESS>//   - nodeJS v16.16.0
//
// Bug: Getting a value from a collection after setting the entire collection
//      returns 'undefined'
//
// Summary of Steps:
// 1. Parse a document with a Seq collection
// 2. Get (getIn) the value of an entry in the Seq collection ... OK
// 3. Set the entire collection using 'set' or 'setIn'
// 4. Get (getIn) the value of an entry in the Seq collection again ... NOK (undefined)
// ----------------------------------------------------------------------------
const { parseDocument } = require('yaml')

const content = `
---
name: simulacrum
path: /opt/simulacrum

splunk:
  - log_path: /var/log/simulacrum/access.log
    index: apps_nonprod
    sourcetype: generic_singleline
    source: simulacrum-access
  - log_path: /var/log/simulacrum/error.log
    index: apps_nonprod
    sourcetype: _json
    source: simulacrum-error
`

// Parse the YAML
const doc = parseDocument(content)
// Print it out ... GOOD!
console.log(doc.toString())

// Get the splunk/0/log_path value
let logPath = doc.getIn(["splunk", 0, "log_path"])
// Print it out ... GOOD!
console.log(`==> OK logPath: ${JSON.stringify(logPath)} <== OK`)

// Use `set` or `setIn` to set the entire `splunk` collection
const newValue = [
  {
    log_path: "fish",
    index: "fry",
    sourcetype: "never",
    source: "more"
  }
]
// doc.set("splunk", newValue)
doc.setIn(["splunk"], newValue)
// Print it out ... GOOD!
console.log(doc.toString())

// Get the `splunk` section
const splunk = doc.get("splunk")
// Print it out ... GOOD
console.log(`splunk: ${JSON.stringify(splunk)}`)

// Get the splunk/0/log_path value (same as above)
logPath = doc.getIn(["splunk", 0, "log_path"])
// Print it out ... BAD!
// The value of `logPath` is `undefined`
// ...`logPath` should be `fish`
console.log(`==> NOK logPath: ${JSON.stringify(logPath)} <== NOK, undefined`)

Not sure is this is a work-around or intended behavior, but if I create newValue using the createNode method everything works as expected:
const newValue = doc.createNode(
  [
    {
      log_path: "fish",
      index: "fry",
      sourcetype: "never",
      source: "more"
    }
  ]
)

If setting a collection using a "raw" Object/Array is NOT suppose to work, then you have my apologies and can close this issue.

This currently counts as intended behaviour. The get/set methods were added mostly as sugar for the direct access modification of the node tree, which supports having plain JS values embedded in it. This means that the setIn() doesn't apply doc.createNode() on the value that's set, and that getIn() doesn't navigate through non-node objects.
Changing the former would be a breaking change, but the I think the latter could be extended as a non-breaking change, along with #386.


Server can be blocked

Hello,
I was experimenting with the server part of the library.
Unfortunately I was able to block the server using mqtt stress testing tool.
The server was blocked inside internal asio operation, waiting indefinitely (timeout = -1) for poll() to return. It was waiting for the socket to be available for writing (POLLOUT).
This and looking into the source I realized that the code is doing synchronous blocking write to network socket.
My issue occurred by having a subscriber receiving data but never reading its (client side) socket. Thus the kernel send buffer filling up on the server side, leading to waiting indefinitely for the socket to become writable -- which would never happen because client side is not reading. Any subsequent progress would only happen after the client disconnect, causing poll() to return.
A possible solution would be using synchronous non-blocking write and disconnect the client if it can't keep up. But I don't have enough overall experience with MQTT to know if that'd be appropriate behavior.
Also I don't fully understand the code in do_sync_write(). It seems error handling is somehow "pushed back" to the next async_read call that would be initiated? I am reading that correctly?
Thanks,

I guess that you are using class template endpoint directly in your server.
endpoint provides both sync and async member functions.
If you use only asnyc member functions, then do_sync_write() is never called.
https://github.com/redboltz/mqtt_cpp/wiki/Sync-vs-Async might help you.

Yes indeed, I was basing my tests off of the simple no_tls_server.cpp example.
I missed the explicit async_* API, thanks for pointing to them !


Episode List

Hey,
I can not get the episodes list of a TV-Serie.
Can help?

@HeberPcL, could you please give me more details? Please enable debug (const IMDB_DEBUG = true;) and post the output of the script.
Thanks.

I saw no method of listing the names of episodes per season.

OK, now I got it. Yes, this is not implemented and most likely never will. Sorry!


Track real progress of unzip in install_widevine_arm

This changes the way the ChromeOS image is extracted and tracks the progress. It most probably fixes #325 .
With this change, the unzip() function isn't used anywhere at all, but I wasn't sure, if it should be removed.

Well, seems like the checks just triggered #305 . :laughing:


Julia instances do not die when quitting VSCode

Environment data

VS Code version: 1.63.2
Jupyter Extension version (available under the Extensions sidebar): v2021.11.1001550889
OS (Windows | Mac | Linux distro) and version: Arch Linux (rolling release)
Jupyter server running: Local

Expected behaviour
I am using the jupyter notebooks extension, with julia notebooks, kernel 1.7.0. This creates an instance of julia running. I would expect when I quit VSCode that the instance get killed.
Actual behaviour
Instead, the instance persists, and if I open VSCode again with the notebook, another instance appears. And memory starts creeping up. See picture below, where I have done this 5 times.

I am not sure whether this should be reported here or somewhere else, but I am open to suggestions.
Steps to reproduce:
They were described above - simply start VSCode, open a julia notebook, quit, and repeat.

I'm sorry you're running into this issue, we'll look into this in the new year.

I am not sure whether this should be reported here or somewhere else, but I am open to suggestions.

This is the right place for this issue.
Please could you provide the output from the Jupyter output panel.

Open a notebook
Click the command from the command palette Jupyter: Show Output (please copy everything from that).
There's no need to run a cell.

Here it is:
Jupyter Extension Version: 2021.11.1001550889.
Python Extension not installed.
Info 20:52:30: Experimentation service retrieved: [object Object]
User belongs to experiment group 'jupyterTest'
User belongs to experiment group 'jupyterEnhancedDataViewer'
Info 20:52:31: ZMQ install verified.
Info 20:52:31: Find preferred kernel for ~/Documents/Teaching/ST213/Code/ThreeStocks/three_stocks.ipynb with metadata {"kernelspec":{"display_name":"Julia 1.7.0","language":"julia","name":"julia-1.7"},"language_info":{"file_extension":".jl","mimetype":"application/julia","name":"julia","version":"1.7.0"},"orig_nbformat":4} & preferred interpreter
Info 20:52:31: findKernel found Julia 1.7.0
Info 20:52:31: PreferredConnection<EMAIL_ADDRESS>found for NotebookDocument: ~/Documents/Teaching/ST213/Code/ThreeStocks/three_stocks.ipynb
Info 20:52:31: TargetController found ID<EMAIL_ADDRESS>for document ~/Documents/Teaching/ST213/Code/ThreeStocks/three_stocks.ipynb
Info 20:52:31: Setting controller affinity for ~/Documents/Teaching/ST213/Code/ThreeStocks/three_stocks.ipynb<EMAIL_ADDRESS>Info 20:52:31: Setting setActiveController for ~/Documents/Teaching/ST213/Code/ThreeStocks/three_stocks.ipynb
Info 20:52:31: KernelProvider switched kernel to id =<EMAIL_ADDRESS>Info 20:52:31: Starting Notebook in kernel.ts id =<EMAIL_ADDRESS>Info 20:52:31: Creating raw notebook for ~/Documents/Teaching/ST213/Code/ThreeStocks/three_stocks.ipynb
Info 20:52:31: Getting preferred kernel for ~/Documents/Teaching/ST213/Code/ThreeStocks/three_stocks.ipynb
Info 20:52:31: Computing working directory ~/Documents/Teaching/ST213/Code/ThreeStocks/three_stocks.ipynb
Info 20:52:31: Starting raw kernel Julia 1.7.0
Info 20:52:31: Kernel launching with ports 9000,9001,9002,9003,9004. Start port is 9000
Info 20:52:31: Launching Raw Kernel & not daemon Julia 1.7.0 # /usr/bin/julia
Info 20:52:31: No custom variables for Kernel as interpreter path is not defined for kernel Julia 1.7.0
Info 20:52:31: Process Execution: > /usr/bin/julia -i --color=yes<EMAIL_ADDRESS>~/.julia/packages/IJulia/e8kqU/src/kernel.jl /tmp/tmp-38695szqAsCYjKpGR.json
> /usr/bin/julia -i --color=yes<EMAIL_ADDRESS>~/.julia/packages/IJulia/e8kqU/src/kernel.jl /tmp/tmp-38695szqAsCYjKpGR.json
Info 20:52:31: Process Execution: cwd: ~/Documents/Teaching/ST213/Code/ThreeStocks
cwd: ~/Documents/Teaching/ST213/Code/ThreeStocks
Warn 20:52:36: Didn't get response for requestKernelInfo after 20ms.
Info 20:52:36: Raw session started and connected
Started kernel Julia 1.7.0
Info 20:52:36: Finished connecting 2bfa5a26-4c23-461a-88fc-441dcf58a08f
Info 20:52:36: Kernel Output: Starting kernel event loops.
Info 20:52:36: Kernel Output: Starting kernel event loops.

Info 20:52:40: Waiting for idle on (kernel): d1ad0c98-1ea6-472d-888b-152e65c15837 -> idle
Info 20:52:40: Finished waiting for idle on (kernel): d1ad0c98-1ea6-472d-888b-152e65c15837 -> idle
Info 20:52:40: IPyWidgetScriptSource.initialize

Thanks for providing the requested information,
Most of us are on a break till the new year.
We'll look into this in Jan.
@rchio I've tested this at my end and am unable to repro this. However that doesn't mean this isn't a bug.

So, I tried again just now and the problem disappeared. It could have been bad Julia packaging, as it got updated yesterday in Arch and it seems ok now. I will continue monitoring it, and if this is the case I will close this ticket.

ok, closing this - after sufficient testing, the issue has "magically" disappeared. Nonetheless, thanks for the prompt response @DonJayamanne.


Email is sent on successful reservation

-now a confirmation email is send on successful reservation
-confirmation email contains all the reservation details
-email is being fetched from kindeAuth
-nodemailer config implemented successfully
-errors are handled using logger

Summary by CodeRabbit
Release Notes

New Features

Users will now receive reservation confirmation emails upon successful booking.
Added email validation for reservation creation.
Introduced an authentication context to manage user email across the application.

Enhancements

Improved the reservation creation process to include email notifications.
Integrated user email handling in the registration process and navigation components.

Bug Fixes

Minor adjustments to ensure user details are fetched correctly upon authentication.

@RamakrushnaBiswal please review my pr issue no #101

@17arindam I will review soon


API to get the file format version of a file at a given path

Needed for the Realm Browser (realm/realm-browser-osx#87) and would probably be useful for some app developers as well. We should discuss if this should be a private or public API.

Do we still need this? Or is the API that explicitly disables file format upgrades sufficient after all?

We haven't received requests for this functionality, so I'd be ok to close this until someone needs it.


Fixed new yaml deprecations

Q
A

Bug fix?
yes

New feature?
no

BC breaks?
no

Deprecations?
no

Fixed tickets
none

Related issues/PRs
none

License
MIT

Documentation PR
none

What's in this PR?
This PR removes the deprecations introduces by the Symfony YAML component to be compatible with the YAML specification.
Why?
In some environment the tests were failing because of that.

@christianbader Could you check if this is working for you?

Closed in favour of https://github.com/sulu/sulu-standard/pull/669


Visualizing BioPaxModels in Python?

I was curious whether there's any ways to visualize a pathway network after loading it as a pybiopax.biopax.model.BioPaxModel? Not sure if visualization is in scope for this package, but a visualization example notebook might mike the models more approachable.
interested as part of https://github.com/openjournals/joss-reviews/issues/4136

That's a great question! I have an initial implementation of a networkx representation for objects (nodes) and references (edges) between them. However, this visualizes the raw OWL structure of the model which is not necessarily useful for seeing the actual reactions with their inputs and outputs. For that, https://github.com/PathwayCommons/chibe is a great tool that allows loading a BioPAX OWL file for visualization.


Update index.md

Link added line 124 resolves https://github.com/MicrosoftDocs/windows-insider/issues/99

@lizap - can you please assist to check, approve and merge the content for this PR based on issue #99?
Thank you.


Prevent DHCP unavailability from failing _get_wire_server_endpoint_address

Mimics https://github.com/ader1990/cloudbase-init-1/commit/2487df0cdff3f4bfa448bed6bcd4edd18be494b6, which is expected to ultimately be merged into the https://github.com/cloudbase/cloudbase-init master branch for later release, at which point we will no longer need this patch.

Meant to open this on my fork, sorry!


Update free-version

Commit Checklist

[x] Remove UNUSED comment code
[x] Remove any logging like console.log
[x] Remove all warnings and errors while build
[x] Check vulnerabilities
[x] Make sure build for production is working. Try running command for prod build in local.
[x] Fix prettier: npx prettier --write .
[x] Fix eslint: npx eslint src\ --fix  command
[x] Push package.lock only if you used npm, push yarn.lock only if you used yarn. NPM will udpate both lock file so make sure you dont push yarn.lock updated by NPM
[ ] WCAG

General

[ ] Follow import structure. module/third-party/files/component/style/types/asset
[ ] Try to use theme for design like palette, typography, variant, components, etc. (don't use custom color code anyhow)
[ ] Before adding custom style follow our pre-built components/elements

@phoenixcoded20
Please review


Text width adjustment fix to stop unwanted wrapping. Maybe OS dependent (OSX)

Because of the tiny size difference between the Figma font and the Tkinter font (could be OSX only, I can't test other platforms), sometime the text will wrap when you don't intend it to.
To test, this Figma file has two single-line text objects side-by-side. For me this renders incorrectly in Tkinter, wrapping the last word onto a second line.
https://www.figma.com/file/hNzdLAhQDcUSxMlq6JtZs3/Untitled?node-id=0%3A1
This fix adds a value to the Text element width equal to the font size which seems to be the best compromise.

@SaptakBhoumik are you using windows ?

@SaptakBhoumik are you using windows ?

No I am on Linux

For me this renders incorrectly in Tkinter, wrapping the last word onto a second line.

After the changes that @neilbaldwin made, I am not facing such issue but now the text is overlapping

Before

After

@ParthJadhav
I will try to fix it after you merge it

@ParthJadhav don't merge yet, I've just noticed it breaks the regular Image element. Will test and fix.

OK this should be better for testing. I've done a few things:

changed the loading code for regular Image elements to do the same X2 export -> 50% scale
added some options in 'constants.py' to select between loading methods. You can choose None, 'PIL' or 'TK'
added the various resampling methods as constants so you can choose between them

I only added the last two things so that we can do more testing. On OSX I found that 'PIL' using ANTIALIAS gives the best results on graphical elements such as button text. I've yet to do some comparissons on regular Image elements. Once we've decided which is the best method we can strip out these options (or leave them as options in the tool for a future feature?) and hard-code the chosen one.

Also, once we're happy with a merge for this feature I will refactor the code as it's a real mess with those IF...ELIF...ELSE sections now. 👍🏻


hls variant not working

    application live {
        live on;
        exec ffmpeg -i rtmp://localhost/$app/$name -async 1 -vsync -1
                    -c:v libx264 -c:a libvo_aacenc -b:v 256k -b:a 32k -vf "scale=480:trunc(ow/a/2)*2" -tune zerolatency -preset veryfast -crf 23 -f flv rtmp://localhost/show/$name_low
                    -c:v libx264 -c:a libvo_aacenc -b:v 768k -b:a 96k -vf "scale=720:trunc(ow/a/2)*2" -tune zerolatency -preset veryfast -crf 23 -f flv rtmp://localhost/show/$name_mid
                    -c:v libx264 -c:a libvo_aacenc -b:v 1024k -b:a 128k -vf "scale=960:trunc(ow/a/2)*2" -tune zerolatency -preset veryfast -crf 23 -f flv rtmp://localhost/show/$name_high
                    -c:v libx264 -c:a libvo_aacenc -b:v 1920k -b:a 128k -vf "scale=1280:trunc(ow/a/2)*2" -tune zerolatency -preset veryfast -crf 23 -f flv rtmp://localhost/show/$name_hd720
                    -c copy -f flv rtmp://localhost/show/$name_src 2>>/tmp/log;
    }

    application show {
        live on;
        hls on;

        # Pointing this to an SSD is better as this involves lots of IO
        hls_path /mnt/hls/;

        # Instruct clients to adjust resolution according to bandwidth
        hls_variant _low BANDWIDTH=288000;
        hls_variant _mid BANDWIDTH=448000;
        hls_variant _high BANDWIDTH=1152000;
        hls_variant _hd720 BANDWIDTH=2048000;
        hls_variant _src BANDWIDTH=4096000;
    }
}

server {
    listen 80;

    location / {
        root /path/to/web_player/;
    }

    location /hls {
        types {
            application/vnd.apple.mpegurl m3u8;
        }

        root /mnt/;
        add_header Cache-Control no-cache;
        add_header Access-Control-Allow-Origin *;
    }
}

I'm trying to stream to rtmp://myserverip/live/ and my http://myserverip/hls/ is empty
My nginx error log when i stream to http://myserverip/show/ :
2016/02/22 02:41:17 [info] 9488#0: *9 connect: app='live' args='' flashver='FMLE/3.0 (compatible; FMSc/1.0)' swf_url='http://<IP_ADDRESS>/live' tc_url='http://<IP_ADDRESS>/live' page_url='' acodecs=0 vcodecs=0 object_encoding=0, client: <IP_ADDRESS>, server: <IP_ADDRESS>:1935 2016/02/22 02:41:17 [info] 9488#0: *9 createStream, client: <IP_ADDRESS>, server: <IP_ADDRESS>:1935 2016/02/22 02:41:17 [info] 9488#0: *9 publish: name='test' args='' type=live silent=0, client: <IP_ADDRESS>, server: <IP_ADDRESS>:1935 2016/02/22 02:41:17 [info] 9488#0: *9 exec: starting managed child 'ffmpeg', client: <IP_ADDRESS>, server: <IP_ADDRESS>:1935 2016/02/22 02:41:17 [info] 9488#0: *10 client connected '<IP_ADDRESS>' 2016/02/22 02:41:17 [info] 9488#0: *10 connect: app='live' args='' flashver='' swf_url='' tc_url='rtmp://localhost/live' page_url='' acodecs=3191 vcodecs=252 object_encoding=0, client: <IP_ADDRESS>, server: <IP_ADDRESS>:1935
And when i stream to  http://myserverip/live/:
2016/02/22 02:41:17 [info] 9488#0: *10 connect: app='live' args='' flashver='' swf_url='' tc_url='rtmp://localhost/live' page_url='' acodecs=3191 vcodecs=252 object_encoding=0, client: <IP_ADDRESS>, server: <IP_ADDRESS>:1935 2016/02/22 02:41:17 [info] 9488#0: *10 createStream, client: <IP_ADDRESS>, server: <IP_ADDRESS>:1935 2016/02/22 02:41:17 [info] 9488#0: *10 play: name='test' args='' start=0 duration=0 reset=0 silent=0, client: <IP_ADDRESS>, server: <IP_ADDRESS>:1935 2016/02/22 02:41:19 [info] 9488#0: *10 deleteStream, client: <IP_ADDRESS>, server: <IP_ADDRESS>:1935 2016/02/22 02:41:19 [info] 9488#0: *10 disconnect, client: <IP_ADDRESS>, server: <IP_ADDRESS>:1935 2016/02/22 02:41:19 [info] 9488#0: *10 deleteStream, client: <IP_ADDRESS>, server: <IP_ADDRESS>:1935
In the ffmpeg log no errors
nginx/1.9.4

Try localhost:1935 in exec ffmpeg command.

I have virtually the same config file, I change to localhost:1935 (even <IP_ADDRESS>:1935) and nothing works

You may not have libvo_aacenc codec in your system change that to aac everywhere in ffmpeg command.

And I hope you changed  _ root /path/to/web_player/;_ and _ hls_path /mnt/hls/;_

the codec was my problem, I am using this :
        exec ffmpeg -i rtmp://localhost/live/$name                 -c:v libx264 -profile:v baseline -b:v 256K -vf "scale=480:trunc(ow/a/2)*2" -f flv -c:a aac -ac 1 -strict -2 -b:a 32k rtmp://localhost/show/$name_low                 -c:v libx264 -profile:v baseline -b:v 768K -vf "scale=800:trunc(ow/a/2)*2" -f flv -c:a aac -ac 1 -strict -2 -b:a 96k rtmp://localhost/show/$name_mid                 -c:v libx264 -profile:v baseline -b:v 1920K -vf "scale=1280:trunc(ow/a/2)*2" -f flv -c:a aac -ac 1 -strict -2 -b:a 128k rtmp://localhost/show/$name_high;
and its working

If it is solved please close the issue.


(clementine) Fix version checks

Description
The version check is stuck on 1.3.1. This change attempts to use the GitHub API to retrieve the latest version.
Motivation and Context
Clementine is stuck on an old version, several years out of date.
How Has this Been Tested?
Executed update.ps1 locally.
Screenshot (if appropriate, usually isn't needed):
Types of changes

[X] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)
[ ] Migrated package (a package has been migrated from another repository)

Checklist:

[X] My code follows the code style of this repository.
[ ] My change requires a change to documentation (this usually means the notes in the description of a package).
[ ] I have updated the documentation accordingly (this usually means the notes in the description of a package).
[ ] I have updated the package description and it is less than 4000 characters.
[X] All files are up to date with the latest Contributing Guidelines
[ ] The added/modified package passed install/uninstall in the Chocolatey Test Environment(https://github.com/chocolatey-community/chocolatey-test-environment/). Note that we don't support the use of any other environment.
[X] The changes only affect a single package (not including meta package).

:white_check_mark: Package verification completed without issues. PR is now pending human review


[CDC|SPI_DEVICE] CDC violation in rv_dm

A CDC violation is detected in rv_dm by the tool as follows.
A signal from main_clk is used for mux select between io_div2_clk signal and io_div4_clk signal.
I am not clear if it's a static path or actual violation.

lc_en is mubi4 type. If prim_mubi4_sync module is used as the synchronizer, it is fine for reconvergence issue.

This signal has similar functionality as the lc_hw_debug_en_i signal on this module.
I.e., this is the latched version coming from the pinmux strap sampling logic via pinmux_hw_debug_en_i.
This uses the prim_lc_sync synchronizer module and the signal should be quasi-static just as  lc_hw_debug_en_i.
Hence it should be ok to waive.

Thanks for confirmation


feat: validation for community report

Implements # 1958

This is working mostly well though if I try and upload a community progress report with the wrong RFI number I get repeated errors that break the bottom of the page:

I added in a check so it doesn't repeat the mismatch error if it's the same wrong ccbc number


Health tool is having incomplete package intro line

$subject

health tools package.md file has the following text;
This project contains an extension implementation for Ballerina CLI that generates Health artifacts from standard specification files.Link
Can this be some issue in the Ballerina central? @azinneera @gayaldassanayake @xlight05

I pulled the tool and the Package.md seems to be broken the text into 2 separate lines.

Need to check if this is happening from the CLI during the bala creation.

@isuruh15 Ballerina Central only displays the very first line of the description in Package.md. However in the case of the health tool, the description is broken into two lines(Link) resulting in only the first line to be shown.
All content intended to be in the central description listed in the package search must be in one line.


Drop Makefile.PL, generated it at ./configure time

Closes #7

NOTE: Makefile.PL is only needed for fetching code from CPAN when using perl-5.8.8 using the stock CPAN.pm module. Perl 5.12 is the oldest Perl version tested by Travis.
Perl 5.12 is also the oldest supported Perl version in linz_bde_uploader
Current Perl version is 5.25. Latest Debian Stable distribution ships 5.20
I still like the idea of having a Makefile.PL, as long as it's generated, because it makes us GNU people happier :)


Database and Schema filter on the explore page does not work properly

Affected module
UI
Describe the bug
When I use Database filter and Schema filter on explore page, it shows wrong table number according to the keyword I search for.
To Reproduce
In this case, I only have 125 tables related to keyword table_1 in OM, but Database and Schema show incorrect result.
https://github.com/user-attachments/assets/d689ade2-c12a-4199-b31d-eafdef737527
Expected behavior
A clear and concise description of what you expected to happen.
Version:

OS: [e.g. iOS]
Python version:
OpenMetadata version: 1.5.2
OpenMetadata Ingestion package version: [e.g. openmetadata-ingestion[docker]==XYZ]

Additional context
Add any other context about the problem here.

Will be available with 1.6 release


Is AirbrakeNotifier thread-safe?

I don't see any mention of this in the documentation. I'm defensively passing around an instance of AirbrakeConfig around to help create instances of AirbrakeNotifier for services that need it.

It should be safe to use the same instance of the notifier across multiple threads. Please let me know if you find any issues with that. Thanks.


How to debug logtrail?

To start with: thank you for this plugin. It is fantastic (having seen it on oth systems).
I cannot have it visulatize my logs though.

How should I approach the debugging?
Note: the normal Kibana query (via Discover) works fine, the example record was actually dumped via a _search call to Elasticsearch

@wsw70 Can you try the logtail.json present here? - https://github.com/sivasamyk/logtrail/blob/master/logtrail.json

Logtrail expects field mapped to hostname should be of type keyword. The default logstash/filebeat template creates a keyword field by appending .keyword to the field name. In case of custom mapping use can configure the keyword suffix using keyword_suffix field.


Time format "yyyyMMdd.HHmmss.mmm" or "yyyyMMdd.HHmmss.SSS" ?

Hi,
Many zAppbuild scripts use the formatting string yyyyMMdd.HHmmss.mmm to format a date-time, but shouldn't the string yyyyMMdd.HHmmss.SSS be used instead?
mmm does not stand for "microsecond", unlike SSS, (S for fraction of second).
Confer SimpleDateFormat patterns.

Yes, I think you're right. I never noticed that before...
In some examples I've seen on our environment:
Build start at 20230911.043529.035
The last part 035 is actually the minutes on 3 digits, as we see the same minutes in 043529. I've check on other builds and it's always the same...
We'll work on a fix for the next release!
Thank for reporting that problem @FALLAI-Denis !


Package OSRM as a JLL

This would vastly ease installation.

See https://github.com/JuliaPackaging/Yggdrasil/pull/6106 :)

I'm working on the binary package for OSRM because I saw your issue (which I came across after running into your discrete choice package). Mainly want to package it for the fun of it, but also because I want to have broad access to OSM tools via Julia for side projects. :)
tldr, no but definitely happy you are building OSRM.jl!

Oh wow, thanks! I'd love to hear what you're working on sometime.


finalize profiles/search/dashboard/multiple authentication

finalize profiles/search/dashboard/multiple authentication

finalize profiles/search/dashboard/multiple authentication