verify_examples is broken on v1.18

verify_examples for cache and dynamic-config-cp are both broken on v1.18. I tried to cargo-cult my way around these issues in #20223 but wasn't able to get it across the finish line.
https://dev.azure.com/cncf/4684fb3d-0389-4e0b-8251-221942316e06/_apis/build/builds/103180/logs/249

@oschaaf can you take a look at this with your Release Manager hat on?

not sure why this didnt close - but i think the issue is resolved


Make adapter ready for Admin v3

For Admin3 some changes are needed: see http://forum.iobroker.net/viewtopic.php?f=24&t=10268

https://github.com/ioBroker/ioBroker.ical/commit/cdce3b694fb057c149e24fa999e8ded91fe6458e


feat: New Apis for Snap

This PR updates the dependencies required to update the Apis, implement homepage and lifecycle hooks

@ShubhamParkhi just tested it. Looks good, just a few comments:

The deeplink works well!
For the onInstall page, I'm suggesting to change "Domain: Which domain(s) is this contract interacted in?" to "Domain: Whether this contract is known to be used on this domain"
For the original CDN result, I'm thinking we can add custom logic for blockchain explorers, such that if domain is one of these, we don't show the deeplink message, as users may accidentally submit the suggest and get challenged.
For the onUpdate hook, currently I see that the text is empty. Is it meant to show something?

Tested again and the fixes above are good.   @ShubhamParkhi
one last thing: i think now the suggestion to submit the CDN entry is shown when no insights are available but I think we can make it it's also shown when it's not one of the explorer domains AND if the CDN insight is not present (rather than only when no insights are present).


Silence Logging by default

By default this library sets the silence_logging config to false which causes the developer logs to be polluted by default. (a single sql query for every request). I propose that that this should be an opt in mode. This PR changes the default.
here is an example of what the developer sees upon initial installation.
web    |   SolidQueue::ScheduledExecution Pluck (5.3ms)  SELECT "solid_queue_scheduled_executions"."job_id" FROM "solid_queue_scheduled_executions" WHERE "solid_queue_scheduled_executions"."scheduled_at" <= $1 ORDER BY "solid_queue_scheduled_executions"."scheduled_at" ASC, "solid_queue_scheduled_executions"."priority" ASC LIMIT $2 FOR UPDATE SKIP LOCKED  [["scheduled_at", "2024-02-06 13:48:23.493518"], ["LIMIT", 500]]
web    |   TRANSACTION (0.6ms)  COMMIT
web    |   SolidQueue::Pause Pluck (1.9ms)  SELECT "solid_queue_pauses"."queue_name" FROM "solid_queue_pauses"
web    |   TRANSACTION (0.9ms)  BEGIN
web    |   SolidQueue::ReadyExecution Pluck (2.9ms)  SELECT "solid_queue_ready_executions"."job_id" FROM "solid_queue_ready_executions" ORDER BY "solid_queue_ready_executions"."priority" ASC, "solid_queue_ready_executions"."job_id" ASC LIMIT $1 FOR UPDATE SKIP LOCKED  [["LIMIT", 5]]
web    |   TRANSACTION (1.4ms)  COMMIT
web    |   SolidQueue::Pause Pluck (1.8ms)  SELECT "solid_queue_pauses"."queue_name" FROM "solid_queue_pauses"
web    |   TRANSACTION (1.2ms)  BEGIN
web    |   SolidQueue::ReadyExecution Pluck (5.9ms)  SELECT "solid_queue_ready_executions"."job_id" FROM "solid_queue_ready_executions" ORDER BY "solid_queue_ready_executions"."priority" ASC, "solid_queue_ready_executions"."job_id" ASC LIMIT $1 FOR UPDATE SKIP LOCKED  [["LIMIT", 5]]
web    |   TRANSACTION (0.6ms)  COMMIT
web    |   SolidQueue::Pause Pluck (1.5ms)  SELECT "solid_queue_pauses"."queue_name" FROM "solid_queue_pauses"
web    |   TRANSACTION (0.4ms)  BEGIN
web    |   SolidQueue::ReadyExecution Pluck (2.1ms)  SELECT "solid_queue_ready_executions"."job_id" FROM "solid_queue_ready_executions" ORDER BY "solid_queue_ready_executions"."priority" ASC, "solid_queue_ready_executions"."job_id" ASC LIMIT $1 FOR UPDATE SKIP LOCKED  [["LIMIT", 5]]
web    |   TRANSACTION (0.6ms)  COMMIT
web    |   SolidQueue::Pause Pluck (0.8ms)  SELECT "solid_queue_pauses"."queue_name" FROM "solid_queue_pauses"
web    |   TRANSACTION (0.3ms)  BEGIN
web    |   SolidQueue::ReadyExecution Pluck (1.7ms)  SELECT "solid_queue_ready_executions"."job_id" FROM "solid_queue_ready_executions" ORDER BY "solid_queue_ready_executions"."priority" ASC, "solid_queue_ready_executions"."job_id" ASC LIMIT $1 FOR UPDATE SKIP LOCKED  [["LIMIT", 5]]
web    |   TRANSACTION (0.3ms)  COMMIT
web    |   SolidQueue::Pause Pluck (3.2ms)  SELECT "solid_queue_pauses"."queue_name" FROM "solid_queue_pauses"
web    |   TRANSACTION (0.7ms)  BEGIN
web    |   SolidQueue::ReadyExecution Pluck (2.2ms)  SELECT "solid_queue_ready_executions"."job_id" FROM "solid_queue_ready_executions" ORDER BY "solid_queue_ready_executions"."priority" ASC, "solid_queue_ready_executions"."job_id" ASC LIMIT $1 FOR UPDATE SKIP LOCKED  [["LIMIT", 5]]
web    |   TRANSACTION (0.7ms)  COMMIT
web    |   SolidQueue::Pause Pluck (2.0ms)  SELECT "solid_queue_pauses"."queue_name" FROM "solid_queue_pauses"
web    |   TRANSACTION (0.6ms)  BEGIN
web    |   SolidQueue::ReadyExecution Pluck (2.2ms)  SELECT "solid_queue_ready_executions"."job_id" FROM "solid_queue_ready_executions" ORDER BY "solid_queue_ready_executions"."priority" ASC, "solid_queue_ready_executions"."job_id" ASC LIMIT $1 FOR UPDATE SKIP LOCKED  [["LIMIT", 5]]
web    |   TRANSACTION (0.5ms)  COMMIT
web    |   SolidQueue::Pause Pluck (0.9ms)  SELECT "solid_queue_pauses"."queue_name" FROM "solid_queue_pauses"
web    |   TRANSACTION (0.4ms)  BEGIN
web    |   SolidQueue::ReadyExecution Pluck (2.0ms)  SELECT "solid_queue_ready_executions"."job_id" FROM "solid_queue_ready_executions" ORDER BY "solid_queue_ready_executions"."priority" ASC, "solid_queue_ready_executions"."job_id" ASC LIMIT $1 FOR UPDATE SKIP LOCKED  [["LIMIT", 5]]
web    |   TRANSACTION (0.4ms)  COMMIT
web    |   SolidQueue::Pause Pluck (1.8ms)  SELECT "solid_queue_pauses"."queue_name" FROM "solid_queue_pauses"
web    |   TRANSACTION (0.6ms)  BEGIN
web    |   SolidQueue::ReadyExecution Pluck (2.1ms)  SELECT "solid_queue_ready_executions"."job_id" FROM "solid_queue_ready_executions" ORDER BY "solid_queue_ready_executions"."priority" ASC, "solid_queue_ready_executions"."job_id" ASC LIMIT $1 FOR UPDATE SKIP LOCKED  [["LIMIT", 5]]

@rosa Why do the tests fail here if I have no touched the gemfile?

@rosa Why do the tests fail here if I have no touched the gemfile?

Because of an unrelated problem, already fixed in ef42e6ade8b1f6c73214e74de58e74a1130715b5, so no worries about it.

@rosa I have updated the read me 😄


adds FMbell

Something I was working on last year and forgot about. This may be able to be refactored so it uses less components, but I really like how it ended up sounding. Try adding a curve to the modulation index from 10 to 1 over the life of the note, or playing with the harmonicity on a curve. I think it has lots of potential for many different sounds!
The one thing I struggle with is this is a percussive sound but it's pitched, so right now "note" length is dictated by the decay value on the envelopes and the sustain is set to 0. Curious about what you think about this.

Used this as reference for both the MetalSynth and the FMOscillator so thanks. In retrospect, i should have merged your changes and then altered them so that you would have gotten due github credit. Sorry about that.


feat: add ESS redirect factory

:tada: This PR is included in version 1.3.0 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


Better type checking on model constructor

https://codesandbox.io/s/mobx-keystone-typings-yo2rs?file=/src/index.tsx:0-179
Currently there no ts error if some object with exta fields is passed to model constructor, but there is runtime error, which even don't report about these extra fields. It's not really good when model created with some external type (such as server data), I spent hour, trying to understand about it.

There is some tricks to do so https://fettblog.eu/typescript-match-the-exact-object-shape/
But it's not working with keystone, because ModelInstanceCreationData<Mod> has no exact shape.

Blame typescript :/
function f(data: { value: number }) { }

const tt = { value: 0, a: 1 }
f(tt) // ok

f({value: 0, a: 1}) // error, a should not be there

same happens if you use new with an object vs new with a literal.
Maybe you could try to type t
const t: SnapshotInOf<Mod> = { value: 0, a: 1 }; // a should not be there
new Mod(t); //runtime error

Edit: Thanks for the heads up, I'll check the article and see if I can use that :D

I think the runtime error should be more specific, for pure js users it will be helpful.
Also maybe there is some ts trick to make compilation error more detailed (not just turn arg into never). I try to dig into it.

Maybe you could try to type t

It's not really working for me, actually, in WebStorm:
const m: ModelInstanceCreationData<Message> = {}  //m has any type

If open BaseModel.d.ts in codesandbox, there is ts errors:
A computed property name in a class property declaration must refer to an expression whose type is a literal type or a 'unique symbol' type.ts(1166)
Cannot find name 'propsDataTypeSymbol'.ts(2304)

Also, in ts 3.9 there is ts-expect-error feature, it can be really good for typings tests!

Thank you!


Break Out Webhooks file

I want to add a webhook integration into Zulip. I think that the webhooks.py file is getting really messy though. Does anyone else think it's a good idea to split them out into individual files by service?

Yeah I think it'd be very reasonable to split them into individual files by service.
If you decide to do this while you're at it, please do it in a way that is easy to review (i.e. one commit per service, and make no changes to the actual code in those commits -- just move it to the new file and adjust imports).

@nVitius were you interested in doing this splitting work or should I take care of it when I get a chance?

Also if while you're at it, you want to record what you're doing as a draft solution for #70 , that'd be awesome.

Yeah, I'll do it. I've been a bit busy with work this past week but I will make time to do it this weekend. I haven't done much with Python before, so this would be a good opportunity.

This was done a couple weeks ago in #513!


NotADirectoryError during evaluate the model with "dasg evaluate './exp-swda-longformer-512/checkpointepoch=6.ckpt' --device cuda -b 1 -o exp-swda-longformer-512/results.pkl -v"

Hi, I tried to run model as the "Running the experiments" in readme.md
the model trained successfully and saved the best checkpoint(epoch 6), but when i evaluate on the test set, I got the following error, may I know how to solve it?
Traceback (most recent call last):
File "/Work/daseg/daseg/models/transformer_model.py", line 34, in from_path
return TransformerModel.from_pl_checkpoint(model_path, device)
File "/Work/daseg/daseg/models/transformer_model.py", line 76, in from_pl_checkpoint
del ckpt['state_dict'][k]
KeyError: 'model.longformer.pooler.dense.weight'
During handling of the above exception, another exception occurred:
Traceback (most recent call last):
File "/home/anaconda3/envs/daseg/bin/dasg", line 7, in
exec(compile(f.read(), file, 'exec'))
File "/Work/daseg/daseg/bin/dasg", line 351, in
cli()
File "/home/anaconda3/envs/daseg/lib/python3.8/site-packages/click/core.py", line 1128, in call
return self.main(*args, **kwargs)
File "/home/anaconda3/envs/daseg/lib/python3.8/site-packages/click/core.py", line 1053, in main
rv = self.invoke(ctx)
File "/home/anaconda3/envs/daseg/lib/python3.8/site-packages/click/core.py", line 1659, in invoke
return _process_result(sub_ctx.command.invoke(sub_ctx))
File "/home/anaconda3/envs/daseg/lib/python3.8/site-packages/click/core.py", line 1395, in invoke
return ctx.invoke(self.callback, **ctx.params)
File "/home/anaconda3/envs/daseg/lib/python3.8/site-packages/click/core.py", line 754, in invoke
return __callback(*args, **kwargs)
File "/Work/daseg/daseg/bin/dasg", line 73, in evaluate
model = TransformerModel.from_path(Path(model_path), device=device)
File "/Work/daseg/daseg/models/transformer_model.py", line 46, in from_path
**json.load(open(Path(model_path) / 'tokenizer_config.json'))
NotADirectoryError: [Errno 20] Not a directory: 'exp-swda-longformer-512/checkpointepoch=6.ckpt/tokenizer_config.json'

The actual issue is in the first exception, loading the checkpoint failed. Can you try commenting out the following lines to see if it helps?
https://github.com/pzelasko/daseg/blob/5e3aaf6e81a44a5eb42226bd376c92c7d1879261/daseg/models/transformer_model.py#L70-L76

Hi, thanks for your quick reply! It now evalute successful, but got a new error when generte the result.pkl file. The exception is as follows:
(daseg) user@dialog:/Work/daseg$ dasg evaluate 'exp-swda-longformer-512/checkpointepoch=6.ckpt' --device cuda -b 1 -o exp-swda-longformer-512/results.pkl -v
huggingface/tokenizers: The current process just got forked, after parallelism has already been used. Disabling parallelism to avoid deadlocks...
To disable this warning, you can either:

Avoid using tokenizers before the fork if possible
Explicitly set the environment variable TOKENIZERS_PARALLELISM=(true | false)
huggingface/tokenizers: The current process just got forked, after parallelism has already been used. Disabling parallelism to avoid deadlocks...
To disable this warning, you can either:
Avoid using tokenizers before the fork if possible
Explicitly set the environment variable TOKENIZERS_PARALLELISM=(true | false)
huggingface/tokenizers: The current process just got forked, after parallelism has already been used. Disabling parallelism to avoid deadlocks...
To disable this warning, you can either:
Avoid using tokenizers before the fork if possible
Explicitly set the environment variable TOKENIZERS_PARALLELISM=(true | false)
huggingface/tokenizers: The current process just got forked, after parallelism has already been used. Disabling parallelism to avoid deadlocks...
To disable this warning, you can either:
Avoid using tokenizers before the fork if possible
Explicitly set the environment variable TOKENIZERS_PARALLELISM=(true | false)
Iterating batches: 19it [00:02,  8.65it/s]
SKLEARN_METRICS:
micro_f1  96.58%
macro_f1  60.05%
micro_f1_common_I 96.58%
macro_f1_common_I 60.05%
SEQEVAL_METRICS:
precision 80.84%
recall  78.75%
f1  79.79%
accuracy  96.58%
ZHAO_KAWAHARA_METRICS:
DSER  8.96%
SegmentationWER 12.97%
DER 30.82%
JointWER  36.30%
ORIGINAL_ZHAO_KAWAHARA_METRICS:
DER 17.87%
JointWER  27.40%
macro_f1  60.05%
micro_f1  96.58%
DSER  7.65%
SegmentationWER 14.28%
ARGS:
Traceback (most recent call last):
File "/home/anaconda3/envs/daseg/bin/dasg", line 7, in
exec(compile(f.read(), file, 'exec'))
File "/Work/daseg/daseg/bin/dasg", line 351, in
cli()
File "/home/anaconda3/envs/daseg/lib/python3.8/site-packages/click/core.py", line 1128, in call
return self.main(*args, **kwargs)
File "/home/anaconda3/envs/daseg/lib/python3.8/site-packages/click/core.py", line 1053, in main
rv = self.invoke(ctx)
File "/home/anaconda3/envs/daseg/lib/python3.8/site-packages/click/core.py", line 1659, in invoke
return _process_result(sub_ctx.command.invoke(sub_ctx))
File "/home/anaconda3/envs/daseg/lib/python3.8/site-packages/click/core.py", line 1395, in invoke
return ctx.invoke(self.callback, **ctx.params)
File "/home/anaconda3/envs/daseg/lib/python3.8/site-packages/click/core.py", line 754, in invoke
return __callback(*args, **kwargs)
File "/Work/daseg/daseg/bin/dasg", line 93, in evaluate
slack.write_and_print(f'{key}\t{val:.2%}')
ValueError: Unknown format code '%' for object of type 'str'

I think it should work if you replace:
slack.write_and_print(f'{key}\t{val:.2%}')

with
if isinstance(val, float):
    slack.write_and_print(f'{key}\t{val:.2%}')
else:
    slack.write_and_print(f'{key}\t{val}')

in file /Work/daseg/daseg/bin/dasg
(I'll try to commit the changes from this thread sometime later)

the code runs well, thanks :)

Hey I had the same sequence of issues and it now runs successfully after following this thread so I think it's time to push these fixes in a new commit and thank you for your great work :-)

Right, I’ll find a moment to do the updates. Thanks for the feedback!

Should be working now, thanks for reporting the issues.


Add Java helper code for establishing binder transport connection

These Java code will be invoked by binder transport C++ implementation
through JNI to establish the connection between client and server.
The code is locally tested with other pending changes to make sure it
works correctly.
For now we only make sure it builds in CI. We will port proper tests
from internal repository later.

cc @TaWeiTu @napathome
Will ask for review from Nicolas after you guys' review

Note: Before merging this, we will need to add a simple replace rule to copy.bara.sky to replace @build_bazel_rules_android// in the BUILD file in this CL

Can you talk about what the new WORKSPACE file is for?

Since this specific BUILD file will need Android SDK/NDK properly configured to build, we put it into a local_repository so that the ... expansion in bazel will exclude this BUILD file.
Without this local_repository trick, scripts like gen_compilation_database.py will fail because it will consider the load statement in the BUILD file a failure.
Other than the purpose of avoiding bazel failure, I think creating local_repository makes some sense because it is Android only Java code (and will be compiled separately) which we want to avoid it interfere with the rest of gRPC core.
(Oops I thought I documented in the WORKSPACE file but the change is lost, will add it back if this approach is ok)

I'm going to leave the ok question up to @nicolasnoble but yeah let's at least add some documentation here.

Hah, yeah, that's a good trick to avoid the ... breakage, but I'm not 100% sure about how this will look on import. We should trigger the test for it.

We have done a copybara import and it looks good. I believe the WORKSPACE files in grpc directory are not used in google's internal repository. On top of that, in our internal repository people don't need to configure Android SDK because it is already configured in the source tree.
I guess let's merge and see? We can always revert this if we find out non trivial issue during daily copybara import


Fix: convert DataFrame to ndarray for Explanation.data

Overview
Closes https://github.com/shap/shap/issues/1625
Description of the changes proposed in this pull request:
Convert DataFrame to ndarray for Explanation.data in a KernelExplainer, when for some reason, X is a DataFrame.
Explanation.data being a DataFrame causes problems later, at the plotting stage.
Checklist

[x] All pre-commit checks pass.
[ ] Unit tests added (if fixing a bug or adding a new feature)

@thatlittleboy good point. I will try to work on it this evening and let you know ASAP if I succeed to understand the testing structure and adding this.

Adding the test test_kernel_shap_with_dataframe_explaination.
This is how the code would fail if my correction was commented (top panel), reproducing the error of the issue

With my correction the test runs smoothly!


Error while saving a new paste in self hosted instance

Error: ERR_CRYPTO_INVALID_KEYLEN
While: Saving a Paste
Key: "randomkey124kd"
Instance: Self Hosted
Strategy: File

Hello!
The key's length needs to be exactly 32 bytes. I should probably document this better somewhere.

Ok thank you


How to change icon??

help pls...

open your walnut app in visual studio... press ctrl+shift+e, this will bring up resource view... now select walnnutapp on the left, right click that and add->resource... this will create an icon1.ico in your walnutapp folder. you can edit that file any way you like as long as you don't rename it, it has mutlple layers that are for different resolutions that you need to pay attention to.

if you decide you want to rename the file make sure visual studio is aware of it or you will lose the linking to it and it won't display.

replace the image file with same name, same resolution.

I wrote a Python script to convert a PNG to a Walnut-Icon.embed file that you can replace in Platform/GUI/Walnut/Embed
https://gist.github.com/auzden/9bea709c4fb1985849a3dcc46cdcb4e4


Add proposal process

What type of PR is this?
kind/documentation
What this PR does / why we need it:

Creates a proposal process through this repo
Changes to proposals / design docs can be tracked through git
Adds template with instructions (inspired by KEP/ADRs)
Helps to deprecate the design doc (which doesn't scale well)

Which issue(s) this PR fixes:

https://github.com/cncf-tags/green-reviews-tooling/issues/47
Special notes for your reviewer (optional):
Please let me know what you think about creating a proposal process through this repository. It's similar to the KEP process in Kubernetes or ADRs which is widely used in OSS. Going through git would allow a better tracking of the history of proposals and how they change. It would also help to have discussions on individual points via PRs.

Hi

Having some kind of design document with the usual questions is a good change. The KEP template is quite extensive. We will see which sections will make sense once we use it a few times. Lets try this out and make adjustments if needed.


Add force_download to snapshot_download

Fix https://github.com/huggingface/huggingface_hub/issues/1383.

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint.


Please update version to 0.4.3

Hi, thanks for your work on jenv, it is really helpful.
For the jenv Homebrew formula to be updated and include the latest corrections on some plugins, could you please bump a new version? The current formula points to the latest release: 0.4.2 (oct 2014). I can take care of updating the formula.
Thanks in advance,
et je boirai une Rochefort à ta santé :)
Romain

Tag is done. Do you want to update the formula? :)

Gildas, please check #99

Done ! Thanks

Et une rochefort, une !

@gcuisinier, for your information, homebrew has merged 0.4.3: https://github.com/Homebrew/homebrew/pull/40473


Ability to use use a proxy

Expected Behavior
I saw there was a commit for adding proxies to the bot but it got reverted :( could we get this added? Would be awesome!
Actual Behavior
Able to pass a proxy via command/config
Steps to Reproduce
Other Information
OS:
Git Commit: (run 'git log -n 1 --pretty=format:"%H"' and paste it here)
Python Version: (run 'python -V' and paste it here)

Install proxychains.
Then just do proxychains ./pokecli
No need to inbuilt proxy

@ddrght12345 so say I have a bash file that spins up bots, how would i use proxychains with this? (sorry I've never used proxychains)
I've tried proxychains ./start.sh already

@ddrght12345 i'm not very familiar with running proxies on a server for a python script. Do you have any suggestions to which one to use on an Ubuntu 15.04 alongside the bot?

@firzzen example: nohup proxychains python pokecli.py -a ptc -u "$1" -p "$2" -l "$3" After installing proxychains using apt-get install proxychains then add your proxies into the /etc/proxychains.conf file

thanks @Unsworth94 , that helps a lot.

@Unsworth94 i understand that proxychains offers dynamic, static or random proxy usage. But what if you're running five bots at the same time? Can you use different configs for proxychains for different bots?
One option would be to use proxychains random proxy so it cycles them each time but that would look bad if you login from different locations every day, or even worse when the bot crashes and you have to login again 5 minutes after initially starting it.

@firzzen yes, you pass -f /path/to/file/proxychains-xxxx.conf to the proxychains command.
Example: proxychains -f /path/to/file/proxychains-xxxx.conf  python pokecli.py -a ptc -u "$1" -p "$2" -l "$3"

@Unsworth94 Trying to run the script with proxychains -f /etc/proxychains.conf python pokecli.py -cf ./configs/config.json results in:
ProxyChains-3.1 (http://proxychains.sf.net)
/usr/bin/proxychains: 9: exec: -f: not found

Check the documentation https://github.com/haad/proxychains

Thanks @Unsworth94 . The suggestion might seem very straightforward and basic but now i actually focused into the instructions and realized that you copied commands for secondary config files, not the default one :).

Oh I thought that's what you was after! Sorry!

What's the solution for windows?


Clean up/externalize angular-directives

Some directives are not used anymore, some are better externalized as they may be useful in other projects.

See angular-vissense.


Lots more Brests :)

Take a look:
https://www.openstreetmap.org/node/4815354290
https://www.openstreetmap.org/relation/6961113
https://www.openstreetmap.org/relation/6423260
https://www.openstreetmap.org/relation/6791494
https://www.openstreetmap.org/relation/72615

@alexriabtsev Nice! Thank you. Would you be up for submitting a PR for these?


lack of dataset file

could you upload the dataset file?Please~~~~~ Dear professor

If the links fail to redirect, please download the corresponding data and pretrained model weights from: http://prnet.drai.cn/Statistics/. For the data files, download LINCS L1000 Chemical Perturbations and Sci-plex Chemical Perturbations from the Supplementary Dataset section. For the model weights, download the PRnet model from the Supplementary Dataset section.

Hello, where is the data: FDA_drug_fold-change_2W.csv

If the links fail to redirect, please download the corresponding data and pretrained model weights from: http://prnet.drai.cn/Statistics/. For the data files, download LINCS L1000 Chemical Perturbations and Sci-plex Chemical Perturbations from the Supplementary Dataset section. For the model weights, download the PRnet model from the Supplementary Dataset section.  Then change the names of the datasets to Lincs_L1000.h5ad and Sci_Plex.h5ad respectively. If the dataset cannot be downloaded, please adjust your browser settings to allow insecure content on the current webpage by setting it to "Allow."

I would like to find a similar molecule to my small molecule (I had transcriptomics data) using the PRnet. How can I do it?

Hello, where is the data: FDA_drug_fold-change_2W.csv

Please download the corresponding data from: http://prnet.drai.cn/Statistics/.  ‘FDA_drug_fold-change_2W.csv’:  download the FDA-approved Drugs Signatures from the PRnet Predicted Transcriptional Signatures section.

I would like to find a similar molecule to my small molecule (I had transcriptomics data) using the PRnet. How can I do it?

I don't quite understand, could you describe it in more detail?

I would like to find a similar molecule to my small molecule (I had transcriptomics data) using the PRnet. How can I do it?

I don't quite understand, could you describe it in more detail?

I have transcriptome and structural data of a small molecule, and I want to find similar molecules for target screening using the PRnet method

I would like to find a similar molecule to my small molecule (I had transcriptomics data) using the PRnet. How can I do it?

I don't quite understand, could you describe it in more detail?

I have transcriptome and structural data of a small molecule, and I want to find similar molecules for target screening using the PRnet method

To prepare your dataset for a new small molecule, please refer to the instructions in custom_data_preprocessing.ipynb. Once your dataset is ready, you can predict the perturbed expression profile by running test_demo.py, adjusting the split_key argument as needed for your analysis.
If you’re interested in other applications or discussing potential collaborations, please feel free to reach out at<EMAIL_ADDRESS>


small benchmark (chi vs httprouter)

the code is extracted from https://github.com/julienschmidt/go-http-routing-benchmark

thank you for this! it inspired me to make a full benchmark suite at https://github.com/pkieltyka/go-http-routing-benchmark and posted the results at https://github.com/pressly/chi#benchmarks


Add search media by place id feature

In the media methods there is no option to search for media by instagram place id. This would be very useful for researchers and should be fairly easy to implement. Thanks!

@Sebsebzen added search medias by location for public (_a1) API
this week I will add work through a private api too


Faster k-way merging using tournament trees, 8-byte key strides.

Two speedups for FrameChannelMerger (which does k-way merging in MSQ):

Replace the priority queue with a tournament tree, which does fewer comparisons.

Compare keys using 8-byte strides, rather than 1 byte at a time.

Benchmarks below. In these benchmarks:

keys can be random (20 random characters) or sequential (incrementing numbers stored as zero-padded strings, like '00000000000000000001', '00000000000000000002', etc).
rows can be distributed round_robin across channels (first key to first channel, second key to second channel, etc) or clustered (first N keys to first channel, next N keys to second channel, etc).

Findings:

The tournament tree and priority queue are about the same speed when there are two channels, but for 16 channels, the tournament tree is ~30% faster. Presumably this is due to doing fewer comparisons.
8-byte strides give a ~5% speedup when there are two channels.  Presumably this is due to 16 channels requiring more comparisons, so there's more opportunities for the longer stride to make a difference.
Overall, combining tournament trees and 8-byte strides gives a ~5% speedup for two channels, and ~40% speedup for 16 channels.

master (priority queue, 1 byte stride)

Benchmark                                  (channelDistributionString)  (keyGeneratorString)  (keyLength)  (numChannels)  (numRows)  (rowLength)  Mode  Cnt     Score    Error  Units
FrameChannelMergerBenchmark.mergeChannels                  round_robin                random           20              2    5000000          100  avgt    5   662.988 ± 39.567  ms/op
FrameChannelMergerBenchmark.mergeChannels                  round_robin                random           20             16    5000000          100  avgt    5  1513.897 ± 45.425  ms/op
FrameChannelMergerBenchmark.mergeChannels                  round_robin            sequential           20              2    5000000          100  avgt    5   764.784 ± 29.506  ms/op
FrameChannelMergerBenchmark.mergeChannels                  round_robin            sequential           20             16    5000000          100  avgt    5  2209.931 ± 31.880  ms/op
FrameChannelMergerBenchmark.mergeChannels                    clustered                random           20              2    5000000          100  avgt    5   677.862 ± 28.828  ms/op
FrameChannelMergerBenchmark.mergeChannels                    clustered                random           20             16    5000000          100  avgt    5  1530.103 ± 80.132  ms/op
FrameChannelMergerBenchmark.mergeChannels                    clustered            sequential           20              2    5000000          100  avgt    5   664.240 ± 13.360  ms/op
FrameChannelMergerBenchmark.mergeChannels                    clustered            sequential           20             16    5000000          100  avgt    5  1424.895 ± 24.168  ms/op

tournament tree, 1 byte stride

Benchmark                                  (channelDistributionString)  (keyGeneratorString)  (keyLength)  (numChannels)  (numRows)  (rowLength)  Mode  Cnt     Score    Error  Units
FrameChannelMergerBenchmark.mergeChannels                  round_robin                random           20              2    5000000          100  avgt    5   652.683 ± 21.292  ms/op
FrameChannelMergerBenchmark.mergeChannels                  round_robin                random           20             16    5000000          100  avgt    5  1123.421 ± 33.857  ms/op
FrameChannelMergerBenchmark.mergeChannels                  round_robin            sequential           20              2    5000000          100  avgt    5   766.496 ± 23.514  ms/op
FrameChannelMergerBenchmark.mergeChannels                  round_robin            sequential           20             16    5000000          100  avgt    5  1428.470 ± 38.184  ms/op
FrameChannelMergerBenchmark.mergeChannels                    clustered                random           20              2    5000000          100  avgt    5   682.236 ±  9.466  ms/op
FrameChannelMergerBenchmark.mergeChannels                    clustered                random           20             16    5000000          100  avgt    5  1126.613 ± 25.387  ms/op
FrameChannelMergerBenchmark.mergeChannels                    clustered            sequential           20              2    5000000          100  avgt    5   659.716 ± 17.220  ms/op
FrameChannelMergerBenchmark.mergeChannels                    clustered            sequential           20             16    5000000          100  avgt    5   897.766 ± 54.850  ms/op

tournament tree, 8-byte stride

Benchmark                                  (channelDistributionString)  (keyGeneratorString)  (keyLength)  (numChannels)  (numRows)  (rowLength)  Mode  Cnt     Score    Error  Units
FrameChannelMergerBenchmark.mergeChannels                  round_robin                random           20              2    5000000          100  avgt    5   602.409 ±  0.754  ms/op
FrameChannelMergerBenchmark.mergeChannels                  round_robin                random           20             16    5000000          100  avgt    5   943.311 ±  4.090  ms/op
FrameChannelMergerBenchmark.mergeChannels                  round_robin            sequential           20              2    5000000          100  avgt    5   742.581 ±  3.323  ms/op
FrameChannelMergerBenchmark.mergeChannels                  round_robin            sequential           20             16    5000000          100  avgt    5  1295.109 ±  3.081  ms/op
FrameChannelMergerBenchmark.mergeChannels                    clustered                random           20              2    5000000          100  avgt    5   599.162 ±  1.119  ms/op
FrameChannelMergerBenchmark.mergeChannels                    clustered                random           20             16    5000000          100  avgt    5   957.285 ±  1.253  ms/op
FrameChannelMergerBenchmark.mergeChannels                    clustered            sequential           20              2    5000000          100  avgt    5   648.640 ±  6.003  ms/op
FrameChannelMergerBenchmark.mergeChannels                    clustered            sequential           20             16    5000000          100  avgt    5   761.045 ± 25.297  ms/op

This test is the only one failing:
standard-its / integration-query-tests-middleManager (security) / security integration test (Compile=jdk8, Run=jdk8, Indexer=middleManager, Mysql=com.mysql.jdbc.Driver)

I don't think it's related to this patch, and I've seen it be flaky in other PRs recently, so I'll merge this.

Would the tournament trees be useful in other places where k-way merge is used like the MergeSequence

Would the tournament trees be useful in other places where k-way merge is used like the MergeSequence

Probably, yes.


Create a function to extract default az subnets

Description
Adding a new function to extract default az subnets from a vpc.
Need this change for https://github.com/gruntwork-io/terraform-aws-data-storage/pull/281 - fixing tests in data storage module.
Testing

sanity check unit test
manually tested with us-west-2 and confirmed it returning only default az subnets.

Note: TestGetDefaultSubnetIDsForVpc test has been failing in master branch (not related to this PR).

TODOs
Read the Gruntwork contribution guidelines.

[x] Update the docs.
[x] Run the relevant tests successfully, including pre-commit checks.
[x] Ensure any 3rd party code adheres with our license policy or delete this line if its not applicable.
[x] Include release notes. If this PR is backward incompatible, include a migration guide.

Release Notes (draft)

Added / Removed / Updated [X].
Added [A new method to get default az subnets]
Migration Guide

Looks like source branch should be rebased on top of last changes in master:
[INFO] Initializing environment for https://github.com/gruntwork-io/pre-commit.
goimports................................................................Failed
- hook id: goimports
- files were modified by this hook

modules/docker/docker_compose_test.go

Terraform fmt............................................................Passed
test-interfaces-used.....................................................Passed

Exited with code exit status 1


Fix voters block (todo in code) & make it look better

I'ts me again ;)
So there was this todo in the address.component.html to mege the two voters block.
First this is how it looked currently (though tbh at my local machine, there's also the balance there):

Well in my first commit  (8f47b6f) I completed the todo and merged the two blocks into one.
However I also did the following:

change the icon nex to the address to somethingbetter
change the expand icon so there is also a "unexpand" icon (see screenshot)
ordered accounts by balance (so it's more meaningful!)

This is how it looks after my first commit:

However as you can see it still looks not good (at least in my opinion).
So I decided to take the same table as is used for top accounts.
I extracted the table to an own component and changed it so that it's a little more generic and can be used from other places.
Now it looks like this:

Note that if you click "Load more" only 50 more voters are loaded each time. Because loading all voters at once into the DOM was slow anyway. However if this functionality is really needed / requested I'd suggest to make another button ("Load all").
Let me know what you think!

@Nasicus Could you resolve the conflicts? Will take a look then and merge or let you know what should be changed.

@faustbrian done

... here we go again - give me some minutes :>

We talked about this PR and think it would be better to move this to a separate page like /address/some-ark-address/voters because of how big the list can get and keep the voter list on /address/some-ark-address the way it is at the moment.
Do you think you could move this to a new page that only contains the voters list?

Hey
Just to clarify, why do you think it's getting to big?
In the current explorer it behaves like this:

In my version it is like this (by default 3 voters, when you click on more 50 additional are loaded):

Of course I could move it to a seperate route (as you suggested). I think I just don't understand what you mean with "too long". And if I move it, I think we should still do something with the old logic? Also: How would you reach the "seperate page" ? By clicking on the "plus" on the right side? Or by clicking on a link like "Show voters list"?

The voter list on the address details page itself should be kept short and only contain the addresses like it does at the moment as it already is quite long. If someone wanted more info about the voters they could go to the voters route and get a more detailed overview about who the voters are.
Could probably add a button like "View Voter Details" to get to the detailed list.

Oki doki will do (with a few little tweaks which I already did in my first commit^^).

Done - and I must say I kinda like it.
I did a small change in the table: it now shows how many % of votes each voter "weighs" (see screenshots).
As promise I left the existing list more or less alone, I changed the icon and did some refactoring (so the "todo" is removed).

@Nasicus Last change I would like to request, could you add a "Load All" button similar to the "More" button to the voters page?

Sure - the hardest part was, as so often, stupid CSS :P
Tell me if there's something there to optimize, CSS is not my favorite subject :P
It looks now like this:

Mobile:

Thanks, looks good!


Remove Invite and Leave button from Default Room Settings

Details

Remove Invite and Leave button from Default Room Settings
Fixed Issues

$ https://github.com/Expensify/App/issues/7791
Tests

Open Default Room (#admins and #announce) Settings.
Invite and Leave button should be hidden.
Open User-Created Room Settings.
Invite and Leave button should be visible.

[x] Verify that no errors appear in the JS console

PR Review Checklist

Contributor (PR Author) Checklist

[x] I verified the PR has a small number of commits behind main
[x] I linked the correct issue in the ### Fixed Issues section above
[x] I wrote clear testing steps that cover the changes made in this PR

[ ] I clearly indicated the environment tests should be run in (Staging vs Production)

[x] I wrote testing steps that cover success & fail scenarios (if applicable)
[x] I included screenshots or videos for tests on all platforms
[x] I ran the tests & veryfy they passed on:

[x] iOS / native
[x] Android / native
[x] iOS / Safari
[x] Android / Chrome
[x] MacOS / Chrome
[x] MacOS / Desktop

[x] I verified there are no console errors related to changes in this PR
[x] I followed proper code patterns (see Reviewing the code)

[ ] I added comments when the code was not self explanatory
[ ] I put all copy / text shown in the product in all src/languages/* files (if applicable)
[ ] I followed proper naming convention for platform-specific files (if applicable)
[ ] I followed style guidelines (in Styling.md) for all style edits I made
[ ] I followed the JSDocs style guidelines (in STYLE.md)

[x] I followed the guidelines as stated in the Review Guidelines
[x] I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
[ ] I corroborated the UI performance was not affected (the performance is the same than main branch)
[ ] If I created a new component I verified that a similar component doesn't exist in the codebase

PR Reviewer Checklist

[ ] I verified the PR has a small number of commits behind main
[ ] I verified the correct issue is linked in the ### Fixed Issues section above
[ ] I verified testing steps are clear and they cover the changes made in this PR

[ ] I verified the testing environment is mentioned in the test steps

[ ] I verified testing steps cover success & fail scenarios (if applicable)
[ ] I checked that screenshots or videos are included for tests on all platforms
[ ] I verified tests pass on all platforms & I tested again on:

[ ] iOS / native
[ ] Android / native
[ ] iOS / Safari
[ ] Android / Chrome
[ ] MacOS / Chrome
[ ] MacOS / Desktop

[ ] I verified there are no console errors related to changes in this PR
[ ] I verified proper code patterns were followed (see Reviewing the code)

[ ] I verified comments were added when the code was not self explanatory
[ ] I verified any copy / text shown in the product was added in all src/languages/* files (if applicable)
[ ] I verified proper naming convention for platform-specific files was followed (if applicable)
[ ] I verified style guidelines were followed
[ ] I verified the JSDocs style guidelines (in STYLE.md) were followed

[ ] I verified that this PR follows the guidelines as stated in the Review Guidelines
[ ] I verified other components are not impacted by changes in this PR (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
[ ] I verified the UI performance was not affected (the performance is the same than main branch)
[ ] If a new component is created I verified that a similar component doesn't exist in the codebase

QA Steps

Open Default Room (#admins and #announce) Settings.
Invite and Leave button should be hidden.
Open User-Created Room Settings.
Invite and Leave button should be visible.

[x] Verify that no errors appear in the JS console

Screenshots

Web

Default Room
User-Created Room

Mobile Web

Default Room
User-Created Room

Desktop

Default Room
User-Created Room

iOS

Default Room
User-Created Room

Android

Default Room
User-Created Room

:hand: This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

🚀 Deployed to staging by @chiragsalian in version: 1.1.42-0 🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
success ✅

🕸 web 🕸
success ✅

🚀 Deployed to production by @chiragsalian in version: 1.1.42-6 🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
success ✅

🕸 web 🕸
success ✅


how to exit suggestions

Feature description

i want to use exit,but the tips is ExitCode,so how can i exit it.
Additional information
No response

<C-e>


Adjust policy output to show time in days during creation

Now that create policy accepts input in days and shows the retention schedule in days, need to clean up how the time is shown:
$ shield create policy
Policy Name: one-year
Summary: Retain for one year
Retention Timeframe, in days: 365

Policy Name:                  one-year
Summary:                      Retain for one year
Retention Timeframe, in days: 31536000

Really create this retention policy? [y/n] y

Created new retention policy
Name:       one-year
Summary:    Retain for one year
Expiration: 365 days

@qanx, I believe this is complete per PR #95?


wsl --import/--export does not handle paths with spaces or quoted paths correctly

Your Windows build number:  (Type ver at a Windows Command Prompt)
Microsoft Windows [Version 10.0.18362.1]

What you're doing and what's happening:  (Copy&paste the full set of specific command-line steps necessary to reproduce the behavior, and their output. Include screen shots if that helps demonstrate the problem.)

C:\Users\JohnDoe> wsl --export Ubuntu "Ubuntu.tar"
The filename, directory name, or volume label syntax is incorrect.

C:\Users\JohnDoe> wsl --import Ubuntwo C:\Ubuntu "C:\Program Files\WindowsApps\CanonicalGroupLimited.UbuntuonWindows_1804.2018.817.0_x64__79rhkp1fndgsc\install.tar.gz"
The filename, directory name, or volume label syntax is incorrect.

What's wrong / what should be happening instead:
Both file paths should be treated correctly.

Workaround
Use stdin/stdout.

> wsl --import Ubuntwo C:\Ubuntu - < "C:\Program Files\WindowsApps\CanonicalGroupLimited.UbuntuonWindows_1804.2018.817.0_x64__79rhkp1fndgsc\install.tar.gz"

Good find, I'll sort this out.

Fixed in Windows Insider Build 18890

My Windows version is 10.0.18362.476.
I have the same problem - I cannot even export.
wsl -l shows:
Legacy (Default)

Trying to export it:
wsl --export "Legacy (Default)" ubuntu.tar

Shows me the exact same error as above:
The filename, directory name, or volume label syntax is incorrect.

I tried to pipe it directly to file like this:
wsl --export "Legacy (Default)" > ubuntu.tar

ubuntu.tar will include the exact same error message.
I suspect that the problem is with the distribution name (Legacy (Default)) itself. Can I rename distribution somehow to test it out? How would I solve this problem with a workaround?

Forgot to mention - I tried different working directories without having any positive effect.

After upgrading Windows to 10.0.19033.1 via Insider Program I managed to export like this:
wsl --export "Legacy" ubuntu.tar

Note, that I had to exclude " (Default)". I also tried that with the previous version and got an error message that Distribution with the name "Legacy" was not found.


docs: pull request template

a pull request template would help out when reviewing pull requests.

PR was made on templates repo.


Mancano alcune informazioni nell'integrazione del Kiosk

Describe the bug
Some information is missing in the Kiosk integration, including:

power curve
environmental benefits
overview

** Debug information **
Answer the questions below before submitting a new issue.

Are you using the latest version of Home Assistant? YES
Are you using the latest version of this integration? YES
Have you looked into the closed issues and did not find a similar issue. YES
Are you using Kiosk or Northbound / OpenAPI mode? KIOSK
If you are using Kiosk mode. Have you checked that the url is still valid? See I am using the kiosk mode, but the data is not updating YES, UPDATED A FEW MINUTES AGO
If you ar using Northbound / OpenAPI mode. Check if your credentials are still valid. See How can I verify my Northbound API / OpenAPI credentials?
Have you checked the logs for any info? NO

To Reproduce
Steps to reproduce the behavior:

Go to '...'
Click on '....'
Scroll down to '....'
See error

Expected behavior
I would have expected to see, in addition to the current, daily, monthly, annual and total performance data, also the 3 final pieces of information indicated in the kiosk summary (power curve, environmental benefits, overview)
Screenshots

In Kiosk mode only a limited amount of entities is exposed. If you need more detailed data I think Northbound API method is the way to go.


Inspect flight log

@priseborough Can you inspect this log which has issues with the position estimate?
http://review.px4.io/plot_app?log=98d340b4-d820-4819-af6d-48acd5f9ff77

There were severe problems with the magnetometer that caused the copter to lose it's yaw reference when hovering. Here is a plot of the field strength:

Here are the mag field and mag yaw innovations:

I might be able to improve resistance to this sort of error by not switching back into heading fusion if the magnetometer is failing innovation consistency checks, but with mag data this bad it is only delaying the inevitable until the combination of mag error and vehicle orientation fools the checks.

Hey, this issue has been closed because the label status/STALE is set and there were no updates for 30 days. Feel free to reopen this issue if you deem it appropriate.
(This is an automated comment from GitMate.io.)


withAuthentication HOC triggers too many rerender of wrapped component

Issue and Steps to Reproduce
When using withAuthentication from @axa-fr/react-oidc-context-fetch, the component wrapped will rerender too many times.
In 3.1.6 with my reproduction code I get "toto 2", and in "3.1.7" I get "toto 6"
3.1.6:

3.1.7:

git clone https://github.com/JLou/repro-bug-react-oidc.git
cd repro-bug-react-oidc
npm i
npm start

Versions
3.1.7 & below
Screenshots

Expected
fetch should not change during the lifespan of the app, and should definitely not trigger a rerender of my wrapped component
Actual
it does
Additional Details

Installed packages:
"@axa-fr/react-oidc-context": "3.1.7",
"@axa-fr/react-oidc-context-fetch": "3.1.7",
"@axa-fr/react-oidc-core": "3.1.7",
"@axa-fr/react-oidc-fetch-core": "3.1.7",

The rerender problem is fixed in v4 by sliting  hooks and by removing data duplication inside react.

I close the issue, thank you for it. The v4 fixe it. Feel free to re-open an issue if you need it.


Message appears strange

I've replied to a mail with a long text.
When I go in Sent Items I see it so:

Best regards.

This problem persists? Сan you repeat this?

Unfortunately I cannot reproduce it, but this is the second time that happens.
In next days I'll try again to reproduce it so I can say you something more.

Sorry, I cannot reproduce it.


Make window-fast default

For TimeSeries baseline correction, the window-fast method is almost always preferable to window, we should rename window-fast -> window , and maybe rename what's currently called window to something else (or just eliminate it).

Fixed as part of 1.0.0 changes https://github.com/thunder-project/thunder/pull/243


Various cleanup items: Fig 12 -- axiomatic rules

Description
This addresses one issue of #288.
We could explain that some rules have no premise (they're essentially axioms). Instead, for consistency, we simply define a horizontal line that takes no premise, introducing syntax to represent such "axiomatic" rules.
Checklist

[X] Commit sequence broadly makes sense and commits have useful messages
[X] Code is formatted according to CONTRIBUTING.md
[X] Self-reviewed the diff

This is somewhat overlapping with #268 , which also introduces the "axiom" syntax and a slightly different represent of premises (= uncurried = single argument as a tuple of premises).

@williamdemeo Since #268 will be merged today probably, I would suggest rebasing now so that you don't spend time repeating the same definitions or resolving merge conflicts.

Okay, I think we're good to go.  @WhatisRT please take a look so we can GTM.  Thanks!


component element can't be typed correctlly

I reproduce this in latest volar starter: https://github.com/tjx666/volar-component-element-issue

Version: 1.78.2
Commit: b3e4e68a0bc097f0ae7907b217c1119af9e03435
Date: 2023-05-10T15:00:40.428Z
Electron: 22.5.2
Chromium: 108.0.5359.215
Node.js: 16.17.1
V8: <IP_ADDRESS>-electron.0
OS: Darwin arm64 22.4.0
Sandboxed: No
Volar: v1.7.8
TakeOver Mode: yes

You can work around the issue with dynamic components for the time being with something like:
<component :is="HelloWorld as any" />

@sfreytag vite vue2.7 doesn't support type assertion:
https://github.com/vitejs/vite-plugin-vue2/issues/87

I think this is the intended behavior. You have defined a required prop msg but you didn't pass it to the <compnent> element.

@so1ve you are right, but the error message is hard to understand here.

这也没办法，转换出来的TSX类型就是这么又臭又长（

You can install a vscode plugin called Pretty Typescript Errors.


Providing Detailed on Lease Mechanism

Cuases for Lease Timeout
-Explanation of what it really is

@PiJoCoder : Thanks for your contribution! The author, @MashaMSFT, has been notified to review your proposed change.

Microsoft authors of articles need to make updates through the private repository so the updates can be staged and validated by the current validation rules. After you review staging and fix all validation issues, you can add the sign-off comment to let the PR reviewers know the updates are ready to be merged.It's easy to access the private repo version of your articles in GitHub. Just add -pr to the URL, as follows:
Public repo URL: https://github.com/Microsoft/azure-docs/blob/master/articles/azure-portal-overview.md
Private repo URL: https://github.com/Microsoft/azure-docs-pr/blob/master/articles/azure-portal-overview.md
We have closed this pull request. Please resubmit the updates through the private repo. If you need perms to the private repo, see the contributor guide instructions

Hi @PiJoCoder thanks for your contribution :) This sounds great. #sign-off

#sign-off


6.3 update?

Is there plans to update this for 6.3?
Makes playing AST so much easier.

I'm currently testing the update (checking if i got all the offsets correct) and if so il have an update out in a bit

Update should be up!
Let me know if you come across any issues

I'll run a few roulettes after breakfast and report back.

Update should be up! Let me know if you come across any issues

Hi there, for some reason for me, it's reporting my plugin as being out of date since 6.3, with no option to update it. I have it installed from the repo link: https://raw.githubusercontent.com/Nik-Potokar/Plogons/main/pluginmaster.json
Any idea what could be causing this? All the other plugins I use are fine. Any help would be greatly appreciated

Try deleting the repo link and then deleting the plugin from %appdata%/xivlauncher/installed plugins or if you happen to have it manually installed in the dev plugins.
Then restart the game and re add the repo link and it should how the correct version.
If none of that works if you dm me on the discord I can give you the plugin file or download it from the link inside the repo link.
https://github.com/Nik-Potokar/Plogons/raw/main/Plugins/Astro/Astro.zip

That worked perfectly for me, thank you so much the help and quick response. This plugin is very much appreciated, I'm grateful to the creator and to you for updating it.

Glad you got it working!


React not rendering until refresh in IE 10 Windows 8.0

I'm using Redux in production in a web application. On Windows 8.0 in Internet Explorer 10, my react components are not rendered on the specified div.  It's simply blank. Where I call
React.render(
  <Provider store={store}>
    {() => <App />}
  </Provider>,
  document.getElementById('content')
);

my <div id="content> </div> appears as is.
In every other broswer/OS combination everything works properly and the app is loaded into the that div on the DOM.
There is not much online about this specific issue. I decided to try out your examples in this browser operating system configuration. The same issue occurs. Have you seen this error before? Thanks

What is the error in console?

There is none.

Just in case: examples in Redux repo have hot reloading enabled which currently has problems with IE < 11. You are not meant to deploy code with hot reloading enabled in production!
Examples only serve as Redux examples, not “how to fully configure a real app”. You should create a separate production configuration, envify the project to use production build of React by setting process.env.NODE_ENV polfill (envify in Browserify, DefinePlugin in Webpack), minify code with UglifyJS, and disable hot reloading.
Is there a possibility that you're deploying an application that hasn't been envified and uses development .babelrc configuration with React Transform enabled?

I'll go ahead and verify all that is being done. Thanks @gaearon

No problem. I guess we should fix the examples to include the build process because I've seen people assume they're complete a couple of times.

Closing for inactivity.


fix(CI): restore image label

Purpose of PR?:
Restore docker image labels
Fixes #
Does this PR introduce a breaking change?
If the changes in this PR are manually verified, list down the scenarios covered::
Additional information for reviewer? :
Mention if this PR is part of any design or a continuation of previous PRs
Checklist:

[ ] Bug fix. Fixes #
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[ ] This change requires a documentation update
[x] PR Title follows the convention of  <type>(<scope>): <subject>
[ ] Commit has unit tests
[ ] Commit has integration tests

Codecov Report

Merging #982 (58c0881) into main (359e36e) will decrease coverage by 3.91%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main     #982      +/-   ##
==========================================
- Coverage   39.48%   35.56%   -3.92%
==========================================
  Files          31       31
  Lines        9898     9898
==========================================
- Hits         3908     3520     -388
- Misses       5476     5896     +420
+ Partials      514      482      -32

Impacted Files
Coverage Δ

KubeArmor/core/crioHandler.go
0.00% <0.00%> (-60.52%)
:arrow_down:

KubeArmor/core/dockerHandler.go
0.00% <0.00%> (-44.79%)
:arrow_down:

KubeArmor/core/containerdHandler.go
53.18% <0.00%> (-15.74%)
:arrow_down:

KubeArmor/monitor/processTree.go
84.94% <0.00%> (-9.68%)
:arrow_down:

KubeArmor/core/kubeArmor.go
45.79% <0.00%> (-4.21%)
:arrow_down:

KubeArmor/common/common.go
39.38% <0.00%> (-3.87%)
:arrow_down:

KubeArmor/monitor/logUpdate.go
66.01% <0.00%> (-3.63%)
:arrow_down:

KubeArmor/enforcer/runtimeEnforcer.go
34.68% <0.00%> (-1.16%)
:arrow_down:

KubeArmor/enforcer/appArmorEnforcer.go
48.21% <0.00%> (-0.48%)
:arrow_down:

KubeArmor/core/kubeUpdate.go
37.97% <0.00%> (-0.45%)
:arrow_down:

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.


@vue/language-plugin-pug / @volar/vue-language-plugin-pug Causes Syntax Errors When Using Multiline Escapes in Pug

As the title suggests, using either of these plugins will cause multiline escapes in pug to be unusable, as shown below:

This is valid Pug syntax.


Update rustyline to v0.11

Replaces https://github.com/facebook/opaque-ke/pull/310.

This increases the MSRV to v1.62, which is w/e really because #307 increases it to v1.65 anyway.


flex justification of headings applied too aggressively in stylesheet

_body.scss includes:
// Right align links inside a header
h1, h2, h3, h4 {
  display: flex;
  justify-content: space-between;
  a {
      margin-top: auto;
      @extend .btn;
      @extend .btn-sm;
  }
}

Unfortunately, this doesn't just right align link inside a header but forces all children of an h* to be justified (e.g.
A B
)
I don't think we can assume this should be the default case for all h* so I think we just have to live with this being triggered by a specific class on the h*.

workaround for now is just commenting out the rule in _body.scss in your project.

I think:

    Title
    Your Link

Will work if you want to have this style work with the extra markup.

Another solution is create a new class:
.action-title {
  display: flex;
  justify-content: space-between;
  > * {
      margin-top: auto;
  }
}```

so that you can do:

```html

    Title
    Your Link


[IMPROVEMENT] Upgrade path improvement

Is your feature request related to a problem? Please describe.
In #2582 and #3068, longhorn manager pod launching will get crashed by the CR update conflicts that happen in the upgrade path. The direct cause is that some CRs will be blindly updated as long as there is a new longhorn manager pod up, regardless of the system being upgraded or the CRs already being up-to-date.
The hotfix I applied is to the above 2 issues avoids the update when there is nothing change in the CRs. Then the upgrade failure won’t be triggered during fresh installation or longhorn pod restart. But it can still block some manager pods during the upgrade, .e.g., upgrade from 1.1.x to 1.2.x.
To fully resolve this issue, I think we can introduce the following:

Longhorn version recognition. Longhorn can skip all old upgrade paths if somehow it knows the previous version and the upgrading version.
By checking the setting values, all other longhorn manager pods can give up the leadership election and skip the upgrade paths if the 1st leader manager pod succeeds to execute the upgrade path. This may speed up the longhorn manager launching when there are hundreds of worker nodes in a cluster.

Describe the solution you'd like
We can add a new read-only setting Current Longhorn version, with which Longhorn would recognize which version it is upgraded from before walking through the upgrade paths, so that Longhorn will skip all old upgrade paths. And after upgrade paths execution (by the 1st manager pod that takes over the leadership), the setting will be updated. Later, once there are other manager pods getting started, they can realize the current Longhorn version is up to date and there is no need to take care of any upgrade path. As a result, the upgrade path will be executed once by the 1st manager pod before any CR controller starts, and there are no other components fighting for CR update.
Describe alternatives you've considered
N/A
Additional context

Notice that the upgrade path idempotency should not be break even if the enhancement is introduced.

Leaving a not here.
For future upgrade refactoring, need to separate the two scenarios
(1) CRD version upgrade
(2) CRD version not upgraded, but longhorn version upgrade
The logic of current upgrade mixes them up, so it is still messy now.

we need to test upgrading Longhorn in big cluster with many volumes, ref https://github.com/longhorn/longhorn/issues/3368#issuecomment-987867876. The expected time is 30s per node

Test summary:
Env:
20 worker nodes (2v core, 4G RAM); 200 running volumes on different nodes
Result:

Case
Result

Restarting all longhorn manager pods for the old version
17mins

Upgrading Longhorn via the old upgrade path (the versions before and after the upgrade that do not contain the PR)
17mins

Restarting all longhorn manager pods for the new version
1~2mins

Upgrading Longhorn via the new upgrade path (the versions before and after the upgrade that both contain the PR)
3~4mins

The idea for this improvement is pretty straightforward. Do we still need any doc or LEP?

The idea for this improvement is pretty straightforward. Do we still need any doc or LEP?

If that's the case, no need.

BTW, we need to backport this improvement to v1.2.4 and v1.1.4, right? @innobead

BTW, we need to backport this improvement to v1.2.4 and v1.1.4, right? @innobead

Yeah, please.

Will be tested with scalability test setup once the rc1 image is out for v1.3.0.

Validating in progress, cc @shuo-wu
Testing from v1.2.2 to v1.3.0-dev.
Retest with 20 volumes attached to 20 simple workload and concurrent-automatic-engine-upgrade-per-node-limit set to 3.
By measuring the status.numberAvailable pod of daemonset/longhorn-manager right after longhorn.yaml deployed.
Sampling the average time out of 4 rounds of test: (container image download time is ignored as the cluster was reused for each round of test.)

Version
Time (sec.)

Fresh install → v1.2.2
123

V1.2.2 → v1.2.3
343

v1.2.3 → v1.2.4
44

v1.2.4 -> v1.3.0-dev
59

* Each round of test will wait for all engine image gets upgraded.

Expand to see the timer function for the reference
ds-timer() {
  local start=`date +%s`
  echo "Timer Starts at $start"
  local desired_count=$(kubectl get daemonset/longhorn-manager -n longhorn-system -o json | jq '.status.desiredNumberScheduled')
  update_current_count() { echo $(kubectl get daemonset/longhorn-manager -n longhorn-system -o json | jq '.status.numberAvailable'); }
  local current_count=$(update_current_count)
  while [[ $desired_count -ne $current_count ]]
  do
    current_count=$(update_current_count)
    echo "longhorn-manager ready pod count: $current_count/$desired_count" | ts '[%Y-%m-%d_%H:%M:%S]'
  done
  local end=`date +%s`
  local elapsed=$((end-start))
  echo "Timer Ends at: $end"
  echo "Total elapsed time in second: $elapsed "
}

When there are multiple volumes in the system, upgrading to v1.3.0 is still relatively fast, right?
BTW, you can launch 100+ volumes instead and see the difference.

I redo the test with 100pod-volumes(size in 11MB) and the result still shows v1.2.4 had better deployment speed of longhorn-manager pods.
Gradual upgrade:

install path
time

fresh install v1.2.3
146s

upgrade to v1.2.4*
56s

upgrade from v1.2.4 to v1.3.0-preview1
97s

* Some engine image will stuck when upgrading to v1.2.4, but it will be resolved when upgrade to 1.3.0-preview1 image
Jump upgrade:

install path
time

fresh install v1.2.3
137s

upgrade to v1.3.0-preview1
100s

Validation - PASSED
Validated with v1.2.4 image, upgrade time had been improved since v1.2.3: https://github.com/longhorn/longhorn/issues/3087#issuecomment-1116121960
Also had reference test with v1.3.0-preview1(see previous comment): https://github.com/longhorn/longhorn/issues/3087#issuecomment-1120730706
As the improvement is made in v1.2.4 branch, the launch time is expecting differ with v1.3.0.


transition not working in firefox

I have the following animation in my angular2 app which is working fine in Chrome but the transition does not work in Firefox.
function slideToLeft() {
return trigger('routerTransition', [
state('void', style({
position: 'fixed',
top: 0,
bottom: 0,
left: 0,
width: '100%'
})),
state('*', style({
position: 'fixed',
top: 0,
bottom: 0,
left: 0,
width: '100%'
})),
transition(':enter', [
style({transform: 'translateY(100%)'}),
animate('0.5s ease-in-out',
style({transform: 'translateY(0%)'}))
]),
transition(':leave', [
style({transform: 'translateX(0%)'}),
animate('0.5s ease-in-out',
style({transform: 'translateX(-100%)'}))
])
]);
}
function slideToTop() {
return trigger('routerTransitionTop', [
state('void', style({
position: 'fixed',
top: 0,
bottom: 0,
left: 0,
width: '100%'
})),
state('*', style({
position: 'fixed',
top: 0,
bottom: 0,
left: 0,
width: '100%'
})),
transition(':enter', [
style({transform: 'translateY(100%)'}),
animate('1s ease-in-out',
style({transform: 'translateY(0%)'}))
]),
transition(':leave', [
style({transform: 'translateY(0%)'}),
animate('1s ease-in-out',
style({transform: 'translateY(-100%)'}))
])
]);
}
I added this library as a polyfill but this did not resolve anything. Does anyone came across this issue and found a solution.

Having the same problem, works in Chrome and Edge, but not IE11 or FireFox. Are you using angular-cli? I am using it and have can't figure out it out.

Would you be able to create a working repro case on https://plnkr.co (or other preferred method)?

Encountered the same problem. No fix hasn't been found yet? Is this a browser issue?


adding weather API

https://openweathermap.org/api
i want to add this api

@ashitaprasad assign me this


When will this crate can be published to crates.io?

+1

@davidli2010 @linkensphere201 Today is the day


Add iNoBounce plugin for preventing bouncing on ios safari

https://github.com/lazd/iNoBounce
https://www.npmjs.com/package/inobounce

@etharner please fix eslint errors

As I see modern sites usually not trying to block bouncing on iOS Safari, so I think we should not disable it as well. Also, seems that it is not so easy and clear as I thought.


Compatibility with Python 3.12.0

Issue type
Build/Install
Have you reproduced the bug with TensorFlow Nightly?
No
Source
binary
TensorFlow version
tensorflow 2.14.0
Custom code
No
OS platform and distribution
Mac OS
Mobile device
No response
Python version
3.12.0
Bazel version
No response
GCC/compiler version
No response
CUDA/cuDNN version
No response
GPU model and memory
No response
Current behavior?
Python 3.12.0 is now available. I tried to pip install TensorFlow 2.14.0. The attempt failed as TF is only compatible with Python 3.11 at most at the moment.
When will a version of TensorFlow be available for the latest Python?
Thanks.
Standalone code to reproduce the issue
Terminal output:

(venv) ## my user ## % pip install tensorflow==2.14.0
ERROR: Could not find a version that satisfies the requirement tensorflow==2.14.0 (from versions: none)

Relevant log output
No response

Duplicate of #62003


KFLUXBUGS-1610 - Logging Operator update -  Update Splunk secret object to secretName & key

As part of the migration to the Logging Operator v6.0, the spec to define the Splunk key was changed; this reconciles our definition with the new spec.

New observability spec for this field -
`➜  ~ oc explain ClusterLogForwarder.spec.outputs.splunk.authentication.token
GROUP:      observability.openshift.io
KIND:       ClusterLogForwarder
VERSION:    v1
FIELD: token
DESCRIPTION:
Token points to the secret containing the Splunk HEC token used for
authenticating requests.
FIELDS:
key	 -required-
Key contains the name of the key inside the referenced Secret.
secretName	 -required-
SecretName contains the name of the Secret containing the referenced value.`


ERROR: no matching manifest for linux/arm

Hello,
I am running this is on Pi.
This is what I am running with compose:
version: "3"
services:
my-wpdb:
image: mariadb
ports:
- "8081:3306"
environment:
MYSQL_ROOT_PASSWORD: Password
This is what I get:
Pulling my-wpdb (mariadb:latest)...
latest: Pulling from library/mariadb
ERROR: no matching manifest for linux/arm in the manifest list entries
Thanks for the help.

Hi All,
I'm having the same issue. this is not specific to MariaDB, but to Mongo and MySLQ as well.

Official image repository can be found here https://github.com/docker-library/official-images. It does not look like arm variants are currently built for those images (they would show up here as well https://hub.docker.com/r/arm32v7/). Please file an issue over there to request official image support.


[stable/falco] enable to set timezone

Signed-off-by: Naoki Oketani<EMAIL_ADDRESS>
What this PR does / why we need it:
This PR enables falco daemonset to set timezone like below.
helm install --set timezone=Asia/Tokyo falco ./falco

I'd like falco to log local time to quickly understand alarms (when it happend).
Which issue this PR fixes
(optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close that issue when PR gets merged)

nothing

Special notes for your reviewer:
Checklist
[Place an '[x]' (no spaces) in all applicable fields. Please remove unrelated fields.]

[x] DCO signed
[x] Chart Version bumped
[x] Variables are documented in the README.md
[x] Title of the PR starts with chart name (e.g. [stable/chart])

/ok-to-test

/lgtm

Ooooops, I had not enough time to review this before merging.
Please fill the CHANGELOG.

OK, I'll create another PR soon.

@nestorsalceda sorry, forgot about the changelog my bad


feat: A shutting down state in ShutdownHandler

Motivation
Before this PR, there was no way of figuring if cloudnet is shutting down or not outside of internal cloudnet packages (without using reflections), causing custom load balancing modules unable to determine whether it should start new services.
Modification
This PR exposes a proper function to determine whether a shutdown is in progress or not.
Result
Custom modules can now determine whether cloudnet is shutting down or not
Other context
N/A

I like the idea but I think it would be best to add a getter to the TickLoop which provides information about the RUNNING state

I like the idea but I think it would be best to add a getter to the TickLoop which provides information about the RUNNING state

Indeed, I've changed the code


Is it possible to save picture not camera taken to the gallery ?

Hi, and thanks for your plugin.
Suppose I have a byte stream representing an image in my code. Can I save it to the system gallery using your plugin ?
Cheers

That is not possible with this plugin. You could probably grab my code that exposes images out to the galleries though and just use that.

Thank you anyway.


More specific error class for 403 HTTP status code

Would you consider adding an AccessDeniedError class that can be be used when linkedin returns a 403 status code. This class would be more appropriate than the GeneralError class that is currently used for that status code.
What do you think? Should I go ahead and add the code and tests?
LinkedIn API documentation https://developer.linkedin.com/documents/request-and-response-headers

Hi - yes if you would like to add the code and tests for this that would be great.

Merged https://github.com/pengwynn/linkedin/commit/c884a4d484228222d6ba60031ec927d39752ab46


Test service settings

if service settings work , this pull also pass :)

works now with https://github.com/woodpecker-ci/woodpecker/pull/4336 applyed & deployed


CSS: Position Absolute and Position Relative

Description
There comes a lot of confusion in position: relative and position: absolute property of CSS. Students often put a hit and trial method to use this. Since due to lack of proper understanding students adopt such hit and trial methods . I would like to contribute on this propertiey of CSS which plays a vital role in Frontend Development.
Domain
Frontend Dev HTML/CSS/JS
Type of Contribution
Documentation
Code of Conduct

[X] I follow Contributing Guidelines & Code of conduct of this project.

/assign

frontend batch 10

/assign

/assign


Timber + Debug Bar - Theme crash

Hello,
my Theme crashs at any page, if i use the latest Version from Timber with the latest? Timber Debug-Bar. If i disable the Debug-Bar the Theme is alright.
Expected behavior
The "Screen" is wrong. The theme does not have the full width on the desktop, just maybe tablet size. The error is also with the timber-starter-theme.
Actual behavior
I see an Error in Debug-Bar under Timber:
Fatal error: Method Timber\FunctionWrapper::__toString() must not throw an exception, caught Error: Call to undefined function Symfony\Component\VarDumper\Caster\str_contains() in /wp-content/plugins/timber-library/vendor/twig/twig/src/Environment.php(497) : eval()'d code on line 0
There is no other output.
What version of WordPress, PHP and Timber are you using?
Wordpress: 5.8 / Timber: 1.18.2 / Timber-Debug-Bar: 1.0.8 (i tried 1.1.4 from your github here. However, it also appears to me as 1.0.8) / ACF 5.9.9 (if I deactivate it nothing changes) - no more plugins
PHP 7.3.22 - as fpm
How did you install Timber? (for example, from GitHub, Composer/Packagist, WP.org?)
Github & Wordpress-Plugin-Directory

@katipierson thanks for the report! Could you confirm you're running the newest WP.org distributions of both Timber and Debug Bar Timber (and the base Debug Bar too). Once those are 100% up to date we can better dive into what might be happening

I tested the newest versions:
The bug has changed.
on the right side in the adminbar is a menu: Debug. In the past there were the menu items:
WP_Http
Queries
WP query
Object cache
Timber
The item "Timber" is now missing.


🚀 Major feature request: Patient onboarding and management

Use Case
As soon as the care provider completed the onboarding process, they might want to manage patients including the following actions:

Add new patients
Manage a specific patient's health records (questionaries, eeg recordings, ...)
Switch between the list of registered patients

Problem
The current app (template) is primarily targeted for individual use only.
Solution
Current structure might need slight refactoring to support managing a list of patients.
Alternatives considered
--
Additional context
Changes done here might include work within the Spezi framework ecosystem.
Code of Conduct

[X] I agree to follow this project's Code of Conduct and Contributing Guidelines

completed as of #9


Add dedicated <gsl-lite/gsl-lite.hpp> header for v1

As a ~first~ second step towards M-GSL compatibility (cf. #194, #222), this PR proposes the following change:

Add new header file <gsl-lite/gsl-lite.hpp> which currently just forwards to the old header <gsl/gsl-lite.hpp>. It raises an error if !(gsl_CONFIG_DEFAULTS_VERSION >= 1).

The idea is that libraries which want to use gsl-lite should do the following:
#include <gsl-lite/gsl-lite.hpp> // instead of <gsl/gsl-lite.hpp>

namespace foo {

namespace gsl = ::gsl_lite; // convenience alias

double mean(gsl::span<double const> elements)
{
    gsl_Expects(!elements.empty()); // instead of Expects()
    ...
}

} // namespace foo

Subsequently, version 1 of gsl-lite would then no longer define the namespace gsl in the <gsl-lite/gsl-lite.hpp> header. Library "foo" will then happily coexist with other code which uses either M-GSL or gsl-lite in "traditional mode" (or "GSL mode", or whatever we want to call it) by defining gsl_FEATURE_GSL_MODE=1, or by including the old header <gsl/gsl-lite.hpp> . (Cf. the comment below for more details; I'd appreciate thoughts and comments especially on this part.)

I'm still not quite sure about that new <gsl-lite/gsl-lite.hpp> header file.
I feel that <gsl-lite/gsl-lite.hpp> would be the appropriate header name for gsl-lite if we want gsl-lite to be more than just another GSL implementation, just as gsl-lite::gsl-lite would be the appropriate name for the CMake target. But I'm not sure if the benefits of making these changes outweigh the drawbacks.
If we do want to proceed with a dedicated gsl_lite namespace, I see two possibilities for version 1:

Do not introduce a new header file. There is only <gsl/gsl-lite.hpp>, and it defines the namespace gsl_lite by default, and additionally the namespace gsl if gsl_FEATURE_GSL_MODE is defined:
// gsl/gsl-lite.hpp
namespace gsl_lite { ... }
namespace gsl_compat { using gsl_lite::span; ... }

// Including the new header <gsl-lite/gsl-lite.hpp> enables "GSL mode" only if requested
// by a feature macro.
#if defined( gsl_FEATURE_GSL_MODE )
namespace gsl = gsl_compat;
# define Expects( x ) gsl_Expects( x )
# define Ensures( x ) gsl_Ensures( x )
#endif // defined( gsl_FEATURE_GSL_MODE )

Advantages: less complexity and confusion, still trivially single-header
Disadvantages: breaks old code which expects everything to be in namespace gsl; the fix is trivial (define gsl_FEATURE_GSL_MODE in the build system), but it still is a breaking change, and we cannot really generate helpful diagnostics

Introduce a new header file <gsl-lite/gsl-lite.hpp> in addition to <gsl/gsl-lite.hpp>.
// gsl-lite/gsl-lite.hpp
namespace gsl_lite { ... }
namespace gsl_compat { using gsl_lite::span; ... }

// Including the new header <gsl-lite/gsl-lite.hpp> enables "GSL mode" only if requested
// by a feature macro.
#if defined( gsl_FEATURE_GSL_MODE )
namespace gsl = gsl_compat;
# define Expects( x ) gsl_Expects( x )
# define Ensures( x ) gsl_Ensures( x )
#endif // defined( gsl_FEATURE_GSL_MODE )

// gsl/gsl-lite.hpp
#include <gsl-lite/gsl-lite.hpp>

// Including the traditional header <gsl/gsl-lite.hpp> implicitly requests "GSL mode".
//
// If `gsl_FEATURE_GSL_MODE` is defined, the "GSL mode" definitions are already provided
// by <gsl-lite/gsl_lite.hpp>, but they are idempotent, hence we can just state them again.
namespace gsl = gsl_compat;
# define Expects( x ) gsl_Expects( x )
# define Ensures( x ) gsl_Ensures( x )

Advantages: old code which references <gsl/gsl-lite.hpp> and expects a namespace gsl keeps working; <gsl-lite/gsl-lite.hpp> can still be used as single-header library (although then the gsl_FEATURE_GSL_MODE feature macro is required to enable the traditional mode)
Disadvantages: more headers and more complexity; the distinction between  <gsl/gsl-lite.hpp> and  <gsl-lite/gsl-lite.hpp> is perhaps too subtle

@martinmoene and @petamas, I'd be grateful if you could take the time to comment on these thoughts. Of course this can wait until next year :)

@mbeutel noticed your request :)

The new gsl_lite namespace, probably less controversial, is now tracked separately in #222.

I've been thinking about this for a while, and I believe that the new header file is the superior choice. Those who need a single-header GSL implementation will then need to define a build configuration macro like gsl_FEATURE_GSL_MODE, which seems bearable.

@mbeutel sorry for slacking, couldn't make up my mind, hadn't come further than the split you made to enable different time paths. Support the choice you made, whichever it would have been.
Like to mention I'm very happy and grateful for the professional approach and the direction you take gsl lite. Thanks very much!

No worries! Thank you for your support :)


Spec: add expectations starts_with, ends_with

i need this many times.

Didn't make my mind up generally but it should be start_with and end_with respectively, since the proper English is "It should start with foo".

I'm a bit wary about having a "slippery slope" towards duplicating all collection/string methods as spec expectations, we shouldn't have too many.

there is not so many, for strings useful only contain, start_with, end_with and match

@kostya By the way, string_spec.cr in the std specs could use this new matcher.

i not found in string_spec where to replace it.

@kostya https://github.com/crystal-lang/crystal/blob/master/spec/std/string_spec.cr#L943-L968

@asterite These are specs explicitly for String#starts_with?. Using the expectation here would clearly compromise these specs. It hides their true purpose and might even be completely wrong if StartWithExpectation wouldn't use String#starts_with? internally.

Okay... I don't see it as that terrible, but it's also not strictly necessary.

So we just need the approval of @RX14


New schema for Labs E1-E6

When TTK support is ready, move to the new manifest v19

Change schema version
Remove deprecated packageName property
Change copilotExtensions to copilotAgents
Change declarativeCopilots to declarativeAgents

ALSO add lab number to manifest and declarativeAgent.json solution files for E3-E6 for easy handling of multiple lab specific versions. Students who follow the instructions won't see these because they will have grown it from the E2 files.

@rabwill I just updated E2-E6, it looks like you already got E1?
Thanks!


Where to store the test results - How to execute them

Describe the issue
The test plan includes several component. The technical approach means that we will have separate results that can be later combined in a consolidated report.
In addition, it may be a good idea to store the reports the scripts that take a 'snapshot' of the state of the Guardrails.
The question is where to store all this information and even how to execute the scripts: GitHub, local machine, Lambda function...?
Note: Kevin and Ukeme send results from querying the CSMP to AWS Quicksight, perhaps that can be another approach to consolidate the results
Additional context
Currently all the scripts can be executed locally. The easiest approach is to execute them there, and then semi manually integrate the results into a single and move the files to a storage location
Alternatively, we can create a script that will integrate the different reports. Notice the creation of the individual reports may be semi automated (for example for the 'Create new project set' test case)

Platform Admins would like a future state in a pipeline (we would have to find a place for the automation to run)
the difference is that billing auto runs on a schedule
it is possible to easily create a role in the future to handle the authentication
For now, we aim for a manually run MVP

Definition of done

A decision of where to store the reports: A bucket in the cloud? A Sharepoint location?
Where to execute the tests: try to run them in GitHub Actions? Locally?

Depending of the answers to the previous questions, new tickets will need to be created, for example a ticket to create a lambda function that will take a snapshot of the AWS guardrails state.

Execute: Locally right now.
Create tickets GitHub C pricate repo