Refactor ParquetReader to pass type to PrimitiveColumnReader at  construction time

For a given PrimitiveColumnReader, we always invoke readValue(BlockBuilder blockBuilder, Type type) with the same type argument.  If we could pass that to the constructor, it would allow column readers to perform computations that are only dependent on the type once, instead of doing it for every row.

fwiw, i had some related wip  in https://github.com/prestosql/presto/pull/2840

The new batched column readers will make the code in PrimitiveColumnReader obsolete.


[Doc Improvement][send-proactive-notifications-user]

Docs Build status updates of commit 9c2740e:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

msteams-platform/bots/how-to/conversations/send-proactive-messages.md
:white_check_mark:Succeeded
View

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching the docs.microsoft.com contributor guidesPost your question in the Docs support channel


⚠ Cioos National CKAN has degraded performance

In f1452a6, Cioos National CKAN (https://catalogue.cioos.ca/) experienced degraded performance:

HTTP code: 200
Response time: 5067 ms

Resolved: Cioos National CKAN performance has improved in ccdc5e8 after 5 minutes.


Initial robot pose not configured from the controller

In my understanding, mc_mujoco reflects the initial root link pose of the controller's robot to the robot in the mujoco simulation (in the following line of the code).
https://github.com/rohanpsingh/mc_mujoco/blob/edae2be05e7068c0847b5c60939e9c9183559ea1/src/mj_sim.cpp#L400-L407
This function worked in @rohanpsingh 's environment, but not in mine. In my environment, the initial position of the robot in the mujoco simulation did not change when the following configuration was added.
init_pos:
  translation: [0, 0, 1]

I suspect that the difference may be due to the version of mc_rtc (I am using the latest version of origin/master). For example, has the timing of when ctl().robot().posW() is initialized changed in recent versions of mc_rtc?

Hi @mmurooka
The above commit should fix the issue. This is indeed a (not so recent) change in mc_rtc initialization of the robot's position as it makes more sense on hardware to set the initial position after getting the initial state of the robot (i.e. in reset) rather than in the constructor.


Support semver notation for WEBSITE_NODE_DEFAULT_VeRSION

You should be able to use semver notation with WEBSITE_NODE_DEFAULT_VERSION instead of exact match.
Corresponding change will also need to be made in dwas - we are starting here.
https://github.com/projectkudu/kudu/blob/master/Kudu.Core/Infrastructure/PathUtils/PathWindowsUtility.cs#L185
(@mhoeger will work on this in functions sprint 45)

Hi
If the problem persists and is related to running it on Azure App Service, please open a support incident in Azure:
https://learn.microsoft.com/en-us/azure/azure-portal/supportability/how-to-create-azure-support-request
This way we can better track and assist you on this case
Thanks,
Joaquin Vano
Azure App Service


Error trying to download client.pem

I ran into this issue yesterday while testing chef-provisioning-ssh but it doesn't appear to be an issue with chef-provisioning-ssh. I'm not sure why provisioning would try to do something with client.pem at this point. @tyler-ball ball suggested I create the issue as he's seen this before.
* machine[chef-backend1.example.com] action setup[2015-04-14T15:52:09-05:00] ERROR: Unable to download /etc/chef/client.pem to #<StringIO:0x007f9658509420> on<EMAIL_ADDRESS>-- Error: command 'cp /etc/chef/client.pem /tmp/client.pem.3417363662' exited with code 1.

I find it very strange that read_line is trying to download an artifact to the target.  @jkeiser is this on purpose?

Moving this to Later because it appears to only be a cosmetic issue

I seem to recall this was causing everything to bomb out but it's been a while.

Okay!  As part of troubleshooting some other stuff, I think we figured this out.  https://github.com/chef/chef-provisioning/blob/master/lib/chef/provisioning/convergence_strategy/precreate_chef_objects.rb#L54 is part of the workflow of creating a new chef client.  First, we check of the remote AWS machine has a private key at /etc/chef/client.pem.  If it does we use that private key to create a Chef Client (with the workstation acting as the Chef User that creates the client).
If that file doesn't exist, we print out those 2 statements and proceed to create a new private key.  We write that private key to the remote AWS machine at /etc/chef/client.pem and then proceed with registering a new Chef Client.
So these error messages are purposeful if the AMI doesn't come pre-baked with a /etc/chef/client.pem file.  But I think we should put a check in there ahead of the read_file to see if that file exists on the remote machine.  Then we could avoid these weird messages.

Would be good to get this done, we get a lot of noise in our logs, its hard to track down the root cause, this just adds noise.


Only get sql logins if user is not external

This is an attempt to fix #32
Please refer to this issue for why this is required.

@magne Any chance to get feedback on this one? It would really help us to be able to create SQL users based on system assigned managed identities...


How to make it working with thermal printer

I am trying to make this snap working on Ubuntu Core with Custom thermal printers which are provided by the manufacturer with their own PPD files as well as CUPS filters. Now I wonder if there is any chance to make this snap working with this kind of printers.
This is the printer model I am working on right now: https://www.custom4u.it/pages/product/index.php
From the Driver tab it is possible to download a tar archive containing CUPS driver.

The PostScript Printer Applications is intended for PostScript printers, where the driver is just a PPD file. Then you can upload the PPD file into the Printer Application if it is not already included.
If your PPD file contains a *cupsfilter(2): ... line specifying a filter executable, the PostScript Printer Application cannot be used for it. For security reasons, none of the Printer Application Snaps allows uploading binary executables into them.
If you want to have your driver in a Snap, you could create your own based on pappl-retrofit with one or another of the existing Printer Application Snaps as a sample.
If it is only about to install your driver into a Printer Application so that you can use it with the CUPS Snap or be prepared to use it with CUPS 3.x, get pappl-retrofit and install its Legacy Printer Application. This Printer Application sees all normally installed CUPS drivers on a system and provides them as Printer Application.

All good, I am looking into it right now. However, for my understanding, installing pappl-retrofit is useful in a system where coexist a "classically installed CUPS with classically installed drivers" (https://openprinting.github.io/OpenPrinting-News-November-2021/#your-driver-not-in-a-printer-application---the-legacy-printer-application) and the snapped version of CUPS. Now, this is not a viable option for Ubuntu Core because it's not possible to install pappl-retrofit on it.

If you are on Ubuntu Core, (sorry, I perhaps overlooked it in the first place) you are on an all-Snap distro, so whatever software you install must exist in Snap format. This would mean that you have to create a Snap of your driver, based on pappl-retrofit (you do not need to install pappl-retrofit on your system to do so), and once having done so, you can install the Snap on your Ubuntu Core system.

To create such a Snap you can take the source code of the PostScript Printer Application  as an example. You need, via a part in snapcraft.yaml add your driver's CUPS filter(s) to the Snap, and add your PPDs to it. You can remove the PostScript PPDs from the Snap. And you should give the Snap another name, like thermal-printer-app.

I'm sorry for involuntary closing the issue, shame on me... That's right, working with Ubuntu Core put some fun in the game :) Thank you for pointing me out the way :)

With a bit of refactoring I've got a yaml that build a snap with PPD and filter files of my thermal printers. However when I try to add the printer through the web interface I get this error message: "Unable to use that driver".
I've put CUPS filters in this folder: usr/lib/thermal-printer-app/filter/ and PPD files in this one: usr/share/ppd/
Is there anything I'm not considering in order to make it works?

Could you make your work available to us? The snapcraft.yaml and also any additional files you created?

This is the yaml I am working on snapcraft.zip
I just removed a couple of things from the original one and copied PPD and filter in the directories I mentioned in the previous comment. In the same zip archive there are also PPD and raster files.


[ISSUE] accountStorageCredentialsImpl generates incorrect paths

Description
As reported in this TF issue
, the paths generated for Update function is incorrect. Comparing accountStorageCredentialsImpl to the doc, the Get & Delete functions are also incorrect
All of these paths are missing the credential name
https://github.com/databricks/databricks-sdk-go/blob/a77197b1261617695f349473154f744e606a014b/service/catalog/impl.go#L129
https://github.com/databricks/databricks-sdk-go/blob/a77197b1261617695f349473154f744e606a014b/service/catalog/impl.go#L138
https://github.com/databricks/databricks-sdk-go/blob/a77197b1261617695f349473154f744e606a014b/service/catalog/impl.go#L156

This has been resolved in the latest Go SDK release.


Added basic support for custom resource savers and loaders

Adds support for custom loaders and savers, so you can add new file types for Godot to load and save using ResourceLoader and ResourceSaver.
Jump here for updated proposal --> https://github.com/godotengine/godot/pull/19501#issuecomment-399802029

Old proposal:
It basically exposes an internal API which was however unfit for the scripting API, but changing this core API could be more work, so a compromise is taken:
Custom loaders and savers are nodes, which you can add as autoloads.
Plugins defining new filetypes can then add those autoloads automatically when the get activated and deactivated (however, see #19499).
Notes:

I only exposed the bare minimum, there are more methods that could be exposed but I either don't understand them or maybe they aren't needed for now. They can be exposed in the future.
I used multiple inheritance, but it should be OK because one of the classes is an interface (it doesn't contain data and has only virtual methods).
When you save a custom resource inheriting Resource, Godot still defaults to .tres in the save dialog, so you have to select the custom extension manually. I would like to make it default to the custom extension (or even remove the others), but I couldn't find how.
If I use remove_autoload_singleton when my plugin exits the tree, Godot now crashes everytime on exit with errors about the scene tree. I think EditorPlugin needs an additional function to know when it's disabled or enabled, as opposed to just being added or removed from the tree, because there is no clean way to differentiate this from an editor launch or exit (can't use is_plugin_enabled because it isn't updated in time) @vnen
Here is the test project I used:
CustomResourceLoader.zip

I worked on making ResourceFormatLoader a Reference, and added a way to register loaders and savers into the project settings through an EditorPlugin API. However, I still had the following problems:

A plugin needs to know when it was enabled or disabled, because currently _exit_tree and _enter_tree are ambiguous. For example, if you want to cleanup an autoload when the plugin gets disabled by using _exit_tree, it would prevent it from staying in ProjectSettings when the user just closes the editor. So I added enable_plugin and disable_plugin to do those registrations.

I need to store the list of custom loaders and savers into a setting in ProjectSettings. I've been trying to save it to `project.godot, which seemed to work, however Godot doesn't find the setting when I load either the editor or the game. What do I have to do for this setting to be recognized?

Promoting autoload to not be limited to nodes. This would allow singletons like custom loaders to exist using the same API. However, it still requires plugin makers to write [boilerplate] code to register them, and the editor has to run this code at the right time. Which leads me to another idea below...

format savers and loaders could be just another thing different that autoload, should not be a problem.

Instead of requiring the plugin maker to implement callbacks to register their autoloads and loaders with code, we could have a .cfg next to the plugin that Godot will parse (in editor or in game)

In game this is not possible, because Godot will never do project filesystem scanning on startup, this does need to be registered in the editor at some point, and I think when plugin is disabled/enabled is probably the best time.

In game this is not possible, because Godot will never do project filesystem scanning on startup

Godot does not need to do that because the addons folder is fixed and obeys to specific rules (res://addons/<addon_name>/file.cfg).

format savers and loaders could be just another thing different that autoload, should not be a problem.

Ok, but how do I make the setting recognized? What I tried so far didn't work.
Should I also implement a UI for users to add them manually etc?

I've been trying to save it to `project.godot, which seemed to work, however Godot doesn't find the setting when I load either the editor or the game. What do I have to do for this setting to be recognized?

I think it should "just work", but maybe there's some bug?. Are you adding using the ProjectSettings API or manually with a text editor?
It could just be stored in project.godot like the autoloads and be registered in main.cpp (at least in game). Since it's a file loaded early anyway, you wouldn't need to export more files, convert them to binary on export, and search the addons folder on startup.

@vnen I'm adding the settings with ProjectSettings::set("loaders", loaders);, and they do get saved by Godot. However I get nothing when I load back the project.

I updated the PR with the new approach:

ResourceFormatLoader and ResourceFormatSaver are now references. I left the existing logic, replacing it with references. Let me know if more should be done.
It's now possible to remove loaders and savers, though in practice only custom ones will do this
Added enable_plugin and disable_plugin so plugins can register loaders or autoloads properly (see above conversastion about why)
ProjectSettings can now have a list of enabled custom loaders and savers, under loaders/enabled and savers/enabled, which are PoolStringArrays containing their scripts.
Added CustomResourceLoader and CustomResourceSaver which you can inherit with a script to define new loaders and savers. Register them in project settings using new functions of EditorPlugin.

Tested so far using this project:
CustomResourceLoader.zip
@vnen it looks like adding the project setting within a category made it work. Somehow it didn't when it was outside.

Formatting needs to be fixed :)

@mhilbrunner but when I run clang-format on register_scene_types.cpp, nothing changes :(

@Zylann depending on the clang-format version it gives different results. It's simpler to apply the patch that Travis gives just to make it pass.

@vnen see, just rebased and the errors went away :)

Rebased again and updated.

I think this is mostly OK, do you think you could change the PR to only include the changes to format loaders/savers? I am still not convinced on the way of registering those from editor, and given we now have named classes, we could take advantage of this system and get those added directly and automatically by checking inheritance from ResourceFormatLoader and ResourceFormatSaver.. so registration can be completely transparent.
@vnen what do you think?

@reduz so the fact a custom loader exists in the project's scripts would make them available? I thought you didn't want a full-project parse at some point (or editor-only?)

[...] given we now have named classes, we could take advantage of this system and get those added directly and automatically by checking inheritance from ResourceFormatLoader and ResourceFormatSaver.. so registration can be completely transparent.

That might be simpler, but also (as @Zylann said) it's not possible to disable the loaders/savers (though it might not be really needed). The major issue for plugins is that named classes have no namespace, so they have to use some unique naming convention.

I thought you didn't want a full-project parse at some point (or editor-only?)

This would happen only in editor. The inheritance of named script classes are already checked and saved in the project.godot file. There's not much difference in checking a list of registered loaders/savers and checking the list of script classes.

So what should I remove from this PR, and how should we do registration?

I updated the PR:

Now registration is done through global class names (class_name in GDScript)
Tested with the following project: CustomLoaders.zip

Moving to 3.2 milestone as we're about to enter the beta stage and release freeze for Godot 3.1. Only bug fixes against issues of the 3.1 milestone (or enhancements to core features of the 3.1 roadmap) will be considered until 3.1-stable is released.
Note: If it's merged after 3.1-stable is released, this change might be considered for cherry-picking into a later 3.1.x release.


Disable save button when image upload process not finished

Issue Summary
Uploading an image with the old image uploader modal allows you to click save even tho the upload process is not finished yet. This causes the image to be blank.
Note: this also happens in General settings when using the new uploader in general settings. But is not as confusing imo as there's no modal that closes after saving.
Steps to Reproduce

Go to your user profile
Throttle the internet connection or use a particularly large image so you'll see the progress bar for a bit
Upload either profile or cover image
Click save before the upload is finished
See that no image is saved

Expected behaviour
I would expect the save button to be disabled until the upload process is finished.
Technical details:

Ghost Version: 60558a776fa76d8567dce5a226baf9d9baa208a4
Node Version: v 6.11.1
Browser/OS: Chrome 59.0.3071.115 / macOS Sierra
Database:  sqlite3

Note: this also happens in General settings when using the new uploader in general settings. But is not as confusing imo as there's no modal that closes after saving.

What we could do there is prevent leaving the settings screen whilst an upload is in progress by displaying a similar "Are you sure?" modal to the one used when leaving the editor with unsaved changes. This could be rolled up as part of https://github.com/TryGhost/Ghost/issues/8483


Radaxa ROCK ZERO 3W version to buy.

Hello, currently there is an many versions of radaxa 3W you can buy,
such as

1GB of RAM and 8GB EMMC
2GB of RAM and 16GB EMMC
4GB of RAM and 32GB EMMC
8GB of RAM and 64GB EMMC

The quesiton is which one is minimum for run OpenIPC without issues?
Many thanks.
Alex

It's been confirmed to run on as little as 1GB or RAM, and EMMC is optional.


update ruble sign

Hello. I have update ruble sign to official.
About ruble sign here.
New sign: ₽ ( U+20BD )
Related issue: #262

Please, repeat review of pr.

@sanekyy – please fix tests!
Also: this should change should be mentioned in the changelog.
CC @davidmorgan

@kevmoo fixed.

Hello @kevmoo @davidmorgan @srawlins
Can you help to merge this PR?
one and half year waiting:(

This needs merge conflict resolution, but LGTM apart from that, as we don't get the currency symbols from CLDR.


futures==2.2.0 distribution not found

I get this error when running mapbox:
pkg_resources.DistributionNotFound: The 'futures==2.2.0' distribution was not found and is required by boto3
Full dump of error output: https://gist.github.com/lxbarth/5559bec90ebccdad16ce
My python version:
$ python --version
Python 2.7.11

@lxbarth thanks for finding this one. It looks like your futures package was upgraded to version 3 but one of the mapbox dependencies (boto3) requires the older version 2.2.0. I can reproduce by upgrading futures to the latest version - I get the same error. If I downgrade futures back to 2.2.0, things work. So the temporary solution is
pip install "futures==2.2.0"

@sgillies Is this a problem we could solve with a constraint file?

The problem is that the boto3 devs have published a defective binary distribution. The workaround is to avoid that binary with the use of pip's --no-binary option.
@lxbarth can you try pip install -U pip; pip install -U --no-binary boto3 mapboxcli for me?
@perrygeo I'll make a ticket in the boto3 repo.

pip install "futures==2.2.0"
addresses the error I described in the original post.
I ran pip install --upgrade futures to bring the error back, then ran
pip install -U pip; pip install -U --no-binary boto3 mapboxcli as @sgillies requested which causes this error:
No such file or directory: '/usr/local/lib/python2.7/site-packages/click_plugins-1.0-py2.7.egg'
Details: https://gist.github.com/lxbarth/2148764a5e079e3238d4

Update: my workaround isn't reliable. It prevents installation errors but as pointed out above, the loading of the command plugins fails because setuptools still sees a futures==2.2.0 requirement. For a full fix, I'm looking into publishing a patched version of boto3 and ensuring its use with mapboxcli via a constraints.txt file like this pip install mapboxcli -c https://raw.githubusercontent.com/mapbox/mapbox-cli-py/master/constraints.txt.

Proposed fix is going to work.
(boto3-commit-test)MapBox-FC:tmp sean$ pip install git+https://github.com/boto/boto3.git@7910662a4c7b841ea50211c4130e97f05e7241ab#egg=boto3
Collecting boto3 from git+https://github.com/boto/boto3.git@7910662a4c7b841ea50211c4130e97f05e7241ab#egg=boto3
  Cloning https://github.com/boto/boto3.git (to 7910662a4c7b841ea50211c4130e97f05e7241ab) to /private/var/folders/zq/fv6jds3j4wb_0z0zh35xky_c0000gn/T/pip-build-u2fFZR/boto3
  Could not find a tag or branch '7910662a4c7b841ea50211c4130e97f05e7241ab', assuming commit.
Collecting botocore<1.4.0,>=1.3.0 (from boto3)
  Using cached botocore-1.3.12-py2.py3-none-any.whl
Collecting jmespath<1.0.0,>=0.7.1 (from boto3)
  Using cached jmespath-0.9.0-py2.py3-none-any.whl
Collecting futures<4.0.0,>=2.2.0 (from boto3)
  Using cached futures-3.0.3-py2-none-any.whl
Collecting python-dateutil<3.0.0,>=2.1 (from botocore<1.4.0,>=1.3.0->boto3)
  Using cached python_dateutil-2.4.2-py2.py3-none-any.whl
Collecting docutils>=0.10 (from botocore<1.4.0,>=1.3.0->boto3)
Collecting six>=1.5 (from python-dateutil<3.0.0,>=2.1->botocore<1.4.0,>=1.3.0->boto3)
  Using cached six-1.10.0-py2.py3-none-any.whl
Installing collected packages: jmespath, six, python-dateutil, docutils, botocore, futures, boto3
  Running setup.py install for boto3
Successfully installed boto3-1.2.2 botocore-1.3.12 docutils-0.12 futures-3.0.3 jmespath-0.9.0 python-dateutil-2.4.2 six-1.10.0
(boto3-commit-test)MapBox-FC:tmp sean$ pip install mapboxcli
Collecting mapboxcli
  Using cached mapboxcli-0.1.0-py2-none-any.whl
Collecting mapbox==0.5 (from mapboxcli)
  Using cached mapbox-0.5.0-py2-none-any.whl
Collecting cligj (from mapboxcli)
  Using cached cligj-0.3.0-py2-none-any.whl
Collecting click (from mapboxcli)
  Using cached click-6.2-py2.py3-none-any.whl
Collecting click-plugins (from mapboxcli)
  Using cached click_plugins-1.0.2-py2.py3-none-any.whl
Requirement already satisfied (use --upgrade to upgrade): six in /Users/sean/envs/boto3-commit-test/lib/python2.7/site-packages (from mapboxcli)
Requirement already satisfied (use --upgrade to upgrade): boto3 in /Users/sean/envs/boto3-commit-test/lib/python2.7/site-packages (from mapbox==0.5->mapboxcli)
Collecting uritemplate.py (from mapbox==0.5->mapboxcli)
Collecting requests (from mapbox==0.5->mapboxcli)
  Using cached requests-2.8.1-py2.py3-none-any.whl
Requirement already satisfied (use --upgrade to upgrade): botocore<1.4.0,>=1.3.0 in /Users/sean/envs/boto3-commit-test/lib/python2.7/site-packages (from boto3->mapbox==0.5->mapboxcli)
Requirement already satisfied (use --upgrade to upgrade): jmespath<1.0.0,>=0.7.1 in /Users/sean/envs/boto3-commit-test/lib/python2.7/site-packages (from boto3->mapbox==0.5->mapboxcli)
Requirement already satisfied (use --upgrade to upgrade): futures<4.0.0,>=2.2.0 in /Users/sean/envs/boto3-commit-test/lib/python2.7/site-packages (from boto3->mapbox==0.5->mapboxcli)
Requirement already satisfied (use --upgrade to upgrade): python-dateutil<3.0.0,>=2.1 in /Users/sean/envs/boto3-commit-test/lib/python2.7/site-packages (from botocore<1.4.0,>=1.3.0->boto3->mapbox==0.5->mapboxcli)
Requirement already satisfied (use --upgrade to upgrade): docutils>=0.10 in /Users/sean/envs/boto3-commit-test/lib/python2.7/site-packages (from botocore<1.4.0,>=1.3.0->boto3->mapbox==0.5->mapboxcli)
Installing collected packages: click, click-plugins, cligj, uritemplate.py, requests, mapbox, mapboxcli
Successfully installed click-6.2 click-plugins-1.0.2 cligj-0.3.0 mapbox-0.5.0 mapboxcli-0.1.0 requests-2.8.1 uritemplate.py-0.3.0
(boto3-commit-test)MapBox-FC:tmp sean$ mapbox directions --help
Usage: mapbox directions [OPTIONS] [WAYPOINTS]...

  Calculate optimal route with turn-by-turn directions between up to 25
  waypoints.

    $ mapbox directions "[-122.681032, 45.528334]" "[-122.71679, 45.525135]"

  An access token is required, see `mapbox --help`.

Options:
  --profile [mapbox.driving|mapbox.walking|mapbox.cycling]
                                  Mapbox direction profile id
  --alternatives / --no-alternatives
                                  Generate alternative routes?
  --instructions [text|html]      Format for route instructions
  --geometry [geojson|polyline|false]
                                  Geometry encoding
  --steps / --no-steps            Include steps in the response
  --geojson / --no-geojson        Return geojson feature collection (default:
                                  full response json)
  -o, --output TEXT               Save output to a file.
  --help                          Show this message and exit.

@lxbarth @perrygeo I've updated the installation instructions https://github.com/mapbox/mapbox-cli-py#installation. You can either do the two step as shown in the README, or do it in one line: pip install mapboxcli -c https://raw.githubusercontent.com/mapbox/mapbox-cli-py/master/constraints.txt


ntlm: RDoc is not a full Ruby parser and will fail when fed invalid ruby programs: undefined method `[]' for nil:NilClass

First and foremost, many thanks for this library! 🙇 👍
FYI and in case something can be done about it, I got an error related to ntlm's documentation during installation:
$ gem install kindle-highlights
Fetching unf_ext-<IP_ADDRESS>.gem
Fetching unf-0.1.4.gem
Fetching domain_name-0.5.20190701.gem
Fetching webrobots-0.1.2.gem
Fetching net-http-persistent-3.1.0.gem
Fetching ntlm-http-0.1.1.gem
Fetching http-cookie-1.0.3.gem
Fetching connection_pool-2.2.2.gem
Fetching kindle-highlights-2.0.1.gem
Fetching mime-types-data-3.2019.1009.gem
Fetching mime-types-3.3.1.gem
Fetching net-http-digest_auth-1.4.1.gem
Fetching mechanize-2.7.6.gem
Building native extensions. This could take a while...
Successfully installed unf_ext-<IP_ADDRESS>
Successfully installed unf-0.1.4
Successfully installed domain_name-0.5.20190701
Successfully installed webrobots-0.1.2
Successfully installed ntlm-http-0.1.1
Successfully installed http-cookie-1.0.3
Successfully installed connection_pool-2.2.2
Successfully installed net-http-persistent-3.1.0
Successfully installed mime-types-data-3.2019.1009
Successfully installed mime-types-3.3.1
Successfully installed net-http-digest_auth-1.4.1
Successfully installed mechanize-2.7.6
Successfully installed kindle-highlights-2.0.1
Parsing documentation for unf_ext-<IP_ADDRESS>
Installing ri documentation for unf_ext-<IP_ADDRESS>
Parsing documentation for unf-0.1.4
Installing ri documentation for unf-0.1.4
Parsing documentation for domain_name-0.5.20190701
Installing ri documentation for domain_name-0.5.20190701
Parsing documentation for webrobots-0.1.2
Installing ri documentation for webrobots-0.1.2
Parsing documentation for ntlm-http-0.1.1
Before reporting this, could you check that the file you're documenting
has proper syntax:

  ${HOME}/.rbenv/versions/2.6.3/bin/ruby -c lib/net/ntlm.rb

RDoc is not a full Ruby parser and will fail when fed invalid ruby programs.

The internal error was:

	(NoMethodError) undefined method `[]' for nil:NilClass

ERROR:  While executing gem ... (NoMethodError)
    undefined method `[]' for nil:NilClass

$ which ruby
${HOME}/.rbenv/shims/ruby

$ ruby -v
ruby 2.6.3p62 (2019-04-16 revision 67580) [x86_64-darwin19]

$ gem env
RubyGems Environment:
  - RUBYGEMS VERSION: 3.0.3
  - RUBY VERSION: 2.6.3 (2019-04-16 patchlevel 62) [x86_64-darwin19]
  - INSTALLATION DIRECTORY: ${HOME}/.rbenv/versions/2.6.3/lib/ruby/gems/2.6.0
  - USER INSTALLATION DIRECTORY: ${HOME}/.gem/ruby/2.6.0
  - RUBY EXECUTABLE: ${HOME}/.rbenv/versions/2.6.3/bin/ruby
  - GIT EXECUTABLE: /usr/local/bin/git
  - EXECUTABLE DIRECTORY: ${HOME}/.rbenv/versions/2.6.3/bin
  - SPEC CACHE DIRECTORY: ${HOME}/.gem/specs
  - SYSTEM CONFIGURATION DIRECTORY: ${HOME}/.rbenv/versions/2.6.3/etc
  - RUBYGEMS PLATFORMS:
    - ruby
    - x86_64-darwin-19
  - GEM PATHS:
     - ${HOME}/.rbenv/versions/2.6.3/lib/ruby/gems/2.6.0
     - ${HOME}/.gem/ruby/2.6.0
  - GEM CONFIGURATION:
     - :update_sources => true
     - :verbose => true
     - :backtrace => false
     - :bulk_threshold => 1000
  - REMOTE SOURCES:
     - https://rubygems.org/
  - SHELL PATH:
     - ${HOME}/.rbenv/versions/2.6.3/bin
     - /usr/local/Cellar/rbenv/1.1.2/libexec
     - ${HOME}/.gem/ruby/2.6.0/bin
     - ${HOME}/.rbenv/shims
     - /usr/local/bin
     - /usr/local/sbin
     - ${HOME}/bin
     - /usr/bin
     - /bin
     - /usr/sbin
     - /sbin
     # <redacted>

It didn't seem to prevent from importing the library though:
$ irb
irb(main):001:0> require 'kindle_highlights'
=> true

I'm experiencing this issue as well 👍

There are some issues with the current implementation because Amazon has changed the structure of their login page. I am working on a fix but don't have an ETA.


Is dbutils supported in non-notebook jobs?

This page states, "All dbutils utilities are available in Python, R, and Scala notebooks." However, it is not clear whether dbutils is supported in non-notebook jobs (e.g. submitting a *.py file as a job).

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 1c1af686-fd41-47e8-a6cb-70197f33bc67
Version Independent ID: 6cc4bc4f-850d-9061-d66d-68620b4baa29
Content: Databricks Utilities - Azure Databricks
Content Source: databricks/dev-tools/databricks-utils.md
Service: azure-databricks
GitHub Login: @mamccrea
Microsoft Alias: mamccrea

@travis-c-lagrone Thank you for reaching out and bringing this to our notice. At this time we are reviewing the feedback and will provide an update as appropriate

@travis-c-lagrone  Yes, All dbutils utilities are available in Python, R, and Scala notebooks.
This is by design and not supported to run by pointing to executors via jobs.
If you run "dbuitls" in jobs, you will receive this error: "You cannot use dbutils within a spark job or otherwise pickle it".
Hope this helps.

I have updated the doc to make this more clear. If you have any additional questions, please reopen this issue.
#please-close


Structure growth doesn't always update fields

I have a structure:
struct VmState __packed
{
    uint16_t RA;
    uint16_t RB;
    uint16_t RC;
    uint16_t RD;
    uint16_t BP;
    uint16_t SP;
    uint16_t PC;
    uint16_t CondPC;
    uint16_t Flags;
}

It works like I expect (woo!):
00400f5d  struct VmState* vm = arg1->vm
00400f73  fprintf(stream: *stderr, format: "RA: %04x\n", zx.q(vm->RA))
00400f8b  fprintf(stream: *stderr, format: "RB: %04x\n", zx.q(vm->RB))
00400fa3  fprintf(stream: *stderr, format: "RC: %04x\n", zx.q(vm->RC))

I find some more fields, and add them, growing the structure:
struct VmState __packed
{
    uint16_t RA;
    uint16_t RB;
    uint16_t RC;
    uint16_t RD;
    uint16_t BP;
    uint16_t SP;
    uint16_t PC;
    uint16_t CondPC;
    uint16_t Flags;
    uint16_t Scratch0;
    uint16_t AddTmp;
    uint16_t SubTmp;
    uint16_t CmpTmp;
    uint16_t MemValue;
    uint16_t MemReg;
    uint16_t ConstantOne;
};

However, in that same function, the previous undef results aren't updated:
0040111c  fprintf(stream: *stderr, format: "Scratch0: %04x\n", zx.q(vm->__offset(0x12).w))
00401134  fprintf(stream: *stderr, format: "AddTmp: %04x\n", zx.q(vm->__offset(0x14).w))
0040114c  fprintf(stream: *stderr, format: "SubTmp: %04x\n", zx.q(vm->__offset(0x16).w))

Changing graph/linear and cycling through all the ILs doesn't cause this to update automatically. If I re-set the type on vm however, this will update. This definitely does work sometime, so I'm not sure what the issue here is. Relevant function is DumpMemory.
rootkit.txt

Does updating analysis for the function fix the IL?

I have encountered similar issues. Sometimes creating new fields in a
structure also fail to trigger an update. In my case, updating the analysis
does fix the issue
On Sat, Oct 24, 2020 at 18:28 Peter LaFosse<EMAIL_ADDRESS>wrote:

Does updating analysis for the function fix the IL?
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/Vector35/binaryninja-api/issues/2060#issuecomment-715894643,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AAZZK3RPAMP5Z6Y2N35RFGLSMKT3XANCNFSM4S5PHQRQ
.

No it does not, presuming that I'm updating analysis correctly (right click -> reanalyze current function).

I cannot reproduce this. Given this issue has been there for a while, it might have been fixed earlier. If one can still reproduce it, please quote me with some details and I can start checking it out again.

Nope, this is not fixed. The HLIL appears to be correct thanks to the periodic update of the display, though the type changes are not propagated in the system

This should have been fixed when I merged the PR on type xref. Now when a type (in the type view) changes, all functions that references it gets updated. I am closing this, but if anyone has more information on this, please free feel to reopen it.

@jeffli678 I was just able to reproduce this again -- you can see the definition for hash_entry is out of sync.

One thing I realized I do which might be relevant: I will frequently split a bndb to two tabs tab, and one tab be disas while the other stays on the types view. Could this be the pattern that causes this desync?
Attached bndb also demonstrates the problem -- if i re-declare the variable at hlil addr 000015ba it will be resolved.
mooosl - Copy.bndb.txt

Sorry, this was on 2780-dev

yrp reported another way to trigger this, though in a slightly more complex way

moved the report to a dedicated issue: https://github.com/Vector35/binaryninja-api/issues/2428


Shard the smoke tests in CircleCI

Waiting an hour is so long...
See https://circleci.com/gh/googleapis/artman/8385 for example run.

The tests are going to be replaced by bazel presubmits.


Unable to retrive the suborganization list

Describe the issue:

Unable to retrieve the suborganization list.

Getting a 400 Bad Request in the ME endpoint.
https://github.com/wso2/product-is/assets/40081059/01eb3a12-6f96-4791-b1c7-27851d8bc562
How to reproduce:

Expected behavior:

Environment information (Please complete the following information; remove  any unnecessary fields) :

Product Version: [e.g., IS 5.10.0, IS 5.9.0]
OS: [e.g., Windows, Linux, Mac]
Database: [e.g., MySQL, H2]
Userstore: [e.g., LDAP, JDBC]

Optional Fields
Related issues:

Suggested labels:

This is working fine in the latest pack.


홈/알림 페이지

https://github.com/gracefullight/doss/commit/0774a83b57e3ec814b231ce33290bf112185326f
https://github.com/gracefullight/doss/commit/a32330eb015c8e2c78644f6518e4cb3995dcdc9b


More mod support (Promenade, Cinderscapes, Regions Unexplored)

Support for the Promenade mod.
I'm not sure if it matters but Promenade is under the LGPL-3.0-only license.
Support for the Cinderscapes mod.
License: LGPL-3.0-only
Support for the Regions Unexplored mod.
License: ARR
Permission: :+1:
Feedback is appreciated!
(Also i accidentaly added Cinderscapes bc idk how github works)

Regions Unexplored foods
https://github.com/Theoness1/EatingAnimation/assets/68734661/0e128f3c-b3ec-4eea-8c20-c8eb338ec504
I'm not really sure about the Salmon berry animation


I have modified some misspellings!

To report bugs or submit patches to Android, please follow the instructions at http://source.android.com/source/contributing.html.  More information on these mirrors (like the fact that issues and pull requests are ignored) is available at http://aosp-mirror.github.io/.


No line breaks show in MultilineEntry

MultilineEntry does not display line breaks if those are supplied with set_value, such as
let mut mle = MultilineEntry::new(&ui);
mle.set_value(&ui, "hello\nworld");

The MultilineEntry will show "helloworld".
The text returned from that MultilineEntry will be shown correctly with a line break when displayed with println!("{}", mle.value(&ui));

No worries, thanks for your help! Yes, I am on Windows indeed.

I suspect this is because Windows wants \r\n line endings. Could you try that and let me know if it works?

I can confirm mle.set_value(&ui, "hello\r\nworld"); works as expected, producing a line break in Windows.

Possible solution: on Windows, the API can automatically replace \n with \r\n, and on other platforms, we'll do the inverse.


checkErrorResponse documented in the tutorial

This is a follow-up to https://github.com/badges/shields/pull/1670
This change contains:

up-to-date code example from server.js
checkErrorResponse function mentioned in tutorial
static badges as example of errors (https://img.shields.io/docker/automated/,/ubuntu-remix.svg is no longer "invalid")
up-to-date links to server.js

Messages

:book:

:sparkles: Thanks for your contribution to Shields, @platan!

:book:

Thanks for contributing to our documentation. We :heart: our documentarians!

  Generated by :no_entry_sign: dangerJS


Transferring large files from iPhone to desktop or browser cause iPhone app to crash

Describe the bug
When transferring large files from iPhone to desktop (using browser or the app), the iPhone app crashes after a couple of seconds and the transfer fails. The port is opened, the settings are correct, I've tried multiple file types, I made sure all programs are the most recent version, and I've tried from both file manager and photo library. Tried reinstalling app and resetting phone. 1 GB files worked fine, 3 GB+ caused the crash.
To reproduce

Add files or folders to localsend.
On desktop, go on browser or accept the transfer through localsend.
Watch the iPhone app crash as soon as the large file's transfer begins.

Expected behavior
I expected the file to transfer to the computer and for the app not to crash.
Screenshots
No Screenshots, the app just crashes
Desktop (please complete the following information)
Windows 11 Home
Smartphone (please complete the following information)
Latest iOS, iPhone 13 Pro Max
Additional context
No response

Same as here
Here is the video
iPhone is on iOS 18 beta 5
https://github.com/user-attachments/assets/71d06ae1-bc9d-4045-ae18-fc0a919dac01

Same here, but in my case none of the file sharing projects I have tested so far are working with my videos. If I add them via the iPhone gallery, the app hangs. Maybe it's processing. If I save them to Files and send them that way, then the same issue as @Kayxue's video happens. Here's the error I'm getting:
HttpException: Connection closed while receiving data, uri = /api/localsend/v2/upload?sessionId=something&token=something

@Tienisto Is there any stream by chunk processing? After looking through some code, I suspect the file is not read by chunks, but fully loaded into memory (RAM) using OpenFilex here.
I'm not familiar with the codebase, but trying to figure this out.
https://github.com/localsend/localsend/blob/d9dff50d15464666103c75555c4a2c375e5c7700/app/lib/util/native/open_file.dart#L25

@MaxRev-Dev This is only the code to open a local file in an external application (e.g. PDF viewer).
The actual sending process is here:
https://github.com/localsend/localsend/blob/d9dff50d15464666103c75555c4a2c375e5c7700/app/lib/provider/network/send_provider.dart#L366
I've tested this on Windows and Android with a file that exceeds available RAM on Android.

I'm facing this same issue on android for a while. Transferring large amounts of files (in quantity, not in size) makes the mobile app stop.
I have Localsend installed on both mobile (android) and desktop (windows). Both of them are running version 1.15.3 (latest). When I try to transfer about 5000 image files (~600mb) from my android to my desktop, it crashes. Strange enough, Localsend doesn't crashes when sending few files with a large size on total (5 files, ~200mb each).
If this information helps, my device is a really low end LgK40s, which in my country is 32bits and has 3gb of ram.


Create a file describing what is open source and why it is important. upload it in the main

file name should be "Open Source"

hey assign this to me please.. also do i have to make it under notes?


[PE-D][Tester A] Module retake not allowed

My current module list is like this:

Assume that I failed CS2109S on Y2S2 and I need to take this module again in order to pass because it's a compulsory module. So I plan to retake it on Y3S1.
So I keyed in add /m CS2109S /c 4 /y y3s1
However, I am not allowed to do so.

In my humble opinion, you could consider allow duplicate module on later years given the module failed before.

Labels: type.FeatureFlaw severity.Medium
original: DerrickSaltFish/ped#2

Add Note in UG to explain.


Support Proposed Base Profile / Unitary QIR

In discussion in a QIR working group is the "base profile," the lowest common denominator for all QIR programs, or the minimal useful program.
Proposed by a partner is the following definition:

A single function which is also the entrypoint
That function's body contains a single basic block, which itself contains a quantum program, composed of only quantum intrinsics.
Its terminator - because a terminator is required - is a ret void instruction.
double parameters are supported, but those parametric values must be arguments to the function

Any deviation from this pattern should result in an error. Shot counts will be provided to the runtime as metadata rather than directly within the program.
The output/target, in this case, should be selectable; either Quil program text or LLVM IR.
Worth consideration:

user selection of the profile, so as to choose whether to support the shot-count pattern or this simpler pattern
reusability and composability of patterns

Some public info on Base Profile:
https://github.com/microsoft/qsharp-language/blob/ageller/profile/Specifications/QIR/Base-Profile.md

Done
Operation
LLVM Function Declaration
Description

:heavy_check_mark:
CCX, CCNOT, Toffoli
@__quantum__qis__toffoli_body (%Qubit*, %Qubit*, %Qubit*)
Toffoli or doubly-controlled X

:heavy_check_mark:
CX, CNOT
@__quantum__qis__cnot_body (%Qubit*, %Qubit*)
CNOT or singly-controlled X

:heavy_check_mark:
CZ
@__quantum__qis__cz_body (%Qubit*, %Qubit*)
Singly-controlled Z

:heavy_check_mark:
H
@__quantum__qis__h_body (%Qubit*)
Hadamard

:heavy_check_mark:
MZ or MEASURE
@__quantum__qis__mz_body (%Qubit*, i32)
Measure a qubit along the the Pauli Z axis

:heavy_check_mark:
RESET
@__quantum__qis__reset_body (%Qubit*)
Prepare a qubit in the |0⟩ state

:heavy_check_mark:
RX
@__quantum__qis__rx_body (double, %Qubit*)
Rotate a qubit around the X axis

:heavy_check_mark:
RY
@__quantum__qis__ry_body (double, %Qubit*)
Rotate a qubit around the Y axis

:heavy_check_mark:
RZ
@__quantum__qis__rz_body (double, %Qubit*)
Rotate a qubit around the  Z axis

:heavy_check_mark:
S
@__quantum__qis__s_body (%Qubit*)
S (phase pi/2 gate)

:heavy_check_mark:
DAGGER S
@__quantum__qis__s_adj (%Qubit*)
The adjoint of S

:heavy_check_mark:
T
@__quantum__qis__t_body (%Qubit*)
T (phase pi/4 gate)

:heavy_check_mark:
DAGGER T
@__quantum__qis__t_adj (%Qubit*)
The adjoint of T

:heavy_check_mark:
X
@__quantum__qis__x_body (%Qubit*)
Pauli X

:heavy_check_mark:
Y
@__quantum__qis__y_body (%Qubit*)
Pauli Y

:heavy_check_mark:
Z
@__quantum__qis__z_body (%Qubit*)
Pauli Z

:heavy_check_mark:
SWAP
@__quantum__qis__swap_body (%Qubit*, %Qubit*)
SWAP q1 and q2

Checklist:

[ ] Handle EntryPoint (#14)
[x] Implement gate set
[x] Implement runtime record functions
[ ] Validate only double params used in gate instructions

[x] implicitly by LLVM type system
[ ] explicitly by pattern code (may not be necessary)

[ ] --format flag, options: unitary or shot-count
[ ] works with both transform (output: LLVM IR) and transpile-to-quil (output: Quil + recorded output mapping, no shot count)

Closed in #30.


How give Monero a RPC Username and Password?

How do you give this Monero docker a RPC Username and Password?

In docker-compose.yaml - look under monerod for- command: monerod --rpc-command-here
This will send commands to monerod when you run docker.

Thank you @clearwater-trust for that. I was able to get it going by removing --public-node and adding --rpc-login per the RPC documentation here in that section of the docker-compose.yaml.


Show number of confirmations on transaction details view

Currently it is blank.
Also, TxType should not be in all caps. Just first letter capitalized.

i have create a PR for this, kindly review

Solved at #32

Verified working in latest build.


Modify Navigation Bar

@5tupidbrain @riturajjain2000 I would like to work on modifying the navigation bar. Here are the changes that I propose to make

Alter the properties of the navigation bar to give it a fixed position on top of the screen, so that it stays on top of the screen even if we scroll to the end of the page.

I would like to add the color-changing property to the navbar which changes its color when we scroll halfway down the length of the page to give it an appealing look. I will be using React State property to accomplish this task.

I request you to please assign me this issue.

Please assign this task to me uder Gssoc 2021

Can I work on this issue?

Please assign it to me.


[BUG] No logs in console with Serilog inside NoopTransaction (disabled ElasticApm scenario)

ECS library: Elastic.CommonSchema.Serilog
ECS schema version: 1.5.0
ECS .NET assembly version: 1.5.3 (earlier and current alfa too)
APM .NET Agent: 1.11.0
.NET framework / OS: .net 5
Description of the problem, including expected versus actual behavior:

Use logging (AddSerilog()) and tracing (UseElasticApm())
Disable ElasticApm ("ElasticApm": { "Enabled": "false" } })
Log something inside transaction

Example:
_logger.LogWarning("Before");
var transaction = _tracer.StartTransaction(GetType().Name, ApiConstants.ActionExec);
try
{
	_logger.LogWarning("Inside");
}
finally
{
	transaction?.End();
}
_logger.LogWarning("After");

Actual behavior:
Tracing disabled; No logged messages inside transaction in console.
Example output:
{"@timestamp":"2021-08-18T20:19:17.5361091+03:00","log.level":"Warning","message":"Before","metadata":...}
{"@timestamp":"2021-08-18T20:19:17.5381091+03:00","log.level":"Warning","message":"After","metadata":...}

Expected behavior:
Tracing disabled, but log messages should be written to output
Desired output:
{"@timestamp":"2021-08-18T20:19:17.5361091+03:00","log.level":"Warning","message":"Before","metadata":...}
{"@timestamp":"2021-08-18T20:19:17.5371091+03:00","log.level":"Warning","message":"Inside","metadata":...}
{"@timestamp":"2021-08-18T20:19:17.5381091+03:00","log.level":"Warning","message":"After","metadata":...}

Steps to reproduce:

Disable ElasticApm
Enable Serilog.SelfLog to easily catch exception: Serilog.Debugging.SelfLog.Enable(msg => Debug.WriteLine(msg));
NullReferenceException is thrown:

caught exception while emitting to sink Serilog.Sinks.SystemConsole.ConsoleSink: System.NullReferenceException: Object reference not set to an instance of an object.
  at Elastic.CommonSchema.Serilog.LogEventConverter.GetTrace(LogEvent logEvent)
  at Elastic.CommonSchema.Serilog.LogEventConverter.ConvertToEcs(LogEvent logEvent, IEcsTextFormatterConfiguration configuration)
  at Elastic.CommonSchema.Serilog.EcsTextFormatter.Format(LogEvent logEvent, TextWriter output)
  at Serilog.Sinks.SystemConsole.ConsoleSink.Emit(LogEvent logEvent)
  at Serilog.Core.Sinks.SafeAggregateSink.Emit(LogEvent logEvent)

Reasons and fix ideas:

NoopTransaction is returned for disabled APM:
https://github.com/elastic/apm-agent-dotnet/blob/07a448406c78871a59088f87edaf3bcc191c2e67/src/Elastic.Apm/Api/Tracer.cs#L65

ElasticApmEnricher for NoopTransaction adds properties ElasticApmTransactionId, ElasticApmTraceId equal null here:
https://github.com/elastic/ecs-dotnet/blob/d1d5b770fc15a81e8883175abe05315c8e525213/src/Elastic.Apm.SerilogEnricher/ElasticApmEnricher.cs#L26

option 1 to fix - adjust ElasticApmEnricher: if (Agent.Tracer?.CurrentTransaction is NoopTransaction) return;

ExtensionMethods.TryGetScalarPropertyValue sets value = null for ElasticApmTraceId and returns true:
https://github.com/elastic/ecs-dotnet/blob/f0033bd47881a926b0d772b1d14f0fa5ebf92e3a/src/Elastic.CommonSchema.Serilog/ExtensionMethods.cs#L25

option 2 to fix - adjust TryGetScalarPropertyValue: return true only if value != null

LogEventConverter's GetTrace() and GetTransaction() methods access Value property of actual null traceId (transactionId):

https://github.com/elastic/ecs-dotnet/blob/f0033bd47881a926b0d772b1d14f0fa5ebf92e3a/src/Elastic.CommonSchema.Serilog/LogEventConverter.cs#L87
https://github.com/elastic/ecs-dotnet/blob/f0033bd47881a926b0d772b1d14f0fa5ebf92e3a/src/Elastic.CommonSchema.Serilog/LogEventConverter.cs#L92
option 3 to fix - add check for null here for both methods of LogEventConverter

Hi, we just ran into this today and I was quite disappointed to discover it was a year old known issue.

Thanks for raising this and apologies for the delay on this issue.
Will look at addressing this ASAP so we are sure the upcoming 8.4.0 release (#197) does not suffer from this bug.

Luckily in main the more egregious bug of not logging at all was already fixed.
Opened https://github.com/elastic/ecs-dotnet/pull/234 to ensure the enrichers are aware of the Enabled setting that was introduced in the 1.7 version of the agent. We were still on the 1.4 version of the agent.


WIP - Fixes for Sortable

Fixed:

[x]  Sortable smoothness
[x] Hunk dragging
[x] Code selecting
[x] Boatloads of small bugs and linter errors
[x] Ghost-drag image (thanks Tim)
[ ] Group dragging (should be made non-horrible)
[ ] Styling (some small things)
[x] rebase

Code seems good so far. After the rebase I will test it :)

There are some left-over tests that failed. For the other part I would like to test this tomorrow together with you to figure out how this feature will work together with the group visualization.

LGTM


provision.cpp line 81 teamprovisioningprofile error

This isn’t an issue with unc0ver, try sideloading it again or use Ignition. Close the issue


feat(Topology/UniformSpace): define uniform preordered space

We define the semi-uniform structure and the uniform preordered space.

Yesterday I just learned the semi-uniform structure and the uniform preordered space from Nachbin's Topology and Order, so I only know a little about these. Feel free to tell me what I should do.


Need to prefix performance with window

I guess this is the cost of preventing bugs like https://github.com/captbaritone/webamp/commit/5407426325db740b7cc0e40ac5d57312b3c36740

I guess this is the cost of preventing bugs like 5407426

haha, yea. Totally worth it, and probably makes sense to explain what scope that functions is magically being pulled from


CAMEL-19571 - camel-parquet-avro: Add other compression codecs than gzip

Description
This PR adds other compression codecs than gzip to the Parquet-Avro data format for marshaling.
Target

[x] I checked that the commit is targeting the correct branch (note that Camel 3 uses camel-3.x, whereas Camel 4 uses the main branch)

Tracking

[x] If this is a large change, bug fix, or code improvement, I checked there is a JIRA issue filed for the change (usually before you start working on it).

Apache Camel coding standards and style

[x] I checked that each commit in the pull request has a meaningful subject line and body.

[x] I have run mvn clean install -DskipTests locally and I have committed all auto-generated changes

/component-test camel-parquet-avro

thanks


I think I accidentally closed the review.  Apologies.  Anyway - let's keep this open for further discussion.  Looks like everything else should make the release.

Out of date with current fbbt- better to redo at some point rather than messy merge


CASMCMS-8708 Rework multi-platform build

Summary and Scope
Currently, docker build buildx is called 3 times during build, with different set of parameters (2 times within Makefile and one more time in publishCsmDockerImage method of csm-shared-libraries). This change (which also depends on https://github.com/Cray-HPE/csm-shared-library/pull/52) is to unify docker buildx build invocation.
Since images for multiple platforms can not be loaded into local docker daemon, separate single-platform target was introduced in Makefile to make local image. I.e.

run make image to build both platforms (amd64 and arm64) and push them to artifactory.algol60.net. No images will be loaded into local docker daemon. Authentication to artifactory.algol60.net must be established with docker login prior to that.
run make image_localto build single platform image and load it into local docker. Image for your laptop platform will be built (amd64 for Intel based Mac's, arm64 for newer Mac chips). No push to artifactory.algol60.net happens, preliminary auth is not needed.

Note: filing it as DRAFT, since branch feature/deprecate-multiarch of csm-shared-libraries is supposed to go away, once https://github.com/Cray-HPE/csm-shared-library/pull/52 gets merged.
Issues and Related PRs

Resolves CASMCMS-8708

Testing
Tested on:

Local development environment
Jenkins: https://jenkins.algol60.net/blue/organizations/jenkins/Cray-HPE%252Fims-kiwi-ng-opensuse-x86_64-builder/detail/feature%252FCASMCMS-8708/3/

Test description:

Tested local build with make image_local
Tested non-local multi-platform builds: https://jenkins.algol60.net/blue/organizations/jenkins/Cray-HPE%252Fims-kiwi-ng-opensuse-x86_64-builder/detail/feature%252FCASMCMS-8708/3/

Moved this to https://github.com/Cray-HPE/ims-kiwi-ng-opensuse-x86_64-builder/pull/55 for a clean hotfix release to master. Closing this PR.


fix(cast): only set function args if signature provided

Motivation
Closes #4016
only set args if sig argument provided.
cast call
0x

cast call 0x<address>
0x

should cast call without an address arg fail @prestwich ?

Solution

I think you can technically eth_call a contract creation with no to specified but idk if thats useful for cast, see https://github.com/ethereum/go-ethereum/blob/6c149fd4ad063f7c24d726a73bc0546badd1bc73/internal/ethapi/transaction_args.go#L38, the to param is a pointer

@tynes i don't think we need that since we've got cast send --create for that

If you don't want to actually create the contract and just want to do some execution in the constructor and get the returndata, its useful to eth_call a contract creation

@tynes I installed this branch yesterday and was able to cast call --create with no arguments and get returndata - I did not try with constructor arguments, however


asap-docking: cached directory fails when using pdb-file

This might be true for a few different examples, but if I try:
asap-docking cross-docking --ligands input/lig_0.smi --pdb-file input/NP_722463.1_lig_0.pdb --target ZIKV-NS2B-NS3pro --cache-dir prep_cache_v2 --structure-selector PairwiseSelector --output-dir dock_output

It works, and I get this log output:
[04/08/24 12:16:48] INFO     Writing to / overwriting output directory:                                   cross_docking.py:101
                             /Users/alexpayne/Scientific_Projects/mers-drug-discovery/20240408-siyang-hel
                             p/dock_output
                    INFO     Running cross docking with inputs:                                           cross_docking.py:105
                             ligands='/Users/alexpayne/Scientific_Projects/mers-drug-discovery/20240408-s
                             iyang-help/input/lig_0.smi'
                             pdb_file=PosixPath('/Users/alexpayne/Scientific_Projects/mers-drug-discovery
                             /20240408-siyang-help/input/NP_722463.1_lig_0.pdb') fragalysis_dir=None
                             structure_dir=None
                             cache_dir='/Users/alexpayne/Scientific_Projects/mers-drug-discovery/20240408
                             -siyang-help/prep_cache_v2' use_only_cache=False save_to_cache=True
                             target=<TargetTags.ZIKV-NS2B-NS3pro: 'ZIKV-NS2B-NS3pro'>
                             write_final_sdf=True use_dask=False dask_type=<DaskType.LOCAL: 'local'>
                             dask_failure_mode=<DaskFailureMode.SKIP: 'skip'> dask_cluster_n_workers=10
                             dask_cluster_max_workers=200 n_select=5 logname='' loglevel='INFO'
                             output_dir=PosixPath('/Users/alexpayne/Scientific_Projects/mers-drug-discove
                             ry/20240408-siyang-help/dock_output') overwrite=True walltime='72h'
                             structure_selector=<StructureSelector.PAIRWISE: 'PairwiseSelector'>
                             multi_reference=False relax=<POSIT_RELAX_MODE.NONE: 0>
                             posit_method=<POSIT_METHOD.ALL: 15> use_omega=False omega_dense=False
                             num_poses=1 allow_low_posit_prob=False low_posit_prob_thresh=0.1
                             allow_final_clash=False allow_retries=False
                    INFO     Dumping input schema to                                                      cross_docking.py:106
                             /Users/alexpayne/Scientific_Projects/mers-drug-discovery/20240408-siyang-hel
                             p/dock_output/inputs.json
                    INFO     Loading ligands from file:                                                   cross_docking.py:126
                             /Users/alexpayne/Scientific_Projects/mers-drug-discovery/20240408-siyang-hel
                             p/input/lig_0.smi
                    INFO     Loading structures from pdb:                                         meta_structure_factory.py:79
                             /Users/alexpayne/Scientific_Projects/mers-drug-discovery/20240408-si
                             yang-help/input/NP_722463.1_lig_0.pdb
                    INFO     Loaded 1 query ligands                                                       cross_docking.py:142
                    INFO     Loaded 1 complexes                                                           cross_docking.py:144
                    INFO     Prepping complexes                                                           cross_docking.py:147
                    INFO     Prepping 1 complexes                                                          protein_prep.py:145
Warning: Detected residue with blank chain ID LIG 151     0
Warning: No BioAssembly transforms found, using input molecule as biounit: _lig_0_LIG
Warning: Iridium - Structure: _lig_0_LIG has no REMARK data
Processing BU # 1 with title: _lig_0_LIG, chains A
[04/08/24 12:17:24] INFO     Prepped 1 complexes                                                          cross_docking.py:160
                    INFO     Writing prepped complexes to global cache                                    cross_docking.py:163
                             /Users/alexpayne/Scientific_Projects/mers-drug-discovery/20240408-siyang-hel
                             p/prep_cache_v2
                    INFO     Selecting pairs for docking                                                  cross_docking.py:169
                    INFO     Selected 1 pairs for docking                                                 cross_docking.py:178
                    INFO     Running docking on selected pairs                                            cross_docking.py:191
[04/08/24 12:17:31] INFO     Docked 1 pairs successfully                                                  cross_docking.py:212
                    INFO     Scoring docking results                                                      cross_docking.py:221
                    INFO     Writing final docked poses to SDF file                                       cross_docking.py:225
[04/08/24 12:17:32] INFO     Renaming columns for manifold

If I then run the same command with --use-only-cache, it fails:
asap-docking cross-docking --ligands input/lig_0.smi --pdb-file input/NP_722463.1_lig_0.pdb --target ZIKV-NS2B-NS3pro --cache-dir prep_cache_v2 --structure-selector PairwiseSelector --output-dir dock_output --use-only-cache

I get this log output
...
                    INFO     Loading structures from pdb:                                         meta_structure_factory.py:79
                                                 /Users/alexpayne/Scientific_Projects/mers-drug-discovery/20240408-si
                                                 yang-help/input/NP_722463.1_lig_0.pdb
                    INFO     Loaded 1 query ligands                                                       cross_docking.py:142
                    INFO     Loaded 1 complexes                                                           cross_docking.py:144
                    INFO     Prepping complexes                                                           cross_docking.py:147
                    INFO     Loaded 1 cached structures from:                                              protein_prep.py:123
                             /Users/alexpayne/Scientific_Projects/mers-drug-discovery/20240408-siyang-help
                             /prep_cache_v2.
                    WARNING  Disregarding 1 structures which could not be found in the cache.              protein_prep.py:132
Traceback (most recent call last):
  File "/Users/alexpayne/miniforge-pypy3/envs/asapdiscovery/bin/asap-docking", line 8, in <module>
    sys.exit(docking())
  File "/Users/alexpayne/miniforge-pypy3/envs/asapdiscovery/lib/python3.10/site-packages/click/core.py", line 1157, in __call__
    return self.main(*args, **kwargs)
  File "/Users/alexpayne/miniforge-pypy3/envs/asapdiscovery/lib/python3.10/site-packages/click/core.py", line 1078, in main
    rv = self.invoke(ctx)
  File "/Users/alexpayne/miniforge-pypy3/envs/asapdiscovery/lib/python3.10/site-packages/click/core.py", line 1688, in invoke
    return _process_result(sub_ctx.command.invoke(sub_ctx))
  File "/Users/alexpayne/miniforge-pypy3/envs/asapdiscovery/lib/python3.10/site-packages/click/core.py", line 1434, in invoke
    return ctx.invoke(self.callback, **ctx.params)
  File "/Users/alexpayne/miniforge-pypy3/envs/asapdiscovery/lib/python3.10/site-packages/click/core.py", line 783, in invoke
    return __callback(*args, **kwargs)
  File "/Users/alexpayne/Scientific_Projects/asapdiscovery/asapdiscovery-workflows/asapdiscovery/workflows/docking_workflows/cli.py", line 266, in cross_docking
    cross_docking_workflow(inputs)
  File "/Users/alexpayne/Scientific_Projects/asapdiscovery/asapdiscovery-workflows/asapdiscovery/workflows/docking_workflows/cross_docking.py", line 149, in cross_docking_workflow
    prepped_complexes = prepper.prep(
  File "/Users/alexpayne/Scientific_Projects/asapdiscovery/asapdiscovery-modeling/asapdiscovery/modeling/protein_prep.py", line 163, in prep
    raise ValueError(
ValueError: No complexes were successfully prepped, likely that nothing was passed in, cache was mis-specified or cache was empty.

If this is really not working, then I think we need to add this as a test.

Is that PDB in the cache?

We don't currently support caching with --pdb-file, but you are right that this should be more explicit and fail if --use-only-cache && --pdb-file. It doesn't take long to prep a structure so should just be okay to not support for now.

Is that PDB in the cache?
it should be getting written to a cache from the first command:

INFO     Writing prepped complexes to global cache                                    cross_docking.py:163
/Users/alexpayne/Scientific_Projects/mers-drug-discovery/20240408-siyang-hel
p/prep_cache_v2

It doesn't take long to prep a structure so should just be okay to not support for now.
but if you have a large structure directory, but you just want to dock to one of the structures, and you have already prepped all of them, I think the natural thing would be to assume you could just specify one of the pdb files and have it confirm that its in the cache


Add Japanese font for supporting Japanese pages

Since the headless browser used in vercel doesn't have Japanese font, Japanese texts aren't displayed correctly in the previews.
Here is the example of the issue:

This PR is adding a Japanese font for supporting Japanese text.
Here is the sample:

Deployed code can be found here.
https://og-image-cyan-kappa.vercel.app/Wizardの特典へのアクセス方法.png?images=https%3A%2F%2Fimages.ctfassets.net%2Fvxapo358qmda%2F64TWvvb0gz9LU3xy6zSOt0%2Feaef8949f0bd3dced07c4441135545d1%2F4VT3rgt.png
The font this PR is adding can be found here.
https://fonts.google.com/specimen/DotGothic16?subset=japanese#standard-styles
License of the font is Open Font License, so we should be able to use it in our site through this module.

Nice work! ⭐

Thank you for merging it!


nfc manager does not check NFC permission.

I found 2 issues about the nfc permission.

"request permission" is shown at second time, not at first time.
When startSession() is called 2 times, "request permission" is shown.

status of permission is not checked.
Even though a user denies the nfc permission, nfc_manager keeps to access to nfc.

using version nfc_manager: ^2.0.0+2

Also have this issue. Sadly, I haven't found a solution either. Will be sure to post an update if anything changes.

Any updates on this issue?

Sorry, I have nothing to update


Fix: #58

The picture below is a problem with the automatic completion of the code that was originally implemented

If the insertContent contains a markdown language, I know where it doesn't work properly. Therefore, we have setContent and insertContent with parseOptions to complement the fakeEditor separately. I think it would be good to apply only CSS with additional modifications :)
The picture below is a screen operated with the actual modified code.

@andrewdoro this may not be an issue once #297 is merged.

I'll close this one in favour #297, for direct streaming in the editor we might have another example


Ansible 2.6 Testing Support

Changes:

Updated default travis config to use Ansible 2.6.1
Added Ansible 2.6 and 2.6.1 to validation
Sectioned out with comments distribution and python versions in travis config
Added commented build status for future use in readme
Updated ansible.rst to include updated links for Ansible 2.6

Issues Resolved:
closes #311

This is great, thanks a ton! The travis badge is intentionally not in the readme at present due to those flakey tests, but i can merge as-is and delete that later. Thanks again!

@dw commented out the badge to make your life a little easier.

Thanks a million!


rename wrong attribute name to prevent AttributeError PYthon Exception

Same as  #672 but different head repo branch

Great, thanks!


[Multi-Tenant] backend Admin Tenant API

Add the following to backend Admin GraphQL API:
type Query {
  tenant(id: string!): Tenant
  tenants: TenantsConnection! // pagination query for tenants
}

type Mutation {
  createTenant(input: CreateTenantInput): CreateTenantMutationResponse!
  updateTenant(input: UpdateTenantInput): UpdateTenantMutationResponse!
  deleteTenant(input: DeleteTenantInput): DeleteTenantMutationResponse!
}

[ ] tenant query
[ ] tenants query
[ ] createTenant mutation
[ ] updateTenant mutation
[ ] deleteTenant mutation

Prerequisites

https://github.com/interledger/rafiki/issues/3123

Deleting tenant - I'm guessing we can only do this if there are no other resources that have been created under the same tenant, correct? Under foreign key constaints

Deleting tenant - I'm guessing we can only do this if there are no other resources that have been created under the same tenant, correct? Under foreign key constaints

Come to think of it, deactivation or some kind of soft deletion makes more sense.


[REBASE & REDIRECT] Conditional Database Imports & Docos, #692

This rebases the venerable #692 (@jlaura), without which we would have no soft dependencies :sunglasses:
This rebases onto current development versions and redirects the contribution to pysal/dev.
It is missing unittests, but writing those may be prohibitive. If someone has knowledge of sqlite, this would be a very cut-and-dry contribution!

Changes Unknown when pulling 975364427b50ec59a4436e52ea2a0440e500099d on ljwolf:pr692 into ** on pysal:dev**.


how can i export my app as sdk for both ios and android?

Use case

Proposal

Hi @mido199
This issue doesn't seem to describe a bug or a feature request. Please see https://flutter.dev/community for resources and asking questions like this,
you may also get some help if you post it on Stack Overflow and if you need help with your code, please see https://www.reddit.com/r/flutterhelp/
Closing, as this isn't an issue with Flutter itself. If you disagree, please write in the comments and I will reopen it.
Thank you


How to keep track of correct last modified times for pages

We are using Nextra + Next Sitemap to update our sitemap, but noticed that the lastmod times are always the last time a deploy happened, rather than the last time the page really had any changes made to it. Apart from the sitemap, the pages themselves also say they were updated very recently, even when that's not truly the case.
I wanted to ask if the community has any solutions for dealing with this problem, other than manually updating it in each page's metadata? Is there a way to hook into Git commit history for example?

https://github.com/iamvishnusankar/next-sitemap#custom-transformation-function

and after do some magic to get the last modified time for md/mdx file

@dimaMachina Cool!
const { execSync } = require('child_process');
const fs = require('fs');

/** @type {import('next-sitemap').IConfig} */
module.exports = {
  siteUrl: 'https://tsdk.dev',
  generateRobotsTxt: true,
  transform: async (config, path) => {
    let filePath = `pages${path}.md`;
    const exist = fs.existsSync(filePath);

    if (!exist) {
      filePath += 'x';
    }

    const cmd = `git log -1 --format=%ct ${filePath}`;
    const result = execSync(cmd).toString();
    // Use default transformation for all other cases
    return {
      loc: path, // => this will be exported as http(s)://<config.siteUrl>/<path>
      changefreq: config.changefreq,
      priority: config.priority,
      lastmod: result
        ? new Date(+result.toString() * 1000).toISOString()
        : config.autoLastmod
        ? new Date().toISOString()
        : undefined,
      alternateRefs: config.alternateRefs ?? [],
    };
  },
};

const { execSync } = require("child_process");
const fs = require("fs");
const packageJson = require("kitchn/package.json");

/** @type {import('next-sitemap').IConfig} */
module.exports = {
  siteUrl: packageJson.homepage,
  generateRobotsTxt: true,
  robotsTxtOptions: {
    policies: [{ userAgent: "*", allow: "/" }],
  },
  transform: async (config, path) => {
    let filePath = `pages${path}.md`;
    let exist = fs.existsSync(filePath);

    if (!exist) {
      filePath += "x";
      exist = fs.existsSync(filePath);
    }

    let lastmod = config.autoLastmod ? new Date().toISOString() : undefined;

    if (exist) {
      try {
        const cmd = `git log -1 --format=%ct ${filePath}`;
        const result = execSync(cmd).toString().trim();

        if (result) {
          lastmod = new Date(+result * 1000).toISOString();
        }
      } catch (error) {
        console.error(
          `Error executing git command for file ${filePath}:`,
          error.message,
        );
      }
    }

    return {
      loc: path,
      changefreq: config.changefreq,
      priority: config.priority,
      lastmod,
      alternateRefs: config.alternateRefs ?? [],
    };
  },
};


Unwanted lines/triangles after imported Collada model + Possible physics engine segmentation fault caused by the model

Release Type: Latest official release
Version: <IP_ADDRESS>4
Platform(s): Windows
Describe the bug
There are unwanted lines+triangles(?) generated after I imported my model. Compare the video with the screenshot below.
https://user-images.githubusercontent.com/20599225/202803306-cea1a6d2-8662-4b55-b706-e6a063d210e3.mp4
This may be also the cause of a crash related for the physics engine.
To Reproduce
Steps to reproduce the behavior:
1.) Use
Model.zip
2.) Create a Model that uses the mesh in the link above.
3.) See video above:
(For the physics engine error)
4.) Create a Static collider from the mesh
5.) There are chances the game will crash at startup. Call stack below:
Expected behavior
I don't expect the extra lines/triangles as shown in the video.
This is how the model looks

Log and callstacks
Physics engine segmentation fault that happens sometimes when starting up the project.
(Copied from Copy Details)
  HResult=0x80004003
  Message=Attempted to read or write protected memory. This is often an indication that other memory is corrupt.

Update 1: A workaround for this is importing the model into Blender and exporting as into FBX.


Add autoprefixer to the node-sass build and generated styles

This helps with older browsers 👍

Done!


feat(mermaidblock): modifies mermaid block to handle custom error

Title
feat(mermaidblock): modifies mermaid block to handle custom error #419

PR Type
Enhancement, Bug fix

Description

Enhanced the MermaidBlock component with error handling for invalid Mermaid syntax and rendering issues.
Introduced ErrorAlert for displaying error messages in the UI.
Refactored Mermaid rendering logic into helper functions for better maintainability.
Improved the UI of the Mermaid block using styled components.
Fixed potential runtime errors in CodeEditorSettings by adding optional chaining.

Changes walkthrough 📝
Relevant filesEnhancement

MermaidBlock.tsxEnhanced Mermaid block with error handling and UI improvements.

packages/client/src/components/block-defaults/mermaid-block/MermaidBlock.tsx
Added error handling for Mermaid syntax validation and rendering.  Introduced ErrorAlert component for displaying error messages.  Refactored Mermaid rendering logic into helper functions.  Enhanced Mermaid block with styled components for better UI.

+108/-6

Bug fix

CodeEditorSettings.tsxImproved error handling in CodeEditorSettings component.

packages/client/src/components/block-settings/shared/CodeEditorSettings.tsx
Added optional chaining to prevent potential runtime errors.  Improved robustness of data handling in CodeEditorSettings.

+2/-2

💡 PR-Agent usage: Comment /help "your question" on any pull request to receive relevant information

PR Reviewer Guide 🔍
Here are some key observations to aid the review process:

⏱ Estimated effort to review: 4 🔵🔵🔵🔵⚪
🧪 No relevant tests
🔒 No security concerns identified
⚡ Recommended focus areas for review
Error HandlingThe new error handling mechanism for Mermaid diagrams is a significant addition. Ensure that the handleMermaidError function and the ErrorAlert component handle all edge cases, such as unexpected error formats or missing elements.
Syntax ValidationThe isMermaidSyntaxValid function introduces syntax validation for Mermaid diagrams. Verify that it correctly handles all valid and invalid Mermaid syntax cases and does not introduce performance bottlenecks for large diagrams.
Missing Diagram TextThe handling of missing diagram text currently results in an empty block. Consider implementing a warning or placeholder UI to improve user feedback.
Potential Data Sync IssueThe addition of optional chaining (?.) for app_id in setModels and setModelId could mask potential issues with missing or undefined data. Ensure that this change does not introduce silent failures or unexpected behavior.

PR Code Suggestions ✨

CategorySuggestion                                                                                ScoreSecurity

Replace innerHTML with textContent to prevent potential XSS vulnerabilities when rendering Mermaid diagrams

Ensure that the initializeMermaid function properly sanitizes the text input before setting it as innerHTML to prevent potential XSS vulnerabilities.
packages/client/src/components/block-defaults/mermaid-block/MermaidBlock.tsx [62]
-element.innerHTML = text; // Set the Mermaid diagram text
+element.textContent = text; // Set the Mermaid diagram text safely

Suggestion importance[1-10]: 9
Why: Replacing innerHTML with textContent mitigates potential XSS vulnerabilities, which is a significant security improvement. This change is highly relevant and impactful.
9
Possible issue

Add a safeguard to handle cases where myModels.data is empty before accessing its first element

Add a null check for myModels.data[0] before accessing app_id in setModelId to prevent potential runtime errors when the array is empty.
packages/client/src/components/block-defaults/mermaid-block/MermaidBlock.tsx [107]
-setModelId(myModels.data[0]?.app_id);
+setModelId(myModels.data.length > 0 ? myModels.data[0]?.app_id : null);

Suggestion importance[1-10]: 8
Why: Adding a null check ensures that the code does not throw runtime errors when myModels.data is empty. This is a critical improvement for robustness and prevents potential crashes.
8
General

Add error logging to the Mermaid syntax validation function for better debugging

Ensure that the isMermaidSyntaxValid function properly handles and logs errors for debugging purposes, as currently, it silently returns false without providing any context about the error.
packages/client/src/components/block-defaults/mermaid-block/MermaidBlock.tsx [47-53]
 const isMermaidSyntaxValid = async (text: string): Promise<boolean> => {
     try {
         await mermaid.parse(text);
         return true;
     } catch (error) {
+        console.error('Mermaid syntax validation error:', error);
         return false;
     }
 };

Suggestion importance[1-10]: 7
Why: Adding error logging to the isMermaidSyntaxValid function improves debugging and helps developers identify issues with Mermaid syntax validation. This is a useful enhancement, though not critical for functionality.
7


Development

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (39f2551) 100.00% compared to head (ed1fbe6) 100.00%.
Report is 4 commits behind head on main.

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.
Additional details and impacted files
@@            Coverage Diff            @@
##              main       #43   +/-   ##
=========================================
  Coverage   100.00%   100.00%
=========================================
  Files            2         2
  Lines            5         5
=========================================
  Hits             5         5

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


upgrade to multer 1.x

Tests are ok. Old version of multer use unprotected async that can crash your app.

If you send a file with a name that was not in the swagger definition, multer will throw an "unexpected field" error. I do not know if this accountable as an issue.

A few minor concerns/questions.  Overall, I really appreciate this.

I have updated req.files[parameter.name] and added more tests

How did the browser/*.js builds change?

I have no idea, i simply exec gulp in the root dir

Interesting.

Should I remove them from the PR ?

Please do.  I usually rebuild before a release in case.

Done

Great pull request.  :)