switch to using pointers to structs in fields

This is so that we can omit fields in output in the managed azure service.

@JackQuincy,
Thanks for your contribution as a Microsoft full-time employee or intern. You do not need to sign a CLA.
Thanks,
Microsoft Pull Request Bot

@acs-bot test this please

Reviewed 6 of 13 files at r1.
Review status: 6 of 13 files reviewed at latest revision, 4 unresolved discussions.

pkg/api/convertertoapi.go, line 391 at r1 (raw file):

func convertV20160330VMDiagnostics(v20160330 *v20160330.VMDiagnostics, api *VMDiagnostics) {
	api.Enabled = v20160330.Enabled
	api.StorageURL = v20160330.StorageURL

StorageURL needs to be a pointer, and copies when it's not nil.

pkg/api/types.go, line 182 at r1 (raw file):

	// This field is readonly as ACS RP will create a storage account
	// for the customer.
	StorageURL neturl.URL `json:"storageUrl"`

I think it needs to be a pointer

pkg/api/v20160330/types.go, line 146 at r1 (raw file):

	// This field is readonly as ACS RP will create a storage account
	// for the customer.
	StorageURL neturl.URL `json:"storageUrl"`

I think it needs to be a pointer

pkg/api/v20170131/types.go, line 159 at r1 (raw file):

	// This field is readonly as ACS RP will create a storage account
	// for the customer.
	StorageURL neturl.URL `json:"storageUrl"`

I think it needs to be a pointer.

Comments from Reviewable

Good idea on the more simple test, that doesn't depend on our test inputs as much. I ran classic/kubernetes.classic.json through and didn't see unexpected objects.

@acs-bot test this please


Add mraa to the SDK build

Currently the IOT2050 patched mraa is not included in the SDK.
Please include it in order to program GPIOs in C++

Do these commits mean mraa is now included when building the SDK?
Or do they first need to be merged to master?

The change is pending for master. If you need it earlier, I can split that branch up and send a PR now.

Do you have a feeling when it will be merged?

Within this or next week, I would guess.

Ok, that should be fine.
I have a customer waiting for it, but this or next week is sufficient I guess.


'az containerapp up' fails to build image for camelCase app name

~/deno/freshRadio (master) $ az containerapp up --source . -n freshRadio -g freshRadio

Using resource group 'freshRadio'
Using ContainerAppEnvironment 'freshRadio-env' in resource group freshRadio
(InvalidInputValue) Some of the properties of 'runRequest' are invalid.. InnerErrors:
DockerBuildRequest:Image name 'freshRadio:20220713133604855032' is invalid.
The acceptable patterns are 'repository' or 'repository:tag'.The repository and tag
names follow the standardized docker repository and tag naming conventions.
Tag templates are supported within '{{' and '}}'.

Not sure where to open this issue, hopefully this is the right place.
My suggestion is to check the app name (passed in -n) and throw a better error if it's not all lowercase. Looks like the current error message is a little convoluted and it takes a while until you figure out the problem.

We have a fix for this going out in the next CLI extension release @anthonychu @snobu


Allow configuring the device to monitor (Desktop / Mobile)

I did not see in the docs a way to configure the device, only by category (performance, SEO, etc).

I think that by default is mobile, but right now, I just want to monitor only in Desktop. Is this possible?

Hey @javiercardenaswork! It's been a while, but this is now available when using v3.5.0 of this plugin.
Mobile is still the default, but you can opt-in to desktop testing instead using the following netlify.toml addition.
[[plugins]]
  package = "@netlify/plugin-lighthouse"

  [plugins.inputs.settings]
    preset = "desktop"

sorry to re-surface an older thread but I couldn't think of a better way to ask this question. Is there a way to use desktop for some paths, and mobile for others?

Hey, it's not currently possible I'm afraid, but I can add it to our roadmap to take a look at in future.
If you don't mind sharing, is there a specific reason to use different devices per-path? Would you be testing the same path against both devices? Or do you have some pages which need to specifically choose one over the other maybe?

It would be much appreciated if you could add it to the roadmap 🙏
At this stage in development I only need desktop and mobile for some pages, and just desktop for others. But long term, I would want to test both, and if that functionality existed now, I don't see an issue with testing both and ignoring the results I don't need as well.


[1.20.x] Too Many Fireflies In Cherry Grove

I am on 1.20.4 and there seems to be a lot more fireflies than there are supposed to be when in a cherry grove biome. This was the best I could capture it, but it looks like a lot more when actually in game.

I could be incorrect, but I think this is due to flowers causing the fireflies to display and because the cherry grove's floor is covered in flowers they end up being overwhelming.

Firefly effect is tied to anything that is classified as a minecraft:flowers. BoP tags a lot of blocks to that tag.  It's just not the foliage on the ground - it'lso the leaf blocks in the trees. I could turn the frequency of spawning to a lower rate, but then it would reduce the rate of spawn across all biomes, including vanilla.  Basically a no win.

No, but I can adjust the chance of spawn based on whether BoP is installed.  I was thinking cutting the frequency in half. Do you have any feel for how frequent it should be compared to what you have encountered?

An option to configure the amount of fireflies from flowers (as well as their size and speed) I think would be a better compromise.
Something I liked about the older versions of this mod is the fireflies were smaller and slower, but in the current version they seem to zoom by and in this case for the Cherry Grove, I think, subjectively, it actually looks nice.
ALL THE CONFIGS! >:D

I don't use BoP. So, this wouldn't help me. Since it can't be reduced based on the biome, the current way it is is fine.

The issue in my screenshots are in a vanilla minecraft biome. I am confused why Biomes O' Plenty was brought up.


12 fix wrong response when repeated requests for external source

fix #12

Use defer object for awaiting steam "write".
createDeffered is used in app too, so remove test/utils.ts.

add .editorconfig

@ofhouse It's hard to set e2e:test envrionments. I ran docker container using docker-compose.yml, but many TCs still failed. So if you add guide for testing, I can run and add TCs.

Added a quick guide here for running e2e tests locally: https://github.com/dealmore/terraform-aws-next-js-image-optimization/blob/main/CONTRIBUTING.md

Whoops forgot to mention that also a local production build is required, updated the contribution guide accordingly.

@b6pzeusbc54tvhw5jgpyw8pwz2x6gs Anything here I can do to push this further?
If e2e don't work for you, I could offer to add them by myself.

I will try to add some TCs soon.

The problem has not been reproduced by TC, so I am checking it. A little more modification is required.

Seems like the issue is hard to track down in a e2e test, because the stream finishes before the result is returned.
Maybe a unit test where the file read is delayed would make more sense?

Yes, it makes sense. Another reason is that the state is initialized every lambdaSAM.sendApiGwRequest call in the sam local environment even the filesystem.
    REPORT RequestId: 47f0c1bf-4125-471f-abba-e9e35cb24156	Init Duration: 0.34 ms	Duration: 485.10 ms	Billed Duration: 500 ms	Memory Size: 1024 MB	Max Memory Used: 1024 MB
    REPORT RequestId: fb02f7e2-c8d8-4716-9bd7-24476e97cd69	Init Duration: 0.18 ms	Duration: 385.11 ms	Billed Duration: 400 ms	Memory Size: 1024 MB	Max Memory Used: 1024 MB

You can see that Init Duration is displayed in the above continuous call log.
I'm looking for a way to turn this initializing setting off.

  const apiSpawnArgs = [
      'local', 'start-api',
      '--port', `${port}`,
      '--warm-containers', 'EAGER',
    ];

I have successfully reproduced by modifying the createSAMLocal function to above on the sammy side. Can you add --warm-containers option to this?

Thanks, added the warmup flag to sammy.
However when I run the test-file from your branch against the current main branch with sammy 1.4.0 the test is also passing, so it seems that it is not replicating the failing behaviour. 🙈
But tracking down this issue further would take too much time, so I would say the PR is fine with the test.

@ofhouse Sorry! There is a problem with that PR. Exported function generateSAM should be modified to pass cli options. I will create a new PR on Sammy.

Please check dealmore/sammy#2 before mering this PR.

I just some "force push" to rebase latest main branch and remove unnecessary commit history. So, Be careful when checking out a branch.

@ofhouse With sammy v1.5.0, I confirmed that both reproducing and resolving problem are working fine. Please check it.


libtest-mimic v 0.6 docs are broken on docs.rs

https://docs.rs/libtest-mimic/0.5.2/libtest_mimic/index.html  << Renders fine
https://docs.rs/libtest-mimic/0.6.0/libtest_mimic/index.html << Broken
Confirmed its not my local browser caching a docs.rs hiccup

Can you describe how they are broken for you? Looks fine to me:

This is how it renders:

Errors in the console

Are you using a custom theme? Because all the links are broken when I visit.

One of the urls that gets a 404 for me
https://docs.rs/-/rustdoc.static/normalize-20221104-1.67.0-nightly-09508489e.css

I've turned caching, flushed cache, and used a incognito window. All are still broke
I'm worried by the broken URLS all seem to mention 1.67-nightly somehow?

The broken urls in 0.6.0 show https://docs.rs/-/
The working ones in 0.5.2 don't have the /-/ path component?

Just tried firefox, broken there as well

Are you using a custom theme?

Nope.

One of the urls that gets a 404 for me
https://docs.rs/-/rustdoc.static/normalize-20221104-1.67.0-nightly-09508489e.css

Nope, works for me: returns a CSS file.

I'm worried by the broken URLS all seem to mention 1.67-nightly somehow?

That's for me as well, so that seems normal.

But wow, that seems weird, especially given that you also tried a different browser. My best guesses are: you are behind some firewall, or are using some kind of VPN or proxy, or something like that. Or maybe a browser extension that you have installed in both browsers?
But as I cannot reproduce this (I tried on multiple devices), I will close this issue. This is not something I can fix.

I just tried it on my phone, broken there as well.

No proxy, vpn, or anything, i tried using wifi and 5g

Filed a ticket in docs.rs in case they have a broken CDN or something. Thanks for your help.


исправил баги таблицы ордеров на мобиле и планшете

Pull request template
Checklist

[x] I have read the CONTRIBUTING guide
[x] branch rebased on develop
[x] styleguide check npm run validate
[x] good naming
[x] keep simple
[x] video or screenshot attached
[ ] testing instruction attached
[x] check your PR once again

Description

Video or screenshot

What and how to test


interop_utils.go:6:11: fatal error: speechapi_c_common.h: No such file or directory

Is it compatible with windows?
I tried in Windows 10 and I am getting the following errors ( same result in Ubuntu) when I run the main.go file from the samples
go1.13\src\github.com\Microsoft\cognitive-services-speech-sdk-go\common\interop_utils.go:6:11: fatal error: speechapi_c_common.h: No such file or directory
 // #include <speechapi_c_common.h>

Hi @ta2swu
Windows isn't officially supported yet, though it is a backlog candidate in our or future work.
In Ubuntu, are you setting CGO_FLAGS in your environment?

Closing as this hasn't seen activity in a bit over a month. If more help is needed please feel free to reopen it.


[bug]: LND shutdown when looses connection to bitcoind

Background
LND starts a shutdown when bitcoind is being stopped.
In this case bitcoind is running in another machine. I reinitiated the machine running bitcoind and the LND running in another machine initiated a shutdown
Your environment

version of lnd: 0.15.5-beta commit=v0.15.5-beta
which operating system (uname -a on *Nix): Linux ubuntu-pi-server 5.15.0-1021-raspi # 23-Ubuntu SMP PREEMPT Fri Nov 25 15:27:43 UTC 2022 aarch64 aarch64 aarch64 GNU/Linux
version of btcd, bitcoind, or other backend: Bitcoin Core version v22.0.0
any other relevant environment details

Steps to reproduce
Stop bitcoind which is running in another machine
Expected behaviour
LND should not initiate a shutdown
Actual behaviour

2023-02-13 12:53:31.216 [ERR] RPCS: [/lnrpc.Lightning/GetInfo]: unable to get best block info: invalid http POST response (nil), method: getblockchaininfo, id: 105135, last error=Post "http://<IP_ADDRESS>:8332": dial tcp <IP_ADDRESS>:8332: connect: connection refused
2023-02-13 12:54:09.667 [INF] CRTR: Processed channels=0 updates=114 nodes=1 in last 59.999301488s
2023-02-13 12:54:19.984 [INF] WTCL: (legacy) Client stats: tasks(received=0 accepted=0 ineligible=0) sessions(acquired=0 exhausted=0)
2023-02-13 12:54:19.985 [INF] WTCL: (anchor) Client stats: tasks(received=0 accepted=0 ineligible=0) sessions(acquired=0 exhausted=0)
2023-02-13 12:54:22.512 [INF] DISC: GossipSyncer(025f1456582e70c4c06b61d5c8ed3ce229e6d0db538be337a2dc6d163b0ebc05a5): applying gossipFilter(start=0001-01-01 00:00:00 +0000 UTC, end=0001-01-01 00:00:00 +0000 UTC)
2023-02-13 12:54:22.526 [INF] DISC: Broadcasting 179 new announcements in 18 sub batches
2023-02-13 12:54:22.524 [INF] DISC: GossipSyncer(021c97a90a411ff2b10dc2a8e32de2f29d2fa49d41bfbb52bd416e460db0747d0d): applying gossipFilter(start=2023-02-13 12:54:22.524078373 +0100 CET m=+3171703.818122654, end=2159-03-22 19:22:37.524078373 +0100 CET)
2023-02-13 12:54:30.205 [INF] CRTR: Examining channel graph for zombie channels
2023-02-13 12:54:30.457 [INF] CRTR: Pruning 0 zombie channels
2023-02-13 12:54:37.203 [CRT] SRVR: Health check: chain backend failed after 3 calls
2023-02-13 12:54:37.203 [INF] SRVR: Sending request for shutdown
2023-02-13 12:54:37.250 [INF] LTND: Received shutdown request.
2023-02-13 12:54:37.251 [INF] LTND: Shutting down...
2023-02-13 12:54:37.251 [INF] LTND: Gracefully shutting down.
2023-02-13 12:54:37.271 [INF] WTWR: Stopping watchtower
2023-02-13 12:54:37.290 [INF] WTWR: Stopping watchtower server
2023-02-13 12:54:37.290 [INF] WTWR: Watchtower server stopped successfully
2023-02-13 12:54:37.290 [INF] WTWR: Stopping lookout
2023-02-13 12:54:37.291 [INF] NTFN: Cancelling epoch notification, epoch_id=8
2023-02-13 12:54:37.291 [INF] WTWR: Lookout stopped successfully
2023-02-13 12:54:37.291 [INF] WTWR: Watchtower stopped successfully
2023-02-13 12:54:37.298 [INF] NANN: Channel Status Manager shutting down
2023-02-13 12:54:37.311 [INF] HSWC: HTLC Switch shutting down
[...]
2023-02-13 12:54:47.876 [INF] WTCL: (legacy) Force quitting watchtower client
2023-02-13 12:54:47.877 [INF] WTCL: (legacy) Force quitting task pipeline
2023-02-13 12:54:47.877 [INF] WTCL: (legacy) Task pipeline unclean shutdown complete
2023-02-13 12:54:47.878 [INF] WTCL: (legacy) Watchtower client unclean shutdown complete, stats: tasks(received=0 accepted=0 ineligible=0) sessions(acquired=0 exhausted=0)
2023-02-13 12:54:57.878 [INF] WTCL: (anchor) Force quitting watchtower client
2023-02-13 12:54:57.878 [INF] WTCL: (anchor) Force quitting task pipeline
2023-02-13 12:54:57.879 [INF] WTCL: (anchor) Task pipeline unclean shutdown complete
2023-02-13 12:54:57.879 [INF] HLCK: Health monitor shutting down
2023-02-13 12:54:57.879 [INF] WTCL: (anchor) Watchtower client unclean shutdown complete, stats: tasks(received=0 accepted=0 ineligible=0) sessions(acquired=0 exhausted=0)
2023-02-13 12:54:57.900 [INF] RPCS: Stopping RPC Server
2023-02-13 12:54:57.901 [INF] RPCS: Stopping AutopilotRPC Sub-RPC Server
2023-02-13 12:54:57.901 [INF] RPCS: Stopping ChainRPC Sub-RPC Server
2023-02-13 12:54:57.905 [INF] RPCS: Stopping NeutrinoKitRPC Sub-RPC Server
2023-02-13 12:54:57.906 [INF] RPCS: Stopping VersionRPC Sub-RPC Server
2023-02-13 12:54:57.926 [INF] RPCS: Stopping WatchtowerRPC Sub-RPC Server
2023-02-13 12:54:57.937 [INF] RPCS: Stopping WalletKitRPC Sub-RPC Server
2023-02-13 12:54:57.945 [INF] RPCS: Stopping PeersRPC Sub-RPC Server
2023-02-13 12:54:57.946 [INF] RPCS: Stopping RouterRPC Sub-RPC Server
2023-02-13 12:54:57.946 [INF] RPCS: Stopping WatchtowerClientRPC Sub-RPC Server
2023-02-13 12:54:57.969 [INF] RPCS: Stopping SignRPC Sub-RPC Server
2023-02-13 12:54:57.970 [INF] RPCS: Stopping InvoicesRPC Sub-RPC Server
2023-02-13 12:54:57.970 [INF] TORC: Stopping tor controller
2023-02-13 12:54:58.131 [INF] LTND: Shutdown complete

Hey @zx9r,
Just curious about this, why would you want LND to stay alive when the chain backend sub-system is failing?
I would assume it's safer to not perform any actions over channels as long as you are disconnected from the chain, which is used as the source of truth. It seems to me like lnd should restart until the chain backend comes back up online.

 Did LND fail to start after that shut down?

As mentioned by @GeorgeTsagk, lnd needs a connection to bitcoind to work, that's what the health check is there for, so it can restart lnd when bitcoind goes down (assuming you have a dockerized or systemd environment that restarts lnd automatically). You can disable the health check but that is not recommended.
Closing since this is expected behavior. Feel free to re-open if you disagree.


ibrowse compilation error

vagrant@vagrant-ubuntu-trusty-64:/vagrant/evercam-media$ mix deps.compile ibrowse
==> ibrowse (compile)
Compiling src/ibrowse_lib.erl failed:
src/ibrowse_lib.erl:371: erlang:now/0: Deprecated BIF. See the "Time and Time Correction in Erlang" chapter of the ERTS User's Guide for more information.
ERROR: compile failed while processing /vagrant/evercam-media/deps/ibrowse: rebar_abort
** (Mix) Could not compile dependency ibrowse, /home/vagrant/.mix/rebar command failed. If you want to recompile this dependency, please run: mix deps.compile ibrowse

Fixed here

:+1:


Add dapr docs

Description
Initial PR for adding Dapr Docs with examples on how to use the SDK. Actors will be added in a follow up PR.
Checklist
Please make sure you've completed the relevant tasks for this PR, out of the following list:

[x] Code compiles correctly
[x] Created/updated tests
[x] Extended the documentation

Other than the 1 comment I added this is looking very nice! Thanks a lot for your amazing contribution, can't wait to merge it 😊

Other than the 1 comment I added this is looking very nice! Thanks a lot for your amazing contribution, can't wait to merge it 😊

Please let me know if there is additional feedback. Otherwise it would be good to get this merged into the docs as a first pass! Thank you.

Approved and merged! Thanks a lot!!


Results with fixing inconsistent, no bug but could be improved.

When missing entities in automation are fixed by altering the automation Spook does dismiss the repair issue.
When missing devices in automation are fixed by altering the automation Spook does NOT dismiss the repair issue. (doesn't reproduce after reboot)
When missing entities or device in automation is fixed by deleting the automation Spook does NOT dismiss the repair issue. (doesn't reproduce after reboot)

I'm lost on what you are trying to say?
Could you write a bit more clearly what you mean?

Let me try. When spook raises a repair for a missing entity or device in an automation you can go into the automation and do what is needed to fix it.
Either you alter the automation or you delete the automation.
1 When there is an entity mentioned in an automation that doesn't exist anymore you fix that by altering the automation.
When you do this the repair is resolved.
2 When this situation is identical but with a missing device the repair doesn't get resolved.
3 When you delete the automation instead it doesn't get resolved either.
And now that I am writing this down I start to wonder... is it spook that resolves the repair or is that something that HA does? Maybe I'm addressing this in the wrong place...

There is nothing to be done about that. At runtime, there is still a reference (even after you have removed it from the automation). Restarting Home Assistant is the only way to resolve it. Meanwhile, Spook will (at least) try picking up the changes to the extend possible.


"Pin to Start Menu" needed.

What's the Problem?
No response
Solution/Idea
Add  "Pin to the Start Menu" to the right-click menu
Alternatives
Add  "Pin to the Start Menu" to the right-click menu
Priorities

Capability
Priority

This proposal will allow developers to accomplish W
Must

This proposal will allow end users to accomplish X
Should

This proposal will allow developers to accomplish Y
Could

This proposal will allow end users to accomplish Z
Won't

Files Version
<IP_ADDRESS>
Windows Version
Windows 11 22H2 22581.200
Comments
No response

This is already supported in the extended context menu (shift + right click).

@yaichenbaum it should be a main option. Also having a pin to taskbar would be very nice :)

This is already supported in the extended context menu (shift + right click).

It is not showing "Pin to Start Menu" when i Shift + Right Clicking file


Mark files.upload / rtm.connect as deprecated

See the following announcements:

https://api.slack.com/changelog/2024-04-a-better-way-to-upload-files-is-here-to-stay
https://api.slack.com/changelog/2024-04-discontinuing-new-creation-of-classic-slack-apps-and-custom-bots

Category (place an x in each of the [ ])

[ ] bolt (Bolt for Java)
[ ] bolt-{sub modules} (Bolt for Java - optional modules)
[x] slack-api-client (Slack API Clients)
[ ] slack-api-model (Slack API Data Models)
[ ] slack-api-*-kotlin-extension (Kotlin Extensions for Slack API Clients)
[ ] slack-app-backend (The primitive layer of Bolt for Java)

Requirements
Please read the Contributing guidelines and Code of Conduct before creating this issue or pull request. By submitting, you agree to those rules.

It seems that Codecov has some issues with their token resolution. I've re-generated the repo token and set it to this repo but it didn't help. Will check this out again tomorrow


Add Michael Chung to Contributors list

@mikechung11, I'm quite elated about your PR. I wanna evolve this project to addresses various problems faced by first-time contributors. I'd love to learn about your journey in open source community, the problems, pain points you had etc.
Could you explain how you felt when you went through the tutorial, made a PR and learned that I merged it?

@Roshanjossey I'd like to thank you for the step by step tutorial.  I felt that it was extremely easy to follow and successfully do a PR.  I have had previous experience using Git, Atlassian, and Visual Studio 2017, but this was my first time using Github.

@mikechung11, I’d urge you to continue contributing to other open source projects.
We also have a slack team to help/mentor people trying to contribute to open source projects.
You can join the team by going to https://firstcontributions.herokuapp.com

@Roshanjossey, Thank you for all the info and support.  I invited members of my team that are also new to github to go thru your PR tutorial as well.  They also found it very helpful.


L.Browser.touch_L.Browser.mobile

Fix for https://github.com/MrMufflon/Leaflet.Elevation/issues/67

thanks @astridx !!
@MrMufflon could you please merge this PR and release new version of your npm package ?
thanks for your work!


[Question]: Want to ask how to support the streaming of multi-document question

Question Validation

[X] I have searched both the documentation and discord for an answer.

Question
I want to implement multi-document streaming answers, I use SubQuestionQueryEngine, I found a built-in parameter of this method response_synthesizer, set ResponseSynthesizer.from_args(streaming=True）It seems to work, but it still reports ValueError: LLM must support streaming and set streaming=True. I tried to use service_context to solve this problem, but it didn't work

I was happy to solve the problem myself

@MonsterZwj how do you solve it, I get that error too ?


LoginPresenterTest fix

#20 LoginPresenter Unit-test fix
No need to rely on RxAndroidPlugins
Scheduler were injected for easier testing and for easier future change
LoginPresenterTest unit-test fixed

@hrskrs Thanks for the contribution. It is awesome.


td::Client deconstructor crash

Hi, I'm trying to use tdlib in a C++ project. I'm using the td::Client interface, but every time I run the program it crashes after closing client. I tried to run gdb, but this time somehow it does not crash.
This is the stack trace, although it is not very helpful.
Callstack Information (PID:3929)
Call Stack Count: 5
 0: (0xb6a1b962) [/usr/lib/libc-2.24.so] + 0x126962
 1: (0xb6a4a420) [/usr/lib/libc-2.24.so] + 0x155420
 2: __libc_thread_freeres + 0x22 (0xb6a4a372) [/usr/lib/libc-2.24.so] + 0x155372
 3: (0xb76fb5e7) [/usr/lib/libpthread-2.24.so] + 0x65e7
 4: clone + 0x6e (0xb69eb3ae) [/usr/lib/libc-2.24.so] + 0xf63ae
End of Call Stack

I have investigated and I found that the problem is in the ThreadPthread::join function, I also tried using std::thread instead but there was no difference.
Does anyone know what the problem is?

You need to show your code.

Nothing particular, only this:
td::Client* client = new td::Client();
delete client; // sigsev

I'm building tdlib inside Tizen Studio so maybe I have some wrong compiling configuration.

We implemented ThreadPthread specifically for Tizen, because std::thread crashed with SIGSEGV on construction. ThreadPthread worked correctly on Tizen for us back then.

I have used std::thread in other parts of the project and it works fine, but for some reason both std::thread and ThreadPthread crash in that situation, I'll continue to investigate but now I have no idea of the cause.
I'm using the latest Tizen compiler avaible (gcc 6.2.1).

Not sure but the problem could be caused by logging:
https://github.com/tdlib/td/blob/10a7edfbea98fd34dee5ff1c3190b8fe934c5407/tdutils/td/utils/logging.cpp#L206
I think dlog_print internally call a function like vfprintf, the function is called with an unsafe format string and that might cause this strange behavior.

Thanks, @bortoz! This is definitely a bug, caused by copy-paste from __android_log_write function usage. I have just pushed a fix for it. Could you check, whether the crash still happens?

The "%" character should be used very-very rare in the log, so I'm not sure that this bug is actually related to the crash.
Also there were a lot of internal changes in Client implementation, so updating to the new version can help itself.

I updated to the latest version of tdlib and Tizen Studio and it does not crash anymore.
Thanks for your time!


Drop support to python 3.7

Codecov Report

Merging #695 (9e886f3) into master (58329f8) will not change coverage.
The diff coverage is n/a.

:exclamation: Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.
@@           Coverage Diff           @@
##           master     #695   +/-   ##
=======================================
  Coverage   89.74%   89.74%
=======================================
  Files          27       27
  Lines        1746     1746
  Branches      311      311
=======================================
  Hits         1567     1567
  Misses        144      144
  Partials       35       35

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more

End of life of Python 3.7 is Jun 27th. We should probably drop support before then, so I'll add that info to the title of the pull request.

@jairhenrique I came across a test that looks like <3.6 only. Does this look like something that should be dropped in here as well?

I will drop!

@jairhenrique Would it be possible to delay this? I imagine a lot of companies will be continuing to use python 3.7 past end of life.

@alisakr Since the core language is no longer supported, I believe it is a waste of effort for libraries to maintain support for a deprecated version.
Python 3.8 has been live since October 2019. I believe enough time has passed to be able to move up a step in versions.
Keeping dependencies up to date is part of the job.

@jairhenrique agreed but sadly not practice (I'm trying to make it so). In any case, I think it's okay if tests don't run on python 3.7. in python 3.7 as long as there's nothing that explicitly prevents it from running on python 3.7. Is that the case?

@alisakr The version that is released with changes from this PR will not work with Python 3.7. You will be able to use an earlier version of the library.
All new fixes and improvements will prioritize live Python versions.

I fully support @jairhenrique in this, well said.

@alisakr in case you missed it, we made release 4.4.0 today right before dropping Python 3.7 support for upcoming 5.0.0. That should allow you to pull in one last round of bug fixes into a Python 3.7 environment — that was part of the idea behind #724 — while also being clear that the only path forward with VCR.py or anything Python is with Python >=3.8 from now on.


Latency increases due to the envoy http connection manager's delayed_close_timeout

Title: Latency increases due to the envoy http connection manager's delayed_close_timeout
Description:
We recently enabled Istio for our Nginx server deployed in our Kubernetes cluster and found that some of the upstream services' latency increased by 1s observed from the Nginx side. To be clear, the client traffic flow and the infrastructure can be described as follows:
client -----> AWS ALB ingress -----> Nginx server (Istio enabled) -----> multiple upstream services
And AWS ALB ingress, Nginx server, and all upstream services are in the same Kubernetes cluster.
We did some investigation and found that Envoy sets up a timer for the connection to the downstream based on the HTTP connection manager's delayed_close_timeout config, and it is 1s by default.
From the envoy proxy container's debug log, it seems that the envoy did not flush the write buffer and the downstream (Nginx) did not send the FIN packet to the envoy (did not initiate the connection close). Therefore, the connection is forced to close by envoy after the timeout:
2021-03-02T02:44:48.682523Z	debug	envoy client	[external/envoy/source/common/http/codec_client.cc:104] [C757968] response complete
2021-03-02T02:44:48.682552Z	debug	envoy connection	[external/envoy/source/common/network/connection_impl.cc:109] [C757967] closing data_to_write=0 type=2
2021-03-02T02:44:48.682556Z	debug	envoy connection	[external/envoy/source/common/network/connection_impl_base.cc:30] [C757967] setting delayed close timer with timeout 1000 ms
2021-03-02T02:44:48.682564Z	debug	envoy pool	[external/envoy/source/common/http/http1/conn_pool.cc:48] [C757968] response complete
2021-03-02T02:44:48.682569Z	debug	envoy pool	[external/envoy/source/common/http/conn_pool_base.cc:93] [C757968] destroying stream: 0 remaining
2021-03-02T02:44:48.682791Z	debug	envoy wasm	[external/envoy/source/extensions/common/wasm/context.cc:1104] wasm log stats_outbound: [extensions/stats/plugin.cc:612]::report() metricKey cache hit , stat=12
2021-03-02T02:44:48.682804Z	debug	envoy wasm	[external/envoy/source/extensions/common/wasm/context.cc:1104] wasm log stats_outbound: [extensions/stats/plugin.cc:612]::report() metricKey cache hit , stat=6
2021-03-02T02:44:48.682808Z	debug	envoy wasm	[external/envoy/source/extensions/common/wasm/context.cc:1104] wasm log stats_outbound: [extensions/stats/plugin.cc:612]::report() metricKey cache hit , stat=10
2021-03-02T02:44:48.682811Z	debug	envoy wasm	[external/envoy/source/extensions/common/wasm/context.cc:1104] wasm log stats_outbound: [extensions/stats/plugin.cc:612]::report() metricKey cache hit , stat=14
2021-03-02T02:44:49.242462Z	debug	envoy tracing	[external/envoy/source/extensions/tracers/datadog/datadog_tracer_impl.cc:87] flushing traces: 1 traces
2021-03-02T02:44:49.242541Z	debug	envoy tracing	[external/envoy/source/extensions/tracers/datadog/datadog_tracer_impl.cc:102] submitting 1 trace(s) to /v0.4/traces with payload size 884
2021-03-02T02:44:49.242582Z	debug	envoy router	[external/envoy/source/common/router/router.cc:477] [C0][S2679291336072070896] cluster 'datadog_agent' match for URL '/v0.4/traces'
2021-03-02T02:44:49.242629Z	debug	envoy router	[external/envoy/source/common/router/router.cc:634] [C0][S2679291336072070896] router decoding headers:

The envoy version we are using is:
envoy --version

envoy  version: 201124ab4fc06dc051c9aebdb49f1d2197e46f02/1.14.5-dev/Clean/RELEASE/BoringSSL

[optional Relevant Links:]

Any extra documentation required to understand the issue.

However, some of the upstream services are not affected. The envoy proxy debug log shows that:
2021-03-02T08:58:53.333068Z	debug	envoy connection	[external/envoy/source/common/network/connection_impl.cc:109] [C797633] closing data_to_write=143 type=2
2021-03-02T08:58:53.333073Z	debug	envoy connection	[external/envoy/source/common/network/connection_impl_base.cc:30] [C797633] setting delayed close timer with timeout 1000 ms
2021-03-02T08:58:53.333079Z	debug	envoy pool	[external/envoy/source/common/http/http1/conn_pool.cc:48] [C6] response complete
2021-03-02T08:58:53.333083Z	debug	envoy pool	[external/envoy/source/common/http/conn_pool_base.cc:93] [C6] destroying stream: 0 remaining
2021-03-02T08:58:53.333129Z	debug	envoy connection	[external/envoy/source/common/network/connection_impl.cc:622] [C797633] write flush complete
2021-03-02T08:58:53.333265Z	debug	envoy connection	[external/envoy/source/common/network/connection_impl.cc:514] [C797633] remote early close
2021-03-02T08:58:53.333271Z	debug	envoy connection	[external/envoy/source/common/network/connection_impl.cc:200] [C797633] closing socket: 0
2021-03-02T08:58:53.333315Z	debug	envoy conn_handler	[external/envoy/source/server/connection_handler_impl.cc:111] [C797633] adding to cleanup list

As you can see, it showed that the write buffer flushed and the remote (Nginx) sent the FIN to initiate the connection close.
I am confused by this inconsistent behavior from the envoy proxy after enabling Istio. And not sure what causes such behavior. Any help or guide is appreciated.

It's expected that if an error occurs for HTTP/1.1 that Envoy will do delayed close.  This is to avoid a race condition where if a client were sending a POST, it would get a TCP reset before it parsed the L7 error and not handle the error response.
It should be flushing the body immediately with a connection close header - if you can provide wireshark dumps showing the data was not sent we can look into it.  If the client won't treat the error response as complete without TCP fin, you should be able to lower the delay close timeout to address it.

@alyssawilk Thank you. This is the Wireshark dumps that captured the abnormal traffic between downstream (Nginx), envoy, and one upstream service:

As you can see from packet 17, the envoy initiated the closing sequence with 1s latency. And from the debug log, I did not see the write flush complete log. From what I understand from the doc, the envoy will initiate the connection close:

NOTE: This timeout is enforced even when the socket associated with the downstream connection is pending a flush of the write buffer.

I also attach the normal one here. You can see that the downstream (Nginx) initiated the closing with packet 19:

Additional information:

Both upstream services are not enabled with Istio (no envoy sidecar in the Pod)

wow, this is super weird.   Any chance you can hop on Envoy slack for some back and forth?  I'm around for a few hours today else could pick it up Monday

@alyssawilk Thanks. Sorry for the late response. We are in different time zones. I will hop on Slack and leave you messages.

@alyssawilk  @wood-push-melon we are also seeing increased latency with similar behavior, can u tell what was the fix


Suppress error messages

Dear Max,
I'm using wd id $article_string since severals years in my scripts. Thank you very much for your tool!
As far as I remember just a few version ago there were no error messages like Error: id not found.
How may I suppress any error message from wikibase-cli for usage with bash one-liner scripts?

you could ignore errors "the shell way" by redirecting stderr :
wd id "$article_string" 2> /dev/null

would that be enough for your need?


Cleaner multi-arch build

Create the specific tagged arch images separately and then create a manifest with both images.
This makes the output much easier to manage. The time to create seems similar to the one command build.

Works locally, broken in github actions.


Add Keep3r support for op-roots

Problem
Currently relayer proxy is not in play for oproots contract calls, they need to happen via Keep3r network.
Impact
Increase security of proposer setup and reduce cost
Proposed Solution
Remove Autonolas usage from our contrtacts
Acceptance Criteria

[ ] Remove Autonolas from all our contracts
[ ] Update keep3r scripts to support op-mode
[ ] Opmode operations (propose and finalize) are working through keep3r
[ ] slowmode operations (processfromroot and propagate) are working through keep3r

@liu-zhipeng please add subtask in here

After recent updates, We decided to keep the keep3r support as backlog.


Add test for parameters shadowing existing bindings.

Test description:

The function parameters must properly shadow the outer scope's bindings.
When the same bindings exist in the environment and function parameters,
the function parameters must properly overwrite the environment bindings.

Nice catch, tanks!


Language loading

Include application/language in the loading of a language file, for consistency with the other application components (config, libraries, etc).
At the moment, language files are loaded from system/language, and then over-ridden in a lang->load call or else in one of the package paths. This change would load them from system/language, over-ride them from application/language, and then finally from a path specified in the lang->load call or else in one of the package paths.
Signed-off-by:Master Yoda<EMAIL_ADDRESS>

I'm quite sure APPPATH is included in the package paths array ...

Looking into Loader, it looks like the package paths are only set when add_package_path is called. Will test.

I don't see where it is in the code, but it does indeed load a language file from APPPATH. My bad!


Stop hiding when the app is closed

When I close Obsidian and open it again, the files that I previously hide appear in the file explore. For them to disappear I have to toggle File Hider off and then on.

+1

This has been reported previously. Please check for existing issue reports before creating a new one, and use the bug report template for reporting.


hello_world/Makefile:151 has not declare "$(B_NAME)"

When I in the directory hello_world and try to compile use the options below:
make all \
        TARGET=sw_emu \
        DEVICE=zcu102_base \
        HOST_ARCH=aarch64 \
        SYSROOT=/opt/petalinux/2019.2/sysroots/aarch64-xilinx-linux/

This Command will make an error because the $(B_NAME) is not declare in the Makefile at 151 line.
It causes wrong path, and I try to change it to the right path of my sysroots, then the Makefile works correctly.

OK, I found reason was I didn't declare the PLATFORM_REPO_PATHS.
So the B_NAME couldn't get a value.
And the B_NAME was defined in utils.mk.


Run Camanjs on a new Image() or image data

I'm working on an app where i capture the image from my webcam with WebRTC. But it looks like, just from code analysis, that it doesn't support working on a new Image() or image data, is that correct? If so it would be nice to have that, if not how would that work?

Here is the workaround I found:
var image = new Image();
image.onload = function () {
    var div = document.createElement("div");
    div.appendChild(image);
    Caman(image, function () {
        this.sepia(50); // Whatever modification you need to do.
        this.render(function () {
            image = div.childNodes[0];
        });
    });
};
image.src = "image.jpeg";

@avandecreme > Thanks a lot for this simple ticks.
It's working perfectly. For those who need it, see my fiddle which:

Create a simple canvas with green dummy text.
Rotate this canvas to set it feet in the air and head on the ground 🎸🤘🎵 Pixies🎵🤘🎸
Download final reversed file
All of this without ever render the canvas in the DOM.


Bot Service az bot authsetting show - Scopes filed is not returned by az bot authsetting show

Version
2.22.1
Describe the bug
Scope is not included in the return value of az bot authsetting show
To Reproduce

Create a Bot Auth Setting MyTestAuthSetting with Azure Active Directory v2
Fill up the fields and have some test value in the Scopes filed.
In PowerShell, try to use the following code to loop through all the properties in the return result.

# Load setting details
$sourceSettingDetail = az bot authsetting show --subscription $subscriptionId --resource-group $resourceGroup --name $botName --setting-name "MyTestAuthSetting" | Out-String | ConvertFrom-Json

# Check the returned value
$parameters = @()
foreach ($parameter in $sourceSettingDetail.properties.parameters) {
	Write-Host $parameter
}

Expected behavior
The Scopes field value can be found in the return result

route to service team

open in the bf cli repo
https://github.com/microsoft/botframework-cli/issues/1333


fix: Make sure not to crash user search api when search service returns empty dict

Summary of Changes
With the changes introduces in this PR: https://github.com/lyft/amundsensearchlibrary/pull/111 , if your user index feature is not implemented in the search i.e., has pass, then the frontend does not work and crashes. This PR will fix this issue.
Tests
Added the corresponding test case!
Documentation
N/A
CheckList
Make sure you have checked all steps below to ensure a timely review.

[x] PR title addresses the issue accurately and concisely. Example: "Updates the version of Flask to v1.0.2"

In case you are adding a dependency, check if the license complies with the ASF 3rd Party License Policy.

[x] PR includes a summary of changes, including screenshots of any UI changes.
[x] PR adds unit tests, updates existing unit tests, OR documents why no test additions or modifications are needed.
[x] In case of new functionality, my PR adds documentation that describes how to use it.

All the public python functions and the classes in the PR contain docstrings that explain what it does

[x] PR passes all tests documented in the developer guide

Codecov Report

Merging #503 into master will increase coverage by 2.63%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master     #503      +/-   ##
==========================================
+ Coverage   81.02%   83.65%   +2.63%
==========================================
  Files         226      184      -42
  Lines        5638     3854    -1784
  Branches      666      499     -167
==========================================
- Hits         4568     3224    -1344
+ Misses       1004      612     -392
+ Partials       66       18      -48

Impacted Files
Coverage Δ

amundsen_application/base/base_mail_client.py

amundsen_application/log/action_log_callback.py

amundsen_application/config.py

...undsen_application/api/utils/notification_utils.py

...ndsen_application/base/base_announcement_client.py

...pplication/proxy/issue_tracker_clients/__init__.py

amundsen_application/api/utils/request_utils.py

amundsen_application/api/preview/dashboard/v0.py

...n/base/examples/example_superset_preview_client.py

amundsen_application/api/issue/issue.py

... and 31 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3ee8845...c06ebb3. Read the comment docs.

@feng-tao can you please review. This PR fixes a crash introduced in the search library.

@verdan , qq: is it correct that ING has indexed  user info into Atlas but didn't implement the search function for user entity?

@feng-tao that is true. We still need to implement the user related features for Atlas. The only reason we enabled the userIndex is to enable the User Profile. But yes, we will be implementing all these features over the time.


(Chore) Use cross-env

Closes #317.
I don't have Windows so I couldn't test it there, but it works on Linux.

I tested this in windows and it works, but it has a problem generating the contracts in public/contracts. As far as I can tell, the same issue happens in master, but since I can't really test that everything is working, I'm going to close this PR and the issue.
If someone wants they can give it a try, but since none of us seems to use windows for developing, I think this is really low priority for now.


tvOS Support

Hi @yonaskolb
Have you test it in a real tvOS box?

Yep, works fine

Great! Thank you.


arch/riscv: Jump instead call riscv_dispatch_syscall

Summary
adn revert "arch/risc-v: use STACK_FRAME_SIZE for in S-mode syscall asm"
Impact
RISCV kernel mode
Testing

@pkarashchenko could you merge this patch.

@pkarashchenko could you merge this patch.

Yes. Will review and merge

@xiaoxiang781216 sorry did not have time to test this before today. Testing shows that this works.


as the title suggesting

Product and Version [VS/VSCode]:
OS Version [macOS/Windows/Linux]:
Live Share Extension Version:
Target Platform or Language [e.g. Node.js]:
What were you doing when you encountered the desync?
How often have you encountered desyncs?

oops, mistake, please remove this one


migrate to TypeScript

not sure if this is still relevant

Addressed by #72

@tokebe Is it okay to close this issue, if it's only deployed on Dev/CI instances?

Relevant changes deployed to Prod.


BUG: potential missing fuzzing results when ListProgrammingLanguages() returns an error

Describe the bug
The fuzzing check might return empty when RepoClient.ListProgrammingLanguages() fails and an error occurs, but has already found checking results  of ossFuzz or CFLite. See the code logic here.
Reproduction steps
I haven't tested this with cases because the call of RepoClient.ListProgrammingLanguages() always succeeds. However, in raw.Fuzzing, if we've already found ossFuzz/CFLite fuzzers but the repo language retrieval failed, it'll return checker.FuzzingData{} (empty data), such that the previous fuzzer records might be dropped.
Expected behavior
The raw.Fuzzing function should return results of ossFuzz/CFLite fuzzers even if an error occurs when retrieving the repo languages.
That said, change this line from
return checker.FuzzingData{}, fmt.Errorf("cannot get langs of repo: %w", err)

to
return checker.FuzzingData{Fuzzers: fuzzers}, fmt.Errorf("cannot get langs of repo: %w", err)

Additional context
We might should not always trust the GitHub List Repo Languages API will give us the correct list of repo languages. It might give us an error, an empty one, or one with duplicates (issue #2060) sometimes.

The possible reasons for the ListProgrammingLanguages to fail can be traced to the langauge setup() func.
If (1) the request to the GitHub API fails or (2) parsing the response fails, the setup() func will wrap the error and return it all the way back to ListProgrammingLanguages. That said, a possible error situation might be the first one, when the GitHub API is not available, so we cannot get the list of repo languages to check the function-level fuzzers.

Actually, I haven't seen it fail in my previous testing, and the ListProgrammingLanguages is only used by the fuzzing check now, so I don't think its failure will affect the other checks.
If the HTTP request to the GH Language API fails and thus leads to the ListProgrammingLanguages failing, the only check that will be affected should be the Fuzzing check. My concern is if the language API fails with an HTTP error when we already have fuzzer results of other fuzzing tools in var fuzzers, returning an empty fuzzer result at L98 might lose the previous results.
Again, since I have not seen the lang API error before, maybe I'm a bit over-worried about this?

It's probably fine leave as-is then. It's good to return an error, rather than ignore it and use the incomplete results. Feel free to close the bug if your agree.

thank you!


4.12 breaks my app on IE11

I am reporting an issue with
TypeScript definitions
[X ] another resource in this repository
My application which is in production for more than a year now and is built using arcgis js 4.x and angular breaks once I upgrade it to use 4.12.
The map and other esri widgets like layer, search and legend DO not load.
This is the error that I get in the debugger "Object.getPrototypeOf: 'this' is not an Object" .
If I downgrade the arcgis js version from 4.12 to 4.10 the map and other widgets like layer, search and legend load fine.
what changed to cause this?
FYI, I have all the IE 11 polyfills .
============================================
import 'core-js/es6/symbol';
import 'core-js/es6/object';
import 'core-js/es6/function';
import 'core-js/es6/parse-int';
import 'core-js/es6/parse-float';
import 'core-js/es6/number';
import 'core-js/es6/math';
import 'core-js/es6/string';
import 'core-js/es6/date';
import 'core-js/es6/array';
import 'core-js/es6/regexp';
import 'core-js/es6/map';
import 'core-js/es6/weak-map';
import 'core-js/es6/set';
/** IE10 and IE11 requires the following for NgClass support on SVG elements /
import 'classlist.js'; // Run npm install --save classlist.js.
/* IE10 and IE11 requires the following for the Reflect API. /
import 'core-js/es6/reflect';
import 'core-js/es7/array';
import 'core-js/es7/object';
/* Evergreen browsers require these. /
// Used for reflect-metadata in JIT. If you use AOT (and only Angular decorators), you can remove.
import 'core-js/es7/reflect';
/
Required to support Web Animations @angular/platform-browser/animations.
Needed for: All but Chrome, Firefox and Opera. http://caniuse.com/#feat=web-animation
/
import 'web-animations-js'; // Run npm install --save web-animations-js.
/*************************************************************************************************
Zone JS is required by default for Angular itself.
*/
import 'zone.js/dist/zone'; // Included with Angular CLI.

was told by @andygup  to submit the issue here

@Abexdatl can you provide the full error message or a screen capture of the console messages. Even better if you can provide a working stackblitz example that reproduces the issue. Here is an example: https://stackblitz.com/edit/angular-cli-esri-map2?file=src/main.ts

Closing... if you have additional info pls let us know.


Unable to publish package after changing listen address

I was trying and using verdaccio with the default setting (localhost:4873) and it was working fine.
I now change the listen address to <IP_ADDRESS>:4873 to allow other machines accessing it.
But then I cannot publish to it anymore:
npm ERR! need auth auth required for publishing
npm ERR! need auth You need to authorize this machine using `npm adduser`

When I run npm adduser again, it complains the user already exists.
I try to uninstall and reinstall verdaccio but the error still presist.
How can I clear the users and start over?
EDIT: To clarify, I can't publish when I change the package.json/publishConfig pointing to the public ip address of the hosting machine.
Changing it back to localhost:4873 works.

Same problem here :(

I do knot know why this error happens but a quick fix is to setup reverse proxy (Apache or Nginx) so you can have verdaccio running on localhost but still be accessible from other machines.

Please have a look at my edited comment above! (Wrong permission in the config was the failure)

I checked my config file and it doesn't have the users section. Here is my config:
#
# This is the default config file. It allows all users to do anything,
# so don't use it on production systems.
#
# Look here for more config file examples:
# https://github.com/verdaccio/verdaccio/tree/master/conf
#

# path to a directory with all packages
storage: F:/verdaccio/storage

auth:
  htpasswd:
    file: F:/verdaccio/htpasswd
    # Maximum amount of users allowed to register, defaults to "+inf".
    # You can set this to -1 to disable registration.
    #max_users: 1000

# a list of other known repositories we can talk to
uplinks:
  npmjs:
    url: https://registry.npmjs.org/

packages:
  '@*/*':
    # scoped packages
    access: $all
    publish: $authenticated
    proxy: npmjs

  '**':
    # allow all users (including non-authenticated users) to read and
    # publish all packages
    #
    # you can specify usernames/groupnames (depending on your auth plugin)
    # and three keywords: "$all", "$anonymous", "$authenticated"
    access: $all

    # allow all known users to publish packages
    # (anyone can register by default, remember?)
    publish: $authenticated

    # if package is not available locally, proxy requests to 'npmjs' registry
    proxy: npmjs

# log settings
logs:
  - {type: stdout, format: pretty, level: http}
  #- {type: file, path: verdaccio.log, level: info}
listen:
  - <IP_ADDRESS>:4873

I would try to change the listen property to something like:

http://<IP_ADDRESS>:4873

If this doesn't help (for test purposes only!) publish: $all

On the machine that you're trying to run verdaccio on use the local ip address:
listen:     - <IP_ADDRESS>:4873

Yes, using local address is fine.
The OP is about not able to publish with the existing user before changing from localhost:... to 10.x.x.x:....
For now, I'm using another user to publish. And will likely be my solution to my problem, because our IT will provide ArtiFactory for me in the future to publish the npm packages. This means I'll deprecate my usage of verdaccio soon.
However, this problem is still real and would affect other users who uses verdaccio.

I tried and I cannot reproduce. What I did was:

Using a new Ubuntu installation running in a VM
Installed latest verdaccio (2.1.1)
Using your same configuration
I created a new user
I logged successfully
I published successfully

Juans-MBP-2016:test jpicado$ npm adduser --registry http://<IP_ADDRESS>:4873
Username: juan
Password:
Email: (this IS public<EMAIL_ADDRESS>Logged in as juan on http://<IP_ADDRESS>:4873/.
Juans-MBP-2016:test jpicado$ npm publish --registry http://<IP_ADDRESS>:4873

><EMAIL_ADDRESS>prepublish /Users/jpicado/projects/test
> npm run lint && npm run build

><EMAIL_ADDRESS>lint /Users/jpicado/projects/test
> eslint .

><EMAIL_ADDRESS>build /Users/jpicado/projects/test
> babel src/ --out-dir lib/ --copy-files

src/index.js -> lib/index.js
+<EMAIL_ADDRESS>Juans-MBP-2016:test jpicado$

I'll need more info in order to reproduce it.

Using a new Ubuntu installation running in a VM
Installed latest verdaccio (2.1.1)
First config with http://localhost:4873
I created a new user
I logged successfully
I published successfully
Change to http://<IP_ADDRESS>:4873
Try to publish

@unional are you changing the registry domain as in going from --registry=http://localhost:4873 to --registry=http://<IP_ADDRESS>:4873?
When you add a user to npm or verdaccio it adds an entry to the users .npmrc file with the users auth token. This is domain specific. e.g.
//localhost:4873/:_authToken="<auth token here>" wont work for http://<IP_ADDRESS>:4873 even though its the same server. You can update your .npmrc file to the new domain.

@Aigeec has the right answer to the initial question. Closing.


After run some time, the databus thread is dead

I use databus to read the mysql binlog, but after some time, the binlog read thread seems dead, only refresh the schema, could you give some advise?
Thanks

Hi @hopecheng,
Yes, I think exception handling can be improved. Please feel free to submit the pull request. If you have managed the fix this.
Thanks,
Srini.


add audio sink block, rtl_fm outputs to speakers

Awesome, thank you! I was just thinking that I needed this.
Merged (plus some stuff to make the audio feature optional, avoiding a dependency for non-audio projects).

Commited as 62568c2f5cd6ee8284f66fc253bea07c4ec2a3fa


Add images: Android Basics with Compose

URL of codelab(https://developer.android.com/codelabs/basic-android-kotlin-compose-add-images?continue=https%3A%2F%2Fdeveloper.android.com%2Fcourses%2Fpathways%2Fandroid-basics-compose-unit-1-pathway-3%23codelab-https%3A%2F%2Fdeveloper.android.com%2Fcodelabs%2Fbasic-android-kotlin-compose-add-images#5)
Tutorial Name : 'Add images to your Android app'
Under Section : 'Align and arrange the Text' , in Point Number 1
"Your turn! In the MainActivity.kt file, scroll to where the GreetingText() function is called and notice the padding attribute.".
The function in the above line should be 'GreetingImage()' and not 'GreetingText()'

Hi @DreamingDroid
Thank you for writing in with your concern.
The wording in the lesson is correct.
The student needs to scroll to where the GreetingText() function is called. You are correct that it is in the GreetingImage() function though.
Hope this helps clarify it.
Regards.


Add babelify and es6 preset

Closes: https://github.com/MetaMask/provider-engine/issues/192
NOTE: I didn't commit build artifacts. Should I? I think it's pointless to have them in repo.

One benefit of having them in the repo is that it allows people to npm install directly off of github.

@danfinlay why would you want to do it when you have npm? I think testrpc used to do this too but they recently stopped.
As a side note: current files in dist folder seems to be outdated. Running yarn bundle on current master generates diff.

Thanks for the PR, added your changes manually


Flesh out design for recommendation page

We have a very simple recommendation page prototype but need this to be fully designed and user tests.

Closing stale issue. It's been so long that design and user research will have to be restarted to make sure all feedback/data gathered is fresh.


Add Usman

Add my name to the collection :-).

Hey @usmanatron,
Something went wrong with the build.
TravisCI finished with status errored, which means the build failed because of something unrelated to the tests, such as a problem with a dependency or the build process itself.
View build log
TravisBuddy Request Identifier: 489dfca0-0393-11e9-87e5-3d0a59f34ca1


update pre-commit hook versions, use new ruff config format

At least a year ago (I'm not sure when precisely), ruff broke up the [ruff] table in pyproject.toml in favor of storing configuration in several more focused tables, like [tool.ruff.lint]. Context: https://github.com/rapidsai/rapids-reviser/pull/51/files#r1755430166
This proposes the following:

using that new format here, to avoid build issues when that deprecation eventually is enforced and becomes an error
updating all the pre-commit hooks w/ pre-commit autoupdate

/merge


Http Client Cookies is not maintained in consistent manner

Description:
When a session cookie is refreshed from the server, the http client persists those as separate cookies eventhough the name is the same.
Additional Note:
When I tried to add the cookie options to set path and other flags, the cookies are not persisted at all. :(
Sample Server: Session cookie is updated in the head resource
import ballerina/http;
import ballerina/io;

service /API_SALES_ORDER_SRV on new http:Listener(9093) {

    int headCount = 0;
    int postCount = 0;

    http:CookieOptions cookieConfig = {
        path: "/",
        maxAge: 3600,
        httpOnly: true,
        secure: true,
        domain: "localhost"
    };
    resource function head .() returns http:Response {
        io:println("Head invoked " + self.headCount.toBalString());

        http:Response res = new;
        if self.headCount == 0 {
            res.setHeader("X-CSRF-TOKEN", "token1");
            //http:Cookie cookie1 = new http:Cookie("session", "session1", self.cookieConfig);
            http:Cookie cookie1 = new http:Cookie("session", "session1");
            res.addCookie(cookie1);
        } else {
            res.setHeader("X-CSRF-TOKEN", "token2");
            //res.addCookie(new http:Cookie("session", "session2", self.cookieConfig));
            res.addCookie(new http:Cookie("session", "session2"));
        }
        self.headCount = self.headCount + 1;
        return res;

    }

    resource function post A_SalesOrder(http:Request req) returns http:Response {
        http:Cookie[] cookies = req.getCookies();
        http:Response res = new;

        io:println("Post invoked " + self.postCount.toBalString());
        io:println("Cookies for post: ");
        foreach http:Cookie cookie in cookies {
            io:println(cookie.name + " : " + cookie.value + " : " + (cookie.path ?: ""));
        }

        if self.postCount == 0 {
            if cookies.length() == 1 && cookies[0].name == "session" && cookies[0].value == "session1" {
                res.statusCode = 200;
                res.setPayload("Sales Order Created");
            } else {
                res.statusCode = 403;
            }
        } else if self.postCount == 1 {
            if cookies.length() == 1 && cookies[0].name == "session" && cookies[0].value == "session1" {
                res.statusCode = 403;
                res.addHeader("X-CSRF-TOKEN", "Required");
            } else {
                res.statusCode = 400;
            }
        } else {
            if cookies.length() == 1 && cookies[0].name == "session" && cookies[0].value == "session2" {
                res.statusCode = 200;
                res.setPayload("Sales Order Created");
            } else {
                res.statusCode = 403;
                res.addHeader("X-CSRF-TOKEN", "Required");
            }
        }
        self.postCount = self.postCount + 1;
        return res;
    }

}

Client
public function main() returns error? {
    http:Client httpClient = check new ("http://localhost:9093/API_SALES_ORDER_SRV", cookieConfig = {
        enabled: true
    });

    http:Response head = check httpClient->head("/");
    io:println("First Head : " + head.statusCode.toString());
    string token = (check head.getHeaders("X-CSRF-TOKEN"))[0];
    io:println("First Head Token: " + token);

    http:Response post = check httpClient->post("/A_SalesOrder", message = {
        body: {
            "SalesOrder": "100000000"
        }
    }, headers = {
        "X-CSRF-TOKEN": token,
        "Content-Type": "application/json"
    });
    io:println("First Post : " + post.statusCode.toString());
    http:Cookie[] cookies = post.getCookies();
    io:println("Cookies for post: ");
    foreach http:Cookie cookie in cookies {
        io:println(cookie.name + " : " + cookie.value + " : " + (cookie.path ?: ""));
    }

    post = check httpClient->post("/A_SalesOrder", message = {
        body: {
            "SalesOrder": "100000000"
        }
    }, headers = {
        "X-CSRF-TOKEN": token,
        "Content-Type": "application/json"
    });
    io:println("Second Post : " + post.statusCode.toString());
    cookies = post.getCookies();
    io:println("Cookies for post: ");
    foreach http:Cookie cookie in cookies {
        io:println(cookie.name + " : " + cookie.value + " : " + (cookie.path ?: ""));
    }

    head = check httpClient->head("/");
    token = (check head.getHeaders("X-CSRF-TOKEN"))[0];
    io:println("Second Head : " + head.statusCode.toString());
    io:println("Second Head Token: " + token);

    post = check httpClient->post("/A_SalesOrder", message = {
        body: {
            "SalesOrder": "100000000"
        }
    }, headers = {
        "X-CSRF-TOKEN": token,
        "Content-Type": "application/json"
    });
    io:println("Third Post : " + post.statusCode.toString());
    cookies = post.getCookies();
    io:println("Cookies for post: ");
    foreach http:Cookie cookie in cookies {
        io:println(cookie.name + " : " + cookie.value + " : " + (cookie.path ?: ""));
    }

}

This feature is currently blocked as we cannot test the refresh scenario, https://github.com/ballerina-platform/ballerina-library/issues/6047

Please find the following trace logs from the above client:

The first HEAD request

HEAD /API_SALES_ORDER_SRV/ HTTP/1.1
host: localhost:9093
user-agent: ballerina
connection: keep-alive

The associated response

HTTP/1.1 200 OK
X-CSRF-TOKEN: token1
Set-Cookie: session=session1
content-length: 0
server: ballerina

Now we should add the session cookie in the subsequent requests via the client

The first POST request: Note that the session cookie is present in the request

POST /API_SALES_ORDER_SRV/A_SalesOrder HTTP/1.1
X-CSRF-TOKEN: token1
Content-Type: application/json
Cookie: session=session1
host: localhost:9093
user-agent: ballerina
connection: keep-alive
content-length: 35

The associated response:

HTTP/1.1 200 OK
content-type: text/plain
content-length: 19
server: ballerina

The second POST request: Note that the same session cookie is present in the request

POST /API_SALES_ORDER_SRV/A_SalesOrder HTTP/1.1
X-CSRF-TOKEN: token1
Content-Type: application/json
Cookie: session=session1
host: localhost:9093
user-agent: ballerina
connection: keep-alive
content-length: 35

The associated response:

HTTP/1.1 403 Forbidden
X-CSRF-TOKEN: Required
content-length: 0
server: ballerina

The next HEAD request: Note that the same session cookie is present in the request

HEAD /API_SALES_ORDER_SRV/ HTTP/1.1
Cookie: session=session1
host: localhost:9093
user-agent: ballerina
connection: keep-alive

The associated response:

HTTP/1.1 200 OK
X-CSRF-TOKEN: token2
Set-Cookie: session=session2
content-length: 0
server: ballerina

Now we received another Set-Cookie header with the same key. The issue raise from this step since we have two cookies with separate values. In that case, http adds both of these as part of cookie header in the subsequent request.

The next POST request: Note the Cookie header

POST /API_SALES_ORDER_SRV/A_SalesOrder HTTP/1.1
X-CSRF-TOKEN: token2
Content-Type: application/json
Cookie: session=session1; session=session2
host: localhost:9093
user-agent: ballerina
connection: keep-alive
content-length: 35

Actually we should be overwriting the identical cookie headers. Seems to be an inconsistency when we are checking whether two cookies are identical or not.


Links to transactions on Explorer right in Wallet Activity

Story
As a USER who logged to wallet.near.org, I want able to click on transactions listed under Activity so I can see the transaction details on explorer.

Acceptance Criteria

[ ] Links added
[ ] Mobile ok
[ ] Tested

Unhappy Path
Have to go to View All

Assets

Mockup:

NOTES

Closing as issue is outdated


Cann't load HashHistory in rc-1

I just upgrade react-router 1.0.0-beta2 to react-router 1.0.0-rc-1
import HashHistory from 'react-router/lib/HashHistory';

This works well in 1.0.0-beta2, but in 1.0.0-rc-1, the loader throws:
Potentially unhandled rejection [3] Error loading<EMAIL_ADDRESS>at<EMAIL_ADDRESS>Error loading<EMAIL_ADDRESS>from "app" at http://localhost:9000/dist/app.js
Not Found<EMAIL_ADDRESS>(WARNING: non-Error used)
what's wrong with this.
Thanks.

I found<EMAIL_ADDRESS>is removed in this version.

Hey the History has been separated from React Router, please have a look in the docs


chore: sign apple binaries

What problem does this PR solve?:
Allows having to sign darwin images.
Which issue(s) does this PR fix?:

https://jira.d2iq.com/browse/D2IQ-88902

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

Closing the ticket as per discussion. The notarizing mac binary in github public repo is not secure enough as it may expose apple credentials. Once we finalize the approach, we can revisit this PR


Support ordering of listeners

Closes #2916
Fixes #2916  .
Did you remember to?

[X] Add test case(s)
[X] Update CHANGES.txt
[X] Auto applied styling via ./gradlew autostyleApply

We encourage pull requests that:

Add new features to TestNG (or)
Fix bugs in TestNG

If your pull request involves fixing SonarQube issues then we would suggest that you please discuss this with the
TestNG-dev before you spend time working on it.
Note: For more information on contribution guidelines  please make sure you refer our Contributing section for detailed set of steps.

Summary by CodeRabbit

New Features

Users can now define the execution order of TestNG listeners.
Added support for specifying a ListenerComparator for ordering listener execution.

Refactor

Restructured listener handling to utilize the new ListenerComparator.
Enhanced sorting mechanisms for proper listener execution order.

Tests

Added multiple test methods to validate listener ordering.

Chores

Ant support moved to a separate repository.

Bug Fixes

Implemented fixes to enhance TestNG functionality, stability, and performance.

@juherr - Thank you for fixing the comments as well. Can we go ahead and merge this PR now ?

@juherr - Thank you for fixing the comments as well. Can we go ahead and merge this PR now ?

Just need that one suite is working well

There are compilation errors @juherr . I am looking into it. I will get it sorted out and get this merged.


feat(jest-mock): add a method to mock a function only for certain arguments

Summary
The full motivation is described more fully in #13811, but the basic idea is that a common need is to mock a function only when passed certain arguments. All of the current workarounds are either messier, or require third-party packages that have to implement this in messier ways.
So in this commit I add a new method mockWhen(args) that says "mock this function only when passed the given arguments". The arguments can be expect matchers, which makes it quite flexible. The caller can then customize the returned mock with mockImplementation or any of its siblings as usual. This is all based on a similar function we've been using in tests at my company; but putting it in Jest offers a clearer API since it can be a method alongside all the other mock*.
For example (see the tests for more examples):
const fn = jest.fn(); // or any `MockInstance` from `jest.mock`, `spyOn`, etc.
fn.mockReturnValue('generic output');
fn.mockWhen('special input').mockReturnValue('special output');

expect(fn('arbitrary')).toBe('generic output');
expect(fn('special input')).toBe('special output');

Fixes #13811.
Test plan
Added unit tests.
TODOs
I didn't add the changelog or documentation yet; I wanted to get confirmation that this is something you're interested in first. I can also add type tests if that's helpful.

This would be great to add.
Could you look through the discussion in #6180? It can be fine to begin with partial support, of course. Perhaps it isn’t that complicated to cover all mock-return/resolve methods?

It can be fine to begin with partial support, of course. Perhaps it isn’t that complicated to cover all mock-return/resolve methods?

This API already covers all the methods. (It's equivalent to the one in this comment from jest-when, just a different name. The implementation is much simpler than jest-when since we don't need to reimplement anything.) The idea is that mockWhen creates and returns a new mock which is used only if the arguments match; you then customize that mock as usual. So in the example I did
fn.mockWhen('special input').mockReturnValue('special output');

but you can just as easily use mockImplementation, mockRejectedValue, etc.
The only thing I didn't add is a parallel mockWhenOnce which would be removed once you call the mock with those arguments. You can do fn.mockWhen(a).mockReturnValueOnce(b), but that has a bit different behavior -- when fn.mockWhen(a) is called it removes the return value but not the when. I think that should be possible to add but it would be a lot more invasive since we can't just push onto specificMockImpls in the same way -- we'd need our own mapping and logic in mockConstructor as well.
cc @timkindberg in case they have any thoughts on how this went in jest-when

Wonderfull! Thanks for clarification.
I think .whenCalledWith() reads better than .mockWhen(). The rest sounds good to me.
Perhaps for testing you could create new test file exclusively for this API? I though that this isn’t full implementation, just because tests were missing.

Finally got around to updating this. I added several more tests, and some type tests, and docs. Thanks for all the comments, I think I've addressed them all now.
I recommend reading the tests relating to mock*Once and/or withImplementation as they explain the arguably-surprising interaction between the two. My experience in our codebase is the issue doesn't come up a ton -- part of the value of whenCalledWith is you can avoid the (often more fragile) mock*Once entirely -- but let me know if you think it should be documented explicitly. We could also change the behavior (although it's unclear what behavior would be clearer on the whole), or remove mock*Once and withImplementation from the whenCalledWith output.

Hey folks, any plan to merge this?


Support default value of table column.

Search before asking

[X] I searched in the issues and found nothing similar.

Motivation
Currently, Column of pipeline do not provide a default value, which will lead to null column after adding a new column with default value, This is not as expected.
Solution
No response
Alternatives
No response
Anything else?
No response
Are you willing to submit a PR?

[ ] I'm willing to submit a PR!

In Test current the comment is all null, Can fix it together?

Sure, I will try to fix it.

closed and traced it in https://issues.apache.org/jira/browse/FLINK-34638.


Rounding issue with Python getTime function

Describe the Bug
The Robot.getTime() sometimes returns wrong values such as 0.8320000000000001
Steps to Reproduce

Open the projects/languages/python world.
Add print(self.getTime()) in the main loop of the controller.
Run the simulation

Expected behavior
Rounded values.
Screenshots
[slave] 0.256
[slave] 0.256
[slave] 0.28800000000000003
[slave] 0.28800000000000003
[slave] 0.28800000000000003
[slave] 0.32

System

Operating System: Linux Ubuntu 16.04
Python version: 3.7

That's actually not a problem of the Python wrapper, but just that the python 'print' prints with a resolution way bigger than the print in C/C++.


Can't get hardware acceleration on WebView

Tried with custom & demo project, the hardware acceleration is disabled on the WebView.

What is your indication that hardware acceleration is disabled, and what are you trying to enable?
I have mActivity.getWebView().isHardwareAccelerated() returning true.
https://github.com/gearvrf/GearVRf-Demos/blob/master/gvr-renderableview/gvrrenderableview/src/main/java/org/gearvrf/renderableview/MainScript.java

If I log it from the MainScript ctr it returns true indeed. Still getting transparent placeholder instead of WebGL content in the WebView. Any idea?

I've attempted to get WebGL to work on a WebView surface previously without luck, and I'm not sure possible with APIs exposed. But I will investigate further.

WebGL support in a WebView seems to have a lot caveats based on my quick search. @aagocs Does WebGL work in your WebView in non-VR apps? If it doesn't work there too then I am afraid this has nothing to do with GVRF.

@aagocs Do you still think there is an issue with GVRF? If not, can we close this issue? Thanks

It's not GVRf specific, but relates to broader usage of drawing WebGL in a locked canvas bound to Surface.

Planning to close tomorrow then. Thank you.


Add viewport size to GA4 page view

What
Adds browser viewport width and height to the GA4 page view.
Uses a fairly clean approach that appears to be reasonably backwards compatible for browsers.
In the tests I'm using the function I'm testing to get the viewport size, which seems a bit redundant but otherwise I think we'd need to be setting the viewport size in the test, which could get complicated and messy. Although now I write this that sounds useful. Perhaps something to consider while reviewing. EDIT: done some digging, this indeed looks difficult and messy. Maybe best avoided.
Why
Part of the GA4 migration.
Visual Changes
None.
Trello card: https://trello.com/c/9J21E5KI/698-viewport-size-custom-dimension

@AshGDS that's a good shout, but I'm still wondering whether it's worth doing - the test is that we intercept a request for a number, replace it with a known number, and check that we get that number. I'm not certain that's worth the extra lines of code, but it does feel like this should test something.


fix [gitlab] pipeline status service test

Fixes #4295

Warnings

:warning:
This PR modified service code for gitlab but not its test code. That's okay so long as it's refactoring existing code.

Messages

:book:
:sparkles: Thanks for your contribution to Shields, @calebcartwright!

  Generated by :no_entry_sign: dangerJS against 54d29ecd0ac77335b8463d9272e8dcfc42394664


doc: create pull_request_template

Pull Request Test Coverage Report for Build 2663

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 80.479%

Totals

Change from base Build 2655:
0.0%

Covered Lines:
2578

Relevant Lines:
3094

💛  - Coveralls


Torch 2.4 in docker images

Adds torch 2.4 docker images

@mvpatel2000 we do in 3 stages: (1) add the new images and bump the max pin, (2) add the new CI and make sure it passes, (3) bump the min pin and remove the older version