Various tables overflow their section container

Since release 20.02, the contents of many of the table-containing sections on the profile pages will display outside of their sections when viewed in a narrow window. Examples include the RNA Expression section on the association profile page (Expression Atlas), the Protein information section on the target profile page (Uniprot), and the Drugs section on all profile pages. I believe the issue to have been introduced by commit https://github.com/opentargets/webapp/commit/72f735a5c0815e5861cc5708381654a589203a55.

From the commit message of the commit I reference, I'm not sure why this behaviour was introduced. Is the reason for it still relevant, or would it make sense to revert the commit as a bugfix?

I see—doing that would cut of the large tooltip of the Gene prioritisation score column heading in the Genetic associations / Common diseases table. Might there be a way to make the overflow apply only to that tooltip?

Hi Fedde,
well spotted - you're correct in all your assumptions/findings.
The change was introduced to allow the (somewhat large) tooltip in the genetic evidence table.
I was aware at lower resolution the drugs table would present some rendering issues, but then again the summary charts would break anyway. I don't think at the time I picked up on the other tables.
It might be possible to revert the change and only fix the genetics evidence table to allow the tooltip - I'd imagine I'd tried that the time, but can have another look...

This article led me to try out what would happen if the popover had no positioned ancestors within the .scroll-table-panel .table-panel—which worked for me, and made the popover visible even without overflow: visible.
…unfortunately, the closest positioned ancestor is positioned by datatables.min.css:
table.dataTable thead .sorting,
table.dataTable thead .sorting_asc,
table.dataTable thead .sorting_desc,
table.dataTable thead .sorting_asc_disabled,
table.dataTable thead .sorting_desc_disabled {
	cursor: pointer;
	position: relative;
}

@fedde-s: we are planning for our 20.04 release, which should be available w/c Monday 27 April, and we can look at resolving this issue then. :-)

Been playing with the css without much luck. Tentatively trying positioning of the popover below the element as an alternative approach, but haven't fully checked it doesn't brake anything else.
As a quick and safe solution (since we're rewriting the app) we could shorten the text of that specific tooltip...

@LucaFumis, could we try shortening the tooltip to the following?
The gene prioritisation score is the output from our Locus2Gene pipeline. For more information on the score and our pipeline, click here.
Does that resolve the overflow issue?

Issue closed as work completed as part of 20.04 release process


feat: improve flagsmith type declaration

Hello and thanks for this great library!
Here is a suggestion to have better type checking with TS
This allows using flagsmith by passing all the possible names of flags (and traits) and be sure to have no typo afterwards

I love this, thanks so much @PrettyWood, I'll sort out the conflicts and get this in.


deps: updates wazero to v1.7.0

This will update wazero to v1.7.0. The v1.7.0. release marks a milestone in the wazero project, replacing our old compiler architecture with a new optimizing compiler backend.. It also introduces experimental support to the thread spec.
We will officially announce the final v1.7.0 release in just a few days, during Wasm I/O, after which we will undraft this PR and update it to the latest tag.
Let me know if you'd rather merge this PR before the official release. This draft PR is intended to let your CI checks run and verify everything is in order before our final release.
What type of PR is this?
/kind feature
Does this PR introduce a user-facing change?

NONE

What are the benchmark results of this change?
the optimizing compiler brings >40% run-time improvement at the cost of slightly slower compile-time; that is a one-time cost you only pay at boot time, and we can setup a persistent file cache if that's an issue
❯ benchstat before-run.txt after-run.txt
goos: darwin
goarch: arm64
pkg: sigs.k8s.io/kube-scheduler-wasm-extension/internal/e2e/scheduler
                                       │ before-run.txt │            after-run.txt            │
                                       │     sec/op     │    sec/op     vs base               │
Example_NodeNumber/Simple/Run-10           166.7µ ± 24%   101.8µ ± 24%  -38.93% (p=0.002 n=6)
Example_NodeNumber/Simple_Log/Run-10       184.9µ ±  9%   116.4µ ±  8%  -37.04% (p=0.002 n=6)
Example_NodeNumber/Advanced/Run-10         78.21µ ±  4%   39.62µ ±  1%  -49.34% (p=0.002 n=6)
Example_NodeNumber/Advanced_Log/Run-10     83.73µ ±  4%   46.14µ ±  1%  -44.89% (p=0.002 n=6)
geomean                                    119.2µ         68.22µ        -42.76%

compile-time:
goos: darwin
goarch: arm64
pkg: sigs.k8s.io/kube-scheduler-wasm-extension/internal/e2e/scheduler
                                       │ before.txt  │              after.txt               │
                                       │   sec/op    │    sec/op     vs base                │
Example_NodeNumber/Simple/New-10         67.39m ± 1%   612.24m ± 1%  +808.45% (p=0.002 n=6)
Example_NodeNumber/Simple_Log/New-10     67.55m ± 1%   604.96m ± 2%  +795.55% (p=0.002 n=6)
Example_NodeNumber/Advanced/New-10       80.16m ± 1%   673.40m ± 1%  +740.05% (p=0.002 n=6)
Example_NodeNumber/Advanced_Log/New-10   80.73m ± 1%   673.02m ± 1%  +733.64% (p=0.002 n=6)
geomean                                  73.67m         640.1m       +768.80%

The PR has been updated to 1.7.0 final


cleanup: improve perf populate_cmdline

What type of PR is this?
/kind cleanup
Any specific area of the project related to this PR?
/area libsinsp
Does this PR require a change in the driver versions?
No
What this PR does / why we need it:
improve perf populate_cmdline
Which issue(s) this PR fixes:
Special notes for your reviewer:
Does this PR introduce a user-facing change?:
NONE

[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: Andreagit97
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

OWNERS [Andreagit97]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

LGTM label has been added.  Git tree hash: 7665a1b01afcd287beeebe3a156f7199d61be827

[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: Andreagit97, FedeDP
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

OWNERS [Andreagit97,FedeDP]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment


Remove unnecessary android components from travis.yml file.

Dupe of #1162.

Whops. Didn't see that one.


replaced normal error type with ErrServiceClient in pkg/clients packages

Nice work @cloudxxx8, but sign is missing

@jduranf , recommitted with sign.  thanks for the reminder


[full-ci] Continuation of Dragonchaser/bump reva

Description
Follow up of https://github.com/owncloud/ocis/pull/8260
Related Issue

Fixes <issue_link>

Motivation and Context

How Has This Been Tested?

test environment:
test case 1:
test case 2:
...

Screenshots (if appropriate):
Types of changes

[ ] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)
[ ] Technical debt
[ ] Tests only (no source changes)

Checklist:

[ ] Code changes
[ ] Unit tests added
[ ] Acceptance tests added
[ ] Documentation ticket raised:

You need to delete these tests:

I created commit but it seams that was removed after force push

sorry @ScharfViktor 🙈 I was not expecting your commit.

I have updated the tests scenarios for file sharing


[BUG] Rule socket-communication-00000 not matching correctly

Is there an existing issue for this?

[X] I have searched the existing issues

Konveyor version
0.3.0-beta2
Priority
Critical
Current Behavior
The rule does not match and issues are not created. If the "PACKAGE" location is removed, the rule matches.
Related to https://github.com/konveyor/analyzer-lsp/issues/363
Expected Behavior
The rule should match normally
How Reproducible
Always (Default)
Steps To Reproduce
Check https://github.com/konveyor/analyzer-lsp/issues/363 for steps on how to reproduce
Environment
Check https://github.com/konveyor/analyzer-lsp/issues/363 for environment

Anything else?
No response

PACKAGE location does not seem to work as expected, probably all these locations should be switched with IMPORT... Created shim PR: https://github.com/konveyor/windup-shim/pull/103


Accessing logs for system tests run locally

If I run system tests locally, right now, the process of finding and accessing the logs is very complicated. I have to run kubectl get service -n <your namespace> to figure out the IP where kibana is running -- and kubectl doesn't work for me, it gives me an error: Unable to connect to the server: stopped after 10 redirects. If I want the logs to be preserved, and not deleted after a successful run, I have to manually change a test config file.
Is all of this documented somewhere? Can it be made easier?

Obsolete.


windows terminal no response when rdp dissconnect and reconnect

Windows Terminal version
1.1210983.0
Windows build number
10.0.22621.0
Other Software
No response
Steps to reproduce
run some long text out put program with remote desktop(I'm run visual studio layout here), and disconnect remote desktop, and reconnect. The windows terminal window will no response.
Expected Behavior
No response
Actual Behavior

This looks like #12607 to me. Do you happen to have an Nvidia graphics card/?

yes, I have an  Nvidia graphics card, I think it is same to https://github.com/microsoft/terminal/issues/12607

Cool, thanks for following up!
/dup  #12607


Regression between 0.5.0 and 0.6.x

From 0.1.3 through 0.5.0 the following test passes. From 0.6.0 it fails.
Apologies for the somewhat verbose scenario for the test, I wanted it to be as close to what we are using in our project as possible. We are using this extraction in a TCA .scope().ifLet(then:else:) so it's causing the then block to always be executed when it should be executing the else block.
Our workaround for now is to hand code computed properties to determine if we are in a specific enum case.
It's possible this was not exactly the intended way of using CasePaths, but it is nevertheless, a regression.
import CasePaths
import XCTest

precedencegroup ForwardComposition {
    associativity: left
    higherThan: AssignmentPrecedence
}

infix operator >>>: ForwardComposition

/// Forward composition eg:
/// Instead of doing `anArray.map(String.init).map(Int.init)`
/// you can do `anArray.map(String.init >>> Int.init)`
public func >>> <A, B, C>(_ a2b: @escaping (A) -> B, _ b2c: @escaping (B) -> C) -> (A) -> C {
    { a in b2c(a2b(a)) }
}

/// this is a cut down version of a real state in our application
public struct AccountCreationState: Equatable {
    public struct Basic: Equatable {
        public enum Stage: Equatable {
            case basicAccount
            case basicAccountComplete(name: String)
            case checkingEmailVerifiedLoader
            case confirmingEmail(email: String)
        }

        public var stage: Stage
    }

    public struct Real: Equatable {
        enum Stage {
            case emailConfirmed
            case profileIntro
            case profileLearnMoreAboutBonus
            case usResidentCheck
            case nonUSResident
            case realAccount
        }

        var stage: Stage
    }

    public enum Stage: Equatable {
        case initial
        case basic(Basic)
        case real(Real)
    }

    public var stage: Stage = .initial
    public var basic: Basic? {
        get {
            (/AccountCreationState.Stage.basic).extract(from: stage)
        }
        set {
            guard let value = newValue else { return }
            stage = .basic(value)
        }
    }

    var real: Real? {
        get {
            (/AccountCreationState.Stage.real).extract(from: stage)
        }
        set {
            guard let value = newValue else { return }
            stage = .real(value)
        }
    }
}

final class BugCheck: XCTestCase {
    func testNestedExtraction() {
        let state = AccountCreationState(stage: .basic(.init(stage: .basicAccount)))

        // the objective is to return non-nil if the state is the basic stage, with the `.checkingEmailVerifiedLoader`
        // sub-state, and otherwise, to return nil
        let extractor: (AccountCreationState) -> Void? = \.basic?.stage >>> (/AccountCreationState.Basic.Stage.checkingEmailVerifiedLoader)

        // in Releases 0.1.3 through 0.5.0 this returns `nil`
        // in Releases 0.6.x this returns `Optional(())`
        let result: Void? = extractor(state)

        XCTAssertNil(result)
    }
}

Thanks for opening this! We were missing one of the signatures needed to feed input to the right metadata extractor function, sorry! Can you check out #48 to confirm it fixes your problem?

Thanks for the quick turnaround! I can confirm that #48 does fix the problem 👍


Compatible with waterfall?

Can i setup this enviorment running under the proxy waterfall?

MMM, NO

It works with Waterfall proxy.
We're not updating Mammoth any more, I'd recommend checking out multipaper: https://github.com/PureGero/MultiPaper


Code for Mesos and Unit Test

Signed-off-by: Prabhakar Kudva<EMAIL_ADDRESS>

Current coverage is 46.08% (diff: 48.31%)

Merging #103 into master will increase coverage by 0.06%

@@             master       #103   diff @@
==========================================
  Files            21         22     +1
  Lines          3029       3118    +89
  Methods           0          0
  Messages          0          0
  Branches          0          0
==========================================
+ Hits           1394       1437    +43
- Misses         1635       1681    +46
  Partials          0          0

Powered by Codecov. Last update a2ce60e...f2fc16f

Just nits. Let's merge this afterwards. But just in case, there is still the pending task of increasing code coverage. mesos.py is at 60% only. Somebody will have to increase that.


Add support for fsnotify plugin

1. What does this change do, exactly?
This PR, in conjunction with https://github.com/awoodbeck/caddyfile-fsnotify, adds the ability to monitor the Caddyfile and its imported files for changes.  If changes are detected, Caddy is signaled to reload, realizing the changes to the Caddyfile and/or imports.
The changes to Caddy's code base were as unobtrusive as I could make them.  I took care not to break the API with the exception of changing []ServerBlock to ServerBlocks in order to facilitate the compilation of a unique file list.  The ServerBlocks object is passed along in a new EventHook named CaddyfileParsedEvent.  The caddyfile-fsnotify loader receives the ServerBlocks from the event and uses it to register those files with fsnotify.  The loader then watches for fsnotify events, sending a syscall.SIGUSR1 to Caddy as appropriate.
I have not exhaustively tested the caddyfile-fsnotify plugin, but it passed my initial QA.  There are edge cases with the loader I'd like to explore.  The Caddy-specific changes all include test coverage and the entire test suite passes.  Hopefully these changes can at least push this longstanding issue forward.
2. Please link to the relevant issues.
#1806
3. Which documentation changes (if any) need to be made because of this PR?
I'm not aware of any, though I admittedly spent more time looking at the code than the docs.
4. Checklist

[X] I have written tests and verified that they fail without my change
[X] I have squashed any insignificant commits
[X] This change has comments for package types, values, functions, and non-obvious lines of code
[X] I am willing to help maintain this change if there are issues with it later

Thanks for the PR, we will look at it as soon as we can.

I'm not sure why AppVeyor is using Go 1.11 despite merging in the changes from master that updated the yaml file to use Go 1.12. I won't have time to look at this any time soon. I'll leave the PR open in case someone wants to make AppVeyor happy and/or review the code.

We just have to wait for AppVeyor to update their image. :(

azure pipelines now :)

Caddy 2 will make this feature much easier to implement, since configuration is not forced through the Caddyfile anymore. If this PR is to be merged, I would like to devote efforts to making this work in Caddy 2 instead. Since it has a REST API and supports various config modules, it should be pretty easy to make this work in Caddy 2: just use fsnotify to watch the Caddyfile for changes, and if it changes, call Load(). Might be a grand total of 100 lines of code (including module registration)?
Would you be interested in that?

I'll familiarize myself with the v2 code base when I have an opportunity.


Is there any function equivalent to always (jQquery)?

I often make an ajax calls with some callbacks with error or not (jQuery ajax always() callback), specially if it's some recursive functionality, ex:
$.ajax({
    url: "example.php",
    type: 'get',
  })
  .done(function(resp) {
    alert( "success" );
  })
  .fail(function() {
    alert( "error" );
  })
  .always(function() {
    alert( "complete" ); // <-- always happens
  });

I was woundering if there is any axios equivalent? Instead of doing this mess:
axios.get( "example.php").then(response => {
   alert('success');
   alert('complete'); // <--- same thing here
 }).catch(function (error) {
   alert(error);
   alert('complete'); // <-- and here
 });

Try the following (note the second then):
axios.post('/api/foo', {
    foo: 'bar'
}).then((response) => {
    // success
}).catch((response) => {
    // error
}).then(() => {
    // always executed
})

Thank you, It worked. I think we can close now.

What if you want to handle always globally? it seems to me the only viable solution is wrapping Axios with the pattern above.

Thank you I was searching everywhere for this. Is it included in the docs? I couldn't find it.

2nd vote to get this in the docs

Try the following (note the second then):
axios.post('/api/foo', {
    foo: 'bar'
}).then((response) => {
    // success
}).catch((error) => {
    // error
}).then(() => {
    // always executed
})

It must be specified in the official documentation.

I'd like to point out a couple things:

The second .then() won't fire if the .catch() is not specified.
Ultimately I think a .always() would be a better solution, for syntactic sugar reasons.


Measurement problem ?

How can you get the following power value with the associated voltage and current?
[POWER] module power input: 3898.000mW
[CURRENT] module power input: 3860.000mA
[VOLTAGE] module power input: 3438.000mV
Since P = U x I, power should be 3.86 x 3.438 = 13,3 W
You also write:
[VOLTAGE] main carrier board 5V supply: 19112.000mV
[VOLTAGE] main carrier board 3.3V supply: 4976.000mV
Does that mean 5V = 19V or that there is overvoltage?
Does this have anything to do with the module version? From the Nvidia forums:

The feature to enable use of INA monitors was added starting with revision 300 of Jetson TX1. For example, SKU 699-82180-1000-300 (note the "-300") has the feature.

Seems like the the next two are wrongly reported as current and voltage, while in fact both of these are powers output in watts. See 91455d03ac198e80f8fe6ad5eff8f0deff7209f6.
Reading through sysf might not always work, although in regards to second question, it is in fact 19 V with wrong description. I'm going to move the sample application to other repository.


JSON ParameterEncoding

I'm passing in at a empty dictionary [String, String] like so,
let tempURLRequest = ParameterEncoding.JSON.encode(NSURLRequest(URL: URL), parameters: myDictionary).0
The request that gets generated is valid except the body is empty and there is no content-type which makes our spring/jhipster server throw exceptions "Required request body is missing". I'm certainly no expert on the JSON RFC but I'm pretty confident that the generally accepted definition says that at a minimum you need, {} or []. It looks like this is getting caught in ParameterEncoding.swift, public enum ParameterEncoding, line 85 which skips apply parameters and setting a content type in the headers.
NSJSONSerialization, which you use internally, would correctly parse this into_ {\n\n}_.
So my questions are,

Since I'm basically sending an empty POST request with no body or content-type should my API not be explicitly treating all requests to that endpoint as JSON content type and actually check whats in the header. AKA does best practice dictate that the API should be resilient towards the content-type in the request?
Is there a known / accepted work around to sending up an empty dictionary with a JSON content type.
Is this a flat out bug?

Although I feel like my first question is definitely part of the answer, using the encode method and explicitly telling it to use JSON should still produce a application/JSON content-type at a bare minimum.
Lastly big thanks for the excellent frameworks!

These are all very valid points @popwarfour. This particular behavior has a lot of history, but your description and reasoning here is spot on. We're discussing this right now and will get back to you shortly. Thank you for the detailed write up!

Thanks for the quick reply @cnoon, I'm very much looking forward to hearing about your discussion

Okay @popwarfour, thanks for your patience. We had a good discussion on Slack about this topic and have decided to revert the changes in 75c269ae. Instead, we are now properly handling the case of an empty query string in URL encoding. This has been fixed in 8b618c76 if you want to check it out. These changes will be available in the 3.2.0 which we are working on right now.
Thanks again for your excellent description here. We've been fighting this issue ever since that change was made. You managed to get to the root issue which made it much easier to work out the proper solution.
Cheers. 🍻


[Port] update Azure svg to current logo (#19034)

Fixes #19027
New:

Old:

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage increased (+0.002%) to 42.294%

Totals

Change from base Build<PHONE_NUMBER>:
0.002%

Covered Lines:
27600

Relevant Lines:
60996

💛  - Coveralls


chore: Vendor supervisor_stdout extension

Instead of downloading it from the github repo on every build (in base.dockerfile), we vendor the supervisor extension so we can look to fix the buffer overflow problem in supervisor logs.
After this is merged, after a day/two, we'll be removing git, python3-pip and the supervisor-stdout extension from base.dockerfile.

Summary by CodeRabbit

Refactor

Enhanced the event handling in system processes for improved logging and output management.

/ok-to-test<EMAIL_ADDRESS>


mshv: Upgrade vmm-sys-utils to the latest version

Summary of the PR
There is a recent CVE-2023-50711 assigned to this package and thus we should upgrade this package to the latest version.
Requirements
Before submitting your PR, please make sure you addressed the following
requirements:

[ ] All commits in this PR are signed (with git commit -s), and the commit
message has max 60 characters for the summary and max 75 characters for each
description line.
[ ] All added/changed functionality has a corresponding unit/integration
test.
[ ] All added/changed public-facing functionality has entries in the "Upcoming
Release" section of CHANGELOG.md (if no such section exists, please create one).
[ ] Any newly added unsafe code is properly documented.

Code looks fine but some old issues trigger the errors.

Pipeline issue is fixed under different PR: https://github.com/rust-vmm/mshv/pull/127


Generated images in uploaded dataset

Hello dear authors, this is an impressive job! Thanks for your contributions. But I'm a little confused about some generated results. For example, in your uploaded generated dataset, 'hazelnut_hole' 10.jpg-12.jpg, there is no hole in the generated images. Are these unusual cases? Because I noticed that most of the cases are good as showed in the bottom row.

Hi~ There are some failure cases in the generated data as you mentioned. You can eliminate them for better anomaly detection performance.


seq-cli: init at 2024.3.922

Added seq-cli package, a CLI for seq log servers https://datalust.co/seq
Used nix init for boilerplate and specified the projectFile, since the repo seems to contain some sample code under src/Roastery  which does not seem to be related to the CLI.
Also added version test.
Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)

[ ] sandbox = relaxed
[ ] sandbox = true

[x] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[x] Tested basic functionality of all binary files (usually in ./result/bin/)
24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[x] Fits CONTRIBUTING.md.

Add a :+1: reaction to pull requests you find important.

Hi @NixOS/dotnet , this is my first time packaging a dotnet project, could you take a look and provide some feedback?

Result of nixpkgs-review pr 348595 run on x86_64-linux 1

1 package built:

seq-cli

nixpkgs-review result
Generated using nixpkgs-review.
Command: nixpkgs-review pr 348595

x86_64-linux

:white_check_mark: 1 package built:

seq-cli


FIX: TRL trainer preprocessing step was running in one process

Description
We weren't passing dataset_num_proc to TRL training config, thus the initial data preprocessing steps in the TRL trainer was running in one process only.
Motivation and Context
Speeds up training start time by a lot depending on the number logical cores you have.
How has this been tested?
Tested it with the ORPO trainer in axolotl.
Screenshots (if appropriate)
Types of changes
Social Handles (Optional)
https://www.linkedin.com/in/ali-mosavian-7a27457/
https://github.com/ali-mosavian

I made a misstake, i sent it as trainer args in all cases, but it only applies CPO, KTO and ORPO trainer args. For the DPO it needs to be sent directly to the trainer. My latest commit in the PR fixes that.


Project 9_15

I encountered this error, any ideas on what could be causing it?

I am not very sure how to help without being able to see your code haha but I will share some of the potential pitfalls I had...maybe see if it helps?
As all the self-checkout counters seem to be working, there could be something wrong with the logic handled for human servers or events associated with the human servers.
Customer 22 is supposed to be served by server 2 at 3.406 timing but it did not happen. This may suggest that the event timing of the serve event for customer 22 is wrong. But given that for your code, before even customer 22 is served, customer 27 arrives and is served by server 2, it feels like the transition from wait event to serve event went wrong(?)...like somehow the nextEvent wasn't executed.
When I debugged my code, I realised that there were errors from earlier parts of the project not caught until the future test cases, so this might also be the case for you as well. Oh yes I also would like to mention that passing fewer test cases after rectifying code does not mean that the correction is in the wrong direction, it may mean that it was partially corrected (which was what happened to me).
Here are some things to check for the code for the entire project (I am sorry if there are some inaccuracies below but these were what I ensured):

[ ] service Timings for servers are only supplier.get() in serve event
[ ] rest Timings for human servers are only supplier.get() in done event
[ ] For the transition of wait event to Serve event for human servers, (I am guessing the logic will go like WaitEvent.next() gives Serve Event)...you might not want to directly create a serve event there and then but later on because...let's give an example: Customer 4 & Customer 5 are queuing at Server 2. Then, Server 2 just started to serve Customer 4. So I am guessing that typically the code will go like okay since server 2 is serving customer 4 now, which means we know when customer 4 will be done serving, we know when customer 5 will be served so we can transit Customer 5 Wait Event into serve event since we can predict when customer 5 is served. But issue here is that right after customer 4 is done being served, the server might go to rest which means that there must be a way to update customer 5 event to delay the serving or just do something about it
[ ] I made the mistake of decreasing the queue length whenever a customer is served at the server without checking whether or not the customer came from the queue or came from Arrive Event
[ ] Depending how one implements the Wait events... (because I have still wait events where if customer need to continue waiting then another wait event will be called) For self-check out counters, if a wait event need to be transited to another wait event, the event timing of the next wait event should be the SMALLEST of all other self-checkout counters end occupied timing. To explain further, let's say we have wait event for customer x at self checkout 1. Self checkout 1 is supposedly to finish serving another customer at 1.33 timing. Self-check out 2 is now full but will be available at 0.56 timing for example. If a next wait event is needed for customer x at self-checkout 1, the event time for the next Wait event for customer x at self-checkout 1 should be 0.56 (or any other "serving done" timings that is the SMALLEST of all other self-checkout counters) and not 1.33
[ ] Assuming that one updates the queue of any server in serve event, then ensure that if self-checkout counters are associated with the serve event, the queue is updated NOT at the self-checkout counter that is serving the customer. We need to find the self checkout counter that supports the queue and update the queue of that counter.

This is all I can remember. Not sure if I am comprehensible because my implementation may be different from yours but hope this gives some idea!

Just to add on to the above answer, someone created a really useful test case which helped me work out the possible issues and pass test case 15. You can consider using it, it is available at Issue #724

I created a rest event, which updates the rest timings of the server and its next available time
My wait event doesn't return a serve event, because I let the rest event check if there's any customers in the queue and create a serve event for them
Wait event:

RestEvent

Thanks everyone! Turns out that the issue is that my rest event's timestamp is at the start of the rest period, not at the end. So if a customer comes and waits in between those timings, the rest event wouldn't be able to detect the customer at the start of the rest period and create a serve event for them


Add launch configuration for VS Code

Pull Request
🤨 Rationale
VS Code can attach to an instance of Chrome, which allows you to set and debug breakpoints right in the editor. This is a better workflow then having to open the dev tools separately in Chrome.
👩💻 Implementation

Added a "task" that starts up Docker compose and npm run dev.
Added a launch configuration that runs the task and then attaches to a new Chrome window.

🧪 Testing
Tried a few scenarios:

Running the debugger and hitting a breakpoint
Launching when Docker engine isn't running - correctly throws an error
Running when the Docker compose is already started - restarts if needed

✅ Checklist

[x] This PR has a title that follows the commit message format.

Could we add a short blurb about this to the README?

Done

:tada: This PR is included in version 1.9.0 :tada:
The release is available on:

v1.9.0
GitHub release

Your semantic-release bot :package::rocket:


Better system integration on Ubuntu/Gnome

Basically:

Could better system integration also include notifications and computer specific shortcuts for play/pause ?
Notifications could be a whole new issue though ...

@vprigent what kind of info do you expect to see in notifications?

Which music in currently playing
Depending on the notification system, you can probably include prev/next buttons
I don't see that as a top priority. As a user, i would be more interested in interacting with the software without the need to switch to the program.

@vprigent so when a track changes, add a native notification ? Seems fair to me.

@KeitIG Yup ! I've seen that kind in Rhythmbox ( Linux app )
I need to test the app on Windows ! Currently linux fan ..

And sometimes Fn+F11 / Fn+F12 key combinations for prev & next song not working..
Thanks for program.
OS: ElementaryOS 0.4 ( Ubuntu 16.04 )

@marzochi Playback keyboard shortcuts "should" be supported, even if I could not test it personally (all laptops have different shortcuts for these). Can you send us the model of your laptop?

Thanks for reply.

description: Laptop
product: IdeaPad Z580 (System SKUNumber)
vendor: LENOVO
version: Lenovo Z580
elementary OS 0.4 Loki (64-bit)
Built on "Ubuntu 16.04.2 LTS"

So I war re-reading http://www.omgubuntu.co.uk/2017/09/will-you-miss-gnome-legacy-tray again to understand why Gnome wanted Trays to disappear.
I went back on NPM and found:

https://www.npmjs.com/package/mpris-service
https://www.npmjs.com/package/mpris

I think it may cover our needs

Apparently https://getharmony.xyz managed to do it, I will try to see how the did it.

node-dbus-next (pure JS) has MPRIS media player example that might be of use.

Working on it ;)

elementary os (Ubuntu 16.04) stack trace

><EMAIL_ADDRESS>museeks /home/pierre/dev/museeks
> electron .

(node:4575) UnhandledPromiseRejectionWarning: Error: unknown bus address
    at createStream (/home/pierre/dev/museeks/dist/main/webpack:/node_modules/dbus-next/index.js:22:1)
    at createConnection (/home/pierre/dev/museeks/dist/main/webpack:/node_modules/dbus-next/index.js:76:1)
    at Object../node_modules/dbus-next/index.js.module.exports.createClient (/home/pierre/dev/museeks/dist/main/webpack:/node_modules/dbus-next/index.js:136:1)
    at Object../node_modules/dbus-next/index.js.module.exports.sessionBus (/home/pierre/dev/museeks/dist/main/webpack:/node_modules/dbus-next/index.js:149:1)
    at Player../node_modules/mpris-service/dist/index.js.Player.init (/home/pierre/dev/museeks/dist/main/webpack:/node_modules/mpris-service/dist/index.js:105:1)
    at new Player (/home/pierre/dev/museeks/dist/main/webpack:/node_modules/mpris-service/dist/index.js:97:1)
    at Player (/home/pierre/dev/museeks/dist/main/webpack:/node_modules/mpris-service/dist/index.js:90:1)
    at new MprisModule (/home/pierre/dev/museeks/dist/main/webpack:/src/main/modules/mpris.ts:14:12)
    at /home/pierre/dev/museeks/dist/main/webpack:/src/main/main.ts:124:5
    at step (/home/pierre/dev/museeks/dist/main/bundle.js:62402:23)
(node:4575) UnhandledPromiseRejectionWarning: Unhandled promise rejection. This error originated either by throwing inside of an async function without a catch block, or by rejecting a promise which was not handled with .catch(). (rejection id: 1)
(node:4575) [DEP0018] DeprecationWarning: Unhandled promise rejections are deprecated. In the future, promise rejections that are not handled will terminate the Node.js process with a non-zero exit code.

@acrisci Any idea what could go wrong here? When editing the module directly and forcing it to be 'unix:path=/var/run/dbus/system_bus_socket', other errors are thrown.

You should be running this on the session bus which for me is at /run/user/$UID/bus.
The dbus library should be reading the DBUS_SESSION_BUS_ADDRESS environment variable for the path of the session bus.
$ echo $DBUS_SESSION_BUS_ADDRESS
unix:path=/run/user/1000/bus

I'm looking at the code for dbus-next and it might not actually be doing that. It might just be trying to read it from the x11 property, but I need to look into that.
If you're running this on Wayland, that's not tested and may introduce some bugs that need to be fixed.
Looking into all of this now.

I looked into dbus-next and confirmed it is reading DBUS_SESSION_BUS_ADDRESS for the session bus address. You will get this error only when that environment variable is not set.
None of the X11 code is working, so that's pretty much the only way to specify the bus address right now.
The session manager should be starting dbus (like with dbus-launch) to start the bus and setting those variables but yours might not be doing that. My stock 18.04 does set those variables, but I didn't test with elementary. This might be their bug, but getting the dbus-next X11 code working might fix this (unless they use Wayland and don't have X11 support compiled into their dbus libraries, which is a possibility).

thanks; I'll investigate on my side why they are not set!

@acrisci Mint 19.1 is based on Ubuntu 18.04. So if it works there, it should work in here too. I agree with you on fixing dbus-next X11 would solve the problem.

I did a detailed writeup on the issue on dbus-next here.

With<EMAIL_ADDRESS>the error is a bit more precise:
(node:5641) UnhandledPromiseRejectionWarning: Error: could not get DISPLAY environment variable to get dbus address
    at getDbusAddressFromFs (/home/pierre/Documents/museeks/dist/main/bundle.js:417:25058)
    at /home/pierre/Documents/museeks/dist/main/bundle.js:13:5792
    at createConnection (/home/pierre/Documents/museeks/dist/main/bundle.js:13:6896)
    at Object.module.exports.createClient (/home/pierre/Documents/museeks/dist/main/bundle.js:13:7771)
    at Object.module.exports.sessionBus (/home/pierre/Documents/museeks/dist/main/bundle.js:13:8096)
    at Player.init (/home/pierre/Documents/museeks/dist/main/bundle.js:130:43113)
    at new Player (/home/pierre/Documents/museeks/dist/main/bundle.js:130:42894)
    at Player (/home/pierre/Documents/museeks/dist/main/bundle.js:130:42743)
    at new MprisModule (/home/pierre/Documents/museeks/dist/main/bundle.js:417:132442)
    at /home/pierre/Documents/museeks/dist/main/bundle.js:417:139372
(node:5641) UnhandledPromiseRejectionWarning: Unhandled promise rejection. This error originated either by throwing inside of an async function without a catch block, or by rejecting a promise which was not handled with .catch(). (rejection id: 1)
(node:5641) [DEP0018] DeprecationWarning: Unhandled promise rejections are deprecated. In the future, promise rejections that are not handled will terminate the Node.js process with a non-zero exit code.

(Ubuntu 18.04.2)

I've run the mpris-service integration test suite on stock Ubuntu 18.04 and it works fine. Both the DISPLAY environment variable is set and the session manager sets DBUS_SESSION_BUS_ADDRESS.
Can you give me some more info on your setup so I can try to reproduce the issue?

Ah, interesting thing, I am running the Communitheme session. Let me try with the default one.

Mmh getting the same with the classic session, let me try with a fresh install.

Getting the same issue on a fresh install. I guess there is a problem with the environment variables then. Maybe Wepback is doing something nasty.
I am now trying to not bundle node-dbus-next so it is called from node_modules.

@acrisci How do you usually get the DISPLAY environment variable with Node.js?

ok, process.env is returning all the good results when asking the node prompt. I think Wepback or Electron is somewhat sanitizing these variables at build/runtime.
I need to find a way to let these variables be accessible at runtime

BAM! Now mpris-service needs an update, but I guess we're almost good to go.

The problem was indeed Webpack, and more specifically the DefinePlugin:
new webpack.DefinePlugin({
  'process.env': {
    NODE_ENV: '"development"',
  },
}),

Would replace all process.env by the provided object in the bundle.

Et voilà. A couple of bugfixes to do and I guess we're good.

Closed by #477 🎉
Base64 covers are not supported, but I guess it's fine for now.

Wow!! Excelent!! :+1:


GoPass 1.10.1 can't  reconfigure with gopass-bridge v0.8.0

Summary
After gopass upgrade to 1.10.1 (via homebrew) and gopass-jsonapi configure, chrome restart, can't get gopass-bridge working
Steps To Reproduce

install gopass before 1.10.1
install and configure gopass-bridge for that version
upgrade to gopass 1.10.1
run gopass-jsonapi configure
restart chrome

Expected behavior
gopass-bridge v0.8.0 should be able to communicate with gopass 1.10.1
Environment

OS: Mac OS Catalina 10.15.7
OS version: Darwin ook-book.local 19.6.0 Darwin Kernel Version 19.6.0: Mon Aug 31 22:12:52 PDT 2020; root:xnu-6153.141.2~1/RELEASE_X86_64 x86_64
gopass Version: 1.10.1 (gopass-bridge chrome v0.8.0)
Installation method: homebrew (gopass-bridge via chrome store)

Additional context
Traces from my re configuration:
☁  ~  gopass-jsonapi --version
gopass-jsonapi version 1.10.1
☁  ~  gopass-jsonapi configure
For which browser do you want to install gopass native messaging? [brave,chrome,chromium,firefox,iridium,slimjet,vivaldi] [chrome]:
Install for all users? (might require sudo gopass) [y/N/q]:
In which path should gopass_wrapper.sh be installed? [/Users/thomas/.config/gopass]:
Native Messaging Setup Preview:
Wrapper Script (/Users/thomas/.config/gopass/gopass_wrapper.sh):
#!/bin/sh

if [ -f ~/.gpg-agent-info ] && [ -n "$(pgrep gpg-agent)" ]; then
	source ~/.gpg-agent-info
	export GPG_AGENT_INFO
else
	eval $(gpg-agent --daemon)
fi

export PATH="$PATH:/usr/local/bin" # required on MacOS/brew
export GPG_TTY="$(tty)"

/usr/local/bin/gopass-jsonapi listen

exit $?

Manifest File (/Users/thomas/Library/Application Support/Google/Chrome/NativeMessagingHosts/com.justwatch.gopass.json):
{
    "name": "com.justwatch.gopass",
    "description": "Gopass wrapper to search and return passwords",
    "path": "/Users/thomas/.config/gopass/gopass_wrapper.sh",
    "type": "stdio",
    "allowed_origins": [
        "chrome-extension://kkhfnlkhiapbiehimabddjbimfaijdhk/"
    ]
}

Install manifest and wrapper? [Y/n/q]:
☁  ~  gopass --version
gopass 1.10.1 go1.15 darwin amd64
☁  ~

And still:

@martinhoefling  @Pharb Any ideas? I'm not using neither jsonapi nor gopass-bridge on my side, so I cannot help and it seems we have at least 3 users impacted.

@martinhoefling  @Pharb Any ideas? I'm not using neither jsonapi nor gopass-bridge on my side, so I cannot help and it seems we have at least 3 users impacted.


enhancement: background-image or other objects in the html template as globally addressed safenet object

sorry posted the issue at the wrong sub-project:
https://github.com/maidsafe/safe_launcher/issues/101

We will get this updated in the next version of the demo app.
Thanks

Updated in the v0.3.1


Unauthorized error while sending message back to FB Messenger

I have a bot I've connected to FB Messenger. It was working for a while. I've since upgraded to BotBuilder 3.3.1 and re-deployed the application. I can use the bot with the emulator no problem. On the bot page, the Test Connection to Bot button works fine. Says bot is authorized. My bot receives messages from FB Messenger without a problem. But when i send the message back , I get this error:
Warning: 0 : Service url facebook.botframework.com is not trusted and JwtToken cannot be sent to it.
Application Insights Telemetry: {"name":"Microsoft.ApplicationInsights.bc7d40e7b50c401891fddb26bb3a0c41.RemoteDependency","time":"2016-11-11T23:38:42.3591555Z","iKey":"bc7d40e7-b50c-4018-91fd-db26bb3a0c41","tags":{"ai.operation.id":"2C6I4qV40f8=","ai.operation.name":"POST Messages/Post","ai.location.ip":"<IP_ADDRESS>","ai.user.userAgent":"BF-Facebook (Microsoft-BotFramework/3.1 +https://botframework.com/ua)","ai.device.roleInstance":"USYNCNB39355","ai.internal.sdkVersion":"rddf: <IP_ADDRESS>3"},"data":{"baseType":"RemoteDependencyData","baseData":{"ver":2,"name":"https://facebook.botframework.com/v3/conversations/1199955020074474-1757015214565977/activities/mid.1478907516997%3A7cc61b7f86","id":"Kx/dKMzCYg4=","value":445.2651,"resultCode":"403","dependencyKind":1,"success":false}}}
System.UnauthorizedAccessException: Authorization for Microsoft App ID 6f82b1da-7eb2-4870-b78f-5401d97dfcd3 failed with status code Forbidden

Any thoughts as to what may be occuring?

I can confirm this is only an issue with BotBuilder 3.3.1. I downgraded to 3.3.0 and everything works fine.

Adding
 MicrosoftAppCredentials.TrustServiceUrl(@"https://facebook.botframework.com", DateTime.MaxValue);
upon startup solved it for me. Can anybody else try it?

@Stevenic @maxpert is this resolved in 3.5?

Still a problem for me in Bot Builder v3.3.3.
I get an error right after the abovementioned warning:
"UnauthorizedAccessException, Message: Authorization for Microsoft App ID 324210c5-b390-49c2-8db6-3117449af666 failed with status code Forbidden". Might be related.

@vossccp, your suggestion worked for me, thanks.

@vossccp's suggestion worked for me as well as a workaround.

This is an issue in the C# SDK not the Node SDK.

Similar to #1729. This is not an issue with the SDK. By desing, MicrosoftAppCredentials only sets the JwtToken of the bot for the post requests to trusted host names. For regular incoming messages to bot, BotAuthenticator adds the service urls to the trusted set if the incoming request to bot is authenticated.
For proactive messages or for the calls to connector that happens in a process that haven't seen the incoming request, your implementation needs to add the service url to the set of trusted host names using the TrustServiceUrl.
The ResumeAsync(...) implementation shows how bot builder trusts the service url if resumption cookie has the IsTrustedServiceUrl flag set to true: https://github.com/Microsoft/BotBuilder/blob/master/CSharp/Library/Dialogs/Conversation.cs#L97

@vossccp, @srozga  where did you insert that code ?

just run into this issue
Guys, you definitely have to put info about the problem here https://docs.microsoft.com/en-us/bot-framework/troubleshoot-authentication-problems
@lonche you can put straight to your Startup.Configuration method

When my HttpClient make the request.
HttpResponseMessage response = await client.GetAsync(uri);
Show me this message in output window:
iisexpress.exe Warning: 0 : Service url localhost:19564 is not trusted and JwtToken cannot be sent to it.

@rbolanoherrrera This issue is closed.  Please create a new issue, or ask your question on Stack Overflow.


unable to launch Fluxgym

Hello Experts,
i have install fresh copy of fluxgym in my drive (E:\My AI\FluxGym\fluxgym) and i have install it successfully with all the dependencies etc with any error also download all the models, after that when i try to launch Fluxgym with this command (python app.py) with the venv activated. after this command i got this error.

(env) E:\My AI\FluxGym\fluxgym>python app.py
Traceback (most recent call last):
File "E:\My AI\FluxGym\fluxgym\app.py", line 17, in
import train_network
ModuleNotFoundError: No module named 'train_network'

Hi, I've just found this problem and the solution.
In app.py move the lines:
os.environ["HF_HUB_ENABLE_HF_TRANSFER"] = "1"
os.environ['GRADIO_ANALYTICS_ENABLED'] = '0'
sys.path.insert(0, os.getcwd())
sys.path.append(os.path.join(os.path.dirname(__file__), 'sd-scripts'))

To right after import sys and import os so it looks something like this:
import os
import sys
os.environ["HF_HUB_ENABLE_HF_TRANSFER"] = "1"
os.environ['GRADIO_ANALYTICS_ENABLED'] = '0'
sys.path.insert(0, os.getcwd())
sys.path.append(os.path.join(os.path.dirname(__file__), 'sd-scripts'))
import subprocess
import gradio as gr
...

For some reason in python 3.10 app.py works but in python 3.12 it doesn't.

First of all thank you so much for your reply.
i have replaced your code in app.py file, So now the file looks like below

import os
import sys
import subprocess
import gradio as gr
from PIL import Image
import torch
import uuid
import shutil
import json
import yaml
from slugify import slugify
from transformers import AutoProcessor, AutoModelForCausalLM
from gradio_logsview import LogsView, LogsViewRunner
from huggingface_hub import hf_hub_download, HfApi
from library import flux_train_utils, huggingface_util
from argparse import Namespace
import train_network
import toml
import re
import os
import sys
os.environ["HF_HUB_ENABLE_HF_TRANSFER"] = "1"
os.environ['GRADIO_ANALYTICS_ENABLED'] = '0'
sys.path.insert(0, os.getcwd())
sys.path.append(os.path.join(os.path.dirname(file), 'sd-scripts'))
import subprocess
import gradio as gr

but the problem still not fix.

(env) E:\fluxgym>python app.py
Traceback (most recent call last):
File "E:\fluxgym\app.py", line 17, in
import train_network
ModuleNotFoundError: No module named 'train_network'

and also my python version is

(env) E:\fluxgym>python --version
Python 3.11.9

I am afraid it wasn't changed the way I suggested. In any case a fix was merged in the PR #102 so just pulling the code now should fix the problem.
THank you for the python version. Then it looks like the problem appears for python > 3.10

你好专家，我的出现了这个启动错误，一直无法解决，请求帮助
I:\fluxgym>python app.py
Traceback (most recent call last):
File "I:\fluxgym\app.py", line 17, in
from gradio_logsview import LogsView, LogsViewRunner
ModuleNotFoundError: No module named 'gradio_logsview'

你好专家，我的出现了这个启动错误，一直无法解决，请求帮助
I:\fluxgym>python app.py Traceback (most recent call last): File "I:\fluxgym\app.py", line 17, in from gradio_logsview import LogsView, LogsViewRunner ModuleNotFoundError: No module named 'gradio_logsview'

make sure python env is activated before running the app.py

你好专家，我的出现了这个启动错误，一直无法解决，请求帮助
I:\fluxgym>python app.py Traceback (most recent call last): File "I:\fluxgym\app.py", line 17, in from gradio_logsview import LogsView, LogsViewRunner ModuleNotFoundError: No module named 'gradio_logsview'

It is possible, that you forgot the following step in the installation (happened to me):
cd .. pip install -r requirements.txt

Hello, I cant seem to start Fluxgym, I followed all the steps.
I get this error:
(env) C:\fluxgym>python app.py
Traceback (most recent call last):
File "C:\fluxgym\app.py", line 8, in
import gradio as gr
ModuleNotFoundError: No module named 'gradio'
(env) C:\fluxgym>
Any help would be appreciated.

Hello, I cant seem to start Fluxgym, I followed all the steps. (On Windows)
I get this error:
(env) C:\fluxgym>python app.py Traceback (most recent call last): File "C:\fluxgym\app.py", line 8, in import gradio as gr ModuleNotFoundError: No module named 'gradio'
(env) C:\fluxgym>
Any help would be appreciated.

maybe doing this might help
https://github.com/cocktailpeanut/fluxgym/issues/274


Bugfix/776 contingent event. Fixes #776.

This PR removed dateTime restrictions from gist:ContingentEvent and adds a skos:example.
See the issue here: https://github.com/semanticarts/gist/issues/776

@coltonglasgow I just saw Dave's comment: I think the canonical example and what ought to be in the definition is the event that triggers some indemnity. The death benefit payout on a life insurance policy is the death of a very specific person. Fire insurance is contingent on a particular building burning down.
Please incorporate this into the definition.


Clean up entries in docsettings.yml

We expect the readme files in each of the packages to follow a particular template.
The docsettings.yml file is where we have added exceptions for this rule.
The omitted_paths is for those readmes that intentionally do not follow this rule
The known_content_issues is for those readmes that we believe should follow the rule and so there is a tracking issue to update it
This PR cleans up this file as follows:

Add Track 1 packages into the omitted path list. Since these are auto generated, they will not be following the rule
Use glob patterns when possible

/azp run js - core - ci


Milestone 2: Add, Remove, Edit a todo list

Milestone 1: Todo List Structure
I have successfully finished developing a feature to edit, add and remove a todo list, adhering to the specified project requirements.
I have added the following features:

[x] Implement a function for adding a new task (add a new element to the array).
[x] Implement a function for deleting a task (remove an element from the array).
[x] Implement a function for editing task descriptions.

I have ensured that:

Remove all hardcoded items from the tasks array.
Create a new JavaScript file for the new functionality.
By default new tasks should have the property completed set to false and the property index set to the value of the new array
length (i.e. if you're adding a 5th task to the list, the index of that task should equal to 5).
Deleting a task should update all remaining items' indexes, so they represent the current list order and are unique(i.e. if you're
deleting the first task index 1 from the list, the index of the next task(2) should be set to 1)..
All changes to the To Do List should be saved in local storage.
There are no linter errors in the project.
Used Correct git-flow.
Documented my work in a professional manner according to Professional code documenting requirement
Included a descriptive Readme file.
Used descriptive commit messages
Followed the recommended HTML, CSS, and Js best practices

Best regards
Asum Victor

Hi @AsumVictor ,
Good job so far! There are some issues that you still need to work on to go to the next project but you are almost there!

Highlights
✔ Descriptive pull request. ✔ Follow the correct GitHub flow. ✔ Application is working fine.
Required Changes ♻
Check the comments under the review. please fix the broken mit license link in your readme file it highly unprofessional to have broken links in your code base 👍🏾
Optional suggestions
Every comment with the [OPTIONAL] prefix is not crucial enough to stop the approval of this PR. However, I strongly recommend you to take them into account as they can make your code better.
Cheers and Happy coding!👏👏👏
Feel free to leave any questions or comments in the PR thread if something is not 100% clear. Please, remember to tag me in your question so I can receive the notification.
Please, do not open a new Pull Request for re-reviews. You should use the same Pull Request submitted for the first review, either valid or invalid unless it is requested otherwise.
As described in the Code reviews limits policy you have a limited number of reviews per project (check the exact number in your Dashboard). If you think that the code review was not fair, you can request a second opinion using this form.

Thank you very much! I have fix it.


Service domain support and logic/syntax details

Can details be added to service domains similar to the file path section to detail what's supported regarding wildcards, subdomains, directories and combinations thereof? E.g. *.gov, drive.google.com, contosos.sharepoint.com/sites/allowed, *.sharepoint.com, contoso.sharepoint.com/sites/hr/*

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 76da4eda-4ccf-ff34-6a48-d9c5553c2ed6
Version Independent ID: 7e887aff-1b85-1651-2bff-63425c54ae63
Content: Using  Endpoint data loss prevention (preview) - Microsoft 365 Compliance
Content Source: microsoft-365/compliance/endpoint-dlp-using.md
Service: o365-seccomp
GitHub Login: @chrfox
Microsoft Alias: chrfox

HI @ssccaavvookk  -
Thanks for your comment, service domains do not accept wildcards.


Support multiple targets under test

On more than one occasion, I or others have needed to have multiple targets under test. This is usually done to verify that a particular configuration change doesn't change behavior from a base line, or to verify that the rule-under-test ignores some configuration change. By having a "baseline" with fixed config settings, it makes it possible to reliably check the expected vs actual state.
This is somewhat possible today, but is rather verbose. If config settings are involved, it's even more verbose, and if different config settings are involved for the targets under test, then even more.
Proposed API:

Add a targets arg. It is mutually exclusive with the target arg.
It is either a list of target names or a dict of name -> <target under test kwargs>.
When list is provided, each target under test is given the same settings as if a single target was provided (e.g. the same aspect, config settings, expect failure, etc settings)
When a dict is provided, each target under test is given the settings as specified by their associated key. This allows each target under test to have custom config settings, aspects, etc.

Hm, well, I'm not sure I 100% like this proposed api, but it works. I'm just not a fan of currying through arbitrary lists of kwargs through things.

cc @murali42

After running into this situation again, I think the originally proposed API is a bit too niche (it only allows controlling the config settings). With the addition of the analysis_test.attr_values arg, it's possible to make something much more powerful with some minor tweaks.
Revised proposal
In the example below, we have two targets under test, subject1 and subject2. Each has different config settings and aspects applied. This is done using a dict with some special keys.
The dicts tell how to build the attribute. Within the analysis_test function, we mixin the extra aspects and cfg transition into those values to construct the attr.<whatever> call. This is a small extension of how the attrs arg is processed, so relatively non-invasive.
analysis_test(
  attr_values = {"subject1": ":s1", "subject2": ":s2"}
  attrs = {
    "subject1": {"@attr": attr.label, "@config_settings": ..., "aspects": ...}
    "subject1": {"@attr": attr.label, "@config_settings": ..., "aspects": ...}
  }
)

I'm not a fan of magic keys and raw dicts, but the two things we require are (1) the attr.XXX function to call to create the attribute, and (2) a mutable dict of kwargs to pass to that call (it has to be mutable so we can append to the aspects key and set the cfg key).
I suppose a builder-esq type of API would be possible, analysis_test_builder().add_attr(...), but ehhh, that seems like a lot of work, and seems like a much more complicated API to understand (the apis for Subjects are harder to figure out because of their fluency; adding that barrier just to define a test seems like too much).
Discarded ideas

Add a targets_attrs arg to carry the raw dicts. This better separates the attribute definitions for targets under tests, but is a bit awkward to split the singular set of attributes into two args.
Add a targets arg, which is a dict of attribute name -> spec, where "spec" tells the target to use, the config settings to apply, and the attribute definition. This just seems like a very complex object when written out, and reuse of the pieces seems a bit awkward.
Treat analysis_test **kwargs as attribute names that are targets under test. This is basically just moving the analysis_test(attr_values = {k:v}) part "up" to be analysis_test(k=v). However, this idea was originally considered when attr_values was introduced; it was discarded because using **kwargs for that makes it difficult to grow the analysis_test function signature safely.


rename LIKELY/UNLIKELY to avoid definition conflict (#135)

Why
Closes #135

What is changing
Example

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

BTW, you need to sign the CLA so that we could merge your PR.


Can linux run 2024 Solidworks

I have a Surface Laptop Go 3. I installed everything that was needed, but in the end, it shows a black screen (see the attachment).

P.S. I bought a version of SolidWorks when I had Windows.

I'm having the same issue. Blank window in front of the installer window. Nothing else I can do at this point.

The best thing to do is install windows and linux on same device just switch when needed for solidoworks. You cant install it on linux myb in future

Yeah that's what I'm currently doing but it's a pain to reboot just to grab a quick dimension or a screenshot or something.


Bug:  QUARANTINE doesnt get added to file

When a file fails data and structural integrity checks it DOES get moved over to the /quarintine dir but this string:
QuarantineStr: string = "\n# [QUARANTINED] [QUARANTINED] [QUARANTINED] [QUARANTINED]\n"
is NOT being appended to the bottom of the file as It should be. A simple fix

I want to work on this, can you please assign it to me

@KhushiSharma0313 Create your branch off the development branch.

@KhushiSharma0313 Any progress with this issue? If not I can take care of it

Deprecating this feature. Since all files will end up being compress & encrypted anyway I see no point in worrying about this for the future


Feature/state table horizontal scroll

Thanks for this PR. 🚀
The changes currently look a bit funky and the whole states table is scrolled instead of just the district table columns.
I was playing around and was able to stitch something like this https://codesandbox.io/s/ecstatic-carson-mxx9s?file=/index.html
Let me know if this helps!

I checked this approach before as well but didn't implement in our code. I will implement it in our project and let's see how it behaves in our project.


Update request: vscode 1.90.1 → 1.90.2

Package name: vscode
Latest released version: 1.90.2

Current version on the unstable channel: 1.90.1
Current version on the stable/release channel: 1.89.1

[x] Checked the nixpkgs pull requests

Notify maintainers
@eadwu @Synthetica9 @bobby285271 @Enzime

Note for maintainers: Please tag this issue in your PR.

Add a :+1: reaction to issues you find important.

https://github.com/NixOS/nixpkgs/pull/321567


add the possibility of slide vertically

add the possibility of slide vertically

+1

@baiyaaaaa  In a page , I have some content overflow the visiable section , but when I touch move , it jump to the next page so I can not read the whole content , how to resolve it ? Do you have the same question?


四日 duplicate

四日 was in words.txt but should have been eliminated as a duplicate

Mismatch due to pasting from spreadsheet.


remove blur shaders

https://github.com/slashiee/cemu_graphic_packs/issues/38#issuecomment-336607945
They probably drop performance:
http://rastergrid.com/blog/2010/09/efficient-gaussian-blur-with-linear-sampling/#comment-453
Might also because more taps at larger res is bad, the largest seen in game is 7(splat)/5(botw), whereas it reaches 19/25 at 5k. And the one pass blur is even more inefficient.

wait... like, all of them?

Probably should make them optional then, some people can push their stuff more couldn't they?

A lot of work was done for implementing these. Especially finding them took considerable effort

But yes, I see what you mean, the performance impact is surely a sensible issue for regular users. I agree to remove anything blur related, or, at least, make a separate BlurCorrection pack, with a side note that it might impact performance considerably. and while at it, I think you should add these shaders in the bucket as well:
f0a615c0f6a37661_0000000000000079_ps
45d85f1d25e7d0de_0000000000000079_ps
They seem copy pasted, the reflection on is for sure

All in all, if the camera dof effect look ok-ish, and it doesn't impact performance, I think people can live with this:

Okay, I've talked to Kiri and the plan is that we're removing all the blur shaders for now to create a new branch with 'fixed' shaders that are less intensive (maybe something with the vertex shaders). It probably won't look as good but would remain radius and remove the grid look.

As of the camera, https://github.com/slashiee/cemu_graphic_packs/issues/38#issuecomment-336607945 indicates that it also is a fps hog so probably should stay removed.


MM-17000: redirect from /jira install, no need to display the link

Ticket: https://mattermost.atlassian.net/browse/MM-17000
cc @jasonblais

Will the user get a confirmation message in the message window that they've failed/succeeded to authenticate with jira?

Just so I'm clear....the URL to nstall is no longer displayed and when the user is redirected to the jira portal to install the plugin?  I'm trying to visualize the flow for the user.
Is a message like "Successfully installed JIRA cloud Server 8.1.0 from your Mattermost 5.12 server" displayed afterwards to the user?

@aaronrothschild This is for /jira connect --> so the user flow after these changes would be

user posts /jira connect (or clicks "Connect to Jira" in the post menu when hovering over a message)
browser tab opens with Jira page, where user accepts the mapping between Jira and Mattermost users

There is no success/failure message afterward about a successful connection..there is a separate issue to add such a message: https://github.com/mattermost/mattermost-plugin-jira/issues/149


⚠ Bofrost.lu has degraded performance

In 8610f36, Bofrost.lu (https://www.bofrost.lu) experienced degraded performance:

HTTP code: 200
Response time: 1701 ms

Resolved: Bofrost.lu performance has improved in d19121d after 7 minutes.


Upgrade version to v1.0.0-rc.2

Upgrading the notation version to v.1.0.0-rc.2

Codecov Report

Merging #558 (a84c024) into main (d62fd58) will not change coverage.
The diff coverage is n/a.

:mega: This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more
@@           Coverage Diff           @@
##             main     #558   +/-   ##
=======================================
  Coverage   34.36%   34.36%
=======================================
  Files          32       32
  Lines        1848     1848
=======================================
  Hits          635      635
  Misses       1192     1192
  Partials       21       21

Impacted Files
Coverage Δ

internal/version/version.go
100.00% <ø> (ø)

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more

LGTM


Resolve "Need to fix duplication of codes in some LOINC Answer Lists."

See #1482

@jamesagnew, please review. Thanks!


A parsing error occurs when entering a Unicode character that exceeds two bytes (>=U+10000) in the input area

Windows Terminal version
1.18.3181.0
Windows build number
10.0.19045.3693
Other Software
No response
Steps to reproduce
Enter a character >U+10000 such as 🌯  (U+1F32F) or 𪚥 (U+2A6A5).
Expected Behavior

The character should be displayed correctly as in the preview image
Actual Behavior
PowerShell:

Command Prompt:

Additionally, in the command prompt, if you insert or delete characters in front of this character, this character will be displayed correctly, but this does not apply to PowerShell.

This may be related to https://github.com/microsoft/terminal/issues/6555 but I'm not really sure.

I think this is a duplicate of https://github.com/microsoft/terminal/issues/1503 and this should have been fixed.


Slow loading of large folders

Is your feature request related to a problem?
Yes, The loading time of folders containing lots of files is considerable.
Describe the solution
My Desktop contains lots of files and when I open my desktop folder using this application, it takes about 10 seconds to show all the files.
Describe alternatives you've considered
Please improve the performance as it may solve the problem.
Additional comment
The latest version of the app is installed.

@Shaheer-Mirza What version of Files & Windows do you have?

Windows : 20H2

Files: <IP_ADDRESS>

@Shaheer-Mirza Is this still an issue if your turn off the option to cache items?

I am observing the changes for the Cache settings.
One more issue. When I open the new Tab of the application, sometimes I do not see the storage bar of the drives. The screenshots are attatched.

@Shaheer-Mirza This is a known issue. It will hopefully be resolve in v2.

Both cache on or off takes about the same time.

Please try to add an online cloud manager in the application.
Helpful screenshots are attatched.


Active virtualenv name is not correct for pyenv

When I activate multiple versions by pyenv global devtools2 devtools3 3.2 2.7, the promt segment shows that I've activated the first (devtools).
I think it should not show any thing here because they are global environment.
The issue can be fixed by using PYENV_VERSION environment variable. Check the document here.
And I'm willing to fix that in a pull request.

Fixed by merge of #680


Can't use .prune/.clear command

Each time I use it it says this... help?

Strange...it does this in every channel? Also, what version are you running? (type .stats to check)

Also your bot has permission to delete/manage messages?

@Kwoth Close? Person hasn't responded in 2 weeks.


should support and add docs: "How to Setup for Multiple Subdomains Application (Dev Box)"

ref: http://awesomeprogrammer.com/blog/2014/12/07/vagrant-setup-for-multiple-subdomains-application/

by update aliases for vagrant-hostsupdater plugin to add the domain to host /etc/hosts file.
Then within the VM, use a reverse proxy (nginx) to configure.
Using with docker, we should use https://github.com/jwilder/nginx-proxy (currently there are some problems with docker-compose v2 format, ssl issue). I managed to use sub domain for (blog-d.teracy.dev and blog.teracy.dev as dev mod and prod mode on local dev). This can applied to any sub domain that we want.

already done with http://dev.teracy.org/docs/nodejs_dev_guide.html


Advanced Routing Constraints and Sorcery

I need to build a custom Routing Constraint that returns true, or "matches," when there is a logged in user.
An example use case is having a single route, for example root, that gets routed to different controller/action depending on if the user is logged in. If they are not, show a "Welcome" page. If they are logged in, show their "Dashboard." (GitHub, for example, works this way.)
# /config/routes.rb

MyApp::Application.routes.draw do

  # other routes …

  root :to => 'users#dashbard', :constraints => AuthenticatedConstraint.new
  root :to => 'pages#welcome'

end

# /lib/authenticated_constraint.rb

class AuthenticatedConstraint

  def matches?(request)
    # Some call off to a Sorcery API?

    # In Warden-based systems (like Devise), I'd do:
    # request.env["warden"].authenticate?
  end
end

Perhaps Sorcery could work with, or on top of, Warden to provide a common API for all Rack-based apps that might be running in the process. I believe this will become all the more common now that mounting a Sinatra app as an engine is so trivial.
I'm also up for any other thoughts, suggestions, critiques?

@scottwater has proposed a quick and dirty starting point: https://gist.github.com/1424816

Would love to see this working.


Status bar color and image orientation issues

First of all, thanks for your work for this library.
When I tried to use this library in SwiftUI in my App, I found two issues:

Status Bar Color

When exit from the photo browser, the status bar didn't recover. The photo browser changed the status bar color to white, but when exit, it didn't change it back to black.

Image Orientation

Image captured from camera is displayed and rotated with 90 degrees.
I think these fixing theses issues will make the library better. Thanks!

Hello @Shouheng88, thanks for the raise out of the issues.
As far as I know, this library is mainly developed using UIKit, so suppose you will need UIViewRepresentable to bridge to SwiftUI.
Therefore, there will be some unexpected behaviours. I can try to investigate to see if there is any workaround on this.
For Image orientation, would you please provide some reference e.g. reproducable project that we can investigate? Thanks.
As always, feel free to submit any pull requests if you are willing to do so!

Hi @tommyming, thanks for your reply.
I fixed the status bar color issue by chaning the background color. Now it works well.
For the image orientation issue. As you can see in the below two images. The first one is the image diplayed by Kingfisher, a image library of SwiftUI. And the second one is the image displayed in SKPhotoBrowser.

I used to meet this problem when I program with Android. In Android, we need to read the image orientation from the EXIF information. And when display the image, we need to change the  orientation accordingly.
fun File.orientation(): Int {
    try {
        val exif = ExifInterface(absolutePath)
        return when (exif.getAttributeInt(ExifInterface.TAG_ORIENTATION, 0)) {
            6 -> 90
            3 -> 180
            8 -> 270
            else -> 0
        }
    } catch (e: IOException) {
        e.printStackTrace()
    }
    return 0
}

I'd love to contribute code. But I'm new to iOS development. I'll try to find a solution.
I hope the information will help! Thanks a lot!

It's little strange, the image orientation works well if I use the UIImage instead of url string to get SKPhoto object.
The image from network also works well.

Thanks for the reply, I think it might be the problem of the convenience init methods, I will have a check and update you later.

@Shouheng88 sorry for the late update, may I know if the orientation issue happens on the local image?
Since network image and UIImage works, I guess local image should be the only category which is not working.

Yes, only the local image from camera has this prolbem.

@Shouheng88 Hello there, sorry for the long-awaited update.
Checked on the code, suppose the local image is convert to UIImage before showing on the screen.
May I know which version of iOS you are using, and did you set any image orientation methods for the local image that has the issue?


how to customize notes to very far?

Describe your problem here.
i want customize notes, but them must be a far, give code plz
Are you modding a build from source or with Lua?
Lua
What is your build target?
Windows x64
Did you edit anything in this build? If so, mention or summarize your changes.
No

i want customize notes, but them must be a far, give code plz

What do you mean byt that?

Resize the notes to small to create a far effect

Resize the notes to small to create a far effect

Give Example

i want customize notes, but them must be a far, give code plz

What do you mean by that?

ah! okay

Resize the notes to small to create a far effect

Give Example

Resize it to size / 3 (is an example) and then use the code

Resize the notes to small to create a far effect

Give Example

Resize it to size / 3 (is an example) and then use the code

Resize the notes to small to create a far effect

Give Example

Resize it to size / 3 (is an example) and then use the code

ok, thanks


Getting started with graphics programming in Csharp

Proposed title of article
Getting started with graphics programming in Csharp
Introduction paragraph (2-3 paragraphs):
Graphics plays an important part in every application you develop. For instance, if you are developing a paint application or code-editor software, you will want to add color and font dialog box functionality. Sometimes, you may have to print text in the form areas of the software. There may be cases where you have to decorate your text or place it within a rectangle or inside a circle. You may want to simply insert a picture as the background. The possibilities are endless. This customizations are only possible with the careful and judicious use of the appropriate concepts. This article, which is the first of two parts, explains the concepts as laid out in the Microsoft .NET Framework using C# programming language.
This section shows how to get started using GDI+ in a Windows Forms application. The following topics show how to complete several GDI+ tasks such as drawing and filling shapes and text.
Key takeaways:
In this tutorial the reader will understand:

how to change the unit of Measurement
Working with ColorDialog Box
Working with FontDialog Box
how to use System.Drawing.Drawing2D Namespace
Working with Pen objects
Working with Brush objects
Working with Images

References:
N/A

Hi, @nicasious. Great topic suggestion.
Can you tell me how your article will be unique from similar articles such as this one?

Hello, @louisefindlay23
I have looked at the  article you suggested and is significantly swallow. In my tutorial I will add more information on working with images ,working with brush object,  and working with pen object which are not in the article you have suggested me to look at .
I will write a unique  tutorial with  a better explanation.
Thank you.

Thanks, @nicasious for the explanation. Topic approved 🚀.


Assign vertexes to center

What I want:
In my situation I need a simple linear layout in which all vertex are aligned either vertically or horizontally in the center. Yet I didn't found any parameters for this feature. The mxStackLayout may be a solution but it automatically put all elements upper left.
What I've tried:
I found mxConstants.ALIGN_CENTER for mxConstants.STYLE_ALIGN and STYLE_VERTICAL_ALIGN yet they seemed to be used for labels). Therefore, no go.
What I've tried next is to use set the calculated distance to left to margin_left for each element in the get_layout function, in other words, do it manually. But this is a parent to children behavior, instead of a children to parent behavior(like in Android), which means, all children will have a same margin_left. So I made a embedded structure: for example I want a vertically centralized mxStackLayout, I firstly arrange a "anchor" all to the left, define the specific left distance to each of these "anchor", then build the real content as a child vertex to these "anchors". It's a ugly trick but it finally makes everything closer, at least seems to be (the "anchor" can be seen as a green dot lined box slightly to the left of box 1):

The issure
Is there already any some other method to implement this? It's not a bug nor a failure, just some reasonable requirement not satisfied!

To align to the center, there is https://jgraph.github.io/mxgraph/docs/js-api/files/view/mxGraph-js.html#mxGraph.alignCells

@alderg Thanks for the answer! It seems that when I use layout like mxStackLayout this function won't work, only when I remove the mxLayout will the this.resizeCell(cells[i], geo) in mxGraph.js:3622 make effect. Does it mean I can only either centralize or use the advantage that mxLayout brings me?

Yes, unless you write your own layout which I'd probably recommend in this case.

@alderg Everythings' clear. Thanks a lot!


fix(TDI-39894):update jackson version

What is the current behavior? (You can also link to an open issue here)
https://jira.talendforge.org/browse/TDI-39063
What is the new behavior?
update com.fasterxml.jackson.version to 2.8.11 for (DI components)
Please check if the PR fulfills these requirements

[x] The commit message follows Talend standard
[ ] Tests for the changes have been added (for bug fixes / features)
[ ] Docs have been added / updated (for bug fixes / features) ?
[ ] The code coverage on new code >75%
[x] The new code does not introduce new technical issues (sonar / eslint)

What kind of change does this PR introduce?

[ ] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build / CI related changes
[x] Other... Please describe: Update jackson version

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Pull request test result: success :star:
Sonar results


Added Google's model viewer within viewer_three.js

Description

Review Time Estimate

[ ] Immediately
[ ] Within one week
[ X] When possible

Types of changes

[ ] Bug fix (non-breaking change which fixes an issue)
[X ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

[ ] My change requires a change to the documentation.
[ ] I have updated the CHANGELOG.md.
[ X] I have signed the CLA
[ ] I have updated the documentation accordingly.
[ ] I have read the CONTRIBUTING document.
[ ] I have added tests to cover my changes.
[ ] All new and existing tests passed.

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.2 out of 3 committers have signed the CLA.:white_check_mark: cconsta1:white_check_mark: lmarini:x: Chrysovalantis ConstantinouChrysovalantis Constantinou seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.You have signed the CLA already but the status is still pending? Let us recheck it.

Hi! To test the changes please use the attached file containing 3D models :)
models.zip

Hi Luigi,
Maybe this has something to do with the fact that I now used Google’s model viewer to load the GLB files instead of the three.js library (which I used before). But no it’s not intentional. I can check tomorrow. However, I did notice the viewport getting huge, which happens when I load 3D models with the developer tools open. I don’t know why that happens to be honest. To reproduce this, please load a file with the tools open and once it loads close the dev tools.
Best regards,
Valentino
Sent from my iPhone

On Aug 29, 2022, at 11:48 PM, Luigi Marini @.***> wrote:

@lmarini requested changes on this pull request.
I noticed that when viewing .glb files the viewerport is much smaller than when viewing .fbx. Is that intentional?
Testing on firefox and chrome on mac.
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you authored the thread.

Hi Luigi, Maybe this has something to do with the fact that I now used Google’s model viewer to load the GLB files instead of the three.js library (which I used before). But no it’s not intentional. I can check tomorrow. However, I did notice the viewport getting huge, which happens when I load 3D models with the developer tools open. I don’t know why that happens to be honest. To reproduce this, please load a file with the tools open and once it loads close the dev tools. Best regards, Valentino
…
Sent from my iPhone
On Aug 29, 2022, at 11:48 PM, Luigi Marini @.***> wrote:  @lmarini requested changes on this pull request. I noticed that when viewing .glb files the viewerport is much smaller than when viewing .fbx. Is that intentional? Testing on firefox and chrome on mac. — Reply to this email directly, view it on GitHub, or unsubscribe. You are receiving this because you authored the thread.

@cconsta1 I tried with developer tools open on both firefox and chrome but the same thing happens.

Hi Luigi,
I think I know what the problem might be. The GLB file loads using the
element . On my first try, the viewport was as small as yours
in the picture but I remedied that by adding a CSS entry:
model-viewer {
width: 640px;
height: 480px;
}
The CSS file (style.css) loads inside the viewer_three.js file. Somehow,
it's not working on your side. I can check tomorrow. I'm attaching what I'm
seeing on my side.
Regards,
Valentino
On Tue, Aug 30, 2022 at 1:00 AM Luigi Marini @.***>
wrote:

Hi Luigi, Maybe this has something to do with the fact that I now used
Google’s model viewer to load the GLB files instead of the three.js library
(which I used before). But no it’s not intentional. I can check tomorrow.
However, I did notice the viewport getting huge, which happens when I load
3D models with the developer tools open. I don’t know why that happens to
be honest. To reproduce this, please load a file with the tools open and
once it loads close the dev tools. Best regards, Valentino
… <#m_-7621028661472024347_>
Sent from my iPhone
On Aug 29, 2022, at 11:48 PM, Luigi Marini @.***> wrote:  @lmarini
https://github.com/lmarini requested changes on this pull request. I
noticed that when viewing .glb files the viewerport is much smaller than
when viewing .fbx. Is that intentional? Testing on firefox and chrome on
mac. — Reply to this email directly, view it on GitHub, or unsubscribe. You
are receiving this because you authored the thread.
@cconsta1 https://github.com/cconsta1 I tried with developer tools open
on both firefox and chrome but the same thing happens.
—
Reply to this email directly, view it on GitHub
https://github.com/clowder-framework/clowder/pull/372#issuecomment-1230907876,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AJ3IKS7FPYYDECD5GT4DOH3V3UXJNANCNFSM56ODJLIA
.
You are receiving this because you were mentioned.Message ID:
@.***>

Thank you, Valentino. So you have the same problem, but adding the model-viewer style at run time fixes it?
Thank you,
Luigi
From: Chrysovalantis Constantinou @.>
Date: Monday, August 29, 2022 at 5:17 PM
To: clowder-framework/clowder @.>
Cc: Marini, Luigi @.>, Mention @.>
Subject: Re: [clowder-framework/clowder] Added Google's model viewer within viewer_three.js (PR #372)
Hi Luigi,
I think I know what the problem might be. The GLB file loads using the
element . On my first try, the viewport was as small as yours
in the picture but I remedied that by adding a CSS entry:
model-viewer {
width: 640px;
height: 480px;
}
The CSS file (style.css) loads inside the viewer_three.js file. Somehow,
it's not working on your side. I can check tomorrow. I'm attaching what I'm
seeing on my side.
Regards,
Valentino
On Tue, Aug 30, 2022 at 1:00 AM Luigi Marini @.***>
wrote:

Hi Luigi, Maybe this has something to do with the fact that I now used
Google’s model viewer to load the GLB files instead of the three.js library
(which I used before). But no it’s not intentional. I can check tomorrow.
However, I did notice the viewport getting huge, which happens when I load
3D models with the developer tools open. I don’t know why that happens to
be honest. To reproduce this, please load a file with the tools open and
once it loads close the dev tools. Best regards, Valentino
… <#m_-7621028661472024347_>
Sent from my iPhone
On Aug 29, 2022, at 11:48 PM, Luigi Marini @.***> wrote:  @lmarini
https://github.com/lmarinihttps://urldefense.com/v3/__https:/github.com/lmarini*3E__;JQ!!DZ3fjg!5bEmi9TDZ7MxLva6Ak3GtRPsz7F-u1uKHY7wkO-FN9LZuRc4pTI6xd8kehUhOtdsUJGWzA079UwntnxNwDKxwJz6Uw$ requested changes on this pull request. I
noticed that when viewing .glb files the viewerport is much smaller than
when viewing .fbx. Is that intentional? Testing on firefox and chrome on
mac. — Reply to this email directly, view it on GitHub, or unsubscribe. You
are receiving this because you authored the thread.
@cconsta1 https://github.com/cconsta1https://urldefense.com/v3/__https:/github.com/cconsta1*3E__;JQ!!DZ3fjg!5bEmi9TDZ7MxLva6Ak3GtRPsz7F-u1uKHY7wkO-FN9LZuRc4pTI6xd8kehUhOtdsUJGWzA079UwntnxNwDKy_kXjYA$ I tried with developer tools open
on both firefox and chrome but the same thing happens.
—
Reply to this email directly, view it on GitHub
https://github.com/clowder-framework/clowder/pull/372#issuecomment-1230907876https://urldefense.com/v3/__https:/github.com/clowder-framework/clowder/pull/372*issuecomment-1230907876*3E__;IyU!!DZ3fjg!5bEmi9TDZ7MxLva6Ak3GtRPsz7F-u1uKHY7wkO-FN9LZuRc4pTI6xd8kehUhOtdsUJGWzA079UwntnxNwDIDdxqp5w$,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AJ3IKS7FPYYDECD5GT4DOH3V3UXJNANCNFSM56ODJLIAhttps://urldefense.com/v3/__https:/github.com/notifications/unsubscribe-auth/AJ3IKS7FPYYDECD5GT4DOH3V3UXJNANCNFSM56ODJLIA*3E__;JQ!!DZ3fjg!5bEmi9TDZ7MxLva6Ak3GtRPsz7F-u1uKHY7wkO-FN9LZuRc4pTI6xd8kehUhOtdsUJGWzA079UwntnxNwDI1UqVq3g$
.
You are receiving this because you were mentioned.Message ID:
@.***>

—
Reply to this email directly, view it on GitHubhttps://urldefense.com/v3/__https:/github.com/clowder-framework/clowder/pull/372*issuecomment-1230926749__;Iw!!DZ3fjg!5bEmi9TDZ7MxLva6Ak3GtRPsz7F-u1uKHY7wkO-FN9LZuRc4pTI6xd8kehUhOtdsUJGWzA079UwntnxNwDJUPfQwcQ$, or unsubscribehttps://urldefense.com/v3/__https:/github.com/notifications/unsubscribe-auth/AAESNLJNFJK6UEX6SBM6HD3V3UZI5ANCNFSM56ODJLIA__;!!DZ3fjg!5bEmi9TDZ7MxLva6Ak3GtRPsz7F-u1uKHY7wkO-FN9LZuRc4pTI6xd8kehUhOtdsUJGWzA079UwntnxNwDIMAOdu0w$.
You are receiving this because you were mentioned.Message ID: @.***>

Hi! I think I never answered this! What do you mean by loading the CSS style at run time?


Missing _tsplitpath_s from table

[Enter feedback here]

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 44bc7b80-b6f3-3ab2-d0c2-3faf43f1e9ee
Version Independent ID: 9bfe82ae-d369-cce4-ab2e-dc615c4fe71b
Content: Routine Mappings
Content Source: docs/c-runtime-library/routine-mappings.md
Product: visual-cpp
Technology: cpp-ucrt
GitHub Login: @TylerMSFT
Microsoft Alias: twhitney

We are in the process of moving away from GitHub issues for C++ documentation (we still accept pull requests). For details, please see Announcing a new way to give feedback on Microsoft Learn This issue will be closed after it is copied to an internal tracking system.


Lint fixes, but actually working

I managed to break things by fixing lint niggles.

Adding more fixes.


Interface: BorderRadius is not Doughnut compatible ?

Documentation Is:

[X] Missing or needed?
[X] Confusing
[X] Not sure?

Please Explain in Detail...
I have try some stuff in my datasets to accomplish a doughtnut with some of them border radius.
Here my dataset :
const dashboardData = {
  labels: ["BBL", "USDT", "BUSD", "USDC", "DAI"],
  datasets: [
    {
      data: [125, 125, 125, 125, 125],
      backgroundColor: [
        "rgb(255, 99, 132)",
        "rgb(54, 162, 235)",
        "rgb(255, 205, 86)",
        "rgb(49, 12, 86)",
        "rgb(12, 12, 12)",
      ],
      borderRadius: {
        topLeft: Number.MAX_VALUE,
        bottomLeft: Number.MAX_VALUE,
        bottomRight: Number.MAX_VALUE,
        topRight: Number.MAX_VALUE,
      },
    },
  ],
};

But it doesn't work.
The documentation here : https://www.chartjs.org/docs/latest/api/interfaces/BorderRadius.html didn't tell if it is compatible
Maybe I do something wrong ?
Have a nice day
Your Proposal for Changes
Maybe a compatibility or a change proposol to show the compatibility
Example
No response

As described in the docs here you need to use outer, inner start and end. Although if you set it all to the same you can also just pass a number instead of an object.

@LeeLenaleee has the correct answer


Remove "certify" checkbox in issue template and replace with kind notice

Sanity check

[X] I certify that the redhat.ansible extension is in use and the language of the document in this bug report shows up as Ansible

Summary
After the most recent file association changes have been released.
Extension version
N/A
VS Code version
N/A
Ansible Version
N/A

OS / Environment
N/A
Relevant log output
N/A

Completed: https://github.com/ansible/vscode-ansible/pull/640


docs: update note regarding libCST Python versions support

https://pypi.org/project/libcst

Thanks a lot!


FIX Reintroduce lost changes to CompositeField_holder.ss after namespacing

I'm not sure if this was deliberate or not, but a large amount of the CompositeField_holder.ss template was lost during namespacing (commit #8dd644d).
See 3.5 version compared with current master.
In its current state, frontend composite fields do not render correctly. No labels are displayed as the individual field's holder templates are not used.
If I've mistaken this, and this was a deliberate change, please feel free to close this pull request!

cc @tractorcow

Test failures related...

Ok, those errors are happening because SelectionGroup extends CompositeField so will be inheriting the changed template.
@tractorcow are you happy that me "fixing" this regression is correct in this case? If so, I'll add the old version of this file as a template for SelectionGroup_holder to prevent this change from affecting it as well.

These changes weren't lost after namespacing, they were intentionally made during the bootrapping process.
Each field is built with a fixed _holder.ss, and a .ss. Typically the holder includes the inner field, but in some cases this was not done consistently. As of 4.0, it is.
If you take a look at ComposetField.ss, you'll see this contains the missing code you were looking for, and this is what would be included with $Field in CompositeField_holder.ss
If fields are not displayed correctly on the front end, then that is a real bug. Can you please show me the code you used to scaffold such a broken form @robbieaverill ?

Ok, I've tested the code locally on both 3.5 and 4.0. There is a bug, but it can be fixed by changing $Field to $FieldHolder in CompositeField.ss, rather than reverting the entire CompositeField_holder.ss template.
The bootstrap version of this field / holder already does this properly. We just need to update the default template.


added clarification before activating coderefinery env; closes #164

Added instruction to activate conda first before activating coderefinery environment. In Mac OS X Catalina, when opening a new terminal shell, it was necessary to do this first even though .bash_profile has export PATH="/Users/naoetatara/miniconda3/bin:$PATH". Once it is done, even after deactivating base, as long as the same window opens it is possible to start from "source activate coderefinery" or "conda activate coderefinery"

Thank you!


Support for Python3

Will there ever be support for python3?
From what I see from other issues, installing node-gyp seems to cause the issue. However according to the official docs:
https://github.com/nodejs/node-gyp#configuring-python-dependency
node-gyp does support one of these versions of python: v2.7, v3.5, v3.6, or v3.7
Any info on the topic would be appreciated.

This issue seemed to be caused when updating electron from v7.1.5 to v8.0.1


Pass the error object down to nested models

I missed the nested calls to modelObjectWithDictionary: in 11db8731.

Is there a way to test?

Yes, but not without building out the test suite a lot more. That would be a good follow-up task.