[Ionic React] Sampler does not work in mobile environments (iOS/Android)

I'm using Ionic React to build my React app for iOS and Android. I was pretty excited about this new integration of React in Ionic because I can utilize Web Audio in mobile without having to rewrite my app.
Only issue right now is that my bread and butter Sampler does not work. I'm using Sampler to create a piano from a couple of samples.
It works just fine on the web, but it looks like Tone has issues loading the sample files into the buffer on mobile. The files are definitely there, and I've gone in the Tone.js code and have verified this.
The root of the issue from me digging in the source code looks to be after the buffer for the file is 95% loaded. I'm not able to figure out how the buffer management stuff works but I hope that this is a start. I also noticed that the buffer has a readyState of  4, and a status of 0.
Any help on this would be appreciated. I can't provide a demo since you'd have to build this to iOS and then run it with Xcode. But I can provide the source code for my app that I'm working on:
Here's the repo: https://github.com/ShayanJavadi/solfej
This is the line that the sampler gets used
Screenshot of the error:

Screenshot of the iOS build folder where we can verify that the samples are present.

And again any help would be appreciated. Been busting my butt on this issue for the past couple of days as it is crucial to the success of my app.

Have you taken a look at this wiki page? Similar to the suggestions in the wiki, this SO answer suggests either using import to handle the url importing or use the public folder. Let me know if either of those works for you

@tambien Yup that's exactly how I'm handling imports right now..
Like I said the importing doesn't seem to be the issue. From what I understand from the code the buffer would not go to 95% completion.
Any ideas?

I'm using Sampler for my project, which is a PWA made using Vue and it works great on all environments, so you might wanna check other things that might cause this.
Also, something you can try is loading the buffers yourself and then sending them to the Sampler using the add() method instead of handing out url's to the sampler.

@Seanitzel My react app is working fine on all platforms as well. It’s the iOS/android build that’s giving me the issue. Not web iOS, native.
Do you happen to have an example anywhere on how to use the add() method? Is that part of the Sampler?
Appreciate your help

I was able to solve this by manually fetching the sample files:
  const A4 = await fetch("capacitor://localhost/A4.mp3")
  const A4Blob = await A4.blob()

  const A5 = await fetch("capacitor://localhost/A5.mp3")
  const A5Blob = await A5.blob()

  const A6 = await fetch("capacitor://localhost/A6.mp3")
  const A6Blob = await A6.blob()

  // console.log(a, b, URL.createObjectURL(b))

  piano = new Sampler(
    {
      A4: URL.createObjectURL(A4Blob),
      A5: URL.createObjectURL(A5Blob),
      A6: URL.createObjectURL(A6Blob)
    },
    {
      onload: () => onLoadFunction
    }
  ).toMaster();

Looks like Tone's Buffer does not work well with iOS native build files for some reason.

Great,
In case you wanna add more sounds to the sampler after instansiating it - the add method is indeed part of the Sampler api: https://tonejs.github.io/docs/13.8.25/Sampler#add
An example:
const file = await fetch(url)
const buffer = file.arrayBuffer()
const audioBuffer = Tone.context.decodeAudioData(buffer)
sampler.add('c3', audioBuffer)

I ran into the same problem in which iOS raised an error when providing the sampler with relative paths to sound files.
Solved by utilizing  @Seanitzel's suggestion like so:
import { Sampler } from "tone";

const data = {
  A1: require('../assets/sounds/A1.mp3'),
  B1: require('../assets/sounds/B1.mp3'),
  ...
};

class Example {
  sampler: Sampler;

  constructor() {
    this.sampler = new Sampler().toDestination();

    const promises = Object.entries(data).map(this.addToSampler);
    Promise.all(promises).then(() => {
      console.log('done');
    });
  }

  addToSampler = ([note, path]) =>
    fetch(path)
      .then(file => file.arrayBuffer())
      .then(buffer => context.decodeAudioData(buffer))
      .then(audioBuffer => {
        this.sampler.add(note, audioBuffer);
      });
}

Thank you @ShayanJavadi  and @Seanitzel 🙇


Connection refused

[20201110-17:18:50] [INFO ] Socket 11: AF_INET connection received from <IP_ADDRESS> port 62373
[20201110-17:18:50] [DEBUG] Closed socket 11 (AF_INET <IP_ADDRESS>:3389)
[20201110-17:18:50] [DEBUG] Closed socket 10 (AF_INET <IP_ADDRESS>:3389)
[20201110-17:18:50] [INFO ] Using default X.509 certificate: /etc/xrdp/cert.pem
[20201110-17:18:50] [INFO ] Using default X.509 key file: /etc/xrdp/key.pem
[20201110-17:18:50] [DEBUG] TLSv1.3 enabled
[20201110-17:18:50] [DEBUG] TLSv1.2 enabled
[20201110-17:18:50] [DEBUG] Security layer: requested 3, selected 1
[20201110-17:18:50] [INFO ] connected client computer name: HIH-L-4407.loca
[20201110-17:18:50] [INFO ] adding channel item name rdpdr chan_id 1004 flags 0xc0800000
[20201110-17:18:50] [INFO ] adding channel item name rdpsnd chan_id 1005 flags 0xc0000000
[20201110-17:18:50] [INFO ] adding channel item name cliprdr chan_id 1006 flags 0xc0a00000
[20201110-17:18:51] [INFO ] TLS connection established from <IP_ADDRESS> port 62373: TLSv1.3 with cipher TLS_AES_256_GCM_SHA384
[20201110-17:18:51] [DEBUG] xrdp_0000fcd5_wm_login_mode_event_00000001
[20201110-17:18:51] [INFO ] Cannot find keymap file /etc/xrdp/km-00000804.ini
[20201110-17:18:51] [INFO ] Cannot find keymap file /etc/xrdp/km-00000804.ini
[20201110-17:18:51] [INFO ] Loading keymap file /etc/xrdp/km-00000409.ini
[20201110-17:18:51] [WARN ] local keymap file for 0x00000804 found and doesn't match built in keymap, using local keymap file
[20201110-17:19:03] [DEBUG] xrdp_wm_log_msg: connecting to sesman ip <IP_ADDRESS> port 3350
[20201110-17:19:03] [INFO ] xrdp_wm_log_msg: sesman connect ok
[20201110-17:19:03] [DEBUG] xrdp_wm_log_msg: sending login info to session manager, please wait...
[20201110-17:19:03] [DEBUG] return value from xrdp_mm_connect 0
[20201110-17:19:03] [INFO ] xrdp_wm_log_msg: login successful for display 10
[20201110-17:19:03] [DEBUG] xrdp_wm_log_msg: started connecting
[20201110-17:19:07] [DEBUG] Closed socket 18 (AF_UNIX)
[20201110-17:19:11] [DEBUG] Closed socket 18 (AF_UNIX)
[20201110-17:19:14] [DEBUG] Closed socket 18 (AF_UNIX)
[20201110-17:19:18] [DEBUG] Closed socket 18 (AF_UNIX)
[20201110-17:19:21] [DEBUG] Closed socket 18 (AF_UNIX)
[20201110-17:19:25] [DEBUG] Closed socket 18 (AF_UNIX)
[20201110-17:19:28] [DEBUG] Closed socket 18 (AF_UNIX)
[20201110-17:19:32] [DEBUG] Closed socket 18 (AF_UNIX)
[20201110-17:19:35] [DEBUG] Closed socket 18 (AF_UNIX)
[20201110-17:19:38] [INFO ] Socket 11: AF_INET connection received from <IP_ADDRESS> port 62494
[20201110-17:19:38] [DEBUG] Closed socket 11 (AF_INET <IP_ADDRESS>:3389)
[20201110-17:19:38] [DEBUG] Closed socket 10 (AF_INET <IP_ADDRESS>:3389)
[20201110-17:19:38] [INFO ] Using default X.509 certificate: /etc/xrdp/cert.pem
[20201110-17:19:38] [INFO ] Using default X.509 key file: /etc/xrdp/key.pem
[20201110-17:19:38] [DEBUG] TLSv1.3 enabled
[20201110-17:19:38] [DEBUG] TLSv1.2 enabled
[20201110-17:19:38] [DEBUG] Security layer: requested 3, selected 1
[20201110-17:19:38] [INFO ] connected client computer name: HIH-L-4407.loca
[20201110-17:19:38] [INFO ] adding channel item name rdpdr chan_id 1004 flags 0xc0800000
[20201110-17:19:38] [INFO ] adding channel item name rdpsnd chan_id 1005 flags 0xc0000000
[20201110-17:19:38] [INFO ] adding channel item name cliprdr chan_id 1006 flags 0xc0a00000
[20201110-17:19:39] [DEBUG] Closed socket 18 (AF_UNIX)
[20201110-17:19:39] [INFO ] TLS connection established from <IP_ADDRESS> port 62494: TLSv1.3 with cipher TLS_AES_256_GCM_SHA384
[20201110-17:19:39] [DEBUG] xrdp_0000fcf7_wm_login_mode_event_00000001
[20201110-17:19:39] [INFO ] Cannot find keymap file /etc/xrdp/km-00000804.ini
[20201110-17:19:39] [INFO ] Cannot find keymap file /etc/xrdp/km-00000804.ini
[20201110-17:19:39] [INFO ] Loading keymap file /etc/xrdp/km-00000409.ini
[20201110-17:19:39] [WARN ] local keymap file for 0x00000804 found and doesn't match built in keymap, using local keymap file
[20201110-17:19:42] [DEBUG] Closed socket 18 (AF_UNIX)
[20201110-17:19:43] [DEBUG] Closed socket 11 (AF_INET <IP_ADDRESS>:3389)
[20201110-17:19:43] [DEBUG] xrdp_mm_module_cleanup
[20201110-17:19:46] [DEBUG] Closed socket 18 (AF_UNIX)
[20201110-17:19:49] [DEBUG] Closed socket 18 (AF_UNIX)
[20201110-17:19:53] [DEBUG] Closed socket 18 (AF_UNIX)
[20201110-17:19:53] [INFO ] Socket 11: AF_INET connection received from <IP_ADDRESS> port 62534
[20201110-17:19:53] [DEBUG] Closed socket 11 (AF_INET <IP_ADDRESS>:3389)
[20201110-17:19:53] [DEBUG] Closed socket 10 (AF_INET <IP_ADDRESS>:3389)
[20201110-17:19:53] [INFO ] Using default X.509 certificate: /etc/xrdp/cert.pem
[20201110-17:19:53] [INFO ] Using default X.509 key file: /etc/xrdp/key.pem
[20201110-17:19:53] [DEBUG] TLSv1.3 enabled
[20201110-17:19:53] [DEBUG] TLSv1.2 enabled
[20201110-17:19:53] [DEBUG] Security layer: requested 3, selected 1
[20201110-17:19:53] [INFO ] connected client computer name: HIH-L-4407.loca
[20201110-17:19:53] [INFO ] adding channel item name rdpdr chan_id 1004 flags 0xc0800000
[20201110-17:19:53] [INFO ] adding channel item name rdpsnd chan_id 1005 flags 0xc0000000
[20201110-17:19:53] [INFO ] adding channel item name cliprdr chan_id 1006 flags 0xc0a00000
[20201110-17:19:54] [INFO ] TLS connection established from <IP_ADDRESS> port 62534: TLSv1.3 with cipher TLS_AES_256_GCM_SHA384
[20201110-17:19:55] [DEBUG] xrdp_0000fd02_wm_login_mode_event_00000001
[20201110-17:19:55] [INFO ] Cannot find keymap file /etc/xrdp/km-00000804.ini
[20201110-17:19:55] [INFO ] Cannot find keymap file /etc/xrdp/km-00000804.ini
[20201110-17:19:55] [INFO ] Loading keymap file /etc/xrdp/km-00000409.ini
[20201110-17:19:55] [WARN ] local keymap file for 0x00000804 found and doesn't match built in keymap, using local keymap file
[20201110-17:19:56] [DEBUG] Closed socket 18 (AF_UNIX)
[20201110-17:20:00] [DEBUG] Closed socket 18 (AF_UNIX)
[20201110-17:20:02] [DEBUG] xrdp_wm_log_msg: VNC started connecting
[20201110-17:20:02] [DEBUG] xrdp_wm_log_msg: VNC connecting to <IP_ADDRESS> 5900
[20201110-17:20:02] [DEBUG] xrdp_wm_log_msg: VNC tcp connected
[20201110-17:20:02] [DEBUG] xrdp_wm_log_msg: VNC security level is 0 (1 = none, 2 = standard)
[20201110-17:20:02] [DEBUG] VNC Server will disconnect
[20201110-17:20:02] [DEBUG] VNC error 1 after security negotiation
[20201110-17:20:02] [DEBUG] VNC error before sending share flag
[20201110-17:20:02] [DEBUG] VNC error before receiving server init
[20201110-17:20:02] [DEBUG] VNC error before receiving pixel format
[20201110-17:20:02] [DEBUG] VNC error before receiving name length
[20201110-17:20:02] [DEBUG] VNC error before receiving name
[20201110-17:20:02] [DEBUG] xrdp_wm_log_msg: VNC error - problem connecting
[20201110-17:20:02] [DEBUG] Closed socket 17 (AF_INET <IP_ADDRESS>:62930)
[20201110-17:20:02] [DEBUG] xrdp_wm_log_msg: some problem
[20201110-17:20:02] [ERROR] xrdp_wm_log_msg: Error connecting to: <IP_ADDRESS>
[20201110-17:20:02] [DEBUG] xrdp_mm_module_cleanup
[20201110-17:20:02] [DEBUG] VNC mod_exit
[20201110-17:20:02] [DEBUG] return value from xrdp_mm_connect 1
[20201110-17:20:03] [DEBUG] Closed socket 18 (AF_UNIX)
[20201110-17:20:07] [DEBUG] Closed socket 18 (AF_UNIX)
[20201110-17:20:10] [DEBUG] Closed socket 18 (AF_UNIX)
[20201110-17:20:14] [DEBUG] Closed socket 18 (AF_UNIX)
[20201110-17:20:17] [DEBUG] Closed socket 18 (AF_UNIX)
[20201110-17:20:21] [DEBUG] Closed socket 18 (AF_UNIX)
[20201110-17:20:25] [DEBUG] Closed socket 18 (AF_UNIX)
[20201110-17:20:28] [DEBUG] Closed socket 18 (AF_UNIX)
[20201110-17:20:32] [DEBUG] Closed socket 18 (AF_UNIX)
[20201110-17:20:35] [DEBUG] Closed socket 18 (AF_UNIX)
[20201110-17:20:39] [DEBUG] Closed socket 18 (AF_UNIX)
[20201110-17:20:42] [DEBUG] Closed socket 18 (AF_UNIX)
[20201110-17:20:46] [DEBUG] Closed socket 18 (AF_UNIX)
[20201110-17:20:49] [DEBUG] Closed socket 18 (AF_UNIX)
[20201110-17:20:53] [DEBUG] Closed socket 18 (AF_UNIX)
[20201110-17:20:56] [DEBUG] Closed socket 18 (AF_UNIX)
[20201110-17:21:00] [DEBUG] Closed socket 18 (AF_UNIX)
[20201110-17:21:03] [DEBUG] Closed socket 18 (AF_UNIX)
[20201110-17:21:07] [DEBUG] Closed socket 18 (AF_UNIX)
[20201110-17:21:10] [DEBUG] Closed socket 18 (AF_UNIX)
[20201110-17:21:14] [DEBUG] Closed socket 18 (AF_UNIX)
[20201110-17:21:17] [DEBUG] Closed socket 18 (AF_UNIX)
[20201110-17:21:21] [DEBUG] Closed socket 18 (AF_UNIX)
[20201110-17:21:24] [DEBUG] Closed socket 18 (AF_UNIX)
[20201110-17:21:28] [DEBUG] Closed socket 18 (AF_UNIX)
[20201110-17:21:32] [DEBUG] Closed socket 18 (AF_UNIX)
[20201110-17:21:35] [DEBUG] Closed socket 18 (AF_UNIX)
[20201110-17:21:39] [DEBUG] Closed socket 18 (AF_UNIX)
[20201110-17:21:42] [DEBUG] Closed socket 18 (AF_UNIX)
[20201110-17:21:46] [DEBUG] Closed socket 18 (AF_UNIX)
[20201110-17:21:49] [DEBUG] Closed socket 18 (AF_UNIX)
[20201110-17:21:53] [DEBUG] Closed socket 18 (AF_UNIX)
[20201110-17:21:56] [DEBUG] Closed socket 18 (AF_UNIX)
[20201110-17:22:00] [DEBUG] Closed socket 18 (AF_UNIX)
[20201110-17:22:03] [DEBUG] Closed socket 18 (AF_UNIX)
[20201110-17:22:07] [DEBUG] Closed socket 18 (AF_UNIX)
[20201110-17:22:10] [DEBUG] Closed socket 18 (AF_UNIX)
[20201110-17:22:14] [DEBUG] Closed socket 18 (AF_UNIX)
[20201110-17:22:17] [DEBUG] Closed socket 18 (AF_UNIX)
[20201110-17:22:21] [DEBUG] Closed socket 18 (AF_UNIX)
[20201110-17:22:24] [DEBUG] Closed socket 18 (AF_UNIX)
[20201110-17:22:28] [DEBUG] Closed socket 18 (AF_UNIX)
[20201110-17:22:31] [DEBUG] Closed socket 18 (AF_UNIX)
[20201110-17:22:34] [DEBUG] xrdp_wm_log_msg: connection problem, giving up
[20201110-17:22:34] [DEBUG] Closed socket 18 (AF_UNIX)
[20201110-17:22:34] [DEBUG] xrdp_wm_log_msg: some problem
[20201110-17:22:34] [DEBUG] xrdp_mm_module_cleanup
[20201110-17:22:34] [DEBUG] Closed socket 17 (AF_INET <IP_ADDRESS>:62908)
[20201110-17:22:34] [DEBUG] Closed socket 11 (AF_INET <IP_ADDRESS>:3389)
[20201110-17:22:35] [DEBUG] xrdp_mm_module_cleanup

xrdp.log

The VNC module currently only supports the "VNC authentication" method, or no authentication at all. This message indicates the VNC module and the VNC server could not agree on a security type:-
VNC Server will disconnect

How are you starting the VNC server? Are you able to change the security type it's using?

sudo /usr/local/sbin/xrdp

@shh230 - the problem seems to be a mismatch between the security types provided by these items:-

The VNC server. Looking at the information you've presented above, this is something out of the scope of XRDP.
The VNC module provided by XRDP.

You'll need to reconfigure your VNC server to support the standard "VNC authentication" security type. Until you do this, XRDP will not be able to connect to it.

I use connect to other RDP server with freeRDP. How to set up RDP server?

To use XRDP you need to configure a VNC server on the Mac and then connect to that. It looks like that's what you're trying to do.
However, the server and XRDP must agree on a "security type". XRDP does not support many of these at the moment.
I'm afraid I don't have access to a Mac so I can't tell you what you need to do to make this work. Maybe someone else can help.

There's been no movement on this for a couple of months so I'm closing it. Anyone who has more Mac knowledge or experience can still comment here.

There's been no movement on this for a couple of months so I'm closing it. Anyone who has more Mac knowledge or experience can still comment here.

I believe the issue is the security level is 0 part.
I got around this by going into System Preferences -> Sharing

make sure Remote Management is checked
click Computer Settings in the Remote Management menu
Check "VNC viewers may control screen with password and set a password"


SoundCloud Playcounts?

Does anyone know if songs played with react-player using soundcloud links adds to playcounts on soundclound?

All ReactPlayer does is grab the stream_url for a track via JSONP and then set the src of an <audio> element. However, it does require a client_id to be appended to the stream_url path so it may be possible that the "play" is still registered with Soundcloud.
I guess the only way to truly know would be to upload your own track to Soundcloud and play it only using ReactPlayer, and see if the play count goes up.
I'll close the issue as it is nothing to do with ReactPlayer, but @a-s-f feel free to update this issue if you manage to find anything out.


Dynamically Generated MenuItem does not update IsChecked property of bound backing property.

Describe the bug
When Binding to a property using the <MenuItem.Styles> or <MenuItem.ItemContainerTheme> method, the IsChecked property does not stay in sync with its bound property.

The underlying property is not updated when you check/uncheck the menu element (I could get around that with a command)
The IsChecked property on the MenuItem does not get updated when the backing Property is changed, despite that property being a Reactive Property from ReactiveUI.Fody.Helpers (which should implement INotifyPropertyChanged). This means that the Checkbox stays visible despite the fact that it should not.

To Reproduce
Use this code:
<MenuItem Header="_Windows" ItemsSource="{Binding WorkspaceWindows, Mode=OneWay}">
    <MenuItem.ItemContainerTheme>
        <ControlTheme TargetType="MenuItem" BasedOn="{StaticResource {x:Type MenuItem}}"
                      x:DataType="layout:WorkspaceWindowState">

            <Setter Property="Command"
                    Value="{Binding  $parent[MenuItem].((appnamespaces:WindowViewModel)DataContext).ToggleWindowCommand}" />
            <Setter Property="CommandParameter" Value="{Binding .}" />
            <Setter Property="Header" Value="{Binding Name}" />
            <Setter Property="IsChecked" Value="{Binding IsVisible}" />
            <Setter Property="ToggleType" Value="CheckBox" />
        </ControlTheme>
    </MenuItem.ItemContainerTheme>
</MenuItem>

The type of WorkSpaceWindows is an ObservableList of:
public class WorkspaceWindowState : ReactiveObject {
  [Reactive]
  public bool IsVisible { get; set; }

  public string Name { get; set; } = string.Empty;
}

Expected behavior
Closing the window sets the value of IsVisible to false, so the IsChecked Property of the MenuItem should be set to false too.
Avalonia version
11.1.3
OS
Windows
Additional context
No response

I think I have a similar issue;
I am using a CheckBox generate dynamically from a collection, like this:
<ItemsControl ItemsSource="{Binding xxx}">
  <ItemsControl.ItemTemplate>
    <DataTemplate>
        <CheckBox IsChecked="{Binding IsSelected, Mode=TwoWay}" />
    </DataTemplate>
  </ItemsControl.ItemTemplate>
</ItemsControl>

I've noticed the bound property IsSelected is triggered only when the CheckBox is set to false, when the CheckBox is set to true, the bound property change is not triggered at all.


hydra_unstable: 2022-06-30 -> 2022-08-08

Description of changes
changes: https://github.com/NixOS/hydra/compare/f2f82b3eeed652e7fc076adf6dcd5a72baaaed18...2b1c1e65d5fbbe25625a31ee93cb14c9a9edf969

Fit more content on screen
Use libmagic for better output MIME detection

Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[x] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
22.11 Release Notes (or backporting 22.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module
[ ] (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes

[x] Fits CONTRIBUTING.md.

Result of nixpkgs-review pr 185935 run on x86_64-linux 1

1 package built:

hydra_unstable

Rebuilt my system and hydra's also still happy, so LGTM.


Add comments state

Modepress has the functionality for commenting built into the API but there is no way to author any of the comments. We need a new section created that allows us to view and modify the comments.
The comments should have a section similar to that of the posts and users. Each comment should be listed in a detail directive, within an item-panel. Admin's should be able to edit comments from here.

Moved to: https://github.com/MKHenson/modepress-admin/issues/2


chore: Move autocomplete suggestions from entityDefinitions to individual widget components

Fixes #21718
This is a PR for review of approach that I have come up with refactor for issue : #21718.
We can discuss the approach in the comments.
This PR moves autocomplete suggestions from a static utility file, entityDefinitions, to widget/index.ts file of each widget.
This refactor will help in the long term project of moving widgets into its own module as well as support for custom widgets.

/ok-to-test sha=0696ab9

/ok-to-test sha=65b8e06

/ok-to-test sha=edba60ec9f

/ok-to-test sha=bce602b

/ok-to-test sha=9b7cef1

/ok-to-test sha=fad80de

/ok-to-test sha= fad80de

Good job, Rajat. just a few minor callouts.

Please use the appropriate type instead of any.
Can we change the name from autoCompletConfig to autocompleteDefinitions ?

Done

/ok-to-test sha=6d753a8

/ok-to-test sha=e694a21

/ok-to-test sha=0f99ecc

/ok-to-test sha=0f99ecc


Add location search

It should be possible to search among the existing locations with an autocomplete.
Nice to have: Geocode the entered location if it doesn't appear in the autocomplete

Done in 0c16f60cb739ea8ddc140b13838580c6cc361107


Add optional link to events source

You're adding a link to the units table (or in #1 a dynamic table region to the units table) but it would be nice to have a link of some sort to the events we're aligning that neural data to
As discussed this could be a time column on a dynamic table (which could use either (i) an extra field to specify the name of the column on that dynamic table region used to align or (ii) extend the HDMF dynamic table region to specify not just row indices but also column names), or certain objects from ndx-events, or even certain timestamps from a TimeSeries such as an IndexSeries (in which case use a TimeSeriesReference as the link)

This could technically also replace the current event-timestamps (https://github.com/catalystneuro/ndx-binned-spikes/blob/main/spec/ndx-binned-spikes.extensions.yaml#L40) by linking to the timestamps used for the bin alignment so the timestamps data is not duplicated
I'm more on the fence about that one though - it can be nice to have the timestamps attached explicitly here for easy access instead of having to follow a link

My initial plan was to have the two options and use post_init checks for this. But yes, I like to preserve the ability to build  an NWB object simply. That meaning, without having to build x or y first to instantiate it.

Ok, so this can't be done with the current automatic mechanism to define a class BinnedAlignedSpikes = get_class("BinnedAlignedSpikes", "ndx-binned-spikes"). That is, I need some sort of post_init check to verify that only one of the following is passed: 1) event-timestamps or 2) a reference to any other object in the spec that represent event timestamps (e.g. start_time in a dynamic column, ndx-events, etc).
I am gona add documentation of the current use case as a the next prority and come back to this once I explore the DiCarlo data as this is a nice to have.

I just meant in the schema, there could be an optional link to the actual object being used as a reference for the alignment, such as an IndexSeries, column of DynamicTable, etc. in addition to the explicit event timestamps. To clarify that there is a relationship between the two objects
For example, say you have a pretty complicated trials table with lots of conditions per trial, and you want to make several of these alignment objects you're designing for various columns. Let's also say you have other stuff like optogenetics or visual stimuli in your stimulus areas of the NWB file - if your extension objects can link to the trials table (and in a best-case scenario, the particular column of that table) that helps remove any confusion about where the source of the event timestamps might be and also is a hint to a data reuser to 'go check out that linked object for more details'

I just meant in the schema, there could be an optional link to the actual object being used as a reference for the alignment, such as an IndexSeries, column of DynamicTable, etc. in addition to the explicit event timestamps.

OK, thanks. Making it in addition and not xor should be easier.

@h-mayorquin Feel free to close w/e you decide


Don't charge exp for searching for items (1.14)

Anvil GUI was charging exp for searching for heads. Fixed that.
:)

Going to double check this commit, I can't decide if this is gonna break the layout of my files or not.

To be fair I'm meant to fix the issue with the repo being in a bad folder in a new repo sooner or later when I'm not so busy, and in fact the commit doesn't actually change any of the java files. Did you forget to commit it or?

Wow, out of habit I added 'src' (a shortcut file for my ide) instead of the main folder xD

Alright thank you for committing the code that time. Will give it a shot when I get the chance. But no worries, was kind of confused xD

Tested and confirmed that everything works fine. Am hoping this is possible with the previous versions, but if so I'll do those. Thank you again!


format the source code

This formats the code using https://pypi.org/project/black/.

Another time, I think this is a good idea.


How to trigger/call c++ function from nodejs javascript class?

What OS are you using (uname -a, or Windows version)?
Windows
What programming language are you using (C/C++/Go/Rust)?
Visual Studio 2022
What did you expect to see and what you saw instead?

I have a nodejs javascript class
@Injectable()
export class MyJSClass extends BaseClass {

  process(arg: InputArgs) {
    console.log('calling process');
    // do processing
  }
};

MyJSClass.process(parameters) is triggered by js code in nodejs script.  How do I trigger a c++ function call when MyJSClass.process is called ?
How do I bind this process method in webiview?
    webview::webview webview(true, nullptr);
    webview.set_title("Test");
    webview.set_size(512, 512, WEBVIEW_HINT_NONE);

    webview.bind("MyJSClass.process", [](std::string s) -> std::string {
        std::cerr << "called function from javascript" <<  s << std::endl;
        return { s };
    });

    webview.navigate("http://localhost:9200");  /* nodejs server running locally */
    webview.run();

I'm not sure if I understand what you means. But for calling c++ code from nodejs or set nodejs callback for C++,you may try nodejs-ffi-napi. I have tried it in my Kotlin/JS bindings and it works well.


Use float instead of int for :number type

In case you'd use :number type of some field in typescript, right now, resulting schema would give this field Int type.
While int is propably more popular than float it might cause some data accuracy lose without any warning.
Right now, if you'd like to use Int, you'd have to explicitly set it as type property of decorator

Hey @pie6k, thanks for the fix! Could you add your name/change to the changelog file before I merge this?

@pie6k I've created another PR adding the proper changes in tests as well (see #83)

@pie6k released 1.0.0-alpha10


ARROW-3279: [C++] Allow linking Arrow tests dynamically on Windows

This helps reduce build times because we don't have to build both the static and shared library.

Codecov Report

Merging #2592 into master will increase coverage by 0.01%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master    #2592      +/-   ##
==========================================
+ Coverage   87.15%   87.17%   +0.01%
==========================================
  Files         380      380
  Lines       58889    58901      +12
==========================================
+ Hits        51322    51344      +22
+ Misses       7493     7487       -6
+ Partials       74       70       -4

Impacted Files
Coverage Δ

cpp/src/arrow/python/helpers.h
90% <ø> (ø)
:arrow_up:

cpp/src/arrow/python/decimal.h
100% <ø> (ø)
:arrow_up:

cpp/src/arrow/util/io-util.h
100% <ø> (ø)
:arrow_up:

cpp/src/arrow/util/cpu-info.cc
77.92% <ø> (ø)
:arrow_up:

cpp/src/arrow/type.h
86.36% <ø> (-0.18%)
:arrow_down:

cpp/src/parquet/schema-internal.h
100% <ø> (ø)
:arrow_up:

cpp/src/arrow/compute/kernels/util-internal.h
100% <ø> (ø)
:arrow_up:

cpp/src/parquet/murmur3.h
100% <100%> (ø)
:arrow_up:

cpp/src/arrow/table_builder.h
100% <100%> (ø)
:arrow_up:

cpp/src/arrow/util/logging.h
60% <100%> (ø)
:arrow_up:

... and 16 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 35b5bce...dd8fe76. Read the comment docs.

Needs a rebase

This seems to have had limited impact on CI runtimes

This seems to have had limited impact on CI runtimes

It's not easy to compare, as they vary quite a bit from run to run. In the logs, one can see that there are 50 to 100 less compilation steps in each cmake pass, which should translate into faster builds on average.
(ultimately, I think it would be nice for this to work on Unix too, as it would shrink the size of test executables, but there are probably major hurdles to overcome)

+1. I won't merge until @xhochy weighs in on the ListType<T> issue

Note ListType<T> was added specifically to implement stl.h.

Rebased... let's hope CI still passes.


Make type constraints mandatory

Feature Request
Description of Problem:
The output from this profile:
{
  "schemaVersion": "v3",
  "fields": [
    {
      "name": "first_name"
    }
  ],
  "rules": [
    {
      "field": "first_name",
      "is": "matchingRegex",
      "value": "(Joh?n|Mar[yk])"
    }
  ]
}

is somewhat unexpected:
> java -jar generator.jar generate profile.json "c:\temp\generator\bar.csv" --t=INTERESTING

first_name
-2147483648
0
2147483646
Jon
John
1900-01-01T00:00
2100-01-01T00:00

Some of the rows are clearly invalid, as they violate the regex rule.
The output is more in line with expectations if you provide a type constraint:
{
  "schemaVersion": "v3",
  "fields": [
    {
      "name": "first_name"
    }
  ],
  "rules": [
    {
      "field": "first_name",
      "is": "matchingRegex",
      "value": "(Joh?n|Mar[yk])"
    },
     {
      "field": "first_name",
      "is": "ofType",
      "value": "string"
    }
  ]
}

Potential Solutions:
Make type constraints mandatory

Why would we do this and not imply types whenever we add a constraint?

Why would we do this and not imply types whenever we add a constraint?

This comes down to usability, within the engine it is 'more sensible' to not imply types - although this is a bit contested. However as Colin has mentioned this is 'less friendly' for users as those without a computer science or mathematics background probably wouldn't expect this.
We have 2 choices of attack:

Embed logic into the reader to imply constraints, but this could be quite difficult when you have if, anyOf and allOf constraints
Show an error to say that users should fix fields to a particular type, or disable this form of checking

The latter is easier and likely to be safer and to implement

I don't see the difficulty with if anyof allof.
for allof, if its not Contradictory, that's fine. if it is, it doesn't produce data.
for if and anyOf.
we internally convert those to or statements.
depending on which is chosen. depends on what restriction it gets.
IMO the problems of not implying type is way harder and more confusing
what does length 3 and is a date mean?
we support it and return nonsense data rather than simply saying it's a contradiction.
it's confusing for people with maths and computer science backgrounds.
It would require refactoring of code and changing of logic, but there would be less things to support so the code would be more understandable and with less edge cases.
This wouldn't restrict what can be done with the generator, as fields that can be either one type or another, can still be done with an if statement, or an anyOf

There are some subtle logical issues you run into if you have implicit typing. Consider the following constraints:
A: X greaterThan 3
B: ¬(X greaterThan 3)
C: X greaterThan 3 AND X ofType numeric
D: ¬(X greaterThan 3 AND X ofType numeric)
Let's say A only permits numerics. That's also presumably true of B? Naturally, it's true of C. What about D? If A and C have the same denotation, shouldn't B and D as well? (PS, "yes, but we have to sacrifice that" is a valid answer to that question! a lot of the design of Helix is about choosing which axioms we want to fulfil and acknowledging which other ones we have to sacrifice)

D will convert to
¬greater than OR ¬numeric
so can be less than 4
or not a number
whereas simply
¬greater than
is
less than 4
¬(x and y) IS different to ¬(x)
x or y IS different to x
we should treat it as different

Do you disagree that if X and Y have the same denotation, it's intuitive that ¬X and ¬Y should as well?

what do you mean by denotation?

Let's go over the terminological details in person - I'm wary of polluting this thread too much :)

After a discussion with @SL-Mark & @ColinEberhardt (product owner) the following can be expressed.
Reason for change: It is important that a user (who may never have used the tool before) can get some data that looks correct. The example provided in the summary of this ticket shows numeric and temporal values which do not match the regular expression in the profile.
It has been agreed that the generator engine (most probably) in the correct manner, and certainly supports violations more correctly in its current fashion. As such any change might be expected at a higher - more user facing mode. It has also been agreed that the tool should 'help' the user to generate data, not hinder this by way of presenting error messages.
As such the following change is proposed:

Update the profile reading section of the generator to (if the option is enabled, which will be on by default) infer the type for fields where no type constraints are found (in the profile) for each field
Update the schema to have a configurable section to control whether this mode is enabled or disabled (absence of the section would imply it is on)

For point (2) above the following could be imagined:
{
  "schemaVersion": "v4",
  "options": {
    "inferTypes": true
  },
  "fields": [{ "name": "foo" }],
  "rules": [
    ...
  ]
}

Whilst out-of-scope, its worth mentioning that the options section described above could be expanded to contain other information, e.g. which constraints should not be violated, etc.
Acceptance criteria (given the above statements)

[ ] Updated schema version with new 'options' section, allowing for control of whether type-inference is enabled

[ ] Documentation and example files updated to match the new schema version

[ ] Profile reader or analyser which can insert a ofType constraint for fields (in a new rule?) where no ofType constraint can be found
[ ] The ability to disable this mode, with documentation on how to and what people may expect from doing so
[ ] Cucumber framework updated to support toggling this mode, off by default?

Why are we introducing a new means of configuring generation when we already have config generation - setting options on the command line? I would reject the idea of noting which constraints should/should not be violated in this section as this would be far more useful to be able to declare this on a constraint.

The idea here is that the options aren't describing how to generate, but rather how to interpret the profile they're annotating. The two things are closely linked and should be kept together.

Closed as all tasks complete


What is the point of the unstable_features flag?

The documentation of unstable_features says:
Enable unstable features on stable channel.

But the option itself is only available on nightly. So how am I supposed to enable this if I am using stable rustfmt?
I wanted to use this to have unstable formatting options on a stable toolchain without having to install that one separately.

Hmm, I think we should have made unstable_features stable before releasing 1.0.0.


Add support for headstage-nric1384-203390

headstage-nric1384-203390 is a 384 channel headstage that uses BGA-packaged neuropixels 1.0 chip (NRIC1384) for acquisition.  It uses Molex 203390 quad-strip connectors for probe connectorization. It also has estim, 3d-tracking, and 3d-orientation capabilities.

This is being addressed in #84 but requires a review.


Onboarding gotchas

Hi Jonathan,
Thanks for tackling this web push topic it really is quite a beast, hence DHH thinks it's worth going after!
Just wanted to let you know a couple of gotchas I ran into when installing the gem.
1. DB migration
My users table has UUIDs as primary keys and I had to change that in the migration - common issue and actually happened on noticed itself as well.
2. installer

It failed but I will break out the real issues separately.
$ rails g noticed:web_push:install
2024-01-06T03:09:24.983Z pid=34373 tid=143l INFO: Sidekiq 7.2.0 connecting to Redis with options {:size=>10, :pool_name=>"internal", :url=>nil}
         run  yarn add github:jbennett/noticed-web_push from "."
yarn add v1.22.21
info No lockfile found.
[1/4] Resolving packages...
[2/4] Fetching packages...
[3/4] Linking dependencies...
[4/4] Building fresh packages...
success Saved lockfile.
success Saved 1 new dependency.
info Direct dependencies
└─<EMAIL_ADDRESS>info All dependencies
└─<EMAIL_ADDRESS>Done in 1.64s.
      append  app/javascript/application.js
         run  touch app/javascript/service_worker.js from "."
      append  app/javascript/service_worker.js
      append  config/initializers/assets.rb
/home/axel/.gem/ruby/3.2.2/bundler/gems/noticed-web_push-132116a5c22b/lib/generators/noticed/web_push/templates/app.webmanifest.erb.tt:8:in `template': undefined method `image_path' for #<Noticed::WebPush::Generators::InstallGenerator:0x00007fb29cae6090 @behavior=:invoke, @_invocations={Noticed::WebPush::Generators::InstallGenerator=>["add_javascript_deps", "setup_service_worker", "create_webmanifest"]}, @_initializer=[[], [], {:behavior=>:invoke, :destination_root=>#<Pathname:/home/axel/src/buzz-me-in>, :shell=>#<Thor::Shell::Color:0x00007fb29c08c6d0 @base=#<Noticed::WebPush::Generators::InstallGenerator:0x00007fb29cae6090 ...>, @mute=false, @padding=0, @always_force=false>}], @options={"skip_namespace"=>false, "skip_collision_check"=>false}, @args=[], @shell=#<Thor::Shell::Color:0x00007fb29c08c6d0 @base=#<Noticed::WebPush::Generators::InstallGenerator:0x00007fb29cae6090 ...>, @mute=false, @padding=0, @always_force=false>, @destination_stack=["/home/axel/src/buzz-me-in"], @indentation=0, @source_paths=["/home/axel/src/buzz-me-in/lib/templates/noticed/install", "/home/axel/.gem/ruby/3.2.2/bundler/gems/noticed-web_push-132116a5c22b/lib/generators/noticed/web_push/templates"], @output_buffer="{\n  \"name\": \"OVERRIDE VIEW IN APPLICATION\",\n  \"short_name\": \"SHORT NAME\",\n  \"start_url\": \"/sign_in\",\n  \"display\": \"fullscreen\",\n  \"icons\": [\n    {\n      \"src\": \""> (NoMethodError)
        from /home/axel/.rubies/ruby-3.2.2/lib/ruby/3.2.0/erb.rb:429:in `eval'
        from /home/axel/.rubies/ruby-3.2.2/lib/ruby/3.2.0/erb.rb:429:in `result'
        from /home/axel/.gem/ruby/3.2.2/gems/thor-1.3.0/lib/thor/actions/file_manipulation.rb:129:in `block in template'
        from /home/axel/.gem/ruby/3.2.2/gems/thor-1.3.0/lib/thor/actions/create_file.rb:54:in `render'
        from /home/axel/.gem/ruby/3.2.2/gems/thor-1.3.0/lib/thor/actions/create_file.rb:64:in `block (2 levels) in invoke!'
        from /home/axel/.gem/ruby/3.2.2/gems/thor-1.3.0/lib/thor/actions/create_file.rb:64:in `open'
        from /home/axel/.gem/ruby/3.2.2/gems/thor-1.3.0/lib/thor/actions/create_file.rb:64:in `block in invoke!'
        from /home/axel/.gem/ruby/3.2.2/gems/thor-1.3.0/lib/thor/actions/empty_directory.rb:117:in `invoke_with_conflict_check'
        from /home/axel/.gem/ruby/3.2.2/gems/thor-1.3.0/lib/thor/actions/create_file.rb:61:in `invoke!'
        from /home/axel/.gem/ruby/3.2.2/gems/thor-1.3.0/lib/thor/actions.rb:93:in `action'
        from /home/axel/.gem/ruby/3.2.2/gems/thor-1.3.0/lib/thor/actions/create_file.rb:25:in `create_file'
        from /home/axel/.gem/ruby/3.2.2/gems/thor-1.3.0/lib/thor/actions/file_manipulation.rb:125:in `template'
        from /home/axel/.gem/ruby/3.2.2/bundler/gems/noticed-web_push-132116a5c22b/lib/generators/noticed/web_push/install_generator.rb:35:in `create_webmanifest'

So I had to do the following manually:

copy the has_many to users
add the mounting to routes.rb
add tags and buttons to layout

3. yarn
As I'm not using yarn to pull in your scripts, I copied the files from https://github.com/jbennett/noticed-web_push/tree/main/app/assets/javascripts/noticed/web_push to my own app/javascript folder.
I'm not a JS guy so not sure how this can be packaged better - or if it needs to, but I'm using importmaps which is kind of the new default for Rails, so should somehow work with this (and maybe have an option in the installer OR detect whether yarn/npm is used).
Also had to change the imports in the 2 JS files from from "noticed-web_push/web_push" to `from "./web_push/web_push" to resolve to my local copies.
4. Active record encryption
Getting the following error when trying to save the web push subscription:
ActiveRecord::Encryption::Errors::Configuration (Missing Active Record encryption credential: active_record_encryption.deterministic_key):

Makes sense to save this encrypted but if it is a requirement it could maybe be checked in the install script - or it could be made optional (though compromising on security is not good).
Noticed does require rails but only 5.2+ I think, so technically this gem might have to require a more recent rails version itself.
5. ApplicationController
It is weird as it seems you have Noticed::WebPush::ApplicationController but it seems like the controllers are inheriting from my apps ApplicationController as I do have a before_action :require_logged_in_user! which I selectively skip where applicable and it catches for all the gem mounted controller actions.
6. Javascript, again
I actually had to also copy the service_worker.js (copied from the gem) content into my sevice_worker.js file as, at least with import maps, I can't just have an "import" statement.
Again I like the plug & play approach but some of that JS might want to be customized as well - perhaps web_push.start is not the most elegant API/DSL for this.
7. save vs setup subscription
I had to change the Notification.permission == "granted" case to check for existing service worker registration.
            navigator.serviceWorker.getRegistrations().then(registrations => {
              if (registrations.length) {
                saveSubscription()
              } else {
                setupSubscription()
              }
            })

As I hit some snags setting everything up (issues with my service worker especially) it happened that Notification access was granted but the service worker was never set up - and saveSubscription would "hang" forever on const registration = await navigator.serviceWorker.ready
8. I would like to customize the "Enable notifications" button
It relies on it's ID so I can probably just add a button with that ID anywhere I like though.
What I really liked though was:

no forcing local certs - I'd rather use a tunnel like ngrok
vapid generator task that let me copy&paste the keys

That was a lot and I might have forgotten some!
But I got it working :rocket: Now I still want to clean things up a little bit. It's quite tricky as there are so many moving pieces especially with the JS and all the routes - I also don't know of any clean ways to pass configuration such as routes from Ruby to JS (without dragging them through the HTML).

Thanks so much for your input. I'll be working through this as I think about v2 in light of the stuff that DHH is proposing for Rails 8.
I'm currently thinking about splitting this into two a PWA focused engine that will be conceptually consistent with what the Rails 8 changes will be and a noticed-web_push that builds on that for noticed. I see the first as being a stopgap and will go away once you are on Rails 8.
What are your feelings on that?


[scaled_joint_trajectory_controller]: Can't accept new action goals. Controller is not running.

Affected ROS2 Driver version(s)
2.2.10
Used ROS distribution.
Humble
Which combination of platform is the ROS driver running on.
Ubuntu Linux with standard kernel
How is the UR ROS2 Driver installed.
From binary packets
Which robot platform is the driver connected to.
UR E-series robot
Robot SW / URSim version(s)
5.12.0 / 5.12.2 / 5.14.6
How is the ROS driver used.
Through the robot teach pendant using External Control URCap
Issue details
Summary
The scaled trajectory controller is inactive after starting the ur driver.
Tried it on both ur5e and ur10e.
Possibly after the new update from ros2.
Issue details
When I launch the ur_driver, the controllers are not active. Hence when I give execute command on MoveIt2 plugin, it gives the error
[ur_ros2_control_node-1] [ERROR] [1705415302.914893185] [scaled_joint_trajectory_controller]: Can't accept new action goals. Controller is not running.

When I run the list_controllers command, it gives the following output -
ros2 control list_controllers
forward_position_controller[position_controllers/JointGroupPositionController] inactive
joint_state_broadcaster[joint_state_broadcaster/JointStateBroadcaster] active
force_torque_sensor_broadcaster[force_torque_sensor_broadcaster/ForceTorqueSensorBroadcaster] active
io_and_status_controller[ur_controllers/GPIOController] active
speed_scaling_state_broadcaster[ur_controllers/SpeedScalingStateBroadcaster] active
scaled_joint_trajectory_controller[ur_controllers/ScaledJointTrajectoryController] inactive

Steps to Reproduce
ros2 launch ur_robot_driver ur_control.launch.py ur_type:=<ur_type> robot_ip:=<robot_ip>

Expected Behavior
All the controller to be active
Actual Behavior
Trajectory controller is not active, causing the moveit2 commands to not execute.
Relevant log output
not_windows@LabTop3:~$ ros2 launch ur_robot_driver ur_control.launch.py ur_type:=ur10e robot_ip:=<IP_ADDRESS>
[INFO] [launch]: All log files can be found below /home/not_windows/.ros/log/2024-01-16-15-27-53-885308-LabTop3-17710
[INFO] [launch]: Default logging verbosity is set to INFO
[INFO] [dashboard_client-2]: process started with pid [17715]
[INFO] [controller_stopper_node-3]: process started with pid [17717]
[INFO] [ur_ros2_control_node-1]: process started with pid [17713]
[INFO] [urscript_interface-4]: process started with pid [17719]
[INFO] [robot_state_publisher-5]: process started with pid [17721]
[INFO] [rviz2-6]: process started with pid [17723]
[INFO] [spawner-7]: process started with pid [17725]
[INFO] [spawner-8]: process started with pid [17727]
[INFO] [spawner-9]: process started with pid [17729]
[INFO] [spawner-10]: process started with pid [17731]
[INFO] [spawner-11]: process started with pid [17733]
[INFO] [spawner-12]: process started with pid [17735]
[ur_ros2_control_node-1] [WARN] [1705415274.450115868] [controller_manager]: [Deprecated] Passing the robot description parameter directly to the control_manager node is deprecated. Use '~/robot_description' topic from 'robot_state_publisher' instead.
[ur_ros2_control_node-1] text not specified in the tf_prefix tag
[ur_ros2_control_node-1] [INFO] [1705415274.450499306] [resource_manager]: Loading hardware 'ur10e'
[robot_state_publisher-5] [INFO] [1705415274.450495154] [robot_state_publisher]: got segment base
[robot_state_publisher-5] [INFO] [1705415274.450581158] [robot_state_publisher]: got segment base_link
[robot_state_publisher-5] [INFO] [1705415274.450590885] [robot_state_publisher]: got segment base_link_inertia
[robot_state_publisher-5] [INFO] [1705415274.450596516] [robot_state_publisher]: got segment flange
[robot_state_publisher-5] [INFO] [1705415274.450601715] [robot_state_publisher]: got segment forearm_link
[robot_state_publisher-5] [INFO] [1705415274.450606632] [robot_state_publisher]: got segment ft_frame
[robot_state_publisher-5] [INFO] [1705415274.450611863] [robot_state_publisher]: got segment shoulder_link
[robot_state_publisher-5] [INFO] [1705415274.450616875] [robot_state_publisher]: got segment tool0
[robot_state_publisher-5] [INFO] [1705415274.450621509] [robot_state_publisher]: got segment upper_arm_link
[robot_state_publisher-5] [INFO] [1705415274.450626295] [robot_state_publisher]: got segment world
[robot_state_publisher-5] [INFO] [1705415274.450631040] [robot_state_publisher]: got segment wrist_1_link
[robot_state_publisher-5] [INFO] [1705415274.450635794] [robot_state_publisher]: got segment wrist_2_link
[robot_state_publisher-5] [INFO] [1705415274.450640507] [robot_state_publisher]: got segment wrist_3_link
[ur_ros2_control_node-1] [INFO] [1705415274.451942327] [resource_manager]: Initialize hardware 'ur10e'
[ur_ros2_control_node-1] [INFO] [1705415274.452010930] [resource_manager]: Successful initialization of hardware 'ur10e'
[ur_ros2_control_node-1] [INFO] [1705415274.452176486] [resource_manager]: 'configure' hardware 'ur10e'
[ur_ros2_control_node-1] [INFO] [1705415274.452186824] [resource_manager]: Successful 'configure' of hardware 'ur10e'
[ur_ros2_control_node-1] [INFO] [1705415274.452213246] [resource_manager]: 'activate' hardware 'ur10e'
[ur_ros2_control_node-1] [INFO] [1705415274.452223561] [URPositionHardwareInterface]: Starting ...please wait...
[ur_ros2_control_node-1] [INFO] [1705415274.452236490] [URPositionHardwareInterface]: Initializing driver...
[ur_ros2_control_node-1] [INFO] [1705415274.452789843] [UR_Client_Library:]: SCHED_FIFO OK, priority 99
[controller_stopper_node-3] [INFO] [1705415274.465218915] [Controller stopper]: Waiting for switch controller service to come up on controller_manager/switch_controller
[dashboard_client-2] [INFO] [1705415274.467336248] [UR_Client_Library:]: Connected: Universal Robots Dashboard Server
[dashboard_client-2]
[rviz2-6] [INFO] [1705415274.775988550] [rviz2]: Stereo is NOT SUPPORTED
[rviz2-6] [INFO] [1705415274.776108306] [rviz2]: OpenGl version: 4.6 (GLSL 4.6)
[rviz2-6] [INFO] [1705415274.788597137] [rviz2]: Stereo is NOT SUPPORTED
[ur_ros2_control_node-1] [INFO] [1705415274.918594530] [UR_Client_Library:]: Negotiated RTDE protocol version to 2.
[ur_ros2_control_node-1] [INFO] [1705415274.918845359] [UR_Client_Library:]: Setting up RTDE communication with frequency 500.000000
[ur_ros2_control_node-1] [WARN] [1705415275.949485588] [UR_Client_Library:]: DEPRECATION NOTICE: Setting the keepalive count has been deprecated. Instead use the RobotReceiveTimeout, to set the timeout directly in the write commands. Please change your code to set the read timeout in the write commands directly. This keepalive count will overwrite the timeout passed to the write functions.
[ur_ros2_control_node-1] [WARN] [1705415275.949532569] [UR_Client_Library:]: DEPRECATION NOTICE: Setting the keepalive count has been deprecated. Instead you should set the timeout directly in the write commands. Please change your code to set the read timeout in the write commands directly. This keepalive count will overwrite the timeout passed to the write functions.
[ur_ros2_control_node-1] [INFO] [1705415275.949543644] [URPositionHardwareInterface]: Calibration checksum: 'calib_5119701370761913513'.
[spawner-12] [INFO] [1705415276.770520931] [spawner_forward_position_controller]: Waiting for '/controller_manager' services to be available
[spawner-8] [INFO] [1705415276.771830554] [spawner_joint_state_broadcaster]: Waiting for '/controller_manager' services to be available
[spawner-9] [INFO] [1705415276.772698565] [spawner_io_and_status_controller]: Waiting for '/controller_manager' services to be available
[spawner-11] [INFO] [1705415276.777039882] [spawner_force_torque_sensor_broadcaster]: Waiting for '/controller_manager' services to be available
[spawner-7] [INFO] [1705415276.785221589] [spawner_scaled_joint_trajectory_controller]: Waiting for '/controller_manager' services to be available
[spawner-10] [INFO] [1705415276.788614407] [spawner_speed_scaling_state_broadcaster]: Waiting for '/controller_manager' services to be available
[ur_ros2_control_node-1] [ERROR] [1705415276.995253935] [URPositionHardwareInterface]: The calibration parameters of the connected robot don't match the ones from the given kinematics config file. Please be aware that this can lead to critical inaccuracies of tcp positions. Use the ur_calibration tool to extract the correct calibration from the robot and pass that into the description. See [https://github.com/UniversalRobots/Universal_Robots_ROS2_Driver/blob/main/ur_calibration/README.md] for details.
[ur_ros2_control_node-1] [INFO] [1705415276.995351581] [URPositionHardwareInterface]: System successfully started!
[ur_ros2_control_node-1] [INFO] [1705415276.995375872] [resource_manager]: Successful 'activate' of hardware 'ur10e'
[controller_stopper_node-3] [INFO] [1705415277.004181300] [Controller stopper]: Service available
[controller_stopper_node-3] [INFO] [1705415277.004235988] [Controller stopper]: Waiting for list controllers service to come up on controller_manager/list_controllers
[controller_stopper_node-3] [INFO] [1705415277.004262280] [Controller stopper]: Service available
[ur_ros2_control_node-1] [INFO] [1705415277.006003777] [UR_Client_Library:]: SCHED_FIFO OK, priority 99
[ur_ros2_control_node-1] [INFO] [1705415277.180218429] [controller_manager]: Loading controller 'forward_position_controller'
[ur_ros2_control_node-1] [INFO] [1705415277.186513561] [controller_manager]: Loading controller 'joint_state_broadcaster'
[spawner-12] [INFO] [1705415277.186622117] [spawner_forward_position_controller]: Loaded forward_position_controller
[ur_ros2_control_node-1] [INFO] [1705415277.192195199] [controller_manager]: Loading controller 'force_torque_sensor_broadcaster'
[spawner-8] [INFO] [1705415277.192595555] [spawner_joint_state_broadcaster]: Loaded joint_state_broadcaster
[spawner-11] [INFO] [1705415277.198595268] [spawner_force_torque_sensor_broadcaster]: Loaded force_torque_sensor_broadcaster
[ur_ros2_control_node-1] [INFO] [1705415277.198603845] [controller_manager]: Loading controller 'io_and_status_controller'
[ur_ros2_control_node-1] [INFO] [1705415277.204260874] [controller_manager]: Loading controller 'speed_scaling_state_broadcaster'
[spawner-9] [INFO] [1705415277.204745268] [spawner_io_and_status_controller]: Loaded io_and_status_controller
[ur_ros2_control_node-1] [INFO] [1705415277.208239250] [speed_scaling_state_broadcaster]: Loading UR SpeedScalingStateBroadcaster with tf_prefix:
[ur_ros2_control_node-1] [INFO] [1705415277.210248761] [controller_manager]: Loading controller 'scaled_joint_trajectory_controller'
[spawner-10] [INFO] [1705415277.210538505] [spawner_speed_scaling_state_broadcaster]: Loaded speed_scaling_state_broadcaster
[ur_ros2_control_node-1] [WARN] [1705415277.216137146] [scaled_joint_trajectory_controller]: [Deprecated]: "allow_nonzero_velocity_at_trajectory_end" is set to true. The default behavior will change to false.
[ur_ros2_control_node-1] [INFO] [1705415277.218439821] [controller_manager]: Configuring controller 'forward_position_controller'
[spawner-7] [INFO] [1705415277.218686986] [spawner_scaled_joint_trajectory_controller]: Loaded scaled_joint_trajectory_controller
[ur_ros2_control_node-1] [INFO] [1705415277.219244867] [forward_position_controller]: configure successful
[ur_ros2_control_node-1] [INFO] [1705415277.220325450] [controller_manager]: Configuring controller 'joint_state_broadcaster'
[ur_ros2_control_node-1] [INFO] [1705415277.220373581] [joint_state_broadcaster]: 'joints' or 'interfaces' parameter is empty. All available state interfaces will be published
[ur_ros2_control_node-1] [INFO] [1705415277.224292028] [controller_manager]: Configuring controller 'force_torque_sensor_broadcaster'
[ur_ros2_control_node-1] [INFO] [1705415277.226473215] [controller_manager]: Configuring controller 'io_and_status_controller'
[ur_ros2_control_node-1] [INFO] [1705415277.228458868] [controller_manager]: Configuring controller 'speed_scaling_state_broadcaster'
[ur_ros2_control_node-1] [INFO] [1705415277.228507360] [speed_scaling_state_broadcaster]: Publisher rate set to : 100.0 Hz
[ur_ros2_control_node-1] [INFO] [1705415277.230278295] [controller_manager]: Configuring controller 'scaled_joint_trajectory_controller'
[ur_ros2_control_node-1] [INFO] [1705415277.230451988] [scaled_joint_trajectory_controller]: No specific joint names are used for command interfaces. Using 'joints' parameter.
[ur_ros2_control_node-1] [INFO] [1705415277.230473971] [scaled_joint_trajectory_controller]: Command interfaces are [position] and state interfaces are [position velocity].
[ur_ros2_control_node-1] [INFO] [1705415277.230483364] [scaled_joint_trajectory_controller]: Using 'splines' interpolation method.
[ur_ros2_control_node-1] [INFO] [1705415277.231344253] [scaled_joint_trajectory_controller]: Controller state will be published at 100.00 Hz.
[ur_ros2_control_node-1] [INFO] [1705415277.232286890] [scaled_joint_trajectory_controller]: Action status changes will be monitored at 20.00 Hz.
[spawner-8] [INFO] [1705415277.240667987] [spawner_joint_state_broadcaster]: Configured and activated joint_state_broadcaster
[spawner-11] [INFO] [1705415277.244754193] [spawner_force_torque_sensor_broadcaster]: Configured and activated force_torque_sensor_broadcaster
[spawner-9] [INFO] [1705415277.252932801] [spawner_io_and_status_controller]: Configured and activated io_and_status_controller
[spawner-10] [INFO] [1705415277.257043183] [spawner_speed_scaling_state_broadcaster]: Configured and activated speed_scaling_state_broadcaster
[spawner-7] [INFO] [1705415277.261018659] [spawner_scaled_joint_trajectory_controller]: Configured and activated scaled_joint_trajectory_controller
[INFO] [spawner-12]: process has finished cleanly [pid 17735]
[INFO] [spawner-8]: process has finished cleanly [pid 17727]
[INFO] [spawner-11]: process has finished cleanly [pid 17733]
[INFO] [spawner-9]: process has finished cleanly [pid 17729]
[INFO] [spawner-10]: process has finished cleanly [pid 17731]
[INFO] [spawner-7]: process has finished cleanly [pid 17725]
[ur_ros2_control_node-1] [INFO] [1705415302.914857595] [scaled_joint_trajectory_controller]: Received new action goal
[ur_ros2_control_node-1] [ERROR] [1705415302.914893185] [scaled_joint_trajectory_controller]: Can't accept new action goals. Controller is not running.

Accept Public visibility

[X] I agree to make this context public

I had the same issue with URSim. Please try running in terminal:
ros2 service call /controller_manager/switch_controller controller_manager_msgs/srv/SwitchController '{"activate_controllers": ["scaled_joint_trajectory_controller"], "deactivate_controllers": ["joint_trajectory_controller", "forward_velocity_controller","forward_position_controller"], "strictness": 1}'

Hello @PhDittmann ,
Thanks for your reply. I tried the command, but it ended up giving the following error -
[ur ros2_control_node-1] [WARN] [1706281297.843853243] [scaled joint_trajectory_controller]: Aborted due to state tolerance violation
But if I restart the external urcap and launch the ur_driver file again, it starts working. I don't know if I am doing anything incorrectly.

Hello @RobertWilbrandt,
I was performing the operations in incorrect order. When I followed the order mentioned by you, it works correctly. I was connected over WLAN, so it would also drop connections and give same error, so I got confused. Now I connect with a LAN cable and it works correctly.


Length of RTP timestamp will be greater then unsigned int

Thanks for sharing.
This project is very powerful.
I found 1 issue that cause the stream can't be played.
chrono::time_point_cast<chrono::microseconds>(chrono::steady_clock::now());
The value of this function will be greater and greater.
Finally it will be greater than 32 bits, so some player can't play the stream.

Hi, I think it should be handled by the rtsp client.
// rtsp client handle rtp timestamp
int64_t modify_timestamp(uint32_t timestamp)
{
static int64_t relative_timestamp = 0;
static int64_t last_timestamp = 0;
if(last_timestamp == 0)
{
	last_timestamp = (int64_t)timestamp;
}

int64_t current_timestamp = (int64_t)timestamp;
int64_t delta_timestamp = last_timestamp - current_timestamp;

if(delta_timestamp > 0)
{
	relative_timestamp += delta_timestamp;
}

last_timestamp = (int64_t)timestamp;
return relative_timestamp;

}

Hi, I think it should be handled by the rtsp client.
int64_t modify_timestamp(uint32_t timestamp)
{
static int64_t relative_timestamp = 0;
static int64_t last_timestamp = 0;
if(last_timestamp == 0)
{
	last_timestamp = (int64_t)timestamp;
}

int64_t current_timestamp = (int64_t)timestamp;
int64_t delta_timestamp = last_timestamp - current_timestamp;

if(delta_timestamp > 0)
{
	relative_timestamp += delta_timestamp;
}

last_timestamp = (int64_t)timestamp;
return relative_timestamp;

}

Hi, I think it should be handled by the rtsp client.
`int64_t modify_timestamp(uint32_t timestamp)
{
static int64_t relative_timestamp = 0;
static int64_t last_timestamp = 0;
if(last_timestamp == 0)
{
last_timestamp = (int64_t)timestamp;
}
int64_t current_timestamp = (int64_t)timestamp;
int64_t delta_timestamp = last_timestamp - current_timestamp;
if(delta_timestamp > 0)
{
relative_timestamp += delta_timestamp;
}
last_timestamp = (int64_t)timestamp;
return relative_timestamp;
}`

Hi, thanks for your reply
In fact, I'm developing on a smart home camera for Alexa.
Alexa echo show doesn't handle such situation, so I need to handle this on server side.
I have fixed this by modifying the function "getRtpInfo" in "RtpConnection.cpp".
I set rtptime as 0 when the stream initiated.
Just want to share this with you.
Thanks. :)


3599 prototype get-model endpoint

Fixes #3599
Scope:

First working version of get-model endpoint for preview and discussion
Documentation and integration tests

If sat, unsat, unknown is consensus, I'll rename the result type (on Monday).
Now, should it indeed be an error if a non-predicate (term, config) is sent?

I think this is OK to allow sending a non-predicate and only consider the predicate part. We should explicitly document that the non-predicate part of the term will be ignored.


Missing searchables

items/search/{query}
header for searchables for language

sorted these out in last push


Nuget dependency on  "Microsoft.Owin.Host.SystemWeb"

The project doesn't have reference Microsoft.Owin.Host.SystemWeb.
It is referenced and used only by the test project.
This dependency is redundant, please remove it.

Hi @arieradle that reference is indeed required because the Auth0AccountController class which is added by the package requires it.
If this is a problem for you I can create a new NuGet package which includes only the OWIN middleware and will therefore required less dependencies.
Please let me know if this is required by you.

I would like to have such NuGet.

OK, I will create one for you ;)

10x :smile:

You can use https://www.nuget.org/packages/Auth0-ASPNET-Owin-Libs/ for using just the OWIN middleware


added OMOP predicates

Summary by CodeRabbit

New Features

Introduced a detailed section in the OMOP dataset README, explaining predicates for healthcare events including hospital admissions, discharges, emergency department registrations, and patient death.
Added a new YAML configuration file defining predicates for categorizing healthcare events with relevant codes for each event type.

@justin13601 can you check the ACES syntax? If that looks good then this is good to go IMO.
@ChaoPang, we may want to make this specific to Columbia too, even though it is a general OMOP input, but we can address that later.

@mmcdermott @justin13601, I don't think I have permission to merge the PR. Would you mind granting the appropriate permission?

@mmcdermott @justin13601, I don't think I have permission to merge the PR. Would you mind granting the appropriate permission?

I don't think I can give permission either but I've merged it for now - @mmcdermott can you add when you get a chance?


new contract logo for Gooreo

In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:

[x] Filename in the lowercase format
[x] Image format: png
[x] Image size: 256 by 256 px

0x18088625f914468a3fcc5904ce24920a3ed87c1a is the new contract address and the old one is no more supported

Can you provide a link to public news stating contract change ?

Dear,
this is the link https://medium.com/@gooreo/business-development-update-3rd-june-2019-gooreo-new-smart-contract-b97c76485caf
Kind Regards,

Gooreo Team
<EMAIL_ADDRESS>http://www.gooreo.com/
---- On Mon, 03 Jun 2019 17:53:48 +0300 Mykola<EMAIL_ADDRESS>wrote ----
Can you provide a link to public news stating contract change ?
—
You are receiving this because you authored the thread.
Reply to this email directly, https://github.com/TrustWallet/tokens/pull/1753?email_source=notifications&email_token=AKHH3DHIRSJLFFA6OT6EBJTPYUV7ZA5CNFSM4HSGKMC2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODWZVCDQ#issuecomment-498290958, or https://github.com/notifications/unsubscribe-auth/AKHH3DB2KTI3TAXYEBAYPW3PYUV7ZANCNFSM4HSGKMCQ.


change all bower_components to node_modules

Status:  WIP
Owner: @ericawright
Reviewers: @mikenikles @MikeKlemarewski @johnboxall  @fractaltheory @stewartyu
Changes

change bower to npm
WIP:  changing zepto to JQuery

Todos:

[ ] Engineer +1

Niiiiiiiiiiice ⭐

LGTM :+1:


Symlink issues with helm init

See if we need to uptake this: https://github.com/kubernetes/helm/commit/9129188fadd62e2baf01dbc0f0c2c21638aab4bf

May also need to look at https://github.com/kubernetes/helm/commit/7cc610960f91589b9a07c285f73f96023db99fef.
I think the built-in Java filewalker stuff will handle all this for us by default.

https://github.com/kubernetes/helm/commit/9129188fadd62e2baf01dbc0f0c2c21638aab4bf is irrelevant for this project's purposes; no work to do.


IInstalledDesktopApp isn't accessible (CS1022 error?)

I was trying out the sample code on this page, and Visual Studio gave me a CS0122 'IInstalledDesktopApp' is inaccessible due to its protection level error message. It compiled and executed successfully if I changed the type parameter in the generic to InstalledDesktopApp.
Some build information in case that is necessary (I was using the C# WinAppSDK project template):
Microsoft Visual Studio Enterprise 2022
Version 17.2.1
OS: prerelease build of Windows 11

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 207d5cfe-20c7-4d3a-afd2-8b70a9e75f31
Version Independent ID: 1f4e5844-0ead-3ebc-cd21-01c45cd27378
Content: InstalledDesktopApp.GetInventoryAsync Method (Windows.System.Inventory) - Windows UWP applications
Content Source: winrt-api-build/xml/Windows.System.Inventory/InstalledDesktopApp.xml
Product: uwp
Technology: winrt-reference
GitHub Login: @hickeys
Microsoft Alias: hickeys

Thanks for submitting your feedback and we apologize for the delayed response. I see that updates have not been made since the creation of this Issue, so I went ahead and created a PR to incorporate your suggestions. The changes should be live soon, so I will go ahead and close this issue.
Though the Issue will be marked as Closed, we will monitor any replies that come afterwards so treat this like an open Issue. Many thanks!


foreach loop

Just found out about zephir and I try to figure it out.
I am passing an array but I get this error when zephir build
Syntax error in /home/osboxes/Desktop/utils/utils/greeting.zep on line 13

	        foreach($arr as $key => $value) {
	---------------------^

namespace Utils;

/**
 * This is a sample class
 */
class Greeting
{
    /**
     * This is a sample method
     */
    public function say($arr)
    {
        foreach($arr as $key => $value) {
	   echo $key . ": " $value;
	}
    }
}

Can you provide an example please; Thanks in advance.

You have to use a for statement.

@arkanSoul  There is no foreach control flow statement for traversing items in a collection/arrays. As @sandrokeil mentioned you have to use for instead.


Get started button fixed for larger screens

Related Issue

Information about the related issue

Closes: #161
Describe the changes you've made
Fixed the get started button which was not working for larger screen.
Type of change
What sort of change have you made:

[x] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Code style update (formatting, local variables)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[ ] Documentation update.
[ ] This change requires a documentation update

How Has This Been Tested?

Checklist

[x] My code follows the guidelines of this project.
[x] I have performed a self-review of my own code.
[ ] I have commented on my code, particularly wherever it was hard to understand.
[ ] I have made corresponding changes to the documentation.
[ ] My changes generate no new warnings.
[ ] I have added tests that prove my fix is effective or that my feature works.
[ ] Any dependent changes have been merged and published in downstream modules.

Screenshots (if applicable)
Updated -

Code of Conduct

[x] I agree to follow this project's Code of Conduct

@Deepu178 I fixed the issue related to get started button. I checked everything when I created the menubar initially, now when I reviewed the code I noticed someone messed up with Backdrop.tsx file which caused this problem.

@Deepu178 changes are not yet reflected


Lint dashboard directory

This PR is part of #236 endeavor.

@Digipalvelutehdas/apika-tiimi please review


Remove references to specific projects from the readme

Bevy builds on a ton of different libraries. Choosing who gets "prime real estate" in the readme is hard / political. Closing that can of worms makes a lot of sense to me.
I have also removed the "alternatives" section for similar reasons. There are a number of engines/libs that aren't credited there, some of those listed no longer exist / aren't maintained, and it isn't really our job to be the canonical source.  Each alternative listed is a soft endorsement of the project (and the reverse is true for projects we don't include). Again, closing this can of worms feels like the right call.

RENDERED


initial pass at adding "action" field

I read through the human-readable version and tried to apply the right action to each field. People are free to change what they actually do, but having a "recommended" action will make it easier to automatically load the list.
I put in four distinct values: suspend, suspend+no-media (pawoo only), silence+no-media, silence, no-media.
Also fixed the domain of 2.distsn.org.

Hey, I'm sorry I didn't talk about this sooner (social anxiety, yay!), but I'm concerned about the potential for instances to go on autopilot, because I think it's better if instances could analyse their threat models and apply levels of blocks accordingly.
(I know this is way too late because the JSON list is now gone, but I wanted to respond, sorry for the delay again!)


Uri::fragment() is only available in test

Uri::fragment() is conditionally included with cfg(test): https://github.com/hyperium/hyper/blob/9c80fdbb9e2ffb717e7126a453e815e8c47be459/src/uri.rs#L222-L228
It seems a weird omission from a basic API which already offers path and query. Could it be the case that this is simply a mistake, and fragment should be included unconditionally?

It wasn't a mistake, it was intentional. Perhaps a comment should have been left explaining the "why". Here's some why:
The server should never receive the fragment, and so it being on the type might make people think they should reach for it (and perhaps route on it). And clients should also never actually send a fragment to the server.
I do realize there is legitimate reason for a client to interact with a fragment before or after issuing a request to a server, but there were concerns (at least my own) of misusing it
It should perhaps be noted that hyper::Uri will soon be replaced with http::Uri, and maybe that issue would be best for discussing how to expose it?

The server should never receive the fragment
You are right. I was confused on this point, but have now re-read the spec regarding it :)

I no longer feel that I should be able to access the fragment where I have tried to do so, so I will close the issue. A code comment explaining the "why" might be appropriate :)
Thanks for your quick response :+1:


[Bug] CenterHead with multi task.

Prerequisite

[X] I have searched Issues and Discussions but cannot get the expected help.
[X] I have read the FAQ documentation but cannot get the expected help.
[X] The bug has not been fixed in the latest version (dev-1.x) or latest version (dev-1.0).

Task
I'm using the official example scripts/configs for the officially supported tasks/models/datasets.
Branch
main branch https://github.com/open-mmlab/mmdetection3d
Environment
python3.7
Reproduces the problem - code sample
xxx
Reproduces the problem - command or script
xxx
Reproduces the problem - error message
https://github.com/open-mmlab/mmdetection3d/blob/0f9dfa97a35ef87e16b700742d3c358d0ad15452/mmdet3d/models/dense_heads/centerpoint_head.py#L484
Here, I found in CenterHead.py. in centerpoint models on nuscenes dataset, common_heads are multi-task specific. But I found the above code, while selecting gt boxes according to gt label for one specific task, directly use class name order in current task to index the original class name order in nus-3d.py, I think it should be under the premise of the class name order in common_heads the same as class name order in nus-3d.py. But I found they are not the same. I am confused about it, could you please show me the reason?
Additional information
class names in nus-3d.py
class_names = [
    'car', 'truck', 'trailer', 'bus', 'construction_vehicle', 'bicycle',
    'motorcycle', 'pedestrian', 'traffic_cone', 'barrier'
]

class names in common_head in file https://github.com/open-mmlab/mmdetection3d/blob/0f9dfa97a35ef87e16b700742d3c358d0ad15452/configs/base/models/centerpoint_voxel01_second_secfpn_nus.py#L42C3-L42C3
tasks=[
          dict(num_class=1, class_names=['car']),
          dict(num_class=2, class_names=['truck', 'construction_vehicle']),
          dict(num_class=2, class_names=['bus', 'trailer']),
          dict(num_class=1, class_names=['barrier']),
          dict(num_class=2, class_names=['motorcycle', 'bicycle']),
          dict(num_class=2, class_names=['pedestrian', 'traffic_cone']),
      ]

What I mean is that the class_names order of tasks while flattening in one list should be the same as class_names in nus-3d.py. Or we will get a wrong class label using class_name.index(i) + flag which is not aligned with the original class_names index order in gt_instances_3d.labels_3d.

In the final config, we refactor the class_names to adjust the tasks. Please see here (https://github.com/open-mmlab/mmdetection3d/blob/main/configs/centerpoint/centerpoint_pillar02_second_secfpn_8xb4-cyclic-20e_nus-3d.py) for reference.

@Xiangxu-0103 thanks for your quick reply.

Another  question: I met a problem when using analysis_tools/get_flops.py
/opt/conda/lib/python3.7/site-packages/traits/etsconfig/etsconfig.py:428: UserWarning: Environment variable "HOME" not set, setting home directory to /tmp
  % (environment_variable, parent_directory)
Traceback (most recent call last):
  File "tools/analysis_tools/get_flops.py", line 83, in <module>
    main()
  File "tools/analysis_tools/get_flops.py", line 73, in main
    flops, params = get_model_complexity_info(model, input_shape)
  File "/opt/conda/lib/python3.7/site-packages/mmcv/cnn/utils/flops_counter.py", line 107, in get_model_complexity_info
    _ = flops_model(batch)
  File "/opt/conda/lib/python3.7/site-packages/torch/nn/modules/module.py", line 1120, in _call_impl
    result = forward_call(*input, **kwargs)
  File "/root/code/eq_mmdet3d_128/mmdet3d/models/detectors/base.py", line 88, in forward
    return self._forward(inputs, data_samples, **kwargs)
TypeError: _forward() takes 1 positional argument but 3 were given

how to solve it?

python tools/analysis_tools/get_flops.py \
    /root/code/eq_mmdet3d_128/configs/centerpoint/centerpoint_voxel0075_second_secfpn_8xb4-cyclic-20e_nus-3d.py \

Run this command

It seems that model input is not only the arg shape, how can I compute the 3D detector flops using the script? Looking forward to your reply and solution.

I get a similar error for Pointpillars #3028.
Did you find a solution to fix this problem? @Xiangxu-0103 @DezeZhao


Allow setting custom source dir via input

🎉 Thanks for sending this pull request! 🎉
Please make sure the title is clear and descriptive.
If you are fixing a typo or documentation, please skip these instructions.
Otherwise please fill in the sections below.
Which problem is this pull request solving?
Example: I'm always frustrated when [...]
List other issues or pull requests related to this problem
Example: This fixes #5012
Describe the solution you've chosen
Example: I've fixed this by [...]
Describe alternatives you've considered
Example: Another solution would be [...]
Checklist
Please add a x inside each checkbox:

[ ] The status checks are successful (continuous integration). Those can be seen below.

What would be the benefits of using a plugin inputs for users instead of using the build.edge_handlers configuration property?

if i want to test a pre-release of this plugin without updating the buildbot image, i need to be able to run this plugin explicitly from the package in my repo.

I can't use the default name edge-handlers for the dir name, because that means the core plugin would run after mine
if I set build.edge_handlers the official core plugin would run, too

this is more of a developer productivity thing than anything publicly facing

if I set build.edge_handlers the official core plugin would run, too

It does not. I have added the following logic because I ran into the same problem you are facing:
https://github.com/netlify/build/blob/725f36c60d1ee5a43b2cfe2fb8c1c923979d327b/packages/build/src/plugins/options.js#L79-L90
If you set build.edge_handlers, the official core plugin should not run.

oh, awesome. didn't know.
That's very handy!


NmeaDevice::ProcessNmea multipart message cache questions

With reference to NmeaDevice ProcessNmea

Is a Lock object required when working with MultiPartMessageCache?
Should there be a Return after Line 172? ie if something is out of order, clear cache and don't raise event
Likewise, should IF statement at Line 182, have an ELSE with a Return if the dictionary isn't full? (ie wait for all messages before raising event)

Thanks and regards
TT

Also, at Line 185 should
args.MessageParts = dic.Values.ToArray();
be changed to
args.MessageParts = dic.Values.Cast<NmeaMessage>.ToArray;
Regards
TT

No shouldn't be, as the messages are not passed in a multi-threaded manner.
No this typically only happens in the beginning where you might start getting messages in-between.
The idea is to raise an event for each message - you'd have to check if all messages are there or not if you only care about the last one.


Stack overflow crashes from hwc.exe

We're experiencing random but fairly frequent (5-10 a day) crashes in the hwc.exe file.  I've capture some of the details from the Windows event logs at https://gist.github.com/amhuber/d4c59ca3e42d19b7b44fe9288ea9cae8.  These are apps that have been running for some time using the binary_buildpack and are seeing the crashes after moving to hwc_buildpack.  From the CF side the errors look like:
App instance exited with guid efefaa8f-1b71-4654-9e5c-2186845cae0f payload: {"instance"=>"402b9783-eb18-46d4-542d-8f1c660ad285", "index"=>2, "reason"=>"CRASHED", "exit_description"=>"2 error(s) occurred:\n\n* Exited with status -1073741571\n* cancelled", "crash_count"=>1, "crash_timestamp"=>1496251511896170785, "version"=>"c127b9a6-8658-43db-afa2-2c8211cea06a"}

Any ideas on what we can do to help troubleshoot the overflow errors?
Aaron

Please open this issue here: https://github.com/cloudfoundry-incubator/hwc

Moving to https://github.com/cloudfoundry-incubator/hwc/issues/4.


Unable to use Bash as integrated terminal

Issue Type: Bug
Issue description
Visual Studio Code version: 1.47.3, git version 2.27.0.windows.1. For the past few months I've been unable to use bash as VSCode's integrated terminal. It's set as default, when I open up the terminal most of the time I dont get a prompt, until I open up a second instance in the terminal. When I do get a prompt, I try an 'ls' command and it either works, returns nothing, or returns 'segmentation fault (core dumped)'.

Running 'ls' works

What's the actual result?

The first time it will usually run the 'ls' command. If I go to run it again (or any other command like 'clear'), it returns 'segmentation fault' or 'segmentation fault (core dumped)'.

Additional details / Things I've tried / screenshot
Running Git Bash outside of VSCode works perfect as expected, it runs in Windows Terminal. Also running CMD or PS as VSCode's integrated terminal works as expected. I had VSC/bash working on this machine a few months ago with no problems.
I've tried adding git binaries to windows defender exclusion list (read that might be a fix), but that didn't solve it. I've also uninstalled/reinstalled VSCode and Git for windows, tried multiple Git bash versions, still nothing.

VS Code version: Code 1.47.3 (91899dcef7b8110878ea59626991a18c8a6a1b3e, 2020-07-23T13:12:49.994Z)
OS version: Windows_NT x64 10.0.19041

System Info

Item
Value

CPUs
Intel(R) Core(TM) i9-9900K CPU @ 3.60GHz (16 x 3600)

GPU Status
2d_canvas: enabledflash_3d: enabledflash_stage3d: enabledflash_stage3d_baseline: enabledgpu_compositing: enabledmultiple_raster_threads: enabled_onoop_rasterization: disabled_offprotected_video_decode: unavailable_offrasterization: enabledskia_renderer: disabled_off_okvideo_decode: enabledviz_display_compositor: enabled_onviz_hit_test_surface_layer: disabled_off_okwebgl: enabledwebgl2: enabled

Load (avg)
undefined

Memory (System)
31.93GB (26.42GB free)

Process Argv

Screen Reader
no

VM
0%

Extensions: none

Can you share your settings.json file?

{
    "extensions.ignoreRecommendations": false,
    "explorer.confirmDelete": false,
    "window.zoomLevel": 1,
    "terminal.integrated.shell.windows": "C:\\Program Files\\Git\\bin\\bash.exe",
}

I think the only thing this could be is an upstream issue in conpty, the component which launches the process, which also drives Windows Terminal. You say it doesn't happen in Windows Terminal which is on a newer version of conpty so maybe the fix will hit Windows 10 within the next 12 months?


Screensaver password delay action

hello
not sure if this counts as a feature request, but adding (re-adding, really) and option to change the time before a screensaver password is reuqested (given that disabling it with FV2 enabled is impossible) would be great!
thanks, Michael

Can I re-open this? Or better to make a new feature request? I don't use FV at all. But I'd prefer changing the password delay time as I move between contexts, to enabling and disabling password protection altogether.  I believe the relevant value is askForPasswordDelay.  Also, in case it helps, I believe I read somewhere that behavior may be different if the native System Preferences app is open at the time a programatic change is made to askForPasswordDelay (so maybe better to test with that app closed.)  Thanks!


Security: deb-s3 incorporates existing release/manifests without verifying signatures

When performing operations such as uploading a package, deb-s3 fetches existing manifest and release files and trusts them fully without verifying that they are signed by a trusted key. This allows for the security provided by apt repository signing to be defeated:

Adversary with ability to write to the bucket but without the signing key uploads a malicious package(s) and updated but unsigned manifest/release files that incorporate the malicious package(s).
When the authorized deb-s3 user (who has the signing key) performs any operation where deb-s3 updates the manifests/release, the malicious package(s) become incorporated into a validly signed release.

The entire point of apt repository signing is to prevent malicious tampering with the repository by an adversary that as a given does have the ability to modify the repository at rest but does not have any trusted signing keys.
By failing to verify that information retrieved from the bucket has not been tampered with before incorporating that information into updated manifest/release files that are signed with a trusted key, deb-s3 creates an opportunity for malicious packages to be distributed as if the adversary had control of a trusted signing key.

Why are you allowing untrusted users write access to your S3 buckets?

@tomelliff Ideally, that would of course never happen. However, at-rest compromise of package repositories(/mirrors) does happen, that's a part of why the ability for signing to happen offline is a feature of most robust update/distribution schemes.
The issue here is that deb-s3 undermines that by blindly trusting the at-rest repo, treating the signature as just a thing to be done so that clients trust the repo instead of as part of keeping the repo itself secure.


Slug is not updating. it is taking previous slug.

Terms

[X] #8232

Bagisto Version(s) affected
master
Issue Description
While creating/updating the title it is showing the slug is updating but actually not updating the slug it took the previous slug.
Preconditions

Admin should be logged in.
Admin should have at least one created product.

Steps to reproduce

Go to 'Admin panel'
Click on 'Edit product' inside the Catalog/products
Change the product name
See the error

Expected Result
It should be updated the slug according to the current value.
Actual Result
It takes the previous slug. Here
Screenshots
No response
Additional context
No response

The issue is still there. Here

Its working fine.
Please try to run development envirnment server then try again.

@suraj-webkul While entering the name it is highlighted the required fields. Here

Fixed

@suraj-webkul Still facing the same issue. Here

Now, this issue is fixed. so I am closing this issue.
And I have attached a screenshot Here, for future reference.


When does it support multilingual versions?

Looking forward to arranging.

It's planned but isn't current a high priority. Can you clarify exactly what you want to see implemented? Do you want to have multi-language support for app names, descriptions and so on? The app also isn't currently localized in terms of the strings included it. We currently lack the resources to do these things properly.

It's planned but isn't current a high priority. Can you clarify exactly what you want to see implemented? Do you want to have multi-language support for app names, descriptions and so on? The app also isn't currently localized in terms of the strings included it. We currently lack the resources to do these things properly.

I am a Chinese user and simply want to see the meaning of Chinese. This is more intuitive.
However, I have already translated it myself.
https://github.com/jiangjiali/GrapheneOS-Apps

Introduce more resources from it. I want to build a resource server myself, but I don't know the overall structure of this resource package.

The entire system is safe and concise to use. Very suitable for living alone in everything.


[QUESTION] Export with custom format.

Prerequisites
Versions

PHP version: 7.1
Laravel version:  5.5
Package version: 3.1

Description
Hello, everyone .
I'm working with the lastest version and I cant figure out how to export with a custom format.
My question is how can I have custom format for the values like when I import withMappedCells and not just the standar horizontal format, I only need to export one specific row and it should look similar to this, any advice is appreciated. Thanks

Closed.
Solved with afterSheetEvent get the values in a variable and then just set cells values in the position that I need .


dbw_fca_ros: 1.2.1-1 in 'melodic/distribution.yaml' [bloom]

Increasing version of package(s) in repository dbw_fca_ros to 1.2.1-1:

upstream repository: https://bitbucket.org/DataspeedInc/dbw_fca_ros.git
release repository: https://github.com/DataspeedInc-release/dbw_fca_ros-release.git
distro file: melodic/distribution.yaml
bloom version: 0.10.7
previous version for package: 1.2.0-1

dbw_fca

No changes

dbw_fca_can
* Bump firmware versions
* Add reserved bits
* Improve printing of license info
* Add ignition status to ThrottleInfoReport
* Add user control of alert
* Contributors: Kevin Hallenbeck

dbw_fca_description
* Modify rear wheel link inertial parameters to prevent wobbling in Gazebo
* Contributors: Micho Radovnikovich

dbw_fca_joystick_demo

No changes

dbw_fca_msgs
* Add ignition status to ThrottleInfoReport
* Add user control of alert
* Contributors: Kevin Hallenbeck

Holding for Melodic sync


fixing issue #858 (acknowledge event after subscriber callback)

Pull request type
Please check the type of change your PR introduces:

[X] Bugfix

What is the current behavior?
See issue description
Issue Number: #858
What is the new behavior?
Issue fixed. Samples cpp/orchestration/component1|component2|orchestrator can be used to test the new behavior.
Does this introduce a breaking change?

[ ] Yes
[X] No

Thank you! I was going crazy why, despite setting the ack timeout, my user callbacks did not block. Would be nice to have that released soon : )


Prevent misconfigured retention-archive setting

In light of the upcoming ottawa release I'd recommend that we either
document in the retention-archive setting that a too low configured value will result in unrestorable backups unless archive-copy is enabled
or
add a sanity check on backup (or expire?) that verifies that retention-archive[-type] >= retention-(full|diff) or  archive-copy is enabled, otherwise emit a WARN message - if that sanity check is even deterministically possible.
Ideally it shouldn't be possible for users to have required WAL files expired without their knowledge.

I'd like to fix this for Ottawa.  Stephen's suggestion was just to keep the WAL in the archive required to make the DBs consistent for any backups that don't have archive-copy turned on.  I think this is a good approach and it's not that hard to do.

:+1: on fixing it for good, wasn't sure how feasible it'd be with the current infrastructure


Missing init.py file

I'm trying to deploy MapProxy installed in virtualenv with system-wide gunicorn. For this purpose I've added the following option to gunicorn config:
CONFIG = {
    'environment': {
        'PYTHONPATH': '/home/dr/ngw/env/lib/python2.7/site-packages',
    },
    ...
}

But in this case I get an error:
Traceback (most recent call last):
  File "/usr/lib/python2.7/dist-packages/gunicorn/arbiter.py", line 473, in spawn_worker
    worker.init_process()
  File "/usr/lib/python2.7/dist-packages/gunicorn/workers/geventlet.py", line 30, in init_process
    super(EventletWorker, self).init_process()
  File "/usr/lib/python2.7/dist-packages/gunicorn/workers/base.py", line 100, in init_process
    self.wsgi = self.app.wsgi()
  File "/usr/lib/python2.7/dist-packages/gunicorn/app/base.py", line 115, in wsgi
    self.callable = self.load()
  File "/usr/lib/python2.7/dist-packages/gunicorn/app/wsgiapp.py", line 33, in load
    return util.import_app(self.app_uri)
  File "/usr/lib/python2.7/dist-packages/gunicorn/util.py", line 362, in import_app
    __import__(module)
  File "/home/dr/ngw/mapproxy/config.py", line 9, in <module>
    from mapproxy.wsgiapp import make_wsgi_app
ImportError: No module named mapproxy.wsgiapp

It happens because mapproxy package doesn't contain __init__.py file. If add it manually all works fine.

Oops, it looks like duplicate of https://github.com/mapproxy/mapproxy/issues/310


Keyword Duration affects all subsequent stimuli if using superimposition

Case A: Superimpose 2 stimuli - Pulse train lasts 2 seconds; White noise should last 15 seconds
    Time: 15 Deltat: 0.0001
   Nodes: 144

    Connection matrix:
From:  1
To 1:  0

Population 1: Stimulation
Length: 0.5
 Stimulus: Superimpose: 2
 Stimulus: Pulse - Onset: 5 Duration: 2 Node: 72 Amplitude: 8 Width: 0.05 Frequency: 0.8 Pulses: 10
 Stimulus: White - Onset: 0 Mean: 1 Psd: 1e-05

Output: Node: 72 Start: 0 Interval: 0.001
Population: 1
Dendrite:
Propagator:
Coupling:

Output:

Case B: Same parameters as Case A, except that the order of the individual stimuli was swapped.
Time: 15 Deltat: 0.0001
Nodes: 144

    Connection matrix:
From:  1
To 1:  0

Population 1: Stimulation
Length: 0.5
 Stimulus: Superimpose: 2
 Stimulus: White - Onset: 0 Mean: 1 Psd: 1e-05
 Stimulus: Pulse - Onset: 5 Duration: 2 Node: 72 Amplitude: 8 Width: 0.05 Frequency: 0.8 Pulses: 10

Output: Node: 72 Start: 0 Interval: 0.001
Population: 1
Dendrite:
Propagator:
Coupling:

Output

To work around this problem one has to set an explicit value for Duration for the white noise stimulus in Case A. However, this issue is still a bug. The parameter values of each individual stimulus should not affect the properties of other individual stimulus. Also, in superimposition mode, chaging the order of individual stimuli should  not affect the resulting stimulus because superimposition is basically an addition (stim_a + stim_b == stim_b + stim_a)

By the way, I checked if the keyword Node did the same as 'Duration'  -- ie, checked in Case A if the White Noise was only applied to node 72. It doesn't. White noise is applied to all nodes in Case A and Case B.


Improve documentation for attributes option

The attributes option on some macros is seemingly very powerful - but I'm not sure the expected format is documented anywhere.
The docs say:
"HTML attributes (for example data attributes) to add to the hint span tag."
As a new user, it would have been helpful to see something that showed the data structure needed - I had to guess it would be an object with keys.

I was hoping to use attributes to set a class on a checkbox item - but I don't think I can because there's already one. Should attributes be merged in? should it mention that there's some stuff you can't set?

@edwardhorsford I think at this point it'd be easier to consider adding 'classes' to individual items than merging attributes (as this would require Nunjucks global functions), so if you need that feel free to raise a separate issue.


IsotypeLayout (Contribution?)

Hello there,
thanks for this great library!
I've written a very rough D3.js Isotype Layout.
It takes tables and converts it into a data structure fitting to create Isotype Graphics. What's special is that it creates a data entry for every "Icon".
Here are two Screenshots:

The Code to the Layout is here: https://github.com/Fannon/isomatic/blob/master/js/isotypeLayout.js
So if you're interested I could commit this to D3.js. Of course there would be some work to do prior to this. Also it would be nice to know if i thought/did it the right way.
Greets,
Simon

Any update on this, would love to use one?

Hi!
You could include this file: https://github.com/Fannon/isomatic/blob/master/src/js/isotypeLayout.js
And it should be available. Creating Isotype graphics is not trivial however, see https://github.com/Fannon/isomatic/blob/master/src/js/views/GraphView.js how we've implemented them. There are two examples / mode in this file.. a simpler and a one more advanced one.
Simon

Great tool, thanks you.
It would be cool to support fractions, like in this example: https://twitter.com/markvitals/status/594651285464350721
I'm looking into Isomatic. Great idea with layouts, and import to SVG.
I'm working on a similar tool, just for knowledge visualization: http://annalogy.co. Looking for ways to integrate Isotype into it.

Hello Mark,
fractions are supported, but only through scaling the image size. The example you've provided looks very nice, I'd prefer this to scaling ;)
Please note that isomatic supports an "advanted" layouting algorithm, too. When browsing through the source code, you'll find both the simple and advanced version.
The actual d3.js layouter works for both.
Great to hear you like it! You're project sounds interesting!
Simon


apollo3.5 build failed

System information

OS Platform and Distribution (e.g., Linux Ubuntu 14.04): Ubuntu 16.04
Apollo installed from (source or binary): source
Apollo version (1.0, 1.5, 2.0, 2.5, 3.0): 3.5

Steps to reproduce the issue:
when I use the command  bash apollo.sh build -j 1,and build failed. And ERROR info is like this:
ERROR: (03-10 10:35:36.396) /apollo/modules/prediction/BUILD:26:1: Linking of rule '//modules/prediction:prediction_component_test' failed (Exit 1).
/usr/bin/ld: warning: libcuda.so.1, needed by<EMAIL_ADDRESS>not found (try using -rpath or -rpath-link)
Supporting materials (screenshots, command lines, code/script snippets):

+1
I have cuda installed and working properly, libcuda.so.1 is inn /usr/lib/x86_64-linux-gnu. Tried adding it to LD_LIBRARY_PATH, but still getting this error.

The problem is that I don't remove content in .cache/bazel


Patch ValidateNested()

Calling ValidateNested() on an undefined value doesn't throw anymore an error

thank you for this PR. released in 0.6.8