forge script prints Script ran successfully but finally failed

Component
Forge
Have you ensured that all of these are up to date?

[X] Foundry
[x] Foundryup

What version of Foundry are you on?
forge 0.2.0 (143abd6 2024-09-04T00:21:38.406856490Z)
What command(s) is the bug in?
forge script
Operating System
Linux
Describe the bug
Here's what I got:
# DEPLOY_CONFIG_PATH=deploy-config/getting-started.json forge script scripts/deploy/Deploy.s.sol:Deploy     --private-key $GS_ADMIN_PRIVATE_KEY     --broadcast --rpc-url $L1_RPC_URL     --slow
[⠢] Compiling...
No files changed, compilation skipped
Script ran successfully.

== Logs ==
  Writing artifact to /root/xu/devnet2/optimism/packages/contracts-bedrock/deployments/11155111-deploy.json
  Connected to network with chainid 11155111
  Commit hash: 7fc9d142a90be988595f5b8d26bb6b5f75b514a1
  DeployConfig: reading file deploy-config/getting-started.json
  Deploying a fresh OP Stack including SuperchainConfig
  start of L1 Deploy!
  Setting up Superchain
  Saving SuperchainProxyAdmin: 0xdaE97900D4B184c5D2012dcdB658c008966466DD
  Saving SuperchainConfigProxy: 0xDc82c0362A241Aa94d53546648EACe48C9773dAa
  Saving SuperchainConfig: 0x238213078DbD09f2D15F4c14c02300FA1b2A81BB
  Saving ProtocolVersionsProxy: 0x856e75e9c0Da547F9753c17746D6cc139b668e5c
  Saving ProtocolVersions: 0xd85BdcdaE4db1FAEB8eF93331525FE68D7C8B3f0
  Running chain assertions on the ProtocolVersions proxy at 0x856e75e9c0Da547F9753c17746D6cc139b668e5c
  Running chain assertions on the SuperchainConfig proxy at 0xDc82c0362A241Aa94d53546648EACe48C9773dAa
  Running chain assertions on the ProtocolVersions implementation at 0xd85BdcdaE4db1FAEB8eF93331525FE68D7C8B3f0
  Running chain assertions on the SuperchainConfig implementation at 0x238213078DbD09f2D15F4c14c02300FA1b2A81BB
  Deploying implementations
  Deploying OptimismPortal
  Saving OptimismPortal: 0xC72539408d2Fb8D5F6C8094c16B9C020c77f44F0
  OptimismPortal deployed at 0xC72539408d2Fb8D5F6C8094c16B9C020c77f44F0
  Running chain assertions on the OptimismPortal implementation at 0xC72539408d2Fb8D5F6C8094c16B9C020c77f44F0
  Guardian has no code: 0x4DC1d9948a3b5D59C3F00fa49A79780D9E51367d
  Deploying L2OutputOracle
  Saving L2OutputOracle: 0x6AAccc390fe49Ec3ffC43373b3B8A44fC3659C26
  L2OutputOracle deployed at 0x6AAccc390fe49Ec3ffC43373b3B8A44fC3659C26
  Running chain assertions on the L2OutputOracle implementation at 0x6AAccc390fe49Ec3ffC43373b3B8A44fC3659C26
  Saving L1CrossDomainMessenger: 0x2CfFF1c8Df8CE2BA6CBa19699CCBa6F381734938
  Saving OptimismMintableERC20Factory: 0x89c88ED20d4b742185185f77017182247671eE3b
  Saving SystemConfig: 0xE3dF61CA9F27cd66880325f3C6CB789EDe857997
  Saving L1StandardBridge: 0x3857b6c6f162fDA9BD591D4CCDEF8C00093cC357
  Saving L1ERC721Bridge: 0x2AC24b15a2Ded48F4B51e70293589058546a11FE
  Saving OptimismPortal2: 0x8237f181A3A8C7f871174e85f499f71f2A0d5B75
  Saving DisputeGameFactory: 0x8a1a5F20ADF3005022049880f799FBBF2a188cfC
  Saving DelayedWETH: 0xec557124625E001dfe2d23ddA4F48A291E8a3e3a
  Saving PreimageOracle: 0xc043F015EB8cA0b94D4cAde622ed7369ce4ffE4E
  Saving Mips: 0x9848e4470F89bec8b050eCDf93F69B8660B6046C
  Saving OPContractsManagerProxy: 0x5b66F1D2dC2691F9bcac54Ee8B90a9923701e553
  Saving OPContractsManager: 0xb32a4b81244fEd6A176f295A4787cC9cce687a5e
  Running chain assertions on the L1CrossDomainMessenger implementation at 0x2CfFF1c8Df8CE2BA6CBa19699CCBa6F381734938
  Running chain assertions on the L1StandardBridge implementation at 0x3857b6c6f162fDA9BD591D4CCDEF8C00093cC357
  Running chain assertions on the L1ERC721Bridge
  Running chain assertions on the L1ERC721Bridge implementation at 0x2AC24b15a2Ded48F4B51e70293589058546a11FE
  Running chain assertions on the OptimismPortal2 implementation at 0x8237f181A3A8C7f871174e85f499f71f2A0d5B75
  Guardian has no code: 0x4DC1d9948a3b5D59C3F00fa49A79780D9E51367d
  Running chain assertions on the OptimismMintableERC20Factory implementation at 0x89c88ED20d4b742185185f77017182247671eE3b
  Running chain assertions on the DisputeGameFactory implementation at 0x8a1a5F20ADF3005022049880f799FBBF2a188cfC
  Running chain assertions on the DelayedWETH implementation at 0xec557124625E001dfe2d23ddA4F48A291E8a3e3a
  Running chain assertions on the PreimageOracle 0xc043F015EB8cA0b94D4cAde622ed7369ce4ffE4E at %s
  Running chain assertions on the MIPS 0x9848e4470F89bec8b050eCDf93F69B8660B6046C at %s
  Running chain assertions on the SystemConfig implementation at 0xE3dF61CA9F27cd66880325f3C6CB789EDe857997
  Deploying OP Chain
  Saving ProxyAdmin: 0x069c6dD931085DfC6130f4e67cDD75c5391428Da
  Saving AddressManager: 0x2252025f59752F9f66beB068c86E350A4b78B3DD
  Saving L1ERC721BridgeProxy: 0xF2661ff94f3435ef5c6ab7a702ccCA4bb6CC3136
  Saving SystemConfigProxy: 0xd4bDB671255b762bf8256c764299E68e228c3f9f
  Saving OptimismMintableERC20FactoryProxy: 0x46Ad87603E34a2a449920e7412AF3dFcB1571f2E
  Saving L1StandardBridgeProxy: 0x811226aA31200eA6a314ba1D3d7B48708848F439
  Saving L1CrossDomainMessengerProxy: 0x77fc41C95B29F86A1A59aD7E875Fc75dEa14BD3E
  Saving DisputeGameFactoryProxy: 0xeC273fd0D132f1681A7a560DF7BBF77C50C326F8
  Saving PermissionedDelayedWETHProxy: 0x1781064D5f6c320E3dB832B0EaFeFFb399CabE75
  Saving AnchorStateRegistryProxy: 0x878d3007e14a5b9ef62247711c73E1DB140f12f0
  Saving AnchorStateRegistry: 0xD9d495ADB1E7702e4c8cfA9b6D3bBA68E138e9de
  Saving PermissionedDisputeGame: 0x775C2edfF536c948094C19c7EaCBC381427D105c
  Saving OptimismPortalProxy: 0x13E60e349b0a4218B17A278bf140aeD2148C0568
  Deploying DelayedWETHProxy
  Saving DelayedWETHProxy: 0xA0966d00977F294CB6F65eF25Eef48Caacdf6c17
  DelayedWETHProxy deployed at 0xA0966d00977F294CB6F65eF25Eef48Caacdf6c17
  Setting Cannon FaultDisputeGame implementation
  [Cannon Dispute Game] Using absolute prestate from config: 0x3c7ae758795765c6664a5d39bf63841c71ff191e9189522bad8ebff5d4eca98
  Deploying FaultDisputeGame_0
  Saving FaultDisputeGame_0: 0xdc0b0dE0aEF85c2fc6BDe6227b66250E843c8406
  FaultDisputeGame_0 deployed at 0xdc0b0dE0aEF85c2fc6BDe6227b66250E843c8406
  DisputeGameFactoryProxy: set `FaultDisputeGame` implementation (Backend: Cannon | GameType: 0)
  Transferring DisputeGameFactory ownership to Safe
  Running chain assertions on the DisputeGameFactory proxy at 0xeC273fd0D132f1681A7a560DF7BBF77C50C326F8
  Transferring DelayedWETH ownership to Safe
  Running chain assertions on the DelayedWETH proxy at 0xA0966d00977F294CB6F65eF25Eef48Caacdf6c17
  Transferring permissioned DelayedWETH ownership to Safe
  Running chain assertions on the PermissionedDelayedWETH proxy at 0x1781064D5f6c320E3dB832B0EaFeFFb399CabE75
  Deploying L2OutputOracleProxy
  Saving L2OutputOracleProxy: 0x08FDcA98449845D36514839B1c9E7340601e79FC
  L2OutputOracleProxy deployed at 0x08FDcA98449845D36514839B1c9E7340601e79FC
  Upgrading and initializing L2OutputOracle proxy
  L2OutputOracle version: 1.8.1-beta.2
  Running chain assertions on the L2OutputOracle proxy at 0x08FDcA98449845D36514839B1c9E7340601e79FC
  resetting initialized value on OptimismPortal Proxy
  Upgrading and initializing OptimismPortal proxy
  OptimismPortal version: 2.8.1-beta.4
  Running chain assertions on the OptimismPortal proxy at 0x13E60e349b0a4218B17A278bf140aeD2148C0568
  Guardian has no code: 0x4DC1d9948a3b5D59C3F00fa49A79780D9E51367d
  set up op chain!

## Setting up 1 EVM.

Failed with `custom error 86bb51b8:000000000000000000000000856e75e9c0da547f9753c17746d6cc139b668e5c`:

  [192] SuperchainProxyAdmin::upgradeAndCall(SuperchainConfigProxy: [0xDc82c0362A241Aa94d53546648EACe48C9773dAa], SuperchainConfigImpl: [0x238213078DbD09f2D15F4c14c02300FA1b2A81BB], 0x400ada750000000000000000000000004dc1d9948a3b5d59c3f00fa49a79780d9e51367d0000000000000000000000000000000000000000000000000000000000000000)
    └─ ← [Revert] EvmError: Revert

  [192] SuperchainProxyAdmin::upgradeAndCall(ProtocolVersionsProxy: [0x856e75e9c0Da547F9753c17746D6cc139b668e5c], ProtocolVersionsImpl: [0xd85BdcdaE4db1FAEB8eF93331525FE68D7C8B3f0], 0x7a1ac61e0000000000000000000000004dc1d9948a3b5d59c3f00fa49a79780d9e51367d00000000000000000000000000000000000000000000000000000000000000010000000000000000000000000000000000000000000000000000000000000001)
    └─ ← [Revert] EvmError: Revert

  [2559] SuperchainProxyAdmin::transferOwnership(0x4DC1d9948a3b5D59C3F00fa49A79780D9E51367d)
    └─ ← [Revert] revert: Ownable: caller is not the owner

  [5855] → new <unknown>@0x639254B88fFe9F4443FB26690E354Ae7f9219347
    └─ ← [Revert] AddressHasNoCode(0x856e75e9c0Da547F9753c17746D6cc139b668e5c)

  [29064] Proxy::upgradeToAndCall(DelayedWETHImpl: [0xec557124625E001dfe2d23ddA4F48A291E8a3e3a], 0x485cc9550000000000000000000000004dc1d9948a3b5d59c3f00fa49a79780d9e51367d000000000000000000000000dc82c0362a241aa94d53546648eace48c9773daa)
    ├─ emit Upgraded(implementation: DelayedWETHImpl: [0xec557124625E001dfe2d23ddA4F48A291E8a3e3a])
    ├─ [190] DelayedWETHImpl::initialize(0x4DC1d9948a3b5D59C3F00fa49A79780D9E51367d, SuperchainConfigProxy: [0xDc82c0362A241Aa94d53546648EACe48C9773dAa]) [delegatecall]
    │   └─ ← [Revert] EvmError: Revert
    └─ ← [Revert] revert: Proxy: delegatecall to new implementation contract failed

  [48777] Create2Deployer::create2()
    ├─ [4005] → new FaultDisputeGame@0xdc0b0dE0aEF85c2fc6BDe6227b66250E843c8406
    │   ├─ [0] MIPSSingleton::oracle() [staticcall]
    │   │   └─ ← [Stop]
    │   └─ ← [Revert] EvmError: Revert
    └─ ← [Revert] EvmError: Revert

Error:
Simulated execution failed.

Initially it printed Script ran successfully. and actually printed all console logs successfully, but in the end it reports Simulated execution failed..
Looks like Script ran successfully. is printed during presimulation process, which succeeded. But later on the simulated execution failed.
So I think there's some inconsistency between the two processes.
UPDATE
After I run foundryup, the error changed:

First error is a misunderstanding of Script ran successfully, it indicates that the script itself does not contain any errors (builds and runs correctly). I would be open to changing this
Second error is possible related to https://github.com/foundry-rs/foundry/issues/8995#issuecomment-2388009238

First error is a misunderstanding of Script ran successfully, it indicates that the script itself does not contain any errors (builds and runs correctly). I would be open to changing this
Second error is possible related to #8995 (comment)

So the first error means the genesis simulation works but live simulation failed, it depends on the contract's own logic, nothing to do with foundry,  right?

That is correct, Script ran successfully is logged before any simulation is done and is part of the preparation steps before simulation. As you mentioned, it can be easily interpreted as if the entire execution has succeeded as it does not accurately describes this.

OK, I think it's an issue with Deploy.s.sol itself, which is being deprecated by op-deployer.


adding test pipeline

@phemankita, this looks good for now if you have tested and validated the pipeline is working.
When we look to adopt the kustomize format of the gitops repo, we should revisit the following:

Rename the pipeline to follow similar pattern of what we have done in ace with the naming convention mq-promote-dev-stage
Review if img-info task is still needed
Update dev-instance-tests as it should be a placeholder to run tests (ie. postman test via newman)
Run pipeline in the ci namespace
Remove the need for the following secrets: gitops-cd-secret and argocd-acces-creds


Monolithic tools

It might make more sense to move this over to the Library versus v5.1.
Thoughts? :thought_balloon:

:+1:

Closing and moving to Library https://github.com/mvcss/library/issues/8


Critical SEO Tag Implementation Issues: missing tags which effect Search Engine Visibility and Performance

What happened?
Description
SEO tags play a crucial role in optimizing web pages for search engines and improving their visibility in Google rankings. However, some pages in the application are currently lacking essential SEO tags, which can hinder their performance in search engine results pages (SERPs).
examples-
Lack of Metadata
Missing Alt Attributes
Lack of Structured Data (Schema.org markup)
XML Sitemap many more
plz assign me this task under GSSOC-2023
Screenshots

Additional information
By adding important SEO tags such as meta titles, meta descriptions, and heading tags to our web pages, we can provide search engines with relevant information about the content and context of each page. These tags help search engines understand the purpose of our pages and match them with relevant user queries.
Benefits:
Improved Search Engine Visibility: Including SEO tags ensures that search engines can effectively crawl and index our web pages, leading to better visibility in search results.
Higher Click-Through Rates (CTR): Well-optimized meta titles and descriptions can attract users' attention in search results, increasing the likelihood of them clicking on our pages.
Enhanced User Experience: SEO tags, such as heading tags, help structure the content on our pages, making it more organized and user-friendly. This improves the overall user experience and encourages visitors to spend more time on our site.
Targeted Keyword Optimization: By strategically incorporating relevant keywords in our SEO tags, we can align our content with user search intent and improve our rankings for specific queries.
To enhance the SEO performance and indexing of our pages, it is essential to implement these missing SEO tags across the application. This will help us rank higher in Google search results, attract more organic traffic, and ultimately improve the overall success of our website.
How can we reproduce this bug?
go in the index.html see in the head section the main tags are missing which are required for boosting the SEO, indexing, ranking in browser
examples-
Lack of Metadata
Missing Alt Attributes
Lack of Structured Data (Schema.org markup)
XML Sitemap many more
Desktop Information (Optional)
No response
Urgency (Optional)
High priority

Already added, you can add more

I have made significant improvements to the SEO and search indexing of the website by implementing the necessary meta tags and tags. Previously, there were few meta tags but they did not directly contribute to SEO but now the website is equipped with a comprehensive set of SEO settings.
Meta tags:

robots: Specifies how search engine crawlers should interact with and index your website.
language: Indicates the language of your website's content.
revisit-after: Instructs search engine crawlers when to revisit your website for updates.
distribution: Specifies the global distribution of your website's content.
geo.region: Defines the geographical region targeting for your website.
googlebot: Provides instructions to Google's search crawler on how to index your website's content.
content-language: Specifies the primary language of your website's content.
description: Provides a concise summary of your website's content.
keywords: Lists relevant keywords related to your website's content.

social media tags:

canonical: Specify the canonical URL for your webpage to avoid duplicate content issues.
Open Graph protocol: Enhances how your webpage appears when shared on social media platforms.
twitter:card: Specifies the type of Twitter card to be used when your webpage is shared.
twitter:site: Identifies the Twitter account associated with your website.
twitter:image: Specifies the image to be displayed when your webpage is shared on Twitter.

JSON-LD : to provide structured data for search engines, conveying essential information about the website, including its type, headline, description, author, publication date, image, publisher, a main entity of the page, keywords, URL, article section, article body, language, accessibility, and its association with creative work.
These changes collectively improve the website's SEO, searchability, and indexing capacity. The website will now be more effectively crawled and indexed by search engines, leading to increased organic traffic and better visibility in search results.
Screenshots

i request to create a pull request

@agamjotsingh18 plz review the change and give permission for pull request

@agamjotsingh18 plz review the changes

@agamjotsingh18 plz review the changes.


Clear out Model wrapper code

Fixes #300
Overview
Opening a draft PR to be lazy and iterate with CI and use the GH diffs
Discussion
Any additional context that you think is important for reviewers or future users/contributors looking at this PR.
Testing
How did you test this? If a reviewer pulled this branch down and wanted to kick the tires, how would they do so?
Documentation
Does this PR update any docs pages? Should it?

:books: Documentation preview :books:: https://garden-ai--303.org.readthedocs.build/en/303/

Codecov Report

Merging #303 (eb0f2cf) into main (acb4f4a) will increase coverage by 3.65%.
The diff coverage is 54.54%.

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.
@@            Coverage Diff             @@
##             main     #303      +/-   ##
==========================================
+ Coverage   73.35%   77.01%   +3.65%
==========================================
  Files          52       48       -4
  Lines        3765     3102     -663
==========================================
- Hits         2762     2389     -373
+ Misses       1003      713     -290

Files
Coverage Δ

garden_ai/__init__.py
100.00% <ø> (ø)

garden_ai/app/model.py
89.58% <100.00%> (+1.05%)
:arrow_up:

garden_ai/backend_client.py
42.10% <100.00%> (-1.56%)
:arrow_down:

garden_ai/client.py
64.54% <100.00%> (+7.76%)
:arrow_up:

garden_ai/constants.py
100.00% <ø> (ø)

garden_ai/mlmodel.py
91.66% <100.00%> (+22.30%)
:arrow_up:

garden_ai/pipelines.py
82.05% <ø> (-0.04%)
:arrow_down:

tests/cli/test_model.py
100.00% <ø> (ø)

tests/conftest.py
95.80% <100.00%> (+0.48%)
:arrow_up:

tests/integrations/test_pipeline_registration.py
50.00% <ø> (+14.81%)
:arrow_up:

... and 4 more

... and 1 file with indirect coverage changes

https://en.m.wikipedia.org/wiki/File:Pouring_one_out.gif


Filters are not working

When i tried to use the filter function it returns an error "Internal Error: Controller not found"

maybe this issue: https://github.com/fguillot/kanboard/issues/2298 ?

Thanks! it works


Remove dependency to archived cncf/contribute repository

Remove dependency to archived cncf/contribute repository.
Although I wasn't there, what I understand from the Git history and the magefile is that it was added as a temporary dependency. See the old commit message here: https://github.com/cncf/tag-contributor-strategy/commit/c5bba84a15afa943e028d84b3de6a4c4a6039588
Changes:

Removed the code that was creating a volume mount for cncf/contribute repository,
Similarly, removed the volume mount for a local Go mod file. This file was used for the replacement of cncf/contribute with a local repository, in a development setup.
Removed Go dependency to cncf/contribute
Added a short instruction in website/content/about/contributing.md file about "Comparing the before and after of your big changes". I used this approach to test if my changes break anything or change any content.

NOTE: Might be easier to review commit by commit

I don't know who to ping for this PR anymore 😢

Assigned me.


feat(codepipeline): add new check codepipeline_project_repo_private

Context
This PR introduces a critical security enhancement for AWS CodePipeline by implementing automated verification of repository visibility. This check helps organizations protect sensitive deployment configurations and mitigate potential supply chain attack vectors by ensuring the use of private repositories.
Description
The implementation includes:

A new security check codepipeline_project_repo_private that:

Validates repository visibility in CodePipeline projects
Supports both GitHub and GitLab repositories through CodeStar Connections

Example Output

Core components:

codepipeline_client.py: Client interface implementation
codepipeline_service.py: Service layer with pipeline state management
codepipeline_project_repo_private.py: Main check implementation
metadata.json: Check specifications and security context

Technical implementation highlights:

Integration with AWS CodeStar Connections API
Automated repository visibility detection
Comprehensive error handling and logging

Required Permissions
The check requires the following AWS permissions:

CodePipeline: ListPipelines, GetPipeline
CodeStar Connections: GetConnection

Checklist

Are there new checks included in this PR? Yes

If so, do we need to update permissions for the provider? Yes, CodePipeline and CodeStar Connections permissions are required.

[x] Review if the code is being covered by tests.
[x] Review if code is being documented following this specification https://github.com/google/styleguide/blob/gh-pages/pyguide.md#38-comments-and-docstrings
[ ] Review if backport is needed.

License
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Thanks for this new check @yyyy7246! Could you please add the tests to cover the new service and the check? You can copy the tests from another one, I can help you if you need help, here you can find documentation about the unit testing in Prowler.

Thanks for this new check @yyyy7246! Could you please add the tests to cover the new service and the check? You can copy the tests from another one, I can help you if you need help, here you can find documentation about the unit testing in Prowler.

Thank you for the feedback and guidance!
I have added the unit tests to cover both the new service and the check. These tests include scenarios for both private and public repositories, as well as checks for multiple repository providers (e.g., GitHub and GitLab). The tests can be found in the following files:

tests/providers/aws/services/codepipeline/codepipeline_service_test.py
tests/providers/aws/services/codepipeline/codepipeline_project_repo_private/codepipeline_project_repo_private_test.py

Please let me know if there are any additional scenarios or improvements you'd like me to include. I’d be happy to address them!

please @yyyy7246, review my comments. Thanks!

Hi MrCloudSec,
Thank you so much for taking the time to review my pull request and provide such detailed feedback. I truly appreciate your guidance.
I have addressed the changes you requested, including:

Refactoring the check logic to avoid direct boto3 calls:
Instead of using boto3 within codepipeline_project_repo_private.py, I created a dedicated service class in codepipeline_service.py to handle the logic, following the recommended architecture pattern.

Improving source configuration handling and tags assignment:
In codepipeline_service.py, I’ve made the code more structured and applied your suggested improvements for assigning pipeline.tags.

Updating the metadata file:
I revised the codepipeline_project_repo_private.metadata.json file to accurately reflect the new check, including an updated description, risks, and remediation steps.

I also want to clarify the force-push action: I initially misunderstood its impact. Fortunately, it didn’t cause any issues, and I’ll be more cautious about such actions in the future.
Thank you again for your thorough review and helpful suggestions. If there’s anything else you’d like me to adjust or improve, please let me know.
Warm regards,
yyyy7246

Please, review my comments @yyyy7246

Thank you for the feedback, @MrCloudSec. I've updated the code to use the list_tags_for_resource API as suggested. This change should now properly handle the retrieval of tags.
Please let me know if there's anything else that needs adjustment. Thanks for your guidance!


PUT a custom role assignment created by az cli

I have a custom role definition at a subscription level, it is assigned to an msi by az cli.
I want to move from az cli to Bicep / ARM: but I can't grandfather the assignment ids because az cli creates new ones every time.
Using this template:
@description('MSI Resource ID')
param msiResourceId string

targetScope = 'subscription'

// Reference the existing msi
var msiSubscriptionId = split(msiResourceId, '/')[2]
var msiResourceGroup = split(msiResourceId, '/')[4]
var msiResourceName = split(msiResourceId, '/')[8]

resource msi 'Microsoft.ManagedIdentity/userAssignedIdentities@2018-11-30' existing = {
  scope: resourceGroup(msiSubscriptionId, msiResourceGroup)
  name: msiResourceName
}

// Reference the existing roleDefinition
var roleName = 'My custom role ${subscription().subscriptionId}'

resource roleDefinition 'Microsoft.Authorization/roleDefinitions@2022-04-01' existing = {
  name: guid(roleName)
  scope: subscription()
}

// Create the role assignment
resource roleAssignment 'Microsoft.Authorization/roleAssignments@2020-04-01-preview' = {
  name: guid(subscription().id, roleDefinition.id, msi.id)
  properties: {
    roleDefinitionId: roleDefinition.id
    principalId: msi.properties.principalId
    principalType: 'ServicePrincipal'
  }
}

Fails with :
{"status":"Failed","error":{"code":"DeploymentFailed","target":"/subscriptions/<sub id>/providers/Microsoft.Resources/deployments/roleDefinitionDeployment","message":"At least one resource deployment operation failed. Please list deployment operations for details. Please see https://aka.ms/arm-deployment-operations for usage details.","details":[{"code":"RoleAssignmentExists","message":"The role assignment already exists."}]}}

Because the id of the role assignment GUID does not match what bicep builds.
I cannot do a create-if-not-exist either, because that is not supported by ARM / Bicep.
Any solution?

The az cli code that was used to create the role assignment is something like:
az role assignment create --subscription "<my sub name>" --scope "subscriptions/<sub id>" --role "My custom role sub-id" --assignee <principal-id>

if you add --debug and run that, then delete the role, then run again, you will see that it generates different GUIDs for the role assignment id every time.

Unfortunately I don't think this is a problem we can solve easily with Bicep itself. I think the best options today are to either:

Track down and delete the original role assignment so that you can re-create it in Bicep
Hard-code the AzureCLI-created role assignment names for any assignments you've migrated to Bicep


Demo server down

http://jingo.cica.li:6067/wiki/home gives

This webpage is not available
ERR_CONNECTION_REFUSED

Hi, thanks for pointing this out but it's working for me.

Must've been temporary. Or maybe it was the corporate network. I can reach it from home, now. I'll try again at the office just to see if that makes any difference.

Actually, I think it is because of the abnormal port. My client's IT policies are almost certainly preventing access to port 6067.
You might consider (if possible) an nginx configuration that forwards port 80 to 6067, which would also be great to have documented. That's the setup we are considering--with jingo installed locally rather than globally--and it would be great to have an example.
Anyway, I understand if you close this issue as "won't fix", but it would be great to have the demo on a server at port 80.

Good to know :)
Regarding the documentation about reverse-proxying jingo, you can read something about in the wiki


Update BPF's anonymous structures

Codecov Report

Merging #1407 into master will decrease coverage by 0.07%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #1407      +/-   ##
==========================================
- Coverage   57.83%   57.75%   -0.08%
==========================================
  Files         131      131
  Lines       24851    24851
==========================================
- Hits        14372    14353      -19
- Misses       9809     9827      +18
- Partials      670      671       +1

Impacted Files
Coverage Δ

prog/target.go
55% <0%> (-7.15%)
:arrow_down:

prog/mutation.go
93.9% <0%> (-1.38%)
:arrow_down:

prog/rand.go
86.09% <0%> (-0.38%)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ad847b9...0be3dc7. Read the comment docs.


Docs Failed to build

Updated the docs in https://github.com/IBM/nodejs-itoolkit/pull/346
Then it failed to build with:
Traceback (most recent call last):
  File "/home/docs/.pyenv/versions/3.7.9/lib/python3.7/runpy.py", line 193, in _run_module_as_main
    "__main__", mod_spec)
  File "/home/docs/.pyenv/versions/3.7.9/lib/python3.7/runpy.py", line 85, in _run_code
    exec(code, run_globals)
  File "/home/docs/checkouts/readthedocs.org/user_builds/nodejs-itoolkit/envs/latest/lib/python3.7/site-packages/sphinx/__main__.py", line 5, in <module>
    from sphinx.cmd.build import main
  File "/home/docs/checkouts/readthedocs.org/user_builds/nodejs-itoolkit/envs/latest/lib/python3.7/site-packages/sphinx/cmd/build.py", line 18, in <module>
    from sphinx.application import Sphinx
  File "/home/docs/checkouts/readthedocs.org/user_builds/nodejs-itoolkit/envs/latest/lib/python3.7/site-packages/sphinx/application.py", line 24, in <module>
    from sphinx.config import Config
  File "/home/docs/checkouts/readthedocs.org/user_builds/nodejs-itoolkit/envs/latest/lib/python3.7/site-packages/sphinx/config.py", line 16, in <module>
    from sphinx.util.tags import Tags
  File "/home/docs/checkouts/readthedocs.org/user_builds/nodejs-itoolkit/envs/latest/lib/python3.7/site-packages/sphinx/util/tags.py", line 3, in <module>
    from jinja2 import nodes
  File "/home/docs/checkouts/readthedocs.org/user_builds/nodejs-itoolkit/envs/latest/lib/python3.7/site-packages/jinja2/__init__.py", line 12, in <module>
    from .environment import Environment
  File "/home/docs/checkouts/readthedocs.org/user_builds/nodejs-itoolkit/envs/latest/lib/python3.7/site-packages/jinja2/environment.py", line 25, in <module>
    from .defaults import BLOCK_END_STRING
  File "/home/docs/checkouts/readthedocs.org/user_builds/nodejs-itoolkit/envs/latest/lib/python3.7/site-packages/jinja2/defaults.py", line 3, in <module>
    from .filters import FILTERS as DEFAULT_FILTERS  # noqa: F401
  File "/home/docs/checkouts/readthedocs.org/user_builds/nodejs-itoolkit/envs/latest/lib/python3.7/site-packages/jinja2/filters.py", line 13, in <module>
    from markupsafe import soft_unicode
ImportError: cannot import name 'soft_unicode' from 'markupsafe' (/home/docs/checkouts/readthedocs.org/user_builds/nodejs-itoolkit/envs/latest/lib/python3.7/site-packages/markupsafe/__init__.py)

Related:
https://github.com/mozilla/sphinx-js/issues/190


[ng9.1.1] stuck on 95% emitting index-html-webpack-plugin

🐞 Bug report
Command (mark with an x)

[ ] new
[ ] build
[x] serve
[ ] test
[ ] e2e
[ ] generate
[ ] add
[ ] update
[ ] lint
[ ] xi18n
[ ] run
[ ] config
[ ] help
[ ] version
[ ] doc

Is this a regression?

 Yes, the previous version in which this bug was not present was: 9.0.2
Description
When i am using this package https://github.com/akserg/ng2-slim-loading-bar
It has old rxjs import path after altering that in __ivy__ngcc/src/slim-loading-bar.service,js it will always stuck at 95%
🔬 Minimal Reproduction

🔥 Exception or Error

ERROR in ./node_modules/ng2-slim-loading-bar/__ivy_ngcc__/src/slim-loading-bar.service.js
Module not found: Error: Can't resolve 'rxjs/Subject' in 'D:\project\node_modules\ng2-slim-loading-bar\__ivy_ngc

i changed import path there it will always stuck at 95%

🌍 Your Environment

ng version

     _                      _                 ____ _     ___
    / \   _ __   __ _ _   _| | __ _ _ __     / ___| |   |_ _|
   / △ \ | '_ \ / _` | | | | |/ _` | '__|   | |   | |    | |
  / ___ \| | | | (_| | |_| | | (_| | |      | |___| |___ | |
 /_/   \_\_| |_|\__, |\__,_|_|\__,_|_|       \____|_____|___|
                |___/

Angular CLI: 9.1.1
Node: 10.16.3
OS: win32 x64

Angular: 9.1.2
... animations, common, compiler, compiler-cli, core, forms
... language-service, localize, platform-browser
... platform-browser-dynamic, router
Ivy Workspace: Yes

Package                           Version
-----------------------------------------------------------
@angular-devkit/architect         0.901.1
@angular-devkit/build-angular     0.901.1
@angular-devkit/build-optimizer   0.901.1
@angular-devkit/build-webpack     0.901.1
@angular-devkit/core              9.1.1
@angular-devkit/schematics        9.1.1
@angular/cdk                      9.2.0
@angular/cli                      9.1.1
@angular/material                 9.2.0
@ngtools/webpack                  9.1.1
@schematics/angular               9.1.1
@schematics/update                0.901.1
rxjs                              6.5.4
typescript                        3.8.3
webpack                           4.42.0

Anything else relevant?

even if i changed rxjs import path before ivy compiling then also its stuck on 95%

This seems like a bug but we'll need to look at a reproduction to find and fix the problem. Can you setup a minimal repro please?
You can read here why this is needed. A good way to make a minimal repro is to create a new app via ng new repro-app and adding the minimum possible code to show the problem. Then you can push this repository to github and link it here.
This might be related to your directory structure so its really important to get an accurate repro to diagnose this.

now even after removing that package still it is stuck on 95%, yesterday night everything was working perfectly.

@indraraj26, I am not sure what's going on here. I suggest to revert any changes done and go back to a working state. If you added a new node package, remove it from the package.json, remove node_modules and do a fresh install.
After that try to create minimal reproduction show casing the issue. A good way to make a minimal repro is to create a new app via ng new repro-app and adding the minimum possible code to show the problem. Then you can push this repository to github and link it here.
This might be related to your directory structure so its really important to get an accurate repro to diagnose this.

Hi @alan-agius4 , yes if i rollback to old commits which was merged by other guy in morning then it is working fine. If i checked his merge changes there is no extra package installed.

In that case, it must have been something which is related to the code.
If you can determine what piece of code resulted in the un-actionable error it would be great so we can determine if we can do anything from our end.
Thanks.

Hi @alan-agius4 , Thank you for your instant support.
What i have done its working now btw i am not able to reproduce 😞
git reset --hard oldcommit
git merge featureBranch
npm start


fix: icx-proxy panic when decoding a response to http_request

Candid 0.7.1 does not support decoding a Record into an IDLValue.  We were using this in an unsupported way with Candid 0.6.x, but it doesn't work anymore.
So, this commit specifies the exact type of the streaming http response token.  Unfortunately, this means that we will no longer support arbitrary token types, but this is the best that we can do until Candid supports generic types: https://github.com/dfinity/candid/issues/245

Does this fix https://github.com/dfinity/agent-rs/issues/203?

Does this fix #203?

Yes, I think it will.  We were running into errors like thread 'tokio-runtime-worker' panicked at 'internal error: entered unreachable code', /sources/candid-0.7.1/src/types/subtype.rs:116:25


Folders opening in wrong window

OSX HighSierra (10.13.6 Beta)   VSCode - Version 1.24.1 (1.24.1)
Recently quite frequently vs code has got into a state where it is opening things in the "wrong" window. For example I have two windows open, click on a recent link in the Welcome tab in one window and it opens in the other.. Another symptom when it is in this state is that launching via new window from the dock doesn't create a new window but reuses one already open. When this happens I have to close all windows to recover normal behaviour. I cannot remember ever seeing this happen before the last update. I also haven't seen it happen on ubuntu, only OSX. Has anyone else had window strangeness recently?

Update, so I think i found reproducible steps.
Open first window, drag it to second monitor and full screen it.
then go back to first monitor and try to open a second window. (it will reuse the first fullscreen window)
If i don't fullscreen the window all works ok.

@monkeygroover so all of this only reproduces if one window is fullscreen, is that right?

Yes I think that appears to be the case. I can't get it to happen if no windows are in fullscreen mode. Not sure if it being on a second monitor is relevant or not, i'll test that when i get a moment.

Yes It does require multiple displays. If i have a window fullscreen on a single display I see no issues. As soon as i drag that fullscreen window onto a second display then the problem occurs.

Open for help if someone wants to look into this. It could be an upstream issue too.

@monkeygroover your steps:

Open first window, drag it to second monitor and full screen it.
then go back to first monitor and try to open a second window. (it will reuse the first fullscreen window)

This is expected, VSCode does not really know on which monitor you are, so it will open a new window on the monitor of the last active VSCode window. If you have a window opened in the first monitor which is most recently used and try this, the window should open correctly on that monitor.

Yes in full-screen that matches what I see. However in windowed mode the new window always opens on the desktop of the dock that I launched new window from no matter what order I do it in or what has focus.

@monkeygroover are you maybe using sierra native window tabs?

It appears I am (didn't even know about the option!) however with that off + whatever changed a month or so back this is now working as I would expect.
Thanks!


WIP Feature/schema docs

Context
As we request data from participants, we'll need to agree a format for them to submit it.
This PR proposes that format in the standard OpenAPI spec style.
It then takes that information and uses it to generate a documentation page, via some Pydantic models.
Changes proposed in this pull request
Lots! This isn't ready for review yet and should probably be broken down into two or three PRs

Create the spec
Turn the spec into Pydantic models using datamodel-code-generator (May be premature: these objects are handy for rendering docs, and we'll need them when we parse user input... tho JSON schema would do for now)
Render the schemas out of the spec (tests still required for the RenderableSchema decorator and more on the end to end test)
Turn the pydantic models into JSON schemas 😅
Use json-schema-faker to generate some example data
Render that on the page too, along with the schemas.
Changelog! 👊

ALSO

fix gunicorn which didn't have reload enabled locally - will pull this into separate PR

Result:

Guidance to review
Not in detail yet! If any of this seems crazy, though, please say so
Link to JIRA ticket
https://technologyprogramme.atlassian.net/jira/software/projects/CON/boards/418?selectedIssue=CON-21
Things to check

[X] I have added any new ENV vars in all deployed environments and updated the .env.example and .env.test files in the repo

The frontend looks great, @duncanjbrown. Just one comment on a tiny fix for the sub-headings within "Entities".


Unable to settle invoice created via addholdinvoice

Background
Unable to settle an invoice created via addholdinvoice.
Your environment

lnd version 0.7.1-beta commit=v0.7.1-beta
4.15.0-50-generic Ubuntu x86_64 Linux
bitcoind - Bitcoin Core Daemon version v0.17.1
bitcoin testnet

Steps to reproduce
Generate secret and hash using the following node.js script:
const crypto = require('crypto');
const secret = crypto.randomBytes(32).toString('hex');
const hash = crypto.createHash('sha256').update(secret).digest('hex');
console.log({secret, hash});

Sample output:
{
  "secret": "2d2cd0ca5c4c49e12f972ff090be63b989f1b605d9d6c1efc73488511f172383",
  "hash": "c8e0a9c20bcbab325ccae5ae23a73d4c44687e00f4e44f6662d5a1fa63b017b0"
}

Create a hold invoice via bash command (providing the hash):
lncli --network=testnet addholdinvoice --memo="test hodl invoice" c8e0a9c20bcbab325ccae5ae23a73d4c44687e00f4e44f6662d5a1fa63b017b0

Initiate payment from the payer's node.
The invoice can be found via lookupinvoice:
lncli --network=testnet lookupinvoice c8e0a9c20bcbab325ccae5ae23a73d4c44687e00f4e44f6662d5a1fa63b017b0

The state is "accepted".
Finally try to settle the invoice from the payee's node:
lncli --network=testnet settleinvoice 2d2cd0ca5c4c49e12f972ff090be63b989f1b605d9d6c1efc73488511f172383

The following error occurs:
[lncli] rpc error: code = Unknown desc = unable to locate invoice

Expected behaviour
The invoice should be settled.
Actual behaviour
An error occurs and the invoice remains in the "accepted" state.
Canceling the invoice works:
lncli --network=testnet cancelinvoice c8e0a9c20bcbab325ccae5ae23a73d4c44687e00f4e44f6662d5a1fa63b017b0

This error is expected if the secret doesn't hash to the payment hash.

I have discovered the problem: I was hashing the hex-encoded string value of the secret instead of the byte array. For example:
const crypto = require('crypto');
const secret = crypto.randomBytes(32);
const hash = crypto.createHash('sha256').update(secret).digest('hex');
const wrongHash = crypto.createHash('sha256').update(secret.toString('hex')).digest('hex');
console.log({
	secret: secret.toString('hex'),
	hash,
	wrongHash,
});

In the above code, the values of hash and wrongHash are different. I tried the whole flow again but with the correct hash and now I am able to settle the invoice as expected.

Cool. Closing then.


[Question] : How to add a default header map to HttpClientBuilder?

Hi, thank you for your work in creating this project.
I am trying to inject a default HeaderMap in client builder. I saw that there is SetOpt implementation as well but no method in Configurable to append the headers.
How can I achieve something like this?
let mut headers = HeaderMap::new();
headers.insert(
  "X-header-something",
  HeaderValue::from_str("my-value").unwrap(),
);

let c = isahc::HttpClientBuilder::new()
    .set_default_headers(headers) // <---- Something like this
    .build()?;

Great question! This isn't currently possible, but its a great idea for a feature! I imagine it would look something like this:
impl HttpClientBuilder {
    // etc

    pub fn default_header(self, key: impl TryInto<HeaderName>, value: impl TryInto<HeaderValue>) -> Self {}

    pub fn default_headers_mut(&mut self) -> &mut HeaderMap<HeaderValue> {}
}

I saw that there is SetOpt implementation as well

That's just used as an internal helper for setting the headers provided in a Request given. Implementing default headers for a client would leverage the same code path.

This feature is now available in 0.9.2! :tada: Thanks to @ansrivas for implementing this!


issues/1566: upgrade Awaitility to 4.0.1

Updated pom.xml file to upgrade Awaitility to 4.0.1.
This fixes strongbox/strongbox#1566.
Acceptance Test

[x] Building the code with mvn clean install -Dintegration.tests still works.
[x] Running mvn spring-boot:run in the strongbox-web-core still starts up the application correctly.
[x] Building the code and running the strongbox-distribution from a zip or tar.gz still works.
[ ] The tests in the strongbox-web-integration-tests still run properly.

@Phitrapy : Could you please work your way through the acceptance test and check, if your changes break anything down the line? Thanks! :)

@carlspring
Hello there!
I have followed the instruction on the Contributing page, and signed the ICLA. I am sorry about it, I wasn't aware of it, and be more careful in the future!
I will update this PR when it passes the acceptance tests.
I will notify you when it's all done.
Kind regards,
Clément

@Phitrapy ,
Have you had a chance to try out the last part of the acceptance tests?

Fixed via #57 .

Thanks for your efforts!


Installation not working properly on Windows with pip==20.0.1

Installation with  pip==19.3.1 works fine.
PS C:\Users\C0nsultant> python -V
	Python 3.7.4
PS C:\Users\C0nsultant> pip freeze
PS C:\Users\C0nsultant> # No packages installed
PS C:\Users\C0nsultant> python -m pip install --upgrade pip==19.3.1
PS C:\Users\C0nsultant> pip -V
	pip 19.3.1 from c:\users\C0nsultant\appdata\local\programs\python\python37\lib\site-packages\pip (python 3.7)
PS C:\Users\C0nsultant> pip install https://files.pythonhosted.org/packages/b8/de/24e4035f06540ebb4e9993238ede787063875b003e79c537511d32a74d29/SoundFile-0.10.3.post1-py2.py3.cp26.cp27.cp32.cp33.cp34.cp35.cp36.pp27.pp32.pp33-none-win_amd64.whl
	Collecting SoundFile==0.10.3.post1
		Using cached https://files.pythonhosted.org/packages/b8/d/24e4035f06540ebb4e9993238ede787063875b003e79c537511d32a74d29/SoundFile-0.10.3.post1-py2.py3.cp26.cp27.cp32.cp33.cp34.cp35.cp36.pp27.pp32.pp33-none-win_amd64.whl
	Collecting cffi>=1.0
		Using cached https://files.pythonhosted.org/packages/71/71/6011c17e8a523be0be20149ed7ba7e8671db7ec6fc52868e4f9a49d527f8/cffi-1.13.2-cp37-cp37m-win_amd64.whl
	Processing c:\users\C0nsultant\appdata\local\pip\cache\wheels\f2\9a\90\de94f8556265ddc9d9c8b271b0f63e57b26fb1d67a45564511\pycparser-2.19-py2.py3-none-any.whl
	Installing collected packages: pycparser, cffi, SoundFile
	Successfully installed SoundFile-0.10.3.post1 cffi-1.13.2 pycparser-2.19
	WARNING: You are using pip version 19.3.1; however, version 20.0.1 is available.
	You should consider upgrading via the 'python -m pip install --upgrade pip' command.
PS C:\Users\C0nsultant> python -m soundfile
PS C:\Users\C0nsultant> $?
	True

When upgrading to pip==20.0.1, installation of the windows-specific package fails.
PS C:\Users\C0nsultant> pip uninstall -y cffi pycparser SoundFile
	Uninstalling cffi-1.13.2:
  		Successfully uninstalled cffi-1.13.2
	Uninstalling pycparser-2.19:
  		Successfully uninstalled pycparser-2.19
	Uninstalling SoundFile-0.10.3.post1:
  		Successfully uninstalled SoundFile-0.10.3.post1
PS C:\Users\C0nsultant> python -m pip install --upgrade pip==20.0.1
	Collecting pip==20.0.1
  		Using cached https://files.pythonhosted.org/packages/57/36/67f809c135c17ec9b8276466cc57f35b98c240f55c780689ea29fa32f512/pip-20.0.1-py2.py3-none-any.whl
	Installing collected packages: pip
  		Found existing installation: pip 19.3.1
    		Uninstalling pip-19.3.1:
      			Successfully uninstalled pip-19.3.1
	Successfully installed pip-20.0.1
PS C:\Users\C0nsultant> pip -V
	pip 20.0.1 from c:\users\C0nsultant\appdata\local\programs\python\python37\lib\site-packages\pip (python 3.7)
PS C:\Users\C0nsultant> pip install https://files.pythonhosted.org/packages/b8/de/24e4035f06540ebb4e9993238ede787063875b003e79c537511d32a74d29/SoundFile-0.10.3.post1-py2.py3.cp26.cp27.cp32.cp33.cp34.cp35.cp36.pp27.pp32.pp33-none-win_amd64.whl
	ERROR: SoundFile-0.10.3.post1-py2.py3.cp26.cp27.cp32.cp33.cp34.cp35.cp36.pp27.pp32.pp33-none-win_amd64.whl is not a supported wheel on this platform.
PS C:\Users\C0nsultant> python -m soundfile
	C:\Users\C0nsultant\AppData\Local\Programs\Python\Python37\python.exe: No module named soundfile
PS C:\Users\C0nsultant> $?
	False
PS C:\Users\C0nsultant> # Installation works, but does not pull a compatible version
PS C:\Users\C0nsultant> pip install soundfile
	Collecting soundfile
  		Downloading SoundFile-0.10.3.post1-py2.py3-none-any.whl (21 kB)
	Collecting cffi>=1.0
  		Using cached cffi-1.13.2-cp37-cp37m-win_amd64.whl (175 kB)
	Processing c:\users\C0nsultant\appdata\local\pip\cache\wheels\f2\9a\90\de94f8556265ddc9d9c8b271b0f63e57b26fb1d67a45564511\pycparser-2.19-py2.py3-none-any.whl
	Installing collected packages: pycparser, cffi, soundfile
	Successfully installed cffi-1.13.2 pycparser-2.19 soundfile-0.10.3.post1
PS C:\Users\C0nsultant> python -m soundfile
	Traceback (most recent call last):
  		File "C:\Users\C0nsultant\AppData\Local\Programs\Python\Python37\lib\site-packages\soundfile.py", line 142, in <module>
    		raise OSError('sndfile library not found')
		OSError: sndfile library not found

	During handling of the above exception, another exception occurred:

	Traceback (most recent call last):
  		File "C:\Users\C0nsultant\AppData\Local\Programs\Python\Python37\lib\runpy.py", line 193, in _run_module_as_main
    		"__main__", mod_spec)
  		File "C:\Users\C0nsultant\AppData\Local\Programs\Python\Python37\lib\runpy.py", line 85, in _run_code
    		exec(code, run_globals)
  		File "C:\Users\C0nsultant\AppData\Local\Programs\Python\Python37\lib\site-packages\soundfile.py", line 163, in <module>
    		_path, '_soundfile_data', _libname))
	OSError: cannot load library 'C:\Users\C0nsultant\AppData\Local\Programs\Python\Python37\lib\site-packages\_soundfile_data\libsndfile64bit.dll': error 0x7e
PS C:\Users\C0nsultant> $?
	False

are there any news about the issue?

According to https://github.com/pypa/pip/issues/7626, it should be fixed on newer versions of pip. I haven't seen any new bug reports in the last while, so I'm inclined to agree.
I'd be grateful for someone to try it and report back, though.

According to pypa/pip#7626, it should be fixed on newer versions of pip. I haven't seen any new bug reports in the last while, so I'm inclined to agree.
I'd be grateful for someone to try it and report back, though.

You're correct. I can confirm that using pip>=20.0.2 solves the problem on all platforms.

Thank you, @C0nsultant, for following up on this.
Ok, let's close this for now, then.

I still have the issue with conda =4.8.4.
Any help is welcome

I have the same issue either, conda version 4.8.4

How did you install soundfile?

How did you install soundfile?

conda install -c conda-forge pysoundfile
With this command

Please use pip install soundfile instead. We don't maintain the conda version, and I know it has been broken on conda's at least once already. Additionally, pysoundfile is very, very old. You should install soundfile, not pysoundfile.

This problem arises when using python 3.7. To solve this, Uninstall soundfile using "pip uninstall soundfile". Then, install pysoundfile using "conda install pysoundfile". This solved the problem for me.

Oh no, please don't!
PySoundFile is a severely outdated, old version of soundfile that has been deprecated years ago. It will be removed, soon. Please use soundfile, not PySoundFile.


[ENH] optimized unpacking from memoryview

Is your feature request related to a problem? Please describe.
In my code, I would like to do the following
cimport numpy as np

cpdef np.uint32_t g(np.uint32_t[:] m):
	cdef np.uint32_t x, y
	x, y = m
	return x+y

but currently the unpacking delegates to Python.
Describe the solution you'd like.
Cython has a replacement implementation when the length matches.
Describe alternatives you've considered.
Writes manually x = m[0]; y = m[1]
Additional context
No response

Is this a feature that you're actually using? Using arrays to store short vectors of integers? Could you give me an idea of your user case for this?

One semi-relevant note: (when merged) patten matching will support this efficiently for memoryviews.

My original use case was np.uint32_t[:,:] with the second dimension has dimension 3, but I suppose (np.uint32_t,np.uint32_t,np.uint32_t)[25] works equally as well --- as long as the length is known at compile time.
For what it's worth (np.uint32_t,np.uint32_t,np.uint32_t)[:] doesn't seem to work…?


Categories parent_id not found

SQLSTATE[42S22]: Column not found: 1054 Unknown column 'parent_id' in 'where clause' (SQL: select * from blog_etc_categories where parent_id is null)
Command php artisan vendor:publish --provider="WebDevEtc\BlogEtc\BlogEtcServiceProvider" doesn't copy migrations.
php artisan vendor:publish --provider="WebDevEtc\BlogEtc\BlogEtcServiceProvider"
Copied Directory [/vendor/hessam/laravel-blogger/src/Views/blogetc] To [/resources/views/vendor/blogetc]
Publishing complete.

Hi @wast,
see this link: https://hessam.binshops.com/laravel-blog-package
you should change this file config/laravel-fulltext.php file change and edit these fields: exclude_feature_enabled to true and exclude_records_column_name to is_published.
For migration issue, do you have any warning or error while entering php artisan vendor:publish command?
thanks for your contribution

No warnings with php artisan vendor:publish
What I have done was manually copy https://github.com/vhessam/laravel-blogger/blob/master/migrations/2020_05_27_104123_add_parameters_blog_etc_categories_table.php to my project migrations folder and then ran php artisan migrate and it passed.

I tested it, it was ok.
If problem with migrations persists I do testing more.


Can this do TTS with pre-trained models instead of training for a week? Where does your Tacotron 2 model go?

I see this section in the ReadMe that says...
Inference demo
Download our published Tacotron 2 model
Download our published WaveGlow model
jupyter notebook --ip=<IP_ADDRESS> --port=31337
Load inference.ipynb
I have the inference.ipynb notebook open.
The waveglow model 'waveglow_old.pt' is loaded and in place.
All dependencies are installed okay. I just don't know where to put the tacotron2_statedict.pt model.
I tried just storing it as 'model' several different ways. One example here.
nv_md = '/path/to/the/tacotron2_statedict.pt'
model = load_model(hparams)
model.load_state_dict(torch.load(nv_md))['state_dict']
_ = model.eval()

returns...
RuntimeError: Error(s) in loading state_dict for Tacotron2:
Missing key(s) in state_dict: "embedding.weight", "encoder.convolutions.0.0.conv.weight", "encoder.convolutions.0.0.conv.bias", "encoder.convolutions.0.1.weight", etc. <error goes on like this listing an entire model>.

BONUS Question: Why is every line repeated in the LJ Speech dataset csv? I'm working on a dataset of my own and wonder if this is required or if repeating it would be repeating a mistake.

It looks like the model given by load_model does not have the same keys/layers as the model from nv_md


fix: not a valid ssr component

This PR replaces the current Vite build process in the library with @sveltejs/package.
Currently there's a bit of a show-stopper bug which is preventing use in SvelteKit - see Error:  is not a valid SSR component
After some digging, it looks like the uncompiled version does not have this issue. Rather than mess around with the Vite build options, I've opted to replace it with @sveltejs/package instead. This is a neat little tool which ships compiled code which we know to be compliant with Svelte (and SvelteKit). Building with this does seem to resolve the issue, and is a bit of a leaner approach as we are able to axe a few dependencies from the library too. I removed Vite and its config file, but left babel as that's there for the purpose of satisfying Jest.
As an aside, it would be great to just remove babel & jest (mostly because we aren't actually doing any tests 😅) - but when tests are introduced, we should probably use Vitest instead (less config, faster, uses Jest API etc etc). I've not actioned anything like that here though, and have kept the tests in place.

Nice one @darbymanning i need to this, was about to abandon the package (or that bit of it)!

Thank you for your feedback and your patience, @darbymanning & @mattpilott. We will do our best to get back to you as soon as possible 🙌

Thank you @darbymanning, for the amazing PR.
I'm testing it.
There are a couple of conflicts with the base main branch.
Do you want to resolve the conflicts, or if you don't have time, I can do it. In this case, will accept the PR on a temporary branch if you agree.
Thank you, and thank you again for sharing your knowledge on this aspect.
The current workaround (if it is applicable in your case) is to use the version of Vite with 4.0.X (and not 4.1)

The current workaround (if it is applicable in your case) is to use the version of Vite with 4.0.X (and not 4.1)

Ahh, that's interesting - thanks!
Just done a little rebase, things should be okay now 🤞🏻

Ehi @darbymanning  just a first quick feedback, the sveltkit part works like a charm.
In the package.json in the script section, i added:
    "dev-kit": "npm run dev --workspace=lib & npm run demo-sveltekit",

I still have an issue with the pure svelte, running npm run dev.
Part of the issue is solved by the #381 . The message (after applying the 381 ):
✘ [ERROR] [plugin vite:dep-scan] ENOENT: no such file or directory, open '/Users/roberto/Projects/playground/temp/storyblok-svelte/lib/dist/index.js'

    ../node_modules/esbuild/lib/main.js:1426:27:
      1426 │         let result = await callback({

I will take a look this afternoon.
Thank you again :)

I'm going to add a feedback about the [plugin vite:dep-scan] issue when you run the playground (a sample code that uses Svelte and not Sveltekit). For fixing this I had to change: playground/vite.config.ts file in this way:
import { defineConfig } from "vite";
import { svelte } from "@sveltejs/vite-plugin-svelte";
import path from "path";
import { fileURLToPath } from "url";
const __filename = fileURLToPath(import.meta.url);
const __dirname = path.dirname(__filename);

export default defineConfig({
  plugins: [svelte()],
  resolve: {
    alias: {
      "@storyblok/svelte": path.resolve(
        __dirname,
        "../node_modules/@storyblok/svelte"
      ),
    },
  },
});

No action is needed from you @darbymanning . I wrote these notes just as a reminder.
Tomorrow i want to merge your PR into main , and then apply these small fixes / fine tuning.

Hey, @darbymanning thanks for the contribution, I have a question regarding removing vite.config.ts in case we want to use vitest, configure alias, or any other build option, how we would approach it with @sveltejs/package, is there a way to configure it?
Since our aim for the SDKs is to maintain a standard build process (using vite) I would consult this with @alexjoverm first.


Failing to compile

Describe the bug
I am trying to install Storybook into an existing RN app. We do not use expo and we only have an ios app not android (yet). I am getting build errors when I run yarn storybook as well as npm run storybook. The compiler bug may be related to babel-loader.
To Reproduce
Steps to reproduce the behavior:

Follow the instructions for adding a SB to a RN app.
2, When running npm install i get many unmet dependency warnings around SB and RN. See output: https://gist.github.com/objectiveSee/2d8ef1d5638f2de389e72515dd8bf044
After running storybook I get the following error:

ERROR in ./storybook/addons.js
Module build failed (from ./node_modules/babel-loader/lib/index.js):
Error: Plugin/Preset files are not allowed to export objects, only functions. In /Users/username/workspace/MyProject/node_modules/babel-preset-react/lib/index.js
    at createDescriptor (/Users/username/workspace/MyProject/node_modules/@babel/core/lib/config/config-descriptors.js:178:11)
    at items.map (/Users/username/workspace/MyProject/node_modules/@babel/core/lib/config/config-descriptors.js:109:50)
    at Array.map (<anonymous>)
    at createDescriptors (/Users/username/workspace/MyProject/node_modules/@babel/core/lib/config/config-descriptors.js:109:29)
    at createPresetDescriptors (/Users/username/workspace/MyProject/node_modules/@babel/core/lib/config/config-descriptors.js:101:10)
    at passPerPreset (/Users/username/workspace/MyProject/node_modules/@babel/core/lib/config/config-descriptors.js:58:96)
    at cachedFunction (/Users/username/workspace/MyProject/node_modules/@babel/core/lib/config/caching.js:33:19)
    at presets.presets (/Users/username/workspace/MyProject/node_modules/@babel/core/lib/config/config-descriptors.js:29:84)
    at mergeChainOpts (/Users/username/workspace/MyProject/node_modules/@babel/core/lib/config/config-chain.js:320:26)
    at /Users/username/workspace/MyProject/node_modules/@babel/core/lib/config/config-chain.js:283:7
    at buildRootChain (/Users/username/workspace/MyProject/node_modules/@babel/core/lib/config/config-chain.js:68:29)
    at loadPrivatePartialConfig (/Users/username/workspace/MyProject/node_modules/@babel/core/lib/config/partial.js:85:55)
    at Object.loadPartialConfig (/Users/username/workspace/MyProject/node_modules/@babel/core/lib/config/partial.js:110:18)
    at Object.<anonymous> (/Users/username/workspace/MyProject/node_modules/babel-loader/lib/index.js:140:26)
    at Generator.next (<anonymous>)
    at asyncGeneratorStep (/Users/username/workspace/MyProject/node_modules/babel-loader/lib/index.js:3:103)
 @ multi ./storybook/addons.js<EMAIL_ADDRESS>manager[0]
Child HtmlWebpackCompiler:
                          Asset      Size               Chunks  Chunk Names
    __child-HtmlWebpackPlugin_0  1.39 MiB  HtmlWebpackPlugin_0  HtmlWebpackPlugin_0
    Entrypoint HtmlWebpackPlugin_0 = __child-HtmlWebpackPlugin_0
<EMAIL_ADDRESS>1.62 KiB {HtmlWebpackPlugin_0} [built]
    [./node_modules/lodash/lodash.js] 527 KiB {HtmlWebpackPlugin_0} [built]
    [./node_modules/webpack/buildin/global.js] (webpack)/buildin/global.js 472 bytes {HtmlWebpackPlugin_0} [built]
    [./node_modules/webpack/buildin/module.js] (webpack)/buildin/module.js 497 bytes {HtmlWebpackPlugin_0} [built]
ℹ ｢wdm｣: Failed to compile.

System:

OS: MacOS
Device: Macbook Pro 2015
Framework: react-native
Version: react-native-cli: 2.0.1
react-native: 0.57.7

This is a babel6 vs babel7 mismatch exception. @Gongreg, is there any workaround for this for now?

@igor-dv We just created the React Native portion of our app this week so we can switch to using any version that works. Here's our package.json:
  "dependencies": {
    "expo": "31.0.5",
    "react": "16.6.3",
    "react-native": "0.57.7",
    "react-native-create-bridge": "2.0.1",
    "react-native-elements": "0.19.1",
    "react-native-fast-image": "^5.1.1",
    "react-native-linear-gradient": "2.5.2",
    "react-native-svg": "^8.0.8",
    "react-native-vector-icons": "^6.1.0"
  },
  "devDependencies": {
    "@storybook/react-native": "^4.0.12",
    "@storybook/addon-actions": "^4.0.12",
    "@storybook/addon-links": "^4.0.12",
    "@storybook/addons": "^4.0.12",
    "babel-core": "^6.26.3",
    "babel-runtime": "^6.26.0",
    "react-dom": "16.6.3",
    "prop-types": "^15.6.2"
  }
}

I think it's related to #4852

this seems to be an issue with todays installs of react-native (0.57.8) and storybook/react-native (4.1.x and the 4.2.x releases). doing a fresh
react-native init MyApp && cd MyApp &&
npx -p @storybook/cli sb init

can reproduce

It will be working after the #4942


Threading errors on program close from eventloop created in init.py

Hello all,
Firstly, I'd like to thank you because this project is a very nice way to rope in node modules and call them from python.
I have a PySide (QT) application I am trying to make use of jsonpath-plus inside of and after running an import javascript statement, I get an exception in threading every time I exit the application.
I read briefly through the docs and the code, and I think it is kicking off the event loop in the __init__.py that opens the thread that closes exceptionally at the end.
Is there a way to appropriately close out the javascript event loop before closing the program?
Thanks,
Dan

Thanks for merging my PR.


failed to open stream: HTTP request failed! HTTP/1.1 400 Bad Request

Hi, This SDK has a bug.
PHP Warning:  file_get_contents(https://sandbox.ebanx.com/ws/request): failed to open stream: HTTP request failed! HTTP/1.1 400 Bad Request
 in /data/aa/aa/vendor/ebanx/ebanx/src/Ebanx/Http/Client.php on line 154
PHP Fatal error:  Uncaught RuntimeException: Bad HTTP request:  in /data/aa/aa/vendor/ebanx/ebanx/src/Ebanx/Http/Client.php:166
Stack trace:
#0 /data/aa/aa/vendor/ebanx/ebanx/src/Ebanx/Command/AbstractCommand.php(91): Ebanx\Http\Client->send()
#1 /data/aa/aa/vendor/ebanx/ebanx/src/Ebanx/Ebanx.php(64): Ebanx\Command\AbstractCommand->execute(Array)
#2 /data/aa/aa/vendor/ebanx/ebanx/examples/checkout.php(11): Ebanx\Ebanx::__callStatic('doRequest', Array)
#3 {main}
  thrown in /data/aa/aa/vendor/ebanx/ebanx/src/Ebanx/Http/Client.php on line 166

How to reproduce the bug

Set key to the file. example/bootstrap.php

run php checkout.php

How to fix that.

Open & find function send in Client.php file.

change $context http -> header array to

 "Content-Type: application/x-www-form-urlencoded \r\n" .
 "User-Agent: EBANX PHP Library " . \Ebanx\Ebanx::VERSION . "\r\n"

:)

Straight to the point! Thanks @instadart


Add warning during installation when users are using a wrong docker version

vFile plugin requires docker version higher or equal to 17.06.
With docker 17.03, removing vFile plugin (or other plugins) will result failure with the rest of the plugins.
Since we won't be able to do anything when the plugin is deleted, at least we should print out some warning message during the installation, if the docker version does not meet the requirement.

nice to have for vFile beta release (improves usability)

Closed by #2014


redirect all http to https requests in nginx.conf

apparently this does not catch all domains in nginx.conf
 # match is case insensitive
    if ($host ~* ${SERVER_NAME_PATTERN}) {
      return 301 https://$host$request_uri;
    } # managed by Certbot
    listen       80 ;

fixed with https://github.com/tillkuhn/angkor/commit/3ae2e86db6709c5f8aee4e4a222e7d6baac1799a


Design and document build on linux and windows for unit test application

This will be deferred until later.  Windows people should be able to follow the vcpkg instructions and if they get all the right dependencies installed with it, it should not be difficult for them to build.  Linux people probably understand CMake etc a helluva a lot better than I do.  Documenting how to build the unit test application does not presently seem like an effective use of my time as the sole contributing developer.


fix: select wheel disabled props

Coverage remained the same at 35.245% when pulling cbc6f3a44bbc533908dc49da8a37441903f03384 on edison-hm:dev into a8421c3a8d03971f86b1c8b8490e16f92fa96d90 on ZhonganTechENG:dev.


Some question

Usefull bundle :+1: :+1: :+1:
Hi im using your bundle on SF3 work but i have two questions :

How can i include an image ?
This

toto

Don't work

How can i propose to download ?

THANK YOU

I found the solutions

$html2pdf->Output('file.pdf', 'D'); (were in the doc htmltopdf)`

Hello and thank you. I'm sorry for not reacting fast enough to this issue.
Glad you found a solution !


ImportError: No module named caffe.proto

I get the following error when trying to translate caffe model to caffe2:
from caffe.proto import caffe_pb2 ImportError: No module named caffe.proto
My caffe2 installation was successfull. I get Success when I run the following code:
python -c 'from caffe2.python import core' 2>/dev/null && echo "Success" || echo "Failure"
Any idea whats causing the issue?

Resolved by using export PYTHONPATH=/path/to/caffe/python:$PYTHONPATH


Retrieving OAuth2 credential returns empty string

When retrieving an OAuth2 credential, I receive an empty string as the response (status code is 200, so that's ok)
I'm performing a GET request on the following endpoint:
http://localhost:8001/consumers/af94a77d-9dfa-4842-c8f5-7a1da7948a04/oauth2/5c75e28c-d00e-400e-c053-8269ab51658d/

Previously, I received the correct credential structure.
Am I doing something wrong or is this now expected behaviour?

@dirkmoors I have just tested this with master and seems to be working properly. It may have been a bug in 0.4.2 that will be fixed in 0.5.0. Next week we are releasing 0.5.0 so you can try with the new version.

@dirkmoors 0.5.0 has been released, please let me know if you still experience the issue.


Allow multiple subnets

Issue #307 was closed but the issue it refers to #1066 never solved the mutiple subnet feature.
The Yaml allows for multiplt subnets per queue, but at creation it is refused.
Create multiple queues in different subnets is also refused.
I understand the need for low latency when different jobs communicate to each other, but if the use case is just many compute jobs with or without dependencies, access to more instances accorss AZs is more important and is at the moment impossible.

I'm going to close this one in favour of: https://github.com/aws/aws-parallelcluster/issues/3576 (that I just renamed).


fix docs typos

Thank you for an easy-to-use library.
I found typos in docs so I sent a PR.

Coverage remained the same at 53.31% when pulling f779a1b8035fc9d04cbdb413e41f301632f64240 on regonn:fix-docs-typos into c032336502de7f3ecd91644f3467ff7e718255b4 on MaxHalford:master.

Thanks!


Go Live [Sept 16]

Push to live

Docs Build status updates of commit 4f7bbe1:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

msteams-platform/concepts/deploy-and-publish/appsource/prepare/teams-store-validation-guidelines.md
:white_check_mark:Succeeded
View

msteams-platform/tabs/how-to/access-teams-context.md
:white_check_mark:Succeeded
View

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching the docs.microsoft.com contributor guidesPost your question in the Docs support channel


rework ripple's tween logic

made the internal tween logic use :GetValue() method of tween service,
changed the time value to speed
did not touch any unit tests 🌱

Resolved by commit 4a14d5cdd419f9e2f2598e36853825373082dc00


cut command printing extra line that was not ending with the specified terminator

issue: uutils/coreutils#5795
Using the default line terminator \n and without the additional option --only-delimited, cut should print the lines that do not contain delimiters only when they are ended with the specified line terminator(the default \n in this case or null-terminated if --zero-terminated is enabled).
In the given input the last line was not ended in a \n so it shouldn't have been printed.

Please rebase this and send it to upstream, and place a link to it here.

uutils/coreutils/pull/5844


Allow to configure startup consul agent

In some cases consul agents cache could be empty.
This chagne allow providing consul agent hostname to
initially populate the cache.
Fixes: #191

Coverage decreased (-0.1%) to 87.386% when pulling 7d4c48cdb91121790c09a3afc3300b2dc17c3806 on bugfix/#191/add_startup_consul_host into 888b8e96ccd51b03bf992b875dee3b155635dbb9 on master.

Coverage decreased (-0.1%) to 87.374% when pulling c3149d8311efc9c4114569d1fd1786c1234b25a8 on bugfix/#191/add_startup_consul_host into 888b8e96ccd51b03bf992b875dee3b155635dbb9 on master.


build.sh requires zip to be installed on local OS

1st thanks for creating "FFmpeg-Builds".
I found that when using your scripts and docker image to cross compile a win64 version of ffmpeg that the "build.sh" script didn't place anything into the "artifacts" folder.  Reviewing bash's output "build.sh" failed when it was unable to zip any of the ffmpeg files - zip wa missing.  The local OS used was Ubuntu server 22.04.  After installing "zip" and re-running "./build.sh win64 nonfree" it worked.
So this isn't really an issue with your "FFmpeg-Builds", but perhaps something to add to the prerequisites that "zip" is also needed for win32/64 builds?
Thanks again.

FWIW, the code is:
https://github.com/BtbN/FFmpeg-Builds/blob/c07b573acd10e813c500ed50f4ceeee9cd819b04/build.sh#L91-L93


[EngSys][comm-identity] upgrade dependency @azure/msal-node to ^2.5.1

as v1 has been deprecated
Resolves https://github.com/Azure/azure-sdk-for-js/issues/27939

API change check
API changes are not detected in this pull request.


memcached: 1.6.8 -> 1.6.9

Automatic update generated by nixpkgs-update tools. This update was made based on information from https://repology.org/metapackage/memcached/versions.
meta.description for memcached is: "A distributed memory object caching system"
meta.homepage for memcached is: "http://memcached.org/"
meta.changelog for memcached is: ""
Updates performed

Version update

To inspect upstream changes
Impact

Checks done (click to expand)

built on NixOS

The tests defined in passthru.tests, if any, passed

0 of 0 passed binary check by having a zero exit code.

0 of 0 passed binary check by having the new version present in output.

found 1.6.9 with grep in /nix/store/wr7mis4wvphpql199akf3xxz46lp6akh-memcached-1.6.9

directory tree listing: https://gist.github.com/75c4a30a901a60b9aea4524cb2221061

du listing: https://gist.github.com/51c98dfe4a77efd3327eca53a6344604

Rebuild report (if merged into master) (click to expand)

4 total rebuild path(s)

1 package rebuild(s)

1 x86_64-linux rebuild(s)
1 i686-linux rebuild(s)
1 x86_64-darwin rebuild(s)
1 aarch64-linux rebuild(s)

First fifty rebuilds by attrpath
memcached

Instructions to test this update (click to expand)

Either download from Cachix:
nix-store -r /nix/store/wr7mis4wvphpql199akf3xxz46lp6akh-memcached-1.6.9 \
  --option binary-caches 'https://cache.nixos.org/ https://nix-community.cachix.org/' \
  --option trusted-public-keys '
  nix-community.cachix.org-1:mB9FSh9qf2dCimDSUo8Zy7bkq5CX+/rkCWyvRCYg3Fs=
  cache.nixos.org-1:6NCHdD59X431o0gWypbMrAURkbJ16ZPMQFGspcDShjY=
  '

(The Cachix cache is only trusted for this store-path realization.)
For the Cachix download to work, your user must be in the trusted-users list or you can use sudo since root is effectively trusted.
Or, build yourself:
nix-build -A memcached https://github.com/r-ryantm/nixpkgs/archive/6e8c5582c92c15732107df750185bc6b4efa00b8.tar.gz

After you've downloaded or built it, look at the files and if there are any, run the binaries:
ls -la /nix/store/wr7mis4wvphpql199akf3xxz46lp6akh-memcached-1.6.9
ls -la /nix/store/wr7mis4wvphpql199akf3xxz46lp6akh-memcached-1.6.9/bin

Pre-merge build results
We have automatically built all packages that will get rebuilt due to
this change.
This gives evidence on whether the upgrade will break dependent packages.
Note sometimes packages show up as failed to build independent of the
change, simply because they are already broken on the target branch.
Result of nixpkgs-review 1

1 package built:

memcached

Maintainer pings
cc @coreyoconnor for testing.

Result of nixpkgs-review pr 105276 run on x86_64-darwin 1

1 package built:

memcached


NIFI-13743: Ensuring the mime type is set when navigating to the cont…

…ent viewer from Provenance.

Adding a trailing slash when loading the external viewer to eliminate an unneeded redirection.

reviewing...


Question about the function edit_dataset in EasyEdit-main/easyeditor/editors/editor.py

I found that the function always return the result of last batch data. I don't know if it's a bug or something I misunderstand.
        for record_chunks in tqdm(self._chunks(ds, num_edits), desc='Editing dataset', total=len(ds)/num_edits):
            ...

            all_metrics = [] # Here
            for i, request in enumerate(record_chunks):

                metrics = {...}
                all_metrics.append(metrics)

            ...

            for i, request in enumerate(record_chunks):
                all_metrics[i]["pre"] = compute_edit_quality(...)

            ...
        return all_metrics, edited_model, weights_copy

Hello, thanks for point out the bug here, we would fix it as soon as possible.

Hello, the standard setting for model editing usually starts from the same model each time. If editing is done sequentially from a model that has already been edited, you may want to carefully review the papers or overview introductions for more details. If you wish to perform sequential editing, you can set copy to false. This way, each time self.model is passed in, it will be the model that has been edited, and the modifications will be applied directly to the reference of self.model.

I have fixed this bug, thanks again.


Introduce new PlanType as part of SubscriptionType and remove PokéPlanType

Introduce a new PlanType and set it as part of SubscriptionType.
Small Poké refactor to use PlanType  over PokéPlanType that I was able to remove.

Once this is merged I can edit createCheckoutSession in our Stripe lib so that it returns a PlanType, which is the intial reason we wanted this refacto 🙇🏻♀

Next steps, we want:

auth.plan() return PlanType()
auth.subscription() return SubscriptionType()
SubscriptionType contains a key plan that contains the PlanType() as opposite to merging PlanType keys in SubscriptionType


Moved commit/frame throttling logic to Compositor

Should fix #8996
Normally, the following sequence happens:

Visual is attached to the visual tree, CompositionVisual is created, which implicitly queues a composition commit
InvalidateVisual is called, that queues renderer's Update
renderers updates the visual
commit happens

However there is throttling logic that prevents the renderer from doing updates faster than rendering happens
So if there is a commit in flight, the following happens:

previous visual gets removed, which implicitly queues a composition commit
new visual is attached to the visual tree, CompositionVisual is created but not yet attached anywhere
InvalidateVisual is called, that queues renderer's Update after the last commit is completed
commit from (0) happens and removes the visual from (0)¸ but visual from (1) didn't have a chance to be processed by the renderer
render thread starts to render the frame
renderer updates the visual from (1) which triggers another commit
commit from (4) happens with correct state

So we have one frame with invalid state which causes flicker
This PR moves the throttling logic to the compositor itself (RequestCommitAsync will return the same task for the planned batch until the previous batch is applied) and calls renderer's Update method right before the batch is serialized.

Seeing crashes that may be related to this. Not sure I understand them though -- seems to be internal .NET error:

at System.IO.StreamWriter.WriteLine(String value)\r\n
at System.IO.TextWriter.SyncTextWriter.WriteLine(String value)\r\n
at System.Console.WriteLine(String value)\r\n
at Avalonia.Rendering.Composition.Compositor.<.ctor>b__17_0() in C:\\Users\\...\\Avalonia\\src\\Avalonia.Base\\Rendering\\Composition\\Compositor.cs:line 52\r\n
at Avalonia.Threading.JobRunner.Job.Avalonia.Threading.JobRunner.IJob.Run() in C:\\Users\\...\\Avalonia\\src\\Avalonia.Base\\Threading\\JobRunner.cs:line 193\r\n
at Avalonia.Threading.JobRunner.RunJobs(Nullable`1 priority) in C:\\Users\\...\\Avalonia\\src\\Avalonia.Base\\Threading\\JobRunner.cs:line 38\r\n
at Avalonia.Win32.Win32Platform.WndProc(IntPtr hWnd, UInt32 msg, IntPtr wParam, IntPtr lParam) in C:\\Users\\...\\Avalonia\\src\\Windows\\Avalonia.Win32\\Win32Platform.cs:line 267\r\n
at Avalonia.Win32.Interop.UnmanagedMethods.DispatchMessage(MSG& lpmsg)\r\n
at Avalonia.Win32.Win32Platform.RunLoop(CancellationToken cancellationToken) in C:\\Users\\...\\Avalonia\\src\\Windows\\Avalonia.Win32\\Win32Platform.cs:line 214\r\n
at Avalonia.Threading.Dispatcher.MainLoop(CancellationToken cancellationToken) in C:\\Users\\...\\Avalonia\\src\\Avalonia.Base\\Threading\\Dispatcher.cs:line 61\r\n
at Avalonia.Controls.ApplicationLifetimes.ClassicDesktopStyleApplicationLifetime.Start(String[] args) in C:\\Users\\...\\Avalonia\\src\\Avalonia.Controls\\ApplicationLifetimes\\ClassicDesktopStyleApplicationLifetime.cs:line 120\r\n
at Avalonia.ClassicDesktopStyleApplicationLifetimeExtensions.StartWithClassicDesktopLifetime[T](T builder, String[] args, ShutdownMode shutdownMode) in C:\\Users\\...\\Avalonia\\src\\Avalonia.Controls\\ApplicationLifetimes\\ClassicDesktopStyleApplicationLifetime.cs:line 209\r\n
at ControlCatalog.NetCore.Program.Main(String[] args) in C:\\Users\\...\\Avalonia\\samples\\ControlCatalog.NetCore\\Program.cs:line 103"

Does it only happen with a debugger attached? We might want to change that line so it uses a logger.

Ouch, that's a leftover debug code.

If you close a Popup thats not initialized it can sometimes hang on _compositor.Commit().Wait();


New org browser

First PR for the new org browser. It mostly contains fixes and improvements to mostly match the current design.
Currently the features it has are:

You can reliably browse through the organisation
It has fixed width and height columns and contains content longer than it's size, has title attributes to help with longer names
Long columns scroll vertically
The org browser scrolls horizontally
Has forms
Has disabled styles for forms
You can have multiple org browsers in the same page
Opens up to the selected node in form mode, scrolls to the said node automatically

Things missing, need a bit of rejigging

The HTML/CSS needs a bit of rearranging to accommodate a couple of design implementation problems, like hover states.
The JS needs a bit of a cleanup. It makes a lot of assumptions
The HTML/CSS can be cleaned up to support resizable columns
Needs a bit of work to make it responsive

OK, I've done some small tweaks and I think it's ready to be reviewed / merged.
@threedaymonk do you mind having a look? It's quite a lot of stuff, maybe we can review it together?

IE7 :sob:


Load existing config?

This is really cool, just discovered it!
Is it possible to load in existing settings for the project so if re-run, they don't have to be specified all over again?
Thanks!

There is no such functionality currently, but I'm open to PRs :) I currently don't have a lot of time to work on this.


Check for GLES3 shader cache support before using it

Experimental draft PR for logging and possibly fixing some GLES3 shader cache related issues on older graphics cards and drivers. See https://github.com/godotengine/godot/issues/79115 and https://github.com/godotengine/godot/issues/78888 This is mostly for providing test PR and possibly builds for those who can't build their own Godot engine.
This PR adds heavy logging as it seems some drivers seem to blow up when attempting to use their shader cache. Also adds is_shader_cache_supported() function which tries to test if some cache related values are available before attempting to cache shader data. It seems that many reported issues are related to devices that report GL_NUM_PROGRAM_BINARY_FORMATS to be zero, see https://registry.khronos.org/OpenGL/extensions/ARB/ARB_get_program_binary.txt, so in these cases it might be best not to use cache at all.

Yep, I added some excessive logging as debugging this is partly shooting in the dark, Foxysen provided very good info in https://github.com/godotengine/godot/issues/79115 and seemed to pinpoint at least one place where things crash, so I'll try to ping them once the builds are ready in case they can test this. Finding other people to test this who suffer from the issue would also be great.
In the final version we probably don't need any extra logging at all, so let's first see if this manages to clear things out in any way.

Thank you for making this PR! However I have a problem when running the scene with shader. The 3d shader in game didnt show for me. Just gives this error 3 times: ShaderGLES3::_save_to_cache: Condition "f.is_null()" is true. <C++ Source drivers\gles3\shader_gles3.cpp:668 @ ShaderGLES3::_save_to_cache(). This happens on the original fork of godotv4.2dev2.

editor

runtime

Anyways here are the logs!
godoteditor.txt


Java 21 SnapStart Priming

This is a tough benchmark for Lambda SnapStart. It caches snapshots so the first restore of a Lambda version is always slower than future ones.
One technique to improve the first restore latency is to have the JVM load and initialize classes before the snapshot is taken. This can be done using the CRaC APIs. In this PR I've made a before hook that does the same thing as the handler. It will mean that those classes are already compiled and stored in the snapshot when the handler is invoked.

Thanks @marksailes !
It seems that the invocation is failing with:
Error loading class io.github.maxday.Handler: org/crac/Resource: java.lang.NoClassDefFoundError
java.lang.NoClassDefFoundError: org/crac/Resource
	at java.base/java.lang.ClassLoader.defineClass1(Native Method)
	at java.base/java.lang.ClassLoader.defineClass(Unknown Source)
	at java.base/java.security.SecureClassLoader.defineClass(Unknown Source)
	at java.base/java.net.URLClassLoader.defineClass(Unknown Source)
	at java.base/java.net.URLClassLoader$1.run(Unknown Source)
	at java.base/java.net.URLClassLoader$1.run(Unknown Source)
	at java.base/java.security.AccessController.doPrivileged(Unknown Source)
	at java.base/java.net.URLClassLoader.findClass(Unknown Source)
	at java.base/java.lang.ClassLoader.loadClass(Unknown Source)
	at java.base/java.lang.ClassLoader.loadClass(Unknown Source)
	at java.base/java.lang.Class.forName0(Native Method)
	at java.base/java.lang.Class.forName(Unknown Source)
	at java.base/java.lang.Class.forName(Unknown Source)
Caused by: java.lang.ClassNotFoundException: org.crac.Resource
	at java.base/java.net.URLClassLoader.findClass(Unknown Source)
	at java.base/java.lang.ClassLoader.loadClass(Unknown Source)
	at java.base/java.lang.ClassLoader.loadClass(Unknown Source)
	... 13 more

any ideas?

Added the dependency to the code.zip


SDSPI cannot be mounted when the SPI bus has been initialized. (IDFGH-2847)

The SPI bus may be shared by multiple devices.
However, if the SPI bus initialization is included in the SDSPI mounting process, and it has already been initialized, it will terminate with an error.
https://github.com/espressif/esp-idf/blob/master/components/driver/sdspi_host.c#L981
In this function, I think that the initialization of the SPI bus and the mounting of the SDSPI should be separated.
Or, if the SPI bus initialization fails, you should try to mount the SD without returning an error.
Currently, cannot unmount SDSPI and then mount it again.
For that purpose, it is necessary to release the SPI bus once.
best regard.

Hi @lovyan03 sdspi_host_init_slot function is deprecated, it is suggested to use sdspi_host_init_device instead. The latter solves the problem with sharing the SPI bus between multiple devices.
https://github.com/espressif/esp-idf/blob/f7d1ed5f329c14c356a710c4c10ba50cea277b55/components/driver/sdspi_host.c#L958-L959
The sd_card example has been updated to split the SPI bus and sdspi initialization:
https://github.com/espressif/esp-idf/blob/f7d1ed5f329c14c356a710c4c10ba50cea277b55/examples/storage/sd_card/main/sd_card_example_main.c#L105-L126

Thank you !! and sorry…
I could not check the latest repository.
I'll update it and check it.

@lovyan03 Hi I'm using M5Stack. Can you provide a demo code that coexists with SD card and LCD on the sharing SPI bus base on ESP-IDF?

@WangYifa
There's nothing to talk about in this thread.


[GoLint] Fixed golint errors when syncing to Google3.

Thank you Rob!!!

Hey, can we talk about this one?
If GitHub is our source of truth, we can not expect (potentially external) rule authors to conform to arbitrary lint rules that are not enforced here. This is going to be a consistent problem.
I would argue that:
(1) We should probably enforce linting here (as we already do).
(2) We should probably disable any linting in google3. It should accept whatever code is accepted here, with only the modifications required to get it running in google3.


Issue with debugger not referencing javascript closure variables

VSCode Version:
OS Version:

Steps to Reproduce:

Open following code in vscode

const util = require('./util');
const decorator = (request) => {
    return {};
}
const init = () => {
    return decorator;
};
const closure = init();
closure();

Put a breakpoin in Line 3
Run using vscode node debugger
When breakpiont hits, try to point the variable util in debug console

Does this issue occur when all extensions are disabled?: Yes
Note:
I am experiencing an issue in the vscode debugger, where it's not showing variables inside closure unless they are referenced.. Please see below screenshots
in first case, I reference a variable (called util) inside closure. When the breakpoint hit, we can see it's defined in the scope( see left side)
In second case, when I don't reference it ( don't do console log for util) then variable doesn't show up in the closure and if I try to print it inside debug console, i get reference error..
Working scenario

Not Working scenario

@nitinsh99 the observed behavior is the expected behavior. If a variable is not used, it is garbage collected or optimised away.
Chrome Dev tools show the same behavior:


Maven reporting plugin

According with Maven conventions, a plugin is just producing an output  machine-readable artifact. That means the maven-{search-platform}-plugin, after running, will produce a JSON output containing the evaluation data.
On top of that, we need to create a separate reporting plugin which will be in charge to take in input the JSON evaluation data and to produce a report in several formats (e.g. xml, html, pdf, excel).

I'm closing this issue, as the plugin has been implemented as an additional module. At the moment we have two outputs: spreadsheet and rre-server.


Cobra Shot appears as Steady Shot after saving macro

When /cast Cobra Shot is entered in the sequence window and saved, it is changed to /cast Steady Shot.   Using GSE-2.6.31 build.  Please advise.

See #758 or the hundred other closed versions of this.


fix(rule): no-accessibilityLabel-for-testing add a check to see if the same value is set

:tada: This PR is included in version 1.6.1 :tada:
The release is available on:

GitHub release
npm package (@latest dist-tag)

Your semantic-release bot :package::rocket:


Fix RuboCop warnings

The RuboCop linter complains about a 36 issues. This PR fixes all of the default warnings except for too-long lines in the comments in the examples which are ignored.

Thanks Steve


ffmpeg-vaapi: add vpp composite test

overlay_vaapi supported on cartwheel.  vaapi-fits example case passed and internal bat/sanity cases passed on KBL.

Same with #320

Same answers


The remote name could not be resolved: 'bcartifacts.azureedge.net'

I have tried from serveral different computers, but keep gettings this error:
The remote name could not be resolved: 'bcartifacts.azureedge.net'
Script:
$Url = Get-BCArtifactUrl -type OnPrem -country w1 -version 14.44.49619.0 -select Latest
New-BcContainer -accept_eula -accept_outdated -artifactUrl $Url
Exception calling "DownloadFile" with "2" argument(s): "The remote name could not be resolved: 'bcartifacts.azureedge.net'"
at InstallPrerequisite, C:\Run\HelperFunctions.ps1: line 614
at , C:\Run\navinstall.ps1: line 30
at , C:\Run\start.ps1: line 316
at , : line 1
remove C:\NAVDVD
BCCH v6.0.6
Docker: 25.0.3

Strange... - must be something with your firewall or like:

You can try to set $bcContainerHelperConfig.DoNotUseCdnForArtifacts to $false and retry the operation

Please supply the full log - I saw now that the error comes from inside the container.
That is likely because the container doesn't have access to DNS.

The setting didn't help.
Here is the Powershell log (assuming that it's not the EventLog):
$Url = Get-BCArtifactUrl -type OnPrem -country w1 -version 14.44.49619.0 -select Latest
New-BcContainer -accept_eula -accept_outdated -artifactUrl $Url
BcContainerHelper is version 6.0.6
BcContainerHelper is running as administrator
HyperV is Enabled
UsePsSession is True
Host is Microsoft Windows 10 Enterprise - 10.0.19045.4046
Docker Client Version is 25.0.3
Docker Server Version is 25.0.3
Removing Session bcserver
Removing container bcserver
Removing Desktop shortcuts
Removing C:\ProgramData\BcContainerHelper\Extensions\bcserver
Fetching all docker images
Fetching all docker volumes
INFO: Windows 10 21H1/21H2 images are not yet available, using 2004 as these are found to work better than 20H2 on 21H1/21H2
Using image mcr.microsoft.com/businesscentral:10.0.19041.1415
Creating Container bcserver
Style: onprem
Multitenant: No
Version: 14.44.49619.0
Platform: 14.0.49616.0
Generic Tag: <IP_ADDRESS>
Container OS Version: 10.0.19041.1415 (2004)
Host OS Version: 10.0.19045.4046 (22H2)
WARNING: Host OS is Windows 10 21H1 or newer and Container OS is 2004, defaulting to process isolation. If you experience problems, add -isolation hyperv.
Using process isolation
WARNING: Using process isolation on Windows Desktop OS with generic image version prior to <IP_ADDRESS> or NAV/BC versions prior to 15.0, might require you to use HyperV isolation or disable Windo
ws Defender while creating the container
Using locale en-US
Disabling the standard eventlog dump to container log every 2 seconds (use -dumpEventLog to enable)
Files in C:\ProgramData\BcContainerHelper\Extensions\bcserver\my:

AdditionalOutput.ps1
MainLoop.ps1
SetupVariables.ps1
updatecontainerhosts.ps1
Creating container bcserver from image mcr.microsoft.com/businesscentral:10.0.19041.1415
f672d9a61aeaf92643b577e1590708bc193d7cd58d54ec5ee3b0723cf66245d7
Waiting for container bcserver to be ready
Using artifactUrl https://bcartifacts.azureedge.net/onprem/14.44.49619.0/w1
Using installer from C:\Run\130
Copying Platform Artifacts
c:\dl\onprem\14.44.49619.0\platform
Copying Application Artifacts
Copying Database
Copy Licensefile
Installing Business Central: InstallOnly=False
Downloading Url Rewrite
Exception calling "DownloadFile" with "2" argument(s): "The remote name could not be resolved: 'bcartifacts.azureedge.net'"
at InstallPrerequisite, C:\Run\HelperFunctions.ps1: line 614
at , C:\Run\navinstall.ps1: line 30
at , C:\Run\start.ps1: line 316
at , : line 1
remove C:\NAVDVDError
Using artifactUrl https://bcartifacts.azureedge.net/onprem/14.44.49619.0/w1
Using installer from C:\Run\130
Copying Platform Artifacts
c:\dl\onprem\14.44.49619.0\platform
Copying Application Artifacts
Copying Database
Copy Licensefile
Installing Business Central: InstallOnly=False
Downloading Url Rewrite
Exception calling "DownloadFile" with "2" argument(s): "The remote name could not be resolved: 'bcartifacts.azureedge.net'"
at InstallPrerequisite, C:\Run\HelperFunctions.ps1: line 614
at , C:\Run\navinstall.ps1: line 30
at , C:\Run\start.ps1: line 316
at , : line 1
remove C:\NAVDVD
New-BcContainer Telemetry Correlation Id: d78a94e3-70a7-4255-be34-34fc423b846b
Initialization of container bcserver failed
At C:\Program Files\WindowsPowerShell\Modules\BcContainerHelper\6.0.6\ContainerHandling\Wait-NavContainerReady.ps1:42 char:17

...             throw "Initialization of container $containerName failed" ...

            ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

CategoryInfo          : OperationStopped: (Initialization ...bcserver failed:String) [], RuntimeException
FullyQualifiedErrorId : Initialization of container bcserver failed

That did not make a difference. Same error.

-dns "<IP_ADDRESS>" ?
If that doesn't work, then try to open a prompt inside the container and
ping <IP_ADDRESS>
Do you get a reply?
ping bcartifacts.azureedge.net
Do you get a reply?
bcartifacts.blob.core.windows.net
Do you get a reply?
are these urls pingable from your host?

With -dns "<IP_ADDRESS>" it created the container without the error! THANKS!
Is that a settings we should use going forward or?

Before bluntly saying YES (and for other people reading this), it is important to understand what happens.
By default, the container lives in a NAT network on your host.
You can change the network settings in docker, but that is a whole other story and not for this issue.
Apparently, your DNS, your network (or your host) doesn't allow the docker container on your host to use the DNS.
Without setting DNS, DNS is handled by the host, which forwards DNS requests to the network DNS, which didn't work (it also doesn't work on my laptop when I am on the Microsoft Corporate Network)
With DNS set to "hostDNS", ContainerHelper will grab the IP address of DNS on the host and forward this to your container, which  apparently was blocked by something. (this works on MS CorpNet)
With DNS set to <IP_ADDRESS>, the container will use Google's public DNS server as DNS. (This doesn't work on MS CorpNet)
So, it is all a matter of how the network is configured and your Network administrator could probably tell you whether all of this is on purpose or whether it is coincidence.

Thanks. I just have a "follow-up problem". If I specify imageName (or run New-BcImage) then I'm also getting the error:
New-BcContainer -accept_eula -accept_outdated -artifactUrl $Url -dns "<IP_ADDRESS>" -imageName 'myimage'
It seems we cannot specify -dns for New-BcImage.

That might be - that is not something I will have time to look into for the foreseeable future:-(
You are however welcome to add that to New-BcImage and create a PR on BcContainerHelper, if you can make it work.

I might just do that, as I tried to put the DNS: <IP_ADDRESS> into the Docker daemon.json, but that didn't work either.

It actually did work to update the windows-daemon.json file with:
"dns": ["<IP_ADDRESS>"]


Add support for soap+xml detection

Please add support for application/soap+xml
This must match header like: Content-Type: application/soap+xml; charset=UTF-8
File: Curl\Curl.php
Before soap support
private $xmlPattern = '~^(?:text/|application/(?:atom\+|rss\+)?)xml~i';

After soap support
private $xmlPattern = '~^(?:text/|application/(?:atom\+|rss\+|soap\+)?)xml~i';

Thanks!