ValueError when attempting to validate list of validator and validator

Hi all;
In an issue similar (I think) to #22 we're running into situations where we have schemas with optional lists - i.e.
example1:
  logic:
    or:
      - thing1
      - thing2
example2:
  logic:
    - or:
      - thing3
      - thing4
      - thing5

validating against:
example1: include('spec-1', required=False)
example2: include('spec-2', required=False)
---
spec-1:
  logic: >
    any(
      include('or-spec', required=False),
      required=False
    )
spec-2:
  logic: >
    any(
      list(
        include('or-spec', required=False),
        required=False
      ),
      required=False
    )
blended-spec:
  logic: >
    any(
      list(
        include('or-spec', required=False),
        required=False
      ),
      include('or-spec', required=False),
      required=False
    )
or-spec:
  or: any(list(str(required=True)), str(required=False))

I can create validators for either example1 or example2 (spec-1 and spec-2 respectively) but when I try to combine those together (blended-spec) I end up with the below stack trace. I'm starting to convince myself that it's not me, but I'd say it's still 50/50 - my YAML comprehension is really truly bad. Any advice would be greatly appreciated!
Traceback (most recent call last):
  File "/Users/hhorsey/.pyenv/versions/idsm3/lib/python3.7/site-packages/yamale/util.py", line 81, in get_value
    return reduce(getitem, path, dic)[last_key]
TypeError: list indices must be integers or slices, not str

During handling of the above exception, another exception occurred:

Traceback (most recent call last):
  File "<stdin>", line 1, in <module>
  File "/Users/hhorsey/repos/tracked/buildstockbatch-dev/buildstockbatch/base.py", line 294, in validate_project_schema
    return yamale.validate(schema, data)
  File "/Users/hhorsey/.pyenv/versions/idsm3/lib/python3.7/site-packages/yamale/yamale.py", line 39, in validate
    schema.validate(d)
  File "/Users/hhorsey/.pyenv/versions/idsm3/lib/python3.7/site-packages/yamale/schema/schema.py", line 49, in validate
    errors += self._validate(validator, data, key=key, includes=self.includes)
  File "/Users/hhorsey/.pyenv/versions/idsm3/lib/python3.7/site-packages/yamale/schema/schema.py", line 83, in _validate
    return self._validate_item(validator, data_item, position, includes)
  File "/Users/hhorsey/.pyenv/versions/idsm3/lib/python3.7/site-packages/yamale/schema/schema.py", line 104, in _validate_item
    includes, position)
  File "/Users/hhorsey/.pyenv/versions/idsm3/lib/python3.7/site-packages/yamale/schema/schema.py", line 150, in _validate_include
    errors += include_schema._validate(validator, data, includes=includes, key=key, position=pos)
  File "/Users/hhorsey/.pyenv/versions/idsm3/lib/python3.7/site-packages/yamale/schema/schema.py", line 83, in _validate
    return self._validate_item(validator, data_item, position, includes)
  File "/Users/hhorsey/.pyenv/versions/idsm3/lib/python3.7/site-packages/yamale/schema/schema.py", line 112, in _validate_item
    includes, position)
  File "/Users/hhorsey/.pyenv/versions/idsm3/lib/python3.7/site-packages/yamale/schema/schema.py", line 163, in _validate_any
    err = self._validate_item(v, data, pos, includes)
  File "/Users/hhorsey/.pyenv/versions/idsm3/lib/python3.7/site-packages/yamale/schema/schema.py", line 104, in _validate_item
    includes, position)
  File "/Users/hhorsey/.pyenv/versions/idsm3/lib/python3.7/site-packages/yamale/schema/schema.py", line 150, in _validate_include
    errors += include_schema._validate(validator, data, includes=includes, key=key, position=pos)
  File "/Users/hhorsey/.pyenv/versions/idsm3/lib/python3.7/site-packages/yamale/schema/schema.py", line 75, in _validate
    data_item = util.get_value(data, key)
  File "/Users/hhorsey/.pyenv/versions/idsm3/lib/python3.7/site-packages/yamale/util.py", line 83, in get_value
    return reduce(getitem, path, dic)[int(last_key)]
ValueError: invalid literal for int() with base 10: 'or'

I'm testing against 1.10.0. Thanks so much!
Ry

I tested your example (changed example1 and example2 to use the blended-spec) with the code from PR #60 and it validates successfully without any crash.

@drmull Brilliant! Thanks so much. I should have caught the include map fix in #60 - would you prefer I close this now, or wait for @mildebrandt to merge #60 first?

@rHorsey I would keep it open until the PR is merged

This is available in version 2.0.


Sidebar style updates

Addresses #7919 styling of sidebar to match ui redesign colour scheme.
Colour changes to the page explorer portion of the sidebar are temporary to avoid major colour clashes until a new UI design for the page explorer is ready.
This doesn't address #7918 for interaction updates

[x] Background colour change to wagtail's new primary colour
[x] Wagtail bird animation tweak and svg refactor
[x] Update top “expand” icon to match designs
[x] Move search icon to the left when sidebar is expanded
[x] Wagtail logo size decrease to circular when sidebar is in slim (collapsed) mode
[x] Change profile image to be circular
[x] Styling of account and logout links to match design
[x] Match colours of subnavigation backgrounds to new sidebar colour scheme
[x] Ensure colour contrast still meets WCAG 2.1 standard

Screenshots
Nested subnav

Logo on hover

With page explorer

Browsers tested on

Chrome 99
Safari 15

The end result looks great @stevedya! There are a few issues with the implementation, and a few more refactorings to do, but we’re not far off.
As far as the UI, I could spot the following issues:

On mobile viewports, the spacing around the account toggle is missing
On mobile viewports, the hamburger button isn’t aligned with the close button
On mobile viewports, the space for the "close" button is still there even though the button has been moved to the right side of the screen
I can’t see the "Close" button on mobile on some pages – it’s there on /admin/, but not on /admin/pages/60/.
On pages like /admin/pages/60/edit/, we’ve moved the hamburger button to the right, but the extra space needed to the left hasn’t been removed
On a 320px viewport, the page explorer scrolls horizontally due not taking over the whole screen anymore. I think we’d want no horizontal scrolling
In sub-menus, the menu icons don’t seem to have enough contrast against their background. We’d need a minimum of 3:1. Looks like this is because the icon has an opacity of 0.15, on top of us changing the color to a transparent white.

And more minor things, where I might have it wrong:

I’d expect the locale selector in the page explorer should keep having the same background as the rest of the explorer header
I’d expect the colors of the icons in the page explorer should be more consistent

Summary GIF:

The end result looks great @stevedya! There are a few issues with the implementation, and a few more refactorings to do, but we’re not far off.
As far as the UI, I could spot the following issues:

On mobile viewports, the spacing around the account toggle is missing
On mobile viewports, the hamburger button isn’t aligned with the close button
On mobile viewports, the space for the "close" button is still there even though the button has been moved to the right side of the screen
I can’t see the "Close" button on mobile on some pages – it’s there on /admin/, but not on /admin/pages/60/.
On pages like /admin/pages/60/edit/, we’ve moved the hamburger button to the right, but the extra space needed to the left hasn’t been removed
On a 320px viewport, the page explorer scrolls horizontally due not taking over the whole screen anymore. I think we’d want no horizontal scrolling
In sub-menus, the menu icons don’t seem to have enough contrast against their background. We’d need a minimum of 3:1. Looks like this is because the icon has an opacity of 0.15, on top of us changing the color to a transparent white.

And more minor things, where I might have it wrong:

I’d expect the locale selector in the page explorer should keep having the same background as the rest of the explorer header
I’d expect the colors of the icons in the page explorer should be more consistent

Summary GIF:

I believe I've fixed these mobile issues now.

Put the expand on the left for mobile viewports, so it will be similar to where it was before and the close button will be in the same spot of the nav as the expand
Ensured the page navigator is set to full width on mobile.
Ensured the icon will be showing for the home page and back buttons to the left of a page explorer header (on mobile)
Allowed title / icons to flex and wrap so that text can fit along with any labels for locale/page status
Adjusted menu icon colours by default.

(I should note ben does have plans to give the page explorer a proper reskin in the future however this is a temporary solution to match the  new sidebar styling)
Here's a screenshot at 320 on Chrome 99 (for reference)


flutter start initializes the Xcode project if the user has not already done so.

cc @devoncarew. I have also moved the guts of the initialization logic out of the command file so that it can be called from multiple places.

This sgtm, but can we just run ios --init as a part of create?  Or does ios --init require bits of xcode which create doesn't?

flutter ios --init made a lot of sense when the ios port was brand new, but doesn't make much sense now when we expect all devs will want both android and ios.  I could imagine wanting to have some sort of ios upgrade, but presumably that would just be rolled into flutter upgrade?

LGTM

Or does ios --init require bits of xcode which create doesn't?

Yeah, create only initializes the user editable components of the Xcode project. It does not download all the device runners.

Addressed all comments and rebased.

lgtm, +1 to refactoring out of the command file.
nit re: the file naming, initialize_xcode.dart sounds like it's setting up xcode, not the app's xcode project. I don't have a better name off-hand.
As mentioned in this PR, I think we do want to move to doing things in flutter create and flutter upgrade like in the android workflow. Perhaps file a bug to capture that?

Fixes https://github.com/flutter/flutter/issues/1909

@devoncarew Just saw your comment updated inline. setup_xcodeproj.dart maybe then? Will update it in another patch.

setup_xcodeproj.dart sgtm


add module identifier as plugin path

fixes #1393

I added '@fastify/compress' as test, but I think that I should add it as dev dependency, any suggestion?

Can you fix the DCO?

I am not sure that it is working correctly, if i add reply.compress to app.get('/', () => 'hello world') then compress is undefined.

Can you fix the DCO?

Sure, I will try

Closing in favor of https://github.com/platformatic/platformatic/pull/1823.


VM creation failure should output the correlation ID of the creation operation

Describe the bug
When a command such as az vm create fails, it returns the correlation ID of the operation that was used to check the deployment status, rather than the correlation ID of the original long-running operation.
To Reproduce
Create a VM in a way that the long-running operation fails (for example, setting unsatisfiable constraints).
Expected behavior
I'd expect to get the correlation ID for the original creation operation.
I work in the Microsoft Azure ARM SRE team, and this would help me troubleshoot those failures rather than having to look for the original correlation ID in our internal logs.
Environment summary
Not relevant.
Additional context
Feel free to reach out to me at<EMAIL_ADDRESS>for more context or examples.

VM creation

hi @qwordy, let's discuss this offline. cc @houk-ms for error message improvment.


[Feature Request] Offer Litecoin Address Resolution

Request
Though this repo supports BTC and ETH address resolution it would be ideal to offer the same functionality for Litecoin (Ł).

Hi! Thanks for opening an issue. Our library already supports other currencies, including Litecoin (LTC). You can see that the addr method accepts any string as a ticker, it isn't limited to accept only BTC or ETH. If you have any troubles with resolving LTC addresses of your domains, please let us know.
Meanwhile, we'll try to update our readme to make this clearer.

@mvlabat thanks for the note!  I will take a look at it for testing.

I'll close this issue due to inactivity. Please feel to comment here or open another one if you have any problems with resolution.


[WIP] Convert Flowlayout to be KMP

Just exploring, nothing to see here.

@chrisbanes What is left to do on this?

Looks like this is abandoned because Chris Banes is no longer working for Google.


Implement UndoCommand and RedoCommand #135 #390

Fixes #135, #390.
User is unable to undo and redo the actions he / she has made.

User is unable to recover from mistakes. For example, if the user
accidentally enters the clear command, he / she will lose all the data
in AddressBook, and there are no ways to retrieve the data back.

Let's implement UndoCommand and RedoCommand so that the user can
recover from his / her mistakes.

v1
@Zhiyuan-Amos submitted v1 for review.

[v1 1/5] Create ReversibleCommand and update some commands to extend it
[v1 2/5] Create CommandObject
[v1 3/5] CommandHistory & ListElementPointer: Use CommandObject instead of String
[v1 4/5] Create undo and redo commands
[v1 5/5] Teach parser

(:books: Archive)

Checkout this PR version locally
git fetch https://github.com/se-edu/addressbook-level4.git refs/pr/547/1/head:BRANCHNAME

where BRANCHNAME is the name of the local branch you wish to fetch this PR to.

For architectural review. UndoCommand and RedoCommand look untidy; intentionally not refactoring it first.

@damithc , Zhi Yuan here. After looking at UndoCommand and RedoCommand with Wang Leng, we thought that the logic looks quite shag, having to consider the different corner cases. :<

As discussed:
Two possible resolution:

=============================================

[1. Add new variables and methods to Command and UndoCommand]

|-----------------------------|
| Command                     |
|-----------------------------|
| ....                        |
| - beforeSnapshot: Snapshot  |
| - afterSnapshot: Snapshot   |
|-----------------------------|
| ....                        |
| + canUndo(): boolean        |
| + hasBeenUndone(): boolean  |
|-----------------------------|

|-----------------------------|
| UndoCommand                 |
|-----------------------------|
| ....                        |
| - commandUndone: Command    |
|-----------------------------|
| ....                        |
| + canUndo(): boolean        |
| + hasBeenUndone(): boolean  |
|-----------------------------|

Undo:
Traverse the list until we found a command that has canUndo() == true and hasBeenUndone() == true.

Redo:
Traverse the list until we found an UndoCommand, apply the UndoCommand.commandUndone.afterSnapshot to the model.

=============================================

[2. Use the stack solution]

Every time a command is executed, it is pushed into an undo stack. (redo stack gets reset)
When we execute undo, pop it out of the undo stack, execute the undo. (push redo stack)
When we execute redo, do it to the same for the redo stack.

=============================================

Yup, I don't mind if you do the undo/redo stack method which may be easier for students to understand.
Even if we come up with a elegant algorithm to find the next command that should be undone/redone, it will take some extensive explaining whereas undo/redo stack can be explained easily.
Once we have the simple implementation (and tests) in place, we can try to switch to a more optimized implementation, if we really want.
In other words, what @pyokagan said.

v2
@Zhiyuan-Amos submitted v2 for review.

[v2 1/7] Add ReversibleCommand and update some commands to extend it
[v2 2/7] Add ReversibleCommandHistory
[v2 3/7] LogicManager: Rename history to commandHistory
[v2 4/7] Teach LogicManager to use ReversibleCommandHistory
[v2 5/7] Command: setData takes in ReversibleCommandHistory too
[v2 6/7] Add UndoCommand and RedoCommand
[v2 7/7] Teach Parser to parse UndoCommand and RedoCommand

(:books: Archive) (:chart_with_upwards_trend: Interdiff between v1 and v2)

Checkout this PR version locally
git fetch https://github.com/se-edu/addressbook-level4.git refs/pr/547/2/head:BRANCHNAME

where BRANCHNAME is the name of the local branch you wish to fetch this PR to.

fyi: Undone with some tests. But that isn't the main issue since we are doing architectural review now :)

Not sure whether the naming is good though: maybe ReversibleCommandHistory can be UndoRedoHistory?

We can avoid History (and the question 'why do you have two kinds of histories?') altogether and call it UndoRedoStack :-)

v3
@Zhiyuan-Amos submitted v3 for review.

[v3 1/6] Add ReversibleCommand and update some commands to extend it
[v3 2/6] Add UndoRedoStack
[v3 3/6] LogicManager: Add field UndoRedoStack
[v3 4/6] Command: setData takes in UndoRedoStack too
[v3 5/6] UndoCommand & RedoCommand: Finish implementation
[v3 6/6] Teach Parser to parse UndoCommand and RedoCommand

(:books: Archive) (:chart_with_upwards_trend: Interdiff between v2 and v3)

Checkout this PR version locally
git fetch https://github.com/se-edu/addressbook-level4.git refs/pr/547/3/head:BRANCHNAME

where BRANCHNAME is the name of the local branch you wish to fetch this PR to.

Made the changes alrd. Also done up the tests! I assume that architecture is fine?

No further comments about architecture so far.

@damithc for your architectural review :)

v4
@Zhiyuan-Amos submitted v4 for review.

[v4 1/6] Add ReversibleCommand and update some commands to extend it
[v4 2/6] Add UndoRedoStack
[v4 3/6] LogicManager: Add field UndoRedoStack
[v4 4/6] Command: setData takes in UndoRedoStack too
[v4 5/6] UndoCommand & RedoCommand: Finish implementation
[v4 6/6] Teach Parser to parse UndoCommand and RedoCommand

(:books: Archive) (:chart_with_upwards_trend: Interdiff between v3 and v4)

Checkout this PR version locally
git fetch https://github.com/se-edu/addressbook-level4.git refs/pr/547/4/head:BRANCHNAME

where BRANCHNAME is the name of the local branch you wish to fetch this PR to.

@yamgent @limmlingg pls nit!

v5
@Zhiyuan-Amos submitted v5 for review.

[v5 1/6] Add ReversibleCommand and update some commands to extend it
[v5 2/6] Add UndoRedoStack
[v5 3/6] LogicManager: Add field UndoRedoStack
[v5 4/6] Command: setData takes in UndoRedoStack too
[v5 5/6] UndoCommand & RedoCommand: Finish implementation
[v5 6/6] Teach Parser to parse UndoCommand and RedoCommand

(:books: Archive) (:chart_with_upwards_trend: Interdiff between v4 and v5)

Checkout this PR version locally
git fetch https://github.com/se-edu/addressbook-level4.git refs/pr/547/5/head:BRANCHNAME

where BRANCHNAME is the name of the local branch you wish to fetch this PR to.

v6
@Zhiyuan-Amos submitted v6 for review.

[v6 1/6] Add ReversibleCommand and update some commands to extend it
[v6 2/6] Add UndoRedoStack
[v6 3/6] LogicManager: Add field UndoRedoStack
[v6 4/6] Command#setData(...): Add UndoRedoStack parameter
[v6 5/6] UndoCommand & RedoCommand: Finish implementation
[v6 6/6] Teach Parser to parse UndoCommand and RedoCommand

(:books: Archive) (:chart_with_upwards_trend: Interdiff between v5 and v6)

Checkout this PR version locally
git fetch https://github.com/se-edu/addressbook-level4.git refs/pr/547/6/head:BRANCHNAME

where BRANCHNAME is the name of the local branch you wish to fetch this PR to.

v7
@Zhiyuan-Amos submitted v7 for review.

[v7 1/6] Add ReversibleCommand and update some commands to extend it
[v7 2/6] Add UndoRedoStack
[v7 3/6] LogicManager: Add field UndoRedoStack
[v7 4/6] Command#setData(...): Add UndoRedoStack parameter
[v7 5/6] Add UndoCommand & RedoCommand
[v7 6/6] Teach Parser to parse UndoCommand and RedoCommand

(:books: Archive) (:chart_with_upwards_trend: Interdiff between v6 and v7)

Checkout this PR version locally
git fetch https://github.com/se-edu/addressbook-level4.git refs/pr/547/7/head:BRANCHNAME

where BRANCHNAME is the name of the local branch you wish to fetch this PR to.

v8
@Zhiyuan-Amos submitted v8 for review.

[v8 1/6] Add ReversibleCommand and update some commands to extend it
[v8 2/6] Add UndoRedoStack
[v8 3/6] LogicManager: Add field UndoRedoStack
[v8 4/6] Command#setData(...): Add UndoRedoStack parameter
[v8 5/6] Add UndoCommand & RedoCommand
[v8 6/6] Teach Parser to parse UndoCommand and RedoCommand

(:books: Archive) (:chart_with_upwards_trend: Interdiff between v7 and v8)

Checkout this PR version locally
git fetch https://github.com/se-edu/addressbook-level4.git refs/pr/547/8/head:BRANCHNAME

where BRANCHNAME is the name of the local branch you wish to fetch this PR to.

@damithc you may be interested in taking a look at the different approach we did the tests in UndoRedoStackTest and ReversibleCommandTest, whereby we created DummyCommands to simplify the testing (i.e tester does not need to know whether AddCommand, DeleteCommand are reversible or not).
I just realized that I didn't make the same change for UndoAndRedoCommandTest, will do so in the next iteration.
cc: @yamgent

note to self: take a look at the tests and partition according to methods

note to self: take a look at the tests and partition according to methods

Yes, divide in a top-down way. First, by methods. After that, if needed, each method by highest-level equivalence partitions e.g. empty stack vs non-empty stack, and so on. That way, we ensure that we are always covering the whole thing and where each piece belongs.

v9
@Zhiyuan-Amos submitted v9 for review.

[v9 1/6] Add ReversibleCommand and update some commands to extend it
[v9 2/6] Add UndoRedoStack
[v9 3/6] LogicManager: Add field UndoRedoStack
[v9 4/6] Command#setData(...): Add UndoRedoStack parameter
[v9 5/6] Add UndoCommand & RedoCommand
[v9 6/6] Teach Parser to parse UndoCommand and RedoCommand

(:books: Archive) (:chart_with_upwards_trend: Interdiff between v8 and v9)

Checkout this PR version locally
git fetch https://github.com/se-edu/addressbook-level4.git refs/pr/547/9/head:BRANCHNAME

where BRANCHNAME is the name of the local branch you wish to fetch this PR to.

Great, the tests look much better now.

v10
@Zhiyuan-Amos submitted v10 for review.

[v10 1/6] Add ReversibleCommand and update some commands to extend it
[v10 2/6] Add UndoRedoStack
[v10 3/6] LogicManager: Add field UndoRedoStack
[v10 4/6] Command#setData(...): Add UndoRedoStack parameter
[v10 5/6] Add UndoCommand & RedoCommand
[v10 6/6] Teach Parser to parse UndoCommand and RedoCommand

(:books: Archive) (:chart_with_upwards_trend: Interdiff between v9 and v10)

Checkout this PR version locally
git fetch https://github.com/se-edu/addressbook-level4.git refs/pr/547/10/head:BRANCHNAME

where BRANCHNAME is the name of the local branch you wish to fetch this PR to.

I will update the Developer Guide in the next PR :)

v11
@Zhiyuan-Amos submitted v11 for review.

[v11 1/6] Add ReversibleCommand and update some commands to extend it
[v11 2/6] Add UndoRedoStack
[v11 3/6] LogicManager: Add field UndoRedoStack
[v11 4/6] Command#setData(...): Add UndoRedoStack parameter
[v11 5/6] Add UndoCommand & RedoCommand
[v11 6/6] Teach AddressBookParser to parse UndoCommand and RedoCommand

(:books: Archive) (:chart_with_upwards_trend: Interdiff between v10 and v11)

Checkout this PR version locally
git fetch https://github.com/se-edu/addressbook-level4.git refs/pr/547/11/head:BRANCHNAME

where BRANCHNAME is the name of the local branch you wish to fetch this PR to.

Made a lot of changes. 761 lines of code :O

@yamgent thorough review pls

v12
@Zhiyuan-Amos submitted v12 for review.

[v12 1/6] Add ReversibleCommand and update some commands to extend it
[v12 2/6] Add UndoRedoStack
[v12 3/6] LogicManager: Add field UndoRedoStack
[v12 4/6] Command#setData(...): Add UndoRedoStack parameter
[v12 5/6] Add UndoCommand & RedoCommand
[v12 6/6] Teach AddressBookParser to parse UndoCommand and RedoCommand

(:books: Archive) (:chart_with_upwards_trend: Interdiff between v11 and v12)

Checkout this PR version locally
git fetch https://github.com/se-edu/addressbook-level4.git refs/pr/547/12/head:BRANCHNAME

where BRANCHNAME is the name of the local branch you wish to fetch this PR to.

v13
@Zhiyuan-Amos submitted v13 for review.

[v13 1/6] Add UndoableCommand and update some commands to extend it
[v13 2/6] Add UndoRedoStack
[v13 3/6] LogicManager: Add field UndoRedoStack
[v13 4/6] Command#setData(...): Add UndoRedoStack parameter
[v13 5/6] Add UndoCommand & RedoCommand
[v13 6/6] Teach AddressBookParser to parse UndoCommand and RedoCommand

(:books: Archive) (:chart_with_upwards_trend: Interdiff between v12 and v13)

Checkout this PR version locally
git fetch https://github.com/se-edu/addressbook-level4.git refs/pr/547/13/head:BRANCHNAME

where BRANCHNAME is the name of the local branch you wish to fetch this PR to.

v14
@Zhiyuan-Amos submitted v14 for review.

[v14 1/7] Add UndoableCommand and update some commands to extend it
[v14 2/7] Add UndoRedoStack
[v14 3/7] LogicManager: Add field UndoRedoStack
[v14 4/7] Command#setData(...): Add UndoRedoStack parameter
[v14 5/7] Add UndoCommand & RedoCommand
[v14 6/7] Teach AddressBookParser to parse UndoCommand and RedoCommand
[v14 7/7] Update User Guide and Developer Guide

(:books: Archive) (:chart_with_upwards_trend: Interdiff between v13 and v14)

Checkout this PR version locally
git fetch https://github.com/se-edu/addressbook-level4.git refs/pr/547/14/head:BRANCHNAME

where BRANCHNAME is the name of the local branch you wish to fetch this PR to.

Updated UG & DG!

LogicComponentClassDiagram.pptx
@yamgent can see if it looks ok? if so, can help me generate the png file (Ctrl-A to select all, right click and select Save as image). Thanks!

As discussed, right now the diagram seems to be implying that XYZCommand is inheriting from both UndoableCommand and Command. Fixing this problem in the main diagram itself is going to make it very complicated, so the suggestion is to split up this portion to another diagram (where we should the commands that actually inherit from UndoableCommand and Command separately). The objective of the UML at the end of the day is to clearly communicate with developers, not to be extremely accurate.

Prof what do you think of this?

Prof what do you think of this?

OK 👍

v15
@Zhiyuan-Amos submitted v15 for review.

[v15 1/7] Add UndoableCommand and update some commands to extend it
[v15 2/7] Add UndoRedoStack
[v15 3/7] LogicManager: Add field UndoRedoStack
[v15 4/7] Command#setData(...): Add UndoRedoStack parameter
[v15 5/7] Add UndoCommand & RedoCommand
[v15 6/7] Teach AddressBookParser to parse UndoCommand and RedoCommand
[v15 7/7] Update User Guide and Developer Guide

(:books: Archive) (:chart_with_upwards_trend: Interdiff between v14 and v15)

Checkout this PR version locally
git fetch https://github.com/se-edu/addressbook-level4.git refs/pr/547/15/head:BRANCHNAME

where BRANCHNAME is the name of the local branch you wish to fetch this PR to.

v16
@Zhiyuan-Amos submitted v16 for review.

[v16 1/7] Add UndoableCommand and update some commands to extend it
[v16 2/7] Add UndoRedoStack
[v16 3/7] LogicManager: Add field UndoRedoStack
[v16 4/7] Command#setData(...): Add UndoRedoStack parameter
[v16 5/7] Add UndoCommand & RedoCommand
[v16 6/7] Teach AddressBookParser to parse UndoCommand and RedoCommand
[v16 7/7] Update User Guide and Developer Guide

(:books: Archive) (:chart_with_upwards_trend: Interdiff between v15 and v16)

Checkout this PR version locally
git fetch https://github.com/se-edu/addressbook-level4.git refs/pr/547/16/head:BRANCHNAME

where BRANCHNAME is the name of the local branch you wish to fetch this PR to.

@damithc prof you can take a chill; let @yamgent and @limmlingg vet through it first :P

Dunno whether you want to do something like this...

v17
@Zhiyuan-Amos submitted v17 for review.

[v17 1/7] Add UndoableCommand and update some commands to extend it
[v17 2/7] Add UndoRedoStack
[v17 3/7] LogicManager: Add field UndoRedoStack
[v17 4/7] Command#setData(...): Add UndoRedoStack parameter
[v17 5/7] Add UndoCommand & RedoCommand
[v17 6/7] Teach AddressBookParser to parse UndoCommand and RedoCommand
[v17 7/7] Update User Guide and Developer Guide

(:books: Archive) (:chart_with_upwards_trend: Interdiff between v16 and v17)

Checkout this PR version locally
git fetch https://github.com/se-edu/addressbook-level4.git refs/pr/547/17/head:BRANCHNAME

where BRANCHNAME is the name of the local branch you wish to fetch this PR to.

@damithc for your review :)

v18
@Zhiyuan-Amos submitted v18 for review.

[v18 1/7] Add UndoableCommand and update some commands to extend it
[v18 2/7] Add UndoRedoStack
[v18 3/7] LogicManager: Add field UndoRedoStack
[v18 4/7] Command#setData(...): Add UndoRedoStack parameter
[v18 5/7] Add UndoCommand & RedoCommand
[v18 6/7] Teach AddressBookParser to parse UndoCommand and RedoCommand
[v18 7/7] Update User Guide and Developer Guide

(:books: Archive) (:chart_with_upwards_trend: Interdiff between v17 and v18)

Checkout this PR version locally
git fetch https://github.com/se-edu/addressbook-level4.git refs/pr/547/18/head:BRANCHNAME

where BRANCHNAME is the name of the local branch you wish to fetch this PR to.

@damithc prof for your review :>

v19
@Zhiyuan-Amos submitted v19 for review.

[v19 1/7] Add UndoableCommand and update some commands to extend it
[v19 2/7] Add UndoRedoStack
[v19 3/7] LogicManager: Add field UndoRedoStack
[v19 4/7] Command#setData(...): Add UndoRedoStack parameter
[v19 5/7] Add UndoCommand & RedoCommand
[v19 6/7] Teach AddressBookParser to parse UndoCommand and RedoCommand
[v19 7/7] Update User Guide and Developer Guide

(:books: Archive) (:chart_with_upwards_trend: Interdiff between v18 and v19)

Checkout this PR version locally
git fetch https://github.com/se-edu/addressbook-level4.git refs/pr/547/19/head:BRANCHNAME

where BRANCHNAME is the name of the local branch you wish to fetch this PR to.


Fixed Markdown Warning in Ops_select.md

Fixed Markdown Warning coming on Table borders in Ops_select.md . Found and Fix using Pycharm's inspect code.

There are no changes when this gets imported. This is because internal autoformatter is different.
Closing PR and associated issue.


Test is not supported

I'm getting this error. Test mode of Shopify Payment is enabled.
The value of payment.test in checkoutCompleteWithTokenizedPaymentV2 is true.

I believe you still have to go through the card payment flow to obtain a token to make this work using one of the test card numbers.

I'm using Stripe to generated token.


GIF_begin build failure fix, etc.

Functional changes:
linux/main.c: too few arguments to function ‘GIF_begin’ #30
Validate GIF Defines configuration

(plus some warnings and a cosmetic cleanups)

I'm fixing this differently. The comment is not needed because those values are not to be changed. I'm not sure what you're seeing with PICO_BUILD, but it should stay the way it is.


Error: "Not running script because past shutdown deadline (x12)"

The error is caused by running Adonis Loader in Roblox Studio. This is the code that is responsible (in Loader.server.lua):
if response == "SUCCESS" then
		if (data.Settings and data.Settings.HideScript) and not data.DebugMode then
			model.Parent = nil
			game:BindToClose(function()
				model.Parent = game:GetService("ServerScriptService")
				model.Name = "Adonis_Loader"
			end)
		end
		model.Name = "Adonis_Loader"
	else

DataModel:BindToClose should not be called from Roblox Studio (see https://developer.roblox.com/en-us/api-reference/function/DataModel/BindToClose).

That's odd given I have had no issues with Adonis running in Roblox Studio. I have never seen an error similar to that before, except if I exit Play Solo before it has a chance to load properly.

Someone had the same error appear on the discord (unless that was you?) but I personally have not encountered it yet.

That was not me on Discord. I had to disable the loader in Roblox Studio with:
RunService:IsStudio()

I am not sure what causes it to break though. My best guess is that the place I am hired to fix dates from 2019, when this bug 'https://devforum.roblox.com/t/bindtoclose-100-infinite-yield/170469' was a thing.

Gonna see what I can do about this now.

Its probably because when you stop a local GameServer it ignores BindToClose from yielding as it forces the server to close.


Option 'strictPropertyInitialization' cannot be specified without specifying option 'strictNullChecks'

Upgrading from 2.8.1 to 2.9.1, I'm now getting the error in the title.
Why strictPropertyInitialization now can't be specified without strictNullChecks? Is it a bug?

@marcomura I think, it is not a bug, see #23659

SPI does nothing if SNC isn't on, so this warning is to tell you that you're not doing what you think you are

Why strictPropertyInitialization should require stringNullChecks?
I don't see how the first should require the second...
class C {
    foo: number;
    bar = "hello";
    baz: boolean;
    //  ~~~
    //  Error! Property 'baz' has no initializer and is not assigned directly in the constructor.
    constructor() {
        this.foo = 42;
    }
}

Without stringNullChecks, I can solve the error explicitly assigning undefined to baz.

Ping on this :)

Please see what --strictNullChecks really mean at https://github.com/Microsoft/TypeScript/wiki/What's-new-in-TypeScript

That's why I can't see its relation with --strictPropertyInitialization


Remove check for docblock when trying to find parent entities (#54)

Can you add test case?

Added test case. Not sure if the way test implemented is fine. Thank you.

After this fix I got generated extra columns from child entities in parent class (JTI usage) schema declaration. Don't merge it. Need complex test and code refactoring.

@msmakouz can be related with https://github.com/cycle/annotated/pull/65

After this fix I got generated extra columns from child entities in parent class (JTI usage) schema declaration. Don't merge it. Need complex test and code refactoring.

Hi, this bug fixed by: #65


Improve cross-compatibility between SNANA and SNCosmo

I am working on fitting SNANA sims with SNIa models in SNCosmo. As a result, I am finding some unnecessary name conversions between the two programs.
Between my read_snana_fits() and mcmc_lc() calls, I currently need to
data.rename_column("FLUXCAL", "flux")
data.rename_column("FLUXCALERR", "fluxerr")
data.rename_column("ZEROPT", "zp")

We can improve this workflow by either

adding these names to PHOTDATA_ALIASES
or, adding an extra flag to read_snana_fits() that performs some standardization on names.

I think option 1 is best, but option 2 could also add a data["zpsys"] = "ab" column if no zero-point system is found.

The first option sounds good to me. Want to write up a quick PR and we can get it into v2.6?
Is the zeropoint in SNANA standardized internally, or are there models with a range of different zeropoints? We need to be very careful about assuming a zeropoint/zpsystem when one isn't specified.

I might be able to get a PR in, when are you releasing v2.6?
I am not sure if SNANA has a standard, but we can add an option where the user can provide the string that gets assigned to data["zpsys"], but at that point it is probably better to just have the user specifically add the column after import.

I'm hoping to release 2.6 today or tomorrow.
This change is just adding a couple of strings to a list. I can whip it up
in a couple mins if you want.
On Thu, Sep 9, 2021, 12:14 Benjamin Rose @.***> wrote:

I might be able to get a PR in, when are you releasing v2.6?
I am not sure if SNANA has a standard, but we can add an option where the
user can provide the string that gets assigned to data["zpsys"], but at
that point it is probably better to just have the user specifically add the
column after import.
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/sncosmo/sncosmo/issues/318#issuecomment-916367495,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AAGA24PUKGUVVU4ZMVYWOU3UBEBS5ANCNFSM5DXRZGIQ
.
Triage notifications on the go with GitHub Mobile for iOS
https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675
or Android
https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.

I'm working on it now. I just needed to finish another project first (and before the end of the day).

I am double-checking that FLUXCAL is what I think it is. In doing this, I found out that SNANA uses both FLUX and FLUXCAL. If a user imports a SNANA data file that has both, option 1 will cause a problem and break previously working scripts.

Reading the SNANA manual, it looks to me like the FLUX column is the flux in ADU with the zeropoint given by ZEROPT while FLUXCAL is the flux scaled by 10^11 (a zeropoint of 27.5). So FLUXCAL is probably something that we need to handle separately.
Adding zeropt to the list of aliases in photdata seems to make sense though, and would probably make most things work.

Now I'm confused... it looks like only FLUXCAL and FLUXCALERR are available in most files, and that they should have a zeropoint of 27.5?
Let's hold off on this for the v2.6.0 release and take some time to figure it out. I looked at some of my scripts for reading SNANA light curves and they are a mess...

it looks like only FLUXCAL and FLUXCALERR are available in most files, and that they should have a zeropoint of 27.5

This is correct. There is an additional difference in the definition of x_0/m_B
I can take a look at this PR, but it won't happen by tomorrow. So please hold off on it for the 2.6.0 release.  Also, for compatibility, I think the simlib_read function is out of date.  There is an issue on this already.
For more cross-compatiblity an item that would help is casting SNCosmo in SNANA form to enable running the SNANA fitter.

While we are talking about SNCosmo/SNANA integration problems here one thing that bothers me is that the table name must be manually specified when reading an SNANA ascii file. This is documented in the docstring of read_snana_ascii, but is really annoying and there is probably a better solution. It would be good to look into how SNANA handles this and copy it.

Sounds like we need a meta/tracking issue. Is this that issue or is this issue just about the PHOTODATA_ALIASES?
On Sep 9, 2021, 7:15 PM -0400, Kyle Boone @.***>, wrote:

While we are talking about SNCosmo/SNANA integration problems here one thing that bothers me is that the table name must be manually specified when reading an SNANA ascii file. This is documented in the docstring of read_snana_ascii, but is really annoying and there is probably a better solution. It would be good to look into how SNANA handles this and copy it.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub, or unsubscribe.
Triage notifications on the go with GitHub Mobile for iOS or Android.


Function suggestion)

Hello!!)) I am shocked and delighted with the work done on this mod and now I can't imagine my game without it) Thank you so much for doing this, you are very cool))) Is it possible to add a function that would remove all the sparkling effects of attack and magic and elixirs? Well, for example, the absorption of vampire health, so that the caretaker's shovel does not have a visual, green effect of absorbing health. Or when you put a glyph or a special rune on the armor of a rune master, then the green effect in battle is triggered, like a vampire absorption, it's very annoying and such a function would just be very useful and irreplaceable, otherwise Geralt sparkles like a Christmas tree during the battle... It's just that sometimes you can't see at all what happens in battle because of these effects))etc

mod_no_green_effect_on_player.zip
Try this.

Uraaaa))!!!It worked)) You were able to solve it so quickly) You are a real professional) But the red effect and the yellow absorption effect still work... these effects are caused by runes that the runemaster applies to weapons and armor. Yellow and red have similar effects on weapons from runes and green effect from buff on armor.

Ah I need to take a look at the code again to be sure of the effect names. I think those effects might exist in multiple places within the script, and thus would be kind of troublesome to do. I could also directly remove the effects themselves from the player, but it would cause major compatibility issues with other mods.
But yeah I'll think about it if I want to continue making mods to remove effects. No guarantees.
By the way, for suggestions, I would recommend you contact me on discord in my channel:
https://discord.gg/xPBgHs42Cb

thank you very much))


Demo PR. New Contributor.

Joining the Open Source Community :smile:

Hey @ritvij14, great to see you here. Do you remember me? well I remember you :).

welcome to the community. Have a great journey here.

Hi @Abhishek-kumar09 ! Yep, I remember you :smile:! Good to see you again!

You have managed to get a beautiful github intro page. loved it.


Adaptation for working with Exonum version 0.9

Overview
Please describe your changes here and list any open questions you might have.

See: https://jira.bf.local/browse/XYZ
Definition of Done

[ ] There are no TODOs left in the code
[ ] Change is covered by automated tests
[ ] The coding guidelines are followed
[ ] Public API has Javadoc
[ ] Method preconditions are checked and documented in the Javadoc of the method
[ ] The continuous integration build passes

I thought it would be much more difficult :D
Looks good to me, but I think it's impossible to merge right now (because we need to update our compiler version first). And we also need to fix this issue with factory name. I think EJB team will handle the rest of it, if you don't mind, @aleksuss. Thank you!

@vitvakatu you are welcome. I suppose this PR can help you to create a temporary workaround for bumping version of Exonum up to 0.9.

This PR can help https://github.com/exonum/exonum/pull/929
It adds blockchain which contains api_sender into ServiceApiBuilder

This PR can help exonum/exonum#929
It adds blockchain which contains api_sender into ServiceApiBuilder

Thanks! @vitvakatu is already working on updating the EJB to 0.9.x :tada:


2674: initialize AWS S3 explicitly from automatic envars

Context
Adding and binding aws-s3-bucket service to the app automatically adds some envars but we still need to explicitly initialiase the client from those envars.
Changes proposed in this pull request
Guidance to review

 Scale bulk allocation updates


Distribute libsbcl shared and static libraries through Conda

Currently, using sbcl-librarian to build shared libraries requires (1) building SBCL from source and then (2) building the SBCL runtime into either a shared library (Linux and macOS) or a static library for further linking (Windows). On macOS and Linux, downstream users also require a copy of the runtime shared library on their systems.
To reduce the burden of building SBCL from source, we should distribute both shared library and static library builds of the SBCL runtime on macOS, Linux, and Windows. A good initial distribution channel for these built binaries is Conda since we anticipate many users wanting to wrap Lisp code into Python libraries.
The implementation plan is as follows:

Update the Linux and macOS sbcl recipes on conda-forge to at least 2.1.10 which adds support for foreign callables. Changes need to be made here.
Add a Windows build to sbcl-feedstock.
Either: (1) create a new libsbcl conda package that uses the updated sbcl package to bootstrap the build or (2) add libsbcl shared and static libraries to the existing sbcl conda package.

The maintainers of sbcl-feedstock have added a Windows build and added shared library creation to all platforms.


Tausi

Pulls in tradition styling for Kenyan judgments
improves footnote styling
hierarchical numbered elements using padding not margin, so that show-structure works a bit better

Ref https://github.com/laws-africa/tausi/issues/1279

Merge https://github.com/laws-africa/la-web-components/pull/44 once this is merged


fix: evaluate transition properties when leaving part

A transition on a part can delay pieces inside that part. When leaving the part the overlap with the next part is calculated, during said calculation we need to consider the transition properties such that the timing of the pieces will remain correct. In order to do this without looking at the previous previous part we should save these transition properties on the part instances.
This PR changes:

Save the transition properties on the part instance during a take
Consider the transition properties during transformation from the previous part to timeline

@baltedewit I went to quickly resolve my comment, and then noticed that both https://github.com/nrkno/tv-automation-server-core/pull/400/files#diff-a6ab1806565e12da53c451b7d616b9b81531826f66a93b9738fb265a55c6231bL626-L630 and https://github.com/nrkno/tv-automation-server-core/pull/400/files#diff-a6ab1806565e12da53c451b7d616b9b81531826f66a93b9738fb265a55c6231bL673-L679 were taking the numbers from themselves, not the part before.
It was just the allowed property that was based on the part before, so now only that one property is preserved

Codecov Report

Merging #400 (5063503) into release28 (5511234) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@             Coverage Diff             @@
##           release28     #400    +/-   ##
===========================================
  Coverage      69.11%   69.11%
===========================================
  Files            211      211
  Lines          14081    14082     +1
  Branches        3316     3160   -156
===========================================
+ Hits            9732     9733     +1
- Misses          4175     4176     +1
+ Partials         174      173     -1

Impacted Files
Coverage Δ

meteor/lib/collections/PartInstances.ts
100.00% <ø> (ø)

meteor/server/api/playout/take.ts
62.73% <100.00%> (+0.23%)
:arrow_up:

meteor/server/api/playout/timeline.ts
73.98% <100.00%> (ø)

meteor/server/DatabaseCaches.ts
91.83% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5511234...5063503. Read the comment docs.

both timeline.ts#L626-L630 and timeline.ts#L673-L679 were taking the numbers from themselves, not the part before.

Ooh, yeah, of course they are. I didn't even bother to look at that.


Building fail

Hi,
When build  I have this error :
No such file or directory @ rb_sysopen - /var/folders/rh/ng8mv_5x24dbkvp87l189dnw0000gn/T/middleman-robots20170509-38873-1dv9lw4 /usr/local/opt/rbenv/versions/2.3.3/lib/ruby/gems/2.3.0/gems/middleman-core-4.2.1/lib/middleman-core/util/binary.rb:70:in read' /usr/local/opt/rbenv/versions/2.3.3/lib/ruby/gems/2.3.0/gems/middleman-core-4.2.1/lib/middleman-core/util/binary.rb:70:in file_contents_include_binary_bytes?'
Here is my Gemfile:
gem 'middleman', '~> 4.0' gem 'middleman-livereload' gem 'middleman-sprockets', github: 'middleman/middleman-sprockets' gem 'builder' gem 'middleman-robots', '~> 1.3.1'
Ps: it's working fine one 1.3.0 ;)
Don't hesitate if ou have any question!
Thanks

Thank you for the report. I think it is probably a problem with tempfile access permissions.
v1.3.2 is released. Please try new version.


download_pdb_seqres.sh uses HTTP, only works for FTP

The script download_pdb_seqres.sh uses the URL
https://ftp.wwpdb.org/pub/pdb/derived_data/pdb_seqres.txt

That url doesn't work; the file must be downloaded using anonymous ftp.

#838 solved this for me

Thanks for reporting, fixed in https://github.com/google-deepmind/alphafold/commit/f78c5893044aa148be7f020f8a1094a556893184.


Stratux Logo?

Wondering if anyone is interested in creating an official logo for the project?  Can't seem to find one anywhere, but not surprising since everyone on the dev group is busy making it way better everyday, not drawing silly logos.  Drawing a case up for my rpi3 and want to put a stratux logo on top.  If I come up with something I think is acceptable I'll put it here.  Should I ask for submitions on reddit?
Thanks!
-Anders

https://github.com/cyoung/stratux/tree/master/web/img
https://github.com/cyoung/stratux/blob/master/web/img/screen-1536x2008.png
This is the official logo now. If you want to design a new one, re-open the issue and post here and we'd gladly consider it. Thanks for the suggestion.


[CP] [3.7][iOS] Toolbar of Textfield in Appbar is shown at the wrong position

issue_link
#119441
Commit Hash
00b0d550c6847afe335825560efbd7ac119c25a7
Target
stable
pr_link
I can't cherry-pick it because of conflicts.
Impacted Users
All iOS users
Impact Description
See #119441
Workaround
None
Risk
medium
Test Coverage
yes
Validation Steps
See #119441

@limenote135 could you give the cherry-pick another shot.

@itsjustkevin I tried to cherry-pick 00b0d550c6847afe335825560efbd7ac119c25a7 into flutter-3.7-candidate.1 branch, but it conflicts.
$ git cherry-pick 00b0d55
Auto-merging packages/flutter/lib/src/cupertino/text_selection_toolbar.dart
CONFLICT (content): Merge conflict in packages/flutter/lib/src/cupertino/text_selection_toolbar.dart
CONFLICT (modify/delete): packages/flutter/lib/src/material/spell_check_suggestions_toolbar.dart deleted in HEAD and modified in 00b0d550c6 (Fix iOS context menu position when flipped below (#119565)).  Version 00b0d550c6 (Fix iOS context menu position when flipped below (#119565)) of packages/flutter/lib/src/material/spell_check_suggestions_toolbar.dart left in tree.
Auto-merging packages/flutter/lib/src/material/text_selection_toolbar.dart
CONFLICT (content): Merge conflict in packages/flutter/lib/src/material/text_selection_toolbar.dart
Auto-merging packages/flutter/test/cupertino/text_selection_toolbar_test.dart
CONFLICT (modify/delete): packages/flutter/test/material/spell_check_suggestions_toolbar_test.dart deleted in HEAD and modified in 00b0d550c6 (Fix iOS context menu position when flipped below (#119565)).  Version 00b0d550c6 (Fix iOS context menu position when flipped below (#119565)) of packages/flutter/test/material/spell_check_suggestions_toolbar_test.dart left in tree.
error: could not apply 00b0d550c6... Fix iOS context menu position when flipped below (#119565)

if there is a conflict in cherry pick you might want to seek help from the pr author Justin. Meanwhile i think we need the label of "cp:approve" too to proceed?

@justinmc, could you please create PR for stable branch?

@itsjustkevin @XilaiZhang @justinmc What is the status of this?

I can take a look at cherry picking this.  It seems reasonable since it was a small low-risk change that fixed a bad visual bug.
What branch should this be cherry picked into now?

@justinmc Thanks for your help! It seems flutter-3.7-candidate.1 branch is for current stable branch.

@limenote135 and @justinmc thank you for the cherry-pick.  I have updated the PR.  I am assuming this has your approval @justinmc?

Yes I approve this as a cherry pick 👍

Looks like this has been released, can we close this issue?

Merged into Flutter 3.7.8.


Add support to edit volume description

Added support to update volume description.
https://github.com/user-attachments/assets/d982c321-50a9-4574-98e7-53792cce410a
Closes #41

@xx-db can you also review please?


Default to downloading the correct framerate

Checklist

[x] I'm reporting a feature request
[x] I've verified that I'm running youtube-dl version 2019.04.30
[x] I've searched the bugtracker for similar feature requests including closed ones

Description

Currently, bestvideo, the default option, does not download the best version of the video. As noted in https://github.com/ytdl-org/youtube-dl/issues/20924#issuecomment-488352225, downloading a 720p60 YouTube video with youtube-dl produces a 720p30 file - equivalent to throwing away half of the video content. youtube-dl should default to downloading videos in their correct framerate, rather than arbitrarily forcing lower framerates.

This is expected behavior since 30 fps video has higher bitrate.


Remove SOLR mounts

Removes SOLR mounts from static (cloud) and local development environment.
As it stands now, the primary use case for this mount is the Initial environment bootstrapping (i.e. a Drupal init script creates the initial SOLR core).  As the cloud environments will not rely on Drupal bootstrapping SOLR, there is no need to expose the SOLR mount to Drupal.  This, this PR removes the mount from the static envornment.
However, over the course of researching the solr behaviour to determine if Drupal needed the mount for any other purpose, the module documentation mentions:

Note: Every time you add a new language to your Drupal instance or add a custom
Solr Field Type you have to update your core configuration files. Using the
example above they will be located in /var/solr/data/test-core/conf. The Drupal
admin UI should inform you about the requirement to update the  configuration.
Reload the core after updating the config using
curl -k http://localhost:8983/solr/admin/cores?action=RELOAD&core=$CORE on
the command line or enable the search_api_admin sub-module to do it from the
Drupal admin UI.
Note: There's file called solrcore.properties within the set of generated
config files. If you need to fine tune some setting you should do it within this
file if possible instead of modifying solrconf.xml.

The initial SOLR configuration is created by the ISLE install process.  To date, we have not encountered the kind of index change that would require new SOLR config.  If we ever did, we have no defined process for doing so in the development environment, nor do we have a defined process for updating the SOLR config in the cloud environment.  The likelihood of ever needing to do so is unclear.  To assure that we never encounter a situation where a developer accidentally updates the SOLR config in a snapshot SOLR instance and "calls it a day", this PR also removes the mount from the local/development environment.
Removing the mount obviously would affect make bootstrap target, which installs the stack from scratch (including creating a SOLR core).  At present, however, this target is broken.   If or when we address fixing the make bootstrap process, we can figure out how to initialize SOLR without having to have SOLR mounted by the Drupal container at runtime after install.
To test
Try poking at SOLR and make sure it still works as expected.  For example:

change the fields indexed
reindex all items

Resolves jhu-idc/idc-general#260

I haven't tested yet, but just read through the description. I have added a new FieldType (language_value_pair) (prior to this PR).  I did update the Drupal fields being index, but nothing in SOLR directly - though I guess drupal must have. I updated the Drupal Default Solr Index pages (Fields tab): https://islandora-idc.traefik.me/admin/config/search/search-api/index/default_solr_index.
However, I anticipate once the config settles, this type of addition will not happen much, if at all.
Is the risk of keeping the mount that it's an attack vector?  Why does it need to go?

I haven't tested yet, but just read through the description. I have added a new FieldType (language_value_pair) (prior to this PR).  I did update the Drupal fields being index, but nothing in SOLR directly - though I guess drupal must have. I updated the Drupal Default Solr Index pages (Fields tab): https://islandora-idc.traefik.me/admin/config/search/search-api/index/default_solr_index.
However, I anticipate once the config settles, this type of addition will not happen much, if at all.
Is the risk of keeping the mount that it's an attack vector?  Why does it need to go?

In production we don’t give clients direct access to the data store of the service.  As drupal is the client to SOLR, that would be same with in this situation. Is this something you can change in the API? If so, having direct access to configuration files is unnecessary and could be a risk.
If you can do this any way that doesn’t require write access to the SOLR files, I would support that.

In production we don’t give clients direct access to the data store of the service.  As drupal is the client to SOLR, that would be same with in this situation. Is this something you can change in the API? If so, having direct access to configuration files is unnecessary and could be a risk.
If you can do this any way that doesn’t require write access to the SOLR files, I would support that.

The risks are theoretical but exist and my job is to reduce risk to the infrastructure wherever possible. Drupal is the entrypoint to this application. If there is a bug in NGINX that allows access to a shell or if there is poorly written PHP (a pretty common problem), access to a system shell is entirely possible. If that container has direct access to a writable mount that powers another service, that is a potential denial of service attack. By deleting all files there, the index and configuration are gone. If that is an avoidable risk, it's unacceptable.
If there is a remotely different way of doing this, best practices recommend we consider that before allowing 3rd party access to update configuration files directly. The Kubernetes way of doing this is through a concept called "init containers". InitContainers are specially crafted containers that run before the main container starts. These containers perform tasks such as configuration modifications, database initialization, settings permissions, creating users, et al. and then exit. This way the modifications happen off of the main container that could be exploited.
That's how I am initializing the MariaDB database for Drupal in the Kubernetes stacks.

The risks are theoretical but exist and my job is to reduce risk to the infrastructure wherever possible. Drupal is the entrypoint to this application. If there is a bug in NGINX that allows access to a shell or if there is poorly written PHP (a pretty common problem), access to a system shell is entirely possible. If that container has direct access to a writable mount that powers another service, that is a potential denial of service attack. By deleting all files there, the index and configuration are gone. If that is an avoidable risk, it's unacceptable.
If there is a remotely different way of doing this, best practices recommend we consider that before allowing 3rd party access to update configuration files directly. The Kubernetes way of doing this is through a concept called "init containers". InitContainers are specially crafted containers that run before the main container starts. These containers perform tasks such as configuration modifications, database initialization, settings permissions, creating users, et al. and then exit. This way the modifications happen off of the main container that could be exploited.
That's how I am initializing the MariaDB database for Drupal in the Kubernetes stacks.

From the tip of development, here is the current solr conf (extracted from the snapshot image)
solr-conf.tar.gz
So far as I can tell, it hasn't been modified since October 8 2020, which is when the dev environment first came live.  Therefore, @bseeger , if there is a new FieldType, it seems clear that it is not the index config used at runtime.  I couldn't find that field type while poking through the search API solr config pages, nor by poking around the schema as shown by the solr server's UI : http://solr-idc.traefik.me/solr/#/ISLANDORA/schema
My motivation for wanting to get rid of the mount in the dev environment is that:

The docs seem to imply that Drupal wouldn't update the config itself anyway; it'd warn the user that the config needs updating, and provide a means to download the updated config (so that the user can put it into the right place underneath SOLR)
If Drupal it did edit config directly in the development environment but not the production environment, the consequences would seem to be bad

Lastly, there is a comment in docker-compose.local.yml:
      # On a production site you may not want to take this approach but instead refer to each of the cores
      # data directories specifically and maintain the configuration as part of a customized image, where
      # in your configuration is Solr managed under source control somewhere.

So if it turns out we actually do need to maintain the schema, we probably need a different approach.
So @bseeger - could you investigate what happened to our custom FieldType?  Maybe we are already at the point where we need to start managing the schema.  At the very least, the exploration and review around removing the mount may have exposed a need we didn't know we had!

From the tip of development, here is the current solr conf (extracted from the snapshot image)
solr-conf.tar.gz
So far as I can tell, it hasn't been modified since October 8 2020, which is when the dev environment first came live.  Therefore, @bseeger , if there is a new FieldType, it seems clear that it is not the index config used at runtime.  I couldn't find that field type while poking through the search API solr config pages, nor by poking around the schema as shown by the solr server's UI : http://solr-idc.traefik.me/solr/#/ISLANDORA/schema
My motivation for wanting to get rid of the mount in the dev environment is that:

The docs seem to imply that Drupal wouldn't update the config itself anyway; it'd warn the user that the config needs updating, and provide a means to download the updated config (so that the user can put it into the right place underneath SOLR)
If Drupal it did edit config directly in the development environment but not the production environment, the consequences would seem to be bad

Lastly, there is a comment in docker-compose.local.yml:
      # On a production site you may not want to take this approach but instead refer to each of the cores
      # data directories specifically and maintain the configuration as part of a customized image, where
      # in your configuration is Solr managed under source control somewhere.

So if it turns out we actually do need to maintain the schema, we probably need a different approach.
So @bseeger - could you investigate what happened to our custom FieldType?  Maybe we are already at the point where we need to start managing the schema.  At the very least, the exploration and review around removing the mount may have exposed a need we didn't know we had!

@birkland  - yeah, I take a look at that today or early tomorrow.  That field is not indexing correctly anyways and I wonder if this is part of why that's the case - because SOLR doesn't really "get" that field.

@birkland  - yeah, I take a look at that today or early tomorrow.  That field is not indexing correctly anyways and I wonder if this is part of why that's the case - because SOLR doesn't really "get" that field.

@birkland  - So I'm realizing the FieldType I was thinking of is different from the solr field type.   I don't believe, after looking at things, that anything I've done in Drupal would end up in the config files, as I haven't added new solr field, just a new Drupal FieldType, which should use the existing solr fields to index into. I've no real concerns with this PR - sorry about the Drupal/Solr Field Type confusion!


[Bug]: SQL plan to view task details ‘could not extract ResultSet’

ODC version
ODC424
OB version
independent
What happened?
SQL plan to view task details ‘could not extract ResultSet’

What did you expect to happen?
。
How can we reproduce it (as minimally and precisely as possible)?
。
Anything else we need to know?
No response
Cloud
No response

性能问题

this bug has fixed by @guowl3


Model importing doesn't work

I'm using django-extensions 2.2.8 and ipython 7.5.0 in django 2.2.10 project.
When I run python manage.py shell_plus, it tells models are imported.
# Shell Plus Django Imports
from django.core.cache import cache
from django.conf import settings

But when I reference it, it shows error name 'settings' is not defined.
It works on some projects and doesn't work for other.
I couldn't figure out what the actual reason is.

Thank you for your report.
(And thanks for listing the version number ! that helps)
However using the django-extensions project itself it works for me and I cannot easily see why it should not work for your project.
You can try using various debugging tools to pin-point where it goes wrong.
Or better yet try to find a reproducible way to create a project where this fails, if it is something internal to Django-Extensions that causes this problem I would love a test & fix for it, or maybe some documentation warning other users about it.
Other then that I cannot see right now what is going wrong here other then that obviously something is messing up the imports.
$ ./manage.py shell_plus
# Shell Plus Model Imports
from django.contrib.admin.models import LogEntry
from tests.collisions.models import Group, SystemUser, UniqueModel
from tests.testapp.models import AbstractInheritanceTestModelChild, ChildSluggedTestModel, Club, CustomFuncPrecedenceSluggedTestModel, CustomFuncSluggedTestModel, CustomModelModificationDateTimeField, DisabledUpdateModelModificationDateTimeField, DummyRelationModel, FKSluggedTestModel, FKSluggedTestModelCallable, FunctionSluggedTestModel, HasOwnerModel, InheritedFromPostWithUniqField, JSONFieldTestModel, Membership, ModelMethodSluggedTestModel, ModelModificationDateTimeField, Name, Note, OverridedFindUniqueModel, Permission, Person, Personality, Photo, Post, PostWithTitleOrdering, PostWithUniqField, RandomCharTestModel, RandomCharTestModelAlpha, RandomCharTestModelAlphaDigits, RandomCharTestModelDigits, RandomCharTestModelLowercase, RandomCharTestModelLowercaseAlphaDigits, RandomCharTestModelPunctuation, RandomCharTestModelUnique, RandomCharTestModelUniqueTogether, RandomCharTestModelUppercase, RandomCharTestModelUppercaseAlphaDigits, ReverseModel, SecondDummyRelationModel, Secret, ShortUUIDTestAgregateModel, ShortUUIDTestManyToManyModel, ShortUUIDTestModel_field, ShortUUIDTestModel_pk, SluggedTestModel, SluggedTestNoOverwriteOnAddModel, SluggedWithConstraintsTestModel, SluggedWithUniqueTogetherTestModel, SqlDiff, SqlDiffUniqueTogether, ThirdDummyRelationModel, TimestampedTestModel, UnicodeVerboseNameModel, UniqueTestAppModel
from django.contrib.auth.models import User
from django.contrib.contenttypes.models import ContentType
from django.contrib.sessions.models import Session
from django.contrib.sites.models import Site
# Shell Plus Django Imports
from django.core.cache import cache
from django.conf import settings
from django.contrib.auth import get_user_model
from django.db import transaction
from django.db.models import Avg, Case, Count, F, Max, Min, Prefetch, Q, Sum, When, Exists, OuterRef, Subquery
from django.utils import timezone
from django.urls import reverse
Python 3.7.6 (default, Dec 30 2019, 19:38:26)
Type 'copyright', 'credits' or 'license' for more information
IPython 7.13.0 -- An enhanced Interactive Python. Type '?' for help.

In [1]: settings
Out[1]: <LazySettings "tests.testapp.settings">


candidate for interactive mode?

Here is example of docker-compose file that is working with docker-compose but it hard get it automatically working on OpenShift/Kubernetes without user input.
version: '2'
services:
  db:
    image: mysql:5.7
    volumes:
      - "./.data/db:/var/lib/mysql"
    restart: always
    environment:
      MYSQL_ROOT_PASSWORD: wordpress
      MYSQL_DATABASE: wordpress
      MYSQL_USER: wordpress
      MYSQL_PASSWORD: wordpress

  wordpress:
    depends_on:
      - db
    image: wordpress:latest
    links:
      - db
    ports:
      - "8000:80"
    restart: always
    environment:
      WORDPRESS_DB_HOST: db:3306
      WORDPRESS_DB_PASSWORD: wordpress

Problem  is that this docker-compose is not saying anything about port for mysq.
Docker-compose doesn't have to do anything for ports that are used just between containers.
Because both containers are attached to the same Docker Network, they can access any ports between them, and they can use container aliases as hostnames.
Afaik  we can't do anything similar on OpenShift :-(
Solution would be to create service for db for port 3306, but we don't know that this should be on port 3306.
So we cat ask user to provide that information during conversion.

+1 @kadel

FYI this kind of error was reported in https://github.com/openshift/origin/issues/8943

Yes, we can make advantage that we can make interactive tool, and ask user to input missing information :wink: instead of showing warning like oc.

@kadel: maybe we can have 2 modes, interactive and non-interactive, we prompt in the former, but in the latter, we show warning just like oc does?

@containscafeine Yes we can do that, and we probably should. But I would say that interactive mode is more important,  with this we can guide user through conversion and show him/her where and how OpenShift/Kubernetes differs from docker-compose.
Lot of people that are going to use this tool will be probably people who are trying OpenShift or Kubernetes for the first time, so Henge can be small introduction into beautiful Kubernetes world :wink:

My brain dump regarding this feature
Example of how interactive mode could work:

if docker-compose service contains build directive

build directory is git repository, ask user if buildConfig with same source as git remote should be created
otherwise ask user for image name and inform user that  he has to build image himself and push it to repository.

if service is missing port definition, as if user wants to expose some ports using services

related issue #27

As we have initial support for interactive mode, I'm going to close this.


Move initialization of some classes to headers

This PR moves the variable initialization of core classes (plus some random ones) to headers. I also cleaned some comments and removed unused destructors.

Thanks!


My contribution

To be on the contribution list you actually have to contribute with something :)
Closing this but you can make a new pull request when you contributed.


[#116] Revert "Use IrodsRunpathDefaults CMake module"

Addresses #116
This reverts commit 820433ed2ff52993f69c055b0d6bbd0d8302986e.
This revert can be re-done once we are no longer concerned with building against 4.3.0.

Closing in favor of #118.


Cloudflare data connector broke

cloudflare data connector is broken no longer showing the function in the function app. Have tried a clean deployment and get this error
'The template parameter 'MaxRunTime' is not found. Please see https://aka.ms/arm-syntax-parameters for usage details.'",
Issue has affected 4 our customers currently using this data connector. Please resolve believe issue is from recent commits 2 weeks ago

Experiencing the same issue in my end.

Our Data Connector has also broken - function no longer present within the function app - this is causing us a huge problem.

this PR seems to be at fault https://github.com/Azure/Azure-Sentinel/pull/9518 @v-atulyadav can this be reverted?

Experiencing the same issue !
Unable to process template language expressions for resource '/subscriptions/xxxxxxxxxxxxxxxxxxx/resourceGroups/Sentinel_Resource_Group/providers/Microsoft.Web/sites/cloudflareqd2sxr4b4bgr2/config/appsettings' at line '154' and column '17'. 'The template parameter 'MaxRunTime' is not found. Please see https://aka.ms/arm-syntax-parameters for usage details.' (Code: InvalidTemplate)

I also have this issue.

Also present.

Hi @philfy20, Thanks for flagging this issue, we will investigate this issue and get back to you with some updates by 20-12-2023. Thanks!

FYI I have raised a Severity B support case via the Azure Portal support feature.

@ingest0x, noted. thanks!

Just discovered that we were affected by this change also. You can roll back to the previous version by updating the WEBSITE_RUN_FROM_PACKAGE app setting to https://raw.githubusercontent.com/Azure/Azure-Sentinel/f159b501922a9d396af6047c40fd93095a3f9778/Solutions/Cloudflare/Data Connectors/CloudflareConn.zip

@scottmckenzie ,We are analyzing the issue and will get back to you with an update

thanks @scottmckenzie ! I'll try give that a go today

Hi @scottmckenzie, sharing update with you, we are working on revert the recent changes. Thanks!

any update on the fix?

Hi @philfy20, we are checking this issue with respective author, meanwhile just want to know have you raised the support case ticket with Cloudflare team?
Thanks!

Hi @philfy20, we are checking this issue with respective author, meanwhile just want to know have you raised the support case ticket with Cloudflare team?
Thanks!

ref support case with Cloudflare "This is owned by Azure, so there is limited action we can take on our side".

@masterchrister, noted thanks!

looks like there is an extra layer of folder inside the package https://aka.ms/sentinel-CloudflareDataConnector-functionapp, that cause the original issue where the connector disappearing from the function app
for the deployment issue, i was able to work around it by adding this piece code into the ARM template between line 10 and 11
    "MaxRunTime": {
        "defaultValue": "10",
        "type": "String"
    },
    "MaximumStorageBlobSize": {
        "defaultValue": "2",
        "type": "String"
    },

but that still doesn't resolve the connector disappearing issue

Hi @philfy20,
We are checking this issue with respective PR author, meanwhile, Could you please follow the below steps and check whether your issue get resolved.
1, Deploy the below Azure deployment file using Custom Deployment-
azuredeploy_Cloudflare_API_FunctionApp.json

Once deployment get successful check the function app in your workspace or resource group -

Then go to Configuration option and chick on the edit option of WEBSITE_RUN_FROM_PACKAGE and replace the existing Value with below shared one -

https://github.com/Azure/Azure-Sentinel/raw/v-mchatla/Cloudflare/Solutions/Cloudflare/Data Connectors/CloudflareConn.zip

Once it gets updated save the changes and restart the function app -

Please let us know once your issue gets resolved.
Thanks!

Hi @philfy20, Could you please have a look on above comment and let us know if your issue get resolved. Thanks!

Updating value  WEBSITE_RUN_FROM_PACKAGE to -
https://github.com/Azure/Azure-Sentinel/raw/v-mchatla/Cloudflare/Solutions/Cloudflare/Data Connectors/CloudflareConn.zip works.
Also seems like updating to https://raw.githubusercontent.com/Azure/Azure-Sentinel/f159b501922a9d396af6047c40fd93095a3f9778/Solutions/Cloudflare/Data Connectors/CloudflareConn.zip works.
Thanks

@philfy20, Thank you for your confirmation. So, closing this issue. If you still need support for this issue, feel free to re-open it any time. Thank you for your co-operation.

This still appears to be an issue when utilizing WEBSITE_RUN_FROM_PACKAGE as https://aka.ms/sentinel-CloudflareDataConnector-functionapp
When deploying today, the function was "found" but never loaded into the runtime to execute

The rolled-back release work for WEBSITE_RUN_FROM_PACKAGE as https://raw.githubusercontent.com/Azure/Azure-Sentinel/f159b501922a9d396af6047c40fd93095a3f9778/Solutions/Cloudflare/Data Connectors/CloudflareConn.zip

When will the Sentinel connector store version of this be fixed?

Any update on CF connector with sentinel, the deployment via sentinel portal still having issue, looking forward to fixed this

Hi @pir8g33k, Apologies for the inconvenience. We are following up with the PR author who made the fix, but as of now, we have not received any response from them. We kindly request you to raise an issue ticket with Cloudflare's support team by sending an email to<EMAIL_ADDRESS>or by visiting their support page at https://support.cloudflare.com/.

@v-sudkharat Cloudflare has already said this is not on them, but on Azure?

https://github.com/Azure/Azure-Sentinel/issues/9601#issuecomment-1864502365

Hi @o-l-a-v, thank you for sharing this update with us. We have shared this information with our team, and they are working on it. Please expect an ETA by 11 Jan 2024.
Thanks!

Hi @o-l-a-v, @pir8g33k, @beachfires, thanks for being connected with us. The fix has been merged and it get reflected into Cloudflare Solution.
Thanks!

Hi @o-l-a-v, @pir8g33k, @beachfires, thanks for being connected with us. The fix has been merged and it get reflected into Cloudflare Solution.
Thanks!

Ok Great thanks for the update and looking forward, i was able to redeploy with the solution you provided above, it would be great if the new fixes applied on sentinel portal deployment file

We have not seen the new release yet within Azure Sentinel Content Hub. When will you be releasing it?


Icons choice for read-only version of checkbox treeview (advice needed, usability)

I'm creating pretty standard admin app, where I have a Role edit page.
On this page, except for editing role name and description, I have a summary of permissions this role has in different app modules/sections.
This information is read-only, and I'm struggling to figure out how to show it.
In page where those permissions are editable, I just use checkbox treeview, like in your examples - it has top-level permissions and subpermissions, If part of subpermissions for top-level permission is enabled, I show indeterminate checkbox for top-level item.

Showing same checkboxes with turned off interaction or in disabled state would confuse users.
Read-only state is something different, after all.
So I'm wondering, which icons could I use to clearly indicate that this is a read-only tree view, and to keep same metaphor of checked/unchecked/indeterminate checkbox.
This is what I came up with recently, but I don't really like the result. It looks less readable than regular checkbox treeview

Is tree view the best choice for this use case?
What other ways can this information be presented?
What is the value in using the same view as the case where they are editable?
Is there any relationship between this user and the one who edits these permissions? i.e. If the read-only permissions were presented differently would the user who sets permissions view permissions in both ways - is this a meaningful concern?
Are icons necessary?
Can a Basic Tree display the list of permissions labelled clearly enough that the type styling of each item can indicate its status?
i.e. black (normal) text for enabled and grey (disabled) text for unavailable? Perhaps minimal iconography will help (e.g. bullet) - small back circle with enabled - hollow grey circle for disabled?
Clarity can’t solve this - the UX of the right choice for the user is a product design concern not part of Clarity - please refer to the suggestions above.


Tutorial code question

Description

yield return new WaitUntil(() => _webCamTexture.width > 16); from

var webCamDevice = WebCamTexture.devices[0];
_webCamTexture = new WebCamTexture(webCamDevice.name, _width, _height, _fps);
_webCamTexture.Play();

yield return new WaitUntil(() => _webCamTexture.width > 16);

Why do need this code? What happens if we don't have this line?

yield return new WaitForEndOfFrame(); from

while (true)
{
  _inputTexture.SetPixels32(_webCamTexture.GetPixels32(_inputPixelData));
  var imageFrame = new ImageFrame(ImageFormat.Types.Format.Srgba, _width, _height, _width * 4, _inputTexture.GetRawTextureData<byte>());
  var currentTimestamp = stopwatch.ElapsedTicks / (System.TimeSpan.TicksPerMillisecond / 1000);
  _graph.AddPacketToInputStream("input_video", new ImageFramePacket(imageFrame, new Timestamp(currentTimestamp))).AssertOk();

  yield return new WaitForEndOfFrame();

  if (multiFaceLandmarksStream.TryGetNext(out var multiFaceLandmarks))
  {
    _multiFaceLandmarksAnnotationController.DrawNow(multiFaceLandmarks);
  }
  else
  {
    _multiFaceLandmarksAnnotationController.DrawNow(null);
  }
}

What happens if we use yield return null instead?

yield return new WaitUntil(() => _webCamTexture.width > 16);

Why do need this code? What happens if we don't have this line?

On macOS or iOS devices, the size of WebCamTexture can be 16x16 even when WebCamTexture#isPlaying returns true.

yield return new WaitForEndOfFrame();

What happens if we use yield return null instead?

This makes a difference in when the coroutine resumes.
This is a pure Unity question, so please ask it elsewhere or google it for more details.

@homuler
Yes, I know WaitForEndOfFrame return after screen rendering, and yield return null return between Update and screen rendering.
I wanted to know why we need to draw landmarks after screen rendering.

I see.
In that sense, we don't need to draw annotations after screen rendering and yield return null might be better.

OK. Thanks for answering!


fix(pubsub): get future value before returning

Closes https://github.com/googleapis/google-cloud-cpp/issues/13240

This change is

I'm not sure what test would cover this.... Do you have any ideas @coryan?

I'm not sure what test would cover this.... Do you have any ideas @coryan?

No simple ideas, just some thoughts on how to start thinking about it: do you have a way to reproduce  #13240 ?  Can you turn that repro into a unit test?

https://github.com/googleapis/google-cloud-cpp/issues/13244


Merge path with route path

Pull Request Test Coverage Report for Build 68daf601-03a1-434b-bc43-d2a8a00afa5c

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 66.894%

Totals

Change from base Build 71db289d-72b1-4289-bc90-b55a3e13386c:
0.0%

Covered Lines:
1238

Relevant Lines:
1747

💛  - Coveralls


"tomorrow 12:05am" returns None

"tomorrow 12:05am" returns None

Hi @flight16 thank you for taking a minute and report this issue. Future dates are not supported as of now but we have plans for them.

Any updates for future support?

Fixed in #137


Ensure GitRepostory.slug is a valid Python package name

Closes: #DNE
What's Changed

Slug GitRepository.slug with slugify_dashes_to_underscores, same as the other places we use slugs for programmatic purposes
Add test to ensure the slug is a valid Python package name
Migration to convert existing repo slugs to valid package names

TODO

[x] Explanation of Change(s)
[ ] Added change log fragment(s) (for more information see the documentation)
[ ] Attached Screenshots, Payload Example
[x] Unit, Integration Tests
[ ] Documentation Updates (when adding/changing features)
[ ] Example Plugin Updates (when adding/changing features)
[ ] Outline Remaining Work, Constraints from Design

Actually, we may also want to pull in the code from custom-fields that makes slug immutable once set without deleting/recreating the repository? Since changing it will affect import paths for jobs?

What if I refactor my jobs? Do I have to delete and re-add the repo?

I wouldn't think so? I'm working on handling this in my current work.

Also it would be pretty fragile to do full package name import since the author of the job may not have access to the GitRepository configuration.

Jobs shouldn't do absolute imports within a Git repository, but on the Nautobot side we have to have an absolute path to import the jobs from. That path would change when re-slugging a GitRepository.


Info message in what when a defence is triggered

Looks good, but I'm getting an 'X' even when just toggling defences, is that right?

Ah no - fixing


Fix colors on hover on the home calendar

On dark theme the hover colors hides completely the arrow keys and the text in the Today and < > arrows. We need to overwrite the styles of the calendar to make it more visible

Fixed at https://github.com/MarckFp/ppoc-gen/commit/1401428aef2fd2a435a5ab11ce1ed4af223fd288


REFACT: Avoid assert calls and try except pass pattern

Updating lines of code considered as bad practice because they may have side effects that are not directly taken into account.
Refact changes:

Avoid using assert as such calls are removed with compiling to optimized byte code. Instead, we now raise an exception (ValueError or KeyError or RuntimeError).
Avoid try: except: pass pattern. Instead, we now log something to info (for public methods) or debug (for other methods).
Adding # nosec for subprocess imports and calls (from what I've seen they shouldn't be a security problem).

Note: Some code refactoring was performed when it made sense.

Codecov Report
Attention: Patch coverage is 36.95652% with 29 lines in your changes are missing coverage. Please review.

Project coverage is 76.63%. Comparing base (2045a0e) to head (409649d).
Report is 6 commits behind head on main.

:exclamation: Current head 409649d differs from pull request most recent head 8f0ceba. Consider uploading reports for the commit 8f0ceba to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4516      +/-   ##
==========================================
- Coverage   81.57%   76.63%   -4.95%
==========================================
  Files         110      110
  Lines       53497    53575      +78
==========================================
- Hits        43640    41055    -2585
- Misses       9857    12520    +2663


unable to catch and handle queue endpoint being unavailable

We've noticed that AWS's SQS endpoints, given enough usage, seem to timeout fairly regularly. This causes the queue:work process to time out as it attempts and fails to fetch a job from the queue.
[Symfony\Component\Process\Exception\ProcessTimedOutException]
  The process ""/usr/bin/php" artisan queue:work
    --queue="https://sqs.us-west-2.amazonaws.com/####/queue"
    --delay=0 --memory=128 --sleep=3 --tries=0"
    exceeded the timeout of 60 seconds.

I've tried setting up an App::error handler for this exception, but no exception handlers appear to be called if queue:listen itself is the trigger (not even my general fallback for Exception). Exceptions within the payload function seem to be handled fine.
Am I going about this the wrong way? Is the only way to handle these process timeouts to have supervisor keep starting them back up?

It would be awesome if Laravel knew to throw exception in default listener.


Fullscreen (borderless)

When using -maximize the window will launch fullscreen but still has the navigation bar visible. Is it possible to launch in borderless fullscreen or hide the navigation bar?

Hi @captainys . I'm running Tsugaru on an arcade cabinet, so I'm very interested on this (I think is not an issue).
It is possible hide the icons bar? Works great, but really it is not necessary for some of us.
I found some images without the bar in your web → http://ysflight.in.coocan.jp/FM/towns/Tsugaru/e.html :
Thanks in advice.


apache spark 1.2.1

Adds Apache Spark version 1.2.1. The latest version is 1.3.0.
-j

You'll need to fix the errors coughed up by the test bot. brew audit --strict will also show those errors locally.

Thanks, I think I got them all, so we'll wait for CI to confirm.  -j

I'm confused about the CI error. It seems to be mavericks only?  -j

Mavericks crash wasn't your fault. Bot threw a fatal but unrelated error. Once you've added the comment the bot will look over the PR again.

Merged in https://github.com/Homebrew/homebrew-versions/commit/7d1f5add1ab2f620d7bf6167d895cba6b06a7f0f. Thanks for your contribution to Homebrew, we appreciate it! :smiley_cat:. For future reference the preferred commit message for new formulae is apache-spark121 1.2.1 (new formula), Thanks!

Great, thanks! -j


Campaign expiration stack trace when invalid date is highlighted

Issue Description
On the campaign expiration screen there is an interesting bug. If a date is highlighted that does not exist in another month a stack trace occurs.
For example, if you select March 29th and then attempt to press the back arrow to select a date in February a stack trace will occur because February 29th does not exist.
Reproduction Steps

Create a new campaign
On the campaign expiration screen, click the date "March 29th"
Press the back arrow to change the month from March to February

Environment Details

Linux base 4.10.0-42-generic #46-Ubuntu SMP 2017 x86_64 x86_64 x86_64 GNU/Linux
KingPhisher Version: 1.10.0-beta1 (rev: 38a40000736c)
Error Details / Stack Trace

Error Type: builtins.ValueError
Error Details: ValueError('day is out of range for month',)
Error UID: 8fac8ccc-bfbe-446e-bc29-037cc354370f
RPC Error: N/A (Not a remote RPC error)
King Phisher Version: 1.10.0-beta1 (rev: 38a40000736c)
Platform Version: Linux: Ubuntu 17.04 zesty
Python Version: 3.5.3
Gtk Version: 3.22.11
Timezone: America/New_York

Thread Information:
 => MainThread (alive=True daemon=False)
    Thread-7 (alive=True daemon=True)
    Thread-11 (alive=True daemon=True)
    Thread-6 (alive=True daemon=False)
    Thread-12 (alive=True daemon=True)

Stack Trace:
Traceback (most recent call last):
  File "/opt/king-phisher/king_phisher/client/assistants/campaign.py", line 373, in signal_calendar_prev
    calendar_day = gui_utilities.gtk_calendar_get_pydate(calendar)
  File "/opt/king-phisher/king_phisher/client/gui_utilities.py", line 224, in gtk_calendar_get_pydate
    return datetime.date(calendar_day[0], calendar_day[1] + 1, calendar_day[2])
ValueError: day is out of range for month

I've updated to KingPhisher Version: 1.10.0-beta2 (rev: cd099361e912). I am still able to reproduce this bug on the latest version.

Cool thanks for that information.

Fixed in commit 3a897746be934d78e22bee9557f165f400a4c3aa.


Cannot reproduce results from paper

Hello,
Thanks for sharing the code.
However, I've had trouble reproducing the results, starting with experiment 1.
I've set up a fresh Python 3.7 environment and installed dependencies with bash setup_and_install.sh. Then I've run bash replicate_experiment_1.sh and here are the results I've got:

rotated mnist, naive: 87.0, stable: 86.8 (average accuracy, averaged over 3 runs). According to the paper, stable should be > 90 (Figure 3c)
permuted mnist, naive: 77.7, stable: 61.7. According to the paper, stable should be > 90.

Any hints for reproducing the results would be very helpful.

Dear @zajaczajac,
Thank you for the feedback. I think I made a typo error for dropout rate. It should have been 0.25 rather than 0.5. I hope this helps. Additionally, you can try different hyper-parameters and even get better results. Here are some runs:

Sorry for the inconvenience. I'm really busy this summer but I intend to provide completely reproducible results in codalab. In addition, I have recorded my experiments online (using comet.ml) and I can share some specific results with you. But the code is not as clean as this repository.
Regards,
Iman

Dear Iman,
Thanks for your quick response! Changing dropout value indeed helps for rotated mnist experiment. However, it does not fully work for permuted mnist - performance is now at 81.15. Do you have some additional insights here?
Also, if you can share the results from comet.ml, that would be helpful. Can you please e-mail the link to me? (my e-mail should be visible at my github profile)
Thanks,
Michał

You are welcome :)
Sure. I just sent you an email.
I close this issue since I believe it is resolved for now.


Install from requirements files in submodules

Right now, we recursively look for requirements.txt files when you run nio add -U. However, we don't do that when you add a single block.
Do we want to dive into submodules and folders when adding a block and look for requirements.txt files? This could be useful for something like the oauth2_mixin but it could be bad with something like the mixins submodule, where you may not use all of the mixins in the submodule

At first I didn't like the idea of doing a recursive install but it's growing on me. We could always consider splitting up the mixins into separate repos: group_by_mixin, etc...

Yeah, I actually think we should split the mixins up regardless. I'm cool
with recursive install too though
On Apr 15, 2015 7:06 PM, "Chris Brackert"<EMAIL_ADDRESS>wrote:

At first I didn't like the idea of doing a recursive install but it's
growing on me. We could always consider splitting up the mixins into
separate repos: group_by_mixin, etc...
—
Reply to this email directly or view it on GitHub
https://github.com/neutralio/nio-cli/issues/12#issuecomment-93617680.


Provide a way to directly write newlines and comments

Currently this is possible only by storing proc_macro2::Punct in a variable and interpolating that into a quote! { ... } block. It would be nice have a nicer way for this.
While functionally it doesn't make any difference, it could make the generated code more readable for debugging purposes and also allows to use quote as a general code generation mechanism outside of proc macros.

I would prefer not to build this into quote, but there is room in the ecosystem for a different library geared toward this use case.
FWIW https://github.com/dtolnay/syn/blob/1.0.19/src/gen/fold.rs is produced using quote, including newlines and doc comments so it's possible to use as a general code generation mechanism outside of proc macros.

Fair enough. That code you pasted there shows the exact problem though: densely packed without any empty lines between things, not readable at all :)
I'll continue to interpolate newlines into quote! { ... } blocks then for the meantime, it's not worth creating a new macro around quote just for this.


workers not running on real iphone

i have running on simulator. it run as well. But i install and run app on real Iphone, this worker but not run. why?

Same issue. In release mode not works


Add DateOnly and TimeOnly for platforms that don't support it.

Not all platforms support DateOnly and TimeOnly.  In particular:

.NET Standard 2.0
Xamarin.iOS 1.0
MonoAndroid 10.0
UAP 10.0

... and probably others.  In addition, the UAP platform does not support Span.
Require to copy the DateOnly and TimeOnly structures from .NET 6 and put them in the platform specific codes.

Since we are leaving Xamarin behind and concentrating on .NET 6+ going forward, this will not be done.


Text overlaps when using jest in watch mode

First off: Great work, I really like this dashboard and want to use it for my own project.
When jest is in watch mode it displays some usage instructions. This cannot be hidden. But after the first run the list collapses to only one line. See here for more details.
These usage instructions overlap with the top-left part of the dashboard. Perhaps it would be possible to add a background to the dashboard or something so it would be hidden?
Please see and example of what I mean below:

Thanks, @HendrikThePendric for the detailed bug. I recall investigating this issue a few months ago. I tried to intercept the console, but unfortunately, that didn't work since the same console instance that prints the UI is used to print that usage message.
None of the available options worked. And, there isn't a way to add a background either (that's a nice idea though!).
The only option for us is to make PR to jest. Luckily, while browsing through the jest issues, I came across https://github.com/facebook/jest/pull/2125 which might be the solution.
Can you please try that and let us know if it works? :)

Hi @theoutlander! Great package! I noticed that the mentioned issue has merged, maybe can we bump jest version to 23 and see if it works?

Thanks for the heads-up @matrunchyk. I updated to the latest jest, but it doesn't appear to work for me.
I get the following:

I'm on the latest version:

I've also tried adding this option to the config file, but still no luck.
Do you happen to know how it is supposed to be used? Thanks!


An empty object in if statement

Hi,
An empty object inside a conditional statement breaks everything:
if condition
  {}

compiles to
if (condition)
  {

I needed this in a function to return an empty object on some condition, so
f = ->
  if condition
    {}

compiles to
f = function() {
  if (condition)
    {;return
}

Playground

Thanks for the report! This is definitely a bug and something we'd like to fix soon.

I looked at the grammar some to see why this happens.  Here are some relevant rule excerpts to save some time:
IfStatement
  (IfClause / UnlessClause) Block ElseClause?
IfClause
  If Condition:condition
ElseClause
  Samedent Else Block
  _? Else Block
Condition
  ParenthesizedExpression !( _? ( BinaryOp / AssignmentOp / Dot / QuestionMark ) ) !( _ OperatorAssignmentOp )
  InsertOpenParen ExpressionWithIndentedApplicationForbidden:expression InsertCloseParen
  # and more for DeclarationCondition
# NOTE: This is the body of if/else/for/case etc.
Block
  ExplicitBlock
  ImplicitNestedBlock
  ThenClause
  _?:ws !EOS Statement:s
ExplicitBlock
  __ OpenBrace NestedBlockStatements? __ CloseBrace ->

So ExplicitBlock wins in particular because it doesn't care about spacing.
I guess the first question is what behavior we want.  For example, do we want if (cond) {} to behave like it does in JavaScript?  What about the following (valid JS)?
if (cond)
{}

One possible rule is: if the condition has parentheses (JS-style), then following braces are treated like a block, like they are currently.  And we could require indentation for the implicit parens model.
Another possible rule is: try to parse as a nested block first, so it takes priority over ExplicitBlock.  This rule would make the previous example work, because the {} isn't indented. It should also work for { on the same line as the if, because again it isn't indented:
if (cond) {
}

I guess the weird case is the following:
if (cond)
  {}

Should this be treated the same as the original example with if cond?  Or should we treat it as an object literal given the indentation?  I'm hoping the latter is "sufficient" JS compatibility, in particular because it'd be easier to implement. It's literally just swapping the order of ExplicitBlock and ImplicitNestedBlock.  I'll make a PR.