Customize the Well-Known Url Response

Hi,
Currently Well-Known Url for my Authorisation Server will shown following list in "response_types_supported" Parameter
code
token
id_token
id_token token
code id_token
code token
code id_token token
I wanted just show the "code id_token" in "response_types_supported".
Please guide us, how customize the well-known url

These are the response types supported by IdentityServer. We don't have a way to customize that.

It might work to set this to false
https://github.com/IdentityServer/IdentityServer4/blob/master/src/Configuration/DependencyInjection/Options/DiscoveryOptions.cs#L42
and add the element manually
https://github.com/IdentityServer/IdentityServer4/blob/master/src/Configuration/DependencyInjection/Options/DiscoveryOptions.cs#L80

Thanks for the quick replay. I'll try your suggestion and revert back if need any further details on this


[CH] With AQE enable, we could preserve hash table size more precisely

Description
With AQE enable, we could preserve hash table size more precisely, and reduce the overhead of rehashing. It's useful in aggregation and join.

will come soon

Don't see much improve


[flaky test] SRIOV VirtualMachineInstance with sriov plugin interface [test_id:3985]should create a virtual machine with sriov interface with custom MAC address

Is this a BUG REPORT or FEATURE REQUEST?:

Uncomment only one, leave it on its own line:

/kind bug
/triage build-officer
What happened:
Flakefinder reported a flaky test:
SRIOV VirtualMachineInstance with sriov plugin interface [test_id:3985]should create a virtual machine with sriov interface with custom MAC address
/root/go/src/kubevirt.io/kubevirt/tests/vmi_multus_test.go:790
MAC "de:ad:00:00:be:ef" was not found in the VMI testvmi87g5m257xp9wd2dpcqkmg8vmfg44zmf8bslqn4557wxt9kp7 within the given timeout
Unexpected error:
<expect.TimeoutError>:<PHONE_NUMBER>0
expect: timer expired after 15 seconds
occurred
/root/go/src/kubevirt.io/kubevirt/tests/vmi_multus_test.go:934
https://prow.apps.ovirt.org/view/gcs/kubevirt-prow/pr-logs/pull/kubevirt_kubevirt/3784/pull-kubevirt-e2e-kind-1.17-sriov/1281192600501489664
What you expected to happen:
Test to pass
How to reproduce it (as minimally and precisely as possible):
Anything else we need to know?:
Environment:

KubeVirt version (use virtctl version):
Kubernetes version (use kubectl version):
VM or VMI specifications:
Cloud provider or hardware configuration:
OS (e.g. from /etc/os-release):
Kernel (e.g. uname -a):
Install tools:
Others:

hopefully #4001 will solve it.
/assign @alonSadan


mkldnn: init at 1.0.2

Motivation for this change
Things done

[ ] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
Built on platform(s)

[ ] NixOS
[ ] macOS
[ ] other Linux distributions

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
[ ] Tested execution of all binary files (usually in ./result/bin/)
[ ] Determined the impact on package closure size (by running nix path-info -S before and after)
[ ] Ensured that relevant documentation is up to date
[ ] Fits CONTRIBUTING.md.

fixes #67982
I can't get the tests to build atm here is the log
https://gist.github.com/alexarice/5fde03409d660638036d3a0b6fedf704

@jonringer Do you know if my patch to change /bin/bash to /bin/sh is the correct thing to do? would it be better to hard link to bash via storepath

I personally would a substitueAll, see pyproj/default.nix patch as an example

Removing the checkPhase did not fix the tests, should I just set doCheck = false?

the tests are failing because of:
51/51 Test #51: test_api ......................................***Failed    0.00 sec
/build/source/build/tests/gtests/api/test_api: error while loading shared libraries: libmkldnn.so.1: cannot open shared object file: No such file or directory

We just need the tests to link against the shared library that gets produced.

Do you know how to do that?

The shared libraries seem to be written to $PWD/src, modifying LD_LIBRARY_PATH seems to do nothing. This should help though:
checkInputs = [ autoPatchelfHook ];
  preCheck = ''
    addAutoPatchelfSearchPath $PWD/src
    autoPatchelf tests
  '';

also, take note that this library may be highly coupled to intel processors, it might not work for AMD.

I'll try that in a bit, my laptop is Intel I think and the tests worked in a nix shell

More tests pass but not all of them

All test pass now, thanks for all the help

Shall I add myself as a maintainer?

It's up to you, but since you're familiar with how to build it to some degree, i would say that's some familiarity. Ideally a maintainer is someone with a vested interest in using the package as well.

The issue also mentioned adding this to the nativeBuildInputs of pytorch so I'll add this to this pr

it's a shared library, it would need to be added to build inputs

undefined variable 'alexarice' at /var/lib/ofborg/checkout/repo/38dca4e3aa6bca43ea96d2fcc04e8229/mr-est/eval-2-shlevy.ewr1.nix.ci/pkgs/development/libraries/mkldnn/default.nix:35:21

you need to add yourself as a maintainer see https://github.com/NixOS/nixpkgs/commit/c3c8f17439bc3aa4313c1137f99c3160b60825c4#diff-498fa90aaf17420b9719f0b04e1c3d08 for an example
your commit history should look like:
maintainers: add alexarice
mkldnn: init at 1.0.2

undefined variable 'alexarice' at /var/lib/ofborg/checkout/repo/38dca4e3aa6bca43ea96d2fcc04e8229/mr-est/eval-2-shlevy.ewr1.nix.ci/pkgs/development/libraries/mkldnn/default.nix:35:21

you need to add yourself as a maintainer see c3c8f17#diff-498fa90aaf17420b9719f0b04e1c3d08 for an example
your commit history should look like:
maintainers: add alexarice
mkldnn: init at 1.0.2

undefined variable 'alexarice' at /var/lib/ofborg/checkout/repo/38dca4e3aa6bca43ea96d2fcc04e8229/mr-est/eval-2-shlevy.ewr1.nix.ci/pkgs/development/libraries/mkldnn/default.nix:35:21

you need to add yourself as a maintainer see c3c8f17#diff-498fa90aaf17420b9719f0b04e1c3d08 for an example
your commit history should look like:
maintainers: add alexarice
mkldnn: init at 1.0.2

The issue isn't that I'm not a maintainer, it's that I was tired and didn't write with maintainers;


ci: update the pre-commit config to target lua files for selene

TL;DR
Updated the Selene Lint pre-commit hook configuration to explicitly specify Lua file types.
What changed?
Added types: - lua to the Selene Lint pre-commit hook configuration in the .pre-commit-config.yaml file. This explicitly defines the file types that the Selene linter should process.
How to test?

Ensure you have the pre-commit hooks installed.
Make changes to a Lua file in the repository.
Run pre-commit run --all-files or attempt to commit the changes.
Verify that the Selene linter runs on the Lua files as expected.

Why make this change?
This change improves the specificity of the Selene Lint pre-commit hook. By explicitly defining the file types, we ensure that the linter only runs on Lua files, potentially improving performance and reducing false positives on non-Lua files that might have a .lua extension.

[!WARNING]
This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more

#13
#12
#11  👈
#10
#9
#8
next

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @AliSajid and the rest of your teammates on  Graphite

Merge activity

Oct 19, 11:32 PM EDT: A user started a stack merge that includes this pull request via Graphite.


How to access the spdsession object from a WebTransportSession

I would like to support getStats and sending goaway stuff in the node webtransport addon.
However, I am hitting the following problem.
GetStats and as well as sendGoawayHttps3 (needed at least from the server side) are available through the underlying QuicSpdySession.
However, it is a private member of WebTransportHttp3, so I have no way to access it from a visitor.
(My plan is to do a dynamic cast on the WebTransport object....).
Are there any plans to make these features available through the WebTransport base class, or at least to get access to the SpdySession?
(I think deriving a class from WebTransportHttp3 is not an option, since it is created deep within quiche objects?)
Or any hints, on how to do it in another way?
Thanks?

I don't think there's a public accessor that would let you do this currently.  Are you trying to implement the W3C APIs for stats and goaway?  If so, I will be adding them at some point soon anyways, since we need those in Chrome.

Are you trying to implement the W3C APIs for stats and goaway?
Yes, this is the intention. Goaway draining is already implemented, thanks to your commit last week, but missing a server equivalent, so not really working or tested without the ability to send it.
Then I will wait....


Step numbers on Lab slides

The lab slides need to have step numbers added and matched with the original content

lab 6 - 8 conform others don't yet.


Making Artifacts Public configuration

I have a IAM user with S3 write access privileges and a generic maven repository bucket (Buckets and objects not public) without any AWS Bucket Policy specified.
Why do I have to set the flag [Public Access Settings -> Manage public access control list (ACLs) -> Block new public ACLs and uploading public objects] to False for the deploy to work?
The similar operation with "aws s3 cp ... " command, and same credentials used for mvn deploy, works well with all [Public Access Settings] flags set to True.

This is a bug in this code. The code enforces "public" putObject ACL.
You can git clone this code and see the issue.
I fixed it and send them PR. But the comitters would not merge and looks
like this a dead project.
I am working on releasing a fork.
Joe
On Tue, Feb 12, 2019, 6:14 AM aritgithub<EMAIL_ADDRESS>wrote:

I have a IAM user with S3 write access privileges and a generic maven
repository bucket (Buckets and objects not public) without any AWS Bucket
Policy specified.
Why do I have to set the flag [Public Access Settings -> Manage public
access control list (ACLs) -> Block new public ACLs and uploading public
objects] to False for the deploy to work?
The similar operation with "aws s3 cp ... " command, and same credentials
used for mvn deploy, works well with all [Public Access Settings] flags set
to True.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/spring-projects/aws-maven/issues/70, or mute the
thread
https://github.com/notifications/unsubscribe-auth/APKJqOEcY1EVQxruhKtiD0D_ZkpI8bkJks5vMqImgaJpZM4a2KWU
.

Thanks Joe, indeed I detected this error in this GitHub sponsored project:
github.com/platform-team/aws-maven
which support all AWS region and the latest cryptographic communication algorithms (AWS4?).
Can you send a PR with your fixes to this forked project?

Can you send me a ref to the pull request submitted?

This project is abandoned. Nobody replies.
I put the fix PR here. This project appears to be more active.
https://github.com/platform-team/aws-maven/pull/14
FYI: You may want to use an IAM role instead of an IAM user.
I have tested all this with AWS Codebuild and CodePipeline.
Joe
On Tue, Feb 12, 2019, 10:44 AM aritgithub<EMAIL_ADDRESS>wrote:

Thanks Joe, indeed I detected this error in this GitHub sponsored project:
github.com/platform-team/aws-maven
which support all AWS region and the latest cryptographic communication
algorithms (AWS4?).
Can you send a PR with your fixes to this forked project?
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/spring-projects/aws-maven/issues/70#issuecomment-462810688,
or mute the thread
https://github.com/notifications/unsubscribe-auth/APKJqPU0-nQ-otZaAYEYGUSToe0xwwXaks5vMuFMgaJpZM4a2KWU
.


python312Packages.blessings: drop nose dependency

Description of changes

#326513

Things done

Built on platform(s)

[X] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)

[ ] sandbox = relaxed
[ ] sandbox = true

[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[X] Fits CONTRIBUTING.md.

Add a :+1: reaction to pull requests you find important.

This package seems to be somewhat famously unmaintained, and there is a maintained fork in the form of Blessed that already uses pytest. We already have a python3Packages.blessed package; perhaps we can simply remove this. In‐tree users:

cbeams: Doesn’t look very maintained, but terminal.py seems simple enough that I expect the port is simple.
python3Packages.invocations: https://github.com/pyinvoke/invocations/issues/38, looks like probably a one‐line import change to port to Blessed.
python3Packages.ronin: Build system with no commits for 7 years and no in‐tree users, not exposed in the top‐level package set, ditto on the port but we can probably just drop this.
python3Packages.reportengine: Marked as broken, unmaintained‐ish upstream, and could potentially just be dropped, but ditto on the port.

@emilazy tried to makes reportengine passing, couldn't successfully patch it, so I dropped it. It also takes 2 other packages with it

Result of nixpkgs-review pr 336152 run on x86_64-linux 1

10 packages built:

cbeams
cbeams.dist
python311Packages.invocations
python311Packages.invocations.dist
python311Packages.pytest-relaxed
python311Packages.pytest-relaxed.dist
python312Packages.invocations
python312Packages.invocations.dist
python312Packages.pytest-relaxed
python312Packages.pytest-relaxed.dist

Result of nixpkgs-review pr 336152 run on aarch64-linux 1

10 packages built:

cbeams
cbeams.dist
python311Packages.invocations
python311Packages.invocations.dist
python311Packages.pytest-relaxed
python311Packages.pytest-relaxed.dist
python312Packages.invocations
python312Packages.invocations.dist
python312Packages.pytest-relaxed
python312Packages.pytest-relaxed.dist


Issue #29: Listing projects

Add support for listing projects (experimental)
Added unit test
Add missing experimental API warnings

Codecov Report

Merging #30 (3ffc959) into dev (73f8fc0) will increase coverage by 0.07%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##              dev      #30      +/-   ##
==========================================
+ Coverage   88.27%   88.35%   +0.07%
==========================================
  Files          14       14
  Lines        1109     1116       +7
==========================================
+ Hits          979      986       +7
  Misses        130      130

Impacted Files
Coverage Δ

averbis/core/_rest_client.py
81.18% <100.00%> (+0.10%)
:arrow_up:

tests/test_client.py
100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 73f8fc0...3ffc959. Read the comment docs.


Adding SSL certs without reverse proxy server

Is there a way to do this? If not, could you point me to a file please where I might add this on my own?
Thanks!

Seems like a lot of work but possible, https://github.com/vercel/next.js/discussions/10935


[hack day] Sync anchor (http URL) to up-to-date

For each URL (anchor), we need to revisit and check its availability. Some of them might be update to new one.
At least, we need to change waffle.io (or waffle.io is available as open board for everyone?)
http://toad.readthedocs.io/en/latest/tracking_development.html

Issue here is to go through all the links that exist in the documentation and make sure that they are all working as intended.


WPP_CLEANUP的问题

在开启驱动程序校验器的情况下，在驱动入口加载驱动失败而没有调用WPP_CLEANUP，反而说是在驱动卸载的时候没有调用WPP_CLEANUP。
这个说法有点坑人啊！

Hello @kouzhudong
What page are you referencing here? I'm don't understand what you're saying without knowing the page.
Thanks,
@EliotSeattle

应该是提交给windbg的帮助文档。

https://docs.microsoft.com/en-us/windows-hardware/drivers/debugger/bug-check-0xc4--driver-verifier-detected-violation
应该提交到这里。

I see that this was opened as #1623 in that topic, so I am going to close this as a duplicate Issue.


WIP: implement namespace packages

[x] Added tests for changed code.
[ ] Updated documentation for changed code.

I added a module key to pyproject.toml which allows developers to specify the module path to which the projects code lives.  This should enable namespace packages such as the following:
[tool.poetry]
name = "abc-foo"
module = "abc.foo"

corresponds with a layout like:
pyproject.toml
abc/
    foo/
        __init__.py

It wouldn't support a namespace package within the src directory, which would be nice.  I don't think that'd be too hard to implement, so I'm leaving this as WIP.

Looks like a bunch of commits were just merged to master that accomplishes what I was trying to do.


[Proposal] Short-list roadmap

Things I would suggest to do:

Check open PRs and take some actions for each (close/merge/define action points).
Check open issues and take some actions for each (close/define action points).
Check exercises and fix missing source files.
Update base template (implemented here):

Update gradle.
Use Jupiter as a testing platform.
Use TestOrder + fail-fast strategy to improve testing experience for students.

Fix issues from report.
I'm exploring other ways to improve tooling for exercises (e.g. I believe it's possible to make testing more lightweight without Gradle).

cc: @mikegehard
What do you think?

Thanks @dector
I totally agree with the first 3 bullet items. I would love to get to a place where both PRs and issues are empty.
Updating gradle is another good one.
I'd like to talk more about Jupiter and TestOrder. I'm unfamiliar with Jupiter and would love to understand your thoughts on improving the testing experience.

I'd like to talk more about Jupiter and TestOrder. I'm unfamiliar with Jupiter and would love to understand your thoughts on improving the testing experience.

I'm actually talking about Junit 5. :) You can read more about it here.

1.1. What is JUnit 5?
Unlike previous versions of JUnit, JUnit 5 is composed of several different modules from three different sub-projects.
JUnit 5 = JUnit Platform + JUnit Jupiter + JUnit Vintage

For now all test cases except one are marked as @Ignored and that requires student to open test file and remove this annotation one-by-one. I think it might be improved: with predefined test order and fail-fast enabled student will see only one failed test-result at a time (and can concentrate on working on it) but there will be no need to edit test cases files.

Ah yes...I totally agree that upgrading to JUnit 5 would be a great idea.
And now I understand you thoughts on the pre-defined test order. Yes that would be an interesting experiment to figure out if that improves student experience because they don't have to remove the @Ignore.
The TDD purist in me has a concern exposing students to the @Order annotation. That concern is that they will see that early in their careers and will then start to use it outside of Exercism. By fixing order in a test suite, when doing TDD, you can cause some subtle bugs because the test can rely on existing state.
That said, we have had some issues in the past with folks not fully reading the instructions and not removing the @Ignore annotation so they didn't implement the full solution.
For now, what if we just implemented JUnit 5 and came back to the "student experience" question. Might be something we want to talk more widely about to get more feedback.
Maybe once we get the issues area cleaned up we can start a discussion issue?

I thought about using order in education purposes as a ladder for making steps from simpler test-cases to more difficult. But in general, we can use just fail-fast approach.

Maybe once we get the issues area cleaned up we can start a discussion issue?

Sounds good for me.

👍

Also, as I see v3 tracks gonna dive dipper into idiomatic languages. v2 are more about idiomatic syntax.
Also there are many Kotlin testing frameworks: starting from classic JUnit-family to Spek or kotlintest that allows to write more readable / better structured tests.

Not sure I follow...

Issue #310 is an existing issue for adding stub files.

Thank you. Will take a look.


[OTHER]

What would you like to share?
why  not we can filter as per languages will be easy for user
Additional information
No response

Closing this as duplicate of #77

just checked


Fetch Failed

Every time I try to Update Data I get the following error:
Fetch failed in undefined for page undefined，you have reached the maximum retry attempt. - Failed
Am I doing something wrong?

Is this happening on the current version (v0.6.3) ?

nope... looks like I downloaded the 2.4 somehow. let me try the other one


[SPARK-27194][SPARK-29302][SQL] Fix commit collision in dynamic partition overwrite mode

What changes were proposed in this pull request?

When using dynamic partition overwrite, each task has its working dir under staging dir like stagingDir/.spark-staging-{jobId}, each task commits to stagingDir/.spark-staging-{jobId}/{partitionId}/part-{taskId}-{jobId}{ext}.
When speculation enable, multiple task attempts would be setup for one task, they have same task id and they would commit to same file concurrently. Due to host done or node preemption, the partly-committed files aren't cleaned up, a FileAlreadyExistsException would be raised in this situation, resulting in job failure.
I don't try to change task commit process for dynamic partition overwrite, like adding attempt id to task working dir for each attempts and committing to final output dir via a new outputCommitCoordinator, here is reason:

FileOutputCommitter already has commit coordinator for each task attempts, we can leverage it rather than build a new one.
To say the least, we implement a coordinator solving task attempts commit conflict, suppose a severe case, application master failover, tasks with same attempt id and same task id would commit to same files, the FileAlreadyExistsException risk still exists

In this pr, I leverage FileOutputCommitter to solve the problem:

when initing a write job description, set stagingDir/.spark-staging-{jobId} as the output dir
each task attempt writes output to stagingDir/.spark-staging-{jobId}/_temporary/${appAttemptId}/_temporary/${taskAttemptId}/{partitionId}/part-{taskId}-{jobId}{ext}
leverage FileOutputCommitter coordinator, write job firstly commits output to stagingDir/.spark-staging-{jobId}/{partitionId}
for dynamic partition overwrite, write job finally move stagingDir/.spark-staging-{jobId}/{partitionId} to finalPath/{partitionId}

Why are the changes needed?

Without this pr, dynamic partition overwrite would fail
Does this PR introduce any user-facing change?

No.
How was this patch tested?

added UT.

Can one of the admins verify this patch?

Can one of the admins verify this patch?

In #29000 , sorry for mistake of pushing unexpected branch to repo, so I close that.
Gentle ping @xuanyuanking @cloud-fan @dongjoon-hyun @turboFei @LuciferYang @advancedxy to further review this pr, thank you.

Gentle ping @cloud-fan @dongjoon-hyun to test this pr, thand you.

gentle ping @cloud-fan @dongjoon-hyun to test this pr, thank you

close this pr and reopen the previous pr, further code review and update please check #29000


Deploy the landing page using Github pages

Instructions:

As a user when I visit the site URL I am brought to a landing page

Specifications:

Deploy to Github pages using the Main branch of this repo
Update the README file with the deployed webpage URL

completed on git commit: 372af6dc7054b956f405faf5e06f6c50087b37ee


New api for panTo, zoomTo, moveTo...

Hello,
I am looking for api like "panTo", "zoomTo", "moveToFitBounds" same with Google Maps SDK.  But CartoDB SDK is not available, can you update this feature?  I think this api is essential for user interaction and map handling.
Thank you so much,
Google Maps API Example:
mapView.animateCamera(CameraUpdateFactory.zoomTo(16), 3000, new GoogleMap.CancelableCallback() {
            @Override
            public void onFinish() {

            }

            @Override
            public void onCancel() {

            }
 });

and maybe CartoDB SDK like:
mapView.moveToFitBounds(mapBounds, screenBounds, integerZoom, durationSeconds, new moveToFitBoundCallback(){
{
            @Override
            public void onFinish() {

            }

            @Override
            public void onCancel() {

            }
 }

})

Tagging this with 'idea-maybe-future'. In general I like the idea, as the current 'camera' API in MapView has always felt a bit limiting. Google API is actually quite nice and it may make sense to actually copy it.
Can not promise a time frame for this, but will look into this soon.


poppler 0.42 build error: 'isfinite' was not declared in this scope

Error:
SplashOutputDev.cc: In member function 'virtual void SplashOutputDev::drawImageMask(GfxState*, Object*, Stream*, i
nt, int, GBool, GBool, GBool)':
SplashOutputDev.cc:2894:25: error: 'isfinite' was not declared in this scope
     if (!isfinite(ctm[i])) return;
                         ^
SplashOutputDev.cc:2894:25: note: suggested alternative:
In file included from /bio/linuxbrew/Cellar/gcc/5.3.0/include/c++/5.3.0/random:38:0,
                 from /bio/linuxbrew/Cellar/gcc/5.3.0/include/c++/5.3.0/bits/stl_algo.h:66,
                 from /bio/linuxbrew/Cellar/gcc/5.3.0/include/c++/5.3.0/algorithm:62,
                 from SplashOutputDev.cc:77:
/bio/linuxbrew/Cellar/gcc/5.3.0/include/c++/5.3.0/cmath:601:5: note:   'std::isfinite'
     isfinite(_Tp __x)
     ^

Logs: https://gist.github.com/facb9b4ab4bc3bf614432e4779250c26
Could be an upstream change that needs to be made to put ```std::`` namespace prefix?
I've filed it upstream: https://bugs.freedesktop.org/show_bug.cgi?id=94761
Build: xz ✔, pkg-config ✔
Required: cairo ✔, fontconfig ✔, freetype ✔, gettext ✔, glib ✔, gobject-introspection ✔, jpeg ✔, libpng ✔, libtiff ✔, openjpeg ✔
Optional: qt ✘, qt5 ✘, little-cms2 ✔

Yeah, I'd guess it's an upstream bug related to GCC 5. It should be std::isfinite, as you noted.

FYI @tseemann the upstream developers responded to the bug, asking you to confirm if adding std:: fixes it.

poppler was updated to version 0.47 and the upstream bug was marked "RESOLVED FIXED", so closing this.


Publish iOS SDK

[x] Publish iOS SDK to CocoaPods or Carthage (to be defined), SKM package
[x] Update Documentation with the correct URL

Documentation updated with CocoaPods, Carthage and SKM package


Review MediaObjectList

This is a component that was built in an effort to be multi-functional but ended up being too convoluted and confusing to modify/fix. We'd like to review where it is used in an effort to see if we could use something simpler instead, that could also be useful for the new Visual Stories components.
Alex brought to our attention the deprecated Image List slice component, which could eventually be brought back from deprecation and used.
This ticket serves as a way to document what we find from this discovery piece.
Might relate to https://github.com/wellcomecollection/wellcomecollection.org/issues/7680

MediaObjectList is used in 7 nodes, 13 times. Again I've added the URLs.
[
  {
    id: 'YgZPOxMAAB4AM-ew',
    prismicUrl: 'https://wellcomecollection.prismic.io/documents~b=working&c=unclassified&l=en-gb/YgZPOxMAAB4AM-ew',
    websiteUrl: 'https://wellcomecollection.org/pages/YgZPOxMAAB4AM-ew',
    type: 'pages',
    format: undefined,
    title: 'An invitation to Indigenous communities'
  },
  {
    id: 'YqdICREAAMXL68GJ',
    prismicUrl: 'https://wellcomecollection.prismic.io/documents~b=working&c=unclassified&l=en-gb/YqdICREAAMXL68GJ',
    websiteUrl: 'https://wellcomecollection.org/events/YqdICREAAMXL68GJ',
    type: 'events',
    format: 'festival',
    title: 'Invisible Touch'
  },
  {
    id: 'YrSVkREAACIAoger',
    prismicUrl: 'https://wellcomecollection.prismic.io/documents~b=working&c=unclassified&l=en-gb/YrSVkREAACIAoger',
    websiteUrl: 'https://wellcomecollection.org/events/YrSVkREAACIAoger',
    type: 'events',
    format: 'festival',
    title: 'A Breath of Fresh Air Festival'
  },
  {
    id: 'Ys11qhEAACEAgsTe',
    prismicUrl: 'https://wellcomecollection.prismic.io/documents~b=working&c=unclassified&l=en-gb/Ys11qhEAACEAgsTe',
    websiteUrl: 'https://wellcomecollection.org/event-series/Ys11qhEAACEAgsTe',
    type: 'event-series',
    format: undefined,
    title: 'A Breath of Fresh Air'
  },
  {
    id: 'X5amzBIAAB0Aq6Gm',
    prismicUrl: 'https://wellcomecollection.prismic.io/documents~b=working&c=unclassified&l=en-gb/X5amzBIAAB0Aq6Gm',
    websiteUrl: 'https://wellcomecollection.org/pages/X5amzBIAAB0Aq6Gm',
    type: 'pages',
    format: undefined,
    title: 'Keeping you safe'
  },
  {
    id: 'YqdQ7BEAACEA6-O3',
    prismicUrl: 'https://wellcomecollection.prismic.io/documents~b=working&c=unclassified&l=en-gb/YqdQ7BEAACEA6-O3',
    websiteUrl: 'https://wellcomecollection.org/pages/YqdQ7BEAACEA6-O3',
    type: 'pages',
    format: undefined,
    title: 'Invisible Touch Trail'
  },
  {
    id: 'Yjm3IBEAACIAd_pL',
    prismicUrl: 'https://wellcomecollection.prismic.io/documents~b=working&c=unclassified&l=en-gb/Yjm3IBEAACIAd_pL',
    websiteUrl: 'https://wellcomecollection.org/events/Yjm3IBEAACIAd_pL',
    type: 'events',
    format: 'festival',
    title: 'Personal Touch'
  }
]

Made a dashboard to try and outline a possible plan: https://miro.com/app/board/uXjVMFYKs3Y=/?share_link_id=703019992871

I'm tempted to move this back to the backlog instead of closing it.

We've determined we weren't going to be using MediaObjectList for Visual Stories, so this loses its priority.
There is nothing that would replace it as is
a) I do suggest creating a new, simplified component to render it, but keeping this ticket open to investigate the doability
We did find out more about ImageList though, and a new ticket has been created to work on completely removing it.

I think the work that needs to be done in order to get where we want with this is now being tracked in #9955. Going to move this to the backlog and we can convert the 12 MediaObjectList instances to the new thing we create or rich text.

I think this is all done done done.


Review the error log that is being generated while indexing

Review the error log we generate while indexing. Revisit it with the data quality group. This one was generated while indexing the full dump from 10-28-2020. https://docs.google.com/spreadsheets/d/1Hn4m9orX07u-JSFwJKiIsJsZF8txnkEhVCXMjfp5OfM/edit#gid=0

[ ] https://github.com/pulibrary/marc_liberation/blob/0a5d2e750bc07b4284ce3a9de167b83f70efc0c7/marc_to_solr/lib/traject_config.rb#L497 look for errors specifc to missing $a instead of $a $n and $p.

[ ] What locations (852b) are attached to the bib. It would be useful to know if they are physical items. These are the ones the the catalogers are able to update. (e-resources / scsb they are beyond our control. ) https://github.com/pulibrary/marc_liberation/blob/0a5d2e750bc07b4284ce3a9de167b83f70efc0c7/marc_to_solr/lib/traject_config.rb#L1101

see also https://github.com/pulibrary/bibdata/issues/1230


adding feature accessor

We should make this a Bazel repo

@negator yeah agree - but maybe that's next step after we get this changeset in?

We should make this a Bazel repo

Would it be possible to keep glide around too without too much contention on pinned hashes? This is a public repo so it would be best to maintain the current status of it if possible.

@promiseofcake, we sould generate the WORKSPACE file off of glide.lock, so it should be exactly the same

For some reason we are getting failing tests on master: https://travis-ci.org/vsco/dcdr, going to restart the build to see if we have a flaky test.


Contextual Help Component

Contextual Help component is a convenience component made up of a quiet small ActionButton, a DialogTrigger (popover variant) and a Dialog.
We will need to override the defaults for ActionButton to display a small size ActionButton (tshirt sizing available in DNA)
This would use the Dialog slots Heading = title, Content = children, Footer = learn more link

Example
<ContextualHelp
  variant="help" //icon
  title="Action not available"
  learnMoreUrl="http://help.adobe.com/...">
  This is the description.
</ContextualHelp>

API
interface ContextualHelpProps {
  variant?: 'help' | 'info', // default: 'help'
  title: ReactNode,
  children: ReactNode,
  learnMoreUrl?: string
}

Where will the learnMore URL be displayed? If an implementation wants to have multiple links or control the placement of the links could that still be achieved through a custom child element?
eg?

How is the popover activated? On click or hover?
What do the two icon variants look like? Is there a filled info icon variant or just an outline variant? Will the help variant be a outlined question mark?


PostgreSQL gen_random_uuid() does no longer require the pgcrypto extension

I crossed this in the documentation quite a few times: Docs say that you would need the pgcrypto extension in order to run the native database function gen_random_uuid() in postgres.
As of Postgres 13, that is no longer true.
As this info is spread across multiple pages in the docs, I figured it'd be best for you guys to decide where / how to reflect this info properly

We support postgres starting with 9.4, and many installations are on older versions, so I don't think we should aim to document the latest version exclusively. We could note that the CREATE EXTENSION is not needed on pg 13+ though.

yep, the mentioning of 13+ is what I was hoping for.


[outdated link on site] "Missing A Feature" page links to Sourceforge

The "Missing A Feature? Get It Done!" has a link pointing to https://vienna-rss.sourceforge.io/?page_id=16, while the newer version of that page lives at http://www.vienna-rss.com/?page_id=16.

Thank you for reporting this :) It should be fixed now...

@josh64x2 ᕕ( ᐛ )ᕗ


rc_visard: 3.0.5-1 in 'kinetic/distribution.yaml' [bloom]

Increasing version of package(s) in repository rc_visard to 3.0.5-1:

upstream repository: https://github.com/roboception/rc_visard_ros.git
release repository: https://github.com/roboception-gbp/rc_visard-release.git
distro file: kinetic/distribution.yaml
bloom version: 0.10.0
previous version for package: 3.0.4-1

rc_hand_eye_calibration_client

No changes

rc_pick_client

No changes

rc_roi_manager_gui

No changes

rc_silhouettematch_client

No changes

rc_tagdetect_client

No changes

rc_visard

No changes

rc_visard_description

No changes

rc_visard_driver
* add noise, test, adaptive_out1_reduction and brightness to CameraParam extra_data if available

Sync is out


Fails to find repositories specified in pin-depends

Describe the bug
Opam-nix seems not to look for pin-depends.
I've been trying to experiment with yocaml. It seems not to have been published to opam yet, and people seem to be using pin-depends as a way to use it in their projects?
I searched on the opam-nix repo and it seems like pin-depends is not mentioned, so maybe it is not yet supported? I understand that it might be tricky to do this while maintaining reproducibility however? So I'm not sure what that would look like.
To Reproduce
flake.nix
{
  description = "A very basic flake";

  inputs = {
    # Utilities for writing flakes
    flake-utils.url = github:numtide/flake-utils;
    # Precisely filter files copied to the nix store
    nix-filter.url = "github:numtide/nix-filter";
    # Generate derivations from Dune and OCaml files
    opam-nix.url = github:tweag/opam-nix;
  };

  outputs = { self, nixpkgs, flake-utils, nix-filter, opam-nix }:
    flake-utils.lib.eachDefaultSystem (system:
      let
        # Legacy packages that have not been converted to flakes
        legacyPackages = nixpkgs.legacyPackages.${system};
        # OCaml packages available on nixpkgs
        ocamlPackages = legacyPackages.ocamlPackages;

        # OCaml source files
        ocaml-src = nix-filter.lib.filter {
          root = ./.;
          include = [
            "dune-project"
            "garden.opam.template"
            (nix-filter.lib.inDirectory "bin")
          ];
        };

        # Nix source files
        nix-src = nix-filter.lib.filter {
          root = ./.;
          include = [
            (nix-filter.lib.matchExt "nix")
          ];
        };
      in
      {
        # Executed by `nix build .#<name>`
        packages.garden =
          (opam-nix.lib.${system}.buildDuneProject { } "garden" ocaml-src { }).garden;

        # Executed by `nix build`
        defaultPackage = self.packages.${system}.garden;

        # Executed by `nix run .#<name>`
        apps.garden = {
          type = "app";
          program = "${self.packages.${system}.garden}/bin/garden";
        };

        # Executed by `nix run`
        defaultApp = self.apps.${system}.garden;

        # Used by `nix develop`
        devShell = legacyPackages.mkShell {
          nativeBuildInputs = [
            ocamlPackages.dune_2
            ocamlPackages.ocaml
            legacyPackages.opam

            # Editor support
            # pkgs.ocamlformat # FIXME: fails to build `uunf` on my M1 mac :(
            ocamlPackages.merlin
            ocamlPackages.ocaml-lsp
          ];
          inputsFrom = [
            self.defaultPackage.${system}
          ];
        };
      });
}

dune-project
(lang dune 2.9)

(generate_opam_files true)

(package
 (name garden)
 (synopsis "Static page generator for my digital garden")
 (depends
  (preface (>= "0.1.0"))
  (yocaml :pinned)
  (yocaml_yaml :pinned)
  (yocaml_markdown :pinned)
  (yocaml_unix :pinned)))

bin/dune
(executable
 (name garden)
 (public_name garden)
 (promote (until-clean))
 (libraries preface yocaml yocaml_yaml yocaml_markdown yocaml_unix))

bin/garden.ml
let () =
  ()

garden.opam.template
pin-depends: [
  ["yocaml.dev" "git://github.com/xhtmlboi/yocaml.git"]
  ["yocaml_unix.dev" "git://github.com/xhtmlboi/yocaml.git"]
  ["yocaml_yaml.dev" "git://github.com/xhtmlboi/yocaml.git"]
  ["yocaml_markdown.dev" "git://github.com/xhtmlboi/yocaml.git"]
]

After running nix build I get:
nix log ...-garden-local.drv
@nix { "action": "setPhase", "phase": "unpackPhase" }
unpacking sources
unpacking source archive /nix/store/l2y5prikdgks7i4a5awc7vkxdxzxi2h9-source-copy
source root is source-copy
@nix { "action": "setPhase", "phase": "patchPhase" }
patching sources
@nix { "action": "setPhase", "phase": "updateAutotoolsGnuConfigScriptsPhase" }
updateAutotoolsGnuConfigScriptsPhase
@nix { "action": "setPhase", "phase": "configurePhase" }
configuring
patching script interpreter paths in .
@nix { "action": "setPhase", "phase": "buildPhase" }
building
File "bin/dune", line 5, characters 55-66:
5 |  (libraries preface yocaml yocaml_yaml yocaml_markdown yocaml_unix))
                                                           ^^^^^^^^^^^
Error: Library "yocaml_unix" not found.
Hint: try:
  dune external-lib-deps --missing --no-config --root . --ignore-promoted-rules --default-target @install --always-show-command-line --promote-install-files false --promote-install-files --release --only-packages garden -p garden --profile release -j 10 @install

The generated opam file is:
/nix/store/...-source-copy/garden.opam
# This file is generated by dune, edit dune-project instead
opam-version: "2.0"
depends: [
  "dune" {>= "2.9"}
  "preface" {>= "0.1.0"}
  "yocaml" {pinned}
  "yocaml_yaml" {pinned}
  "yocaml_markdown" {pinned}
  "yocaml_unix" {pinned}
  "odoc" {with-doc}
]
build: [
  ["dune" "subst"] {dev}
  [
    "dune"
    "build"
    "-p"
    name
    "-j"
    jobs
    "--promote-install-files=false"
    "@install"
    "@runtest" {with-test}
    "@doc" {with-doc}
  ]
  ["dune" "install" "-p" name "--create-install-files" name]
]
pin-depends: [
  ["yocaml.dev" "git://github.com/xhtmlboi/yocaml.git"]
  ["yocaml_unix.dev" "git://github.com/xhtmlboi/yocaml.git"]
  ["yocaml_yaml.dev" "git://github.com/xhtmlboi/yocaml.git"]
  ["yocaml_markdown.dev" "git://github.com/xhtmlboi/yocaml.git"]
]

Expected behavior
The build should find the dependencies
Environment

OS name + version: aarch64-darwin, macOS 12.1

Version of the code:
Inputs:
├───flake-utils: github:numtide/flake-utils/74f7e4319258e287b0f9cb95426c9853b282730b
├───nix-filter: github:numtide/nix-filter/bd03eb5242e707bc270f7a7e4f835b55713247ac
├───nixpkgs: github:NixOS/nixpkgs/568e0bc498ee51fdd88e1e94089de05f2fdbd18b
└───opam-nix: github:tweag/opam-nix/03ff01c4d228814e03566ef36667599848408738
    ├───flake-compat: github:edolstra/flake-compat/12c64ca55c1014cdc1b16ed5a804aa8576601ff2
    ├───flake-utils: github:numtide/flake-utils/74f7e4319258e287b0f9cb95426c9853b282730b
    ├───nixpkgs: github:nixos/nixpkgs/eac07edbd20ed4908b98790ba299250b5527ecdf
    ├───opam-repository: github:ocaml/opam-repository/c7b45b3cbcfbe22a7b3b8af1e5bb9998f3aa0e8a
    └───opam2json: github:tweag/opam2json/7652f94ac18ec94bc1ae697169c7f7f8b809270a
        └───nixpkgs: github:NixOS/nixpkgs/5c37ad87222cfc1ec36d6cd1364514a9efc2f7f2

Additional context
Add any other context about the problem here.

It's indeed not possible to support pin-depends reproducibly without an opam lockfile (since it doesn't have any notion of actually pinning the dependency version in the package description). It can probably be supported with --impure in some way.
For now, you can try passing yocaml as a repo. First, add an input to your flake:
  yocaml = {
    url = "github:xhtmlboi/yocaml";
    flake = false;
  };

Then, pass it (together with the default opam-repository) to the buildDuneProject:
      packages.garden = (opam-nix.lib.${system}.buildDuneProject {
        repos = [
          yocaml
          opam-nix.inputs.opam-repository
        ];
      } "garden" ocaml-src { }).garden;

opam-nix now supports pin-depends, but in your particular case it won't work because yocaml has a non-master default branch. See https://github.com/NixOS/nix/issues/5139 and https://github.com/NixOS/nix/issues/4456

Oh nice, thanks!
Hmm for some reason the suggestion above doesn't seem to be working for me?
@nix { "action": "setPhase", "phase": "unpackPhase" }
unpacking sources
unpacking source archive /nix/store/l2y5prikdgks7i4a5awc7vkxdxzxi2h9-source-copy
source root is source-copy
@nix { "action": "setPhase", "phase": "patchPhase" }
patching sources
@nix { "action": "setPhase", "phase": "updateAutotoolsGnuConfigScriptsPhase" }
updateAutotoolsGnuConfigScriptsPhase
@nix { "action": "setPhase", "phase": "configurePhase" }
configuring
patching script interpreter paths in .
@nix { "action": "setPhase", "phase": "buildPhase" }
building
File "bin/dune", line 5, characters 55-66:
5 |  (libraries preface yocaml yocaml_yaml yocaml_markdown yocaml_unix))
                                                           ^^^^^^^^^^^
Error: Library "yocaml_unix" not found.
Hint: try:
  dune external-lib-deps --missing --no-config --root . --ignore-promoted-rules --default-target @install --always-show-command-line --promote-install-files false --promote-install-files --release --only-packages garden -p garden --profile release -j 10 @install

Ah, yeah, sorry. I forgot to makeOpamRepo and also opam doesn't resolve pinned packages with opam admin list, so we have to ask for those ourselves:
        packages.garden = (with opam-nix.lib.${system};
          buildDuneProject {
            repos = [ (makeOpamRepo yocaml) opam-nix.inputs.opam-repository ];
          } "garden" ocaml-src {
            yocaml = null;
            yocaml_unix = null;
            yocaml_yaml = null;
            yocaml_markdown = null;
          }).garden;

(Note that you'll also need the latest version of opam-nix since there was an overlay issue)

Wooo, I think that worked! Thanks a bunch. Here's the full flake I made if it's of any use to anyone:
{
  description = "Static page generator for my digital garden";

  inputs = {
    # Utilities for writing flakes
    flake-utils.url = github:numtide/flake-utils;
    # Precisely filter files copied to the nix store
    nix-filter.url = "github:numtide/nix-filter";
    # Generate derivations from Dune and OCaml files
    opam-nix.url = github:tweag/opam-nix;
    # Static site generator for OCaml (not yet publishe to opam)
    yocaml.url = "github:xhtmlboi/yocaml";
    yocaml.flake = false;
  };

  outputs = { self, nixpkgs, flake-utils, nix-filter, opam-nix, yocaml }:
    flake-utils.lib.eachDefaultSystem (system:
      let
        # Legacy packages that have not been converted to flakes
        legacyPackages = nixpkgs.legacyPackages.${system};
        # OCaml packages available on nixpkgs
        ocamlPackages = legacyPackages.ocamlPackages;

        # OCaml source files
        ocaml-src = nix-filter.lib.filter {
          root = ./.;
          include = [
            "dune-project"
            "garden.opam.template"
            (nix-filter.lib.inDirectory "bin")
          ];
        };
      in
      {
        # Executed by `nix build .#<name>`
        packages.garden =
          (opam-nix.lib.${system}.buildDuneProject
            {
              pinDepends = false;
              repos = [
                (opam-nix.lib.${system}.makeOpamRepo yocaml)
                opam-nix.inputs.opam-repository
              ];
            }
            "garden"
            ocaml-src
            {
              yocaml = null;
              yocaml_unix = null;
              yocaml_yaml = null;
              yocaml_markdown = null;
            }).garden;

        # Executed by `nix build`
        defaultPackage = self.packages.${system}.garden;

        # Executed by `nix run .#<name>`
        apps.garden = {
          type = "app";
          program = "${self.packages.${system}.garden}/bin/garden";
        };

        # Executed by `nix run`
        defaultApp = self.apps.${system}.garden;

        # Used by `nix develop`
        devShell = legacyPackages.mkShell {
          nativeBuildInputs = [
            # Editor support
            # pkgs.ocamlformat # FIXME: fails to build `uunf` on aarch64-darwin :(
            ocamlPackages.merlin
            ocamlPackages.ocaml-lsp
          ];
          inputsFrom = [
            self.defaultPackage.${system}
          ];
        };
      });
}

Ahh wierd, for some reason when I do dune build --watch --terminal-persistence=clear-on-rebuild using the above nix file, builds a bin/garden.exe, rather than putting it in the _build directory?

Ahh wait, I think that must be because of the recommended dune file:
(executable
 (name garden)
 (public_name garden)
 (promote (until-clean)) ; <-- this is the culprit!
 (libraries preface yocaml yocaml_yaml yocaml_markdown yocaml_unix))

Thanks to work of @rizo now non-master main branches are also supported! E.g. this works: https://github.com/tweag/opam-nix/blob/main/examples/readme/my-package/my-package.opam#L16

Should I be looking at https://github.com/tweag/opam-nix#examples-8 for this?

No, it should just work with buildOpamProject and buildDuneProject now.

So I switched on pinDepends = true:

flake.nix
{
  description = "Static page generator for my digital garden";

  inputs = {
    # Utilities for writing flakes
    flake-utils.url = github:numtide/flake-utils;
    # Precisely filter files copied to the nix store
    nix-filter.url = "github:numtide/nix-filter";
    # Generate derivations from Dune and OCaml files
    opam-nix.url = github:tweag/opam-nix;
    # Static site generator for OCaml (not yet published to opam)
    yocaml.url = "github:xhtmlboi/yocaml";
    yocaml.flake = false;
  };

  outputs = { self, nixpkgs, flake-utils, nix-filter, opam-nix, yocaml }:
    flake-utils.lib.eachDefaultSystem (system:
      let
        # Legacy packages that have not been converted to flakes
        legacyPackages = nixpkgs.legacyPackages.${system};
        # OCaml packages available on nixpkgs
        ocamlPackages = legacyPackages.ocamlPackages;

        # OCaml source files
        ocaml-src = nix-filter.lib.filter {
          root = ./.;
          include = [
            "dune-project"
            "garden.opam.template"
            (nix-filter.lib.inDirectory "bin")
          ];
        };

        # Nix source files
        nix-src = nix-filter.lib.filter {
          root = ./.;
          include = [
            (nix-filter.lib.matchExt "nix")
          ];
        };
      in
      {
        # Used for `nixpkgs` packages, also accessible via `nix build .#<name>`
        legacyPackages =
          (opam-nix.lib.${system}.buildDuneProject
            {
              pinDepends = true;
              repos = [
                opam-nix.inputs.opam-repository
                (opam-nix.lib.${system}.makeOpamRepo yocaml)
              ];
            }
            "garden"
            ocaml-src
            {
              # Include `yocaml` packages
              yocaml = null;
              yocaml_markdown = null;
              yocaml_mustache = null;
              yocaml_unix = null;
              yocaml_yaml = null;

              # Ask `opam-nix `to include editor tools in the same scope as our
              # package, ensuring that they will be built using the same
              # compiler version etc.
              merlin = null;
              ocaml-lsp-server = null;
            });

        # Executed by `nix build`
        defaultPackage = self.legacyPackages.${system}.garden;

        # Executed by `nix run .#<name>`
        apps.garden = {
          type = "app";
          program = "${self.legacyPackages.${system}.garden}/bin/garden";
        };

        # Executed by `nix run`
        defaultApp = self.apps.${system}.garden;

        # Used by `nix develop`
        devShell = legacyPackages.mkShell {
          nativeBuildInputs = [
            # Editor support
            legacyPackages.fswatch # for `dune build --watch --terminal-persistence=clear-on-rebuild`
            # legacyPackages.ocamlformat # FIXME: fails to build `uunf` on aarch64-darwin :(
            self.legacyPackages.${system}.merlin
            self.legacyPackages.${system}.ocaml-lsp-server
          ];
          inputsFrom = [
            self.defaultPackage.${system}
          ];
        };
      });
}

but now I am getting warnings like:
trace: warning: pin-depends without an explicit sha1 is not supported in pure evaluation mode; try with --impure

I also get a build error:
@nix { "action": "setPhase", "phase": "unpackPhase" }
unpacking sources
unpacking source archive /nix/store/4d0ix5djms3n2jnjdc58l916cwack1rp-empty-directory
source root is empty-directory
@nix { "action": "setPhase", "phase": "patchPhase" }
patching sources
@nix { "action": "setPhase", "phase": "updateAutotoolsGnuConfigScriptsPhase" }
updateAutotoolsGnuConfigScriptsPhase
@nix { "action": "setPhase", "phase": "configurePhase" }
configuring
patching script interpreter paths in .
cp: cannot create regular file '/tmp/opam-subst': Permission denied

Ooohh, so I need to set a sha in the pinned dependency?

I'm wondering if it's possible to use an opam lockfile to simplify this kind of thing? This is what naersk does, but I'm not too clear on the specifics of how opam works to know if it's possible here too…  eg. I'm not sure how to generate the lockfile in the first place. I'm guessing it might require opam to be installed globally?

but now I am getting warnings like:

Well, the warning tells you exactly what to do: run your command again with --impure, or set the git commit sha1 (a.k.a rev) in the opam file (like done in the example: https://github.com/tweag/opam-nix/blob/main/examples/readme/my-package/my-package.opam#L14)

I also get a build error:

That error looks weird, I'll look into it

Well, the warning tells you exactly what to do

Yeah, I didn't want to run it in --impure, as I thought this was the point of flakes: offering isolation. I also couldn't tell from the warning where to set the sha - I was looking for somewhere in the nix file, not the .opam.template.

To be clear, this is also supported by opam, and is a good idea for reproducibility purposes regardless of opam-nix.

Ahh yeah, this might be me confused by opam's model… (which I find confoundingly frustrating at the best of times). Coming from Cargo git dependencies are automatically pinned in a lockfile. I'll go ahead and add the sha to the pin-depends, but it is kind of frustrating as it loses information on what branch it is supposed to be tracking, and can't be updated with tooling. :(
Sorry again for all my confusion!

Could it be that there is some weirdness in how opam-nix is understanding my pinned deps?
pin-depends: [
  # The sha1 hashes currently point to the main branch of the yocaml repository
  ["yocaml.dev" "git+https://github.com/xhtmlboi/yocaml.git#167cddf111bec1095fc35a10f5c10d2d25e9adbd"]
  ["yocaml_markdown.dev" "git+https://github.com/xhtmlboi/yocaml.git#167cddf111bec1095fc35a10f5c10d2d25e9adbd"]
  ["yocaml_mustache.dev" "git+https://github.com/xhtmlboi/yocaml.git#167cddf111bec1095fc35a10f5c10d2d25e9adbd"]
  ["yocaml_unix.dev" "git+https://github.com/xhtmlboi/yocaml.git#167cddf111bec1095fc35a10f5c10d2d25e9adbd"]
  ["yocaml_yaml.dev" "git+https://github.com/xhtmlboi/yocaml.git#167cddf111bec1095fc35a10f5c10d2d25e9adbd"]
]

Certainly possible :)
What is the exact problem you're experiencing?


Pairing blog post

This is the initial draft from our first pairing session on this post

Alright, we've fixed up a bunch of the I / we issues - but generally speaking want to keep the general flow of an opening which sets the I up as being Yuki, then always talk to "you" when it's something hands on

LGTM! Merge on green

Seems like merge on green is triggering a merge any more. Manually merging.

Did it need a rebase?


Component Name Conflict

I have just found an issue when naming a layout the same as another component.  Currently it will load the layout in the component which could cause an infinite mirror effect. :(
I had a component named 'panel' and created a layout called 'panel'.
This issue happened as the layout will also use
I think it should instead use  instead
Sure this can be avoided just by making sure your component and layout names are unique, but that becomes difficult when importing plugins and other directives.
This can easily be avoided by changing:
layouts().forEach(c => {
    c = c.default || c
    Vue.component(c.name, c)
  })

TO
layouts().forEach(c => {
    c = c.default || c
    Vue.component('layouts-' + c.name, c)
  })

And by changing
function layoutCompile (context) {
  return _Vue.compile(`<${(context.$route.meta.layout || 'default')} />`)
}

TO
function layoutCompile (context) {
  return _Vue.compile(`<layout-${(context.$route.meta.layout || 'default')} />`)
}

Thanks

This also might be a good chance to add a configuration option for this:
And leave the default as ''
Vue.use(VueExtendLayout, {
	componentPrefix: 'layout-'
})

@ggedde
Done: v1.1.0
https://github.com/ktquez/vue-extend-layout#options
Thanks so much for use and for contribution.


Update resources in README.md with HSE minor and article about strategies

Before submitting (must do checklist)

[x] Did you read the contribution guide?
[x] Did you update the docs? We use Numpy format for all the methods and classes.
[x] Did you write any new necessary tests?
[ ] Did you update the CHANGELOG?

Proposed Changes
Add link with article about strategies. Add link with video for HSE.
Closing issues

Codecov Report

Merging #1240 (66ec82f) into master (f06cd82) will decrease coverage by 0.07%.
The diff coverage is n/a.

:mega: This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more
@@            Coverage Diff             @@
##           master    #1240      +/-   ##
==========================================
- Coverage   87.92%   87.85%   -0.07%
==========================================
  Files         186      186
  Lines       10621    10617       -4
==========================================
- Hits         9338     9328      -10
- Misses       1283     1289       +6

see 6 files with indirect coverage changes
:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more


Bars not showing when transformed from a list

Hello
First of all - love this project. The charts look amazing.
I tried to include it in my project and having a problem with bars not showing when transformed from a list.
I started with the your example:
                ColumnChart(
                    modifier = Modifier.fillMaxWidth().height(250.dp).padding(horizontal = 22.dp),
                    /*
                    data = tmpStatisticsState.value.dayStatistics.map {
                        Bars(
                            label = it.date.format(HpAndroidGUIConstants.LOCALIZED_DATE_FORMATTER),
                            values = listOf(
                                Bars.Data(label = "All items", value = 10.0, color = SolidColor(Color.Blue)),
                                // Bars.Data(label = tmpLabelAllItems, value = it.amountItems.toDouble(), color = SolidColor(Color.Blue)),
                                Bars.Data(label = "Done items", value = 15.0, color = SolidColor(Color.Red)),
                                // Bars.Data(label = tmpLabelDoneItems, value = it.amountDoneItems.toDouble(), color = SolidColor(Color.Red)),
                            )
                        )
                    },
                    */
                    data = listOf(
                        Bars(
                            label = "Jan",
                            values = listOf(
                                Bars.Data(label = "Linux", value = 50.0, color = SolidColor(Color.Blue)),
                                Bars.Data(label = "Windows", value = 70.0, color = SolidColor(Color.Red)),
                            )
                        ),
                        Bars(
                            label = "Feb",
                            values = listOf(
                                Bars.Data(label = "Linux", value = 80.0, color = SolidColor(Color.Blue)),
                                Bars.Data(label = "Windows", value = 60.0, color = SolidColor(Color.Red)),
                            )
                        )
                    ),
                    animationSpec = spring(
                        dampingRatio = Spring.DampingRatioMediumBouncy,
                        stiffness = Spring.StiffnessLow
                    )
                )

This works like expected:

Now I get the List of Bars from a transformation:
               ColumnChart(
                    modifier = Modifier.fillMaxWidth().height(250.dp).padding(horizontal = 22.dp),
                    data = tmpStatisticsState.value.dayStatistics.map {
                        Bars(
                            label = it.date.format(HpAndroidGUIConstants.LOCALIZED_DATE_FORMATTER),
                            values = listOf(
                                Bars.Data(label = "All items", value = 10.0, color = SolidColor(Color.Blue)),
                                // Bars.Data(label = tmpLabelAllItems, value = it.amountItems.toDouble(), color = SolidColor(Color.Blue)),
                                Bars.Data(label = "Done items", value = 15.0, color = SolidColor(Color.Red)),
                                // Bars.Data(label = tmpLabelDoneItems, value = it.amountDoneItems.toDouble(), color = SolidColor(Color.Red)),
                            )
                        )
                    },
                    /*
                    data = listOf(
                        Bars(
                            label = "Jan",
                            values = listOf(
                                Bars.Data(label = "Linux", value = 50.0, color = SolidColor(Color.Blue)),
                                Bars.Data(label = "Windows", value = 70.0, color = SolidColor(Color.Red)),
                            )
                        ),
                        Bars(
                            label = "Feb",
                            values = listOf(
                                Bars.Data(label = "Linux", value = 80.0, color = SolidColor(Color.Blue)),
                                Bars.Data(label = "Windows", value = 60.0, color = SolidColor(Color.Red)),
                            )
                        )
                    ),
                    */
                    animationSpec = spring(
                        dampingRatio = Spring.DampingRatioMediumBouncy,
                        stiffness = Spring.StiffnessLow
                    )
                )

Now the bars are not showing (even though I replaced the values with fixed values to make sure they are not empty):

Am I overlooking something?
Any idea?
Thanks and best regards
Stephan

Hi @stephansann , i glad to hear it you likes this lib.
Your problem looks weird because the labels and indicators are visible depends on you data.
I dont have any idea whats happening, first set random values and test it ( for example (0..50).random() )
And if did not solved, let me notified, then I'll work on that.

Hi @ehsannarmani
Thanks for the swift response.
I was able to isolate the issue. The problem is not the transformation of the list.
The problem is that the bars do not show up when a new state is emitted by my view model.
When my view is loaded, I will get the newest statistic data:
    val tmpStatisticsState = statisticsViewModel.dayStatisticsState.collectAsState()
    statisticsViewModel.getDayStatistics(true)

I guess the re-rendering of the view by the state change will interfere with the animation of the bars.
By disabling the state change...
    val tmpStatisticsState = statisticsViewModel.dayStatisticsState.collectAsState()
    //statisticsViewModel.getDayStatistics(true)

... I now get the bars:

Anyhow my data is not current any more :-(
Is there a way to make the bar animation "state proof"? Otherwise maybe disable it!?
Thanks again and best regards
Stephan

@stephansann You mean the chart does not re-render when state is changed?

@ehsannarmani I mean that there will be no bars when there is a state change.
If the reason for this is that there is no re-rendering, or if there is a re-rendering with some conflict I cannot say.

But i tested a simple scenario with this code:
                   val data = remember {
                        mutableStateOf(listOf(10 to 20, 15 to 20))
                    }
                    ColumnChart(modifier=Modifier.height(300.dp),data = data.value.mapIndexed {index,value-> Bars(
                        label = "Data $index",
                        values = listOf(
                            Bars.Data(value = value.first.toDouble(), color = SolidColor(Color.Red)),
                            Bars.Data(value = value.second.toDouble(), color = SolidColor(Color.Blue)),
                        )
                    ) })
                    Button(onClick = {
                        data.value = MutableList(3){
                            (0..10).random() to (10..20).random()
                        }
                    }) {
                        Text(text = "Test")
                    }

In this code the data state will change when we click on button.
but i did not see any problem, everything worked fine.

My statistical data is loaded in a CoroutineScope within the ViewModel.
Here is how to reproduce, based on your code:
    val data = remember {
        mutableStateOf(listOf(10 to 20, 15 to 20))
    }
    ColumnChart(modifier = Modifier.height(300.dp), data = data.value.mapIndexed { index, value ->
        Bars(
            label = "Data $index",
            values = listOf(
                Bars.Data(value = value.first.toDouble(), color = SolidColor(Color.Red)),
                Bars.Data(value = value.second.toDouble(), color = SolidColor(Color.Blue)),
            )
        )
    })

    CoroutineScope(Dispatchers.Main).launch {
        delay(100)
        data.value = MutableList(3) {
            (0..10).random() to (10..20).random()
        }
    }

Maybe I have to solve it differently.
Let me know if you have an idea.
Thanks in any case for your support 🙏🏻

Found the solution. The loading of the data caused a loop, ending up in starting the bar animation over and over again (which resulted in no bars being shown).
Solution:
    val tmpStatisticsState = statisticsViewModel.dayStatisticsState.collectAsState()
    LaunchedEffect(Unit) {
        statisticsViewModel.getDayStatistics(true)
    }

Sorry for the "false alarm".

Ah, i saw you code but i thought you putted like this in just github and its correct in your code.
No problem.


Fix enforce protection logic

At the moment the app copies all current required status checks as an array and then, depending on whether you enforce it or not, adds a new required check to that array. That means that even though you toggle the boolean from true to false, it will still be part of the original array of required checks.
This PR:

Removes the context from the required contexts array if it is un-enforced
Adds specs for the enforce-protections function

Fixes #24

Release with 1.3.0.


ToProtoMessage to GetProtoMessage

There was still one ToProtoMessage. Now all Tests are running fine.

thank you.


Change seo option to false for next major version

What problem does this feature solve?
seo = true option is computationally expensive (https://nuxt-community.github.io/nuxt-i18n/seo.html#improving-performance), sometimes even breaks the code, and users typically don't need the functionality it provides and would be fine with using it the way the mentioned link describes.
What does the proposed changes look like?
I suggest change seo option to false by default, update documentation regarding that and suggest using solution from https://nuxt-community.github.io/nuxt-i18n/seo.html#improving-performance
Those who really need that functionality will be able to change the option to true.

This feature request is available on Nuxt community (#c256)

Thanks @rchl, I think this makes sense. Would you have some time to open a PR by any chance?

Guys, THIS MUST BE ADDED IN THE NEXT VERSION!!!! I just waisted a WHOLE DAY trying to figure out why my already built website had a a major issue with my page styles breaking on page route changes because my body class style kept changing all of a sudden. I spent the whole day looking into thing and resorted to changing my CSS to get it to work. The realised what if it's something to do with nuxt-i18n because I installed it the previous day! Then I see this, made seo:false, AND MY WEBSITE IS BACK TO NORMAL AGAIN!!!! (Yes i am extremly happy now!) Guys this is a bad design decision... Never force a setting on a user! Please disable in the next release!

@hga77 That's the plan :) https://github.com/nuxt-community/nuxt-i18n/pull/362/commits/5115b5b45490ad198d0607a3ee5ee2eeeaf1cebd


naming: dotnet, dn, .net, etc.

let's try to be consistent with naming
use dn prefix throughout?
class DnfileFeatureExtractor(FeatureExtractor):

??? up for discussion
Originally posted by @williballenthin in https://github.com/mandiant/capa/pull/955#discussion_r842125380

yeah, i think this is good, when reasonable. for example, lets keep is_dotnet_file (not is_dn_file), but i do like DnfileExtractor over DotnetfileExtractor

same thoughts; dn over dotnet when possible

👍  see e.g. 1418562b


Do not store decrypted private keys

https://github.com/3s3s/multicoins.org/blob/master/server_side/app.js#L49
DecodeWallet stores the decrypted private keys in localstorage.
It is safer to store the decrypted private keys in memory only.
Some reasons:

If the user closes the browser tab and forgets to encrypt, the wallet stays decrypted, which is a security risk.

Localstorage also writes to disk, even if wallets are encrypted consistently, private keys can still be retrieved by attackers.

Not sure this is such a necessary feature. Most of clients are store decrypted private keys in local drive (wallet.dat). But I will think about the possible implementation this. Thank you.

Yes you are correct. If it doesn't fit your wallet, no worries.
It's just something that I'd find important, but like you say most users don't really care.
So if you think it would reduce adoption, feel free to ignore.


[ServiceBus] throw error for invalid scheduledEnqueueTimeUtc

to scheduleMessages().
The service ignores the value when it is not valid. This may surprise JavaScript developers who pass in a datetime string and expect it to work.  This adds an instanceof check to only accept Date instances

API change check
API changes are not detected in this pull request.


artisan make:policy returning empty dependence

Laravel Version: 7.6.1
PHP Version: 7.4.1
Database Driver & Version:

Description:
When I use the  artisan make:policy   command with the -m option, it returns a empty dependence in the Class
Steps To Reproduce:
php artisan make:policy RolePolicy -m Role
Returned Class:
<?php

namespace App\Policies;

use App\Role;
use Illuminate\Auth\Access\HandlesAuthorization;
use ;

class RolePolicy
{

I get the same issue when I try php artisan make:policy RolePolicy --model=Role.
But If i type php artisan make:policy RolePolicy -m=Role it returns:
 <?php

namespace App\Policies;

use App\=Role;
use Illuminate\Auth\Access\HandlesAuthorization;
use ;

I don't get this problem in the latest version. I just get the expected dependencies.

I've got same problem in laravel 5.8.*


[KFNBC] Most cards under Resources tab still show JupyterHub icon

As per discussion on Slack with Guillaume, these icons should all be Jupyter icons rather than JupyterHub icons once KFNBC is implemented.

One of the cards has the correct Jupyter icon, the rest have the JupyterHub icon still.

@laubai Just want to make sure, we want to keep all of these docs, and only change the icons of them, right?

@DaoDaoNoCode Good question - I think so, but I haven’t actually run through them. Let me do that on Monday and get back to you.

@DaoDaoNoCode Yes, we can keep them all. I will log a separate issue, though - Launching Jupyter hides the QuickStart that the user is currently following steps in, which is an issue for people trying to complete the  first quickstart! :)

@laubai Is there a getting-started doc for jupyter like this jupyterhub one? https://github.com/opendatahub-io/odh-dashboard/blob/main/data/getting-started/jupyterhub.md. If there is no, should I also hide the jupyterhub card on the Explore page when the notebook controller is enabled?

Bulk un-assigning things that were old -- reassigned this back to you @DaoDaoNoCode as you're working on it now. If you are actively working on it please move it into progress on the board.

Sure, already moved. I just need some more information to get this PR submitted so I can make sure we are showing the correct docs on every page including Explore and Resources.


fix(ci): add comments rule to forgo double space requirement

yamllinter expects double spaces before comments, this patch adds an exception for yamllinter to allow single space.

I think the title should be modified. This title will trigger a patch release. 😄

I think the title should be modified. This title will trigger a patch release. 😄

Good point, I forgot we had auto-release based on commits here. I like the new prefix you suggested (ci(lint):).


PaypalAdaptive is broken under Ruby 1.9.3

citadela:paypal_adaptive deepj$ ruby -v
ruby 1.9.3p0 (2011-10-30 revision 33570) [x86_64-darwin11.2.0]

citadela:paypal_adaptive deepj$ rake test
Run options:

# Running tests:

...-------
get shipping addresses
E........EEE...-------
chain
E-------
parallel
E-------
simple
E-------
payment details
E-------
set payment options
E-------
invalid
E-------
invalid
E-------
valid test
{"returnUrl"=>"http://<IP_ADDRESS>:3000/payments/completed_payment_request", "requestEnvelope"=>{"errorLanguage"=>"en_US"}, "currencyCode"=>"USD", "cancelUrl"=>"http://<IP_ADDRESS>:3000/payments/canceled_payment_request", "maxTotalAmountOfAllPayments"=>"1500.00", "maxNumberOfPayments"=>"30", "startingDate"=>"2020-07-13T07:00:00.000Z", "endingDate"=>"2020-12-13T07:00:00.000Z"}
E

Finished tests in 14.331456s, 1.8142 tests/s, 0.5582 assertions/s.

  1) Error:
test_get_shipping_addresses(GetShippingAddressesTest):
TypeError: can't convert nil into String
    /Users/deepj/dev/oss/paypal_adaptive/lib/paypal_adaptive/request.rb:90:in `post'
    /Users/deepj/dev/oss/paypal_adaptive/lib/paypal_adaptive/request.rb:75:in `wrap_post'
    /Users/deepj/dev/oss/paypal_adaptive/lib/paypal_adaptive/request.rb:29:in `pay'
    /Users/deepj/dev/oss/paypal_adaptive/test/unit/get_shipping_addresses_test.rb:19:in `test_get_shipping_addresses'

  2) Error:
test_invalid_chain_pay(PayRequestTest):
TypeError: can't convert nil into String
    /Users/deepj/dev/oss/paypal_adaptive/lib/paypal_adaptive/request.rb:90:in `post'
    /Users/deepj/dev/oss/paypal_adaptive/lib/paypal_adaptive/request.rb:75:in `wrap_post'
    /Users/deepj/dev/oss/paypal_adaptive/lib/paypal_adaptive/request.rb:29:in `pay'
    /Users/deepj/dev/oss/paypal_adaptive/test/unit/pay_request_test.rb:50:in `test_invalid_chain_pay'

  3) Error:
test_invalid_parallel_pay(PayRequestTest):
TypeError: can't convert nil into String
    /Users/deepj/dev/oss/paypal_adaptive/lib/paypal_adaptive/request.rb:90:in `post'
    /Users/deepj/dev/oss/paypal_adaptive/lib/paypal_adaptive/request.rb:75:in `wrap_post'
    /Users/deepj/dev/oss/paypal_adaptive/lib/paypal_adaptive/request.rb:29:in `pay'
    /Users/deepj/dev/oss/paypal_adaptive/test/unit/pay_request_test.rb:71:in `test_invalid_parallel_pay'

  4) Error:
test_invalid_simple_pay(PayRequestTest):
TypeError: can't convert nil into String
    /Users/deepj/dev/oss/paypal_adaptive/lib/paypal_adaptive/request.rb:90:in `post'
    /Users/deepj/dev/oss/paypal_adaptive/lib/paypal_adaptive/request.rb:75:in `wrap_post'
    /Users/deepj/dev/oss/paypal_adaptive/lib/paypal_adaptive/request.rb:29:in `pay'
    /Users/deepj/dev/oss/paypal_adaptive/test/unit/pay_request_test.rb:25:in `test_invalid_simple_pay'

  5) Error:
test_valid_chain_pay(PayRequestTest):
TypeError: can't convert nil into String
    /Users/deepj/dev/oss/paypal_adaptive/lib/paypal_adaptive/request.rb:90:in `post'
    /Users/deepj/dev/oss/paypal_adaptive/lib/paypal_adaptive/request.rb:75:in `wrap_post'
    /Users/deepj/dev/oss/paypal_adaptive/lib/paypal_adaptive/request.rb:29:in `pay'
    /Users/deepj/dev/oss/paypal_adaptive/test/unit/pay_request_test.rb:36:in `test_valid_chain_pay'

  6) Error:
test_valid_parallel_pay(PayRequestTest):
TypeError: can't convert nil into String
    /Users/deepj/dev/oss/paypal_adaptive/lib/paypal_adaptive/request.rb:90:in `post'
    /Users/deepj/dev/oss/paypal_adaptive/lib/paypal_adaptive/request.rb:75:in `wrap_post'
    /Users/deepj/dev/oss/paypal_adaptive/lib/paypal_adaptive/request.rb:29:in `pay'
    /Users/deepj/dev/oss/paypal_adaptive/test/unit/pay_request_test.rb:62:in `test_valid_parallel_pay'

  7) Error:
test_valid_simple_pay(PayRequestTest):
TypeError: can't convert nil into String
    /Users/deepj/dev/oss/paypal_adaptive/lib/paypal_adaptive/request.rb:90:in `post'
    /Users/deepj/dev/oss/paypal_adaptive/lib/paypal_adaptive/request.rb:75:in `wrap_post'
    /Users/deepj/dev/oss/paypal_adaptive/lib/paypal_adaptive/request.rb:29:in `pay'
    /Users/deepj/dev/oss/paypal_adaptive/test/unit/pay_request_test.rb:15:in `test_valid_simple_pay'

  8) Error:
test_payment_details(PaymentDetailsTest):
TypeError: can't convert nil into String
    /Users/deepj/dev/oss/paypal_adaptive/lib/paypal_adaptive/request.rb:90:in `post'
    /Users/deepj/dev/oss/paypal_adaptive/lib/paypal_adaptive/request.rb:75:in `wrap_post'
    /Users/deepj/dev/oss/paypal_adaptive/lib/paypal_adaptive/request.rb:29:in `pay'
    /Users/deepj/dev/oss/paypal_adaptive/test/unit/payment_details_test.rb:18:in `test_payment_details'

  9) Error:
test_payment_options(PaymentOptionsTest):
TypeError: can't convert nil into String
    /Users/deepj/dev/oss/paypal_adaptive/lib/paypal_adaptive/request.rb:90:in `post'
    /Users/deepj/dev/oss/paypal_adaptive/lib/paypal_adaptive/request.rb:75:in `wrap_post'
    /Users/deepj/dev/oss/paypal_adaptive/lib/paypal_adaptive/request.rb:29:in `pay'
    /Users/deepj/dev/oss/paypal_adaptive/test/unit/payment_options_test.rb:19:in `test_payment_options'

 10) Error:
test_invalid_preapproval(PreapprovalTest):
TypeError: can't convert nil into String
    /Users/deepj/dev/oss/paypal_adaptive/lib/paypal_adaptive/request.rb:90:in `post'
    /Users/deepj/dev/oss/paypal_adaptive/lib/paypal_adaptive/request.rb:75:in `wrap_post'
    /Users/deepj/dev/oss/paypal_adaptive/lib/paypal_adaptive/request.rb:49:in `preapproval'
    /Users/deepj/dev/oss/paypal_adaptive/test/unit/preapproval_test.rb:31:in `test_invalid_preapproval'

 11) Error:
test_invalid_preapproval_with_bad_credit_information(PreapprovalTest):
TypeError: can't convert nil into String
    /Users/deepj/dev/oss/paypal_adaptive/lib/paypal_adaptive/request.rb:90:in `post'
    /Users/deepj/dev/oss/paypal_adaptive/lib/paypal_adaptive/request.rb:75:in `wrap_post'
    /Users/deepj/dev/oss/paypal_adaptive/lib/paypal_adaptive/request.rb:49:in `preapproval'
    /Users/deepj/dev/oss/paypal_adaptive/test/unit/preapproval_test.rb:45:in `test_invalid_preapproval_with_bad_credit_information'

 12) Error:
test_preapproval(PreapprovalTest):
TypeError: can't convert nil into String
    /Users/deepj/dev/oss/paypal_adaptive/lib/paypal_adaptive/request.rb:90:in `post'
    /Users/deepj/dev/oss/paypal_adaptive/lib/paypal_adaptive/request.rb:75:in `wrap_post'
    /Users/deepj/dev/oss/paypal_adaptive/lib/paypal_adaptive/request.rb:49:in `preapproval'
    /Users/deepj/dev/oss/paypal_adaptive/test/unit/preapproval_test.rb:16:in `test_preapproval'

26 tests, 8 assertions, 0 failures, 12 errors, 0 skips
rake aborted!
Command failed with status (12): [/Users/deepj/.rvm/rubies/ruby-1.9.3-p0/bin...]

Tasks: TOP => test => test:units
(See full trace by running task with --trace)

In my test and application PaypalAdaptive::Request.pay returns the same error under Ruby 1.9.3, Ruby 1.9.2 is okay.

See fix https://github.com/tc/paypal_adaptive/pull/29


Nexus 4: Home Button and Quick Settings broken

Hello!
I have followed the procedure to restore Quick Settings on my Nexus 4 with latest snapschot of CM13.
Still no luck.

I can confirm this (on a different device). It seems like something changed in the last month or two.
A (poor) workaround was to install an older version of Cyanogenmod 13.

Maybe it is because freecyngn removes Setup Wizard...

This line is responsible for enabling functionality that CyanogendSetupWizard is normally responsible for:
/system/xbin/sqlite3 /data/data/org.cyanogenmod.cmsettings/databases/cmsettings.db "update secure set value = 1 where name = 'cm_setup_wizard_completed';"
https://github.com/nvllsvm/freecyngn/blob/1db806bbbf08c86ef32ec53d60e459736ed5f320/20-freecyngn.sh#L29
This works on my Nexus 5X. Don't have a Nexus 4 to test with.

My device is a OnePlus One.

Home button is also broken on Nexus 5 using these builds