Is angularfire affected by the upgrade of the Firebase tools, now Firebase 3.x?

I'm just reading the web API reference, but what about integrating angular?

I just imported one of my projects to the new console and the web app still works fine with firebase 2.4.2 and angularfire 1.2.0. I will test upgrading firebase to 3.0.0 later today and see if it breaks.

ok, so you can import your project on the console, what about the support for firebase 2, the docs for the 2 versions appears as deprecated so i would like to know for how long this version will be supported because i am just finishing an app and is not cool to release a new app that uses a deprecated firebase version.

Upgrading to Firebase 3.0.0 modifies some of the sintaxis to save and read data, besides the use of the Firebase reference and child events.
You can import the database to the new console and most of the queries are done the same way.
But with Fireabse 3 you have to use firebase.database(), and it sure affects this library right?
I would also assume $firebaseRef no longer works with version 3.

Interesting, on Firebase migration guide, they are talking about Angularfire 2.x to support Firebase 3.x: https://firebase.google.com/support/guides/firebase-web#update_your_firebase_libraries_numbered
But it looks like this Angularfire 2.x doesn't exist yet.

You are correct, 1.2.0 $firebaseRef no longer works with firebase 3.0.0. I cannot even authenticate after upgrading.
ReferenceError: Firebase is not defined
    at FirebaseRef.$$createMultipleRefs [as $$createRefsFromUrlConfig]

Angular fire 1.xx to 2.xx guide
It is in the 2.0 branch docs folder

Okay, lots of different discussions going on here. Let's see if I can set things straight.
We are upgrading this AngularFire library (compatible with Angular 1.x) to the new 3.0.0 Firebase SDK in #717. We will be following semver and release it as version 2.0.0 since it contains breaking changes (the auth stuff, not the database stuff). This does not imply that it will work with Angular 2.
If you want to use AngularFire in Angular 2, check out AngularFire2. It will be upgraded to the Firebase 3.0.0 in the coming days to weeks. @davideast and @jeffbcross are leading the AngularFire2 effort.
The existing AngularFire library (and all Firebase apps) will continue to work if you simply keep using the libraries you are using today. If you migrate your app to the new console, you existing apps will continue to work. We've worked really hard to ensure backwards compatibility with our existing libraries.
If you do decide to upgrade to the new Firebase JavaScript SDK, there are in fact a handful of breaking changes. Please check out our migration guide.

@jwngr thanks for your time. I really appreciate the effort handling this update. Really, great work.
Are there estimated times for these releases?

I would suspect in the hours to days timeline - but no promises :)

I noticed that in order to use the new "Sign up confirmation" auth feature you have to be using Firebase SDK 3.0.0 so I'm looking forward to the AngularFire upgrade as well!

@abehaskins the firebasearray code update is working pretty well with firebase 3 :)

Hi.
We've updated Firebase to v3 but our application does not work because all calls to DB are made with AngularFire 1.2 which currently does not support v3. Is it right?
@jwngr could you please give any estimate/date when #717 will be merged (which means the new version of AngularFire will support Firebase v3, right?). I just need to give a report to my client when I can finish migration to Firebase v3.
Thank you

We should be able to review, test, merge, and publish a new version by the end of next week. Hopefully sooner. In the meantime, please continue with the existing libraries against the 2.x.x Firebase SDKs.

@jwngr Thanks Jacob! Really appreciate your hard work!

what we want? Merge!, when we want? Now! Thx your guys for the hard work.

To give an update here: @abehaskins and I are fighting with some test failures and trying to make sure the library works as expected with the 3.x.x SDK. This lib is a bit trickier to update than the other *Fire libs since the code is old, there are more tests, and it uses more parts of the underlying Firebase SDK (like auth). Hang tight and hopefully we can get a new version out to you sometime this week.

The new version of AngularFire which is compatible with the Firebase 3.x.x SDK is out! 🎉


Flyway binaries  for Solaris and Aix

Do we have Flyway binary tar files for Solaris and Aix OS?

The version without JRE should work on any OS with a Java 6+ JRE


plugin manager crash

I am using ver 2.14.0 from the fedora repo on fedora 24. Attempting to open the plugin manager from the menu bar produces a seg fault. Instructions ?

Please contact QGIS-user mailing list or forum: http://qgis.org/en/site/forusers/support.html
This issue tracker is for problem with QGIS Website only.


How can i bind event to a chart

in chart.js doc, BarChart prototype-methods, i can bind click event listener to the canvas and get the clicked bar via chart instance's methods. But in react, in this component, i can not access to the chart instance, even i do not know where is the canvas is... so how can i bind event listener and get the bar clicked?

I've released 0.5.0 which has 2 additional methods on all chart components

getChart: return the chartjs instance
getCanvass: return the canvass DOM element

Yeah, thanks a lot, this solves my problem~

I'm somewhat new to ReactJS and can't seem to get getChart working.
Could you post an example?


Add source map support to react.componentStack metadata

Description

We're using the provided React error boundary to capture app wide errors. This is working, but the included react.componentStack metadata doesn't take advantage of our uploaded source maps and still shows up as minified. This makes this information fairly useless, it would be nice to have proper source mapping in this section like we do in the stacktrace tab

Describe the solution you'd like

Provide some sort of mechanism for metadata that can allow us to pass a data format that can, at a minimum, take advantage of uploaded source maps, and ideally, be rendered nicely like the stacktrace tab. Also, update the React error boundary to use this new mechanism out of the box for react.componentStack metadata.
Describe alternatives you've considered

No alternative features. One possible workaround on our end is doing this mapping manually. We have access to our own source maps on our server, so we could expose a sort of bugsnag proxy API that can special case handle react.componentStack by reading on disk source maps and string substituting the minified names/file/row/column for the actual component name/file/row/column.

Hi @RobertMic
We do have an item on our product backlog to support symbolication of the React component stack.
I've noted the additional interest in this feature, and we will make sure to post any future updates on this thread.


Issue #138 [ci skip] adding setup info for windows

Description
doc updated to add windows setup info - win+gpu will not be supported

@NMontanaBrown if you want to add a another tab for Mac?

Codecov Report

Merging #144 into master will increase coverage by 8.33%.
The diff coverage is 78.37%.

@@            Coverage Diff             @@
##           master     #144      +/-   ##
==========================================
+ Coverage   35.26%   43.60%   +8.33%
==========================================
  Files          27       27
  Lines        1432     1438       +6
==========================================
+ Hits          505      627     +122
+ Misses        927      811     -116

Impacted Files
Coverage Δ

deepreg/predict.py
0.00% <0.00%> (ø)

deepreg/train.py
0.00% <ø> (ø)

deepreg/util.py
0.00% <ø> (ø)

deepreg/model/backbone/global_net.py
100.00% <100.00%> (+36.00%)
:arrow_up:

deepreg/model/backbone/local_net.py
100.00% <100.00%> (+46.15%)
:arrow_up:

deepreg/model/backbone/u_net.py
100.00% <100.00%> (+41.66%)
:arrow_up:

deepreg/model/layer_util.py
95.65% <0.00%> (+1.44%)
:arrow_up:

... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8563fdc...9d3c450. Read the comment docs.


feat: Add functions to directly get and set pan

Description
As of the time of writing, there is no getPan or setPan functions to directly set and get the pan value of a handle. However, soloud does provide such functions. The only way to set pan as of yet, is to provide a pan value to play(), or use the fadePan method, but that is not appropriate when you just need to instantly change pan, or when you need to just get the current value.
Requirements

[ ] Add a function to get the current pan value of a handle.
[ ] Add a function to set the current pan value of a handle.

Additional Context
We are making a game using this, and directly getting / setting pan is required for us, so we would appreciate it if this can be looked into.
Thanks.

@the-byte-bender sorry I forgot to write that this feature has been merged in main branch. Not yet on pub.dev


feat: add custom header key support to EventSource API

Solved https://github.com/Lusito/react-nano/issues/1.
Thanks to @RunDevelopment and @Lusito help me write these codes in:

https://github.com/Lusito/react-nano/issues/1
https://github.com/chaiNNer-org/chaiNNer/issues/1798

Even if the official EventSource API - MDN Page doesn't support custom header keys, for now, we can use event-source-polyfill to customize in @react-nano/use-event-source just using createESClassWithHeaders function.
With no breaking changes, It feels so cool to make this contribution.
Feel free to merge this pull request or not. I have already published the downstream version to NPM: https://www.npmjs.com/package/@hyler-coop/use-event-source. But looking forward to make react-nano be better together.

React nano probably should not add event-source-polyfill as a dependency, given that the first sentence in the README of that library is:

Пожалуйста не используйте эту обосранную библиотеку!

which Google Translate says is:

Please do not use this crap library!

There is also an issue about this line: https://github.com/Yaffle/EventSource/issues/213
This library also seems to have been the target/source of a supply chain attack: https://github.com/Yaffle/EventSource/issues/202. There's also https://github.com/Yaffle/EventSource/issues/199.
While software can be used an expression of free speech and a political statement, I would be careful with using such software.

First of all, I appreciate the effort to make a contribution. I'm not going to accept the PR for several reasons. I'll give you some explanations, so you understand it and are aware in case of another PR:
The polyfill
As @RunDevelopment already said, the library is a bit sketchy.
Even if it was completely trustworthy: A lot of users probably don't want to use the polyfill and with this PR, you are forcing them to download it anyway, as you've listed it as a dependency. Having it as a dependency also means, that I have to maintain the version number and make sure that there are no security issues with new versions.
A better approach would be to list it as a peerDependency. That way, the user doesn't need to install it unless they use the code that depends on it. In that case, the function createESClassWithHeaders should be defined in a separate file, so that one could do import { createESClassWithHeaders } from '@react-nano/use-event-source/with-polyfill' or something similar.
Alternatively, you could do it in a similar way as I did with EventSourceConstructor. I.e. define a constructor type, which accepts both withCredentials and headers. That way, no modification of the package.json would be required. Of course, the user would have to pass in the EventSourcePolyfill to the createESClassWithHeaders function for that to work.
Missing documentation
If I would accept a PR, which added new functionality, it should also modify the documentation, as otherwise people won't know it's there.
The package.json version
The version number is usually bumped up during the release and not during the feature pull requests. You can leave that work up to the maintainers of the library.
About fetch-event-source
That library has a different API (no classes, different listeners, ...), so there would have to be modifications to useEventSource.
A safer approach
I would not consider any of these approaches a best-practice, but rather a last-resort. What I could accept, would be to extend the readme with some information for those who have no other choice. But that choice should be well-informed, so a link to #1 would be mandatory (and reduce the required text in the readme).

OK, it's clear that we don't need this PR now.
My situation about injecting headers to EventSource API is in such uncommon usage, it's not necessary to make many modifications to this repo.
The other people who want to add header support will be led to this PR  and issue #1 by search engines, they will know what happened. So it's also not necessary for me to make another PR.
Let me close this PR and thanks for all your work and sharing!


Fix HTML entities in generator options

Possibly a byproduct of the change to backticks (#628)

Thanks @SlashmanX, yes I think it did slip in when we changed to backticks.


Cleanup/refactor some things, make it possible to use individual images, hide unused flags

Nits here and there, this is just the first round :)
ping @errordeveloper

I've cherry-picked this. Thanks, @luxas!


[v1] BackAndroid is deprecated. Please use BackHandler instead.

I get this yellowbox warning on android when this module is loaded. This looks like the culprit:
https://github.com/inProgress-team/react-native-youtube/blob/v1/YouTube.android.js#L13

I'll probably get to it sometime

https://github.com/react-community/react-navigation/issues/1330

#177


Does not limit the length of the id to a string type

In the zipkin model, the id value of the span can be set by the String type, but the length can be limited to no more than 16 bits.
public Span.Builder id(String id) {
    if (id == null) {
        throw new NullPointerException("id == null");
    } else {
    	int length = id.length();
        if (length == 0) {
            throw new IllegalArgumentException("id is empty");
        } else if (length > 16) {
            throw new IllegalArgumentException("id.length > 16");
        } else {
            Span.validateHex(id);
            this.id = length < 16 ? Span.padLeft(id, 16) : id;
            return this;
        }
    }
}

Now we use 0, 0.1, 0.1.1, <IP_ADDRESS>, ..., to describe the spanId. If the link is long, it may exceed 16 bits. Therefore, it is recommended not to set the maximum length or increase the maximum length. .

we dont support arbitrary string span IDs. a span ID is 64bit encoded as
lower hex

Question answered, thanks !


Automatically convert ExecCommand responses to strings

This would require passing in a decoding method, but it'll be well worth it so that users don't have to think about it

Done


Feature Request - om should return error messages when a product manifest cannot be generated

We ran into a situation where our tile was not fully configured (missing the stemcell version), and had trouble diagnosing the problem using om staged-manifest -p pivotal-mysql because it just returned null and exited successfully.
Looking at the OpsMan api /api/v0/staged/products/pivotal-mysql-307620e03012f3c2619e/manifest, we saw a much better error message:
 {"errors":{"base":["Product configuration is incomplete; cannot generate manifest"]}}

but returns a 200 error code for the http request
Ideally, we would see something like:
$ om staged-manifest -p pivotal-mysql
error: Product configuration is incomplete; cannot generate manifest
$ echo $?
1

At the moment, those errors are generated by OpsManager. We don't have definitie way of doing the same from staged-config command as we'd be require to duplicate the validation login in om.
Are you able to document the values that were incorrect? Maybe the staged-config just needs to do more work at extracting the config.

@crhino This change in better error messaging seems like it would be good for the product. Feel free to submit a PR (apologies for the delay)

@crhino
We did not implement the change you requested to staged-manifest, but we did add a new command for the Ops Manager 2.6+ API (pre-deploy-check) that will return an organized list of errors like so if run:
go run main.go --env /Users/pivotal/workspace/platform-automation-deployments/platform-automation/gcp/env/env.yml pre-deploy-check
go: finding github.com/cloudfoundry/bosh-cli v5.5.0+incompatible
go: downloading github.com/cloudfoundry/bosh-cli v5.5.0+incompatible
go: extracting github.com/cloudfoundry/bosh-cli v5.5.0+incompatible
Scanning OpsManager now ...

[X] director: p-bosh-41e836276c754094cdb1
    Error: Network is not assigned

    Error: Availability Zone is not assigned

    Error: verifier: AvailabilityZonesVerifier
    Why: IaaS default: Cannot find availability zone 'us-east-1', type: AvailabilityZonesVerifier

[X] product: p-event-alerts-131b5f3d7a54accac935
    Error: Network is not assigned

    Error: Availability Zone is not assigned

    Error: missing stemcell
    Why: Required stemcell OS: ubuntu-xenial version 97.34
    Fix: Download ubuntu-xenial version 97.34 from Pivnet and upload to OpsManager

    Error: property: .properties.mysql.internal.plan_name
    Why: can't be blank

    Error: property: .properties.smtp_selector.enabled.smtp_from
    Why: can't be blank

could not execute "pre-deploy-check": OpsManager is not fully configured
exit status 1

Could you explain your use case for staged-manifest a little better for the team? We highly encourage using staged-config for the manifest in Ops Manager, or config-template if you would like to get/edit the configuration before touching your Ops Manager. both commands do not fail when you pull down an config, but pre-deploy-check would allow you to see a list of all errors after you have run configure-product
However, if neither of these commands work for you, we'd like to understand how you and your team use staged-manifest.

Hi @crhino @sethboyles
Friendly reminder to keep this conversation alive and fresh! ^^

Hi there! 👋
It's been a while since we have had any response.
Given that we did add a new command that we think would be a solution, I am going to close this issue. If pre-deploy-check or config-template doesn't work for you, please let us know and reopen this issue with a little more context and/or a use case for staged-manifest
@crhino @sethboyles


[5.3] OperationQueue fixes

This is a rollup of three OperationQueue fixes, #2776 #2777 #2779
This is done as one PR as the some tests are disabled then enabled and  the commits overlap otherwise.

@swift-ci please test

Will this make it into 5.3? @parkera @millenomi


General approach for protocol message retransmission

Currently, any protocol implementation in Mir needs to manage periodic retransmission of its messages based on an abstract notion of time.
Since the need for periodically retransmitting certain protocol messages occurs at multiple places and in various protocols, it would be useful to create an abstraction for periodic message retransmission that can easily be reused.
Potential challenges:

Finding a compromise between encapsulating in a separate abstraction and giving the protocol enough control
Stopping retransmission when no longer needed

Potential challenges:

Taking advantage of network transport layer properties (e.g. TLS/TCP already provides reliable P2P communication channels)

After playing around and making my own stubborn channel (relevant event definitions) and implementing Alea with it, I've retained some ideas(wishes?) that may be good to keep in mind:

Using existing existing messages as implicit ACKs demands explicit control over acknowledgements.
It should be possible to mark whole module trees as received, which is useful for garbage collection of old protocol/subprotocol instances (and the protocol will provide an alternative method of catching up).
The cleanup condition alone for these subprotocols may be enough to serve as an implicit ACK to all the messages involved.
That said, sometimes a single message needs retries, and creating a whole module for it is cumbersome. For those, we can use a combination of module ID and a separate numeric (or string) sub ID to identify it.
It should be possible to easily send ACKs for messages, because it's convenient, but also to mark them as received on the sender's end, in order to implement implicit ACKs.
It's still useful to send messages that are not retransmitted (prevents some nasty infinite loops when helping nodes catch up).
The underlying channel is reliable anyways, so retransmissions can be veeery spaced in time (some orders of magnitude more than the expected latency). They will likely be focused in helping slow-but-not-too-slow nodes catch up.
Retransmissions mustn't overwhelm regular traffic, and duplicate messages definitely shouldn't accumulate in send buffers (this is not solved in my implementation).

Implementation-wise, I believe it's best to integrate it directly into the net module (unlike what I did). That way, it's possible to fully prevent retransmissions from accumulating in the send queue (solving no. 8).
If 3. sounds reasonable, instead of demanding explicit ID assignments for all messages, we could make it optional (or reserve one value like 0), and allow messages to be sent with retransmissions enabled, expecting the developer to eventually mark all module messages as received.
Instead of my stopgap solution of not letting more than x messages be retransmitted (placed in the send queue again) in each retransmission loop iteration, the send/processing loop seems to be a good point for deciding what message to send next (new or retransmission), stitching both the new message and retransmission queues together.
Apart from that, the combination of linked list for the queue, and a map serving as an index of what queue entries each module is associated with, seems to be a good choice (removes from the middle of the queue are probably common, and we don't want to fully iterate it whenever a message needs to be dequeued).


Project description and links are asked in form

Closes #47

@zachlatta Just  amended it to have only one form field now.


it's not working on 10.11.6

LOL. You need to give us a wee bit more information than that.
Do you get a "You cannot use the Aerial screen saver with this version of OS X. Please contact the vendor to get a newer version of the screen saver." error message?
If so then yes it is working. There is a bug in OS X.
The screen saver itself works fine. You just get that error with the preview.
So select the Aerial screen saver, close System Preferences, re-open System Preferences and now the preview should work. Let me know if it doesn't.
It's a bug in OSX.
More here if you are curious. http://alistairmcmillan.github.io/2016/04/25/OSX-Swift-screensaver-bug.html

Sorry, my fault. It's working fine now.


Broken link

"The latest workshop lab is run as part of AWS DeepRacer events conducted in 2022."
Workshop Lab Link in Readme does not work.

The link works though.


[Feature]: New models implementation

Description
I managed to add new models editing multiple config files (I learned how to do it), new models include:

Mel-Roformer-De-Reverb by anvuew
Mel-Roformer-De-Reverb-Less-Aggr by anvuew
Mel-Roformer-De-Reverb-Echo by Sucial
MelBand Roformer Kim | SYHFT
MelBand Roformer Kim | SYHFT V2
MelBand Roformer Kim | SYHFT V2.5
MelBand Roformer Kim | SYHFT V3
MelBand Roformer Kim | Big SYHFT V1
MelBand Roformer Kim | Big Beta 4 FT
BS-Roformer-Chorus-Male-Female

and more!
But to make these models work, their respective hash must be included in the model_data_new.json file of their respective arch with their parameters as you know.
The reason these models work in the original UVR project and the model hashes have not been added to the model_data_new.json file is because there are BETA versions that have been released that include a feature that automatically creates a file with the hash and parameters locally so it doesn't matter if the model hashes are not in the repo.

So.... The purpose of this issue is to decide what we should do since that repo is not ours. Maybe make a fork like I did to test these models and keep it updated, make a file in the audio-separator repo like with models.json or do you have any other ideas?
I would really like to add more models to audio-separator and I think you would too.
There are other models that did not work but I will check them carefully later.

Hey @Eddycrack864 - thanks for raising this, you're right I'd certainly love to add support for more models to audio-separator if inference already works with the existing architecture code!
I'm a bit confused by your message though 🤔 let me explain how things work here and perhaps you can help me figure out the missing pieces?
The audio-separator code for finding and downloading model files/configs is pretty messy tbh, because I originally wanted it to "just work" with any models added to UVR automatically. As such, the list_supported_model_files method here initially downloads the supported model list (download_checks.json) from the UVR repo.
It then adds onto that list any models which are listed in the models.json file in this repo, so we can add new models to audio-separator even if they haven't been added to UVR.
When it comes to loading a model, the download_model_files method here then attempts to download the model file and it's corresponding config file from either the UVR repo(s), or this repo - whichever location it finds the files in.
So, in my opinion the easiest way to add new models to audio-separator is to do what you did in your previous PR #165 where you give me the direct link to the model file and config file for each new model.
I can then just download those and upload them to this models/configs file store in this repo, add them to models.json and that's all that should be needed!
Hope this makes sense. If you can find the model .ckpt and .json config file for those models, send me the links and I'll try and get them working in audio-separator 😄

Oh, my bad. I hadn't checked this part of the code where if the model is a roformer it sets it to True. And of course, if it's MDX23C it won't use that, and anyway only MDX23C and Roformers use a .yaml config file 😅
What happened was that I first added a VR Arch model and it gave me an error since for this architecture you do have to add the corresponding model parameters to model_data_new.json so I assumed that I had to do the same for all the following models
Well, for VR Arch we will have to do something like what I described in my first message, here is the error in question btw

I will make a PR with all models, including the model that belongs to VR Arch but needs a workaround to work as I mentioned before.

Update: I figured out how to solve the models errors, now more models are coming!


doc(code-snippets): update link to use Kong org

(rebased it and resolved the conflict) thanks for basing it on a commit from LAST NOVEMBER DARRRREEENNNN (haha jkjk)


Apply template (/setup/turnkey/aws/)

And add overview and prerequisites.

preview is here
original

/lgtm
/approve


CANVAS-87 - Fix ESLint issues.

@kilometerskang Still see some lint warnings in src/client/components/App/index.js


AMD CPU Integrated graphics support. it seems like that this render engine dose not support AMD CPU Integrated graphics(AMD r5 5600u)

AMD CPU Integrated graphics support. it seems like that this render engine dose not support AMD CPU Integrated graphics(AMD r5 5600u)

AMD CPU Integrated graphics support. it seems like that this render engine dose not support AMD CPU Integrated graphics(AMD r5 5600u)

Fixed,it is the Problem of Edge explorer

Great, closing.


pkgs: introduce package-list.nix and trivialPackages stage

The idea here is to move as much of all-packages.nix to package-list.nix as humanly possible.
Pros:

It improves metrics because import package-list.nix gets cached between stages. Meanwhile, doing the same with import all-packages.nix produces a negative impact because all-packages.nix is complicated and caching it adds pressure on GC. Meanwhile, package-list.nix is just a list of paths, which is cheap.

It allows for easy experimentation with alternatives to callPackage as package-list.nix is, by definition, a set of trivial packages. (This was the initial motivation for this change.)

It's homogeneous with NixOS' module-list.nix.

Eventually package-list.nix can be completely autogenerated.

Cons:

Migration to package-list.nix does introduce some code churn.

This also adds maintainers/scripts/all-packages-to-package-list.sh script that does the (very conservative, currently) conversion automagically.
Take you time merging and testing this, conflicts are easy to fix: just rebase dropping the last commit and rerun the script.
Yes, this is a massive noop change. :)
/cc @matthewbauer @Ericson2314 @vcunat @edolstra

Ping. I see thumbs down, but can I have an explanation why? I see no reason not to proceed in this way except for the churn. And the churn won't be too much of an issue if we migrate in tiny installments (i.e. if we agree to merge the infra from the first commit and start adding new packages there).
Concerning package arguments, I think the better policy to doing what the current policy does is switching to using the following method:
Now:
in package:
  { stdenv, package }: ...

in all-packages:
  xxx = callPackage ... { package = package_version; };

After:
in package:
  { stdenv, package_version, package ? package_version }: ...

in all-packages:
  xxx = callPackage ... { };

I'm not even against making an RFC for this change, but I want to hear out some thoughts first.
Disclaimer: Yes, I want this because it greatly simplifies the proper implementation of #12877, but even if you don't want use-flags functionality in Nixpkgs I see no reason not to implement this particular change.

Re: re-importing: not sure if it would be better than mapping callPackage over the list in all-packages.nix — I guess some packages will still be in all-packages.nix till the next Nix language redesign, so it would be too fragile to be used.
Future plans of modularising Nixpkgs seems to be an argument in favour of doing version selection in-package. Treewide version pinning changes might become more complicated, though.
Unlike all-packages.nix, the list of trivial packages is almost sure to end up in a sorted state. all-packages.nix is quasi-sorted in an order that I fail to fully understand and that is also sometimes unintentionally violated and that is also sometimes intentionally violated. Not sure if we consider the current intentional violations of sorting order valuable.

Re: re-importing ...

Please elaborate, I don't understand what you are trying to convey in that paragraph. "mapping callPackage over the list in all-packages.nix" what list? all-packages.nix is not a list.

Treewide version pinning changes might become more complicated, though.

I don't see why, you can pin in all-packages.nix as before and then just grep around. If anything, it doesn't change much in that regard as many packages depend on particular versions already, so you have to grep anyway when you want to pin something.

quasi-sorted in an order that I fail to fully understand and that is also sometimes unintentionally violated and that is also sometimes intentionally violated

Oh, yes, that bugs me too.

re: re-importing:
I expect that all-packages.nix will stay in some form even if the current PR is adopted, so a full simplification won't happen.
I am not sure that the extra caching will be noticeable — I would expect that looking up any attribute name in the resulting attrset should end up with the same outcome as evaluation of the current all-packages.nix; the mapAttrs will need to be evaluated enough to have the list of names.
Re: pinning: replacing a single argument name in a package is a simpler operation that doing something about two related ones.

@edolstra

In short, it's confusing if some packages are in all-packages.nix and some aren't.

That's a fair point for the transition period, but it stops being an issue when all-packages.nix becomes "default version selector overlay" as noted above.

And if you need to override an argument, you now need to modify two files. Saving a few lines didn't really justify this.

No, you don't, you just override the default with a default value in the package expression itself, see above.

The effect of this is quite noticeable already (I still need to measure carefully, but I think it was about 10% in -qa time last time I checked), even before most of all-packages.nix is converted.

Is there an import that doesn't get accessed at all? Because I don't see how an access wouldn't create an attrset of thunks.

Is there an import that doesn't get accessed at all? Because I don't see how an access wouldn't create an attrset of thunks.

pkgs/top-level/default.nix, basically:
  allPackages = newArgs: import ./stage.nix ({
    inherit lib nixpkgsFun;
  } // newArgs);

  boot = import ../stdenv/booter.nix { inherit lib allPackages; };

in boot stages

pkgs/stdenv/booter.nix then evaluates allPackages a bunch of times to bootstrap stdenv, each eval of that imports stage.nix and then evaluates the result as a function on that ... // newArgs argument.
Here goes the important bit.
The body of the function defined in stage.nix imports all-packages.nix. Since allPackages gets evaluated multiple times, stage.nix function gets evaluated multiple times, which re-imports all-packages.nix multiple times (which is easy to check by adding a trace there).
But if you move that import of all-packages.nix from stage.nix to default.nix (kinda like I did with packageList) you will actually loose performance because nix will have to keep two copies of it in memory while applying arguments evaluating the package set: one for the initial cached version it can't GC because it's cached, and another one for the evaluation of the function all-packages.nix contains.
With packageList there's no such issue, it's not a function, it's an attrset of paths. And converting larger chunks of all-packages.nix to package-list.nix will produce larger difference in performance.
I do need to measure more stuff, though, like I have a feeling that adding some tactical deepSeq there might produce an even better result.

Are there any updates on this pull request, please?

a similar thing https://github.com/nixpkgs-architecture/simple-package-paths


Int b 19884 authenticate non cac user

B-19884
Summary
This pull request adds the functionality for the services counselor to designate whether a customer is a cac-user or not in the edit customer info form. This will help allow a customer to login to to MilMove their first time without needing to authenticate with a CAC.
This PR does the following:

Updated CustomerContactInfoForm to include the Cac Validation button
Added cacUser to body for sending to backend
Made tests for validating proper functionality of button in form.

Verification Steps for the Author
These are to be checked by the author.

[v] Tested in the local environment
[v] Have the Agility acceptance criteria been met for this change?

These are to be checked by a reviewer.

[ ] Has the branch been pulled in and checked out?
[ ] Have the BL acceptance criteria been met for this change?
[ ] Was the CircleCI build successful?
[ ] Has the code been reviewed from a standards and best practices point of view?

How to test

Run server and client and login as a services counselor
Search for a customer and choose one then head to the edit customer info form
select either yes or no on the form and submit and validate the value has been updated in the database.
On the client side create a new user, then on services counselor side find the user and update the cacuser value to either yes or no. If value updated to yes validate user has to sign in using cac, otherwise validate they o

Frontend

[ ] There are no aXe warnings for UI.
[ ] This works in Supported Browsers and their phone views (Chrome, Firefox, Edge).
[ ] There are no new console errors in the browser devtools.
[ ] There are no new console errors in the test output.
[ ] If this PR adds a new component to Storybook, it ensures the component is fully responsive, OR if it is intentionally not, a wrapping div using the officeApp class or custom min-width styling is used to hide any states the would not be visible to the user.
[ ] This change meets the standards for Section 508 compliance.

Backend

[ ] Code follows the guidelines for Logging.
[ ] The requirements listed in Querying the Database Safely have been satisfied.

Screenshots

@MichaelEngelbertCACI you need to close this PR or change the base branch. Right now you have it to where your INT branch is merging into main and you should have your main branch instead. Conflicts with your INT PR.


Add transaction name to span

We need to have the transaction name on spans if we want to display "transaction traces" using that data.
cc @alanwest

🙄 there's some third party license nonsense you gotta run


[Feature/add lift demo] Add hotel scenario

This is the demo scenario I have been working on as part of Google Summer of Code. The map is a reduced version and the full version can be accessed here. The full map consumes a huge amount of memory thus cannot run. This version is reduced so that the rmf_core can handle most requests. Though It still breaks when the request is long (especially for the MiR100 fleet)

It would be good to also update the README.md file with instructions to launch this world.

Thank you for the changes, I am able to launch the world now. Though there are still several minor issues, I guess I can quickly fix them after merging. Just to clarify, are all the doors and some lifts missing to reduce memory usage? Also, it would be great if you could add the link to the full version map in README.md so that people can still try if interested.

Yeah I removed the doors and most lifts to reduce the memory usage. I have also attached the link to the full hotel repo


injectResult retain cycle

With the following code...
class FetchContentMessageProcedure: GroupProcedure {

  init(_ ctx: MessageContext, summary: MessageSummary) {

    let resolveProc = ResolveRoutingProcedure(ctx, aliases: [summary.senderAlias])
    let processProc = ContentMessageProcessProcedure(ctx, summary: summary)
    processProc.injectResult(from: resolveProc)

    let ackProc = AcknowledgeMessageProcedure(ctx, messageId: summary.id, onOrBefore: summary.sent)
    ackProc.addDependency(processProc)

    super.init(operations: [resolveProc, processProc, ackProc])
  }

}

neither ResolveRoutingProcedure nor ContentMessageProcessProcedure are being released properly.
Replacing the injectResult line with the following (not suggesting it's a perfectly "correct" solution):
    processProc.addDependency(resolveProc)
    resolveProc.addCompletionBlock {
      processProc.input = .ready(resolveProc.output.success!)
    }

seems to solve the issue.

The offending block appears to be here...
https://github.com/ProcedureKit/ProcedureKit/blob/2bf45aac793c6cb035743d953fe1fbef392a5fc7/Sources/ProcedureKit/ProcedureResult.swift#L195
Adding a [weak self] to this block & appropriate strong capture when using self the procedures are released correctly.

Thanks @kdubb - yes, definitely a bug. Fixing it now.

@kdubb - can you try your code against the branch in #898?
I did write a unit test in an attempt to catch this error - but found it a little bit inconclusive. So will continue testing in my own projects.
I'm pretty sure the error is caused by the self which is passed into the block, this is a mistake, as it should use the procedure argument which it receives and is already weak.

Yep. Appears to work for me! Thanks!

Thanks @kdubb - will aim to merge this branch into development asap.

Closing this now, as the fix is merged.


Disable nto inplace test for kubevirt

In order to restore the ability for devs to merge into the hypershift repo, I am disabling this test until https://issues.redhat.com/browse/OCPBUGS-18566 is resolved.

/approve
/lgtm


[Feature] support KNN benchmark

Thanks for your contribution and we appreciate it a lot. The following instructions would make your pull request more healthy and more easily get feedback. If you do not understand some items, don't worry, just make the pull request and seek help from maintainers.
Motivation
Support KNN benchmark
Modification
Add KNN benchmark
Refactor extract_process.py and relevant files
BC-breaking (Optional)
Does the modification introduce changes that break the backward compatibility of the downstream repositories?
If so, please describe how it breaks the compatibility and how the downstream projects should modify their code to keep compatibility with this PR.
Use cases (Optional)
If this PR introduces a new feature, it is better to list some use cases here and update the documentation.
Checklist
Before PR:

[ ] Pre-commit or other linting tools are used to fix the potential lint issues.
[ ] Bug fixes are fully covered by unit tests, the case that causes the bug should be added in the unit tests.
[ ] The modification is covered by complete unit tests. If not, please add more unit test to ensure the correctness.
[ ] The documentation has been modified accordingly, like docstring or example tutorials.

After PR:

[ ] If the modification has potential influence on downstream or other related projects, this PR should be tested with those projects, like MMDet or MMSeg.
[ ] CLA has been signed and all committers have signed the CLA in this PR.

Besides, write the KNN usage tutorial in en/tutorials/6_benchmarks.md and zh_cn/tutorials/6_benchmarks.md.


[OCPCLOUD-1810]: Update tooling

This commit introduces modernization of the approach to update auxiliary tooling to be more consistent such as in Control Plane Machine Set repository. We align envtest, controller-gen and other tooling as well as in the CPMS repo.

Packages sigs.k8s.io/kustomize/api and sigs.k8s.io/kustomize/kyaml will need to be updated in a separate PR later.
sigs.k8s.io/kustomize/api has not yet been updated with a signature change between kyaml v0.13.9 and v0.13.10 so that needs to be updated before this can be resolved.

The tests are passing locally on my system. Really not sure why the tests aren't passing in CI.

It reached the ginkgo timeout (10m) on CI
Try and bump this to 20m or so.

It reached the ginkgo timeout (10m) on CI Try and bump this to 20m or so.

To be honest, I don't think this might help. I have no clue, whether something like this happens regularly, but locally, the test that is failing is successful in like 0.5s. That gives me vibes, that something else must be broken. Have you ever encountered such scenario before?

To be honest, I don't think this might help. I have no clue, whether something like this happens regularly, but locally, the test that is failing is successful in like 0.5s. That gives me vibes, that something else must be broken. Have you ever encountered such scenario before, @damdo?

The timeout is a global timeout, so it's not individual tests, but how long Ginkgo will run the entire suite. For many different reasons (lookup CPU CFS for one) the unit tests run much slower in CI than they do on our laptops, so it's common that we have to have what seems like a very long timeout for the units, just because of the limitations of CI.
I think Dam is right, let's get that value updated and it should resolve the issue

/approve

/retest-required

/retest-required

/retest e2e-aws

/retest-required


docs: Add badges

Fix: https://github.com/casdoor/casdoor-flutter-sdk/issues/5

:tada: This PR is included in version 1.0.0 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


Use rawgit.com for the demo to avoid showing an out of sync JSbin link

Don't know about the other contributors, but I never thought of updating the JSBin, and why should we when we can link directly to the latest version from master ?

This was my first attempt. But it only worked for the first version as rawgit will cache the files:
https://rawgit.com/faq#cdn-ttl

Looks like the caching lasts only for 300 seconds. So let's try this.

Yes, I've used rawgit for similar small projects and caching or performance has never been an issue.


Layout editor does not correctly apply layouts for 3rd screen

Microsoft PowerToys version
0.60.00
Running as admin

[ ] Yes

Area(s) with issue?
FancyZones
Steps to reproduce
Opening Layout Editor and applying a different template only for screen 3 result in the template being applied correctly.
Re-opening Layout Editor and selecting screen 3 results in a different template being shown as active the one that had previously been applied.
At any time, opening Layout Editor and applying templates for more than one screen results in the templates being applied correctly for screens 1 and 2, but a different template being applied to screen 3.
✔ Expected Behavior
The selected template should be applied to screen 3.
❌ Actual Behavior
Opening Layout Editor and applying a different template only for screen 3 result in the template being applied correctly.
Re-opening Layout Editor and selecting screen 3 results in a different template being shown as active the one that had previously been applied.
At any time, opening Layout Editor and applying templates for more than one screen results in the templates being applied correctly for screens 1 and 2, but a different template being applied to screen 3.
Other Software
No response

@jmessham
Can you please update to the last hotfix v0.60.1. This should be fixed there.

/needinfo

v0.60.1 fixed this issue for me. I have 2 identical 3840x2160 monitors and was having trouble using separate custom grids for each. Working fine now with this update, thanks.


Run profile stat updates concurrently

Changes proposed
For each profile view, we perform 4 separate stat updates.
Each of these performs a write to MongoDB.
We currently wait for each operation to complete before performing the next.
Running these operations concurrently instead of one after another will improve performance.
Because these operation are all writes & involve network connections, there is a delay.
Node does not allow running in parallel, but will perform work on another task while one is waiting for results.
Check List (Check all the applicable boxes)

[x] My code follows the code style of this project.
[ ] My change requires changes to the documentation.
[ ] I have updated the documentation accordingly.
[x] All new and existing tests passed.
[x] This PR does not contain plagiarized content.
[x] The title of my pull request is a short description of the requested changes.

Sorry the path got renamed in another PR from users to profiles which caused a conflict


Fix potential race condition

Prior to this PR, there was a possible race condition that could be hit by two execution paths where,

path 1 calls Server::drop_stream which is a yielding call
path 2 call Server:m_connections->drop_all_streams();

Server::drop_stream locks the server's state, but Server::m_connections is not protected by that mutex.
Relates to #247

Note, this will pass CI, because CI is still skipping test_mrc_private.x.

We could also convert the Server's
mutable boost::fibers::mutex m_mutex;

to a
mutable boost::fibers::recursive_mutex m_mutex;

@gpucibot merge


Prefetching queries in multi-language sites

Describe the feature
The prefetching is great! Maybe I am overseeing it, but it would be great to prefetch content in different (or rather all available) languages. If this is already possible, it would be great to add something to the existing docs.
Additional information

[ ] Would you be willing to help implement this feature?
[ ] Can you think of other implementations of this feature?

Final checks

[X] Check existing issues.

Great feature request! What do you think about the following syntax?
// `nuxt.config.ts`
export default defineNuxtConfig({
  modules: ['nuxt-kql'],

  kql: {
    prefetch: {
      site: {
        // Define a query and its language
        query: {
          query: 'site',
          select: ['title']
        },
        language: 'de'
      }
    }
  }
})


Voicecall record is getting created along with salesforce case record during Voicemail creation

Hi @dougjaso,
In Previous Versions, It is only creating sf case record with origin as "VOICEMAIL" but
In current version,

Sf case record is getting created with origin as "PHONE" and voicecall record is also getting created
We can't see any differences for this voicecall record and the record which is created when agents attends the customer call
And the sf case record (created during voicemail) is not connected to the voicecall.

Hi @dougjaso
Could you please tell us if any one of the below is possible-

when a voicemail creates VoiceCall Record, the Call type for that voiceCall record should be "Voicemail" . I see that the 'Call Type' Picklist field already have a value as "Voicemail". But its not picking that value.

How do we stop creating VoiceCall Record for Voicemails.

Kindly provide steps to achieve any one of these.
Thanks in Advance!

Hi @dougjaso
While exploring the code in CTRDataSyncFunction lambda function, we found that there is a vm_flag is called. Changed that vm_flag to vmx_flag. Now it is not creating voicecall for voicemail.
Thanks

Salesforce now includes voicemail, based on this solution, with SCV. You are now running two versions of voicemail. For long term support purposes, you should migrate to the Salesforce provided version:
https://developer.salesforce.com/docs/atlas.en-us.voice_developer_guide.meta/voice_developer_guide/voice_example_voicemail.htm

Jason Douglas
Principal Solutions Architect
Amazon Connect
704.807.6561 – mobile
415.262.9741 – office
[signature_2001959500]http://www.aws.amazon.com/
Thoughts on our interaction? Provide feedback herehttps://feedback.aws.amazon.com/?ea=dougjaso&fn=Jason&ln=Douglas.
From: Sureka A R K @.>
Reply-To: amazon-connect/amazon-connect-salesforce-scv @.>
Date: Monday, August 5, 2024 at 2:20 AM
To: amazon-connect/amazon-connect-salesforce-scv @.>
Cc: "Douglas, Jason" @.>, Mention @.***>
Subject: [amazon-connect/amazon-connect-salesforce-scv] Voicecall record is getting created along with salesforce case record during Voicemail creation (Issue #174)
Hi @dougjasohttps://github.com/dougjaso,
In Previous Versions, It is only creating sf case record with origin as "VOICEMAIL" but
In current version,

Sf case record is getting created with origin as "PHONE" and voicecall record is also getting created
We can't see any differences for this voicecall record and the record which is created when agents attends the customer call
And the sf case record (created during voicemail) is not connected to the voicecall.

—
Reply to this email directly, view it on GitHubhttps://github.com/amazon-connect/amazon-connect-salesforce-scv/issues/174, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AJRHYXW4NRXYCLO62MQMZODZP47WTAVCNFSM6AAAAABL74SFHOVHI2DSMVQWIX3LMV43ASLTON2WKOZSGQ2DQMBVGAYTGOA.
You are receiving this because you were mentioned.Message ID: @.***>

This repository does not provide a voicemail application that creates VoiceCall objects, only the native voicemail option included with Service Cloud Voice does that. If you do not wish to use the Salesforce-provided version, simply remove the trigger for the Salesforce Lambdas. More info can be found here: https://github.com/amazon-connect/amazon-connect-salesforce-scv/issues/165

Jason Douglas
Principal Solutions Architect
Amazon Connect
704.807.6561 – mobile
415.262.9741 – office
[signature_2001959500]http://www.aws.amazon.com/
Thoughts on our interaction? Provide feedback herehttps://feedback.aws.amazon.com/?ea=dougjaso&fn=Jason&ln=Douglas.
From: Manvitha K @.>
Reply-To: amazon-connect/amazon-connect-salesforce-scv @.>
Date: Tuesday, August 6, 2024 at 7:46 PM
To: amazon-connect/amazon-connect-salesforce-scv @.>
Cc: "Douglas, Jason" @.>, Mention @.***>
Subject: Re: [amazon-connect/amazon-connect-salesforce-scv] Voicecall record is getting created along with salesforce case record during Voicemail creation (Issue #174)
Hi @dougjasohttps://github.com/dougjaso
Could you please tell us if any one of the below is possible-

when a voicemail creates VoiceCall Record, the Call type for that voiceCall record should be "Voicemail" . I see that the 'Call Type' Picklist field already have a value as "Voicemail". But its not picking that value.
How do we stop creating VoiceCall Record for Voicemails.

Kindly provide steps to achieve any one of these.
Thanks in Advance!
—
Reply to this email directly, view it on GitHubhttps://github.com/amazon-connect/amazon-connect-salesforce-scv/issues/174#issuecomment-2272512891, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AJRHYXUYAO7SR2AEJKOB66DZQGC73AVCNFSM6AAAAABL74SFHOVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDENZSGUYTEOBZGE.
You are receiving this because you were mentioned.Message ID: @.***>


Please verify and consider a major version change for the angular 8 updates and schematics

1.6.0 breaks angular 7.x. cli production builds.
I get, when trying to start my angular 7 app with angular-apollo 1.6.0
angular production build must call super constructor before using |this| in anonymous class constructor

works with angular-apollo 1.5.0
Maybe you can check that. If this is a valid issue then the schematics and angular upgrade has breaking changes and it should be a major version change.

also Package "apollo-angular" has an incompatible peer dependency to "zone.js" (requires "~0.8.20", would install "0.9.1"). Incompatible peer dependencies found. See above

Temporary solution for this might be set
"buildOptimizer": false
for now, but still waiting for fix

yeah but this is not really a workaround, because you are losing the build optimization, without that it is not really a "production" build. Especially for bigger apps the result is not suitable ;)

yeah, or use 1.5.0 as you mentioned before.

Closing in favor of #1226


Partially revert AccountAPI change

As per https://github.com/verida/vault-mobile/issues/394#issuecomment-1080334156 the Account API should be reverted to this:
const account = new VaultAccount({
  request: {
    logoUrl: "https://assets.verida.io/verida_login_request_logo_170x170.png", # or whatever
  }
});

Please add your planning poker estimate with ZenHub @cmcWebCode40


How to specify volume mount?

How would I mount the local directory as a volume? I would like to run this command using the GH action, but I see no option to mount volumes.
docker run --rm -v "$(pwd):/app" slashmo/swiftformat

@fatso83 Try this:
options: --rm -v ${{ github.workspace }}:/zap/wrk/:rw

In your case it would be: docker run --rm -v "${{ github.workspace }}:/app" slashmo/swiftformat
I found this via:

https://github.com/addnab/docker-run-action/commit/6f0804dd49caf60dff3f446626c5918c65c9efa7 (readme)
https://github.com/addnab/docker-run-action/issues/5
https://github.com/addnab/docker-run-action/issues/4

Perfect! Great to see it is mentioned, but it would be even better with an explicit text. Easy to miss a small -v in a wall of text 😄

Added a PR for this btw. Still waiting six weeks in


Replace chart.min.js by chart.umd.js

There is no chart.min.js file when you npm install chart.js. I supposed it has been replaced by chart.umd.js as indicated in the Chart.js integration documentation.

But there is no chart.umd.min.js available with npm install chart.js.

Ok, accessing to CDN by script tag, you can use also umd.min. But that's ok.

Thanks @JimmyGouraud


Change of behavior between 0.18 and 0.19

I've been using your crate for one of my demos, so first, thanks a lot.
The idea is to receive an HTTP request with the traceparent HTTP header, start a span, make HTTP calls to other services, and see all of them in Jaeger.
I've noticed a change in behavior between 0.18 and 0.19. With 0.18, I see all spans - the one from the receiving call and the ones from the sending calls. With 0.19, I se nothing. On my side, the code is exactly the same:
#[tokio::main]
async fn main() {
    // Initialize OTEL
    init_tracing_opentelemetry::tracing_subscriber_ext::init_subscribers().unwrap();

    let reqwest_client = Client::builder().build().unwrap();
    let client = ClientBuilder::new(reqwest_client)
        // Insert the tracing middleware
        .with(TracingMiddleware::default())
        .build();

    let app_state = AppState {
        warehouse_env_vars: get_warehouse_env_vars(),
        client,
    };

    // Routing
    let app = axum::Router::new()
        .route("/stocks/:product_id", get(get_stock_by_product_id))
        .with_state(app_state)
        .layer(OtelInResponseLayer::default())
        .layer(OtelAxumLayer::default());

    let listener = TcpListener::bind("<IP_ADDRESS>:3000").await.unwrap();

    // Start the server
    axum::serve(listener, app.into_make_service())
        .with_graceful_shutdown(otel::shutdown_signal())
        .await
        .unwrap();
}

v0.18 result:

v0.19 (and higher) result:

I've checked the changes between the two versions in the changelog but I didn't see anything related (my Rust skills are pretty low, though).
PS: the project is on GitHub but it's pretty involved.

With 0.19, you should have a warning at compile time, because you should at least manage the output of init_tracing_opentelemetry::tracing_subscriber_ext::init_subscribers().unwrap();
The output is to keep a reference to the opentelemetry provider, and provide a better handling of shutdown,... it's also due to change in the opentelemetry library.
Has a quickfix you can just change the line to:
let _guard = init_tracing_opentelemetry::tracing_subscriber_ext::init_subscribers().unwrap();

Then the _guard (and the configured opentelemetry provider) will be dropped at end of the main, and not at end of the call.

I just noticed that you used an old version of our crate/library that mismatch the version of opentelemetry that you declare in Cargo.toml, resulting by having 2 versions of opentelemetry (rust is not java, you could have several version of same library). The issue is that opentelemetry use some "static" field (~ one instance per version) => 1/2 opentelemetry is configured.
See Troubleshot why no trace?
For opentelemetry "0.27", use our crates in 0.24 (IIRC)

Thanks for your feedback @davidB
Indeed, the issue was because of the duplicate dependencies. When I aligned the version brought by reqwest_tracing and the one brought by your lib, everything worked.
Sorry about the bother!


Im not sure if this is a bug or not.

Describe the bug
Hi, to make it short when i change the scene and go to the next and die it never reloads the current scene. I have a state machine and when im in Die-State after the animation is played it should reload the current scene and when the scene starts from the beginning i go to Spawn-State but it never happens.
To Reproduce
State Machine GD-Quest
Expected behavior
True - get_tree().reload_current_scene()
Screenshots
Video Bellow
Desktop (please complete the following information):

OS: Windows 10

Additional context
I tried in the Die-State ( SceneManager.reload_scene() ) but same results. If i go (get_tree().change_scene_to_file()) so no SceneManager to change the scene it works as intended.
https://github.com/glass-brick/Scene-Manager/assets/105984870/67da1f1e-beee-4fe3-a676-907eb3e3d9a1

Hello @Galllaa , do I understand correctly that, if you replace SceneManager.reload_scene() for get_tree().reload_current_scene(), everything works as intended? If so, that does sound like it might be an issue on our side, unfortunately I don't have enough information to reproduce this as-is. Do you have a link to the project you're using, that I could clone and test directly? Or could you create a minimal project where this is reproducible?

Link to replicate the issue : https://www.mediafire.com/folder/k3ajypk45iyu5/SceneChangeTest if you want i can upload it to another site just let me know, is there a discord maybe it would be easier to communicate then over here.

We don't have a discord unfortunately, I will try to check this out this week though

Actually checking the link, it looks like I need MediaFire Premium to download files in bulk, could you upload a zipped folder or use a different service?

Yea shoud zip it before my bad. Here is the zipped project https://www.mediafire.com/file/z6pca5pz4j6rdtg/SceneChangeTest.rar/file
Tnx for taking time.

Any news for this?

I had something similar happen recently. Do you get any errors when calling the reload_scene function that the scene file could not be found? I solved it by using a PackedScene.

I don't know if this plugin is still being worked on, but I'm encountering this exact same issue

It seems to be a problem with how the Change scene works. If I use the reload scene without changing scenes first, it works as expected. But changing the scene, then trying to reload the current scene causes the "Resource file not found: res:// (expected type: )" error
<C++ Error>    Condition "!file_check->file_exists(p_path)" is true. Returning: Ref()
<C++ Source>   core/io/resource_loader.cpp:279 @ _load()

The way I got around this was to simply use change_scene on the current scene's path

I believe this issue is still happening. It only seems to occur on scenes that have been loaded with the scene managers change scene function. This is what I found:

If I use SceneManager.change_scene() and then the scene it loads uses SceneManager.reload_scene() at any point during that scene, the transition will play but then the scene will continue as if nothing happened. (No errors either)

If I use SceneManager.change_scene() and then the scene it loads uses 'get_tree().reload_current_scene()` at any point during that scene, nothing happens (No errors either)

If I use get_tree().change_scene_to_file() and then the following scene uses SceneManager.reload_scene()`, this will work as intended.

My personal workaround is instead of using SceneManager.change_scene() , I used the SceneManager.fade_out() function, then get_tree().change_scene_to_file() and then called SceneManager.fade_in() on the new scene. This then meant the SceneManager.reload_scene() was working correctly. It's a couple of extra steps but it works exactly how I expected the normal method to.


Use relative imports for ESPHome

Description:
Use relative imports for ESPHome, this makes it easier to use as a custom component.
Related issue (if applicable): fixes #
Pull request in home-assistant.io with documentation (if applicable): home-assistant/home-assistant.io#<home-assistant.io PR number goes here>
Example entry for configuration.yaml (if applicable):

Checklist:

[ ] The code change is tested and works locally.
[ ] Local tests pass with tox. Your PR cannot be merged unless tests pass
[ ] There is no commented out code in this PR.

If user exposed functionality or configuration variables are added/changed:

[ ] Documentation added/updated in home-assistant.io

If the code communicates with devices, web services, or third-party tools:

[ ] New dependencies have been added to the REQUIREMENTS variable (example).
[ ] New dependencies are only imported inside functions that use them (example).
[ ] New or updated dependencies have been added to requirements_all.txt by running script/gen_requirements_all.py.
[ ] New files were added to .coveragerc.

If the code does not interact with devices:

[ ] Tests have been added to verify that the new code works.

Someone did them all at once 💃  #22235


GLRM | Invalid field: loss_by_col

should it be loss_by_col_idx?

this issue appears in drift master branch, so was not introduced by the refactor-model-input-branch

this issue appears in h2o-flow, so it was not introduced by drift


Predict_Single Script warning message

 SourceChangeWarning: source code of class '__main__.EnsembleClassifier' has changed. you can retrieve the original source code by accessing the object's source attribute or set `torch.nn.Module.dump_patches = True` and use the patch tool to revert the changes.
  warnings.warn(msg, SourceChangeWarning)

can we add a parameter inside pytorch to disable warning?


Fix some issues of Psalm in level 6

Q
A

Type
improvement

BC Break
no

Fixed issues

Summary

Right now we are using level 7 of psalm, I raised it locally to level 6 and this PR fixes some of the issues that I think they are easy to review and only in tests directory.
The first commits are not SA related, just some polishing.
For the remaning ones I'll open another PR.

Thanks @franmomu!


bpf: improve metadata initialization

Improve the robustness of the skb->cb clearing in from-netdev / from-host. Also sort out the custom hs-ipcache path into from-overlay, until https://github.com/cilium/cilium/issues/29762 is sorted.

/test

Is this fixing a bug? I don't understand why this meets the backport criteria for v1.14.


Fix LoginActivity page

This looks like it might have regressed with the lodash upgrade in https://github.com/studentinsights/studentinsights/pull/1964:

Fixed by https://github.com/studentinsights/studentinsights/pull/2063


tesseract51.dll

Hello,
unfortunately, trying to add your library does not work for me. The correct qpdf29.dll's are copied but named wrong. Therefore the library does not find the DLL when starting. Attached is a screenshot from my IDE as well as from the current Nuget package.

Sorry I will make a new package, for some reason I mixed up a build tempalte.

This issue should be fixed now.


[Federation] Add reference docs for kubefed

Addresses https://github.com/kubernetes/kubernetes.github.io/issues/2888
@kubernetes/sig-federation-misc @madhusudancs
cc @csbell

This change is

@irfanurrehman content looks good. A minor nit and a couple of comments about the URL structure. We need @devin-donnelly's suggestions to fix them though. Thank you so very much for creating these docs!

Reviewed 8 of 8 files at r1.
Review status: all files reviewed at latest revision, 4 unresolved discussions.

_data/guides.yml, line 207 at r1 (raw file):

- title: Administering Federation
  section:
  - docs/tutorials/federation/set-up-cluster-federation-kubefed.md

We want the old URL to be around. We don't want to break links on the Internet.

_data/reference.yml, line 146 at r1 (raw file):

      - docs/user-guide/kubectl/kubectl_stop.md

- title: Kubeadm - Administrate Federations

Just call this kubefed CLI or kubefed commands

docs/admin/federation/kubefed.md, line 1 at r1 (raw file):

---

I am not entirely sure if we want the reference documentation at this URL.
@devin-donnelly this is a command reference. What's your URL location recommendation for these reference docs?

docs/admin/federation/kubefed_options.md, line 2 at r1 (raw file):

---
title: Kubefed options

I did not know we had kubefed options! TIL!
Auto-generated command I guess?

Comments from Reviewable

/assign @madhusudancs

Review status: all files reviewed at latest revision, 4 unresolved discussions.

Comments from Reviewable

/assign @devin-donnelly

@irfanurrehman Did you manually generate these docs in core repo and copy them here?
We have a script for copying autogenerated docs from core repo to here: https://github.com/kubernetes/kubernetes.github.io/blob/master/update-imported-docs.sh
hack/update-generated-docs.sh should generates autogenerated docs in core and then that script copies them to this repo (We should have better documentation for the process, if there isnt already).

@irfanurrehman , @madhusudancs , reference documentation should go under the docs/api-reference directory.
Is this generated documentation that got copy-pasted?

@devin-donnelly apologies for a late response. I think you mistook this for an api reference. Kubefed is an admin command used to deploy federation control plane and manage federations.
kubeadm is the exact parallel of this command, but I could not find the command reference for the same in the docs repo (may be the kubeadm dev team hasnt built the command reference yet).
kebefed is very similar to kubectl too, but kubectl is an user facing (not an admin alone) command/tool. That is why I think docs/user-guide is probably not a right place for kubefed command reference.
Also, yes this is an auto generated reference (with minor manual changes, for example title, owner, etc), and manually copied to this place. As per @nikhiljindal's comment above I did check https://github.com/kubernetes/kubernetes.github.io/blob/master/update-imported-docs.sh, but I think it will need additional logic to copy the kubefed auto generated doc to the appropriate place (similar to the way kubectl command reference is handled). If that is the correct approach, I would rather raise a PR updating that and close this one.
Please educate me.. :-)

Review status: 6 of 8 files reviewed at latest revision, 4 unresolved discussions.

_data/guides.yml, line 207 at r1 (raw file):
Previously, madhusudancs (Madhusudan.C.S) wrote…
We want the old URL to be around. We don't want to break links on the Internet.

I am sort of sure, this change would not break any links. The old url would open up  a redirection page (is currently active at https://kubernetes.io/docs/admin/federation/kubefed/), with the link to the set-up-cluster-federation-kubefed.
Without this change, the link at the line above and the tools page kubefed link  (https://kubernetes.io/docs/tools/) both pointed to the redirection page.
With this change the tools page (https://kubernetes.io/docs/tools/) kubefed link will reach the command help (just like kubectl) (which I think its supposed to show, rather then the redirection link which reaches set-up-cluster-federation-kubefed) and the "Administering federation" link will directly go to the correct page rather then via a redirection.

_data/reference.yml, line 146 at r1 (raw file):
Previously, madhusudancs (Madhusudan.C.S) wrote…
Just call this kubefed CLI or kubefed commands

Done.

docs/admin/federation/kubefed_options.md, line 2 at r1 (raw file):
Previously, madhusudancs (Madhusudan.C.S) wrote…
I did not know we had kubefed options! TIL!
Auto-generated command I guess?

yes

Comments from Reviewable

@devin-donnelly any suggestions ??
thanks!

@madhusudancs @nikhiljindal Sorry I'm only looking at this now. Did you guys give this a Tech LGTM?

@chenopis, I raised some questions in the last comment. I need some suggestions on those queries to take it forward!

@irfanurrehman Ok, no problem. Just ping me when it's ready to be merged.

I think updating https://github.com/kubernetes/kubernetes.github.io/blob/master/update-imported-docs.sh to move kubefed docs as well (as it does for federation api reference docs) is the right thing to do. That way, every new branch will get updated docs.
Update the script and then run it to generate these docs.
You will still need manual changes to the navigation menu from this PR.

I agree with @nikhiljindal since we import these into kubernetes/kubernetes.github.io. @irfanurrehman can you make the changes he suggested?

I agree with @nikhiljindal since we import these into kubernetes/kubernetes.github.io. @irfanurrehman can you make the changes he suggested?

@chenopis updated this. Am not sure if I need to add the generated md files here for the first time?
@madhusudancs @nikhiljindal, can u please verify that the placeholders for the files are ok?
I have updated https://github.com/kubernetes/kubernetes/pull/43443 also accordingly.

@irfanurrehman I don't see that the kubefed docs are being pulled in. Can you verify that before I merge this?

@irfanurrehman I don't see that the kubefed docs are being pulled in. Can you verify that before I merge this?

@chenopis thanks for the updates! The docs generation PR is still open, I have requested merge for it. I will update you as soon as that happens.

@irfanurrehman Ok, great. Thx!

@chenopis, Thanks for helping me on this and fixing the issues, as well.
I have rebased this on latest as the changes were out of syn with master. Please let me know if anything further is needed.

Deploy preview ready!
Built with commit 2db7e161a1b8060d5848219463c64b14f8092481
https://deploy-preview-2937--kubernetes-io-master-staging.netlify.com

@irfanurrehman I think I need to kickoff the autogeneration for the kubefed docs and then push them into the kubernetes.github.io repo. Let me ask @pwittrock

thanks @chenopis, that is what I actually asked here earlier.
I know how to autogenerate those docs and which doc fits which title (Infact, I did add them here as part of original PR). If its ok, I can autogenerate and add those docs also to this PR.
Also, I did not completely get what is the new commit (2db7e16) which you did add for the netlify preview. Isn't rebasing this on latest master sufficient?

@irfanurrehman Sorry, I was mistaken about how the process is supposed to work. :( Yes, you will need to include those docs in this PR. Sorry again for the confusion.
The "Deploy preview ready!" comment is actually a bot I'm testing out that displays the preview build link in a comment after a commit instead of burying it in the checks sections. It seems that most people don't know that the preview exists, so I'm trying to make it more obvious.

@chenopis no problems, and thanks again for helping me on this PR. I have updated the auto-generated docs also.

@chenopis verify-docs-format.sh seems to be failing with <file> doesn't have a proper title defined for the newly added files. The auto-generation tools dont add titles.
However the same is true for other similar reference files for example kube-apiserver or federation-apiserver. Some script in the process of copying these files into their target path seems to be adding title lines (or its manually done when those files are copied). For example
---
title: federation-apiserver
notitle: true
---

for federation-apiserver.
update-imported-docs.sh seems to add the lines ---, but not sure which script is adding the title lines.
If you can verify and confirm how is this getting done, I can update a commit for that too. On the other hand we can skip this check for these files too, as they anyways are auto-generated. Let me know which might be the more suitable option.
Thanks again for all your help.

On second thoughts did add those files to skip_title_check.txt

@chenopis rebased this again (conflict). Please let me know if anything else is needed!


POSSIBLY THE MOST IMPORTANT CHECKIN IN THE HISTORY OF BUNKER!

THIS SHOULD BE MERGED SOMEWHAT IMMEDIATELY!


Support cascade join

Add learned join cascade code from research experiments
Add join cascade example

Expected output of the join_cascade.py example:
Joined 4 rows from df1 with 98 rows from df2
    Join cascade took 53 LM calls
    Helper resolved 339 LM calls
Join cascade used 135 LM calls in total
Naive join would require 392 LM calls
                              Course Name                 Skill
0  Digital Design and Integrated Circuits        Circuit Design
0  Digital Design and Integrated Circuits  Hardware Engineering
0  Digital Design and Integrated Circuits           Electronics
0  Digital Design and Integrated Circuits      Computer Science
3             Natural Language Processing      Machine Learning
3             Natural Language Processing      Computer Science
1          Data Structures and Algorithms      Computer Science
1          Data Structures and Algorithms       Problem Solving
1          Data Structures and Algorithms           Programming
1          Data Structures and Algorithms  Software Development
1          Data Structures and Algorithms       Decision Making
2                      The History of Art     Critical Thinking
2                      The History of Art              Painting


Piece wise readerwriter units

Added default units to all the file readers and writers, as well as default units for csg.

@JensWehner this pull request does very little at the moment. I have added the default units of each of the file readers and writers, in coming pull requests I will be using the default units given in this pull request to convert between them using the unitconverter class in tools. That way you can read a pdb file in its default units and automatically convert it to a gromacs file in its default units.


Log git info

This change is

Reviewed 1 of 1 files at r1.
Review status: all files reviewed at latest revision, 1 unresolved discussion.

op_robot_tests/tests_files/keywords.robot, line 36 [r1] (raw file):
цікаво додати це

Comments from the review on Reviewable.io

Reviewed 1 of 1 files at r2.
Review status: all files reviewed at latest revision, all discussions resolved.

Comments from the review on Reviewable.io


393 Schnittstelle Details and Edit

Pull Request
Description
Reference
Issues: https://jira.muenchen.de/browse/MDAS-393
Definition of Done
Advice: Unchecked checkboxes are not accepted by the build pipeline. Cross out any non-relevant item by using '~~'.


Path to a published release

This issue is tracking the remaining tasks before we have an official release.

[x] Transfer repo to @romejs org

This will hopefully be done by the end of the work. There's some additional things to work out.

[ ] Rework website

I'm handling this one. I want a mostly single-page website for 90% of people. Not single page as in SPA, single page as in a single page to scroll through.
Taking inspiration from classic projects such as coffeescript.org, backbonejs.org, and underscorejs.org.
I find the current structure of most open source projects to be extremely confusing. Someone should be able to spend 20 minutes reading through the Rome documentation and have a good grasp on how to use almost all of it (we'll see).

[ ] Add more tests

Tests are lacking in many areas. Notably @romejs/core.

[x] Automated releases

After the initial release I want to be able to push new release really quickly. I am fine doing multiple releases a day. Patch and minor versions are cheap.
This means we need to invest in tooling to quickly publish releases. It should be semi-automated, just running a command or pushing to a branch should trigger a release.

I don't think it makes sense to have blockers on pending features or missing lint rules.

Do we have any target on what the publish version should be capable of doing?

Everything it does now. There's no other launch blockers besides a new website and additional tests.

I want a mostly single-page website for 90% of people. Not single page as in SPA, single page as in a single page to scroll through.

I made a documentation tool for this: docup.now.sh, would love some feedback from you 🤔

I'm handling this one. I want a mostly single-page website for 90% of people. Not single page as in SPA, single page as in a single page to scroll through.
Taking inspiration from classic projects such as coffeescript.org, backbonejs.org, and underscorejs.org.
I find the current structure of most open source projects to be extremely confusing. Someone should be able to spend 20 minutes reading through the Rome documentation and have a good grasp on how to use almost all of it (we'll see).

Just a thought about clear docs.  It's hard to express how much I value the versioned docs I've seen in the elixir community (linked below for reference), and the impact that that has had on the community's ability to be welcoming to newcomers.  If it's something you're up for, I'd love to help make it happen.
https://hexdocs.pm/elixir/1.10.1/Kernel.html

I'd like to help with adding tests

We now have a publishing process. The only thing remaining for a release is an improved website. I've opened #496 to track. Tests would be really nice but aren't a blocker for an alpha/beta release. If anyone is interested feel free to go through the folders in packages/@romejs and find a package that looks interesting and write some unit tests. You can find *.test.ts files elsewhere as a reference.

Going to close this since #14 is the only actual blocker.


If with command --listen, plug-in will show error

I'm running WebUI from my server, so I turned the local IP access link on. In webui-user.bat I set
set COMMANDLINE_ARGS= --listen
After I open the local IP in another computer, after every setting set up then hit Generate, It will show error
FileNotFoundErrir: [Eeeno 2] No such file or directory: 'E:\\stable-difusion\\extensions/enhanced-img2img/scripts/util.py'
On the computer I use locally, Stable Diffusion is not installed in the E:\ drive. But in my server, I put my stable diffusion in the E:\ drive. So the folder information it reads is from the E drive of the server, but for some reason it wants to read the information from the E drive of my local computer.

Fix #14


Update network-file-system-protocol-support-how-to.md

If the account is not enabled for NFS3.0 then also the error `No such file or directory' can appear. This was observed on sample repro hence proposing the changes for review

@ktoliver : Thanks for your contribution! The author(s) have been notified to review your proposed change.


tools/distrib/python/check_grpcio_tools.py

https://sponge.corp.google.com/target?id=da3d57a5-8611-4d52-bf57-2f9d84460c50&target=github/grpc/sanity_linux_dbg_native&searchFor=&show=FAILED&sortBy=STATUS
Failure
Extracting Bazel installation...
...........................................
____Loading package:
____Loading package: @bazel_tools//tools/genrule
____Loading package: tools/defaults
____Loading package: @local_config_cc//
ERROR: /var/local/git/grpc/third_party/protobuf/BUILD:283:1: in cc_library rule //:protoc_lib: cycle in dependency graph:
.-> //:protoc_lib
|   //:protobuf
|   //:src/google/protobuf/unittest_custom_options.pb.h
|   //:cc_test_protos_genproto
|   //:protoc
`-- //:protoc_lib.
ERROR: Loading of target '//:protoc_lib' failed; build aborted.
ERROR: Evaluation of query "deps(//:protoc_lib)" failed due to BUILD file errors.
Traceback (most recent call last):
  File "tools/distrib/python/check_grpcio_tools.py", line 25, in <module>
    check_protoc_lib_deps_content = make.get_deps()
  File "/var/local/git/grpc/tools/distrib/python/make_grpcio_tools.py", line 89, in get_deps
    cc_files_output = bazel_query(BAZEL_DEPS_PROTOC_LIB_QUERY)
  File "/var/local/git/grpc/tools/distrib/python/make_grpcio_tools.py", line 83, in bazel_query
    output = subprocess.check_output([BAZEL_DEPS, query])
  File "/usr/lib/python2.7/subprocess.py", line 573, in check_output
    raise CalledProcessError(retcode, cmd, output=output)
subprocess.CalledProcessError: Command '['/var/local/git/grpc/tools/distrib/python/bazel_deps.sh', '//:protoc_lib']' returned non-zero exit status 7

@mehrdada, can you take a look?

@jtattermusch will do. there's another failure caused by an upgrade to Python protobuf package that we are waiting for them to fix, FYI.

Seems like this is the same issue as this old one: https://github.com/grpc/grpc/issues/9677

Should be fixed now. Please ping the issue if you see it again.


Add image prop to wizard

This adds an image prop to the ProvisioningWizard component
This prop is an object with a shape of { name: string, ami: string }
The ami already exists in the image-builder front application, so it seems redundant to fetch it later in our backend by the image identifier. The image's name prop propagates to the review page, so the user is notified just before the reservation is made.
    <ProvisioningWizard
       isOpen={isWizardOpen}
       onClose={onCloseFn}
       image={{ name: 'example-image', ami: 'ami-0c830793775595d4b' }}
    />

[ ] Testing

we can also propagates an image id for fetching unknown attributes later on 🤔

This is what the image status endpoint returns from image-builder API:
{
"image_status": {
  "status": "success",
  "upload_status": {
    "status": "success",
    "type": "aws",
    "options": {
        "ami": "ami-0c830793775595d4b",
        "region": "eu-west-1"
     }
  },
"error": {}
}

Looks a bit redundant to me to do an async request just for the AMI while it is already available to our consumers.
BTW, there's a nice online redoc tool for visualizing image-builder API - https://redocly.github.io/redoc/?url=https://raw.githubusercontent.com/osbuild/image-builder/main/internal/v1/api.yaml :)

After offline discussion, I've created image builder client which can be extended for future multi-cloud usage
https://github.com/RHEnVision/provisioning-backend/pull/116
the consumer should add image object (name and and id):
    <ProvisioningWizard
       isOpen={isWizardOpen}
       onClose={onCloseFn}
       image={{ name: 'example-image', id: 'compose-id' }}
    />

The server will verify and pull its ami info

@amirfefer can we have the rebase pls? :(

rebased, btw we have now a provisioning namespace in stage :)
The wizard testing will be part of https://github.com/RHEnVision/provisioning-frontend/pull/47


Revert "Add script for OCPBUGS-33377 workaround"

This reverts commit b9cbcc231120138abb590ffce61e6e44c6ff79d3.
What type of PR is this?
cleanup as OCPBUGS-33377 is fixed
What this PR does / Why we need it?
Which Jira/Github issue(s) does this PR fix?
Resolves #
Special notes for your reviewer
Pre-checks (if applicable)

[ ] Validated the changes in a cluster
[ ] Included documentation changes with PR

/lgtm
/approve


Add support for coloring op coverage table elements

This was implemented in JavaScript as opposed to CSS because it isn't possible to give the td elements generated by markdown classes using inline HTML. To get a similar effect without hand generating the table HTML, I put spans around the success and failure symbols with success-table-element and failure-table-element classes respectively. (This is implemented in #2020).
This allows for the td elements that need to be styled to be selected conditioned on their containing a success or failure element. CSS doesn't allow for parents to be selected conditionally in this way from their children however, so this had to be implemented in JavaScript.
Directly styling the {success/failure}-table-elements themselves doesn't work because theme has padding on the td elements, making any attempts to do so quite ugly.

This is going to the gh-pages branch, so no ready to pull label. I'll merge on GitHub.

Oh wow, this looks pretty! :) Thanks @phoenix-meadowlark !


[docs] Improve API for theme default prop

I initially only wanted to remove logic related to a given open-source project from the ApiPage so we can keep it more generic, e.g.
https://github.com/mui/material-ui/blob/f71821eb13b6dddcf3e59946169e359a4222b579/docs/src/modules/components/ApiPage.js#L303
but then went a bit above to differentiate default prop customization to style customization. These are implemented differently now, especially with the data grid.
Before:

https://mui.com/material-ui/api/card/#component-name
https://mui.com/joy-ui/api/card/#component-name

After:

https://deploy-preview-36490--material-ui.netlify.app/material-ui/api/card/#component-name
https://deploy-preview-36490--material-ui.netlify.app/joy-ui/api/card/#component-name

Follow-up thoughts:

root should always be at the top: https://deploy-preview-36490--material-ui.netlify.app/joy-ui/api/button/#slots. But this seems to really surface something deeper: the type order isn't translated to the docs.
JoyButton is a bit strange to customize the default when the class name is MuiButton. IMHO, the correct way to handle this here is to isolate the emotion context between Joy UI and Material UI & use MuiButton.
We miss the docs for the component prop in https://deploy-preview-36490--material-ui.netlify.app/joy-ui/api/alert/#props.
In the card https://deploy-preview-36490--material-ui.netlify.app/joy-ui/api/card/, we have no docs about the root element. Should we?

I opened a PR for this today (didn't know you opened a PR for it already!). I think we can go with your PR.
I will handle this.

(3) I noticed that component, slots, slotProps are missing in API docs of some components of all Base, Material and Joy. Is it to be fixed, or is there some reason we did this?

For (6), I think we can extract the description and put it above the table (in a separate PR).


Refactor S3 storage and add presigned URL flag

Migrated to v2 of the AWS Go SDK
Added a flag for presigned URLs in the S3 storage backend
Fixed a bug where the S3 client config doesn't have the region
configured properly. It should now work with MinIO properlyd

@heimweh With #39 merged, I could finally test the PR with MinIO. Pushed ce42d51c2a52600c1952d8b808cd4aecffa8c709 to fix a minor issue.


Error: Cannot find module 'hangupsjs'

For some reason, prepublish is not executing.
Current workaround is to run this after npm install from the hubot directory
npm run-script hubot-hangupsjs\node_modules\hangupsjs prepublish

Currently fixed by pinning to 0.10.1.


Tutorial documentation/check (particularly Tutorial 3)

All tutorials:
Hierarchical properties enrichment instructions
This is really minor and of course we can all cope, but it would be clearer/quicker if instructions for the drop down menus were in the same order as they appear on screen: property type, higher linguistic type, lower linguistic type, rather than having property type last as currently.
Tutorial 3 specific:
Step 3: Query
A typo ‘…it is not necessary to construct a query.’ is presumably meant to be ‘…it is now necessary…’
When carrying out this query I click ‘add filter’, select stress from the dropdown box and enter ‘1’ in the space under ‘value’ as instructed but then see a warning box saying ‘no label matching 1’. Is this a problem? I imagine that this simply refers to the fact that there is nothing which is solely '1' but that we are looking for the '1' in the stress pattern?
Dependent on target audience some may need to be reminded to install tidyverse first before using the library() function. In addition trying to use ‘filter’ caused my R to crash and I had to reload some relevant packages, I gather one of our RAs struggled with it too. It may have been something to do with installing tidyverse when I had some of the constituent packages installed already, perhaps a version issue related to this?
R code for checking how many words there are for each number of syllables may also be useful as this is mentioned in the instructions – I know it’s basic but there does seem to be a few options, with the count function in the plyr package being the easiest I think? E.g.:
 >count(df, “word_num_syllables”)

Ok, some of these are fixed now, the main outstanding one is that the stress still has the "no matching labels", but it still works alright.


Fixed Protobuf header mappings

 Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.0 out of 4 committers have signed the CLA.:x: TerryGirniak:x: murba-ss:x: austbot:x: ThomasGirniakYou have signed the CLA already but the status is still pending? Let us recheck it.


Improve data usage by reusing Http connections

Is your feature request related to a problem? Please describe.
Network data usage is critical for our business and currently, Datadog library is using the biggest number of data from all the libs that we use and our own service as well (around ~10 times more)
Describe the solution you'd like
While inspecting the network requests I noticed that Datadog is not reusing HTTP connections (~30-40% are new). This means it needs to make a TLS handshake that takes a significant amount of data. Take a look at the screenshots below (this were two consecutive requests). Notice the total data used.

1
2

This profiling was done when the app was in the background and still, the DD was doing ~2 requests per minute. The app I'm working on is turned on 24/7 so if we count that 30% request created a new connection this gives us ~17MB extra data per day.
Possible solutions:

Reuse the HTTP connections
Improve the number of requests made in the background. Ideally, make it configurable by the app.

Describe alternatives you've considered
Bumping up LogLevel
Leaving only critical logs (but at some point we might just as well use crashlytics only)
Additional context
This request is also valid for tracing and RUM

Hello @AdamGrzybkowski  and thanks for bringing up this topic.
Indeed we need to ensure we lower our impact on your application in such an intensive use. We are using OkHttp to perform our requests, and in theory it does reuse connections whenever possible. We'll investigate why this doesn't work in your case and fix that ASAP.
We also intend to provide some ways to configure how often batches are sent, which can alos decrease the number of requests performed by the SDK.

I've been performing some verifications with Charles Proxy, and although the connection itself is not marked as "kept alive", it is indeed reused. But the default configuration of OkHttp means that any connection will be recreated after 5 minutes of inactivity. This matches what we can already observe on our test, so the next step will be to provide some ways to configure the way data is sent, and possibly tweak the inactivity delay yourself.

and although the connection itself is not marked as "kept alive", it is indeed reused

The client is reusing the connection, but the server restarts it. This means the TLS handshake is required.
You can see that in the screenshot.

Thanks for those details, we'll keep investigating that.

Thanks, if you need more specific info from me, let me know. This is very important for us so I'm eager to help as much as I can :)

Hello @AdamGrzybkowski,
I made a few more tests, and the server does allow keep alive but only allows one minute of inactivity. I was able to keep a connection alive for 30 minutes while sending logs every 55s, but the connection restarts after 1 minute of inactivity. There's nothing much we can do to improve at our level, apart from what we schedule, that is giving more control on how the batches are gathered and sent to get more efficient data usage.

Hi @xgouchet
thank you for testing it :)

and the server does allow keep alive but only allows one minute of inactivity

is there a reason why BE cannot increase that time? This would be a way quicker solution that would almost immediately work for us as it doesn't require a new SDK release(that will probably not happen soon?)

We cannot increase this value, first for performance of our load balancer and intake process just for one specific case. Most of our clients application are not running 24/7 (which in general is not a good idea unless it's really needed), so they don't meet such a situation. We'll try to work fast on delivering better control on the upload process, and we'll keep you informed as soon as we can.


gh profile show

It would be nice if there was a simple command which would just show you which profile is currently specified.

That's something I asked for via https://github.com/gabe565/gh-profile/issues/1#issuecomment-1276700253 and @gabe565 accepted the proposal 😃 Nice that you created a dedicated issue for this. For tracking and all that stuff.
I also think the status command would also need to not just list selected profile (gh profile list does that already), but also to mimic gh auth status command so that user can see active credentials config rather than selected profile if the active creds have been changed by other means.
Not sure it would be not overhead (but would be good) to have a builtin logic to compare selected profile and active creds and warn if they differ 🤔

Like @yermulnik said, it's already possible to see which profile is active by running gh profile list. I'm currently working on a nicer status page that shows which account the profile is using, similar to gh auth status which will fully satisfy this.

Here's an example of the current gh profile list output. The profile which is bolded with the green check is the one that's currently active!

Confirmed it does show the correct profile with a check for me, so that is helpful.
I will say my intuition was to look for a show / status command and couldn't see it and didn't know how to figure it out I am also hoping to have a simple way to format the current profile so I can put it into my PS1 such as:
08:32:51:justin:~/code/example:feature/cool-feature (profile:default)
>

I didn't even think of adding this to the PS1 but that's a great idea. I'll add a show subcommand shortly!

Added a gh profile show subcommand in v1.1.0. Feel free to reopen this if you have any further suggestions. Thank you!

Thought I would mention that I've added a section to the readme for using gh-profile as a prompt element!