Update Ambassador IR module to respect preserve request ID flow

Description
This is the follow up PR for the changes incorporated at https://github.com/datawire/ambassador/pull/2522
Related Issues
https://github.com/datawire/ambassador/issues/2218
Testing
A few sentences describing what testing you've done, e.g., manual tests, automated tests, deployed in production, etc.
Tasks That Must Be Done

[ ] Did you update CHANGELOG.md?
[ ] Did you add or update tests?
[ ] Did you update documentation?
[ ] Were there any special dev tricks you had to use to work on this code efficiently?

[ ] Did you add them to DEVELOPING.md?

[ ] Is this a build change?

[ ] If so, did you test on both Mac and Linux?

Other

If this is a documentation change for a particular release, please open the pull request against the release branch.

Ah, the local caches need updating. The easy way to do this (which should be described in DEVELOPING.md?) is to get a Kubernetes cluster and run make push pytest-only, then once it passes, run make pytest-gold and commit the results.

Any updates on this?

@kflynn I rebased my changes with upstream. I did not understand about local cache 🤔 ? Seems like tests are still failing. while running make KAT_RUN_MODE=envoy pytest fails for me on local.

(Note that the changes for everything having two notices logged is actually a separate bug that I'll be tackling shortly. Sigh.)

Nice! hope to see this in 1.5.5 :)

This should definitely be in our next release, yes. 🙂

So I've realized that I was wrong, and this did not make it into 1.5.5 -- mea culpa! It has definitively been accepted for 1.6.0, though, stay tuned. 🙁


Does the flutter driver have plans to support the hybrid app?

When I used flutter driver for integration testing on hybrid app, I found that only after Dart VM was started, the test would continue. Is there any way I could use the flutter driver for integration testing when native part before the flutter ?  @kangwang1988

We're not going to support driver tests (since like you pointed out, Dart can't drive a test if the Dart VM isn't going to be started). But we'll support e2e testing via espresso and earl grey.
We'll create some examples in our samples repository via https://github.com/flutter/flutter/issues/47396.


rm

The domain is on the abuse list and should be removed from the library

@cidng I am sorry, the domain utexas.edu is removed from our trusted domains list because it was abused in the past. If you are the student of this school, please enroll to GitHub Student Developer Program. Then apply for JetBrains educational subscription with your GitHub account (GitHub tab at https://www.jetbrains.com/shop/eform/students).


[TreeView] Dynamic TreeView width

Fixes #16935
@joshwooding

@joshwooding can you help with the failing test please?

Thank ypu so much @oliviertassinari for fixing it. :)

No problem, one step at the time, the tree view is improving. Thanks for the help.


how can id run this project on Mac OS M1, use the GPU via torch "mps"

how can id run this project on Mac OS M1, use the GPU via torch mps

same question here

+1

Have you solved the problem

+1

I did everything as I can to port the code to mps. Sadly, mps does not implement ten::_fft_r2c at PyTorch 2.0.1. And I got this from console:
NotImplementedError: The operator 'aten::_fft_r2c' is not currently implemented for the MPS device. If you want this op to be added in priority during the prototype phase of this feature, please comment on https://github.com/pytorch/pytorch/issues/77764. As a temporary fix, you can set the environment variable 'PYTORCH_ENABLE_MPS_FALLBACK=1' to use the CPU as a fallback for this op. WARNING: this will be slower than running natively on MPS.

@yosefl20 thanks for you insights. i'm unable to get it run on my M1 CPU. I set this env variable to 1  ..but still gets the error
(video_retalking) a@Mac-a video-retalking % python3 inference.py \
  --face examples/face.mp4 \
  --audio examples/audio.m4a \
  --outfile results/1_1.mp4
/opt/homebrew/Caskroom/miniconda/base/envs/video_retalking/lib/python3.8/site-packages/torchvision/transforms/functional_tensor.py:5: UserWarning: The torchvision.transforms.functional_tensor module is deprecated in 0.15 and will be **removed in 0.17**. Please don't rely on it. You probably just need to use APIs in torchvision.transforms.functional or in torchvision.transforms.v2.functional.
  warnings.warn(
[Info] Using cpu for inference.
[Step 0] Number of frames available for inference: 377
[Step 1] Landmarks Extraction in Video.
Traceback (most recent call last):
  File "inference.py", line 345, in <module>
    main()
  File "inference.py", line 81, in main
    kp_extractor = KeypointExtractor()
  File "/Users/a/Git/video-retalking/third_part/face3d/extract_kp_videos.py", line 16, in __init__
    self.detector = face_alignment.FaceAlignment(face_alignment.LandmarksType._2D)
  File "/opt/homebrew/Caskroom/miniconda/base/envs/video_retalking/lib/python3.8/site-packages/face_alignment/api.py", line 77, in __init__
    self.face_detector = face_detector_module.FaceDetector(device=device, verbose=verbose, **face_detector_kwargs)
  File "/opt/homebrew/Caskroom/miniconda/base/envs/video_retalking/lib/python3.8/site-packages/face_alignment/detection/sfd/sfd_detector.py", line 31, in __init__
    self.face_detector.to(device)
  File "/opt/homebrew/Caskroom/miniconda/base/envs/video_retalking/lib/python3.8/site-packages/torch/nn/modules/module.py", line 1145, in to
    return self._apply(convert)
  File "/opt/homebrew/Caskroom/miniconda/base/envs/video_retalking/lib/python3.8/site-packages/torch/nn/modules/module.py", line 797, in _apply
    module._apply(fn)
  File "/opt/homebrew/Caskroom/miniconda/base/envs/video_retalking/lib/python3.8/site-packages/torch/nn/modules/module.py", line 820, in _apply
    param_applied = fn(param)
  File "/opt/homebrew/Caskroom/miniconda/base/envs/video_retalking/lib/python3.8/site-packages/torch/nn/modules/module.py", line 1143, in convert
    return t.to(device, dtype if t.is_floating_point() or t.is_complex() else None, non_blocking)
  File "/opt/homebrew/Caskroom/miniconda/base/envs/video_retalking/lib/python3.8/site-packages/torch/cuda/__init__.py", line 239, in _lazy_init
    raise AssertionError("Torch not compiled with CUDA enabled")
    ```

    any idea how to workaround this?

In case anyone still wondering,
Here are the steps. At least for now.
1-) Add this to above main function
Set default dtype to float32
torch.set_default_dtype(torch.float32)
and
def main():
# device = 'cuda' if torch.cuda.is_available() else 'cpu'
# adding gpu support on Apple M1/M2/M3 Chip Devices
if not torch.backends.mps.is_available():
if not torch.backends.mps.is_built():
print("MPS not available because the current PyTorch install was not "
"built with MPS enabled.")
else:
print("MPS not available because the current MacOS version is not 12.3+ "
"and/or you do not have an MPS-enabled device on this machine.")
elif torch.cuda.is_available():
device = 'cuda'
elif torch.backends.mps.is_available():
device = torch.device("mps")
else:
device == 'cpu'
...rest
to inference.py
2- On face_parsing.py
change process function to this ( starts at line 43 )
def process(self, im, masks=[0, 255, 255, 255, 255, 255, 255, 255, 255, 255, 255, 255, 255, 0, 0, 0, 0, 0, 0]):
# Adding im.astype((np.float32) to work with Apple M1/M2/M3 Chip Devices
if self.device == 'mps':
im = cv2.resize(im.astype((np.float32)), (self.size, self.size))
else:
im = cv2.resize(im, (self.size, self.size))
imt = self.img2tensor(im)
with torch.no_grad():
pred_mask, sr_img_tensor = self.faceparse(imt)  # (1, 19, 512, 512)
mask = self.tenor2mask(pred_mask, masks)
    return mask

3-) And lastly do this
conda env config vars set PYTORCH_ENABLE_MPS_FALLBACK=1
conda activate <video_retalking>
( We do the last step just because there is one operation that is yet to be implemented via MPS ).
It still takes long time on my MacAir M1/16GB RAM. Like around 30min for 6second video. Let me know yours.

I was able to run this on mps. Still slow but significantly better than CPU. Here is the 5 second video result.
MPS ===> 29min 36sec
CPU ===> 50min 4sec
Let me know how long yours take. And if you want to try yourself on mps:
1-) face_parsing.py ---> line 45 to ===> im = cv2.resize(im.astype((np.float32)), (self.size, self.size))
2-) inference.py --->
def main():
    # device = 'cuda' if torch.cuda.is_available() else 'cpu'
    # adding gpu support on Apple M1/M2/M3 Chip Devices
    if not torch.backends.mps.is_available():
        if not torch.backends.mps.is_built():
            print("MPS not available because the current PyTorch install was not "
              "built with MPS enabled.")
        else:
            print("MPS not available because the current MacOS version is not 12.3+ "
              "and/or you do not have an MPS-enabled device on this machine.")
    elif torch.cuda.is_available():
        device = 'cuda'
    elif torch.backends.mps.is_available():
        device = torch.device("mps")
    else:
        device == 'cpu'

...rest

3-)
conda env config vars set PYTORCH_ENABLE_MPS_FALLBACK=1
conda activate <video_retalking>

We do step 3 because there is this one operation is yet to be implemented using mps.
It should work.
Cheers.

I was able to run this on mps. Still slow but significantly better than CPU. Here is the 5 second video result.
MacBook Air 2020 M1/16GB RAM/8 Core GPU
MPS ===> 29min 36sec CPU ===> 50min 4sec
Let me know how long yours take. And if you want to try yourself on mps:
1-) face_parsing.py ---> line 44 to --->
im = cv2.resize(im.astype((np.float32)), (self.size, self.size))
2-) inference.py --->
def main():
    # adding gpu support on Apple M1/M2/M3 Chip Devices
    if not torch.backends.mps.is_available():
        if not torch.backends.mps.is_built():
            print("MPS not available because the current PyTorch install was not "
              "built with MPS enabled.")
        else:
            print("MPS not available because the current MacOS version is not 12.3+ "
              "and/or you do not have an MPS-enabled device on this machine.")
    elif torch.cuda.is_available():
        device = 'cuda'
    elif torch.backends.mps.is_available():
        device = torch.device("mps")
    else:
        device = 'cpu'

...rest

3-)
conda env config vars set PYTORCH_ENABLE_MPS_FALLBACK=1
conda activate <video_retalking>

We do step 3 because there is this one operation is yet to be implemented using mps.
It should work.
Cheers.

Thank you for the solution, but I have installed PyTorch 1.9.0,  the torch.backends does have "mps", which PyTorch version do you use and does it work for this project , for the guide says , to install PyTorch 1.9.0


Document the difference between WarningLevel and AnalysisLevel

The documentation for -warn compiler option should mention notes about AnalysisLevel, is it the same as WarningLevel? is it just a new name for it?
https://devblogs.microsoft.com/dotnet/automatically-find-latent-bugs-in-your-code-with-net-5/
This blog mentions that the default value for AnalysisLevel is 5. However, the default value for WarningLevel is 4.
All these need to be clarified.

This new article should cover all the information about warning waves.


Exporting figures to word/ pdf

@mvankessel-EMC at the moment createSunburstPlot and createSankeyDiagram provide nice html output, but is there already a recommended way to export these for word/ pdf (that could be used for example in a RMD file that renders to one of these) or, if not, could this be added (perhaps an argument to the function)?

Both plots are htmlwidget objects, which renders the HTML when used in RMarkdown. When rendered to a PDF or Word-document, it will render a static version of the plot. See the following example rmd-file.


add hyphen to source id, e.g. MPI-ESM1-2-HAM to MPI-ESM-1-2-HAM

Fixes missing dash in source id, MPI-ESM1-2-HAM to MPI-ESM-1-2-HAM
closes #359 (which was blocking progress on run #314)

I'm merging so I can get this running. Thanks, @dgergel !


[Backport release-23.11] zulip: 5.10.3 → 5.11.0

Description of changes
Backport to release-23.11:

#279756
#283898
#298292

Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)

[ ] sandbox = relaxed
[ ] sandbox = true

[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[x] Tested basic functionality of all binary files (usually in ./result/bin/)
24.05 Release Notes (or backporting 23.05 and 23.11 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[x] Fits CONTRIBUTING.md.

Add a :+1: reaction to pull requests you find important.

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:
https://discourse.nixos.org/t/prs-ready-for-review/3032/4081

As NixOS 23.11 reaches end-of-life today, this PR is closed as part of the EOL cleanup.


Choose a state management

I think that is a good idea to use MobX with Flutter Modular to state management. This can help the code moduralization... :D

A simple list of possibilities:

flutter_bloc
cubit
mobx
get
Bloc with rxdart
ValueNotifier

MobX is simple and very current

I Think MobX is better for the project and simple to understand!

MobX is simple, very powerful and has a good amount of materials available for research.

Mobx is a powerful way to do state management and simple to use due your concepts easy to understand and untill who never was working with flutter get understand

Mobx it's powerful and simple.

Mobx, simple and solve the problem.

Mobx with Modular, it will solve the problem about dependency injection and also the state management.

mobx is the best one.

as we can all agree, let's go with mobx :D


Error connectiong to Ontime version 2.0

When I try connecting companion to Ontime version 2.0, it's only showing this error: "Connection Failure
Connect error".
I tried companion version 3.0 and also version 2.4.2 stable builds, both on localhost and other networks

Hi, would you mind trying again, the module version 2.1.2 should be bundled in companion beta v3

Hey @MrFruble unfortunately the current module version, which allows connecting to OnTime V2, isn't included yet in the current stable release of Companion.
If you want to use OnTime with Companion, download the current beta release pls.


Error while trying to delete

Here is my code:
<?php
    if(!class_exists('Imap')) require "Imap.php";
    $imap = new Imap($mailbox, $username, $password, $encryption);
    if($imap->isConnected() === false) die($imap->getError());
    $imap->selectFolder("INBOX");
    $emails = $imap->getMessages();
    if(count($emails)>0){ //if theres a new email
        echo "There are ".count($emails)." emails found
\n";
        foreach($emails as $email) { //for every new email
            echo "Processing UID: ".$email['uid']."
\n"; //$email['uid'] is 4
            //do some stuff, import attachments, etc
            $read = $imap->setUnseenMessage($email['uid']); //mark as read
            if($imap->deleteMessage($email['uid'])) echo "deleted
\n"; //delete the email
            else echo " error deleting email
\n";
        }
    }
?>

I get the following errors:

( ! ) Notice: Unknown: Client tried to access nonexistent namespace. (Mailbox name should probably be prefixed with: INBOX.) (0.000 + 0.000 secs). (errflg=2) in Unknown on line 0
( ! ) Notice: Unknown: IMAP protocol error: Error in IMAP command UID COPY: Invalid uidset (0.000 + 0.000 secs). (errflg=2) in Unknown on line 0
( ! ) Notice: Unknown: Error in IMAP command UID COPY: Invalid uidset (0.000 + 0.000 secs). (errflg=2) in Unknown on line 0

Happens to me as well, definitely a bug

Moreover, no messages get deleted, all stay unchanged in INBOX

Notice: Unknown: Client tried to access nonexistent namespace. (Mailbox name should probably be prefixed with: INBOX.) (errflg=2) in Unknown on line 0
Notice: Unknown: Client tried to access nonexistent namespace. (Mailbox name should probably be prefixed with: INBOX.) (errflg=2) in Unknown on line 0
Notice: Unknown: Client tried to access nonexistent namespace. (Mailbox name should probably be prefixed with: INBOX.) (errflg=2) in Unknown on line 0
Notice: Unknown: Client tried to access nonexistent namespace. (Mailbox name should probably be prefixed with: INBOX.) (errflg=2) in Unknown on line 0
Notice: Unknown: Client tried to access nonexistent namespace. (Mailbox name should probably be prefixed with: INBOX.) (errflg=2) in Unknown on line 0
Notice: Unknown: Client tried to access nonexistent namespace. (Mailbox name should probably be prefixed with: INBOX.) (errflg=2) in Unknown on line 0
Notice: Unknown: Client tried to access nonexistent namespace. (Mailbox name should probably be prefixed with: INBOX.) (errflg=2) in Unknown on line 0

fix - edit Imap.php and replace deleteMessages function with this:
     /**      * delete messages      *      * @return bool success or not      * @param $ids array of ids      */     public function deleteMessages($ids) {         foreach ($ids as $id) {             imap_delete($this->imap, $id, FT_UID);         }         /*         if( imap_mail_move($this->imap, implode(",", $ids), $this->getTrash(), CP_UID) == false)             return false;         */         return imap_expunge($this->imap);     }

If this is merged into the normal file, I can close the issue.

@kurdtpage I will add this in with a pr later thanks!


packer hangs when I set the memory size to 8196 - for creating virtualbox-iso

I want to create a box by OSX Yosemite 10.10.4,
the default memory size is 2048 in template.json, when I changed the size to 8196 and use packer to build the vbox, then packer hangs and show
Waiting for SSH to become available...
The GUI is just black, and nothing happened.

I've heard reports from @chilcote before that he had a similar problem - at least, SSH not responsive - with VMware Fusion as well once he bumped the RAM size up to 4096.
This all seems odd, given that I can make an OS X VM manually with plenty of RAM and it functions as expected.

The vmware-vmx provider seems to work irt to ssh with >2048 set.

This seems to be a VirtualBox problem. I can't create a straight OS X VM with 4 GB RAM either—it simply fails to boot.

I fixed this by increasing vram to 128mb
["modifyvm", "{{.Name}}", "--vram", "128"]

I wonder if this is what was causing the problems referenced in PR #49.

On Nov 29, 2015, at 9:37 PM, cybertk<EMAIL_ADDRESS>wrote:
I fixed this by increasing vram to 128mb
["modifyvm", "{{.Name}}", "--vram", "128"]
—
Reply to this email directly or view it on GitHub.

This is a different problem than #49, but it is true that the box finishes booting if it has 4096 MB RAM and at least 128 MB VRAM. 64 MB VRAM didn't work. Build is still running; I'll see how that goes.

The above-mentioned build went fine. It did not solve the ARD problem (I'm perpetually on the lookout for a fix for that… but I digress.)
I would be okay with bumping up the VRAM to 128 MB (which is the maximum) by default, to make adjusting the RAM size less obtuse.

Thanks all!


gRPC interop: compute_engine_creds test fails

Jan 05, 2017 8:48:33 PM io.grpc.internal.ManagedChannelImpl <init>
INFO: [io.grpc.internal.ManagedChannelImpl-1] Created with target directaddress:///proxy-test-4b/<IP_ADDRESS>:
4141
Running test compute_engine_creds
Exception in thread "main" java.lang.AssertionError: expected:<null> but was:<>
        at org.junit.Assert.fail(Assert.java:88)
        at org.junit.Assert.failNotEquals(Assert.java:743)
        at org.junit.Assert.assertEquals(Assert.java:118)
        at org.junit.Assert.assertEquals(Assert.java:144)
        at io.grpc.testing.integration.AbstractInteropTest.computeEngineCreds(AbstractInteropTest.java:1091)
        at io.grpc.testing.integration.TestServiceClient.runTest(TestServiceClient.java:236)
        at io.grpc.testing.integration.TestServiceClient.run(TestServiceClient.java:200)
        at io.grpc.testing.integration.TestServiceClient.main(TestServiceClient.java:84)
Shutting down

it's worth noting that gRPC won't send credentials over an unencrypted channel and this test was done without TLS so I will re-run all of these credential failure test cases with TLS.


fix floatingActionButton not hiding when scrolling

It's a bug introduced by the new material3 changes.
Vitor removed the animation because when opening the app it was not showing the button


Composer is Conflicting with PHP Composer

Description:
Many developers may have installed PHP Composer in their machines (including me).
Ballerina composer is a new one and since names are pretty same they are conflicting.
PHP Composer is there for many years and they will never change the name, so ballerina will have to avoid this problem preventing users manually changing the name of scripts in the bin folder (i changed it to bal-composer myself to avoid conflicts)

Steps to reproduce:

Install ballerina and php composer in the same machine
Run composer in any directory and you will get them conflicted as os does not knows which composer to run.
So it will run the one found 1st in the PATH which may lead to one composer to be started

Affected Versions:

Any with the composer

OS, DB, other environment details and versions:

Any OS

Related Issues (optional):

Suggested Labels (optional):

Suggested Assignees (optional):

Duplicate of https://github.com/ballerina-platform/ballerina-lang/issues/9442.

thanks, Closing issue due to conflict


Redesign homepage for the standalone site

Problem
As Openverse will be in a standalone site, out of wordpress.org, we need to update the homepage to this new context. The page needs to be more explicit about what Openverse is, how to contribute to the project, showing content about the project living inside the site, and its relation with WordPress.
Besides the above, the page needs to fix showing the content types in the content switcher by meeting a11y and i18n requirements.
Since the scope of this change is moving Openverse to a new site, current functionalities and tweaks must tend to be as minimum as possible, mainly to accomplish the primary goal described above.
Issues related

#991
#978
#1198
#1295
#1174
#125

Proposal
https://user-images.githubusercontent.com/895819/170377079-ef058db0-bd42-4a85-bc81-96b452cb0cf2.mp4
https://user-images.githubusercontent.com/895819/170377728-d253d3f0-e859-442f-9ece-ea99e6af72fe.mp4
Description
As you can see, compared to the current menu, this one has fewer items since I made the following changes:

All items have no dropdown elements.
There is a “Get involved” item linking to either the make blog or the handbook.
Sources, Our story, Search Guide, and Meta Search pages are inside About as page’ sections instead of separated pages. I think we do not need most content from the Meta Search page as the feature should explain itself by using it, except for the paragraph describing why we have it.
API is a page in Openverse instead of external. I suggested this time ago, but I would like your thoughts. I am not thinking of redesigning the page but placing it in the openverse site.

The main title has a light font weight to balance the page contrast and not compete with the openverse logo.
Once opening the switcher, content-type items have smaller icons to reduce the popover size, and the video option was removed. This last point is a significant change for the user experience, but the reason is not providing a content type that sets the expectation of browsing content as the others, to then finding a white page with links to external sites. The promise of searching for relevant content would not be met.
Nonetheless, the video option still will be in the search result page. I would like to see your comments on this proposal.
I displayed the sample search results in a row at the bottom and added an interaction showing the content title. I did not want to hide content depending on the viewport, but I do not have a clear idea about how it looks like on big screens.
To show that openverse relates to WordPress, I added a small note in the footer. I was thinking of adding more content but could not find any reason why do it.
On mobile, I think the best way to solve the content type labels is by hiding them and letting users tap the icon to see the options. If we show the content type names, we will have to deal with i18n all the time.
The bottom-up box to see select a content type is an idea I like, but it would work only on this page. The current flow of leaving the site when seeing a full-size modal to select a content type feels odd at this stage of the search journey.
This proposal has many nuances, so I am happy to hear your thoughts and try new ideas.
Mockup

Figma: 3D model support and homepage redesign

I love the design, @panchovm ❤

On mobile, I think the best way to solve the content type labels is by hiding them and letting users tap the icon to see the options. If we show the content type names, we will have to deal with i18n all the time.

I really like the content type selector interaction on mobile! Having only an icon in the searchbar is great because it fits well on a narrow screen. I was wondering if we could add an x button for clearing the mobile searchbar: on mobile, clearing up a long string without it is a frustrating experience. On the other hand, we are an image search engine, so the users probably don't use long queries...

The bottom-up box to see select a content type is an idea I like, but it would work only on this page. The current flow of leaving the site when seeing a full-size modal to select a content type feels odd at this stage of the search journey.
This feels much more natural for mobile experience!

Glad that you loved the design @obulat 🙂

I was wondering if we could add an x button for clearing the mobile searchbar: on mobile, clearing up a long string without it is a frustrating experience

You are very right. I forgot to add it. I will work on that.
I actually understood something different before reading the whole sentence. I thought you referred to closing the modal for selecting a content type, and that part can be improved too. The only actionable element is the gray bar in the modal's top area to drag it down, and replacing it with an explicit close action seems clearer and more effective.

Here is a new flow fixing the input clear and closing the switcher.
https://user-images.githubusercontent.com/895819/170731173-d427ab09-c0a1-4b2b-9802-052fb6282cc0.mp4

Sorry about not getting you feedback sooner, @panchovm! I love the overall layout and the addition of the menu items, along with the dark-background mobile menu. Some feedback on points you made:

All items have no dropdown elements.

👍

There is a “Get involved” item linking to either the make blog or the handbook.

👍

Sources, Our story, Search Guide, and Meta Search pages are inside About as page’ sections instead of separated pages. I think we do not need most content from the Meta Search page as the feature should explain itself by using it, except for the paragraph describing why we have it.

I agree that 'meta search' doesn't need its own page, I am not sure about the Sources and search guide. I think those are both a lot of content and warrant their own pages. However, we could add links to those pages on the "About" page. In general, maybe the About page would be a good thing to leverage as a sort-of landing/marketing page for the project.
Alternatively, we could add more content 'below the fold', like DuckDuckGo does:
https://duckduckgo.com/

API is a page in Openverse instead of external. I suggested this time ago, but I would like your thoughts. I am not thinking of redesigning the page but placing it in the openverse site.

I am not sure about this, but I don't think it blocks this proposal at all. It's a matter of having the external icon or not, really.

One thing I still think we need to address is having a little more content and clearer content on this page. From a SEO perspective but also one of user understanding. 'items for reuse' is not as clear to folks as 'free stock photos' or 'free to use images' or whatever. Obviously those terms aren't correct for this project, but we still need to develop more and better content for this page and it would be nice to do alongside the redesign.
My very last thought: The new page looks amazing, but it loses a bit of the WordPress jazzy-ness of the current page, which has movement from the diagonal lines of the staggered images on desktop. I don't think we have to keep that feel, but I wonder if there are ways to preserve it in some sense.

Coming back late here too.

maybe the About page would be a good thing to leverage as a sort-of landing/marketing page for the project.

You are right about this, and that Sources deserves its page. My main discrepancy with the Search Guide content is putting it inside a page rather than explaining its potential through the search experience, i.e., showing the syntax commands in the recent searches popover. I would like to explore a solution for this idea to be more explicit about my point.

I am not sure about this, but I don't think it blocks this proposal at all. It's a matter of having the external icon or not, really.

Exactly 👍

The new page looks amazing, but it loses a bit of the WordPress jazzy-ness of the current page, which has movement from the diagonal lines of the staggered images on desktop. I don't think we have to keep that feel, but I wonder if there are ways to preserve it in some sense.

I like the feeling you are bringing. I can definitely work more on this aspect.
In general, it seems that your comments @zackkrida point to enhancing the page look and feel by bringing more brand and jazzy elements. I agree with the idea but my initial plan was to narrow the implementation scope as the upcoming domain change might require us to move quickly.
But that is open to change indeed.

@panchovm I think the page would be a great improvement. If we end up prioritizing the iframe project we could definitely launch this page as-designed here.

Coming back to share a new version of this page as we are facing a new context based on four points:

Openverse will be placed in a standalone site under openverse.org. This shift boosts the product independency while meeting a new scenario for the brand. However, we need to highlight that it is part of the WordPress project, and therefore, link to its site.
The current copy was updated weeks ago (#1756) and does not need new updates.
The new header (#1669) changes the search flow, and therefore, this page needs to be consistent with that new interaction.
The new footer (#1811) brings back the locale component (#1810) and the feature needs to be present from the beginning.

Without further details, here are the mockups.
Desktop lg

Mobile sm

Home
Menu

Interaction flow
https://user-images.githubusercontent.com/895819/202456748-30b0694b-27c5-45eb-b76e-9e6074a9432b.mp4

On desktop, each image takes you to its single result view. Instead of cropping the gallery section, this proposal shows all images and remains fixed on the right side. As the viewport goes smaller, I was thinking of hiding columns of the gallery until showing nothing on sm view.
For the switcher flow, I reused the new drawer and replaced the main button with "Search" to ease seeing the results.
The pages listed in the header should solve the content needs we have, so it is fully open to changes whether we consider adding or removing pages.
What do you think of the idea?

To your points:

⭐
I also like the boldness of the current grid, but this layout eases the domain change and sets a baseline for improving the layout. I am not getting rid of the full-size image idea, but this one simplifies the upcoming update.
It does have UX problems. The main one is how the image size meets a11y requirements and adapts to viewports as it goes bigger with breakpoints. Cropping images has interaction problems, and it will require deep thought to reuse the idea without jeopardizing the content navigation.
I am not concerned about the footer inconsistency as this page is the "cover" context introducing the project. With that in mind, we need to highlight the WordPress dependency, and the mention in the footer felt insufficient. However, I agree with your point on showing the WordPress project and library license texts across the site, but for now, this solution allow us to make a quick change and leave room for those improvements in the future.

I appreciate your approach @dhruvkb. Thanks

I am +1 on @dhruvkb's first and second points!
Your examples also show the disclaimer for CC licensed content no longer linking to https://creativecommons.org/licenses/ - is that an intended change?

My mistake @AetherUnbound, thanks for noticing it. It should link to the CC licenses page. The link should have the same style, an underline in the resting state.

Adding the discussion label to make clear the design proposal is not done yet.

Here is a new version of the page.

xs
xl

The changes made are:

Replacing the WordPress logo with the simplified version to make the mention less prominent.
Moving the WordPress mention to the footer to make it consistent with the last component update (see #2015).
Moving the CC license disclaimer below the search bar.

I also added the breakpoint variants. Here is a real-size frame with all mockups.

Questions and feedback
My main feedback request: What do you think of this version?
From xs up to lg, search area is the main content and is wrapped in the center by paddings on both sides. But from xl and beyond, search area's width is fixed, and the gallery appears on the right side.
The idea of this is to prevent a huge search bar on big screens, but since the right side would look empty, I was thinking of adding columns of images as there is available space, with a maximum of five columns. Once reaching the five columns, the gallery can float fixed on the right to balance the layout's white space. What do you think of this? Adding an example of how it might look like.

@panchovm It looks great to me.
I like the idea of adding columns to fill available space. I'm also fine with the logo swap to the "W" mark.
I'll connect with other WordPress.org community stakeholders to make sure the reduced prominence of the WordPress project callout is acceptable.

I think it's a great idea to limit the search bar size and fill in the extra space with more images! The new design looks fantastic 😄

We're good to move forward here 😄

Awesome. I will start preparing the assets ✨

Final design

Presentation
Mockups

The file assets are done. Changing the discussion label to ready for work ✨ 🚀

@panchovm could you share the cropped square images that will be used (preferably along with the UUID identifiers so that we can link to their single result pages)? I assume there will be many, considering ~ 15 images per set.
These image sets will be needed when implementing the image grid.

Sure! This week I am also selecting the remaining images for Universe, Olympic Games, and Indigenous pottery. So sharing them here as soon as possible.

These photos are excellent!

@olga asked a great question in the mockups, and moving it here to see other thoughts.

What should happen when you click on "See results" here (when opening the switcher drawer without typing a search term)? If you are redirected to search, then it can get confusing if the user hasn't entered a search term yet. We might have to indicate that they need to enter the search term then. And if it simply closes the modal, then the button label should be something like "Confirm selection/content type"

(Note added by me in italic)
Showing a message in the input field makes sense, but I wonder if Openverse might search regardless instead. Interrupting users from seeing results because they did not type a term seems like missing an opportunity to show Openverse. I am thinking of the Universe, Olympic Games, and Pottery as the default terms to match the homepage's gallery.
In this way, if users do not type anything, clicking on the search button or selecting a content type and then searching would take them to a result.
What do you think?

In this way, if users do not type anything, clicking on the search button or selecting a content type and then searching would take them to a result.

Interesting idea!
It might also be confusing for the user who wanted to 1. Select the search type and then 2. type in the search term.
I wonder if focusing the search bar after you click the CTA button in the search type selection modal would be more or less clear... Would be nice to have some user feedback :)

Taking them to a predefined search term based on the gallery seems wrong to me because:

It's not immediately clear that the gallery consists of searchable, indexed content in Openverse. To a new user, it might seem like a curated collection of very high-quality CC works. This is further reinforced because when you search for something like "universe" or "pottery", none of the gallery results are on the first page.

Since the gallery theme is not written anywhere, it is hard to relate a word like "universe" or "pottery" to the list of images in the gallery. So if clicking search takes them to the results page, it will seem like a random search. On mobiles, the gallery is not even visible, so there is even less reason to know why choosing a media type led them to a seemingly random search term.

I agree with @obulat that people might want to choose a media type first and enter the term later. In that case, their planned interaction is interrupted. If we take them to the search box and they choose to hit search anyway, then the idea of taking them to some predefined search makes sense. We still need to make sure that the results for the term are very high quality, currently searching for pottery shows a very NSFW image.

Other search engines do nothing when the search button is clicked without a query. Taking the user to the search field and using the required attr for that field seems the most reasonable approach to me.

It might also be confusing for the user who wanted to 1. Select the search type and then 2. type in the search term.

You are very right. In that vein. Showing the "See results" button in the drawer does not make much sense as selecting a content type could close it and go back to the homepage showing the content type icon selected.
On the other hand, you are right @dhruvkb. The randomness feeling, especially on mobile. The relationship is not clear and the results might frustate if does not fit the expectation. Hence, requiring to type a search term is more clear.
Here is a prototype based on the flows advised above.
https://user-images.githubusercontent.com/895819/209559655-9d327b91-4636-438f-8328-af67897f304f.mp4
Note: The prototype has spacings for interaction purposes, but are not part of the mockup.
I moved the content area slightly upwards so snackbar does not overlap the search bar. This change would require a different flex lauyout setting.


Wrong detection of multiple annotated constructors.

Open PR from migration of MGA to TP, should always be mergeable but might have some work in progress

Coverage remained the same at 77.29% when pulling 8a2641f739d3ecbfdc11c2da62ba258ba29d5c11 on sni/mga-tp-bug-fix_1 into e638262a1f0fcaaabd9816a8e2cfc39c62a9cfce on master.

Coverage remained the same at 77.29% when pulling 54914adbfc124e38fdef1ca762263be7939b4ac6 on sni/mga-tp-bug-fix_1 into e638262a1f0fcaaabd9816a8e2cfc39c62a9cfce on master.

Coverage decreased (-0.3%) to 77.023% when pulling 05bccc81e324c34c44496489ec91b333e9ae0c3d on sni/mga-tp-bug-fix_1 into e638262a1f0fcaaabd9816a8e2cfc39c62a9cfce on master.

Coverage decreased (-0.2%) to 77.095% when pulling e7348debf712ea56f258b5f3d96ad3a23fe1119a on sni/mga-tp-bug-fix_1 into e638262a1f0fcaaabd9816a8e2cfc39c62a9cfce on master.

Coverage decreased (-0.6%) to 76.731% when pulling 0fe3329d8831bed814dd3ab9bab97a92eec0bd73 on sni/mga-tp-bug-fix_1 into e638262a1f0fcaaabd9816a8e2cfc39c62a9cfce on master.

Coverage decreased (-0.6%) to 76.731% when pulling f4e5ec2016ef98623176c2c4d1918d3e03fd6fac on sni/mga-tp-bug-fix_1 into e638262a1f0fcaaabd9816a8e2cfc39c62a9cfce on master.

Coverage decreased (-0.7%) to 76.611% when pulling 8371b8651e1b81840003472f9e0ed532218e0388 on sni/mga-tp-bug-fix_1 into e638262a1f0fcaaabd9816a8e2cfc39c62a9cfce on master.

👍


size of images used, should be minimized

Smart car image one = 15.6kb
Smart car image two = 11.7kb
Smart car image three = 11.7kb
Rivals car image = 9.3kb
@amangarg104 size should be reduced as much as possible of all images!

Please take a look of the compressed images #4

@justudin LGTM! Thanks :smile:

You are welcome @amarlearning :)


New features for Qt3Scans

In this pull request, multiple functionalities have been added to the Qt3Scan GUI and controllers.

DAQ clock rate is stored internally in the controller for the collected dataset. This prevents any issues arising when changing the DAQ clock rate before you save the collected data.

In addition to the clock rate, now the DAQ and Scanner last config dicts are stored right before the scan starts. This is important to later store this kind of metadata.

Added functionality to the spectral confocal scans, so that the plotted images can be processed in two ways:

Choose the data aggregation method: Since each pixel in the scan contains an entire spectrum, the data must somehow be processed to be put in an image. Traditionally, a sum over the entire spectrum would suffice. Here, we give the user a choice to perform more nuanced analysis with choices such as plotting the mean, max, or min counts for each pixel, or plotting the wavelength at which the max and min are, or even plotting the weighted-by-counts wavelength (which gives the central wavelength of a single peak if the spectrum contains only one peak, without requiring a fit).
Filter the wavelength range: instead of using the entire spectrum to aggregate data, this functionality allows the user to select only a specific range of wavelengths on which the aggregation method will act on. This range is also depicted in the individual scan data (upon a right-click on a plot pixel).

Added more parameters to the stored data:

Filter range
Aggregation method
DAQ configuration
Scanner configuration

With npz filetype, the daq_config and scanner_config are saved as additional keys. In order to read them, allow_pickle=True in the np.load(...) method must be used. With h5 filetype, the daq_config and scanner_config are saved as a json-converted dicts in the file attributes. (e.g., h5file.attrs['daq_config']).

Load Scan: Now you can load a saved scan and view it immediately. All formats other than '.npy' are supported. Since the filter range and aggregation method are stored, the user can even recover the process which resulted in the plot they last saw on the GUI.

'Go to' after scan checkbox: After the end of a scan, the 'Go To Position' method will run once if the checkbox is set to active.

Added "Optimize axis" functionality for spectrometer-based DAQs

Fixed "Optimize axis" bug (axis values were missing last value with previous changes in main).

We tested the code on the QT3 quantum light microscope and all features seem to work.  This branch has been in operation for some time in the ZnO experiment in the quantum defects lab.


What are the custom views ids for the addon?

I'm submitting a ...

[ ] bug report
[ ] feature request
[x] support request

General infomration
Prerequisites

[x] Are you running the latest version?

Description
What are the custom views for the addon? I tried searching on google but didn't find.
I would like to show the Netflix Menu as a banner (if possible) and movies/tvseries as poster, what should be the ids?
Context (Environment)
Installation

[ ] I installed the plugin via zip from the Releases page
[x] I´m using the Netflix Repo
[ ] I´m using a different source (Please tell which)

Operating System

[ ] Linux (x86/x64)
[ ] OSX (x86/x64)
[ ] Windows (x86/x64)
[x] Linux (ARM) (RPi3)
[ ] Android

Additional informatin on the environment
LibreElec Milhouse TestBuild #0603

banners: = 501
posters  = 51,
Although i guess it depends on the Skin you are using.

Yep It depends on the skin you use.


Added ssn-input component, updated addon to use latest ember-cli

@pzuraq I had a requirement in my project where this addon helped me a lot. I have made some upgrades to this addon. I hope you find them useful.
This pull request includes:

New {{ssn-input}} component with unit test
Upgraded ember-cli and most of other dependencies to latest ember version
Cleanup failing email-input test
Cleanup of the dummy app

@tushar-chauhan This looks good! My one question is about the commented out test, is it an incorrect test or could you just not get it working again? If it's incorrect we should remove it, but if it is correct and not working we'll need to diagnose and fix.

@pzuraq if you uncomment and try that test out, you will see that the unmaskedValue is same as the input value.
I tried to fix it, but I could not find any code in the email-input component, rather I found out that it is totally inherited from input-mask component.
As that test was failing after upgrade, I commented it.
Right now I am on a holiday and not carrying my machine, so I won't be able to look into it before 9th of this month. Let me know if you try that test and get it running before that.

One solution could be to change that assertion to:
assert.equal(component.get('unmaskedValue'), 'test@test.test');

I guess you can do replace: assert.equal(component.get('unmaskedValue'), 'testtesttest'); with
assert.equal(component.get('unmaskedValue'), 'test@test.test');
I just checked email tests on jquery.inputmask: https://github.com/RobinHerbots/jquery.inputmask/blob/3.x/qunit/tests_dynamic.js
When entire email id is in the input field then they are also asserting it with the same full email id. I hope this helps. My fingers are killing me while typing on mobile now :smile:

@tushar-chauhan That makes sense, looks like the test was flawed to begin with. Go ahead and replace the value, it's much better than commenting out the test. I'll merge as soon as it's updated, thank you for contributing!

@pzuraq Updated the pull request with cleaned up tests. I have added both assertions in a single test. Let me know if something needs to be changed.

@pzuraq You may want too add the usage instruction for ssn-input field in the Readme file too.

@tushar-chauhan Right on, I'll merge this as is. I'm not actively maintaining this plugin at the moment, but will continue to review and merge PRs, so feel free to add any docs or make any changes!


getHistoricalData fields don't match the official ones

getHistoricalData returns an undocumented custom object that doesn't match the official Bar class.
There are extra .dateStart and .dateEnd fields, and the bars arrive in .bars. OK, not so bad. But then each bar renames time to date, WAP to average (presumably), and count to barCount.
What has been the reasoning here?

It was never supposed to mimic Java API, since it has own legacy stuff. And it's very old library (i've used it 10 years ago) and has a lot of legacy burden. They have to.
Particularly it's architecture doesn't support request-response notation, auto reconnect, and many other stuff.
so no reason to use uncommon weird names.
dateStart, dateEnd is a good example - they are in the protocol's response and useful, but not in java api return object.


SPI failed to write. errno: 110, Connection timed out

[x] I confirm that this is an issue rather than a question.

Bug report
My hyperion.ng setup was working fine for month. From one day to the next the hyperion suddenly stops working.
The LEDs light up, but stay static. When I disable and enable hyperion via the webinterface, the LEDs get updated once and stay static.
Updating to the latest version or compiling from source did not change a thing.
Deleting my .hyperion directory did not change a thing either.
What is expected?
Color changing LEDs
What is actually happening?
Static LEDs
hyperion says:
LEDDEVICE    : <ERROR> SPI failed to write. errno: 110, Connection timed out
SPI failed to write. errno: 110, Connection timed out

System
Hyperion Server:

Build:           master (GitHub-36441554/9e281b23-1613561393)
Build time:      Feb 20 2021 11:06:42
Git Remote:      https://github.com/hyperion-project/hyperion.ng.git
Version:         2.0.0-alpha.9
UI Lang:         auto (BrowserLang: de-DE)
UI Access:       default
Avail Capt:      dispmanx,v4l2,framebuffer,qt
Database:        read/write

Hyperion Server OS:

Distribution:   Raspbian GNU/Linux 10 (buster)
Architecture:   arm
CPU Model:      ARMv7 Processor rev 3 (v7l)
CPU Type:       Raspberry Pi 4 Model B Rev 1.1
CPU Revision:   b03111
CPU Hardware:   BCM2711
Kernel:         linux (5.10.11-v7l+ (WS: 32))
Qt Version:     5.11.3
Python Version: 3.7.3
Browser:        Mozilla/5.0 (Windows NT 6.3; WOW64; rv:84.0) Gecko/20100101 Firefox/84.0

@Unkn0wn-MDCLXIV I would suggest that you follow up on the error that is given to you. There seems to be a problem with SPI.
This is not a bug, but something on your system.


Plans for non-self-contained package?

Hi!
Intro
I just today found out about jupyterlab desktop (henceforth JLD) via mention in notebook-v7.html#user-stories
I have read both the medium blogs (introduction 2021.09 & latest update 2023.02). The idea of JLD is awesome.
But looking at the releases, the assets for Setup-Windows are >500 MBs.
Main Body

JupyterLab App is the cross-platform standalone application distribution of JupyterLab.
It is a self-contained desktop application which ...
JupyterLab App is based on Electron and it runs the front-end of JupyterLab inside an embedded browser.
The backend of the JupyterLab along with Python libraries are provided via a bundled conda Python environment.
JupyterLab Desktop App now available!
- Mehmet Bektas | 2021-Sep-22 | emphasis mine

While i can understand the reasoning behind making JLD a self-contained application,
but is there any plan to just release the JLD front end to use the existing system wide python environment?
My User Stories
My user story for this against the normal jupyter-lab is:

my browser is quite heavy, and I dont feel it to be much reliable.
While installing the link localhost:8888 as web app does some isolation,
... but making the shortcut to that web app for launching, changing the start-in directory etc are still a hassle
being able to launch it as a separate application not dependent on my browser, and being able to independently configure the launch paths will be nice to haves.

My story for against the self-contained JLD:

my system is low on storage (thanks to OEMs bundling small SSDs and not HDDs in their laptop offerings)
and i like to keep things minimal where possible and avoid duplicates

I would think that this is a bug. All Mac/Linux installers are ~300 MB, why is Windows >500MB?
PS. I would love to have an option to install this without conda environment (e.g. having a jupyterlab-desktop-serverless distribution) but this is probably a minor contributor to the bundle size.

standalone JupyterLab/Jupyter Server would be lighter in weight than JupyterLab Desktop does,

How? talking about the normal pip install jupyterlab ??

... and you can also create shortcuts to open a browser to your locally running JupyterLab

if talking about above mentioned method, then i have already highlighted the points related to this above.

this is probably a minor contributor to the bundle size.

i don't think so. 2 things come to mind: VS Code is also based on electron - it's just 90 MB on windows. Don't know the size of the extension or if it downloads any other thing. 2nd, this huge size makes it comparable to the Anaconda.

@goyalyashpal we don't have a distribution without bundled conda environment unfortunately but we would like to have it eventually. You can delete the conda env installer from C:\JupyterLab\resources\env_installer\ directory to save space if you won't be using it.

we would like to have it eventually

thats great :)

delete the conda env installer from dir

nice point, if not there already, then for the time being, this choice to disable it can also be made available via JLD installer itself in the "custom installation options".

I just found jupyterlite via jupyter home site (refer from julia)

JupyterLite is a JupyterLab distribution that runs entirely in the browser built from the ground-up using JupyterLab components and extensions.
JupyterLite Project | emphasis mine

several of the environments below use the JupyterLite project to provide a self-contained Jupyter environment that runs in your browser ...
https://try.jupyter.org

While installing the link localhost:8888 as a progressive web app (PWA) does some isolation,

also, now i have moved away from the google chromium base to google mozilla firefox base.
but sadly, firefox doesn't support web-apps, so yeah... yet another hassle and needless dependency on the underlying system of the user.


package Mojolicious::Plugin::AssetPack::Pipe::RollupJs misspelled

The file ist named Rollupjs.pm, the package name is RollupJs. Therefor the pipe cannot be instantiated.
Error:
Can't locate object method "new" via package "Mojolicious::Plugin::AssetPack::Pipe::Rollupjs"

Oh! I messed up because the osx filesystem is case-insensitive when it tries to locate files.
Hopefully fixed in 2.00.


Update default tag README section

Sorry for the delay. We had a significant API update coming which got help up for a bit. This part of Kermit has changed. The default is now an empty string, which is ignored on platforms that don't support tags. So, closing this, but thanks for the PR.


LSU stall on pipeline miss

This PR includes the changes from https://github.com/riscv-software-src/riscv-perf-model/pull/77 .
I have implemented stall_on_pipeline_miss as a parameter for the LSU.
It assumes the timing from MMU and Cache to be as follows
Lookup => 1 cycle
Ready => N cycles

I have included a new file test/core/dispatch/test_cores/test_small_core_stall.yaml which runs the existing tests with the stall_on_pipeline_miss parameter active

@knute-sifive @arupc I think I implemented something totally different here.
I implemented an in order load-store execute instead of a stall on pipeline miss behaviour.
I will change the title and the description to match that


About depth information

Hi,
The article you mentioned "Real-time Grasp Detection..." has the image depth information included when training the CNN. While the title of your repository "robot-grasp-detection" is "Detecting grasping... using RGB images".
Does it mean when training your network, you only used RGB images, and depth info. is not used ?
Further, the Cornell Grasping Dataset, has point cloud information of all images. If your network is trained with this dataset, depth information should be included. Am I correct ?
Thanks.

@qiushenjie Just replace the B (in RGB) channel by D (depth image). Or pass RGB and DDD to 2 separate Networks, then concatenate the 2 feature maps which then are fed into FC layers.


Selector expect map not string

If we using string then k8s api is throwing validation error
(HorizontalPodAutoscaler.spec.metrics[0].object.metric.selector): invalid type for io.k8s.apimachinery.pkg.apis.meta.v1.LabelSelector: got "string", expected "map"; if you choose to ignore these errors, turn validation off with --validate=false

@jalagari Please sign the CLA so that your PR can be reviewed.
https://github.com/kubernetes/community/blob/master/CLA.md

/sig autoscaling

/assign

I'm pretty confident this is correct but I am trying to get a technical review from SIG Scalability

I wasn't able to get a technical reviewer to respond.  I did some further research and feel I was able to validate this is techically correct.  Great job!
/lgtm
/approve


Fix #77: Added composer plugins to installation guide

Q
A

Is bugfix?
✔

New feature?
❌

Breaks BC?
❌

Fixed issues
#77

@luke- Thanks 👍


Memory leak in RedisHealthContributor

There appears to be a memory leak in RedisHealthContributor.  I have an application running under Cloud Foundry, If I call AddRedisConnectionMultiplexer, that adds the health contributor.  Then my application memory will climb steadily.  About every 5 or 6 hours, the application will run out of memory and Cloud Foundry restarts it - and this is over night when the only activity on the app is the health checks.  If I disable the health checks, then the memory increase goes away.
I haven't pulled the Steeltoe libraries from git and built them myself - I'm just getting them from NuGet.  But looking in git, it looks like the health check is calling a Create method on a factory.  I can't tell what the data type is getting created, but could that have a Dispose that should be getting called?
I also see in the health check that there's a Microsoft implementation and a StackExchange implementation.  Based on the fact that we're getting a ping time back, we appear to be hitting the StackExchange implementation.

@dwilliss :  Thanks ...Digging into this!

@dwilliss :
I pushed what I think fixes this memory leak based on my testing.
If you have the time... pull the latest Connectors package from the DEV NuGet feed .... and give it a try.
We will merge the change into a new 2.1.1 service release soon.
Thanks for the report!

@dwilliss:
Bummer, I thought I had fixed it...
Is this a ASP.NET Core or .NET Framework app?
How much memory are you allocating to the container for the app?
Is the app you're testing with one of the Steeltoe sample apps or is it your own?   Is it available so I can try testing with it?
Dave

It's a .NET Framework app.
We're allocating 1 Gig to it.
It's one of our own apps.
Unfortunately, it's not available on a publicly facing server yet.
I don't know if there's anything you can do.  The class you're getting via reflection into the StackExchange.Redis.StrongName DLL isn't IDisposable, and all you do is call its Ping method.

@dwilliss:
I took our CloudFoundryWeb 4.x sample and added Redis Health contributor to it.
I updated it to use the latest Steeltoe bits off the Dev MyGet feed.  This includes the "fix" I did to address this OOM issue.
You can grab the updated sample here
I ran the sample on a PASW Cell (2016) in 512M container.  I created a script that continuously hits the "/cloudfoundryapplication/info", "/cloudfoundryapplication/health" and "/" endpoints.  The script hits these 4 times a second.  I ran the script for 6+ hours.  I was unable to get the OOM condition to happen during that time.  The PCF Apps Manager indicated about 350M memory usage out of 512M.
If you look at the sample you will see that the "/" endpoint logs the Heap usage, and the count of GC's.  From the logs,  I saw that GCs were happening and the heap usage was going up and down as expected .... with no steady climb to indicate an OOM would happen anytime soon.
If you have time would you try the above sample and confirm you see issues even with that sample.  Also can you confirm that you are using the same Steeltoe and Stackexchange NuGets  in your app. Have a look at packages.config for the version #'s.
Thanks
Dave

I just got a reply from the Stackexchange.Redis people saying they had a version 2.0 that was just released (dated yesterday).  I dropped that in and the situation seems to have improved quite a bit. I'm going to let it run over night and see what happens.

Their fix seems to have worked.

Also, for anyone else who is interested in this issue.
I ran the above mentioned test overnight and found no OOM issues using these NuGets:
StackExchange.Redis.StrongName version=1.2.6
Steeltoe.CloudFoundry.ConnectorBase version=2.1.0-dev-00280
We applied a fix that we believe fixed the OOM issue and that contained in ConnectorBase 2.1.0-dev-00280.  From our testing it appears we do not have an OOM issue anymore.   We will soon merge that fix into an upcoming 2.1.1 of the ConnectorBase package.
Thanks @dwilliss  for reporting the issue.
Dave


Add check to prevent attempt to sign with nil PrivateKey

This could previously cause panics when a PrivateKey wasn't parsed correctly.

r? @oconnor663 @maxtaco

:+1:

This change looks good. But do the panics mean that the parsing code is dropping an err on the ground somewhere?

@oconnor663 When parsing packets, go-crypto/openpgp will just drop invalid packets/keys, not set PrivateKeys from dummy keys.
https://keybase.atlassian.net/browse/CORE-2538 should cover warning the user when this happens.https://keybase.atlassian.net/browse/CORE-2538


(HITOS) Update hitos.html

Changes
-changed an error from a calculation of a skill
-changed the size of some boxes that did not show the numbers well

Soo what did you change? If you read the default message and folow it, Cassie knows faster what to look for in you changes.

thanks!. Eres muy amable! ^-^


Fix issue with extension sidenavs not being moved correctly in prod

Codecov Report

Merging #81 into v2-master will decrease coverage by <.01%.
The diff coverage is 100%.

@@              Coverage Diff              @@
##           v2-master      #81      +/-   ##
=============================================
- Coverage      71.95%   71.94%   -0.01%
=============================================
  Files            685      685
  Lines          29562    29565       +3
  Branches        6783     6783
=============================================
  Hits           21272    21272
- Misses          8290     8293       +3


How to redirect stdout and stderr to same file

@BrendanSimon That's something I didn't think of earlier!
I'll try adding that feature in sometime in the future.


Add instance.dropItem() to InstanceContainer

When dealing with generators or other objects, you may want to be able to drop some materials.
As we already have setBlock, it would be short and efficient to have a method like this:
instance.dropMaterial(Material material, Pos position, int quantity);

when would a world generator want to drop a item?

Not a world generator, i meant a generator of items in minigames like in bedwars, every x seconds an item gets dropped from a generator.

You can already spawn entities inside an instance: https://github.com/Minestom/Minestom/blob/1.18/demo/src/main/java/net/minestom/demo/PlayerInit.java#L81-L85


FIPS enforcement woes

Testing against the a FIPS enforced system produces a condition whereby agent.ps1 doesnt initialize properly due to restrictions on algorithms used (HMACMD5).
https://support.microsoft.com/en-us/kb/811833
-- Changing registry key fixed problem... but that wont be kosher :)
Running agent.ps1 in the current master:
New-Object : Exception calling ".ctor" with "0" argument(s): "This implementation
is not part of the Windows Platform FIPS validated cryptographic algorithms."
At line:373 char:31

        $hmac = New-Object <<<<  System.Security.Cryptography.HMACMD5;

CategoryInfo          : InvalidOperation: (:) [New-Object], MethodInvocatio
nException
FullyQualifiedErrorId : ConstructorInvokedThrowException,Microsoft.PowerShe
ll.Commands.NewObjectCommand

Property 'Key' cannot be found on this object; make sure it exists and is settable
.
At line:374 char:19

        $hmac. <<<< Key = $encoding.GetBytes($SessionKey);

CategoryInfo          : InvalidOperation: (Key:String) [], RuntimeException
FullyQualifiedErrorId : PropertyNotFound

You cannot call a method on a null-valued expression.
At line:375 char:42

        $expected = $hmac.ComputeHash <<<< ($inBytes);

CategoryInfo          : InvalidOperation: (ComputeHash:String) [], RuntimeE
xception
FullyQualifiedErrorId : InvokeMethodOnNull

Compare-Object : Cannot bind argument to parameter 'DifferenceObject' because it i
s null.
 Error starting listener on port 8081: [Errno 98] Address already in use
2015-08-27 02:16:40 EmpireServer : [] Initializing HTTP server on 8082
2015-08-27 02:17:38 HttpHandler : [] /index.asp requested from None at <IP_ADDRESS>
2015-08-27 02:17:38 Agents : [] Sending stager (stage 1) to <IP_ADDRESS>
2015-08-27 02:17:38 HttpHandler : [] Post to /index.jsp from ZTG4SEN2GCWYSZXN at <IP_ADDRESS>
2015-08-27 02:17:38 Agents : [] Agent ZTG4SEN2GCWYSZXN from <IP_ADDRESS> posted to public key URI
2015-08-27 02:17:38 Agents : [] Agent ZTG4SEN2GCWYSZXN from <IP_ADDRESS> posted valid RSA key
2015-08-27 02:17:38 HttpHandler : [] Post to /index.php from ZTG4SEN2GCWYSZXN at <IP_ADDRESS>
2015-08-27 02:17:38 Agents : [] Sending agent (stage 2) to ZTG4SEN2GCWYSZXN at <IP_ADDRESS>
2015-08-27 02:17:38 Agents : [+] Initial agent ZTG4SEN2GCWYSZXN from <IP_ADDRESS> now active
2015-08-27 02:17:43 HttpHandler : [] /news.asp requested from ZTG4SEN2GCWYSZXN at <IP_ADDRESS>
2015-08-27 02:17:48 HttpHandler : [] /admin/get.php requested from ZTG4SEN2GCWYSZXN at <IP_ADDRESS>
2015-08-27 02:17:53 HttpHandler : [] /login/process.jsp requested from ZTG4SEN2GCWYSZXN at <IP_ADDRESS>
2015-08-27 02:17:55 Agents : [] Tasked ZTG4SEN2GCWYSZXN to run TASK_SHELL
2015-08-27 02:17:58 HttpHandler : [] /admin/get.php requested from ZTG4SEN2GCWYSZXN at <IP_ADDRESS>
2015-08-27 02:18:01 Agents : [] Tasked ZTG4SEN2GCWYSZXN to run TASK_SHELL
2015-08-27 02:18:02 Agents : [] Tasked ZTG4SEN2GCWYSZXN to run TASK_SHELL
2015-08-27 02:18:03 Agents : [] Tasked ZTG4SEN2GCWYSZXN to run TASK_SHELL
2015-08-27 02:18:04 HttpHandler : [] /login/process.jsp requested from ZTG4SEN2GCWYSZXN at <IP_ADDRESS>
2015-08-27 02:18:04 Agents : [] Tasked ZTG4SEN2GCWYSZXN to run TASK_SHELL
2015-08-27 02:18:06 Agents : [] Tasked ZTG4SEN2GCWYSZXN to run TASK_SHELL
2015-08-27 02:18:09 Agents : [] Tasked ZTG4SEN2GCWYSZXN to run TASK_SHELL
2015-08-27 02:18:10 HttpHandler : [] /admin/get.php requested from ZTG4SEN2GCWYSZXN at <IP_ADDRESS>
2015-08-27 02:18:15 HttpHandler : [] /login/process.jsp requested from ZTG4SEN2GCWYSZXN at <IP_ADDRESS>
2015-08-27 02:18:20 HttpHandler : [] /admin/get.php requested from ZTG4SEN2GCWYSZXN at <IP_ADDRESS>
2015-08-27 02:18:25 HttpHandler : [] /login/process.jsp requested from ZTG4SEN2GCWYSZXN at <IP_ADDRESS>
2015-08-27 02:18:30 HttpHandler : [] /login/process.jsp requested from ZTG4SEN2GCWYSZXN at <IP_ADDRESS>
2015-08-27 02:18:35 HttpHandler : [] /news.asp requested from ZTG4SEN2GCWYSZXN at <IP_ADDRESS>
2015-08-27 02:18:40 HttpHandler : [] /news.asp requested from ZTG4SEN2GCWYSZXN at <IP_ADDRESS>
2015-08-27 02:18:45 HttpHandler : [] /news.asp requested from ZTG4SEN2GCWYSZXN at <IP_ADDRESS>
2015-08-27 02:18:50 HttpHandler : [] /news.asp requested from ZTG4SEN2GCWYSZXN at <IP_ADDRESS>
2015-08-27 02:18:55 HttpHandler : [] /news.asp requested from ZTG4SEN2GCWYSZXN at <IP_ADDRESS>
2015-08-27 02:19:00 HttpHandler : [] /news.asp requested from ZTG4SEN2GCWYSZXN at <IP_ADDRESS>
2015-08-27 02:19:05 HttpHandler : [] /login/process.jsp requested from ZTG4SEN2GCWYSZXN at <IP_ADDRESS>
2015-08-27 02:19:10 HttpHandler : [] /news.asp requested from ZTG4SEN2GCWYSZXN at <IP_ADDRESS>
2015-08-27 02:19:15 HttpHandler : [] /admin/get.php requested from ZTG4SEN2GCWYSZXN at <IP_ADDRESS>
2015-08-27 02:19:20 HttpHandler : [] /news.asp requested from ZTG4SEN2GCWYSZXN at <IP_ADDRESS>
2015-08-27 02:19:25 HttpHandler : [*] /admin/get.php requested from ZTG4SEN2GCWYSZXN at <IP_ADDRESS>

The reason the agent works when you revert to 1.0 is because someone discovered a flaw in the 1.0 crypto that would allow someone to execute timing attacks on the Empire server. You can view the convo here:
https://github.com/PowerShellEmpire/Empire/pull/3
and the commit here, in which we added hmac:
https://github.com/joncave/Empire/commit/4624cff0e6bbb07ab5e0d51c67fec4c24eefc620
We will look into a way to potentially get this fixed and get back to you.

Have a test branch that converts HMACMD5 to HMACSHA1 at https://github.com/PowerShellEmpire/Empire/tree/hash_alg_update . Let us know if this fixes the issue.

This branch works with the registry key's FipsAlgorithmPolicy's Enabled key set to 1. Confirmed to work on win7 x64 USGBC image. Thanks for quick turn around.


Integration tests are flaky

Recently we notice that the integration tests are flaky and failing time to time. With no reason related to the code changes. It's looks like that we have some timeout problems. This is an example:
https://github.com/kubewarden/kubewarden-controller/actions/runs/8007800052/job/21882884521
Acceptance criteria

Checks why the tests are failing in our CI and fix it.

Duplicated, closing in favour of https://github.com/kubewarden/kubewarden-controller/issues/628


Google directions API - how can I get estimated travel times based on departure/arrival time?

I have no idea how to get the travel time, and NgMap does do nothing about travel time.


quasi does not get a lot of documentation

Problem or new feature
quasi does not get its own entry in the reference, and barely a few words in the macro documentation. We don't know, for instance, it needs a "scoped block" (#4079) or what kind of arguments it has
Suggestions
Improve macro documentation, or give quasi its own page (or create one for experimental features)

Aiui quasi (and macros in general) are like harmless zombies, not remotely close to being worthy of documentation, nor the effort of deprecation or removal except as part of point #2.

Aiui it is reasonable to hope that macros and quasi (or some other paint) will become non-experimental at some point in the next 1-3 years as part of the RakuAST work.

Per this line of code, a "scoped block" is, syntactically speaking, a code block (cf the type Block and code of the form { ... }).

Semantically speaking, a quasi block is not a Block. It might be a sub class implementation-wise (in the experimental code and/or the hopefully upcoming non-experimental code per point #2), but just as likely won't be given that it is a fundamentally different beast in at least one respect, and perhaps a second one. The definite difference is that it's a template of code that allows some fragments to be substituted in. The possible additional difference is that, aiui, the braces might not always establish a lexical scope (i.e. the "scoped block" is, aiui, quite possibly entirely misleading). Aiui this latter possible difference depends on how folk decide to handle "hygienic" vs "non-hygienic" macros.

As a bikeshed paint point, I hope to persuade Rakoons to consider choosing a better word than quasi (when the time is right, which I'm presuming will be when RakuAST is much further along). I don't think this issue is the right place and time to detail the excellent rationale I've seen Carl Masak and others provide for using the word quasi, nor the ones I see for not using it. Instead I will just note that, aiui, a quasi returns a fragment of AST (which is compiled from the "block" that follows the keyword), or perhaps some variant of an AST that is a template of AST; and the word I have mentally penciled in as a strawman proprosal is ToAST, short for either to AST or Template of AST.


frontend: Add feature to view deploy logs

This adds feature to view all the pods of pods in a deployment rather than going to a specific pod.
Fixes: #2552
Testing

Create a deployment kubectl create deployment nginx --image=nginx --replicas=3
Run the app and navigate to the deployment
Click on the logs button to view the logs of all the pods in the deployment

Screenshots

So weird, I ran the tests locally, updated snapshots, wonder why it is still failing 🤔

Changing some UX for this

Updated, please review


system

Is it possible to run the sample code under windows10 system?

I haven't test the code on windows, but it should be doable I think. You'll need nvcc and cuda installed.

@PeterWang512 Excuse me, When I run generate sample script, but processing stop at line 11 of [fused_act.py]。
RuntimeError: Ninja is required to load C++ extensions

@PeterWang512 Excuse me, When I run generate sample script, but processing stop at line 11 of [fused_act.py]。 RuntimeError: Ninja is required to load C++ extensions

Hello, I think you can use pip install ninja to build a C++ extension.

@PeterWang512 @0sure Excuse me, the GPU I use is NVIDIA RTX3060, can RTX3060 run the sample code? When I run this sample code after configuring the relevant environment, there is an error, and the program error is as follows:
UserWarning:
NVIDIA GeForce RTX 3060 with CUDA capability sm_86 is not compatible with the current PyTorch installation.
The current PyTorch install supports CUDA capabilities sm_37 sm_50 sm_60 sm_70 sm_75.
If you want to use the NVIDIA GeForce RTX 3060 GPU with PyTorch, please check the instructions at https://pytorch.org/get-started/locally/
relevant environment：ubuntu 20.04
GPU:NVIDIA RTX3060 12G
tensorflow-gpu-2.4.0
cuda:11.0
cuDNN:8.0
pytorch:1.7.1

I think the GPU you are currently using should be able to run the code in this repo. I use Quadro P6000, pytorch = 1.8.1,  tensorflow-gpu=2.3.0, cuda=10.2.89, and cudnn=<IP_ADDRESS>. I guess the problem may be related to CUDA. I think you should also check the local configuration according to the link of pytorch given to you.


Compilation error after updating the pod to version 9.0.0

I get a compilation error on UIDevice.orientationDidChangeNotification in QRCodeReader.swift (line 165).
Am I the only one as I didn't see any mention of this?
A fix seems to update it with NSNotification.Name.UIDeviceOrientationDidChange

The v9.0.0 is compatible with Swift 4.2.
See #152.

Indeed, I don't know why it was on 4.0
Thanks


Train in Keras with Stateless CuDNN GRU and infer using tensorflow with stateful CuDNN GRU

Hi
I am facing a problem with using Stateful and Steteless CuDNN GRU
I trained my model in Keras with CuDNN GRU's using let's say 1000 time steps and stateful=False.
During inference, to keep the model real-time, I changed the time_steps to 1, and stateful=true to load the model and it's weights. I converted this model to tensorflow protobuf using convert_variables_to_constants() function to freeze the graph and write_graph() to write it to a protobuf file.
The problem I am facing currently is that I am getting same results whether or not stateful = True or False during inference. which means I am missing something while converting keras model to tensorflow model. Is there any special consideration needed with the conversion process?
While running tensorflow session, along with the output, do I need to get states of all the CuDNN GRU layers and pass in these states with the next input? If yes, how can I get these states from the graph. It's not clear from the nodes of cudnn layer, which of it might contain state information.
Or is there something very fundamental I am missing here? Any help is very much appreciated.
Tensorflow version : 1.14.0
Keras version : 2.2.4
Thanks

This question is better asked on StackOverflow since it is not a bug or feature request. There is also a larger community that reads questions there.
Thanks!


[1.11.2] Dispenser Block not updating

When you use a dispenser to place water from a bucket, the places water gets recognized by the server but is not recognized by the client. Mobs swim in the liquid (hover up and down client-side). The same happens when trees get fertilized with bonemeal from a dispenser. This can be reproduced easily.

I cannot reproduce this on the latest 1.11.2 build. On which version did you run into this problem? Please test again with the latest test.


Migrate of nothing on fresh install

I currently installed new log but it does nothing on migration
Screenshots
If applicable, add screenshots to help explain your problem.
Versions (please complete the following information)

PHP: 7.4.28
Database: mysql
Laravel: 8
Package: laravellog

Stack Trace
The full stack trace of the thrown exception.

You can't be on v4 of the package as you are using PHP7.4.
https://github.com/spatie/laravel-activitylog/blob/4.0.0/composer.json
So you should also refer to the correct version of the docs matching your installed package version.
https://spatie.be/docs/laravel-activitylog/v3/introduction


How can I use crates other than optee_utee on TA side?

Hi! I make a little project with this rust-optee-trustzone-sdk.
But when I try to use extern crate like crypto or rand in TA, I can build the host and TA but it panic with generic errno, 0xffff0000.
How can I use extern crate in this sdk?
I know dynamic link is not allowed in TA, so I can't use other crate than optee_utee?
Error message in normal world is like this:
Error: Non-specific cause. (error code 0xffff0000)
and message in secure world is like this:
D/TC:? 0 tee_ta_init_pseudo_ta_session:299 Lookup pseudo TA 1234f200-2450-11e4-abe2-0002a5d5c51b
D/TC:? 0 ldelf_load_ldelf:91 ldelf load address 0x104000
D/LD:  ldelf:134 Loading TA 1234f200-2450-11e4-abe2-0002a5d5c51b
D/TC:? 0 ldelf_syscall_open_bin:140 Lookup user TA ELF 1234f200-2450-11e4-abe2-0002a5d5c51b (Secure Storage TA)
D/TC:? 0 ldelf_syscall_open_bin:144 res=0xffff0008
D/TC:? 0 ldelf_syscall_open_bin:140 Lookup user TA ELF 1234f200-2450-11e4-abe2-0002a5d5c51b (REE)
D/TC:? 0 ldelf_syscall_open_bin:144 res=0
D/LD:  load_main:1090 Reloading TA 1234f200-2450-11e4-abe2-0002a5d5c51b as legacy TA
D/TC:? 0 ldelf_syscall_open_bin:140 Lookup user TA ELF 1234f200-2450-11e4-abe2-0002a5d5c51b (Secure Storage TA)
D/TC:? 0 ldelf_syscall_open_bin:144 res=0xffff0008
D/TC:? 0 ldelf_syscall_open_bin:140 Lookup user TA ELF 1234f200-2450-11e4-abe2-0002a5d5c51b (REE)
D/TC:? 0 ldelf_syscall_open_bin:144 res=0
D/TC:0 0 abort_handler:518 [abort] abort in User mode (TA will panic)
E/TC:? 0
E/TC:? 0 User mode data-abort at address 0x82b64c8 (translation fault)
E/TC:? 0  fsr 0x00000005  ttbr0 0x0e19786a  ttbr1 0x0e19006a  cidr 0x2
E/TC:? 0  cpu #0          cpsr 0x20000130
E/TC:? 0  r0 0x02060fcf      r4 0x0010f088    r8 0x0010f0b4   r12 0x00000000
E/TC:? 0  r1 0x00000000      r5 0x0010ee48    r9 0x00000000    sp 0x00103e80
E/TC:? 0  r2 0x0013258c      r6 0x0010ee44   r10 0x00000000    lr 0x00107d43
E/TC:? 0  r3 0x082b64c8      r7 0x00103e98   r11 0x00000000    pc 0x00107aa8
E/TC:? 0  region  0: va 0x00100000 pa 0x0e100000 size 0x001000 flags ---R-X
E/TC:? 0  region  1: va 0x00102000 pa 0x0e300000 size 0x002000 flags rw-RW-
E/TC:? 0  region  2: va 0x00104000 pa 0x0e302000 size 0x00b000 flags r-x---
E/TC:? 0  region  3: va 0x0010f000 pa 0x0e30d000 size 0x001000 flags rw-RW-
E/TC:? 0  region  4: va 0x00110000 pa 0x0e30e000 size 0x004000 flags rw-RW-
E/TC:? 0  region  5: va 0x00114000 pa 0x0e312000 size 0x001000 flags r--R--
E/TC:? 0  region  6: va 0x00115000 pa 0x0e313000 size 0x01e000 flags r-xR--
E/TC:? 0  region  7: va 0x00133000 pa 0x0e331000 size 0x00b000 flags rw-RW-
E/TC:? 0  region  8: va 0x0013e000 pa 0x0e33c000 size 0x001000 flags rw-RW-
E/TC:? 0 ldelf_init_with_ldelf:122 ldelf panicked
D/TC:? 0 tee_ta_open_session:720 init session failed 0xffff0000
D/TC:0   console_itr_cb:109 cpu 0: got 0x3

Hi, generally speaking, the SDK should be compatible with (at least) some external crates, and our serde example is using the external crate serde. Please refer to the example to double-check you are using the extra crate correctly.
Also,  by taking a quick look at your log, your TA is getting the error 0xffff0008, which is the item not found error. Though I'm not 100% sure, it looks like the TA is not compiled correctly, so probably you can go over your logs again to see what's happening when building the TA.

Hi, generally speaking, the SDK should be compatible with (at least) some external crates, and our serde example is using the external crate serde. Please refer to the example to double-check you are using the extra crate correctly.
Also,  by taking a quick look at your log, your TA is getting the error 0xffff0008, which is the item not found error. Though I'm not 100% sure, it looks like the TA is not compiled correctly, so probably you can go over your logs again to see what's happening when building the TA.

First,  I look around serde example code, but some linker script make confusing me.
There's some extra work other than add packagename=VERSION on Cargo.toml?
Second,  I think item not found is just for lookup walking. When I try to run normal TA, It also poped up, so it;s not main cause of error.
Here is message when I run optee_example_hello_world: There's also 0xffff0008 exist.
D/TC:? 0 tee_ta_init_pseudo_ta_session:299 Lookup pseudo TA 8aaaf200-2450-11e4-abe2-0002a5d5c51b
D/TC:? 0 ldelf_load_ldelf:91 ldelf load address 0x104000
D/LD:  ldelf:134 Loading TA 8aaaf200-2450-11e4-abe2-0002a5d5c51b
D/TC:? 0 ldelf_syscall_open_bin:140 Lookup user TA ELF 8aaaf200-2450-11e4-abe2-0002a5d5c51b (Secure Storage TA)
D/TC:? 0 ldelf_syscall_open_bin:144 res=0xffff0008
D/TC:? 0 ldelf_syscall_open_bin:140 Lookup user TA ELF 8aaaf200-2450-11e4-abe2-0002a5d5c51b (REE)
D/TC:? 0 ldelf_syscall_open_bin:144 res=0
D/LD:  ldelf:168 ELF (8aaaf200-2450-11e4-abe2-0002a5d5c51b) at 0x11a000
D/TA:  TA_CreateEntryPoint:39 has been called
D/TA:  TA_OpenSessionEntryPoint:68 has been called
I/TA: Hello World!
D/TA:  inc_value:105 has been called
I/TA: Got value: 42 from NW
I/TA: Increase value to: 43
D/TC:? 0 tee_ta_close_session:514 csess 0xb90916b0 id 1
D/TC:? 0 tee_ta_close_session:533 Destroy session
I/TA: Goodbye!
D/TA:  TA_DestroyEntryPoint:50 has been called
D/TC:? 0 destroy_context:310 Destroy TA ctx (0xb9091670)

Thanks for your help.

First,  I look around serde example code, but some linker script make confusing me.
There's some extra work other than add packagename=VERSION on Cargo.toml?
Second,  I think item not found is just for lookup walking. When I try to run normal TA, It also poped up, so it;s not main cause of error.
Here is message when I run optee_example_hello_world: There's also 0xffff0008 exist.
D/TC:? 0 tee_ta_init_pseudo_ta_session:299 Lookup pseudo TA 8aaaf200-2450-11e4-abe2-0002a5d5c51b
D/TC:? 0 ldelf_load_ldelf:91 ldelf load address 0x104000
D/LD:  ldelf:134 Loading TA 8aaaf200-2450-11e4-abe2-0002a5d5c51b
D/TC:? 0 ldelf_syscall_open_bin:140 Lookup user TA ELF 8aaaf200-2450-11e4-abe2-0002a5d5c51b (Secure Storage TA)
D/TC:? 0 ldelf_syscall_open_bin:144 res=0xffff0008
D/TC:? 0 ldelf_syscall_open_bin:140 Lookup user TA ELF 8aaaf200-2450-11e4-abe2-0002a5d5c51b (REE)
D/TC:? 0 ldelf_syscall_open_bin:144 res=0
D/LD:  ldelf:168 ELF (8aaaf200-2450-11e4-abe2-0002a5d5c51b) at 0x11a000
D/TA:  TA_CreateEntryPoint:39 has been called
D/TA:  TA_OpenSessionEntryPoint:68 has been called
I/TA: Hello World!
D/TA:  inc_value:105 has been called
I/TA: Got value: 42 from NW
I/TA: Increase value to: 43
D/TC:? 0 tee_ta_close_session:514 csess 0xb90916b0 id 1
D/TC:? 0 tee_ta_close_session:533 Destroy session
I/TA: Goodbye!
D/TA:  TA_DestroyEntryPoint:50 has been called
D/TC:? 0 destroy_context:310 Destroy TA ctx (0xb9091670)

Thanks for your help.

Hi @ChoKyuWon
It seems that ldelf panic occurs.ldelf is a user mode ELF loader in OPTEE OS(reference here).

We have upgraded the sdk to OPTEE 3.11.0.TAs built with previous sdk will cause a ldelf panic when running on newer OPTEE OS(such as OPTEE 3.11.0).Maybe you could try the latest sdk version.
If not works,debugging the ldelf using GDB may help(reference here)

Best Regards,
Yuan

@DemesneGH  Thanks! upgrade SDK is the perfect solution for me.


Some logs are sent as nested JSON objects

Steps to reproduce

start a working COOL board and make sure it sends some logs properly over a working Wifi connection, with a short logInterval
interrupt the Wifi connection (unplug the router, stop your phone's hotspot...)
wait for the board LED to blink read (indicating : "I can't send this message but I'll save it for later)
plug the Wifi again after some time
wait for the COOL Board to blink green again (indicating: "I have a working network connection, so I'll happily send log again and replay your saved logs")

Expected behavior

the board shadow should look has follow:

{
  "timestamp": "some timestamp"
  "someMetric": "some value",
}

Actual behavior
{
  "timestamp": "some timestamp",
  "someMetric": "some value",
  "state": {
    "reported": {
      "timestamp": "some timestamp",
      "someMetric": "some value",
    }
  }
}

Notes
This seems to affect only saved logs that are being replayed, but we we could very well have some other scenarios
Example
https://demo.lecool.menu/devices/5c:cf:7f:68:15:ff

@Kameeno, you're up for testing this.


build: Remove prerelease tag from packages

Summary | Résumé
Current release-please configuration marks all packages as prerelease, this will hopefully stop that form happening.

Hmm the latest release generated seems to be normal, not sure if this is needed anymore.

@ethanWallace there is still something wonky going on the the SSR canary tag. Let's talk about it in dev sync!


Support line graphs

Perhaps I am missing something, but it seems that line graphs are not supported in pivot table charts. It would be useful to have them.

@marksweb Both Pie and Line charts are supported so I believe we can close this one


Update GH link

@jongio : Thanks for your contribution! The author(s) have been notified to review your proposed change.

#sign-off

@jongio: I'm sorry - only the author of this article, @craigshoemaker, can sign off on your changes. But we do have an exception process - if you are on the Microsoft content or product team for this product area, you can ask the PR review team to review and merge it by sending mail to the techdocprs alias.

thanks, @jongio!
#sign-off

Thanks, all. Merging in the repo is paused; this PR is in the queue to merge when merging resumes.


Session API requirements for Privilege-Level Changes, based on OWASP recommendations

A few features are missing from the Session api:

session key renewal
session purge

1. Session key renewal
Two of the most common events in a web application where there are "privilege-level changes" are login and logout, but there are others.  Each of these events requires the Session ID be renewed.  With this given, the Session API requires renewal functionality so that one may renew the session key on-demand.  Although the Session ID changes, state is preserved.
2. Session purge
Purging involves removing the session state AND the cookie (ie "purge").  Purging is done during the logout process, for instance.
If you'd like to see an example implementation, such functionality exists in actix-web and an example useful for integration testing can be found here.

Purge exists and is currently called destroy. The destroy flag on session is used by the tide session middleware to delete the session from the backing store and remove the cookie: https://github.com/http-rs/tide/blob/master/examples/sessions.rs#L32
Session key renewal is called Session::regenerate.
Let me know if there's something missing from either of these, or if the naming is unclear. There's a lot to get right in sessions and I wouldn't be at all surprised if there were bugs or missing features

@Dowwie Are the names you used (purge vs destroy, renew vs regenerate) standardized enough that you think it's worth changing the API?

They were the best that I could come up with.  I'm not aware of any standard.  I think that regenerate and destroy are fine!

Closing this issue then, but please do keep reporting shortcomings you find!


Comments in dependency section of Cargo.toml get removed

The Trustfall project has some meaningful comments in Cargo.toml — some notes on which dependencies are re-exported in our public API vs internal-only, notes on why certain crates and features are enabled, etc.
These comments get wiped out when cargo autoinherit is executed, which is not desirable. The comments get wiped out even if the surrounding dependencies didn't need to change, which is extra unfortunate.
To repro:
git clone git@github.com:obi1kenobi/trustfall.git
cd trustfall
git checkout 5e915a5e3dd6cddb84b9db32f7ab4c8860d7fc4d  # recent `main` branch head
cargo autoinherit

That will produce a diff that includes the following:
diff --git a/Cargo.toml b/Cargo.toml
index 511f0a7..0aa94c7 100644
--- a/Cargo.toml
+++ b/Cargo.toml
@@ -21,8 +21,6 @@ authors = ["Predrag Gruevski<EMAIL_ADDRESS> license = "Apache-2.0"

 [workspace.dependencies]
-# The dependencies below are part of our public API.
-# Bumping a major version here requires our own major version bump.
 anyhow = "1.0.71"
 async-graphql-parser = "7.0"
 async-graphql-value = "7.0"
@@ -30,9 +28,6 @@ serde = "1.0.185"
 serde_json = "1.0.96"
 thiserror = "1.0.30"
 regex = "1.9.1"
-
-# The dependencies below are internal-only.
-# Bumping major versions here should be safe.
 itertools = "0.12.1"
 ron = "0.8.0"
 similar-asserts = "1.4.2"

While fixing this I spotted another issue, which has been patched in #8.
Running cargo-autoinherit on trustfall should work perfectly now!

Amazing, thank you Luca! This tool is awesome and I'm super glad you built it.


create a simple breadcrumb composable utility for core nuxt

Describe the feature
Feature
There has never been an elegant way to to get breadcrumbs without creating custom code. It would be nice to see a simple utility that creates basic breadcrumbs that has the title from meta title information, if not fallbacks to name of route. Maybe this sounds silly but it would nice to have it baked in so then we use it on our projects.
Ideas

Use meta title as main source of truth, as this can be added and customized using useHead() which everyone uses.
Make the first item in array the index *(Home) then next route, next route etc.

For dynamic routes it might be a little more tricky but I am open to ideas.
interface Breadcrumb {
   title: string
   path: string
}[]

const breadcrumbs = useRouteBreadcrumbs()

Name space can be modified to liking but would like to see a utility built in the core of nuxt vs creating a utilty every project.
Ideas are welcome!
Thanks 💚
Additional information

[ ] Would you be willing to help implement this feature?
[ ] Could this feature be implemented as a module?

Final checks

[X] Read the contribution guide.
[X] Check existing discussions and issues.

I think this is something that can and should be solved in module land.
There are certain limitations to it as well which make it unsuitable for a core framework feature:

needs to use route meta for the data which is not the convention (you can't use useHead without pre-fetching the other pages)
it doesn't work on dynamic routes

The module Nuxt SEO Kit ships with these automated Breadcrumbs. It also publishes the Schema.org needed for them. I'll be revamping the API on it soon but is works.
Going to close this off


CVAT new UI: Cannot read property 'annotations' of null

My actions before raising this issue

[x] Read/searched the docs
[x] Searched past issues

TypeError: Cannot read property 'annotations' of null
Expected Behaviour
N/A
Current Behaviour
Exception occurs
Possible Solution

Steps to Reproduce (for bugs)
N/A
Context

Your Environment

Git hash commit (git log -1): 35badcca5588d22bbe7bc0e6d52637053e55f40c
Docker version docker version: Docker version 19.03.8, build afacb8b7f0
Are you using Docker Swarm or Kubernetes? No
Operating System and version (e.g. Linux, Windows, MacOS): Ubuntu 18.04
Code example or link to GitHub repo or gist to reproduce problem:
Other diagnostic information / logs:
JS stack trace:

TypeError: Cannot read property 'annotations' of null
    at Lo.beforeUnloadCallback (https://cvat.org/cvat-ui.min.js:72:1177773)

Next steps
You may join our Gitter channel for community support.

Steps to reproduce:

Open tool (DO NOT OPEN A JOB)
Go to settings
Close the tab

beforeUnloadCallback is called and tries to read property annotations of jobInstance that is null.
It will be resolved with #1705.


[Bug]: Mapping binding patter does not support escaped strings

Description
type FuelEvent record {
    @xmldata:Attribute
    string employeeId;
    int s\:odometerReading;
    decimal s\:gallons;
    decimal s\:gasPrice;
};
foreach var {employeeId, s\:odometerReading} in fuelEvents.s\:FuelEvent {
}

The above throws error saying {ballerina}TypeCastError {"message":"incompatible types: '()' cannot be cast to 'int'"}
I am able to access the field if I use capture binding pattern
Steps to Reproduce
No response
Affected Version(s)
2201.3.0-rc3
OS, DB, other environment details and versions
No response
Related area
-> Compilation
Related issue(s) (optional)
No response
Suggested label(s) (optional)
No response
Suggested assignee(s) (optional)
No response

Reproducible with
type Details record {
    int id;
    string emp\:name;
};

public function main() {
    Details[] fuelEvents = [
        {
            id: 2,
            emp\:name: "Jo"
        }
    ];
    foreach var {id, emp\:name} in fuelEvents {
    }
}


layers: Update concurrent unordered map from vvl

CI Vulkan-ExtensionLayer build queued with queue ID 58795.

CI Vulkan-ExtensionLayer build queued with queue ID 58795.

CI Vulkan-ExtensionLayer build # 358 running.

CI Vulkan-ExtensionLayer build # 358 failed.

CI Vulkan-ExtensionLayer build queued with queue ID 59415.

CI Vulkan-ExtensionLayer build queued with queue ID 59415.

CI Vulkan-ExtensionLayer build # 362 running.

CI Vulkan-ExtensionLayer build # 362 failed.

CI Vulkan-ExtensionLayer build queued with queue ID 59457.

CI Vulkan-ExtensionLayer build queued with queue ID 59457.

CI Vulkan-ExtensionLayer build # 363 running.

CI Vulkan-ExtensionLayer build # 363 failed.

CI Vulkan-ExtensionLayer build # 366 running.

CI Vulkan-ExtensionLayer build # 366 failed.

CI Vulkan-ExtensionLayer build queued with queue ID 59586.

CI Vulkan-ExtensionLayer build queued with queue ID 59586.

CI Vulkan-ExtensionLayer build # 367 running.

CI Vulkan-ExtensionLayer build # 367 failed.

CI Vulkan-ExtensionLayer build queued with queue ID 59607.

CI Vulkan-ExtensionLayer build queued with queue ID 59607.

CI Vulkan-ExtensionLayer build # 368 failed.

CI Vulkan-ExtensionLayer build # 368 failed.

ERROR: unexpected exception: _run(/home/lunarg/Android/Sdk/platform-tools/adb -s<PHONE_NUMBER>399 install -r -g -t /home/lunarg/.jenkins/wvel/Debug32/Vulkan-ExtensionLayer/build-android/VulkanExtensionLayerTests.apk) return 1, stdout=Performing Streamed Install
, stderr=adb: failed to install /home/lunarg/.jenkins/wvel/Debug32/Vulkan-ExtensionLayer/build-android/VulkanExtensionLayerTests.apk: Failure [INSTALL_FAILED_INSUFFICIENT_STORAGE: Package couldn't be installed in /data/app/com.example.VulkanExtensionLayerTests-_6TyTNHwnhmS0uE5SQXuPw==: Package com.example.VulkanExtensionLayerTests could not be assigned a valid UID]

Looks like an issue with Android CI?

CI Vulkan-ExtensionLayer build queued with queue ID 59677.

CI Vulkan-ExtensionLayer build # 370 running.


bundle exec shouldn't run Bundler.setup just setting the correct rubyopts options is enough

:+1: Nice!

The PR is generated from my 1-1-stable branch but I'm pushing it to master. Anyway should go to both branches. No idea what github is doing here :P

@sferik check the commit message I sent a Gemfile that shows a 17% speedup with this change

Merge it, merge it, merge it!

Nice! I'll pull it into master and cherry-pick it into 1-1-stable.


Normalize source URLs

Fixes #115.
As said in the linked issue we should discus if this is enough normalization. Also I am not sure if it is a good idea to change values in the validation step.
Besides do the normalization I also adapted the test file so that the new feature will be tested. This test fails with the old version version of cargo-deny and passes with the changes in this PR.

CI cached a bug it seams. texture-synthesis is OK with the current release of cargo-deny but not with my modified version. I will take a look.
➜  texture-synthesis git:(main) ~/git/cargo-deny/target/debug/cargo-deny check
error: detected 'git' source not specifically allowed
   ┌─ /home/stefano/git/texture-synthesis/Cargo.lock:29:16
   │
29 │ img_hash 2.1.0 git+https://github.com/EmbarkStudios/img_hash.git?rev=c40da78#c40da78946840c810543e6ec53967afb7adafd74
   │                ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ source
   │
   = img_hash v2.1.0
     └── (dev) texture-synthesis v0.8.0
         └── texture-synthesis-cli v0.8.0

warning: allowed source was not encountered
   ┌─ /home/stefano/git/texture-synthesis/deny.toml:45:5
   │
45 │     "https://github.com/EmbarkStudios/img_hash.git",
   │     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ no crate source matched these criteria

advisories ok, bans ok, licenses ok, sources FAILED

Don't worry about, that repo is just outdated.


Update opensds.conf with telemetry configs before starting hotpot services

Describe the bug
As of now hotpot process starts before telemtry installer tasks update opensds.conf.
need to change the order , so that when hotpot processes starts it has the inof about telemetry configs.

/assign @NajmudheenCT


Could you generate onedarkpro theme for alacritty and kitty?

I use alacritty, the theme is nice for me

Me too. The hot reloading of config files is amazing. I actually have onedark and onelight bundled in my config and then have a command prompt which changes from dark->light or vice versa