HDDS-1371. Download RocksDB checkpoint from OM Leader to Follower.

Posted initial patch. Will add unit tests soon.

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Comment

0
reexec
26
Docker mode activated.

_ Prechecks _

+1
@author
0
The patch does not contain any @author tags.

+1
test4tests
0
The patch appears to include 1 new or modified test files.

_ trunk Compile Tests _

0
mvndep
24
Maven dependency ordering for branch

+1
mvninstall
1117
trunk passed

+1
compile
967
trunk passed

+1
checkstyle
183
trunk passed

+1
mvnsite
225
trunk passed

+1
shadedclient
1128
branch has no errors when building and testing our client artifacts.

+1
findbugs
261
trunk passed

+1
javadoc
162
trunk passed

_ Patch Compile Tests _

0
mvndep
23
Maven dependency ordering for patch

+1
mvninstall
162
the patch passed

+1
compile
949
the patch passed

+1
javac
949
the patch passed

+1
checkstyle
230
the patch passed

+1
mvnsite
193
the patch passed

+1
whitespace
0
The patch has no whitespace issues.

+1
xml
1
The patch has no ill-formed XML file.

+1
shadedclient
614
patch has no errors when building and testing our client artifacts.

+1
findbugs
302
the patch passed

+1
javadoc
151
the patch passed

_ Other Tests _

+1
unit
70
common in the patch passed.

+1
unit
35
client in the patch passed.

+1
unit
45
common in the patch passed.

+1
unit
51
ozone-manager in the patch passed.

+1
unit
41
ozone-recon in the patch passed.

+1
asflicense
41
The patch does not generate ASF License warnings.

6849

Subsystem
Report/Notes

Docker
Client=17.05.0-ce Server=17.05.0-ce base: https://builds.apache.org/job/hadoop-multibranch/job/PR-703/1/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/703

Optional Tests
dupname  asflicense  compile  javac  javadoc  mvninstall  mvnsite  unit  shadedclient  findbugs  checkstyle  xml

uname
Linux 4d168ad1eda8 4.4.0-139-generic #165-Ubuntu SMP Wed Oct 24 10:58:50 UTC 2018 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
personality/hadoop.sh

git revision
trunk / dc013f7

maven
version: Apache Maven 3.3.9

Default Java
1.8.0_191

findbugs
v3.1.0-RC1

Test Results
https://builds.apache.org/job/hadoop-multibranch/job/PR-703/1/testReport/

Max. process+thread count
458 (vs. ulimit of 5500)

modules
C: hadoop-hdds/common hadoop-ozone/client hadoop-ozone/common hadoop-ozone/ozone-manager hadoop-ozone/ozone-recon U: .

Console output
https://builds.apache.org/job/hadoop-multibranch/job/PR-703/1/console

Powered by
Apache Yetus 0.9.0 http://yetus.apache.org

This message was automatically generated.

Thank you @arp7 for the review. Addressed your review comments and added a unit test.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Comment

0
reexec
46
Docker mode activated.

_ Prechecks _

+1
@author
0
The patch does not contain any @author tags.

+1
test4tests
0
The patch appears to include 3 new or modified test files.

_ trunk Compile Tests _

0
mvndep
60
Maven dependency ordering for branch

+1
mvninstall
1138
trunk passed

+1
compile
1383
trunk passed

+1
checkstyle
268
trunk passed

+1
mvnsite
366
trunk passed

+1
shadedclient
1560
branch has no errors when building and testing our client artifacts.

0
findbugs
0
Skipped patched modules with no Java source: hadoop-ozone/integration-test

+1
findbugs
352
trunk passed

+1
javadoc
258
trunk passed

_ Patch Compile Tests _

0
mvndep
30
Maven dependency ordering for patch

-1
mvninstall
27
integration-test in the patch failed.

+1
compile
1408
the patch passed

+1
javac
1408
the patch passed

+1
checkstyle
237
the patch passed

+1
mvnsite
291
the patch passed

+1
whitespace
0
The patch has no whitespace issues.

+1
xml
1
The patch has no ill-formed XML file.

+1
shadedclient
810
patch has no errors when building and testing our client artifacts.

0
findbugs
0
Skipped patched modules with no Java source: hadoop-ozone/integration-test

+1
findbugs
372
the patch passed

+1
javadoc
243
the patch passed

_ Other Tests _

+1
unit
112
common in the patch passed.

+1
unit
44
client in the patch passed.

+1
unit
55
common in the patch passed.

-1
unit
1167
integration-test in the patch failed.

+1
unit
82
ozone-manager in the patch passed.

+1
unit
81
ozone-recon in the patch passed.

+1
asflicense
84
The patch does not generate ASF License warnings.

10358

Reason
Tests

Failed junit tests
hadoop.ozone.web.client.TestKeys

hadoop.ozone.client.rpc.TestOzoneRpcClientWithRatis

hadoop.ozone.TestOzoneConfigurationFields

hadoop.ozone.client.rpc.TestCloseContainerHandlingByClient

hadoop.ozone.client.rpc.TestSecureOzoneRpcClient

hadoop.ozone.client.rpc.TestCommitWatcher

hadoop.ozone.client.rpc.TestReadRetries

Subsystem
Report/Notes

Docker
Client=17.05.0-ce Server=17.05.0-ce base: https://builds.apache.org/job/hadoop-multibranch/job/PR-703/2/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/703

Optional Tests
dupname  asflicense  compile  javac  javadoc  mvninstall  mvnsite  unit  shadedclient  findbugs  checkstyle  xml

uname
Linux eedce58a368f 4.4.0-141-generic #167~14.04.1-Ubuntu SMP Mon Dec 10 13:20:24 UTC 2018 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
personality/hadoop.sh

git revision
trunk / 5379d85

maven
version: Apache Maven 3.3.9

Default Java
1.8.0_191

findbugs
v3.1.0-RC1

mvninstall
https://builds.apache.org/job/hadoop-multibranch/job/PR-703/2/artifact/out/patch-mvninstall-hadoop-ozone_integration-test.txt

unit
https://builds.apache.org/job/hadoop-multibranch/job/PR-703/2/artifact/out/patch-unit-hadoop-ozone_integration-test.txt

Test Results
https://builds.apache.org/job/hadoop-multibranch/job/PR-703/2/testReport/

Max. process+thread count
3938 (vs. ulimit of 5500)

modules
C: hadoop-hdds/common hadoop-ozone/client hadoop-ozone/common hadoop-ozone/integration-test hadoop-ozone/ozone-manager hadoop-ozone/ozone-recon U: .

Console output
https://builds.apache.org/job/hadoop-multibranch/job/PR-703/2/console

Powered by
Apache Yetus 0.9.0 http://yetus.apache.org

This message was automatically generated.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Comment

0
reexec
27
Docker mode activated.

_ Prechecks _

+1
dupname
0
No case conflicting files found.

+1
@author
0
The patch does not contain any @author tags.

+1
test4tests
0
The patch appears to include 2 new or modified test files.

_ trunk Compile Tests _

0
mvndep
28
Maven dependency ordering for branch

+1
mvninstall
528
trunk passed

+1
compile
278
trunk passed

+1
checkstyle
76
trunk passed

+1
mvnsite
0
trunk passed

+1
shadedclient
911
branch has no errors when building and testing our client artifacts.

+1
javadoc
182
trunk passed

0
spotbugs
355
Used deprecated FindBugs config; considering switching to SpotBugs.

+1
findbugs
608
trunk passed

_ Patch Compile Tests _

0
mvndep
73
Maven dependency ordering for patch

+1
mvninstall
591
the patch passed

+1
compile
331
the patch passed

+1
javac
331
the patch passed

-0
checkstyle
48
hadoop-hdds: The patch generated 1 new + 0 unchanged - 0 fixed = 1 total (was 0)

-0
checkstyle
41
hadoop-ozone: The patch generated 5 new + 0 unchanged - 0 fixed = 5 total (was 0)

+1
mvnsite
0
the patch passed

+1
whitespace
0
The patch has no whitespace issues.

+1
xml
2
The patch has no ill-formed XML file.

+1
shadedclient
756
patch has no errors when building and testing our client artifacts.

+1
javadoc
166
the patch passed

+1
findbugs
655
the patch passed

_ Other Tests _

-1
unit
1041
hadoop-hdds in the patch failed.

-1
unit
153
hadoop-ozone in the patch failed.

+1
asflicense
47
The patch does not generate ASF License warnings.

6737

Reason
Tests

Failed junit tests
hadoop.hdds.server.events.TestEventWatcher

hadoop.ozone.om.TestOzoneManagerHttpServer

Subsystem
Report/Notes

Docker
Client=17.05.0-ce Server=17.05.0-ce base: https://builds.apache.org/job/hadoop-multibranch/job/PR-703/4/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/703

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient findbugs checkstyle xml

uname
Linux 7445e1a4280d 4.4.0-143-generic #169~14.04.2-Ubuntu SMP Wed Feb 13 15:00:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
personality/hadoop.sh

git revision
trunk / 9122b9b

Default Java
1.8.0_212

checkstyle
https://builds.apache.org/job/hadoop-multibranch/job/PR-703/4/artifact/out/diff-checkstyle-hadoop-hdds.txt

checkstyle
https://builds.apache.org/job/hadoop-multibranch/job/PR-703/4/artifact/out/diff-checkstyle-hadoop-ozone.txt

unit
https://builds.apache.org/job/hadoop-multibranch/job/PR-703/4/artifact/out/patch-unit-hadoop-hdds.txt

unit
https://builds.apache.org/job/hadoop-multibranch/job/PR-703/4/artifact/out/patch-unit-hadoop-ozone.txt

Test Results
https://builds.apache.org/job/hadoop-multibranch/job/PR-703/4/testReport/

Max. process+thread count
1290 (vs. ulimit of 5500)

modules
C: hadoop-hdds/common hadoop-hdds/framework hadoop-ozone/client hadoop-ozone/common hadoop-ozone/integration-test hadoop-ozone/ozone-manager hadoop-ozone/ozone-recon U: .

Console output
https://builds.apache.org/job/hadoop-multibranch/job/PR-703/4/console

versions
git=2.7.4 maven=3.3.9 findbugs=3.1.0-RC1

Powered by
Apache Yetus 0.10.0 http://yetus.apache.org

This message was automatically generated.

/retest

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Comment

0
reexec
814
Docker mode activated.

_ Prechecks _

+1
dupname
0
No case conflicting files found.

+1
@author
0
The patch does not contain any @author tags.

+1
test4tests
0
The patch appears to include 2 new or modified test files.

_ trunk Compile Tests _

0
mvndep
69
Maven dependency ordering for branch

+1
mvninstall
588
trunk passed

+1
compile
288
trunk passed

+1
checkstyle
84
trunk passed

+1
mvnsite
0
trunk passed

+1
shadedclient
950
branch has no errors when building and testing our client artifacts.

+1
javadoc
168
trunk passed

0
spotbugs
338
Used deprecated FindBugs config; considering switching to SpotBugs.

+1
findbugs
530
trunk passed

_ Patch Compile Tests _

0
mvndep
29
Maven dependency ordering for patch

+1
mvninstall
508
the patch passed

+1
compile
288
the patch passed

+1
javac
288
the patch passed

-0
checkstyle
41
hadoop-hdds: The patch generated 1 new + 0 unchanged - 0 fixed = 1 total (was 0)

-0
checkstyle
44
hadoop-ozone: The patch generated 5 new + 0 unchanged - 0 fixed = 5 total (was 0)

+1
mvnsite
0
the patch passed

+1
whitespace
0
The patch has no whitespace issues.

+1
xml
1
The patch has no ill-formed XML file.

+1
shadedclient
751
patch has no errors when building and testing our client artifacts.

+1
javadoc
168
the patch passed

+1
findbugs
548
the patch passed

_ Other Tests _

-1
unit
248
hadoop-hdds in the patch failed.

-1
unit
163
hadoop-ozone in the patch failed.

+1
asflicense
46
The patch does not generate ASF License warnings.

6519

Reason
Tests

Failed junit tests
hadoop.hdds.scm.TestStorageContainerManagerHttpServer

hadoop.ozone.om.TestOzoneManagerHttpServer

Subsystem
Report/Notes

Docker
Client=17.05.0-ce Server=17.05.0-ce base: https://builds.apache.org/job/hadoop-multibranch/job/PR-703/5/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/703

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient findbugs checkstyle xml

uname
Linux 67e7a18fa221 4.4.0-141-generic #167~14.04.1-Ubuntu SMP Mon Dec 10 13:20:24 UTC 2018 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
personality/hadoop.sh

git revision
trunk / 277e9a8

Default Java
1.8.0_212

checkstyle
https://builds.apache.org/job/hadoop-multibranch/job/PR-703/5/artifact/out/diff-checkstyle-hadoop-hdds.txt

checkstyle
https://builds.apache.org/job/hadoop-multibranch/job/PR-703/5/artifact/out/diff-checkstyle-hadoop-ozone.txt

unit
https://builds.apache.org/job/hadoop-multibranch/job/PR-703/5/artifact/out/patch-unit-hadoop-hdds.txt

unit
https://builds.apache.org/job/hadoop-multibranch/job/PR-703/5/artifact/out/patch-unit-hadoop-ozone.txt

Test Results
https://builds.apache.org/job/hadoop-multibranch/job/PR-703/5/testReport/

Max. process+thread count
1309 (vs. ulimit of 5500)

modules
C: hadoop-hdds/common hadoop-hdds/framework hadoop-ozone/client hadoop-ozone/common hadoop-ozone/integration-test hadoop-ozone/ozone-manager hadoop-ozone/ozone-recon U: .

Console output
https://builds.apache.org/job/hadoop-multibranch/job/PR-703/5/console

versions
git=2.7.4 maven=3.3.9 findbugs=3.1.0-RC1

Powered by
Apache Yetus 0.10.0 http://yetus.apache.org

This message was automatically generated.

/retest

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Comment

0
reexec
63
Docker mode activated.

_ Prechecks _

+1
dupname
0
No case conflicting files found.

+1
@author
0
The patch does not contain any @author tags.

+1
test4tests
0
The patch appears to include 2 new or modified test files.

_ trunk Compile Tests _

0
mvndep
27
Maven dependency ordering for branch

+1
mvninstall
535
trunk passed

+1
compile
287
trunk passed

+1
checkstyle
81
trunk passed

+1
mvnsite
0
trunk passed

+1
shadedclient
950
branch has no errors when building and testing our client artifacts.

+1
javadoc
176
trunk passed

0
spotbugs
382
Used deprecated FindBugs config; considering switching to SpotBugs.

+1
findbugs
587
trunk passed

_ Patch Compile Tests _

0
mvndep
30
Maven dependency ordering for patch

+1
mvninstall
473
the patch passed

+1
compile
291
the patch passed

+1
javac
291
the patch passed

-0
checkstyle
46
hadoop-ozone: The patch generated 1 new + 0 unchanged - 0 fixed = 1 total (was 0)

+1
mvnsite
0
the patch passed

+1
whitespace
0
The patch has no whitespace issues.

+1
xml
2
The patch has no ill-formed XML file.

+1
shadedclient
733
patch has no errors when building and testing our client artifacts.

-1
javadoc
62
hadoop-hdds in the patch failed.

-1
javadoc
101
hadoop-ozone generated 7 new + 8 unchanged - 0 fixed = 15 total (was 8)

-1
findbugs
86
hadoop-ozone in the patch failed.

_ Other Tests _

+1
unit
264
hadoop-hdds in the patch passed.

-1
unit
59
hadoop-ozone in the patch failed.

+1
asflicense
38
The patch does not generate ASF License warnings.

5314

Subsystem
Report/Notes

Docker
Client=17.05.0-ce Server=17.05.0-ce base: https://builds.apache.org/job/hadoop-multibranch/job/PR-703/6/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/703

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient findbugs checkstyle xml

uname
Linux 2f113408fdf3 4.4.0-141-generic #167~14.04.1-Ubuntu SMP Mon Dec 10 13:20:24 UTC 2018 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
personality/hadoop.sh

git revision
trunk / 0b1e288

Default Java
1.8.0_212

checkstyle
https://builds.apache.org/job/hadoop-multibranch/job/PR-703/6/artifact/out/diff-checkstyle-hadoop-ozone.txt

javadoc
https://builds.apache.org/job/hadoop-multibranch/job/PR-703/6/artifact/out/patch-javadoc-hadoop-hdds.txt

javadoc
https://builds.apache.org/job/hadoop-multibranch/job/PR-703/6/artifact/out/diff-javadoc-javadoc-hadoop-ozone.txt

findbugs
https://builds.apache.org/job/hadoop-multibranch/job/PR-703/6/artifact/out/patch-findbugs-hadoop-ozone.txt

unit
https://builds.apache.org/job/hadoop-multibranch/job/PR-703/6/artifact/out/patch-unit-hadoop-ozone.txt

Test Results
https://builds.apache.org/job/hadoop-multibranch/job/PR-703/6/testReport/

Max. process+thread count
403 (vs. ulimit of 5500)

modules
C: hadoop-hdds/common hadoop-hdds/framework hadoop-ozone/client hadoop-ozone/common hadoop-ozone/integration-test hadoop-ozone/ozone-manager hadoop-ozone/ozone-recon U: .

Console output
https://builds.apache.org/job/hadoop-multibranch/job/PR-703/6/console

versions
git=2.7.4 maven=3.3.9 findbugs=3.1.0-RC1

Powered by
Apache Yetus 0.10.0 http://yetus.apache.org

This message was automatically generated.

/retest

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Comment

0
reexec
43
Docker mode activated.

_ Prechecks _

+1
dupname
0
No case conflicting files found.

+1
@author
0
The patch does not contain any @author tags.

+1
test4tests
0
The patch appears to include 2 new or modified test files.

_ trunk Compile Tests _

0
mvndep
24
Maven dependency ordering for branch

+1
mvninstall
500
trunk passed

+1
compile
286
trunk passed

+1
checkstyle
81
trunk passed

+1
mvnsite
0
trunk passed

+1
shadedclient
970
branch has no errors when building and testing our client artifacts.

+1
javadoc
174
trunk passed

0
spotbugs
373
Used deprecated FindBugs config; considering switching to SpotBugs.

+1
findbugs
587
trunk passed

_ Patch Compile Tests _

0
mvndep
30
Maven dependency ordering for patch

+1
mvninstall
492
the patch passed

+1
compile
290
the patch passed

+1
javac
290
the patch passed

-0
checkstyle
42
hadoop-ozone: The patch generated 1 new + 0 unchanged - 0 fixed = 1 total (was 0)

+1
mvnsite
0
the patch passed

+1
whitespace
0
The patch has no whitespace issues.

+1
xml
1
The patch has no ill-formed XML file.

+1
shadedclient
724
patch has no errors when building and testing our client artifacts.

+1
javadoc
175
the patch passed

+1
findbugs
616
the patch passed

_ Other Tests _

+1
unit
269
hadoop-hdds in the patch passed.

-1
unit
1315
hadoop-ozone in the patch failed.

+1
asflicense
49
The patch does not generate ASF License warnings.

6876

Reason
Tests

Failed junit tests
hadoop.ozone.client.rpc.TestBCSID

hadoop.ozone.TestSecureOzoneCluster

hadoop.hdds.scm.pipeline.TestRatisPipelineProvider

hadoop.ozone.client.rpc.TestWatchForCommit

hadoop.ozone.TestOzoneConfigurationFields

hadoop.ozone.client.rpc.TestFailureHandlingByClient

Subsystem
Report/Notes

Docker
Client=17.05.0-ce Server=17.05.0-ce base: https://builds.apache.org/job/hadoop-multibranch/job/PR-703/7/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/703

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient findbugs checkstyle xml

uname
Linux 5add6ca39b8a 4.4.0-141-generic #167~14.04.1-Ubuntu SMP Mon Dec 10 13:20:24 UTC 2018 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
personality/hadoop.sh

git revision
trunk / 0b1e288

Default Java
1.8.0_212

checkstyle
https://builds.apache.org/job/hadoop-multibranch/job/PR-703/7/artifact/out/diff-checkstyle-hadoop-ozone.txt

unit
https://builds.apache.org/job/hadoop-multibranch/job/PR-703/7/artifact/out/patch-unit-hadoop-ozone.txt

Test Results
https://builds.apache.org/job/hadoop-multibranch/job/PR-703/7/testReport/

Max. process+thread count
4608 (vs. ulimit of 5500)

modules
C: hadoop-hdds/common hadoop-hdds/framework hadoop-ozone/client hadoop-ozone/common hadoop-ozone/integration-test hadoop-ozone/ozone-manager hadoop-ozone/ozone-recon U: .

Console output
https://builds.apache.org/job/hadoop-multibranch/job/PR-703/7/console

versions
git=2.7.4 maven=3.3.9 findbugs=3.1.0-RC1

Powered by
Apache Yetus 0.10.0 http://yetus.apache.org

This message was automatically generated.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Comment

0
reexec
47
Docker mode activated.

_ Prechecks _

+1
dupname
1
No case conflicting files found.

+1
@author
0
The patch does not contain any @author tags.

+1
test4tests
0
The patch appears to include 2 new or modified test files.

_ trunk Compile Tests _

0
mvndep
24
Maven dependency ordering for branch

+1
mvninstall
540
trunk passed

+1
compile
309
trunk passed

+1
checkstyle
84
trunk passed

+1
mvnsite
0
trunk passed

+1
shadedclient
941
branch has no errors when building and testing our client artifacts.

+1
javadoc
167
trunk passed

0
spotbugs
365
Used deprecated FindBugs config; considering switching to SpotBugs.

+1
findbugs
567
trunk passed

_ Patch Compile Tests _

0
mvndep
34
Maven dependency ordering for patch

+1
mvninstall
507
the patch passed

+1
compile
331
the patch passed

+1
javac
331
the patch passed

-0
checkstyle
44
hadoop-ozone: The patch generated 1 new + 0 unchanged - 0 fixed = 1 total (was 0)

+1
mvnsite
0
the patch passed

+1
whitespace
0
The patch has no whitespace issues.

+1
xml
2
The patch has no ill-formed XML file.

+1
shadedclient
797
patch has no errors when building and testing our client artifacts.

+1
javadoc
199
the patch passed

+1
findbugs
584
the patch passed

_ Other Tests _

+1
unit
251
hadoop-hdds in the patch passed.

-1
unit
1293
hadoop-ozone in the patch failed.

+1
asflicense
54
The patch does not generate ASF License warnings.

7000

Reason
Tests

Failed junit tests
hadoop.ozone.client.rpc.TestBCSID

hadoop.ozone.client.rpc.TestOzoneRpcClientWithRatis

hadoop.ozone.TestSecureOzoneCluster

hadoop.ozone.client.rpc.TestWatchForCommit

hadoop.ozone.om.TestOzoneManagerHA

hadoop.ozone.TestOzoneConfigurationFields

Subsystem
Report/Notes

Docker
Client=17.05.0-ce Server=17.05.0-ce base: https://builds.apache.org/job/hadoop-multibranch/job/PR-703/8/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/703

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient findbugs checkstyle xml

uname
Linux 78c75eb7ce10 4.4.0-141-generic #167~14.04.1-Ubuntu SMP Mon Dec 10 13:20:24 UTC 2018 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
personality/hadoop.sh

git revision
trunk / 0b1e288

Default Java
1.8.0_212

checkstyle
https://builds.apache.org/job/hadoop-multibranch/job/PR-703/8/artifact/out/diff-checkstyle-hadoop-ozone.txt

unit
https://builds.apache.org/job/hadoop-multibranch/job/PR-703/8/artifact/out/patch-unit-hadoop-ozone.txt

Test Results
https://builds.apache.org/job/hadoop-multibranch/job/PR-703/8/testReport/

Max. process+thread count
4197 (vs. ulimit of 5500)

modules
C: hadoop-hdds/common hadoop-hdds/framework hadoop-ozone/client hadoop-ozone/common hadoop-ozone/integration-test hadoop-ozone/ozone-manager hadoop-ozone/ozone-recon U: .

Console output
https://builds.apache.org/job/hadoop-multibranch/job/PR-703/8/console

versions
git=2.7.4 maven=3.3.9 findbugs=3.1.0-RC1

Powered by
Apache Yetus 0.10.0 http://yetus.apache.org

This message was automatically generated.

Fixed related unit test failures.
/retest

/retest

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Comment

0
reexec
51
Docker mode activated.

_ Prechecks _

+1
dupname
0
No case conflicting files found.

+1
@author
0
The patch does not contain any @author tags.

+1
test4tests
0
The patch appears to include 2 new or modified test files.

_ trunk Compile Tests _

0
mvndep
24
Maven dependency ordering for branch

+1
mvninstall
530
trunk passed

+1
compile
292
trunk passed

+1
checkstyle
72
trunk passed

+1
mvnsite
0
trunk passed

+1
shadedclient
865
branch has no errors when building and testing our client artifacts.

+1
javadoc
164
trunk passed

0
spotbugs
385
Used deprecated FindBugs config; considering switching to SpotBugs.

+1
findbugs
590
trunk passed

_ Patch Compile Tests _

0
mvndep
35
Maven dependency ordering for patch

+1
mvninstall
546
the patch passed

+1
compile
350
the patch passed

+1
javac
350
the patch passed

+1
checkstyle
87
the patch passed

+1
mvnsite
0
the patch passed

+1
whitespace
0
The patch has no whitespace issues.

+1
xml
2
The patch has no ill-formed XML file.

+1
shadedclient
719
patch has no errors when building and testing our client artifacts.

+1
javadoc
179
the patch passed

+1
findbugs
665
the patch passed

_ Other Tests _

-1
unit
235
hadoop-hdds in the patch failed.

-1
unit
2166
hadoop-ozone in the patch failed.

+1
asflicense
50
The patch does not generate ASF License warnings.

7821

Reason
Tests

Failed junit tests
hadoop.ozone.container.common.statemachine.commandhandler.TestCloseContainerCommandHandler

hadoop.ozone.container.common.impl.TestHddsDispatcher

hadoop.ozone.client.rpc.TestBlockOutputStream

hadoop.ozone.client.rpc.TestOzoneRpcClient

hadoop.ozone.client.rpc.TestSecureOzoneRpcClient

hadoop.ozone.om.TestOzoneManager

hadoop.hdds.scm.container.TestContainerStateManagerIntegration

hadoop.ozone.client.rpc.TestOzoneRpcClientWithRatis

hadoop.ozone.ozShell.TestOzoneDatanodeShell

hadoop.ozone.client.rpc.TestContainerStateMachineFailures

hadoop.ozone.om.TestOzoneManagerConfiguration

hadoop.ozone.ozShell.TestOzoneShell

Subsystem
Report/Notes

Docker
Client=17.05.0-ce Server=17.05.0-ce base: https://builds.apache.org/job/hadoop-multibranch/job/PR-703/9/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/703

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient findbugs checkstyle xml

uname
Linux c891aa18257b 4.4.0-138-generic #164-Ubuntu SMP Tue Oct 2 17:16:02 UTC 2018 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
personality/hadoop.sh

git revision
trunk / 8ca58ef

Default Java
1.8.0_212

unit
https://builds.apache.org/job/hadoop-multibranch/job/PR-703/9/artifact/out/patch-unit-hadoop-hdds.txt

unit
https://builds.apache.org/job/hadoop-multibranch/job/PR-703/9/artifact/out/patch-unit-hadoop-ozone.txt

Test Results
https://builds.apache.org/job/hadoop-multibranch/job/PR-703/9/testReport/

Max. process+thread count
3610 (vs. ulimit of 5500)

modules
C: hadoop-hdds/common hadoop-hdds/framework hadoop-ozone/client hadoop-ozone/common hadoop-ozone/integration-test hadoop-ozone/ozone-manager hadoop-ozone/ozone-recon U: .

Console output
https://builds.apache.org/job/hadoop-multibranch/job/PR-703/9/console

versions
git=2.7.4 maven=3.3.9 findbugs=3.1.0-RC1

Powered by
Apache Yetus 0.10.0 http://yetus.apache.org

This message was automatically generated.

/retest

/retest

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Comment

0
reexec
44
Docker mode activated.

_ Prechecks _

+1
dupname
0
No case conflicting files found.

+1
@author
0
The patch does not contain any @author tags.

+1
test4tests
0
The patch appears to include 2 new or modified test files.

_ trunk Compile Tests _

0
mvndep
21
Maven dependency ordering for branch

+1
mvninstall
525
trunk passed

+1
compile
303
trunk passed

+1
checkstyle
82
trunk passed

+1
mvnsite
0
trunk passed

+1
shadedclient
923
branch has no errors when building and testing our client artifacts.

+1
javadoc
166
trunk passed

0
spotbugs
404
Used deprecated FindBugs config; considering switching to SpotBugs.

+1
findbugs
624
trunk passed

_ Patch Compile Tests _

0
mvndep
30
Maven dependency ordering for patch

+1
mvninstall
491
the patch passed

+1
compile
304
the patch passed

+1
javac
304
the patch passed

+1
checkstyle
82
the patch passed

+1
mvnsite
0
the patch passed

+1
whitespace
0
The patch has no whitespace issues.

+1
xml
1
The patch has no ill-formed XML file.

+1
shadedclient
710
patch has no errors when building and testing our client artifacts.

+1
javadoc
165
the patch passed

-1
findbugs
412
hadoop-ozone generated 1 new + 0 unchanged - 0 fixed = 1 total (was 0)

_ Other Tests _

-1
unit
177
hadoop-hdds in the patch failed.

-1
unit
681
hadoop-ozone in the patch failed.

+1
asflicense
48
The patch does not generate ASF License warnings.

6189

Reason
Tests

FindBugs
module:hadoop-ozone

Null passed for non-null parameter of java.util.concurrent.CompletableFuture.completedFuture(Object) in org.apache.hadoop.ozone.om.ratis.OzoneManagerStateMachine.notifyInstallSnapshotFromLeader(TermIndex)  At OzoneManagerStateMachine.java:of java.util.concurrent.CompletableFuture.completedFuture(Object) in org.apache.hadoop.ozone.om.ratis.OzoneManagerStateMachine.notifyInstallSnapshotFromLeader(TermIndex)  At OzoneManagerStateMachine.java:[line 185]

Failed junit tests
hadoop.ozone.container.common.impl.TestHddsDispatcher

hadoop.ozone.container.ozoneimpl.TestOzoneContainer

hadoop.ozone.client.rpc.TestBCSID

hadoop.ozone.web.client.TestKeys

hadoop.ozone.client.rpc.TestOzoneRpcClientWithRatis

hadoop.ozone.client.rpc.TestWatchForCommit

hadoop.ozone.client.rpc.TestOzoneAtRestEncryption

hadoop.ozone.client.rpc.TestSecureOzoneRpcClient

hadoop.ozone.client.rpc.TestReadRetries

hadoop.ozone.client.rpc.TestOzoneRpcClient

Subsystem
Report/Notes

Docker
Client=17.05.0-ce Server=17.05.0-ce base: https://builds.apache.org/job/hadoop-multibranch/job/PR-703/10/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/703

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient findbugs checkstyle xml

uname
Linux a15288e66644 4.4.0-141-generic #167~14.04.1-Ubuntu SMP Mon Dec 10 13:20:24 UTC 2018 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
personality/hadoop.sh

git revision
trunk / cb9bc6e

Default Java
1.8.0_212

findbugs
https://builds.apache.org/job/hadoop-multibranch/job/PR-703/10/artifact/out/new-findbugs-hadoop-ozone.html

unit
https://builds.apache.org/job/hadoop-multibranch/job/PR-703/10/artifact/out/patch-unit-hadoop-hdds.txt

unit
https://builds.apache.org/job/hadoop-multibranch/job/PR-703/10/artifact/out/patch-unit-hadoop-ozone.txt

Test Results
https://builds.apache.org/job/hadoop-multibranch/job/PR-703/10/testReport/

Max. process+thread count
4417 (vs. ulimit of 5500)

modules
C: hadoop-hdds/common hadoop-hdds/framework hadoop-ozone/client hadoop-ozone/common hadoop-ozone/integration-test hadoop-ozone/ozone-manager hadoop-ozone/ozone-recon U: .

Console output
https://builds.apache.org/job/hadoop-multibranch/job/PR-703/10/console

versions
git=2.7.4 maven=3.3.9 findbugs=3.1.0-RC1

Powered by
Apache Yetus 0.10.0 http://yetus.apache.org

This message was automatically generated.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Comment

0
reexec
45
Docker mode activated.

_ Prechecks _

+1
dupname
0
No case conflicting files found.

+1
@author
0
The patch does not contain any @author tags.

+1
test4tests
0
The patch appears to include 2 new or modified test files.

_ trunk Compile Tests _

0
mvndep
23
Maven dependency ordering for branch

+1
mvninstall
524
trunk passed

+1
compile
296
trunk passed

+1
checkstyle
80
trunk passed

+1
mvnsite
0
trunk passed

+1
shadedclient
932
branch has no errors when building and testing our client artifacts.

+1
javadoc
179
trunk passed

0
spotbugs
385
Used deprecated FindBugs config; considering switching to SpotBugs.

+1
findbugs
618
trunk passed

_ Patch Compile Tests _

0
mvndep
32
Maven dependency ordering for patch

+1
mvninstall
482
the patch passed

+1
compile
301
the patch passed

+1
javac
301
the patch passed

+1
checkstyle
79
the patch passed

+1
mvnsite
0
the patch passed

+1
whitespace
0
The patch has no whitespace issues.

+1
xml
1
The patch has no ill-formed XML file.

+1
shadedclient
731
patch has no errors when building and testing our client artifacts.

+1
javadoc
203
the patch passed

+1
findbugs
650
the patch passed

_ Other Tests _

-1
unit
190
hadoop-hdds in the patch failed.

-1
unit
2369
hadoop-ozone in the patch failed.

+1
asflicense
47
The patch does not generate ASF License warnings.

7951

Reason
Tests

Failed junit tests
hadoop.ozone.container.common.impl.TestHddsDispatcher

hadoop.ozone.client.rpc.TestBCSID

hadoop.hdds.scm.pipeline.TestNode2PipelineMap

hadoop.ozone.client.rpc.TestOzoneRpcClientWithRatis

hadoop.hdds.scm.pipeline.TestRatisPipelineProvider

hadoop.ozone.client.rpc.TestOzoneAtRestEncryption

hadoop.ozone.client.rpc.TestCloseContainerHandlingByClient

hadoop.ozone.client.rpc.TestHybridPipelineOnDatanode

hadoop.ozone.client.rpc.TestOzoneRpcClient

Subsystem
Report/Notes

Docker
Client=17.05.0-ce Server=17.05.0-ce base: https://builds.apache.org/job/hadoop-multibranch/job/PR-703/11/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/703

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient findbugs checkstyle xml

uname
Linux c00839d6af42 4.4.0-141-generic #167~14.04.1-Ubuntu SMP Mon Dec 10 13:20:24 UTC 2018 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
personality/hadoop.sh

git revision
trunk / cb9bc6e

Default Java
1.8.0_212

unit
https://builds.apache.org/job/hadoop-multibranch/job/PR-703/11/artifact/out/patch-unit-hadoop-hdds.txt

unit
https://builds.apache.org/job/hadoop-multibranch/job/PR-703/11/artifact/out/patch-unit-hadoop-ozone.txt

Test Results
https://builds.apache.org/job/hadoop-multibranch/job/PR-703/11/testReport/

Max. process+thread count
5316 (vs. ulimit of 5500)

modules
C: hadoop-hdds/common hadoop-ozone/client hadoop-ozone/common hadoop-ozone/integration-test hadoop-ozone/ozone-manager hadoop-ozone/ozone-recon U: .

Console output
https://builds.apache.org/job/hadoop-multibranch/job/PR-703/11/console

versions
git=2.7.4 maven=3.3.9 findbugs=3.1.0-RC1

Powered by
Apache Yetus 0.10.0 http://yetus.apache.org

This message was automatically generated.

Thank You @hanishakoneru for the contribution.
I will commit this.


Feature/ttl support

Add support for expiring secrets using Dynamo DB TTL. Changes include:

credstash setup - enable TTL on the DD table adding a 'ttl' attribute
credstash put - add a '-e' flag for an expiry period in seconds
updated readme to document new feature

We use this feature to store SSL certs that expire in 24 hours. Rather than creating a new process in our application to track these records and remove them manually we rely on DD TTL to automatically remove the records when they are no longer required.

Thanks for the awesome work @wzedi. Sorry to leave you hanging for a while. I'm going through the PRs now. I'm planning to pull this in to the next major version of credstash that I'm working on now. One thing I'll note is I don't think DDB TTL is supported in us-gov-west-1. I don't know if anyone is using credstash there or not. My guess is in that region the call will fail. If you have time, would you add a protection around making the call to update_time_to_live() here. If you don't have time it's ok I'll take it up as part of the refactor and integration I'm working on for 2.0.

I'll get the change in as soon as I can.
Sent from my Samsung Galaxy smartphone.
-------- Original message --------
From: wayne-luminal<EMAIL_ADDRESS>Date:27/10/2017  6:55 AM  (GMT+10:00)
To: fugue/credstash<EMAIL_ADDRESS>Cc: Warrick<EMAIL_ADDRESS>Mention<EMAIL_ADDRESS>Subject: Re: [fugue/credstash] Feature/ttl support (#170)
Thanks for the awesome work @wzedi. Sorry to leave you hanging for a while. I'm going through the PRs now. I'm planning to pull this in to the next major version of credstash that I'm working on now. One thing I'll note is I don't think DDB TTL is supported in us-gov-west-1. I don't know if anyone is using credstash there or not. My guess is in that region the call will fail. If you have time, would you add a protection around making the call to update_time_to_live() here. If you don't have time it's ok I'll take it up as part of the refactor and integration I'm working on for 2.0.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or mute the thread.

Updated to handle any AWS exception during ttl enablement and to present warning message. Table creation will complete and credstash can be used without ttl enablement.


fix: iOS FPS

What
Currently, the FPS of a video recorded by the vision camera library on iOS are not consistent.
The FPS vary from one video to another even when the “fps” prop is used.
Examples:

Changes
Modification of recorder parameters to take into account the desired FPS.
Tested on

iPhone 12, iOS 17

Hmm, as per documentation the asset writer will choose an appropriate value automatically:

The default value is 0, which indicates that the input chooses an appropriate value, if applicable.

Do we really want to overwrite this?

After some research, I found that phones don't necessarily capture video at a constant bitrate, so it's a "normal" behaviour.


chore: update zkvyper and era test node

What I did

updated zkvyper to v1.5.7
updated era test node to alpha.30
updated this package's version to 0.2.7

Cute Animal Picture

Fixed https://github.com/vyperlang/titanoboa-zksync/issues/31


RX 5600M ramps down to 300MHz while mining etherum

Brief summary of the problem:
When I try to mine ethereum using the RX5600M on my Dell G5 15 SE the GPU clock ramps down to its lowest P-state (300MHz)
Hardware description:

CPU: Ryzen 5 4600H
GPU: RX 5600M
System Memory: 8+16GB
Display(s): Laptop screen
Type of Diplay Connection: eDP

System information:

Distro name and Version: openSUSE Tumbleweed 20210429
Kernel version: 5.12.0-1-defalut
Custom kernel: From openSUSE main repositories
AMD package version: Mesa 21.0.1 Rocm 4.1.0

How to reproduce the issue:
run teamredminer -a ethash --url=stratum+tcp://asia1.ethermine.org:4444 -u <YOUR-ETH-WALLET-ID>- p x -d 0  --eth_config=A432
It successfully initializes the GPU but ramps the clock speeds down to 300MHz. I don't know if other Rocm/OpenCL workloads have the same behaviour. Games dont exhibit this behaviour and run at proper clock speeds
I've also reported the bug on drm/amd https://gitlab.freedesktop.org/drm/amd/-/issues/1587

Thanks @Zakhrov for reaching out.
Navi series of cards are not supported right now with ROCm. Please check our documentation for supported hardware.
Thank you.


A wildcard '*' cannot be used in the 'Access-Control-Allow-Origin' header when the credentials flag is true

I have a vast ad server and when i put the ad in my player i get this error. how to solve it please .A wildcard '*' cannot be used in the 'Access-Control-Allow-Origin' header when the credentials flag is true.

If you having a cross domain request blocked with flash, please check this comment:
https://github.com/MailOnline/videojs-vast-vpaid/issues/102
What I recommend is that you contact you ad provider.
From http://www.iab.com/wp-content/uploads/2015/06/VASTv3_0.pdf see page 16

<IP_ADDRESS> Cross Origin Resource Sharing (CORS) for JavaScript

In order for JavaScript video players to accept a VAST response, ad servers must include a CORS header in the http file that wraps the VAST response. The CORS header must be formatted as follows:

Access-Control-Allow-Origin: <origin header value>
Access-Control-Allow-Credentials: true

These HTTP headers allow an ads player on any origin to read the VAST response from the ad server
origin. The value of Access-Control-Allow-Origin should be the value of the Origin header sent
with the ad request.
Setting the Access-Control-Allow-Credentials header to true will ensure that cookies will be
sent and received properly.
For more information, visit http://www.w3.org/TR/cors

This didn't happened with the flash video players, because flash uses another way to allow/block cross origins resources see page 15

Hi @Fetz
Thanks you for your great job!
I have the same CORS problem with my ad server. It works in chrome but it dosn't in Firefox.
But when i test my VAST tag in your DEMO it works in FF, so what I do wrong?

I also have the same Issue , have anyone a solution for it ?

@kwolniak Maybe your ad server is allowing some domains and not others...
@xcuben the easy solution and more future proof is to request you ad provider to update and respect the spec the complicated solution is if we get that specific error of CORS we can request flash to load the VAST instead of JS. We didn't implemented that hard solution because would slowdown even more the load of the ad, and because flash was only transition solution until we start getting more vpaid html ads...

This is mostly happening where flash can't be used and XMLHttpRequest is used. The plugin sets XMLHttpRequest.withCredentials to true which makes it impossible to use * in the allow origin header.
I have been looking for ways to extend VASTClient to overwrite the method that does that and couldn't, the only option I see so far is to actually overwrite XMLHttpRequest.prototype.send and set withCredentials to false.
NOTE: This will change the behavior of XMLHttpRequest EVERYWHERE. so I personally wouldn't recommend that option as it is too "hacky".


Create http server before features are initialised

For example socket.io requires a valid (but not listening) http server instance in feature constructor.

Coverage decreased (-0.5%) to 90.958% when pulling 1ccc04fe96c091ca0b7f060ee43779203f3019fe on matti-vincit:mm-alter-http-server-init-order into 11a7adf79ffaf84d4a58d10ede0476a686b2e6a5 on Vincit:master.


RDM-10539 rename UserRole columns to AccessProfile

JIRA link (if applicable)
RDM-10539 "Update User Role Column and codebase rename of UserRole to AccessProfile"
Change description
Rename of BEFTA_MASTER definition's UserRole columns to AccessProfile.
Created to support:

hmcts/ccd-definition-store-api#961.

Additional test PRs:

hmcts/ccd-data-store-api#1406
hmcts/aac-manage-case-assignment#251  hmcts/aac-manage-case-assignment#294

Does this PR introduce a breaking change? (check one with "x")
[x] Yes
[ ] No

LGTM


Canonical order for Z* extensions.

All Z* extension like Zifencei, Zicsr, Zam, Ztso should be listed in Table 28.1 with canonical order, or it's order free between Z* extension?

My assumption would be that Z extensions would be treated like Xfoo, Sbar, SXbaz and there is no required order between extensions within one of those categories (X/S/SX) them. Though it might be worth suggesting that ISA strings are canonicalised to sort extensions alphabetically within the X/S/SX/Z categories when being stored.
Table 28.1 should really be updated to show how Z should be ordered with Xabc/Sdef/SXghi

Proposal: they should be ordered first by category (I->M->A->F->D, for example), then alphabetically within a category.

Proposal: they should be ordered first by category (I->M->A->F->D, for example), then alphabetically within a category.

Sound good to me, how about Ze? I ask that because E is not listed in the table too, or there is no  Ze? if so, it might worse to write into spec?

There's no concept of Ze yet, so I think we can wait to make a decision until Ze is created :)


Change page inside a confirm event

I have this code:
var confirm = phonon.confirm("¿Enviar identificación?", sitio, true, "SI", "NO");
confirm.on('confirm', function() {
		phonon.navigator().changePage('pagetwo');
} );

And does nothing... But if I execute phonon.navigator().changePage('pagetwo'); outside the scope it works... It is normal?

I try here and your code is working fine. Please check if you have one pane with ID 'pagetwo'. Check if you have declarated this page in index.html file and if yor app.js file have one action to page two.
You can try visit (on navigator) http://localhost/index.html#!pagetwo (if you is using local server)

Yes, I have, in fact is a copy of the Getting Started example (home->page2)... This code is fired inside the where it is processed an asynchronous external event and the user can be viewing any other page in this moment. I know the code is executed, but I still seen the same page.

Can you share your code? Only interesting code., please use button isert code.

Hello again,
I think I have solved it chaging the preventClose of the other pages to false (previously I had true). Now it is working as expected.

To use preventClose you need add activity onClose in your action, without this not work.

yes, I know, my onclose was:
activity.onClose(function(self) {
            self.close();
    });

But now it is working...

It's ok, but if your issue is solved, please close this issue.  ;-)

Sure... In fact I'm more concern about the ios issue regarding the i18n #198


Add Pack CLI

Tool information

Tool name:  Pack CLI
Tool license:  Apache-2.0 License
Add or update?  Add
Desired version:  0.14.2
Approximate size:
If this is an add request:

Brief description of tool:  Allow you to create docker images taking advantage of buildpacks
URL for tool's homepage:  https://github.com/buildpacks/pack
Provide a basic test case to validate the tool's functionality:  pack --version

Area for Triage:

Question, Bug, or Feature?:

Feature
Virtual environments affected

[ ] macOS 10.15
[X] Ubuntu 16.04 LTS
[X] Ubuntu 18.04 LTS
[X] Ubuntu 20.04 LTS
[ ] Windows Server 2016 R2
[ ] Windows Server 2019

Can this tool be installed during the build?

Tool installation time in runtime

Are you willing to submit a PR?

Yes

Hi @eddumelendez,
this tool can be installed in runtime in a second, also, there is an action for it actions/pack-docker-action. Please, consider using these two options to work with Pack CLI.
Closing this issue due to installation and usage simplicity.
Feel free to create a new one in case of any other questions. Thanks!


Gait3D and GREW testing acc

the result of Gait3D is very low,are you sure the result of your paper is true?

There is no problem with our results. I re-ran the experiment by downloading the code again, and due to time constraints, I only ran it 30,000 times. The results, shown in the image above, are significantly higher than yours. I inquired with the colleague who ran the experiment at that time, and he confirmed that all the necessary steps for Gait3D and GREW were uploaded. He mentioned that for Gait3D, you can use the pkl files provided by the dataset authors, and the results should be fine. You should check where you might have made a mistake.

I don't know, how you deleted your comment, but I'll reply to you anyway! My colleague told me after 30,000 times the results go up even further.

If you use pkl files released by the original author of Gait3D, please take care to follow our instructions. （See readme for instructions.）

I will try it again

your datasets provided in the code is the same as the opengait ,so I get the datasets  via the opangait，but I really ran a false answer

After processing the dataset according to the code you provided, the final result is still the same as mine before, very low, and all the configurations have not changed at all. The following is the result after 70000 training rounds. I don't know whether the correct result you said before is actually produced by this code.

If you use pkl files released by the original author of Gait3D, please take care to follow our instructions. （See readme for instructions.）
您好，我是一个初学者，请问triplet_loss=0.1443, triplet_hard_loss=0.6375, triplet_loss_num=1317.1608, triplet_mean_dist=3.2787请问这三个指标一般看哪个指标呢？哪个指标越低证明效果越好呢？


Modify filename acceptance criteria with flags.

The Debian packaging standard has rules on acceptable filenames for files destined to cron.d. Enabling these with a flag would be better than the current solution.
http://www.debian.org/doc/manuals/maint-guide/dother.en.html#crond
When checking files in a package's debian/ directory, filenames should only match the (\S+\.)?cron.d as opposed to the other names currently accepted. In addition the error for this should probably point the user at the above link.
I suspect other packaging systems have their own standards, so need to investigate those first.

Another vote for this. In our case we'd like to be able to lint crontabs that are in ansible and are preprocessed via j2, so we've named them all foo.j2. If we had an option to just ignore filename validation that'd be sufficient for us.


[TLUL] Add ecc calculation functions

Signed-off-by: Jacob Levy<EMAIL_ADDRESS>

Any reason why the CI (private) check is not executing?
14 successful out ot the 15 checks and 1 looks stuck...

Any reason why the CI (private) check is not executing?
14 successful out ot the 15 checks and 1 looks stuck...

it looks like the DV regression is still running.  All but two tests have passed. Either that will pass soon, or maybe it's hanging somehow (it's probably the former, it's only been running for 15 mins).

this LGTM, adding the dv folks just in case they want something slightly different.

If no other comments, can someone Merge this PR. Thanks!

Whoah! @weicaiyang: This probably needed some squashing before it got pushed. Nothing to do now, but it might be worth being careful next time.

Whoah! @weicaiyang: This probably needed some squashing before it got pushed. Nothing to do now, but it might be worth being careful next time.

ohh, thanks @rswarbrick. I didn't know there are 5 commits in this PR. we should squash into one before merge


Implement a duckdb backend

As duckdb popularity rises, I think it makes sense to add support for it, even if it's a thin wrapper
import pandas as pd
import duckdb

pd.DataFrame({"a": [1, 2, 3], "b": [4, 5, 6], "c": ["a", "b", "c"]}).to_parquet("example.parquet")

connection = duckdb.connect()
relation = connection.from_parquet("example.parquet").to_view("example")

relation = connection.execute("SELECT * FROM example")
relation.fetchdf().hvplot()  <- # simplify this to relation.hvplot()

Seems to work for base case :O
import hvplot.duckdb

import pandas as pd
import duckdb

df = pd.DataFrame({
    'x': [1, 2, 3],
    'y': [4, 5, 6]
})

df.to_parquet('test.parquet')

connection = duckdb.connect(database=':memory:', read_only=False)
connection.from_parquet("test.parquet").hvplot(
    x='x', y='y', kind='scatter'
)


BLE service discovery fails (using any app), iPhone 6 / iOS 10.2.1

(As originally posted in the Nordic Dev Zone)
Hi!
Using the out of the box ANT shared channel demo with a NRF52-DK board and the iOS demo app everything compiles and installs nicely, using the Android-based app nRF Connect for Mobile I can successfully connect and control the hub/peripherals, but the iOS App will not work.
The iOS app will successfully make a connection and start the service discovery with the given service identifier, but this service discovery always times out after +- 30 seconds thus disconnecting the two devices again.
Note: 30 seconds is the supervisor timeout in the hub-code, but changing the timeout or deactivating it has no effect.
Removing the service filter searching for any services within the iOS app leads to the same result.
Also exactly the same happens using a generic bluetooth explorer app (LightBlue Explorer).
Added: The same with the Nordic nrf Connect for iOS
There are no clear BT errors occurring on the device (after adding extra code).
Any plausible app-sided approaches regarding iOS/BLE problems (according SO) did not lead to solutions yet..
Has anyone encountered similiar problems and might have a solution at hand, either app-sided or NRF52-DK-sided?
iPhone 6, iOS 10.2.1 + iPad mini 3, iOS 10.2.0
NRF52-DK (PCA10040, V1.1.1, 2016.48)
NRF5 SDK 12.2.0
Softdevice 332, 2.0.1

Hi, it may be related to the fact that new iOS sends mtu request after connection and the firmware seems not to reply. We are investigating it. It's a bug (?) in fw, not in the iOS app. It used to work with older version of iOS.

As you may have seen, the question has been answered here:
https://devzone.nordicsemi.com/question/113951/iosiphone-ble-service-discovery-timeout-with-ant-shared-channel-demo/

That's right - I thought I'd also post it here for any future reference; maybe adding a note to the README might be an idea. Thus I'll also just repeat Petter Myhre's solution here:
I did a sniffer trace, it seems iOS is sending a ATT MTU request that is not responded to, and because of that iOS disconnects after 30s.
If you replace the ble_evt_dispatch() function with the following, the MTU request should be responded to:
In asc_coordinator.c:
static void ble_evt_dispatch(ble_evt_t * p_ble_evt)
{
    uint32_t err_code;

    cntrldevice_event_handler(p_ble_evt);

    if(p_ble_evt->header.evt_id == BLE_GATTS_EVT_EXCHANGE_MTU_REQUEST)
    {
        err_code = sd_ble_gatts_exchange_mtu_reply(p_ble_evt->evt.common_evt.conn_handle, GATT_MTU_SIZE_DEFAULT);
        APP_ERROR_CHECK(err_code);
    }
}

I would also like to mention that the iOS app is old (2 years), it is not tested with later SDK, and it will not be updated. It can of course still be used as a starting point for development.


Does not compile when target is Arduino GIGA R1

Hi!
This library will not compile when the target board is an Arduino GIGA R1.  Any thoughts on how to fix?
The outputData.ino example in this library, for instance, will not compile when the target is GIGA.
Below is the compile output showing that 'SCL' and 'SDA' are not declared.
Thanks,
Brian
Compile output:
In file included from D:\Dropbox\arduino\libraries\DFRobot_GP8403\examples\outputData\outputData.ino:13:0:
d:\Dropbox\arduino\libraries\DFRobot_GP8403/DFRobot_GP8403.h:114:13: error: 'SCL' was not declared in this scope
int _scl= SCL;
^~~
d:\Dropbox\arduino\libraries\DFRobot_GP8403/DFRobot_GP8403.h:114:13: note: suggested alternative: 'SCK'
int _scl= SCL;
^~~
SCK
d:\Dropbox\arduino\libraries\DFRobot_GP8403/DFRobot_GP8403.h:115:14: error: 'SDA' was not declared in this scope
int _sda = SDA;
^~~
exit status 1
Compilation error: exit status 1

See this thread for more info and temporary workaround:
https://forum.arduino.cc/t/compile-errors-with-i2c-library-and-giga-r1/1325076/20


[WIP] v2.2.0

Checklist

[x] I have read contributing guidelines.
[x] I'm sure that the cat did not jump to the keyboard and did not unrelated changes in this pull request
[x] I have created at least one test case for the changes I have made
[x] I have updated the documentation for the changes I have made
[x] I have added myself to the CONTRIBUTORS.md
[x] I have added my changes to the CHANGELOG.md

Related issues
Updated:

[ ] Updated documentation and fixed typos
[ ] Completely annotated all functions
[x] Updated data for locale pl
[x] Updated snils algorithm for RussiaSpecProvider

Removed:

[x] Removed deprecated method Science.scientific_article()
[x] Removed deprecated method Structure().json(), use schema.Schema() instead

Fixed:

[x] Fixed bug with seed
[x] Fixed issue with names on downloading images

Added:

[ ] Added doctests
[x] Added generate KPP for RussiaSpecProvider
[ ] Added PolandSpecProvider
[x] Added support of timezones for Datetime().datetime()
[ ] Added new provider choice.Choice()
[x] Added method to bulk create datetime objects (Datetime().bulk_create_datetimes())
[ ] Added support of second, third and fourth level domains

Please, do not forget about doctests

@sobolevn Sure! Work still in progress.

@sobolevn How about following format of doctests:
    def street_number(self, maximum: int = 1400) -> str:
        """Generate a random street number.

        :param maximum: Maximum value.
        :return: Street number.

        :Example:
        >>> address = Address()
        >>> number = address.street_number(128)
        >>> isinstance(number, str)
        True
        >>> int(number) <= 128
        True
        """
        return str(self.random.randint(1, maximum))

Should i add :Example:?

@sobolevn Can you, please, review module address.py where added doctests?

@lk-geimfari LGTM!

That's not for testing. That's done to be sure that examples are still valid.
We can change something and then miss to fix it in the docs.
These tests ensure that we won't forget about it.

@sobolevn So, then that's a good idea! Should we show doctests in documentations?

@lk-geimfari yes, we surely have to show doctests in the docs.


mv 'architecture' to 'microservices-architecture'

Fixes #2498

The redirection request is ID 1026648  on our internal system. Once processed, this can be merged.


TProtocol.h: Be extra careful when including MSVC Windows-related headers

Windows-related headers can pollute the c++ namespace with macros min and max and other quirks that break standard c++ code quite easily.

[ ] Did you create an Apache Jira ticket?  (Request account here, not required for trivial changes)
[ ] If a ticket exists: Does your pull request title follow the pattern "THRIFT-NNNN: describe my issue"?
[x] Did you squash your changes to a single commit?  (not required, but preferred)
[x] Did you do your best to avoid breaking changes?  If one was needed, did you label the Jira ticket with "Breaking-Change"?
[x] If your change does not involve any code, include [skip ci] anywhere in the commit message to free up build resources.

No build problems or errors are related to this change. Failing tests already failed before:

https://ci.appveyor.com/project/ApacheSoftwareFoundation/thrift/builds/48258433/job/cyhd8al8agk2a91e
https://ci.appveyor.com/project/ApacheSoftwareFoundation/thrift/builds/48258433/job/5cyffy00o3rafy6l


Make levels configurable and allow overriding borrowing restrictions

closes #56
closes #35

Hello @mik2k2! Thanks for opening this PR. We checked the lines you've touched for PEP 8 issues, and found:

In the file buchschloss/config/main.py:

Line 162:69: E226 missing whitespace around arithmetic operator

In the file buchschloss/core.py:

Line 949:70: E226 missing whitespace around arithmetic operator


Author name not specified in LICENSE

Author name is not specified in LICENSE . As far as I have noticed all ruby-packages have a specified author name with email in the LICENSE but not in the case with kostya-sigar .
If it's not an issue I would love to add author name and email in the LICENSE to.
Regards,
@nightwarrior-xxx

i am not author, its just fork with some fixes


tests: integration

We need some end-to-end tests verifying that provided renderers gets converter to expected HTML. So far we only have those for parallel coordinates plot.

Duplicate https://github.com/iterative/dvc-render/issues/4 ?

Not quite, those two are about testing HTML, so verifying that the rendering gets done and no errors are thrown on JS side. However what I mean here is that we should prepare a tests making sure that particular data points get converted into particular HTML. They might be joined with #4 but not necessarily. Our current tests resemble unit tests more than end-to-end tests.


Cmd-R no longer working

I can't figure this out, but my browser will no longer refresh when I press Cmd-R.  My browser is properly entered. Running Browser: Refresh from the command palette works, but not Cmd-R.
When I try it, I see VS Code says in its footer, "Cmd-R was pressed. Waiting for second key of chord..."
I'm on macOS 14.2.1 with VS Code 1.85.2.
It's been like this for a while. So maybe it was a VS Code update?
I thought maybe it was my browser, because it seemed to work with Chrome and Brave, but not with Arc—at least a week ago. Now, though, I can't get Cmd-R to work with Chrome or Brave at all!

It may be worth reporting this issue upstream, it's not strictly a problem that the extension itself can solve. I was going to guess that maybe some other extension is contributing a shortcut that takes precedence over our's, but it seems incompatible with you seeing "Cmd-R was pressed...".
You could try explicitly setting a shortcut for this in the settings:
{ "key": "cmd+r", "command": "browserRefresh.refresh" }

SOLVED! It's a conflict with the Postman extension!
While I was trying to figure out where to put that key command code you gave me, I found "Toggle keyboard shortcuts troubleshooting" in the command bar. I enabled that, hit Cmd-R, and watched the log:
2024-03-08 14:20:22.190 [info] [KeybindingService]: | Resolving meta+[KeyR]
2024-03-08 14:20:22.190 [info] [KeybindingService]: \ From 6 keybinding entries, awaiting 1 more chord(s), when: postman-for-vscode:sign-in, source: user extension Postman.postman-for-vscode.
2024-03-08 14:20:22.190 [info] [KeybindingService]: / Received  keydown event - modifiers: [meta], code: KeyR, keyCode: 82, key: r
2024-03-08 14:20:22.190 [info] [KeybindingService]: | Converted keydown event - modifiers: [meta], code: KeyR, keyCode: 48 ('R')

Although I don't quite know what that log is showing, I could clearly see Postman referenced in there, so I tried disabling it and now Cmd-R works again!
I know your solution didn't actually fix the problem, but it helped lead to the solution. So thank you!


[CLNP-4596] feat: add forceLeftToRightMessageLayout to enable LTR message layout display in RTL mode

Addresses https://sendbird.atlassian.net/browse/CLNP-4596
This PR addresses the layout issues and CSS specificity improvements for right-to-left (RTL) text direction in the Sendbird UIKit React components.
The background for adding the forceLeftToRightMessageLayout flag is that some of our users in the middle-east want to set htmlTextDirection='rtl' while keeping the message layout in left-to-right (LTR) format (outgoing messages on the right, incoming messages on the left).
Todo

[x] The postcssRtl plugin options were modified.
[x] Layout adjustments were made to ensure proper alignment and behavior.

For whom wants to test this

RTL but only the message layout keeps LTR : http://localhost:5173/?htmlTextDirection=rtl&forceLeftToRightMessageLayout=true

Normal RTL: https://deploy-preview-1184--sendbird-uikit-react.netlify.app?htmlTextDirection=rtl


No link to this repo on npmjs.org

Hi!
I was about to use this library for the fun of it and found it on npmjs.org, but there's no link to this repo in the package which made me feel a bit unsafe since I couldn't verify the source code so there wasn't anything malicious in it.
Think it would be a great idea to add this repo-link to your npmjs.org package: https://www.npmjs.com/package/starwars :)
Great job!

Thanks! Fixed in e58e40516f4b3636ab4fd89cd794f2ac33d0a54e.


Fixed facet_generator() and typos

facet_generator() in bipartite_to_max_facet.py is now able to yield the last facet of a dataset.

Thanks, merged.


fix: remove unnecessary reassignments

Ⅰ. Describe what this PR does
This variable will be initialized to this value globally, and the global variable will be executed before init(), so there is no need to reassign it here.

Ⅱ. Does this pull request fix one issue?

Ⅲ. Describe how to verify it
Ⅳ. Special notes for reviews
V. Checklist

[ ] I have written necessary docs and comments
[ ] I have added necessary unit tests and integration tests
[ ] All checks passed in make test

/lgtm
/approve


[BUG] window_function_test hanging in databricks 10.4 runtime

Describe the bug
rapids_databricks_nightly-pre_release-github build 451, 452
rapids_databricks_nightly-dev-github build 170,171,172
parallel test in spark local mode
[2022-07-29T12:41:59.014Z] [gw3] [ 99%] PASSED ../../src/main/python/window_function_test.py::test_window_aggs_lead_ignore_nulls_fallback[partBy:Long-orderBy:Long-orderBy:LongRange(not_null)-agg:Boolean][IGNORE_ORDER({'local': True}), ALLOW_NON_GPU(WindowExec,Alias,WindowExpression,Lead,Literal,WindowSpecDefinition,SpecifiedWindowFrame)]
[2022-07-29T14:45:47.874Z] [gw3] [ 99%] PASSED ../../src/main/python/window_function_test.py::test_window_aggs_lead_ignore_nulls_fallback[partBy:Long-orderBy:Long-orderBy:LongRange(not_null)-agg:Date][IGNORE_ORDER({'local': True}), ALLOW_NON_GPU(WindowExec,Alias,WindowExpression,Lead,Literal,WindowSpecDefinition,SpecifiedWindowFrame)] Sending interrupt signal to process
those pipeline failed timeout seems abnormal long test time for specific cases,
this only occurred in databricks 10.4 runtime (9.1 works fine)

this also occurred intermittently in premerge CI
rapids_premerge-github build 5273  triggered in #5989

My attempt at repro-ing this produced the same results as @tgravescs's:

Running only test_window_aggs_lead_ignore_nulls_fallback didn't repro the problem, even after several runs.
Running all (and only) the tests under window_function_tests.py did not reproduce the problem.

I'm now running the full set of python tests. The problem looks elusive.

this didn't seem to happen last night as our nightly passed in two hours.

Yesterday, I was able to run the integration tests to completion 3 times on Databricks 10.4. (I wish I had timed those runs, in hindsight.) The window function tests did not hang indefinitely.
I was also able to run just the window function tests to completion several times.
I wonder if what we're seeing is a performance regression somewhere that results in the full integration suite taking longer than the 2 hour timeout. (Note that the window function tests are among the very last to run.)
The hang is as yet not reproducible for me. :/

Maybe some intermittent azure instances performance issue during that period.
Let's keep monitoring this for a few more days

We are not seeing this for ~ a week. Closing it


Register model.AuthenticationPolicy to istioctl.

Also,  make config parsing error message more verbose.

@diemtvu: The following test failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/e2e-simpleTests.sh
e0bff267d4610b83d8a7d00206a7a83a9caf216a
link
/test e2e-simple

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@diemtvu: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/e2e-simpleTests.sh
e0bff267d4610b83d8a7d00206a7a83a9caf216a
link
/test e2e-simple

prow/e2e-bookInfoTests.sh
e0bff267d4610b83d8a7d00206a7a83a9caf216a
link
/test e2e-bookInfo

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@diemtvu: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/e2e-simpleTests.sh
e0bff267d4610b83d8a7d00206a7a83a9caf216a
link
/test e2e-simple

prow/e2e-bookInfoTests.sh
e0bff267d4610b83d8a7d00206a7a83a9caf216a
link
/test e2e-bookInfo

prow/istio-pilot-e2e.sh
e0bff267d4610b83d8a7d00206a7a83a9caf216a
link
/test istio-pilot-e2e

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.


no HTTP server in master

Hey. In readme it's written:
python -m SimpleHTTPServer
But there is no python code in repo at all. How can I run audio-annotator?
Thank you.

My fault, was trying to run under python3 where SimpleHTTPServer is merged in another package http.server


Enable PP for vignetting only when required

Enable PP for vignetting only when required
Set custom imageProcessingConfiguration applyByPostProcess to true which was set to false by mistake

Ill move these to a single PR


he problem is that the code that ive written to clone target5 clones it and copies it to the left-well but since i cloned target5 the name of the elements are same and that ends up transfering double target 5 boxes. and its like on and off in some moment it shows only 1 box and other it shows both target5 box'es

Challenge Use jQuery to Modify the Entire Page has an issue.
User Agent is: Mozilla/5.0 (Windows NT 6.3; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/56.0.2924.87 Safari/537.36.
Please describe how to reproduce this issue, and include links to screenshots if possible.
My code:

jQuery Playground

#left-well

        <button class="btn btn-default target" id="target1">#target1</button>
        <button class="btn btn-default target" id="target2">#target2</button>
        <button class="btn btn-default target" id="target3">#target3</button>

#right-well

        <button class="btn btn-default target" id="target4">#target4</button>
        <button class="btn btn-default target" id="target5">#target5</button>
        <button class="btn btn-default target" id="target6">#target6</button>

@varunmistry The title of the issue should ideally be succinct and only a few words long, to describe the issue briefly. You can use the body of the issue to fill in all the details.

It's  not issue. It's normal .clone() behaviour.

@varunmistry as @Gardemarin has said, .clone() will copy the target it's applied to. I think this is functioning as intended.

if you use removeAttr('id') then the test doesn't run.  so either way, it's a bug

So don't remove it ;) Task don't ask to do that ;)

target5 is not a class so removing it won't help.  It is a known bug on the freecodeacademy site.  One solution is to use  $(document).bind("ready",function(e) {...   that seems to fix the problem without removing the id.

Did you inspect my all code ? :) I add target5 class to button with id="target5"

What I want to say, it's not an issue. It's normal .clone() behaviour and if You still don't believe me try that code on localhost  inside your computer ;)

Funny ! :D I tried this code in codepen :) so .. rss81 You was right! :) it is an issue :) my apologies!

This is likely an issue with the jQuery running for each test. Regardless, it has been resolved on the beta. http://beta.freecodecamp.com/en/challenges/jquery/clone-an-element-using-jquery

This may be fixed in the beta, but it is still occurring in production.

Issue is still occurring. Happens after running the tests.

+1


Password manager service on CentOS

When installing from source on CentOS 7 and running, there's an error message saying that a password manager service is required but not installed. If I don't want to use snap what can I install for this?

@dontmesswithbill Thank you for your question!
Since this channel is for driving improvements towards MS Docs, could you provide the URL of the specific documentation that your feedback is applicable to? That way, we are able to make sure your feedback is addressed by the right team.

@dontmesswithbill Any update on the issue. Can you please share the document URL.

@dontmesswithbill  I will proceed to close this issue. You can either open a new issue by providing Feedback directly on the document or If you have the document URL then please share so that we can reopen this issue.


Dependency_pins does not honor passwords

Describe the bug
If a package requires an install key, putting a dependency pin on it will fail to install with an invalid install key issue. Including password_env_name in the pin causes a parsing error.
Please add support for install keys on pinned dependencies
Reproduction steps

Have a dependency that requires an Install key
Add dependency to the dependency_pins section
Run update_dependencies

Install will fail due to missing install key.
Your CumulusCI and Python versions
CumulusCI version: 3.77.0
Python version: 3.10.9
Operating System
macOS 13.4.1 (22F82)
Windows environment
No response
CumulusCI installation method
pipx
Error Gist
No response
Additional information
No response

+1 to this feature


Add checks for future's state before setting result

set_result can throw an InvalidStateError if the future is done or cancelled, so this adds a check. (https://docs.python.org/3/library/asyncio-future.html#asyncio.Future.set_result)

This corrects the same errors I was getting on Win32/Py3.6.  Also fixes #11
Any idea when this could be merged?

@lllama I've merged your commit into qasync, which is an actively maintained fork of asyncqt.
Thanks for your contribution!


confirmation email on sprig request form

self describing
-why?
simply to be sure to not misspell the email (and so that in that case I could reach out to someone)
especially important in case of delays etc. (why didn't I get an email - didi I maybe misspell something?)
things to include after form: you will shortly receive a confirmation email, if not please reach out on slack hq channel (for example)

useful informations/implementation ideas:
https://support.airtable.com/docs/when-a-form-is-submitted-trigger
https://support.airtable.com/docs/send-an-email-action

@Sheepy3 this seems like a very reasonable ask and can avoid confusion in the sprig/case awarding flow, we should probably just bang this out

I agree that this would probably solve some worries people have

setup this automation! it also allows you to confirm your address


[Dubbo-1765] Fix ReferenceBean initialization issue

What is the purpose of the change
Fixed a bug described in Dubbo-1765
If the provider is temporarily unavailable, the reference bean initialization will failed with exception. However, the initialized flag will be set to true, which will cause spring to hold a NULL_OBJECT cache. The subsequent call will always get a null instance.
This change will allow the consumer to obtain the correct instance when provider become available.
Brief changelog

Set initialized=false in ReferenceConfig when provider is not available.

Verifying this change
unit test passed
Follow this checklist to help us incorporate your contribution quickly and easily:

[x] Make sure there is a GITHUB_issue filed for the change (usually before you start working on it). Trivial changes like typos do not require a GITHUB issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
[ ] Format the pull request title like [Dubbo-XXX] Fix UnknownException when host config not exist #XXX. Each commit in the pull request should have a meaningful subject line and body.
[ ] Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
[ ] Write necessary unit-test to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add integration-test in test module.
[ ] Run mvn clean install -DskipTests & mvn clean test-compile failsafe:integration-test to make sure unit-test and integration-test pass.
[ ] If this contribution is large, please follow the Software Donation Guide.

Codecov Report

Merging #1991 into master will decrease coverage by <.01%.
The diff coverage is 100%.

@@             Coverage Diff              @@
##             master    #1991      +/-   ##
============================================
- Coverage     50.83%   50.83%   -0.01%
- Complexity     4767     4770       +3
============================================
  Files           562      562
  Lines         25218    25219       +1
  Branches       4449     4449
============================================
  Hits          12820    12820
- Misses        10466    10467       +1
  Partials       1932     1932

Impacted Files
Coverage Δ
Complexity Δ

.../java/org/apache/dubbo/config/ReferenceConfig.java
51.41% <100%> (+3.73%)
43 <0> (+5)
:arrow_up:

...ubbo/rpc/protocol/dubbo/ChannelWrappedInvoker.java
41.66% <0%> (-8.34%)
3% <0%> (ø)

.../dubbo/remoting/transport/netty4/NettyChannel.java
57.5% <0%> (-7.5%)
21% <0%> (-1%)

...org/apache/dubbo/rpc/filter/ActiveLimitFilter.java
83.33% <0%> (-5.56%)
6% <0%> (-1%)

...e/dubbo/remoting/transport/netty4/NettyServer.java
72.13% <0%> (-3.28%)
9% <0%> (-1%)

...bo/remoting/transport/netty/NettyCodecAdapter.java
53.12% <0%> (-1.57%)
3% <0%> (ø)

...a/org/apache/dubbo/monitor/dubbo/DubboMonitor.java
89.71% <0%> (+1.86%)
15% <0%> (ø)
:arrow_down:

...rpc/protocol/dubbo/telnet/InvokeTelnetHandler.java
54.43% <0%> (+2.53%)
12% <0%> (+1%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7a48fac...9efa787. Read the comment docs.


Multiple mdat boxes lead to panic

I came across mp4 files with two mdat boxes: first is the real one and the next is empty. All players and wowza were playing it all right but mp4ff reads such file and rewrite file.Mdat with second empty one.  I propose these changes to file.go for fixing it:
	case *MdatBox:
		if !f.isFragmented {
			if f.Mdat == nil || f.Mdat.Data == nil {
				f.Mdat = box
			}
		} else {

@alttagil  Thanks for the report. This is a weird case, but apparently allowed by the spec. There may also be multiple mdat boxes containing data, or references to data in another file. The goal of mp4ff is not to be the most general parser/processor possible, but this is an easy enough change that I can add something similar to the code change you suggest. I think, I'll rather use the size of mdat than a nil pointer in the test, though. I suppose your empty mdat box has the size properly set to 8?

[ftyp] size=8+24
major_brand = isom
minor_version = 200
compatible_brand = isom
compatible_brand = iso2
compatible_brand = avc1
compatible_brand = mp41
[free] size=8+0
[mdat] size=8+20990219
[mdat] size=8+0
[moov] size=8+72942
[mvhd] size=12+96
timescale = 1000
duration = 127318
duration(ms) = 127318
....

it seems that it doesn't prevent rewriting non-empty box with empty one

@alttagil Yeah, you're right. I didn't write a test to check the behaviour. Thanks for checking!
The code has now been fixed and there is a a new test that checks the various cases with mixed empty and non-empty mdat boxes.


Unit Test Parameter Validation and Coercion without Rack

Parameter Validation and Coercion definitions can be large.  The only method for testing these definitions that I am familiar with is thought using a test RACK.  If I created definitions in a separate module (or class) and included the definitions in a Grape::API class, could I test the definitions isolated without using using RACK?

I'll close this. Please use the Grape mailing list for questions.


Upcoming Hard Fork Question

Does cardano-graphql (or db-sync) expose the time / slot an upcoming hard fork event will occur? There's a param_proposal table in db-sync but I can't see anything useful in there.
I'm looking at adding it as an alert, maybe like a push service.
Thanks!

My understanding is that for a hard fork to occur it first has to be proposed on the chain, and any parameter proposal on the chain will end up in the param_proposal table.

So if this is a voting record, is there a way to determine that the proposal was rejected?

Actually, as per my understanding - if the count of signed records is >= updateQuorum (shelley genesis parameter: 5 on mainnet), the "vote" is accepted. Though I could be wrong, but I do remember having tested the proposal method when we went live with shelley - not via dbsync
(Feel free to correct me @erikd if above is incorrect)

@CyberCyclone Can this be closed?


Problem

enough settings to use the crystal?
CONFIG_CLOCK_CONTROL_NRF_K32SRC_XTAL=y
CONFIG_CLOCK_CONTROL_NRF_K32SRC_50PPM=y
At the moment the consumption is too high 4.8mA = 4800ua
Should be around ~7.3ua

On which board are you running this?
As explained in the disclaimer, the code is currently a proof-of-concept with no power management implemented. Patches are welcome.

On which board are you running this?
As explained in the disclaimer, the code is currently a proof-of-concept with no power management implemented. Patches are welcome.

NRF52810

@koenvervloesem I've tried various settings and still can't get save power

Closing because of a lack of concrete information.


[docs] Adds DropDownMenu to migration guide

This small PR adds an item to the Migration From v0.x page.
Specifically, I have added documentation regarding the DropDownMenu component from v0.x and how it is replaced with <Select/> in the new version.
Before

After

@mxmcg It's a great first pull request on Material-UI 👌🏻. Thank you for working on it!

Thank you sir! I am in the midst of migrating a large project. Glad I could help.


Docker - container not starting after update

I know that I have a bit of a complicated awkward setup here, but hopefully someone with a bit better understanding of yesterdays update can help me locate what's broken.
I have a bunch of the directories redirected to my home directory as it's being ran in plexguide, and some of this needs to be able to be updated on it's own for configuration purposes and such.
pg_volumes:
          - '/home/iandrewc/nginx/:/opt/nginx/'
          - '/home/iandrewc/nginx/:/etc/nginx/'
          - '/home/iandrewc/nginx/:/usr/local/nginx/'
          - '/home/iandrewc/HLS/:/opt/data'
          - '/home/iandrewc/HLS/:/HLS'
          - '/home/iandrewc/video_recordings/:/videorecordings'
          - '/home/iandrewc/www/:/www'
          - '/home/iandrewc/letsencrypt/etc/letsencrypt:/le-ssl'

But here's the errors that's showing in the log now.
 Are you able to reproduce this issue with a more minimal setup without the mounted volumes?

Finally got a chance to do this, thank you for getting back to me.
So I pulled out the volumes other than the HLS ones and WWW as I felt it was unlikely they'd cause it. Then loaded them back one by one. All volume mappings were okay apart from this one.
/home/iandrewc/nginx : /usr/local/nginx
Of course I can't do much without that as that's where the config lives.
Thoughts on possibilities to look at from here?

Looks like after copying that folder from the container, and then updating /nginx/sbin/nginx in my local volume, the container at least stays running. Seems to have broken something else but at least it's working.


feat: extend recorder API to let shutdown it gracefully

Closes #21

Codecov Report

Merging #62 into master will increase coverage by 3.76%.
The diff coverage is 95.45%.

@@            Coverage Diff             @@
##           master      #62      +/-   ##
==========================================
+ Coverage   81.46%   85.22%   +3.76%
==========================================
  Files          27       27
  Lines         863      880      +17
==========================================
+ Hits          703      750      +47
+ Misses        160      130      -30

Impacted Files
Coverage Δ

Sources/AWSXRayUDPEmitter/UDPEmitter.swift
56.89% <80.00%> (+28.82%)
:arrow_up:

Sources/AWSXRayRecorder/Emitter.swift
100.00% <100.00%> (+33.33%)
:arrow_up:

Sources/AWSXRayRecorder/Recorder.swift
96.70% <100.00%> (+0.31%)
:arrow_up:

Sources/AWSXRayTesting/LogEmitter.swift
95.65% <100.00%> (+1.90%)
:arrow_up:

Sources/AWSXRayUDPEmitter/Config.swift
93.33% <0.00%> (-6.67%)
:arrow_down:

Sources/AWSXRayRecorder/Config.swift
95.45% <0.00%> (-4.55%)
:arrow_down:

Sources/AWSXRayUDPEmitter/UDPClient.swift
34.37% <0.00%> (+6.25%)
:arrow_up:

Sources/AWSXRayUDPEmitter/Locks.swift
51.92% <0.00%> (+21.15%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 02891fb...77baf6f. Read the comment docs.


Integration publishing should honor BuildTargetingString

The python builds have the concept of BuildTargetingstring queue time variable that can narrow the scope of a build to select artifacts.
Unfortunately, when we use it to get something like a single dev publish of azure-storage-blob out the door, we crash after uploading the target, because the expected artifacts aren't present in their folder.
Need to resolve this assumption and ensure it doesn't crash.

Label prediction was below confidence level 0.6 for Model:ServiceLabels: 'Azure.Core:0.3575137,Storage:0.3024703,azure-spring:0.07378103'


Devices are connected but unresponsive until first toggled inside the Tuya app

I managed to get homebridge + homebridge-tuya-lan working across two vlans but for some reason I no longer see "Sending first query..." and "Ready to handle..." after it connects to one of the devices. In the Home app, all devices show "No response". If I open the Tuya app and toggle a light, I then see the "Read to handle..." message and the device in the Home app comes to life instantly. I can use all the devices inside the Home app without issue from this point on so long as I don't have to restart homebridge.
My question is, what happens between "Connected to..." and "Sending first query..." that would prevent it from ever sending the first query? I know it's related to my setup but I'm just not sure where to start. Does it wait after it connects for a ping or some other response before it continues to send the first query and ready the device?
$ journalctl -f -u homebridge
Dec 14 02:20:30 homebridge homebridge[10316]: [12/14/2019, 2:20:30 AM] [TuyaLan] Starting discovery...
Dec 14 02:20:30 homebridge homebridge[10316]: [12/14/2019, 2:20:30 AM] Homebridge is running on port 51826.
Dec 14 02:20:30 homebridge homebridge[10316]: [TuyaDiscovery] Discovery started on port 6666.                                                                                Dec 14 02:20:30 homebridge homebridge[10316]: [TuyaDiscovery] Discovery started on port 6667.                                                                                Dec 14 02:20:30 homebridge homebridge[10316]: [TuyaDiscovery] UDP from <IP_ADDRESS>:6667 0x000055aa...0x0000aa55                                                                                Dec 14 02:20:30 homebridge homebridge[10316]: [12/14/2019, 2:20:30 AM] [TuyaLan] Discovered Living Room Overhead 2 (76670400dc4f2271c443) identified as RGBTWLight (3.3)
Dec 14 02:20:30 homebridge homebridge[10316]: [TuyaAccessory] Changing ping gap for Living Room Overhead 2 to 9s
Dec 14 02:20:30 homebridge homebridge[10316]: [12/14/2019, 2:20:30 AM] [TuyaLan] Connected to Living Room Overhead 2                                                                                Dec 14 02:20:30 homebridge homebridge[10316]: [TuyaDiscovery] UDP from <IP_ADDRESS>:6666 0x000055aa...0x0000aa55
Dec 14 02:20:30 homebridge homebridge[10316]: [12/14/2019, 2:20:30 AM] [TuyaLan] Discovered Overhead Light (002004245ccf7f43e31f) identified as TWLight (3.1)
Dec 14 02:20:30 homebridge homebridge[10316]: [12/14/2019, 2:20:30 AM] [TuyaLan] Connected to Overhead Light                                                                                Dec 14 02:20:30 homebridge homebridge[10316]: [TuyaDiscovery] UDP from <IP_ADDRESS>:6667 0x000055aa...0x0000aa55                                                                                Dec 14 02:20:30 homebridge homebridge[10316]: [12/14/2019, 2:20:30 AM] [TuyaLan] Discovered Kitchen Overhead Light 3 (821043242cf4323b16d8) identified as RGBTWLight (3.3)
Dec 14 02:20:30 homebridge homebridge[10316]: [TuyaAccessory] Changing ping gap for Kitchen Overhead Light 3 to 9s
Dec 14 02:20:30 homebridge homebridge[10316]: [12/14/2019, 2:20:30 AM] [TuyaLan] Connected to Kitchen Overhead Light 3                                                                                Dec 14 02:20:31 homebridge homebridge[10316]: [TuyaDiscovery] UDP from <IP_ADDRESS>:6666 0x000055aa...0x0000aa55

$ journalctl -f -u homebridge (after toggling a few lights in Tuya)
Dec 14 02:30:33 homebridge homebridge[10316]: [12/14/2019, 2:30:33 AM] [TuyaLan] Ready to handle Office Lamp (Outlet:3.1) with signature {"1":false,"2":0}
Dec 14 02:30:51 homebridge homebridge[10316]: [TuyaAccessory] Heard back from Coffee Bar Lamp with command 8
Dec 14 02:30:51 homebridge homebridge[10316]: [12/14/2019, 2:30:51 AM] [TuyaLan] Ready to handle Coffee Bar Lamp (RGBTWLight:3.3) with signature {"20":true}
Dec 14 02:30:55 homebridge homebridge[10316]: [TuyaAccessory] Heard back from Kitchen Overhead Light 3 with command 8
Dec 14 02:30:55 homebridge homebridge[10316]: [12/14/2019, 2:30:55 AM] [TuyaLan] Ready to handle Kitchen Overhead Light 3 (RGBTWLight:3.3) with signature {"1":true}
Dec 14 02:30:55 homebridge homebridge[10316]: [TuyaAccessory] Color format for Kitchen Overhead Light 3 (3.3) is undetectable.
Dec 14 02:31:03 homebridge homebridge[10316]: [TuyaAccessory] Heard back from Kitchen Overhead Light 3 with command 8
Dec 14 02:31:07 homebridge homebridge[10316]: [TuyaAccessory] Heard back from Coffee Bar Lamp with command 8
Dec 14 02:31:22 homebridge homebridge[10316]: [TuyaAccessory] Heard back from Kitchen Overhead Light 3 with command 8

Network setup:
vlan10 - <IP_ADDRESS> - wireless router
vlan20 - <IP_ADDRESS> - homebridge server, Apple TV, iPhone
vlan40 - <IP_ADDRESS> - homebridge server, Tuya IoT devices
The homebridge server has two interfaces, one connecting to vlan20 and another to vlan40. I have my router (rt-ac68u) setup with an avahi-reflector which I'm not sure is necessary since the server is available on the same vlan as the ATV.

I was able to narrow it down to this block of code:
https://github.com/AMoo-Miki/homebridge-tuya-lan/blob/f1b4fa9c653c49c4535c4a9af690f481df11f553/lib/TuyaAccessory.js#L200-L205
@AMoo-Miki - is this essentially waiting endlessly for a ping response (cmd 9)?

After playing around with this for a few days, I was able to (somewhat) get around my problem by adding an “intro”: false entry to each of my devices (couldn’t find any reference in the code to a context.intro except when it’s checked prior to the code above). I now see “Sending first query” and “Ready to handle” messages but the plugin seems to get ping timeouts on everything soon after. I’m able to ping all devices from the server when this happens so I’m curious if the timeout is too short or if it “forgets” where they are (I have set static IPs on all the Tuya stuff to keep the troubleshooting consistent).
Couple of questions...

What is the “intro” property for?
I’m getting a ton of “UDP message from...” in the logs that I hadn’t gotten in the past. Is this new?

I'm still curious what some of these status messages mean but I'm going to close this issue.
For anyone else looking to use this on a VLAN, it can be done and it's quite easy once you've got the VLANs setup. Put all your IoT devices and your Homebridge server on one dedicated VLAN (I have a dedicated Homebridge server running as a headless VM). I also enabled the avahi-reflector on my router to allow HomeKit to see the bridge.
My problems stemmed from the fact that I had the server on two VLANs which worked briefly after toggling devices from the Tuya app but would inevitably disconnect. This plugin couldn't find it automatically and would fallback to my static IP in the config even with routing setup on the server.


The select method of the query builder does not work properly

What steps will reproduce the problem?
if we have an active record called Person and we have the following method specifying it's relation to phones, we can't change the query later
/**
     * @return \yii\db\ActiveQuery
     */
    public function getPhones()
    {
        return $this->hasMany(Phones::className(), ['person_id' => 'id'])
            ->select(['id', 'number'])
            ->distinct();
    }

$column = $person->getPhones()->select(['number'])->column();

What is the expected result?
['555-555', '666-666'] // the number column

What do you get instead?
[1, 2]; // the id column

Additional info
If in the second select() you specify a column which was not present in the first select(), the functionality works as expected and you will get the contents of that column. The issue occurs only if the column specified in the second select is already present in the first one.
I tracked the issue to \yii\db\Query::getUniqueColumns() which was introduced in Yii 2.0.14. I think that in the foreach() loop the columns are unset for no specific reason.

Q
A

Yii version
2.0.14

PHP version
7.1

Operating system
Ubuntu 14.04

@eroteev  Try to
$column = $person->getPhones()->select([Phones::tableName() . '.number'])->column();

this is correct?

@bscheshirwork, thanks for the suggestion. Another workaround would be to create different relation in the active record class or avoid using select in it in the first place.
That said I think we should also find a solution to the core problem, because I'm working on a legacy system and it will be difficult for me to track all places in the code which could be affected by this change in the framework. That would also affect new feature development.

@eroteev you have 'number' field on $person AR? Or you have eager loading? the number field just not representative in main request IMHO

Simplified structure of the tables:
person: id
phone: id, person_id, number
Case 1 (mentioned by @bscheshirwork )
  /**
    * @return \yii\db\ActiveQuery
    */
   public function getPhones()
   {
       return $this->hasMany(Phones::className(), ['person_id' => 'id'])
           ->distinct();
   }

$column = $person->getPhones()->select(['number'])->column();
Results in query:
SELECT DISTINCT numberFROMphoneWHEREperson_id=123
Case 2 (my original case):
In the relation I have  ->select(['id', 'number']) and outside I have ->select(['number'])
Results in query:
SELECT DISTINCT * FROM phoneWHEREperson_id=123
Case 3 (prefix the column of the original case with the table name):
Results in query:
SELECT DISTINCT phone.numberFROMphoneWHEREperson_id=123
Case 4 (use a column name which is not specified in the first select call in the AR):
$column = $person->getPhones()->select(['non_existent_column'])->column();
Results in query:
SELECT DISTINCT non_existent_columnFROMphoneWHEREperson_id=123
The problem is in case 2, where the columns gets erased by the query builder for no apparent reason.

So... I think this we have $this is a person in getPhones() and his related hasMany PhonesQuery have primaryModel is a person
https://github.com/yiisoft/yii2/blob/1d336963a553936380acfe1eeb64bb0b1c910457/framework/db/BaseActiveRecord.php#L446
... and query builder use PersonQuery as a main model for build query in select part. Something like this...

note: we can use triple ``` with name of syntax (i.e.sql) to surround code and highlight it


fix: move custom head html to fix favicons

This will fix the problem of favicons not showing up when the website is deployed.

This fix was accidentally merged, I did a hard reset on main and will open a new PR to close the issue (#1)

New Pull Request open: #3


New feature to get posts for a Facebook page.

Coverage remained the same at 100.0% when pulling 524472c894b568272337113dbb93a1ed1b2d92ce on posts_with_paging into f24a5507b95739cc574a6f257246586afa5b369c on master.


Added more test case and README OR operator example.

I added more test cases, in addition to adding an example of the OR operator in readme, that's all for this year.
Bye ! and !! Happy New Year !!
@nathanb  My humble apologies for the multiple pull requests ... lol

Excellent! Thanks!! I'll merge so it's in the GH repo.

Happy New Year to you too! Thanks!


new request please merge

merge it

hey @pkparas it seems like this is a very old merge / rebase, can you try re-applying your changes on a fresh pull? i cant tell what is changed for this


create credentialhelper for docker login in entrypoint

ref:
Configure a credential helper to remove this warning. See
https://docs.docker.com/engine/reference/commandline/login/#credentials-store

https://github.com/stuartsierra/password-store

docker logout $DOCKER_REGISTRY deletes the secret, docker-login action uses same strategy.


Remove in-coordinator (SGv1) RESTv2 API (leave RESTv1)

Similar to #2117, we want to get rid of all of in-coordinator REST API, except for REST v1.
But this should only be done once the new SGv2 REST API has been proven in production: until then we'd like to have a simple rollback option.

Fixed on 2.1 branch in #2640.


AMBARI-22618. New daemon is not shown on Ambari UI even though added …

What changes were proposed in this pull request?
New daemon is not shown on Ambari UI even though added in metainfo.xml
How was this patch tested?
unit 21835 passed, manually
Please review Ambari Contributing Guide before opening a pull request.

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/Ambari-Github-PullRequest-Builder/4133/
Test PASSed.


Update audio-and-video.md

Fixed typo

@Trevorthe37th : Thanks for your contribution! The author(s) have been notified to review your proposed change.


Password not replaced in SQLAlchemy URL when impersonation is enabled causing 401 Unauthorized

Hi everybody, we use Superset to execute queries on a PrestoDB cluster.
We activated the impersonation feature on our PrestoDB connection, because we want to identify which user run which query just for auditing.
But when this feature is activated, all queries run result in a HTTP 401 error.
FYI, we have securized our PrestoDB cluster with SSL access and LDAP authentifcation, so PrestoDB URL configured in Superset includes basic authentication with user:password inside it (see attached image).

This error appears right after saving the Presto datasource with those configurations.
After debugging Superset execution, I observed that the impersonation features only replaces the username inside URL but not the password.
So in the resulting impersonated URL, the current user name is associated with the configured password in the datasource, which is not correct.
Superset version
0.28.1
Expected results
Run query with impersonation feature enabled should replace password (is specified) in the datasource URL, like username is.
Actual results
Queries are run with the current username in the datasource URL which has replaced the configured default username of the datasource URL, but the password in the URL remains the default one configure on the datasource.
The attached image shows the error resulting in saving the datasource after having activated the impersonation feature.

Steps to reproduce
Configure PrestoDB datasource with SSL and username/password configured (like shown in attached image), activate impersonation feature, and save the datasource.

I just create database named  hive-username for everyone by using   username:password@host:port/hive,  so the user can login, then choose the db with their name.
The disadvantage is that DB link needs to be maintained, but it does work

I'm having the same problem with a PostgreSQL connection.
Once you enable "impersonate", the connection only works if the logged in user's password is the same as the database setup URI password.

@haydenwhitehead @nladuguie  how you guys solved this issue facing similar issue https://github.com/apache/incubator-superset/issues/11359 ?

https://github.com/apache/incubator-superset/pull/9422/files fixes it


Made a simple animated mp4/gif to demonstrate wiki-hub

GIF:

MP4:
https://github.com/erlend-sh/erlend-sh.github.io/blob/master/images/wikihub-presentation.mp4

Cool, but it made my browser tab crash eating memory, could you compress it or something?
I'll give you push access to wiki-hub so you put this in the readme and make any documentation or presentation changes you see fit.

Really? That's odd. Well the mp4 is quite compressed already, but gifs work in mysterious ways...
I tried making one video Imgur's video-to-gif converter instead, but it's super strange. The more I pre-compress the .mp4 file I feed it, the bigger the gif turns out!
http://imgur.com/Of336jY

My computer can handle the gif in imgur, thanks. It could just be that my
computer's too old, I am running window vista...
On Wed, Sep 9, 2015 at 12:36 PM, Erlend Sogge Heggen <
<EMAIL_ADDRESS>wrote:

Really? That's odd. Well the mp4 is quite compressed already, but gifs
work in mysterious ways...
I tried making one video Imgur's video-to-gif converter instead, but it's
super strange. The more I pre-compress the .mp4 file I feed it, the bigger
the gif turns out!
http://imgur.com/Of336jY
—
Reply to this email directly or view it on GitHub
https://github.com/wiki-hub/wiki-hub/issues/4#issuecomment-138883675.

The one on imgur is 15 mb though ^^ I made yet another gif in the Nth gif creator I tried, and got it down to 1mb with reasonable quality. Will use that one, since I don't wanna impose a 15mb load on unsuspecting GitHub visitors.