idea: numerous fixes and improvements

Motivation for this change
Improve JetBrains IDE packages.

Fix #24453: JetBrains IDEs are put under wrong scope
sort packages alphabetically in default.nix to reduce a mess
update CLion, Datagrip, RubyMine to latest versions
add Rider and Gogland IDEs, this makes JetBrains IDE set for NixOS complete

Things done

[ ] Tested using sandboxing
(nix.useSandbox on NixOS,
or option build-use-sandbox in nix.conf
on non-NixOS)
Built on platform(s)

[X] NixOS
[ ] macOS
[ ] Linux

[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
[X] Tested execution of all binary files (usually in ./result/bin/)
[X] Fits CONTRIBUTING.md.

I really like the changes. However I think that you should document the breaking change done by renaming idea to jetbrains in all-packages.nix

@Ma27, good catch! Added a note to release notes.

I like the rename. Please add an deprecated alias to aliases.nix.

@chris-martin, done.


[e2e]: container workflow_dispatch branch1 default slsa3

Repo: https://github.com/slsa-framework/example-package/tree/branch1
Run: https://github.com/slsa-framework/example-package/actions/runs/3662381663
Workflow file: https://github.com/slsa-framework/example-package/tree/main/.github/workflows/e2e.container.workflow_dispatch.branch1.default.slsa3.yml
Workflow runs: https://github.com/slsa-framework/example-package/actions/workflows/e2e.container.workflow_dispatch.branch1.default.slsa3.yml
Trigger: workflow_dispatch
Branch: branch1
Date: Sat Dec 10 03:10:25 UTC 2022

Repo: https://github.com/slsa-framework/example-package/tree/branch1
Run: https://github.com/slsa-framework/example-package/actions/runs/3667149296
Workflow file: https://github.com/slsa-framework/example-package/tree/main/.github/workflows/e2e.container.workflow_dispatch.branch1.default.slsa3.yml
Workflow runs: https://github.com/slsa-framework/example-package/actions/workflows/e2e.container.workflow_dispatch.branch1.default.slsa3.yml
Trigger: workflow_dispatch
Branch: branch1
Date: Sun Dec 11 03:16:42 UTC 2022

Repo: https://github.com/slsa-framework/example-package/tree/branch1
Run: https://github.com/slsa-framework/example-package/actions/runs/3672308399
Workflow file: https://github.com/slsa-framework/example-package/tree/main/.github/workflows/e2e.container.workflow_dispatch.branch1.default.slsa3.yml
Workflow runs: https://github.com/slsa-framework/example-package/actions/workflows/e2e.container.workflow_dispatch.branch1.default.slsa3.yml
Trigger: workflow_dispatch
Branch: branch1
Date: Mon Dec 12 03:16:54 UTC 2022

Repo: https://github.com/slsa-framework/example-package/tree/main
Run: https://github.com/slsa-framework/example-package/actions/runs/3678051851
Workflow file: https://github.com/slsa-framework/example-package/tree/main/.github/workflows/e2e.container.workflow_dispatch.branch1.default.slsa3.yml
Workflow runs: https://github.com/slsa-framework/example-package/actions/workflows/e2e.container.workflow_dispatch.branch1.default.slsa3.yml
Trigger: workflow_dispatch
Branch: main
Date: Mon Dec 12 17:11:10 UTC 2022
Tests are passing now. Closing this issue.


Fixed Issue of Review Menu Shown Behind

Fixed #31144

And there is a regression bug from  Simplify review UI #31062 , the dropdown doesn't get properly initialized when "show more files"

Overall it should be like this 1957c87ac31b125035a8d4c76a0ca7038d387672

https://github.com/go-gitea/gitea/pull/32631/commits/9faaa4084588490d65e73b1b23d567669750a162
before:

after:


Generate .pb.go files

This uses the gogo repository and new proto rules to generate the .pb.go
files on demand.
Note that this has to use my fork of gogo/protobuf (the bazel rules are not in a good enough shape to ask them to accept them yet, just good enough to use the plugins) and my fork of rules go (although the changes are already in a pull request so that won't be for long)

Thanks!
@ianthehat Just for reference…

your fork of gogo/protobuf is https://github.com/ianthehat/protobuf/tree/bazel ?
your fork of rules_go was this PR https://github.com/bazelbuild/rules_go/pull/833, which has since been merged & this PR updated to use official rules_go ?

Testing locally, build seems to work…
$ bazel build //cmd/...
INFO: Found 16 targets...
INFO: From Compiling external/com_google_protobuf/src/google/protobuf/compiler/js/embed.cc [for host]:
external/com_google_protobuf/src/google/protobuf/compiler/js/embed.cc:37:12: warning: unused variable 'output_file' [-Wunused-const-variable]
const char output_file[] = "well_known_types_embed.cc";
           ^
1 warning generated.
INFO: From Linking external/com_google_protobuf/libprotobuf_lite.a [for host]:
/Library/Developer/CommandLineTools/usr/bin/libtool: file: bazel-out/host/bin/external/com_google_protobuf/_objs/protobuf_lite/external/com_google_protobuf/src/google/protobuf/arenastring.o has no symbols
/Library/Developer/CommandLineTools/usr/bin/libtool: file: bazel-out/host/bin/external/com_google_protobuf/_objs/protobuf_lite/external/com_google_protobuf/src/google/protobuf/stubs/atomicops_internals_x86_msvc.o has no symbols
/Library/Developer/CommandLineTools/usr/bin/libtool: file: bazel-out/host/bin/external/com_google_protobuf/_objs/protobuf_lite/external/com_google_protobuf/src/google/protobuf/stubs/io_win32.o has no symbols
INFO: From Linking external/com_google_protobuf/libprotobuf.a [for host]:
/Library/Developer/CommandLineTools/usr/bin/libtool: file: bazel-out/host/bin/external/com_google_protobuf/_objs/protobuf/external/com_google_protobuf/src/google/protobuf/io/gzip_stream.o has no symbols
/Library/Developer/CommandLineTools/usr/bin/libtool: file: bazel-out/host/bin/external/com_google_protobuf/_objs/protobuf/external/com_google_protobuf/src/google/protobuf/util/internal/error_listener.o has no symbols
INFO: From Linking external/com_github_google_protobuf/libprotobuf.a [for host]:
/Library/Developer/CommandLineTools/usr/bin/libtool: file: bazel-out/host/bin/external/com_github_google_protobuf/_objs/protobuf/external/com_github_google_protobuf/src/google/protobuf/io/gzip_stream.o has no symbols
/Library/Developer/CommandLineTools/usr/bin/libtool: file: bazel-out/host/bin/external/com_github_google_protobuf/_objs/protobuf/external/com_github_google_protobuf/src/google/protobuf/util/internal/error_listener.o has no symbols
INFO: From Linking external/com_github_google_protobuf/libprotobuf_lite.a [for host]:
/Library/Developer/CommandLineTools/usr/bin/libtool: file: bazel-out/host/bin/external/com_github_google_protobuf/_objs/protobuf_lite/external/com_github_google_protobuf/src/google/protobuf/arenastring.o has no symbols
/Library/Developer/CommandLineTools/usr/bin/libtool: file: bazel-out/host/bin/external/com_github_google_protobuf/_objs/protobuf_lite/external/com_github_google_protobuf/src/google/protobuf/stubs/atomicops_internals_x86_msvc.o has no symbols
/Library/Developer/CommandLineTools/usr/bin/libtool: file: bazel-out/host/bin/external/com_github_google_protobuf/_objs/protobuf_lite/external/com_github_google_protobuf/src/google/protobuf/stubs/io_win32.o has no symbols
INFO: From Compiling external/com_github_google_protobuf/src/google/protobuf/compiler/js/embed.cc [for host]:
external/com_github_google_protobuf/src/google/protobuf/compiler/js/embed.cc:37:12: warning: unused variable 'output_file' [-Wunused-const-variable]
const char output_file[] = "well_known_types_embed.cc";
           ^
1 warning generated.
INFO: From Linking vendor/golang.org/x/sys/unix/libgo_default_library.cgo_c_lib.lo:
/Library/Developer/CommandLineTools/usr/bin/libtool: file: bazel-out/local-fastbuild/bin/vendor/golang.org/x/sys/unix/_objs/go_default_library.cgo_c_lib/vendor/golang.org/x/sys/unix/go_default_library.cgo.dir/_cgo_export.pic.o has no symbols
/Library/Developer/CommandLineTools/usr/bin/libtool: file: bazel-out/local-fastbuild/bin/vendor/golang.org/x/sys/unix/_objs/go_default_library.cgo_c_lib/vendor/golang.org/x/sys/unix/go_default_library.cgo.dir/vendor_golang.org_x_sys_unix_env_unset.cgo2.pic.o has no symbols
/Library/Developer/CommandLineTools/usr/bin/libtool: file: bazel-out/local-fastbuild/bin/vendor/golang.org/x/sys/unix/_objs/go_default_library.cgo_c_lib/vendor/golang.org/x/sys/unix/go_default_library.cgo.dir/vendor_golang.org_x_sys_unix_constants.cgo2.pic.o has no symbols
/Library/Developer/CommandLineTools/usr/bin/libtool: file: bazel-out/local-fastbuild/bin/vendor/golang.org/x/sys/unix/_objs/go_default_library.cgo_c_lib/vendor/golang.org/x/sys/unix/go_default_library.cgo.dir/vendor_golang.org_x_sys_unix_dirent.cgo2.pic.o has no symbols
/Library/Developer/CommandLineTools/usr/bin/libtool: file: bazel-out/local-fastbuild/bin/vendor/golang.org/x/sys/unix/_objs/go_default_library.cgo_c_lib/vendor/golang.org/x/sys/unix/go_default_library.cgo.dir/vendor_golang.org_x_sys_unix_endian_little.cgo2.pic.o has no symbols
/Library/Developer/CommandLineTools/usr/bin/libtool: file: bazel-out/local-fastbuild/bin/vendor/golang.org/x/sys/unix/_objs/go_default_library.cgo_c_lib/vendor/golang.org/x/sys/unix/go_default_library.cgo.dir/vendor_golang.org_x_sys_unix_env_unix.cgo2.pic.o has no symbols
/Library/Developer/CommandLineTools/usr/bin/libtool: file: bazel-out/local-fastbuild/bin/vendor/golang.org/x/sys/unix/_objs/go_default_library.cgo_c_lib/vendor/golang.org/x/sys/unix/go_default_library.cgo.dir/vendor_golang.org_x_sys_unix_flock.cgo2.pic.o has no symbols
/Library/Developer/CommandLineTools/usr/bin/libtool: file: bazel-out/local-fastbuild/bin/vendor/golang.org/x/sys/unix/_objs/go_default_library.cgo_c_lib/vendor/golang.org/x/sys/unix/go_default_library.cgo.dir/vendor_golang.org_x_sys_unix_race0.cgo2.pic.o has no symbols
/Library/Developer/CommandLineTools/usr/bin/libtool: file: bazel-out/local-fastbuild/bin/vendor/golang.org/x/sys/unix/_objs/go_default_library.cgo_c_lib/vendor/golang.org/x/sys/unix/go_default_library.cgo.dir/vendor_golang.org_x_sys_unix_sockcmsg_unix.cgo2.pic.o has no symbols
/Library/Developer/CommandLineTools/usr/bin/libtool: file: bazel-out/local-fastbuild/bin/vendor/golang.org/x/sys/unix/_objs/go_default_library.cgo_c_lib/vendor/golang.org/x/sys/unix/go_default_library.cgo.dir/vendor_golang.org_x_sys_unix_str.cgo2.pic.o has no symbols
/Library/Developer/CommandLineTools/usr/bin/libtool: file: bazel-out/local-fastbuild/bin/vendor/golang.org/x/sys/unix/_objs/go_default_library.cgo_c_lib/vendor/golang.org/x/sys/unix/go_default_library.cgo.dir/vendor_golang.org_x_sys_unix_syscall.cgo2.pic.o has no symbols
/Library/Developer/CommandLineTools/usr/bin/libtool: file: bazel-out/local-fastbuild/bin/vendor/golang.org/x/sys/unix/_objs/go_default_library.cgo_c_lib/vendor/golang.org/x/sys/unix/go_default_library.cgo.dir/vendor_golang.org_x_sys_unix_syscall_bsd.cgo2.pic.o has no symbols
/Library/Developer/CommandLineTools/usr/bin/libtool: file: bazel-out/local-fastbuild/bin/vendor/golang.org/x/sys/unix/_objs/go_default_library.cgo_c_lib/vendor/golang.org/x/sys/unix/go_default_library.cgo.dir/vendor_golang.org_x_sys_unix_syscall_darwin.cgo2.pic.o has no symbols
/Library/Developer/CommandLineTools/usr/bin/libtool: file: bazel-out/local-fastbuild/bin/vendor/golang.org/x/sys/unix/_objs/go_default_library.cgo_c_lib/vendor/golang.org/x/sys/unix/go_default_library.cgo.dir/vendor_golang.org_x_sys_unix_syscall_darwin_amd64.cgo2.pic.o has no symbols
/Library/Developer/CommandLineTools/usr/bin/libtool: file: bazel-out/local-fastbuild/bin/vendor/golang.org/x/sys/unix/_objs/go_default_library.cgo_c_lib/vendor/golang.org/x/sys/unix/go_default_library.cgo.dir/vendor_golang.org_x_sys_unix_syscall_unix.cgo2.pic.o has no symbols
/Library/Developer/CommandLineTools/usr/bin/libtool: file: bazel-out/local-fastbuild/bin/vendor/golang.org/x/sys/unix/_objs/go_default_library.cgo_c_lib/vendor/golang.org/x/sys/unix/go_default_library.cgo.dir/vendor_golang.org_x_sys_unix_syscall_unix_gc.cgo2.pic.o has no symbols
/Library/Developer/CommandLineTools/usr/bin/libtool: file: bazel-out/local-fastbuild/bin/vendor/golang.org/x/sys/unix/_objs/go_default_library.cgo_c_lib/vendor/golang.org/x/sys/unix/go_default_library.cgo.dir/vendor_golang.org_x_sys_unix_zerrors_darwin_amd64.cgo2.pic.o has no symbols
/Library/Developer/CommandLineTools/usr/bin/libtool: file: bazel-out/local-fastbuild/bin/vendor/golang.org/x/sys/unix/_objs/go_default_library.cgo_c_lib/vendor/golang.org/x/sys/unix/go_default_library.cgo.dir/vendor_golang.org_x_sys_unix_zsyscall_darwin_amd64.cgo2.pic.o has no symbols
/Library/Developer/CommandLineTools/usr/bin/libtool: file: bazel-out/local-fastbuild/bin/vendor/golang.org/x/sys/unix/_objs/go_default_library.cgo_c_lib/vendor/golang.org/x/sys/unix/go_default_library.cgo.dir/vendor_golang.org_x_sys_unix_zsysnum_darwin_amd64.cgo2.pic.o has no symbols
/Library/Developer/CommandLineTools/usr/bin/libtool: file: bazel-out/local-fastbuild/bin/vendor/golang.org/x/sys/unix/_objs/go_default_library.cgo_c_lib/vendor/golang.org/x/sys/unix/go_default_library.cgo.dir/vendor_golang.org_x_sys_unix_ztypes_darwin_amd64.cgo2.pic.o has no symbols
warning: /Library/Developer/CommandLineTools/usr/bin/libtool: warning for library: bazel-out/local-fastbuild/bin/vendor/golang.org/x/sys/unix/libgo_default_library.cgo_c_lib.lo the table of contents is empty (no object file members in the library define global symbols)
INFO: From Linking vendor/golang.org/x/sys/unix/go_default_library._cgo_.o:
clang: warning: argument unused during compilation: '-pthread' [-Wunused-command-line-argument]
INFO: Elapsed time: 319.015s, Critical Path: 36.08s

But tests don't…
$ bazel test //pkg/...
INFO: Found 25 targets and 9 test targets...
ERROR: /Users/jml/go/src/github.com/weaveworks/cortex/pkg/ingester/client/BUILD.bazel:11:1: GoCompile pkg/ingester/client/~normal~cortex_go_proto~/github.com/weaveworks/cortex/pkg/ingester/client.a failed (Exit 1).
2017/09/17 10:05:35 missing strict dependencies:
	bazel-out/local-fastbuild/bin/pkg/ingester/client/github.com/weaveworks/cortex/pkg/ingester/client/cortex.pb.go: import of github.com/gogo/protobuf/proto, which is not a direct dependency
	bazel-out/local-fastbuild/bin/pkg/ingester/client/github.com/weaveworks/cortex/pkg/ingester/client/cortex.pb.go: import of github.com/weaveworks/cortex/pkg/util/wire, which is not a direct dependency
	bazel-out/local-fastbuild/bin/pkg/ingester/client/github.com/weaveworks/cortex/pkg/ingester/client/cortex.pb.go: import of golang.org/x/net/context, which is not a direct dependency
	bazel-out/local-fastbuild/bin/pkg/ingester/client/github.com/weaveworks/cortex/pkg/ingester/client/cortex.pb.go: import of google.golang.org/grpc, which is not a direct dependency
INFO: Elapsed time: 1.703s, Critical Path: 1.06s
//pkg/chunk:go_default_test                                           NO STATUS
//pkg/configs/api:go_default_xtest                                    NO STATUS
//pkg/configs/client:go_default_test                                  NO STATUS
//pkg/distributor:go_default_test                                     NO STATUS
//pkg/ingester:go_default_test                                        NO STATUS
//pkg/querier:go_default_test                                         NO STATUS
//pkg/ring:go_default_test                                            NO STATUS
//pkg/ruler:go_default_test                                           NO STATUS
//pkg/util:go_default_test                                            NO STATUS

Executed 0 out of 9 tests: 9 were skipped.

Investigating.

This is indeed most excellent!  A few questions / comments:

Changes in the vendor dir shouldn't be made directly, you should use the dep tool to update it. If you did then you're missing changes to Gopkg.toml and Gopkg.lock.
Have you open a PR / spoke to the gogo guys about upstreaming the changes?  I think its fine using a fork for a little while, but its not something we should depend on long term, so I'd be keen to see if this is something they'd accept in principle.  If not, there are alternative way, less desirable ways to do this (using gen_rules for instance).
In https://github.com/gogo/protobuf/compare/master...ianthehat:bazel?expand=1 I see you're using checked-in generated .pb.go files - is this intentional?  Now that bazel can generate them with your other PR, I'd have thought it would be best to generate them here too?

Otherwise I think this change looks excellent - I particularly like the embed = [":cortex_go_proto"], bits, I've been looking for a way to do that for a month or so!

Ran out of time to investigate.

I wasn't really expecting this pr to get submitted, I was just putting it up so you could try it and comment :)
Yes that is my gogo fork, and yes, that was the rules_go fork that is already merged.
The changes in vendor are legacy from when I was seeing what it would take to make the gogo repository play nice, the changes are all in my fork which is pulled directly from the workspace now.
The test problems look like I did not add the deps to the gogo toolchain, that's a fairly trivial fix.
The changes in the gogo repository were generated by gazelle and then hand adjusted and added to only in places where I needed to to make the plugins work and add the toolchains rules. They are far from correct, but I am waiting for the full changes to gazelle to arrive so I can regenerated them before I consider putting it up as a pull request to the main gogo repository. This is also why they are doing things like using the checked in .pb.go files...
If they won't accept the changes it's not a big deal, we can do it all with an external flat mode build file. I am just trying to be a good citizen by contributing an alternative that works better than make to their project while I am looking at it anyway :)
Note that I know nothing about weaveworks, I have no idea what this project does, and I have not run or tested the results in any way at all, so you are going to have to make sure I have not broken something before you start using this.
I am also not happy that the vendor directory is an unbuildable mess, I was originally trying to do
bazel test //...

Which is my basic mode of operation on all bazel projects, but it does not stand a hope of building the vendor dir right now, so I dropped back to
bazel build //cmd/...

because I assume that had to build, but it has no tests.
What I might try to do is write a tool to update a workspace from a lock file, and then not use the vendor dir at all, just exclude it from the build, but that's not going to happen in a hurry, I have too many other things to make work first (like windows)

I wasn't really expecting this pr to get submitted, I was just putting it up so you could try it and comment :)

@ianthehat, thank you for that! It's extremely helpful. Certainly didn't mean to imply that you were on the hook for fixing everything—I'm grateful for what you've done already.

The test problems look like I did not add the deps to the gogo toolchain, that's a fairly trivial fix.

Not 100% sure what this means, but maybe that's because I'm still not precise on Bazel terminology (or because I'm not awake yet).
Naively, one of the missing deps is github.com/weaveworks/cortex/pkg/util/wire, which is specific to Cortex and not a part of the toolchain, so it probably shouldn't be added there?

Nice one; one nit - tools is a subtree of weaveworks/build-tools, so you might want to find a different place for those files.
I'll do a thorough review tomorrow evening, but a quick first pass looks good.

@tomwilkie Happy for you to do the review, but LMK if you can't get to it soon & I'll get onto it next week.

I am changing the proto rules again after feedback on the current system.
see bazelbuild/rules_go#1098 for the first change.
Would you like me to update this to use the new system with the gogo plugin?

Yes please!
On Fri, 1 Dec 2017 at 21:18 Ian Cottrell<EMAIL_ADDRESS>wrote:

I am changing the proto rules again after feedback on the current system.
see bazelbuild/rules_go#1098
https://github.com/bazelbuild/rules_go/pull/1098 for the first change.
Would you like me to update this to use the new system with the gogo
plugin?
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/weaveworks/cortex/pull/564#issuecomment-348616861,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAHq6m_Ap5ka_8RfIfb7xgzcAxTlR0qhks5s8G02gaJpZM4PZRkK
.

This now works with the new system (you also need the as yet not submitted bazelbuild/rules_go#1102)

Thanks @ianthehat! I'll take a look as soon as I may.
On Mon, 4 Dec 2017 at 23:51 Ian Cottrell<EMAIL_ADDRESS>wrote:

This now works with the new system (you also need the as yet not submitted
bazelbuild/rules_go#1102
https://github.com/bazelbuild/rules_go/pull/1102)
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/weaveworks/cortex/pull/564#issuecomment-349147256,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAHq6inmmMFrmB-K3JC4ZMA32H_7EM6qks5s9IVqgaJpZM4PZRkK
.

I just tried this out.
Before trying anything I made the following local change:
--- a/WORKSPACE
+++ b/WORKSPACE
@@ -2,8 +2,8 @@ workspace(name = "com_github_weaveworks_cortex")

 http_archive(
     name = "io_bazel_rules_go",
-    url = "https://codeload.github.com/bazelbuild/rules_go/zip/0fb90c43c5fab2a0b2d7a8684f26f6995d9aa212",
-    strip_prefix = "rules_go-0fb90c43c5fab2a0b2d7a8684f26f6995d9aa212",
+    url = "https://codeload.github.com/bazelbuild/rules_go/zip/43e3cadb0469e3ada11ac0371f924004c77ea01a",
+    strip_prefix = "rules_go-43e3cadb0469e3ada11ac0371f924004c77ea01a",
     type = "zip",
 )

In order to pull in bazelbuild/rules_go#1102 as mentioned.
First time I got errors like:
error: could not expand include path '~/.gitcinclude'
fatal: bad config line 49 in file /usr/local/git/etc/gitconfig

Which is because brew installs a global git config with ~ in paths, and Bazel unsets $HOME.
After working around that, bazel build //cmd/... failed again with:
ERROR: /private/var/tmp/_bazel_jml/c3efe7604fd21db2522d82194bf89683/external/com_github_gogo_protobuf/gogoproto/BUILD.bazel:19:1: GoCompile external/com_github_gogo_protobuf/gogoproto/darwin_amd64_stripped/go_default_library~/github.com/gogo/protobuf/gogoproto.a failed (Exit 1)
external/com_github_gogo_protobuf/gogoproto/helper.go:35:37: cannot use E_Embed (type *"github.com/golang/protobuf/proto".ExtensionDesc) as type *"github.com/gogo/protobuf/proto".ExtensionDesc in argument to "github.com/gogo/protobuf/proto".GetBoolExtension

Full output:
$ bazel build //cmd/...
INFO: Analysed 16 targets (6 packages loaded).
INFO: Found 16 targets...
INFO: From Compiling external/com_google_protobuf/src/google/protobuf/compiler/js/embed.cc [for host]:
external/com_google_protobuf/src/google/protobuf/compiler/js/embed.cc:37:12: warning: unused variable 'output_file' [-Wunused-const-variable]
const char output_file[] = "well_known_types_embed.cc";
           ^
1 warning generated.
INFO: From Linking external/com_google_protobuf/libprotobuf_lite.a [for host]:
/Library/Developer/CommandLineTools/usr/bin/libtool: file: bazel-out/host/bin/external/com_google_protobuf/_objs/protobuf_lite/external/com_google_protobuf/src/google/protobuf/arenastring.o has no symbols
/Library/Developer/CommandLineTools/usr/bin/libtool: file: bazel-out/host/bin/external/com_google_protobuf/_objs/protobuf_lite/external/com_google_protobuf/src/google/protobuf/stubs/atomicops_internals_x86_msvc.o has no symbols
/Library/Developer/CommandLineTools/usr/bin/libtool: file: bazel-out/host/bin/external/com_google_protobuf/_objs/protobuf_lite/external/com_google_protobuf/src/google/protobuf/stubs/io_win32.o has no symbols
INFO: From Linking external/com_google_protobuf/libprotobuf.a [for host]:
/Library/Developer/CommandLineTools/usr/bin/libtool: file: bazel-out/host/bin/external/com_google_protobuf/_objs/protobuf/external/com_google_protobuf/src/google/protobuf/io/gzip_stream.o has no symbols
/Library/Developer/CommandLineTools/usr/bin/libtool: file: bazel-out/host/bin/external/com_google_protobuf/_objs/protobuf/external/com_google_protobuf/src/google/protobuf/util/internal/error_listener.o has no symbols
INFO: From Linking external/com_github_google_protobuf/libprotobuf_lite.a [for host]:
/Library/Developer/CommandLineTools/usr/bin/libtool: file: bazel-out/host/bin/external/com_github_google_protobuf/_objs/protobuf_lite/external/com_github_google_protobuf/src/google/protobuf/arenastring.o has no symbols
/Library/Developer/CommandLineTools/usr/bin/libtool: file: bazel-out/host/bin/external/com_github_google_protobuf/_objs/protobuf_lite/external/com_github_google_protobuf/src/google/protobuf/stubs/atomicops_internals_x86_msvc.o has no symbols
/Library/Developer/CommandLineTools/usr/bin/libtool: file: bazel-out/host/bin/external/com_github_google_protobuf/_objs/protobuf_lite/external/com_github_google_protobuf/src/google/protobuf/stubs/io_win32.o has no symbols
INFO: From Linking external/com_github_google_protobuf/libprotobuf.a [for host]:
/Library/Developer/CommandLineTools/usr/bin/libtool: file: bazel-out/host/bin/external/com_github_google_protobuf/_objs/protobuf/external/com_github_google_protobuf/src/google/protobuf/io/gzip_stream.o has no symbols
/Library/Developer/CommandLineTools/usr/bin/libtool: file: bazel-out/host/bin/external/com_github_google_protobuf/_objs/protobuf/external/com_github_google_protobuf/src/google/protobuf/util/internal/error_listener.o has no symbols
INFO: From Compiling external/com_github_google_protobuf/src/google/protobuf/compiler/js/embed.cc [for host]:
external/com_github_google_protobuf/src/google/protobuf/compiler/js/embed.cc:37:12: warning: unused variable 'output_file' [-Wunused-const-variable]
const char output_file[] = "well_known_types_embed.cc";
           ^
1 warning generated.
INFO: From GoStdlib external/go_stdlib_darwin_amd64_cgo/bin/go [for host]:
# runtime/cgo
clang: warning: argument unused during compilation: '-pthread' [-Wunused-command-line-argument]
clang: warning: argument unused during compilation: '-gno-record-gcc-switches' [-Wunused-command-line-argument]
# runtime/cgo
clang: warning: argument unused during compilation: '-pthread' [-Wunused-command-line-argument]
clang: warning: argument unused during compilation: '-gno-record-gcc-switches' [-Wunused-command-line-argument]
clang: warning: argument unused during compilation: '-nopie' [-Wunused-command-line-argument]
# os/user
clang: warning: argument unused during compilation: '-pthread' [-Wunused-command-line-argument]
clang: warning: argument unused during compilation: '-gno-record-gcc-switches' [-Wunused-command-line-argument]
# os/user
clang: warning: argument unused during compilation: '-pthread' [-Wunused-command-line-argument]
clang: warning: argument unused during compilation: '-gno-record-gcc-switches' [-Wunused-command-line-argument]
clang: warning: argument unused during compilation: '-nopie' [-Wunused-command-line-argument]
# net
clang: warning: argument unused during compilation: '-pthread' [-Wunused-command-line-argument]
clang: warning: argument unused during compilation: '-gno-record-gcc-switches' [-Wunused-command-line-argument]
# net
clang: warning: argument unused during compilation: '-pthread' [-Wunused-command-line-argument]
clang: warning: argument unused during compilation: '-gno-record-gcc-switches' [-Wunused-command-line-argument]
clang: warning: argument unused during compilation: '-nopie' [-Wunused-command-line-argument]
# plugin
clang: warning: argument unused during compilation: '-pthread' [-Wunused-command-line-argument]
clang: warning: argument unused during compilation: '-gno-record-gcc-switches' [-Wunused-command-line-argument]
# plugin
clang: warning: argument unused during compilation: '-pthread' [-Wunused-command-line-argument]
clang: warning: argument unused during compilation: '-gno-record-gcc-switches' [-Wunused-command-line-argument]
clang: warning: argument unused during compilation: '-nopie' [-Wunused-command-line-argument]
# crypto/x509
clang: warning: argument unused during compilation: '-pthread' [-Wunused-command-line-argument]
clang: warning: argument unused during compilation: '-gno-record-gcc-switches' [-Wunused-command-line-argument]
# crypto/x509
clang: warning: argument unused during compilation: '-pthread' [-Wunused-command-line-argument]
clang: warning: argument unused during compilation: '-gno-record-gcc-switches' [-Wunused-command-line-argument]
clang: warning: argument unused during compilation: '-nopie' [-Wunused-command-line-argument]
INFO: From Linking vendor/golang.org/x/sys/unix/libgo_default_library.cgo_c_lib.lo:
/Library/Developer/CommandLineTools/usr/bin/libtool: file: bazel-out/darwin-fastbuild/bin/vendor/golang.org/x/sys/unix/_objs/go_default_library.cgo_c_lib/vendor/golang.org/x/sys/unix/go_default_library.cgo_codegen~/_cgo_export.pic.o has no symbols
/Library/Developer/CommandLineTools/usr/bin/libtool: file: bazel-out/darwin-fastbuild/bin/vendor/golang.org/x/sys/unix/_objs/go_default_library.cgo_c_lib/vendor/golang.org/x/sys/unix/go_default_library.cgo_codegen~/vendor_golang.org_x_sys_unix_env_unset.cgo2.pic.o has no symbols
/Library/Developer/CommandLineTools/usr/bin/libtool: file: bazel-out/darwin-fastbuild/bin/vendor/golang.org/x/sys/unix/_objs/go_default_library.cgo_c_lib/vendor/golang.org/x/sys/unix/go_default_library.cgo_codegen~/vendor_golang.org_x_sys_unix_constants.cgo2.pic.o has no symbols
/Library/Developer/CommandLineTools/usr/bin/libtool: file: bazel-out/darwin-fastbuild/bin/vendor/golang.org/x/sys/unix/_objs/go_default_library.cgo_c_lib/vendor/golang.org/x/sys/unix/go_default_library.cgo_codegen~/vendor_golang.org_x_sys_unix_dirent.cgo2.pic.o has no symbols
/Library/Developer/CommandLineTools/usr/bin/libtool: file: bazel-out/darwin-fastbuild/bin/vendor/golang.org/x/sys/unix/_objs/go_default_library.cgo_c_lib/vendor/golang.org/x/sys/unix/go_default_library.cgo_codegen~/vendor_golang.org_x_sys_unix_endian_little.cgo2.pic.o has no symbols
/Library/Developer/CommandLineTools/usr/bin/libtool: file: bazel-out/darwin-fastbuild/bin/vendor/golang.org/x/sys/unix/_objs/go_default_library.cgo_c_lib/vendor/golang.org/x/sys/unix/go_default_library.cgo_codegen~/vendor_golang.org_x_sys_unix_env_unix.cgo2.pic.o has no symbols
/Library/Developer/CommandLineTools/usr/bin/libtool: file: bazel-out/darwin-fastbuild/bin/vendor/golang.org/x/sys/unix/_objs/go_default_library.cgo_c_lib/vendor/golang.org/x/sys/unix/go_default_library.cgo_codegen~/vendor_golang.org_x_sys_unix_flock.cgo2.pic.o has no symbols
/Library/Developer/CommandLineTools/usr/bin/libtool: file: bazel-out/darwin-fastbuild/bin/vendor/golang.org/x/sys/unix/_objs/go_default_library.cgo_c_lib/vendor/golang.org/x/sys/unix/go_default_library.cgo_codegen~/vendor_golang.org_x_sys_unix_race0.cgo2.pic.o has no symbols
/Library/Developer/CommandLineTools/usr/bin/libtool: file: bazel-out/darwin-fastbuild/bin/vendor/golang.org/x/sys/unix/_objs/go_default_library.cgo_c_lib/vendor/golang.org/x/sys/unix/go_default_library.cgo_codegen~/vendor_golang.org_x_sys_unix_sockcmsg_unix.cgo2.pic.o has no symbols
/Library/Developer/CommandLineTools/usr/bin/libtool: file: bazel-out/darwin-fastbuild/bin/vendor/golang.org/x/sys/unix/_objs/go_default_library.cgo_c_lib/vendor/golang.org/x/sys/unix/go_default_library.cgo_codegen~/vendor_golang.org_x_sys_unix_str.cgo2.pic.o has no symbols
/Library/Developer/CommandLineTools/usr/bin/libtool: file: bazel-out/darwin-fastbuild/bin/vendor/golang.org/x/sys/unix/_objs/go_default_library.cgo_c_lib/vendor/golang.org/x/sys/unix/go_default_library.cgo_codegen~/vendor_golang.org_x_sys_unix_syscall.cgo2.pic.o has no symbols
/Library/Developer/CommandLineTools/usr/bin/libtool: file: bazel-out/darwin-fastbuild/bin/vendor/golang.org/x/sys/unix/_objs/go_default_library.cgo_c_lib/vendor/golang.org/x/sys/unix/go_default_library.cgo_codegen~/vendor_golang.org_x_sys_unix_syscall_bsd.cgo2.pic.o has no symbols
/Library/Developer/CommandLineTools/usr/bin/libtool: file: bazel-out/darwin-fastbuild/bin/vendor/golang.org/x/sys/unix/_objs/go_default_library.cgo_c_lib/vendor/golang.org/x/sys/unix/go_default_library.cgo_codegen~/vendor_golang.org_x_sys_unix_syscall_darwin.cgo2.pic.o has no symbols
/Library/Developer/CommandLineTools/usr/bin/libtool: file: bazel-out/darwin-fastbuild/bin/vendor/golang.org/x/sys/unix/_objs/go_default_library.cgo_c_lib/vendor/golang.org/x/sys/unix/go_default_library.cgo_codegen~/vendor_golang.org_x_sys_unix_syscall_darwin_amd64.cgo2.pic.o has no symbols
/Library/Developer/CommandLineTools/usr/bin/libtool: file: bazel-out/darwin-fastbuild/bin/vendor/golang.org/x/sys/unix/_objs/go_default_library.cgo_c_lib/vendor/golang.org/x/sys/unix/go_default_library.cgo_codegen~/vendor_golang.org_x_sys_unix_syscall_unix.cgo2.pic.o has no symbols
/Library/Developer/CommandLineTools/usr/bin/libtool: file: bazel-out/darwin-fastbuild/bin/vendor/golang.org/x/sys/unix/_objs/go_default_library.cgo_c_lib/vendor/golang.org/x/sys/unix/go_default_library.cgo_codegen~/vendor_golang.org_x_sys_unix_syscall_unix_gc.cgo2.pic.o has no symbols
/Library/Developer/CommandLineTools/usr/bin/libtool: file: bazel-out/darwin-fastbuild/bin/vendor/golang.org/x/sys/unix/_objs/go_default_library.cgo_c_lib/vendor/golang.org/x/sys/unix/go_default_library.cgo_codegen~/vendor_golang.org_x_sys_unix_zerrors_darwin_amd64.cgo2.pic.o has no symbols
/Library/Developer/CommandLineTools/usr/bin/libtool: file: bazel-out/darwin-fastbuild/bin/vendor/golang.org/x/sys/unix/_objs/go_default_library.cgo_c_lib/vendor/golang.org/x/sys/unix/go_default_library.cgo_codegen~/vendor_golang.org_x_sys_unix_zsyscall_darwin_amd64.cgo2.pic.o has no symbols
/Library/Developer/CommandLineTools/usr/bin/libtool: file: bazel-out/darwin-fastbuild/bin/vendor/golang.org/x/sys/unix/_objs/go_default_library.cgo_c_lib/vendor/golang.org/x/sys/unix/go_default_library.cgo_codegen~/vendor_golang.org_x_sys_unix_zsysnum_darwin_amd64.cgo2.pic.o has no symbols
/Library/Developer/CommandLineTools/usr/bin/libtool: file: bazel-out/darwin-fastbuild/bin/vendor/golang.org/x/sys/unix/_objs/go_default_library.cgo_c_lib/vendor/golang.org/x/sys/unix/go_default_library.cgo_codegen~/vendor_golang.org_x_sys_unix_ztypes_darwin_amd64.cgo2.pic.o has no symbols
warning: /Library/Developer/CommandLineTools/usr/bin/libtool: warning for library: bazel-out/darwin-fastbuild/bin/vendor/golang.org/x/sys/unix/libgo_default_library.cgo_c_lib.lo the table of contents is empty (no object file members in the library define global symbols)
ERROR: /private/var/tmp/_bazel_jml/c3efe7604fd21db2522d82194bf89683/external/com_github_gogo_protobuf/gogoproto/BUILD.bazel:19:1: GoCompile external/com_github_gogo_protobuf/gogoproto/darwin_amd64_stripped/go_default_library~/github.com/gogo/protobuf/gogoproto.a failed (Exit 1)
external/com_github_gogo_protobuf/gogoproto/helper.go:35:37: cannot use E_Embed (type *"github.com/golang/protobuf/proto".ExtensionDesc) as type *"github.com/gogo/protobuf/proto".ExtensionDesc in argument to "github.com/gogo/protobuf/proto".GetBoolExtension
external/com_github_gogo_protobuf/gogoproto/helper.go:39:37: cannot use E_Nullable (type *"github.com/golang/protobuf/proto".ExtensionDesc) as type *"github.com/gogo/protobuf/proto".ExtensionDesc in argument to "github.com/gogo/protobuf/proto".GetBoolExtension
external/com_github_gogo_protobuf/gogoproto/helper.go:43:37: cannot use E_Stdtime (type *"github.com/golang/protobuf/proto".ExtensionDesc) as type *"github.com/gogo/protobuf/proto".ExtensionDesc in argument to "github.com/gogo/protobuf/proto".GetBoolExtension
external/com_github_gogo_protobuf/gogoproto/helper.go:47:37: cannot use E_Stdduration (type *"github.com/golang/protobuf/proto".ExtensionDesc) as type *"github.com/gogo/protobuf/proto".ExtensionDesc in argument to "github.com/gogo/protobuf/proto".GetBoolExtension
external/com_github_gogo_protobuf/gogoproto/helper.go:94:36: cannot use E_Enumdecl (type *"github.com/golang/protobuf/proto".ExtensionDesc) as type *"github.com/gogo/protobuf/proto".ExtensionDesc in argument to "github.com/gogo/protobuf/proto".GetBoolExtension
external/com_github_gogo_protobuf/gogoproto/helper.go:94:85: cannot use E_EnumdeclAll (type *"github.com/golang/protobuf/proto".ExtensionDesc) as type *"github.com/gogo/protobuf/proto".ExtensionDesc in argument to "github.com/gogo/protobuf/proto".GetBoolExtension
external/com_github_gogo_protobuf/gogoproto/helper.go:98:39: cannot use E_Typedecl (type *"github.com/golang/protobuf/proto".ExtensionDesc) as type *"github.com/gogo/protobuf/proto".ExtensionDesc in argument to "github.com/gogo/protobuf/proto".GetBoolExtension
external/com_github_gogo_protobuf/gogoproto/helper.go:98:88: cannot use E_TypedeclAll (type *"github.com/golang/protobuf/proto".ExtensionDesc) as type *"github.com/gogo/protobuf/proto".ExtensionDesc in argument to "github.com/gogo/protobuf/proto".GetBoolExtension
external/com_github_gogo_protobuf/gogoproto/helper.go:106:37: cannot use E_Customtype (type *"github.com/golang/protobuf/proto".ExtensionDesc) as type *"github.com/gogo/protobuf/proto".ExtensionDesc in argument to "github.com/gogo/protobuf/proto".GetExtension
external/com_github_gogo_protobuf/gogoproto/helper.go:119:37: cannot use E_Casttype (type *"github.com/golang/protobuf/proto".ExtensionDesc) as type *"github.com/gogo/protobuf/proto".ExtensionDesc in argument to "github.com/gogo/protobuf/proto".GetExtension
external/com_github_gogo_protobuf/gogoproto/helper.go:119:37: too many errors
2017/12/05 18:20:55 error running compiler: exit status 1
INFO: Elapsed time: 275.347s, Critical Path: 27.61s
FAILED: Build did NOT complete successfully

Looks like your bazel version is old, you need at least 0.8

I'm running 0.8. Still see those errors in external/com_github_gogo_protobuf/gogoproto/helper.go
$ bazel version
Build label: 0.8.0-homebrew
Build target: bazel-out/darwin-opt/bin/src/main/java/com/google/devtools/build/lib/bazel/BazelServer_deploy.jar
Build time: Mon Nov 27 20:38:20 2017<PHONE_NUMBER>)
Build timestamp:<PHONE_NUMBER>
Build timestamp as int:<PHONE_NUMBER>

I should mention that I only recently upgraded from 0.5.4 (brew update; brew upgrade bazel). Perhaps there's some extra step required?

Still failing with same errors with bazel 0.8.1
$ bazel version
Build label: 0.8.1-homebrew
Build target: bazel-out/darwin-opt/bin/src/main/java/com/google/devtools/build/lib/bazel/BazelServer_deploy.jar
Build time: Tue Dec 5 19:29:04 2017<PHONE_NUMBER>)
Build timestamp:<PHONE_NUMBER>
Build timestamp as int:<PHONE_NUMBER>

Sorry for the delay, was waiting for everything to be submitted in rules_go so I could update the dependency.
I have pushed a new change, It all works with this cl at the moment for me.

Great! Works for me too, modulo #527.
As @tomwilkie says, we need to move tools/build/bazel/ to somewhere other than tools/ before we can merge. No strong preference on name, perhaps bazel-build-tools/?
Then I think we can merge this, hook it up to our CI (separate PR), and then it's time for me to sit down & figure out how I can build the docker images w/ Linux binaries by cross-compiling from my Mac. Exciting times!
Thanks so much, @ianthehat!

@ianthehat Where does this leave us wrt Gazelle?
I had a quick play around to see what bazel run //:gazelle would do. It succeeds, generates a bunch of warnings (either gazelle: multiple rules (//pkg/ingester/client:cortex_go_proto and //pkg/ingester/client:go_default_library) may be imported with "github.com/weaveworks/cortex/pkg/ingester/client" or warning: file contains rules whose structure is out of date. Consider running 'gazelle fix'.), and adds new proto_library and go_grpc_library targets to pkg/ingester/client/BUILD.bazel. Needless to say the build fails with this change.
Naïvely adding a # gazelle:proto disable directive to pkg/ingester/client/BUILD.bazel before running gazelle works a little better, but introduces changes like:
diff --git a/pkg/util/BUILD.bazel b/pkg/util/BUILD.bazel
index 2d24cc8..b86e274 100644
--- a/pkg/util/BUILD.bazel
+++ b/pkg/util/BUILD.bazel
@@ -19,7 +19,6 @@ go_library(
     importpath = "github.com/weaveworks/cortex/pkg/util",
     visibility = ["//visibility:public"],
     deps = [
-        "//pkg/ingester/client:go_default_library",
         "//vendor/github.com/blang/semver:go_default_library",
         "//vendor/github.com/gogo/protobuf/proto:go_default_library",
         "//vendor/github.com/golang/snappy:go_default_library",
@@ -45,8 +44,8 @@ go_test(
         "priority_queue_test.go",
         "validate_test.go",
     ],
+    embed = [":go_default_library"],
     importpath = "github.com/weaveworks/cortex/pkg/util",
-    library = ":go_default_library",
     deps = [
         "//vendor/github.com/prometheus/common/model:go_default_library",
         "//vendor/github.com/prometheus/prometheus/storage/local:go_default_library",

Which leads to build failures like:
$ bazel build //pkg/...
INFO: Analysed 34 targets (0 packages loaded).
INFO: Found 34 targets...
ERROR: /Users/jml/go/src/github.com/weaveworks/cortex/pkg/util/BUILD.bazel:3:1: GoCompile pkg/util/darwin_amd64_stripped/go_default_library~/github.com/weaveworks/cortex/pkg/util.a failed (Exit 1)
2017/12/08 11:25:57 missing strict dependencies:
	pkg/util/compat.go: import of github.com/weaveworks/cortex/pkg/ingester/client, which is not a direct dependency
INFO: Elapsed time: 0.733s, Critical Path: 0.31s
FAILED: Build did NOT complete successfully

I'll try to dig more deeply into this later today. Reporting my notes now in case you (or others) have more insight.


style the 404 page

right now it's just a white page with "404 page not found"

let's change it to 404 page not found. [Submit a Pull Request] to improve this page and see what we get :)


Renaming library keywords with custom keywords

Hi, thank you very much for this library, it is amazing!
I'd like to know if is possible to rename the library keywords, for example rename $id, $ref, etc. with custom words.
This is because i'm trying to save the schemas on MongoDB and it is throwing errors due that MongoDB doesn't allow save document properties prefixed with '$' sign.

They are quite embedded in code, so it can only be done by forking/editing code.


Remove default shadow texture for flying creatures (such as aviansies)

Problem:
Aviansies (and likely other flying creatures) have a default shadow as part of their texture, so when the "shadows" feature in 117 HD is turned on, it means that these creatures have two shadows - one from the default texture and one from the plugin
Solution:
It would be nice to either remove the default shadow for certain creatures when 117 HD is enabled, or else disable 117 HD shadows for these creatures.
Alternatives:
An alternative is just turning off the "shadows" feature in places like God Wars Dungeon, but this is a minor inconvenience
Additional Context:
In the image below, you can see the default elliptical shadow next to the HD shadow, with the Aviansie in the top-left corner

#253

This can now be called as it was added


Instructions for docker-based dev setup

This setup is just a more detailed version of @horcsinbalint's instructions.

Thanks for making documentation for it and making it overall more understandable. I might be biased but I would recommend it more than the "Universal method", as both require Docker but mine does not need composer and php on the host system. So I would probably put it above that.

I have made the requested changes, thank you. I have also placed this new description above the Universal method. Currently, both are marked as recommended, which is obviously not ideal, but I also feel biased in this matter and therefore don't wish to un-recommend the previously recommended solution myself.


[CARBONDATA-1680] Fixed Bug to show partition Ids for Hash Partition

Be sure to do all of the following checklist to help us incorporate
your contribution quickly and easily:

[x] Any interfaces changed? No

[x] Any backward compatibility impacted? No

[x] Document update required? No

[x] Testing done
Please provide details on
- Whether new unit test cases have been added or why no new tests are required?
- How it is tested? Please attach test report.
- Is it a performance related change? Please attach the performance test report.
- Any additional information to help reviewers in testing this change.

[x] For large changes, please consider breaking it into sub-tasks under an umbrella JIRA. (N/A)

Build Failed with Spark 2.2.0, Please check CI http://<IP_ADDRESS>:8080/job/ApacheCarbonPRBuilder/729/

Build Failed  with Spark 2.1.0, Please check CI http://<IP_ADDRESS>:8080/job/ApacheCarbonPRBuilder1/1957/

Build Success with Spark 2.1.0, Please check CI http://<IP_ADDRESS>:8080/job/ApacheCarbonPRBuilder1/1958/

Build Success with Spark 2.2.0, Please check CI http://<IP_ADDRESS>:8080/job/ApacheCarbonPRBuilder/730/

SDV Build Success , Please check CI http://<IP_ADDRESS>:8080/job/ApacheSDVTests/2276/

Hi, For hash partition we only need to show number of partitions. Why need to show the ids?

I have displayed the partition_ids due to the bug raised in this jira https://issues.apache.org/jira/browse/CARBONDATA-1680
which says "Show Partition for Hash Partition doesn't display the partition id"

Hi @SangeetaGulia ,
look into the first image in the jira, under the highlighted text, we said the alter partition operation is not supported for hash partition table. So we don't show the ids. I suggest to keep the origin design.
Thanks for your contribution although : )

Hi @lionelcao ,
Is there any plan to support alter partition operation for hash partition table in future?

@SangeetaGulia partition requirement is being rewritten to solve additional usecases.Pls refer CARBONDATA-1850. Please verify whether you fix would be required or not

@sraghunandan I have found two related tasks:

Create a system-level switch for supporting standard partition or carbon custom partition.
Support drop partition in carbon

So are we continuing support of custom partitions? and if yes then are we going to provide the support of drop partition for hash partition table?
Support drop partition in carbon
Support drop partition in carbon
Support drop partition in carbon
Support drop partition in carbon
Support drop partition in carbon

Build Success with Spark 2.2.0, Please check CI http://<IP_ADDRESS>:8080/job/ApacheCarbonPRBuilder/944/

Build Success with Spark 2.1.0, Please check CI http://<IP_ADDRESS>:8080/job/ApacheCarbonPRBuilder1/2173/


[verifying-client] Refactor Storage->StateStore. Add FileStateStore - (24)

Motivation
Flesh out the durable TrustedState storage API. Replaces the Storage + TrustedStateStore with new StateStore trait. Looks like:
pub trait StateStore {
    type Error: std::error::Error + Send + Sync + 'static;

    fn latest_state(&self) -> Result<Option<TrustedState>, Self::Error>;
    fn latest_state_version(&self) -> Result<Option<u64>, Self::Error> {
        Ok(self.latest_state()?.map(|s| s.version()))
    }
    fn store(&self, new_state: &TrustedState) -> Result<(), Self::Error>;
}

Clarify properties needed from StateStore implementations in order to guarantee client safety under concurrency and crashes.
Add FileStateStore which dumps states into one of a pair of files. The main idea here is to provide ACID guarantees by ensuring (1) only one writer, (2) writer always writes to the oldest state file (by version), (3) we fsync the file after every write. This ensures the highest version state is always durable and consistent.
Testplan
CI/CD pipeline testcases will cover above changes also.

/canary

/canary

:sunny: Canary successful

/land


Provide mariadb 10.1 and 10.2, fixes #1221

The Problem/Issue/Bug:
It turns out TYPO3 v8 and earlier require Mariadb 10.1 and can't function with 10.2. This PR provides explicit 10.1 support.
The first attempt at this was #1222, which tried it using library/mariadb, but that made images that were twice as big and swich to debian base image. Too much change for too little value. This one maintains two almost identical images.
How this PR Solves The Problem:

10.1 and 10.2 are now available with setting mariadb_version: 10.1 etc in config.yaml
You can also ddev config --mariadb-version=10.1 and ddev start.
You can also restore 10.1 snapshots (pre v1.3) with it running in 10.1 mode.
An attempt to start a 10.2 database with 10.1 mariaDB will fail and the logs will tell why (and it fails before the db can be damaged).
An attempt to restore a 10.1 snapshot with 10.2 is warned.
An attempt to restore a 10.2 snapshot with 10.1 is warned.

Manual Testing Instructions:
To test out the mariadb 10.1 db, please:
• dump your db to make a backup: ddev export-db >dump.sql.gz
• ddev remove --remove-data which will create an automatic snapshot also (or ddev remove --remove-data --omit-snapshot if you don't want it.
• ddev config --mariadb-version=10.1
• ddev start
Automated Testing Overview:

There's a new test just for 10.1 that goes over the basics of database usage.

Related Issue Link(s):
OP #1221
Release/Deployment notes:

I didn't mean to put so much effort into this, but am pretty happy with the end result. It even has error checking on wrong-db-version and wrong-snapshot type. Even though the audience is probably small, they'll appreciate it. And we have enough test coverage for it I think. And if we're forced to add another type, the model is at least in place.


docs: add API and usage docs

Check the version of package you are using. If it's not the newest version, update and try again (see changelog while updating!).
If the issue is still there, write a minimal project showing the problem and expected output.
Link to the project and mention Node version and OS in your report.

IMPORTANT! You should use Stack Overflow for support related questions.

0.1.0 is published to npm, need to document the api and usage for consumers.

Done. Forgot to close this.


Added exception handling for PendingDeprecationWarning when using Python...

Ran into this issue as well just now. Would be great to a have this library working with python3.

@tavor, this legacy version of python-docx is no longer supported. The current version is at https://github.com/python-openxml/python-docx, and works with Python 3.


what size of input image are the 33G FLOPs calculated

Hi:
Your work is really amazing，and I have some question after reading the paper:
You mentioned in the article, "The whole IPT has 114M parameters and 33G FLOPs".
What size of input image are the 33G FLOPs calculated here?

For 48*48 input image size.


WIP [RFC]: ACRN boot

This is just a request for comment. It would allow master, after we get Jack patches merged, to build basic ACRN-based EVE images if HV=acrn is passed to makefile.
Still very temporary, but ready enough to discuss the approach.
There are only two commits of interest here:  9eb4317 and
4b3efff
The first one creates per-hypervisor (rather than grub-specific) grub.cfg, the other massages the makefile and the build system.

First of all, I like the approach overall. Explicitly picking your hypervisor with make HV=<hypervisor> is good and clean. I have minor nits with it, e.g.
ROOTFS_YML_xen=images/rootfs.yml
ROOTFS_YML_acrn=images/acrn-rootfs.yml

Why should rootfs.yml be the Xen one, while the named one is for acrn? I find it confusing. Let's have explicit for all hypervisors, i.e.
ROOTFS_YML_xen=images/xen-rootfs.yml
ROOTFS_YML_acrn=images/acrn-rootfs.yml

The fact that we pick one over the other is a function of the defined HV value, and the fact that xen is the default is just a function of the Makefile.
That having been said, can we flip it to rootfs-xen.yml and rootfs-acrn.yml, to make it easier on humans? This way they all group together in `ls`` or a Finder/Explorer window.
Similarly, we probably should have pkg/kernel-acrn/ and pkg/kernel-xen. Make them easy to see.
Ideally, we would have one pkg/kernel/ with build information that can handle either, but if those are too far apart, we can keep them separate, but let's make them equal first-class citizens.
Nice work!
In the same vein,

Avi, thanks for your comments!
Yes renaming files to something more sensible was definitely outside the scope of the RFC. Probably even HV should be changed to something more esplicative.
As for kernel I think we should insist that pig/kernel is the generic one, and the ACRN one is the special.
Changing names and moving files around would’ve complicated the patch and distracted from the mechanism, so I didn’t do that here.

should insist that pig/kernel is the generic one

Not for me; I am Jewish, so no pig. I could do pkg/kernel though. :-)
(got to love auto-correct....)

Yes renaming files to something more sensible was definitely outside the scope of the RFC.

Yeah, I might have delved too deeply into your implementation rather than concept.

Probably even HV should be changed to something more esplicative.

Nah, I like HV. Using the full HYPERVISOR would be way too long. It was a good choice.

As for kernel I think we should insist that pkg/kernel is the generic one, and the ACRN one is the special.

That implies a lot about the expected value of xen vs acrn. If we are positive that the main focus is xen, and acrn is an additional, then sure. If we might do other things, or acrn is first-class citizen here and fully supported, then we should have unbiased naming conventions.
It really isn't about naming; it is about long-term focus and support.

should insist that pig/kernel is the generic one

Not for me; I am Jewish, so no pig. I could do pkg/kernel though. :-)
(got to love auto-correct....)

Yes, my phone is somehow biased toward animals. It’s really insisting that I should talk about ducks all the time, for some mysterious reason!

My daughter loves animals; she will want your phone. 😃

Yes renaming files to something more sensible was definitely outside the scope of the RFC.

Yeah, I might have delved too deeply into your implementation rather than concept.

Probably even HV should be changed to something more esplicative.

Nah, I like HV. Using the full HYPERVISOR would be way too long. It was a good choice.

As for kernel I think we should insist that pkg/kernel is the generic one, and the ACRN one is the special.

That implies a lot about the expected value of xen vs acrn. If we are positive that the main focus is xen, and acrn is an additional, then sure. If we might do other things, or acrn is first-class citizen here and fully supported, then we should have unbiased naming conventions.

No, no, that’s not what’s happening. Pkg/kernel is essentially a vanilla kernel, has the xen bits turned on but can be booted without it, too. It is in this sense a generic one and not tied to Xen.
Suppose we want to enable KVM, we could do that in pkg/kernel without problems.
The ACRN kernel is a special branch, released by acrn, with the explicit need to be used in ACRN. Xen used to be the same way for a very long time, requiring a special kernel form dom0.
In this sense the acrn kernel is acrn specific.

It really isn't about naming; it is about long-term focus and support.
Yes, it is about long term. In the long term I’d like to use the same kernel for both hypervisors.

No, no, that’s not what’s happening. Pkg/kernel is essentially a vanilla kernel, has the xen bits turned on but can be booted without it, too. It is in this sense a generic one and not tied to Xen.

Suppose we want to enable KVM, we could do that in pkg/kernel without problems.

yeah, that makes sense. OK, thanks for clarifying.

Hey @glguida -- now that I merged #303 and #315 can you please rebases this PR on the latest master?
Also, would it make more sense to actually keep grub.cfg where it is and simply override it for ACRN via /config/grub.cfg ?

Also, would it make more sense to actually keep grub.cfg where it is and simply override it for ACRN via /config/grub.cfg ?

Rather than using /config, I am actually creating a /EFI/BOOT/grub-hv.cfg override. This is because as opposed to /config it should be really a static configuration -- and also without it horrible things would happen because Xen is not present.
I'll am about to rebase and test one last time before sending the PR, so we can continue the discussion there.


Github authentication for monitoring

/kind enhancement
What this PR does / why we need it:
This PR deploys oauth2_proxy in the trusted cluster in order to enable Github authentication for the monitoring UIs.
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:

⚠ GitGuardian has uncovered 1 secret following the scan of your pull request.
Please consider investigating the findings and remediating the incidents. Failure to do so may lead to compromising the associated services or software components.
🔎 Detected hardcoded secret in your pull request
🛠 Guidelines to remediate hardcoded secrets
🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.Our GitHub checks need improvements? Share your feedbacks!

False alarm my friend, there is no secret 🤖


fix(coral): Add support for target prop in HeadermenuLink

What happened?
The documentation link in HeaderNavigation is not target="_blank", as are our other external links in the app.
What did you expect to happen?
The external link should be target="_blank". This could be achieved by adding a target prop to HeaderMenuLink

Can you assign this to me

@mathieu-anderson  maybe we should rethink the use of target="_blank" in general. It's bad for usability (deciding for the user how the link opens),  accessibility (no warning for users of assistive technology that link is being opened in a new window) and can carry security risks (which we mitigate by using rel="noopener noreferrer" but it's easy to forget)
for example see this: https://www.searchenginejournal.com/blank-link-attribute/435883/

Closing this issue in favour of removing target=blank in general based on discussion we had: (internal slack link: https://aiven-io.slack.com/archives/C040JF3VDJR/p1698651729417509?thread_ts=1698219887.106169&cid=C040JF3VDJR)


Update CodeMirror

I've successfully run all unit and integration tests.
CodeMirror releases page
Commit log
Notable changes

Multiple improvements to CSS mode
Support for async/await in JS
Indent PHP code when in nested HTML (#10038)

This is awesome, thanks @MarcelGerber. @nethip or anyone else, can we do a sanity check and merge this if it all looks good?

@MarcelGerber Thanks Marcel! Just a quick question. Have our tests passed with this change? If yes, then we should be good to go.

Too bad I missed the "I've successfully run all unit and integration tests.". This looks fine to me.


Refresh browser

Hi, I have a problem with feathers-client when I refresh the browser page and the backend is restricted for authenticated users. The client will give an error that the authentication token is missing. My home page isn't restricted, so when I go to my home page and navigate from there everything is fine.
When I do a AJAX request via jQuery with { token : localStorage.getItem("feathers-jwt") } I get no error (even on browser refresh)
Does the client handle browser refresh in a weird way or something?

If you hit a restricted endpoint with the browser without setting the Authorization header it will definitely show an authentication error. If you are using PushState you have to make sure that every route returns the unrestricted index.html.

Thanks for your reply. Why would I need to set the Authorization header?
The feathersjs-client does that right? The problem is that on browser refresh the token will not be set (while the token is in the localStorage). I use feathersjs-client in React. When I replace the part which does the request to find data with a plain jQuery ajax request it works. So this is done when components are rendered, so the token is available from the localStorage. But strangely the feathersjs-client doesn't set it in this scenario. I also tried to set it manually but I couldn't figure out how to pass that.

You have to call app.authenticate() (with no parameters) first to let the client know that it should use the store token for future requests.

Thanks! I already did that for checking if the user is authenticated, but now I wrapped it around my service call and then it works on browser refresh. Is that the way you meant?
PS: I'm using React, Redux and created an action which does the app.authenticate() and stores the result in the redux store and then I checked this variable when a page needs authentication

Yes, you have to wait for the promise from app.authenticate() to return before making any service calls.

Cool then its clear for me thanks!

I'm trying exactly this method but it seems that even after the authentication response the request is not authenticated, it seems that it takes some small time to set it up.
If I .authenticate() and in the .then I put a setTimeout for 200 milliseconds for ex. it works, but it doesn't if I call the service instantly


jinja2-cli: init at 0.8.2

Description of changes

Things done

Built on platform(s)

[ ] x86_64-linux
[ ] aarch64-linux
[x] x86_64-darwin
[ ] aarch64-darwin

[x] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[x] Tested basic functionality of all binary files (usually in ./result/bin/)
[x] Fits CONTRIBUTING.md.

Would make sense to locate this package as a Python package? Then reference it at top-level?

It's really an application.


Build with @appland/appmap version 2.3.4.

Closes https://github.com/applandinc/appmap-intellij-plugin/issues/18
@ptrdvrk This is using 2.3.4 now, I wasn't certain if that the right version to use.

Great, thank you @jansorg . I've built the plugin locally with 2.3.4 and it looks good.


Crash when loading second workspace

When I load a second workspace folder, the runtime gets shutdown without an error message.
Full reproduction with Helix instructions can be found here: https://github.com/dvic/nextls-bug-shutdown
It seems I can only reproduce it when I add the dependencies that are currently added to the bar project from the reproduction example. When I ran it without those set of dependencies, the project didn't crash. So it could be maybe a timing issue?

I tested this out, at least with helix 23.10 and the latest Next LS, can't reproduce anymore.
One thing to note is that Next LS will now ask you if you want it to run mix deps.get for you if your deps are outdated, but helix doesn't support the right LSP method for that yet, so you'll just need to make sure that your deps are up to date.


При перезарядке звук снова воспроизводится | When recharging, the sound is played again

https://youtu.be/QKZbl-GZipY

I've noticed that this is an issue. I'm not entirely sure how to fix it because the way we detect shots on the client is by seeing how the ammo count changes. The weapon must have reduced its ammo count when reloading.
Before you ask why we use this method, it's because entityfirebullets seems to be greatly delayed on the client under certain conditions, causing the reverb sound to be out of sync with the actual shot.
I will keep this in the back of my head and this issue open until I figure out a big brain method to fix it...

After a long time of not even opening the project, I have made a fix. You can get it from the master branch. Tell me how it goes

Да, все хорошо, ошибка пропала, можно заливать в воркшоп, думаю 👀


Use ISO8601 for the session expires text under the log out button

The superior date and time format

UJCi'mmm gonna close this sincei t was a joke issue anyway


Feature request: Implementation of events for dnd-sortable-container

I'm submitting a ...
[ ] bug report
[x ] feature request
[ ] question about the decisions made in the repository

Do you want to request a feature or report a bug?
Feature request

What is the current behavior?
At the moment there are no working events within the dnd-sortable-container.

What is the expected behavior?
I would like to have same events like implemented in non dnd-sortable-container to handle different use cases after ended or successfull drag.

What is the motivation / use case for changing the behavior?
On sortable containers there are also use cases where those events might be useful, i.E. sorting elements of the list and recalculate data using the new sorted items.

+1

+1

+1

+1

+1

Has this now been implemented??

Not really, I've just tried and it doesnt work.

very important feature it would be.


Unable to start server. Problem with SocketIO?

When running sudo SECRET_KEY='something random-ish' python3 switchremoteplay/server.py, I get this error. I have changed the SECRET_KEY to various values to no success.
Line 8 from the log from server.py being flask_socketio import SocketIO
Traceback (most recent call last):
  File "/home/myuser/switch-remoteplay/server/switchremoteplay/server.py", line 8, in <module>
    from flask_socketio import SocketIO
  File "/usr/local/lib/python3.10/dist-packages/flask_socketio/__init__.py", line 9, in <module>
    from socketio import socketio_manage  # noqa: F401
  File "/usr/local/lib/python3.10/dist-packages/socketio/__init__.py", line 9, in <module>
    from .zmq_manager import ZmqManager
  File "/usr/local/lib/python3.10/dist-packages/socketio/zmq_manager.py", line 5, in <module>
    import eventlet.green.zmq as zmq
  File "/usr/local/lib/python3.10/dist-packages/eventlet/__init__.py", line 17, in <module>
    from eventlet import convenience
  File "/usr/local/lib/python3.10/dist-packages/eventlet/convenience.py", line 7, in <module>
    from eventlet.green import socket
  File "/usr/local/lib/python3.10/dist-packages/eventlet/green/socket.py", line 4, in <module>
    __import__('eventlet.green._socket_nodns')
  File "/usr/local/lib/python3.10/dist-packages/eventlet/green/_socket_nodns.py", line 11, in <module>
    from eventlet import greenio
  File "/usr/local/lib/python3.10/dist-packages/eventlet/greenio/__init__.py", line 3, in <module>
    from eventlet.greenio.base import *  # noqa
  File "/usr/local/lib/python3.10/dist-packages/eventlet/greenio/base.py", line 32, in <module>
    socket_timeout = eventlet.timeout.wrap_is_timeout(socket.timeout)
  File "/usr/local/lib/python3.10/dist-packages/eventlet/timeout.py", line 166, in wrap_is_timeout
    base.is_timeout = property(lambda _: True)
TypeError: cannot set 'is_timeout' attribute of immutable type 'TimeoutError'

For reference, I have tried running this on a Raspbian and also a Ubuntu virtual machine. Both have the same error. I'm wondering if I'm missing some sort of dependency here.
Please help me out if you're able to.

Have you solved this issue? I'm having the same problem.


[error] make -j8

Hello, when I followed the tutorial Build and install this package, an error occurred when I executed "make -j8". The following is the error details. In addition, I would like to ask if the directory should be under the MT_SOFTWARE_SUIT downloaded before when installing this package? Can you give a more detailed installation tutorial, thank you very much!
> `$ make -j8
/usr/bin/cmake -S/home/yanghengyi/Downloads/MT_Software_Suite_linux-x64_2022.0/xsens_streaming -B/home/yanghengyi/Downloads/MT_Software_Suite_linux-x64_2022.0/xsens_streaming/build --check-build-system CMakeFiles/Makefile.cmake 0
/usr/bin/cmake -E cmake_progress_start /home/yanghengyi/Downloads/MT_Software_Suite_linux-x64_2022.0/xsens_streaming/build/CMakeFiles /home/yanghengyi/Downloads/MT_Software_Suite_linux-x64_2022.0/xsens_streaming/build/CMakeFiles/progress.marks
make -f CMakeFiles/Makefile2 all
make[1]: Entering directory '/home/yanghengyi/Downloads/MT_Software_Suite_linux-x64_2022.0/xsens_streaming/build'
make -f src/xsens_streaming/CMakeFiles/xsens_streaming.dir/build.make src/xsens_streaming/CMakeFiles/xsens_streaming.dir/depend
make -f binding/python/CMakeFiles/copy-sources-3-xsens_streaming-python-bindings.dir/build.make binding/python/CMakeFiles/copy-sources-3-xsens_streaming-python-bindings.dir/depend
make -f binding/python/CMakeFiles/copy-sources-0-xsens_streaming-python-bindings.dir/build.make binding/python/CMakeFiles/copy-sources-0-xsens_streaming-python-bindings.dir/depend
make[2]: Entering directory '/home/yanghengyi/Downloads/MT_Software_Suite_linux-x64_2022.0/xsens_streaming/build'
cd /home/yanghengyi/Downloads/MT_Software_Suite_linux-x64_2022.0/xsens_streaming/build && /usr/bin/cmake -E
make[2]: Entering directory '/home/yanghengyi/Downloads/MT_Software_Suite_linux-x64_2022.0/xsens_streaming/build'
cd /home/yanghengyi/Downloads/MT_Software_Suite_linux-x64_2022.0/xsens_streaming/build && /usr/bin/cmake -E cmake_depends "Unix Makefiles" /home/yanghengyi/Downloads/MT_Software_Suite_linux-x64_2022.0/xsens_streaming /home/yanghengyi/Downloads/MT_Software_Suite_linux-x64_2022.0/xsens_streaming/binding/python /home/yanghengyi/Downloads/MT_Software_Suite_linux-x64_2022.0/xsens_streaming/build /home/yanghengyi/Downloads/MT_Software_Suite_linux-x64_2022.0/xsens_streaming/build/binding/python
[ 94%] Building CXX object src/xsens_streaming/CMakeFiles/xsens_streaming_sample.dir/main.cpp.o
cd /home/yanghengyi/Downloads/MT_Software_Suite_linux-x64_2022.0/xsens_streaming/build/src/xsens_streaming && /usr/bin/c++  -DBOOST_ALL_NO_LIB -DBOOST_PROGRAM_OPTIONS_DYN_LINK -I/home/yanghengyi/Downloads/MT_Software_Suite_linux-x64_2022.0/xsens_streaming/build -I/home/yanghengyi/Downloads/MT_Software_Suite_linux-x64_2022.0/xsens_streaming/build/include -I/home/yanghengyi/Downloads/MT_Software_Suite_linux-x64_2022.0/xsens_streaming/include -isystem /usr/local/xsens/include  -pedantic -Wno-long-long -Wall -Wextra -Wcast-align -Wcast-qual -Wformat -Wwrite-strings -Wconversion    -std=gnu++11 -o CMakeFiles/xsens_streaming_sample.dir/main.cpp.o -c /home/yanghengyi/Downloads/MT_Software_Suite_linux-x64_2022.0/xsens_streaming/src/xsens_streaming/main.cpp
No such file or directory
make[2]: *** [binding/python/CMakeFiles/xsens_streaming-python-bindings.dir/build.make:64: binding/python/CMakeFiles/xsens_streaming-python-bindings] Error 1
make[2]: Leaving directory '/home/yanghengyi/Downloads/MT_Software_Suite_linux-x64_2022.0/xsens_streaming/build'
make[1]: *** [CMakeFiles/Makefile2:1428: binding/python/CMakeFiles/xsens_streaming-python-bindings.dir/all] Error 2
make[1]: *** Waiting for unfinished jobs....
[100%] Linking CXX executable xsens_streaming_sample
cd /home/yanghengyi/Downloads/MT_Software_Suite_linux-x64_2022.0/xsens_streaming/build/src/xsens_streaming && /usr/bin/cmake -E cmake_link_script CMakeFiles/xsens_streaming_sample.dir/link.txt --verbose=1
/usr/bin/c++   -pedantic -Wno-long-long -Wall -Wextra -Wcast-align -Wcast-qual -Wformat -Wwrite-strings -Wconversion   -rdynamic CMakeFiles/xsens_streaming_sample.dir/main.cpp.o  -o xsens_streaming_sample  -Wl,-rpath,/home/yanghengyi/Downloads/MT_Software_Suite_linux-x64_2022.0/xsens_streaming/build/src/xsens_streaming:/usr/local/xsens/lib: libxsens_streaming.so /usr/lib/x86_64-linux-gnu/libboost_program_options.so.1.71.0 /usr/local/xsens/lib/libxstypes.so
make[2]: Leaving directory '/home/yanghengyi/Downloads/MT_Software_Suite_linux-x64_2022.0/xsens_streaming/build'
[100%] Built target xsens_streaming_sample
make[1]: Leaving directory '/home/yanghengyi/Downloads/MT_Software_Suite_linux-x64_2022.0/xsens_streaming/build'
make: *** [Makefile:144: all] Error 2

Instructions are clearly provided in the README:

First install the mt software suite sdk using the script they provide
Next clone this repository (it does not need to be within the MT software suite directory). cmake will look for the installed MT software suite SDK

ware suite sdk using

Hello, I have installed the sdk following the tutorial in readme and cloned the library locally. cmake uses "cmake --DPYTHON_BINDING=OFF..." The command was built successfully, but the aforementioned problem occurred when "make-j8" was compiled.

Btw I am not your dedicated customer service, no need to spam me by email in addition to issues if I don't answer within the day, especially to build issues you could solve yourself. Please stick to issues only.

Thank you for reaching out. I understand your concern regarding unnecessary emails and related issues, and I sincerely apologize for any inconvenience caused.
We will make efforts to minimize the frequency of emails, especially if there's no immediate response from your end.
Wishing you all the best, and thank you for your understanding!

I just gave it a try locally, and besides a minor issue with clang compiler, everything works as expected. CI is fine too, so there is something odd in your system.
Can you please clone the repository outside of the MT software suite folder, and rerun the following commands:
git clone --recursive git@github.com:arntanguy/xsens_streaming
cd xsens_streaming
mkdir build && cd build
cmake -DPYTHON_BINDING=OFF ..
make -j8
sudo make install

I just gave it a try locally, and besides a minor issue with clang compiler, everything works as expected. CI is fine too, so there is something odd in your system.
Can you please clone the repository outside of the MT software suite folder, and rerun the following commands:
git clone --recursive git@github.com:arntanguy/xsens_streaming
cd xsens_streaming
mkdir build && cd build
cmake -DPYTHON_BINDING=OFF ..
make -j8
sudo make install

Hello, thank you for taking the time to try, I did it outside of the folder in the mt software package. I have a look at the reason for the error, it seems that I can't find the path of python binding, in short, I will try again, if you have other or more detailed suggestions, please tell me, I will try, thank you.

Building with -DPYTHON_BINDING=OFF should be completely disabling the python bindings. If that is not the case on your system, then I am confused as to why.

Building with -DPYTHON_BINDING=OFF should be completely disabling the python bindings. If that is not the case on your system, then I am confused as to why.

I created a Python3.7 environment with anaconda and tried it again using "cmake -DPYTHON_BINDING_USER_INSTALL=ON.." Compile, but I still get an error when I "make -j8"...

Cython.Compiler.Errors.CompileError: xsens_streaming/xsens_streaming.pyx
make[2]: *** [binding/python/CMakeFiles/xsens_streaming-python-bindings.dir/build.make:64: binding/python/CMakeFiles/xsens_streaming-python-bindings] Error 1
make[2]: Leaving directory '/home/dt/Teleoperated_Arm/xsens_streaming/build'
make[1]: *** [CMakeFiles/Makefile2:1456: binding/python/CMakeFiles/xsens_streaming-python-bindings.dir/all] Error 2
make[1]: *** Waiting for unfinished jobs....
[100%] Linking CXX executable xsens_streaming_sample
cd /home/dt/Teleoperated_Arm/xsens_streaming/build/src/xsens_streaming && /usr/bin/cmake -E cmake_link_script CMakeFiles/xsens_streaming_sample.dir/link.txt --verbose=1
/usr/bin/c++   -pedantic -Wno-long-long -Wall -Wextra -Wcast-align -Wcast-qual -Wformat -Wwrite-strings -Wconversion   -rdynamic CMakeFiles/xsens_streaming_sample.dir/main.cpp.o  -o xsens_streaming_sample  -Wl,-rpath,/home/dt/Teleoperated_Arm/xsens_streaming/build/src/xsens_streaming:/usr/local/xsens/lib: libxsens_streaming.so /usr/lib/x86_64-linux-gnu/libboost_program_options.so.1.71.0 /usr/local/xsens/lib/libxstypes.so
make[2]: Leaving directory '/home/dt/Teleoperated_Arm/xsens_streaming/build'
[100%] Built target xsens_streaming_sample
make[1]: Leaving directory '/home/dt/Teleoperated_Arm/xsens_streaming/build'
make: *** [Makefile:144: all] Error 2


[Release-1.21] - k3s.service enters restart loop after running k3s secrets-encrypt prepare

Backport fix for k3s.service enters restart loop after running k3s secrets-encrypt prepare

#5442

Environment Details
Infrastructure
Cloud
Hosted
Node(s) CPU architecture, OS, and Version:
$ uname -a
Linux ip-172-31-2-185 5.4.0-1009-aws #9-Ubuntu SMP Sun Apr 12 19:46:01 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux
$ cat /etc/os-release
NAME="Ubuntu"
VERSION="20.04 LTS (Focal Fossa)"
ID=ubuntu
ID_LIKE=debian
PRETTY_NAME="Ubuntu 20.04 LTS"
VERSION_ID="20.04"
HOME_URL="https://www.ubuntu.com/"
SUPPORT_URL="https://help.ubuntu.com/"
BUG_REPORT_URL="https://bugs.launchpad.net/ubuntu/"
PRIVACY_POLICY_URL="https://www.ubuntu.com/legal/terms-and-policies/privacy-policy"
VERSION_CODENAME=focal
UBUNTU_CODENAME=focal
Cluster Configuration:
3 servers
Config.yaml:
write-kubeconfig-mode: "0644"
tls-san:

token:
secrets-encryption: true
server: https://:6443
Replication Steps:
Install K3S:
curl -sfL https://get.k3s.io | INSTALL_K3S_VERSION=v1.22.8+k3s1 sh -
On a server that was not the initial server, run: k3s secrets-encrypt prepare && systemctl restart k3s && journalctl -u k3s -f
Restart the other two servers: systemctl restart k3s
NOTE: After several tries and attempts to replicate the issue, for version 1.21, always after reset the servers they reconcile and k3s starts normally.
Validation Steps
Install K3S:
curl -sfL https://get.k3s.io | INSTALL_K3S_COMMIT=1e0507c6c01badb24e4ad1303a7eeb86787c2b02 sh -
On a server that was not the initial server, run: k3s secrets-encrypt prepare && systemctl restart k3s && journalctl -u k3s -f
Restart the other two servers: systemctl restart k3s
Results:
Logs only loop like above initially, but after restarting the other two servers, it reconciles and k3s starts normally.
Additional context :
Additional information can be helpful:
https://rancher.com/docs/k3s/latest/en/security/secrets_encryption/


Typst cannot type Chinese properly

Description
I found that Typst cannot type Chinese properly now. For example, when I wrote:
定义1.1.1（集合）：集合（set）是“事物的选集”。这些事物被称为集合的元素（element）或成员（member）。
The final result of tpyst's compile is:

You can see here, for example, the phrase 集合（set） is not in bold.
I don't understand why this happened, since last time when I used typst, it could type Chinese properly.
Reproduction URL
No response
Operating system
Windows
Typst version

[X] I am using the latest version of Typst

I suspect this is a case of missing fonts and fallback.

Yeah, maybe. But last time, Typst could compile these exact same Chinese words properly. Have we had any updates on Typst recently?

Are you specifying fonts manually, or entirely relying on typst finding a font on your system? In the latter case all bets are off.

You may want to use https://typst.app/universe/package/cuti/
AND I see you are using touying-buaa, so you can configure the language and the template will automatically import cuti for you. See https://github.com/Coekjan/touying-buaa/blob/bf25effe6066b3930c5fd0b7aac1ebf8af5c6b9f/examples/main.typ#L50

I'll close this. If you're still having issues after specifying an actual font (with a bold variant), then feel free to open a new issue.
Typst doesn't ship with a CJK font, and last resort fallback is unpredictable.

Note: The problem has been solved by adding the following codes:
#set text(font: "Noto Sans CJK SC")


Create Privacy notice mockup

Create a notice at foot of browser which redirects new user to GDPR privacy statement.

See #169.

For review:
https://chanzuckerberg.invisionapp.com/d/main#/console/14304893/316191625/preview
https://chanzuckerberg.invisionapp.com/d/main#/console/14304893/316191624/preview


Syntax highlighting taking 30+ seconds

Atom hangs seemingly on application of syntax color scheme
To reproduce:

On Atom v1.0.6 with no community themes or packages installed
Download and open http://code.jquery.com/jquery-1.11.3.min.js

Timeline:

Thanks for the report! This looks like a duplicate of https://github.com/atom/atom/issues/979 – mind commenting there with this Timeline screenshot?

#979 is locked.

@mcanas Sorry about that - I'll unlock it briefly so you can comment


ENI: new node not does not immediately trigger the creation of Eni

Is there an existing issue for this?

[X] I have searched the existing issues

What happened?

New node add to cluster, it not immediately trigger the creation of Eni.  Until resync period is triggered, eni be created in new node. so agent in waiting eni create max duration is 1min.
It happend in aws and alibabacloud and azure.
it also find log in issue https://github.com/cilium/cilium/issues/18239#issuecomment-992927403 https://github.com/cilium/cilium/issues/14028 https://github.com/cilium/cilium/issues/11560#issuecomment-902693365

Instance not found! Please delete corresponding ciliumnode if instance has already been deleted

instance does not exist in azure
Because it not update instanceManger.instances when new node find. So in ops.ResyncInterfacesAndIPs return error in aws and alibabacloud.
https://github.com/cilium/cilium/blob/94ea7fc93e0af5bf3ddab5b67508003ca47678cd/pkg/aws/eni/node.go#L509-L542
https://github.com/cilium/cilium/blob/94ea7fc93e0af5bf3ddab5b67508003ca47678cd/pkg/aws/eni/instances.go#L216-L230
https://github.com/cilium/cilium/blob/94ea7fc93e0af5bf3ddab5b67508003ca47678cd/pkg/ipam/types/types.go#L433-L449

Cilium Version
master https://github.com/cilium/cilium/tree/94ea7fc93e0af5bf3ddab5b67508003ca47678cd
Kernel Version
none
Kubernetes Version
none
Sysdump
No response
Relevant log output
No response
Anything else?
I think need add new method UpdateInstance(ctx context.Context, obj *v2.CiliumNode) error for instanceManager that call cloud api to get instance for this node and update instanceManager.instances .  do update instances logic in n.ops.UpdatedNode(resource)
https://github.com/cilium/cilium/blob/94ea7fc93e0af5bf3ddab5b67508003ca47678cd/pkg/ipam/node.go#L355-L377
// UpdatedNode is called when an update to the CiliumNode is received.
func (n *Node) UpdatedNode(obj *v2.CiliumNode) {
	n.mutex.Lock()
	n.k8sObj = obj
        n.mutex.Unlock()
        err := n.manager.UpdateInstance(context.Todo(), obj)
        ..........
}

other ideas is  add new method  UpdateInstance(ctx context.Context, obj *v2.CiliumNode) error   for  NodeOperations interface and do logic node.UpdatedResource
func (n *Node) UpdatedResource(resource *v2.CiliumNode) bool {
	// Deep copy the resource before storing it. This way we are not
	// dependent on caller not using the resource after this call.
	resource = resource.DeepCopy()

	n.ops.UpdatedNode(resource)
        err := n.manager.instancesAPI.UpdateInstance(context.Todo(), obj)
        if err != nil {
           return false
         }

	n.mutex.Lock()
	// Any modification to the custom resource is seen as a sign that the
	// instance is alive
	n.instanceRunning = true
	n.resource = resource
	n.mutex.Unlock()

	n.recalculate()
	allocationNeeded := n.allocationNeeded()
	if allocationNeeded {
		n.requirePoolMaintenance()
		n.poolMaintainer.Trigger()
	}

	return allocationNeeded
}

Code of Conduct

[X] I agree to follow this project's Code of Conduct

@wu0407 Could you submit a PR with some fixes? Thank you!

/Assignees @wu0407

Reopening due to revert of https://github.com/cilium/cilium/pull/21027.


Flux / Redux integration

Is there a pattern to integrate this with Flux and/or Redux?
I like how the proxy server and the client are in separate packages, but there seems to be a lot of useful logic around subscriptions in this package that is tightly coupled to the mixin (at least, I can't figure out how to trivially separate it).
Pulling this logic out and packaging it might be an easy solution to #8 - I don't need anything fancy like a mixin, for my use case at least. Just an interface to subscribe to changefeeds and pass the results to Redux.

I realized I might be misinterpreting the division of labor here. Possibly I can just get away with using rethinkdb-websocket-client. I'll try that and report back...

Actually, integrating with Redux was very straightforward working directly from https://github.com/mikemintz/rethinkdb-websocket-client instead! Awesome!
I'm really surprised at the popularity difference between this package and the client - as far as I can tell this package doesn't work with React 0.14 yet (mixin issue) and that one is actually really straightforward and nice to use with Flux.
Anyways, no problem here in the end, I was just confused...

@coffenbacher, yes I think using rethinkdb-websocket-client with redux probably makes the most sense. The react-rethinkdb project is more intended to be a sideways data loading model where components directly specify their data queries as opposed to a flux model. It needs to track react component lifecycle so it can share results across components and unsubscribe from changefeeds when unmounting.
If you have any tips or run into any issues for integrating redux with rethinkdb-websocket-client, please post about them so others can benefit from what you've learned! I'd be interested in seeing what a simple component or project looks like using them together.
FWIW, react-rethinkdb should work fine with react 0.14, e.g. the chat example app runs with 0.14.2. Or did you mean to say that it doesn't work with ES6 class syntax (which is true until we implement https://github.com/mikemintz/react-rethinkdb/issues/8)?

Great! This helps to understand the plan, thanks.
The client works like a charm with Flux / Redux, I'll try to write up an example + tutorial at some point, because your work on the client is really excellent and is pretty cool when paired with Redux. Meteor-esque except for the latency compensation.
And yes, you're totally right about 0.14. All of our 0.14 projects use ES6, so I actually forgot you didn't need to use it.  :+1:


Auto-attack

Implement auto-attack feature. Attack mobs with the single tap.

Need to have some kind of config window to be able to turn this feature off


License for Microsoft.Data.SqlClient.SNI.runtime

Hi, is there any chance to change the license of the Microsoft.Data.SqlClient.SNI.runtime package to MIT? The reason I am asking is because the corporate I work in has a nuget proxy setup which filters access to packages to only those with allowed license (e.g. MIT). The "Microsoft .NET library" has quite a scary wording from the perspective of the company I work for and legal is unwilling to allow it. This has the consequence that we'll not be allowed to use e.g. EF Core v5 and others. Previous EF Core (or rather the older Microsoft.Data.SqlClient) has a dependency on runtime.native.System.Data.SqlClient.sni which has MIT license.
So overall, I am just curious why this particulour license was chosen for this package / if there is any chance to change it.

cc @David-Engel

@bezysoftware The license was chosen because the code for that package is not open source. System.Data.SqlClient has a similar dependency on an SNI native library with the same license and that is where Microsoft.Data.SqlClient inherited the dependency architecture and license from.
Which sections of the license are "scary"?
Note: You can avoid using that package if you are running on a non-Windows platform, or if you set an app context switch on Windows. Just be aware there are still some unresolved issues in the managed SNI implementation in SqlClient around MARS and async.
Regards,
David

Thanks for the rationale. The legal haven't given me their full statement, but the main concern is
"Data Collection. The software may collect information about you and your use of the software, and send that to Microsoft"
It looks like they will approve it after all though, after several months. Still, just wanted to make you aware there might be this concern with other companies, as was with us.
Re Context Switch, that doesn't help me when installing e.g. the EF Core v5 package though, does it? It cannot install without its dependencies, which are blocked by our proxy. Unless you're thinking manually referencing all its dlls manually which I would rather refrain from :)

Yeah, that section sounds scary but is standard boilerplate used across may MS products. It says "may" to cover all bases. That library definitely does NOT collect any data. I actually got that section changed from the stock legalese for other drivers for the same reasons you noted:

DATA COLLECTION. Some features in the software may enable collection of data from users of your applications that access or use the software. If you use these features to enable data collection in your applications, you must comply with applicable law, including getting any required user consent, and maintain a prominent privacy policy that accurately informs users about how you use, collect, and share their data. You agree to comply with all applicable provisions of the Microsoft Privacy Statement at [https://go.microsoft.com/fwlink/?LinkId=521839].

I can look into updating this one, too.
The context switch won't help with blocking the dependencies from being installed, but it would keep it from being loaded/used is all.
Regards,
David

License has been updated for Microsoft.Data.SqlClient.SNI v3.0.0 and Microsoft.Data.SqlClient.SNI,runtime v3.0.0


As a content editor, I want to merge person records so that I can combine account records when I've identified duplicated people.

Notes for testing

Review the notes below for details on how this should work
New admin action is available from the person list.  Search or browse to find the records to be merged, select them using the checkbox on the left, choose "merge selected people" from the drop down at the bottom left, then click "Go".
Test merging an empty record with a more detailed one to confirm that details are copied to the primary record (nationality, info urls, relationships, addresses, etc)
Test merging a not empty (or less empty) record to confirm details in the primary record are not overwritten
Test cases that should not work to make sure you get a comprehensible error message:

try to merge to a person who does not have an account
add a second account to a person record and try to merge to that record
edit an account to give a person a shared account and try to include that record in the merge

Notes for development

Merge function will be triggered from the person list in the personography section of the admin site.
Will provide a confirmation form with the following details:

for each person, display: name, title, viaf, birth/death, sex, mep id, notes (added)

display all events for each person; divide them so subscription/renewal/etc are displayed first, then borrowing/purchasing events
user picks which person to use as the primary record; by default, the oldest record in the database will be selected by default (based on lowest database id)
when form is submitted:

all account events will be associated with the account for the selected person record
all account addresses will be associated with the account for the selected person record
all personal addresses will be associated with the selected person record
person attributes (title, mep id, birth and death years, viaf id, sex, and profession) will be copied to the primary person record if they are not already set
any nationalities, relationships to other people, info urls, and footnotes will be re-associated with the selected person record
notes will be combined, and merged MEP ids will be documented in the notes
duplicate account and person records will be deleted

merge will not happen, and will display an error message for any of the following cases:

the selected person record does not have an account record
the selected person record has more than one account
any of the records to be merged has an account shared with another person

This looks good to me!  Thank you!

On Feb 26, 2018, at 12:10 PM, Rebecca Sutton Koeser<EMAIL_ADDRESS>wrote:
@jkotin @elspethgreen drafted this story and documented our decisions from the meeting today. Please review to let me know if I missed anything, and let me know if you think we're likely to need to handle people with multiple accounts.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or mute the thread.

I've added more details to the issue description above to document all the fields that are displayed and copied over when merging.  I added notes and mep id to the merge display because I thought they might be useful.
Also, please note that merged MEP ids will be documented in the notes. I added this because we need to be able to find people by MEP id in order to import the borrowing events properly, and if you should happen to merge and choose the "wrong" MEP id we wouldn't be able to find the person record.  This way, we'll be able to look people up by database MEP id and use the merged MEP ids in the notes as a fallback. These will need to be left in the record notes as is until the card import is completed.

Sorry to take so long to get to this! I'm having an issue that seems like I must be doing something wrong: I haven't been able to get the "merge selected people" option to show up in the drop down, as in this screenshot. Am I looking in the right place, doing the right things?

Ian, my VPN seems to have crapped out, so I can't check this until I get to
campus--are you looking at the test site, and not the mep2.princeton.edu
site?  (I've definitely mixed them up)
On Wed, Mar 7, 2018 at 1:13 PM, i-davis<EMAIL_ADDRESS>wrote:

Sorry to take so long to get to this! I'm having an issue that seems like
I must be doing something wrong: I haven't been able to get the "merge
selected people" option to show up in the drop down, as in this screenshot.
Am I looking in the right place, doing the right things?
[image: screen shot 2018-03-07 at 1 11 16 pm]
https://user-images.githubusercontent.com/15250325/37109880-559647b2-2209-11e8-9054-e426b5a4c90b.png
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/Princeton-CDH/mep-django/issues/72#issuecomment-371231237,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AMCD5mIhajKC88QWPjLOtmpHvRVVebehks5tcCNbgaJpZM4STl12
.

I couldn't find anything wrong here, did everything, I think; looks lovely.

Yes this looks good to me too!


feat(tools): add indy docker container for developing Indy Ledger Plugin and testing it

Description
A build script that start/stop Hyperledger Indy node pool is necessary for indy ledger plugin development.
Acceptance Criteria
A docker-compose definition that you can start / stop indy node pool with. It should mount a volume to support data persistency.

Izuru0 https://github.com/izuru0 will be assigned to this issue. His account is made just now so GitHub search engine doesn't find it now yet.


Any plan on made this compatible with Android?

Hi @Victoor please see #8. No plans at this time but would welcome a PR. Thanks!


Document how to upgrade vue-cli

What problem does this feature solve?
There's currently no documented way to upgrade vue-cli, however there is vue upgrade --all. If you search current documentation for 'upgrade', you find only one mention for the word and even that is just marketing speak.
We should have a documented way to do upgrades to vue-cli inside the repo so when for example user sees a security issue in Vue UI dashboard in vue-cli packages, there would be a documented way to do the upgrade.
What does the proposed API look like?
Start with minimal and easiest documentation, expand later (when we for example have non-experimental command available). I'm happy to start a PR if it helps.

@Uninen thank you for creating the issue! Starting a PR would be really nice if you're fine with working on it 👍

Added a short PR. I'm not familiar how tightly these changes are screened, but there's definitely room for improvements by at least checking by someone English-native that the language is not bad :)

Closing the issue because related PR was merged


ZEPPELIN-1785. Remove ZEPPELIN_NOTEBOOK_DIR and ZEPPELIN_INTERPRETER_DIR from common.sh

What is this PR for?
We should remove ZEPPELIN_NOTEBOOK_DIR and ZEPPELIN_INTERPRETER_DIR from common.sh otherwise the corresponding property defined in zeppelin-site.xml won't take effect. I also check other properties like ZEPPELIN_CONF_DIR and ZEPPELIN_WAR. Although we define them explicitly in common.sh, we didn't expose them in document install.md and zeppelin-site.xml.template, so I think these are only for internal use and it is OK to keep them in common.sh although their correponding property in zeppelin-site.xml won't take effect too.
What type of PR is it?
[Bug Fix]
Todos

[ ] - Task

What is the Jira issue?

https://issues.apache.org/jira/browse/ZEPPELIN-1785

How should this be tested?
Tested manually
Screenshots (if appropriate)
Questions:

Does the licenses files need update? No
Is there breaking changes for older versions? No
Does this needs documentation? No

…

@Leemoonsoo  Please help review.

Thanks @zjffdu for the fix!
LGTM and merge to master if there're no more discussions

LGTM


(FACT-1010) Fix innacurate uptime on Solaris zones

On Solaris zones - besides the default global zone - uptime in Facter
3 was inaccurate compared to Facter 2. This seems to reflect a bug in
Solaris related to querying kstat for uptime.
Change to calling uptime directly, which should be authoritative.

Need to test on Solaris still, but a simpler replacement for https://github.com/puppetlabs/facter/pull/1126.

I think the kstat method allowed more precision, uptime seems limited to minutes.

Verified on Solaris 10.

:+1:

Also installed the package on Solaris 11 and verified there.

Nano-nit: but can you s/innacurate/inaccurate/ in the commit summary?

Done.


Room invite page is confusing

The page matrix.to shows for room/etc. invite links is a bit confusing:

It's unclear what the user is supposed to click to join the room.
There are several link targets close to each other that lead to different places (room/etc join link / app homepage)
The actual link/information how to join the room is given on the far right, which usually is the place for unimportant stuff.
There's some prominently shown "scary looking" information that's not important for users (repeat of the contents of the browser url bar, the room invite url which may be long and contain random characters, instructions how to add apps to the list)
How do I join with Riot mobile or desktop apps?

Because this page is an entry point to first-time users, it might make sense to check that its design is suitable for this.

I don't think this is relevant for the new room invite page eg https://matrix.to/#/#element-dev:matrix.org


add interface to provide update user info

Changes made to the function type, and please see my comments related to the naming issue.

After thinking more, I decided to use contactSelfXXX for all self-modification methods.