[ospp] support custom notice template

What's changed?
Custom Notice Template Configuration

Checklist

[x]  I have read the Contributing Guide
[x]  I have written the necessary doc or comment.
[x]  I have added the necessary unit tests and all cases have passed.

hi pls fix these confilcts
manager/pom.xml
web-app/src/assets/i18n/zh-CN.json

启动修改 hzb_notice_rule 表新增 template_id 字段报错不能为null, 这里是因为之前的老数据没有此字段导致，新增 alter table hzb_notice_rule add column template_id bigint not null 会导致之前的老数据异常

2023-10-11 11:14:23 [main] WARN  org.hibernate.tool.schema.internal.ExceptionHandlerLoggedImpl - GenerationTarget encountered exception accepting command : Error executing DDL "alter table hzb_notice_rule add column template_id bigint not null" via JDBC Statement
org.hibernate.tool.schema.spi.CommandAcceptanceException: Error executing DDL "alter table hzb_notice_rule add column template_id bigint not null" via JDBC Statement

建议不设置 template_id 约束null，然后考虑老数据问题，当template_id为null时应该有个对应的默认模版

启动时报错 'classpath:sql/data.sql' 找不到资源，那是因为没有在manager模块的pom.xml里面配置资源路径，导致编译class时没有主动编译此资源到类路径下面去
Caused by: java.lang.IllegalStateException: No data scripts found at location 'classpath:sql/data.sql'
需要把 <include>sql/**</include> 添加到 manager pom.xml build.resources.resource.includes 下

要不要把我们内置的默认消息模版像之前一样以文件的方式存储，用户自定义消息模版用现在的数据库方式存储。系统启动时从文件中加载内置模版到内存中，当 template_id 为null找不到时就使用我们内置的消息模版。页面配置用户不选择的情况下默认就使用内置消息模版。
这样能避免 template_id 为null老数据问题和data.sql重复初始化等问题，无需初始化数据库里面的消息模版数据。

Bot detected the issue body's language is not English, translate it automatically. 👯👭🏻🧑🤝🧑👫🧑🏿🤝🧑🏻👩🏾🤝👨🏿👬🏿

Should we store our built-in default message templates in files as before, and user-defined message templates in the current database method? When the system starts, the built-in template is loaded from the file into the memory. When template_id is null and cannot be found, our built-in message template is used. If the page configuration user does not select it, the built-in message template will be used by default.
This can avoid the problem of old data with template_id being null and repeated initialization of data.sql. There is no need to initialize the message template data in the database.

要不要把我们内置的默认消息模版像之前一样以文件的方式存储，用户自定义消息模版用现在的数据库方式存储。系统启动时从文件中加载内置模版到内存中，当 template_id 为null找不到时就使用我们内置的消息模版。页面配置用户不选择的情况下默认就使用内置消息模版。 这样能避免 template_id 为null老数据问题和data.sql重复初始化等问题，无需初始化数据库里面的消息模版数据。

之前阿晨老师说不想维护文件配置，所以全部入库了，但我没有考虑到老数据的问题，这个方案也可以

Bot detected the issue body's language is not English, translate it automatically. 👯👭🏻🧑🤝🧑👫🧑🏿🤝🧑🏻👩🏾🤝👨🏿👬🏿

Should we store our built-in default message templates in files as before, and user-defined message templates in the current database method. When the system starts, the built-in template is loaded from the file into the memory. When template_id is null and cannot be found, our built-in message template is used. If the page configuration user does not select it, the built-in message template will be used by default. This can avoid the problem of old data with template_id being null and repeated initialization of data.sql. There is no need to initialize the message template data in the database.

Previously, Teacher Achen said that he did not want to maintain file configurations, so he put them all into the database, but I did not consider the problem of old data. This solution can also be used

@tomsun28 @Eden4701 可以换成用文件存储，这样就不用初始化数据和是否为默认模板这个字段了；

Bot detected the issue body's language is not English, translate it automatically. 👯👭🏻🧑🤝🧑👫🧑🏿🤝🧑🏻👩🏾🤝👨🏿👬🏿

@tomsun28 @Eden4701 It can be changed to file storage, so that there is no need to initialize the data and the fields of whether it is the default template;

@tomsun28 @Eden4701 可以换成用文件存储，这样就不用初始化数据和是否为默认模板这个字段了；但是缺点是需要额外维护一下从文件获取模板的代码，而且，如果要在页面显示默认模板的话，还需要额外编写代码（文件 + 数据库的分页感觉有点难做）

是的，如果这样做的话看能不能应用层的代码尽量不改动，主要是启动时加载内置的文件模版，还有数据层操作，因为内置模版只查询不修改，数据层分页改造的时候我们固定把内置模版排序到最前面，然后计算剩余pagesize 和pagenum查询数据库数据后合并 用 new PageImpl<>(list)来返回数据

Bot detected the issue body's language is not English, translate it automatically. 👯👭🏻🧑🤝🧑👫🧑🏿🤝🧑🏻👩🏾🤝👨🏿👬🏿

@tomsun28 @Eden4701 It can be replaced by file storage, so that there is no need to initialize the data and whether it is the default template field; but the disadvantage is that it requires additional maintenance of the code to obtain the template from the file, and if you want to display the default template on the page , additional code needs to be written (file + database paging feels a bit difficult to do)

Yes, if you do this, see if you can keep the code of the application layer as unchanged as possible. The main thing is to load the built-in file template at startup, and to operate the data layer. Because the built-in template only queries and does not modify, we fixed it during the data layer paging transformation. Sort the built-in templates to the front, then calculate the remaining pagesize and pagenum to query the database data and then merge them using new PageImpl<>(list) to return the data.

@tomsun28 @Eden4701 可以换成用文件存储，这样就不用初始化数据和是否为默认模板这个字段了；但是缺点是需要额外维护一下从文件获取模板的代码，而且，如果要在页面显示默认模板的话，还需要额外编写代码（文件 + 数据库的分页感觉有点难做）

是的，如果这样做的话看能不能应用层的代码尽量不改动，主要是启动时加载内置的文件模版，还有数据层操作，因为内置模版只查询不修改，数据层分页改造的时候我们固定把内置模版排序到最前面，然后计算剩余pagesize 和pagenum查询数据库数据后合并 用 new PageImpl<>(list)来返回数据

新的代码已提交，预设模板文件存储，自定义模板在数据库，设置通知规则时模板是可选项，用户不选择模板时默认使用预设模板

Bot detected the issue body's language is not English, translate it automatically. 👯👭🏻🧑🤝🧑👫🧑🏿🤝🧑🏻👩🏾🤝👨🏿👬🏿

@tomsun28 @Eden4701 You can switch to file storage, so you don’t need to initialize the data and the fields of whether it is the default template; but the disadvantage is that you need to maintain the code to get the template from the file, and if you want to display the default template on the page If so, additional code needs to be written (file + database paging seems a bit difficult to do)

Yes, if you do this, see if you can keep the application layer code as unchanged as possible. The main thing is to load the built-in file template at startup and data layer operations, because the built-in template only queries and does not modify. When we transform the data layer paging Fixed sorting the built-in templates to the front, then calculating the remaining pagesize and pagenum, querying the database data, and then merging and using new PageImpl<>(list) to return the data.

The new code has been submitted, the preset template file is stored, and the custom template is in the database. The template is optional when setting notification rules. When the user does not select a template, the preset template is used by default.

赞👍 完成度和质量都很高，这个PR合并了哦。
后续UI优化建议供参考：

[通知模板] 菜单放到第三位即 [告警通知策略] 后面，因为通知模版在默认情况下用户不修改也能使用，对于多数没有修改模版需求的用户它只需前面两步即可。
[告警通知策略]新增配置时建议[通知模版框]根据选中的接收人的通知类型自动渲染填充系统内置默认模版
编辑通知模版UI建议有展示当前所支持的模版环境变量，参考华为云消息通知模版

Bot detected the issue body's language is not English, translate it automatically. 👯👭🏻🧑🤝🧑👫🧑🏿🤝🧑🏻👩🏾🤝👨🏿👬🏿

Like 👍 The completion and quality are very high, this PR has been merged.
Follow-up UI optimization suggestions are for reference:

The [Notification Template] menu is placed in the third position, that is, after [Alarm Notification Policy], because the notification template can be used by users without modification by default. For most users who do not need to modify the template, it only requires the first two steps. .
[Alarm Notification Policy] When adding new configuration, it is recommended that [Notification Template Box] automatically render and fill the system's built-in default template according to the notification type of the selected recipient.
It is recommended to display the currently supported template environment variables when editing the notification template UI. Please refer to Huawei Cloud Message Notification Template.

@all-contributors please add @Eden4701  for code

赞👍 完成度和质量都很高，这个PR合并了哦。 后续UI优化建议供参考：

[通知模板] 菜单放到第三位即 [告警通知策略] 后面，因为通知模版在默认情况下用户不修改也能使用，对于多数没有修改模版需求的用户它只需前面两步即可。
[告警通知策略]新增配置时建议[通知模版框]根据选中的接收人的通知类型自动渲染填充系统内置默认模版
编辑通知模版UI建议有展示当前所支持的模版环境变量，参考华为云消息通知模版

收到！

Bot detected the issue body's language is not English, translate it automatically. 👯👭🏻🧑🤝🧑👫🧑🏿🤝🧑🏻👩🏾🤝👨🏿👬🏿

Like 👍 The completion and quality are very high, this PR has been merged. Follow-up UI optimization suggestions are for reference:

The [Notification Template] menu is placed in the third position, that is, after [Alarm Notification Policy], because the notification template can be used by users without modification by default. For most users who do not need to modify the template, it only requires the first two steps. Can.
[Alarm Notification Policy] When adding new configurations, it is recommended that the [Notification Template Box] automatically render and fill the system's built-in default template according to the notification type of the selected recipient.
It is recommended to display the currently supported template environment variables when editing the notification template UI. Please refer to Huawei Cloud Message Notification Template.

receive!

@Eden4701 hi 打扰了 今天使用中有个建议反馈下 我们现在对默认模版每次是发告警时去打开文件，读取文件内容，关闭文件这样，在大量告警消息时会很耗性能。建议参考 org.dromara.hertzbeat.manager.service.impl.AppServiceImpl#run 在程序启动时统一读取文件加载到内存中，发告警消息时若使用内置默认模版，就到内存中取模版内容即可。

Bot detected the issue body's language is not English, translate it automatically. 👯👭🏻🧑🤝🧑👫🧑🏿🤝🧑🏻👩🏾🤝👨🏿👬🏿

@Eden4701 hi I’m sorry to bother you. I have a suggestion during use today. Please give me feedback. We now use the default template to open the file, read the file content, and close the file every time an alarm is sent. This will consume a lot of performance when there are a large number of alarm messages. It is recommended to refer to org.dromara.hertzbeat.manager.service.impl.AppServiceImpl#run to uniformly read the file and load it into the memory when the program starts. If you use the built-in default template when sending an alarm message, just get the template content from the memory.

@Eden4701 hi 打扰了 今天使用中有个建议反馈下 我们现在对默认模版每次是发告警时去打开文件，读取文件内容，关闭文件这样，在大量告警消息时会很耗性能。建议参考 org.dromara.hertzbeat.manager.service.impl.AppServiceImpl#run 在程序启动时统一读取文件加载到内存中，发告警消息时若使用内置默认模版，就到内存中取模版内容即可。

ok

Bot detected the issue body's language is not English, translate it automatically. 👯👭🏻🧑🤝🧑👫🧑🏿🤝🧑🏻👩🏾🤝👨🏿👬🏿

@Eden4701 hi Sorry to bother you. I have a suggestion and feedback during use today. We now use the default template to open the file, read the file content, and close the file every time an alarm is sent. This will consume a lot of performance when there are a large number of alarm messages. It is recommended to refer to org.dromara.hertzbeat.manager.service.impl.AppServiceImpl#run to uniformly read the file and load it into the memory when the program starts. If you use the built-in default template when sending an alarm message, just get the template content from the memory.

OK


Unable to read Excel after recent update to Excel for Mac

We have a bulk upload function on our site. This has stopped working for me, but not for other users. It works for me if I use an XLSX provided by another user, but breaks if I open the file and save it.
I believe it relates to a recent update to Office for Mac 2016 - probably the one described as "Fix a long-running issue where Excel fails to save changes on certain enterprise storage configurations such as NetApp FAS units. Excel now adopts the same file saving pattern as Word." here: https://support.office.com/en-us/article/Release-notes-for-Office-2016-for-Mac-ed2da564-6d53-4542-9954-7e3209681a41?ui=en-US&rs=en-US&ad=US
It initially fails here:
tag.match(/(\w+)="([^"]*)"/g).map(
    function(x){var y=x.match(/(\w+)="([^"]*)"/); z[y[1]] = y[2]; });

It fails on a <b /> tag as the Regex doesn't match and x becomes null.
This can be fixed by replacing the above with:
var matches = tag.match(/(\w+)="([^"]*)"/g);
if (matches !== null) {
   matches.map(function(x){var y=x.match(/(\w+)="([^"]*)"/); z[y[1]] = y[2]; });
}

Looks like we're on an old version - closing


Iron-Router Error: request entity too large at makeError

Hi,
I'm trying to upload json data to my application via a POST request to the Restivus REST API. The json data has about 350kByte of size.
Unfortunately I receive this error message: "Error: request entity too large at makeError"
I suppose I found the solution here: https://github.com/iron-meteor/iron-router/issues/710
How can I achieve this in Restivus? Is there a way to configure the routers centrally like the Restivus.configure() stuff?

Let me check if this is specific to Iron Router (the Iron Router dependency has been removed from Restivus in the unreleased v0.7.0). From the issue you referenced, it appears it may be a property that can be set on the Connect bodyParser middleware (this middleware is used in the Iron Router replacement, JsonRoutes, as well). I'll look into providing an option in Restivus for increasing the size limit. I probably won't have a chance to look into this until later tonight. I'll keep you posted. Sorry for the inconvenience!

I am having the same issue.

This could be a fairly simple fix if it's just a matter of setting a config option in the bodyParser. I'll look into this tonight and get back to you. I'm going to do this on the 0.7.0 branch, because I just can't deal with Iron Router and all the headache that comes along with that anymore. I will make a strong effort to do the 0.7.0 release this weekend, or no later than next week. It's all the doc updates that are taking the longest.

Would either of you be able to share a sample request body with me for testing?

I'll try to do so tomorrow morning (GMT+1) - so in about 14 hours.
Kahmali Rose<EMAIL_ADDRESS>schrieb am Mo., 15. Juni 2015 um
20:13 Uhr:

Would either of you be able to share a sample request body with me for
testing?
—
Reply to this email directly or view it on GitHub
https://github.com/kahmali/meteor-restivus/issues/78#issuecomment-112155794
.

Awesome. Thanks @michaelleuzinger!

Late but hopefully not too late...
https://github.com/michaelleuzinger/files/blob/master/large.json

You have to configure the bodyParser on the server side in order to allow bigger requests :
Router.configureBodyParsers = function() {
    Router.onBeforeAction(Iron.Router.bodyParser.urlencoded({
        extended: true,
        limit: '20mb'
    }), {where: 'server'});
};

Thanks for the test data @michaelleuzinger! And thanks for the information @samybob1! I would add an API config option to get rid of the boilerplate, but I'm close to releasing v0.8.0, which removes Iron Router, so we'll need to add a means of increasing the body size limit in simple:json-routes (the iron router replacement), and I'll provide a config option whenever that's taken care of. Sorry for being so slow on a resolution for this.

Hi, I have the same problem with json-routes and large POST requests. Is there a way to deal with that?
Thanks for you time.

Hi @heiligeslama. Thanks for reporting this issue. I knew it was coming, as you can see from my comment above :) I filed an issue on the simple:json-routes repo with  a suggested fix. If you have the time and means you could always submit a PR for it to get the ball rolling a lot faster. Unfortunately, as I mentioned in the issue over there, I just don't have any free time to devote to this right now.

The request size limit has been increased to 50mb in v0.8.6


Crash with Vintage Story 1.17.2

Reported by Tels.
https://discord.com/channels/302152934249070593/454909656230526976/1015716631588126740

Hopefully fixed with the 1.2.2 release. Cannot confirm, though, as it is a rare crash that I couldn't replicate.


data preprocess error

operands could not be broadcast together with shapes (1,1025) (0,)
File "/home/ubuntu/Tacotron-2-master/datasets/preprocessor.py", line 42, in
return [future.result() for future in tqdm(futures) if future.result() is not None]
File "/home/ubuntu/Tacotron-2-master/datasets/preprocessor.py", line 42, in build_from_path
return [future.result() for future in tqdm(futures) if future.result() is not None]
File "/home/ubuntu/Tacotron-2-master/preprocess.py", line 17, in preprocess
metadata = preprocessor.build_from_path(hparams, input_folders, mel_dir, linear_dir, wav_dir, args.n_jobs, tqdm=tqdm)
File "/home/ubuntu/Tacotron-2-master/preprocess.py", line 83, in run_preprocess
preprocess(args, input_folders, output_folder, hparams)
File "/home/ubuntu/Tacotron-2-master/preprocess.py", line 106, in main
run_preprocess(args, modified_hp)
File "/home/ubuntu/Tacotron-2-master/preprocess.py", line 110, in
main()

I managed to fix this by updating librosa to 0.6.2


Bug: The avatar image on the user profile page appears square instead of round

Fixed by 390df55 commit


move new layers and models to towhee from towhee's hub.

Signed-off-by: zhang chen<EMAIL_ADDRESS>move new layers and models to towhee from towhee's hub.

/lgtm

/approve


getBTCBalance tool API does not support bech32 addresses

The Blockchain API does not support bech32 address type. A different blockchain API should be used to query for Address Balance.

@Septem151 - Nice solution to getBTCBalance()!  Where did you find the information about the fields to work that out?

Where did you find the information about the fields to work that out?

I looked on the Esplora API Documentation and tested the endpoints using Postman to see what they returned.


Time is displayed in UTC

Using AOSP  /e/ time is displayed in UTC and no way to set it to my timezone.
It is a bit counterintuitive to read sunshine at 8pm.

Same problem on regular Android on Samsung tablet, here we are in GMT-10 (Honolulu/Tahiti)

Same problem on regular Android on Samsung tablet, here we are in GMT-10 (Honolulu/Tahiti)

Is this in the astronomy tab? I haven't seen this before, can you send me what your system time settings are?

Is this in the astronomy tab? I haven't seen this before, can you send me what your system time settings are?

It is currently configured to use the system default timezone, which is returned by Android itself

It is currently configured to use the system default timezone, which is returned by Android itself

Can you double check the location settings in Trail Sense just to confirm they are correct? That's Settings > GPS in TS

Can you double check the location settings in Trail Sense just to confirm they are correct? That's Settings > GPS in TS

(this looks more like the location is incorrect rather than the times being in UTC)

(this looks more like the location is incorrect rather than the times being in UTC)

Yes I can confirm that this is what happens when the location is 0, 0

Yes I can confirm that this is what happens when the location is 0, 0

So that means either the GPS can't get location, or the permission was denied and the location override needs to be set in the GPS settings of TS

So that means either the GPS can't get location, or the permission was denied and the location override needs to be set in the GPS settings of TS

After setting GPS manually,  correct time is displayed.

After setting GPS manually,  correct time is displayed.

Verified permission,  they are correct.

Verified permission,  they are correct.

So just to confirm, it doesn't work properly for you when GPS is set to auto, but does when you manually override it? If that is the case, can you re-enable auto GPS and then verify your location appears on the navigation tab?
(if I misunderstood, and you are all set, feel free to close this issue)

So just to confirm, it doesn't work properly for you when GPS is set to auto, but does when you manually override it? If that is the case, can you re-enable auto GPS and then verify your location appears on the navigation tab?
(if I misunderstood, and you are all set, feel free to close this issue)

There's also a "Sensor details" option on the settings tab of TS - if you could send a screenshot of that, it would be appreciated to help figure out what's going on - though, it may just be a very delayed GPS reading.

There's also a "Sensor details" option on the settings tab of TS - if you could send a screenshot of that, it would be appreciated to help figure out what's going on - though, it may just be a very delayed GPS reading.

It definitely require GPS not to be in automatic,  eventually getting data from GPS  works. Will try further when back home.

It definitely require GPS not to be in automatic,  eventually getting data from GPS  works. Will try further when back home.

Everythings at true, except hygrometer.

Everythings at true, except hygrometer.

Also, something that I've seen before is the device is set to use the GPS in "battery saving" or "network" mode, but Trail Sense requires that the device is using "device only" or "high accuracy", as it doesn't use network location. Not sure if that is coming into play here though. I suspect it is a slow reading (and I have an open issue to add a timeout there) or that the satellite count isn't supported on your device, which would lead to slow readings.

Also, something that I've seen before is the device is set to use the GPS in "battery saving" or "network" mode, but Trail Sense requires that the device is using "device only" or "high accuracy", as it doesn't use network location. Not sure if that is coming into play here though. I suspect it is a slow reading (and I have an open issue to add a timeout there) or that the satellite count isn't supported on your device, which would lead to slow readings.

Both tested device are using regular gps mode. No battery saving.
The gps works well when using the button "get location from gps"

Both tested device are using regular gps mode. No battery saving.
The gps works well when using the button "get location from gps"

If you click the get location from GPS button, then re-enable auto GPS, and then immediately go back to the astronomy page, does that help at all? I'm going to put in that condition check for when the GPS is 0,0 that I'll push out in the next update - I suspect it will resolve this, as it forces a GPS update in that case.

If you click the get location from GPS button, then re-enable auto GPS, and then immediately go back to the astronomy page, does that help at all? I'm going to put in that condition check for when the GPS is 0,0 that I'll push out in the next update - I suspect it will resolve this, as it forces a GPS update in that case.

Yes it helps.  Time is correctly displayed.

Yes it helps.  Time is correctly displayed.

Thanks! That confirms my theory, which I will provide a fix for in the next release. If this happens again, you should be able to force an update by using the above method.

Thanks! That confirms my theory, which I will provide a fix for in the next release. If this happens again, you should be able to force an update by using the above method.

This should be fixed in version 1.6.0 (will be releasing over the weekend). I'm going to close this issue, but if after installing 1.6.0 this happens again, feel free to reopen.

This should be fixed in version 1.6.0 (will be releasing over the weekend). I'm going to close this issue, but if after installing 1.6.0 this happens again, feel free to reopen.


Refactor: improve ID comparison for get_message

Summary

This pull request refactors the get_message function to improve ID comparison. It changes the comparison from integer conversion to string comparison, enhancing code readability and avoiding unnecessary type conversions.
General Info

[x] If code changes were made then they have been tested.

[ ] I have updated the documentation to reflect the changes.

[ ] This PR fixes an issue (please put issue # in summary).
[ ] This PR adds something new (e.g. new method or parameters).
[ ] This PR is a breaking change (e.g. methods or parameters removed/renamed)
[ ] This PR is not a code change (e.g. documentation, README, ...)

Comparing ints is much faster than comparing strings. Also, it just works, so why change it?

message_id: Snowflake
Snowflake allows passing in str and int. If a str type is passed, it will throw an error. This is not a meaningless modification.


Feature/input descriptor interface

Suggestion to how to seperate the different use cases into seperate classes without messing up the serialization using JsonContentPolymorphicSerializer

Please only look at the last commit. If you like it I will deal with the mess.


Added 2 Questions in Ola Labs Folder

HacktoberFest 2021 Contribution

HacktoberFest 2021 Contribution

Please fix the formatting issue. Commit looks good otherwise.


Make DrawCommandType an abstract Int enum

By making it an integer it makes sure the compiler doesnt turn it into a dynamic enum, improving the performance of switch statements like the ones in DrawCommandReader

I'd lean toward not merging this. However, if someone can create a benchmark that shows that this change makes an impactful difference in performance, I'd reconsider. My gut feeling is that this change won't make a measurable difference, but I'd be very happy to be proven wrong.

Currently enums in Haxe are normally heavy and slow, so this is a good move.
abstract enums are much faster, as there is lots of AST magic where results are resolved to values rather than using more complex structures. But I would forget the less than 4 as that is largely irrelevant being too much in the past.
I have some support for similar.
https://github.com/nanjizal/justPath/blob/master/justPath/PathCommand.hx
enums are theortically cool but in real use they often suck for performance, abstract enums very limited compared,  but they almost disappear with ast optimization.

an abstract enum to the compiler is normally just a basic value so can be replaced in place rather than requiring a look up of a structure? Or my understanding atleast.

enums in Haxe are normally heavy and slow, so this is a good move

Maybe. I suspect that the difference is insignificant the vast majority of the time. I still want to see a benchmark that shows this change actually makes things measurably faster before I even consider merging.

Well largely the point is haxe can replace the abstract enum with a number at runtime, and for low level drawing speed is important, rather than game logic where it may not alway be as important.
Take a simple case for JS since that is easy to look at generated source.
https://try.haxe.org/#9582b2c5
enum ABC {
  A;
  B;
  C;
}

enum abstract ABC_( Int ) {
  var A;
  var B;
  var C;
}
class Test {
  static function main() {
    trace("Haxe is great!");
    //trace( ABC.A );
    trace( ABC_.A );
  }
}

so for abstract enum the trace is just an integer with no generation overhead.
// Generated by Haxe 4.3.6
(function ($global) { "use strict";
class Test {
	static main() {
		console.log("Test.hx:15:","Haxe is great!");
		console.log("Test.hx:17:",0);
	}
}
class haxe_iterators_ArrayIterator {
	constructor(array) {
		this.current = 0;
		this.array = array;
	}
	hasNext() {
		return this.current < this.array.length;
	}
	next() {
		return this.array[this.current++];
	}
}
{
}
Test.main();
})({});

But for the current setup..
// Generated by Haxe 4.3.6
(function ($global) { "use strict";
var $estr = function() { return js_Boot.__string_rec(this,''); },$hxEnums = $hxEnums || {},$_;
Math.__name__ = true;
var ABC = $hxEnums["ABC"] = { __ename__:true,__constructs__:null
	,A: {_hx_name:"A",_hx_index:0,__enum__:"ABC",toString:$estr}
	,B: {_hx_name:"B",_hx_index:1,__enum__:"ABC",toString:$estr}
	,C: {_hx_name:"C",_hx_index:2,__enum__:"ABC",toString:$estr}
};
ABC.__constructs__ = [ABC.A,ABC.B,ABC.C];
class Test {
	static main() {
		console.log("Test.hx:15:","Haxe is great!");
		console.log("Test.hx:16:",ABC.A);
	}
}
Test.__name__ = true;
class haxe_iterators_ArrayIterator {
	constructor(array) {
		this.current = 0;
		this.array = array;
	}
	hasNext() {
		return this.current < this.array.length;
	}
	next() {
		return this.array[this.current++];
	}
}

You could try adding some switch statements... I would be inclined to just change it and see who complains!
However although frowned on I would put 'to' and 'from' to save compile errors you can always consider removal in the future but for non breaking changes in areas like switch statements probably worth it.

enum ABC {
  A;
  B;
  C;
}

enum abstract ABC_( Int ) from Int to Int {
  var A;
  var B;
  var C;
}
class Test {
  static function main() {
    trace("Haxe is great!");
    //trace( ABC.A );
    trace( ABC_.A );
  }
}

I guess with an array / for loop you could test timings with a timing macro. But it is obviously less overhead and a small worthwhile win.

It may not be worthwhile, which is why I’m continuing to ask for a performance benchmark showing an improvement in OpenFL drawing performance. It’s quite possible that this PR will make no significant difference without billions of drawing commands (assuming other factors don’t affect performance long before this would, which is very likely). If it’s not measurablely better, I’m inclined to make no changes because they’ll feel like making changes only for the sake of some kind of unnecessary purity rather than for practical reasons.
On the other hand, if there’s a nice little boost, then absolutely, I’m happy to merge.
I think I’ve made my thoughts on the matter clear. Any further discussion of theoretical performance is a waste of time. I want to see some real code that can demonstrate a performance win.


Disable deprecation warning check for GradleBuildSmokeTest

https://github.com/gradle/gradle-private/issues/3405

@bot-gradle test and merge

Your PR is queued. See the queue page for details.

OK, I've already triggered a build for you.


Readme: PSWG whitepaper link is broken

The PSWG link in readme is broken. It should be updated to: https://www.hyperledger.org/learn/publications/blockchain-performance-metrics. Same should be done for the documentation website too

Hey @aritroCoder, could you please assign the broken PSWG link issue to me? I'd like to take the lead on resolving it.


imv: 3.1.2 -> 4.0.1

Motivation for this change
Update imv to version 4.0.1.  Changelog: https://github.com/eXeC64/imv/blob/a6deca0ad390d29ada6d72584a1be835a3913139/CHANGELOG#L4-L40
I kept the standard imv build, that produces both x11 and wayland versions.  We could also separate imv or/and add flags to enable which version is actually build to keep the dependency smaller.  Given however that the closure size decreased from ~140M to 123M I think it's okay for now as it is.
Also separated the stuff needed to build the manpage into nativeBuildInputs
Things done

[ ] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
Built on platform(s)

[x] NixOS
[ ] macOS
[ ] other Linux distributions

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
[x] Tested execution of all binary files (usually in ./result/bin/)
[x] Determined the impact on package closure size (by running nix path-info -S before and after)
[ ] Ensured that relevant documentation is up to date
[x] Fits CONTRIBUTING.md.

Notify maintainers
cc @rnhmjoj

@GrahamcOfBorg build imv


Update @jonpulsifer's email and delete some spaces

These emails are better respected in another inbox, my filter game is
not that strong.
Signed-off-by: Jonathan Pulsifer<EMAIL_ADDRESS>😄

/lgtm
/approve
Thanks for cleaning up the trailing whitespace... that always bugs me.


MudMenu: Fix MouseEventArgs in net7 on BSS

Description

In net7 the new native onmouseenter event returns MouseEventArgs which seems not to downcast to EventArgs in BSS (probably a signalr thing).
In net6 our polyfill uses EventArgs due to a framework limitation in net5 that was solved in net6.
Therefore I updated the polyfill which has a small chance of breaking change for those that use our polyfill (as it is public).
However this is not a documented feature so I think we go for the greater good of fixing MudMenu
Added the correct signature in MudMenu.
How Has This Been Tested?

Visually using docs

Before Fix
Wasm Hosted net6 - pass
BSS net6 - pass
Wasm Hosted net6 - pass
Wasm Hosted net7 - pass
BSS net7 - failed
After Fix
All senarios pass
Types of changes

[x] Bug fix (non-breaking change which fixes an issue)
[x] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

[x] The PR is submitted to the correct branch (dev).
[x] My code follows the code style of this project.
[ ] I've added relevant tests.

@iXyles

LGTM! 👍


This script works only with Python 2

Is it possible to make the code in a2sv.py compatible with Python 3? E.g. moving from print 'abc' to print('abc').
As an alternative the script could check at runtime the Python version with sys.version or sys.version_info[0] and stop the execution if not Python 2.

2to3


Additional CLI functionality

This PR adds a few simple CLI features I found myself wanting while working on a zkapp with several smart contracts.
Features:

keypair generation
display config and deploy aliases
set deploy alias property values
selectable default url and fee

To see the specific tasks where the Asana app for GitHub is being used, see below:

https://app.asana.com/0/0/1204678398180871

Thanks for the contribution @Isaac-DeFrain! I will review this pr shortly.

Hi. Will this ever be reviewed?

Hi. Will this PR be reviewed?

Hey @Isaac-DeFrain. Sorry for the delay. There have been many additions to the cli including the ability to add a third party fee payer account since you made this pr. Have you tried the latest version 10.1? Could modify this to be compatible with the latest version?


[Bug]: optimizing Tab paging display error

What happened?

No matter how many items are selected to be displayed per page, there will only be one page in the end.
Affects Versions
master
What table formats are you seeing the problem on?
No response
What engines are you seeing the problem on?
AMS
How to reproduce
No response
Relevant log output
No response
Anything else
No response
Are you willing to submit a PR?

[ ] Yes I am willing to submit a PR!

Code of Conduct

[X] I agree to follow this project's Code of Conduct

ams returns total value error

I suggest keeping an eye on this PR merged recently:
https://github.com/apache/amoro/pull/2914
This modified a lot

@huyuanfeng2018 this may be the problem introduced by #2914, I'll submit a patch for this. the total number is correct, but the value is not right. this was merged into 0.8-SNAPSHOT(not in 0.7 branch), so we don't need to backport this to 0.7-branch if we don't want backport #2914 back.

@huyuanfeng2018 I've filed a pr(#3231) try to fix this problem, could you please check whether this fix your problem thanks.


422 error when trying to create a new service from swagger definition

Launched the following command:
3scale-cli import swagger -f swagger-mock.yaml -p {method}_{path}
with the attached file
swagger-mock.yaml.txt
and received the following error while processing it:
[3scale-cli] ERROR encountered on creating Mapping rule: undefined
/usr/lib/node_modules/node-3scale-cli/node_modules/q/q.js:155
                throw e;
                ^

Error: Server responded with status code 422 undefined
    at /usr/lib/node_modules/node-3scale-cli/lib/mappingrules.js:29:13
    at _combinedTickCallback (internal/process/next_tick.js:73:7)
    at process._tickCallback (internal/process/next_tick.js:104:9)
From previous event:
    at createMappingRulePromise (/usr/lib/node_modules/node-3scale-cli/lib/swagger.js:123:113)
    at /usr/lib/node_modules/node-3scale-cli/node_modules/delay-promise/index.js:15:18
    at delay.then (/usr/lib/node_modules/node-3scale-cli/node_modules/delay-promise/index.js:8:33)
From previous event:
    at threescale_waterfall (/usr/lib/node_modules/node-3scale-cli/lib/swagger.js:88:4)
    at /usr/lib/node_modules/node-3scale-cli/lib/swagger.js:36:11

hey @lucamaf
there is a missing basePath property in the swagger spec.
it's not mandatory to make the description valid, but our flow rely on it.
adding a simple basePath: '/' will do the job.


add is_incremental as additional example of when you will need to force dependencies

Contributions

[ ] I have read the contribution docs, and understand what's expected of me.

Link to the page on docs.getdbt.com requiring updates
https://docs.getdbt.com/reference/dbt-jinja-functions/ref#forcing-dependencies
What part(s) of the page would you like to see updated?
We already have an example for when you need to force dependencies - a model that only has a macro.
Let's also add an example for when references are wrapped in the is_incremental() macro - see slack thread.
Dependencies nested in the is_incremental macro will not show up in lineage, so will need to force dependencies in that case.
Example
If you have an incremental model that includes a snippet like below, then you will not be able to see the source('raw', 'orders') upstream dependency in the lineage.
{% if is_incremental() %}
select * from {{ source('raw', 'orders') }}
{% endif %}

This is because the is_incremental macro will always return false at parse time, so anything buried inside that will not be available to parsing, so will not be added to depends_on.
So in this case, you'd need to do force a dependency outside of the is_incremental() conditional like this instead:
 -- depends_on: {{ source('raw', 'orders') }}

{% if is_incremental() %}
select * from {{ source('raw', 'orders') }}
{% endif %}

Thanks @graciegoheen! Anything you think we should add to the is_incremental macro docs?

No I think this is enough!


Do not start fetch if link fails

this was fixed incidentally by fixing the updateUserInfo methods in the google & Microsoft strategies


tracing - expose jaeger collector endpoint

Allows user to specify jaeger_collector endpoint that overrides agent_address (based on client functionality)
Adds docker-compose with jaeger ports exposed that work with current benthos configurations (agent and collector)

Thanks again @Jeffail !

Thanks again @Jeffail !

Looks good, nice one @nwest1!

Looks good, nice one @nwest1!


[Airbrake] [Staging] no implicit conversion from nil to integer

Airbrake error: #3499
Airbrake project: ETMoses
Error type: TypeError
Error message: no implicit conversion from nil to integer
Where: gas_asset_lists#gas_load
Occurred at: May 19, 2016 08:17:05 UTC
First seen at: May 19, 2016 08:17:05 UTC
Occurrences: 1 (1 since last deploy on May 18, 2016 15:38:56 UTC)
URL: https://beta-moses.energytransitionmodel.com/testing_grounds/502/gas_asset_lists/11/gas_load
File: [PROJECT_ROOT]/app/models/installed_gas_asset.rb
Backtrace:
[PROJECT_ROOT]/app/models/installed_gas_asset.rb:33:in []
[PROJECT_ROOT]/app/models/installed_gas_asset.rb:33:in pressure_level
[PROJECT_ROOT]/app/models/installed_gas_asset.rb:40:in pressure_level_name
[PROJECT_ROOT]/app/models/network/builders/gas_chain/slots.rb:22:in block in initialize

I modified the gas asset lists for the affected LESes (see #980). The problem is that a number of assets were assigned pressure_level_index: null. I can't seem to recreate this myself.


Create simple_neural_net.ipynb

Happy Learn..)

Hi, we don't need Ipython notebooks in the package.
We already have neural networks and we don't accept copypasted code.


Update k8s version in the CI

This PR updates the k8s versions in the CI. The supported version in the Kubernetes community, EKS, and AKS are the following.

Kubernetes (https://kubernetes.io/releases/)

Supported

1.25
1.24
1.23

EoL

1.20
1.19
1.22
1.21

EKS (https://docs.aws.amazon.com/eks/latest/userguide/kubernetes-versions.html#kubernetes-release-calendar)

Supported

1.24
1.23
1.22
1.21

EoL

1.20
1.19

AKS (https://learn.microsoft.com/en-us/azure/aks/supported-kubernetes-versions?tabs=azure-cli#aks-kubernetes-release-calendar)

Supported

1.24
1.23
1.22

EoL

1.21
1.20
1.19

In this PR, I updated versions that are used for testing as follows based on the above supported versions.
I decided to patch versions based on the latest version provided in kindest/node since we use the kind for testing in the CI.

v1.21.14
v1.22.16
v1.23.14
v1.24.8
v1.25.4

All versions test is passed in the other PR.
https://github.com/scalar-labs/helm-charts/pull/155
So, we can support from v1.21 to v1.25 now.
And, I think we can merge this PR into the main branch.
Please take a look!

I will do the following two updates in the other PR.

Update README to describe the supported version.
Update CI to run all versions test triggered by workflow_dispatch.


AuthorityFactory and other deployment support contracts

This PR deploys to Sepolia testnet the smart contracts that will support the DApp deployment system.
It includes:

AuthorityFactory: a simple to use factory for Authorities. This will enable the indexing of Authorities and easy of configuration during dapp deployment by selecting the Authority from a list
ControlledDAppFactory: a deployer of DApps that implements both IFinancialProtocol and IMachineProtocol and can be used for validators with no onchain payment.
ERC20DAppSystem: a factory of deployer of DApps that can choose any ERC20 accepted as payment.

Changes applied and rebased


fix an issue with min height of screen when Offline Indicator is shown

@fedirjh @luacmartins

Details

I moved the minHeight style to the root View, because the child View has some paddings. (just put it in KeyboardAvoidingView because of maxWeight). Also because of that we don't need to calculate insets in useInitialWindowDimensions hook.
I've got rid of shouldEnableMaxHeight and added shouldEnableKeyboardAvoidingView={false} to EditRequestAmountPage page to behave the same as MoneyRequestSelectorPage page and fix an issue when go back from currency selector

Fixed Issues

$ https://github.com/Expensify/App/issues/17866
PROPOSAL: https://github.com/Expensify/App/issues/17866#issuecomment-1631355043
Fix of the issue with offline mode:
https://github.com/Expensify/App/issues/30840
Tests

Case with adding money request:

Launch New Expensify app.
Tap + > Request money.
Enter amount of money
Press next
Go back
Verify that the keyboard does not flash.

Case with editing money request:

Launch New Expensify app.
Tap + > Request money.
Create a manual request.
Open the IOU details view
Tap Amount
Select some currency.
Go back
Verify that the keyboard does not flash.

[x] Verify that no errors appear in the JS console

Offline tests

Case with adding money request:

Launch New Expensify app.
Force "Offline" mode
Tap + > Request money.
Enter amount of money
Press next
Go back
Verify offline message will not overlap with the white navigation bar (IOS native)

Case with editing money request:

Launch New Expensify app.
Force "Offline" mode
Tap + > Request money.
Create a manual request.
Open the IOU details view
Tap Amount
Select some currency.
Go back
Verify offline message will not overlap with the white navigation bar (IOS native)

QA Steps

See above.

[x] Verify that no errors appear in the JS console

PR Author Checklist

[x] I linked the correct issue in the ### Fixed Issues section above
[x] I wrote clear testing steps that cover the changes made in this PR

[x] I added steps for local testing in the Tests section
[x] I added steps for the expected offline behavior in the Offline steps section
[x] I added steps for Staging and/or Production testing in the QA steps section
[x] I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
[x] I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
[x] I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).

[x] I included screenshots or videos for tests on all platforms
[x] I ran the tests on all platforms & verified they passed on:

[x] Android: Native
[x] Android: mWeb Chrome
[x] iOS: Native
[x] iOS: mWeb Safari
[x] MacOS: Chrome / Safari
[x] MacOS: Desktop

[x] I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
[x] I followed proper code patterns (see Reviewing the code)

[x] I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
[x] I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
[x] I verified that comments were added to code that is not self explanatory
[x] I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
[x] I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method

[x] If any non-english text was added/modified, I verified the translation was requested/reviewed in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:

[x] I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
[x] I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
[x] I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
[x] I verified the JSDocs style guidelines (in STYLE.md) were followed

[x] If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
[x] I followed the guidelines as stated in the Review Guidelines
[x] I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
[x] I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
[x] I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
[x] I verified that if a function's arguments changed that all usages have also been updated correctly
[x] If a new component is created I verified that:

[x] A similar component doesn't exist in the codebase
[x] All props are defined accurately and each prop has a /** comment above it */
[x] The file is named correctly
[x] The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
[x] The only data being stored in the state is data necessary for rendering and nothing else
[x] If we are not using the full Onyx data that we loaded, I've added the proper selector in order to ensure the component only re-renders when the data it is using changes
[x] For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
[x] Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
[x] All JSX used for rendering exists in the render method
[x] The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions

[x] If any new file was added I verified that:

[x] The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory

[x] If a new CSS style is added I verified that:

[x] A similar style doesn't already exist
[x] The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG))

[x] If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
[x] If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
[x] If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
[x] If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
[x] If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
[x] If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
[x] I have checked off every checkbox in the PR author checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: Native

https://github.com/Expensify/App/assets/6162207/69111769-ffcc-48e0-8718-7f5ac6468e62
https://github.com/Expensify/App/assets/6162207/421efe98-1a71-45f5-b465-4f076e61354d
https://github.com/Expensify/App/assets/6162207/9bfdeef3-2c42-481e-b6ee-eac448417660

Android: mWeb Chrome

https://github.com/Expensify/App/assets/6162207/43ebb362-00a3-4032-bc2d-9c5f7086f473
https://github.com/Expensify/App/assets/6162207/198fe4d6-a755-4a4d-81e0-e3e113d8e0ab

iOS: Native

https://github.com/Expensify/App/assets/6162207/412347f2-750c-469e-abe3-a678b451522e
https://github.com/Expensify/App/assets/6162207/873bd7ed-f0cb-4fe8-9544-763d14dab79d
https://github.com/Expensify/App/assets/6162207/b1c58e48-be6d-4f0b-a1bb-dbd0f9c0b801

iOS: mWeb Safari

https://github.com/Expensify/App/assets/6162207/efe49485-fd23-41a2-8f10-1e99ffd54877
https://github.com/Expensify/App/assets/6162207/17147cf7-2aa5-44db-979d-c1035f92e33e
https://github.com/Expensify/App/assets/6162207/bb05b8e7-6cb4-4aed-a6d5-314cfb8e2250

MacOS: Chrome / Safari

MacOS: Desktop

We have a failed Reassure test.

Oh, I see.  What can I do with that? It seems the error is not related to components and files that I was changed. It seem this is an error, because of someone else commits.

I think merging main should fix the issue

Sorry, closed by accident

@sarious are you able to do this asap? This is blocking the deploy so we'd like to get this fixed.

I'm gonna merge this PR with failing reassure tests since they are unrelated to the changes in this PR and this is blocking the deploy.

See above

:hand: This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

🚀 Cherry-picked to staging by https://github.com/puneetlath in version: 1.3.95-7 🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
success ✅

🕸 web 🕸
success ✅

@Expensify/applauseleads please QA this PR and check it off on the deploy checklist if it passes.

🚀 Deployed to production by https://github.com/puneetlath in version: 1.3.95-9 🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
success ✅

🕸 web 🕸
success ✅

I think merging main should fix the issue

I wanted to do that at first, but each merge of main branch added new problems. Firstly, it was lint issues, because someone pushed the code without the checks, after that I've got Performance Test Issues and in the end Jets Test Errors.. And all of these errors wasn't related to my code.
So, I thought maybe you can just re-run the all steps (without merging) if this error not related to some task, but just a mystical error.

🚀 Deployed to production by https://github.com/puneetlath in version: 1.3.97-7 🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
success ✅

🕸 web 🕸
success ✅


textacy dependency missing

I attempted a pip install and am getting a ModuleNotFoundError: No module named 'textacy' when attempting to use the CLI.

PR #22

Hi @pmbaumgartner , thank you so much! Merging it soon :)


How use the parameter "query" with Irony

I was seen both the class "QueryConditionGrammar"  and  then project "Irony" ,but I  still can't understand how use it,could you show it example?

sorry, i can use it,

sorry,my bad.


Homepage - Enter your email or phone number input focused when there saved credentials

If you haven’t already, check out our contributing guidelines for onboarding and email<EMAIL_ADDRESS>to request to join our Slack channel!

Version Number: 9.0.64-1
Reproducible in staging?: Y
Reproducible in production?: Y
If this was caught on HybridApp, is this reproducible on New Expensify Standalone?: N/A
If this was caught during regression testing, add the test name, ID and link from TestRail: https://expensify.testrail.io/index.php?/tests/view/5241946
Issue reported by: Applause - Internal Team
Action Performed:
precondition: user has saved credentials, and enabled autofill passwords

Go to https://www.expensify.com/
or https://staging.expensify.com/

Expected Result:
The "Enter your email or phone number" input should not be focused
Actual Result:
The "Enter your email or phone number" input is focused and saved credentials are suggested when navigating to the home page
Workaround:
Unknown
Platforms:

Which of our officially supported platforms is this issue occurring on?

[ ] Android: Standalone
[ ] Android: HybridApp
[x] Android: mWeb Chrome
[ ] iOS: Standalone
[ ] iOS: HybridApp
[ ] iOS: mWeb Safari
[ ] MacOS: Chrome / Safari
[ ] MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

https://github.com/user-attachments/assets/991b6ff9-ffd6-4741-97b1-7969cf27e014
View all open jobs on GitHub

Pulled up expensify.com on Android, Chrome and it didn't autofocus on the compose box
Since we're not using passwords any more, in favor of magic codes, I don't think we should prioritize fixing this


Stack size editor and Energymanager dont work after updated LDB tool

TITLE

I also would like to ask, to pleas update your awesome mods, I realy liked them, but now doesn't working any of them.

i updated energy manager in my FactoryOverclock mod and for stack size you can use the one by appuns

i asked him on discord if he gonna update and he said he needs to fix RL and then maybe

Factory overclock is a nice mod, but a bit too cheaty for me. Not my type, despite Energy Manager also cheaty a bit.
I Enjoyed the simplicity of Stack size with the ingame GUI and energymanager with a single .cfg file setup.
I don't know what is RL, but I still waiting for theese mods to be updated.

Free foundations, free soil also not working BTW.

RL is real life


Restrict the maximum count of images the user can pick

Use case

Proposal
can you add this feature
Restrict the maximum count of images the user can pick, so the user can't pick more the number allowed to.

Hi @FIREIDEAS, Thanks for filing the issue. Is this issue proposal regarding limiting the images picked  via image picker? If so  please read this comment https://github.com/flutter/flutter/issues/85772#issuecomment-887614127

in the comment you mentioned that this feature works only on IOS, so is it hard to implement it on android?
there is a package called multi_image_picker https://pub.dev/packages/multi_image_picker2/example
that implemented it but without image quality, so is there any way to add this feature?

so is there any way to add this feature?

Not that I am aware of, But you could look for other existing third-party plugins which support this feature on Android.
Closing as per the linked comment in the above response.

I have a suggestion to implement it, what if we take the number of max images number from user and select images until we reach this number then show scaffold message?


Fix What is ROCm? components list

Cherry-pick #3129 and #3143 into 6.1 release (docs).

Remove Radeon Compute Profiler from list of components

Update ROCm CMake and ROCr (https://github.com/ROCm/rocm-docs-core/pull/780) links

@ROCm/rocm-documentation Can someone merge? I'm not authorized.


Not finding weapons data in roster

uploading roster for Warhammer 40K results in all data EXCEPT unit weaponry printing.

Could post a roster with the problem?

Fixed.


Set idle timeout per Cloud Image

I am using the classic version of the plugin to sleep and wake my agents.
It would be useful if there was a feature to be able to tell an agent not to sleep for say 4h.
I often find myself disabling the agent cloud plugin so I can do maintenance on an Agent without it being shut down.

@aaron-0, increasing Terminate instance idle time does not help in your case?

You are right I'm probably better using that value so at least if I forget to change it back all the agents don't keep running till I realise. I guess I was more after something that could be applied to a single agent

Will be fixed as part of #73


Corrected vital comment issue

Coverage decreased (-0.002%) to 92.974% when pulling 5cb99556ac6af11474ca83b2e1c8563ddddcf74f on RubbaBoy:patch-1 into 588602694fa1d19e433f9e2705aed9ccb0b404ba on apache:trunk.

Coverage decreased (-0.002%) to 92.974% when pulling 5cb99556ac6af11474ca83b2e1c8563ddddcf74f on RubbaBoy:patch-1 into 588602694fa1d19e433f9e2705aed9ccb0b404ba on apache:trunk.

Thanks! 👍


Import Database Fails if DEFAULT is set on any property

In 2.2.0, you can not import a database that had a default value set for one of the properties. There is a problem in the 2.2.0 version of ODatabasImport.
Starting on line 989:
if (attrib.equals("\"min\""))
        min = value;
      else if (attrib.equals("\"max\""))
        max = value;
      else if (attrib.equals("\"linked-class\""))
        linkedClass = value;
      else if (attrib.equals("\"mandatory\""))
        mandatory = Boolean.parseBoolean(value);
      else if (attrib.equals("\"readonly\""))
        readonly = Boolean.parseBoolean(value);
      else if (attrib.equals("\"not-null\""))
        notNull = Boolean.parseBoolean(value);
      else if (attrib.equals("\"linked-type\""))
        linkedType = OType.valueOf(value);
      else if (attrib.equals("\"collate\""))
        collate = value;
      else if (attrib.equals("\"default-value\""))
        collate = value;
      else if (attrib.equals("\"customFields\""))
        customFields = importCustomFields();

Notice that when we get default-value we set collate.  This results in a null pointer exception later on in the code.
I noted that in the develop branch, commit 1b0f490c28a9778a74703a4adde48f7066667140 actually fixes this, even though it was trying to fix another issue.  I am not sure if this has been targeted for a 2.2.x release or not, so I wanted to bring this up in a separate issue to be tracked.
Expected behavior and actual behavior
The database import should succeed.
Steps to reproduce the problem
Export a database with any property that has a default value.  You will get a null pointer exception when importing that database.
Important Questions
Runninng Mode

[X] Embedded, using PLOCAL access mode
[X] Embedded, using MEMORY access mode
[X] Remote

Misc

[ ] I have a distributed setup with multiple servers. How many?
[ ] I'm using the Enterprise Edition

OrientDB Version

[ ] v2.0.x - Please specify last number:
[ ] v2.1.x - Please specify last number:
[X] v2.2.x - Please specify last number:

Operating System

[ ] Linux
[X] MacOSX
[ ] Windows
[ ] Other Unix
[ ] Other, name?

Java Version

[ ] 6
[ ] 7
[X] 8

hi @mmacfadden,
Thank you for so precise reporting, going to fix it quickly
Regards

Hi @mmacfadden,
Yes i confirm is fixed and is going to be released in 2.2.1, can i close it.
Regards

@tglman Yes by all means.  I saw that it was fixed.  I mainly reported it so that others would no go through the same debugging process I did for something that was coming soon!


Issue with Forge Item Capabilities

When playing with any fabric mod in 1.20.1 and possibly 1.21 (havent tested)
Forge item capabilities are broken.
This issue is related to #121 and https://github.com/Sinytra/Connector/issues/1441. except that i opened it in the wrong place.
Looking at issue https://github.com/Sinytra/Connector/issues/1441 i was later informed this is a fabric api forgified bug and not a Connector issue.
I have later tested with multiple mods as such below and have seen item pipes do not connect to any tile entity if the pipe mod is from a forge mod. Using certain mods that extend vanilla items such as hoppers work fine but anything that is custom seems to break. Using LaserIO to force a connection pulls the cards out of the laserio node which makes me think its trying to pull the IInventory wrong.
I am going to look into this on my own time and try to submit a pull request.

Sorry if i was overly hostile, i was just kinda salty from the automated like responce of

As our LTS support target, 1.20.1 now only receives critical fixes related to Connector bugs. Please upgrade to the latest version for mod compatibility support.

when this bug seems to happen with many mods and would consider this critical because its inheritely an issue with how Forge Item Capabilites work and not a connector issue in general.
### Tasks

Once again im sorry i was overly hostile, i just really would like to see this issue fixed, or atleast give me some pointers to submit a proper pull request.

I have identified that the issue is probably tied to the Fabric-transfer-API, going to look deeper into this myself

This commit seemed to of broke it https://modrinth.com/mod/forgified-fabric-api/version/0.89.0+1.9.24+1.20.1

This is the broken commit b00938ec12cc6caa62752e29748f6ce0163a996f.
Going to submit a PR to revert it. I do think that would be easiest solution.

This commit actually broke it https://modrinth.com/mod/forgified-fabric-api/version/0.91.0+1.10.4+1.20.1

I have since confirmed this is also broken in 1.21.


Issue #224

Hi, this issue (#224) is a "good first issue", so I tried to address it

av commit amend should not fetch or push to remote

Is my change what this issue aims to address? I'd appreciate clarification of the details if my understanding is incorrect.
Thank you.

Thank you for review!

/aviator merge


Show dungeon timer breakpoints

Blizzard API gives us also the dungeon timer breakpoints. We could show them in the dungeon tooltip.

Done... I thought it is easier to do it without API, but shortly after i commited it, is saw, thats no problem at all to do it with the API... so i did another commit ;D

Looks great! Yeah we could calc these timers by ourself. Didn't know before that +2 is 80% and +3 is 60% of the timer. But when we already pulled that info we could also use it. Maybe Blizzard changes this for some strange reason.
Tipp: If you add the Issues Number (e.g. #17) at the beginning of your commit message github will automaticaly link the commit(s) to the related issue. I just found that out by accident, but it's a cool feature.


crash when selecting "last time" on edge explore simulator

DataStore fetching lastSteakTimeout
************************ comparing 120 [120, 180, 300] = 0
timerCallback
DataStore fetching lastSteakTimeout
Deciding Selection on steak 0 for null seconds
Error: Debugger killed
Stack:

decideSelection() at C:
cs\garmin\barbecueboss-master\source\Controller.mc:331 0x1000184b
onSelect() at C:
cs\garmin\barbecueboss-master\source\TimeSelectionMenuDelegate.mc:57 0x100022fc
onMenuItem() at C:
cs\garmin\barbecueboss-master\source\TimeSelectionMenuDelegate.mc:17 0x100021af

I was not able to reproduce. Tried with two "last time" of 0:22 and 2:00 and did ok.
For some reason the variable did not have the last time set

Deciding Selection on steak 0 for null seconds

I wonder if it was not saved properly from the datastore.

I just looked at where it failed.

function decideSelection() {
var i = self.getSelectedSteak();
var timeout = self.steaks[i].getTimeout();
System.println("Deciding Selection on steak " + i + " for " + timeout + " seconds");

The cause probably was the steaks[i].getTimeout() returned null.

@arquicanedo I'm going to try to debug this today and see if there is actually an issue here. Works fine on-device for me so I'm not sure if it's actually a problem, or if it's just the simulator.

the issue is that we weren't ever saving the last timeout. if a last time wasn't found, we correctly default it to something but when the user selected a timeout for an item we didn't persist that value anywhere.
Tweaked it a little to make sure we save the last user selected timeout, and if we don't find a saved value in the DataStore we don't show the (last) menu item just the default entries.

looks good on simulator and device, closing.


Easier way to change servers [UX enhancement]

Currently it takes 5 touches to change servers, I find this annoying.
I would recommend making the server name in the top middle clickable and having a list of servers drop down and switching when clicked so it would be much faster (this would be 2 touches.)
Thanks for this app.

Added on v3.2.0.


Support for lightbridge based vehicles

Hey,
this is a more general question. All the drones tested with use OccuSync in various versions. I'm using a M600Pro, which uses a lightbridge 2 connection. Are there fundamental roadblocks for the use with such a system?

DJI have done small changes on alll there systems. So every system must be tested and adapted. We got Inspire 1, Matrice 100 and Phantom 3 to work, they all uses the old system. The 600 I have never tried, nor the Lightbridge video link. Ether you will have to work out the problem, find someone that will, or find a way to send a system to me.

DJI have done small changes on alll there systems. So every system must be tested and adapted. We got Inspire 1, Matrice 100 and Phantom 3 to work, they all uses the old system. The 600 I have never tried, nor the Lightbridge video link. Ether you will have to work out the problem, find someone that will, or find a way to send a system to me.


[Traefik Plugin Catalog] Plugin Analyzer has detected a problem.

The plugin was not imported into Traefik Plugin Catalog.
Cause:
failed to run the plugin with Yaegi: the load of the plugin takes too much time(10s), or an error, inside the plugin, occurs during the load: 1:21: import "github.com/killer-djon/traefik-http2amqp" error: /tmp/traefik-plugin-gop3633141250/src/github.com/killer-djon/traefik-http2amqp/http2amqp.go:7:2: import "github.com/wagslane/go-rabbitmq" error: /tmp/traefik-plugin-gop3633141250/src/github.com/killer-djon/traefik-http2amqp/vendor/github.com/wagslane/go-rabbitmq/connection.go:4:2: import "github.com/rabbitmq/amqp091-go" error: /tmp/traefik-plugin-gop3633141250/src/github.com/killer-djon/traefik-http2amqp/vendor/github.com/rabbitmq/amqp091-go/channel.go:418:18: cannot use type func(amqp091.frame) as type func(*struct {},amqp091.frame)

Traefik Plugin Analyzer will restart when you will close this issue.
If you believe there is a problem with the Analyzer or this issue is the result of a false positive, please contact us.

Fix imported library


useCoursier := false in build.sbt won't work without adding it in project/plugins.sbt too

steps
sbt version: 1.3.0-RC3
echo "useCoursier := false" > build.sbt
mkdir project
echo "sbt.version=1.3.0-RC3" > project/build.properties
echo "addSbtPlugin(\"ch.epfl.scala\" % \"sbt-scalafix\" % \"0.9.5\")" > project/plugins.sbt
sbt updateSbtClassifiers

problem
The problem is if we do useCoursier := false in build.sbt we need to do it in project/plugins.sbt too.

I'm not really sure how to categorize this. The main build settings are not shared with the meta build. I agree that it is a pain point that useCoursier needs to be specified for both the main build and the meta build but I'm not sure that there is much that can be done about it. The workaround would be to run sbt with -Dsbt.coursier=false which will set useCoursier := false for both.
Just out of curiosity, what is broken for you with Coursier? Is there an outstanding issue for it?

@eatkins This specific issue is minor to be fair, all I have to do is add useCoursier := false  everywhere as you said, which is ok.
My original issue is https://github.com/sbt/sbt/issues/4720

Got it. Thanks for the clarification.

I guess this is only needed if your plugins fail to resolve with coursier? like #4852
Then I guess this can be closed as it works as intended

Closing this.


Add a Community Button

Feature Request - Community Button
Is your feature request related to a problem? Please describe.
In user experience research by Carolien Modinger it turned out that users find it hard to find and use the community for tips and feedback.
Describe the solution you'd like
A solution would be to add a specific "community" button linking to a community section on the asreview website (https://asreview.nl/community, work in progress). This leads to increased visibility and accessibility of the community towards new and existing users.
Carolien proposed 2 approaches:

Although approach 1 is presumably simpler to implement, approach 2 puts a stronger emphasis towards "community" and would therefore be preferred.
Describe alternatives you've considered
See approach 1 & 2
Teachability, Documentation, Adoption, Migration Strategy
See above

Some suggestions for the icon:

https://materialdesignicons.com/icon/forum
https://materialdesignicons.com/icon/account-group


fix: sampling buffer size

The buffer size was wrong previously.

Oh I see. It's for delta_timestamps.


Issue_3: min encoder

Reference Issues/PRs
issue reference: https://github.com/VishwaP98/lets-git-it-scikit-learn/issues/3
parent PR: https://github.com/VishwaP98/lets-git-it-scikit-learn/pull/1
What does this implement/fix? Explain your changes.
find the minimum value in each bin after KBinsDiscretizer allocates each entry to a specific bin.

@VishwaP98 @RylandWang @shrutimistry @vishwaapatel review please 😄

minor comment but otherwise looks good to me!


system::default_device() fails to respect BOOST_COMPUTE_DEFAULT_DEVICE_TYPE for non gpu devices

This is because the type of the device id is a bitmask, but the test used are equalities. This means that if the device type is cpu but it is also default, it's type will be CL_DEVICE_TYPE_DEFAULT|CL_DEVICE_TYPE_CPU != boost::compute::device::cpu.

---
Want to back this issue? **[Post a bounty on it!](https://www.bountysource.com/issues/26529919-system-default_device-fails-to-respect-boost_compute_default_device_type-for-non-gpu-devices?utm_campaign=plugin&utm_content=tracker%2F402515&utm_medium=issues&utm_source=github)** We accept bounties via [Bountysource](https://www.bountysource.com/?utm_campaign=plugin&utm_content=tracker%2F402515&utm_medium=issues&utm_source=github).

What do you mean by that? You cannot set CPU as default device? Because for me export BOOST_COMPUTE_DEFAULT_DEVICE_TYPE=CPU works.
Can you point the file and line where device.type() is compared to boost::compute::device::cpu / gpu / accelerator instead of &?

Did you mean this include/boost/compute/system.hpp#L229?

It may work for you if your CPU device is not the default one. I don't know how to mark system-wide my devices as defaults. Anway, I can find these occurrencies:
include/boost/compute/algorithm/count_if.hpp:41:    if(device.type() & device::cpu){
include/boost/compute/algorithm/reduce.hpp:175:    if(device.type() & device::cpu){
include/boost/compute/algorithm/detail/scan.hpp:33:    if(device.type() & device::cpu){
include/boost/compute/algorithm/detail/find_extrema.hpp:40:    if(count < 64 || (device.type() & device::cpu)){
include/boost/compute/system.hpp:229:                    if (!(device.type() & device::gpu))
include/boost/compute/system.hpp:233:                    if (!(device.type() & device::cpu))
include/boost/compute/system.hpp:250:            if(device.type() & device::gpu){
include/boost/compute/system.hpp:259:            if(device.type() & device::cpu){
test/test_command_queue.cpp:166:       device.type() == boost::compute::device::gpu){
example/list_devices.cpp:31:            if(device.type() & compute::device::gpu)
example/list_devices.cpp:33:            else if(device.type() & compute::device::cpu)
example/list_devices.cpp:35:            else if(device.type() & compute::device::accelerator)

I suggest you clear CL_DEVICE_TYPE_DEFAULT inside device::type().

Updated comment, a few times, see previous.

Aaaaa, OK, now I get it.

I suggest you clear CL_DEVICE_TYPE_DEFAULT inside device::type() here > https://github.com/boostorg/compute/blob/master/include/boost/compute/device.hpp#L158

I think there's not need for that. We just need to change if (device.type() != device::gpu) to  if (!(device.type() & device::gpu)) (and so on), like you did:
include/boost/compute/system.hpp:229:                    if (!(device.type() & device::gpu))
include/boost/compute/system.hpp:233:                    if (!(device.type() & device::cpu))
include/boost/compute/system.hpp:250:            if(device.type() & device::gpu){
include/boost/compute/system.hpp:259:            if(device.type() & device::cpu){

You can make pull request with these changes (in system.hpp and you should also change device.type() == boost::compute::device::gpu to device.type() & boost::compute::device::gpu in test/test_command_queue.cpp:166).

This can be closed, see https://github.com/boostorg/compute/pull/508.


Fix MetricDescriptor names for Stackdriver Stats Exporter

All MetricDescriptor exported by Stackdriver Stats Exporter needs to be under the name domain: "custom.googleapis.com/opencensus".

Fixed in https://github.com/census-instrumentation/opencensus-java/pull/827


Added the new sponsorship brochure

Deleting and Adding the updated pdf

@all-contributors add @ahamedbasha-n for maintenance


fix: node17 returns ipv6 addresses, which fastify doesn't like

Coverage increased (+4.3%) to 81.042% when pulling 45d00e4f66561691cec5d985304047082b75e43d on debug-node-17-ssrf into a585a91d1010309a633ce622caa348b422156dc5 on main.


feat: Support sync or async function for custom transformers

This avoids forcing clients to pass async function for custom transformers.
This is not a breaking change since await works with sync and async functions.

This should be live in upcoming release. It may take some time as I can't create a release only for this.
Thanks for contribution.

The changes are live in v2.5.4.
Thanks for the contribution.


inconsistent implementation for saved .pth model

Hi,
Thanks for sharing such a awesome work.
As current implementation did not using model.module anymore.
Using model.load_state_dict(state_dict) instead of model.module.load_state_dict(state_dict)
works for all trained weights provided except HR18-300W.pth which still saved under model.module.
For now I just modify the keys as below and it works correctly.
new_state_dict = OrderedDict()
for i, key in enumerate(state_dict):
    new_state_dict[key.replace('module.', '')] = state_dict[key]
model.load_state_dict(new_state_dict)

@JMingKuo, I modify the keys in the test.py as your suggestion. But there is still an error. Is there something wrong when I modify the code. I have used your code instead of the code in test.py as follow.
state_dict = torch.load(args.model_file)     if 'state_dict' in state_dict.keys():         state_dict = state_dict['state_dict']         model.load_state_dict(state_dict)     else:         model.module.load_state_dict(state_dict)

@briantse100, you only have to modify the keys while using 300W model and always use model.load_state_dict for loading weights.

@JMingKuo  retrained the model with model.load_state_dict or just use the code you mentioned above in testing


data and ml module mising ?

from data import BodyPart
from ml import Movenet
where are those two modules ?

You need to download example folder
url:https://github.com/tensorflow/examples/tree/master/lite/examples/pose_estimation/raspberry_pi

You need to download example folder url:https://github.com/tensorflow/examples/tree/master/lite/examples/pose_estimation/raspberry_pi

But i can not find the ModelType that i can't rebuild this project ?How i can do that solve this problem


/threads breaking

For some users, the /threads command returns interaction failed when trying to list all threads. I think this is due to embed field content being over 2k but it might be something else.
Gotta investigator alligator

fixed


numba.typed.typeddict.Dict.get returns the default even though the key is present

With some specific key dtypes, Dict.get returns the default value even when the key is present. This has been tested with numba 0.55.1
To reproduce:
import numba

numba_dict = numba.typed.typeddict.Dict.empty(
    key_type=numba.types.Tuple([numba.types.uint32, numba.types.uint32]),
    value_type=numba.types.int64)

numba_dict[(1,1)] = 12345
assert numba_dict.get((1,1), 1) == numba_dict[(1,1)]

The error depends on the size of the ints in the key, not on the unsigned aspect. It disappears with e.g. numba.types.Tuple([numba.types.uint32, numba.types.uint64])

Hi @MarcMassar, thanks for the report. I can confirm this is a bug in Numba.
import numba
from numba.core.types import Tuple, int64, uint32
from numba.typed.typeddict import Dict

d = Dict.empty(
    key_type=Tuple([uint32, uint32]),
    value_type=int64)

d[(1,1)] = 12345
print(d[(1, 1)])  # print "12345"
print(d.get((1, 1)))  # print None

I guess the issue is because dict.get is using the non-casted key as the second argument to _dict_lookup. Whereas operator.getitem uses the casted one.
https://github.com/numba/numba/blob/2e825b000e609e090005f8fb3d567999f1f1940c/numba/typed/dictobject.py#L731-L741
https://github.com/numba/numba/blob/2e825b000e609e090005f8fb3d567999f1f1940c/numba/typed/dictobject.py#L749-L758
If I am correct, the fix is just a matter of replacing key by castedkey on line 741.

It's probably a casting issue. The weird thing is that this issue disappear it the key type is Tuple(in32, int64). But your suggested fix is almost surely going to work, so it might not be worth it to investigate further.

Would you like to give it a try and send a patch to Numba containing a fix?

On running the above example with the following diff,
diff --git a/numba/typed/dictobject.py b/numba/typed/dictobject.py
index 74c6ab02c..ec334eb1b 100644
--- a/numba/typed/dictobject.py
+++ b/numba/typed/dictobject.py
@@ -738,7 +738,7 @@ def impl_get(dct, key, default=None):

     def impl(dct, key, default=None):
         castedkey = _cast(key, keyty)
-        ix, val = _dict_lookup(dct, key, hash(castedkey))
+        ix, val = _dict_lookup(dct, castedkey, hash(castedkey))
         if ix > DKIX.EMPTY:
             return val
         return default

I get the following warning,
/Users/czgdp1807/numba_project/numba/numba/typed/typeddict.py:33: NumbaTypeSafetyWarning: unsafe cast from UniTuple(int64 x 2) to UniTuple(uint32 x 2). Precision may be lost.
  d[key] = value

Are we okay with the above? If so, I can go ahead and make a PR to close this issue.

@guilhermeleobas Thanks for debugging, your assessment in https://github.com/numba/numba/issues/7908#issuecomment-1068327361 seems to highlight the likely cause.
@czgdp1807 RE the warning:
NumbaTypeSafetyWarning: unsafe cast from UniTuple(int64 x 2) to UniTuple(uint32 x 2). Precision may be lost.

This is because the dictionary is declared as taking uint32 but Numba will infer the type of a Python int as int64, as a result the type of the requested key UniTuple(int64 x 2) has to be cast to match the types of the keys as declared in the dictionary. This is expected.
Patches to fix and test as suggested are welcome. Many thanks!

Great. I will send a fix with a regression test tomorrow.


Introduce static analysis

Was #9035, this goes to master, see comments in the other PR.

🐴

We should get this in the 4 branch


Poor blade formatting/support

Greetings,
I've been looking for days for a configuration that works with "blade.php" files, however even the most obscure solutions don't seem to work.
The repository description says that the config supports blade files, however html snippets don't work, php neither, neither tailwind.
Is this a general problem with blade files not being supported by the community, a config problem, or something wrong with my pc?

Greetings, these are all the information that you asked me for, all programs are in the most recent stable version.
All highligths, snippets, etc work on php only files, such as routes, models....
On blade files tho php, html, blade directives and tailwing classes don't
This is a screenshot of lazyvim mason window, is it correct?
https://imgur.com/gallery/vxKeh5T
> php --version
PHP 8.2.8 (cli) (built: Jul 16 2023 11:01:56) (NTS)
Copyright (c) The PHP Group
Zend Engine v4.2.8, Copyright (c) Zend Technologies
    with Zend OPcache v8.2.8, Copyright (c), by Zend Technologies
> nvim --version
NVIM v0.9.1
Build type: Release
LuaJIT 2.1.0-beta3

   system vimrc file: "$VIM/sysinit.vim"
  fall-back for $VIM: "/__w/neovim/neovim/build/nvim.AppDir/usr/share/nvim"

Run :checkhealth for more info
> php artisan --version
Laravel Framework 10.17.1

Well that's interesting. Can you also run the :checkhealth command?
Did you copy some of my settings or are you using my config as a base?

I installed the repository settings alone, i did not change anything.
Checkhealth log
https://pastebin.com/0ELArMM0
lsp warn log
https://pastebin.com/4Ekw5vG7

Well from checkhealth it seems everything should work. The issue seems that the files cannot be written. I have to be honest and tell you that I don't have a concrete idea what the issue is.
Looking at the message:
[WARN][2023-08-04 15:37:40] ...lsp/handlers.lua:537	"Failed to apply changes to file:///home/oxio2/progamer/example-app/resources/views/welcome.blade.php"
My first (uneducated) guess would be file permissions, any chance that might be it?

that warn was indeed because of a permission issue, however after fixing it another issue occures
[START][2023-08-05 20:26:32] LSP logging initiated
[WARN][2023-08-05 20:26:32] ...lsp/handlers.lua:137	"The language server copilot triggers a registerCapability handler despite dynamicRegistration set to false. Report upstream, this warning is harmless"
[WARN][2023-08-05 20:26:33] ...lsp/handlers.lua:537	"Failed to apply changes to file:///home/oxio2/progamer/laravel/example-app/resources/views/welcome.blade.php"
[WARN][2023-08-05 20:26:33] ...lsp/handlers.lua:537	"textDocument/didOpen ignored. file:///home/oxio2/progamer/laravel/example-app/resources/views/welcome.blade.php has unsupported language ID blade."
[WARN][2023-08-05 20:26:33] ...lsp/handlers.lua:537	"file:///home/oxio2/progamer/laravel/example-app/vendor/fakerphp/faker/src/Faker/Provider/nl_BE/Text.php is over the maximum file size of 1000000 bytes."
[WARN][2023-08-05 20:29:21] .../lua/vim/lsp.lua:1637	"buf_attach_client called on unloaded buffer (id: 13): "
[WARN][2023-08-05 20:29:21] .../lua/vim/lsp.lua:1637	"buf_attach_client called on unloaded buffer (id: 13): "
[WARN][2023-08-05 20:29:21] .../lua/vim/lsp.lua:1637	"buf_attach_client called on unloaded buffer (id: 13): "
[WARN][2023-08-05 20:29:21] .../lua/vim/lsp.lua:1637	"buf_attach_client called on unloaded buffer (id: 13): "
[WARN][2023-08-05 20:29:21] .../lua/vim/lsp.lua:1637	"buf_attach_client called on unloaded buffer (id: 13): "
[WARN][2023-08-05 20:29:21] .../lua/vim/lsp.lua:1637	"buf_attach_client called on unloaded buffer (id: 13): "
[WARN][2023-08-05 20:29:21] .../lua/vim/lsp.lua:1637	"buf_attach_client called on unloaded buffer (id: 13): "
[WARN][2023-08-05 20:29:21] .../lua/vim/lsp.lua:1637	"buf_attach_client called on unloaded buffer (id: 13): "
[START][2023-08-05 20:30:55] LSP logging initiated
[WARN][2023-08-05 20:30:55] ...lsp/handlers.lua:137	"The language server copilot triggers a registerCapability handler despite dynamicRegistration set to false. Report upstream, this warning is harmless"
[START][2023-08-05 20:31:12] LSP logging initiated
[WARN][2023-08-05 20:31:12] ...lsp/handlers.lua:137	"The language server copilot triggers a registerCapability handler despite dynamicRegistration set to false. Report upstream, this warning is harmless"
[WARN][2023-08-05 20:31:12] ...lsp/handlers.lua:537	"textDocument/didOpen ignored. file:///home/oxio2/progamer/laravel/example-app/resources/views/welcome.blade.php has unsupported language ID blade."
[WARN][2023-08-05 20:31:12] ...lsp/handlers.lua:537	"file:///home/oxio2/progamer/laravel/example-app/vendor/fakerphp/faker/src/Faker/Provider/nl_BE/Text.php is over the maximum file size of 1000000 bytes."
[WARN][2023-08-05 20:31:15] ...lsp/handlers.lua:537	"Failed to apply changes to file:///home/oxio2/progamer/laravel/example-app/resources/views/welcome.blade.php"
[WARN][2023-08-05 20:31:15] ...lsp/handlers.lua:537	"Failed to apply changes to file:///home/oxio2/progamer/laravel/example-app/resources/views/welcome.blade.php"
[ERROR][2023-08-05 20:31:19] .../vim/lsp/rpc.lua:734	"rpc"	"node"	"stderr"	"[ERROR] [auth] [2023-08-05T18:31:19.277Z] Failed to send notification result to GitHub: 403 \n"
[WARN][2023-08-05 20:31:20] ...lsp/handlers.lua:537	"Failed to apply changes to file:///home/oxio2/progamer/laravel/example-app/resources/views/welcome.blade.php"
[WARN][2023-08-05 20:31:20] ...lsp/handlers.lua:537	"Failed to apply changes to file:///home/oxio2/progamer/laravel/example-app/resources/views/welcome.blade.php"
[WARN][2023-08-05 20:31:21] ...lsp/handlers.lua:537	"Failed to apply changes to file:///home/oxio2/progamer/laravel/example-app/resources/views/welcome.blade.php"
[WARN][2023-08-05 20:31:22] ...lsp/handlers.lua:537	"Failed to apply changes to file:///home/oxio2/progamer/laravel/example-app/resources/views/welcome.blade.php"
[WARN][2023-08-05 20:31:29] .../lua/vim/lsp.lua:1637	"buf_attach_client called on unloaded buffer (id: 14): "
[WARN][2023-08-05 20:31:29] .../lua/vim/lsp.lua:1637	"buf_attach_client called on unloaded buffer (id: 14): "
[WARN][2023-08-05 20:31:29] .../lua/vim/lsp.lua:1637	"buf_attach_client called on unloaded buffer (id: 14): "
[WARN][2023-08-05 20:31:29] .../lua/vim/lsp.lua:1637	"buf_attach_client called on unloaded buffer (id: 14): "
[WARN][2023-08-05 20:31:29] .../lua/vim/lsp.lua:1637	"buf_attach_client called on unloaded buffer (id: 14): "
[START][2023-08-05 20:33:06] LSP logging initiated
[WARN][2023-08-05 20:33:06] ...lsp/handlers.lua:137	"The language server copilot triggers a registerCapability handler despite dynamicRegistration set to false. Report upstream, this warning is harmless"
[WARN][2023-08-05 20:33:06] ...lsp/handlers.lua:537	"textDocument/didOpen ignored. file:///home/oxio2/progamer/laravel/example-app/resources/views/welcome.blade.php has unsupported language ID blade."
[WARN][2023-08-05 20:33:06] ...lsp/handlers.lua:537	"file:///home/oxio2/progamer/laravel/example-app/vendor/fakerphp/faker/src/Faker/Provider/nl_BE/Text.php is over the maximum file size of 1000000 bytes."
[START][2023-08-05 20:33:38] LSP logging initiated
[WARN][2023-08-05 20:33:38] ...lsp/handlers.lua:137	"The language server copilot triggers a registerCapability handler despite dynamicRegistration set to false. Report upstream, this warning is harmless"
[WARN][2023-08-05 20:33:39] ...lsp/handlers.lua:537	"textDocument/didOpen ignored. file:///home/oxio2/progamer/laravel/example-app/resources/views/welcome.blade.php has unsupported language ID blade."
[WARN][2023-08-05 20:33:39] ...lsp/handlers.lua:537	"file:///home/oxio2/progamer/laravel/example-app/vendor/fakerphp/faker/src/Faker/Provider/nl_BE/Text.php is over the maximum file size of 1000000 bytes."
[WARN][2023-08-05 20:34:31] .../lua/vim/lsp.lua:1637	"buf_attach_client called on unloaded buffer (id: 12): "
[WARN][2023-08-05 20:34:31] .../lua/vim/lsp.lua:1637	"buf_attach_client called on unloaded buffer (id: 12): "
[WARN][2023-08-05 20:34:31] .../lua/vim/lsp.lua:1637	"buf_attach_client called on unloaded buffer (id: 12): "
[START][2023-08-05 20:35:17] LSP logging initiated
[WARN][2023-08-05 20:35:17] ...lsp/handlers.lua:137	"The language server copilot triggers a registerCapability handler despite dynamicRegistration set to false. Report upstream, this warning is harmless"
[WARN][2023-08-05 20:35:18] ...lsp/handlers.lua:537	"textDocument/didOpen ignored. file:///home/oxio2/progamer/laravel/example-app/resources/views/welcome.blade.php has unsupported language ID blade."
[WARN][2023-08-05 20:35:18] ...lsp/handlers.lua:537	"file:///home/oxio2/progamer/laravel/example-app/vendor/fakerphp/faker/src/Faker/Provider/nl_BE/Text.php is over the maximum file size of 1000000 bytes."

The important warn seems to be
[WARN][2023-08-05 20:35:18] ...lsp/handlers.lua:537	"textDocument/didOpen ignored. file:///home/oxio2/progamer/laravel/example-app/resources/views/welcome.blade.php has unsupported language ID blade."
there seem to be missing a plugin that takes care of blade identified files?

Hmmm I do know that by default, blade is not supported. But: I do have included a plugin that should fix that, see here.
When you execute :echo &filetype, do you get blade as the output?

the vim-blade plugin is installed and the :echo $filetype returns blade as the output
https://imgur.com/a/A82d2Ax

Well that's really weird then. As the LSP plugin I/LazyVim use (null-ls), which this problem seems to stem from, is archived in four days and I couldn't find any lead by googling the error message, I'll have to fold here.
I think I will wait for what new LSP plugin LazyVim adopts and then transfer the config to that. I know that that surely is not a satisfying answer for you, but I cannot replicate the problem locally and thus have no chance of efficiently debugging this. At the moment I am strapped for time, so if i come back around to it, I'll try to debug further - but that timeframe is probably a few months in the future and at that point I expect null-ls to be already replaced.
Thanks for bringing the problem to my attention and your cooperation in trying to debug! If you find the issue yourself, I'd love to hear the solution :)

Thank you very much for all the help, i will stay updated on the issue :)

@oxio2 try with the new version now, null-ls is replaced by a fork called none-ls. Check this commit for what to do to migrate.
Maybe it works now!

Another bump, @oxio2 ! Formatting is now running via conform, good chance it all works now! Check out my migration branch. I'll close this when I merge the branch.

Formatting now runs over conform.nvim, closing this.


Adds missing unit tests, end to end testing of the daily/monthly CLI and some code cleanups

@peterdesmet to support the 'all' option, one can use the 0 option (to keep it an integer)
❯ vph5_to_vpts --help
Usage: vph5_to_vpts [OPTIONS]

  Convert and aggregate h5 vp files to daily/monthly vpts files on s3 bucket

  Check the latest modified h5 files on the s3 bucket using an s3 inventory,
  convert all ODIM hdf5 profiles files for the days with modified files to the
  vpts-csv standard and upload the vpts-csv daily/monthly files to s3.

Options:
  --modified-days-ago INTEGER  All bucket files with a modified date between
                               now and N modified_days_ago will be taken into
                               account for the recreation of daily/monthly
                               files. If 0,all nucket files will be taken into
                               account for the recreation.
  --aws-profile TEXT           Optionally, define the AWS profile used to run
                               the command for interaction with the AWS s3
                               bucket.
  --help                       Show this message and exit.

With This PR, the targeted set of functionalities is provided. I marked as draft as I do have to fix an issue with the sphinx documentation building. I'll do that asap.

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

45 of 45 (100.0%)  changed or added relevant lines in 5 files are covered.
7 unchanged lines in 1 file lost coverage.
Overall coverage increased (+36.6%) to 87.888%

Files with Coverage Reduction
New Missed Lines
%

src/vptstools/vpts_csv.py
7
76.99%

Totals

Change from base Build<PHONE_NUMBER>:
36.6%

Covered Lines:
385

Relevant Lines:
405

💛  - Coveralls

Sounds good, nice coverage!
please correct typos to:

All bucket files with a modified date between now and N modified-days-ago will be taken into account for the recreation of daily/monthly files. If 0, all bucket files will be taken into account for the recreation.


Hook is added, we need to put in the deploydata(outputs) for removal

Added a method SetDeployData to support save of hookid as deploy data for removal during a destroy.
The cmd code has the tests passing.
I tested with app/machines they run ok. We need some changes to be done in the api. Will open issues on that.

@thomasalrin @rajthilakmca @morpheyesh Guys we need to have everybody test with new megamd on monday.  It will be difficult to test all.


Button not showing in Task view of Asana when language is set to Japanese

OS version: macOS: 12.1
Browser version: Google Chrome
Version: 105.0.5195.125 (Official Build) (arm64)
Extension version: 2.0.17

Relevant integration (if any):
Asana
🐛 Describe the bug
When language is set to Japanese, the button doesnt show in Task

Expected behaviour
Button should show, it used to before.
Steps to reproduce
Steps to reproduce the behaviour:

Go to Asana
Change language to Japanese
Button will not show in Task

Other details or context
Case
Case

Hello,
I don't think it's because of the language. Because I have the same problem in French, English,... since more than one month.
And the button on the left, is not well linked anymore to the projects.

Case ref - spanish user

I can see the toggl button in Asana in list and tasks view.. but disappeared in Calenda view.


TSP: Loop an Input TS file

I'm not sure if I missed it in the documents, but i've tried looking everywhere and could not find.
Is there any way of using TSP.exe to Loop an Input TS file for output Streaming?

With -I file --infinitefilename the file is played again and again. With option --repeatcount the file is played a given number of times.
If the output device naturally regulates the output speed (a modulator for instance), the command is simply: tsp -I file --infinitefilename-O dektec ...
If the output does not regulate (ip or hls for instance), then you need in add the plugin regulate to ensure that the data are not sent faster than the playout speed.
See the TSDuck user's guide sections 5.2.3 and 5.2.4.

Thanks, i'll give it a try!
PS: i was looking for the word "loop" in the guide and couldn't find, but i'll check those sections!