Webpacking npm module and using its files

I'm a little confused on how webpack is grabbing npm modules and including them.
For example:
loaders: commonLoaders.concat([
        { test: /\.css$/, loader: "style!css" },
        { test: /\.scss$/,
          loader: ExtractTextPlugin.extract("css?sourceMap!sass?sourceMap&outputStyle=expanded" +
            "&includePaths[]=" + (path.resolve(__dirname, "./bower_components")) +
            "&includePaths[]=" + (path.resolve(__dirname, "./node_modules")))
        }
      ])

i Know this includes our node_modules path, but what if im using a library, and I want to link its css and js files to my basehtml, then I would go to helmconfig.js right? Then add the link href to the links. But would it be something like this?
{ "rel": "stylesheet", "href": "../../node_modules/alloyeditor/dist/alloy-editor/assets/alloy-editor-ocean-min.css"}

and the js file would I just include it  tags in the basehtml? Or is everything in the npm modules already applied?
I should just require("") it right?

you should be able to just require('alloy-editor') where you need it in particular components - if the path doesn't resolve you can potentially add a alias to the resolve section of webpack config.
For the css, right way is still being decided.. If you are using current master, you should be able to include in main.scss, but you'll need to resolve the path relative to node_modules. For example
@include "alloyeditor/dist/alloy-editor/assets/alloy-editor-ocean-min.css";

otherwise you can add part/all of that path to the includePaths in webpack config, e.g.:
 { test: /\.scss$/,
    loader: ExtractTextPlugin.extract('css?module&localIdentName=[local]__[hash:base64:5]' +
      '&sourceMap!sass?sourceMap&outputStyle=expanded' +
      '&includePaths[]=' + (path.resolve(__dirname, './node_modules')) +
      '&includePaths[]=' + (path.resolve(__dirname, './node_modules/alloyeditor/dist/alloy-editor/assets')))
  }

will allow you to just @include "alloy-editor-ocean-min.css"
This will slightly change after https://github.com/choonkending/react-webpack-node/pull/35, but it's probably worth thinking about how we want to handle external style deps.
@choonkending thoughts?

@psimyn Good analysis.
I think having your first @include "alloyeditor/dist/alloy-editor/assets/alloy-editor-ocean-min.css"; is neater, especially if you are debugging and looking through the scss/css, it won't be immediately apparent that it belongs from a node module if we do it @include "alloy-editor-ocean-min.css".

I'm not using the current master probably the version before react-hot-loader was added. Well in this case if I wanted to use AlloyEditor,it would be import * from 'alloy-editor' (ES6) in the component I'm using it at right? Also can you explain the alias for the for the resolve part of the webpack.config file a bit more. Thanks btw I really appreciate it.

@kkotwal94 Yes you can import it that way.
As for the resolve part of the webpack config, you can read more here.
The resident webpack expert here is @psimyn. But I'll attempt an explanation.
 resolve: {
      extensions: ['', '.react.js', '.js', '.jsx', '.scss'],
      modulesDirectories: [
        "app", "node_modules"
      ]
    },

This tells webpack to search through those directories (besides the current directory) when it encounters a file/module with those extensions.
The resident webpack expert here is @psimyn, was that correct? Gimme a :+1:

resolve: {
      extensions: ['', '.react.js', '.js', '.jsx', '.scss', '.css'],
      modulesDirectories: [
        "app", "node_modules"
      ],
      alias: {
      alloyeditor : '../../node_modules/alloyeditor/dist/alloy-editor/alloy-editor-all.js'
      },
    },

After looking at the documentation and trying this, hitting npm runscript start or watch, both tell me that it still can't resolve the module.

If your alias is alloyeditor, did you import alloyeditor or alloy-editor.
Otherwise check the path for alloyeditor, whether it really is the correct
directory. It'll be helpful if you paste your webpack config + what error
is thrown here if the above suggestions don't work out :)
On Tue, 28 Jul 2015 01:57 kkotwal94<EMAIL_ADDRESS>wrote:

resolve: {
extensions: ['', '.react.js', '.js', '.jsx', '.scss', '.css'],
modulesDirectories: [
"app", "node_modules"
],
alias: {
alloyeditor : '../../node_modules/alloyeditor/dist/alloy-editor/alloy-editor-all.js'
},
},
After looking at the documentation and trying this, hitting npm runscript
start or watch, both tell me that it still can't resolve the module.
—
Reply to this email directly or view it on GitHub
https://github.com/choonkending/react-webpack-node/issues/43#issuecomment-125253623
.

var path = require("path");
var ExtractTextPlugin = require("extract-text-webpack-plugin");
var webpack = require("webpack");

var assetsPath = path.join(__dirname, "public", "assets");
var publicPath = "assets/";

var commonLoaders = [
  {
    /*
     * TC39 categorises proposals for babel in 4 stages
     * Read more http://babeljs.io/docs/usage/experimental/
     */
    test: /\.jsx$/, loader: "babel-loader?stage=0"
  },
  {
    test: /\.js$/,
    loader: "babel-loader?stage=0",
    include: path.join(__dirname, "app")
  },
  { test: /\.png$/, loader: "url-loader" },
  { test: /\.jpg$/, loader: "file-loader" },
  { test: /\.html$/, loader: "html-loader" }
];

module.exports = [
  {
    // The configuration for the client
    name: "browser",
    /* The entry point of the bundle
     * Entry points for multi page app could be more complex
     * A good example of entry points would be:
     * entry: {
     *   pageA: "./pageA",
     *   pageB: "./pageB",
     *   pageC: "./pageC",
     *   adminPageA: "./adminPageA",
     *   adminPageB: "./adminPageB",
     *   adminPageC: "./adminPageC"
     * }
     *
     * We can then proceed to optimize what are the common chunks
     * plugins: [
     *  new CommonsChunkPlugin("admin-commons.js", ["adminPageA", "adminPageB"]),
     *  new CommonsChunkPlugin("common.js", ["pageA", "pageB", "admin-commons.js"], 2),
     *  new CommonsChunkPlugin("c-commons.js", ["pageC", "adminPageC"]);
     * ]
     */
    context: path.join(__dirname, "app"),
    entry: {
      app: "./app"
    },
    output: {
      // The output directory as absolute path
      path: assetsPath,
      // The filename of the entry chunk as relative path inside the output.path directory
      filename: "[name].js",
      // The output path from the view of the Javascript
      publicPath: publicPath

    },
    module: {
      preLoaders: [{
        test: /\.js$|.jsx$/,
        exclude: /node_modules/,
        loaders: ["eslint"]
      }],
      loaders: commonLoaders.concat([
        { test: /\.css$/, loader: "style!css" },
        { test: /\.scss$/,
          loader: ExtractTextPlugin.extract("css?sourceMap!sass?sourceMap&outputStyle=expanded" +
            "&includePaths[]=" + (path.resolve(__dirname, "./bower_components")) +
            "&includePaths[]=" + (path.resolve(__dirname, "./node_modules")) +
            '&includePaths[]=' + (path.resolve(__dirname, './node_modules/alloyeditor/dist/alloy-editor/assets')))
        }
      ])
    },
    resolve: {
      extensions: ['', '.react.js', '.js', '.jsx', '.scss', '.css'],
      modulesDirectories: [
        "app", "node_modules"
      ],
      alias: {
      alloyeditor : '../../node_modules/alloyeditor/dist/alloy-editor/alloy-editor-no-react.js'
      }
    },
    plugins: [
        // extract inline css from modules into separate files
        new ExtractTextPlugin("styles/main.css")
    ]
  }, {
    // The configuration for the server-side rendering
    name: "server-side rendering",
    context: path.join(__dirname, "app"),
    entry: {
      app: "./app",
      header: "./elements/Header.react"
    },
    target: "node",
    output: {
      // The output directory as absolute path
      path: assetsPath,
      // The filename of the entry chunk as relative path inside the output.path directory
      filename: "[name].server.js",
      // The output path from the view of the Javascript
      publicPath: publicPath,
      libraryTarget: "commonjs2"
    },
    externals: /^[a-z\-0-9]+$/,
    module: {
      loaders: commonLoaders
    },
    resolve: {
      extensions: ['', '.react.js', '.js', '.jsx', '.scss'],
      modulesDirectories: [
        "app", "node_modules"
      ],
alias: {
      alloyeditor : '../../node_modules/alloyeditor/dist/alloy-editor/alloy-editor-no-react.js'
      }
    },
    plugins: [
      new webpack.NormalModuleReplacementPlugin(/\.(css|scss)$/, "node-noop")
    ]
  }
];

As for importing it, i tried 3 ways.
import * from alloyeditor;
import * as alloy from alloyeditor;
require("alloyeditor");

My file structure is here : https://github.com/kkotwal94/IsoReportProcessor
as for the error it is
ERROR in ./components/NewReport.js
Module not found: Error: Cannot resolve module 'alloy-editor' in /home/karan/Documents/IsoReportProcessor/app/components
 @ ./components/NewReport.js 33:19-42

when importing * as alloy from alloyeditor
and
Cannot find module 'alloyeditor'

when hitting npm start (running server.js) however webpack does not spit and issues if I change it during it is watching.
I also tried finding the path from the directory, and it still gives me the same issue.

@kkotwal94 No luck on my end.
Not sure about how alloyeditor is meant to be used. I tried npm installing the package, and I added a   "main": "dist/alloy-editor/alloy-editor-all-min.js", into the package.json for alloyeditor.
Then I could import * from alloyeditor, but I set it up as an entry point only for the browser so the server won't throw an error. (There were certain window checks in alloyeditor).
// Browser
    entry: {
      app: "./app",
      test: "./components/Test"
    },

I required that <script type="text/javascript" charset="utf-8" src="/assets/test.js"></script> in my base.html just to test it out. Not sure how it s meant to be used. Perhaps you could create an issue in alloyeditor and get some clarification.

gotchya, well I guess i'll be back with a solution. Perhaps maybe you know any wysiwyg that work with webpack and es6?

@kkotwal94 Good work!!

@kkotwal94 Will close unless you have more questions :)


Change how aws-lambda-ric module is resolved and spawned

Problem
The live lambda development functionality spawns the aws-lambda-ric module using npx command to run the aws-lambda-ric script. The npx command expects to find the aws-lambda-ric script in the node_modules/.bin/ folder. This doesn't work properly with PNPM as it doesn't install the aws-lambda-ric script in the expected location due to it not being a top level dependency but a dependency of @serverless-stack/cli.
Details
The following error is shown when running pnpm start and making a request that will call the lambda.
Debug session started. Listening for requests...
9fa9bc5b-7f98-4861-af22-0e7e00300cdb REQUEST dev-rest-api-my-stack-ApiLambdaGETB1714EF3-YVjrJ16SAUyF [src/lambda.handler] invoked by API GET /
2022-03-31T08:34:54.795Z    undefined   INFO    Executing '/Users/user/sst-pnpm/.sst/artifacts/dev-rest-api-my-stack-Api-Lambda_GET_-/src/lambda.handler' in function directory '/Users/user/sst-pnpm'
- /Users/user/.npm/_npx/53765/lib/node_modules/aws-lambda-ric/bin/index.jslient/index.jslient.jse-client.node'

Workaround
Adding the aws-lambda-ric dependency to the project's package.json will make the script available in node_modules/.bin/ where npx can find it.
Proposed fix
Find the aws-lambda-ric module using require.resolve() and spawn it using node instead of npx. This is the same way as cdk is spawned in PR https://github.com/serverless-stack/serverless-stack/pull/1582.
Move the aws-lambda-ric dependency from @serverless-stack/cli to @serverless-stack/core as this dependency is used from core and not cli.

Released in v0.69.6 and v1.0.0-beta.20


Use smarter trimming

**TimToady │ so...Geth replaces the final line to report that there's 1 more line...**

Fixed in 8bcea9e84f


Annotation objects comparison (dev)

Description
Resolves #5411
I've updated multiple python wrapping objects, all in the same manner—fixing a problematic type check. The logic for the check was backwards, so I just inverted the comparisons.
Type of change

[x] Bug fix
[ ] New feature
[ ] Documentation update
[ ] Other

How Has This Been Tested?
I've tested this by hand, and I've also added a new test to support the update.
Checklist:

[x] I have followed the style guidelines of this project.~~
[x] I have performed a self-review of my own code.~~
[ ] I have commented my code where applicable.
[x] I have updated the release notes.~~
[ ] I have made corresponding changes to the documentation.
[ ] I have added debugging support to my changes.
[x] I have added tests that prove my fix is effective or that my feature works.~~
[x] I have confirmed new and existing unit tests pass locally with my changes.~~
[x] I have added new baselines for any new tests to the repo.~~
[x] I have NOT made any changes to protocol or public interfaces in an RC branch.~~
[x] I have assigned reviewers (see VisIt's PR procedures for more information).~~

I wasn't entirely sure where the new test should go. Since it was so localized, I thought "unit" tests might be appropriate. Let me know if either of you think there's a better location for it.

Can we hold of on changes to any Py... files until #5750 is merged?

Can we hold of on changes to any Py... files until #5750 is merged?

Sure thing.


You posted AoC inputs >_>

From AoC about page:

If you're posting a code repository somewhere, please don't include parts of Advent of Code like the puzzle text or your inputs.

Pls don't post

Fixed, thanks for the heads-up 👍


Add tertiary navigation for AWS and Azure details

Per my discussion with @nlcwong , we want to use the PF4 navigation component as 3rd level navigation to the AWS and Azure details pages.
We're also removing "details" from the page title and just using "Amazon Web Services" and "Azure".
Fixes https://github.com/project-koku/koku-ui/issues/965

Codecov Report

Merging #977 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #977   +/-   ##
=======================================
  Coverage   76.04%   76.04%
=======================================
  Files         221      221
  Lines        4133     4133
  Branches      761      761
=======================================
  Hits         3143     3143
  Misses        889      889
  Partials      101      101

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8cf59e2...19cdb27. Read the comment docs.

Just need a clarification - when I am switching between AWS and Azure I get the same account names/services/etc.
Is that OK or it's something you'll address in the future due to limitations on the back-end?
Thanks.

Yes, this is expected. Azure is just a copy of AWS right now. I will update the APIs when they become available next sprint


Tolerate missing OS configuration

This PR resolves problem described in https://issues.redhat.com/browse/ECOPROJECT-587. And allows for OS configuration to be missing (which is the case before the device is registered).

LGTM


More control over dgram sending

I added 'callback' parameter to UDP socket.send to have full control over events emitted, including the case of successful dgram sending.
Also, I payed attention to Node's deprecation warning (https://nodejs.org/api/buffer.html#buffer_new_buffer_size) and fixed the cause.

Thanks for merging. Do you plan updating the package at npmjs.com?

Yes I do, sorry about the lag. Glad I waited tho :) Any other changes you
want?
On Tue, Jun 19, 2018 at 10:14 AM Serge Medvedev<EMAIL_ADDRESS>wrote:

Thanks for merging. Do you plan updating the package at npmjs.com?
—
You are receiving this because you modified the open/close state.
Reply to this email directly, view it on GitHub
https://github.com/perezd/riemann-nodejs-client/pull/27#issuecomment-398476287,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AABQdh_poEGtOaerEfJLgSabXWeZAYOGks5t-TGRgaJpZM4UtjJV
.

At the moment I don't see anything I'd like to add.
But I've got a question.
Changes I did are needed since I'm playing with "promisified" wrappers around current functionality.
How do you like an idea to make the library code itself promise-based (instead of event-based) in the future?

At the moment I don't see anything I'd like to add.
But I've got a question.
Changes I did are needed since I'm playing with "promisified" wrappers around current functionality.
How do you like an idea to make the library code itself promise-based (instead of event-based) in the future?

I like the idea of providing both, go ahead and add it.
On Tue, Jun 19, 2018 at 1:21 PM Serge Medvedev<EMAIL_ADDRESS>wrote:

At the moment I don't see anything I'd like to add.
But I've got a question.
Changes I did are needed since I'm playing with "promisified" wrappers
around current functionality.
How do you like an idea to make the library code itself promise-based
(instead of event-based) in the future?
—
You are receiving this because you modified the open/close state.
Reply to this email directly, view it on GitHub
https://github.com/perezd/riemann-nodejs-client/pull/27#issuecomment-398532324,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AABQdgg2zMPACC2c0tsvggTiCapS9-qtks5t-V1JgaJpZM4UtjJV
.


error with npm install

I tried to run npm install hfc. I think the problem has something to do with node-pre-gyp. I've tried updating node, npm, xcode. I'm running macOS
The debug log won't show me anything above line 8004, not sure why:
https://gist.github.com/isabellewei/a5632a3956353d5b2b0d1130c9b20a81

You're right, it does look like the problem is a node-pre-gyp failure. Unfortunately, as far as I can tell, that log doesn't contain any additional relevant information.

Is there any other information I could provide to try and solve this issue?

Maybe there is something weird with how node-pre-gyp is logging information. What is the console output of running the command?

Never mind, I see the problem. You're trying to install gRPC 1.0.0 on Node 7.10.0. That version of gRPC did not support that version of Node. You will either need to upgrade to a more recent version of gRPC or downgrade Node. Node 6 should be compatible.


Feedback from Vorner

Vorner wrote a really insightful post on trying out async/await with async-std, and talked about several things that didn't go well. This is a tracking issue to address all the feedback provided.
Also @vorner if you're reading along; thanks so much for the writeup! -- Posts like these are incredibly helpful, and allow us to learn where we need to improve.
Items

[ ] Low rates of connection on localhost (started on in #205)
[ ] Investigate why TcpListener sometimes stays open indefinitely
[ ] Investigate why connections are timing out
[x] Document how to enable the unstable feature (needed for future::timeout. (solved by #190 #202)
[x] futures_rs::select requires Unpin (solved by #187)
[ ] Pinning can be tricky (groundwork in #203)

Quotes

But when running it, with both server and client on localhost, sometimes the experiment never finished, even with low rates of new connection creation. This seemed odd.

Still, even with rates like 100 new connections per second, some of the connections were timing out.

Code Example
// expected
async fn connect(server: SocketAddr, content: Arc<[u8]>, mut results: Sender<Duration>) {
    let res = timeout(connect_inner(server, content), TIMEOUT).await.unwrap();
    res.send().await.unwrap();
}

// current
async fn connect(server: SocketAddr, content: Arc<[u8]>, mut results: Sender<Duration>) {
    let connect = connect_inner(server, content);
    pin_mut!(connect);
    let timeout = task::sleep(TIMEOUT);
    pin_mut!(timeout);
    match future::select(connect, timeout).await {
        Either::Left((Ok(duration), _)) => results
            .send(duration)
            .await
            .expect("Channel prematurely closed"),
        Either::Left((Err(e), _)) => error!("Connection failed: {}", e),
        Either::Right(_) => {
            warn!("Connection timed out");
            results
                .send(TIMEOUT)
                .await
                .expect("Channel prematurely closed");
        }
    }
}

Refs

https://github.com/vorner/tspam
https://vorner.github.io/2019/09/15/play-with-new-async.html

Hello. It's nice you liked it.
Anyway, let me clarify a bit:

I didn't complain about low rates on localhost. I set the rate at which I want it to run, I was merely pointing out that even if I set a low rate, the connections were timing out (or getting stuck). My point there was it probably isn't caused by overloading something (eg. packets getting lost).
I don't know anything about TcpListener being open indefinitely. Is it something you deduced from what I wrote?
The connections timing out, I suspect they time out on the client side. I believe I switched to tokio on the client, but had the server still running with the async-std code and it worked. But I'm not 100% sure, maybe I only thought I have been keeping the async-std server around.

What is the outstanding work we need to do on this issue? If there is none, can we close?

@stjepang Yeah, I think it's okay to close. The only part that could potentially still be an issue is:

The connections timing out, I suspect they time out on the client side.

But we haven't had any other reports, so it may indeed just have been the client side here.

@vorner thanks so much again for the article you wrote. Apologies I dropped off of this feedback issue, but the points you've raised have been incredibly useful to improve the flow of people discovering async-std for the first time!


Move most of Mixer from glog to the new log package.

What's left is pkg/adapterManager and pkg/runtime which are exposing the logging
interface to adapters. I'll handle this separately.

@geeknoid: Adding do-not-merge/release-note-label-needed because the release note process has not been followed.

One of the following labels is required "release-note", "release-note-action-required", or "release-note-none".
Please see: https://github.com/kubernetes/community/blob/master/contributors/devel/pull-requests.md#write-release-notes-if-needed.
Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

/lgtm

/approve


Missing multisign check

Problem:
The validate_owner function does not verify that the signers are unique thus making it allowed for the same signer to sign an instruction multiple time, what this means is that the whole purpose of multi-signing is rendered moot
Proposed solution:
Only count a single signer once within the function, handle repeated cases by either ignoring them or returning an error code

In addition to fixing for v3, we should add a notice to the v2 docs that multisig doesn't work


[Doc] Update Backup_and_restore.md

Signed-off-by: wangsimo0<EMAIL_ADDRESS>Why I'm doing:
What I'm doing:
Fixes #issue
What type of PR is this:

[ ] BugFix
[ ] Feature
[ ] Enhancement
[ ] Refactor
[ ] UT
[x] Doc
[ ] Tool

Does this PR entail a change in behavior?

[] Yes, this PR will result in a change in behavior.
[x] No, this PR will not result in a change in behavior.

If yes, please specify the type of change:

[ ] Interface/UI changes: syntax, type conversion, expression evaluation, display information
[ ] Parameter changes: default values, similar parameters but with different default values
[ ] Policy changes: use new policy to replace old one, functionality automatically enabled
[ ] Feature removed
[ ] Miscellaneous: upgrade & downgrade compatibility, etc.

Checklist:

[ ] I have added test cases for my bug fix or my new feature
[ ] This pr needs user documentation (for new or modified features or behaviors)

[ ] I have added documentation for my new feature or new function

Bugfix cherry-pick branch check:

[ ] I have checked the version labels which the pr will be auto-backported to the target branch

[x] 3.2
[ ] 3.1
[ ] 3.0
[ ] 2.5

@mergify rebase main

@mergify rebase main

Updates made in previous PR solved this issue. Closing the PR.


fix: ability to set provider after shutdown

This PR
Fix #552
Since API is a singleton, we must re-initialize all cleaned-up resources.

@Kavindu-Dodan I've update the PR title to be a bit more precise, IMO.


Fix null value for the message

Changes proposed:

on extractOptionsDependentKeys: typeof null === "object"

Tasks:

[x] Added test case(s): The default message is available!

@GreatWizard Thanks for adding this test case 👍


Tweak size

I applied some optimizations to reduce bundle size:

sideEffects: false to improve dead code elimination
removed default export in _u64
migrated _assert and _u64 module to wildcard imports to enable tree-shaking
added /*#__PURE__*/ annotation to all top-level invocations

sizes (with all dependencies, minified and gzipped):
blake2b from blake2b
Size:         3 kB      →   2.71 kB

blake2s from blake2s
Size:         2.75 kB   →   2.31 kB

blake3 from blake3
Size:         4.22 kB   →   3.19 kB

hmac from hmac
Size:         1.03 kB   →   891 B

hkdf from hkdf
Size:         1.25 kB   →   1.11 kB

pbkdf2 from pbkdf2
Size:         1.47 kB   →   1.33 kB

pbkdf2Async from pbkdf2
Size:         1.54 kB   →   1.41 kB

ripemd160 from ripemd160
Size:         2.15 kB   →   1.98 kB

scrypt from scrypt
Size:         4.32 kB   →   4.13 kB

scryptAsync from scrypt
Size:         4.39 kB   →   4.2 kB

sha256 from sha256
Size:         2.45 kB   →   2.18 kB

sha512 from sha512
Size:         4.09 kB   →   3.44 kB

sha1 from sha1
Size:         1.82 kB   →   1.65 kB

sha3_224 from sha3
Size:         2.06 kB   →   1.79 kB

sha3_256 from sha3
Size:         2.06 kB   →   1.79 kB

sha3_384 from sha3
Size:         2.06 kB   →   1.79 kB

sha3_512 from sha3
Size:         2.06 kB   →   1.79 kB

keccakP from sha3
Size:         2.06 kB   →   705 B

keccak_256 from sha3
Size:         2.06 kB   →   1.79 kB

keccak_384 from sha3
Size:         2.06 kB   →   1.79 kB

keccak_512 from sha3
Size:         2.06 kB   →   1.79 kB

cshake128 from sha3-addons
Size:         2.32 kB   →   2.04 kB

cshake256 from sha3-addons
Size:         2.32 kB   →   2.04 kB

kmac128 from sha3-addons
Size:         2.5 kB    →   2.2 kB

kmac256 from sha3-addons
Size:         2.5 kB    →   2.19 kB

k12 from sha3-addons
Size:         2.51 kB   →   2.24 kB

m14 from sha3-addons
Size:         2.51 kB   →   2.24 kB

argon2id from argon2
Size:         4.9 kB    →   4.6 kB

eskdf from eskdf
Size:         5.43 kB   →    5.28 kB

i used #62 to test changes

run big-endian check in every entry and mark it as sideEffect

why? does sideEffects: false in package.json help us in any way? i've thought only PURE annotations do.

sideEffects: false allows to webpack skip unused imports earlier and not traverse over all module tree
sideEffects: false decrease the bundle size for all entries ~100B-300B
it also breaks the big-endian check because webpack will remove it
I moved the check to a separate file and marked it as a side effect so webpack would enable that greedy tree-shaking and would keep the big-endian check always in bundle

made a little demo with stackblitz to test that behavior

@paulmillr Hello,
Are you interested in those changes? I wanna create some PR for the curves package.

@jeetiss thanks for the pull request. It's good. Yes, I am interested.
I am concerned with moving-out big-endian check into the separate file.
It's always used. Can't we just keep it in utils? I assume sideEffects: false remove it, but what else do they remove?

Please don't make curves PR until we merge the current one, don't want you to do work that won't be merged.

I think it should be better to split this PR into a couple:

one with pure notations
second with migration from default exports to wildcard imports
and third with sideEffects: false

The first two are not so controversial and we can discuss options for sideEffects after


[SPARK-28541][WEBUI] Document Storage page

What changes were proposed in this pull request?
add an example for storage tab
How was this patch tested?
locally building

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution-unified/14140/
Test PASSed.

Test build #109076 has started for PR 25445 at commit bdc796c.

Test build #109076 has finished for PR 25445 at commit bdc796c.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/109076/
Test PASSed.

Test build #109311 has started for PR 25445 at commit d4d1ca4.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution-unified/14374/
Test PASSed.

Test build #109311 has finished for PR 25445 at commit d4d1ca4.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/109311/
Test PASSed.

Test build #109314 has started for PR 25445 at commit c34cc46.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution-unified/14378/
Test PASSed.

Test build #109314 has finished for PR 25445 at commit c34cc46.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/109314/
Test PASSed.

Test build #109318 has started for PR 25445 at commit 9d3447d.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution-unified/14381/
Test PASSed.

Test build #109318 has finished for PR 25445 at commit 9d3447d.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/109318/
Test PASSed.

@srowen Thanks for reviewing! I had move the header outside in https://github.com/apache/spark/pull/25445/commits/d4d1ca43bcb6f49301d82a68d51e3844a71a8576
There were two screenshots of the built docs, and I just deleted the old one with version number in it.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution-unified/14443/
Test PASSed.

Test build #109381 has started for PR 25445 at commit 7d99ad2.

Test build #109381 has finished for PR 25445 at commit 7d99ad2.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/109381/
Test PASSed.

Merged to master


When I run demo, it says No module named crop_and_resize. I thought it is from lib/layer_utils/roi_align/_ext/crop_and_resize/init.py

{GPU_ID} ./tools/demo.py
Traceback (most recent call last):
File "./tools/demo.py", line 29, in
from nets.vgg16 import vgg16
File "/home/hyunbae/pytorch-faster-rcnn/tools/../lib/nets/vgg16.py", line 10, in
from nets.network import Network
File "/home/hyunbae/pytorch-faster-rcnn/tools/../lib/nets/network.py", line 28, in
from layer_utils.roi_align.crop_and_resize import CropAndResizeFunction
File "/home/hyunbae/pytorch-faster-rcnn/tools/../lib/layer_utils/roi_align/crop_and_resize.py", line 7, in
from ._ext import crop_and_resize as _backend
File "/home/hyunbae/pytorch-faster-rcnn/tools/../lib/layer_utils/roi_align/_ext/crop_and_resize/init.py", line 3, in
from ._crop_and_resize import lib as _lib, ffi as _ffi
ImportError: No module named _crop_and_resize

Did you creatly compile the roi_align?

thanks I solved it with recompliing those. However, I found another error
IOError: [Errno 2] No such file or directory: 'output/res101/voc_2007_trainval+voc_2012_trainval/default/res101_faster_rcnn_iter_110000.pth'
I linked 'default', under the 'output' folder, file to the pretrained model from Google drive and another file under 'data' folder to VOC2007devkit that I downloaded. I think I put the files in the right places but still meeting some errors I hope to know how to solve this.


Debug non-received/handled data

Is there a way to simulate an IDE client sent data to Wakapi ?
I've been trying to run Wakapi with podman and I don't seem to pinpoint where the issue lie.
Any way to debug from Wakapi and test with an direct API request ?
Thanks a lot.

Hu @deurk! For debugging, you might want to check out sample_data.py to generate and insert fake heartbeats as well as this Postman collection as an example of how to manually make heartbeat requests.

Thanks a lot for your prompt answer, I will try this now and report :)

I am correctly able to send heartbeats from Postman using your collection (very convenient, thank you) and I can see it arrive on the pod instance (as a POST request). However, is a {"responses":[[null,201]]} response normal ?
The Wakapi instance does not show the example data (go project) when refreshed, even though it now displays empty graphs.

Nevermind, testing with today's timestamp works way better. So it seems issues does not lie with my instance, but rather with the VSCode plugin (although it works fine with Wakatime and your dev instance).
Any pointer for me?

I see an occasional message
2021-04-25T13:06:47.030668182Z [ERROR] error while writing json response: json: unsupported value: +Inf

However, is a {"responses":[[null,201]]} response normal ?

Yes, although it looks kinda weird, this is actually what wakatime-cli expects.

Any pointer for me?

Can you please tell me, what Wakapi version are you using (and when compiled from source, what's your latest commit hash) and with what database? Could you take a peek into your database and see what (if any) heartbeat was actually inserted? This would help me debug the issue.

Sure thing, I used the latest version of the docker image n1try/wakapi (1.26.5).
To be clearer: Postman heartbeats work as intended, they do appear in Wakapi. VSCode extension does not seem to add any heartbeats, although just by changing its api_url and api_key to your dev public Wakapi it works flawlessly.
I do not know when the message appears exactly, I'll try to monitor to correlate with any action I might have but so far have not found its origin.

You can also directly fiddle with the instance for tests if you want, I opened registration: https://wakapi.owndesign.net/

That is weird. Can you check what's in your database? I assume you're using the SQLite, which you can best view with a tool like this.

I'll try to monitor to correlate with any action I might have but so far have not found its origin.

Keep me posted and maybe open another bug ticket here once you were able to figure out how to reproduce it.
Btw., if you had any kinds of issues running Wakapi with Podman, feel free to share your thoughts here, maybe someone finds it helpful.

Only the manually generated entries appear in there

Alright. The VSCode plugin can't be the problem as heartbeats are successfully sent to Wakapi.dev or WakaTime, right? Your instance itself can't be the problem as well (Firewall, etc.), as you're able to send heartbeats from Postman. What's left in between is only the wakatime.cfg config pointing to your instance, but I assume it is properly configured as well?
Maybe ~/.wakatime.log (you'll need to figure out what's the Windows equivalent of that file) has something useful to tell?

I configured your instance on my machine for testing and it looks like my heartbeats from GoLang and VSCode are properly sent. Must be some weird configuration issue on your machine.

Must be local to my VSCode instance indeed then, thanks for taking the time go try to troubleshoot. I'll keep digging.

Sure, I'd suggest to check wakatime-cli's logs.

I see an occasional message
2021-04-25T13:06:47.030668182Z [ERROR] error while writing json response: json: unsupported value: +Inf

This should be resolved with the latest release.
Did you manage to solve your plugin problem?

This should be resolved with the latest release.
Great to hear, thanks !

Did you manage to solve your plugin problem?
Yup, trouble was a local DNS as I have a split view configuration of the domain name, forgot to update internal DNS (hence why it worked fine with your dev instance and Wakatime). All solved, thanks a lot for your help !


CI: Make a check which ensures standalone crates actually are standalone

What problem does this solve or what need does it fill?
A few crates:

bevy_reflect
bevy_math
bevy_color
(possiblye bevy_transform: https://github.com/bevyengine/bevy/pull/13533)

Are intended to be usable in isolation (or close to, i.e. they don't bring the whole Bevy dep tree with them).
This should have a CI check that ensures this is true.
For example if a crate garuantees that by turning off default features means it can be used standalone, this should be checked.
What solution would you like?
An automated CI check.
What alternative(s) have you considered?
Maintainers must bear the mental overhead of keeping these kinds of guaruantees, which is not good.

The best way to do this might be to somehow examine the output of cargo tree 🤔 The check-bans tool may be a good source of inspiration.

I pondered this a bit when working on https://github.com/bevyengine/bevy/pull/13533 which intends to allow default-features = false to mean only bevy_transform (and bevy_math) is pulled into your deps.
I think I found a possible way to ensure this.
cargo tree can list features, but it doesn't have structured output e.g. json.
But it has lots of other interesting (and stable) CLI flags.
Here is an example:
cargo tree --no-default-features
bevy_transform v0.14.0-dev (/home/togr/repos/bevy/crates/bevy_transform)
├── bevy_math v0.14.0-dev (/home/togr/repos/bevy/crates/bevy_math)
│   ├── approx v0.5.1
│   │   └── num-traits v0.2.18
│   │       [build-dependencies]
│   │       └── autocfg v1.2.0
│   ├── glam v0.27.0
│   │   ├── approx v0.5.1 (*)
│   │   └── bytemuck v1.15.0
│   ├── smallvec v1.13.2
│   └── thiserror v1.0.58
│       └── thiserror-impl v1.0.58 (proc-macro)
│           ├── proc-macro2 v1.0.79
│           │   └── unicode-ident v1.0.12
│           ├── quote v1.0.35
│           │   └── proc-macro2 v1.0.79 (*)
│           └── syn v2.0.57
│               ├── proc-macro2 v1.0.79 (*)
│               ├── quote v1.0.35 (*)
│               └── unicode-ident v1.0.12
└── thiserror v1.0.58 (*)
[dev-dependencies]
├── approx v0.5.1 (*)
├── bevy_math v0.14.0-dev (/home/togr/repos/bevy/crates/bevy_math) (*)
└── bevy_tasks v0.14.0-dev (/home/togr/repos/bevy/crates/bevy_tasks)
    ├── async-executor v1.11.0
    │   ├── async-task v4.7.0
    │   ├── concurrent-queue v2.4.0
    │   │   └── crossbeam-utils v0.8.19
    │   ├── fastrand v2.0.2
    │   ├── futures-lite v2.3.0
    │   │   ├── fastrand v2.0.2
    │   │   ├── futures-core v0.3.30
    │   │   ├── futures-io v0.3.30
    │   │   ├── parking v2.2.0
    │   │   └── pin-project-lite v0.2.14
    │   └── slab v0.4.9
    │       [build-dependencies]
    │       └── autocfg v1.2.0
    └── futures-lite v2.3.0 (*)

we can get rid of the dev deps like so:
cargo tree --edges normal,build --no-default-features
bevy_transform v0.14.0-dev (/home/togr/repos/bevy/crates/bevy_transform)
├── bevy_math v0.14.0-dev (/home/togr/repos/bevy/crates/bevy_math)
│   ├── glam v0.27.0
│   │   └── bytemuck v1.15.0
│   ├── smallvec v1.13.2
│   └── thiserror v1.0.58
│       └── thiserror-impl v1.0.58 (proc-macro)
│           ├── proc-macro2 v1.0.79
│           │   └── unicode-ident v1.0.12
│           ├── quote v1.0.35
│           │   └── proc-macro2 v1.0.79 (*)
│           └── syn v2.0.57
│               ├── proc-macro2 v1.0.79 (*)
│               ├── quote v1.0.35 (*)
│               └── unicode-ident v1.0.12
└── thiserror v1.0.58 (*)

we can make it less noisy:
cargo tree --edges normal,build --no-default-features --format {lib}
bevy_transform
├── bevy_math
│   ├── glam
│   │   └── bytemuck
│   ├── smallvec
│   └── thiserror
│       └── thiserror_impl
│           ├── proc_macro2
│           │   └── unicode_ident
│           ├── quote
│           │   └── proc_macro2 (*)
│           └── syn
│               ├── proc_macro2 (*)
│               ├── quote (*)
│               └── unicode_ident
└── thiserror (*)

no prefix:
cargo tree --edges normal,build --no-default-features --format {lib} --prefix none
bevy_transform
bevy_math
glam
bytemuck
smallvec
thiserror
thiserror_impl
proc_macro2
unicode_ident
quote
proc_macro2 (*)
syn
proc_macro2 (*)
quote (*)
unicode_ident
thiserror (*)

some unix piping:
cargo tree --edges normal,build --no-default-features --format {lib} --prefix none | sort | uniq
bevy_math
bevy_transform
bytemuck
glam
proc_macro2
proc_macro2 (*)
quote
quote (*)
smallvec
syn
thiserror
thiserror (*)
thiserror_impl
unicode_ident

then we can lastly do a grep for example of stuff we don't want:
cargo tree --edges normal,build --no-default-features --format {lib} --prefix none | sort | uniq | grep -E "(bevy_ecs|bevy_reflect)"

This seems like a good fit for root-level integration tests in our tests folder.

Define "standalone." Does it mean:

Can compile by itself without raising any errors.
Does not pull in any other Bevy dependencies.
Does not pull in any other dependencies at all, even non-Bevy ones.
Can optionally be turned into a standalone crate with one of the above criteria, e.g. with feature flags.

For most of the crates listed, 2. For bevy_transform, 4.

I don't think this should be part of Bevy CI. It would add complexity to an already not simple setup, without a lot of value for Bevy itself

I'm going to defer to Francois here. I've spent a while thinking about the problems this saves us from that won't be readily caught in review, and I don't think it's many.
By contrast, there's quite a bit of complexity involved in checking this.


Implement deflate compression for metrics uploads in Datadog backend

The python dd-agent uses deflate compression when POSTing to /api/v1/series. Doing this results in a substantial reduction in payload size.

Do they support gzip? I think it is preferred to deflate because deflate is/was poorly specified and different browsers do it differently IIRC. Also, why not use it for events too? I can hardly imagine that their web server is configured to accept compressed payload only for a specific url path. Or is it?

I used deflate because this is in use by the python agent. Given that this is a non-public undocumented API we're using it's best to stick fairly closely to the actual agent's behaviour.
I spent a lot of time debugging use of deflate because I was getting failures I couldn't explain. I believe deflate is supported on the metrics endpoint but not the events endpoint. You get a message that the payload is invalid, so i think it doesn't respect the content-encoding header.
WARN[0002] [datadog] failed to send events, sleeping for 1.433515344s: received bad status code 400
INFO[0004] [datadog] failed request status: 400
{"errors": ["Invalid JSON structure"]}


Compilation errors in test classes when imported in eclipse

Compilation errors when importing the project in eclipse for two test classes TestSQLAccessControlContextFactory and TestSQLAccessControlSystemInitializer
The above two classes are calling "com.ibm.icu.impl.Assert.fail" methods but it seems we need to replace this with "org.junit.Assert.fail" (and in pom we never have dependency to icu4j)

Thanks for reporting these incorrect dependencies, Mahesh!
I've replaced the wrong import statements with the correct ones that point at JUnit.
We currently don't list the (rather large) icu4j library as a dependency in OACC's POM file because it is only relevant if someone uses OACC's built-in secure password authentication provider and wants to prevent a cleanable char[] password being turned into a temporary String during unicode character normalization within the jasypt library. We'll make this more transparent in our documentation, shortly.


OCPNODE-2387: SCC: add UserNamespaceLevel field

to allow an SCC to toggle whether a pod is forced to be confined by a user namespace

@ibihim @wallylewis are you both ok with this addition to SCC, I believe auth team would own this right?

/retest

/test minor-e2e-upgrade-minor
Odd that the CLI image is missing suddenly, I don't think that's a configuration problem

/test /test minor-e2e-upgrade-minor
has magic fixed it :thinking:

updated, thanks @JoelSpeed ! Any reviews I can gather work for me, @deads2k do you have any additional notes?

Adding a new default breaks the integration tests, you'll have to add the new default field to the expected

updated! thanks @JoelSpeed

/test e2e-upgrade
/test e2e-aws-ovn-hypershift

We are asking folks to fix SSA tags as and when they come up, could you please look into fixing, for most this is just a case of adding +listType=atomic unless there is an obvious need for a map type
error in security/v1/zz_generated.crd-manifests/0000_03_config-operator_01_securitycontextconstraints-CustomNoUpgrade.crd.yaml: ListsMustHaveSSATags: crd/securitycontextconstraints.security.openshift.io version/v1 field/^.requiredDropCapabilities must set x-kubernetes-list-type
		error in security/v1/zz_generated.crd-manifests/0000_03_config-operator_01_securitycontextconstraints-CustomNoUpgrade.crd.yaml: ListsMustHaveSSATags: crd/securitycontextconstraints.security.openshift.io version/v1 field/^.allowedCapabilities must set x-kubernetes-list-type
		error in security/v1/zz_generated.crd-manifests/0000_03_config-operator_01_securitycontextconstraints-CustomNoUpgrade.crd.yaml: ListsMustHaveSSATags: crd/securitycontextconstraints.security.openshift.io version/v1 field/^.seccompProfiles must set x-kubernetes-list-type
		error in security/v1/zz_generated.crd-manifests/0000_03_config-operator_01_securitycontextconstraints-CustomNoUpgrade.crd.yaml: ListsMustHaveSSATags: crd/securitycontextconstraints.security.openshift.io version/v1 field/^.fsGroup.ranges must set x-kubernetes-list-type
		error in security/v1/zz_generated.crd-manifests/0000_03_config-operator_01_securitycontextconstraints-CustomNoUpgrade.crd.yaml: ListsMustHaveSSATags: crd/securitycontextconstraints.security.openshift.io version/v1 field/^.groups must set x-kubernetes-list-type
		error in security/v1/zz_generated.crd-manifests/0000_03_config-operator_01_securitycontextconstraints-CustomNoUpgrade.crd.yaml: ListsMustHaveSSATags: crd/securitycontextconstraints.security.openshift.io version/v1 field/^.supplementalGroups.ranges must set x-kubernetes-list-type
		error in security/v1/zz_generated.crd-manifests/0000_03_config-operator_01_securitycontextconstraints-CustomNoUpgrade.crd.yaml: ListsMustHaveSSATags: crd/securitycontextconstraints.security.openshift.io version/v1 field/^.defaultAddCapabilities must set x-kubernetes-list-type
		error in security/v1/zz_generated.crd-manifests/0000_03_config-operator_01_securitycontextconstraints-CustomNoUpgrade.crd.yaml: ListsMustHaveSSATags: crd/securitycontextconstraints.security.openshift.io version/v1 field/^.volumes must set x-kubernetes-list-type
		error in security/v1/zz_generated.crd-manifests/0000_03_config-operator_01_securitycontextconstraints-CustomNoUpgrade.crd.yaml: ListsMustHaveSSATags: crd/securitycontextconstraints.security.openshift.io version/v1 field/^.allowedFlexVolumes must set x-kubernetes-list-type
		error in security/v1/zz_generated.crd-manifests/0000_03_config-operator_01_securitycontextconstraints-CustomNoUpgrade.crd.yaml: ListsMustHaveSSATags: crd/securitycontextconstraints.security.openshift.io version/v1 field/^.allowedUnsafeSysctls must set x-kubernetes-list-type
		error in security/v1/zz_generated.crd-manifests/0000_03_config-operator_01_securitycontextconstraints-CustomNoUpgrade.crd.yaml: ListsMustHaveSSATags: crd/securitycontextconstraints.security.openshift.io version/v1 field/^.forbiddenSysctls must set x-kubernetes-list-type
		error in security/v1/zz_generated.crd-manifests/0000_03_config-operator_01_securitycontextconstraints-CustomNoUpgrade.crd.yaml: ListsMustHaveSSATags: crd/securitycontextconstraints.security.openshift.io version/v1 field/^.users must set x-kubernetes-list-type

updated @JoelSpeed !

/override ci/prow/verify-crd-schema
We can't fix the existing NoBool issues

/retest

/retest

/test e2e-aws-ovn-techpreview

/retest

LGTM once the auth team ack
/override ci/prow/verify-crd-schema

/lgtm

/lgtm

/override ci/prow/verify-crd-schema

/override ci/prow/verify-crd-schema

/retest

/retest

/retest

/cherry-pick release-4.17


GPU under-utilisation

I have tried executing the code on 1060-6GB variant and Tesla K80 12GB GPU. The GPU is heavily under-utilized on both the GPU's. Can you suggest some workaround?

Im using the same hardware as you. It will take around 2 days to estimate  poses and detect the head in for a 14 min video when suing make_target.py. The code looks very sequential. It should be possible to add  to do as much ops in CPU while loading GPU with batches. But is a lot of work to refactor the code like this.


[TEP-0089] - Phase 2 Signed TaskRun Status

Signed-off-by: pxp928<EMAIL_ADDRESS>
Changes
Authors - @pxp928 and @lumjjb
In association with TEP-0089: Non-falsifiable provenance support
This PR is the implementation of Phase 2 of the TEP-0089: Non-falsifiable provenance support
This PR builds on Phase 1  [TEP-0089] - Phase 1 Signed TaskRun Results - #4759 so that must be merged first.
Phase 2

Implement Signed TaskRuns with SPIRE
Add support for Chains verifying Signed TaskRuns

Continuation of phase 1 of TEP-0089. This PR adds signed TaskRuns by adding an annotation to that TaskRun Status. This only allows for changes from the pipeline controller to be valid. All others interactions will be marked as not valid and fail the spire verification.
Once Tekton Pipeline completes, Chains will run to verify both the TaskRun Results and the TaskRun are validated by Spire. If they do not pass the check, Chains will not sign the TaskRun.
Submitter Checklist
As the author of this PR, please check off the items in this checklist:

[x] Docs included if any changes are user facing
[x] Tests included if any functionality added or changed
[x] Follows the commit message standard
[x] Meets the Tekton contributor standards (including
functionality, content, code)
[x] Release notes block below has been filled in or deleted (only if no user facing changes)

Release Notes

Added TaskRun Status annotations to track the validity of the signed TaskRun
Utilizes pipeline controller spire SVID, status hash and signature
Pipeline controller continuously validates the TaskRun Status for any modifications
Tekton Chains will validate the results and status of the TaskRun after completion

Please provide feedback and improvements!

Clearing the milestone for now since we need to merge the Phase I implementation first.


[BUG]I can't use k3d cluster after reboot server

What did you do?
when I reboot server my demo cluster can't work

How was the cluster created?

CentOS Linux release 7.8.2003 (Core)
Linux k3d-demo 3.10.0-1127.13.1.el7.x86_64 #1 SMP Tue Jun 23 15:46:38 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux
k3d --version
k3d version v3.0.0
k3s version v1.18.6-k3s1 (default)
create cluster command
k3d cluster create demo1 --api-port <IP_ADDRESS>:10001 -p 40001:30001@server[0] --servers 3 --agents 2

What did you do afterwards?

After reboot server , I show my k3d cluster and start cluster
k3d cluster list
NAME    SERVERS   AGENTS   LOADBALANCER
demo1   3         2        true
k3d cluster start demo1
INFO[0000] Starting cluster 'demo1'
INFO[0000] Starting Node 'k3d-demo1-agent-1'
INFO[0000] Starting Node 'k3d-demo1-agent-0'
INFO[0001] Starting Node 'k3d-demo1-server-2'
INFO[0001] Starting Node 'k3d-demo1-server-1'
INFO[0002] Starting Node 'k3d-demo1-server-0'
INFO[0003] Starting Node 'k3d-demo1-serverlb'

kubectl get nodes
Error from server (ServiceUnavailable): the server is currently unable to handle the request
it's wrong
What did you expect to happen?
i can't use my demo cluster
Screenshots or terminal output
Error from server (ServiceUnavailable): the server is currently unable to handle the request
Which OS & Architecture?
Linux on gcp
Which version of k3d?
k3d version v3.0.0
k3s version v1.18.6-k3s1 (default)
Which version of docker?
Docker version 19.03.12, build 48a66213fe

Hi @chabater , thanks for opening this issue!
Can you paste the output of the following commands here please?

docker ps -a
docker logs k3ddemo1-server-0

I suspect that it's the HA issue with dqlite again, where the server-0 (i.e. the initializing server node) must not go down as long as you don't have at least one standby node (that's a perk of dqlite): So you could try it with 4 server nodes instead of 3 (at least as long as k3s is still using embedded dqlite).

@iwilltry42 thanks for your help
docker ps -a
CONTAINER ID        IMAGE                      COMMAND                  CREATED             STATUS              PORTS                             NAMES
a412f46f0698        rancher/k3d-proxy:v3.0.0   "/bin/sh -c nginx-pr…"   3 minutes ago       Up 13 seconds       80/tcp, <IP_ADDRESS>:10001->6443/tcp   k3d-demo1-serverlb
1e0265cc1ff8        rancher/k3s:v1.18.6-k3s1   "/bin/k3s agent"         3 minutes ago       Up 17 seconds                                         k3d-demo1-agent-1
9a9ba3c09efc        rancher/k3s:v1.18.6-k3s1   "/bin/k3s agent"         3 minutes ago       Up 16 seconds                                         k3d-demo1-agent-0
fcc1d8591b1c        rancher/k3s:v1.18.6-k3s1   "/bin/k3s server --t…"   3 minutes ago       Up 15 seconds                                         k3d-demo1-server-2
8a853065e010        rancher/k3s:v1.18.6-k3s1   "/bin/k3s server --t…"   3 minutes ago       Up 15 seconds                                         k3d-demo1-server-1
636cbb577bcf        rancher/k3s:v1.18.6-k3s1   "/bin/k3s server --c…"   3 minutes ago       Up 14 seconds       <IP_ADDRESS>:40001->30001/tcp          k3d-demo1-server-0
docker logs k3d-demo1-server-0
time="2020-07-22T06:51:10.324318585Z" level=warning msg="server unavailable err=failed to establish network connection: tls dial: dial tcp <IP_ADDRESS>:6443: connect: connection refused address=<IP_ADDRESS>:6443 attempt=71"
time="2020-07-22T06:51:10.324530243Z" level=warning msg="server unavailable err=failed to establish network connection: tls dial: dial tcp <IP_ADDRESS>:6443: connect: connection refused address=<IP_ADDRESS>:6443 attempt=71"
time="2020-07-22T06:51:10.327537302Z" level=warning msg="no known leader address=<IP_ADDRESS>:6443 attempt=71"
time="2020-07-22T06:51:10.327843992Z" level=warning msg="no known leader address=<IP_ADDRESS>:6443 attempt=71"
time="2020-07-22T06:51:11.328663966Z" level=warning msg="server unavailable err=failed to establish network connection: tls dial: dial tcp <IP_ADDRESS>:6443: connect: connection refused address=<IP_ADDRESS>:6443 attempt=72"
time="2020-07-22T06:51:11.329003561Z" level=warning msg="server unavailable err=failed to establish network connection: tls dial: dial tcp <IP_ADDRESS>:6443: connect: connection refused address=<IP_ADDRESS>:6443 attempt=72"
time="2020-07-22T06:51:11.331951197Z" level=warning msg="no known leader address=<IP_ADDRESS>:6443 attempt=72"
time="2020-07-22T06:51:11.332200401Z" level=warning msg="no known leader address=<IP_ADDRESS>:6443 attempt=72"

Yep, this looks like the dqlite leader election failed. This is a known issue in k3s HA with embedded dqlite.
You either have to make sure that server-0 does not go down or try some stop/start combination to bring it back or add at least one additional server node as standby. For more stability we'll have to wait for embedded etcd in k3s.. sorry for that :/

i have a old version k3d, it's can work after reboot, maybe can help.
k3d version v3.0.0-beta.0
docker images
REPOSITORY             TAG                 IMAGE ID            CREATED             SIZE
rancher/k3s            v1.18.3-k3s1        7dc8e404a0db        7 weeks ago         151MB
iwilltry42/k3d-proxy   v0.0.1              247cc840a059        3 months ago        27MB
rancher/k3s            v1.17.4-k3s1        d080d71a66ab        3 months ago        147MB
why this version can't get now

In terms of HA, nothing changed there. Are you talking about k3d or k3s version there? :thinking:
The dqlite issue is present in all of the so far.

While this is nothing more than a workaround, you can always start your load balancer (k3d node start k3ddemo1-serverlb) followed by each of your servers (k3d node start k3d-demo1-server-0) . This seems to allow a consensus to happen, and the cluster to work as expected. You can then k3d cluster start <cluster-name>

@chabater , any update on this? :+1:

I suspended this lab , thank you very much for your assistance.


As a dean I want to start a new registration window

Description
To be able to receive registrations for a course an open registration window is necessary.
The registration window can be started by the corresponding dean.
A Registration Window has the following attributes:

ID
Start: LocalDateTime
End: LocalDateTime
Status

Details
1. Add Endpoint to start a registration window
Add an endpoint to create a new registration window:

Only one registration window can be open (only one with status open, throw an exception if one is already open)
Restrict the API call to the dean
Set the status to open
The dean can enter the start and endtime when creating a new registration window

2. Start the registration window process
When a new registration window is created a new registration window process should be created.
Add the ID, start and end time to the registration window process.
3. When creating a new registration add the currently open registration window ID
When a registration is added by a student, add the current registration window id to the registration.
4. Set the status to finished when the registration window process ends
Add a service task at the end of the process and set the registration window status to finished
5. Unit tests
Don't forget to write Unit Tests for each task

@VladKay I have tried to remember the functionality that was originally planned. You can use this epic to validate if we have everything to get started with registration windows.


fix(s3.list): type hinting for chunked arg

Issue #, if available:
N/A
Description of changes:
Fixing the return type of s3.list_objects to account for the chunked arg by using typing.overload.
Currently, I have to use cast in a lot of places (40+ and growing). cast is confusing to data scientists who consume the code base, as they think it is actually casting the value or haven't seen it before. This addition allows the correct return type to be reported based on the args passed. It will save quite a bit of overhead on the user end.
Tested with mypy==0.910 and mypy==0.931.
from typing import cast, List
import awswrangler as wr

# Mypy issues, and runtime issues if you try to index a
# generator
# error: Value of type "Union[List[str], Iterator[List[str]]]" is not indexable
thing = wr.s3.list_objects("thing", chunked=True)[0]

# No mypy issues nor runtime issues, this will return a list
thing = wr.s3.list_objects("thing")[0]

# Currently I have to do this all over the code base (not using chunked)
# Or even worse... #type: ignore it
thing = cast(List[str], wr.s3.list_objects("thing"))[0]

If this is agreeable, I would be happy to take on some of the other functions that have chunking.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

AWS CodeBuild CI Report

CodeBuild project: GitHubCodeBuild8756EF16-pDO66x4b9gEu
Commit ID: adbb892bf483ef01ae11cb8a5eb1a89f84b46a4e
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

Neat, I like it, although I must say it's quite verbose

Neat, I like it, although I must say it's quite verbose

Agreed,, it is extremely verbose. I could not figure out a better way to implement it though. If someone can, please do. I guess these lines would take care of maybe several hundred lines on the user side?
@diegodebrito grep for it

I agree that it's a bit too verbose I am afraid, especially that there are other methods that have even larger input arguments. Since we are only interested in the return type, I wonder if there is a way to specify **args, **kwargs instead?

AWS CodeBuild CI Report

CodeBuild project: GitHubCodeBuild8756EF16-pDO66x4b9gEu
Commit ID: 804bb0f5d1f250679100aa9d06221a6671b9ad9e
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

I agree that it's a bit too verbose I am afraid, especially that there are other methods that have even larger input arguments. Since we are only interested in the return type, I wonder if there is a way to specify **args, **kwargs instead?

It might be possible to only include the chuncked arg with a ...  in the overloads. I'll give a shot at making something like these examples from the mypy docs work tonight.
from typing import overload

class M: ...

@overload
def get_model(model_or_pk: M, flag: bool = ...) -> M: ...
@overload
def get_model(model_or_pk: int, flag: bool = ...) -> M | None: ...

def get_model

I tried a few more things. A possible alternative is converting chucked to a keyword only arg. That is potentially more verbose and would impact the api.
https://github.com/python/mypy/issues/7333
https://github.com/python/mypy/issues/8634

IMO better type hints >> LOC so I'm ok to merge this

That'd be splendid! s3 list is probably the one users (at least in our case) are most likely to be indexing that doesn't resolve to Any (like the pandas returns), so it should cut out quite a few cast LOC.  Taking in to account just our end user code base, it would already be an overall net reduction in LOC.
The one thing I'd like to validate a bit more is if the overloads should be using the defaults i.e. ignore_suffix: Union[str, List[str], None] = None, or the ... i.e. ignore_suffix: Union[str, List[str], None] = ...,.  I'll get on that asap.

IMO better type hints >> LOC so I'm ok to merge this

That'd be splendid! s3 list is probably the one users (at least in our case) are most likely to be indexing that doesn't resolve to Any (like the pandas returns), so it should cut out quite a few cast LOC. Taking in to account just our end user code base, it would already be an overall net reduction in LOC.
The one thing I'd like to validate a bit more is if the overloads should be using the defaults i.e. ignore_suffix: Union[str, List[str], None] = None, or the ... i.e. ignore_suffix: Union[str, List[str], None] = ...,. I'll get on that asap.

Did some testing. It works either way but the ... seems like the better option since if any of the defaults ever changes, the overload doesn't need to be updated.
Here's what I used.
Happy to rebase this if needed since there were some merges into it.
# Redundant cast error -- this is a good thing
thing = cast(List[str], wr.s3.list_objects("thing"))[0]

thing = wr.s3.list_objects("thing", "*", chunked=True)

# These are all valid calls
wr.s3.list_objects("thing", ["*"], ["^"], datetime.datetime(2022, 1, 1), chunked=True)
wr.s3.list_objects("thing", ["*"], ["^"], datetime.datetime(2022, 1, 1), chunked=False)

wr.s3.list_objects(
    path="thing",
    suffix="*",
    ignore_suffix="^",
    last_modified_begin=datetime.datetime(2022, 1, 1),
    last_modified_end=datetime.datetime(2022, 1, 1),
    ignore_empty=True,
    chunked=False,
    s3_additional_kwargs={"foo": "bar"},
    boto3_session=boto3.Session(),
)

wr.s3.list_objects(
    "thing",
    "*",
    "^",
    last_modified_begin=datetime.datetime(2022, 1, 1),
    last_modified_end=datetime.datetime(2022, 1, 1),
    ignore_empty=True,
    chunked=False,
    s3_additional_kwargs={"foo": "bar"},
    boto3_session=boto3.Session(),
)

wr.s3.list_objects(
    "thing",
    "*",
    "^",
    last_modified_begin=datetime.datetime(2022, 1, 1),
    last_modified_end=datetime.datetime(2022, 1, 1),
    ignore_empty=True,
    chunked=True,
    s3_additional_kwargs={"foo": "bar"},
    boto3_session=boto3.Session(),
)

wr.s3.list_objects(
    "thing",
    "*",
    "^",
    last_modified_begin=datetime.datetime(2022, 1, 1),
    last_modified_end=datetime.datetime(2022, 1, 1),
    chunked=True,
    s3_additional_kwargs={"foo": "bar"},
    boto3_session=boto3.Session(),
)

AWS CodeBuild CI Report

CodeBuild project: GitHubCodeBuild8756EF16-pDO66x4b9gEu
Commit ID: 511b471b981a4e4405360c2e85920a2626d04405
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository


Multiuser communication in SpectatorView Pro.

Excuse, when i builded the SpectatorView Pro done, I used a emulator and a hololens joined the conversation.
I tried to move a cube, the Unity game window was show what i to do, but the other user can't get this new situation cause it's window don't get any new.
When current build the SpectatorView Pro done, it support the multiuser communication? Just like i move this cube, and you can get this.

Hello,
Spectator View Pro is able to share anchors over the network in order to setup a shared coordinate space. It doesn't however conduct content synchronization across devices like you have described (The cube translation isn't relayed to all other devices).
The MixedRealityToolkit-Unity team is working on trying to setup better content synchronization practices now that Unity's UNET has been deprecated. That going said, we don't have a great solution for this at this point in time. Some MVP contributors to the MRTK do have state synchronization solutions. It looks like a feature branch currently exists for conducting content synchronization with other industry tools such as photon (https://github.com/Microsoft/MixedRealityToolkit-Unity/tree/feature/sharing_photon_preview). I apologize that I do not have more context on how this code works. @mr0ng may be able to help direct you to some other solutions for shared experiences.

@MrUncleXiang I am going to close this issue based on a lack of activity. Please reopen this issue if you are still blocked.


let homogeneous tuples be alldense

This lets LoopVectorization work more broadly .. e.g. VectorizedStatistics can process NTuples, vminimum((1.0,2.0,0.5,1.5)) (currently it chokes).

clearly I overlooked something structural -- closing this PR
will open an issue covering the same thing

clearly I overlooked something structural -- closing this PR will open an issue covering the same thing

What did you overlook? Is this not enough for the example vminimum to work?

It does make the v_ functions work -- what I overlooked is whatever is causing the test to fail here
https://github.com/JuliaSIMD/LoopVectorization.jl/actions/runs/3512452079/jobs/5884165315
If that is unrelated -- cool.

It does make the v_ functions work -- what I overlooked is whatever is causing the test to fail here https://github.com/JuliaSIMD/LoopVectorization.jl/actions/runs/3512452079/jobs/5884165315 If that is unrelated -- cool.

That is fixed by my suggestion above.

I went ahead and committed my suggestion; I'll merge if tests pass.


Added receiveSlice api to REST endpoint

This pull request adds a slice controller to enabling receiving slices over REST.

I'll wait untill it's green


Update README.md add new name

Related issue

What changes does this PR do?
Screenshots (If any)
Questions

ok, i have found some other names which are not ordered correctly, may I reorder all the list ?

ok, i have found some other names which are not ordered correctly, may I reorder all the list ?

yes you can do this in a new Pull Request if you want :)


fix: gsheet continuous re authorisation required issue fixed

Description
After upgrade to v1.9.21, google sheets datasource would lose authentication after every couple of hours, causing all queries to fail. This PR fixes that issue.
The issue started occurring after v1.9.21 because of the changes made as a part of multiple environments. Once the access token expires, we make an API call to google to refresh the access token. This API call does not return refresh token and hence we were setting refresh token as null. On subsequent refresh calls, this refresh token would be passed as null, hence causing failure in refresh.
PR fixes following issue(s)
Fixes #24236

if no issue exists, please create an issue and ask the maintainers about this first

Media

A video or a GIF is preferred. when using Loom, don’t embed because it looks like it’s a GIF. instead, just link to the video

Type of change

Bug fix (non-breaking change which fixes an issue)

Testing

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Also list any relevant details for your test configuration.
Delete anything that is not relevant

[x] Manual
[ ] Jest
[ ] Cypress

Test Plan

Add Testsmith test cases links that relate to this PR

Issues raised during DP testing

Link issues raised during DP testing for better visiblity and tracking (copy link from comments dropped on this PR)

Checklist:
Dev activity

[x] My code follows the style guidelines of this project
[x] I have performed a self-review of my own code
[ ] I have commented my code, particularly in hard-to-understand areas
[ ] I have made corresponding changes to the documentation
[x] My changes generate no new warnings
[ ] I have added tests that prove my fix is effective or that my feature works
[ ] New and existing unit tests pass locally with my changes
[ ] PR is being merged under a feature flag

QA activity:

[ ] Speedbreak features have been covered
[ ] Test plan covers all impacted features and areas of interest
[ ] Test plan has been peer reviewed by project stakeholders and other QA members
[ ] Manually tested functionality on DP
[ ] We had an implementation alignment call with stakeholders post QA Round 2
[ ] Cypress test cases have been added and approved by SDET/manual QA
[ ] Added Test Plan Approved label after Cypress tests were reviewed
[ ] Added Test Plan Approved label after JUnit tests were reviewed

/build-deploy-preview

/ok-to-test

/ok-to-test


[release/1.7] Fix windows default path overwrite issue

Windows Containers have a default path already configured at bootup. WithDefaultPathEnv overwrites this with a unix path
(cherry picked from commit 7d636908746beb1330dad76fb86bb8235e1303cc without any additional changes)

@CharityKathure could you please the title to
[release/1.7] Fix windows default path overwrite issue

/ok-to-test


chore: move test resources to pod security CEL folder to avoid cross references

Related Issue(s)
Closes #933

Description

Checklist

[x] I have read the policy contribution guidelines.
[ ] I have added test manifests and resources covering both positive and negative tests that prove this policy works as intended.
[x] I have added the artifacthub-pkg.yml file and have verified it is complete and correct.

Thank you! 🙌


Revert "Adding Spack document"

Reverts RadeonOpenCompute/ROCm#2516
This PR should not have been merged. It doesn't meet standards and is not included in the toc.yml.in. Work on formatting and content is needed.

That's correct. It's still a draft. @saadrahim

no longer needed


Using all_pairs() on a 14k dataset causes MemoryErrors

Hi,
I'm trying to use the all_pairs() function to find all the (near-)duplicates in a set of about 14000 text documents (after turning them into ngram shingles first). However, I'm running against MemoryErrors crashing my script, despite the virtual machine I work on having 16GB of RAM. I've checked, and indeed the entire RAM and swap get maxed out before the script stops working.
Do you have any advice on how to reduce RAM usage, or any indication of how much memory the algorithm uses? I don't run into any memory issues when I use LSH with datasketch, but I'd rather have an exact list of duplicates.

Quick and wholly unscientific benchmark:

When run on about 4000 documents all_pairs() takes about 1 minute and consumes at most 1.8GB of RAM;
When run on about 8000 documents all_pair() takes about 19 minutes and consumes at most 10.6GB of RAM.

So I understand why running it on the full 14k dataset would cause MemoryErrors.
Still, I really need to be able to run all_pairs() on the full dataset, and I expect to have to run it on even bigger datasets in the future. Any idea on how to reduce memory usage?


feat(back-link): Add content to page

This adds the content to the back link page.

@jpveooys In the morning do you mind pulling this branch and running a visual locally on your machine? Cheers.


Kotlin test and spring: WithMockUser

Hello,
I'd like to know if it's possible to use the WithMockUser feature of Spring Security test.
Thanks beforehand

I believe you can use WithMockUser without annotations, which would make it possible to use in KotlinTest.
Try to take a look at https://stackoverflow.com/questions/40471424/withmockuser-without-annotation


Add docs cross-linking to APIs

For APIs now we can use cross-referencing, which is more user-friendly but also easier to maintain as we only need to update the version we want to point to in one place (the mkdocs.yml file).

mkdocs: Add cross-linking object inventory for APIs
Change links to the source with links to the docs

Enabling auto-merge.