Add Yaml support in addition to json

Could something like the following be added to the OpenApi utils as many swaggers use a yaml versus a json from their backend?
Here is an implementation that uses Jackson:
String convertYamlToJson(String yaml) {
    ObjectMapper yamlReader = new ObjectMapper(new YAMLFactory());
    Object obj = yamlReader.readValue(yaml, Object.class);

    ObjectMapper jsonWriter = new ObjectMapper();
    return jsonWriter.writeValueAsString(obj);
}

Here are two additions that we have implemented to capture the yaml and to convert the yaml to a json file for use:
  private static void saveYamlFromUrl(URL url, String filePath) throws IOException {
    ReadableByteChannel readableByteChannel = Channels.newChannel(url.openStream());

    File yaml = new File(filePath + ".yaml");
    yaml.getParentFile().mkdirs();
    yaml.createNewFile();
    FileOutputStream fileOutputStream = new FileOutputStream(yaml, false);
    FileChannel fileChannel = fileOutputStream.getChannel();
    fileChannel.transferFrom(readableByteChannel, 0, Long.MAX_VALUE);

    fileOutputStream.close();
  }

private static void yamlConversionToJson(String yamlString, String filePath) {
  ObjectMapper yamlReader = new ObjectMapper(new YAMLFactory());
  Object obj = null;

  try {
    obj = yamlReader.readValue(yamlString, Object.class);
  } catch (JsonMappingException e) {
    // TODO Auto-generated catch block
    e.printStackTrace();
  } catch (JsonProcessingException e) {
    // TODO Auto-generated catch block
    e.printStackTrace();
  }

  SaveFormattedJson(obj, filePath);
}

private static void SaveFormattedJson(Object jsonObject, String filePath) {
  try {
    ObjectWriter writer = new ObjectMapper().writerWithDefaultPrettyPrinter();
    writer.writeValue(new File(filePath + ".json"), jsonObject);
    // Used a current version of json for use with SwaggerCoverage of current karate run
    writer.writeValue(new File("target/swaggers/current.json"), jsonObject);
  } catch (IOException e) {
    e.printStackTrace();
  }
}


Binary message attributes support

Thanks! Looks great. Maybe you could add a simple integration test? See: https://github.com/adamw/elasticmq/blob/master/rest/rest-sqs-testing-amazon-java-sdk/src/test/scala/org/elasticmq/rest/sqs/AmazonJavaSdkTestSuite.scala

Sure, np.

Done

Thanks again, 0.8.9 released :)

Can't see it at maven central yet :(

Sorry! I uploaded the binaries but didn't release to central - should be there in ~15 minutes

Thank you!


feat: add dynamic suite and signing provider

Extends the SignatureSuiteRegistry and adds a SigningProviderRegistry that allows to dynamically register signers for key types and signature suites. This is needed in preparation of #948, so we can extract the bbs signing provider and signature suites to it's own package.
Extracting into a separate package will be done in a separate PR.
BbsService has been moved into the generic SigningProvider interface. I've removed support for Bls12381g1 keys for now as they're not really used for anything. It will be easy to add back in.

Codecov Report

Merging #949 (c71a77e) into 0.3.0-pre (df1ed92) will decrease coverage by 1.89%.
The diff coverage is 58.69%.

@@              Coverage Diff              @@
##           0.3.0-pre     #949      +/-   ##
=============================================
- Coverage      87.09%   85.20%   -1.90%
=============================================
  Files            536      539       +3
  Lines          13050    13086      +36
  Branches        2244     2244
=============================================
- Hits           11366    11150     -216
- Misses          1588     1805     +217
- Partials          96      131      +35

Impacted Files
Coverage Δ

...ypto/signing-provider/Bls12381g2SigningProvider.ts
25.80% <25.80%> (ø)

packages/core/src/wallet/IndyWallet.ts
56.76% <31.81%> (-5.79%)
:arrow_down:

...rc/crypto/signing-provider/SigningProviderError.ts
100.00% <100.00%> (ø)

...crypto/signing-provider/SigningProviderRegistry.ts
100.00% <100.00%> (ø)

packages/core/src/crypto/signing-provider/index.ts
100.00% <100.00%> (ø)

...ages/core/src/modules/vc/SignatureSuiteRegistry.ts
70.58% <100.00%> (ø)

...ckages/core/src/modules/vc/W3cCredentialService.ts
71.85% <100.00%> (-4.09%)
:arrow_down:

packages/core/src/modules/vc/module.ts
100.00% <100.00%> (ø)

packages/core/src/plugins/index.ts
100.00% <100.00%> (ø)

packages/core/src/wallet/WalletModule.ts
94.64% <100.00%> (+0.19%)
:arrow_up:

... and 9 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update df1ed92...c71a77e. Read the comment docs.


[ISSUE #8203] Adjust the timing of delayed messages to avoid a concentrated distribution

Which Issue(s) This PR Fixes

Fixes #8203
Brief Description

How Did You Test This Change?

Codecov Report
Attention: Patch coverage is 66.66667% with 2 lines in your changes are missing coverage. Please review.

Project coverage is 42.91%. Comparing base (0ad0244) to head (20e6191).
Report is 6 commits behind head on develop.

Files
Patch %
Lines

...apache/rocketmq/store/timer/TimerMessageStore.java
66.66%
1 Missing and 1 partial :warning:

Additional details and impacted files
@@              Coverage Diff              @@
##             develop    #8204      +/-   ##
=============================================
- Coverage      42.94%   42.91%   -0.03%
+ Complexity     10376    10373       -3
=============================================
  Files           1270     1270
  Lines          88696    88728      +32
  Branches       11402    11406       +4
=============================================
- Hits           38090    38078      -12
- Misses         45906    45944      +38
- Partials        4700     4706       +6

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


[rv_dm] Implement bad address error on SBA

This addresses https://github.com/lowRISC/opentitan/issues/11480.
The fix has been PR'ed upstream as well (#129), but until that is merged, the patch is hosted on the lowrisc patch repository so that we can vendor it in.
@sriyerg I believe the DV environment now needs to be updated to correctly predict this error.
Let me know if I should do that as part of this PR.

@sriyerg I believe the DV environment now needs to be updated to correctly predict this error. Let me know if I should do that as part of this PR.

Yes - this will break some tests, but they are designated V2. The vendor-in should not break our CI so feel free to leave that to me.

@sriyerg I believe the DV environment now needs to be updated to correctly predict this error. Let me know if I should do that as part of this PR.

Yes - this will break some tests, but they are designated V2. The vendor-in should not break our CI so feel free to leave that to me.

Sounds good!
I've pushed an updated version where the bus-integrity error is hooked up to the other_err input that we've just added to the rv_dm (see https://github.com/pulp-platform/riscv-dbg/pull/129#discussion_r835654366).

I just noticed that the patch got merged upstream: https://github.com/pulp-platform/riscv-dbg/pull/129#discussion_r835654366
I have hence re-vendored the rv_dm so that we do not have to rely on temp patches anymore.


Windows (10). Doesn't show up properly with taskbar placements

When the taskbar is not positioned to the bottom or the right, the popup show up in the opposite corner (as if the taskbar was in those positions).

I don't have enough experience with JavaScript and Node.js, so I can't offer a pull request to fix it.

Does windows 10 show up as 'win32'? If so, this line would explain that https://github.com/maxogden/menubar/blob/master/index.js#L18

Okay, seems like a good thread to as one more thing: what's the best approach to show the window directly after launch, in appropriate position according to the Tray icon?
This one shows it in the middle of screen:
// main is MenuBar instance with preloadWindow: true
main.on('after-create-window', function () {
    main.window.show();
});

Fixed in<EMAIL_ADDRESS>🚀


No dropdown on Starship Sheet for Weapons (Turret) Critical Damage

As a tagalong to this, when selecting the Gunner Actions, there is no drop down to select the Turret either. I realize that the Turret has to fire into a certain Quadrant but for purposes of your Turret taking critical damage you would need to be able to select the Turret for that to apply to the roll.

I believe the current implementation is correct as turret weapons don't suffer critical effects independently; they are considered critically damaged if any arc's weapon is critically damaged [CRB p321 in the crit dam table: "a turret counts as being in all arcs"].

I believe the current implementation is correct as turret weapons don't suffer critical effects independently; they are considered critically damaged if any arc's weapon is critically damaged [CRB p321 in the crit dam table: "a turret counts as being in all arcs"].

Yes, you are correct, This was my own misunderstanding of the rules. I will close the issue!

Yes, you are correct, This was my own misunderstanding of the rules. I will close the issue!


Using DCMTK for the standard dictionary

Take a look at dicom.dic.
It is carefully curated by the DCMTK team, in coordination with the authors of the DICOM standard. It is also updated routinely with supplements (take a look at git history).
I recommend updating the dictionary build to use it, instead of the xml version of the DICOM standard. You wouldn't need the separate/static list of "META" entries. This change would also invalidate this PR.

I see. The dictionary builder could indeed be extended to support those files.

I am working on this now. What do you think about also publishing const static strings for each key? They way, we can avoid typos in implementations.

What do you think about also publishing const static strings for each key?

Yes, this is also a good idea. We could have two kinds of Rust source code file outputs, one of them being a sequence of pub const declarations.


[Rating] Fix precision rating

[x] I have followed (at least) the PR section of the contributing guide.

Fix #32557.
This fixes the issue of precision rating, the star doesn't become full when we click on the second part, the issue was in the click event. By adding display: flex, the click event works as expected.
Note:
I tested only on Brave, we need to test also on Google Chrome & Microsoft Edge, I didn't find the specific versions!

@boutahlilsoufiane Actually now it works for me in Google Chrome as well. My Chrome version is 102.0.5005.115

Hi @ZeeshanTamboli, thanks a lot for doing the test in Google Chrome, the issue was also in Brave [Version 1.38.111 Chromium: 101.0.4951.54 (Official Build) (64-bit)].

Hi @ZeeshanTamboli, could you please tell me what's the next ? Do I need to close the PR ? Thanks !

Hi @ZeeshanTamboli, could you please tell me what's the next ? Do I need to close the PR ? Thanks !

Yes, we can close this PR. It's working for me in Google Chrome and Mozilla Firefox on the latest release v5.8.7


[Question] How do you remove the noise from the images

Amazing work on this!  I had looked into creating an auto-segmenter a while back but I struggled with sorting out the noise from the actual sheets.  Are you just cutting out anything below a certain intensity?  I imagine it's more involved than that though.  From what I understand, you generate side images from the top/down ones that are provided and then use that figure out the edges(?), but what about all the nose in the images that isn't part of the sheet itself?

Hi Noah,
I employ Gaussian Blurring to smooth out some of the noise. To extract the surface points of the sheets, Thaumato analyzes the 3D derivatives of the 3D scroll scan.
I am writing a technical report about ThaumatoAnakalyptor, it should be ready some time this week.
Cheers

Hi Noah
I added a Technical Report and Roadmap for ThaumatoAnakalyptor here: https://github.com/schillij95/ThaumatoAnakalyptor/blob/main/documentation/ThaumatoAnakalyptor___Technical_Report_and_Roadmap.pdf
Any improvements to the repository or documentation are most welcome.
Regards, Julian


Allow local, non-async FSs for references

Also introduces template_overrides kwargs, which will allow for easier testing

This opens the door to thorough testing with local files or MemoryFileSystem, but it means we should be sure to test an async backend too (i.e., HTTP, the only choice in this repo).


Build fails after merging from upstream

I'm submitting a ...  (check one with "x")
[X] bug report => search github for a similar issue or PR before submitting
[ ] feature request
[ ] support request => Please do not submit support request here, instead see use [gitter](https://gitter.im/mgechev/angular2-seed) or [stackoverflow](https://stackoverflow.com/questions/tagged/angular2)

Current behavior
The application builds, but crashes with a segfault on startup:
Successfully deployed on device with identifier 'AA4409B4-8F5C-4E1F-A991-59669D34BA6A'.
1   0x10848e5dc -[TNSRuntime executeModule:referredBy:]
2   0x104f36d02 main
3   0x1099a792d start
Dec 12 09:32:31 Smartfactorys-MacBook-Pro-2 nativescript[57775]: 4   0x1
Dec 12 09:32:31 Smartfactorys-MacBook-Pro-2 com.apple.CoreSimulator.SimDevice.AA4409B4-8F5C-4E1F-A991-59669D34BA6A.launchd_sim[57435] (UIKitApplication:ch.smartfactory.development.igoapp[0xe70f][57775]): Service exited due to signal: Segmentation fault: 11
file:///app/native.module.ts:50:0: JS ERROR SyntaxError: Importing binding name 'View' is not found.

The same issue occured when i upgraded to upstream last week with a similar error message (see https://github.com/NativeScript/nativescript-angular/issues/582).
Expected behavior
Well, it should run :)
Minimal reproduction of the problem with instructions
The steps i took to upgrade:

npm run git.merge.preview
fixed all merge conflicts (especially the yarn lockfile)
rm -rf node_modules nativescript/node_modules nativescript/platforms
yarn
npm run start.ios

What is the motivation / use case for changing the behavior?

Please tell us about your environment:
macOS latest, typescript 2.1.4, nativescript 2.4.2

Angular Seed Version: 626b42d05c9fe260899aa782215facd5b649b60b

Node: node --version = 6.9.2

I got similar errors when merging recently and it was due to changes on {N}.
Imports from nativescript, which use to be something like import {xx} from "nativescript/whatever", need to be modified to import {xx} from "nativescript".
Same thing for "nativescript-angular".
See that the above as one of the changes in the seed code, which I simply mimic on my code.
That did it for me. So check your code and fix those imports, if that is your case

That is true, thanks @fourctv
@schaermu just update all nativescript-angular imports to all import directly from the barrel, for example:
before:
import { NativeScriptModule } from 'nativescript-angular/platform';

after:
import { NativeScriptModule } from 'nativescript-angular';

That goes for all imports from that plugin everywhere.


[Suggestion] Make more drops from Sieving / Hammering visible in a single instance from JEI

Here's a concept:

Is this a happy compromise?

Is this a happy compromise?

Definitely ^^
Il Gio 7 Mar 2019, 03:17 SirLyle<EMAIL_ADDRESS>ha scritto:

[image: jei_sieve_3rows]
https://user-images.githubusercontent.com/6723308/53927520-26de2000-4055-11e9-984c-a215a6bc9925.png
Is this a happy compromise?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/BloodyMods/ExNihiloCreatio/issues/170#issuecomment-470356276,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AG2i0IEAGjbtn75qrjn3-n_C8kKmVDMBks5vUHawgaJpZM4a92rW
.


Receiving payment for unordered item(s)

The issue

The customer is prompted to make payment on clicking the "place order" button
The payment is processed successfully
The system tries to create the actual order from the quote object but fails for some reason. Let's call this reason... "network"
The customer's account has been debited without an assurance of getting his/her order. The merchant most likely would never know he received payments for a good never gonna be delivered; not unless the customer complains anyway.

Solution

Create the order with a "Pending Payment" status
On successful order creation, prompt customer to make payments
If payment is successful:
Update the order status to "Processing"

@ibrahimlawal please let me know what's your take on this

@AwoyoToyin Very well thought.

@ibrahimlawal Happy you think so too.
Milestones

I would like to eliminate the subscription to the sales_order_place_after event and remove the Profibro\Paystack\Observer\AfterOrderObserver altogether.
Add a new order_status field in the system.xml for setting a default new order status; in this case "Pending Payment". DONE
Add a new custom event say payment_verify_after that gets dispatched after the payment is verified successfully. DONE
Add a Profibro\Paystack\Observer\AfterPaymentVerifyObserver that subscribes to the custom event. This observer simply gets the last real order and sets the status to "Processing". DONE

I have begun work on this and the only issue I have is:

It seems the new order_status field in the system.xml for setting a default new order status is essentially useless has magento ignores it and defaults to "Pending" anyways.

Solution:

Skip step 1 & 2 defined in the milestone and instead do a check to make sure the order was place using profibro_paystack payment code before setting the status to "Pending Payment".

What do you think?

@AwoyoToyin Awesome, looking forward to testing this.

@ibrahimlawal Great! The proposed solution is ready and you can go ahead with the testing whenever you can.
What do you want me to do? Create a pull request?

If it's on a staging server, that'd be great

I'll see what I can do about that.

But yea, a PR is great if that's a long thing 😃

I do have it running on a client's server right now just, not exactly my staging environment. Think a PR would have to do for now. Probably have my own staging environment ready next time.

@ibrahimlawal I believe we can mark this as closed now, right?


Reproduction when facing memory error

Hi
when I reproduce repr_table6_h36m,face following problem, My compute memory is 55 GB, and I close predicting vertes for it use too much momery.
InstaVariety number of dataset objects 130431
MPII3D Dataset overlap ratio:  0
Loaded mpii3d dataset from data/preprocessed_data/mpii3d_train_scale1_db.pt
is_train:  True
mpii3d - number of dataset objects 59934
Human36M Dataset overlap ratio:  0
Loaded h36m dataset from data/preprocessed_data/h36m_train_25fps_tight_db.pt
is_train:  True
h36m - number of dataset objects 48456
Human36M Dataset overlap ratio:  0.9375
Loaded h36m dataset from data/preprocessed_data/h36m_test_front_25fps_tight_db.pt
is_train:  False
h36m - number of dataset objects 68416
=> loaded pretrained model from 'data/base_data/spin_model_checkpoint.pth.tar'
=> no checkpoint found at ''
Epoch 1/45
(500/500) | Total: 0:03:51 | ETA: 0:00:01 | loss: 9.57 | 2d: 3.23 | 3d: 4.53  | loss_kp_2d: 1.615 | loss_kp_3d: 0.990 | loss_shape: 0.022 | loss_pose: 0.682 | data: 1.17 | forward: 0.03 | loss: 0.01 | backward: 0.07 | batch: 1.28
(2138/2138) | batch: 1.201e+03ms | Total: 0:02:00 | ETA: 0:00:01
Evaluating on 68416 number of poses...
Learning rate 5e-05
Learning rate 0.0001
Epoch 0, MPJPE: 84.9076, PA-MPJPE: 57.8166, ACCEL: 2.5355, ACCEL_ERR: 3.3904,
Epoch 1 performance: 57.8166
Best performance achived, saving it!
Epoch 2/45
(500/500) | Total: 0:03:59 | ETA: 0:00:01 | loss: 3.98 | 2d: 2.00 | 3d: 1.38  | loss_kp_2d: 2.273 | loss_kp_3d: 1.975 | loss_shape: 0.020 | loss_pose: 0.572 | data: 0.56 | forward: 0.03 | loss: 0.01 | backward: 0.08 | batch: 0.68
(2138/2138) | batch: 1.197e+03ms | Total: 0:01:59 | ETA: 0:00:01
Evaluating on 68416 number of poses...
Epoch 1, MPJPE: 77.5908, PA-MPJPE: 49.9525, ACCEL: 2.5912, ACCEL_ERR: 3.3052,
Epoch 2 performance: 49.9525
Learning rate 5e-05
Learning rate 0.0001
Best performance achived, saving it!
Epoch 3/45
(500/500) | Total: 0:03:56 | ETA: 0:00:01 | loss: 3.34 | 2d: 1.70 | 3d: 1.18  | loss_kp_2d: 3.205 | loss_kp_3d: 1.627 | loss_shape: 0.018 | loss_pose: 0.582 | data: 0.01 | forward: 0.03 | loss: 0.01 | backward: 0.08 | batch: 0.12
(2138/2138) | batch: 1.238e+03ms | Total: 0:02:03 | ETA: 0:00:01
Evaluating on 68416 number of poses...
Epoch 2, MPJPE: 72.0071, PA-MPJPE: 48.5966, ACCEL: 2.8021, ACCEL_ERR: 3.3457,
Epoch 3 performance: 48.5966
Learning rate 5e-05
Learning rate 0.0001
Best performance achived, saving it!
Epoch 4/45
(500/500) | Total: 0:03:48 | ETA: 0:00:01 | loss: 3.12 | 2d: 1.69 | 3d: 1.06  | loss_kp_2d: 1.572 | loss_kp_3d: 2.059 | loss_shape: 0.017 | loss_pose: 0.360 | data: 0.01 | forward: 0.03 | loss: 0.01 | backward: 0.07 | batch: 0.12
(2138/2138) | batch: 1.199e+03ms | Total: 0:01:59 | ETA: 0:00:01
Evaluating on 68416 number of poses...
Epoch 3, MPJPE: 70.6277, PA-MPJPE: 47.0223, ACCEL: 2.6875, ACCEL_ERR: 3.2729,
Epoch 4 performance: 47.0223
Learning rate 5e-05
Learning rate 0.0001
Best performance achived, saving it!
Epoch 5/45
(500/500) | Total: 0:03:51 | ETA: 0:00:01 | loss: 2.92 | 2d: 1.61 | 3d: 0.98  | loss_kp_2d: 1.649 | loss_kp_3d: 1.081 | loss_shape: 0.012 | loss_pose: 0.321 | data: 0.50 | forward: 0.03 | loss: 0.01 | backward: 0.07 | batch: 0.61
Traceback (most recent call last):
  File "/media/xf/F/code/TCMR_RELEASE-master/train.py", line 141, in <module>
    main(cfg)
  File "/media/xf/F/code/TCMR_RELEASE-master/train.py", line 131, in main
    debug_freq=cfg.DEBUG_FREQ,
  File "/media/xf/F/code/TCMR_RELEASE-master/lib/core/trainer.py", line 343, in fit
    self.validate()
  File "/media/xf/F/code/TCMR_RELEASE-master/lib/core/trainer.py", line 291, in validate
    for i, target in enumerate(self.valid_loader):
  File "/home/xf/miniconda3/envs/tcmr/lib/python3.7/site-packages/torch/utils/data/dataloader.py", line 279, in __iter__
    return _MultiProcessingDataLoaderIter(self)
  File "/home/xf/miniconda3/envs/tcmr/lib/python3.7/site-packages/torch/utils/data/dataloader.py", line 719, in __init__
    w.start()
  File "/home/xf/miniconda3/envs/tcmr/lib/python3.7/multiprocessing/process.py", line 112, in start
    self._popen = self._Popen(self)
  File "/home/xf/miniconda3/envs/tcmr/lib/python3.7/multiprocessing/context.py", line 223, in _Popen
    return _default_context.get_context().Process._Popen(process_obj)
  File "/home/xf/miniconda3/envs/tcmr/lib/python3.7/multiprocessing/context.py", line 277, in _Popen
    return Popen(process_obj)
  File "/home/xf/miniconda3/envs/tcmr/lib/python3.7/multiprocessing/popen_fork.py", line 20, in __init__
    self._launch(process_obj)
  File "/home/xf/miniconda3/envs/tcmr/lib/python3.7/multiprocessing/popen_fork.py", line 70, in _launch
    self.pid = os.fork()
OSError: [Errno 12] Cannot allocate memory

Could you give me some suggestion? Thanks!

Uhm..
Did you try discarding some data as I suggested here? https://github.com/hongsukchoi/TCMR_RELEASE/issues/29

I reduce num_worker from 16 to 4 and got simmilar result.


Add library to allow easier Java arithmetic conversion

I am trying to convert a program from Java to Dart. I am having trouble because of the rounding differences between Java and Dart.
e.g.
Dart
stdout.write("out="+(8/12).toString());
out=0.6666666666666666

Java
System.out.println("out="+8/12);
out=0

It looks like Dart is treating 8 as a double, whereas Java treats 8 as an int and 8.0 as a double ?
Perhaps implementing a rounding mode as available in Java would allow for easier code conversion ?
Java Rounding Mode

I just checked, and :
Java
System.out.println("out="+8.0/12.0);
out=0.6666666666666666

Dart
int s=8;
int t=12;
stdout.write("out="+(s/t).toString());
out=0.6666666666666666

If you would an integer division like in Java you need to use a ~/ b operator.


Update README.md

@marcuxyz take a look, please

thanks, @blablatdinov  for contributing

Thank you too. Nice tool!


DNN9.10.0 Calling API/CKEditorProvider/CloudServices/GetToken results in user being logged out

Description of bug
If a user in a portal other than the root portal calls API/CKEditorProvider/CloudServices/GetToken, the user will be logged out.  The user must not be a member of the root portal and from what I can see must not be a super user.
I think this is a different manifestation of the same problem:
https://github.com/dnnsoftware/Dnn.Platform/pull/4773
In this case, fixing the javascript on the site doesn't help (it's an API call)
Steps to reproduce
List the precise steps to reproduce the bug:

Create a new user in a portal that  is not the root portal.  this user must not exist in the root portal
Log the user into the portal
Access url https://<host>/API/CKEditorProvider/CloudServices/GetToken
The response will be a 302 and the user is logged out (the cookie is wiped)

Current behavior
The response will be a 302 and the user is logged out (the cookie is wiped)
Expected behavior
A 200 response that does not log the user out
Screenshots

Error information
No errors other than the 302 response
Additional context
In chasing this down, in the call to Authenticate in (MembershipModule.cs:99) request, this code returns the portal settings for portal 0, not the current portal:
// Obtain PortalSettings from Current Context
PortalSettings portalSettings = PortalController.Instance.GetCurrentPortalSettings();

So unless the logged in user is a user in portal 0, this results in a NULL being returned:
var user = UserController.GetCachedUser(portalSettings.PortalId, context.User.Identity.Name);
To see this happen do the following:
have a user who is not a member of portalid = 0
log that user in
from the current tab or another tab in your brower hit the URL: https:///API/CKEditorProvider/CloudServices/GetToken
At this point the user is logged out... web server will return with a 302 and a delete the session login cookie
if you grab the process in the debugger, you will see that portalSettings.PortalId == 0 for the API call, but it's correct for all the other activity loading the page.
Affected version

[ ] 10.00.00 alpha build
[x] 09.10.00 latest supported release

Affected browser

[x] Chrome
[x] Firefox
[x] Safari
[x] Internet Explorer 11
[x] Microsoft Edge (Classic)
[x] Microsoft Edge Chromium

@ggiordan do you have steps to reproduce this other than "accessing that URL", I am not sure how to make this happen here. I am guessing it is with maybe some specific CKEditor Plugin maybe ?

Hi @valadas , it seems that the logout is caused when this is hit:
https://<machine>/API/CKEditorProvider/CloudServices/GetToken
The problem is that the user's current portal is getting lost and the API looks for the user in portal 0.  The API needs to look for the user in the correct portal.

Yeah, the thing is that I cannot get DNN to call that API, can you look into Site Settings -> Site Behaviour -> More -> Open HTML Editor Manager Then in that panel, go to the Editor Config tab and search for the word "Plugin", you should see a field with a list of plugins, can you put this list here...

Are you using the Easy Image plugin? That's configuring in the File Browser Settings tab.

Haaa, that was the missing piece, cool, I get it accessing that endpoint, I'll look into this


friture: 0.47 -> 0.48, add myself as maintainer

Marked as a draft because Friture still needs this PR merged for this to work properly - and because this is an issue that likely affects all Linux distributions building Friture from source, it's probably better to wait for an upstream fix. The PR has been merged, but it will probably still take some time for a new version to come out, so I've backported the fix as a patch.
Motivation for this change
Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
[x] Tested execution of all binary files (usually in ./result/bin/)
21.11 Release Notes (or backporting 21.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[ ] Fits CONTRIBUTING.md.

I've backported the fix for the packaging issue, so this should be ready to merge now.

I would say let's merge this, and if there are additional improvements, they can be incorporated in the next version bump.
Thank you for your contribution!


ci: run tests against Python 3.13

Welcome to Codecov :tada:
Once you merge this PR into your default branch, you're all set! Codecov will compare coverage reports and display results in all future pull requests.
Thanks for integrating Codecov - We've got you covered :open_umbrella:


No longer working

Seems an update to either vscode (or some other extension) has broken this (quite recently for me). Tells me that ⌘-K, V is not a command even though it is listed in the key bindings. ⌘-Shift-V does nothing.
Version: 1.55.2 (Universal)
Commit: 3c4e3df9e89829dce27b7b5c24508306b151f30d
Date: 2021-04-13T09:36:32.643Z
Electron: 11.3.0
Chrome: 87.0.4280.141
Node.js: 12.18.3
V8: <IP_ADDRESS>-electron.0
OS: Darwin x64 18.7.0

Any suggestions on how to track down the problem?

I have the same problem.
macOS, 10.15.7

I have the same problem, on a Windows Computer. Error message with Ctrl+K, V:  "The key combination CTRL+K V is not a command."
Using CTRL+Shift+V copies something into my program.
I have disabled all other extensions and this is a new install (only a few days old)


CB-12804 : manifest.json added to browser during create

Platforms affected
What does this PR do?
manifest.json added to browser during create
What testing has been done on this change?
Checklist

[X] Reported an issue in the JIRA database
[X] Commit message follows the format: "CB-3232: (android) Fix bug with resolving file paths", where CB-xxxx is the JIRA ID & "android" is the platform affected.
[X] Added automated test coverage as appropriate for this change.

@audreyso looks good. Is there a follow up issue to read the icon tag from config.xml and add it to the manifest?


Bug in Date calculator

Describe the bug

A clear and concise description of what the bug is.

Possible solution

Describe the solution you thought of.

Screenshots

NaN...NaN - invalid output is published because the js function is called as soon as we give the 1st input
So i will just try calling the function after both inputs are given

i would like to work on this issue


Add dataset creators

Codecov Report
Patch coverage is 100.00% of modified lines.

:exclamation: Current head a73ff50 differs from pull request most recent head 35cac75. Consider uploading reports for the commit 35cac75 to get more accurate results

Files Changed
Coverage

src/gravitorch/creators/dataset/__init__.py
100.00%

src/gravitorch/creators/dataset/base.py
100.00%

src/gravitorch/creators/dataset/vanilla.py
100.00%

:loudspeaker: Thoughts on this report? Let us know!.


CompendiumCollection.indexed is missing

In which branch or foundry version does the problem occur?
branch: foundry-0.8.x
foundry v 0.8.9
Describe the wrong type
CompendiumCollection is missing the boolean indexed
To Reproduce
It's missing so get's red if I try to use it
Expected behavior
To be typed :-)
Additional context
Documented here https://foundryvtt.com/api/CompendiumCollection.html

ConpendiumCollection hasn’t been updated for the latest version yet, see https://github.com/League-of-Foundry-Developers/foundry-vtt-types/issues/897. we'll keep this in mind when doing the update.


Added caching via workbox

User can now click on download website button to cache the content that we deem fit. Backend devs will support this by providing access to the content that will be cached

Not sure how important this is, but I can see a warning, in Firefox, regarding the web manifest that says, "The start URL is outside the scope, so the scope is invalid".

resolved issue


u_3 at the bottom cell face is not zero

When running the sphere_baroclinic_wave_rhoe simulation in ci, Y.f.u_3 is not zero at the bottom cell face:
Fields.level(Y.f.u₃, half)
ClimaCore.Geometry.Covariant3Vector{Float32}-valued Field:
  components:
    data:
      1: Float32[-1.10124, -0.122195, -0.277133, -0.0229017, 0.0599936, -0.00809689, -0.0431773, 0.170735, 0.250247, 0.0437873  …  -0.114353, 0.0320632, -0.556519, 0.214318, 0.0463827, 0.244027, -1.10124, -0.122195, -0.277133, -0.0229017]

It is zero if hyperdiff is set to "false".
Found together with @trontrytel. cc @simonbyrne.

Do you know if this was the case before #2006? Because the logic should still be the same:
https://github.com/CliMA/ClimaAtmos.jl/pull/2006/files#diff-2eab639ff3ba32cd1f1eaab302ce6aa6845984a8f1d1aaad8c9c46896db13c28L177
In any case, it should get cleaned up by set_precomputed_quantities!. When are you accessing it?

Do you know if this was the case before #2006? Because the logic should still be the same: https://github.com/CliMA/ClimaAtmos.jl/pull/2006/files#diff-2eab639ff3ba32cd1f1eaab302ce6aa6845984a8f1d1aaad8c9c46896db13c28L177

I don't remember exactly. I remember u_3 at the surface is zero in the diagnostics, but that is after set_precomputed_quantities!

In any case, it should get cleaned up by set_precomputed_quantities!. When are you accessing it?

Right, I was accessing it at the end of the simulation, when set_precomputed_quantities! is not called yet I think. I thought all the tendencies of u_3 at the surface would be zero though?


added support for parameter less functions as fields

I hope you find this idea interesting. Just to make an example where this could be usefull is knockout observables. Actually the grid don't support it, at least not without specifing a dataItemColumnValueExtractor.
I think this is a really small change but really usefull. I looked for the fastest "function test", but if you have another one you can change it.

This does look interesting, but I don't think it's right as a default behavior.  It is easy enough to add this particular customization via dataItemColumnValueExtractor, which is what I added it for in the first place.
As a side note, the "function test" is overly inclusive, as it would consider any object with "call" and "apply" properties a function.

Hi Michael, thanks for having a look.
For the function test I found the jQuery.isFunction that I was not aware of.
About the dataItemColumnValueExtractor, yeah it's a good approach. Anyway if you are using knockout like me (i know it's my problem!) it can become boring to specify it for all the columns when the solution are just two lines of code. Anyway you chose what to put in your repository.
Yesterday I had a deeper look and found that the "editors" don't call the function you introduced with the 2.0 (getDataItemValueForColumn) but still goes with the array like 1.4.3 did. Also the method it's not public. But probably you already knew it.

You should only have to specify the dataItemColumnValueExtractor once for the grid and not for each column.
Good catch with the editors - I'll look into that.

Oh yeah, It's not a column option but a grid option. My fault!
About the editors it would be great to have also a setter method on the grid like the getter one.
Thanks


Update index.rst

between is more appropriate to use than on when referring to the relationships that exist between tables.

This is a slightly problematic term for us because from a language point of view relationships between tables makes sense. But from a Hasura point of view, you define a "relationship" "on" a table because each table has these things called relationships. Just like permissions. Leaving this open till we figure out what the right terminology is.

Sticking with on


pretty_float!() drops a lot of precision

pretty_float!() is used when printing Expression, and it keeps at most two decimal places of precision.
For example RX(3.1415925) 0 becomes RX(3.14) when printed, and those are very different unitaries. I recommend we drop pretty_float!() in favor of precision.

Similarly, I was surprised to see the following behaviour after removing the pretty printer: RX(0.01) 0 becomes RX(0.009999999776482582) 0 which leads me to believe floats are parsed as f32? Not sure.

Both of the above are addressed in #9
@kalzoo

Closed by #9


Fix "log.SetLogger(...) was never called" warning

Motivation
System tests sometimes complain with a warning about this issue:
[controller-runtime] log.SetLogger(...) was never called; logs will not be displayed.
Detected at:
	>  goroutine 89 [running]:
	>  runtime/debug.Stack()
	>  	/usr/local/go/src/runtime/debug/stack.go:24 +0x5e
	>  sigs.k8s.io/controller-runtime/pkg/log.eventuallyFulfillRoot()
	>  	/go/pkg/mod/sigs.k8s.io/controller-runtime@v0.16.2/pkg/log/log.go:60 +0xcd
	>  sigs.k8s.io/controller-runtime/pkg/log.(*delegatingLogSink).WithName(0xc0001f3400, {0x1d7b101, 0x14})
	>  	/go/pkg/mod/sigs.k8s.io/controller-runtime@v0.16.2/pkg/log/deleg.go:147 +0x45
	>  github.com/go-logr/logr.Logger.WithName({{0x201aac0, 0xc0001f3400}, 0x0}, {0x1d7b101?, 0x1d63709?})
	>  	/go/pkg/mod/github.com/go-logr/logr@v1.2.4/logr.go:336 +0x3d
	>  sigs.k8s.io/controller-runtime/pkg/client.newClient(0x1d09720?, {0x0, 0xc003dfa3f0, {0x0, 0x0}, 0x0, {0x0, 0x0}, 0x0})
	>  	/go/pkg/mod/sigs.k8s.io/controller-runtime@v0.16.2/pkg/client/client.go:122 +0xec
	>  sigs.k8s.io/controller-runtime/pkg/client.New(0x20024e0?, {0x0, 0xc003dfa3f0, {0x0, 0x0}, 0x0, {0x0, 0x0}, 0x0})
	>  	/go/pkg/mod/sigs.k8s.io/controller-runtime@v0.16.2/pkg/client/client.go:103 +0x7d
	>  github.com/spacemeshos/go-spacemesh/systest/testcontext.New(0xc000187380, {0xc0003c5f18, 0x1, 0x5ac?})
	>  	/build/systest/testcontext/context.go:291 +0x32e
	>  github.com/spacemeshos/go-spacemesh/systest/tests.TestPartition_30_70(0xc0001031e0?)
	>  	/build/systest/tests/partition_test.go:174 +0xc8
	>  testing.tRunner(0xc000187380, 0x1e6c4c0)
	>  	/usr/local/go/src/testing/testing.go:1595 +0xff
	>  created by testing.(*T).Run in goroutine 1
	>  	/usr/local/go/src/testing/testing.go:1648 +0x3ad

This PR tries to fix that warning
Changes

set a logger for controller-runtime in system tests

Test Plan
n/a
TODO

[x] Explain motivation or link existing issue(s)
[x] Test changes and document test plan
[x] Update documentation as needed
[x] Update changelog as needed

bors merge


Correcting a syntactic error in ES6 class usage in readme

I don't think this bit in the readme file is valid ES6. If you want to use classes to create namespaces, it has to be done via assignment.
The preferred way of doing namespaces are through using the new module system. Unfortunately, Meteor hasn't integrated ES6 modules yet so we are stuck with this method for now.

Thanks!
Hm, are there anonymous classes possible in ES6? So Buttons.Red = class extends BlazeComponent {}?

Yeah, it should be possible. Checkout this MDN article with more details: https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Operators/class
ES6 classes are just syntactic sugar for prototypical inheritance so in essence, there's nothing new here.

Yea, but probably stack then looks uglier.


Remove Individual Schema Checks on PR

Remove Individual Schema Checks on PR
assetlist, chain, versions, keys, but NOT ibc, because that has additional checks

LGTM!


Add script for deploying latest stable CF to BOSH Lite

Cache stemcell & cf release in WORKSPACE.
We are making our use of WORKSPACE explicit and believe this is better than relative paths. What do you think?

Hi @jutkko
This script doesn't seem to depend on the cf-release repository at all.  Seems like this script could live anywhere and still work.  If you find this script handy for your workflow, I encourage you to use it, but we don't want to maintain an additional script within this repo at this time.
Thanks,
Amit


no space between end and start in loop

This issue happen in loop mode when the width of the text is longer that the width containing tag.
The space at the end of the text is cleaned by HTML standard.
I tried to use   but this is interpreted as text.

Similar issue is, that multiple space are not accepted resp. multiple space are cleaned by HTML standard.
I assume this have the same reason and maybe same solution.
How to get a text with multiple space?

Found the solution by myself.
I took the text itself as children.
By embedding the text into a  tag, I was able to have as many spaces I want to any position.
So I am able to do spaces at the end or at the beginning to get the wanted gap.
Issue closed.


cmd/go: relax module consistency checks if vendor/modules.txt is missing

Strong consistency checks in go1.14 and requirement that vendor/modules.txt must be present make it hard to package Go software (e.g. as FreeBSD ports).
Because network is not available during the port build, ports are built in -mod=vendor mode. All required dependencies are fetched beforehand and then unpacked into vendor directory simulating the result of go mod vendor, except that vendor/modules.txt is not present. If software's go.mod specifies go.14, missing vendor/modules.txt is a hard error (... is explicitly required in go.mod, but not marked as explicit in vendor/modules.txt) and working around it requires patching go.mod back to go1.13
Proposed change relaxes module consistency checks and switches back to go1.13 behaviour if vendor/modules.tx is not present during the build.

Could you say more about why go mod vendor can't be used build the vendor directory? That's the only supported mechanism for building a vendor directory in module mode.
Also, why not build a vendor/modules.txt file that satisfies the consistency check? Information from that file is used in several commands, so it's important that it's present and accurate.

@jayconrod Because network is not available during the build. The list of required dependencies is generated from vendor/modules.txt (after go mod vendor) and committed along with port and vendor dir contents is then reconstructed using that list. We don't keep vendor/modules.txt because (a) it wasn't required with go1.13 and (b) dependencies list is already consistent with go.mod by construction.

If you have a full copy of vendor/modules.txt at an earlier point in the build, why not keep that? It sounds like you're able to run go mod vendor at some point, so I don't understand why it needs to be rebuilt after that.
You may be able to construct the vendor directory using go mod vendor offline by adding replace directives to go.mod, or an alternative go.mod file specified with -modfile. A local GOPROXY implementation may also be an option.
I don't think we should disable the vendor/modules.txt consistency check though. It's important.

Alternatively, you can add an option to go to wave the consistency check.
(A full copy of vendor/modules.txt is available at some point during the port maintainer update, but it's problematic to keep it into the build phase within the FreeBSD ports framework.)

The design of Go assumes that network is available at all times during build, while during package build the network is not available for security reasons. The new consistency checking exacerbate this conflict, putting more and more burden on port developers/maintainers.

The consistency check does not use the network, by design. It compares the lexical contents of the go.mod and vendor/module.txt files.
And note that replace directives also avoid the network. I would expect that in most packaging systems, a replace directive would express the intended substitution more clearly than a vendor tree.

Closing old issues that still have the WaitingForInfo label where enough details to investigate weren't provided. Feel free to leave a comment with more details and we can reopen.


Publish 0.37.0 to winget

Automatic PR creatition is disabled in your goreleaser config, so It seems you need to create PR manually.

thank you. I'm sending Pull Request.
https://github.com/microsoft/winget-pkgs/pull/190124


initial BoringSSL harness

WIP.

This looks like it uses the legacy validator. Boringssl has a new validator
that might be more useful to include
On Thu, Aug 1, 2024, 4:08 PM William Woodruff @.***>
wrote:

WIP.
You can view, comment on, or merge this pull request online at:
https://github.com/C2SP/x509-limbo/pull/315
Commit Summary

8437bd8
https://github.com/C2SP/x509-limbo/pull/315/commits/8437bd88197c91a000479850d202d9cc0bbe3134
initial BoringSSL harness

File Changes
(5 files https://github.com/C2SP/x509-limbo/pull/315/files)

M Cargo.lock
https://github.com/C2SP/x509-limbo/pull/315/files#diff-13ee4b2252c9e516a0547f2891aa2105c3ca71c6d7a1e682c69be97998dfc87e
(262)
M Makefile
https://github.com/C2SP/x509-limbo/pull/315/files#diff-76ed074a9305c04054cdebb9e9aad2d818052b07091de1f20cad0bbac34ffb52
(3)
M harness/openssl/Makefile
https://github.com/C2SP/x509-limbo/pull/315/files#diff-fb67f3a1ea4404b2e18f20857104550a8ced3bb920bd9da8e4907108d9c09108
(10)
A harness/openssl/boringssl.dockerfile
https://github.com/C2SP/x509-limbo/pull/315/files#diff-db8d8aecc698639e7344e1e33a7985f5c797324d811b7814fcdc8869525ba3a4
(10)
M harness/openssl/main.cpp
https://github.com/C2SP/x509-limbo/pull/315/files#diff-311ab821a4aeb2f0ebe79ad32cb9e799afe833139221168c2a31f8927e779b49
(17)

Patch Links:

https://github.com/C2SP/x509-limbo/pull/315.patch
https://github.com/C2SP/x509-limbo/pull/315.diff

—
Reply to this email directly, view it on GitHub
https://github.com/C2SP/x509-limbo/pull/315, or unsubscribe
https://github.com/notifications/unsubscribe-auth/AAAAGBADIXX5XUC3JLURE5DZPKISDAVCNFSM6AAAAABL3HZZDGVHI2DSMVQWIX3LMV43ASLTON2WKOZSGQ2DGMZRHA2DMMQ
.
You are receiving this because you are subscribed to this thread.Message
ID: @.***>

TIL, I'll look into using that (I did it the lazy way to start by just adapting the existing OpenSSL harness).

I might be missing it, but I don't see a newer validator in BoringSSL's X.509 APIs.
x509.h has this note:
// Legacy X.509 library.
//
// This header is part of OpenSSL's X.509 implementation. It is retained for
// compatibility but should not be used by new code. The functions are difficult
// to use correctly, and have buggy or non-standard behaviors. They are thus
// particularly prone to behavior changes and API removals, as BoringSSL
// iterates on these issues.
//
// In the future, a replacement library will be available. Meanwhile, minimize
// dependencies on this header where possible.

https://github.com/google/boringssl/blob/7a6e828dc53ba9a56bd49915f2a0780d63af97d2/include/openssl/x509.h#L95C1-L104C47

https://github.com/google/boringssl/tree/7a6e828dc53ba9a56bd49915f2a0780d63af97d2/include/openssl/pki
On Fri, Aug 2, 2024 at 11:06 AM William Woodruff @.***>
wrote:

I might be missing it, but I don't see a newer validator in BoringSSL's
X.509 APIs.
x509.h has this note:
// Legacy X.509 library.//// This header is part of OpenSSL's X.509 implementation. It is retained for// compatibility but should not be used by new code. The functions are difficult// to use correctly, and have buggy or non-standard behaviors. They are thus// particularly prone to behavior changes and API removals, as BoringSSL// iterates on these issues.//// In the future, a replacement library will be available. Meanwhile, minimize// dependencies on this header where possible.
https://github.com/google/boringssl/blob/7a6e828dc53ba9a56bd49915f2a0780d63af97d2/include/openssl/x509.h#L95C1-L104C47
—
Reply to this email directly, view it on GitHub
https://github.com/C2SP/x509-limbo/pull/315#issuecomment-2265607022, or
unsubscribe
https://github.com/notifications/unsubscribe-auth/AAAAGBE4AH7SGNTTI4IWFITZPON7DAVCNFSM6AAAAABL3HZZDGVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDENRVGYYDOMBSGI
.

This now uses libpki, although FWICT the libpki APIs don't perform SAN/name verification as part of path/chain building. I might be missing that in the CertificateVerifyOptions, so I'll spend some more time attempting to make this work in the coming days.


[hivemq-krb] Handle dynamic ACLs better

When ACLs change existing connections continue with their current permission set. This is starting to cause problems with our dynamic ACL adjustments, particularly when a client gets stuck with no permissions because they hadn't been set up yet at the point where they connected.
Handling this will be tricky. It will require a proper auth plugin rather than just setting a permission list at connection time. It will also require working out how to listen to our own MQTT traffic in order to get change-notify from the services; I think there are APIs for tracking packets, but we don't want to get slow.

I think we can work around this, as follows:

If permission is revoked for an active subscription, we don't attempt to let the client know. We do stop sending packets.
If the client resubscribes, we send an appropriate error. MQTT is clear that the new subscription replaces the old, so an error from a resubscription must leave the client not subscribed.
If a client needs to know when subscription permission is revoked, it will need to periodically resubscribe. This still leaves open the possibility of a gap in permission which the client doesn't become aware of.

This means we will need to preserve subscriptions the client is no longer authorised for, potentially forever, in case they come back. This is no different from the normal MQTT state.
Clients will not know if they have missed packets because of ACL changes, except by tracking Sparkplug sequence numbers (currently unreliable due to not using bdSeq correctly). This means a client could potentially end up misinterpreting aliases. Given that we don't currently issue a rebirth on reconnection I think this is unlikely to be a serious problem in practice.
The implementation required for this will also mean that we could implement separate Subscribe and Read permissions, like Mosquitto. A general grant of Subscribe to spBv1.0/# would work around all the problems with failed subscriptions needing to be retried; the packets would just either appear, or not.


feat(telemetry): Introduce DO_NO_TRACK and KEDRO_DISABLE_TELEMETRY

Description

Fix #728
Development notes

Added two new env vars to skip telemetry if exist. It will override the consent regardless what is written in a .telemetry file.

Checklist

[ ] Opened this PR as a 'Draft Pull Request' if it is work-in-progress
[ ] Updated the documentation to reflect the code changes
[ ] Added a description of this change in the relevant RELEASE.md file
[ ] Added tests to cover my changes

CI error is irrelevant, suspect some changes caused by https://github.com/kedro-org/kedro/pull/3883.


Missing non-production watermark in credential details screen

Background
People are unable to tell if the credential is a demo/test credential from the credential details screen or proof request screen.
Acceptance Criteria
Given the credential is a non-production credential
When the user is in a proof request or credential details screen
Then the watermark should be present in the credential card UI
Wireframes
https://xd.adobe.com/view/045a1969-719a-4aa5-848f-637ef1b7051a-5109/screen/6f5562f2-088c-49df-9db5-47dadafa852d/

@jleach checked iOS and Android build 1576, the watermark isn't present in the credential details screen.

I can see them in 1.0.15 1594.

Tested 1598 on iOS and Android, watermark is on the details screen


[SE-0306] Disable actor inheritance.

Actor inheritance was removed in the second revision of SE-0306. Remove
the ability to inherit actors.
Note that this doesn't fully eliminate all vestigates of inheritance
from actors. There are simplifications that need to be performed
still, e.g., there's no need to distinguish
designated/convenience/required initializers. That will follow.

@swift-ci please smoke test and merge

@swift-ci please smoke test Linux


@Variable doesn't work on Kotlin functions, i.e. static methods in Java

@falko currently I have not implemented any support for Kotlin. It would great to have the support for Kotlin. PR's are welcome
The extension quarkus-scheduler could serve as an example.

Well, this issue is not really Kotlin-specific: The code that handles static methods does not support annotations.

@falko Do you have an example (or method) that I can use to reproduce this issue?

PR: #277


Avoid re-issuing redundant cross-references.

Fixes #8722
This will avoid rewriting the reference if its the same as an existing one.

Codecov Report

Merging #8734 into master will increase coverage by <.01%.
The diff coverage is 59.52%.

@@            Coverage Diff             @@
##           master    #8734      +/-   ##
==========================================
+ Coverage   41.38%   41.39%   +<.01%
==========================================
  Files         537      537
  Lines       69242    69260      +18
==========================================
+ Hits        28656    28667      +11
- Misses      36906    36913       +7
  Partials     3680     3680

Impacted Files
Coverage Δ

models/issue_comment.go
48.48% <0%> (+0.21%)
:arrow_up:

models/issue.go
51.06% <25%> (+0.37%)
:arrow_up:

models/issue_xref.go
54.5% <66.66%> (-1.86%)
:arrow_down:

modules/indexer/indexer.go
44.73% <0%> (-10.53%)
:arrow_down:

models/repo_list.go
74.27% <0%> (+0.97%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c4f9d06...a838473. Read the comment docs.

I'll test it this day ...

In theory this could be ported to 1.10.0.

this case does still produce redundancy:
create issue A
create issue B

from B reverence A
from B reverence A again
from B reverence A again

Result: same issue referenced in line ...
what i expect until there is a message in between no new reverence/update last rev

this case does still produce redundancy:
create issue A
create issue B

from B reverence A
from B reverence A again
from B reverence A again

Result: same issue referenced in line ...
what i expect until there is a message in between no new reverence/update last rev

I don't think I should remove that case. If the issue was referenced twice, IMHO there should be two lines with references. The md parsing code will eliminate references from quotes and code, so I think it's worth leaving them.
Even from the algorithm point of view, think of what would happen if the users decides to delete the first comment? Should I parse all comments and check again all possible references before I delete the corresponding one?
Besides, the reference is not the same: they each point to a different comment#snug

@lafriks can you review?

@guillep2k can you resolve conflicts thx

Conflicts solved

Make LG-TM work :)


Dependabot - parent ticket 520

User Story
As an engineer
I need/want/expect to keep the code base reasonably up to date
So that tooling does not become deprecated and difficult to work with.
Value / Purpose
Automated Dependabots create pull request showing outdated versions of the Terraform providers and modules, this has been left quite some time.
In this case Dependabot has yet to be configured.
Useful Contacts
No response
Additional Information
https://github.com/ministryofjustice/nvvs-devops/issues/520
Definition of Done
Example - [ ] Documentation has been written / updated

[ ] README has been updated
[ ] User docs have been updated
[ ] Another team member has reviewed
[ ] Tests are green

Not relavent now.


Update has-symbols to 1.0.2 to fix "global is not defined" when qs is used

https://github.com/inspect-js/has-symbols/blob/main/CHANGELOG.md#v102---2021-02-27

No update is needed, since ^ is used. You can update it yourself in your lockfile, or, npm install qs and it will install the newest version of its transitive dependencies.
The better fix is to fix your broken bundler (webpack 5, presumably) so it properly polyfills node globals.


Do not allow users with is_active=False to login

This introduces the SAML_FAIL_REDIRECT setting which allows for
redirecting the user after SAML authentication fails on the Django
side
Fix #27

Thank you! It's now available in 0.0.9 in pypi


Role in Python SDK is None, but is sectionHeader in the RestAPI

Package Name: azure-ai-formrecognizer
Package Version: 3.3.1
Operating System: Windows
Python Version: 3.9

Describe the bug
Using the document here https://portal.unifiedpatents.com/patents/patent/US-7551599-B2 when using the form recognizer studio it will return ABSTRACT in a paragraph with a role sectionHeader, however using the Python SDK it returns it as none.
To Reproduce
Steps to reproduce the behavior:

Use  azure_document_analyzer_instance.begin_analyze_document(
"prebuilt-layout", document=f, locale="en-US"
) where document is the patent, observe the output to see that the paragraph with ABSTRACT only has role type none.

Expected behavior
role type should be sectionHeader
Screenshots
If applicable, add screenshots to help explain your problem.
Additional context
Add any other context about the problem here.

Thanks for the feedback, we’ll investigate asap.

Hi @jaceaser , what's the service api version you are using in sdk and in studio?


Lastworkingversion

Please make sure these boxes are checked before submitting your pull request - thanks!

[ ] Run the unit tests with gradlew app:connectedGmsDebugAndroidTest to make sure you didn't break anything (with an emulator running or phone connected)

[ ] If you have multiple commits please combine them into one commit by squashing them.

Found the issue.


FEATURE REQUEST: MAKE THIS THEME ONE LINER LIKE SAFARI 15

PLEASE MAKE A MONTEREY VERSION FOR WINDOWS IF POSSIBLE

I also want that, badly :(

For me, the most difficult part is how to make active bar turn into URL field when clicked. I’ve seen a demo before, but it was way too complicated, so it might stop working with any Firefox update.

Can you make the theme without active bar turning into url…just make tabs and url bar in one line like this
https://raw.githubusercontent.com/vinceliuice/WhiteSur-gtk-theme/pictures/pictures/firefox.svg

Yep! Looking for the same thing. I can't find a good theme like that. Monterey style one liner looks the best and minimalist with bookmark hover. I hope u can do that, because i'm too dumb to make this work. Thx for the work, the theme is good, need some minor fixes.


Add grouped event schedule.

Probably need to tidy up some naming, and get the groups into the event schedule.

@wellcometrust/experience-dev out of WIP


Chat - On changing skin tone 6th time, emoji reduced to one

If you haven’t already, check out our contributing guidelines for onboarding and email<EMAIL_ADDRESS>to request to join our Slack channel!

Version Number: 9.0.31-14
Reproducible in staging?: Y
Reproducible in production?: Y
Issue reported by: Applause Internal Team
Action Performed:

Go to https://staging.new.expensify.com/home
Open a chat
Tap on emoticon plus reaction button( send a message & long press and react for the message so that you can see this button in conversation)
Now select thumbs up emoji
Change the skin tone
Now select thumbs up emoji in new skin tone
Repeat this and select thumbs up emoji in all 6 skin tone
Note in conversation we can see all 5 skin tone thumbs up emoji but on adding 6th skin tone it reduced to one emoji

Expected Result:
On changing skin tone 6th time, emoji must not be reduced to one.
Actual Result:
On changing skin tone 6th time, emoji reduced to one. 6th skin tone also unused one. It is not used 2nd time but reduced to one emoji.
Workaround:
Unknown
Platforms:

[x] Android: Native
[x] Android: mWeb Chrome
[ ] iOS: Native
[ ] iOS: mWeb Safari
[x] MacOS: Chrome / Safari
[ ] MacOS: Desktop

Screenshots/Videos
https://github.com/user-attachments/assets/e8f14691-8bea-4c38-a44d-b553c6a94bc6

View all open jobs on GitHub

@garrettmknight  FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors

I don't think this is worth fixing.


Mixing connector versions

The "Specify A Calendar" section specifies V3 of the Office365Outlook.GetEventsCalendarView connector, however the iconNextMonth and iconPrevMonth controls in the template page use V2. This breaks functionality, as the event properties have changed. For example:
.Subject → .subject
.Body → .body
.Location → .location
For the filtered event gallery to work, Start will need to be changed to startWithTimeZone, as converting start, which is now in UTC format, to ShortDate doesn't work. Here's the new Items property:
SortByColumns(Filter(MyCalendarEvents, Text(startWithTimeZone,ShortDate) = Text(_dateSelected,ShortDate)), "start")
Various properties elsewhere will need to be changed as well.

Document Details
⚠ Do not edit this section. It is required for learn.microsoft.com ➟ GitHub issue linking.

ID: 9451acad-432a-1f11-8204-238de8655846
Version Independent ID: 16134a5a-2880-4221-32b9-256f0573620b
Content: Calendar-screen template in canvas apps - Power Apps
Content Source: powerapps-docs/maker/canvas-apps/screen-templates/calendar-screen-overview.md
Service: powerapps
Sub-service: canvas-maker
GitHub Login: @emcoope-msft
Microsoft Alias: emcoope

Thanks for your comment, @JSpradlinZF. This issue has been assigned to the doc author for review.

@JSpradlinZF thank you for the feedback. I am will waiting on internal feedback to see if the V3 action for the connector.
Thanks,
Mints

@JSpradlinZF I spoke with my internal team and this is a know issue. For now, they are working on fixing this.
Thank you,
Mints


update sampling_n

Please make sure this branch doesn't break down your code @Lu-Neil. If it looks good to you, then just go ahead and merge it. Thanks!


[RL] [Ray] Update #568 errors

First of all, thank you for updating the Ray container to add checkpoint support, it was definitely missing and rather important.
Today I proceeded to test said modifications #568 , and a few things seem to be out of order:
Both checkpoint and outputs seem to be saved properly. However, the overall process fails, throwing the following:
TERMINATED trials:
- PPO_RoboschoolReacher-v1_0:#011TERMINATED [pid=92], 1774 s, 65 iter, 1638000 ts, 18.4 rew
Saved model configuration.
Traceback (most recent call last):
File "train-reacher.py", line 51, in <module>
MyLauncher().train_main()
File "/opt/ml/code/sagemaker_rl/ray_launcher.py", line 250, in train_main
launcher.launch()
File "/opt/ml/code/sagemaker_rl/ray_launcher.py", line 242, in launch
config=config)
File "/opt/ml/code/sagemaker_rl/ray_launcher.py", line 208, in save_checkpoint_and_serving_model
self.copy_checkpoints_to_model_output()
File "/opt/ml/code/sagemaker_rl/ray_launcher.py", line 183, in copy_checkpoints_to_model_output
raise RuntimeError("Failed to save checkpoint files - .tune_metadata or .extra_data")

As for the evaluation process, it too seems to be malfunctioning, not being able to retrieve checkpoints:
LocalMultiGPUOptimizer devices ['/cpu:0']
Traceback (most recent call last):
File "evaluate-ray.py", line 110, in <module>
run(args, parser)
File "evaluate-ray.py", line 79, in run
agent.restore(args.checkpoint)
File "/usr/local/lib/python3.6/dist-packages/ray/tune/trainable.py", line 253, in restore
self._restore(checkpoint_path)
File "/usr/local/lib/python3.6/dist-packages/ray/rllib/agents/ppo/ppo.py", line 153, in _restore
extra_data = pickle.load(open(checkpoint_path + ".extra_data", "rb"))
FileNotFoundError: [Errno 2] No such file or directory: '/opt/ml/input/data/model/checkpoint.extra_data'

All of the previous happened whilst running an exact copy of the repository, no changes have been included.
Side note 1 - Recall to modify the examples - available through SageMaker's notebook instances - to mirror the updates, otherwise some people might mistakenly bind their code to the old sources.
Side note 2 - Callbacks can be quite a useful tool as well, not sure if their support is planned.

Running a ray example for lunar lander (box2d) environment .. started with an earlier version of the SM RL container for ray-tesorflow-gpu and had this checkpoint error. I've attached the ray launcher code.
thought updating container to 0.6 or 0.65 will fix that.
With version 0.65 I get
Traceback (most recent call last):
File "train-lunarlander-PPO.py", line 10, in
from sagemaker_rl.ray_launcher import SageMakerRayLauncher
File "/opt/ml/code/sagemaker_rl/ray_launcher.py", line 13, in
from ray.rllib.agents.agent import get_agent_class

19:37:10
ImportError: cannot import name 'get_agent_class'
And with 0.6 I get
ImportError: cannot import name 'get_agent_class' (SAME ERROR)
train-lunarlander-PPO.py.zip

Hi,
It looks like you are using the old ray_launcher.py file.  Could you please check the file ../common/sagemaker_rl/ray_launcher.py and confirm if it's the same as https://github.com/awslabs/amazon-sagemaker-examples/blob/master/reinforcement_learning/common/sagemaker_rl/ray_launcher.py#L216 . If not, please try using the latest ray_launcher.py from the above link.

Lines 42 - 62 of the example given in the link pasted above looks the same to me as our launched code below:
Again, we have the same issue as the original post here, and we are trying to get around it by setting checkpoint frequency. However, the way the launcher code is structured, it doesn't seem like it will take user parameters for certain fields. This is confirmed in the TODO
    # TODO: move this to before customer-specified so they can override
    hyperparams_dict["rl.training.local_dir"] = INTERMEDIATE_DIR
    hyperparams_dict["rl.training.checkpoint_at_end"] = True
    hyperparams_dict["rl.training.checkpoint_freq"] = config['training'].get('checkpoint_freq', 10)

import json
import os
import gym
import ray
from ray.tune import run_experiments
from ray.tune.registry import register_env
import roboschool
from sagemaker_rl.ray_launcher import SageMakerRayLauncher
def create_environment(env_config):
# This import must happen inside the method so that worker processes import this code
import roboschool
return gym.make('LunarLander-v2')
class MyLauncher(SageMakerRayLauncher):
def register_env_creator(self):
    register_env("LunarLander-v2", create_environment)

def get_experiment_config(self):
    return {
      "training": {
        "env": "LunarLander-v2",
        "run": "PPO",
        "checkpoint_freq":100000, # Tried 1, 0 and 10000 doesn't work
        "stop": {
            "episode_reward_mean": 0,
            "training_iteration": 50,
        },
        "config": {
          "num_sgd_iter": 50,
          "lr": 5e-5,
          "lambda":0.896973,
          "vf_loss_coeff":0.786165,
          "kl_target":0.01,
          "kl_coeff":0.62396,
          "entropy_coeff":0.001268,
          "clip_param":0.384411,
          "sgd_minibatch_size": 5000,
          "train_batch_size": 25000,
          "monitor": True,  # Record videos.
          "model": {
            "free_log_std": True
          },
          "num_workers": (self.num_cpus-1),
          "num_gpus": self.num_gpus,
          "batch_mode": "complete_episodes",
        }
      }
    }

if name == "main":
MyLauncher().train_main()

Hi,
What Ray version did you use? Can you please try both including the checkpoint_freq option and using latest ray_luancher on the robomaker-ray example and paste the error?

Changed container to 0.6.5
Replaced entire ray launcher file in common subdirectory with https://github.com/awslabs/amazon-sagemaker-examples/blob/master/reinforcement_learning/common/sagemaker_rl/ray_launcher.py
commented out checkpoint save line #322

now works!

Cool. If you do want to save checkpoint the set up hosting, please make sure the stop criteria is set up appropriately, so that at least one checkpoint gets saved before the job finishes / gets stopped.


Bug: Hover tooltips in repo/contributors graph should match color of repo/user block

Describe the bug
The hover tooltips in repo/contributors graph should match colour of repo/user block.
Steps to reproduce

Navigate to a list activity page, e.g. https://app.opensauced.pizza/lists/04a518a0-87f7-47ad-89e9-784f4b376941/activity
Hover over a repository in the graph.
Notice the little square in the hover tooltip is not the same colour as the same as the square (repo/contributor) that it's hovering over.

Browsers
No response
Additional context (Is this in dev or production?)
No response
Code of Conduct

[X] I agree to follow this project's Code of Conduct

Contributing Docs

[X] I agree to follow this project's Contribution Docs

.take


Add add-all-kernels-clean function

This allows to easily add all kernels and regenerate the initrds for them
Fixes https://github.com/openSUSE/sdbootutil/issues/35
The name of the function is still quite long, but is easier to understand.
If a shorter name is preferred, this can be changed ofc :)
Command tested on Tumbleweed

just mkinitrd? even if it also installs kernels?

just mkinitrd? even if it also installs kernels?

renamed it :)


bug(Voice Disconnect): Unexpected error response

Describe the bug
A user is not present in the voice channel but then to bot is sending an error as well as a success message in response.
To Reproduce
Steps to reproduce the behavior:

Use the command on someone who is not connected to the voice channel.
Bot will respond with an error as well as a success message.

Expected behavior
The bot should only send the error message in response.
Screenshots

Additional context
Add any other context about the problem here.

(Prefer to use Github Commits)

Fixed in fddb025


Created Dataloader function for UCImultifeature dataset and unit tests

I didn't even realize the notebook was still in this PR. I didn't mean to include that at all. I'll make a new one as an example of how to use this and include it in the examples folder


Revert "Bump vite from 3.1.4 to 3.1.5"

Reverts carlosedp/rvasmweb#4

Until https://github.com/stafyniaksacha/vite-plugin-fonts/issues/31 is solved.


postinstall shouldn't run npm uninstall

I'm submitting a bug report

Library Version:
1.0.0

Please tell us about your environment:

Operating System:
OSX 10.x

Node Version:
7.7.1

NPM Version:
5.0.1

JSPM OR Webpack AND Version
webpack 2.4.1

Browser:
all

Language:
TypeScript 2.3.1

Current behavior:
The aurelia-validation npm package has a postinstall hook which runs npm uninstall for a set of packages. We've recently upgraded to npm 5 which seems to first install all the packages including any development dependencies. We're working with our own npm feed thus it fails to find some of the development dependencies since we don't need those ourselves.
Expected/desired behavior:

I think the postinstall hook shouldn't be uninstalling packages in the first place. If they aren't needed they shouldn't be a dependency in the first place. What's the reasoning behind uninstalling these packages in the postinstall hook?

What is the expected behavior?
npm install works in our environment without having to put all the dev dependencies for aurelia-validation into our own feed.

What is the motivation / use case for changing the behavior?
More consistent and faster installations of the package.

Hi @jmezach!
I can answer your question, one of the dependencies called @typedoc installs these typings what are not required by us and therefore the post install script. These are removed because they can cause typescript errors in your project. You can take a look at this pr and below the issues at typedoc that why they had to put the typings in to dependencies.
https://github.com/TypeStrong/typedoc/pull/434


Waiter API - Split the bill by total

Done when multiple bills exist with the correct amounts

splitBillByTotalTest: 18min

13 minutes- updating tests

10 min- implementation

5 min- round price to two decimal places


Have message fees paid by senders

We're almost done. Just need to make grants easy to compute then mandatory.


ref prop is missing

It seems that the type of the ReactFlow component is a bit broken in v12 since it doesn't show the ref prop anymore.

fixed in 12.0.0-next.12


Why does .accordian have overflow-anchor: none;?

If you inspect bootstrap 4.6 accordian you will see the following:

.accordion {
    overflow-anchor: none;
}

What's the point of that? Why would you not want overflow-anchor: auto? Suppose you got a lot of images in the accordion panel, wouldn't you want the viewport set to the content you are reading, when those pictures load?

https://github.com/twbs/bootstrap/pull/31347 and https://github.com/twbs/bootstrap/pull/31346


Error testing the plugin (System.NullReferenceException: Object reference not set to an instance of an object.) FOR App

I do all for use the pluging media to take photos, my frist issues it when y install  the  CurrentActivity don't create the class main application, but i read and create the file, then when  i trie to test mi aplication the LoadApplication(new App()); on mi file MainActivity show that error.
I don´t know why
Version Number of Plugin: 3.1.3
Device Tested On: Android 4.4 Samsung
Version of VS: 2017

I have the same problem.

same problem :(

Did you install the nuget into all projects. You can run the samples and see how to set it up.

Did anyone manage to fix this issue?
It occurs on Android only


Use ALSA config to define PCM initial volume and codec

I think both these changes are "nice to have" additions rather than essential function. The volume config works well for me, but the codec config is largely untested as I do not have access to suitable devices - it is tested only with A2DP playback with SBC and aptX.

I pushed a commit with the simple changes done. The codec refactoring will take a little longer, I'll come back to it when I have more free time.

he codec refactoring will take a little longer, I'll come back to it when I have more free time.

OK, no hurry. In the mean time I'll try to move select_codec() function into the shared folder (+ small cleanup).

... actually I've already done a first draft of the refactoring, just won't be able to test it until tomorrow. It allows case-insensitive codec name matching, with aliases, and also accepts a codec configuration as a hex string appended to the codec name. I've used a slightly different signature for select-codec() than your suggestion, but otherwise I think it covers all your recommendations. Will push a new commit tomorrow, unless I get some serious failure in testing, I still can't properly test though, so it is possible some mistakes may slip through. I should have some more time for any required revisions next week.

It allows case-insensitive codec name matching, with aliases, and also accepts a codec configuration as a hex string appended to the codec name

OK, great.
OK, so I will wait until you will push your changes, Than I will merge my small "cleanups" with your commits.

One additional thought. Since there will be a possibility to control volume
and mute, maybe it would be worth adding parameter for software-volume. If
no such parameter, then soft-vol will not be changed, and when given it
will be updated before opening PCM. What do you think? With such options
for alsa there will be no need for adding per-device configuration into the
bluealsa service.

I did not need to add codec names to the client header file, so perhaps I have not correctly understood your idea. However, here is my shot at refactoring the duplicated code. I have added softvol support and codec config support.

I did not need to add codec names to the client header file, so perhaps I have not correctly understood your idea.

Scratch my idea. I was thinking out loud without revising my stream of thoughts :D With aliasing there will be no (hard) need for codec names in header file.
I will review your latest commit but maybe tomorrow evening or on Monday evening because I might have busy Sunday...

I've drafted some updates for the wiki to document the features in this PR. It is currently visible here:
https://github.com/borine/bluez-alsa/wiki/Using-the-BlueALSA-ALSA-PCM-Plugin

I've drafted some updates for the wiki to document the features in this
PR.

Great. Also, sorry for not giving you any more feedback regarding this PR,
but currently I've got no time for any open-source activity. Unfortunately,
this will last at least until the end of this month. I'd try to do a second
round review at the beginning of September. And I will have to try it
myself (I have not done this yet). Also, I'm struggling whether codec name
correction bluealsa_codec_get_canonical_name() should be embedded into
the bluealsa_dbus_pcm_select_codec() function. My thoughts are that the
dbus-client.h API should reflect the D-Bus API. So, maybe the
bluealsa_codec_get_canonical_name() can be also in the dbus-client.h but as
a separate function which one can call explicitly. I have not made up my
mind yet, though.

Ok. An advantage of making bluealsa_codec_get_canonical_name() accessible to clients is that the plugin would be able to properly check whether the codec needs to be changed. At present it does a simple strcasecmp() which obviously does not match aliases.
I also have another PR just about ready which I think makes some important improvements to both plugins. I will wait until this PR is finally settled before raising that one, however the code is visible in my fork here:
https://github.com/borine/bluez-alsa/tree/alsa-disconnect-improvements
with some draft user notes for the CTL change here:
https://github.com/borine/bluez-alsa/wiki/Using-the-BlueALSA-ALSA-CTL-Plugin.

An advantage of making bluealsa_codec_get_canonical_name()
accessible to clients is that the plugin would be able to properly
check whether the codec needs to be changed.

This check is already done in the BlueALSA service. I'm not sure whether it
will make any difference in robustness if D-Bus communication is skipped.
And beside the codec name check, BlueALSA also compares used A2DP
configuration. I think that the bluealsa_codec_get_canonical_name() is more
like UI enhancement than codec selection logic.

Finally, I'm back from long vacations :D In the meantime, I've tested this PR and it works nicely. I've updated code style a little bit + some minor fixes. In the final version I've decoupled bluealsa_dbus_pcm_select_codec() and get_codec_canonical_name() which should allow some flexibility in the future (maybe it will never be used, but it's nice to have an option).
PS.
In order to spot more warnings, please compile code with -Wall -Werror. Since it's very easy to forget about this I've got something like this in my ~/.profile file:
export CFLAGS="${CFLAGS} -Wall -Wextra"
export CXXFLAGS="${CFLAGS}"


Run meteor on chromecast

Would it be possible to get this running on chromecast similar to greenscreen from groupon? https://github.com/groupon/greenscreen

Hi John ( @thatgibbyguy )
thanks to bring that idea in. I will have a look on the greenscreen project and come back to you.
Cheers
Tom

its running on Node.js so its seems like it could be possible. You can compile a meteor app into a node app.

green screen looks like your hosting the app and pushing instructions to the cast device to update the system to run the url you want to run on it.


Implement .d.ts type definitions

Let's write some .d.ts type definition file to leverage auto-completion from VSCode and other editor that use TypeScript as auto completion back end.
Note:

How to write .d.ts file: http://www.typescriptlang.org/docs/handbook/declaration-files/templates.html
How to include definition file with node module: http://www.typescriptlang.org/docs/handbook/declaration-files/publishing.html

Implemented in #11


missing train.list file

Following the instruction of preparing data,  cannot find examples/csmsc/data/filelists/train.list. I wonder how to generate this file, Thank you.

Thanks for your feedback. I have uploaded corresponding list files.

Thanks for updating the repo.


Add combine data window

Resolves #86
Lots of style issues in here. I'll need suggestions because I literally can not use css. Aside from that, most of the js has worked in testing. (I have not done enough for this PR to be accepted yet)

[x] Test javascript code with malformed json files and improper json files.
[x] Change place csv files are saved to. (Another localStorage section?)

Congrats on PR #:100:

My recommendation on this would be to incorporate ALL the data processing into the View Data section. Also, yeah, don't worry about making the button red.

Tasks complete.

This is satisfactory. There are a couple things I'd like to change though, I will open them issues of their own in a minute.


Issues with TypeScript exactOptionalPropertyTypes

Describe the bug
The same as mentioned here and here: with 'exactOptionalPropertyTypes: true'. Consider adding undefined to the types of the target's properties.
To Reproduce
Steps to reproduce the behavior:
const Example = classed('div', '', {
  variants: {
    size: {
      lg: '',
      sm: '',
    },
  },
})

Example({
  size: undefined // << here
})

Expected behavior
I should be able to pass undefined (implicitly and explicitly).
Screenshots

Environment? (please complete the following information):

OS: N/A
Browser N/A
Node.js N/A
Version 1.6.1

Thanks for brining this to my attention! Seems a lot of libs have forgotten about this type, even stitches. Fixing in same release as #131


Create documentation and sample for sharing the same transitive platform dependency

Describe best practice for managing and sharing upstream dependencies like Crashalytics that's being used both by the platform and Flutter.
cc @jmagman @RedBrogdon

Part of the work is figuring out the matrix as well for subproject/aar/cocoapods/framework.

I made a simple demo with https://github.com/xster/flutter-test/tree/master/t154_flutter_crashlytics and https://github.com/xster/flutter-test/tree/master/t154_android_crashlytics though it's still good to document it more systematically.

Good to check on iOS first too but if there aren't too much specific coding needed to accomplish this, it could just be some additional text instructions on the flutter.dev website.

Tagging @jmagman for the iOS part of the doc

Tentatively assigning to @jmagman for the iOS part

@jmagman, if this is a flutter.dev documentation issue, we can move the issue to the website repo. Is there more to it?

@sfshaza2 yes I think it can be moved.  It's now tracking writing an iOS version of https://flutter.dev/docs/development/add-to-app/android/plugin-setup.


Bug fix were uhf was always 0 if a fixed charge were given

If a fixed charge was given, the uhf were set to 0 every time. This is now fixed by calculating the uhf for the molecule.

Then, let's just do it correctly and bring the following workflow from set_random_charge into a form in which it just calls calculate_ligand_electrons and calculate_uhf.
        ln_protons = 0
        ac_protons = 0
        for atom in ati:
            if atom in get_lanthanides():
                if atom < 64:
                    uhf += atom - 56
                else:
                    uhf += 70 - atom
                ln_protons += (
                    atom - 3 + 1
                )  # subtract 3 to get the number of protons in the Ln3+ ion
            elif atom in get_actinides():
                if atom < 96:
                    uhf += atom - 88
                else:
                    uhf += 102 - atom
                ac_protons += (
                    atom - 3 + 1
                )  # subtract 3 to get the number of protons in the Ln3+ ion
        ligand_protons = nel - ln_protons - ac_protons

Suggestion
Use ati_to_atlist within the function call, from PR https://github.com/grimme-lab/MindlessGen/pull/81.
uhf = calculate_uhf(ati_to_atlist(ati))

or similar.


Lint rules

that's an application on what is required by those rules. few examples:

prefer final
use const when possible
sort imports
classes must follow some ground rules on how and where to put memebrs or constructor
return types must be used
prefer package imports instead of relatives
indentations
trailing commas
documentation of public members
many many more

@eopeter do you know what's going on with the Lint Code Base?

@eopeter do you know what's going on with the Lint Code Base?
If I run flutter analyze --fatal-infos I see only this instead of all the basic thing github action found

It seems it is not aware of Flutter Library

@eopeter do you know what's going on with the Lint Code Base?
If I run flutter analyze --fatal-infos I see only this instead of all the basic thing github action found

It seems it is not aware of Flutter Library

mmm how can I fix this?


ConnectionResetError not caught in websocket_safe_read

Ran into an issue when letting my SlackClient run for extended period of time, received the below stack trace. It seems that in send_to_websocket() we catch any exception and reconnect the client. However, when reading from the server via rtm_read() we do not catch any connection failures. Is this by design? Could we possibly catch a connection error in websocket_safe_read() or rtm_read() and reconnect?

...
File "/usr/local/lib/python3.5/site-packages/slackclient/_client.py", line 39, in rtm_read
json_data = self.server.websocket_safe_read()
File "/usr/local/lib/python3.5/site-packages/slackclient/_server.py", line 110, in websocket_safe_read
data += "{0}\n".format(self.websocket.recv())
File "/usr/local/lib/python3.5/site-packages/websocket/_core.py", line 298, in recv
opcode, data = self.recv_data()
File "/usr/local/lib/python3.5/site-packages/websocket/_core.py", line 315, in recv_data
opcode, frame = self.recv_data_frame(control_frame)
File "/usr/local/lib/python3.5/site-packages/websocket/_core.py", line 328, in recv_data_frame
frame = self.recv_frame()
File "/usr/local/lib/python3.5/site-packages/websocket/_core.py", line 360, in recv_frame
return self.frame_buffer.recv_frame()
File "/usr/local/lib/python3.5/site-packages/websocket/_abnf.py", line 312, in recv_frame
self.recv_header()
File "/usr/local/lib/python3.5/site-packages/websocket/_abnf.py", line 261, in recv_header
header = self.recv_strict(2)
File "/usr/local/lib/python3.5/site-packages/websocket/_abnf.py", line 346, in recv_strict
bytes = self.recv(min(16384, shortage))
File "/usr/local/lib/python3.5/site-packages/websocket/_core.py", line 429, in _recv
return recv(self.sock, bufsize)
File "/usr/local/lib/python3.5/site-packages/websocket/_socket.py", line 77, in recv
bytes = sock.recv(bufsize)
File "/usr/local/lib/python3.5/ssl.py", line 909, in recv
return self.read(buflen)
File "/usr/local/lib/python3.5/ssl.py", line 786, in read
return self._sslobj.read(len, buffer)
File "/usr/local/lib/python3.5/ssl.py", line 572, in read
v = self._sslobj.read(len or 1024)
ConnectionResetError: [Errno 104] Connection reset by peer

I tried turning on blocking on the websocket in order to avoid using polling (sleep(1) after each loop).   Hence the need for polling.
self.sc.server.websocket.sock.setblocking(1)
I wonder if this behavior is related to this issue?

Fixed in 2.1.0


refactor(@embark): template generator should use npm if downloaded template has package-lock.json

Previously, when using "development embark" (i.e. embark command in the monorepo) the template generator would always use yarn install to install a template's dependencies. However, if a template relies on package-lock.json, as is the case for embark-create-react-dapp-template, that behvaior can cause serious problems. So, have the choice of install command depend not only on whether we're using "development embark" but also whether the template has a package-lock.json file.
NOTE: this change can probably result in problems given that yarn install and npm install behave differently re: symlinks in node_modules. However, such problems would never show up with production installs of the embark packaage. Moreover, after dropping embarkjs-connector-web3 we don't presently have a situation where a monorepo package would be yarn linked into an instantiated template's node_modules. So, in effect, the changes introduced in this PR allow existing templates to work correctly whether using production or monorepo embark. The impending embark v5 refactor should deprecate embark new in favor of the yet unfinished embark init.

dependencies. However, if a template relies on package-lock.json, as is the case for embark-create-react-dapp-template, that behvaior can cause serious problems

Isn't yarn install ignoring package-lock.json altogether?

@PascalPrecht

Isn't yarn install ignoring package-lock.json altogether?

Yes, but the problem is that npm honoring package-lock vs yarn ignoring it can result in different node_modules trees. In the case of embark-create-react-dapp-template the effect was an installation that didn't work when I tried npm run start, i.e. the react-scripts package checked that versions of some packages it relies on didn't match the expected versions and it refused to start up.


Faster storage validator

This PR improves the performance of the storage validator; it introduces the following improvements:

remove the locks used by the validator and #[inline] 2 small, widely-used database methods (a tiny improvement)
use the COL_BLOCK_TRANSACTIONS column to obtain block's transactions in bulk as opposed to obtaining them individually via Ledger::get_transaction_bytes (~40% speed improvement for a database with a modest number of glitches, should be much more for a glitchy one)

There is still room for improvement by introducing partial transaction deserialization, but I don't know if it's viable yet; since the PR is already fairly large, I decided to open it, and further improvements - if any - will build on top of it.

@ljedrz looks good. Can you check that the MemDb implementation is receiving the requisite updates as well?

The in-memory implementation can't (or rather doesn't need to) be validated this way, so the MemDb impl doesn't need to be adjusted individually. That being said, fixing any logic-related bugs detected by the validator will automatically improve all the storage backends, so it's not being left out.

Sadly, partial deserialization doesn't seem to significantly improve the performance of the storage validator, and it makes it considerably more complex. However, the extra profiling led to https://github.com/AleoHQ/snarkVM/pull/287, which provides a small speed boost and makes the related code more idiomatic.


Add Dockerfile and publish image to ghcr.io

Per title, this PR seeks to add a dockerfile to build the container image of this repo.
I know goreleaser has an image building integration, but opted to not use that due to how simple it is. I wasn't sure there would be enough freedom to customize the image since it appears to mainly drop the binary in the image and go. Where as we will benefit from the image using bash to enable bash completion features.
This is related to these efforts for rancher: https://github.com/rancher/rancher/issues/43760

Updated per the advice now, thanks for the great idea to generate bash completion at build time!


Improve test coverage of simtools/ray_tracing.py

simtools/ray_tracing.py   has an unusual low test coverage and needs some additional unit tests.

Notice that the coverage was not that low to begin with when you include also the integration tests in the coverage measurement. Either way, the coverage is raised to 100% in #593.


Feature/pp 1027 implement backend report functionality

Description
This PR adds an AsyncTask database structure with associated facilities for pushing tasks onto a logical queue, pulling them for processing, and removing them when complete (by flagging them as complete as rather than deleting them).
Additionally it provides support for requesting for an inventory report to be generated asynchronously for a given library and user.
Finally it includes a script that runs every 15 minutes for pulling inventory report tasks off the queue, generating a CSV report for "Palace Marketplace", "BiblioBoard", "Unlimited Listens", and "Palace Bookshelf" titles, and then emailing them together to the requestor's email address.
Motivation and Context
https://ebce-lyrasis.atlassian.net/browse/PP-1027

How Has This Been Tested?

Checklist

[ ] I have updated the documentation accordingly.
[x] All new and existing tests passed.

@jonathangreen and @tdilauro :  for the life of me I can't figure out why the migration is failing.  I tried reworking the migration to simply add a single table with a single primary key and no other fields,  but it doesn't seem to work.  The table is being detected as removed after that upgrade operation. Strangely it works when I run against a copy of minotaur.   Do either of you guys have any suggestions how to sort this out?

@dbernstein I believe its because your new tables are not being imported in core/model/__init__.py, so the migration script does not know they exist.
https://github.com/ThePalaceProject/circulation/blob/24900ec757e6aa171281525f57f8ce08b877ab94/core/model/__init__.py#L513-L516

@jonathangreen :  thanks for the reviews on this one.  I redid the integration query,  removed the pg_advisory_lock and made a note about race conditions.


Publish API documents to a standalone site.

If we can generate API documents when CI build gitea, and publish to a standalone site. That we can use a standalone subdomain for API documents but not link to https://try.gitea.io .

Moved to https://gitea.com/gitea/gitea-docusaurus/issues/14


Compile error for ESP32S3 on fresh checkout - config.h not found

I wass following the steps from here:
https://wiki.seeedstudio.com/SenseCAP_Indicator_Application_Home_Assistant/
And got the following error when compiling
idf.py -p /dev/ttyUSB0 build flash monitor
In file included from /home/paul/Documents/git/sensecap-indicator-ha/main/indicator_enabler.h:18,
                 from /home/paul/Documents/git/sensecap-indicator-ha/main/main.c:38:
/home/paul/Documents/git/sensecap-indicator-ha/main/app/indicator_mqtt.h:17:10: fatal error: config.h: No such file or directory
   17 | #include "config.h"
      |          ^~~~~~~~~~

If this file is created with 'touch'
touch /home/paul/Documents/git/sensecap-indicator-ha/main/app/config.h
than the compile, install, monitor works
idf.py -p /dev/ttyUSB0 build flash monitor

use v5.1 idf version


Health status column - Resolve the conflicting and redundant information on the health status column?

We have some conflicting combined information like "Cancer::normal" and "none::unknown", but also redundant info like "Adenocarcinoma ampulla of vater::cancer"; "Fatty Liver Disease::intrahepatic Metastasis"

We fixed most of those issues. For some entries in DEEP and KNIH we could not find a solution.

Most of these should also be resolved by #70

There are no more cases like this


Update pipeline version to the 1.0.0

update export PIPELINE_VERSION=0.5.1 to point to 1.0.0 instead of the old version 0.5.1

/ok-to-test

master branch is already 1.0.0 https://github.com/kubeflow/website/blob/master/layouts/shortcodes/pipelines/latest-version.html

master branch is already 1.0.0 https://github.com/kubeflow/website/blob/master/layouts/shortcodes/pipelines/latest-version.html

sorry your right, got confused since https://www.kubeflow.org/docs/pipelines/installation/standalone-deployment/#deploying-kubeflow-pipelines is still showing 0.5.1 . Why is that @Bobgy ?

kubeflow.org is not showing master, because everyone is working on kubeflow 1.1

aa ok thnx!


Update Python client

@christopher-lowrie PTAL

@jpcedenog let's discuss on Friday or after soft-close.  It's likely fine, I'd just like to know how you did it and how to QA all these generated files

Documentation was not generated correctly. Another PR will be open to fix this.


Can't build from Visual Studio 2012

Building the solution from within Visual Studio 2012 gives the following output:
1>------ Build started: Project: Paket.Core, Configuration: Debug Any CPU ------
2>------ Build started: Project: Paket.Bootstrapper, Configuration: Debug Any CPU ------
1>	"C:\Users\jni\prj\github\Paket\.paket\paket.exe" restore --references-files "C:\Users\jni\prj\github\Paket\src\Paket.Core\paket.references"
2>  Paket.Bootstrapper -> C:\Users\jni\prj\github\Paket\bin\paket.bootstrapper.exe
1>	Paket version <IP_ADDRESS>
1>	1 second - ready.
1>C:\Program Files (x86)\Microsoft SDKs\F#\3.1\Framework\v4.0\Microsoft.FSharp.Targets(155,9): error MSB4127: The "Fsc" task could not be instantiated from the assembly "C:\Program Files (x86)\Microsoft SDKs\F#\3.1\Framework\v4.0\FSharp.Build.dll". Please verify the task assembly has been built using the same version of the Microsoft.Build.Framework assembly as the one installed on your computer and that your host application is not missing a binding redirect for Microsoft.Build.Framework. Unable to cast object of type 'Microsoft.FSharp.Build.Fsc' to type 'Microsoft.Build.Framework.ITask'.
1>C:\Program Files (x86)\Microsoft SDKs\F#\3.1\Framework\v4.0\Microsoft.FSharp.Targets(155,9): error MSB4060: The "Fsc" task has been declared or used incorrectly, or failed during construction. Check the spelling of the task name and the assembly name.
1>Done building project "Paket.Core.fsproj" -- FAILED.
1>
1>Build FAILED.
StopOnFirstBuildError: Build cancelled because project "Paket.Core" failed to build.
Build has been canceled.

Running e.g. .\build.cmd RunTests from the command line works fine.

sorry, but we don't support VS2012 for paket's own project.


The DINE policy for DNS record creation does not work for RSV where region code is part of DNS zone name

If using RSV for Azure Backup in multiple regions, there is no check to ensure that the DNS records is created in the correct Private DNS zone. If two or more policies are assigned using the same SubResource/GroupId then DNS records will be created randomly in the different private DNS zones, e.g. in privatelink.we.backup.windowsazure.com and in privatelink.sdc.backup.windowsazure.com.
If an additional check is added on location for the private endpoint itself in the policy, then it works. See example here:
https://github.com/norregaard/Azure/blob/main/Policy/Auto-create-DNS-record-private-DNS-zone.json

Document Details
⚠ Do not edit this section. It is required for learn.microsoft.com ➟ GitHub issue linking.

ID: 2bd28f7b-1764-83c9-9d82-d65ba75bcb94
Version Independent ID: e91679fb-9d61-7f89-5cb6-238e2eb91757
Content: Private Link and DNS integration at scale - Cloud Adoption Framework
Content Source: docs/ready/azure-best-practices/private-link-and-dns-integration-at-scale.md
Service: cloud-adoption-framework
Sub-service: ready
GitHub Login: @JefferyMitchell
Microsoft Alias: martinek

Thank you for your feedback.  We have created internal ticket 72717 to track and investigate this issue.

#please-close