Stuck in setup

Steps to reproduce
Deployment of a Shop through shopware helm chart
What should happened?
The setup job should pass
What actually happened?
The setup job is instantly deleted (and the pod killed) after creation, leaving the operator stuck in the setup stage.
I1127 18:41:21.032202       1 leaderelection.go:260] successfully acquired lease my-shop/d79142e5.shopware.com
2024-11-27 18:41:21    [DEBUG]    events    shopware-operator-5b8dfc5f8f-ctmz8_b033fa7b-3577-4bce-9362-4281a886aaaf became leader    {"type": "Normal", "object": {"kind":"Lease","namespace":"my-shop","name":"d79142e5.shopware.com","uid":"6c33bfe3-8dca-4893-897d-88b1e00ec547","apiVersion":"coordination.k8s.io/v1","resourceVersion":"513755298"}, "reason": "LeaderElection"}
2024-11-27 18:41:21    [INFO]    Starting EventSource    {"controller": "store", "controllerGroup": "shop.shopware.com", "controllerKind": "Store", "source": "kind source: *v1.Store"}
2024-11-27 18:41:21    [INFO]    Starting EventSource    {"controller": "store", "controllerGroup": "shop.shopware.com", "controllerKind": "Store", "source": "kind source: *v1.Secret"}
2024-11-27 18:41:21    [INFO]    Starting EventSource    {"controller": "store", "controllerGroup": "shop.shopware.com", "controllerKind": "Store", "source": "kind source: *v1.Deployment"}
2024-11-27 18:41:21    [INFO]    Starting EventSource    {"controller": "store", "controllerGroup": "shop.shopware.com", "controllerKind": "Store", "source": "kind source: *v1.Job"}
2024-11-27 18:41:21    [INFO]    Starting EventSource    {"controller": "store", "controllerGroup": "shop.shopware.com", "controllerKind": "Store", "source": "kind source: *v1.Secret"}
2024-11-27 18:41:21    [INFO]    Starting Controller    {"controller": "store", "controllerGroup": "shop.shopware.com", "controllerKind": "Store"}
2024-11-27 18:41:21    [INFO]    Starting workers    {"controller": "store", "controllerGroup": "shop.shopware.com", "controllerKind": "Store", "worker count": 1}
2024-11-27 18:41:21    [INFO]    Do reconcile on store because db secret has changed    {"Store": "my-shop"}
2024-11-27 18:41:21    [INFO]    my-shop    Do reconcile on store    {"controller": "store", "controllerGroup": "shop.shopware.com", "controllerKind": "Store", "Store": {"name":"my-shop","namespace":"my-shop"}, "namespace": "my-shop", "name": "my-shop", "reconcileID": "8f480550-5d3b-4023-b9e1-8a1570c38276", "state": "setup"}
2024-11-27 18:41:21    [INFO]    my-shop    reconcile app secrets    {"controller": "store", "controllerGroup": "shop.shopware.com", "controllerKind": "Store", "Store": {"name":"my-shop","namespace":"my-shop"}, "namespace": "my-shop", "name": "my-shop", "reconcileID": "8f480550-5d3b-4023-b9e1-8a1570c38276", "state": "setup"}
2024-11-27 18:41:21    [DEBUG]    events    Update Store my-shop setup job in namespace my-shop. Diff hash    {"type": "Normal", "object": {"kind":"Store","namespace":"my-shop","name":"my-shop","uid":"0cd29409-5b25-4e5e-ac71-89e86a48dc7b","apiVersion":"shop.shopware.com/v1","resourceVersion":"513754547"}, "reason": "Diff setup job hash"}
2024-11-27 18:41:21    [INFO]    my-shop    Wait for setup to finish    {"controller": "store", "controllerGroup": "shop.shopware.com", "controllerKind": "Store", "Store": {"name":"my-shop","namespace":"my-shop"}, "namespace": "my-shop", "name": "my-shop", "reconcileID": "8f480550-5d3b-4023-b9e1-8a1570c38276", "state": "setup"}
2024-11-27 18:41:21    [INFO]    Reconcile finished    {"controller": "store", "controllerGroup": "shop.shopware.com", "controllerKind": "Store", "Store": {"name":"my-shop","namespace":"my-shop"}, "namespace": "my-shop", "name": "my-shop", "reconcileID": "8f480550-5d3b-4023-b9e1-8a1570c38276"}
2024-11-27 18:41:21    [INFO]    Found container for job `shopware-setup`    {"controller": "store", "controllerGroup": "shop.shopware.com", "controllerKind": "Store", "Store": {"name":"my-shop","namespace":"my-shop"}, "namespace": "my-shop", "name": "my-shop", "reconcileID": "8f480550-5d3b-4023-b9e1-8a1570c38276"}
2024-11-27 18:41:21    [INFO]    Job not terminated still running    {"controller": "store", "controllerGroup": "shop.shopware.com", "controllerKind": "Store", "Store": {"name":"my-shop","namespace":"my-shop"}, "namespace": "my-shop", "name": "my-shop", "reconcileID": "8f480550-5d3b-4023-b9e1-8a1570c38276"}
2024-11-27 18:41:21    [INFO]    Update store status    {"controller": "store", "controllerGroup": "shop.shopware.com", "controllerKind": "Store", "Store": {"name":"my-shop","namespace":"my-shop"}, "namespace": "my-shop", "name": "my-shop", "reconcileID": "8f480550-5d3b-4023-b9e1-8a1570c38276", "status": {"state":"setup","conditions":[{"type":"setup","lastTransiti
onTime":null,"lastUpdatedTime":"2024-11-27T18:41:21Z","message":"Waiting for setup job to finish (Notice sidecars are counted). Active jobs: 0, Failed jobs: 0","status":"True"}]}}
2024-11-27 18:41:21    [INFO]    my-shop    Do reconcile on store    {"controller": "store", "controllerGroup": "shop.shopware.com", "controllerKind": "Store", "Store": {"name":"my-shop","namespace":"my-shop"}, "namespace": "my-shop", "name": "my-shop", "reconcileID": "5a9d1b84-b146-4eb1-9f1b-aa6568c7de81", "state": "setup"}
2024-11-27 18:41:21    [INFO]    my-shop    reconcile app secrets    {"controller": "store", "controllerGroup": "shop.shopware.com", "controllerKind": "Store", "Store": {"name":"my-shop","namespace":"my-shop"}, "namespace": "my-shop", "name": "my-shop", "reconcileID": "5a9d1b84-b146-4eb1-9f1b-aa6568c7de81", "state": "setup"}
2024-11-27 18:41:21    [DEBUG]    events    Update Store my-shop setup job in namespace my-shop. Diff hash    {"type": "Normal", "object": {"kind":"Store","namespace":"my-shop","name":"my-shop","uid":"0cd29409-5b25-4e5e-ac71-89e86a48dc7b","apiVersion":"shop.shopware.com/v1","resourceVersion":"513754547"}, "reason": "Diff setup job hash"}
2024-11-27 18:41:31    [INFO]    my-shop    Wait for setup to finish    {"controller": "store", "controllerGroup": "shop.shopware.com", "controllerKind": "Store", "Store": {"name":"my-shop","namespace":"my-shop"}, "namespace": "my-shop", "name": "my-shop", "reconcileID": "5a9d1b84-b146-4eb1-9f1b-aa6568c7de81", "state": "setup"}
2024-11-27 18:41:31    [INFO]    Reconcile finished    {"controller": "store", "controllerGroup": "shop.shopware.com", "controllerKind": "Store", "Store": {"name":"my-shop","namespace":"my-shop"}, "namespace": "my-shop", "name": "my-shop", "reconcileID": "5a9d1b84-b146-4eb1-9f1b-aa6568c7de81"}
2024-11-27 18:41:31    [ERROR]    job not found in container: shopware-setup    {"controller": "store", "controllerGroup": "shop.shopware.com", "controllerKind": "Store", "Store": {"name":"my-shop","namespace":"my-shop"}, "namespace": "my-shop", "name": "my-shop", "reconcileID": "5a9d1b84-b146-4eb1-9f1b-aa6568c7de81", "error": "job not found in container: shopware
-setup"}
github.com/shopware/shopware-operator/internal/job.IsJobContainerDone
    /home/runner/work/shopware-operator/shopware-operator/internal/job/util.go:89
github.com/shopware/shopware-operator/internal/controller.(*StoreReconciler).stateSetup
    /home/runner/work/shopware-operator/shopware-operator/internal/controller/status.go:232
github.com/shopware/shopware-operator/internal/controller.(*StoreReconciler).reconcileCRStatus
    /home/runner/work/shopware-operator/shopware-operator/internal/controller/status.go:63
github.com/shopware/shopware-operator/internal/controller.(*StoreReconciler).Reconcile.func1
    /home/runner/work/shopware-operator/shopware-operator/internal/controller/store_controller.go:107
github.com/shopware/shopware-operator/internal/controller.(*StoreReconciler).Reconcile
    /home/runner/work/shopware-operator/shopware-operator/internal/controller/store_controller.go:132
sigs.k8s.io/controller-runtime/pkg/internal/controller.(*Controller).Reconcile
    /home/runner/go/pkg/mod/sigs.k8s.io/controller-runtime@v0.16.3/pkg/internal/controller/controller.go:119
sigs.k8s.io/controller-runtime/pkg/internal/controller.(*Controller).reconcileHandler
    /home/runner/go/pkg/mod/sigs.k8s.io/controller-runtime@v0.16.3/pkg/internal/controller/controller.go:316
sigs.k8s.io/controller-runtime/pkg/internal/controller.(*Controller).processNextWorkItem
    /home/runner/go/pkg/mod/sigs.k8s.io/controller-runtime@v0.16.3/pkg/internal/controller/controller.go:266
sigs.k8s.io/controller-runtime/pkg/internal/controller.(*Controller).Start.func2.2
    /home/runner/go/pkg/mod/sigs.k8s.io/controller-runtime@v0.16.3/pkg/internal/controller/controller.go:227
2024-11-27 18:41:31    [INFO]    Update store status    {"controller": "store", "controllerGroup": "shop.shopware.com", "controllerKind": "Store", "Store": {"name":"my-shop","namespace":"my-shop"}, "namespace": "my-shop", "name": "my-shop", "reconcileID": "5a9d1b84-b146-4eb1-9f1b-aa6568c7de81", "status": {"state":"setup","conditions":[{"type":"setup","lastTransiti
onTime":null,"lastUpdatedTime":"2024-11-27T18:41:31Z","message":"Waiting for setup job to finish","reason":"job not found in container: shopware-setup","status":"Error"}]}}
2024-11-27 18:41:31    [INFO]    my-shop    Do reconcile on store    {"controller": "store", "controllerGroup": "shop.shopware.com", "controllerKind": "Store", "Store": {"name":"my-shop","namespace":"my-shop"}, "namespace": "my-shop", "name": "my-shop", "reconcileID": "705040e8-3343-4517-a1d1-f55d68f24e7e", "state": "setup"}
2024-11-27 18:41:31    [INFO]    my-shop    reconcile app secrets    {"controller": "store", "controllerGroup": "shop.shopware.com", "controllerKind": "Store", "Store": {"name":"my-shop","namespace":"my-shop"}, "namespace": "my-shop", "name": "my-shop", "reconcileID": "705040e8-3343-4517-a1d1-f55d68f24e7e", "state": "setup"}
2024-11-27 18:41:31    [DEBUG]    events    Update Store my-shop setup job in namespace my-shop. Diff hash    {"type": "Normal", "object": {"kind":"Store","namespace":"my-shop","name":"my-shop","uid":"0cd29409-5b25-4e5e-ac71-89e86a48dc7b","apiVersion":"shop.shopware.com/v1","resourceVersion":"513755310"}, "reason": "Diff setup job hash"}
2024-11-27 18:41:41    [INFO]    my-shop    Wait for setup to finish    {"controller": "store", "controllerGroup": "shop.shopware.com", "controllerKind": "Store", "Store": {"name":"my-shop","namespace":"my-shop"}, "namespace": "my-shop", "name": "my-shop", "reconcileID": "705040e8-3343-4517-a1d1-f55d68f24e7e", "state": "setup"}
2024-11-27 18:41:41    [INFO]    Reconcile finished    {"controller": "store", "controllerGroup": "shop.shopware.com", "controllerKind": "Store", "Store": {"name":"my-shop","namespace":"my-shop"}, "namespace": "my-shop", "name": "my-shop", "reconcileID": "705040e8-3343-4517-a1d1-f55d68f24e7e"}
2024-11-27 18:41:41    [INFO]    Update store status    {"controller": "store", "controllerGroup": "shop.shopware.com", "controllerKind": "Store", "Store": {"name":"my-shop","namespace":"my-shop"}, "namespace": "my-shop", "name": "my-shop", "reconcileID": "705040e8-3343-4517-a1d1-f55d68f24e7e", "status": {"state":"setup","conditions":[{"type":"setup","lastTransiti
onTime":null,"lastUpdatedTime":"2024-11-27T18:41:41Z","message":"Waiting for setup job to finish","status":"True"}]}}
2024-11-27 18:41:41    [INFO]    my-shop    Do reconcile on store    {"controller": "store", "controllerGroup": "shop.shopware.com", "controllerKind": "Store", "Store": {"name":"my-shop","namespace":"my-shop"}, "namespace": "my-shop", "name": "my-shop", "reconcileID": "9eed825f-148b-448a-bffd-46027bb35b3b", "state": "setup"}
2024-11-27 18:41:41    [INFO]    my-shop    reconcile app secrets    {"controller": "store", "controllerGroup": "shop.shopware.com", "controllerKind": "Store", "Store": {"name":"my-shop","namespace":"my-shop"}, "namespace": "my-shop", "name": "my-shop", "reconcileID": "9eed825f-148b-448a-bffd-46027bb35b3b", "state": "setup"}
2024-11-27 18:41:41    [DEBUG]    events    Update Store my-shop setup job in namespace my-shop. Diff hash    {"type": "Normal", "object": {"kind":"Store","namespace":"my-shop","name":"my-shop","uid":"0cd29409-5b25-4e5e-ac71-89e86a48dc7b","apiVersion":"shop.shopware.com/v1","resourceVersion":"513755386"}, "reason": "Diff setup job hash"}

Your custom resource
# configured through helm chart shopware
# values:
percona:
  enabled: false

minio:
  enabled: false

store:
  host: shop...
  serviceAccountName: null

  disableJobDeletion: true

  network:
    enabled: false

  database:
    user: 'root'
    host: 'my-shop-mariadb'
    passwordSecretRef:
      name: 'my-shop-mariadb'
      key: 'mariadb-root-password'

  s3Storage:
    endpointURL: https://s3...
    accessKeyRef:
      name: s3-credentials
      key: AWS_ACCESS_KEY
    secretAccessKeyRef:
      name: s3-credentials
      key: AWS_SECRET_KEY

Hi thank you for the issue 👍
This happens when the job resource is modified from other operators or in some way. That's mostly true if you see the diff hash log/event.
Update Store my-shop setup job in namespace my-shop-namespace. Diff hash

If the job resource is not the same as it was before, we delete the job and recreate it. Because jobs can't be patched and so we delete and recreate it.
The first issue
job not found in container: shopware-setup

happens when the setup job is found but the name of the setup container inside the job is not shopware-setup. You can't modify the name, because it's hard coded in the code so I guess the issue is a timing issue with the api and the operator.
We can fix this in the operator by ignoring fields for the hash generation. So if you can tell me what get's attached after the job is created, I can fix it. Annotations should be fine, but labels for example would trigger a recreate of the job.

apiVersion: batch/v1
kind: Job
metadata:
  annotations:
    batch.kubernetes.io/job-tracking: ""
    shopware.com/last-config-hash: 24b308ee1d48a04d07293a69ed85e4f4
  creationTimestamp: "2024-11-27T18:29:00Z"
  deletionGracePeriodSeconds: 0
  deletionTimestamp: "2024-11-27T18:29:00Z"
  finalizers:
  - foregroundDeletion
  generation: 2
  labels:
    store: my-shop
    type: setup
  name: my-shop-setup
  namespace: my-shop
  ownerReferences:
  - apiVersion: shop.shopware.com/v1
    blockOwnerDeletion: true
    controller: true
    kind: Store
    name: my-shop
    uid: 0cd29409-5b25-4e5e-ac71-89e86a48dc7b
  resourceVersion: "513749357"
  uid: 87de84cf-7c20-42d9-b5b1-c20202fb4cf4
spec:
  backoffLimit: 6
  completionMode: NonIndexed
  completions: 1
  parallelism: 1
  selector:
    matchLabels:
      controller-uid: 87de84cf-7c20-42d9-b5b1-c20202fb4cf4
  suspend: false
  template:
    metadata:
      creationTimestamp: null
      labels:
        controller-uid: 87de84cf-7c20-42d9-b5b1-c20202fb4cf4
        job-name: my-shop-setup
        store: my-shop
        type: setup
    spec:
      containers:
        ...

I cannot see that any other operator would modify the job. It is deleted almost instantly after creation (aprox. 4-5 sec).
The created Pod is also being terminated almost instantly as the Job is deleted. It has the following spec:
apiVersion: v1
kind: Pod
metadata:
  creationTimestamp: "2024-11-27T18:33:51Z"
  deletionGracePeriodSeconds: 30
  deletionTimestamp: "2024-11-27T18:34:21Z"
  generateName: my-shop-setup-
  labels:
    controller-uid: 2c455c57-04c6-4657-8d3a-ef259f660179
    job-name: my-shop-setup
    store: my-shop
    type: setup
  name: my-shop-setup-hd8rl
  namespace: my-shop
  ownerReferences:
  - apiVersion: batch/v1
    blockOwnerDeletion: true
    controller: true
    kind: Job
    name: my-shop-setup
    uid: 2c455c57-04c6-4657-8d3a-ef259f660179
  resourceVersion: "513751839"
  uid: 22f56eb5-a237-4119-8f3a-094767a66f45
spec:
  containers:
  - args:
    - /setup
    command:
    - sh
    - -c
    env:
      ...
    image: ghcr.io/shopware/shopware-kubernetes:latest
    imagePullPolicy: IfNotPresent
    name: shopware-setup
    resources: {}
    terminationMessagePath: /dev/termination-log
    terminationMessagePolicy: File
    volumeMounts:
    - mountPath: /etc/caddy
      name: my-shop-caddy-config
    - mountPath: /var/run/secrets/kubernetes.io/serviceaccount
      name: kube-api-access-nd4gj
      readOnly: true
  dnsPolicy: ClusterFirst
  enableServiceLinks: true
  nodeName: ...
  preemptionPolicy: PreemptLowerPriority
  priority: 0
  restartPolicy: Never
  schedulerName: default-scheduler
  securityContext: {}
  serviceAccount: default
  serviceAccountName: default
  shareProcessNamespace: true
  terminationGracePeriodSeconds: 30
  tolerations:
  - effect: NoExecute
    key: node.kubernetes.io/not-ready
    operator: Exists
    tolerationSeconds: 300
  - effect: NoExecute
    key: node.kubernetes.io/unreachable
    operator: Exists
    tolerationSeconds: 300
  volumes:
  - configMap:
      defaultMode: 420
      name: my-shop-caddy-config
    name: my-shop-caddy-config
  - name: kube-api-access-nd4gj
    projected:
      defaultMode: 420
      sources:
      - serviceAccountToken:
          expirationSeconds: 3607
          path: token
      - configMap:
          items:
          - key: ca.crt
            path: ca.crt
          name: kube-root-ca.crt
      - downwardAPI:
          items:
          - fieldRef:
              apiVersion: v1
              fieldPath: metadata.namespace
            path: namespace
status:
  conditions:
  - lastProbeTime: null
    lastTransitionTime: "2024-11-27T18:33:51Z"
    status: "True"
    type: Initialized
  - lastProbeTime: null
    lastTransitionTime: "2024-11-27T18:33:51Z"
    message: 'containers with unready status: [shopware-setup]'
    reason: ContainersNotReady
    status: "False"
    type: Ready
  - lastProbeTime: null
    lastTransitionTime: "2024-11-27T18:33:51Z"
    message: 'containers with unready status: [shopware-setup]'
    reason: ContainersNotReady
    status: "False"
    type: ContainersReady
  - lastProbeTime: null
    lastTransitionTime: "2024-11-27T18:33:51Z"
    status: "True"
    type: PodScheduled
  containerStatuses:
  - image: ghcr.io/shopware/shopware-kubernetes:latest
    imageID: ""
    lastState: {}
    name: shopware-setup
    ready: false
    restartCount: 0
    started: false
    state:
      waiting:
        reason: ContainerCreating
  hostIP: ...
  phase: Pending
  qosClass: BestEffort
  startTime: "2024-11-27T18:33:51Z"

The operator is changing the setup job because the resource is modified in some way. I can't see anything directly what cause this problem, but I will focus on the sub issue to make it visible. Sorry for that.
If you want to test it out, you can use the helm chart to create a local cluster. This works as expected currently and I will make the cause more visible with the next patch.

Just for clearification, a local cluster without the operator? Which chart are you referring to? I'm not able to find one where the operator isn't used. Thanks for your help in advance :)

Hi,
we provider a helm-chart which you can use for testing.
The docs also include the steps for setting it up in a kind cluster.
Can you maybe give us some more information about the current environment you are running the workload in?
This would help us for recreating the error for further debugging.

Exactly this helm chart is used to deploy the shop (incl. operator) and it was setup according to docs (see values in issue description).
Environment is a k3s, self hosted. Furthermore I want to use the s3 backend provided by rook-ceph, which is used as storage backend, as I don't want to deploy multiple services providing a s3 (e. g. minio)

Thank you, I will try to recreate the issue in k3s.
I will keep you updated when I found a solution.

Hi
I am still on trying to recreate the issue.
Are the secrets that are used for the store generated by other operators or did you create them manually?

Thanks for your support. I can provide the following answers:
@tombojer

Hi
I am still on trying to recreate the issue.
Are the secrets that are used for the store generated by other operators or did you create them manually?

The secret for the store is created manually.

@TrayserCassa

Operator image of the pod kubectl get deployment/shopware-operator -n  -o wide
Image: ghcr.io/shopware/shopware-operator:0.0.26

I can confirm that the same image is being used.

One Idea to see if something is changing the resource you can watch the resources like this:
kubectl get stores -n <namespace> --watch

Make sure to scale the shopware operator deployment down to 0, because the operator is changing the status of the resource from time to time.

When the operator is not running, there are no changes to the store resource.

And if you run this command:
kubectl get jobs/<helm installation name>-setup -n <namespace> -o=jsonpath='{$.metadata.annotations}' --watch

you should see different hashes each time the job get's created. This is not tested because it's working locally for me but should confirm my suspicions.

 So the crd is not getting changed at all, which is good. We pushed a new image which logs the reason why the object will be patched by the operator:
ghcr.io/shopware/shopware-operator:0.0.27

If you change the deployment of the operator to this image you should get more logs like this one:
Object last-config-hash has changed or Object meta has changed
This happens only if the annotation or label is not equal and print it out or the hash is not the same. So we can maybe see why this is happening. And if the message doesn't show up at all, the job is not modified by the operator.
On thing to make sure that the operator is deleting the job would be, that you remove the permission for the deletion of the operator. Then we should also see an error if the operator is trying to delete it. The object manager-role in the resource pool of roles should be edited for that.

Ok found it, the Object meta has changed is the indicator that the metadata of an resource is not the same after the operator created the resource.
  "oldAnnotations": {
    "batch.kubernetes.io/job-tracking": "",
    "shopware.com/last-config-hash": "24b308ee1d48a04d07293a69ed85e4f4"
  },
  "newAnnotations": {
    "shopware.com/last-config-hash": "24b308ee1d48a04d07293a69ed85e4f4"
  },

This is why it gets deleted and recreated. The Annotation batch.kubernetes.io/job-tracking is attached to the job after it's created. So for a hot fix you could attach it to the annotations in the store crd, just to make sure that my assumption is correct.
Since annotations are currently attached to any resource we need a way to support this. I will talk to my colleagues and fix this asap.


How can I navigate through the entire Asset Administration Shell (AAS) to explore its submodels and search for elements?

I'm familiar with navigating through a submodel using a for loop, as shown in the example: "for submodel_element in submodel:". This allows me to iterate through all the elements contained within that submodel. I've also successfully navigated through a submodelElementCollection using a similar approach: "for element_ref in submodel_element.value:".
However, I'm struggling to search within my AAS. I've identified that the class "AssetAdministrationShell" takes the submodel argument as follows: "submodel: Optional[Set[base.AASReference[Submodel]]] = None". These are references to submodels, not the actual submodels. Therefore, using "for submodel_ref in new_aas.submodel:" doesn't work. I've also attempted to use the "resolve" function of the "AASReference" class, but I'm uncertain about what to provide as the provider parameter. I've tried submodels, AAS, and even creating an AbstractObjectProvider, but the instantiation gives me an error.
In summary, I've tried various approaches to navigate through the AAS to locate a submodel and then search for a specific element (which I can handle once I'm in the submodel). Despite utilizing different functions and methods of the classes, I haven't been successful.

Hey,
to resolve reference you have to pass an ObjectProvider to the resolve() function. An ObjectProvider is a collection of Identifiable objects, among which the resolve() tries to resolve the reference and return the referenced object. This SDK offers several ObjectStores, such as the DictObjectStore, that stores objects in a python dict, the CouchDBObjectStore, that stores objects in a CouchDB and the LocalFileObjectStore, that stores objects as plain JSON files on the filesystem.
A short introduction is given here:
https://github.com/eclipse-basyx/basyx-python-sdk/blob/5255a1fae3aac923d10ce20f091c256b81a3e6d6/basyx/aas/examples/tutorial_storage.py#L73-L77
https://github.com/eclipse-basyx/basyx-python-sdk/blob/main/basyx/aas/examples/tutorial_storage.py#L96-L97

If I understand correctly, is it necessary to interact with the object_store to navigate through the Asset Administration Shell (AAS)? In my attempt to work more efficiently with the AAS, I utilized the AASXReader to retrieve my AAS created in AASX as new_object_store. Subsequently, I extracted from new_object_store the asset, the AssetAdministrationShell, and the submodels. While I have been able to work with the submodels successfully, I encountered challenges in working with the AssetAdministrationShell and navigating through it.

The references between AAS and Submodel are "soft" as to the specification. That means, a Submodel is only connected to its AAS via the AASReference and does not belong to the AAS as a child class, as you discovered correctly. You can also read up on this in the specification
Therefore, the specification does not provide a clear way as to how a Submodel should be found when only knowing the AAS, so we developed our own solution, using the ObjectStores.
So, yes it is necessary to interact with the ObjectStore in order to find the Identifiable Submodel based on the AASReference to it inside the AAS. On the Submodel level itsself you can then use the walk_submodel() function from here
I hope this helps. Feel free to ask further questions.

Thank you!

I'll close this issue. Feel free to reopen it, if you deem it necessary.


Rasa x domain section tab and space bug

**Also like to tag along @koaning he was the one to whom I showed this when we where in workshop for Rasa chatbot organized by Me in India.
Rasa version: 2.0.2
Rasa SDK version (if used & relevant): 2.1.2
Rasa X version (if used & relevant): 0.33.2
Python version: 3.8.5
Operating system (windows, osx, ...): Windows
Issue: When used spaces in domain section rasa x recognizes the indentation but when used tab for adding spaces it gives Error 500
Here is screenshot of that error:
With tabs

with spaces

Error (including full traceback):
Traceback (most recent call last):
  File "e:\anaconda3\envs\rasa-workshop\lib\site-packages\sanic\app.py", line 939, in handle_request
    response = await response
  File "e:\anaconda3\envs\rasa-workshop\lib\site-packages\rasax\community\api\decorators.py", line 213, in decorated_function
    return await await_and_return_response(args, kwargs, request)
  File "e:\anaconda3\envs\rasa-workshop\lib\site-packages\rasax\community\api\decorators.py", line 143, in await_and_return_response
    response = await response
  File "e:\anaconda3\envs\rasa-workshop\lib\site-packages\rasax\community\api\decorators.py", line 50, in decorated_function
    return await f(request, user=user, *args, **kwargs)
  File "e:\anaconda3\envs\rasa-workshop\lib\site-packages\rasax\community\api\blueprints\project.py", line 384, in update_domain
    updated_domain = DomainService(
  File "e:\anaconda3\envs\rasa-workshop\lib\site-packages\rasax\community\services\domain_service.py", line 140, in validate_and_store_domain_yaml
    domain = RasaDomain.from_yaml(domain_yaml)
  File "e:\anaconda3\envs\rasa-workshop\lib\site-packages\rasa\shared\core\domain.py", line 162, in from_yaml
    raise e
  File "e:\anaconda3\envs\rasa-workshop\lib\site-packages\rasa\shared\core\domain.py", line 149, in from_yaml
    rasa.shared.utils.validation.validate_yaml_schema(
  File "e:\anaconda3\envs\rasa-workshop\lib\site-packages\rasa\shared\utils\validation.py", line 143, in validate_yaml_schema
    raise YamlSyntaxException(underlying_yaml_exception=e)
rasa.shared.exceptions.YamlSyntaxException: Failed to read YAML. while scanning for the next token
found character '\t' that cannot start any token
  in "<unicode string>", line 23, column 1:
        type: float
    ^ (line: 23)

Command or request that led to error:
rasa x <- to start rasax and save changes button
Content of configuration file (config.yml) (if relevant):

Content of domain file (domain.yml) (if relevant):
session_config:
  session_expiration_time: 60
  carry_over_slots_to_new_session: true
intents:
  - greet
  - goodbye
  - affirm
  - deny
  - mood_great
  - mood_unhappy
  - bot_challenge
  - ask_timings
  - ask_menu
  - take_order
  - ask_details
  - chitchat
entities:
  - name
  - email
  - order
slots:
  age:
    type: float
    influence_conversation: false
    max_value: 1
    min_value: 0
  email:
    type: text
    influence_conversation: true
  name:
    type: text
    influence_conversation: true
  order:
    type: list
    influence_conversation: true
responses:
  utter_greet:
    - text: Hey! How are you?
  utter_cheer_up:
    - image: 'https://i.imgur.com/nGF1K8f.jpg'
      text: 'Here is something to cheer you up:'
  utter_did_that_help:
    - text: Did that help you?
  utter_happy:
    - text: 'Great, carry on!'
  utter_goodbye:
    - text: Bye
  utter_iamabot:
    - text: 'I am a bot, powered by Rasa.'
  utter_timings:
    - text: Our restaurant is opened from Morning 10am till 12am Midnight
  utter_menu:
    - text: |-
        1. Panner Butter Masala
        2. Pizza
         3. Burger
         4. Roti
  utter_ask_details:
    - text: Please provide us with your details(name and email id)
  utter_confirm:
    - buttons:
        - payload: /affirm
          title: 'Yes'
        - payload: /deny
          title: 'No'
      text: Should I confirm your order?
  utter_thank_you:
    - text: Thank you!
actions:
  - action_menu
  - action_send_mail

```

Thanks for the issue, @joejuzl will get back to you about it soon!
You may find help in the docs and the forum, too 🤗

Hi @Horizon733 technically tabs are actually forbidden in yaml, see: https://yaml.org/faq.html.

Hi @Horizon733 technically tabs are actually forbidden in yaml, see: https://yaml.org/faq.html.

But in Domain file it doesn't so that's why. If we keep just spaces or both(tabs and spaces) in both places then there won't be this error.

But in Domain file it doesn't so that's why. If we keep just spaces or both(tabs and spaces) in both places then there won't be this error.

Are you sure that your tabs are not being converted to spaces by your editor?
I get this error when I run rasa train with a domain file containing tabs:
YamlSyntaxException: Failed to read '/Users/josephjuzl/code/myrasa/domain.yml'. while scanning for the next token
found character '\t' that cannot start any token
  in "/Users/josephjuzl/code/myrasa/domain.yml", line 5, column 1:
        - greet
    ^ (line: 5)

You can use https://yamlchecker.com/ to validate the YAML syntax of your file.

Although I do agree that it's a bit weird that the yaml editor in rasa x allows tabs but then fails like that.

But in Domain file it doesn't so that's why. If we keep just spaces or both(tabs and spaces) in both places then there won't be this error.

Are you sure that your tabs are not being converted to spaces by your editor?
I get this error when I run rasa train with a domain file containing tabs:
YamlSyntaxException: Failed to read '/Users/josephjuzl/code/myrasa/domain.yml'. while scanning for the next token
found character '\t' that cannot start any token
  in "/Users/josephjuzl/code/myrasa/domain.yml", line 5, column 1:
        - greet
    ^ (line: 5)

You can use https://yamlchecker.com/ to validate the YAML syntax of your file.

Yes Because when I and Vincent Checked the editor showed us Tabs and not spaces

Try with this:
intents:
	- greet
	- goodbye
responses:
	utter_greet:
	- text: Hey! How are you?

Try with this:
intents:
	- greet
	- goodbye
responses:
	utter_greet:
	- text: Hey! How are you?

This provides more than 2 spaces

Try loading it in python and see what characters you can find.

Try loading it in python and see what characters you can find.

2 tabs thats equal to 4 spaces in python 3.7 IDE

In [1]: text = open('domain.yml', 'r').read()

In [2]: text
Out[2]: 'intents:\n\t- greet\n\t- goodbye\nresponses:\n\tutter_greet:\n\t- text: Hey! How are you?\n'

The \t character represents a tab. It is a special character, different from a space. See how I can use expandtabs to replace it with any number of spaces?
In [3]: text.expandtabs(0)
Out[3]: 'intents:\n- greet\n- goodbye\nresponses:\nutter_greet:\n- text: Hey! How are you?\n'

In [4]: text.expandtabs(10)
Out[4]: 'intents:\n          - greet\n          - goodbye\nresponses:\n          utter_greet:\n          - text: Hey! How are you?\n'

And if I try to parse it using yaml:
import yaml
list(yaml.parse(text))

ScannerError: while scanning for the next token
found character '\t' that cannot start any token
  in "<unicode string>", line 2, column 1:
        - greet
    ^

I get an error.

oh I see so what if we remove the tab option everywhere so, this issue won't arrive

Whenever the domain orany yml is ran it needs to be checked for tabs. For example, when running rasa train

oh I see so what if we remove the tab option everywhere so, this issue won't arrive

Yeah I think what makes it confusing is that it lets you input tabs in the rasa x UI. And then it doesn't highlight it as an error until you save it.
Do you think it would be clearer if it showed a warning as soon as you entered a tab character?

Yep that too is great idea. This will work, also some might say like tab works with Rasa and not in Rasa x GUI. So, tab checking needs to be there in Rasa.
What do you think?

I think that the reason the tabs seem to work for you with rasa is that your IDE is converting them to spaces when you save. And if you were to load the raw text you would see that it actually contains spaces.

Yeah that might be the case. So, better idea just to show up warning in Rasa x GUI.


Add ruby version requirement to .gemspec

This will prevent gem upgrade on environments with ruby 1.8.7 which is no longer supported by Puppet (4.0.0)

Waiting for CLA signature by @VladRassokhin
@VladRassokhin - We require a Contributor License Agreement (CLA) for people who contribute to Puppet, but we have an easy click-through license with instructions, which is available at https://cla.puppetlabs.com/
Note: if your contribution is trivial and you think it may be exempt from the CLA, please post a short reply to this comment with details. http://docs.puppetlabs.com/community/trivial_patch_exemption.html

Hi @VladRassokhin, thanks for the contribution!  Would it be possible to open a ticket for this issue and amend the commit message per our guidelines?

Hi @VladRassokhin.  Just touching base to see if you've had any time to open a ticket, amend the commit message per the guidelines, and sign the CLA.  Thanks!

I don't care about to be mentioned or not in commits history, so you can just do same fix yourself.
Hmm.. Really, CLA, register on issue tracker, all kind bureaucracy for one-line fix?
So answering your question, I don't have time for all this stuff.
PS: Note there is CONTRIBUTON.md in this repo, but it not shown when creation pull request, so i was not aware of it.

@VladRassokhin Thanks again for the contribution.  I will go ahead and close this in favor of #3925 which has linked a new ticket.  If you get a prompt from our CLA bot about signing the CLA, you can ignore it as this meets the requirement for a trivial change exception.  Thanks!


I installed mod 1.19.3, but I can't enter any commands in the chat.

I installed mod 1.19.3, but I can't enter any commands in the chat. That is, I write, for example, /seed gui, but there is no such command. But here the structures are outlined, the xray works. Maybe you need a different version?

I'm using google translate so sorry

On 1.19.3 the command changed from /seed to /seedcracker

Okay, I'll try, thanks.


Swift 3 Error

I made migration to Swift 3, I use this framework and I get this framework from the specific swift-3 branch. But I get Xcode error “Use Legacy Swift Language Version” (SWIFT_VERSION) is required to be configured correctly for targets which use Swift. Use the [Edit > Convert > To Current Swift Syntax…] menu to choose a Swift version or use the Build Settings editor to configure the build setting directly.
My pod file
pod 'ObjectMapper', :git => 'https://github.com/Hearst-DD/ObjectMapper.git', :branch => 'swift-3'
I saw it in the terminal window Installing ObjectMapper 1.4.0 (was 1.4.0) then I opened the swift-3 branch popspec and I saw incorrect version for this branch. I think error because of it.
https://monosnap.com/file/JooapeSwo8b1lvvwGbuuuqDTYDUriF
How can I fix it?

Please use v2.0.0. I have already merged the swift-3 branch back into master.
Let me know if you are still having issues when you use that


IEIP712 interface & cleanup for developer integration

Hey @ewilz, do you have any plans of merging this soon?
We have an audit slated to start next week (on May 31), and we would love to be able to install the official Uniswap/permit2 repo instead of our fork.
Also, any chance we could include https://github.com/Uniswap/permit2/pull/212 in this PR, too? https://github.com/Uniswap/permit2/issues/211 is another blocker.

sorry for the delay, merging asap, I don't have authority w/o an external reviewer (since I issued PR). build failure is not new to this PR but an existing issue. (cc @snreynolds @marktoda )

no worries, thanks Emily.


(Minor) Update GitHub actions workflow

Also adds VSCode IDE dir to gitignore, fixes a minor typo in readme

This is cool. I was trying to figure out how to determine what runner version we are using since it sounds like we need Actions Runners v2.285.0 or later. Do you know the best way to determine that?
Also, curious if (in a different effort) there is value in trying to add a matrix to the runners to include java 11 support since I don't think we have anything specifically preventing 11 from working right now.
From the docs:
jobs:   build:     runs-on: ubuntu-20.04     strategy:       matrix:         java: [ '8', '11', '13', '15' ]     name: Java ${{ matrix.Java }} sample     steps:       - uses: actions/checkout@v2       - name: Setup java         uses: actions/setup-java@v2         with:           distribution: '<distribution>'           java-version: ${{ matrix.java }}       - run: java -cp java HelloWorldApp

Thanks Jason - see PR 1649 in the other repo too which includes a slightly alternate example for the matrix feature. You're right though in that compiling w/ Java 11 works fine for emissary, so I'll update this PR to include that (and perhaps other versions if they compile OK)

Thanks Jason - see PR 1649 in the other repo too which includes a slightly alternate example for the matrix feature. You're right though in that compiling w/ Java 11 works fine for emissary, so I'll update this PR to include that (and perhaps other versions if they compile OK)

Ah, yes I see. I'd certainly be in favor (provided it works) of locking in 8 and 11 as versions to enforce to help the 11 migration and call that good for now.
I'm not as convinced 16 and 17 are necessary in the immediate, but if it works to combine them in a way to enforce 8/11 and make 16/17 informatory only (which I think is how you were going in 1649) then it might be fine. What sort of timing are we talking here though? I believe these would intend to run max parallel, but it would depend on availability of the runner VMs which I don't have insight into how many resources we have.  I'm not sure we'd want the extra builds to delay the action completion too much.

Thanks for making these updates!


added ubuntu-22 compatibility

name: Pull request
about: Describe the proposed change

Describe the change
Ubuntu 22 ships with PHP 8.1 by default, this adds the necessary directory and service
Testing
In case a feature was added, how were tests performed?
Local testing on Ubuntu 22.04 solves #1

Bookworm is failing because it also depends on PHP 8.1., I have added a commit that should also solve that. I was unsure if I should apply the same structure there because Bookworm is supposed to release next year.
Isn't there a way to check the installed PHP Version instead of the system version? That would maybe solve some problems.


[Foundation] Error-bridging kCFErrorDescriptionKey

Follow-up to: https://github.com/apple/swift/pull/26061#issuecomment-511070891

Cc: @parkera

I'm not sure if this change is still needed:

The original pull request (#26061) was intended for XCTest failures, which at the time printed the localized description of caught errors.
But the current version of XCTest (in Xcode 11.4.1) somehow prints the non-localized description of the Swift type.
I thought it might be using SR-7652, but that is only implemented in the release/5.3 and master branches.

I had to make some changes to AnyHashableTests:

MinimalHashableRCSwiftError now has a synthesized conformance, but I don't know why the deleted method didn't hash the LifetimeTracked payloads.
The tests were assuming that the userInfo of a bridgedNSError would be empty, which is no longer true — it now contains the kCFErrorDescriptionKey entry.
The equalityOracle and hashEqualityOracle local functions are updated, based on my understanding of __SwiftNativeNSError and CFError.


Dependencie list is missing Vinyl

Dependencie list in package.json misses Vinyl.

I'm still having this in v4.0.1
d:/Projects/microcosm/microcosm/node_modules/gulp-typescript/release/input.d.ts(1,23): error TS2688: Cannot find type definition file for 'vinyl'.
d:/Projects/microcosm/microcosm/node_modules/gulp-typescript/release/reporter.d.ts(1,23): error TS2688: Cannot find type definition file for 'vinyl'.
TypeScript: 2 semantic errors

@artin-phares That appears to be a different issue, I opened #567 for you


move from python 3.8-3.10 to 3.10-12

3.8 will be EOL in oktober, So I would argue we can move to >=3.10. which we can enforce in the python setup.py
would also need to change tests here: https://github.com/airo-ugent/airo-mono/blob/5cbacd7acee7491435f963e39b33ea29af6b4357/.github/workflows/pytest.yaml#L17

@Victorlouisdg  @adverley  anyone has an issue with this proposed change?

also need to change the conda environment's default python version

Sounds good to me, however some packages like ur_rtde only have prebuilt wheels up to 3.11 I believe, making it difficult to install on 3.12.
We should probably also update our types too then, because 3.10 allow tuple instead of Tuple etc.


Questions about code

Hi, thanks for your kind help last time. Now I'm learning NeRF from your code. It's a really great work but I am not good at coding. I met some problems in learning. I will try to list them below.

I find some conv layers seem not to be used in the network. They are self.resize_1_1 to self.resize_output_1_16 in scenerf/models/unet2d_sphere.py. Should I delete these layers?

I find 'steps' appear repeatedly in scenerf/models/utils/sample_rel_poses. Should I use the first line?
steps = torch.arange(start=0, end=max_distance, step=step)
steps = torch.arange(start=0, end=0.6, step=0.5)

In scenerf/models/utils/uniform_sampling, the step of noise seems not to be consistent with sensor_distance_sampled, as the intervals of torch.linspace will be n_pts_per_ray-1 instead of n_pts_per_ray. Is this ok?

Thank you very much again!

Hello @zhangfang97,
Thank you for expressing your interest! Here are my responses to your queries:

Yes, you should delete those lines. I cleaned up the code for publishing, but I may have missed those lines.

The first line is accurate.

I have specified the steps in torch.linspace such that it will sample n_pts_per_ray.

sensor_distance_sampled = torch.linspace(d_min, d_max,
                                             steps=n_pts_per_ray,
                                             device=unit_direction.device)

Thanks for your quick reply! I understand the first two responses. For the third one, I'm sorry I didn't make it clear. I will try to explain what I am concerned about.
As sensor_distance_sampled is added by noise, I was wondering if the noise[i] is used to move the sensor_distance_sampled[i] to the interval of (sensor_distance_sampled[i],  sensor_distance_sampled[i+1]).
Through using torch.linspace, sensor_distance_sampled will have n_pts_per_ray, but the distance of two consecutive points will be (d_max-d_min)/(n_pts_per_ray-1).
At the same time, the interval of noise is (d_max-d_min)/n_pts_per_ray, which may exceed the boundary of (sensor_distance_sampled[i],  sensor_distance_sampled[i+1]).
Did I make a mistake or will this be ok?

Hi @zhangfang97,
You're correct that the value can exceed. I actually noticed this issue myself earlier, but I added a step in the rendering process where all the points are sorted. Thus, the issue doesn't have any impact on the output.
Here's the specific line of code where I addressed the issue: https://github.com/astra-vision/SceneRF/blob/main/scenerf/models/scenerf.py#L650

Thank you so much! I understand it.
I'm truly grateful for your help. Wish you every success!  😊

No problem at all! Happy to help and glad you understood. Best of luck to you!


[DDW-1165] Update configs for Preprod respin

This PR updates cardano-node configs for the respinning of the Preprod environment
Todos

[ ] is it enough to communicate to users that they have to remove the chain directory manually?

Screenshots
n/a
Testing Checklist

Slack QA thread
[ ] Test

Review Checklist
Basics

[x] PR assigned to the PR author(s)
[x] input-output-hk/daedalus-dev and input-output-hk/daedalus-qa assigned as PR reviewers
[x] If there are UI changes, Alexander Rukin assigned as an additional reviewer
[ ] All visual regression testing has been reviewed (assign run Chromatic label to PR to trigger the run)
[x] PR has appropriate labels (release-vNext, feature/bug/chore, WIP)
[x] PR link is added to a Jira ticket, ticket moved to In Review
[x] PR is updated to the most recent version of the target branch (and there are no conflicts)
[x] PR has a good description that summarizes all changes
[x] PR contains screenshots (in case of UI changes)
[x] CHANGELOG entry has been added to the top of the appropriate section (Features, Fixes, Chores) and is linked to the correct PR on GitHub
[x] There are no missing translations (running yarn manage:translations produces no changes)
[ ] Text changes are proofread and approved (Jane Wild / Amy Reeve)
[ ] Japanese text changes are proofread and approved (Junko Oda)
[ ] Storybook works and no stories are broken (yarn storybook)
[x] In case of dependency changes yarn.lock file is updated

Code Quality

[ ] Important parts of the code are properly commented and documented
[ ] Code is properly typed with typescript types
[ ] React components are split-up enough to avoid unnecessary re-renderings
[ ] Any code that only works in main process is neatly separated from components

Testing

[ ] New feature/change is covered by acceptance tests
[ ] New feature/change is manually tested and approved by QA team
[ ] All existing acceptance tests are still up-to-date
[ ] New feature/change is covered by Daedalus Testing scenario
[ ] All existing Daedalus Testing scenarios are still up-to-date

After Review

[ ] Update Slack QA thread by marking it with a green checkmark

This one is easy


Correct required v.s. optional fields in run status

Changes
/kind misc
Fixes https://github.com/tektoncd/pipeline/issues/5818.
Prior, startTime and completionTime are marked as optional fields in Run status, and provenance field was not marked as optional in Run status.
Now, we remove +optional tag for startTime and completionTime in Run status, and add +optional tag for the provenance field.
Signed-off-by: Chuang Wang<EMAIL_ADDRESS>
Submitter Checklist
As the author of this PR, please check off the items in this checklist:

[x] Has Docs included if any changes are user facing
[ ] Has Tests included if any functionality added or changed
[x] Follows the commit message standard
[x] Meets the Tekton contributor standards (including
functionality, content, code)
[x] Has a kind label. You can add one by adding a comment on this PR that contains /kind <type>. Valid types are bug, cleanup, design, documentation, feature, flake, misc, question, tep
[ ] Release notes block below has been updated with any user facing changes (API changes, bug fixes, changes requiring upgrade notices or deprecation warnings)
[ ] Release notes contains the string "action required" if the change requires additional action from users switching to the new release

Release Notes
Remove optional tag for `startTime` and `completionTime` in TaskRun/PipelineRun status, and add option tag for `provenance` field in TaskRun/PipelineRun status.

cc @JeromeJu @dibyom @lbernick
Please take a look. Thanks!

/retest
Flake: testReconcile
link https://prow.tekton.dev/view/gs/tekton-prow/pr-logs/pull/tektoncd_pipeline/5819/pull-tekton-pipeline-unit-tests/1598068375232188416


Results in vignette are inconsistent with docs

Running the vignette is giving different output than that in the docs. Most likely this is due to recent commits changing the code, and we just need to update the docs.

The latest commit made --shuffle_inds no longer default, but this helps get different pairs each epoch.
I think let's make this option default, except when using empirical locs. So no shuffle_inds flag.

Changed --shuffle_inds to default, reran the vignette twice with same seed, got same output.
Updating the docs with the new output (v0.0.7)


yaml container doc (container per phase)

@TingluoHuang Is there a timeline for getting this feature out? Is there a issue I can follow?

@joaomoreno the Doc has merged with #1436, it should coming this month as preview.


Migrate to Gulp & Integrate Mock (v2.0.0)

WHEN REVIEWING MAKE SURE YOU MARK UP FILES IN /SRC NOT /OUT
Original PR: https://github.com/lytics/jstag/pull/21
First step in actually closing: https://github.com/lytics/lio/issues/6881
Once the delete-junk branch gets thumbed / merged we can probably alter this pr to be against gh-pages but for now this will make it easier to review the code related changes. Also plan on rebasing this thing this afternoon.
out are the compiled files so all comments should be against files in src
Cleanup
Migrated everything to use gulp.
Tests
Added gulp, jasmine, karma, phantom for unit tests. Wrote tests for everything I could think of. I am sure ther are some missing but here is a shortlist of the things that are covered:

extend function
setcookie
getcookie
async queue
send
identify
pageview
mock
block
etc

New Functionality
In support of 6881 I introduced the concept of a mock and a hold on sending events. We needed the ability to basically pause all sends and then build an object of that send queued data so that we could pass it to our /me endpoint and get the most current state of the entity. This will make strides in facilitating the first visit use case as well as many other use cases negatively effected by latency.
In a nutshell it routes all send events to a queue. Then when send the mock event it pulls all that data out of the queue, extends the current payload and does all the processing up the point where it would actually be sent. It then returns the payload via callback so we can handle it in /tag/lio.js.
When block is lifted all existing events get processed normally.
TODO:

Add Readme
Rebase all Commits

👍 × 💯

:+1:


LongLoRA implementation

PR types
Others
PR changes
Others
Description

修改了llm/data.py 中处理red pajama中这种只有text的example方法
在LlamaAttention forward使用scaled_dot_product_attention前对qkv进行shift操作，计算后对attn_output进行shift操作
在llm/finetune_generation.py修改了rope scaling，保证模型能够处理2048以上长度的序列
在llm/finetune_generation.py设置了norm embed层可训练

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.


ajax link inside ajax form is not functioning properly

<form accept-charset="UTF-8" action="/users/sign_in" data-remote="true" method="post">
Forgot Password?
</form>

the data-remote of the link inside the form is ignored

I know this issue is outdated but just writing here as Google led me here and I guess this issue should be closed unless a failing test can be provided.
Are you perhaps using stopPropagation somewhere else? I was facing this issue as well and I was using stopPropagation on elements within the dynamic content.

Having this issue too. My particular issue I found to be from the bubbling of link click ajax:* events bubbled up to the form ajax:success before my global ajax:success intended for links attached to document. The form behaviour was calling other function which stopped propagation.
I fixed the issue by checking in the form ajax:success event was attached to the form itself rather than bubbled from the link
event.target != this


Recognize Building notice as not an error

Newer versions of ember-cli seem to be putting a progress spinner with - Building on stderr, which ember-cli-rails doesn't recognize as not a BuildError. This adds a simple regex to detect--and ignore--this output.

We've recently switched continuous integration providers for this project. To re-run your pull request's test suite, could you rebase off of the latest master branch and force push this PR's branch?

I rebased as asked, but now there are a few houndci-bot comments. I have no problem addressing the style issues as indicated, but I also note that it would make the style inconsistent with the rest of the respective files. Should I change them or leave them as-is?

Hi folks! Is there anything that prevents this PR to be merged and released? Anything I can help with?


Support no_std without [patch.crates-io] section

Crate
ibc, ibc-proto
Summary
With #1846 merged, the ibc and ibc-proto crates on master branch now fully support no_std. There are just two dependencies that need to be patched for no_std to fully work:

[ ] Wait for new version of tendermint-rs to be released so that https://github.com/informalsystems/tendermint-rs/pull/1087 is included.
[x] Wait for the merge request for safe-regex to be merged and published.

PR: #1866

As of now, developers who need full no_std support can include the following section in their project Cargo.toml:
[patch.crates-io]
tendermint                        = { git = "https://github.com/informalsystems/tendermint-rs", branch = "v0.23.x" }
tendermint-proto                  = { git = "https://github.com/informalsystems/tendermint-rs", branch = "v0.23.x" }
tendermint-light-client-verifier  = { git = "https://github.com/informalsystems/tendermint-rs", branch = "v0.23.x" }

Acceptance Criteria
This issue will be closed when new version of ibc-rs is released, and no_std us supported without requiring the [patch.crates-io] section.

For Admin Use

[ ] Not duplicate issue
[ ] Appropriate labels applied
[ ] Appropriate milestone (priority) applied
[ ] Appropriate contributors tagged
[ ] Contributor assigned/self-assigned

Is that ready to close? I see https://github.com/informalsystems/tendermint-rs/pull/1087 is merged.

We are still waiting for a new version of tendermint-rs to be released for this to be closed. Right now the no_std check can only pass by patching to the latest tendermint-rs on GitHub.

This is now fixed.


⚠ Cioos National CKAN has degraded performance

In 5b67c66, Cioos National CKAN (https://catalogue.cioos.ca/) experienced degraded performance:

HTTP code: 200
Response time: 5466 ms

Resolved: Cioos National CKAN performance has improved in 0f3d14c after 25 minutes.


Recursive definition causes stack overflow

Problem statement
I find the case that swagger panics with a stack overflow.
In this case, the swagger specification contains a schema that includes an item which has some special property, the definition containing that array of itself.
This schema is valid with swagger edittor.
My swagger version is 0.5.0-58-gf6472e8.
Swagger specification
swagger: "2.0"
info:
  title: sample
  version: 1.0.0
schemes:
- http
- https
consumes:
- application/vdn.sample.v1+json
produces:
- application/vdn.sample.v1+json
paths:
  /:
    get:
      responses:
        200:
          description: list all suites
          schema:
            type: array
            items:
              $ref: '#/definitions/Foo'
definitions:
  Foo:
    type: object
    properties:
      foo:
        $ref: "#/definitions/Bar"
  Bar:
    type: object
    properties:
      bar:
        type: array
        items:
          $ref: "#/definitions/Bar"

Steps to reproduce

Run swagger validate swagger.yml with the given swagger specification

duplicate of #442
I'm keeping this one open because the spec is cleaner


Rooms page errors of time and rooms

Please move times back to left side of the table and ensure room only shows up once.

@aayusharora will you take a look at this ? your earlier PR moved the times into the boxes.

@championswimmer Working for this

thanks, done via https://github.com/fossasia/open-event-webapp/pull/685

Rooms still repeating

@championswimmer Figured that out Please check the spaces in front off Dalton hall in data https://github.com/fossasia/open-event/blob/master/sample/FOSSASIA16/sessions#L48 This is the reason for creating two objects. Can you remove this?

done https://github.com/fossasia/open-event/pull/92


Updated Redirection Button

Description
This PR fixes #
Notes for Reviewers

Thanks @swarnade , we will review and merge it soon!

Looking Into It

Closes Issue #399

Okh Looking Into It

Done All Changes

Hey @swarnade , u didn't change anything, the commit is same as previous
Ok I will tell u.....
Check 139 and 140th lines in this

Those lines should be there, the  is not there in your commit. I mean the button content must be wrapped inside the span tag. Instead of directing it to contact section, lead that to join-us

Acctually @akshathar-navada Due To Multiple Commits And Changes It Is Getting Confused
I Am Closing This Pull Request And Issueing a Fresh Pull Request


feat/nuget

:tada: This PR is included in version 1.1.0 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


WordPress: "response from the Jetpack site could not be verified"

started getting these errors from the WordPress API on https://brid.gy/wordpress/leolaporte.com (self hosted with jetpack) when looking up post of for a slug. log:
2017-05-24 15:28:39.617700 I Determining WordPress.com post id for https://leolaporte.com/2017/05/24/galloping-galapagos/
2017-05-24 15:28:39.618040 I Looking up post id for slug galloping-galapagos
2017-05-24 15:28:39.618480 I urlopen GET https://public-api.wordpress.com/rest/v1/sites/126530361/posts/slug:galloping-galapagos?pretty=true {}
2017-05-24 15:28:39.950870 W Error 400, response body: {
"error": "jetpack_verification_failed",
"message": "The response from the Jetpack site could not be verified."
}

this is actually fine, and we're doing the right thing by returning 400. fix is just to stop emailing myself about it. :P


API versioning

We should provide semver API in format of /api/vX.Y/
X - major version
Y - minor version
So, we should introduce controolers in our code to bind routers to proper path

Implemented /api/v0_0/ endpoints for v"0.0"


Add support and environment files for Python v3.8 and v3.9

Currently only Python v3.6 and v3.7 are supported. Add yaml files to env directory and new tests to Travis.

Awesome! Would also be nice to have updated versions on pypi.org supporting these Python versions: https://pypi.org/project/exoctk/

I'm currently working on a PR for this (#469), but while testing things out I noticed that our Travis builds are using python 3.8, even in the 3.6, 3.7, and 3.9 env builds. 😱 I'll work on fixing that.

Python 3.8 and 3.9 are now supported with the merge of #469!
@falkben I also pushed the latest ExoCTK release (v1.1) to PyPI, and it appears to pip install successfully in the new environments.  But let me know if you run into any issues with that.


Invalid ES_HEAP_SIZE setting prevents elasticsearch starting

I'm guessing that the template looks at the VM size and sets the ES_HEAP_SIZE value in /etc/default/elasticsearch to half the VM's memory, as per the usual recommendations.  In a deployment I've just done to a cluster of small nodes with 3.5GB memory and had the following setting:
ES_HEAP_SIZE=1719.5m
elasticsearch wouldn't start and there were no errors or logs reported, but by removing .5 from the setting I was able to get the service running.  Looks like the value needs to be an integer.

Hi @batwad
Deploying through the template and from the master branch of this repos directly i end up with:
ES_HEAP_SIZE=1720m

In all cases.
Can you share a bit more about your VMsize/elasticsearch version/parameters.

I'm not sure what details exactly you need, and how to get them.  It's a corporate deployment so I'm reluctant to dump everything.
I should confess to editing the template: my client wanted to deploy to a UK data centre and when I tried to do this I got a validation error rejecting UK South (I exchanged emails with @russcam about this) so I downloaded the template from the marketplace, added the locations and deployed that.

@batwad I experienced this when deploying an Elasticsearch 5.x cluster to Ubuntu 16.04-LTS; I've added a fix for it in #90 👍

This is now merged into master if you would like to try again, @batwad.
Closing this, but feel free to reopen if you still experience the issue.


Roll engine 70a1106b509e..22fc02028306 (10 commits)

https://github.com/flutter/engine/compare/70a1106b509e...22fc02028306
git log 70a1106b509e..22fc02028306 --no-merges --oneline
22fc02028 Roll src/third_party/skia fa8898747551..5d58d09ae77d (4 commits) (flutter/engine#6796)
d372d56ae Roll src/third_party/skia 23d1f94faac1..fa8898747551 (1 commits) (flutter/engine#6794)
8f105d79c Roll src/third_party/skia 2f8889b876d3..23d1f94faac1 (1 commits) (flutter/engine#6793)
0ce31d660 Roll src/third_party/skia 71bcc7d63f8c..2f8889b876d3 (1 commits) (flutter/engine#6792)
09ff6dc47 avoid overreleasing FlutterView (flutter/engine#6791)
bd793c011 Roll src/third_party/skia f49563bf9276..71bcc7d63f8c (3 commits) (flutter/engine#6790)
c8da28826 Roll Dart version to 9c07fb64c48adb3d6fde50bab6b8b641c5b67683 (flutter/engine#6788)
94dd7165e Skia Cleanup (flutter/engine#6786)
547b8585e Roll src/third_party/skia b52c273d3f05..f49563bf9276 (7 commits) (flutter/engine#6785)
b6f76e07a Delete unused license goldens and add check (flutter/engine#6784)
The AutoRoll server is located here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

@liyuqian : New roll has been created by https://autoroll.skia.org/r/flutter-engine-flutter-autoroll

FYI anyone else watching this, the same tests for the same hash passed (after flaking out once or twice) in https://github.com/flutter/flutter/pull/24113


rich text editor remember draft?

Your use case
What would you like to do?
Before RTE, Element was remembering draft of unsent message when we were changing to an other room and coming back. I'd like RTE to be able to do the same.
Why would you like to do it?
Using RTE, if I'm composing a message and I need to look for some information in an other room, if I don't think I should copy/paste my draft before leaving the room, when I come back, I have to rewrite all the message as the draft has vanished
How would you like to achieve it?
RTE should remember drafts of last unsent message in each room.

Might be nice to sync drafts between clients too!

Thanks for your report @Thatoo
This library doesn't save any data that is typed (and it will probably never will, as its designed to be pure text processing - not to mention the security issues if it starts saving pairs of text and room information), but it does provide tools like set_content_from_html and set_content_from_markdown to the hosting application.
It's up to the application, so Element in your case, to save the partial messages and restore them in a new instance of the Rich Text Editor.

Good.
In this case, could you reopen my original request https://github.com/vector-im/element-web/issues/25135#event-9034892627 ? And then we could close this request.


segmentation fault (core dumped) running eQTL.Catalogue.query()

HI,
I am having this issue running eQTL.Catalogue.query. I thought It could be somehow related with tabix, so I updated the yaml file. I removed tabix, and added htslib to solve the environment again. The output did not change
r$> gwas.qtl_paths <- eQTL_Catalogue.query(sumstats_paths = sumstats_paths,
                                           qtl_search = c("myeloid","Alasoo_2018"),
                                           output_dir = "./catalogueR_queries",
                                           split_files = T,
                                           merge_with_gwas = T,
                                           force_new_subset = T,
                                           nThread=4)
[1] "++ R package `pbmcapply` not installed. Turning off `progress_bar`."
[1] "+ Optimizing multi-threading..."
[1] "++ Multi-threading across QTL datasets."
[1] "eQTL_Catalogue:: Querying 4 QTL datasets x 1 GWAS loci (4 total)"
Alasoo_2018.macrophage_naive
Alasoo_2018.macrophage_IFNg
Alasoo_2018.macrophage_Salmonella
Alasoo_2018.macrophage_IFNg+Salmonella
[1][1] "++ Extracting locus name from `sumstats_paths` names." "++ Extracting locus name from `sumstats_paths` names."

[1] "++ Extracting locus name from `sumstats_paths` names."
_+_+_+_+_+_+_+_+_--- Locus: BST1 ---_+_+_+_+_+_+_+_+_
_+_+_+_+_+_+_+_+_--- Locus: BST1 ---_+_+_+_+_+_+_+_+_
_+_+_+_+_+_+_+_+_--- Locus: BST1 ---_+_+_+_+_+_+_+_+_
[1] "++ Extracting locus name from `sumstats_paths` names."
_+_+_+_+_+_+_+_+_--- Locus: BST1 ---_+_+_+_+_+_+_+_+_
Start at 2022-02-02 14:39:32

Start at 2022-02-02 14:39:33

Start at 2022-02-02 14:39:33

Start at 2022-02-02 14:39:33

End at 2022-02-02 14:39:38
Runtime in total is: 6 secs

[1] "++ Inferring coordinates from gwas_data"

End at 2022-02-02 14:39:39
Runtime in total is: 6 secs

[1] "+ CONDA:: Identified tabix executable in echoR env."
[1] "/home/acarrasco/.conda/envs/echoR/bin/tabix ftp://ftp.ebi.ac.uk/pub/databases/spot/eQTL/csv/Alasoo_2018/ge/Alasoo_2018_ge_macrophage_IFNg+Salmonella.all.tsv.gz 4:14735725-16735661"
Segmentation fault (core dumped)
[1] "Data dimensions: 0 x 0"
[1] "++ Merging GWAS data and QTL query results."
[1] "Data dimensions: 0 x 0"
[1] "Data dimensions:  x "
[1] "+ Returning list of split query results files."
[1] "++ Inferring coordinates from gwas_data"

End at 2022-02-02 14:39:40
Runtime in total is: 7 secs

[1] "+ CONDA:: Identified tabix executable in echoR env."
[1] "/home/acarrasco/.conda/envs/echoR/bin/tabix ftp://ftp.ebi.ac.uk/pub/databases/spot/eQTL/csv/Alasoo_2018/ge/Alasoo_2018_ge_macrophage_naive.all.tsv.gz 4:14735725-16735661"
Segmentation fault (core dumped)
[1] "Data dimensions: 0 x 0"
[1] "++ Merging GWAS data and QTL query results."
[1] "Data dimensions: 0 x 0"
[1] "Data dimensions:  x "
[1] "+ Returning list of split query results files."
[1] "++ Inferring coordinates from gwas_data"
[1] "+ CONDA:: Identified tabix executable in echoR env."
[1] "/home/acarrasco/.conda/envs/echoR/bin/tabix ftp://ftp.ebi.ac.uk/pub/databases/spot/eQTL/csv/Alasoo_2018/ge/Alasoo_2018_ge_macrophage_IFNg.all.tsv.gz 4:14735725-16735661"
Segmentation fault (core dumped)
[1] "Data dimensions: 0 x 0"
[1] "++ Merging GWAS data and QTL query results."
[1] "Data dimensions: 0 x 0"
[1] "Data dimensions:  x "
[1] "+ Returning list of split query results files."
[1] "++ Returning list of split files paths."
[1] "Data dimensions:  x "
Time difference of 13.5 secs
Warning message:
In lapply_func(qtl_datasets, function(qtl_id, .sumstats_paths = sumstats_paths,  :
  scheduled core 3 encountered error in user code, all values of the job will be affected

r$> sumstats_paths
                                                                                BST1
"/home/acarrasco/.conda/envs/catalogueR_V2/lib/R/library/catalogueR/extdata/Nalls23andMe_2019/BST1_Nalls23andMe_2019_subset.tsv.gz"

r$> sessionInfo()
R version 4.1.2 (2021-11-01)
Platform: x86_64-conda-linux-gnu (64-bit)
Running under: Ubuntu 20.04.3 LTS

Matrix products: default
BLAS/LAPACK: /home/acarrasco/.conda/envs/catalogueR_V2/lib/libopenblasp-r0.3.18.so

locale:
 [1] LC_CTYPE=en_GB.UTF-8       LC_NUMERIC=C               LC_TIME=en_GB.UTF-8        LC_COLLATE=en_GB.UTF-8     LC_MONETARY=en_GB.UTF-8    LC_MESSAGES=en_GB.UTF-8    LC_PAPER=en_GB.UTF-8
 [8] LC_NAME=C                  LC_ADDRESS=C               LC_TELEPHONE=C             LC_MEASUREMENT=en_GB.UTF-8 LC_IDENTIFICATION=C

attached base packages:
[1] stats     graphics  grDevices utils     datasets  methods   base

other attached packages:
[1] reticulate_1.24   R.utils_2.11.0    R.oo_1.24.0       R.methodsS3_1.8.1 catalogueR_0.1.0

loaded via a namespace (and not attached):
 [1] Rcpp_1.0.8        pillar_1.7.0      compiler_4.1.2    prettyunits_1.1.1 remotes_2.4.2     tools_4.1.2       pkgbuild_1.3.1    jsonlite_1.7.3    lattice_0.20-45   lifecycle_1.0.1   tibble_3.1.6
[12] gtable_0.3.0      png_0.1-7         pkgconfig_2.0.3   rlang_1.0.0       Matrix_1.4-0      cli_3.1.1         DBI_1.1.2         parallel_4.1.2    curl_4.3.2        withr_2.4.3       dplyr_1.0.7
[23] generics_0.1.2    vctrs_0.3.8       rprojroot_2.0.2   grid_4.1.2        tidyselect_1.1.1  glue_1.6.1        data.table_1.14.2 R6_2.5.1          processx_3.5.2    fansi_1.0.2       callr_3.7.0
[34] purrr_0.3.4       ggplot2_3.3.5     magrittr_2.0.2    scales_1.1.1      ps_1.6.0          ellipsis_0.3.2    assertthat_0.2.1  colorspace_2.0-2  utf8_1.2.2        munsell_0.5.0     crayon_1.4.2

Update
I read #6, and thought it could make sense to try an install catalogueR directly on the echolocatoR conda env It did not work
Also, I read the README and made sure, I have data.table >1.14. Same error arised
r$> gwas.qtl_paths <- eQTL_Catalogue.query(sumstats_paths = sumstats_paths[1],
                                           qtl_search = c("myeloid","Alasoo_2018"),
                                           output_dir = "./catalogueR_queries",
                                           split_files = T,
                                           merge_with_gwas = T,
                                           force_new_subset = T,
                                           nThread=4)
[1] "++ R package `pbmcapply` not installed. Turning off `progress_bar`."
[1] "+ Optimizing multi-threading..."
[1] "++ Multi-threading across QTL datasets."
[1] "eQTL_Catalogue:: Querying 4 QTL datasets x 1 GWAS loci (4 total)"
Alasoo_2018.macrophage_naive
Alasoo_2018.macrophage_IFNg
Alasoo_2018.macrophage_Salmonella
Alasoo_2018.macrophage_IFNg+Salmonella
[1][1] "++ Extracting locus name from `sumstats_paths` names." "++ Extracting locus name from `sumstats_paths` names."

_+_+_+_+_+_+_+_+_--- Locus: BST1 ---_+_+_+_+_+_+_+_+_
_+_+_+_+_+_+_+_+_--- Locus: BST1 ---_+_+_+_+_+_+_+_+_
[1] "++ Extracting locus name from `sumstats_paths` names."
_+_+_+_+_+_+_+_+_--- Locus: BST1 ---_+_+_+_+_+_+_+_+_
[1] "++ Extracting locus name from `sumstats_paths` names."
_+_+_+_+_+_+_+_+_--- Locus: BST1 ---_+_+_+_+_+_+_+_+_
Start at 2022-02-03 14:30:21

Start at 2022-02-03 14:30:21

Start at 2022-02-03 14:30:21

Start at 2022-02-03 14:30:21

End at 2022-02-03 14:30:27
Runtime in total is: 6 secs

End at 2022-02-03 14:30:27
Runtime in total is: 6 secs

End at 2022-02-03 14:30:27
Runtime in total is: 6 secs

[1] "++ Inferring coordinates from gwas_data"
[1] "++ Inferring coordinates from gwas_data"
[1] "++ Inferring coordinates from gwas_data"

End at 2022-02-03 14:30:27
Runtime in total is: 6 secs

[1] "++ Inferring coordinates from gwas_data"
[1] "+ CONDA:: Identified tabix executable in echoR env."
[1] "/home/acarrasco/.conda/envs/echoR/bin/tabix ftp://ftp.ebi.ac.uk/pub/databases/spot/eQTL/csv/Alasoo_2018/ge/Alasoo_2018_ge_macrophage_IFNg+Salmonella.all.tsv.gz 4:14735725-16735661"
[1] "+ CONDA:: Identified tabix executable in echoR env."
[1] "/home/acarrasco/.conda/envs/echoR/bin/tabix ftp://ftp.ebi.ac.uk/pub/databases/spot/eQTL/csv/Alasoo_2018/ge/Alasoo_2018_ge_macrophage_Salmonella.all.tsv.gz 4:14735725-16735661"
[1] "+ CONDA:: Identified tabix executable in echoR env."
[1] "/home/acarrasco/.conda/envs/echoR/bin/tabix ftp://ftp.ebi.ac.uk/pub/databases/spot/eQTL/csv/Alasoo_2018/ge/Alasoo_2018_ge_macrophage_naive.all.tsv.gz 4:14735725-16735661"
[1] "+ CONDA:: Identified tabix executable in echoR env."
[1] "/home/acarrasco/.conda/envs/echoR/bin/tabix ftp://ftp.ebi.ac.uk/pub/databases/spot/eQTL/csv/Alasoo_2018/ge/Alasoo_2018_ge_macrophage_IFNg.all.tsv.gz 4:14735725-16735661"
Segmentation fault (core dumped)
Segmentation fault (core dumped)
Segmentation fault (core dumped)
Segmentation fault (core dumped)
[1] "Data dimensions: 0 x 0"
[1] "++ Merging GWAS data and QTL query results."
[1] "Data dimensions: 0 x 0"
[1] "Data dimensions:  x "
[1] "+ Returning list of split query results files."
[1] "Data dimensions: 0 x 0"
[1] "++ Merging GWAS data and QTL query results."
[1] "Data dimensions: 0 x 0"
[1] "Data dimensions:  x "
[1] "+ Returning list of split query results files."
[1] "Data dimensions: 0 x 0"
[1] "++ Merging GWAS data and QTL query results."
[1] "Data dimensions: 0 x 0"
[1] "Data dimensions:  x "
[1] "+ Returning list of split query results files."
[1] "Data dimensions: 0 x 0"
[1] "++ Merging GWAS data and QTL query results."
[1] "Data dimensions: 0 x 0"
[1] "Data dimensions:  x "
[1] "+ Returning list of split query results files."
[1] "++ Returning list of split files paths."
[1] "Data dimensions:  x "
Time difference of 10.6 secs
Warning message:
In lapply_func(qtl_datasets, function(qtl_id, .sumstats_paths = sumstats_paths,  :
  scheduled core 3 encountered error in user code, all values of the job will be affected

r$> sessionInfo()
R version 4.0.5 (2021-03-31)
Platform: x86_64-conda-linux-gnu (64-bit)
Running under: Ubuntu 20.04.3 LTS

Matrix products: default
BLAS/LAPACK: /home/acarrasco/.conda/envs/catalogue_V3/lib/libopenblasp-r0.3.18.so

locale:
 [1] LC_CTYPE=en_GB.UTF-8       LC_NUMERIC=C               LC_TIME=en_GB.UTF-8        LC_COLLATE=en_GB.UTF-8     LC_MONETARY=en_GB.UTF-8    LC_MESSAGES=en_GB.UTF-8    LC_PAPER=en_GB.UTF-8
 [8] LC_NAME=C                  LC_ADDRESS=C               LC_TELEPHONE=C             LC_MEASUREMENT=en_GB.UTF-8 LC_IDENTIFICATION=C

attached base packages:
[1] stats     graphics  grDevices utils     datasets  methods   base

other attached packages:
[1] R.utils_2.11.0    R.oo_1.24.0       R.methodsS3_1.8.1 reticulate_1.24   data.table_1.13.6 catalogueR_0.1.0

loaded via a namespace (and not attached):
 [1] tidyselect_1.1.1  remotes_2.4.2     purrr_0.3.4       haven_2.4.3       lattice_0.20-45   colorspace_2.0-2  vctrs_0.3.8       generics_0.1.2    utf8_1.2.2        rlang_1.0.1       pkgbuild_1.3.1
[12] pillar_1.7.0      glue_1.6.1        withr_2.4.3       DBI_1.1.2         dbplyr_2.1.1      modelr_0.1.8      lifecycle_1.0.1   munsell_0.5.0     gtable_0.3.0      forcats_0.5.1     callr_3.7.0
[23] tzdb_0.2.0        ps_1.6.0          curl_4.3.2        parallel_4.0.5    fansi_1.0.2       broom_0.7.12      Rcpp_1.0.8        readr_2.1.2       scales_1.1.1      backports_1.4.1   jsonlite_1.7.3
[34] ggplot2_3.3.5     hms_1.1.1         png_0.1-7         processx_3.5.2    dplyr_1.0.7       grid_4.0.5        rprojroot_2.0.2   cli_3.1.1         tools_4.0.5       magrittr_2.0.2    tibble_3.1.6
[45] crayon_1.4.2      tidyr_1.2.0       pkgconfig_2.0.3   ellipsis_0.3.2    Matrix_1.4-0      prettyunits_1.1.1 lubridate_1.8.0   assertthat_0.2.1  httr_1.4.2        R6_2.5.1          compiler_4.0.5

Hi @AMCalejandro, I've just finished a major overhaul of catalogueR to make it compatible with the echoverse.
Could you try reinstalling catalogueR and running this example?
sumstats_paths <- echodata::get_Nalls2019_loci(limit_snps = 10)
GWAS.QTL <- catalogueR::eQTLcatalogue_query(
    sumstats_paths = sumstats_paths$BST1,
    qtl_search = "Alasoo_2018.macrophage_naive")


Scala 2.12 release artifact for 1.0.0-RC1 is empty

I tried referencing this library in a 2.12 project, but the jar it pulls down contains nothing other than jar metadata.
https://search.maven.org/artifact/com.vladkopanev/cats-saga_2.12/1.0.0-RC1/jar

Hey @seglo I'm sorry for the long response time, yeah you are right, I've checked and for some reason, the artefact for 2.12 is empty when downloaded from maven, this is strange because publishLocal produces a fully packed jar! I think maybe it has something to do with "sbt-release-early" plugin, that plugin looks like it is not supported anymore and maybe has some incompatibilities with the latest sbt version released when used against scala 2.12. Unfortunately, this issue is hard to investigate right now, and also to fix as the plugin is not supported anymore, and the only solution I see is to migrate to release plugins that are still supported. Pls, let me know if this is crucial for you to have a release for 2.12 and you can't migrate to new Scala versions and I will try to do something about it.

No worries! I found an alternative on the project I was working on at the time.


TerraScreenshotCollector returns screenshots for the resolved name from other spec files too

Steps to reproduce
When collecting related screenshots for various features e.g. gutter icons, they are returned for screenshots not just for the containing spec file but other spec files too, if the screenshot name matches.

Create a spec file S1 with a validation for screenshot A.
Create a spec file S2 with a validation for screenshot B where B has the same name as A.
Execute one of the collection methods in TerraScreenshotCollector for S1.

Expected results
The collection should return only A, but not B because B is not in the source spec file.
Actual results
The collection returns A and B as well because they have the same name.
Technical notes

Related parts:

TerraScreenshotValidationLineMarkerProvider
MissingScreenshotInspection
TerraScreenshotReference

Unit test data will need to be reorganized as well.

Versions affected
0.3.0, 0.3.1, 0.4.0
Out of scope

N/A

Completed on release branch.


Automator: update istio/client-go@master dependency in istio/istio@master

Generated by Automator - 2022-10-21T18:23:16+00:00

@istio-testing: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

integ-helm_istio
cd8b4a9c19aef179366f4259f63237858766e37f
link
true
/test integ-helm

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

/test integ-helm

I'll update this manually.


Update Spark tests that use wildcard query

There were some issues fixed with the Wildcard query in https://github.com/elastic/elasticsearch/pull/53127 that now cause a few tests to fail in ES-Hadoop. Looking through the logic, it seems that the tests were originally written with the incorrect behavior in mind. This PR updates them to run again.

Fixes #1456


Merge OTP 18.3.2 onto Basho's version

Looks like the previous merge was 18.2.3

erlang:OTP-18.3.2 has been merged into basho:basho-otp-18.
erlang:maint has been merged into basho:maint.

Thanks, @tburghart!


Add interface type to the "null concrete type" message in the service locator

Recently, enhanced log messages were added to the service locator object to help developers better understand which service(s) were failing to register. This change adds the interface type name to the message regarding attempting to register a null instance.
This was hit by one of our customers who reached out to me with the issue,

/azp run mrtk_pr


Call changed callbacks after all bound properties are assigned during the initial bind phase

This is a request to change the timing of when changed callbacks are called during the bind() phase.
Current timing: The changed callbacks are invoked progressively, as the bound properties are set. The order in which they are called is not guaranteed.
Therefore this code does not work because in one changed callback the other property will not be bound yet:
@bindable attr1;
@bindable attr2;
attr1Changed(){
   this.DoSometingWith(this.attr1, this.attr2);
}
attr2Changed(){
   this.DoSometingWith(this.attr1, this.attr2);
}

Proposed timing: The changed callbacks should be invoked after all bound properties are set.
I have already discussed this with @EisenbergEffect.

@EisenbergEffect what were your thoughts on this ^^

It's something we could do. I haven't looked into it to see how easy/hard it would be. The logic is in the Controller class's bind method. My only concern is that changing this might affect perf or memory negatively. I need to dig in though...

@jdanyow This may not be that hard to change. See here: https://github.com/aurelia/templating/blob/master/src/controller.js#L107 We could remove the code related to self subscribers and then after the first loop, check to see if we aren't supposed to skip, and if so, loop again, invoking the callbacks. I think that would do it. I'm not sure if this would be a big perf change or not though, for scenarios where there were bindables and no bind callback. What do you think?

Sounds like a good plan to me. If I had to guess I'd bet that it doesn't impact the templating benchmarks.

@EisenbergEffect We already have bind to handle this case. Does the plan mean we separate the logic call after all properties bound out of bind to changed ?

It's about timing. In the event where someone does not have a bind, the first time the change callbacks are called as part of the binding phase, they would/should all be called together after all properties are bound. Right now each callback is fired after each property is bound.

could not find the issue recently closed by @EisenbergEffect
with a comment that a new lifecycle event 'bound' will be introduced in vNext
guess that would solve this
maybe can be closed

This is a bit different. But, I don't think we're going to make the exact change proposed by this issue. Instead, we'll probably consistently fire a bound event and property change events.


Shaka Error MANIFEST.UNPLAYABLE_PERIOD ()

What version of Shaka Player are you using?
Shaka Player v2.1.0-debug

Can you reproduce the issue with our latest release version?
yes

Can you reproduce the issue with the latest code from master?
Stream plays ok with 2.0.8

Are you using the demo app or your own custom app?
demo and custom

If custom app, can you reproduce the issue using our demo app?
yes

What browser and OS are you using?
Fedora Linux 24 @ Chrome 58

What did you do?
Trying to play https://av-cdn-1.wpimg.pl/wptv/preview_2/manifest.mpd

What content did you load?
https://av-cdn-1.wpimg.pl/wptv/preview_2/manifest.mpd

If custom asset, what manifest and license server URIs?
https://av-cdn-1.wpimg.pl/wptv/preview_2/manifest.mpd

How did you interact with the content, if at all?
load

What did you expect to happen?
stream playing

What actually happened?
Shaka Error MANIFEST.UNPLAYABLE_PERIOD ()

Hi @pszemus,
This piece of content has a video codec of "avc1.4d001f" (aka h.264) and an audio codec of "mp4a.40.34" (aka mp3).  This video codec is supported by the browser, but the audio codec is not.
In v2.0, our internal model kept video and audio separate.  So in v2.0.x, this plays as a video-only clip.
In v2.1, we changed to a model in which video and audio combinations are modeled as variants.  In this model, none of the variants in your content are playable, because all variants use an audio codec that is not supported by the browser.
I don't think it makes sense for us to play in video-only mode or audio-only mode for content that is clearly meant to have both video and audio.  What do you think?

Hi @joeyparrish
I thought the same untill I tried VLC and DASH-IF players that can play that stream as a video-only stream. Nevertheless it's not a bug nor regression, but a feature to consider.

Thanks.  We will consider it.

@pszemus, I have discussed this issue with our product managers, and we have decided not to pursue support for video-only playback in content that contains an audio stream.  If content contains audio, ignoring the audio without throwing an error would not be a desirable user experience.  The same is true of content which contains unplayable video.  Ignoring the video stream while playing audio-only would not make sense for the end user.
I apologize for any inconvenience this causes you.


Setup Travis CI for the master branch

Is it possible to set up Travis CI to build the master branch in addition to the gwt/2.8 branch?
This would show us build issues in the main branch as well.

I was wrong, the master branch is already build - I was just looking on the wrong branch of README.md.


ci: improve and simplify metrics collection

Remove support for metrics_token (no longer needed since #452).
Configure self-ci to use the new mechnism to report metrics for the CI and bridge.

Closing for now. Most of this PR has already been merged, but we can't remove metrics_token until one last user no longer needs it.


Move to new sbt/librarymanagemento

Currently zincIvyIntegration and zinc tests fail..
Something about not being able to find xsbti classes (which come from util-interface).
Ideas to unblock this - very welcome. Thanks.

It seems like you published https://github.com/sbt/util/releases/tag/v0.1.0-M15 but didn't sync it to Maven Central - https://repo1.maven.org/maven2/org/scala-sbt/util-interface/
So you're hitting a legitimate issue. You need to sync it from https://bintray.com/sbt/maven-releases/util/0.1.0-M15#central

Done. But it still hasn't fixed the issue..


Error processing server's data

I´m getting this issue with pokemap version 3.1.0
Error processing server's data: Error Domain=NSCocoaErrorDomain Code=3840 "JSON text did not start with array or object and option to allow fragments not set." UserInfo={NSDebugDescription=JSON text did not start with array or object and option to allow fragments not set.}
Does anyone know why?

Have you still got the same problem?

No, I think was PokemonGoMap issue, the server response html code before the json data. On the latest release works like a charm


sort the location of objects

Hi,
How to sort the position of objects after detection?
i use yolo for character recognition and have to sort character after detection.
in below code i saw to sort by clss:
def draw_bboxes(self, img, boxes, confs, clss):
"""Draw detected bounding boxes on the original image."""
for bb, cf, cl in zip(boxes, confs, clss):
where and how can sort by position of objects (for example left to right for car plate recognition).
so that the zip(boxes, confs, clss] sort only based on "x_min" of the boxes.
Many Thanks.

The best place in the visualization section and below:
def draw_bboxes(self, img, boxes, confs, clss):
"""Draw detected bounding boxes on the original image."""
n = len(clss)
plate = np.array([[0, 0, 0]])
for bb, cf, cl in zip(boxes, confs, clss):
cl = int(cl)
x_min, y_min, x_max, y_max = bb[0], bb[1], bb[2], bb[3]
color = self.colors[cl]
cv2.rectangle(img, (x_min, y_min), (x_max, y_max), color, 2)
txt_loc = (max(x_min+2, 0), max(y_min+2, 0))
cls_name = self.cls_dict.get(cl, 'CLS{}'.format(cl))
txt = '{} {:.2f}'.format(cls_name, cf)
img = draw_boxed_text(img, txt, txt_loc, color)
**     plate = np.append(plate, [[x_min, cf, cls_name]], axis = 0)
**    plate = np.delete(plate, 0, axis=0)
**    plate = plate[plate[:,0].astype(int).argsort()]
**    plate = plate[:,2]
return img

Sorting by topleft x-coordinate of the bounding boxes should be straightforward.  You could do something like the following:
    # bb[0] is the x_min coordinate of the bbox
    sorted_indices = np.argsort([bb[0] for bb in bboxes])
    for i in sorted_indices:
        bb = bboxes[i]
        x_min, y_min, x_max, y_max = bb[0], bb[1], bb[2], bb[3]
        cl = int(clss[i])
        ......


feat: Load BMT from MMR peaks

Related PRs:

Closes #122

Thank you for the thorough review @freesig!
In general, this crate was not designed with arithmetic safety as a high priority. Specifically, there are instances of additions (increments) and multiplication that may overflow when we reach the extreme upper bounds of the u64 space. We use u64 in the following (likely not exhaustive):

Leaves counts
Proof indices
Positions (indices for tree nodes)

Leaves count is simply an incremental counter of the number of leaves in a tree. It starts at 0 and increments with each push.
The proof index is a value that must lie between [0, leaves_count] for a BMT.
Positions store the in-order index of a tree node. The highest in-order index will be the tree's leaves_count * 2 - 1. This means we require an integer space of 2^(N + 1) where N is the leaves count. Therefore, we may limit the leaves count to 2^63 in order to support the index space.
We should consider the risk this poses in the context of real use. Do we suspect it is possible to reach the upper limits of the u64 space?

We could do a similar effort to the VM where we use the new clippy lint arithmetic_side_effects to protect against unexpected arithmetic behaviors. Typically the client will manage the interactions with the merkle tree so the risks should be low, but if we ever allow user provided input to select parameters like a "tree version" we'd want to make sure there are no uncaught edge cases.

If we want to review the arithmetic safety of this crate, we can do that in a separate, focused effort.

Yep that sounds like a good approach.

I'm creating a new issue to address overall arithmetic safety: https://github.com/FuelLabs/fuel-merkle/issues/124.


Create a 3D map coordinate struct

We should create a 3D map coordinate struct, so a full map location can be completely specified with one compound value. We should then update many of the map functions to use the compound struct.

Added an issue engine-side to address this.

Vectors and Points are different. They have subtly different operations. They just seem similar because they both have the same data fields.


Confirm Prettier + CI + VS Code setup

I've run into a CI lint error with #35. It seems that prettier format write on save hadn't run on the file locally because of this prettier ignore line. More insight in this comment.
Still investigating, let me know what you guys think.

currently investigating. annoying issue. may i be right that this only concerns lint-staged and not the new pnpm run lint:all command? because we only have one lint-staged in the root and therefore prettier only runs from the root in this case?
fyi you can attach —loglevel debug to prettier commands and —verbose to the lint-staged command to see which files are taken into account. but you don’t have to, i’m already digging deeper right now 🙂

After some more investigation, I think my initial assumption was correct. Please double-check, @raulrpearson.
One more tip for debugging is to use another code editor or temporarily deactivate the code-actions-on-save in VSCode. Also, don't forget to actually stage the files that they are taken into account by lint-staged.


Use cobra to implement superadmin and other administrative commands, versus running the server

It is rather inconvenient to access the migration cli as a separate app from our main server app.
Let's unify them with spf13/cobra so we can issue consistent command line commands from our project root.

We choose spf13/cobra over urfave/cli because cobra supports subcommands.

[ ] by default, run our API server
[ ] command to create database
[ ] command to create database user
[ ] command to create schema
[ ] command to initialise schema migration table
[ ] command to run all available migrations
[ ] command to run migrations up to the target one
[ ] command to revert last migration
[ ] command to reset all migrations
[ ] command to print current db (schema) version
[ ] command to set db (schema) version without running migrations


Is there a way to get transparent background for segments?

My terminal has a transparent background so I'd like to have one or two segment backgrounds to be transparent while keeping the foreground a solid color.

Well. It would kinda work if you set the background for the segments to an invalid value like POWERLEVEL9K_TIME_BACKGROUND="none".
Kind of, because it would look different from what you want (at least, if you don't use flat mode). To go a bit into detail here: The separating glyph (a.k.a. POWERLEVEL9K_LEFT_SEGMENT_SEPARATOR) is a real character, which has the same foreground color as the preceding segments background color. That is how we achieve the effect of the segments.
Long story short: If you "disable" the background color of a segment, the separator will still be printed in some color (at least in the terminal emulators default color).

Ahh I see, probably better to stick with a colored background then. Thanks!

Super noob question here: Is there a way to make separator character's foreground transparent as well?

@dritter Super noob question here: Is there a way to make separator character's foreground transparent as well?

@giogziro95 Short answer: unfortunately not.
Transparency is a feature of your Terminal Emulator. So, from the point of view of your Terminal Emulator all you get from P9K/ZSH is the advice to print a character in a specific color (or to print a background color). But it cannot distinguish between the separator and normal characters. This is because the separator is a normal character and not printed in the background. In ZSH you just can send a control character to start or stop a background color. The Terminal Emulator just starts from that point the background color in the line height, which results in a rectangular shape. To create the illusion of that segments we print the separator in the same background color..

@dritter Thanks for your response. And I'm not that noob; I know about escape codes and how Zsh is doing the tricks. What I was asking was if there was a way to print a character that's transparent/invisible. Obviously, this depends on the terminal emulator as well, and I assumed that there was no way before even finding this issue, but I decided to try anyway. So, apparently, the answer is no, and that's what I was expecting.
Another solution could be not printing the separator character at all, but that would probably require messing with the theme scripts if you need to do this only in one segment. Am I wrong?

@giogziro95 You could deactivate the separators at all, just set POWERLEVEL9K_LEFT_SEGMENT_SEPARATOR='' ;)

@dritter Yeah, I know, but that would deactivate all separators as well. 😂

:D There is no easy way to disable the separator for a specific segment. Sorry.

Depending on the circumstances you could use a joined segment to not have a separator show up. I use this for a couple segments I want to appear 'together' - though I don't know of anything that will allow you to have transparent characters in a terminal.

Ha! Right @rjorgenson That is an easy way to accomplish this.. 👍

@rjorgenson Thanks. However, that wouldn't work either since my goal was to remove this very last (well, the one on the left) character which can't be done through that. Anyway, not a dealbreaker. I can live without that. 🙂

@rjorgenson Thanks. However, that wouldn't work either since my goal was to remove this very last (well, the one on the left) character which can't be done through that. Anyway, not a dealbreaker.  Nope, you misunderstood. I just gave it a nice lite grey background. That should do it for now.