download picture issue

//a href="javascript:;" ng-click="download('http://pic1.nipic.com/2008-09-08/200898163242920_2.jpg')">download a//
then i use angular access to the route;
exports.download=function (req,res) {
var url=req.params.url;
var start=url.lastIndexOf('/')+1;
var stop=url.length;
var fileName=url.substring(start,stop);
res.download(url,fileName,function (err) {
if(err){
console.log('downloadError',err);
}else{
return res.send(200,{code:0});
}
});
};
it throws the error:
{ [Error: ENOENT, stat 'http://pic1.nipic.com/2008-09-08/200898163242920_2.jpg']
errno: 34,
code: 'ENOENT',
path: 'http://<IP_ADDRESS>:8081/cdrb/sd_image/20150630/a21ea8d0-1ecf-11e5-bb81-00163e0013bc_m.jpg',
status: 404 }

Hi! In Express, you can only use the res.download method with file system paths; it does not work with URLs, which is why you are getting that message.
You can read more about res.download on http://expressjs.com/4x/api.html but the summary is that it doesn't download something from the Internet, rather it is used to offer a file on your file system for download.


feat: add default in exports field

According to https://nodejs.org/api/packages.html#conditional-exports, it should be better if there had a  default field.

Is that webpack that wants a "default" export? Isn't it surprising that webpack doesn't consider the "browser" export?

I went ahead and removed the "default" condition for the main "." entry (I don't think it's needed). Only question left: can we use something more explicit than "default" for the "/server" entry? E.g. maybe even "webpack", if webpack has it &ndash that'd be super explicit.

Do you know whether webpak has "server" in its conditions?

I don't remember this happening

what webpack's conditions are when it isn't targeting the browser?

"web"(or "webworker"): ["import", "module", "webpack","development","browser"]
"node": ["require", "module", "webpack", "development", "browser"]

I went ahead and removed the "default" condition for the main "." entry (I don't think it's needed).

Yes, node and browser  already cover almost all cases.

can we use something more explicit than "default" for the "/server" entry

This is up to you (my opinion is to use default), but I recommend not using webpack, because tools like vite may not have this default value?

Fix released at<EMAIL_ADDRESS>You're right and I've drastically simplified the exports to this:
  "exports": {
    ".": {
      "node": "./dist/cjs/server/hooks.js",
      "default": "./dist/esm/client/hooks.js"
    },
    "./server": {
      "node": "./dist/cjs/server/index.js",
      "default": "./dist/esm/server/index.js"
    }
  }

Let's see if that one is going to work out. Hopefully so!


Integrations with Kubernetes Distros & Installers

One of the focuses of Trow is to be easy to install. To that end, we should try to integrate with other projects. These needs to go beyond just "works with", In a lot of cases we can aim to be a "plugin" or similar.
This should include:
[ ] minikube addon https://minikube.sigs.k8s.io/docs/handbook/deploying/#addons
[ ] microk8s addon https://microk8s.io/docs/addons#heading--list
[ ] kubestack install https://www.kubestack.com/catalog
[ ] arkade https://github.com/alexellis/arkade

If you want to work on any of these, please discuss here and then we can open a new issue for the specific platform.

I'm setting something up with k3d on #193

Not happening, we have helm


more work

adds search and videos endpoints
and improves readme

oops, didn't look what I had done before. #32 is the same as this....

aborting 32 and reapplying this, sorry...


DataStore - Sync error  - UnauthorizedException

I receive this error:
DataStore - Sync error – "subscription failed Connection failed: {\"errors\":[{\"errorType\":\"UnauthorizedException\",\"message\":\"Permission denied\"}]}"
While I run this code:
Auth.currentCredentials()       .then(d => console.log("data: ", d))       .catch(e => console.log("error: ", e));
before
this.init = DataStore.observe(Quiz).subscribe();
with this schema:
type Quiz
  @model
  @auth(
    rules: [
      { allow: public, provider: iam, operations: [read] }
      { allow: owner }
    ]
  ) {
  id: ID!
  title: String!
  seconds: Int!
  currentQuestion: String
  questionOrder: String
  started: Boolean
  questionTime: Int
  view: Int
  owner: String!
}

type Questions
  @model
  @auth(
    rules: [
      { allow: public, provider: iam, operations: [read] }
      { allow: owner }
    ]
  ) {
  id: ID!
  image: String
  youtube: String
  question: String!
  answerOne: String
  answerOneCorrect: Boolean
  answerTwo: String
  answerTwoCorrect: Boolean
  answerThree: String
  answerThreeCorrect: Boolean
  answerFour: String
  answerFourCorrect: Boolean
  quizID: String!
  order: Int
  public: Boolean
  fromLibrary: Boolean
  category: String
}
type QuestionsDB
  @model
  @auth(
    rules: [
      { allow: public, provider: iam, operations: [read] }
      { allow: owner }
    ]
  ) {
  id: ID!
  image: String
  youtube: String
  question: String!
  answerOne: String
  answerOneCorrect: Boolean
  answerTwo: String
  answerTwoCorrect: Boolean
  answerThree: String
  answerThreeCorrect: Boolean
  answerFour: String
  answerFourCorrect: Boolean
  relatedQuestion: String!
  public: Boolean
  category: String
  language: String
}

type Subscribers @model @auth(rules: [{ allow: public, provider: iam }]) {
  id: ID!
  type: String!
  score: Int!
  quizID: String!
  name: String!
}

type Responses @model @auth(rules: [{ allow: public, provider: iam }]) {
  id: ID!
  quiz: String!
  subscriber: String!
  question: String!
}
type Languages
  @model
  @auth(rules: [{ allow: public, provider: iam }])
  @key(name: "ByCode", fields: ["type", "code"], queryField: "getLangByCode") {
  id: ID!
  type: String!
  code: String!
}

Transferring this over per my conversation with @edwardfoyle.
I was able to reproduce this issue using the following simplified schema (and explicitly turning off subscription authorization on the model).
When I try to subscribe to changes on this model with DataStore as an unauthed user, I get the error: "DataStore - Sync error subscription failed Connection failed: {"errors":{"errorType":"UnauthorizedException","message":"Permission denied”}}"

Unauthed Identities are enabled on the Identity Pool
API Auth is configured with IAM and User Pools (IAM is default)
Neither the authed nor the unauthed IAM roles have any explicit permissions for subscriptions, but I’m able to subscribe successfully with the authed role, e.g. via the AppSync console.

Here's the schema:
type Quiz
  @model(subscriptions: { level: public })
  @auth(
    rules: [
      { allow: owner },
      { allow: public, provider: iam, operations: [read] }
    ]
  ) {
  id: ID!
  title: String!
  seconds: Int!
  currentQuestion: String
  questionOrder: String
  started: Boolean
  questionTime: Int
  view: Int
  owner: String!
}

App.js I'm using to reproduce the error:
import React from 'react';
import Amplify from 'aws-amplify';
import { DataStore } from '@aws-amplify/datastore';
import aws_exports from './aws-exports';
import { Quiz } from './models';

Amplify.configure(aws_exports);

DataStore.observe(Quiz).subscribe((msg) => {
  console.log(msg.model, msg.opType, msg.element);
});

const App = () => <></>;

export default App;

Here's the generated IAM policy (idential for authed and unauthed roles):
{
    "Version": "2012-10-17",
    "Statement": [
        {
            "Action": [
                "appsync:GraphQL"
            ],
            "Resource": [
                "arn:aws:appsync:us-east-1:xxxxxapis/xxxxxxxxxx/types/Quiz/*",
                "arn:aws:appsync:us-east-1:xxxxx:apis/xxxxxxxxxx/types/Query/fields/getQuiz",
                "arn:aws:appsync:us-east-1:xxxxx:apis/xxxxxxxxxx/types/Query/fields/listQuizs",
                "arn:aws:appsync:us-east-1:xxxxx:apis/xxxxxxxxxxtypes/Query/fields/syncQuizzes"
            ],
            "Effect": "Allow"
        }
    ]
}

Any ideas what it can be? Can I help in any way?

@SwaySway - can you provide details if your PR is addressing this issue?

PR addresses this issue by creating the necessary policies for subscriptions when the auth rule read is applied.
Closing this issue as the fix has been addressed and released into version 4.21.1.

With this schema:
type User
  @model
  @key(fields: ["id", "horecaID"])
  @key(name: "byHoreca", fields: ["horecaID"])
  @auth(
    rules: [
      { allow: groups, groups: ["owner", "supervisor"] }
      { allow: owner, ownerField: "owner", identityClaim: "custom:horeca" }
    ]
  ) {
  id: ID!
  horecaID: ID!
  owner: ID!
  name: String!
  lastDateLogin: String
  group: Group
}

I face this issue again. This time it is on react native with an authenticated users. This is my package.json:
{
"main": "node_modules/expo/AppEntry.js",
"scripts": {
"start": "expo start",
"android": "expo start --android",
"ios": "expo start --ios",
"web": "expo start --web",
"eject": "expo eject",
"amplify-modelgen": "node amplify/scripts/amplify-modelgen.js",
"amplify-push": "node amplify/scripts/amplify-push.js"
},
"dependencies": {
"@aws-amplify/analytics": "^3.3.6",
"@aws-amplify/api": "^3.2.6",
"@aws-amplify/auth": "^3.4.6",
"@aws-amplify/core": "^3.6.0",
"@aws-amplify/datastore": "^2.6.0",
"@expo/vector-icons": "^10.0.0",
"@react-native-community/masked-view": "0.1.10",
"@react-native-community/netinfo": "5.9.6",
"@react-navigation/bottom-tabs": "^5.6.1",
"@react-navigation/native": "^5.7.5",
"@react-navigation/stack": "^5.6.2",
"aws-amplify-react": "^4.2.7",
"expo": "~39.0.2",
"expo-constants": "~9.2.0",
"expo-status-bar": "~1.0.2",
"lottie-react-native": "~2.6.1",
"react": "16.13.1",
"react-dom": "16.13.1",
"react-native": "https://github.com/expo/react-native/archive/sdk-39.0.2.tar.gz",
"react-native-error-boundary": "^1.1.3",
"react-native-gesture-handler": "~1.7.0",
"react-native-reanimated": "~1.13.0",
"react-native-safe-area-context": "3.1.4",
"react-native-screens": "~2.10.1",
"react-native-tiny-toast": "^1.0.7",
"react-native-web": "~0.13.12"
},
"devDependencies": {
"@types/react": "~16.9.35",
"@types/react-dom": "~16.9.8",
"@types/react-native": "~0.63.2",
"ini": "^1.3.5",
"inquirer": "^6.5.1",
"typescript": "~3.9.5"
},
"private": true
}

@renebrandel @SwaySway: can you re-open this issue?

We are getting the same problem with our React Native + Expo app.

@ltaljaard same versions like I have used?

This is the error we are getting:
[Unhandled promise rejection: Error: UnauthorizedException]

node_modules/@aws-amplify/pubsub/lib-esm/Providers/AWSAppSyncRealTimeProvider.js:714:29 in __generator$argument_1

http://<IP_ADDRESS>:19001/node_modules/expo/AppEntry.bundle?platform=ios&dev=true&minify=false&hot=false:133744:23 in step

node_modules/tslib/tslib.js:122:34 in
node_modules/tslib/tslib.js:113:43 in rejected
... 7 more stack frames from framework internals

package.json:
{
"main": "node_modules/expo/AppEntry.js",
"scripts": {
"start": "expo start",
"android": "expo start --android",
"ios": "expo start --ios",
"web": "expo start --web",
"eject": "expo eject",
"amplify-modelgen": "node amplify/scripts/amplify-modelgen.js",
"amplify-push": "node amplify/scripts/amplify-push.js"
},
"dependencies": {
"@aws-amplify/core": "^3.4.0",
"@aws-amplify/datastore": "^2.2.4",
"@expo/vector-icons": "^10.0.0",
"@react-native-community/masked-view": "0.1.6",
"@react-native-community/netinfo": "5.5.1",
"@react-navigation/drawer": "^5.8.2",
"@react-navigation/material-bottom-tabs": "^5.2.10",
"@react-navigation/native": "^5.5.1",
"@react-navigation/stack": "^5.5.1",
"aws-amplify": "^3.0.18",
"aws-amplify-react-native": "^4.2.1",
"expo": "~37.0.3",
"moment": "^2.27.0",
"react": "~16.9.0",
"react-dom": "~16.9.0",
"react-native": "https://github.com/expo/react-native/archive/sdk-37.0.1.tar.gz",
"react-native-action-button": "^2.8.5",
"react-native-elements": "^2.0.2",
"react-native-gesture-handler": "~1.6.0",
"react-native-paper": "^3.10.1",
"react-native-reanimated": "~1.7.0",
"react-native-safe-area-context": "0.7.3",
"react-native-screens": "~2.2.0",
"react-native-web": "~0.11.7"
},
"devDependencies": {
"@babel/core": "^7.8.6",
"babel-preset-expo": "~8.1.0",
"ini": "^1.3.5",
"inquirer": "^6.5.1"
},
"private": true
}
AWS-exports.js:
const awsmobile = {
"aws_project_region": "eu-west-1",
"aws_appsync_graphqlEndpoint": "https://amazonaws.com/graphql",
"aws_appsync_region": "eu-west-1",
"aws_appsync_authenticationType": "API_KEY",
"aws_appsync_apiKey": "",
"aws_cognito_identity_pool_id": "eu-west-",
"aws_cognito_region": "eu-west-1",
"aws_user_pools_id": "",
"aws_user_pools_web_client_id": "***",
"oauth": {}
};
export default awsmobile;

@rpostulart
Based on the provided schema when running datastore operations it will attempt to run authorization with owner auth. When the you get the error that they are unauthorized is it because the current signed in user is not the owner but they exist in the group? You can view this by enabling the logger, logger docs: https://docs.amplify.aws/lib/utilities/logger/q/platform/js
@ltaljaard
Is your schema similar to that of @rpostulart ? Could you provide your schema if it's different as well as the logs?

@SwaySway my schema looks like this and a while back it was working fine without this issue.
The link to the logger docs doesn't want to open, could you check that it's the right one?
type VAddress @auth(rules: [{ allow: public }])
@model
{ id: ID!
line1: String
line2: String
line3: String
line4: String
}

I'm seeing the same behavior.  I'm using iam auth to populate read-only, global content from a content management system.  Then using cognito to authenticate by group to grant access to "Everyone" (which is the group users are assigned to on sign up using a lambda). Here's an excerpt from my schema:
type Trail @model  @auth(
    rules: [
      { allow: private, provider: iam, operations: [read, update, create, delete] },
      { allow: groups, groups: ["Everyone"], operations: [read] }
    ]
  ) {
    id: ID!
    Name: String!
    strapiId: Int!
    fallacyId: Int!
    Order: Int!
    swatchId: Int!
}
type Screen @model  @auth(
    rules: [
      { allow: private, provider: iam, operations: [read, update, create, delete] }
      { allow: groups, groups: ["Everyone"], operations: [read] }
    ]
  ) {
    id: ID!
    strapiId: Int!
    Title: String!
    Content: String!
    ButtonText: String!
    ScoreIndicator: Boolean
    trailId: Int!
    Order: Int!
    OverrideCartoonUrl: String
    QuizId: Int
    uncleId: Int
    PointValue: Int
}

type Category @model @auth(
    rules: [
      { allow: private, provider: iam, operations: [read, update, create, delete] }
      { allow: groups, groups: ["Everyone"], operations: [read] }
    ]
  ) {
    id: ID!
    strapiId: Int!
    Name: String!
}

type Swatch @model  @auth(
    rules: [
      { allow: private, provider: iam, operations: [read, update, create, delete] }
      { allow: groups, groups: ["Everyone"], operations: [read] }
    ]
  ) {
    id: ID!
    strapiId: Int!
    Name: String!
    Solid: String!
    GradientTop: String!
    GradientBottom: String!
}

When I turn logging up to DEBUG as described in the link above, it's obviously a massive amount of output, as I've got about a dozen object types in datastore, auth, pinpoint, etc.  But here's the full stanza related to the unauthorized exception:
ConsoleLogger.js?721f:97 [DEBUG] 58:58.843 AWSAppSyncRealTimeProvider - subscription message from AWS AppSyncRealTime: {"type":"connection_ack","payload":{"connectionTimeoutMs":300000}}
3ConsoleLogger.js?721f:97 [DEBUG] 58:58.843 AWSAppSyncRealTimeProvider - Notifying connection successful
8ConsoleLogger.js?721f:97 [DEBUG] 58:58.844 AWSAppSyncRealTimeProvider - Notifying connection successful
10ConsoleLogger.js?721f:97 [DEBUG] 58:58.845 AWSAppSyncRealTimeProvider - Notifying connection successful
10ConsoleLogger.js?721f:97 [DEBUG] 58:58.846 AWSAppSyncRealTimeProvider - Notifying connection successful
8ConsoleLogger.js?721f:97 [DEBUG] 58:58.847 AWSAppSyncRealTimeProvider - Notifying connection successful
ConsoleLogger.js?721f:97 [DEBUG] 58:58.851 AWSAppSyncRealTimeProvider - subscription message from AWS AppSync RealTime: {"type":"ka"}
ConsoleLogger.js?721f:100 [DEBUG] 58:58.851 AWSAppSyncRealTimeProvider {id: "", observer: null, query: "", variables: {…}}
ConsoleLogger.js?721f:97 [DEBUG] 58:59.20 AWSAppSyncRealTimeProvider - subscription message from AWS AppSync RealTime: {"id":"c0d7e29b-372a-49b1-84bb-ee4a82ae98c2","type":"error","payload":{"errors":[{"errorType":"UnauthorizedException","message":"Permission denied"}]}}
ConsoleLogger.js?721f:100 [DEBUG] 58:59.20 AWSAppSyncRealTimeProvider {id: "c0d7e29b-372a-49b1-84bb-ee4a82ae98c2", observer: SubscriptionObserver, query: "subscription operation {↵  onCreateMultipleChoiceA…  _version↵    _lastChangedAt↵    _deleted↵  }↵}↵", variables: {…}}
ConsoleLogger.js?721f:107 [WARN] 58:59.20 DataStore - subscriptionError Connection failed: {"errors":[{"errorType":"UnauthorizedException","message":"Permission denied"}]}

Startup looks like this:
[HMR] Waiting for update signal from WDS...
client-entry.js?d124:33 [Quasar] Running SPA.
ConsoleLogger.js?721f:107 [DEBUG] 58:56.946 AWSPinpointProvider - endpointId from cache (3) ["ca99f450-0eec-11eb-8989-4d8f94dec68d", "type", "string"]
ConsoleLogger.js?721f:107 [DEBUG] 58:56.949 AWSPinpointProvider - setting endpoint id from the cache ca99f450-0eec-11eb-8989-4d8f94dec68d
ConsoleLogger.js?721f:107 [DEBUG] 58:56.950 Hub - Dispatching to analytics with  {event: "pinpointProvider_configured", data: null}
ConsoleLogger.js?721f:107 [DEBUG] 58:56.950 AnalyticsClass - on hub capsule analytics {event: "pinpointProvider_configured", data: null}
ConsoleLogger.js?721f:107 [DEBUG] 58:56.950 AWSPinpointProvider - _public record {event: {…}, provider: undefined}
ConsoleLogger.js?721f:97 [DEBUG] 58:56.951 Credentials - getting credentials
ConsoleLogger.js?721f:97 [DEBUG] 58:56.951 Credentials - picking up credentials
ConsoleLogger.js?721f:97 [DEBUG] 58:56.951 Credentials - getting new cred promise
ConsoleLogger.js?721f:97 [DEBUG] 58:56.951 Credentials - checking if credentials exists and not expired
ConsoleLogger.js?721f:97 [DEBUG] 58:56.952 Credentials - need to get a new credential or refresh the existing one
ConsoleLogger.js?721f:97 [DEBUG] 58:56.952 AuthClass - Getting current user credentials
ConsoleLogger.js?721f:107 [DEBUG] 58:56.953 AWSPinpointProvider - _public record {event: {…}, provider: "AWSPinpoint"}
ConsoleLogger.js?721f:97 [DEBUG] 58:56.954 Credentials - getting credentials
ConsoleLogger.js?721f:97 [DEBUG] 58:56.954 Credentials - picking up credentials
ConsoleLogger.js?721f:97 [DEBUG] 58:56.954 Credentials - getting old cred promise
ConsoleLogger.js?721f:97 [WARN] 58:56.955 Hub - Cannot perform pattern matching without a message key
ConsoleLogger._log @ ConsoleLogger.js?721f:97
ConsoleLogger.warn @ ConsoleLogger.js?721f:150
HubClass._toListeners @ Hub.js?753e:167
HubClass.dispatch @ Hub.js?753e:109
dispatchAnalyticsEvent @ AWSPinpointProvider.js?9ab4:81
eval @ AWSPinpointProvider.js?9ab4:143
Promise.then (async)
AWSPinpointProvider.configure @ AWSPinpointProvider.js?9ab4:140
eval @ Analytics.js?dd23:119
AnalyticsClass.configure @ Analytics.js?dd23:113
eval @ Amplify.js?c5fb:83
AmplifyClass.configure @ Amplify.js?c5fb:82
eval @ amplify.js?dc26:16
./src/boot/amplify.js @ app.js:1241
__webpack_require__ @ app.js:854
fn @ app.js:151
eval @ client-entry.js?d124:1
./.quasar/client-entry.js @ app.js:1019
__webpack_require__ @ app.js:854
fn @ app.js:151
0 @ app.js:1611
__webpack_require__ @ app.js:854
checkDeferredModules @ app.js:46
webpackJsonpCallback @ app.js:33
(anonymous) @ vendor.js:1
ConsoleLogger.js?721f:97 [DEBUG] 58:56.955 AuthClass - Getting current session
ConsoleLogger.js?721f:107 [DEBUG] 58:56.958 AuthClass - Getting the session from this user: CognitoUser {username: "username", pool: CognitoUserPool, Session: null, client: Client, signInUserSession: CognitoUserSession, …}
ConsoleLogger.js?721f:107 [DEBUG] 58:56.958 AuthClass - Succeed to get the user session CognitoUserSession {idToken: CognitoIdToken, refreshToken: CognitoRefreshToken, accessToken: CognitoAccessToken, clockDrift: 0}
ConsoleLogger.js?721f:107 [DEBUG] 58:56.966 AuthClass - getting session success CognitoUserSession {idToken: CognitoIdToken, refreshToken: CognitoRefreshToken, accessToken: CognitoAccessToken, clockDrift: 0}
ConsoleLogger.js?721f:97 [DEBUG] 58:56.966 Credentials - set credentials from session
vue.runtime.esm.js?5593:8429 Download the Vue Devtools extension for a better development experience:
https://github.com/vuejs/vue-devtools
ConsoleLogger.js?721f:97 [DEBUG] 58:57.436 AuthClass - getting current authenticated user
ConsoleLogger.js?721f:97 [DEBUG] 58:57.438 AuthClass - cannot load federated user from auth storage
ConsoleLogger.js?721f:97 [DEBUG] 58:57.438 AuthClass - get current authenticated userpool user
ConsoleLogger.js?721f:97 [DEBUG] 58:57.439 AuthClass - getting current authenticated user
ConsoleLogger.js?721f:97 [DEBUG] 58:57.470 AuthClass - getting current authenticated user
ConsoleLogger.js?721f:97 [DEBUG] 58:57.484 AuthClass - cannot load federated user from auth storage
ConsoleLogger.js?721f:97 [DEBUG] 58:57.484 AuthClass - get current authenticated userpool user
ConsoleLogger.js?721f:97 [DEBUG] 58:57.485 AuthClass - cannot load federated user from auth storage
ConsoleLogger.js?721f:97 [DEBUG] 58:57.485 AuthClass - get current authenticated userpool user
ConsoleLogger.js?721f:107 [DEBUG] 58:57.490 AWSPinpointProvider - _public record {event: {…}, provider: undefined}
ConsoleLogger.js?721f:97 [DEBUG] 58:57.490 Credentials - getting credentials
ConsoleLogger.js?721f:97 [DEBUG] 58:57.490 Credentials - picking up credentials
ConsoleLogger.js?721f:97 [DEBUG] 58:57.490 Credentials - getting old cred promise
ConsoleLogger.js?721f:97 [DEBUG] 58:57.492 DataStore - Starting DataStore
ConsoleLogger.js?721f:97 [DEBUG] 58:57.497 DataStore - Starting Storage
ConsoleLogger.js?721f:107 [DEBUG] 58:57.812 Hub - Dispatching to datastore with  {event: "networkStatus", data: {…}}
ConsoleLogger.js?721f:107 [DEBUG] 58:57.813 Hub - Dispatching to datastore with  {event: "networkStatus", data: {…}}
ConsoleLogger.js?721f:107 [DEBUG] 58:57.813 Hub - Dispatching to datastore with  {event: "networkStatus", data: {…}}
ConsoleLogger.js?721f:97 [DEBUG] 58:57.814 AuthClass - getting current credentials
ConsoleLogger.js?721f:97 [DEBUG] 58:57.814 Credentials - getting credentials
ConsoleLogger.js?721f:97 [DEBUG] 58:57.815 Credentials - picking up credentials
ConsoleLogger.js?721f:97 [DEBUG] 58:57.815 Credentials - getting new cred promise
ConsoleLogger.js?721f:97 [DEBUG] 58:57.815 Credentials - checking if credentials exists and not expired
ConsoleLogger.js?721f:107 [DEBUG] 58:57.816 Credentials - are these credentials expired? {accessKeyId: "redacted", secretAccessKey: "redacted", sessionToken: "redacted", expiration: Thu Oct 15 2020 10:58:57 GMT-0400 (Eastern Daylight Time), identityId: "redacted", …}
ConsoleLogger.js?721f:97 [DEBUG] 58:57.816 Credentials - credentials not changed and not expired, directly return
ConsoleLogger.js?721f:97 [DEBUG] 58:57.819 AuthClass - Getting current session
ConsoleLogger.js?721f:107 [DEBUG] 58:57.825 DataStore - after createFromExisting - predicate undefined
ConsoleLogger.js?721f:107 [DEBUG] 58:57.825 DataStore - params ready {predicate: undefined, pagination: {…}, modelConstructor: ƒ}
ConsoleLogger.js?721f:107 [DEBUG] 58:57.825 DataStore - after createFromExisting - predicate Proxy {}
ConsoleLogger.js?721f:107 [DEBUG] 58:57.825 DataStore - params ready {predicate: {…}, pagination: {…}, modelConstructor: ƒ}
ConsoleLogger.js?721f:107 [DEBUG] 58:57.826 AuthClass - Getting the session from this user: CognitoUser {username: "username", pool: CognitoUserPool, Session: null, client: Client, signInUserSession: CognitoUserSession, …}
ConsoleLogger.js?721f:107 [DEBUG] 58:57.826 AuthClass - Succeed to get the user session CognitoUserSession {idToken: CognitoIdToken, refreshToken: CognitoRefreshToken, accessToken: CognitoAccessToken, clockDrift: 0}
ConsoleLogger.js?721f:97 [INFO] 58:57.826 Cache - Get item: key is federatedInfo with options undefined
ConsoleLogger.js?721f:107 [DEBUG] 58:57.830 PubSub - subscribe options {provider: Symbol(INTERNAL_AWS_APPSYNC_REALTIME_PUBSUB_PROVIDER), appSyncGraphqlEndpoint: "https://redacted.appsync-api.us-east-1.amazonaws.com/graphql", authenticationType: "AWS_IAM", apiKey: undefined, query: "subscription operation {↵  onCreateTrail {↵    id↵…  _version↵    _lastChangedAt↵    _deleted↵  }↵}↵", …}
ConsoleLogger.js?721f:97 [DEBUG] 58:57.831 Credentials - getting credentials
ConsoleLogger.js?721f:97 [DEBUG] 58:57.832 Credentials - picking up credentials
ConsoleLogger.js?721f:97 [DEBUG] 58:57.832 Credentials - getting new cred promise
ConsoleLogger.js?721f:97 [DEBUG] 58:57.832 Credentials - checking if credentials exists and not expired
ConsoleLogger.js?721f:107 [DEBUG] 58:57.833 Credentials - are these credentials expired? {accessKeyId: "redacted", secretAccessKey: "redacted", sessionToken: "redacted", expiration: Thu Oct 15 2020 10:58:57 GMT-0400 (Eastern Daylight Time), identityId: "redacted", …}
ConsoleLogger.js?721f:97 [DEBUG] 58:57.833 Credentials - credentials not changed and not expired, directly return
ConsoleLogger.js?721f:107 [DEBUG] 58:57.835 PubSub - subscribe options {provider: Symbol(INTERNAL_AWS_APPSYNC_REALTIME_PUBSUB_PROVIDER), appSyncGraphqlEndpoint: "https://gxgsvawtsraazp7cl4usjsrwg4.appsync-api.us-east-1.amazonaws.com/graphql", authenticationType: "AWS_IAM", apiKey: undefined, query: "subscription operation {↵  onUpdateTrail {↵    id↵…  _version↵    _lastChangedAt↵    _deleted↵  }↵}↵", …}
ConsoleLogger.js?721f:97 [DEBUG] 58:57.835 Credentials - getting credentials
ConsoleLogger.js?721f:97 [DEBUG] 58:57.836 Credentials - picking up credentials
ConsoleLogger.js?721f:97 [DEBUG] 58:57.836 Credentials - getting old cred promise

I'm at a loss - it was working, and then suddenly stopped.  Stashing changes didn't help, clearing browser history, logging out and back in... nothing helped. I'm  on versions:
"@aws-amplify/datastore": "^2.5.2",
"@aws-amplify/ui-vue": "^0.2.21",
"aws-amplify": "^3.3.2",
"aws-amplify-vue": "^2.1.2",
and cli version 4.24.3.

@kurtroberts I tried to check the authorization on the AppSync Console, and if I am in the group "Everyone" I am able to run operations on AppSync. If I am in the IAM role the same thing is allowed. Sounds like this could potentially be an issue in the DataStore library on how it's signing the requests over to AppSync. Transferring this issue to the JS library for better visibility.


Use Array.sort in hoist-jest

Summary
When hoist-jest encounters a file with a large enough number of statements to sort, it can error with Maximum call stack size exceeded
Test plan
Use existing hoist-jest tests + tested change against our project.
Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information
Closes: #3476

Going to wait for initial CI run, and then I'll push the lint fix.

Ubuntu tests pass, so I amended the commit and pushed with the lint fix + a commit message that passes local checks

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

3 of 3 (100.0%)  changed or added relevant lines in 1 file are covered.
1 unchanged line in 1 file lost coverage.
Overall coverage decreased (-0.1%) to 94.792%

Files with Coverage Reduction
New Missed Lines
%

src/transformers/hoist-jest.ts
1
95.5%

Totals

Change from base Build<PHONE_NUMBER>:
-0.1%

Covered Lines:
1120

Relevant Lines:
1147

💛  - Coveralls

Yup all tests passed. Latest push's workflow run just needs an approval, and then it's all set.

@ahnpnl I can confirm that this solves the same problem on v27.1.4. Would it be possible to get a new version of v27 released with this? Or can the latest v28 of ts-jest work with v27 jest and related tools?
This is a huge problem for me. We have 60 projects with unit tests and this infinite recursion happens randomly on all of those projects when we try to do a test run.

I will push 27.1.5 which contains this

Thank you very much!!!

@gregveres done, 27.1.5 was out now

thank you. I have updated and it is running now. So far, no more infinite recursion.


Error in analyseWGCNA()---color

Hi
When I run pywgcna.analyseWGCNA(), I got this error:
-> 4439     colors = mcolors.to_rgba_array(c)
ValueError: 'c' argument must be a color, a sequence of colors, or a sequence of numbers, not array(['darkviolet', 'darkviolet', 'darkvio
However, the file of sample info and color setting was same with the files in Quick start.
How can I solve this problem?
Thank you so much!

Hi,
please make sure you have the latest version and if you still got that error would you mind sharing with me your picke file and the script you used?

Hi,
please make sure you have the latest version and if you still got that error would you mind sharing with me your picke file and the script you used?

Hi
I have installed pYWGCNA1.2.3. Previous error have solved.
The data link mentioned in https://github.com/mortazavilab/PyWGCNA/issues/39#issuecomment-1546492332
Thank you so much

Hi,
For pywgcna.analyseWGCNA(), you need to add your data trait and colormap like the tutorials.
I don't have your data trait and the script you used. would you mind giving me some insight of those things?
Thanks

Hi， thanks for response
the trait data was arranged like tutorials. a dataframe like this:
sample_id	group
oocyte1	oocyte
oocyte2	oocyte
oocyte3	oocyte
pronuclear1	pronuclear
pronuclear2	pronuclear
pronuclear3	pronuclear
zygote1	zygote
zygote2	zygote
2_cell1	2_cell
2_cell2	2_cell
2_cell3	2_cell
4_cell1	4_cell
4_cell2	4_cell
4_cell3	4_cell
4_cell4	4_cell
8_cell1	8_cell
8_cell2	8_cell
8_cell3	8_cell
8_cell4	8_cell
8_cell5	8_cell
8_cell6	8_cell
8_cell7	8_cell
8_cell8	8_cell
8_cell9	8_cell
8_cell10	8_cell
8_cell11	8_cell
morula1	morula
morula2	morula
morula3	morula
The color set was copy from  the tutorials.
test.setMetadataColor('stage', ['oocyte': 'darkviolet',
                                'pronuclear': 'deeppink',
                                'zygote': 'thistle',
                                '2cell': 'plum',
                               '4cell': 'violet',
                                '8cell': 'purple',
                                'morula':'red'])

Thank you

Again, I was able to run PyWGNA without any problem!
I attached my script below.
Please read the tutorials more carefully :)
i.e. your color map should be a dictionary, not a list. Or the name of the color map should match to the one the column names but in your case, your column name is group but you specify stage in the setMetadataColor() function.
`
import PyWGCNA
import pandas as pd
tpm = pd.read_csv('GSE44183_human_expression_mat.txt', sep='\t', index_col=0).T
test = PyWGCNA.WGCNA(name='test',
species='mus musculus',
geneExp=tpm,
outputPath='',
save=True)
test.preprocess()
test.findModules()
sampleInfo = test.datExpr.obs.copy(deep=True)
sampleInfo['group'] = sampleInfo.index.tolist()
sampleInfo.group[sampleInfo.group.str.contains('oocyte')] = 'oocyte'
sampleInfo.group[sampleInfo.group.str.contains('pronuclear')] = 'pronuclear'
sampleInfo.group[sampleInfo.group.str.contains('zygote')] = 'zygote'
sampleInfo.group[sampleInfo.group.str.contains('2 cell')] = '2 cell'
sampleInfo.group[sampleInfo.group.str.contains('4 cell')] = '4 cell'
sampleInfo.group[sampleInfo.group.str.contains('8 cell')] = '8 cell'
sampleInfo.group[sampleInfo.group.str.contains('morula')] = 'morula'
test.updateSampleInfo(sampleInfo=sampleInfo)
test.setMetadataColor('group', {'oocyte': 'darkviolet',
'pronuclear': 'deeppink',
'zygote': 'thistle',
'2 cell': 'plum',
'4 cell': 'violet',
'8 cell': 'purple',
'morula':'red'})
test.analyseWGCNA()
`


fix: on first run of gnome-shell its not centered

I find out that it wasn't centering the text (#46) when I started the gnome shell for the first time, just when the shell was restarted.
The reason for that was: I was applying the style to sA.dateMenu.actor but I should have applied it on its children instead.
Sorry about that, sending the fix.
Thanks

Thanks!


New samples from kotlin-by-example

New samples in a repository https://github.com/Kotlin/kotlin-by-example
Commit: https://github.com/Kotlin/kotlin-by-example/commit/22f99626d11779473a6482793860b885cac7f418
Files:
examples/01_introduction/02_Functions.md

New samples in a repository https://github.com/JetBrains/kotlin-web-site
Commit: https://github.com/JetBrains/kotlin-web-site/commit/9bab1bdafaca07c5c6bdfc43a2cdc51ec8352c14
Files:
docs/topics/whatsnew18.md


Unable to focus elements when multiple FocusScope used

🐛 Bug Report
When we use FocusScope more than one time with contain={true}. We are unable to focus on elements inside the rest of the FocusScope.  This was working fine in the earlier version<EMAIL_ADDRESS>🤔 Expected Behavior
Should be able to focus/click elements.
😯 Current Behavior
<EMAIL_ADDRESS>Unable to focus inside FocusScope when used multiple times.
💁 Possible Solution
🔦 Context
We are using multiple modal components. All the modal contents are wrapped with FocusScope with contain={true}. Focus is contained in the first modal and is unable to focus on the rest of the modal contents.
💻 Code Sample
CodeSandbox Link https://codesandbox.io/s/silly-snyder-kj8tu3
🌍 Your Environment

Software
Version(s)

Browser
Chrome

Operating System
MacOS 12.2.1

@react-aria/focus
3.6.1

🧢 Your Company/Team
React Native Aria

Hey, thanks for the issue. This is working as intended, you can't have two sibling scopes that both contain, each one will try to make sure focus is within itself and that the focus never leaves.
Can you explain a bit more about your use case?
I think what you're trying to implement, and I could be wrong, is a roving tabIndex, essentially like a RadioGroup. In that case, you should stop using contains and follow along with an implementation I did for a AxeCon talk this year where I implemented a RadioGroup's roving tabIndex https://www.youtube.com/watch?v=HpSYnoPh6aE&t=589s

Thanks, @snowystinger.
We're trying to open a modal from another modal.
Both the modals are wrapped in FocusModal with contain={visible}.
When both the modals are visible, we have two modals with contain={true}.
We need to set contain={false} manually when a new modal pops up. Thanks for your help, we'll do it by wrapping all the modals in a Provider and keeping track of the current active modal.

I see. Some extra information then, we only allow one modal to be visible at a time. If a new one opens, the previous one closes. It offers a bit nicer UX as well, you don't have to back track through numerous modals to get back to the page.
That said, our FocusScope should be able to handle this. You can move from a containing focus scope parent down into a nested contain focus scope, however, you cannot move up from a child to a parent.
The codesandbox you shared isn't quite a representation of the issue I don't think?
Something more like this https://codesandbox.io/s/reverent-colden-6u7hve?file=/src/App.js it's a partial example, I'd expect an underlay to prevent mouse users from interacting with the buttons in the first scope. But you can see if you tab to "1 One", press space, then tab twice more, you'll move from the first scope to the second scope, and then via keyboard you cannot leave the second scope. Again, you'd need something to move focus to the second scope, maybe autofocus or something and you'd need to prevent mouse interactions with the first scope, but it shows that our FocusScopes can handle this flow.

Thanks for the example @snowystinger . I've made a few changes to your example and introduced a third scope. Can you please tell me how can I focus on the third scope?

The third dialog you have isn't part of the second dialog, it's incidental that it opened it. The second dialog should close when it opens the third. Keyboard navigation works again here https://codesandbox.io/s/peaceful-montalcini-5pk6wz

Okay, got it. Thanks for your help.


Fix GpuTimeAdd handling both input expressions being GpuScalar [databricks]

fixes https://github.com/NVIDIA/spark-rapids/issues/8293
GpuTimeAdd was failing with:
 Caused by: java.lang.UnsupportedOperationException: GpuTimeAdd takes column and interval as an argument only, the types passed are, left: class
 com.nvidia.spark.rapids.GpuScalar right: class com.nvidia.spark.rapids.GpuScalar

GpuTimeAdd currently doesn't handle both input expressions being GpuScalar.  This can happen when a subquery is input to the filter. The issue has more details.  I validated test fails without this fix and passes with it.
integration test created and also verified this fixed the customer query that ran into the issue.

build


Potential fix for bug #1975

The change was made to the function that is executed when entering the world editor. The boolean variable for first person shooter was set to true, since the camera always defaults to first person on entering the world editor. On setting this boolean variable to be true, the correct camera setting will always be displayed on entering the world editor. This does not affect other camera labels.

Looks good.


Update Readme.md

Add new Repo

Is this just spam? I am going to close this PR because it looks likes spam, if it is not, you are welcome to reopen and tell me.


When virtual keyboard pop up, input box near the screen bottom doesn't automatically scroll up

[x] I have read the Getting Started section
[x] I have already searched for the same problem

Environment

Technology
Version

Flutter version
3.19.6

Plugin version
6.0.0

Android version
14

iOS version

macOS version

Xcode version

Google Chrome version

Device information:
Description
When there is a input box near the bottom of the screen and we need to input something using the virtual keyboard, when the keyboard is shown,  sometimes this input box is hidden by the keyboard, I need the input box automatically scroll up everytime.
Expected behavior:
I need the web page automatically scroll up and make the input box visible to the user automatically as the behavior when we use chrome.

Current behavior:
the input box is not visible most of the time(actually sometimes it works but not always), I need to scroll the web page manually to show the input box.
Steps to reproduce

Run the flutter_inappwebview_example app,
visit this url: https://www.google.com/advanced_search
scroll down and let the site or domain input box near the screen bottom.
click on the site or domain input box, virtual keyboard show up.
site or domain input box is not visible most of the time(actually sometimes it works but not always), I need to scroll the web page manually to show the input box.

Images
Stacktrace/Logcat

Same thing here ! Does anyone have a workaround ?

I encounter this issue in the Android Platform. iOS works correctly.
This issue will occur if the input field position is located at the 1/2 top of the keyboard.
If the input field position is located at the 1/2 bottom of the keyboard, adjustResize and Autofocus work smoothly.
I am looking for a workaround solution.

Related to #1887 #1834

We are facing a similar issue with a text input field located near the bottom of a webpage. When using InAppWebView, the text input is not visible when the keyboard appears. However, in Chrome, the bottom text area is automatically pushed above the keyboard.
Does anyone have a workaround for this issue?


Add KCC support

Add KCC(KuCoin Community Chain) support
TokenName: KuCoin Token
ChainName: KCC
Symbol: KCS
Documentation: https://docs.kcc.io/
Reason: KCC is a high-performance and decentralized public chain built by KCS’ and KuCoin’s fan communities.
Developed based on go-there with the purpose of providing community users with a higher-speed, convenient and low-cost blockchain user experience.
Fully compatible with Ethereum and ERC-20 smart contracts, extremely low costs in migration.

thanks for reaching out, we will consider add it later, closing for now

Thanks, 非常感谢。


Add option to clear individual error on text changed

I'm using ValidationStyle.UNDERLABEL as my validation style.
Now as far as I could explore , I could find a method to clear error from all the form fields:
mAwesomeValidation.clear();
However, I am not able to remove error from a single EditText. My requirement is, when a user starts typing in an EditText field, it should remove the under label error. I've tried using setError(null) on the EditText but it isn't working. Is there any way to do this?

Hi @Pinaki93, thanks for the feedback.
I understand what you mentioned above, but unfortunately it's not supported so far.  It's about UX, different people might have different opinion.  I think it's OK that I've chosen clear all as default instead of clear individual.  But it's my fault if I don't provide clear individual as an option.  Sorry for that.  I'll put this to my TODO list.
I would like to rephrase the title from "Remove validation error" to "Add option to clear individual error on text changed".  Then for the mAwesomeValidation instance, you can set the option as enabled, so that error removal code will be added to addTextChangedListener for each individual input field.
Thanks again.

This feature has been added to TODO list.

Have managed to do a quick workaround by clearing and validating the EditText on focus change.
`@OnFocusChange(R.id.text_business_name)
public void changeBusinessNameFocus()
{
revalidate();
}
@OnFocusChange(R.id.text_address)
public void changeAddressFocus()
{
    revalidate();
}

public void revalidate()
{
    awesomeValidation.clear();
    awesomeValidation.validate();
}`


Alignment and style Team Members page

On "Invite a team member" page, after inviting a team member, it should redirect to the team members index page, not the root.
On "Invite a team member" page, remove "Users can invite members of their team or organisation to use this service."
On "Team members" page, show team member names in the table. See notify: https://www.notifications.service.gov.uk/services/d1844f74-3895-4a8b-8f75-3eb929763d16/users
On "Team Members" page, right align the "add a team member" button
On "Team Members" page, the "resend invite" link should not be a primary green button, it should be a secondary blue/grey button or just a link.

BEFORE:

AFTER:

Lookin' good! I'll give it the thumbs up once the merge has been sorted out.


Import failing when torch.distributed is not available

💡 Your Question
``Hi,
I am trying to use yolo-nas on a jetson xavier and need super-gradients to do this. Unfortunately the Jetson Torch Wheels (that are needed for cuda support) are built without USE_DISTRIBUTED so torch.distributed.is_available() returns false.
When running
import super_gradients

I get the Error: ImportError: cannot import name 'get_rank' from 'torch.distributed'
Just to double check, to use super_gradients AND have Cuda support available I need to build pytorch from source as torch.distributed is a mandatory requirement for super-gradients?
Versions
PyTorch version: 1.13.0a0+936e9305.nv22.11
Is debug build: False
CUDA used to build PyTorch: 11.4
ROCM used to build PyTorch: N/A
OS: Ubuntu 20.04.6 LTS (aarch64)
GCC version: (Ubuntu 9.4.0-1ubuntu1~20.04.2) 9.4.0
Clang version: Could not collect
CMake version: version 3.28.3
Libc version: glibc-2.31
Python version: 3.8.10 (default, Nov 22 2023, 10:22:35)  [GCC 9.4.0] (64-bit runtime)
Python platform: Linux-5.10.104-tegra-aarch64-with-glibc2.29
Is CUDA available: True
CUDA runtime version: 11.4.315
CUDA_MODULE_LOADING set to:
GPU models and configuration: Could not collect
Nvidia driver version: Could not collect
cuDNN version: Probably one of the following:
/usr/lib/aarch64-linux-gnu/libcudnn.so.8.6.0
/usr/lib/aarch64-linux-gnu/libcudnn_adv_infer.so.8.6.0
/usr/lib/aarch64-linux-gnu/libcudnn_adv_train.so.8.6.0
/usr/lib/aarch64-linux-gnu/libcudnn_cnn_infer.so.8.6.0
/usr/lib/aarch64-linux-gnu/libcudnn_cnn_train.so.8.6.0
/usr/lib/aarch64-linux-gnu/libcudnn_ops_infer.so.8.6.0
/usr/lib/aarch64-linux-gnu/libcudnn_ops_train.so.8.6.0
HIP runtime version: N/A
MIOpen runtime version: N/A
Is XNNPACK available: False
CPU:
Architecture:                    aarch64
CPU op-mode(s):                  32-bit, 64-bit
Byte Order:                      Little Endian
CPU(s):                          6
On-line CPU(s) list:             0-5
Thread(s) per core:              1
Core(s) per socket:              2
Socket(s):                       3
Vendor ID:                       Nvidia
Model:                           0
Model name:                      ARMv8 Processor rev 0 (v8l)
Stepping:                        0x0
CPU max MHz:                     1907,2000
CPU min MHz:                     115,2000
BogoMIPS:                        62.50
L1d cache:                       384 KiB
L1i cache:                       768 KiB
L2 cache:                        6 MiB
L3 cache:                        4 MiB
Vulnerability Itlb multihit:     Not affected
Vulnerability L1tf:              Not affected
Vulnerability Mds:               Not affected
Vulnerability Meltdown:          Not affected
Vulnerability Spec store bypass: Not affected
Vulnerability Spectre v1:        Mitigation; __user pointer sanitization
Vulnerability Spectre v2:        Mitigation; Branch predictor hardening
Vulnerability Srbds:             Not affected
Vulnerability Tsx async abort:   Not affected
Flags:                           fp asimd evtstrm aes pmull sha1 sha2 crc32 atomics fphp asimdhp cpuid asimdrdm dcpop
Versions of relevant libraries:
[pip3] numpy==1.23.0
[pip3] onnx==1.15.0
[pip3] onnx-graphsurgeon==0.3.12
[pip3] onnx-simplifier==0.3.5
[pip3] onnxoptimizer==0.3.13
[pip3] onnxruntime==1.15.0
[pip3] onnxsim==0.4.36
[pip3] torch==1.13.0a0+936e9305.nv22.11
[pip3] torch2trt==0.4.0
[pip3] torchmetrics==0.8.0
[pip3] torchvision==0.13.0
[conda] Could not collect

Thank you, we are planning on using tensorrt later on but currently it is easier to evaluate different models just using the "basic" variant. Problem with the conversion is that we would also need to import super-gradients for doing the conversion but I guess we can do this on a machine with a proper nvidia gpu running normal ubuntu or windows

Just to have some more information on this:
https://forums.developer.nvidia.com/t/torch-distributed-is-not-available-on-jetson-pytorch/256254
As said there a workaround would be the older pytorch version or building pytorch from source:
https://forums.developer.nvidia.com/t/pytorch-for-jetson/72048
My guess would be that closed issue #1538 was having the same problem as there is also a nvidia torch version used there indicated by nv23.2


Video stops playing / timed out

Can't seem to play a full video, playback stops after 2 min or so.
State keeps saying that it's still playing.
Whats the best way to debug this?
Looks like the apple tv 4 stops playing without giving notice to airplay client. (socket closes/closed?)

Issue seems fixed by polling serverInfo.


Adding a log wrapper to the list IGNORED_PACKAGE_PREFIXES

I want to add our wrapper around the datadog class,
In the current implementation (logcat), we see our wrapper in the source file / line ...
There is a mechanism to ignore it, but it is currently hardcoded as:
// internal for testing
internal val IGNORED_PACKAGE_PREFIXES = arrayOf(
"com.datadog.android.timber",
"timber.log"
)
It would be nice to have a way to add a new package.

Hi @viewers , I transfered this issue as I think you meant this for the dd-sdk-android repository and not dd-trace-java.
This would be a feature request to make this internal list customizable, which is not something that would be high in our roadmap right now, but feel free to submit a PR to allow a custom ignoredPackagePrefixes to be added in the LogcatLogHandler class.


gain value in decimal format

openwebrx passes gain in decimal format and hpsdrconnector does not accept that
owrx.source - INFO - Started sdr source: hpsdrconnector --samplerate 96000 --gain 30.0 --radio <IP_ADDRESS> --frequency 28074000 -p 44551 -c 56021
invalid value "30.0" for flag -gain: parse error

See: https://github.com/jketterl/openwebrx/issues/256

As the issue that @jketterl linked to shows, this has been fixed in the OpenWebRX develop branch (see https://github.com/jketterl/openwebrx/pull/235 for more details). Until there's an official release, you will have to build OpenWebRX from source or use one of the experimental builds.


upgrade npm packages because of lodash vulnerability

see https://npmjs.com/advisories/782
After integration of  minimed-connect-to-nightscout into Nightscout. I get the following npm security warning:
$ npm audit
                       === npm audit security report ===
# Run  npm update lodash --depth 2  to resolve 1 vulnerability
  Moderate        Prototype Pollution
  Package         lodash
  Dependency of   minimed-connect-to-nightscout
  Path            minimed-connect-to-nightscout > lodash
  More info       https://npmjs.com/advisories/782

Since Nightscout 0.11 the Nightscout release policy is not to release versions with known security issues.
As I'm not a minimed-connect-to-nightscout user, I can't test this. I'm just providing the PR for the community sake.
@mddub Can you please review, test and merge this PR and release a new version.

Note that this PR also does a major update of the mocha package.
I only tested that this PR still passes all its tests, but didn't do any code changes for mocha.

lgtm if tests pass.

Just updated to v1.2.2 in 83f8d46 and published to npm (I made a mistake in publishing v1.2.1, so skip that one).


Tomquirk/fix lock

What does this PR do and why?

update lock file
add lockfile check to ci

cc @jmilldotdev , gonna merge to fix build


Document the Amazon architecture

Could be on Miro via some diagram.

I have something like this:

this looks awefully crowded but certainly has some charm to it. Maybe this chart and some descriptions.

Yeah, I think that's what I am going with. This plus a small description of the resource we have on aws I hope will be enough.
I can also comment on how I made this graph because that would be also nice.


⚠ Bofrost.es has degraded performance

In 0dc26a8, Bofrost.es (https://www.bofrost.es) experienced degraded performance:

HTTP code: 200
Response time: 1474 ms

Resolved: Bofrost.es performance has improved in 84cc1a6 after 9 minutes.


Revert "feat: add vsock support to cyclone-server"

Reverts systeminit/si#2956
Will re-introduce these changes when we merge the firecracker support for real.

bors merge


Support building swift/AST with MSVC on Windows

Relies on apple/swift-llvm#33 but can be merged before

I've rebased and addressed your comments about the alignment issues

I've made a connect bug for the numTrailingObjects problem: https://connect.microsoft.com/VisualStudio/feedback/details/3116517
If anyone's curious, they can try coming up with a better workaround by compiling MSVC code online here: http://rextester.com/XIJ43194

@slavapestov PTAL. I think the only thing holding back this one getting merged is the gross hack for https://connect.microsoft.com/VisualStudio/feedback/details/3116517. I'd like to figure out a work around that doesn't make us diverge from upstream LLVM.
If anyone has some spare time, check out a simple reproduction here: http://rextester.com/XIJ43194. This one also lets you compile C++ online if you don't have a Windows PC

@swift-ci Please smoke test


WIP: Combined call and composition checks

Refactor based on the idea in #246

[x] Convert all checks into combined "IntoFnCheck"s
[x] Introduce module-level IntoFnCheck declarations for each fn
[ ] Introduce intoFnCheckFlatFromList : List IntoFnCheck -> IntoFnCheck
[ ] Go through each "use together / in combination with ..." and convert to a IntoFnCheck

Can only be merged after #278. If rebasing means I'll have to reopen a new PR, so be it. This PR is mostly to track progress for me but more transparently.

If rebasing means I'll have to reopen a new PR, so be it. This PR is mostly to track progress for me but more transparently.

You're good to go :+1: :wink:
And I'm fine with you making multiple branches/PRs at the same time, even if they were to conflict (we can always solve them, no worries).

This should be it.
Comment if you notice more checks where would could combine composition+call or if some edge case should be tested.


fix: include public_key in OutputProof

This PR:

Adds public_key field to OutputProof
adds a (non-public) RevealedOutputCommitment struct, also with a public_key field.
ensures that output public_keys are signed, by virtue of being in OutputProofs, which is included in message-to-be-signed.

Regarding (2).   Another approach would be to add public_key field to RevealedCommitment directly.  I believe that would be workable.  It is Output and TrueInput that generate (random) RevealedCommitment, and they both have a public_key present. Note that this would change the public API (maybe for the better?) whereas the present approach does not.  I'm happy to do it either way....  @davidrusu what do you think?

adds a (non-public) RevealedOutputCommitment struct, also with a public_key field.

This is done to keep the connection between the RevealedCommitment and the OutputProof?
We have this mapping already in place by virtue of the the RevealedCommitment being unique for each Output.
We could add a RingCtTransaction::output_by_commitment(commitment: G1Affine) -> Option<OutputProof> method which would allow you to find the output that has the given commitment, then you can take the public key from that output to find the owner.
i.e. something like:
let (tx, revealed_commitments) = RingCtMatrial.sign(..);

let output = tx.output_by_commitment(revealed_commitments[0].commit(..)).unwrap();

println!("Owner for commitment {:?} is {:?}", revealed_commitments[0], output.public_key());

This is done to keep the connection between the RevealedCommitment and the OutputProof?

It is done as a temporary storage for the public_key on its journey from Output to OutputProof within RingCtMaterial::sign() through intermediate RevealedCommitment step.   See impl of ::sign and its sub-functions.  A tuple could have been used instead to group them together, but this seemed a bit cleaner.

RingCtTransaction::output_by_commitment(commitment: G1Affine) -> Option

It may be a useful thing in its own right, but I do not (yet?) see that this helps with the above.

I am presently seeing a need to map from OutputProof back to a RevealedCommitment.
This is when client is building a Dbc.  The client needs to somehow obtain the "secrets" (amount, blinding) and transfer them to the recipient.  For now, I am thinking to encrypt them in the DbcContent (as before).
So the builder code is iterating over the RingCtTransaction::outputs, which are OutputProof.  It is now able to obtain the public_keys, but not the secrets, for each OutputProof.   Even if the client saved the original Outputs, it doesn't know how to match them with the OutputProof, and also the blinding_factor was randomly created along the way.
Hopefully I am explaining clearly enough...


remove aeraki configmap in namepace if we uninstall aeraki

What this PR does / Why we need it:

Pre-Submission Checklist:

[ ] Did you explain what problem does this PR solve? Or what new features have been added?
[ ] Have you added related test cases?
[ ] Have you modified the related document?
[ ] Is this PR backward compatible?

LGTM. Thanks for the cleaning up.


20154 Invalid Token claims set Twillio Video

SIP/2.0 403 Forbidden
Call-ID: Gw0M0cxXF2tIQs3yMYWi2g..
CSeq: 1 INVITE
Server: Twilio
X-Twilio-Error: 20154 Invalid Token claims set
X-Twilio-LegInfo: external
X-Twilio-TlsVerify: true
is that server problem or in iOS problem ??
What is solution ?

@mrchauhan2802,
Without seeing your token, my assumption is that there is something not being set properly when you are generating the token on your server.
If you wouldn't mind, send an email to<EMAIL_ADDRESS>reference this GitHub issue and include a generated token and I will take a look. Also post a comment here when you send the email and I will check in the support system for the issue.
Thanks!
Ryan

Yes issue solved

Awesome. Let us know if you run into anything else.

@paynerc  @mrchauhan2802 Can u share the details how do u solve the issue?


Sahar

👷 Deploy Preview for crpp-ai-oncology processing.

Name
Link

🔨 Latest commit
68b646ef9eb974d8f93f8430bf2d09cfe51dc547

🔍 Latest deploy log
https://app.netlify.com/sites/crpp-ai-oncology/deploys/647ad396010d510008a372c4


Add support for omitempty field tag to exclude empty values from queries and headers

Adds support for an omitempty tag.
Main use case is for query parameters where we may not want have empty keys
i.e. /pets?name_pointer=
By adding omitempty to the tag then this the key will not appear in the query string
i.e.
	type SearchQuery struct {
		NamePointer *string `in:"query=name_pointer,omitempty"`
	}

This will create /pets
This has been added to the formencoder so that it will also remove empty headers.
I have picked omitempty as I feel this will feel most natural for engineers as they are likely already used to this syntax with JSON.

Build is failing due to rate limiting in CodeCov - will try a rebuild later.


[AIRFLOW-1166] Speed up _change_state_for_tis_without_dagrun

Dear Airflow maintainers,
Please accept this PR. I understand that it will not be reviewed until I have checked off all the steps below!
JIRA

[x] My PR addresses the following Airflow JIRA issues and references them in the PR title. For example, "[AIRFLOW-XXX] My Airflow PR"

https://issues.apache.org/jira/browse/AIRFLOW-1166

Description

[X] Here are some details about my PR, including screenshots of any UI changes:

_change_state_for_tis_without_dagrun was locking a significant
amount of tasks uncessarily. This could end up in a deadlock
in the database due to the time the lock stood.
Tests

[X] My PR adds the following unit tests OR does not need testing for this extremely good reason:

Unit tests added.
Commits

[x] My commits all reference JIRA issues in their subject lines, and I have squashed multiple commits if they address the same issue. In addition, my commits follow the guidelines from "How to write a good git commit message":

Subject is separated from body by a blank line
Subject is limited to 50 characters
Subject does not end with a period
Subject uses the imperative mood ("add", not "adding")
Body wraps at 72 characters
Body explains "what" and "why", not "how"

@aoen @saguziel

@aoen @artwr @saguziel I'm pretty sure you guys must see this issue, except when the previous code is not in your fork yet.
errors on travis are unrelated.

Codecov Report

Merging #2267 into master will increase coverage by 0.03%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master    #2267      +/-   ##
==========================================
+ Coverage   69.51%   69.55%   +0.03%
==========================================
  Files         144      144
  Lines       11042    11040       -2
==========================================
+ Hits         7676     7679       +3
+ Misses       3366     3361       -5

Impacted Files
Coverage Δ

airflow/jobs.py
75.15% <100%> (+0.55%)
:arrow_up:

airflow/models.py
87.08% <0%> (-0.05%)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update df9a10b...462ca73. Read the comment docs.

@saguziel @aoen please review. I would really like to get it in 1.8.2 and besides I'm pretty sure you will (eventually) see this issue.

LGTM


./run.sh: 17: ./run.sh: gawk: not found

help when I try to run ra1nstorm.run I get this back "./run.sh: 17: ./run.sh: gawk: not found
"

I get the same problem. I never found a fix, but after trying again several days later, I can't even boot into Xubuntu anymore. It brought me straight to a terminal saying that it couldn't boot properly. Naturally, I assumed that the OS had gone corrupt after using it just one time so I attempted to reinstall Xubuntu using ra1nstorm. I did this around 10-12 different times.
Outcome 1: Boots into the installation, then tells me that its missing the EFI System Partition needed to complete the setup and to continue setting up at my own risk. I attempted to just continue setting up and obviously it failed, it wouldn't boot properly.
So now I need to find out how to create an EFI System Partition for Xubuntu?

Try:
sudo apt-get update -y
sudo apt-get install -y gawk


$watch breaking change from 1.2 to 1.3

I have recently migrated our code base from 1.2 to 1.3.16.
We have noticed the following change in behaviour.
We have a directive that is responsible for detecting and reacting to a change in the height of our application's root dom element.
Our strategy involved the following function
function watchElementHeightChange() {
                scope.$watch
                    (
                        function() { return element.height(); },
                        function (newValue, oldValue) {
                            if (newValue !== oldValue) {
                                requestResize("height Change");
                            }
                        }
                    );
            }

This has worked robustly within our Angular 1.2 codebase, when a digest occurred the value returned by our watchExpression's function   element.height() was the new height of our element.
Moving to 1.3, this was no longer true, the value returned by the watchExpression function element.height() was the height of the element before the digest occurred. Also at no time during the digest's multiple invocations of the watchExpression did that value change.
I have not seen any mention of this change in behaviour mentioned in the migration document (https://docs.angularjs.org/guide/migration).
Nor have I seen any internet chatter either apart from this question on SO (http://stackoverflow.com/questions/27810450/angularjs-getting-stale-results-for-element-dimensions-in-a-directive-1-2-vs-1?rq=1)
As a workaround we have adopted the following :
function watchElementHeightChange() {
                scope.$watch
                    (
                        function() {
                            setTimeout(function () {
                                newHeight = element.height();
                                if (oldHeight !== newHeight) {
                                    oldHeight = newHeight;
                                    requestResize("height change");
                                }
                            },100);
                        }
                    );
            }

The use of setTimeout to avoid raising more digest cycles.
I would appreciate, if someone could either confirm what I have written or explain where I have errored.
Regards
Aidan

It is not considered a good practice to access DOM properties (especially if that results in layout thrashing).

You can use $timeout and still avoid invoking a digest (by using $timeout's third argument).

It is really hard to tell what the problem might be without a live reproduction.

If I had to guess, I would say that the change in height is a result of class manipulation, which happens (either explicitly or implicitly) using Angular's $animate (either the built-in or ngAnimate's one).

I do not consider this comment appropriate to the question asked, see(4) below. This is a directive not a controller, so accessing/monitoring dom elements should be acceptable. No one mentioned layout thrashing, and layout thrashing (if I guess correctly what that means) is not occurring.
Thanks, had not spotted that, this will allow me to remove Jasmine's Clock dependency from our test suite.
If on rereading this comment, a sample is still required, I will provide one.
This suggests that you misread the post. The change in height is expected and is not in question. In 1.2 the new height is provided as the new value in the $watch, in 1.3 the old, original height is provided as the new value.

I just realized that I omitted a very crucial part from my previous comment. What I meant to say is that "it is not considered a good practice to access DOM properties (especially if that results in layout thrashing) in a watch function". (I fixed the original comment to avoid future confusion.)

In case it is not obvious, a watch function can be triggered multiple times during a digest (at least 2), so accessing the DOM (which is known to be slow) inside a watch function is not recommened. (Performance is not the only reason, but it's a major one).
Additionally, using jQuery's height, which uses getBoundingClientRect() under the hood, will cause a forced synchronous layout (aka layout thrashing) each time, which is a really bad practice perfomance-wise.
(Layout thrashing cheatsheet - thx @ThomasBurleson for sharing :wink:)
--
3. As already mentioned, it is really hard to tell what the problem might be without a live reproduction (and the comment didn't actually provide any more info regarding the problem).
--
4. Sorry, I did not misread the post. What I said in (4) is actually what I believe is going on, but it's really impossible to be sure without more info (see (3) :smiley:).
In fact, I believe (but again I can only guess here) that this is a duplicate of #10522. Take a look at https://github.com/angular/angular.js/issues/10522#issuecomment-67627356 for a more detailed explanation of what I meant in (4).

The clarifications and url links you provided show that you had not misread the question and they have allowed me to understand the points that you were making.

I am aware of $watch being triggered multiple times during a digest, I did not see the correct height value in any of the calls made in a given digest. I was not aware of the underlying cost of JQuery's height function, I will read the link provided and look for an alternative method for getting the current height.
The digest is caused by a binding change, e.g. a given select control has values that when selected cause some visible controls to be hidden while making some hidden controls visible, or by a check box being ticked/unticked, again some additional controls being made visible on selection and invisible on deselection using ng-show/ng-hide. It would help the poster, if, when more information is required, some indication of what kind of information is needed, some direct questions would help.
#10522 looks to be the same issue, I believe the change in behaviour I am seeing is due to deferring class changes to postDigest, since the hiding / showing of components is via ng-show which translates to the class ".ng-hide".

Any advice on a strategy for detecting height change within an Angular applications that avoids $watch would be appreciated.
The requirement to be able to react to a change in the DOM height stems from having to support running the application within 3rd party integrator's embedded IE components, some are locked down in various ways, one of which is the prevention of client side code executing window resizing, so there is a need to detect height changes passing them to the appropriate external handler.

I will read the link provided and look for an alternative method for getting the current height

I don't really think there is a "cheap" way to actually get the height, but note that in most cases this is not necessary (as you can watch for stuff that triggered the change in height - usually height's don't just change randomly). That said, things are more complicated when something happens outside of the Angular context, but it should be possible nonetheless.
--

It would help the poster, if, when more information is required, some indication of what kind of information is needed, some direct questions would help.

Quoting myself from above:

It is really hard to tell what the problem might be without a live reproduction.

I thought "live reproduction" was direct enough (but still I haven't seen any :P).
--

I believe the change in behaviour I am seeing is due to deferring class changes to postDigest, since the hiding / showing of components is via ng-show

Indeed, ngShow uses $animate.add/removeClass() to add/remove .ng-hide, so the change is deferred until the post-digest phase (and thus not detectable in your watch).
--

Any advice on a strategy for detecting height change within an Angular applications that avoids $watch would be appreciated.

As I mentioned above, usually there is some event/action/condition that results in the change of height.
Watching that instead of meassuring the actual height is the way to go. Furthermore, it sounds like you are in fact trying to detect if the element is visible or not (and not really care about the height).
From what you said (and again...no demo...just saying), the element is shown/hidden as a result of an Angular expression bound to ngShow. If that is indeed the case, you should watch that same expression itself.
--
So, I am going to close this issue, as we seem to have pinpointed the cause of the observed behaviour and the Angular part works as expected (and documented).
Feel free to follow-up should you need any more clarifications.
You can also direct support/usage question to one of the support channels.


transitionCompleted vs newPageReady

Hey all,
I'm trying to reinitiate my other scripts when the "newPageReady". However the scripts don't initiate unless I'm using "transitionCompleted", and if I do the page jumps as the scripts kick in and it doesn't look great.
Is there anything I need to do to allow "newPageReady" to work as expected. I currently have:
First chunk is my barba code
var FadeTransition = Barba.BaseTransition.extend({
  start: function() {
    // As soon the loading is finished and the old page is faded out, let's fade the new page
    Promise
      .all([this.newContainerLoading, this.fadeOut()])
      .then(this.fadeIn.bind(this));
  },

  fadeOut: function() {
      return $(this.oldContainer).animate({ opacity: 0 }, 1000).promise();
  },

  fadeIn: function() {

    var _this = this;
    var $el = $(this.newContainer);

    $(this.oldContainer).hide();

    $el.css({
      visibility : 'visible',
      opacity : 0
    });

    $el.animate({ opacity: 1 }, 1000, function() {
          _this.done();
    });
  }
});

Barba.Pjax.getTransition = function() {

  return FadeTransition;
};

Barba.Pjax.start();

Then I have a function for all the additional js
function vendorStart() {
    <js in here>
}

vendorStart();

I then have my dispatcher
Barba.Dispatcher.on('transitionCompleted', function(currentStatus, oldStatus, container) {
    vendorStart();
});

As mentioned, it works on transitionCompleted but jumps, it doesnt work with 'newPageReady. Any thoughts?
Thanks for any light you can shed on this.

were you able to find a solution for this?

No yet I’m afraid

I just did a project with this and found that the newPageReady event is a bit misleading. It fires when the DOM is ready but not yet necessarily laid out. This meant anything requiring measuring positions etc. would get incorrect values. The fix was to do it on the next 'tick' after that event fires. This might not correspond exactly to your problem but try this:
Barba.Dispatcher.on("newPageReady", (currStatus, prevStatus, newContainer) => {
    setTimeout(vendorStart);
});

Thank you I’ll try this and report back.

Since Barba has no control over the internals of whatever transition you may define, such behaviour could instead be triggered within your custom transition (e.g. somewhere in fadeIn)

@Simon-Tang yes, that's the way I did it; but Barba does have this callback for newPageReady, which is slightly misleading in that the DOM is ready (the elements are present) but the layout (anything that needs to be measured) is not. It could easily be fixed; or another Dispatcher callback could be added


Optimized logic for getting a random TabletServer connection

The previous logic in this class would gather all of the Tserver ZNodes in ZooKeeper, then get the data for each ZNode and validate their ServiceLock. Then, after all of that it would randomly pick one of the TabletServers to connect to. It did this through the ZooCache object which on an initial connection would be empty and causes a lot of back and forth to ZooKeeper. The side effect of this is that the ZooCache would be populated with TabletServer information.
This change modifies the ClientContext to populate the ZooCache in a single-shot background task and modifies the default logic for getting a connection to a TabletServer. The new logic will make 2 calls to ZooKeeper in the best case scenario, one to get the list of TServer ZNodes in Zookeeper and another to get the ZNode data for one of them.
Fixes #4303

With the changes in this PR this method may only be called by test code now, so may be able to clean up and adjust the test code.

I  got rid of the method in aecd790

Full IT build based off commit aecd79064602b2dca413e4274e2c1ba98bbfc048 passed successfully.


fix(crates): do not process relative dependencies twice

Description
Currently in the aztec3 repo we are unable to import helper dependencies that rely on the aztec3-noir standard library that we have created.
The module structure is something like this:
- root
- library
- helper

in our case both helper depends on library and helper, where helper also depends on library. This leads to noir compiling the library files, then recompiling them when processing the helper.
This leads to instances like below, where the same type has two different idents that mismatch.

This pr fixes this issue by recognising when a dependant local crate has already been compiled, and not compiling it again

Problem*

Resolves
Summary*

Documentation

[ ] This PR requires documentation updates when merged.

[ ] I will submit a noir-lang/docs PR.

[ ] I will request for and support Dev Rel's help in documenting this PR.

Additional Context

PR Checklist*

[ ] I have tested the changes locally.
[ ] I have formatted the changes with Prettier and/or cargo fmt on default settings.

Looks like graph::tests::it_works2 is failing

I believe this broke wasm because (last time I checked) the canonicalize function is not supported by wasi. I had replaced this in circom with an alternative impl.


App would crash if the bottom sheet is set to fillMaxHeight()

please help me. Also if you have discord message me at 🔥KingFu🔥#8159

It's fix now just have to upgrade the compose version thx for the help.


[Feature] Limit order function

Are you adding a new feature?

[x] YES
[ ] NO

Are you enhancing the old feature?

[] YES
[x] NO

Is your feature request related to a problem?

[x] YES
[ ] NO

Describe your feature/enhancement.

Can you add the feature by yourself?

[x] YES
[ ] NO

Additional Information
Limit Orders: Functions for placing limit orders to buy or sell securities at a specified price or better.
placeLimitOrder(): Places a limit order to buy or sell securities at a specified price or better.
The placeLimitOrder function takes parameters such as symbol (the trading symbol of the security), quantity (the quantity of securities to be bought or sold), limit_price (the specified price at which the order should be executed), and order_type (specifying whether it is a 'buy' or 'sell' order).
The function connects to the API or trading platform using the connect_to_api function (which needs to be implemented based on the specific API documentation).
It constructs the limit order request using the provided parameters.
The api.place_order method is called to place the order, passing the order request as a parameter.
The response is checked to determine if the order was successfully placed. If successful, it retrieves the order ID and prints a success message. Otherwise, it prints an error message.
Finally, the function disconnects from the API or trading platform using the disconnect_from_api function (which needs to be implemented based on the specific API documentation).

Please assign me this issue under gssoc 23 @ighoshsubho
thanks

Sure go ahead @Abhinavcode13 ;)

Hello @Abhinavcode13, this is Version 2 of Fintech API repository, there had been few major updates, please go through the docs to make further contributions. Thanks.

@ighoshsubho so can i still contribute for this issue

why isn't this issue closed

why isn't this issue closed

Can you work on it @bhavya1857?

yes, but why isn't this issue closed? And what do you mean by version 2

It was raised by @Abhinavcode13, and it was not done as expected. I kept it open so that he or any other contributor if comes can work on making this feature.
Version 2 is for adding more features to this API repo. Now the entire repo is:

Modular
Has request validation
Auth for certain routes
API docs

These were not there in prev version.
Any more clarification @bhavya1857?

Oh ok, I can do this

Sure thing!

is this the updated version

?

The pic has not loaded and its pointing to this page URL.
Anyways the repo itself is updated. Fork the repo and then clone it locally. Else sync the previous changes. and your cloned repo will get upgraded to v2.
Then work on this feature locally.

i'm sorry i couldn't figure this out, please assign it to someone else


zh-trans: website/content/zh/docs/user-journeys/users/cluster-operato…

…r/intermediate.md

^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
Remember to delete this note before submitting your pull request.
For pull requests on 1.15 Features: set Milestone to 1.15 and Base Branch to dev-1.15
For pull requests on Chinese localization, set Base Branch to release-1.14
For pull requests on Korean Localization: set Base Branch to dev-1.14-ko.<latest team milestone>
If you need Help on editing and submitting pull requests, visit:
https://kubernetes.io/docs/contribute/start/#improve-existing-content.
If you need Help on choosing which branch to use, visit:
https://kubernetes.io/docs/contribute/start#choose-which-git-branch-to-use.
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^

assign @dchen1107
Please give this PR approval.

/assign @chenrui333

/assign @chenrui333


Readme mentions "removeHtml" but function not found

Hi, I just found this package in the search for a way to cleaning up some test.
Overall it does exactly what I need, so thanks for publishing.
I found that in the readme at the top it shows an example with removeHtml but in the docs below it's called stripHtml?
I think both would work, and maybe even a double name would be helpful for ease of memory.
Thanks,
Chris

I believe there was meant to be stripHtml


Create DLL folder, move DLL files to respective folders (not linked)

This just moves DLL into respective folders. No linking or actions are performed at build step.

Linking is done when the .exe is being built, the " Pre-link " event is done before the .exe. To specify which DLL and how it will be used by the .exe.
Additionally the ping command is there to make sure that the linking is done before continuing, giving it a specified time to do so.

Yes It does exactly as you described as well, for reference try removing the ping  command from pre linking and then try to run the .exe you won't be able to :)


Is anyone else getting an old version on npm?

The version I'm grabbing from npm (@1.2.3) does not look the same as the version in this github repo (@1.2.3). For example, the code in this repo is written using ecma6, but the copy i keep getting from npm isn't. Any idea on why this may be happening?

Hi @tendolukwago
Good question. What does the code you are downloading from npm look like?
Do the first couple of lines look something like the below:
'use strict';

Object.defineProperty(exports, "__esModule", {
  value: true
});
exports.default = configureStore;

If it is, then everything is good 👍
The version that you are downloading is what the code looks like after going through babel.

Dope. Thanks for the quick reply.
I'm having another problem I'm hoping you can help me on. Gonna open up another issue.


Direct users to submit github issues when a developer error is encountered

For example in siac when a 404 error is returned, print "Please file a bug report on our GitHub: https://github.com/NebulousLabs/Sia/issues" before the error message.
This could be added to build.Critical messages as well.

It's difficult to add this to siac because modules that aren't started do not have their routes registered and will therefore return 404 when there is no bug.


Delete unused resources

Description
MA-2580
Deleted a whole bunch of unused resources.
I left the "standard" colors/dimensions intact, even though we aren't using some of them. Everything else I deleted.
Reviewers
If you've been tagged for review, please check your corresponding box once you've given the :+1:.

[ ] Code review: @mdinino
[ ] Code review: @BenjiLee

@@             master       #767   diff @@
==========================================
  Files           486        485     -1
  Lines         20689      20598    -91
  Methods           0          0
  Messages          0          0
  Branches       2926       2912    -14
==========================================
  Hits           3650       3650
+ Misses        16632      16541    -91
  Partials        407        407

Review [#767][cc-pull] on Codecov

Powered by Codecov. Last updated by [3c3c20a...fdac780][cc-compare]
[cc-base-branch]: https://codecov.io/gh/edx/edx-app-android/branch/master?src=pr
[cc-compare]: https://codecov.io/gh/edx/edx-app-android/compare/3c3c20a02cd2086871c724ee2fd5830fa1cfdf14...fdac78009e7c1483c83c633411416611c35dae30?src=pr
[cc-pull]: https://codecov.io/gh/edx/edx-app-android/pull/767?src=pr

👍

👍

Just curious, is there a pro-tip for finding unused resources/stuff in Android Studio ?

Just curious, is there a pro-tip for finding unused resources/stuff in Android Studio ?

Yes, the lint tool detects them https://developer.android.com/studio/write/lint.html


change team member add RPC to return who failed to be added

service_helper AddMembers is modified to retry on server TeamContactSettingsBlock error. if it fails with the same error (a 2nd time) it will return the TeamContactSettingsBlock error, which should contain the list of restricted users (failed to add)
approach is to change the following RPCs:

[X] implemented [X] tested; resolveIdentifyImplicitTeam - after discussion, we decided not to modify this endpoint. we test LookupOrCreateImplicitTeam (which is called by ResolveIdentifyImplicitTeam)  in teams/implicit_test.
[X] implemented [X] tested;  teamAddMember - noop implementation. added team/members_test test.
[X] implemented [X] tested;  teamAddMembers - calls service_helper AddMembers. added systests tested in team/members_test.
[X] implemented [X] tested; teamAddMembersMultiRole - noop implementation. tested in team/members_test.
[X] implemented [X] tested; TeamReAddMemberAfterReset - noop implementation. tested in teams/implicit_test.

got approval from zapu in chat


Fix priority.md typo

@rusjoan Please sign the Contributor License Agreement!
Click here to manually synchronize the status of this Pull Request.
See the FAQ for frequently asked questions.

@rusjoan Thank you for signing the Contributor License Agreement!

Well spotted. Thanks!