Created Tic-tac-toe.java

@AnuragRoy485 Your PR has been merged successfully, Thank you for your contribution.
Give repo a star if it was useful.
Happy hacking.


update EINFRA page

include: when there is an existing collaboration/wallet always add the collaboration name in the request

Also, should the EINFRA be renamed to "NWO small"?

Yes, agree

Think @jelletreep did this in #25 so will close this 🎆


Required validation is not working

If ui-timepicker directive is added to an input textbox, validation events are never fired.
Usage:
<input id="timepickerTest" name="timepickerTest" ui-timepicker ng-model="myModel" type="text"
                                                class="form-control" required />

Hm.. I can't seem to reproduce the problem that you describe. We also have a specific test for this, that tests for the validation of a required ui-timpicker with blank input: https://github.com/Recras/angular-jquery-timepicker/blob/master/test/timepicker.spec.js#L102
Could you try writing a test for your case?


Improve Integration tests

Expand upon current integration tests within ./test.sh.
In addition, it seems that the tests are not reporting correctly.
They are reporting a javax.ws.rs.WebApplicationException: Error code: 401, Error message: ...

I've moved the bug with the integration tests reporting to #61
This issue could use more detail about the kinds of tests that should be added - what is there now? What specific tests should be added for this issue to be considered "done"?


fix: omit lodash.set vuln until spectral approves fix

Snyk vulnerability SNYK-JS-LODASHSET-1320032 should be ignored until spectral approves fix mentioned here: https://github.com/stoplightio/spectral/issues/2017

:tada: This PR is included in version 0.53.0 :tada:
The release is available on npm package (@latest dist-tag)
Your semantic-release bot :package::rocket:

:tada: This PR is included in version 0.2.0 :tada:
The release is available on npm package (@latest dist-tag)
Your semantic-release bot :package::rocket:


build: Latest go-mods, config and Dockerfile fix

Signed-off-by: Leonard Goodell<EMAIL_ADDRESS>

If your build fails  due to your commit message not passing the build checks, please review the guidelines here: https://github.com/edgexfoundry/edgex-go/blob/main/.github/Contributing.md
PR Checklist
Please check if your PR fulfills the following requirements:

[x] I am not introducing a breaking change (if you are, flag in conventional commit message with BREAKING CHANGE: describing the break)
[x] I am not introducing a new dependency (add notes below if you are)
[ ] I have added unit tests for the new feature or bug fix (if not, why?) N/A
[ ] I have fully tested (add details below) this the new feature or bug fix (if not, why?) N/A
[ ] I have opened a PR for the related docs change (if not, why?) N/A

Testing Instructions

New Dependency Instructions (If applicable)

Codecov Report

Merging #4217 (7bf2850) into main (9ee2498) will increase coverage by 0.01%.
The diff coverage is 52.38%.

:exclamation: Current head 7bf2850 differs from pull request most recent head aa1fa3a. Consider uploading reports for the commit aa1fa3a to get more accurate results

@@            Coverage Diff             @@
##             main    #4217      +/-   ##
==========================================
+ Coverage   43.28%   43.29%   +0.01%
==========================================
  Files         125      125
  Lines       11106    11126      +20
==========================================
+ Hits         4807     4817      +10
- Misses       5887     5896       +9
- Partials      412      413       +1

Impacted Files
Coverage Δ

...rnal/core/command/controller/messaging/internal.go
0.00% <0.00%> (ø)

...nternal/core/command/controller/messaging/utils.go
66.03% <75.00%> (+1.59%)
:arrow_up:

...rnal/core/command/controller/messaging/external.go
87.23% <100.00%> (+0.56%)
:arrow_up:

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.


Add search functionality to organization list (postgres required)

Currently only works with postgres

posting this here as a reminder to myself to put psycopg2 in requirements.txt thanks


limit maximum number of tasks in whenever gem rails

How can i limit maximum number of tasks in whenever. For example if i have something like this
every 1.hours do
runner "MyModel.some_process"
rake "my:rake:task"
command "/usr/bin/my_great_command"
end
I want to limit it to 1 means if there is a thread already running do not start new thread at next hour.

The general idea in https://github.com/javan/whenever/pull/598 is what you're looking for. This is something that cron itself doesn't support, and I believe to be outside the scope of Whenever. You might want to consider using cron or sidekiq-scheduler to schedule jobs on a queue with a single worker.


missing entire "dependencies" group of predefined variables

Missing the entire "dependencies" group of predefined variables. For example to get a var value from another job's output var you would access: dependencies.jobName.outputs['stepName.varname']
See https://docs.microsoft.com/en-us/azure/devops/pipelines/process/variables?view=azure-devops&tabs=yaml%2Cbatch#set-in-script for them being used
...yet what are all the vars in the dependencies tree?

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 9ffebdc8-521c-44b5-cde4-4abdc1bd6f18
Version Independent ID: dc0effda-6d93-62aa-64c5-4e6f283b0826
Content: Predefined variables - Azure Pipelines
Content Source: docs/pipelines/build/variables.md
Product: devops
Technology: devops-cicd
GitHub Login: @steved0x
Microsoft Alias: sdanie

@diablodale - if it helps - the object structure for dependencies is briefly mentioned here.

Hello. What was the action on this so I can verify the close?


Rework error handling in JSON pipeline

This series fixes #5598 -- provides the infrastructure, and fixes that issue's motivating example. See commit messages and comments for details.

Automated message from Dropbox CLA bot
@gnprice, it looks like you've already signed the Dropbox CLA. Thanks!

(On my own fork at least, Travis shows a backend failure and production error, but empty logs for both of them. The backend tests pass locally for me, as do mypy and casper. Hopefully Travis does better with the builds running on this PR.)

Thanks for working on this @gnprice!  This branch looks great.  It looks like you have some linter errors.  A few notes on these:

Some error strings lacking translation tags.  The root bug is that I guess our linter for these only applies to JsonableError, not its subclasses, so when you got rid of SocketAuthError, that changed, and now the linter is catching the fact that these didn't have translation tags :(.  As a sidenote, shouldn't SocketAuthError have had a non-400 status code?
Never use == or != in JavaScript; it has super weird behavior.  === and !== are the things to use.

Jul 21 04:28:03 Using /srv/zulip-py3-venv
Jul 21 04:28:20 py        | Argument to JsonableError should be a literal string enclosed by _() at zerver/tornado/socket.py line 128:
Jul 21 04:28:20 py        |             raise JsonableError('Unknown or missing session')
Jul 21 04:28:20 py        | Argument to JsonableError should be a literal string enclosed by _() at zerver/tornado/socket.py line 132:
Jul 21 04:28:20 py        |             raise JsonableError('CSRF token does not match that in cookie')
Jul 21 04:28:20 py        | Argument to JsonableError should be a literal string enclosed by _() at zerver/tornado/socket.py line 135:
Jul 21 04:28:20 py        |             raise JsonableError("Missing 'queue_id' argument")
Jul 21 04:28:20 py        | Argument to JsonableError should be a literal string enclosed by _() at zerver/tornado/socket.py line 143:
Jul 21 04:28:20 py        |             raise JsonableError("You are not the owner of the queue with id '%s'" % (queue_id,))
Jul 21 04:28:26 eslint    |
Jul 21 04:28:26 eslint    | /home/travis/build/zulip/zulip/static/js/server_events.js
Jul 21 04:28:26 eslint    |   191:56  error  Expected '===' and instead saw '=='  eqeqeq
Jul 21 04:28:26 eslint    |
Jul 21 04:28:26 eslint    | ✖ 1 problem (1 error, 0 warnings)
Jul 21 04:28:26 eslint    |

Lint issues fixed!

I guess our linter for these only applies to JsonableError, not its subclasses

Yeah, probably. SocketAuthError wasn't even a subclass, either -- just a direct Exception subclass with its own msg attribute.

As a sidenote, shouldn't SocketAuthError have had a non-400 status code?

Seems like 403 would be the right HTTP status code. I'm not quite sure what the plumbing looks like here, though -- the error handler does a self.session.send_message call which doesn't seem to specify a status code, and then tells write_log_line about a 403 response. Does send_message correspond to an HTTP response in the first place? It's not obvious to me that it does. I'm not sure there's a place for an actual HTTP status code here.

Yeah -- I chose not to write that because #5598 mentions one other example too. So I don't want to close it without either fixing that other example (probably quick and will do today) or filing a specific issue for it.

You have a capitalization linter issue tools/check-capitalization.
zerver/lib/socket.py is for websockets, so it's going to correspond to a websocket response.  Probably HTTP codes are irrelevant there.  So maybe we're OK.
A bit of history: originally, for no reason I'm aware of, none of the things that should be subclasses of JsonableError were; they just all defined the same API.  Which is why it had that funny duck-typing model.  I tried to purge those last year, but apparently missed the SockAuthError :).

Gah. Fixed.
Kind of a pain to have a bunch of separate tools to run to check these things. The capitalization linter (and maybe the frontend-18n linter and others) should probably be under the tools/lint umbrella. ... Hmm, in fact I bet a reason it wasn't before was that it used to litter changes in the working copy, which we recently fixed by having it only generate English message files and having Git ignore those.

It's also probably too slow for incremental lint, but might be fine if you're running lint without arguments.  Could be a good quick project to migrate that to be a linter that does nothing on subdirectories.

Ping -- shall we merge this?

Yep, merged, thanks @gnprice!  I was just waiting for CI to run, since we'd had so many little issues on this one :)


Gene name in result list and variant details can differ

Describe the bug
For example for the gene HGNC:25322 - result list displays C12orf29 (previous symbol) while the official name is RLIG1
https://www.genenames.org/data/gene-symbol-report/#!/hgnc_id/HGNC:25322

RCA
The annotation of the gene for the variant in the variant details comes from annonars. In the result list, it is joined via the postgres query coming from the RefseqToGeneSymbol/EnsemblToGeneSymbol table. These tables are not up-to-date.
https://github.com/varfish-org/varfish-server/blob/1f6608d767f45fd37312d738fd33061fef7fcf5a/backend/variants/queries.py#L291
Solution

Either we wait for the next-generation annotation step with mehari.
or we substitute the join of the table with a call to annonars.


HLIL Doesn't Currently Retrieve this pointer

Atm if one loads up binaries such as win32kfull.sys and attempts to decompile a function with a this pointer in its function defininition, such as ESTROBJ::ptlBaseLineAdjustSet, the definition in Binary Ninja will be as though the invisible this pointer never existed. This makes it incredibly annoying to correct HLIL output that uses the this pointer in its code. This can be seen in the image below.

On the contrary, programs like Relyze are able to recognize that this function has a hidden this parameter from the PDB information:

This is dependent on this issue #604

PDBs now properly annotate this parameters and thiscall functions, so combining the fixing of #604 with the new PDB loader in 3.1.3715-dev, this is now fixed.


Consolidate Client and ClientCore

Further streamlining after testing client.get_resource(name) vs client.session.get(url):

removed Client.print_methods() as it did not work
remove API constants from Client
make _get_items and _request methods public
set default "application/json" media type on request get

Which functions are considered non-essential? Happy to put those back e.g. into ClientExtra.py

I also agree that Client should be as lean as possible. Perhaps we can mixin other helper methods (e.g. that address specific end-points) or extend from Client. At the moment I think Client contains only essential items and I'll keep this in mind as we determine in the future what will happen with HubInstance.

I'll check that as well. Note that status_code / 100 != 2 is not behaving as one might expect. Python3 is turning status_code / 100 into a float. Are you trying to say continue ahead if status_code within 200..299?

Good catch - that was the intention. Should work as int(status_code/100) != 2.


Issue: Need Slider with values 0.1, 0.5, 1, 2, 5, 10, 15, 20, 30

// Issue: Need Slider with values 0.1, 0.5, 1, 2, 5, 10, 15, 20, 30
// Solution: On some step it is possible to show value what we want

I signed it!
пн, 28 серп. 2017 о 00:20 googlebot<EMAIL_ADDRESS>пише:

Thanks for your pull request. It looks like this may be your first
contribution to a Google open source project. Before we can look at your
pull request, you'll need to sign a Contributor License Agreement (CLA).
📝 Please visit https://cla.developers.google.com/
https://cla.developers.google.com/ to sign.
Once you've signed, please reply here (e.g. I signed it!) and we'll
verify. Thanks.

If you've already signed a CLA, it's possible we don't have your
GitHub username or you're using a different email address. Check your
existing CLA data https://cla.developers.google.com/clas and verify
that your email is set on your git commits
https://help.github.com/articles/setting-your-email-in-git/.
If your company signed a CLA, they designated a Point of Contact who
decides which employees are authorized to participate. You may need to
contact the Point of Contact for your company and ask to be added to the
group of authorized contributors. If you don't know who your Point of
Contact is, direct the project maintainer to go/cla#troubleshoot.
In order to pass this check, please resolve this problem and have
the pull request author add another comment and the bot will run again.

—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/angular/material2/pull/6664#issuecomment-325225510,
or mute the thread
https://github.com/notifications/unsubscribe-auth/ADPHehY0VNq9HA5lLn6mD2YiNpBT-pBnks5scd2ZgaJpZM4PD7EJ
.

Maybe we can go with a display function as @willshowell mentioned in #4776? This would be more consistent with how we do it in autocomplete. Also needs tests

I #4776 https://github.com/angular/material2/issues/4776 this idea!
ср, 30 серп. 2017 о 19:33 mmalerba<EMAIL_ADDRESS>пише:

Maybe we can go with a display function as @willshowell
https://github.com/willshowell mentioned in #4776
https://github.com/angular/material2/issues/4776? This would be more
consistent with how we do it in autocomplete. Also needs tests
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/angular/material2/pull/6664#issuecomment-326046600,
or mute the thread
https://github.com/notifications/unsubscribe-auth/ADPHerlgldjc8JOkkXrhN4gFivZD-PuGks5sdY7TgaJpZM4PD7EJ
.

Do you need help or it is done by another peoples?
ср, 30 серп. 2017 о 19:36 Андрей Сягровский<EMAIL_ADDRESS>пише:

I #4776 https://github.com/angular/material2/issues/4776 this idea!
ср, 30 серп. 2017 о 19:33 mmalerba<EMAIL_ADDRESS>пише:

Maybe we can go with a display function as @willshowell
https://github.com/willshowell mentioned in #4776
https://github.com/angular/material2/issues/4776? This would be more
consistent with how we do it in autocomplete. Also needs tests
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/angular/material2/pull/6664#issuecomment-326046600,
or mute the thread
https://github.com/notifications/unsubscribe-auth/ADPHerlgldjc8JOkkXrhN4gFivZD-PuGks5sdY7TgaJpZM4PD7EJ
.

Closing this as stale now


Adding read preference to the collection

Adding read preference as an attribute on the collection.

Isn't this PR to be closed because it is subsumed into #219 entirely?


Cloning Repo from Bitbucket failing -- team completely blocked

Before opening, please confirm:

[X] I have checked to see if my question is addressed in the FAQ.
[X] I have searched for duplicate or closed issues.
[X] I have read the guide for submitting bug reports.
[X] I have done my best to include a minimal, self-contained set of instructions for consistently reproducing the issue.
[X] I have removed any sensitive information from my code snippets and submission.

App Id
d1o1goat7xuf0t
AWS Region
us-east-1
Amplify Hosting feature
Backend builds, Deployments
Frontend framework
React
Next.js version
N/A
Next.js router
N/A
Describe the bug
All of sudden earlier today our builds stopped working at the clone repository step.
We did not modify amplify.yml or make any other major changes in git, it failed on a small UI update merge.
Even getting the error when clicking redeploy this version on a previous successful builds.
We utilize a repository in Bitbucket.
Expected behavior
Repo clones and build as it did before.
Reproduction steps
N/A -- Feel free to "redeploy" the latest version on main.
Build Settings
version: 1
backend:
  phases:
    preBuild:
      commands:
        - npm i -g<EMAIL_ADDRESS>        - yarn global add typescript
        - amazon-linux-extras enable golang1.11
        - yum clean metadata
        - yum -y install golang jq
        - export GOPROXY=https://proxy.golang.org
    build:
      commands:
        - '# Execute Amplify CLI with the helper script'
        - amplifyPush --simple
frontend:
  phases:
    preBuild:
      commands:
        - yarn install --frozen-lockfile
    build:
      commands:
        - yarn build --skip-nx-cache
  artifacts:
    baseDirectory: dist/apps/company
    files:
      - '**/*'
  cache:
    paths:
      - node_modules/**/*
test:
  phases:
    preTest:
      commands:
        - yarn install --frozen-lockfile
        - npx cypress install
    test:
      commands:
        - export COMMIT_INFO_BRANCH="$(git rev-parse HEAD | xargs git name-rev | cut -d' ' -f2 | sed 's/remotes\/origin\///g')"
        - export COMMIT_INFO_MESSAGE="$(git log -1 --pretty=%B)"
        - export COMMIT_INFO_EMAIL="$(git log -1 --pretty=%ae)"
        - export COMMIT_INFO_AUTHOR="$(git log -1 --pretty=%an)"
        - export COMMIT_INFO_SHA="$(git log -1 --pretty=%H)"
        - export COMMIT_INFO_REMOTE="$(git config --get remote.origin.url)"
        - yarn e2e:ci --spec **/signUp.cy*
        - yarn e2e:ci --excludeSpecPattern **/signUp.cy*
    postTest:
      commands:
        - npx mochawesome-merge dist/cypress/apps/company-e2e/mochawesome-report/mochawesome_*.json > dist/cypress/apps/company-e2e/mochawesome-report/mochawesome.json
  artifacts:
    baseDirectory: dist/cypress/apps/company-e2e/
    configFilePath: '**/mochawesome.json'
    files:
      - '**/*.png'
      - '**/*.mp4'
  cache:
    paths:
      - node_modules/**/*

Log output

2023-09-25T20:13:52.913Z [INFO]: Git SSH Key acquired
2023-09-25T20:13:52.992Z [INFO]: # Cloning repository: git@bitbucket.org:company/company.git
2023-09-25T20:14:08.505Z [INFO]: Agent pid 157
2023-09-25T20:14:08.641Z [INFO]: Identity added: /root/.ssh/git_rsa (/root/.ssh/git_rsa)
                                 Cloning into 'company'...
                                 Warning: Permanently added the ECDSA host key for IP address '<IP_ADDRESS>' to the list of known hosts.
2023-09-25T20:14:08.642Z [INFO]: # Switching to commit: d0aa6581da79f039cd1b27ae7f43d49b149cb373
2023-09-25T20:14:08.718Z [INFO]: Agent pid 170
2023-09-25T20:14:08.719Z [INFO]: Identity added: /root/.ssh/git_rsa (/root/.ssh/git_rsa)
                                 Note: switching to 'd0aa6581da79f039cd1b27ae7f43d49b149cb373'.
                                 You are in 'detached HEAD' state. You can look around, make experimental
                                 changes and commit them, and you can discard any commits you make in this
                                 state without impacting any branches by switching back to a branch.
                                 If you want to create a new branch to retain commits you create, you may
                                 do so (now or later) by using -c with the switch command. Example:
                                 git switch -c <new-branch-name>
                                 Or undo this operation with:
                                 git switch -
                                 Turn off this advice by setting config variable advice.detachedHead to false
                                 HEAD is now at d0aa6581 amplify.yml edited online with Bitbucket
2023-09-25T20:14:08.767Z [INFO]: Successfully cleaned up Git credentials
2023-09-25T20:14:08.768Z [INFO]: # Checking for Git submodules at: /codebuild/output/src847317844/src/g2mint/.gitmodules
2023-09-25T20:14:08.795Z [ERROR]: !!! CustomerError: Invalid configuration file found in repository: Unexpected end of JSON input
2023-09-25T20:14:08.795Z [INFO]: # Starting environment caching...
2023-09-25T20:14:08.795Z [INFO]: # Environment caching completed
Terminating logging...

Additional information
No response

Hi @djorgji 👋 , it looks like you have a buildSpec amplify.yml file in your git repository and the build process is failing as the amplify.yml file seems to have some syntax errors. I'll recommend using a yaml linter to ensure the file does not have any syntax errors. Once you have ensured that, you can then redeploy the build.

@Jay2113 I have double checked the amplify.yml a few dozen time. I have reconnected repository, and disconnected/reconnected the branch, still the same error. When I click Redeploy this version on an older fully successful build it still the same error.
I just checked again with a few different validators, and it is they all said the yml is valid.

@djorgji thanks for confirming that. Based on the baseDirectory: dist/apps/company attribute, it seems that you may have your app in a monorepo setup and if that's the case the amplify.yml file is missing the appRoot attribute: https://docs.aws.amazon.com/amplify/latest/userguide/monorepo-configuration.html#monorepo-yml-syntax
Can you verify the same?

@Jay2113 I noticed there was a package-lock.json even though we use yarn, so I deleted it, that seems to have done the trick.
Unsure how it was corrupted, or how it showed up to begin with... neither of which is your problem, so I am closing this. Sorry for the trouble, and thanks for your time!

Resolved closing.


Internal tank does not drain some fluids

I've been having several issues with the internal tank filling and getting stuck full, where it won't drain, nor will the pump operate. This happens for example with betweenlands swamp water and ender io pressurized fluid conduits. It will usually work for a brief time and then cease to operate shortly thereafter. Breaking and replacing the pump sometimes works but usually not (usually it still refuses to drain, fills the internal tank again, and then ceases functioning again). Nothing turns up in the log to provide.

There is not another fluid in the conduit preventing draining. In the above example stagnant water (which sometimes pumps in place of swamp water) is properly voided, and it still does not pump.
Seems to place fluid into tanks properly, but not conduits, pipes, and other non-tank fluid transport blocks.

I can't reproduce this.


feat: Any chance for switch session with language bind with?

🚀 Feature Proposal
Thanks for the work! 😄
I thought it would be great if it could has multi language session switch feature.
I saw there was already a session feature, but I'm confused with the configuration,
(I could not found much detailed description in readme... 🤔)
Is there a separate config file like .leetcoderc? or only in vscode's settings.json
(Maybe a local leetcode-progress json structure to record, even better)(For self analyze propose...)
Motivation
Because I want to practice with multi languages 🙋♀

Hi @seognil,
Would you mind to describe more about the multi-language session? Just not quite get your point. 😄

(Oh, I get it now, the session feature is from leetcode.com, I can manage that on the website.)

The remaining problem is, language
I mean programing language (or defaultLanguage of the api),
I thought it could be better if each session has its own defaultLanguage config in local.
(I only found the global leetcode.defaultLanguage in settings.json in vscode now)
For example:
// leetcode-training-folder/.vscode/settings.json
{
  "sessions": {
    "js": {
      "defaultLanguage": "javascript",
      "outputFolder": "./js/"
    },
    "cpp": {
      "defaultLanguage": "cpp",
      "outputFolder": "./cpp/"
    },
    "python": {
      "defaultLanguage": "python",
      "outputFolder": "./py/"
    }
  }
}

How about that 😄

Switch session is supported in the extension, see: https://github.com/jdneo/vscode-leetcode#manage-session
About your proposed setting schema, I'm not sure if this is a common requirement from others. So I tend to leave it open for a while to see if there is any feedback from other users.
Thank you.


Read zoom and attribution config from /

This allows different installs to use their own setting while
reducing hard-coding.
When you have URL parameters, there is currently a flash where you see
the default map before it loads the settings and zooms.  The settings
could be cached in localStorage to mitigate that.
This changes the default max zoom (used only if the /info.json request
fails) to 18.  This is on the theory that 18 is safe if 20 is
available, but not vice-versa.
Bug: T186780
Updated version of https://github.com/kartotherian/server/pull/4 .

I think 18 is a better (safer) default, but I don't feel strongly about that.
I'm not sure if the flash is a blocker.

minor thing, but looks good otherwise. What is a "flash is a blocker"?

@mooeypoo thx, but just to keep it in perspective - this is a test file, used for testing that the maps server is still up and running, so we shouldn't spend too much time on it :)  Most of the client side polishing should be probably done in the kartographer ext.

minor thing, but looks good otherwise. What is a "flash is a blocker"?

See second paragraph of the commit message.  Essentially, if you open a URL like https://maps.wikimedia.org/#8/41.865/-93.043 in a new tab (or just start there and refresh), you'll see a flash of the entire North American continent before it goes where you requested.  I thought this was caused by my patch, but now I see it's happening on maps.wikimedia.org already.  And logically, the patch shouldn't make the flash worse (though overall time might get a little worse), since it doesn't even register the layer/tile URL (so can't show the default layer view/continent) before the AJAX request is already done.
I think the flash is worse locally generally.

@mooeypoo thx, but just to keep it in perspective - this is a test file, used for testing that the maps server is still up and running, so we shouldn't spend too much time on it :) Most of the client side polishing should be probably done in the kartographer ext.

I agree there's no need to overdo it, but it's at a very prominent URL (maps.wikimedia.org), so it should be solid (solid and simple is good, though).

@mattflaschen sounds all good. Let me know if you want to clean it up a bit, or if not, I'm ok to merge it even as is.

I'll have the changes I mentioned above uploaded today.  It will need a rebase after that (I thought I got it working on top of master, but I was wrong).
It will be on 0.0.17 again, the version from https://github.com/kartotherian/kartotherian/blob/update-snapshot-dep/package.json .  Someone needs to look at how to get the overall stack working with a newer kartotherian/server.
We can't just repoint kartotherian/kartotherian package.json to kartotherian/server master + this patch (at least for me, an equivalent to that causes "source.getHandler(...).getAsync is not a function")
When the overall stack is working, this can be merged and tagged, then kartotherian/kartotherian package.json updated.

It's only marked WIP because of the 0.0.17 issue I noted above (master + this patch needs to be successfully tested with the rest of the stack).

Getting the repos working together with latest kartotherian/server tracked as https://phabricator.wikimedia.org/T187411 .

This PR should now be rebased on top of master.

Note: The current PR fails, and is also not listening to the proper browser eslint rules. I'm fixing this, please do not merge yet.

@mooeypoo btw, if you want, we can make the static content fully wikimedia-only style -- simply because it is totally a standalone, and used just for testing.  I'm more concerned about all the other nodejs code.

Yeah, in order to solve the linting and es6 issues that don't work on browser, I submitted https://github.com/kartotherian/server/pull/8 which basically uses the wikimedia style inside the static folder. I just couldn't use airbnb styling, since all their rules are es6 and even if we override the environment, they still stick ...

I've merged #8, let me know when this PR can be merged.

I verified that this PR works when running with https://github.com/kartotherian/kartotherian/tree/update-deps2
It's good to go.


Fill in the installation page

It shall include instructions to download TermIt, install through docker and install by building source.

Done in the referenced commit.


fix: also update when inputRev changes

It turns out that #119 already worked in some cases.  Namely lake update would pick up changes in transitive dependencies, but only if the inputRev stayed the same.  If the direct dependency switched to another branch of the transitive dependency, then lake update would not pick up the new revision.
This PR removes the inputRev check and adds a test for this issue.
Fixes #119.

@gebner Thanks for the PR, especially the updated test! 😄
However, this does not actually fix the underlying issue.  First, removing the check does not result in Lake copying the entry from a transitive dependency. Rather, it results in it updating the specified dependency to its latest version (a la lake update). Second, the check was there for a reason. Without it, transitive dependencies are updated on every lake build (not just lake update), which is not ideal. (Though, upon reflection, the check does fully achieve what it was meant to do either.)

Oh that is indeed an issue.  I think I got confused by the two meanings of shouldUpdate here (are we inside lake update vs. should we do a git pull).  Maybe it would be best to separate the two functions.
I've updated the test to include the issue you've mentioned.

I think I got confused by the two meanings of shouldUpdate here (are we inside lake update vs. should we do a git pull). Maybe it would be best to separate the two functions.

For reference, shouldUpdate always means "should we do a git pull" -- there is no setting for "are we inside a lake update". It is just that lake update sets shouldUpdate since it wants to do a git pull (because that is what lake update is for).

Superseded by #138.


doesn't accept [ inside bracket expression

For GNU grep [[] is just like \[, but the regex crate reports an error:
regex parse error:
    [[]
     ^^
error: unclosed character class

(I don't know if that is a GNU extension or a missing corner case in the regex crate.)

This is by design, and there is certainly no specific goal to be compatible with POSIX regex syntax, which has a number of idiosyncrasies. For example, this regex engine supports nested character classes, such that [[a-z]--[a-g]] is a thing. As is [[a-g][x-z]], for example. So failure modes for unescaped brackets are more important.
In general though, this crate has taken a less flexible approach to escaping in favor of better failure modes. Many regex engines will, for example, permit things that normally need to be escaped to remain unescaped if there exists an otherwise valid interpretation. (This crate does make an exception for things like [-a-z], where the leading - is treated as a literal -.)


Form values not initialized from initialValues until 2nd render cycle

We have been struggling w/ this for a while now and following some of the related issues. I'm not sure if our problem is directly related to these others or not (using release 4.1.6):

https://github.com/erikras/redux-form/issues/176
https://github.com/erikras/redux-form/issues/578

To summarize, we are finding that values are not being initialized until the second render cycle for our reduxForm-ed components. Example being that none of the following properties would be initialized until the first call of componentWillReceiveProps (i.e. the 2nd render):

props.fields.someField.value
props.values.someField

Although, the following properties are initialized (even for the 1st render cycle) according to initialValues

props.fields.someField.defaultValue
props.fields.someField.initialValue
etc...

My question would be, is what I've described above the expected behavior from redux-form? This causes issues for us where children component who depend on valid props being passed down to them receive undefined on the 1st render cycle and we can not rely on the "values" being reliably initialized.
We have resorted to something similar to
render() {
  if (typeof values.someField === 'undefined') {
    return null;
  }

  // ...
}

but then we can not rely on componentDidMount, etc...
I will make an effort to circle back and try and clarify this issue. I just want to get this out there for possible discussion. Any feedback/advice is much appreciated!

Here is some mostly-valid code below to illustrate the issue we have been experiencing
const SomeForm = React.createClass({

  componentWillMount() {
    const {values} = this.props;
    if (typeof values.someString === 'undefined') {
      // All values = undefined
      // props.fields.someString.defaultValue is set as expected
      // props.fields.someString.initialValue is set as expected
      debugger;
    } else {
      debugger;
    }
  },

  componentDidMount() {
    const {values} = this.props;
    if (typeof values.someString === 'undefined') {
      // All values = undefined
      // props.fields.someString.defaultValue is set as expected
      // props.fields.someString.initialValue is set as expected
      debugger;
    } else {
      debugger;
    }
  },

  componentWillReceiveProps(newProps) {
    const {values} = newProps;
    if (typeof values.someString === 'undefined') {
      debugger;
    } else {
      // Values initialized on 1st call (2nd render)
      debugger;
    }
  },

  render() {
    const {
      fields: {someString, someArray, someObject},
    } = this.props;

    return (

        <ComponentUsesSomeString
          value={someString.value}
          onChange={someString.onChange}
        />
        <ComponentUsesSomeArray
          value={someArray.value}
          onChange={someArray.onChange}
        />
        <ComponentUsesSomeObject
          value={someObject.value}
          onChange={someObject.onChange}
        />

    )
  }

});

const ReduxFormedSomeForm = reduxForm(
  {name: 'SomeForm', fields: ['someString', 'someArray', 'someObject']},
  (state) => {
    return {
      initialValues: {
        someString: 'Some String',
        someArray: ['some', 'array'],
        someObject: {a: 'some', b: 'object'},
      },
    };
  }
)(SomeForm);

const App = React.createClass({
  render() {
    return (

        <ReduxFormedSomeForm />

    )
  }
})

#485 and #514 do point at the same thing I think. It would be great to have some direction on this matter since it seriously hinders server side rendering.

Excellent description. :+1: I understood what you meant before I even got to the code.
Yes, this is a bizarre inconsistency with the library that should be remedied. The problem is that it is using the values from the redux state, which are not yet set until the the INITIALIZE action gets dispatched on componentWillMount(), so it doesn't get them until the second render. What needs to happen is that redux-form needs to be smart enough to go ahead and merge in any initialValues as though they were the values from the redux state on the first render.
I think I know how to fix this, but I can't get to it today.

1

Is there any practical solution to this ?

@erikras so... if I understand correctly, the problem is caused by following reason:

we define fields here:
https://github.com/erikras/redux-form/blob/master/src/createHigherOrderComponent.js#L36
without initial values.
invoke initialize on componentWillMount
https://github.com/erikras/redux-form/blob/master/src/createHigherOrderComponent.js#L44
here is initialize action
https://github.com/erikras/redux-form/blob/master/src/actions.js#L19
that is handling by reducer:
https://github.com/erikras/redux-form/blob/master/src/reducer.js#L71
component renders with fields without initial values
reducer changes form in redux state. Our component is connected to this state branch, so it receive new props and componentWillReceiveProps is invoking:
https://github.com/erikras/redux-form/blob/master/src/createHigherOrderComponent.js#L48
The form was changed, so readFields is invoking:
https://github.com/erikras/redux-form/blob/master/src/createHigherOrderComponent.js#L50
Now our fields have values
render component with new fields with initial values

As i see, we need move initialize from reducer to component, so we will have all fields and form with initial values in component from the very beginning. Then we can define shouldComponentUpdate that will prevent second render if there was nothing changed in fields or form

guys, nobody cares? why?

I care, but I am currently focusing my efforts on the next version, which will take this and all the other unresolved bugs of v4 into account. It's maybe a month or two away from release. I have not taken the time to examine your analysis in depth, but it sounds like you have analyzed the problem well. If you would like to submit a PR that makes the test I wrote (linked above) pass and doesn't break any of the other tests, I'd be happy to accept it into v4.

I am currently seeing this double render as well, which is also affecting the validate function (getting called the 1st time without any values from initialValues, even though they are available).
Anyway - I think @sars has properly identified the issue, now it's time to conceive a solution.

+1

+1

+1

Also causes some tests to fail / be run twice.

Just to let anybody know that stumbles across this, it looks like this issue was specifically solved in the 5.0.0 release

The value prop of your fields will never be undefined [...]

I have yet to fully confirm this (to update our usages to 5.x), but if that is the case this issue might be appropriately closed (unless a 4.x patch is really needed/in demand).

In my case v5 only sets the value to "", not to initialValue.

Hey guys. Just wanted to let you know v6.0.0-alpha has been released!

@silvenon it seems that the change from "uninitialized being `undefined" to "uninitialized being an empty string" might make things worse (for my use cases at least). If you see my examples above (issue description), that is how we are guarding against attempting to render w/ uninitialized values. Hmmm....
FYI I am diving into this now to address throughout our project(s) at work (we ended up having to guard against this on every usage of redux-form throughout :sweat_smile:...) I'll be sure to update if I land on any sensible workaround or come up with a possible patch to submit. I do have a few in mind that I'll start playing with.
It seems that I may be better off sticking w/ v4.x for now considering the "empty string" issue @silvenon  described here

@erikthedeveloper I downgraded as well.

Hey all! I just submitted https://github.com/erikras/redux-form/pull/843 as a fix for this. As far as I understand things, it should pretty well cover this issue. Thanks @sars for laying out the flow of things, that helped me dive in a lot easier 😄
cc @silvenon @Guibod @shilpan

@erikthedeveloper Waiting for a merge from @erikras

I case anybody is looking for a temporary fix before this is actually fixed/merged, this is loosely what I've landed on for the moment so that I can sweep through and remove all my temporary hacks/guards throughout my components. This at least opens up a reliable data flow so that values[field] and fields[field].value are reliably set (for use within that 1st pesky render cycle and components' lifecycle methods).
// SomeFormComponent.js
import { makeFormSafe } from '../../makeFormSafe';

export const MyForm = React.createClass({/* */});

// ...

export const MyFormConnected = reduxForm(
  /*...*/
)(makeFormSafe(MyForm));

// makeFormSafe.js
import { createElement } from 'react';
import _ from 'lodash';

const fieldToValue = ({value, initialValue}) => typeof value !== 'undefined'
  ? value
  : initialValue;

const makeFieldsSafe = (fields) => _.mapValues(fields,
  (field) => typeof field.value !== 'undefined'
    ? field
    : {...field, value: fieldToValue(field)}
);

const makeValuesSafe = (values, safeFields) => _.mapValues(values,
  (value, fieldName) => typeof value !== 'undefined'
    ? value
    : safeFields[fieldName].value
);

/**
 * "Safely" wrap up a FormComponent before passing it to reduxForm
 *  This basically ensures that field.value and values[field] are reliably available...
 *  Pending redux-form patch. See {@link https://github.com/erikras/redux-form/pull/843}
 * @param {Component} component
 * @return {Component}
 */
export function makeFormSafe(component) {
  const ReduxFormSafetyWrapper = ({fields, values, ...otherProps}) => {
    const safeFields = makeFieldsSafe(fields);
    return createElement(component, {
      ...otherProps,
      fields: safeFields,
      values: makeValuesSafe(values, safeFields),
    });
  };

  return ReduxFormSafetyWrapper;
}

@erikras Can you please accept the merge? The issue is still relevant and needs an urgent fix

I apologize, @NSLS and @erikthedeveloper, I totally missed seeing that PR.

Thanks a ton @erikras!

Published as v5.1.4. 👍 Cheers, @sars and @erikthedeveloper!

@erikthedeveloper Can you please look at this test that I wrote to demonstrate the bug for this issue? It's still not passing with your PR. Either the test is wrong or the bug is not really fixed.

@erikras I've been looking into this. I'm not quite familiar with all of the inner workings here. If I follow this all correctly, it seems that the point of entry for the problem is somewhere underneath ReduxForm.constructor assigning this.fields via readFields(/* ... */), likely within or under readField about in this hunk
Either that or initializeState.
Also, I have been unable to locate where field.defaultValue is being set... only where it is being tested for.

I'm still digging in so I'll be sure to post what I come up with.

@erikras After digging around, for what amounted to my full morning, I have yet to come up with a sensible solution for this. I'm going to have to call it quits for the moment... I'll see if I can circle back some time this week.
The key components I found myself digging around in were

getValues.js
updateField.js
readFields.js

It may be related to the change in behavior from 4.x to 5.x described [https://github.com/erikras/redux-form/issues/621#issuecomment-213152226] there seems to be some conflict/duplication surrounding where we "fallback/default" certain properties.

@erikthedeveloper Okay, no worries. No doubt the library is better with your PR than without it, but I don't think the dragon is quite dead yet.

After a few hours digging. I think I find the key point is here and here. In readField.js#L119 field.value is assigned by the initial value that is what we expected, but in updateField.js#L9, because at very first time form state is not created yet, so formFieldValue  will always be '' and override the initial value.

I have an issue with this and nested fields. If I try to 'clear' the form by changing the state of my store, not all fields are set to the right value. Let's say I have the following object in the store:
state.myObject = {
  "name": "test",
  "properties": [
    {
      "name": "first"
    },
    {
      "name": "second"
    }
}

and the following form initialization:
MyForm = reduxForm({
  form: 'myForm',
  fields: [
    'name',
    'fields[].name'
  ]
},
state => ({
  initialValues: state.myObject
}))(MyForm);

Now if somewhere I dispatch an action that reinitialize state.Object to {} or undefined, the form state will be in a weird state where fields contains 2 empty object. I would expect it to fallback to the initial state instead (where fields is empty).

Fix published as v5.2.5.

I'm still getting uninitialized values in validate hook with v5.2.5

@yesmeck ?

😢  Forgot the validate here, conceiving a solution.

Very confused - @erikras @yesmeck I am using v5.2.5 but I seem to have the problem described in the initial post. Perhaps @rpominov has the same. Is a solution coming? Including checks for undefined in validation where I shouldn't need them is getting tedious.

had this problem with a version 3.X.X from react-redux-hot-example boilerplate, just updated to latest version and errors are GONE.
thx ;-)

I seem to be experiencing this also.  Digging around it seems like the overwrite from initial values is occurring at this line:
https://github.com/erikras/redux-form/blob/master/src/updateField.js#L10
I'm not sure what the value of formField is supposed to be when updateField is called... but it appears to be an empty object which causes my value to always default to "".
I may have the opportunity to dive into this at a later point.

@erikras I still see this problem in v5.2.5 when using this.props.values. I saw in the debugger in the redux-form HOC that this.fields._meta.values has keys for the fields, but the values are all undefined in the first render, even though initialValues are correct. Is this expected behavior?

Seeing an issue with v5.2.5 as well. validate is being called with undefined/null when the form mounts. When I handle that with an if statement the form mounts successfully, but any future calls of validate are not causing the form to re-render. Strangely, everything works successfully when using react-hot loader locally. It is just in the production deployment that I am having any issues. Sorry if that is vague/confusing.

still seeing this in v6.0.0.rc3

yes this problem also exists in v6.0.0.rc3

I think it's the onFocus/onBlur event caused this. Only when I touched this field, it will get the field value.

In v6.0.0.rc4 there is the boolean enableReinitialize form config property, that worked for me

Correct take a look at enableReinitialize
Also, be sure to not dispaly your form before you actually have initial values...
e.g.
// ...

	render() {

		const { post } = this.props;

	   return (

	   			{post && <UpdatePostForm initialValues={post} />}

	   );
	}

// ...

Does anyone still see this issue? Or is it only me and i'm missing something?
I have a form and using enableReinitialize with initialValues and a validation of required fields.
Once the INITIALIZE is dispatched, the validate function gets a values with an empty object.
After all the fields are registered, a second call is made to the validate function (not sure how and why..?) but it does not update the form state so there are still sync errors present.
The issue that i see is after all this initialisation, if i go to the form, click on a field and then on something else, the error is shown. Even though the value there is actually valid

I'm having an issue as well which is caused by this, I believe.
In my form, i define initialValues:
FindOrdersForm = reduxForm({
  form: FIND_ORDER_FORM,
  initialValues: {
    startDate: moment().subtract(1, 'months'),
    endDate: moment()
  }
})(FindOrdersForm);

In a parent component that renders this form, I need to access these initial values in componentDidMount. I've tried doing it using getFormValues, but the values are undefined. So no initial values present.
Any ideas?

I'm still having in 6.0.5.

I'm having a similar issue with the second render cycle. I've got an outstanding SO question here outlining my issue: http://stackoverflow.com/questions/40565652/display-server-message-on-initial-redux-form-load I'm simply trying to initialise the display of a react-toaster alert on the first cycle of loading a registration form. It works great if I click a second time on my submit button.

@erikras any news on this?

same problem here @erikras

Thanks seems like enableReinitialize does the job

@erikthedeveloper, @erikras enableReinitalize does the job, but the validate is not working because it is getting undefined/null and here is the error what I am getting with the validate which I am passing to the redux-form:

If I remove the validate from the redux-form, everything works perfectly.
The code for the editTeam is here: https://gist.github.com/reznord/eb0e50539dc72484b7d446f7b8141280
It would be great if I can get a solution for this, on how to use the redux-form validation here.
Thanks in advance.

Hi Anup:
If your code is available somewhere on Github I could take a look at it for
you. Is your application in the public domain?
Cheers,
Dave
On Mon, Dec 12, 2016 at 1:35 AM, Anup<EMAIL_ADDRESS>wrote:

@erikthedeveloper https://github.com/erikthedeveloper, @erikras
https://github.com/erikras enableReinitalize does the job, but the
validate is not working because it is getting undefined/null and here is
the error what I am getting with the validate which I am passing to the
redux-form:
[image: screen shot 2016-12-12 at 12 02 20 pm]
https://cloud.githubusercontent.com/assets/3415488/21090028/eff69b22-c062-11e6-89b3-dee1fdd9e80f.png
If I remove the validate from the redux-form, everything works perfectly.
The code for the editTeam is here: https://gist.github.com/reznord/
eb0e50539dc72484b7d446f7b8141280
It would be great if I can get a solution for this, on how to use the
redux-form validation here.
Thanks in advance.
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/erikras/redux-form/issues/621#issuecomment-266353647,
or mute the thread
https://github.com/notifications/unsubscribe-auth/ASt2yMGpE9LWldrwNoxb23Bid_bu7KOeks5rHOszgaJpZM4HTtp8
.

@gridworkz, the repository is private, can't share the code. You can see my code if you are okay with helping me out on TeamViewer.

Ah OK, I just work on open source, sorry.
Cheers,
Dave
On Mon, Dec 12, 2016 at 11:05 AM, Anup<EMAIL_ADDRESS>wrote:

@gridworkz https://github.com/gridworkz, the repository is private,
can't share the code. You can see my code if you are okay with helping me
out on TeamViewer.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/erikras/redux-form/issues/621#issuecomment-266470484,
or mute the thread
https://github.com/notifications/unsubscribe-auth/ASt2yIvF1eOJa_LnBX7N-K8irnTGAiyWks5rHXDZgaJpZM4HTtp8
.

It seems that the issue still persists when
 {
 enableReinitialize: true,
}

Just a comment that this issue is still present in 6.4.3 even with enableReinitialize and keepDirtyOnReinitialize.

Although actually, the issue I'm mainly having is with  @@redux-form/UPDATE_SYNC_ERRORS.
See this action:
{
  type: '@@redux-form/INITIALIZE',
  meta: {
    form: 'myFormName',
    keepDirty: true
  },
  payload: {
    contactName: 'notempty',
    contactSurname: 'notempty',
    contactEmail<EMAIL_ADDRESS>    contactPhone: '123-456-7890'
  }

is followed immediately by
{
  type: '@@redux-form/UPDATE_SYNC_ERRORS',
  meta: {
    form: 'myFormName'
  },
  payload: {
    syncErrors: {
      contactName: 'First name?',
      contactSurname: 'Last name?',
      contactEmail: 'Please provide an email address.',
      contactPhone: 'Please provide a phone number.'
    }
  }
}

Yes enableReinitialize will do the magic.
// define EditForm ...

EditForm = reduxForm({
  form: 'userEditForm',
  enableReinitialize: true,
})(EditForm);

I can confirm @oychao that writing code with enableReinitialize: true like this helps:
import BigCommerceSettingsForm from 'sr/components/ecommerces/big_commerce/connection/form'
// Imported a component stateless function here

let ConnectedBigCommerceSettingsReduxForm = reduxForm({
  form: 'BigCommerceSettingsForm',
  enableReinitialize: true,
})(BigCommerceSettingsForm)

ConnectedBigCommerceSettingsReduxForm = connect(
  state => ({
    initialValues: {
      description: state.app.bigCommerceSettings.connection.description,
    },
  }),
)(ConnectedBigCommerceSettingsReduxForm)

enableReinitialize didn't work when I had defined redux-form version as ^6.2.0, which installed 6.6.2 version of redux form (syncErrors were present even if the form's initial values were valid). Forcing the version to 6.2.0 fixed it for me.

It works for me on current version without using enableReinitialize, but I found a strange behaviour
reduxForm({
    form: 'someForm',
    initialValues: { foo : 'bar' },
    validate: (values) => someValidator(values, schema),
  })

On validation the initial value/values is passed as Object to my validator and not as Map, so my validator crashed, expecting a Map, as described in the docs. The rest works great and comes in as Map.
So in your validator, you need to:
const { Map } = require('immutable');

values = (!Map.isMap(values)) ? new Map(values) : values ;

To force it to a Map for the initalValues :)
The "schema" thing is that we use "JSON schema" to describe our Form and our validation rules, and we validate with AJV that is a schema validator.
JSON schema
AJV

I have a multi step form -- multiple forms connected by the same name, like a wizard.
The issues is that if I don't set enableReinitialize to true, it won't fill the initialValues. Using enableReinitialize: true resets the form between steps. Any suggestions?

The issue is still there in combination with enzyme.

I am seeing this issue in 6.7.0, but only with numeric field values.  Text values populate their respective fields on first render.  Numeric values take a second render.

I thought I was reproducing this bug with 6.8.0 but after debugging more it was caused by forgetting to add the {form: formReducer} attribute into my top level reducer. It might be worth reduce-form logging a warning if it detects that it's not properly initialized.

@gbegher I think I might be hitting the same issue, unless I'm doing something wrong.
Were you able to work around this?

Using enableReinitialize together with a onChange PUT request creates an infinite loop. I would still like to see another solution to this issue. A have a few forms with routing. For me the form that was opened by the initial routing is always filled and the other are partly filled.

Hey all,
I had this issue and figured out it was because you have to FIRST decorate with reduxForm, and then decorate with redux connect.

@flushentitypacket's solution is what worked for me. If it wasn't for that I'd still be lost...

We're seeing this issue as well using redux-form 7.2.2; this breaks things so badly that they can become disconnected from the client render cycle - i.e. svg styles not updating.

@erikras don't you think this issue needs to be reopened?

I was running into this issue and I had no idea it was being discussed. I thought I was doing something wrong. But I just stumbled on to this while looking for something else, so I'll chime in. I got around it with a conditional mapStateToProps. It's probably considered sloppy but it is getting the job done:
("redux-form": "^7.2.3")
function mapStateToProps(state) {
    if (state.something) {
        return {
            something: state.abc
            initialValues: {
                "abc": state.some.value,
                "xyz": state.some.value,
            }
        }
    }
    else {
        return {
            something: state.abc
        }
    }
};

redux-form 7.0.4
It's very bad when your library return empty string for registered field without value and initial value!

I am sure they would be happy about receiving some help to improve it instead of a bitchy comment ;).

Ran into this issue using v7.3.0 and was banging my head on a wall for longer than I care to admit. I had enableReinitialize: true within the reduxForm options as well...
Turns out the issue was that I had another child component nested within the component tree that had its own reduxForm options and because it didn't have enableReinitialize: true. It appeared to be overwriting the functionality of the parent components reduxForm options
The fix was making sure the nested reduxForm options matched the parent component's reduxForm options

For those of you who are still facing this issue, here is a quick hack to get around this problem.
In your form component's componentDidMount lifecycle method do the following as shown
`
class MyForm extends React.Component {
componentDidMount() {
this.props.initialize(this.props.initialValues); // here add this line to initialize the form
}
render() {
....
}
}
`

componentDidUpdate() {
		if(this.props.match.params.id && !this.props.initialized)
			this.props.initialize(this.props.initialValues);
	}

This actually worked

I experienced the same issue with reduxForm 7.0.4, but it works in reduxForm 7.0.3
My node-js version is v8.9.0 fyi

Had the same problem in version 7.4.2. As in the above solutions, adding 'enableReinitialize: true' in reduxForm solved my problem.

Have the same problem in 7.4.2. Had to add enableReinitialize:true and
componentDidMount() {     this.props.initialize(this.props.initialValues);   }

I am sure they would be happy about getting some help to improve it instead of a bitchy comment ;).

Yeah, agreed, but on the other hand this is a serious bug, and it's been documented extensively in this thread, so the issue should have been reopened...
My way of dealing with this, with my own components that get wrapped with Field, is to check if input.value is falsy and do some something about it, e.g. return null.
@erikras
@gustavohenke
Any chance that this gets reopened and fixed at some point?

@codewaseem 's hack was needed in order to fix this. Version: 8.1.0

I use the same version 8.1.0. However, the bug is not fixed. textarea fields get empty value with server side rendering. This is seriously breaking my app.

Can anyone please re-open this issue because it is breaking SSR?

@kunokdev and @codewaseem , how do I fix this using a stateless component or functional component?

Thanks @codewaseem that works well.

With functional component it can be resolved with useEffect:
const MyForm = ({
  initialize,
  initialValues,
}) => {
  useEffect(() => {
    initialize(initialValues);
  }, [initialValues]);

  // ...
};

Still having this problem with redux-form 8.1.1 and react-redux 7.0.3.

The problem seems to be that validate is called before the component is rendered. Is that normal?

This hack works with redux-form 8.2.6  & react-redux 7.1.0

Is there any reason that this issue is closed?
Having initial values to not be available until 2nd render would make your code prone to null-pointer errors.

For those of you who are still facing this issue, here is a quick hack to get around this problem. In your form component's componentDidMount lifecycle method do the following as shown
class MyForm extends React.Component {
  componentDidMount() {
    this.props.initialize(this.props.initialValues); // here add this line to initialize the form
  }
  render() {
    ....
  }
}

Thank you! This problem still exists with react-redux 7.2.6 and redux-form 8.3.7.


UX of "Error reading build artifact"

After upgrading to Elm 0.15.1, I get this:
Error reading build artifact elm-stuff/build-artifacts/elm-lang/core/2.1.0/Array.elmi
    The file was generated by a previous build and may be outdated or corrupt.
    Please remove the file and try again.

Is there any reason not to structure elm-stuff like this?
elm-stuff/
  build-artifacts/
    0.15.0/
      NoRedInk/
      elm-lang/
      evancz/
    0.15.1/
      NoRedInk/
      elm-lang/
      evancz/

This seems like it would make it so I never had to see this error again. :smile:

Re: https://github.com/elm-lang/elm-compiler/issues/976#issuecomment-117375008
Either option would be preferable to the status quo. This suggestion was my first thought, but I actually have a use case for keeping both versions around.
I haven't upgraded our Rails integrations to use Elm 0.15.1 yet (blocked on https://github.com/kevva/elm-bin/issues/23), but I still wanted the improved error messages, so I ran the OS X installer in order to at least get them in elm-repl. However, since my project only gets one elm-stuff directory, I have to manually blow it away each time I switch from elm-repl to testing out the results in the browser.
It would be nice if the tool blew away the directory for me, but it would be nicer still if my elm-repl 0.15.1 and my build tools' elm-make 0.15.0 could coexist peacefully. :smiley:

That sounds like a good arguments for the versioned build-artifact directories.

Another motivating use case for changing the status quo: all of our CI builds will fail once we upgrade to 0.15.1, unless I explicitly add a build step to blow away elm-stuff first.

I can't imagine that the build artifacts are too massive, so versioned artifacts seems like a plausible solution for the foreseeable future. I imagine we'll get an issue in the future when someone with a big project is like "why do I keep all this extra old stuff?" but that seems like it's not the end of the world and should not block the "try two out at once" scenario when releases can be used together.

I think this is actually not too crazy a change. Anyone able to take a look?

FWIW, versioning by build system is a more functional (immutable) way to handle things. Wouldn't you hate for something to go wrong (network, corrupt file), and the build system for a functional language deleted all the files that you now can't get back?

Close in favor of https://github.com/elm-lang/elm-plans/issues/1 ?

Yep!

For the record, this is implemented now.


[oozie] OPSAPS-62127 Remove Oozie NameNode whitelist setting.

The whitelist of Oozie NameNodes did not include the NameNodes
of the base cluster when the Oozie service was installed onto a
compute cluster, which lead to an error when an Oozie job was
submitted. This issue has been fixed in CM, so it is safe to remove
this safety valve setting.

Waiting for bobcat review.


KAFKA-3567 Add --security-protocol option to console consumer and producer

Creating a new pull request, because original pull request #1408 has some issues.

@ijuma  This will be helpful when running with kerberos. At that time only security.protocol is needed. We can directly mention through command line option. Where as for other as you said, we need some more parameters. During other mechanisms like SSL, the user will have both options(command line and configuration file) for security protocol.
Ismael:
Thanks for the PR. Can you please explain how this helps? It seems to me that one always needs to provide additional configuration when using a security protocol that is not PLAINTEXT, so it seems easy enough to set the security protocol in the same config. But I may be missing something.

+1.

Updated the code so that user can give security-protocol option through config file / security-protocol option. Added a null check if it is not updated through configuration file, then take default/user provided through option. If user has given through security-protocol option also it will work fine, as the property will not be there it will return null and update the security.protcol to user value/default value.

Hi, the console producer has these options:
--producer-property <producer_prop> A mechanism to pass user-defined
properties in the form key=value to
the producer.
--producer.config  Producer config properties file. Note
that [producer-property] takes
precedence over this config.
the console consumer has only
--consumer.config  Consumer config properties file.
IMHO, it would make sense not to add a specific --security-protocol option to them,
but just add a
--consumer-property <consumer_prop>
to the console consumer

Hi Edoardo,
I will look in to that property, and see I can update that way to be more generic.
But this change has been done for this reason "This will be helpful when running with kerberos. At that time only security.protocol is needed. We can directly mention through command line option."

@bharatviswa504 I am not saying that the change isn't useful, but I don't think adding a command line option for every config property is a good idea. As the producer already has  CLI mechanism to pass in any property, the same should be done for the consumer

As you said @bharatviswa504, this is only useful with SASL_PLAINTEXT, Kerberos mechanism and the default values for all Kerberos settings. SSL, SASL_PLAINTEXT with the PLAIN mechanism and SASL_SSL need other configurations anyway and PLAINTEXT is the default. As such, the use case seems a bit narrow and I'm not sure it's worth adding a new command-line switch to every tool (which we would want to do to be consistent.

Hi @ijuma It will provide an additional option to users who are running through console tools like console producer and console consumer. Can you please let me know, how you want to proceed on this jira.

Hi @edoardocomar
Ya got your point. I have seen the property which you have specified. Which will give more benefit through which we can override any consumer config property. I have created a jira KAFKA-3748 and will contribute to this.

@harshach Can you provide your suggestions on this.

@edoardocomar With producer-property can we override multiple producer configurations. Because When I am trying like below
bin/kafka-console-producer.sh --broker-list <server:port> --topic mytopic --producer-property security.protocol=SASL_PLAINTEXT fetch.min.bytes=2
only security.protocol is getting overriding, where as fetch .min.bytes is still showing as default value 1.
Because when arguments are parsed and used options.valuesOf(producerPropertyOpt) is returning only one value because of space fetch.min.bytes is not considered here.
val extraProducerProps = CommandLineUtils.parseKeyValueArgs(options.valuesOf(producerPropertyOpt))
Is that it works for only one parameter or I am doing something not correctly? Can you please let me know your inputs.

have you tried
 --producer-property security.protocol=SASL_PLAINTEXT   --producer-property fetch.min.bytes=2
?

Ya it worked.
bin/kafka-console-consumer.sh  --new-consumer --zookeeper host:port --topic mytopic --from-beginning --bootstrap-server host:port --consumer-property security.protocol=SASL_PLAINTEXT --consumer.property fetch.min.bytes=2

@edoardocomar  @harshach  @ijuma I have updated the JIRA KAFKA-3748. Can you review it.

I think #1459 supersedes this one @bharatviswa504 right ?

@edoardocomar Yes, with this user can override any consumer property.

Closing since the problem was resolved by #1459.


Browser integration

This PR does the strictly necessary things to integrate the cvmfs-browser in an optional way, modifying settings.py.example accordingly. It also removes the dependency of South for Django 1.4 and updates that dependency to 1.8 since South is now integrated in Django.
Also it's noticeable that this dependency with the browser is absolutely optional, and actually disabled by default.
From the user perspective it would display the url in the basic description of the repository if enabled.

Offtopic, this is just a pre-visualization. I might change the final name of the cvmfs-browser, for example. I was ment to give an overview of the changes, which shouldn't be more than these.

I think this is ready to be reviewed @reneme


build: filter -z,nodelete on Windows

LLVM recently added a new ELF-only linker flag that gets exported.
Filter this from  the linker flags too.

Replace this paragraph with a description of your changes and rationale. Provide links to external references/discussions if appropriate.

Resolves SR-NNNN.

@swift-ci please test and merge


help of predict about camera parameter?

hello,i find we predict the camera parameter[z,tx,ty],and then we get the wold coordinate[tx,ty,2×focal_length/img_size×z],and we get this picture just use the world coordinate in render,

now,i want to use pytorch3d to replace the original renderer,but in pytorch3d,the setting in camera should know the R and T,but we only konw the world coordinate [tx,ty,2×focal_length/img_size×z],can you help me,how can i use pytorch3d to get the same img(There can be no background image)

Hi,
you may try:
R = torch.eye(3) and T = [tx,ty, 2×focal_length / (img_size×z)]


fix: Added client_authentication in ignore_changes

Description
When try to run terraform apply where TF code wasn't changed. Terraform run is failed
Motivation and Context
The change resolves the problem MSK Cluster TLS config.
Breaking Changes
No
How Has This Been Tested?

[x] I have updated at least one of the examples/* to demonstrate and validate my change(s)
[x] I have tested and validated these changes using one or more of the provided examples/* projects

[x] I have executed pre-commit run -a on my pull request

it does not resolve the problem, it merely ignores the problem. this needs to be fixed in the provder


Error when trying to join server

fabric-log.txt
I'm not very experienced in creating github issues, but an error is being thrown every time my friend tries to join my fabric server
I have attached the error log.
Thank you.

The plugin version 1.6.2 on 1.19


Does the side navigation in the context of a page feel interactive to a user?

Feature Request

[x] I’ve read and understood the Contributing guidelines and have done my best effort to follow them.
[x] I’ve read and agree to the Code of Conduct.
[x] I’ve searched for any related issues and avoided creating a duplicate issue.
[x] I've searched the community forums to check for related issues or feature requests

Is this feature request relating to an existing component? Please describe.

Component name: Side Nav
Component version: 4.0.0

I feel the links should be underlined. It was hard for me to tell that they were links until i hovered over them. Is there a reason for non underlined links?
Could be worth investigating pros and cons for both approaches.
With underlines:

Without underlines:

i think underlines with a slightly muted underline could work

We discussed this thoroughly when designing them. I recommend reading the thread on discourse and talking to treb. The reasons were the lines with borders where too much cognitive load for a user. The list pattern with borders and location on page we felt were enough.

I think we should leave this open for a while for community input. I will make a post in the community.
The discussion should be centred around:

Does the side navigation in context of a page look interactive?

How do you propose this works on mobile? It seems all of the DTA components have not been designed mobile first. Mobile seems to be an afterthought, which is unfortunate as we should all know by now, mobile web consumption outranks desktop year on year. The proposed nav and how it works on mobile is fairly lackluster and I dare say does not conform to the mental model people typically have for interacting with a mobile navigation.

@laurenburley Feel free to contribute with any ideas on how to make the mobile experience better. The team is always open to feedback.

Hi @laurenburley - thanks for taking the time to comment.

It seems all of the DTA components have not been designed mobile first.

Before being considered for inclusion in the Australian Government Design System, a component does need to pass a series of tests.  Responsiveness and suitability for mobile / small screen devices is one part of the test battery. Responsiveness also forms part of the Digital Service Standard.

mobile web consumption outranks desktop year on year.

No question.

The proposed nav and how it works on mobile is fairly lackluster

We try to ensure components' defaults are accessible, functional and unobtrusive. "Luster" wasn't something we've been prioritising ;) .

I dare say does not conform to the mental model people typically have

If you've got a specific improvement to suggest in the form of code, screenshots, screen captures, designs, research findings, prototypes, I'd encourage you to either add them to this GitHub ticket, raise a new ticket highlighting the specific issue you're having, or start a thread on the community forum.
Constructive criticism is always welcomed by the core team and the community. It helps us (and the system) improve.


DX: cleanup - remove redundant @param annotations

actually, those are not just redundant, they are simply wrong :D

those are wrong by being redundant ;)

Thank you @kubawerlos.


Cleaning up old issues

Your proably have seen - due to the huge list of notificatios from the git-tfs project - that I try to clean up old issues.
I was recently invited to the organization by @spraints, so now actually have the permissions to actually close issues myself.
As I am so to say new here in the project, I want to clarify somehow the working mode.
Should I close the obvious / very old ones issues myself? Is there anything to be aware of, special rules in this organization?

@pmiossec had contacted my privately, which I missed before writing this issue.
I will continue going through the old issues and close them myself if they don't make any sense


unsupported parameter for module: host_groups

Strangely enough but task Create hostgroups fails on me with:
failed: [gg-tool24 -> <IP_ADDRESS>] => {"failed": true}
msg: unsupported parameter for module: host_groups

FATAL: all hosts have already failed -- aborting

installed from galaxy
ansible-galaxy install dj-wasabi.zabbix-agent -p roles/
with vars like those:
# Zabbix API stuff
zabbix_api_use: True
zabbix_url: http://myzabbix-host/zabbix
zabbix_api_user: myuser
zabbix_api_pass: mypassword
zabbix_create_host: true
zabbix_host_groups:
  - Linux servers

$ dpkg -l | grep zabbix | awk '{print $2 " "$3}'
zabbix-agent 1:2.0.4+dfsg-1~exp0
zabbix-frontend-php 1:2.0.4+dfsg-1~exp0
zabbix-server-mysql 1:2.0.4+dfsg-1~exp0

Hi kostyrevaa,
Could you please test it again? (With source from github, not galaxy?) It seems the library files had an mission .py extension.

Yeah! That's was it! It works from github
Thanks!

Hmmm
after awhile I've got the very same error

Am I the only one experiencing this problem?

I am, same problem... Even after cloning the git repo.
TASK: [ansible-zabbix-agent | Create hostgroups] ******************************
failed: [test-machine -> <IP_ADDRESS>] => {"failed": true}
msg: unsupported parameter for module: host_groups
FATAL: all hosts have already failed -- aborting

@dj-wasabi any thoughts on this one?

Hi all,
I've been thinking about this one.
I placed the python files into the library folder for those users which are using Ansible version 1.8.x or lower. As of Ansible 1.8, those modules are part of the Ansible release. (http://docs.ansible.com/ansible/list_of_monitoring_modules.html)
I can update the 'min_ansible_version' to 1.8 and remove the files from this repository, or I could try to find out why this is happening.
I prefer the first one, not just because it saves time for me ;-), but also the modules in Ansible are more up2date compared with the one in my repository.
Do you guys have an preference?
Kind regards,
Werner

I'd go with the first option too
'cause even on CentOS6 you couldn't install ansible lower than 1.9.2 (epel)
So why the hell keep those in role :)

I'm using latest version of Ansible, so eiter is fine.

But I do not.
I use 1.9.2

Hi All,
I've removed the zabbix_group from the module, we use this one from the ansible library. The other 2 are still in this module. I do thought these were also added with the 1.8.0 release, but it seems they are in the 2.0.0 release. (Like @kostyrevaa mentions).
I pushed the fix some moments ago to this repository. When I receive positive comments about this, I'll create an tag and the release will be available on Galaxy too.

I have problem too with this host_group
failed: [92.xx.xx.xx -> <IP_ADDRESS>] => {"failed": true}
msg: unsupported parameter for module: host_group

I'm closing it 'cause it's been working for me for quite a long time since @dj-wasabi removed zabbix_group. And I've been adding stuff to zabbix every day

Hi @kostyrevaa
Thanks for the confirmation!


[Do Not Merge] DS-803 Wrapper Object Deprecation

Jira
https://pegadigitalit.atlassian.net/browse/DS-803
Summary
The object o-bolt-wrapper is deprecated.
Details

Pulled the DS-811 with the new wrapper element.
All instances of o-bolt-wrapper were replaced with the e-bolt-wrapper element.

How to test
Check if there are no instances of the o-bolt-wrapper object and the new wrapper element fulfills its function.
Release notes
The object o-bolt-wrapper is deprecated, please use the e-bolt-wrapper element.

@danielamorse Edited title of this PR with [Do Not Merge]


enable-migrations causes "the project 'project' failed to build.

Describe what is not working as expected.
The command "enable-migrations"  according to many tutorial sessions, this one included, always produces the same error result The project 'MigrationsDemo' failed to build. (or CodeFirstDemo from Udemy - another example  https://bah.udemy.com/entity-framework-tutorial/learn/lecture/3243042#overview)
There is some indication after googling - that the migrations are enabled automatically when the job runs the first time and sets up a database in the "(localdb)\MsSqlLocalDb"  (also localdb? poorly documented here)
WHEN running the "enable-migrations" command after the database is setup, there is a message about scaffolded migration.  (Didn't get that far).
If you are seeing an exception, include the full exceptions details (message and stack trace).
Exception message:
The project 'MigrationsDemo' failed to build.

_Detected database created with a database initializer. Scaffolded migration '201907172347434_InitialCreate' corresponding to existing database. To use an automatic migration instead, delete the Migrations folder and re-run Enable-Migrations specifying the -EnableAutomaticMigrations parameter._

Stack trace:

Steps to reproduce
Include a complete code listing (or project/solution) that we can run to reproduce the issue.
I did not vary from the script above.  I am running SSMS 2017 with SQL Server 2017 Developer and Visual Studio 2017 Professional.
Create Console App (.NET Framework) called MigrationsDemo
Install-Package EntityFramework from Package Manager Console
Add Class named Model with code from link
Update Program.cs with code from link
Run Package and wait for console to show "Another Blog" (press any key to exit)
Run the Enable-Migrations command in Package Manager Console
***What may have fixed this for me - as it works now - was opening the (localdb)\MsSqlLocalDB.   Once that was created, and opened for a first time with SSMS, the enable-migrations command began to run.   If I am correct, the part that is missing is the "open the database" portion.  Or perhaps another command that would ensure the data is committed to this database called (localdb)\MsSqlLocalDB
Further technical details
EF version: (found in project.csproj or packages.config is 6.2.0)
Database Provider: (e.g. EntityFramework.SqlServer) presumably the one in the command above which is System.Data.SqlClient.
Operating system: (e.g. Windows 10)
IDE: (e.g. Visual Studio 2017 15.6)

This my no longer be a problem in 6.3.0. I removed the code that builds the project twice during Enable-Migrations

Thank you bricelam


Service Issue

Isolated Service not bound

Can you elaborate on the changes you did to the project?

Feel free to reopen when you have sufficient info

Feel free to reopen when you have sufficient info


Direct round trips

Signed-off-by: Gabriel Indik<EMAIL_ADDRESS>

Changes in this PR:
If the sender and recipient ID match (round trip) no mTLS communication is established. Instead DX will:

In the case of messages, directly place the message in the queue and emit the corresponding events
In the case of blob transfers, copy the blob to the "received" folder location (which may contain the destination) and emit the corresponding events.


Allow BCCSP config to be set using environment variables

Type of change

Bug fix

Related issues
FAB-17969

This isn't pretty but it at least works for the peer. I tried the orderer environment variables as well for the new test but those don't work currently either...

@jyellick removed the overrides for hardcoded SW values

This change had some a pretty well hidden side affect. It pushed PKCS11 code outside of the pkcs11 build tag gating, which now pulls the pkcs11 library in, even when you aren't using pkcs11 factories. This prevents cross-compilation of fabric from one platform to another now unless you have a C cross-platform compiler installed and pass the proper CGO options when building since the miekg package uses CGO

@btl5037 what do you suggest? reverting?

Resolved in https://github.com/hyperledger/fabric/pull/3697


[evaluation] Add support for using evaluate() with evaluators that have missing inputs

Description
Cherry-pick of #38276
All SDK Contribution checklist:

[ ] The pull request does not introduce [breaking changes]
[ ] CHANGELOG is updated for new features, bug fixes or other significant changes.
[ ] I have read the contribution guidelines.

General Guidelines and Best Practices

[ ] Title of the pull request is clear and informative.
[ ] There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For more information on cleaning up the commits in your PR, see this page.

Testing Guidelines

[ ] Pull request includes test coverage for the included changes.

API change check
API changes are not detected in this pull request.


bug: Small nerd font icons in alpha

Did you check docs and existing issues?

[X] I have read all the LazyVim docs
[X] I have searched the existing issues of LazyVim
[X] I have searched the exsiting issues of plugins related to this issue

Neovim version (nvim -v)
0.8.3
Operating system/version
Fedora 37
Describe the bug
The new nerd font icons replacing the obsolete ones look too small. My term is kitty and the font is JetBrains Mono + symbol_map to Symbols Nerd Font Mono.

Steps To Reproduce
Pull the latest version of LazyVim and launch nvim.
Expected Behavior
All icons picked should look consistent in size.
Repro
No response

Replaced the session icon, but couldn't find a larger sleep symbol

So sad that nf-mdi-sleep icon is obsolete. I actually had no issue with it even for CJK fonts.

Yeah, me neither, but I assume it will be removed at some point...


V3.5.3 failed to @extend

I'm getting this error with the last version:
Use "@extend .ui-header !optional" if the extend should be able to fail.
at options.error (/Users/esbanarango/myProject/node_modules/ember-cli-sass/node_modules/broccoli-sass-source-maps/node_modules/node-sass/lib/index.js:271:32)

Prior to 3.5.0-beta.1, extending a css selector that didn't exist until runtime was possible. 3.5.0-beta.1 through 3.5.3 does not allow this. Is this a bug, or is !optional now required?

Looks like it's probably related to https://github.com/sass/libsass/issues/1670 @esbanarango, we may need to open the issue over there. Doesn't seem like a css class should be considered an "undefined placeholder"

You know.. I'm going to investigate a little further, but I'm thinking this is actually a "feature." I think it's catching a "bug" that we didn't know existed. Will report back.

@sethbrasile I think your spot on with that assessment ;)

@sethbrasile This is a feature, I agree. but it has broken a lot of my builds. Going from silently failing to now throwing errors should've warranted a major version bump IMO.

 But agree nonetheless, should have been a major version.

I can understand your point somehow, please also see my other [comments] 1.
node-sass was always clear that it will not follow semver if libsass changes in a way that is more in line with official ruby sass (and this includes errors obviously). So that's the contract. You can still pin node-sass to a specific version if you don't have the time to fix you code, which should be quite trivial. Silently ignoring stuff is really uncool for people that convert from ruby sass to libsass. That's all I have to say, as I'm not a maintainer of node-sass, so technically that's not even any of my business.

Sorry @mgreter 😢
Totally understand, broken builds are just always such a surprise 😱
I think what we're experiencing here is just kind of "par for the course" with the current package eco-system, dependencies of dependencies of dependencies and all that 😃

This project is an implementation of the Sass language. Our goal is to be 100% compatible with Sass. These issues you mention are a result of invalid Sass. Node Sass has no way to know that these breakages because we assume valid Sass is being compiled. This is no different to depending on an undocumented API. For that reason we do not consider these breaking changes.
If valid Sass started breaking we would consider that a breaking change. We don't claim responsibility for bugs in the Sass code being compiled.
If you wish to suggest features of file bugs in the Sass language please open an issue with Sass - https://github.com/sass/sass
In closing if your code does not compile with the official Sass project you should not expect it to compile with Node Sass.


Correct whitespace issues

This commit was generated using
coala --files=\*\*/\*.py --bears=SpaceConsistencyBear -S use_spaces=True and strips trailing whitespaces and replaces tabs with four spaces.
The coala tool can be retrieved from
https://github.com/coala-analyzer/coala/

:+1: Looks good to me. It only touches insignificant whitespace.

Agreed and it also converts a few tabs to spaces. That sold it to me!

So it's in! Thanks @sils1297  for taking the time to create that patch.

No problem!
2015-06-11 15:13 GMT+02:00 Gregor Müllegger<EMAIL_ADDRESS>
So it's in! Thanks @sils1297 https://github.com/sils1297 for taking the
time to create that patch.
—
Reply to this email directly or view it on GitHub
https://github.com/rtfd/readthedocs.org/pull/1331#issuecomment-111128744
.

By the way you can use coala easily to ensure no whitespace problems are introduced via travis.


display issue list on NewspaperTitle show page

Descriptive Summary
We want users to be able to browse a chronological list of available issues for any given newspaper title. The most obvious place for this list would be on the NewspaperTitle show page. The issue display will give users a quick overview of what's available, and provide a link directly to each available issue.
Background
This functionality is available in several other systems, we are basically trying to emulate what they do.

Chronicling America: calendar view
Welsh Newspapers Online:

calendar view
list view

The calendar view was specifically requested by several institutions during our requirements gathering phase.
Expected Behavior
As a non-admin user
When I am on the show page for a Newspaper Title
I should see a calendar-based display of available issues for the title
And I should be able to easily browse by year
And when I click on a date with an available issue
It should take me to the show page for that issue.
This ticket will be complete when:
Functionality in user story above is implemented.

Calendar view implemented via #137.


Swap in pmorie/go-open-service-broker-client

needs to be rebased before travis will pick it up.

@MHBauer that is a terrible UX

This does seem to fix https://github.com/kubernetes-incubator/service-catalog/issues/953

@jwforres that's awesome. Any idea why it fixes?
Also, @pmorie can you put Closes #953 in the OP so that issue is closed when this PR is merged?

Hrm, I'm not sure that I think this should do anything to meaningfully change #953

I think this PR is as ready as it's going to get.


SW-6187 Add overlapping plots to data model, API

Changing the plot sizes for future observation of a planting site that already has
observation results will mean that the new-sized plots will partially overlap the
old-sized ones. We want users to be able to navigate back to the old-sized plots
to see how the observation data has changed over time.
Add the concept of overlapping plots to the system. A newer plot may overlap with
some number of older plots, and may in turn be overlapped by some number of even
newer plots. Include the overlapping plot IDs in the plot-level observation results.
Currently, since plot size isn't variable yet, the list of overlapping plots will
always be empty.

#2531  👈
main

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @sgrimm and the rest of your teammates on  Graphite

Merge activity

Oct 24, 4:32 PM EDT: A user started a stack merge that includes this pull request via Graphite.


Makefile: Enable debug logging for worker.py.

We sporadically see that the worker.py test times out on Travis CI after 10 minutes. Enabling logging will give us better visibility to debug the problem.

LGTM


Improvements to KituraSample

Implement a few small improvements to the KituraSample app:

Add a customised 404 (Not Found) handler

Remove the / handler, to show the Kitura landing page

Verified.


trivial true/false predicates

These can be useful for testing or if, say, you want to tt_replace every token.

I added 286bd4d72d55871fed31adf096c2fd42e01fe992 to export these two new macros and released version 1.0.1.


Dependents section added

This ticket
Meant to look like this:
http://ministryofjustice.github.io/fr-prototypes/public/journey-7/children.html
Adds the 'children' page.

Looks good, merge on green.


Update CorelightForcedExternalOutboundSMB.yaml

Eliminate false positives in Corelight - Forced External Outbound SMB rule
Fixes Azure/Azure-Sentinel#2445
Proposed Changes

Change the 'or' to an 'and' in the rule logic

@v-ampami and @v-maudan - This looks like it is the correct change, but since you both worked on the original Solution would like your review.


Cut, Copy, Paste

Hi,
First, I really like this plugin. Something I would like to have in addition is some basic cut/copy/paste functionality:

while in FileBrowser, mark some files
hit ctrl-x/ command-x, the files are moved to Trash and the resulting filenames copied to clipboard
in the same FileBrowser or in another one, hit ctrl-v / command-v and the files are moved from the trash to the current directory of the file/directory selected
ctrl-c / command-c would simply copy the filenames

seems easy enough to integrate, let me know if you want to add the functionality or would like somebody to implement it via a pull-request.

Sure, this feature is desirable and planned.
I just want to warn all interested ppl that it is not that easy as may seem. Imagine user try to transfer several gigabytes between separate partitions—so obviously you would do it in separate thread, which is not a problem, but how about display progress status?
Not mention that for sure there are some non-obvious potential issues.
And just in case if you’re serious about trash, there is no need to send to trash (esp. taking into account that the question is how to restore from trash on different OSs), but simply put filenames in some setting, e.g. 'to_move':[list of full paths] or something like this.

:+1: This would be a great feature!

Would be nice to call system utility, like this.
I could do it and try to make something like this for Linux (Ubuntu at least), but no OSX.
@aziz what you think? could you make it for OSX?

I think it's a great idea. let's experiment and in the beginning we can keep it as a Windows Only feature but ultimately can be shipped to other OSes.
I like things to be small and maintainable and this plugin is not a good example. I'm thinking about breaking extra features into smaller plugins. This one could be a candidate of for a plugin.

I’m playing with SHFileOperationW right now, and I just love it—how about copy directory into itself? Who would even think about it implementing with shutil or whatever? But no problem SHFileOperationW says ‘bro, you crazy: skip or cancel’ :+1: (not mention free renaming, duplication and all other features, and all these are in 30 lines of Python code).
I’ll test further and look into Linux options (Gnome, KDE) in next couple days.

https://github.com/aziz/SublimeFileBrowser/compare/x-cut-copy-paste
For Gnome I found this command line to use Nautilus/Files:
qdbus org.gnome.Nautilus /org/gnome/Nautilus org.gnome.Nautilus.FileOperations.CopyFile "file:///source/directory" "*" "file:///destination/directory" ""

But there is no move method, and it seems they (Linux-world folks in general) change APIs so often in last several years that I think it is not worth an effort.

Sorry for delay, please test that branch x-cut-copy-paste & let me know about any problems.
If no feedback, release this weekend.

Intresting that on Windows system dialog gets the focus on ST2, but not on ST3 (i.e. opens in the background) — I think this is because ST3 plugins are in separate process.
There is SetWindowPos function, but I don’t understand how to use it in our case — any help would be welcomed.
Any way I’ll release it today (at evening, now is a midday here), since even if dialog is in background, then dock icon will blink so user’ll see it eventually.

Hi,
this is fantastic! I have been on vacation until yesterday, so I could not test earlier. I'm testing now using current master under Windows/ST3. No issues so far. Thanks a lot, this will make my way of working so much easier for many workflows, especially since I can use it under Win and Mac (which I will test this evening).


Doc for changing from mqtt server to serial connection research Project 1

Added file to facilitate ble connectivity

Made necessary changes mate!


wiki: CodeReviewComments change

The code review comments state: "Avoid renaming imports except to avoid a name collision; good package names should not require renaming."  However, a pattern I am used to is to rename a protobuf import "pb" or, if there are many protobuf imports, "somethingpb" where "something" is usually pretty short.
Should there be a specific acknowledgement of this here?

@andybons @dmitshur

I agree it's a convention. The question is does every convention need to be listed in this wiki page.

I don’t think this convention needs to be specifically called out, but perhaps @neild has an opinion.

The justification for the comment already says “good package names should not require renaming”, so it already mostly does not apply to package names that are not “good” (such as those imposed by dependencies translated from non-native-Go sources).

Per discussion with @golang/proposal-review, seems fine to add a note about protobufs.
What's the proposed wording?

I think protobuf style has generally shifted to versioned packages (.v1, .v2, etc.) and renaming to pb is less common now, and untenable when you need more than one proto package.


Make osmnx samples usable with Binder

Possible fix for https://github.com/gboeing/osmnx/issues/182
The "Binder" badge in readme should be adjusted for the main repo URL.

Funny, I was about to submit this PR. Shouldn't the extra required packages (e.g. matplotlib, pandas) be added to the Binder dependencies as well?

I assume these come via dependency tree anyway.

I just tested in Binder and the necessary dependencies appear to come via the dependency tree, as you assumed. The advantage of explicitly stating the dependencies in the environment.yml may be that the more standard libraries will come via the default conda channel instead of conda-forge, but that's not a huge deal I think.

@jaakla @rhiever thanks guys!


Teach users to install NApps remotely only

Update documentation to fix issue kytos/kytos#944

Please make sure there's a section teaching users to install locally with python setup.py develop. We can create another issue for this.


WGSL material example crash

Bevy version
0.12.1
[Optional] Relevant system information

cargo 1.74.0-nightly (2fc85d15a 2023-09-09)
Windows 10

`AdapterInfo { name: "AMD Radeon(TM) Graphics", vendor: 4098, device: 5686, device_type: IntegratedGpu, driver: "AMD proprietary driver", driver_info: "<IP_ADDRESS>", backend: Vulkan }`

What you did
I have copied the material wgsl shader example, including the shader and rust code, and pasted them without changing anything.
What went wrong
I was expecting to observe working shader, but I've got Validation Error.
Caused by:
    In Device::create_render_pipeline
      note: label = `alpha_blend_mesh_pipeline`
    Error matching ShaderStages(FRAGMENT) shader requirements against the pipeline
    Shader global ResourceBinding { group: 2, binding: 2 } is not available in the layout pipeline layout
    Binding is missing from the pipeline layout

Additional information
I have also copied some other examples, like animated shader, and it was working properly, so I think, the problem is in the material wgsl shader example on bevy website.

I have observed the same crash in the custom vertex attribute example.
The problem is in the index of the group in the .wgsl file. I had to replace group index from 2 to 0.
@group(0) @binding(0) var<uniform> material: CustomMaterial;

For the wgsl material example, I had to replace group index from 2 to 1.
@group(1) @binding(0) var<uniform> material_color: vec4<f32>;
@group(1) @binding(1) var material_color_texture: texture_2d<f32>;
@group(1) @binding(2) var material_color_sampler: sampler;

The example from the main branch on git are updated with the in-development version of Bevy.
For the 0.12.1 version, you should copy from the release-0.12.1 branch: https://github.com/bevyengine/bevy/blob/release-0.12.1/assets/shaders/custom_material.wgsl

Got it, thank you!


bigquery: let users contruct TableResult for testing

Fixes #3228.
@tswast I'm comfortable making this public, but please let me know if you want to @BetaApi it or something.

I guess @VisibleForTesting is a Guava-ism, which I've heard we want to be careful about exposing those types in interfaces.

Our equivalent for @VisibleForTesting is @InternalApi (add a text note in the annotation, "Exposed for testing")

@garrettjonesgoogle PTAL

Thanks a lot a for making TableResult public