[KED-2385] Refactor row toggle/label CSS, and fix row hover icon bug

Description

Instead of having just the _row.scss file and then filter overrides in _filter.scss, instead create one file for all the text label scss (both toggle/filter kinds), and one for the toggle-icon scss (both kinds)
Fix toggle-icon--kind-filter parent row-hover bug: The toggle-all icon would decrease in opacity on row hover.
Rename node-list row toggle --kind-toggle to --kind-element to make the distinction between the two elements a bit more clear. We can rename them again later if necessary but I think this makes things a lot easier to understand.
Refactor node-list group creation selector to improve readability

Development notes
I discussed the naming of the two node-list row item kinds with @bru5 at length while working on this PR. We want to strike a balance between intuitiveness and extensibility, which is why we've avoided being too specific in the names of the two kinds (e.g. calling filters 'category', which might not work with future usages, or calling them 'blue-dot' and 'eye-icon', which is too dependent on the presentation).
QA notes
Please double-check the node-list hover/focus/selection states and see that nothing has changed (except for the blue dot checked parent row-hover state, which has been fixed).
Checklist

[ ] Read the contributing guidelines
[ ] Opened this PR as a 'Draft Pull Request' if it is work-in-progress
[ ] Updated the documentation to reflect the code changes
[ ] Added new entries to the RELEASE.md file
[ ] Added tests to cover my changes

Legal notice

[x] I acknowledge and agree that, by checking this box and clicking "Submit Pull Request":

I submit this contribution under the Apache 2.0 license and represent that I am entitled to do so on behalf of myself, my employer, or relevant third parties, as applicable.

I certify that (a) this contribution is my original creation and / or (b) to the extent it is not my original creation, I am authorised to submit this contribution on behalf of the original creator(s) or their licensees.

I certify that the use of this contribution as authorised by the Apache 2.0 license does not violate the intellectual property rights of anyone else.

Thanks for the refactor, code looks good to me 👍
One thing to confirm - I notice that you mentioned that the 'toggle-all' icon would decrease in opacity on hover, however it looks like it is currently set at opacity 0 and only shows up on hover of the toggle button ( see below), which is very different from the existing behaviour of the filter all row on hover.

This is what we previously have:

Is this new change something intended, as it seems to deviate from the behaviour of the toggle all icon for the eye ( where the 'toggle-all' eye icon would still show up on toggle of the entire row, and only increase in opacity on hover of the toggle button?) @GabrielComymQB

Thanks for the refactor, code looks good to me 👍
One thing to confirm - I notice that you mentioned that the 'toggle-all' icon would decrease in opacity on hover, however it looks like it is currently set at opacity 0 and only shows up on hover of the toggle button ( see below), which is very different from the existing behaviour of the filter all row on hover.

This is what we previously have:

Is this new change something intended, as it seems to deviate from the behaviour of the toggle all icon for the eye ( where the 'toggle-all' eye icon would still show up on toggle of the entire row, and only increase in opacity on hover of the toggle button?) @GabrielComymQB

@studioswong Good catch, thanks! 🙌
Fixed 😅

@studioswong Good catch, thanks! 🙌
Fixed 😅


Update packages and translations

/botio test

/botio-linux unittest

Great, there's now intermittent unittest failures only on the Linux bot; unfortunately I cannot really debug that locally...

Thanks!
Since the intermittent failures are getting a bit out of hand, I'm at least going to make a tracking issue for it.


Docker compose

This branch add a simplistic docker-compose config to allow the user to quickly get started with a hdfs cluster. This branch required the pull request #25 to be merge before.
resolve #24

LGTM


Add mayLaunchUrl and warmup methods in Android

Thanks for bringing these up.
At first glance, they seem easy to implement, so they will most likely make it into the next update for both v2 and v3.
Resources for later

CustomTabsSession - mayLaunchUrl
CustomTabsClient - warmup

@LuckyLuke19 could try out the latest release candidate with the two new methods?
@matt-block/react-native-in-app-browser@next

@matei-radu It works, thanks!


REPL: https://svelte.dev/repl/c3a6591167c34bb48d28966fe83b22f2?version=3.59.1
If you click on the button "Toggle Flatpickr" the Flatpickr renders and works with date:

But if you use the mobile version of the browser and click the button two times to re-render it, it throws!

Uncaught (in promise) TypeError: Cannot set properties of undefined (setting 'tabIndex')
    at buildMonthSwitch (eval at handle_message (about:srcdoc:14:8), <anonymous>:1723:51)
    at jumpToDate (eval at handle_message (about:srcdoc:14:8), <anonymous>:1484:17)
    at Object.setDate (eval at handle_message (about:srcdoc:14:8), <anonymous>:2823:13)
    at $$self.$$.update (eval at handle_message (about:srcdoc:14:8), <anonymous>:3457:13)
    at update (eval at handle_message (about:srcdoc:14:8), <anonymous>:335:16)
    at flush (eval at handle_message (about:srcdoc:14:8), <anonymous>:299:21)

This happens in mobile only!
Why? What's the problem?

Did you ever figure this out? Svelte Flatpickr on Sveltekit v2 doesn't work on mobile at all


CSF3 cards

Closes
CSF3 conversion for Cards and Cardview. Move stories that are purely visual to the chromatic stories since we had very few in chromatic and we had many in our stories, yet they didn't have any interactions to test, only the visual state.
✅ Pull Request Checklist:

[ ] Included link to corresponding React Spectrum GitHub Issue.
[ ] Added/updated unit tests and storybook for this change (for new code or code which already has tests).
[ ] Filled out test instructions.
[ ] Updated documentation (if it already exists for this component).
[ ] Looked at the Accessibility Practices for this feature - Aria Practices

📝 Test Instructions:

🧢 Your Project:

RTL is later, right?


Add web-terminal for karmada-dashboard

What would you like to be added:
Why is this needed:

Hello, @warjiang I want to work on this issue. If so, i have a question, for this issue are you going to add a new section in overview or Create a new section in nevbar? I mean I have to create a new route like /web-terminal right ? Please guide me.


Possibility to explicitely set connections to return ANSI bytestrings in...

Added Possibility to explicitely set connections to return ANSI bytestrings in Py3 using unicode_results = False (it will default to true in Py3). This allows use of bytearrays in case of databases that are not properly unicode encoded.
This patch does add functionality but does not affect any other code paths so is fully compatible. Arguably it makes functioning of the module more congruent with the parameters you can pass. More important It might help adoption of py3 by facilitating certain py2-to-py3 legacy issues.

I'm not sure I see the reasoning here.  In Python 3 all strings are Unicode - why wouldn't you want strings in Unicode even if the DB isn't set up right?  Python's bytes is like a binary encoding.
I could certainly see having per-query encodings for certain columns if the DB is all ASCII and you want to treat a couple as binary.
Can you explain some more?

Mike,
In certain cases one can have different encodings on a per-record base.
Consider the case of a CMS with these columns:
RECID bigint, CONTENT varchar, LANGUAGEID tinyint
where each record might have a different encoding (for the chinese page,
korean page etc). With a CMS for webpages in different
countries/encodings you can easily end up there. Of course, fixing the
db content would be the ideal solution but

other software depends on this data too
I'd probably like to fix all that content to the proper encodings
using a tool like Python, in which case I'd need bytearray retrieval :)
SQL Server has varchar and nvarchar. I think almost by definition,
what's in varchar is not mandatory unicode as opposed to nvarchar

Basically I think there should be the option to use a database 'garbage
in garbage out'. Especially when realising that won't break anything:
all defaults remain unicode and if you don't deliberately light the
match, you can't burn your fingers.
I like your idea about per-column indicators although that might bloat
the library.
In my personal case I've even got to deal with stuff in (binary)
encrypted or compressed format due to field width limitations in the db
or encryption requirements not natively supported by the db. That means
unpacking in the client (python). I would go through the effort of
cleaning it all up if the fix in pyODBC wasn't so trivial.
Thanks.
Robert
On 4/30/2015 4:05 AM, Michael Kleehammer wrote:

I'm not sure I see the reasoning here. In Python 3 all strings are
Unicode - why wouldn't you want strings in Unicode even if the DB
isn't set up right? Python's bytes is like a binary encoding.
I could certainly see having per-query encodings for certain columns
if the DB is all ASCII and you want to treat a couple as binary.
Can you explain some more?
—
Reply to this email directly or view it on GitHub
https://github.com/mkleehammer/pyodbc/pull/30#issuecomment-97634226.

Fair enough.
I'm going to need to manually work this one.  First, I manually removed the unicode_results from Python 3 since it wasn't needed.  Second, I need to add unit tests to a couple of databases.

While working on this it occurred to me you might already have the tools you need.  I have already implemented per-type converters.  Can you use something like this?
    def test_varchar_converter(self):
        """
        Ensure a conversion function can be used to force CHAR and VARCHAR columns
        to be returned as bytes instead of Unicode strings.
        """
        def tobyte(val):
            if val is None:
                return None
            return val.encode('ascii')

        self.cnxn.add_output_converter(pyodbc.SQL_CHAR, tobyte)
        self.cnxn.add_output_converter(pyodbc.SQL_VARCHAR, tobyte)
        self.cnxn.add_output_converter(pyodbc.SQL_LONGVARCHAR, tobyte)

        value = b'testing'
        self.cursor.execute("create table t1(s varchar(20))")
        self.cursor.execute("insert into t1 values (?)", value)
        v = self.cursor.execute("select * from t1").fetchone()[0]
        self.assertEqual(type(v), bytes)
        self.assertEqual(v, value)

The data is converted to Unicode, regardless of the data type, and passed to the converter.  (I couldn't come up with a way to pass "raw" data in Python.  Passing a 4-byte array instead of a "long" didn't seem like the right way to go.)  I'm open to suggestions on improving the converters too.

Mike,
Actually I'm not using the output converters but I understand the mechanism.
The problem is that the actual content isn't correct unicode to start
with, so interpreting it as unicode, then trying to encoding it to
another charset doesn't make sense.
If any converter would be used, its purpose would be to assemble correct
unicode from whatever comes in, instead of creating bytes from what is
supposedly unicode.
btw, our current mail exchange, is that as a reaction to the request I
submitted quite a while ago or to the patch I submitted on github? I've
already implemented the change needed and created a pull request for it.
Robert
On 4/30/2015 2:54 PM, Michael Kleehammer wrote:

While working on this it occurred to me you might already have the
tools you need. I have already implemented per-type converters. Can
you use something like this?
 def  test_varchar_converter(self):
     """
     Ensure a conversion function can be used to force CHAR and VARCHAR columns
     to be returned as bytes instead of Unicode strings.
     """
     def  tobyte(val):
         if  valis  None:
             return  None
         return  val.encode('ascii')

     self.cnxn.add_output_converter(pyodbc.SQL_CHAR, tobyte)
     self.cnxn.add_output_converter(pyodbc.SQL_VARCHAR, tobyte)
     self.cnxn.add_output_converter(pyodbc.SQL_LONGVARCHAR, tobyte)

     value=  b'testing'
     self.cursor.execute("create table t1(s varchar(20))")
     self.cursor.execute("insert into t1 values (?)", value)
     v=  self.cursor.execute("select * from t1").fetchone()[0]
     self.assertEqual(type(v),bytes)
     self.assertEqual(v, value)

The data is converted to Unicode, regardless of the data type, and
passed to the converter. (I couldn't come up with a way to pass "raw"
data in Python. Passing a 4-byte array instead of a "long" didn't seem
like the right way to go.) I'm open to suggestions on improving the
converters too.
—
Reply to this email directly or view it on GitHub
https://github.com/mkleehammer/pyodbc/pull/30#issuecomment-97763732.

Both, but I'd rather use converters if they would do the trick.  I'm considering making the converter parameter bytes or bytearray for varchar,, int, etc.  Would that help?

Mike,
That would be perfect. Wouldn't that break existing functionality?
BTW I'd be happy to make a financial contribution for this.
Robert
On 4/30/2015 3:53 PM, Michael Kleehammer wrote:

Both, but I'd rather use converters if they would do the trick. I'm
considering making the converter parameter |bytes| or |bytearray| for
varchar,, int, etc. Would that help?
—
Reply to this email directly or view it on GitHub
https://github.com/mkleehammer/pyodbc/pull/30#issuecomment-97801813.

Michael,
Actually I was thinking.
When you just pass in the to-be-converted fields you have no context of
the rest of the row, right? So for this table setup to work:
Content (Varchar)    LanguageISO(char(5))
ABË                  En-en
ABË                  Euc-Kr
one would need, while processing the Content field, access to the
LanguageID field.
Robert
On 4/30/2015 3:53 PM, Michael Kleehammer wrote:

Both, but I'd rather use converters if they would do the trick. I'm
considering making the converter parameter |bytes| or |bytearray| for
varchar,, int, etc. Would that help?
—
Reply to this email directly or view it on GitHub
https://github.com/mkleehammer/pyodbc/pull/30#issuecomment-97801813.

It would break, but I would actually be willing to do that and call it 3.1 or 4.0.  I've been uncomfortable with passing Unicode to them.
Until then, I'm going to merge your patch, but I'll need to hand touch it up because I removed unicode_results from Python 3 with an #ifdef, etc.
Also, I thought I asked this earlier but I guess I deleted it.  Currently the patch you provided would also affect GUIDs and XML.  I really think XML should remain Unicode since most people would expect it.  I don't have an opinion on GUIDs, but I think the option makes more sense if is is simply "the flag causes CHAR and VARCHAR to be returned as bytes".  So I would want to make a small change for that.
Also, is "unicode_results" really right?  Perhaps a new parameter name is better such as "char_as_bytes"?  It is a bit more work and makes the C code a little messier, but I think it would be better to have a more self-describing parameter.
Thoughts?

And I forgot to answer the last question - I don't pass in context since I'm calling the converter as I process each column.  It would be possible to do so afterwards but wouldn't be as efficient.  If more than one column need conversion, you would not know in each converter if the other column had already been converted or not.  (Not important in your example, but something that could trip someone up.)
Which is why I'm leaning towards the flag now.

I think unicode_results is understandable: it instructs pyODBC to return
everything as unicode results which is an understandable, logical and
expectable process, especially in python2.x.
For python3.x it's an understandable flag because, although it should
default to true, setting it to false clearly indicates that the library
will not return unicode anymore. It's about as descriptive and
appropriate as it gets. My personal opinion is tweaking anything more in
names would complicate stuff, you'd get discussions about the
unicode_results flag as opposed to the char_as_bytes flags and people
would have whole philosophies about what's the difference.
As for your GUID and XML types: I expect there would never be an
incompatabilty issue with GUID's because they are all convertable to
ascii- and back no matter how you present them, so either unicode or
bytes would be 100% usable.
I'm not sure about the XML types so I'm no expert but it seems that at
least SQL Server has different possible encodings, if you pass in UTF-8
you receive UTF-8 and if you pass in ANSI you receive ANSI:
https://msdn.microsoft.com/en-us/library/ms131375.aspx
This means you'd have to make an assumption about the encoding.
If I would have to decide this I would both send also GUIDs and XML as
bytes, XML because it just might be what people need in a certain
scenario and GUIDs just because of consistency. It would make the flag
more understandable: you set 'unicode_results' to False and you know
what to expect without an exception here and an exception there.
Robert
On 1-5-2015 00:01, Michael Kleehammer wrote:

It would break, but I would actually be willing to do that and call it
3.1 or 4.0. I've been uncomfortable with passing Unicode to them.
Until then, I'm going to merge your patch, but I'll need to hand touch
it up because I removed |unicode_results| from Python 3 with an
|#ifdef|, etc.
Also, I thought I asked this earlier but I guess I deleted it.
Currently the patch you provided would also affect GUIDs and XML. I
really think XML should remain Unicode since most people would expect
it. I don't have an opinion on GUIDs, but I think the option makes
more sense if is is simply "the flag causes CHAR and VARCHAR to be
returned as bytes". So I would want to make a small change for that.
Also, is "unicode_results" really right? Perhaps a new parameter name
is better such as "char_as_bytes"? It is a bit more work and makes the
C code a little messier, but I think it would be better to have a more
self-describing parameter.
Thoughts?
—
Reply to this email directly or view it on GitHub
https://github.com/mkleehammer/pyodbc/pull/30#issuecomment-97983390.

One more addition to my previous mail:
At least sql server has the distinction between varchar and nvarchar.
Varchar can contain bytestreams of arbitral encoding. However nvarchar
is by definition and so guaranteed unicode.
If you'd want to make distinctions between field types, you could choose
to return unicode only when it's guaranteed no encoding conflict exists.
That would mean returning nvarchar and guid's as unicode regardless of
the flag, but xml and varchars as bytestreams.
what you're facing in that scenario is that you'd need a full list of
all field types in all db systems that are guaranteed to contain unicode.
For instance I also use Oracle for the same application and also there
I'm facing the same challenges but I don't know if Oracle has field
types that enforce Unicode.
For Oracle a 'complication' is that number datatypes could return long
as long as there are no decimals. That would reduce the use of
Decimal.decimal objects. But that's a whole different discussion.
Robert
On 1-5-2015 00:07, Michael Kleehammer wrote:

And I forgot to answer the last question - I don't pass in context
since I'm calling the converter as I process each column. It would be
possible to do so afterwards but wouldn't be as efficient. If more
than one column need conversion, you would not know in each converter
if the other column had already been converted or not. (Not important
in your example, but something that could trip someone up.)
Which is why I'm leaning towards the flag now.
—
Reply to this email directly or view it on GitHub
https://github.com/mkleehammer/pyodbc/pull/30#issuecomment-97984830.

Mike,
I was just wondering, do you have any official release scheduled? For now pyodbc is keeping me from moving to Py3 unless I use my manually patched source to facilitate fallback to bytes instead of unicode for varchar fields (versus nvarchar fields). It would be nice to have an 'official' solution.

I don't think this is necessary anymore after the complete Unicode rewrite.  You can now use something like: Connection.setdecoding(pyodbc.SQL_VARCHAR, encoding='utf-8', to=str)
Thanks though.


Fixing some bugs in temporary assets

We were losing references to temporary assets when switching between the asset editor and blocks editor. This fixes that and also makes it so that the source of truth for assets is the block data and not the field value (though that still gets used if the data doesn't exist)

also fixes https://github.com/microsoft/pxt-arcade/issues/2493 !


Create new Windows class issue

Summary of your issue
When I create a new Window class, after execution the window shows and closes immediately.
Environment
Windows 7 64 bit
What did you do when you faced the problem?
After creating a new Window class
Example code:

using (Window window = new Window("Result")){}

Output:

What did you intend to be?
I thought when I explicitly call the method "ShowImage", the image should be shown. But not after creating the instance of the class.

Please use Cv2.WaitKey();
https://github.com/shimat/opencvsharp#usage

I know Cv2.WaitKey() doesn't close the window until you close it.
I'm trying to understand why after creating an instance window opens and closes immediately.
For example:
I create an instance at the beginning of my program. The window opens and closes(I don't need it).
Then there are many many operations.... My program works 10 minutes...
I wanna show the specific image. I invoke ShowImage method and then Cv2.WaitKey(). Here I understand why this method uses.

new Window("windowName") is a simple wrapping of cv::namedWindow (C++). Please check out the native OpenCV specs for cv::namedWindow and cv::waitKey. I am closing this issue as it is not about the wrapper.


get original path

I have a use case where I would like to get the original path to the filesystem so that I can use ffmpeg to stream HLS.

How about using op.info().root() to get the root path of your backend and concat the original path?

That works.


Initial API types using kube-builder

Following guide of https://cluster-api.sigs.k8s.io/developer/providers/getting-started/initialize-repo-and-api-types#initialize-a-repository-and-the-providers-api-types.

/cc @kyleCheng56

This is using


[Dispatcher] Add cmake files for Windows platform

Thanks for your contribution. In general, this repo is for Linux only. It doesn't include MSDK windows runtime.

The dispatcher library only has Visual Studio project files. With CMake, one can compile or cross compile it without Visual Studio. It will not require MS c/c++ runtime and will link with any other c/c++ libraries that comes with compiler toolchain e.g. gcc, clang etc.

So you just need compile dispatcher for Windows? Windows Intel media driver folder should include MSDK built runtime and dispatcher which are close source.

So you just need compile dispatcher for Windows?

Yes.

This repo is not used to accept the patch for Windows code.

CMake project was also requested here https://github.com/Intel-Media-SDK/MediaSDK/issues/2935


On My Own Dataset

@cmh1027 cmh1027  Thank you for your excellent work. Now, I want to run your code on a custom dataset, but I am encountering some difficulties with the dataloader part of your code. My dataset is of a certain indoor scene and includes some color images, with known 'near' and 'far' scene parameters, and known camera intrinsics. Due to the uniqueness of our dataset, it cannot be successfully processed with COLMAP. However, when I was reading your code, it utilizes data processed by COLMAP and has some other settings, so could you please give me some advice? Thank you!

@TwiceMao Hello. I updated the dataset file for custom datasets. You can check it in README.

@cmh1027  I need to compare your method with my custom data set. But I encountered difficulties when doing test-time-optimization and evaluation. Could you please provide me with convenience? thank you!

@TwiceMao Test-time optimization requires GT camera poses (you can refer to supplementary material) because it is only for reporting metrices of validation images. Based on your first comment, it seems that you don't have GT poses so I guess that doing TTO on your dataset is not possible. If you still want me to update the code, please leave the comment.

@cmh1027
Sorry, I didn't provide complete information. We have GT (Ground Truth) camera poses. Since our dataset is a synthetic dataset, we have GT camera poses available. However, due to the challenging settings of the dataset, traditional Structure from Motion methods cannot function properly.

@TwiceMao I updated the code, but didn't test it because currently there's no GPU left due to ECCV. Let me know if any error occurs.

@cmh1027   Thanks, I will test soon! And I will tell you the error if there is.


support psycopg2 sslmode

Please support passing sslmode to psycopg2.  Most cloud databases require it, example change in pgwarehouse.py:
        self.pgsslmode = conf.get('pgsslmode', 'preferred')
        self.client = psycopg2.connect(
            f"host={self.pghost} dbname={self.pgdatabase} user={self.pguser} password={self.pgpassword} port={self.pgport} sslmode={self.pgsslmode}",
            connect_timeout=10
        )

This PR addresses the problem, and more - https://github.com/scottpersinger/pgwarehouse/pull/8

thanks Matt! I merged your PR. Funny that I wrote this thing against a Heroku db... Guess it didn't require SSL!


Make find invited user by email case insensitive

What problem does this pull request solve?
Trello card: https://trello.com/c/JBBA5kyk/1623-make-email-matching-case-insensitive-when-adding-someone-to-a-group
When users are created in Signon and Auth0, the email is downcased when it is stored.
When inviting users to join groups, we should therefore ignore the case when locating the user to invite. Previously, we were showing an error saying that the user does not have a Forms account when the case did not match the stored email for the user.
Things to consider when reviewing

Ensure that you consider the wider context.
Does it work when run on your machine?
Is it clear what the code is doing?
Do the commit messages explain why the changes were made?
Are there all the unit tests needed?
Has all relevant documentation been updated?

A unique constraint on email addresses would make any clash issues not our problem.


Adding all site content from 0l.network in markdown form

I was able to export all of the content from the site and turn everything into MD for Github. This includes all blog content and pages that existed on the original site. I also took some of the pages that had older content and moved them to an archive folder.

Looks good. Only change is to move the content to ./docs instead of ./site-content. Then you'll see them when you publish. Notice capitalization of the directory names.


Pasting multiple lines into the "find in current buffer" field

Hi there, when I command + f and paste multiple lines into the "find in current buffer" field the lines seem to be pasted into the field but behind all the other ui elements.

bug?

Duplicate of #4400. Please subscribe to that issue for updates.


Basic plugin creation doc

References issue https://github.com/feathersjs/feathers-docs/issues/155

@jones, this is really awesome!

This is great, thank you! I'm going to merge this tomorrow. I hope it's ok if I change it up a little bit after that. I'd like to add some information on how to create your own spec compliant service adapter and maybe also mention that a plugin does not have to be a service but could also be used to mix functionality into services (like what feathers-hooks does) and the application.

Rock on.

On Apr 30, 2016, at 6:41 PM, David Luecke<EMAIL_ADDRESS>wrote:
This is great, thank you! I'm going to merge this tomorrow. I hope it's ok if I change it up a little bit after that. I'd like to add some information on how to create your own spec compliant service adapter and maybe also mention that a plugin does not have to be a service but could also be used to mix functionality into services (like what feathers-hooks does) and the application.
—
You are receiving this because you authored the thread.
Reply to this email directly or view it on GitHub


Feature/member carrousel

What does this PR do?

Adds the carousel functionality to see members in order.

Related issues

Merge Checklist:

[x] The branch is up-to-date (i.e. rebased) with the base branch
[x] No code style issues (eslint and flow)

The only file where logic was added is src/components/Members/MembersGrid/MembersGrid.css
Other files are just ESLint corrections.


FAILED: InterceptorTests.test_interceptor_shouldInterceptSignals

11:02:19 Test Case 'InterceptorTests.test_interceptor_shouldInterceptSignals' started at 2022-06-10 18:02:19.205
11:02:19 <EXPR>:0: error: InterceptorTests.test_interceptor_shouldInterceptSignals : threw error "
11:02:19         try p.expectNoMessage(for: .milliseconds(500))
11:02:19              ^~~~~~~~~~~~~~~~
11:02:19 error: Received unexpected message [_ChildTerminated(/user/theWallsHaveEarsForTermination/stopperTwo)]:_ChildTerminated. Did not expect to receive any messages for [500ms]."
11:02:19 ------------------------------------- ClusterSystem(InterceptorTests) ------------------------------------------------
11:02:19 Captured log [InterceptorTests][2022-06-10 18:2:19.2100] [ClusterSystem.swift:909] [warning] Assign identity
11:02:19 // metadata:
11:02:19 // "actor/id": /system/receptionist
11:02:19 // "actor/id/uniqueNode": sact://InterceptorTests@<IP_ADDRESS>:9001
11:02:19 // "actor/type": OpLogDistributedReceptionist
11:02:19 Captured log [InterceptorTests][2022-06-10 18:2:19.2100] [ClusterSystem.swift:922] [trace] Actor ready
11:02:19 // metadata:
11:02:19 // "actor/id": /system/receptionist
11:02:19 // "actor/type": OpLogDistributedReceptionist
11:02:19 Captured log [InterceptorTests][2022-06-10 18:2:19.2110] [ClusterSystem.swift:395] [info] ClusterSystem [InterceptorTests] initialized, listening on: sact://InterceptorTests@<IP_ADDRESS>:9001
11:02:19 Captured log [InterceptorTests][2022-06-10 18:2:19.2110] [_OperationLogClusterReceptionistBehavior.swift:98][/system/receptionist-ref] [debug] Initialized receptionist
11:02:19 Captured log [InterceptorTests][2022-06-10 18:2:19.2110] [ClusterEventStream.swift:80][/system/clusterEvents] [trace] Successfully added async subscriber [ObjectIdentifier(0x00007f3e846bce30)]
11:02:19 Captured log [InterceptorTests][2022-06-10 18:2:19.2110] [ClusterEventStream.swift:44][/system/clusterEvents] [trace] Successfully subscribed [_ActorRef<Cluster.Event>(/system/receptionist-ref/$sub-DistributedActors.Cluster.Event-y)], offering membership snapshot
11:02:19 Captured log [InterceptorTests][2022-06-10 18:2:19.2120] [_ActorShell.swift:438][/user/theWallsHaveEarsForTermination] [error] DeathPactError: Unhandled [_ChildTerminated(/user/theWallsHaveEarsForTermination/stopperOne)] signal about watched actor [/user/theWallsHaveEarsForTermination/stopperOne]. Handle the `.terminated` signal in `.receiveSignal()` in order react to this situation differently than termination.
11:02:19 Captured log [InterceptorTests][2022-06-10 18:2:19.2130] [DeadLetters.swift:206][/user/theWallsHaveEarsForTermination] [notice] Dead letter was not delivered to ["/user/theWallsHaveEarsForTermination#789261356"]
11:02:19 // metadata:
11:02:19 // "deadLetter/location": /code/Sources/DistributedActors/_ActorShell.swift:604
11:02:19 // "deadLetter/message": childTerminated(ref: _AddressableActorRef(/user/theWallsHaveEarsForTermination/stopperTwo), DistributedActors._TerminationCircumstances.stopped)
11:02:19 // "deadLetter/message/type": DistributedActors._SystemMessage
11:02:19 // "deadLetter/recipient": /user/theWallsHaveEarsForTermination#789261356
11:02:19 ========================================================================================================================
11:02:19 Test Case 'InterceptorTests.test_interceptor_shouldInterceptSignals' failed (0.022 seconds)

This is one of the tests we'll be removing entirely since we have new DA based interceptors and those behavior based one are going away.
If it pops up a lot feel free to delete the test tbh.


compare falsy header values & numbers correctly

The "mocking succeeds when mocked and specified request headers have falsy values" which I made for #966 was still failing when run with {only: true} :/ I really don’t trust the tests much right now
Anyway, this fixes it for good now, I hope

Coverage remained the same at 92.686% when pulling d7b86971c81212d928037faa2e4795269577ee16 on handle-falsy-header-values into 66cd477dbc3c262b4f55d045f161f0de3a2a0b15 on master.


summary and response details only included in swagger if XML documentation is read

To improve the documentation I'd suggest to add a sentence similar to the following:
Some swagger feature do work without the use of a XML file based documentation, e.g. the scheme for a request body or the possible response codes (if specified in attributes). To make use of the <summary> or <response code="..."> tags the use of the XML based documentation file is mandatory, though.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 14fce65f-1337-58cb-2193-8d8e0e62792d
Version Independent ID: 59222460-a971-e76e-4fe9-23d4d7d768ee
Content: Get started with Swashbuckle and ASP.NET Core
Content Source: aspnetcore/tutorials/getting-started-with-swashbuckle.md
Product: aspnet-core
Technology: aspnetcore-tutorials
GitHub Login: @zuckerthoben
Microsoft Alias: scaddie

@hf-kklein would you be interested in creating a PR to address this issue? cc @scottaddie


Remove additional newline when printing on web

Printing on web is less readable than on other platforms due to the additional newline

This might be an issue with the tool, but it does look like we're not including the newline:
https://github.com/flutter/flutter/blob/master/packages/flutter_tools/lib/src/build_runner/resident_web_runner.dart#L701
You could check if the lines already have an appended newline at that point

I don't think it's the tool, it looks good there. It only occurs in Android studio's run window, so perhaps a bug for flutter/intellij?

, so perhaps a bug for flutter/intellij?

seems unlikely. This would be easy to validate by debugging the tool or running from the command line

From the command line, it's fine, both in and out of Android Studio, that rules out the tool, no?

only somewhat :)
Android Studio is running the flutter app in "machine" mode, you can repro a similar setup with `flutter run -d chrome --machine"

if the logs in that format do not have the newline appended, then you were right - and its an Android Studio/Intellij issue

Ah thanks! I debugged this a littler further. The message from _vmService passed to  globals.printStatus has a \n byte at the end on web, whereas the line string in resident_runner.dart doesn't. When the --machine flag is used, NotifyingLogger is used, which prints message with the extra newline.

@grouma is this appending by dwds or chrome devtools? If so we should consider removing it to match the other platforms.

We append a newline to the console events we get from Chrome here: https://github.com/dart-lang/webdev/blob/4112b1be94563ee414b2fcaf362e2f4669a5c68d/dwds/lib/src/services/chrome_proxy_service.dart#L690
We do that to align with the console.log API. Otherwise the messages you see in the Dart DevTools console would not look appropriate.

Yes, it does make sense to eventually append a newline - but its being done in multiple places right now. What does the devtools console do for stdout/stderr from mobile/desktop flutter applications?

I assume Dart DevTools does not append a new line since it shows up as expected.

I'm now seeing triple newlines on the master channel in Android Studio with an iOS device

Fixed by https://github.com/flutter/flutter/pull/63976


Small documentation fixes that should clear up some test failures

Two tests are failing because of these sphinx documentation errors. This should clean up a lot of the failures on different PRs except for the tests using numpy prerelease and astropy dev.

Thanks @wtgee !


"use of closed network connection" on long-lived blob pushes (how can I configure timeouts?)

I have been attempting to use regctl image copy, per @sudo-bmitch 's advice on this StackOverflow question.  Unfortunately, it hasn't worked with any of the repositories or images I've tried so far, due to the following error:
Failed to send blob (put), digest sha256:0e7c9a9df090dca82298fa849f9b5b7886a552cfac13077f625f8a95bf3b192d, ref docker.io/openworkshop/maker-builder@sha256:9cc2c46e51c9d14e287bddb3033c4217864f5662a01a70c2153ecbc699e376a0: Put "https://registry-1.docker.io/v2/openworkshop/maker-builder/blobs/uploads/66a6c3c2-b0df-494b-965a-8eb5b6b09c3b?_state=8z14zK0MmvI0dTyAh47nrgpfvlH1yJXdKFyN_9Kkj117Ik5hbWUiOiJvcGVud29ya3Nob3AvbWFrZXItYnVpbGRlciIsIlVVSUQiOiI2NmE2YzNjMi1iMGRmLTQ5NGItOTY1YS04ZWI1YjZiMDljM2IiLCJPZmZzZXQiOjAsIlN0YXJ0ZWRBdCI6IjIwMjEtMDctMTJUMTQ6MDU6NDAuMDI3MzA3MDQ3WiJ9&digest=sha256:0e7c9a9df090dca82298fa849f9b5b7886a552cfac13077f625f8a95bf3b192d": write tcp <IP_ADDRESS>:58970-><IP_ADDRESS>:443: use of closed network connection
--
  |
  | at ChildProcess.exithandler (node:child_process:397:12)
  | at ChildProcess.emit (node:events:394:28)
  | at maybeClose (node:internal/child_process:1067:16)
  | at Process.ChildProcess._handle.onexit (node:internal/child_process:301:5) {
  | killed: false,
  | code: 1,
  | signal: null,
  | cmd: 'regctl image copy -v info containers.oodalolly.camp/openworkshop/maker-builder:latest docker.io/openworkshop/maker-builder:latest'
  | }

This is likely due to the fact that (1) layers in my windows server images are multiple GB in size and (2) my internet connection is poor.
I have tried searching this repository for timeout related options, as well as looked at the MAN (regctl image copy —help) and registry config source code. AFAICT, there is no way to pass in the necessary timeout flags to regctl (?)

Thanks for the report. I think there's more I can do to improve fault tolerance with unstable networks, and in particular retrying a blob send after a previous failure. The regctl command itself doesn't have a timeout. One could be added but I don't believe that would help here. Instead it stops on an error, including a network fault, or user interruption (cont-c).
For additional debugging, output with -v debug would help, along with an indication of whether the error happens at the same place in every blob.

Hm. I don't use golang myself, but some research indicates that this is a standard "connection closed before content length headers received" sort of error. Broadening the search to other languages, then, it seems specific to the Docker API as it pertains to Windows images. I'm not using a proxy, but I am attempting to push the image from within a Docker container (my CI itself is dockerized), though the container is based upon debian-slim and running on an Ubuntu host.
The issue always happens with the same blob. Here's a paste of the debug logs:

INFO[0019] Copy layer                                    layer="sha256:0e7c9a9df090dca82298fa849f9b5b7886a552cfac13077f625f8a95bf3b192d" source="containers.oodalolly.camp/openworkshop/maker-builder:latest" target="docker.io/openworkshop/maker-builder:latest"
DEBU[0019] Sending request                               method=HEAD url="https://registry-1.docker.io/v2/openworkshop/maker-builder/blobs/sha256:0e7c9a9df090dca82298fa849f9b5b7886a552cfac13077f625f8a95bf3b192d" withAuth=true
DEBU[0020] Not found                                     Status="404 Not Found" URL="https://registry-1.docker.io/v2/openworkshop/maker-builder/blobs/sha256:0e7c9a9df090dca82298fa849f9b5b7886a552cfac13077f625f8a95bf3b192d"
DEBU[0020] Sending request                               method=GET url="http://containers.oodalolly.camp/v2/openworkshop/maker-builder/blobs/sha256:0e7c9a9df090dca82298fa849f9b5b7886a552cfac13077f625f8a95bf3b192d" withAuth=false
DEBU[0020] Auth scope added                              host=registry-1.docker.io scope="repository:openworkshop/maker-builder:pull,push"
DEBU[0022] Sending request                               method=POST url="https://registry-1.docker.io/v2/openworkshop/maker-builder/blobs/uploads/?mount=sha256%3A0e7c9a9df090dca82298fa849f9b5b7886a552cfac13077f625f8a95bf3b192d" withAuth=true
DEBU[0025] Sending request                               method=PUT url="https://registry-1.docker.io/v2/openworkshop/maker-builder/blobs/uploads/8594ad96-588f-4bec-bc15-85588f94c5e1?_state=SaoITkccZf_dtBIO50qojZLYnjAG6aYY6PiRaMkvuLN7Ik5hbWUiOiJvcGVud29ya3Nob3AvbWFrZXItYnVpbGRlciIsIlVVSUQiOiI4NTk0YWQ5Ni01ODhmLTRiZWMtYmMxNS04NTU4OGY5NGM1ZTEiLCJPZmZzZXQiOjAsIlN0YXJ0ZWRBdCI6IjIwMjEtMDctMTJUMTc6NTg6MDAuMzMyODgyOTc5WiJ9&digest=sha256:0e7c9a9df090dca82298fa849f9b5b7886a552cfac13077f625f8a95bf3b192d" withAuth=true
aDEBU[3292] Unexpected status                             Status="504 Gateway Time-out" URL="https://registry-1.docker.io/v2/openworkshop/maker-builder/blobs/uploads/8594ad96-588f-4bec-bc15-85588f94c5e1?_state=SaoITkccZf_dtBIO50qojZLYnjAG6aYY6PiRaMkvuLN7Ik5hbWUiOiJvcGVud29ya3Nob3AvbWFrZXItYnVpbGRlciIsIlVVSUQiOiI4NTk0YWQ5Ni01ODhmLTRiZWMtYmMxNS04NTU4OGY5NGM1ZTEiLCJPZmZzZXQiOjAsIlN0YXJ0ZWRBdCI6IjIwMjEtMDctMTJUMTc6NTg6MDAuMzMyODgyOTc5WiJ9&digest=sha256:0e7c9a9df090dca82298fa849f9b5b7886a552cfac13077f625f8a95bf3b192d"
WARN[3292] Failed to push blob                           err="Failed to send blob (put), digest sha256:0e7c9a9df090dca82298fa849f9b5b7886a552cfac13077f625f8a95bf3b192d, ref docker.io/openworkshop/maker-builder@sha256:9cc2c46e51c9d14e287bddb3033c4217864f5662a01a70c2153ecbc699e376a0: All requests failed" src="containers.oodalolly.camp/openworkshop/maker-builder:latest" tgt="docker.io/openworkshop/maker-builder:latest"
WARN[3292] Failed to copy layer                          err="Failed to send blob (put), digest sha256:0e7c9a9df090dca82298fa849f9b5b7886a552cfac13077f625f8a95bf3b192d, ref docker.io/openworkshop/maker-builder@sha256:9cc2c46e51c9d14e287bddb3033c4217864f5662a01a70c2153ecbc699e376a0: All requests failed" layer="sha256:0e7c9a9df090dca82298fa849f9b5b7886a552cfac13077f625f8a95bf3b192d" source="containers.oodalolly.camp/openworkshop/maker-builder:latest" target="docker.io/openworkshop/maker-builder:latest"
Failed to send blob (put), digest sha256:0e7c9a9df090dca82298fa849f9b5b7886a552cfac13077f625f8a95bf3b192d, ref docker.io/openworkshop/maker-builder@sha256:9cc2c46e51c9d14e287bddb3033c4217864f5662a01a70c2153ecbc699e376a0: All requests failed
root@buildkite-agent-amd64-7:/#

From the earlier edit, I saw there was a Status="504 Gateway Time-out". If that's not coming from a local proxy, it could be part of the Docker Hub infrastructure itself, so I wouldn't read too much into it. The big telling part to me is how much time the logs indicated had passed, which appeared to be about 55 minutes, so my expectation is the request is well past sending headers. My best guess is something server side killing connections that are up for over 50 minutes.
Adding some retry logic, and falling back to chunked uploads should make a big improvement here, so I'll make that the next priority for this project.

@zaneclaes have a look at regclient/regsync:edge or regclient/regsync:alpine-edge to see if they resolve this for you. The retry code wasn't too difficult to add, but finally getting around to writing some decent test code took a bit of effort. Hopefully that pays off with fewer bugs and regressions in the future.

Release v0.3.6 just went out with #70 which will hopefully resolve this.


Update pointer event tests results for all browsers

@RByers, @teddink, @mingchou

LGTM, thanks.  There's a couple surprises for me in the output, but we can talk about that separately.


fix(RELEASE-994): incorrect handling of multiarch images with 1 arch

This was caught in a test and it's a valid use case that we should support - you could have a multiarch image (with a manifest list) that will only contain one arch image inside.
Previously, we would handle such image as a normal single arch image and the script would fail.

/test release-pipelines-e2e-suite

/test release-pipelines-e2e-suite


all works, but very slow

Hi
Hello
My sequence of connecting and sending a message takes about 10 seconds, how can this be accelerated?
My code is
`
$logger = new Logger('xmpp');
$logger->pushHandler(new StreamHandler('php://stdout', Logger::DEBUG));
	$options
		->setHost($hostname)
		->setPort($port)
		->setUsername($adminUsername)
		->setPassword($adminPassword)
		->setLogger(new my_logger());

	$client = new XmppClient($options);

	$client->connect();
	$client->iq->getRoster();
	$client->message->send('Hello world', 'vovan@мщмфтюсщь');
	$client->disconnect();

`
launched on same server with ejabberd.
Thanks !

I found the problem
in the module
norgul/xmpp-php/src/Socket.php uses
fgets($this->connection) with a timeout of 1 second
here is solution idea
https://stackoverflow.com/questions/9356152/non-blocking-on-stdin-in-php-cli

Hello @hedgehed
the slowness issue was already discussed https://github.com/Norgul/xmpp-php/issues/7, and apparently in Socket.php timeout set to 1 imposes a 1s timeout, not setting the max waiting period.
You can speed it up by using a 250ms timeout instead (stream_set_timeout third parameter is microseconds so you can pass 250000 there and use 0 as second parameter).
This is something I have started working on but am currently a bit busy so I can't. If you find a nice solution feel free to make a PR.
Thank you

Hello @hedgehed, I have made the improvements and published as new patch version. You can try it out. I am closing the issue as resolved. Thanks


Datatables - can not scroll the page while on the table

Scrolling the page while touching the datatable
Datatables component has some issues and this is a big problem while I'm using my site on a small device.
When you're on the table you cannot scroll further down the page unless you touch out of the table to scroll it
Please fix this, I'm using this Library because datatables component 🙏

Hi, I've just added it to our project board. We'll fix it as soon as possible.

Thank you, glad  hear 🙏


Create a Slack app

https://api.slack.com/docs/slack-button

Won't do, this is a large change suited for a different app.


prql-java release workflow not yet working

Currently we have the start of a release workflow to maven. But it needs another pass — it's raising an error around not having a distribution argument: https://github.com/prql/prql/runs/7494133022?check_suite_focus=true, and the maven auth tokens need configuring

Related: https://github.com/prql/prql/blob/a2589f51ee8e71292587038dea7fd573a76d7477/prql-java/java/pom.xml#L9
There seems to be an outdated version field in an XML file there

Good spot. We can add a replacements like https://github.com/prql/prql/blob/main/prql-js/Cargo.toml#L36-L53 to the prql-java (although no impact until we do a pass of the java release...)


save and restore current topic

Intended to address https://github.com/rstudio/tutor/issues/56
@robbyshaver I've added the code required for tutorials to save and restore their hash and scroll position in this PR. This appears to work fine, but I thought you might want to give it a test drive to confirm before we merge it. Note that we are now restoring scroll position which previously I thought too janky but if we are restoring the topic it only seems right to restore the scroll position.

The save/restore topic is working great. The scroll restore doesn't work because of what I'm doing in tutorial-format.js. When we switch topics, I set the scroll top to 0. I put that in because our #hash navigation was causing the page to scroll up a bit whenever you switched topics and it looked bad. There may be another way around that problem, but I'm not even sure restoring the scroll position is a good thing - I agree that it's kind of wanky. I'm ok if we always take you to the top of the topic  - and if it's not what you want, you likely just want to jump to the end, which isn't much effort.

Okay, I just commented out the scroll position restoration so I think this is good to go.


memtest86plus: 6.10 -> 6.20

Automatic update generated by nixpkgs-update tools. This update was made based on information from https://github.com/memtest86plus/memtest86plus/releases.
meta.description for memtest86plus is: A tool to detect memory errors
meta.homepage for memtest86plus is: https://www.memtest.org/
Updates performed

Version update

To inspect upstream changes

Release on GitHub

Compare changes on GitHub

Impact

Checks done (click to expand)

built on NixOS
The tests defined in passthru.tests, if any, passed
found 6.20 with grep in /nix/store/5fard8289jxi1sp2w12xs8d8qxd48yyp-memtest86+-6.20
found 6.20 in filename of file in /nix/store/5fard8289jxi1sp2w12xs8d8qxd48yyp-memtest86+-6.20

Rebuild report (if merged into master) (click to expand)

1 total rebuild path(s)

1 package rebuild(s)

First fifty rebuilds by attrpath
memtest86plus

Instructions to test this update (click to expand)

Either download from Cachix:
nix-store -r /nix/store/5fard8289jxi1sp2w12xs8d8qxd48yyp-memtest86+-6.20 \
  --option binary-caches 'https://cache.nixos.org/ https://nix-community.cachix.org/' \
  --option trusted-public-keys '
  nix-community.cachix.org-1:mB9FSh9qf2dCimDSUo8Zy7bkq5CX+/rkCWyvRCYg3Fs=
  cache.nixos.org-1:6NCHdD59X431o0gWypbMrAURkbJ16ZPMQFGspcDShjY=
  '

(The Cachix cache is only trusted for this store-path realization.)
For the Cachix download to work, your user must be in the trusted-users list or you can use sudo since root is effectively trusted.
Or, build yourself:
nix-build -A memtest86plus https://github.com/r-ryantm/nixpkgs/archive/db7305086f7917980b3c57de64c8e9984abfd7b2.tar.gz

After you've downloaded or built it, look at the files and if there are any, run the binaries:
ls -la /nix/store/5fard8289jxi1sp2w12xs8d8qxd48yyp-memtest86+-6.20
ls -la /nix/store/5fard8289jxi1sp2w12xs8d8qxd48yyp-memtest86+-6.20/bin

Pre-merge build results
We have automatically built all packages that will get rebuilt due to
this change.
This gives evidence on whether the upgrade will break dependent packages.
Note sometimes packages show up as failed to build independent of the
change, simply because they are already broken on the target branch.
Result of nixpkgs-review run on x86_64-linux 1

1 package built:

memtest86plus

Maintainer pings
cc @LunNova for testing.

@jansol There’s a separate PR for that:

#226821


Rookout no slf4j relocated

@orishoshan @ElDuderinos
This will fix https://rookout.atlassian.net/browse/RK-7069
Exception in thread "Thread-1" java.lang.NoSuchMethodError: org.java_websocket.client.WebSocketClient.<init>(Ljava/net/URI;III)V at com.rookout.rook.ComWs.RookoutWebSocketClient.<init (RookoutWebSocketClient.java:43)

All I did was to rename the namespace.

@BenTheKlein don't we have a way that we'll be easier to merge changes from upstream? Also, can you explain a bit more regarding slf4j?

@LiranLast
@orishoshan can explain about the slf4j; he did that change; all I did was to rename the namespace;
I opened a ticket about the management of this (branched) project


Broken link "ArgoCD GitOps Tutorial - Working with Kustomize"

The Guides > Intermediate > ArgoCD GitOps Tutorial - Working with Kustomize link is broken, RedHat's website returns a 404.
I don't know what the original article was, but on google I found this doc, not sure if this is the same one. https://redhat-scholars.github.io/argocd-tutorial/argocd-tutorial/03-kustomize.html

@Petrosz007 thanks a lot for reporting this :ok_hand:
I've fixed it in abfd79f.


Relayer

Still needs work

I think next step would be ServiceContext being a Kestrel thing so coming out of Connection

Frame : ServiceContext looks problematic,

In ServiceConext is a lot of http specific stuff rather than networking
These might be valid for networking
public IApplicationLifetime AppLifetime { get; set; }
public IConnectionTrace Log { get; set; }
public IThreadPool ThreadPool { get; set; }

This is probably split (e.g. NoDelay)
public KestrelServerOptions ServerOptions { get; set; }

These are very much not Connection related
public DateHeaderValueManager DateHeaderValueManager { get; set; }
public IHttpComponentFactory HttpComponentFactory { get; set; }
public Func<IConnectionContext, Frame> FrameFactory { get; set; }
public Action<IFeatureCollection> PrepareRequest { get; set; }

Reverting the ServiceConext thing but FrameFactory can be Func<IConnectionContext, IFrameControl> if the methods Start, Stop and Abort are added to it.

Better?

Better? ComponentFactory crosses the line; but its an idea

Going to leave it alone now :)

Closing :)


OpenEHR Environment

As an Electronic Healthcare Record user i want to explore an opensource alternative using patient data within the secure confines of a TRE.
Is your feature request related to a problem? Please describe.
A clear and concise description of what the problem is. Ex. I'm always frustrated when [...]
This request is beginning to see the Azure TRE and associated workspaces as a secure marketplace which connects world class research and healthcare innovations into a secure data environment which provides protection for patient data.
Describe the solution you'd like
A clear and concise description of what you want to happen.
I'd like to see the OpenEHR Opensource project and Java developed tools built to allow healthcare providers to test this. The OpenEHR project has the potential to disrupt global providers and the Azure TRE is a great environment to test, deploy and build this service longer term.
Describe alternatives you've considered
A clear and concise description of any alternative solutions or features you've considered.
There are many EHR providers globally and each provider has the ability to build their own workspace service in this open project irrespective of whether it is a commercial off the shelf product. This however places the EHR platform in the hands of an open community and the TRE offers a complementary deployment environment.
Additional context
Add any other context or screenshots about the feature request here.

Thanks Martin, will add this to the roadmap

@martysharkey  not sure I understand this request and how it fits into the Azure TRE roadmap. As far as I understand OpenEHR is a standard rather than a piece of software.
Can you be more specific? Thanks.


Drag and Drop conflict with another Component

I just realize Drag-n-Drop function on File uploader or Dropzone or FilePond or WYSYWYG Editor Drag not working because of render React Draggable Tabs component.
How to fix it?
Thanks

Like this case
https://github.com/react-dnd/react-dnd/issues/457


fix sequence bug and suit new logic

What this PR does:
Which issue(s) this PR fixes:

Fixes #
Special notes for your reviewer:
Does this PR introduce a user-facing change?:

duplicated with #301


Side menu: component updates

Acceptance Criteria:

For sandbox example have the side menu take up the full width of sandbox when past the mobile breakpoint.

Close, as this work would not be needed after implementing #1909


Deploy Helm chart on Kind cluster

Signed-off-by: Tom Kerkhove<EMAIL_ADDRESS>Closes #87

#88 is being reproduced in the CI, we're good to go @zroubalik!


feat(example-widget-space): Create example space widget

Example widget. DO NOT MERGE

Should we close this?

Yea we can get rid of this PR... eventually I'd like to create an actual project for this.


Fix STS credentials to ignore empty actor token path.

One-line fix is  is in oauth2_credentials.cc
Added test to ensure correct behavior

Thanks much for the speedy reviews. Test failures look unrelated.


Remove Autolinker from global scope

I'm trying to build Cesium with Webpack and I ran into the same error as #7981.
TypeError: Cannot set property 'Autolinker' of undefined

I'm guessing it has something to do with the bundled code being run in strict mode, but I didn't dive very deep into why Webpack was treating this as void 0 in the bundle.
Either way, this also happens to resolve #3497, and cleans up the global scope.
Autolinker fixed this in v0.24.1, but the bundled version here is 0.17.1, so to keep it safe, I just updated the UMD header.

Thank you so much for the pull request @ajlende! I noticed this is your first pull request and I wanted to say welcome to the Cesium community!
The Pull Request Guidelines is a handy reference for making sure your PR gets accepted quickly, so make sure to skim that.

:x: Missing CONTRIBUTORS.md entry.

Please add yourself to the contributors file!

:x: Missing CLA.

Please send in a Contributor License Agreement (CLA) and comment back here to let us know to check this!

:grey_question: CHANGES.md was not updated.

If this change updates the public API in any way, please add a bullet point to CHANGES.md.

:grey_question: Changes to third party files were made.

Looks like a file in one of our ThirdParty folders (ThirdParty/, Source/ThirdParty/) has been added or modified. Please verify that it has a section in LICENSE.md and that its license information is up to date with this new version.

:grey_question: Unit tests were not updated.

Make sure you've updated tests to reflect your changes, added tests for any new code, and ran the code coverage tool.

Reviewers, don't forget to make sure that:

[ ] Cesium Viewer works.
[ ] Works in 2D/CV.
[ ] Works (or fails gracefully) in IE11.

I signed the Individual CLA and added myself to CONTRIBUTORS.md

Thanks @ajlende ! I can confirm we received your CLA. Looks like a pretty straightforward change, hopefully we can get it in in the next release.

Thanks again for your contribution @ajlende!
No one has commented on this pull request in 30 days. Maintainers, can you review, merge or close to keep things tidy?
I'm going to re-bump this in 30 days. If you'd like me to stop, just comment with @cesium-concierge stop. If you want me to start again, just delete the comment.

Thanks for the PR @ajlende!  Sorry it took so long to get you a review on this.
Instead of modifying the version we have in the repo, can you please update the library to the latest version which you said has a fix for this?  Thanks!

@ajlende thanks again for this PR.  Were in the process of migrating Cesium to ES6 modules and Autolinker has been updated to the latest version and fixed as part of that process.  It should go into master and be part of the Nov 1 release.

Thanks for the awesome work @ajlende! Your contribution is about to launch to millions of users with the next release. :rocket:
Do you mind if we tweet about it? CC @OmarShehata @Slchow.


Add prometheus metrics timeout settings

Description
Metrics collection from OCP 3.7 using Prometheus may hit timeout while collecting metrics.
a. the default timeouts are too small
b. users can not set new timeout values to fit their system
This PR adds the settings needed to adjust the timeouts.
BZ: https://bugzilla.redhat.com/show_bug.cgi?id=1511341

@miq-bot add_label bug, providers/containers
cc @simon3z @moolitayer @ilackarms @joelddiaz

Closing in favour of using local config/setting.yaml

Closing in favour of using local config/setting.yaml

@yaacov do you mean settings.local.yaml or settings.yaml in the kubernetes repo?

@yaacov do you mean settings.local.yaml or settings.yaml in the kubernetes repo?

We have a settings.yml file [1] in manageiq-providers-kubernetes , after discussing the pro and cons of using each with @cben, we decided to use that one for the settings.

https://github.com/yaacov/manageiq-providers-kubernetes/blob/master/config/settings.yml

We have a settings.yml file [1] in manageiq-providers-kubernetes , after discussing the pro and cons of using each with @cben, we decided to use that one for the settings.
[1] https://github.com/yaacov/manageiq-providers-kubernetes/blob/master/config/settings.yml

:+1: for that approach then


Using Access is much slower than Map.get

As an example, this speeds up MapTupleFull get(8, 8) from average ~9.81 μs to average ~200ns.
Doing map[x] uses Access which is much slower than eg Map.get(map, x).

actually nevermind, closing this for now cause I can't reproduce 😭


Fix Plaid modal by updating to latest version of react-native-plaid-link-sdk / resolve stashed token issue

Details
cc @Julesssss @luacmartins
Fixed Issues

$ https://github.com/Expensify/App/issues/4959
Tests AND QA Steps

Start with a non-public domain account that has not yet set up a workspace or bank account
Create a new workspace by tapping on the green FAB button
Navigate to /bank-account by selecting the workspace and tapping the "Get Started" button
Tap button to add account via Plaid (Note: This step may take time to complete)
Enter test credentials user_good pass_good
Press "Continue"
Verify that the account selection dropdown appears

Tested On

[ ] Web
[ ] Mobile Web
[ ] Desktop
[x] iOS
[x] Android

Screenshots

Web

Mobile Web

Desktop

iOS

Android

This should be ready for review now

So... actually.... I'm still experiencing issues on Android on debug builds. Building for release works fine. @yuwenmemon lmk if you need help figuring out how to do this (there is a SO post somewhere).

Hmm actually it's worse than I thought and also happens in release but inconsistently.
Gonna put this back into draft and file see if I can get some help from Plaid.

Ok, this is ready for a review now.
There is still an issue with Plaid that causes the UI to load very slowly and basically makes it seem broken on dev, but I got to the bottom of the worst of the Android issues. Plaid is aware of the issue and working on it - it's related to their web bundle that is getting served via a WebView. But not sure what we can do about this from our end at the moment.
A more extreme idea is to create our own native module, but Plaid is also working on that for react-native so it seems like we should #do-nothing and wait for improvements.

Just tested again and it's working!

:hand: This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

Personally, I've never found the slow loading time to be that problematic, but nice to hear Plaid is looking into improvements anyway.

Oh nice! It could be related to my device or internet now that I think about it. Glad to hear it's only slow for me!

@Julesssss @luacmartins thanks for testing! 🙇

🚀 Deployed to staging by @luacmartins in version: 1.0.92-1 🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
failure ❌

🕸 web 🕸
success ✅

@marcaaron @luacmartins Hello! We're currently unable to test this in iOS and Android since we can't navigate to a specific URL in-app This might have to be tested internally or if you know another method please let us know.

Same answer as here -> https://github.com/Expensify/App/pull/5029#issuecomment-912664141 but please let us know here if that's not going to work! Thanks!

This issue is failing this PR https://github.com/Expensify/App/issues/5075

🚀 Deployed to production by @roryabraham in version: 1.0.93-1 🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
success ✅

🕸 web 🕸
success ✅


Week 5, Unit 7, Intro - typo

Subheading text ends abruptly - "This hands on script only shows the first part of the viedo for unit 7 since the second part that shows the creation of a "

done
https://github.com/SAP-samples/abap-platform-rap-opensap/blob/main/week5/unit7.md#introduction

done
https://github.com/SAP-samples/abap-platform-rap-opensap/blob/main/week5/unit7.md#introduction


Animated Flashpoint Logo on Homepage?

I feel like the static FP logo on the homepage isn't having a charm to it unlike the Flashpoint homepage. Perhaps a small animation could play for the logo in the site's homepage?

68ca37226a08ca9833375ba90b91ff0a99df1fe5


Create CONTRIBUTING.md

Pull Request Title

Related Issue
closes #175
Description
Adding a detailed contributing guide as guidance to give contributors proper expectations.
Type

[ ] Bug Fix
[ ] Feature Enhancement
[x ] Documentation Update
[ ] Code Refactoring
[ ] Other (please specify):

Proposed Changes

Screenshots / Code Snippets (if applicable)

How to Test

Checklist

[ ] The code compiles successfully without any errors or warnings
[ ] The changes have been tested and verified
[ ] The documentation has been updated (if applicable)
[ ] The changes follow the project's coding guidelines and best practices
[ ] The commit messages are descriptive and follow the project's guidelines
[ ] All tests (if applicable) pass successfully
[ ] This pull request has been linked to the related issue (if applicable)

Additional Information

No prob @srbhr! Happy to help :)


remove kvdb wal (#2)

Signed-off-by: youjiali1995<EMAIL_ADDRESS>
What is changed and how it works?
Close #xxx
What's Changed:
Related changes

PR to update pingcap/docs/pingcap/docs-cn:
PR to update pingcap/tidb-ansible:
Need to cherry-pick to the release branch

Check List
Tests

Unit test
Integration test
Manual test (add detailed scripts or steps below)
No code

Side effects

Performance regression

Consumes more CPU
Consumes more MEM

Breaking backward compatibility

Release note
Please add a release note.
If you don't think this PR needs a release note then fill it with None.
If this PR will be picked to release branch, then a release note is probably required.

/release make dist_release

/release


Dokumentation link leads to Warning: Potential Security Risk Ahead

PHP Version
not needed
Shopware Version
relate to the current dokumentation
Expected behaviour
visiting page without certificates warning
and after accept a leading to this page https://docs.shopware.com/en/shopware-6-en/settings/snippets
and  not to a external microsoft login page.
Actual behaviour
Warning: Potential Security Risk Ahead
Firefox detected a potential security threat and did not continue to wiki.shopware.in. If you visit this site, attackers could try to steal information like your passwords, emails, or credit card details.
What can you do about it?
The issue is most likely with the website, and there is nothing you can do to resolve it. You can notify the website’s administrator about the problem.
How to reproduce
Clear browser cache / logins and so on.
open https://docs.shopware.com/en/shopware-6-en/tutorials-and-faq/changing-a-template
scroll down to the headline "Including snippets"
below second sentence: click on the word here
by the way
https://docs.shopware.com/en/shopware-6-en/settings/snippets
Here is a missing translation of the headline.  "Links einbinden"
If you know a better place to report documentation issues, please leave a note.

Hello,
Within our company roadmap and work capacity, we try to address each bug or improvement request but admit that not each one will be resolved. To continue our culture of honesty and openness, we are closing this issue to focus on our roadmap on behalf of all Shopware users.
If you feel like this issue is still impacting you, please create a new issue and let us know.
Thank you again for your valuable feedback.


Cannot read property 'endpoints' of undefined

I have some sample code as follows:
var GoSquared = require('gosquared');

var gosquared = new GoSquared({
  api_key: 'key',
  site_token: 'token'
});

gosquared.storeEvent('Test Event', {
        'hello': 'world'
    },
    function(e, res){
        if(e) return console.log(e);
        console.log(res);
    }
);

which when run using Node gives the error:
node_modules/gosquared/lib/gosquared.js:182
  this._exec(this.config.endpoints.data, '/event?' + queryString.stringify(qsP
                        ^
TypeError: Cannot read property 'endpoints' of undefined
    at GoSquared.storeEvent (node_modules/gosquared/lib/gosquared.js:182:25)

I got the same issue while using endpoint to run amazon gamelift  locally... whats the solution of it?
my error is " s3.defineService.endpoint.hostname ='http://localhost:8080';
^
TypeError: Cannot read property 'endpoint' of undefined
at Object."

Hi @dharini08, it looks like you might be in the wrong place - the error message you're coming across is the same as in this issue, but this module has nothing to do with AWS or GameLift I'm afraid.
You're probably looking for the aws-sdk-js project or its associated documentation and developer guides. I hope that helps!

Thanks you so much.


Abilty to pull to xboxunity.net for updates and alternitive covers

it is a free service to download covers (both official and fan made) and title title update download.
thank you for the great project

I already implemented downloading title updates from XboxUnity. Check it in FAQ


$import creates NPE if content-type isn't populated

Describe the bug
If you are using $import, and the server hosting the ndJson file doesn't populate content-type, a NPE is thrown here: https://github.com/hapifhir/hapi-fhir/blob/48c28997e6cce8b704f1705a8bd2658b6ff7acbf/hapi-fhir-storage-batch2-jobs/src/main/java/ca/uhn/fhir/batch2/jobs/imprt/FetchFilesStep.java#L84
Expected behavior
To support endpoints providing no content-type for ndJson files, hapi should assume a ndJson file and try to load it.
Environment (please complete the following information):

HAPI FHIR Version 6.0.1

This is a dead easy fix, working on it now.

This is a dead easy fix, working on it now.

Thanks! Wasn't sure if you would agree to default to jsonND on unknown content-type. Thats why i didn'T create a PR.


Add an orderby when fetching from the database

When using PostgreSQL on a large database, if you paginate using offset, it may happen that psql do not follow the same rule to order the documents.
Meaning that, if I make multiple requests with different offsets, I might receive back documents that I already fetched before.
Exemple:
Running Select * FROM x OFFSET 100 two times might return different documents.
To tackle that issue, we need to add an order by during the request. This ensures the database follows the same order for the documents.

bors merge

Thanks again for contributing with Meilisearch :heart:
If you are participating in Hacktoberfest, and you would like to receive a small gift from Meilisearch too, don't forget to fill this form.


check-ttf.py: Fixed IOError for function check_with_msfontvalidator.

If the user doesn't have MS Font Validator installed, the file report.xml
will not be generated. The variable xml_report will not be able to load this
file. By adding this variable and subsequent statements to the try and accept
block, it will run the exception and not crash the script, if the user does
not have MS Validator installed.
Just for further clarity, here's the traceback:
Traceback (most recent call last):
  File "fontbakery-check-ttf.py", line 4261, in <module>
    fontbakery_check_ttf(config)
  File "fontbakery-check-ttf.py", line 4047, in fontbakery_check_ttf
    check_with_msfontvalidator(fb, target.fullpath)
  File "fontbakery-check-ttf.py", line 1778, in check_with_msfontvalidator
    xml_report = open("{}.report.xml".format(font_file), "r").read()
IOError: [Errno 2] No such file or directory: '/Users/marc/Documents/googlefonts/fonts/ofl/amaticsc/AmaticSC-Bold.ttf.report.xml'

oh! I see! Thanks ;-)


Suggestions for improvement

It would help if the first paragraph made it clear you were talking about a page in the ONLINE app.powerbi.com -  I wasted 20 minutes trying to find this in PowerBi desktop.  The screen clip is really insufficient to locate the appropriate option in context (to me it looks like a screen cap of the LEFT hand side of the desktop app rather than the RIGHT hand side of the web app.
Personal gateway just seems not to work, full stop (at least I never see it registered.
It should be made clear whether you need to leave the gateway app open in order for it to work.  The presence of the big "CLOSE" button in the bottom right where a "NEXT" button would normally be implies that closing it is required for the gateway to function.  (I assume it's running as a service but that could be laid out explicitly)
The big undocumented "gotcha" that exacerbates the confusion around all of these is that the "Manage gateways" page on app.powerbi.com DOES NOT REFRESH unless  you refresh the entire page :-(  I.e. you will continue to see an empty gateway list no matter how may times you go to "settings->Manage Gateways"  until you hit F5 in the browser.  This makes it appear that all the previous instructions steps are failed.
Slightly amusing that the warning "manage gateways will not show up until you are an admin" appears before the section on managing admins which would appear to put the user in a bit of a catch-22.   (Yes I know you become an admin by creating a gateway but when you're not seeing any gateways in the list because of the behaviour above and you're assuming that somehow the admin-allocation has gone wrong locally, this warning seems like it's designed as a wind-up ;-)  )

Perhaps these problems are due to me using the "New look" UI but it's frustrating that something that should "just work" in a couple of minutes requires an hour of floundering around before stumbling on the right sequence.
I would also suggest that this documentation suffers from the usual MS documentation structural issue of describing all the bits individually but making it quite unclear how to put them together.  Why not take a more task-based approach?  I'd bet 90% of users setting up a gateway fall into a couple of scenarios.... "As a data-analyst I want to be able to share and update a new csv file on a scheduled basis...."

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 20180bfa-f4ab-224a-d089-58a06dbf4ac3
Version Independent ID: f4ab3a3c-397d-01d1-f6d2-05e9085770a1
Content: Manage an on-premises data gateway
Content Source: data-integration/gateway/service-gateway-manage.md
Technology: on-premises-data-gateway
GitHub Login: @arthiriyer
Microsoft Alias: arthii

Hi @NeilMacMullen
Thanks for your feedback! Unfortunately, at this time we have been unable to review your issue in a timely manner and we sincerely apologize for the delayed response. We are closing this issue for now, but if you feel that it's still a concern, please respond and let us know. If you determine another possible update to our documentation, please don't hesitate to reach out again.


read huge data

When I tried to read the 1,28 GB file from
http://svs.aids.gov.br/dantps/centrais-de-conteudos/dados-abertos/sim/
http://svs.aids.gov.br/dantps/centrais-de-conteudos/dados-abertos/sim/DO21OPEN.zip
my computer cant open that file, so I did a change to allow an optional handler to read the data without keep all records in memory.
Example:
https://github.com/fabiooshiro/covid

Hi @fabiooshiro, thanks for the PR! The current API is already designed to read very large files by reading records in batches. I've outlined an example below that should hopefully work fine for your case. As such I don't think the changes in this PR are necessary, so I'll be closing this. If you have any problems please feel free to post back here or create a new issue.
const BATCH_SIZE = 1000;
(async () => {
    const dbf = await DBFFile.open('./DO21OPEN.dbf');
    while (true) {
        // read the next batch of records
        const records = await dbf.readRecords(BATCH_SIZE);

        // exit the while loop when no more records are read
        if (records.length === 0) break; // done

        // process each record in this batch
        for (const record of records) {
            // process each record here...
        }
    }
})();

Now I understand.
Thank you!


Fix StdoutOutputPlugin broken by stopping @Config indirection by default implementation at: #956

The default implementation has been introduced at: #931, and it's to be a kind of reverted as well in addition to #956.
@sakama @muga Can you have a look?

An unused import remained...

Passed. Merging... Thanks!


Demonstration notebook

This notebook specifies some parameters, generated the config YAML, then runs NEAT and displays the embedding tsne plot.

It works fine until it gets to the classifier step, at which point it complains about not having pos/neg validation sets.
I believe this is at least partially fixed in #48


⚠ AGEG website (prod) has degraded performance

In 72dd821, AGEG website (prod) (https://www.ageg.ca/) experienced degraded performance:

HTTP code: 200
Response time: 1961 ms

Resolved: AGEG website (prod) performance has improved in ac248e5.


Plugin Crash after Config deployment to Miniserver

Hi,
When deploying a new Config to the Miniserver the Plugin crashes after the reconnect... seems to be an issue with the Camera provide by the Intercom Gen 2
[1/23/2024, 9:29:13 AM] [LoxonePlatform] Connected to Miniserver
Miniserver out of service!
[1/23/2024, 9:36:47 AM] [LoxonePlatform] Socket closed 2008
[1/23/2024, 9:36:47 AM] [LoxonePlatform] Reconnecting in 10 seconds...
[1/23/2024, 9:36:57 AM] [LoxonePlatform] Trying to connect to Miniserver
[1/23/2024, 9:36:57 AM] [LoxonePlatform] Connected to Miniserver
Error: A Controller with the type/id 'camera' was already added to the accessory Sprechanlage
at Accessory.configureController (/homebridge/node_modules/homebridge/node_modules/hap-nodejs/src/lib/Accessory.ts:847:13)
at PlatformAccessory.configureController (/homebridge/node_modules/homebridge/src/platformAccessory.ts:148:34)
at Camera.setupService (/homebridge/node_modules/homebridge-loxone-proxy/src/homekit/services/Camera.ts:22:20)
at new Camera (/homebridge/node_modules/homebridge-loxone-proxy/src/homekit/services/Camera.ts:13:10)
at IntercomV2.setupCamera (/homebridge/node_modules/homebridge-loxone-proxy/src/loxone/items/Intercom.ts:54:5)
at /homebridge/node_modules/homebridge-loxone-proxy/src/loxone/items/IntercomV2.ts:13:12
at /homebridge/node_modules/homebridge-loxone-proxy/src/loxone/LoxoneHandler.ts:69:56
at Array.forEach ()
at handleAnyEvent (/homebridge/node_modules/homebridge-loxone-proxy/src/loxone/LoxoneHandler.ts:69:36)
at Object.socketOnEventReceived (/homebridge/node_modules/homebridge-loxone-proxy/src/loxone/LoxoneHandler.ts:99:17)

It should be fixed in v1.9.0-beta.7
Could you test and let me know if it resolves the issue for you?

Testet it several times.
Fix is working!
Congrats!


added hidden: true configuration to dfe-analytics-dataform config fil…

…es so fields are created with policy tags.

This PR is for the adding of the hidden:true configuration to the DFataform javascript configuration to apply the Policy Tags for hidden PII


Update error message to include SRIOV network node state not being pr…

…operly initialized.
When the SRIOV network node state is not properly initialized it can hit the error "no supported NIC is selected by the nicSelector" even though the NIC may be indeed be selected. This commit updates the error message to ensure that if the user is configuring a NIC that is supported, then the error is because the SRIOV network node state is not properly initialized.

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

0 of 1 (0.0%)  changed or added relevant line in 1 file are covered.
No unchanged relevant lines lost coverage.
Overall coverage increased (+0.1%) to 25.776%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

pkg/webhook/validate.go
0
1
0.0%

Totals

Change from base Build<PHONE_NUMBER>:
0.1%

Covered Lines:
1952

Relevant Lines:
7573

💛  - Coveralls

/cc @bn222
/cc @wizhaoredhat
/cc @SalDaniele

As discussed, let's have validateNicModel return an error instead. Also, let's get rid of the side-effect way to communicate the result of functions. More precisely, we should at least address interfaceSelected and maybe even nodesSelected.
It seems to me that we should also refactor the for loop in the function dynamicValidateSriovNetworkNodePolicy. Some parts of it are nested 5 deep.

/cc @pliurh

Hi @vrindle can you please fix the commit message?
the tittle is longer then expected for a commit :)

@vrindle please also add a test to cover the new case where the nic is supported but not initialize and please check the error message

@bn222
@wizhaoredhat
@zshi-redhat

LGTM

@adrianchiris
This is a pretty small change that doesn't actually change functionality. CI is green and we already have an LGTM from RH. Can you PTAL? Should be pretty quick.
Regards,
Balazs

This is a pretty small change that doesn't actually change functionality. CI is green and we already have an LGTM from RH.

did not see an LGTM from maintainer, @bn222 @SchSeba you should approve :)
will take a look at this later this week.

lgtm

Thx @vrindle for this improvement !


split r-hat

I added

implementation of split-R-hat (with tests)
additional validation in basic R-hat to ensure each chain has 2 or more draws (I added an additional test for this)

This resolves issue #36.

Codecov Report

Merging #37 (6c1c484) into main (dff8143) will increase coverage by 0.04%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main      #37      +/-   ##
==========================================
+ Coverage   97.91%   97.95%   +0.04%
==========================================
  Files          11       11
  Lines         288      294       +6
==========================================
+ Hits          282      288       +6
  Misses          6        6

Impacted Files
Coverage Δ

bayes_kit/rhat.py
100.00% <100.00%> (ø)

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more

I can update for 100% coverage of the tests.  And apply black.

This is ready to review.  Failures are all in MCMC tests, not in the rhat stuff I added.
This is all updated with 100% coverage tests.  I just added split_rhat and rank_normalized_rhat to the same rhat.py file.  The doc has full definitions and pointers to the original references.

@jsoules and @WardBrian.  Thanks for all the comments.  I'll learn Python one PR at a time.
I made all the fixes I could understand and marked them as resolved.
There are a couple points I didn't know how to fix and I would really appreciate guidance.

A few minor comments

27 of them and counting.  :-(.
There are two remaining concerns that I do not know how to address:

https://github.com/flatironinstitute/bayes-kit/pull/37#discussion_r1248101521
https://github.com/flatironinstitute/bayes-kit/pull/37#discussion_r1247958390


Missing dist file in 2.0.0

2.0.0 package does not contain ./dist/index.js file. Could you fix this with a new release @ibufu ?

/dist/* should be removed from .npmignore

You just have to build and release with current master, https://github.com/ibufu/vue2-scrollspy/commit/e9b5030128a8ed1eb46c4ebb0d1b0819a20fc8b2 should fix this. If you agree to give rights to me on npm registry, I could perform releases with this account : https://www.npmjs.com/~toilal

Sorry

I add you to collaborators of npm.


Investigate git worktree

Play with git worktree and explore workflow improvements

Didn't like the worktree workflow. Closing this.


Update templates to match helm best practices

Some tweaks for your pr #228 based on the tips in the following links, and on the default service scaffolding helm provides.
https://github.com/kubernetes/helm/blob/master/docs/chart_best_practices
https://github.com/kubernetes/helm/blob/master/docs/chart_best_practices/templates.md\#names-of-defined-templates
https://github.com/kubernetes/helm/blob/master/docs/chart_best_practices/rbac.md\#using-rbac-resources

Thanks very greateful for this hands-on teaching! :smile:

Also, these tweaks don't necessarily represent an exhaustive implementation of the suggestions in chart best practices, just a few things that caught my eye.


"Document for this path already in _openDocuments!" error on multiple DocumentManager.getDocumentForPath calls

Description
When calling DocumentManager.getDocumentForPath for the same path more than once, the error Document for this path already in _openDocuments! is thrown.
The API claims this method "Gets an existing open Document for the given file, or creates a new one if the Document is not currently open", so the document being already open should not cause any issue.
Steps to Reproduce

Call DocumentManager.getDocumentForPath with a valid path.
Call it again.
Observe error.

Expected behavior: Promise is provided that will give the open document (or open the document if it has closed)
Actual behavior: Error is thrown.
Versions
OS X El Capitan 10.11.6
Brackets Release 1.6 build 1.6.0-16680 (release 3df0ac6fa)

It seems that getOpenDocumentForPath does only compares the string for the path and does not do proper path comparison. Any difference in format will break this method.
See line 131 in /document/DocumentManager.js


⚠ Bofrost.be has degraded performance

In 72dec41, Bofrost.be (https://www.bofrost.be) experienced degraded performance:

HTTP code: 200
Response time: 859 ms

Resolved: Bofrost.be performance has improved in b6c98a5 after 2 hours, 21 minutes.


[zh] Umbrella topic for files missing translation.

The following files are missing in content/zh.

[ ]  153 content/en/docs/tasks/administer-cluster/migrating-from-dockershim/change-runtime-containerd.md   #31907
[x]  483 content/en/docs/tasks/administer-cluster/memory-manager.md #31172
[ ]   79 content/en/docs/setup/best-practices/enforcing-pod-security-standards.md   #31926
[ ]  779 content/en/docs/contribute/style/diagram-guide.md   #31912
[ ]  170 content/en/docs/concepts/security/pod-security-admission.md   #31926
[ ]  123 content/en/docs/concepts/storage/projected-volumes.md   #31945
[x]  183 content/en/docs/concepts/architecture/garbage-collection.md   #31180
[ ]   51 content/en/docs/concepts/architecture/cri.md    #31859
[ ]  478 content/en/docs/tutorials/security/apparmor.md   #31884
[ ]  526 content/en/docs/tutorials/security/seccomp.md    #31867
[ ]   75 content/en/docs/reference/tools/map-crictl-dockercli.md   #31943
[ ] 1517 content/en/docs/reference/config-api/kube-scheduler-config.v1beta3.md  #31018
[ ] 1517 content/en/docs/reference/config-api/kube-scheduler-config.v1beta2.md   #31021
[ ] 1449 content/en/docs/reference/config-api/kubeadm-config.v1beta2.md     #31030
[ ]  279 content/en/docs/reference/config-api/apiserver-encryption.v1.md   #31948
[ ]  281 content/en/docs/reference/config-api/kubelet-config.v1alpha1.md   #31951
[ ]  375 content/en/docs/reference/config-api/apiserver-config.v1alpha1.md    #31942
[ ]   91 content/en/docs/reference/config-api/apiserver-config.v1.md    #31941
[ ]  107 content/en/docs/reference/setup-tools/kubeadm/generated/kubeadm_kubeconfig_user.md  #31911
[ ]   61 content/en/docs/reference/setup-tools/kubeadm/generated/kubeadm_kubeconfig.md  #31911
[ ]   23 content/en/docs/reference/setup-tools/kubeadm/kubeadm-kubeconfig.md  #31911
[ ]   22 content/en/docs/reference/glossary/container-runtime-interface.md  #31977
[ ]   16 content/en/docs/reference/glossary/cadvisor.md   #31978
[ ]   28 content/en/docs/reference/glossary/userns.md   #31979
[ ]   25 content/en/docs/reference/glossary/event.md   #31980
[ ]  272 content/en/docs/reference/access-authn-authz/psp-to-pod-security-standards.md  #31940

/language zh
/triage accepted
/help

Then it seems that nearly all of the English files are translated to Chinese (except those files, which count not that much)! Wow 😊

Is there a plan to translate content under content/zh/docs/reference/kubernetes-api ?

/remove help

/remove-help

Is there a plan to translate content under content/zh/docs/reference/kubernetes-api ?

I'm not aware of any plan so far.

all works have been done, looks like we can close this one.
Thanks to all contribution

/close


Player V2

Implemented the episode detail view that expands and collapses into the mini player that sits just above the tab bar.
I made four new views to do this: the header view, the episode detail view, a controls view with play/pause/etc. buttons, and the mini player bar view.
Currently, the series title label doesn't update correctly because the search results don't return models with a series attribute. This should fix itself when the models are fully implemented.

This PR addresses #28 and #30


error Couldn't find match for "d546e3f7..." in "refs/heads/master" for "https://github.com/mwittig/license-checker.git".

Just suddenly started to happen, it was working fine just a couple of days ago but now can't install this package.
I just ran yarn add -D npm-license-crawler and got error Couldn't find match for "d546e3f738e14c62e732346fa355162d46700893" in "refs/heads/master" for "https://github.com/mwittig/license-checker.git".

Any thoughts?

@vrgimael I have the same problem, is this problem solved?


Made SSL enabled by default

As per #301

@LordMike Should it be enabled for the tests as well? Is there a reason why SSL is disabled for the tests?

I am unsure why it's been disabled by default all this time. It may be an artifact of "let's quickly disable it by default for testing" .. which then got committed..

Tests don't "need" TLS.. I'm not going to change it.


Updated Rubyzip to 1.1.7

This fixes #76. I also added unit tests for the loc drop generation and consumption commands.

While we are in here and fixing up the gemspec file, I have been thinking about updating a bunch of the requirements to be ~> X.Y instead of >= or ~> X.Y.Z. I may try to do that soon and see what happens.
And finally, I am also considering making twine require ruby 2.0 or greater now that OS X ships with ruby 2.0 by default. Thoughts?

This should address #76

Yeah, why not. Just ~> X.Y should be fine. To be honest I haven't thought too much about it when I added the minitest and mocha requirements. But I guess it should be done in a separate PR?
How about opening an issue for the ruby 2.0 update and see if many users protest in the next few weeks?

Sounds good to me.


JVM option change. (permgen -> meta)

Is your feature request related to a problem? Please describe.
No problem
Describe the solution you'd like
JVM option value change.
-XX:MaxPermSize -> -XX:MaxMetaspaceSize
Describe alternatives you've considered
From JDK8, the permgen space has been deleted.
Additional context
None

@kuckjwi0928 You are right. We missed this part. I think it needs to fix the default option in the shell file.
Thank you for your nice report :)

If you are busy, i can help you :)

welcome 👍

Thank you for your help.


pythonPackages.keyring: 12.0.2 -> 12.2.1

Motivation for this change
Bumping to latest version
Things done

[x] Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
Built on platform(s)

[x] NixOS
[ ] macOS
[ ] other Linux distributions

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
[ ] Tested execution of all binary files (usually in ./result/bin/)
[x] Fits CONTRIBUTING.md.

@GrahamcOfBorg build python2.pkgs.keyring python3.pkgs.keyring

Success on x86_64-linux (full log)
Attempted: python2.pkgs.keyring, python3.pkgs.keyring
Partial log (click to expand)
keyring/tests/backends/test_kwallet.py .ssssssssssssssssss               [ 89%]
keyring/util/__init__.py ..                                              [ 91%]
keyring/util/escape.py .                                                 [ 93%]
keyring/util/platform_.py .                                              [ 94%]
keyring/util/properties.py ...                                           [ 97%]
tests/test_packaging.py ..                                               [100%]

==================== 41 passed, 46 skipped in 12.48 seconds ====================
/nix/store/k7kx01fhzmwdx6r48m6y77pkxw2a17zh-python2.7-keyring-12.2.1
/nix/store/c4wg3qkqlyffaiwzm7xdgkw75yf1ycr4-python3.6-keyring-12.2.1

Success on aarch64-linux (full log)
Attempted: python2.pkgs.keyring, python3.pkgs.keyring
Partial log (click to expand)
keyring/tests/backends/test_kwallet.py .ssssssssssssssssss               [ 89%]
keyring/util/__init__.py ..                                              [ 91%]
keyring/util/escape.py .                                                 [ 93%]
keyring/util/platform_.py .                                              [ 94%]
keyring/util/properties.py ...                                           [ 97%]
tests/test_packaging.py ..                                               [100%]

==================== 41 passed, 46 skipped in 88.09 seconds ====================
/nix/store/8qmhh4glkclc5bz7a4zc6dg9vp3v3x58-python2.7-keyring-12.2.1
/nix/store/ay6by9y2nis1x8v2jc6bjz80a95sxqn5-python3.6-keyring-12.2.1


Use ObjectName as discriminator's mapping key

What type of PR is this?
Add one of the following kinds:

documentation

What this PR does / why we need it:
Encourage usage of Object Name as discriminator's mapping key to facilitate usage of Json serializer/deserializer
Which issue(s) this PR fixes:
Fixes #42
Special notes for reviewers:
Changelog input
Encourage usage of Object Name as discriminator's mapping key to facilitate usage of Json serializer/deserializer

Additional documentation

I have modified the style of writing OpenAPI name to be aligned with other parts of the DG.

@RubenBG7 @jordonezlucena  Could you review this PR? As it was discussed: it is recommendation to simplify life of developers using code generators.

lgtm

Merged as agreed in the call


Loan status prediction using ML

💥 Proposal
Please Assign this issue to me I want to build a loan prediction system using the ML algorithm SVM in Python.

@i-am-SnehaChauhan Can you please provide the dataset link which you will be using.

Please assign this project to me.
Dataset Link: https://www.kaggle.com/datasets/altruistdelhite04/loan-prediction-problem-dataset

Hey data set i will be use which is available on kaggle
https://www.kaggle.com/datasets/altruistdelhite04/loan-prediction-problem-dataset

Hey @theyashwanthsai please assign this to me.

@i-am-SnehaChauhan  - you can go ahead! We are assigning you 21 days for this project, after which it will be assigned to someone else if not completed. All the best!  Name the file as: algorithm_dataset.ipynb and link it in the readme of the labeled directory as algorithm - dataset.

Thank you

@theyashwanthsai i will submit the PR today by evening.


feat: add form-data into packages

Codecov Report

Merging #135 (75db29f) into master (70d9307) will decrease coverage by 8.97%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##           master     #135      +/-   ##
==========================================
- Coverage   96.93%   87.96%   -8.98%
==========================================
  Files          25       27       +2
  Lines         196      216      +20
  Branches       37       41       +4
==========================================
  Hits          190      190
- Misses          5       22      +17
- Partials        1        4       +3

Impacted Files
Coverage Δ

packages/form-data/src/formData.ts
0.00% <0.00%> (ø)

packages/form-data/src/index.ts
0.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 70d9307...75db29f. Read the comment docs.


Update style.css

As i think the background color should be white to make it simple but attractive
Thanks

@ossamamehmood  Thanks for your time to take a look and open PR!
Yes am agree with you.