OpenAPT do not switch the publishings

For the moment I have to do the following inside the CI pipeline else openapt will crash:
- aptly publish drop buster somerepo
- openapt schema.json

Thanks for reporting !
This should be resolved in a261f90.


Mongocreateactivity

I have checked in artifacts for a new activity called InsertDocument.
I have also fixed a couple of minor bugs for other existing activities:

Name change of MongoDB Trigger
Changed datatype of timeout field from int to number in descriptor.json

@skothari-tibco and @fm-tibco Could you both review and provide your comments? Thanks!

I had to push a few bug fixes raised by FE MongoDB QA as part of the PR. Can you check and provide your comments?


react-query | query keys to be statically generated for invalidateQueries()

Is your feature request related to a problem? Please describe.
currently to invalidate certain query on a mutation, i manually check what query key is for targeted queries.
Since key is a string, its easy to  uppercase/lowercase typo.  and there is no warning getting thrown saying that querykey is not used anywhere.
Describe the solution you'd like
Simple solution for this to generate a string variable for queryKey with operationName from AST.
So that variable will be utilised for invalidations and stuff
Describe alternatives you've considered
Additional context

typescript-react-query has a config named exposeQueryKeys to fit your needs
https://www.graphql-code-generator.com/plugins/typescript-react-query


Prepare 0.4.0 release

Following on the request made by Frans-Jan van Steenbeek (see #23 ) to release a new version of the cookbook supporting binary installations there are a couple of things I wanted to add to the discussion:

This should be a minor release since new features will be added.
Even though this feature already includes integration tests a request was made to @salsa-dev to create a pull request with chef specs for additional safety.

As such I have no problem in releasing version 0.4.0 as is. If anyone has anything to add please do so.

I would like to add unit tests for the logic of using a binary or source install. Other than that, it looks fine.
Though in regards to compat_resource - should we add that as a dependency until EOL chef-client 12? - And at that point, we could move this cookbook to 1.0.0 and remove dependencies and the depreciated features?

There is one more issue to discuss before release:
If binary_package option is set to 'netdata-latest.gz.run' (which is the default) NetData will be updated to the latest version available every chef-client run. Thus we have the default autoupdate performed by Chef.
It should be noted in README but before making PR I propose to discuss whether everyone agrees on such a default behaviour.

Regarding "compat_resource" I thought accumulator support from chef-client 12.16.x as noted https://gist.github.com/lamont-granquist/b569d0086d19739ebeb3e8c7ab1d65bc#the-delayed_action-helper
If specifying dependency solves the issue It solves the problem for those having old chef-client in prod (including myself).
+1 to supporting chef-client 12 until EOL.

Having Chef auto-update Netdata to the latest package will definitely be a surprise and I believe the source install got changed to master also? Which makes both of the install methods auto-update?
I don't think it's a bad thing, though if Netdata were to change how they did the installs or changed the packages then the cookbook could fail.
+1 on leaving it auto-updating on default call of netdata_install resource
+1 on supporting chef 12 until EOL
+1 on creating unit tests to check the logic between binary and source installs.


Improving the deployment instructions per Greg's feedback.

This change is

A couple of nit comments.

This is a little weird with now mixing app/instance between what we're talking about, but I think that is okay. Done and done.

Looks really nice now! :+1:


Guild configurations should be configurable via config.yml

Is your feature request related to a problem? Please describe.
As it stands right now, Guild Configurations can only be changed in two ways: With sparse, half-baked commands, and directly modifying database values.
Describe the solution you'd like
While the dashboard is being developed, which is the superior way of going about this, a YAML file is both easy for general uses, and easy to work with programmatically.
Describe alternatives you've considered
INI Files shudders.
Additional context
An example config would be as such:
config: # do not change the names.

  welcome:
    enabled: true
    greet_when:
    greeting: "" # what to say when they've passed requisite verification.
                 # substitutions: {@u} -> Mention the user {u} -> User's username {s} -> Server name
                 # Example: "Welcome to {s}, {@u}! We hope you enjoy your stay! 😄"

  moderation:
    mute_role: 0 # Id of the role

    log:
      channel: 0 # the channel to log to for anything moderation-related
      edits: false
      deletions: false

    word_blacklist: # Words to blacklist. All messages will be scanned for these strings (case insensitive).
      enabled: false
      blacklist:
        - "Example 1"
        - "Exmaple 2"

    anti_invite: # block members from sending invites
      enabled: false # enable anti-invite
      delete_invites: false # whether to delete the message containing an invite
      scan_invites: false # whether to check if invites are valid. Good for servers without vanity urls
      warn_member: false # whether to warn members for sending non-whitelisted invites.
      anti_circumvention: false # false matches discord.gg/ true matches all discord-like invites and common circumventions to auto-mod
      allowed_invites:
        - "discord.gg/foo"
        - "discord.gg/bar"

Side note, I spent far too much time on this.

As nice as this seems from an overall standpoint, a config command would be miles better. Good excuse to get working on the IInputService anwyay


KCP CLI: Operation type missing in JSON output of kcp rc info command

Description
The KCP CLI should also include the type of an operation in the JSON view of a reconciliation. Currently operations don't include a type field:
  kcp rc info --scheduling-id 2f7b6dbe-8328-45ec-936c-58e5d1df9f71--cd16472b-b17d-4c4b-a9d9-7676b81138a4 -o json
  {
    "configVersion": 30136,
    "created": "2022-02-10T07:48:32.866951Z",
    "finished": true,
    "operations": [
      {
        "component": "CRDs",
        "correlationID": "2f7b6dbe-8328-45ec-936c-58e5d1df9f71--b7137357-1910-4fc3-9335-116db4e53d4f",
        "created": "2022-02-10T07:48:32.866951Z",
        "priority": 1,
        "reason": "context deadline exceeded",
        "schedulingID": "2f7b6dbe-8328-45ec-936c-58e5d1df9f71--cd16472b-b17d-4c4b-a9d9-7676b81138a4",
        "state": "error",
        "updated": "2022-02-10T07:59:00.798949Z"
      },
  ...
  }

The operation-type defines whether it is a delete or reconcile operation.
Expected result
Operation type is shown in KCP CLI output.
Actual result
Operation type is not part of the JSON output when requesting the details of a reconciliation.
Steps to reproduce

Troubleshooting

I'm testing on dev landscape and see empty type in json response

Thanks @moelsayed. It works


tf.keras: Error in BinaryCrossentropy loss when output shape is determined by inputs

Please make sure that this is a bug. As per our GitHub Policy, we only address code/doc bugs, performance issues, feature requests and build/installation issues on GitHub. tag:bug_template
System information

Have I written custom code (as opposed to using a stock example script provided in TensorFlow): Yes
OS Platform and Distribution (e.g., Linux Ubuntu 16.04): ArchLinux
Mobile device (e.g. iPhone 8, Pixel 2, Samsung Galaxy) if the issue happens on mobile device: No
TensorFlow installed from (source or binary): Source
TensorFlow version (use command below): v2.0.0-beta1-4983-g65e6355ad9 2.0.0-rc0
Python version:
Bazel version (if compiling from source): bazel 26.1
GCC/Compiler version (if compiling from source):
CUDA/cuDNN version: N/A
GPU model and memory: N/A

You can collect some of this information using our environment capture
script
You can also obtain the TensorFlow version with: 1. TF 1.0: python -c "import tensorflow as tf; print(tf.GIT_VERSION, tf.VERSION)" 2. TF 2.0: python -c "import tensorflow as tf; print(tf.version.GIT_VERSION, tf.version.VERSION)"
Describe the current behavior
Shape mismatch for binary cross-entropy with logits for compiled Keras  when output shape is determined by model inputs (no error when using eager-evaluation):
ValueError: logits and labels must have the same shape ((None,) vs (None, 1))

Describe the expected behavior
No shape mismatch
Code to reproduce the issue
Provide a reproducible test case that is the bare minimum necessary to generate the problem.
import tensorflow as tf
import numpy as np

inputs = tf.keras.Input(shape=(1,), dtype=tf.int64)
outputs = tf.random.normal(shape=(inputs[0, 0],))

model = tf.keras.Model(inputs, outputs)
model.compile(optimizer='sgd', loss=tf.keras.losses.BinaryCrossentropy(from_logits=True))

dummy = np.zeros((10, 1))
shapes = np.random.randint(0, 11, 10).reshape(10, 1, 1)
dataset = tf.data.Dataset.from_tensor_slices(shapes)
dataset = dataset.map(lambda x: (x, tf.random.uniform(minval=0, maxval=2, shape=(x[0,0],), dtype=tf.int32)))

# eagar mode, works
loss = tf.keras.losses.BinaryCrossentropy(from_logits=True)
for inputs, true in dataset:
    pred = model(inputs)
    print(true)
    print(pred)
    print(loss(true, pred))
    break

# compiled model, fails
model.fit(dataset, epochs = 1, steps_per_epoch=1)

Other info / logs
Include any logs or source code that would be helpful to diagnose the problem. If including tracebacks, please include the full traceback. Large logs and files should be attached.
Traceback (most recent call last):
  File "/usr/lib/python3.7/site-packages/tensorflow_core/python/framework/tensor_shape.py", line 928, in merge_with
    self.assert_same_rank(other)
  File "/usr/lib/python3.7/site-packages/tensorflow_core/python/framework/tensor_shape.py", line 983, in assert_same_rank
    (self, other))
ValueError: Shapes (None, 1) and (None,) must have the same rank

During handling of the above exception, another exception occurred:

Traceback (most recent call last):
  File "/usr/lib/python3.7/site-packages/tensorflow_core/python/ops/nn_impl.py", line 168, in sigmoid_cross_entropy_with_logits
    labels.get_shape().merge_with(logits.get_shape())
  File "/usr/lib/python3.7/site-packages/tensorflow_core/python/framework/tensor_shape.py", line 934, in merge_with
    raise ValueError("Shapes %s and %s are not compatible" % (self, other))
ValueError: Shapes (None, 1) and (None,) are not compatible

During handling of the above exception, another exception occurred:

Traceback (most recent call last):
  File "test.py", line 25, in <module>
    model.fit(dataset, epochs = 1, steps_per_epoch=1)
  File "/usr/lib/python3.7/site-packages/tensorflow_core/python/keras/engine/training.py", line 736, in fit
    use_multiprocessing=use_multiprocessing)
  File "/usr/lib/python3.7/site-packages/tensorflow_core/python/keras/engine/training_v2.py", line 307, in fit
    total_epochs=epochs)
  File "/usr/lib/python3.7/site-packages/tensorflow_core/python/keras/engine/training_v2.py", line 121, in run_one_epoch
    batch_outs = execution_function(iterator)
  File "/usr/lib/python3.7/site-packages/tensorflow_core/python/keras/engine/training_v2_utils.py", line 84, in execution_function
    for out in distributed_function(input_fn)]
  File "/usr/lib/python3.7/site-packages/tensorflow_core/python/eager/def_function.py", line 427, in __call__
    self._initialize(args, kwds, add_initializers_to=initializer_map)
  File "/usr/lib/python3.7/site-packages/tensorflow_core/python/eager/def_function.py", line 370, in _initialize
    *args, **kwds))
  File "/usr/lib/python3.7/site-packages/tensorflow_core/python/eager/function.py", line 1834, in _get_concrete_function_internal_garbage_collected
    graph_function, _, _ = self._maybe_define_function(args, kwargs)
  File "/usr/lib/python3.7/site-packages/tensorflow_core/python/eager/function.py", line 2134, in _maybe_define_function
    graph_function = self._create_graph_function(args, kwargs)
  File "/usr/lib/python3.7/site-packages/tensorflow_core/python/eager/function.py", line 2025, in _create_graph_function
    capture_by_value=self._capture_by_value),
  File "/usr/lib/python3.7/site-packages/tensorflow_core/python/framework/func_graph.py", line 884, in func_graph_from_py_func
    func_outputs = python_func(*func_args, **func_kwargs)
  File "/usr/lib/python3.7/site-packages/tensorflow_core/python/eager/def_function.py", line 320, in wrapped_fn
    return weak_wrapped_fn().__wrapped__(*args, **kwds)
  File "/usr/lib/python3.7/site-packages/tensorflow_core/python/keras/engine/training_v2_utils.py", line 71, in distributed_function
    per_replica_function, args=(model, x, y, sample_weights))
  File "/usr/lib/python3.7/site-packages/tensorflow_core/python/distribute/distribute_lib.py", line 760, in experimental_run_v2
    return self._extended.call_for_each_replica(fn, args=args, kwargs=kwargs)
  File "/usr/lib/python3.7/site-packages/tensorflow_core/python/distribute/distribute_lib.py", line 1787, in call_for_each_replica
    return self._call_for_each_replica(fn, args, kwargs)
  File "/usr/lib/python3.7/site-packages/tensorflow_core/python/distribute/distribute_lib.py", line 2132, in _call_for_each_replica
    return fn(*args, **kwargs)
  File "/usr/lib/python3.7/site-packages/tensorflow_core/python/autograph/impl/api.py", line 292, in wrapper
    return func(*args, **kwargs)
  File "/usr/lib/python3.7/site-packages/tensorflow_core/python/keras/engine/training_v2_utils.py", line 299, in train_on_batch
    output_loss_metrics=model._output_loss_metrics)
  File "/usr/lib/python3.7/site-packages/tensorflow_core/python/keras/engine/training_eager.py", line 307, in train_on_batch
    output_loss_metrics=output_loss_metrics))
  File "/usr/lib/python3.7/site-packages/tensorflow_core/python/keras/engine/training_eager.py", line 252, in _process_single_batch
    training=training))
  File "/usr/lib/python3.7/site-packages/tensorflow_core/python/keras/engine/training_eager.py", line 166, in _model_loss
    per_sample_losses = loss_fn.call(targets[i], outs[i])
  File "/usr/lib/python3.7/site-packages/tensorflow_core/python/keras/losses.py", line 216, in call
    return self.fn(y_true, y_pred, **self._fn_kwargs)
  File "/usr/lib/python3.7/site-packages/tensorflow_core/python/keras/losses.py", line 989, in binary_crossentropy
    K.binary_crossentropy(y_true, y_pred, from_logits=from_logits), axis=-1)
  File "/usr/lib/python3.7/site-packages/tensorflow_core/python/keras/backend.py", line 4449, in binary_crossentropy
    return nn.sigmoid_cross_entropy_with_logits(labels=target, logits=output)
  File "/usr/lib/python3.7/site-packages/tensorflow_core/python/ops/nn_impl.py", line 171, in sigmoid_cross_entropy_with_logits
    (logits.get_shape(), labels.get_shape()))
ValueError: logits and labels must have the same shape ((None,) vs (None, 1))

@deasmhumhna
The code seems to work fine in 2.0.0-beta1

I'm technically using Tensorflow 2.0.0-rc0, built from source.
Here's another, somewhat cleaner version using dataset_from_generator:
import numpy as np

print('Tensorflow', tf.__version__)

inputs = tf.keras.Input(shape=(1,), dtype=tf.int32)
outputs = tf.random.normal(
    shape=(tf.reduce_max(inputs) - tf.reduce_min(inputs) + 1,))

model = tf.keras.Model(inputs, outputs)
model.compile(optimizer='sgd',
              loss=tf.keras.losses.BinaryCrossentropy(from_logits=True))

x = np.random.randint(1, 10, 100).reshape(10, 10)
ysize = x.min(axis=-1)

def gen():
    while True:
        x = np.random.normal(5, 10, size=(5, 1)).astype('i4')
        y = np.random.randint(0, 2, size=int(np.ptp(x) + 1)).astype('i4')
        yield (x, y)

dataset = tf.data.Dataset.from_generator(
    gen, output_types=(tf.int32, tf.int32),
    output_shapes=(tf.TensorShape([5, 1]), tf.TensorShape([None])))

# eagar mode, works
loss = tf.keras.losses.BinaryCrossentropy(from_logits=True)
for inputs, true in dataset:
    pred = model(inputs)
    print(true.shape)
    print(pred.shape)
    print(loss(true, pred))
    break

# compiled model, fails
model.fit(dataset, epochs = 1, steps_per_epoch=1)

I'm re-building tensorflow right now. I'll see if that helps.

@deasmhumhna ,
When tried executing the code in TF-2.0.0beta1 and 1.14 worked fine. Any update on the issue after you re-building the TF?Thanks!

I haven't finished re-building yet, but I keep getting strange errors with @tf.function that aren't even consistent across models/files (simple models pass, but complex models break the same training loops, simple and complex nested models give different errors, etc). I suspect something might be wrong with the Autograph files in my build. In the meantime, I might just reinstall the pip build of Tensorflow 2.0.

@deasmhumhna ,
Any update after tried rebuilding TF?Thanks!

Automatically closing due to lack of recent activity. Please update the issue when new information becomes available, and we will reopen the issue. Thanks!


Checker framework 2.3.2 fixes

Hi Michael,
I tried out Glacier after you mentioned in to me at Dagstuhl.  I'm using checker framework 2.3.2 so I had to make some updates to Glacier to get it compiling against 2.3.2.  Those changes are fairly trivial I think, but getting the Glacier tests working with 2.3.2 involves some more changes.  See the commit comment on the last commit (35d2a3d) for a detailed explanation, so you can judge if you think it should be done differently.  After all these changes, Glacier compiles and passes all tests with checker-framework 2.3.2.
Thanks,
Neil.

Thanks, Neil! I restored two @Override annotations because removing them didn't seem necessary. Could you please make sure everything works for you too?


vs code don't open erroe

Issue Type: Bug
when i start the vscode i need to wiat for sometimes because it will prompt me that unable to load vs code please reopen it or close it.
VS Code version: Code 1.55.2 (3c4e3df9e89829dce27b7b5c24508306b151f30d, 2021-04-13T09:35:57.887Z)
OS version: Windows_NT x64 10.0.19042

Can you show me a screenshot of that prompt?


Unhandled Exception in Connection Loop: RuntimeError: ('xids do not match, expected %r received %r', 28, 27)

Two days ago we upgraded our servers from Kazoo 1.3.1 -> Kazoo 2.0. We started seeing a 10x increase in the number of connection failures ... and the recovery of those connections is far worse too. It looks like we're seeing a new exception being raised that we did not see before.
        "stack_trace": [
            "Traceback (most recent call last):",
            "  File '/mnt/.venv/lib/python2.7/site-packages/kazoo/protocol/connection.py', line 531, in _connect_attempt",
            "    response = self._read_socket(read_timeout)",
            "  File '/mnt/.venv/lib/python2.7/site-packages/kazoo/protocol/connection.py', line 407, in _read_socket",
            "    return self._read_response(header, buffer, offset)",
            "  File '/mnt/.venv/lib/python2.7/site-packages/kazoo/protocol/connection.py', line 338, in _read_response",
            "    'received %r', xid, header.xid)",
            "RuntimeError: ('xids do not match, expected %r received %r', 28, 27)"

This is being caught by kazoo.client and throwing the Unhandled exception in connection loop error. I'm completely stumped, I can't seem to replicate this in my own dev environment... and it only happens sporadically in production.

bump @diranged any updates per above?
Is it still reproducible?


New guide/tutorial: How to change the token prefix from LSK to a custom prefix

Description
Explain: Each blockchain app (v5) is natively using their own utility token (unnamed)

How to change the token prefix from LSK to a custom prefix
How to create addresses with custom prefix (not ""lsk"")"

Motivation
This is a common task any sidechain developer would like to do at some point.
Additional information
https://lisk.com/documentation/lisk-sdk/references/lisk-elements/cryptography.html#getbase32addressfrompublickey you can use custom prefix
The core idea for Lisk is that instead of trying your idea as a smart contract with erc20 tokens to a running chain at Lisk you create your own chain and connect it to the Mainchain hosting the LSK tokens. This comes with the benefit of being able to build much more complex onchain solutions than possible on e.g. Ethereum. But of course even on a sidechain people would want implement something erc20 style for their sidechain. This is also possible and actually quite simple - we've seen people prototyping this in a matter of 3-5 days. There are GitHub projects showcasing this. But what I find more convincing is that a fungible token Module is being developed as we speak by LiskHQ and is going to be included in the next release.

Decision was to use the same address in the ecosystem, so this is will be closed


feat: update novelty sampler to work with pd.DataFrames

with @blinodelka

In the novelty_score_sample function, we append a score to the return value that is not part of the condition. Wrapping in the wrap_to_use_state would lead to an additional column in the condition field of the state. We should figure out a way to deal with functions that return additional things that are not part of a state field.

We should figure out a way to deal with functions that return additional things that are not part of a state field.

This will conflict with the idea that the results of an experimentalist have to have a spot on the State – sometimes they just need to be discarded.

Or we make this explicit in the wrapper. If the user explicitly wants to discard return values from functions, they have to make that explicit when wrapping the function.


PMM-11768 Add test that verify PostgreSQL exporter ignores connection error to "rdsadmin" database for Amazon RDS instance

Positive run for dev latest:
https://pmm.cd.percona.com/blue/organizations/jenkins/pmm2-ui-tests/detail/pmm2-ui-tests/30412/pipeline/
Negative run for 2.34.0
https://pmm.cd.percona.com/blue/organizations/jenkins/pmm2-ui-tests/detail/pmm2-ui-tests/30413/pipeline

@peterSirotnak  any idea why RBAC tests are failing?

@peterSirotnak any idea why RBAC tests are failing?

@puneet0191 Looks like there was change of string, i will fix it.


Review TeamCreation.jsx and TeamInvitationsWidget.jsx

Files to Review
TeamCreation.jsx
TeamInvitationsWidget.jsx
Checklists
Architecture
Design
JS
React
Testing
Due Date
Monday, October 9, 9:00 AM
For more information
The review process is documented at: http://courses.ics.hawaii.edu/ics414f23/morea/review/reading-idpm-review.html

TeamCreation.jsx
DE-03: L60, 76, 81, 124, 132, 136, 139, 144
JS-04: L51
JS-05: L151-153
TeamInvitationsWidget.jsx
JS-05: L63, 75, 78, 90, 93, 105, 108, 120, 123, 151-154
RE-06: 180-194 define constants in withTracker()
RE-09
RE-10

TeamCreation.jsx
JS-04 & RE-09: L29
JS-05: L151,152,153
JS-06: L60, 76, 81, 124, 132, 136, 139, 144
#TeamInvitationsWidget.jsx
JS-04 & RE-09: L51
JS-05: L75, 90, 105, 120

outcome
TeamCreation.jsx

remove logs
lodash
bootstrap instead of semantic ui
use function component

useRef

use checkbox instead of radio
use useTracker instead of withTracker
add a test

TeamInvitationsWidget.jsx

remove unused variables

lodash

bootstrap

function component

useTracker

add collection subscriptions and return a field like "ready"

test

getSomething functions could use a filter instead of

const data = [];
...js
return data;

TeamCreation.jsx
DE-05: L60, L76, L108, L124, L139, L144
JS-04 L84 & L92
JS-05: L151-153
TeamInvitationsWidget.jsx
RE-09
JS-05: L75, L90, L105, L120


Query offers in Cosmos DB

Package Name:  @azure/cosmos
Package Version: new
Operating system: windows
[ ] nodejs

version:  any

[ ] browser

name/version:

[ ] typescript

version:

Is the bug related to documentation in

[ ] SDK API docs on https://docs.microsoft.com
createIfNotExists returns database object not databaseResponse . need to correct https://docs.microsoft.com/en-us/javascript/api/@azure/cosmos/databases?view=azure-node-latest#createifnotexists-databaserequest--requestoptions-

Describe the bug
A clear and concise description of what the bug is.
trying to query offers as mentioned at below link but getting undefined
https://docs.microsoft.com/en-us/rest/api/cosmos-db/querying-offers
const {resources: offers} = await client.offers.query({query :"SELECT * FROM root WHERE (root[\"_self\"] = \""+ resourceUrl+"\") "});

To Reproduce
Steps to reproduce the behavior:

https://gist.github.com/prashanthmadi/287acd7361567e812d3882ae3c07a115#file-update_offer_cosmos_sqlapi-js-L29

Expected behavior
return offers..
Screenshots
If applicable, add screenshots to help explain your problem.
Additional context
Add any other context about the problem here.

@prashanthmadi There are a couple of issues. 1) Your code is missing a fetchAll() to actually execute the query 2) I think the doc page you linked is incorrect about the query contents. Here is the working snippet:
  const { resources: offers } = await client.offers
    .query({
      query: `SELECT * FROM root WHERE root.resource = "${resourceUrl}"`,
    })
    .fetchAll();

@zfoster Two tasks for your list. 1. Update the doc page 2. We should add a readOffer() method to Container and Database that does this query operation on behalf of the user

@prashanthmadi Also, thanks for the detailed reproduction! Helped me track this down really quickly

Thanks @southpolesteve ... it worked with changes you have suggested.. updated my sample
@ https://gist.github.com/prashanthmadi/287acd7361567e812d3882ae3c07a115
one more ask,
createIfNotExists returns database object not databaseResponse . need to correct it at below doc .. https://docs.microsoft.com/en-us/javascript/api/@azure/cosmos/databases?view=azure-node-latest#createifnotexists-databaserequest--requestoptions-

@prashanthmadi Those docs are auto-generated from the types. Is there something wrong there? https://github.com/Azure/azure-sdk-for-js/blob/83fcc44a23ad771128d6e0f49043656b3d1df990/sdk/cosmosdb/cosmos/src/client/Database/Databases.ts#L140-L143

We added support for readOffer to container and database in https://github.com/Azure/azure-sdk-for-js/pull/8704


Create Reverse of Lists.py

Added A File In Arrays Folder.
Hope It Helps.
Please Accept The Pull Request
Then Only It Will Merge

I think it's done
On Oct 1, 2020 at 01:39, Ankit Kumar<EMAIL_ADDRESS>wrote:
Merged #2
https://github.com/AnkitKumar1311/Data-Structures-And-Algorithms/pull/2
into master.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/AnkitKumar1311/Data-Structures-And-Algorithms/pull/2#event-3826258589,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/ARB3QCGFQFMFAU6UNNC3LWTSIOGA3ANCNFSM4R7QUHZQ
.

Yes I have merged your changes already.

Ok
On Oct 1, 2020 at 13:25, Ankit Kumar<EMAIL_ADDRESS>wrote:
Yes I have merged your changes already.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/AnkitKumar1311/Data-Structures-And-Algorithms/pull/2#issuecomment-701960306,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/ARB3QCEY7M7BO3ZPVLI6G4TSIQYYFANCNFSM4R7QUHZQ
.


test singularlity setup

https://gitlab.mn.tu-dresden.de/bia-pol/singularity-devbio-napari

the singularity container with tag v0.2.9 does not contain torchvision
the singularity container with tag 'pol-course-pytorch' appears to work


Includes of a page will not be reused if the page will included on another page

Describe the Bug
If i have a page with includes from another page and i try to reuse this page also as an include on another Page. The includes from the page will not be resolved. Only showing the include tags.
Also i another way of explanation:
Page A includes a section of Page B -> it works the include will be resolved.
Page C includes now Page A -> Page A is resolved but the include of Page B will not be resolved on Page C
i hope this was clear
Steps to Reproduce

reuse page b on page a
reuse page a on page c
you will see that the page b content will not be resolved on page c

Expected Behaviour
the expected behaviour ist that the resolving of the content works also if i reuse a page which already have includes from another page.
Screenshots or Additional Context

Browser Details
No response
Exact BookStack Version
v23.02.1
PHP Version
No response
Hosting Environment
as Container on a kubenetes Cluster.
Application is working fine only a content reuse issue

Thanks for raising, but this is not a bug, but the include feature has been built to only include a single level.
A request for nested includes is already open in #2845 so I'll close this off.


ISSUE 2.2.0 : kob installation uninstallation commands malfunction

We regret for the issue that you are facing, Thanks for helping us by raising an issue so that we can improve ourself to do the best.
Please tick one according to the issue you are facing with:

[ ] Issue facing with installation or setup.
[ ] Issue facing while running a environment.
[x] Issue facing while adding a new environment or new file.
[ ] Other issues: please provide the issue in the comment box

Please explain the Issue / Feature Request here:
   kob install & kob uninstall command malfunction

Please provide the necessary screenshots or documents regarding the issue:
   blockchain@blockchain-VirtualBox:~$ kob uninstall --dev tob
   TheOrgBook - Uninstalling...
   bash: cd: /home/blockchain/Dev_TOB: Permission denied
   blockchain@blockchain-VirtualBox:~$

   blockchain@blockchain-VirtualBox:~$ kob install --dev kobman EtricKombat
   Installing KOBMAN
   Building kobman from

   Cloning into 'KOBman'...
   Username for 'https://github.com': ^Z
   [1]+  Stopped                 sudo git clone https://github.com/${kobman_namespace}/KOBman.git

Solution :
The issue around  kob install --dev kobman {namespace}  was resolved by making the listed modification on the function call at  "KOBman/src/main/bash/commands/kobman-install.sh":
Before
     __kobman_install_kobman

After
        __kobman_install_kobman "$name_space"

Solution :
The issue around  kob uninstall --dev kobman  was resolved by making the listed modification on the function body  at  "KOBman/src/main/bash/env/kobman-tob.sh":
Added a new line to the function __kobman_uninstall_tob
    sudo chmod a+x ${KOBMAN_TOB_DEV_DIR}


Introduce "Name" as a standard property on SpeckleObject

Proposed Spec Change
Introduce "Name" as a standard property on SpeckleObject and connect this to the "name" property (Group.name and Component.name).

housekeeping update - this was resolved some time ago in the spec


Restore fix auto-start issue on Android O.

As per comment in #303 I realised removing this code was a mistake. I did no realise that it was different to the SDK version of the class. This reverts the removal of the custom WakefulBroadcastReceiver. I have also renamed startWakefulService to startWakefulForegroundService to highlight that it's different to the SDK version.

Thanks.


[GetPage] toNamed not working when used with nested route

ATTENTION: DO NOT USE THIS FIELD TO ASK SUPPORT QUESTIONS. USE THE PLATFORM CHANNELS FOR THIS.
Fill in the template. Issues that do not respect the model will be closed.
Describe the bug
The method Get.toNamed('some/route') does not work on nested route.
Reproduction code
NOTE: THIS IS MANDATORY, IF YOUR ISSUE DOES NOT CONTAIN IT, IT WILL BE CLOSED PRELIMINARY)

main.dart
void main() {
  runApp(
    GetMaterialApp(
      title: 'GPR',
      debugShowCheckedModeBanner: false,
      initialRoute: AppPages.INITIAL,
      getPages: AppPages.routes,
    ),
  );
}

app_pages.dart
import 'package:get/get.dart';

import 'page_a.dart';
import 'page_b.dart';
import 'page_c.dart';

part 'app_routes.dart';

class AppPages {
  static const INITIAL = Routes.PAGE_A;

  static final routes = [
    GetPage(
      name: Routes.PAGE_A,
      page: () => PageA(),
      children: [
        GetPage(
          name: Routes.PAGE_B,
          page: () => PageB(),
          children: [
            GetPage(
              name: Routes.PAGE_C,
              page: () => PageC(),
            ),
          ],
        ),
      ],
    ),
  ];
}

app_routes.dart
part of 'app_pages.dart';

abstract class Routes {
  // static const PAGE_A = '/a';
  // static const PAGE_B = '$PAGE_A/b';
  // static const PAGE_C = '$PAGE_B/c';

  static const PAGE_A = '/a';
  static const PAGE_B = '/a/b';
  static const PAGE_C = '/a/b/c';
}

page_a.dart
import 'package:flutter/material.dart';
import 'package:get/get.dart';
import 'package:getx_getpage_issue/app_pages.dart';

class PageA extends GetView {
  @override
  Widget build(BuildContext context) {
    return Scaffold(
      body: Center(
        child: Column(
          mainAxisSize: MainAxisSize.max,
          mainAxisAlignment: MainAxisAlignment.center,
          children: [
            Text('page A'),
            RaisedButton(
              child: Text('to page B'),
              onPressed: () => Get.toNamed(Routes.PAGE_B),
            ),
          ],
        ),
      ),
    );
  }
}

page_b.dart
import 'package:flutter/material.dart';
import 'package:get/get.dart';
import 'package:getx_getpage_issue/app_pages.dart';

class PageB extends GetView {
  @override
  Widget build(BuildContext context) {
    return Scaffold(
      body: Center(
        child: Column(
          mainAxisSize: MainAxisSize.max,
          mainAxisAlignment: MainAxisAlignment.center,
          children: [
            Text('page B'),
            RaisedButton(
                child: Text('to page C'),
                onPressed: () => Get.toNamed(Routes.PAGE_C)),
          ],
        ),
      ),
    );
  }
}

page_c.dart
import 'package:flutter/material.dart';
import 'package:get/get.dart';

class PageC extends GetView {
  @override
  Widget build(BuildContext context) {
    return Scaffold(
      body: Center(
        child: Column(
          mainAxisSize: MainAxisSize.max,
          mainAxisAlignment: MainAxisAlignment.center,
          children: [
            Text('page C'),
            RaisedButton(child: Text('back'), onPressed: () => Get.back()),
          ],
        ),
      ),
    );
  }
}

To Reproduce
Steps to reproduce the behavior:

Make a new flutter project, add get on pubspec.yaml
Make each file mentioned above, and copy paste the content, adjust the import 'package:getx_getpage_issue' to yours
Run the app, click the button
See error

Expected behavior
It should be redirected to page B, and then in page B, it should be able to go to page C, and so forth.
Screenshots
Scenario 1 using Routes.NAME

click here to see

Scenario 2 hardcoded.

click here to see

Scenario 3 similar to Scenario 1 but with /a, /b, /c independently instead of /a, /a/b, a/b/c

click here to see

Flutter Version:
Flutter 1.22.5 • channel stable • https://github.com/flutter/flutter.git
Framework • revision<PHONE_NUMBER> (5 days ago) • 2020-12-10 11:54:40 -0800
Engine • revision ae90085a84
Tools • Dart 2.10.4

Getx Version:
get: ^3.23.0
Describe on which device you found the bug:
ex: Android 10 - (Xiaomi Redmi Note 7, codename: Lavender)
Minimal reproduce code
onPressed: () => Get.toNamed(Routes.PAGE_B)
or
onPressed: () => Get.toNamed('/a/b')
or
onPressed: () => Get.toNamed('/b')

When you insert a nested page, to access it, you must enter the full path, as well as a browser URL.
so if "c" is a child of "b" which is a child of "a", you access it with Get.toNamed ('a/b/c')

The library combines automatically the parents routes with the children routes.
So you defined this tree

/a

/a/b
/a/b/c

And this tree is built

/a
/a/a/b
/a/a/b/a/b/c

If you what a tree like you definition you have to define the routes like this.
-/a

/b

/c

When you insert a nested page, to access it, you must enter the full path, as well as a browser URL.
so if "c" is a child of "b" which is a child of "a", you access it with Get.toNamed ('a/b/c')

so it needs some kind of http:// prefix? @jonataslaw

If you what a tree like you definition you have to define the routes like this.
-/a

/b

/c

i think i did it already, you can see it on scenario 3's image @SchabanBo

@pratamatama i meant when you define the routes, not when you navigate.
i have replaced your routes with this
  static final routes = [
    GetPage(
      name: '/a',
      page: () => PageA(),
      children: [
        GetPage(
          name: '/b',
          page: () => PageB(),
          children: [
            GetPage(
              name: '/c',
              page: () => PageC(),
            ),
          ],
        ),
      ],
    ),
  ];

and tested it. and it works as expected

@pratamatama i meant when you define the routes, not when you navigate.
i have replaced your routes with this
  static final routes = [
    GetPage(
      name: '/a',
      page: () => PageA(),
      children: [
        GetPage(
          name: '/b',
          page: () => PageB(),
          children: [
            GetPage(
              name: '/c',
              page: () => PageC(),
            ),
          ],
        ),
      ],
    ),
  ];

and tested it. and it works as expected

@SchabanBo I don't get it, isn't it just the same as this?
// extracted from scenario 3
abstract class Routes {
    static const PAGE_A = '/a';
    static const PAGE_B = '/b';
}
...

GetPage(
    name: Routes.PAGE_A, // '/a'
    page: () => PageA(),
    children: [
        GetPage(
            name: Routes.PAGE_B,  // '/b'
            page: () => PageB(),
            children: [...],  // '/c'
        ),
    ],
),

when you changed it in Scenario 3 you made it right in the tree but then you have navigated to the wrong route /b you should navigate to /a/b

when you changed it in Scenario 3 you made it right in the tree but then you have navigated to the wrong route /b you should navigate to /a/b

aaaa... so this was the problem, I thought Get.toNamed will add the prefix under the hood. I see clear now

I've just tested it, works fine. Thanks for the support. Gonna close this issue now.


Delay animation

Hi I'm curious if it's possible to delay first slide animation. I've got two sliders next to each other and I want the same animation speed and interval, but I need one of them to start a bit later.
Thanks for your help.

Hi @sarnecki-cic ,
Thanks for the suggestion I also faced the same problem. I will implement this feature and push the update

@sarnecki-cic ,
This feature is now implemented. read this release

@sarnecki-cic This changes is now in latest version. Thanks


Stop eating food if you drop it

About the PR

Stops the do-after for eating/drinking things if you drop the item from your hands
Why / Balance

I'm tired of having to run away from my food to stop eating it, or accidentally eating papers in my hands
Technical details

Sets the NeedHand argument for the do-after to true if the item started out in the user's hands
Media

[x] I have added screenshots/videos to this PR showcasing its changes ingame, or this PR does not require an ingame showcase

https://github.com/space-wizards/space-station-14/assets/58439124/5f457fd7-db71-4bdc-a7bf-2fa8747e87e8
Breaking changes

Changelog

:cl:

fix: You can now drop food to stop eating it.

test fail is TryStopNukeOpsFromConstantlyFailing, one day..... one day it'll stop failing

The copy paste disgusts me but that's not your fault so.

between the food and drink systems? yeah I don't really understand why they're separate despite doing the same thing

We need something Ike this for drinking too. Really kills the immersion when you're trying to sip a drink on the bar and you just go full chug every time.
"chug" should be like an option instead of the default

We need something Ike this for drinking too. Really kills the immersion when you're trying to sip a drink in the bar and you just go full chug every time.
"chug" should be like an option instead of the default

drinks are included in the PR

We need something Ike this for drinking too. Really kills the immersion when you're trying to sip a drink in the bar and you just go full chug every time.
"chug" should be like an option instead of the default

drinks are included in the PR

Oh dang, I missed that!


MYSQL / MongoDB Doc

I frenquently use MYSQL or MongoDB for my websites, APIs and other and I would like to use these with Perfect.. But we haven't docs for these Connectors

+1 I'm trying to use MongoDB Connector but can't link it to my module.
I think the following error:
error: module 'MongoDB' has no member named ‘MongoClient'

@TheAbstractDev The best way to go is to check the tests in the connectors.

I've updated the ReadMe on the Perfect-MongoDB repo (https://github.com/PerfectlySoft/Perfect-MongoDB) to include a "Quick Start" and some sample code.

The MySQL and PGSQL will follow shortly!


Add an option to conditionally perform upgrade

Passing proxy.performUpgrade: false allows not running the changeImplementation/upgradeTo
transaction. This supports deployments where the owner is a multisig and changing implementation requires
approvals / multiple signatures out of band. We can still deploy the implementation and
and save the deployment in a way that hardhat-deploy expects / makes etherscan
verification work, but the actual upgrade can be performed separately.

You can do this right now using await catchUnknownSigner()
See https://github.com/wighawag/hardhat-deploy/blob/09c1ad5968663112450a125b23b33279ada1a3dc/src/helpers.ts#L2122

Using catchUnknownSigner would prevent the error but wouldn't write out the updated proxy deployment file since the error is thrown before the proxy deployment is updated. Ideally we would get the changes to the proxy deployment file too (implementation, upgradeIndex, etc), without having to re-run the deploy script, since we sometimes have other actions in our deploy scripts that aren't idempotent.
This PR would support that, but if there's another way to achieve this / another direction to go in, I'm open to it

been thinking of an option where it would pause execution ask you to perform the upragde (or any tx that requires an external signer) and then allow you to continue after you perform the operation
Your solution can be achieved by checking if the contract exist and skip the call to deploy, no ?

Honestly, what would be great is to be able to optionally pass in an "upgrade handler" that controls / performs the upgrade i.e. the function signature is:
(proxyAddress: string, implementationAddress: string) => Promise<void>

and, if not passed in, defaults to the existing upgrade logic in hardhat-deploy that runs upgradeMethod/upgradeToAndCall and uses the available signer. If the promise succeeds, hardhat-deploy should treat the implementation as "upgraded". That way, the user has maximal flexibility in deciding how the upgrade should be performed (and hardhat-deploy could potentially provide other plug-and-play strategies). In our case, we batch all of the upgrade calls into a multisend and execute it at the end of the deployment to produce as few transactions as possible. We would use the upgrade handler to add the upgrade tx to a list for batching later.
If you think this would be a viable direction, I'd be happy to put up another PR

I like that, one thing that this should is replay the deployment, after the promise resolve (this way hardhat-deploy can automatically update the deployments file)
the promise could also resolve to a tx hash that hardhat-deploy can then wait for
or it could also resolve to a deployment object so hardhat-deploy can save it.
Need to think about it more and usual implementation work help to see what's best

@wighawag was there any method like this added in?
I also have a similar use case, we use a safe for ownership on our proxies after initial deploy, my use case here is to deploy an implementation only (and update the hardhat-deploy info) and then run a defender propose upgrade.


Pjax is not working properly on mobile chrome.

Hello! I found a problem.
On mobile chrome, when I touched browser's history navigation buttons (back, forward), pjax is not working properly. It works full reload.

pjax version: 0.2.5, 0.2.7
device: iPhone 7 / 8
iOS version: 12.0 (16A366)
mobile chrome version: 70.0.3538.75

Can you give some more details about what's not working? Or better yet, can you provide a codepen reproducing the issue?

In this codes,

        on(window, "popstate", function(st) {

            if (st.state) {
                var opt = clone(this.options)
                opt.url = st.state.url
                opt.title = st.state.title
                // Since state already exists, prevent it from being pushed again
                opt.history = false
                opt.scrollPos = st.state.scrollPos
                if (st.state.uid < this.lastUid) {
                    opt.backward = true
                }
                else {
                    opt.forward = true
                }
                this.lastUid = st.state.uid

                // @todo implement history cache here, based on uid
                this.loadUrl(st.state.url, opt)
            }
        }.bind(this))

On pc chrome, event handler is called. On mobile chrome, event handler is not called.

What about in mobile Safari?

In mobile Safari, it works normally.

This appears to be a reported issue with Chrome on iOS (see here, here, and here). I don't think there's anything we can do.
Although I haven't seen reports of it being an issue in iOS Safari, I personally had the same issue in Safari as well. MDN says that popstate has limited support in iOS Safari, so it's possible that this is one of the issues.


Fixes #962 typo in javascript

Fixes #962 typo in javascript referring to createDate when it should be createData.

well that's embarrassing lol, thanks


feat: cast JSValue from/to u64

This PR tries to add support for JSValue::as_u64, and JSValue::from_u64. I can't seem to get it to a functioning state though.
In Chrome 86 (with experimental wasm features enabled) my attempts fail the error below. I don't understand why this happens though. I would understand this error if this occurred on a exported function (because of the disallowed i64 type in the function signature). But as that is not the case (function never directly touches JS), I don't get it.
TypeError: wasm function signature contains illegal type
            at wasm_bindgen::JsValue::from_u64::h34ae9b79359a621f (<anonymous>:wasm-function[8442]:0x1e2046)
            at <wasm_bindgen::JsValue as core::convert::From<u64>>::from::h1c482d09df9df836 (<anonymous>:wasm-function[9106]:0x1ec14c)
            at wasm::api::api_faz::h498cfaecbd4acab5 (<anonymous>:wasm-function[12674]:0x211e08)
            at api_faz (<anonymous>:wasm-function[8813]:0x1e7ba9)
            at Object.module.exports.api_faz (/mnt/f9/Projects/github.com/rustwasm/wasm-bindgen/target/wasm32-unknown-unknown/wbg-tmp/wasm-bindgen-test.js:504:20)
            at exports.js_works (/mnt/f9/Projects/github.com/rustwasm/wasm-bindgen/tests/wasm/api.js:13:29)
            at wasm::api::js_works::haa9d61ac0376a8a3 (<anonymous>:wasm-function[10685]:0x200618)
            at wasm::api::works::h78bff9502dc41e95 (<anonymous>:wasm-function[12841]:0x212712)
            at core::ops::function::FnOnce::call_once::h363f2b57eb52eb28 (<anonymous>:wasm-function[10732]:0x200def)
            at wasm_bindgen_test::__rt::Context::execute_sync::{{closure}}::h098a2e306ed5fa39 (<anonymous>:wasm-function[2625]:0x14384d)

This is my first time touching wasm-bindgen, or low level wasm in general, so it is also highly likely I am just completely misunderstanding how this should work. Could anyone point me in the right direction?
Closes #2350

Thanks for the PR!
I'm not precisely sure where this is coming from but it seems like the node being used might not support i64 being used in the interface of a wasm module? I think that's where the bit about the illegal type is coming from.

Now, I may very well be completely wrong, but I belive the problem is that the Wasm imports __wbindgen_bigint_new as a JS function with the call signature of (i64) -> JsValue, so it proceeds to actually call it like that, with a Wasm i64, throwing the exception when invoking the host function.
As for why this could fail with experimental feature flags enabled, that is beyond me.

Is this closable now that https://github.com/rustwasm/wasm-bindgen/pull/2629 is merged, supporting BigInt conversions?

See https://github.com/rustwasm/wasm-bindgen/issues/2350#issuecomment-929563421, I think JsValue::as_u64 part is still missing, so this PR or the like of it would be useful.


Add Ability to enrich metric tags

Inspired by: https://github.com/MassTransit/MassTransit/pull/5373

@NooNameR
I found a bug in the implementation. :(
TagList is a value type so that the changes within the Populate method are not affected.


Bump tauri-plugin-updater to beta.9

Closes https://github.com/KittyCAD/modeling-app/issues/2741

Closed in favour of #2914


VSCode Debugging not showing logs

Describe the bug
If you debug an js file in VSCode with signale logs, they don't show up in the debug output
To Reproduce
Steps to reproduce the behavior.
Simple package with just signale as dependencie
const signale = require('signale');

signale.info('foo');
console.log('bar')

'bar' gets logged, 'foo' not
Expected behavior
A clear and concise description of what you expected to happen.
i don't see any logs.
Loggin to a file stream works
Screenshots
If applicable, add screenshots to help explain your problem.
Technical Info (please complete the following information)

OS: Windows 10
Signale Version: 1.1.0
Node.js Version: 9.6.1 & 10.1.0

Additional context
Add any other context about the problem here.

EDIT:
using the "console": "integratedTerminal" launch option shows all the logs.

"outputCapture": "std" also shows the log but will not show color and figure.

Closing, for now, will reopen if needed in the future.

@klauscfhq Any chance to get it working with the debug console of VSCode?

Having the same issue more than two years later again and finding this issue... I guess the answer is no. :-D


Fix compilation

Which issue does this PR close?
Closes #1000
Rationale for this change
API changes broke compilation and execution of the standalone ballista client.
What changes are included in this PR?
Compilation fixes, and another fix is required for tests to pass
Are there any user-facing changes?
None

Problem here https://github.com/apache/arrow-datafusion/blob/master/ballista/rust/executor/src/standalone.rs#L55
By the time df collects test results the tonic server is unreachable, I tried to make it run ad-vitam but then the tests never end.

I verified that the cargo check --features=standalone compiles on this branch, but does not on master
When we fix the ballista test, I recommend we start running the standalone client tests as part of CI so they aren't broken again

This seems like an improvement to me, so merging it in. We can always improve things more in the future

Thanks again @Igosuki

So how do we fix the ballista test though ? I don't understand why the tonic server is unreachable since even if the thread gets detached because the tokio JoinHandle gets dropped it should still be running right ?

I wonder which part of the not is not parsing.

Sorry @Igosuki  I am not super familiar with the ballista codebase yet. What test are you referring to (aka what command are you running locally that is failing)?
With that information I can file a ticket for the problem and probably find someone in the community who can help fix it

@alamb This one https://github.com/apache/arrow-datafusion/blob/master/ballista/rust/client/src/context.rs#L300

Filed https://github.com/apache/arrow-datafusion/issues/1020 to track test failing


added support for a new migrate.path configuration setting to the mod…

I've implemented this change-set in order to further decouple each module from the core application's configuration settings.
The current behavior of the module:migrate command requires that all modules incorporate a uniform directory structure where the location of each module's migration scripts are determined by fetching config('modules.paths.generator.migration') then appending it to each module's base path.
This may pose a problem when multiple vendors who are utilizing different configuration settings try to share modules of code.
The solution I'm proposing involves adding support for an optional migration.path setting to the module.json files which will override the default behavior which was described above.
{
    migration: {
        path: "src/database/migrations"
    }
}

Update:
I've also just added support for an additional seeds parameter:
{
    migration: {
        seeds: [className, ...]
    }
}

This setting should serve as an explicit override for the (current) default behavior of module:seed:
public function getSeederName($name)
    {
        $name = Str::studly($name);

        $namespace = $this->laravel['modules']->config('namespace');

        return $namespace . '\\' . $name . '\Database\Seeders\\' . $name . 'DatabaseSeeder';
    }

As you can see this command works a little bit differently from module:migrate.
The name of each module is passed through an Str::studly method and then appended to the modules.namespace app configuration setting.
The Database\Seeders segment of the namespace is hardcoded which is also less than ideal hence the optional override.

Hello,
Thank you for your contribution!
This looks like a good addition. However, to be sure, those 2 new options in the module.json file are optional, right ? As in they don't need to be set at all.

This looks like a good addition. However, to be sure, those 2 new options in the module.json file are optional, right ? As in they don't need to be set at all.

That's correct.  I made them optional because I didn't want to break BC.

Awesome thanks for the clarification.


Set the full day correctly

moro config --day 8 will not set the day to 8 hours - it always tells me  "Working until  16:10 will make it a full (7.5) day " afterwards.

I can't reproduce the issue on my computer.
Could you tell me what operating system you use? What version of node?
There should be a config file in your home directory where Moro saves it's settings:
.moro-config.json
Does that exist on your machine?

@omidfi no this file does not exist. There is only .moro-data.db
I am using a MacBook Pro / macOS Sierra 10.12.5 with node V7.7.2

@Isengo1989
Sure
{"BREAK_DEFAULT":30,"HOURS_IN_A_WORK_DAY":8,"DATE_FORMAT":"dddd, MMMM D","DB_FILE_MAIN":"/home/GraceHopper/.moro-data.db"}

I created the file in my home dir and changed the path at the end - still showing 7.5 hours tho.

Sorry I can't reproduce this. But in next releases, I'll try to move this setting to database probably that makes it better.


enable freetype for lvgl & remove little_ui dir

Signed-off-by: zhuxinglongbest.126.com

感谢提交 Pull Requests！
Thanks for submitting a pull request.

auto build success,number:119

autotest success,number:1282


Fix load error when using Spring w/ custom config

I'm currently working a project that is a Rails engine
When I add dotenv-rails to my Gemfile, and try to run a command, say: bundle exec rspec spec, this error occurs:
{gem-path}/spring-1.6.4/lib/spring/configuration.rb:31:in `application_root_path':
Spring was unable to find your config/application.rb file.
Your project root was detected at {project-root}, so spring looked
for {project-root}/config/application.rb but it doesn't exist.

You can configure the root of your application by
setting Spring.application_root in config/spring.rb. (Spring::MissingApplication)
  from {gem-path}/spring-1.6.4/lib/spring/watcher.rb:24:in `watcher`

The error is saying that Spring can't find my application_root. This is odd, because Spring allows for custom configuration, such as specifying where to find the root directory of your Rails application.
This is especially helpful when working with a Rails Engine, and the root of the application lives within the dummy app.
In my project, Spring's application_root is configured via a ./config.spring.rb file.
In lib/dotenv/rails Spring's watcher file was being included, but that watcher file doesn't trigger the loading of custom Spring configurations.
Those includes take place in Spring's commands file.
Specifically:

Loading of .spring.rb files
Loading of ./config.spring.rb files

Changed lib/dotenv/rails to instead include spring/commands (which in itself includes the watcher file). This allows for Spring to preload any configurations before dotenv-rails uses the Spring.watch
command.

Thanks!

@bkeepers welcome!
Thanks for this project!

Hey @bkeepers - would you be willing to push a new version of this gem now that this has been merged?

Yup, 2.1.1 is now released!

Thanks, @bkeepers !!


mat-select is skipped from tab navigation

I'm submitting a ...  (check one with "x")
[x] bug report => search github for a similar issue or PR before submitting
[ ] feature request
[ ] support request

Current behavior
Cannot navigate to mat-select using tab navigation - mat-select is simply left out.
Expected behavior
mat-select should be included into the tab navigation.
Minimal reproduction of the problem with instructions

Navigate to: https://stackblitz.com/edit/angular-6pkj4y
Focus first input field
Press tab key and observe mat-select being skipped

What is the motivation / use case for changing the behavior?
All the material components should be normally accessible.
Please tell us about your environment:
OS X 10.13.6
VSCode 1.28.2
Yarn 1.12.1
Node 10.13.0
Language: TypeScript 3.1.6
Node (for AoT issues): 10.13.0

Issue again seems to be somewhat related to how FormlyAttributes is adding the attributes to material controls. Hopefully this get's sorted out by material.
Current workaround would be to always set tabindex attribute to 0 in case of falsy value: '[attr.tabindex]': 'to.tabindex || 0'


[Android] Underline highlight remains after moving selection elsewhere

Package Version
Using https://github.com/superlistapp/super_editor/commit/0a58e704469ccaffe5ab14620a56afe75bee6574 in main.
To Reproduce
Steps to reproduce the behavior:

Go to SuperEditor or SuperTextField demos
Tap on the text to place the selection
Tap elsewhere in the content to move the selection

Actual behavior
Caret and handle move to the new selection, but the composing region underline highlight remain in the previous place
Expected behavior
Caret, handles and composing region underline highlight are painted in the selection position.
Platform
Android.

Screenshots
Screen_recording_20231214_161411.webm

Cc @matthew-carroll

@miguelcmedeiros that's the composing region. Apparently, Android places a composing region around whatever word has the caret.
It does look like a bug that the composing region doesn't leave when you change nodes, but the underline is going to follow you around if we underline the composing region.
Please advise.

@matthew-carroll I'm not an Android user and while testing the upgrade in Superlist, I thought that showing the underline highlight when the selection is collapsed was a bug.
The fact that composing region is not cleared when selection changes, seems like a duplicate of https://github.com/superlistapp/super_editor/issues/1685. To make sure we check both cases, leave this one open and update the title and description.

@miguelcmedeiros I don't think typical Android apps show the underline as aggressively as we do now. But I'm not sure what the operative difference might be. We're blindly underlining the composing region. I'm not sure if built-in Android text views have some additional heuristic on top.

I don't think typical Android apps show the underline as aggressively as we do now.

I tested this using an emulator (not sure if it matters) and tried on Google Keep and another notepad app and both showed the underline like super_editor is now showing. Not sure if there's some setting for this or not.

Ok, if other mainstream apps do it, then I think we're fine. But we can leave this open until the related issue is resolved.

I think this will probably be fixed by https://github.com/superlistapp/super_editor/pull/1693

@angelosilvestre this issue is fixed in some cases, but when the user taps outside a text field and the field is unfocused, then the underline remains:
https://github.com/superlistapp/super_editor/assets/31278849/ed204ea7-16fa-4f0b-bf1b-035f303a4c22
This was captured without making any changes to the demo code.

@miguelcmedeiros Thanks for letting me know. I'll take a look at this situation.


Use Uniform Bulletting

Thanks for the project!
This README.md would be more readable if the sections were uniformly lists, not a mix of lists and paragraphs. I'm also not sure why some product have a link to the product page and show the product description, and other products don't.
Examples
ACTUAL
See the extensive list at [Awesome Cloud Run](https://github.com/steren/awesome-cloudrun).

EXPECTED
- [Awesome Cloud Run](https://github.com/steren/awesome-cloudrun).

List of sections that have descriptions rather than (awesome) list items.

Big Data
Storage & Databases
Cloud AI
Cloud Run
Compute

Makes sense to me. Happy to review a PR that reformats this.
I don't think there was any particular reason these weren't nested lists to begin with.

Makes sense to me. Happy to review a PR that reformats this.
I don't think there was any particular reason these weren't nested lists to begin with.

Cool. Here's a little PR: https://github.com/GoogleCloudPlatform/awesome-google-cloud/pull/36


In models with integration (d > 0) or seasonal integration (D > 0), trend terms of lower order than d + D cannot be

Task type: forecast
Covariate columns: 9 columns
Prediction column: 1 column
I am getting the following error when using HyperTS:
search:   0%|          | 0/3 [00:00<?, ?it/s]04-06 15:27:10 E hypernets.m.hyper_model.py 71 - run_trail failed! trail_no=1
04-06 15:27:10 E hypernets.m.hyper_model.py 73 - Traceback (most recent call last):
File "/root/miniconda3/envs/hyperTS/lib/python3.8/site-packages/hypernets/model/hyper_model.py", line 66, in _run_trial
estimator.fit(X, y, **fit_kwargs)
File "/root/miniconda3/envs/hyperTS/lib/python3.8/site-packages/hyperts/hyper_ts.py", line 118, in fit
self.model.fit(X_transformed, y, **kwargs)
File "/root/miniconda3/envs/hyperTS/lib/python3.8/site-packages/hyperts/framework/wrappers/stats_wrappers.py", line 80, in fit
model = ARIMA(endog=y, order=(p, d, q), trend=trend,
File "/root/miniconda3/envs/hyperTS/lib/python3.8/site-packages/statsmodels/tsa/arima/model.py", line 146, in init
raise ValueError(
ValueError: In models with integration (d > 0) or seasonal integration (D > 0), trend terms of lower order than d + D cannot be (as they would be eliminated due to the differencing operation). For example, a constant cannot be included in an ARIMA(1, 1, 1) model, but including a linear trend, which would have the same effect as fitting a constant to the differenced data, is allowed.
search:  33%|███▎      | 1/3 [00:00<00:00,  3.02it/s]INFO:prophet:Disabling yearly seasonality. Run prophet with yearly_seasonality=True to override this.
INFO:prophet:Disabling weekly seasonality. Run prophet with weekly_seasonality=True to override this.
search:  67%|██████▋   | 2/3 [00:02<00:01,  1.38s/it]INFO:prophet:Disabling yearly seasonality. Run prophet with yearly_seasonality=True to override this.
INFO:prophet:Disabling weekly seasonality. Run prophet with weekly_seasonality=True to override this.

This is a conflict in the ARIMA parameter space, but it should not affect the final searched model.  You can post more detailed code information to help me reproduce the error process.


Allow rating of individial episodes

User should be able to rate episodes under a tv show.
Also add watched/not watched or maybe assume watched if rated?

For series is a must to be able to add watched state for every episode.

For series is a must to be able to add watched state for every episode.

Thanks for commenting @christ4k, this is high on the priority list, I will get it done soon.

@christ4k Sorry this took so long, should be a release soon after I test on beta.watcharr.app.
If you have any feedback after trying it out, please feel free to open a new issue.


Update dependencies.props

The windows build is failing very early now.

The build error appeared to be unrelated to your change. I've clicked "retry" for you.
(For future reference, you should be able to do this, too. When signed into Azure Pipelines, you should see a 'Retry' button if you click the triple dots on the top right)

I did that, I think you can see it in the history. Thanks anyway.


Dynatrace Certification

Dynatrace Certification

@nsankar1987 Dynatrace Certifications are paid, and it is not eligible for this list.

Further Info:
https://www.devopsschool.com/blog/dynatrace-associate-certification/


Generate command applies previously unapplied migrations to DB

I'm not sure if this is a bug or intentional, but I created 2 migrations one after the other:
npm run db g myMigration1

 ... some schema changes

npm run db g myMigration2

as soon as I ran the 2nd command I saw the first was applied to the database without me first calling npm run db migrate.

It's intentional, because otherwise you could get migrations with the same actions in them, it would fail and confuse.
I added a line about this to the docs (will be deployed later).


It don't enters chars with tilde such as 'ã' or 'õ'

I write in brazilian portuguese and I need do time entries names with tilde. All is working on my environment, but not on Toggl Desktop (only on it that does not work); I use Antergos with Fluxbox.

No accents. None. Neither tilde or acute, for example.

I've managed to reproduce this issue. We'll look more into it.

I've taken another look at this issue. Sadly I cannot reproduce it anymore.


config to allow disabling credit card number sanitization

This allows for still using SanitizeData, while disabling this specific value
sanitizer, which is broad enough to capture any other 13-16 digit numbers as well.
As discussed in https://github.com/getsentry/raven-ruby/issues/328
Overall I kinda liked my second suggestion better, splitting the credit card sanitizer into a separate processor, but decided against it for backwards compatibility reasons. It'd be sad if people suddenly lost that sanitization because they were doing something like
config.processors = [Raven::Processor::SanitizeData, MyCustomProcessor]

It'd be sad if people suddenly lost that sanitization because they were doing something like

Great point!

thanks for the snappy response!


Distribution status (present/absent) is not used when showing distributions

This species: https://api.gbif-uat.org/v1/species/159674339/distributions is absent in Burundi, but is shown as present on the species page: https://www.gbif-uat.org/species/159674339
Required for https://github.com/gbif/data-mobilization/issues/175 to progress.

It looks like it ignores the actual status
https://github.com/gbif/portal16/blob/master/app/views/pages/species/key/speciestypes/nonBackboneSpecies.nunjucks#L51-L52


Add portable uBPF unit tests that run on Windows / Linux / MacOS

Run the uBPF code generation tests and capture code coverage..
Resolves: #117
Resolves: #141
Signed-off-by: Alan Jowett<EMAIL_ADDRESS>

@alessandrogario this is a continuation of your work to have uBPF build on Windows, Linux, and MacOS. Would you be able to take a quick look at this?

@rlane can you authorize the coveralls.io app so it can post code coverage stats for PRs?

I have tested this on an M1 Mac and under Arm64 Linux with no issues.
Thank you - this fixes many Python version contortions I needed to do.

Awesome. I hope to eventually retire the Python-based tests, but there are still some code coverage gaps in the C++ tests that need to be addressed. I want to get this checked in as the first step towards getting this updated.

@matt-gretton-dann can you check on your MacOS and see what the correct package name for the equivalent of "libboost-dev",  "libboost-program-options-dev", and  "libboost-filesystem-dev" are. I think "boost" is the correct for "libboost-dev", but I don't have access to a MacOS instance to check the others.

Converting to draft until MacOS and ARM64 issues are resolved.

@matt-gretton-dann can you check on your MacOS and see what the correct package name for the equivalent of "libboost-dev", "libboost-program-options-dev", and "libboost-filesystem-dev" are. I think "boost" is the correct for "libboost-dev", but I don't have access to a MacOS instance to check the others.

@Alan-Jowett: boost is all you need.  However, there are problems in the CMakeLists.txt file, and also in bpf_conformance that need resolving.

@Alan-Jowett: To help fix the macOS build https://github.com/Alan-Jowett/bpf_conformance/pull/24 needs to be approved, and then the submodule dependency updated to the appropriate hash.

Everything appears to build and run.
Windows Debug/Release
Linux x64 Debug/Release | Sanitize/Coverage
Linux arm64 Debug/Release | Sanitize/Coverage
MacOS11 Debug/Release | Sanitize/Coverage

There is value in getting this checked in. Filed an issue to resolve the ubsan / qemu issue later.


Try sharing the Travis cache between jobs

Travis uses the environment variable to determine the cache: if two jobs have different environment variables, they get different caches. See https://docs.travis-ci.com/user/caching/#caches-and-build-matrices
This means every job is having to rebuild the common lib and download dependencies.  This is very inefficient!  Let's try sharing the cache among all Scala jobs and see if that improves build times.
h/t Jamie for spotting this originally

Closing – this doesn't seem to make any noticeable effect on build times, but it does make it harder to see which job in the list has failed.


update project id

update crowdin project id
#356

[x] Make sure you are opening from a topic/feature/bugfix branch (right side) and not your main branch!
[x] Ensure that the pull request title represents the desired changelog entry
[x] Please describe what you did
[x] Link to relevant issues in GitHub or Jira

@NotMyFault  can you pls look here. Thx

@NotMyFault can you pls look here. Thx

What am I supposed to look for?

Kindly ask, to be sure I do it in correct way. It is 'new' feature and I thing nobody here has some experience.


the pain of trying to update query parameters

Version
3.0.1 (nuxtjs 1.4)
Reproduction link
https://github.com/vuejs/vue-router
Steps to reproduce
I've read the documentation repeatedly, read every stack overflow, and gone through all of the Vue forums on anything related to programatic navigation for over a year now and i've never been able to do the following successfully

pass a this=that query parameter into this.$route.query, using either .push, .replace, etc
have this.$route.query instantly contain that new parameter
have my URL also reflect that change/add/removal of the parameter

here is one of my current methods I use that "kind of" works in one of my projects
methods: {
    query (params) {
      let i = 0
      for (let key in params) {
        setTimeout(() => {
          this.$router.push({ query: {...this.$route.query, [key]: params[key] }})
        } , 100*++i)
      }
      setTimeout(() => this.get(), 100*++i)
    },
}

I simply call query({page: 2}) and pray, this.get() is just an axios get to the API passing this.$route.params, then refreshing the data
What is expected?
my parameters to update both in this.$route.query and the URL
What is actually happening?
If I don't add these delays, the behavior is pretty radical, one of the following and/or all happens

this.$route.query does not have any, or some of the parameters passed through
The URL does not show or reflect some of the parameters
1. will happen to different parameters than 2.
Safari is most likely not to work, requires a larger increase of delays

Why is this a GitHub issue?
My main goal with posting this is not just to finally find a solid stable solution to my issue, but afterwards do all I can to shorten this path for others in the future.

that is not a repro. Also please, do not use such negative titles (the pain of trying to update query parameters) in issues 😕

@posva like I've said in the issue I've scoured and posted in all 3 of those, this is easily a repro issue, just try the sample.
I'm not attempting to impose negativity, but instead help contribute to what I think is either a bug, or a lack of docs/examples on a generally needed task for programatic navigation.

okay, then please put that into a jsfiddle: https://jsfiddle.net/posva/9r6xhqbp/ so I can take a look 🙂


Compose Box: Unresolve empty topics.

In case of empty topics, only the compose box
topic is changed to remove the tick-prefix from it.
The function with_first_message_id may return
undefined when no message is found, instead of
throwing an error.
Fixes #29182

Fixes:

Screenshots and screen captures:
Instead of an error, unresolving an empty topic and then sending a message in it now results in:

Self-review checklist

[ ] Self-reviewed the changes for clarity and maintainability
(variable names, code reuse, readability, etc.).

Communicate decisions, questions, and potential concerns.

[x] Explains differences from previous plans (e.g., issue description).
[ ] Highlights technical choices and bugs encountered.
[ ] Calls out remaining decisions and concerns.
[ ] Automated tests verify logic where appropriate.

Individual commits are ready for review (see commit discipline).

[ ] Each commit is a coherent idea.
[ ] Commit message(s) explain reasoning and motivation for changes.

Completed manual review and testing of the following:

[ ] Visual appearance of the changes.
[ ] Responsiveness and internationalization.
[ ] Strings and tooltips.
[ ] End-to-end functionality of buttons, interactions and flows.
[ ] Corner cases, error conditions, and easily imagined bugs.

Can you squash the commits? You should never have a commit that just fixes a bug in the previous commit in the same PR.
Check out our GitHub guide and commit guidelines for more details.

@timabbott I've squashed the commits.

Works for me in manual testing!

@timabbott See above for responses to your feedback.

I cleaned this up, pushed the changes, and marked this to merge once CI passes. Thanks for the contribution @kuv2707!
Please be encouraged to work on the TODO comment that I added in my revisions; I think this is a good checkpoint as it eliminates the exception, but if you actually send the message, it does not feel great.

Great! I'll surely look into it.


Ideas for engines

Hello,
I make modpacks in my free time, and I love this..... eh, ill get to the point.
I use this mod a lot. A LOT. and have found that the engines use a lot of fuel, and it can be difficult to keep them full. I'm not wanting the engines to burn less fuel, I feel like they are a good mid-game option for speed. But I would like higher tiers of engine. perhaps one that uses RF instead of fuel, one that uses lava from an internal tank. Hell, a wind up engine would probably fit the semi-steampunk feel of this mod. also, in the ship GUI, you should be able to disable engines when the ship is sitting idle, of course you would have to have measurement gauges installed to do this. And, if none of that, it would be nice to be able to use the config to add blocks to a list of engines.
as a side note and a less serious request, it would be cool if boats and airships could have some sort of weapons. from the ship gui be able to launch TNT or fireballs would be nice, but I don't think that's needed.

I'd like to examine this for a bit:

RF Engine
An RF Engine is certainly not outside the realm of possibility. The main issue is setting a balance, and determining how it would work.
If it's an RF Engine, the most simple(and boring) way to do this is to create a multiblock engine. One part is just a simple RF Generator, and the other would be a turbine/motor block. You're essentially just making speed cheaper using the same amount of fuel,
The second, and far more interesting version, is also the same method you would use for the Lava tank, the only difference would be whether you're using RF or MB of Lava as a source. The idea is that you create a new block, an RF Power Cell Block, or a Lava Tank Block, as well as a Fuel Port block. Each Power Cell/Tank Block would represent a limited amount of RF. Adding more of these blocks to the structure of the ship would add more overall capacity for fuel when the ship is active, the same way the Air Balloons work towards making your ship able to fly. From there, you would simply connect an RF Generator or Fluid Pipe up to the Fuel Port, while the ship is parked, and add fuel the same way you would any other RF/Fluid Device.

Disabling Engines in gui.
I agree, this should be a feature,

Weapons.
Weapons are something I've also been wanting for quite a while, and I've found a fairly simple workaround that would be fairly easy to implement. The Ancient Warfare 2 mod has some really nice "Vehicles" which are basically entities in the form of Cannons, Ballista, Catapults, and Trebuchets.
These are all Entities that can be controlled remotely with an item. All that really needs to be done to combine them with a ship is code similar to that found in the Crates, so they can be carried by the ship.

Personal dream list:
Different types of engine for different types of travel.
Oven+Balloons (or antigrav engine) = slow and smooth and can park in midair
Wings = Fast, but only stays up when moving fast, drops like a rock when hits something
Air tanks + propellers = Water/underwater
Ideally, being able to name and assign type and power level to blocks from other mods for engines.
Pylons from Botania look amazing and have an attached power mechanism, as do the gravitational anomolies from Matter overdrive, and the floating crystals of Astronomy - great engine candidates.


chore: Downdate softprops/action-gh-release to 2.1.0

Description

https://github.com/softprops/action-gh-release/issues/556 needs to be resolved.

Closes #
Additional context

Checklist

[ ] I have read the Contribution Guide.
[ ] I agree to follow the Code of Conduct.

@dependabot show softprops/action-gh-release ignore conditions


Improve custom style syntax

Do you think that something like log('this is ') makes the API syntax more specific? I think particularly in terms of beginners and consistency with HTML.
Best regards,
Rick

Hey again, Rick! I’ve never been particularly satisfied with log('this is [c="color: red"]red[c]') but I’m not sure I find this syntax much more appealing. I’m definitely open to suggestion though.

Once I've played with regexp I will see if I can generate some other suggestions!

@adamschwartz the only other syntax I feel isn't difficult to read is something akin to the handlebars templating syntax, perhaps like log('this is <"color: red">{{red}}');
Beyond that, I haven't been able to create anything that isn't pretty ugly. I did a small poll on a slack channel I'm a member of and most people preferred the one initially suggested as it mimics HTML style tags. Any thoughts?

Thanks for conducting that poll!
As strange as it may sound, I might be more of a fan of something like log('this is red'). While this arbitrarily adds support for  elements, I think I find it preferable to creating a pseudo-HTML syntax like


build: Debug config support for PackOne

Now PackOne takes files from objchk_* and copy them to Install_Debug when project configuration name ends with "Debug". It's required for NDIS5 driver build.
Also, PackOne source and dest can be overrided in the project configuration.

virtio-win/master was in a bad state for a few minutes and it made the pull request look ugly.
Can you please kick it, so GitHub updates the PR? git commit --amend followed by git push -f should do it. Thanks!

Done.

It looks like as a side effect empty Install directory with OS\platform subdirectories created as well.

It looks like as a side effect empty Install directory with OS\platform subdirectories created as well.

Actually, it's not a PackOne side effect or any other degradation, because you get the same result without my commits to NetKVM. I can fix it, but prefer to make a separate pull request.

Ilya, thanks for the pull request - approving. Wating for CI to finish the build to merge.

It looks like Install is created by the in NetKVM-VS2015.vcxproj.

by the <CustomBuildStep>, GitHub ate the markup :)

Thank you. I plan to replace CustomBuildStep with PackOne if possible.

Thanks!


Change the pointer color

How can I change the pointer color?
I have tried the below props, but it didn't work.
pointerProps={{
  style: {
    caretColor: "white",
  },
}}

pointerProps={{
style: {
filter: "contrast(0%) brightness(2)",
},
}}

Great!
I got it with filter: "hue-rotate(26deg)" function.


how to add validation to nedb?

hi all. I am trying to include a validator on post requests and I am pretty lost. I don't know how to add a proper response for the browser. i tried it with hooks and all sorts of others things, but no luck.
I get an exception in the browser with the code below.
var apiService, app, bodyParser, errors, feathers, hooks, nedb, port;

feathers = require('feathers');
hooks = require('feathers-hooks');
nedb = require('feathers-nedb');
bodyParser = require('body-parser');
errors = require('feathers-errors').types;

apiService = nedb('api').extend({
  create: function(data, params, cb) {
    var valid;
    if (valid = false) {
      console.log("update", data);
      return this._super(data, params, cb);
    } else {
      //WHAT TO CALL HERE, to get a proper response for the browser
      return cb(new errors.BadRequest("not valid"));
    }
  }
});

app = feathers()
.configure(hooks())
.use(feathers["static"]('./client/dist'))
.configure(feathers.socketio())
.configure(feathers.rest())
.use(bodyParser.json())
.use(bodyParser.urlencoded({extended: true}))
.use('api', apiService)
.use(function(err, req, res, next) {
  console.log(err);
  res.status(404);
  return res.json({
    message: err.message
  });
});

port = 7777;
app.listen(port, function() {
  return console.log('Feathers server listening on port ' + port);
});

and the following client request:
var data, url;

data = {
  username: "franzl",
  date: new Date(),
  type: "stammtisch"
};

url = "/api";

fetch(url, {
  method: 'POST',
  headers: {
    'Content-Type': 'application/json'
  },
  body: JSON.stringify(data)
}).then(function(res) {
  return console.log(res);
})["catch"](function(err) {
  return console.log(err);
});

Feathers in build error messages work fine when trying a GET to a missing id, but not my own validator.
thanks a lot and happy new year.

It doesn't look like your extended code would work the way I'd expect it. Did you look at the guide for using hooks for validation?
A simple extended validator can look like this:
apiService = nedb('api').extend({
  create: function(data, params, cb) {
    if(!data.name) {
      return cb(new errors.BadRequest('Name needs to be provided'));
    }

    return this._super(data, params, cb);
  }
});

If you now try to submit data without  a name property you should get a BadRequest error.

merci vielmals :)
that was it. My code was working before too, but I did not read my fetch result properly.

@ekryski
(if (valid = false)) of course. but that was only for testing.


feat(icon): add has shape attribute

General summary

Screenshots

Check list

[ ] (if has style) Add need: review-integration label
[ ] (if has textual documentation) Add need: review-doc label
[x] (if has code) Add need: review-frontend label
[x] (if has react) Check through the react dev check list
[x] (if fix or feature) Add need: test label

Check out the contribution guide for general guidelines for submissions to the design system.

Is that normal that for the lumapps theme in dark mode, somes icons are not visible ?

Yes, it's WAD. Icon does not handle themes for now. And for the shape to be visible, we make a default color as dark.
One day we will handle theme and the default color will be light on dark theme. But for now it's WAD.


improve clear interval

it turned out to be just one place that needed to be updated.

@all-contributors please add @bboydflo for code

Released in v1.5.1, thank you!


Return a Task object from add_task, not an id

Type of changes

[ ] Bug fix
[x] New feature
[ ] Documentation / docstrings
[ ] Tests
[ ] Other

Checklist

[x] I've run the latest black with default args on new code.
[ ] I've updated CHANGELOG.md and CONTRIBUTORS.md where appropriate.
[ ] I've added tests for new code.
[x] I accept that @willmcgugan may be pedantic in the code review.

(Missing items would be completed on final submission. Currently, I'm just exploring this idea.)
Description
Preface: This pull request is practically just a feature request (more open to discussion), but with a quick attempt to see how difficult the work would be. I don't mean for the code/design to be final. Just a proof-of-concept.
I would like add_task to return a Task object instead of an opaque identifier TaskId. Further, Task objects should be able to update, advance, and reset themselves. My reasoning is as follows:

It is easier to pass around a single reference to a Task instead of two references to a TaskId and Progress object. Having "rich-ified" a few personal projects, the tedium of passing both these things deep down a call stack adds up.
TaskId (ints) aren't useful to users, but Task objects are. For example, I can't ask a TaskId what its total is, but a Task does know.
There's no (public) way to translate TaskIds into Tasks currently. Even if you know that the private-ish self._tasks dict is where they're kept, you further have to know that the TaskId is really just a key into that dict

Implementation
The quick summary is:

Return a Task object from Progress.add_task, not an id
Add a progress attribute to Task objects. On initialization, this gets set to the Progress object that is managing the task.

(Not attempted option) Make the attribute private (_progress)?

Add start(), stop(), update(), reset(), advance() methods to the Task class. Currently, these are just thin wrappers to the method on the progress object. For example def start(...): self.progress.start(...).

(Not attempted option) Strip these methods from Progress altogether, and have the implementations only live under Task. This simplifies Progress's interface and makes it less confusing to figure out the "right way" to do something.

Update callers of add_task to use the task.id instead of just the old returned task_id. This includes in tests, which still pass 100% with this PR's code.

Because these changes change the interface of add_task, this change would be backwards incompatible.
Later work would include new tests and documentation updates.

Since this is a breaking change I couldn't accept it unless there was a very compelling reason to do so.
Exposing the Task object is probably a bad idea because there are some internal attributes there, that a user might expect to modify and have a meaningful effect.
What might work is having an object that wraps TaskID and adds public methods. But this object would have not break the current API. i.e. progress.update(my_task, ... should continue to work in addition to  my_task.update(.
I'm going to close this PR, but happy to continue the discussion on Discussions tab.


Fix go.mod for utilities to point to correct path

Signed-off-by: Radu Andries<EMAIL_ADDRESS>What type of PR is this?
/kind cleanup
What this PR does / why we need it:
go mod tidy and correct pointers to repo
Does this PR introduce a user-facing change?:
NONE

[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by:
To complete the pull request process, please assign admiral0 after the PR has been reviewed.
You can assign the PR to them by writing /assign @admiral0 in a comment when ready.
The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: leodido
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

OWNERS [leodido]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

LGTM label has been added.  Git tree hash: 996f85530bda1c4106c4d957f1a75c7fcbaeb542


api-docs: Clarify narrow parameter in /get-messages endpoint.

Clarifies the narrow parameter description by adding information about what a user's message history includes, about bots not being automatically subscribed to the owner's streams, and about the streams:public narrow.
Adds some of that information to the main description for the endpoint as well, and changes the link in the main description to go to the parameter instead of to the 'construct-a-narrow' page, which is linked to in the parameter description.
Fixes #19477.

Notes:

Do we also want to update the 'construct-a-narrow' documentation to include something about either the streams:public narrow specifically or the results being limited to a user's message history and what that includes?
Do we want to update other instances of narrow parameters to have a similar description? These seem to be:

check if messages match narrow
register event queue
real time events API

Screenshots and screen captures:

Get messages main description
Current documentation

Get messages narrow parameter description
Current documentation

Self-review checklist

[x] Self-reviewed the changes for clarity and maintainability
(variable names, code reuse, readability, etc.).

Communicate decisions, questions, and potential concerns.

[x] Explains differences from previous plans (e.g., issue description).
[ ] Highlights technical choices and bugs encountered.
[x] Calls out remaining decisions and concerns.
[ ] Automated tests verify logic where appropriate.

Individual commits are ready for review (see commit discipline).

[x] Each commit is a coherent idea.
[x] Commit message(s) explain reasoning and motivation for changes.

Completed manual review and testing of the following:

[x] Visual appearance of the changes.
[ ] Responsiveness and internationalization.
[ ] Strings and tooltips.
[ ] End-to-end functionality of buttons, interactions and flows.
[ ] Corner cases, error conditions, and easily imagined bugs.

Do we want to update other instances of narrow parameters to have a similar description?

Yeah, I think so. For /events and /register, we definitely hear from people wondering "Why don't I get any messages when testing this", because they haven't subscribed their bot to any streams.
We probably want a multi-faceted fix for this -- e.g. we should potentially make the UI for creating bots offer to let you add them to streams, so that this class of problem doesn't come up; perhaps you can start a thread in #integrations or #design to discuss how that should work.
But I think having an explicit mention in https://zulip.com/api/real-time-events and on the /register documentation that a user will only receive messages sent to streams to which it is subscribed would be a very helpful reminder in helping eliminate this not infrequent case of folks feeling like our bots system doesn't work because they didn't know they needed to subscribe the bot to streams.

Do we also want to update the 'construct-a-narrow' documentation to include something about either the streams:public narrow specifically or the results being limited to a user's message history and what that includes?
I think the "construct a narrow" page should probably explain the algorithm clearly. It's a bit subtle -- so I think a user-facing summary of the rules in the ok_to_include_history comments that explain it for Zulip developers would be a very helpful section to add to that page.

Updates:

Revised the /get-messages documentation update based on Tim's feedback above.
Added updates to the shared Narrow parameter that's used in both the /register-queue and /real-time-events documentation.
Updated the main description for the /check-messages-match-narrow endpoint.

Pending:

I'm working on the /construct-a-narrow update, but thought I would post these changes for review now. Also that could be a follow-up commit to these changes.
CZO conversation about updating the UI for creating bots to have an option/ability to subscribe to streams.

Updated screenshots:

Get messages - main description
Current documentation

Get messages - narrow parameter
Current documentation

Check if matches narrow - main description
Current documentation

Real time events and register queue - narrow parameter
Current documentation

I think the note about narrows being limited to a user's message history feels a bit confusing for the events parameter -- since we're talking about processing of new messages there anyway.
I didn't have a clear idea of how to express that, so ended up fiddling with this and ending up with the following diff. Key changes include:

Correcting a misleading statement about how shared history searches work; it's quite complicated (see the comments in ok_to_include_history) but I found a /help/ article that explains it well enough to link to. Definitely an idea we'll want to cover clearly on the "Construct a narrow" page, which probably needs a larger pass as you've mentioned, so we can leave that for a follow-up.
Rewriting the real-time-events pages description of /narrow to more distinctly frame things as "this is updates for new mesages"; I realized splitting the private messages and streams examples would be helpful here.

diff --git a/zerver/openapi/zulip.yaml b/zerver/openapi/zulip.yaml
index ce08c12d52..841915a9f4 100644
--- a/zerver/openapi/zulip.yaml
+++ b/zerver/openapi/zulip.yaml
@@ -5119,18 +5119,22 @@ paths:
             The narrow where you want to fetch the messages from. See how to
             [construct a narrow](/api/construct-narrow).

-            Note that, in general, narrows are limited to the user's message
-            history, which means that results will be from streams that the
-            user is subscribed to and from private/group messages in which
-            the user is a participant.
+            Note that many narrows, including all that lack a `stream`
+            or `streams` operator, search the user's personal message
+            history. See [searching shared
+            history](/help/search-for-messages#searching-shared-history)
+            for details.

-            Newly created bot users are not usually subscribed to any streams.
-
-            If you would like to fetch messages from all public streams instead
+            For example, if you would like to fetch messages from all public streams instead
             of only the user's message history, then a specific narrow for
             messages sent to all public streams can be used:
             `{"operator": "streams", "operand": "public"}`.

+            Newly created bot users are not usually subscribed to any
+            streams, so bots using this API should either be
+            subscribed to appropriate streams or use a shared history
+            search narrow with this endpoint.
+
             **Changes**: In Zulip 2.1.0, added support for using user/stream IDs
             when constructing narrows for a message's sender, its stream and/or
             its recipient(s).
@@ -17046,18 +17050,28 @@ components:
         [narrow filter(s)](/api/construct-narrow) for which you'd
         like to receive events for.

-        For instance, to receive events for the stream
-        `Denmark`, you would specify `narrow=[["stream", "Denmark"]]`.
-        Another example is `narrow=[["is", "private"]]` for private
-        messages.
+        For example, to receive events for private messages (including
+        group private messages) received by the user, one can use
+        `narrow=[["is", "private"]]`.
+
+        Unlike the API for [fetching messages](/api/get-messages),
+        this narrow parameter is simply a filter on messages that the
+        user receives through their stream subscriptions (or because
+        they are a recipient of a private message).
+
+        This means that a client that requests a `narrow` filter of
+        `[["stream", "Denmark"]]` will receive events for new messages
+        sent to that stream while the user is subscribed to that
+        stream. The client will not receive any message events at all
+        if the user is not subscribed to `"Denmark"`.

-        Note that narrows are limited to the user's message history,
-        which does not contain messages sent to streams before they
-        [subscribe](/api/subscribe), and that newly created bot users
-        are not usually subscribed to any streams.
+        Newly created bot users are not usually subscribed to any
+        streams, so bots using this API need to be
+        [subscribed](/api/subscribe) to any streams whose messages
+        you'd like them to process using this endpoint.

-        There is a specific narrow for messages sent to all public
-        streams, which is `narrow=[["streams", "public"]]`.
+        See the `all_public_streams` parameter for how to process all
+        public stream messages in an organization.

         Defaults to `[]`.
       content:

Merged, with those changes; thanks so much for making this happen @laurynmm! This is a super tangly area, so I really appreciate your helping with this.


Localization for strings and messages

It's getting out of hands to hard code messages should use strings resource.
Could we use this? https://www.jetbrains.com/help/idea/resource-bundle.html

Thats not a solution

https://www.baeldung.com/java-resourcebundle

https://docs.oracle.com/javase/8/docs/api/java/util/PropertyResourceBundle.html