One light turning on again after turning off the group

Version information:
V1.4.1
Description:
On light turns back on again after turning off a group of zigbee lights (not a ZHA group but a group helper).
I get this if I listen to call_service:
Event 11 fired 9:58 AM:
event_type: call_service
data:
domain: light
service: turn_on
service_data:
entity_id: light.bedroom_light_bulb_1_level_light_color_on_off
transition: 10
brightness: 255
color_temp_kelvin: 4000
origin: LOCAL
time_fired: "2022-12-22T08:58:36.535368+00:00"
context:
id: adapt_lgt:b'*Xx`':interval:b'6%q'
parent_id: null
user_id: null
Event 9 fired 9:58 AM:
event_type: call_service
data:
domain: light
service: turn_off
service_data:
entity_id:
- light.bedroom_light_bulb_1_level_light_color_on_off
- light.bedroom_light_bulb_2_level_light_color_on_off
- light.bedroom_light_bulb_3_level_light_color_on_off
origin: LOCAL
time_fired: "2022-12-22T08:58:31.689347+00:00"
context:
id: 01GMWGWEBVZNCBWVF07F8S6AFR
parent_id: 01GMWGWEBM53FTCQC1CPFV2ERG
user_id: null
Event 8 fired 9:58 AM:

same is happening to me. random lights turn on back again after they are turned off by an automation. only happens sometimes. I already increased the update interval to 300 seconds and that makes it happen less often, but is still annoying to realize that the bedroom lights have been on for hours.

btw it does not happen when only_once is activated, which at least solved the problem for lights that don't stay on for long (like in the hallway). So it must be that the lights get updated with new values although they are already off (and state is showing off in HA)

I have the same issue as mentioned above on version 1.4.1
Using an automation to turn off the lights, some of them turn on again (Not using groups, individual lights only)
If only_once activated it also fixes my issue.
History of the light that turn on again:
turned on triggered by service light.turn_on
2:31:16 PM - 2 minutes ago
turned off triggered by automation ****
triggered by state of Switch
2:30:54 PM - 3 minutes ago
turned on triggered by automation ****
triggered by state of Switch
2:29:22 PM - 4 minutes ago

Looks like a duplicate of https://github.com/basnijholt/adaptive-lighting/issues/377
In the Adaptive Lighting configuration, try setting interval to smaller value than transition and sleep_transition and restarting Home Assistant.

I'm seeing this issue and I've tried the recommended settings from #377 but it did not fix anythingfor me. I've tried several variations, including using the exact values in the screenshot from that issue.
My situation is specific to this issue, in that I'm experiencing this with Zigbee lights in a group. In my case the group is defined by the deCONZ system.

Can someone experiencing this on zigbee2mqtt post their configuration.yaml and devices.yaml so I can reproduce your settings?

I have had similar issues and for me it was the Z2M zigbee groups. Moving to HA groups removed the problem completely.

Can someone experiencing this on zigbee2mqtt post their configuration.yaml and devices.yaml so I can reproduce your settings? Your adaptive-lighting config is also needed.
I was getting this issue with older configurations - using zigbee2mqtt. I was only able to solve this accidentally by updating everything to the latest version. I also redid the zigbee2mqtt configuration.yaml just to be certain everything would act the way I wanted it to. optimistic was very significant in my tests I remember.

I just tried reproducing it and got the issue right away. Here are my files.
devices.zip

Pictures on the adaptive config
![image](https://user-images.githubusercontent.com/9947929/228055463-20eb54bd-5bf5-40af-84b8-073c0e137d86.png)

@filikun can you post debug logs of this happening? Set your interval low and you should notice the problem right away.
I use optimistic: true on my configuration: I couldn't get optimistic: false to work. When optimistic is false it would never publish any state changes to HA which adaptive-lighting relies on.

Yeah, I'll revert my optimistic change and turn on the logs. Give me a moment

Set your interval to something like 5 as well.

Hmm how can I cahnge the interval?

Anyhow here is something. So I played around a little applying adaptive, taking it away, adding it again and applying night mode and turning on and off some individual lights. Not spamming them but a slow "stress" test and had some issues right away.
https://pastebin.com/u1xg9rsK

Hmm how can I cahnge the interval? And is there a way to isolate the logs from the logger integration? It's a lot going on here

Go to home assistant's integrations page. Should look like this:

Click adaptive-lighting to see the following:

@th3w1zard1
Alright! Here we go https://pastebin.com/5NQZRMfK

@th3w1zard1
Did you find anything useful?

@filikun Sorry for the delay, haven't had much time to look into this.
For reference I see your group is composed of the following:
Lampa sovrum fönster 4
Lampa sovrum säng Filip 16
Lampa sovrum säng Hannah 17
Lampa sovrum skrivbord Filip 1
Lampa sovrum skrivbord Hannah 2
Lampa sovrum tak 6

Do you know if it's always the same bulb in the group everytime that is getting turned on?
I wasn't able to find anything useful in your logs, but there's a lot in there and I haven't had time to properly go line by line.
Is there perhaps anything useful in your logbook?

I have one more idea on how to test this but I'll need some time to write the automation.

@filikun I'm sorry I just need more information. I've created a script with the exact light.turn_on calls adaptive lighting is using from your posted logs. Can you run this script with your same group and see if you get the same issue? Make sure to turn off adaptive-lighting or disable it before running this.
alias: Stress test zigbee group
sequence:
  - service: light.turn_on
    data:
      transition: 1
      brightness: 3
      color_temp_kelvin: 2202
    target:
      entity_id: light.den_ceilingfan_lights
  - delay:
      hours: 0
      minutes: 0
      seconds: 3
      milliseconds: 0
  - service: light.turn_on
    data:
      transition: 1
      brightness: 144
      color_temp_kelvin: 2500
    target:
      entity_id: light.den_ceilingfan_lights
  - delay:
      hours: 0
      minutes: 0
      seconds: 3
      milliseconds: 0
  - service: light.turn_on
    data:
      transition: 1
      brightness: 144
      color_temp_kelvin: 2500
    target:
      entity_id: light.den_ceilingfan_lights
  - delay:
      hours: 0
      minutes: 0
      seconds: 3
      milliseconds: 0
  - service: light.turn_on
    data:
      transition: 1
      brightness: 144
      color_temp_kelvin: 2500
    target:
      entity_id: light.den_ceilingfan_lights
  - delay:
      hours: 0
      minutes: 0
      seconds: 3
      milliseconds: 0
  - service: light.turn_on
    data:
      transition: 1
      brightness: 3
      color_temp_kelvin: 2202
    target:
      entity_id: light.den_ceilingfan_lights
  - delay:
      hours: 0
      minutes: 0
      seconds: 3
      milliseconds: 0
  - service: light.turn_on
    data:
      transition: 1
      brightness: 3
      color_temp_kelvin: 2202
    target:
      entity_id: light.den_ceilingfan_lights
  - delay:
      hours: 0
      minutes: 0
      seconds: 3
      milliseconds: 0
  - service: light.turn_on
    data:
      transition: 1
      brightness: 3
      color_temp_kelvin: 2202
    target:
      entity_id: light.den_ceilingfan_lights
  - delay:
      hours: 0
      minutes: 0
      seconds: 3
      milliseconds: 0
  - service: light.turn_on
    data:
      transition: 1
      brightness: 3
      color_temp_kelvin: 2202
    target:
      entity_id: light.den_ceilingfan_lights
  - delay:
      hours: 0
      minutes: 0
      seconds: 3
      milliseconds: 0
  - service: light.turn_on
    data:
      transition: 1
      brightness: 3
      color_temp_kelvin: 2202
    target:
      entity_id: light.den_ceilingfan_lights
  - delay:
      hours: 0
      minutes: 0
      seconds: 3
      milliseconds: 0
  - service: light.turn_on
    data:
      transition: 1
      brightness: 3
      color_temp_kelvin: 2202
    target:
      entity_id: light.den_ceilingfan_lights
  - delay:
      hours: 0
      minutes: 0
      seconds: 3
      milliseconds: 0
  - service: light.turn_on
    data:
      transition: 1
      brightness: 3
      color_temp_kelvin: 2202
    target:
      entity_id: light.den_ceilingfan_lights
  - delay:
      hours: 0
      minutes: 0
      seconds: 3
      milliseconds: 0
  - service: light.turn_on
    data:
      transition: 1
      brightness: 3
      color_temp_kelvin: 2202
    target:
      entity_id: light.den_ceilingfan_lights
  - delay:
      hours: 0
      minutes: 0
      seconds: 3
      milliseconds: 0
  - service: light.turn_on
    data:
      transition: 1
      brightness: 3
      color_temp_kelvin: 2202
    target:
      entity_id: light.den_ceilingfan_lights
  - delay:
      hours: 0
      minutes: 0
      seconds: 3
      milliseconds: 0
  - service: light.turn_on
    data:
      transition: 1
      brightness: 3
      color_temp_kelvin: 2202
    target:
      entity_id: light.den_ceilingfan_lights
  - delay:
      hours: 0
      minutes: 0
      seconds: 3
      milliseconds: 0
  - service: light.turn_on
    data:
      transition: 1
      brightness: 3
      color_temp_kelvin: 2202
    target:
      entity_id: light.den_ceilingfan_lights
mode: single

For the record I tried this on two different zigbee light groups I have and it worked fine.

@th3w1zard1
I'll try this out and get back to you ASAP!

It didn't do much log wise
2023-04-01 09:19:08.373 DEBUG (MainThread) [custom_components.adaptive_lighting.switch] Sovrum: Called '_setup_listeners'
2023-04-01 09:19:08.373 DEBUG (MainThread) [custom_components.adaptive_lighting.switch] Sovrum: Cancelled '_setup_listeners'

@filikun the script I posted were the exact same light.turn_on calls that adaptive-lighting did in your logs you posted earlier. So the question is after you ran the script, did any of your bulbs become unsynced?

Please check https://github.com/basnijholt/adaptive-lighting/issues/410#issuecomment-1490820625 in case you missed it.

Hmm no nothing ordinary. It might be that I'm using the light group in AL and then was turning of one of the grouped lights and thinking that if it's off then it won't turn back on but if AL sends a light ON to the whole group every light would be expected to turn on.
Everything was in sync during the test. I will have to take AL live and make sure to have smaller light groups in my areas as I don't want all lights to always be on in a room.
My stupidity obviously, sorry for taking your time! I know I had problems with AL turning on lights at random before (not the same case as the one I described here) I'll have to see if works.

No worries! please don't hesitate to post back here if you find out more info we can debug

@th3w1zard1 one more thing. I have now created some light groups. I have one for the entire room, one for roof lights, one for windows and one for task lights. 4 in total and the one for the entire room contains all lights. When I turn on one individual light, every light in the room turns on. Is that expected?

All lights group
light.a
light.b
light.c
light.d
light.e
Roof group
light.a
light.b
Window group
light.c
light.d
Task group
light.e
Turning on one light, light.e, turns on all above lights

@filikun if one light is turning on your whole group, you need to disable optimistic inside the group itself

I use Adaptive Lighting with Zigbee2MQTT and Ikea Tradfri bulbs. I sometimes get odd behavior of individually controlled single lights (not groups!) staying on despite after being turned off and also being reported as off.
When it happens, HA reports them off, and Z2M reports them off, but they are shining. When I manually sync the state in Z2M, it correctly updates to the on-state.  It happens only every once in a while, and I haven't found a way to reproduce, so I just could have missed the off/on sequence.
It seems like this doesn't happen during the day, only during adjustment phases in the morning and at night, but I'm not 100% sure on that either. My theory is that AL adjustment commands might interfere with turn-off commands. interval is set to the default 90 seconds, and I feel like whatever I set it to, it's either too long and counteracts the purpose of AL, or there's a chance that commands collide.
Anyway, I'm primarily wondering whether this is the same issue as reported here?

I have now also witnessed my lights turning back on, and I figured out the reason.
This is the problematic code (the else branch):
https://github.com/basnijholt/adaptive-lighting/blob/9caf64509349958a340f8cef9207fdb0ea35dbef/custom_components/adaptive_lighting/switch.py#L1203-L1216
And here is a Zigbee2MQTT log which demonstrates it nicely:
// Light turn-on command
Debug 2023-05-09 10:57:11 Received MQTT message on 'zigbee2mqtt/Bulb01/set' with data '{"state":"ON"}'

// AL responds to turn-on with split adaptation commands (separate color temperature and brightness)
Debug 2023-05-09 10:57:11 Received MQTT message on 'zigbee2mqtt/Bulb01/set' with data '{"state":"ON","transition":0.5,"color_temp":250}'
Debug 2023-05-09 10:57:13 Received MQTT message on 'zigbee2mqtt/Bulb01/set' with data '{"state":"ON","transition":0.5,"brightness":254}'

// Later, AL sends a scheduled adapation command (first half of split: color temperature)
Debug 2023-05-09 10:57:27 Received MQTT message on 'zigbee2mqtt/Bulb01/set' with data '{"state":"ON","transition":22.5,"color_temp":250}'

// Then, the light is turned off
Debug 2023-05-09 10:57:33 Received MQTT message on 'zigbee2mqtt/Bulb01/set' with data '{"state":"OFF"}'

// NOW THE PROBLEM:
// AL sends the second half (brightness) of the adaptation command initiated before the light was turned off
Debug 2023-05-09 10:57:50 Received MQTT message on 'zigbee2mqtt/Bulb01/set' with data '{"state":"ON","transition":22.5,"brightness":254}'

// UNDESIRED SIDE EFFECT:
// AL thinks the light was regularly turned on and sends another split adaptation command
Debug 2023-05-09 10:57:51 Received MQTT message on 'zigbee2mqtt/Bulb01/set' with data '{"state":"ON","transition":0.5,"color_temp":250}'
Debug 2023-05-09 10:57:52 Received MQTT message on 'zigbee2mqtt/Bulb01/set' with data '{"state":"ON","transition":0.5,"brightness":254}'

To fix the lights turning back on, the split command sequence needs to be cancelled when the lights are turned off.
This seems to be related to the issue described in my previous comment https://github.com/basnijholt/adaptive-lighting/issues/410#issuecomment-1538922312 where the lights just stay on. The difference is that there, a scheduled adjustment command collides with and overrules the turn-off command. This race condition can happen with and without separate_turn_on_commands, it's just less likely.


[HAMMER] Use AwesomeSpawn for ConversionHost

hammer backports of the following commits:

https://github.com/ManageIQ/manageiq/commit/0db28e77d8d257a57737be74ca3dff9e6f8115a9
https://github.com/ManageIQ/manageiq/commit/7f22efa385fea25e88995106e11e9262e097d9a1

@miq-bot add_label hammer
@miq-bot add_reviewer @fdupont-redhat

@NickLaMuro looks good. I'm not able to merge, so you'll need another reviewer :)

@NickLaMuro Thank you for getting this done quickly!


#310: Use rating for favorited

Add rating to and remove favorited from the Photo model. Migrate data: favorited==true => rating=4.
Show photos with a rating greater than a user-set minimum rating (default 4) as favorited.
When a user marks a photo as favorite, set rating to that same favorite minimum rating.
Admin can set the default favorite minimum rating for new users.
This PR should be merged together with the one in frontend (https://github.com/LibrePhotos/librephotos-frontend/pull/21).

I implemented this with a site setting first, but then added the user setting, using the site setting as a default. The site setting is perhaps a bit unnecessary now...

Thank you again for opening up the pull request! The code looks in general looks good to me, but I found a couple of issues.
As you said, the site setting seems redundant. I think it should be removed.
I found a bug. If you add a photo to favorites within the "With Timestamps" view and then switch to the favorites view, then the site crashes. If you refresh the favorites view everything works again. It looks like an issue with a redux store. The items are manipulated in way that makes react-pig crash.
TypeError: g.items is undefined
computeLayoutGroups/<
src/app/node_modules/react-pig/dist/index.es.js:5898

  5895 | // the working rowAspectRatio.
  5896 |
  5897 | var tempImgData = [];
> 5898 | g.items.forEach(function (image, index) {
       | ^  5899 |   if (index === 0) {
  5900 |     groupTranslateY = translateY;
  5901 |   }

Ok. I will reproduce and fix.
Will also remove the added site setting.

I can reproduce the bug with and without the changes in this PR (and https://github.com/LibrePhotos/librephotos-frontend/pull/21, having migrated the database back).
So, definitely a bug, but not caused by these changes.
I think that it should also be solved naturally by the changes I'm currently doing to use one single photos list in the frontend.

I found the issue, I think. When adding a photo as favorite, it's just added to store.photos.favoritePhotos directly, but the FavoritePhotos view expects store.photos.favoritePhotos to be a date-grouped list. This will definitely change in my current refactoring.

I could also reproduce the bug on the demo server, which obviously does not have the changes in this PR. I think after the removal of the site setting, this can be merged 👍
I will file an issue to document the bug 😄

Default favorite min rating removed from site settings. I did make it possible to supply the default as an environment variable though (DEFAULT_FAVORITE_MIN_RATING). If you think it would be good, I'll create a PR in librephotos-docker with this as an added optional setting.

Yes, this makes sense :+1:
Looks good to me!


[CdapIO] CdapIO and SparkReceiverIO updates

Added pullFrequencySec parameter - delay in seconds between polling for new records updates.
Added startOffset parameter - inclusive start offset from which the reading should be started.
Refactoring (Plugin, MappingUtils, context classes)

Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

[ ] Choose reviewer(s) and mention them in a comment (R: @username).
[ ] Mention the appropriate issue in your description (for example: addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment fixes #<ISSUE NUMBER> instead.
[ ] Update CHANGES.md with noteworthy changes.
[ ] If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.
To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md
GitHub Actions Tests Status (on master branch)

See CI.md for more information about GitHub Actions CI.

Run Java PreCommit

Run Java PreCommit

Run Java_Examples_Dataflow_Java17 PreCommit

Run Java PreCommit

R: @aromanenko-dev
R: @johnjcasey
R: @chamikaramj
This is the PR with CDAP and SparkReceiver IOs' changes (related to the comment from the https://github.com/apache/beam/pull/23501 PR).
Thanks!

@johnjcasey
All comments have been addressed, thanks!


Can't create team with release 5.4.0

Hi,
In 5.3.1 I can create a new team upon bootstrapping via docker-compose.
In 5.4.0, after creating the first user, the clickable string "Create a new team" is missing from the panel by which you join a team

Do you have any error message ? I just try to spawn a new Mattermost instance locally, create a new team and it works correctly. After creating the team, I'm redirect to the Team chat interface.


RL training stage, out of memory

Switching to RL, after every epoch training, the memory usage will increase about 2GB. Finally, the system will be out of memory, and kill process.
Could you please give me some tips to solve it? Thank you very much!

Hello, have you ever solved this problem? Before switching to RL,  I use Xe loss function to train model , the memory usage will increase.

Switching to RL, after every epoch training, the memory usage will increase about 2GB. Finally, the system will be out of memory, and kill process. Could you please give me some tips to solve it? Thank you very much!

Hello,I  meet the same problem. Have you ever overcome it ? Could you please tell me  how to solve this problem, thank you !

Have you solved it? I hope to receive your reply as soon as possible. Thank you

Hello, have you ever solved this problem? Before switching to RL, I use Xe loss function to train model , the memory usage will increase.
Hello, excuse me.  I have the same problem, have you solved it? My cache keeps increasing when I run it and eventually the model gets stuck，thanks a lot.


Bundle container images with appliances

In order to run podman-based workers or built-in floe containers on appliances we have to be able to package docker images and deploy them on an appliance without requiring a podman pull at runtime.
One possibility is to package the images in an RPM that would podman load the image into a podman image registry.
It is simple to create alternate image registries by specifying an alternate graphRoot via --root when pulling or loading images.

It seems the image storage directory has to be owned by manageiq if we are going to run the containers as that user.  I tried to have e.g. /var/lib/manageiq/containers/storage owned by root with runRoot and tmpDir pointing somewhere else, but podman always tries to create other files/directories in the main imagestore
TODO try additionalimagestores in /etc/containers/storage.conf, doesn't seem to work for non-root containers?

For building the RPM I tried using podman load in manageiq.spec.in but that fails due to UID/GID errors
+ podman load --root=/root/rpmbuild/BUILDROOT/manageiq-19.0.0-20240405144727.el9.x86_64/var/lib/manageiq/data/containers/storage --input manageiq-gemset-19.0.0/bundler/gems/manageiq-providers-embedded_terraform-a6319eeb8602/content/containers/opentofu-runner_latest
time="2024-04-05T14:59:24Z" level=warning msg="Using rootless single mapping into the namespace. This might break some images. Check /etc/subuid and /etc/subgid for adding sub*ids if not using a network user"
Getting image source signatures
Copying blob sha256:d858e3d4ed076bae0562df26c2c251d1140619a80531f5e6edf1b4b2af55cdb3
Copying blob sha256:4222f9694f4be6c22d86d8a24a6e26d49ed01d1c393bb053ea8003928635446a
Copying blob sha256:c0d7d10a1b4e234d1c9057f8f793cff397a738d3334d3d40b93519d9e81a25ee
Copying blob sha256:716476e198e5a004dab028219afa022f8d56cc497b4f92ee770c52b01d9b61e6
Copying blob sha256:048b0fef4f933bbe51ac1da3d7d93ed17f8bc3c46c05703f41a24f243da46a90
Copying blob sha256:39146e33ec19ce2b054da412b06ccc57e648f3078cdc01dfd1523b9cb22de066
Error: payload does not match any of the supported image formats:
 * oci: writing blob: adding layer with blob "sha256:d858e3d4ed076bae0562df26c2c251d1140619a80531f5e6edf1b4b2af55cdb3": processing tar file(potentially insufficient UIDs or GIDs available in user namespace (requested 0:42 for /etc/shadow): Check /etc/subuid and /etc/subgid if configured locally and run "podman system migrate": lchown /etc/shadow: invalid argument): exit status 1
 * oci-archive: creating temp directory: untarring file "/var/tmp/container_images_oci172047747": read /root/rpmbuild/BUILD/manageiq-gemset-19.0.0/bundler/gems/manageiq-providers-embedded_terraform-a6319eeb8602/content/containers/opentofu-runner_latest: is a directory
 * docker-archive: detecting compression for file "manageiq-gemset-19.0.0/bundler/gems/manageiq-providers-embedded_terraform-a6319eeb8602/content/containers/opentofu-runner_latest": detecting compression: read manageiq-gemset-19.0.0/bundler/gems/manageiq-providers-embedded_terraform-a6319eeb8602/content/containers/opentofu-runner_latest: is a directory
 * dir: open manageiq-gemset-19.0.0/bundler/gems/manageiq-providers-embedded_terraform-a6319eeb8602/content/containers/opentofu-runner_latest/manifest.json: no such file or directory
error: Bad exit status from /var/tmp/rpm-tmp.LXgPB2 (%install)

And it doesn't seem possible to add subuid/subgid in the build container for podman to work properly.
We might need to package the .tar.gz files and podman load them at install time.

@bdunne Please also take a look here.


Crash [Throwing]

#### Crash logs
http://zerobin.qbuissondebon.info/?643a724274bfff1b#Yx4yITyQ80CCU6zVWE5BxC6rUNT4bP1I1WveaZlO1Ho=
n]: [mana] Wrote mana data into /home/quentinbd/minetest/worlds/minetestforfun//mana.mt.
01:31:34: ACTION[main]: compassgps writing settings
01:31:34: ACTION[main]: Wrote quests to file
01:31:34: ACTION[main]: [PClasses] Datas saved
01:31:34: ACTION[main]: [tsm_pyramids] Chests saved
01:31:34: ACTION[main]: [fishing] Server shuts down. saving trophies table
01:31:35: ERROR[main]: ERROR: An unhandled exception occurred: ...uentinbd/minetest/bin/../mods/throwing/functions.lua:36: attempt to index a nil value
01:31:35: ERROR[main]: stack traceback:
01:31:35: ERROR[main]: 	...uentinbd/minetest/bin/../mods/throwing/functions.lua:36: in function 'throwing_shoot_arrow'
01:31:35: ERROR[main]: 	...uentinbd/minetest/bin/../mods/throwing/functions.lua:109: in function <...uentinbd/minetest/bin/../mods/throwing/functions.lua:103>

In thread 7f076f4d2740:
/home/quentinbd/minetest/src/main.cpp:882: int main(int, char**): Assertion '0' failed.
Debug stacks:
DEBUG STACK FOR THREAD 7f0768b3c700:
#0  virtual void* CurlFetchThread::Thread()
DEBUG STACK FOR THREAD 7f076f4d2740:
#0  int main(int, char**)
(Leftover data: #1  Dedicated server branch)
(Leftover data: #2  virtual void ServerMap::save(ModifiedState))
(Leftover data: #3  void ItemStack::serialize(std::ostream&) const)
/home/quentinbd/script/start02.sh : ligne 26 : 20913 Abandon                 /home/quentinbd/minetest/bin/minetestserver --world /home/quentinbd/minetest/worlds/minetestforfun/ --config /home/quentinbd/minetest/minetest.conf --gameid minetestforfun_game --port 30001
----------------------
Server restarted at mardi 28 juillet 2015, 01:32:05 (UTC+0200)
----------------------
WARNING: system-wide share not found at "/usr/share/minetest"
WARNING: system-wide share not found at "/home/quentinbd/minetest/bin/../share/minetest"
WARNING: system-wide share found at "/home/quentinbd/minetest/bin/.."
Using game specified by --gameid on the command line
01:32:05: WARNING: Undeclared global variable "handlers" accessed at ...home/quentinbd/minetest/bin/../mods/irc/irc/main.lua:188

https://github.com/MinetestForFun/minetest-minetestforfun-server/commit/0d88b4443f79aeb4c53a17b35ddfea86085f11ef
Very very very rare case.


Possible factorial error.

Hi.
I am not sure about this being a bug or not but I will put forward some of my findings.
So I defined the factorial method as given on [(http://www.objecthunter.net/exp4j/)].
I get an exception for 3!-2! but not for 3-2!(I get 1, as expected). But rightfully, (3!)-(2!) gives me the correct answer(i.e, 4).
What can be done in order for 3!-2! to work without having to enter brackets?

Yes, this actually related to #64 see pull request #74, I just added a test for this and it seems to be resolved in that branch (https://travis-ci.org/dktcoding/exp4j/builds/182453474)

case '!':
if (numArguments != 1) {
return BUILTIN[INDEX_FACTORIAL];
}
default:
return null;
This is the proposed fix correct? In this, would the numArguments be number of elements in the string to which I add operators and numbers?

From: Federico Vera<EMAIL_ADDRESS>Sent: Friday, December 9, 2016 5:43 AM
To: fasseg/exp4j
Cc: Anurag Joshi; Author
Subject: Re: [fasseg/exp4j] Possible factorial error. (#75)
Yes, this actually related to #64https://github.com/fasseg/exp4j/issues/64 see pull request #74https://github.com/fasseg/exp4j/pull/74, I just added a test for this and it seems to be resolved in that branch (https://travis-ci.org/dktcoding/exp4j/builds/182453474)

You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHubhttps://github.com/fasseg/exp4j/issues/75#issuecomment-265895292, or mute the threadhttps://github.com/notifications/unsubscribe-auth/AQCtmLEEqwNlKGz4vZUp1KvjRfWys_rWks5rGJ0vgaJpZM4LIbDd.

That's the special casing, the way it works is:

The ! is declared to have only one argument (as it should)
Since we need ! to be always on the right we treated as a binary operator with a null second argument (like num!null)
The tokenizer doesn't actually count the number of available tokens, it uses some clever assumptions to try and figure out the argument count.
Based on (3) we could trick it to believe that it should have two arguments when there's only one is available, that way the expression is always valid (because it has only one argument), but the operator is always on the right.

The problem is that this can't be done using an external Operator (at least I was unable to figure out how), only using a built-in so it's possible to special case it
That code you posted isn't from the original exp4j it's from a fork I created, the proposed fix is detailed in PR #74

Hey Guys,
I do have January off and will invest some time to get exp4j up to date. Unfortunately I do not have enough time to do this properly earlier...

Hey Guys,
I added the tests from @dktcoding and it does produce the correct value. Am I missing something there or has this bug mysteriously disappeared?
https://github.com/fasseg/exp4j/commit/e977f199cc1222cd5232582a03a3742324710b9a


Dropped bar charts incorrectly representing data

The recent addition to enable a bar to rise or drop from the bottom or top respectively is not capturing the correct data value. If the examples/basic chart is changed to represent a bar chart with a drop, then the first value of the first bar is 1. However, it is rendered with a length of 4.

This was resolved with extra Rustdoc to clarify what is happening - PR #27.


Uncaught Error: Class Sentry\Options not found

Dev
How do you use Sentry?
Sentry SaaS (sentry.io)
Steps to Reproduce
basically after try to update sentry-symfony, I'm getting an error.
composer req sentry/sentry-symfony:^4.0 -W
Actual Result
Creating myprofile_php_run ... done
./composer.json has been updated
Running composer update sentry/sentry-symfony --with-all-dependencies
Loading composer repositories with package information
Restricting packages listed in "symfony/symfony" to "5.2.*"
Updating dependencies
Nothing to modify in lock file
Installing dependencies from lock file (including require-dev)
Nothing to install, update or remove
Generating autoload files
composer/package-versions-deprecated: Generating version class...
composer/package-versions-deprecated: ...done generating version class
96 packages you are using are looking for funding.
Use the `composer fund` command to find out more!

Synchronizing package.json with PHP packages
Don't forget to run npm install --force or yarn install --force to refresh your JavaScript dependencies!
Run composer recipes at any time to see the status of your Symfony recipes.

Executing script cache:clear [KO]
 [KO]
Script cache:clear returned with error code 255
!!  Symfony\Component\ErrorHandler\Error\ClassNotFoundError {#4597
!!    #message: """
!!      Attempted to load class "Options" from namespace "Sentry".\n
!!
Script @auto-scripts was called via post-update-cmd

Installation failed, reverting ./composer.json and ./composer.lock to their original content.

It's the pull request: https://github.com/eerison/myprofile/pull/375/files
Symfony 5.2

I'm closing this issue because I resolved it

removing

 "replace": {
        "sentry/sdk": "*"
    }

adding

composer require pugx/sentry-sdk

The regular sentry/sdk package uses the Symfony HTTP client now so I'm not sure you still need any of these "workarounds".
Can you try just requiring sentry/sentry-symfony (no sentry/sdk or pugx/sentry-sdk)?
I'm not sure that package is needed anymore (we used to have Guzzle but that is no longer the case).

Hi @stayallive I removed the pugx/sentry-sdk but I get this error:
Executing script cache:clear [KO]
 [KO]
Script cache:clear returned with error code 1
!!
!!  In DefinitionErrorExceptionPass.php line 54:
!!
!!    Cannot autowire service "Symfony\Bridge\PsrHttpMessage\Factory\PsrHttpFacto
!!    ry": argument "$serverRequestFactory" of method "__construct()" references
!!    interface "Psr\Http\Message\ServerRequestFactoryInterface" but no such serv
!!    ice exists.
Script @auto-scripts was called via post-update-cmd
xmb00559:myprofile erison.silva$

composer.json
"require": {
        "php": "^8.0",
        "ext-ctype": "*",
        "ext-iconv": "*",
        "ext-intl": "*",
        "composer/package-versions-deprecated": "<IP_ADDRESS>",
        "doctrine/annotations": "^1.11",
        "doctrine/doctrine-bundle": "^2.2",
        "doctrine/doctrine-migrations-bundle": "^3.0",
        "doctrine/orm": "^2.7",
        "presta/sitemap-bundle": "^2.1",
        "sensio/framework-extra-bundle": "^5.6",
        "sentry/sentry-symfony": "^4.0",
        "stof/doctrine-extensions-bundle": "dev-master",
        "symfony/apache-pack": "^1.0",
        "symfony/console": "^v5.2",
        "symfony/dotenv": "v5.2",
        "symfony/expression-language": "v5.2",
        "symfony/flex": "^1.3",
        "symfony/form": "v5.2",
        "symfony/framework-bundle": "v5.2",
        "symfony/http-client": "v5.2",
        "symfony/mailgun-mailer": "v5.2",
        "symfony/monolog-bundle": "^3.5",
        "symfony/proxy-manager-bridge": "^v5.2",
        "symfony/security-bundle": "v5.2",
        "symfony/translation": "v5.2",
        "symfony/twig-pack": "^1.0",
        "symfony/validator": "v5.2",
        "symfony/webpack-encore-bundle": "^1.7",
        "symfony/yaml": "^v5.2",
        "symfonycasts/reset-password-bundle": "^1.2",
        "symfonycasts/verify-email-bundle": "^1.2",
        "transloadit/php-sdk": "^2.1"
    },

and when I install the sentry/sentry-symfony
has added psr_http_message_bridge.yaml with
services:
    _defaults:
        autowire: true
        autoconfigure: true

    Symfony\Bridge\PsrHttpMessage\HttpFoundationFactoryInterface:
        '@Symfony\Bridge\PsrHttpMessage\Factory\HttpFoundationFactory'

    Symfony\Bridge\PsrHttpMessage\HttpMessageFactoryInterface:
        '@Symfony\Bridge\PsrHttpMessage\Factory\PsrHttpFactory'

    Symfony\Bridge\PsrHttpMessage\Factory\HttpFoundationFactory: null
    Symfony\Bridge\PsrHttpMessage\Factory\PsrHttpFactory: null

    # Uncomment the following line to allow controllers to receive a
    # PSR-7 server request object instead of an HttpFoundation request
    #Symfony\Bridge\PsrHttpMessage\ArgumentValueResolver\PsrServerRequestResolver: null

    # Uncomment the following line to allow controllers to return a
    # PSR-7 response object instead of an HttpFoundation response
    #Symfony\Bridge\PsrHttpMessage\EventListener\PsrResponseListener: null

is that right?

Excellent question!
I understand why pugx/sentry-sdk used to be needed, but suspect it's no longer needed because the sentry/sdk now (almost) provides the exact same packages.
But I'm not familiar enough with Symfony to know if this services config is correct in our context... I'm missing some Synfony knowledge here, I hope @Jean85 can help me out here :)

well I'm almost finish the task in repository, and after that I can see again more deep why it's happening
maybe should I reopen this issue?

The psr_http_message_bridge.yaml is a Flex recipe, and probably related to the warning added in our docs in #445; it's not our issue, it comes from a BC in SensioFrameworkExtraBundle.

Hey @Jean85 thank you for replay
I'll try to update the sensio/framework-extra-bundle and I'll post here :)

Hey @Jean85 and @stayallive
now it works properly 🎊
Steps

Upgrade "sensio/framework-extra-bundle": "^6.0",
Removed pugx/sentry/sdk and psr_http_message_bridge.yaml

after execute those steps it works
Thank you 😊


removed logical or

all licenses applies

This looks fine, but it would be useful to have a document that states that this syntax is valid.
https://devmanual.gentoo.org/general-concepts/licenses/
That's the only item I could find, but, unfortunately, it doesn't talk about the case of multiple licenses applying (though it does state the syntax for when at least one of many licenses can apply).

https://devmanual.gentoo.org/ebuild-writing/variables/index.html#license


Add support for TOML to the frontmatter plugin

I ran into a case where we were using both TOML and YAML for frontmatter and it turned out the spellchecker was assuming YAML and not ignoring TOML frontmatter. I believe this additional code will allow for either TOML or YAML frontmatter to be ignored or parsed correctly when keys are specified.

That file was already there and I didn’t see a test for it but I think the frontmatter tests get covered okay by the frontmatter-incorrect*md files.
Yes, I can add a section to the readme and changelog but I wasn’t sure what section to put it in. Do the changes go under [unreleased] in the changelog or do I create a new version section?

That file was a toml version of the frontmatter.md file that was already there and I didn’t see a test that one either. I think the frontmatter tests get covered okay by the frontmatter-incorrect*md files so I can delete those other two if we don’t need them.

Understood - it makes sense to me to delete those two files. I might add them back later and add tests for them. Good catch!

And yes, I can add a section to the readme and changelog but I wasn’t sure what section to put it in. Do the changes go under [unreleased] in the changelog or do I create a new version section?

Yes, they go under [unreleased] - sorry for the confusion.

Perfect. I’ll get that all updated today. Thanks!

@tbroadley Hope this is good to go now. Thanks for the help!

Ah as it turns out one of the tests did use frontmatter.md. It expected there to be two fixtures for each plugin (including frontmatter): one with no errors and one containing some errors. I've added the file back.

Thanks for the contribution! I just release v4.3.0, which contains this change.


[Feature] : Add search Results

#1533
The Feature will be added
Related Issue

The Feature for the search  results can be implemented if the input element we can search the Temple places.
Closes: #1533

Description

Used for the india 50+ places and important temple names will be added.
If you can for the search and check the results..

Screenshots
Screencast from 2024-05-15 12-53-40.webm
Checklist

[x] My code adheres to the established style guidelines of the project.
[x] I have included comments in areas that may be difficult to understand.
[x] My changes have not introduced any new warnings.
[x] I have conducted a self-review of my code.

@akshitagupta15june i will finished the New feature can implement..


add session.child_client(client_type, version)

Current dependencies on/for this PR:

main

PR #13   👈

This comment was auto-generated by Graphite.


⚠ Bofrost.at has degraded performance

In 767e407, Bofrost.at (https://www.bofrost.at) experienced degraded performance:

HTTP code: 200
Response time: 1651 ms

Resolved: Bofrost.at performance has improved in 861acb0 after 6 minutes.


Add two options to the LoggingInterceptor

I created a REST API client based on this, and want to fine tune logging.
For this purpose I would like two have two options added to the logging interceptor:

Add the logging level BODY_ONLY to log the request body without logging the headers.
Add the option to pretty print the body.

An alternative to adding another level would be to change the signature of the log method, to receive more (optional) parameters, i.e. log(String message, String headers = null, String body = null), but I am not sure if this is possible without breaking existing implementations.
I just realised that the current implementation is actually passing the content line by line, so I could solve the 2. problem by simply waiting for a line that contains JSON, and pretty print that.

In general, we do not want to add infinite control to the interceptor. If you want extreme customization you're better off duplicating it and implementing the desired behavior in your version.
For example, point 2 is impossible since it implies that 1. the format is text-based and 2. the format is known to OkHttp and can be pretty printed.


mystery: v<IP_ADDRESS> works but no later version does

Hi there,
I've been using this excellent app (v<IP_ADDRESS>) for long, PC, Win 10 Pro, never having any issues. I've recently realized there are later versions. However, none of them work for me. They simply don't start. I tried everything I could, removed the older version, cleaned the registry, tried from different hard drives. Nothing has helped. I even tried it on my laptop, it worked without any problem.
When I move the old version back, it works.  Ben Kenobi. you are my only hope.
Vozzy

Hi,
it's good to hear that it works on your laptop. But of course we would like to see it running on your pc too. And therefore we need to find out what are the specifics to that system.
Here are a few things you can check.
Are the files marked as "downloaded from internet"? Do you have any antivirus/security/firewall software installed which could prevent executing the program? Can you please check the windows event logs for a hint what happens when you try to start the exe?
As the program doesn't even start I think our log file (folder %LOCALAPPDATA%\TumblThree) won't have much hints.
Is your user account an administrator or normal user? Do you have the same problem with other programs/exe too?
Have you already tried to create a new windows user account and run the exe under that one?
Plenty questions, we know that. But we as well as you would like to find out what are the real reasons behind that strange behavior. May the force be with you!

As mentioned in #151 you could delete (don't forget a backup) or rename the settings folder (%LOCALAPPDATA%\TumblThree) to see if the new version starts afterwards.

Thank you very much for your help, @thomas694 and @Fehertukor. I succesfully narrowed problem to the Setting.json file in AppData/Local/TumblThree/Settings folder. Now it works beautifully. Thank you once again for this great app.


Add backwards-compatible locale verbose_name migration

Wagtail 6.2 alters the Locale model on TranslatableMixin, adding a verbose_name. Because Footnote inherits from TranslatableMixin, it needs a new migration generated for Wagtail 6.2.
To maintain compatibility with Wagtail <= 6.1, this change makes the migration a noop for those versions. See #71 for context.
This PR also adds Wagtail 6.2 to the tox environments.
Closes #71

https://github.com/torchbox/wagtail-footnotes/releases/tag/0.12.0 now out

Thank you so much, @zerolab!


APP-2907: implemented ext app certificate authentication

Ticket
APP-2907
Description
Implementation of extension app authentication with a certificate.
Dependencies
Should be merged before : https://github.com/symphonyoss/symphony-api-spec/pull/79
Checklist

[x] Referenced a ticket in the PR title and in the corresponding section
[x] Filled properly the description and dependencies, if any
[x] Unit tests updated or added
[x] Javadoc added or updated
[x] Updated the documentation in docs folder

Looks ok to me
We probably need to investigate more on how extension apps and how the circle of trust work (maybe have a full example for that? replacing the auth app mentioned in the official doc?) (out of the scope of this PR)

Looks ok to me
We probably need to investigate more on how extension apps and how the circle of trust work (maybe have a full example for that? replacing the auth app mentioned in the official doc?) (out of the scope of this PR)

yo symphony can generate an app


Error message: No devices or entities – Failed setup, will retry, NickName

Hello, first of all thank you for this HA extension. When I try to login with My Porsche credentials, which I am using in mobile app, I receive this error message:

Tried to restart HA, log in again, but still the same results. Porsche Connect is active, I can fully manage my car via the Porsche app. Do you have any idea how to solve this issue?

Mine was working fine until recently. Now the same thing is happening to me.

Same happend for me.

Looks like Porsche made some changes in their API.

I’ve got the same issue

Same here... When will it be fixed ?

New user for this integration here.  Confirming the same issue on my first attempt at connecting.

I have the same issue, any news on this?

Please see https://github.com/CJNE/pyporscheconnectapi/issues/46#issuecomment-2210352012

Same here

same here

C.f. #242.


ROX-16924: Fix flake in 'Verify generated network policies'

Description
Apparently the network graph and the network policies are not in sync. We try to fix that by waiting at the beginning of the test to make sure that they have enough time to observe the same conditions.
Checklist

[x] Investigated and inspected CI test results
[ ] Unit test and regression tests added
[ ] Evaluated and added CHANGELOG entry if required
[ ] Determined and documented upgrade steps
[ ] Documented user facing changes (create PR based on openshift/openshift-docs and merge into rhacs-docs)

If any of these don't apply, please comment below.
Testing Performed

CI

/test

/test ocp-4-10-qa-e2e-tests ocp-4-12-qa-e2e-tests ocp-4-13-qa-e2e-tests

/retest

The tests seem to pass few times in a row: link to example logs
NetworkFlowTest > Verify generated network policies STANDARD_OUT
    17:21:39 | INFO  | NetworkFlowTest           | Starting testcase
    17:22:14 | DEBUG | Kubernetes                | Removed the deployment: no-connection-source
    17:22:14 | INFO  | Services                  | SR does not detect the deployment no-connection-source yet: io.grpc.StatusRuntimeException: NOT_FOUND: deployment with id '6905edf9-75ea-4b7f-a9e6-f744745889b0' does not exist: not found
    17:22:14 | INFO  | NetworkFlowTest           | two-ports-connect-source has no incoming connections - ensure ingress spec is empty
    17:22:14 | INFO  | NetworkFlowTest           | tcp-connection-source has no incoming connections - ensure ingress spec is empty
    17:22:14 | INFO  | NetworkFlowTest           | single-connection-source has no incoming connections - ensure ingress spec is empty
    17:22:14 | INFO  | NetworkFlowTest           | tcp-connection-target has incoming connections - ensure podSelectors/namespaceSelectors match sources from graph
    17:22:14 | DEBUG | NetworkFlowTest           | sourceDeploymentsFromNetworkPolicy: [tcp-connection-source-qa2, two-ports-connect-source, tcp-connection-source]
    17:22:14 | DEBUG | NetworkFlowTest           | sourceDeploymentsFromGraph: [tcp-connection-source-qa2, two-ports-connect-source, tcp-connection-source]
    17:22:14 | INFO  | NetworkFlowTest           | udp-connection-source has no incoming connections - ensure ingress spec is empty
    17:22:14 | INFO  | NetworkFlowTest           | nginx-connection-target has LB/External incoming traffic - ensure All Ingress allowed
    17:22:14 | INFO  | NetworkFlowTest           | external-destination-source has no incoming connections - ensure ingress spec is empty
    17:22:14 | INFO  | NetworkFlowTest           | tcp-connection-source-qa2 has no incoming connections - ensure ingress spec is empty
    17:22:14 | INFO  | NetworkFlowTest           | short-consistent-source has no incoming connections - ensure ingress spec is empty
    17:22:14 | INFO  | NetworkFlowTest           | udp-connection-target has incoming connections - ensure podSelectors/namespaceSelectors match sources from graph
    17:22:14 | DEBUG | NetworkFlowTest           | sourceDeploymentsFromNetworkPolicy: [udp-connection-source]
    17:22:14 | DEBUG | NetworkFlowTest           | sourceDeploymentsFromGraph: [udp-connection-source]
    17:22:14 | INFO  | NetworkFlowTest           | Ending testcase

NetworkFlowTest > Verify generated network policies PASSED

/test ocp-4-10-qa-e2e-tests ocp-4-12-qa-e2e-tests ocp-4-13-qa-e2e-tests

/test gke-qa-e2e-tests

/test gke-qa-e2e-tests

/test ocp-4-13-qa-e2e-tests gke-nongroovy-e2e-tests

It runs nicely in CI:
NetworkFlowTest > Verify generated network policies STANDARD_OUT
    16:18:38 | INFO  | NetworkFlowTest           | Starting testcase
    16:18:38 | DEBUG | Kubernetes                | Removed the deployment: no-connection-source
    16:18:38 | INFO  | Services                  | SR does not detect the deployment no-connection-source yet: io.grpc.StatusRuntimeException: NOT_FOUND: deployment with id '9ffcfee7-c0b3-41a1-9119-c68f114c21ac' does not exist: not found
    16:18:38 | INFO  | NetworkFlowTest           | Verifying graph edges of tcp-connection-target
    16:18:38 | INFO  | NetworkFlowTest           | tcp-connection-target has incoming connections
    16:18:38 | DEBUG | NetworkFlowTest           | sourceDeploymentsFromGraph: [two-ports-connect-source, tcp-connection-source, tcp-connection-source-qa2]
    16:18:38 | INFO  | NetworkFlowTest           | Verifying graph edges of udp-connection-target
    16:18:38 | INFO  | NetworkFlowTest           | udp-connection-target has incoming connections
    16:18:38 | DEBUG | NetworkFlowTest           | sourceDeploymentsFromGraph: [udp-connection-source]
    16:18:39 | INFO  | NetworkFlowTest           | tcp-connection-target has incoming connections - ensure podSelectors/namespaceSelectors match sources from graph
    16:18:39 | DEBUG | NetworkFlowTest           | sourceDeploymentsFromNetworkPolicy: [tcp-connection-source-qa2, tcp-connection-source, two-ports-connect-source]
    16:18:39 | DEBUG | NetworkFlowTest           | sourceDeploymentsFromGraph: [two-ports-connect-source, tcp-connection-source, tcp-connection-source-qa2]
    16:18:39 | INFO  | NetworkFlowTest           | udp-connection-source has no incoming connections - ensure ingress spec is empty
    16:18:39 | INFO  | NetworkFlowTest           | short-consistent-source has no incoming connections - ensure ingress spec is empty
    16:18:39 | INFO  | NetworkFlowTest           | external-destination-source has no incoming connections - ensure ingress spec is empty
    16:18:39 | INFO  | NetworkFlowTest           | nginx-connection-target has LB/External incoming traffic - ensure All Ingress allowed
    16:18:39 | INFO  | NetworkFlowTest           | tcp-connection-source-qa2 has no incoming connections - ensure ingress spec is empty
    16:18:39 | INFO  | NetworkFlowTest           | tcp-connection-source has no incoming connections - ensure ingress spec is empty
    16:18:39 | INFO  | NetworkFlowTest           | single-connection-source has no incoming connections - ensure ingress spec is empty
    16:18:39 | INFO  | NetworkFlowTest           | two-ports-connect-source has no incoming connections - ensure ingress spec is empty
    16:18:39 | INFO  | NetworkFlowTest           | udp-connection-target has incoming connections - ensure podSelectors/namespaceSelectors match sources from graph
    16:18:39 | DEBUG | NetworkFlowTest           | sourceDeploymentsFromNetworkPolicy: [udp-connection-source]
    16:18:39 | DEBUG | NetworkFlowTest           | sourceDeploymentsFromGraph: [udp-connection-source]
    16:18:39 | INFO  | NetworkFlowTest           | Ending testcase

NetworkFlowTest > Verify generated network policies PASSED


C#: Fix building OpenVisualStudio executable

Since moving the TFM to .NET Core we need to add some configuration to cross-compile a Windows executable from Linux.

Fixes https://github.com/godotengine/godot/issues/88447.

Thanks!


Fix loading netrc flags from environment

Since 1aa722ba5c63bf4c5985069e478b2cf9c1ab6919, the flags netrc.{machine,username,password} can't be loaded from the environment anymore. This pull request fixes this and closes #54.

@appleboy can you please merge this? Same issue here.


Notifications: Add email support for duplicate test cases

Checklist
General

[x] I tested all changes and their related features with all corresponding user types on a test server.
[x] Language: I followed the guidelines for inclusive, diversity-sensitive, and appreciative language.
[x] I chose a title conforming to the naming conventions for pull requests.

Motivation and Context
This PR adds email support for the NotificationType DUPLICATE_TEST_CASES, i.e. if duplicate test cases (so far only relevant for programming exercises) occur (these are tests in the TEST repository with the same name (they have to be in different Classes!).
This is a critical issue that blocks the correct workflow for students and their result processing.
Therefore @krusche asked me to add email support so Instructors and Editors will be informed via email (because the webapp can be overlooked, etc.)
There are no settings for this NotificationType/Email. You can not deactivate them due to their criticality. (This is a requirement by @krusche)
I do not change any of the logic that decides when to trigger such a notification. I simply added email support for the legacy implementation. (The majority of the LoC are due to new tests)
Steps for Testing

Prerequisites:

1 Instructor
1 Programming Exercise
TS1 (only here the email support is enabled)
Make sure that you use your tum account (e.g. de42sos) so it is possible for you to receive and look at the email!
You have to be an instructor of the course (admin might not work)

I highly recommend simply following the steps in the video to trigger the duplicate test case notification/email. (It took me way too much time to figure out how to trigger this notification, so please follow the video)
I repeat: I did not change the logic of when or why this notification is triggered, I just added the email. The goal is to check if the email is created and it is valid.
*It is not necessary to click the last button, the notification should appear after you have added the duplicated test case. Otherwise 2 notifications/email might/will be created
(I am using the same user in two tabs (no incognito, etc. needed for this one) One tab is also enough
https://user-images.githubusercontent.com/65814168/144247861-58c60605-6157-41fd-a747-858f5dbc9c66.mp4
Written steps:

create a new default programming exercise

open it as an instructor (in course management) and click on the "edit in editor" button.

change the "repostory"/tab to TEST.

Look at the File Browser to your left

Click on the test folder and add a new file: e.g. "PlagiarismTest.java"

edit this new file:

e.g. add the following code into it :

package plagiarismHope;

import org.junit.jupiter.api.*;
import static org.junit.jupiter.api.Assertions.*;

import java.lang.reflect.InvocationTargetException;
import java.text.*;
import java.util.*;

import static de.tum.in.test.api.util.ReflectionTestUtils.*;

import de.tum.in.test.api.BlacklistPath;
import de.tum.in.test.api.PathType;
import de.tum.in.test.api.StrictTimeout;
import de.tum.in.test.api.WhitelistPath;
import de.tum.in.test.api.jupiter.Public;

@Public
@WhitelistPath("target") // mainly for Artemis
@BlacklistPath("target/test-classes") // prevent access to test-related classes and resources
class PlagiarismTest {

    @Test
    @StrictTimeout(1)
    void testMergeSort() {
        fail("MergeSort does not sort correctly");
    }
}

press submit.

check notification & email

Review Progress
Code Review

[x] Review 1
[x] Review 2

Manual Tests

[x] Test 1
[ ] Test 2

Test Coverage
I simply added a new email.html (case) to the already working, unchained notification-email pipeline.
So no change to the logic.
I actually added a couple of tests:

I added/adjusted test for GroupNotificationFactory for the notification type DUPLICATE_TEST_CASES
I created a new test class NotificationTargetTest.java which tests methods that are used by the MailService to extract the correct URL from the notification.target property (this class is needed to be able to generate a valid link/URL based on a notification (prior to notification emails this was not necessary on the server-side (i.e. the URL was extracted only on the client-side)
(NotificationTarget ~ 100%)
(GroupNotificationFactory > 90%)

Screenshots
Notification

Email

Tested on TS1. Notification and Email were both triggered as expected. Somehow, I receive the notification and the email twice for the same exercise. I observed this both times I created an exercise and followed your testing steps. Besides that, I'm not sure how meaningful the email footer (You can (un)subscribe to similar emails...) is in this case, as the notification cannot be disabled. This might lead to confusion as it suggests that the deactivation is possible. But this is rather a little nit I assume.

Thank you for testing this PR.
About your findings/comments:
a) Multiple notifications:
I assume that you clicked the "rebuild" button at the end just as I did in the video.
This last step (clicking the button) is not needed. One notification should appear without pressing the button.
I think due to this pressed button a second check is done and that's the reason why a second notification is created ( I tested this difference to make sure) (To be frank, I do not really want to recreate the video) + I have not touched the logic when things are triggered. This PR is simply about adding email support for these rare but crucial cases. So there is no real situation that spam could be created.
b) I understand you point about the settings link.
But I think I will keep the link because it states "you can (un)subscribe to similar ones) so this information is not really misleading + It is part of the newly established "convention". Just like a logo or the far well at the end.^^

I am currently waiting for this refactoring PR to get merged, resolve the merge conflicts and then open it again for review https://github.com/ls1intum/Artemis/pull/4462

After  https://github.com/ls1intum/Artemis/pull/4462 has been merged I resolved the merge conflicts and this PR is once again ready to review.


i18n:fr fix below/after

The French translation for below and after/above was reversed.

You're right, I seem to have gone cross-eyed!


Voice recorder button throws an exception when qnabot is embedded on website

Describe the bug
Selecting the mic button when the qnabot is embedded in a HTML website (parent.html) results in an exception: "Uncaught (in promise) DOMException: The element has no supported sources." The error is on line 29 of lex-web-ui.min.js, as part of setAudioAutoPlay.
To Reproduce
Deploy the bot as an embedded UI and click the mic button.
Expected behavior
Launch the audio recorder associated with the browser.
Please complete the following information about the solution:

[ ] Version: [e.g. v0.0.1]

To get the version of the solution, you can look at the description of the created CloudFormation stack. For example, "(SO0189) QnABot [...] v5.4.5".

[ ] Region: [us-east-1]
[ ] Was the solution modified from the version published on this repository? No
[ ] If the answer to the previous question was yes, are the changes available on GitHub?
[ ] Have you checked your service quotas for the services this solution uses? Yes
[ ] Were there any errors in the CloudWatch Logs? No, client side error

Screenshots
If applicable, add screenshots to help explain your problem (please DO NOT include sensitive information).
Additional context
Add any other context about the problem here.

Hi @chanbi-aws, I assume you are using v5.4.5 from your latest post. I recommend trying to upgrade to the latest version v5.5.0. I wasn't able to replicate this issue when deploying qnabot v5.5.0. Let me know if you still come across issues! Thanks.

After discussion with @chanbi-aws, this seems to be a bug from lex-web-ui, which our QnABot solution does not manage. This is occuring due to LLM (Bedrock) response returning a response wrapped in tags. This breaks any Polly based responses due to 'invalid ssml'.

This is a different issue to the 'invalid ssml'.

The issue occurs prior to any request to the LLM. The error is thrown when you click the 'mic' icon to record your voice input. Maybe this is an issue that needs to be raised with https://github.com/aws-samples/aws-lex-web-ui.

@chanbi-aws Is the embedded version of LexWebUi being used or was the full version from https://github.com/aws-samples/aws-lex-web-ui installed? Sounds like it is the full version based on the use of parent.html but want to confirm. If its the full version then this should be submitted against LexWebUi. Note a number of problems with voice mode were resolved in LexWebUi 0.20.2 which was released on 2023-11-28. So first step is going to be to upgrade to the latest LexWebUi at least greater than or equal to 0.20.2.

@bobpskier This comment should refer to this ticket 694.
In terms of the mic issue in the embedded page, I recommend using the latest lex build (20.6), otherwise this may be a bug for lex-web-ui. Closing this ticket out now

@michaelin-96 @chanbi-aws If the LLM (Bedrock) response is generating output to be used in a voice based response through QnABot, the handlers managing the request/response with Bedrock will need to manage output in a voice based SSML manner. That is, the Bedrock integration will need to provide a voice based response in valid SSML if that is supported. LexWebUi is not going to manage output from the Lex bot and perform correction to account for incorrectly formatted SSML. The integration in QnABot needs to identify that the request was made in voice mode and that the output should be in voice mode using valid SSML.
Is the response payload being provided to LexWebUi when the error occurs available to investigate further?
Is there a public endpoint that can be exercised to investigate?

I will raise an issue with aws-lex-web-ui. Updating the stack with the master.yaml (https://github.com/aws-samples/aws-lex-web-ui/blob/master/templates/master.yaml) successfully upgrades to v0.20.6, but when the UI initialises with version 0.20.5. Browser console output: "lex-web-ui.min.js:29 successfully initialized lex web ui version:  0.20.5"


Add Polisʹkyy Natsionalʹnyy Universytet

@I0VoONE0I Thank you for your patience while waiting for a review and processing your request. Pull request merged.


Avalanche doesn't send remote-write requests when --metric-interval alone is set

Issue

Thanos uses avalanche in e2e tests. About two weeks ago, one of the e2e tests which uses avalanche started failing.
The test was configuring --metric-interval=30s and --remote-write-interval=30s and expecting requests to be made every 30s from avalanche.
However, in write.go#L143 no timeseries is returned and avalanche doesn't make write requests.

Avalanche configuration
Avalanche configuration that wasn't working
--metric-count=10 \
--series-count=1 \
--metric-interval=30 \
--series-interval=3600 \
--value-interval=3600 \
--remote-write-interval=30s \
--remote-batch-size=10 \
--remote-requests-count=5

Avalanche configuration that worked
--metric-count=10 \
--series-count=1 \
--metric-interval=3600 \
--series-interval=30 \
--value-interval=30 \
--remote-write-interval=30s \
--remote-batch-size=10 \
--remote-requests-count=5

Related
https://github.com/thanos-io/thanos/pull/7620

hey @harry671003, can you share more details about what you're seeing?
I see samples being sent correctly when testing locally with both sets of CLI arguments you've provided.


[🐞] build scripts stuck after Built client modules in node/express adapter

Which component is affected?
Qwik Runtime
Describe the bug
When i run pnpm run build in express adapter it stuck after sometime
✓ built in 1.22s
✓ Built client modules
After this cli got stuck
Reproduction
https://github.com/harshmangalam/qwik-x
Steps to reproduce
No response
System Info
System:
    OS: macOS 13.3.1
    CPU: (8) arm64 Apple M1
    Memory: 42.33 MB / 8.00 GB
    Shell: 5.9 - /bin/zsh
  Binaries:
    Node: 18.16.0 - ~/.nvm/versions/node/v18.16.0/bin/node
    Yarn: 1.22.19 - ~/.nvm/versions/node/v18.16.0/bin/yarn
    npm: 9.5.1 - ~/.nvm/versions/node/v18.16.0/bin/npm
    pnpm: 8.6.12 - ~/Library/pnpm/pnpm
  Browsers:
    Chrome: 116.0.5845.187
    Safari: 16.4

Additional Information
No response

same here, static adapter: stuck at Built client modules

Can I have a reproduction that works on my machine? The current reproduction requires that Postgres DB is running, so I can't reproduce it.

[ ]

@mhevery  do you want dist and server code ?

I need to be able to build it so that I can see how it is failing. So I need a reproduction that is not dependent on installing a DB. I am asking for a simpler reproduction that stands on its own.

One more thing i noticed that even it is in stuck mode but it generate server bundle and when i manually stop the build process and run  pnpm run serve is working fine.

I need to be able to build it so that I can see how it is failing. So I need a reproduction that is not dependent on installing a DB. I am asking for a simpler reproduction that stands on its own.

Okay got it

Actually the problem is  related to drizzle migrator. After commenting the migration code build issues resolved.

import { drizzle } from "drizzle-orm/postgres-js";
// import { migrate } from "drizzle-orm/postgres-js/migrator";
import postgres from "postgres";
import * as schema from "./schema";
const DRIZZLE_DATABASE_URL = process.env["DRIZZLE_DATABASE_URL"] as string;

if (!DRIZZLE_DATABASE_URL)
  throw new Error("DRIZZLE_DATABASE_URL env variable missing");

// for migrations
// const migrationClient = postgres(DRIZZLE_DATABASE_URL, { max: 1 });
// migrate(drizzle(migrationClient, { schema }), {
//   migrationsFolder: "migrations",
// });

// for query purposes
const queryClient = postgres(DRIZZLE_DATABASE_URL);
export const db = drizzle(queryClient, { schema });

Great! The importance of having small repros! Can we close this issue?

Sure you can close it


BUG: Failure with upgrade if DB already exists

What happened:
When running helm upgrade -i -n kubeclarity kubeclarity -f values.yml . if the db already exists kubeclarity will fall into a crash loop.
I believe it has to do with this section of code.
What you expected to happen:
I should be able to update the deployment and not have to worry about kubeclarity crashing because the db already exists.  In order to get around this i have to destroy the existing PVC and PV and reinstall from scratch.
How to reproduce it (as minimally and precisely as possible):

Launch kubeclarity via helm install -n kubeclarity kubeclarity -f values.yml .
Wait till it's up and running.
Make any change (say ENV Var) to the deployment
Run helm upgrade -i -n kubeclarity kubeclarity -f values.yml .
See error

Are there any error messages in KubeClarity logs?
(e.g. kubectl logs -n kubeclarity --selector=app=kubeclarity)
It's this section of code that's causing the error:
https://github.com/openclarity/kubeclarity/blob/7f3d166ad4feb0bda93138e6c4e4fe12b6c360a5/backend/pkg/database/database.go#L476-L478
Environment:

Kubernetes version (use kubectl version --short):  Client Version: v1.22.2 / Server Version: v1.22.9+vmware.1
KubeClarity version (use kubectl -n kubeclarity exec deploy/kubeclarity -- ./backend version) : Version: v2.7.0 / Commit: 8aced6f31c18b970a997e393bfcbc0f0a3680ce6 / Build Time: 2022-10-30T08:15:59Z
Cloud provider or hardware configuration:  AWS
Others:  Kubernetes Flavor -> TKG (Vmware)

@jheck88 thanks for reporting the issue, can you please share the error message that cause the crash loop?
You can try to use -p flag when running kubectl logs to print the logs for the previous instance of the container.


Use ExecutionContext/Scheduler.global when it's not implicit

ExecutionContext.Implicits.global is just an implicit reference to ExecutionContext.global, so when it's not imported to be implicit, the direct reference is clearer, in my opinion.
The same holds for Monix' Scheduler.

True :) Thanks!


add pypi variables

Coverage remained the same at 84.291% when pulling b3daad7a383ca82eebaebe66bd90c63a23f769f6 on hendrik-cliqz:pip-variables into c2ab32f04a8f4f65c3acf26759a437e132952eea on cliqz-oss:master.


Trouble disabling SC_CLOSE for terminal's window

Windows Terminal version
1.17.11461.0
Windows build number
10.0.19044.0
Other Software
PowerShell 7+
Steps to reproduce
I would like to disable the close (from the ALT+Space floating menu and the top-left window's "X") button for the terminal that my PowerShell session is loaded in. So, I run the following function (based on this SO answer and this blog post):
function Disable-ThisTerminalClose {
    #Calling user32.dll methods for Windows and Menus
    $MethodsCall = '
[DllImport("user32.dll")] public static extern long GetSystemMenu(IntPtr hWnd, bool bRevert);
[DllImport("user32.dll")] public static extern bool EnableMenuItem(long hMenuItem, long wIDEnableItem, long wEnable);
[DllImport("user32.dll")] public static extern long SetWindowLongPtr(long hWnd, long nIndex, long dwNewLong);
[DllImport("user32.dll")] public static extern bool EnableWindow(long hWnd, int bEnable);
'

    #Create a new namespace for the Methods to be able to call them
    Add-Type -MemberDefinition $MethodsCall -name NativeMethods -namespace Win32

    Write-Host "Added NativeMethods type..."

    #WM_SYSCOMMAND Message
    $MF_GRAYED = 0x00000001L    #Indicates that the menu item is disabled and grayed so that it cannot be selected.
    $MF_DISABLED = 0x00000002L #Indicates that the menu item is disabled, but not grayed, so it cannot be selected.
    $MF_ENABLED = 0x00000000L #Indicates that the menu item is enabled and restored from a grayed state so that it can be selected.
    #... http://msdn.microsoft.com/en-us/library/windows/desktop/ms647636(v=vs.85).aspx

    $SC_CLOSE = 0xF060
    #... http://msdn.microsoft.com/en-us/library/windows/desktop/ms646360(v=vs.85).aspx

    #Get window handle of this Powershell process (should be the Windows Terminal?)
    $PSWindow = Get-Process | Where-Object { $_.Name -like "*Terminal*" }
    Write-Host ("Found PSWindow: " + $PSWindow)
    $hwnd = $PSWindow.MainWindowHandle
    Write-Host ("hwnd: " + $hwnd)

    #Get System menu of windows handled
    $hMenu = [Win32.NativeMethods]::GetSystemMenu($hwnd, 0)

    # #Window Style : TOOLWINDOW
    # [Win32.NativeMethods]::SetWindowLongPtr($hwnd, $GWL_EXSTYLE, $WS_EX_TOOLWINDOW) | Out-Null

    #Disable X Button and window itself
    Write-Host "About to disable close functionality..."
    [Win32.NativeMethods]::EnableMenuItem($hMenu, $SC_CLOSE, ($MF_GRAYED + $MF_DISABLED))

    Write-Host "Disabled!" -ForegroundColor Red
}

Run this function (or, paste it's body into a PowerShell 7+ session.
Expected Behavior
I was hoping that the close button (both X and in floating menu) would be disabled.
Actual Behavior
Close/X are not disabled.

Yea, messing with Terminal's HWND is 100% not supported.
Focus mode might be something that interests you, though, that'll entirely hide the titlebar (including the tabs).
We could theoretically make this a window theme setting. You can already hide the close button on the tabs, so there's probably room for configuring the close button too. I coulda swore I had some json laying around for that...

Why would you like to disable the close button?

I need to trigger some cleanup scripts on exit, but PowerShell.Exiting still does not trigger correctly for when the user presses the X button. At this point, the issue has been open for so long, that I am not sure what is going on there: https://github.com/PowerShell/PowerShell/issues/8000
So, I thought I'd just try to disable the X button.

We could theoretically make this a window theme setting. You can already hide the close button on the tabs, so there's probably room for configuring the close button too. Something ala: #12632 (comment)

@zadjii-msft That would be super helpful, actually. I realize that it wouldn't disable Close in the alt+Space menu, but that would still be a major improvement. Of course, the best solution is if PowerShell.Exiting just finally worked correctly...

@zadjii-msft, I recognize the reasons why EnableMenuItem may not be supported in Terminal, but documentation around those APIs should clarify limits. The biggest issue with EnableMenuItem as I see it is that in a tabbed host, modifying the host is undefined; is the app modifying the tab, the window, and/or both?
AttachConsole, GetConsoleWindow, GetConsoleTitle, SetConsoleTitle, GetSystemMenu, and GetMenuState do work, which follows the documentation. This is great, as it does allow me to create an app which has a behavior in conhost and it seemingly does the right thing in Terminal. On the other hand, SetConsoleMode and EnableMenuItem seem to work, in that the calls don't cause an exception and looking at the state changes the state seems to have been changed, but setting the flag for EnableMenuItem doesn't seem to actually disable the Close button and disable the corresponding menu item. EnableMenuItem seems like it should affect the tab Close button, and I was surprised to see that it doesn't when the underlying structure was modified using documented Windows API calls.

SetConsoleMode is a little trickier to evaluate as the flags I'm changing have to do with disabling ENABLE_LINE_INPUT, disabling ENABLE_ECHO_INPUT, enabling ENABLE_EXTENDED_FLAGS, enabling ENABLE_MOUSE_INPUT, and enabling ENABLE_QUICK_EDIT_MODE, which I've only really looked at the effect in conhost.
If these APIs aren't being honored in Terminal, then the API documentation should indicate that they only affect conhost, or Terminal should support these flags for continued backwards compatibility. How do other 3rd party terminal apps handle these states?
Maybe some of these API calls will automatically detach the tab from the Terminal and transition to Focus mode? Restoring the state would then revert out of Focus mode if state has been restored and/or FreeConsole is called. It is a different behavior, but then again this might be seen as trying to follow backwards compatible behavior and intent. This suggestion seems like a hack on a hack though.
I haven't created an issue around my findings, as this was already an issue concerning the behavior around:
const auto menu = GetSystemMenu(GetConsoleWindow(), FALSE);
EnableMenuItem(menu, SC_CLOSE, MF_GRAYED);

It seemed appropriate to add to the discussion here first, and perhaps this only needs to be resolved with documentation changes if these aren't seen as backwards compatibility concerns.


Add filter feature

Change logs:

add filter button
add content type controller
change pagination to pagination based on url for adapting builtin filter component behavior
fix security issue https://github.com/vinubabu323/strapi-plugin-excel-export/issues/10

Screenshot:

Any progress on this. Looking for this feature


How to make an invertible mapping between two variables whose dimensions are different ?

 In the image super-resolution task, the input and output have different dimensions. How to build such an invertible mapping between them ?
Take an example:
If I have a low-resolution(LR) image x, and I have had an invertible function G. I can feed LR image x into G, and generate an HR image y. But can you ensure that we could obtain an output the same as x when we feed y into G_inverse?
y = G(x)
x' = G_inverse(y) =? x
I would appreciate it if you could offer some help.

 In the image super-resolution task, the input and output have different dimensions. How to build such an invertible mapping between them ? Take an example: If I have a low-resolution(LR) image x, and I have had an invertible function G. I can feed LR image x into G, and generate an HR image y. But can you ensure that we could obtain an output the same as x when we feed y into G_inverse?
y = G(x) x' = G_inverse(y) =? x
I would appreciate it if you could offer some help.


[BUG] Gemma 2 - 27B Regression

PR https://github.com/ModelCloud/GPTQModel/pull/131 added Gemma 2 support but in our testing only 9B models are working. This ticket is to track the 27B inference issue post quantization.

27B model inference instability appears to be something unique to gemma 2. We have tested latest main/Transformers and even though reports of it fixed, 27B still cannot pass our tests.

Make sure we re-check this inference bug with latest transformers gemma 2 27B fixes in https://github.com/huggingface/transformers/releases/tag/v4.42.4

@Qubitium There is no GPTQ model for gemma-2-27b on HuggingFace. Could you help upload a version?

@maxin9966 We have quanted the 27b model but inference did not pass our ppl quality test so we did not upload it. There is something special/wrong with the 27b model that is breaking inference.

Are you using Vllm for inference , then it may be attention , for gemma 2  27 you need flash infer for attention

@LRL-ModelCloud Re-test 27B inference ppl with vllm with flash infer, and sglang with flash infer (lastest).

@Qubitium Thank you very much. I would like to know if the 27b-gptq model has passed the test when using flash infer.

@maxin9966  It's the weekend so we will re-test next week.

Gemma 2 27B model download: https://huggingface.co/ModelCloud/gemma-2-27b-it-gptq-4bit
vllm/sglang fixed gemma 2 27b inference

Can we use GPTQmodel to quantize our gemma-2-27B finetuned models?

@Qubitium Thank you very much. 👍
I have a few more questions. Could you please guide me?

Between sglang and vllm, which one is more suitable for a production environment? How much better is the throughput of sglang compared to vllm in general? Can sglang's stability support a production environment?
Between flashinfer and flashattn2, which one performs better?

@maxin9966

You have to benchmark these yourself. Both are fast, and depending on model, one is faster than the other. They are verry different when it comes to kv cachig and re-use.
Again, you have to benchmark this yourself.

Could you please share your script for quantizing gemma 27b ? I have been trying to quantize it but I keep getting the error
torch._C._LinAlgError: linalg.cholesky: The factorization could not be completed because the input is not positive-definite (the leading minor of order 1 is not positive-definite)

Could you please share your script for quantizing gemma 27b ? I have been trying to quantize it but I keep getting the error torch._C._LinAlgError: linalg.cholesky: The factorization could not be completed because the input is not positive-definite (the leading minor of order 1 is not positive-definite)

@king398  Do the following:

Increase damp value
Make sure you have at least 512/1024 rows of data in calibration.

@Qubitium Why does running gemma-2-it-27b-gptq through vllm produce all outputs as , I have tested different versions of flashinfer and vllm, and the results are the same.
vllm:
VLLM_ATTENTION_BACKEND=FLASHINFER CUDA_VISIBLE_DEVICES=1 python -m vllm.entrypoints.openai.api_server --model ModelCloud/gemma-2-27b-it-gptq-4bit --gpu-memory-utilization 0.9 --quantization gptq --host <IP_ADDRESS> --port 1231 -tp 1 --dtype float16 --served-model-name gpt --trust-remote-code --enable-prefix-caching --enforce-eager
output:
[Choice(finish_reason='length', index=0, logprobs=None, message=ChatCompletionMessage(content='

Usually when I see this, the first thing I would look at is your tokenizer. Check you have latest transformers with tokenizer fixes and latest vllm. Lastly, check your bos, eos, pad token are alll correct as relates to gemma 2 it model. If any of the bos/eos/pad token is incorrectly set then you get bad output.

It could also be the issue of the dtype used , it was trained with bfloat 16 by google and known to produce these outputs when using any other dtype like float 16

Like @sparsh35  noted, if model is bf16 and you use fp16, there is a conversion loss.

@Qubitium
VLLM_ATTENTION_BACKEND=FLASHINFER CUDA_VISIBLE_DEVICES=1 python -m vllm.entrypoints.openai.api_server --model ModelCloud/gemma-2-27b-it-gptq-4bit --gpu-memory-utilization 0.9 --quantization gptq --host <IP_ADDRESS> --port 1231 -tp 1 --dtype bfloat16 --served-model-name gpt --trust-remote-code --enable-prefix-caching --enforce-eager
error:
ValueError: torch.bfloat16 is not supported for quantization method gptq. Supported dtypes: [torch.float16]

@maxin9966  You're right. gptq models are only fp16 capable. We will check what's going with vllm and this gemma-2-27b quant.


optimize: CodecFactory and LockerFactory get synchronized

Ⅰ. Describe what this PR did
optimize CodecFactory and LockerFactory get synchronized
Ⅱ. Does this pull request fix one issue?

Ⅲ. Why don't you add test cases (unit test/integration test)?
Ⅳ. Describe how to verify it
Ⅴ. Special notes for reviews

Codecov Report

Merging #1799 into develop will not change coverage.
The diff coverage is 0%.

@@            Coverage Diff             @@
##             develop    #1799   +/-   ##
==========================================
  Coverage      55.06%   55.06%
  Complexity      2345     2345
==========================================
  Files            418      418
  Lines          14197    14197
  Branches        1701     1701
==========================================
  Hits            7818     7818
  Misses          5658     5658
  Partials         721      721

Impacted Files
Coverage Δ
Complexity Δ

.../main/java/io/seata/server/lock/LockerFactory.java
45% <0%> (ø)
3 <0> (ø)
:arrow_down:

...rc/main/java/io/seata/core/codec/CodecFactory.java
0% <0%> (ø)
0 <0> (ø)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7e1bc6b...069cb82. Read the comment docs.


Vercel build fails because of "parseBody" webhook

Describe the bug
I cloned a simple blog project from this Stablo template, then add revalidate (slug) to the code & deploy to Vercel. Build error at parseBody method: Type error: Expected 0 type arguments, but got 1.
To Reproduce
Steps to reproduce the behavior:

Add caching revalidate to your project, in my situation, I use the example code by Sanity team
Deploy to Vercel to trigger the auto build
See error: Type error: Expected 0 type arguments, but got 1.

Expected behavior
Build passes
Screenshots

Which versions of Sanity are you using?
Please see the package.json file here:
{
  "private": true,
  "scripts": {
    "dev": "next dev",
    "build": "next build",
    "postbuild": "next-sitemap",
    "start": "next start",
    "sanity": "sanity dev",
    "sanity-import": "sanity dataset import lib/sanity/data/production.tar.gz production",
    "sanity-export": "sanity dataset export production lib/sanity/data/production.tar.gz",
    "lint": "next lint"
  },
  "dependencies": {
    "@headlessui/react": "^1.7.13",
    "@heroicons/react": "^2.0.17",
    "@portabletext/react": "^2.0.2",
    "@sanity/code-input": "^4.1.0",
    "@sanity/icons": "^2.2.2",
    "@sanity/image-url": "^1.0.2",
    "@sanity/table": "^1.0.1",
    "@sanity/types": "^3.8.3",
    "@sanity/ui": "^1.3.1",
    "@sanity/vision": "^3.8.3",
    "@tailwindcss/typography": "^0.5.9",
    "@vercel/og": "^0.5.1",
    "@web3forms/react": "^1.1.3",
    "clsx": "^1.2.1",
    "date-fns": "^2.29.3",
    "get-video-id": "^3.6.5",
    "next": "^13.4.12",
    "next-sanity": "^5.1.1",
    "next-seo": "^5.15.0",
    "next-sitemap": "^4.0.6",
    "next-themes": "^0.2.1",
    "react": "^18.2.0",
    "react-dom": "^18.2.0",
    "react-hook-form": "^7.43.9",
    "react-iframe": "^1.8.5",
    "react-refractor": "^2.1.7",
    "sanity": "^3.9.0",
    "sanity-plugin-asset-source-unsplash": "^1.0.6",
    "styled-components": "^5.3.9",
    "swr": "^2.1.2",
    "typescript": "^5.0.4"
  },
  "devDependencies": {
    "autoprefixer": "^10.4.14",
    "eslint": "^8.38.0",
    "eslint-config-next": "^13.3.0",
    "eslint-config-sanity": "^6.0.0",
    "postcss": "^8.4.21",
    "prettier": "^2.8.7",
    "prettier-plugin-tailwindcss": "^0.2.7",
    "sharp": "^0.32.0",
    "tailwindcss": "^3.3.1"
  }
}

Additional context
This issue only appears on Vercel build. I test on local build with pnpm run build and it passes. I've spent 3 days to look around but couldn't find a resolution

Hi, you need to update next-sanity to get the latest typings used in the README :)


[release-1.19] add ip filter logic in GetProxyServiceTargets

Manual cherrypick required.
#48814 failed to apply on top of branch "release-1.19":
Applying: add ip filter logic in GetProxyServiceTargets
Using index info to reconstruct a base tree...
M	pilot/pkg/serviceregistry/kube/controller/controller_test.go
M	pilot/pkg/serviceregistry/kube/controller/endpointslice.go
Falling back to patching base and 3-way merge...
Auto-merging pilot/pkg/serviceregistry/kube/controller/endpointslice.go
CONFLICT (content): Merge conflict in pilot/pkg/serviceregistry/kube/controller/endpointslice.go
Auto-merging pilot/pkg/serviceregistry/kube/controller/controller_test.go
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
Patch failed at 0001 add ip filter logic in GetProxyServiceTargets
When you have resolved this problem, run "git am --continue".
If you prefer to skip this patch, run "git am --skip" instead.
To restore the original branch and stop patching, run "git am --abort".

fixed by https://github.com/istio/istio/pull/48837


Literature Review: GAMA

https://gama-platform.github.io/wiki/Tutorials
"Create an agent based SEIR disease model with 1 million agents distributed unevenly across 25 nodes with an initial outbreak of 100 agents. β and mean incubation period are inputs to the model. Run for 1 simulated year and plot the aggregated SEIR curves for the total population and the SEIR curves for each node in a 5 by 5 grid of plots."

Some quick reactions...

Just asking Chat with the prompt above for a working example of what we want didn't get very far.
Available for Ubuntu, but you have to download a .deb install of just doing an apt install (I think)
Looks like it's very IDE-based and very GUI-based.
A nice set of tutorials in the documentation; haven't seen a disease model yet.

These are helpful notes. Can we put your name on this one 😀 ?

These are helpful notes. Can we put your name on this one 😀 ?

Haha. I guess so. I might pass it off to someone else though. Hit a bit of a roadblock on Linux.

I used wget to download the .deb file from an existing Ubuntu VM, and than installed with apt.
It wasn't at all obvious what the binary name or path was. I did an updatedb and locate gama to find out it was:
/opt/gama-platform/Gama
/opt/gama-platform wasn't put in my path and the documentation https://gama-platform.org/wiki/Launching didn't tell me to do that.
After launching the splashcreen stayed up in front of the first dialog which was prompting me to pick a workspace folder. I can't interact with the dialog and can't proceed with testing the app.
Might be worth continuing on Windows instead.

Roadblock indeed.  🧱

OK, after rebooting my Ubuntu laptop I was able to get further. Running the luneray flu tutorials now.

(Looks a lot like my pygame ABM hello world I created late 2023.)


add .gitattributes to admin/framework to allow --prefer-dist install only core framework

With .gitattributes, when running --prefer-dist (mostly default implementation), we can get the something like this:
└─- vendor/codeigniter4
    ├── framework
         ├── license.txt
         ├── README.md
         ├── composer.json
         ├── license.txt
         ├── system

We can still get the full of framework structure in vendor directory with --prefer-source, documentation updated in Upgrading section in Composer Installation page.
Checklist:

[x] Securely signed commits
[x] User guide updated

Good change. Thank you!
We have more choices and we can choose a more minimalist version if we want.


Opening a project (attached) is freezing GUI after coloring the nodes and making cursor disappear

Discord username
No response
What type of issue is this?
Permanent – Occurring repeatably
Is this issue blocking you from using Enso?

[ ] Yes, I can't use Enso because of this issue.

Is this a regression?

[ ] Yes, previous version of Enso did not have this issue.

What issue are you facing?
Opening a project attached to the issue is having few problems:

nodes are appearing after a very long time
when nodes are colored after a few seconds GUI gets irresponsive:

mouse cursor is disappearing
there are huge lags on panning/zooming
it is not possible to edit the nodes

Expected behaviour
This project is rather small - it should work without problems
How we can reproduce it?
Open the project:
Unnamed_5_1.enso-project.zip.
Try to interact with it. Alert: there is a lot of performance issues while working with this project - when we were trying to clean up the project with James GUI was freezing pretty often ad getting desynchronized with engine. Separate issues will come.
Screenshots or screencasts
https://github.com/enso-org/enso/assets/12892578/e02ddfcd-1500-43ac-98a8-479c42f76df1
Enso Version
nightly 10.05.2023
Browser or standalone distribution
Standalone distribution
Browser Version or standalone distribution
standalone
Operating System
MacOS
Operating System Version
No response
Hardware you are using
No response

May have something to do with #6630

Yes, described behavior is the same as I'm experiencing (#6630).

I have reproduced this with a build older than the #6630 fixes, and found that in a current build performance is fine. I think it's safe to say this was another instance of the same problem, which has drastic improvements merged on both backend and frontend.


Get the list of all available containers

I'm facing an issue when trying to retrieve a specific container in an Android fragment.
AFAIK, I don't have any other tool provided by Kodein to retrieve a container in an Android Fragment other than closestDI which gives me a container but not the one that I want.
Is there any kind of global map or something that holds all of the available containers over which I could iterate to get a specific container ?

Although I have the DI container that I need in some reference before creating the fragment, I can't pass it as an arg in the constructor because Android forbid it. The bundle way doesn't seem to be a solution neither because the DI object is not serializable.

By default, Kodein-DI doesn't use global context, thus their is no possibility to retrieve a list of containers.
However, we provide a module to manage global container https://docs.kodein.org/kodein-di/7.1/extension/configurable.html
But we do not recommand its use.
What are you trying to achieve, from where your container comes from to not be reachable with the closest pattern?
Could using a module be a solution?

Thanks for your suggestion

What are you trying to achieve, from where your container comes from to not be reachable with the closest pattern?

I'm building a plugin system where some code is loaded dynamically based on the installed list of plugins. Therefore each plugin has its own Kodein-DI container which extends a "core" Kodein-DI container (defined in the main Application class). The problem I was facing was the following : the Activities and Fragments defined in each plugin could not reach the DI container of the plugin they belong to, closestDI was always giving me the "core" container.

Could using a module be a solution?

Finally, I managed to solve this issue by using a custom proxy function to define my containers so I can store them in a global map (referenced in the core Kodein-DI module). Then when I need a specific container, I can retrieve it directly from the map.
object DIProxy {
    private val containers: MutableMap<String, DI> = mutableMapOf()
    fun bind(name: String, di: DI) = containers.put(name, di)
    fun di(name: String) = lazy { containers[name]!! }
}

fun di() = DIProxy.di(BuildConfig.LIBRARY_PACKAGE_NAME)
fun DI.bindProxy() = DIProxy.bind(BuildConfig.LIBRARY_PACKAGE_NAME, this)

// when defining a container
// (...)
override val di: DI by DI.lazy {
    extend(commonDI)
    import(...)
    di.bindProxy()
}

// retrieve a stored container
import (..).di
// (...)
override val di by di()


Wants Review

One enhancement I'd like to recommend is to grab wants review from OSMCha. We could start just by looking at the first edit. Not sure if the welcome tool can grab the results from OSMCha otherwise a checkbox would need to be added just like the existing  welcomed and replied one.

The "Review requested" tag (and all other tags from OSMCha) is already displayed.

If the changeset has been checkd in OSMCha, it is also already displayed.

I try to keep the Welcome Tool as simple as possible and not duplicate features that are already available in OSMCha (for instance).
You can easily open a changeset in OSMCha from the Welcome Tool and check the changeset there.
Check tag will be automatically been displayed in the Welcome Tool at the next run (or when you'll run the tool manually - when that feature is added, see #18)
Does that answer to your request or am I missing something ?

For the initial tool, I agree just having it displayed with the changeset is sufficient. At some point in a future release, I'd like to see something on the list page highlighting mappers requesting a changeset review. For example, I just had https://www.openstreetmap.org/changeset/110465636 where a new mapper was trying to solve a very complex problem, on their first edit! Reviewing new mappers who request a review ranks higher on my priority list than others.

I think we should probably ask people who use the tool to use osmcha to validate/invalidate the changesets. That way, others know of the user has been welcomed as well as checked. However, I'm a bit confused. I marked this changeset as "good" https://osmcha.org/changesets/113363045/ , but it doesn't show up in https://welcome.osm.be/belgium/mapper/14403247 . You mention the "checked" status will show up in the tool, but I don't see any flag in osmcha to add this...

I marked this changeset as "good" https://osmcha.org/changesets/113363045/ , but it doesn't show up in https://welcome.osm.be/belgium/mapper/14403247 .

When did you do that ?
I'm only refreshing the data once a day.

You mention the "checked" status will show up in the tool, but I don't see any flag in osmcha to add this...

All the tags I'm displaying in the tool come from OSMCha.
I'm assuming that the "checked" tag comes from the "Verify > Good" button in OSMCha.

Hmmm, if it is only updated daily, maybe it does make sense to add an explicit flag "user's changeset was reviewed" next to the "user was welcomed" flag.

As far as I know, it only shows in OSMCha. It should leave a changeset comment on the review, good or bad, but only if the reviewer remembers to post the note.


Fix sorting inside dynamic custom attributes

Previously in the for loop for dynamicAttrs "attr.name" was added in the string template (which was undefined) while the required value was "attr" itself.
e.g. tailwindAttributes: ["ui"],
Before:
staticAttrs: "class,ui"
dynamicAttrs: ":class,v-bind:class,:undefined,v-bind:undefined"
After:
staticAttrs: "class,ui"
dynamicAttrs: ":class,v-bind:class,:ui,v-bind:ui"
fixes Prettier Plugin Tailwind within :ui={...} and [Prettier Plugin] Can't seem to get "tailwindAttributes" and/or "tailwindFunctions" to work?

lol oops — thanks

Released as v0.5.7 — may take a few for NPM to pick it up


App Store submission fails because of embedded frameworks

First off, I'm using Carthage. I'm not sure if that matters. App submission fails because there are embedded frameworks inside RocketData.framework. Specifically:

a Frameworks folder full of swift libs
libswiftRemoteMirror.dylib at the root level

Based on this discussion, I believe the fault is because "Always Embed Swift Standard Libraries" is set to Yes in RocketData.
I didn't have time to fully investigate, but simply deleted those frameworks using a build phase script in my project, like this:
rm -rf $SRCROOT/Carthage/Build/iOS/RocketData.framework/libswiftRemoteMirror.dylib
rm -rf $SRCROOT/Carthage/Build/iOS/RocketData.framework/Frameworks

Hmmm...there's no reason I need this set in the library afaik. I'm in
England without my laptop but if you submit a pr I can approve. Otherwise,
I can take a look in a week when I get back.
On Thu, Dec 22, 2016 at 3:24 AM Mark Krenek<EMAIL_ADDRESS>wrote:

First off, I'm using Carthage. I'm not sure if that matters. App
submission fails because there are embedded frameworks inside
RocketData.framework. Specifically:

a Frameworks folder full of swift libs
libswiftRemoteMirror.dylib at the root level

Based on this discussion
http://stackoverflow.com/questions/39480526/what-is-libswiftremotemirror-dylib-and-why-is-it-being-included-in-my-app-bundle,
I believe the fault is because "Always Embed Swift Standard Libraries" is
set to Yes in RocketData.
I didn't have time to fully investigate, but simply deleted those
frameworks using a build phase script in my project, like this:
rm -rf $SRCROOT/Carthage/Build/iOS/RocketData.framework/libswiftRemoteMirror.dylib
rm -rf $SRCROOT/Carthage/Build/iOS/RocketData.framework/Frameworks
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/linkedin/RocketData/issues/52, or mute the thread
https://github.com/notifications/unsubscribe-auth/ABMNTZlTb9aZqXaKqOf7VipLLUN0XwRlks5rKe2EgaJpZM4LTmse
.

#61


adding timeout on wait for acknowledge

Adding the ability to time out when waiting to acknowledge.

Thanks a lot and sorry for the delay!