Order Model

Similar to the Product model create the Order model
Discussion 🗣
The model needs to be created to handle API data.

Can do it. Where can I find the attributes list that we'll get from the API?

Can do it. Where can I find the attributes list that we'll get from the API?

Check the order_item.dart in widgets for the fields. And you just need to create the model for now. I'll create a separate issue to handle the data.

That's all right?

Should I also change the profile.dart file to pass Order object to order_item.dart instead of the individual attributes?

Should I also change the profile.dart file to pass Order object to order_item.dart instead of the individual attributes?

Not for now, there are a lot of issues assigned on Profile Screen, we need to wait till it is resolved. I'll create a separate issue for the Product and Order Model altogether

Should I also change the profile.dart file to pass Order object to order_item.dart instead of the individual attributes?

Not for now, there are a lot of issues assigned on Profile Screen, we need to wait till it is resolved. I'll create a separate issue for the Product and Order Model altogether

Okay then I'll push just this code

Done. Please check the code :)


Features/distributed streaming

runs black
Logging Enhancement: Introduces a log database for capturing stream outputs, scalable to track any incoming request data. This enhancement lays the groundwork for future analytics and incentive mechanisms by providing a robust data repository.
Stream Manager Implementation: Develops a Stream Manager that queries a configurable number of miners. It prioritizes the first miner to respond, allowing it to complete the request while ensuring that all streams are awaited and their outputs are processed. This includes logging all responses in the log database for comprehensive downstream analysis.

Results of api multiturn analysis regression tests:
Statistics for top_incentive:
Empty responses: 0 / 400 (0.00%)
Turn 1: % of non-empty responses: 100.00%
Turn 2: % of correctly guessed name: 3.00%
Turn 3: % of correctly guessed country: 5.00%
Turn 4: % of correctly guessed age: 2.00%
Average latency per response: 2.2159s

Raw outputs:
responses.csv
summary.txt

LGTM!
Not related to this change: Is this result from the current miners on mainnet? Based on summary.txt, looks like a lot of miners are using history context from previous API calls, i.e the first API call was "My name is Gianna, I live in Benin. I am 53 years old", and in all other API calls the response is often "Name = Gianna", "Country = Benin"
I remember last time the % of correct countries/names/ages were around 30%

Yes, the results are from mainnet


[Event Request] Codeunit 7600 "Calendar Management" - OnCalcDateBOCOnAfterGetCalendarCodes

Describe the request
Dear ALAppExtensions team,
On behalf of 4PS I would like to request integration event 'OnCalcDateBOCOnAfterGetCalendarCodes' to be changed in procedure CalcDateBOC in codeunit 7600 "Calendar Management".
    procedure CalcDateBOC(OrgDateExpression: Text[30]; OrgDate: Date; CustomCalendarChange: Array[2] of Record "Customized Calendar Change"; CheckBothCalendars: Boolean): Date
    var
        CompanyInfo: Record "Company Information";
        CalendarMgt: array[2] of Codeunit "Calendar Management";
        DateFormula: DateFormula;
        NegDateFormula: DateFormula;
        LoopCounter: Integer;
        NewDate: Date;
        LoopFactor: Integer;
        CalConvTimeFrame: Integer;
        CalendarChangeNo: Integer;
        IsHandled: Boolean;
    begin
        if not IsOnBeforeCalcDateBOCHandled(CustomCalendarChange, CalConvTimeFrame) then begin
            CustomCalendarChange[1].AdjustSourceType();
            CustomCalendarChange[2].AdjustSourceType();

            if CompanyInfo.Get() then
                CalConvTimeFrame := CalcDate(CompanyInfo."Cal. Convergence Time Frame", WorkDate()) - WorkDate();

            CustomCalendarChange[1].CalcCalendarCode();
            CustomCalendarChange[2].CalcCalendarCode();

            OnCalcDateBOCOnAfterGetCalendarCodes(CustomCalendarChange);
            //OnCalcDateBOCOnAfterGetCalendarCodes(CustomCalendarChange); //old
            OnCalcDateBOCOnAfterGetCalendarCodes(CustomCalendarChange, CalConvTimeFrame); //new
        end;

    [IntegrationEvent(false, false)]
    //local procedure OnCalcDateBOCOnAfterGetCalendarCodes(var CustomCalendarChange: Array[2] of Record "Customized Calendar Change") //old
    local procedure OnCalcDateBOCOnAfterGetCalendarCodes(var CustomCalendarChange: Array[2] of Record "Customized Calendar Change"; var CalConvTimeFrame: Integer) //new
    begin
    end;

Additional context
When CalConvTimeFrame has the value 0, we want to replace it with 7, to check at least 1 week.
Internal work item: AB#521546

Thanks for reporting this. We agree, and we’ll publish a fix asap, either in an update for the current version or in the next major release. Please do not reply to this, as we do not monitor closed issues. If you have follow-up questions or requests, please create a new issue where you reference this one.
Build ID: 18489.


How to create an optional any field ? Union(Unknown, Undefined) discards the Undefined

I'm trying to add a property to my schema which can either be anything or not defined at all (optional).
When using Unknown to allow the "anything" part, the "optional" aspect is discarded and Typescript requires that optionalField be included.
const mySchema = Record({
   id: String,
   optionalField: Union(Unknown, Undefined)
})

type MyType = Static<typeof mySchema>

// =>
MyType {
   id: string
   optionalField: unknown
}

What I would expect is :
// =>
MyType {
   id: string
   optionalField: unknown | undefined
}

// or
MyType {
   id: string
   optionalField ?: unknown
}

I succeeded with the following technique, though I still don't understand why Union(Unknown, Undefined) doesn't work.
const mySchema = Record({
   id: String
}).And(Partial({ optionalField: Unknown })

type MyType = Static<typeof mySchema>

// =>
MyType {
   id: string
} & {
   optionalField ?: unknown
}

There is a PR for this https://github.com/pelotom/runtypes/pull/131,

though I still don't understand why Union(Unknown, Undefined) doesn't work.

Because that's how TypeScript works. See https://github.com/pelotom/runtypes/pull/113#issuecomment-544199694. The technique you described is the correct way to achieve what you want to do.

FWIW #113 has been merged, so you will be able to use following syntax in the near future:
const mySchema = Record({
   id: String,
   optionalField: Optional(Unknown)
})

type MyType = Static<typeof mySchema>

// =>
MyType {
   id: string
   optionalField?: unknown
}


Cluster marker click event + polygon typo fix

@tomasprieboj asked for it, and it's of a great use for me too

Can you squash the commits so I'm able to review it? Thanks

sorry iam not using this lib anymore ... i use native google map
2018-02-01 20:10 GMT+01:00 Sebastian Holstein<EMAIL_ADDRESS>
Can you squash the commits so I'm able to review it? Thanks
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/SebastianM/angular-google-maps/pull/1278#issuecomment-362370234,
or mute the thread
https://github.com/notifications/unsubscribe-auth/ARB7pm8coeFUBi-RyMKTBVhMXuOeVXFGks5tQgw7gaJpZM4RVJuo
.

Well, yeah, i'll make that right away.

Look here for squashed commit https://github.com/SebastianM/angular-google-maps/pull/1278/commits/f8e02090483f0e07cf3081c2f561cacbd4ec72a1

Out of curiosity, how long before this update is made available on npm?

Up ?

I need it too please

Any news about this?

@SebastianM Anything I can help do to get this merged in?

Any chance of getting this up soon?

Any news ?

@SebastianM Any news?

any updates on this ?

merge?

any updates on this ?

any updates on this ?
I'll fix conflicts and check everything today.

Wow, now i've got to write a test for this code?

any updates on this ?

At this point i don't know what else could i do...


QuickStart error with "mud:not found"

what I got
ubuntu@DESKTOP-DD1DBGG:~$ pnpm create mud my-project
.local/share/pnpm/store/v3/tmp/dlx-25736 |  WARN  deprecated<EMAIL_ADDRESS>.local/share/pnpm/store/v3/tmp/dlx-25736 | +158 ++++++++++++++++
Packages are hard linked from the content-addressable store to the virtual store.
  Content-addressable store is at: /home/ubuntu/.local/share/pnpm/store/v3
  Virtual store is at:             .local/share/pnpm/store/v3/tmp/dlx-25736/node_modules/.pnpm
.local/share/pnpm/store/v3/tmp/dlx-25736 | Progress: resolved 158, reused 158, downloaded 0, added 158, done
? Template minimal

Creating a new package in /home/ubuntu/my-project.

Initializing a git repository
> git init

Installing dependencies using pnpm
> pnpm install --dir /home/ubuntu/my-project
 WARN  The "workspaces" field in package.json is not supported by pnpm. Create a "pnpm-workspace.yaml" file instead.
Packages: +4
++++
Packages are hard linked from the content-addressable store to the virtual store.
  Content-addressable store is at: /home/ubuntu/.local/share/pnpm/store/v3
  Virtual store is at:             node_modules/.pnpm
Progress: resolved 4, reused 4, downloaded 0, added 0

> my-project@ prepare /home/ubuntu/my-project
> yarn workspace contracts prepare
Progress: resolved 4, reused 4, downloaded 0, added 4, done
yarn workspace v1.22.19
yarn run v1.22.19
$ mud types
/bin/sh: 1: mud: not found
error Command failed with exit code 127.
info Visit https://yarnpkg.com/en/docs/cli/run for documentation about this command.
error Command failed.
Exit code: 127
Command: /home/ubuntu/.nodejs/bin/node
Arguments: /mnt/c/Program Files (x86)/Yarn/lib/cli.js prepare
Directory: /home/ubuntu/my-project/packages/contracts
Output:

info Visit https://yarnpkg.com/en/docs/cli/workspace for documentation about this command.
 ELIFECYCLE  Command failed.
Failed to install dependencies: 1

question
Should I install Mud cli globally before running the above command?
But this seems to be not recommended according to the doc.

Further more, I cloned the mud repo and run pnpm install. It turns out that mud and mud2 binaries were failed to be created.
ubuntu@DESKTOP-DD1DBGG:~$ cd mud
ubuntu@DESKTOP-DD1DBGG:~/mud$ pnpm install
...
...
 WARN  Failed to create bin at /home/ubuntu/mud/packages/std-client/node_modules/.bin/mud. The source file at /home/ubuntu/mud/packages/cli/dist/mud.js does not exist.
 WARN  Failed to create bin at /home/ubuntu/mud/packages/std-client/node_modules/.bin/mud2. The source file at /home/ubuntu/mud/packages/cli/dist/mud2.js does not exist.

I think the two issues you noted here are separate/different.
There seems to be some issues with our v1 cli/templates and pnpm (will be fixed in v2), can you try using yarn create mud instead?


Casey add wwise

Task card: https://trello.com/c/41YMa1af/946-programming-add-wwise-to-the-project
To test this, follow the instructions in README.md, and then open the settings and move the SFX volume slider. It should play a sine wave. It might be pretty quiet.

I don't know if this is intentional, but changing the sounds volume throws this error. I'm not sure if this is intentional or not.

 I don't know if this is intentional, but changing the sounds volume throws this error. I'm not sure if this is intentional or not.

Weird, I didn't get that error. Did you discard all changes from github desktop after pressing the integrate button?


Preview on custom Layout goes to the left corner

I am not sure if this is can be reported as an issue. But when creating a custom Layout and trying to preview the camera there it goes to the left corner of the layout.
It could be because the screen of the Motorola Moto C is smaller and when the layout is also a little smaller it just compresses itself.
If this can be viewed as an issue, then I have a more detailed despriction on StackOverflow : https://stackoverflow.com/questions/49880717/android-camera2video-preview-issue

This sample has been migrated to a new location (check README for more information).
As recommended by GitHub, we are closing all issues and pull requests now that this older repo will be archived.
If you still see this issue in the updated repo, please reopen the issue/PR there. Thank you!


[FR]: Automatically add tag to "partial" downloaded torrents

Is your feature request related to a problem? Please elaborate.
Issues with cross-seeds and broken files can be annoying to analyze and fix when caused by (related) torrents where not all files are selected for download.
Unwanted files often get created anyway because the pieces for the wanted files often overlap with unwanted files.
And when pre-allocation is enabled, those unwanted files (e.g. other TV show episodes) are just as big as the other files, making it also harder to detect why they are not working. You'd need to check all torrents that might include this file and then see if it might be unwanted.
Describe the solution you'd like
I think it would be useful if qbit_manage could automatically add a custom tag to all torrents where at least one file is set to "Do not download" / "Unwanted". As the default i suggest "partial".
Does your solution involve any of the following?

[X] New config option
[ ] New command option

Describe alternatives you've considered
It might be possible to change the GUI of VueTorrent to have this as a column, but it might be significantly more work than scanning with qbit_manage and adding a tag.
The other alternative would be a custom script that does something similar to what qbit_manage does, but that scans specifically for partial torrents.
Who will this benefit?
Anyone that has partial torrents in combination with cross-seeding, hardlinking, *arr setup etc.
Anyone that downloads only the sample video file or the first video file of a TV show pack to check it out and has cross-seed running.
Additional Information
No response

This is a highly niche use case and have never heard of anyone partially downloading torrents and cross-seeding them. It makes no sense for anyone to do that.
QBm also does not operate on non-complete (I.e. not downloaded or seeding or stopped torrents)

Unwanted files often get created anyway because the pieces for the wanted files often overlap with unwanted files.

that's a qbit bug you need to report to qbit if it is still downloading files you didn't tell it to


Proposed incorrect package.json

Fixed an error occurred during npm run doc

Error during additional-doc/summary.json read
Error during Additional documentation generation

Sorry i didn't understand the purpose of your PR, the last build works fine : https://travis-ci.org/compodoc/compodoc-demo-todomvc-angular/builds/461044907#L784


Use projectile-mode-line-prefix to set projectile mode line

See https://github.com/bbatsov/projectile/commit/19943eb85ff4cb30466568b0d357c22d398e8cf8
projectile-mode-line-lighter is obsolete (that is, it is defined as an obsolete variable in the latest version), and continued use will cause problem mentioned in #621 (That is, " Projectile" will be displayed in non-file buffers and remote buffers instead of " Proj").
I have been paying attention to the mode-line changes of projectile recently. Because this is caused by my issue.
If the inconvenience to you, I'm sorry.
BTW, why do you use so many setq-default instead of setq?
Thanks.

Great, thanks.

BTW, why do you use so many setq-default instead of setq?

In some cases it makes a difference whether you change the default value of a variable or its local or global value. Probably isn't necessary in all the cases I use it.


workflows: Bump timeout of ConformanceKind workflow

With the connectivity tests now taking almost 10min, the 30min timeout of the ConformanceKind workflow doesn't leave a lot of time for Cilium installation, image waiting time, etc. The workflow is thus often timing out.
This pull request bumps the timeout to 45min.

Added the needs-backport label since we are starting to hit the save in 1.12 branch


Replace AsyncWrite with Upload trait and rename MultiPartStore to MultipartStore (#5458)

Which issue does this PR close?

Closes #5458
Closes #5443
Closes #5526
Rationale for this change

What changes are included in this PR?

This changes put_multipart to instead return a Box<dyn MultipartUpload>` that provides an API much closer to that of the stores themselves. This gives users much more control over buffering and concurrency, whilst also opening up new possibilities for integrating object_store into systems such as parquet.
Are there any user-facing changes?

BTW: I really like the overall implementation!

I think this is now ready to go, I may refine it in subsequent PRs prior to release, but I am happy with where the core API is

I intend to follow this up with a PR with some further tweaks to the BufWriter / WriteMultipart structures, but I'd like to get the changes to ObjectStore in, and then iterate on top of this


Remove unused HiveViewNotSupportedException class

Usage got removed in 47dbba4140f474b3179e54176bfb12523f76ca57

Superseded by https://github.com/prestosql/presto/pull/5636


samples(storage): IAM conditions samples

(@frankyn) PHP Library released and this PR is now unblocked.

@bshaffer Friendly ping for review.


NameError: name 'model' is not defined

run webapp.py
NameError: name 'model' is not defined

This was resolved recently - please update and report back https://github.com/robmarkcole/yolov5-flask/issues/19


Print formatting options

Let's print non-verbose info by default (e.g. when listing streams, only list the names and maybe whether they're a source/derived stream).
Flags instruct the CLI to print more, like:

--output table, prints all information as a table (see kubectl get pods as an example), where e.g. stream type (source / derived) is also shown as a column.
--output plain, prints only reference names as plain text
--output json-raw, prints all information in a raw unformatted JSON
--output json, prints all information pretty

--output short would be -o.
The default should be configurable through the config file. The default if no preference is given, then the fallback is table.

Fixed in https://github.com/streammachineio/cli/releases/tag/v1.6.0


Convert existing models with cache duplication to symlinks

Is your feature request related to a problem? Please describe.
I have duplication of multiple models in windows with same large model files stored on both blobs and snapshots folder that was downloaded in past. This is taking lots of extra space which can be reduced by converting to symlink versions.
For new models I run python terminal as admin and it creates 0KB symlink in snapshots folder and I see actual files are stored on blobs folder. There is no duplicate extra space taken.
I have also seen some models store actual files on snapshots folder and the blobs folder is empty.
Describe the solution you'd like
Convert existing model folder that have duplications to symlink versions.
Describe alternatives you've considered
Delete cache for duplicated models and redownload with admin privilege.
Additional context

Hi @quickgrid :wave:
Symlinks on windows have indeed be a topic so far. The behavior you mentioned (some duplicated files, some not, some in blobs, some in snapshots,...) comes from the fact that symlinks are not supported by default on Windows. What we really encourage is to set developer mode on your machine or always run as admin (less ideal). You should normally get a warning message about this.
For a more detailed explanation, please read https://github.com/huggingface/huggingface_hub/issues/1062#issuecomment-1256054899 (and the full issue). The behavior has been introduced in by PR https://github.com/huggingface/huggingface_hub/pull/1067. It is not optimal but that's "the best we can do" to get huggingface_hub working on all setups.
Now, if you want to fix your situation the best solution is to enable developer mode and clean your existing cache. Hope this is fine with you :)


Equation numbers occasionally become "()"

Not observed my dev vault, but constantly observed a fresh new test vault.

I've finally figured it out: it was due to the absence of finishRenderMath() call...


Allow rendering with different X and Y scale

Hi,
We need to render pages sometimes with diffent X and Y scales. But currently there is no public method to do so. Please check the pull request which adds support for separate X and Y scale when rendering to a graphics object.

@choeflake  Could you close the PR as PDFBOX-4057 was implemented?

@msahyoun done!


windowOpened fires too quickly

Problem
nothing happens when the exe is running
Solution
put a pause in and wait for the window to open before selecting the usb key option
    private void onWindowOpened(object? sender, ShellEventArgs args) {
        //Debug.WriteLine($"Window Open Dectected: {args.shellEvent}");
        if (args.shellEvent == ShellEventArgs.ShellEvent.HSHELL_WINDOWCREATED) {
            Thread.Sleep(1000); // << there might be a better way
            windowOpened?.Invoke(this, new SystemWindow(args.windowHandle));
        }
    }

Hi @Omzig, thank you for alerting me to this issue.
Yeah there is a little bit of delicate timing when interacting with this UI. I already have seen this type of issue when finding the CredentialsList element, which is lazily rendered roughly 12ms after the dialog box appears.
 Once we know which element isn't being found in time, I can add retry logic to fix it.

ya, my corporate environment is quite strict, but i can tell you what line gets a null
Extensions.cs
 public static IEnumerable<AutomationElement> children(this AutomationElement parent) {
        if(parent == null)
        {
            return null; //this is where i traced it to, that led me to putting in the delay. Funny thing, when i am in debug, it works because debug slows it down, but then when i run it as normal, it gets kranky.
        }
        return parent.FindAll(TreeScope.Children, Condition.TrueCondition).Cast<AutomationElement>();
    }

Interesting, that is a method that gets retried when it throws an exception (for example if parent is null), so I would expect 2-3 caught and handled exceptions from that line but for it to ultimately succeed. Maybe we're not waiting long enough there (currently only 200 ms), or maybe it's masking the real error later, outside of the children() call.
Can you try changing the maxAttempts: 25 argument to maxAttempts: 125 and see if that fixes it?

Hi, I am getting the same issue, I am also not sure why this happens because it is in a try loop.
I can also confirm that if i implement the code (checking for null in the Extensions.cs ) it fixes the issue for me.
As the returned null is then caught by the try and on the next try it continues.

Thanks for the additional info. I will try reproducing it on more computers, and also upload a development build that both increases the timeout and prints log messages, which may be useful for spotting the cause. At this point there is still something I am not understanding about the root cause here, because the given workaround doesn't seem like it should change the behavior, so there's more to it than I currently can see.

This issue did not reproduce on two additional computers I tested with.
Here is a development build with a longer timeout for finding CredentialsList and log messages to help diagnose this problem.
AuthenticatorChooser.zip
You can try this out and let me know if it fixes the problem, and what the stdout is. Here is what I'm expecting:
Caught NullReferenceException while finding CredentialsList
No CredentialsList found in dialog box yet, retrying
Caught NullReferenceException while finding CredentialsList
No CredentialsList found in dialog box yet, retrying
Caught NullReferenceException while finding CredentialsList
No CredentialsList found in dialog box yet, retrying
authenticatorChoices has 2 items
USB security key selected
Next button pressed

Yes thanks, it is working nicely now
Caught NullReferenceException while finding CredentialsList
No CredentialsList found in dialog box yet, retrying
Caught NullReferenceException while finding CredentialsList
No CredentialsList found in dialog box yet, retrying
Caught NullReferenceException while finding CredentialsList
No CredentialsList found in dialog box yet, retrying
authenticatorChoices has 2 items
USB security key selected
Next button pressed

Thank you very much, adding this fix to the upcoming 0.2.0 release.

Released in 0.2.0.


Safe Mode for Influxdb startup

Proposal:
If the database has some overwhelming processes such as a bad task or a compaction on an over-sized bucket, it may prevent influxdb from starting up properly.  We should have a safe mode that turns off all automatic processes so that we can inspect the application and trouble shoot.
Current behavior:
The DB, in an unstable state, will not start.
Desired behavior:
the DB should create minimal state during startup so that a user can evaluate resources.

some process we should disable:

tasks, checks, notifications
compactions.

I'm having second thoughts about compaction. "safe mode" implies that things are broke and we can fix in safe mode. I'm not sure compaction is something that breaks and fixes in this fashion. In fact, safe mode could be a good time to give space to compaction.

@jacobmarble I think we have latitude to design this how we see fit.     I think safe mode would/should by default disable all automated processes.

Some previous discussion of a read-only mode at https://github.com/influxdata/influxdb/issues/7737 (which was stalebotted).

Why wouldn't all these diagnostic functions just be available in the influxd command? influxd doctor for example? what is an example of something we need the database running in order to fix?

Based on the discussion around this, I've introduced a --no-tasks flag to disable task scheduling specifically. What is everyone's thoughts on that?

@brettbuddin sounds great. Do you have a PR?

@jacobmarble https://github.com/influxdata/influxdb/pull/17462


What is the base URL?

I have the routes...what is the base URL for the user endpoint metadata? Supposedly user data can be modified from outside the VM, but it's not at all clear how to do this.

Document Details
⚠ Do not edit this section. It is required for learn.microsoft.com ➟ GitHub issue linking.

ID: b3293bd8-9818-239b-aa57-b610cc6e2ac0
Version Independent ID: 6642a3f4-db0e-7c37-98a8-cd03da437b20
Content: User data for Azure Virtual Machine - Azure Virtual Machines
Content Source: articles/virtual-machines/user-data.md
Service: virtual-machines
GitHub Login: @ningk
Microsoft Alias: ningk

@tasdflkjweio
Thanks for your feedback! We will investigate and update as appropriate.

Hi @tasdflkjweio
As per your scenario you can follow below steps.
I have highlighted the regarding the Updating user data. You can just go through it.
https://learn.microsoft.com/en-us/azure/virtual-machines/user-data#:~:text=id}%3F%24expand%3DuserData"-,Updating user data,string for "userData" in this case%2C the user data is deleted.,-User data and
And for you reference and clarifications you can refer below link also:
https://learn.microsoft.com/en-us/azure/virtual-machines/instance-metadata-service?tabs=windows
if there are any further questions regarding the documentation, please tag me in your reply and we will be happy to continue the conversation.


Updated setuptools version

While creating new docker deployment, we were getting this error:
AttributeError: module '_distutils_hack' has no attribute 'ensure_shim'.
This update removes this error and ensures smooth deployment

@zuman thanks for the fix :) These dependency issues are super annoying.


Optimization of the code

This code can be optimized by integrating more technical indicators or other concepts of Machine learning or deep learning

@Akshat111111 hey I can try this part ...if possible assign me this issue

I have assigned this issue to you.Can you please share your thought process of what you are thinking to implement?? or which Machine learning or deep learing algorithm?? or Something else??

Well I have just started machine learning algorithms lessons but will adapt with it so it will take me some time....if you have any suggestions for me please give

Yeah,no worries.Learn the ML at your own pace.I would suggest you to focus more on Random forest and Decision tree.

okay

Hey @shubha987 are you working on it ??

Actually I am still learning it . You can unassign me but I will surely work on it irrespective of kwoc

No worries,keep learning,as learning is the main priority.You are welcome to contribute in it anytime

You can assign me this, I will use try and test different ml algos , use different activation functions and maybe hypertune paramteres if need be.

Sure,you can move forward with it

Can I also be assigned to this issue? I am new to ML but I have worked with Decision Trees before

@Celaena24 I will suggest you to make a new issue targetting decision tree implementation

@apooyadv are you working on it??

yes, I am. I just have to write more efficient code for each of the models right?

yes, I am. I just have to write more efficient code for each of the models right?

yeah and make it more organized.


Keyboard controls is improperly mapped

Describe the bug
When you receive a key event, you receive two values, the event.code (KeyA) and the event.key (A).
The key is equal to the pressed letter, but letters change based on keyboard layout.
While event.code don't.
Please swap the use of key to code, and use the proper values (A => KeyA).
Here is an example.

In my picture, WASD is as unusable as you can imagine, but if you use KeyW,  KeyA, KeyS, and KeyD, then it will map to my ZQSD no problem.
Reproduction
https://cientos.tresjs.org/guide/controls/keyboard-controls.html
Steps to reproduce
Access the webpage with a keyboard of different layout
System Info
azerty layout keyboard

Used Package Manager
npm
Code of Conduct

[X] I agree to follow this project's Code of Conduct
[X] Read the Contributing Guidelines.
[X] Read the docs.
[X] Check that there isn't already an issue that reports the same bug to avoid creating a duplicate.
[X] The provided reproduction is a minimal reproducible example of the bug.

@arthurmougin
Thanks for pointing this out. A fix is in the works.


Setup all-contributors

@all-contributors please add @licg9999 for code

@all-contributors please add @licg9999 for doc

@all-contributors please add @licg9999 for code, doc

https://github.com/all-contributors please add @licg9999 for infra


Dashboard UI have inconsistent option title and labels on buttons for node-label and node-taint for node driver

On master-head commit id: 7a2fc74
Steps to reproduce:

Cluster-management->Create->Amazon EC2->Show Advanced
Node label has Kubernetes Node Labels and taints have Taints and label on the button has Add label for node-labels and Add for node-taints

Expected:
Consistent labels and taints

'Kubernetes Node Labels' is used to be clear that this is for the k8s nodes rather than the node it is provisionned on.
@neillsom Can you look at this for the 'Add' buttons - I think we should use 'Add Tag', 'Add Label' and 'Add Taint'
should just be some new translations and wiring them in - changes need to be made in MachinePool.vue

On master-head commit id: f33188d


Badge component

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

-13 of 34 (61.76%)  changed or added relevant lines in 2 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage decreased (-0.1%) to 99.417%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

src/modules/layerManager/components/LayerItem.js
5
9
55.56%

src/modules/commons/components/badge/Badge.js
16
25
64.0%

Totals

Change from base Build<PHONE_NUMBER>:
-0.1%

Covered Lines:
11674

Relevant Lines:
11691

💛  - Coveralls


Lesson 7 human-numbers

cell number 17, when it says
x1[:,0]
should be x1[0]
next cell y1[:,0]
should be y1[0]
this is now the correct way to see that y is x shifted by 1

If this is reporting a bug, could you please show what you're doing exactly, what error you see (paste the stack trace), and what versions of fastai and pytorch you're using on what platform?

it is not an error on the library but a mistake on the notebook of the lessons I mean this file
https://github.com/fastai/course-v3/blob/master/nbs/dl1/lesson7-human-numbers.ipynb
on the 17th cell it says
x1[:,0] and in the next cell y1[:,0] to check theirs content
This is the same code on the video but maybe the library is changed since then because now if you check x1[:,0] and y1[:,0] what you actually see doesn't show what it meant to show (y is the x shifted by 1 position). The right code tho show that now it to check  x1[0] and y1[0]
In fact, few cell later when the notebook shows the same content but with words instead number it correctly (this time) check  v.textify(x1[0]) and v.textify(y1[0])  (not v.textify(x1[:,0] ) and v.textify(y1[:,0]))
sorry for my english, I understand maybe I can't explain this thing right
the point is no bug in the library, to me just the notebook of the lesson needs a small fix

I just checked and it's working fine - please check you've got the latest version of fastai, and ask on the forum if you're still having trouble.


(enhancement): add support for setting extensions to watch.

It should be possible to set extensions so that changes are observed and it restarts.

Was added


The result on the Endo4IE dataset

The result on the Endo4IE dataset in the paper, is it obtained by averaging the results of real-over and real-under?

Yes. We average all the results on over- and under-exposed images.

Yes. We average all the results on over- and under-exposed images.


How to write to a dataset without holding the whole dataset in memory?

Hello! Is there any way to write to a dataset and not hold the whole dataset in memory? I'm sure I'm missing something simple here.
The line in question is in the counter function, write_slice. Should I be manually calling the flush method at some point?

fn create_loom(
    file_prefix: String,
    row_names: Vec<String>,
    col_names: Vec<String>,
) -> hdf5::Dataset {
    let _ = hdf5::silence_errors();
    let file = hdf5::File::open(format!("{}_counts.loom", file_prefix), "w").unwrap();
    let global_attrs = file.create_group("attrs").unwrap();
    let loom_version = global_attrs
        .new_dataset::<hdf5::types::VarLenUnicode>()
        .create("LOOM_SPEC_VERSION", 1)
        .unwrap();
    let row_attrs = file.create_group("row_attrs").unwrap();
    let col_attrs = file.create_group("col_attrs").unwrap();
    let r_names = row_attrs
        .new_dataset::<hdf5::types::VarLenUnicode>()
        .create("row_names", row_names.len())
        .unwrap();
    let c_names = col_attrs
        .new_dataset::<hdf5::types::VarLenUnicode>()
        .create("col_names", col_names.len())
        .unwrap();
    let row_num = row_names.len();
    let col_num = col_names.len();
    unsafe {
        loom_version
            .write(&[hdf5::types::VarLenUnicode::from_str_unchecked("3.0.0")])
            .unwrap();
        r_names
            .write(
                &row_names
                    .into_iter()
                    .map(|r| hdf5::types::VarLenUnicode::from_str_unchecked(r))
                    .collect::<Vec<_>>(),
            )
            .unwrap();
        c_names
            .write(
                &col_names
                    .into_iter()
                    .map(|c| hdf5::types::VarLenUnicode::from_str_unchecked(c))
                    .collect::<Vec<_>>(),
           )
            .unwrap();
    }
    let matrix = file
        .new_dataset::<u32>()
        .create("matrix", (row_num, col_num))
        .unwrap();
    matrix
}

fn counter(
    cells: &HashMap<String, HashMap<String, Lapper<u32>>>,
    regions: &HashMap<String, Lapper<u32>>,
    cell_ids: &Vec<String>,
    output_prefix: String,
) {
    let mut chrs = regions.keys().map(|k| k.clone()).collect::<Vec<String>>();
    chrs.sort_unstable();
    let row_names = create_region_names(regions);
    let col_num = cell_ids.len();

    let matrix = create_loom(output_prefix, row_names, cell_ids.clone());
    let mut i = 0;
    for chr in chrs.iter() {
        let region_ivs = &regions.get(chr).unwrap().intervals;
        for iv in region_ivs.iter() {
            let mut counts = vec![0; col_num];
            for (j, cell_id) in cell_ids.iter().enumerate() {
                let cell = cells.get(cell_id).unwrap();
                if let Some(lapper) = cell.get(chr) {
                    counts[j] = lapper.count(iv.start, iv.stop) as u32;
                }
            }
            matrix
                .write_slice(Array1::from_vec(counts).view(), s![i, ..])
                .unwrap();
            i += 1;
        }
    }
    //matrix.write(data.view()).unwrap();
}

@sstadick Well, write_slice() lets you do exactly what you described, write the dataset bits by bits. Looking at your code, I'm not exactly sure what the problem is, maybe it would be easier if you just describe it in words what you're trying to achieve?

Certainly! When using write or write_slice, writes don't seem to flush until the whole dataset has been formed in memory. What I want to have happen is to write like writing to a normal text file, where nothing/very little is building up in memory.

It was my own issue, nothing to to with this crate. Sorry to bother you!


Update floodlightdefault.properties

Hi Ryan!
Your last update to floodlightdefault.properties has deleted the support of the ACL application. So I add it again.
Best Regards,
Alex Lu

@Pengfei-Lu haha ooops, thanks for catching!


refactor(semantic)!: remove SymbolTable::get_symbol_id_from_name and SymbolTable::get_scope_id_from_name

#5480  👈
main

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @overlookmotel and the rest of your teammates on  Graphite


Can't mention two people with the same name

Mentioning someone with the same name as someone who was already tagged, replaces the original tag with the new mention.

I think this pull request should fix it: https://github.com/podio/jquery-mentions-input/pull/136

Yes, you're right.. Thanks @juanvillegas


zib-Encounter: .class ConceptMap

https://simplifier.net/nictiz-r4-zib2020/zibencounter
Encounter.class has an extensible binding but has a ConceptMap defined. According to the Profiling Guidelines, we only need a ConceptMap with a required binding.
Should the ConceptMap be removed? And if so, is it sufficiently clear to implementer that the OTH code (in this case) can also be added to be zib compliant?
You could argue that the ConceptMap is a good way to communicate that fact that 'the zib allows this and this extra codes' with an extensible binding. In that case the guidelines should be edited.

This is actually a strange beast, as the codes in the zib ValueSet are part of the FHIR ValueSet, with the addition of OTH. Binding the zib ValueSet here seems the proper thing to do.


Improve line-spacing, decrease font size on small screens, fix issue #15

Small tweaks to the typography just to make it easier to read. Increased the line-height across all screen sizes, and reduced the base font-size on smaller screens.
Before:

After:

Also added a min-width to the .post-meta class on the home page, so that the titles to the right are aligned (as mentioned in issue #15 ), and increased the spacing between post titles to improve the tap-target size (particularly important on mobile).
Before:

After:

Thanks so much for contribution @ianmaleney , I’ll publish a new release recently.


Fix recent topics filters being partially hidden.

There is no specific reproducer for this but here are hints to do so in the dicussion on czo.
Please don't claim this issue if you can't figure out how to reproduce it.

@zulipbot claim

@cherish2003 it would be helpful if you can share how you reproduced the issue and share your approach to fix it.

@amanagr i am unable to reproduce this issue in mac and linux too so i am unassigning myself

@zulipbot claim

@zulipbot claim

Closing as fixed by https://github.com/zulip/zulip/pull/30134.


Rename factory methods to be more consistent

This renames the various NodeFactory methods to be more consistent and less ambiguous.

The change in names results in an additional 11k increase in the file size for tsc.js.


Issue on running the server

executing bin/run gives following:
python: posix_spawn: /my-path/ccs-calendarserver/.develop/virtualenv/bin/python2.72.7: No such file or directory
platform: Mac Osx El capitan

Hi @raminbp
Your error looks similar to what happens if pip is not installed. Until just a moment ago, the README was incorrect in its reference to using bin/install_pip, as we no longer ship such a script. I've updated README.rst to add the instruction to run "python -m ensurepip" to install pip, if you don't have it already.
Also, I feel like there might be issues with the keychain integration (specific to OS X). I haven't nailed it down yet, but it doesn't seem particularly happy right now on a couple different test machines. You can bypass the keychain integration by running: export USE_OPENSSL=1 prior to running ./bin/develop. If you have already run ./bin/develop, delete the .develop directory, then set USE_OPENSSL and run ./bin/develop again.

Hi @dreness
I noticed the bin/install_pip doesn't exist but as far i saw in the logs , pip is installed during the first execution bin/run. I also installed pip sing the brew and the result was the same.  i'll try you solution see if it resolves.
Thank you

Installing collected packages: setuptools
Successfully installed setuptools-23.1.0

Installing pip==8.1.2
Collecting pip==8.1.2
Using cached pip-8.1.2-py2.py3-none-any.whl
Installing collected packages: pip
Successfully installed pip-8.1.2

Installing virtualenv==15.0.2
Collecting virtualenv==15.0.2
Using cached virtualenv-15.0.2-py2.py3-none-any.whl
Installing collected packages: virtualenv
Successfully installed virtualenv-15.0.2
New python executable in /Users/raminbpr/Projects/Gam/darwin/ccs-calendarserver/.develop/virtualenv/bin/python2.7
Also creating executable in /Users/raminbpr/Projects/Gam/darwin/ccs-calendarserver/.develop/virtualenv/bin/python
Installing pip, wheel...done.
macOS virtualenv codesign fix.
python: posix_spawn: /Users/raminbpr/Projects/Gam/darwin/ccs-calendarserver/.develop/virtualenv/bin/python2.72.7: No such file or directory

@raminbp Hrm, with a closer look at your original message I might have noticed that it's trying to access "python2.72.7", which is understandably not present.
I'd guess something about your setup violates the assumptions of CalendarServer's run / setup scripts. To get some debug information, try editing bin/_build.sh to add "set -x" right above the line '. "${wd}/bin/_py.sh";', then run ./bin/develop again. If you can share the output of that, hopefully I can figure out what's going on. The first part of the output should document how these scripts find a suitable python to use. On my system, the output is:
++ . /Users/andre/work/server/ccs-calendarserver/bin/_py.sh
+ develop
+ init_build
+ cd /Users/andre/work/server/ccs-calendarserver
+ init_py
++ detect_python_version
++ local v
++ local p
++ for v in '"2.7"' '""'
++ for p in '"${PYTHON:=}"' '"python${v}"'
+++ find_cmd ''
+++ local cmd=
+++ shift
++++ type ''
++++ sed 's|^ is \(a tracked alias for \)\{0,1\}||'
+++ local path=
+++ '[' -z '' ']'
+++ return 1
++ p=
++ for p in '"${PYTHON:=}"' '"python${v}"'
+++ find_cmd python2.7
+++ local cmd=python2.7
+++ shift
++++ type python2.7
++++ sed 's|^python2.7 is \(a tracked alias for \)\{0,1\}||'
+++ local path=/usr/bin/python2.7
+++ '[' -z /usr/bin/python2.7 ']'
+++ echo /usr/bin/python2.7
++ p=/usr/bin/python2.7
++ try_python /usr/bin/python2.7
++ local python=/usr/bin/python2.7
++ shift
++ '[' -z /usr/bin/python2.7 ']'
++ type /usr/bin/python2.7
+++ py_version /usr/bin/python2.7
+++ local python=/usr/bin/python2.7
+++ shift
++++ /usr/bin/python2.7 -c 'from distutils.sysconfig import get_python_version; print get_python_version()'
+++ echo 2.7
++ local py_version=2.7
+++ echo 2.7
+++ sed 's|\.||'
++ '[' 27 -lt 25 ']'
++ return 0
++ echo /usr/bin/python2.7
++ return 0
+ bootstrap_python=/usr/bin/python2.7
++ find_cmd /usr/bin/python2.7
++ local cmd=/usr/bin/python2.7
++ shift
+++ type /usr/bin/python2.7
+++ sed 's|^/usr/bin/python2.7 is \(a tracked alias for \)\{0,1\}||'
++ local path=/usr/bin/python2.7
++ '[' -z /usr/bin/python2.7 ']'
++ echo /usr/bin/python2.7
+ export PYTHON=/usr/bin/python2.7
+ PYTHON=/usr/bin/python2.7

cd /Users/raminbpr/Projects/Gam/darwin/ccs-calendarserver
py_dependencies
python=/Users/raminbpr/Projects/Gam/darwin/ccs-calendarserver/.develop/virtualenv/bin/python
py_ve_tools=/Users/raminbpr/Projects/Gam/darwin/ccs-calendarserver/.develop/ve_tools
export PATH=/Users/raminbpr/Projects/Gam/darwin/ccs-calendarserver/.develop/virtualenv/bin:/Users/raminbpr/Projects/Gam/darwin/ccs-calendarserver/.develop/roots/PostgreSQL/bin:/Users/raminbpr/Projects/Gam/darwin/ccs-calendarserver/.develop/roots/memcached/bin:/Users/raminbpr/Projects/Gam/darwin/ccs-calendarserver/.develop/roots/libevent/bin:/Users/raminbpr/Projects/Gam/darwin/ccs-calendarserver/.develop/roots/openssl/bin:/Users/raminbpr/bin/mongodb-osx-x86_64-3.0.6/bin:/Users/raminbpr/bin/Sencha/Cmd/<IP_ADDRESS>/..:/Users/raminbpr/bin/Sencha/Cmd/<IP_ADDRESS>/..:/Users/raminbpr/Projects/Personal/depot-tools:/Users/raminbpr/bin/Sencha/Cmd/<IP_ADDRESS>/..:/usr/local/bin:/usr/bin:/bin:/usr/sbin:/sbin
PATH=/Users/raminbpr/Projects/Gam/darwin/ccs-calendarserver/.develop/virtualenv/bin:/Users/raminbpr/Projects/Gam/darwin/ccs-calendarserver/.develop/roots/PostgreSQL/bin:/Users/raminbpr/Projects/Gam/darwin/ccs-calendarserver/.develop/roots/memcached/bin:/Users/raminbpr/Projects/Gam/darwin/ccs-calendarserver/.develop/roots/libevent/bin:/Users/raminbpr/Projects/Gam/darwin/ccs-calendarserver/.develop/roots/openssl/bin:/Users/raminbpr/bin/mongodb-osx-x86_64-3.0.6/bin:/Users/raminbpr/bin/Sencha/Cmd/<IP_ADDRESS>/..:/Users/raminbpr/bin/Sencha/Cmd/<IP_ADDRESS>/..:/Users/raminbpr/Projects/Personal/depot-tools:/Users/raminbpr/bin/Sencha/Cmd/<IP_ADDRESS>/..:/usr/local/bin:/usr/bin:/bin:/usr/sbin:/sbin
export PYTHON=/Users/raminbpr/Projects/Gam/darwin/ccs-calendarserver/.develop/virtualenv/bin/python
PYTHON=/Users/raminbpr/Projects/Gam/darwin/ccs-calendarserver/.develop/virtualenv/bin/python
export PYTHONPATH=/Users/raminbpr/Projects/Gam/darwin/ccs-calendarserver/.develop/ve_tools/lib:/Users/raminbpr/Projects/Gam/darwin/ccs-calendarserver:
PYTHONPATH=/Users/raminbpr/Projects/Gam/darwin/ccs-calendarserver/.develop/ve_tools/lib:/Users/raminbpr/Projects/Gam/darwin/ccs-calendarserver:
mkdir -p /Users/raminbpr/Projects/Gam/darwin/ccs-calendarserver/.develop/patches
++ uname -s
'[' Darwin = Darwin ']'
/usr/local/Cellar/python/2.7.12_2/bin/python2.7 -c 'import distutils.sysconfig; print distutils.sysconfig.get_config_var("CFLAGS")'
grep -e -mno-fused-madd
true
false
'[' '!' -d /Users/raminbpr/Projects/Gam/darwin/ccs-calendarserver/.develop/virtualenv ']'
bootstrap_virtualenv
mkdir -p /Users/raminbpr/Projects/Gam/darwin/ccs-calendarserver/.develop/ve_tools
export PYTHONUSERBASE=/Users/raminbpr/Projects/Gam/darwin/ccs-calendarserver/.develop/ve_tools
PYTHONUSERBASE=/Users/raminbpr/Projects/Gam/darwin/ccs-calendarserver/.develop/ve_tools
for pkg in setuptools==18.5 pip==8.1.2 virtualenv==15.0.2
ruler 'Installing setuptools==18.5'
true
echo ____________________________________________________________
echo ''
'[' 1 -gt 0 ']'
echo 'Installing setuptools==18.5'
/usr/local/Cellar/python/2.7.12_2/bin/python2.7 -m pip install -I --user setuptools==18.5
for pkg in setuptools==18.5 pip==8.1.2 virtualenv==15.0.2
ruler 'Installing pip==8.1.2'
true
echo ____________________________________________________________
echo ''
'[' 1 -gt 0 ']'
echo 'Installing pip==8.1.2'
/usr/local/Cellar/python/2.7.12_2/bin/python2.7 -m pip install -I --user pip==8.1.2
for pkg in setuptools==18.5 pip==8.1.2 virtualenv==15.0.2
ruler 'Installing virtualenv==15.0.2'
true
echo ____________________________________________________________
echo ''
'[' 1 -gt 0 ']'
echo 'Installing virtualenv==15.0.2'
/usr/local/Cellar/python/2.7.12_2/bin/python2.7 -m pip install -I --user virtualenv==15.0.2
/usr/local/Cellar/python/2.7.12_2/bin/python2.7 -m virtualenv --system-site-packages --no-setuptools /Users/raminbpr/Projects/Gam/darwin/ccs-calendarserver/.develop/virtualenv
case "$(uname -s)" in
++ uname -s
echo 'macOS virtualenv codesign fix.'
cp /usr/bin/python /Users/raminbpr/Projects/Gam/darwin/ccs-calendarserver/.develop/virtualenv/bin/python
cd /Users/raminbpr/Projects/Gam/darwin/ccs-calendarserver
PYTHONPATH=/Users/raminbpr/Projects/Gam/darwin/ccs-calendarserver/.develop/ve_tools/lib:/Users/raminbpr/Projects/Gam/darwin/ccs-calendarserver:
/Users/raminbpr/Projects/Gam/darwin/ccs-calendarserver/.develop/virtualenv/bin/python /Users/raminbpr/Projects/Gam/darwin/ccs-calendarserver/setup.py check

it doesn't look like your output

Apparently this is somehow related to using python from homebrew. In a fresh VM, I installed dev tools, homebrew, ran "brew install python", and then git cloned the CS repo, which fails with the same error message you posted:
python: posix_spawn: /Users/local/ccs-calendarserver/.develop/virtualenv/bin/python2.72.7: No such file or directory
I'll investigate...

thank you very much

@raminbp This seems to be caused by something we do during setup that's really only intended for the Server.app distribution of Calendar Server, related to code signing and other things that hopefully are of no interest to anyone reading this. We shouldn't be doing our 'codesign fix' for the this, the open source distribution, and I will be confining that behavior to Server.app builds momentarily. In the mean time, if you comment out the 'cp' command shown below, that should fix it for you:
diff --git a/bin/_build.sh b/bin/_build.sh
index e3ec9b7..e6baed4 100644
--- a/bin/_build.sh
+++ b/bin/_build.sh
@@ -661,8 +661,8 @@ py_dependencies () {
       "${py_virtualenv}";
     case "$(uname -s)" in
       Darwin)
-        echo "macOS virtualenv codesign fix."
-        cp "/usr/bin/python" "${py_bindir}/python";
+        echo "skipping macOS virtualenv codesign fix."
+        #cp "/usr/bin/python" "${py_bindir}/python";
         ;;
     esac;
   fi;

... or you can just wait until I push a fix for this, which should be coming soon...

@raminbp This should be fixed as of https://github.com/apple/ccs-calendarserver/commit/935cf46edc39e17d163af796f9793c7600f6e837. You should delete the .develop directory before retrying, and you might even have to do the silly stuff I mentioned in the Update to this comment: https://github.com/apple/ccs-calendarserver/issues/468#issuecomment-253057362

@dreness thank you very much, now its working

@raminbp you're welcome! glad to hear it's working. Perhaps I will add some automated tests that use other pythons... all our automated tests on OS X use apple's Python.


Revamp README

Content should act as a front-door for both city government staff and developers who want to learn more about the project overall. Move technical instructions to elsewhere in the repo.

To do: add 3D printed case to my wheel, take new photo next to fire hydrant

this is good enough as-is for that milestone. closing to clear this out.


Fix/flush cli output

Description
Fixes that when running the CLI in IntelliJ the output of the console is displayed.


i18n(pt-BR): Update images.mdx translation

Update images.mdx translation
This PR updates de pt-br translation of the images.mdx guide.

Lunaria Status Overview
🌕 This pull request will trigger status changes.

Learn more
By default, every PR changing files present in the Lunaria configuration's files property will be considered and trigger status changes accordingly.
You can change this by adding one of the keywords present in the ignoreKeywords property in your Lunaria configuration file in the PR's title (ignoring all files) or by including a tracker directive in the merged commit's description.

Tracked Files

Locale
File
Note

pt-br
guides/images.mdx
Localization changed, will be marked as complete.

Warnings reference

Icon
Description

🔄
The source for this localization has been updated since the creation of this pull request, make sure all changes in the source have been applied.


When a JMS message is received, traceId and spanId are not added to MDC of logger

https://github.com/opentracing-contrib/java-jms/issues/26

Pull Request Test Coverage Report for Build 121

0 of 15 (0.0%)  changed or added relevant lines in 1 file are covered.
No unchanged relevant lines lost coverage.
Overall coverage decreased (-0.3%) to 31.818%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

opentracing-jms-common/src/main/java/io/opentracing/contrib/jms/common/TracingMessageListener.java
0
15
0.0%

Totals

Change from base Build 117:
-0.3%

Covered Lines:
168

Relevant Lines:
528

💛  - Coveralls

Why it should be added here?
It's not part of opentracing api. MDC,... whatever

I think it is necessary because without this information in log is not
possible join the opentracing information with the trace in log.
I don't know if:

can be trasformed in optional like in web configuration
can be introduce something that can be consider an interceptor that
permit to implement/activate this custom option

Il giorno lun 15 lug 2019 alle ore 17:30 Sergei Malafeev <
<EMAIL_ADDRESS>ha scritto:

Why it should be added here?
It's not part of opentracing api. MDC,... whatever
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/opentracing-contrib/java-jms/pull/27?email_source=notifications&email_token=AA2K5GKDMYS5RJNLCB542ITP7SJYPA5CNFSM4IDX5EE2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODZ6B5KY#issuecomment-511450795,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AA2K5GO4T5CKD3JJHJHDNPLP7SJYPANCNFSM4IDX5EEQ
.

can be trasformed in optional like in web configuration

@lucapreziati could you provide a link to that?
I think slf4j dependency should be optional and MDC code should be under new configuration flag.

@malafeev  i don't know how made a dependency optional, it is enough that has scope provided from your point of view?
For adding in logging i added this servlet filter.
public class TracingLogFilter implements Filter {

	@Autowired
	io.opentracing.Tracer tracer;

	@Override
	public void doFilter(ServletRequest request, ServletResponse response, FilterChain chain)
			throws IOException, ServletException {
		SpanContext spanContext = getCurrentSpanContext();
		if (spanContext != null) {
			MDC.put("spanId", spanContext.toSpanId());
			MDC.put("traceId", spanContext.toTraceId());
		}
		chain.doFilter(request, response);
		if (spanContext != null) {
			MDC.remove("spanId");
			MDC.remove("traceId");
		}
	}

	private SpanContext getCurrentSpanContext() {
		if (tracer == null) {
			return null;
		} else if (tracer.activeSpan() == null) {
			return null;
		} else
			return tracer.activeSpan().context();
	}

}

scope should be optional, but we need a  boolean parameter to enable/disable MDC

@lucapreziati could you revert formatting?
2 spaces are used for indentation (Google code style)

@malafeev i will download and apply, sorry i forget to check. I have one more solid solution, if you are agree, which can meet you requirement of optional. Wait a secondo please, i am working on it.

@malafeev do you think I can add in main pom the maven plugin to force to use google style formatter?

thanks @lucapreziati
could you also resolve conflicts?

@malafeev sorry, there was a short down. I have created new repository. I will try the fix and i will propose a new pull request.

@malafeev I suggest to close this merge request, i propose a solution more close to your requirement, having MDC by configuration.
The pull is https://github.com/opentracing-contrib/java-jms/pull/29


Text in scheduler controls is black instead of blue

I think it's just that selectlist actually has the wrong color text:

Master is incorrect. The select list is supposed to be black text.


QAF to support output of cucumber.json file for Quantum

QAF Version

Note: only the latest version is supported

Steps To Reproduce
1. Write any test using Gherkin in feature file
2. Run it

Expected behavior
cucumber.json should be created in test-result folder.
The customer wants to use this to directly import results into Jira.
Find attached an expected cucumber.json example.
Actual behavior
Instead, QAF specific json files are output.
Similar in content, but not accepted by Jira as they deviate from standard cucumber.json file syntax.
Is the issue reproductible on runner?

[x] QAS
[x] Maven
[ ] Gradle
[] Ant
[x ] Eclipse

Test case sample

Please, share the test case (as small as possible) which shows the issue
https://github.com/Project-Quantum/Quantum-Starter-Kit
Run any test using feature file- only qaf specific output json files are created.

Attached:
expected file- cucumber.json and ResultsToUpload.json
actual file generated by QAF- WeeklyMarkets.json
video showing how customer attempts to import results json into Jira
cucumber.json.txt
WeeklyMarkets.json.txt
ResultstoUpload.json.txt
Json report upload into JIRA.arf.zip

qaf doesn't use cucumber or cucumber runner so it is not generating cucumber report. You will get testng xml report in addition to qaf json report which is supported by different tools.  If you want cucumber report you need to run with cucumber runner or generate using testng report listener.


Last Question Help Wanted! Discrepancy between bidirectional schema linking code and paper

I have reviewed all the code, but I have questions about the differences between the implementation in the code and what is described in the paper regarding bidirectional schema linking. I understand that this approach is actually equivalent.
For Backward Linking
In The Code
In bid_schema_linking.py, you extract the tables and columns mentioned in preSQL1 by comparing it with both the full dbschema and hint, as well as by comparing hint with preSQL1.
https://github.com/Laqcce-cao/RSL-SQL/blob/ecee46ffee3ad22ffae3edb5072e43286db0fb31/src/bid_schema_linking.py#L32-L70
https://github.com/Laqcce-cao/RSL-SQL/blob/ecee46ffee3ad22ffae3edb5072e43286db0fb31/src/bid_schema_linking.py#L74-L117
In The  Paper

Question

In the paper, it is mentioned that sqlglot is used to extract table columns. However, in the code, I only see sqlglot being used during the evaluation of linking, but not in bid_schema_linking.py. Can I consider these two approaches equivalent?
BTW. Another issue, upon reading the code logic, it seems that the following piece of code has no effect?
https://github.com/Laqcce-cao/RSL-SQL/blob/ecee46ffee3ad22ffae3edb5072e43286db0fb31/src/bid_schema_linking.py#L152-L199

I should not have any other questions, looking forward to your reply again. thank you.

Thank you very much for your question.

Our paper has been updated to the second version. It seems that you are viewing the first version.

The filter() method is designed to control the case of column names and filter out some repeated elements.

We hope our approach is inspiring to you.

okay. thank you.


[BUG] : Pipeline stuck at "Setting pipeline to PLAYING ... New clock: GstSystemClock"

Hi,
I have built kvsproducer using amazon-kinesis-video-streams-producer-sdk-cpp and using kvssink for streaming.
Below is the pipeline Used for streaming
gst-launch-1.0 v4l2src do-timestamp=TRUE device=/dev/video0 ! video/x-raw, width=640, height=480 ! videoconvert! vpuenc_h264 ! h264parse ! video/x-h264, stream-format=avc, alignment=au, width=640, height=480 ! kvssink stream-name=415ae8e5-f115-4125-8ee7-082e13f2578c access-key= secret-key= aws-region=ap-south-1 restart_on_error=false connection_staleness=40
Pipeline is set without any error but it got stuck after setting pipeline to playing.
INFO - createKinesisVideoClient(): Creating Kinesis Video Client
2021-07-05 12:35:33 [281472894467232] INFO - heapInitialize(): Initializing native heap with limit size 134217728, spill ratio 0% and flags 0x00000001
2021-07-05 12:35:33 [281472894467232] INFO - heapInitialize(): Creating AIV heap.
2021-07-05 12:35:33 [281472894467232] INFO - heapInitialize(): Heap is initialized OK
2021-07-05 12:35:33 [281472894467232] DEBUG - stepStateMachine(): State Machine - Current state: 0x0000000000000001, Next state: 0x0000000000000002
2021-07-05 12:35:33 [281472894467232] DEBUG - getSecurityTokenHandler invoked
2021-07-05 12:35:33 [281472894467232] DEBUG - Refreshing credentials. Force refreshing: 0 Now time is:<PHONE_NUMBER>853010809 Expiration: 0
2021-07-05 12:35:33 [281472894467232] DEBUG - stepStateMachine(): State Machine - Current state: 0x0000000000000002, Next state: 0x0000000000000010
2021-07-05 12:35:33 [281472894467232] INFO - createDeviceResultEvent(): Create device result event.
2021-07-05 12:35:33 [281472894467232] DEBUG - stepStateMachine(): State Machine - Current state: 0x0000000000000010, Next state: 0x0000000000000040
2021-07-05 12:35:33 [281472894467232] DEBUG - clientReadyHandler invoked
2021-07-05 12:35:33 [281472894467232] INFO - try creating stream
2021-07-05 12:35:33 [281472894467232] INFO - Creating Kinesis Video Stream 415ae8e5-f115-4125-8ee7-082e13f2578c
2021-07-05 12:35:33 [281472894467232] INFO - createKinesisVideoStream(): Creating Kinesis Video Stream.
2021-07-05 12:35:33 [281472894467232] DEBUG - logStreamInfo(): Kinesis Video Stream Info
2021-07-05 12:35:33 [281472894467232] DEBUG - logStreamInfo(): Stream name: 415ae8e5-f115-425-8ee7-082e13f2578c
2021-07-05 12:35:33 [281472894467232] DEBUG - logStreamInfo(): Streaming type: STREAMING_TYPE_REALTIME
2021-07-05 12:35:33 [281472894467232] DEBUG - logStreamInfo(): Content type: video/h264
2021-07-05 12:35:33 [281472894467232] DEBUG - logStreamInfo(): Max latency (100ns): 600000000
2021-07-05 12:35:33 [281472894467232] DEBUG - logStreamInfo(): Fragment duration (100ns): 20000000
2021-07-05 12:35:33 [281472894467232] DEBUG - logStreamInfo(): Key frame fragmentation: Yes
2021-07-05 12:35:33 [281472894467232] DEBUG - logStreamInfo(): Use frame timecode: Yes
2021-07-05 12:35:33 [281472894467232] DEBUG - logStreamInfo(): Absolute frame timecode: Yes
2021-07-05 12:35:33 [281472894467232] DEBUG - logStreamInfo(): Nal adaptation flags: 0
2021-07-05 12:35:33 [281472894467232] DEBUG - logStreamInfo(): Average bandwith (bps): 4194304
2021-07-05 12:35:33 [281472894467232] DEBUG - logStreamInfo(): Framerate: 25
2021-07-05 12:35:33 [281472894467232] DEBUG - logStreamInfo(): Buffer duration (100ns):<PHONE_NUMBER>
2021-07-05 12:35:33 [281472894467232] DEBUG - logStreamInfo(): Replay duration (100ns): 400000000
2021-07-05 12:35:33 [281472894467232] DEBUG - logStreamInfo(): Connection Staleness duration (100ns): 400000000
2021-07-05 12:35:33 [281472894467232] DEBUG - logStreamInfo(): Store Pressure Policy: 1
2021-07-05 12:35:33 [281472894467232] DEBUG - logStreamInfo(): View Overflow Policy: 1
2021-07-05 12:35:33 [281472894467232] DEBUG - logStreamInfo(): Segment UUID: NULL
2021-07-05 12:35:33 [281472894467232] DEBUG - logStreamInfo(): Frame ordering mode: 0
2021-07-05 12:35:33 [281472894467232] DEBUG - logStreamInfo(): Track list
2021-07-05 12:35:33 [281472894467232] DEBUG - logStreamInfo(): Track id: 1
2021-07-05 12:35:33 [281472894467232] DEBUG - logStreamInfo(): Track name: kinesis_video
2021-07-05 12:35:33 [281472894467232] DEBUG - logStreamInfo(): Codec id: V_MPEG4/ISO/AVC
2021-07-05 12:35:33 [281472894467232] DEBUG - logStreamInfo(): Track type: TRACK_INFO_TYPE_VIDEO
2021-07-05 12:35:33 [281472894467232] DEBUG - logStreamInfo(): Track cpd: NULL
2021-07-05 12:35:33 [281472894467232] DEBUG - stepStateMachine(): State Machine - Current state: 0x0000000000000001, Next state: 0x0000000000000002
2021-07-05 12:35:33 [281472894467232] INFO - writeHeaderCallback(): RequestId: a0a19700-985a-4beb-959b-d425c4e408f4
2021-07-05 12:35:34 [281472719503840] DEBUG - describeStreamCurlHandler(): DescribeStream API response: {"StreamInfo":{"CreationTime":1.624626808443E9,"DataRetentionInHours":1,"DeviceName":null,"IngestionConfiguration":null,"KmsKeyId":"arn:aws:kms:ap-south-1:308222340895:alias/aws/kinesisvideo","MediaType":"video/h264","Status":"ACTIVE","StreamARN":"arn:aws:kinesisvideo:ap-south-1:308222340895:stream/415ae8e5-f115-4125-8ee7-082e13f2578c/1624626808443","StreamName":"415ae8e5-f115-4125-8ee7-082e13f2578c","Version":"AJEhmCaus22KPfZsxI49"}}
2021-07-05 12:35:34 [281472719503840] INFO - describeStreamResultEvent(): Describe stream result event.
2021-07-05 12:35:34 [281472719503840] WARN - describeStreamResult(): Retention period returned from the DescribeStream call doesn't match the one specified in the StreamInfo
2021-07-05 12:35:34 [281472719503840] DEBUG - stepStateMachine(): State Machine - Current state: 0x0000000000000002, Next state: 0x0000000000000020
2021-07-05 12:35:34 [281472719503840] INFO - writeHeaderCallback(): RequestId: 2a14e9c2-a0a4-4f94-8588-a483204a0831
2021-07-05 12:35:34 [281472711111136] DEBUG - getStreamingEndpointCurlHandler(): GetStreamingEndpoint API response: {"DataEndpoint":"https://s-703775db.kinesisvideo.ap-south-1.amazonaws.com"}
2021-07-05 12:35:34 [281472711111136] INFO - getStreamingEndpointResultEvent(): Get streaming endpoint result event.
2021-07-05 12:35:34 [281472711111136] DEBUG - stepStateMachine(): State Machine - Current state: 0x0000000000000020, Next state: 0x0000000000000010
2021-07-05 12:35:34 [281472711111136] DEBUG - getStreamingTokenHandler invoked
2021-07-05 12:35:34 [281472711111136] DEBUG - Refreshing credentials. Force refreshing: 1 Now time is:<PHONE_NUMBER>399843068 Expiration:<PHONE_NUMBER>3709551615
2021-07-05 12:35:34 [281472711111136] INFO - getStreamingTokenResultEvent(): Get streaming token result event.
2021-07-05 12:35:34 [281472711111136] DEBUG - stepStateMachine(): State Machine - Current state: 0x0000000000000010, Next state: 0x0000000000000040
2021-07-05 12:35:34 [281472711111136] DEBUG - streamReadyHandler invoked
2021-07-05 12:35:34 [281472711111136] Stream is ready
====== VPUENC: 4.5.5 build on Mar 29 2021 07:40:42. ======
wrapper: 3.0.0 (VPUWRAPPER_ARM64_LINUX Build on Sep 14 2020 22:44:33)
vpulib: 1.1.1
firmware: <IP_ADDRESS>690
Pipeline is live and does not need PREROLL ...
Setting pipeline to PLAYING ...
New clock: GstSystemClock
**

Hi Any comments on this bug ??

The failure you see originates from your upstream components and not KVS. Recommend replacing KVS sink with fakesink or another, stabilize your pipeline and only afterwards try to use KVS sink. The best place to get help with GStreamer related issues is their forums.

Closing since it does not seem to be a KVS specific issue.


Seeding for a specific Website is not working

Description
If I try to execute a Seeder manually with:
php artisan tenancy:db:seed --class=...Seeder --website_id=5

the following error shows up
Database [tenant] not configured.

shows up
Actual behavior
The seeder tries to use the configured tenant connection
Expected behavior
The seeder should use the connection from the website given by the website_id

Information

hyn/multi-tenant version: 5.0.8
laravel version: 5.5.19
database driver and version: mysql 5.7
webserver software and version: apache 2.4
php version: 7.1

Like I mentioned on Discord#support channel, I'm having this exact same issue but in a different way. What I'm doing: create a customer => create a website => create a hostname => auto run migrations and seeds (this is where the problem begins)

Repro: https://github.com/ashokgelal/tenancy-repro

This needs a test that proves it won't work.

The problem is maybe related to the fact that I'm using tenant models (model with trait UsesTenantConnection) in the Seeder, because normal DB Statements are working.
Seeder:
public function run()
    {
        TenantModel::updateOrCreate([
            'name' => 'test'
        ]);
    }


Feature/optimize mnemonic phrase gen

add screens and functionality for:

Optimise Mnemonic Phrase generation in Onboarding (with check if user has written it down)
Implement confirm mnemonic phrase screens

Confirmation page shouldn't be scrollable when page is 375px x 667px (iPhone 6/7/8).

I have made changes:

extracted alert action and AlertModal component
implement inactive behavior for a tapped button
seed is passed by implicit route param in all related pages
some refactoring

@SamLife91 please check this PR, maybe I have broken something

Confirmation page shouldn't be scrollable when page is 375px x 667px (iPhone 6/7/8).

I was wrong, it is the design issue.


Cleanup opcode definitions

We currently have SQLite VDBE opcodes defined in multiple places.
For example, for the If opcode, we have this in core/vdbe/mod.rs:
pub enum Insn {
    /// Jump to target_pc if r\[reg\] != 0 or (r\[reg\] == NULL && r\[null_reg\] != 0)
    If {
        reg: usize,              // P1
        target_pc: BranchOffset, // P2
        /// P3. If r\[reg\] is null, jump iff r\[null_reg\] != 0
        null_reg: usize,
    },
}

The following in core/vdbe/explain.rs:
Insn::Goto { target_pc } => (
    "Goto",
    0,
    *target_pc as i32,
    0,
    OwnedValue::Text(Rc::new("".to_string())),
    0,
    "".to_string(),
),

and the following in cli/opcodes_dictionary.rs:
Let's implement some macro magic where we can do something like:
pub enum Insn {
    /// Jump to target_pc if r\[reg\] != 0 or (r\[reg\] == NULL && r\[null_reg\] != 0)
    #[description = "Jump to P2 if the value in register P1 is true. The value is considered true if it is numeric and non-zero. If the value in P1 is NULL then take the jump if and only if P3 is non-zero."]
    If {
        #[p1] reg: usize,
        #[p2] target_pc: BranchOffset,
        /// If r\[reg\] is null, jump iff r\[null_reg\] != 0
        #[p3] null_reg: usize,
    },
}

@penberg  If I'm understanding correct you want opcode description in one single place using macros?

Yes if it makes the code cleaner.


LEGO: Pull request from juno/hb_dd8dbf7b-874d-49f2-9313-853dd6e34f6c_20210702185402454 to main

LEGO: Pull request from juno/hb_dd8dbf7b-874d-49f2-9313-853dd6e34f6c_20210702185402454 to main with localized lcls

Codecov Report

Merging #227 (dd9ff86) into main (cb0c484) will decrease coverage by 0.41%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main     #227      +/-   ##
==========================================
- Coverage   89.59%   89.18%   -0.42%
==========================================
  Files          87       87
  Lines        6008     6008
==========================================
- Hits         5383     5358      -25
- Misses        625      650      +25

Impacted Files
Coverage Δ

....Composition.AppDomainTests/OpenGenericExport`1.cs
0.00% <0.00%> (-100.00%)
:arrow_down:

...mposition.AppDomainTests/ExternalExportOnMember.cs
0.00% <0.00%> (-100.00%)
:arrow_down:

...mposition.AppDomainTests/ExternalExportWithLazy.cs
0.00% <0.00%> (-100.00%)
:arrow_down:

...osition.AppDomainTests2/CustomMetadataAttribute.cs
0.00% <0.00%> (-100.00%)
:arrow_down:

...dTypeReceiver/PartThatImportsLazyOfEmbeddedType.cs
0.00% <0.00%> (-100.00%)
:arrow_down:

...rtThatLazyImportsExportWithMetadataOfCustomType.cs
0.00% <0.00%> (-100.00%)
:arrow_down:

...atLazyImportsExportWithTypeMetadataViaTMetadata.cs
0.00% <0.00%> (-100.00%)
:arrow_down:

...tLazyImportsExportWithTypeMetadataViaDictionary.cs
0.00% <0.00%> (-100.00%)
:arrow_down:

...ft.VisualStudio.Composition/LazyMetadataWrapper.cs
68.71% <0.00%> (-3.07%)
:arrow_down:

...soft.VisualStudio.Composition/ReflectionHelpers.cs
69.28% <0.00%> (-1.37%)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cb0c484...dd9ff86. Read the comment docs.


[No QA] Allow editing fields of Request

Details
Fixed Issues
$ https://github.com/Expensify/Expensify/issues/270589
Tests

Uncomment out the lines of code here:

diff --git a/src/components/MoneyRequestHeader.js b/src/components/MoneyRequestHeader.js
index ee74a89826..b84a2bf9f5 100644
--- a/src/components/MoneyRequestHeader.js
+++ b/src/components/MoneyRequestHeader.js
@@ -189,23 +189,23 @@ const MoneyRequestHeader = (props) => {
                         description={`${props.translate('iou.amount')} • ${props.translate('iou.cash')}${isSettled ? ` • ${props.translate('iou.settledExpensify')}` : ''}`}
                         titleStyle={styles.newKansasLarge}
                         // Note: These options are temporarily disabled while we figure out the required API changes
-                        // shouldShowRightIcon
-                        // iconRight={Expensicons.ArrowRight}
-                        // onPress={() => Navigation.navigate(ROUTES.getEditRequestRoute(props.report.reportID, CONST.EDIT_REQUEST_FIELD.AMOUNT))}
+                        shouldShowRightIcon
+                        iconRight={Expensicons.ArrowRight}
+                        onPress={() => Navigation.navigate(ROUTES.getEditRequestRoute(props.report.reportID, CONST.EDIT_REQUEST_FIELD.AMOUNT))}
                     />
                     <MenuItemWithTopDescription
                         description={props.translate('common.description')}
                         title={transactionDescription}
-                        // shouldShowRightIcon
-                        // iconRight={Expensicons.ArrowRight}
-                        // onPress={() => Navigation.navigate(ROUTES.getEditRequestRoute(props.report.reportID, CONST.EDIT_REQUEST_FIELD.DESCRIPTION))}
+                        shouldShowRightIcon
+                        iconRight={Expensicons.ArrowRight}
+                        onPress={() => Navigation.navigate(ROUTES.getEditRequestRoute(props.report.reportID, CONST.EDIT_REQUEST_FIELD.DESCRIPTION))}
                     />
                     <MenuItemWithTopDescription
                         description={props.translate('common.date')}
                         title={formattedTransactionDate}
-                        // shouldShowRightIcon
-                        // iconRight={Expensicons.ArrowRight}
-                        // onPress={() => Navigation.navigate(ROUTES.getEditRequestRoute(props.report.reportID, CONST.EDIT_REQUEST_FIELD.DATE))}
+                        shouldShowRightIcon
+                        iconRight={Expensicons.ArrowRight}
+                        onPress={() => Navigation.navigate(ROUTES.getEditRequestRoute(props.report.reportID, CONST.EDIT_REQUEST_FIELD.DATE))}
                     />
                 </>
             )}

Create a new workspace as admin and invite an employee account
Sign in as employee
Request money via the Workspace chat - adding all fields (amount, description)
Navigate to the workspace chat
Tap the expense to navigate to the screen with the expense details
Verify the rows have carets and are tappable
Tap description row and verify you are navigated to the Description screen
Update the description and hit "Save"
Check the JS console to confirm the correct description is logged.

[ ] Verify that no errors appear in the JS console

Offline tests
N/A or if there are any we will have to consider them when making the API changes. For now, this feature will not yet be accessible.
QA Steps
There is no QA because the code we are adding is not accessible yet.

[ ] Verify that no errors appear in the JS console

PR Author Checklist

[x] I linked the correct issue in the ### Fixed Issues section above
[x] I wrote clear testing steps that cover the changes made in this PR

[x] I added steps for local testing in the Tests section
[x] I added steps for the expected offline behavior in the Offline steps section
[x] I added steps for Staging and/or Production testing in the QA steps section
[x] I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
[x] I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
[x] I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).

[x] I included screenshots or videos for tests on all platforms
[x] I ran the tests on all platforms & verified they passed on:

[x] Android / native
[x] Android / Chrome
[x] iOS / native
[x] iOS / Safari
[x] MacOS / Chrome / Safari
[x] MacOS / Desktop

[x] I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
[x] I followed proper code patterns (see Reviewing the code)

[x] I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
[x] I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
[x] I verified that comments were added to code that is not self explanatory
[x] I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
[x] I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method

[x] If any non-english text was added/modified, I verified the translation was requested/reviewed in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:

[x] I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
[x] I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
[x] I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
[x] I verified the JSDocs style guidelines (in STYLE.md) were followed

[x] If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
[x] I followed the guidelines as stated in the Review Guidelines
[x] I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
[x] I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
[x] I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
[x] I verified that if a function's arguments changed that all usages have also been updated correctly
[x] If a new component is created I verified that:

[x] A similar component doesn't exist in the codebase
[x] All props are defined accurately and each prop has a /** comment above it */
[x] The file is named correctly
[x] The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
[x] The only data being stored in the state is data necessary for rendering and nothing else
[x] For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
[x] Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
[x] All JSX used for rendering exists in the render method
[x] The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions

[x] If any new file was added I verified that:

[x] The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory

[x] If a new CSS style is added I verified that:

[x] A similar style doesn't already exist
[x] The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG))

[x] If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
[x] If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
[x] If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
[x] If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
[x] If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
[x] I have checked off every checkbox in the PR author checklist, including those that don't apply to this PR.

 Ok I think it's probably something to do with the routing because the DOB picker works fine.

Ah yep the "year picker" page is defined in the settings stack here:
https://github.com/Expensify/App/blob/38ba7c8eb29a43552980b09dcdde46ccded35c7e/src/libs/Navigation/linkingConfig.js#L219-L221
I think maybe we can just remove it from that stack and have it be pushed as it's own navigator. Maybe not the best solution, but the first one that comes to mind.

@luacmartins The good news is that I fixed that bug...
The bad news is that I'm not feeling too great about the NewDatePicker in general. It looks like we will either need to refactor it to be more flexible and work with screens (specifically, one's with dynamic routes) or accept a temporary hack for now and follow up later to fix it.
Maybe I'm missing some obvious alternative that you will spot. The code looks a little wacky to me. Like the currency selector it's also using routes to pass parameters. And the routes are hardcoded to the component.
I attempted to start some conversation about the way we are passing around parameters in routes here earlier this week: https://expensify.slack.com/archives/C01GTK53T8Q/p1686161800267329, but it didn't get much engagement.

I agree that the component feels very brittle. Let's keep the discussion in that thread though

@grgia yes, admins can edit transactions too!

@marcaaron can you resolve conflicts. @0xmiroslav would appreciate your review on this one.

Fixed. There are 3 internal engineers tagged on this issue. If @grgia is already testing maybe we can take @0xmiroslav off the review (they haven't chimed in yet and this PR has been open for a week).

Are we planning on merging this with the console logs?

Are we planning on merging this with the console logs?

It's unusual and not our best practice - but I would advise we merge it as is (or after review comments). The flows are commented out until we are ready to use them and we will remove that console.log soon.
The lack of reviews here is affecting my ability to GSD. So, I would prefer not to wait for the date picker refactor to happen (if that's the current blocker or cause for delay here).

Ok I think the crash should be fixed now. The hacky code to fix the cursor position threw me off my game.

Reviewer Checklist

[ ] I have verified the author checklist is complete (all boxes are checked off).
[ ] I verified the correct issue is linked in the ### Fixed Issues section above
[ ] I verified testing steps are clear and they cover the changes made in this PR

[ ] I verified the steps for local testing are in the Tests section
[ ] I verified the steps for Staging and/or Production testing are in the QA steps section
[ ] I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
[ ] I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)

[ ] I checked that screenshots or videos are included for tests on all platforms
[ ] I included screenshots or videos for tests on all platforms
[ ] I verified tests pass on all platforms & I tested again on:

[ ] Android / native
[ ] Android / Chrome
[ ] iOS / native
[ ] iOS / Safari
[ ] MacOS / Chrome / Safari
[ ] MacOS / Desktop

[ ] If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
[ ] I verified proper code patterns were followed (see Reviewing the code)

[ ] I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
[ ] I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
[ ] I verified that comments were added to code that is not self explanatory
[ ] I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
[ ] I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
[ ] I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
[ ] I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
[ ] I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
[ ] I verified the JSDocs style guidelines (in STYLE.md) were followed

[ ] If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
[ ] I verified that this PR follows the guidelines as stated in the Review Guidelines
[ ] I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
[ ] I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
[ ] I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
[ ] If a new component is created I verified that:

[ ] A similar component doesn't exist in the codebase
[ ] All props are defined accurately and each prop has a /** comment above it */
[ ] The file is named correctly
[ ] The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
[ ] The only data being stored in the state is data necessary for rendering and nothing else
[ ] For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
[ ] Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
[ ] All JSX used for rendering exists in the render method
[ ] The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions

[ ] If any new file was added I verified that:

[ ] The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory

[ ] If a new CSS style is added I verified that:

[ ] A similar style doesn't already exist
[ ] The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG)

[ ] If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
[ ] If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
[ ] If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
[ ] If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
[ ] If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
[ ] I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Web

Mobile Web - Chrome

Mobile Web - Safari

Desktop

iOS

Android

mobile safari / mobile chrome are crashing for me (not on main) @marcaaron

@grgia did you pull the branch before re-testing? I am testing on mWeb and don't see any crashes.

Quick update here. This PR is a lot simpler now. TL;DR I got some bad conflicts from this PR and the MoneyRequestAmountPage will need to be looked into more closely as there were other dependencies added.
Originally, I set out to refactor that component and the description stuff so that things would be more DRY, but abandoned that for now as it will take too much time to improve and this PR continues to get confusing conflicts leading to delays in general.
So what did this PR end up... doing??

Adds the route for the edit request page.
Adds the edit description page (this will need to be refactored)

The other pages will also need more thought to incorporate so I suggest we do a follow up for each one and then do a final PR to call the API.

Updated

Cool. I am skipping testing on the rest of the platforms because we have been waiting a while and parts of the UI we are adding are not even accessible. We can test the flow again in the later stages of development. I am confident that these changes are fine.

:hand: This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

🚀 Deployed to staging by https://github.com/marcaaron in version: 1.3.31-0 🚀

platform
result

🤖 android 🤖
failure ❌

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
success ✅

🕸 web 🕸
success ✅

🚀 Deployed to production by https://github.com/luacmartins in version: 1.3.31-3 🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
cancelled 🔪

🍎 iOS 🍎
success ✅

🕸 web 🕸
success ✅

🚀 Deployed to production by https://github.com/luacmartins in version: 1.3.31-3 🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
success ✅

🕸 web 🕸
success ✅


[BREAKING] Disable overrides via query string by default

This PR adds ability to toggle ability to override spas via query string and disables this behavior by default.
Closes https://github.com/single-spa/import-map-overrides/issues/103

I agree with this change. Since this alters the default behavior to disable a feature, it is a breaking change rather than a patch. I'll test locally and update the changeset.

Added some documentation and updated the changeset.

Released in https://github.com/single-spa/import-map-overrides/releases/tag/v4.0.0


Revert "object_storage: make object storage config field types more precise

About this change - What it does
This reverts commit 73fb83b6
Why this way
This checks that the file or folder exists at the time the config object is created,
it's perfectly valid for the file or folder to not exist when the object is created
and sometimes impossible for that file or folder to exist:
The config may be created in a different environment from where the config
will be used in the end (different chroot, container or server).
Using the object type to validate a property that is actually not part of the
object but part of the external environment is flaky anyway: the environment
will change outside of the control of the object and the property validated
when the object was constructed will become false while the code using
the object will believe that property is still true.

Codecov Report

Merging #140 (de5bdec) into main (3142922) will decrease coverage by 0.03%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main     #140      +/-   ##
==========================================
- Coverage   66.53%   66.51%   -0.03%
==========================================
  Files          35       35
  Lines        3846     3846
==========================================
- Hits         2559     2558       -1
- Misses       1287     1288       +1

Files Changed
Coverage Δ

rohmu/object_storage/config.py
98.07% <100.00%> (ø)

... and 1 file with indirect coverage changes
:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more

While I agree with the revert itself, it would be better to prevent this kind of mistakes in the future. I see two options: add TypeAlias for str with the explanation in the comment, or by adding comments in field definition lines for visibility. I would choose TypeAlias, since the knowledge that this is a path, but it is not validated, will be visible in IDEs without checking for comments.

Good point.
I've typed it as python's Path, which does not suffer from the same problem and added a comment.

@kmichel-aiven Do we support something except POSIX (e.g. Windows)? I couldn't find this information in setup.cfg, hence the question. If we do, then this is probably incorrect, since on my Fedora machine:
In [1]: from pathlib import Path

In [2]: Path("C://")
Out[2]: PosixPath('C:')

@kmichel-aiven Do we support something except POSIX (e.g. Windows)? I couldn't find this information in setup.cfg, hence the question. If we do, then this is probably incorrect, since on my Fedora machine:
In [1]: from pathlib import Path

In [2]: Path("C:\\")
Out[2]: PosixPath('C:')

We don't support windows :)


Prevent infinite hang on WebSocket response.close() (#1002)

What do these changes do?
WebSocketResponse.close() would no longer block indefinitely even when a malicious client sends bogus messages with an interval shorter than server-side close timeout.
Are there changes in behavior for the user?
No changes.
Related issue number
#1002
Checklist

[x] I think the code is well written
[x] Unit tests for the changes exist
[ ] Documentation reflects the changes

The close() method now checks the time elapsed since the original
starting time as well as the timeout for each iteration.

Now close() should wait no more than at most twice of the timeout
given to WebSocketResponse.

Current coverage is 95.17% (diff: 100%)

Merging #1084 into master will decrease coverage by 2.46%

@@             master      #1084   diff @@
==========================================
  Files            28         28
  Lines          6397       6398     +1
  Methods           0          0
  Messages          0          0
  Branches       1085       1086     +1
==========================================
- Hits           6246       6089   -157
- Misses           79        226   +147
- Partials         72         83    +11

Powered by Codecov. Last update 1cf6c18...157c136

Thanks!

Shouldn't we set self._close_code ? Also we should return true

And self.exception should be set to a Timeout error just like the Timeout fired a few lines below


[ECOS-94] Adding examples for subaccounts

Updated documentation as well: https://bluefin-exchange.readme.io/v2.0/reference/create-sub-account

Need to update version in toml file


Ping test should keep running during transfer phase to measure bufferbloat

Hi
I noticed that the speedtest client only does a single ping measurement before the download and upload tests, but fails to measure latency under load while the transfers are running. This is a mistake: measuring latency under load is a really simple way to get an indication of whether the user suffers from bufferbloat, one of the most common problems affecting perceived user networking performance.
To see examples of how other speedtests incorporate bufferbloat measurements, see:

DSL reports: https://www.dslreports.com/speedtest
Fast.com: https://fast.com (visible when clicking "show more info")

For more information about bufferbloat see:

Introduction to bufferbloat: https://www.bufferbloat.net/projects/bloat/wiki/Introduction/
Tests for bufferbloat: https://www.bufferbloat.net/projects/bloat/wiki/Tests_for_Bufferbloat/

This really ought to be part of the test specification, but I couldn't find a way to open a bug against that, so opening this instead.
If you need more information about how best to incorporate bufferbloat tests into your speedtest, we are multiple people willing to help on the bufferbloat mailing list: https://lists.bufferbloat.net/listinfo/bloat

Hello @tohojo ,
thank you for your input!
On a first glance, this looks doable without server modifications. So the best place to start for a proof of concept is probably the web client rtr-nettest/rmbtws. I'll move the issue there.