replace circle with circleMarker in quick-start guide

Checklist

[x] I've searched through the current issues to make sure this change hasn't been suggested already.
[x] I agree to follow the Code of Conduct that this project adheres to.

Which documents need updating?
https://leafletjs.com/examples/quick-start/
Motivation
I believe that for most leaflet users, especially those coming to the quick-start guide - the idea of using a circle as an "abstract representation of data" (e.g. a marker) is more common than the use-case for "plotting a real-world circle of fixed radius in meters".
We can debate this a bit, but I see quite a few examples of folks using circle() incorrectly as markers (and thus running into weird effects at extreme latitudes), and I feel that using circleMarker() within the quick-start guide will help mitigate this.
Suggested changes
I'd change
https://github.com/Leaflet/Leaflet/blob/main/docs/examples/quick-start/index.md
https://github.com/Leaflet/Leaflet/blob/main/docs/examples/quick-start/example-overlays.md
to reference circleMarker() instead of circle() and update with an appropriate radius as needed.
I'm happy to make this PR myself - but wanted to discuss here first

Hi i am new to open source Maybe this is an issue i can start with?

Hi,
thank you for your suggestion.
In my eyes there are less usecases to use a CircleMarker then a Circle. Most of the users have own Icons for theier Marker so they are not using a CircleMarker (which can't be customized except for color-style) . The Circle is used to show in which range something will be or the accouracy GPS or a search radius, etc.
Do you have some references that the CircleMarker is more common?

Hi am new to open source can I work on this project

Please take another one, I will close this one.


Add function for writing N bytes of randomness

Issue:
Currently, you need to jump through hoops if you only want to write N bytes to a buffer, because our existing aws_device_random_buffer(aws_byte_buf *dst) function simply fills the buffer to capacity.
Description of Changes:

New function for appending N bytes aws_device_random_buffer_append(aws_byte_buf *dst, size_t n)
Fix bug on windows when writing more than UINT32_MAX bytes

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Codecov Report
Patch coverage: 100.00% and project coverage change: -1.41 :warning:

Comparison is base (21d478b) 81.88% compared to head (3822c11) 80.48%.

:exclamation: Current head 3822c11 differs from pull request most recent head c528ec0. Consider uploading reports for the commit c528ec0 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1005      +/-   ##
==========================================
- Coverage   81.88%   80.48%   -1.41%
==========================================
  Files          52       52
  Lines        5553     5472      -81
==========================================
- Hits         4547     4404     -143
- Misses       1006     1068      +62

Impacted Files
Coverage Δ

source/posix/device_random.c
76.19% <100.00%> (+2.50%)
:arrow_up:

... and 2 files with indirect coverage changes
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.


A syntax error breaks autocomplete

A minimal example: autocomplete does not work on the k.. If you delete the a you will find that autocomplete works again.
If this is expected behavior I recommend closing this and opening another ticket to remember to document this behavior.
local k = import "../vendor/ksonnet-lib/ksonnet.beta.2/k8s.libsonnet";

a

k.

It should work if you add a semicolon after k.. The issue is that we don't have an incremental parser, so we have a hard time figuring out where an error "really" is in the document, so adding a . somewhere in the source between 2 identifiers will cause that part of the document to parse, but it might cause some other distant part of the document to break.
We will fix this when we implement the incremental parser, but for now this is actually better than the alternatives.

We should keep it open so I remember to fix it.


Filipe/legacy event stream

Test failures were not related

@mangas do you still have the failing build link? I'm worried we have non-deterministic tests 😕


feature request: :wq

Did you check existing requests?

[X] I have searched the existing issues

Describe the feature
:wq currently behaves like :w. If the command was successful (the user presses [O]k), :wq should close Neovim as well.
Provide background
I genuinely might see myself using oil.nvim as a file manager replacement, and this would save a lot of time for quick operations.
Additional details
No response

I added support for this. It's a bit of a hack, but it seems to work well enough. I'm a little concerned that there may be some unintended edge cases, so there's a chance I'll have to tweak this or roll it back.

I'm running into an edge case of this change that causes Neovim to close unexpectedly.
I have the following keymaps:
vim.keymap.set('n', '<leader>w', '<CMD>w<CR>', {})
vim.keymap.set('n', '-', '<CMD>Oil<CR>', {})
To reproduce:

Open Neovim.
Close Neovim with :x.
Open Neovim.
Open Oil with - keymap.
Create a file.
Save the buffer with <leader>w keymap.
Neovim closes.

This happens because commands run through keymaps are not inserted into the history table so the last command is still :x.
Thanks for all the work you do!

I'm using LunarVim and the default w doesn't play nice with oil. However, I found overwriting the default w fixes it.
vim.api.nvim_del_keymap('n', '<leader>w')
vim.api.nvim_set_keymap('n', '<leader>w', ':w<CR>', { noremap = true, silent = true })


Add top menu and launcher

Closes https://github.com/QuantStack/jupytercad/issues/139

Isn't here a way to have a CSS selector that checks for the light/dark body data attribute so that we set those variables correctly depending on this?

If we're able to do it this way, we may not need to implement our own themes for JupyterCAD, and we may support any theme.

Isn't here a way to have a CSS selector that checks for the light/dark body data attribute so that we set those variables correctly depending on this?

If we're able to do it this way, we may not need to implement our own themes for JupyterCAD, and we may support any theme.

Thank you for pointing it out! The dark theme looks a little bit better now
https://github.com/QuantStack/jupytercad/assets/4451292/77d2226a-cc01-47d2-801d-7e97b30902ff

Niiice!


Make Cmd a Monoid and/or Applicative/Monad

This would make helpers at the Cmd level (e.g. focusCmd, focusSelectCmd) much much nicer to use in combination with other Cmds, e.g animations)
I think the current design of the Cmd ADT could be made into a Monoid and/or Applicative.  Ap could be even made parallel.  Monad should possible but would be a lot of work, and confusing to use - all those ansychronous emits.
Current aim: sequential <>, parallel <*>.  No monad.

Implementing the Applicative instance has the same problem the monad has:  it would be necessary to collect all the results before combining.  This would completely change the semantics .. e.g for an animation it would loose all the delays (and thus, all intermediate steps).
Monoid should be possible though

Not enough bang for the buck, will not be implemented

Still won't implement the Monad/Applicative instances though.
An emittingTask can call it's emitter multiple times.  It would be possible to wait for the values with an AVar, and somehow signal the end when the emittingTask ends, but why?  Pure commands are an array, just compose that.  And the task commands are Aff actions - they are fully composable as well.

Oops, I made a monad instance.  This lets us define empty and pure ... kill emptyCommand and pureCommand?

Having worked with the new combinators:  this is awesome.
I want a parallel apply, and alt should choose the first message that arrives on either stream of messages.
Not sure yet whether bind and apply should permute or zip.  I suspect zipping would be more useful, but I'll have to think about it some more.

This is in https://github.com/grmble/purescript-bonsai-types now.
bind/apply have permute semantics, like array and other collections.  append has string ordering, alt forwards any message that comes in.
Still missing: parallel apply, racing operator.  Worth the effort? Dunno.
https://github.com/grmble/purescript-bonsai-types/issues/1


fix: unicode truncation bug

This has some pretty comprehensive tests covering quite a few edge cases as rstests.
This has 3 bugs still I think in the rendering, but these are not panics.

"1234🦀7890" right aligned into a 5 wide buffer renders as "🦀789" instead of " 7890" (definite error)
"ab🦀cdef" centered into a 2 wide buffer renders as "🦀" instead of " c" (debatable error)
"ab🦀cdefg" centered into a 2 wide buffer renders as "🦀" instead of " c" (debatable error - especially as 1 wide renders "c")

Fixes: https://github.com/ratatui-org/ratatui/issues/1032

I'd suggest that for this PR it's probably worth:

fixing up any obvious simplifications / problems I've missed
disabling the broken tests (unless there's a really obvious test fix for the right alignment one)
merging this and making a 0.26.3 release pretty soon.
If there's an easy and obvious way that unicode-truncate helps simplify this, then we should consider that

Note this stems from https://github.com/ratatui-org/ratatui/pull/1082 credit goes to @EdJoPaTo for making it easier to see a way to make a fix for this.
Side note: there's also a truncate crate, which does various unicode split_at things, but it uses unicode-segmentation instead of unicode-width for calculating positions - there's some subtle incompatibilities with the approaches. The ideas / methods might be useful to consider for unicode-truncate however.

Side note: there's also a truncate crate, which does various unicode split_at things, but it uses unicode-segmentation instead of unicode-width for calculating positions - there's some subtle incompatibilities with the approaches. The ideas / methods might be useful to consider for unicode-truncate however.

I also suggested unicode-segmentation for unicode-truncation as it currently rips apart stuff that belongs together like Emoji combinations (Flags for example): https://github.com/Aetf/unicode-truncate/pull/11

Side note: there's also a truncate crate, which does various unicode split_at things, but it uses unicode-segmentation instead of unicode-width for calculating positions - there's some subtle incompatibilities with the approaches. The ideas / methods might be useful to consider for unicode-truncate however.

I also suggested unicode-segmentation for unicode-truncation as it currently rips apart stuff that belongs together like Emoji combinations (Flags for example): Aetf/unicode-truncate#11

There's a lengthy debate on to use / not use segmentation in https://github.com/ratatui-org/ratatui/issues/75 (ratatui's longest open issue). I don't know which side of that debate has more merit, and it's likely that using unicode-segmentation within the truncation crate would break things in other ways for many terminals / use cases.

There's an EXTREMELY lengthy debate on to use / not use segmentation in #75 (ratatui's longest open issue). I don't know which side of that debate has more merit, and it's likely that using unicode-segmentation within the truncation crate would break things in other ways for many terminals / use cases.

Also, I forgot that we do use segmentation when doing grapheme splitting, so maybe that is the right abstraction. I'm unsure how exactly to test an edge case on this one without delving a vast amount more into unicode than I want to right now.

I've updated the tests so that the document the current behavior even if it's wrong (as noted in the first post).
This is better than panicking, so I'd suggest merge, release, and keep a bug open to fix the more minor issue.

The code is very readable and merging this even with bugs is good to me! I like that there are tests that capture the behavior.
I don't quite understand why this works (haven't had a lot of time to go through it in detail). Maybe the PR description can have a high level description of why this works?
Unrelated to this PR but it would nice to collect links to resources on the developer guide sector of website about Unicode that for uninitiated potential contributors to read.

I don't quite understand why this works (haven't had a lot of time to go through it in detail). Maybe the PR description can have a high level description of why this works?

Added an algorithm comment to help in the code

Added heavily inspired by unicode-truncate code to find the index in order to get the starting index. This allows for taking a reference rather than cloning into an ever-more-allocating String.
I think this would be a great addition for unicode-truncate especially with all the related test cases specific for this.
Some test cases expect " c" with a space in the beginning where the multi width Unicode was.
This requires padding → Owned data → has a bigger performance impact. But it's something for step 2, ideally even solved within unicode-truncate too.
(Mentioning @Aetf here as they might be interested in this discussion)
Did not remove the split_at method which obviously annoys the CI.
Benchmark after the change. (Results on a Raspberry Pi 3 are similar while taking ~10 times the time)
line_render/0           time:   [82.312 ns 82.321 ns 82.329 ns]
                        change: [-13.630% -13.444% -13.279%] (p = 0.00 < 0.05)
                        Performance has improved.
Found 148 outliers among 1000 measurements (14.80%)
  100 (10.00%) low severe
  3 (0.30%) low mild
  16 (1.60%) high mild
  29 (2.90%) high severe
line_render/3           time:   [179.75 ns 179.88 ns 180.00 ns]
                        change: [-26.027% -25.958% -25.891%] (p = 0.00 < 0.05)
                        Performance has improved.
Found 4 outliers among 1000 measurements (0.40%)
  3 (0.30%) high mild
  1 (0.10%) high severe
line_render/4           time:   [202.37 ns 202.48 ns 202.60 ns]
                        change: [-24.577% -24.503% -24.432%] (p = 0.00 < 0.05)
                        Performance has improved.
line_render/6           time:   [262.62 ns 262.75 ns 262.88 ns]
                        change: [-20.892% -20.719% -20.522%] (p = 0.00 < 0.05)
                        Performance has improved.
Found 5 outliers among 1000 measurements (0.50%)
  3 (0.30%) high mild
  2 (0.20%) high severe
line_render/7           time:   [281.92 ns 282.05 ns 282.20 ns]
                        change: [-20.378% -20.302% -20.212%] (p = 0.00 < 0.05)
                        Performance has improved.
Found 25 outliers among 1000 measurements (2.50%)
  19 (1.90%) high mild
  6 (0.60%) high severe
line_render/10          time:   [359.13 ns 359.72 ns 360.49 ns]
                        change: [-13.931% -13.808% -13.652%] (p = 0.00 < 0.05)
                        Performance has improved.
Found 32 outliers among 1000 measurements (3.20%)
  20 (2.00%) low mild
  5 (0.50%) high mild
  7 (0.70%) high severe
line_render/42          time:   [518.82 ns 518.92 ns 519.03 ns]
                        change: [-1.9234% -1.8597% -1.7990%] (p = 0.00 < 0.05)
                        Performance has improved.
Found 6 outliers among 1000 measurements (0.60%)
  1 (0.10%) low mild
  1 (0.10%) high mild
  4 (0.40%) high severe

Some test cases expect " c" with a space in the beginning where the multi width Unicode was.
This requires padding → Owned data → has a bigger performance impact. But it's something for step 2, ideally even solved within unicode-truncate too.

Oh… it actually doesn't in our use case as we can just increase the x += n and continue render further right (Buffer::set_stringn does something similar).

I think there might be some general assumed area.x == 0 in here due to code that uses the span_offset. This works for the tests if the line is rendered at x=0 but i think it might break when that's not the case (for the partial rendered span part of the line at least).

Yeah, this fails currently: 0a55e7618d2422377fe5b3704a81bbdb06a26c00

All tests passing (and corrected so that the edge cases seem like they're the right result)
E.g. right aligned text that does not have enough space to render the first emoji will not overwrite any first character(s) in that position.
I think this is probably good to go now

There's another possible simplification (for future consideration on this) that teases apart the span selection and span rendering. Something like (pseudo code):
fn render_ref(...) {
  for span in self.visible_spans(...) {
    span.render_ref(area, buf)
    let area = area.indent(span.width())
    if area.is_empty() { break }
  }
}

fn visible_spans(...) -> Iterator<&Span> {
  skip non-visible spans
  chain!(truncated first span, rest of spans)
}

I experimented briefly with this, but I think it's only possible if visible_spans returns owned Spans instead of refs due to the truncation - it's worth another try (in a future PR).

I'll wait on @EdJoPaTo's approval to merge this

The logic is somewhat horribly complex as a lot of stuff isn't intuitive… The widths are usize and not u16 as the truncation of the end is implicitly done. That resulted in misunderstandings in what should happen. I don't think we can fully explain the code by comments. We need many tests to ensure it actually does what it is expected to do. Lines/Spans longer than u16 for example is a whole new mess which I haven't thought about before.
Also, I refactored the code to iterator logic. I'm fine with reverting it. Benchmarks suggest it's similar in performance. But it might be even harder to follow what is going on?

Some final tweaks:
It's important to look the absolute magnitude of a perf gain, and not just the relative amount. On my M2 mac, removing this costs ~30ns. This which means for an app running at an absolutely absurd 1000FPS, the app would now run at 999.97 FPS. This isn't worth keeping the code to optimize.

Remove perf fast path for left aligned lines as the absolute perf diff
is negligible (30ns on an M2 Mac)
move the visible spans calculation to a method that returns an
iterator over the spans that are visible
replace truncation clippy lints with converions that clamp to u16::MAX
replace arithmetic_side_effects clippy lint with saturating_sub
remove debug_asserts
rewrite comments in the precise imperative mood ("when this, then that", rather than "if this then it's necessary / we only need to")

I'd like to get this released (perhaps Monday if @orhun is up to it).
Direct link to the current file as of the last commit: https://github.com/ratatui-org/ratatui/blob/43118c5494f5218332319a41eb742a51138d7e3c/src/text/line.rs#L555
The actual complexity of the implementation is pretty much aligned with the inherent complexity of the problem, and it's documented well enough.

I'm not too worried - most text that's rendered in the context of a tui app isn't > u16::MAX, and when it is the resultant bug is easy to fix by pre-trimming the text instead of doing this in the rendering.

I am not worried about the actual bug that came up. I am more worried that 3 people looked over it for days and missed yet another bug.

I replaced these with infallible code.

What I liked about it were the assumptions actually tested. We wrote code with assumptions which are now hidden behind infallible code. But with all the tests, fine by me.

Remove perf fast path for left aligned lines as the absolute perf diff is negligible (30ns on an M2 Mac)

I am not at all worried about way overpowered hardware. I know that mqttui is used on Raspberry Pi, personally I regularly use mqttui on Raspberry Pi 1.
Line is one of the core constructs used by a lot of things. Relatively small improvements will impact a lot of code depending on it. So it's way more significant to improve the performance here. And also the Alignment::Left is the default for most things so it has the most impact.

To pick even more on the performance fast path of Alignment::Left on slower devices…
Let's imagine a table rendered on a 100x100 terminal. Assume 5 columns and 90 rows. The table cell used Text, so many Lines. More cells vs. more lines per cells are probably irrelevant.
90 * 5 means 450 visible Cells to be rendered. The worst case time in the benchmark below is the Buffer wider than the Line width with 9.7 µs. Let's assume 10 µs for ease of calculation.
10 µs * 450 = 4.5 ms. 60 FPS are 16.66 ms. So we took 1/4 of that for the rendering of lines alone.
And this is a Raspberry Pi 2 benchmark, I use mqttui on Raspberry Pi 1 regularly.
Even an improvement of 12% is really good here already. The benchmark goes to a regression of 36%. So this is definitely significant. For the default of left alignment which is the most often used one.
Benchmark on Raspberry Pi 2:
line_render/Left/3      time:   [2.7422 µs 2.7427 µs 2.7433 µs]
                        change: [+34.945% +36.396% +37.329%] (p = 0.00 < 0.05)
                        Performance has regressed.
Found 68 outliers among 1000 measurements (6.80%)
  48 (4.80%) high mild
  20 (2.00%) high severe
line_render/Left/4      time:   [2.9284 µs 2.9290 µs 2.9297 µs]
                        change: [+33.260% +33.549% +33.885%] (p = 0.00 < 0.05)
                        Performance has regressed.
Found 23 outliers among 1000 measurements (2.30%)
  13 (1.30%) high mild
  10 (1.00%) high severe
line_render/Left/6      time:   [4.7153 µs 4.7158 µs 4.7164 µs]
                        change: [+23.409% +24.391% +24.993%] (p = 0.00 < 0.05)
                        Performance has regressed.
Found 63 outliers among 1000 measurements (6.30%)
  30 (3.00%) high mild
  33 (3.30%) high severe
line_render/Left/7      time:   [4.9508 µs 4.9513 µs 4.9518 µs]
                        change: [+23.962% +24.193% +24.427%] (p = 0.00 < 0.05)
                        Performance has regressed.
Found 44 outliers among 1000 measurements (4.40%)
  24 (2.40%) high mild
  20 (2.00%) high severe
line_render/Left/10     time:   [7.0004 µs 7.0016 µs 7.0030 µs]
                        change: [+16.254% +16.648% +16.980%] (p = 0.00 < 0.05)
                        Performance has regressed.
Found 46 outliers among 1000 measurements (4.60%)
  21 (2.10%) high mild
  25 (2.50%) high severe
line_render/Left/42     time:   [9.7193 µs 9.7207 µs 9.7224 µs]
                        change: [+12.279% +12.559% +12.887%] (p = 0.00 < 0.05)
                        Performance has regressed.
Found 131 outliers among 1000 measurements (13.10%)
  57 (5.70%) low mild
  35 (3.50%) high mild
  39 (3.90%) high severe

Benchmark of Raspberry Pi 4: regression of 14.3 to 38.7%. Worst case takes ~2.03 µs, so ~5 times faster than Pi 2.
I will not benchmark this on Pi 1 as running the benchmarks on Pi 4 take ~10 min, on Pi 2 ~40 min. Pi 1 is single core in comparison to Pi 2 with 4 cores.

10 µs * 450 = 4.5 ms. 60 FPS are 16.66 ms

Let's look at the absolute magnitude of the change though: (10 * .125) = 1.25us per call
1.25*450 = 0.563ms, so each frame now takes (16.667+0.563) = 17.23ms = 58 FPS. That's measurable sure, but rarely directly noticeable. Assuming a factor of 4 on the Pi 1, 18.92ms = 53 FPS.
One thing I did note when removing the fast path was that the slow paths got slightly faster (1-4%), so the tradeoff is one that doesn't necessarily have a definitively good answer.
For now, I'd like to keep it simplified, and keep this PR about fixing the bug and not trying to eek out all the performance of this. You've convinced me that there are some parts of this that matter to you, so let's continue the discussion about perf in an issue / forum topic if it's more a discussion.

Pi 1 is single core in comparison to Pi 2 with 4 cores.

This raises an interesting point. I wonder (not for this PR), what parts of our rendering pipeline might be able to be done more in parallel.


Remove password verification

Problem
cockpit is blocking the usage of weak passwords. The system (Debian 10) is allowing this usage (checked with running "adduser" and the same weak password). Please add an option to disable your password verification
cockpit version 188
linux version: Debian GNU/Linux 10 (buster)
Reproduce

in the cockpit UI open "...:9090/users" and click "Add Account" (or whatever the original text is)
enter the username and a weak password (f.eg. "ma99" - of course twice)
click "create"

Result
You'll get the response "Password quality check failed: The password is shorter than 8 characters".
Wrong: I never decided to have a minimal length for passwords.
For a locally driven (not connected) server it is rediculous to have long and complex passwords.
System behaviour
Using the bash on the system directly, there is no problem to create the user with the same password:

type "adduser testname"
type the weak password twice
confirm all other questions simply by pressing the "return" key
voila ! the user has been created without problems.

Expected result
The user should not be blocked when specifying a weak password. Please remove the password verification altogether ... or add an option in your software to avoid this behaviour.
(also requested in ticket #985 by jgiardino but closed without a real solution)

This belongs to https://github.com/cockpit-project/cockpit - I cannot transfer this issue for some reason, maybe I don't have enough privileges for this repo or github allows transferring only inside organization? @snoopy72 maybe you can transfer it there as author?
Back to the issue: Cockpit uses pwscore to check for password quality.
$ /usr/bin/pwscore
ma99
Password quality check failed:
 The password is shorter than 8 characters

This is configurable in /etc/security/pwquality.conf. (In this case minlen=4 I guess?)
This however still leaves the question opened as if we should or should not enforce strong passwords if useradd does not enforce it either (I thought it does do that). Maybe a good approach would be to do something like anaconda does, that you need to click twice on OK if the password is weak to make sure you are aware you are using weak one.

Same problem in version 225.
The problem is not the warning itself - higer security is always welcome, because most users password ist "password" or "xxx".
BUT:
Running a local (test) server for limited access and private LAN testing is something different. And even if somebody is thinking, strong password have to be forced ... when somebody wants a weak password, he/she should get it. It's not the job of a developer to teach the customer (i am a developer for 40+ years, so believe me).
The idea of @marusak (confirm the bad password) is a good way.
Reopening the case in "cockpit" with link to this case for these comments. Thanks, marusak.

Leading ticket should be in cockpit. closing this one.


@total_ordering : Is it required

While this decorator makes it easy to create well behaved totally ordered types, it does come at the cost of slower execution and more complex stack traces for the derived comparison methods. If performance benchmarking indicates this is a bottleneck for a given application, implementing all six rich comparison methods instead is likely to provide an easy speed boost.

I didn't know this decorator has performance issues. I used it so I could use sorted()
Using sorted() helps me generate reports in a reproducible way, ensuring that modalities/sessions are not shuffled everytime. I will add it as a github issue

let’s review it later, and consider potential alternatives for future..
one could be :
self._sub_nodes = OrderedDict()

also reviewing the need for sorting in the first place.


clone codec per worker

Per discussion in elastic/logstash/issues/8830 each input worker should have its own codec instance.

code looks ok. Any thoughts on adding a test? Maybe something that sends 2 lines in a single UDP packet and asserts that 2 events come out? Also that 2 events (line delimited w/ line codec) per packet, sending 2 packets, results in 4 events?

@jordansissel yeah, good idea, will do.

@jordansissel added new test, LMKWYT.

Delightful, thank you!
LGTM

Good catch, I didn't notice that removal. A test for shutdown should still be included (https://github.com/elastic/logstash-devutils/blob/master/lib/logstash/devutils/rspec/shared_examples.rb).

@jordansissel @yaauie OMG good catch - dunno why/how I removed that, a mistake.

Added deleted spec, assuming it now LGTM per your comments - thanks @jordansissel  @yaauie

rebased changes, added version bump commit, will merge and publish.

LGTM


Can the code for generating instruction data using GPT-4 be made public?

Can the code for generating instruction data using GPT-4 be made public?
Because I have two related questions:

I would like to know if you use bounding boxes when generating all three types of data? Because table 11 and table 12 in your paper do not contain bounding boxes.
I see that all the queries in the data (llava_instruct_150k.json) are marked as from human, how did you collect these queries? Is the self-instrut method used?

I would appreciate it if you could answer my question!

Hi @gray311, the conversation data was generated without the bounding boxes, while the detailed description and reasoning data is generated with bounding boxes.
We generate the data by querying text-only GPT-4 following a similar pipeline as self-instruct, except that we are using fewer few-shot samples.  And marking them as Human:  and GPT is simply complying with the format in Vicuna code base that we build with.
All system messages, prompts, and few-shot samples are released here.  You may refer to them on detailed format and content that we used to generate these data.
Please let me know if you have further concerns.

o

Thank you for your reply!
I have one more question, where did you guys get this query from in the process of generating the conversations?

@hjjpku Your understanding is correct :)  And for complex reasoning and detailed description, we also add bounding boxes.  You may refer to here for each prompt that we use.

@gray311 Regarding query please see my response above.  And no-instruction tuning means that we only perform the first stage training, and do the evaluation.

@haotian-liu Thanks for your reply!

@hjjpku Thanks for your reply!

@RyanHuangNLP I think you are right.

@haotian-liu Great work. I have a follow-up question -- after you create instruction-following samples, how do you reject a bad generated sample? I didn't see it anywhere in the paper, but I am curious about it, as I probably need to follow your work and generate more samples.

@haotian-liu hi, thanks for such a great work. I have one follow-up question, why did you decide to not include bounding boxes into the context for the conversation type? I think, given the object information as a context, GPT-4 can generate more accurate answers for the questions regarding object location or object counts! Your reply would help me a lot, thanks!


could not able connect with android

Hi Thanks for provide great example but i am getting  these error in android client logs:
W/xlui.example.i: Accessing hidden method Landroid/view/View;->computeFitSystemWindows(Landroid/graphics/Rect;Landroid/graphics/Rect;)Z (light greylist, reflection)
W/xlui.example.i: Accessing hidden method Landroid/view/ViewGroup;->makeOptionalFitsSystemWindows()V (light greylist, reflection)
D/NetworkSecurityConfig: No Network Security Config specified, using platform default
W/xlui.example.i: Accessing hidden method Ldalvik/system/CloseGuard;->get()Ldalvik/system/CloseGuard; (light greylist, reflection)
Accessing hidden method Ldalvik/system/CloseGuard;->open(Ljava/lang/String;)V (light greylist, reflection)
Accessing hidden method Ldalvik/system/CloseGuard;->warnIfOpen()V (light greylist, reflection)
D/StompClient: Connect
D/AbstractConnectionProvider: Emit lifecycle event: ERROR
D/StompClient: Socket closed with error
D/AbstractConnectionProvider: Emit lifecycle event: CLOSED
D/StompClient: Socket closed
D/StompClient: Stomp disconnected
I/xlui: Subscribe to the broadcast
I/Adreno: QUALCOMM build                   : cf57c9c, I1cb5c4d1cc
Build Date                       : 09/23/18
OpenGL ES Shader Compiler Version: EV<IP_ADDRESS>
Local Branch                     :
Remote Branch                    :
Remote Branch                    :
Reconstruct Branch               :
Build Config                     : S L 6.0.7 AArch64
I/Adreno: PFP: 0x005ff112, ME: 0x005ff066
I/ConfigStore: android::hardware::configstore::V1_0::ISurfaceFlingerConfigs::hasWideColorDisplay retrieved: 0
I/ConfigStore: android::hardware::configstore::V1_0::ISurfaceFlingerConfigs::hasHDRDisplay retrieved: 0
I/OpenGLRenderer: Initialized EGL, version 1.4
D/OpenGLRenderer: Swap behavior 2
I/Toast: Show toast from OpPackageName:app.xlui.example.im, PackageName:app.xlui.example.im
I/xlui.example.i: ProcessProfilingInfo new_methods=0 is saved saved_to_disk=0 resolve_classes_delay=8000
please help me on this

Hello, If you use AVD provided by Android Studio, you should use this local address instead of genymotion's local address

@xlui i am using android device for testing and i have changed url like this
public static final String address = "ws://<IP_ADDRESS>:8080/im/websocket";

It seems that Android 8 or higher has disabled cleartext support by default. see https://stackoverflow.com/questions/45940861/android-8-cleartext-http-traffic-not-permitted.
I have updated the code with Option 2 metioned by https://stackoverflow.com/a/50834600, and tested on my Android 9. Please pull the latest code and try again 😄

@xlui  thanks for solution let me try this

@xlui  it's works thanks


The sidebar height needs to consider it's height minus the navbar height.

At present the height of the sidebar is of full screen height (i.e. h-screen), by which the content at very last accordion i.e. Week 15 is hidden from the main screen.
Such that the height of the navbar should be taken care in the height of the sidebar.

@nigupta29 can you provide screenshot to make it clear that what changes you're suggesting?

In the below screenshot, if I have to select the week 15 content then I have scroll fully down to the page because the scroll bar has height of 100vh which is simply going out of the pov because the navbar height hasn't been considered in the view.
If we simply compensate the height of navbar from sidebar (i.e. current height of sidebar - height of navbar) this will resolve the issue.
It's a quick fix if you wanna do or let someone pick who is new to OS contri.
If still got some queries, hit me up on discord - jerry_codes

Hey @nigupta29 nice catch. I was the one responsible for this.

Raise a pr mostly kirat will accept and mb

Hey im new to opensource and still trying to understand the codebase. can i solve this issue.

@prasanth7890 Definitely! Go ahead!


Added complete sprint button

Solution:
The status will be updated as Completed on click.
Risk level:

[ ] high
[x] medium
[ ] low

How to test:

ng serve
Click on the complete sprint button
the status will be updated

This works totally fine when my firebase cdn is attached. and while testing with Docnos cdn, not only the completed status but also the current status is also not visible. Here I had attached a video link for your understanding.
https://www.loom.com/share/9e256ac64e10409992a28b0fe51825f8
or else refer this
https://user-images.githubusercontent.com/54079190/103030643-3a3be180-4582-11eb-958b-f70e0f7e5de3.mp4


Access to un-wrapped worker instance

According to https://github.com/GoogleChromeLabs/comlink/issues/372, in order to terminate a worker before it has completed, we need to call worker.terminate() on the worker instance. Calling it on the proxy won't work.
This package generates code like:
const proxy = wrap(
            new Worker(
              new URL("/src/components/print/print-react/internal:comlink:./documents/campPrint/my-custom.worker.js?type=module&worker_file", self.location)
              , {type: "module"})
          )

This way, accessing the new Worker(...) part is not possible. I had a look at the Comlink code, and there does not seem to be an easy way to "unwrap" the proxy.
Do you see any easy way for this package to provide access to the worker instance instead of the proxy? Or at least a way to access the terminate method on the worker instance?

Looking for a way to get the terminate method too.

I found a PR on the comlink side which would allow us to do this, but it's been unanswered since 2020... https://github.com/GoogleChromeLabs/comlink-loader/pull/27
So I created #138 to fix this on the side of vite-plugin-comlink.


[WIP] Move OFL to new website

see #453

Broken links
(Output of test script tests/http-status.js.)
There were 0 internal and 4 external links failing.

http://www.adblighting.com/?page=getsupportfile&file=165
http://www.cameolight.com/
https://www.claypaky.it/en/home/
https://www.claypaky.it/media/documents/HR_Sharpy_Manual_05.2016_EN.pdf

What a great progress of our project in the last year! :tada:


Extend Object prototype for message instances

After https://github.com/timostamm/protobuf-ts/pull/582, message instances don't behave exactly like simple objects, as their prototype only includes a Symbol("protobuf-ts/message-type") field and is missing fields normally present in a simple object (e.g. constructor). For us, this specifically causes an issue when using mobx  to observe changes to message instances - it only allows observing objects that have a constructor method in their prototype that matches the method for simple objects.
This fixes the problem by copying the default object prototype and adding a Symbol("protobuf-ts/message-type") field, rather than starting from an empty prototype.

@erichiggins0, CI was failing because of an issue with go. Pushed up https://github.com/timostamm/protobuf-ts/pull/636 to your fork.

Released in v2.9.4


About the setting of hyperparameters

Hey, thank you for sharing your wonderful work!
I am a beginner in point cloud registration and have recently been trying out your work. My own data has the same density as 3Dmatch, but with about 20w points, how can I set hyperparameters in demo.py to achieve simple point cloud registration? When I run it with the default parameters, it says I'm out of memory. Do I need to adjust the whole pixel size or something to ensure implementation

I am also learning about this model. I have found that insufficient GPU memory might be due to the excessively large scale of point cloud scenes in my dataset. Adjusting the scene scale to match that of the training set seems to resolve the issue, while the number of point clouds appears to have less impact. Additionally, I've noticed that running the demo with the same model weights and test data produces varying metrics each time. The metrics obtained from the same data in the demo and test scenarios also differ. Furthermore, the metrics from the test scenario are extremely off, such as PIR: 0.000, IR: 0.000, RRE: 168.230, RTE: 7.411, RMSE: 1.160, RR: 0.000, time: 4.800s/0.130s. The PKL files used for testing are created following the structure of existing PKL files. Could you advise me on the correct approach to testing my own data effectively?

I found the reason for the fluctuation in the demo metrics in Comment #37. After fixing it, the metrics produced by the demo are still considerably off, but they are now somewhat similar to the test metrics. This suggests that the issue lies with the model's generalization rather than my data preprocessing. I appreciate the author's responses to these issues – they are truly invaluable.

You can try adjusting the downsample Voxel size.


feat: install modern AWS CLI to Tooler

closes #91

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 63.854%

Totals

Change from base Build<PHONE_NUMBER>:
0.0%

Covered Lines:
1203

Relevant Lines:
1884

💛  - Coveralls


Basic example now adds storage content, where none was before.

When comparing the results from before the many merges, with those after, the shSourceBus_building* tabs now include storage content.
Is this a desired change?
https://github.com/SPF-OST/optihood/tree/75-get-optihood-under-ci/tests/test_examples/expected_files
Compare test_run_basic_example.xls with 'test_results_basic_example_after_merge.xls'
This can also be done using:
test_compare_results_before_and_after_merge
https://github.com/SPF-OST/optihood/blob/75-get-optihood-under-ci/tests/test_examples/test_xls_examples.py

The manual test simplifies the xls comparison using plots:
Given unequal dataframes.
A plot is shown with the two dataframes.

And, if the shape is equal, their differences.


Confirm support for try/except use in objmode block

Reporting a bug

[x] I am using the ~latest released~ master version of Numba (most recent is visible in
the change log (https://github.com/numba/numba/blob/master/CHANGE_LOG).
[x] I have included below a minimal working reproducer (if you are unsure how
to write one see http://matthewrocklin.com/blog/work/2018/02/28/minimal-bug-reports).

This:
from numba import njit, objmode
import numpy as np

@njit
def foo():
    with objmode():
        try:
            print('{}'.format("unsupported opcodes"))
        except:
            pass

foo()

does this:
$ python gi185.py
Traceback (most recent call last):
  File "gi185.py", line 12, in <module>
    foo()
NameError: global name 'mark_try_block' is not defined

which either needs fixing, or a better error message should appear.

need to fix this. shouldn't replace try-except in objmode block.

Are there any workarounds available for this if I just want to ignore the exception? For example:
@numba.njit
def fastfunc(arg1):
    val1 = 12345 * arg1
    with numba.objmode():
        try: extval = external_function()
        except: pass
    return  val1 + extval

@kartiksubbarao something like this work?
from numba import njit, objmode
import numpy as np

def external_function():
    return 10

def external_function_raises():
    raise ValueError("This function raised")

def wrap(fn):
    try:
        return fn()
    except Exception as e:
        print(e)
        pass

@njit
def foo(arg1):
    val1 = 12345 * arg1
    with objmode(val1='intp'):
        x = wrap(external_function)
        if x is not None:
            val1 += x
        y = wrap(external_function_raises)
        if y is not None:
            val1 += y
    return val1

print(foo(1))

also, Numba now has a discourse forum https://numba.discourse.group/ which is great for questions like this, please do consider posting there in future :) Thanks!

Thanks for the lightning-fast (numba-fast :-) ) response @stuartarchibald! Wrapping the function worked. I'll keep the numba discourse forum in mind for future reference.


Allow only Destructuring declaration for some classes

Expected Behavior of the rule
This rule will only allow the use of Destructuring declaration for some clases as Pair, Triple or Entry. It should be configurable because it have sense to allow things like Point or Color to use destructuring declaration. Any other use of Destructuring declaration should be marked as an error.
Probably we should add other flag to allow destructuring any private class to. It's kind of common pattern that, if you want a function to return two values you create a private class to return it and receive the value in a destructuring way. And use destructuring declarations in private classes is kind of safe because if you change the number of parameters or it's order the only affected code is in the same file
Context
This issue is related with #3256 but not the same.
The destructing declarations are dangerous because they depend on the position of the parameters. Adding a new parameter can blow up all your code in a non obvious way. So it's safer to only allow the use of it in the classes that have a defined order in their properties.

It should be configurable because it have sense to allow things like Point or Color to use destructuring declaration.

Generally agree on the idea for this rule. I'm just wondering how inconvenient would be for our users to end up having to edit the config for every class they want to destructure.

The list should be short and should not change. Other option is to allow destructuring any class with a defined annotation or something similar. But I would keep it simple at the beggining. If we have some complains about this we could add this later.

Related context: https://medium.com/a-problem-like-maria/a-problem-like-destructuring-declarations-95f10375ea8a
I think we could avoid allowing only Pair, Triple or Entry if we could forbid destructuring when there are more than one of the same type OR if the types of the variable are not explicit?
Could still have an "allow:" list in the config for the rule to override this logic.
data class MyClass1(val foostr1: String, val foostr1: String)
data class MyClass2(val foostr1: String, val fooint2: Int)
data class MyClass3(val foostr1: String, val foocharseq1: CharSequence)

non-compliant, because there is more than one val of type String
val (one: String, two: String) = myClass1

non-compliant, because there is more than one val of a type assignable to CharSequence
val (one: String, two: CharSequence) = myClass3

compliant:
val one: String = myClass1.foostr1
val two: String = myClass1.foostr2

val one: String = myClass3.foostr1
val two: CharSequence = myClass3.foocharseq1

non-compliant, because types are not specified.
val (one, two) = myClass2

compliant, because types are specified, they are different and String is not assignable to Int and Int is not assignable to String.
val (one: String, two: Int) = myClass2

I think that we should never forbid deconstructing Pair, Triple or Entry. I agree that it's safer if they have different types but you can have this type of errors calling a function and no one force you to add names on each parameter.
And, for example, Point has a very well defined order in their parameters: x and then y. Forbidding deconstructing a class point doesn't seems reasonable to me.
But I like the idea you are proposing. I think that we should have a list of classes that always can be deconstructed (you can always keep it empty to get exactly your described behaviour). If the class is not in the list we fall back to the rule that you defined.


prefix is not necessary for required fields

prefix is not necessary for required fields

Do you mean it's not required for Parsleyjs to handle them?
Then it means that the tests need to be adjusted for this to go in, as far as I can see.

@timur-orudzhov Your one change seems fine but second change doesn't.
attrs["required"] = "true" is fine.

But required-message still needs to be put as attrs['data-parsley-required-message']. attrs['required-message'] doesn't work. I have tested it with http://parsleyjs.org/dist/parsley.js.
So proper message will not be shown by parsley.js if we do
attrs["required-message"] = error_message

We need
attrs["data-parsley-required-message"] = error_message

We have {prefix} at all the places. eg: data-parsley-type, data-parsley-mincheck etc. So I prefer data-parsley-required="true" instead of required="true". So I am not merging this PR.


Hyint with inclusion of ETCCDI indices from extreme_events_v2

The hyint functionality that allows inclusion of etccdi indices calculated by the extreme_events recipe is working and under test. This is currently reading the data from a user preset directory pointing to the ./work where the etccdi indices were stored. Once extreme_events is merged into version2_development, then we can have a unique recipe calling the extreme_events diagnostic followed by the hyint one.
@jhardenberg @bouweandela How do we proceed with this? Shall we wait for extreme_events to be merged? I can provide hyint additional recipe and routine for dealing with etccdi to start to have comments on it.
@maritsandstad I added you here so you can follow the development of this part too.

Here is the preprocessing routine needed for dealing with etccdi indices in hyint:
hyint_etccdi_preproc.R
And here the recipe with the few extra settings (see etccdi_preproc etccdi_dir etccdi_list_import select_indices):
recipe_hyint_extremes.yml
Further details in #754 and #324 (now closed).

I have pushed a temporary branch having both the current version of extreme_events and hyint refined to read its output and further processes it. All is working.
The recipe with both diagnostics looks like this: recipe_hyint_extreme_events.yml
The preprocessing of extreme_events output and inclusion in hyint is performed here by hyint_etccdi_preproc.R
@bouweandela how do I pass the path of the work directory of the first diagnostic to the second diagnostic? That depends on how the diagnostic is called in the recipe.
How do we deal with metadata for authors, projects and the like when having two diagnostics in the same recipe? I added everything from both diagnostics right now.

how do I pass the path of the work directory of the first diagnostic to the second diagnostic? That depends on how the diagnostic is called in the recipe.

Make use of the ancestors key in the script section, add  ancestors: [extreme_events/main] in the section describing the hyint/main script. Do you also need the pr preprocessed data for hyint? In that case you should add ancestors: [pr, extreme_events/main].
diagnostics:
  extreme_events:
    variables:
      pr:
        mip: day
      tasmax:
        mip: day
      tasmin:
        mip: day
    scripts:
      main:
        script: extreme_events/extreme_events.R
        ...
  hyint:
    variables:
      pr:
        preprocessor: preproc
        mip: day
    scripts:
      main:
        script: hyint/hyint.R
        ancestors: [pr, extreme_events/main]
        ...

Or if the preprocessed pr data can be the same for extreme events and hyint (now you only mask out sea data for hyint), you could also move the whole hyint script section to the extreme events diagnostic section.
diagnostics:
  diagnostic:
    variables:
      pr:
        mip: day
      tasmax:
        mip: day
      tasmin:
        mip: day
    scripts:
      extreme_events:
        script: extreme_events/extreme_events.R
        ...
      hyint:
        script: hyint/hyint.R
        ancestors: [pr, extreme_events]
        ...

Note that the default value for the ancestors key is all the variables from the same diagnostic and you can add any combination of diagnostic_name/variable or diagnostic_name/script_name as ancestors. The diagnostic_name can be omitted if you are referring to variables or scripts from the in the same diagnostic section.

Good, thanks. Sure, I will apply the same approach and avoid double preprocessing of pr.

The hyint version working in pipe to extreme_events (which is now in version2_development) was uploaded to branch version2_hyint_extremes.


Add workflow to automerge dependabot minor and patch PRs

Let the machine auto-merge patch and minor dependabot PRs, like we do for Renovate PRs

Good idea. I like the explanation in the ADR


Alt text validation pattern refinement

Is your proposal related to a problem?
In #11967, we introduced Wagtail’s first ever custom accessibility check, alt-text-quality. It checks all images’ alt text to flag known bad patterns. Currently it uses this regex: \.(avif|gif|jpg|jpeg|png|svg|webp)$.
There’s room for improvement here, there are a lot of other known bad patterns which we could flag.
Describe the solution you'd like
Extend the regular expression to flag more known bad patterns in alt text. Focusing on patterns that are very clear-cut problems, in particular patterns that would fail WCAG SC 1.1.1 Non-text Content. For example:

Alt text starting with IMG_ is probably a reasonable indication that most of the alt text is a file name, and as such doesn’t serve an "equivalent purpose" to the image’s visuals.
Alt text starting with "Image of" is more verbose than it needs to be, but otherwise is an indication that the alt text is likely a description of the image, which is good

Describe alternatives you've considered
See RFC 89: ATAG 2.0 audit, RFC 51: Contextual alt text, RFC 97: Alt Text Capabilities.
Additional context
I have prepared two datasets of images alt text which we can use to trial our new rule:

35k alt text of images –  displayed on Wagtail websites’ homepages
19k alt text of CMS-managed images – also from Wagtail websites’ homepages

See thibaudcolas/alt-text-benchmark for a reference on how this data was produced.
Working on this
Contributions welcome from anyone with thoughts on what best to aim for in the context of Wagtail. @albinazs will implement the one code change and additional unit tests once we’ve decided on a new pattern.

an indication that the alt text is likely a description of the image, which is good

Just checking I understood - are we saying that this would be a good alt text? My understanding is that "Image of" and "Photo of" are unnecessary as AT announces it's an image, but "Screenshot of" may be appropriate.

Some other ideas off the top of my head, with examples from the 35k file:

Multiple words with no spaces but other common separators like - or _. These are unlikely to be proper sentences.

Examples: acm-phase-4, social-icon-instagram

Single words. While it might be possible that alt text could have a single word and still be sufficient (for example, "Beyonce", "Kitten" or "Facebook"), it's unlikely to be good quality.

Examples: play, logo, media

Starts with lowercase. Again there might be legitimate use cases ("bell hooks in October 2014" or "iPhone 15 launch event") but generally this could indicate poor quality.

Examples: leadership programs square graphic, gratitude daily tile, wsj

All uppercase. While there may be legitimate inclusion of acronyms or initialisms, an entire alt text of uppercase is unlikely to have been written by a human, or if it was it's probably minimally descriptive.

Example: AOC, DSC00752, FICEP

Contains only numbers. I can't think of a legitimate reason why alt text would contain only numbers unless it was an image of text, which would be inaccessible for its own reasons.

Examples: 110033, 2017

Starts with a non-alphanumeric character. There may be legitimate exceptions such as Spanish ¡ {sentence} ! (though I don't think exclamation marks are necessarily appropriate in alt text)

Examples:  + alt_text + ', _CAM5839, (( title ))

Emoji.

Example: 🍃 Chicken Wedge Salad, ✨ Carved mirrors and beautiful paintings converge

@streats at this stage we only have the capability to flag things either as errors or not at all, there is no third "review" option. So we want to flag "definitely bad" alt text, not "possibly could be improved". So any proposed pattern needs to be as close to 99% precision as possible (high quality of matches). Having a high recall (high quantity) isn’t needed because we don’t have the UI to display the nuance of possible issues.
Also keep in mind we want patterns that work across multilingual content, so rules that flag non-alphanumeric characters aren’t viable.

Just checking I understood - are we saying that this would be a good alt text? My understanding is that "Image of" […]

Yes, your understanding is correct. What I’m saying is if alt text starts with "Image of", then we can reasonably expect what follows will be a description of the image. The alt text would clearly be better without the "Image of" prefix, but that’s a minor verbosity issue. The prefix won’t prevent a screen reader user from understanding the content. And I don’t think the presence of such a verbose prefix would constitute a fail of WCAG SC 1.1.1 Non-text content.

Multiple words with no spaces but other common separators like - or _

For underscores this makes sense to me. For -, how would you distinguish between problem cases and legitimate hyphenation? For example "Coca-Cola", or the French word for Rainbow ("Arc-en-Ciel") would make for an excellent alt text. Or place names like Stoke-on-Thames.
Also I believe screen readers have no problem reading hyphenated text without mention of the hyphens, since there are a lot of words like this. For example "Coca-Cola" is read "Coca Cola", not "Coca Hyphen Cola".

Single words (contains no spaces).

I don’t see how this would work as a global rule with the diversity of images we work with in a CMS? "Facebook" seems like perfectly valid alt text for an image of the text "Facebook".
Also keep in mind we need patterns that work across different languages. In some languages there are much longer words that could be fine to use as-is even for longer description. For example in Finnish, "Pyyhkäisyelektronimikroskooppi".

Starts with lowercase.

I think just "iPhone" is a solid example of why this couldn’t work. There’s lots of text out there that’s stylized as lowercase.

All uppercase. While there may be legitimate inclusion of acronyms or initialisms, an entire alt text of uppercase is unlikely to have been written by a human, or if it was it's probably minimally descriptive.

This seems to me like a very common occurrence for logos ("NHS", "FCC", "MIT")

Contains only numbers.

I think this is promising but there are clear examples where numbers-only could be valid so I’m hesitant. WCAG has clear provisions where images of text are allowed: A particular presentation of text is essential to the information being conveyed., and mentions logotypes are valid examples.
So here are examples of things that are referred to with numbers only: 2012 (film), 1664 (beer), 1917 (2019 film).

Starts with a non-alphanumeric character.

This would need refinement for alphabets that don’t use alphanumeric characters. Perhaps if we earmarked specific characters?

Emoji. Even if the alt text is good, […]

I can see why alt text would be better without emoji, but it seems to me like a clear case of "could use improvement" rather than "alt text is bad".

Multiple consecutive non-alphanumeric characters.

What's The Point Of Literature? is just HTML escaping of a ' single quote character as the template rendering logic might not know whether the developer chose to use single or double quotes for their attribute. Browsers have no problem interpreting this as "'" when providing the alt text to a screen reader.

Perhaps those characters aren’t alphanumeric from a technical standpoint?

Gotcha, yes, I suppose it depends what we mean by alphanumeric :) I thought you meant ASCII characters, but yes alphanumeric in Unicode would include accented letters and I assume much more than that. This gets quite thorny so if we did something like this I assume we’d need to review what is feasible in JavaScript specifically (which is where our regex check runs currently).

an allow list for legitimate characters or a denylist for illegitimate ones?

Yes so same for this I think it depends on what is technically feasible. So we’d need to look at available character class escapes specifically, narrowing down on the ones that are unicode-aware. Possibly a unicode character class escape with the correct character classes 🤔.

Noting from today’s accessibility team meeting – for the pass/fail checks, we’re keen to proceed with:

_ – "any underscore in the alt text = error". We noted there would be a few false positives (brands with underscores, images of computer code, images of social media handles or URLs with underscores. Those feel like they’re reasonably uncommon enough, and problematic anyway as images of text, to justify the trade-off.
TBC - single-character alt text (^.$). There are a few characters that seem like they could be appropriate (particularly for icons – 🙂, ”, →). We want to do more research and then hopefully proceed.

I’ve merged #12119 with the inclusion of the underscore. Keeping this open for us to do further research into other patterns, such as single-character alt text. It seems like we could disallow specific unicode or character ranges (for example ^[0-9a-z]$ would probably go a long way).


Update tinkerbell/tink to the latest tag and add tink-controller

Description of changes:
This PR updates the tinkerbell/tink project to the latest commit hash and adds the logic for building tink-controller image.
It also removes all the previous patches under tinkerbell/tink as those are either not needed or being contributed back upstream.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

/lgtm
/approve


Default config should be search in protodot/config.json

There should be a default path list for the config present, such as in config.hson and if not found then protodot/config.json, etc. Specifying it each time does not make sense.

Hello and thank you for your report.

The config file name can be specified using CLI argument, e.g. "-config my.config". If it was not specified, the name "config.json" is used.
The logic of looking for location of the config file is:
Directory where the application is located (concatenated with provided or default config name)
Current Working directory (concatenated with provided or default config name)
If config file name is "config.json", and config file wasn't found using two aforementioned locations - an internal version of configuration settings is used.

Hopefully this provides enough information to get you moving.
If you still experience any issues, repeated or new, please follow the following format what reporting them:

what I wanted: ?
what I did: ?
what I expected: ?
what I got: ?
what I propose: ?


Still getting Method not found in class.

What the problem is:
For example: inside my resource controller, Customer::find($id); It get the method "find" not found warning, If I go to the Costumer Class and extend it to Eloquent that problem goes away, but the methods that I personally created for the class get me the method not found warning in the IDE.
I don't have a problem with "new Customer()" the problem is when I Involve Customer::find($id).
I have also run: "php artisan clear-compiled", "php artisan ide-helper:generate", "php artisan optimize" and php artisan ide-helper:models.
Any help please?
Thanks!

Just in case:
PHPStorm 10.2
Laravel 5.1.26

I'm having the same issue in Intellij IDEA.
I think this might be related to this issue here – https://youtrack.jetbrains.com/issue/WI-28394. If it is, it's a massive pain, as it's killing productivity on a number of my projects.
I'd suggest heading to the issue above and voting on it.

The dev is not interested to implement support for those methods unless you submit a PR yourself.

@raysn0w The reason why PHPStorm thinks the method ::find does not exist is because they are redirected to a query builder instance:
    /**
     * Handle dynamic method calls into the model.
     *
     * @param  string  $method
     * @param  array  $parameters
     * @return mixed
     */
    public function __call($method, $parameters)
    {
        if (in_array($method, ['increment', 'decrement'])) {
            return call_user_func_array([$this, $method], $parameters);
        }

        $query = $this->newQuery();

        return call_user_func_array([$query, $method], $parameters);
    }

    /**
     * Handle dynamic static method calls into the method.
     *
     * @param  string  $method
     * @param  array  $parameters
     * @return mixed
     */
    public static function __callStatic($method, $parameters)
    {
        $instance = new static;

        return call_user_func_array([$instance, $method], $parameters);
    }

Thus, PHPStorm can't know the method exists... Does that answer your question? If so, close this issue :wink:

I'm getting a similar issue.  I don't think this is about namespaces as suggested earlier.
I think this is because PHPStorm can't understand that findOrFail, and similar functions, returns an instance of a particular extension of a model, not an instance of Model or Eloquent.
Extending Eloquent instead of Model makes findOrFail complete fine, but the return of that function isn't know to the IDE to be an instance of whatever Model it found.
For example:
$some_model = Some_Model::findOrFail($id); // this works fine
$some_model->some_relationship();  // methods on model won't autocomplete
The IDE thinks it's an instance of either a collection or a Model, not an instance of Some_Model, so the IDE won't know about its methods or properties unless I type hint it by passing the object to an intermediate function.

@jtwiegand I got also, u know how to fix?

@barryvdh this are basic things all got fixed and working in the current era, vote for closing :}


Regression crash?: TypeError: 'NoneType' object is not subscriptable

After this commit: https://github.com/ml-explore/mlx-examples/commit/1003a8b2dd59a22255a6a6c9a20f9d41f9812fb5#r146019927
I have tried other Llama 3.1 models and they fail in the exact same way. Is this a regression from PR #956?
~ via 🐍 v3.12.4 (mlx-0-17-2) took 6s
❯ mlx_lm.generate  --temp 0.7  --model "mlx-community/Meta-Llama-3.1-8B-bf16"  --prompt "Hello I am a Sunny I know Ruby on Rails, this is an example of a model class:

    ```rb"
Fetching 9 files: 100%|████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████| 9/9 [00:00<00:00, 111353.20it/s]
Traceback (most recent call last):
  File "/Users/gaston/.pyenv/versions/mlx-0-17-2/bin/mlx_lm.generate", line 8, in <module>
    sys.exit(main())
             ^^^^^^
  File "/Users/gaston/.pyenv/versions/3.12.4/envs/mlx-0-17-2/lib/python3.12/site-packages/mlx_lm/generate.py", line 175, in main
    tokenizer.chat_template = metadata["chat_template"]
                              ~~~~~~~~^^^^^^^^^^^^^^^^^
TypeError: 'NoneType' object is not subscriptable
(mlx-0-17-2)

❯ pip list  | grep mlx
mlx                     0.17.2
mlx-lm                  0.18.0
(mlx-0-17-2)

Thank you for the amazing work!

Sorry about that, looks like a bug for models that don't have a chat template. I'll send a fix shortly.

cool, thank you @awni

how to solve this issue, still not fixed

I just uploaded 0.18.1 which fixes this. You can do pip install -U mlx-lm and it should work.
Closing for now but feel free to comment if you are still having issues.

Thanks it worked 👍
I just need to remove and then reinstall mlx-lm
pip uninstall mlx-lm
pip install -U mlx-lm

Fixed in PR #965 🚀 ty


add new a action & modify terms

add new a action & modify terms

@vmanoharas please help review and merge this request

Hi @vmanoharas  i see that my PR still not merged, anything I need do from my side?

Hello @sear-lin-avepoint,
Please accept my apology for not merging this PR.  I will merge it now.


Eliminate use of glog in test/e2e/util.go, convert functions to return errors

We've had a lot of complaints about the e2e test output, and one of the issues is the mixed output formats. Now that we've embraced a framework, let's actually use its output. This also shifts several functions to percolate errors back to tests, which seems vaguely more appropriate for a library. (Though I'm happy to just shift these all to "OrFail" now that we're in Gingko. Really I could go either way.)
(Note that some tests still log using glog.)
@filbranden @rrati @satnam6502

I'm still testing this - don't merge yet. Just wanted to get it out for discussion.

Okay, this looks fine on my end.


Cannot Flash Arlec Smart Bulb

Hi All,
I have flashed devices successfully with the Tasmota firmware for ESP8266 devices that I have. However, I am trying to flash this device now with no luck.
Here are details from log files:
smarthack-psk.log
_new client on port 443 from <IP_ADDRESS>:32338
ID: 0242416f68626d6436614739314946523155a5777e28d7dd773368a10d1f54ec4180b7ce247f274bc2703daaf57ad76ab4
PSK: d72a99042f58345901c799d8440316079e9272f2bc3025c632f3c97700ce8282
could not establish sslpsk socket: [SSL: DECRYPTION_FAILED_OR_BAD_RECORD_MAC] decryption failed or bad record mac (_ssl.c:852)
new client on port 443 from <IP_ADDRESS>:40474
could not establish sslpsk socket: [SSL: NO_SHARED_CIPHER] no shared cipher (_ssl.c:852)
don't panic this is probably just your phone!
new client on port 443 from <IP_ADDRESS>:40480
could not establish sslpsk socket: [SSL: NO_SHARED_CIPHER] no shared cipher (_ssl.c:852)
don't panic this is probably just your phone!
new client on port 443 from <IP_ADDRESS>:40484
could not establish sslpsk socket: [SSL: NO_SHARED_CIPHER] no shared cipher (_ssl.c:852)
don't panic this is probably just your phone!
new client on port 443 from <IP_ADDRESS>:40486
could not establish sslpsk socket: [SSL: NO_SHARED_CIPHER] no shared cipher (_ssl.c:852)
don't panic this is probably just your phone!
new client on port 443 from <IP_ADDRESS>:41555
ID: 0242416f68626d6436614739314946523155a5777e28d7dd773368a10d1f54ec4180b7ce247f274bc2703daaf57ad76ab4
PSK: d72a99042f58345901c799d8440316079e9272f2bc3025c632f3c97700ce8282
could not establish sslpsk socket: [SSL: DECRYPTION_FAILED_OR_BAD_RECORD_MAC] decryption failed or bad record mac (_ssl.c:852)
new client on port 443 from <IP_ADDRESS>:40494
could not establish sslpsk socket: [SSL: NO_SHARED_CIPHER] no shared cipher (_ssl.c:852)
don't panic this is probably just your phone!
new client on port 443 from <IP_ADDRESS>:18461
ID: 0242416f68626d6436614739314946523155a5777e28d7dd773368a10d1f54ec4180b7ce247f274bc2703daaf57ad76ab4
PSK: d72a99042f58345901c799d8440316079e9272f2bc3025c632f3c97700ce8282
could not establish sslpsk socket: [SSL: DECRYPTION_FAILED_OR_BAD_RECORD_MAC] decryption failed or bad record mac (_ssl.c:852)
new client on port 443 from <IP_ADDRESS>:13712
ID: 0242416f68626d6436614739314946523155a5777e28d7dd773368a10d1f54ec4180b7ce247f274bc2703daaf57ad76ab4
PSK: d72a99042f58345901c799d8440316079e9272f2bc3025c632f3c97700ce8282
could not establish sslpsk socket: [SSL: DECRYPTION_FAILED_OR_BAD_RECORD_MAC] decryption failed or bad record mac (_ssl.c:852)
new client on port 443 from <IP_ADDRESS>:40919
ID: 0242416f68626d6436614739314946523155a5777e28d7dd773368a10d1f54ec4180b7ce247f274bc2703daaf57ad76ab4
PSK: d72a99042f58345901c799d8440316079e9272f2bc3025c632f3c97700ce8282
could not establish sslpsk socket: [SSL: DECRYPTION_FAILED_OR_BAD_RECORD_MAC] decryption failed or bad record mac (ssl.c:852)
new client on port 443 from <IP_ADDRESS>:3893
ID: 0242416f68626d6436614739314946523155a5777e28d7dd773368a10d1f54ec4180b7ce247f274bc2703daaf57ad76ab4
PSK: d72a99042f58345901c799d8440316079e9272f2bc3025c632f3c97700ce8282
could not establish sslpsk socket: [SSL: DECRYPTION_FAILED_OR_BAD_RECORD_MAC] decryption failed or bad record mac (ssl.c:852)
smarthack-wifi.log
Attempting to stop wpa_supplicant
Stopping NetworkManager...
Configuring AP interface...
RTNETLINK answers: File exists
Starting DNSMASQ server...
Starting AP on wlx0013ef6a83ef...
Configuration file: /dev/stdin
Using interface wlx0013ef6a83ef with hwaddr 00:13:ef:6a:83:ef and ssid "vtrust-flash"
wlx0013ef6a83ef: interface state UNINITIALIZED->ENABLED
wlx0013ef6a83ef: AP-ENABLED
wlx0013ef6a83ef: AP-STA-CONNECTED 7a:36:d3:59:d2:80
wlx0013ef6a83ef: AP-STA-CONNECTED f4:cf:a2:55:c6:29
wlx0013ef6a83ef: AP-STA-CONNECTED f4:cf:a2:55:c6:29
wlx0013ef6a83ef: interface state ENABLED->DISABLED
wlx0013ef6a83ef: AP-STA-DISCONNECTED f4:cf:a2:55:c6:29
wlx0013ef6a83ef: AP-STA-DISCONNECTED 7a:36:d3:59:d2:80
wlx0013ef6a83ef: AP-DISABLED
nl80211: deinit ifname=wlx0013ef6a83ef disabled_11b_rates=0
AP closed
Here f4 is the bulb, 7a is my phone.
smarthack-udp.log
Listening for Tuya broadcast on UDP 6666
Listening for encrypted Tuya broadcast on UDP 6667
smarthack-mqtt.log
1594905688: mosquitto version 1.4.15 (build date Tue, 18 Jun 2019 11:42:22 -0300) starting
1594905688: Using default config.
1594905688: Opening ipv4 listen socket on port 1883.
1594905688: Opening ipv6 listen socket on port 1883.
^C1594905980: mosquitto version 1.4.15 terminating
I have seen others report this issue, but cannot find a solution that has been posted on those issue reports. Can someone please help? I am fairly new to this. Please let me know if there is any further information that I need to provide that might help with troubleshooting. Thanks in advance.

Currently not possible to flash OTA. See #483


dev -> master

This change is

Reviewed 5 of 5 files at r1.
Review status: all files reviewed at latest revision, all discussions resolved.

Comments from Reviewable

Reviewed 2 of 2 files at r2.
Review status: all files reviewed at latest revision, all discussions resolved.

Comments from Reviewable


Combing (Box-)FDDP and (Box-)DDP solvers

In this issue, I propose a code simplification for easy maintenance.
I want to draw the attention of @proyan and @nmansard to this issue.
Currently, we have

the unconstrained solvers: DDP and FDDP, and
the control-bound constrained solvers: Box-DDP and Box-FDDP

In both cases, there is a single different: the feasibility-driven routing for forward pass.
This routine can be easy switch off, without affecting runtime performance, by a configuration parameter to the solver.
Concretely speaking, I propose the following action points:

Deprecate DDP and Box-DDP solvers
Include a boolean (the configuration parameter) in the FDDP/Box-FDDP constructors to switch from feasibility mode to classical mode.
Use as default value of this parameter the feasibility mode, which avoids construction deprecation in FDDP/Box-FDDP solvers

Removing DDP as a solver from our repertoire makes sense. FDDP with feasible initial guess is already DDP.
However, because of historical reasons, I think we need to always keep the DDP as an explicit solver in our list, and inherit from that. DDP is an old and accepted algorithm, and it is comfortable for a new user to start with something familiar

However, because of historical reasons, I think we need to always keep the DDP as an explicit solver in our list, and inherit from that. DDP is an old and accepted algorithm, and it is comfortable for a new user to start with something familiar

What I propose is to introduce a flag that makes our FDDP solver behaves as our DDP solver even if the initial guess is infeasible. Something like this
fddp = crocoddyl.SolverFDDP(problem)
ddp = crocoddyl.SolverFDDP(problem, feasibility=False)

(same for box solvers)
I agree that this is not as explicit as writing crocoddyl.SolverDDP, however, the desired behavior is explicitly defined by the user.
Of course, with a proper deprecation protocol, our users will be aware of this approach.
How do you think about this approach?

To be honnest, I don't think that calling the solver FDDP will be helpful. Keep DDP naming for universal convention, just deprecate FDDP.

To be honnest, I don't think that calling the solver FDDP will be helpful. Keep DDP naming for universal convention, just deprecate FDDP.

I understand your point, but I would prefer to turn on the feasibility as default since it is better option.
If this is the case, then I think DDP should be deprecated.
On the other hand, we have a couple of papers referring to FDDP and Box-FDDP (and there are more citations out there)
Indeed, it is also important for us to keep the FDDP naming, because it is our contribution.


Eliminate the use of the cv namespace

Users especially those new to C++ often face confusion and difficulties in understanding the proper usage of OpenCV classes due to the common practice of using the cv namespace. To improve clarity and encourage best practices, I think it is suitable to eliminate the use of the cv namespace in our examples.
Possible solution to this problem could be:

Encouraging Explicit Namespace Usage: Update documentation and examples to explicitly use the cv:: prefix for OpenCV classes (e.g., cv::Mat, cv::VideoCapture) instead of relying on the cv namespace. This will also allow users to have a better understanding of the working of C++ as using namespaces abstracts some stuff.

I will start working on this issue and will do the PR by midnight.

@advait-0, there are already some existing PRs that should be merged before I do the namespace change else the test cases would fail because of merge conflicts.


Unable to write into user settings

Visual Studio Code Version : [1.17.0]
Code Settings Sync Version : [ 2.8.3]
Operating System : [Win 10]
Occurs On: [Everything ]
Proxy Enabled: [No ]
GIst Id: [ N/A]
Hello,
I am attempting to use this after coming back to VSCode, I had the plug installed a while ago and it was working, since then the secret has been removed and I have generated a new one.
Any command unser >sync will not work producing the following messages:

Here is what is in the console:
[Extension Host] Error: Unable to write into user settings. Please open **User Settings** file to correct errors/warnings in it and try again.
    at new t (file:///C:/Program Files/Microsoft VS Code/resources/app/out/vs/workbench/workbench.main.js:28:2275443)
    at e.wrapError (file:///C:/Program Files/Microsoft VS Code/resources/app/out/vs/workbench/workbench.main.js:28:3034499)
    at file:///C:/Program Files/Microsoft VS Code/resources/app/out/vs/workbench/workbench.main.js:28:3038333
    at Object.g [as _notify] (file:///C:/Program Files/Microsoft VS Code/resources/app/out/vs/workbench/workbench.main.js:28:53561)
    at Object.enter (file:///C:/Program Files/Microsoft VS Code/resources/app/out/vs/workbench/workbench.main.js:28:57126)
    at n.Class.derive._creator._run (file:///C:/Program Files/Microsoft VS Code/resources/app/out/vs/workbench/workbench.main.js:28:58954)
    at n.Class.derive._creator._completed (file:///C:/Program Files/Microsoft VS Code/resources/app/out/vs/workbench/workbench.main.js:28:58395)
    at n.Class.derive._creator.then (file:///C:/Program Files/Microsoft VS Code/resources/app/out/vs/workbench/workbench.main.js:28:60387)
    at Object.enter (file:///C:/Program Files/Microsoft VS Code/resources/app/out/vs/workbench/workbench.main.js:28:56205)
    at n.Class.derive._creator._run (file:///C:/Program Files/Microsoft VS Code/resources/app/out/vs/workbench/workbench.main.js:28:58954)
    at n.Class.derive._creator._setCompleteValue (file:///C:/Program Files/Microsoft VS Code/resources/app/out/vs/workbench/workbench.main.js:28:58648)

Sync : Unable to clear settings. Error Logged on console. Please open an issue.
e.doShow @ messageService.ts:125
e.show @ messageService.ts:104
e.resume @ messageService.ts:63
(anonymous) @ workbench.ts:988
e.invoke @ callbackList.ts:36
e.fire @ event.ts:123
(anonymous) @ quickOpenController.ts:534
messageService.ts:125 Sync : Error Logged In Console (Help menu > Toggle Developer Tools).

Even when attempting to reset it will not work. I have tried uninstalling and reinstalling the extension but it seems to do the same thing. Is there somewhere on disk that the settings are saved so I can just start again?

what is your gist ID ? so i can reproduce at me end.
Also you can reset the extension settings from command and then check the valid Json settings.json and then try downloading the gist

Looks like my settings.json was invalid!

This is not a huge issue but this could probably use a better error message.

@lferrao PR is welcome for this, i will be glad to help someone for this.

I just ran into the same issue: My settings.json contains comments, which is totally fine for VS Code, but will break other JSON parsing methods.


CAMEL-11804:Add tests that checks DESTINATION_OVERRIDE_URL

Please review PR for CAMEL-11804:Add tests that checks DESTINATION_OVERRIDE_URL

Thanks for the PR it has been merged. Do you mind closing this?


Cannot reproduce your performance

I use
export BATCH_SIZE=8;
./run.sh 5 \
	-default \
	"--scannet_path /data1/antao/Documents/Datasets/ScanNet_processed/"

to train my model, but only get 67.088 in validation set. Can you tell me your commend to run the script?

add --dataset ScannetSparseVoxelization2cmDataset

thx !!!

And what your batch size do you use? After I add --dataset ScannetSparseVoxelization2cmDataset, I find batch size 2 out of memory in my 2080ti.


Code is old??

I don't understand ..Google is pushing the Android Tv and there is no update code to help developers learn..
Why is that??There is open PR and nobody is taking care of this anymore?

We are currently working hard on bringing Compose, a modern, declarative UI framework, to TV. Alpha releases can be found in the AndroidX release notes.
In the meantime, I'd be eager to hear if there are specific PRs that you're direly missing or what could be addressed in the interim as we focus our efforts on TV Compose.

compose is great, but not everyone is there yet..thx
On Thu, Dec 22, 2022, 5:45 p.m. Paul Lammertsma @.***>
wrote:

We are currently working hard on bringing Compose, a modern, declarative
UI framework, to TV. Alpha releases can be found in the AndroidX release
notes https://developer.android.com/jetpack/androidx/releases/tv.
In the meantime, I'd be eager to hear if there are specific PRs that
you're direly missing or what could be addressed in the interim as we focus
our efforts on TV Compose.
—
Reply to this email directly, view it on GitHub
https://github.com/googlesamples/androidtv-sample-inputs/issues/62#issuecomment-1363413577,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/ABOFGYQKD4KJZYCE37SV3FDWOTKXLANCNFSM6AAAAAATHA7OVY
.
You are receiving this because you authored the thread.Message ID:
@.***>

Any news on this?
Also,is there a way to pull the code from the EPG of Leanback?There is many out there but the leanback is more stable..


bug: arrows don't work for cmdline history navigation

I use regexen extensively in vim / neovim. Often I will mess up a regex somehow and need to correct it, and I do that by editing it from my search history (i.e. in vim, hitting "/" then pressing up arrow until I reach the regex I want to edit). How do I do this in vscode-vim? I've been having to spawn vim in a terminal, do the regex stuff, and then exit.

I have the same question and would extend it to command history too.

Yeah, for some reason the arrows don't work in command mode anymore. I tried installing some very old versions of this plugin and still could not get it to work, so I assume an update to VSCode broke it, not this plugin. Trying to manually map the arrow keys don't work either, however, putting this in your keybindings is a mediocre fix:
    {
        "command": "vscode-neovim.history-up-cmdline",
        "key": "ctrl-p",
        "when": "neovim.mode == cmdline_normal"
    },
    {
        "command": "vscode-neovim.history-down-cmdline",
        "key": "ctrl-n",
        "when": "neovim.mode == cmdline_normal"
    },

I remember this working for me and I don't think it was too long ago. It no longer does, but that workaround did the trick for now. Thanks @theol0403!

That worked for me too. Thanks, @theol0403!
On Thu, Jul 16, 2020 at 11:23 AM Peter Sieg<EMAIL_ADDRESS>wrote:

I remember this working for me and I don't think it was too long ago. It
no longer does, but that workaround did the trick for now. Thanks
@theol0403
https://urldefense.proofpoint.com/v2/url?u=https-3A__github.com_theol0403&d=DwMCaQ&c=jGUuvAdBXp_VqQ6t0yah2g&r=TTXL98RIPQNjLdDSgeT8-yL45AVQu-9EyYWqGxjCNjqPZing27cmWboo1qWURfVf&m=UVjUOdOEUhRhhrGcukXuUiWT_meoxt4WnOvC7KitCS4&s=9UO7EHT6dq5MQWapIuZMf9xu517foqZsiZhrr3uwgt0&e=
!
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://urldefense.proofpoint.com/v2/url?u=https-3A__github.com_asvetliakov_vscode-2Dneovim_issues_288-23issuecomment-2D659521844&d=DwMCaQ&c=jGUuvAdBXp_VqQ6t0yah2g&r=TTXL98RIPQNjLdDSgeT8-yL45AVQu-9EyYWqGxjCNjqPZing27cmWboo1qWURfVf&m=UVjUOdOEUhRhhrGcukXuUiWT_meoxt4WnOvC7KitCS4&s=ZCBH8zTzsXsYzVyOvszDbTj9h-otvUxOioshdwY1I2w&e=,
or unsubscribe
https://urldefense.proofpoint.com/v2/url?u=https-3A__github.com_notifications_unsubscribe-2Dauth_AMOAKPVQC4GSJVETCLQIXIDR34SP7ANCNFSM4OHADK6Q&d=DwMCaQ&c=jGUuvAdBXp_VqQ6t0yah2g&r=TTXL98RIPQNjLdDSgeT8-yL45AVQu-9EyYWqGxjCNjqPZing27cmWboo1qWURfVf&m=UVjUOdOEUhRhhrGcukXuUiWT_meoxt4WnOvC7KitCS4&s=DuOw844GJMIcVAroOAAeXJ0VGZ9RZdguvv_ea-WN2E0&e=
.

It works also for me!. Thanks to @theol0403

@theol0403, thanks!
@asvetliakov, maybe made this shortcuts be default? In Neovim <C-p> and <C-n> works for search too.

If you could get arrows to work will be ideal. Muscle memory is hard to change. I have seen other vim integrations that even include a drop-down with the history, so moving up/down is easier.

VSCode started to disallow to remap <up>/<down> in quick pick. Blame vscode devs ! 👿  👿  👿

@asvetliakov  Any thoughts on moving the command line to the VSCode status bar (the bottom bar in the ide)?
The VSCodeVim extension exposes the vim commandline in that bar - it shows what you're typing and allows you to navigate through history with arrow keys due to it. Could resolve this problem

@uladkasach It would be worth considering, and also solve a few other problems regarding quickpick's limitations (and support more bindings). However, the largest drawback is showing completions - any idea how that could be done?

@theol0403 VSCodeVim implemented this in https://github.com/VSCodeVim/Vim/pull/2758/files. Some asked for the ability to move it back (https://github.com/VSCodeVim/Vim/issues/2773,  https://github.com/VSCodeVim/Vim/issues/3602) but I'd say : opening in quick open is one of the biggest cons transitioning from VSCodeVim to vscode-neovim so far.
Though, I think a really good approach to multiple buffers (#505) might lead to the most optimal, fully-featured command buffer. Maybe something leveraging horizontal splits. View: Toggle Split Editor In Group and View: Toggle Layout of Split Editor in Group can be used to make "borderless" splits of the same file, and https://github.com/microsoft/vscode/issues/36700#issuecomment-953737831 implies there might be a way to do that using some custom view.

Still not fixed, waiting for
https://github.com/microsoft/vscode/pull/196899

Fixed by https://github.com/vscode-neovim/vscode-neovim/pull/2001

FYI, now that VSCode 1.90 is released, this now works :tada:


support a sentence as text_prompt for Ground and Tracking?

For custom video input, does the supported text prompt have to be a word (i.e. a word representing a certain category), can it be a sentence?

Sure, I think it can be achieved by both Grounding DINO and Florence-2, we will consider support it by Florence-2 in the future release. But we only ground phrases in one specific frame and track the object in the following frame, if you need more complex applications, you may modify it by yourself.


Adds Deno in memory

I'm still figuring out the persisted version

Hanging on the db creation, although I can see it's definitely creating the files:

Might need to revisit this to get Deno storage working. Happy for you to merge this if you don't want to leave PRs hanging (or you can close if you don't want a partial doc)

I've narrowed down the issue to here: https://github.com/electric-sql/pglite/blob/9a508ac71f03f0512bc4d69b1229d13415fa1733/packages/pglite/src/index.ts#L188-L193
This code adds event listeners for waiting and result, but their handlers never get called in Deno. Since the handlers don't get called, the promise doesn't resolve.
These functions aren't getting called by wasm at all. console never logs:

@samwillis Would you mind taking a look at my discovery? :point_up: I came very close to figuring it out but got stuck after realizing the event handlers weren't firing. Any ideas what could be causing that?

Absolutely, sorry I missed this 😬
Based on your description of await_query not being called, that suggests that Postgres hasn't fully initialised. It never reaches the point in its main loop where it reads user input.
Which file system were you trying, the in memory or the persisted one?

It works in-memory. I was trying to figure out how to get the persisted one working in Deno. :thinking:

There seems to be issues with running the Emscripten nodefs under Deno, it's mentioned here: https://github.com/emscripten-core/emscripten/issues/13190
We are still on an older version of Emscripten, it maybe that it's fixed in a newer version.

If we can pinpoint the issue we can open a bug in Deno. They're aiming for 100% Node compatibility, so Emscripten should not need to add any special support.


Deploy main net

Just for fun, could you please:

Take the example at https://github.com/lknix/ethereum-erc721/blob/4cc409a6ddfc1183bbe0fdd82a8dfff07222f24e/README.md
Remove onlyOwner
Deploy to main net and ropsten
Publish code on etherscan.io

Then you can add to the README:

We deployed a contract you can play with RIGHT NOW. No need to install software. In this test version of the contract, anybody can mint or burn tokens, so don't use it for anything important.
Mainnet address: xxxxx
Ropsten address: xxxxx

https://github.com/0xcert/ethereum-erc721/pull/44


Add tests and enable per-scenario containers

Container support was previously only for per-feature containers. This PR adds the ability to set up containers at a per-scenario scope instead (so each gets its own container, instead of a single container being shared across all the scenarios in a feature).
Adding support for both per-feature and per-scenario containers made the old @setupContainer tag ambiguous, so I've introduced new @perScenarioContainer and @perFeatureContainer tags. The old tag still works but will now produce a warning at test time.
There were no tests even for the existing feature-scope container support, so I added tests for those as well as the new feature.
Resolves #24

Would it be worth updating the readme to explain how this works?

Earlier, @jesspanni asked:

Would it be worth updating the readme to explain how this works?

Yes it would. I've now updated this PR by filling in the README.md file. It wasn't describing any of the capabilities before. Since some of the others relate directly or indirectly to the feature being added in this PR I decided just to fill it in completely.


fix(confd): Fix user registration disabling

Fixes #529

Current coverage is 83.16%

Merging #531 into master will not affect coverage as of fda14e9

@@            master    #531   diff @@
======================================
  Files           32      32
  Stmts         1919    1919
  Branches       271     271
  Methods          0       0
======================================
  Hit           1596    1596
  Partial         60      60
  Missed         263     263

Review entire Coverage Diff as of fda14e9

Powered by Codecov. Updated on successful CI builds.


[Power Launcher] Integrate web search experience powered by Bing apis

Summary of the Pull Request
https://github.com/microsoft/PowerToys/issues/5119
PR Checklist

[ ] Applies to #xxx
[ ] CLA signed. If not, go over here and sign the CLA
[ ] Tests added/passed
[ ] Requires documentation to be updated
[ ] I've discussed this with core contributors already. If not checked, I'm ready to accept this work might be rejected in favor of a different grand plan. Issue number where discussion took place: #xxx

Info on Pull Request
A new plugin Microsoft.Plugin.WebSearch
Validation Steps Performed
type 'web xxx' or 'map 1 microsoft way' or 'dict apple' or 'image titanic'.

Thanks for the PR @peterpy8 .
For all other plugin images we use 48x48 dimensions, with a padding of 6px for top/bottom.
I have updated your assets to reflect this (and updated the Bing logo since it was using an older version of that) you can easily include:

Since Bing Maps doesn't have an official logo, I'd just re-use the Bing one. Do you agree?

Achtung: Bing bekommt wohl demnächst ein neues Logo.

Thanks for the PR @peterpy8 .
For all other plugin images we use 48x48 dimensions, with a padding of 6px for top/bottom.
I have updated your assets to reflect this (and updated the Bing logo since it was using an older version of that) you can easily include:

Since Bing Maps doesn't have an official logo, I'd just re-use the Bing one. Do you agree?

Thanks for pointing this out. I will update the logo in my next iteration.

@peterpy8 is this just a modified version of https://github.com/peterpy8/Wox/tree/master/Plugins/Wox.Plugin.WebSearch?

@peterpy8 is this just a modified version of https://github.com/peterpy8/Wox/tree/master/Plugins/Wox.Plugin.WebSearch?
https://github.com/Wox-launcher/Wox/tree/master/Plugins/Wox.Plugin.WebSearch

yes.

@peterpy8
Can please you provide/add an option to disable web search for people who don't want to search the internet.

I think this plugin, we need to start thinking about enabling / disabling plugins holistically.
Also this plug in needs to not break everything if the user does not have internet access.

I think this plugin, we need to start thinking about enabling / disabling plugins holistically.

@crutkas
See #5273 for a concept/mock up about plugin management. 😃

I think this plugin, we need to start thinking about enabling / disabling plugins holistically.

@crutkas
See #5273 for a concept/mock up about plugin management. 😃

I agree with crutkas's point that if no internet connectivity, the plugin should be disabled. Could you suggest a proper way to detect internet connectivity?

Don't get me wrong, but bing is the primary reason for many to not use windows search who just want to search for files/programs on their computer. So instead of using so many generic words like 'web', 'map' or 'image' for bing search, which can be typed unintentionally by many ( like who just wanted to search for 'maps' app), you could have this plugin prefixed (in addition of option to disable) by some a symbol (like ~ might be good option).

Our goal with PowerToys Run was to build a quick way people can launch apps and files.  In doing so, our interface is a plug-in based one to enable all the core scenarios we needed to meet this need. When the plugin system is ready for 3rd party plugins, this will anyone to build against the APIs for their feature.  This work includes a robust settings UI that would allow someone to not load a plugin as well as set an action key.
The first main step of that is https://github.com/microsoft/PowerToys/issues/5273.
As of now, yes we understand some would want to be able to do a search from their instance of PT Run but others wouldn’t. As this isn’t a core functionality goal of PT Run currently, we’re going to decline this PR as we do need additional work to enable this for everyone to have a great experience.


Alt-selection doesnt work

VSCode Version: 1.12.1 (f6868fce3eeb16663840eb82123369dec6077a9b)
OS Version: Windows 8

Steps to Reproduce:

Press Alt
Select text

Result:
Normal selection
Expected
Similar to Alt+Shift selection in VSCode, but should work as a normal selection: use mousedown position as first corner of rectangle and current position as second corner.

By default, alt+click adds multiple cursors

Duplicate of https://github.com/Microsoft/vscode/issues/5402?

@jnm2 Yes. Couldn't find that issue.


iOS and Android target?

Is there any idea for iOS and Android? Is it not in consideration or something long story to implement?

Well, we want to support WebRTC on those platforms in the future.
Android might be easier mainly because I don't have access to Apple devices (which is also the reason why there is not yet an official OSX build), but they both requires some work.
Overall, in the long run, I'd like to try and include rawrtc in Godot as a third party library which is much more lightweight only supports data channels (and will compile natively on all platform without the need for this GDNative plugin).

Awesome news for me if don't required to build from GDNative for official API, or even chromium branch.

Hello, I was testing my game for the first time in Android and according to Godot's debugger there is no implementation defined yet.
Are you planning to add it soon? @Faless

Same question here @Faless  ! And by the way, thank you so mush for your work. I'd be very glad to help, but I honestly don't even know where to start.

Are you planning to add it soon?

Not really, it's something we'd like to have, but it's not in the top priorities right now.
Of course, if someone manages to build the android/iOS version correctly and posts the instructions I'll gladly add it to the releases.
The long term plan, as mentioned above, is to switch to a different, maintainable library, currently, both rawrtc and the amazon kinesis webrtc sdk are being evaluated.

Hey everyone, I've created #24 adding build support for Android.
I followed the README.md build guide, using the following WebRTC pre-compiled binaries for Android arm and arm64.
To build for Android, I've added platform=android.
ANDROID_NDK_ROOT env variable needs to be defined.
By default, it builds for armv7 with Api 18.
To build for arm64v8 (or x86, x86_64), use android_arch=arm64v8.
64 bits requires at least Api level 21.
If needed, you can change it with android_api_level=XX.
To be honest, I mostly used the godot-cpp/SConstruct as reference. So may not be the best approach.
I've used a Linux (Ubuntu) host platform and built libraries for Android armv7 and arm64v8.
I have not tested building from Windows or Mac. I also have not tested building for Android x86 and x86_64.
I've tested the Android library with Godot webrtc_signaling example, It worked correctly locally on a Android device.
It also worked correctly between the Android device and a local Linux and HTML5 instance of the game.
Hope it helps.

Both Android and iOS targets have now been added to the 0.5 release. Closing as fixed.