My account > Public profile should be the public profile

It should go to /user/username – not to the dashboard at /member/me.
And maybe the latter is entirely unnecessary. There could be an "edit profile" a user sees on the profile page itself, if a user is viewing their own profile.

Do you mean /member/username?

@troublemagnet thanks for the PR! I don't think this will close the issue – I'd like to see the edit profile button added, and potentially clean up removing the old /member/me if that's obsolete. (Don't worry about having to do this too – I can do it sometime soon.)
Our community pages in Outreachy are confusing, I think we've miscommunicated to potential applicants: our main site isn't the code we intend to invite folks to contribute to. Even though it's open source, it's a very complex starting point! Please check out ideas here if you'd like to do more stuff: http://openhumansfoundation.org/outreachy/ideas/
That said: all your comments on issues and PR are spot on! But not everyone has your skill. ;-) I'm going to remove links to this repository in Outreachy, because I feel bad about creating confusion.

I'm a bit confused by that comment @madprime. It seems to me that https://www.openhumans.org/member/me/ already leads to the same public profile that https://www.openhumans.org/member/gedankenstuecke/ would yield, but in addition to the public profile it has the edit profile button on top and the left-side-menu for looking at all my data sources/projects?
Would you want to move the stuff that's right now member/me to member/username for cases where request.user.username == /member/username?

Part of it. Yes, I want an "Edit profile" button to show up on the /member/username for the case (site user is the user in the profile). I also want completion of member/me/edit/ should also return to /member/username.
And as a result, I think the /member/me view could be removed entirely. I also think the side panel could disappear entirely from all other /member/me pages – now that there's a dropdown.
Does that make sense?

The first part makes sense, got it now. I think I would keep the side menu around though, because that makes using your own profile easier. :)

Did some back-and-forth with @gedankenstuecke in Slack. We concluded that the side-panel on "own profile" is more confusing – we looked at how Twitter manages this. Let's leave the other views with side panels.
Here's the updated changes that should occur, I think…

In the navbar dropdown, My account → Public Profile should go to member-detail-direct
In the corresponding template, the button for Contact member should instead be Edit profile (leading to my-member-profile-edit
The view for my-member-profile-edit should return the user to member-detail-direct
The side-panel for other "my-member" views should remove the "Public Profile" button and link to my-member-dashboard
I'd like to add a separator in the dropdown separating "Public profile" from the stuff below, since they've become substantially different types of view. The section with three links below (Projects joined / My data / Account settings) might also have a dropdown header "Account management" – but not sure how this will look.

@troublemagnet Thanks so much for trying to address this in #730! You're welcome to try to make the updates I've described, but it might be easiest for me to do all this. :)

@madprime Apologies for the inactivity, had mid term submissions at my university. Also about this issue and PR, since you suggest that it'll be the easiest for you to do it, I'll take up some thing else. :smiley:


Added Contact page as contact.html

Well done great job for today, it looks that your instructor taught your very well, I salut him🙏

that is it for today.
Thanks


NGINX Error Log - not found

Hey,
Running this on Win 10 - specifically through WSL using the daemon as a host so it routes back through to the Windows install.
I cant seem to get past docker-compose up due to this error; help? :(
nginx_1          | nginx: [emerg] open() "/var/log/nginx/error.log" failed (2: No such file or directory) nginx_1          | nginx: [emerg] open() "/var/log/nginx/error.log" failed (2: No such file or directory) wapp_nginx_1 exited with code 1

You need to clone the repo using Git for Windows in order to have the permissions set correctly.

@daveross is this still the case? Currently (and propably more in the future) lots of people are hoping to be able to use only WSL when developing in Win 10 and therefore might not have nor want Git for Windows installed. Could there be an easy way to fix this instead of having to use git for windows?

I cloned this repo with git for windows and received the same errors with Nginx. Windows 10 x64 Pro - was hoping to also develop with WSL, but can't seem to get past the nginx issue.

I've been using Varying Vagrant Vagrants instead. Which is great but
doesn't isolate sites
Quinn Battersby
e//<EMAIL_ADDRESS>t//<PHONE_NUMBER>
w// www.qbattersby.com
On Wed., Nov. 7, 2018, 5:39 p.m. Michael Warf<EMAIL_ADDRESS>wrote:

I cloned this repo with git for windows and received the same errors with
Nginx. Windows 10 x64 Pro - was hoping to also develop with WSL, but can't
seem to get past the nginx issue.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/10up/wp-local-docker/issues/96#issuecomment-436804100,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AA3TTEXs2IbLqslGIj-B5ew-7T0AGI3gks5us2EzgaJpZM4T_mC9
.


readonly(["a", "b", "c"])  Collected by dependency

Version
3.0.2
Reproduction link
https://codesandbox.io/s/vigorous-field-e0xxe?file=/src/App.vue
Steps to reproduce
readonly(["a", "b", "c"])  Collected by dependency
What is expected?
["a", "b", "c"] Should not be collected by dependency
What is actually happening?
["a", "b", "c"] Collected by dependency

You misunderstand what readonly does. This is expected behaviour. readonly still allows for values to be collected as dependencies - it only keep you from mutating the source objects through the procxy returned by readonly.
Maybe you are looking for markRaw() or one of the shallow*() APIs.

I'd like to ask why this design is so designed that indexes can't be collected by dependency, but by using lastIndexOf, indexof and includes. Shouldn't readonly behave consistently

Please be more specific and provide an example.

setup() {
const readonlyState = readonly(["a", "b", "c"]);
effect(() => {
debugger;
readonlyState.includes("a");
});
},
so
readonly(["a", "b", "c"]) Collected by dependency
if
setup() {
const readonlyState = readonly(["a", "b", "c"]);
effect(() => {
debugger;
readonlyState[0]
});
},
readonly(["a", "b", "c"]) Should not be collected by dependency
Shouldn't readonly behave consistently

readonlyState.includes("a");     readonly(["a", "b", "c"]) Collected by dependency
readonlyState[0]                      readonly(["a", "b", "c"]) not be collected by dependency
Shouldn't readonly behave consistently

I'm still not sure what you are asking as your code doesn't contain any example of how different behaviour affects your use case.
However:

in the first example, using includes() makes the whole array a dependency, as well as each index, as any index could be "a".
in the second example, you access one specific index, and consequently only access to that specific index is collected as a dep.

I'd like to ask why this design is so designed
readonly(["a", "b", "c"])
I mean, why don't you collect dependencies in both cases, or not

and readonlyState.includes ("a") to be collected dependency, readonlystate [0] will not be collected dependency ， Any thoughts

We only collect the minimal dependencies necessary.

in the first example, "a" could be anywhere in the array, so we have to collect the whole array as a dep.
in the second example,  we only need 1 dep for the first index of the array, because that's all that's ever read from the array.

I'm not sure how to make that clearer without an explanation of why you think we should collect more/something different.

Ah, now I get what you mean. I failed at reproducing it properly first with the snippet your provided.

You may have misunderstood the meaning
In the case of readonly(),
Why? readonlyState.includes ("a") to collect dependencies, readonlystate [0] will not collect dependencies
Not consistent behavior

OK, thank you

So thanks for being adamant here, I was wrong.
readonly on a plain value should of course not track. I usually use it on reactive values only and didn't think about it enough.
So the problem seems to be here:
https://github.com/vuejs/vue-next/blob/0e5a3c47a7398dfd0107fccf9b615772dd01aa74/packages/reactivity/src/baseHandlers.ts#L85-L88
We should check for isReadonly here

Thanks for reporting, tracked it down and sent a PR.
Apologies for my initial stubborness.

Thank you for answering my questions


missing key?

In the cliffs of Fire adventure I cannot find a key to open the locked door on the second level of the tower.
Am I missing something or is something missing?
PS: Yes, I'm escaping isolation by visiting Eamon.

It's in the sarcophagus on level 2. Each level of that tower is pretty self-contained and has everything you need to get to the next level, if you can find it.
I do see that there are no hints for that adventure. I'll have to add some.

Found it. Thanks


Resource file is not being picked up & displayed in MVC View

Hi,
Am trying to understand MVC6 localization using RESX files as given in the two sample projects in github and i noticed that the labels stay in default language (system's language) only and does not change according to the request.
https://github.com/aspnet/Localization/tree/master/samples/LocalizationSample
The above sample has everything happening at the startup itself and only the label's translation is given in the RESX files which is not being picked and only "Hello" is being displayed for any language i select. Can any one tell me what is that am missing here? Also i noticed that the RESX files do not have the designer.cs files after downloading the sample.
https://github.com/aspnet/Mvc/tree/dev/test/WebSites/LocalizationWebSite

I tried browsing the LocPage action after setting the language in my system as french but again ended up with same result as the translation is not visible.

Note: Am using Visual studio 2015 with beta8 tools extensions installed and beta8 official build installed in my machine.

Please close this issue as duplicate of  #115 as this is related to VS tooling and not with ASP.NET localization


use guide

We have created a config . what's next?
Tell please. that needs to be done in the controller.

even i am wondering what to do next

@prostoVladislav
OAuth.getAccessToken(user, options); return a response promise and you can execute a callback.
eg:
var promise  = OAuth.getAccessToken(user);
promise.then(function (result) {
    $rootScope.access_token = result.data.access_token;
})

The really confusing thing is why you need a username and password to retrieve user data... isn't the whole point of oauth moving the necessity to get a username and password to the auth provider?
The documentation should contain an SSCCE... which it doesn't right now.

Basically, after configuration you can use the getAccessToken method on your controller. By sending the username and password, it will store the access_token which will be used in the next request as an Authorization.
@jmwilkinson There are different ways to obtain authorization.
It would be great to have a better documentation and an example, but honestly I don't have time at the moment.
Duplicated by #67.


Unlock before pushing the app to device and wait to check if screen is unlocked

Unlocking before pushing the app to device so that we can fail the job if it failed to unlock before installing.
I also added one second after unlock runs to actually check if the screen is unlocked cause it was failing this check when the case was that the unlock app was running and then coming back to the lock screen for some reason.
With the changes here on the verification of the unlock screen + the changes to send to background the unlock app I was getting no false positives.

Looks good. Can you do two things: (1) squash into a single commit, and (2) update package.json to require appium-unlock be at least 0.0.2 ("appium-unlock": "^0.0.2")?

Done!

Awesome! Once the build finished I'll get it in!

Hmm. That seems like a flake, though those tests don't normally flake. I also can't figure out how to retrigger the build. Can you force repush to rerun the e2e tests?


Add support for exporting metrics from cstor

Is this a BUG REPORT or FEATURE REQUEST?
FEATURE REQUEST

What happened:
maya-exporter does not support exporting metrics from cstor.
What you expected to happen:
maya-exporter should export metrics from the cstor too.
Anything else we need to know?:
Design docs: https://docs.google.com/document/d/129WTzCtHz5bYBDUa8QVJFFwa2YMn2jJhWYnWcJJNPiQ/edit

Duplicate issue, so closing it. ref : #1465


dependencies package has no corresponding BUILD file

Hi, when I tried using the repo I got the following error but am not sure how to solve it since there is a BUILD file present in the directory where dependencies.bzl is located.
(08:24:34) ERROR: Error computing the main repository mapping: Every .bzl file must have a corresponding package, but '@com_github_storypku_bazel_iwyu/
/bazel:dependencies.bzl' does not have one. Please create a BUILD file in the same or any parent directory. Note that this BUILD file does not need to
do anything except exist.

Do you know what might be the reason?
Thanks!

thank you for your answer,
for anyone that may have the same issue then the release: bazel_iwyu 0.19.2 works fine! :)


Ading files and folders

Contact form added to the mob version portofolio project

I attached this screenshot as proof allowing me to do projects this week solo.


Fix #787

Coverage increased (+0.06%) to 40.928% when pulling c8c4be8b5f17809d7c46e47dd4447fab83a4c8d1 on ywk253100:fix_for_#787 into 981a13d7514bfaa14e119af8b7d908faef941cd9 on vmware:dev.

Is it correct? seems a non-admin user can only see the access log he generates, not access logs in the projects he has access.

Coverage increased (+0.08%) to 40.966% when pulling ce5264292412b28f52b8a1dd655b86f0244f4d74 on ywk253100:fix_for_#787 into 42d0f968d3510d495a740c1411cbdd6244744d2a on vmware:dev.

Updated.


Connection Delete Icon when connection is selected

Hello!
I was just curious if it is possible to display the Connection delete icon on node or connection selection rather than onContextmenu?
Thanks!
Mark

View:

https://github.com/jerosoler/Drawflow/issues/390

Thank you!
On Sun, Aug 28, 2022, 6:03 AM Jero Soler @.***> wrote:

View:

#390 https://github.com/jerosoler/Drawflow/issues/390

—
Reply to this email directly, view it on GitHub
https://github.com/jerosoler/Drawflow/issues/506#issuecomment-1229423488,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/ADJ7PVSWJHVHSCAHXHTO37TV3M2QRANCNFSM57YBVGNA
.
You are receiving this because you authored the thread.Message ID:
@.***>


Questions about dataset and devices.

hello! thanks for the great work!
When I tried to run your code on my pc, I cannot run it directly and I have 3 questions about your work.

How do you organize your ' adaptation_list.csv '?
The order of training on Sceneflow, kitti and other datasets.
When you training the models, how many GPUs did you use? And their video memory?

thanks again!

Hi,
Regarding 1 what do you mean exactly? The details on the dataset preparation are reported here: https://github.com/CVLAB-Unibo/Learning2AdaptForStereo#data-preparation. It boils down to having one CSV per stereo sequence with consecutive frames in conseutives lines.
Regarding 2, the order of the datasets is reported on the paper, it should be SceneFlow (without meta learning) then either Kitti, Carla or synthia (with meta learning)
Regarding 3, all the result in the paper were achieved with a single GPU, I'm not exactly sure on the model but something equivalent to a Titan X with 12 Gb of VRAM

Hi,
Regarding 1 what do you mean exactly? The details on the dataset preparation are reported here: https://github.com/CVLAB-Unibo/Learning2AdaptForStereo#data-preparation. It boils down to having one CSV per stereo sequence with consecutive frames in conseutives lines.
Regarding 2, the order of the datasets is reported on the paper, it should be SceneFlow (without meta learning) then either Kitti, Carla or synthia (with meta learning)
Regarding 3, all the result in the paper were achieved with a single GPU, I'm not exactly sure on the model but something equivalent to a Titan X with 12 Gb of VRAM


Implicit Downcasting of Exceptions by operator<<

The operator<< implementation of the Exception type forcefully downcasts all inherited class types when the operator is used. A problematic usecase is in THROW_RECOVERABLE, that is used by the CHECK macro.
Basically all exceptions thrown by CHECK are irrecoverable at the moment. An easy fix would be to replace all THROW_* variants with something like:
#define THROW_RECOVERABLE(msg)                           \
    do                                                   \
    {                                                    \
        std::ostringstream oss;                          \
        oss << "\nERROR: " << FMT_ERROR_LOCATION << msg; \
        throw RecoverableException(oss.str());           \
    } while (0)

Short demonstration, hope I was clear in my description.

Oh, thanks. Good catch!
There used to be an overload for the operator<< for each derived Exception class, but I must have accidentally deleted it during a code cleanup. I'll add it back into the code.


Only prompt to clone successful historical runs

Overview
We're currently prompting users to clone the most recent historical run regardless of whether or not it was successful.
We should only give the option to clone the most recent run if that run was successfully completed.

closing this in favor of #9031


updates to documentation

This PR provides some more context and details for setup to those that may not be familiar with setting up Vortex, and are using it for the first time on their Steam Deck. It also likely has instructions where things have changed slightly from when this was first written, for instance if the first game modded requires an extension, it does not pop up warnings to be fixed, and thus would cause mods to fail.

Note: As this is a simple doc update, merging prior to @SirStig 's PR would be beneficial. If we could merge that PR into a separate develop branch, I would be happy to update his more formal README as well. (I kept the formatting and tone of the original in this PR).

Looks good. Not sure if that PR will be merged - ton of things to resolve and the new Nexus Mods App will hopefully obsolete this soon.


cannot multiply &&EdwardsBasepointTable by &Scalar

Hi there, I'm facing this issue when compiling my Substrate program:
error[E0369]: cannot multiply `&&EdwardsBasepointTable` by `&Scalar`
   --> /Users/kofiotuo/.cargo/registry/src/github.com-1ecc6299db9ec823/snow-0.9.0/src/resolvers/default.rs:132:47
    |
132 |         let point = (&ED25519_BASEPOINT_TABLE * &self.privkey).to_montgomery();
    |                      ------------------------ ^ ------------- &Scalar
    |                      |
    |                      &&EdwardsBasepointTable
    |
help: `*` can be used on `&EdwardsBasepointTable` if you dereference the left-hand side
    |
132 |         let point = (*&ED25519_BASEPOINT_TABLE * &self.privkey).to_montgomery();
    |                      +

For more information about this error, try `rustc --explain E0369`.
error: could not compile `snow` due to previous error

Also just encountered this, seems the latest version of curve25519-dalek v4.0.0-rc.0 released 18 hours ago is causing the issue.
Manually downgrading to the previous version resolved it for me:
cargo update -p<EMAIL_ADDRESS>--precise 4.0.0-pre.5

In the rc.0 release, you'll probably want to switch to the new mul_base method:
let point = EdwardsPoint::mul_base(&self.privkey).to_montgomery();

This abstracts over various fixed-base scalar multiplication implementations based on what optimizations are available, including using the basepoint tables.

Here's a PR which adds a first-class API for this: https://github.com/dalek-cryptography/curve25519-dalek/pull/503

Likely, the culprit here is that snow depends on curve25519-dalek with the implicit caret (^) operator which allows cargo to look for semver-compatible versions: https://github.com/mcginty/snow/blob/dd50e62077407de730421fc66b757ccbd480d87f/Cargo.toml#L48
Pre-releases are compared lexically, an rc happens to have a higher precedence than pre.
Would it possible to get a hot fix for snow that pins the curve25519-dalek version like this:
curve25519-dalek = { version = "=4.0.0-pre.2", optional = true }

Submitted a PR here: https://github.com/mcginty/snow/pull/147

Published a patch fix (v0.9.1) on to a new  0.9 branch https://github.com/mcginty/snow/tree/0.9, as the main branch has API-breaking changes.


[MM-22171] Move loadedPlugins into redux-store

Summary
This PR removes loadedPlugins global variable, and switches to using the plugins redux store in mattermost-webapp.
Ticket Link
Fixes: https://github.com/mattermost/mattermost-server/issues/13928
JIRA: https://mattermost.atlassian.net/browse/MM-22171

/update-branch

/upadte-branch

/update-branch

/update-branch

Hey @DHaussermann this is ready for QA. Will fill in the details in the jira.

/update-branch

@Qovaros or @ali-farooq0  I tested the majority of the plugins in the market place.

No issues on install
Ensured that enable / disable works without needing a refresh
No user side console errors on enable / disable. Checked Browser and Desktop client
No need for refresh on uninstall

The only issue I found is that with Zoom - when disabled the icon disappears but the /zoom remains in the slash command auto-complete. This did not occur with any other plugin I tested. Any thoughts on if it could be related to this PR?

Thanks for the thorough QA @DHaussermann, can you confirm if same behaviour is observed in master? If so then it's probably isolated to the Zoom plugin and not related to this PR. I suspect it is isolated but better to confirm.

/update-branch

Thanks @DHaussermann!
Thanks @Qovaros for your contribution! 🎉
merging this now.


Add Option To Not Upload Video If Using Remote Source String

Let me know if this completely defeats the purpose of next-video, but I've been given a requirement to get the video from one of our servers through a remote URL.
I'm following this: https://next-video.dev/docs#remote-videos
And as the docs say, in doing so will have the video process and be uploaded to my hosting provider (I'm using Vercel Blob).
It does feel very weird to have the videos saved on a server to be reuploaded to another server so I was wondering if it's possible to just read from the source string or if that just defeats the purpose of using next-video and I should consider another video player.
I'm also running into another issue where if I don't have the JSON for the video, it won't play. For some context, I'm going to be uploading videos to this server, and updating my database with video links, and my website will get the source string but from the database. But in order for me to have the video play, I have to get this to upload on my local first, but I can't always do that because maybe there will be 100 videos added. Is there a workaround for this or something I'm misunderstanding?
Thank you!

Thanks for this feedback! we're going to make this possible, seems this is often requested.

Thanks @luwes ! Sucks I have to move off of it for the time being, but will keep an eye out for the PR to switch back!

there's a next-video/player export available in the latest release 1.1.0
example:
https://next-video-demo.vercel.app/player-only
https://github.com/muxinc/next-video/blob/main/examples/default-provider/app/(default)/player-only/page.tsx


Render issue references in file table

Fixes #17887

There's a minor inconsistency: the icons on the popup are greyed out?
files view:

commits view:

@jpraet https://github.com/go-gitea/gitea/pull/17903.


[Bug]When discord opens ona  system startup better discord does not launch with it

Before Reporting

[X] I found no existing issues matching my bug
[X] My issue is not caused by a plugin or theme

Describe the Bug
when I turn on my computer discord launches automatically, better discord does not launch and I have to reinstall better discord every time.
Expected Behavior
better discord shouldn't need to be installed everytime i launch my computer
Steps To Reproduce
turn on computer
let discord open
done
Operating System
Windows
Discord Version
Canary
BetterDiscord Version
v1.8.5
Anything else?
No response

Duplicate of #1538


chore: fix layout shift

Avoids shifting content to the bottom when the ad pops up
Before:
https://user-images.githubusercontent.com/32865581/158005633-f1ff5ccd-1d90-457b-b747-357213d97591.mov
After:
https://user-images.githubusercontent.com/32865581/158005690-01cbb6c3-dc0e-4cf6-9a50-c244d496bd00.mov

The ad is not supposed to be displayed on mobile AFAIK. @nzakas could you confirm? I have it explicitly set to display: none in the stylesheet. Did something change?

The ad is not supposed to be displayed on mobile AFAIK. @nzakas could you confirm? I have it explicitly set to display: none in the stylesheet. Did something change?

Yes, We don't need the wrapper to take space in mobile right that is why added display none for that wrapper. The behaviour is the same. except we add explicit height in devices with ad and display: none the ad wrapper when ads are not needed (mobile)

I’m sorry you totally lost me here. x) The ads never displayed on mobile before. The CSS hid them, and even the script that adds the ad to the hero only runs at viewports > 800px. What am I missing?

<div class="carbon-wrapper">
            {% include "partials/carbon-ad.html" %}
</div>

The media query I've added is for the wrapper that I've introduced. It does not affect any of the existing styles.

Deploy previews only work for forks as a security precaution.
The ad isn't displayed on mobile, that's correct. I think what's happening here is that carbon-wrapper has a fixed height, and on mobile, that would show up as a big vertical gap in the page, so the media query ensures that it's hidden. Did I get that correct?

Did I get that correct?
Yes exactly

Great thanks! 😄

For better understanding, see the carbon ad and layout shift below.
Before
https://user-images.githubusercontent.com/46647141/158918638-a3eea3c6-15cd-4ee9-a895-5e781ec63325.mov
After
https://user-images.githubusercontent.com/46647141/158918691-16f87773-f1d0-440f-ad89-336b9e0bb6e1.mov

Checked it out locally with mobile, too. Looks good. Thanks!


GitHub: offer .tar.gz binary downloads - not just .zip

https://github.com/docker-slim/docker-slim/releases
Two reasons:

Every Linux comes with tar - but not unzip.
ZIP format doesn't carry a +x flag for binaries. chmod +x is needed after unzip.

That's a great idea! Thank you! Will do this ASAP.
There's also a wishlist item to publish docker-slim to the major package repositories. If this is something you are interested in doing your contribution will be greatly appreciated!

I can submit to AUR (Arch User Repository).

That would be great if you can help out with that!

By the way, the latest release should have a tar.gz download too.

It seems fixed.


fix(versionWriter): use correct path to node_modules directory #23

Alaska Airlines Pull Request
Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.
Fixes: #23
Summary:
Edit the path to node_modules used in versionWriter.js to be correct. This change was tested in auro-combobox.
Type of change:
Please delete options that are not relevant.

[ ] New capability
[x] Revision of an existing capability
[ ] Infrastructure change (automation, etc.)
[ ] Other (please elaborate)

Checklist:

[x] My update follows the CONTRIBUTING guidelines of this project
[x] I have performed a self-review of my own update

By submitting this Pull Request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
Pull Requests will be evaluated by their quality of update and whether it is consistent with the goals and values of this project. Any submission is to be considered a conversation between the submitter and the maintainers of this project and may require changes to your submission.
Thank you for your submission!
-- Auro Design System Team

:tada: This PR is included in version 1.0.1 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


Server crashes NetherEX is included in the mods

I tried to run NetherEX & LibraryEX on a server and the it crashed when trying to start up the server. I'm using the latest forge version, and I'm also using the latest version of both of the mods and there were no config changes made to any of them.
Crash Report: https://pastebin.com/vyc8NZ28
Log File: https://pastebin.com/M9xtxJQH
Minecraft Version: 1.12.2
Forge Version: <IP_ADDRESS>55
NetherEX Version: 2.2.4
LibraryEX Version: 1.2.1

Try the latest version I just released and see if it fixes your issue.

Alright, it worked! Thank you for the fix!


Add labels for SES and SNS AWS connectors

Purpose
$Subject

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.Hasitha Abeykoon seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.You have signed the CLA already but the status is still pending? Let us recheck it.


Send Mail Out of Context

I'ved added the ability to send email outside of HTTPContext by mocking one up with just the BaseUrl. I didn't run unit tests as they weren't immediately working for me, and I only did it for StringResult (don't know if it's needed anywhere else). I only tested for my specific situation, so it might be able to be optimized.
Now all that you need to do if sending outside of context is specify the BaseUrl of the MailerBase and it if HttpContect.Current is null, it will mock out an HTTPContext object to be able to render the view.

+1 Please implement this.

It seems possible with Hangfire. It would send the mails in the background, but still within context. See http://docs.hangfire.io/en/latest/tutorials/send-email.html


Removing folders we no longer use

Increasing consistency with other working groups.

LGTM!
Signed-off-by: Armstrong<EMAIL_ADDRESS>


API key

Where can o get the training key and prediction key

Go to https://www.customvision.ai/, sign in
Find/create a project
Click on the gear icon in the upper right


Add 'w3c' to the injected JAEGER_PROPAGATION environment variable

In https://github.com/jaegertracing/jaeger-operator/blob/master/pkg/inject/sidecar.go#L308 the default propagation formats are set to jaeger and b3. Many OpenTelemetry clients have adopted the recent W3C TraceContext as a default propagation format.
It would be great if w3c were added to this list by default.

Sure, sounds good. Do you know what happens when a propagation format isn't recognized? Would the client typically crash, or will it just ignore? The Java client will not crash, but will log a message:
https://github.com/jaegertracing/jaeger-client-java/blob/568ab68ec2ac5e9e811b1d0d76f752f3242d45d3/jaeger-core/src/main/java/io/jaegertracing/Configuration.java#L458

The

Sure, sounds good. Do you know what happens when a propagation format isn't recognized? Would the client typically crash, or will it just ignore? The Java client will not crash, but will log a message:
https://github.com/jaegertracing/jaeger-client-java/blob/568ab68ec2ac5e9e811b1d0d76f752f3242d45d3/jaeger-core/src/main/java/io/jaegertracing/Configuration.java#L458

The C# client does the same: https://github.com/jaegertracing/jaeger-client-csharp/blob/4e97b9ada2a9b30fdc266482f5841f1e5e161d59/src/Jaeger.Core/Configuration.cs#L477
According to https://www.jaegertracing.io/docs/1.19/client-features/ these are the only clients that can be officially configured via that variable. There's definitely still a potential risk, however as the documentation states that w3c can be used as a value and should therefore be expected I think we should be ok.

Go ahead then :-)


fix(v5): broken link and missing type annotations in tutorial

I know we're not supposed to send PRs right now, but since I noticed some errors while I did the tutorial again (see https://github.com/withastro/blog-tutorial-demo/pull/33), I thought I'd make the necessary updates!
Description (required)
Updates the tutorial to:

Add missing type annotations in the Unit 5 (final code snippet, code check-ins...)
Fix a broken link in Unit 6

I haven't addressed ThemeIcon.astro because I don't know if it's necessary or not:

when I follow the tutorial I don't see any error
when I open blog-tutorial-demo I see Typescript errors...

Related issues & labels (optional)

Suggested label: 5.0.0-beta, code snippet update, typo/link/grammar - quick fix!

Sorry for the wrong automatic labels... I forgot to use the 5.0.0 branch as base... 😅

Lunaria Status Overview
🌑 This pull request will not trigger status changes.

Learn more
Lunaria automatically ignores changes on specific PRs by adding a ignored keyword in its title. Found: broken link.
You can change this by either removing the keyword above from the PR's title, or modifying the ignoreKeywords property in your Lunaria configuration file.

Tracked Files

[!NOTE]
The notes below indicate what would happen if the pull request is merged when triggering status changes. Since a ignored keyword was found in the PR's title, the status changes indicated below won't be applied.

File
Note

en/tutorial/5-astro-api/1.mdx
Source changed, localizations will be marked as outdated.

en/tutorial/5-astro-api/2.mdx
Source changed, localizations will be marked as outdated.

en/tutorial/5-astro-api/3.mdx
Source changed, localizations will be marked as outdated.

en/tutorial/6-islands/4.mdx
Localization changed, will be marked as complete.

Warnings reference

Icon
Description

🔄
The source for this localization has been updated since the creation of this pull request, make sure all changes in the source have been applied.

I'm just rerunning the Netlify deploy to see if I can get it to work before merging. We're getting the "out of memory" error again.

Second Netlify deployment is fine! 🚀


chore: rm contracts replacement in docker compose

https://github.com/neutron-org/neutron-tests/actions/runs/6472544249


Support setting colors in terminal profile setting

Follow up from https://github.com/microsoft/vscode/issues/121738

How will these interact w the icon -
will we support setting a profile's icon to a ThemeIcon | URI | { light: URI, dark: URI }?

Hi

That's what I'm saying

I think for profiles we'll probably just have color: 'terminal.ansiRed' | 'terminal.ansiBlack' | ...

To support any color we would need to move the below into TerminalView's style tag:
https://github.com/Microsoft/vscode/blob/514d3162bc82bc9bc50c4aba0992f1386ad3d3d4/src/vs/workbench/contrib/terminal/browser/terminalInstance.ts#L1953-L1960


Add @require_reader decorator where appropriate

This PR demonstrates how to create a route decorator for enforcing the workspace "reader" role.
If this passes muster, I will plan to create the other three decorators and place them on the appropriate route functions as well.
Depends on #396

@waxlamp it seems you've addressed all of my concerns. Is your plan still create the other role decorators in this PR, or a follow-up one?

@waxlamp it seems you've addressed all of my concerns. Is your plan still create the other role decorators in this PR, or a follow-up one?

Follow-up.


Remove duplicate commons library in Android Vision sample

Hi @chsienki, I'm your friendly neighborhood Microsoft Pull Request Bot (You can call me MSBOT). Thanks for your contribution!

It looks like you're a Microsoft contributor (Chris Sienkiewicz). If you're full-time, we DON'T require a Contribution License Agreement. If you are a vendor, please DO sign the electronic Contribution License Agreement. It will take 2 minutes and there's no faxing! https://cla.microsoft.com.

TTYL, MSBOT;


Rethink cases for setAccessibleContent

@zepumph found a few issues with setAccessibleLabel and setAccessibleLabelAsHTML. The default behavior for these functions is to set the label value as the innerText or innerHTML of the node.  This is confusing because for nodes with children that also have accessible content it will produce html like

 (node's accessible tag)
  <button>Child Button</button> (child of node)
  <input> (child of node)
  "Accessible Label" (accessible label of node)

More intuitive default behavior would be the following (the label should be outside of the child content):

 (container element

 (node's accessible tag)
    <button>Child Button</button> (child of node)
    <input> (child of node)

Accessible Label
 (accessible label of node

With setAccessibleLabelAsHTML it is easy to blow away accessible content of child nodes because the default is to set the innerHTML of the Node's DOM element. (Very scary!)
We would like to  change the behavior of setAccessibleLabel to only set content for a label element (maybe default to p) or set the content for aria-label. New functions like setAccessibleInnerHTML and setAccessibleInnerText will explicitly set the innerHTML or innerText to handle cases like
<button>My label as inner text</button>

This change would likely make this kind of mix of inner content unsuported:

Some text content

  Other text content

In general I think this is OK, I can't think of a case where this would be better than

Some text  content

Other text content

But @terracoda we wanted to check this limitation with you before continuing, does this seem OK?

@zepumph and @jessegreenberg, I need to think this over a bit to understand it.
There are a few different ways to create and "accessible name" for an element, and we should be building in all the ways to do that. You need different "naming" solutions for different situations.

@zepumph @terracoda and I discussed this today, and @terracoda said it was OK to proceed with this as long as we still support the common ways of naming elements with labels: aria-labelledby, label element with the for attribute and innerText/innerHTML.

All interactive elements must have an "accessible name" in the Accessibility Tree. The API should make sure all techniques for providing an accessible name are provided.
The most common ways to provide an accessible name (preferably in this order) are to:

provide understandable content inside an interactive element, like a button <button>Accessible Name</button>
associate the label element to the interactive element it is labeling with a for attribute My Checkbox's Accessible Name<input type="checkbox" id="my-checkbox>
provide the name with the aria-label attribute inside the interactive element <input aria-label="My Reset's Accessible Name" type="reset">
associate the html content of one element to another element with the aria-labelledby attribute when one of the three methods above are not naturally available, or to associate one name to a group or region. Examples for aria-labelledby are more diverse and complex. Several examples are available at MDN.

@jessegreenberg, @mbarlow12 and I just spent some time discussing this one. It seems to be a pretty multi-faceted api. We want to be able to handle quite a bit of flexibility in how we have a "label" (what we are calling a separate tag that goes either before or after the node's tag) or set and Accessible Name (supported examples of Accessible Name: (1)  tag with for attribute; (2)  aria-label attribute set on another "label" tag; and (3) aria-labeledby on the node itself (not supported by this api change;).
Currently we are looking into trying to be more explicit with the calls, and less clever in the mixin to make the resulting html more expected and clear for all developers.
One thing we thought about was to have 2 options, instead of just accessibleLabel plus flags. These options would be to create a separate tag to hold content (like a "label"), and the other is to directly set the innerHTML/textContent of the node (only allowed if the node does't have any children).
We will continue discussing the next time we meet. Perhaps next Wednesday?
@jessegreenberg @mbarlow12 please refine my comment as you see fit.

Today we spoke again, and tried to gain a better understanding of our use cases. @terracoda discussed them out nicely in https://github.com/phetsims/scenery/issues/686#issuecomment-336526279 and we tried to go off of that.
Imagine a new mixin option called accessibleName. It only supports creating an accessible name for something, rather than the current accessibleLabel which has other uses too. Since @terracoda said there are 4 ways to have an accessible name, here are the 4 use cases:
// javascript
accessibleName: "George", use cases below

//1
<button>George</button>

//2
George
<id="input" input/>

//3

 // Barlow: Redundant? perhaps we can just use aria-labelledby exclusively with another tag.

//4

 // parent container

George
 // SR says "George". Or does SR just negate this because it know that it labelling something else?

 // SR says "George" again?

Besides case 4, we would also address the case of having another node far away label your node.
@terracoda we have a question for you. Currently there is no support in our new thought process for

George

But this is used quite often in our code currently. We are wondering if:

George

is better/ preferred replacement. Do we want to always have both options above? What do you think about it?
is

George

actually not a better option at all?
Thanks!
the a11y dev team.

One other valid way to provide AT with an accessible name is

    <input type="something">Input name

This may be a more concise option for case 2 in https://github.com/phetsims/scenery/issues/686#issuecomment-339525658.

@terracoda We also discussed possibly not supporting case 3. Since it appears that aria support in general is somewhat limited, we thought it may be simpler to default to case 4 and explicitly delineate the desired labelling element. Also, in that vein, we're curious if the 2 html structures affect how virtual cursors move through the page.
From what I understand, we currently provide the following:

George

And screen readers will see the heading since that is their default behavior. I'm curious as to the behavior of the following:

George

Will the curser pass over the h3, knowing that it provides the accessible name for the ul, and pass focus to the ul or will it behave as above, first reading the contents of the h3 then moving to the ul --effectively repeating the ul's name?

Unassigning, to be continued next meeting.

Initially this issue was to discuss the problematic case of accessible content that looks like:

 (node's accessible tag)
  <button>Child Button</button> (child of node)
  <input> (child of node)
  "Accessible Label" (accessible label of node)

Instead of reworking supported HTML structures and API, what if we kept a similar API but remove this confusing case?
@zepumph @mbarlow12 what do you think of an API that looks like this:
//--------------------------------------------------------------------------
new Node( {
  tagName: 'button',
  innerAccessibleLabel: 'My Button' // will error if this node has any children
} );

// creates HTML
<button>My Button</button>
//--------------------------------------------------------------------------

new Node( {
  tagName: 'ul'
  accessibleLabel: 'My Label'
} );

// creates HTML

My Label

//--------------------------------------------------------------------------

new Node( {
  tagName: 'input'
  accessibleLabel: 'My Label',
  labelTagName: 'label'
} );

// creates HTML

  <input id='my-node'>
  My Label

//--------------------------------------------------------------------------

new Node( {
  tagName: 'input',
  accessibleLabel: 'My Label',
  useAriaLabel: true
} );

// creates HTML:
<input aria-label="My Label">

While aria-labelledby and aria-describedby go through different functions.

I like that! By doing this are we only ever setting innerHTML, or do we still support textContent?
Also how to handle a situation where where we aren't trying to add a label, but just apply content to a paragraph:

The dog went to the park

By doing this are we only ever setting innerHTML, or do we still support textContent?

Good point, we will still need accessibleLabelAsHTML and innerAccessibleLabelAsHTML to support
//--------------------------------------------------------------------------
new Node( {
  tagName: 'button',
  innerAccessibleLabelAsHTML: 'My Button' // will error if this node has any children
} );

// creates HTML
<button>
My Button
</button>
//--------------------------------------------------------------------------

Also how to handle a situation where where we aren't trying to add a label, but just apply content to a paragraph

My thought was the we treat this just like buttons, so it would look like
//--------------------------------------------------------------------------
new Node( {
tagName: 'p',
innerAccessibleLabel: 'The dog went to the  park.'
} );
// creates HTML
The dog went to the park.
//--------------------------------------------------------------------------
So that through the API the only difference between p and button is tagName, innerAccessibleLabel behaves the same for both.

@jessegreenberg  and @zepumph, you do want to support things like this:

The big dog went to the park and the little one stayed home.

But I would never want to see
 or
 which are non-closing tags inside a <button> element's content. Also, a pair of  tags should be unnecessary inside a button element as one could use CSS to style the label of a button.
The difference between the button element and the p element is that the button requires an accessible name in the accessibility tree, whereas the content of a p is content. I don't think it is an "accessible name" or "label" in the same way.

But I would never want to see
 or

Thanks, I meant to say  instead of
, sorry.

I don't think it is an "accessible name" or "label" in the same way.

I agree, and that is one of the reasons I like the proposal in https://github.com/phetsims/scenery/issues/686#issuecomment-339767546. This is not the "accessible name" used in the accessibility tree, this is "inner accessible content" for whatever tag name was specified with the function setTagName. The resulting HTML will look the same whether it is button or p.

@jessegreenberg, I agree that https://github.com/phetsims/scenery/issues/686#issuecomment-339767546 is a good approach. I would like to consider a couple changes to the list example in order to provide code validity and perhaps better semantics.
The button example and the input examples examples make perfect sense.
The list example, however, seems a little strange to me. I am not sure a paragraph would provide the best semantics of a label for a list without using aria-labelledby. That said, a heading (of which there are 6 levels) could be interpreted more like a label. This is just my feeling (not sure how to find an absolute answer on this, maybe on whatsock.com).
Also, the generated code for a list should include at least one pair of list items tags,

. A list is not valid without list items. I'm not sure what the Javascript should be, but I think the generated HTML would more accessible for our purposes if it looked something like this:
//--------------------------------------------------------------------------
new Node( {
tagName: 'ul'
accessibleLabel: 'My Label'
__ accessibleLabelLevel: 2 - not sure how this is done in JS __
} );
// creates HTML

My List's Label

List item content

//--------------------------------------------------------------------------
Does that make sense to you?

@terracoda sounds good, the p for the list was just an example, it could be any arbitrary tag. I agree that lists should have content in use, and that would be supported by https://github.com/phetsims/scenery/issues/686#issuecomment-339767546. To create your example, code it might look like this:
var listNode = new Node( {
  tagName: 'ul',
  labelTagName: 'h2',
  accessibleLabel: 'My Lists Label'
} );

var itemNode = new Node( {
  tagName: 'li',
  innerAccessibleLabel: 'List item content'
} );

listNode.addChild( itemNode );

To create

@jessegreenberg, thanks for the example. Sounds good to me.

Unassigning, lets talk about this more at dev meeting.

Discussed 11/22/17: We are going to go ahead with the proposal listed in https://github.com/phetsims/scenery/issues/686#issuecomment-339767546, but with the following changes:

We will add innerAccessibleText and innerAccessibleTextAsHTML.
We will also change useAriaLabel: <boolean> to a setter called ariaLabel: <string>, where when specified the value of  setAriaLabel will be the value for the aria-label attribute on the node's accessible DOM element.

I am going to take a first stab at this, then I'll come back to the group if I run into problems.

I want to make sure that I'm implementing the right thing here:

There are now three options, that are independent, for controlling the text associated with a tag, all of these options are of type string:

innerAccessibleText(AsHTML) -

changes textContent/innerHTML respectively.
errors out if there are children of this node

accessibleLabel(AsHTML):

always creates a sibling tag to but the content in
default tag is a "p"

setAriaLabel:

es5 setter ariaLabel
sets the aria label attribute of the tag

examples
//--------------------------------------------------------------------------
new Node( {
  tagName: 'button',
  innerAccessibleLabel: 'My Button' // will error if this node has any children
} );

// creates HTML
<button>My Button</button>
//--------------------------------------------------------------------------

new Node( {
  tagName: 'button',
  innerAccessibleLabelAsHTML: 'My Button' // will error if this node has any children
} );

// creates HTML
<button>My Button</button>
//--------------------------------------------------------------------------

new Node( {
  tagName: 'ul'
  accessibleLabel: 'My Label'
} );

// creates HTML

My Label

//--------------------------------------------------------------------------
new Node( {
  tagName: 'ul'
  accessibleLabelAsHTML: 'My Label'
} );

// creates HTML

My Label

//--------------------------------------------------------------------------

new Node( {
  tagName: 'input'
  accessibleLabel: 'My Label',
  labelTagName: 'label'
} );

// creates HTML

  <input id='my-node'>
  My Label

//--------------------------------------------------------------------------

new Node( {
  tagName: 'input',
  ariaLabel: 'My Label'
} );

// creates HTML:
<input aria-label="My Label">

@jessegreenberg I like all of the above except one thing. Why do we need an explicit call for html, can't these label options both just support formatting tags? We error out for innerAccessibleText if there are any children, so using innerHTML should be reasonable and safe.  I just want to make sure that if you pass in "

Adding to a11y dev meeting just to get refreshed on this, and to make sure I understand how to proceed.

In the keyboard nav meeting today, we (@terracoda leading) discussed the need for multiple aria-labelledby and aria-describedby` tags on a single element, we should add that to the api in this issue.

Marking as high so that we make sure to get to it tomorrow.

We would like to reconsider having both setAccessibleLabelAsHTML and setAccessibleLabel. It is possible we only need one, and having  both complicates the API. To determine whether or not we can get rid of one, we need see if there is a detectable performance degredation by using setAccessibleLabelAsHTML.

@jonathanolson we are trying to decide if this makes it worthwhile to support both textContent and innerHTML. Would you recommend that we support both, or is this performance difference irrelevant in the scheme of things?

Depends on how many times this will need to be called per frame, and if the performance is worse on iOS/etc. Also depends on convenience. If it takes 0.01ms for a 16.7ms budget for each frame, and is only called a few times per frame, I'm definitely not concerned about performance.

We discussed the textContent vs innerHTHML performance more in dev meeting today. @jessegreenberg @mbarlow12 and I think that the performance difference is not prohibitive. In fact on Safari @mbarlow12 found that innerHTML is actually 37% faster, and firefox had them as equals.
If there are problems with performance in the future, then there are other pieces of the mixin that can (and should eventually) be updated. One of these that was discussed was batching invalidateAccessibleContent calls to once a frame. @mbarlow12 also spoke to Web Assembly as holding answers.

We finished discussing the way that we want the new A11y API to look in scenery:

[ ] Remove *AsHTML methods and only use innerHTML settings on DOM elements. Performance considerations in the above comment https://github.com/phetsims/scenery/issues/686#issuecomment-373202147

[ ] Reimplement accessibleLabel: {{string}} so that it only ever set's a sibling DOM element, tag declared in labelTagName.  labelTagName should default to label if not specified when accessibleLabel is given.

[ ] innerContent: sets the innerHTML on tagName DOM element of the Node itself.

[ ] Reimplement useAriaLabel: {{boolean}} to setAriaLabel: {{string}} which will set the aria label attribute on the Node's DOM Element

[ ] prependLabels: {{default false}} will be split into two options:

`appendLabel: {{default false}}
appendDescription: {{ default false}}

Notice that the default value has switched, and the default now places the label/description before the Node's DOM Element.

[ ] parentContainerTagName exists if ever there is a label or description DOM Element, defaults to div

[ ] If parentContainerTagName is given without label/description content, then just surround the single Node's tagName

[ ] Label and description DOM Elements cannot be children to the Node's DOM element, only siblings.

Closing, to be implemented in https://github.com/phetsims/scenery/issues/748

Great work everyone! This was a honker.

Great work @zepumph, thank you for taking the lead on this.

@zepumph can Scenery handle two id's for an aria-labelledby attribute yet?

It cannot, but we have not updated the aria-labelledby or aria-describedby apis yet, please see https://github.com/phetsims/scenery/issues/701 for that issue. Feel free to add comments and capability suggestions.

@zepumph, thanks, I needed the issue number.


Add 'censor middle only' feature

Firstly, thanks for the amazing module!
I've added a censor middle only feature which censors only the middle of the texts.
Can only be used if middle_only argument is set to True and it's set to False by default, so it doesn't break anything or alter the way the module works.
I didn't really test edge cases that much but it passes all 30 unit tests.
Without middle_only parameter (same result with middle_only=False):
from better_profanity import profanity

if __name__ == "__main__":
    profanity.load_censor_words()

    text = "fucking shit"
    print(profanity.censor(text))
    # "**** ****"

With middle_only parameter:
from better_profanity import profanity

if __name__ == "__main__":
    profanity.load_censor_words()

    text = "fucking shit"
    print(profanity.censor(text, middle_only=True))
    # "f*****g s**t"

Also added env/ to gitignore since I was using a virtual environment, discard it if you want.

May I ask what the use case for "middle only" censoring is ? Or is it just a personal preference ?

Actually we just needed a way to determine the true length of the censored text. With the current method it returns 4 regardless of the words length. Not censoring the initial and the last letter was a personal preference in order to make the word more "guessable".

Oh sure, sorry about that.
Closing rn.


sink(cdc): avoid temporary memory allocations for avro

What problem does this PR solve?
Issue Number: close #11590
What is changed and how it works?
It is like #11595 but removes temporary memory allocations from avro sink.
Check List
Tests

Unit test

Questions
Will it cause performance regression or break compatibility?
Do you need to update user documentation, design documentation or monitoring documentation?
Release note
None

/retest


[Popup] Setting to hide on scroll

Hi,
maybe i have a little improvement.
I used popups and tried to close them on a page scroll event, cause they are positioned on body and when i scroll, they are still on this position, while they point on wrong data.
When i create them inline, the positioning works, but the page needs nearly 10sec to render all items.
Therefore i thought it would be nice, if u can close them on a scroll event.
Thx for all work on Semantic-Ui! :)
Raph

Added last novemeber


Create Pytorch Informer/ClientSet

What this PR does / why we need it:
This PR runs code generator to create a pytorch client and informer.
Which issue(s) this PR fixes Fixes #1499
Checklist:

[ ] Docs included if any changes are user facing

Could you please also add XGBoostJob, MXNetJob, and MPIJob?

Added all 3. Although the imports aliases conflict with each other. @gaocegege do you happen to know what's needed to resolve this or is the expectation to manually resolve them?

Ref https://github.com/kubernetes/code-generator/issues/135

I'm extremely curious, will this pr continue to update?

Ref kubernetes/code-generator#135

I also think the problem is this groupName. See mpi group name, mxnet group name,  pytorch group name, tensorflow group name and xgb group name: they are all kubeflow.org.
Our hierarchy is /pkg/apis/<ml-framework>/<version>, where in fact, each ml framework actually is a subgroup, so if we can add one more subgroupName to the groupName, such as tfjob.kubeflow.org, then packing collision could be fixed.

We can close this PR as #1610 is merged

/close


Design @1x

Designing @1x is super important to me, and the more I use FS as a design tool, it becomes even more imperative (this means less ⌘I and more direct drawing in Framer). It is also extremely beneficial for cleaner communication between designers and engineers (app.coffee becomes a source of self-documenting design ... no more red-lines).
Here is a test project (with an augmented template Sketch file included) where you can see the changes in action.
Related: https://www.facebook.com/groups/framerjs/permalink/641286459331762/

...I will write/update tests too if you are cool with this @koenbok ;)

I just realized that my changes to index.html will break things for existing projects that are designed in absolute pixels. I reverted those changes and added some logic to update the viewport meta tag when setting DeviceComponent#contentScale. This should make things compatible with existing projects and shouldn't require any of the Studio demos/templates to be reworked.
@koenbok what do you think about this?

Ooh this looks pretty interesting. I'll try and take a closer look tomorrow!

Any news?

Hey @peteschaffner we're still pretty interested in solving this. Are you still thinking about finishing approach?


Implementing the swipe action in the "updates" section

Describe your suggested feature
Would be possible to implement the swipe action in the "updates" section as well? For exemple swiping left to bookmark a chapter but directly on the updated chapters list.
Other details
No response
Acknowledgements

[X] I have searched the existing issues and this is a new ticket, NOT a duplicate or related to another open or closed issue.
[X] I have written a short but informative title.
[X] If this is an issue with an official extension, I should be opening an issue in the extensions repository.
[X] I have updated the app to version 0.16.1.
[X] I will fill out all of the requested information in this form.

+1
Please add Library's chapter swipe action to Updates tab too.


Black screen when launching the Game

When launching the game from the HuntersPie app, the game remains on a black screen and I am unable to perform any interactions on my computer.

Are you talking about MHW or MHR? Launching the game from HunterPie is the exactly same thing as launching it from Steam. If you're talking about MHW and your game is getting stuck in a black screen that is usually related to broken mods in your NativePC folder.

It is MHW, I thought I had to launch the game from the app, I replicate launching the game from steam with and without mods, and it runs perfectly on both, the black screen only happens from the application.
Thanks for the help

The launch button on the app is just a QoL, all it does is call steam to launch the game, it's exactly the same thing as launching from steam.
https://github.com/HunterPie/HunterPie/blob/aef90a2da2a438ada8eaa604e9bfc2a42a012da3/HunterPie/Internal/Steam.cs#L24-L28

I can see that, not sure why in only does that from the app


Fix non jvm compliant character

When running jRuby 9K (packaged as a WAR in a Tomcat Server), the character you used ‽ creates an internal server error. I have replaced ‽ with ?.
Error Log:
07-Jan-2016 01:12:18.730 SEVERE [localhost-startStop-1] org.apache.catalina.core.ApplicationContext.log ERROR: initialization failed
 org.jruby.rack.RackInitializationException: /Users/cmullen/Developer/Tomcat/webapps/skio-api/WEB-INF/gems/gems/econfig-2.0.0/lib/econfig/backend_collection.rb:23: Invalid char `\200' ('') in expression
      existsâ½(name)
             ^

Damn JRuby ruining all the fun :(

Seems like this should probably be reported to JRuby. In this case the interrobang was just for fun, but having UTF-8 chars in method names is legitimate Ruby code, so this should really work.

Can instead be fixed by adding "# encoding: utf-8" to the top of the file.

That shouldn't be necessary any more. Ruby 2.x assumes UTF-8 encoding by default.

And JRuby 9.x targets Ruby 2.2 IIRC.

I think this has to do with the jrubyc compiler


fix: change material for ply and add vertex color

Change the Material for PLY model to MeshBasicMaterial according to the stack overflow post at issue 57. Since PLY object is made of vertex, set the vertexColor to true.

I think you can use the ply file from this Q and A section to test.
https://discourse.threejs.org/t/import-color-from-ply-file/38430


Add support for morph targets in 3dsmax exporter

@noalak can you provide a sample scene for the morph target in the exporter folder?


Use MODULESTRIP where appropriate

this depends on https://github.com/apache/incubator-nuttx/pull/806


knocking

About the PR
Added knocking to windows
Why / Balance
resolves #4864
Media
https://github.com/user-attachments/assets/985db4a9-36d5-43d5-9ec2-52e87b5495f7
Requirements

[x] I have read and am following the Pull Request and Changelog Guidelines.
[x] I have added media to this PR or it does not require an ingame showcase.

Changelog

do resolves #4864 in the description so it auto closes

do resolves #4864 in the description so it auto closes

neat, didn't know you could do that, thanks 👍


Bump eslint-config-expensify version in E/App

Details
Affected rules:

Fixed no-loss-of-precision - Eslint explanation
Fixed no-promise-executor-return - Eslint explanation
Fixed no-import-assign - Disallows assignment to imported bindings ('no-import-assign': 'off' added to tests).
Fixed no-unsafe-optional-chaining - Disallows optional chaining expressions at potentially unsafe positions.
Fixed react/jsx-no-useless-fragment - Disallow unnecessary React fragments.
Turned off prefer-regex-literals - Suggests to use regex literals instead of new RegExp().
Fixed import/no-relative-packages - Forbidden any requires that come for a package inside itself
Fixed react/no-unused-class-component-methods - Prevent definitions of unused class methods
Fixed import/no-import-module-exports/ - Don't mix require/ES6 imports and module.export
Fixed react/no-unstable-nested-components - Prevents creating unstable components inside components
Fixed react/sort-comp - Enforces a sort order for methods and properties
Fixed default-param-last - Enforces default parameters to be the last in the function definition

Fixed Issues
$ https://github.com/Expensify/App/issues/36718
PROPOSAL: N/A
Tests

Verify that desktop app works
Test that requesting money (scan receipt, distance and manual request) work as expected
Verify that Share QRCode works as usual
Verify that PDFViewer works as usual
Test reimbursement form (mainly that labels display as usual)

Offline tests
N/A
QA Steps
Same as tests
PR Author Checklist

[x] I linked the correct issue in the ### Fixed Issues section above
[x] I wrote clear testing steps that cover the changes made in this PR

[x] I added steps for local testing in the Tests section
[x] I added steps for the expected offline behavior in the Offline steps section
[x] I added steps for Staging and/or Production testing in the QA steps section
[x] I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
[x] I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
[x] I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).

[x] I included screenshots or videos for tests on all platforms
[x] I ran the tests on all platforms & verified they passed on:

[x] Android: Native
[x] Android: mWeb Chrome
[x] iOS: Native
[x] iOS: mWeb Safari
[x] MacOS: Chrome / Safari
[x] MacOS: Desktop

[x] I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
[x] I followed proper code patterns (see Reviewing the code)

[x] I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
[x] I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
[x] I verified that comments were added to code that is not self explanatory
[x] I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
[x] I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method

[x] If any non-english text was added/modified, I verified the translation was requested/reviewed in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:

[x] I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
[x] I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
[x] I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
[x] I verified the JSDocs style guidelines (in STYLE.md) were followed

[x] If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
[x] I followed the guidelines as stated in the Review Guidelines
[x] I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
[x] I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
[x] I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
[x] I verified that if a function's arguments changed that all usages have also been updated correctly
[x] If any new file was added I verified that:

[x] The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory

[x] If a new CSS style is added I verified that:

[x] A similar style doesn't already exist
[x] The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))

[x] If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
[x] If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
[x] If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
[x] If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
[x] If the PR modifies the form input styles:

[x] I verified that all the inputs inside a form are aligned with each other.
[x] I added Design label so the design team can review the changes.

[x] If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
[x] If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Android: Native
android.webm

Android: mWeb Chrome
adnroid-web.webm

iOS: Native
https://github.com/Expensify/App/assets/46095609/dfaaf865-6640-47f3-9f6e-b8907e18131a

iOS: mWeb Safari
https://github.com/Expensify/App/assets/46095609/8c7f227d-18f1-4c43-81f7-7ee796ebc4d5

MacOS: Chrome / Safari
https://github.com/Expensify/App/assets/46095609/8aaff6a8-2b64-4b5e-864f-4ba37cafcab8

MacOS: Desktop
https://github.com/Expensify/App/assets/46095609/303faaa4-9193-444d-b693-2ef01b3ff86e

Reviewer Checklist

[ ] I have verified the author checklist is complete (all boxes are checked off).
[ ] I verified the correct issue is linked in the ### Fixed Issues section above
[ ] I verified testing steps are clear and they cover the changes made in this PR

[ ] I verified the steps for local testing are in the Tests section
[ ] I verified the steps for Staging and/or Production testing are in the QA steps section
[ ] I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
[ ] I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)

[ ] I checked that screenshots or videos are included for tests on all platforms
[ ] I included screenshots or videos for tests on all platforms
[ ] I verified tests pass on all platforms & I tested again on:

[ ] Android: Native
[ ] Android: mWeb Chrome
[ ] iOS: Native
[ ] iOS: mWeb Safari
[ ] MacOS: Chrome / Safari
[ ] MacOS: Desktop

[ ] If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
[ ] I verified proper code patterns were followed (see Reviewing the code)

[ ] I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
[ ] I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
[ ] I verified that comments were added to code that is not self explanatory
[ ] I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
[ ] I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
[ ] I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
[ ] I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
[ ] I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
[ ] I verified the JSDocs style guidelines (in STYLE.md) were followed

[ ] If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
[ ] I verified that this PR follows the guidelines as stated in the Review Guidelines
[ ] I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
[ ] I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
[ ] I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
[ ] If a new component is created I verified that:

[ ] A similar component doesn't exist in the codebase
[ ] All props are defined accurately and each prop has a /** comment above it */
[ ] The file is named correctly
[ ] The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
[ ] The only data being stored in the state is data necessary for rendering and nothing else
[ ] For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
[ ] Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
[ ] All JSX used for rendering exists in the render method
[ ] The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions

[ ] If any new file was added I verified that:

[ ] The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory

[ ] If a new CSS style is added I verified that:

[ ] A similar style doesn't already exist
[ ] The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)

[ ] If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
[ ] If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
[ ] If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
[ ] If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
[ ] If the PR modifies the form input styles:

[ ] I verified that all the inputs inside a form are aligned with each other.
[ ] I added Design label so the design team can review the changes.

[ ] If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
[ ] If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
[ ] I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

MacOS: Desktop

I recommend to review this PR commit by commit, to understand the changes better cc @roryabraham @jjcoffee

@jjcoffee Kind bump

Ah sorry I was waiting on @roryabraham to confirm if this needs C+ testing as he said here that it won't.

@jjcoffee I think we definitely need a C+ review on this one

@roryabraham Gotcha! Thanks for confirming, I'll review on Monday.

This PR keeps getting conflicts, @jjcoffee merged the newest main for you, please have a look today

@blazejkustra Would you mind fixing conflicts so I can get a clean test pass in?

@blazejkustra I'm getting a crash on Android Native when opening any attachment (AttachmentCarousel):

Fixed in the last commit, I'm surprised that it wasn't detected by my IDE.

:hand: This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

🚀 Deployed to staging by https://github.com/roryabraham in version: 1.4.45-0 🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
success ✅

🕸 web 🕸
success ✅

🚀 Deployed to production by https://github.com/puneetlath in version: 1.4.45-6 🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
success ✅

🕸 web 🕸
success ✅


TypeError

TypeScript Version:  2.2.1
Code
// A *self-contained* demonstration of the problem follows...
type AB=A|B;

interface A{
  a:number
}

interface B{
  a:string
}

interface C{
  a:number|string;
}

function hoge(c:C):AB{
  return c;//error
}

Expected behavior:
Actual behavior:

This has been discussed many times before...  The type system is a structural type system and TypeScript compares based on structure.  Type AB is either:
interface A {
  a: number;
}

Or:
interface B {
  a: string;
}

Where as you are returning something that has a single member a that is either a string or a number.  That is not assignable to interface A or interface B.
You can fix the error by better modelling the type:
type AB=A|B;

interface A{
  a:number
}

interface B{
  a:string
}

type C = { a: number } | { a: string };

function hoge(c: C): AB{
  return c;//no error
}

Sidenote: your issue really leaves a lot to be desired.

The actual code is more complicated, so it can not be done
interface DBModelA{
    type:'a',
    hoge:number
}

interface DBModelB{
    type:'b',
    foo:number
}

interface DBModelC{
    type:'c',
    hoge:number,
    foo:number
}

type DBModel=DBModelA|DBModelB|DBModelC;

function toModel(t:OriginalTweet):OriginalTweetModel;
function toModel(t:ReTweet):ReTweetModel;
function toModel(t:Tweet):TweetModel{
    //process
}

let hoge=toModel(Tweet);//error

You can add one more overload:
function toModel(t:Tweet):TweetModel;

And it should be fine. The problem with your current approach is that none of the overloads is actually callable with the provided argument. It can be argued that the compiler may synthesise a compatible call signature based on the intersection of existing ones, but it's actually very hard and confusing.

Thank you


Fix android build by migrating androidx modules

I ran into issues attempting to use this plugin for a Ionic 5 capacitor project.
This seemed to be a common issue:
https://github.com/EddyVerbruggen/cordova-plugin-safariviewcontroller/issues/155
https://github.com/EddyVerbruggen/cordova-plugin-safariviewcontroller/issues/157
I looked into it a bit more and saw android.support libraries are now replaced with androidx by default for Ionic.
So I changed the imports and found I was able to build and use the CustomTabs android implementation of this plugin.
Here are the changes I made to get it to build and run.
This would appear to be a breaking change so I will leave with @EddyVerbruggen to decide on merging this change.

@EddyVerbruggen could you please take a look? I'm facing this problem when installing fingerprint-aio plugin, I think it does something androidx related and there is a compatibility issue, and I need both plugins. Thanks!

I tested the pull request on Android 10 and can verify that it works as expected.

Thanks guys!
I'll do a major version bump, just to be on the safe side.


WIP: Update for 2017 challenge

@msmolens @rustylogic33 Feel free to start taking a look at Part 1 and Part 2 of this. I need to finish adding additional metrics for Part 3 before it's ready for merge though.

@msmolens Fixed all issues. PTAL.


Can't install helm chart 'skywalking'

Please answer these questions before submitting your issue.

Why do you submit this issue?
[x] Question or discussion
[ ] Bug
[ ] Requirement
[ ] Feature or performance improvement

Question

What do you want to know?

Bug

Which version of SkyWalking, OS and JRE?

Which company or project?
Trying to test Istio's "Book app" with "skywalking"

What happen?
Trying to install skywalking

If possible, provide a way for reproducing the error. e.g. demo application, component version.
helm install --name my-release skywalking
Error: failed to download "skywalking" (hint: running helm repo update may help)
helm search skywalking
No results found

Requirement or improvement

Please describe about your requirements or improvement suggestions.

I think you need helm file in our repo, https://github.com/apache/skywalking-kubernetes/tree/master/helm-chart.
We haven't pushed them into official helm repo, and the recent severl release hasn't provided helm chart by @hanahmily

@innerpeacez Please push new helm for skywalking 6.4.0, thanks.
@DarthRevanXX The new helm3 chart for 6.3.0 is there already.

thanks guys

Trying with helm 2 but getting Error: failed to download "skywalking" (hint: running helm repo update may help). Tried to run helm repo update but no help

helm search skywalking
No results found

Again, there is no helm chart in helm official repo.

You need to use local helm chart.

Ok, sorry

when i use the repo:https://github.com/apache/skywalking-kubernetes/blob/master/README.md
i meet a problem when execute command:"helm dep up skywalking",
the response is "No requirements found in /root/skywalking-kubernetes/chart/skywalking/charts."
how to fix it?

You should pick up "helm 3" instead of "helm 2"
Alen King<EMAIL_ADDRESS>于2019年12月30日周一 下午3:00写道：

when i use the repo:
https://github.com/apache/skywalking-kubernetes/blob/master/README.md
i meet a problem when execute command:"helm dep up skywalking",
the response is "No requirements found in
/root/skywalking-kubernetes/chart/skywalking/charts."
how to fix it?
—
You are receiving this because you were assigned.
Reply to this email directly, view it on GitHub
https://github.com/apache/skywalking/issues/3559?email_source=notifications&email_token=AAO6UWIIW2GCUC6SG5J2GADQ3GL77A5CNFSM4I5MPV32YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEHZWL7A#issuecomment-569599484,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AAO6UWKRZJKYYP35KHKQBSTQ3GL77ANCNFSM4I5MPV3Q
.

--
Hongtao Gao
Apache SkyWalking && Apache ShardingSphere
Twitter, @hanahmily


Protected routes support out of the box.

I have a question / feature request.
Would you guys be open to add protected routes (accessible only for authenticated users) to react-router
I would imagine the interface to look more or less like this:
<Router
  isAuthenticated={true}
  redirectUnauthenticatedTo="/login"
>
   <Login path="/login" />
   <Dashboard path="/Dashboard" protected/>
<Router>

If there is a chance of merging that in I would love to work on that.

We would rather stay agnostic to this sort of thing. There are many different ways to do authentication, and they often times would not work with this kind of API. Instead, we would like to leave it to other libraries or the user to implement something customized to their needs.

Ok thanks for the response.


OpenAI: TypeSpec representations of new Assistants streaming response models

There is an API breaking-ish change that we may want to address in this PR. For the uploadFile operation:
@post
@added(ServiceApiVersions.v2024_02_15_preview)
@route("/files")
op uploadFile(
  @header contentType: "multipart/form-data",
  @clientName("Data", "csharp") file: bytes,
  purpose: FilePurpose,

  /*
   * Spec note: filename is not documented as a distinct option but functionally should be one. The value is encoded
   *            in the multipart Content-Disposition header for the data section and can be provided independently of
   *            any specific data source like a file. It can be inferred in some circumstances (as when using direct
   *            file input, like curl does) but should remain configurable when using a stream or other data source
   *            lacking an a priori name.
   */
  filename: string,
): OpenAIFile;

the filename has actually turned into mandatory 🤔

A couple more models that I noticed while doing streaming stuff: https://github.com/Azure/azure-rest-api-specs/pull/28864


Updated CLI option validation to handle dependent options with multiple main options.

Signed-off-by: Mark Terry<EMAIL_ADDRESS>

PR description
Updates the dependent CLI option validation to handle options that can be dependent on multiple main options.
Fixed Issue(s)
Fixes #2038.
Changelog

[x] I thought about the changelog and included a changelog update if required.

New output looks like:

Message updated to:


refactor: remove unnecessary parentheses

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.


Feature request: Enhance GeneInfo Aesthetics

Description
Improve the aesthetics of the GeneInfo component by adding visual cues like colors, rounding values, and more.
Tasks

[x] Design a more visually appealing layout for GeneInfo.
[x] Add color coding based on value thresholds.
[x] Implement formatting for numerical values.

Acceptance Criteria

The GeneInfo component is more engaging and easier to interpret.
Colors and formatting add clarity to the data presentation.

closed by #a8d12fb281eb4d790b9f3f467cc858731afbf529


Find a better way how to maintain the compatibility with the list of magic numbers from CPython

I can imagine some kind of range for each Python version but I'm afraid that it might end up identifying pure marshal files as pyc files.
I have to investigate whether some kind of random conflict might happen. If not, we can maintain future proof ranges of magic numbers for every supported Python version and adjust it when something important happens there and we won't have to release a new version after every change.

FTR: Python has a new magic number 3434 and MarshalParser has been already ready.

Commit https://github.com/python/cpython/commit/fcb55c0037baab6f98f91ee38ce84b6f874f034a introduces new magic number 3435 which we already have here.

3436 added and we are still fine here.

3437 added in https://github.com/python/cpython/commit/b0544ba77cf86074fb1adde00558c67ca75eeea1 if they increase it once more, we'd need to release a new version.


Close NERDTree on all open tabs?

Self-Diagnosis

[x] I have searched the issues for an answer to my question.
[x] I have reviewed the NERDTree documentation. :h NERDTree
[x] I have reviewed the Wiki.
[x] I have searched the web for an answer to my question.

State Your Question
Hi, I'm trying to find a way to auto close every NERDTree istances on the current vim session before closing it. I've looked around and I didn't found anything relevant to the topic. Something like NERDTreeTabsClose which came from https://github.com/jistr/vim-nerdtree-tabs. Unfortunately it appears to be a dead NERDTree plugin so I'm looking for a fresh way to achieve that. I don't actually know if this is achievable with NERDTree commands only so I'm asking here if someone have a little hack for it. Thanks in advance.

This command will do it for you. Work it into the suggested autocmd in the README.
:tabdo NERDTreeClose


About Comments

Pls Sir Help To Solve this Problem you know in the previous Issue I have text you that I am getting an error these are below in the image

Below having our code which I am copied as yours on GitHub pls help me to get rid of these problems sir you are saying add comments && in these code for exists the array pls help me below having our code...
Comments.js
import { Stack, Typography } from "@mui/material";
import { Box } from "@mui/system";
import React, { useEffect, useState } from "react";
import Comment from "./Comment";
import Loading from "./Loading";
import { getComments } from "../api/Comment";
import { useParams } from "react-router-dom";
import CommentEditor from "./CommentEditor";
const Comments = () => {
  const [comments, setComments] = useState(null);
  const [rerender, setRerender] = useState(false);
  const [error, setError] = useState("");
  const [loading, setLoading] = useState(false);
  const params = useParams();
  const fetchComments = async () => {
    const data = await getComments(params);
    if (data.error) {
      setError("Failed to fetch comments");
    } else {
      setComments(data);
    }
  };
  useEffect(() => {
    fetchComments();
  }, []);
  const findComment = (id) => {
    const recurse = (comment, id) => {
      if (comment._id === id) {
        return comment;
      } else {
        for (let i = 0; i < comment.children.length; i++) {
          const commentToSearch = comment.children[i];
          return recurse(commentToSearch, id);
        }
      }
    };
    for (let i = 0; i < comments.length; i++) {
      const comment = comments[i];
      const returnedComment = recurse(comment, id);
      if (returnedComment) {
        return returnedComment;
      }
    }
  };
  const removeComment = (removedComment) => {
    if (removedComment.parent) {
      const parentComment = findComment(removedComment.parent);
      parentComment.children = parentComment.children.filter(
        (comment) => comment._id !== removedComment._id
      );
      setRerender(!rerender);
    } else {
      setComments(
        comments.filter((comment) => comment._id !== removedComment._id)
      );
    }
  };
  const editComment = (editedComment) => {
    if (editedComment.parent) {
      let parentComment = findComment(editedComment.parent);
      for (let i = 0; i < parentComment.children.length; i++) {
        if (parentComment.children[i]._id === editedComment._id) {
          parentComment.children[i] = editedComment;
        }
      }
    } else {
      for (let i = 0; i < comments.length; i++) {
        if (comments[i]._id === editedComment._id) {
          comments[i] = editedComment;
        }
      }
      setRerender(!rerender);
    }
  };
  const addComment = (comment) => {
    if (comment.parent) {
      const parentComment = findComment(comment.parent);
      parentComment.children = [comment, ...parentComment.children];
      setRerender(!rerender);
    } else {
      setComments([comment, ...comments]);
    }
  };
  return comments ? (
    <Stack spacing={2}>
      <CommentEditor
        addComment={addComment}
        label="What are your thoughts on this post?"
      />
      {comments.length > 0 ? (
        <Box pb={4}>
          {comments.map((comment) => (
              <Comment
                addComment={addComment}
                removeComment={removeComment}
                editComment={editComment}
                comment={comment}
                key={comment._id}
                depth={0}
              />
            )
          )}
          {loading && <Loading />}
        </Box>
      ) : (
        <Box
          display="flex"
          justifyContent="center"
          textAlign="center"
          paddingY={3}
        >
          <Box>
            <Typography variant="h5" color="text.secondary" gutterBottom>
              No comments yet...
            </Typography>
            <Typography variant="body" color="text.secondary">
              Be the first one to comment!
            </Typography>
          </Box>
        </Box>
      )}
    </Stack>
  ) : (
    <Loading label="Loading comments" />
  );
};
export default Comments;

Pls sir where should I write comments && in the above code

or Anyone Know These Problem Solutions pls tell me

Pls Sir

Please console.log the value of comments and tell me the value


test: refactor functional test script

Description:
Commit Message
test: refactor functional test script

see the guidelines for commit messages.
Checklist:

[x] I have performed a self-review of my own code
[x] I have documented my code in accordance with the documentation guidelines
[x] My changes generate no new warnings
[ ] I have added tests that prove my fix is effective or that my feature works
[ ] I have run the unit tests
[ ] I only have one commit (if not, squash them into one commit).
[x] I have a descriptive commit message that adheres to the commit message guidelines

Please review the CONTRIBUTING.md file for detailed contributing guidelines.

Removed unnecessary variable declarations and added bin path to one of the test case which would fail or else in workflow


When selecting a row for later use, the row height should not change

Hey team! Please add your planning poker estimate with ZenHub @adulbrich @bogdanromanx @imsdu @nicwells @samuel-kerrien @smitfire @Stafeeva @wwajerowicz


Allow to use custom file systems

Might be helpful with tools like Angular Schematics, Webpack plugins etc

Closing, I don't think we need it for now :)