Single Xml Nodes can be fetched as single XmlNode, CDATA nodes as string

Single xmlNode objects are now fetched as single objects (not
XmlNodeLists) when they stand alone.  Previously this was only available
to nodes that contained text.
CDATA nodes also treated as text nodes.
Some small refactoring of Xml ValueGetter because of confusing naming
of fields and methods
tets for above added

Hey,
This was released in Nustache v<IP_ADDRESS>. Thank you for your contribution!


OpenCV Native libraries could not be loaded

I am using 2017.2.3. I have redeployed and reimaged.
OpenCV Native Libraries could not be loaded.
Please try redeploying, or reimage your roboRIO and try again.
java.lang.UnsatisfiedLinkError: no opencv_java320 in java.library.path
	at java.lang.ClassLoader.loadLibrary(ClassLoader.java:1857)
	at java.lang.Runtime.loadLibrary0(Runtime.java:870)
	at java.lang.System.loadLibrary(System.java:1119)
	at edu.wpi.first.wpilibj.RobotBase.initializeHardwareConfiguration(RobotBase.java:181)
	at edu.wpi.first.wpilibj.RobotBase.main(RobotBase.java:194)
********** Robot program starting **********
Error at edu.wpi.first.wpilibj.RobotBase.main(RobotBase.java:249): ERROR Unhandled exception: java.lang.NullPointerException at [org.usfirst.frc.team1018.lib.util.MultipleJoystickButton.<init>(MultipleJoystickButton.java:15), org.usfirst.frc.team1018.robot.OI.<init>(OI.java:24), org.usfirst.frc.team1018.robot.OI.getInstance(OI.java:51), org.usfirst.frc.team1018.robot.Robot.robotInit(Robot.java:47), edu.wpi.first.wpilibj.IterativeRobot.startCompetition(IterativeRobot.java:64), edu.wpi.first.wpilibj.RobotBase.main(RobotBase.java:247)]
WARNING: Robots don't quit!
---> The startCompetition() method (or methods called by it) should have handled the exception above.
NT: server: client CONNECTED: <IP_ADDRESS> port 56381

Edit: I just realized the error after "Robot program starting" is mine, I'm referring to the one above it.

Looks like I'm missing a path. I'll take a deeper look soon
Note to self: check /usr/local/frc/lib, opencv_java320 might be deploying to the linux subdirectory

Looks like WPI changed where libopencv_.so is stored inside the jar. Use OpenCV 3.1.0 and GradleRIO 2017.1.5 for now, since there's a new version of GradleRIO queued that will be rewritten, so I'll change this behavior while I'm at it

Just to clarify, I have to declare the OpenCV version explicitly in my build.gradle, correct?

Yes, in your build.gradle:
wpi {
    opencvVersion = "3.1.0"
}

replying to be notified when this gets fixed

Noah, is the above 3.1.0 fix working, or is there another fix that is required to be more urgent?

Using 1.3.0 is working great, I just want to know when I can switch.

I'm going to bump real quick for when I take a look at this issue in the newer releases.
It may be possible to make 3.1.0 and 3.2.0 both work in the same plugin version, given some clever version checking. For <=3.1.0, the artifact is opencv-jni-VERS-linux-arm, while from 3.2.0 onwards it is opencv-jni-VERS-linuxathena

This should be fixed now. 2017.10.30 for 2017, 2018-beta-2c for 2018 beta

Hmm. Possibly unrelated, but while using 2017.10.30 attempting to set exposure on a USB camera with setExposureAuto() is throwing a VisionException. This wasn't happening before today, which makes me think there's tickery afoot on Gradle's end. I've tried manually setting opencvVersion to  "3.1.0" in the wpi block (right after the deploy one.)

Would the OpenCV version affect that? If I'm not mistaken, USBCamera is part of cscore which is part of wpilib.

I believe that's a cscore thing. Send me your stacktrace (gradlew clean build --stacktrace) and I'll see where this issue lays

Clean build doesn't spit out any stacktrace, just the normal Gradle log (command: ./gradlew clean build --stacktrace):
Picked up _JAVA_OPTIONS: -Dawt.useSystemAAFontSettings=on -Dswing.aatext=true -Dswing.defaultlaf=com.sun.java.swing.plaf.gtk.GTKLookAndFeel
Starting a Gradle Daemon, 1 stopped Daemon could not be reused, use --status for details
:clean
:compileJava
:processResources NO-SOURCE
:classes
:jar
:assemble
:compileTestJava NO-SOURCE
:processTestResources NO-SOURCE
:testClasses UP-TO-DATE
:test NO-SOURCE
:check UP-TO-DATE
:build

BUILD SUCCESSFUL in 16s
3 actionable tasks: 3 executed

I don't have the robot with me at this exact moment, but I can get the trace from the actual code crash when I do (should been soon:tm:.)

Here's the trace from the DS. I'll see if there's a more detailed version available in the RIOlog (RIO log?)
In case it's relevant, here's our Robot.java as well. This version is from before we started with GradleRIO, but there hasn't been any changes to the cameras in code since then (just what debug info goes to the SmartDashboard I believe.)

Since there's been a lot of recent updates, OpenCV bindings should be fixed now, at least in the beta branch. Feel free to reopen if it's still failing


Add appveyor support and fix issues on Windows

fixes #233
This PR adds support to run tests for Windows platform on appveyor and fixes the issues related to paths and URIs handling on windows.
Using pathname2url while transforming a path to an URI ensures that on windows paths are correctly formatted while on linux and mac the function looks like a no-op.
There are 2 tests modifications:

tests/acceptance/relative_ref_test.py::test_dereferenced_swagger_schema_retrieval: this is needed as bravado-core flattening produces a different swagger spec dict in case it runs on windows platform
tests/spec_test.py::test_proper_error_on_missing_api_declaration: this is needed as \ in the exception string is escaped and it's harder to regenerate the same string and keeping the test easy to read. The approach used was to check that directory name and file name are present on the exceptio

Tests pass on Windows: https://ci.appveyor.com/project/macisamuele/pyramid-swagger/build/1

Coverage increased (+0.003%) to 99.56% when pulling 348dab569ff2f6d1d65f73245218cefb630e7b56 on macisamuele:maci-add-appveyor-support into 13ffad40dcb5318f76e9266dec1cd4c7a13f6d6f on striglia:master.

Added the badge to the README and created https://ci.appveyor.com/project/striglia/pyramid-swagger for regular builds


[Improve] Add i18n support for system user menu.

Add i18n support for system user menu.

Thank you for your contribution. We have modified the i18 of the user and menu section. If you are interested, you can try to modify the i18n of the application module. We apologize for the inconvenience caused!


ShowDialog position on Retina OSX is wrong

Using ShowDialog with WindowStartupLocation as CenterOwner or CenterScreen displays it in the bottom right corner of the application instead
I believe it's the same issue as this? https://github.com/AvaloniaUI/Avalonia/pull/3018

Fixed.


['dvm']['user_installs'] not compatible with home folder located outside /home (Ubuntu Linux)

['dvm']['user_installs'] not compatible with home folder located outside /home (Ubuntu Linux)
Error:
* template[/home//var/lib/dashing/.rvmrc] action create[2014-08-10T00:10:21+00:00] INFO: Processing template[/home//var/lib/dashing/.rvmrc] action create (rvm::user_install line 145)
* Parent directory /home//var/lib/dashing does not exist.
================================================================================
Error executing action `create` on resource 'template[/home//var/lib/dashing/.rvmrc]'
================================================================================

Dup #207


options issue

Hello, I found the config options is not working.
It seems like the option has been missed in the js, Because after I use the code from the left column of this, the options is working.(But the table is not defined)
Thank for the plugin, it's the only one wysiwyg plugin I can use.

#25
Try the newest VueJS and vue-wysiwyg. Could be the fix. Worked for me.

I update VueJS, Vue-cli, and vue-wysiwyg.
It looks the same.
And when I clicked the toolbar btn, the dashboard is flash.

My Config is:
import wysiwyg from "vue-wysiwyg";
import "vue-wysiwyg/dist/vueWysiwyg.css";
Vue.use(wysiwyg, {
hideModules: {
headings: true
}
});
It works at my project. maybe you did not include it right oder a typo?

My confusion is that when I replace the code 'node_modules/vue-wysiwyg/dist/vueWysiwyg.js' with the code in #15 ,it is successful.

This is a duplicate of #30, and #30 is now fixed :tada:


Themis Android crashes on devices with 16 KB page size

Describe the bug
Themis Android crashes on devices with 16 KB page size.
To Reproduce
Steps to reproduce the behavior:

Create a virtual device with Android 15 and 16KB page size
Run docs/examples/android app on the created virtual device
App crashes

Expected behavior
App runs without a crash
Environment (please complete the following information):

OS: Android 15
Hardware: ARM 64-bit 16KB page size
Themis version: 0.15.2
Installation way:

built from source

Additional context
According to https://developer.android.com/guide/practices/page-sizes#compile-r26-lower a line:
target_link_options(themis_jni PRIVATE "-Wl,-z,max-page-size=16384")

should be added to the file:
jni/CMakeLists.txt

oh wow thank you @lehandriel
We will take a look and update CMakeLists and try to repack the build

i've prepared a potential pr bases on google requirements:
https://github.com/cossacklabs/themis/pull/1051

@vixentael do you plan to release a new version of themis-android containing this fix any time soon? :)

We updated themis-android on GitHub and in the Maven repository.
You may try to set dependency as
implementation 'com.cossacklabs.com:themis:0.15.5'

@lehandriel please try the updated Themis and let us know if it works for you!

@radetsky @vixentael works like a charm 👍 thanks! 🙂

@radetsky @vixentael works like a charm 👍 thanks! 🙂

thank you @lehandriel for opening an issue and suggesting a fix!
thank you @radetsky for checking the fix, updating the example app, and releasing the updated Themis lib


Combined AspId and EFStorage -- deprecated

Hi
What was the reason for deprecating these ?

maintenance cost

The IdS 4 + ASP.NET Identity + EF Core combo is still going to be the stack of choice for a lot of enterprise projects moving forward; will there be any guidance on this at all? E.g. documentation.
Or is it a case of, if you're using that particular stack, you're on your own.

I agree. But we only so many hours a week to work on free stuff.
EF nor ASP.NET Identity is not really IdentityServer related. But we do consulting if "enterprises" need help.


Add astefanutti to org members and distributed workloads maintainers

Description
Add astefanutti to organization members and distributed workloads maintainers.

@anishasthana @accorvin FYI.

/approve


Improve encoding performance

Most of the perfomance benefits come from converting properties into normal attributes. Each property call results in a new stack frame which is quite expensive.
Benchmarks with some random message on my laptop:
message.encode(data, strict=True, scaling=True): 49.19% improvement
message.encode(data, strict=False, scaling=True): 22.98% improvement
message.encode(data, strict=False, scaling=False): 60.74% improvement
This is the code i used for benchmarking:
import timeit

setup = """
import cantools
db = cantools.db.load_file("path_to_OEM_dbc")

message = db.get_message_by_name("OEM_message_name")
data = {signal.name: min(0x40, signal.maximum-1) for signal in message.signals}
"""

print(min(timeit.Timer('message.encode(data, strict=False, scaling=False)', setup=setup).repeat(100, 1000)))

Here is a cProfile dump for 10000 encode calls of the master branch (strict=False, scaling=True):
         2570002 function calls in 0.762 seconds

   Ordered by: cumulative time

   ncalls  tottime  percall  cumtime  percall filename:lineno(function)
    10000    0.013    0.000    0.758    0.000 message.py:863(encode)
    10000    0.009    0.000    0.740    0.000 message.py:759(_encode)
    10000    0.015    0.000    0.731    0.000 utils.py:88(encode_data)
    10000    0.077    0.000    0.706    0.000 utils.py:92(<dictcomp>)
   270000    0.493    0.000    0.614    0.000 utils.py:51(_encode_field)
   540000    0.032    0.000    0.032    0.000 {built-in method builtins.isinstance}
   540000    0.031    0.000    0.031    0.000 signal.py:249(name)
   270000    0.023    0.000    0.023    0.000 {method 'to_integral' of 'decimal.Decimal' objects}
   270000    0.018    0.000    0.018    0.000 signal.py:359(offset)
   270000    0.016    0.000    0.016    0.000 signal.py:347(scale)
   270000    0.016    0.000    0.016    0.000 signal.py:311(is_float)
    20000    0.006    0.000    0.006    0.000 {method 'pack' of 'bitstruct.c.CompiledFormatDict' objects}
    20000    0.003    0.000    0.003    0.000 {built-in method binascii.hexlify}
    10000    0.002    0.000    0.002    0.000 {built-in method builtins.hex}
    10000    0.001    0.000    0.001    0.000 {built-in method binascii.unhexlify}
    10000    0.001    0.000    0.001    0.000 {method 'rstrip' of 'str' objects}
    10000    0.001    0.000    0.001    0.000 message.py:323(is_container)
    10000    0.001    0.000    0.001    0.000 {built-in method builtins.len}
    10000    0.001    0.000    0.001    0.000 typing.py:898(cast)

And here is the same with my changes:
         660002 function calls in 0.412 seconds

   Ordered by: cumulative time

   ncalls  tottime  percall  cumtime  percall filename:lineno(function)
    10000    0.007    0.000    0.409    0.000 message.py:859(encode)
    10000    0.007    0.000    0.399    0.000 message.py:755(_encode)
    10000    0.009    0.000    0.392    0.000 utils.py:99(encode_data)
    10000    0.338    0.000    0.375    0.000 utils.py:51(_encode_fields)
   270000    0.020    0.000    0.020    0.000 {method 'to_integral_value' of 'decimal.Decimal' objects}
   270000    0.017    0.000    0.017    0.000 {built-in method builtins.isinstance}
    20000    0.005    0.000    0.005    0.000 {method 'pack' of 'bitstruct.c.CompiledFormatDict' objects}
    20000    0.002    0.000    0.002    0.000 {built-in method from_bytes}
    10000    0.001    0.000    0.001    0.000 {method 'to_bytes' of 'int' objects}
    10000    0.001    0.000    0.001    0.000 message.py:323(is_container)
    10000    0.001    0.000    0.001    0.000 {built-in method builtins.len}
    10000    0.000    0.000    0.000    0.000 typing.py:898(cast)

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

46 of 48 (95.83%)  changed or added relevant lines in 4 files are covered.
127 unchanged lines in 16 files lost coverage.
Overall coverage decreased (-1.9%) to 92.713%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

cantools/database/utils.py
31
33
93.94%

Files with Coverage Reduction
New Missed Lines
%

cantools/database/diagnostics/database.py
1
93.62%

cantools/database/can/signal.py
2
96.0%

cantools/database/can/attribute.py
4
77.78%

cantools/database/can/formats/arxml.py
5
93.95%

cantools/database/can/formats/dbc.py
5
98.42%

cantools/database/can/message.py
6
91.37%

cantools/database/can/node.py
6
78.0%

cantools/database/can/signal_group.py
6
72.0%

cantools/logreader.py
6
92.45%

cantools/database/can/bus.py
7
73.68%

Totals

Change from base Build<PHONE_NUMBER>:
-1.9%

Covered Lines:
6514

Relevant Lines:
7026

💛  - Coveralls

There is another bottleneck in _encode_fields but changing this would lead to a few failing tests:
Replacing this
                    decimal = (Decimal(value) - Decimal(field.offset)) / Decimal(field.scale)
                    unpacked[field.name] = int(decimal.to_integral_value())

with
                    unpacked[field.name] = int((value - field.offset) / field.scale + 0.5)

results in
         390002 function calls in 0.139 seconds

   Ordered by: cumulative time

   ncalls  tottime  percall  cumtime  percall filename:lineno(function)
    10000    0.007    0.000    0.137    0.000 message.py:859(encode)
    10000    0.006    0.000    0.127    0.000 message.py:755(_encode)
    10000    0.009    0.000    0.122    0.000 utils.py:98(encode_data)
    10000    0.092    0.000    0.106    0.000 utils.py:51(_encode_fields)
   270000    0.015    0.000    0.015    0.000 {built-in method builtins.isinstance}
    20000    0.004    0.000    0.004    0.000 {method 'pack' of 'bitstruct.c.CompiledFormatDict' objects}
    20000    0.002    0.000    0.002    0.000 {built-in method from_bytes}
    10000    0.001    0.000    0.001    0.000 {method 'to_bytes' of 'int' objects}
    10000    0.001    0.000    0.001    0.000 message.py:323(is_container)
    10000    0.000    0.000    0.000    0.000 typing.py:898(cast)
    10000    0.000    0.000    0.000    0.000 {built-in method builtins.len}

For huge values the resulting raw value can be off by one. But i'd say that is acceptable.

I also edited the decoder code a little.
Here is the profile from before #427 (i introduced a major performance regression by using TypeGuard inside _decode_field)
         1510000 function calls in 0.316 seconds

   Ordered by: cumulative time

   ncalls  tottime  percall  cumtime  percall filename:lineno(function)
    10000    0.004    0.000    0.313    0.000 message.py:1054(decode)
    10000    0.005    0.000    0.307    0.000 message.py:943(_decode)
    10000    0.011    0.000    0.303    0.000 utils.py:101(decode_data)
    10000    0.105    0.000    0.278    0.000 utils.py:110(<dictcomp>)
   270000    0.101    0.000    0.145    0.000 utils.py:65(_decode_field)
   540000    0.029    0.000    0.029    0.000 signal.py:249(name)
    70000    0.011    0.000    0.016    0.000 utils.py:74(<lambda>)
   270000    0.015    0.000    0.015    0.000 signal.py:422(choices)
    20000    0.009    0.000    0.009    0.000 {method 'unpack' of 'bitstruct.c.CompiledFormatDict' objects}
    80000    0.005    0.000    0.005    0.000 signal.py:347(scale)
    10000    0.005    0.000    0.005    0.000 {method 'update' of 'dict' objects}
    70000    0.004    0.000    0.004    0.000 signal.py:359(offset)
    80000    0.004    0.000    0.004    0.000 {built-in method builtins.isinstance}
    40000    0.003    0.000    0.003    0.000 signal.py:311(is_float)
    10000    0.001    0.000    0.001    0.000 {method 'is_integer' of 'float' objects}
    10000    0.001    0.000    0.001    0.000 message.py:329(is_container)

And here is the profile of this PR:
         60000 function calls in 0.070 seconds

   Ordered by: cumulative time

   ncalls  tottime  percall  cumtime  percall filename:lineno(function)
    10000    0.004    0.000    0.067    0.000 message.py:1040(decode)
    10000    0.003    0.000    0.062    0.000 message.py:929(_decode)
    10000    0.051    0.000    0.059    0.000 utils.py:96(decode_data)
    20000    0.008    0.000    0.008    0.000 {method 'unpack' of 'bitstruct.c.CompiledFormatDict' objects}
    10000    0.001    0.000    0.001    0.000 message.py:323(is_container)

I'm happy with this now. You too, @juleq?

What do you think about replacing (Decimal(value) - Decimal(field.offset)) / Decimal(field.scale)?
I'm wondering why this is the default. What is the use case for this? AFAIK no ECU would use decimals for encoding CAN messages.

What do you think about replacing (Decimal(value) - Decimal(field.offset)) / Decimal(field.scale)?

As long as the differences due to replacing it are minor, I'm happy to sacrifice it on the altar of performance. (Since this construct predates my time with cantools, I can also only speculate why it was done that way. My money is on not even theoretically running into precision issues...)

Yes, I think this was it. It was not only this line, but internal storage of non-ints and other code parts, too. Because there is no guarantee for an exact representation in DP, your alternative option would be to be very consistent in your rounding/formatting/comparison. Can of worms :).

your alternative option would be to still use DP but be very consistent in your rounding/formatting/comparisons. Can of worms :).

I see. do you think that adding a set of floating point attributes for de-/encoding besides the Decimal ones would be feasible? i.e., the  decimal ones would be used for dumping the files, while the floating point ones for everything else?

But the encode function does not influence a database dump.
Yes, thats true. Either the contributor did that for consistency with changes related to load/dump or maybe encode/decode roundtrip was a concern. Or inference of underlying number type. It is nice to retain the underlying integer type when scaling and offset would in principle allow for that. But as @andlaus mentioned, considering the signal type and some rounding strategy would also do that. Maybe the contributor had something to say in his commit for that line?
I think some rounding error is to be expected when the user sets scaling=True, at least for anyone who is familiar with floating point data types. The decode function also just uses regular floats.
Also true. It is kind of being the unicorn when probably every other tool will probably top out at DP precision and call it a day. And that decode does not stick to this strategy speaks against the encode/decode roundtrip hypothesis.

Not sure how to proceed. Whats the performance gain? Would it be worth a shot?

Not sure how to proceed.

I recommend merging this PR (#428) and leave the better decode performance for a later one. (If I understood this correctly, that's an orthogonal issue...)

Removing decimal scaling reduces encoding time by 70% compared to this PR

does that mean that decoding gets faster by a factor of more than 3, or "only" by factor ~1.7?

The decoding changes are actually already in this PR

okay, I missed that somehow g. If @juleq considers this change to be too risky to do in one swoop, would do mind factoring it out and make a separate pull request for it?

does that mean that decoding gets faster by a factor of more than 3, or "only" by factor ~1.7?

For encoding it is factor 3.3 compared to this PR (factor 4.6 compared to master) with strict=False, scaling=True. Decimal scaling is only used for encoding, so removing it has no impact on decoding.
But i measured this on one message only. Numbers may vary for other messages.

okay, I missed that somehow g. If @juleq considers this change to be too risky to do in one swoop, would do mind factoring it out and make a separate pull request for it?

Yeah i could.

@zariiii9003: we're always looking to expand the number of maintainers for cantools. If you're interested, drop me an email. (I couldn't figure out how to get in contact with you directly...)


update docs links to mongodb docs

@mhor thanks a bunch for going through all the links! There's one change I'd like to see before merging though (please see comment above), would you mind ammending your commit with it?

Thank you @mhor!


App Bar on mobile has no way to navigate home

Maybe keep logo in center, and have a search icon that pops up with the full search bar and genome switch

Link put in hamburger menu for now


alias failing to work. no id for alias

on adding a alias with mysql database it would not save or implement.
on the alias screen the alias would not have a id number.
alias mysql fix.txt
VK6 pagermon log.txt
yea i know i am not good at this

Should be fixed in 0.3.2


[$1000] Web - Chat - Hover effect lost after opening popover again before closing it.

If you haven’t already, check out our contributing guidelines for onboarding and email<EMAIL_ADDRESS>to request to join our Slack channel!

Action Performed:

Go to any chat
Open the pop over right clicking
Move the pointer to the left or the right and right click again.

Expected Result:
The hover effect is present
Actual Result:
The hover effect is lost
Workaround:
Unknown
Platforms:

Which of our officially supported platforms is this issue occurring on?

[ ] Android / native
[ ] Android / Chrome
[ ] iOS / native
[ ] iOS / Safari
[x] MacOS / Chrome / Safari
[ ] MacOS / Desktop

Version Number: v1.3.55-7
Reproducible in staging?: Y
Reproducible in production?: Y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation
https://github.com/Expensify/App/assets/115492554/992b7225-c2ed-4660-a46e-830c2f9a0498
https://github.com/Expensify/App/assets/115492554/ba2a8cb1-0b08-4871-b0e4-fa1b8dc8a81f
Expensify/Expensify Issue URL:
Issue reported by: @getusha
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1691745427354299
View all open jobs on GitHub
Upwork Automation - Do Not Edit

Upwork Job URL: https://www.upwork.com/jobs/~01c432588dbb79d8dd
Upwork Job ID:<PHONE_NUMBER>574693376
Last Price Increase: 2023-09-11

Proposal
Please re-state the problem that we are trying to solve in this issue.
Hover effect lost after opening context menu popover again before closing the opened one.
What is the root cause of that problem?
We are passing toggleContextMenuFromActiveReportAction as onHide argument, which will make the isContextMenuActive false, currently we are passing empty function to be triggered for onShow param.
https://github.com/Expensify/App/blob/4a7558cdfea721e58675b2e1d1f9ba25a2fd9e31/src/pages/home/report/ContextMenu/ReportActionContextMenu.js#L59-L60
https://github.com/Expensify/App/blob/4a7558cdfea721e58675b2e1d1f9ba25a2fd9e31/src/pages/home/report/ReportActionItem.js#L226-L227
when we set isContextMenuActive to true here, when the previous context menu closes it will replace our true value with false. because onHide is triggered after the new isContextMenuActive update.
What changes do you think we should make in order to solve the problem?

We should set isContextMenuActive to true onShow instead of calling it here:
https://github.com/Expensify/App/blob/4a7558cdfea721e58675b2e1d1f9ba25a2fd9e31/src/pages/home/report/ReportActionItem.js#L215
We should move setIsContextMenuActive to here, to be triggered onShow after onHide is called. this will insure it has the updated value.
https://github.com/Expensify/App/blob/4a7558cdfea721e58675b2e1d1f9ba25a2fd9e31/src/pages/home/report/ReportActionItem.js#L226-L226
() => setIsContextMenuActive(true),

What alternative solutions did you explore? (Optional)

onHide is triggered after the new isContextMenuActive update
@getusha I am about to propose the same solution but just wanted to understand the above point.

@Pujan92
https://github.com/Expensify/App/blob/4a7558cdfea721e58675b2e1d1f9ba25a2fd9e31/src/pages/home/report/ReportActionItem.js#L215
after the above update onHide will be triggered for the previous context menu then the new popover shows right? Once the onHide function is triggered, it will set the state to false, overriding the updated value which was set before opening the popover.

@aimane-chnaif i have a proposal here

@abdulrahuman5196 can you please review the proposals?

Apologies for the delay. Will check and update soon

@abdulrahuman5196 any updates on your checks?

Sorry folks for the delay. Will test on mobile and update sooner.

I'm not actually able to reproduce this issue anymore. The hover effect is no longer lost.

Issue not reproducible during KI retests. (First week)

Still able to reproduce.

@abdulrahuman5196 any updates?

@tjferriss the issue still happens (tested on main)
Screen.Recording.2023-09-13.at.12.05.27.mov

I think this is different issue than what this issue was initially created for. The initial issue is not reproducible anymore.
But this seems to be a related issue. If its fine we can convert this issue to make sure only the message with context menu is highlighted. If that is the experience we want @tjferriss

@abdulrahuman5196 please refer to this comment https://github.com/Expensify/App/pull/24515#discussion_r1300623349
https://github.com/Expensify/App/assets/75031127/dde8a1c9-9dc6-467c-84a6-9cf9232d1658

I'm going to close this issue out as I don't view this hover effect as a bug, but as intended.

@trjExpensify the hover effect is being lost when you move the mouse out but not the first time.

Sounds like this should be reopened according to these comments - https://github.com/Expensify/App/issues/27578#issuecomment-1722479126

Moving my proposal here from #27578
Proposal
Please re-state the problem that we are trying to solve in this issue.
We are solving the problem of app removing background color from message when we again right click on same message to open popover
What is the root cause of that problem?
Currently we use IsContextMenuActive boolean value in ReportActionItem.js to check if any action was done on current message and it is used to also set background color for the message. We set the boolean value as true first in showPopover and then reset the value to false for previous message using toggleContextMenuFromActiveReportAction in showContextMenu function call in same showPopover function.
Because of this, if we right click on same message, we set the IsContextMenuActive true for that message but since previous message too was same, we set IsContextMenuActive false again for it causing the issue.
What changes do you think we should make in order to solve the problem?
We will need to change the position of setIsContextMenuActive function to the end of showPopover, it will ensure that previous selected message IsContextMenuActive is set to false and current selected message IsContextMenuActive is set to true later on avoiding the current issue.
We can do that by removing this line from here
setIsContextMenuActive(true);

and adding it below this line
What alternative solutions did you explore? (Optional)

the hover effect is being lost when you move the mouse out but not the first time.

@getusha thanks for the description. I see it now. @abdulrahuman5196 what do you think of the proposals?

Reviewing now

@abdulrahuman5196 have you had a chance to review the proposals?

@getusha 's proposal here https://github.com/Expensify/App/issues/25582#issuecomment-1686470940 looks good and works well. Tested on other platforms as well and it works fine.
🎀 👀 🎀
C+ Reviewed

@abdulrahuman5196 have you checked carefully the issues I mentioned on the small screen?

@bernhardoj yes. Couldn't find any. Let me know if you still find any.

@bernhardoj that can be fixed if necessary, can you just apply the following diff without removing setIsContextMenuActive(true) and see if the issue persists?
Diff
diff --git a/src/pages/home/report/ReportActionItem.js b/src/pages/home/report/ReportActionItem.js
index fe1dcf248f..96e9a6d52f 100644
--- a/src/pages/home/report/ReportActionItem.js
+++ b/src/pages/home/report/ReportActionItem.js
@@ -247,7 +247,7 @@ function ReportActionItem(props) {
                 props.action.reportActionID,
                 originalReportID,
                 props.draftMessage,
-                () => {},
+                () => setIsContextMenuActive(true),
                 toggleContextMenuFromActiveReportAction,
                 ReportUtils.isArchivedRoom(originalReport),
                 ReportUtils.chatIncludesChronos(originalReport),

@bernhardoj this is a straight forward issue with minor change and all of the proposals are similar. i'll also leave the final call for @abdulrahuman5196 @pecanoro

IMO I don't think its an issue. It just acts as an extra check.
I am still aligned towards the approved solution.

@aimane-chnaif I still can reproduce on main!
Assigning @getusha to the issue

@abdulrahuman5196 can I have some feedback on my proposal here? I think it better addresses the root cause, and it's different from the selected proposal

I think that the proposal was fine. I choose based on the simplest solution to achieve the expected result without any regression or long term losses.

@abdulrahuman5196 @pecanoro the PR is ready!

The PR that introduced the bug has been identified. Link to the PR:
The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:

Doesn't seem to be a regression. This issue should be present from before.

Determine if we should create a regression test for this bug.

Yes.

If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.

Go to any chat
Open the pop over right clicking
Move the pointer to the left or the right and right click again.
Move the mouse out of the report item
Verify that the hover effect is not lost when the popover is opened

@tjferriss I received $50 offer for reporting bonus, i think it should be $250 since this issue was created before the announcement.

@tjferriss Friendly bump since this is waiting on you.

The payments have been sent via Upworks.


Missing Inter fonts in lara-*-blue themes

After downloading sakai-ng v.17 and unpacking it, it turns out that the Inter-roman and Inter-talic font files mentioned in layout/styles/theme/lara-light-blue/theme.css and layout/styles/theme/lara-dark-blue/theme.css do not exist:

I noticed the same thing today. The font (it seems) was never available as part of the code on GitHub. I downloaded the missing font(s) as needed based on my theme, and placed them in the expected location. My preference is generally never to version control static assets alongside the code, but inject them during build time - perhaps the devs do the same?


add hs with AMIP targeted resolution to longrun

PULL REQUEST
Purpose and Content
This PR adds high resolution hs simulations to longrun buildkite.
It sets up mpi with 128 tasks.
Benefits and Risks
(State concisely the benefits to be derived from and the risks associated with this PR)
Linked Issues
(Provide references to any link issues. Use closes #issuenum to automatically close an open issue)

Fixes #
Closes #

PR Checklist

[ ] This PR has a corresponding issue OR is linked to an SDI.
[ ] I have followed CliMA's codebase contribution and style guidelines OR N/A.
[ ] I have followed CliMA's documentation policy.
[ ] I have checked all issues and PRs and I certify that this PR does not duplicate an open PR.
[ ] I linted my code on my local machine prior to submission OR N/A.
[ ] Unit tests are included OR N/A.
[ ] Code used in an integration test OR N/A.
[ ] All tests ran successfully on my local machine OR N/A.
[ ] All classes, modules, and function contain docstrings OR N/A.
[ ] Documentation has been added/updated OR N/A.

I think it’s a good idea to add this in general, but there are some issues with the flags used. I’ll try to confirm the correct format today

Thanks! That's very helpful.

Maybe we can discuss this during the amip meeting today. The terminology is a bit confusing and we're running different parallelization models in different ways. It might be nice to document what works.

Maybe we can discuss this during the amip meeting today. The terminology is a bit confusing and we're running different parallelization models in different ways. It might be nice to document what works.

Yes, that will be helpful. Here I'm following comments in #660 which says
  agents: # works
    slurm_ntasks: 8
    slurm_ntasks_per_node: 8

Yes, that will be helpful. Here I'm following comments in #660 which says...

Yeah, but this is for running jobs with multiple threads, not multiple processors.

bors r+


Blank White Screen

I don't know what happened to my Tusk. After opened the app, Tusk just give me a white blank screen after sign in to my email

I have this problem too

+1


Expose clear_cache option

This pull-request is to fix https://github.com/ruby-json-schema/json-schema/issues/225

Travis is failing, after this change (not sure why this would cause it to fail however)

If we can figure out why the build is failing it gets my :+1:

Build is passing now, :+1:

Thanks @hoxworth . Merging...


QR code reader framework; manager authentication; manager gives badges

About the /random page: we realized we had saved space in the staff credentials for a QR code that wouldn't be needed.
Instead of completely redesigning the credential, we decided to have a bit of fun and add an Easter Egg:
The QR code in the staff and organization credentials directs the user to https://www.seium.org/random , which in turn redirects to a random meme from a list not so carefully chosen by the team.

By the way, please ignore the more crude look of the manager's badge giving page. It isn't supposed to be used on desktop at all, so it wasn't a priority

The navbar on the website as a link to Dashboard that does not work for managers.


Fix CIDR regex escaping characters

This checklist is used to make sure that common issues in a pull request are addressed. This will expedite the process of getting your pull request merged and avoid extra work on your part to fix issues discovered during the review process.
PR information

[ ] The title of the PR is clear and informative.
[ ] There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For information on cleaning up the commits in your pull request, see this page.
[ ] Except for special cases involving multiple contributors, the PR is started from a fork of the main repository, not a branch.
[ ] If applicable, the PR references the bug/issue that it fixes.
[ ] Swagger files are correctly named (e.g. the api-version in the path should match the api-version in the spec).

Quality of Swagger

[ ] I have read the contribution guidelines.
[ ] My spec meets the review criteria:

[ ] The spec conforms to the Swagger 2.0 specification.
[ ] The spec follows the guidelines described in the Swagger checklist document.
[ ] Validation tools were run on swagger spec(s) and have all been fixed in this PR.

Can one of the admins verify this patch?

Automation for azure-sdk-for-python

Fix is going to be done on autorest side.

Automation for azure-sdk-for-js

Automation for azure-sdk-for-node

Automation for azure-sdk-for-ruby

Automation for azure-sdk-for-java


[Docs]: Create a projects YAML reference page

Type
New content idea
What do you want to report?
Create a projects YAML reference page
Code of Conduct

[X] I agree to follow this project's Code of Conduct

Review link: https://storage.googleapis.com/sem-docs/main/index.html#/docs/reference/project-yaml


argparse.ArgumentError: argument --seed: conflicting option string: --seed

Thanks for sharing the code with us. I find an issue on this line.

@DanMS98   GOTURN is hard to train (I mean use other training datasets) and the results are very poor. I suggest you try other strong and fast trackers, such as DiMP, TransT, etc.

@wangxiao5791509 Thanks for the recommendations, but I'm using GOTURN as a part of my bachelor final project and I'm stuck with it. :smile:
Also, I found the issue if you are still interested. The argparser for seed was defined twice, I commented one of them and I was good to go. Also, I had to replace the view function with the reshape function. Except for these, I didn't have any other problem training it.


Played just one song and instance exited

Started the instance with
java -jar librespot-core-jar-with-dependencies.jar >info.log 2>&1 &
and played only 1 song, after the song ended, the instance exited.
Attaching the log for reference, latest version on spotify-new-api
info.log

This happened because the client can't apparently load an autoplay for search queries. The client will now simply pause.


[Bug]: expect URL objects are compared by href

Version
29.7.0
Steps to reproduce

create a test with URL objects like follows
run the test, you will see it passes

test('compare url', () => {
  expect(new URL('https://example.org')).toEqual(new URL('https://different-example.org'));
})

Expected behavior
I expect it fails.
Actual behavior
It passes actually.
Additional context
I created a test with toHaveBeenCalledWith to check URL object.
In this example, the test fails because it fails to find the difference in URL objects.
test('test with toHaveBeenCalledWith', async () => {
  jest.spyOn(window, 'fetch').mockImplementation(() => Promise.resolve(new Response('OK')));
  await fetch(new URL('https://example.org'));

  expect(fetch).not.toHaveBeenCalledWith(new URL('https://different-example.org'));
});

Result
expect(jest.fn()).not.toHaveBeenCalledWith(...expected)

Expected: not "https://different-example.org/"
Received:     0, ["https://example.org/"]

Number of calls: 1

  324 |        await fetch(new URL('https://example.org'))
  325 |
> 326 |   expect(fetch).not.toHaveBeenCalledWith(new URL('https://different-example.org'));
      |                     ^
  327 | })
  328 |

There is a same issue on Vitest which is already resolved https://github.com/vitest-dev/vitest/issues/4614. The same thing what I mentioned was suggested.
Environment
System:
  OS: macOS 14.1.2
  CPU: (10) arm64 Apple M2 Pro
Binaries:
  Node: 20.11.1 - ~/.nodenv/versions/20.11.1/bin/node
  npm: 10.2.4 - ~/.nodenv/versions/20.11.1/bin/npm
  pnpm: 8.15.5 - ~/.nodenv/versions/20.11.1/bin/pnpm
npmPackages:
  jest: 29.7.0 => 29.7.0

This was fixed in https://github.com/jestjs/jest/pull/14672, which will be in Jest@30 (you can install jest@next now if you want)


082 dewey decimal classification number

https://github.com/uwlib-cams/MARC2RDA/blob/main/Working Documents/0XX.csv

@pennylenger @GordonDunsire
Both the google sheet and the document have multiple instructions for the skos:inScheme value here.
Should I follow this section?

If ind1 = 0
http://id.loc.gov/vocabulary/classSchemes/ + “ddc” + substring($2, 1, position($2, “/”)-1) // that is, the first two characters of $2
Else
http://id.loc.gov/vocabulary/classSchemes/ + “ddc”

I think so. I asked this: Why not add DDC edition if ind1 !=0? I see examples in MARC there are also edition if the ind1 is not 0.
Gordon: ind1=0 if a Full edition of DDC is used. LoC differentiates the full editions in its RDF representation of classifications schemes, but not abridged editions. The transform cannot determine if the edition data in subfield $2 pertains to a full or abridged edition unless ind1=0; otherwise, we just use the general DDC scheme. The MARC 21 manual acknowledges the potential problem by requiring a timestamp, although this was formulated when online Dewey was developed. The focus of editions moved from the whole of DDC to the timestamp of an individual concept, and the legacy data may reflect confusion or lag-times in amending cataloging instructions.

@pennylenger: You are correct. Here is some more detail:
The full and abridged editions of DDC have different numbering sequences; see the Wikipedia article for further information.
The MARC 21 manual gives these examples for ind1=0 (full) and ind1=1 (abridged):
082 	04 $a388/.0919$222
082 	14 $a914.3$213
For the full edition, the scheme IRI is http://id.loc.gov/vocabulary/classSchemes/ddc22, with the local part from 'ddc' + subfield $2.
The scheme IRI http://id.loc.gov/vocabulary/classSchemes/ddc13 is also for a full edition, so it is incorrect to use the same mapping for an abridged edition. The best we can do is to use the 'general' DDC scheme IRI http://id.loc.gov/vocabulary/classSchemes/ddc, with the local part from 'ddc' but no edition number.


[BUG] - Appointment Type - Required Appointment (and Input)

Describe the bug
When creating an Appointment Type and selecting "Required Appointment" (Checkbox = True), without a Registration Input value, the Appointment/Option doesn't allow you to select the requirement option. This stops you from moving forward.
When you update the appointment type to have a registrant input, you can input a value on the required option and then select it appropriately.
If that registration input is not required on a required appointment type/option, you are still required to input something to add it to the Selected Option list.
Overall there are issues with the Required Appointment functionality.
To Reproduce
Steps to reproduce the behavior:

Create a basic Event

Create an Appointment Type and make "Requirement Appointment" field TRUE.

Create a registration and try to select the required option.

Create a basic Events

Create an Appointment Type and make "Requirement Appointment" field TRUE.

Update the "Registrant input"  to "Text Box"

Create a registration and try to select the required option WITHOUT inputting text (since inputting text is note required)

Input text on the required appointment/option. This should process, but misses the expect behavior.

Expected behavior
If there is a requirement appointment/option, you can select it without any registrant input.
If there is registrant input, it should follow the rules associated to the "registrant input" field, so if the value is required, an error message appears saying, please input/select a value.  If it is not required, you can select the required appointment without inputting anything.
Screenshots

Included in beta release <IP_ADDRESS>

Included in production release <IP_ADDRESS>


Use imgui-glutin-support in examples and split examples

@Gekkio This is the suggestion we discussed in #163.

Use imgui-glutin-support crate in all examples.
Move examples in their own crates in their own workspace to prevent glutin version conflicts
Allow setting HIDPI factor to imgui-glutin-support crate for current examples to work on all platform.

imgui-glutin-support's glutin version is set in the Cargo.lock global to the workspace. I do not know of a way to using glutin 0.18 for imgui-examples and glutin 0.17 for imgui-glium-examples, unless we do not include the examples in the workspace. That's why I moved all the examples out of the main workspace. Then, I committed a working Cargo.lock for the glium example so that the correct version of glutin be selected.
Project tree now looks like this:
.
├── imgui
│   ├── Cargo.toml
│   ├── imgui-gfx-renderer
│   │   ├── Cargo.toml
│   │   └── src
│   ├── imgui-glium-renderer
│   │   ├── Cargo.toml
│   │   └── src
│   ├── imgui-glutin-support
│   │   ├── Cargo.toml
│   │   └── src
│   ├── imgui-sys
│   │   ├── build.rs
│   │   ├── Cargo.toml
│   │   ├── src
│   │   └── third-party
│   ├── src
│   │   ├── child_frame.rs
│   │   ├── ...
│   │   └── window.rs
│   └── target
├── imgui-examples
│   ├── Cargo.toml
│   ├── examples
│   │   ├── hello_gfx.rs
│   │   ├── ...
│   │   └── support_gfx
│   └── target
├── imgui-glium-examples
│   ├── Cargo.lock
│   ├── Cargo.toml
│   ├── examples
│   │   ├── color_button.rs
│   │   ├── ...
│   │   └── test_window.rs
│   └── target
├── LICENSE-APACHE
├── LICENSE-MIT
└── README.markdown

What are you thoughts on this?

Is it possible to use workspace exclusion instead of moving all the crates? I'm not sure how it exactly works, but in the 0.1-dev branch I've got a imgui-sys-bindgen crate that is excluded from the workspace.

Excellent! I did not know cargo had an exclude feature and that is exactly what we were looking for. I am not sure either how it works as I could not find it documented anywhere. I tried using "exclude" and made a new PR in #171. I close this PR.


Add JS exception logging to Crashlytics

Automated message from Dropbox CLA bot
@borisyankov, it looks like you've already signed the Dropbox CLA. Thanks!


<EMAIL_ADDRESS>23

Pull Request Test Coverage Report for Build 932

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 65.84%

Totals

Change from base Build 930:
0.0%

Covered Lines:
3530

Relevant Lines:
4858

💛  - Coveralls

Pull Request Test Coverage Report for Build 932

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 65.84%

Totals

Change from base Build 930:
0.0%

Covered Lines:
3530

Relevant Lines:
4858

💛  - Coveralls


WIP: Add comparison function

The comparison function for plotting the behavior dynamics, corresponding test for it. Please review the changes @wyshi @HongfeiZhao @lynnzhao92
We also need to add something like
.. plot:: report/plots/plot_dynamics0.py

   The fake mouse from the first strain does the other activities and then stays inactive during the given time period.

for plot_dynamics0.py, plot_dynamics1.py, and plot_dynamics2.py to doc/source/report/dynamics.rst.  It probably makes sense to do that in pull request #189.

As plotting takes a long time, Jarrod suggests that it should be better to add figures in the figure directory. I will do that in the Lynn's repository so that we can see it really works.

Coverage increased (+0.3%) to 73.591% when pulling 2dc6bf3f10fa9ba0d318a95efd625906666d0672 on mingyungkim:add_comparison_function into 6191a571a5a9595bf512ba3eb7383dd570fff366 on berkeley-stat222:master.

Coverage increased (+0.3%) to 73.591% when pulling 2dc6bf3f10fa9ba0d318a95efd625906666d0672 on mingyungkim:add_comparison_function into 6191a571a5a9595bf512ba3eb7383dd570fff366 on berkeley-stat222:master.


Regression, sprite.stringify() returns no symbols in 4.1.6 when 4.1.3 works ok

Do you want to request a feature, report a bug or ask a question?
Report a bug
What is the current behavior?
After upgrading to v4.1.6, calling sprite.stringify() returns no symbols.
It works without issues with v4.1.3.
What is the expected behavior?
sprite.stringify() should return stringified symbols.
Part of webpack config for svg-sprite-loader
if (env.serverSideRendering || env.storybook) {
    return {
      module: {
        rules: [
          {
            test: /.*\.svg$/i,
            use: 'svg-sprite-loader',
            include: /assets\/glyphs/,
            exclude: /node_modules/,
          },
        ],
      },
    };
  }

  // For client bundle, we don't want to store contents of SVG files
  // therefore we use extract mode to provide only "minimal" amount
  // of data about SVG files (viewbox, id and url)
  // @see https://github.com/kisenka/svg-sprite-loader#extract-configuration
  return {
    module: {
      rules: [
        {
          test: /.*\.svg$/i,
          loader: 'svg-sprite-loader',
          include: /assets\/glyphs/,
          exclude: /node_modules/,
          options: {
            extract: true,
            runtimeGenerator: require.resolve('./svgRuntimeGenerator'),
          },
        },
      ],
    },
    plugins: [
      new SpriteLoaderPlugin({ plainSprite: true }),
    ],
  };

Please tell us about your environment:

Node.js version: 8.11.3?
webpack version: 4.38.0?
svg-sprite-loader version: 4.1.6
OS type & version: macOS 10.14.5

Same question when execute SSR in nodejs. I believe this problem was introduced in PR #345 which used absolute path when import sprite.build. I have never used yarn before so I'm not able to fix it, @bimbiltu do you have any time to have a look at this bug?

After 4.1.3 give Error. After 5.0.0 no Error, but return no symbols (ssr side).


fix: change animation example to use new system adds

Objective

change animation example to use new system adds

Solution

just swapped the functions out, compiles and runs fine now

The code in these examples is newer than the latest release <3 This will fail CI, as it reverts the adaption to the upcoming breaking change.
See the large warning in the README.


Remove Zero and Negative Categories When Covering Over-Budgeting - Not working in 0.4.4

Chrome using Toolkit 0.4.4!
I have a negative TBB (created by overbudgeting one category for April).
Click on TBB to get the 'Cover this overbudgeting with' dialog.
The list includes categories with zero available.
I have turned off the feature in Toolkit settings, refreshed YNAB, then turned the feature back on and refreshed YNAB, and the dialog is still the same - showing all categories.

Thank you for the report, we'll have a look shortly. I suspect this is due to changes from YNAB proper.

I'm having the same issue!!!

This seems to be working fine for me in the latest master.

This should now be fixed. Let us know if it's not and we'll have another look.


speech file can't be longer than 30 seconds

hi
i modifed your code a bit to read from sample file. My sample file is 55 seconds long and I noticed that it get's cut off.
I am using recognize_google.
I am guessing this is some sort of api limitation and that I should probably get my own key.

@jzoudavy Yes, this is a limitation with the Google Web Speech API. Unfortunately, I don't think you get any additional length by using your own key. For longer files, you have a couple of options:

Break them up into chunks, either manually with audio editing software, or using the offset and duration keyword arguments for the .record() method.
Use the .listen() method to capture speech until a pause is detected. This is not covered in the article. You can find information about this method in the Speech Recognition docs
Use the Google Cloud Speech API. That is not a free API, although you can get an account with a free $300 credit for one year at https://cloud.google.com. I don't cover setting up and account and obtaining a key for the Google Cloud platform in the article. Here is a quick start on how to do that from the Google Cloud docs: https://cloud.google.com/speech-to-text/docs/quickstart-client-libraries.

Hope that helps!


libpng: New version 1.6.23

Updated libpng to version 1.6.27 1.6.23
Needed to fix iCCp chunk in a lot of pngs, since libpng 1.6 is more strict in this matter. See [1] [2] [3].
Projects will also need to fix their pngs if they have an incorrect iCC profile or will receive warnings like:
ERROR: _png_warn_function: iCCP: known incorrect sRGB profile
Will do a PR in the godot-docs repo about this, adding some documentation about the errors and fixing them.
fixes #3059, updates: #5248

Meh, I merged too fast and noticed too late that you made a typo in the version number :) 1.6.27 does not exist, what we have is 1.6.23.

I fixed with 9bf3ee7 the bug that made libpng warnings treated as errors; they now raise a Godot warning instead:
WARNING: _png_warn_function: iCCP: known incorrect sRGB profile
   At: drivers/png/image_loader_png.cpp:65.

Oops, sorry on the version number, I guess we just have to wait for 1.6.27 and be like ha! We had that moths ago! :smiley:

Well this is annoying. So is there a color profile that it will accept, or does everyone have to go through some rigmarole to remove the chunk for every new png?

@rgrams I fixed all my problems with ImageMagicks mogrify tool (just by running find . -name '*.png' -exec mogrify {} \; in my project's dir). If the profile is correct it'll accept, since not all of my project's PNGs were showing the warning.

I did some fixes to ScrollContainer some time ago, maybe it fixed it
On Mon, Jul 4, 2016 at 4:05 PM, George Marques<EMAIL_ADDRESS>wrote:

@rgrams https://github.com/rgrams I fixed all my problems with
ImageMagicks mogrify tool (just by running find . -name '*.png' -exec
mogrify {} ; in my project's dir). If the profile is correct it'll
accept, since not all of my project's PNGs were showing the warning.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/godotengine/godot/pull/5362#issuecomment-230342738,
or mute the thread
https://github.com/notifications/unsubscribe/AF-Z2_WwrAqAUfUS7ycSwDTsXCwA6D6Zks5qSVltgaJpZM4I8IUU
.

@reduz maybe you meant to post on #3472?

@rgrams I will do a PR in godot-docs shortly, explaining the warning and will give instructions to fix PNGs on all platforms hopefully.

@akien-mga Hmm will look into it, afaik libpng has no knowledge of the image source file in godot, it just reads the raw data and does its job. Although something of that sort could be done in image_loader_png.cpp

For everyone searching the repo for the error message:
WARNING: _png_warn_function: iCCP: known incorrect sRGB profile
Here is a guide to fixing PNGs.

@reduz please...
https://github.com/godotengine/godot/blob/d463b6e3d005ddef1a0e4ff8f297cfc60de1d764/thirdparty/libpng/png.c#L2350
Is it legal to remove this if?
                  /* Warn that this being done; this isn't even an error since
                   * the profile is perfectly valid, but it would be nice if
                   * people used the up-to-date ones.
                   */

No. We don't touch upstream sources.


d3 shape like API

I am trying to integrate d3 axis into a react-native application.
d3 shape API is quite good in the sense that it gives back the raw path data which could be directly used with react-native ART api.
However d3-axis doesn't have similar isolation. it relies on knowledge of DOM to setup the path correctly. It would be nice to have an API to get those axis, ticks and labels path directly so that it can be used with any compatible rendering methods.

No plans to implement this. You can use d3-scale (and d3.ticks from d3-array) if you want to roll your own axes without using SVG.


update to 9.3

Checklist

[ ] Used a personal fork of the feedstock to propose changes
[ ] Bumped the build number (if the version is unchanged)
[ ] Reset the build number to 0 (if the version changed)
[ ] Re-rendered with the latest conda-smithy (Use the phrase @conda-forge-admin, please rerender in a comment in this PR for automated rerendering)
[ ] Ensured the license file is being packaged.

Hi! This is the friendly automated conda-forge-linting service.
I wanted to let you know that I linted all conda-recipes in your PR (recipe) and found some lint.
Here's what I've got...
For recipe:

license_file entry is missing, but is required.

@conda-forge-admin, rerender

Hi! This is the friendly automated conda-forge-linting service.
I wanted to let you know that I linted all conda-recipes in your PR (recipe) and found some lint.
Here's what I've got...
For recipe:

license_file entry is missing, but is required.
noarch: python recipes are required to have a lower bound on the python version. Typically this means putting python >=3.6 in both host and run but you should check upstream for the package's Python compatibility.

@conda-forge-admin, rerender

Hi! This is the friendly automated conda-forge-linting service.
I wanted to let you know that I linted all conda-recipes in your PR (recipe) and found some lint.
Here's what I've got...
For recipe:

license_file entry is missing, but is required.

@conda-forge-admin, rerender

Hi! This is the friendly automated conda-forge-linting service.
I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

This is a package with 100+ direct dependencies and 300+ indirect dependencies. It's also a meta-package that is noarch. (code is in sagelib conda package which has minimal deps and is used for building a few dependencies of sage and then sage is just a collection of sagelib package and other dependencies)
@conda-forge/core, this package doesn't build with conda-build, but does with conda-mambabuild. Since it's noarch, is it okay to use conda-mambabuild here? (I've tried debugging, but it's hard given that there are 300+ indirect dependencies)

I'd be ok making an exception, but you'll have to edit the build scripts by hand. Smithy doesn't support uploads from mamba build.

I'd be ok making an exception,

Thanks.

but you'll have to edit the build scripts by hand. Smithy doesn't support uploads from mamba build.

Sure. This should be a temporary measure and I'll try to debug it in the future.

@conda-forge-admin, rerender


What is the range of these predicted metrics

What is the range of these predicted metrics? For example, MOS  ranges from 0 to 5？

The predicted values range from 1-5 where 1 is poor and 5 is excellent quality


Video 23: Amateur Radio

There seems to be a leftover from another video at the very bottom of the script


Add GitHub logo

Thank you for contributing! Please confirm this pull request meets the following requirements:

[X] I followed the contributing guidelines: https://github.com/github/explore/blob/master/CONTRIBUTING.md
[X] I have no affiliation with the project I am suggesting (as a maintainer, creator, contractor, or employee).

Which change are you proposing?

[X] Suggesting edits to an existing topic or collection
[ ] Curating a new topic or collection

Editing an existing topic or collection
I'm suggesting these edits to an existing topic or collection:

[X] Image (and my file is *.png, square, dimensions 288x288)
[ ] Content (and my changes are in index.md)

I think the usage of the GitHub mark is appropriate in this context, especially since the topic relates to GitHub itself and is shown within the GitHub website.

Hey, @mynetx I saw that your checks are failing because you named your image to github.png. Since its part of github-api topic, according to the test, you need to name it github-api.png.
Check the Travis error messages for more details :)

@vjs3 Thanks for the heads-up, I’m going to force-push a fix (for a clean commit history).


Pasting gif and svg

Please Select if your Request is Either something new or an Enhancement

[x] Enhancement of an existing Feature.
[ ] Request of a new feature.

Please select the area your request applys to. (Multiple selections are Possible)

[ ] Onboard. Initial vault setup and import/export pods
[x] Create. Note creation, lookup, snippets and templates
[ ] Retrieve. Backlinks, references, graph view
[ ] Structure. Refactoring, multi-vault and schemas
[ ] Publish. Sharing your repo with the world
[ ] Misc (Choose this if your not sure)

Is your feature request related to a problem? Please describe
Pasting images into the notes with auto-referencing the image in the image folder is very nice! But this works only for png and jpg (probably among others), but not gif and svg.
Describe the solution you'd like
Support image pasting of svg and gif.

+1


Refocus opened diff view / don't open the same diff view multiple times

When I double click on a file in the list of changes for a patch it opens a new diff view even if that diff view is already opened in another tab. It would be good if double clicking on a file that is already opened in a tab focused that tab rather than duplicating it.

If I understand you correctly, it's not the same behaviour as the IntelliJ diff viewer used for commits and change lists. Only a single diff view tab is used for all files in a commit or change view. For example, if I double click on a file in a change list a diff view tab opens. If I double click that file again nothing happens. If I double click another file in the change list it opens in the same diff view tab that is already open.

Ah, you are right. It depends on the diff viewer you are using in IntelliJ. This plugin uses the "old" one, which is still available also for change lists. But the new one is "inline", which does not have this issue. Would you prefer to have the "inline" one in this plugin as well?

Yeah, I think the plugin should use the new "inline" diff viewer so it's consistent with the diff viewer used for commits.


The Tusimple model accuracy

@harryhan618  Hi, I evaluated the model that you provide on the Tusimple dataset by the test_tusimple.py. the result is as follows:
[{"order": "desc", "value": 0.9416278328369392, "name": "Accuracy"}, {"order": "asc", "value": 0.073538221902708, "name": "FP"}, {"order": "asc", "value": 0.08252456266474979, "name": "FN"}]
Well, I find there is a mismatch with your reported results in the README. Do you have any idea about it? Thank you!

There was a bug in my evaluation code. I fixed the bug and re-evaluated my trained model on CULane. But I forget to re-evaluate the model on Tusimple. Thank you for updating!


[Bug]: devices randomly readded to google home

Version
alpha-52-54
Matter Controller
Google Home
Steps to reproduce
Happened during the night yesterday and today, waking up with Google Home notification about new devices added.
All devices where removed and recognised as new ones, needing to reconfigure all of them.
Matter Hub was not rebooted during the night.
Relevant logs posted below , there's nothing else logged thereafter, so it seems it happened after 2:20 am
State and attributes
No response
Relevant log output
[ 2024-12-10T02:20:34.062Z ] [ INFO  ] [ Matter / ServerSubscription                        ]: Error sending subscription update message (error count=1):
[ 2024-12-10T02:20:50.218Z ] [ INFO  ] [ Matter / ServerSubscription                        ]: Error sending subscription update message (error count=1):
[ 2024-12-10T02:20:56.249Z ] [ INFO  ] [ Matter / ServerSubscription                        ]: Error sending subscription update message (error count=2):
[ 2024-12-10T02:21:00.284Z ] [ INFO  ] [ Matter / CaseServer                                ]: Received pairing request from udp://2a01:cb05:8f20:8aec:ac78:b9e4:f059:7953:5540
[ 2024-12-10T02:21:00.417Z ] [ INFO  ] [ Matter / CaseServer                                ]: session 40924 created with udp://2a01:xxxxxxxxxxxxxxxxxxxxxx for Fabric 00000000BF0DA1F5(index 1) and PeerNode<PHONE_NUMBER>F90ED3 with CATs 65537
[ 2024-12-10T02:21:00.533Z ] [ INFO  ] [ Matter / InsecureSession                           ]: End insecure session insecure/3755012722899755379
[ 2024-12-10T02:21:00.985Z ] [ INFO  ] [ Matter / InteractionServer                         ]: Successfully created subscription<PHONE_NUMBER> for Session 40924. Updates: 0 - 30 => 31 seconds (sendInterval = 25 seconds)
[ 2024-12-10T02:21:04.729Z ] [ INFO  ] [ Matter / CaseServer                                ]: Received pairing request from udp://2a01:xxxxxxxxxxxxxxx:5540
[ 2024-12-10T02:21:05.390Z ] [ INFO  ] [ Matter / CaseServer                                ]: session 23470 created with udp://2a01:xxxxxxxxxxxxxxxxx for Fabric 00000000DA8402B0(index 1) and PeerNode<PHONE_NUMBER>F90ED3 with CATs 65537
[ 2024-12-10T02:21:05.499Z ] [ INFO  ] [ Matter / InsecureSession                           ]: End insecure session insecure/12303254117298041709
[ 2024-12-10T02:21:06.006Z ] [ INFO  ] [ Matter / InteractionServer                         ]: Successfully created subscription 865146145 for Session 23470. Updates: 0 - 30 => 33 seconds (sendInterval = 26 seconds)

Documentation & Issues

[X] I have reviewed the documentation and the linked troubleshooting guide.
[X] I have searched the issues for a similar problem.

Happened again tonight around 3am, same log as above. All devices removed and appearing as new devices discovered.
I wonder if matter.js 0.11.9 won't fix that, I see this commit about reconnection handling: https://github.com/project-chip/matter.js/commit/09ad57f78626862add889d8c27976539d9470d4b

We are currently using a pre-release version of 0.11.9 (0.11.9-alpha.0-20241208-09ad57f78), because it fixes a bug with fans.
The commit you linked was merged (https://github.com/project-chip/matter.js/pull/1488) just before this pre-release version - so it should be included already.
Maybe @Apollon77 could give a hint 🙂

Perhaps this is the culprit then 😉

This was just a topic for controller usage, you work as a bridge. So it is completely unrelated. In fact it is strange that devices gets re-created just because of a subscription re-establishment (probably the hub got an update or such) ... such cases usually only happen on bridge restart if the endpoint assignment is lost ... so no ideas ... but without debug log also hard to spot more

I've activated debug today to catch it when it'll happened again

Happened again tonight. There's gazillon of logs, I've tried to filter out the related part , not 100% sure it is the correct part but I think it is when it happened:
matterbridgelog.txt

At least I can not spot anythng beside a resubscription hat could have caused this behavior .. especially no partLists changes

Since alpha-56 problem seems to be solved. Thing haven't happened for 2 days yet.  I

In alpha 56 I've added the serial number to every device. That could definitely be related.
Let's observe it for a few days.

In alpha 56 I've added the serial number to every device.

Clearly solved the issue. No problem since.
Thanks


fix: update dependencies and upgrade svgo

Hi
I have updated the dependencies, the main issue was running tests, which I managed to after forcing the vite version to latest beta,
also audited and added necessary overrides for pnpm
since I was on windows, I had to install cross-env as dev dependency to use the environment variables you had set in scripts
then I updated the failing tests, which where mainly because of the reordering of attributes of svg for gzip performance increase
also I moved webpack dependencies to peer dependencies, because the way it's used doesn't require it to be in the dependencies, and I think less dependencies, especially when It's for webpack and vite is the default, sounds better to me
I made this fork to work on it to add some features I'd like this module to have
I'll make the features I like on another branch on top of this branch, and make PR for them as well probably
I just thought it's nice to make a PR, so other's could use it too, so no pressure at all :)

This is 🔥 , thank you @jd1378 !


chore(package): update @types/jest to version 18.1.1

Closes #62
https://greenkeeper.io/

Codecov Report

:exclamation: No coverage uploaded for pull request base (master@776ef9e). Click here to learn what that means.

@@            Coverage Diff            @@
##             master      #63   +/-   ##
=========================================
  Coverage          ?   40.63%
=========================================
  Files             ?       19
  Lines             ?      475
  Branches          ?       81
=========================================
  Hits              ?      193
  Misses            ?      282
  Partials          ?        0

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 776ef9e...c897ae2. Read the comment docs.


feat(type): native module for node 16

Pull Request Test Coverage Report for Build 783372753

2 of 2 (100.0%)  changed or added relevant lines in 1 file are covered.
No unchanged relevant lines lost coverage.
Overall coverage increased (+0.2%) to 91.654%

Totals

Change from base Build 781290144:
0.2%

Covered Lines:
792

Relevant Lines:
852

💛  - Coveralls


Add support for (unofficial) FreeBSD REH

While FreeBSD is not officially supported by vscode, it is possible to connect REH with some modifications.
FYI, the steps are described at https://github.com/openingnow/freebsd-vscode-reh.

Would it be better to create a separate "FreeBSD" SERVER_OS category?

Would it be better to create a separate "FreeBSD" SERVER_OS category?

yes :+1: , also I'd would add it behind a new flag setting remote.SSH.experimental.freeBSDSupport or something like that

You can publish you vscode server freebsd releases (be sure to set the same commit as the vscodium release, you can use VSCODE_DISTRO_COMMIT env variable when running the build gulp task) to github releases and then use remote.SSH.serverDownloadUrlTemplate setting and would be done automatically, and other would be able to use it too.

Now using SERVER_OS="freebsd".
As there is no GitHub actions support for ARM64 FreeBSD AFAIK, I cannot provide compiled REH to the end user in the near time. Currently I'm planning to fetch pkg(officially compiled FreeBSD ports) after making an REH port and submitting it to ports but it is not expected to be done in a few weeks.
IMHO prompting users to install manually is best at this moment.

add it behind a new flag setting

I'd like to hide this non-official supporting feature as possible but I can't imagine using a new setting to do so. Isn't it add additional footprints to IServerConfig, such as freebsdSupport?: string;?

As there is no GitHub actions support for ARM64 FreeBSD AFAIK, I cannot provide compiled REH to the end user in the near time. Currently I'm planning to fetch pkg(officially compiled FreeBSD ports) after making an REH port and submitting it to ports but it is not expected to be done in a few weeks.

I think it's possible to create a github release and attach the REH manually


server: make the --insecure warning more explicit

PR: https://github.com/cockroachdb/cockroach/pull/15924
Update the --insecure flag description, and perhaps other docs, to more explicit as well.

PR: https://github.com/cockroachdb/cockroach/pull/15724#issuecomment-301103837
Key here is making sure users know that, when running --insecure, any user can connect without providing a password, which means that any user can connect as root, which means that any user can read and write any data in the cluster.


Add View.LayoutComplete event

See #569

Love it!

This can go in as well - will defer on the conflicting file

this will go in my mondo patch.