opening alternates between 'ValueError: I/O operation on closed file' and no exception

What happened:
I am trying to load a xarray.Dataset from a Gen2 filesystem.
The first time I open a file with xarray, it opens without problem. The next call to open the same file raises:
---------------------------------------------------------------------------
ValueError                                Traceback (most recent call last)
<ipython-input-27-314f04be463e> in <module>
     16         return xr.open_dataset(f).load()
     17
---> 18 open_da(loc) # runs fine
     19 open_da(loc) # throws
     20

<ipython-input-27-314f04be463e> in open_da(loc)
     14 def open_da(loc):
     15     with fsspec.open("abfs://" + loc, **STORAGE_OPTIONS) as f:
---> 16         return xr.open_dataset(f).load()
     17
     18 open_da(loc) # runs fine

~/miniconda3/envs/majoanalysis/lib/python3.8/site-packages/xarray/core/dataset.py in load(self, **kwargs)
    664         for k, v in self.variables.items():
    665             if k not in lazy_data:
--> 666                 v.load()
    667
    668         return self

~/miniconda3/envs/majoanalysis/lib/python3.8/site-packages/xarray/core/variable.py in load(self, **kwargs)
    379             self._data = as_compatible_data(self._data.compute(**kwargs))
    380         elif not hasattr(self._data, "__array_function__"):
--> 381             self._data = np.asarray(self._data)
    382         return self
    383

~/miniconda3/envs/majoanalysis/lib/python3.8/site-packages/numpy/core/_asarray.py in asarray(a, dtype, order)
     81
     82     """
---> 83     return array(a, dtype, copy=False, order=order)
     84
     85

~/miniconda3/envs/majoanalysis/lib/python3.8/site-packages/xarray/core/indexing.py in __array__(self, dtype)
    675
    676     def __array__(self, dtype=None):
--> 677         self._ensure_cached()
    678         return np.asarray(self.array, dtype=dtype)
    679

~/miniconda3/envs/majoanalysis/lib/python3.8/site-packages/xarray/core/indexing.py in _ensure_cached(self)
    672     def _ensure_cached(self):
    673         if not isinstance(self.array, NumpyIndexingAdapter):
--> 674             self.array = NumpyIndexingAdapter(np.asarray(self.array))
    675
    676     def __array__(self, dtype=None):

~/miniconda3/envs/majoanalysis/lib/python3.8/site-packages/numpy/core/_asarray.py in asarray(a, dtype, order)
     81
     82     """
---> 83     return array(a, dtype, copy=False, order=order)
     84
     85

~/miniconda3/envs/majoanalysis/lib/python3.8/site-packages/xarray/core/indexing.py in __array__(self, dtype)
    651
    652     def __array__(self, dtype=None):
--> 653         return np.asarray(self.array, dtype=dtype)
    654
    655     def __getitem__(self, key):

~/miniconda3/envs/majoanalysis/lib/python3.8/site-packages/numpy/core/_asarray.py in asarray(a, dtype, order)
     81
     82     """
---> 83     return array(a, dtype, copy=False, order=order)
     84
     85

~/miniconda3/envs/majoanalysis/lib/python3.8/site-packages/xarray/core/indexing.py in __array__(self, dtype)
    555     def __array__(self, dtype=None):
    556         array = as_indexable(self.array)
--> 557         return np.asarray(array[self.key], dtype=None)
    558
    559     def transpose(self, order):

~/miniconda3/envs/majoanalysis/lib/python3.8/site-packages/xarray/backends/h5netcdf_.py in __getitem__(self, key)
     26
     27     def __getitem__(self, key):
---> 28         return indexing.explicit_indexing_adapter(
     29             key, self.shape, indexing.IndexingSupport.OUTER_1VECTOR, self._getitem
     30         )

~/miniconda3/envs/majoanalysis/lib/python3.8/site-packages/xarray/core/indexing.py in explicit_indexing_adapter(key, shape, indexing_support, raw_indexing_method)
    835     """
    836     raw_key, numpy_indices = decompose_indexer(key, shape, indexing_support)
--> 837     result = raw_indexing_method(raw_key.tuple)
    838     if numpy_indices.tuple:
    839         # index the loaded np.ndarray

~/miniconda3/envs/majoanalysis/lib/python3.8/site-packages/xarray/backends/h5netcdf_.py in _getitem(self, key)
     36         with self.datastore.lock:
     37             array = self.get_array(needs_lock=False)
---> 38             return array[key]
     39
     40

~/miniconda3/envs/majoanalysis/lib/python3.8/site-packages/h5netcdf/core.py in __getitem__(self, key)
    144
    145     def __getitem__(self, key):
--> 146         return self._h5ds[key]
    147
    148     def __setitem__(self, key, value):

h5py/_objects.pyx in h5py._objects.with_phil.wrapper()

h5py/_objects.pyx in h5py._objects.with_phil.wrapper()

~/miniconda3/envs/majoanalysis/lib/python3.8/site-packages/h5py/_hl/dataset.py in __getitem__(self, args)
    541             arr = numpy.ndarray(selection.mshape, dtype=new_dtype)
    542             for mspace, fspace in selection:
--> 543                 self.id.read(mspace, fspace, arr, mtype)
    544             if len(names) == 1:
    545                 arr = arr[names[0]]

h5py/_objects.pyx in h5py._objects.with_phil.wrapper()

h5py/_objects.pyx in h5py._objects.with_phil.wrapper()

h5py/h5d.pyx in h5py.h5d.DatasetID.read()

h5py/_proxy.pyx in h5py._proxy.dset_rw()

h5py/_proxy.pyx in h5py._proxy.H5PY_H5Dread()

h5py/defs.pyx in h5py.defs.H5Dread()

h5py/h5fd.pyx in h5py.h5fd.H5FD_fileobj_read()

~/miniconda3/envs/majoanalysis/lib/python3.8/site-packages/adlfs/spec.py in readinto(self, b)
   1547         https://docs.python.org/3/library/io.html#io.RawIOBase.readinto
   1548         """
-> 1549         data = self.read(len(b))
   1550         memoryview(b).cast("B")[: len(data)] = data
   1551         return len(data)

~/miniconda3/envs/majoanalysis/lib/python3.8/site-packages/adlfs/spec.py in read(self, length)
   1566             length = self.size - self.loc
   1567         if self.closed:
-> 1568             raise ValueError("I/O operation on closed file.")
   1569         logger.debug("%s read: %i - %i" % (self, self.loc, self.loc + length))
   1570         if length == 0:

ValueError: I/O operation on closed file.

Then when I try to open the file again, it works just fine again. It continues to alternate between exception and no exception.
I tried it wth adlfs latest release and with master.
What you expected to happen:
The file to load without an error.
Minimal Complete Verifiable Example:
import adlfs
import fsspec
import xarray as xr

from majoanalysis.utils import datalake_storage_options
STORAGE_OPTIONS = datalake_storage_options()   # returns {'account_name': '...', 'account_key': '...'}

fs = adlfs.AzureBlobFileSystem(**STORAGE_OPTIONS)
da = xr.DataArray(1)
da.to_netcdf("test.nc")
loc = "majodata/test.nc"
fs.put("test.nc", loc)

# works just fine
with fsspec.open("abfs://" + loc, **STORAGE_OPTIONS) as f:
    x = xr.open_dataset(f).load()

# throws 'ValueError: I/O operation on closed file.'
with fsspec.open("abfs://" + loc, **STORAGE_OPTIONS) as f:
    x = xr.open_dataset(f).load()

Anything else we need to know?:
Environment:
import dask, xarray, fsspec, adlfs
print(dask.__version__, xarray.__version__, fsspec.__version__, adlfs.__version__)

2.22.0 0.16.0 0.8.0 v0.5.0

Python version: 3.8.1
Operating System: CentOS
Install method (conda, pip, source): pip

When I tested this with adlfs 0.5.1, it passed.  Did it pass for you with 0.5.1?
I'll also note that this bug report did highlight a missing dunder method, which has been added in the xarray_test branch.  Can you take a look at that one?

Oops, wrapping the call in a function makes the error disappear.
I have edited my original post.

Oops, wrapping the call in a function makes the error disappear.
I have edited my original post.
The error still happens in 0.5.1 and in the xarray_test branch BTW.

When I run this, it passes.  Can you try it without the custom **storage_options method?

The only thing that method does is returning a dict:
{'account_name': 'acnt_name_here',
 'account_key': 'keyhere=='}

Sorry, that wasn't very obvious from my code.
If I leave that out, I don't have access.

Maybe it's because of the specific versions I have?
import xarray as xr
xr.show_versions()

INSTALLED VERSIONS
------------------
commit: None
python: 3.8.1 | packaged by conda-forge | (default, Jan 29 2020, 14:55:04)
[GCC 7.3.0]
python-bits: 64
OS: Linux
OS-release: 3.10.0-957.27.2.el7.x86_64
machine: x86_64
processor: x86_64
byteorder: little
LC_ALL: en_US.UTF-8
LANG: en_US.UTF-8
LOCALE: en_US.UTF-8
libhdf5: 1.10.6
libnetcdf: 4.7.4

xarray: 0.16.0
pandas: 1.1.1
numpy: 1.19.1
scipy: 1.5.2
netCDF4: 1.5.4
pydap: None
h5netcdf: 0.8.1
h5py: 2.10.0
Nio: None
zarr: None
cftime: 1.2.1
nc_time_axis: None
PseudoNetCDF: None
rasterio: None
cfgrib: None
iris: None
bottleneck: 1.3.2
dask: 2.25.0
distributed: 2.25.0
matplotlib: 3.3.1
cartopy: None
seaborn: 0.10.0
numbagg: None
pint: None
setuptools: 45.1.0.post20200119
pip: 20.2.3
conda: 4.8.4
pytest: None
IPython: 7.18.1
sphinx: None

Looks like the bug is occurs when I install netCDF4.
I started with the environment below, without h5netcdf and netCDF4.  Installed h5netcdf v0.8.1.  The file opened.  Once I installed netCDF4 v1.5.4, I replicated your error.
  The following works for me:
with fsspec.open("abfs://" + loc, **storage_options) as f:
    x  = xr.open_dataset(f)

with fsspec.open("abfs://" + loc, **storage_options) as f:
    x  = xr.open_dataset(f)

Can you provide a working conguration?

I can confirm that the code you posted works too.
However, adding a single .load() outside of the context manager, like
with fsspec.open("abfs://" + loc, **storage_options) as f:
    x  = xr.open_dataset(f)

with fsspec.open("abfs://" + loc, **storage_options) as f:
    x  = xr.open_dataset(f)

x = x.load()  # <-------- this

Raises the exception again.

You indicated that the code above worked with adlfs==0.4.  However, when I downgraded adlfs in the above config, I got the same error.  Can you provide an xr.show_versions() for your working code?  I'm trying to determine if the issue lies in adlfs, or elsewhere.
Thanks.

Sorry, if I had posted that originally then that was incorrect. However, there is no mention above about it working with 0.4.0. Perhaps it's because I copied some text from #94 and then later edited it out. Sorry for the confusion.

No worries.  So it hasn't ever worked with adlfs.  Do you know if it works with either s3fs or gcsfs?
I'm asking because adlfs passes the existing unit tests for the context manager, and my debugging efforts suggest this is related to calling .load() with NetCDF4.  However, both of those packages are also based on fsspec, so if one of them works, then that may give me another route to explore.

Unfortunately, I do not have access to any other cloud storage.
Maybe I can try to get access to one of them next week.

Closing as stale.


Fluxes Optimization with Evolutionary Algorithms

Hello,
I am working on a task using a kinetic SBML model to optimize the flux of a reaction. I used basico package in order to add my reactions and parameters to the model, but got stuck on the optimization task itself, specifically on how to set up the objective function, I am sorry to bother you if this isn't the right place for these questions, I read the optimization notebook in docs but I wasn't able to solve the problem. Specifically, how to write the expression in set_objective_function(expression='Values[f].InitialValue', maximize=True)  in order to maximize a flux?
How exactly do I set a flux as the maximization objective function and how to create the list of targets for optimization (Ki, Km and Vmax in my case)?
I want to implement this as a script, as such I prefer doing it in basico instead of the GUI COPASI.
Any help is appreciated :)

This is the right place to ask these questions. To maximise the flux of a Reaction say J1 the expression would be (J1).Flux and then you'd add the bounds on ki, km and vmax as parameters to vary in the optimisation. I'll try and put together an example for that early next week.

There is no way to specify that for the optimization algorithms. In that case it would be best to run an optimization with only those parameters that would be feasible to do. Or first run a sensitivity analysis for the parameters you selected, to see which one have more impact on the desired flux, and then only select those.


Switch control with default set to OFF shows as ON

Issue description:
All of my 40 themes have this issue when updating. Switch controls set to OFF as default shows as ON and are broken.
Version used:
Kirki 4.0.15
Using theme_mods or options?
Code to reproduce the issue (config + field(s))
Example field:
// Blog: Frontpage Widgets Bottom
Kirki::add_field( 'incolor_theme', array(
	'type'			=> 'switch',
	'settings'		=> 'frontpage-widgets-bottom',
	'label'			=> esc_html__( 'Frontpage Widgets Bottom', 'incolor' ),
	'description'	=> esc_html__( '2 columns of widgets', 'incolor' ),
	'section'		=> 'blog',
	'default'		=> 'off',
) );

Or download one of my themes here and check: https://alx.media/themes/incolor/ (/functions/kirki/ folder needs to be updated to 4.0.15)
Customize > Theme Options > Blog > Frontpage Widgets Top/Bottom (shown as ON with it set to OFF)
(The code could look like this in a theme:)
<?php if ( get_theme_mod('my-option','off') == 'on' ) : ?>

I'd do anything for backwards compatibility here on the switch. Rebuilding many options in each theme, and then do it 40 times is... well, far from fun.

We got you, this was an oversight. I'll report back once this is fixed! :)

Hi @AlxMedia , thanks a lot for reporting this issue.
It's is now fixed (I have tested it) in v4.0.16. Download link: v4.0.16
Please let us know if this version fixes your issue :)
Thanks!

Seem to work great from the testing I've done, thanks for this @contactjavas - I can now sleep without worrying about having to remake 40 themes :D

Hi @AlxMedia , I'm sorry, v4.0.16 contains some notice messages if you don't define the default argument.
Please update to v4.0.17 that include the fix for that. Download link: v4.0.17
Thanks :)


README: Broken screenshot.

https://googledrive.com/host/0ByfSjdPVs9MZbkhjeUhMYzRTeEE/gom-screenshot.png is 404.

I was about to deprecate this tool, remove the screenshot instead?

This has been resolved via 183a9e70f4777aa03d377d21a0ed023a6afac141, closing.

Re: deprecation,  did you have a replacement in mind?

@dgryski I am wishing someone from the community can take over or fork. I cannot maintain the tool due to limited bandwidth :(


TLS 1.2 Support - New Feature Request

Hello Team,
Apologies in case this feature already exists in the library.
I am looking at setting up an SMPP Server (Gateway) where clients connect to and support TLS 1.2 to secure data in transit.

Hi, there is a class SSLSocketConnectionFactory which you can use. I will add an example.

I add SSL connection factories and updated the examples to optionally use SSL.

Thank you very... I will try it out.


switch instrumentation from execute_with_consistency to execute_with_options

I hadn't ever gotten the new relic instrumentation to work, but I attributed it to configuration issues.  After diving in, I found that the changes I made a few months ago to support pagination may have broken the usefulness of instrumenting execute_with_consistency since it is now only used when doing batch queries.
Since execute_with_consistency calls execute_with_options, I thought it would make sense to change the instrumented method.  Trying it out locally, I was able to start seeing metrics and transaction segments for Cequel, as I never had before.

Merged! Thanks for correcting the instrumentation.

Released in 1.9.1


update supervisor.clj add a comment to supervisor-data function

update supervisor.clj add a comment "used for saving jvm thread id when running in local mode" to keyword :worker-thread-pids-atom supervisor-data function

@BuDongDong it seems the remote repository for this pull request has disappeared.  Please close this pull request and file a new one as needed.

@BuDongDong, can you please create JIRA to elaborate on the change, and need to delete "missing-tasks"? Also it would be good to get PR subject describe changes.

It seems the original change for this pull request was reverted, and a different change was added.  The remote repository no longer exists, so I will close this pull request.


Docker Compose yaml missing chronograf reference

The current yaml has a "depends_on" entry for chronograf but there is no service. The website shows the config but the GitHub entry doesn't. Here's what the website shows:
chronograf:
image: chronograf:latest
restart: always
ports:
- '8888:8888'
volumes:
- chronograf-storage:/var/lib/chronograf
depends_on:
- influxdb
environment:
- INFLUXDB_URL=http://influxdb:8086
- INFLUXDB_USERNAME=${INFLUXDB_ADMIN_USER}
- INFLUXDB_PASSWORD=${INFLUXDB_ADMIN_PASSWORD}

this is fixed


Weird display behavior in small width REPL

Hi, and thanks for the awesome package!
In VSCode my REPL is usually quite narrow, and this seems to mess Term up. Is there something I failed to configure appropriately?
The following screenshots show what happens when I try to display the following function with different terminal widths.
julia> dumb_function(x, y) = x + y

Sufficient width:

Insufficient width:

Thanks for reporting this, and sorry for the delay with getting back to you.
There was an error with how the panel's content was handled when creating such a narrow panel.
It will be fixed in the next release:

Though it might still create aberrant output for very narrow layouts: reshaping text with lots of markup/ansi style info is not trivial and gets increasingly complicated the narrow the lines are 😓


Adding plot_graph_layout

Function added to common.py and to embeddingset.
I also added an option of choosing the distance metric you want to use. I couldn't find any other layouts that allowed for a distance input.

@Arsilla thanks for the PR! I have some questions about the changes you've made to __get_item__. The rest looks green to merge.

LGTM

thanks for the PR @Arsilla !


setSortColumn in slick.grid.js bad

Change it to the following, and it will work.
        setSortColumns([{ id: columnId, sortAsc: ascending}]);
    }

Fixed.  Thanks!


Can I use SQL Bulk Copy but exclude rows that don't met a certain set of criteria?

Lets say using the example here I did not want to include a row if the Column OpenPrice was < 100.00.
Is this possible?

@VictorioBerra Not easily no, since the ColumnHeader functionality is more about mapping CSV columns to SQL columns.
What I think would be needed is to extend CsvReader with a Func<Row, bool> delegate that would be evaluated by NextRecord, so it would only return true if the row is to be returned.

@phatcher thanks for the quick reply. I will see what I can do.

I put my Func evaluate code here but im having some trouble "skipping" the current row depending on if it was true/false
https://github.com/phatcher/CsvReader/blob/master/code/LumenWorks.Framework.IO/Csv/CsvReader.cs#L1618
I tried SkipToNewLine() but that just skipped the very last line. I am using the reader like this currently:
 foreach (var fileName in files)
            {
                Logger.Info(string.Format("Reading in File: {0}", fileName));

                using (var reader = new CsvReader(new StreamReader(fileName), true, filter))
                {

                    using (var outputStream = new StreamWriter(@"C:\Users\toryb\Downloads\CsvReader Output\output.txt"))
                    {
                        while (reader.ReadNextRecord())
                        {
                            var sb = new StringBuilder();
                           // ... removed for brevity ...

                            outputStream.WriteLine(sb.ToString());
                        }
                    }

So I think maybe this works when placed after this line?
                if (Filter != null)
                {
                    var shouldKeepRecord = Filter.Invoke(this);
                    if (!shouldKeepRecord)
                    {
                        return ReadNextRecord(false, true);
                    }
                }


Fix broken prover contract tests

Noticed yesterday we had 2 failing Arbitrum Prover contract tests
This PR fixes both tests with updated mock proof data
Fixing the above tests subsequently broke all OP Stack tests due to updating the fork block number so updated all OP Stack tests as well

🟡 Heimdall Review Status

Requirement
Status
More Info

Reviews

🟡
0/1

Denominator calculation

Show calculation

1 if user is bot
0

1 if user is external
0

From .codeflow.yml

1

Additional review requirements

Show calculation

Max
0

0

From CODEOWNERS

0

Global minimum
0

Max

1

1

1 if commit is unverified
0

Sum
1


5 post upgrade tests failing

added post-upgrade message and added a 1 minute pause before post-upgrade tests are run.


j.tools.expect is broken for windows

At first glance, it looked like tab/spaces and subprocess.mswindows missing attribute problem, but it turned to be bit complex.
There's no pxssh , no j.logger.addConsoleLogger  and it affects tools/admin/Node, shellcmds/jsdesktop

does it work when we install in unix tools on windows?

No longer an issue with js9 docker


Inaccurate schemastore description for isolatedModules

The current description on schemastore for isolatedModules in tsconfig.json and jsconfig.json is something to the effect of
Unconditionally emit imports for unresolved files

https://github.com/SchemaStore/schemastore/blob/d1d79204ebbd48d24e7130bdfb156e8f7b1b9279/src/schemas/json/tsconfig.json#L229
https://github.com/SchemaStore/schemastore/blob/d1d79204ebbd48d24e7130bdfb156e8f7b1b9279/src/schemas/json/jsconfig.json#L220
Is this an artifact of time?
On our compiler options page, we describe it as
Perform additional checks to ensure that separate compilation (such as with transpileModule or @babel/plugin-transform-typescript) would be safe.

@RyanCavanaugh I'm just trying to get clarity before I update this - would you and @sheetalkamat say the original descriptipn is inaccurate?

Our description in commandLineParser is Transpile_each_file_as_a_separate_module_similar_to_ts_transpileModule which seems accurate.

Just looking at old issues; this was fixed a couple of years ago back in https://github.com/SchemaStore/schemastore/pull/1534.


[TEST] removed failing test, as it was backported by a mistake

The test is coming from this commit which is contained by Kettle starting from 6.0 version.

@pamval @mbatchelor @bmorrise please review


✨ galleryitem redesign details

PR Type

[x] Feature

Context

[x] related #4111
[x] slight change color on link
[x] parse markdown

Before submitting pull request, please make sure:

[x] My contribution builds clean without any errors or warnings
[x] I've merged recent default branch -- main and I've no conflicts
[x] I've tried to respect high code quality standards
[x] I've didn't break any original functionality
[x] I've posted a screenshot of demonstrated change in this PR

Had issue bounty label?

[x] Fill up your KSM address: Payout

Screenshot 📸

@preschian since you made some changes related with these files, could you update your PR with has-text-link and I'll close this one?

closing this in favor of #4360


Bundle enters in an irrecoverable state when a git dependency in the without group is upgraded.

We are facing an issue where bundle enters in a irrecoverable state when a git dependecy that is in one of the groups listed in the without config is upgraded. I have a repository that reproduces the problem (The README contains how to reproduce the issue) https://github.com/rafaelfranca/bundle_test.
Here are the outputs:
$ git checkout error
$ bundle check
The Gemfile's dependencies are satisfied
$ bundle exec irb
git://github.com/modeset/teaspoon.git (at 42a4f61) is not yet checked out. Run `bundle install` first.
$ bundle install
git://github.com/modeset/teaspoon.git (at 42a4f61) is not yet checked out. Run `bundle install` first.

As you can see in the diff, only the sha of the gem that was changed.
For my debug session it is happening in this line of the index method. index is being called in specs and specs is being called in specs_for. Only specs_for has information about the groups that need to be loaded, but I think index should not try to load gems that are not in those groups.
I'm having a hard time to define what is the expected behavior, but I think either bundle check should fail and bundle install works.
cc @andremedeiros

So the expected behavior here imho is that install will download the locked sha, and then not use it

how about the check?

Check probably should return false? But I tried looking into this, and it's some quite hairy code that probably only @indirect fully understands :P

Yeah, I tried too and it was not easy to figure it out. Thank you for looking!

This bug still exists (thanks @rafaelfranca for the good reproduction case) and is waiting for anyone available to work on a fix

Ah nevermind! I needed to update the Bundler version in the lockfile for the test case. This issue is resolved in Bundler 1.13.1


Support for the Java module system?

Hello everyone. My team is considering using RoaringBitmap in our product (a plugin for elasticsearch) but we are encountering some issue at runtime, which I believe is related to the java module system that elasticsearch adopts. I wonder if to modularize RoaringBitmap would help with this.
java.lang.module.ResolutionException: Modules shims and RoaringBitmap export package org.roaringbitmap to module java.uuid.generator
	at java.base/java.lang.module.Resolver.resolveFail(Resolver.java:900)
	at java.base/java.lang.module.Resolver.failTwoSuppliers(Resolver.java:814)
	at java.base/java.lang.module.Resolver.checkExportSuppliers(Resolver.java:735)
	at java.base/java.lang.module.Resolver.finish(Resolver.java:380)
	at java.base/java.lang.module.Configuration.<init>(Configuration.java:139)
	at java.base/java.lang.module.Configuration.resolveAndBind(Configuration.java:493)
	at org.elasticsearch.server@8.7.1/org.elasticsearch.plugins.PluginsService.createModuleLayer(PluginsService.java:705)
	at org.elasticsearch.server@8.7.1/org.elasticsearch.plugins.PluginsService.createPluginModuleLayer(PluginsService.java:673)
	at org.elasticsearch.server@8.7.1/org.elasticsearch.plugins.PluginsService.createPlugin(PluginsService.java:527)
	at org.elasticsearch.server@8.7.1/org.elasticsearch.plugins.PluginsService.loadBundle(PluginsService.java:451)
	at org.elasticsearch.server@8.7.1/org.elasticsearch.plugins.PluginsService.loadBundles(PluginsService.java:292)
	at org.elasticsearch.server@8.7.1/org.elasticsearch.plugins.PluginsService.<init>(PluginsService.java:161)
	at org.elasticsearch.server@8.7.1/org.elasticsearch.plugins.PluginsService.lambda$getPluginsServiceCtor$15(PluginsService.java:668)
	at org.elasticsearch.server@8.7.1/org.elasticsearch.node.Node.<init>(Node.java:417)
	at org.elasticsearch.server@8.7.1/org.elasticsearch.node.Node.<init>(Node.java:324)
	at org.elasticsearch.server@8.7.1/org.elasticsearch.bootstrap.Elasticsearch$2.<init>(Elasticsearch.java:216)
	at org.elasticsearch.server@8.7.1/org.elasticsearch.bootstrap.Elasticsearch.initPhase3(Elasticsearch.java:216)
	at org.elasticsearch.server@8.7.1/org.elasticsearch.bootstrap.Elasticsearch.main(Elasticsearch.java:67)

For what it matters, the issue my team encountered seems similar to the one reported in this stackoverflow question.
Thanks for your attention,
Matteo

Pull request invited.

I've made a pull request: https://github.com/RoaringBitmap/RoaringBitmap/pull/656
I'm afraid you'll reject the PR, because I had to get rid of the shims module and upgrade the base java from 8 to 11 to get the module-info.java to work. There may be a way to make this work, but it's beyond my ability to tame the Java module system.
On the other hand - Java 11 is more than 1 year EOL: https://endoflife.date/java ... isn't it a good time to drop its support in RoaringBitmaps? ;)

On the other hand, 33% are still running Java 8 :/ ... according to this presentation: https://docs.google.com/presentation/d/1oMDMQrTiHNkkyL9PnE9A-jLcJBD-ljNwg_JhzvjdzzA/edit#slide=id.g27e04a1c42f_0_0
The figures were taken from: https://newrelic.com/resources/report/2023-state-of-the-java-ecosystem#most-used-java-versions
I'm shooting myself in my own foot, but it's fair to talk about objective numbers.

@richardstartin Can you comment? What do you think?
Speaking for myself, I am ok with dropping JDK8 support going forward.

This tweet suggests modules are not actually beneficial or use in production:
https://twitter.com/nevgeniev/status/1704686184302063746?s=46&t=-zo9kVFDyKuN4X1cdtkIrw

I am also getting a lot of feedback against dropping JDK8.
So I think we will need to keep JDK 8 support.
If modules break JDK 8 support, maybe the problem is with modules themselves?

Added a PR here which adds module-info.java without dropping Java 8 support: https://github.com/RoaringBitmap/RoaringBitmap/pull/657

It wouldn't be such a problem not to have modular support in RoaringBitmaps, since the Java module systems can work around this using "automatic modules" (see https://dev.java/learn/modules/automatic-module/). The problem is with the shim JAR, which is a separate JAR but uses the same package as the RoaringBitmap JAR. In the Java 9 module system, JARs have to declare different packages in order to be able to export to other modules (or at least that's what I ended up with). So if another library is modularised, RoaringBitmaps can't be used easily and I had to merge RoaringBitmap and shims libraries using the "shade" plugin (see attached pom.xml):
pom.zip
So I'd at least suggest:
a) dropping shims module and integrate it directly into RoaringBitmaps module
b) moving ArraysShim from org.roaringbitmap package to separate one - fe. org.roaringbitmap.shims
Both proposals would allot to use RoaringBitmaps from modularised projects as automatic modules.

Added a PR here which adds module-info.java without dropping Java 8 support: #657

Will it work? If you exclude module-info.java from the build, will it be present and compiled in the target JAR? I have attached a screenshot of what the internal structure of the modularised JAR looks like:

@novoj

will it be present and compiled in the target JAR?

It appears to be, when I build it. Have you checked inside the jar produced by the pull request, or are your concerns theoretical?

I tried it, but in wrong branch. I confirm that in branch ticket-651-add-java-modules-support the module-java.class is present.

@matteo-catena Please see https://github.com/RoaringBitmap/RoaringBitmap/releases/tag/1.0.0


Chunk missing in upload

I am using laravel-chuck-upload in combination with dropzone.js. Everything works fine, the chunks are uploading and when they are uploaded the final file will be saved in S3. The problem is that 1 chunk is always missing. Sometimes .8.part is missing, sometimes .7.part is missing (they remain in the chunks directory after uploading). When I upload a video that has a total size of 9.7MB the file in S3 is 8.7MB. That is 1mb missing, the same size as the missing part. All the chunks are 1MB in size.
What could be the problem and how can I fix this?

I think I have found the problem, but not the fix. When the last chunk (10th) is uploaded it thinks all the chunks are uploaded but the 8th chunk isn't finished uploading yet.

Extended the DropZoneUploadHandler with my own isLastChunk method. This way the file gets uploaded when it's really the latest chunk. The only problem is that dropzone.js triggers the chunksUploaded event for the last chunk call and not for the last completed chunk.
public function isLastChunk()
{
    $chunkFileName = preg_replace(
        "/\.[\d]+\.".ChunkStorage::CHUNK_EXTENSION.'$/', '', $this->getChunkFileName()
    );

    $files = ChunkStorage::storage()->files(function ($file) use ($chunkFileName) {
        return false === Str::contains($file, $chunkFileName);
    });

    return (count($files) + 1) == $this->getTotalChunks();
}

Added a chunkUploaded function to dropzone.js to get the response of every chunk upload. Now I can do everything as I did before but with file that has all the chunks.
I added the following to dropzone.js:
/**
 * The callback that will be invoked when a single chunk has been uploaded for a file.
 * It gets the file for which the chunks have been uploaded as the first parameter,
 * and the `done` function as second. `done()` needs to be invoked when everything
 * needed to finish the upload process is done.
 */
chunkUploaded: function chunkUploaded(file, response, statuscode, done) {
    done();
},

xhr.onreadystatechange = function () {
    if(this.readyState == 4) {
        _this16.options.chunkUploaded(file, this.responseText, this.status, function () {
            _this16._finished(files, '', null);
        });
    }
};

I have noticed that sometimes this isn't working. I have added the following to ChunkSave.php to make sure the isLastChunk is always set.
public function checkLastChunk()
    {
    $this->isLastChunk = $this->handler()->isLastChunk();

    return $this;
}

$this->handleChunkFile($file)
    ->checkLastChunk()
    ->tryToBuildFullFileFromChunks();

I am currently having this with my system as well. It just started all of a sudden. It works fine sometimes and then it leaves a chunk or a chunk is not merged. Is this what is happening with you?

Though I am not using the dropzone library, just the standard upload. This may prove to be a problem with the plugin

https://github.com/23/resumable.js/issues/559

You can check my answer here at @LadyDeathKZN 's issue
https://github.com/23/resumable.js/issues/559#issuecomment-622429803

Extended the DropZoneUploadHandler with my own isLastChunk method. This way the file gets uploaded when it's really the latest chunk. The only problem is that dropzone.js triggers the chunksUploaded event for the last chunk call and not for the last completed chunk.
public function isLastChunk()
{
    $chunkFileName = preg_replace(
        "/\.[\d]+\.".ChunkStorage::CHUNK_EXTENSION.'$/', '', $this->getChunkFileName()
    );

    $files = ChunkStorage::storage()->files(function ($file) use ($chunkFileName) {
        return false === Str::contains($file, $chunkFileName);
    });

    return (count($files) + 1) == $this->getTotalChunks();
}

I tried to solve problem with method proposed and added PullRequest.
Also checking uploaded size vs TotalFileSize to upload in ParallelChunksUpload Mode = true

Hi all, thanks @MaximMonin for a support in my absence.
Fixed a bug and added a support for Laravel 7 in v1.4.0
🎉 Finally a release for Laravel 7 support
⛑ Finally I've fixed problems with chunks (Dropzone/Resumable.js with parallel upload).
👍 Also I've found a solution how to get file data after upload for a Dropzone. Check WIKI.
If you created a packagist entry please mark it as deprecated (in favor of this package) or delete it - it can confuse people.
Thank you for your patience.


Add html and image in tool tip ?

hello i try to add image in tool tip but seems doesn't work can you html me ?
],             "hotSpots": [                 {                     "pitch": -12,                     "yaw": 170,                     "type": "info",                     "text": "This is Jordan Pond, located in Acadia National Park."                 },                 {                     "pitch": -10,                     "yaw": -50,                     "type": "info",                     "text": "
 Youpi !",                     "URL": "https://github.com/mpetroff/pannellum"                 },                 {                     "pitch": 0,                     "yaw": -60,                     "type": "scene",                     "text": "Pond",                     "sceneId": "pond"                 }             ]         },

HTML is escaped unless you explicitly set the escapeHTML parameter to false, to mitigate against potential DOM XSS attacks. However, depending on what you're doing, you many want to look at the custom hot spots example, since it demonstrates the use of custom tool tips.


[feature] introduce includeWalletIdsStandards configuration for createWeb3Modal (filter out incompatible to required standards wallets)

What problem does this new feature solve?
Hi WalletConnect team,
In our dApp we require the connected ethereum wallet to be RFC 6979-compatible. (i.e. signature should be the same for the same exact payload). We are building an exchange, so accidentally allowing users to Sign-In with non-stable-signature Wallets will result in users won't be able to Sing In (when they try to sign in a second time from scratch) (and they'll need to call chain contracts directly to withdraw funds).
But there is currently no easy way to block the non-RFC 6979-compatible wallets from WalletConnect options. (The includeWalletIds currently can be used, but it is a manual process of finding all the RFC 6979-compatible and "allowlisting" them.)
For more context on the issue:

… If a user uses a random temporary key k wallet[i.e. non RFC 6979-compatible], then when the user closes the browser or switches browsers, the user may have no permission to operate on dApp using the same L1 wallet.
Although it is possible to recover assets through Ethereum Key Authentication, the process is complicated and is likely beyond the capabilities of the average user.
(source: https://blog.safeheron.com/blog/insights/safeheron-originals/enhancing-security-on-mpc-wallet-dydx-connections#risk-of-asset-loss-for-users-of-wallets-utilizing-random-temporary-key-k)

Describe the solution you'd like
Introduce includeWalletIdsStandards prop that in similar to the WalletConnect web explorer way will filter out incompatible wallets from includeWalletIds
createWeb3Modal({
  includeWalletIdsStandards: {
    RFC6979: true,
  },
  // … other options
});

Created after https://github.com/orgs/WalletConnect/discussions/3866 discussion

This is interesting proposal 👍 we'll need to check with our data team to see if it is good enough for us to provide this (there is a risk of not showing a wallet here because they didn't fill out standards field for their project for example). If data for this is good, we could ship

Thank you @0xAsimetriq, if we won't be able to add feature in near future due to higher priorities,

Question 1: would it be possible to somehow get a list of wallets with non-stable signatures, so we can use excludeWalletIds to block them
Question 2: is it a correct assumption that most of the WalletConnect-provided wallets are already RFC 6979-compatible (with stable signatures), so risk of user singing with a non-stable signature is low?

@SergeyVolynkin I see this was closed; as a non-RFC 6979 compliant wallet, we too are curious about ensuring we are blocked from dapps that require RFC 6979 compliance. Was another resolution reached?

@ccamrobertson one option is to ask for two signatures during first time wallet connection, then remember the given address is compliant (client-side in IndexedDB, LocalStorage)

@ccamrobertson that's certainly good practice on the dapp side, however, apart from RFC 6979 compliance (infeasible for us at the moment) there doesn't seem like much can be done on our [wallet] side.
Maybe a canonical list of dapps who require RFC 6979 compliance and a corresponding list of wallets that do not support it?


Bombs on activity image upload if no file selected

On the Admin Edit Activity screen, if I load an activity with no image file and click the Upload button, the application throws a null reference exception.  It should instead ignore or not allow an image upload with no file selected.

For me this is breaking whether or not a file is selected.  I think it's because there is no Route attribute specified, but there are also some other issues, like typos in some of the IDs in the <form> element.
I'll take a look at this, unless it isn't needed for the November MVP and other things should be prioritized?

This upload form is using RedirectToRoute (to the Activity edit page) on both success and failure of image upload.  Ignoring a couple of typos which are currently breaking the form (it doesn't use Html.BeginForm but is hand generated), this means that ModelState will be lost upon failure, such that no error appears.  In actual fact, because the Edit page is using the Activity class as its model, and not it's own ViewModel, the <input type='file'> upload element isn't part of the model anyway, so no validation would be happening in any case.
Rather than use TempData to persist validation messages concerning the <input type='file'> element back to the Edit action, it seems like this would be an opportune moment to alter the Create and Edit activity pages (both of which use the Edit.cshtml view) to have their own ViewModel.
This will allow the <input type='file'> element to be added to the model and will then allow full flexibility for validation (e.g. we could (in due course) derive from RequiredAttrbute and check it is indeed an image file that is uploaded).
Let me know if you think this is the wrong approach; if it sounds sensible I'll start working on it.

I think I have this basically working now, having converted the create/edit/activity image upload page to use two different ViewModels rather than the simply the Activity object as its model.  This enables each of the forms to be separately validated.
It's successfully uploading images to Azure.
I'll test everything more thoroughly tomorrow morning and push it for review.

This problem also exists for the Campaign Admin Edit page: it too crashes when no file is selected.
The issue is as described above.
@dpaquette, what would you suggest as the best way for fixing this?  If your refactorings of all the admin pages is now complete, the solution I committed last week could perhaps be reimplemented on top of those modifications (i.e., we could have two models, one for each form, which would allow validation on the image form).
Alternatively, the PostActivityFile and PostCampaignFile actions could be modified to check for a null value, and then redirect back to the appropriate edit form. The redirection would need to include something to indicate the error so that a message could be displayed.  The latter would certainly be a simpler solution - would it be too hacky, putting something on the query string (say) to indicate the error?

Touch base with @joelhulen. I think he was doing something related to images. Just want to make sure you 2 are not overlapping on tasks.

Yes, that's true. I wasn't finished with the changes since I was rushing to
get it up for testing toward the end of the hackathon. Feel free to make
any necessary adjustments, however.
On Monday, November 9, 2015, David Paquette<EMAIL_ADDRESS>wrote:

Touch base with @joelhulen https://github.com/joelhulen. I think he was
doing something related to images. Just want to make sure you 2 are not
overlapping on tasks.
—
Reply to this email directly or view it on GitHub
https://github.com/HTBox/allReady/issues/48#issuecomment-155261988.

Ah okay, I'll leave it for now if you're doing stuff on this @joelhulen.  I hope my PR #301 didn't overlap with anything image-related you were doing.
My main question for the above, which maybe of interest for whoever ends up working on it, concerns the design decision of whether to split the viewmodel so that the file upload form can be validated in the normal way, or whether to simply do the error checking on the post action and then redirect to the original edit page indicating some kind of error via the querystring.

@joelhulen are your changes with respect to images complete now?  Shall I go ahead and fix up the activity edit page in a manner similar to how you simplified the campaign one, or are you handling this one too?

@ksk100 yes, my changes with respect to images on the campaign edit page are complete. Please go ahead and follow a similar pattern for the activity edit page. I wouldn't be able to get to it until late tonight.
One thing to look for is the issue you brought up about the image being required. If you fix that for activities, please also apply the fix to campaigns.

Okay no problem.
On 12 Nov 2015 17:27, "Joel Hulen"<EMAIL_ADDRESS>wrote:

@ksk100 https://github.com/ksk100 yes, my changes with respect to
images on the campaign edit page are complete. Please go ahead and follow a
similar pattern for the activity edit page. I wouldn't be able to get to it
until late tonight.
One thing to look for is the issue you brought up about the image being
required. If you fix that for activities, please also apply the fix to
campaigns.
—
Reply to this email directly or view it on GitHub
https://github.com/HTBox/allReady/issues/48#issuecomment-156174547.

One question: as it stands the Create Activity page doesn't show the image upload form; that only becomes accessible via the Edit page once the activity has been created.  Was there a reason for that behaviour and should it be retained?
(Incidentally, as it's already getting late here I probably won't get this finished and tested tonight; but it'll be finished off first thing tomorrow, with the fix for the campaign page too; if that will be too late do take over).

I don't know why it was set up that way, to be honest. If you mimic the image behavior I've set up in the Campaign edit form, then you'll be able to upload the image on create as well as edit.

Okay will do.
On 12 Nov 2015 18:38, "Joel Hulen"<EMAIL_ADDRESS>wrote:

I don't know why it was set up that way, to be honest. If you mimic the
image behavior I've set up in the Campaign edit form, then you'll be able
to upload the image on create as well as edit.
—
Reply to this email directly or view it on GitHub
https://github.com/HTBox/allReady/issues/48#issuecomment-156196317.


How do you enable it?

The article doesn't seem to actual mention how you enable?

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

 We will investigate and update as appropriate.

Since this article is focused on Azure and the recycle bin is enabled in the on-premises environment, the documentation for this is separate.
Please see this document that covers how to enable it in Active Directory Administrative Center.

We will proceed to close this thread. Please leave a comment and tag me in it if you have further questions and I will gladly continue the discussion.

I was just about to leave the same feedback as this post.
The AzureAD Connect wizard links to this page and should probably point to the link you provided above. Or at least there could be a note on this page pointing to the other page.

This is still not addressed.


fix(i18n): notification translatability

Description:
Ensure that all desktop notifications display correctly and can be translated.
Motivation and Context:
None of the desktop notifications are translatable, and some of them are displaying incorrectly (see screenshot)
How Has This Been Tested?
Test all notifications:

Copy address on syncing screen
Copy address in node addresses screen
Copy invoice address on new invoice summary screen
Copy invoice address on existing invoice detail screen

Screenshots (if appropriate):
Copy payment request (before):

Copy payment request (after):

Types of changes:
Bug fix
Enhancement
Checklist:

[x] My code follows the code style of this project.
[x] I have reviewed and updated the documentation accordingly.
[x] I have read the CONTRIBUTING document.
[ ] I have added tests to cover my changes where needed.
[ ] All new and existing tests passed.
[x] My commits have been squashed into a concise set of changes.

Good call @JimmyMow . I've updated that.

Nice @mrfelton
Tested ACK 4cac353


Update threat-protection-integration.md

Fixed broken link

Issue#https://github.com/MicrosoftDocs/microsoft-365-docs/issues/5224

@JohanFreelancer9  Please copy review


Documentation needs to better explain how to handle the returned arguments

...especially since that part is the only thing golang specific.
By chance I found this example that helped:
https://github.com/docopt/docopt.go/blob/master/examples/type_assert/type_assert_example.go
But it is not super clear nor easy to find

I agree, an example that shows the parsing of arguments showcasing the various argument types would be very appreciated.
I think that, if it would exist, it would benefit the README page and showcase how nice the access actually is 👍
There are many cases to cover, but it doesn't mean one person has to do it all, @nwolff or @mboersma what do you think, might be collaborative and incremental ?

Take a look at my fork which handles this more cleanly: https://github.com/aviddiviner/docopt-go#api. I've added docs there which shows what to do with the returned opts that are parsed.

Hi @aviddiviner
first of all 👍 I like the handling in your fork.
And back to the topic, nice intro, end the bind examples and the parse args example.
The list you do in there

flag, _ := opts.Bool("--flag")
secs, _ := opts.Int("")

is exactly what jumps to the eye of a possible new user, i guess, that's where the args are accessed and explicit simple accesses like these are powerful attraction. An even longer list with some other types of if checks would be fantastic.
Also the bind example, loved it.


Nested elements in CSS

Type: Adding Feature
In the CSS3 features released in 2023, the inclusion of nested elements is noteworthy. However, it is observed that Visual Studio Code does not currently comprehend nesting. I anticipate the incorporation of colorization for nested elements, akin to the functionality present in the SASS CSS preprocessor.
VS Code version: Code 1.84.2 (1a5daa3a0231a0fbba4f14db7ec463cf99d7768e, 2023-11-09T10:51:52.184Z)
OS version: Windows_NT x64 10.0.19045
Modes:

Thanks for creating this issue! It looks like you may be using an old version of VS Code, the latest stable release is 1.85.0. Please try upgrading to the latest version and checking whether this issue remains.
Happy Coding!

Nesting support has been added a while back.
Can you give more information about what doesn't work? Please add a sample code.

Syntax highlighting seems a bit spotty. For example, here's a sample of CSS with no nesting:

And here's a sample with nesting. Notice certain nested selectors aren't highlighted. Notice also nothing is highlighted more than 2 levels deep. Often the presence of the & selector doesn't matter.

Same here, the highlighting seems spotty.
VSCode 1.85.1

code from image
  ```css
  textarea,
  input[type="text"],
  input[type="number"] {
      background: var(--bg-color);
      color: var(--font-color);
      border: 1px solid var(--font-color);
      border-radius: 0.25em;
      outline: none;
      padding: 2px 4px 1px 4px;
      &:hover,
      &:focus {
          border-color: var(--accent-color);
      }
      &:hover {
          box-shadow: 0 0 0.4em var(--accent-color);
      }
  }
input[type="checkbox"] {
padding: 48px;
&:checked,
&:hover {
accent-color: var(--accent-color);
box-shadow: 0 0 0.4em var(--accent-color);
}
}
</details>

Duplicate of https://github.com/microsoft/vscode-css/issues/9


[FLINK-7137] [table] Flink TableAPI supports nested CompositeType mapped to nullable calcite RelDataType by default

Thanks for the PR @walterddr.
This looks good to me.
What do you think @twalthr?

I tried to improve the stability regarding nullable types. This should fix FLINK-7177 and FLINK-7137. It ensures that all types have the correct nullability. By default, types are always nullable. If they are not nullable, than we know it for sure.
https://github.com/apache/flink/compare/master...twalthr:FLINK-7137
What do you think? @walterddr @fhueske

@twalthr Thank you for the suggestion, yeah I think this nullable default to false issue will pop up soon somewhere else, might as well just resolve them all together. I incorporated your suggestions and also add some tests so that the problem could be captured during unitest instead of ITCases. Let me know what your thoughts on this are @fhueske @twalthr

Thanks for the tests @walterddr. I will merge this now...


set('param', '{{param}}/x') leads to php segfault

Q
A

Issue Type
Bug

Deployer Version
6.0.3

Local Machine OS
arch linux 2017-09

Remote Machine OS
N/A

Description
I can cause segfault with set() function :).
Steps to reproduce

download deploy.php from this issue
execute dep test

Content of deploy.php
<?php

namespace Deployer;

set('release_path', '{{release_path}}/asdf');

task('test', function() {
    writeln('{{release_path}}');
});

Output log
hiciu@unknown ~/s/2/2/temp> dep -vvv test
➤ Executing task test
fish: “dep -vvv test” terminated by signal SIGSEGV (Address boundary error)

gdb output
hiciu@unknown ~/s/2/2/temp> gdb --args php ~/bin/dep -vvv test
GNU gdb (GDB) 8.0.1
Copyright (C) 2017 Free Software Foundation, Inc.
License GPLv3+: GNU GPL version 3 or later <http://gnu.org/licenses/gpl.html>
This is free software: you are free to change and redistribute it.
There is NO WARRANTY, to the extent permitted by law.  Type "show copying"
and "show warranty" for details.
This GDB was configured as "x86_64-pc-linux-gnu".
Type "show configuration" for configuration details.
For bug reporting instructions, please see:
<http://www.gnu.org/software/gdb/bugs/>.
Find the GDB manual and other documentation resources online at:
<http://www.gnu.org/software/gdb/documentation/>.
For help, type "help".
Type "apropos word" to search for commands related to "word"...
Reading symbols from php...(no debugging symbols found)...done.
(gdb) c
The program is not being run.
(gdb) r
Starting program: /usr/bin/php /home/hiciu/bin/dep -vvv test
[Thread debugging using libthread_db enabled]
Using host libthread_db library "/usr/lib/libthread_db.so.1".
➤ Executing task test
Program received signal SIGSEGV, Segmentation fault.
0x00007ffff7513bbb in pcre_exec (argument_re=0x555556332e60, extra_data=0x5555562181d0, subject=0x7ffff35847f8 "{{release_path}}/asdf", length=21, start_offset=0, options=0, offsets=0x7fffff7ff210,
    offsetcount=6) at pcre_exec.c:6361
6361    {
(gdb) bt
#0  0x00007ffff7513bbb in pcre_exec (argument_re=0x555556332e60, extra_data=0x5555562181d0, subject=0x7ffff35847f8 "{{release_path}}/asdf", length=21, start_offset=0, options=0, offsets=0x7fffff7ff210,
    offsetcount=6) at pcre_exec.c:6361
#1  0x000055555569cea8 in php_pcre_replace_impl ()
#2  0x000055555569ddf0 in php_pcre_replace ()
#3  0x000055555569e004 in ?? ()
#4  0x000055555569e2df in ?? ()
#5  0x000055555569eca2 in ?? ()
#6  0x000055555596711f in ?? ()
#7  0x000055555590ec4b in execute_ex ()
#8  0x00005555558b3ee7 in zend_call_function ()
#9  0x00005555558b4356 in _call_user_function_ex ()
#10 0x000055555569d673 in php_pcre_replace_impl ()
#11 0x000055555569ddf0 in php_pcre_replace ()
#12 0x000055555569e004 in ?? ()
#13 0x000055555569e2df in ?? ()
#14 0x000055555569eca2 in ?? ()
#15 0x000055555596711f in ?? ()
#16 0x000055555590ec4b in execute_ex ()
#17 0x00005555558b3ee7 in zend_call_function ()
#18 0x00005555558b4356 in _call_user_function_ex ()
#19 0x000055555569d673 in php_pcre_replace_impl ()
#20 0x000055555569ddf0 in php_pcre_replace ()
...
#51717 0x000055555569e004 in ?? ()
#51718 0x000055555569e2df in ?? ()
#51719 0x000055555569eca2 in ?? ()
#51720 0x000055555596711f in ?? ()
#51721 0x000055555590ec4b in execute_ex ()
#51722 0x00005555558b3ee7 in zend_call_function ()
#51723 0x00005555558b4356 in _call_user_function_ex ()
#51724 0x000055555569d673 in php_pcre_replace_impl ()
#51725 0x000055555569ddf0 in php_pcre_replace ()
#51726 0x000055555569e004 in ?? ()
#51727 0x000055555569e2df in ?? ()
#51728 0x000055555569eca2 in ?? ()
#51729 0x000055555596711f in ?? ()
#51730 0x000055555590ec4b in execute_ex ()
#51731 0x00005555558b3ee7 in zend_call_function ()
#51732 0x00005555557c99e4 in ?? ()
#51733 0x0000555555967544 in ?? ()
#51734 0x000055555590ec4b in execute_ex ()
#51735 0x000055555596a250 in zend_execute ()
#51736 0x00005555558c4285 in zend_execute_scripts ()
#51737 0x000055555585ff79 in php_execute_script ()
#51738 0x000055555596c68a in ?? ()
#51739 0x0000555555657f0d in ?? ()
#51740 0x00007ffff61b0f6a in __libc_start_main () from /usr/lib/libc.so.6
#51741 0x00005555556580ba in _start ()

What is desired output of set('release_path', '{{release_path}}/asdf');?
It's basically same as
function release_path() {
     return release_path() . '/asdf';
}

At first I was hoping that it will append "/asdf" to the release_path variable. I tried to do that because in one of the projects I have composer.json and other files in sub directory, not in root of the git repo.
Thanks for the explanation. Is there some way we could add a recursion limit to the set()? Or perhaps note in the docs to not do what I did.
I was thinking also how to detect this kind of loops. This comes from src/Configuration/Configuration.php:
<?php
namespace Deployer\Configuration;

class Configuration
{
    public function get($name, $default = null)
    {
        ...

        return $this->parse($value);
    }

    public function parse($value)
    {
        if (is_string($value)) {
            $value = preg_replace_callback('/\{\{\s*([\w\.\/-]+)\s*\}\}/', [$this, 'parseCallback'], $value);
        }

        return $value;
    }

    private function parseCallback($matches)
    {
        return isset($matches[1]) ? $this->get($matches[1]) : null;
    }
}

How loop detection could work:
<?php
namespace Deployer\Configuration;

class Configuration
{
    public function get($name, $default = null, $originalName = null)
    {
        ...

        return $this->parse(is_null($originalName) ? $name : $originalName, $value);
    }

    public function parse($name, $value)
    {

        if (is_string($value)) {
            $value = preg_replace_callback('/\{\{\s*([\w\.\/-]+)\s*\}\}/', function($matches) { $this->parseCallback($matches, $name); }, $value);
        }

        return $value;
    }

    private function parseCallback($matches, $name)
    {
        if (!isset($matches[1]))
            return null;

        if ($matches[1] == $name)
            throw Exception('loop detected');

        return $this->get($matches[1], $originalName = $name);
    }
}

but that's really ugly IMO. Note in the docs to avoid loops with set() should suffice.

If append is something that is regularly needed, alternately an append() function could be added... There is an add() already that does the same for configuration arrays, so why not be consistent for strings?

So some sort of stack should be implemented, how this should work?
set('param', 'a');
set('param', '{{param}}/x');
set('param', 'y/{{param}}');

What is desired output?

What is desired output?

In my opinion? Exception "Variables are lazy evaluated, you can't use {{param}} in param definition" + note in the docs. I'm not sure if "lazy evaluated" is the proper term here.

lazy evaluated

It's ok. I think let's think of it a little bit more. Maybe it's nice feature and we need to implement it. Or maybe just warn users not to do it.


Kundera 2.0.5

I made a number of fixes associated with UUIDs as row keys and column values.
Please review and advise.
Thanks!!

i will have a look on this. Thanks Again
-Vivek

I am reviewing it and will be merged by today.
Thanks Carlson for good contributions.
-Vivek

119f7cb	 :
if(!idxColumnPresent && !idColumn.equalsIgnoreCase(fieldName))
{
idxColumnPresent = true;
}
Why do we need to have another boolean variable, Could you please elaborate issue faced for making this change?

080e9fd
Please add log statements and avoid e.printStackTrace(), we are already working on removing these things from current code base.
-Vivek

5d42f07
Why do we need to pull "pelops" dependency in kundera-core! As pelops is very much specific to cassandra.
Any such changes in kundera-core must be highly avoided.
Please review this change.
-Vivek

d31bf8d
Please review as per previous comment.
-Vivek

Thanks for these contributions.
However Kundera supports MongoDB, HBase,Mysql other than cassandra. So these changes needs to be made keeping any impact they might have on other components.
There is seperate test project Kundera-Examples with proper test cases to validate these changes:
https://github.com/impetus-opensource/Kundera-Examples/tree/Kundera-Examples-2.0.5/src/test/java/com/impetus/kundera/examples/crossdatastore
https://github.com/impetus-opensource/Kundera-Examples/tree/Kundera-Examples-2.0.5/src/test/java/com/impetus/kundera/examples/crud
I suggest, if you could verify your changes against available test cases.
Thanks again.
-Vivek

Yes, once again the changes past 5d42f07fcd6dccfac2eaf3c1ceb80f5489c62623 weren't officially intended for the pull. Sorry about that.
I will take a look at the kundera-examples test cases.

Thanks a lot Kristoffer.
in case if you could raise a pull request for changes which needs to be merged after all your fixes. I will put this action point on myself to quickly merge them in kundera
-Vivek

Hi Kristoffer,
Please let me know, once you are ready with your pull request. Changes which needed to merged!
-Vivek

Hmm, I guess I keep on changing things when I encounter something that doesn't work as I need it. :) Everything I've done works correctly in regards to cassandra (I have a bunch of tests outside of kundera for my specific application which verify my changes, once again, at least in cassandra). I haven't run all the tests in kundera-examples yet since I don't have all the databases installed on my dev workstation. So to answer your question, they are ready once the changes have been verified running the kundera-example test suite. I should hopefully be able to get around to this tomorrow.

Great to hear that.
I haven't run all the tests in kundera-examples yet since I don't have all the databases installed on my dev workstation.
 You can try it atleast on two(e.g. mysql, Cassandra) to get a feeling if it is running or not, However we are working on CI integration over kundera-examples, in case if something is broken
Your changes to CassQuery(related to range query) and PelopsClient(related to null on getSlice) are definitly needed apart from UUID changes.
Take your time. Once you are done we can work together to check-in your stuff.
Cheers,
Vivek

Do you have any scripts to populate the databases (mysql,cassandra) with the data needed for the testcase in UserAddressDaoTest?

Please ignore this test. It is going to be deleted.
Rest i assume all other test should work for you.
For mysql: if you enable "ddl_auto_create" that should do the trick for you.

ok. Which testcase would you say is best for verifying cross-datastore with mysql/cassandra?

I have commit some changes for test case. Those should help you out for running kundera-examples.
-Vivek

Great, thanks so much! Sorry I haven't been able to get around to setting up and testing.
Also, the last commit has a very important bugfix (see commit e6dcb72a3f4a8c9afbecc6b88ee34a8f10d6c6b6).

Yes. i saw it. Thanks again for one more contribution
-Vivek

Hi. Finally got around to testing.
PersonTest:
Both cassadra and mysql unit tests pass. However, onInsertCassandra will most likely fail at line 145 if the random partitioner is used.
PickrBaseTest:
I had to comment out cleanLuceneDirectory since I changed my dependencies to 2.0.5.
PickrTestBi_1_M_1_M fails @ line 64 due to the addition of PHOTOGRAPHER_ID as a scalar to the SQLQuery object in HibernateClient @ line 625, throwing the exception @ line 629. This doesn't have anything to do with my changes though.
PickrTestBi_M_M_1_1 fails @ line 168 due to the relationships to ALBUM not being persisted in the database. For example, when provisioning the users, the PHOTOGRAPHER.ALBUM_ID = NULL for all users as well as PHOTO.ALBUM_ID = NULL for all photos. In ALBUM all PHOTOGRAPHER_IDs are NULL as well. So there is an issue with album relationships that needs to be investigated. Once again, I don't think that these have anything to do with my changes.
Hopefully this is useful to you. I would like to draw the conclusion that the tests showed the changes made have not had a negative impact on kundera's cross-datastore capabilities. But please have a look, I may have overlooked, or misinterpreted something.
Thanks for the advice!

Thanks Kristoffer.
I will have a look.
Cheers,
Vivek

Hi,
Shall i assume these as your final changes to pushed in?
-Vivek

I have one more thing to check regarding UUIDs. I think I have to make some (small) changes involving joins and foreign keys. I think I forgot to add the special ByteUtils that take UUIDs into consideration in those functions.

Okay. Can you please raise a seperate pull request once you are done with your changes?
-Vivek

Will do. Shall this pull request be closed then?

Yes. i think that should be fine.


Fix pod annotation clear

This PR fix an issue with requested networks.
Before this PR networks with requested mac where not added into the generated annotation.

LGTM


[docs] Add custom method's returnDOMNodes description

@AndreyBelym do you remember why we didn't describe the returnDOMNodes flag? We thought maybe it's time to do this?


Feature/79 groupBy & having

#79 Add support for groupBy and having clauses.

[x] groupBy()
[x] having()
[x] orHaving()
[x] tests

@Omranic done and tested.

@Omranic ready to merge I guess :)

Awesome @ionut-tanasa . Thanks for your works.


add a calculator that renders classifications

While working on a classification pipeline I realized there wasn't any equivalent to DetectionsToRenderDataCalculator, LandmarksToRenderDataCalculator or RectToRenderDataCalculator for classifications, so here is a basic yet useful first implementation.
Note: the proto extension number at optional ClassificationsToRenderDataCalculatorOptions ext = 299999999; is arbitrary. Does this to be set to something meaningful?

Since v0.6.3 mediapipe provides labels_to_render_data_calculator. Closing this since it's far more usable.


Add Newman tool

Description
New tool: Newman
Newman is a command-line collection runner for Postman. It allows you to effortlessly run and test a Postman collection directly from the command-line.
Installation time: ~20 sec
Size: ~50 Mb
Related issue:
#1063
Check list

[x] Related issue / work item is attached
[x] Tests are written (if applicable)
[x] Documentation is updated (if applicable)
[ ] Changes are tested and related VM images are successfully generated

/azp run


Use the new version of CleanWebpackPlugin

Questions
Answers

Description?
Use the new version of CleanWebpackPlugin, this dependency has been updated by dependabot.

Type?
bug fix

BC breaks?
no

Deprecations?
no

How to test?
No need QA.

This change is

Thanks @PierreRambaud


App made with MahApps.Metro won't run on other computers

I made a new version of my app with MahApps.Metro. I build the project for release, and copied the entire release folder to a flash drive to test on other machines. The first machine I tried was a Windows 7 Home Premium 32-bit machine (after installing .Net Framework 4.5) but after double clicking the app, nothing happens. The executable doesn't show up in task manager. Then I tried a Windows 8.1 Preview machine but it didn't run there either and didn't show up in the task manager. It runs just fine on my dev machine running Windows 8 Pro with Media Center. I am new to wpf, I've only used WinForms in the past. Am I missing something? Is there something I need to do?
Edit: Actually, It won't even run from the release folder on my development machine. It will only run if I launch it from Visual Studio.

Remove:

from App.Xaml and it will work

Hi, I downloaded mahapps and extracted it on my computer. An error occurs when running. Which says error in loading project files


Use dep

Hi, @mlabouardy! Thanks for this library.
This adds dep the "unofficial" official dependency tool for Go: https://github.com/golang/dep
The reason for this change is that builds will now use consistent versions of shared libraries when compiling locally, on Circle CI, etc.

thanks @toddmazierski


Fix disposing of RequestItems.

This fixes the root cause of issue #114.

 Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.:x: dkoeb sign nowYou have signed the CLA already but the status is still pending? Let us recheck it.

Applying this patch to git master works.  I successfully imported folders with 118, 157, and 323 photos, whereas I was getting only 5 to 20 at most before the crash.

That's the recommended basic dispose pattern, even for classes without explicit finalizers. Furthermore, RequestItem is not sealed so at least in theory there might be subclasses with finalizers on day...


No credit given..

PS. you will burn out your device trying this.  Don't


Create a Resource for people to educate themselves

This is to add value to the conversation but not to add directly to the proposal. This could go out of control so I added parameters in the form of a key

I like this a lot.
For categories, I can see how that could be contentious. I suggest the following:

Reference: this is for straight-up reference type stuff, which some still may flag for containing "opinions" about thing but that nonetheless is aimed at being informational.
Advocacy: this would be how we'd flag advocacy journalism, fact sheets from sources like the NRA, and stuff that's clearly designed to sway opinion in one direction or another.
Opinion: the standard for this category would be stuff that's clearly marked as "opinion" by the publisher, i.e. op-eds and editorials in major newspapers.
Discussion: this would be for forum threads, reddit threads, HN discussions, and so on that are worth looking at.

I think my original piece on the AR-15 would go under "advocacy" in the above, because though it includes a lot of info, the point is to make a case for why someone without military pretensions would choose the AR-15 over some other weapon type on practical grounds.

I think I mixed the suggestions into this without adding too many new categories. Your thoughts?

Actually after I merged I realized that this was a PR to a branch that's already merged into master. I'll fix it.


🖥 Auto-add attribute codefix

Codefix for auto adding [Watch], [Messager] or [Filter] attributes, depending on what your system needs. Good stuff.
@isadorasophia Would love your feedback on what the defaults should be for these. Right now I'm adding an empty attribute, but we can be clever and use the code fixes to educate and nudge people towards better decisions. Adding an empty attribute is fine, but adding a smart attribute is better (and not much more expensive since the heavy lifting is already done).

Awesome, I'm curious on what we could have for smart attributes!! For the default values:

[Filter(ContextAccessorFilter.None)] (since usually you are not using a filter if you are not using anything
Messager and Filter are really tricky though... because they are basically useless without a type argument (we could also suggest removing the IMessager/IReactive inheritance)

@isadorasophia Implemented, please review

Thanks @heytherewill! I'm thinking whether the [Messager] and [Watch] can be misleading here. Is the code fix right now just adding a [Messager]/[Watch] attribute?
Maybe we could add something like [Messager(typeof())] and the person can fill the gaps...? I'm not sure whether people can be misled into thinking that [Messager]/[Watch] attribute will work by themselves (which won't in a non-obvious way, they need to define the type)

Oh, that's not a bad idea! I wonder if we can control the caret to move it to inside the typepf, but adding broken syntax, in this case, is a good idea

@isadorasophia I ended up creating partial attributes for all possible fixes. For Filter I went with AllOf and they all have empty typof expressions for the user to fill in. I think it's way better this way. The moving caret part wasn't working, though, so I'll wait for .NET 8 to be stable to try again on an IDE that fully supports it 😂


IGAPP-950: Add shelter contact form

This pull request belongs to an issue on our bugtracker.
You can find it there by looking for an issue with the key which is mentioned in the title of this pull request.
It starts with the keyword IGAPP.

Tested and received a call immediately. nice work! I'm not sure about the form validation. maybe we should improve it a little bit. If not this could block the whole contact process

Yes, sounds good. Will create an issue for this. Going to merge this now as this is quite important.


Stub out calls to useProxyAttributes when ots2 is disabled

Closes #1854

Yes, it does. The assumption was that the order of hooks would not change, so the conditional would always go one way or the other throughout the page lifecycle. But to follow this rule strictly, I could separate out the experimental tabs and routes into their own components, which we can render conditionally without breaking any of the rules of hooks. I'll do this instead...


Godot 4.0 Update

Hey there, thanks for the great mirror asset! This pull request updates the project to Godot 4.0. There is an outstanding issue that affects Godot 3.5 regarding the way the addon plugin is configured that I haven't fixed with this pull request.

Hey!
Thanks for the PR! I will go through it and test it when I have some time.
I guess the weekend maybe :)

Great, thanks! There is also the following error that happens when instantiating a scene with a SubViewport and material that uses the texture from that SubViewport:
Mirror.gd:21 @ _enter_tree(): Condition "proxy.is_valid()" is true.
  <C++ Source>   scene/main/viewport.cpp:89 @ setup_local_to_scene()
  <Stack Trace>  Mirror.gd:21 @ _enter_tree()

There seems to be a lot of development work surrounding SubViewports in Godot 4.0, so I think this issue will be fixed in an upcoming 4.0 RC. I think the specific fix to this error can be found as a pull request to this issue. Because of this, I've just been ignoring this error for now.

Hey!
Sorry for not getting back sooner. I started learning about the differences of the new engine and I'll soon get around to test and merge this PR.Do you happen to know any recommendation on how to add new

Hey, no worries. Full disclosure: this was my first time ever working with Godot and I have no other experience with plugins. My goal was just to get this plugin to be behaving the same on Godot 4.0 as it does using Godot 3.5, if you ignore the "proxy.is_valid()" is true issue that seems to be a known issue, as I mentioned.
So to answer your question: I have no idea, sorry!

Hey, no worries. Full disclosure: this was my first time ever working with Godot and I have no other experience with plugins. My goal was just to get this plugin to be behaving the same on Godot 4.0 as it does using Godot 3.5, if you ignore the "proxy.is_valid()" is true issue that seems to be a known issue, as I mentioned.
So to answer your question: I have no idea, sorry!

Applied some small fixes and pushed it to a new branch.
You can find it under https://github.com/Norodix/GodotMirror/tree/godot4
Thanks for the help! : )

Nice!


🚀 - Processors should accept array of functions + maskitoPipe deletion

Which package(s) are relevant/related to the feature request?
@maskito/core, @maskito/kit
Description
Step 1
Replace these lines
https://github.com/Tinkoff/maskito/blob/4c5a7f64b9a8ac209584c75e17ec022674b87c1b/projects/core/src/lib/types/mask-options.ts#L8-L9
with
 readonly preprocessors?: MaskitoPreprocessor[];
 readonly postprocessors?: MaskitoPostprocessor[];

(plural form + new type)

Step 2
Deprecate this utility
https://github.com/Tinkoff/maskito/blob/4c5a7f64b9a8ac209584c75e17ec022674b87c1b/projects/core/src/lib/utils/pipe.ts#L12-L19

Step 3
All mask generators from @maskito/kit should return Required<MaskitoOptions>.

Step 4
Update documentation
https://tinkoff.github.io/maskito/core-concepts/processors

Those arrays have to be readonly


06.Administration/02.Production-installation: configure allowed gatew…

…ay hosts
notes on how to define the gateway's host whitelist for the purpose
of preventing host header injection attacks.
Issues: MEN-1262
Changelog: None
Signed-off-by: mchalczynski<EMAIL_ADDRESS>

Looks ok to me.  The only nitpick I have is the changelog title line wraps funny.  @estenberg how picky are we being about changelog formatting?

@estenberg any thoughts on the nitpick here?

I do not believe changelog title wrapping has been an issue, so I don't know about that.

Sounds good.  Merging.
Acked-by: Drew Moseley<EMAIL_ADDRESS>


Gradient explosion in Mamba2 training, norm and loss divergence

Hi,
I'm experiencing an issue with clip_grad_norm_ and loss values while training Mamba2. After training for some time, the gradient norm starts to rapidly increase to infinity. If training continues, the loss eventually becomes NaN.
With gradient accumulation:

Training with no gradient accumulation:

Below is a simple training script that reproduces this issue. I'm wondering if I'm doing something incorrect:
from transformers import AutoTokenizer
from mamba_ssm.models.config_mamba import MambaConfig
from mamba_ssm.models.mixer_seq_simple import MambaLMHeadModel
from tqdm import tqdm
import time
import torch
import torch.nn.functional as F
import requests
import polars as pl

device = torch.device("cuda")
tokenizer = AutoTokenizer.from_pretrained("mistral-community/Mistral-7B-v0.2")
cfg = MambaConfig(
    d_model = 1024,
    d_intermediate = 0,
    n_layer = 20,
    vocab_size = 32768,
    ssm_cfg = {"ngroups": 8, "layer": "Mamba2"},
    rms_norm = True,
    residual_in_fp32 = True,
    fused_add_norm = True,
    pad_vocab_size_multiple = 8,
    tie_embeddings = True)
model = MambaLMHeadModel(cfg).to(device)

def download_file(url, path):
    response = requests.get(url, stream=True)
    total_size = int(response.headers.get('content-length', 0))
    with open(path, 'wb') as file, tqdm(
        desc=path, total=total_size, unit='iB', unit_scale=True, unit_divisor=1024
    ) as progress_bar:
        for data in response.iter_content(chunk_size=1024):
            size = file.write(data)
            progress_bar.update(size)

url = "https://huggingface.co/datasets/mlfoundations/dclm-baseline-1.0-parquet/resolve/main/filtered/OH_eli5_vs_rw_v2_bigram_200k_train/fasttext_openhermes_reddit_eli5_vs_rw_v2_bigram_200k_train/processed_data/global-shard_01_of_10/local-shard_0_of_10/shard_00000010_processed.parquet"
download_file(url, "temp.parquet")

df = pl.read_parquet("temp.parquet")['text']
tokens = []
enc_batch = []
for text in tqdm(df):
    enc_batch.append("<s>" + text + "</s>\n")
    if len(enc_batch) == 25:
        for t in tokenizer.batch_encode_plus(enc_batch, add_special_tokens=False)['input_ids']:
            tokens.extend(t)
        enc_batch = []
        if len(tokens) >= 5_000_000:
            break
del df, enc_batch

block = 4096
gradient_accumulation = 12
optimizer = torch.optim.AdamW(model.parameters(), lr=0.0004, betas=(0.9, 0.95))
tq = tqdm(range(0, len(tokens), block))
tloss = 0
model.train()

for p, i in enumerate(tq):
    src = torch.tensor([tokens[i:i+block]], dtype=torch.int64).to(device)
    tgt = torch.tensor([tokens[i+1:i+block+1]], dtype=torch.int64).to(device)
    if src.size()[-1] != block or tgt.size()[-1] != block:
        break
    if tloss == 0:
        optimizer.zero_grad()
    logits = model(src).logits
    loss = F.cross_entropy(logits.view(-1, logits.size(-1)), tgt.view(-1))
    loss = loss / gradient_accumulation
    loss.backward()
    tloss += loss.item()
    if (p + 1) % gradient_accumulation == 0:
        clip_grad_norm = torch.nn.utils.clip_grad_norm_(model.parameters(), 1.0).item()
        optimizer.step()
        tq.set_description(f"loss: {tloss:.4f}, grad_norm: {clip_grad_norm:.4f} | p: {p} | i: {i}")
        tloss = 0

Possibly related to #522

@edwko Could you try to decrease ngroups to 1 to see if the issue is related to the one I'm having?

@edwko Could you try to decrease ngroups to 1 to see if the issue is related to the one I'm having?

@DanFosing Yes, using ngroups 1, which is the default setting, the training process is stable. Processed over 30 billion tokens, and everything appears to be stable.


Typescript support

I am implementing firebase-analytics for mobile app and I am using angular. I am not sure if I am missing something but once I hover on some function I don't see any information in VS Code regarding its parameters and output.
Is the project missing types declaration?
I am using TSlint if it helps.
Example of my implementation, hovering on logEvent() only shows any:
import { Plugins } from '@capacitor/core';
const { FirebaseAnalytics } = Plugins;

publishEvent(event: Event): void {
  FirebaseAnalytics.logEvent({ name: eventName, params: value });
}

Same issue here, just started with the plugin and can't get any TypesScript support in VSCode.
Did you find a solution?

Nothing, this repo seems not being actively maintained.

Yeah, I think so. The Crashalytics Repo seems also to be outdated. I am fine without code insight, but I am worried about the maintenance of the plugins.

Same here, but with many community Plugins

It's been a couple of months since the last comment. Has anyone found any kind of progress here? Any custom definitions being used in the wild?

It's been a couple of months since the last comment. Has anyone found any kind of progress here? Any custom definitions being used in the wild?

This seems to be working since the 0.2.0 release, are you still having this problem?

I see this repo is starting to come alive. Many thanks @brownoxford for this!
Your comment made me try different builds and different aproaches. I was already on 0.2.0 release, I tried 0.2.1 but still no luck.
Then I tried changing way how the package is imported.
Importing this way worked:
import { FirebaseAnalytics } from '@capacitor-community/firebase-analytics';

The problem occurs when we import package as recommended by Capacitor docs:

A common mistake is to import a plugin directly, then use the plugin API immediately, resulting in the web implementation being used:
By using the plugins from the plugin registry (Plugins object), the native implementation of the plugin is used (if available), with fallback to the web version.

import { Plugins, Capacitor } from '@capacitor/core';
const { FirebaseAnalytics } = Plugins;

Not sure as to how manage getting code insight with this approach.

Hmm, here are my imports for the working capacitor v2 implementation where I got that screenshot:
import { Plugins } from "@capacitor/core";
import "@capacitor-community/firebase-analytics";

const { FirebaseAnalytics } = Plugins;

It looks like your first implementation may not have been working because you were not also importing "@capacitor-community/firebase-analytics" - you need that import because it actually exports all of the definitions for the plugin via export * from './definitions'
import { Plugins } from '@capacitor/core';
const { FirebaseAnalytics } = Plugins;

The new style you show is only for capacitor v3, so I would not use that unless you are upgrading:
# Capacitor V3 only
import { FirebaseAnalytics } from '@capacitor-community/firebase-analytics';

@michalsisak did the updated import fix the issue for you?

@brownoxford Importing import "@capacitor-community/firebase-analytics"; solved the issue! Thank you. Will close the issue now.


HBASE-28204 : Canary can take lot more time If any region (except the first region) starts with delete markers

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
0m 36s
Docker mode activated.

At least this change does not change any behavior of the Canary, other than avoiding unnecessary scans for empty tables/regions, and avoiding a Get of a very large deleted row, if it exists. Seems to be a strict improvement in that sense.
If anyone was relying on the RPCs being Gets, by using separate RPC handlers for Gets vs. Scans, this will change that behavior. But that seems like weird behavior to rely on.

@d-c-manning 's suggestion is valid. Should we include this as JIRA release note? So it's documented for every branch that has this JIRA?

At least this change does not change any behavior of the Canary, other than avoiding unnecessary scans for empty tables/regions, and avoiding a Get of a very large deleted row, if it exists. Seems to be a strict improvement in that sense.
If anyone was relying on the RPCs being Gets, by using separate RPC handlers for Gets vs. Scans, this will change that behavior. But that seems like weird behavior to rely on.

@d-c-manning 's suggestion is valid. Should we include this as JIRA release note? So it's documented for every branch that has this JIRA? @virajjasani

Sounds good, feel free to update release note on the Jira.

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
0m 24s
Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s
No case conflicting files found.

+1 :green_heart:
hbaseanti
0m  0s
Patch does not have any anti-patterns.

+1 :green_heart:
@author
0m  0s
The patch does not contain any @author tags.

_ master Compile Tests _

+1 :green_heart:
mvninstall
3m  5s
master passed

+1 :green_heart:
compile
2m 27s
master passed

+1 :green_heart:
checkstyle
0m 32s
master passed

+1 :green_heart:
spotless
0m 41s
branch has no errors when running spotless:check.

+1 :green_heart:
spotbugs
1m 26s
master passed

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
2m 42s
the patch passed

+1 :green_heart:
compile
2m 23s
the patch passed

+1 :green_heart:
javac
2m 23s
the patch passed

+1 :green_heart:
checkstyle
0m 34s
the patch passed

+1 :green_heart:
whitespace
0m  0s
The patch has no whitespace issues.

+1 :green_heart:
hadoopcheck
5m  3s
Patch does not cause any errors with Hadoop 3.3.6.

+1 :green_heart:
spotless
0m 38s
patch has no errors when running spotless:check.

+1 :green_heart:
spotbugs
1m 32s
the patch passed

_ Other Tests _

+1 :green_heart:
asflicense
0m  9s
The patch does not generate ASF License warnings.

27m 52s

Subsystem
Report/Notes

Docker
ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5675/2/artifact/yetus-general-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/5675

Optional Tests
dupname asflicense javac spotbugs hadoopcheck hbaseanti spotless checkstyle compile

uname
Linux 85380ad2a503 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
master / b3ffc4acb6

Default Java
Eclipse Adoptium-11.0.17+8

Max. process+thread count
77 (vs. ulimit of 30000)

modules
C: hbase-server U: hbase-server

Console output
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5675/2/console

versions
git=2.34.1 maven=3.8.6 spotbugs=4.7.3

Powered by
Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.


get_recent_tracks(4) returns just one song:

What did you do?
I'm trying to get the last 4 played songs
What did you expect to happen?
The output should be:
Track1
Track2
Track3
Track4
What actually happened?
But the output is:
Track1
What versions of OS, Python and pylast are you using?
Python 3.6.5
        recents = self.user.get_recent_tracks(max_results)
        for song in recents:
            return str(song.track)

The problem is your code returns immediately on the first track.
See:
https://stackoverflow.com/a/53366468/724176


test: add browser tests for new APIs

Adds browser tests for stringify, parse, version, and validate methods.
Notes:

The examples-all page was getting a bit long when displayed in the browser so I tweaked the structure a bit.  Specifically, I switched from H2/P tags to DT/DD tags since that seemed more semantically appropriate, and added an inline <style> block clean up the appearance.
The whole "examples" directory feels a bit off to me.  All of the scaffolding we've added to allow these to be useful in testing gets in the way of providing readers with clean, easy-to-comprehend examples.   I'm wondering if we shouldn't move this stuff under the "./tests" directory, instead.
I added new tests to browser-rollup and browser-webpack examples, since that's what's CI tested, but none of the other example directories.  Should I do that for consistency?  (And, if so, it'd be nice if that were generalized somehow to avoid having to copy/paste code across those directories.)

  When I do npm run test:browser from my shell, everything passes but the BrowserStack dashboard shows the "manual build" as failing.  Conversely, the dashboard shows the latest v9_tests build as passing, but here in this Github PR, it says "checks were not successful".
I think the above failures are because "Terser" lint checks are failing, but I'm unable to reproduce that on my local box, nor are the error messages in the log very helpful.

I agree that the current setup is not ideal: After all, the examples were there first and I only started using them as test cases when I was adding browser tests. This definitely deserves a refactoring in the future, but I think we can pull this in before.


Add docs for kernel, boot and trusted cert bundle settings

Issue #, if available:
Description of changes:
Add docs for kernel, boot and trusted cert bundle settings
Testing (if applicable):
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

/approve

/cherry-pick release-0.16


Cant connect diaflow with realtime firebase !!!

Can anyone help me !? I create a google diaflow project and connect with firebase. I create a realtime database but when i deploy the fullfillment in diaflow and run simulator, nothing happened with my database. No data saved to it and the simulator always disconnect. I close the firebase tab and reopen it.
Surprise my database doesnt exist and i must create the new database. Few months ago, I created the same project with another google account and it all ok. What wrong with google -_-
Sorry for my bad english !!
Error: FIREBASE FATAL ERROR: Cannot parse Firebase url. Please use https://.firebaseio.com
at fatal<EMAIL_ADDRESS>...................................

OMG i just find that realtime database isnt free no more it so sad :'(

he must have used firebase functions to ensure the change, most likely he copied the sketch from the webhook without noticing the writing


Cannot delete stopped containers

I click the "X" in the list of containers on the left, then:

@bfirsh can you issue in the Docker CLI  docker ps -a so we can see what is running on your system and list it here?
Thanks

It happens with any container.
 Not sure what caused that - sorry. :(


GH-35821: [Python][CI] Skip extension type test failing with pandas 2.0.2

What changes are included in this PR?
Skip Python extension type tests due to the new 2.0.2 release of pandas.
Are these changes tested?
Changed check of pandas version
Are there any user-facing changes?
No

Closes: #35821

Yes, certainly, go ahead!


downloaded-logs-20211118-141007

![Screenshot_20211025_170330_com sec android app sbrowser~2](https://user-images.githubusercontent.com/94048360/143272886-747472db-e09d-4b37-b787-5e4c84cea491.jpg)
Originally posted by @Lovygoogle in https://github.com/MicrosoftDocs/windows-itpro-docs/issues/10146#issuecomment-978013297

We hugely appreciate your contribution, feedback, and support to our technical documentation.
We’ve phased out GitHub Issues on this repository as the feedback mechanism for content and have replaced it with a new feedback system. For more information see, Content User Feedback. As part of this rollout, we are migrating your issue where our team will use your comments to improve the documentation experience. Unfortunately, this does mean you won't be able to access this issue after the migration is complete.
All issues will be migrated by Thursday 29th August 2024.
Once again, thank you for your valuable feedback, we hope you’ll continue to contribute using our new feedback system.


Changes -> Charges

Changed "Changes only accruing when you are actually running code." to "charges only when you are actually running code."

Hi @dbrust, I'm your friendly neighborhood Azure Pull Request Bot (You can call me AZPRBOT). Thanks for your contribution!

This seems like a small (but important) contribution, so no contribution license agreement is required at this point. Real humans will now evaluate your PR.

TTYL, AZPRBOT;

@eduardolaureano - Please review this proposed change from @dbrust in the public repo.

This fix is correct.

@dbrust thanks for taking the time to find and fix this typo. We appreciate your help improving the quality of Azure docs.


Determine license for asr-api project

We need to figure what license to use for the project. Current suggestion is MIT.

[ ] Research the suitable license
[ ] Update the license information in README.md
[ ] Update the license file LICENSE.md

As per last meeting, we go with the license of MIT as it is the same for whisper.cpp


Calling Date.description might result in undefined behaviour

Date’s description function uses a fixed size buffer (26 bytes, see here). This buffer is given to strftime.
Both, dates before “-999-01-01 00:00:00 +0000” and starting at “10000-01-01 00:00:00 +0000”, will require 27 bytes or more (including null byte at the end).
The return value of this function is checked by guard strftime(…) >= 0 (see). While most library functions in C return a negative value on failure, strftime returns 0 if the buffer is not big enough to hold the formatted date. Thus this guard never executes.
The buffer in this case is not guaranteed to contain a ending null byte, as the man page states: “Otherwise, 0 shall be returned and the contents of the array are unspecified.” (Highlighting mine)
The undefined content (worst case: 26 bytes forming valid UTF-8, e.g. 26 spaces) is then given to String(validatingUTF8:) which probably will (in the worst case) run behind the end of the buffer, resulting in a crash.
I suggest to either replace the call to strftime by a better API or change the buffer size to be big enough to hold any description of any point in time that Date might represent. In addition to that, the guard should be changed to guard strftime(…) >= 25 given that is the smallest valid size.
test cases:
Date(timeIntervalSinceReferenceDate: TimeInterval(-63145526400)).description == "0000-01-01 00:00:00 +0000"
Date(timeIntervalSinceReferenceDate: TimeInterval(-4200000000000)).description == "-131090-12-30 21:20:00 +0000"
Date(timeIntervalSinceReferenceDate: TimeInterval(4200000000000)).description == "15310-04-10 02:40:00 +0000"

I'd rather start with 26 bytes like we do now and allow for one single reallocation if strftime returns 0 - which is guaranteed (in our specific case / given the format) to be due to undersizing the buffer.
I slightly disagree with guard strftime(…) >= 25 (although true in practice), but it should not be required if we're looking for 0 directly (as per man).

The memory is deallocated at the end of the block, why not use a few bytes more than the minimum? Thinking about that, I’d use something that just allocates the buffer on the stack:
   lazy var unavailable = { "<description unavailable>" } ()
   let format = "%Y-%m-%d %H:%M:%S +0000"
   let bufferSize = 512

   var info = tm()
   var time = time_t(self.timeIntervalSince1970)
   gmtime_r(&time, &info)

   return withUnsafeTemporaryAllocation(of: CChar.self, capacity: bufferSize) { buffer -> String in
      guard let ptr = buffer.baseAddress else {
         return unavailable
      }

      guard strftime(ptr, bufferSize, format, &info) != 0 else {
         return unavailable
      }

      guard let result = String(validatingUTF8: ptr) else {
         return unavailable
      }

      return result
   }

I know, 512 bytes is unreasonable.
On the other hand, currently the compiler considers up to 1024 bytes as small enough to live on the stack (see).
It could be whatever the is used at most (with the given max time_t) but I think, I’d just use 64 or 128 and it will work with every strange architecture even when time_t is way bigger.

Looks solid 🚀. Out of curiosity, why not let unavailable instead (since we're dealing with a string literal anyway)?
My only argument against a large initial buffer was that in 99.999% of the cases the buffer is exactly 26 bytes. That being said, you're right, there's literally no gain to be had, so we might as well allocate 512.

Looks solid 🚀. Out of curiosity, why not let unavailable instead (since we're dealing with a string literal anyway)?

I was over-optimizing. (I thought that assigning the string literal to the variable would require a copy of the string.)

Fixed by https://github.com/apple/swift-foundation/pull/93


fix(build): Rebuilt lib

:tada: This PR is included in version 1.7.2 :tada:
The release is available on npm package (@latest dist-tag)
Your semantic-release bot :package::rocket:


"High compliancy" is not explained

Continuing from babel/babel#1930.
OK I can see why it can be useful to use high compliancy and loose mode together, but it's confusing with the current labeling. Maybe the solution is to add a note under the "High compliancy" checkbox, saying "Enables optional spec transformers".

Even experimental should maybe be changed to a dropdown for stage with a description of each?
Related #92

Closing since this was a babel 5 option


Make sure the Like/Tweet buttons work

Currently they don't—hitting "Like" pops up a dialog under the "Popular Photos" panel and going off the right edge of the screen.

[x] Like home screen
[x] Share home screen
[x] Tweet home screen
[ ] Like image details
[ ] Share image details
[ ] Tweet image details
[x] Comment widget

A few issues:

Tweet on image details is missing cross-street information.
Facebook Share has the wrong URL & the Like button turns to "Error" when you click it.


Clarify that channel_message_counts is optional, update variable-length field byte counts to "4 + N"

I wonder if we are doing something weird with the whole 4+N thing. On one hand we've defined the types to have length prefixes so the N could be read to include the prefix size?

@defunctzombie the 4 + N was an additional clarifier for me that these are length prefixed (and the length prefix is uint32), and I don't think there's a downside to this additional clarity.

The length field updates I've included in this branch: https://github.com/foxglove/mcap/tree/roman/spec-format/docs/specification
I don't know about the optional channel counts in statistics. If you set it to 0, should a reader treat that as an indication that there are no messages in the file? Other records where we allow 0 (i.e. Footer with offsets), 0 means there are no records of that type. A 0 here doesn't actually mean there are no channels in the file - just that the statistics record lied to you.
I would be in favor of a separate statistics record for these counts if we want to make this actually optional. Or a field indicating whether this count is used.

Closing - I've incorporated the changes to the latest working copy.