Izhang issue 170

Addressing:
https://github.com/open-cluster-management/multicloud-operators-subscription/issues/170
and
https://github.com/open-cluster-management/multicloud-operators-subscription/issues/166
170,
when a user uses a subscription to deploy a CRD at GVK apiextensions.k8s.io/v1beta1, our code will convert the apiextensions.k8s.io/v1, then the converted template will fail to apply.
User's yaml
apiVersion: apiextensions.k8s.io/v1beta1
kind: CustomResourceDefinition
metadata:
  labels:
    operator.kubevirt.io: ""
  name: kubevirts.kubevirt.io
spec:

The failure is due to that, for these 2 versions, the k8s have different validation rules. On v1 there's an extra field required. So simply replace the GVK won't work for us.
At the meantime, if we use kubectl to apply the user's sample CRD at apiextensions.k8s.io/v1beta1, it will process without any issue. It seems our code is limiting incoming resources.
We are using the following code to limited the resources to be served, mainly limiting resource version.
pkg/synchronizer/kubernetes/discovery.go
resources, err := discovery.NewDiscoveryClientForConfigOrDie(sync.localConfig).ServerPreferredResources()
The ServerPreferredResources would only return the latest resource version to our code, then we convert out-of-date version to the lasted version.
I feel, we should use ServerResources to list all the resource versions(GVK) since we should reflect the full capacity of the managed cluster... but maybe there are some other design considerations against doing a full GVK list, can you please comment on this one @xiangjingli  @rokej  @kuanf
166,
It seems when the CRD is updated, the GVK list(cache) is not updated right away, so our code will complain the kind is not supported yet.
I believe we can force the GVK list to rebuild via,
pkg/synchronizer/kubernetes/synchronizer.go
sync.rediscoverResource()

The other changes are mainly for the format issues.

@xiangjingli
I'm seeing the following test case is failing,
=== RUN   TestGVKValidation
I0422 23:25:44.800863   14121 discovery.go:149] Discovering cluster resources
--- FAIL: TestGVKValidation (0.05s)
    sync_test.go:134:
        Expected
            <*schema.GroupVersionKind | 0xc0005174a0>: {Group: "apps", Version: "v1beta1", Kind: "StatefulSet"}
        to equal
            <*schema.GroupVersionKind | 0xc0005173b0>: {Group: "apps", Version: "v1", Kind: "StatefulSet"}

Do you still remember if we are doing this version change for some special issue or I can just update the test cases so that we are not doing this version change?

Hi @rokej @xiangjingli
I was consulting this with @kuanf. He pointed out that, if we use the ServerResources it will add more watch on the controller... which could be a very bad idea.
He suggested, in the long run, we should still use the ServerPreferredResources but need to redo some caching logic. So I'm going to hold on to this PR.
For the user's issue, I guess we should direct the user to use apiextensions.k8s.io/v1 instead, which will skip the version conversion part from our code, meaning we can workaround issue #170
When I was trying this  with apiextensions.k8s.io/v1 on my own, I hit the following part,  #166
I0421 17:06:26.795155       1 gitrepo.go:369] kubevirt.io/v1alpha3/KubeVirt
W0421 17:06:26.795269       1 gitrepo.go:76] Not a Kubernetes resource
I0421 17:06:26.797963       1 gitrepo.go:386] Multi resource
I0421 17:06:26.798020       1 gitrepo.go:340] otherFiles size ^B
W0421 17:06:26.798052       1 helmrepo.go:373] subsciption.spec.name is missing for subscription: ec/cnv-appsub
W0421 17:06:26.798197       1 gitrepo.go:76] Not a Kubernetes resource
I0421 17:06:26.798479       1 subscriber_item.go:284] Skipping resource
E0421 17:06:26.798635       1 subscriber_item.go:270] Failed to apply a resource, error: Resource kubevirt.io/v1alpha3, Kind=KubeVirt is
 not supported

FYI, yaml used to reproduce
Checking the logic, it seems that the CR is not requeue correctly. The flow goes this way,

CRD and CR is pulled from github and apply to cluster
CRD will be applied, and CR will be rejected, since on manged cluster, we don't have a CRD to support CR
CRD applied successfully, and CRD cache is updated
GitHub doSubscription() kicks in, however, since the git commit ID doesn't change, so we won't retry the CR.

https://github.com/open-cluster-management/multicloud-operators-subscription/blob/4c146908ef91cf8fb3f9da866c1c539f9f5334dd/pkg/subscriber/github/subscriber_item.go#L114-L125
@rokej do you think if we can find a way to re-queue the CR? It seems if we have multiple resources within the same git commit, then the failed one won't be retried.


Timepicker: the bind value is not updated when click on "clear"

In the timepicker, when we click on the button "Clear", the value isn't updated.
Currently, the value is updated by the afterdone event:
afterDone: this.afterDone.bind(this)
But this event is called only when click on "OK".
In my opinion, we should you an $(this.element).on('change', ...); to update the value. It seems to work with the "OK" and "Clear" button. And the afterdone event is useless.
What do you think?

I'd rather stick to the timepicker API instead of listening for change events on the input.
afterHide seems to be triggered by clear as well.

Actually, your idea works better. 👍

I hope they will update the timepicker API in the version 1.0 to avoid this "hack". Thanks for the change.


Gh 256 eclipse

Relates to #256

@030 I thought your packages were automatic packages?  This is not a problem if not, I just thought that the main problem that you had was that you didn't have a windows server to run ketarin in order to continue automatically pushing the packages.
Also, with regard to your common functions, I think that it might be better to include them as an extension package, and then take a dependency on that package, rather than dot sourcing them.  That way, if anything changes in one of those files, you can push out a new version of the extension package, without touching the actual package itself.  You can see examples of these in the extensions folder in this repository.

@030 did you happen to see my comment above?  Thanks!

I think we should close this as there is no feedback.

Agreed


Still getting Index out of range error calling GetPlayerMap

Still getting the Index out of range error in sessions.go, when accessing one of the Returns slice at index 0
This is the exact code:
package main

import (
    "log"

    "golang.org/x/net/context"

    "github.com/pkmngo-odi/pogo/api"
    "github.com/pkmngo-odi/pogo/auth"
)

func main() {

    ctx := context.Background()

    provider, err := auth.NewProvider("ptc", "xqaYVxmzdVD8AjS", "EGi9tUf8cmIOq9a")
    if err != nil {
        log.Println(err)
        return
    }

    location := &api.Location{
        Lon: 0.0,
        Lat: 0.0,
        Alt: 0.0,
    }

    feed := &api.VoidFeed{}

    session := api.NewSession(provider, location, feed, false)
    err = session.Init(ctx)
    if err != nil {
        log.Println(err)
        return
    }

    _, err = session.GetPlayer(ctx)
    if err != nil {
        log.Println(err)
        return
    }

    _, err = session.GetPlayerMap(ctx)
    if err != nil {
        log.Println(err)
        return
    }

    _, err = session.Announce(ctx)
    if err != nil {
        log.Println(err)
        return
    }
}

The stacktrace:
Moddy:~/go/src/github.com/moddyz/pokemapgo$ go build -v . && ./pokemapgo
github.com/moddyz/pokemapgo
panic: runtime error: index out of range

goroutine 1 [running]:
panic(0x417620, 0xc82000a0b0)
	/usr/local/go/src/runtime/panic.go:481 +0x3e6
github.com/pkmngo-odi/pogo/api.(*Session).GetPlayerMap(0xc820012640, 0x8951a0, 0xc82000a2a8, 0xc82042c2c0, 0x0, 0x0)
	/Users/Moddy/go/src/github.com/pkmngo-odi/pogo/api/session.go:230 +0x5e8
main.main()
	/Users/Moddy/go/src/github.com/moddyz/pokemapgo/main.go:43 +0x4c7

@moddyz Still having issues?

I'm getting the error. I think it's caused by too many requests per second or at the same time.
Dirty fix from me:
	mapObjects = &protos.GetMapObjectsResponse{}
	if(len(response.Returns) > 5) {
		err = proto.Unmarshal(response.Returns[5], mapObjects)
		if err != nil {
			return nil, &ErrResponse{err}
		}
	} else {
		return nil, errors.New("Empty response")
	}

Not getting the error anymore after staggering the requests to 1 per second

@femot So if you're doing more than 1 requests per second, you start getting this error again? Reeks of concurrency issues.

@zeeraw Didn't try to find out the breakpoint, but 1s seems to work fine for now.
@moddyz code is a good example because he calls session.GetPlayer(ctx) in rapid succession without concurrency.
I also had the problem sometimes after startup while using 1 account (rarely). After switching tests to 5 accounts it happened all the time (they were calling session.GetPlayer(ctx) simultaneously before i fixed it).
If you want I can try a few things, but I thought I read something about this being an issue on Niantics side where they just say "nope" if you're doing too much - not 100% sure though.
The code I used can be found here: https://github.com/femot/spawnfinder

@zeeraw I did some testing with this: https://gist.github.com/femot/685f4796c090de5a6ee85e08d4c0dcf3
Seems like the magic value is around 120ms.

fixed in ec8a3f26e4dde20585f6e0329501413bbc1673a4


Support LINE quick reply

https://developers.line.me/en/news/#quick-reply-released-2018-07-31

So will it be like
client.pushText(userId, text, { quickReply: { items: [/* items */] } })

?


initialEditorState removed in latest version

Is there any particular reason for removing initialEditorState from the newest version?

Hello @damir-i , initialEditorState property is deprecated with Lexical 0.5, see;
https://github.com/facebook/lexical/commit/8cba075fd9b135545dbfa4d8831e47284045e134
Seems like, the functionality of initializing an editor state is moved to LexicalComposer;
https://lexical.dev/docs/concepts/editor-state#understanding-the-editor-state
<LexicalComposer initialConfig={{
  editorState: initialEditorState
}}>
  <LexicalRichTextPlugin />
  <LexicalOnChangePlugin onChange={editorState => editorStateRef.current = editorState} />
  <Button label="Save" onPress={() => {
    if (editorStateRef.current) {
      saveContent(JSON.stringify(editorStateRef.current))
    }
  }} />
</LexicalComposer>

We need to adapt verbum to this changes accordingly.

Thank you for your response, I will keep using the older version until this is adapted.

Thank you for your response, I will keep using the older version until this is adapted.

0.4.1 is now released with initialEditorState feature.

hey there, i'm new to verbum/lexical. is initialEditorState how we would set an intial value in the editor?
my usecase: we have a form, onChange we save to our data, before submission a use can preview their submission (new page), but they can go back to change things, but the editor is blank. i'd like to paste back in that data we saved from their current work in progress.
so need to know how to set the ('.ContentEditable__root').innerHTML with an initial value, thanks!


Compilation Errors

I know that in the past, swift-nio-ssl wasn't officially supported on Windows, but now that Swift itself has an official Windows port, I figured that I should report a compilation issue that occurs with the official Swift for Windows toolchain:
In file included from C:\Users\gjaco\Desktop\Shuttle-Tracker-Server\.build\checkouts\swift-nio-ssl\Sources\CNIOBoringSSL\ssl\tls_record.cc:118:
In file included from C:\Users\gjaco\Desktop\Shuttle-Tracker-Server\.build\checkouts\swift-nio-ssl\Sources\CNIOBoringSSL\ssl/internal.h:173:
In file included from C:\Program Files (x86)\Windows Kits\10\include\10.0.20348.0\um\winsock2.h:116:
C:\Program Files (x86)\Windows Kits\10\include\10.0.20348.0\shared\ws2def.h:240:16: error: redefinition of 'sockaddr'
typedef struct sockaddr {
               ^
C:\Program Files (x86)\Windows Kits\10\include\10.0.20348.0\um\winsock.h:482:8: note: previous definition is here
struct sockaddr {
       ^
In file included from C:\Users\gjaco\Desktop\Shuttle-Tracker-Server\.build\checkouts\swift-nio-ssl\Sources\CNIOBoringSSL\ssl\tls_record.cc:118:
In file included from C:\Users\gjaco\Desktop\Shuttle-Tracker-Server\.build\checkouts\swift-nio-ssl\Sources\CNIOBoringSSL\ssl/internal.h:173:
In file included from C:\Program Files (x86)\Windows Kits\10\include\10.0.20348.0\um\winsock2.h:116:
C:\Program Files (x86)\Windows Kits\10\include\10.0.20348.0\shared\ws2def.h:442:5: error: expected identifier
    IPPROTO_ICMP          = 1,
    ^
C:\Program Files (x86)\Windows Kits\10\include\10.0.20348.0\um\winsock.h:211:33: note: expanded from macro 'IPPROTO_ICMP'
#define IPPROTO_ICMP            1               /* control message protocol */
                                ^
In file included from C:\Users\gjaco\Desktop\Shuttle-Tracker-Server\.build\checkouts\swift-nio-ssl\Sources\CNIOBoringSSL\ssl\tls_record.cc:118:
In file included from C:\Users\gjaco\Desktop\Shuttle-Tracker-Server\.build\checkouts\swift-nio-ssl\Sources\CNIOBoringSSL\ssl/internal.h:173:
In file included from C:\Program Files (x86)\Windows Kits\10\include\10.0.20348.0\um\winsock2.h:116:
C:\Program Files (x86)\Windows Kits\10\include\10.0.20348.0\shared\ws2def.h:443:5: error: expected identifier
    IPPROTO_IGMP          = 2,
    ^
C:\Program Files (x86)\Windows Kits\10\include\10.0.20348.0\um\winsock.h:212:33: note: expanded from macro 'IPPROTO_IGMP'
#define IPPROTO_IGMP            2               /* group management protocol */
                                ^
In file included from C:\Users\gjaco\Desktop\Shuttle-Tracker-Server\.build\checkouts\swift-nio-ssl\Sources\CNIOBoringSSL\ssl\tls_record.cc:118:
In file included from C:\Users\gjaco\Desktop\Shuttle-Tracker-Server\.build\checkouts\swift-nio-ssl\Sources\CNIOBoringSSL\ssl/internal.h:173:
In file included from C:\Program Files (x86)\Windows Kits\10\include\10.0.20348.0\um\winsock2.h:116:
C:\Program Files (x86)\Windows Kits\10\include\10.0.20348.0\shared\ws2def.h:444:5: error: expected identifier
    IPPROTO_GGP           = 3,
    ^
C:\Program Files (x86)\Windows Kits\10\include\10.0.20348.0\um\winsock.h:213:33: note: expanded from macro 'IPPROTO_GGP'
#define IPPROTO_GGP             3               /* gateway^2 (deprecated) */
                                ^
In file included from C:\Users\gjaco\Desktop\Shuttle-Tracker-Server\.build\checkouts\swift-nio-ssl\Sources\CNIOBoringSSL\ssl\tls_record.cc:118:
In file included from C:\Users\gjaco\Desktop\Shuttle-Tracker-Server\.build\checkouts\swift-nio-ssl\Sources\CNIOBoringSSL\ssl/internal.h:173:
In file included from C:\Program Files (x86)\Windows Kits\10\include\10.0.20348.0\um\winsock2.h:116:
C:\Program Files (x86)\Windows Kits\10\include\10.0.20348.0\shared\ws2def.h:451:5: error: expected identifier
    IPPROTO_TCP           = 6,
    ^
C:\Program Files (x86)\Windows Kits\10\include\10.0.20348.0\um\winsock.h:214:33: note: expanded from macro 'IPPROTO_TCP'
#define IPPROTO_TCP             6               /* tcp */
                                ^
In file included from C:\Users\gjaco\Desktop\Shuttle-Tracker-Server\.build\checkouts\swift-nio-ssl\Sources\CNIOBoringSSL\ssl\tls_record.cc:118:
In file included from C:\Users\gjaco\Desktop\Shuttle-Tracker-Server\.build\checkouts\swift-nio-ssl\Sources\CNIOBoringSSL\ssl/internal.h:173:
In file included from C:\Program Files (x86)\Windows Kits\10\include\10.0.20348.0\um\winsock2.h:116:
C:\Program Files (x86)\Windows Kits\10\include\10.0.20348.0\shared\ws2def.h:457:5: error: expected identifier
    IPPROTO_PUP           = 12,
    ^
C:\Program Files (x86)\Windows Kits\10\include\10.0.20348.0\um\winsock.h:215:33: note: expanded from macro 'IPPROTO_PUP'
#define IPPROTO_PUP             12              /* pup */
                                ^
In file included from C:\Users\gjaco\Desktop\Shuttle-Tracker-Server\.build\checkouts\swift-nio-ssl\Sources\CNIOBoringSSL\ssl\tls_record.cc:118:
In file included from C:\Users\gjaco\Desktop\Shuttle-Tracker-Server\.build\checkouts\swift-nio-ssl\Sources\CNIOBoringSSL\ssl/internal.h:173:
In file included from C:\Program Files (x86)\Windows Kits\10\include\10.0.20348.0\um\winsock2.h:116:
C:\Program Files (x86)\Windows Kits\10\include\10.0.20348.0\shared\ws2def.h:458:5: error: expected identifier
    IPPROTO_UDP           = 17,
    ^
C:\Program Files (x86)\Windows Kits\10\include\10.0.20348.0\um\winsock.h:216:33: note: expanded from macro 'IPPROTO_UDP'
#define IPPROTO_UDP             17              /* user datagram protocol */
                                ^
In file included from C:\Users\gjaco\Desktop\Shuttle-Tracker-Server\.build\checkouts\swift-nio-ssl\Sources\CNIOBoringSSL\ssl\tls_record.cc:118:
In file included from C:\Users\gjaco\Desktop\Shuttle-Tracker-Server\.build\checkouts\swift-nio-ssl\Sources\CNIOBoringSSL\ssl/internal.h:173:
In file included from C:\Program Files (x86)\Windows Kits\10\include\10.0.20348.0\um\winsock2.h:116:
C:\Program Files (x86)\Windows Kits\10\include\10.0.20348.0\shared\ws2def.h:459:5: error: expected identifier
    IPPROTO_IDP           = 22,
    ^
C:\Program Files (x86)\Windows Kits\10\include\10.0.20348.0\um\winsock.h:217:33: note: expanded from macro 'IPPROTO_IDP'
#define IPPROTO_IDP             22              /* xns idp */
                                ^
In file included from C:\Users\gjaco\Desktop\Shuttle-Tracker-Server\.build\checkouts\swift-nio-ssl\Sources\CNIOBoringSSL\ssl\tls_record.cc:118:
In file included from C:\Users\gjaco\Desktop\Shuttle-Tracker-Server\.build\checkouts\swift-nio-ssl\Sources\CNIOBoringSSL\ssl/internal.h:173:
In file included from C:\Program Files (x86)\Windows Kits\10\include\10.0.20348.0\um\winsock2.h:116:
C:\Program Files (x86)\Windows Kits\10\include\10.0.20348.0\shared\ws2def.h:475:5: error: expected identifier
    IPPROTO_ND            = 77,
    ^
C:\Program Files (x86)\Windows Kits\10\include\10.0.20348.0\um\winsock.h:218:33: note: expanded from macro 'IPPROTO_ND'
#define IPPROTO_ND              77              /* UNOFFICIAL net disk proto */
                                ^
In file included from C:\Users\gjaco\Desktop\Shuttle-Tracker-Server\.build\checkouts\swift-nio-ssl\Sources\CNIOBoringSSL\ssl\tls_record.cc:118:
In file included from C:\Users\gjaco\Desktop\Shuttle-Tracker-Server\.build\checkouts\swift-nio-ssl\Sources\CNIOBoringSSL\ssl/internal.h:173:
In file included from C:\Program Files (x86)\Windows Kits\10\include\10.0.20348.0\um\winsock2.h:116:
C:\Program Files (x86)\Windows Kits\10\include\10.0.20348.0\shared\ws2def.h:485:5: error: expected identifier
    IPPROTO_RAW           = 255,
    ^
C:\Program Files (x86)\Windows Kits\10\include\10.0.20348.0\um\winsock.h:220:33: note: expanded from macro 'IPPROTO_RAW'
#define IPPROTO_RAW             255             /* raw IP packet */
                                ^
In file included from C:\Users\gjaco\Desktop\Shuttle-Tracker-Server\.build\checkouts\swift-nio-ssl\Sources\CNIOBoringSSL\ssl\tls_record.cc:118:
In file included from C:\Users\gjaco\Desktop\Shuttle-Tracker-Server\.build\checkouts\swift-nio-ssl\Sources\CNIOBoringSSL\ssl/internal.h:173:
In file included from C:\Program Files (x86)\Windows Kits\10\include\10.0.20348.0\um\winsock2.h:116:
C:\Program Files (x86)\Windows Kits\10\include\10.0.20348.0\shared\ws2def.h:487:5: error: expected identifier
    IPPROTO_MAX           = 256,
    ^
C:\Program Files (x86)\Windows Kits\10\include\10.0.20348.0\um\winsock.h:221:33: note: expanded from macro 'IPPROTO_MAX'
#define IPPROTO_MAX             256
                                ^
In file included from C:\Users\gjaco\Desktop\Shuttle-Tracker-Server\.build\checkouts\swift-nio-ssl\Sources\CNIOBoringSSL\ssl\tls_record.cc:118:
In file included from C:\Users\gjaco\Desktop\Shuttle-Tracker-Server\.build\checkouts\swift-nio-ssl\Sources\CNIOBoringSSL\ssl/internal.h:173:
In file included from C:\Program Files (x86)\Windows Kits\10\include\10.0.20348.0\um\winsock2.h:116:
C:\Program Files (x86)\Windows Kits\10\include\10.0.20348.0\shared\ws2def.h:638:16: error: redefinition of 'sockaddr_in'
typedef struct sockaddr_in {
               ^
C:\Program Files (x86)\Windows Kits\10\include\10.0.20348.0\um\winsock.h:309:8: note: previous definition is here
struct sockaddr_in {
       ^
In file included from C:\Users\gjaco\Desktop\Shuttle-Tracker-Server\.build\checkouts\swift-nio-ssl\Sources\CNIOBoringSSL\ssl\tls_record.cc:118:
In file included from C:\Users\gjaco\Desktop\Shuttle-Tracker-Server\.build\checkouts\swift-nio-ssl\Sources\CNIOBoringSSL\ssl/internal.h:173:
C:\Program Files (x86)\Windows Kits\10\include\10.0.20348.0\um\winsock2.h:136:16: error: redefinition of 'fd_set'
typedef struct fd_set {
               ^
C:\Program Files (x86)\Windows Kits\10\include\10.0.20348.0\um\winsock.h:65:16: note: previous definition is here
typedef struct fd_set {
               ^
In file included from C:\Users\gjaco\Desktop\Shuttle-Tracker-Server\.build\checkouts\swift-nio-ssl\Sources\CNIOBoringSSL\ssl\tls_record.cc:118:
In file included from C:\Users\gjaco\Desktop\Shuttle-Tracker-Server\.build\checkouts\swift-nio-ssl\Sources\CNIOBoringSSL\ssl/internal.h:173:
C:\Program Files (x86)\Windows Kits\10\include\10.0.20348.0\um\winsock2.h:180:8: error: redefinition of 'timeval'
struct timeval {
       ^
C:\Program Files (x86)\Windows Kits\10\include\10.0.20348.0\um\winsock.h:108:8: note: previous definition is here
struct timeval {
       ^
In file included from C:\Users\gjaco\Desktop\Shuttle-Tracker-Server\.build\checkouts\swift-nio-ssl\Sources\CNIOBoringSSL\ssl\tls_record.cc:118:
In file included from C:\Users\gjaco\Desktop\Shuttle-Tracker-Server\.build\checkouts\swift-nio-ssl\Sources\CNIOBoringSSL\ssl/internal.h:173:
C:\Program Files (x86)\Windows Kits\10\include\10.0.20348.0\um\winsock2.h:236:9: error: redefinition of 'hostent'
struct  hostent {
        ^
C:\Program Files (x86)\Windows Kits\10\include\10.0.20348.0\um\winsock.h:164:9: note: previous definition is here
struct  hostent {
        ^
In file included from C:\Users\gjaco\Desktop\Shuttle-Tracker-Server\.build\checkouts\swift-nio-ssl\Sources\CNIOBoringSSL\ssl\tls_record.cc:118:
In file included from C:\Users\gjaco\Desktop\Shuttle-Tracker-Server\.build\checkouts\swift-nio-ssl\Sources\CNIOBoringSSL\ssl/internal.h:173:
C:\Program Files (x86)\Windows Kits\10\include\10.0.20348.0\um\winsock2.h:249:9: error: redefinition of 'netent'
struct  netent {
        ^
C:\Program Files (x86)\Windows Kits\10\include\10.0.20348.0\um\winsock.h:177:9: note: previous definition is here
struct  netent {
        ^
In file included from C:\Users\gjaco\Desktop\Shuttle-Tracker-Server\.build\checkouts\swift-nio-ssl\Sources\CNIOBoringSSL\ssl\tls_record.cc:118:
In file included from C:\Users\gjaco\Desktop\Shuttle-Tracker-Server\.build\checkouts\swift-nio-ssl\Sources\CNIOBoringSSL\ssl/internal.h:173:
C:\Program Files (x86)\Windows Kits\10\include\10.0.20348.0\um\winsock2.h:256:9: error: redefinition of 'servent'
struct  servent {
        ^
C:\Program Files (x86)\Windows Kits\10\include\10.0.20348.0\um\winsock.h:184:9: note: previous definition is here
struct  servent {
        ^
In file included from C:\Users\gjaco\Desktop\Shuttle-Tracker-Server\.build\checkouts\swift-nio-ssl\Sources\CNIOBoringSSL\ssl\tls_record.cc:118:
In file included from C:\Users\gjaco\Desktop\Shuttle-Tracker-Server\.build\checkouts\swift-nio-ssl\Sources\CNIOBoringSSL\ssl/internal.h:173:
C:\Program Files (x86)\Windows Kits\10\include\10.0.20348.0\um\winsock2.h:268:9: error: redefinition of 'protoent'
struct  protoent {
        ^
C:\Program Files (x86)\Windows Kits\10\include\10.0.20348.0\um\winsock.h:196:9: note: previous definition is here
struct  protoent {
        ^
In file included from C:\Users\gjaco\Desktop\Shuttle-Tracker-Server\.build\checkouts\swift-nio-ssl\Sources\CNIOBoringSSL\ssl\tls_record.cc:118:
In file included from C:\Users\gjaco\Desktop\Shuttle-Tracker-Server\.build\checkouts\swift-nio-ssl\Sources\CNIOBoringSSL\ssl/internal.h:173:
C:\Program Files (x86)\Windows Kits\10\include\10.0.20348.0\um\winsock2.h:364:16: error: redefinition of 'WSAData'
typedef struct WSAData {
               ^
C:\Program Files (x86)\Windows Kits\10\include\10.0.20348.0\um\winsock.h:319:16: note: previous definition is here
typedef struct WSAData {
               ^
fatal error: too many errors emitted, stopping now [-ferror-limit=]
20 errors generated.
[0/901] Compiling CNIOBoringSSL ssl\tls_record.cc

Some research that I've done seems to indicate that this issue arises because on Windows, swift-nio-ssl runs #include <windows.h> before #include <winsock2.h>. If my diagnosis is correct, then I imagine that it wouldn't be too difficult to fix.
Here's a relevant Stack Overflow thread: https://stackoverflow.com/questions/1372480/c-redefinition-header-files-winsock2-h

Thanks for filing this issue! Unfortunately, swift-nio itself doesn’t compile on Windows, and without getting that working we can’t get swift-nio-ssl working either.


Cant open Duckdb files of version 43

Cant open Duckdb files of version 43, only version 39

We can't help with that, you need to upgrade your DuckDB library.

Thanks, pip install duckdb==0.7.1 worked.


Activating Open Collective

This pull request adds backers and sponsors from your Open Collective https://opencollective.com/git-point ❤
It adds two badges at the top to show the latest number of backers and sponsors. It also adds placeholders so that the avatar/logo of new backers/sponsors can automatically be shown without having to update your README.md. [more info]. See how it looks on this repo.
We have also added a postinstall script to let people know after npm|yarn install that you are welcoming donations (optional). [More info]
You can also add a "Donate" button to your website and automatically show your backers and sponsors there with our widgets. Have a look here: https://opencollective.com/widgets
P.S: As with any pull request, feel free to comment or suggest changes. The only thing "required" are the placeholders on the README because we believe it's important to acknowledge the people in your community that are contributing (financially or with code!).
Thank you for your great contribution to the open source community. You are awesome! 🙌
And welcome to the open collective community! 😊
Come chat with us in the #opensource channel on https://slack.opencollective.com - great place to ask questions and share best practices with other open source sustainers!

Woohoo thank you @asood123 🎉  🎉  🎉
CC @lex111 @andrewda @machour


Tests for Input and Select components

I didn't do all components because the template will change when we've switched to Typescript. Vue 3 has better Typescript and Vue 2 is on its way out, so we should upgrade before continuing test.

This is a great starting point, thanks Roman!


Does Nancy support custom request headers?

I need to add a custom header but it looks like its read only. Is there somewhere else in the framework to do this?
ctx.Request.Headers = new RequestHeaders(new_headers);

Why do you want to change the headers sent by the client?

I want to inject a custom header that tells the backend servers what app instance to use.

And they accept NancyRequestHeaders? I'd say the ctx.Items hash is more suited for that purpose

I'm using HAProxy acl rules to filter the header out.

That doesn't seem to do anything.

Why, exactly, do you want this to be an actual header when it does not originate from the actual client itself? What are you trying to accomplish?

I ended solving my problem with a cookie instead. Thanks


Release docker images for Azure Linux 3.0

Azure Linux 3.0 is now preview. Its docker image is available at azurelinuxpreview.azurecr.io/public/azurelinux/base/core:3.0.
Azure CLI should release docker images for Azure Linux 3.0 and publish them to Microsoft Artifact Registry (MAR) https://mcr.microsoft.com/ .

Thank you for opening this issue, we will look into it.

Official image is released: mcr.microsoft.com/azurelinux/base/core:3.0

We've release azure linux 3 image from 2.65.0 https://mcr.microsoft.com/en-us/artifact/mar/azure-cli/tags


fix: complete removal of ./templates folder started in #311

This should fix failure of operator-test in kudobuilder/kudo repo (like observed in https://app.circleci.com/pipelines/github/kudobuilder/kudo/5631/workflows/28d9ebb7-bbc4-4218-a9fa-a4a52505a62e/jobs/17182)

lgtm, although I accidently already commited this change to master :-/


iwr : Unable  to connect to remote server

Describe the bug
A clear and concise description of what the bug is.
To Reproduce
Steps to reproduce the behavior:

Go to '...'
Click on '....'
Scroll down to '....'
See error

Expected behavior
A clear and concise description of what you expected to happen.
Screenshots
If applicable, add screenshots to help explain your problem.
Additional context
Add any other context about the problem here.

Try irm https://christitus.com/win | iex

no same issue well debloat worked the first time i used then after restart started happening

Can you connect to https://christitus.com and git.io using a web browser?

yes man same problem

sounds like a DNS issue.
Try this
[Net.ServicePointManager]::SecurityProtocol=[Net.SecurityProtocolType]::Tls12;iex(New-Object Net.WebClient).DownloadString('https://raw.githubusercontent.com/ChrisTitusTech/winutil/main/winutil.ps1')

its working after conneting to dns <IP_ADDRESS>

can you help me King527

just download <IP_ADDRESS> dns from google
and connect to it then it will work

If its a dns issue:

it tried but same issue

i dont know what to do i will just reset the computer now

Did you run the windows troubleshooter for network connectivity? It usually resets the network connection to default settings which might work

let it run and maybe it works.
Did you reach the internet at any time before?

Yeah it was a dns issue i have a windows11 so after reseting the networks setting i just again change dns to <IP_ADDRESS> and <IP_ADDRESS> and turn on DNS over HTTPs and Fall back to plain text and it worked thanks you for the support i would have formated but i believed in the community

Great to hear its working again :)

It is still not working for me. Even after changing the DNS severs.

Can you open the address in your normal browser?

Can you open the address in your normal browser?

which address?

Thhe one mentioned in the screenshot

Did you run the script as admin?

Did you run the script as admin?

Yes I did.

Tried all the solution mentioned above i'm still getting the issue anyone please help

Worked for me when I changed my IPv6 DNS as well as IPv4.
2606:4700:4700::1111
2606:4700:4700::1001

bro  help me out here.. anyone.... im still having the problem

Hey buddy,
It's nothing but DNS issues just change DNS as stated on website you might
also find on comments also I actually not remember right now.
You might need to restart your device once connect to network.
Try once or twice.
On Sun, Sep 17, 2023, 8:46 PM Richard9526 @.***> wrote:

bro help me out here.. anyone.... im still having the problem
—
Reply to this email directly, view it on GitHub
https://github.com/ChrisTitusTech/winutil/issues/464#issuecomment-1722499300,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AUBQA5TJLLW3U5B2EJDCUOLX24H3RANCNFSM6AAAAAASPATCXI
.
You are receiving this because you commented.Message ID:
@.***>

THE THING IS... i installed  a tweaks for the notification pop up to stop and it did...but thn i realised i needed it back so i had to recheck it again on the christitustool page...but thn now its just showing...
Unable to connect to the server,,,
i changed DNS, restarted, tried the other links..still the same  damnn problem

Trust me bro  try different ways of changing DNS or change whole network (
your wifi to mobile hotspot or something)
It's really a DNS issue and nothing else
Try again you will figure it out
On Mon, Sep 18, 2023, 11:24 AM Richard9526 @.***> wrote:

THE THING IS... i installed a tweaks for the notification pop up to stop
and it did...but thn i realised i needed it back so i had to recheck it
again on the christitustool page...but thn now its just showing...
Unable to connect to the server,,,
i changed DNS, restarted, tried the other links..still the same damnn
problem
—
Reply to this email directly, view it on GitHub
https://github.com/ChrisTitusTech/winutil/issues/464#issuecomment-1722792301,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AUBQA5RYMFJ4HSFXLST5NQTX27OXZANCNFSM6AAAAAASPATCXI
.
You are receiving this because you commented.Message ID:
@.***>

THE THING IS... i installed a tweaks for the notification pop up to stop and it did...but thn i realised i needed it back so i had to recheck it again on the christitustool page...but thn now its just showing... Unable to connect to the server,,, i changed DNS, restarted, tried the other links..still the same damnn problem

Use vpn and it'll work

I found whats causing this problem. Its IPv6. Changing DNS didnt make any difference.
Disable IPv6 to fix it before running the script.

On any system which i face this issue i just go onto the google dns website and change my IPv4 and IPv6 dns address by going into the network adapter settings as shown earlier by some.
IPv4:
<IP_ADDRESS>
<IP_ADDRESS>

IPv6:
2001:4860:4860::8888
2001:4860:4860::8844

Some older devices may even use:
2001:4860:4860:0:0:0:0:8888
2001:4860:4860:0:0:0:0:8844

As a plus it even helps resolving of domains faster ( loading websites faster )


Windows VMs generation

Description
Windows Vms have the Problem that they can not start when using more than 8gb RAM.
https://docs.ionos.com/cloud/compute/compute-engine/compute-engine-faq#what-are-the-maximum-resources-available-for-a-server
I haven't found a way to set the ram value to 8gb or less on the first apply and ingress it on the second without changing a Variable in some strange way.
This makes automating a Deployment with new Windows Vms Impossible and IaC useless.
Expected behavior
I dont know where this workaround should be.
terraform sdk = first start a 4 gb vm and modify it to use the defined memory.
cloud api = the cloud api could do the same while the underlying Problem is not fixed.
Environment
Terraform version:

Provider version:

OS:

Configuration Files

How to Reproduce

Error and Debug Output

Additional Notes

References

Thanks for raising this, we are looking at providing a workaround to be able to create using terraform and not needing to update after. We still need to do some research to how feasible it is.

Hello and thank you for raising this.
I tried to create a server with an Windows image with more than 8GB of RAM and it worked every time (more than 5 times, even with 32 GB). I know that there is a may not always work in the documentation, I will discuss with the other teams about that note that you highlighted. Anyways, for me it worked, I cannot take that for granted (I'm assuming that there are some cases in which this is failing), but I could successfully boot the machine, log in and play with the server, so I can't reproduce this problem.
For that reason, please, if possible, share with us a terraform plan that you used and that led you to this problem. Also, can you please tell me how do you know if there is a problem. I mean: is the provisioning done successfully and you can't boot the machine? Or is there any error message during the provisioning that says that the provisioning could not be done because of the RAM configuration? I want to know how we can identify the problem: maybe we can do it from the provisioning phase or maybe we need to manually boot the machine and check that everything is working fine.
Thank you!

Update: I've been told that this behavior is related to Windows Server 2012/R2 and older systems. I managed to reproduce it by creating a server with windows-2012-r2-server-2023-06 image. The provision is done successfully but if I try to boot the machine I have some configuration errors.
Creating the server and immediately changing the RAM memory does not solve the problem.
I will investigate this, in the mean time, if possible, please use a newer Windows image. This is the most basic work-around I can give you right now, but it's the only one.


Automate linkcheck

Include one build with linkcheck. However, allow it to fail (human eye required for judging...).

Coverage decreased (-1.4%) to 96.966% when pulling 45fab4926cb1c0d011a0a58c091b95d0d86c03ed on linkcheck into 1f37a2ae66a84907af331fa0242353bdfbf5afe0 on master.


Crystal run/eval: pass the file name and the following arguments to the program

Description
In most interpreters, the file name and the following arguments are passed to the program.
For example in python:
#!/usr/bin/python -OO
import sys
print(sys.argv)

$ 2 ./myapp.py arg1 arg2 # or python -OO myapp.py arg1 arg2
$ ['myapp', 'arg1', 'arg2']

or in shell:
#!/bin/sh -eu
echo $@

$ ./myapp.sh arg1 arg2 # or sh -eu myapp.sh arg1 arg2
$ arg1 arg2

Purpose
This will allow us to execute directly Crystal code like a script without the build and run steps.
Useful for testing and executing non-performance related tasks which the code changes often.
#!/usr/bin/crystal run
puts ARGV

$ ./myapp.cr arg1 arg2 # or crystal run myapp.cr arg1 arg2
$ ["./myapp.cr", "arg1", "arg2"]

This feature can also be added to the crystal eval command:
$ crystal eval "puts ARGV" arg1 arg2
$ ["arg1", "arg2"]

The current behavior of crystal run it to take all non-option arguments as files, like crystal build does.
If this behavior for crystal run is really wanted to be kept, an option indicating that all following parameters will be passed as arguments, in addition to the files, can be created.

https://github.com/crystal-lang/crystal/issues/546

Thanks @asterite , this issue is thus a semi duplicate, my mistake. However I find a bit confusing to have crystal and  crystal run for build & run.
Also we can't use the flags that are in crystal run like --verbose or --debug, that can be useful.
IMO it will be clearer to merge this to crystal run, and eventually add an option like -f as used in awk.

But crystal is not a scripting language. I have a few programs written in crystal that I use in my machine. I compile them in release and copy them to /usr/local/bin. No need to recompile each time, and it's super fast.

Agree but when developing a CLI program, it's very handy. I still find having both crystal FILE and crystal run FILE confusing.
You said that Crystal is a compiled language - it feels weird that an argument right after crystal is taken by default as a file and interpret it.

It's just that by default the first argument is considered to be the filename if it's not one of the commands (and it's usually never the case because crystal filenames usually end with .cr). So it's just a nice convenient thing to do. And it's not that Crystal interprets your program, it compiles it and runs it.
And then, when you develop, you can do:
crystal file.cr -- arg1 arg2

you probably don't need to type that all the type, pressing up a few times in your shell will bring it up.
Once you are done with your program, you compile it in release mode and move it to /usr/local/bin
All I'm saying is that with the above workflow I don't see the need to treat crystal as an interpreted language. In fact, I wouldn't want to make any changes to the language to suggest that's the case. Putting a crystal file in /usr/local/bin and have it be compiled every time you want to execute it is a waste of energy.

An interesting solution to the problem of "don't compile every time" could be to have crystal run cache the compiled binary somewhere like ~/.cache/crystal/run/. I've written a rudimentary tool that accomplishes this, using a digest of the script's contents as a lookup for the cached binary. It still lacks some features that would be necessary if it was in the core Crystal command, but in practice it works well.

Fixed with https://github.com/crystal-lang/crystal/pull/9171


Run usb detached

Applies API changes in reaction to feedback from Windows users experiencing the following issues:
App disconnects from robot while it is moving
This PR adds the new feature to run the robot with USB detached. With a protocol calibrated and loaded, pressing the RUN JOB button in the UI will generate a .gcode file on the Smoothieboard and will then run with no USB connection required. If the user attempts to run detached with old firmware, user is prompted to update their robot's firmware.
Also, the driver.wait_for_arrival() method now swallows all exceptions, and will instead timeout after no activity for 1 second. This accounts for any garbage bytes that are generated through a noisy USB signal while the motors are moving.
App displays a blank white screen when opened
Still do not know what is causing this issue, so more logging has been added to the app-shell to help us detect what is happening.

Coverage decreased (-2.3%) to 91.37% when pulling 56a89425b1887407ca3df9b3195ab390a4fcb863 on run-usb-detached into df9051fe9c958105d4554593d0d8c6980dee1c7d on master.


Installation via conda package manager

It will be great to be able to install imgaug via conda package manager.
It is very popular now and has some advantages over pip.

I'm on it: https://github.com/conda-forge/staged-recipes/pull/8504

You can now install imgaug from conda-forge: https://github.com/conda-forge/imgaug-feedstock.
I think this issue can be closed now.

Before closing issue, please add exact installation command to the README.

Thanks for the help @mdraw !
I see in https://github.com/conda-forge/imgaug-feedstock/blob/master/recipe/meta.yaml that the recipe contains a list of the current dependencies. How to update these when they change? I guess it doesn't happen automatically.

@aleju Indeed, the conda feedstock maintainers (currently only me, but I can add you if you want) have to keep dependencies up to date manually.
When you upload a new version to PyPI, a PR to update the conda package will be automatically made by a bot, but it has to be reviewed and merged by a human. Dependency changes can be made by maintainers inside these PRs.
To be on the safe side, it's also possible to add the automated tests from imgaug/test/ to the test section of the meta.yaml, but that would require the xdoctests package, which is not yet available on conda-forge.

@mdraw Would be great if you could add me as a maintainer. Not very likely that there will be dependency changes in the near future, but that is always hard to predict.
And the tests could probably be run without xdoctests for conda.

Install commands for conda are now in the readme.

I 'm installing a fresh new desktop pc with Ubuntu 19.04 and after installing imaug with conda the import (in python) gives me an error
~/anaconda3/envs/tfgpu/lib/python3.6/site-packages/scipy/sparse/linalg/interface.py in
48
49 from scipy.sparse import isspmatrix
---> 50 from scipy.sparse.sputils import isshape, isintlike, asmatrix
51
52 all = ['LinearOperator', 'aslinearoperator']
ImportError: cannot import name 'asmatrix'


Notification retry not working

System Health details
System Information

version
core-2024.8.0

installation_type
Home Assistant Container

dev
false

hassio
false

docker
true

user
root

virtualenv
false

python_version
3.12.4

os_name
Linux

Checklist

[X] I have enabled debug logging for my installation.
[X] I have filled out the issue template to the best of my ability.
[X] This issue only contains 1 issue (if you have multiple issues, open one issue for each issue).
[X] This issue is not a duplicate issue of any previous issues..

Describe the issue
My idea was to use the retry service for phone notifications. So for example is my phone is not connected to the internet for some reason, the notification doesn't get lost. I would just receive it a little after my phone connects to the internet again. But this is not working. I get a Task exception was never retrieved when trying to run a notification service within the retry service. Is my idea possible with this retry service?
Reproduction steps

I created a script with a field called message, which is used in my automations that send messages
For the message sending part, this is the YAML:

metadata: {}
data:
  retries: 999
  backoff: 60
  service: notify.mobile_app_2109119dg
  message: "{{message}}"
  data:
    message: "{{message}}"
action: retry.action

It works if the phone is connected
Debug logs
Logger: homeassistant
Source: components/mobile_app/notify.py:151
First occurred: 10:31:02 AM (8 occurrences)
Last logged: 11:24:58 AM
Error doing job: Task exception was never retrieved (None)

Traceback (most recent call last):
  File "/usr/src/homeassistant/homeassistant/components/mobile_app/push_notification.py", line 56, in handle_push_failed
    await fallback_send(data)
  File "/usr/src/homeassistant/homeassistant/components/mobile_app/notify.py", line 151, in _async_send_remote_message_target
    push_token = app_data[ATTR_PUSH_TOKEN]
                 ~~~~~~~~^^^^^^^^^^^^^^^^^
KeyError: 'push_token'

Diagnostics dump
No response

According to the error, there is a missing ATTR_PUSH_TOKEN. This is notification specific issue, and is unrelated to retry.
My suggestion is to use the developer tools and send a regular notification (without retry). Once it's working, you can copy over the relevant parameters.

But the script works if the phone is connected to the internet (meaning it works on the first try). It just issues this error if on the first try it doesn't succeed.

One thing that doesn't seem right is backoff: 60. It should be backoff: "60" - the field is string and not integer. You can also try and remove it entirely, just for making sure it's not the root cause of the issue here.
The other thing that is suspicious is:
Error doing job: Task exception was never retrieved (None)
This means that an exception is not getting properly propagated to the retry integration, which can also explain why there is no additional attempt. I've encountered action (aka service call) which are not propagating exceptions. For example: https://github.com/amitfin/retry/issues/24#issuecomment-1706536433 .
If you share the log file we might be able to understand it better.


EC3-widget-react

pull request to store EC3 widget on iTwin repository instead of private fork.

How were you able to merge this in (a new pkgs) w/o review from the VCR admins?

@aruniverse  This PR was made just to have the EC3 widget under iTwin org, not under a private github account. This was merged into branch ec3, not master. Merging into non-master branch does not require a review from VCR admins.


Module breaks when targetting small tokens.

Test case, target a token with a scale of 0,5 , the program screen will pseudo freeze while the UI components are still reachable, have to change scenes to reset or re focus the camera to solve the problem, small tokens are untargetable with the plugin enabled (or they are, but I dont get any visual feedback so I cant confirm)

I cannot reproduce, do you have other modules installed, or alternative reproduction steps?

Okay, I did some further testing as I tried to generate another situation to test this,

This is the condition that is required on the token, or atleast the one that broke the program, now, as I targetted the token it functioned properly, so I went back to the original map to see if maybe an updated changed something but no, the bug remains there
After testing a few settings, I noticed the fault here is the grid size, a grid size of 64 (the original value) will not break the module but more difficult number like 72 will.
Setting the grid size to 72 and targetting the token will generate the bug, and its the same bug that i described on the earlier post

The scene i tested with had originally a grid size of 64, so I can suspect is about perfect roots, but otherwise my knowledge is limited.

Hrm, weird, it's triggering a bug in the PIXI/earcut library when punching the hole in the center of the target. Really strange, will take some effort to work out what exactly is causing it, and/or report upstream.

Should be fixed in v0.1.17, please let me know of any issues.


fix: No rule to make target 'nokogiri.so' on android

What problem is this PR intended to solve?
On android builds of ruby, DLLIB does not direct to a valid nokogiri.so path but TARGET_SO does. This PR fixes it for the clean-ports step.
Reference #3244

Have you included adequate test coverage?

Not sure what kind of tests should be added. I have tested this on my build system and it passes.
Does this change affect the behavior of either the C or the Java implementations?

Does not change the behaviour, but allows the compilation.

I've created https://github.com/sparklemotion/nokogiri/pull/3250 which is a simpler proposed solution.


Success/Error Messages clear

#301
There's some instances where the error or success message don't go away. Such as after processing the approved transfers. Another would be if you get a validation error message in the propose trade screen.
Changelog:

Refactored on where the Action Types constants are stored.
Success Message from Historical Data Entry should clear properly
Error Message in Propose trade should clear properly
Fixed an issue where View Credit Transfer would not load if an Error message occurred in Add/Edit Credit Transfer

 Confirmation Alerts | Success Message doesn't disappear |1| [v0.3.0]


Committing More Files Causes Authentication Error, Unable To Preview HTML Or Compile Java Files on GitHub Remote Workspace

I don't know if it's the fact that i've committed too many files at once but whenever I do, it popups an error saying that my authentication failed and that there's a button that says re-authenticate. However, the button doesn't do anything.
Also, I've realized that whenever I put my file into the GitHub remote workspace, I am not allowed to compile or preview my html files using a VSCode extension. I've even made it a trusted workspace. What seems to be the problem?

authentication failed and that there's a button that says re-authenticate

Are you looking at a repository in an organization that enforces SAML for authentication?

I am not allowed to compile or preview my html files

GitHub Repositories workspaces are virtual workspaces. To compile and run files you will need to clone the repository locally or open it in a GitHub Codespace.

Are you looking at a repository in an organization that enforces SAML for authentication?
Umm no because I'm using a GitHub Repository workspace.

GitHub Repositories workspaces are virtual workspaces. To compile and run files you will need to clone the repository locally or open it in a GitHub Codespace.

Right but I guess having this extension to making the repository workspace into a temporary local workspace doesn't work then.

Are you looking at a private repository or a publicly accessible one? Do you only have trouble committing changes, i.e. you can browse the repository contents without issues?
Could you enable debug logging in your settings, reload, then provide the contents of the GitHub Repositories output channel when you see the error message about committing?

 Please reopen if you have additional information to share on this issue.


Fix eac runtime controller rbac & fix eac.runtime getWorkerPod logic

Ⅰ. Describe what this PR does
Fix eac runtime controller rbac & fix eac.runtime getWorkerPod logic
Ⅱ. Does this pull request fix one issue?

NONE
Ⅲ. List the added test cases (unit test/integration test) if any, please explain if no tests are needed.
Ⅳ. Describe how to verify it
Ⅴ. Special notes for reviews

/lgtm
/approve


Add users.identity method

See https://api.slack.com/methods/users.identity

@Ustice do you need a test or a documentation change as well or is this change sufficient?

There are a number of errors that are missing. Would you mind adding those in too?

I thought those were omitted on purpose, as they are on all (most?) other methods as well.

Never mind, you are right. If I remember right, I have a special catch for those.

@Ustice thanks! Do you publish a new release on npm?


Ambiguous ids on join

First of all: Very nice lib! I like it so far 👍
Here is my issue... with:
sFromSql : 'mitarbeiter LEFT JOIN personen ON personen.personId = mitarbeiter.personId'
You will face an error if you want to render "personId" on the Datatable: (Column 'personId' in order clause is ambiguous)
This is true because the generated query looks like this:
'SELECT * FROM mitarbeiter LEFT JOIN personen ON personen.personId = mitarbeiter.personId ORDER BY personId asc LIMIT 0, 10'
And personId is in both tables
How can I go around this/fix it?

I haven't worked on SQL in a couple of years, so I'm too rusty to give a good answer. Sorry.

thats very sad. In my opinion, you should start working on SQL again :D
I solved this for the moment by not rendering the ID. If I need this to work at some point I will dig deeper or one day an other user steps by and solve this. Thanks again :)

Mongodb these days :-)

this is not a lib problem. More sql. You can just define the columns instead of the star * and use SELECT personen.personenId AS ...


Improve multibyte character handling in branch ext

This fixes a bug that causes a mangled statusline. The bug occurs, when
the displayed_head_limit variable is set and causes the substring
expression to take a substring, which ends in the middle of a multi-byte
character.
This patch replaces the byte-based methods for measuring the
length of the branch name and creating a substring with methods that are
character-based and multi-byte aware.
It also has the nice side effect of making the length measuring more
accurate, by taking the actual display width of multi-byte characters
and the ambiwidth setting into account.

Was literally just seeing this bug! 👍

Hm, I believe strcharpart is not available with Vim 7.4 and older, which is what airline still supports. I'll have a closer look soon and will merge the use of  strcharpart() with the repsecting testing flags to make sure, older Vims won't complain.


error while running yarn commands

Describe the bug
which template:

[ ] MaterialDesignFrameworkModule — Material Design
[ ] Bootstrap3FrameworkModule — Bootstrap 3
[ ] Bootstrap4FrameworkModule — Bootstrap 4
[ ] NoFrameworkModule — plain HTML
[x] Other (please specify below)

A clear and concise description of what the bug is.
To Reproduce
Steps to reproduce the behavior:

...

Expected behavior
A clear and concise description of what you expected to happen.
Screenshots
If applicable, add screenshots to help explain your problem.
Desktop (please complete the following information):

OS: [e.g. iOS]
Browser [e.g. chrome, safari]
Version [e.g. 22]

Log output covering before error and any error statements
Insert log hereCopy

Additional context
Add any other context about the problem here.

Detailed Description

Context

Possible Implementation

ERROR in ./src/app/demo.module.ts
Module not found: Error: Can't resolve '/Users/store/Downloads/angular-schema-form/angular6-json-schema-form/dist/angular6-json-schema-form' in '/Users/store/Downloads/angular-schema-form/angular6-json-schema-form/src/app'
ERROR in ./src/app/demo.component.ts
Module not found: Error: Can't resolve '/Users/store/Downloads/angular-schema-form/angular6-json-schema-form/dist/angular6-json-schema-form' in '/Users/store/Downloads/angular-schema-form/angular6-json-schema-form/src/app'
ℹ ｢wdm｣: Failed to compile.

this is after running the yarn commands as mentioned here:
https://www.npmjs.com/package/angular6-json-schema-form

You need to run the following commands:

git clone https://github.com/hamzahamidi/angular6-json-schema-form.git angular6-json-schema-form
cd angular6-json-schema-form
yarn install
yarn buildlib
yarn start

Thanks @hamzahamidi it works now


[WIP] Add apple sign in to sample code

Resubmit https://github.com/firebase/firebase-ios-sdk/pull/4412 There is weird build issue. I doubt it's because of the category name of "+Apple"


[Feature Request]:  solution for leetcode 908

Is there an existing issue for this?

[X] I have searched the existing issues

Feature Description
I would like to add solution in c++,java,python, javascript for leetcode problem 908. Smallest Range I
Use Case
solution for the leet code problem 908
Benefits
No response
Add ScreenShots
No response
Priority
High
Record

[X] I have read the Contributing Guidelines
[X] I'm a GSSOC'24 contributor
[X] I have starred the repository

@Ajay-Dhangar  can you please assign me.


TypeScript misses document symbols

open https://github.com/Microsoft/vscode/blob/master/src/vs/code/electron-main/windows.ts
trigger outline
search for ready
🐛 you get only one result, but there is IWindowsMainService#ready and WindowsManager#ready

I believe this has been fixed by TS. We still point to TS 2.0.x for vscode itself using "typescript.tsdk". After removing this setting so that we use TS 2.1.4 for analysis, I now see both symbols listed.


Update PyDNG to take in a json camera profile converted from a DCP file

What does this PR do?
Based on the info from https://www.raspberrypi.org/blog/processing-raw-image-files-from-a-raspberry-pi-high-quality-camera/ I have added the ability to specify custom (JSON) versions of DCP (camera profiles) as it wasn't obvious how to do this in code.
Let me know if there are any changes needed or things I need to change. I had to do a bunch of data shape changes and Im not 100% sure I got everything correct. I have tested with the RPi HQ camera and the optional parameter and its working.
This is for when you dont have direct access to the Tags to set your own colour profiles.

🤷🏻♂

🤷🏻♂

There were some major changes to the api of this package; I do not have the time currently to see the transition of this code. Upon further request I can re-open this and consider merging.


fix(html): empty script

Description
fix: #6008
Additional context

What is the purpose of this pull request?

[x] Bug fix
[ ] New Feature
[ ] Documentation update
[ ] Other

Before submitting the PR, please make sure you do the following

[x] Read the Contributing Guidelines.
[x] Read the Pull Request Guidelines and follow the Commit Convention.
[x] Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
[x] Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).
[x] Ideally, include relevant tests that fail without this PR but pass with it.

I don't know if this is the right fix, we should check why there isn't a string for that cached proxy. If an empty string is inserted in the cache (instead of undefined as I assume it is now), then we don't need to throw an error

I don't know if this is the right fix, we should check why there isn't a string for that cached proxy. If an empty string is inserted in the cache (instead of undefined as I assume it is now), then we don't need to throw an error

@patak-dev thanks comment.

why there isn't a string for that cached proxy

so we need to find why isn't a string for that cached proxy case to fix? avoid using if to catch edge case.
I guess import "index.html?html-proxy&index=1.js" is used manually 😀.

I think the problem needs to be here https://github.com/vitejs/vite/blob/d4c5cff551ad9fb721243f8abdbf0c78f5b5a7ec/packages/vite/src/node/plugins/html.ts#L231

I think script children must be a TextNode, so the cache must be string.

You are right, the initial implementation was fine. Sorry for the noise, reverted it for you. Let's merge 👍🏼


Correct expires_on values of tokens from AzureCliCredential

The Azure CLI get-access-token command gives the token's expiry time in local time as produced by datetime.fromtimestamp (here), with no timezone information. Because AzureCliCredential uses a naive datetime to convert this string to epoch seconds, it can provide a token with an incorrect expires_on value, causing a client to send an expired access token.
This PR fixes the test which should have detected this, and has the credential parse the CLI's output with the datetime.timestamp() method when available (it was added in Python 3.3). When datetime.timestamp() is unavailable, e.g. on Python 2.7, the credential falls back to its implementation in 3.5 (here). I chose 3.5's implementation despite 3.6's improvements around clock shifts (e.g. daylight saving time) because those improvements require the fold attribute described in PEP 495.
Closes #14345

There is still one problem with this implementation - the local datetime string is not able to represent "fold" and Azure Identity won't be able to get the correct POSIX timestamp during the second 01:00 ~ 02:00 when Daylight Saving Time ends each year. More details: https://github.com/Azure/azure-cli/issues/19700#issuecomment-1727797158.


Compability with SAML using AzureAD as IDP

Currently, Grist cannot be used with AzureAD.
The error one gets with GRIST_SAML_SP_HOST  = https://grist.mydomain is:
Sorry, but we’re having trouble signing you in.
AADSTS700016: Application with identifier 'https://grist.mydomain/saml/metadata.xml' was not found in the directory 'My Directory'. This can happen if the application has not been installed by the administrator of the tenant or consented to by any user in the tenant. You may have sent your authentication request to the wrong tenant.

The issue probably originates from this line: https://github.com/gristlabs/grist-core/blob/main/app/server/lib/SamlConfig.ts#L85
The GRIST_SAML_SP_HOST is used as part of the entity_id. This should be a separate variable so one can set it to the actual client id.

Hi @lohrm-stabl, that makes sense. There may be a workaround here https://community.getgrist.com/t/azure-ad-saml-sso-and-grist/1269/3
A pull request to allow the entity_id to be overridden would be very welcome :pray:

Hi @lohrm-stabl, that makes sense. There may be a workaround here community.getgrist.com/t/azure-ad-saml-sso-and-grist/1269/3

I have found this as well. At first, I didn't get it working because I Azure AD wouldn't let me customize the entity_id. But by recreating the application, I got it working.
Step-by-step guide:

Create a new enterprise application
Go to the "Single Sign-on" tab and select "SAML"

Edit the "Basic SAML Configuration", set the values to: (assuming your Grist instance is hosted on grist.test.xyz)

Identifier: https://grist.test.xyz/saml/metadata.xml
Reply URL: https://grist.test.xyz/saml/assert
Sign on URL: https://grist.test.xyz/saml/login

Edit claims, add the following claims (not entirely sure if necessary):

Name: FirstName, Source attribute: user.givenname
Name: LastName, Source: user.surname
Name: name_id, Source: user.userprincipalname

Set the following environment variables to for your grist instance to values found on the Single Sign-On tab:

GRIST_SAML_IDP_LOGIN: set to the Login URL provided by Azure
GRIST_SAML_IDP_LOGOUT: set to the Logout URL provided by Azure
GRIST_SAML_SP_HOST: https://grist.test.xyz
GRIST_SAML_IDP_CERTS: download from SAML Certificates > Certificate (Base64), upload to your server and put file path here
GRIST_SAML_SP_CERT: will be set later
GRIST_SAML_SP_KEY: will be set later
GRIST_SAML_IDP_UNENCRYPTED: set to 1

Setup client secret

Go to App registrations in your Azure AD, search for your application and go to "Certificates & secrets"
Generate a new certificate

openssl req -x509 -newkey rsa:4096 -keyout key.pem -out cert.pem -days 365 (adjust days as needed)
openssl pkcs12 -export -out certificate.pfx -inkey key.pem -in cert.pem

Upload the certificate (to Azure AD)

Also upload the private and public part to your server
Set GRIST_SAML_SP_CERT and GRIST_SAML_SP_KEY to the public and private certificate key files you just generated


[Embeddingapi] Modify testcase name to avoid effect

-Modify testcase name to avoid effect
-Cover the XWalkActivity and XWalkInitializer two ways
Impacted tests(approved): new 2, update 0, delete 0
Unit test platform: [Android]
Unit test result summary: pass 2, fail 0, block 0
BUG=https://crosswalk-project.org/jira/browse/XWALK-4758

@jennycao please help to review it.

About this pr, I just adjust the case testOnDocumentLoadedInFrame running order, and put it on the first position by change its name.


DEBUG_UART=1 printf no data?

I am not getting any data off the tx and rx header pins. I feel like I'm missing something absolutely simple.
I've tried the prebuilt binary, also building it with make DEBUG_UART=1 parameter under eclipse. Enabling THERMAL_DATA_UART spits out some random info. I've tried different baud rates. I've also confirmed the baud with an oscilloscope.
HAL_UART_MspInit has GPIO_InitStruct.Pin = GPIO_PIN_2|GPIO_PIN_3; which according to the datasheet is definitely the uart2 pins labeled as tx and rx on the purethermal 2 board.
Is printf (debug_printf) not retargetted to uart? Any help would be greatly appreciated. Thanks.

Please close this. I solved this issue the best way I could. Its in my fork. I hope this helps others who have been trying to figure this one out.


App icon on Old Expensify don't support dark mode

If you haven’t already, check out our contributing guidelines for onboarding and email<EMAIL_ADDRESS>to request to join our Slack channel!

Version Number: <IP_ADDRESS>
Reproducible in staging?: Yes
Reproducible in production?:
If this was caught on HybridApp, is this reproducible on New Expensify Standalone?:
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: @dubielzyk-expensify
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1729202799742179
Action Performed:

Find Old Expensify on your homescreen
Change to dark mode

Expected Result:
See the Old Expensify icon change to be dark mode compliant
Actual Result:
Icon still has white background color
Workaround:
Can the user still use Expensify without this being fixed? Have you informed them of the workaround?
Platforms:

Which of our officially supported platforms is this issue occurring on?

[ ] Android: Standalone
[ ] Android: HybridApp
[ ] Android: mWeb Chrome
[ ] iOS: Standalone
[x] iOS: HybridApp
[ ] iOS: mWeb Safari
[ ] MacOS: Chrome / Safari
[ ] MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

https://github.com/user-attachments/assets/0dd7d5c8-dae4-499f-b1c2-a2095ec97e3c

View all open jobs on GitHub

Hey @dubielzyk-expensify can you remind me what we need to do here? The linked thread doesn't contain your solution. Which I think is to provide a dark mode icon for OldDot?

According to their documentation we need to provide a dark mode asset. Light mode and tinted mode is working well already so here's the dark mode variations:
app_icons_dark.zip
That should give us this look on mobile:

cc @Expensify/design

Looks good to me 👍

Rounded edges would be expected.

Ahh, I just used a Figma file I found. My bad! I'll fix

Here's another go :D
app-icons.zip

@dubielzyk-expensify can I get Dark - App Store.png at 1024x1024 please?

Yes sir 🫡
Dark - App Store.png.zip

Reopening as this wasn't fully implemented. I created a new PR that supports light, dark, and tinted icons here.

Should we use the same single shade for themed icons? (to match the NewDot logo)

My 2 cents is a big yes to this. I think the ND one looks way better IMO.

Agree with big yes. Now there'll be no way to differentiate them though. I've made a white version which means the tint will apply fully. We could do a gradient or something else here or even have the outer rings be a bit more faded. Here's a few variations.

If we just want white, then use these:
tinted-icon.zip

My vote would be to go flat, since we don't use gradients really anywhere in our brand system.

Agree with flat! I actually also really like the faded outer ring version, but since we're going to be delisting "New Expensify" soon I think it makes sense to just go flat as that most closely represents the latest and greatest iteration of our iconmark. (Jon also knew Shawn and I were going to say flat which is why he went ahead and included the files for that one 🤣)

(Jon also knew Shawn and I were going to say flat which is why he went ahead and included the files for that one 🤣)

😂 ❤

but could you please share a 1024x1024 asset? I could only see up to 512x512. FYI, as of iOS 18, we now only need to provide a single asset, which is automatically resized.
Here you go:
Tinted - App Store.png.zip

Thanks all

Awesome work Jules!


[SPARK-46177][PYTHON][CONNECT][ML][TESTS] Skip 'CrossValidatorTests.test_crossvalidator_with_fold_col' with Python 3.12

What changes were proposed in this pull request?
This PR proposes to skip doctest CrossValidatorTests.test_crossvalidator_with_fold_col with Python 3.12.
Why are the changes needed?

For the proper test for Python 3.12. It is failing, see SPARK-46177 and https://github.com/apache/spark/actions/runs/7034467411/job/19154766502

Current dev torch version does not work very well with Python 3.12. It should be enabled together with SPARK-46078.

The build with Python 3.12 halts so can't see if other tests pass fine.

Does this PR introduce any user-facing change?
No, dev-only.
How was this patch tested?
Manually tested.
Was this patch authored or co-authored using generative AI tooling?
No.

Build: https://github.com/HyukjinKwon/spark/actions/runs/7040333718

Merged to master.


Create a new feature to delete all URLs for the current user

Implement delete all shortened URLs page.


How to make triangles to have a different form shape

Hello, Im discovering your work and I'm trying to figure out how to make randomize shapes like the demo site. Right now I only get squared shapes with static triangles. Could you explain a bit more please ? And thanks agin for this work !

Look into the examples folder, you will see the code that display squared shapes with static triangles.
Notice this:
var geometry = new FSS.Plane(600, 400, 6, 4);
Then, use console.log(geometry) to see what is inside it.
After that, you will find out "triangles" is inside it.
Continue...
At last you will get:
geometry > triangles > a or b or c > Vertex
So,you can use
geometry.triangles[0].a = new FSS.Vertex(Somenumber,Somenumber,Somenumber);
geometry.triangles[0].b = new FSS.Vertex(Somenumber,Somenumber,Somenumber);
geometry.triangles[0].c = new FSS.Vertex(Somenumber,Somenumber,Somenumber);
to change the position of a point.
I'm not very skilled of this, I was found out that just now. And my English is not good, hope you can get what I mean.


Random story books write Nar'Sie as narsie, IE the ACTUAL on god most unimportant bug ever

Description
Title, the "narsie cultist" random character is spelled as "narsie" as opposed to Nar'Sie, the (i think) correct spelling.
Reproduction
Step 1. Open random storybooks until you get one mentioning a "narsie" cultist.
Screenshots

Additional context
i cant believe this, my immersion

The localization string for this is found in story-generation.ftl
Good first PR material, if someone wants to fix it

while we're at it we might as well also capitalise ratvar to Ratvar

Hello space-station-14, I'm a newb and I think I can handle this issue if possible.  I should be able to handle both the Nar'Sie and Ratvar fixes if I get the ok.

Hello space-station-14, I'm a newb and I think I can handle this issue if possible. I should be able to handle both the Nar'Sie and Ratvar fixes if I get the ok.

You don't need the ok, just learn how to PR and do that. This issue is the "ok" you seek.

Understood.  Appreciate your patience.  I'll go read your documentation again and submit a PR with a proposed fix, thank you.

Is there any preference as to how it should look?  I saw some SS13 documentation that spells 'narsie' as 'Nar'Sie'.  At least one page in the SS14 wiki spells it as 'Nar'sie'.  There could be some intentional convention that I have yet to discover in the docs so far.
Also, I'm loving this game.  New to it, but this is completely awesome.  I didn't even know about SS13.  The documentation here is so thorough it could train people literally in almost the complete software development cycle, if not 100%.  The odd passages with the strikethroughs are a bit intriguing, but otherwise spotless.  I have been really curious how I was going to go from having a little code knowledge to deep in some real game development, and this looks like the perfect way.
I'm still fumbling around learning the game while reading the dev docs as well.  Everything build and ran as promised.  What's the quickest way to invoke the storybooks?  Do I need a particular space station or character?  This bug is a home run, not many bugs have the lines that require edited right in the bug.  Clearly, I'd like to be able to verify whatever change is decided per the input requested above.  Also, is it such that verifying the fix in one storybook should reasonably verify the change took throughout the game, or should I canvas the different space station types for the storybooks to check?
Thanks again for your help, awesome game!

I just had a look and every occurence I found in the code was Nar'Sie and I would suggest using that.
We don't really have official lore, so someone on the wiki might have used it differently.
The best way to test it would be to use the F5 spawn menu to spawn a lot of randomized books until you get one containing it I suppose.
If you need any help with the dev environment, feel free to ask us on our Discord channel, lot's of helpful people around there. Thats how I quickly learned coding for the game :)

@slarticodefast,
Super thanks for such a speedy response.  Hope to get this in asap.  I'm on the discord site now, thanks.  The docs really helped me set up the dev environment and I think I'm good so far, but I'll definitely reach out if I run into issues.  Great support.


watch-bluekit only looks for .js files, not .jsx

At src/createBlueKit.js#L115
Whereas the build-bluekit task uses getAllFilesInDir which matches on /\.(js|jsx)$/ (src/createBlueKit.js#L26).

Thanks.


Bump dcos-test-utils

High-level description

CLI binary is now configurable
users must opt-in to having the test fixture assume the cluster composition

Corresponding DC/OS tickets (obligatory)
https://jira.mesosphere.com/browse/DCOS-17702
Checklist for all PRs

[x] Included a test which will fail if code is reverted but test is not. If there is no test please explain here:
[x] Read the DC/OS contributing guidelines
[x] Followed relevant code rules Rules for Packages and Systemd

Checklist for component/package updates:
If you are changing components or packages in DC/OS (e.g. you are bumping the sha or ref of anything underneath packages), then in addition to the above please also include:

[x] Change log from the last version integrated (this should be a link to commits for easy verification and review): https://github.com/dcos/dcos-test-utils/compare/aa22cf1e6ffcf0a375e7e424a02669f51b0adbee...master
[x] Test Results: https://teamcity.mesosphere.io/viewLog.html?buildId=905247&tab=buildResultsDiv&buildTypeId=DcosIo_DcosTestUtils_ToxDcosTestUtils

PLEASE FILL IN THE TEMPLATE ABOVE / DO NOT REMOVE ANY SECTIONS ABOVE THIS LINE
Instructions and review process
What is the review process and when will my changes land?
All PRs require 2 approvals using GitHub's pull request reviews.
Reviewers should be:

Developers who understand the code being modified.
Developers responsible for code that interacts with or depends on the code being modified.

It is best to proactively ask for 2 reviews by @mentioning the candidate reviewers in the PR comments area. The responsibility is on the developer submitting the PR to follow-up with reviewers and make sure a PR is reviewed in a timely manner. Once a PR has 2 ship-it's, no red reviews, and all tests are green it will be included in the next train.

@mesosphere-mergebot bump-ee

VIP test failure in  teamcity/dcos/test/aws/onprem/static should be overridden

@mesosphere-mergebot override-status @mesosphere-teamcity
teamcity/dcos/test/aws/onprem/static https://jira.mesosphere.com/browse/DCOS-19542

@mesosphere-mergebot override-status teamcity/dcos/test/aws/onprem/static https://jira.mesosphere.com/browse/DCOS-19542

@mesosphere-mergebot ship_it_label_status_check


clarifying flow for main dropdown menu #17

I wanted to solve #17 using the current conventions and adding a little bit of model logic.

Hi, thank you for this contribution, unfortunately, we are moving towards a simpler design, which will not even have this menu. We are in the process of updating this github to reflect the new plan.


Design pymovements logo

Description of the problem
Based on the example text stub from the template:
I'm always frustrated when I look at the pymovements github page and don't see a fancy logo
Description of a solution

[ ] create first draft of logo (svg)
[ ] incorporate suggestions from feedback round
[ ] put logo on repo README.md page

Minimum acceptance criteria

[ ] a svg logo that passes majority group vote

I think we can move this back depending on @jakobchwastek


Rolling upgrades

https://botbot.me/freenode/weavenetwork/2015-02-18/?msg=32237468&page=1

Any thoughts on how I may perform a rolling update of weave without taking the whole cluster down?

Bounce each node in turn. The new nodes won't be able to talk to the old ones IF the protocol revision has changed, so you end up with a sort of rolling partition which eventually disappears. We could do better, but not easily, so we'd need some evidence that what we have isn't enough.

A few things we could do to improve the situation...

Maintain release branches and ship non-protocol-changing bug fix updates on them.
Switch to a major/minor scheme for the protocol version, with minor version changes being considered compatible.
Make the protocol resilient to "extra stuff", so that we can introduce some additions w/o bumping the major version.

However, some bug fixes / changes are simply too intrusive to maintain compatibility.

We did (1) for the first time with the 0.11.1 release. We create release branches "just in time", i.e. when we need them, rather than at the time of the release.


Multiple column header comment and sheet name improvements to address user confusion and consistency

Summary Change Description
I took a few issues at once here that all had to do with sheet names, headers, and header comments.  Note that header comments are automatically generated based on a number of inputs and column configuration items.  There is custom content, but each item is a component that is collated together from a group of components.  For example, there is an automatically generated sentence that describes drop-downs (if any) that are used in the column.
Thus, please be aware that composition structure of header comments in review issues, will apply to multiple columns/sheets.
I say this because, given the number of files this PR touches, I suggest (instead of reviewing the code) you review this sample template, keeping in mind these specific changes (mostly related to the resolved issues):

Renamed the Sequences sheet to "MS Runs".
Renamed any column referencing "Sequence Name" to just "MS Run".
Made every header comment describing how it is referenced by columns in other sheets to use a ColumnReference instance that auto-populates a section of the header comment to that effect.
Changed the Tracers sheet's "Compound Name" column header to just "Compound".
Referenced the source column in every column populated by dropdowns for the column format.
Renamed "Tracer Name" to "Tracer" in the Infusates sheet.
Included the list of static choices for all fields with a tuple of possible values defined in the models.

Affected Issues/Pull Requests

Resolves #1088
Resolves #1089
Resolves #1091
Resolves #1100
Merges into main

Review Notes

See comments in-line.
Checklist

This pull request will be merged once the following requirements are met.  The
author and/or reviewers should uncheck any unmet requirements:

Review requirements

Minimum approvals: 1
No changes requested
All blocking issues resolved by reviewers
Specific reviewers: @add_username_here

Review period: 2 days

Associated issue/pull request requirements:

[x] All requirements in affected issues marked "resolved" are satisfied
[x] All required pull requests are merged (or none)

Basic requirements

[x] All linters pass
[x] All tests pass
[x] All conflicts resolved

Overhead requirements

[x] New/changed method tests implemented/updated (or no change)
[ ] Updated Unreleased section of changelog.md (or no change)
[x] Migrations created & committed (or no change)

@mneinast - Could you take a look at the changes I made to the downloaded template to review the changed header names, tab names, and header comments to see if they are more intuitive?  These are the specific changes to look for:

Renamed the "Sequences" sheet to "MS Runs".
Renamed any column referencing "Sequence Name" to just "MS Run".
Changed every header comment for columns with dropdowns.
Renamed the Tracers sheet's "Compound Name" column header to just "Compound".
Renamed "Tracer Name" to "Tracer" in the Infusates sheet.
Minor improvements to various header comments.

Looks good!  The main thing to consider is how we use "Sequences" and "MS Runs".
In the "Xcalibur" software (which researchers use to operate the LCMS instrument), a Sequence is a single collection of injections defined by a "Sequence" file which the users create.  They have flexibility in how they organize this.  For example, they can use multiple LC protocols within a single Xcalibur Sequence.
The purpose of "Sequence/MS Run" in tracebase is to delineate a set of comparable samples (defined as a set of samples run on a single instrument with the same LC protocol on a specific day).  Since this is different than the Xcalibur definition for "sequence", then I agree we should find a different name.
"MS Run" could be interpreted as a single sample running on the instrument.  I think this is how we defined it a long time ago?  Here are some more ideas:

"Sample Batch"
"Sample Group"
"Sample Set"

of these, I like "Sample Batch" best.  But what do you think?

Looks good! The main thing to consider is how we use "Sequences" and "MS Runs".
In the "Xcalibur" software (which researchers use to operate the LCMS instrument), a Sequence is a single collection of injections defined by a "Sequence" file which the users create. They have flexibility in how they organize this. For example, they can use multiple LC protocols within a single Xcalibur Sequence.
The purpose of "Sequence/MS Run" in tracebase is to delineate a set of comparable samples (defined as a set of samples run on a single instrument with the same LC protocol on a specific day). Since this is different than the Xcalibur definition for "sequence", then I agree we should find a different name.
"MS Run" could be interpreted as a single sample running on the instrument. I think this is how we defined it a long time ago? Here are some more ideas:

"Sample Batch"
"Sample Group"
"Sample Set"

of these, I like "Sample Batch" best. But what do you think?

Thanks for adding this valuable context, though in my mind, it seems to make the ambiguity/difficulty of this problem worse.  I see what you mean about "MS Run".  I must have misinterpreted early feedback on the new study doc format.  What I was trying to solve was the incorrect understandings of the "Sequence Name" columns and sheet when you guys tried it out the first time.  For example, Lance and John left the sequence name columns and the Sequences sheet empty because they didn't know what they were for.  And before there were drop-downs, you understandably "made up names" for those columns/rows.
We have struggled with the terminology for both the model and field names for the MS Run-related data.  We all suggested different things at different points.
I'm a little concerned about conflating sample records with MS Run type records.  So let me speak off the cuff here and see what you think...
All we want is for users to know how to fill in the sheets, and perhaps John's and Lance's confusion over the Sequences sheet and the columns (i.e. not filling them out at all) is not the best evidence of the precise problem.  Perhaps the lab people will understand the "sequence" terms and it was just the "name" component of the header that lead you to make something up there.  And perhaps now with the drop-downs, it might be enough to rename things like this:

Sequences sheet (maybe rename as "MS Run Sequences"? or leave as "Sequences"?)

Maybe rename the read-only "Sequence Name" column as "Sequence ID" (but given the column is controlled by formula, a rename isn't even necessary)

Peak Annotation Files sheet

Rename the "Default Sequence Name" column as "Default Sequence" (and depend on the fact that there exist dropdowns to infer they shouldn't enter a custom name)

Peak Annotation Details sheet

Rename the "Sequence Name" column as just "Sequence" (and depend on the fact that there exist dropdowns to infer they shouldn't enter a custom name)

Thanks I see what the main issue is now.
To me, a lot of this confusion will be minimized once the new submission system is in place (which essentially prefills sequence information before providing the study doc to the researcher).

Sequences sheet (maybe rename as "MS Run Sequences"? or leave as "Sequences"?)

Maybe rename the read-only "Sequence Name" column as "Sequence ID" (but given the column is controlled by formula, maybe a rename isn't even necessary)

I think we leave as "Sequences", but I like renaming the "Sequence Name" column to "Sequence ID".

Peak Annotation Files sheet

Rename the "Default Sequence Name" column as "Default Sequence" (and depend on the fact that there exist dropdowns to infer they shouldn't enter a custom name)

Peak Annotation Details sheet

Rename the "Sequence Name" column as just "Sequence" (and depend on the fact that there exist dropdowns to infer they shouldn't enter a custom name)

i like this approach in both cases.

Going into draft to make changes. Please hold off on reviewing until it is again "ready for review".

[x] TODO: Rename "MS Runs" sheet back to "Sequences"
[ ] TODO: Rename "MS Run Name" to "Sequence Name" (not "Sequence ID" for consistency with columns in other sheets)
[ ] TODO: Rename "Default MS Run" to "Default Sequence"
[ ] TODO: Rename "MS Run" to "Sequence"


how to change the train code

Hi all,
given the flexible code (in tensor2tensor) that allows to easily register new problems / hparams / models, I was wondering if there had been any discussion to allow more flexibility with the training process.
E.g., it is not hard to add early stopping, but it requires to change the tensor2tensor code directly.
(instead of using the elegant solution of --t2t_usr_dir and registry to be able to inject code from some other folder / repository)
Obviously, not duplicating any tensor2tensor code would be preferred given this means there is no problem when updating tensor2tensor.
(while with duplicated code, the duplicated part should be fixed every time)
Any insight w.r.t. how to do that?
Thanks,
Mirko

My personal opinion: There is a clear and simple interface for problems / hparams / models, which allows to separate the code and inject it from outside and there is low risk that this external code will have to be updated frequently with new versions of t2t.
I am not sure if this is possible with the training process. Maybe it is more desirable (better for users from the long-term point of view) to integrate all enhancements (such as --early_stopping option, which should be by default off) to the master (via pull requests).

Thanks @martinpopel - your proposal makes sense.
I'll complete the implementation and follow up - closing the issue for now.

In the new release 1.2.0 we made it easy to call T2T models from raw session, as in this test:
https://github.com/tensorflow/tensor2tensor/blob/master/tensor2tensor/utils/trainer_utils_test.py#L96
It can be used for writing your own training loop in a few dozen lines.

thanks for the info @lukaszkaiser  !


Cant install on a Js project

i keep getting this error everytime i try to install on my non-ts project
Failed to load tsconfig.json. Couldn't find tsconfig.json

Hi @ayofimihan. This components are meant for TypeScript projects. If you want to use them in a js project you can copy them from the docs and remove the types.

I am facing the same issue. I am following the installation instructions to the dot. Which means running the following commands.
npx create-next-app@latest nextjs-test --typescript --tailwind --eslint
npx shadcn-ui@latest init
npx shadcn-ui@latest add button

@prashantchhonker did you cd into the nextjs-test folder?

@ayofimihan the latest version of the cli adds the support for JavaScript 🚀 .

Hi @dan5py I recently faced this issue, I am also using js, and trying to install this lib. But When I use this npx shadcn-ui@latest add alert-dialog using the latest cli version it instantly gives me the error Failed to load tsconfig.json. Couldn't find tsconfig.json. I am used to tsconfig.json.
And also I have init components.json using this npx shadcn-ui@latest init.
Any suggestions? What to do?

Hello @Namnika @prashantchhonker ,i assume you are using react js. I have been using shadcn at my own js react vite project too, you can use my starter repo if you like.
https://github.com/spiritoftime/shadcn-reactjs-starter

I ran into this issue as well with a non-TS project. I manually added a tsconfig.json file at the root of the project and inserted the block of code provided in step 4 of the manual instructions. Then I ran the init command npx shadcn-ui@latest init and stepped through the questions - specifying 'no' to the "Would you like to use TypeScript (recommended)?" questions. When I installed the Badge component, it added a .jsx file into components/ui dir.

Found the issue
You need to add a jsconfig.json to the file to mention the alias paths if you have a need to support any
For eg.
{
  "compilerOptions": {
    "paths": {
      "@/*": ["./*"]
    }
  }
}

The error message needs to be updated to specify missing jsconfig.js file instead of tsconfig.json file when tsx is false in components.json file

Found the issue You need to add a jsconfig.json to the file to mention the alias paths if you have a need to support any
For eg.
{
  "compilerOptions": {
    "paths": {
      "@/*": ["./*"]
    }
  }
}

The error message needs to be updated to specify missing jsconfig.js file instead of tsconfig.json file when tsx is false in components.json file

Thanks! That was my problem!

Thanks everyone, I now fully use typescript lol.

Hello @Namnika @prashantchhonker ,i assume you are using react js. I have been using shadcn at my own js react vite project too, you can use my starter repo if you like. https://github.com/spiritoftime/shadcn-reactjs-starter

Thanks!,

Hello @Namnika @prashantchhonker ,i assume you are using react js. I have been using shadcn at my own js react vite project too, you can use my starter repo if you like. https://github.com/spiritoftime/shadcn-reactjs-starter

Thanks :)

Thanks :D

@spiritoftime, thank you so much. it worked. I am so happy now!

Found the issue You need to add a jsconfig.json to the file to mention the alias paths if you have a need to support any
For eg.
{
  "compilerOptions": {
    "paths": {
      "@/*": ["./*"]
    }
  }
}

The error message needs to be updated to specify missing jsconfig.js file instead of tsconfig.json file when tsx is false in components.json file

Thanks it worked for me

@spiritoftime Thank you so much for sharing the repo link! :) And I tried to do it with customization of React + Vite + shandcn which worked well.
Thanks All of the way!

in my React.js vite its not working still the same error.

It seems like it is back to not supporting the jsconfig.json.
I have created the jsconfig.json and used the path but the error tsconfig.json appears.
Any solution to this?

npx shadcn-ui@latest add stepper failed to use this

If using vite vite.config.js also needs to be updated.
import { defineConfig } from "vite";
import react from "@vitejs/plugin-react";
import path from "path";

// https://vitejs.dev/config/
export default defineConfig({
  plugins: [react()],
  resolve: {
    alias: {
      "@": path.resolve(__dirname, "./"),
    },
  },
});

I don't like typescript

Thanks a lot sakettawde

Hey!
For those how're having this issue, just do the following:

Create a 'tsconfig.json' or 'jsconfig.json' at the root directory of your project (create the file at the directory where your package.json file is located).

Add the following to the new file created:

For Ts:
{
"compilerOptions": {
"target": "es6",
"module": "commonjs",
"strict": true,
"esModuleInterop": true,
"skipLibCheck": true,
"forceConsistentCasingInFileNames": true
},
"include": ["src"]
}
For Js:
{
"compilerOptions": {
"target": "es6",
"module": "commonjs",
"checkJs": true
},
"include": ["src"]
}

You can run the command again and it will work 💯. Be sure to check shadcn docs so as to answer the questions asked correctly.

✌🏼

@spiritoftime you are the goat, thanks

I ran into this issue as well with a non-TS project. I manually added a tsconfig.json file at the root of the project and inserted the block of code provided in step 4 of the manual instructions. Then I ran the init command npx shadcn-ui@latest init and stepped through the questions - specifying 'no' to the "Would you like to use TypeScript (recommended)?" questions. When I installed the Badge component, it added a .jsx file into components/ui dir.

Used this on Aug 4, 2024 - and it worked.

https://www.instagram.com/1900_officelle?igsh=MW5ueDI0b21qbW44Zg==
Brian Ball @.***> schrieb am Mo., 5. Aug. 2024, 06:35:

I ran into this issue as well with a non-TS project. I manually added a
tsconfig.json file at the root of the project and inserted the block of
code provided in step 4 of the manual instructions
https://ui.shadcn.com/docs/installation/manual. Then I ran the init
command npx @.*** init and stepped through the questions -
specifying 'no' to the "Would you like to use TypeScript (recommended)?"
questions. When I installed the Badge component, it added a .jsx file
into components/ui dir.
Used this on Aug 4, 2024 - and it worked.
—
Reply to this email directly, view it on GitHub
https://github.com/shadcn-ui/ui/issues/821#issuecomment-2268154242, or
unsubscribe
https://github.com/notifications/unsubscribe-auth/BIO77CLUX7NCLFUN3DVPTZLZP36INAVCNFSM6AAAAAAZ4VL4D2VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDENRYGE2TIMRUGI
.
You are receiving this because you are subscribed to this thread.Message
ID: @.***>


[ci] Fix BIN_DIR merging and artifact passing between jobs

The CI build pipelines is split into different jobs. Build artifacts between jobs are passed in the BIN_DIR directory. Due to a variety of misunderstandings and bugs, this passing wasn't working as expected:

Multiple jobs produced identical artifacts in BIN_DIR, i.e. we didn't have an unambiguous build rule for each output in BIN_DIR any more.
Partial BIN_DIR artifacts were downloaded from unrelated jobs in a non-determinisic manner.
The overall system of selecting intended build artifacts and merging partial BIN_DIR outputs into a final result wasn't very robust.

This series of commits fixes the underlying problems and makes the whole build pipeline a bit more robust and explicit; see the individual commit messages for details.
In the medium term, much of the logic contained in the pipeline definitions today should be part of a higher-level build system, which, for example, takes care of having unambiguous ways to produce output artifacts, and ensures that the right input artifact dependencies are present or built if needed. That work has started and will hopefully come to fruition soon. In the meantime, I went for a fix which improves on the status quo without going overboard.
Thanks a lot to @vogelpi for ultimately finding the reason why builds were failing when I got lost in the weeds of synthesis logs.
Fixes #5029
Fixes #5044

Thanks for your reviews, I've updated the comments a bit and merged the result.

thanks @imphil and @vogelpi for fixing this!


 The stone brick slab was on the lower half of the adjacent block. See screenshot below:

I'm not sure if this is related to issue: https://github.com/CJMinecraft01/DoubleSlabs/issues/48
While the server did crash, the crash-report did not tell much. However, the latest.log shows the error.
latest.log
crash-2020-06-18_23.29.23-server.txt

Minecraft Version: 1.15.2
Operating System: Linux (amd64) version 4.15.0-99-generic
Java Version: 1.8.0_251, Oracle Corporation
Forge: 31.2.20
DoubleSlabs-1.15-2.5.1
Crafting Station 3.1.0

Hi! This is related to that issue. If you update to the latest version 2.6.1 it should be fixed. There should be a Crafting Station update soon once my PR is accepted


Unable to display data in a combo bar-line (ChartJS 2.0)

Hi,
I have a weird problem with my combo bar-line which should display like this : http://i.stack.imgur.com/7pVUf.png
I use angular and bootstrap to display a particular chart when i click on a tab.
I load asynchronously datasets, then i put them in a new Chart() instance displayed in my page. (I clear the last chart with destroy() method).
But sometimes, nothing appears in my canvas, there are juste a white space delimited by my height and width attributes. (occasionally it works well but i can't understand why ...)
Morever there is 0 error in my console...
Whereas my datasets structure is the same, and my datasets aren't empty, null or something else.
The canvas id and context are goods, so what's wrong ?
This is a little part of my angular controller
if( $scope.graphes[ graphe_index ].data.type == "combo" ){
//console.log("Combo !!!!");
//console.log( $scope.graphes[ graphe_index ].data.dataCombo );
		if( $scope.newCharts[ graphe_index ] ){
			$scope.newCharts[ graphe_index ].destroy();
        }

		$scope.newCharts[ graphe_index ] = new Chartjs(
			document.getElementById("combo-"+graphe_index).getContext("2d"),
			{
				type: 'bar',
				data: $scope.graphes[ graphe_index ].data.dataCombo,
				options: {
					responsive: true,
					responsiveAnimationDuration: 1000,
                    tooltips: {
                        enabled: true
                    }
				}
			}
		);
	}

$scope.graphes[ graphe_index ].data.dataCombo is obtained by a php page callback.
PS : Sorry for my english, i hope i explained well my problem here.

Is it possible to create a JSBin for this?
Alternatively, after #1646 was merged you do not need to recreate the chart. You can simply change the data object and call update().
I will reopen this when a test case becomes available.


Update README.md

Correct directory for markdown files

And correct an mistake in the CSS file, influencing all td elements outside this module

Thank you for the update!