[fix] [broker] When notify wait opReadEntry, use same policy to calculate readPosition.

Fixes #15101
Motivation
Unify opReadEntry's readPosition calculated policy.
Documentation
Need to update docs?

[x] no-need-doc
(Please explain why)

close it, it cover by https://github.com/apache/pulsar/pull/15098/commits/23b3dd76f02bba8ab690b8aa7c0fdd886dc0c7ed in #15098


Fix logging filename lookup.

Description

runtime.Callers may be inlined so don't try to skip it.
Increase callers buffer, new versions of logrus use a deeper stack.

Related issues/PRs

Todos

[ ] Tests
[ ] Documentation
[ ] Release note

Release Note

Fix that Felix logs would sometimes record <nil> for the filename of some logs.

/merge-when-ready

OK, I will merge the pull request when it's ready, leave the commits as is when I merge it, and leave the branch after I've merged it.


DialogSpots not showing up

Hello there i am having an issue with the SpotsDialog, the box shows up but not the DialogSpotCount, i have already implemented it before and everything  was ok, i changed a bit  of code(not sure but i think the xml themes).
What's the problem with it and how can i solve it.
I implemented the same code just  as the instructions are given. Any help?

Could it be that the spots are not shown up because i have used Proguard shrink and minify?  I read somewhere about this.

Hi, @erkand-imeri Sorry for late response. It looks like proguard removed unused resources. Please, take a look at readme or #10. Thanks


Emphasize features on Chrome Web Store

Hi!
I just want to tell you that this extension is awesome and I use it on all my machines, BUT I always have trouble finding/installing it, since its not really optimized for SEO. I know this may sound dumb, but you should really emphasize that this extension can move tabs between windows, since its a killer feature other extensions don't really provide. Yet when I'm searching for "chrome move tabs between windows" on Google it simply doesn't list this extension, which should be #1 in my opinion.
(This just happened to me today: I wanted to install this extension at my workplace, but I simply couldn't find it, while I knew that I have this installed at home. I just did not remember its name and Google doesn't know about it either.)
So I suggest updating the Chrome Web Store description so people can find it easier.
Thanks for the extension again!

Thanks for pointing this out! I'm glad you find this extension useful 🙂 I've updated the description and added more visuals while I was at it. I don't know if this will help much with SEO, but let's see how it goes.


New tab/window doesn't open on current directory on iterm2

Even with Preferences -> Profile -> General -> Working Directory set to "Reuse previous session's directory", a new tab or window always open on ~/.
OSX: El Capitan
iTerm2: Build 3.0.20161226-nightly

Hey @gmattar this repo is not being maintained, see #1239
The community fork is here https://github.com/zsh-users/prezto, please move this issue to zsh-users and we will be able to help you!
zsh-users is an organization dedicated to host Zsh community projects and therefore became the rational home for a community maintained version of prezto.

I'm not able to reproduce this with iTerm2 3.0.15. Do you have any additional information for reproducing this?

I think this must be a problem with my prezto configs, since it doesn't occur to anyone else and oh-my-zsh works fine. I'll play with different config next weekend, see what happens and let you guys know.
This is the basic of it:
.zpreztorc
zstyle ':prezto:*:*' color 'yes'

zstyle ':prezto:load' pmodule \
  'history' \
  'directory' \
  'completion' \
  'syntax-highlighting' \
  'history-substring-search' \
  'prompt'

zstyle ':prezto:module:editor' key-bindings 'emacs'

zstyle ':prezto:module:prompt' theme 'agnoster'

.zprofile
if [[ "$OSTYPE" == darwin* ]]; then
  export BROWSER='open'
fi

export EDITOR='vim'
export VISUAL='nano'
export PAGER='less'

if [[ -z "$LANG" ]]; then
  export LANG='en_US.UTF-8'
fi

typeset -gU cdpath fpath mailpath path

path=(
  /usr/local/{bin,sbin}
  $path
)

export LESS='-F -g -i -M -R -S -w -X -z-4'
if (( $#commands[(i)lesspipe(|.sh)] )); then
  export LESSOPEN="| /usr/bin/env $commands[(i)lesspipe(|.sh)] %s 2>&-"
fi

if [[ ! -d "$TMPDIR" ]]; then
  export TMPDIR="/tmp/$LOGNAME"
  mkdir -p -m 700 "$TMPDIR"
fi

TMPPREFIX="${TMPDIR%/}/zsh"

.zshrc
if [[ -s "${ZDOTDIR:-$HOME}/.zprezto/init.zsh" ]]; then
  source "${ZDOTDIR:-$HOME}/.zprezto/init.zsh"
fi

unsetopt CDABLE_VARS
unsetopt AUTO_NAME_DIRS

export PATH="/usr/local/bin:$PATH"
export PATH="/usr/local/opt/coreutils/libexec/gnubin:/usr/local/bin:$PATH"
export EDITOR='vim'

# improve bash history
export HISTFILE=$HOME/.bash_history

# RVM.
export PATH="$PATH:$HOME/.rvm/bin" # Add RVM to PATH for scripting
[[ -s "$HOME/.rvm/scripts/rvm" ]] && source "$HOME/.rvm/scripts/rvm"

# NVM.
export NVM_DIR="$HOME/.nvm"
[ -s /nvm.sh ] && . /nvm.sh

Thanks for following up on this!
I unfortunately wasn't able to reproduce it even with your configuration (though I don't have rvm or nvm installed). Maybe it's an issue with the version of iterm or zsh you're using?
Alternatively, maybe enabling the iterm shell integration would help. Browsing through the code this installs, it looks like it uses some magical escape codes to set CurrentDir, which may help it track properly.

Ah, here's the other PR I was thinking of. https://github.com/sorin-ionescu/prezto/pull/1226

This is real, and I don't remember why it's happens. The iTerm2 shell integration conflicts. The terminal module, prompt themes, will have to be redone.

I didn't have time to play with settings this weekend but I have good news. I installed shell integration (as @belak suggested) and now the issue is gone.
I'll try to remove shell integration and activate/deactivate modules to see if I can narrow down the origin of the problem in the coming days.

Hey @gmattar did you end up finding this issue root cause?

No, but I settle down with the shell integration fix. I haven't seen this issue for a long time.


This is awesome!

I didn't know where to add a comment.
This is awesome. Thanks!

:+1: Just did the exercise with 10+ students ... thanks for creating this @thomaspark :heart:

I've been giving talks on Flexbox, and I'm definitely adding this as a slide if I do another speaking date. You rule!

:sparkles: :sparkling_heart: :sparkles:

I loved it, really awesome! :+1:

:+1:

Thank you for creating such a delightful and enjoyable app to learn Flexbox. You rock!

:+1: yep, the app is fantastic, thank you for creating this!

This is so awesome really cool.... :+1:

If only all learning was this much fun!  Great work!

+1

Excellent job brother, very creative 👏👏👏 @thomaspark

Awesome!

The best way of teaching Flex!

Amazing! A great visual way to learn Flex! Thanks!

yes! probably the best tutorial I've encountered for any programming topic

Nice game.

Great way to learn. Easy and simple way to practice.


Reset timeout after connection

If we set only connect_timeout — it will be used even after connection.

Are you going to merge this?

yes, and sorry for the delay.
Currently the thriftpy is in a pretty stable state, it's used as a core lib in ele.me website which processed over 5 million orders per day. we'll merge and release new version every 3-6 months, based on development cycle.


I can not add additional parameters??

What ist wrong guys ?
sensor:

platform: luxtronik2
sensors:

group: calculations
id: ID_WEB_Temperatur_TVL
id: calculations.ID_WEB_Temperatur_TVL
friendly_name: Temperatur Vorlauf
icon: mdi:thermometer
group: calculations
id: ID_WEB_WMZ_Durchfluss
id: calculation.ID_WEB_WMZ_Durchfluss
friendly_name: WMZ_Durchfluss
group: calculations
id: ID_WEB_Durchfluss_WQ
id: calculation.ID_WEB_Durchfluss_WQ
friendly_name: Durchfluss_WQ

Which HA and luxtronik integration version habe you installed?
Please provide an integration diag file as attachment in this ticket.

config_entry-luxtronik2-0f26c9a1c64546377e3ad50d2ff8cab5.json (1).txt

This is normal and no bug.
Please notice that the Alpha-Core-Preview no more support yaml configs! You can use https://github.com/Bouni/luxtronik parallel for yaml configs.

See
sensor.*_flow_in_temperature
ID_WEB_Temperatur_TVL

yes thank you
but when i update to new core [2023.9.2]
luxtronik2 shows no devices anymore ?

with with luxtronik2 2023.04.30
should i downgrade to 2023.03.24 ??

Please try 2023.9.19-Alpha-Core-Preview


kubectl rollout status deployment has no response

What happened?
Running the kubectl rollout status deployment without specifying deployment name raises no error and gives back no response.
What did you expect to happen?
Should either throw an error or give status for at least the existing deployment(s)
How can we reproduce it (as minimally and precisely as possible)?

Run any deployment
run kubectl rollout status deployment

Anything else we need to know?
No response
Kubernetes version

Client Version: version.Info{Major:"1", Minor:"23", GitVersion:"v1.23.3", GitCommit:"816c97ab8cff8a1c72eccca1026f7820e93e0d25", GitTreeState:"clean", BuildDate:"2022-01-25T21:17:57Z", GoVersion:"go1.17.6", Compiler:"gc", Platform:"darwin/amd64"}
Server Version: version.Info{Major:"1", Minor:"23", GitVersion:"v1.23.1", GitCommit:"86ec240af8cbd1b60bcc4c03c20da9b98005b92e", GitTreeState:"clean", BuildDate:"2021-12-16T11:34:54Z", GoVersion:"go1.17.5", Compiler:"gc", Platform:"linux/amd64"}
```console
$ kubectl version
# paste output here
```

Cloud provider

Locally with Minikube

OS version

# On Linux:
$ cat /etc/os-release
# paste output here
$ uname -a
# paste output here

# On Windows:
C:\> wmic os get Caption, Version, BuildNumber, OSArchitecture
# paste output here

Install tools

Container runtime (CRI) and version (if applicable)

Related plugins (CNI, CSI, ...) and versions (if applicable)

It seems like it should show a message like No resources found in default namespace. similar to when you do kubectl get deployment.
/triage accepted

It seems like it should show a message like No resources found in default namespace. similar to when you do kubectl get deployment.
/triage accepted

Indeed. I used to have version 1.23.3, and this command was freezing in both cases (with or without a deployment). After upgrading to 1.26.1 it is showing the response in case there is a deployment and shows no response in case there is none. This is the issue I'm trying to address here. I think it should give a proper response in case there is nothing deployed.

I want to work on this issue. @martin-majorov

As far as I can see, nobody has assigned this issue yet. @murthy95 feel free to work on it. It would be great if you also add some testing steps(integration test probably) to assure that your fix is working.

@murthy95 did you have any chance working on this issue?

/assign

@ardaguclu @brianpursley
From reading through this issue it sounds like the fix is to show the no resources found message when no deployments are running. Otherwise this command is functioning properly? Thats what my testing is showing. Any other concerns here?
I will work on tests to ensure the fix is working as mentioned by @ardaguclu. Does this fix require release note?
Thanks


HHH-14287 Create "project template"

Signed-off-by: Jan Schatteman<EMAIL_ADDRESS>

Seems issue remained for another PR as well.
On Mon., Nov. 9, 2020, 16:41 Jan Schatteman<EMAIL_ADDRESS>wrote:

@jrenaat commented on this pull request.
In tooling/project-template/src/main/resources/gradlew
https://github.com/hibernate/hibernate-orm/pull/3621#discussion_r520138232
:

@@ -0,0 +1,185 @@
+#!/usr/bin/env sh

I would agree, were it not for the fact that in my latest correction I
actually deleted it, because it actually doesn't work any more ('gradle
wrapper' update run is needed, which defeats the purpose of having it in
the first place a bit).
Either way I did not amend that commit correctly, so it didn't actually
get removed; I noticed thanks to your comment.
I've corrected the mistaken commit. Thanks!
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/hibernate/hibernate-orm/pull/3621#discussion_r520138232,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AB6UYASTVZQ5X3TNR3HWYYLSPBOZ5ANCNFSM4TLQXFKA
.

Seems issue remained for another PR as well.
…
Not sure I understand what you mean? The most recent commit removes it, that should be enough I think?

I meant the PR for HHH-14285.
On Mon., Nov. 9, 2020, 17:03 Jan Schatteman<EMAIL_ADDRESS>wrote:

Seems issue remained for another PR as well.
… <#m_-831689747167763944_>
Not sure I understand what you mean? The most recent commit removes it,
that should be enough I think?
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/hibernate/hibernate-orm/pull/3621#issuecomment-724304715,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AB6UYATIXHE6WDBM5WJB6FTSPBRKNANCNFSM4TLQXFKA
.

I meant the PR for HHH-14285.
…
On Mon., Nov. 9, 2020, 17:03 Jan Schatteman, @.***> wrote: Seems issue remained for another PR as well. … <#m_-831689747167763944_> Not sure I understand what you mean? The most recent commit removes it, that should be enough I think? — You are receiving this because you commented. Reply to this email directly, view it on GitHub <#3621 (comment)>, or unsubscribe https://github.com/notifications/unsubscribe-auth/AB6UYATIXHE6WDBM5WJB6FTSPBRKNANCNFSM4TLQXFKA .

https://github.com/hibernate/hibernate-orm/pull/3623 doesn't contain a gradlew, it's just a minor correction.


Different questions

Hello,
first thanks a lot for this repository, it allowed me to discover ImGui trough the web and it's super useful for my usecase.
Will you maintain the repo and update the ImGui version to the latest from times to times ?
Why are some styles readonly, like ItemSpacing ?

Hello,
first thanks a lot for this repository, it allowed me to discover ImGui trough the web and it's super useful for my usecase.
Will you maintain the repo and update the ImGui version to the latest from times to times ? Why are some styles readonly, like ItemSpacing ?

I Cant wait to use this package. Thank you Zhobo so much.
I'm struggling to incorporate this into my project. Would you be willing to help me. I'm very knew to web-assembly and I'm trying to wrap my head around what I need to do to get this package usable in my project. I would compensate for any help.
Again, thanks so much for the selfless contribution to the community!

there are also npm package @zhobo63/imgui-ts


needs_types registered twice using add_need_type()

Hi,
We are developing a sphinx need extension. When using the add_need_type method to register types as follows for example:

add_need_type(app, "type1", "TY1", "TY1_", "#BFD8D2", "node")
add_need_type(app, "type2", "TY2", "TY2_", "#BFD8D2", "node")

We are getting warnings during the sphinx-build suggesting that:

...
[app] adding directive: ('type1', <class 'sphinxcontrib.needs.directives.need.NeedDirective'>)
WARNING: la directive 'type1' est déjà enregistrée, elle sera écrasée
translating: 'type1' directive is already registered, it will be overwritten

It seems that, in the add_need_type method, the directive is:

being appended to needs_type configuration which is, at config-inited state, registered
being immediatly registered (add_directive)
So it is indeed registered twice

As a temporary solution, we are currently doing method #1 (only append the new types to needs_type). We plan to use -W option to build our doc, meaning a warning fails the build*
Thanks

I understand the problem, but I'm not sure I understood the reason why it gets triggered.
Is the new type, registered via add_need_type, also available in conf.py?
Or gets it just registered by using the API?
Mhh maybe the reason is also the order of execution.
Your plugin should register stuff only if the original sphinx-configuration step is done.
So it should be called by a sphinx event:
app.connect("config-inited", sphinx_needs_update)
This is how  Sphinx-Test-Reports is doing it.

Hi @danwos,
Thank you very much for your quick reply !

Is the new type, registered via add_need_type, also available in conf.py?
Or gets it just registered by using the API?

Only registered using the API, no needs_types declared in our conf.py.

Mhh maybe the reason is also the order of execution.
Your plugin should register stuff only if the original sphinx-configuration step is done.
So it should be called by a sphinx event:
app.connect("config-inited", sphinx_needs_update)

Indeed it seems that all our configuration part was done before sphinx config-inited. I guess it could involved some conflicts. Connecting our setup to config-init state using the method you mentioned solved the issue.
I think we can close this
Thank you again.


Rewrite GitHub forks

Messages

:book:
:sparkles: Thanks for your contribution to Shields, @paulmelnikow!

  Generated by :no_entry_sign: dangerJS against 957ef5d762fe1f5007dd5d7a793ee2c0ea19b7c4


March 2020 updates

Pull Request Test Coverage Report for Build 794

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 62.233%

Totals

Change from base Build 791:
0.0%

Covered Lines:
931

Relevant Lines:
1496

💛  - Coveralls


Older GNU Licenses are not tagged on the FSF license page

Older licenses like the GPL-1.0 and LGPL-2.0 are not covered by the FSF's license list or compat table.  Presumably, the FSF considers them free, but deprecated in favor of their later versions (like the OSI's “Superseded licenses”).  It would be nice to have FSF metadata for these older licenses, even if they are not current enough to deserve billing in the main list.
Previous discussion here and later.

Those older licenses are indeed not listed at that specific page, but is listed at both https://www.gnu.org/licenses/licenses.html#LicenseURLs and https://www.gnu.org/licenses/old-licenses/old-licenses.html

On Tue, Feb 27, 2018 at 02:19:39PM -0800, Jonas Smedegaard wrote:

Those older licenses are indeed not listed at that specific page,
but is listed at both
https://www.gnu.org/licenses/licenses.html#LicenseURLs and
https://www.gnu.org/licenses/old-licenses/old-licenses.html

Right, but those pages don't tag them 1.  For example, I expect the
FSF considers the GPL-1.0 to be libre but not gpl-2-compatible,
gpl-3-compatible, fdl-compatible, or viewpoint.  But I don't want to
make those tag calls without FSF wording to anchor them on, and I'd
really like to have the FSF make those assignents using something
machine readable like the HTML classes that 1 is translating.

For the OFL-1.0 in particular, the license is already mentioned in the entry for OFL-1.1 https://www.gnu.org/licenses/license-list.en.html#SILOFL...

Ah, I'd missed that.  I've just floated #19 to address it.
For the other licenses, separate entries would be nice (because that's how I get the license text link), but it's not required.  If you have many sections covering multiple licenses, I'll have to add logic to manually override those links when appropriate, but I'll need the FSF linking somewhere for it's view on the canonical text (I don't want to have to guess which text the FSF considers SILOFL-1.0 applies to).
Regardless of how you split the licenses among entries, it would be nice to have license-specific anchors to link to, because those anchors would survive the licenses being split into separate sections in the future.  It's also nice to not have to come up with my own "what would the FSF choose" identifiers ;).


fix: use find_package to fix rolling build error

Follow up from:

https://github.com/autowarefoundation/ros2_socketcan/pull/42

Attempts to fix:

https://github.com/autowarefoundation/ros2_socketcan/actions/runs/8421904097/job/23059902100?pr=42#step:5:371

I don't know why is this necessary but without find_package(can_msgs REQUIRED) it cannot build with rolling.

Wrong judgement from my side.
It turns out this was coming from rosdep not resolving the package.xml things because I was in Ubuntu jammy and instead was asking for noble.
Instead opened this PR:

https://github.com/autowarefoundation/ros2_socketcan/pull/44


Nested quote example not rendering correctly on

As seen on Markdown syntax  and in the screenshot below, the nested quote is not rendering correctly.
A preview of the file in GitHub does do the nested quote rendering fine

You need a blank blockquote line between the 2nd blockquote level, for example:
> Blockquote
>
> > Indented blockquote
>
> Continuation of original

Hugo uses BlackFriday renderer which has more in-depth documentation here
Agreed though, our documentation needs updating. Fixing in a minute.


Multiple Dutch translation issues

ℹ Computer information

PowerToys version: 2.25.0
PowerToy utility: Multiple
Language: Dutch

📝 Provide where the issue is / 📷 Screenshots

PowerRename

Enumerate items

Info about PowerRename

Example is from PowerRename, but it's in each settings page (Kenmerk / Attribution)

Dark / Light / Windows default

❌ Actual phrase(s)
1: Voedingsnaam wijzigen
2: Items opsommen
3: Informatie over het wijzigen van de voedingsnaam
4: Kenmerk
5: Choose a mode / Dark / Light / Windows default / Windows color settings
✔ Expected phrase(s)
1: Power Rename
2: Items nummeren
3: Over PowerRename
4. Credits OR Met dank aan OR Referentie
5. Kies een modus / Donker / Licht / Windows standaard / Windows kleurinstellingen
ℹ Why is the current translation wrong

"Voedingsnaam wijzigen" means something like: change the name of the power supply
"Items opsommen" means "Sum up items" while it's nog summing up anything, but just giving them a number
Again, "PowerRename" is translated as something like "information about changing the name of your power supply"
"Kenmerk" means something like a property of something. The English term "Attribution" is not that clear to me either. Is "Thanks to" or "Reference" better? Please note that this text is in almost each settings page.
No explanation needed.

Good points. I've seen these too - also Dutch here. I was kind of assuming that most of these would be noticed (by the developers) along the way, but still good to make an issue for it. Number 5, for example, is definitely on the radar: #7632
I would translate the word 4: "attribution" to "bijdrage".

https://ceapex.visualstudio.com/CEINTL/_workitems/edit/335839

https://ceapex.visualstudio.com/CEINTL/_workitems/edit/335839

Is that addressed to somebody specific or something internal? Just wondering.

Internal tracking to prove to myself I filed the issue and do targeted follow ups.

@crutkas I see in 0.31.1 numbers 3 and 5 are done. Do you know if the others are overlooked or just still on the way?

I'm trying to work with the team.  We are still learning how to best communicate data back and forth.  They live in their tool chain and without knowing how to parse it, it is a bit hard to understand what actions were taken.

Really guys, three months to change an obvious error?
Not everything MUST be translated, sometime the name of the program is the name of the program.....

Should be in next release.
@bronstijn-git we need to follow a process and make sure we're on the different team's schedule.  Not as easy as go-go-go!

Great news!  This was resolved in the newly released 0.33 version of PowerToys!  Head to https://aka.ms/installpowertoys to grab latest.

PowerRename context menu (Voedingsnaam wijzigen --> Power Rename) is still wrong btw. Version 0.41.4

@dedavis6797  fyi, create a new issue and file the bug against loc. from @opus-x


Support for Desktop

Hello,
is there the plan to expand the editor also for using on desktop platforms (Windows/MacOS/Linux)?
Best Regards!

Hello @jogehl ,
The functionality of quill_html_editor relies on the webview_flutter package, which currently offers support exclusively for Android, iOS, and Web platforms. I am open to extending the editor's compatibility to additional platforms, provided that webview support becomes available for those platforms. For now, I will close this issue; however, please feel free to reopen if needed.
Thanks :)

any update on this?


Add config to configure routes for blog posts

At the moment blog posts are routed using Phenomic's default route. Example: file blog/bla-bla-post.md results in URL blog/bla-bla-post/. It would be great to have a config that allows tweaking this to get more blog like URLs like this: blog/2016/10/31/title-of-bla-bla-post/.

I plan to support this. We should extract date and transform this into params (year, month, date) and allow people to use those param in router directly.
We may start by adding a custom code for date extraction here https://github.com/MoOx/phenomic/blob/88d73fd3ba2b27f00fbefbe93cd78c6d4df03e68/src/static/routes-to-urls/index.js#L29

Closing in favor of #700. We will create key from date that will allow you to use :year, :month, :day in react router routes definition, should be enough.


Pager Control: unable to hide buttons

Describe the bug
In a WinUI 2.6 (prerelease) Pager Control, setting any of the (First, Last, Next, Previous)ButtonVisibility to 'Hidden' has no effect.
Steps to reproduce the bug
Steps to reproduce the behavior:

Add Pager to UWP page
Set any of the Button visibilities to 'Hidden'
Run -> Buttons are visible

Expected behavior
Hidden Button should not be visible (or PagerControlVisibility enum should not have 'Hidden' value). Especially in ButtonPanelMode with first and last page number visible the standard buttons should really become invisible.
Screenshots

Version Info
NuGet package version:
[Microsoft.UI.Xaml 2.6.0-prerelease.210113001]

Not using WinUI 3.
Windows app type:

UWP
Win32

Windows 10 version
Saw the problem?

Insider Build (xxxxx)

May 2020 Update (19041)
Yes

November 2019 Update (18363)

May 2019 Update (18362)

October 2018 Update (17763)

April 2018 Update (17134)

Fall Creators Update (16299)

Creators Update (15063)

Device form factor
Saw the problem?

Desktop
Yes

Xbox

Surface Hub

IoT

Additional context

I'll take a look at this.


fix: typo in SILDeclRef.cpp from intializers to initializers

This PR fixes typos in lib/SIL/IR/SILDeclRef.cpp file.
Following typos have been fixed:
intializers -> initializers
No other changes.

@swift-ci please smoke test

@varundhand Please reword the commit message to something meaningful. And please make sure you read and follow our contributing guidelines when submitting changes.

There are 3 commits now. Could you squash them?

@swift-ci please smoke test

@AnthonyLatsis We can squash them before merging.

I have squashed them.

@swift-ci please smoke test

Thank you!


OpenShadingLanguage/master: Change to GNUInstallDirs for install paths

The variables: BIN_INSTALL_DIR, LIB_INSTALL_DIR, INCLUDE_INSTALL_DIR,
DOC_INSTALL_DIR, and MAN_INSTALL_DIR are defined but never used.
Instead, hard coded paths to lib, include, and bin were used. This
will cause difficulty on multi-lib systems or in cases where they
are named differently. The existing variables were replaced by the
GNUInstallDirs variables, which is compatible on all systems.
There were two instances of the install_targets macro defined, so
removed one and upgraded it to use GNUInstallDirs. Also, it was
never used in code, so all library installs were changed to use it.
Thus all library installs now use GNUInstallDirs.
INSTALL_DOCS variable is defined, so it's now controlling if
the documentation is being installed.
Signed-off by: Jonathan Scruggs<EMAIL_ADDRESS>Please Note: This is a port of the code I modified from the RB-1.8 branch and did a full install test of that branch.

[X] I have read the contribution guidelines.
[X] I have previously submitted a Contributor License Agreement.
[ ] I have updated the documentation, if applicable.
[ ] I have ensured that the change is tested somewhere in the testsuite (adding new test cases if necessary).
[X] My code follows the prevailing code style of this project.

From the 1.8 branch test install:
Installed files when set to no docs (note: gentoo installs readme by default) and no tests:
/usr
/usr/bin
/usr/bin/oslc
/usr/bin/oslinfo
/usr/include
/usr/include/OSL
/usr/include/OSL/Imathx.h
/usr/include/OSL/accum.h
/usr/include/OSL/dual.h
/usr/include/OSL/dual_vec.h
/usr/include/OSL/export.h
/usr/include/OSL/genclosure.h
/usr/include/OSL/llvm_util.h
/usr/include/OSL/matrix22.h
/usr/include/OSL/optautomata.h
/usr/include/OSL/oslclosure.h
/usr/include/OSL/oslcomp.h
/usr/include/OSL/oslconfig.h
/usr/include/OSL/oslexec.h
/usr/include/OSL/oslnoise.h
/usr/include/OSL/oslquery.h
/usr/include/OSL/oslversion.h
/usr/include/OSL/rendererservices.h
/usr/include/OSL/shaderglobals.h
/usr/lib64
/usr/lib64/liboslcomp.so
/usr/lib64/liboslexec.so
/usr/lib64/liboslnoise.so
/usr/lib64/liboslquery.so
/usr/lib64/osl.imageio.so
/usr/shaders
/usr/shaders/emitter.osl
/usr/shaders/emitter.oso
/usr/shaders/glass.osl
/usr/shaders/glass.oso
/usr/shaders/image.osl
/usr/shaders/image.oso
/usr/shaders/matte.osl
/usr/shaders/matte.oso
/usr/shaders/metal.osl
/usr/shaders/metal.oso
/usr/shaders/oslutil.h
/usr/shaders/stdosl.h
/usr/shaders/ubersurface.osl
/usr/shaders/ubersurface.oso
/usr/share
/usr/share/doc
/usr/share/doc/osl-1.8.10
/usr/share/doc/osl-1.8.10/README.md.bz2

Why did this fail all the builds? The correct directories are being returned. I added message outputs in the RB-1.8 version and it shows this:
-- CMAKE_INSTALL_PREFIX is /home/travis/build/imageworks/OpenShadingLanguage/dist/linux64.debug
-- CMAKE_INSTALL_LIBDIR is lib
-- CMAKE_INSTALL_BINDIR is bin
-- CMAKE_INSTALL_DOCDIR is share/doc/OSL
When you look at the diff, it's all like for like... except docs.

Oh, I was not aware of the GNUInstallDirs. Nice. I'll give this a try, it's a nice simplification if it works.
Does everything work as expected on Windows? (I have no easy way to test that myself.)
Does it correctly make the python vs python3 directory distinction?

Ah, I see, there isn't a python module for OSL at this time. So 1/2 never mind.
But the other 1/2 -- what will we need to do to support Python modules in the future? The reason that complexity was here is that this section of the build scripts is just copied between the OIIO and OSL projects, and there is some utility in keeping them in sync (makes my life easier, for one thing). So I want to make sure that this solution can be propagated to the OIIO project as well without breaking something there.

@lgritz I noticed there were no python modules, but the variables were defined for it. Python is one of those tricky directories as each distribution seems to have their own structure, for example, on Gentoo: /usr/lib64/python3.5/site-packages/. The only way to do that is to have a variable that package managers can set. A default could be ${CMAKE_INSTALL_LIBDIR}/python3/site-packages. On Gentoo, we have tools that can define things during the configure phase that gets the site directory.
I haven't looked at OIIO yet as it's installing to lib64 for now, but it should be able to be done. I have submitted a PR for OpenEXR already, and have some lined up for OpenVDB, ctl, and OpenSubDiv. I could look at OIIO and do a switch over for it, as it does remove a lot of code and the paths remain overridable. It's illegal now on Gentoo to install to /usr/lib, it must be lib64 or lib32 for multilib systems. GNUInstallDirs handles all that for us.
I was told that GNUInstallDirs is usable on Windows.
More info here:
https://cmake.org/cmake/help/v3.4/module/GNUInstallDirs.html
Thanks for taking the time to look at this PR.

@lgritz handling python in CMake has historically been bad, so there's not a lot of involvement with GNUInstallDirs here.
But please merge GNUInstallDirs, it's an important part for making the CMake-based ecosystem as uniform as possible. All distributions have hooks for the GNUInstallDirs variables.

Do you stand by this review in its current form, or do you want to do a pass on it to compare to what we ended up with on the OIIO side and make sure they match?

@lgritz I will do a compare with the OIIO code. I want them to be as similar as possible. A lot of great changes were done. :)

@lgritz Just cleaned up the a few things to better match oiio. :) Now for a new round of checks.

LGTM. Just waiting for CI tests and I'll give it a try myself. If all pans out, I'll merge it.

Tests all pass. Merging.


gnunet: 0.13.2 -> 0.13.3

Automatic update generated by nixpkgs-update tools. This update was made based on information from https://repology.org/metapackage/gnunet/versions.
meta.description for gnunet is: "GNU's decentralized anonymous and censorship-resistant P2P framework"
meta.homepage for gnunet is: "https://gnunet.org/"
meta.changelog for gnunet is: ""
Updates performed

Version update

To inspect upstream changes
Impact

Checks done (click to expand)

built on NixOS

The tests defined in passthru.tests, if any, passed

0 of 0 passed binary check by having a zero exit code.

0 of 0 passed binary check by having the new version present in output.

found 0.13.3 with grep in /nix/store/lbm6rm8pjkam67wk00c6liz6f0aaifs3-gnunet-0.13.3

directory tree listing: https://gist.github.com/9c9b55c9e0b7f9149b7e01c7959deee5

du listing: https://gist.github.com/45018ff72a2e74d0f9eeffdd6397d5ae

Rebuild report (if merged into master) (click to expand)

6 total rebuild path(s)

2 package rebuild(s)

2 x86_64-linux rebuild(s)
2 i686-linux rebuild(s)
0 x86_64-darwin rebuild(s)
2 aarch64-linux rebuild(s)

First fifty rebuilds by attrpath
gnunet
gnunet-gtk

Instructions to test this update (click to expand)

Either download from Cachix:
nix-store -r /nix/store/lbm6rm8pjkam67wk00c6liz6f0aaifs3-gnunet-0.13.3 \
  --option binary-caches 'https://cache.nixos.org/ https://nix-community.cachix.org/' \
  --option trusted-public-keys '
  nix-community.cachix.org-1:mB9FSh9qf2dCimDSUo8Zy7bkq5CX+/rkCWyvRCYg3Fs=
  cache.nixos.org-1:6NCHdD59X431o0gWypbMrAURkbJ16ZPMQFGspcDShjY=
  '

(The Cachix cache is only trusted for this store-path realization.)
For the Cachix download to work, your user must be in the trusted-users list or you can use sudo since root is effectively trusted.
Or, build yourself:
nix-build -A gnunet https://github.com/r-ryantm/nixpkgs/archive/7fecbee7854e5b7bb11431e4b7d10755b58729f7.tar.gz

After you've downloaded or built it, look at the files and if there are any, run the binaries:
ls -la /nix/store/lbm6rm8pjkam67wk00c6liz6f0aaifs3-gnunet-0.13.3
ls -la /nix/store/lbm6rm8pjkam67wk00c6liz6f0aaifs3-gnunet-0.13.3/bin

Pre-merge build results
We have automatically built all packages that will get rebuilt due to
this change.
This gives evidence on whether the upgrade will break dependent packages.
Note sometimes packages show up as failed to build independent of the
change, simply because they are already broken on the target branch.
nixpkgs-review encountered an error. Please check the logs at https://r.ryantm.com/log/ for more information.

Maintainer pings
cc @vrthra for testing.


Fixed import of mxnet Trainer.

Issue #, if available:
Description of changes:
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Is there a new release of the pip package of gluonts coming up soon which will have the packages at the correct location? I have version 0.5.2 installed and it doesn't seem to like import of gluonts.mx. It does find the packages at the old location of gluonts.trainer.
$ python
Python 3.8.5 (default, Jul 21 2020, 10:48:26)
[Clang 11.0.3 (clang-1<IP_ADDRESS>)] on darwin
Type "help", "copyright", "credits" or "license" for more information.
>>> import gluonts
>>> gluonts.__version__
'0.5.2'
>>> from gluonts.mx.trainer import Trainer
Traceback (most recent call last):
  File "<stdin>", line 1, in <module>
ModuleNotFoundError: No module named 'gluonts.mx'
>>> from gluonts.trainer import Trainer
>>>

Hello @shrinandj,
you are right, these changes are not in the 0.5.x releases. Also, I unfortunately can't promise anything about a 0.6 release, which would include these changes.
You can install gluon-ts directly from github though:
pip install git+https://github.com/awslabs/gluon-ts.git

Hope that helps!


Hello,Where is setDlpfBandwidth defined?

https://github.com/finani/ICM42688/blob/6de46cd15bc35f8c909d1e95334e39e4eb038be2/examples/Interrupt_SPI/Interrupt_SPI.ino#L23

Same question. Is there a way, how to set up Bandwidth?
Thank you.

unfortunately, there is currently not a way to change the LPF bandwidth, although it should be straightforward to add.
From the datasheet, there are two sets of filters whose bandwidth can be controlled - the anti-aliasing filters (AAF) and the UI filters (not sure what UI stands for...)
Currently you can turn on/off the anti-aliasing filters though using setFilters.

Thank you for the answer. Hope it will be added in the future, because for my application it is really needed. I read the manual now and also wondering, what UI could mean...


Modify implementation of CameraAcquisition

... according to the new specification of  CameraView.

Finally integrated in class CameraView.


[Bug] crash on startup

It crashes on startup, before the update this didnt happen.

Geometry Dash Crashed
An exception had occured!
Tip: You can use 'CTRL + C' to copy this message.
== OpenHack information ==

Version: <IP_ADDRESS>
Build date: Apr  7 2024 21:26:28
Commit hash: f8a5a29
Game version: 2.204
Game path: D:\SteamLibrary\steamapps\common\Geometry Dash

== Exception Information ==
Exception code: c0000005 (EXCEPTION_ACCESS_VIOLATION)
Exception flags: 0
Exception address: 40400000 (40400000)
Number of parameters: 2
== Stack Trace ==

40400000
0118F3DC
MSVCR120.dll + 0x9ea6b (_RTDynamicCast + 0x77)
XINPUT9_1_0.dll + 0x1ccc6 (openhack::gui::from_json + 0x156)

== Registers ==
EAX: 000000c8
EBX: 58a98d97
ECX: 0118f3a8
EDX: 73aa123c
EBP: 00000000
ESP: 0118f3f4
EDI: 5889c8e6
ESI: 0118f3c0
EIP: 5889ccc6

OK

Reinstall from the latest release.


Should allow to refresh list of certificates

I was trying to create an installer and picking option to notarize I noticed I hadn't gotten an deverloper Id installer certificate
could have a small ? button there to point to this article: https://delphiworlds.com/2019/07/notarizing-your-macos-64-bit-apps-built-with-delphi/
but most importantly should have a refresh button (or at least do a refresh when I untick and tick back again the "notarize installer") to query for certificate for the installer
similar maybe at other forms that query for certificates have a refresh button in case the user added more certs in the mean time
currently I had to close the create and installer form and open it again (luckily it remembered the fields [guess cause I hadn't closed the Mosco app])

I agree there should be a refresh option for the certs/profiles. It's now on the todo list

Added to version 1.3.0


Add LoRA

I implemented LoRA for Linear, Embedding, Conv1d, and Conv2d, each according to the official peft implementation (with the exception of Conv1d which was implemented according to a Microsoft implementation as there is no peft implementation).
Details
I added a package, called candle-lora that implements LoRA for the above types. Merged weights are not yet implemented, although I plan on implementing them and submitting a PR which will be an addition to candle-lora.
To use candle-lora, the Linear, Embedding, Conv1d, or Conv2d types must be replaced by a Box<dyn ...LayerLike> type in the model struct(s). This is so that they can be swapped out with the new layers without requiring an error-prone model struct duplication.
Because Rust cannot check the types of members without macros, the developer must select layers to convert. Selected layers are passed to candle-lora, and new layers that have a concrete type (Lora...) are returned. To use them, they must be manually inserted into the model struct(s).
Limitations and future plans
Because Rust can not allow dynamic attribute reassignment like Python, candle-lora cannot have as simple an interface as peft does. However, I plan on developing a library that leverages macros to make using candle-lora more ergonomic. This library will allow automatic selection and swapping of layers akin to peft.

Thanks for all the work on this, this look very nice. Maybe we could keep this in an external repo rather than including it here? We would like to emphasize that it's easy to build on top of the candle core libraries and that it's not a monolithic design and candle-lora looks like a great example of this. Fwiw we should probably also move out of the repo things like candle-datasets, the wasm examples, the stable diffusion example if we start to make it more fully featured, the pyo3 bindings, etc.
Additional benefits of a separate repo:

Faster compilation time for the main repo.
It forces us into having a clean boundary between the different parts and not breaking the external facing apis.
The only downside I can see is discoverability of crates but for that I feel that we should add new sections in the main readme such as "Models using candle", "Libraries using candle".

Ok, thank you. I agree - it would be great to have a non-monolithic canndle.

Do you want to make a PR to mention it in the readme? (I can also do it if you prefer but would be great to mention it)


Was this inspired by a particular game?

just wanted to ask this question but couldnt find anywhere else to put this

It was inspired by Outer Wilds, but the gravity crystals in that game don't play that big a role in gameplay.


Download Server not Working

I am not able to download the robomimic data. I tried the webpage, wget as well as the download_datasets.py script.
Downloading dataset:
    task: lift
    dataset type: mh
    hdf5 type: image
    download path: <path-to>/robomimic/datasets/lift/mh

TimeoutError: [Errno 110] Connection timed out

During handling of the above exception, another exception occurred:

urllib.error.URLError: <urlopen error [Errno 110] Connection timed out>

Unfortunately, I believe the servers are down currently due to some problems related to overheating - they should hopefully be back up soon (re-open the issue if you continue having issues tomorrow).


linter

Pull Request Test Coverage Report for Build<PHONE_NUMBER>0
Details

19 of 163 (11.66%)  changed or added relevant lines in 8 files are covered.
18992 unchanged lines in 237 files lost coverage.
Overall coverage decreased (-1.0%) to 57.67%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

peer/brontide.go
0
1
0.0%

feature/manager.go
1
4
25.0%

lncfg/protocol.go
0
3
0.0%

rpcserver.go
0
7
0.0%

htlcswitch/link.go
17
31
54.84%

server.go
0
20
0.0%

itest/lnd_experimental_endorsement.go
0
96
0.0%

Files with Coverage Reduction
New Missed Lines
%

chanbackup/recover.go
1
97.73%

labels/labels.go
1
73.33%

channeldb/invoices.go
2
84.32%

watchtower/wtclient/session_negotiator.go
2
80.32%

channeldb/witness_cache.go
2
77.78%

funding/batch.go
2
81.48%

invoices/invoice_expiry_watcher.go
2
86.26%

chanacceptor/chainedacceptor.go
2
81.48%

brontide/listener.go
2
66.67%

watchtower/wtclient/candidate_iterator.go
2
96.0%

Totals

Change from base Build<PHONE_NUMBER>4:
-1.0%

Covered Lines:
97570

Relevant Lines:
169188

💛  - Coveralls


Query speed is slower after add and connect other relay

Describe the bug
I've just noticed a strange situation after add and connect other relay. I've a simple get_event_of query to get user's metadata, but after add a new relay, it sometime slowdown than before 2x.
Query without add new relay

Query after add new relay

To Reproduce
Repo: https://github.com/reyamir/rust-nostr-debug
In this repo, I've choosed 2 fastest relays with my network.
Expected behavior
Query speed is same as before after add new relay.
Build environment

Library: nostr-sdk
Language: Rust
Language version: 1.78
Tag/commit: c5671aa28866eff93a11a14a056a6195d657ba8e
OS+version: macOS

It's due to the connection time.
In the get_profile_slow you are measuring also the time needed for connection to relay.

Yup, I've updated my repo to better reproceduce.
I also found other problem when you add_relay but not connect then add other relay but this time connectted, this time query will very slow (timeout).
example:
/// Bootstrap
client.add_relay("wss://relay.damus.io").await?;
client.connect().await;

/// Query something
let before = Instant::now();
let _ = get_profile(&client).await;
println!("Elapsed time: {:.2?}", before.elapsed());

/// Then add other relay
client.add_relay("wss://relay.nostr.net").await?;
// let _ = client.connect_relay("wss://relay.nostr.net").await; <- not connect to this relay
println!("Added relay .1");

/// Query something
let before = Instant::now();
let _ = get_profile(&client).await;
println!("Elapsed time: {:.2?}", before.elapsed());

// Then add other relay
client.add_relay("wss://relay.primal.net").await?;
let _ = client.connect_relay("wss://relay.primal.net").await;
println!("Added relay .2");

...

You can see the query 2 is take very long time and timeout too.

Everything will work fine if I added all relays then use client.connect().await
I notice this situation while develop my chat app, when after login user will connect to their inbox relay for fetch new messages. But suddenly all queries is very slow.

my temporary workaround is set timeout to 1 sec 😅
let opts = Options::new().timeout(Duration::from_secs(1))

I've set a simple client handle notifications like this to see what happened behide the scene
client.handle_notifications(|notification| async {
  if let RelayPoolNotification::Message { message, .. } = notification {
    println!("message: {}", message.as_json())
  }
  Ok(false)
})
.await

I notice relay is return event immediately, but somehow the get_event_of command isn't return data.

Yup, I've updated my repo to better reproceduce. I also found other problem when you add_relay but not connect then add other relay but this time connectted, this time query will very slow (timeout).
example:
/// Bootstrap
client.add_relay("wss://relay.damus.io").await?;
client.connect().await;

/// Query something
let before = Instant::now();
let _ = get_profile(&client).await;
println!("Elapsed time: {:.2?}", before.elapsed());

/// Then add other relay
client.add_relay("wss://relay.nostr.net").await?;
// let _ = client.connect_relay("wss://relay.nostr.net").await; <- not connect to this relay
println!("Added relay .1");

/// Query something
let before = Instant::now();
let _ = get_profile(&client).await;
println!("Elapsed time: {:.2?}", before.elapsed());

// Then add other relay
client.add_relay("wss://relay.primal.net").await?;
let _ = client.connect_relay("wss://relay.primal.net").await;
println!("Added relay .2");

...

You can see the query 2 is take very long time and timeout too.

I can do 2 things to solve this:

Return an error if relay is only initialized (never called connect or connect_relay methods) instead of timeout
Add an option to auto start the connection with relay on add_relay method call (maybe disabled by default?)

I've set a simple client handle notifications like this to see what happened behide the scene
client.handle_notifications(|notification| async {
  if let RelayPoolNotification::Message { message, .. } = notification {
    println!("message: {}", message.as_json())
  }
  Ok(false)
})
.await

I notice relay is return event immediately, but somehow the get_event_of command isn't return data.

The get_events_of method wait that all relays return EOSE. If one of them is slow, the method will require more time to finish

Try commit 79b84f618d2e339f13c763f697c6fd56d8062aec
It's available the autoconnect option to automatically start connection with relay when added (disabled by default). If this option is not enabled and the relay connect method is never called, the relay will be immediately skipped without waiting for timeout.
Example for autoconnect option:
let keys = Keys::generate();
let opts = Options::default().autoconnect(true);
let client = Client::with_opts(keys, opts);

client.add_relay("wss://relay.damus.io").await?; // This auto connect

// Query ...

The get_events_of method wait that all relays return EOSE. If one of them is slow, the method will require more time to finish

I wonder is there a way to config this behavior?, instead of wait all relays, I want to wait 1 relay or X relays.

I think that this could be increase again the code complexity. I prefer a solution like https://github.com/rust-nostr/nostr/issues/446. I'll work on it soon

Alternatively, if get_events_of is too slow for your needs, the best way is to use subscribe and handle_notifications methods.
I used this approach for SmartVaults: subscribe at app start, handle notifications in a separated thread and cache things in RAM/DB. I used a channel to notify the UI where there was a new message from the "sync" thread. And when channel notify the UI, get the data from the cache. In this way everything was in real time and no matter if a relay was slow.


How can I list the rules on linux?

First thank you for this nice software.
I want to know how can I see the rules in the server side, to apply IP Allow or Disallow.
Just to apply for every rule created on rathole.

Do you mean an IP whitelist/blacklist for a specific port? You're probably looking for that in firewall configurations, not rathole

Yes I want it, but how rathole create the routes and how can I list?
I try with iptables -S and others but I'm a noob

rathole does not create routes. Just configure your firewall for the port rathole is listening


removed duplicate imports

I saw that some files had duplicate imports so I cleaned them up.

These changes don't apply to the v2 version of the SDK as this code was rewritten.  https://github.com/aws/aws-sdk-ios


DB refactor

Adds new table for DS to store case data.

This is the currently deployed branch. v. 0.35.6


Can not resolve reference: System.Buffers, referenced by System.Memory

I am building a cross platform xamarin forms application using vs2017 version 15.8.7 nad after adding reference to ef core sqllite (2.2.0-preview2-35157) I am getting the following error:
Can not resolve reference: System.Buffers, referenced by System.Memory. Please add a NuGet package or assembly reference for System.Buffers, or remove the reference to System.Memory

@divega to follow up

@marek-safar this bug report looks a lot like what happened in 2.1. Any new known issues with System.Memory again?
@dannythomas13 If you could provide a repro project that would help us and the Xamarin team a lot.

@divega We've got a reproduction project available at https://github.com/xamarin/Xamarin.Forms/issues/3810

I'm getting this error with the 2.1.4 versions of the nuget's.

@divega to follow up.

Is there any repro? I should just work out of the box if you add both System.Memory and System.Buffers nugets.

@marek-safar sorry I did not respond before but the repro was provided by @hartez in https://github.com/xamarin/Xamarin.Forms/issues/3810 as he mentioned above in this thread. It seems that one uses EF Core 2.1.3, while @dannythomas13 reported this happening with 2.2.0-preview2, but the error seems identical.
I will close this issue as external in the meantime, but please mention me in https://github.com/xamarin/Xamarin.Forms/issues/3810 if I can be of any help.


an SPA -> a SPA

Summary
I'm not a native English speaker, but should it be "a SPA" other than "an SPA"?
Fixes #Issue_Number (if available)
No issue number.

hmm, probably I'm wrong, somehow it should be "an SPA"....


Tabs: Focus-styling should be better

With outline focus:

Suggestion:

Example from govuk: https://design-system.service.gov.uk/components/tabs/
@Febakke  Any thoughts? :)

This is fixed in the new tab component


update/od/2.0/hi/index.markdown

Formatted as per the English version format

please update the hindi translation with the new formatted text. I am still seeing the earlier un-formatted version when i see the website of open definition. thanks.


Potential master regression in cilium-operator with clustermesh

A user reported on Slack that the operator would not start up, logs like this:
https://cilium.slack.com/archives/C53TG4J4R/p1573085478010800
level=info msg="Cilium Operator 1.6.90 a5f496448 2019-10-30T12:31:14-04:00 go version go1.13.3 linux/amd64" subsys=cilium-operator
level=info msg="Establishing connection to apiserver" host="https://<IP_ADDRESS>:443" subsys=k8s
level=info msg="Starting apiserver on address :9234" subsys=cilium-operator
level=info msg="Connected to apiserver" subsys=k8s
level=info msg="Retrieved node information from kubernetes" nodeName=ip-10-100-1-228.ec2.internal subsys=k8s
level=info msg="Received own node information from API server" ipAddr.ipv4=<IP_ADDRESS> ipAddr.ipv6="<nil>" nodeName=ip-10-100-1-228.ec2.internal subsys=k8s v4Prefix=<IP_ADDRESS>/24 v6Prefix="<nil>"
level=info msg="Starting to synchronize k8s services to kvstore..." subsys=cilium-operator
level=info msg="cilium-operator running with service synchronization: automatic etcd service translation enabled" address= kvstore=etcd subsys=cilium-operator
level=info msg="Waiting for all services to be synced with kubernetes before connecting to etcd" address= kvstore=etcd subsys=cilium-operator
level=fatal msg="Unable to start status api: http: Server closed" subsys=cilium-operator

I don't have timestamps for it.
When I suggested downgrading operator from latest to 1.6.3, the operator started up fine.

I encountered this by following the guide, after installing Cilium with managed etcd as described here – but instead of downloading a tarball I cloned the repo and ran helm template in the repo master branch at commit 94d62d66c925abd82a47bd3a6df46d5341529173.

No Cluster Mesh here, yet still the same issue with exactly the same log and cilium operator version.
Is there any word on this issue yet? Is it being investigated?
Cheers,
Gergely.

@Skarlso Do you have full reproduction instructions or a sysdump ? In particular I'm curious how much of the environment you share with the reported details above.
I'm wondering if there's some change in the managed etcd handling that we've put in place on master which causes this, or if it's related to some change we made to the operator. /cc @aanm

@joestringer Not that I'm aware of, @Skarlso a sysdump would be really useful in this case.

Sheesh sorry this dropped off my radar. I think we reverted and went ahead. I'll try to gather some more information if I can.


:sparkles:  add support for category index

Description

Checklist

[ ] My changes follow the contributing guidelines of this project.
[ ] I have performed a self-review of my code.
[ ] I have made corresponding changes to the documentation.
[ ] I have added tests that prove my fix is effective or that my changes work.
[ ] New and existing unit tests pass locally with my changes.

Coverage decreased (-0.2%) to 93.425% when pulling d5c626cd47bc687c747098c85dd9731c2263bd8c on feat/category-support into 5fde83fac86e90259678892434c8e7753ebb7bc4 on main.


Fix Chinese spelling errors

enable Chinese spelling checks
fix spelling errors
refer to #2038

[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by: rootsongjc
To fully approve this pull request, please assign additional approvers.
We suggest the following additional approver: linsun
If they are not already assigned, you can assign the PR to them by writing /assign @linsun in a comment when ready.
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

/lgtm

[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by: fleeto, rootsongjc
To fully approve this pull request, please assign additional approvers.
We suggest the following additional approver: linsun
If they are not already assigned, you can assign the PR to them by writing /assign @linsun in a comment when ready.
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

/approve

[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by: fleeto, rootsongjc
To fully approve this pull request, please assign additional approvers.
We suggest the following additional approver: linsun
If they are not already assigned, you can assign the PR to them by writing /assign @linsun in a comment when ready.
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@rootsongjc @fleeto Two errors slipped in:
content_zh/about/notes/0.3/index.md
   17 | 和 Pilot 之间的通信和其他网格内的服务一样，开始使用 mTLS 加密。

content_zh/about/notes/0.8/index.md
   25 | olicy/)提供了统一的 API，管理范围涵盖了服务间的 mTLS 认证和最终用户认证。我们推荐使用认证策略来管理认证的相关行


pttv support

[21:05:49.880] Supibot: mm2pl, reminders from: b_bepis - https://pastebin.com/24TCWV7N -> global manifest. links don't work rn but it should be available at https://pttv.bepis.io/manifest/global.json when i set up a webserver (2h, 5m ago)
FeelsOkayMan

this project is ded from what it seems


Only remove cache folder of the current job

Fixes #5

Now that I see your fix I realize the problem I introduced. Thanks for the PR!


ithc - Update YAML definitions

Automated updates from daily job running on ithc cluster.

Plan Result (ptlsbox-dt-availability-dashboards)
No changes. Your infrastructure matches the configuration.

Plan Result (demo-dt-availability-dashboards)
No changes. Your infrastructure matches the configuration.

Plan Result (stg-dt-availability-dashboards)
No changes. Your infrastructure matches the configuration.

Plan Result (test-dt-availability-dashboards)
No changes. Your infrastructure matches the configuration.


chore: clean unused imports

we might want to consider moving this inside the pyproject.toml for some more organization, and adding many of the other supported ruff rules

we might want to consider moving this inside the pyproject.toml for some more organization, and adding many of the other supported ruff rules

+1, goes along with the ethos expressed in https://github.com/nominal-io/nominal-client/blob/main/CONTRIBUTING.md:

As a rule, all tools should be configured via pyproject.toml, and should prefer configuration over parameters for project information. For example, poetry run mypy should work without having to run poetry run mypy nominal.


Tdr 2466 ons body and series

I've never seen that RETURNING "BodyId" INTO syntax, it's good.

I just copied what @pashworth-tna  did, so can't take any credit for that!


Update _sass.md

A few words in portuguese that are wrong in according with the english version.

Thank you very much!

@chroda Actually, that's just how the portuguese people talk to each other (dialect). Pretty weird, huh?! Though, they really helped this project. <3

@JLammeer hello, its all good? ;)
So.. I'm a Brazilian and to me, its is pretty weird, some words make no sense, I would to ask to @HugoGiraudel is this translate its is to be a portuguese from Portugal translation, so I have no expertise to help (because portuguese from Brasil is pretty different from Portugal).
I be happy to help to revise the entire document with proper time.
Just will be glad in have my name/github mentioned in this repo.

@chroda all good! =D
It has a mix of both dialects, though I don't think it is that hard to read. I mean: I've read it all with no problems.
However, if you think we should have a page for both dialects and our boy @HugoGiraudel support the idea, I would love to help you revise.

hey @JLammeer, I believe its not necessary to make another translation to PT-BR.
but it is important to notice temporal changes, and maybe minor words and confusing terms, I can revise this translation and u check is is okay in both dialects.
(I assuming here you speak pt-pt).
anyway, I'm available to improve and help this repo. <3

@chroda
It seems like a great reason to modify the actual text:

but it is important to notice temporal changes, and maybe minor words and confusing term

Though, u gotta be careful to use words and expressions that makes sense on both dialects. Otherwise, u will be modifying the text just for brazilians and then, maybe someone from another lusophone country will attempt to do the same. Therefore no one will ever be happy.

@JLammeer

Im from Brazil, just like you.
Thats so nice.
Otherwise, u will be modifying the text just for brazilians.
Thats exactly my concern about it and the motivation to revise the words to the simplist way.
The main goal anyway its to provide the spread the information easily.

Hey there! 👋
I’d like to avoid having pt-br and a pt-pt translations, for maintainability reasons mostly. That being said, I agree with you that we need to make sure the content remains understandable in both languages. I’m happy merging any modifications you judge necessary.
One thing I suggest you do is updating the Portuguese README.md to include a note about the language in use and maybe how to keep it consistent and relevant both for Brazilian and non-Brazilian Portuguese.
What do you think?


Google Cloud DNS not working anymore

lego<EMAIL_ADDRESS>\
       --accept-tos \
       --csr="/path/to/csr.csr" \
       --path="/path/to/letsencrypt/data/" \
       --server="https://acme-v02.api.letsencrypt.org/directory" \
       --dns="gcloud" \
       --dns-resolvers="<IP_ADDRESS>:53" \
       --dns-resolvers="<IP_ADDRESS>:53" \
       --dns-resolvers="<IP_ADDRESS>:53" \
       --dns-resolvers="<IP_ADDRESS>:53" \
       --dns-timeout=5 \
       run;

2018/09/20 21:42:34 [INFO] [domain.net, *.domain.net, *.staging.domain.net, domain.info, *.domain.info, *.staging.domain.info] acme: Obtaining bundled SAN certificate given a CSR
2018/09/20 21:42:35 [INFO] [*.domain.info] AuthURL: https://acme-v02.api.letsencrypt.org/acme/authz/xxxx
2018/09/20 21:42:35 [INFO] [*.domain.net] AuthURL: https://acme-v02.api.letsencrypt.org/acme/authz/xxxx
2018/09/20 21:42:35 [INFO] [*.staging.domain.info] AuthURL: https://acme-v02.api.letsencrypt.org/acme/authz/xxxx
2018/09/20 21:42:35 [INFO] [*.staging.domain.net] AuthURL: https://acme-v02.api.letsencrypt.org/acme/authz/xxxx
2018/09/20 21:42:35 [INFO] [domain.info] AuthURL: https://acme-v02.api.letsencrypt.org/acme/authz/xxxx
2018/09/20 21:42:35 [INFO] [domain.net] AuthURL: https://acme-v02.api.letsencrypt.org/acme/authz/xxxx
2018/09/20 21:42:35 [INFO] [domain.info] acme: Could not find solver for: tls-alpn-01
2018/09/20 21:42:35 [INFO] [domain.net] acme: Could not find solver for: tls-alpn-01
2018/09/20 21:42:35 [INFO] [domain.info] acme: Preparing to solve DNS-01
2018/09/20 21:42:38 [INFO] [domain.net] acme: Preparing to solve DNS-01
2018/09/20 21:42:41 [INFO] [staging.domain.info] acme: Preparing to solve DNS-01
2018/09/20 21:42:44 [INFO] [staging.domain.net] acme: Preparing to solve DNS-01
2018/09/20 21:42:47 [INFO] [domain.info] acme: Preparing to solve DNS-01
2018/09/20 21:42:49 [INFO] [domain.net] acme: Preparing to solve DNS-01
2018/09/20 21:42:51 [INFO] [domain.info] acme: Trying to solve DNS-01
2018/09/20 21:42:51 [INFO] [domain.info] Checking DNS record propagation using [<IP_ADDRESS>:53 <IP_ADDRESS>:53 <IP_ADDRESS>:53 <IP_ADDRESS>:53]
2018/09/20 21:45:54 [INFO] [domain.net] acme: Trying to solve DNS-01
2018/09/20 21:45:54 [INFO] [domain.net] Checking DNS record propagation using [<IP_ADDRESS>:53 <IP_ADDRESS>:53 <IP_ADDRESS>:53 <IP_ADDRESS>:53]
2018/09/20 21:48:55 [INFO] [staging.domain.info] acme: Trying to solve DNS-01
2018/09/20 21:48:55 [INFO] [staging.domain.info] Checking DNS record propagation using [<IP_ADDRESS>:53 <IP_ADDRESS>:53 <IP_ADDRESS>:53 <IP_ADDRESS>:53]
2018/09/20 21:49:01 [INFO] [staging.domain.info] The server validated our request
2018/09/20 21:49:01 [INFO] [staging.domain.net] acme: Trying to solve DNS-01
2018/09/20 21:49:01 [INFO] [staging.domain.net] Checking DNS record propagation using [<IP_ADDRESS>:53 <IP_ADDRESS>:53 <IP_ADDRESS>:53 <IP_ADDRESS>:53]
2018/09/20 21:49:07 [INFO] [staging.domain.net] The server validated our request
2018/09/20 21:49:09 [WARN] Error cleaning up staging.domain.info: googlecloud: <nil>
2018/09/20 21:49:11 [WARN] Error cleaning up staging.domain.net: googlecloud: <nil>
2018/09/20 21:49:11 Could not obtain certificates
	acme: Error -> One or more domains had a problem:
[domain.info] Time limit exceeded. Last error: NS ns-cloud-c1.googledomains.com. did not return the expected TXT record
[domain.net] Time limit exceeded. Last error: NS ns-cloud-c1.googledomains.com. did not return the expected TXT record

weird thing is that it validates the *.staging.domain.<tld> domains...
have also tried without --dns-resolvers

@lenovouser good catch, I will fix that immediately

@ldez 👌🏻
this probably doesn't fix the issue why it only validates the staging subdomain but doesn't validate the main one even though both are on the same DNS server I suppose?

@lenovouser could you retry with the master branch version?

@ldez the nil error is gone. But the timeout is still there, and it seems to come from lego. Not LE.
2018/09/20 23:20:41 No key found for account<EMAIL_ADDRESS>Generating a curve P384 EC key.
2018/09/20 23:20:41 Saved key to /path/to/letsencrypt/data/accounts/acme-staging-v02.api.letsencrypt.org/letsencrypt<EMAIL_ADDRESS>2018/09/20 23:20:42 [INFO] acme: Registering account for<EMAIL_ADDRESS>2018/09/20 23:20:42 !!!! HEADS UP !!!!
2018/09/20 23:20:42
		Your account credentials have been saved in your Let's Encrypt
		configuration directory at<EMAIL_ADDRESS>		You should make a secure backup	of this folder now. This
		configuration directory will also contain certificates and
		private keys obtained from Let's Encrypt so making regular
		backups of this folder is ideal.
2018/09/20 23:20:42 [INFO] [domain.net, *.domain.net, *.staging.domain.net, domain.info, *.domain.info, *.staging.domain.info] acme: Obtaining bundled SAN certificate given a CSR
2018/09/20 23:20:43 [INFO] [*.domain.info] AuthURL: https://acme-staging-v02.api.letsencrypt.org/acme/authz/xxxx
2018/09/20 23:20:43 [INFO] [*.domain.net] AuthURL: https://acme-staging-v02.api.letsencrypt.org/acme/authz/xxxx
2018/09/20 23:20:43 [INFO] [*.staging.domain.info] AuthURL: https://acme-staging-v02.api.letsencrypt.org/acme/authz/xxxx
2018/09/20 23:20:43 [INFO] [*.staging.domain.net] AuthURL: https://acme-staging-v02.api.letsencrypt.org/acme/authz/xxxx
2018/09/20 23:20:43 [INFO] [domain.info] AuthURL: https://acme-staging-v02.api.letsencrypt.org/acme/authz/xxxx
2018/09/20 23:20:43 [INFO] [domain.net] AuthURL: https://acme-staging-v02.api.letsencrypt.org/acme/authz/xxxx
2018/09/20 23:20:43 [INFO] [domain.net] acme: Could not find solver for: http-01
2018/09/20 23:20:43 [INFO] [domain.info] acme: Preparing to solve DNS-01
2018/09/20 23:20:48 [INFO] [domain.net] acme: Preparing to solve DNS-01
2018/09/20 23:20:51 [INFO] [staging.domain.info] acme: Preparing to solve DNS-01
2018/09/20 23:20:55 [INFO] [staging.domain.net] acme: Preparing to solve DNS-01
2018/09/20 23:20:58 [INFO] [domain.info] acme: Preparing to solve DNS-01
2018/09/20 23:21:02 [INFO] [domain.net] acme: Preparing to solve DNS-01
2018/09/20 23:21:05 [INFO] [domain.info] acme: Trying to solve DNS-01
2018/09/20 23:21:05 [INFO] [domain.info] Checking DNS record propagation using [<IP_ADDRESS>:53 <IP_ADDRESS>:53 <IP_ADDRESS>:53 <IP_ADDRESS>:53]
2018/09/20 23:24:07 [INFO] [domain.net] acme: Trying to solve DNS-01
2018/09/20 23:24:07 [INFO] [domain.net] Checking DNS record propagation using [<IP_ADDRESS>:53 <IP_ADDRESS>:53 <IP_ADDRESS>:53 <IP_ADDRESS>:53]
2018/09/20 23:27:07 [INFO] [staging.domain.info] acme: Trying to solve DNS-01
2018/09/20 23:27:07 [INFO] [staging.domain.info] Checking DNS record propagation using [<IP_ADDRESS>:53 <IP_ADDRESS>:53 <IP_ADDRESS>:53 <IP_ADDRESS>:53]
2018/09/20 23:27:13 [INFO] [staging.domain.info] The server validated our request
2018/09/20 23:27:13 [INFO] [staging.domain.net] acme: Trying to solve DNS-01
2018/09/20 23:27:13 [INFO] [staging.domain.net] Checking DNS record propagation using [<IP_ADDRESS>:53 <IP_ADDRESS>:53 <IP_ADDRESS>:53 <IP_ADDRESS>:53]
2018/09/20 23:27:19 [INFO] [staging.domain.net] The server validated our request
2018/09/20 23:27:23 Could not obtain certificates
	acme: Error -> One or more domains had a problem:
[domain.info] Time limit exceeded. Last error: NS ns-cloud-c1.googledomains.com. did not return the expected TXT record
[domain.net] Time limit exceeded.  IN TXT

;; ANSWER SECTION:
_acme-challenge.domain.net. 180 IN TXT "JIUrft7njWuDFiG54x40AW6LTDK0_Vt77yEuWNTJy-Q"

;; Query time: 30 msec
;; SERVER: 2001:4860:4802:32::6c#53(2001:4860:4802:32::6c)
;; WHEN: Thu Sep 20 23:30:50 CEST 2018
;; MSG SIZE  rcvd: 121

weird. Same goes for the .info domain

also it validates the *.staging.domain.net and *.staging.domain.info requests just fine. Which are on the same DNS and part of the same request to LE.

Could this have something to do with #607?

I am going to try this with another project of ours. Also on Google DNS but on a different server.

for now, what I can determine from the logs is that the error happens during the precheck.
I will investigate.
could you try to build from those hash:

before 607: 6588bc6fa5b9d47abae1b6c40ef73e166f44fa95
607: de3accf531a7dd4eff65ae20e9787fc62045b674

same issue with another domain on another Google DNS server:
2018/09/20 23:48:00 [INFO] [test-two.com, *.test-two.com, *.staging.test-two.com] acme: Obtaining bundled SAN certificate given a CSR
2018/09/20 23:48:01 [INFO] [*.test-two.com] AuthURL: https://acme-staging-v02.api.letsencrypt.org/acme/authz/xxxx
2018/09/20 23:48:01 [INFO] [*.staging.test-two.com] AuthURL: https://acme-staging-v02.api.letsencrypt.org/acme/authz/xxxx
2018/09/20 23:48:01 [INFO] [test-two.com] AuthURL: https://acme-staging-v02.api.letsencrypt.org/acme/authz/xxxx
2018/09/20 23:48:01 [INFO] [test-two.com] acme: Could not find solver for: http-01
2018/09/20 23:48:01 [INFO] [test-two.com] acme: Preparing to solve DNS-01
2018/09/20 23:48:06 [INFO] [staging.test-two.com] acme: Preparing to solve DNS-01
2018/09/20 23:48:10 [INFO] [test-two.com] acme: Preparing to solve DNS-01
2018/09/20 23:48:14 [INFO] [test-two.com] acme: Trying to solve DNS-01
2018/09/20 23:48:14 [INFO] [test-two.com] Checking DNS record propagation using [<IP_ADDRESS>:53 <IP_ADDRESS>:53]
2018/09/20 23:51:15 [INFO] [staging.test-two.com] acme: Trying to solve DNS-01
2018/09/20 23:51:15 [INFO] [staging.test-two.com] Checking DNS record propagation using [<IP_ADDRESS>:53 <IP_ADDRESS>:53]
2018/09/20 23:51:20 [INFO] [staging.test-two.com] The server validated our request
2018/09/20 23:51:22 Could not obtain certificates
	acme: Error -> One or more domains had a problem:
[test-two.com] Time limit exceeded. Last error: NS ns-cloud-a1.googledomains.com. did not return the expected TXT record

@ldez will try with 6588bc6fa5b9d47abae1b6c40ef73e166f44fa95

@ldez works with 6588bc6fa5b9d47abae1b6c40ef73e166f44fa95
2018/09/21 00:00:12 No key found for account<EMAIL_ADDRESS>Generating a curve P384 EC key.
2018/09/21 00:00:12 Saved key to /path/to/letsencrypt/data/accounts/acme-staging-v02.api.letsencrypt.org/letsencrypt<EMAIL_ADDRESS>2018/09/21 00:00:13 [INFO] acme: Registering account for<EMAIL_ADDRESS>2018/09/21 00:00:13 !!!! HEADS UP !!!!
2018/09/21 00:00:13
		Your account credentials have been saved in your Let's Encrypt
		configuration directory at<EMAIL_ADDRESS>		You should make a secure backup	of this folder now. This
		configuration directory will also contain certificates and
		private keys obtained from Let's Encrypt so making regular
		backups of this folder is ideal.
2018/09/21 00:00:13 [INFO] [domain.com, *.domain.com, *.staging.domain.com] acme: Obtaining bundled SAN certificate given a CSR
2018/09/21 00:00:14 [INFO] [*.domain.com] AuthURL: https://acme-staging-v02.api.letsencrypt.org/acme/authz/xxxx
2018/09/21 00:00:14 [INFO] [*.staging.domain.com] AuthURL: https://acme-staging-v02.api.letsencrypt.org/acme/authz/xxxx
2018/09/21 00:00:14 [INFO] [domain.com] AuthURL: https://acme-staging-v02.api.letsencrypt.org/acme/authz/xxxx
2018/09/21 00:00:14 [INFO] [domain.com] acme: Trying to solve DNS-01
2018/09/21 00:00:17 [INFO] [domain.com] Checking DNS record propagation using [<IP_ADDRESS>:53 <IP_ADDRESS>:53]
2018/09/21 00:01:43 [INFO] [domain.com] The server validated our request
2018/09/21 00:01:44 [INFO] [staging.domain.com] acme: Trying to solve DNS-01
2018/09/21 00:01:47 [INFO] [staging.domain.com] Checking DNS record propagation using [<IP_ADDRESS>:53 <IP_ADDRESS>:53]
2018/09/21 00:02:38 [INFO] [staging.domain.com] The server validated our request
2018/09/21 00:02:41 [INFO] [domain.com] acme: Could not find solver for: tls-alpn-01
2018/09/21 00:02:41 [INFO] [domain.com] acme: Trying to solve DNS-01
2018/09/21 00:02:43 [INFO] [domain.com] Checking DNS record propagation using [<IP_ADDRESS>:53 <IP_ADDRESS>:53]
2018/09/21 00:04:04 [INFO] [domain.com] The server validated our request
2018/09/21 00:04:05 [INFO] [domain.com, *.domain.com, *.staging.domain.com] acme: Validations succeeded; requesting certificates
2018/09/21 00:04:06 [INFO] [domain.com] Server responded with a certificate.

Could you try with de3accf531a7dd4eff65ae20e9787fc62045b674?

@ldez will do

@lenovouser could you try with https://github.com/xenolf/lego/tree/fix/gcloud-wildcard?

@ldez that replaces the "Time limit exceeded" error with another error that represents the issue more correctly:
2018/09/21 12:32:36 No key found for account<EMAIL_ADDRESS>Generating a curve P384 EC key.
2018/09/21 12:32:36 Saved key to /path/to/letsencrypt/data/accounts/acme-staging-v02.api.letsencrypt.org/letsencrypt<EMAIL_ADDRESS>2018/09/21 12:32:37 [INFO] acme: Registering account for<EMAIL_ADDRESS>2018/09/21 12:32:37 !!!! HEADS UP !!!!
2018/09/21 12:32:37
		Your account credentials have been saved in your Let's Encrypt
		configuration directory at<EMAIL_ADDRESS>		You should make a secure backup	of this folder now. This
		configuration directory will also contain certificates and
		private keys obtained from Let's Encrypt so making regular
		backups of this folder is ideal.
2018/09/21 12:32:37 [INFO] [domain.com, *.domain.com, *.staging.domain.com] acme: Obtaining bundled SAN certificate given a CSR
2018/09/21 12:32:38 [INFO] [*.domain.com] AuthURL: https://acme-staging-v02.api.letsencrypt.org/acme/authz/xxxx
2018/09/21 12:32:38 [INFO] [*.staging.domain.com] AuthURL: https://acme-staging-v02.api.letsencrypt.org/acme/authz/xxxx
2018/09/21 12:32:38 [INFO] [domain.com] AuthURL: https://acme-staging-v02.api.letsencrypt.org/acme/authz/xxxx
2018/09/21 12:32:38 [INFO] [domain.com] acme: Could not find solver for: tls-alpn-01
2018/09/21 12:32:38 [INFO] [domain.com] acme: Could not find solver for: http-01
2018/09/21 12:32:38 [INFO] [domain.com] acme: Preparing to solve DNS-01
2018/09/21 12:32:42 [INFO] [staging.domain.com] acme: Preparing to solve DNS-01
2018/09/21 12:32:46 [INFO] [domain.com] acme: Preparing to solve DNS-01
2018/09/21 12:32:49 [INFO] [domain.com] acme: Trying to solve DNS-01
2018/09/21 12:32:49 [INFO] [domain.com] Checking DNS record propagation using [<IP_ADDRESS>:53 <IP_ADDRESS>:53]
2018/09/21 12:33:35 [INFO] [staging.domain.com] acme: Trying to solve DNS-01
2018/09/21 12:33:35 [INFO] [staging.domain.com] Checking DNS record propagation using [<IP_ADDRESS>:53 <IP_ADDRESS>:53]
2018/09/21 12:33:51 [INFO] [staging.domain.com] The server validated our request
2018/09/21 12:33:52 Could not obtain certificates
	acme: Error -> One or more domains had a problem:
[domain.com] acme: Error 403 - urn:ietf:params:acme:error:unauthorized - Incorrect TXT record "zJ4V1TqgApcaxL3GBXoE-5UMnGEssgittCRRfsfIAGM" found at _acme-challenge.domain.com

Could you retry with my new changes?

@ldez you mean the changes in your fork I suppose? Will do.

in this branch: https://github.com/xenolf/lego/tree/fix/gcloud-wildcard

@ldez you pushed into your own fork at https://github.com/ldez/lego/tree/fix/gcloud-wildcard
I pulled that and it seems to work 🎉
2018/09/21 14:48:20 No key found for account<EMAIL_ADDRESS>Generating a curve P384 EC key.
2018/09/21 14:48:20 Saved key to /path/to/letsencrypt/data/accounts/acme-staging-v02.api.letsencrypt.org/letsencrypt<EMAIL_ADDRESS>2018/09/21 14:48:21 [INFO] acme: Registering account for<EMAIL_ADDRESS>2018/09/21 14:48:21 !!!! HEADS UP !!!!
2018/09/21 14:48:21
		Your account credentials have been saved in your Let's Encrypt
		configuration directory at<EMAIL_ADDRESS>		You should make a secure backup	of this folder now. This
		configuration directory will also contain certificates and
		private keys obtained from Let's Encrypt so making regular
		backups of this folder is ideal.
2018/09/21 14:48:21 [INFO] [domain.com, *.domain.com, *.staging.domain.com] acme: Obtaining bundled SAN certificate given a CSR
2018/09/21 14:48:22 [INFO] [*.domain.com] AuthURL: https://acme-staging-v02.api.letsencrypt.org/acme/authz/DB-ItrJrmP4p9SYZu45cOrWBYWD2Jkk724vpNZvfmHk
2018/09/21 14:48:22 [INFO] [*.staging.domain.com] AuthURL: https://acme-staging-v02.api.letsencrypt.org/acme/authz/xgBBscjhPjhQec8t_pN-oocxN-nbmWMn8nNYUcoNZoI
2018/09/21 14:48:22 [INFO] [domain.com] AuthURL: https://acme-staging-v02.api.letsencrypt.org/acme/authz/V54Zk94i04uB_-3-Az3P7CSCcuv2wcu_siszjkCYS9w
2018/09/21 14:48:22 [INFO] [domain.com] acme: Preparing to solve DNS-01
2018/09/21 14:48:23 [INFO] domain: domain.com
2018/09/21 14:48:23 [INFO] new {"name":"_acme-challenge.domain.com.","rrdatas":["n8B4o96v_P7S5SxTAhk_X8gLEawRuzmP6q2VB9k7Cgo"],"ttl":120,"type":"TXT"}
2018/09/21 14:48:23 [INFO] existing {"kind":"dns#resourceRecordSet","name":"_acme-challenge.domain.com.","rrdatas":["\"GDkmHWLhF_4ESyUblKPUTI7wNi-Fco5ekOm3YBO5NTE\""],"ttl":120,"type":"TXT"}
{"additions":[{"kind":"dns#resourceRecordSet","name":"_acme-challenge.domain.com.","rrdatas":["\"n8B4o96v_P7S5SxTAhk_X8gLEawRuzmP6q2VB9k7Cgo\"","\"GDkmHWLhF_4ESyUblKPUTI7wNi-Fco5ekOm3YBO5NTE\""],"ttl":120,"type":"TXT"}],"deletions":[{"kind":"dns#resourceRecordSet","name":"_acme-challenge.domain.com.","rrdatas":["\"GDkmHWLhF_4ESyUblKPUTI7wNi-Fco5ekOm3YBO5NTE\""],"ttl":120,"type":"TXT"}],"id":"186","kind":"dns#change","startTime":"2018-09-21T12:48:23.781Z","status":"pending"}
2018/09/21 14:48:25 [INFO] [staging.domain.com] acme: Preparing to solve DNS-01
2018/09/21 14:48:26 [INFO] domain: staging.domain.com
2018/09/21 14:48:26 [INFO] new {"name":"_acme-challenge.staging.domain.com.","rrdatas":["6LFdjFm8iHW2ir_-rYt7gM1l-rc10zabDJCKtPeDAms"],"ttl":120,"type":"TXT"}
{"additions":[{"kind":"dns#resourceRecordSet","name":"_acme-challenge.staging.domain.com.","rrdatas":["\"6LFdjFm8iHW2ir_-rYt7gM1l-rc10zabDJCKtPeDAms\""],"ttl":120,"type":"TXT"}],"id":"187","kind":"dns#change","startTime":"2018-09-21T12:48:26.968Z","status":"pending"}
2018/09/21 14:48:28 [INFO] [domain.com] acme: Preparing to solve DNS-01
2018/09/21 14:48:29 [INFO] domain: domain.com
2018/09/21 14:48:29 [INFO] new {"name":"_acme-challenge.domain.com.","rrdatas":["ETGV8pYQ0r8ppx8V_tEzYEua1OAe0hT0gNRDAwJBz_c"],"ttl":120,"type":"TXT"}
2018/09/21 14:48:29 [INFO] existing {"kind":"dns#resourceRecordSet","name":"_acme-challenge.domain.com.","rrdatas":["\"n8B4o96v_P7S5SxTAhk_X8gLEawRuzmP6q2VB9k7Cgo\"","\"GDkmHWLhF_4ESyUblKPUTI7wNi-Fco5ekOm3YBO5NTE\""],"ttl":120,"type":"TXT"}
{"additions":[{"kind":"dns#resourceRecordSet","name":"_acme-challenge.domain.com.","rrdatas":["\"ETGV8pYQ0r8ppx8V_tEzYEua1OAe0hT0gNRDAwJBz_c\"","\"n8B4o96v_P7S5SxTAhk_X8gLEawRuzmP6q2VB9k7Cgo\"","\"GDkmHWLhF_4ESyUblKPUTI7wNi-Fco5ekOm3YBO5NTE\""],"ttl":120,"type":"TXT"}],"deletions":[{"kind":"dns#resourceRecordSet","name":"_acme-challenge.domain.com.","rrdatas":["\"n8B4o96v_P7S5SxTAhk_X8gLEawRuzmP6q2VB9k7Cgo\"","\"GDkmHWLhF_4ESyUblKPUTI7wNi-Fco5ekOm3YBO5NTE\""],"ttl":120,"type":"TXT"}],"id":"188","kind":"dns#change","startTime":"2018-09-21T12:48:29.909Z","status":"pending"}
2018/09/21 14:48:31 [INFO] [domain.com] acme: Trying to solve DNS-01
2018/09/21 14:48:31 [INFO] [domain.com] Checking DNS record propagation using [<IP_ADDRESS>:53 <IP_ADDRESS>:53 <IP_ADDRESS>:53 <IP_ADDRESS>:53]
2018/09/21 14:49:59 [INFO] [domain.com] The server validated our request
2018/09/21 14:49:59 [INFO] [staging.domain.com] acme: Trying to solve DNS-01
2018/09/21 14:49:59 [INFO] [staging.domain.com] Checking DNS record propagation using [<IP_ADDRESS>:53 <IP_ADDRESS>:53 <IP_ADDRESS>:53 <IP_ADDRESS>:53]
2018/09/21 14:50:04 [INFO] [staging.domain.com] The server validated our request
2018/09/21 14:50:04 [INFO] [domain.com] acme: Trying to solve DNS-01
2018/09/21 14:50:04 [INFO] [domain.com] Checking DNS record propagation using [<IP_ADDRESS>:53 <IP_ADDRESS>:53 <IP_ADDRESS>:53 <IP_ADDRESS>:53]
2018/09/21 14:50:10 [INFO] [domain.com] The server validated our request
2018/09/21 14:50:12 [WARN] Error cleaning up domain.com: googlecloud: <nil>
2018/09/21 14:50:14 [WARN] Error cleaning up staging.domain.com: googlecloud: <nil>
2018/09/21 14:50:14 [INFO] [domain.com, *.domain.com, *.staging.domain.com] acme: Validations succeeded; requesting certificates
2018/09/21 14:50:15 [INFO] [domain.com] Server responded with a certificate.

there cleanup error re-appeared though.

Could you pull and retry once again?

@ldez works fine!
2018/09/21 15:08:34 No key found for account<EMAIL_ADDRESS>Generating a curve P384 EC key.
2018/09/21 15:08:34 Saved key to /path/to/letsencrypt/data/accounts/acme-staging-v02.api.letsencrypt.org/letsencrypt<EMAIL_ADDRESS>2018/09/21 15:08:34 [INFO] acme: Registering account for<EMAIL_ADDRESS>2018/09/21 15:08:35 !!!! HEADS UP !!!!
2018/09/21 15:08:35
		Your account credentials have been saved in your Let's Encrypt
		configuration directory at<EMAIL_ADDRESS>		You should make a secure backup	of this folder now. This
		configuration directory will also contain certificates and
		private keys obtained from Let's Encrypt so making regular
		backups of this folder is ideal.
2018/09/21 15:08:35 [INFO] [domain.com, *.domain.com, *.staging.domain.com] acme: Obtaining bundled SAN certificate given a CSR
2018/09/21 15:08:36 [INFO] [*.domain.com] AuthURL: https://acme-staging-v02.api.letsencrypt.org/acme/authz/54gh57jPio-h5RzCDC5Arl_66s7jiBo_HjHkybhiezA
2018/09/21 15:08:36 [INFO] [*.staging.domain.com] AuthURL: https://acme-staging-v02.api.letsencrypt.org/acme/authz/QfdbRbql999l83q8yhPouhuG9oSsJ2gMqHaT83pHmN0
2018/09/21 15:08:36 [INFO] [domain.com] AuthURL: https://acme-staging-v02.api.letsencrypt.org/acme/authz/aBe5130BdKwIzPcxfYOFmqd5kOSw1iXaCA0rnh8gTMo
2018/09/21 15:08:36 [INFO] [domain.com] acme: Could not find solver for: tls-alpn-01
2018/09/21 15:08:36 [INFO] [domain.com] acme: Could not find solver for: http-01
2018/09/21 15:08:36 [INFO] [domain.com] acme: Preparing to solve DNS-01
2018/09/21 15:08:37 [INFO] domain: domain.com
2018/09/21 15:08:37 [INFO] new {"name":"_acme-challenge.domain.com.","rrdatas":["rE6u6DUHjWHAJGCj1oFN5yew2XC6GzgmbOSnQZ3xXlk"],"ttl":120,"type":"TXT"}
{"additions":[{"kind":"dns#resourceRecordSet","name":"_acme-challenge.domain.com.","rrdatas":["\"rE6u6DUHjWHAJGCj1oFN5yew2XC6GzgmbOSnQZ3xXlk\""],"ttl":120,"type":"TXT"}],"id":"191","kind":"dns#change","startTime":"2018-09-21T13:08:38.050Z","status":"pending"}
2018/09/21 15:08:39 [INFO] [domain.com] acme: Preparing to solve DNS-01
2018/09/21 15:08:40 [INFO] domain: domain.com
2018/09/21 15:08:40 [INFO] new {"name":"_acme-challenge.domain.com.","rrdatas":["zoKxiIv-Wq8c7JnrE8AhcAvWTvEJyyJnqX6MC0seQGs"],"ttl":120,"type":"TXT"}
2018/09/21 15:08:40 [INFO] existing {"kind":"dns#resourceRecordSet","name":"_acme-challenge.domain.com.","rrdatas":["\"rE6u6DUHjWHAJGCj1oFN5yew2XC6GzgmbOSnQZ3xXlk\""],"ttl":120,"type":"TXT"}
{"additions":[{"kind":"dns#resourceRecordSet","name":"_acme-challenge.domain.com.","rrdatas":["\"zoKxiIv-Wq8c7JnrE8AhcAvWTvEJyyJnqX6MC0seQGs\"","\"rE6u6DUHjWHAJGCj1oFN5yew2XC6GzgmbOSnQZ3xXlk\""],"ttl":120,"type":"TXT"}],"deletions":[{"kind":"dns#resourceRecordSet","name":"_acme-challenge.domain.com.","rrdatas":["\"rE6u6DUHjWHAJGCj1oFN5yew2XC6GzgmbOSnQZ3xXlk\""],"ttl":120,"type":"TXT"}],"id":"192","kind":"dns#change","startTime":"2018-09-21T13:08:40.334Z","status":"pending"}
2018/09/21 15:08:42 [INFO] [staging.domain.com] acme: Preparing to solve DNS-01
2018/09/21 15:08:43 [INFO] domain: staging.domain.com
2018/09/21 15:08:43 [INFO] new {"name":"_acme-challenge.staging.domain.com.","rrdatas":["YFzLGzRzLKTEHikXrXMQ_7jq1YnsI_wgOvDAWzU5hAo"],"ttl":120,"type":"TXT"}
{"additions":[{"kind":"dns#resourceRecordSet","name":"_acme-challenge.staging.domain.com.","rrdatas":["\"YFzLGzRzLKTEHikXrXMQ_7jq1YnsI_wgOvDAWzU5hAo\""],"ttl":120,"type":"TXT"}],"id":"193","kind":"dns#change","startTime":"2018-09-21T13:08:43.802Z","status":"pending"}
2018/09/21 15:08:45 [INFO] [domain.com] acme: Trying to solve DNS-01
2018/09/21 15:08:45 [INFO] [domain.com] Checking DNS record propagation using [<IP_ADDRESS>:53 <IP_ADDRESS>:53 <IP_ADDRESS>:53 <IP_ADDRESS>:53]
2018/09/21 15:10:02 [INFO] [domain.com] The server validated our request
2018/09/21 15:10:02 [INFO] [domain.com] acme: Trying to solve DNS-01
2018/09/21 15:10:02 [INFO] [domain.com] Checking DNS record propagation using [<IP_ADDRESS>:53 <IP_ADDRESS>:53 <IP_ADDRESS>:53 <IP_ADDRESS>:53]
2018/09/21 15:10:07 [INFO] [domain.com] The server validated our request
2018/09/21 15:10:07 [INFO] [staging.domain.com] acme: Trying to solve DNS-01
2018/09/21 15:10:07 [INFO] [staging.domain.com] Checking DNS record propagation using [<IP_ADDRESS>:53 <IP_ADDRESS>:53 <IP_ADDRESS>:53 <IP_ADDRESS>:53]
2018/09/21 15:10:13 [INFO] [staging.domain.com] The server validated our request
2018/09/21 15:10:16 [INFO] [domain.com, *.domain.com, *.staging.domain.com] acme: Validations succeeded; requesting certificates
2018/09/21 15:10:17 [INFO] [domain.com] Server responded with a certificate.

Thanks for help! :tada:

No problem and thank you very much @ldez ❤!
We might want to check if this is an issue with other DNS providers too. Not too sure, but it should be since the records there are also the same and will also be submitted serially?

Not too sure, but it should be since the records there are also the same and will also be submitted serially?

Cloudflare might be in this boat.

Possibly DNSimple, too:
Server returned error NXDOMAIN, mitigating potential DNS violation DVE-2018-0001, retrying transaction with reduced feature level UDP.

Works when I build lego before commit de3accf531a7dd4eff65ae20e9787fc62045b674.

Yeah I suspect a lot - if not all DNS providers - should be affected by this. I think I also just discovered another bug related / belonging to this that still persists in the current version last night. Will post details later today or tomorrow.

@lenovouser Great, thanks for looking into it. I hadn't been keeping up with the latest changes. See my detailed report at issue #649 -- if it helps at all.

All providers are not affected, I did some testing with some providers before merging this PR.

@ldez ah okay. Awesome


Updating SQL TDE BYOK tests to account for new requirement that the k…

…ey vault must be enabled for soft delete

This checklist is used to make sure that common guidelines for a pull request are followed.

[x] The PR has modified HISTORY.rst describing any customer-facing, functional changes. Note that this does not include changes only to help content. (see Modifying change log).

[x] I adhere to the Command Guidelines.

View a preview at https://prompt.ws/r/Azure/azure-cli/6160
This is an experimental preview for @microsoft users.

Please rebase with the latest on dev branch. There was a fix just merged to fix a Travis CI change.

I'll close this PR and open a new one. This PR was trying to merge from my master branch to Azure master, but I see now that the dev branch is the branch for active development. To keep things tidy I'll submit a new PR from dev to dev branch.


actions: Upload test results to opensearch service

On push, upload test results to opensearch for analysis and reporting.
Goal is to use this data to understand test coverage better and use this
services for all test reporting, also for results coming from testing on
hardware.
Opensearch is currenly being used for evaluation, we are considering
the switch to elasticsearch later.
Signed-off-by: Anas Nashif<EMAIL_ADDRESS>

Will the community (eventually) have access to the uploaded, searchable data?

Will the community (eventually) have access to the uploaded, searchable data?

Eventually, yes. The idea is to use OpenSearch + Dashboard (or ElasticSearch + Kibana for that matter) like a test management system.

Will the community (eventually) have access to the uploaded, searchable data?

thats the idea.

@henrikbrixandersen a sneak preview:


fix: two folders are created when the project name contains spaces

Description
When select customize with create-vue, If the project name contains a space, two folders will be created, and then the template content will be filled into the folder named with the character before the first space.

Additional context

What is the purpose of this pull request?

[ ] Bug fix
[ ] New Feature
[ ] Documentation update
[ ] Other

Before submitting the PR, please make sure you do the following

[ ] Read the Contributing Guidelines.
[ ] Read the Pull Request Guidelines and follow the PR Title Convention.
[ ] Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
[ ] Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).
[ ] Ideally, include relevant tests that fail without this PR but pass with it.

@sapphi-red Please review this pr.


add OCM prefix for clusterrole and clusterrolebinding

Signed-off-by: myan<EMAIL_ADDRESS>Referrence: https://github.com/stolostron/backlog/issues/26271

/retest

Also I think you missed role and rolebinding for agent in hosted mode.

Maybe we just need to add the open-cluster-management to the clusterrole and clusterrolebinding.  Cause role and rolbinding is namespaced. We don't need a prefix to indicate where it's from.
Am I right? @clyang82 @morvencao

@yanmxa I think we don't add prefix to the role/clusterrole/rolebing/clusterrolebinding to the operator, because they will be installed with OLM, the csv will help to generate the names. We should focus on role/clusterrole/rolebing/clusterrolebinding for manager and agent? right? @clyang82

Agree!

OK @yanmxa make sense to me! thanks.


Weird behavior of NativeEnvironment which causes duplicated elements in Jinja 2.10.x

Expected Behavior
>>> print(NativeEnvironment().from_string('{{ "tr" }} ue').render())
tr ue

Actual Behavior
In Jinja2 2.10.1 (the version used by kubespray) and 2.10.3 (the latest version of 2.10.x)
>>> print(NativeEnvironment().from_string('{{ "tr" }} ue').render())
tr uetr ue

Nevertheless, everything works as expected in Jinja2 2.11.1 (the latest major version).
Template Code
Python 3.7.3 (default, Dec 13 2019, 19:58:14)
[Clang 11.0.0 (clang-1<IP_ADDRESS>)] on darwin
Type "help", "copyright", "credits" or "license" for more information.
>>> import jinja2
>>> from jinja2.nativetypes import NativeEnvironment
>>>
>>> print(jinja2.__version__)
2.10.3

env = NativeEnvironment()
print(env.from_string('{{ "tr" }} ue').render()) >>>
>>> env = NativeEnvironment()
>>> print(env.from_string('{{ "tr" }} ue').render())
tr uetr ue
>>>

Full Traceback
None
Your Environment

Python version: 3.7.3
Jinja version: 2.10.3

If you use git bisect you can find the first commit that fixed this issue. If you want to backport the relevant PR to the 2.10.x branch, I'm happy to review and release a fix.


Migrate documentation for aggregate functions from aggregate_functions.md to code

Is your feature request related to a problem or challenge?
As part of https://github.com/apache/datafusion/issues/12740 this ticket is to migrate all the existing documentation for aggregate functions from the static file to code and to remove them from the static file.
Here is the current static content:

doc source: https://github.com/apache/datafusion/blob/main/docs/source/user-guide/sql/aggregate_functions.md
rendered: https://datafusion.apache.org/user-guide/sql/aggregate_functions.html
Code source: https://github.com/apache/datafusion/tree/main/datafusion/functions-aggregate/src

Need Functions:

[ ] Port / Add Documentation for ApproxDistinct
[ ] Port / Add Documentation for ApproxMedian
[ ] Port / Add Documentation for ApproxPercentileCont
[ ] Port / Add Documentation for ApproxPercentileContWithWeight
[ ] Port / Add Documentation for ArrayAgg
[ ] Port / Add Documentation for Avg
[ ] Port / Add Documentation for BoolAnd
[ ] Port / Add Documentation for BoolOr
[ ] Port / Add Documentation for Correlation
[ ] Port / Add Documentation for Count
[ ] Port / Add Documentation for CovarianceSample
[ ] Port / Add Documentation for CovariancePopulation
[ ] Port / Add Documentation for FirstValue
[ ] Port / Add Documentation for LastValue
[ ] Port / Add Documentation for Grouping
[ ] Port / Add Documentation for Median
[ ] Port / Add Documentation for Max
[ ] Port / Add Documentation for Min
[ ] Port / Add Documentation for NthValueAgg
[ ] Port / Add Documentation for Regr
[ ] Port / Add Documentation for Stddev
[ ] Port / Add Documentation for StddevPop
[ ] Port / Add Documentation for StringAgg
[ ] Port / Add Documentation for Sum

Describe the solution you'd like
One (or more) PRs that

port the documentation for the above named functions from the static docs to code
Bonus points:  add sql examples should be added for all functions
Remove the documentation from the static docs

Here are some example PRs of doing this:

https://github.com/apache/datafusion/pull/12775 from @Omega359
https://github.com/apache/datafusion/pull/12742

Describe alternatives you've considered
No response
Additional context
No response

take

Will work on this after @Omega359 approves of my first pr!


Status check failure during bootstrap doesn't exit non-zero

I think that a "failure" of the status-check step should exit non-zero. Currently, something like this is logged:
16:52:12.084409 status-check status-check unhealthy services detected!

The following services are reporting unhealthy, this likely indicates a problem with your deployment:
    router

/cc @josephglanville

Flynn is unmaintained and our infrastructure will shut down on June 1, 2021. See the README for details.


feat: Pokemon showdown Replay video URL

https://replay.pokemonshowdown.com/ + season + id
example: https://replay.pokemonshowdown.com/gen9vgc2023regulationc-1844873752

Web API: https://github.com/smogon/pokemon-showdown-client/blob/master/WEB-API.md

Added feature at https://github.com/louis70109/find-your-pokemon/commit/8c4222ccf357870af54a7f7b10d5e27bc808f347

But need flex message to build content


[WIP] Fix indentation of legacy HTML templates

#1236

Automated message from Dropbox CLA bot
@jajodiaraghav, it looks like you've already signed the Dropbox CLA. Thanks!

@jajodiaraghav
Zulip has a 4 space indent standard.
I have been working on cleaning up these.

@adnrs96 Thanks for notifying this. So all i have to do is convert my 2-space indent to 4-space indent, right?
Will update the changes.

@timabbott Is it fine to fix the indentation for other files in the similar way?

Well, privacy.html in particular is the old privacy policy for zulip.com, and I'd probably rather delete and/or replace with a markdown system.  I think @HarshitOnGitHub is managing the process of fixing these while avoiding merge conflicts with open PRs.

@HarshitOnGitHub Should i stash these changes and/or work on other files given in check-template file?

@jajodiaraghav I think there is some confusion here. @adnrs96 is managing the work of cleaning up templates and he will be the right person to ask.

@jajodiaraghav  We might want to be careful here in cleaning up these files, since we might cause merge conflicts to other PR's which would be undesirable. This work is underway in this PR in small rounds.
@timabbott what do you think, would be the appropriate way forward.

Oops yeah sorry for the confusing mention; I must have been tired yesterday :/.
Yeah I think maybe @adnrs96 should drive further work on cleaning this list since he has a tool that does it so it's pretty fast.  For this PR, I need to figure out what to do with this template.

For this particular PR, I think this legacy privacy template is no longer used and we should probably be deleting it instead.  I can take care of doing that shortly.


filteration of vendor prefixes.

We all support the cross-browser consistency. I am happy that "animate.css" is supporting the same.
But simple thing is, we are 3D transforms in the project. As of the support, 3D transforms are supported in
IE10+
Firefox
Chrome
Safari(IOS)
Here only Safari is needed the prefix & some times Chrome & firefox.
But for IE10+, we don't need any vendor prefixes. IE started supporting 3D transforms from IE10 & dropped vendor prefixes for the same.
IE prefixes are needed  for IE9 & (-).
I think we can remove un-needed vendor prefixes from the code.

Autoprefixer is included in the Gruntfile and removes all unnecessary prefixes for us automatically. Those left in the code are required for support for the last 2 versions of browsers.

Actually @daneden, the Autoprefixer task is configured to the 3 last versions of the browsers, and this end up including IE9 and its prefixes. A simple change to the 2 last versions would exclude the -ms- prefixes.
Mind if I PR it?

@eltonmesquita nice catch. Go ahead!

Thanks for considering my point.
Thanks @eltonmesquita , @danedan