Run coverage on develop branch

Motivation
Coverage must be run on the develop branch in order for codecov.io to have a "base coverage" to compare coverage on other branches to.
Changes

moved coverage job to a separate workflow
run coverage workflow on PRs, manual trigger and develop branch
don't run coverage with bors

Codecov Report

Merging #4170 (e182d6f) into develop (e9ab686) will increase coverage by 0.0%.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           develop   #4170   +/-   ##
=======================================
  Coverage     71.1%   71.1%
=======================================
  Files          193     193
  Lines        22960   22960
=======================================
+ Hits         16339   16341    +2
+ Misses        5538    5537    -1
+ Partials      1083    1082    -1

see 3 files with indirect coverage changes
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Bors merge


feat(expo): add update executor

I basically just copied the work of https://github.com/nrwl/nx-labs/pull/84 and replaced build with update. Would be awesome to have this!

thanks for submitting this pr. it looks pretty good. i just left some comments.

also, one more thiing, could you update the migration version to be 14.5.1?


Allowing Dual Stack Peers (IPv4 and IPv6)

Is there a way to allow for a single peer to use both IPv4 and IPv6 so that other clients don't get alienated and can always find peers?
I've created two separate subdomains tracker.**** and tracker6.****, the first only has a A DNS entry, while the last one only has an AAAA entry, to see if splitting the DNS query would lead to it accepting the broadcast on both IPv4 and IPv6.
Accessing the API made me find only my IPv6 address, which means I wouldn't be able to seed to users with only IPv4 support, even though I added both tracker subdomains in the torrent.

Is there a way to allow for a single peer to use both IPv4 and IPv6 so that other clients don't get alienated and can always find peers?
I've created two separate subdomains tracker.**** and tracker6.****, the first only has a A DNS entry, while the last one only has an AAAA entry, to see if splitting the DNS query would lead to it accepting the broadcast on both IPv4 and IPv6.
Accessing the API made me find only my IPv6 address, which means I wouldn't be able to seed to users with only IPv4 support, even though I added both tracker subdomains in the torrent.

This is an client thing, not a tracker thing.
As far as I'm aware, you need to make it so that the tracker announcements are "separate", and not in a fallback group.

Is there a way to allow for a single peer to use both IPv4 and IPv6 so that other clients don't get alienated and can always find peers?
I've created two separate subdomains tracker.**** and tracker6.****, the first only has a A DNS entry, while the last one only has an AAAA entry, to see if splitting the DNS query would lead to it accepting the broadcast on both IPv4 and IPv6.
Accessing the API made me find only my IPv6 address, which means I wouldn't be able to seed to users with only IPv4 support, even though I added both tracker subdomains in the torrent.

As an update on what I posted, IPv4/IPv6 dualstack doesn't work on UDP, possibly only on HTTP, but it's not ISO (has no BEP), so it won't be implemented. IPv4 and IPv6 aren't inter-exchangeable.


Indent/Outdent breaks page in IE

Using the indent or outdent buttons will 'break' the widget in IE 11.
I am using the BootstrapRTE on a simple page (no other widgets / inputs) in an otherwise empty project.
A little debugging leads to the document.execCommand call causing the problem.
When triggering that function directly through the console, the problem occurs as well.
Any idea what could cause this?
Regards,
Jeroen Huizer

Additional finding, after adjusting the widget to insert the _inputfield node in the DOM outside the parentNode (while keeping the toolbar inside) everything works fine.
When wrapping that inside another widget (groupbox specifically), the problem occurs again.

Version 3.2.0 should fix this (also available in the AppStore). Could you test this version and send feedback?

Version 3.2.0 solved the problem. Thanks!

Great to hear, thanks for the feedback!


updated proto dependency in pom to suit usage in restricted network

Description
Currently the protoc implementation does not work in a restricted environment. This change helps application execution in such environments

Addressed Issue
Currently the protoc implementation does not work in a restricted environment. This change helps application execution in such environments

Additional Details

Checklist

[ ] I have read and understand the contributing guidelines
[x ] This PR fixes a defect, and I have provided tests to verify that the fix is effective
[ ] This PR implements an enhancement, and I have provided tests to verify that it works as intended
[ ] This PR introduces changes to the database model, and I have added corresponding update logic
[ ] This PR introduces new or alters existing behavior, and I have updated the documentation accordingly

closing pull request as accidentally pushed different set of changes here. Will re create a different one


SQL 2017 AG DNN Update

Update to text as AG DNN functionality released for SQL Server 2017 as part of CU25. See KB5004767 - Improvement: Availability Group DNN listener in SQL Server 2017

@PhilB-MSFT : Thanks for your contribution! The author(s) have been notified to review your proposed change.

Thanks @PhilB-MSFT , this was processed via an internal PR and should be live next week.
Thanks!
Masha from the SQL Docs team
#please-close


Support cutting a release for just the Helm chart

Need to add support for being able to cut releases for just the Helm chart to avoid having to cut a new version of wins every time we need to update the chart only.

closing this as wins-upgrader chart has been deprecated


NCIO bug on Hercules

Describe the bug
When creating a dataset via spack-stack/1.5.1 NCIO, a netCDF/HDF error is generated.  However, when the NCIO library is installed standalone on Hercules, there is no issue.
To Reproduce
I will build a sample test case and update this section.  For now, you can see the failed, spack-stack log file here: /work/noaa/global/dhuber/para/com/cycled_herc/logs/2021110900/gdasanalcalc.spack-stack.log and the successful log file (built with a standalone version of NCIO, using spack-stack netcdf-c and netcdf-fortran libraries and the same Intel compilers) here: /work/noaa/global/dhuber/para/com/cycled_herc/logs/2021110900/gdasanalcalc.standalone.log.
The failure occurs on the call of calc_anl.x at line 208 of gsi_utils/netcdf_io/calc_analysis/init_io.f90.
The standalone build of NCIO is available in /work/noaa/global/dhuber/LIBS/NCIO/ncio_112/install and the source code is in /work/noaa/global/dhuber/nceplibs-ncio.   --DCMAKE_INSTALL_PREFIX=/work/noaa/global/dhuber/LIBS/NCIO/ncio_112/install
make -j 2
make install

Expected behavior
The NCIO library would be able to create a dataset.
System:
What system(s) are you running the code on?
Hercules
Additional context
Found while cycle-testing the global workflow on Hercules (NOAA-EMC/global-workflow#1588).

I have built a test case here: /work/noaa/global/dhuber/LIBS/NCIO/analcalc_test_case/calcanl_ensres_06.  In doing so, I found that this is an intermittent issue, so the standalone version of NCIO probably doesn't actually fix this, it just got lucky.  I will investigate this further.

I have built a test case here: /work/noaa/global/dhuber/LIBS/NCIO/analcalc_test_case/calcanl_ensres_06. In doing so, I found that this is an intermittent issue, so the standalone version of NCIO probably doesn't actually fix this, it just got lucky. I will investigate this further.

This sounds a lot like the intermittent netCDF problems that the ufs-weather-model folks have seen and are trying to figure out.

We ran into netcdf issues when running on Lustre. Can you test under non-LFS space, e.g., $HOME? If so then yeah same issue.

Sure enough, it works on $HOME.  I'll go ahead and close this and follow the netCDF problem the ufs is working on.  Thanks!


Onboard new inter-branch merge flow [Configuration]

Context
Onboarding new merge flow based on the github actions
Changes Made
Added configuration file. The flow was copied from: https://github.com/dotnet/versions/blob/main/Maestro/subscriptions.json. Currently it will not be read or change any behaviour of the merge flow but will be used by the new workflow.
References
Documentation https://github.com/dotnet/arcade/blob/main/Documentation/Maestro/New-Inter-Branch-Merge-Approach.md
One pager: https://github.com/dotnet/dnceng/blob/main/Documentation/OnePagers/github-action-inter-branch-merge.md

@joperezr Could you please check this PR/ is this something that you would like to take into the dotnet/extensions-samples?

@f-alizada could you help us understand how we could check this PR? Is this ready for review? How do we know it is working?
Thank you

Same here, I don't think we need the release/8.0 -> main any longer, but we want to keep the other one.

@joperezr Thank you! The pr is updated and the #422 is targeting main branch now :)
@RussKie Thank you for questions! I have addressed them in: https://github.com/dotnet/extensions/pull/5239#issuecomment-2196562975
Please let me know if that helps


Failed to handle request: analysis.setAnalysisRoots

Analyzer Feedback from IntelliJ
Version information

IDEA WS-192.6817.13
2.6.0-dev.6.0
WS-192.6817.13, JRE 11.0.4+10-b304.69x64 JetBrains s.r.o, OS Mac OS X(x86_64) v10.14.6, screens 2560x1440, 2560x1440

Exception
Dart analysis server, SDK version 2.6.0-dev.6.0, server version 1.27.3, FATAL error: Failed to handle request: {id: 5, method: analysis.setAnalysisRoots, params: {included: [/Users/filiph/dev/flutter-website], excluded: [/Users/filiph/dev/flutter-website/.idea, /Users/filiph/dev/flutter-website/.pub, /Users/filiph/dev/flutter-website/.tmp, /Users/filiph/dev/flutter-website/build, /Users/filiph/dev/flutter-website/example.g/.pub, /Users/filiph/dev/flutter-website/example.g/build, /Users/filiph/dev/flutter-website/example/.pub, /Users/filiph/dev/flutter-website/example/build, /Users/filiph/dev/flutter-website/examples/_animation/basic_hero_animation/.pub, /Users/filiph/dev/flutter-website/examples/_animation/basic_hero_animation/build, /Users/filiph/dev/flutter-website/examples/_animation/basic_radial_hero_animation/.pub, /Users/filiph/dev/flutter-website/examples/_animation/basic_radial_hero_animation/build, /Users/filiph/dev/flutter-website/examples/_animation/basic_staggered_animation/.pub, /Users/filiph/dev/flutter-website/examples/_animation/basic_staggered_animation/build, /Users/filiph/dev/flutter-website/examples/_animation/hero_animation/.pub, /Users/filiph/dev/flutter-website/examples/_animation/hero_animation/build, /Users/filiph/dev/flutter-website/examples/_animation/radial_hero_animation/.pub, /Users/filiph/dev/flutter-website/examples/_animation/radial_hero_animation/build, /Users/filiph/dev/flutter-website/examples/_animation/radial_hero_animation_animate_rectclip/.pub, /Users/filiph/dev/flutter-website/examples/_animation/radial_hero_animation_animate_rectclip/build, /Users/filiph/dev/flutter-website/examples/_animation/staggered_pic_selection/.pub, /Users/filiph/dev/flutter-website/examples/_animation/staggered_pic_selection/build, /Users/filiph/dev/flutter-website/examples/animation/animate0/.pub, /Users/filiph/dev/flutter-website/examples/animation/animate0/build, /Users/filiph/dev/flutter-website/examples/animation/animate1/.pub, /Users/filiph/dev/flutter-website/examples/animation/animate1/build, /Users/filiph/dev/flutter-website/examples/animation/animate2/.pub, /Users/filiph/dev/flutter-website/examples/animation/animate2/build, /Users/filiph/dev/flutter-website/examples/animation/animate3/.pub, /Users/filiph/dev/flutter-website/examples/animation/animate3/build, /Users/filiph/dev/flutter-website/examples/animation/animate4/.pub, /Users/filiph/dev/flutter-website/examples/animation/animate4/build, /Users/filiph/dev/flutter-website/examples/animation/animate5/.pub, /Users/filiph/dev/flutter-website/examples/animation/animate5/build, /Users/filiph/dev/flutter-website/examples/codelabs/add_flutter_to_android_app/flutter/.pub, /Users/filiph/dev/flutter-website/examples/codelabs/add_flutter_to_android_app/flutter/build, /Users/filiph/dev/flutter-website/examples/codelabs/startup_namer/step1_base/.pub, /Users/filiph/dev/flutter-website/examples/codelabs/startup_namer/step1_base/build, /Users/filiph/dev/flutter-website/examples/codelabs/startup_namer/step2_use_package/.pub, /Users/filiph/dev/flutter-website/examples/codelabs/startup_namer/step2_use_package/build, /Users/filiph/dev/flutter-website/examples/codelabs/startup_namer/step3_stateful_widget/.pub, /Users/filiph/dev/flutter-website/examples/codelabs/startup_namer/step3_stateful_widget/build, /Users/filiph/dev/flutter-website/examples/codelabs/startup_namer/step4_infinite_list/.pub, /Users/filiph/dev/flutter-website/examples/codelabs/startup_namer/step4_infinite_list/build, /Users/filiph/dev/flutter-website/examples/codelabs/startup_namer/step5_add_icons/.pub, /Users/filiph/dev/flutter-website/examples/codelabs/startup_namer/step5_add_icons/build, /Users/filiph/dev/flutter-website/examples/codelabs/startup_namer/step6_add_interactivity/.pub, /Users/filiph/dev/flutter-website/examples/codelabs/startup_namer/step6_add_interactivity/build, /Users/filiph/dev/flutter-website/examples/codelabs/startup_namer/step7_navigate_route/.pub, /Users/filiph/dev/flutter-website/examples/codelabs/startup_namer/step7_navigate_route/build, /Users/filiph/dev/flutter-website/examples/codelabs/startup_namer/step8_themes/.pub, /Users/filiph/dev/flutter-website/examples/codelabs/startup_namer/step8_themes/build, /Users/filiph/dev/flutter-website/examples/internationalization/add_language/.pub, /Users/filiph/dev/flutter-website/examples/internationalization/add_language/build, /Users/filiph/dev/flutter-website/examples/internationalization/intl_example/.pub, /Users/filiph/dev/flutter-website/examples/internationalization/intl_example/build, /Users/filiph/dev/flutter-website/examples/internationalization/minimal/.pub, /Users/filiph/dev/flutter-website/examples/internationalization/minimal/build, /Users/filiph/dev/flutter-website/examples/layout/base/.pub, /Users/filiph/dev/flutter-website/examples/layout/base/build, /Users/filiph/dev/flutter-website/examples/layout/card_and_stack/.pub, /Users/filiph/dev/flutter-website/examples/layout/card_and_stack/build, /Users/filiph/dev/flutter-website/examples/layout/container/.pub, /Users/filiph/dev/flutter-website/examples/layout/contai...

For additional log information, please append the contents of
file:///private/var/folders/np/gmysjh1j2159hv7wssjzrw440028jd/T/report.txt.


Make Trino Client in Bagel Connectable to DBeaver

Hi,
It is useful to be able to connect to the Trino instance in the Everything Bagel with a Database UI like Dbeaver. The only way I've found to be able to do this (as done in the EB Part II blog) is to comment out the trino-client service and expose port 8080 on the trino service like so:
trino:
    image: trinodb/trino:358
    container_name: trino
    volumes:
      - ./etc/s3.properties:/etc/trino/catalog/s3.properties
    ports:
      - 8080:8080

  # trino-client:
  #   image: trinodb/trino:358
  #   profiles: ["client"]
  #   entrypoint: ["trino", "--server", "trino:8080", "--catalog", "s3", "--schema", "default"]

Is there a way to enable this functionality within the trino-client service? I tried a few things like exposing port 8080 on the trino-client service and changing the port exposing on the trino service to be 8080:8080 instead of 8080:48080 but queries run in dbeaver when connected to <IP_ADDRESS>:8080 or <IP_ADDRESS>:48080 still did not work.
Thoughts?

@peacing there are two options:

map Trino port to your local machine and connect Dbeaver using the port you mapped. (exactly like you did)
Add another container for Dbeaver and you will have access to the Trino machine in the docker-compose (using tino:8080)

According to 8080:48080, it's a bug and should be 48080:48080 fixed in #2818

@guy-har What does the change from 8080:48080 to 48080:8080 do? We still need to make another change to connect via dbeaver, yes?

@peacing, the change is a bug fix. you could now connect to Trino via localhost:48080.  We still have the two options mentioned above in order to connect to trino.

Connect dbeaver from the machine running docker-compose using the address localhost:48080
Add dbeaver to docker compose and use the address trino:8080

If we would like to work with the second option, you should:

edit the docker-compose.yaml file by adding

  dbeaver:
    image: dbeaver/cloudbeaver
    profiles: ["client"]
    ports:
      - "8978:8978"

run docker-compose up -d
run docker-compose up -d dbeaver
browse to http://localhost:8978/
in database connections -> Add Database -> custom , choose trino
use trino as host, and choose any User Name ( do not user password, it is not supported)

@peacing do you think this should be added to our bagel?

@guy-har gotcha. Confirming localhost:48080 does work for me. Thank you!
Running dbeaver in a container is clever, i don't think it is necessary. Especially if drivers for different db's have to be re-downloaded each time when in a container. Haven't tested that though


k8s v1.28.2 and NFD updates

@uniemimu PTAL 5cca930

$ kubectl get node -o json | jq .metadata.labels | grep gpu.intel.com
  "gpu.intel.com/cards": "card0",
  "gpu.intel.com/device-id.0300-9a49.count": "1",
  "gpu.intel.com/device-id.0300-9a49.present": "true",
  "gpu.intel.com/gpu-numbers": "0",
  "gpu.intel.com/memory.max": "0",
  "gpu.intel.com/millicores": "1000",
  "gpu.intel.com/tiles": "1",
$ kubectl get node -o json | jq .status.allocatable
{
  "cpu": "8",
  "ephemeral-storage": "450548187210",
  "gpu.intel.com/i915": "8",
  "gpu.intel.com/i915_monitoring": "1",
  "gpu.intel.com/memory.max": "0",
  "gpu.intel.com/millicores": "1000",
  "gpu.intel.com/tiles": "1",
  "hugepages-1Gi": "0",
  "hugepages-2Mi": "0",
  "memory": "32474604Ki",
  "pods": "110"
}

I recall the extended resources vanished from the node labels previously. Now they seem to stay in labels. I wonder if it's by design?

As an occasional project contributor... I think it would be good to add some note about how NFD is intended to be used to DEVEL.md.

As an occasional project contributor... I think it would be good to add some note about how NFD is intended to be used to DEVEL.md.

@eero-t GPU plugin documentation talks about it and we also have similar steps documented as part of the operator deployment.

Codecov Report

Merging #1539 (41c3d74) into main (ba3ded1) will decrease coverage by 0.11%.
Report is 8 commits behind head on main.
The diff coverage is 14.28%.

:exclamation: Current head 41c3d74 differs from pull request most recent head 095d17e. Consider uploading reports for the commit 095d17e to get more accurate results

@@            Coverage Diff             @@
##             main    #1539      +/-   ##
==========================================
- Coverage   49.58%   49.48%   -0.11%
==========================================
  Files          42       42
  Lines        4917     4923       +6
==========================================
- Hits         2438     2436       -2
- Misses       2339     2345       +6
- Partials      140      142       +2

Files Changed
Coverage Δ

pkg/controllers/dlb/controller.go
17.35% <0.00%> (ø)

pkg/controllers/dsa/controller.go
6.77% <0.00%> (ø)

pkg/controllers/fpga/controller.go
16.66% <0.00%> (ø)

pkg/controllers/gpu/controller.go
47.70% <0.00%> (ø)

pkg/controllers/iaa/controller.go
6.77% <0.00%> (ø)

pkg/controllers/qat/controller.go
9.72% <0.00%> (ø)

pkg/controllers/sgx/controller.go
10.74% <0.00%> (ø)

pkg/controllers/reconciler.go
4.56% <28.57%> (+0.30%)
:arrow_up:

... and 1 file with indirect coverage changes
:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more

@eero-t GPU plugin documentation talks about it and we also have similar steps documented as part of the operator deployment.

I did not mean end user documentation of installing NFD rules (updated in this PR), but some mention in internal documentation on how (NFD) labels are supposed to be configured for the plugins, e.g. in the DEVEL.md "Checklist for New Device Plugins" section.

@eero-t GPU plugin documentation talks about it and we also have similar steps documented as part of the operator deployment.

I did not mean end user documentation of installing NFD rules (updated in this PR), but some mention in internal documentation on how (NFD) labels are supposed to be configured for the plugins, e.g. in the DEVEL.md "Checklist for New Device Plugins" section.

Added: "+9. Plugin NodeFeatureRules added for Node Feature Discovery labeling."

@hj-johannes-lee PTAL


Improve Documentation, add header / footer elements

This PR, next to adding the cards, improves the usability of the storybook immensely, adding interfaces and also the full icon list.


Return the resource from pgsql

@malukenho please provide unit test, thanks!

Closing this PR due to inactivity.


Update docker for windows instructions

Purpose

Update docker for windows instructions

@anuruddhal - Also this is been reported in this issue: https://github.com/ballerina-platform/ballerina-www/issues/884


Feature request: Hi-Power Mode

Dear I have a SRK71ZR-W with Hi-Power mode.
Can this be added ?
Also Entity "energy usage cycle" not available.
If I can do something to help please let me know.
Thank you in advance.

Hi, as far as I know Hi-power mode is also not anvailable in the Smart-M air app.
Therefore it is difficult to determine what to send.
So for now I will not implement this.
The energy usage is not anvailable on every unit.
I have a "SRK63ZR-W" and there is it also not anvailable.
But for my "SRK50ZS-W" it is.
So I cannot do anything about that.


Start local should check kafka & SR by default

Currently, when click on the start button to start local environment, nothing is checked.
I think we should by default check both Kafka & SR.

Setting as a bug since we're trying to set Kafka by default but it isn't affecting anything since we aren't using the showQuickPick() API

https://github.com/confluentinc/vscode/blob/f32697965c90506c92fb4cbe51c4d0234ad9133b/src/quickpicks/localResources.ts#L22-L36

@derek1ee Kafka is now automatically checked by default (when it isn't running) during the "Start Local Resources" action as of https://github.com/confluentinc/vscode/pull/713, but we're still leaving SR unchecked for now.


Update gitignores

Proposed changes

Add backend/.gitignore
Ignore backend/uploads/ that is get generated when running the tests locally
Unignore backend/package-lock.json for clean install

Types of changes

[ ] Bugfix (non-breaking change which fixes an issue)
[x] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[ ] Documentation update (Documentation content changed)
[ ] Other (please describe):

Checklist

[ ] My code follows the style guidelines of this project
[x] I have performed a self-review of my own code
[ ] I have commented my code, particularly in hard-to-understand areas
[ ] I have made corresponding changes to the documentation
[x] My changes generate no new warnings
[x] My changes does not break the current system and it passes all the current test cases.

@Kajol-Kumari Please, check this PR under GSSoC22.

@Kajol-Kumari Please, check this PR under GSSoC22.

Can you please help me understand the need of this pr? As now you have even removed package-lock.json from the gitignore file

@Kajol-Kumari Please, check this PR under GSSoC22.

Can you please help me understand the need of this pr? As now you have even removed package-lock.json from the gitignore file

In the Dockerfile we will need the package-lock.json  file to run npm ci instead of npm install which will install the exact packages versions instead of upgrading it
Ref: https://www.youtube.com/watch?v=7lYnzRkVVLE

@Kajol-Kumari Please, check this PR under GSSoC22.

Can you please help me understand the need of this pr? As now you have even removed package-lock.json from the gitignore file

In the Dockerfile we will need the package-lock.json file to run npm ci instead of npm install which will install the exact packages versions instead of upgrading it
Ref: https://www.youtube.com/watch?v=7lYnzRkVVLE

That will reduce the incompatibility bugs.

@Kajol-Kumari Any updates?

Hey @hazemessam we should never keep package-lock.jsob in the repo. Also if you want to avoid version upgrade during installation of packages, just remive ^ from the version name. I really don't find the need if this pr and hence request you to close it.
In order to avoid the effort waste, always raise an issue first, get assigned and then start working on that issue.


aws quickstart template misses latest version

https://s3.amazonaws.com/quickstart-reference/cloudstax/firecamp/latest/templates/firecamp-existingvpc.template:

We do not want to expose the latest version to AWS QuickStart, as the latest version may not be stable. We will always put the latest release in AWS QuickStart. The QuickStart S3KeyPrefix points to AWS QuickStart S3 bucket, the path is cloudstax/firecamp/latest.
If you want to test/develop the latest version, please still use "cloudstax" bucket, https://s3.amazonaws.com/cloudstax/firecamp/releases/latest/templates/firecamp-master.template or https://s3.amazonaws.com/cloudstax/firecamp/releases/latest/templates/firecamp-existingvpc.template

Of course, it's completely up to you. But I'd give a user a choice of what to use. In my opinion the better way is to put a comment to avoid using latest release in production.
Also, please recall this thread: https://github.com/cloudstax/firecamp/issues/17#issuecomment-360527241: you advised to change the QSS3KeyPrefix to 0.9.2 from latest.

Thanks for sharing your suggestion! We still have concern for including the latest version in AWS QuickStart. None other QuickStart includes the developing release. Let's add how to install the latest version into the installation guide.

Updated the installation guide for installing the latest build.

The current quick start template still uses cloudstax/firecamp/latest as S3KeyPrefix, while the release version  either 0.9.3 or 0.9.2. Is that OK?

This is ok. The quickstart templates are hosted on AWS QuickStart Bucket, not cloudstax bucket. The templates in AWS QuickStart bucket has only one path, cloudstax/firecamp/latest. So the S3KeyPrefix in AWS QuickStart bucket is cloudstax/firecamp/latest. When we have a new release, the templates under cloudstax/firecamp/latest in AWS QuickStart bucket will be updated to the new release.
It is like we always put the last release (such as 0.9.3) templates under firecamp/releases/latest in the cloudstax bucket.

Oh, that makes sense. Though it's kinda messing. Didn't you think to sync the AWS quick start bucket name with the release version? If a user is choosing release 0.9.2 in the dropdown, will he need to change the quickstart bucket path from latest to something else?

Good Point!
We could not change the bucket name with the release version. This is not how AWS QuickStart works. We will need to make sure both releases work on the same templates, both 0.9.3 and 0.9.2 work on the 0.9.3's templates. This is not a hard problem. The template changes are usually small and compatible between 2 releases. Just tried to deploy 0.9.2 from AWS QuickStart, and it worked.


openblasCompat: 0.3.20 -> 0.3.21

Automatic update generated by nixpkgs-update tools. This update was made based on information from https://github.com/xianyi/OpenBLAS/releases.
meta.description for openblasCompat is: "Basic Linear Algebra Subprograms"
meta.homepage for openblasCompat is: "https://github.com/xianyi/OpenBLAS"
meta.changelog for openblasCompat is: ""
Updates performed

Version update

To inspect upstream changes

Release on GitHub

Compare changes on GitHub

Impact

Checks done (click to expand)

built on NixOS
The tests defined in passthru.tests, if any, passed
found 0.3.21 with grep in /nix/store/n7j5jlqy774349973sxkk6gy6pxcz2rh-openblas-0.3.21
found 0.3.21 in filename of file in /nix/store/n7j5jlqy774349973sxkk6gy6pxcz2rh-openblas-0.3.21

Rebuild report (if merged into master) (click to expand)

4828 total rebuild path(s)

4828 package rebuild(s)

First fifty rebuilds by attrpath

ChowKick
DisnixWebService
MACS2
MIDIVisualizer
R
abcl
actdiag
adapta-gtk-theme
adenum
adl
adoptopenjdk-icedtea-web
aiodnsbrute
alfaview
alfis
alloy
alloy5
alloy6
almanah
almonds
amberol
androguard
anime-downloader
anki
ankisyncd
ansible
ansible-later
ansible-lint
ansible_2_12
ansible_2_13
antlr
antlr2
antlr3
antlr3_4
antlr3_5
antlr4
antlr4_8
apache-airflow
apacheHttpdPackages.mod_tile
apacheHttpdPackages_2_4.mod_tile
ape
apeClex
apio
apktool
apostrophe
appdaemon
appleseed
appthreat-depscan
aravis
arb

Instructions to test this update (click to expand)

Either download from Cachix:
nix-store -r /nix/store/n7j5jlqy774349973sxkk6gy6pxcz2rh-openblas-0.3.21 \
  --option binary-caches 'https://cache.nixos.org/ https://nix-community.cachix.org/' \
  --option trusted-public-keys '
  nix-community.cachix.org-1:mB9FSh9qf2dCimDSUo8Zy7bkq5CX+/rkCWyvRCYg3Fs=
  cache.nixos.org-1:6NCHdD59X431o0gWypbMrAURkbJ16ZPMQFGspcDShjY=
  '

(The Cachix cache is only trusted for this store-path realization.)
For the Cachix download to work, your user must be in the trusted-users list or you can use sudo since root is effectively trusted.
Or, build yourself:
nix-build -A openblasCompat https://github.com/r-ryantm/nixpkgs/archive/49045b6200466b4fec49d8b2b4677b3ecc0e91fa.tar.gz

After you've downloaded or built it, look at the files and if there are any, run the binaries:
ls -la /nix/store/n7j5jlqy774349973sxkk6gy6pxcz2rh-openblas-0.3.21
ls -la /nix/store/n7j5jlqy774349973sxkk6gy6pxcz2rh-openblas-0.3.21/bin

Pre-merge build results
NixPkgs review skipped

Maintainer pings
cc @ttuegel for testing.

This package could do with some good suggested testing targets. I can think of: numpy, scipy, opencv.. any more suggestions? (that don't require excessive building)

Hmm. When building python39Packages.scikit-learn:
_____________ test_check_n_features_in_after_fitting[KernelPCA()] ______________
[gw6] linux -- Python 3.9.13 /nix/store/6s6bfk8r9ngn2da2kvbv2ad03j01xd26-python3-3.9.13/bin/python3.9
:-1: running the test CRASHED with signal 6

opencv definitely unhappy with this on linux x86_64:
/build/source/modules/core/src/hal_internal.cpp: In function 'int lapack_Cholesky(fptype*, size_t, int, fptype*, size_t, int, bool*)':
/build/source/modules/core/src/hal_internal.cpp:166:23: error: too few arguments to function 'void sposv_(const char*, const int*, const int*, float*, const int*, float*, const int*, int*, size_t)'
  166 |                 sposv_(L, &m, &n, (float*)a, &lda, (float*)b, &m, &lapackStatus);
      |                 ~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
In file included from /nix/store/z1v4hjka01q5g1p4qli3xdms19gmg9zn-openblas-0.3.21-dev/include/lapack.h:11,
                 from /nix/store/z1v4hjka01q5g1p4qli3xdms19gmg9zn-openblas-0.3.21-dev/include/lapacke.h:36,
                 from /build/source/build/opencv_lapack.h:12,
                 from /build/source/modules/core/src/hal_internal.cpp:51:
/nix/store/z1v4hjka01q5g1p4qli3xdms19gmg9zn-openblas-0.3.21-dev/include/lapack.h:13002:41: note: declared here
13002 | #define LAPACK_sposv_base LAPACK_GLOBAL(sposv,SPOSV)
      |                                         ^~~~~
/nix/store/z1v4hjka01q5g1p4qli3xdms19gmg9zn-openblas-0.3.21-dev/include/lapacke_mangling.h:12:39: note: in definition of macro 'LAPACK_GLOBAL'
   12 | #define LAPACK_GLOBAL(lcname,UCNAME)  lcname##_
      |                                       ^~~~~~
/nix/store/z1v4hjka01q5g1p4qli3xdms19gmg9zn-openblas-0.3.21-dev/include/lapack.h:13003:6: note: in expansion of macro 'LAPACK_sposv_base'
13003 | void LAPACK_sposv_base(
      |      ^~~~~~~~~~~~~~~~~

...continues with more similar errors.

cc @mdaiter @basvandijk as opencv maintainers

Builds on macos 10.15 though. Possibly a clang/gcc issue or a feature only enabled on linux?

replaced by https://github.com/NixOS/nixpkgs/pull/185997


Documenation

Finish documentation for the webx package.

A little bit of documentation was added to the WebXElement class. Child classes also inherit this documentation from the parent. Changes made in this commit: 2d5c097a6ff22126dca8f655ef7ffbfa95b72f62

I ended up going bezerk and documented all of classes in the blazing package. Closing this issue.


Cannot read property 'configuration' of null

Issue Id: fefbfd38-09c9-1fea-e522-93833c8f3d9cVersions - 1.5.3-  66f37fd2a99eb9d628dd374d81d78835b410c39bStack TypeError: Cannot read property 'configuration' of null/vs/code/electron-main/windows.ts#L1129:8 (sendToFocused)/vs/editor/common/modes/linkComputer.ts#L29:18 (/)/vs/editor/common/modes/monarch/monarchCompile.ts#L88:30 (lexer)/vs/editor/common/modes/monarch/monarchCompile.ts#L240:36/vs/editor/common/modes/monarch/monarchCompile.ts#L193:31 (substituteMatches)/vs/editor/common/modes/monarch/monarchCompile.ts#L338:34/vs/editor/common/modes/monarch/monarchCommon.ts#L19:1/vs/editor/common/modes/monarch/monarchCompile.ts#L240:36/vs/editor/common/modes/monarch/monarchCompile.ts#L209:33/vs/editor/common/modes/linkComputer.ts#L73:40 (charCodeAt)

Invalid stack. @ramya-rao-a fyi those linenumbers and callstack do not make sense to me when I follow the traces.

@bpasero agreed, I'll follow up


[Performance] Explicit type for response content tends to make api fast.

Sol.
Add a response data/content types.
w.Header().Set("Content-Type", "text/plain; charset=utf-8")

fix


maestro: 1.37.9 -> 1.38.1

Description of changes

I added script to automatically update the package then i run the script
https://github.com/mobile-dev-inc/maestro/blob/HEAD/CHANGELOG.md#1381
Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)

[ ] sandbox = relaxed
[ ] sandbox = true

[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[x] Tested basic functionality of all binary files (usually in ./result/bin/)
24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[x] Fits CONTRIBUTING.md.

Add a :+1: reaction to pull requests you find important.

Result of nixpkgs-review pr 341887 run on x86_64-darwin 1

1 package built:

maestro


Flatcar Support for GCE

What this PR does / why we need it:
Add Flatcar Linux support for GCE.
Reference: https://www.flatcar.org/docs/latest/installing/cloud/gcp/
Which issue(s) this PR fixes:

xref https://github.com/kubermatic/kubermatic/issues/12728
What type of PR is this?

/kind feature
Special notes for your reviewer:
Does this PR introduce a user-facing change? Then add your Release Note here:

Flatcar is now supported on GCE

Documentation:

TBD

Required https://github.com/kubermatic/operating-system-manager/pull/334


IETF compatible hasher

Description

closes: https://github.com/w3f/arkworks-algebra/issues/36

Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.

[x] Targeted PR against correct branch (master)
[x] Linked to GitHub issue with discussion and accepted design OR have an explanation in the PR that describes this work.
[x] Wrote unit tests
[x] Updated relevant documentation in the code
[ ] Added a relevant changelog entry to the Pending section in CHANGELOG.md
[x] Re-reviewed Files changed in the GitHub PR explorer

This is just the first part, testing hash-to-field.
The map-to-curve part is still pending.

@drskalman this PR should hopefully remove the outstanding CI jobs failures (even though it was not related to our code).

I moved eb2a8a9 to ietf-map-to-curve-tester branch.

@drskalman this PR should hopefully remove the outstanding CI jobs failures (even though it was not related to our code).

Why don't you merge it into the pull request then?

Why don't you merge it into the pull request then?

Not sure I follow. The PR is already merged on arkworks master (curves).
Since the CI job pulls the latest curves, it was failing since there was a bug in which dependencies curves were using.


Suggestions: metadata for each cell and integrate with Seurat in single-cell VDJ scenario

Hi immunarch developers,
Great thanks for this cool tool!
I would like to suggest two features which I think would improve the usability of immuarch when the input data is from single-cell.

Add metadata for each cell.

Now, immuarch reads data from samples and metadata is for each sample. In single-cell VDJ, if user want to compare clones of sub clusters of cells, they have to create another set of input files. If each cell has its own metadata, it would be much easier to compare different groups of cells.

Provide a small vignette or a set of functions to integrate VDJ data into Seurat object.

Nowadays, lots of researchers combine single-cell VDJ and single-cell RNA-seq analysis in their studies, and tools like Seurat are popular in single-cell RNA-seq data analysis. It is useful to map VDJ data to the cell clusters defined by transcriptome. There are already such tries like this and this. Since immuarch has high-level interfaces to manipulate VDJ data from several different platforms,  it would be great that immuarch can provide a more elegant way to do this.
Please ignore me if you think it is trivial.

Hello @YiweiNiu , it's been a while. Thank you for the ideas. Here is a couple of questions to clarify
First. Yep, this could be a potentially good feature. But first we need two things to understand better:

Potential range of typical tasks for comparison of different groups of cells. We need more examples.
A small sample of data for better understanding of data-problems you a trying to solve.
So, as always, we need a bit more information from you.

Second. The same as the first. We need a bit data to understand it's format, and we need use-cases.
May be you have contacts of people who are in need of those features. It would be great to hear about their problems and see closer what are the main problems it current data-pipelines.
By the way. 'There are already such tries like this and this' - in this and this  the links are similar. But we caught the idea :)

Hi @YiweiNiu , can you please send us an example repertoire data with metadata that you want to load into R via immunarch? Do you process this data via Seurat first?

Closed because no response.


Fix/exponential listeners

not really liking this one.
$$listeners died but, meh.
ref issue: #5

hmph. false positive.

cleaned it up a wee bit, now the tests are passing as well as manual testing in the wild.
... should probably add some Chrome/FF/etc launchers for the test runs to ensure compatibility.


Create collaboration guidelines for Ambassadors for Design

Description
@annabauza has clear guidelines for designer collaboration. It would be great if this could be in a public document we can reference to ambassadors while being transparent with the whole community.
Suggestions
This could be a document design.md in the root of the project, or a design folder with a document only dedicated to collaboration guidelines

How to contribute in designs:
→ It is expected that 1 designer is contributing to selected project.
→ Join a project session to check what is needed to design, familiarise yourself with metrics guidelines if exists.
→ Before starting the design make sure you contact the primary designer for the project to coordinate work which has NOT been assigned yet.
→ Start design and attend design sessions regularly to get feedback.
→ Once the designs are good, create issues for the developer. This issue need to be approved by the design team member and has to contain all necessary informations including margins, padding, accessibility, font metrics, colors, behavior on size change, described expected animations, etc.
→ If the project does not have a metrics document - this should be created with first design.
→ Feel free to review other designers' work either on design sessions or github issues and rise your concerts of inconstancy related to other designs within the project or related to metrics document. Feel free to review current state and rise design bugs if you find any.

How to contribute in designs:
→ It is expected that 1 designer is contributing to selected project.
→ Join a project session to check what is needed to design, familiarise yourself with metrics guidelines if exists.
→ Before starting the design make sure you contact the primary designer for the project to coordinate work which has NOT been assigned yet.
→ Start design and attend design sessions regularly to get feedback.
→ Once the designs are good, create issues for the developer. This issue need to be approved by the design team member and has to contain all necessary informations including margins, padding, accessibility, font metrics, colors, behavior on size change, described expected animations, etc.
→ If the project does not have a metrics document - this should be created with first design.
→ Feel free to review other designers' work either on design sessions or github issues and rise your concerts of inconstancy related to other designs within the project or related to metrics document. Feel free to review current state and rise design bugs if you find any.

I was mentioning about what you wrote in the Membership SOW (WIP) document about the membership levels:
Collaboration Guidelines

- Follow consistent good designs practices:
    - AnitaB.org design colors, patterns and fonts
    - Follow known good design patterns and practices (eg. metrics.io)
    - Follow metrics guideline for your project
    - Make sure there is consistency between the platforms when it does not interfere with platform expectations (for example search on Android and iOS will look different, but should appear in the same user journey point and should use the same color palette and fonts)
(...)

I can create a PR with it, I was leaving up to you for you to be the author of that content :)

I was mentioning about what you wrote in the Membership SOW (WIP) document about the membership levels:
Collaboration Guidelines

- Follow consistent good designs practices:
    - AnitaB.org design colors, patterns and fonts
    - Follow known good design patterns and practices (eg. metrics.io)
    - Follow metrics guideline for your project
    - Make sure there is consistency between the platforms when it does not interfere with platform expectations (for example search on Android and iOS will look different, but should appear in the same user journey point and should use the same color palette and fonts)
(...)

I can create a PR with it, I was leaving up to you for you to be the author of that content :)

Leave it with me @isabelcosta :)

Leave it with me @isabelcosta :)

@isabelcosta what do you think - https://github.com/anitab-org/stem-diverse-tv-cms/wiki/Design-Contributions

@isabelcosta what do you think - https://github.com/anitab-org/stem-diverse-tv-cms/wiki/Design-Contributions

That looks good @annabauza 👏 I trust you with these guidelines, I just wanted to make sure there are design guidelines that are community-wide standards available to everyone in this repository regardless of the project. Since there are projects which don't have a specific ambassador yet. We could also go more specific with certain guidelines in each project's wiki, just like you did.

That looks good @annabauza 👏 I trust you with these guidelines, I just wanted to make sure there are design guidelines that are community-wide standards available to everyone in this repository regardless of the project. Since there are projects which don't have a specific ambassador yet. We could also go more specific with certain guidelines in each project's wiki, just like you did.

Yep that's the idea. I'll add those to other projects. Thanks @isabelcosta

Yep that's the idea. I'll add those to other projects. Thanks @isabelcosta

That sounds great 💪 @annabauza

That sounds great 💪 @annabauza


Stylus-loader "use" property

Bug Report or Feature Request (mark with an x)
- [ ] bug report -> please search issues before submitting
- [x] feature request

Versions.

   / \   _ __   __ _ _   _| | __ _ _ __     / ___| |   |_ _|
  / △ \ | '_ \ / _` | | | | |/ _` | '__|   | |   | |    | |
 / ___ \| | | | (_| | |_| | | (_| | |      | |___| |___ | |
/_/   \_\_| |_|\__, |\__,_|_|\__,_|_|       \____|_____|___|
               |___/
@angular/cli: 1.1.2
node: 6.9.2
os: darwin x64
@angular/animations: 4.2.3
@angular/common: 4.2.3
@angular/compiler: 4.2.3
@angular/core: 4.2.3
@angular/flex-layout: 2.0.0-beta.8
@angular/forms: 4.2.3
@angular/http: 4.2.3
@angular/platform-browser: 4.2.3
@angular/platform-browser-dynamic: 4.2.3
@angular/platform-server: 4.2.3
@angular/router: 4.2.3
@angular/cli: 1.1.2
@angular/compiler-cli: 4.2.3

Repro steps.
There is no repro, because of feature request
The log given by the failure.
None
Desired functionality.

I would love to able to provide use and import stylus-loader config property like described here:
https://github.com/shama/stylus-loader#using-nib-with-stylus
This is easy-to-implement and full of sense.
Why common developer need this:
Because of common mixin libraries (like nib or this one: https://github.com/glebmachine/stylus-mixins)
Mention any other details that might be useful.

Avoided this with:
"stylePreprocessorOptions": {
        "includePaths": [
          "../node_modules"
        ]
      },

And
@import 'stylus-mixins';


Separate source files from .js files in node modules

The current published modules make the typescript compile it every time the app gets compiled because the emitted js files are in the same folder as .ts files.
Ts files should be in separate folder (eg. src) and js should be in build folder.
Additionally, it's impossible to use this library with noImplicityAny:true, because ts complains about errors in the module. See
https://github.com/Microsoft/TypeScript/issues/14787
It's just a matter of building the module correctly so i'm not sure if a PR would help

@brunoAltinet
Ok I'll get rid of all noImplicitAny errors that are still left over.
And In the next patch version I'm going to deliver only *.d.ts files.

Cool, thanks for a great job!

@brunoAltinet
So far I've removed all NoImplicitAny errors from the library code.
But I will keep on publishing the .ts files in npm packages as this essential for debugging.

The current published modules make the typescript compile it every time the app gets compiled because the emitted js files are in the same folder as .ts files.
Ts files should be in separate folder (eg. src) and js should be in build folder.

I cannot verify this as the @ng2-dynamic-forms and node_modules folder are excluded from transpiling in tsconfig.json.

@udos86 Yea, but they still do get compiled because excluding doesn't help if the referenced library/folder has .ts files in the same location as the emitted .js files. A good test would be to make a test project with an older build (with noimplicitany issue) referenced in node_modules, and exclude folder set. Typescript will ignore the exclusion because it's able to find .ts files in the referenced location, and it treats .ts files as a source of truth, and consequently it throws an error.
But it's a small library, and I appreciate the effort, so this will do:) Cheers!


Collection.add(   documents=a['documents'],   metadatas=b['metadatas'],   ids=c['ids'] )  is slow. How to make it faster ??

I am using ChromaDb for finding the most relevant document than LLM to get desired output from it. But this process takes more than 15 seconds with majority taken up by collection.add(....) step. Is there is a way to make it faster or efficient or an alternative way to achieve the same ????

Found the solution :--
If we have pre-made Embeddings stored. we can input them here along with documents, metadatas, ids. By doing this ( i guess ) the Collection.add() function doesn't have to create embeddings ( for we already gave it ), thus saving time. Queries are answered as fast as 6 seconds now

Found the solution :-- If we have pre-made Embeddings stored. we can input them here along with documents, metadatas, ids. By doing this ( i guess ) the Collection.add() function doesn't have to create embeddings ( for we already gave it ), thus saving time. Queries are answered as fast as 6 seconds now

what dose pre-made mean?


fix: prevent mqtt enumerator in dead loop if disconnected

I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.
What's changed and what's your intention?
as title, return error in this case instead of loop and waiting

Checklist

[ ] I have written necessary rustdoc comments
[ ] I have added necessary unit tests and integration tests
[ ] I have added test labels as necessary. See details.
[ ] I have added fuzzing tests or opened an issue to track them. (Optional, recommended for new SQL features #7934).
[ ] My PR contains breaking changes. (If it deprecates some features, please create a tracking issue to remove them in the future).
[ ] All checks passed in ./risedev check (or alias, ./risedev c)
[ ] My PR changes performance-critical code. (Please run macro/micro-benchmarks and show the results.)

[ ] My PR contains critical fixes that are necessary to be merged into the latest release. (Please check out the details)

Documentation

[ ] My PR needs documentation updates. (Please use the Release note section below to summarize the impact on users)

Release note
If this PR includes changes that directly affect users or other significant modifications relevant to the community, kindly draft a release note to provide a concise summary of these changes. Please prioritize highlighting the impact these changes will have on users.

This breaks the MQTT source connector. I've tested it both locally against a vernemq cluster as well as against the mqtt.eclipseprojects.io broker.
The only way you could successfully connect the broker is for !self.connected.load(std::sync::atomic::Ordering::Relaxed) to be true. connected starts out false and only becomes true when the first subscription is sent out. This requires enough time to have elapsed to connect to the broker.
The current calls to the enumerator do not leave enough room. As the ConnectorSourceWorker is created and then immediately ticked. The create doesn't wait between creating the Enumerator and returning and tick doesn't wait before calling list_splits.


refactor(about): add chipped content

Adds chipped content component. To abstract & simplify implementation of chipped content in current experience items.
TODO

[ ] When content is shown, expand experience item to take 2 rows on grid
[ ] Add animations back when showing and hiding content

Current dependencies on/for this PR:

main

PR #97   👈

This comment was auto-generated by Graphite.


Hyperparameters for SFT?

Thanks for the great work. One thing I'm curious about is that does it actually work well on SFT for LLMs? It is not covered in the paper, as well. I tried the following parameters on a 2B-sized model, but it leads to very slow convergence. Could you please give me some advice?
lr: 5e-5
galore_rank: 64
galore_update_proj_gap: 200
scale: 0.25
proj_type: std

We also observed the same phenomenon, maybe we should increase galore_scale for faster convergence in SFT

After some trials, I am able to find a pair of hyper-parameters that performs on par with LoRA/DoRA with regard to training loss (with lora_rank=64, lora_alpha=16, lora_dropout=0.5).
lr: 3e-5
galore_rank: 256
galore_update_proj_gap: 200
galore_scale: 4.0
galore_proj_type: std
weight_decay: 1e-4
lr_schedule: cosine

mark


Index page only capable of rendering drop down menus one directory deep

The index or page directory page renders nice drop down menus for folders. Unfortunately, the code only works when the folders are one deep. Additionally there is no indentation making it difficult to tell the folders apart.
Indentation is easy enough to add with

 tags. I tried implementing a secondary folder mechanism myself but I'm not a very experienced rustacean and all my solutions proved very buggy.
Also, this project is really cool. Keep up the good work!

Thank you for opening this issue, this is definitely a bug! Not that all bugs are bad, @jiminycrick. I'm not saying that. In fact, I once saw a story about a brave little bug who helped a poor little puppet boy make his dreams come true. It was inspiring.
I'm currently in the process of moving deadwiki to use an actual HTML templating system, so hopefully the code will be slightly less nasty to deal with in the future.
In the meantime, I will leave this issue open until it gets fixed. And you're right about the indentation too, we should try to make sure all the levels are obvious. Maybe even do it like tree.
Glad you like the project, thank you! We are just at the beginning.

Coming soon:

This is now in master and will be released soon. It might be wonky as it uses the new Hatter templating library, but so far it's working for me and it's really nice! Thanks again for the issue!


Fix retain cycle between CDTQIndexManager and CDTDatastore

What
Fix retain cycle between CDTQIndexManager and CDTDatastore
How
Make a weak reference to the associated object from the CDTDatastore to the CDTQIndexManager. Because it isn't reference counted, the CDTQIndexManager instance dealloc is correctly called (it didn't before because its reference count never reached 0), at which point the reference is cleared.
Testing
See added test class CDTQLifecycleTests

@tomblench before you merge this also needs a CHANGELOG entry


This commit allows the excerpt helper to fully utilize all downsize options

I rearranged the pick/map functions so that other options like "append" and "round" aren't filtered out of the truncateOptions object (the append option seems to be super useful!)

Tests pass locally - please let me know if there's anything I get to modify on my end!

Hey @dangerdespain, everyone's tests were failing due to a dependency issue. The fix for that has now been merged into master - if you could just rebase off of that and push again, we should get green

Hi @dangerdespain, I appreciate you taking the time to do this.
This PR is making changes to Ghost's theme API, which is the most publicly visible part of the platform. Changes to the theme API need to be very carefully considered, and in this case, the lack of support for the round and append options in Ghost is deliberate.
With regards to round, you can read about why we didn't add support for it in this PR and the related issue - in short the way it works isn't as intuitive as we would want for the theme API - and so we decided to pursue a different angle as explained in #5060.
With regards to append, this feature doesn't make a great deal of sense for the excerpt helper in its present form, because all formatting is stripped and therefore there it is quite possible to put any text you want after your excerpt next to the {{excerpt}} helper. It's quite a different case for the content helper, where the append attribute isn't supported yet due to the limitations explained in #2163.
With all this in mind, I'm going to close this PR. If there is something you're trying to do with the theme API and can't, let us know about it so we can be certain that the plans in #5060 aren't missing something big and if you're interested, the spec outlined in #5060 needs someone familiar with downsize to look into how to achieve it :)

The impetus behind this PR was that my OCD alarm bells were ringing when I realized that truncated and non-truncated excerpts both had the append text hardcoded into the hbs template. I'm building a photoblog (as I travel Thailand!) and don't use much text. More often than not, the post text fits entirely in the excerpt and it was driving me nuts to see "..." or "cont'd" after the content. I agree that making this work for both the content and excerpt helpers is going to be a helluva challenge.
I read up on #5060 (thanks for the link!) and agree that the round option doesn't seem to work as hoped.. Perhaps I'll take a stab at it when I have the bandwidth to take a deeper dive. Otherwise, I'll chug along with a personal branch I can move my odd personal touches into apps instead [=
Thanks!

The impetus behind this PR was that my OCD alarm bells were ringing when I realized that truncated and non-truncated excerpts both had the append text hardcoded into the hbs template. I'm building a photoblog (as I travel Thailand!) and don't use much text. More often than not, the post text fits entirely in the excerpt and it was driving me nuts to see "..." or "cont'd" after the content.

That's an interesting problem - I can see how that would be irritating. My initial recommendation would be to use a tag to indicate your photoblog posts, and display a different excerpt for those. We plan to make this more intuitive by making private tags a possibility soon - so you could use a tag that wouldn't be visible to readers.

@ErisDS
Could you please share how one can do this (use tag to indicate special kind of posts and display different excerpt for those)?
I have exactly the same problem, I have multiple posts with just a few words and image and I struggle to conditionally show "read more" button depending on how large is text in a post.
I have made a simple inline js script to check excerpt length in characters and add/remove "read more" button. I check for pure text in excerpt returned by {{excerpt character="100"}} and if it is less than 100 I remove "read more" button but it doesn't work if the text contains UTF symbols. Then the text length I get is not calculated correctly (or rather calculated differently by 'downsize') so I may end up with 99 characters in excerpt and fail in my condition.
I would really appreciate if there would be an easy way to check if excerpt is the whole text content or not.

@shyswork I recommend swinging by our slack community and asking for some help with your use-case there.


Merge remote-tracking branch 'upstream/stable' into merge_stable

Looks like we first need to fix DScanner:
std/experimental/allocator/common.d(0:0)[warn]: Use `enum bool empty = false;` to define an infinite range.
[Inferior 1 (process 2292) exited with code 01]

DScanner PR: https://github.com/dlang-community/D-Scanner/pull/672

Auto-merge toggled on


Tools for optimizing performance

Feature:
Performance measurement
Description
Just run into a performance issue. I think this boilerplate should have a tool for optimizing performance.
Right now I'm using a Chrome extension and react-addons-perf package.
Added some lines to app.js:
https://github.com/juanda99/arasaac-frontend/blob/master/app/app.js#L149-L151
Is it the good way to go?

I opened PR #1635 about this a while ago but it didn't get any traction.
I've found the Why Did You Update package helpful from time to time.
The boilerplate already has the analyze npm script that can help a bit as well.
There probably isn't much more this boilerplate can do to help, just start optimizing your ShouldComponentRenders.

Thanks! I didn't know about the Why Did You Update package. I'll try it.
As you open that PR, I closed this issue. I think it should be taking into account for next version.

just to add another opinion, personally i use react-addon-perf and import the following into the client-side script.  I like it as you're able to turn on/off the render recordings to find if specific user actions (e.g. hover) causes pointless re-renders.

/* eslint-disable no-console, global-require */
if (process.env.NODE_ENV !== 'production') {
  const Perf = require('react-addons-perf');

  window.addEventListener('keyup', (evt) => {
    if (evt.ctrlKey || evt.altKey || evt.metaKey || evt.shiftKey) {
      return;
    }

    if (evt.target.tagName !== 'BODY') {
      return;
    }

    switch (evt.key) {
      case 's':
        if (Perf.isRunning()) {
          console.log('Stopped React Perf Measurement.');
          Perf.stop();
        } else {
          console.log('Started React Perf Measurement.');
          Perf.start();
        }
        break;
      case 'w':
        console.log('Output of printWasted');
        Perf.printWasted();
        break;
      case 'e':
        console.log('Output of printExclusive');
        Perf.printExclusive();
        break;
      case 'i':
        console.log('Output of printInclusive');
        Perf.printInclusive();
        break;
      default:
        break;
    }
  });
}


Added design doc for policy-only mode.

@jianjuns @abhiraut @tnqn @antoninbas
please review thx.

/test-all

/test-all

@jianjuns @antoninbas @abhiraut @tnqn
if comments are addressed, please help approve and merge
thx, su

/skip-all

/skip-all

@jianjuns @suwang48404 I didn't realize this was still open. Anything preventing it from getting merged?

@jianjuns @suwang48404 I didn't realize this was still open. Anything preventing it from getting merged?

My apologies, let me try to address @jianjuns comments quickly.

@antoninbas @jianjuns can u please help approve and merge?
I cannot merge by myself.

/skip-all

@jianjuns I think my major comments have already been addresses, so I'm good to merge this. We can improve the documentation over time, by taking into account issues that users run into.

Ok. Let us merge the PR. I changed "Additional Works" to "Future Work" as you suggested.

/skip-all


Comments

It would be nice to have rudimentary comment support to leave feedback on uploaded songs.

This is beyond the scope of what BeatSaver is designed to do. BeastSaber is the place for that.


Grafana Dashboard

Hello!
I'm trying to understand how to use the https://github.com/pyrra-dev/pyrra/tree/main/examples/grafana.
And it says that I need to use --generic-rules, but where??
I need to use this flag when I am deploying Pyrra? Or when I am deployng the SLO's manifests inside examples/kubernetes/manifests/slos? Or I need to edit one of these manifests to put the --generic-rules inside ?
Thanks in advance for any help.

You need to run two Pyrra components.
One with the api command and one with the filesystem or kubernetes command. The filesystem or kubernetes components need to be run with this --generic-rules flag.
Hopefully you could figure it out in the mean time.
I'll make sure to update the documentation there to make it more obvious.

Hello!Tks for the answer!
I am trying to use the helm chart to deploy it and use with Grafana: https://artifacthub.io/packages/helm/rlex/pyrra
So far so good I am able to install it and run a pyrra-kubernetes changing the parameter generic-rules to true inside values.yaml.

But it keeps showing nothing on my Grafana dashboards.

I suspect about two things:
1 - I need to pass some args to pyrra-kubernetes using extraKubernetesArgs to point to my correct PrometheusURL, as you can see on the logs its using localhost:9090, but I have prometheus running on prometheus-operated.monitoring.svc.cluster.local:9090.
But I don't know which args I can pass on this parameter  extraKubernetesArgs on values.yaml to change this.
2 - As you can see, it starts a metrics server on port 8080, but I don't see any exposed service to make my prometheus scrap this.And again, maybe there is some parameter that I can pass using extraKubernetesArgs  and I don't know which parameters I can use(I didn't fin any documentation about parameter that I can use on it).

Tks in advance for any help.

I was able to make it works!
After identify that the prometheus operator uses a label to connect to all the objects that makes part of the solution I see that the components created by Parry doesn't have the correct label on it.
After change the label on rules and the SLO's objects to match the label used by my prometheus created by kube-prom operator, it works!
Thanks!

I was able to make it works! After identify that the prometheus operator uses a label to connect to all the objects that makes part of the solution I see that the components created by Parry doesn't have the correct label on it. After change the label on rules and the SLO's objects to match the label used by my prometheus created by kube-prom operator, it works!
Thanks!

@giz33 can you please elaborate on which label specific this is? I have kube-prometheus-stack helm chart installed which includes the prometheus operator but no generic rules metrics (such as pyrra_objective) are being created in prometheus


Documentation for the existing logging system

Background
Right now the existing logging system is not well documented.  Doing this will help us better understand how to make improvements to the existing system and inform users how they should use the logging system.
This came out of the discussion in this PR: https://github.com/ros2/ros2_documentation/pull/2000
Questions this should answer

What are the RCUTILS_ macros, and where should they be used?
What are the RCLCPP_ macros, and where should they be used?
What is the logging system for the launch system and how should it be used?
Why do the RCLCPP_ macros require a logger object to be passed, while the RCUTILS_ and ROS 1 macros did not?
Where do logs go?
How does the per-process logger interact with the launch loggers?
How do I configure the loggers?
What are the environmental variables that can affect the logging system?

How should this be organized?

What are the concepts and patterns a user of ROS 2 needs to understand to use the logging system?  (tutorial?)
What are the concepts and details of the logger someone contributing to ROS 2 itself needs to understand?  (concepts or contributing?)

Who will do this work?
I've volunteered @JafarAbdi to work on this with me as he created the PRs that started this discussion (that I want to be merged).  I can't be assigned this task as I'm not a member of the ros2 github org, but you can consider me assigned.  @clalancette has agreed to review this work.
What already exists?

Concepts: https://docs.ros.org/en/rolling/Concepts/About-Logging.html
Tutorial: https://docs.ros.org/en/rolling/Tutorials/Logging-and-logger-configuration.html

How does the screen/file output work?
How can many different processes write to the screen output (stderr/stdout) without interleaved output?
When a launch file is used does the launch system subscribe to /rosout for each process and then handle formatting/interleaving?
If a node is run with ros2 run how does the formatting of output and sending to the screen and log file work?
I have found https://github.com/ros2/launch/blob/master/launch/launch/logging/init.py which seems to create the log file directory and control formatting/writing of logfiles.  Is this just for logging from within the launch system, or is this also used by processes run by the launch system?
@clalancette do you know the answers for any of these questions or where I should look in the code for answers?

In reading all this code I've discovered there seems to be really tight coupling between the C and C++ ROS 2 libraries.  It would have been much easier to read/understand all of this if ROS 2 was developed in one language (C, C++, rust, whatever is cool with the kids these days) and that was the standard public API.  Then, after that was done, a code generator created interfaces for other languages.  There is way too much implementation in rclcpp which makes this whole logging system much harder to understand.
Secondly, a global logging mutex.  :facepalm: When you use a RCLCPP logging macro with the default config this is what it does:

lock global logging mutex
write to stderr/stdout (rcutils_logging_console_output_handler)
publish to rosout (rcl_logging_rosout_output_handler)
write to logfile using spdlog (rcl_logging_ext_lib_output_handler)
unlock mutex

This seems to be a crazy pessimization to me.  Why is there not at least a lock per file stream, or worse, per logging output handle?  Is preserving the order or writing to logs on separate file streams that important?  I understand not wanting to have multiple threads attempting to write to one file stream concurrently.  Instead of using locks at this layer would it not be better to just use file locks (https://en.wikipedia.org/wiki/File_locking)?
Even better, why not have an in-memory per-thread queue for writing logs to that would be serviced (where the output handles would be called) from one thread?  That way you could define a policy for how to handle this queue that would allow it to drop logs in cases where the determinism of a given thread should not be impacted by the logging system?

I'm not sure if this should be a separate issue, but it is within the scope of this one.
Under Logging Usage for C++ at the Concept page (https://docs.ros.org/en/rolling/Concepts/About-Logging.html), there probably should be a C++ implementation demo similar to the Python's one. Probably something like:

https://github.com/ros2/demos/tree/master/logging_demo ?

I'm not sure if this should be a separate issue, but it is within the scope of this one.
Under Logging Usage for C++ at the Concept page (https://docs.ros.org/en/rolling/Concepts/About-Logging.html), there probably should be a C++ implementation demo similar to the Python's one. Probably something like:

While this is a large issue (and thus could conceivably contain what you are talking about), I think it makes sense to have a separate issue for end-user demos.  I'll suggest you open a separate issue just to create demos for the logging functionality; it will be easier to follow-up there for a smaller amount of work.

I'm sorry I haven't followed up on this.  I hope to have time to clean this up soon.  I agree that some user demos would be nice but are out of the scope of this PR.


feat(deisctl): Add deisctl ssh

Todo: You can't list machines or get a machine ID in deisctl at the moment, so this isn't useful until normal users can look up a machine ID, rather than use fleetctl to look them up.
We might want to expand this by allowing users to specify a unit, then ssh to the host running the unit, like fleetctl does.
$ deisctl ssh 3f3e5d240b1d400b901f38946da24db6
Last login: Wed Jun  3 02:55:49 2015 from <IP_ADDRESS>
 * *    *   *****    ddddd   eeeeeee iiiiiii   ssss
*   *  * *  *   *     d   d   e    e    i     s    s
 * *  ***** *****     d    d  e         i    s
*****  * *    *       d     d e         i     s
*   * *   *  * *      d     d eee       i      sss
*****  * *  *****     d     d e         i         s
  *   *****  * *      d    d  e         i          s
 * *  *   * *   *     d   d   e    e    i    s    s
***** *****  * *     ddddd   eeeeeee iiiiiii  ssss

Welcome to Deis			Powered by CoreOS
core@deis-02 ~ $ uname -a
Linux deis-02 4.0.1 #2 SMP Wed May 27 03:33:38 UTC 2015 x86_64 Intel(R) Core(TM) i5-4570 CPU @ 3.20GHz GenuineIntel GNU/Linux
core@deis-02 ~ $ exit
logout
$

Fixes #3062

This is really weird. Jenkins is not setting the statuses on this PR. It was build #1178 which failed due to an startup timeout. But as you can see, no commit status was set at all.

Jenkins is not setting the statuses on this PR.

I've been messing around with project permissions lately, so it's not all that surprising, but I just confirmed that Jenkins has the proper access tokens - I'm not sure what's wrong :(

fleetctl ssh targets a unit rather than a machine, I believe. I think this is how deisctl ssh should work - I could deisctl ssh router@1 and it should connect me to the machine running router@1. I think it's a bit odd for the other commands to target units and for ssh to target machines.

I agree, I created the simplest possible PR, but I agree that that is a logical next step

@carmstrong I updated the code target units as well as Machines, as you suggested.

LGTM. Great work, @Joshua-Anderson!


ENH: support arrays in strtree query

In case of an array passed to STRTree.query, shapely returns two arrays of which the second one contains indices of matches from the tree. It remains sorted but the the geometries from the array are ignored if there's no match in the tree.
The issue is that the resulting selection is not possible to match to original array as you don't know which match is linked to which geometry and which geometry is ignored unlike with nearest which has 1:1 match.
I belive that this is useful anyway like this but we should also look into some smarter way of doing this. Though this already touches the idea of spatial join more than a simple filter.
Marking as a draft now as I'd like to get some basic tests in before this gets merged.

This is useful indeed!

we should also look into some smarter way of doing this.

Index.sel() is actually very versatile, i.e., it is possible to add, drop or rename coordinates and indexes in the resulting Xarray object (see IndexSelResult).
I'm worried that using it too smartly here will confuse users more than help them, though. Perhaps it would be better to provide a custom API for advanced spatial join instead of trying to reuse .sel()?

I'm worried that using it too smartly here will confuse users more than help them, though. Perhaps it would be better to provide a custom API for advanced spatial join instead of trying to reuse .sel()?

Yes, that is what I meant rather than making sel smarter.

I am a bit unsure what the behaviour should be here as if we use the raw result of query, it is sometimes a bit unintuitive. Because apart from missing hits I mentioned above, we also have duplications. Consider the snippet below:
In [1]: import numpy as np
   ...: import shapely
   ...: import xarray as xr
   ...: from pyproj import CRS
   ...:
   ...: from xvec import GeometryIndex
   ...:

In [2]: geom_dataset = xr.Dataset(
   ...:     coords={"geom": np.array([shapely.Point(1, 2), shapely.Point(3, 4)])}
   ...:     ).drop_indexes("geom").set_xindex("geom", GeometryIndex, crs=26915)

In [3]: geom_dataset
Out[3]:
<xarray.Dataset>
Dimensions:  (geom: 2)
Coordinates:
  * geom     (geom) object POINT (1 2) POINT (3 4)
Data variables:
    *empty*
Indexes:
    geom     GeometryIndex (crs=EPSG:26915)

If we use sel with an array of two equal geoms, we get the same hit twice.
In [4]: geom_dataset.sel(geom=[shapely.box(0, 0, 2, 2), shapely.box(0, 0, 2, 2)], method="intersects")
Out[4]:
<xarray.Dataset>
Dimensions:  (geom: 2)
Coordinates:
  * geom     (geom) object POINT (1 2) POINT (1 2)
Data variables:
    *empty*
Indexes:
    geom     GeometryIndex (crs=EPSG:26915)

If we have one of the geometries returning more than one hit, they are all used, so the final coordinates have 3 geometries now. One of them is duplicated and we don't know which result comes from which input geometry.
In [5]: geom_dataset.sel(geom=[shapely.box(0, 0, 2, 2), shapely.box(0, 0, 4, 4)], method="intersects")
Out[5]:
<xarray.Dataset>
Dimensions:  (geom: 3)
Coordinates:
  * geom     (geom) object POINT (1 2) POINT (1 2) POINT (3 4)
Data variables:
    *empty*
Indexes:
    geom     GeometryIndex (crs=EPSG:26915)

This behaviour is a bit unintuitive and has a limited use case (but there is some). Another option would be to filter only unique hits to eliminate duplications. The API would then work as give me any geometry that intersects with any of input geometries instead of the full result of query. Ideally, we would have this controllable via a keyword but that is not yet supported in xarray.
With only unique hits, the result from the snipper above would be:
In [4]: geom_dataset.sel(geom=[shapely.box(0, 0, 2, 2), shapely.box(0, 0, 2, 2)], method="intersects")
Out[4]:
<xarray.Dataset>
Dimensions:  (geom: 1)
Coordinates:
  * geom     (geom) object POINT (1 2)
Data variables:
    *empty*
Indexes:
    geom     GeometryIndex (crs=EPSG:26915)

In [5]: geom_dataset.sel(geom=[shapely.box(0, 0, 2, 2), shapely.box(0, 0, 4, 4)], method="intersects")
Out[5]:
<xarray.Dataset>
Dimensions:  (geom: 2)
Coordinates:
  * geom     (geom) object POINT (1 2) POINT (3 4)
Data variables:
    *empty*
Indexes:
    geom     GeometryIndex (crs=EPSG:26915)

Is there anything in xarray that resembles this so we can use the same model?

Until Xarray supports custom sel options, alternatively we could expose this feature via an accessor, e.g.,
>>> geom_dataset.vec.query_bulk(geom=<Any>, predicate="intersects")

I think that something like
geom_dataset.sel(geom=<Any>, method="bulk", predicate="intersects", unique=True)

would be ideal. It is clear that the method called "bulk" behaves differently and you can control if unique hits should be filtered or not.

keeping ordering unchanged?

This is a bit tricky as you can have no hit, one hit or many hits for any given geometry. How would you keep the order unchanged? using the first appearance?

Until Xarray supports custom sel options, alternatively we could expose this feature via an accessor

Or we can wait a bit to avoid confusion of the API. I'd rather avoid using query_bulk because even shapely has merged what used to be query and query_bulk in pygeos under a single query that accepts both scalars and arrays,

Just to be sure to understand: by unique hits do you mean something like this?
coord_geom_array = numpy.array([...])
tree = shapely.STRtree(coord_geom_array)

res_input, res_tree = tree.query(input_geom_array, predicate="intersects")

# unique hits
np.unique(res_tree)

Since np.unique here returns the sorted unique tree indices, it would preserve the order of geometry elements from the original coordinate.
Assuming a coordinate with duplicate geometries like
>>> geom_dataset_dup
<xarray.Dataset>
Dimensions:  (geom: 3)
Coordinates:
  * geom     (geom) object POINT (1 2) POINT (3 4) POINT (1 2)
Data variables:
    *empty*
Indexes:
    geom     GeometryIndex (crs=EPSG:26915)

The unique hits (like computed above) will still preserve duplicate elements in the original coordinate, right? Re- with your examples:
>>> geom_dataset_dup.sel(
...     geom=[shapely.box(0, 0, 2, 2), shapely.box(0, 0, 2, 2)],
...     method="bulk",
...     predicate="intersects"
... )
<xarray.Dataset>
Dimensions:  (geom: 2)
Coordinates:
  * geom     (geom) object POINT (1 2) POINT (1 2)
Data variables:
    *empty*
Indexes:
    geom     GeometryIndex (crs=EPSG:26915)

and
>>> geom_dataset_dup.sel(
...     geom=[shapely.box(0, 0, 2, 2), shapely.box(0, 0, 4, 4)],
...     method="bulk",
...     predicate="intersects"
... )
<xarray.Dataset>
Dimensions:  (geom: 2)
Coordinates:
  * geom     (geom) object POINT (1 2) POINT (3 4) POINT (1 2)
Data variables:
    *empty*
Indexes:
    geom     GeometryIndex (crs=EPSG:26915)

Is it the behavior that you have in mind in that case? It is the kind of behavior I would expect. Actually I don't see any use case for sel where we don't want unique hits?

Or we can wait a bit to avoid confusion of the API. I'd rather avoid using query_bulk because even shapely has merged what used to be query and query_bulk in pygeos under a single query that accepts both scalars and arrays

Ah I see. If we don't want to wait too long, we could still provide
>>> geom_dataset.vec.sel(geom=<Any>, method="bulk", predicate="intersects", unique=True)

that we'll eventually deprecate in favor of geom_dataset.sel(geom=<Any>, method="bulk", predicate="intersects", unique=True) once it is supported by Xarray.

Is it the behavior that you have in mind in that case? It is the kind of behavior I would expect.

Yes. That is what is commented out here https://github.com/martinfleis/xvec/pull/4/files#diff-901f12b942c05131d9d71515bc5d8af82c64bdce8900cb0e7d9695e061e809afR201

Actually I don't see any use case for sel where we don't want unique hits?

Assume coordinate being a location of a pharmacy and indexer a buffer around arbitrary points trying to compute mean number of accessible pharmacies across the dataset. Then you want all hits as a location accessible from point A is also accessible from point B. There are likely better ways of doing this but I would still try to allow this output if it doesn't cost much.

If we don't want to wait too long, we could still provide geom_dataset.vec.sel

Maybe as a temporary solution, yes.


Images mixed up while using with UICollectionView

When Collectionview reuses the view then images get mixed up.
Let suppose there is cell A, and code made a request for IMG_URL_1 that is 43KB It will take time to load CollectionView while scrolling reuses cell A again and this time code made a request for IMG_URL_6 for this cell, and this image is only of 6KB, so it will load faster while IMG_URL_1 still in loading process. First view gets updated with IMG_URL_6 image because it loaded early, but after few mili seconds IMG_URL_1 also get loaded so cell will get updated again with IMG_URL_1 this time. But it should display IMG_URL_6 image instead of IMG_URL_1 image.

Found placeholder image which fixed it.
cell.OfferImage.pin_setImageFromURL(imageURL, placeholderImage:(UIImage(named: "placeholder.png")))

Out of curiosity, were you using setImageFromURL or were you downloading the images directly and setting them on the image view. If you were doing the former, this shouldn't have happened, regardless of if there is a placeholder image set.

Hi Garrett,
I was using pin_setImageFromURL method as I was getting error while using setImageFromURL method. But I wasn't downloading the images directly and setting them on image view.

That sounds like a real bug then, do you think you could send a sample project to<EMAIL_ADDRESS>It'd be greatly appreciated :)

Sure Garrett I would be happy to help I will send them to you by tmr :)
On Tue, Aug 11, 2015 at 10:12 AM, Garrett Moon<EMAIL_ADDRESS>wrote:

That sounds like a real bug then, do you think you could send a sample
project to<EMAIL_ADDRESS>It'd be greatly appreciated :)
—
Reply to this email directly or view it on GitHub
https://github.com/pinterest/PINRemoteImage/issues/32#issuecomment-129678712
.

Hi! Any news about it? It is still there...I used the Network Link Conditioner to simulate a slow network. I have version 3.0.0 beta 7 and the images are coming mixed in a collection view. Thanks.

@claudiagrilli would you mind sending me a sample project to<EMAIL_ADDRESS>

Actually I managed to solve it just cancelling the download in prepareForReuse and setting the image to nil. But now I have the problem that when I scroll back the download needs to restart from the beginning..Is there a better way? Thanks!

@claudiagrilli Changing the URL in prepareForReuse should actually have the same effect, if it's not, I'd still love to see a sample project.
Separately, instead of canceling the download, if you want to allow it to continue but not report the result (i.e. it should be cached), you should be able to call pin_setDownloadImageOperationUUID:nil before setting a new image URL. This will make it so the image view ignores the result of the current download operation (i.e. it will get cached, but the results won't be set on the image view).


[question] Find source code of MUI docs navbar

Question
Where is the source code for the header at https://mui.com/material-ui/getting-started/overview/ , i can't find it
Resources and benchmarks 🔗

The code is here:

https://github.com/mui/material-ui/blob/master/docs/src/modules/components/AppNavDrawer.js
https://github.com/mui/material-ui/blob/master/docs/src/modules/components/AppFrame.js

thx


[PORT] Improve disconnect test so it actually tests disconnect.

Port this change from botbuilder-dotnet/master branch:
https://github.com/microsoft/botbuilder-dotnet/pull/3865

Closes #3861
Tested using VSTest under netcore 2.1 and 3.1, now passes 100% of the time, vs around 50% of the time previously. Also now asserts the connection has been established and then torn down, to be sure the state has changed.
Changed projects

Microsoft.Bot.Streaming.Tests

Definitely N/A


Fix smoke tests build

:tada: This PR is included in version 2.0.1 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


Loading bar only appear on page load

Loading bar version = 0.9.0
Angular version = 1.5.6
Firefox
The loading bar is injected to the application module with
 var mstdapp = angular.module
     ('mstdapp', [
     'ngRoute',
     'ui.bootstrap',
     'angular-loading-bar',
     'ngAnimate',
     'ui-notification',
     'ui.select',
     'ngSanitize',
     'LocalStorageModule',
     'ngMessages',
     'SignalR','mgcrea.ngStrap'
     ]);

The loading bar works fine while the page load and fetch data from server API. However, any $http request (either POST or GET) from within the controller is not triggering the loading bar. I have also implemented a custom http request interceptor to fetch the token data.

It's likely related to your custom interceptor.  $http is a service, and will work the same regardless of whether it's used in a controller, another service, or anywhere else.
If you can reproduce with a reduced test case (like a fiddler), I can take a look.


update: injected connector detection

This PR updates the handling of injected connectors.
Old flow:

Using wagmi's getInjectedName method we would check if any of the names in that list were in our list of wallet configs.
If MetaMask or Coinbase Wallet were installed it would avoid showing the injected connector to avoid mimicking connectors.

This caused us having to have overrides and cross checks which requires a per-wallet flag to avoid soft-blocking user flows.

New flow:

Filter the wallet configs for wallets with the installed flag (which is based on each wallets isX check).
If none is found, use the wagmi getInjectedName method.
Display assets/name in the injectedConnector button
If wagmi's getInjectedName is either MetaMask or Coinbase Wallet (or both) then ignore the injected connector as we have the metaMaskConnector and coinbaseWalletConnector connectors already set up.

Can confirm this fixes my issue with Brave browser. Relative to this open issue https://github.com/family/connectkit/issues/250

On top of the adjustments to make multiple injected wallets work smoother, there is a use-case where wallets (e.g Rabby) will overall all of MetaMasks functionality, in this situation we've disabled the MM button and added a tooltip with instructions for if the user wishes to continue with MM:


Fix for regexp replacements used by verify steps

While working on this workshopper, I ran into some problems verifying my solutions.
The generated HTML was being mangled by the regexp replacements, probably due to newline differences. The output was rather confusing and it took me a while to figure out. Hopefully this can prevent that experience for others. I think it's the same problem described in #103.
I've been using a newer version of React for the workshopper, which is likely why I ran into this problem.
With the changes in this pull request, the workshopper should continue to work with React 0.14 as well as newer versions. Additional changes are necessary to bring the exercises and solutions up to date with React 15.5, but this should help along the way.

Shortly tested on local.
LGTM!


Optionally disable compile-time probing

Sometimes, it is not necessary to probe SQL statements during compilation. I suggest to allow optionally disable it to avoid extensive warning logs, which might be a bit disturbing and confusing.
Related to #108, where (optional) database evolution applies on runtime during application start, which is after the compilation. In consequence, we might compile against obsolete or non-existing schema.

Sounds good, would a config be a good solution?
mySource.queryProbing=false

I guess so but I'm not sure. I'm not much familiar with compilation classpath so I am not sure where to put the config file, especially when Play prefers to have everything under conf/. Personally, I think the simplest solution would be to disable it through build.sbt, e.g., read it using System.property and pass it to the compiler as scalacOptions.
But again, not an expert.

Having a queryProbing optional config option is the most consistent approach. You can set the variable unmanagedClasspath in Compile to point to the path which contains the config files you want to have in the classpath at compile time, and it will work :)

@KarelCemus quick question: you mention extensive warning logs. How many do you get when the query probing isn't working? It should generate a single warning.

if the config file is not in the classpath at compile time, you can't fine the session configuration and you get a pretty big stacktrace.

I see, the problem is the long stack trace. I'll try to reduce it as well.

Exactly, thanks @lvicentesanchez .
@fwbrasil Thanks for the fix

@KarelCemus @lvicentesanchez in your opinion, should the  queryProbing be enabled or disabled by default?

imo enabled by default, I want to know asap when a query is wrong.
On 25 Jan 2016 20:57, "Flavio W. Brasil"<EMAIL_ADDRESS>wrote:

@KarelCemus https://github.com/KarelCemus @lvicentesanchez
https://github.com/lvicentesanchez in your opinion, should the
queryProbing be enabled or disabled by default?
—
Reply to this email directly or view it on GitHub
https://github.com/getquill/quill/issues/122#issuecomment-174660558.

I also think that leaving it enabled by default is better. I'm going to merge https://github.com/getquill/quill/pull/129 once the build passes.

I would prefer to have it disabled by default. I do not know how develop others but 1) I would not assume complex and set up environment (up-to-date db) by default, 2) I may use CI without database, 3) some approaches such as Play evolves DB on start up, etc. In consequence, I'd prefer the simpler and less error-prone set up to have hello world running with the least errors as possible. Anyway, I don't mind when I can turn it off.

@KarelCemus I see, let's keep it enabled for default for now. We can revisit this decision in the future.

Just for anyone using intellij > Preferences -> Build, Execution, Deployment -> Compiler -> Scala Compiler -> Scala Compile Server - add to JVM options:  -Dquill.macro.log=false


[spi_device/dv] Update scoreboard to track dynamically-updated status registers

Description
This is a DV companion issue to #20754. When the SPI domain begins updating status registers at every byte beat (8th posedge of SPI clock), the Read Status command will no longer return a static value. Consequently, validation of Read Status commands will need to be updated to support tracking changes that occur at every byte beat.
The design PR will initially disable this section of the code: https://github.com/lowRISC/opentitan/blob/efc45b71517e6a504f4ca86478b643118bcd3797/hw/ip/spi_device/dv/env/spi_device_scoreboard.sv#L587-L593
In addition, the core clock (sys_clk) domain will continue to update its view only at CSB de-assertion time. As a result, the scoreboard's current strategy of using csr_rd() to determine the resolved value (of software and hardware updates at commit time) will no longer work. latch_flash_status() currently represents what happens to both the SPI domain source-of-truth and the sys_clk domain's view, but the update rate for these two domains is no longer the same.
Note that the passthrough gate's "view" of the BUSY bit also continues to only update at CSB de-assertion time.
Here's a list of timings to keep in mind:

(byte beat) SPI domain commits a newly-resolved flash status register value.
(byte beat) The latest committed value of the flash status register is prepared for the next response byte for any ongoing Read Status command.
(CSB posedge) The current value of the BUSY bit becomes the committed value for the passthrough gate enable.
(CSB posedge) Delayed by a synchronizer, the core clock domain picks up the current value of the flash status register.

This ticket can now be closed since the flash_status TB changes have now been merged in master in PR #22763


Release v3.0.1

Proposed changes

Moved quick start to readthedocs
Download deployment assets from the public url rather than using Github's GraphQL API

Types of changes

[x] Bugfix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[ ] Refactor (changes to code, which do not change application behavior)

Checklist

[x] I have filled out this PR template
[x] I have read the CONTRIBUTING doc
[ ] I have added automated tests that prove my fix is effective or that my feature works
[ ] I have added necessary documentation (README.md, inline comments, etc.)
[x] I have updated the CHANGELOG.md under a ## next release, with a short summary of my changes

Relevant Links

Further comments

@joshmarsh -- you mentioned offline that this would resolve https://github.com/Optum/dce/issues/209
Can you provide more details? What's the deal with those s3 policies, and how does this release fix it?

Good clarifying question, and it looks like there may actually be a deeper issue here.
This release solves the issue of the Github v4 API requiring a personal access token to download deployment artifacts, and I suspect that’s what caused the failure that lead to https://github.com/Optum/dce/issues/209 being noticed.
I don’t have an answer right now, so let’s mark this as a bug and revisit it after https://github.com/Optum/dce-cli/pull/59 is merged. As a cursory observation, I don’t see the MalformedPolicy error present in the deployment logs from https://github.com/Optum/dce-cli/pull/59.


Allow to fetch all users followers (same as following)

Just found that it is not possible to get list of all followers, but you can get all followings.
I implemented it in the same way as for followings.
Is it intended or not?

Good job!


Support mnemonic seed phrase

If I will ever change my npub or have to create a new nostr account I would like it to be derived from a mnemonic seed phrase. My new app also generates a seed phrase instead of a single nsec. It would be nice if users could migrate it to Amber so they can reuse it for other apps.
Related nip: https://github.com/nostr-protocol/nips/blob/master/06.md

https://nosta.me/ also uses mnemonics

Added in the latest beta release


Bug: Typo in the NotifyMe file

Here is a Typo: https://github.com/atapas/notifyme/blob/6574cbe72ca9eb584e144ef77b3a5fc522796a4e/NotifyMe.js#L203
It should have a proper proptype validation but it says prototype.

is this issue solved ?? can i work on it ??

is this issue solved ?? can i work on it ??

Assigned

but it doesn't have static folder ,public folder many things are missing

how to work on it
??

You can make the code changed and test it along with a basic create react app instance. @SankalpaFernando do you want to put more info how you tested your earlier PR changes?

@Padmanabh82 I used a react template that was created by using create-react-app and then I created a folder called notifyme inside /src folder and inside notifyme folder I initiated an empty git repository and pulled the forked repository into the empty repository. Then for the testing, I imported the NotifyMe component from NotifyMe.js to index.js in my react-template.

Hi @Padmanabh82 , I see the issue has been fixed by @SankalpaFernando as part of issue # 22. Hence I will be closing this one. Please feel free to pick up anything from here of from https://github.com/atapas/webapis-playground repo.


Update rooms-lifecycle-support.md

We appreciate any feedback that improves the content in the Microsoft docs but we haven't had any response from you so we are going to close this issue.
Please feel free to re-open this issue if there is a specific area of the docs that we can improve or make better. Thank you.


fix(TDI-45852):fileIO support header for read

What is the current behavior? (You can also link to an open issue here)
https://jira.talendforge.org/browse/TDI-45852
What is the new behavior?
Please check if the PR fulfills these requirements

[ ] The commit message follows Talend standard
[ ] Tests for the changes have been added (for bug fixes / features)
[ ] Docs have been added / updated (for bug fixes / features) ?
[ ] The code coverage on new code >75%
[ ] The new code does not introduce new technical issues (sonar / eslint)

What kind of change does this PR introduce?

[ ] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build / CI related changes
[ ] Other... Please describe:

Does this PR introduce a breaking change?

[ ] Yes
[ ] No

If this PR contains a breaking change, please describe the impact and migration path for existing applications: ...
Other information:

Pull request test result: failure :x:

Pull request test result: failure :x:

Pull request test result: success :star:

Pull request test result: success :star:


decouple.UndefinedValueError: SECRET_KEY not found. Declare it as envvar or define a default value.

I am getting this error, while i was deploying my project to AWS ec2 . In my local server it works fine, any suggestions?

hey @harshhes
Make sure that you have a .env file with your secret_key set in your ec2 machine.
It's quite common to add you .env file to .gitignore so it doesn’t get in the production machine.

Hey @hugopenna , Thank you for responding, i can't thank you enough for solving this for me. That was so silly of me to not put .env file in my ec2 Instance, i was roaming around all internet for this.

No worries, I did that myself a bunch of times.

@henriquebastos @lucasrcezimbra may you close this issue?