[Feature] Snackbar – Update default offset to assume nav bar

Description of Change

Updates default offset to match app and assume there is a nav bar present. Values copied from va-mobile-app's standardTheme.ts.
Also adds util to check for iOS devices with home buttons and adjust offset depending on that.
Default offset will eventually be replaced by a global setting that can be adjusted.
In regards to the safe areas, based on my research, nesting multiple  or using  within s is not recommended. The mobile app already has a SafeAreaProvider so we won't include it here but made note of it in the docs.
Testing Packages

0.21.1-alpha.11
0.21.1-alpha.12
0.21.1-alpha.13

Screenshots/Video

DS snackbar vs App Snackbar (iOS)

DS snackbar vs App Snackbar (iPhone SE with home button)

DS snackbar vs App Snackbar (Android)
Testing

[x] Tested on iOS
[x] Tested on Android
[x] Tested on Web

PR Checklist
Code reviewer validation:

General

[x] PR is linked to ticket(s)
[x] PR has changelog label applied if it's to be included in the changelog
[x] Acceptance criteria:

All satisfied or
Documented reason for not being performed or
Split to separate ticket and ticket is linked by relevant AC(s)

[x] Above PR sections adequately filled out
[x] If any breaking changes, in accordance with the pre-1.0.0 versioning guidelines: a CU ticket has been created for the VA Mobile App detailing necessary adjustments with the package version that will be published by this ticket

Code

[x] Tests are included if appropriate (or split to separate ticket)
[x] New functions have proper TSDoc annotations

Publish

If changes warrant a new version per the versioning guidelines and the PR is approved and ready to merge:

[ ] Merge main into branch
[ ] Merge branch to main
[ ] Verify that Check Component Integrations workflow ran successfully
[ ] Publish new version after merging

Since we know the app is using react-native-safe-area-context decided to leverage that instead and provider a helper provider for apps not using it.

Created a new hook useSnackbarDefaultOffset() which uses useSafeAreaInsets() bottom inset to determine default offset
Fixed Android offset so it's the same as iOS
Add <SnackbarWithSafeArea/> convenience provider for apps that don't have a <SafeAreaProvider/>
Remove hasHomeButton() util

I assume by the time another app is using our lib, we will have figured out native code by then and could switch to using react-native-device-info or similar libs to check for home buttons.

Addressed nits
Putting react-native-safe-context as a dependency caused a conflict and crash within the app. Put it in peerDependencies instead
Added isAndroid() check to the tabIndex for the Snackbar container props to avoid TS error when running in app on iOS
Bumped mobile-tokens in peerDependencies since the new color token from 0.14.0 is needed in Snackbar
Keeping hooks separated. I think I tried this initially but was getting a circular dependency warning


Highlight not applied for last character

As shown in the above image, There is a last character to which the highlight isn't applied to. Moreover, it seems to apply some other color. This color doesn't show up when navic is removed. I have set bg for all highlights mentioned in the readme as black.

Can you share which statusline plugin are you using?
Also share the output of set statusline?

I'm using lualine along with navarasu/onedark.nvim theme.
Output of set statusline:
statusline=%{%v:lua.require'lualine'.statusline()%}

Hey!
Are you still facing this issue? Try keeping only nvim-navic as a component in lualine and then see if it is occuring?
What is the output for lua require'lualine'.statusline() ?

This still happens for me. I tried deleting all components after nvim-navic (so it is the only component on the line) and it still appears.

I'm seeing this issue as well with lualine. It seems related to the padding. I have temporarily fixed this by applying a 0 padding on the right side after the navic output:
lualine_c = {
    { 'filetype' },
    { 'filename' },
    {
        navic.get_location,
        cond = navic.is_available,
        padding = { left = 1, right = 0 },
    }
}

issue is apparent specially on slanted styles

Sorry for being so late, but I looked into this... And yep, its an issue with how lualine is handling the padding. For some reason it is applying incorrect colour for the space character in padding. Should be issue on lualine's repo.


Update zh_cn.lang

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

Thanks for the contribution!
Please sign the CLA. I'll review the changes when I have time.

Closed in favor of your newer PR https://github.com/thexaero/xaero-minimap-translations/pull/21


Fix duplicate field schema generation to respect casing

Fix the duplicate field schema generation to respect casing
Add unit tests
fixes GH-1519

Thumbs up from me, but I'll need to watch this when it hits the 4.0 codebase. Really wish folks wouldn't do this kind of thing.


more bugs in feature includes

related to handling include.objectid with / in it.
with / can be relative link or external link, so the value should be put through | relative_url (this doesn't mess up full urls, but fixes relative paths), and should use capture as well I think.
the second if doesn't need other weird reasoning, just needs to put object_locations | relative_url handles all possiblities

also lots of -gh specific youtubeid and filename stuff still in there

starting fixes in includes-bugs


Build fails on i386 and armv7: non-constant-expression cannot be narrowed from type 'unsigned long long' to 'size_t'

[ 76% 55/71] /usr/bin/c++ -DDMLC_LOG_CUSTOMIZE=1 -DXGBOOST_BUILTIN_PREFETCH_PRESENT=1 -DXGBOOST_MM_PREFETCH_PRESENT=1 -D_MWAITXINTRIN_H_INCLUDED -I/wrkdirs/usr/ports/misc/xgboost/work/xgboost-1.7.1/include -I/wrkdirs/usr/ports/misc/xgboost/work/xgboost-1.7.1/dmlc-core/include -I/wrkdirs/usr/ports/misc/xgboost/work/xgboost-1.7.1/rabit/include -O2 -pipe -fstack-protector-strong -isystem /usr/local/include -fno-strict-aliasing  -isystem /usr/local/include -O2 -pipe -fstack-protector-strong -isystem /usr/local/include -fno-strict-aliasing  -isystem /usr/local/include  -DNDEBUG -fPIC -funroll-loops -pthread -std=gnu++14 -MD -MT src/CMakeFiles/objxgboost.dir/predictor/cpu_predictor.cc.o -MF src/CMakeFiles/objxgboost.dir/predictor/cpu_predictor.cc.o.d -o src/CMakeFiles/objxgboost.dir/predictor/cpu_predictor.cc.o -c /wrkdirs/usr/ports/misc/xgboost/work/xgboost-1.7.1/src/predictor/cpu_predictor.cc
FAILED: src/CMakeFiles/objxgboost.dir/predictor/cpu_predictor.cc.o
/usr/bin/c++ -DDMLC_LOG_CUSTOMIZE=1 -DXGBOOST_BUILTIN_PREFETCH_PRESENT=1 -DXGBOOST_MM_PREFETCH_PRESENT=1 -D_MWAITXINTRIN_H_INCLUDED -I/wrkdirs/usr/ports/misc/xgboost/work/xgboost-1.7.1/include -I/wrkdirs/usr/ports/misc/xgboost/work/xgboost-1.7.1/dmlc-core/include -I/wrkdirs/usr/ports/misc/xgboost/work/xgboost-1.7.1/rabit/include -O2 -pipe -fstack-protector-strong -isystem /usr/local/include -fno-strict-aliasing  -isystem /usr/local/include -O2 -pipe -fstack-protector-strong -isystem /usr/local/include -fno-strict-aliasing  -isystem /usr/local/include  -DNDEBUG -fPIC -funroll-loops -pthread -std=gnu++14 -MD -MT src/CMakeFiles/objxgboost.dir/predictor/cpu_predictor.cc.o -MF src/CMakeFiles/objxgboost.dir/predictor/cpu_predictor.cc.o.d -o src/CMakeFiles/objxgboost.dir/predictor/cpu_predictor.cc.o -c /wrkdirs/usr/ports/misc/xgboost/work/xgboost-1.7.1/src/predictor/cpu_predictor.cc
/wrkdirs/usr/ports/misc/xgboost/work/xgboost-1.7.1/src/predictor/cpu_predictor.cc:167:24: error: non-constant-expression cannot be narrowed from type 'unsigned long long' to 'size_t' (aka 'unsigned int') in initializer list [-Wc++11-narrowing]
    size_t non_missing{beg};
                       ^~~
/wrkdirs/usr/ports/misc/xgboost/work/xgboost-1.7.1/src/predictor/cpu_predictor.cc:167:24: note: insert an explicit cast to silence this issue
    size_t non_missing{beg};
                       ^~~
                       static_cast<size_t>( )
1 error generated.

Version: 1.7.1
clang-14
FreeBSD 13.1

See https://github.com/dmlc/xgboost/issues/9035#issuecomment-1578016136. We decided that XGBoost 2.0+ will not support 32-bit systems.

What is the latest version of XGBoost that supports 32bits architectures ?

We made a fork with a release 1.7.6 compatible with 32-bits architectures : https://github.com/FleksySDK/xgboost/tree/v<IP_ADDRESS>b

Actually, 2.1 builds with 32bit machine for support web assembly. But we don't run the test suite with 32bit machine.


Integration with Vite

Now that more and more vite is being used, is integration possible?

Mmh is there anything new about this in the meantime? 😶

@karolisdailidonis I don't think we're getting this.  vite is made to work on the web, which makes integrating vite quite difficult.  What we may see is Rspack!! https://twitter.com/ScriptedAlchemy/status/1618059819138822146?t=l8KOLVi39fDyCqemJLc7QA&s=19

Hey @vallemar , I think it is possible to support Vite. Here is a discussion link I found in the react-native-web repo :smile:

now vite 6 have the new environment API, I think move to vite now is easier


is it possible to use oc instead of kubectl while doing kedge create/apply ?

I am running kedge apply -f filename and facing following error.
failed to execute command: failed to execute command: exec: "kubectl": executable file not found in $PATH
yes, I do not have kubectl installed, but is it possible to use oc here?

If the end user does not want to install kubectl binary and wants to use kedge create/apply/delete commands using oc, one hack is to alias kubectl to oc, and it should work.
Later on, when we'll be moving to client-go for Kubernetes and OpenShift, then these binaries won't be required.
However, this is somewhere the end user experience breaks and flags like --provider kubernetes/openshift or --use-oc true/false could help.
ping @kadel, WDYT?

I think we should fallback to oc if kubectl not found in path, if nothing found then error out!

Also oc can create all objects that kubernetes supports.
I was doubtful of ingress but tried that and it worked:
$ kedge generate -f . | oc create -f -
service "database" created
deployment "database" created
service "wordpress" created
ingress "root-ingress" created
deployment "web" created

I think we should fallback to oc if kubectl not found in path, if nothing found then error out!
👍 2

Agree this might be the best way how to do that right now.

I am running kedge apply -f filename and facing following error.
failed to execute command: failed to execute command: exec: "kubectl": executable file not found in $PATH
yes, I do not have kubectl installed, but is it possible to use oc here?

@pranavgore09
Are you creating any OpenShift objects, like  DeploymentConfig? Or just Deployment?

TASK:
Kedge should fallback to oc if kubectl is not found in path. If oc is not found either then error out!

As it's already mentioned in the kedge-docs, mentioning the controller should ideally be good enough (given, the values were intuitive enough to express the container orchestrators) to invoke the correct tool for the purpose.
I agree, that on a system that has either kubectl or oc then it's best to not complain about not finding the controller (as long as it's not specifically mentioned) and fall back to the other; but, it should still regard the specific controller selection for hosts which has both kubectl and oc setup, but wants to use specific one of them for a particular purpose.

Yes, controller should still be primary indicator.
Only problem is when someone uses OpenShift but and deploys Deployment or Jobs on it. And they don't have kubectl installed as they don't need it.
For this, we should fallback to oc if kubectl is not found.  But only this. Kedge can never do fallback in other direction from oc to kubectl.

The error that is produced due to this "fix" is misleading. In the absence of kubectl the error states: "failed to execute command: Unable to find oc command. Please install oc to your system"
How is this any better? This is just persisting the problem if a user (of which there are many) does not use OpenShift or know what 'oc' is. This is particularly true if kedge is being used in varying CD environments.
This is not an issue at all. The error message clearly states that kubectl is missing from PATH. I don't see this as a bug and I'm not sure why oc was even introduced, especially given that you're now going from a general cli to a specific one.


fix: Modified action execution endpoint

Fixes #8431
Fixes #9395
Test coverage results :test_tube:
:red_circle: Total coverage has decreased
// Code coverage diff between base branch:release and head branch: fix/binary-data-for-exec

Status
File
% Stmts
% Branch
% Funcs
% Lines

:red_circle:
total
55.72 (0)
37.05 (-0.01)
35.79 (0)
56.08 (0)

:green_circle:
app/client/src/sagas/ActionExecution/PluginActionSaga.ts
18.68 (0.08)
2.5 (0.02)
11.11 (0)
21.36 (0)

:red_circle:
app/client/src/utils/autocomplete/TernServer.ts
52.71 (-0.23)
40.83 (-0.84)
36.21 (0)
56.74 (-0.25)

/ok-to-test sha=c8c2d03

/ok-to-test sha=c8c2d03

/ok-to-test sha=80cb672

/ok-to-test sha=425bfb6

/ok-to-test sha=0a54aeb

/ok-to-test sha=0a54aeb


Feature Sync Feedback

Created SyncFeedback element
Added examples
Added unit tests

Codecov Report

Merging #77 into master will not change coverage.
The diff coverage is 100%.

@@          Coverage Diff          @@
##           master    #77   +/-   ##
=====================================
  Coverage     100%   100%
=====================================
  Files         101    103    +2
  Lines        2317   2373   +56
  Branches      517    528   +11
=====================================
+ Hits         2317   2373   +56

Impacted Files
Coverage Δ

src/components/syncFeedback/SyncFeedback.spec.tsx
100% <100%> (ø)

src/components/syncFeedback/SyncFeedback.tsx
100% <100%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 24df35f...b651d87. Read the comment docs.


Properly handle timezones (fixes #598)

Orignally this was done using time.mktime and datetime.timetuple but these
functions don't properly handle timezones:

dt.timetuple creates a time_struct while completely ignoring the timezone of
the datetime.
time.mktime assumes the time_struct to be in local time, e.g. whatever the
machine has set as timezone.

This would end up in bad timestamps when either the machine runs in a different
timezone or the datetime is in a different timezone than UTC.
Also included is a UTC tzinfo so that datetimes generated by redis-py can be
assigned the correct timezone.

I updated the branch with latest changes from master (awesome work the everyone did for on 3.0!) as I still think this is a relevant change. I can see how this change can break backwards compatibility for people who expect it to use local time. If the change as it stands can not be accepted for that specific reason, perhaps we can talk about different methods of implementation. For example: an opt-in argument than can be passed to the Client that triggers UTC usage everywhere and checks that datetimes passed to methods on the Client are always 'aware'.


Rename createRoot & createBlockingRoot  to unstable_createRoot & unst…

[concurrent mode docs] Rename createRoot & createBlockingRoot with unstable_createRoot & unstable_createBlockingRoot with refrence to latest changes in experimental apis in pr
https://github.com/facebook/react/pull/18825
also closes https://github.com/reactjs/reactjs.org/issues/2960#issue-614500217

Issue Number: 2960

Hmm why didn't CI trigger a website build..

It's not just createRoot, there's also useTransition, etc. It gets pretty noisy if you add it everywhere in the docs.
I think what we should do instead is to add a new section that explains each export is behind unstable_. And has a map of them.

It's not just createRoot, there's also useTransition, etc. It gets pretty noisy if you add it everywhere in the docs.
I think what we should do instead is to add a new section in Adopting that explains each export is behind unstable_. And has a map of them.

but still the code examples would need unstable_ as it would be ambigious if unstable is omitted from code examples. i'll create a new pr with separate section explaining unstable


Using 'Check Met' button on application throws forbidden message

In gitlab by @bjoplin on Aug 31, 2016, 09:18
On this application:
https://core.vatsim-uk.co.uk/adm/visit-transfer/application/4
Selecting 'Mark this check met' button redirects to the following page which states 'Forbidden'
https://core.vatsim-uk.co.uk/adm/visit-transfer/application/4/check/met

In gitlab by @bjoplin on Aug 31, 2016, 09:19
Happens on all applications attempted so far

In gitlab by @A-Lawrence on Aug 31, 2016, 13:42
mentioned in commit d67cc86affa4fbf41c766f1c575232e1b317b51f

In gitlab by @A-Lawrence on Aug 31, 2016, 13:42
mentioned in commit 34b0164dd8882933bec9a94d30082ee8f380d849

In gitlab by @A-Lawrence on Aug 31, 2016, 13:44
Status changed to closed by commit d67cc86affa4fbf41c766f1c575232e1b317b51f


Week starting day

I read documentation but couldn't find this option. How can I set Monday as a first day of week instead of Sunday?

For the moment, the only way to configure the first day of the week, is to change it manually in the language file: weekStart option (or maybe in your case, use the right language file)
I will add an option to configure it at runtime.


can't add new articles

details
from the app
It seems there's no way to add an article from the app itself, like a + button or "add url" from the top left menu
from sharing function

Open the broswer (firefox, brave, etc)
Visit any page you like
Share it with frigoligo

actual behaviour
Now frigoligo opens but nothing is added to the articles list
expected behaviour
The article is added to wallabag
device info
eOS (android 13)
Samsnung a52q

The feature to add an article from inside the app is currently worked on and will be available in the next version. See #198.
I can reproduce the issue with the sharing function, this is a bug. I'll work on a fix as soon as possible.

The 2 issues are addressed by #198 and #200 that will by shipped in the next release. Hopefully in a few days.

Released in https://github.com/casimir/frigoligo/releases/tag/v1.1.0


cosmetic:  version of DSM and vDSM is 7.1 not 7.2

hello, i tried your virtual-dsm and it is working very nice.
One item i would like to note is that the version of DSM and vDSM is not 7.2 as mentioned in the readme.md
A docker container of Synology DSM v7.2 using KVM.
but version 7.1 shows on the big blue welcome screen and DSM 7.1.1-42962 in the InfoCenter respectively.
This also matches the latest version of vDSM i can find from synology, 7.1.1:
https://www.synology.com/en-us/support/download/VirtualDSM

Indeed, but updating to 7.2 beta is poss, did it yesterday without issues.


Add missing license header.

Codecov Report

:exclamation: No coverage uploaded for pull request base (develop@09d3e63). Click here to learn what that means.
Patch has no changes to coverable lines.

Additional details and impacted files
@@            Coverage Diff             @@
##             develop      #62   +/-   ##
==========================================
  Coverage           ?   85.61%
==========================================
  Files              ?       20
  Lines              ?     1265
  Branches           ?        0
==========================================
  Hits               ?     1083
  Misses             ?      182
  Partials           ?        0

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.


Please Document Error 7000218

Getting this error: AADSTS7000218: The request body must contain the following parameter: 'client_assertion' or 'client_secret'.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: fa732de6-2cab-d780-aa21-dfec80e0a8fe
Version Independent ID: 1a11b9b6-cf4f-3581-0864-0d5046943b6e
Content: Sign-in activity report error codes in the Azure Active Directory portal
Content Source: articles/active-directory/reports-monitoring/reference-sign-ins-error-codes.md
Service: active-directory
GitHub Login: @priyamohanram
Microsoft Alias: priyamo

@chaddaignault Thank you for your feedback . We will have this checked and update the thread.

@chaddaignault The error 70002 described as The application returned invalid client credentials. Contact the application owner. pertains to the same error. The error code is not exact but its the same .

@chaddaignault We will now close this issue. Please tag me to your reply in case you have any further query . In case its something unrelated to this thread , please open a new issue and we will help you with the same.


Run tests using threads via at-include_foreach

https://github.com/tkf/PerformanceTestTools.jl/pull/11

Codecov Report

Merging #211 into master will decrease coverage by 1.37%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master     #211      +/-   ##
==========================================
- Coverage   92.41%   91.03%   -1.38%
==========================================
  Files          19       19
  Lines        1279     1272       -7
==========================================
- Hits         1182     1158      -24
- Misses         97      114      +17

Impacted Files
Coverage Δ

src/basics.jl
66.66% <0.00%> (-19.05%)
:arrow_down:

src/reduce.jl
80.48% <0.00%> (-12.29%)
:arrow_down:

src/progress.jl
87.23% <0.00%> (-2.13%)
:arrow_down:

src/core.jl
90.24% <0.00%> (-1.22%)
:arrow_down:

src/unordered.jl
95.83% <0.00%> (-0.33%)
:arrow_down:

src/show.jl
95.00% <0.00%> (-0.05%)
:arrow_down:

src/library.jl
94.47% <0.00%> (+0.22%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 40e4df4...b98a2aa. Read the comment docs.

Codecov Report

Merging #211 into master will decrease coverage by 1.37%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master     #211      +/-   ##
==========================================
- Coverage   92.41%   91.03%   -1.38%
==========================================
  Files          19       19
  Lines        1279     1272       -7
==========================================
- Hits         1182     1158      -24
- Misses         97      114      +17

Impacted Files
Coverage Δ

src/basics.jl
66.66% <0%> (-19.05%)
:arrow_down:

src/reduce.jl
80.48% <0%> (-12.29%)
:arrow_down:

src/progress.jl
87.23% <0%> (-2.13%)
:arrow_down:

src/core.jl
90.24% <0%> (-1.22%)
:arrow_down:

src/unordered.jl
95.83% <0%> (-0.33%)
:arrow_down:

src/show.jl
95% <0%> (-0.05%)
:arrow_down:

src/library.jl
94.47% <0%> (+0.22%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 40e4df4...b98a2aa. Read the comment docs.


How To Install & Run On Mac For Newbies

I would love to be able to use your NextAction script since I'm a hard core Todoist user. However, I know nothing about python or code. Could you provide step by step instructions for a someone who doesn't know anything about this stuff?
I downloaded Python, but don't know what to do.
Thanks in advance and thanks for making this. I hope I can put it to use.

Same here. Would be great to have the NextAction function in Todoist, since this is a key feature of GTD, right?

Yes, documentation for installation is a seriously lacking feature at the moment. Essentially:

Python comes pre-installed with OSX, no further packages are needed
Download and extract the zip
From the extracted directory run sudo python ./setup.py install
The nextaction command should now be available to you to use as per the normal documentation.

This is by no means the best way to install this, but its a workable solution. Ideally this should be installed on a system that is available all the time to keep your Todoist up to date.


Misc net fixes

Fixes to various part of the IP stack while working on #980

Updated according to comment.


Printer status blank if translation not available

In Listings > Printers, "Printer Status" field is translated, and if translation is not available, it prints an empty string. It should preferably just print untranslated status instead.

Fixed wit PR #689


Add support for xdoctest

Description
Now that #3857 is merged, we can add support for xdoctest for testing doctests.
Xdoctest is a pytest equivalent to python's build-in doctest. See more : https://github.com/pybamm-team/PyBaMM/issues/3617#issuecomment-1854702640
Related to : #3617

Hi, @prady0t – are you already on this? Let us know if you are, and one of us can assign you to it

Yes please assign this to me


Make generateUUID() async

The change is propagated from resin-io/resin-register-device. See
commit:
https://github.com/resin-io/resin-register-device/commit/e1858f00d8659f5ae8fcb07f6dcd245a217e1bcc

LGTM


vs code 启动程序报错

无法启动！！！

我尝试在 配置文件中添加
"terminal.integrated.shell.windows": "C:/Windows/System32/cmd.exe",
但还是无效的

The terminal cannot be started properly. Switching terminal.integrated.shell.windows to  C:/Windows/System32/cmd.exe doesn't help.

thank you！Finally choose to reinstall the software to solve


Improve in-air behavior for crouch and slide jumps

This is a little prescriptive to what I found "feels right", but in response to #79, I've modified how crouch and slide jumps feel and look.
In #79, @ksjfhor found that un-crouching mid-air would look as though there's a sudden upwards velocity to exactly where you'd expect the jump to be if you had done it standing. It is merely a visual effect from the camera moving from the crouched height to the standing height, the jump is functionally exactly the same. The only thing that changes is the camera height, and the collision to make collisions consistent with what the player is seeing.
I personally find this behavior makes for consistent functionality both as a player and as a dev trying to find the right game feel. When crouch jumping, the characters feet comes off the ground by exactly the same amount whether crouched or standing.
To address the visual jitter, I made it so you can't change your standing/crouching state visually whilst jumping. This feels a little prescriptivist, but I think is the neatest solution for right now with minimal compromise in terms of actual game functionality and feel. If you're making a parkour game however, you may find you need to alter this behavior with a custom solution to resolve this, but that likely would've been the case anyways.
I also changed the in-air behavior. If you're crouched and in-air, you will consistently have the crouch movement speed, unless you're jumping from a slide. If you're slide jumping, your character will largely be registered as being in the "standing" state, which also includes having the camera in the standing state.
I've added 2 parameters for devs to be able to dial in their game feel:
CROUCH_JUMP_VELOCITY - what force your jump should have if crouch jumping
SLIDE_JUMP_MOD - modifier to how strong your jump is coming from a slide

I saw they were still recent commits, so I held off. Let me know when I can review.

You're all set to review actually, just wrapped it up. The more recent commits were minor addendums to the overall PR.

Gave this a test and noticed that when I sprint > crouch > jump, I leap higher than with a regular jump (see video).
I'd qualify this as unexpected behavior.
https://github.com/Phazorknight/Cogito/assets/70389309/53acb499-f35a-435e-8c9f-27c911f90ac3

So, how would you like that to be handled?
That's the slide jump modifier, which I've not changed the factor of, just split it out into its own variable SLIDE_JUMP_MOD. If you change that to 1.0, you'll get normal jump height on doing this.
The reason it's higher than without this branch is I've made it so slide jumps put you into standing mode. I can make it so you stay at crouched height instead visually, though ultimately you're still coming off the ground higher than a regular jump.

Oh, apologies, I didn't realize this was an intended modifier. That's what I get for rushing.
Changing the modifier did what you said and I was able to get the expected behaviour.
Will finish my review after lunch.


Altona: Cannot detect new peers upon restart

Describe the bug
After we initialize a beacon folder and sync Altona, we can always detect peers very quickly. But upon a restart, sometimes we can detect peers, sometimes we cannot and we end up with setting up a new beacon folder by beacon run init.
Expected behavior
We can detect new peers at any time

This is an issue of discv5 since it never emit a "peer" event to libp2p. When we send random requests to peers, most of them do not response us except for 1-2 peers with below log:
discv5:service Sending lookup. Id: 1, Iteration: 1, Node: 13027eca868692747ffd93324fbf38f4d1f435d4d950ed92b326138b3c862eb8 +1ms
  discv5:sessionService No session established, sending a random packet to: 13027eca868692747ffd93324fbf38f4d1f435d4d950ed92b326138b3c862eb8 on /ip4/<IP_ADDRESS>/udp/5000 +1ms
discv5:sessionService Sending authentication message: { type: 3, id:<PHONE_NUMBER>140610451n, distance: 255 } to node: 13027eca868692747ffd93324fbf38f4d1f435d4d950ed92b326138b3c862eb8 on /ip4/<IP_ADDRESS>/udp/5000 +1ms
discv5:sessionService Message timed out with node: 13027eca868692747ffd93324fbf38f4d1f435d4d950ed92b326138b3c862eb8 +237ms

The above node/peer did response us with WhoAreYou message and we response back with an authentication message. However, handshare stops from then and then it's timed out.

do you have any ideas @wemeetagain ?

Not sure :thinking: I've also seen lots of immediate disconnections from peers we do find.

Lighthouse peers ban us for 30s after we send goodbye request

So that might be disconnects

This happens regularly even through I leave it hours before I restart.
One of the issue is https://github.com/ChainSafe/lodestar/blob/master/packages/lodestar/src/sync/reqResp/reqResp.ts#L68
On start, the getPeers() only returns peers which have connection while initially we have no connection so it returns no peer.
I tried to get all peers without the connections and do a connect/dial but got ECONNREFUSED error (even thru the peerStore already have multiaddrs for those peers as I can see ip address and port), don't know why.

If we don't save ENR in run.ts, this issue does not happen and we can always detect peers upon a restart so it's always good with a fresh enr.json file.
This is what's logged for a fresh enr.json
  discv5:sessionService No session established, sending a random packet to: 98b7a0b9d86ab6d90f30a032bc96385b36d8019c644f39c2e235b48ca1f1ed42 on /ip4/<IP_ADDRESS>/udp/9000 +1ms
discv5:sessionService Sending authentication message: { type: 3, id:<PHONE_NUMBER>36639294n, distance: 255 } to node: 98b7a0b9d86ab6d90f30a032bc96385b36d8019c644f39c2e235b48ca1f1ed42 on /ip4/<IP_ADDRESS>/udp/9000 +14ms
discv5:sessionService Session established with node from updated: 98b7a0b9d86ab6d90f30a032bc96385b36d8019c644f39c2e235b48ca1f1ed42 +267ms
discv5:sessionService Sending request: { type: 1, id:<PHONE_NUMBER>080359569n, enrSeq: 3n } to 98b7a0b9d86ab6d90f30a032bc96385b36d8019c644f39c2e235b48ca1f1ed42 on /ip4/<IP_ADDRESS>/udp/9000 +1m
discv5:sessionService Message received: NODES from: 98b7a0b9d86ab6d90f30a032bc96385b36d8019c644f39c2e235b48ca1f1ed42 on /ip4/<IP_ADDRESS>/udp/9000 +1ms

This is what's logged for a modified enr.json which does not work:
discv5:sessionService No session established, sending a random packet to: 98b7a0b9d86ab6d90f30a032bc96385b36d8019c644f39c2e235b48ca1f1ed42 on /ip4/<IP_ADDRESS>/udp/9000 +1ms
discv5:sessionService Sending authentication message: { type: 3, id:<PHONE_NUMBER>072610744n, distance: 251 } to node: 98b7a0b9d86ab6d90f30a032bc96385b36d8019c644f39c2e235b48ca1f1ed42 on /ip4/<IP_ADDRESS>/udp/9000 +2ms
discv5:sessionService Message timed out with node: 98b7a0b9d86ab6d90f30a032bc96385b36d8019c644f39c2e235b48ca1f1ed42 +210ms

We can see that the same node 98b7a0b9d86ab6d90f30a032bc96385b36d8019c644f39c2e235b48ca1f1ed42 did reply authentication message of a freshenr.json but did not do that for the modified enr.json, so there's probably an issue with authentication message after we save to enr.json.
The surprise thing is it does not always happen for every modified enr.json file. If I immediately restart my node, the enr.json is modified but it still can detects new peers. But it seems that if I leave my .altona folder for about 2h then restart, it can't detect new peers...

I think I found the root cause, open an issue in discv5 https://github.com/ChainSafe/discv5/issues/72


Add hyphen to mention of layout type

Big change, this one. 😛 Spotted a tiny inconsistency in the Layout guidance when I looked it up to help with reviewing a footer PR.

Nice one! I thought we caught the last of these.

@calvin-lau-sig7 Ta for review!


Support for Custom Attribute Naming with Non-camelCase Variables

Is your feature request related to a problem? Please describe.
I am currently using the Zeebe.Client.Accelerator package for my C# project,. The package automatically deserializes the TInput object into an array of fetch variables. However, I've encountered an issue with variable naming conventions. While the official camunda documentation allows the usage of camelCase, PascalCase, and snake_case for variable names, the Zeebe.Client.Accelerator package only supports camelCase. This limitation is causing problems in our integration with camunda, as we need the flexibility to use custom variable names that may not follow the camelCase convention.
Describe the solution you'd like
To address this limitation and enhance the package's functionality, I propose the implementation of a new custom attribute in C#. The custom attribute should be used to decorate C# properties and provide the necessary metadata for mapping these properties to the desired Zeebe variable names. With this attribute, users can specify the exact variable names they want to use, regardless of the variable naming convention.
Expected Behavior:
The package should support custom attribute mapping for properties to allow users to define custom variable names when deserializing TInput into the array of fetch variables. This custom attribute should enable us to map C# property names to custom Zeebe variable names in a straightforward manner.
Example Usage:
public class MyWorkflowInput
{
    [ZeebeVariableName("OrderId")] // Using the custom attribute to map to Zeebe variable "OrderId"
    public string OrderId { get; set; }

    [ZeebeVariableName("ItemList")] // Using the custom attribute to map to Zeebe variable "ItemList"
    public List<string> ItemList { get; set; }

    // Additional properties and their mappings as needed...
}

Addional context
existing mapping to fetchVariables: JobHandlerInfoProvider.GetFetchVariablesFromJobState(Type jobType) - Line: 171

Under the hood this project uses System.Text.Json.JsonSerializer.
A compatible solution would be to use
[JsonPropertyName("MY_Variable_name")]
public string MyVariable { get; set; }

This will indeed need a change in the code when detecting the variables to fetch, but all the rest should work out of box.

Hi @LennartKleymann,
I just released version 1.1.0 which supports JsonPropertyName and JsonIgnore attributes. This should help you to customize your attribute mapping.


Revert "[path_provider_windows] Resolve FFI stabilization changes"

Reverts flutter/plugins#3485 to fix the tree.
Running command: "pub global run tuneup check" in /b/s/w/ir/tmp/t/pluginsFHFRRF/packages/path_provider/path_provider_windows
Checking project path_provider_windows...

  error - The method 'setGUID' isn't defined for the type 'Pointer' at lib/src/path_provider_windows_real.dart:119:57 - (undefined_method)

1 issue found; analyzed 11 source files in 4.0s.

https://logs.chromium.org/logs/flutter/buildbucket/cr-buildbucket.appspot.com/8856572090238051232/+/steps/run_test.dart_for_flutter_plugins_shard_and_subshard_analyze/0/stdout
CC @timsneath @stuartmorgan

I'm confused; the revert introduces the error you say you are fixing.
And from your build log:

! path_provider_windows 0.1.0-nullsafety from path ..
That's the version from before the patch you are trying to revert.

If you are seeing this error in current builds, the most likely explanation is a pub cache on the machine in question that has the older version, in which case the fix is to update the minimum path_provider_windows constraint on path_provider, and then update the minimum version of path_provider.


Simplicity

Simplicity is the ultimate sophistication.

--Leonardo da Vinci

Thank you! Code has decreased a lot.
That's a wise saying! 😆


Fatal error: Theme CSS could not load after 20 sec. Please download the latest theme at http://galleria.io/customer/

On Chrome when hosted, but not on localhost.
Galleria 1.34
JQuery 1.10.2

In case it helps anyone out. I had the same issue @rawtaz had only with 1.4.2. It would show the fatal theme CSS error after 4-5 seconds, but network tools showed the CSS was downloading. I was able to solve it with #369. The browser was rendering the galleria loader at less than a pixel, but the code is looking for $loader.height() == 1


wants to add carousel effect using css

I wanted to add carousel effect written in CSS only. Can you please assign this task to me ?

@shubham-sharma-2323 Add ss or video

@shubham-sharma-2323 Add ss or video

sure will add them in PR

@shubham-sharma-2323 ???? make pr fast

Really sorry @DEEPALI-SUK actually my laptop went on repair and i wasn't able to make PR in the past few days but now i have made the PR for this issue.


Unexpected behaviour when used with GDB --tty on Mac OS X 10.10.3

First of all I want to apologise if the following is not an issue with this project, but I really don't know where to start.
Issue
As the title says, I tried to use the terminals returned by pty.Open() to interact with the target program with GDB. I try to provide a minimal working example that reproduce this issue.
Here's a dummy C program (hello.c):
#include <stdio.h>

int main()
{
    printf("Hello!\n");
    return 0;
}

Here's the Go program (issue.go):
package main

import (
    "github.com/kr/pty"
    "io"
    "os"
    "os/exec"
)

func main() {
    ptm, pts, err := pty.Open()
    if err != nil {
        panic(err)
    }
    println(ptm.Name())
    println(pts.Name())

    ttyName := pts.Name()
    // ttyName := "/dev/ttys000" // taken from $ tty

    gdb := exec.Command("gdb", "--tty", ttyName)

    stdin, err := gdb.StdinPipe()
    if err != nil {
        panic(err)
    }

    if err := gdb.Start(); err != nil {
        panic(err)
    }

    go func() {
        _, err := io.Copy(os.Stdout, ptm)
        if err != nil {
            panic(err)
        }
    }()

    if _, err := stdin.Write([]byte("file ./a.out\n")); err != nil {
        panic(err)
    }

    if _, err := stdin.Write([]byte("run\n")); err != nil {
        panic(err)
    }

    // this is not received by GDB when ttyName := pts.Name()
    if _, err := stdin.Write([]byte("run\n")); err != nil {
        panic(err)
    }

    if _, err := stdin.Write([]byte("quit\n")); err != nil {
        panic(err)
    }

    if err := gdb.Wait(); err != nil {
        panic(err)
    }
}

Now with:
gcc hello.c
go run issue.go

what I get is:
/dev/ptmx
/dev/ttys001
Hello!

then the program is stuck. While if I use a TTY of another terminal as ttyName in issue.go everything seems to work as expected:
$ tty
/dev/ttys000
$ tail -f /dev/null
warning: GDB: Failed to set controlling terminal: Operation not permitted
Hello!
warning: GDB: Failed to set controlling terminal: Operation not permitted
Hello!

And the program exits successfully.
Also, commenting out the second stdin.Write([]byte("run\n")) the program works even with a TTY coming from pty.Open().
System details
$ uname -a
Darwin pacinotti-wifi-219-203.unipi.it 14.3.0 Darwin Kernel Version 14.3.0: Mon Mar 23 11:59:05 PDT 2015; root:xnu-2782.20.48~5/RELEASE_X86_64 x86_64
$ go version
go version go1.4.2 darwin/amd64
$ gdb --version
GNU gdb (GDB) 7.9

If more are needed please do ask.

What about something like this instead:
package main

import (
        "io"
        "os"
        "os/exec"

        "github.com/kr/pty"
)

func main() {
        ptm, pts, err := pty.Open()
        if err != nil {
                panic(err)
        }
        println(ptm.Name())
        println(pts.Name())

        gdb := exec.Command("gdb")
        gdb.Stdin = pts
        gdb.Stdout = pts
        gdb.Stderr = pts
        if err := gdb.Start(); err != nil {
                panic(err)
        }
        go func() {
                _, err := io.Copy(os.Stdout, ptm)
                if err != nil {
                        panic(err)
                }
        }()
        stdin := ptm
        if _, err := stdin.Write([]byte("file ./a.out\n")); err != nil {
                panic(err)
        }
        if _, err := stdin.Write([]byte("run\n")); err != nil {
                panic(err)
        }
        // this is not received by GDB when ttyName := pts.Name()
        if _, err := stdin.Write([]byte("run\n")); err != nil {
                panic(err)
        }

        if _, err := stdin.Write([]byte("quit\n")); err != nil {
                panic(err)
        }
        if err := gdb.Wait(); err != nil {
                panic(err)
        }
}

Nope, the point of using the --tty option of GDB is to separate its own I/O from target program's.

What about this?
For some reason the ptm does not block and yields EOF upon each read. @kr any idea why?
Just keep going upon EOF allows for expected behavior.
package main

import (
        "fmt"
        "io"
        "log"
        "os"
        "os/exec"

        "github.com/kr/pty"
)

func main() {
        ptm, pts, err := pty.Open()
        if err != nil {
                panic(err)
        }
        println(ptm.Name())
        println(pts.Name())

        ptsName := pts.Name()
        go func() {
                for {
                        buf := make([]byte, 1024)
                        n, err := ptm.Read(buf)
                        if err != nil {
                                if err != io.EOF {
                                        fmt.Printf("Err: %s\n", err)
                                        continue
                                }
                        }
                        if _, err := os.Stdout.Write(buf[:n]); err != nil {
                                log.Fatal(err)
                        }
                }
        }()

        gdb := exec.Command("gdb", "--tty", ptsName)
        // gdb.Stdout = os.Stdout
        // gdb.Stderr = os.Stderr

        stdin, err := gdb.StdinPipe()
        if err != nil {
                panic(err)
        }
        if err := gdb.Start(); err != nil {
                panic(err)
        }

        if _, err := stdin.Write([]byte("file ./a.out\n")); err != nil {
                panic(err)
        }

        if _, err := stdin.Write([]byte("run\n")); err != nil {
                panic(err)
        }
        // this is not received by GDB when ttyName := pts.Name()
        if _, err := stdin.Write([]byte("run\n")); err != nil {
                panic(err)
        }

        if _, err := stdin.Write([]byte("quit\n")); err != nil {
                panic(err)
        }

        if err := gdb.Wait(); err != nil {
                panic(err)
        }
}

I tried to manually set the non blocking mode via fcntl without luck, I tried to use select(2) without luck either.

ok, with this C code:
#include <stdio.h>
#include <unistd.h>

int main()
{
  for (int i = 0; i < 10; i++) {
    printf("Hello!\n");
    sleep(1);
  }
  return 0;
}

I found out that the ptm is non blocking only when the pts is not used. Once gdb starts the process, ptm is blocking as expected.

Yes I can confirm that keep reading from ptm works:
go func() {
	for {
		if _, err := io.Copy(os.Stdout, ptm); err != nil {
			panic(err)
		}
	}
}()

But I don't think it's a solution, isn't it?
I also noticed some others weird behaviours. Here I also copy the standard output of GDB to the main program's (***), the result is that the standard output of GDB is shown, while the output of the target program (from ptm) is not. Also in this case keep reading seems to fix; I report also this test case because, though related, it seems a different scenario.
package main

import (
	"github.com/kr/pty"
	"io"
	"os"
	"os/exec"
)

func main() {
	ptm, pts, err := pty.Open()
	if err != nil {
		panic(err)
	}
	println(ptm.Name())
	println(pts.Name())

	ttyName := pts.Name()

	gdb := exec.Command("gdb", "--tty", ttyName)

	stdin, err := gdb.StdinPipe()
	if err != nil {
		panic(err)
	}

	// ***
	stdout, err := gdb.StdoutPipe()
	if err != nil {
		panic(err)
	}

	if err := gdb.Start(); err != nil {
		panic(err)
	}

	go func() {
		if _, err := io.Copy(os.Stdout, ptm); err != nil {
			panic(err)
		}
	}()

	// ***
	go func() {
		if _, err := io.Copy(os.Stdout, stdout); err != nil {
			panic(err)
		}
	}()

	if _, err := stdin.Write([]byte("file ./a.out\n")); err != nil {
		panic(err)
	}

	if _, err := stdin.Write([]byte("run\n")); err != nil {
		panic(err)
	}

	if _, err := stdin.Write([]byte("quit\n")); err != nil {
		panic(err)
	}

	if err := gdb.Wait(); err != nil {
		panic(err)
	}
}

Ok, it seems that the latter case is probably due to the fact that I don't close ptm and pts at the end; adding:
ptm.Close()
pts.Close()

after gdb.Wait() fixes.
Anyway, after this change, on Linux both examples I provided work.

Update: I published the project in which I use the module pty and for which I opened this issue. If you have any suggestion please feel free to share your knowledge! :)

Closing as it the ticket is too old and seems to be solved. Feel to re-open if it is not the case.


ACM certificate does not work with subject alternative names

Problem
I am unable to successfully run the following Terraform code when the subject_alternative_names param is passed to the aws_acm_certificate resource. Terraform also shows that there are changes every run due to switching values from the default cert and the alternative name when the SAN is passed into the resource.
Reproduction
I have the following Terraform files:
providers.tf
provider "aws" {
  region                      = "us-east-1"
  s3_use_path_style           = true
  skip_credentials_validation = true
  skip_metadata_api_check     = true
  skip_requesting_account_id  = true

  endpoints {
    acm     = "http://localhost:5000"
    route53 = "http://localhost:5000"
  }

  access_key = "my-access-key"
  secret_key = "my-secret-key"
}

acm.tf
locals {
  domain_name = "test.co"
}

resource "aws_route53_zone" "test" {
  name = local.domain_name
}

resource "aws_acm_certificate" "certificate" {
  domain_name       = local.domain_name
  validation_method = "DNS"

  subject_alternative_names = ["*.${local.domain_name}"]

  lifecycle {
    create_before_destroy = true
  }
}

resource "aws_route53_record" "certificate_validation" {
  for_each = {
    for dvo in aws_acm_certificate.certificate.domain_validation_options : dvo.domain_name => {
      name   = dvo.resource_record_name
      record = dvo.resource_record_value
      type   = dvo.resource_record_type
    }
  }

  allow_overwrite = true
  name            = each.value.name
  records         = [each.value.record]
  ttl             = 60
  type            = each.value.type
  zone_id         = aws_route53_zone.test.zone_id
}

resource "aws_acm_certificate_validation" "validation" {
  certificate_arn = aws_acm_certificate.certificate.arn
  validation_record_fqdns = [
    for record in aws_route53_record.certificate_validation : record.fqdn
  ]
}

The errors:
| Error: each.value cannot be used in this context
│
│   on acm.tf line 34, in resource "aws_route53_record" "certificate_validation":
│   34:   name            = each.value.name
│
│ A reference to "each.value" has been used in a context in which it is unavailable, such as when the configuration no longer contains the value in its "for_each" expression. Remove
│ this reference to each.value in your configuration to work around this error.
╵
╷
│ Error: each.value cannot be used in this context
│
│   on acm.tf line 35, in resource "aws_route53_record" "certificate_validation":
│   35:   records         = [each.value.record]
│
│ A reference to "each.value" has been used in a context in which it is unavailable, such as when the configuration no longer contains the value in its "for_each" expression. Remove
│ this reference to each.value in your configuration to work around this error.
╵
╷
│ Error: each.value cannot be used in this context
│
│   on acm.tf line 37, in resource "aws_route53_record" "certificate_validation":
│   37:   type            = each.value.type
│
│ A reference to "each.value" has been used in a context in which it is unavailable, such as when the configuration no longer contains the value in its "for_each" expression. Remove
│ this reference to each.value in your configuration to work around this error.
╵

Note: If you comment out the subject_alternative_names param in the aws_acm_certificate resource, then the above code works as expected.
Expectation
I expect that I am able to use a subject alternative name with the aws_acm_certificate resource.
Current Setup
docker-compose.yml with following config ran with docker-compose up -d
services:
  moto-server:
    image: motoserver/moto:latest
    ports:
      - 5000:5000

Hi @jrindy-iterable, thanks for raising this. It looks like an issue with the DomainValidationOptions that Moto returns. We only return a value for the domain name, but TF also expects a separate DomainValidationOption for each SubjectAlternativeName.
I'll try to raise a fix soon.

@bblommers, just tested newest latest tag and this now works perfectly for me. Thank you!


Revisiting JSON handling and workflow interface

Previous assumptions

JSON-Nexus in run-start- message, which gets parsed into a nested dict.
Insert updates as NXlog, NXevent_data into nested dict.
Pass parsed JSON to reduction workflow
Workflow reads, e.g., NXdetector (containing NXevent_data), NXmonitor (containing NXevent_data).

The list item is linked to a parallel development in workflows, now in ESSreduce, where we avoid loading the entire file but just individual groups.
New developments

JSON-Nexus will not contain everything, since geometry is too large.
Instead we will get a reference to a Nexus template file.

Question
Should we read NXdetector from Nexus template file, and pass only NXevent_data from beamlime to workflows? That is, further split the loaders in the workflows to load NXevent_data separately?

Beamlime would become simpler, since it does not have to recursively assemble nested dict. Only make NXevent_data(s) from flatbuffer message(s).
Workflows would have to read NXdetector without events from file...

Implies that workflows needs to be initialized with a filename.

... and with every update, read just new events from NXevent_data (which it then can combine with the event-less NXdetector, grouping by pixel if desired).

Trying this out on the SANS workflow. From what I can tell so far the proposal makes sense, and even leads to some improvements.
Before:

After:

Notes:

Some functions and types may need renaming now, I left it for making before/after comparison easier.
By getting the detector IDs from the RawData[SampleRun], which is now the "empty" detector with no events masks can be loaded and processed without loading potentially huge amounts of events. Even if the events will be loaded anyway this will improve parallelism, and will avoid reprocessing of masks if the event data changes.
Chunking loading of the event data (using Sciline's map-reduce) with in the "after" graph will only load new events. Other detector information as well as masks can be reused.

My conclusion is that we should go ahead as discussed/proposed. Other thoughts @MridulS @YooSunYoung?

I made changes in scipp/essreduce#53 and scipp/esssans#153 as discussed. @YooSunYoung we should probably have a chat about changing the workflow interface?

I think this is mostly done.


chore: update stb_image from 2.29 to 2.30

Description
Updates stb_image from 2.29 to 2.30.
This PR is not related to any issues I could find.
Tasks

[ ] Tested on Linux
[ ] Tested on Windows
[x] Tested on macOS
[ ] Tested on iOS
[ ] Tested on Android

How to test this PR?
Compile SFML successfully and without those "erroneous gcc warning" that they got rid of in 2.30, also tests.

SFMLBuildMaster: Build this please.

Pull Request Test Coverage Report for Build<PHONE_NUMBER>9
Details

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage decreased (-0.002%) to 56.615%

Totals

Change from base Build<PHONE_NUMBER>4:
-0.002%

Covered Lines:
11885

Relevant Lines:
19908

💛  - Coveralls

windows-vc17-32:
100% tests passed, 0 tests failed out of 71
Total Test time (real) =   6.25 sec
	echo >nul && "C:\Program Files\CMake\bin\cmake.exe" -P C:/Dev/worker/windows-vc17-32/build/build/patch_coverage.cmake
	cd C:\Dev\worker\windows-vc17-32\build\build
[100%] Built target runtests
	"C:\Program Files\CMake\bin\cmake.exe" -E cmake_progress_start C:\Dev\worker\windows-vc17-32\build\build\CMakeFiles 0
jom: Option /K specified. Continuing.
jom: Target 'preinstall' cannot be built due to failed dependencies.
jom: Target 'install' cannot be built due to failed dependencies.
program finished with exit code 1
elapsedTime=106.134514

Rerunning it


Parameters can now be passed to routeable::route

This creates more flexible URL's for sidebars

Awesome :+1:


button on-click outline removed

Hi @Prashastp25. Thanks for your attempt to solve the issue. However, the outline still displays on smaller screens below. I have closed the issue now, so I'll be closing your pull request as well. Thanks again.


Cannot parse empty arrays.

The current version of the parser is not able to parse empty arrays, e.g.
::json::parse {{"test":[]}}

will fail. The following patch fixes it:
proc ::json::decode-array {str {numberDictArrays 0}} {
    set strInitial $str
    set result {}
    set value {}
    set i 0
    if {[string index $str 0] ne "\["} {
        error "can't parse JSON array: $strInitial"
    } else {
        set str [string range $str 1 end]
    }
    while 1 {
        # Empty array, get out from here.
	    if { [string index [string trimleft $str] 0] eq "\]" } {
        set str [string range [string trimleft $str] 1 end]
        break
	    }
        # Value.
        lassign [::cirrus::json::decode-value $str $numberDictArrays] value str
        set str [string trimleft $str]
        if {$numberDictArrays} {
            lappend result $i
        }
        lappend result $value

        # ","
        set sep [string index $str 0]
        set str [string range $str 1 end]
        if {$sep eq "\]"} {
            break
        } elseif {$sep ne ","} {
            error "can't parse JSON array: $strInitial"
        }
        incr i
    }
    return [list $result $str]
}

Sorry if the formatting got a little bit messed up. The idea is basically to peek forward for the end of the array and jump out of the loop at once. I haven't had time to test this thoroughly, so might need to do some extra thinking for corner cases.

Thanks for spotting the problem, and doubly so for the patch!
Could you issue a pull request with your changes to the code? This would ensure proper attribution of the code you've contributed and prevent any formatting or other copying/pasting problems.

Done... I edited in the texteditor at github... Weird feeling... :)

...And merged. Thanks for the PR! I've also committed a test for this case.

Weird feeling... :)

Beware: it's easy to get addicted to it. :-)


fix bench_dbms build

What problem does this PR solve?
Issue Number: close #7924
Problem Summary:
What is changed and how it works?

remove bench_exchange bench_window: they are for fine grained shuffle benchmark. The code has changed too much. So delete them.
merge bench_collation and bench_function_ilike.cpp into one file. Because they both include FunctionsStringSearch.cpp, will got multiple definition complation error.

Check List
Tests

[ ] Unit test
[ ] Integration test
[ ] Manual test (add detailed scripts or steps below)
[ ] No code

Side effects

[ ] Performance regression: Consumes more CPU
[ ] Performance regression: Consumes more Memory
[ ] Breaking backward compatibility

Documentation

[ ] Affects user behaviors
[ ] Contains syntax changes
[ ] Contains variable changes
[ ] Contains experimental features
[ ] Changes MySQL compatibility

Release note

None

/merge

/run-all-tests

/run-unit-test
/run-integration-test

/run-unit-test
/run-integration-test

/run-integration-test

/run-integration-test

/run-integration-test

/run-unit-test

/cherry-pick release-6.1


many problems please fix signup withdrawal and balance

every thing install ok, but
1- when signup its always show loading not redirect to login
2- when withdrawal only loading no thing happend
3- your balance show only loading some time work and some time only show loading
i attache screenshots

please tell me how can i fix this issue

@altmarkets dont warry i was set this just for fun i dont copy your sheet :) i will set my own i will launch site and show you

Did you enjoy taking the Stylesheet from us, Github is all about sharing and contributions especially with such an open source project.
But that takes the piss.
And you go further to ask for help?


SAK-27778 Chat tool - use new date picker for consistency

https://jira.sakaiproject.org/browse/SAK-27778

Should the JSFUtil be in the jsf module maybe under widgets and named appropriately so that other tools will be able to use it? Idea here being that all jsf tools would be able to use it vs each jsf tool duplicating this code.

@bjones86 and @jonespm do you want this PR closed or accepted as is?

I think at the very least @jonespm's comments should be addressed.

Original committer shows no progress so it sounds like you want this closed?

Seems reasonable to me


Fix some release API issues

relates to #1766

reduces some of the calls on the amd release uploads
fixes the issue with bad substitution from the previous PR
removes files which should not be uploaded: VERSION, IMAGE and versions.yaml

this only runs on release so cancelling jobs


Added a Bengali book on Data Science

What does this PR do?
Add resource
For resources
Description
I've added a Bengali book on Data Science. The book, named ডাটা সাইন্সের হাতেখড়ি is freely available as a gitbook at https://datasinsightsbd.gitbook.io
Why is this valuable (or not)?
This book is a valuable resource for learning Data Science in Bengali Language. The book contains lessons starting from besic Introduction to intermediate level topics.
How do we know it's really free?
This book is available freely https://datasinsightsbd.gitbook.io. The book has been made freely available by the author of the book, Fazle Rabbi Khan.
For book lists, is it a book? For course lists, is it a course? etc.
It is a book.
Checklist:

[x] Read our contributing guidelines.
[x] Search for duplicates.
[x] Include author(s) and platform where appropriate.
[x] Put lists in alphabetical order, correct spacing.
[x] Add needed indications (PDF, access notes, under construction).
[x] Used an informative name for this pull request.

Follow-up

Check the status of GitHub Actions and resolve any reported warnings!

Thanks, and welcome to free-programming-books!


是否支持双向同步？

Closing this issue because it was created before version 2.3.0 (2022-11-10). Please try the latest version of Flink CDC to see if the issue has been resolved. If the issue is still valid, kindly report it on Apache Jira under project Flink with component tag Flink CDC. Thank you!


resizeMax Issue

I am attempting to use resizeMax.  When I programmatically check the size of a resized bitmapfactory object, the dimensions are what they should be but when I save the resized image by getting the imageSource and calling saveToFile, the saved file is not the resized dimensions but the size of the original file.  This is the code that does not work:
let bmp = BitmapFactory.create(imageSource.width, imageSource.height);             bmp.dispose(function(b) {                 b.insert(imageSource);                 let resized = b.resizeMax(1024);                 let resizedImageSource = resized.toImageSource();                     let saved = resizedImageSource.saveToFile(                         path,                         enums.ImageFormat.jpeg                     );
Instead, I have to write the file to a new bitmapfactory object with the size I need.  This is my current work around.
let bmp = BitmapFactory.create(imageSource.width, imageSource.height); bmp.dispose(function(b) {                 b.insert(imageSource);                 let preSized = b.resizeMax(1024);                 let sbmp = BitmapFactory.create(preSized.size.width, preSized.size.height);                 sbmp.dispose(function(s) {                     s.insert(imageSource);                     let resizedImageSource = s.toImageSource();                     let saved = resizedImageSource.saveToFile(                         path,                         enums.ImageFormat.jpeg                     );
To me this seems like a bug.  If I am doing something wrong, please let me know.  If this is not a bug it would be great to have a fix.
Thanks in advance!

@glen-stephens
Can you give me some examples of original sizes?

Original image is 2448x3264 @ 72ppi
Code example 1 results in an image that is 2304x3072 @ 216ppi
Code example 2 results in an image that is 768x1024 @ 72ppi

Thanks!
I will check this.
Where does this happen? Android, iOS, both?

I am seeing it on iOS.  Have not tested Android yet.

Any update on this?

Working fine on Android, but iOS won't touch the original res at all with "resizeMax".
"resizeMax" appear broken on iOS, although the "resize" method works just fine (at least for me).
For now I am going like :
`                                    var maxWidth = yourMaxWidth;
                                var b2 = b.resize({
                                    width: maxWidth,
                                    height: ((image.height * maxWidth ) / image.width)
                                });`


How can I make work via bluetooth?

Without using the data cable.
(Arduino 101 here)

frankthedead,
Your question is too vague to answer in any way. Please be more specific.

How can I use the port /dev/tty.Bluetooth-Incoming-Port? For example, I want to monitor my pulse in my phone.

It's not as easy as it sounds. First you need a bluetooth radio module that the Pulse Sensor can plug into. Look at Sparkfun or Adafruit for one of those.
Then you need code on the computer to monitor the incoming bluetooth signal. This is not a question that we are prepared to answer. You are asking for extensive design services that we don't provide

The Arduino 101 makes this much easier then before.  We don't have an example project yet, but there are some great ones around the web.  See 👇
https://create.arduino.cc/projecthub/masteruan/arduino-101-curie-ios-pulse-sensor-2441cd


MAINT: move LSAP maximization handling into solver code

What does this implement/fix?

In line with #13860 and #13870, I have moved maximization handling into the solver code of scipy.optimize.linear_sum_assignment
Additional information

@peterbell10: almost finished with this round of maintenance. The last bit is to move the remaining parts of _lsap.py into the binding code.

@peterbell10 any comments on this? If not I will go ahead and merge as the changes are quite small.

Thanks @pmla, I must have missed the notification first time around.

Thank you!


chore: rename folders to not all start with astria

Summary
Removes astria- from the beggining of each crate folder in the repo. Note this will affect open PRs and branches, but the code is otherwise identical and generated packages are identical.
Background
Every crate produced by us starts with astria- this is useful for packaging for annoying for browsing the code, IMO.
Changes

Change folder references and folders to remove astria-
Update docker and general build scripts to make work with new naming

Testing
CI/CD tests

After further discussion, closing and killing.
The goal had been to align folders with alias names, preference to migrate to not aliasing over the folder renaming.


(RSP-1796) Fixing invalid radio halo ring and updating focus ring when radio is checked

Closes https://jira.corp.adobe.com/browse/RSP-1796
✅ Pull Request Checklist:

[ ] Included link to corresponding Issue.
[ ] Added/updated unit tests and storybook for this change (for new code or code which already has tests).
[ ] Filled out test instructions.
[ ] Updated documentation (if it already exists for this component).
[ ] Looked at the Accessibility Practices for this feature - Aria Practices

📝 Test Instructions:

🧢 Your Team:

Did we miss it or did spectrum-css not have it?

@dannify Kinda a bit of both I guess? Spectrum-css doesn't have it, so I opened a pull on their repo and applied the same changes to our repo shortly after I brought halo focus rings to our stuff. These updates are basically new things that my original change didn't account for and so I updated the spectrum css PR and opened this PR


Nx v16, Cannot find module<EMAIL_ADDRESS>

When using this package with "@nx/cypress": "16.3.2" I am getting this error:
`Error: Cannot find module<EMAIL_ADDRESS>Require stack:

<EMAIL_ADDRESS>/PATH_TO_PROJECT/node_modules/nx/src/config/workspaces.js
/PATH_TO_PROJECT/node_modules/nx/src/command-line/run/run.js
/PATH_TO_PROJECT/node_modules/nx/bin/run-executor.js
at Function.Module._resolveFilename (node:internal/modules/cjs/loader:1021:15)
at Function.Module._load (node:internal/modules/cjs/loader:866:27)
at Module.require (node:internal/modules/cjs/loader:1093:19)
at require (node:internal/modules/cjs/helpers:108:18)
at /PATH_TO_PROJECT/node_modules/@nx-extend/e2e-runner/src/executors/run/run.impl.js:23:41
at Generator.next ()
at fulfilled (/PATH_TO_PROJECT/node_modules/@nx-extend/e2e-runner/node_modules/tslib/tslib.js:164:62)
at processTicksAndRejections (node:internal/process/task_queues:96:5) {
code: 'MODULE_NOT_FOUND',
requireStack: [
<EMAIL_ADDRESS>'/PATH_TO_PROJECT/node_modules/nx/src/config/workspaces.js',
'/PATH_TO_PROJECT/node_modules/nx/src/command-line/run/run.js',
'/PATH_TO_PROJECT/node_modules/nx/bin/run-executor.js'
]
}
`

I noticed that when we use 'cypress' as a runner the logic inside packages/e2e-runner/src/executors/run/run.impl.ts, tries to import it from @nrwl/cypress which has been renamed to @nx/cypress. So changing
const cypressExecutor = require('@nrwl/cypress/src/executors/cypress/cypress.impl').default
to
const cypressExecutor = require('@nx/cypress/src/executors/cypress/cypress.impl').default
should resolve the issue.
Please let me know if you need more information or details.

This will be fixed with #128


Dead link at Manual --> Test Plugins

The link the the plugins manual is dead.

http://cpputest.github.io/plugins_manual.html

Ends in a 404.
Here's where to find it:

Complete Documentation for provided plugins can be found on the Plugins Manual page.

http://cpputest.github.io/manual.html#test_plugins

@offa thanks for noticing this.
@basvodde fixed this and changed the Coveralls badge to point to cpputest/cpputest in
https://github.com/cpputest/cpputest.github.io/pull/32

Fixed by PR mentioned above.


[css] Add linux metric compatible font snippets for CSS

Linux metric compatible font fonts should be added afterwards in case they have the tts core fonts installed, althought not everyone will have these core fonts, it might be less likely they have these others, but I think we should help pushing forward to including them.
These snippets are shown when auto-completing the font-family property in CSS, adding those would help linux user who installed these fonts having a more pleasant experience on the web without jumps when loading fonts. It would also help designers/coders getting more familiar with these alternatives.
Usually these default completions are used when you don't want to load a google font and/or aim for a fast loading website.
Those metric compatible fonts are these, as far as I'm aware, begginer friendly distros like Zorin OS have them installed by default. Also libreoffice might include or recommend them, they come in packages like fonts-liberation, fonts-liberation-2 or fonts-croscore, but can be easily found on sites like font-squirrel.
Also many linux distros ship with other metric compatible fonts such as shown on Arch wiki's, so I think this should be put more thought into it or see if we're missing some font.

Carlito for Calibri
Caladea for Cambria
Gelasio for Georgia
Selawik for Segoe
Comic Relief for Comic Sans
Arimo and Liberation Sans for Arial
Nimbus Sans for Helvetica
Timos and Liberation Serif for Times
Cousine and Liberation Mono for Courier New

So the snippets might look like these
Arial, Helvetica, sans-serif
Arial, Helvetica, Arimo, 'Liberation sans', 'Nimbus Sans', sans-serif
'Times New Roman', Times, serif
'Times New Roman', Times, Tinos, serif
Georgia, 'Times New Roman', Times, serif
Georgia, Gelasio, 'Times New Roman', Times, Tinos, 'Liberation Serif' serif

You can make a pull request here:
https://github.com/microsoft/vscode-custom-data/blob/5d54077fa266d0d407647a9ed9bca555ba572cd1/web-data/css/css-schema.json#L7892


some notification cleanups and suppressions of unwanted errors

I have one more PR after this one (like the previous ones I will soak this for a few days) and then we should be ready for the 1.6.0 release. 🙂

then we should be ready for the 1.6.0 release

Sounds good. When you're ready for a new release, make a new issue and assign it to me. I'll test out and the do the release.

Sounds good. When you're ready for a new release, make a new issue and assign it to me. I'll test out and the do the release.

I would have just created a PR with the release preparation and version bump in separate commit you could have merged and set the tag on the first one. Can file a ticket as well.
But there might yet be another PR before that - I found another TODO I want to look at first ...

Yes, if you want to do a PR, that also sounds good.

@firewave Now that you are a full maintainer, I added a Maintainers section to the README with you included. I think this could make the changelog nicer if we didn't add (Contribution by @firewave) to each line. I want you to get credit for your great work, but maybe this way the changelog is a little cleaner? What do you think?

Now that you are a full maintainer, I added a Maintainers section to the README with you included. I think this could make the changelog nicer if we didn't add (Contribution by @firewave) to each line. I want you to get credit for your great work, but maybe this way the changelog is a little cleaner? What do you think?

Thanks. That makes sense. I will cleanup the logs when I prepare the release.


Made pending not on by default

@jlhughes @kgrgreer @nanoscott

LGTM

@kgrgreer .. can you merge this so that we can use it for the liquidPOC branch?


refactor(service): calculate multi-signature recursion depth

What type of PR is this?
refactor
What this PR does / why we need it:

Instead of using a global variable, use a local variable to calculate the multi-signature recursion depth.
remove redundancy signature verify in add_account, remove_account, set_threshold .etc
refactor check recursion depth function, when the depth is overflow, stop check immediately.

Which issue(s) this PR fixes:

Fixes #
Special notes for your reviewer:

修复ci
https://github.com/nervosnetwork/Huobi-doc-specs 检查一下有没有没有对的上的
fn update_account(new_config: MultiSigPermission) -> bool {} //更新多签地址的信息

增加一个这个接口,你那些接口,用着太难受了.....


API call to fetch issues when adding dependent issue doesn't take ROOT_URL into account

Gitea version (or commit ref): 1.6.0
Database (use [x]):

[ ] PostgreSQL
[X ] MySQL
[ ] MSSQL
[ ] SQLite

Can you reproduce the bug at https://try.gitea.io:

[ ] Yes (provide example URL)
[X] No
[ ] Not relevant

Description
I wanted to try out issue dependencies and when clicking wihtin the dropbox, or typing in an issue, I get the response:
There was an error contacting the server
In the JavaScript console I can see the following error:
API: Server gave an error: error /scm/api/v1/repos/scm/MY_USER/MY_REPO/issues?q=
The problem is, that my ROOT_URL looks like this:
https://mydomain.com/scm
and therefore the API call doesn't find the correct endpoint (see the additional scm after repos/).
It seems like the URL-building part of the API call doesn't take ROOT_URL into account, or simply uses everything after DOMAIN to concat it to v1/repos/
I currently see no workaround which I can do on my side to work around this at the moment.
Screenshots

I've found the API call here and it seems that the #repolink element in my HTML does have the /scm suffix.
I'm not sure what the correct way is here, either have a different #repolink (which might break other stuff) or have the call relativize the URL correctly taking ROOT_URL into account


Call CheckCompactionConfig during upgrade

Closes #4315

@ddanielr  - Properties can't be removed in 2.1.x or 3.1, so I'm not checking that here. The calls to ConfigCheckUtil should catch any properties that were removed and log a warning about them.

Closing in favor of #4802 which is against the 2.1 branch.


show actual size (how much it takes up) of the VM OR show "reclaimable space"

because of v3.2.0 (pre-release), trimming the drives in the VM will result in reduced disk usage.
however, that is not reflected in UTM, as the current size UTM shows is the size of the images (disk images) with the holes (i.e. UTM shows apparent size, not actual size).
before reclaim:
after reclaim:
solutions:

show the actual size it would take up on disk (maybe along with the apparent size (refer to DU(1) man page))
another is to show the amount of space the disk images can be "reduced" by (it doesn't actually get reduced in the sense of disk usage, since the disk image contains holes)

QCOW2 images are not sparse (i.e. zeros are stored and take up space). Hence the ability to reclaim space. For Apple VMs, the raw IMG are sparse, but I have no idea how to calculate the "actual size on disk". There's no good documentation for APFS stuff.

QCOW2 images are not sparse (i.e. zeros are stored and take up space).

true, but when qemu is made to create holes in the disk image (which i'm highly confident is already implemented and pre-released), i would consider it a sparse file after meeting the requirements for creating holes (write zeros to disk or trim) and so the size might differ.

Hence the ability to reclaim space.
For Apple VMs, the raw IMG are sparse, but I have no idea how to calculate the "actual size on disk". There's no good documentation for APFS stuff.

there is du (the command), which if it works might be useful.
however, i'm not sure how "reclaimable space" would be implemented. the actual space might be better than none, but reclaimable space is likely going to be more complex.

Maybe I’m misunderstanding what you’re asking here. So currently, we get the file size by querying the file size attribute from the file URL. This returns the actual size of the file. If it uses APFS sparse files feature (which I don’t think the QCOW2 backend does), then it will think the file is larger than what is actually stored on the drive. This is applicable to “raw” images and I don’t know a way to query the actual size for those.

if i can't really explain it, then saying "the size output from du" might be enough for some understanding of what i'm talking about

On MacOS UTM currently displays the size set during the creation of a VM's QCOW2 image.
So for example setting the VM's disk size to 215GB looks like this in Finder/du
Finder

du

They both, minor differences aside, show the file size and the actual file size on disk. I also think it would be useful to show both sizes in UTM. I created a little mockup.

I hope this is what OP was asking for and I did not misinterpret this.

@introns-bungles thanks for explaining, you have interpreted me pretty much correctly.
there's something you said which is slightly incorrect but that's not important (the size of the image isn't the disk image size specified necessarily unless it's raw).
should note, the output of du is actually in GibiBytes (powers of 2, what du uses) and not GigaBytes (powers of 10, what macOS uses), so using output straight from du will lead to an inconsistency with the unit of size represented. so what's shown in finder (the 39,24 GB) should be the one that'll be used.
On May 14, 2022 7:31:53 AM UTC, introns-bungles @.***> wrote:

On MacOS UTM currently displays the size set during the creation of a VM's QCOW2 image.
So for example setting the VM's disk size to 215GB looks like this in Finder/du
Finder

du

They both, minor differences aside, show the file size and the actual file size on disk. I also think it would be useful to show both sizes in UTM. I created a little mockup.

I hope this is what OP was asking for and I did not misinterpret this.
--
Reply to this email directly or view it on GitHub:
https://github.com/utmapp/UTM/issues/4005#issuecomment-1126663141
You are receiving this because you authored the thread.
Message ID: @.***>

Thanks, I didn't know about the output difference between macOS and du.

Looking at utm files on macOS Sonoma I get SO confused what is really going on....
The UTM is a package that Finder offers to "Show package contents" of, if I "Get info" on the utm package/file it is
16,912,659,207 bytes (16.54 GB on disk)
If I look in the package there is the Data folder with the gcow2 file, which finder now says is
27,724,480,512 bytes (27.72 GB on disk)
If I look with a tool like Sparsity or Precize (eclecticlight.co.uk) they report there is a sparse file but that it is completely full at 27.72GB.
If I make a Finder copy on APFS drive it is immediately cloned. Finder now says the utm file/package is 27.7GB. I delete it and nothing much ever happened to the disc.
IF I run UTM routine to compact or save space on the original  UTM files disc the Finder "Get info" then reports it is now 20GB although the gcow2 file inside is reported as maybe 17GB. (Roughly, from memory- now all deleted).
du seems to agree with the 27.72 sizes, I did not run it during the compact/save space tests.
I can;'t easily form an idea of what is true and reliable and what differs from that , why and when!


[React] - The React render method lesson should be updated

In the Front End Development Libraries Certification lesson, specifically React lesson on 'Render HTML Elements to the DOM' it is still using [ReactDOM.render]. I know this method still works, but I believe it should be updated to [ReactDOM.createRoot] as [ReactDOM.render] is running the root API in legacy mode and will create a warning that it's deprecated.
To Reproduce

Go to Freecodecamp react render lesson

Additional context
For reference : this is a link to React's github discussion on the root API
React discussion on root API
P.S. To open the link in new tab, press [CTRL+click] for Windows & Linux or [CMD+click] on MacOS

Our curriculum is still running on React 16, I believe, so this migration wouldn't be possible just yet. But something we can keep in mind when we move to a project-based Front End Libraries approach. :3

Thank you for the information. 😁


feat: URL filtering with createFilter

Copied from https://github.com/unjs/ufo/pull/99

The createFilter is a popular util from Rollup to filter system paths when transforming modules. This PR introduces a port of that util, but for URL paths.
Why?
I'm working on a Nuxt module that allows end users to filter paths that it should run on (nuxt-delay-hydration v1). I need something that is straightforward to define inclusions and exclusions.
Generally, this function can be used wherever the end user needs to target a set of routes with certain exclusions.
How
The API is pretty much the same as the rollup createFilter, supporting whatever tokens Radix3 supports as well as regex.
I'm open to dropping regex support if you want to keep parity with the rest of the Radix3 API, let me know your thoughts.
Thanks!

Sorry for late review @harlan-zw.
Implementation seems quite good only I'm not sure about supporting regex matchers. A main promise of radix3 in design is that by keeping patterns simple (* / named / wildcard) they can have the maximum integration with platform native configurations (nginx, vercel, etc)
While i understand it could be useful for basic validation, perhaps we can support regex as a super-set layer out of this util and per projects?

Closing as this feature is not relevant to this library roadmap.
I think pathe/utils could be perhaps a better candidate.


Misc make / tests fixups

This is a series of misc changes for Makefiles and contrib scripts, including:

New make unit-tests target to only run unit tests
Fix up watchtest macro in contrib/
Improve makefile dependencies (removes several seconds off builds when modifying/running unit tests in a loop)

test-me-please


[autoupdate] base64 hash extraction length

sha512 encoded hash length for Franz is 88 characters length and autoupdate just dont extract it's value.
If anyone have better fix, feel free to edit.
Relate lukesampson/scoop-extras#1487

No. It's already implemeted. (lukesampson/scoop@04c9ddeb6d3b99496c39543ad468d34f4f1adeff)

Actually, it would be enough to fix the condition.
from: $hash.length -in @(32, 40, 64, 128)
to: $hash.length -notin @(32, 40, 64, 128)
This check prevents overwriting $hash with garbage if the result in $base64 contains valid base64 characters but not a real hash. It's just a safety net, I messed up 😁

Ok. Tested with -notin variant with franz and rambox pro (from extras) and it's working 👍
Do you know some others manifests, which have encoded hashes?

@Ash258
https://github.com/lukesampson/scoop-extras/blob/master/blink1control2.json
https://github.com/lukesampson/scoop-extras/blob/master/inboxer.json
https://github.com/lukesampson/scoop-extras/blob/master/signal.json
https://github.com/lukesampson/scoop-extras/blob/master/cacher.json
Some of them require changes to work because the .yml has changed.


Remove hard-coded scheme in azure HTTP requests. Closes #1703

Dynamically assign scheme to HTTP requests in azure driver
Description
Per #1703. The hard-coded http scheme is replaced with a variable that assigns it to http or https based on the value of self.secure. Otherwise, requests made to a secure Azure blob storage will always start with http and will fail, as this is not allowed.
Status

done, ready for review

Checklist (tick everything that applies)

[x] Code linting (required, can be done after the PR checks)
[ ] Documentation
[x] Tests
[ ] ICLA (required for bigger changes)

Output of tox:
========================================== 25 passed, 39 skipped in 13.11s ===========================================
______________________________________________________ summary _______________________________________________________
ERROR:  pypypy3: InterpreterNotFound: pypy3
ERROR:  py3.6: InterpreterNotFound: python3.6
ERROR:  py3.7: InterpreterNotFound: python3.7
ERROR:   py3.8: could not install deps [-r/home/ckan29lts/FORKS/libcloud/requirements-tests.txt, fasteners, libvirt-python==7.9.0]; v = InvocationError('/home/ckan29lts/FORKS/libcloud/.tox/py3.8/bin/python -m pip install -r/home/ckan29lts/FORKS/libcloud/requirements-tests.txt fasteners libvirt-python==7.9.0', 1)
ERROR:  py3.9: InterpreterNotFound: python3.9
ERROR:  py3.10: InterpreterNotFound: python3.10
ERROR:  pypyjion: InterpreterNotFound: pyjion
ERROR:  checks: InterpreterNotFound: python3.7
ERROR:  lint: InterpreterNotFound: python3.7
ERROR:  pylint: InterpreterNotFound: python3.7
ERROR:  mypy: InterpreterNotFound: python3.7
ERROR:  docs: InterpreterNotFound: python3.7
ERROR:  coverage: InterpreterNotFound: python3.7
  integration-storage: commands succeeded

I added a test case for it (e87ee8314e8a88ee908d109ac877dc3f36046e7d) and will go ahead and merge it into trunk. Thanks for the contribution.
While testing the fix and adding a test case, I also noticed a bug in the list_containers() method where double quotes are not correctly removed from the etag extra attribute.
......{'url': None, 'last_modified': None, 'etag': '"0x8CFBAB7B5B82D8E"', 'lease': {'status': 'unlocked', 'state': 'available', 'duration': None}, 'meta_data': {}}

I went ahead and fixed that as well - 07c72cd8ec8ddea0636d9632a72c66e5d6975777.


fixed 'receive url(s) to enqueue'

I found issue in log report.
Before:
2016/11/20 17:28:39 receive url(s) to enqueue [0xc8203403c0]
After:
2016/11/20 17:38:07 receive url(s) to enqueue http://*****/Seller/Jewelry-Gemstones
Tests:

PASS
ok  	github.com/PuerkitoBio/gocrawl	23.900s

Thanks!


SharePoint List Connector

Add a new SharePoint List Connector.  Happy to contribute a PR for this :)
Example feature SharePoint List Connector would unlock:
"Create a SharePoint List of action items with these fields: , , , from the last email I got from xxxx"

Thanks for sharing this idea @glenchao! We'd be happy to receive a PR from you!

@glenchao looking forward to your PR.  I will close this for now.


[Packager] Fix transforming when ast is not available

Fixes https://github.com/facebook/react-native/issues/12071. I found that babel.transform does not generate ast for files from babelrc' ignore, so while babel-generator fails. I don't know the best way to handle such files, I reverted code that was used before https://github.com/facebook/react-native/commit/0849f84df26e4c56f5763375363bae90d94015fe for files without ast.

cc @davidaurelio

Looks that this issue solved in 0.41.2

@gitim @davidaurelio This is still happening on 0.42 and I have verified that this PR fixes the issue.

Verified same as @ruiaraujo, 0.42.0rc3


Create dataset loader for CC3M-35L

Dataloader name: cc3m_35l/cc3m_35l.py
DataCatalogue: http://seacrowd.github.io/seacrowd-catalogue/card.html?cc3m_35l

Dataset
cc3m_35l

Description
CC3M-35L is created by translating Conceptual Captions 3M (Sharma et al., 2018), originally in English, to the other 34 languages using Google’s machine translation API.

Subsets
fil, ind, tha, vie

Languages
fil, ind, tha, vie

Tasks
Image-to-Text Generation

License
Creative Commons Attribution 4.0 (cc-by-4.0)

Homepage
https://google.github.io/crossmodal-3600/

HF URL
-

Paper URL
https://aclanthology.org/2022.emnlp-main.45/

#self-assign

Uhm, this dataset is very huge.
It takes days (without parallelization) to load and download all the images locally.
Are you sure all that all of the images needs to be downloaded locally before it can be used?

Hi @IvanHalimP, sorry for the late reply. I am testing the dataloader right now and, as you mention it takes some time to generate the dataset. I will check if there is a way to speed up the process. I'll push some updates on this later this week.


NIFI-11144 Fix failing tests for ConsumeJMS/PublishJMS

Summary
NIFI-11144
As the title says, this PR intends to fix currently failing tests without changing the behavior of the processors. There are two things worth mentioning. There was an exception propagation in ConsumeJMS. The comment next to it doesn't really make sense. In 2020 a commit was added, which even caught all exceptions in the Abstract class. I tried to figure out what the expectation would be. Propagate it according to the original behavior, or go forward and remove the rethrow part. I decided to do the latter because propagating the exception doesn't make sense in this case. There is no upstream connection, and when "consume" fails, there won't be a flowfile in the output relationship, so rollback is unnecessary, which could be triggered by the exception.
The other thing is testMultiplethreads(). It failed with timeout because we reached a limit after publishing a thousand messages. It is probably related to this. I tried multiple different configurations without luck. It is a hint, but maybe not all of them work with the test broker implementation. Ultimately I decided to set the total messages to that threshold. This way, we can spare the additional configuration, and one thousand messages should be enough for the purpose of the test.
Tracking
Please complete the following tracking steps prior to pull request creation.
Issue Tracking

[x] Apache NiFi Jira issue created

Pull Request Tracking

[x] Pull Request title starts with Apache NiFi Jira issue number, such as NIFI-00000
[x] Pull Request commit message starts with Apache NiFi Jira issue number, as such NIFI-00000

Pull Request Formatting

[x] Pull Request based on current revision of the main branch
[x] Pull Request refers to a feature branch with one commit containing changes

Verification
Please indicate the verification steps performed prior to pull request creation.
Build

[x] Build completed using mvn clean install -P contrib-check

[x] JDK 8
[ ] JDK 11
[ ] JDK 17

Licensing

[ ] New dependencies are compatible with the Apache License 2.0 according to the License Policy
[ ] New dependencies are documented in applicable LICENSE and NOTICE files

Documentation

[ ] Documentation formatting appears as expected in rendered files

Thank you @tpalfy for your review! I've updated the pr based on your comments, except in the "assertCausedBy" topic. Please see my comment inline.

LGTM
Thank you for your work @nandorsoma !
Merged into main.


Add bikramnehra to kubeflow org

This change is

/assign @theadactyl

Closing this PR because of the CLA issue, will create a new one


Improved dual subs support

I'm interested if it's possible to select dual subs with streaming services? At the moment, it seems that it's only possible to select either a single subtitle or use Open Files to load multiple subtitles at the same times (so to have multiple subtitles from a streaming service, one needs to DL both of them and then Open Files both of them). It would be good to have checkboxes (rather than a single subtitle selection) to load dual subs automatically without downloading them.
Additionally, I don't think there's a consistent way to load dual subs regarding their positions? I.e. sometimes English subtitles get loaded into 1st track and sometimes - into 2nd. This means that the shortcut to hide English subtitles changes from video to video. It seems that subtitle order depends on the video and nothing else. I tried clicking the subtitles in different order when opening them but for some videos English subtitles are always first and for others - second

It would also be cool if I could export both the target language sentence and the native subtitle sentence, to the same card. So target language on the front, native on the back of the card. Similar to sub2srs.
While all through the video JP subs are displayed on top of English subs maybe with a flip button or blur, or each with there own individual keybind to hid and show, different text style for each would be fantastic.


The diaUmpire filter in msconvert.exe does not work for me

Hi,
I tried to use msconvert.exe (from Proteowizard 3.0.20239) in Windows 10, along with the diaUmpire params filter. However, the process quits quickly as the following message appears:
[diaUmpire] params filepath is required (params=path/to/diaumpire.params)`
Even though I provide the file path to the params file, it still keeps asking for the file path... I dont really understand why this is the case.
I would be happy if you could help me out on this one! See attached code :).
Best,
Marc
`C:\Program Files\ProteoWizard\ProteoWizard 3.0.20239.db48a3d0d>msconvert.exe D:\MS_files\MSLibrarian_DIA_test\CK_P1911_228.mzXML --filter diaUmpire "C:\DIA-Umpire_v2_0\diaumpire_se_marc_edit.params" -o D:\MS_files\MSLibrarian_DIA_test
format: mzML
m/z: Compression-None, 64-bit
intensity: Compression-None, 32-bit
rt: Compression-None, 64-bit
ByteOrder_LittleEndian
indexed="true"
outputPath: D:\MS_files\MSLibrarian_DIA_test
extension: .mzML
contactFilename:
runIndexSet:
spectrum list filters:
diaUmpire
chromatogram list filters:
filenames:
D:\MS_files\MSLibrarian_DIA_test\CK_P1911_228.mzXML
C:\DIA-Umpire_v2_0\diaumpire_se_marc_edit.params
processing file: D:\MS_files\MSLibrarian_DIA_test\CK_P1911_228.mzXML
calculating source file checksums
[diaUmpire] params filepath is required (params=path/to/diaumpire.params)`

Did you figure out that the params should be inside the filter argument? --filter "diaUmpire params=path/to/params"?

Hi, yes I figured it out at last :). It works nice

Hello!
Sorry for resurrecting the issue but I was wondering where the documentation for the diaUmpire filter is located. I cannot seem to find it in the online filter documentation (https://proteowizard.sourceforge.io/tools/filters.html).
Thanks beforehand!
-Sebastian


Controller Dashboard: toolbar isn't styled

Issue Type: Bug
The toolbar styling isn't matching things like the Notebook toolbar. I believe this should be a built-in component so has this regressed? We should ensure this is consistent.

Specific issues:

Spacing is off
On click, get left with blue selection box around the button you clicked (should grow bigger then not show with blue selection box at the end)

Azure Data Studio version: azuredatastudio 1.12.0 (9ca6200018fc206d67a47229f991901a8a453781, 2017-12-15T12:00:00.000Z)
OS version: Darwin x64 18.7.0

System Info

Item
Value

CPUs
Intel(R) Core(TM) i7-8850H CPU @ 2.60GHz (12 x 2600)

GPU Status
2d_canvas: enabledflash_3d: enabledflash_stage3d: enabledflash_stage3d_baseline: enabledgpu_compositing: enabledmultiple_raster_threads: enabled_onnative_gpu_memory_buffers: enabledoop_rasterization: disabled_offprotected_video_decode: unavailable_offrasterization: enabledskia_deferred_display_list: disabled_offskia_renderer: disabled_offsurface_synchronization: enabled_onvideo_decode: enabledviz_display_compositor: disabled_offwebgl: enabledwebgl2: enabled

Load (avg)
2, 2, 2

Memory (System)
16.00GB (0.03GB free)

Process Argv
.

Screen Reader
no

VM
0%

Extensions (4)

Extension
Author (truncated)
Version

gitlens
eam
9.9.3

ads-language-pack-es
Mic
1.9.0

azuredatastudio-postgresql
Mic
0.2.2

sql-vnext
Mic
0.14.1

@Charles-Gagnon Is this issue related to the refresh button behavior?

@kevcunnane We don't use the same toolbar
Notebook is using a toolbar styled with the editor-toolbar and actionbar-container classes
https://github.com/microsoft/azuredatastudio/blob/60bf331f19f32cde22558992748790a0fb29704d/src/sql/workbench/parts/notebook/browser/notebook.component.html#L8
BDC dashboard is using the modelview toolbarContainer which is using its own CSS
https://github.com/microsoft/azuredatastudio/blob/e8e8ee59413886a2f8d92410ceaf52d1ee0409cb/src/sql/workbench/browser/modelComponents/media/toolbarLayout.css#L6
I agree this doesn't seem correct though - we should be using the same toolbar styling for both.
As for the spacing - are you still seeing that on the latest master/insiders? I have a fix there which should make things look better

@yualan I'm moving this into planning since I don't see this as being necessary for the November time frame


Create .intunewin file: WARNING: Unexpected error occurred while packaging Win32 app. Return code from invocation: -532462766

When attempting to follow the instructions provided in the GitHub repository
https://github.com/MSEndpointMgr/IntuneWin32App?tab=readme-ov-file#package-application-source-files-into-win32-app-package-intunewin
For packaging application source files into a Win32 app package using New-IntuneWin32AppPackage, I consistently encounter the following error:
WARNING: Unexpected error occurred while packaging Win32 app. Return code from invocation: -532462766
I'm using the exact code as outlined in the readme.md:
# Package MSI as .intunewin file
$SourceFolder = "C:\Win32Apps\Source\7-Zip"
$SetupFile = "7z1900-x64.msi"
$OutputFolder = "C:\Win32Apps\Output"
New-IntuneWin32AppPackage -SourceFolder $SourceFolder -SetupFile $SetupFile -OutputFolder $OutputFolder -Verbose

If you have any insights into resolving this issue or if there are additional steps to consider, I would greatly appreciate your assistance.
Tested on multiple devices.

Tested several version of IntuneWinAppUtil.exe
They all produce the same error.
No issues running IntuneWinAppUtil.exe standalone

Hello,
I just researched this for the 3rd time as I have automation that uploads apps in a script. The last 2 times I had to change code in the module itself or some people here had to change to an older IntuneWInAppUtil.exe version as you have tried.
I have just upgraded to the Module to version 1.4.3 and specified in my script's first line:
#requires -Modules @{ ModuleName="IntuneWin32App"; RequiredVersion="1.4.3" }
I am currently executing this script with:
PSVersion                      7.3.10
PSEdition                      Core
I haven't changed anything after upgrading the module. I hope this helps you as well.

Thanks, for now I solved this by directly IntuneWinAppUtil.exe from my PoweShell script. Not as nice as downloaden the most recent version, but is does the job

I think this is related to Issue https://github.com/MSEndpointMgr/IntuneWin32App/issues/134
New-IntuneWin32AppPackage uses the module's Invoke-Executable function.
Supposedly there will be a fix in 1.4.4 but I see nothing yet.

1.4.4 is out now, please verify if the issue still persist. Reopen the issue if there's still a problem :)


Feat/automate chart creation - DX-175

these calls must go through the middleware for safe authentication, make sure the logic of at least api connection is through there


update version to 0.1.1

Coverage remained the same at 100.0% when pulling daee55cf892bd9e30fb923ec497aac32b83d866e on update-version into 7e86578f8e4204386c696b69ded9c0da4f4baf20 on master.