How to quickly add extract_image_patch op support in tflite?

System information

OS Platform and Distribution (e.g., Linux Ubuntu 16.04):Ubuntu 18.04
TensorFlow installed from (source or binary):Source
TensorFlow version (or github SHA if from source):1.14

Command used to run the converter or code if you’re using the Python API
import tensorflow as tf
saved_model_dir="./"
converter = tf.lite.TFLiteConverter.from_saved_model(saved_model_dir)
converter.target_ops = [tf.lite.OpsSet.TFLITE_BUILTINS,
                                       tf.lite.OpsSet.SELECT_TF_OPS]
#converter.allow_custom_ops=True
tflite_model = converter.convert()
open("./converted_model.tflite", "wb").write(tflite_model)

The output from the converter invocation
Some of the operators in the model are not supported by the standard TensorFlow Lite runtime and are not recognized by TensorFlow. If you have a custom implementation for them you can disable this error with --allow_custom_ops, or by setting allow_custom_ops=True when calling tf.lite.TFLiteConverter(). Here is a list of builtin operators you are using: ADD, CAST, CONCATENATION, CONV_2D, DIV, ELU, LOGISTIC, MAXIMUM, MINIMUM, MUL, RELU, RESHAPE, RESIZE_NEAREST_NEIGHBOR, REVERSE_V2, SOFTMAX, SPLIT, SQRT, SQUARE, STRIDED_SLICE, SUM, TANH, TRANSPOSE, TRANSPOSE_CONV. Here is a list of operators for which you will need custom implementations: ExtractImagePatches.
Traceback (most recent call last):
  File "/home/siju/.local/bin/toco_from_protos", line 8, in <module>
    sys.exit(main())
  File "/home/siju/.local/lib/python3.6/site-packages/tensorflow/lite/toco/python/toco_from_protos.py", line 59, in main
    app.run(main=execute, argv=[sys.argv[0]] + unparsed)
  File "/home/siju/.local/lib/python3.6/site-packages/tensorflow/python/platform/app.py", line 40, in run
    _run(main=main, argv=argv, flags_parser=_parse_flags_tolerate_undef)
  File "/home/siju/.local/lib/python3.6/site-packages/absl/app.py", line 299, in run
    _run_main(main, args)
  File "/home/siju/.local/lib/python3.6/site-packages/absl/app.py", line 250, in _run_main
    sys.exit(main(argv))
  File "/home/siju/.local/lib/python3.6/site-packages/tensorflow/lite/toco/python/toco_from_protos.py", line 33, in execute
    output_str = tensorflow_wrap_toco.TocoConvert(model_str, toco_str, input_str)
Exception: We are continually in the process of adding support to TensorFlow Lite for more ops. It would be helpful if you could inform us of how this conversion went by opening a github issue at https://github.com/tensorflow/tensorflow/issues/new?template=40-tflite-op-request.md
 and pasting the following:

Some of the operators in the model are not supported by the standard TensorFlow Lite runtime and are not recognized by TensorFlow. If you have a custom implementation for them you can disable this error with --allow_custom_ops, or by setting allow_custom_ops=True when calling tf.lite.TFLiteConverter(). Here is a list of builtin operators you are using: ADD, CAST, CONCATENATION, CONV_2D, DIV, ELU, LOGISTIC, MAXIMUM, MINIMUM, MUL, RELU, RESHAPE, RESIZE_NEAREST_NEIGHBOR, REVERSE_V2, SOFTMAX, SPLIT, SQRT, SQUARE, STRIDED_SLICE, SUM, TANH, TRANSPOSE, TRANSPOSE_CONV. Here is a list of operators for which you will need custom implementations: ExtractImagePatches.

Also, please include a link to the saved model or GraphDef
saved_model.zip
Failure details
I want to implement a block of contextual attenuation which contains op
extract image patches
This op is not the first/last one. its in the middle so that i cannot do the processing outside the model.
Any other info / logs
NO

@gbaned Could you please help to assign one person to help me add this as a custom op?

@gbaned Could you please help to assign one person to help me add this as a custom op?

Sure @siju-samuel  Thanks!

@haozha111 any help is appreciated!
i implemented as custom operator and now im facing another issue.
output shape of extract_image_patch is 1, 64, 85, 1536
Next layer after extract_image_patch is reshape new_shape=[1,-1,4,4,96], where this error is coming.
ERROR: tensorflow/lite/kernels/reshape.cc:66 num_input_elements != num_output_elements (1 != 0)
ERROR: Node number 150 (RESHAPE) failed to prepare.

Its quite a long time. please help!!

Hi, @siju-samuel
I've faced the same problem. Could you share the way to solve the problem?

You can try adding as a builtin-op instead of custom op.

Hi, @siju-samuel
Thanks for your fast reply.
I tried with it before, but there wasn't ExtractImagePatches ops in builtin-op list.
Could you please explain how to add it as a builin-op?

@siju-samuel Hi, I facing the same problem when export DeepFill models. Haved you solved this problem, looking forward to chat with you!

It was quite some time back.
First i tried to implement ExtractImagePatches from the eigen. eigen already have api to support ExtractImagePatches.  You can add as a op in lite. For reference you can use this .
Eigen impl link
But for me there were some other issues as well. So i abandoned this method and i splitted the tflite graph into two and i did ExtractImagePatches outside tflite network.
I strongly feel tflite must add support for this op. If its in middle of network, its difficult to process.

@siju-samuel Thanks for your update!
yes, ExtraImagePatches op is really important! I hold the same opinion with you!

Hi
Does tflite support ExtraImagePatches op now?

Hi There,
We are checking to see if you still need help on this, as you are using an older version of tensorflow which is officially considered end of life . We recommend that you upgrade to the latest 2.x version and let us know if the issue still persists in newer versions. Please open a new issue for any help you need against 2.x, and we will get you the right help.
This issue will be closed automatically 7 days from now. If you still need help with this issue, please provide us with more information.


Mismatch between imports behaviour and docs

Describe the bug
It looks like importing CO2.js and using the hosting check function is working differently to the docs.
Our docs say:
const { hosting } = require("@tgwf/co2");
hosting.check("google.com", options).then((result) => {
  console.log(result);
});

It looks like what worked in the end was
const { hosting } = require("@tgwf/co2");
hosting(google.com", options).then((result) => {
  console.log(result);
});

To Reproduce
Steps to reproduce the behavior:
(@samuelIkoli to share more notes)
Expected behavior
A clear and concise description of what you expected to happen.

When I tried using CO2.JS as an npm package in my react (javascript) site, when doing the check to see if your domain hosting is green, rather than the 'hosting.check(domain)' which is on the official documentation (kept giving a 'hosting.check is not a function), what worked was hosting(domain).

Environment (please complete the following information):
Browser - react
Additional context (if applicable)
Add any other context about the problem here.

My immediate impression here is that this is a result of how we're exporting the hosting module in CO2.js for ESM and CJS.
This difference in syntax is something we need to do a better job of capturing in the docs. I've started a branch - https://github.com/thegreenwebfoundation/developer-docs/tree/fi-clearer-code-blocks - to address this for all the JS-based docs on the site. It'll be a slowish burn, but the aim is to have an update deployed by the end of the year.


Allow setting initial contents of persistent directories

Background & motivation
Currently, you can not mount a files artifact to a persistent directory and have that files artifact persist with whatever else is written to that directory.
Desired behaviour
 hi_files_artifact = initial data to mount to a services persistent directory

 plan.add_service(
 name="...",
 config=ServiceConfig(
   ...
   files={
      "/root/": Directory(
	    persistent_key="ubuntu",
	    artifact_names=[hi_files_artifact],
      ),
   }
   ...
   )
 )

How important is this to you?
Painful; the lack of this feature makes using Kurtosis frictionful.
What area of the product does this pertain to?
Other: anything not covered by the above

@tedim52 just tracking that I could use this too for point-and-click enclave-building

If I can upvote more than once, github will ban me for being a bot 🤖

@tedim52 IIRC didn't we enable this now?


Update README.md Added more badges in readme

[![GitHub stars](https://img.shields.io/github/stars/reactive-python/reactpy.svg)](https://github.com/reactive-python/reactpy/stargazers)

All this information can already be found on the repo's home page without badges.


Add checked_add to VirtAddr and update frame_to_pointer

This pr adds support for checked_adds between virtual addresses and uses it in the frame_to_pointer function for #290 .

@goldencm could you rebase this on top of #298, as those are the checked traits we would ideally like to use (rather than a one-off method).


Error: Minified React error #31; visit https://reactjs.org/docs/error-decoder.html?invariant=31&a...

Describe the bug
To Reproduce
Expected behavior
Screenshots
Applicable Versions:

Netlify CMS version<EMAIL_ADDRESS>Git provider: git-gateway
Browser version: Mozilla/5.0 (Macintosh; Intel Mac OS X 10_15_7) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/<IP_ADDRESS> Safari/537.36

CMS configuration
backend:
  name: git-gateway
  branch: master
media_folder: static/img
public_folder: /img
collections:
  - name: blog
    label: Blog
    folder: src/pages/blog
    create: true
    slug: "{{year}}-{{month}}-{{day}}-{{slug}}"
    fields:
      - label: Template Key
        name: templateKey
        widget: hidden
        default: blog-post
      - label: Title
        name: title
        widget: string
      - label: Publish Date
        name: date
        widget: datetime
      - label: Hero image
        name: Image
        widget: image
      - label: Description
        name: description
        widget: text
      - label: Body
        name: body
        widget: markdown
      - label: Tags
        name: tags
        widget: list
      - label: author
        name: author
        widget: relation
        collection: authors
        search_fields:
          - title
        value_field: details
        display_fields:
          - title
        required: true
    publish: true
    type: folder_based_collection
    sortable_fields:
      - commit_date
      - title
      - date
      - commit_author
      - description
    view_filters: []
    view_groups: []
  - name: pages
    label: Pages
    files:
      - file: src/pages/carriere.md
        label: Carriere
        name: carriere
        fields:
          - label: Template Key
            name: templateKey
            widget: hidden
            default: carriere-page
          - label: Title
            name: title
            widget: string
          - label: jobs
            name: jobs
            widget: list
            fields:
              - label: job title
                name: jobTitle
                widget: text
              - label: job description
                name: jobDescription
                widget: markdown
      - file: src/pages/index.md
        label: home Page
        name: index
        fields:
          - label: Template Key
            name: templateKey
            widget: hidden
            default: index-page
          - label: Title
            name: title
            widget: string
          - label: Image
            name: image
            widget: image
          - label: Heading
            name: heading
            widget: string
          - label: Subheading
            name: subheading
            widget: string
            required: false
      - file: src/pages/about/index.md
        label: About
        name: about
        fields:
          - label: Template Key
            name: templateKey
            widget: hidden
            default: about-page
          - label: Title
            name: title
            widget: string
          - label: Body
            name: body
            widget: markdown
    publish: true
    type: file_based_collection
    sortable_fields:
      - commit_date
      - commit_author
    view_filters: []
    view_groups: []
  - name: projets
    label: Projets
    create: true
    folder: src/pages/projects
    slug: "{{year}}-{{month}}-{{day}}_{{slug}}"
    fields:
      - label: Template Key
        name: templateKey
        widget: hidden
        default: projets-tbwa
      - label: Informations SEO (importantes)
        name: seo
        widget: object
        fields:
          - label: SEO title
            name: seo_title
            widget: string
          - label: Description SEO (max 140 caractères)
            name: seo_metta_desc
            widget: text
      - label: Titre
        name: title
        widget: string
      - label: Client
        name: client
        widget: string
      - label: Date
        name: date
        widget: date

...

Hi @TbwaDjaz, we believe that you have a problem, but in order for anybody to help you, you need to provide as much detail as possible. The issue template contains the bare minimum of what is required (how to reproduce, expected behaviour, screenshots, etc..).
I'm closing this issue for now. If the problem persists, please open a new issue with all of the details filled out. Also, before posting a new issue, please verify that everything is all right with your environment (computer, internet, browser) and verify whether this issue was already reported by someone else. For general help, please turn to our Slack.


make test_dataset less DRY w/ fixtures

Codecov Report

Merging #49 into master will increase coverage by 0.13%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master      #49      +/-   ##
==========================================
+ Coverage   98.04%   98.18%   +0.13%
==========================================
  Files           8        8
  Lines         717      717
  Branches      184      184
==========================================
+ Hits          703      704       +1
+ Partials       14       13       -1

Impacted Files
Coverage Δ

src/pycldf/db.py
97.68% <0%> (+0.57%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1f765b4...0ff5556. Read the comment docs.

Ok. Got it. I think I'm getting into the pytest flow.
Am 11.11.2017 11:17 schrieb "Codecov"<EMAIL_ADDRESS>
Codecov https://codecov.io/gh/cldf/pycldf/pull/49?src=pr&el=h1 Report
Merging #49 https://codecov.io/gh/cldf/pycldf/pull/49?src=pr&el=desc
into master
https://codecov.io/gh/cldf/pycldf/commit/1f765b443007e0dcadfb27825d10fe2f337d5613?src=pr&el=desc
will increase coverage by 0.13%.
The diff coverage is n/a.
[image: Impacted file tree graph]
https://codecov.io/gh/cldf/pycldf/pull/49?src=pr&el=tree
@@            Coverage Diff             @@##           master      #49      +/-   ##
==========================================+ Coverage   98.04%   98.18%   +0.13%
Files           8        8
Lines         717      717
Branches      184      184
==========================================+ Hits          703      704       +1     + Partials       14       13       -1
Impacted Files https://codecov.io/gh/cldf/pycldf/pull/49?src=pr&el=tree Coverage
Δ
src/pycldf/db.py
https://codecov.io/gh/cldf/pycldf/pull/49?src=pr&el=tree#diff-c3JjL3B5Y2xkZi9kYi5weQ== 97.68%
<0%> (+0.57%) ⬆
Continue to review full report at Codecov
https://codecov.io/gh/cldf/pycldf/pull/49?src=pr&el=continue.
Legend - Click here to learn more
https://docs.codecov.io/docs/codecov-delta
Δ = absolute  (impact), ø = not affected, ? = missing data
Powered by Codecov
https://codecov.io/gh/cldf/pycldf/pull/49?src=pr&el=footer. Last update
1f765b4...0ff5556
https://codecov.io/gh/cldf/pycldf/pull/49?src=pr&el=lastupdated. Read
the comment docs https://docs.codecov.io/docs/pull-request-comments.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/cldf/pycldf/pull/49#issuecomment-343654595, or mute
the thread
https://github.com/notifications/unsubscribe-auth/AA1HKACMUwX_uOoGw3gnAleNvMFPnACqks5s1XRHgaJpZM4QacTS
.

The nice thing is that fixtures can take fixtures themselves and you can also use fixtures to reuse mocks (example).
pytest-mock provides a mocker fixture, so no need to import mock.
The tmpdir fixture from pytest probly already most ofl the pathlib.Path functionality (and more like an .as_cwd() contextmanager).

Yes, tmpdir seems powerful - unfortunately with a different API.

Yeah, sadly slightly different, but I think I would prefer using it in tests rather than tying them to clldutils dependencies (except when maybe a function expects something from there).

I think I didn't find the API to cast a tmpdir path to a string :)


Chat UX: Unstarring messages

When the ReceiveMessageData object that UX receives has the event Content.MessageEvent.Star, it indicates that the starred status of the message has been toggled. So if the message wasn't starred, it now is, and if it was already starred, then it indicates it has been unstarred.
In the UX, the unstarring part seems to be missing. Once starred, a message appears starred forever, even if it may have been unstarred at the server if the user had clicked on the star button again.

@RaswanthMurugan20 @Suchitray kindly fix this issue

Unstarring is not implemented by UX, once a msg is starred it is starred forever


Add optional load balancer configurations

We deployed dgraph on GKE and would like to configure and internal load balancer in order to make available in the entire VPC. Unfortunately, right now there is no way to inject annotations or general load balancer configuration in any of the services provided by the Helm chart.
This PR enables the configuration of load balancer configs, service annotations, and makes it easy to disable the ratel deployment.
This PR addresses some of the features discussed in https://github.com/dgraph-io/charts/issues/6.
TODO list:

[x] bump version
[x] update README
[x] update values.yaml
[x] add load balancer configurations (loadBalancerIP, loadBalancerSourceRanges, and externalTrafficPolicy)
[x] add annotations to services (annotations)
[x] allow disabling ratel through a boolean value

This change is

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

I just noticed this PR includes changes made in https://github.com/dgraph-io/charts/pull/20

Pinging @danielmai, @darkn3rd  or @prashant-shahi to add one more review to this PR.

We'll look at adding these before the next version is published.

The aforementioned issue https://github.com/dgraph-io/charts/issues/6 is now at https://discuss.dgraph.io/t/feedback-ratel-should-be-disabled-by-default-and-available-on-port-80-443/8261

I created a similar PR that is compatible with the current code based on this PR:

https://github.com/dgraph-io/charts/pull/52


how can a normal coder use this ???/ no option give??? how

Please give us a procedure to use it

If you'd like to use this as a developer (I don't recommend it for any other than curiosity though as it is very untested), you can checkout this vscode extension :nerd_face: ! https://github.com/CodedotAl/code-clippy-vscode

thanks i am a dev! flutter
[image: Mailtrack]
https://mailtrack.io?utm_source=gmail&utm_medium=signature&utm_campaign=signaturevirality10&
Sender
notified by
Mailtrack
https://mailtrack.io?utm_source=gmail&utm_medium=signature&utm_campaign=signaturevirality10&
09/27/21,
10:34:22 PM
On Mon, Sep 27, 2021 at 4:30 PM Nathan Cooper @.***>
wrote:

If you'd like to use this as a developer (I don't recommend it for any
other than curiosity though as it is very untested), you can checkout this
vscode extension 🤓 ! https://github.com/CodedotAl/code-clippy-vscode
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/CodedotAl/gpt-code-clippy/issues/67#issuecomment-927784907,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AIRXJSHQLYIKNTE3MSTYWODUEBIXBANCNFSM5EXRQJEQ
.
Triage notifications on the go with GitHub Mobile for iOS
https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675
or Android
https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.

wont use it... very very dofficult to use
[image: Mailtrack]
https://mailtrack.io?utm_source=gmail&utm_medium=signature&utm_campaign=signaturevirality7&
Sender
notified by Mailtrack
https://mailtrack.io?utm_source=gmail&utm_medium=signature&utm_campaign=signaturevirality7&
09/27/21,
10:35:27 PM
On Mon, Sep 27, 2021 at 10:34 PM Faheem Ahmad @.***>
wrote:

thanks i am a dev! flutter
[image: Mailtrack]
https://mailtrack.io?utm_source=gmail&utm_medium=signature&utm_campaign=signaturevirality10& Sender
notified by
Mailtrack
https://mailtrack.io?utm_source=gmail&utm_medium=signature&utm_campaign=signaturevirality10& 09/27/21,
10:34:22 PM
On Mon, Sep 27, 2021 at 4:30 PM Nathan Cooper @.***>
wrote:

If you'd like to use this as a developer (I don't recommend it for any
other than curiosity though as it is very untested), you can checkout this
vscode extension 🤓 ! https://github.com/CodedotAl/code-clippy-vscode
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/CodedotAl/gpt-code-clippy/issues/67#issuecomment-927784907,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AIRXJSHQLYIKNTE3MSTYWODUEBIXBANCNFSM5EXRQJEQ
.
Triage notifications on the go with GitHub Mobile for iOS
https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675
or Android
https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.


Implement RANGE / ALIGN / FILL grammar

What problem does the new feature solve?
It's very useful if we can aggregate over time range like PromQL's range selector on time-series data.
What does the feature do?
Add three new SQL keyword

RANGE
FILL
ALIGN

RANGE
Follow the function. It specifies the time range of data that feed into the range function. Range function should be a superset of window functions.
FILL
Can be either global (at the end of SELECT statement) or local (follow the function). Specifies the default value when a range function doesn't have result (NULL)
ALIGN
Specifies the align step. Default align to calendar, or to the time the query is submitted.
Examples
select tag1, rate(metrics) RANGE 5m, sum(metrics) FILL MAX, sum(metrics) RANGE 10m from t ALIGN 1h FILL NULL;

The above SQL has two range function rate(metrics) RANGE 5m and sum(metrics) RANGE 10m. One computes 5mins rate and one computes 10mins sum. A query can have different RANGE.
The result will be aligned to calendar with 1 hour step. I.e., the result will be at 00:00 a.m., 01:00 a.m etc.
Implementation challenges
No response

Related parser PR: https://github.com/GreptimeTeam/sqlparser-rs/pull/1

As of July 16, the things that have been completed are:

Update of sqlparser,  it can already recognize fill and range grammars
A simple logicalplan rewriter that can rewrite the logic plan generated by datafusion
A simple physical plan implementation, now you can input SELECT avg(a) RANGE '5m' FROM test ALIGN '1h' FILL NULL; from the command line and get a result. (Although the range-select algorithm is not implemented, the entire sql can run correctly with wrong output)

As of July 24, the things that have been completed are:

support calculation/nested expression rewriting | keyword by |  new range_fn rewrite logical in sqlparser
implement macro DFConvert to implement From Trait. Convert the current sqlparser struct to the struct used by datafusion sqlparser.

related pr https://github.com/GreptimeTeam/sqlparser-rs/pull/3
this week:
Implement a simple logical plan rewriter and a basical RangePlan

Support to cast between two different versions of sqlparser https://github.com/GreptimeTeam/sqlparser-rs/pull/3

As of August 7, the things that have been completed are:

logical plan rewriter: fix code review, almost finish https://github.com/GreptimeTeam/greptimedb/pull/2058
fix format of range_fn, related pr: https://github.com/GreptimeTeam/sqlparser-rs/pull/4
Implementaion a physical plan, with unit test and sqlness test. Can execute arbitrary  nested/complex range queries from the cmd, range select can work normally https://github.com/Taylor-lagrange/greptimedb/commit/5549f6ab7ba047937334fe9f3c61ce12f007ed1d

this week:

merge logical plan rewriter/physical plan into codebase
optimize physical plan implementation

@waynexia @Taylor-lagrange  seems implemented?

Yes, the range query function has been implemented, and many bugs in range query have been fixed. Should this issue be closed? @waynexia

Yes, this ticket is fully implemented. Closing it.


<EMAIL_ADDRESS>hang on "Preparing your database"

ENV:
prisma2:  2.0.0-preview019
system:  Deepin Linux 15.11
npm:  6.12.4
node:  v10.16.3
mysql: 5.7
When I try to create a new project.Follow this step

prisma2 init test-server
 > Blank priject
> MySQL
Input db information
> Use Exists database Empty Database
> demo project

than I suck on
✔  Downloading the demo script from GitHub ...
✔  Extracting content to zeitgeber-server ...
✔  Installing dependencies with: `npm install` ...
⠧  Preparing your database ...

at now have been an hour a ago.
I try this step on other machine got the same results.

Centos：7
node: v12.13.0
npm: 6.13.6
Got the same result.
[root@xersoft ~]# prisma2 init test-server

Preparing your starter kit: GraphQL API (+ Auth)

✔  Downloading the starter kit from GitHub ...
✔  Extracting content to test-server ...
✔  Installing dependencies with: `npm install` ...
⠏  Preparing your database ...
5  Seeding your database with: `npm run seed` ...

I am actually able to reproduce this on CentOS 7 on digitalocean with a local mysql server setup within the box but not on locally on macOS.
I ran the command in debug mode and looks like somehow we are sending an invalid database name in CentOS (or basically or rhel based binaries)

(Error report id 1122 for internal use)

Looks like this reoccurrence of #778.
On CentOS the cli is not printing the database name to the schema:

The workaround here would manually add it and run the script. On macOS it prints it correctly.


High CPU usage

When this extension is enabled there's a high CPU usage, to the point where my macbook pro 16 2019 has to increase the fan speed to a considerable frequency.
I confirm that when the extension is disabled, the activity monitor shows a much smaller CPU usage by vscode.

It is most likely sourcekit-lsp. When you are getting higher CPU usage, can you run activity monitor and search for sourcekit, check the amount CPU usage of both sourcekit-lsp and SourceKitService.

Will try again but it was named electron the process, also i am using sourcekit using another extension and works fine, let me report back later

Will try again but it was named electron the process, also i am using sourcekit using another extension and works fine, let me report back later

I also just released 0.5.0, can you check using that version

Since 0.5.0 this issue seems to be fixed. Thanks!


Enhancement: Avoid excessive copying of keys

Description
There is an issue with excessive copying in surrealkv related to handling snapshots and the vart library. This needs to be optimized to avoid unnecessary allocations and copying.
Details
Whenever setting on a snapshot in surrealkv, the terminate method is called on the key:
https://github.com/surrealdb/surrealkv/blob/edab05d1cbc8a97445b9756d52a3584d8f5418ce/src/storage/kv/snapshot.rs#L46
This terminate method performs an unnecessary copy just to extend the data:
https://github.com/surrealdb/vart/blob/5fe7118140e7da5bdf7c6bcd2d05e0f19725aa88/src/lib.rs#L247
The call to terminate shouldn't happen because, during a set/get operation
https://github.com/surrealdb/surrealkv/blob/edab05d1cbc8a97445b9756d52a3584d8f5418ce/src/storage/kv/transaction.rs#L280
, calling on the key invokes the following function:
https://github.com/surrealdb/vart/blob/5fe7118140e7da5bdf7c6bcd2d05e0f19725aa88/src/lib.rs#L284
To optimize, the null byte can be added directly within the function mentioned above to eliminate the unnecessary allocation.
Suggested Solution

Remove the call to terminate on the key in surrealkv.
Add the null byte directly when doing internal conversion.

This change should reduce unnecessary copying and improve performance.

Resolved through https://github.com/surrealdb/surrealkv/pull/122


Wrong description of math notation

Steps to reproduce the problem

Click on 'https://learn.qiskit.org/course/ch-states/representing-qubit-states'
Go to 'Math notations in right sidebar'

What is the current behavior?
Math  notation 1 & 0 are decribed as amplitude of |0> & |1> state respectively. But both the states have amplitude 1 and they are plotted as radial vector in bloch sphere of unit radius.
What is the expected behavior?
Description of these two math notation are not necessary. It can be removed completely. Or it may be described as
0 -> Classical bit value 0
1 -> Classical bit value 1
Screenshots (optional but very helpful)

Environment (optional but very helpful)

Device: Laptop
OS: Windows 11
Browser: Chrome

Additional context (optional)
Add any other context that could help debug the problem.

The problem is that the definitions of ket 0 and ket 1 are both connected to the 1st and 2nd rows (respectively) of the right (0) ket
The entire kets should be annotated and then the descriptions would be appropriate.

This repository is no longer maintained. It has been superseded by IBM Quantum Learning.


hotfix: shorten override name

[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by:
To complete the pull request process, please assign niazhussain
You can assign the PR to them by writing /assign @niazhussain in a comment when ready.
The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

:star: PR built and available in a preview peaqnetwork-peaq-network-ev-charging-sim-be-pr-49 here

[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by:
To complete the pull request process, please assign niazhussain
You can assign the PR to them by writing /assign @niazhussain in a comment when ready.
The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

:star: PR built and available in a preview peaqnetwork-peaq-network-ev-charging-sim-be-pr-49 here

/lgtm

[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: niazhussain
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

OWNERS [niazhussain]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: niazhussain
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

OWNERS [niazhussain]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment


Is there any way to return the exit code from a PowerShell script to Jenkins?

Describe the bug
I'm trying to run a PowerShell script from Jenkins using Azure CLI that is installed in a docker container. The problem is that when the script fails the Jenkins pipeline passes.
This is the response from the Azure CLI
`[Pipeline] sh

az vm run-command invoke --command-id RunPowerShellScript --n AZR -g AM --scripts '& C:\clean_up.ps1'
{
"value": [
{
"code": "ComponentStatus/StdOut/succeeded",
"displayStatus": "Provisioning succeeded",
"level": "Info",
"message": "Uninstalling the previous version \n\nCheck that the previous installer was uninstalled\n\n'App ' NOT is installed.\n\nDelete the previous unistaller\n\nVerify if the folder is empty\n\n\nThe Folder is not empty",
"time": null
},
{
"code": "ComponentStatus/StdErr/succeeded",
"displayStatus": "Provisioning succeeded",
"level": "Info",
"message": "",
"time": null
}
]
}`

here is an example of the Powershell script
Write-Host ""
Write-Host "Uninstalling the previous version of the app"
Write-Host ""
msiexec.exe /x $PATH_TO_MSI /passive
Write-Host "Check that the previous installer was uninstalled"
Write-Host ""
$installed = (Get-ItemProperty  HKLM:\Software\Wow6432Node\Microsoft\Windows\CurrentVersion\Uninstall* | Where { $_.DisplayName -match $software }) -ne $null
If(-Not $installed) {
Write-Host "'$software' NOT is installed.";
Write-Host ""
} else {
Write-Host "'$software' is installed."
Write-Host ""
exit 1
}
I'm expecting if the PowerShell scripts fail that that error can be marked as a failure in  Jenkins.
Can you help me with how to do this?

hi @qwordy could you pls help to have a look? thanks

@yungezz @qwordy  Any Solution for the question above?
Thanks

Use $? or $LASTEXITCODE to get exit code of last command in PowerShell.
Sorry I have little experience of Jenkins. Here is doc of Jenkins. https://www.jenkins.io/doc/


Tests are discovered correctly but then an incorrect argument is supplied to PyTest, leading test-result discovery to fail (Git Submodules?)

Environment data

VS Code version:
Version: 1.61.2
Commit: 6cba118ac49a1b88332f312a8f67186f7f3c1643
Date: 2021-10-19T14:58:13.605Z
Electron: 13.5.1
Chrome: 91.0.4472.164
Node.js: 14.16.0
V8: 9.1.269.39-electron.0
OS: Linux x64 5.4.0-90-generic snap
Extension version (available under the Extensions sidebar): v2021.10.1365161279
OS and version: Ubuntu 20.04
Python version (& distribution if applicable, e.g. Anaconda): 3.8.10
Type of virtual environment used (N/A | venv | virtualenv | conda | ...): None
Relevant/affected Python packages and their versions: PyTest 6.0.0
Relevant/affected Python-related VS Code extensions and their versions: VSCode Native Test Explorer
Value of the python.languageServer setting: Pylance

Expected behaviour
Given the following repo structure:
/work/repos/my_repo
|
-src/
    |
    - main.py
 - dependencies/
      |
     -my_git_submodule/
            - tests/
                   |
                   - test_other_main.py
           ...
-tests/
    |
    - conftest.py
    - test_sometests.py
    - integration_tests/
            |
            - test_integration_main.py

Discovered tests in workspace are run and their results displayed when doing CTRL+SHIFT+P: Test: Run All Tests.
Expect to run the command using the supplied path to the test folder.
Actual behaviour
Pytest fails to run, using the following command:
cwd: /work/repos/my_repo

Causing the error: ERROR  - ModuleNotFoundError: No module named 'tests.integration_tests'
But it runs correctly when only running the tests in the tests folder and that can be achieved by clicking "Run All" on the "tests" subgroup:
> /usr/bin/python3 -m pytest --rootdir /work/repos/my_repo --override-ini junit_family=xunit1 --junit-xml=/tmp/tmp-14347RaAiZqepCFUO.xml ./tests
cwd: /work/repos/my_repo

This works without any issues, however this is not run when doing the VSCode Run All tests function and I have not been able to configure this working to command to be used.
Another way to get it working is ignoring the submodules in dependencies(they should be unit-tested using their own repos workflows) using --ignore-glob=dependencies/* in python.testing.pytestArgs. However I don't see why not manually ignoring submodules should break test(result) discovery.
> /usr/bin/python3 -m pytest --rootdir /work/repos/my_repo --override-ini junit_family=xunit1 --junit-xml=/tmp/tmp-14347jcCkQFFhe9c0.xml --ignore-glob=dependencies/* ./tests
cwd: /work/repos/my_repo

So the first command fails while the two other commands work. I am not sure if it is intended for the first command to fail.
When using pytest from the terminal, all that's required to get it to run is a simple pytest.ini like this:
[pytest]
testpaths =
    tests

and the simply doing pytest with the repo as cwd, no ignoring the dependencies folder required.
Steps to reproduce:
Replicate above repo structure with Pytest files in /tests and in /tests/integration_tests and include another repo as a submodule that also contains its own tests.

This will be resolved with https://github.com/microsoft/vscode-python/issues/17242


Is Zeppelin same as Databricks notebook?

Is Zeppelin same as Databricks notebook? Is this an open source version of Notebook?

Thank you for your interest!
Zeppelin has now migrated to Apache so in case of any further questions it's better to email appropriate mailing list


Improve error message for illagal variable access in WITH/RETURN

Queries like
MATCH (a) RETURN DISTINCT a.name ORDER BY a.age

would fail with a non-helpful error message "Variable a not defined"
This is changed to
In a WITH/RETURN with DISTINCT or an aggregation, it is not possible
to access variables declared before the WITH/RETURN: p

RETURN ... WHERE is illegal syntax. That leaves me with 6 combinations. I added a commit to test all those 6 positively and negatively.


Client is missing required entitlement

After using login for >= 12 iOS - I got this
20-07-05 13:52:53.524581+0600 InstaPro[15062:971119] [ProcessSuspension]  0x1110fd690 - ProcessAssertion() PID 15062 Unable to acquire assertion for process with PID 15117
2020-07-05 13:52:53.524722+0600 InstaPro[15062:961869] [ProcessSuspension] 0x1110fd690 - ProcessAssertion::processAssertionWasInvalidated()
2020-07-05 13:52:53.526214+0600 InstaPro[15062:971119] [assertion] Error acquiring assertion: <NSError: 0x600000242910; domain: RBSAssertionErrorDomain; code: 2; reason: "Client is missing required entitlement"> {
userInfo = {
RBSAssertionAttribute = <RBSLegacyAttribute: 0x7fc1dfc2aac0; requestedReason: FinishTaskUnbounded; reason: FinishTaskUnbounded; flags: PreventTaskSuspend>;
}
}

Nothing to do with SwiftyInsta, per se, it's about background mode.
Apparently you are using some feature related to it without enabling it from the project settings.
Go to your target settings, select Signing & Capabilities from the tab bar, + Capability and choose the specific background mode you require.

I made it but still getting this error

I can't seem to replicate this.
Do you mind providing more info?


Make code sizes a characteristic of the EVM version

PR description
Make the max code size and max initcode size a part of the EVM
configuration. As part of the change we need to move the tasks
CodeFactory once handled as a static class and move it into the EVM.
This has a nice follow on effect that we don't need to pass in max EOF
versions or max code sizes anymore.
Fixed Issue(s)

Thanks for sending a pull request! Have you done the following?

[ ] Checked out our contribution guidelines?
[ ] Considered documentation and added the doc-change-required label to this PR if updates are required.
[ ] Considered the changelog and included an update if required.
[ ] For database changes (e.g. KeyValueSegmentIdentifier) considered compatibility and performed forwards and backwards compatibility tests

Locally, you can run these tests to catch failures early:

[ ] unit tests: ./gradlew build
[ ] acceptance tests: ./gradlew acceptanceTest
[ ] integration tests: ./gradlew integrationTest
[ ] reference tests: ./gradlew ethereum:referenceTests:referenceTests

This is a variant of #7245 removing the ProtocolSpec configurations.  #7245  will remain as the PR where we alter protocol spec creation.

Main config is fine.  Closing and merging the parent PR.


Updating config does not get applied

Allow multiple variables to be set at the same time, triggering a single deployment.

[ ] show a message "the values will be applied at the next deployment"
[ ] implement proper compose start and/or compose restart (which should not need the sources to be available)


Modify Google Maps Zoom Timing

Currently the zoom change only happens when a loaction-specific card is dragged and when a country is lookup up on the select country button.

[ ] Add behavior for zooming when a location-specific card is clicked on.
[ ] Add behavior when a preexisted card is rehighlighted

ex. I look up Cuba, it should zoom to cuba, then when i click the north America hyperlink inside of it, it zooms into north America, and when i click on Cuba hyperlink from the north America card it should zoom into Cuba again

[ ] any zooming cases i forgot about that doesn't currently zoom

this might actually literally boil down to one conditional on build for a card that checks if its the last card on the stack. If so and a location card, zoom into location


Function used in cloning graph does not receive the key

The documentation for graph.clone() states that it receives the value as the first argument, and it's key as the 2nd argument.
However, it only receives the value, the key is not passed as well. (the same applies for edges, the function only gets the value, not the keys for from/to vertices)

Well spotted! Will fix a.s.a.p.


Stage

Will approve upon review

Josh there are some scripts that need to be updated with validation.

Joe, Chris wanted this form to show demographics.


Document polyfills

We should document that we include fetch and Promise polyfills, and have an example of making an AJAX request in the howto (template/README.md).

I'm more than happy to help out with this one 😄
Just making sure, we are talking about something like this right?

Using promises
This project includes a Promise polyfill ... some extra explanation and a link to mdn

AJAX requests

This project includes a fetch polyfill ... some extra explanation and mention that fetch uses promises, etc...

// some example here on how to use fetch

Yep, thanks!

Closing, let’s track this in #531.


updated MultiplierUpdate trait

This solves #12240,
Concerning enforcing the returned Multiplier should be less than Next block fees multiplier , I have put that if the returned multiplier is greater than maximum multiplier then return the maximum multiplier.
I have set maximum multiplier to be Bounded::max_value.
Please instruct me If i can improve the above the logic.
@kianenigma

Duplicate of https://github.com/paritytech/substrate/pull/12282


Fix trailing slash in requests

I don't know if anyone else had the same issue but in GET requests trailing slash was added at the end of request and it resulted in 404 for me as this resource didn't exist

Thanks for the PR! Can you post an example where it breaks?

Sure, snippet looks like this:
const mediaClient = swaddle(baseUris.media);
mediaClient.files.get(serialize({ tenant }), header);

function serialize( obj ) {
  const query = Object.keys(obj).reduce((a, k) => {
    if(obj[k]) a.push(`${k}=${obj[k]}`);
    return a;
  }, []).join('&');

  return query && `?${query}`;
}

when I patched it with my solution everything is OK now.
It is clearly visible in code - if there is no extension to add then every time url is appened with /${part}

Thanks! I just wanted to add a failing test case as well https://github.com/danielstjules/swaddle/commit/f5aa5fa59559656086a9734abe4fecf49ba49cc8

Great, thank you for quick response!


how to install deepspeed in window10?

When i want to install deepspeed in window 10, i meet this problem.

Greetings, I am also a Window 10 user and during the process of installing the dependencies, I also encountered a plethora of issues, one of which resembled the one you are having right now. My suggestion after debugging, going through all of the discussion thread, is to install and set up WSL which comes with Ubuntu running on your local machine, make sure you use venv or conda  to avoid any entrypoint command. Hope this helps you

After I fixed that problem, 'run_main' reported an error on line 167. Jump to the subprocess, reported this error, may I ask you have encountered?

Greetings, I am also a Window 10 user and during the process of installing the dependencies, I also encountered a plethora of issues, one of which resembled the one you are having right now. My suggestion after debugging, going through all of the discussion thread, is to install and set up WSL which comes with Ubuntu running on your local machine, make sure you use venv or conda to avoid any entrypoint command. Hope this helps you

你好，请问一下你是怎么解决的在windows上运行的问题呢？我现在解决了deepspeed的安装，但是还有很多其他的报错比如说nccl的问题，想问一下你是怎么处理的哇


missing main.py

cant find the main.py file per the instructions

@XiangyuZhu-open   please update the code

Thanks for reminding, the code has been updated


Allow running of disease_phenotype.py without UMLS license

This is likely already on the radar - but it would be useful to be able to run the disease_phenotype parser without a UMLS license

Babel now requires that you put a few files that can't be downloaded by the software into the input_data/private directory (see README for details). At the moment this is MRCONSO.RRF and MRSTY.RRF from UMLS (which requires the user to create an account to access the UMLS datasets) and the FDA UNII datasets (but these are going to be removed from here, see https://github.com/TranslatorSRI/Babel/issues/76). Does this meet the needs of this issue?

I don't think we can do much better than this.

It would really be good if translator monarch tims and OMOP would try to lobby UMLS for a public dump of all codes and mappings at least.

I'm going to close this as something we can't do much about, but I agree @matentzn that lobbying UMLS to make a public dump of all codes and mappings would be great! I think a bunch of the licensing issues are around SNOMED; I wonder if they could be convinced to publish a public dataset that only includes NCIt + ontology mappings or something. Alternatively, we could consider building an external resource that puts all the NCIt mappings we know about in one place.


Once a network is encrypted, do not accept clear packets from it

even if sender won't be able to decrypt the responses

Signed-off-by: Alessandro Boch<EMAIL_ADDRESS>

LGTM


⚠ SceneTime has degraded performance

In 5626acf, SceneTime ($ST) experienced degraded performance:

HTTP code: 200
Response time: 5029 ms

Resolved: SceneTime performance has improved in a9b5131.


Environment variable from .yarnrc does not seem to work

I created a .yarnrc file in the repository root with the following contents:
youtube_dl_download_host "https://xxxxxx.s3.xxxxx.amazonaws.com/xxxxxxx"

But when running yarn for installing the dependencies the script does not seem to pick up that configuration. I checked the code for the downloader and it seems like only setting an environment variable is a possible option. So yarn must expand the .yarnrc entry as an environment variable to make that work. However, I did not find any information on yarn being able to expand environment variables from the .yarnrc.
Am I doing something wrong here? If so the README should be a bit clear on how to provide those values via .yarnrc, e.g. by showing an example.
Configuring the link via the rc file would be more convenient as it would cover both CI and local dev environments and does net require setting manual environment variables in the checkout/install steps.

Nevermind figured it out :) Gonna send a pr shortly!
env:
  YOUTUBE_DL_DOWNLOAD_HOST "https://xxxx.s3.xxxx.amazonaws.com/xxxx


[SERVERLESS] Remote Configuration enabled in serverless mode

Hi,
I'm running my app in serverless and I've successfully activate APPSEC and APMS.
I would like to enabled WAF in APPSEC and to do it, I tried to enable REMOTE_CONFIGURATION but I get
2023-08-01 14:23:41 UTC \| DD_EXTENSION \| ERROR \| could not update remote-config state: rpc error: code = Unavailable desc = connection error: desc = "transport: Error while dialing: dial tcp <IP_ADDRESS>:5001: connect: connection refused" | 2023-08-01 14:23:41 UTC \| DD_EXTENSION \| ERROR \| could not update remote-config state: rpc error: code = Unavailable desc = connection error: desc = "transport: Error while dialing: dial tcp <IP_ADDRESS>:5001: connect: connection refused"
-- | --

I've looked at DD_REMOTE_CONFIGURATION_ENABLED in this repo and I cannot find that it's in any folder of serverless
I can see that Datadog knows about my serverless configuration and tracing libraries but doesn't receive anything.

Is there any plan to support it or do you have technical limitations to enable it in serverless mode?
Cheers,
Pedro

Hi Pedro,
Today Remote Configuration is not supported on Serverless Functions or Serverless Container Managed Apps (see Supported Environments). If you'd like to open a feature request feel free to contact our support team
I'm closing this issue, but please reopen if you have any other concerns.
Cheers,
Baptiste


Spaceship's Client can't make a "create" request until after a "get" request

New Issue Checklist

[x] Updated fastlane to the latest version
[x] I read the Contribution Guidelines
[x] I read docs.fastlane.tools
[x] I searched for existing GitHub issues

Issue Description
Spaceship's client will fail to make a "create" request (like PortalClient#create_app! method) until after executing a "get" request (like PortalClient#teams). After checking the difference in the failure or success requests using Charles proxy, a request like teams configures the Csrf and Csrf_ts headers. Without these, "create" requests will fail to succeed.
It would simplify things if after doing login, the client would test it's connectivity with a simple request like teams, which would also configure the required Csrf for future requests.
Workaround for now is to directly call teams after login.

@sergiocampama Is this only an error really when calling the spaceship API directly? Word another way - are actions that use spaceship probably okay since they all should prompt for team? 🤔

Yes, this is when using the client objects directly. Please refer to the other 2 issues I have opened on using the portal client directly:
#11901 and #11816

Thanks for linking those! This is definitely something I saw that needed improving too when exploring through the codebase this past weekend too 💡

still open


gh-contribs: init at 0.9.0

Adds the github-cli extension gh-contribs
Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[x] aarch64-darwin

For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)

[ ] sandbox = relaxed
[ ] sandbox = true

[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[x] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[x] Tested basic functionality of all binary files (usually in ./result/bin/)
24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[ ] Fits CONTRIBUTING.md.

Add a :+1: reaction to pull requests you find important.

nixpkgs-review result
Generated using nixpkgs-review.
Command: nixpkgs-review pr 352927

x86_64-linux

:white_check_mark: 1 package built:

gh-contribs


issue not found pve_exporter.cli

Hi i am getting an error from reding pve_exporter.cli to main
any solution
Traceback (most recent call last):
Aug 02 16:05:08 host pve_exporter[3827475]:   File "/usr/local/bin/pve_exporter", line 5, in
Aug 02 16:05:08 host pve_exporter[3827475]:     from pve_exporter.cli import main
Aug 02 16:05:08 host pve_exporter[3827475]: ModuleNotFoundError: No module named 'pve_exporter'
Aug 02 16:05:08 host systemd[1]: prometheus-pve-exporter.service: Main process exited, code=exited, status=1/FAILURE

This looks like pve_exporter is not (or not properly) installed. This can also happen after a system upgrade (e.g., PVE 7 to PVE 8).
Please reinstall pve_exporter.

its started after upgrade from 7 to 8
i will try to remove and install again
thanks


Add more control fields for articles

Change the user and created fields in the article model for new fields that track who and when the article was created or updated.
Should add the following fields:
updatedAt, default value: Date.now
updatedBy, default value: req.user
createdAt, default value: Date.now
createdBy, default value: req.user

The PR for this issue was merged in, should be resolved.

@ilanbiala @miguelcoba Any idea why this ticket has open closed so many times?  Anything I can help with?

This issue has only been closed then reopened once, it references lots of other things though. I'd like to merge this in, but I think @miguelcoba had some issues with redoing this PR on 0.4.0 instead of master based on the latest comment in #392.

@ilanbiala i see now, I saw 'closed' above on #391, thinking it was this ticket.  My B on not looking more closely.  Thanks, I wont make this mistake twice

@miguelcoba since we haven't done much about it, I'm going to close this PR unless people express strong interest in bringing it back or you can get it into 0.4.x once we have released 0.4.0


Fixed broken link in README.md

Appended web.archive.org to link because original site seems to be down. Maybe we could replicate that example and have it here inside repo?

Thanks!


[OSCI] Adds new author abhinaenae

Description
Adds a new author Abhinaenae
Issues Resolved
[List any issues this PR will resolve]
Check List

[x] Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the BSD-3-Clause License.

Hello @Abhinaenae check out our Day 2 video and start watching from 49:20 and you'll see how to solve DCO issue.
https://www.youtube.com/watch?v=v56sNHkvRrU

Closing as we are past deadline and there are outstanding changes.


[feature] 'Live File' Links for Archived Files

Purpose

Currently, when viewing a file that has been archived in a registration, there is no quick/easy way for a user to see the original version of the archived file. This PR generates a URL when an archived OSFS file is viewed which points to the current live file, provided that it has not been deleted.

Changes

This PR adds the archived_from_id field to the StoredFileNode model, which is then set when a file archived.
This PR also removes the "This project is a registration of this project/component" page alert if there is an archived file link alert to be shown, in order to prevent cluttering the page (shown below).

Notes

An archived live file link will only be generated for OSFS files that are archived after this PR is merged. Links will not be generated for previously archived files, or for add-on files, as we cannot guarantee that we are linking to the correct live file (we can only make an educated guess based on comparing file names).

JIRA

OSF-5160

Pass complete @caseyrollins! :sunny:

@samanehsan, I've added those tests and addressed your comments! I also changed the attribute archived_from_id to be named copied_from_id since it is set when a file is copied.

Taking a look ...

Thanks for making those changes @caseyrollins! Just one more addition to a test & this is good to merge :tada: :sunny:

@samanehsan Done!

Pass finished. Just one question above. Otherwise, this looks good.

@sloria, I changed copied_from to be a ForeignField, so this could use another round of review.

@caseyrollins +1 to making copied_from a ForeignField, but I'm unsure why the properties are necessary. Can you please clarify?

@sloria -- discussed in person -- properties in the FileNode class are necessary to safely access the copied_from field of the StoredFileNode.


feature: make cli doc generation auto finished

Signed-off-by: Allen Sun<EMAIL_ADDRESS>1.Describe what this PR did
This pr makes cli doc auto-generated. With this PR, developers can only maintain code in cli go files, but we should add more detailed information in cli go file. Then with a command pouch gen-doc, corresponding docs will be auto-generated in dir ./doc/commandline/.
vendor related things:
1.Update pkg spf13/cobra;
2.add pkg github.com/cpuguy83/go-md2man
3.add pkg github.com/russross/blackfriday
2.Does this pull request fix one issue?
fixes #216
3.Describe how you did it
Add a command pouch gen-doc to make use of "github.com/spf13/cobra/doc".
4.Describe how to verify it
$ make client
$ ./pouch gen-doc

5.Special notes for reviews
None
/cc @alibaba/pouch @xiang90

LGTM

Thanks for your review. @sunyuan3


Too many redirects when using https url

When setting ENV variable url to http the site works correctly (even on https) but then all the internal links use http as a protocol. When settings the url to https the browser says there are too many redirects. Is there anything I can try?
Thank you for making Ghost.

Found out the problem, had to disable the Plesk docker rule redirect, disable the nginx proxy mode and manually create the nginx proxy configuration, letting ghost know that has been redirected.

Could you please make a mini guide and preview on the code that you had to make?

Sure. Create a virtual machine using docker, set it to a fixed port, then create a domain. I suppose you're already to this phase. Disable any docker proxy rules that you've created in Plesk, then in Apache & nginx settings, set under nginx everything off, and under additional nginx directive past this:
location ^~ /manifest.json {}

location ^~ /OneSignalSDKUpdaterWorker.js {}

location ^~ /OneSignalSDKWorker.js {}

location ^~ /.well-known/ {}

location / {
	proxy_set_header X-Real-IP $remote_addr;
	proxy_set_header X-Forwarded-For $proxy_add_x_forwarded_for;
	proxy_set_header Host $http_host;
	proxy_set_header X-Forwarded-Proto https;
	proxy_pass http://<IP_ADDRESS>:32768;
}

first rows are examples that allow to pierce through the proxy and download files on the actual root of the site, for example to enable Let's Encrypt and load OneSignal javascripts. The last location statement allows to emulate the docker proxy rule, replace 32768 with your actual port.


Best contact for discussion with PhET team?

Hello,
I am the Director of Development for the PhET interactive simulations project, who would be the best contact at your organization to have a discussion about the app you have up on Google play?
Thanks!

Dear Ariel. Thank you for taking contact. Stéphane, a colleague of mine, has just sent you an invitation on LinkedIn so you later can have a phonecall.

Excellent, thank you! I have accepted his invitation and written him back on LinkedIn.

@ariel-phet Ok, I close this ticket then :)


fix: Pin bigframes to < 1.0.0

Background

Deployment of this JSS inside Cloud Console randomly started producing errors related to the Cloud Run web hook.
See Google-internal Chat thread here.
The error was not a result of changes to this repo.
I initially created this pull-request to reproduce the error via integeration tests. I reproduced it; albeit only through the  terraform-genai-knowledge-base-int-trigger check — not through the webhook / test (3.12) check. (Both of these GitHub checks test terraform apply. I'm guessing webhook / test (3.12) didn't fail because it's using a cached version of the image.)

Solution

In the aforementioned Chat thread, @glasnt suggested pinning bigframes to < v1 - based on this StackOverflow post.
It seemed to have worked. See GitHub checks of commits.

Error logs

The Terraform errors:

google_cloudfunctions2_function.webhook: Creation errored after 1m41s
Error waiting for Creating function: Error code 3, message:
Could not create or update Cloud Run service webhook-7b5fb8, Container Healthcheck failed.
Revision 'webhook-7b5fb8-00001-mil' is not ready and cannot serve traffic. The user-provided container failed to start and listen on the port defined provided by the PORT=8080 environment variable.
Logs for this revision might contain more information.

The errors from the Cloud Run Revision itself:

File "/workspace/main.py", line 25, in <module>
    import vertexai  # type: ignore
    ^^^^^^^^^^^^^^^
File "/layers/google.python.pip/pip/lib/python3.12/site-packages/vertexai/__init__.py", line 17, in <module>
    from google.cloud.aiplatform import version as aiplatform_version

The latest version of google-cloud-aiplatform has fixed this.
https://github.com/googleapis/python-aiplatform/commit/cdb8e6afc3791ca5b3c86e516dde2c3f111401f0


Added compatibility for Guzzle 6

I'd like to use spatie/geocoder on a project of mine which depends on Guzzle 6. This is my suggestion on how to solve it. If I missed something, please let me know and I'll try to fix it. All tests are passing. Also, this should fix #18

Nice, thanks! 👍


Graph2Seq: Graph to Sequence Learning with Attention-Based Neural Network

Poster
BUPT/awesome-chatbot#28

@zixia fixed


Threshold lines are vertical in horizontal boxplot view

The threshold lines should rotate to horizontal when switching from vertical to horizontal boxplot view.
Current state:

Demo only issue; probably should use tabs in the demo and switch between horizontal and vertical that way and then you can redefine the threshold config

Should we close this?


List of empty storefront pages that need to be updated later:

Ref. discussion: https://equinor.slack.com/archives/GEF6LDVT9/p1582023866009600

DEV Getting started developers: _https://eds.equinor.com/getting-started/developers/_ Can you look at these pages? The intro page needs to be updated, I can try but better if one of you do it. What about the other 3 pages? Do we need to add links to storybook ++  ?
DEV Remove this? What were we going to say about tokens https://eds.equinor.com/guidelines/tokens/
DEV https://eds.equinor.com/assets/product-icons/library/
What do we do here? Remove the page? We have like 2 product icons now.
DEV https://eds.equinor.com/contributing/developers/ **We should have something here, contact info, something else? **
DEV https://eds.equinor.com/help/resources/ I think this was supposed to be one page with EDS downloads and links like Material and Carbon and others have. Should we have that or remove?
DESIGN https://eds.equinor.com/patterns/common-actions/ some draft content here - might just be copy/paste from Material
DESIGN https://eds.equinor.com/patterns/data-formats/ some draft content here - might just be copy/paste from Material
DESIGN https://eds.equinor.com/patterns/loading/ some draft content here - might just be copy/paste from Material
https://eds.equinor.com/components/buttons-toggle/ content coming
https://eds.equinor.com/components/date-picker/usage/ and overview Lotte working on this, just remove from menu
https://eds.equinor.com/help/faq/ some content here  - delete for now
https://eds.equinor.com/patterns/empty-states/ Empty - remove
https://eds.equinor.com/patterns/launch-screens/ Empty - remove
https://eds.equinor.com/patterns/onboarding/ Empty - remove
https://eds.equinor.com/assets/system-icons/usage/ Mode was Publish instead of publish. Fixed

@BeckyBrekke is this still relevant?

Don't think these are relevant anymore.


org.zalando.logbook.okhttp.LocalRequest doesn't compile?

Line 92:
.method(request.method(), create(body, entity.contentType()))
the call of create doesn't seem to be correct as it expects create(entity.contentType(), body).
How did you manage to compile that? I have okhttp:3.8.1 on my classpath (same as latest logbook-okhttp)

Oh, I am sorry, I see the library actually has 4.2.2. I assume IDEA meant you had the same


[P1] Storage: Add Blob/Queue/File prefix to SignedIdentifier and RetentionPolicy

Follow up from #8607 - we should update anything returned from *ServiceClient.GetProperties with a service prefix so devs using multiple services don't get conflicts.

And GeoReplicationStatus


Cleanup exception/rejection handler before replacing.

Attempts to address comment: https://github.com/winstonjs/winston/pull/1824#issuecomment-784935345

@wbt Do we still need this PR in light of #1973 ?

LOL I made the same PR twice because I'd forgotten that I'd previously submitted this one.


Ignoring certain attributes

Hi esteemed idom authors,
We are using a UI framework which, when upgrading components to a decorated state, adds an attribute to the element being upgraded.
Sometimes, when we render over these upgraded components with idom, the upgraded components get trampled, presumably because the attribute signaling its upgrade is removed, having been added after idom’s initial render.
So, my question: is there a mechanism to skip certain named attributes in the DOM, if they are found during idom render, but aren’t present in the template?
We are driving idom from Soy, so, for us, some JSAPI change or addition might solve this (I.e. a config object passed to ‘IncrementalDOM.patch’).
We can’t use the skip calls, for instance, because those would have to be generated by Soy.
Thank you in advance for your time and help

I think you can intercept changes to attributes
https://github.com/google/incremental-dom/blob/master/src/attributes.ts

@iteriani i see, so i could register an attribute mutator, and then just return the value i'm given to maintain what's there? i'll give this a try, thank you.

Yeah so somewhere in bootstrap you just do
incrementaldom.attributes['someAttribute'] = (el:Element, name: string, newAttribute: unknown) => {...}

@iteriani this was fantastic and worked for our case, thank you
however, i was wondering if there is a way to skip subtrees for a given node, when there is an attribute present?
coming back to this issue, it solves the trampling of the attribute, but not the trampling of sub-dom which would now be managed by JavaScript.
basically, what i'm looking for here, is a similar way to filter render calls - but to innerHTML rather than a regular attribute. is this supported? the intention would be, ignore innerHTML attribute changes for any element with a given attribute set, for instance, data-upgraded="...".

We have something like this. There's an API for elements that's just
element/applyAttribute/close where you can do something like
open(...)
if(!currentElement.hasAttribute(...)) {}
else { skip()}
On Tue, Oct 29, 2019, 12:35 PM Sam Gammon<EMAIL_ADDRESS>wrote:

@iteriani https://github.com/iteriani this was fantastic and worked for
our case, thank you
however, i was wondering if there is a way to skip subtrees for a given
node, when there is an attribute present?
coming back to this issue, it solves the trampling of the attribute, but
not the trampling of sub-dom which would now be managed by JavaScript.
basically, what i'm looking for here, is a similar way to filter render
calls - but to innerHTML rather than a regular attribute. is this
supported? the intention would be, ignore innerHTML attribute changes for
any element with a given attribute set, for instance, data-upgraded="...".
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/google/incremental-dom/issues/412?email_source=notifications&email_token=AA2MCG7YTDSA2HUI3SXD75TQRCGBXA5CNFSM4IEI72IKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOECRZ6CI#issuecomment-547593993,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AA2MCGZHZRHTCSJPCWKQ4IDQRCGBXANCNFSM4IEI72IA
.

You can also use elementOpen / elementClose, no need to use open/close directly (unless you want to). Just make sure to call the close call in both flows:
const el = elementOpen('div');
// Check for some attribute or DOM property
if(!el._rendered) {
  // Render some DOM, set `innerHTML` or whatever
  el._rendered = true;
} else {
  skip();
}
elementClose('div');


[WFLY-18971] Upgrade ByteBuddy to 1.14.11

https://issues.redhat.com/browse/WFLY-18971

Thanks @ropalka, @scottmarlow and @Sanne!


UI should differentiate between Partitioned Tables and Partition-Aware Source Tables

If I have a PartitionAwareSourceTable, I get the partitioned table viewer in the UI, which is very helpful, but a bit confusing because it tells me I have a "Partitioned Table":

It is a partitioned table in the sense that "it is a table, and it has partitions", but it's not an actual io.deephaven.engine.table.PartitionedTable.
It would be helpful if there were some way to see in the UI what the actual table type is (like some small text under "where it says "Partitioned Table" with the class name...or even a tooltip when you hover over "Partitioned Table", or the table's tab).

@rbasralian Why is it important to know the distinction in the UI? I don't think the UI can get this information at this point.

It's not a huge deal but it's confusing. The words "partitioned table" mean something different & pretty specific when you're writing a query. In this case I had a regular table not a PartitionedTable, and I got hung up for a few minutes trying to understand what table operations like .where() would actually return and whether I'd have to call .merge() at some point in the query.
The "Merge" button in the UI makes it even more confusing, because with a PartitionAwareSourceTable like this, you generally don't think of "view all partitions" as a "merge" operation — since it's not actually a merge() but rather a .where() with no arguments.

I think our partitioning UI and underlying data models intentionally make both kinds of tables behave as if they were the same. This is probably fine for basic use cases but might be confusing when the table type is important. I also had this issue once and had to call .getClass() on a table object to get this information.

@rbasralian We could re-label Partitioned table as Partition-aware source table and change the Merge button to something more appropriate. Would the label Coalesce make more sense for partition-aware source tables? Or something else?

See #2079 for details


install target when built without curl or tests

Long story short, I'm creating a FreeBSD port for cpr. It doesn't want to install without defining an install target in the Makefile. Please add one.
Thank you very much in advance.

Gotta provide the patch and maybe file a pull request for it.

There's a bunch of PR's that do this right now, most recently this one: https://github.com/whoshuu/cpr/pull/277
I haven't had time to review and test them. Since demand for this seems pretty high I'll see if I can find the time to do that within the week.

This resolves the issue, thank you @whoshuu


Different versions for nox and maturin build

I have found that the python interpreter versions for maturin and nox are in different versions:
# Makefile

build:
	maturin build --interpreter python3.7 python3.8 python3.9 python3.10 python3.11

#noxfile.py

@nox.session(python=["3.8", "3.9", "3.10", "3.11", "3.12", "3.13"])
def test(session):
    session.install("-rrequirements-dev.txt")
    session.install("-e", ".", "--no-build-isolation")
    session.run("pytest", *session.posargs)

Will this lead to unexpected behavior?

I don't think that makefile is used anywhere. The CI doesn't, for example. I think we should just delete it.

I think the makefile is still useful for testing. It helps me build the latest tantivy (local) binary for my testing in one command, I think we should not discard it.

For this I just run maturin develop which builds the extension and installs it into a local venv. Is there anything the makefile gives beyond this?
Could you describe your workflow in more detail?

For this I just run maturin develop which builds the extension and installs it into a local venv. Is there anything the makefile gives beyond this?
Could you describe your workflow in more detail?

Oops I just found that the nox command does its job. The Makefile should be safe to discard


feat(spanner): add support for Customer Managed Encryption Key (CMEK)

NOTE: The emulator GA is failing due to an issue with grpc v1.36. See #3911


Request: Add a Community tab to the existing VRFs, prefixes and pools tabs/sections

It would be useful if we could gather our communities in NIPAP as well, since we already have RTs, prefixes and pools already.
Columns like "Community", "Type", "IPv4", "IPv6", "Description" and "Typical use" ;-)

That would be useful :)


[DO NOT MERGE] Auto PR to update dependencies of istio

This PR will be merged automatically once checks are successful.
none

@istio-testing: The following test failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-pilot-e2e.sh
d82642f6163c09c3b06f9bcbe7948ef8c1d8a33a
link
/test istio-pilot-e2e

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.


ref(*): removes unnecessary namespace check

This commit removes an unnecessary call to check if the namespace
is monitored which is already checked by ListMultiClusterServices().
resolves #4248
Signed-off-by: Michelle Noorali<EMAIL_ADDRESS>Please mark with X for applicable areas.
-->
Affected area:

Functional Area

New Functionality
[ ]

CI System
[ ]

CLI Tool
[ ]

Certificate Management
[ ]

Control Plane
[X ]

Demo
[ ]

Documentation
[ ]

Egress
[ ]

Ingress
[ ]

Install
[ ]

Networking
[ ]

Observability
[ ]

Performance
[ ]

SMI Policy
[ ]

Security
[ ]

Sidecar Injection
[ ]

Tests
[ ]

Upgrade
[ ]

Other
[ ]

Please answer the following questions with yes/no.

Does this change contain code from or inspired by another project? No

Did you notify the maintainers and provide attribution? NA

Is this a breaking change? No

Codecov Report

Merging #4251 (ca8e7ea) into main (75562ac) will increase coverage by 0.13%.
The diff coverage is 82.27%.

@@            Coverage Diff             @@
##             main    #4251      +/-   ##
==========================================
+ Coverage   69.57%   69.71%   +0.13%
==========================================
  Files         211      211
  Lines       11436    11495      +59
==========================================
+ Hits         7957     8014      +57
- Misses       3430     3432       +2
  Partials       49       49

Flag
Coverage Δ

unittests
69.71% <82.27%> (+0.13%)
:arrow_up:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files
Coverage Δ

pkg/envoy/ads/grpc.go
0.00% <0.00%> (ø)

pkg/envoy/ads/stream.go
10.60% <0.00%> (+0.26%)
:arrow_up:

pkg/ingress/client.go
81.08% <ø> (+1.08%)
:arrow_up:

pkg/messaging/broker.go
95.72% <92.64%> (-4.28%)
:arrow_down:

pkg/policy/client.go
83.78% <100.00%> (+1.35%)
:arrow_up:

pkg/certificate/rotor/rotor.go
84.37% <0.00%> (-3.13%)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5ae6244...ca8e7ea. Read the comment docs.


Number Guessing Game - HTML, CSS, JS

Can I contribute a number guessing game I made? I would like to get an accepted PR for hactoberfest.

okaay


add ${workspaceFolder}  to "PYTHONPATH" in launch.son by default

Hi, I'm new User of VScode. Previously I used Jetbrains Pycharm and not for a long time ago switched to VSCode.
Please add
"env": {
"PYTHONPATH": "${workspaceFolder}"
}
as default configuration parameters, when create to launch.json
Pycharm did it for a long time ago
Thank you in advance

Thanks for the issue. Pylance doesn't actually handle debugging of Python code. Transferring.

@Akopov4 You see an issue when you run or you see it with handling of imports in the editor?

it's not an issue, it's feature request

@karthiknadig

"env": {
"PYTHONPATH": "${workspaceFolder}"
}

without it, when a user tries to run python file in debugger, import statement rooted from workspace root won't be resolved at runtime even if it is resolved at editing time due to our import resolve heuristic.
root/
        lib/
             __init__.py
             module.py
             currentfile.py

currentfile.py
import module # this will work at runtime and edit time
import lib.module # this won't work at runtime but will work at edit time.

user might want it to just work when debugging?
that said, if user run currentfile.py from terminal, it still won't work unless user add root to sys.path in some ways such as setting PYTHONPATH env var or sys.path.append(...) from code.
user could use .env for it to be set on terminal but when user run it in regular command line it won't work again.
but it will at least make it to just work for debugger?

maybe "PYTHONPATH": "${workspaceFolder};${env:PYTHONPATH}", would be better for reason that there were already PYTHONPATH environmental variable set

@heejaechang typical directories like .vscode, .idea and so on are included in gitignore file. So they don't affect production codes.


"Top count" is not applied in Portals query string

I'm getting an issue on Dataverse Rest Builder for XrmToolBox. I'm trying to use a "top count" but the $top=X insn't applied in  querystring. I'm using the lastest version (<IP_ADDRESS>).
Regards.

can you post a screenshot of the request and a screenshot of the generated code?
the top clause is missing from all the generated code options or just one?
Thanks

The top clouse is missing in the Portals tab.

thanks for the screenshots. In the other requests (except Xrm.WebApi) I use the odata.maxpagesize header (because $top can't be used together with $count option (documentation link: https://learn.microsoft.com/en-us/power-apps/developer/data-platform/webapi/query-data-web-api#use-top-query-option)
I am not sure if a header can be passed to a safeAjax without destroying the existing header (__RequestVerificationToken, required for the authentication).
For your specific situation I suggest to add manually the $top clause, meanwhile I will try to check how the Portals call acts with a supplied header.
Thanks for reporting the issue.

@mgdevelop-hub quick update about this issue. Next version of DRB will contain the correct header (odata.maxpagesize) to implement the top count functionality also inside Portals. I can't give you an exact date when it will be released as I plan to fix some other parts too.

@mgdevelop-hub I released a new version of Dataverse REST Builder (<IP_ADDRESS>) and now supports the Top Count clause for the Portals syntax.
Thanks again for reporting the issue.


what should interrupt do when records in fault queue ?

let wire interrupt as an example. When two faults occur in fault queue in time series, and the first fault record is stored in fault queue, the interrupt is assert, then the software detect the interrupt and start to deal with the fault record and deassert the fip. However, at the same time, the next fault record is arrive and stored in fault queue but software not detect it and the interrupt is deassert, software lost a attention which the next fault record is stored in fault queue?
is the software do right ? or the interrupt stay assert when records in fault queue rather than this is a new record ?
the same condition for fqmf , fqof or other queues interrupt handle.

The guidelines for handling interrupts are provided in section 6.5 of the specification. The sequence to follow is to first clear fip and then read the the fqt/fqh to process the fault records. In your example, if this sequence is followed then the fqt and fqh will be 1 record apart leading to software processing one fault record. A second fault record if produced after clearing of fip will cause fip to be set again but software may not observe it. This is however okay as when the interrupt service routine completes there is another interrupt pending and the ISR will be invoked again to handle the second interrupt.

Thanks.

I don't quite understand this sentence.

A second fault record if produced after clearing of fip will cause fip to be set again but software may not observe it.  This is however okay as when the interrupt service routine completes there is another interrupt pending and the ISR will be invoked again to handle the second interrupt.

So if the bit fip is set to 0 from 1 because of software clearing and the hardware wants to set the fip to 1 again because of a fault recorded produced in the fq at the same cycle, should the fip set to 0 from 1 at the first cycle and set to 1 again at the second cycle? Or it is not necessary to set the fip to 1 again. It is just okey to wait another fault record to set the fip to 1 and both of fault records will resolved together.


KAFKA-3112: Change verification of bootstrap servers

so that unresolvable DNS names are ignored and only throw an error if no other bootstrap servers are resolvable.

The contribution is my original work and that I license the work to the project under the project's open source license.

Thanks for the patch. Could you change the title of the PR to lead with "KAFKA-3112: "? A unit test would be great too.

Done & done.  There's also a test in KafkaProducerTest which goes through this code.

@bondj Thanks for the update.
One thing to note is that any invalid url will no longer be a part of the bootstrap, even if it is resolvable later because most usage is something like this:
List<InetSocketAddress> addresses = ClientUtils.parseAndValidateAddresses(config.getList(ConsumerConfig.BOOTSTRAP_SERVERS_CONFIG));
this.metadata.update(Cluster.bootstrap(addresses), 0);

I would like some others to confirm thats acceptable. @ewencp @ijuma ?
The name of the method parseAndValidateAddresses doesn't make it totally clear that it could filter out and return a subset of addresses, though its purpose is clearly for bootstrap use given the logging inside the method and its current usage in the project. I think some simple javadoc on the behavior of the method would be useful.
Otherwise LGTM.

Also noting this change looks to be very similar/duplicate to KAFKA-2657 with #336. Closing one should resolve the other. I have linked them in Jira.

Good point with regards to #336 @granthenke. It would be good to understand why unresolvable DNS names are present and whether this is a temporary failure or a permanent one. It does seem a bit odd to remove it from the list if it's just a temporary failure.

@ijuma My understanding is the modified bootstrap servers list is only used during the initialisation and constructor of the client.  Once used to bootstrap, the node information is all replaced with the current metadata, and then refreshed periodically.
The benefit of the fix is that it allows the client to start if any one of the bootstrap servers are resolvable. We might have a connectivity problem to a single node when we actually start to send messages, but this can be fixed through the usual refresh cycle of the metadata as and when the system as a whole becomes aware of the issue.
It reduces the impact of a single bad DNS record from preventing the client to start, to bad connectivity to a single broker, until the DNS problem is resolved - or the metadata is updated to include a new broker with a better DNS entry.
Preventing the startup of the client because of one bad dns entry when there are others which are usable seems overly restrictive.  If there are no servers resolvable the client should be prevented from starting and throwing the relevant exception.

@bondj There is a discussion about using the bootstrap servers after initialisation under some failure scenarios in KAFKA-3068.

@ijuma I think this approach is a reasonable compromise given that we'd want to exclude the bad hostnames from the Cluster. Maybe the right solution is to do this (which has no negative affect re: KAFKA-3068 given current code doesn't actually replace with the bootstrap servers, just keeps track of seen nodes). Then KAFKA-3068 can address whether the full original list is re-loaded or we use the filtered version based on this code when it switches to reverting to the original bootstrap servers list.

@ewencp fine by me.

@ewencp Should this go in now then, with a follow up in KAFKA-3068?
Note: It should also close KAFKA-2657.

@granthenke @ewencp @ijuma will this be included in to the next release of kafka?

@bondj, the gist of the change seems fine. Can you please address @ewencp's two comments? I'll merge it to trunk once you do.

@ijuma done!

LGTM, merged to trunk and 0.10.0 branches.


Not able to configure AWS Redshift DB with DBeaver update 23.2.1

Description
While setting up AWS Redshift DB on DBeaver( v23.2.1), I am getting below error and due to which not able to use Redshift DB.
ERROR: relation "pg_catalog.pg_enum" does not exist

Kindly please help and look into it.
DBeaver Version
23.2.1
Operating System
macOS ventura 13.6
Database and driver
Amazon Redshift
Steps to reproduce
Just setup any Redshift DB cluster and do the 'Test Connection'. This error will come.
Additional context
I am using SSH tunnel for configuring Redshift

Thanks for the report.
This is a duplicate of #21293
Rerelease is available at https://dbeaver.io/files/23.2.1/


JS library - Changed closure args

WHY
BEFORE - What was wrong? What was happening before this PR?
The event was first, even if it was rarely or never used.
crud.field('visible').onChange((event, value) => {
  crud.field('visible_where').show(value === 1);
});

AFTER - What is happening after this PR?
field is first, event is second 👌
crud.field('visible').onChange(field => {
  crud.field('visible_where').show(field.value === 1);
});

🎉 ALSO 🎉
CrudField class is binded to the closure, so this can also be done;
crud.field('visible').onChange(function() {
  crud.field('visible_where').show(this.value === 1);
});

Although I prefer the first option 🤷♂
Is it a breaking change?
Yes, it changes the order of the closure args, so I'm also pushing a PR to the demo.
https://github.com/Laravel-Backpack/demo/pull/391

https://github.com/Laravel-Backpack/demo/pull/391 is open to test this PR.

I've tried this (in https://github.com/Laravel-Backpack/demo/pull/391), and it seems to work ok up to a point... where we start using crud().field('smth').input - that's where things stop working, I assume because this needs https://github.com/Laravel-Backpack/CRUD/pull/4391 to be merged first.
So right now, Scenarios 9 and 10 are not working. In order to get them to work we need to:

[ ] @promatik fix merge conflicts in https://github.com/Laravel-Backpack/CRUD/pull/4391
[ ] @tabacitu test and merge https://github.com/Laravel-Backpack/CRUD/pull/4391
[ ] @tabacitu test and merge this PR, along with https://github.com/Laravel-Backpack/demo/pull/391

@tabacitu important note here.
@pxpm may(must?) also change the way the repeatable works, because it has its own way to trigger the callbacks.

@promatik heads-up. Since this didn't actually depend on removing jQuery, I've merged it. I've also changed the demo PR to put back jQuery - that way we're down 2 PRs so we can better focus.


rename and change haste-task-webpack-dev-server to haste-task-express

Codecov Report

Merging #108 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #108   +/-   ##
=======================================
  Coverage   96.01%   96.01%
=======================================
  Files          18       18
  Lines         201      201
  Branches       20       20
=======================================
  Hits          193      193
  Misses          8        8

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5f1a6eb...275e619. Read the comment docs.

I think we shouldn't maintain code that we don't use or need right now, if we need we can always bring it back. Let's keep it and remove it a bit later if we decide we don't need it atm.


shovel: rpc client improvements

Right now the rpc client requests blocks, transactions, and logs for each block that it is processing. If an integration is indexing block/tx/log data then all of this data is required. However, if a task's integrations only require log data, then we can omit the request for block data.

If an integration provides a filter_op on the log_addr field, the filter_arg should be propagated to eth_getLogs.

If an integration requests tx_status then the rpc client should also request the receipts for the block. (more data)

This has been fixed in #222


Update keycloak-adapter-core to 25.0.3 in scala-steward-dependencies

About this PR
📦 Updates org.keycloak:keycloak-adapter-core from 24.0.5 to 25.0.3 ⚠
Usage
✅ Please merge!
I'll automatically update this PR to resolve conflicts as long as you don't change it yourself.
If you'd like to skip this version, you can just close this PR. If you have any feedback, just mention me in the comments below.
Configure Scala Steward for your repository with a .scala-steward.conf file.
Have a fantastic day writing Scala!

⚙ Adjust future updates
Add this to your .scala-steward.conf file to ignore future updates of this dependency:
updates.ignore = [ { groupId = "org.keycloak", artifactId = "keycloak-adapter-core" } ]

Or, add this to slow down future updates of this dependency:
dependencyOverrides = [{
  pullRequests = { frequency = "30 days" },
  dependency = { groupId = "org.keycloak", artifactId = "keycloak-adapter-core" }
}]

labels: library-update, early-semver-major, semver-spec-major, commit-count:1

Not signed


Move Apache rewrite rules out of Dockerfiles

Having the rewrite rules in a single shared file ensures that the latest
updates are always in the environment used for development as well as the
deployable docker image.
This change also removes the need for potentially complicated escaping
required when using "echo >".
Signed-off-by: Ryan Beck-Buysse<EMAIL_ADDRESS>

Testing instructions:
Deployable image:
just docker-build
docker run -it --rm -p 8080:80 splintercommunity/splinter-docs
open http://localhost:8080/docs/0.5/concepts/application_authorization.html

Observe that your browser has been redirected to 0.6 and the 302 in the logs.
Dev environment:
just run
wait for the site to generate
open http://localhost:8080/docs/0.5/tutorials/configuring_splinter_nodes_with_docker.html
Observe that your browser has been redirected to 0.6 and the 302 in the logs.


Provide easier way for people to share game and get back to it to iterate

From Maggie's feedback:
Is there a reason why we can't have permanent URLs? Would make it easier for small bugfixes and if we could customize URLs, it would be easier to share
(and I second... I was confused about where my game is 'stored', and didn't know it could disappear from 'recent'.

Tried to clarify local storage by turning it into saving instead of recent. Can't have persistent urls with a backend which we don't want to add at the moment because the investment it incurs.


Windows Setup Failure, including wheels

Hello,
I am terribly sorry but I am really struggling to fix the following issue
I have tried installing: MPI and MPI4py, as well as all the
When trying to run the following via pip:
This is the response:
C:\>pip install charm4py
Collecting charm4py
  Using cached charm4py-1.0.tar.gz (3.4 MB)
Requirement already satisfied: numpy>=1.10.0 in c:\users\dylan\appdata\local\programs\python\python37-32\lib\site-packages (from charm4py) (1.18.5)
Requirement already satisfied: greenlet in c:\users\dylan\appdata\local\programs\python\python37-32\lib\site-packages (from charm4py) (0.4.16)
Building wheels for collected packages: charm4py
  Building wheel for charm4py (setup.py) ... error
  ERROR: Command errored out with exit status 1:
   command: 'c:\users\dylan\appdata\local\programs\python\python37-32\python.exe' -u -c 'import sys, setuptools, tokenize; sys.argv[0] = '"'"'C:\\Users\\Dylan\\AppData\\Local\\Temp\\pip-install-vrwss169\\charm4py\\setup.py'"'"'; __file__='"'"'C:\\Users\\Dylan\\AppData\\Local\\Temp\\pip-install-vrwss169\\charm4py\\setup.py'"'"';f=getattr(tokenize, '"'"'open'"'"', open)(__file__);code=f.read().replace('"'"'\r\n'"'"', '"'"'\n'"'"');f.close();exec(compile(code, __file__, '"'"'exec'"'"'))' bdist_wheel -d 'C:\Users\Dylan\AppData\Local\Temp\pip-wheel-5sx356ud'
       cwd: C:\Users\Dylan\AppData\Local\Temp\pip-install-vrwss169\charm4py\
  Complete output (10 lines):
  running bdist_wheel
  running build
  running build_py
  creating build
  creating build\lib.win32-3.7
  creating build\lib.win32-3.7\charm4py
  creating build\lib.win32-3.7\charm4py\.libs
  creating C:\Users\Dylan\AppData\Local\Temp\pip-install-vrwss169\charm4py\charm4py\.libs
  creating build\lib.win32-3.7\charmrun
  error: Building charm++ from setup.py not currently supported on Windows. Please download a Charm4py binary wheel (64-bit Python required)**
  ----------------------------------------
  ERROR: Failed building wheel for charm4py
  Running setup.py clean for charm4py
Failed to build charm4py
DEPRECATION: Could not build wheels for charm4py which do not use PEP 517. pip will fall back to legacy 'setup.py install' for these. pip 21.0 will remove support for this functionality. A possible replacement is to fix the wheel build issue reported above. You can find discussion regarding this at https://github.com/pypa/pip/issues/8368.
Installing collected packages: charm4py
    Running setup.py install for charm4py ... error
    ERROR: Command errored out with exit status 1:
     command: 'c:\users\dylan\appdata\local\programs\python\python37-32\python.exe' -u -c 'import sys, setuptools, tokenize; sys.argv[0] = '"'"'C:\\Users\\Dylan\\AppData\\Local\\Temp\\pip-install-vrwss169\\charm4py\\setup.py'"'"'; __file__='"'"'C:\\Users\\Dylan\\AppData\\Local\\Temp\\pip-install-vrwss169\\charm4py\\setup.py'"'"';f=getattr(tokenize, '"'"'open'"'"', open)(__file__);code=f.read().replace('"'"'\r\n'"'"', '"'"'\n'"'"');f.close();exec(compile(code, __file__, '"'"'exec'"'"'))' install --record 'C:\Users\Dylan\AppData\Local\Temp\pip-record-ild1vqpv\install-record.txt' --single-version-externally-managed --compile --install-headers 'c:\users\dylan\appdata\local\programs\python\python37-32\Include\charm4py'
         cwd: C:\Users\Dylan\AppData\Local\Temp\pip-install-vrwss169\charm4py\
    Complete output (9 lines):
    running install
    running build
    running build_py
    creating build
    creating build\lib.win32-3.7
    creating build\lib.win32-3.7\charm4py
    creating build\lib.win32-3.7\charm4py\.libs
    creating build\lib.win32-3.7\charmrun
    error: Building charm++ from setup.py not currently supported on Windows. Please download a Charm4py binary wheel (64-bit Python required)
    ----------------------------------------
ERROR: Command errored out with exit status 1: 'c:\users\dylan\appdata\local\programs\python\python37-32\python.exe' -u -c 'import sys, setuptools, tokenize; sys.argv[0] = '"'"'C:\\Users\\Dylan\\AppData\\Local\\Temp\\pip-install-vrwss169\\charm4py\\setup.py'"'"'; __file__='"'"'C:\\Users\\Dylan\\AppData\\Local\\Temp\\pip-install-vrwss169\\charm4py\\setup.py'"'"';f=getattr(tokenize, '"'"'open'"'"', open)(__file__);code=f.read().replace('"'"'\r\n'"'"', '"'"'\n'"'"');f.close();exec(compile(code, __file__, '"'"'exec'"'"'))' install --record 'C:\Users\Dylan\AppData\Local\Temp\pip-record-ild1vqpv\install-record.txt' --single-version-externally-managed --compile --install-headers 'c:\users\dylan\appdata\local\programs\python\python37-32\Include\charm4py' Check the logs for full command output.

When I run via no Binary option
I get:
C:\>pip3 install [--mpi] charm4py --no-binary charm4py
ERROR: Exception:
Traceback (most recent call last):
  File "c:\users\dylan\appdata\local\programs\python\python37-32\lib\site-packages\pip\_vendor\packaging\requirements.py", line 98, in __init__
    req = REQUIREMENT.parseString(requirement_string)
  File "c:\users\dylan\appdata\local\programs\python\python37-32\lib\site-packages\pip\_vendor\pyparsing.py", line 1955, in parseString
    raise exc
  File "c:\users\dylan\appdata\local\programs\python\python37-32\lib\site-packages\pip\_vendor\pyparsing.py", line 3814, in parseImpl
    raise ParseException(instring, loc, self.errmsg, self)
pip._vendor.pyparsing.ParseException: Expected stringEnd, found '['  (at char 11), (line:1, col:12)

During handling of the above exception, another exception occurred:

Traceback (most recent call last):
  File "c:\users\dylan\appdata\local\programs\python\python37-32\lib\site-packages\pip\_internal\cli\base_command.py", line 216, in _main
    status = self.run(options, args)
  File "c:\users\dylan\appdata\local\programs\python\python37-32\lib\site-packages\pip\_internal\cli\req_command.py", line 182, in wrapper
    return func(self, options, args)
  File "c:\users\dylan\appdata\local\programs\python\python37-32\lib\site-packages\pip\_internal\commands\install.py", line 295, in run
    reqs = self.get_requirements(args, options, finder, session)
  File "c:\users\dylan\appdata\local\programs\python\python37-32\lib\site-packages\pip\_internal\cli\req_command.py", line 319, in get_requirements
    user_supplied=True,
  File "c:\users\dylan\appdata\local\programs\python\python37-32\lib\site-packages\pip\_internal\req\constructors.py", line 409, in install_req_from_line
    parts = parse_req_from_line(name, line_source)
  File "c:\users\dylan\appdata\local\programs\python\python37-32\lib\site-packages\pip\_internal\req\constructors.py", line 349, in parse_req_from_line
    extras = convert_extras(extras_as_string)
  File "c:\users\dylan\appdata\local\programs\python\python37-32\lib\site-packages\pip\_internal\req\constructors.py", line 75, in convert_extras
    return Requirement("placeholder" + extras.lower()).extras
  File "c:\users\dylan\appdata\local\programs\python\python37-32\lib\site-packages\pip\_vendor\packaging\requirements.py", line 102, in __init__
    requirement_string[e.loc : e.loc + 8], e.msg
pip._vendor.packaging.requirements.InvalidRequirement: Parse error at "'[--mpi]'": Expected stringEnd

I  have also tried all the windows wheels and each says that they are not compatible.
Please help

Please try to download a precompiled wheel for Windows from here: https://pypi.org/project/charm4py/#files