Add support for Browserify

This line does not work in browserify, because this is not the window:
this.MutationObserver = this.MutationObserver || this.WebKitMutationObserver || (function(){/* ... */})(void 0);

Changing it to this works:
this.MutationObserver = window.MutationObserver || window.WebKitMutationObserver || (function(){/* ... */})(void 0);

@megawac This is the same for require.js

@stephanebachelier I've only used AMD via dojo, is the wrapper (https://github.com/stephanebachelier/MutationObserver.js/commit/0d93d9d6e2eb2a57058206aa4d1dc02ad2a2a9b9) really necessary for require.js support?

@megawac I forgot to update my comment. It was too much pain to modify the tests for ... no gain.
You're absolutely right: no need for AMD wrapper. The MutationObserver must be attached to window.

Sweet, should be good I hope in that case. Can you confirm whether something like this would be possible with require?
require.config({
    shim: {
        MutationObserver: {
            exports: 'MutationObserver'
        },
        c3: {
           deps: ["MutationObserver"]
        }
    },
    paths: {
        MutationObserver: window.MutationObserver ? null : "/depends/MutationObserver/dist/mutationobserver.min.js",
       c3: "/path/to/c3"
    }
});

Reference


Removed references to Invite.HOME and code which supported multiple housemates existing.

Resolved #515 Remove "housemate" managing. This PR represents the first step - removing the ability of people to add other folks to their home. This makes the Person-Home relationship essentially a one-to-one relationship for now.
Later the idea is to set people up to have multiple saved configurations for attendees and homes. For now, I just want to avoid someone actually managing to set up a people-home situation (since it would make migrations more complicated later.)

This is missing a migration—but it's one that I don't think has any effect on the database, so I'll let you figure out how you want to slip that migration in.

yeah...  It just blanks and does not seem to save. Let me know if you can't reproduce.

I can reproduce. It happens if the user is new & doesn't have a home attached to them yet.

Fixed! Also, I checked, and this is handled correctly on the hosting form.

Seems dandy. Merging.


Hey just following up here as I had the same issue. Try adding the --game-path option to your .bat file:
Example:
.\modengine2_launcher.exe -t er -c .\config_eldenring.toml --game-path "D:\SteamLibrary\steamapps\common\ELDEN RING\Game\eldenring.exe"


Update Composer dependencies (2022-04-15-00-03)

Visual regression test passed!
View the visual regression test report


Memory leak when streaming

Describe the bug
I try to use a dataset with streaming=True, the issue I have is that the RAM usage becomes higher and higher until it is no longer sustainable.
I understand that huggingface store data in ram during the streaming, and more worker in dataloader there are, more a lot of shard will be stored in ram, but the issue I have is that the ram usage is not constant. So after each new shard loaded, the ram usage will be higher and higher.
Steps to reproduce the bug
You can run this code and see you ram usage, after each shard of 255 examples, your ram usage will be extended.
from datasets import load_dataset
from torch.utils.data import DataLoader

dataset = load_dataset("WaveGenAI/dataset", streaming=True)

dataloader = DataLoader(dataset["train"], num_workers=3)

for i, data in enumerate(dataloader):
    print(i, end="\r")

Expected behavior
The Ram usage should be always the same (just 3 shards loaded in the ram).
Environment info

datasets version: 3.0.1
Platform: Linux-6.10.5-arch1-1-x86_64-with-glibc2.40
Python version: 3.12.4
huggingface_hub version: 0.26.0
PyArrow version: 17.0.0
Pandas version: 2.2.3
fsspec version: 2024.6.1

I seem to have encountered the same problem when loading non streaming datasets. load_from_disk. Causing hundreds of GB of memory, but the dataset actually only has 50GB

FYI when streaming parquet data, only one row group per worker is loaded in memory at a time.
Btw for datasets of embeddings you can surely optimize your RAM by reading the data as torch tensors directly instead of the default python lists
from datasets import load_dataset
from torch.utils.data import DataLoader

dataset = load_dataset("WaveGenAI/dataset", streaming=True).with_format("torch")

dataloader = DataLoader(dataset["train"], num_workers=3)


'getAudience' -fix

Fixed the 'getAudience' issue. The empty method was preventing you to retrieve the Audience and resulted in a exception that was being thrown.

Thank you


PaperUIManager: Rename getConstants() -> getUIManagerConstantsCache()

Summary:
Rationale
The new name makes it clear:

The constants come from NativeUIManager
The constants are cached (i.e: computed once).

I might further improve the name later, after I further develop my understanding of this method.
Changelog: [Internal]
Reviewed By: dmytrorykun
Differential Revision: D51987399

Closed as abandoned internally


Syslog formatter

First of, I know the Syslog handler exists.
The suggestion here is to create a Syslog formatter, which would allow using it without messing around with PHP's settings.
Use case:

formatter is created and Symfony enables it by default in dev mode
the format of the log file is by default recognized by various logging helpers like https://lnav.org/ without any configuration, super-charging the logging information
the user (developer) gets great DX by default, using standard best-of-kind apps

Syslog seems like the most obvious choice since it's very widely supported, if there's another alternative, that also works.

Closed by https://github.com/Seldaek/monolog/pull/1689

Yay! \o/ Created a Symfony bundle issue here: https://github.com/symfony/monolog-bundle/issues/441


[upb] fix elisp_rules build broken by upstream b997cb6d

This is https://github.com/protocolbuffers/protobuf/commit/b997cb6d titled "upb: add a non-void typedef for upb_Message" by @ericsalo.

I'm not sure how to fix this build breakage. Does this require repinning upb to the latest version?

Well the change in upb was just pushed to top-of-trunk but we've not included it in an official protobuf release yet.

In this repo we depend on the last version of protobuf/upb pushed to the BCR, which is pretty old (cf. https://github.com/protocolbuffers/protobuf/issues/14564). Until https://github.com/protocolbuffers/protobuf/issues/14564 is fixed I wouldn't necessarily want this to change because IIUC that would require every user to add a module override for protobuf. At Google there are some local patches to make the code compatible with upstream upb, so probably this patch should be added there as well.


Import service from JSON/YAML

This PR adds the ability to import a service into the CAS Service Registry using either JSON or YAML formats.

User can choose to open a file from their local computer or paste the contents directly into the browser.
User can edit the JSON or YAML in place before importing.
Importing a service will bring the Service up in the Form edit view.  Here the user can edit the service and then save the Service to the registry.
When a service is imported, the assigned id is always set to -1 to ensure a new service is created.

Awesome!


Fix broken Ansible Lint docs link

https://ansible.readthedocs.io/projects/lint/en/latest/configuring/ >> https://ansible.readthedocs.io/projects/lint/configuring/

wrong base


internal/core/export: fix issue #2584; add issue2584.txtar

Before the fix, issue2584.txtar fails with a panic due to accessing a nil pointer. The fix prevents accessing the offending pointer.
After the fix, issue2584.txtar passes.
modified:   internal/core/export/adt.go
new file:   internal/core/export/testdata/main/issue2584.txtar
Fixes #12345

The Check diagnostic in the failing test says
Run for module in . internal/e2e; do
  for module in . internal/e[2](https://github.com/cue-lang/cue/actions/runs/6829502521/job/18598641665?pr=2690#step:21:2)e; do
  	(
  		cd $module
  		go vet ./...
  		go mod tidy
  	)
  done
  shell: /usr/bin/bash --noprofile --norc -e -o pipefail {0}
  env:
    CUE_LONG: true
go: downloading golang.org/x/sync v0.[3](https://github.com/cue-lang/cue/actions/runs/6829502521/job/18598641665?pr=2690#step:21:3).0
/home/runner/work/_temp/c5268e80-f89d-[4](https://github.com/cue-lang/cue/actions/runs/6829502521/job/18598641665?pr=2690#step:21:4)1d9-86b9-cc982bb[5](https://github.com/cue-lang/cue/actions/runs/6829502521/job/18598641665?pr=2690#step:21:5)e202.sh: line 3: cd: internal/e2e: No such file or directory
Error: Process completed with exit code 1.

@mvdan Can I assume that the failure is not caused by my proposed changes? What can I do?

The CI failure should disappear if you rebase on master.

Done.
cue % git log --graph --oneline                                             [fix-issue-2584|✔]
* dec11d94 (HEAD -> fix-issue-2584, origin/fix-issue-2584) internal/core/export: fix issue #2584; add issue2584.txtar
* 9dd0f82d (upstream/master, origin/master, origin/HEAD, master) cue: don't panic on Iterator.Selector.Index with lists
...

I had to --force the push:
cue % git push origin fix-issue-2584 --force                          [fix-issue-2584 ↓1↑44|✔]
Enumerating objects: 16, done.
Counting objects: 100% (16/16), done.
Delta compression using up to 8 threads
Compressing objects: 100% (9/9), done.
Writing objects: 100% (9/9), 1.12 KiB | 47.00 KiB/s, done.
Total 9 (delta 6), reused 0 (delta 0), pack-reused 0
remote: Resolving deltas: 100% (6/6), completed with 6 local objects.
To https://github.com/rudifa/cue.git
 + 7fd2847e...dec11d94 fix-issue-2584 -> fix-issue-2584 (forced update)


Not sending events to GA

Hi, I've spent some time trying to make it work but to no avail.
I followed the initialization instruction from here.
Trial 1:
/* index.tsx */
// imports
...
const ga4react = new GA4React('G-XXXXXXXXX');

(async (_) => {
  await ga4react
    .initialize()
    .then((ga4: any) => {
      ga4.pageview('test', 'test', 'test'); // event doesn't show in GA
    })
    .catch((err: any) => console.log('Analytics Failure.'))
    .finally(() => {
      ReactDOM.render(<App />, document.getElementById('root'));
    });
})();

Trial 2:
/* somewhere in the app */
const ga4 = useGA4React() as GA4ReactResolveInterface; // use hook

useEffect(() => {
  if (ga4) {
     ga4.pageview(location.path, location.path, 'page');
  }
}, [location.pathname])
...

Could you please let me know what I'm doing wrong?
(Yes. I've also looked at the current and past issues posted here and didn't find them as useful)
Thank you.

It actually did send the events, it just took a little bit of time.
Also, seems like it's only capturing the page title based on index.html and not what I sent using ga4react.gtag().
Closing the issue for now.


Move getting started section to local development

From: https://typerefinery.ai/guide/setup-vue.html
To: https://typerefinery.ai/miscellaneous/local-development.html

It has been modified to local development section


Codes of LERF

Hi,
Thanks for your great work and I am very interested in you latest work LERF. I wonder when will the code of LERF integrated into nerfstudio?
Thanks for your time!
Best,

We hope to integrate it in the next few weeks.


Possible bug in const_assert_ne!

const_assert_ne! supports 2 or more arguments. In the latter case, only the first argument is compared to every other argument, meaning that the arguments are not checked for pairwise inequality. For example, the following compiles:
const_assert_ne!(1, 2, 2);

The documentation suggests that all the arguments should be not equal to each other. If that's not the intended behaviour (and this is not a bug), the documentation should be updated to reflect that.

The macro in 1.1.0 only accepts two arguments.
Also, when I try to compile your code:
use static_assertions::const_assert_ne;

const_assert_ne!(0, 1, 1);

I get this error:
error: no rules expected the token `1`
 --> src/main.rs:3:24
  |
3 | const_assert_ne!(0, 1, 1);
  |                        ^ no rules expected this token in macro call


Warnings on Latest Xcode 8.3

I am getting these warnings when I did try to build my project with latest xcode 8.3. I am attaching the screenshot.

Hi @mwaqasbhati,
Have you the last version? It should be fixed.

sorry I just update the library to latest commit and things are working with no warnings .... thanks


nullpointerexception when use list method

When I use something like this:
template.newSqlQuery().from(q).list(q.name);
it throws NPE. Seems in AbstractSQLQuery.java, the conn is null when using list method.
The query method is fine.
final PreparedStatement stmt = conn.prepareStatement(queryString);

Tested on 3.6.0 and 3.6.1

I think in the fix is: QueryDslJdbcTemplate.java method newSqlQuery should change from
public SQLQuery newSqlQuery() {
return new SQLQuery(this.dialect);
}
to
public SQLQuery newSqlQuery() {
Connection conn = DataSourceUtils.getConnection(this.jdbcTemplate.getDataSource());
return new SQLQuery(conn,this.dialect);
}

Spring's JDBCTemplates provides us with the connection, so it is an error on their part.
I think you'd do good to report the problem there.

I can confirm that the issue is with Spring Data JDBC, and not Querydsl, though the query created by them is not supposed to be executed directly as you can see from their docs
http://docs.spring.io/spring-data/jdbc/docs/1.2.0.BUILD-SNAPSHOT/reference/html/core.querydsl.html

You are right. This is spring querydsl template issue. Thank you.


Bug in sockets.c (subsys\net\lib\sockets)

Describe the bug
When zsock_accept_ctx is called on a non-blocking socket, after a few times it returns ENFILE - no more file descriptors available
Call
z_free_fd(fd);
Before returning EAGAIN (line 16 of the function accept)
To Reproduce
Steps to reproduce the behavior:

mkdir build; cd build
cmake -DBOARD=frdm_k64f
make
See error

Expected behavior
Accept should return EAGAIN when there is no pending connection on the listening socket
Impact
Showstopper. This bug means non-blocking sockets cannot be used for listening and accepting on the server side.
Screenshots or console output
N/A
Environment (please complete the following information):

OS:  Windows
Toolchain arm mbed
Commit SHA or Version used: top as of Jan 30 2020

Additional context
code snippet:
@@ -421,6 +421,7 @@ int zsock_accept_ctx(struct net_context *parent, struct sockaddr *addr,
	ctx = k_fifo_get(&parent->accept_q, timeout);
	if (ctx == NULL) {
		errno = EAGAIN;
+		z_free_fd(fd);
		return -1;
	}

@bran795 are you planning to send a pull request, since you seem to have a fix proposal in the description?

@jhedberg Hi, newbie here
I haven't checked the procedure for sending a pull request
Can anyone send a pull request?

@jhedberg
I would appreciate a little help with the pull request
Is there a way to edit the pull request comment after it has been created?
Thanks

@bran795: "Comment", not (well, it won't help). "Commit message", yes.  Read instructions carefully, and feel free to google it up for more details (Zephyr docs may also include suggestions for development process).

@pfalcon right
what about the Identity/Emails issues? I added an email address first.last@company to my github account but that doesn't seem to work either
thanks

@bran795 you need to configure your local git correctly, which is normally done through $HOME/.gitconfig. E.g. in mine I have:
[user]
	name = Johan Hedberg
	email =<EMAIL_ADDRESS>
Since you already created the commit you'll need to amend its author explicitly. You should be able to do that with git commit --amend --author="Your Name <your@email> or with git commit --amend --reset-author after you've fixed your git configuration.

@bran795: Name/email in commit's "Author:" field should match those in "Signed-off-by:" as present in the commit message. In #22366 I see (git log):
Author: bran795<EMAIL_ADDRESS>
which suggests that you submitted that PR from Github's web UI. That won't work here, you would need to use command-line git client, I'm afraid.

@jhedberg
@pfalcon
Thanks, I'll install git and try again

you submitted that PR from Github's web UI

I had no idea that GitHub had such a feature. I wonder if it can be disabled per-project, since it doesn't seem to be able to produce what's required for Zephyr.

Getting closer...
Gitlint issues
1: UC2 Signed-off-by: must have a full name
Identity/Emails issues
1a868e8: author email (Inbar Anson Bratspiess<EMAIL_ADDRESS>needs to match one of the signed-off-by entries.
Please help
Thanks


How to create an instance and call a method?

For example, we have a DirectoryInfo class in mscorlib, which methods take an its instance as first argument, which in-game being created using .ctor method and passing in it the needed path for later usage.
GetFiles, for example:

How to process that using UnityResolve?

UnityResolveClass* pClass;
DirectoryInfo* ptr =  pClass->New<DirectoryInfo*>();
ptr->GetFiles(...)

UnityResolve::Class* pClass;
UnityResolve::Method* ptr = pClass->GetUnityResolve::Class("GetFiles");
ptr->Invoke<ReturnType*>(instance, UnityResolve::UnityType::String::New("file"), 0);

UnityResolveClass* pClass; DirectoryInfo* ptr = pClass->New<DirectoryInfo*>(); ptr->GetFiles(...)

Assuming i have implemented DirectoryInfo type?

UnityResolve::Method* ptr = pClass->GetUnityResolve::Class("GetFiles");

You meant UnityResolve::Method* ptr = pClass->GetUnityResolve::Method("GetFiles");?

yeah


Auth::logout() not working

The docs state this:
To log users out of your application, you may use the logout method on the Auth facade. This will clear the authentication information in the user's session...
What is the intended behaviour of Auth::logout()? What is it meant to do?
Auth::login($user); //This logs the user in
I can log user in and make it persist through different requests but
Auth::logout() makes them logout for that particular request but does not persist the log out? They are still considered logged in for future requests as per: Auth::user();

Thank you for reporting, but as I said, this isn't actually a bug. It's the expected behaviour.

The 2nd request finishing will store the session, regardless of if a previous request running at the same time was meant to log the user out.

https://github.com/AltThree/Locker/blob/master/src/Http/Middleware/LockingMiddleware.php

I wrote an example middleware there. Just mofiy it to lock for all types of requests if you want maximal locking.

Ie, delete:
        if ($request->isMethodSafe()) {
            return $next($request);
        }

Was this changed with L5.1?

What is the intended behaviour of Auth::logout()? What is it meant to do?

Logout only performs an operation on the session, which is persisted when the session is saved. If someone else overwrites the saved data just after, than we have a problem. This is the issue you're experiencing, which is why I'm suggesting to take a look at locking. Hope this makes sense. ;)

Thanks

Was this changed with L5.1?

Oh? I assumed you were using L5.1. We only support L5.1 LTS, or L5.2. ;)

No I am using L5.1.
I upgraded my project from L5 where it logout worked.


Dialogs now honor modal property.

Dialog's did not honor the modal property. When clicking on the overlay the event will stop propagating and the user will be forced to use the action buttons (still allows keyboard ESC) to interact with the dialog.

Thanks @jkruder


1.0.0-beta.8 md to mat problem

I have to upgrade to 1.0.0-beta.8 , but after the update some of the md prefix are present so I got an error.
Please fix this.
Specific case: md-sidenav-container, generated by td-layout tag.
Thank you for your efforts.

Please change the angular material changelog, they removed all md prefixes and you should use matnow

Ok maybe i didn't explain myself. I used td-layout that is a covalent's component and is exactly td-layout that generate md-sidenav-container that goes against material and generate the error that make my app crash. So i am asking if you are considering a refactoring of your components.
Thank you very much.

We already updated this in our beta.8 release and its all in our changelog

Ok is as you said. I am really sorry for bothering but during the installation something went wrong, I had package on beta 8 but all the files were effectively an older version. I cleared and reinstalled and now is ok.
Thank you very much for your help and time.

No problem, glad it was just an installation issue 😄


Remove LSP specific error codes

https://github.com/julia-vscode/JSONRPC.jl/blob/5adc04bf4df6a220dda20896a8ecc1fd396a9346/src/core.jl#L18-L30
These are not listed in the JSON-RPC specification under section 5.1, so should probably be removed, as they are in the application defined section and may be different for other servers/clients.
A potential fix would be to have a wrapper error in LanguageServer.jl for the (then missing) custom printing, which would be thrown in places where JSON-RPC errors can occur by catching & rethrowing with the wrapper type. If that is acceptable, I can try to make PRs here and at LanguageServer.jl to implement this.

Yes, but those are specific to LS.jl, right? Other servers using this may have a different error, so patching this library on a per-server basis seems odd. Moreover, some of these truly are application specific, so hardcoding them seems bad.
I have a patch for this locally without resorting to a new error type, which allows other potential users to also hook into the showerror functionality, allowing this to be decoupled from LS.jl.


Adding search processor for score normalization and combination

Description
Added processor that does score normalization and combination for Hybrid query results. Processor is registered via search pipeline API as search phase result processor.
In this PR we're adding support for techniques "min-max" for normalization and "arithmetic mean" for combination. Support for weights and other techniques will be added in next PRs to keep size of a single PR minimal.
Below is example of definition for registering new processor as part of search pipeline:
{
    "description": "Post processor for hybrid search",
    "phase_results_processors": [
        {
            "normalization-processor": {
                "normalization": {
                    "technique": "min_max"
                },
                "combination": {
                    "technique": "arithmetic_mean"
                }
            }
        }
    ]
}

Issues Resolved
https://github.com/opensearch-project/neural-search/issues/228, part of solution for https://github.com/opensearch-project/neural-search/issues/126
Check List

[X] New functionality includes testing.

[X] All tests pass

[X] New functionality has been documented.

[X] New functionality has javadoc added

[X] Commits are signed as per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@martin-gaievski all the comments which you have resolved please mark them as resolved.

@martin-gaievski all the comments which you have resolved please mark them as resolved.

sure, I addressed all comments, @navneet1v  please check PR again


Change the license notation in the package.json file.

We need to use the short identifier defined by the SPDX in the package.json file. For instance, the short identifier for Apache License 2.0 is Apache-2.0 (see).
Currently, when executing yarn build and so on, the following warning message will be output:
$ yarn build
yarn run v1.7.0
warning package.json: License should be a valid SPDX license expression
$ tsc && cp -r ./locales ./dist
✨  Done in 4.32s.

I would like to fix this issue by this pull request. Could you review this?

@Fleker @Canain Could you review this pull request?

Yeah I've been meaning to go back to this change. It looks good to me. I think I originally took this from one of the other packages we have. Maybe we should adopt some automated way to validate the notation.


[1.2]RPG Style Inventory Multiplayer Compatibility

the original RPG style inventory is not updated to 1.2 and someone re-uploaded it for 1.2, same code as 1.1 version, tested the 2 buttons, still works :D

No need for duplicates. MPCompatFor attribute supports multiple names.

Fixed by https://github.com/rwmt/Multiplayer-Compatibility/commit/acf63452ef533e958910143ea91584fd2553399f

That works :D


Fastnlight: Watch annonymous.eu

Fastnlight requests the watch of the watch_keyword annonymous\.eu. See the MS search here and the Stack Exchange search in text, in URLs, and in code.

annonymous\.eu has been seen in 1 true positive, 0 false positives, and 0 NAAs.

Approved by Ryan M in Charcoal HQ


Added the Pascals Triangle

Issue no. #162
I've added following:

Generating Pascal's Triangle
Retrieve Specific Row from Pascal's Triangle
Binomial Coefficient Calculation
Printing Pascal's Triangle
Summing Elements of a Row
Factorial Calculation
Polynomial Expansion
Pascal's Triangle Modulo

@UTSAVS26

Hey @UTSAVS26 there are two different pr for fibonacci generator and pascals triangle


Allow caching of getServices in the UI

From @yurishkuro

the query to get all service names in Cassandra needs to hit every node in the cluster. We've been seeing strange huge latencies with it recently, still investigating. To mitigate the impact, I've added a cache of service names in Cassandra span storage, which periodically refreshes itself.

I think we should solve this at the HTTP abstraction, ex. sending cache headers back, so that the client doesn't call so much.
There are two endpoints on zipkin-web that call getServices

/ - part of a massive thing that includes enumerating all services, to pass to index.mustache
/api/services - possibly unused json string list

I see two things to do:

change index.mustache to use javascript to GET /api/services and fill the Service Name selector by itself
change handleServices to return cache headers

@mzagar @eirslett either of you have some cycles to help with this by chance?

I believe I can take a look at this one.

Great. I suspect this won't impact you if you are only working in
JavaScript layer. But just in case:
https://github.com/openzipkin/zipkin/pull/728

the query to get all service names in Cassandra needs to hit every node in the cluster.

best to increase RF of the zipkin keyspace.
(answers more to the availability than performance)

I think we should solve this at the HTTP abstraction, ex. sending cache headers back, so that the client doesn't call so much.

:+1:

so realizing that the getServices isn't actually called by the javascript yet. Also, I noticed a special case. WDYT about this?
if services.size < 3 don't cache
otherwise set TTL on the http response to 30 seconds?

Isn't 30 seconds a bit low - are new services created that often? I was thinking about adding a property allowing to set this timeout to a custom value at web startup and setting the default to 5 minutes, is that too long?
Optimization when not to cache sounds good.
I'll make a PR fpr the js side later do

Honestly I don't know what's the right value.. there's a special case of
bootstrapping, which I think the minimum count would cover.. Perhaps 5m
after that is a decent value. Probably only way to find out is to spike it!
Thanks for the offer for the javascript change! Note that ideally we'd
remove the call from Handlers.scala while at it.

@mzagar "/api/services" can be put back in.. sure. We just want to remove the call in the scala side once that's done.
PS we had a chat on https://gitter.im/openzipkin/zipkin about wanting to do caching at the http-level, addressed by the browser. Browsers know how to deal with cache headers w/o creating special-caches in scala :) Best way forward is to do as much as possible to get the UI javascript-only. Put another way, a tactical scala cache just for services would probably end up as tech debt.

@yurishkuro @eirslett let's continue the chat from https://github.com/openzipkin/zipkin/pull/983#discussion_r53009101 here, as the history is here

To summarize status quo, the query server sends back a cache header when there are more than 3 services present:
assert(response.headerMap.get("Cache-Control") == Some("max-age=300, must-revalidate"))

https://github.com/openzipkin/zipkin/blob/master/zipkin-query/src/test/scala/com/twitter/zipkin/query/ZipkinQueryServerFeatureTest.scala#L167
The actual age is assigned via the flag "zipkin.queryService.servicesMaxAge", which is incidentally not currently mapped as an environment variable.
The zipkin-web server should forward this header all the way to javascript (or any other caller). I suspect if it wasn't, @mzagar would have complained :P However, we have no test on zipkin-web to verify forwarding doesn't lose the header. The main reason is that zipkin-web is an older framework than finatra, and doesn't support feature tests.

PS something Eirik mentioned was interesting.
If 100s of service names strings are that slow, and for some reason HTTP cache headers aren't an option, a decorating SpanStore which caches in memory would be something those doing custom builds could add, if the middleware itself doesn't have a caching feature.

We could add a cache layer with an environment variable to set TTL (default to 0 seconds, which disables the cache?)
Ideally, people shouldn't have to do custom builds, if we can avoid it?

Another option is to deploy varnish as middleware on top of zipkin-query, to handle the caching. Then we only need cache headers, but the deployment becomes much more complex.

We could add a cache layer with an environment variable to set TTL
(default to 0 seconds, which disables the cache?)
Ideally, people shouldn't have to do custom builds, if we can avoid it?

I don't really want to do anything on this :) but the practical issue on
cassandra remains, so happy to discuss.
I really think we should get most mileage out of the other cache setting we
have now (cache-control). If we find this is a fools errand, I'd prefer we
remove it and make a different parameter that works. one in-one out.
In general I don't like the idea of doing in-memory caching in the query
server. Guava and similar caches add more edge cases to the code, and in
this case, it is one api that sends very little data. What happens if
somehow spanNames degrades in performance.. do we need another env property?

a decorating SpanStore which caches in memory would be something those doing custom builds could add, if the middleware itself doesn't have a caching feature

We already did that a few months ago, and I am still occasionally seeing the dropdown staying blank for a second or more after page loading. I feel it's a combination of transferring large JSON (via two hops due to query service running separately) and DOM creation altogether result in this visible latency. It just seems like the wrong design that the UI needs to keep re-loading this large list. Soon our list of services will be approaching a 1000.

I haven't tested the UI with 1000 service names yet. Might be worthwhile to stub the JSON API calls, and measure the impact on DOM rendering time in isolation?

We already did that a few months ago, and I am still occasionally seeing
the dropdown staying blank for a second or more after page loading. I feel
it's a combination of transferring large JSON (via two hops due to query
service running separately) and DOM creation altogether result in this
visible latency. It just seems like the wrong design that the UI needs to
keep re-loading this large list. Soon our list of services will be
approaching a 1000.

Thanks for the update on this.
So, there are plenty of control and monitoring UIs with relatively stable
things like buckets, application lists or tenants. I doubt that the
supporting UIs require modification to the services they serve (ex I doubt
someone changed S3 bucket api to cache in support of AWS console). What I
tend to see in tools like this is a refresh button.
Is there a way we can solve this lag problem without digging into the query
server directly?

I tried creating 1000 service names in the UI to measure the impact on rendering time:
diff --git a/zipkin-web/src/main/resources/app/js/component_ui/serviceName.js b/zipkin-web/src/main/resources/app/js/component_ui/serviceName.js
index f5b4cc6..55fb66e 100644
--- a/zipkin-web/src/main/resources/app/js/component_ui/serviceName.js
+++ b/zipkin-web/src/main/resources/app/js/component_ui/serviceName.js
@@ -23,6 +23,11 @@ define(

       this.updateServiceNameDropdown = function(ev, data) {
         $('#serviceName').empty()
+        data.serviceNames = [];
+        for (let i = 0; i < 1000; i++) {
+          data.serviceNames.push('service'+i);
+        }
+
         $.each(data.serviceNames, function(i, item) {
             $('<option>').val(item).text(item).appendTo('#serviceName');
         });

This basically replaces the API response with a list of service names, service0, service1, service2 ... service999.
The impact on rendering time was minimal, there was no visual cue showing that the latency was higher than when rendering 15-20 service names.

We have hundreds of services here at pinterest and we see the lag in the UI dropdown being populated. So my experience is same as @yurishkuro's. Can we add an environment variable to set the zipkin.queryService.servicesMaxAge?

@mansu are you saying that your browsers aren't honoring the cache-control headers? or that you feel the timeout is too short?
Bear in mind that the UI is pure javascript and hits a normal http api. In other words, cache headers can also be affected by nginx or similar normal web tier tech.
https://github.com/openzipkin/docker-zipkin/blob/master/zipkin-ui/nginx.conf

@mansu lol it is already configurable, just not documented
Here's the default, which is in seconds.
zipkin.query.names-max-age:300
This value can be overridden by system properties or any other alternative supported by Spring Boot. For example, you can upper-case it as an ENV variable. ZIPKIN_QUERY_NAMES_MAX_AGE=10000000

@adriancole ah, that works also. Looked around for setting values via command line but couldn't find anything right away. Thanks!

I don't know the status of this issue but given that we have a new UI and @tacigar, does it make sense to cache some information in localStorage? For example the service names or span per service? Any concerns more than having the posibility for a service to not to come up? we could set an expiracy at server level or even better have a config page where, in case of doubt, one could clear the storage manually. What do you think @apache/zipkin-committers ?


[Internal] Query : Adds Tests for Linq Custom Serializer

[Internal] Query : Adds Tests for Linq Custom Serializer
Description
Bootstrapping some tests for LINQ custom serializer. Building on something Minh added before but was undone since we had to revert that change as a regression. Also baselining current behavior around newtonsoft v/s json.net attributes as far as custom serializer is concerned.
Type of change
Please delete options that are not relevant.

[] Bug fix (non-breaking change which fixes an issue)

Closing inactive PRs older than 3-months, please re-active it needed.


Updated app icon

It would be nice to have a revamped icon based on Apple's guidelines for Big Sur.

Ho, any updates on this?

Hi, any progress on this?


Update performance tests with new requests, and changes where now query is not allowed.

Is your feature request related to a problem? Please describe.
A clear and concise description of what the problem is. Ex. I'm always frustrated when [...]
With IBM fhir-server changes some performance tests are no longer valid, so altering them to be valid.  And new IBM fhir-server function requires some new tests.
Describe the solution you'd like
A clear and concise description of what you want to happen.
Describe alternatives you've considered
A clear and concise description of any alternative solutions or features you've considered.
Acceptance Criteria
1.
GIVEN [a precondition]
AND [another precondition]
WHEN [test step]
AND [test step]
THEN [verification step]
AND [verification step]
Additional context
Add any other context or screenshots about the feature request here.

Tests are now merged and updated, closing issue.


New Files.md

My first steps with GIT , I have managed to create a branch , commit and also push

first review


Release notes 1.3.0

subj.

Codecov Report

Merging #868 into develop will increase coverage by 0.01%.
The diff coverage is n/a.

@@             Coverage Diff             @@
##           develop     #868      +/-   ##
===========================================
+ Coverage    97.37%   97.39%   +0.01%
===========================================
  Files           59       59
  Lines         5457     5457
===========================================
+ Hits          5314     5315       +1
+ Misses         143      142       -1

Impacted Files
Coverage Δ

gpflow/params/parameterized.py
98.67% <0%> (+0.44%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3935d6b...120b128. Read the comment docs.


[UBS] Fix bug with bag and tariff ids initial values

Link to issue
https://github.com/ita-social-projects/GreenCity/issues/5336
Summary of change
Bags and tariffs ids values removed from changelogs with inserted bags and tariffs data to bag and tariff_infos tables.
The admin's email corrected to<EMAIL_ADDRESS>Testing approach
Checked data in the respective tables.

Why you changed existing change logs? That will be a cause of the Liquid Base checksum exception.


ansible-molecule: use single step again

Executing individual steps does not work as intended and sometimes leads to unstable tests.
Revert d6d9b64bf728b0a14cb9bac8d9703b64362783d0

Before #80 there was also a destroy call: https://github.com/osism/zuul-jobs/blob/b81cdc14b1483ba115c441c00badd6734437b038/roles/ansible-molecule/tasks/main.yml#L18
But I am not sure if this really fixes the unstable tests. It was the logs that threw me off at first!

The destroy doesn't really matter as we delete the instance afterwards anyway. Destroy is also always included in the test sequence in the Molecule configuration in the Ansible Collections.


Sublime 3 like preview on right

I love macvim and use it daily, but there is one feature I really like from Sublime 3. Would you consider implementing the small preview of the file you are editing similar to how Sublime3 does it? Perhaps this goes against your philosophy of keep the vim spirit. Thanks for listening.
Apparently, I can't mark this as a feature request myself.

How about https://github.com/severin-lemaignan/vim-minimap?

This seems like something that should be handled by plugins, to me.

Send us a pic of what Sublime 3 is doing for you, and people will recommend
plugins that approximate what you want to do.
Rick
On Fri, Nov 10, 2017 at 10:00 AM, Josh Petrie<EMAIL_ADDRESS>wrote:

This seems like something that should be handled by plugins, to me.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/macvim-dev/macvim/issues/592#issuecomment-343528598,
or mute the thread
https://github.com/notifications/unsubscribe-auth/ABaFwoJKHstKZtIrPiolIinGhWhZrQddks5s1IEigaJpZM4QZTqs
.

--
rd

This really seems like something that should be handled by a plugin. Where MacVim offers functionality above-and-beyond that of vim itself, it generally does so to leverage some functionality of the OS to enhance the experience of using vim.


globalHeaders seems to be ignored

I am using svelte-adapter-azure-swa which recently implemented a means to modify the generated config that the adapter produces: https://github.com/geoffrich/svelte-adapter-azure-swa/issues/1
I wanted to use it to try set CSP headers on my personal website. The generated staticwebapp.config.json looks like this:
{
    "globalHeaders": {
        "X-Content-Type-Options": "nosniff",
        "X-Frame-Options": "DENY",
        "Content-Security-Policy-Report-Only": "default-src 'self'; img-src cdn.ldam.co.za; style-src cdn.jsdelivr.net fonts.googleapis.com; script-src az416426.vo.msecnd.net cdn.jsdelivr.net"
    },
    "routes": [
        {
            "route": "*",
            "methods": [
                "POST",
                "PUT",
                "DELETE"
            ],
            "rewrite": "/api/__render"
        },
        {
            "route": "/_app/*",
            "headers": {
                "cache-control": "public, immutable, max-age=31536000"
            }
        },
        {
            "route": "/index.html",
            "rewrite": "/api/__render"
        },
        {
            "route": "/",
            "rewrite": "/api/__render"
        }
    ],
    "navigationFallback": {
        "rewrite": "/api/__render"
    }
}

However, this does not appear to be respected, and the headers are not present in any responses. These are the only headers I am getting back (via Postman):

I wasn't sure if it might be CloudFlare changing headers along the way, but I see the same behaviour going directly to the *.azurestaticapps.net URL.
I also see the same behaviour with the SWA CLI, the headers are not present there.
According to the docs, and the playground, this should work fine.

So it appears that resources under my site are being returned with the headers I specify in globalHeaders, but not the root route, which has a rewrite rule to an API call. Is it possible that those rewrites are causing this?


Removed outdated code related to web analytics

Motivation and context

How has this been tested?

Checklist

[x] I submit my changes into the develop branch
[ ] I have created a changelog fragment
[ ] I have updated the documentation accordingly
[ ] I have added tests to cover my changes
[ ] I have linked related issues (see GitHub docs)
[ ] I have increased versions of npm packages if it is necessary
(cvat-canvas,
cvat-core,
cvat-data and
cvat-ui)

License

[x] I submit my code changes under the same MIT License that covers the project.
Feel free to contact the maintainers if that's a concern.

Summary by CodeRabbit

New Features

Updated build process for the CVAT UI to enhance configuration handling.

Bug Fixes

Simplified routing logic in the CVATApplication component to improve navigation tracking.

Documentation

Updated copyright notice in the environment utility file.

Chores

Removed unused web analytics tracking function to streamline code.

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 74.05%. Comparing base (88a3301) to head (529fee7).

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #8755      +/-   ##
===========================================
- Coverage    74.06%   74.05%   -0.01%
===========================================
  Files          409      409
  Lines        43784    43777       -7
  Branches      3984     3983       -1
===========================================
- Hits         32429    32420       -9
- Misses       11355    11357       +2

Components
Coverage Δ

cvat-ui
78.36% <ø> (-0.02%)
:arrow_down:

cvat-server
70.34% <ø> (ø)


Coverage

Coverage increased (+8.5%) to 81.396% when pulling b0e099ef9358a96009e46c028bb66a05e1c5a0e9 on AnjaneyuluBatta505:Coverage into 2ea65e619b6b448362d5bebb25aaf9befa7cfd91 on MicroPyramid:master.


Add progress information in notifications

Display "preparing backup 1/3", ...

This is not useful for end-users. I won't do that.


Dashboard - Could not locate that index-pattern

Hello,
I get this error when I go in to the dashboard section.
"Could not locate that index-pattern (id: awswaf), [click here to re-create it] (#/management/kibana/index)"
The discover section does show the raw logs correctly and I have already tried to delete and recreate the awswaf-* index pattern. Does anyone know how to fix this issue?

I met same issue too, did you fixed it ?


Upgrade IP BOM to 7.0.0.CR5

CR5 brings JPA 2.1 + Hibernate 5.x
(upgraded from JPA 2.0 + Hibernate 4.x)

Please don't merge yet. All the IP BOM 7.0.0.CR5 PRs need to be merged together.

not yet?

@ederign yeah, not yet please. Some of the downstream PRs are failing, so I will first need to fix those. I'll make sure to merge everything at the same time (or ask someone to do that as I don't have the permission for errai).

@ederign could you please review this? I'll then coordinate the merge of all the PRs.


Add brakeman gem and clean up warnings

Brakeman is a security analysis gem that flags vulnerable code that we should put to work for us. There are three steps here:

Install the gem - https://github.com/presidentbeef/brakeman
Run the gem and clean up any warnings
Add the gem to our CI process, so that a build fails if it introduces new vulnerable code

(This is underway!)


Integration with GitLab

I need to connect my azure board and tasks to GitLab repository, there's any way?

@FrtsVictor -- Victor, thank you for your question.  This repo is solely for documentation issues, and this seems implementation-related.  Please consider these resources:

Azure DevOps Services
Azure DevOps on Stack Overflow

I am closing this issue now.  You are welcome to @ mention me for any followup.  We hope to hear from you again.


Design kit access request

Thanks for your interest in the IBM.com Design kits!
We are in a closed adoption phase at the moment. Please answer the following questions to help us better understand your interest. Someone from Carbon for IBM.com will reach out to you soon regarding your request for access.

Which team are you on?

MSC / Privacy Organization

What experience are you designing for?

Application called Preference Center

What platform is your experience on? (ie. Drupal, Wordpress, etc)

Carbon

Please list a point of contact for:
Offering manager: Neera Mathur
Design lead: Rafaela Mascaro
Development lead: Joe Stowers

Any additional information you'd like to share about your project

@oliviaflory Please provide access to kit cc: @jeffchew

Hi @rafaelamascaro-star could you please share your IBM email so I can add you to the Box folder? Thank you!

meeting scheduled to review the completed questionnaire Monday, 8/17.

Invitation to design kit folder sent!


Cannot change difficulty setting at server start

I have tried the command /mvm set diff 0 Craftia and that works, until the server is restarted.
I have changed the entry in worlds.yml, while the server is not running, but the server rewrites those values at startup. The world always loads with difficulty set to easy.
I am running Thermos 1.7.10-1558 with a custom pack of mods. I can list them if it is relevant.

This issue either does not have enough details. Please read up on "submitting a bug" and form a more complete bug report, thanks!

Did you ever fix this issue? I'm having the same problem.


where can i find envoyfilter yaml demos

(NOTE: This is used to report product bugs:
To report a security vulnerability, please visit https://istio.io/about/security-vulnerabilities
To ask questions about how to use Istio, please visit https://discuss.istio.io)
Bug description
where can i find envoyfilter yaml demos*Affected product area (please put an X in all that apply)**
[ ] Docs
[ ] Installation
[ ] Networking
[ ] Performance and Scalability
[ ] Extensions and Telemetry
[ ] Security
[ ] Test and Release
[ ] User Experience
[ ] Developer Infrastructure
[ ] Upgrade
Expected behavior
Steps to reproduce the bug
Version (include the output of istioctl version --remote and kubectl version --short and helm version --short if you used Helm)
How was Istio installed?
Environment where the bug was observed (cloud vendor, OS, etc)
Additionally, please consider running istioctl bug-report and attach the generated cluster-state tarball to this issue.
Refer cluster state archive for more details.

https://github.com/istio/istio/wiki/EnvoyFilter-Samples contains some unofficial ones


ci: fix semgrep action name

:tada: This PR is included in version 2.5.2 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


MacOS preventing me from running

after unzipping it and opening the application i get this error
“Dino” can’t be opened because Apple cannot check it for malicious software.
how do i solve this?

Recent versions of macOS block unsigned apps by default, which hurts indie developers because they have to pay Apple $99/year in order to sign their apps. That's why this, and a lot of other small macOS apps, are unsigned and won't run by default.
To run these apps, right-click/control-click the .app file and click on Open. This will add a security exception for that app, and in the future you can just double-click it to open.
Here's the macOS support article about this "feature".


Minor edits, clarifications, quote smartening, link tidying

O hai. Bump?

Merged. Many, many thanks for the cleanup! My apologies for the delay.

No worries. Happy to help.


textfield label goes nuts on clear collection modal

that thing running away is quite funny...

Note: same issue on index delete dialog


Subject not being set if using Dynamic templates

I was trying to add subject for my email with dynamic templates but it is not working. Is this a known bug already? Can you suggest any workarounds for this issue?
template code:

  <title></title>

 Hello {{test_name}}!

send mail function:
const sgMail = require('@sendgrid/mail');
sgMail.setApiKey(settings.sendgrid.api_key);
sgMail.setSubstitutionWrappers('{{', '}}');

const msg = {
    to<EMAIL_ADDRESS>    from: settings.sendgrid.from,
    subject: 'Test Subject',
    templateId: settings.sendgrid.template_id,
    dynamic_template_data: {
	test_name: 'Testing Name'
    },
};

sgMail.send(msg);

Same as #834

@10kc-zack I see. It is a known issue then.
By the way, what workaround did you do to fix it?

@nyel-dev Setting the template's subject on SendGrid website works. The problem is that it seems that SendGrid's API does not let you supply a template when you trigger a dynamic template.

Hello @nyel-dev,
I believe in the transactional template you would set the subject to be {{ subject }}, then in your code you set data.subject to be "[TEST] My Email Subject".
Does that work for you?
With Best Regards,
Elmer

We still have this issue

Damn I was stuck on this issue for so long because I thought I was following the docs and thought I did something wrong. Especially since I'm migrating from legacy templates, I thought the API would stay the same.
Are there any plans to update the documentation to v3/mail/send to properly reflect this change?

The only way I was able to solve this issue was with triple-stash:
{{{ subject }}}
According to this article https://github.com/sendgrid/sendgrid-nodejs/blob/master/use-cases/transactional-templates.md

Can confirm using triple instead of double curly braces in the subject field works

Whenever I save the triple curlys or any other code in the subject line, the code reverts back automatically after a few minutes to the standard <%subject%>.
Is anyone else having the same issue?

Is anyone else having the same issue?

I have seen something like this when I had two windows open. SendGrid auto-saves, so if you have two windows open, they will cancel each other out.

The way it worked for me:
use in subject filed in SendGrid UI: {{{subject}}}
send "subject": "test" in message.dynamic_template_data
Suggestion: You guys should really work on your docs. I mean really they are so scattered and bits and pieces are outdated.

Triple brackets is still working, I'm just checking to see if that is still the official solution.
Thanks!

@tcukanoot Yes.

Please do re-open issue! The documents still are not correct suggesting subject to be set on the top level of the request. However, it must be included in dynamic_template_data and subject in template must be set as {{subject}} or any other dynamic key. This is open from 2018 and no any changes in documentation introduced since!

The way it worked for me:
use in subject field in SendGrid UI: {{{subject}}}
send "subject": "test" in message.dynamic_template_data
Suggestion: You guys should really work on your docs. I mean really they are so scattered and bits and pieces are outdated.

How to do it in PHP. Please share the code!

Are the docs currently just incorrect in suggesting that subject be sent as a top level parameter then?

Are the docs currently just incorrect in suggesting that subject be sent as a top level parameter then?

The way it worked for me:
use in subject field in SendGrid UI: {{{subject}}}
send "subject": "test" in message.dynamic_template_data
Suggestion: You guys should really work on your docs. I mean really they are so scattered and bits and pieces are outdated.

This worked for me!

When i used triple bracket i was still missing the fact that subject property must be placed under dynamic_template_data and not at higher level as wrongly stated in docs

Is there any way to put variable in mail subject ?

SendGrid’s greatest weakness is its scattered documentation. It’s awful.

Suggestion: You guys should really work on your docs. I mean really they are so scattered and bits and pieces are outdated.

The way it worked for me:
use in subject field in SendGrid UI: {{{subject}}}
send "subject": "test" in message.dynamic_template_data
Suggestion: You guys should really work on your docs. I mean really they are so scattered and bits and pieces are outdated.

This worked for me! Your doc should look something like:
const msg = {
    to: toEmail,
    from: "email",
    templateId: "tempateId",
    dynamic_template_data: {
      subject: "subjectHere",
    },
  };

sendGridEmail
    .send(msg)
    .then(() => console.log("email sent"))
    .catch((error) => console.error(error.toString()))

this works with
{{{subject}}} in template in sengrid web

November 2021, still not working according to the documents

I notice the subject is always use dynamic template setting from official
message = Mail(     from_email=FROM_EMAIL,     to_emails=TO_EMAILS,     subject='a test subject' )
The param "subject" in above code is not working

For me when using {{subject}} on the template page in the subject field, then setting:
mail.getPersonalization().get(0).addDynamicTemplateData("subject", "MyCoolSubject");
Worked

Thanks!  I have solved the problem
On Fri, Dec 17, 2021 at 8:50 PM Attila Novák @.***>
wrote:

For me when using {{subject}} on the template page in the subject field,
then setting:
mail.getPersonalization().get(0).addDynamicTemplateData("subject",
"MyCoolSubject");
Worked
—
Reply to this email directly, view it on GitHub
https://github.com/sendgrid/sendgrid-nodejs/issues/843#issuecomment-996697930,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AWU3J4LCXUTH4GJGKFOZXVTURMWXVANCNFSM4GCHRZHQ
.
Triage notifications on the go with GitHub Mobile for iOS
https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675
or Android
https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.
You are receiving this because you commented.Message ID:
@.***>

@breakline87 solution solved the problem for me.
{       from<EMAIL_ADDRESS>      template_id: "d-xxx",       personalizations: [         {           to: [{email<EMAIL_ADDRESS>          dynamic_template_data: {            username: "test",             subject: message.subject,           },         },       ],     };


Add "create dataset privileged" groups and review dataset authorization

This PR adds a configuration group that allows users to be able to create datasets for other groups (ingestion) and implement the correct dataset authorization.
Tests included/Docs Updated?

[ ] Included for each change/fix?
[ ] Passing? (Merge will not be approved unless this is checked)
[ ] Docs updated?
[ ] New packages used/requires npm install?
[ ] Toggle added for new features?

@bpedersen2, @nitrosx
Backend e2e test is removed for now, because of the inconsistency caused by different backend and frontend images, as well as changes in authorization, requiring either the frontend or backend to be forcibly merged with failing e2e tests.
In the future, we could apply monorepo strategy to execute e2e, instead of relying on docker images.

I would prefer for better reviewability that this branch get rebase on the current dev head and force-pushed (possbily also squashing it a bit down to useful commits ( I like this approach: https://github.blog/2022-06-30-write-better-commits-build-better-projects/).


Add support for formatting AddrOf (unary "&").

r+ with the minor comments addressed

Updated to address review comments.

Great, thank you!


node-neigh: Reduce arping related log msg's level

It is not the end of the world if any arping related operation fails (e.g. frequent connections between nodes ensure the presence of relevant L2 entries in the neigh table). So, decrease the log level of the log msgs.

Then let's prefix [DEBUG] in these messages

@aanm I've changed the logging subsystem to node-neigh-debug. PTAL.

Beyond the scope of this patch, but I took look at the callers of insertNeighbor and shouldn't we return an error here and kick the retry logic? Otherwise we are waiting for the refresh logic to kick in from neighbor-table-refresh? I would expect a failed arp could be retried almost immediately and then backed off from there if it keeps failing.

Beyond the scope of this patch, but I took look at the callers of insertNeighbor and shouldn't we return an error here and kick the retry logic

@jrfastab I've added a retry logic into both arping libraries we use. They will retry 3 times. If all fail, then it is up the periodic refresh to fix any outstanding issues.


fix: Tapping thread reply of expense hold offline, hmm not here displayed briefly

Details

Fixed Issues

$ https://github.com/Expensify/App/issues/49268
PROPOSAL: https://github.com/Expensify/App/issues/49268#issuecomment-2373304087
Tests

Open 1:1 with an user
Go offline
Create a expense
Long press the expense to hold and unhold the expense
Open the expense
Tap header -- delete expense
Go online
Note deleted message with thread reply displayed little delay
Tap on reply
Verify that: Tapping thread reply of expense hold offline, hmm not here must not be displayed briefly.

[x] Verify that no errors appear in the JS console

PR Author Checklist

[x] I linked the correct issue in the ### Fixed Issues section above
[x] I wrote clear testing steps that cover the changes made in this PR

[x] I added steps for local testing in the Tests section
[x] I added steps for the expected offline behavior in the Offline steps section
[x] I added steps for Staging and/or Production testing in the QA steps section
[x] I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
[x] I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
[x] I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).

[x] I included screenshots or videos for tests on all platforms
[x] I ran the tests on all platforms & verified they passed on:

[x] Android: Native
[x] Android: mWeb Chrome
[x] iOS: Native
[x] iOS: mWeb Safari
[x] MacOS: Chrome / Safari
[x] MacOS: Desktop

[x] I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
[x] I followed proper code patterns (see Reviewing the code)

[x] I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
[x] I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
[x] I verified that comments were added to code that is not self explanatory
[x] I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
[x] I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method

[x] If any non-english text was added/modified, I verified the translation was requested/reviewed in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:

[x] I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
[x] I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
[x] I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
[x] I verified the JSDocs style guidelines (in STYLE.md) were followed

[x] If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
[x] I followed the guidelines as stated in the Review Guidelines
[x] I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
[x] I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
[x] I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
[x] I verified that if a function's arguments changed that all usages have also been updated correctly
[x] If any new file was added I verified that:

[x] The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory

[x] If a new CSS style is added I verified that:

[x] A similar style doesn't already exist
[x] The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))

[x] If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
[x] If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
[x] If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
[x] If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
[x] If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:

[x] I verified that all the inputs inside a form are aligned with each other.
[x] I added Design label and/or tagged @Expensify/design so the design team can review the changes.

[x] If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
[x] If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Android: Native

https://github.com/user-attachments/assets/523d5eec-f750-4878-833e-e507f07b732d

Android: mWeb Chrome

https://github.com/user-attachments/assets/8e063d68-e7b5-4f2b-bedd-ec1d4624b8a8

iOS: Native

https://github.com/user-attachments/assets/bcc25515-ae5b-4493-bb4b-a26e41430b8d

iOS: mWeb Safari

https://github.com/user-attachments/assets/b71150fd-f019-40af-abf2-8bb267597dd1

MacOS: Chrome / Safari

https://github.com/user-attachments/assets/e2b131a0-fc5e-4197-98af-455a2efcbc9e

MacOS: Desktop

https://github.com/user-attachments/assets/7b6b2def-b78e-418c-9083-15b5b8ada16e

@akinwale friendly bump

@akinwale bump again

@akinwale any update here?

Apologies for the delay. I'll review this today.

Reviewer Checklist

[x] I have verified the author checklist is complete (all boxes are checked off).
[x] I verified the correct issue is linked in the ### Fixed Issues section above
[x] I verified testing steps are clear and they cover the changes made in this PR

[x] I verified the steps for local testing are in the Tests section
[x] I verified the steps for Staging and/or Production testing are in the QA steps section
[x] I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
[x] I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)

[x] I checked that screenshots or videos are included for tests on all platforms
[x] I included screenshots or videos for tests on all platforms
[x] I verified tests pass on all platforms & I tested again on:

[x] Android: Native
[x] Android: mWeb Chrome
[x] iOS: Native
[x] iOS: mWeb Safari
[x] MacOS: Chrome / Safari
[x] MacOS: Desktop

[x] If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
[x] I verified proper code patterns were followed (see Reviewing the code)

[x] I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
[x] I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
[x] I verified that comments were added to code that is not self explanatory
[x] I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
[x] I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
[x] I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
[x] I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
[x] I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
[x] I verified the JSDocs style guidelines (in STYLE.md) were followed

[x] If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
[x] I verified that this PR follows the guidelines as stated in the Review Guidelines
[x] I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
[x] I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
[x] I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
[x] If a new component is created I verified that:

[x] A similar component doesn't exist in the codebase
[x] All props are defined accurately and each prop has a /** comment above it */
[x] The file is named correctly
[x] The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
[x] The only data being stored in the state is data necessary for rendering and nothing else
[x] For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
[x] Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
[x] All JSX used for rendering exists in the render method
[x] The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions

[x] If any new file was added I verified that:

[x] The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory

[x] If a new CSS style is added I verified that:

[x] A similar style doesn't already exist
[x] The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)

[x] If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
[x] If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
[x] If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
[x] If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
[x] If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:

[x] I verified that all the inputs inside a form are aligned with each other.
[x] I added Design label and/or tagged @Expensify/design so the design team can review the changes.

[x] If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
[x] If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
[x] I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari
https://github.com/user-attachments/assets/ef3cc24b-1b4c-405f-b7b2-9fce905c8134

MacOS: Desktop

:hand: This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.


[HUDI-1696] add apache commons-codec dependency to flink-bundle explicitly

Tips

Thank you very much for contributing to Apache Hudi.
Please review https://hudi.apache.org/contributing.html before opening a pull request.

What is the purpose of the pull request
This causes the shaded code from apache commons codec to be explicitly pulled into the uber jar
Brief change log
Verify this pull request
Verified the built uber jar to contain the libraries in the path, also verified that the release has them missing
This pull request is a trivial rework / code cleanup without any test coverage.
Committer checklist

[] Has a corresponding JIRA in PR title & commit

[] Commit message is descriptive of the change

[ ] CI is green

[ ] Necessary doc changes done or have another open PR

[ ] For large changes, please consider breaking it into sub-tasks under an umbrella JIRA.

Codecov Report

Merging #2758 (ea0d401) into master (fe16d0d) will increase coverage by 0.01%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##             master    #2758      +/-   ##
============================================
+ Coverage     52.04%   52.06%   +0.01%
- Complexity     3625     3626       +1
============================================
  Files           479      477       -2
  Lines         22804    22646     -158
  Branches       2415     2436      +21
============================================
- Hits          11868    11790      -78
+ Misses         9911     9805     -106
- Partials       1025     1051      +26

Flag
Coverage Δ
Complexity Δ

hudicli
37.01% <ø> (ø)
0.00 <ø> (ø)

hudiclient
∅ <ø> (∅)
0.00 <ø> (ø)

hudicommon
50.78% <ø> (-0.14%)
0.00 <ø> (ø)

hudiflink
56.71% <ø> (+0.69%)
0.00 <ø> (ø)

hudihadoopmr
33.44% <ø> (ø)
0.00 <ø> (ø)

hudisparkdatasource
71.33% <ø> (+0.45%)
0.00 <ø> (ø)

hudisync
45.47% <ø> (ø)
0.00 <ø> (ø)

huditimelineservice
?
?

hudiutilities
69.69% <ø> (-0.09%)
0.00 <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files
Coverage Δ
Complexity Δ

...ache/hudi/sink/compact/CompactionPlanOperator.java
58.00% <0.00%> (-21.07%)
8.00% <0.00%> (-1.00%)

.../main/scala/org/apache/hudi/HoodieSparkUtils.scala
83.33% <0.00%> (-5.56%)
0.00% <0.00%> (ø%)

...src/main/scala/org/apache/hudi/DefaultSource.scala
78.78% <0.00%> (-5.36%)
31.00% <0.00%> (+14.00%)
:arrow_down:

...main/scala/org/apache/hudi/HoodieWriterUtils.scala
83.33% <0.00%> (-5.24%)
0.00% <0.00%> (ø%)

...di/common/table/timeline/HoodieActiveTimeline.java
66.81% <0.00%> (-3.97%)
43.00% <0.00%> (ø%)

...apache/hudi/sink/compact/CompactionCommitSink.java
66.66% <0.00%> (-3.55%)
10.00% <0.00%> (-1.00%)

...rg/apache/hudi/common/table/HoodieTableConfig.java
43.20% <0.00%> (-2.25%)
17.00% <0.00%> (ø%)

...pache/hudi/common/table/HoodieTableMetaClient.java
66.66% <0.00%> (-1.65%)
43.00% <0.00%> (ø%)

...c/main/java/org/apache/hudi/common/fs/FSUtils.java
47.34% <0.00%> (-0.94%)
57.00% <0.00%> (ø%)

...apache/hudi/utilities/deltastreamer/DeltaSync.java
71.08% <0.00%> (-0.64%)
55.00% <0.00%> (-1.00%)

... and 23 more


(shortfin-sd) Adds program isolation optionality and fibers_per_device.

This sets HIP_VISIBLE_DEVICES from the .yaml -- it can be exposed as a pytest option as well (it's an option for the server CLI) but this is easiest and most obvious. https://github.com/nod-ai/SHARK-Platform/issues/342 describes why this method was chosen for the runner (it's a little faster to init)


Adding contract testing

% export AKO_CONTRACT_TEST=1; go clean -testcache && go test -v ./test/contract/...
?   	github.com/mongodb/mongodb-atlas-kubernetes/v2/test/contract	[no test files]
2024/03/19 17:30:25 Wipe resources set to false
2024/03/19 17:30:25 Reusing existing resources
=== RUN   TestCreateSearchIndex
--- PASS: TestCreateSearchIndex (0.60s)
PASS
2024/03/19 17:30:26 Trying to stored search test resource references for reuse...
2024/03/19 17:30:26 Stored search test resource references for reuse
ok  	github.com/mongodb/mongodb-atlas-kubernetes/v2/test/contract/search	1.509s
2024/03/19 17:30:25 Wipe resources set to false
2024/03/19 17:30:26 Reusing existing resources
=== RUN   TestUser
2024/03/19 17:30:26 Creating user user...
2024/03/19 17:30:26 User user already created, updating password
--- PASS: TestUser (11.30s)
PASS
2024/03/19 17:30:37 Trying to stored user test resource references for reuse...
2024/03/19 17:30:37 Stored user test resource references for reuse
ok  	github.com/mongodb/mongodb-atlas-kubernetes/v2/test/contract/user	12.395s

All Submissions:

[X] Have you signed our CLA?

Feedback after discussing with @helderjs

Not only we NOT use the API calls directly on the tests, which is pending in current PR but also...
Try to reuse the production functions instead of direct calls for setting up the test infra.

Lessons around contract testing:

For us it requires quite some infrastructure automation to make sure the initial state is as expected. Usually a project and deployment need to be in place for most tests.
For local dev it is useful to keep the infrastructure around to re-test faster. For CI it needs to be cleaned up always at the end.
Ad-hoc infra automation is a waste, we probably want to use the Operator itself for this.
Calling the API directly is pointless: we must test the production code that calls the API instead. This needs our production code to separate such code and probably include full translation of types as well in such layer.


Collapsing identical reprs broken by caching

Collapsing behavior is based on pseudo-random UUIDs generated for each <ul> in an objects repr. Because the repr is cached, printing the same object twice will return exactly the same repr with the same UUIDs. When you try to collapse the second repr, the first repr will (probably) get collapsed instead.
For some reason, collapsing works correctly in Jupyter classic, Colab, and VS Code, but is broken in Jupyter Lab (including Binder) or when a notebook is rendered statically (nbviewer). I'm guessing this is an implementation detail since the UUID issue isn't platform-dependent.
The quick solution is to cache the Earth Engine data by wrapping getInfo instead of caching the repr, but regenerating the repr may be a non-negligible performance hit for huge collections. If performance is too slow I'll need to think about another solution, e.g. caching the repr but re-generating each pair of UUIDs.

I ran some tests and generating the HTML is a significant chunk of the total time for large collections and can actually take longer than getInfo, so disabling caching on the HTML generation is a no go.
Another alternative I'm looking into is bypassing UUIDs altogether. Currently, UUIDs are used to tie the header <label> to the hidden <input> checkbox, but that can also be done by just making the <input> a child of the <label> instead of a sibling (see). This would remove any possible interaction between duplicated reprs, save some processing in generating UUIDs, and make the reprs a little lighter.
The challenge is that making the <input> a child of the <label> breaks the CSS selector I'm currently using, and I'm not sure there's any workaround for that. Basically I need to be able to select eerepr-list elements that are siblings of eerepr-header elements that contain eerepr-collapser:checked inputs, but CSS selectors are almost all based around selecting children or siblings, so I'm not sure there's any way to get the parent of the checked input. The has:() selector looks promising, but isn't well supported. Instead of relying on pure CSS, I could fix that by injecting some JS into the repr, but I'd like to avoid that if possible to keep things simple.

This is fixed by scrapping UUIDs and connecting label and input elements implicitly. I don't think a pure CSS solution is possible without using has:() which would break Firefox support, so until that changes I'm using JS to handle collapsing behavior.


feat: optionally output a debug artifact on compile

Description

Problem*

Resolves #2279
Summary*

Documentation

[ ] This PR requires documentation updates when merged.

[ ] I will submit a noir-lang/docs PR.

[ ] I will request for and support Dev Rel's help in documenting this PR.

Additional Context

PR Checklist*

[x] I have tested the changes locally.
[x] I have formatted the changes with Prettier and/or cargo fmt on default settings.

I'm currently making pretty large changes to these same files for #2164 which I think this would conflict pretty heavily with. I think it would be easier if those changes went in first and then I can merge them into here.

@TomAFrench what is the corresponding PR which is blocking this one?


Regex /s not supported in lower node version

Getting regex error on index.js line 50. I am on node 8.9.4. I cannot update node to later versions due to restrictions.
On searching, it looks like this error is related to regex /s being used.

Hmm - it looks like later versions of Node 8 support it, but not 8.9.4 - are you able to update minor versions?


Use ruff (linter & formatter)

Ruff is a linter and formatter for Python code.
It has high compatibility with flake8 and black, and is easy to use.
It has good performance and is written in Rust.
https://github.com/astral-sh/ruff

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (bc9f4dd) 100.00% compared to head (eb23d73) 100.00%.
Report is 71 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff            @@
##              main      #121   +/-   ##
=========================================
  Coverage   100.00%   100.00%
=========================================
  Files            4         4
  Lines          178       178
=========================================
  Hits           178       178

Flag
Coverage Δ

unittests
100.00% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


google-cloud-sdk - install additional components: gcloud components install cloud-build-local

Describe the bug
gcloud components install cloud-build-local
ERROR: (gcloud.components.install) You cannot perform this action because this Cloud SDK installation is managed by an external package manager.
Please consider using a separate installation of the Cloud SDK created through the default mechanism described at: https://cloud.google.com/sdk/

To Reproduce
nix-env -i google-cloud-sdk
gcloud components install cloud-build-local

cloud components list

Your current Cloud SDK version is: 306.0.0
The latest available version is: 312.0.0

+---------------------------------------------------------------------------------------------------------------+
|                                                   Components                                                  |
+------------------+------------------------------------------------------+--------------------------+----------+
|      Status      |                         Name                         |            ID            |   Size   |
+------------------+------------------------------------------------------+--------------------------+----------+
| Update Available | BigQuery Command Line Tool                           | bq                       |  < 1 MiB |
| Update Available | Cloud SDK Core Libraries                             | core                     | 16.1 MiB |
| Update Available | Cloud Storage Command Line Tool                      | gsutil                   |  3.5 MiB |
| Not Installed    | App Engine Go Extensions                             | app-engine-go            |  4.9 MiB |
| Not Installed    | Appctl                                               | appctl                   | 21.0 MiB |
| Not Installed    | Cloud Bigtable Command Line Tool                     | cbt                      |  7.7 MiB |
| Not Installed    | Cloud Bigtable Emulator                              | bigtable                 |  6.6 MiB |
| Not Installed    | Cloud Datalab Command Line Tool                      | datalab                  |  < 1 MiB |
| Not Installed    | Cloud Datastore Emulator                             | cloud-datastore-emulator | 18.4 MiB |
| Not Installed    | Cloud Firestore Emulator                             | cloud-firestore-emulator | 41.0 MiB |
| Not Installed    | Cloud Pub/Sub Emulator                               | pubsub-emulator          | 34.9 MiB |
| Not Installed    | Cloud SQL Proxy                                      | cloud_sql_proxy          |  7.5 MiB |
| Not Installed    | Cloud Spanner Emulator                               | cloud-spanner-emulator   | 21.4 MiB |
| Not Installed    | Emulator Reverse Proxy                               | emulator-reverse-proxy   | 14.5 MiB |
| Not Installed    | Google Cloud Build Local Builder                     | cloud-build-local        |  6.0 MiB |
| Not Installed    | Google Container Registry's Docker credential helper | docker-credential-gcr    |  1.8 MiB |
| Not Installed    | Kind                                                 | kind                     |  4.5 MiB |
| Not Installed    | Kustomize                                            | kustomize                | 25.9 MiB |
| Not Installed    | Minikube                                             | minikube                 | 24.1 MiB |
| Not Installed    | Nomos CLI                                            | nomos                    | 17.7 MiB |
| Not Installed    | Skaffold                                             | skaffold                 | 14.5 MiB |
| Not Installed    | anthos-auth                                          | anthos-auth              | 16.0 MiB |
| Not Installed    | gcloud Alpha Commands                                | alpha                    |  < 1 MiB |
| Not Installed    | gcloud Beta Commands                                 | beta                     |  < 1 MiB |
| Not Installed    | gcloud app Java Extensions                           | app-engine-java          | 59.5 MiB |
| Not Installed    | gcloud app Python Extensions                         | app-engine-python        |  6.1 MiB |
| Not Installed    | gcloud app Python Extensions (Extra Libraries)       | app-engine-python-extras | 27.1 MiB |
| Not Installed    | kpt                                                  | kpt                      | 11.1 MiB |
| Not Installed    | kubectl                                              | kubectl                  |  < 1 MiB |
+------------------+------------------------------------------------------+--------------------------+----------+

Expected behavior
install the component (e.g. cloud-build-local)
Screenshots
If applicable, add screenshots to help explain your problem.
Additional context
Notify maintainers

@pradyuman
@stephenmw
@zimbatm
Metadata
Please run nix-shell -p nix-info --run "nix-info -m" and paste the result.

system: "x86_64-linux"
host os: Linux 5.8.9, NixOS, 20.03.2652.076c67fdea6 (Markhor)
multi-user?: yes
sandbox: yes
version: nix-env (Nix) 2.3.6
channels(ae): "OsUnstable-21.03pre243854.2a14d21224f, NxUnstable-21.03pre243968.2a35f664394, home-manager-20.03, nixos-20.03.3002.773ef5ae783"

This issue has been mentioned on NixOS Discourse. There might be relevant details there:
https://discourse.nixos.org/t/google-cloud-sdk-and-installing-extra-components/10319/1

Is there a way to do this with nixpkgs?

Is there a way to do this with nixpkgs?

any update?

would be nice to get in nix-native (and flexible)

Looks like you will have to do it yourself. You probably want something similar to terraform where you could do google-cloud-sdk.withPlugins(p: [ p.cloud-build-local)

FYI this was just added to nixpkgs.  You can do the following:
google-cloud-sdk.withExtraComponents ([google-cloud-sdk.components.cloud-build-local])

This issue has been mentioned on NixOS Discourse. There might be relevant details there:
https://discourse.nixos.org/t/google-cloud-sdk-and-installing-extra-components/10319/9

Is there a reason why it's not supported on aarch64-darwin?
error: Package ‘gke-gcloud-auth-plugin’ in /nix/store/69l88zcx53mg0zqmxjamnp0srnn7whyr-source/pkgs/tools/admin/google-cloud-sdk/components.nix:169 is not supported on ‘aarch64-darwin’, refusing to evaluate.

Two reasons:

I don't have a darwin ARM machine so I didn't have a way to test this myself.

Components in google-cloud-sdk have an architecture field that can specify arm, but it's unclear whether this is aarch64 or any other kind of ARM architecture, so I didn't really know what the right mapping was, and preferred not to make a decision.

You're welcome to try it out and make a PR tho :-]

It looks like there is an existing PR.

Hello,
Apologies if this is something obvious since I'm pretty new to nix, but the following doesn't work for me:
{ pkgs ? import (fetchTarball "https://github.com/NixOS/nixpkgs/archive/a62844b30250.tar.gz") {} }:

pkgs.mkShell {
  buildInputs = [
    pkgs.google-cloud-sdk.withExtraComponents [pkgs.google-cloud-sdk.components.cloud-build-local]
...

fails with error: Dependency is not of a valid type: element 1 of buildInputs for nix-shell
I'm pretty sure I'm doing something wrong, but can't figure it out, would appreciate some help.

That's not normal indeed, I'm looking into it.

I was facing the same deal, but came across this: https://github.com/michielboekhoff/nixos-conf/commit/3833fcc9a67f071e4191dfb751ea4bb8a2b76a69. Try adding () around the package in your buildInputs, should fix the issue:
{ pkgs ? import (fetchTarball "https://github.com/NixOS/nixpkgs/archive/a62844b30250.tar.gz") {} }:

pkgs.mkShell {
  buildInputs = [
    (pkgs.google-cloud-sdk.withExtraComponents [pkgs.google-cloud-sdk.components.cloud-build-local])
  ];
}

Thank you @learnitall , that did it!

Oh, how did I miss that :sweat_smile: Thanks @learnitall

I noticed an issue with a separate component - cloud-run-proxy
It seems to install fine with (google-cloud-sdk.withExtraComponents ([google-cloud-sdk.components.cloud-run-proxy])), and the executable is added to the bin, but trying to run cloud-run-proxy causes a command not found error - so far as I can tell, the symlink in the store that's being pointed to appears to simply point to itself, but with no actual executable anywhere.
ERROR: (gcloud.beta.run.services.proxy) Error executing command on [cloud-run-proxy]: [/nix/store/vh0vainhfkp83dilxp60fsx3pjipd24s-google-cloud-sdk-408.0.1/google-cloud-sdk/bin/cloud-run-proxy: command not found]

I'm not sure if there's something I'm missing for the installation of components? gcloud components list does claim that Cloud Run Proxy is installed.

Here's a fix: https://github.com/NixOS/nixpkgs/pull/215526

@DerekMaffett Fix was just merged in upstream nixpkgs :-)

FYI this was just added to nixpkgs. You can do the following:
google-cloud-sdk.withExtraComponents ([google-cloud-sdk.components.cloud-build-local])

@xlambein Could you please give the full example how this is used? What file to add this too? Thanks.

@ckt114 Same way as you'd use google-cloud-sdk alone, so e.g. in a devShell's buildInputs.  See e.g. https://github.com/NixOS/nixpkgs/issues/99280#issuecomment-1267627236

Lol I can’t believe I missed that comment. Thanks a lot @xlambein.

@xlambein Would you able to show me how to install it with nix-env? I tried the below command below but it's throwing error.
command
nix-env -f '<nixpkgs>' -iA (google-cloud-sdk.withExtraComponents [google-cloud-sdk.components.cloud-build-local])
error
error: attribute '(google-cloud-sdk' in selection path '(google-cloud-sdk.withExtraComponents' not found        Did you mean google-cloud-sdk?

I've actually never used nix-env, but looking at your command, it seems like you didn't quote the Nix expression, so maybe try doing that?
Also, in general I'd recommend using a dev shell instead of nix-env, see https://nixos.wiki/wiki/Development_environment_with_nix-shell.  It makes it easier to create a reproducible environment for a specific project.

I did quote it with single and double quote but still getting same error. I use nix mainly for the shell to avoid brew updating my tools that I can't downgrade. I tried using nix-shell but it took 3+ seconds to start a nix shell which is quite annoying.

Hi, what would be the full install command with nix profile install...  ?  I tried the following and failed miserably
$ nix profile install (nixpkgs#google-cloud-sdk.withExtraComponents [pkgs.google-cloud-sdk.components.cloud-build-local])
-bash: syntax error near unexpected token `('


Prevent memory bloat in ActiveJob children

ActiveJob attaches a single LogSubscriber to be notified of events.
When one job enqueues another, that's treated as a child event and
stored on the same stack as the parent. If a large number of children
are enqueued that leads to R14 errors on Heroku.
The fix here is to unsubscribe all existing "enqueue" listeners and
then add a new subscriber for just that event. The original handler
is copied from the parent class using define_method so that it's
picked up by attach_to.
Related:
https://github.com/rails/rails/issues/21036
https://github.com/rails/rails/pull/5932
Before and after:

🎩  tip @trevororeilly

That's an impressive memory improvement!
The implementation looks good to me, but others might have some thoughts.

The example chart obviously specific to our app, which had a lot of jobs kicking off child jobs as part of an ETL process.


Update Openshift Demo with gitea

Update to new version of gitea-operator. The old source is not valid anymore. In addition the urls in the documentation were wrong.

Thanks @hurzelpurzel


when item is removed or added screen/ui flickers

whenever a new item is added into list then below items of the list gets flicker. as it can be seen in the example app of this package too. can you guys fix it?

Hi @zohaib1313
Thank you for bringing this to our attention. We've recently made changes to address this issue. Could you please try using the latest version and let us know if the problem persists?


[CanvasCast] Not all courses are shown

Extension – CanvasCast
Author: @YodaLightsabr
Description
Not all courses are shown. For me, only the first 8 of my 14 courses are shown.
Steps To Reproduce

Have more than 10 courses
Use the command

The current behavior
Not all courses are shown. For me, only the first 8 of my 14 courses are shown, which I think is because the other 2 courses returned in the first page of /api/v1/courses are old courses/don‘t appear on my dashboard (yet the enrollment_state is active… I’m not sure what’s going on here).
The expected behavior
All courses are shown. Pagination should be used and the per_page value should be set to a higher value (if unset like it is currently, it defaults to 10).
Raycast version
Version: 1.38.3

Is it pagination or unfavorited courses? If it's pagination I'd expect a different cutoff number. I'll take a look a bit later.

It’s pagination. The issue isn‘t with the unfavourited courses, of which there are 2 (which explains why only 8 courses are displayed). /api/v1/courses returns my first 10 courses, including 2 unfavourited ones (which I want to continue to not display), but I have 4 more unfavourited courses that I want to see.

Oh ok. This sounds like an easy enough thing to fix.


Overflow fix

Small fix to be able to include overflow bin in histogram plots. Before overflow bins were only included in case a variabe_inst.x.slice was defined.

This was meant to be a merge with the master branch on GhentAnalysis github instead of the central columnflow.


display="block" in CSL style is not respected in LaTeX output

With the test document below and apa-annotated-bibliography.csl style, the abstract of the citation is not separated from the previous part of the citation. The URL is directly followed, without any space or new line, etc., by the first letter in the abstract. The LaTeX rendering looks like this:
...\url{https://doi.org/10.1001/jamacardio.2016.3312}P values and...

I initially thought this was an issue with the style itself and I have attempted to patch it (https://github.com/citation-style-language/styles/pull/2277) but I was told this was rather a CSL processor issue. It seems that pandoc-citeproc needs to recognize and handle display="block" attribute of <text> in CSL style.
Test document:
---
csl: apa-annotated-bibliography.csl
references:
- id: Mark2016
  type: article-journal
  author:
  - family: Mark
    given: Daniel B.
  - family: Lee
    given: Kerry L.
  - family: Harrell
    given: Frank E.
    suffix: Jr.
  issued:
  - year: '2016'
    month: '10'
    day: '12'
  title: Understanding the role of p values and hypothesis tests in clinical research
  container-title: JAMA Cardiology
  abstract: P values and hypothesis testing methods are frequently misused in clinical
    research. Much of this misuse appears to be owing to the widespread, mistaken
    belief that they provide simple, reliable, and objective triage tools for separating
    the true and important from the untrue or unimportant. The primary focus in interpreting
    therapeutic clinical research data should be on the treatment (“oomph”) effect,
    a metaphorical force that moves patients given an effective treatment to a different
    clinical state relative to their control counterparts. This effect is assessed
    using 2 complementary types of statistical measures calculated from the data,
    namely, effect magnitude or size and precision of the effect size. In a randomized
    trial, effect size is often summarized using constructs, such as odds ratios,
    hazard ratios, relative risks, or adverse event rate differences. How large a
    treatment effect has to be to be consequential is a matter for clinical judgment.
    The precision of the effect size (conceptually related to the amount of spread
    in the data) is usually addressed with confidence intervals. P values (significance
    tests) were first proposed as an informal heuristic to help assess how “unexpected”
    the observed effect size was if the true state of nature was no effect or no difference.
    Hypothesis testing was a modification of the significance test approach that envisioned
    controlling the false-positive rate of study results over many (hypothetical)
    repetitions of the experiment of interest. Both can be helpful but, by themselves,
    provide only a tunnel vision perspective on study results that ignores the clinical
    effects the study was conducted to measure.
  URL: http://dx.doi.org/10.1001/jamacardio.2016.3312
  DOI: 10.1001/jamacardio.2016.3312
  ISSN: '2380-6583'
...

# Text

This and that is said in @Mark2016. Another sentence here.

# References

I have used pandoc --verbose  --filter pandoc-citeproc -f markdown -t latex -o test-citeproc.pdf test-citeproc.md to process it.

(mostly a duplicate of https://github.com/jgm/pandoc-citeproc/issues/85 )