When I am trying to run npm run server:dev --host abc.com, it is not loading correctly and getting Invalid host address

We have to connect remote machine to get API access, but unable to connect it via --host
Tried to include angular/cli but it is not working. Could you please help on this

Hi @randeepnathtr . You're serving your api through http right? Why are you trying to use "npm run" to connect on that API? It's not easier to do a simple http call?


Update README.md for new Tesla API link

The Tesla API link in the README is out of date, this PR has the correct one

thanks liko


add custom commands "cmd":"download_logs"

could you write your command for example download logs
{ "token":"str", "cmd":"download_logs"  }

Yep, this can be done quite easily.  The only issue I believe is that download logs does something weird, not sure if I ever did implement it properly, but you can try it.
The way to do this is miner.api.send_command("download_logs").

Regarding the parameter, if you want to send an encoded command you can use miner.api.send_privileged_command("download_logs"), which parses the token and handles encoding for you with whatsminers.


Only inputs on the first level can be set to node setErrors

Reproduction
sample below
Describe the bug
If I define a form and a group in it. I don't have the possibility to set error messages to inputs embedded in the group via node.setErrors(...).
I tried to set setErrors via:
<my-form-instance>.node.setErrors({
  <my-group-name>: {
    firstName: 'Test error message'
  }
})

but the tread doesn't work. It is probably due to the logic in the createMessages method, which counts on assigning error messages only to first level inputs.
Environment
• OS: Linux
• Browser Chrome (beta)
• Version 1.0.0-beta.10-54f014c

Keys should be a flat object and use dot-notation, as specified here https://formkit.com/essentials/forms#input-errors and linked to here https://formkit.com/advanced/core#traversal:
So:
formNode.setErrors({
  'topLevelInputName': ['error1, 'error2'],
  'groupName.inputName': 'deep error'
})

Sorry, i’ll try ❤


[[BEAM-5092] Row comparison should be faster when both are POJOs.

In this case, we can delegate comparison to the target object instead of extracting all values first.

@timrobertson100 FYI as well

Run Java PreCommit

Run Java PreCommit

Run Java PreCommit

Run Java PreCommit

@timrobertson100 @apilloud any more comments?

Thanks @reuvenlax
A typo in the jdoc you just updated but otherwise LGTM (contributor not committer)

Run Java PreCommit

Run Java PreCommit

Run Java PreCommit

Run Java PreCommit


White item menu on white background color

When read code and select text, item menu and toolbar bad visible.

Is this the same as #114?

Ok. Sory


Flask and python fast load scripts

Adds several scripts to test flask and python.

Git shows load_coreutils.sh changes as an empty file, this is fine because I just added chmod +x to it.

Overall this is just really impressive work! Other than my code cleanliness comments, I did wonder about the _speedups.so file added... why are we adding a static object? If it's compiled by the nacl toolchain shouldn't we instead just include a way to build it? And if not, then what is it used for?

Ah ok I see that it's removed in the second PR

I think this failed the CI because it still has the outdated setsid test that Caglar fixed.


changed colour of buttons

Please attach screenshot of your work for review.
Thanks.

Please reply, otherwise I will have to close this PR.


Docker always build failed in linux 4.6 kernel

Output of docker version:
docker version
Client:
 Version:      1.11.2
 API version:  1.23
 Go version:   go1.5.4
 Git commit:   b9f10c9
 Built:        Wed Jun  1 22:00:43 2016
 OS/Arch:      linux/amd64

Server:
 Version:      1.11.2
 API version:  1.23
 Go version:   go1.5.4
 Git commit:   b9f10c9
 Built:        Wed Jun  1 22:00:43 2016
 OS/Arch:      linux/amd64

Output of docker info:
docker info
Containers: 0
 Running: 0
 Paused: 0
 Stopped: 0
Images: 21
Server Version: 1.11.2
Storage Driver: btrfs
 Build Version: Btrfs v4.4
 Library Version: 101
Logging Driver: json-file
Cgroup Driver: cgroupfs
Plugins:
 Volume: local
 Network: bridge null host
Kernel Version: 4.6.2-xanmod4
Operating System: Ubuntu 16.04 LTS
OSType: linux
Architecture: x86_64
CPUs: 4
Total Memory: 7.704 GiB
Name: mrtux-lappy
ID: CK52:GUBD:ORBO:BQD6:MORU:PBRV:2DYQ:H4KJ:5IYP:A2VL:MZGR:PFIW
Docker Root Dir: /SSD/docker
Debug mode (client): false
Debug mode (server): false
Username: thuandt
Registry: https://index.docker.io/v1/

Additional environment details:
It's my laptop: Dell Vostro 3550.
Kernel parameters:
[Fri Jun 10 19:54:44 2016] -  microcode: microcode updated early to revision 0x29, date = 2013-06-12
[Fri Jun 10 19:54:44 2016] -  Linux version 4.6.2-xanmod4 (root@BabyMachine) (gcc version 6.1.1 20160603 (Debian 6.1.1-5) ) #1 SMP Wed Jun 8 18:29:15 UTC 2016
[Fri Jun 10 19:54:44 2016] -  Command line: BOOT_IMAGE=/boot/vmlinuz-4.6.2-xanmod4 root=UUID=bb9fc675-f03d-41a6-81b1-ba1d7865255b ro quiet splash intel_pstate=disable libahci.ignore_sss=1 pcie_aspm=force radeon.dpm=1 ipv6.disable=1 apparmor=1 security=apparmor cgroup_enable=memory swapaccount=1 vt.handoff=7

Steps to reproduce the issue:

Create simple Dockerfile with content

FROM alpine:3.4
RUN apk add --update ca-certificates && rm -rf /var/cache/apk/*

Build docker image for it

docker --no-cache build -t test:test .

Describe the results you received:
Sending build context to Docker daemon 51.88 MB
Step 1 : FROM alpine:3.4
 ---> 29cc5addcb99
Step 2 : RUN apk add --update ca-certificates && rm -rf /var/cache/apk/*
 ---> Running in 5f661c3cc71f
The command '/bin/sh -c apk add --update ca-certificates && rm -rf /var/cache/apk/*' returned a non-zero code: 139

**Additional information you deem important **
I can build this image normally in 4.4 kernel

what did it get when you run following in alpine ?
/bin/sh -c apk add --update ca-certificates && rm -rf /var/cache/apk/*

@HackToday I already told that

I can build this image normally in 4.4 kernel

So Dockerfile isn't have any error.

@thuandt I think @HackToday means if there's any more output if you run that command interactively in a container. If it also fails, and doesn't provide any useful error, could you try with an interactive container, and running it with --privileged, --security-opt seccomp=unconfined, and --security-opt apparmor=unconfined?

docker always return 1 :(
In kernel 4.4, I can access ash shell of alpine when run above commands

@justincormack any ideas?

I too have this problem

Can you run the diagnostic script https://raw.githubusercontent.com/docker/docker/master/contrib/check-config.sh maybe there is something not right about the kernel configuration?

warning: /proc/config.gz does not exist, searching other paths for kernel config ...
info: reading kernel config from /boot/config-4.6.0-040600-generic ...

Generally Necessary:
- cgroup hierarchy: properly mounted [/sys/fs/cgroup]
- apparmor: enabled and tools installed
- CONFIG_NAMESPACES: enabled
- CONFIG_NET_NS: enabled
- CONFIG_PID_NS: enabled
- CONFIG_IPC_NS: enabled
- CONFIG_UTS_NS: enabled
- CONFIG_DEVPTS_MULTIPLE_INSTANCES: enabled
- CONFIG_CGROUPS: enabled
- CONFIG_CGROUP_CPUACCT: enabled
- CONFIG_CGROUP_DEVICE: enabled
- CONFIG_CGROUP_FREEZER: enabled
- CONFIG_CGROUP_SCHED: enabled
- CONFIG_CPUSETS: enabled
- CONFIG_MEMCG: enabled
- CONFIG_KEYS: enabled
- CONFIG_MACVLAN: enabled (as module)
- CONFIG_VETH: enabled (as module)
- CONFIG_BRIDGE: enabled (as module)
- CONFIG_BRIDGE_NETFILTER: enabled (as module)
- CONFIG_NF_NAT_IPV4: enabled (as module)
- CONFIG_IP_NF_FILTER: enabled (as module)
- CONFIG_IP_NF_TARGET_MASQUERADE: enabled (as module)
- CONFIG_NETFILTER_XT_MATCH_ADDRTYPE: enabled (as module)
- CONFIG_NETFILTER_XT_MATCH_CONNTRACK: enabled (as module)
- CONFIG_NF_NAT: enabled (as module)
- CONFIG_NF_NAT_NEEDED: enabled
- CONFIG_POSIX_MQUEUE: enabled

Optional Features:
- CONFIG_USER_NS: enabled
- CONFIG_SECCOMP: enabled
- CONFIG_CGROUP_PIDS: enabled
- CONFIG_MEMCG_SWAP: enabled
- CONFIG_MEMCG_SWAP_ENABLED: missing
    (note that cgroup swap accounting is not enabled in your kernel config, you can enable it by setting boot option "swapaccount=1")
- CONFIG_BLK_CGROUP: enabled
- CONFIG_BLK_DEV_THROTTLING: enabled
- CONFIG_IOSCHED_CFQ: enabled
- CONFIG_CFQ_GROUP_IOSCHED: enabled
- CONFIG_CGROUP_PERF: enabled
- CONFIG_CGROUP_HUGETLB: enabled
- CONFIG_NET_CLS_CGROUP: enabled (as module)
- CONFIG_CGROUP_NET_PRIO: enabled
- CONFIG_CFS_BANDWIDTH: enabled
- CONFIG_FAIR_GROUP_SCHED: enabled
- CONFIG_RT_GROUP_SCHED: missing
- CONFIG_EXT3_FS: missing
- CONFIG_EXT3_FS_XATTR: missing
- CONFIG_EXT3_FS_POSIX_ACL: missing
- CONFIG_EXT3_FS_SECURITY: missing
    (enable these ext3 configs if you are using ext3 as backing filesystem)
- CONFIG_EXT4_FS: enabled
- CONFIG_EXT4_FS_POSIX_ACL: enabled
- CONFIG_EXT4_FS_SECURITY: enabled
- Network Drivers:
  - "overlay":
    - CONFIG_VXLAN: enabled (as module)
- Storage Drivers:
  - "aufs":
    - CONFIG_AUFS_FS: missing
  - "btrfs":
    - CONFIG_BTRFS_FS: enabled (as module)
  - "devicemapper":
    - CONFIG_BLK_DEV_DM: enabled (as module)
    - CONFIG_DM_THIN_PROVISIONING: enabled (as module)
  - "overlay":
    - CONFIG_OVERLAY_FS: enabled (as module)
  - "zfs":
    - /dev/zfs: missing
    - zfs command: missing
    - zpool command: missing

Limits:
- /proc/sys/kernel/keys/root_maxkeys: 1000000

warning: /proc/config.gz does not exist, searching other paths for kernel config ...
info: reading kernel config from /boot/config-4.6.2-xanmod4 ...

Generally Necessary:
- cgroup hierarchy: properly mounted [/sys/fs/cgroup]
- apparmor: enabled and tools installed
- CONFIG_NAMESPACES: enabled
- CONFIG_NET_NS: enabled
- CONFIG_PID_NS: enabled
- CONFIG_IPC_NS: enabled
- CONFIG_UTS_NS: enabled
- CONFIG_DEVPTS_MULTIPLE_INSTANCES: enabled
- CONFIG_CGROUPS: enabled
- CONFIG_CGROUP_CPUACCT: enabled
- CONFIG_CGROUP_DEVICE: enabled
- CONFIG_CGROUP_FREEZER: enabled
- CONFIG_CGROUP_SCHED: enabled
- CONFIG_CPUSETS: enabled
- CONFIG_MEMCG: enabled
- CONFIG_KEYS: enabled
- CONFIG_MACVLAN: enabled (as module)
- CONFIG_VETH: enabled (as module)
- CONFIG_BRIDGE: enabled (as module)
- CONFIG_BRIDGE_NETFILTER: enabled (as module)
- CONFIG_NF_NAT_IPV4: enabled (as module)
- CONFIG_IP_NF_FILTER: enabled (as module)
- CONFIG_IP_NF_TARGET_MASQUERADE: enabled (as module)
- CONFIG_NETFILTER_XT_MATCH_ADDRTYPE: enabled (as module)
- CONFIG_NETFILTER_XT_MATCH_CONNTRACK: enabled (as module)
- CONFIG_NF_NAT: enabled (as module)
- CONFIG_NF_NAT_NEEDED: enabled
- CONFIG_POSIX_MQUEUE: enabled

Optional Features:
- CONFIG_USER_NS: enabled
- CONFIG_SECCOMP: enabled
- CONFIG_CGROUP_PIDS: enabled
- CONFIG_MEMCG_SWAP: enabled
- CONFIG_MEMCG_SWAP_ENABLED: missing
    (note that cgroup swap accounting is not enabled in your kernel config, you can enable it by setting boot option "swapaccount=1")
- CONFIG_BLK_CGROUP: enabled
- CONFIG_BLK_DEV_THROTTLING: enabled
- CONFIG_IOSCHED_CFQ: enabled
- CONFIG_CFQ_GROUP_IOSCHED: enabled
- CONFIG_CGROUP_PERF: enabled
- CONFIG_CGROUP_HUGETLB: enabled
- CONFIG_NET_CLS_CGROUP: enabled (as module)
- CONFIG_CGROUP_NET_PRIO: enabled
- CONFIG_CFS_BANDWIDTH: enabled
- CONFIG_FAIR_GROUP_SCHED: enabled
- CONFIG_RT_GROUP_SCHED: missing
- CONFIG_EXT3_FS: missing
- CONFIG_EXT3_FS_XATTR: missing
- CONFIG_EXT3_FS_POSIX_ACL: missing
- CONFIG_EXT3_FS_SECURITY: missing
    (enable these ext3 configs if you are using ext3 as backing filesystem)
- CONFIG_EXT4_FS: enabled
- CONFIG_EXT4_FS_POSIX_ACL: enabled
- CONFIG_EXT4_FS_SECURITY: enabled
- Network Drivers:
  - "overlay":
    - CONFIG_VXLAN: enabled (as module)
- Storage Drivers:
  - "aufs":
    - CONFIG_AUFS_FS: enabled (as module)
  - "btrfs":
    - CONFIG_BTRFS_FS: enabled (as module)
  - "devicemapper":
    - CONFIG_BLK_DEV_DM: enabled
    - CONFIG_DM_THIN_PROVISIONING: enabled (as module)
  - "overlay":
    - CONFIG_OVERLAY_FS: enabled (as module)
  - "zfs":
    - /dev/zfs: missing
    - zfs command: missing
    - zpool command: missing

Limits:
- /proc/sys/kernel/keys/root_maxkeys: 1000000

My diagnostic says that the kernel 4.4 had linux-image-extra package which had support for "aufs" storage driver which seem to be required by docker daemon.
I got no solution yet

@fragsalat Thanks but I'm sure it isn't about storage driver.
I don't use AUFS for Docker at all since Ubuntu 15.10

@thuandt What is the output if you want to start the daemon?

I start it via customize docker service file
● docker.service - Docker Application Container Engine
   Loaded: loaded (/lib/systemd/system/docker.service; enabled; vendor preset: enabled)
  Drop-In: /etc/systemd/system/docker.service.d
           └─ubuntu.conf
   Active: active (running) since Mon 2016-06-20 09:22:43 ICT; 1 day 12h ago
     Docs: https://docs.docker.com
 Main PID: 987 (docker)
    Tasks: 22
   Memory: 22.7M
      CPU: 1min 448ms
   CGroup: /system.slice/docker.service
           ├─ 987 /usr/bin/docker daemon -H fd:// --dns <IP_ADDRESS> --dns <IP_ADDRESS> -g /SSD/docker --storage-driver=btrfs
           └─1061 docker-containerd -l /var/run/docker/libcontainerd/docker-containerd.sock --runtime docker-runc --start-timeout 2m

Ok then I can't help. For me it was the daemon with the problem

I also created issue in Alpine Bug Tracker: https://bugs.alpinelinux.org/issues/5892
Because I can run normally with all another container based FROM ubuntu:14.04.
Seem it's alpine problem.

works for me on kernel 4.7
core@ip-192-168-254-162 ~/test $ uname -r
4.7.0-coreos

core@ip-192-168-254-162 ~/test $ docker version
Client:
 Version:      1.11.2
 API version:  1.23
 Go version:   go1.5.4
 Git commit:   4a6e2b1
 Built:
 OS/Arch:      linux/amd64

Server:
 Version:      1.11.2
 API version:  1.23
 Go version:   go1.5.4
 Git commit:   4a6e2b1
 Built:
 OS/Arch:      linux/amd64

core@ip-192-168-254-162 ~/test $ docker info
Containers: 36
 Running: 2
 Paused: 0
 Stopped: 34
Images: 274
Server Version: 1.11.2
Storage Driver: overlay
 Backing Filesystem: extfs
Logging Driver: json-file
Cgroup Driver: cgroupfs
Plugins:
 Volume: local
 Network: null host bridge
Kernel Version: 4.7.0-coreos
Operating System: CoreOS 1122.0.0 (MoreOS)
OSType: linux
Architecture: x86_64
CPUs: 1
Total Memory: 3.679 GiB
Name: ip-192-168-254-162.us-west-2.compute.internal
ID: -snip-
Docker Root Dir: /var/lib/docker
Debug mode (client): false
Debug mode (server): false
Registry: https://index.docker.io/v1/

core@ip-192-168-254-162 ~/test $ cat Dockerfile
FROM alpine:3.4
RUN apk add --update ca-certificates && rm -rf /var/cache/apk/*

core@ip-192-168-254-162 ~/test $ docker build --no-cache -t test:test .
Sending build context to Docker daemon 2.048 kB
Step 1 : FROM alpine:3.4
 ---> f70c828098f5
Step 2 : RUN apk add --update ca-certificates && rm -rf /var/cache/apk/*
 ---> Running in c3ba3a874fca
fetch http://dl-cdn.alpinelinux.org/alpine/v3.4/main/x86_64/APKINDEX.tar.gz
fetch http://dl-cdn.alpinelinux.org/alpine/v3.4/community/x86_64/APKINDEX.tar.gz
(1/1) Installing ca-certificates (20160104-r4)
Executing busybox-1.24.2-r8.trigger
Executing ca-certificates-20160104-r4.trigger
OK: 5 MiB in 12 packages
 ---> 1717f9011b6c
Removing intermediate container c3ba3a874fca
Successfully built 1717f9011b6c

Is this still an issue for others, or can we close?

I have since switched to 4.4 again so I cannot comment.

I've seen similar behavior on Ubuntu 16.04 with the following 'docker run' as a sanity check for Alpine in general:
➜  /tmp docker run -ti --entrypoint=/bin/sh alpine /bin/sh
➜  /tmp echo $?
139

Here's the output of the diag script:
info: reading kernel config from /boot/config-4.6.4-xanmod6 ...

Generally Necessary:
- cgroup hierarchy: properly mounted [/sys/fs/cgroup]
- apparmor: enabled and tools installed
- CONFIG_NAMESPACES: enabled
- CONFIG_NET_NS: enabled
- CONFIG_PID_NS: enabled
- CONFIG_IPC_NS: enabled
- CONFIG_UTS_NS: enabled
- CONFIG_DEVPTS_MULTIPLE_INSTANCES: enabled
- CONFIG_CGROUPS: enabled
- CONFIG_CGROUP_CPUACCT: enabled
- CONFIG_CGROUP_DEVICE: enabled
- CONFIG_CGROUP_FREEZER: enabled
- CONFIG_CGROUP_SCHED: enabled
- CONFIG_CPUSETS: enabled
- CONFIG_MEMCG: enabled
- CONFIG_KEYS: enabled
- CONFIG_VETH: enabled (as module)
- CONFIG_BRIDGE: enabled (as module)
- CONFIG_BRIDGE_NETFILTER: enabled (as module)
- CONFIG_NF_NAT_IPV4: enabled (as module)
- CONFIG_IP_NF_FILTER: enabled (as module)
- CONFIG_IP_NF_TARGET_MASQUERADE: enabled (as module)
- CONFIG_NETFILTER_XT_MATCH_ADDRTYPE: enabled (as module)
- CONFIG_NETFILTER_XT_MATCH_CONNTRACK: enabled (as module)
- CONFIG_NF_NAT: enabled (as module)
- CONFIG_NF_NAT_NEEDED: enabled
- CONFIG_POSIX_MQUEUE: enabled

Optional Features:
- CONFIG_USER_NS: enabled
- CONFIG_SECCOMP: enabled
- CONFIG_CGROUP_PIDS: enabled
- CONFIG_MEMCG_SWAP: enabled
- CONFIG_MEMCG_SWAP_ENABLED: missing
    (note that cgroup swap accounting is not enabled in your kernel config, you can enable it by setting boot option "swapaccount=1")
- CONFIG_BLK_CGROUP: enabled
- CONFIG_BLK_DEV_THROTTLING: enabled
- CONFIG_IOSCHED_CFQ: enabled
- CONFIG_CFQ_GROUP_IOSCHED: enabled
- CONFIG_CGROUP_PERF: enabled
- CONFIG_CGROUP_HUGETLB: enabled
- CONFIG_NET_CLS_CGROUP: enabled (as module)
- CONFIG_CGROUP_NET_PRIO: enabled
- CONFIG_CFS_BANDWIDTH: enabled
- CONFIG_FAIR_GROUP_SCHED: enabled
- CONFIG_RT_GROUP_SCHED: missing
- CONFIG_IP_VS: enabled (as module)
- CONFIG_EXT3_FS: missing
- CONFIG_EXT3_FS_XATTR: missing
- CONFIG_EXT3_FS_POSIX_ACL: missing
- CONFIG_EXT3_FS_SECURITY: missing
    (enable these ext3 configs if you are using ext3 as backing filesystem)
- CONFIG_EXT4_FS: enabled
- CONFIG_EXT4_FS_POSIX_ACL: enabled
- CONFIG_EXT4_FS_SECURITY: enabled
- Network Drivers:
  - "overlay":
    - CONFIG_VXLAN: enabled (as module)
    Optional (for secure networks):
    - CONFIG_XFRM_ALGO: enabled (as module)
    - CONFIG_XFRM_USER: enabled (as module)
  - "ipvlan":
    - CONFIG_IPVLAN: enabled (as module)
  - "macvlan":
    - CONFIG_MACVLAN: enabled (as module)
    - CONFIG_DUMMY: enabled (as module)
- Storage Drivers:
  - "aufs":
    - CONFIG_AUFS_FS: enabled (as module)
  - "btrfs":
    - CONFIG_BTRFS_FS: enabled (as module)
    - CONFIG_BTRFS_FS_POSIX_ACL: enabled
  - "devicemapper":
    - CONFIG_BLK_DEV_DM: enabled
    - CONFIG_DM_THIN_PROVISIONING: enabled (as module)
  - "overlay":
    - CONFIG_OVERLAY_FS: enabled (as module)
  - "zfs":
    - /dev/zfs: missing
    - zfs command: missing
    - zpool command: missing

Limits:
- /proc/sys/kernel/keys/root_maxkeys: 1000000

@nrvale0 docker run -ti --entrypoint=/bin/sh alpine /bin/sh  is not valid - it is trying to run /bin/sh /bin/sh which is not valid syntax. You need docker run -ti --entrypoint=/bin/sh alpine -c /bin/sh or something, not sure what you are trying.
I am going to close this as the original does not seem to be a problem now.  I will do some testing soon with more recent kernels than 4.4.

@justincormack I just tested this yesterday (without the --entrypoint) and same result : SEGV
➜  ~ docker pull alpine:latest && docker run -ti alpine:latest /bin/sh ; echo $?; uname -a
latest: Pulling from library/alpine

Digest: sha256:02eb5cfe4b721495135728ab4aea87418fd4edbfbf83612130a81191f0b2aae3
Status: Image is up to date for alpine:latest
139
Linux atacama 4.6.7-xanmod9 #1 SMP Thu Aug 18 01:45:56 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux


render rest children to LayerUI

Right now in excalidraw.com we render some app components outside <Excalidraw/> but use internal components.
For example, the <Collab/> dialog uses <Dialog/>, but is rendered outside. So context and atoms (potentially) won't be set correctly.
Thus, this does nothing at best:
https://github.com/excalidraw/excalidraw/blob/618442299f85229a0e5c1fdb7c3bb9aeaa850a50/src/components/Dialog.tsx#L78-L79
When used inside the <RoomDialog/>:
https://github.com/excalidraw/excalidraw/blob/618442299f85229a0e5c1fdb7c3bb9aeaa850a50/src/excalidraw-app/collab/RoomDialog.tsx#L178-L185
We should render app-custom children passed to Excalidraw to <LayerUI/> as is, so we can move the <Collab/> inside <Excalidraw/>.
Longer-term we'll may introduce an <ExcalidrawContext/>, but it's unclear how and whether it will work, and in some cases like the this issue it's unnecessary.

To confirm If I understand correctly, rn since we are allowing only named components, host cannot render anything apart from that and hence the dialog inside collab will not have access to the context, atoms.
To solve this, if we have named collab component host will be able to render it. But for other components (custom ones) this is not possible as we filter.
So one solution is what you are doing but in this we are allowing all top level children to render. Another approach what I think is for those components which could be used outside Excalidraw (so the generic UI components), eg button, dropdown, dialog, these should be pure components and not be dependent on these hooks directly, that way these components could be used outside excal easily and later on if we create a library of UI components of Excalidraw, these components could be directly moved into the library as they are pure components.

To confirm If I understand correctly, rn since we are allowing only named components, host cannot render anything apart from that and hence the dialog inside collab will not have access to the context, atoms.
To solve this, if we have named collab component host will be able to render it. But for other components (custom ones) this is not possible as we filter.

No, we're just not rendering anything custom from the host. Naming or not naming will not solve it.

So one solution is what you are doing but in this we are allowing all top level children to render. Another approach what I think is for those components which could be used outside Excalidraw (so the generic UI components), eg button, dropdown, dialog, these should be pure components and not be dependent on these hooks directly, that way these components could be used outside excal easily and later on if we create a library of UI components of Excalidraw, these components could be directly moved into the library as they are pure components. In other words, these UI components shouldn't be tightly coupled to editor.

The Dialog in question is a private component, so excalidraw.com shouldn't even be using it — but it is (meaning, current production is buggy in that the state is not working as intended). We can rewrite the component's API so it's more reusable, but who knows how long that will take. And I'm not confident that we would be able to remove all dependencies on editor state — let's say dark mode toggling or i18n. So it wouldn't be reusable without exposing some Excalidraw provider/context as we discussed and making hosts wrap those components in that provider anyway — at which point whether you render inside the Excalidraw container or in the Excalidraw provider will not make that much difference.


Update document to adding argocd CLI to create applications

We need to update document to adding argocd CLI to create applications, so that the CICD or some test tools can leverage argocd CLI to do gitops.

we can also use the CLI like kubectl/oc apply -f application.yaml to create the gitops applications which is also kubernetes native.

We can update 3.2 document first @liyanwei93


Move LY and LYC elsewhere

They don't really pertain to scrolling (where they currently are, mostly because that's where they have always been), but where else should they go?

If anywhere, LY and LYC belong near STAT, as they reflect the status of the PPU and control one of the STAT IRQ sources.


TiCDC misses backslash(\) when replicating ddl to downstream

What did you do?
This is a bug found in tidb issue.

Set sql mode in both upstream and downstream tidbs

-- downstream
set sql_mode = "NO_BACKSLASH_ESCAPES";
set global  sql_mode = "NO_BACKSLASH_ESCAPES";

-- upstream
set sql_mode = "NO_BACKSLASH_ESCAPES";
set global  sql_mode = "NO_BACKSLASH_ESCAPES";

Create a changefeed to start a replication

-- upstream
create table t20(id bigint primary key, a text, b text as ((regexp_replace(a, "^[1-9]\d{9,29}$", "aaaaa"))), c text as ((regexp_substr(a, "^[1-9]\d{9,29}$"))), d text as ((regexp_like(a, "^[1-9]\d{9,29}$"))), e text as ((regexp_instr(a, "^[1-9]\d{9,29}$"))));

-- downstream
show create table t20;

What did you expect to see?
| t20   | CREATE TABLE `t20` (
  `id` bigint(20) NOT NULL,
  `a` text DEFAULT NULL,
  `b` text GENERATED ALWAYS AS ((regexp_replace(`a`, _utf8'^[1-9]\\d{9,29}$', _utf8'aaaaa'))) VIRTUAL,
  `c` text GENERATED ALWAYS AS ((regexp_substr(`a`, _utf8'^[1-9]\\d{9,29}$'))) VIRTUAL,
  `d` text GENERATED ALWAYS AS ((regexp_like(`a`, _utf8'^[1-9]\\d{9,29}$'))) VIRTUAL,
  `e` text GENERATED ALWAYS AS ((regexp_instr(`a`, _utf8'^[1-9]\\d{9,29}$'))) VIRTUAL,
  PRIMARY KEY (`id`) /*T![clustered_index] CLUSTERED */
) ENGINE=InnoDB DEFAULT CHARSET=utf8mb4 COLLATE=utf8mb4_bin |

What did you see instead?
| t20   | CREATE TABLE `t20` (
  `id` bigint(20) NOT NULL,
  `a` text DEFAULT NULL,
  `b` text GENERATED ALWAYS AS ((regexp_replace(`a`, _utf8mb4'^[1-9]d{9,29}$', _utf8mb4'aaaaa'))) VIRTUAL,
  `c` text GENERATED ALWAYS AS ((regexp_substr(`a`, _utf8mb4'^[1-9]d{9,29}$'))) VIRTUAL,
  `d` text GENERATED ALWAYS AS ((regexp_like(`a`, _utf8mb4'^[1-9]d{9,29}$'))) VIRTUAL,
  `e` text GENERATED ALWAYS AS ((regexp_instr(`a`, _utf8mb4'^[1-9]d{9,29}$'))) VIRTUAL,
  PRIMARY KEY (`id`) /*T![clustered_index] CLUSTERED */
) ENGINE=InnoDB DEFAULT CHARSET=utf8mb4 COLLATE=utf8mb4_bin |

Versions of the cluster
You can reproduce it using tiup playground nightly --db 1 --kv 1 --tiflash 0 --ticdc 1 (upstream)
and tiup playground nightly --db 1 --kv 1 --tiflash 0 (downstream)

/severity Major

From v7.5, we can set corresponding sql_mode in changefeed config to avoid this problem.

This is related PR: https://github.com/pingcap/tiflow/pull/9941

Since there is a solution, I will close this issue now.


Implement brotli compression data-format for faster loading of websites.

References:

Introducing Brotli: a new compression algorithm for the internet  - Google OpenSource blog
http://google-opensource.blogspot.fr/2015/09/introducing-brotli-new-compression.html
Intent to Ship: Brotli (Accept-encoding: br on HTTPS connection) - Chromium mailing-list
https://groups.google.com/a/chromium.org/forum/#!searchin/blink-dev/brotli/blink-dev/JufzX024oy0/WEOGbN43AwAJ
Brotli IETF draft proposal
https://www.ietf.org/id/draft-alakuijala-brotli-08.txt
Brotli reference implementation by Google
https://github.com/google/brotli

Yeah, brotli looks cool. Waiting for a good Go library that implements brotli.

Going to mark this "good for newbies" since implementing an algorithm from spec is a great exercise for anyone, as long as you know Go.

I would like to work on this.

Awesome, let the author know and it looks like this would be a good place to start: https://github.com/dsnet/compress/blob/master/brotli/writer.go

Which author, @mholt ?

I mean @dsnet ;)

Hello.
The current state of my brotli package is that the Reader is 100% functional. There are still many performance tweaks to be made, but I am not aware of any bugs that make it non-compliant with the RFC draft. In fact, as I was implementing it a few months back, a few PRs were made to the draft to clarify certain points.
As for the Writer, there is still work to be done. I have completed an implementation of a bit writer and a entropy encoder. The major remaining piece, is writing a LZ77-style string matcher. For that reason, I'm actually currently working on finishing my own implementation of a RFC 1951 DEFLATE compressor. The components built to implement DEFLATE will make implementing Brotli significantly easier.
Given that I work on my compression library as a personal side project, I don't anticipate getting this all done for a few months. Follow the project for updates on progress. Also, I can ping this issue when the Writer is in a functional state.

Thank you for explanations @dsnet
Should we put this on hold @mholt?

Yeah, I guess. But at least now Joe knows there is great interest in his work - so please do let us know, Joe, when you're ready for others to help or use it.
Or if anyone finds another pure Go brotli package before then, we could look at that too.

I would like to see this included in caddy as well.

@dsnet By the way, I just realized I don't think I thanked you for chiming in a few months back. Thank you! :smile: Looking forward to your progress in the coming weeks/months. Looks like really great code so far.

I am not entirely sure this is the kind of thing you're looking for but:
https://github.com/Nelson69/izip/

No, unfortunately that package requires heavy amounts of cgo.

Gotcha-- well, I'll keep my eyes open :)

Anyone want to implement golang version of brotli from scratch?

out of curiosity, what is gained by purging one's go of cgo?
Pride?  performance?  Stability?
Thanks :)
Jacob Gadikian
E-mail<EMAIL_ADDRESS>SKYPE: faddat
Phone/SMS: +84<PHONE_NUMBER>
On Thu, Oct 13, 2016 at 12:21 AM, Mateusz Gajewski<EMAIL_ADDRESS>
wrote:

Anyone want to implement golang version of brotli from scratch?
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/mholt/caddy/issues/525#issuecomment-253279033, or mute
the thread
https://github.com/notifications/unsubscribe-auth/AGz6iTV8to4EllN8cVbxWpLS4v-HdqrKks5qzRcWgaJpZM4HJhl_
.

@faddat
It is incredibly hard to get cgo to work properly with stability on all platforms and across versions of Go. Even carefully reading the documentation, its easy to miss something. [0] [1] [2]
In my job, one of my tasks is to do the release of the next version of Go. Issues coming from cgo are probably among the most common failures (and also the most painful to debug). What worked in one version may not work in the next version because the cgo code made subtle assumptions about the runtime environment that happened to be true in one version, but not the next. After a release, it is common to see bug reports (some from popular projects) about cgo breaking after a release and IIRC a majority of them is due to faulty assumptions.
As an example of an upcoming change in Go1.8, SSA is getting smarter and no longer keeps variables live until the end of the function. This can cause failure in cgo when a pointer is passed to C, but ends up being the last reference of it. The GC may come and clear the backing memory. It is the programmer's responsibility to call runtime.KeepAlive to ensure that the variable is live in the duration of the cgo call (see golang/go#15843). Changes like this are not covered by the compatibility agreement.
Fundamentally, some packages must depend on cgo, but hopefully they have been battle tested by many users and carefully reviewed by experts.
(This isn't a smack on cgo, but to say that foreign function interfacing is always hard in any language)

Hi folks,
I found this package: https://github.com/kothar/brotli-go
Could it be usefull in Brotli implementation?

Hello @devil1591,
sorry but no :( -- We want to use clean/pure Go (see above)

Well, since a brotli reader has been implemented in pure Go, Caddy now serves up pre-compressed brotli (and gzip) files if they are on disk with a .br extension. This went out with 0.9.4. I still don't know of a brotli writer in pure Go and I'm not sure if we'd want that anyway since, AFAIK, brotli compresses way slower than gzip. So maybe what we've got for now is good enough. Thanks everyone! And especially thanks to @dsnet. Happy New Year.

Well, since a brotli reader has been implemented in pure Go, Caddy now serves up pre-compressed brotli (and gzip) files if they are on disk with a .br extension. This went out with 0.9.4. I still don't know of a brotli writer in pure Go and I'm not sure if we'd want that anyway since, AFAIK, brotli compresses way slower than gzip. So maybe what we've got for now is good enough. Thanks everyone! And especially thanks to @dsnet. Happy New Year.

Hi Matt, i'm not sure if it's the best choice to not look further into a pure go brotli writer. Akamai has written a nice article about brotli versus gzip. It seems brotli is only slower then gzip if you use them both with default settings. When using quality level 4 brotly is compresses 21% faster with 9% better compression on average. For more info please read: https://blogs.akamai.com/2016/02/understanding-brotlis-potential.html

@Bechrissed If you run caddy to serve static files you can always serve pre-compressed files (.br for brotly and .gz for gzip - brotli is preferred). If you proxy from caddy to other backends (fastcgi/proxy) you can always use brotli there with whatever implementation you would like. From my perspective - compressing files in the flight is bad solution and should be avoided.

Yes, that might be true. I'll look for a build solution. Thanks

I'm working on a fly package to generate the brotli compressed files. Will release when finished.

If you run something on backend that can brotli support (like nginx + ngx_brotli module) you can use caddy and caddy will send your Accept-Encoding header to backend. Backend will send compressed on-fly with brotli (content-encoding:br) and caddy will proxy it to you.
No need any support for this in proxy mode.

@wendigo

(.br for brotli and .gz for gzip - brotli is preferred if both are present)
why not to prefer the one with the smaller file size?

what about proxy mode? how will you check which is smaller? brotli is smaller in most cases so it should be prefered.

Yeah it would be cool to have brotli built-in support, at least as a plugin.

Hi is a pure Go encoder and decoder @mholt , https://github.com/andybalholm/brotli
Any way to implement that? I know your opinion about brotli, that sometimes it can be even slower, but maybe it's better to let user to choose?

Not really an opinion - the facts are pretty well covered further up the thread regarding speed, no need to rehash. We'd love to see a PR, but I suspect Matt will be too busy with Caddy 2 efforts to look into this himself.

Thanks @faradaytrs - will consider that. @whitestrake you are right, but I might as well look into putting it into Caddy 2

We added it to Caddy 2, but it's unbearably slow when used with network requests. Might not make it a standard module for now. (But, hey, Caddy 2 has a good zstandard encoder instead.)


Issue while creating projects

🐞 Bug report
I have created a project and having this issue
Command (mark with an x)

ng serve --open
Is this a regression?

 Yes, the previous version in which this bug was not present was: ....
Description
 A clear and concise description of the problem...
🔬 Minimal Reproduction

🔥 Exception or Error

C:\Users\Mohit\my-app> ng serve --open
'wmic.exe' is not recognized as an internal or external command,
operable program or batch file.
10% building 3/3 modules 0 activei ｢wds｣: Project is running at http://localhost:4200/webpack-dev-server/
i ｢wds｣: webpack output is served from /
i ｢wds｣: 404s will fallback to //index.html

chunk {main} main.js, main.js.map (main) 47.8 kB [initial] [rendered]
chunk {polyfills} polyfills.js, polyfills.js.map (polyfills) 264 kB [initial] [rendered]
chunk {runtime} runtime.js, runtime.js.map (runtime) 6.15 kB [entry] [rendered]
chunk {styles} styles.js, styles.js.map (styles) 9.7 kB [initial] [rendered]
chunk {vendor} vendor.js, vendor.js.map (vendor) 3.81 MB [initial] [rendered]
Date: 2019-09-10T07:10:15.255Z - Hash: 79fae9c4a87754da1a82 - Time: 10185ms
** Angular Live Development Server is listening on localhost:4200, open your browser on http://localhost:4200/ **
i ｢wdm｣: Compiled successfully.
events.js:174
      throw er; // Unhandled 'error' event
      ^

Error: spawn cmd ENOENT
    at Process.ChildProcess._handle.onexit (internal/child_process.js:240:19)
    at onErrorNT (internal/child_process.js:415:16)
    at process._tickCallback (internal/process/next_tick.js:63:19)
Emitted 'error' event at:
    at Process.ChildProcess._handle.onexit (internal/child_process.js:246:12)
    at onErrorNT (internal/child_process.js:415:16)
    at process._tickCallback (internal/process/next_tick.js:63:19)

C:\Users\Mohit\my-app> ng serve --open
'wmic.exe' is not recognized as an internal or external command,
operable program or batch file.
10% building 3/3 modules 0 activei ｢wds｣: Project is running at http://localhost:4200/webpack-dev-server/
i ｢wds｣: webpack output is served from /
i ｢wds｣: 404s will fallback to //index.html

chunk {main} main.js, main.js.map (main) 47.8 kB [initial] [rendered]
chunk {polyfills} polyfills.js, polyfills.js.map (polyfills) 264 kB [initial] [rendered]
chunk {runtime} runtime.js, runtime.js.map (runtime) 6.15 kB [entry] [rendered]
chunk {styles} styles.js, styles.js.map (styles) 9.7 kB [initial] [rendered]
chunk {vendor} vendor.js, vendor.js.map (vendor) 3.81 MB [initial] [rendered]
Date: 2019-09-10T07:15:25.702Z - Hash: 79fae9c4a87754da1a82 - Time: 6714ms
** Angular Live Development Server is listening on localhost:4200, open your browser on http://localhost:4200/ **
i ｢wdm｣: Compiled successfully.
events.js:174
      throw er; // Unhandled 'error' event
      ^

Error: spawn cmd ENOENT
    at Process.ChildProcess._handle.onexit (internal/child_process.js:240:19)
    at onErrorNT (internal/child_process.js:415:16)
    at process._tickCallback (internal/process/next_tick.js:63:19)
Emitted 'error' event at:
    at Process.ChildProcess._handle.onexit (internal/child_process.js:246:12)
    at onErrorNT (internal/child_process.js:415:16)
    at process._tickCallback (internal/process/next_tick.js:63:19)

🌍 Your Environment

Anything else relevant?

Hello, we reviewed this issue and determined that it doesn't fall into the bug report or feature request category. This issue tracker is not suitable for support requests, please repost your issue on StackOverflow using tag angular-cli.
If you are wondering why we don't resolve support issues via the issue tracker, please check out this explanation.
That said you can take a look at the following stackoverflow post https://superuser.com/questions/1178674/wmic-is-not-recognized-as-an-internal-or-external-command-operable-program-or


Change theme of experiment page

The experiment page has a greenish background which should be changed to match PSLab's theme.

I would like to solve this issue. Can I proceed?

@priyanshunayan Go ahead

@AakashMallik I have created a pull request. Please review it.

This issue should be closed now.


Port changes to fix index creation from devel to 3.3.

Cleanup and repair error handling in index creation in the cluster.

http://jenkins01.arangodb.biz:8080/view/PR/job/arangodb-matrix-pr/2205/


Add chat with seller button in the products cards

📘 Issue Description
Add a "Chat with Seller" Button (Design Only)
We want to introduce a button on the product page to allow users to start a chat with the seller. At this stage, the task focuses solely on the design aspect, with no functionality required.
Task Details:

Design a visually appealing and intuitive "Chat with Seller" button.
Ensure the button aligns with the overall marketplace style and theme.
The button should be responsive and accessible for all users.

Notes:

The focus is purely on the design; no backend or frontend logic needs to be implemented at this point.
Include the design in the appropriate section of the product page.

Feel free to explore creative options for the button while maintaining consistency with the existing UI!

Hello, can I work on this? @danielcdz
I have experience with UI/UX design.

Could I take over this issue?

May I be assigned to this?
Background and Relevant Experience
I’ve designed clean, responsive UI elements like buttons for various web platforms. My focus is on usability and visual appeal.
Plan for Tackling the Issue

Design a "Chat with Seller" button for the product page.
Ensure it aligns with the marketplace style and is responsive.
Focus on button design without backend functionality.

Hey! I’m Sttef and i have experience in front-end development, I own experience working with tools like figma and zeplin
I’m part of the Dojo Team ⛩
I would be happy to help and to be part of this one! I will create the button and ensure it matches the design perfectly! I will follow the steps mentioned to deliver what is needed!
Thank you!

Could I take over this issue?

I would like to work on this issue

Could I take on this issue?

Can I take care of this issue?
i'm a frontend dev and a blockchain dev kindly assign :)

Can I be assigned to this?

Step 1: Understand Design Context
I will analyze the existing UI/UX of the marketplace to understand the color palette, typography, button styles, and spacing conventions.
By examining the landing page and marketplace page layout, I’ll determine where the "Chat with Seller" button can be positioned effectively.
Step 2: Sketch the Button Design
I'll create a button design that matches the marketplace's style:
Shape: Rounded edges for a modern, approachable feel.
Icons: Optionally include a chat icon (e.g., speech bubble) for better intuitiveness.
Text: Use clear and concise text like "Chat with Seller".
Colors: Use primary or accent colors from the marketplace theme while maintaining readability and contrast.
Hover Effects: Add subtle effects like color changes or shadowing to make it interactive.
Step 3: Placement on Product Cards
I’ll position the button in a logical area on the product cards, such as:
Below the product details (e.g., name, price).
Near the "Buy Now" or "Add to Cart" buttons for logical flow.
The placement will respect spacing and avoid cluttering the card layout.
Step 4: Responsiveness and Accessibility
Responsiveness: Ensure the button adapts to various screen sizes:
Small screens: Center the button below product details.
Large screens: Align it to match the layout flow of product cards.
Accessibility: Add considerations for visually impaired users:
High contrast between text and background.
Focus states for keyboard navigation.
Step 5: Create the Design
Using tools like Figma or Adobe XD:
I’ll replicate the existing product card and add the new button design.
Ensure consistency in fonts, margins, and button styles.
Share a design mockup or prototype for review.

I'd like to take this issue.

Can I be assigned to this?  I am an experienced frontend developer with 3 years of experience.


pull request for e2e test at 11/06/2016 13:26:03

:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

optest/docs/updated_at.md
:white_check_mark:Succeeded

Details

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.


Fix issues with resources and args

Description of the change
Correction to issues related to how resources and arguments are injected

Resources are not defined by default. When they are along with an additional appConfig, a parsing error occurs due to the location within the Deployment template
Additional configurations are assumed to be located in the /app directory. Not all images containing backstage will have their installation directory in this location. This change makes the installDir configurable

Existing or Associated Issue(s)
Checklist

[x] Chart version bumped in Chart.yaml according to semver.
[x] Variables are documented in the values.yaml and added to the README.md. The helm-docs utility can be used to generate the necessary content. Use helm-docs --dry-run to preview the content.
[ ] JSON Schema generated.
[x] List tests pass for Chart using the Chart Testing tool and the ct lint command.

@sabre1041 you'll need to rebase this one

@sabre1041 this one seems to need a rebase. PTAL

@tumido @ChrisJBurns rebased as well as incorporated feedback from @jlmayorga.
Please take a look whenever you have a moment


[Event Request] Application “Tests-ERM”, Codeunit 135301 "O365 Sales Item Charge Tests"

[Event Request] Application “Tests-ERM”, Codeunit 135301 "O365 Sales Item Charge Tests"

Could you please insert the OnTestInitialize Event at the beginning of procedure Initialize?

Thanks for reporting this. We agree, and we’ll publish a fix asap, either in an update for the current version or in the next major release. We will update this issue with information about availability.


Remove needs clause from build.yml

Pre-review checklist

[ ] I've confirmed that instructions included in README.md are still correct after my changes in the codebase.
[ ] I've added or updated automated unit tests to verify correctness of my new code.
[ ] I've added or updated integration tests to verify correctness of my new code.
[ ] I've confirmed that my changes are working by executing CLI's commands manually.
[ ] I've confirmed that my changes are up-to-date with the target branch.
[ ] I've described my changes in the release notes.
[ ] I've described my changes in the section below.

Changes description
The needs does not work across different workflows. This is probably a leftover from early CI split.

What problems did it cause?


authenticate does not work

authenticate method is not working. There doesn't seem to be a testcase for authenticate.

Hi @beders,
I'm using Resty 0.3.1, and I can't seem to get HTTP Basic Authentication to work. I receive an error when I use the json() method. Here is the stack trace:

java.lang.NullPointerException
at us.monoid.web.auth.RestyAuthenticator.getPasswordAuthentication(RestyAuthenticator.java:30)
at java.net.Authenticator.requestPasswordAuthentication(Authenticator.java:162)
at org.apache.harmony.luni.internal.net.www.protocol.http.HttpURLConnectionImpl.getAuthorizationCredentials(HttpURLConnectionImpl.java:1182)
at org.apache.harmony.luni.internal.net.www.protocol.http.HttpURLConnectionImpl.processAuthHeader(HttpURLConnectionImpl.java:1155)
at org.apache.harmony.luni.internal.net.www.protocol.http.HttpURLConnectionImpl.processResponseHeaders(HttpURLConnectionImpl.java:1095)
at org.apache.harmony.luni.internal.net.www.protocol.http.HttpURLConnectionImpl.retrieveResponse(HttpURLConnectionImpl.java:1048)
at org.apache.harmony.luni.internal.net.www.protocol.http.HttpURLConnectionImpl.getInputStream(HttpURLConnectionImpl.java:512)
at us.monoid.web.AbstractResource.fill(AbstractResource.java:34)
at us.monoid.web.Resty.fillResourceFromURL(Resty.java:417)
at us.monoid.web.Resty.doGET(Resty.java:373)
at us.monoid.web.Resty.json(Resty.java:189)
at us.monoid.web.Resty.json(Resty.java:177)
...

I'm new to Java, so I could be completely wrong, but I noticed that there's a reference to the method getRequestingURL(), but it's not defined anywhere else in the code:
https://github.com/beders/Resty/blob/master/src/main/java/us/monoid/web/auth/RestyAuthenticator.java#L28
To work around this bug, I'm using the alwaysSend() method instead, performing the Base64 encoding myself, like so:
Resty resty = new Resty();
String encodedString = Base64.encodeToString((username + ":" + password).getBytes("UTF-8"), android.util.Base64.DEFAULT);
resty.alwaysSend("Authorization", "Basic " + encodedString);

Object name = resty.json(baseURI + "/users/new").get("user.firstName");
System.out.println(name);

Thanks for this library!

Thank you for trying Resty.
The problem is that sometimes the request URL for an authentication is null, which is unexpected.
I need to work around this issue somehow.
Thank you so much for sharing your work-around!
Cheers,
Jochen
On Feb 27, 2012, at 1:54 PM, Todd Mazierski wrote:

Hi @beders,
I'm using Resty 0.3.1, and I can't seem to get HTTP Basic Authentication to work. I receive an error when I use the json() method. Here is the stack trace:

java.lang.NullPointerException
at us.monoid.web.auth.RestyAuthenticator.getPasswordAuthentication(RestyAuthenticator.java:30)
at java.net.Authenticator.requestPasswordAuthentication(Authenticator.java:162)
at org.apache.harmony.luni.internal.net.www.protocol.http.HttpURLConnectionImpl.getAuthorizationCredentials(HttpURLConnectionImpl.java:1182)
at org.apache.harmony.luni.internal.net.www.protocol.http.HttpURLConnectionImpl.processAuthHeader(HttpURLConnectionImpl.java:1155)
at org.apache.harmony.luni.internal.net.www.protocol.http.HttpURLConnectionImpl.processResponseHeaders(HttpURLConnectionImpl.java:1095)
at org.apache.harmony.luni.internal.net.www.protocol.http.HttpURLConnectionImpl.retrieveResponse(HttpURLConnectionImpl.java:1048)
at org.apache.harmony.luni.internal.net.www.protocol.http.HttpURLConnectionImpl.getInputStream(HttpURLConnectionImpl.java:512)
at us.monoid.web.AbstractResource.fill(AbstractResource.java:34)
at us.monoid.web.Resty.fillResourceFromURL(Resty.java:417)
at us.monoid.web.Resty.doGET(Resty.java:373)
at us.monoid.web.Resty.json(Resty.java:189)
at us.monoid.web.Resty.json(Resty.java:177)
...

I'm new to Java, so I could be completely wrong, but I noticed that there's a reference to the method getRequestingURL(), but it's not defined anywhere else in the code:
https://github.com/beders/Resty/blob/master/src/main/java/us/monoid/web/auth/RestyAuthenticator.java#L28
To work around this bug, I'm using the alwaysSend() method instead, performing the Base64 encoding myself, like so:
Resty resty = new Resty();
String encodedString = Base64.encodeToString((username + ":" + password).getBytes("UTF-8"), android.util.Base64.DEFAULT);
resty.alwaysSend("Authorization", "Basic " + encodedString);

Object name = resty.json(baseURI + "/users/new").get("user.firstName");
System.out.println(name);

Thanks for this library!

Reply to this email directly or view it on GitHub:
https://github.com/beders/Resty/issues/7#issuecomment-4204004

Todd, what version of Java are you using?

org.apache.harmony.luni.internal.net.www.protocol.http.HttpURLConnectionImpl.getAuthorizationCredentials(
is not a Sun Java class.
I suspect we are dealing with a compatibility problem here and the requestingURL of the Authenticator class I'm using is not set up correctly by the harmony implementation.

On Feb 27, 2012, at 1:54 PM, Todd Mazierski wrote:

Hi @beders,
I'm using Resty 0.3.1, and I can't seem to get HTTP Basic Authentication to work. I receive an error when I use the json() method. Here is the stack trace:

java.lang.NullPointerException
at us.monoid.web.auth.RestyAuthenticator.getPasswordAuthentication(RestyAuthenticator.java:30)
at java.net.Authenticator.requestPasswordAuthentication(Authenticator.java:162)
at org.apache.harmony.luni.internal.net.www.protocol.http.HttpURLConnectionImpl.getAuthorizationCredentials(HttpURLConnectionImpl.java:1182)
at org.apache.harmony.luni.internal.net.www.protocol.http.HttpURLConnectionImpl.processAuthHeader(HttpURLConnectionImpl.java:1155)
at org.apache.harmony.luni.internal.net.www.protocol.http.HttpURLConnectionImpl.processResponseHeaders(HttpURLConnectionImpl.java:1095)
at org.apache.harmony.luni.internal.net.www.protocol.http.HttpURLConnectionImpl.retrieveResponse(HttpURLConnectionImpl.java:1048)
at org.apache.harmony.luni.internal.net.www.protocol.http.HttpURLConnectionImpl.getInputStream(HttpURLConnectionImpl.java:512)
at us.monoid.web.AbstractResource.fill(AbstractResource.java:34)
at us.monoid.web.Resty.fillResourceFromURL(Resty.java:417)
at us.monoid.web.Resty.doGET(Resty.java:373)
at us.monoid.web.Resty.json(Resty.java:189)
at us.monoid.web.Resty.json(Resty.java:177)
...

I'm new to Java, so I could be completely wrong, but I noticed that there's a reference to the method getRequestingURL(), but it's not defined anywhere else in the code:
https://github.com/beders/Resty/blob/master/src/main/java/us/monoid/web/auth/RestyAuthenticator.java#L28
To work around this bug, I'm using the alwaysSend() method instead, performing the Base64 encoding myself, like so:
Resty resty = new Resty();
String encodedString = Base64.encodeToString((username + ":" + password).getBytes("UTF-8"), android.util.Base64.DEFAULT);
resty.alwaysSend("Authorization", "Basic " + encodedString);

Object name = resty.json(baseURI + "/users/new").get("user.firstName");
System.out.println(name);

Thanks for this library!

Reply to this email directly or view it on GitHub:
https://github.com/beders/Resty/issues/7#issuecomment-4204004

The current head version has a new call Resty.authenticateForRealm
which allows you to set login/password for the HTTP realm send by the server.
(The realm can be found in header WWW-Authenticate)
On Feb 27, 2012, at 1:54 PM, Todd Mazierski wrote:

Hi @beders,
I'm using Resty 0.3.1, and I can't seem to get HTTP Basic Authentication to work. I receive an error when I use the json() method. Here is the stack trace:

java.lang.NullPointerException
at us.monoid.web.auth.RestyAuthenticator.getPasswordAuthentication(RestyAuthenticator.java:30)
at java.net.Authenticator.requestPasswordAuthentication(Authenticator.java:162)
at org.apache.harmony.luni.internal.net.www.protocol.http.HttpURLConnectionImpl.getAuthorizationCredentials(HttpURLConnectionImpl.java:1182)
at org.apache.harmony.luni.internal.net.www.protocol.http.HttpURLConnectionImpl.processAuthHeader(HttpURLConnectionImpl.java:1155)
at org.apache.harmony.luni.internal.net.www.protocol.http.HttpURLConnectionImpl.processResponseHeaders(HttpURLConnectionImpl.java:1095)
at org.apache.harmony.luni.internal.net.www.protocol.http.HttpURLConnectionImpl.retrieveResponse(HttpURLConnectionImpl.java:1048)
at org.apache.harmony.luni.internal.net.www.protocol.http.HttpURLConnectionImpl.getInputStream(HttpURLConnectionImpl.java:512)
at us.monoid.web.AbstractResource.fill(AbstractResource.java:34)
at us.monoid.web.Resty.fillResourceFromURL(Resty.java:417)
at us.monoid.web.Resty.doGET(Resty.java:373)
at us.monoid.web.Resty.json(Resty.java:189)
at us.monoid.web.Resty.json(Resty.java:177)
...

I'm new to Java, so I could be completely wrong, but I noticed that there's a reference to the method getRequestingURL(), but it's not defined anywhere else in the code:
https://github.com/beders/Resty/blob/master/src/main/java/us/monoid/web/auth/RestyAuthenticator.java#L28
To work around this bug, I'm using the alwaysSend() method instead, performing the Base64 encoding myself, like so:
Resty resty = new Resty();
String encodedString = Base64.encodeToString((username + ":" + password).getBytes("UTF-8"), android.util.Base64.DEFAULT);
resty.alwaysSend("Authorization", "Basic " + encodedString);

Object name = resty.json(baseURI + "/users/new").get("user.firstName");
System.out.println(name);

Thanks for this library!

Reply to this email directly or view it on GitHub:
https://github.com/beders/Resty/issues/7#issuecomment-4204004

Seeing this issue as well, appears that not authentication is being attempted.


Revert "Ubuntu oval rewrite"

Reverts nexB/vulnerablecode#188

Closed because it was not based on my branch


candle number in get_product_historic_rates

Hi,
On gdax api document, it says" If data points are readily available, your response may contain as many as 350 candles and some of those candles may precede your declared start value." However, recently I noticed the function only retrieved ~300 candles, does anyone know the reason? thanks.

"as many as", so there is no guarantee they will respond with 350 candles.

this seems to be resolved. please open a new issue if this persists.


Help

How do I install this? Your website is down and I can't find any installation instructions.

Hey, sorry, DNS issue.
I'm currently at the airport waiting to board a flight, but I think it should be resolved by the time I land. If it isn't, I'll take another look.
Sorry about that.

Looks like it's been resolved, feel free to re-open the issue if you continue to experience problems.


Ensure new components config is always acted upon

@bratseth please review.

The change is just to inline the getOptionalConfigs and keep the knowledge that there was a new components config that we should possibly return, unless bootstrap configs have changed, in which case we'll be called again with a new components subscriber, with generation -1.

@gjoranv FYI, or review if you wish.

Superseded by #20821


Incorrect parsing of commands with duplicate words

Not sure if it is the desired behavior,
I tried doing (just an example)
tool folder ls
I want this command to list all folders in my db.
tools folder ext ls <folder_id>
I want to list all extensions of files in that folder.
The second command basically returns me the output of first command followed by second command.

Hi @chakshuahuja, could you provide some more details?


[JavaFX-Part2] Add UI screenshot to introduce different components of UI

Current:
Uses a tree diagram to show the various nodes of the UI

Problem:
Does not reflect how this structure renders on the actual UI. May not be directly and immediately understandable.
Proposed:
Add a screenshot of the UI and label each component. Show the inclusion logic with the label.

@laney0808 Seems like a good suggestion. Go ahead and send a PR for this.


the status of grpc php client

hi
i want to ask is any companies use in online env? and standard
usage in distributed system。

I think the most important feature it lacks as a RPC client is persistent connection.
I have a golang-backend service, which is ~20k qps under benchmark.
However,  the php client has 0.5% chance to  connect unavailable when  qps > 1k, through ELB 4 layer loadbalancer.
I tried to use client-side round-robin LB without ELB using 1.2.0.
However, it doesn't work perfect.
It connects to all endpoints every times, and has a great chance to choose same server.
Php is supposed to be in a stateless mode. We cannot save state in application-level, and only extension can do it, just like yar does.
The grpc generated client has third option to pass channel,  but it only works to do multi RPCs during a request.
Is my understanding correct? I'll be surprised and happy to embrace it if you could tell me a way, @stanley-cheung & @nathanielmanistaatgoogle . Thanks!

By the way, HTTP2 direct connection has much more overhead than HTTP/1.1.
It starts with a connection preface, two settings frame, and two settings ACK.
I think grpc-gateway may help to go with the old-good HTTP/1.1, which is on my todo list.

FWIW, for simpler APIs like logging, I'm trying to solve the similar problem by running an external daemon.
The source code is available at:
https://github.com/GoogleCloudPlatform/google-cloud-php/tree/batch/src/Core/Batch
You can run PHP daemon program that creates a client object at startup, and in your client code, just pass operations to the daemon.
Just an idea.

Just a heads up the code linked above has since been merged and can now be found here:
https://github.com/GoogleCloudPlatform/google-cloud-php/tree/v0.34.1/src/Core/Batch

Closing this issue. The grpc extension by default creates persistent connections since 1.6.0 release.


Larger test data files

When trying to start a test with a ~1M test data (CSV) file, I've noticed that Kangal silently rejects the test. There is an error message printed to the controller logs, but the POST request yields a 201 response and the error can only be externally detected by examining the response to a succeeding GET to /load-test/:test_name and noticing that it does not include a test name.
Besides warning that some kind of error message should be returned to the end user, I'd like to start a discussion here: do we see that test data size should be limited? It can be argued that we don't need a lot of test data since most load testing can be done by just repeating requests. On the other hand, there are very legitimate use cases for large data sets in a load test scenario like cache busting.

Hey @thiagoarrais, thanks for reporting.
Kangal stores test data on a Kubernetes ConfigMap and there is a 1MB limit on those resources.

A ConfigMap is not designed to hold large chunks of data. The data stored in a ConfigMap cannot exceed 1 MiB. If you need to store settings that are larger than this limit, you may want to consider mounting a volume or use a separate database or file service.

https://kubernetes.io/docs/concepts/configuration/configmap/
So there is not much to be done unless change the whole approach to use Volumes instead.
But we could improve the experience a bit and fail fast in case of the file exceeds the size.

I see. Would kangal be willing to accept a PR that moves the data to Volumes then?

Definitely @thiagoarrais,
If you prefer, you can propose the solution first and then we can discuss it.
I think the main question is, where those files will be stored?
Proxy already has S3 integration, so we could rely on this maybe.

Another idea that I'm working on: convert the csv to a gzip 64 file and convert back using an init container.


Closing health data window leaves link reference "floating"

Hi.
I just open Brackets, closed the heath data window information, open two files in split vertical view and I found the link of Health Data is still working, but invisible.  I'm attaching an image where you can view this behavior.

At the right you can find the link (I put my mouse over that space that has nothing).
Regards
Hernán

By the way, it happens on Ubuntu 14.04 LTS running on VMware.

I closed the application (Brackets) and opened it again and now the Health Data window doesn't show, neither the "invisible link".

This could be focus issue; i have seen similar issues in google chrome browser.
When you switch out to another application and come back to brackets does the tooltip disappear?


The build was falling after the build engine has been upgraded D8

Gradle log:
AGPBI: {"kind":"error","text":"Static interface methods are only supported starting with Android N (--min-api 24): okhttp3.Request okhttp3.Authenticator.lambda$static$0(okhttp3.Route, okhttp3.Response)","sources":[{}],"tool":"D8"}
AGPBI: {"kind":"error","text":"Static interface methods are only supported starting with Android N (--min-api 24): okhttp3.Request okhttp3.Authenticator.lambda$static$0(okhttp3.Route, okhttp3.Response)","sources":[{}],"tool":"D8"}

> Task :ui:mergeExtDexDevelopmentDebug FAILED

FAILURE: Build failed with an exception.

* What went wrong:
Could not resolve all files for configuration ':ui:developmentDebugRuntimeClasspath'.
> Failed to transform file 'jetified-okhttp-3.14.0.jar' to match attributes {artifactType=android-dex, dexing-is-debuggable=true, dexing-min-sdk=21} using transform DexingTransform
   > Error while dexing.
> Failed to transform file 'jetified-okhttp-3.14.0.jar' to match attributes {artifactType=android-dex, dexing-is-debuggable=true, dexing-min-sdk=21} using transform DexingTransform
   > Error while dexing

The issue has been fixed.


Simple-JNDI alongside Tomcat 8

I'm trying to use Simple-JNDI with Tomcat 8 so I can use a different connection pool with Eclipselink (JPA) without having to configure the JNDI resource in Tomcat itself.
This answer on stackoverflow indicates that it was working with Tomcat 6 at least: https://stackoverflow.com/a/13936449/3375325
I'd like to use HikariCP instead of Eclipselink's internal connection pooling, so what I do is create a HikariDataSource and try to bind it to a name, e.g. jdbc/OracleHikariDatasource in my WebListener's contextInitialized method. Unfortunately it already fails when calling new InitialContext() with the following RuntimeException:
java.lang.RuntimeException: Illegal node/branch clash. At branch value 'Property' an Object was found: [TEST, /logfiles/TEST/webapp]
    at org.osjava.sj.loader.JndiLoader.createSubContexts(JndiLoader.java:310) ~[simple-jndi-0.14.0.jar:?]
    at org.osjava.sj.loader.JndiLoader.jndiPut(JndiLoader.java:290) ~[simple-jndi-0.14.0.jar:?]
    at org.osjava.sj.loader.JndiLoader.load(JndiLoader.java:223) ~[simple-jndi-0.14.0.jar:?]
    at org.osjava.sj.loader.JndiLoader.loadDirectory(JndiLoader.java:125) ~[simple-jndi-0.14.0.jar:?]
    at org.osjava.sj.loader.JndiLoader.loadDirectory(JndiLoader.java:82) ~[simple-jndi-0.14.0.jar:?]
    at org.osjava.sj.SimpleJndi.loadRoot(SimpleJndi.java:78) ~[simple-jndi-0.14.0.jar:?]
    at org.osjava.sj.SimpleContextFactory.getInitialContext(SimpleContextFactory.java:72) ~[simple-jndi-0.14.0.jar:?]
    at javax.naming.spi.NamingManager.getInitialContext(NamingManager.java:684) ~[?:1.8.0_131]
    at javax.naming.InitialContext.getDefaultInitCtx(InitialContext.java:313) ~[?:1.8.0_131]
    at javax.naming.InitialContext.init(InitialContext.java:244) ~[?:1.8.0_131]
    at javax.naming.InitialContext.<init>(InitialContext.java:192) ~[?:1.8.0_131]
    [...]

The mentioned directory is where log4j2 places the log files of my web application.
jndi.properties (placed under src/main/resources)
java.naming.factory.initial=org.osjava.sj.SimpleContextFactory
org.osjava.sj.root=conf/

WebListener
    @Override
    public synchronized void contextInitialized(ServletContextEvent event) {
        System.setProperty(Context.INITIAL_CONTEXT_FACTORY, "org.osjava.sj.SimpleContextFactory");

        try {
            Configuration config = new Configuration();
            Context ctx = new InitialContext();
            ctx.bind("jdbc/OracleHikariDatasource", config.getDataSource());
        } catch (NamingException | SQLException | RuntimeException ex) {
            log.error(ex.getMessage(), ex);
        }
    }

Is this supposed to work? Am I doing something wrong?

With "org.osjava.sj.root=conf/" Simple-JNDI scans all files and directories in "conf" and creates contexts according their names and keys, they contain. So it is easy to run into name collisions. In your case it looks like there is already an object bound to the name "Property", when trying to bound another one to the same name.
I would suggest to change "conf" to a directory exlusively owned by Simple-JNDI and putting your DataSource definition file there. Or you can load the file directly. See https://github.com/h-thurow/Simple-JNDI/wiki/Load-property-files-with-any-extension-from-any-location-(New-in-0.13.0) .

That was it! Other files in the conf directory got in the way. Thank you very much!


Provide spec proposal templates

@mujx pointed out that having a consistent starting point for spec proposals would be useful.  @benparsons perhaps you can find some commonality out of the ones we have atm (erik's Groups one might be a good bet?) to provide a potential starting point?

I have noted:

Problem/Background
Proposal
Tradeoffs
Issues
Conclusion

These could all be optional.

The template mentioned above seems to be linked in the proposals introduction. Is there something else people had in mind before closing this?

I think that was it - can close.


whatsapp-web cli starts Chrome and – after phone conn. – crashes it

I have to reopen this issue, as with a new version of Chrome (Version 64.0.3282.186 (official build) (64-Bit)) and the appropriate chromedriver version (ChromeDriver 2.35) whatsapp-web cli crashes after taking these steps:
iMac:whatsapp-web _username_$ python chat.py _WhatsappUser_

(Google Chrome is started, loggin into whatsapp-web capturing the code on the Webpage /w my smartphone)

my Terminal asks: Phone connected? y/n:

As soon as I type in 'y', Google Chrome crashes and I get this error message:

Message: no such element: Unable to locate element: {"method":"xpath","selector":"//*[@id="main"]/header//div[contains(@Class, "chat-main")]"}
    (Session info: chrome=64.0.3282.186)
    (Driver info: chromedriver=2.35.528157 (4429ca2590d6988c0745c24c8858745aaaec01ef),platform=Mac OS X 10.11.6 x86_64)

    Chromedriver Error. Read the above error (if any), then
    Check if installed chromedriver version is compatible with installed Chrome vesion.

The path in chat.py which points to the location of the chromedriver binary file is correct, although the installed versions of python and selenium differ:
Python 3.6.4
selenium 3.4.0 (which is the selenium version which gets installed after using the pip install command)
Maybe you can help me out again? Thank you in advance!

I'm having the same problem.
:/

Working on a fix. Should be up by the weekend
On Mar 8, 2018 23:38, "Ítalo Fernandes"<EMAIL_ADDRESS>wrote:

I'm having the same problem.
:/
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/zvovov/whatsapp-web/issues/14#issuecomment-371572985,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AIOr2tNS8IW12eZ_p5xr9lJ42MX251z5ks5tcXOogaJpZM4SaAGs
.

Whatsapp changed some DOM elements on their website. Should be fixed now.

Still not getting it to start up, I am getting the following error (after reinstalling chromedriver using homebrew, setting the PATH of chromedriver (usr/local/bin/chromedriver), and editing the path in chat.py):
`Message: 'chromedriver' executable needs to be in PATH. Please see https://sites.google.com/a/chromium.org/chromedriver/home
Chromedriver Error. Read the above error (if any), then
Check if installed chromedriver version is compatible with installed Chrome version.`

Maybe I did not set the path/to/chromedriver right in chat.py? Below is my try, maybe you can point me to what I did wrong (I am a python noob, btw):
`config = {
'chromedriver_path': "{0}usr/local/bin/chromedriver".format(os.environ['HOME']),
'chromedriver_path': "usr/local/bin/chromedriver".format(os.environ['HOME']),`

Finally got it running. To some extent, at least.

Found out that homebrew does not install chromedriver at the path I set, but places a symbolic link instead (MacOS), so I just changed the path to chromedriver in chat.py accordingly.

Had to update chromedriver manually to 2.38 (homebrew is still residing at 2.37) to prevent the crash described  here: https://github.com/zvovov/whatsapp-web/issues/14#issue-301791220

Still I get an error after trying to send the first message after the prompt "Phone connected? y/n, as follows:
Exception in thread Thread-1: Traceback (most recent call last):   File "/opt/local/Library/Frameworks/Python.framework/Versions/3.6/lib/python3.6/threading.py", line 916, in _bootstrap_inner     self.run()   File "/opt/local/Library/Frameworks/Python.framework/Versions/3.6/lib/python3.6/threading.py", line 864, in run     self._target(*self._args, **self._kwargs)   File "chat.py", line 119, in startGetMsg     incoming_scheduler.run()   File "/opt/local/Library/Frameworks/Python.framework/Versions/3.6/lib/python3.6/sched.py", line 154, in run     action(*argument, **kwargs)   File "chat.py", line 138, in getMsg     if first_msg: # if one or more messages exist UnboundLocalError: local variable 'first_msg' referenced before assignment


falco-edits

may grammaratically errors are corrected.

What type of PR is this?

Uncomment one (or more) /kind <> lines:

/kind bug

/kind cleanup

/kind design

/kind documentation

/kind failing-test

/kind feature

/kind flaky-test

If contributing rules or changes to rules, please make sure to also uncomment one of the following line:

/kind rule-update

/kind rule-create

Any specific area of the project related to this PR?

Uncomment one (or more) /area <> lines:

/area build

/area engine

/area examples

/area rules

/area integrations

/area tests

/area proposals

What this PR does / why we need it:
Which issue(s) this PR fixes:

Fixes #
Special notes for your reviewer:
Does this PR introduce a user-facing change?:

@ankitasharma88990: Adding the "do-not-merge/release-note-label-needed" label because no release-note block was detected, please follow our release note process to remove it.

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Thanks for your pull request. Before we can look at it, you'll need to add a 'DCO signoff' to your commits.
:memo: Please follow instructions in the contributing guide to update your commits with the DCO
Full details of the Developer Certificate of Origin can be found at developercertificate.org.
The list of commits missing DCO signoff:

a7bb2c6 falco-edits

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

Welcome @ankitasharma88990! It looks like this is your first PR to falcosecurity/falco 🎉

[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by:
To fully approve this pull request, please assign additional approvers.
We suggest the following additional approver: mstemm
If they are not already assigned, you can assign the PR to them by writing /assign @mstemm in a comment when ready.
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Please accept as it's the end of hacktoberfest.
Thank you.

[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by:
To fully approve this pull request, please assign additional approvers.
We suggest the following additional approver: leodido
If they are not already assigned, you can assign the PR to them by writing /assign @leodido in a comment when ready.
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@koppor: changing LGTM is restricted to assignees, and only falcosecurity/falco repo collaborators may be assigned issues.

In response to this:

The text of the Apache license must not be changed.

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Going to close this since it is huge and it seems to been done with automatic tools not accounting for specific situations.
/close


Update first_steps.md

Inconsistent port number used in code and prose, so the example doesn't work.

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.


fix(mysqld_exporter): Change condition for mysqld_exporter_host check

Modify the condition for mysqld_exporter_host in the mysqld_exporter my_cnf.j2 template to address an issue where mysqld_exporter_host: null in roles/defaults/main.yml was not being handled correctly. The updated condition ensures the host setting logic operates properly even when mysqld_exporter_host is set to null.
I also think a useful approach would be to simply remove mysqld_exporter_host[port] from defaults/main.yml and not change the template condition. I would appreciate your comments on this.

Good catch, thanks!

I also think a useful approach would be to simply remove mysqld_exporter_host[port] from defaults/main.yml and not change the template condition. I would appreciate your comments on this.

That's up for debate and it's actually a part of a larger discussion.
It's been standard practice in ansible roles that the defaults have served the purpose of giving a overview the variables that users can override. But as we recently introduced the argument spec validation of the roles which serves the same purpose (and is actually used to generate the docs) then perhaps it's ok to remove this variable and other null value ones from the defaults.

Thank you for merging and explaining the background.


Bug

Bug Description

Steps to Reproduce

Expected Behavior

Actual Behavior

Screenshots

Device Information

Device Model:
Android Version:
App Version:

Additional Context

Error Log

Paste your logs here

Checklist

[x] I have checked for similar issues
[x] I am using the latest version of the app
[x] I can consistently reproduce this issue
[x] I have included all the required information above

Related Permissions

[x] Internet
[x] Access Network State
[x] Install Packages
[x] Delete Packages
[x] Query Packages
[x] Notifications
[x] Boot Completed

H


Handle schema branches for all sources rather than just Kafka

Created a SAM app and added HDFS source
Entered schema name and selected version "1" and saved (the output fields are populated)
Edit the source again.

The schema version is missing in the component dialog. See screenshot.

Cluster: http://ctr-e138-1518143905142-85179-01-000002.hwx.site:8080/api/v1/clusters/cl1
Schema registry url: http://hdf-3-1-release3.field.hortonworks.com:7788/

Now when I try the schema never shows up. In the backend i see a request with schema name "undefined".

https://github.com/hortonworks/streamline/pull/1243

@shahsank3t @joylyn
While handling ui changes in https://github.com/hortonworks/streamline/pull/1204/files  for backend changes in https://github.com/hortonworks/streamline/pull/1200 it seems that we missed a few things.
Can we fix the below?

It seems that default value of MASTER for schema branch is hardcoded for field name. Quoting an example for source at https://github.com/hortonworks/streamline/pull/1204/files#diff-700814ca73bcf79d2404b6826901cebfR115 Ditto for sink. Can we change the logic in that if clause such that we use hint instead of fieldName? So, if there are any fields for that source/sink that have a hint of schemaBranch and if they dont have a value then we assign the default value of master.
The logic for getting all branches for a schema also seems to be hard coded just for Kafka. https://github.com/hortonworks/streamline/pull/1204/files#diff-700814ca73bcf79d2404b6826901cebfR145 ditto for sink. That is making all other sources fail. I dont see a call being made to fetch branches for other sources like hdfs, eventhub, etc after applying json file changes in this PR. Can we change that logic instead to use the hints schemaBranch and dependsOn- to make it generic and work for all ?

In general if you guys come across any UI api calls that are hardcoded using field names, please change it to use hints as well, unless its a special case.
@arunmahadevan The changes I have pushed in this PR are necessary and will not break anything. However they are not sufficient and we need UI fixes as mentioned above as well to fix this issue.

Thanks @priyank5485 , @sameer79 for the patch, merged to master.


error on dynamic table refresh during

Terraform CLI and Provider Versions
Terraform v1.5.5
on darwin_arm64
Provider version 0.85.0
Terraform Configuration
resource "snowflake_dynamic_table" "dynamic_table" {
  provider   = snowflake.account_admin
  for_each   = var.dynamic_tables
  database   = var.snowflake_database_name
  warehouse  = var.snowflake_warehouse_name
  schema     = snowflake_schema.collection.name
  name       = each.value.name
  comment    = each.value.name
  or_replace = true
  query      = templatefile("${path.module}/${each.value.sql}", { DB = var.snowflake_database_name, SCHEMA = snowflake_schema.collection.name, IP_INFO_PRIVATE_SHARING = var.ip_info_private_sharing })
  target_lag {
    maximum_duration = var.env == "ci" || var.env == "dev" ? "1 minute" : each.value.target_lag
  }
}

Expected Behavior
expected terraform to be applied
Actual Behavior
Error: too many matches found. There is no way of getting ONLY the 'query' used to create the dynamic table from Snowflake. We try to get it from the whole creation statement but there may be cases where it fails. Please submit the issue on Github (refer to #2329)
#2329
Steps to Reproduce

terraform apply

How much impact is this issue causing?
High
Logs
No response
Additional Information
No response

Hey @freylafert. Thanks for reaching out to us.
Can you share the query you want to run? I suspect that it has multiple SELECT AS in it. This is the limitation in the current provider version which is caused by how Snowflake returns the query. You can check more details in #2329.
There is also an open PR #2438 that will try to solve such problems. We should be able to release it as a part of v0.86.0 (this Wednesday/Thursday).

Yes, we have statements like this in the query:
WITH unique_accounts_per_day_on_ip AS

Great, then it will be a good test for the change from #2438 (please check it, after we release v0.86.0.

Hey @freylafert. We have released 0.86.0 yesterday. Could you check if this solves your issue, please?

Yes, the issue was resolved, closing the ticket.


feat(xds): add flags to set xds client metadata

Issues associated with this PR
issue # 951
Solutions
add new flags to set xds client metadata
Code Style

Show Golint result

➜  mosn git:(trainyao/xds_metadata_flag) ✗ golint cmd/mosn/main/control.go
➜  mosn git:(trainyao/xds_metadata_flag) ✗

Codecov Report

Merging #952 into master will decrease coverage by 0.11%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master     #952      +/-   ##
==========================================
- Coverage   55.66%   55.55%   -0.12%
==========================================
  Files         237      237
  Lines       23881    23881
==========================================
- Hits        13294    13266      -28
- Misses       9381     9401      +20
- Partials     1206     1214       +8

Impacted Files
Coverage Δ

pkg/stream/stream.go
46.66% <0%> (-13.34%)
:arrow_down:

pkg/log/logger.go
56.14% <0%> (-1.61%)
:arrow_down:

pkg/module/http2/transport.go
78.55% <0%> (-0.73%)
:arrow_down:

pkg/module/http2/server.go
81.55% <0%> (-0.52%)
:arrow_down:

pkg/network/connection.go
33.39% <0%> (-0.37%)
:arrow_down:

pkg/module/http2/frame.go
84.17% <0%> (-0.31%)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2f21695...d6c5ce9. Read the comment docs.

@trainyao could you add some unit test cases for it, thx.
BTW Currently MOSN does not support Metadata in the cluster returned by pilot.

@trainyao could you add some unit test cases for it, thx.
BTW Currently MOSN does not support Metadata in the cluster returned by pilot.

ok i'll add some unit test.
and this PR is not about to handle the metadata of cluster returned, but to set the globalXdsInfo of the ads xdsclient in order to request cluster info from xds server, maybe the PR title/content make misunderstanding.

@trainyao could you add some unit test cases for it, thx.
BTW Currently MOSN does not support Metadata in the cluster returned by pilot.

ok i'll add some unit test.
and this PR is not about to handle the metadata of cluster returned, but to set the globalXdsInfo of the ads xdsclient in order to request cluster info from xds server, maybe the PR title/content make misunderstanding.

@trainyao could you add some unit test cases for it, thx.
BTW Currently MOSN does not support Metadata in the cluster returned by pilot.

how should i add test cases in this scene? should i start a xds server to connet with mosn?

@trainyao could you add some unit test cases for it, thx.
BTW Currently MOSN does not support Metadata in the cluster returned by pilot.

how should i add test cases in this scene? should i start a xds server to connet with mosn?
the unit test coverage decrement seems to be due to a wrong master branch picking, the decreasing module i didn't edit any code of it.
i have already rebase to the right master branch and repush PR.

You can add unit test cases for initXdsFlags to verify that serviceMeta is handled as expected. thx.

@wangfakang ok it's done


Support Theme Components

Theme Components are not currently supported by the Build Script.
For example the Hugo Bare Min Theme depends on a theme component called "hugo-debugprint" and as a result its demo is not generated on the Hugo Themes website.
See: https://github.com/kaushalmodi/hugo-bare-min-theme/issues/6#issuecomment-436994652

The build script uses the theme's exampleSite/ dir as site project dir, right?
Then the fix might be as simple as doing a *recursive git clone. That way, it will get all the linked git submodules in exampleSite/themes/ here: https://github.com/kaushalmodi/hugo-bare-min-theme/tree/master/exampleSite

Then the fix might be as simple as doing a recursive git clone.

Actually the lack of support for Theme Components on the Hugo Themes website is not a matter of a recursive git clone but more of an architecture issue and it seems unlikely that this will be solved within the Build Script.
Also the Hugo Docs mention the above lack of support since Theme Components were first implemented over here
With that said locally I managed to make the Themes Site Build Script see this theme's components by creating relative symlinks under the theme's /layouts/partials/ directory to the relevant partials under the theme components directories.
Relative symlinks may very well offer a valid workaround for themes with inherited theme components on the Hugo website.
However before exploring the above further there is an open issue that needs to be addressed first in the hugo-bare-min theme repository: https://github.com/kaushalmodi/hugo-bare-min-theme/issues/7

However before exploring the above further there is an open issue that needs to be addressed first in the hugo-bare-min theme repository: kaushalmodi/hugo-bare-min-theme#7

That issue is now fixed. Thanks for reporting it.


Blog article's words size on the Homepage

Hi, I have noticed that on Hulga's demo site and zilcH40's Blog, blog articles only display the first sentence on the home page, followed by "Read more".
But articles on my homepage show 6-7 lines each, although it still stops at the period (".") before "read more", but it includes multiple sentences (4 sentences).
Do you know how to config this to improve the reading experience?

In hugo, you can set the length of summary as Docs says.
Another potential reason is that you are using CJK languages, for your reference:

The Hugo-defined summaries are set to use word count calculated by splitting the text by one or more consecutive whitespace characters. If you are creating content in a CJK language and want to use Hugo’s automatic summary splitting, set hasCJKLanguage to true in your site configuration.

Thanks! I added summaryLength = 30 in the config.toml to solve the issue. it can also manually split the summary by adding <!--more-->, but using <!--more--> , the "Read more" will display in a newline


[Bug] Unexpected token

Describe the Bug
I'm just opening discord and it's showing its error
To Reproduce
maybe something broke with the pc idk because it started to happen after my pc started to crash a lot
Expected Behavior
restart the pc the see this (it can happen every day or 2)
Screenshots

Discord Version
Stable
Additional Context
discord sometimes freezes or crashes after reinstall better discord

Reinstall BD. This would only really happen if your PC or Discord is randomly killed during startup.

it fixed now i dont remember how i fixed it


Added bio and picture :)

Hi @Ibrahimmohamed33! Can you please update this PR so it includes the picture? :)


Bug: CodeIgniter\Router\Router hasLocale returns true even if {locale} is absent

Describe the bug
When using $this->request->getLocale() if the route don't have the {lang} segment i get always the default language because the $this->router->hasLocale() returns true in system/CodeIgniter.php line 798
CodeIgniter 4 version
4.0.4
Affected module(s)
Router
Expected behavior, and steps to reproduce if appropriate
The router should try to match the locale only if {locale} is present
Context

OS: CentOS 7 / Debian 10
Web server 2.4.6 / 2.4.38-3+deb10u3
PHP 7.4.8 / 7.3+69

Maybe I don't understand you correctly, but I couldn't reproduce the behavior you're describing here.
Please check out the methods that are available in the framework to set Locale dynamically: https://codeigniter.com/user_guide/outgoing/localization.html?highlight=locale#locale-detection
I'm closing this but feel free to continue the conversation if you can provide some better example for this issue.

In Routes.php i have
$routes->get('/code/(:any)', 'DefaultController::code/$1');
$routes->get('/menu/(:any)', 'DefaultController::menu/$1');

$routes->get('/{locale}', 'MainSite::index');
$routes->get('/{locale}/menu/(:any)', 'ShowMenu::index/$1');

In App.php I have
public $defaultLocale = 'it';
public $negotiateLocale = true;
public $supportedLocales = ['it','en','es','de','fr'];

i see the setLocale with menu as parameter in the locale in the DefaultController::menu

Sorry, but I followed your example and was not able to reproduce the error. Here are my results:
When we use {locate} in the URL it's always respected.
When I was checking $routes->get('/menu/(:any)', 'DefaultController::menu/$1'):

my default accept language is en and I got this value when calling $this->request->getLocale()
when I changed Accept-Language value in my browser to it it also worked fine (I got it)
when I changed Accept-Language value to something not supported, like pl, I got the default value it

This is all working as expected. If I'm still missing something, please don't hesitate to provide another example so I can reproduce the error.

I managed to reproduce the issue running

composer create-project codeigniter4/appstarter ci-lang-test
cd ci-lang-test

diff --git a/app/Config/App.php b/app/Config/App.php
index b91c058..5f6a130 100644
--- a/app/Config/App.php
+++ b/app/Config/App.php
@@ -76,7 +76,7 @@ class App extends BaseConfig
 	| If false, no automatic detection will be performed.
 	|
 	*/
-	public $negotiateLocale = false;
+	public $negotiateLocale = true;

 	/*
 	|--------------------------------------------------------------------------
@@ -88,7 +88,7 @@ class App extends BaseConfig
 	| found, the first locale will be used.
 	|
 	*/
-	public $supportedLocales = ['en'];
+	public $supportedLocales = ['en','it','es','de'];

 	/*
 	|--------------------------------------------------------------------------
diff --git a/app/Config/Routes.php b/app/Config/Routes.php
index 56839ca..aaeca6f 100644
--- a/app/Config/Routes.php
+++ b/app/Config/Routes.php
@@ -20,7 +20,7 @@ $routes->setDefaultController('Home');
 $routes->setDefaultMethod('index');
 $routes->setTranslateURIDashes(false);
 $routes->set404Override();
-$routes->setAutoRoute(true);
+$routes->setAutoRoute(false);

 /**
  * --------------------------------------------------------------------
@@ -32,6 +32,23 @@ $routes->setAutoRoute(true);
 // route since we don't have to scan directories.
 $routes->get('/', 'Home::index');

+$routes->get('/logout', 'Home::index');
+
+
+$routes->group('/admin',function(\CodeIgniter\Router\RouteCollection $routes) {
+    $routes->get('', 'Home::index');
+});
+$routes->group('/{locale}/admin', function(\CodeIgniter\Router\RouteCollection $routes) {
+    $routes->get('', 'Home::index');
+});
+
+$routes->get('/code/(:any)', 'Home::index');
+$routes->get('/menu/(:any)', 'Home::index');
+
+$routes->get('/{locale}', 'Home::index');
+$routes->get('/{locale}/menu/(:any)', 'Home::index');
+
+
 /**
  * --------------------------------------------------------------------
  * Additional Routing
diff --git a/app/Controllers/Home.php b/app/Controllers/Home.php
index 8798cdd..0c3996a 100644
--- a/app/Controllers/Home.php
+++ b/app/Controllers/Home.php
@@ -4,7 +4,7 @@ class Home extends BaseController
 {
 	public function index()
 	{
-		return view('welcome_message');
+		return $this->request->getLocale()."\n";
 	}

 	//--------------------------------------------------------------------

curl -H "Accept-Language: es" http://localhost:8080/menu/id1
curl -H "Accept-Language: es" http://localhost:8080

I'm thinking that the issue is with the $routes->group with the {locale} route

Okay, now I see it. It's not related to the $routes->group but just to the {locale} itself. If the route with {locale} is defined before "normal" route it will be "remembered" as $localeSegment in the Router::checkRoutes() will not have the opportunity to be reset.


Silence mc-lists loading

I don't want to see

Loading /home/pythonnut/.emacs.d/data/.mc-lists.el (source)...done

Every single time I load my Emacs.

This doesn't fix the case where multiple-cursors is loaded manually, though, right?

No, and I can't think of a better way to do it, other than some kind of with-eval-before-load system.  multiple-cursors seems determined to make this difficult for me.
If you have any better ideas, I'm all ears.

I would have thought that you could just add an advice to the appropriate function that loads .mc-lists.el, and the advice would take effect once the function is loaded. I might misunderstand how advices work on not-yet-loaded functions, though.

The problem here is that the file is not loaded by a function; it's a toplevel call.

Well, shoot.  You have no idea how much grief I have getting Org-mode to shut up about "can't figure out what version this is" when running it straight from the repository.
So I guess the only real solution is https://github.com/magnars/multiple-cursors.el/pull/290.

@raxod502

You have no idea how much grief I have getting Org-mode to shut up about "can't figure out what version this is" when running it straight from the repository.

I see what you did there.

Indeed. Running packages in an unconventional way seems to have a habit of revealing bugs. For example I had to make a pull request to Magit to deal properly with loading files through symlinks.


The question about running with the demo

Hi!The code runs without errors, but the result is as shown above. Why is this? Then I compiled openpose, but I didn't get openpose.bin, only got exe.Can you help me with your answer?

This problem has been bothering me for many days, I hope I can answer it. @yjxiong @yysijie

Hi,I've already solved the above problem under linux, and then I want to ask how to call the camera for real-time identification.

@yysijie @lshiwjx


Blazor preview 8

Hi,
This is a great project which I've been experimenting with. Thanks for your efforts.
I've updated my project to preview 8 of .net core 3 and blazor as this supposedly won't have any more breaking changes. Unfortunately, I haven't been able to include your package or work out how to build your source code with preview 8. I keep getting a linker error. Are you looking into getting this to work with the latest preview? I appreciate you may be busy at the moment but it would be useful to know if you are intending to do this.
Thanks very much,
Best regards,
Andy Eastham

Hi Andy,
Will get on to it in the next day or so.
Will let you know when it is done.
Cheers,
Bill

Have updated the source code to preview 8 and have published an updated Nuget package

Thank you so much.
Andy


 Someone should go through the changes and make sure our configs match up with the recommended patterns and upgrade our dependencies in package.json.
https://babeljs.io/blog/2019/03/19/7.4.0

Babel is upgrade :)


[RFR] Fix all dependencies version

Closing as discussed with the team. We keep ~ to update patch versions, and hence profit from security enhancements.


Fixed possible memory leak

Nice to see my 10+ year old code brought back to life.
Erwin

@CDyWeb thanks Erwin! Your code certainly helped me and a lot of people. Welcome back :)


Add some options so we can influence the compression options of inter…

…mediate data written by cascading

@rangadi can you take a look at this?

LGTM.


add more properties to Fsc msbuild task

SkipCompilerExecution to skip compilation (default false)
ProvideCommandLineArgs to populate output CommandLineArgs (default false)
CommandLineArgs (output) the list of fsc arguments (only if ProvideCommandLineArgs is true)

All default to previous behaviour (so are disabled)
That's needed for

FCS https://github.com/fsharp/FSharp.Compiler.Service/issues/707
roslyn https://github.com/dotnet/roslyn-project-system/pull/1670

Change to target file is just
              SkipCompilerExecution="$(SkipCompilerExecution)"
              ProvideCommandLineArgs="$(ProvideCommandLineArgs)">
          <Output TaskParameter="CommandLineArgs" ItemName="FscCommandLineArgs" />
        </Fsc>

I didnt added to current in vf# repo, because is only used with new fsproj.
And new target file for fsproj isnt there, but in https://github.com/dotnet/netcorecli-fsc/src/FSharp.NET.Sdk/build/FSharp.NET.Core.Sdk.targets
/cc @dsyme @KevinRansom

Hey @enricosada is there any reason we don't always populate CommandLineArgs?  having a property to set that seems a trifle redundant.

@KevinRansom i didnt added it at first.
But Csc task does like that, and i think is to not pullute more the msbuild output with tons of lines for that items. So i added it.
Also i didnt add the property in target file to save FscCommandLineArgs to a file as was discussed before, because is not needed anymore.
I did it better ihmo with a tool/lib, to generally evaluate all needed properties/items from fsproj/csproj for FSAC/FCS. Not tied to msbuild assemblies/api, just calling dotnet msbuild
ref examples https://github.com/enricosada/dotnet-proj-info/tree/master/examples

ref https://github.com/dotnet/netcorecli-fsc/pull/88 who modify f# target file

@enricosada ... Hmmm!! well if they did it that way ... who are we do differently :-)

Thanks @KevinRansom


JavaScript Solution example for Face Detection crashes due to incorrect options in setOptions()

Thank you for submitting a MediaPipe documentation issue.
The MediaPipe docs are open source! To get involved, read the documentation Contributor Guide
URL(s) with the issue:
https://google.github.io/mediapipe/solutions/face_detection#javascript-solution-api
Description of issue (what needs changing):
The Javascript API to set Options for face detection has 'model': 'short' as supported option and not modelSelection. Also the drawingUtils variable is not initialised. This is forcing abrupt crash of JS Face detection example.  Relates to the issue #3950 .
Clear description
...
Correct links
No link
Parameters defined
The documentation does not provide the Javascript API description.
But the parameter accepted by the setOptions function in faceDetection object are incorrect. modelSelection
Returns defined
The documentation does not provide the Javascript API description.
Raises listed and defined
The documentation does not provide the Javascript API description.
Usage example
Yes
..
Request visuals, if applicable
No
Submit a pull request?
Are you planning to also submit a pull request to fix the issue? See the docs
https://github.com/google/mediapipe/blob/master/CONTRIBUTING.md
Yes planning to submit PR.

This has been fixed internally and can be closed.