Refactor Java API

We had a long discussion with Mr. Bulldog, resulting in the following:

Packages refactoring

Modularity in my own taste of order. :-) Well, I refactored those packages a bit - I think I did a good job naming them, or do you find a module/packagename misleading? I can then explain it to you. The only choice I regret is putting things in the gpio package that don't belong there (e.g. AnalogInput.java or even the Pin class!). A lot of people think a GPIO is the pin that you can touch, the outlet of a signal. That is plainly wrong and when I realized it, it was too late. GPIO is just a feature of a pin. This term is often used loosely and often times wrong on the web. This specific thing should be refactored or else real electrical engineers will face palm. Pi4j has the same problem, btw.

Overall architecture

Libbulldog was intended as an easy to use API for makers and tinkerers - thus the naive approach with the board as an entry point to get everything. Due to this target audience, I also broke with the concept of providers (like pi4j does for example). I thought that for the average tinkerer, in contrast to the skilled programmer, such wordings would only add complexity. The concept of pin features was born as I thought about the problem domain.  It can be connected to various features and thus I concluded it would be wrong to implement features directly into a Pin class. So I created it as a container which can be connected to a "feature". This abstraction is still not 100% correct, however, because there are features that can be used which have not really a PIN as an outlet (yes, of course, there are lines on the pcb but they are not intended to be accessible).
By now I think the correct abstraction would be to have a feature, configure it and then eventually map it to a possible outlet (e.g. a pin).
Also, find attached the revised architecture that Robert Savage, me and a few others had worked out after long discussions. We had plans for Android support, a daemon for server usage, transparent networking (like EJB/.NET Remoting), and, of course, support for many platforms (Banana Pi, Hummingboard, all the Cubies and the Intel Galileos).
{quote}

Resolved by fixing #63


No bower.json present when using bower 1.5.x

We have a bunch of projects with the same bower setup.
In the root of the project, there is a .bowerrc file with "cwd" set to "client".
{
  "cwd": "client",
  "directory": "src/bower_components"
}

In the "client" directory we have our bower.json file.  We run "bower install" from the root of the project.
We have been using this same set up for over a year in some projects.  It seems starting with bower 1.5.0, we started getting the error pasted below.
Downgrading to 1.4.1 fixed the issue.  We were also able to replicate this on 5 different machines (4 devs + our build server).
For now we downgraded bower on our build server to 1.4.1 to get around this issue.
bower                           ENOENT No bower.json present

Stack trace:
Error: No bower.json present
    at createError (/Users/jsolis/Sites/m-stay-checkout/node_modules/bower/lib/util/createError.js:4:15)
    at /Users/jsolis/Sites/m-stay-checkout/node_modules/bower/lib/core/Project.js:54:19
From previous event:
    at Project.install (/Users/jsolis/Sites/m-stay-checkout/node_modules/bower/lib/core/Project.js:88:6)
    at install (/Users/jsolis/Sites/m-stay-checkout/node_modules/bower/lib/commands/install.js:26:20)
    at /Users/jsolis/Sites/m-stay-checkout/node_modules/bower/lib/commands/index.js:32:28

Console trace:
Error
    at StandardRenderer.error (/Users/jsolis/Sites/m-stay-checkout/node_modules/bower/lib/renderers/StandardRenderer.js:82:37)
    at Logger.<anonymous> (/Users/jsolis/Sites/m-stay-checkout/node_modules/bower/bin/bower:110:22)
    at Logger.emit (events.js:107:17)
    at Logger.emit (/Users/jsolis/Sites/m-stay-checkout/node_modules/bower/node_modules/bower-logger/lib/Logger.js:29:39)
    at /Users/jsolis/Sites/m-stay-checkout/node_modules/bower/lib/commands/index.js:45:20
    at _rejected (/Users/jsolis/Sites/m-stay-checkout/node_modules/bower/node_modules/q/q.js:844:24)
    at /Users/jsolis/Sites/m-stay-checkout/node_modules/bower/node_modules/q/q.js:870:30
    at Promise.when (/Users/jsolis/Sites/m-stay-checkout/node_modules/bower/node_modules/q/q.js:1122:31)
    at Promise.promise.promiseDispatch (/Users/jsolis/Sites/m-stay-checkout/node_modules/bower/node_modules/q/q.js:788:41)
    at /Users/jsolis/Sites/m-stay-checkout/node_modules/bower/node_modules/q/q.js:604:44
System info:
Bower version: 1.5.1
Node version: 0.12.7
OS: Darwin 14.4.0 x64

Yes, it's a bug. Sorry about that. I'll push fix soon.

:+1: awesome, thanks for the quick reply

In 1.5.2 I've reverted auto-running in directory containing bower.json, so it should be fine now..

:trophy: confirmed this works with v 1.5.2 again.  Thanks!!


vendor: bump libcontainer and its deps

Pulls latest libcontainer code and updates its deps
Signed-off-by: Antonio Murdaca<EMAIL_ADDRESS>

https://github.com/docker/docker/pull/17211 updated go-systemd to v4, now libnetwork isn't compiling because it's using v3 (and godbus/dbus v2), I'll try and update libnetwork as well otherwise this PR won't even compile

created https://github.com/docker/libnetwork/pull/765 to address the above comment

/cc @tianon (I'll use v5 here if tag gets pushed to runc)

Wooot, "v0.0.5" now available! :smile: :heart:

updated! though this still needs libnetwork changes before being merged :(

@LK4D4 @tianon this can be reviewed now that libnetwork changes are in and it does compile

:metal: :+1:  LGTM

I'll wait for CI :D

oh noes, cross-compile failed lol

opened https://github.com/docker/libnetwork/issues/770 which address failures in cross compilation

\o/ green!

LGTM

@tiborvass I added this to the 1.9.2 milestone for consideration, because it fixes https://github.com/docker/docker/issues/18145. however I see this PR not only updates libnetwork, but also libcontainer, and I'm not sure (if a 1.9.2 release is released) we want both in a patch release...

@thaJeztah @tiborvass Please, add this to a 1.9.2 :(
we are on production with 1.9.1 with #18535
the workaround (removing network local-kv.db) does not solve the real problem

@sitamet we most likely won't be releasing 1.9.2; but this will be in docker 1.10; code freeze is this Thursday - scheduled for release February 4th

@thaJeztah ok ... lets go forward then :S


crun: 1.5 -> 1.6

https://github.com/containers/crun/releases/tag/1.6
Description of changes

Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[x] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
22.11 Release Notes (or backporting 22.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module
[ ] (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes

[x] Fits CONTRIBUTING.md.

Please remove fetchpatch from inputs, it seems it isn't used anymore

@ofborg build crun


test(connlib): refactor checked ICMP properties

With #5049, connlib will start mangling and translating ICMP requests which means we can no longer rely on the ICMP request emitted by the gateway to have the same sequence number and identifier as originally generated by the client. In the end, that is actually also not a property we care about.
What we do care about is that an ICMP request results in an ICMP reply and that those have a matching sequence number and identifier. Additionally, every ICMP request arriving at the gateway should target the correct resource. For CIDR resources, we already now which IP that should be. For DNS resources, it has to be one of the resolved IPs for the domain.

@conectado I added some logs too and extracted the assertions into dedicated functions to make it easier to understand what is going on. What is nice is that, by keeping all previous packets, I can make the state of the mapping actually a local variable!


Elasticsearch NEST tutorial times out after long processing

Following along the tutorial here
https://github.com/elastic/elasticsearch-net-example/tree/5.x with elasticsearch 5.6 and changing the code as below i get response timed out exception on windows 7. All the settings are default and cluster is running on localhost:9200
static void IndexDumps()
{
 	   var packages = DumpReader.Dumps.Select(s=>s.NugetPackages);

            var result = Client.IndexMany(packages);

            if (!result.IsValid)
            {
                Console.WriteLine(result.OriginalException.ToString());
            }

            Console.WriteLine("Done.");
}

@sramalingam24 Could you post on issue on https://github.com/elastic/elasticsearch-net-example/issues for this please.

@russcam I have entered an issue, thanks.


Add pageblock to customer account UI

Background
TLDR; We are re-adding PageBlock, an exclusive Self-serve component, to the customer-account-ui packages for use in a 1P extension app being built on Self-serve for the Shopify Returns project.

Add PageBlock to both the plain and React flavors of the customer-account-ui packages
Update the type for the padding prop

Related PRs

Original PR to add PageBlock: https://github.com/Shopify/ui-extensions/pull/361
PR to remove PageBlock: https://github.com/Shopify/ui-extensions/pull/365

Solution
In order to unblock the Shopify Returns team, we are re-exposing PageBlock as an extension component in customer-account-ui. A different component will likely replace PageBlock in the future.
🎩

...

Checklist

[ ] I have :tophat:'d these changes
[ ] I have updated relevant documentation

Hi all! 👋 I am new to this repo but am working on a first-party application built on the Self-serve platform. Per this Slack discussion, we decided to re-expose PageBlock to unblock extension app development.
Please let me know if there's anything I missed here!


Null coalescing with or should be faster.

Most minor of refactorings.

@asavaritayal Any thoughts on this tiny change?

Coalescing isn't usually faster than an if statement, and I usually prefer not to use it for long statements such as these.

Cool! I learned something 🙂
I’ll abandon the PR


Swift 4 migration.

Swift 4 migration.

Hi @drxlx, thank you very for the PR, the lib has been updated for the latest Swift version.
Thanks again :)


Domain activation is Failed - [BRIEF DESCRIPTION]

App Id: d32ydrg3lpvl5a
Region: eu-west-3
Step: Domain activation
Status: Failed

Note: Do not include information that is sensitive in nature such as your domain name, company etc.

Issue/question
A clear and concise description of what the issue/question is.
Error message
If there is an error message, please include it here.
Note: Be sure to check the message for sensitive information.
Additional information
Please add any other relevant information. Please feel free to include screenshots.

Resolving due to age, if you are still experiencing issues please re-open the ticket.
Else you can try following these steps:

Is this domain connected to a different Amplify App that you own? If so, make sure you are not trying to reuse one of the hostnames.
If you are using www.domain.com on the other app, you cannot use www.domain.com on this app
You can use other hostnames, like blog.domain.com
If you had this domain successfully connected to Amplify and then recently (within the last hour) deleted it, please wait and try again.
Check the Cloudfront console to see if you have this domain deployed to any distributions
If you are positive no CloudFront distribution exists (including in other accounts) using this domain, and only if it would not be disruptive to any currently running services, try deleting and recreating the hosted zone


Case insensitive routing

Add a configuration option for case insensitive routing
https://github.com/vapor/vapor/issues/1196

Merged


Nice Job！but In terms of details, there is a sense of tearing and deformation on the lips and face. How can it be adjusted?

The provided image should be in a square shape, or the method may produce unexpected results.


docs: add Pharos Design System to who-is-using

Add Pharos Design System to who-is-using with logo

@googlebot I signed it!

/gcbrun


Error "KeyError: 'queued_msgs'" while getting metrics from Wazuh Manager 4.7.2

Hi. Currently running Wazuh 4.7.2, with the 'latest' docker image for the exporter as of now (2024-01-28) and when I want to start the exporter, I  get the following error:
{"written_at": "2024-01-28T10:53:06.548Z", "written_ts":<PHONE_NUMBER>548555000, "msg": "Starting Wazuh prometheus exporter", "type": "log", "logger": "wazuh-exporter", "thread": "MainThread", "level": "info", "module": "main", "line_no": 551}
{"written_at": "2024-01-28T10:53:06.549Z", "written_ts":<PHONE_NUMBER>549734000, "msg": "Start collector", "type": "log", "logger": "wazuh-exporter", "thread": "MainThread", "level": "info", "module": "main", "line_no": 62}
{"written_at": "2024-01-28T10:53:07.595Z", "written_ts":<PHONE_NUMBER>595591000, "msg": "Got response http code 400, response body Stats file does not exist: /var/ossec/stats/totals/2024/Jan/ossec-totals-28.log", "type": "log", "logger": "root", "thread": "MainThread", "level": "warning", "module": "__init__", "line_no": 127}
Traceback (most recent call last):
  File "./main.py", line 553, in <module>
    REGISTRY.register(WazuhCollector())
  File "/usr/local/lib/python3.8/site-packages/prometheus_client/registry.py", line 40, in register
    names = self._get_names(collector)
  File "/usr/local/lib/python3.8/site-packages/prometheus_client/registry.py", line 80, in _get_names
    for metric in desc_func():
  File "./main.py", line 251, in collect
    value=remote_state["queued_msgs"],
KeyError: 'queued_msgs'

When I do a curl -kH 'Authorization: Bearer <SNIP>' https://<IP_ADDRESS>:55000/manager/stats?pretty=true, I get the following response:
{
   "data": {
      "affected_items": [
         {
            "hour": 10,
            "alerts": [
               {
                  "sigid": 5104,
                  "level": 8,
                  "times": 1
               },
               {
                  "sigid": 5403,
                  "level": 4,
                  "times": 1
               },
               {
                  "sigid": 5402,
                  "level": 3,
                  "times": 50
               },
               {
                  "sigid": 2930,
                  "level": 0,
                  "times": 2
               },
               {
                  "sigid": 2932,
                  "level": 7,
                  "times": 6
               },
               {
                  "sigid": 5501,
                  "level": 3,
                  "times": 57
               },
               {
                  "sigid": 5502,
                  "level": 3,
                  "times": 60
               },
               {
                  "sigid": 5721,
                  "level": 0,
                  "times": 6
               },
               {
                  "sigid": 5715,
                  "level": 3,
                  "times": 3
               },
               {
                  "sigid": 40700,
                  "level": 0,
                  "times": 120
               },
               {
                  "sigid": 80700,
                  "level": 0,
                  "times": 2121
               },
               {
                  "sigid": 80710,
                  "level": 10,
                  "times": 2
               },
               {
                  "sigid": 86003,
                  "level": 3,
                  "times": 2
               },
               {
                  "sigid": 86001,
                  "level": 1,
                  "times": 92
               },
               {
                  "sigid": 86002,
                  "level": 1,
                  "times": 3
               },
               {
                  "sigid": 5901,
                  "level": 8,
                  "times": 3
               },
               {
                  "sigid": 5902,
                  "level": 8,
                  "times": 1
               },
               {
                  "sigid": 1002,
                  "level": 2,
                  "times": 41
               },
               {
                  "sigid": 530,
                  "level": 0,
                  "times": 178
               },
               {
                  "sigid": 533,
                  "level": 7,
                  "times": 3
               },
               {
                  "sigid": 535,
                  "level": 1,
                  "times": 11
               },
               {
                  "sigid": 501,
                  "level": 3,
                  "times": 3
               },
               {
                  "sigid": 502,
                  "level": 3,
                  "times": 1
               },
               {
                  "sigid": 503,
                  "level": 3,
                  "times": 3
               },
               {
                  "sigid": 506,
                  "level": 3,
                  "times": 3
               },
               {
                  "sigid": 515,
                  "level": 0,
                  "times": 11
               },
               {
                  "sigid": 19000,
                  "level": 0,
                  "times": 746
               },
               {
                  "sigid": 19007,
                  "level": 7,
                  "times": 324
               },
               {
                  "sigid": 19011,
                  "level": 9,
                  "times": 1
               },
               {
                  "sigid": 19008,
                  "level": 3,
                  "times": 219
               },
               {
                  "sigid": 19009,
                  "level": 3,
                  "times": 6
               },
               {
                  "sigid": 19004,
                  "level": 7,
                  "times": 7
               }
            ],
            "totalAlerts": 4087,
            "events": 20890,
            "syscheck": 11,
            "firewall": 0
         }
      ],
      "total_affected_items": 1,
      "total_failed_items": 0,
      "failed_items": []
   },
   "message": "Statistical information for each node was successfully read",
   "error": 0
}

It is indeed missing, but so are other keys. So not sure yet if this is a me issue or a exporter issue.
If you need any additional information, don't hesitate to reach out.

Thanks @pyToshka
(Nice PR though!) 👍


Update debug to have timestamps

What this PR does / why we need it:
This PR adds timestamp to debug statements
fixes https://github.com/helm/helm/issues/6336
Special notes for your reviewer:
If applicable:

[ ] this PR contains documentation
[ ] this PR contains unit tests
[ ] this PR has been tested for backwards compatibility

cc @bacongobbler Can you take a look at this.
@freeseacher What do you think about this. Should I make any more changes ?

@waveywaves As I mentioned in my comment, I don't think adding timestamps is really necessary seeing as this is a function used purely by the CLI. Anyone who uses it as a library can attach their own logger with timestamps and if you are using it in CI or other automated usage, timestamps are automatically attached. Please let me know if there is a good argument for them I am missing

timestamps are automatically attached
sorry, but they are not. gitlab does not provide such functionality :(
probably it is corner case and timestpamping should be added with flags

Thanks @waveywaves for the contribution. Right now the core maintainers are trying to focus on bug fixes so we can release Helm 3.0 in a timely manner. Can we re-discuss this feature after Helm 3.0 has been released?

@bacongobbler @thomastaylor312 From my point of view as well, this does not seem to be something that is extremely critical. I have only updated this wrt the feature proposal by @freesearcher.

Apologies for the automatic closure. We just switched the dev-v3 branch to master, and the old master branch is now dev-v2. Feel free to re-open a new PR with this change. Thanks again and sorry for the hassle!

please reopen it. still usefull in my opinion

@freeseacher once the base branch has been closed, the PR cannot be re-opened. That's why I'm asking @waveywaves to open a new PR.
This was a clerical error on our end as part of the migration. Sorry about that.


upd(teams-for-linux-deb): 1.0.25 -> 1.0.45

@Zahrun do you wish to continue maintaining this?

@Zahrun do you wish to continue maintaining this?

No, please go ahead


lets make sure we can focus on the filter search input

I have overwritten template and removed filter search input field. Then I got javascript error where it cannot .focus() on the input as it doesnt exist.
Here is a quick check if it exists as a fix.
Any comments/amends please let me know

Cool, thanks!


source.user attribute (mTLS auth principal) has incorrect value

When I was testing Bookinfo sample with Istio 0.5 release, I found that "source.user" attribute for requests calling "productpage" service was set to "cluster.local/ns/istio-system/sa/default". However, it is the ingress service that calls "productpage" service, and Ingress service is deployed with "istio-ingress-service-account". So we expect "source.user" being set to "cluster.local/ns/istio-system/sa/istio-ingress-service-account", instead of "cluster.local/ns/istio-system/sa/default".
In addition, after I upgraded to Istio 0.6 release, "source.user" becomes an empty string, which is obviously wrong. This is completely breaking Istio RBAC and any authorization system on Mixer because the auth principal is missing.

/cc @myidpt @qiwzhang @wattli @wenchenglu

We need an e2e test case that is validating this use case as well.

Actually, after debugging (with help from @qiwzhang and @ldemailly), we found that for Istio 0.6 release, source.user is set to "cluster.local/ns/istio-system/sa/default" for all mesh services except Ingress. For Ingress service, "source.user" was set to empty, which was expected. I slightly changed RBAC policy and it works now.
The reason I only see empty value for "source.user" in 0.6 Istio is that, from 0.6 release, Ingress starts calling Mixer. Before that, Ingress does not call Mixer.
Now the only issue left is ingress service identity is set to  "cluster.local/ns/istio-system/sa/default", rather than the Ingress service account. Is that expected?

This is the set of attributes for "productpage" service. Note that source.serviceAccount is istio-ingress-service-account, but source.user is set to cluster.local/ns/istio-system/sa/default.
2018-03-03T00:50:13.516954Z     debug   Attribute Bag:
connection.mtls               : true
context.protocol              : http
destination.ip                : [0 0 0 0 0 0 0 0 0 0 255 255 10 8 1 14]
destination.labels            : {destination.labels map[pod-template-hash:1658261386 version:v1 app:productpage] 0xc420ddb380}
destination.service           : productpage.default.svc.cluster.local
destination.uid               : kubernetes://productpage-v1-5b9d6b57db-6mxnd.default
request.headers               : {request.headers map[user-agent:Mozilla/5.0 (X11; Linux x86_64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/64.0.3282.186 Safari/537.36 upgrade-insecure-requests:1 :path:/productpage cache-control:max-age=0 x-b3-sampled:1 accept-encoding:gzip, deflate accept:text/html,application/xhtml+xml,application/xml;q=0.9,image/webp,image/apng,/;q=0.8 x-forwarded-for:<IP_ADDRESS> accept-language:en-US,en;q=0.9 x-ot-span-context:460857f3adf33548;460857f3adf33548;0000000000000000 x-envoy-internal:true x-b3-spanid:460857f3adf33548 :authority:<IP_ADDRESS> x-b3-traceid:460857f3adf33548 x-request-id:e459734f-e7bb-9b7f-a01f-d3c8228fa1a9 x-forwarded-proto:http content-length:0 :method:GET] 0xc420ddb380}
request.host                  : <IP_ADDRESS>
request.method                : GET
request.path                  : /productpage
request.scheme                : http
request.time                  : 2018-03-03 00:50:13.512687487 +0000 UTC
request.useragent             : Mozilla/5.0 (X11; Linux x86_64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/64.0.3282.186 Safari/537.36
source.ip                     : [10 8 2 17]
source.port                   : 36988
source.uid                    : kubernetes://istio-ingress-7bb5cf4c4c-s8p9c.istio-system
source.user                   : cluster.local/ns/istio-system/sa/default
destination.namespace         : default
destination.serviceAccount    : bookinfo-productpage
source.labels                 : map[istio:ingress pod-template-hash:3661790707]
source.namespace              : istio-system
source.service                : istio-ingress.istio-system.svc.cluster.local
source.serviceAccount         : istio-ingress-service-account

Yes, I think the source.user is incorrect here. Thanks for digging into this. Will look into it.

This is fixed in https://github.com/istio/istio/pull/4115

it will auto close when that PR merges


Hamishmar Votes Data should include member ID instead of name

Currently Hamishmar votes data csv file contains a list of member names
This is a problem because the spelling they use is different then Knesset spelling.
Hamishmar will do a change on their side which will allow them to export the member IDs (same as the official Knesset ID which is the same as the Open Knesset Member ID as well)
Update (May.10) - we got the updated format, see the comment below

the updated csv format: votes.csv
the required change is in non_knesset_data/hamishmar_votes.py and the corresponding tests are at non_knesset_data/tests/test_hamishmar_votes.py

not sure if it's still needed, closing for now, and will keep tracking in the open knesset issue hasadna/Open-Knesset#502


Update manual install docs for Ruby 3.2.2

This commit updates the manual install documentation to reference Ruby 3.2.2 and one new build-time dependency for Ruby on Debian.

I'm not absolutely sure if libtool-bin has to be there as an explicit dependency. Does a build fail without it?

A fresh build of Debian 12 Bookworm did not require this explicity.
My previous experience was with a Debian Buster which I upgraded straight to Bookworm, which may have required this.

Ok 😄  What do we think about removing libtool-bin from the dependencies and see if anyone runs into problems?

@dsander @knu I have updated this pull request in e751d84a5903d912838e5118dc5f9de5f0589683 to remove libtool-bin.

Thank you!


Fix git ahead/behind count on zsh

@{upstream}...HEAD needs to be quoted else zsh eats it.

Bad pull request.  Will fix and resubmit.

Apparently I don't understand how pull requests work on github.
Made a second fix for the only_if_ssh check on the host slice and somehow it became a part of this pull request.  Should be pulled also but not sure how it automatically became part of this PR.

Hm.. I can't reproduce. Which version of zsh are you using?

Installed via homebrew.
zsh 5.0.7 (x86_64-apple-darwin14.0.0)
On OS X Yosemite


Text Shadow Offset wrong compiled

In the SCSS:
text-shadow-offset: "JS({width: 0, height: 0})";
In the JS:
"textShadowOffset": ""JS({width: 0, height: 0})""
It should be compiling this:
"textShadowOffset":{width: 0, height: 0}
React states that textShadowOffset cannot be a string.

Your computer system?
I use mac os and windows tests are normal, you have described the problem occurs because the "js (...)" has not been parsed, and then I use your posted code successfully parsed.
Can you give me a complete code?

I'm running on the following setup:

Mac OS 10.11.4
Node v5.3.0
react-native-css v1.2.35

I created a test.scss and ran: "react-native-css -i test.scss -o test.js", you can download the source and compiled js here: http://cl.ly/fUHV

This is a very embarrassing thing, you are not using plugin I wrote atom-react-native-css, react-native-css does not support JS()，vw，vh，vmax，vmin These features are my extended。If you are using atom, you can use my plug.

Aaaahhh! Confusion! But thanks!


How can I control the line/arc width?

How can I control the line/arc width?
I can only see options for colors....

Hi!
Leaflet.Arc extends Leaflet.Polyline, so you can pass all options it supports.
Line width can be controlled by weight option (see Leaflet docs).


Video not playing with Amazon URL.

I am trying to play video from amazon URL but this error occurs.
Video operation finished with error: Invalid parameters.
is it possible to play custom url rather than youtube video id?

I feel this is more for StackOverflow rather than GitHub. However this should work for you:
XCDYouTubeVideoPlayerViewController *videoPlayerViewController = [[XCDYouTubeVideoPlayerViewController alloc] initWithContentURL:[NSURL URLWithString:@"URL"]];

@JJGEight  thanks for reply. but that is not working as you mentioned above, it will throw exception.

@kuldeep13990 you can just edit XCDYouTubeVideoPlayerViewController and comment out the following to stop the exception and to inherit make XCDYouTubeVideoPlayerViewController inherit from MPMoviePlayerViewController.
- (instancetype) initWithContentURL:(NSURL *)contentURL
{
	@throw [NSException exceptionWithName:NSGenericException reason:@"Use the `initWithVideoIdentifier:` method instead." userInfo:nil];
} // LCOV_EXCL_LINE

Probably should have added this before, apologies.

The exception is there you tell you that you are not using XCDYouTubeVideoPlayerViewController properly. If you already have a movie URL to play, you simply don’t need XCDYouTubeKit at all, just use an AVPlayerViewController.


Is it possible to set BATCH_IMAGES > 1?

Seemed that you can only accelerate training/testing by using multiple GPUs, which doesn't make sense now, since the memory of mainstream GPU is more than 10G, while training with batch_image 1 only use about 4G per card.

If I don't get it wrong, you mean you want to train more than one image in a single GPU? It's possible to do so. See https://github.com/Zardinality/TF_Deformable_Net/issues/16. @Zardinality made a great answer for this problem.

@jessemelpolio I got it. Thank you.


Workspace Factory #14: Expanded Import/Export

Expanded import and export buttons to be dropdowns that allow the user to import/export toolbox XML or workspace XML for pre-loaded blocks. In the case of export, the user has the option to export both the toolbox XML and the workspace XML in separate files. Print was not updated in this way because the print button will probably be removed in the final version (mostly for debugging purposes) and adding dropdown options for print would only require UI changes.
Changes made to index.html (restructuring UI for dropdowns), style.css (removed unnecessary style for labels), wfactory_controller.js (most of changes, allow different modes for importing and exporting), and wfactory_generator.js (adjust generator functions to not need the toolbox workspace currently loaded).

This change is

+@picklesrus +@vicng +@quachtina96

Review status: 0 of 4 files reviewed at latest revision, all discussions resolved.

Comments from Reviewable

Review status: 0 of 5 files reviewed at latest revision, 7 unresolved discussions, some commit checks failed.

demos/blocklyfactory/workspacefactory/wfactory_controller.js, line 255 [r1] (raw file):

  if (exportMode == FactoryController.MODE_TOOLBOX) {
    // Export the toolbox XML.
    if (this.selectedMode == FactoryController.MODE_TOOLBOX) {

The idea of capturing changes made by user should be in a separate method, since it looks like it's being called in many places and it's dependent on the mode.

demos/blocklyfactory/workspacefactory/wfactory_controller.js, line 315 [r1] (raw file):

  if (this.selectedMode == FactoryController.MODE_TOOLBOX) {
    // If currently editing the toolbox.
    // Capture any changes made by user before generating XML.

This shouldn't be in updatePreview().

demos/blocklyfactory/workspacefactory/wfactory_controller.js, line 501 [r1] (raw file):

  }

  var firstCategory = !this.model.hasToolbox();

Rename variable to isFirstCategory.

demos/blocklyfactory/workspacefactory/wfactory_model.js, line 76 [r1] (raw file):

 * @return {boolean} True if categories exist, false otherwise.
 */
FactoryModel.prototype.hasToolbox = function() {

Didn't catch this before, but this should be renamed to hasElements or something.
Update the comment too.

demos/blocklyfactory/workspacefactory/wfactory_model.js, line 114 [r1] (raw file):

  // If removing last element from toolbox list, create empty list element
  // for single flyout.

Missing call to setDefaultSelected()?
Nit: Add line above this comment.

demos/blocklyfactory/workspacefactory/wfactory_model.js, line 122 [r1] (raw file):

 *
 */
FactoryModel.prototype.setDefaultSelected = function() {

Rename to createDefaultSelectedIfEmpty() or something more descriptive.

demos/blocklyfactory/workspacefactory/wfactory_model.js, line 124 [r1] (raw file):

FactoryModel.prototype.setDefaultSelected = function() {
  if (this.toolboxList.length == 0) {
    this.selected = new ListElement(ListElement.TYPE_CATEGORY);

This is confusing -- you can have a selected element that isn't actually in the toolbox list?

Comments from Reviewable

Review status: 0 of 5 files reviewed at latest revision, 7 unresolved discussions, some commit checks failed.

demos/blocklyfactory/workspacefactory/wfactory_controller.js, line 255 [r1] (raw file):
Previously, vicng wrote…
> The idea of capturing changes made by user should be in a separate method, since it looks like it's being called in many places and it's dependent on the mode.

Moved to a saveStateFromWorkspace method that's called whenever it's possible that the user updated the workspace.

demos/blocklyfactory/workspacefactory/wfactory_controller.js, line 315 [r1] (raw file):
Previously, vicng wrote…
> This shouldn't be in `updatePreview()`.

Moved into saveStateFromWorkspace

demos/blocklyfactory/workspacefactory/wfactory_controller.js, line 501 [r1] (raw file):
Previously, vicng wrote…
> Rename variable to `isFirstCategory`.

Done.

demos/blocklyfactory/workspacefactory/wfactory_model.js, line 76 [r1] (raw file):
Previously, vicng wrote…
> Didn't catch this before, but this should be renamed to `hasElements` or something.
>
> Update the comment too.

Done.

demos/blocklyfactory/workspacefactory/wfactory_model.js, line 114 [r1] (raw file):
Previously, vicng wrote…
> Missing call to setDefaultSelected()?
>
> Nit: Add line above this comment.

Forgot to take out the comment after trying the call to setDefaultSelected there. Moved it to the controller.

demos/blocklyfactory/workspacefactory/wfactory_model.js, line 122 [r1] (raw file):
Previously, vicng wrote…
> Rename to `createDefaultSelectedIfEmpty()` or something more descriptive.

Done.

demos/blocklyfactory/workspacefactory/wfactory_model.js, line 124 [r1] (raw file):
Previously, vicng wrote…
> This is confusing -- you can have a selected element that isn't actually in the toolbox list?

I did this because before having multiple modes, there was no need to store the XML for the workspace when there were no categories. However when I switch to the other mode, I need to be able to store the workspace XML, and the easiest way to store it is as selected XML. Because there aren't any elements in the list, it doesn't live in the toolboxList, only in selected. If you think this is problematic, we can definitely talk about it. I chose to do it this way because by leaving it as selected, I didn't have to do a lot of extra checks for if there are categories to figure out where to load XML from or save XML to  when switching between modes.

Comments from Reviewable

Review status: 0 of 5 files reviewed at latest revision, 7 unresolved discussions, some commit checks failed.

demos/blocklyfactory/workspacefactory/wfactory_controller.js, line 360 [r2] (raw file):

    // If currently editing the toolbox.
    this.model.getSelected().saveFromWorkspace(toolboxWorkspace);
  } else {

Make this an else if, in case you add more modes in the future.

demos/blocklyfactory/workspacefactory/wfactory_model.js, line 124 [r1] (raw file):
Previously, evd2014 (Emma Dauterman) wrote…
> I did this because before having multiple modes, there was no need to store the XML for the workspace when there were no categories. However when I switch to the other mode, I need to be able to store the workspace XML, and the easiest way to store it is as selected XML. Because there aren't any elements in the list, it doesn't live in the toolboxList, only in selected. If you think this is problematic, we can definitely talk about it. I chose to do it this way because by leaving it as selected, I didn't have to do a lot of extra checks for if there are categories to figure out where to load XML from or save XML to  when switching between modes.

Yeah, this is definitely confusing.
In general, try avoid hacking your model since its the base for all your code. I've found it best to keep the model really simple and very explicit, or else it can introduce logic errors later on in development (maybe not for you, but for ppl working off your code).
You can leave it as-is for now, but you should clean this up in a TODO. Some ideas for fixing are:

Create an explicit .flyout property, and make it so only one of toolboxList or flyout can be non-empty at all times (adding proper error checking throughout model as needed)
Create a different ListElement type for flyouts

Comments from Reviewable

Review status: 0 of 5 files reviewed at latest revision, 7 unresolved discussions, some commit checks failed.

demos/blocklyfactory/workspacefactory/wfactory_controller.js, line 360 [r2] (raw file):
Previously, vicng wrote…
> Make this an `else if`, in case you add more modes in the future.

Done.

demos/blocklyfactory/workspacefactory/wfactory_model.js, line 124 [r1] (raw file):
Previously, vicng wrote…
> Yeah, this is definitely confusing.
>
> In general, try avoid hacking your model since its the base for all your code. I've found it best to keep the model really simple and very explicit, or else it can introduce logic errors later on in development (maybe not for you, but for ppl working off your code).
>
> You can leave it as-is for now, but you should clean this up in a TODO. Some ideas for fixing are:
> - Create an explicit `.flyout` property, and make it so only one of `toolboxList` or `flyout` can be non-empty at all times (adding proper error checking throughout model as needed)
> - Create a different ListElement type for flyouts
>
>

Added an explicit flyout property (so that selected always holds a reference to a ListElement stored somewhere else) and made a new type for list elements (ListElement.TYPE_FLYOUT) for flyout list elements.

Comments from Reviewable

Review status: 0 of 5 files reviewed at latest revision, 13 unresolved discussions, some commit checks failed.

demos/blocklyfactory/workspacefactory/style.css, line 194 [r3] (raw file):

.dropdown-content label {
    color: black;

Nit: Indentation is off here and elsewhere in the file.

demos/blocklyfactory/workspacefactory/wfactory_controller.js, line 255 [r1] (raw file):
Previously, evd2014 (Emma Dauterman) wrote…
> Moved to a saveStateFromWorkspace method that's called whenever it's possible that the user updated the workspace.

Missing call to saveStateFromWorkspace here and below :)

demos/blocklyfactory/workspacefactory/wfactory_controller.js, line 295 [r3] (raw file):

FactoryController.prototype.printConfig = function() {
  // Capture any changes made by user before generating XML.
  this.model.getSelected().saveFromWorkspace(toolboxWorkspace);

saveStateFromWorkspace?

demos/blocklyfactory/workspacefactory/wfactory_generator.js, line 97 [r3] (raw file):

  *
  */
 FactoryGenerator.prototype.generateWorkspaceXml = function() {

Nit: Extra space in front of method name.

demos/blocklyfactory/workspacefactory/wfactory_model.js, line 24 [r3] (raw file):

  // Array of block IDs for all user created shadow blocks.
  this.shadowBlocks = [];
  // Currently selected ListElement. In toolboxList if there are categories, in

Nit: Awkward wording

demos/blocklyfactory/workspacefactory/wfactory_model.js, line 387 [r3] (raw file):

ListElement.prototype.saveFromWorkspace = function(workspace) {
  // Don't save anything from separators.
  if (this.type == ListElement.TYPE_SEPARATOR) {

Change it to explicitly check for CATEGORY and FLYOUT (in case you add more types visual types later).

demos/blocklyfactory/workspacefactory/wfactory_model.js, line 402 [r3] (raw file):

ListElement.prototype.changeName = function (name) {
  // Only update list elements that are categories.
  if (this.type == ListElement.TYPE_CATEGORY) {

This should be != right?

Comments from Reviewable

Review status: 0 of 5 files reviewed at latest revision, 13 unresolved discussions, some commit checks failed.

demos/blocklyfactory/workspacefactory/style.css, line 194 [r3] (raw file):
Previously, vicng wrote…
> Nit: Indentation is off here and elsewhere in the file.

Done.

demos/blocklyfactory/workspacefactory/wfactory_controller.js, line 255 [r1] (raw file):
Previously, vicng wrote…
> Missing call to saveStateFromWorkspace here and below :)

Replaced with a call to saveStateFromWorkspace()

demos/blocklyfactory/workspacefactory/wfactory_controller.js, line 295 [r3] (raw file):
Previously, vicng wrote…
> saveStateFromWorkspace?

Yep. Fixed.

demos/blocklyfactory/workspacefactory/wfactory_generator.js, line 97 [r3] (raw file):
Previously, vicng wrote…
> Nit: Extra space in front of method name.

Done.

demos/blocklyfactory/workspacefactory/wfactory_model.js, line 24 [r3] (raw file):
Previously, vicng wrote…
> Nit: Awkward wording

Better?

demos/blocklyfactory/workspacefactory/wfactory_model.js, line 387 [r3] (raw file):
Previously, vicng wrote…
> Change it to explicitly check for CATEGORY and FLYOUT (in case you add more types visual types later).

Done.

demos/blocklyfactory/workspacefactory/wfactory_model.js, line 402 [r3] (raw file):
Previously, vicng wrote…
> This should be != right?

Yes!! Thanks.

Comments from Reviewable

Review status: 0 of 5 files reviewed at latest revision, 13 unresolved discussions, some commit checks failed.

demos/blocklyfactory/workspacefactory/wfactory_controller.js, line 360 [r2] (raw file):
Previously, evd2014 (Emma Dauterman) wrote…
> Done.

Just pushed a version with this change.

Comments from Reviewable

Review status: 0 of 5 files reviewed at latest revision, 14 unresolved discussions, some commit checks failed.

demos/blocklyfactory/workspacefactory/wfactory_controller.js, line 254 [r4] (raw file):

  // Save workspace in current state.
  this.saveStateFromWorkspace();
  // Generate XML.

Nit: Line break

demos/blocklyfactory/workspacefactory/wfactory_model.js, line 24 [r3] (raw file):
Previously, evd2014 (Emma Dauterman) wrote…
> Better?

Better :)
Best would be to reference ivars with "this". eg. "this.toolboxList" and "this.flyout"

Comments from Reviewable

Review status: 0 of 5 files reviewed at latest revision, 14 unresolved discussions, some commit checks failed.

demos/blocklyfactory/workspacefactory/wfactory_controller.js, line 254 [r4] (raw file):
Previously, vicng wrote…
> Nit: Line break

Done.

demos/blocklyfactory/workspacefactory/wfactory_model.js, line 24 [r3] (raw file):
Previously, vicng wrote…
> Better :)
>
> Best would be to reference ivars with "this". eg. "this.toolboxList" and "this.flyout"

Got it, thanks. Fixed!

Comments from Reviewable

Review status: 0 of 5 files reviewed at latest revision, 14 unresolved discussions, some commit checks failed.

Comments from Reviewable


Swipe with JQuery Mobile

I cannot detect swipe on any of the elements...
$('.ekko-lightbox *').swiperight(function() {
alert('ekko swiped');
$('.ekko-lightbox-nav-overlay .glyphicon-chevron-left').trigger("click");
});
$('.ekko-lightbox *').swipeleft(function() {
alert('ekko swiped');
$('.ekko-lightbox-nav-overlay .glyphicon-chevron-right').trigger("click");
});
`

I figured out a way to do it:
$(this).ekkoLightbox({ onContentLoaded: function() {
$('').appendTo('body').show();
  $('.lightbox-swipe').swiperight(function() {
  $('.ekko-lightbox-nav-overlay .glyphicon-chevron-left').trigger("click");
});

$('.lightbox-swipe').swipeleft(function() {
$('.ekko-lightbox-nav-overlay .glyphicon-chevron-right').trigger("click");
});
}});

No that only worked on Desktop... either that or my cache on my phone is stuck...

weird.. worked on phone with wifi turned on.. must be caching somewhere..

Swipe is already built in, see _swipeGesure in the main JS file

Can I detect left and right swipe? Can you put a little more detail in the answer like a left an right swipe function with alert I could add to my javascript (not the ekko lightbox js) ?
I am using the 4.0.4 tree for Bootstrap 3 (I think that's why I have to use 4.0.4 can't remember which of your support comments said it but one said I needed 4.0.4 to make it work)
HOWEVER the solution I have works. OnContentLoaded I add a div to the body and position it fixed with the highest z-index so it is invisible and sits over the lightbox, and then I put the swipe on that.
It works. Just had to wait for the server to propagate the changes or something to clear cache. When I woke up today my solution worked.
So I am interested in your idea, but my solution works. I need JQuery Mobile Swipe for my other bootstrap carousels anyway. So, its not like its going anywhere.

http://davidgallo.unaomnia.com/category/concerts-and-events/
Here is what I am working on.. I also added custom buttons.

I just noticed my method covers the video though. So I am working on a way to handle that.. Have to get a cover behind the video..
Maybe your method would be better... I will wait to hear back and search around in the JS

My gosh I am sorry. I tried once more to target .ekko-lightbox for the JQuery Mobile swipeleft and swiperight functions and it worked.
http://davidgallo.unaomnia.com/category/concerts-and-events/
So now I have swipe, and can click the video to play it, and I also have custom buttons. Those are absolute positioned inside .ekko-lightbox wrapper div.
Was still hoping to get swipe to work if they went over where the video was... It works on the backdrop and on the images, but not if the swipe across the area with the video in it. But at least they can play. When they fullscreen Youtube and exit it stays in the lightbox, but when they do the same in a Vimeo video it closes the lightbox.
function dgEkkoLoad(){
	$(document).on('click', '[data-toggle="lightbox"]', function(event) {

            event.preventDefault();
            $(this).ekkoLightbox({ onContentLoaded: function() {

  var imgh = $(".ekko-lightbox-container").find("img").height();
  var winh = $(window).height();
  if ((imgh+0)>winh)
  {
    $(".ekko-lightbox-container").find("img").css("height",winh-50).css("width","auto").css("margin","0 auto");
  }

  var navForEkko = '

Close
';
		if(!$('.ekko-lightbox').hasClass('hasButtons')){
		$(navForEkko).appendTo('.ekko-lightbox');

$('.ekko-lightbox').addClass('hasButtons');
$('.dg-ekko-prev').on('click', function(){
$('.ekko-lightbox-nav-overlay .glyphicon-chevron-left').trigger("click");
});
		$('.dg-ekko-next').on('click', function(){
			$('.ekko-lightbox-nav-overlay .glyphicon-chevron-right').trigger("click");
		});

		$('.dg-ekko-close').on('click', function(){
			$('.ekko-lightbox .close').trigger("click");
		});

  $('.ekko-lightbox, .embed-responsive iframe').swiperight(function() {

  $('.ekko-lightbox-nav-overlay .glyphicon-chevron-left').trigger("click");
});

$('.ekko-lightbox, .embed-responsive iframe').swipeleft(function() {
  $('.ekko-lightbox-nav-overlay .glyphicon-chevron-right').trigger("click");

});
		}

}
});
        });

}
dgEkkoLoad();


bug: SQL injection works with heredoc, but now with nowdoc

Did you check existing issues?

[X] I have read all the tree-sitter docs if it relates to using the parser
[X] I have searched the existing issues of tree-sitter-php

Tree-Sitter CLI Version, if relevant (output of tree-sitter --version)
tree-sitter 0.22.5
Describe the bug
SQL is not recognized as such when enclosed in nowdoc.
Steps To Reproduce/Bad Parse Tree
      right: (nowdoc) ; [130:16 - 135:3]
       identifier: (heredoc_start) ; [130:20 - 22]
       value: (nowdoc_body) ; [130:24 - 134:1]
        (nowdoc_string) ; [131:1 - 24]
        (nowdoc_string) ; [131:25 - 132:22]
        (nowdoc_string) ; [132:23 - 133:18]
        (nowdoc_string) ; [133:19 - 134:1]
       end_tag: (heredoc_end) ; [134:2 - 135:3]

Expected Behavior/Parse Tree
      right: (nowdoc) ; [130:16 - 135:3]
       identifier: (nowdoc_start) ; [130:20 - 22]
       value: (nowdoc_body) ; [130:24 - 134:1]
        (statement) ; [131:1 - 133:18]
         (create_table) ; [131:1 - 133:18]
          (keyword_create) ; [131:1 - 6]
          (keyword_table) ; [131:8 - 12]
          (object_reference) ; [131:14 - 22]
           name: (identifier) ; [131:14 - 22]
          (column_definitions) ; [131:24 - 133:18]
           (column_definition) ; [132:5 - 20]
            name: (identifier) ; [132:5 - 7]
            type: (varchar) ; [132:9 - 20]
             (keyword_varchar) ; [132:9 - 15]
             size: (literal) ; [132:18 - 19]
           (column_definition) ; [133:5 - 12]
            name: (identifier) ; [133:5 - 7]
            type: (keyword_text) ; [133:9 - 12]
           (keyword_having) ; [133:14 - 17]
        (keyword_having) ; [134:1 - 1]
        (string_content) ; [131:1 - 24]
        (string_content) ; [132:1 - 22]
        (string_content) ; [133:1 - 18]
        (string_content) ; [134:1 - 1]
       end_tag: (nowdoc_end) ; [135:1 - 3]

Repro
// Example code that causes the issue
function foo() {
  // Code that fails to parse, or causes an error
        $sql = <<<'SQL'
CREATE TABLE dbal_1779 (
    foo VARCHAR (64) ,
    bar TEXT (100)
)
SQL;
}

Maybe the issue is that the tree shows heredoc_start and not nowdoc_start, if such a thing exists…

Maybe the issue is that the tree shows heredoc_start and not nowdoc_start

No that's not the issue, the Nowdoc reuses the same heredoc_{start,end} nodes

Issue is that the heredoc_end is sometimes including the whitespace:

However, does not seem to do this if there's a comma:


update readme

i would remove the python packages section entirely. it makes no sense ot have the information duplicated in the requirements file.

updated


Unable to create private endpoints in CLI using bash terminal

This is autogenerated. Please review and update as needed.
Describe the bug
Command Name
az network private-endpoint create
Errors:
request failed: Error occurred in request., RetryError: HTTPSConnectionPool(host='management.azure.com', port=443): Max retries exceeded with url: /subscriptions/b526aa26-e5c4-4583-90a3-6d0a4663242a/resourceGroups/rg-eu2-network/providers/Microsoft.Network/privateEndpoints/pe-eu2-iris-dev-006?api-version=2020-03-01 (Caused by ResponseError('too many 500 error responses',))

To Reproduce:
Steps to reproduce the behavior. Note that argument values have been redacted, as they may contain sensitive information.

Put any pre-requisite steps here...
az network private-endpoint create --name {} --resource-group {} --vnet-name {} --subnet {} --location {} --private-connection-resource-id {} --group-id {} --connection-name {} --tags {}

Expected Behavior
Environment Summary
Windows-10-10.0.17763-SP0
Python 3.6.6
Installer:

azure-cli 2.6.0

Extensions:
interactive 0.4.4

Additional Context

hi @MyronFanQiu, could you pls have a look?

add to S170

@lchave Hi, Are you targeting at Private Link Service? --group-id is not needed for private link service. Or do you have any name containing ' or "? Could you run the command with --debug?

@MyronFanQiu The group-id is just passing a variable defined in a previous step. When i run the --debug I see that the --private-connection-resource-id is sending the id with an \r at the end of it which is not added by us. The way we are getting the resource id is by running the az resource show and specifying the --query parameter to get the id. When I echo the variable defined to hold this ID it doesn't show the \r however, when calling the variable on the az network private-endpoint create it adds it. Any suggestions on this?

@lchave I see. Thanks for such useful information. @jiasli @zhoxing-ms Any idea?

Related issue: #13573

@lchave This problem seems to be related to Windows style newline characters, there is a similar problems here:
https://stackoverflow.com/questions/11616835/r-command-not-found-bashrc-bash-profile
Bash expects that end-of-line in a script is always and only a newline \n character, Unix-style, not a carriage return-newline combination \r\n like you normally see on Windows.
Bash thinks the \r character is just an ordinary character at the end of the string.
Could you try to execute the command dos2unix for the scripts executed in Windows?

Hello @lchave,

May I know the shell you are using, Mintty, Cygwin, MinGW? We haven't heard of this issue before with PowerShell on Windows or Bash on Linux. I doubt the output is not parsed correctly by the shell.
Could you share a full code snippet so that we can repro?

@jiasli I've tried on WSL, Bash & Git Bash terminals from Visual Studio on Windows. As per the code, if you can share your MS email I can send the code to reproduce it.
@zhoxing-ms this looks accurate, however, this command runs on files and I'm just trying to pass this variable within my code to complete deployments.

@lchave Hi, please send them to<EMAIL_ADDRESS>and<EMAIL_ADDRESS>thanks~

I have reproduced this problem in the WSL environment and identified the root cause:
The newline character in WSL is LF and the newline character in windows is CRLF. Therefore, when a script written under Windows is used in WSL, only \n in the newline character \r\n of CRLF is recognized as the newline character of LF, while \r is recognized as plain text.
For example:

Write a bash script in Windows, which is in CRLF format:
The script content:

group_name=$(az group show -n zhoxing-test --query name)
echo $group_name
az group create -l westus --debug -n $group_name

Execute the script in the WSL environment

root@DESKTOP-S8GCCTE:/mnt/c/Users/zhoxing.FAREAST/Desktop# file test.sh
test.sh: ASCII text, with CRLF line terminators

root@DESKTOP-S8GCCTE:/mnt/c/Users/zhoxing.FAREAST/Desktop# bash test.sh
"zhoxing-test"
Command arguments: ['group', 'create', '-l', 'westus', '--debug', '-n', '"zhoxing-test"\r\r']

At this point, the value of group_name is added with \r due to incompatibility between WSL and windows newline character.

Convert the file format from CRLF to LF and then execute the script

root@DESKTOP-S8GCCTE:/mnt/c/Users/zhoxing.FAREAST/Desktop# dos2unix test.sh
dos2unix: converting file test.sh to Unix format...

root@DESKTOP-S8GCCTE:/mnt/c/Users/zhoxing.FAREAST/Desktop# file test.sh
test.sh: ASCII text

root@DESKTOP-S8GCCTE:/mnt/c/Users/zhoxing.FAREAST/Desktop# bash test.sh
"zhoxing-test"
Command arguments: ['group', 'create', '-l', 'westus', '--debug', '-n', '"zhoxing-test"']

Problem solving after the file format becomes LF.
@lchave The same is true even if the value of the variable is not written directly in the file but is returned from a query (as the example I provided). So when using CRLF files in Unix and Unix-like Systems (including WSL), you need to convert the file to LF (you can use the command dos2unix)
For more information, please refer to: https://en.wikipedia.org/wiki/Newline

Because there is no reply to this question for a long time, I will close it temporarily. If you have any questions, please feel free to let us know.


[Bug] kubernetes application can't cancel job

Search before asking

[X] I had searched in the issues and found no similar issues.

Java Version
No response
Scala Version
2.11.x
StreamPark Version
2.1.1
Flink Version
1.14.4
deploy mode
kubernetes-application
What happened
Submitting job in the k8s application execution mode using streampark, the job cannot be cancelled (the streampark UI shows the job status as cancelled), but the actual k8s pod for the task is still present and jm的pod restarted
Error Exception
No response
Screenshots

Are you willing to submit PR?

[ ] Yes I am willing to submit a PR!(您是否要贡献这个PR?)

Code of Conduct

[X] I agree to follow this project's Code of Conduct

You can upgrade to version 2.1.2 and see if the issue still persists. Additionally, the feedback provided is incomplete. Could you please provide relevant log information from "log/streampark.out"?


Client Connection Parameters Doc Update

Re: Client Connection Parameters
Issue Description
This doc doesn't yet cover having multiple targets in the connection string. It just has one. But the connection string can not only handle multiple targets, it can load-balance between them with the right options.
Suggested Resolution
Need to add a section that talks about having multiple nodes/endpoints in the connection string. Plus add examples. For example, I was just working with someone who wanted their HAProxy to not be a single point of failure. So I suggested TWO HA proxy boxes, and then adding both to the JDBC connection string so that they can do maintenance. Or adding all of the nodes of a 6-node cluster to the JDBC connection string. We don't explain this yet.
Also should show the options for the multiple connection including loadBalanceHosts option as specified here: https://jdbc.postgresql.org/documentation/head/connect.html

cc @ericharmeling for triage.


override path defaults for FreeBSD

Sockets should go in /var/run and config files for non-base software in /usr/local/etc.
What type of PR is this?
/kind cleanup
What this PR does / why we need it:
This matches the socket paths used by my cri-o prototype on FreeBSD
Which issue(s) this PR fixes:
None
Special notes for your reviewer:
Does this PR introduce a user-facing change?
NONE

/ok-to-test
/lgtm
thanks!


Pass through additional JacksonXml annotations

See inferred/FreeBuilder#295

It looks like we should just pass through every annotation in this package (there's a fourth you missed?)

Would it be a bug if we copied everything in the package? I'd rather have less coupling to Jackson if possible...

IMO, no. Any annotation from com.fasterxml.jackson.dataformat.xml.annotation should be copied over to the generated code. I agree that explicitly whitelisting them isn't great.


Can't build with latest Meteor update (v1.4.2)

With the latest update to Meteor v.1.4.2, building an image gives an error that the build is running as root user.

You are attempting to run Meteor as the "root" user. If you are developing,
this is almost certainly not what you want to do and will likely result in
incorrect file permissions. However, if you are running this in a build process
(CI, etc.) or you are absolutely sure you know what you are doing, add the
--unsafe-perm flag to this command to proceed.

I have only FROM kadirahq/meteord:onbuild in my Dockerfile and I cannot seem to switch user, since the error occurs during the first steps.
Is there perhaps a workaround?
Edit: This might also be useful from the meteor repo
https://github.com/meteor/meteor/issues/7964

+1

+1

I'm having the same problem - trying to bypass the kadriq repo for now

There are a few alternatives to meteorD. See them here, and leave some feedback:
https://forums.meteor.com/t/docker-team-up-to-create-a-reference-docker-image-for-meteor/30829/3

+1

Thanks @keyscores using jshimko/meteor-launchpad and build my image on Quay.io solves the issue.

I still can't build in DockerHub with jshimko/meteor-launchpad? Can anyone else?

I can't either, so I just build it locally and push to dockerhub.

@tnargwoxow @Netherdrake  there is a new build for jshimko/meteor-launchpad since your last message.

@keyscores Thanks - strangely this one seems to respect my earlier preference of meteor version and installs <IP_ADDRESS> - that version doesn't contain the --unsafe-perms line and therefore the build fails. I'll raise it over there though


(chore): Added folder structure, libraries and files.

How are we going to bundle this for the PROD deployment ?

How are we going to bundle this for the PROD deployment ?


incorrect OSSL_CMP_MSG_update_recipNonce version number in 3.1 branch

BN_are_coprime                          5564	3_1_0	EXIST::FUNCTION:
OSSL_CMP_MSG_update_recipNonce          5565	3_0_9	EXIST::FUNCTION:CMP

It is expected in 3.1 branch function to be marked as 3_1_1.

Off topic
Once again OpenSSL team breaks binary compatibility. This is de facto standard for all releases since 1.1 nevertheless versioning policy.

Nope, this is not a bug. The function is present on 3.0 branch as well. The version string is correct.


Compiling Error

When I compile the lib with cuda-9.0, it poped up an error shown in log.txt. Could you advise? Thanks.

You can reference here to find solutions: detectron-tw, stan-dev470 stan-dev622 stan-dev561


adds 'insecureRegistries' to the helm chart

Description
Fixes https://github.com/aquasecurity/trivy-operator/issues/372 by adding ''trivy.insecureRegistry" to the helm chart
Related issues

Close #372

Remove this section if you don't have related PRs.
Checklist

[ x] I've read the guidelines for contributing to this repository.
[x ] I've updated the documentation with the relevant information (if needed).

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

@mauricewittek thank you for the contribution LGTM 🚀


Could not load type Microsoft.SharePoint.Administration.DesignPackageType

Details of the scenario you tried and the problem that is occurring
Getting the following error when trying to load the module with Import-Module Office365DSC -Verbose. This is due to multiple versions of the Microsoft.Online.SharePoint.PowerShell modules installed side-by-side.
VERBOSE: Loading module from path 'C:\Program Files\WindowsPowerShell\Modules\Office365DSC\1.0.0\Office365DSC.psd1'.
Import-Module : Could not load type 'Microsoft.SharePoint.Administration.DesignPackageType' from assembly
'Microsoft.SharePoint.Client, Version=<IP_ADDRESS>, Culture=neutral, PublicKeyToken=71e9bce111e9429c'.
Verbose logs showing the problem
VERBOSE: Loading module from path 'C:\Program Files\WindowsPowerShell\Modules\Office365DSC\1.0.0\Office365DSC.psd1'.
Import-Module : Could not load type 'Microsoft.SharePoint.Administration.DesignPackageType' from assembly
'Microsoft.SharePoint.Client, Version=<IP_ADDRESS>, Culture=neutral, PublicKeyToken=71e9bce111e9429c'.
Suggested solution to the issue
The DSC configuration that is used to reproduce the issue (as detailed as possible)
# insert configuration here

The operating system the target node is running

Version of the DSC module that was used ('dev' if using current dev branch)

Further investigation: It appears that version 16.0.8812.1200 of the module is causing issue. We should stick with version:
16.0.8316.0
We still need to work on a fix, or at least some better informative error message whenever a conflict in version is detected.

Fixed with the new Module manifest which now uses "Required Version" for module dependencies


deja/robot_name

Incorporated latest feedback and split into separate feature branch.

@DejaAugustine Great job on this exercise. This is one of the best solutions to this exercise I've seen. Take a look at my comments, and let me know your thoughts.
You are good on this exercise.


[21.11] Backport Firefox 102.0, 91.11.0esr, Spidermonkey 91.11.0

Backport #179322
Description of changes

Things done

Built on platform(s)

[ ] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
22.11 Release Notes (or backporting 22.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module
[ ] (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes

[x] Fits CONTRIBUTING.md.

Sorry, this was merged prematurely, based on a stale local branch. NSS is outdated and needs one more update, which I'll push in a few minutes.


How do I add a space between each element in a slide

If I add a padding or margin property to the slide, as shown in the red box in the image below, there is a blank space at the beginning and end.

How to add gaps while ensuring that there is no blank space on both sides？

@fatcarter add margin: 0 -{X}px; to slider; X should be same as gap between slider items

i need some help for problem too

This seems to work:
.carousel__slide {
  padding: 0 1rem;
}

It'd be nice if this library had something built in to add a gap, but this is the approach I took. We use tailwind in our project, so I've done my best to translate this to plain CSS.
Note, I'm using this in a component that has the Carousel as the only element in my
<style scoped>

.carousel {
    /* Make the width 100% plus the width of the gap between slides */
    width: calc(100% + 1.25rem);

    /* replace 0.625rem with half of the gap between slides */
    transform: translateX(-0.625rem)
}

/deep/ .carousel__slide {
    /* Once again, replace 0.625rem with half of the width you want the gap to be */
    padding-left: 0.625rem;
    padding-right: 0.625rem;
}
</style>

This approach removes the gap from the left and right sides of the carousel while adding space between slides. Some of the other solutions work, but at least when I tried them there was still extra space on the right side of my carousel.

@jaek-s Thats cool! It looks normal, but, actually it's wider than normal, it's just we can't see it, it works for me! Thank you

The easiest solution I found for it, is to use a margin to the slide and add a corresponding negative margin to the parent container.

It'd be nice if this library had something built in to add a gap, but this is the approach I took. We use tailwind in our project, so I've done my best to translate this to plain CSS.
Note, I'm using this in a component that has the Carousel as the only element in the <template>
<style scoped>

.carousel {
    /* Make the width 100% plus the width of the gap between slides */
    width: calc(100% + 1.25rem);

    /* replace 0.625rem with half of the gap between slides */
    transform: translateX(-0.625rem)
}

/deep/ .carousel__slide {
    /* Once again, replace 0.625rem with half of the width you want the gap to be */
    padding-left: 0.625rem;
    padding-right: 0.625rem;
}
</style>

This approach removes the gap from the left and right sides of the carousel while adding space between slides. Some of the other solutions work, but at least when I tried them there was still extra space on the right side of my carousel.

Thank you!!!!💪🏼


Slash Commands

Slash Commands Aren't Working, This is My console.

Can I Please Get Some Help? Thanks.

NameFlix.

before you post issues look at previous unsolved issues this has already been stated

This was fixed in the discord support server.


Rename ThirdPartyNotices

Docs Build status updates of commit 8df69cd:
:x: Validation status: errors
Please follow instructions here which may help to resolve issue.

File
Status
Preview URL
Details

:x:Error

Details

[Error] Cannot sync git repo to specified state. Please make sure the pull request is mergeable. Details: Git merge results in conflict, repository remote url: https://github.com/MicrosoftDocs/DocsLegal-pr.en-NZ, working directory: W:\2o24-s, target branch: HEAD, target branch commit: 83f8bbaf1191d11ab76d8c105b356ece7d59f0b1, source commit: 8df69cd7cf4e6692fae1437412ac06cc16ae990e.

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.

Docs Build status updates of commit 8436382:
:x: Validation status: errors
Please follow instructions here which may help to resolve issue.

File
Status
Preview URL
Details

:x:Error

Details

[Error] An exception occurred during the build process. Please check the raw log and retry building your content again. If the issue persists, please open a ticket in http://SiteHelp and include the URL of publishing report as well as below information: One or more errors occurred..

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.


Support Iceberg table format

What is the context for this pull request?

Tracking Issue: #306
Proposal: #318
Dependencies: #355
Fixes: #306
Fixes: #318
Closes: #321
Closes: #320

What changes were proposed in this pull request?
This PR adds support for Iceberg.
The following changes are in this PR and each of them are separate commits:

Add Iceberg source.
Add support for incremental refresh. This is based on #301 PR from @sezruby.
Add integration test

Does this PR introduce any user-facing change?
No. The main changes to user-facing APIs are in the #321 PR. Detailed information can be found in the #318 proposal.
How was this patch tested?

Integration test added for the new functionality
Locally & Databricks Runtime tests

Local build

sbt publishLocal

Run Spark shell with Hyperspace and Iceberg libraries loaded

$ spark-shell \
--driver-memory 4g \
--packages "com.microsoft.hyperspace:hyperspace-core_2.11:0.4.0-SNAPSHOT,org.apache.iceberg:iceberg-spark-runtime:0.10.0" \
--driver-java-options "-agentlib:jdwp=transport=dt_socket,server=y,suspend=n,address=5006 -XX:+UseG1GC -Dlog4j.debug=true"

Paste the following code

import org.apache.spark.sql._
import com.microsoft.hyperspace._
import com.microsoft.hyperspace.index._
import scala.collection.JavaConverters._
import org.apache.iceberg.PartitionSpec
import org.apache.iceberg.TableProperties
import org.apache.iceberg.spark._
import org.apache.iceberg.hadoop._

val hs = new Hyperspace(spark)

// create Iceberg table
val props = Map(TableProperties.WRITE_NEW_DATA_LOCATION -> "table3").asJava
val sourceDf = Seq((1, "name1"), (2, "name2")).toDF("id", "name")
val schema = SparkSchemaUtil.convert(sourceDf.schema)
val part = PartitionSpec.builderFor(schema).build()
val icebergTable = new HadoopTables().create(schema, part, props, "table3")
sourceDf.write.mode("overwrite").format("iceberg").save("./table3")

// read created table
val iceDf = spark.read.format("iceberg").load("./table3")

// create indexes
hs.createIndex(iceDf, IndexConfig("index_ice0", indexedColumns = Seq("id"), includedColumns = Seq("name")))
hs.createIndex(iceDf, IndexConfig("index_ice1", indexedColumns = Seq("name")))

// verify plans
val query = iceDf.filter(iceDf("id") === 1).select("name")
hs.explain(query, verbose = true)

@imback82 I closed the #321, #320 PRs which were obsolete after your refactoring work on #355 - thanks for it. Please review this PR that adds support for Iceberg table format.

@sezruby The test for hybrid scan is in the IcebergIntegrationTest lines 299-338.

@sezruby The test for hybrid scan is in the IcebergIntegrationTest lines 299-338.

Yes, but we need to verify the exact plan transformation and the result of query.

@sezruby I did take the Delta Lake hybrid test and modified it for Iceberg. That is what is in the integration test from line 299 to 338. Is there other hybrid test for Delta Lake that I missed?

@andrei-ionescu There's another test set:
https://github.com/microsoft/hyperspace/blob/master/src/test/scala/com/microsoft/hyperspace/index/HybridScanForDeltaLakeTest.scala
based on https://github.com/microsoft/hyperspace/blob/master/src/test/scala/com/microsoft/hyperspace/index/HybridScanSuite.scala

@sezruby I added HybridScanForIcebergTest.scala. Please have another look.

@sezruby

For start & end snapshot id test, I'd just like to check the use case & how those configs work well (or not well) with Hyperspace.

Is there such check for Delta so that I could inspire from?

@andrei-ionescu No, not sure Delta has the feature.
How about this?

build test data

snapshot 1) add a row with value 1 (append 1 file)
snapshot 2) add a row with value 2 (append 1 file)
snapshot 3) add a row with value 3 (append 1 file)
snapshot 4) add a row with value 4 (append 1 file)
snapshot 5) add a row with value 5 (append 1 file)

build index with df with start-snapshot-id 2, end-snapshot-id 4

query with df with start-snapshot-id 2, end-snapshot-id 4 w/o hybrid scan
query with df with start-snapshot-id 3, and check w/ hybrid scan
query with df with end-snapshot-id 3, and check w/ hybrid scan

@sezruby I'll try to see it is possible but from my knowledge on Iceberg I don't think this kind of test is possible. The snapshot ids are used for time travel and to isolate date at read time. A snapshot is a sort of full image of the dataset -- is not a delta from the previous. This is a bit different than Delta.
Delta has the same parameter under versionAsOf. If there are tests to validate the functionality of Delta with time travel I'll do my best add it to Iceberg too although the implementation is a bit different.
Otherwise I would suggest to have a separate PR with time travel for Iceberg.

@andrei-ionescu I guess versionAsOf of Delta Lake is the same as Iceberg only with end-snapshot-id.
But both start-snapshot-id or end-snapshot-id handles "delta" dataset between two snapshots, right?
Hybrid scan will work w/o any link of version info - it utilizes the list of source files from DataFrame.
For time travel query optimization, to pick a proper version of index (after some refresh),
I added version history info to link delta version and index version in #272.

@sezruby: I refactored it a bit and it is no longer needed to have knowledge of start-snapshot-id, end-snapshot-id and other internal Iceberg properties.

LGTM thanks @andrei-ionescu!

@rapoth, @imback82, @sezruby: The PR has 2 LGTMs already - thanks @imback82 & @sezruby. What's the process? What next steps are ahead to have it merged and complete the feature?

Let me take a final look since there were some changes since my last LGTM.

@andrei-ionescu Can you do a follow up PR to address https://github.com/microsoft/hyperspace/pull/358#discussion_r580425973? Thanks!

@imback82: I create #362 to address the doc comment.
@imback82, @sezruby, @rapoth: Thanks for help with this PR & feature.

It has been a fantastic collaboration so far and I have personally learned a lot in the process! Thank you @andrei-ionescu! 🙂

Thanks for the work @andrei-ionescu!
Could you also simply update the user document if possible?
ref: https://microsoft.github.io/hyperspace/docs/ug-supported-data-formats/
https://github.com/microsoft/hyperspace/blob/master/docs/_docs/08-ug-supported-data-formats.md


Fix host_height, host_timestamp return value

Closes: #242
Description

PR author checklist:

[x] Added changelog entry, using unclog.
[ ] Added tests.
[x] Linked to GitHub issue.
[ ] Updated code comments and documentation (e.g., docs/).
[ ] Tagged one reviewer who will be the one responsible for shepherding this PR.

Reviewer checklist:

[ ] Reviewed Files changed in the GitHub PR explorer.
[ ] Manually tested (in case integration/unit/mock tests are absent).

Also, now that #241 is merged, could you apply the same change to ValidationContext?

Also, now that #241 is merged, could you apply the same change to ValidationContext?

Done


.transition() is not a function

does not work with .transition()
when library included, .transition is not a function

This sounds like a problem with how you are bundling your code.
The .transition function is added to the selection prototype when you import d3-transition.

Hello, this error occurred when I also did this version-up from 1.4.1 to 1.4.2.
(Note that Github's d3-selection has a release of 1.4.1 and 1.4.2 is present at NPM.)
This error was resolved when I ran yarn upgrade or yarn upgrade d3-selection.


Floating point exception: 8

INDEXING: 231000000 points processed; 231000000 points written; 348.893 seconds passed INDEXING: 232000000 points processed; 232000000 points written; 350.284 seconds passed INDEXING: 233000000 points processed; 233000000 points written; 351.352 seconds passed Floating point exception: 8
PotreeConverter returns to prompt with this error. My LAZ file is 1,17GB, is it too big?
This is on OSX btw.

Nevermind, i tried on linux which crashed with exactly the same message. Seems now my file is incomplete. Closing issue.


[AutoPR monitor/resource-manager] updated description of recurrent frequency

Created to sync https://github.com/Azure/azure-rest-api-specs/pull/3468

(message created by the CI based on PR content)

This PR has been merged into https://github.com/Azure/azure-sdk-for-python/pull/2761


Create new order

Oh yes I did.
You can now build and save an order.  Some basic quantity checking takes place but it could probably be a bit more robust.
The seed file was modified to create a random number of orders for various organizations.


Output code-block highlighting

so that
/run csharp md

would result in
 return (
            introduction
            + '```md\n'
            + output.replace('\0', '')
            + '```'
        )

so we can format de output generated by the program. json or yaml would be good use cases too.

Pretty sure that would be rarely needed. When are you ever outputting these formats?
Also I am scared of no man, but this thing - it scares me.
Jokes aside if someone wants to make it work and implement this be my guest.

Implemented by the previous merge using the /run [lang] -> [output syntax] syntax.


show layout property in flexbox align tool

follow up on #36, right now the function handles hover/click events and gets the computed property, maybe need an observer or callback later for styles changes during data-selected.

nice! looks great so far 💯
observers are watching and ready for hooks to update label text, i tested out locally and these changes worked out well. thoughts?
// selectable.js
const setLabel = (el, label) => {
  label.text = handleLabelText(el, visbug.activeTool)
  label.update = {boundingRect: el.getBoundingClientRect(), isFixed: isFixed(el)}
}

// label.element.js
set text(content) {
  this.$shadow.childElementCount
    ? this.$shadow.firstElementChild.textContent = content
    : this._text = content
}

oh, that makes sense.

Rendered output for reference:

index.html


simplify load image

decode_image can handle different formats and allows to direclty specify channels and dtype

Did you test this? I don't see the dtype option in the docs.
https://www.tensorflow.org/api_docs/python/tf/io/decode_jpeg

Did you test this? I don't see the dtype option in the docs.
https://www.tensorflow.org/api_docs/python/tf/io/decode_jpeg

Yes. Pls note that I am using https://www.tensorflow.org/api_docs/python/tf/io/decode_image

Did you test this? I don't see the dtype option in the docs.
https://www.tensorflow.org/api_docs/python/tf/io/decode_jpeg

Yes. Pls note that I am using https://www.tensorflow.org/api_docs/python/tf/io/decode_image

Makes sense. Thanks!


⚠ Ansible Galaxy API has degraded performance

In 2b96723, Ansible Galaxy API (https://galaxy.ansible.com/api/v2/) experienced degraded performance:

HTTP code: 200
Response time: 3455 ms

Resolved: Ansible Galaxy API performance has improved in 465b2ad.


Add required fields to build nuspec

These required fields are missing from the .Build nuspec, and this is blocking package upload.

Actually I'm going to merge this right away so we can be ready with builds ASAP.
Regarding @Suchiman's suggestion about project URL, if @rynowak thinks the change is valid we can do it after.
Regarding the AppVeyor failure, this is bogus. It's annoying that this one test is flaky - I have looked at it, and it's unclear from the sources what's different compared with other tests. And the failure only seems to happen on AppVeyor. If this continues I will have to do something about it, but not blocking this PR on it as it's unrelated.


Add doctor-visits data anomaly once deployed

see https://github.com/cmu-delphi/www-covidcast/pull/1080/commits/5b77e4f6cda4660af3a357d36779376d67332891 where the temporary one has been removed again

I need some text to fill out the doctor-visit uncertainty data anomaly:

published: TRUE
problem: ??
explanation: ??
source: doctor-visits
signals: smoothed_adj_cli
dates: -10
regions: nation();state();county();hrr()

@ryantibs suggestions?

Sharing Ryan's request for example texts, and what they look like on the screen.

it will look similar to

and closer like in the PR:
https://github.com/cmu-delphi/www-covidcast/pull/1080

Thanks.  It looks like we use "Title Caps" for the problem field so we could change it to that, but other than that I think it should be fine. If you could get us a preview of how it looks for us to see, all put together, before merging, then that would be great.

@sgratzl Do you need anything more from me on this one? As I said in my last comment, if you have a PR and can show us a preview then that would be great.

it depends on #1106 and that @krivard is approving my change in https://docs.google.com/spreadsheets/d/1w3jzNizh7rBkl1P-ikXa_GW2m_tRmV97eN7naOIR6jA/edit#gid=0

current dev version: https://dev--cmu-delphi-covidcast.netlify.app/indicator/?sensor=doctor-visits-smoothed_adj_cli


does not understand prerelease extensions to the version number

Hi,
when i set "1.0.0-pre1" as the nuget version, this action correctly detects the change, but publishes the nuget package with version 1.0.0 instead of 1.0.0-pre1 (whatever is after the dash means it is a prerelease package).
Any idea how to fix ?

Did you update the version of your project? The action just runs dotnet pack & publishes the nupkg file so the version is just picked up from the filename. I need the action log to help you

Closing due to inactivity, reopen if needed

Still not working. Reopen.

Help me to help you by sharing the failed action log to see more details


fix: potential security issues

"Potentially unsafe external link" of TOS and EMail Links: no real threat as links lead to ZITADEL itself and noopener is now default in current browser versions
"Size computation for allocation may overflow" in internal crypto pkg: no real threat either, but fixed nonetheless by limiting AES encryption to 64MB

:tada: This PR is included in version 0.116.10 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


Question about versioning

How would one introduce versioning to the framework of Definitions, Assignments, and initiatives?

Since you are using a sorce code repository as the source, it would contain the version history.
If you're asking, how can I tell in Azure what version something was built-on: one could add a version to the metadata (all Azure Policy objects have a metadata element (JSON based)).
The version metadata could be auto injected from the script. This is not currently a capability.

Since you are using a source code repository as the source, it would contain the version history.
If you're asking, how can I tell in Azure what version something was built-on: one could add a version to the metadata (all Azure Policy objects have a metadata element (JSON based)).
The version metadata could be auto injected from the script.

Yeah I was maybe asking more about telling and recording what version something was built-on like if we have a policy that had v.1.0 then it would be changed or modified with new features etc, and then it would be v.2.0, we could then gradually move over to that policy instead of all assignments, or initiatives that have this policy would use the new version right away.

I would avoid that pattern, especially for built-ins (they fix bugs when creating an updated version). Locking in a specific Version would require a Policy engine change.


ci: run fuzz tests on every PR

Testing

Run all tests nightly
Run fuzz tests as an optional check on PRs

Test succeeded b/c https://github.com/rootulp/celestia-app/actions/runs/6881529597/job/18718067903?pr=45


Failed to run custom build command

I had followed the developer instructions to install from TPS Cube - psifertex
The last step did not work for me

make native

Here's the terminal output.
Compiling sdl2-sys v0.34.5
error: failed to run custom build command for sdl2-sys v0.34.5
Caused by:
process didn't exit successfully: /Users/et/Code/tpscube/target/release/build/sdl2-sys-56ab4890b5991f10/build-script-build (exit status: 101)

@ParadyNexus
I had the same on Mac OS:
Here's how I solved it:
Install sdl2 on MacOS using the official docs:
brew install sdl2

# add this line to your ~/.zshenv or ~/.bash_profile depending on whether you use ZSH or Bash.
export LIBRARY_PATH="$LIBRARY_PATH:$(brew --prefix)/lib"

# close and reopen terminal to reload ENV variables

# in `Cargo.roml` change replace this:
sdl2 = { version="0.34", features=["bundled", "static-link"] }
# with this to use the local `sdl2` installation:
sdl2 = { version="0.34"}

# build again
make native