Increase Metropolitan reingestion timeout

Description

We have a number of failures in the metropolitan_reingestion_workflow caused by AirflowTaskTimeouts during the pull_data step. From first glance, it appears the affected tasks actually are ingesting an unusually large amount of data.
We should consider increasing the timeout here.
We should also consider increasing the DagRun timeout.
Additional context

We should investigate failed tasks to make sure there's nothing else going on, since this DAG does typically complete very quickly. These likely are genuinely days with a disproportionate amount of data, but we can verify by trying to run the DAG locally for the affected dates using the conf option described in #880.

While investigating this, I noticed that the Metropolitan reingestion flow is exceeding its dagrun_timeout of 23 hours and skipping many of its reingestion tasks. I was about to make a separate issue for this, but after looking a little closer I think it may actually be the cause of this issue.
The task timeout for the pull_data task for Met is currently 16 hours, but glancing through the logs for the most recent pull_data timeout failures show that they timed out after only 12 hours (although 16 hrs is correctly configured in the Task Instance Details). I think it's possible the tasks are timing out early when the entire DAG times out at 23 hours. We should be able to verify this, but I've removed the help wanted label as this will require investigating the logs in production.
Since the metropolitan reingestion workflow is run @weekly, we can increase the dagrun timeout. Alternatively we should consider reducing the number of reingestion tasks so that it can be completed within the 23hour timeframe, and then update the schedule to @daily.


Markdown serving issue

1. What version of Caddy are you running (caddy -version)?
Caddy 0.9.3
2. What are you trying to do?
Render README.md from https://github.com/mholt/caddy/blob/master/dist/init/README.md as http://localhost:8080/README.md
3. What is your entire Caddyfile?
http://*:8080
root init/

markdown /
browse /

filemanager /_fileman {
    show init/
    allow_commands false
    allow_edit true
    allow_new true
}

4.  What did you expect to see?
markdown processed README.md
6. What did you see instead (give full error messages and/or log)?
plaintext README.md
7. How can someone who is starting from scratch reproduce this behavior as minimally as possible?
caddy release + filemanager and the included init/README.md
If I make a copy of README.md to readme.md, that works correctly

I'm gonna go out on a limb and ask if you're sure you've cleared your browser cache? Try curl...

I would've thought that I checked it, but maybe that was it because I cannot reproduce. I was assuming that maybe markdown and browse aren't meant to work together, but apparently they are supported in combination?

Yep, totally should work. :) Glad it's fixed for ya now!


Params return error

Resolves #20

Codecov Report

Merging #22 into master will increase coverage by 0.53%.
The diff coverage is 81.81%.

@@            Coverage Diff             @@
##           master      #22      +/-   ##
==========================================
+ Coverage    83.5%   84.03%   +0.53%
==========================================
  Files          10       10
  Lines        1079     1090      +11
==========================================
+ Hits          901      916      +15
+ Misses        139      137       -2
+ Partials       39       37       -2

Impacted Files
Coverage Δ

phono.go
50% <0%> (-0.85%)
:arrow_down:

track/track.go
96.74% <100%> (+0.02%)
:arrow_up:

pipe/pipe.go
78.63% <100%> (+1.77%)
:arrow_up:

mock/mock.go
87.5% <75%> (-0.74%)
:arrow_down:

pipe/state.go
85.86% <0%> (+0.52%)
:arrow_up:

mixer/mixer.go
100% <0%> (+2.38%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a8e70fe...de0cb7f. Read the comment docs.

Not needed.


nginx-ingress-integrator fails in arm64 architecture

Bug Description
nginx-ingress-integrator does not work in arm64 architecture. This happens in stable and edge channels.
The error is: ImportError: /var/lib/juju/agents/unit-nginx-ingress-integrator-0/charm/venv/cryptography/hazmat/bindings/_rust.abi3.so: cannot open shared object file: No such file or directory
To Reproduce
Deploy nginx-ingress-integrator in an existing model, with a constraint for arm64 architecture.
ubuntu@netbox:~$ juju deploy nginx-ingress-integrator --trust --constraints "arch=arm64"

Environment
I am using MicroK8S 1.30-strict/stable and Juju 3.5.2.
It happens at least stable and edge channels for nginx-ingress-integrator
Relevant log output
ubuntu@netbox:~$ juju debug-log --replay --include nginx-ingress-integrator
unit-nginx-ingress-integrator-0: 08:50:46 INFO juju.cmd running containerAgent [3.5.3 63d460f9ee6c7c710131961390687e7a0ab90470 gc go1.21.12]
unit-nginx-ingress-integrator-0: 08:50:46 INFO juju.cmd.containeragent.unit start "unit"
unit-nginx-ingress-integrator-0: 08:50:46 INFO juju.worker.upgradesteps upgrade steps for 3.5.3 have already been run.
unit-nginx-ingress-integrator-0: 08:50:46 INFO juju.worker.probehttpserver starting http server on <IP_ADDRESS>:65301
unit-nginx-ingress-integrator-0: 08:50:46 INFO juju.api connection established to "wss://controller-service.controller-microk8s.svc.cluster.local:17070/model/6466ba98-1f87-4189-85ba-2f5ca72218a1/api"
unit-nginx-ingress-integrator-0: 08:50:46 INFO juju.worker.apicaller [6466ba] "unit-nginx-ingress-integrator-0" successfully connected to "controller-service.controller-microk8s.svc.cluster.local:17070"
unit-nginx-ingress-integrator-0: 08:50:46 INFO juju.api connection established to "wss://controller-service.controller-microk8s.svc.cluster.local:17070/model/6466ba98-1f87-4189-85ba-2f5ca72218a1/api"
unit-nginx-ingress-integrator-0: 08:50:46 INFO juju.worker.apicaller [6466ba] "unit-nginx-ingress-integrator-0" successfully connected to "controller-service.controller-microk8s.svc.cluster.local:17070"
unit-nginx-ingress-integrator-0: 08:50:46 INFO juju.worker.migrationminion migration migration phase is now: NONE
unit-nginx-ingress-integrator-0: 08:50:46 INFO juju.worker.logger logger worker started
unit-nginx-ingress-integrator-0: 08:50:46 WARNING juju.worker.proxyupdater unable to set snap core settings [proxy.http= proxy.https= proxy.store=]: exec: "snap": executable file not found in $PATH, output: ""
unit-nginx-ingress-integrator-0: 08:50:46 INFO juju.worker.caasupgrader abort check blocked until version event received
unit-nginx-ingress-integrator-0: 08:50:46 INFO juju.worker.caasupgrader unblocking abort check
unit-nginx-ingress-integrator-0: 08:50:46 INFO juju.worker.leadership nginx-ingress-integrator/0 promoted to leadership of nginx-ingress-integrator
unit-nginx-ingress-integrator-0: 08:50:46 INFO juju.agent.tools ensure jujuc symlinks in /var/lib/juju/tools/unit-nginx-ingress-integrator-0
unit-nginx-ingress-integrator-0: 08:50:46 INFO juju.worker.uniter unit "nginx-ingress-integrator/0" started
unit-nginx-ingress-integrator-0: 08:50:46 INFO juju.worker.uniter resuming charm install
unit-nginx-ingress-integrator-0: 08:50:46 INFO juju.worker.uniter.charm downloading ch:arm64/focal/nginx-ingress-integrator-111 from API server
unit-nginx-ingress-integrator-0: 08:50:46 INFO juju.downloader downloading from ch:arm64/focal/nginx-ingress-integrator-111
unit-nginx-ingress-integrator-0: 08:50:46 INFO juju.downloader download complete ("ch:arm64/focal/nginx-ingress-integrator-111")
unit-nginx-ingress-integrator-0: 08:50:47 INFO juju.downloader download verified ("ch:arm64/focal/nginx-ingress-integrator-111")
unit-nginx-ingress-integrator-0: 08:56:42 INFO juju.worker.uniter hooks are retried true
unit-nginx-ingress-integrator-0: 08:56:42 INFO juju.worker.uniter found queued "install" hook
unit-nginx-ingress-integrator-0: 08:56:45 WARNING unit.nginx-ingress-integrator/0.install Traceback (most recent call last):
unit-nginx-ingress-integrator-0: 08:56:45 WARNING unit.nginx-ingress-integrator/0.install   File "./src/charm.py", line 14, in <module>
unit-nginx-ingress-integrator-0: 08:56:45 WARNING unit.nginx-ingress-integrator/0.install     from charms.tls_certificates_interface.v3.tls_certificates import (
unit-nginx-ingress-integrator-0: 08:56:45 WARNING unit.nginx-ingress-integrator/0.install   File "/var/lib/juju/agents/unit-nginx-ingress-integrator-0/charm/lib/charms/tls_certificates_interface/v3/tls_certificates.py", line 289, in <module>
unit-nginx-ingress-integrator-0: 08:56:45 WARNING unit.nginx-ingress-integrator/0.install     from cryptography import x509
unit-nginx-ingress-integrator-0: 08:56:45 WARNING unit.nginx-ingress-integrator/0.install   File "/var/lib/juju/agents/unit-nginx-ingress-integrator-0/charm/venv/cryptography/x509/__init__.py", line 7, in <module>
unit-nginx-ingress-integrator-0: 08:56:45 WARNING unit.nginx-ingress-integrator/0.install     from cryptography.x509 import certificate_transparency, verification
unit-nginx-ingress-integrator-0: 08:56:45 WARNING unit.nginx-ingress-integrator/0.install   File "/var/lib/juju/agents/unit-nginx-ingress-integrator-0/charm/venv/cryptography/x509/certificate_transparency.py", line 11, in <module>
unit-nginx-ingress-integrator-0: 08:56:45 WARNING unit.nginx-ingress-integrator/0.install     from cryptography.hazmat.bindings._rust import x509 as rust_x509
unit-nginx-ingress-integrator-0: 08:56:45 WARNING unit.nginx-ingress-integrator/0.install ImportError: /var/lib/juju/agents/unit-nginx-ingress-integrator-0/charm/venv/cryptography/hazmat/bindings/_rust.abi3.so: cannot open shared object file: No such file or directory

Additional context
No response

@weiiwang01 Can you have a look if this is easily fixable, please?

arm64 is already working.


Delete FONTNAME (Regular) in the registry upon installation

Fonts in Windows should not use the (Regular) name, but when a font is manually installed by drag&dropping it into the Fonts applet, it can still happen that Windows registered the font as such.
This can than collide with the correct font registration that does not use (Regular).

Will be fixed in v1.4.2

Updated setup released, closing issue.


Issue #1117: handle race in concurrent bundle split

Motivation
in NamespaceService.splitAndOwnBundle().
The concurrent update of Policies of same namespace will cause some override to bundles value that kept in Zookeeper. And this involves at least 2 rounds of split.
e.g.

At beginning, we have 2 bundles, with partitions:[0x00000000, 0x7fffffff, 0xffffffff],
First round of split: We will split the 2 bundles at the same time. In first bundle split, the NamespaceBundles value that returned by NamespaceBundleFactory.splitBundles() would be:
[0x00000000, 0x3fffffff, 0x7fffffff, 0xffffffff];
while at the same time, the NamespaceBundles value for second bundle split would be:
[0x00000000, 0x7fffffff, 0xbfffffff, 0xffffffff]
Then the 2 split operations, whoever success updateNamespaceBundles last, will override the former one.
Here if second split finally success,  it will override the former success value [0x00000000, 0x3fffffff, 0x7fffffff, 0xffffffff], and the final bundles partitions would be:  [0x00000000, 0x7fffffff, 0xbfffffff, 0xffffffff];  But we thought it should be [0x00000000, 0x3fffffff, 0x7fffffff, 0xbfffffff,  0xffffffff];
Second round split:  e.g. try to split to range [0x00000000, 0x3fffffff], it will not find upper boundary 0x3fffffff in actual [0x00000000, 0x7fffffff, 0xbfffffff, 0xffffffff].
And  this will cause the error:

 java.lang.IllegalArgumentException: Invalid upper boundary for bundle  at com.google.common.base.Preconditions.checkArgument(Preconditions.java:122)

Modifications

Add version in NamespaceBundles,  when update the zookeeper z-node, verify the version, and do read-modify-write retry when there are simultaneous write to the z-node.
Add test for it.

Result
No user behavior will change. This concurrent bug fixed.
Fixes #1117

Thanks @merlimat @rdhabalia for your comments, changed it and rebased to catch up master.

retest this please

retest this please

@zhaijack Please merge with master that has fix for a very flaky test.
Also it appears there's a test that might be genuiniley failing:
https://builds.apache.org/job/pulsar-pull-request/2290/org.apache.pulsar$pulsar-broker/testReport/org.apache.pulsar.broker.service/BrokerServiceTest/testCreateNamespacePolicy/
I don't remember having seen that test failing before.

@merlimat thanks, will handle it now

@merlimat , test fail because of wrongly removed getData in LocalZooKeeperCacheService in commit 2f1e6e1, added it back.

retest  this please


Update version number in app and changelog

Codecov Report

Merging #210 into master will not change coverage.
The diff coverage is 100%.

@@           Coverage Diff           @@
##           master     #210   +/-   ##
=======================================
  Coverage   99.16%   99.16%
=======================================
  Files           8        8
  Lines         481      481
=======================================
  Hits          477      477
  Misses          4        4

Impacted Files
Coverage Δ

app/__init__.py
100% <100%> (ø)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 944db31...08aeb77. Read the comment docs.


CMake npm install function ignores package.lock file in Apps folder

If you run cmake at the time of writing, it will pull 6.11.2.
But, if you run npm install, it will use 6.4.1.

@CedricGuillemet This is because we are ignoring the lock file in the npm install function.

Yes, it's explicit in the command line to not use the package lock.
Does it make sense to remove package lock in the repo?

Why not use the package lock file? Usually this is kind of an anti pattern since build behavior can change without making any changes to any files in the repo.

We should use the package lock file here. I added it for a different purpose for JsRuntimeHost.

Fixed with https://github.com/BabylonJS/BabylonNative/pull/1260


Describe py3 requirement of use_openmetrics option

Found while QA-ing https://github.com/DataDog/integrations-core/pull/9613/files

Needs syncing


gpt-neox-20b_peft/merge_peft_adapter.py script fails

I've been trying to run the script examples/sentiment/scripts/gpt-neox-20b_peft/merge_peft_adapter.py. It fails with this full traceback:
$ accelerate launch scripts/gpt-neox-20b_peft/merge_peft_adapter.py

===================================BUG REPORT===================================
Welcome to bitsandbytes. For bug reports, please run

python -m bitsandbytes

 and submit this information together with your error trace to: https://github.com/TimDettmers/bitsandbytes/issues
================================================================================
bin /home/calkin0j/.local/lib/python3.10/site-packages/bitsandbytes/libbitsandbytes_cuda112.so
CUDA SETUP: CUDA runtime path found: /usr/lib/x86_64-linux-gnu/libcudart.so.11.0
CUDA SETUP: Highest compute capability among GPUs detected: 8.0
CUDA SETUP: Detected CUDA version 112
CUDA SETUP: Loading binary /home/calkin0j/.local/lib/python3.10/site-packages/bitsandbytes/libbitsandbytes_cuda112.so...
Traceback (most recent call last):
  File "/home/calkin0j/.local/lib/python3.10/site-packages/peft/tuners/lora.py", line 278, in __getattr__
    return super().__getattr__(name)  # defer to nn.Module's logic
  File "/home/calkin0j/.local/lib/python3.10/site-packages/torch/nn/modules/module.py", line 1614, in __getattr__
    raise AttributeError("'{}' object has no attribute '{}'".format(
AttributeError: 'LoraModel' object has no attribute '_get_submodules'

During handling of the above exception, another exception occurred:

Traceback (most recent call last):
  File "/home/calkin0j/trl/examples/sentiment/scripts/gpt-neox-20b_peft/merge_peft_adapter.py", line 39, in <module>
    parent, target, target_name = model.base_model._get_submodules(key)
  File "/home/calkin0j/.local/lib/python3.10/site-packages/peft/tuners/lora.py", line 280, in __getattr__
    return getattr(self.model, name)
  File "/home/calkin0j/.local/lib/python3.10/site-packages/torch/nn/modules/module.py", line 1614, in __getattr__
    raise AttributeError("'{}' object has no attribute '{}'".format(
AttributeError: 'GPTNeoForCausalLM' object has no attribute '_get_submodules'. Did you mean: 'get_submodule'?
Traceback (most recent call last):
  File "/home/calkin0j/.local/bin/accelerate", line 8, in <module>
    sys.exit(main())
  File "/home/calkin0j/.local/lib/python3.10/site-packages/accelerate/commands/accelerate_cli.py", line 45, in main
    args.func(args)
  File "/home/calkin0j/.local/lib/python3.10/site-packages/accelerate/commands/launch.py", line 918, in launch_command
    simple_launcher(args)
  File "/home/calkin0j/.local/lib/python3.10/site-packages/accelerate/commands/launch.py", line 580, in simple_launcher
    raise subprocess.CalledProcessError(returncode=process.returncode, cmd=cmd)
subprocess.CalledProcessError: Command '['/usr/local/bin/python3.10', 'scripts/gpt-neox-20b_peft/merge_peft_adapter.py']' returned non-zero exit status 1.

Any fix?

Hi @ckinateder
Thanks for the issue!
I think that you are using an outdated version of the merging script. Please pull the latest version of the merging script: https://github.com/lvwerra/trl/blob/main/examples/stack_llama/scripts/merge_peft_adapter.py and make sure you are using at least peft==0.3.0 and re-run the script.
Thanks!

Thanks for the quick response @younesbelkada. Should the merge script for the gpt-neox-20b_peft example be the same as the one in the stack_llama example?

Hi @ckinateder
No worries! I believe that you just need to provide the correct paths to the respective adapter and base models
--adapter_model_name and --base_model_name and it should work properly!

@younesbelkada, that's what I was thinking too. I tried it with
accelerate launch scripts/gpt-neox-20b_peft/merge_peft_adapter.py --adapter_model_name facebook/opt-125m --base_model_name edbeeching/gpt-neo-125M-imdb-lora

This gave me the traceback:
$ accelerate launch scripts/gpt-neox-20b_peft/merge_peft_adapter.py --adapter_model_name facebook/opt-125m --base_model_name edbeeching/gpt-neo-125M-imdb-lora

===================================BUG REPORT===================================
Welcome to bitsandbytes. For bug reports, please run

python -m bitsandbytes

 and submit this information together with your error trace to: https://github.com/TimDettmers/bitsandbytes/issues
================================================================================
bin /home/calkin0j/.local/lib/python3.10/site-packages/bitsandbytes/libbitsandbytes_cuda112.so
CUDA SETUP: CUDA runtime path found: /usr/lib/x86_64-linux-gnu/libcudart.so
CUDA SETUP: Highest compute capability among GPUs detected: 8.0
CUDA SETUP: Detected CUDA version 112
CUDA SETUP: Loading binary /home/calkin0j/.local/lib/python3.10/site-packages/bitsandbytes/libbitsandbytes_cuda112.so...
Traceback (most recent call last):
  File "/home/calkin0j/.local/lib/python3.10/site-packages/huggingface_hub/utils/_errors.py", line 259, in hf_raise_for_status
    response.raise_for_status()
  File "/home/calkin0j/.local/lib/python3.10/site-packages/requests/models.py", line 1021, in raise_for_status
    raise HTTPError(http_error_msg, response=self)
requests.exceptions.HTTPError: 404 Client Error: Not Found for url: https://huggingface.co/facebook/opt-125m/resolve/main/adapter_config.json

The above exception was the direct cause of the following exception:

Traceback (most recent call last):
  File "/home/calkin0j/.local/lib/python3.10/site-packages/peft/utils/config.py", line 106, in from_pretrained
    config_file = hf_hub_download(pretrained_model_name_or_path, CONFIG_NAME, subfolder=subfolder)
  File "/home/calkin0j/.local/lib/python3.10/site-packages/huggingface_hub/utils/_validators.py", line 118, in _inner_fn
    return fn(*args, **kwargs)
  File "/home/calkin0j/.local/lib/python3.10/site-packages/huggingface_hub/file_download.py", line 1195, in hf_hub_download
    metadata = get_hf_file_metadata(
  File "/home/calkin0j/.local/lib/python3.10/site-packages/huggingface_hub/utils/_validators.py", line 118, in _inner_fn
    return fn(*args, **kwargs)
  File "/home/calkin0j/.local/lib/python3.10/site-packages/huggingface_hub/file_download.py", line 1541, in get_hf_file_metadata
    hf_raise_for_status(r)
  File "/home/calkin0j/.local/lib/python3.10/site-packages/huggingface_hub/utils/_errors.py", line 269, in hf_raise_for_status
    raise EntryNotFoundError(message, response) from e
huggingface_hub.utils._errors.EntryNotFoundError: 404 Client Error. (Request ID: Root=1-6488a30c-36e2b50d5c4e5c4b12e31a8b)

Entry Not Found for url: https://huggingface.co/facebook/opt-125m/resolve/main/adapter_config.json.

During handling of the above exception, another exception occurred:

Traceback (most recent call last):
  File "/home/calkin0j/trl/examples/sentiment/scripts/gpt-neox-20b_peft/merge_peft_adapter.py", line 26, in <module>
    peft_config = PeftConfig.from_pretrained(script_args.adapter_model_name)
  File "/home/calkin0j/.local/lib/python3.10/site-packages/peft/utils/config.py", line 108, in from_pretrained
    raise ValueError(f"Can't find '{CONFIG_NAME}' at '{pretrained_model_name_or_path}'")
ValueError: Can't find 'adapter_config.json' at 'facebook/opt-125m'
Traceback (most recent call last):
  File "/home/calkin0j/.local/bin/accelerate", line 8, in <module>
    sys.exit(main())
  File "/home/calkin0j/.local/lib/python3.10/site-packages/accelerate/commands/accelerate_cli.py", line 45, in main
    args.func(args)
  File "/home/calkin0j/.local/lib/python3.10/site-packages/accelerate/commands/launch.py", line 918, in launch_command
    simple_launcher(args)
  File "/home/calkin0j/.local/lib/python3.10/site-packages/accelerate/commands/launch.py", line 580, in simple_launcher
    raise subprocess.CalledProcessError(returncode=process.returncode, cmd=cmd)
subprocess.CalledProcessError: Command '['/usr/local/bin/python3.10', 'scripts/gpt-neox-20b_peft/merge_peft_adapter.py', '--adapter_model_name', 'facebook/opt-125m', '--base_model_name', 'edbeeching/gpt-neo-125M-imdb-lora']' returned non-zero exit status 1.

Any ideas on how to fix this? I'm following the procedure in this huggingface blog post. According to the 3 scripts in the gpt-neox-20b_peft directory, I believe the base model name should be edbeeching/gpt-neo-125M-imdb-lora and the adapter model name should be facebook/opt-125m.

Hi @ckinateder,  --adapter_model_name should point to an adapter for --base_model_name . However,facebook/opt-125m is a base model and edbeeching/gpt-neo-125M-imdb-lora is an adapter for gpt-neo-125m rather than opt-125m.

the gpt-neox-20b_peft file has been removed?

Hi @o-github-o
Yes it has been removed as now you just need to call a one-liner to merge adapter weights into the base model. Check out this specific section on PEFT documentation to learn more about it.
...
model = model.merge_and_unload()


max_retry on fail

I had the use case where processing an item was failing every time: queue.fail(uid) was therefore putting the item back into the queue indefinitely.
Based on that, I added a feature to be able to tell how many times the items should be added back into the queue before going into a FAILED queue permanently to avoid any infinite loops.
Using max_retry when using fail ensures that this scenario cannot happen.
For example: queue.fail(uid, max_retry=2)
Let me know what you think
Thanks

@hellp
Any updates?
Thanks

Well, yes and no. At work we're going to abandon this project as we're currently re-doing important parts of our infrastructure and along with this move to a more mature queue – probably Kafka. SafeRedisQueue served us well in the past, but it doesn't have a future, I guess. And as I don't have a use case in any of my personal projects at the moment, I will not spend effort in adding stuff.
I suggest you just fork the project and adapt it to your needs. I don't know about project ownership, especially the PyPI name. The easiest would be you just rename it and publish it yourself and let saferedisqueue as it is. Or I could (but I don't know how) hand over the name to you. I'd prefer the renaming.
Sorry, but I hope this answer still helps you.

quick update: I'm currently working on a much more reliable algorithm and implementation for the "autoclean" aka automatic-requeuing feature. See branch "alternative-requeueing". I first want to get feedback my from colleagues, but if the new approach is accepted, we may look into this pull-request again.

Thanks for the update. So you are not abandoning this project afterall?
I'll keep an eye on it.


Site won't build anymore

I tried rebuilding my site for the first time in a while, and it doesn't seem to work anymore:
taylor@taylor-XPS-13-9365:~/my_academic_site_v2$ ./view.sh
Built in 780 ms
Error: Error building site: failed to render pages: render of "page" failed: "/home/taylor/my_academic_site_v2/themes/academic/layouts/publication/single.html:14:10": execute of template failed: template: publication/single.html:14:10: executing "main" at <(.Params.publication_types) and (ne (index .Params.publication_types 0) "0")>: can't give argument to non-function .Params.publication_types

I tried manually editing themes/academic/layouts/publication/single.html as per this thread,, but I get a new error:
taylor@taylor-XPS-13-9365:~/my_academic_site_v2$ ./view.sh
Built in 512 ms
Error: Error building site: failed to render pages: render of "page" failed: "/home/taylor/my_academic_site_v2/themes/academic/layouts/publication/single.html:14:47": execute of template failed: template: publication/single.html:14:47: executing "main" at <index .Params.publication_types 0>: error calling index: index of untyped nil

I try editing config/_default/params.toml  as per this thread, but I get yet another error message:
taylor@taylor-XPS-13-9365:~/my_academic_site_v2$ ./view.sh
Building sites … ERROR 2020/07/19 12:25:45 render of "page" failed: execute of template failed: template: _default/single.html:5:5: executing "main" at <partial "page_header" .>: error calling partial: execute of template failed: template: partials/page_header.html:89:7: executing "partials/page_header.html" at <partial "page_metadata" (dict "page" $page "is_list" 0 "share" true)>: error calling partial: "/home/taylor/my_academic_site_v2/themes/academic/layouts/partials/page_metadata.html:49:64": execute of template failed: template: partials/page_metadata.html:49:64: executing "partials/page_metadata.html" at <index site.Params.comments.commentable $page.Type>: error calling index: index of untyped nil
ERROR 2020/07/19 12:25:45 render of "page" failed: execute of template failed: template: _default/single.html:5:5: executing "main" at <partial "page_header" .>: error calling partial: execute of template failed: template: partials/page_header.html:89:7: executing "partials/page_header.html" at <partial "page_metadata" (dict "page" $page "is_list" 0 "share" true)>: error calling partial: "/home/taylor/my_academic_site_v2/themes/academic/layouts/partials/page_metadata.html:49:64": execute of template failed: template: partials/page_metadata.html:49:64: executing "partials/page_metadata.html" at <index site.Params.comments.commentable $page.Type>: error calling index: index of untyped nil
ERROR 2020/07/19 12:25:45 render of "page" failed: execute of template failed: template: _default/single.html:5:5: executing "main" at <partial "page_header" .>: error calling partial: execute of template failed: template: partials/page_header.html:89:7: executing "partials/page_header.html" at <partial "page_metadata" (dict "page" $page "is_list" 0 "share" true)>: error calling partial: "/home/taylor/my_academic_site_v2/themes/academic/layouts/partials/page_metadata.html:49:64": execute of template failed: template: partials/page_metadata.html:49:64: executing "partials/page_metadata.html" at <index site.Params.comments.commentable $page.Type>: error calling index: index of untyped nil
ERROR 2020/07/19 12:25:45 render of "page" failed: execute of template failed: template: _default/single.html:5:5: executing "main" at <partial "page_header" .>: error calling partial: execute of template failed: template: partials/page_header.html:89:7: executing "partials/page_header.html" at <partial "page_metadata" (dict "page" $page "is_list" 0 "share" true)>: error calling partial: "/home/taylor/my_academic_site_v2/themes/academic/layouts/partials/page_metadata.html:49:64": execute of template failed: template: partials/page_metadata.html:49:64: executing "partials/page_metadata.html" at <index site.Params.comments.commentable $page.Type>: error calling index: index of untyped nil
Built in 372 ms
Error: Error building site: failed to render pages: render of "page" failed: execute of template failed: template: _default/single.html:5:5: executing "main" at <partial "page_header" .>: error calling partial: execute of template failed: template: partials/page_header.html:89:7: executing "partials/page_header.html" at <partial "page_metadata" (dict "page" $page "is_list" 0 "share" true)>: error calling partial: "/home/taylor/my_academic_site_v2/themes/academic/layouts/partials/page_metadata.html:49:64": execute of template failed: template: partials/page_metadata.html:49:64: executing "partials/page_metadata.html" at <index site.Params.comments.commentable $page.Type>: error calling index: index of untyped nil

Is there something I can do to fix this without editing files manually? If I re-fork and clone the Academic Kickstart repo by following the instructions here, then what are the files I have to copy/paste over from my old nonfunctioning site to my new site?

Closing as this doesn't appear to be a bug and there are already existing discussions on why this error might appear. These issues are for bug reports and feature requests. For support, see https://github.com/gcushen/hugo-academic/blob/master/.github/support.md
The first error appears due to using an incompatible version of Hugo. Likely you updated Hugo without updating Academic to a compatible version. Check that you are using the compatible version of Hugo Extended which is defined in your themes/academic/theme.toml file under min_version. Note that min_version is also the max compatible version in this context.

Thanks @gcushen yep you were right. I followed the steps here


fix notices with latest V, run v fmt -w .

Note: there is one breaking change in the public interface:
-pub fn read(filename string) ?PngFile {
+pub fn read(filename string) !PngFile {

Since ?Type and !Type are now split, and the common idiom is to return err from the lower levels, if a library can not recover, I think that !PngFile is more appropriate, since it will not lose details, about what the problem was.

thanks ! glad to see this package of mine is still used somehow


Add Load functions for LinkToken and VRFConsumerV2

Also some cleanup to contain all the info around proving keys and hashes for JobInfo

Codecov Report

Merging #339 (37abab3) into main (c4ff01b) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #339   +/-   ##
=======================================
  Coverage   28.32%   28.32%
=======================================
  Files          16       16
  Lines        1762     1762
=======================================
  Hits          499      499
  Misses       1218     1218
  Partials       45       45

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c4ff01b...37abab3. Read the comment docs.


CI: Jython 2.7.2rc1 + Java >= 9 - failures of few unit tests

Starting from v2.7.2rc1, Jython supports Java 11. There are few failures of unit tests on CI in such combination on Macos, Linux and Win, the same tests pass on Jython 2.7.2rc1 + Java8. :
======================================================================
FAIL: test_original_signal_handlers_are_restored (test_run_and_rebot.TestSignalHandlers)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/home/runner/work/robotframework/robotframework/utest/api/test_run_and_rebot.py", line 317, in test_original_signal_handlers_are_restored
    assert_equal(signal.getsignal(signal.SIGINT), orig_sigint)
  File "/home/runner/work/robotframework/robotframework/utest/../src/robot/utils/asserts.py", line 182, in assert_equal
    _report_inequality(first, second, '!=', msg, values, formatter)
  File "/home/runner/work/robotframework/robotframework/utest/../src/robot/utils/asserts.py", line 231, in _report_inequality
    raise AssertionError(msg)
AssertionError: java.lang.Terminator$1@30722243 (Signal$SunMiscHandler) != java.lang.Terminator$1@30722243 (Signal$SunMiscHandler)

======================================================================
FAIL: test_original_signal_handlers_are_restored (test_running.TestPreservingSignalHandlers)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/home/runner/work/robotframework/robotframework/utest/running/test_running.py", line 249, in test_original_signal_handlers_are_restored
    assert_equal(signal.getsignal(signal.SIGINT), self.orig_sigint)
  File "/home/runner/work/robotframework/robotframework/utest/../src/robot/utils/asserts.py", line 182, in assert_equal
    _report_inequality(first, second, '!=', msg, values, formatter)
  File "/home/runner/work/robotframework/robotframework/utest/../src/robot/utils/asserts.py", line 231, in _report_inequality
    raise AssertionError(msg)
AssertionError: java.lang.Terminator$1@30722243 (Signal$SunMiscHandler) != java.lang.Terminator$1@30722243 (Signal$SunMiscHandler)

======================================================================
FAIL: test_restore_when_failure (test_signalhandler.TestRestoringOriginalHandlers)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/home/runner/work/robotframework/robotframework/utest/running/test_signalhandler.py", line 110, in test_restore_when_failure
    assert_equal(self.get_int(), self.orig_int)
  File "/home/runner/work/robotframework/robotframework/utest/../src/robot/utils/asserts.py", line 182, in assert_equal
    _report_inequality(first, second, '!=', msg, values, formatter)
  File "/home/runner/work/robotframework/robotframework/utest/../src/robot/utils/asserts.py", line 231, in _report_inequality
    raise AssertionError(msg)
AssertionError: java.lang.Terminator$1@30722243 (Signal$SunMiscHandler) != java.lang.Terminator$1@30722243 (Signal$SunMiscHandler)

======================================================================
FAIL: test_restore_when_no_failures (test_signalhandler.TestRestoringOriginalHandlers)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/home/runner/work/robotframework/robotframework/utest/running/test_signalhandler.py", line 97, in test_restore_when_no_failures
    assert_equal(self.get_int(), self.orig_int)
  File "/home/runner/work/robotframework/robotframework/utest/../src/robot/utils/asserts.py", line 182, in assert_equal
    _report_inequality(first, second, '!=', msg, values, formatter)
  File "/home/runner/work/robotframework/robotframework/utest/../src/robot/utils/asserts.py", line 231, in _report_inequality
    raise AssertionError(msg)
AssertionError: java.lang.Terminator$1@30722243 (Signal$SunMiscHandler) != java.lang.Terminator$1@30722243 (Signal$SunMiscHandler)

----------------------------------------------------------------------

For example, refer to this run.

These errors look really strange but luckily seem to have the same root cause. Unfortunately I only have Java 8 installed at the moment so cannot test this locally, but hopefully someone else can debug this a bit.
All these tests seem to be doing something like this:
original_sigint_handler = signal.getsignal(signal.SIGINT)
# do something that sets sigint handler but should at the end reset the original
current_sigint_handler = signal.getsignal(signal.SIGINT)
assert original_sigint_handler == current_sigint_handler

It's first of all strange these tests fail, but it is even more strange based on the error message at least the string representation of the original and current handlers are exactly same.

Are these errors already resolved?

These tests are now passing, right? If not, we can continue discussion on Slack.


Text bounds wrong after releasing the cache.

Been working through some problems getting the bounds of Text objects and caching:
Text.js:253
p.getBounds = function() {
    var rect = this.DisplayObject_getBounds();
    if (rect) { return rect; }
    if (this.text == null || this.text === "") { return null; }
    var o = this._drawText(null, {});
    var w = (this.maxWidth && this.maxWidth < o.width) ? this.maxWidth : o.width;
    var x = w * Text.H_OFFSETS[this.textAlign||"left"];
    var lineHeight = this.lineHeight||this.getMeasuredLineHeight();
    var y = lineHeight * Text.V_OFFSETS[this.textBaseline||"top"];
    return this._rectangle.setValues(x, y, w, o.height);
};

DisplayObject.js:1145
p.getBounds = function() {
    if (this._bounds) { return this._rectangle.copy(this._bounds); }
        var cache = this.bitmapCache;
	if (cache) {
	    return cache.getBounds();
        }
	return null;
};

First of all, I'm not sure what the _rectangle object is for, but it seems to be doing the job of the _bounds object in this case.
Because the _bounds object isn't set at the end of Text.getBounds when I next calculate the bounds the DisplayObject.getBounds tries to use bitmapCache bounds, but if I've just released the cache the returned bounds are {x: 0, y: 0, width: 0, height: 0}.
The bounds of Text objects shouldn't rely on the bitmapCache bounds. I think when the bitmapCache is released it should probably nullify this.bitmapCache on the display object.
The reason I'm releasing the cache is because when I update a Text object the width & height changes and I need to recalculate the size of the cacheCanvas. Is there another way to resize the cacheCanvas that I'm not aware of?

Are you manually calling release on the bitmapCache or are you using the uncache method from DisplayObject?  The uncache method should be setting the bitmapCache property to undefined.
_rectangle is just a reusable object that gets returned from getBounds.  The idea is to avoid unnecessary object creation and the associated overhead.

I was calling bitmapCache.release, like a fool! Thanks.
Is the text supposed to get measured every time getBounds is called or should it be storing _bounds so when displayObject.getBounds is called it can return the _rectangle rather than remeasure the text?

Not automatically.  If you look at the description for getBounds it gives an example for how to stop it recalculating the bounds each time.  You can also cache the text and it will use the bounds of the cache instead of measuring the text.

Awesome, thanks for replying so quickly!
On a side note, I'm also a big fan of Grim Fandango.


chore(deps): upgrade dependencies

Upgrades project dependencies. See details in workflow run.

Automatically created by projen via the "upgrade-2.x" workflow

⚪ Backport skipped
The pull request was not backported as there were no branches to backport to. If this is a mistake, please apply the desired version labels or run the backport tool manually.
Manual backport
To create the backport manually run:
backport --pr 611

Questions ?
Please refer to the Backport tool documentation


npm run build failure

why the gulpfile is written in ES6?
It is better to write node version and other useful development  environment.
I add the .babelrc to set preset es2015. Is it right?

I don't understand the question. How would you rather have it written?
El abr. 7, 2016 6:14, "Luto Yvan"<EMAIL_ADDRESS>escribió:

why the gulpfile is written in ES6?
It is better to write node version and other useful development
environment.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub
https://github.com/JuanCarniglia/kbn_circles_vis/issues/2

It is right to add the preset, it was actually there in the first place but I removed it, I know it has to be there due to some bug in Babel right?

I think it is necessary to add presets for build, add a .babelrc file or add presets in package.json. But if you move the project to KIBANA_HOME/src/plugins and there is a .babelrc or presets in package.json, it will optimize failed.

I just pushed a new version with some minor changes for this plugin.
Anyway, apart from that, I cloned the project on my src/plugins folder
(Kibana 4.5) and it worked (without installing it).
I am working on some more changes, but as you were having issues using
this, perhaps you can test it?
Thanks
2016-04-07 23:30 GMT-03:00 Luto Yvan<EMAIL_ADDRESS>
I think it is necessary to add presets for build, add a .babelrc file or
add presets in package.json. But if you move the project to
KIBANA_HOME/src/plugins and there is a .babelrc or presets in package.json,
it will optimize failed.
—
You are receiving this because you commented.
Reply to this email directly or view it on GitHub
https://github.com/JuanCarniglia/kbn_circles_vis/issues/2#issuecomment-207180649

--
Juan Ignacio Carniglia

I too got  build issue
`➜  kbn_circles_vis git:(master) ✗ npm run build

<EMAIL_ADDRESS>build /home/suresh/ground/kibana/kbn_circles_vis
gulp build

[12:17:48] Working directory changed to ~/ground
module.js:341
throw err;
^
Error: Cannot find module 'gulp-util'
at Function.Module._resolveFilename (module.js:339:15)
at Function.Module._load (module.js:290:25)
at Module.require (module.js:367:17)
at require (internal/module.js:20:19)
at Object. (/home/suresh/ground/gulpfile.js:2:13)
at Module._compile (module.js:413:34)
at Object.Module._extensions..js (module.js:422:10)
at Module.load (module.js:357:32)
at Function.Module._load (module.js:314:12)
at Module.require (module.js:367:17)
npm ERR! Linux 3.13.0-96-generic
npm ERR! argv "/usr/bin/nodejs" "/usr/bin/npm" "run" "build"
npm ERR! node v5.12.0
npm ERR! npm  v3.8.6
npm ERR! code ELIFECYCLE
npm ERR<EMAIL_ADDRESS>build: gulp build
npm ERR! Exit status 1
npm ERR!
npm ERR! Failed at the<EMAIL_ADDRESS>build script 'gulp build'.
npm ERR! Make sure you have the latest version of node.js and npm installed.
npm ERR! If you do, this is most likely a problem with the kbn_circles_vis package,
npm ERR! not with npm itself.
npm ERR! Tell the author that this fails on your system:
npm ERR!     gulp build
npm ERR! You can get information on how to open an issue for this project with:
npm ERR!     npm bugs kbn_circles_vis
npm ERR! Or if that isn't available, you can get their info via:
npm ERR!     npm owner ls kbn_circles_vis
npm ERR! There is likely additional logging output above.
npm ERR! Please include the following file with any support request:
npm ERR!     /home/suresh/ground/kibana/kbn_circles_vis/npm-debug.log
➜  kbn_circles_vis git:(master) ✗
`

same issue ..

17 error Linux 2.6.32-642.13.1.el6.x86_64
18 error argv "/usr/bin/node" "/usr/bin/npm" "run" "build"
19 error node v6.9.5
20 error npm  v3.10.10
21 error code ELIFECYCLE
22 error<EMAIL_ADDRESS>build: `gulp build`
22 error Exit status 1
23 error Failed at the<EMAIL_ADDRESS>build script 'gulp build'.
23 error Make sure you have the latest version of node.js and npm installed.
23 error If you do, this is most likely a problem with the kbn_circles_vis package,
23 error not with npm itself.
23 error Tell the author that this fails on your system:
23 error     gulp build
23 error You can get information on how to open an issue for this project with:
23 error     npm bugs kbn_circles_vis
23 error Or if that isn't available, you can get their info via:
23 error     npm owner ls kbn_circles_vis
23 error There is likely additional logging output above.
24 verbose exit [ 1, true ]


Snyk XSS<EMAIL_ADDRESS>

Snyk found a Cross-site Scripting (XSS) with [High Severity].

To handle this issue I can override dependencies. But it will be better to fix it in the origin package.
I tried to create a PR with fixes, but I can't resolve types in src/test-utils/createEditor.ts. Could someone help to update the dependencies?

issue was fixed in #1756


Adding more annotation examples

Adding more annotation examples for e.g. deprecated

Deprecated example have been disabled for now because bug issue
Adding extra annotations to and refactoring them in order to line it with the petstore yml reference:
https://github.com/springdoc/springdoc-openapi-demos/pull/3

IBM Cloud toolchain: Delivery Pipeline deployed springdoc-openapi-demos to dev, including commit ac12f5c221b8bc771569780eb6c7f90e52a28462


C api docs2

Some more progress towards finalizing the C API docs, and cleaning up the Bindings interface a little bit more.

I'm thinking I'll go ahead and merge now, but I have more documentation to add.
I'll finish the docs up and remove the extraneous comments in the next PR.


Replace gometalinter with golangci-lint

gometalinter is deprecated :(  Replace with https://github.com/golangci/golangci-lint, which is the recommended replacement.
See https://github.com/alecthomas/gometalinter/issues/590

Resolved


minWidth on  tag is invalid

getting this error:
"en_US.Main.js:22103 Warning: Unknown prop minWidth on  tag. Remove this prop from the element."
also referenced here #1063

This will be fixed when I merge in the latest react-select-plus release (likely later this week).

This warning also occurs on the 0.9.1 version

This should now be fixed.


how to create contained database users with powershell

[Enter feedback here]
I use the following powershell script to create contained database users, but I get an error:

Principal<EMAIL_ADDRESS>could not be resolved.

the script :
# Set Resource URI to Azure Database
$resourceAppIdURI = 'https://database.windows.net/'
# Set Authority to Azure AD Tenant
$authority = 'https://login.windows.net/' + $tenantId
$ClientCred = [Microsoft.IdentityModel.Clients.ActiveDirectory.ClientCertificate]::new($applicationId, $cert)
$authContext = [Microsoft.IdentityModel.Clients.ActiveDirectory.AuthenticationContext]::new($authority)
$authResult = $authContext.AcquireTokenAsync($resourceAppIdURI, $ClientCred)
$AccessToken = $authResult.Result.AccessToken

## Execute sql
$AccessToken
$connectionString = "Data Source=MYCOOLSQLSERVER.database.windows.net;Initial Catalog=MYCOOLDATABASE;Connect Timeout=30"
$connection = New-Object -TypeName System.Data.SqlClient.SqlConnection($connectionString)
$query = "Create User<EMAIL_ADDRESS>From EXTERNAL PROVIDER;"

$command = New-Object -TypeName System.Data.SqlClient.SqlCommand($query, $connection)
$connection.AccessToken = $AccessToken
$connection.Open()
$command.ExecuteNonQuery()
$connection.Close()

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 2d4a33b0-87d0-f60c-1b52-aeafa889e657
Version Independent ID: c281bdb7-c98c-6853-5077-41b3dd44d3a2
Content: Configure Azure Active Directory authentication - SQL
Content Source: articles/sql-database/sql-database-aad-authentication-configure.md
Service: sql-database
Sub-service: security
GitHub Login: @GithubMirek
Microsoft Alias: mireks

@test123114 Thanks for the feedback. We are looking into this.

@test123114 Please try to use<EMAIL_ADDRESS>as the user and let us know of the results. Your Domain might be xyz.onmicrosoft.com but what is the domain this specific user is listed as in the active directory.

I found this solution which worked for me.
https://stackoverflow.com/a/57871529

@test123114 Please check the above links and suggestions and get back to us. or if you don't have any further questions, we will close the thread by EOD.


API for vaccine data

Hello
Is your vaccination tracker available through an API?
Thank you

Yes - all of the vaccination tracker data is available via our API as a part of standard endpoints for reports and includes cumulative and change in vaccinations nationally, for each province and for some health regions as reported.
Documentation that may assist you: https://api.covid19tracker.ca/docs/1.0/reports


Exception in thread "main" java.lang.NoSuchMethodError: com.google.gson.JsonParser.parseString(Ljava/lang/String;)Lcom/google/gson/JsonElement;

I copied exactly the same code of examples/authorization/client_credentials/ClientCredentialsExample.java to my project and it didn't work, showing this error message:
Exception in thread "main" java.lang.NoSuchMethodError: com.google.gson.JsonParser.parseString(Ljava/lang/String;)Lcom/google/gson/JsonElement;
	at com.wrapper.spotify.SpotifyHttpManager.getResponseBody(SpotifyHttpManager.java:277)
	at com.wrapper.spotify.SpotifyHttpManager.post(SpotifyHttpManager.java:179)
	at com.wrapper.spotify.requests.AbstractRequest.postJson(AbstractRequest.java:126)
	at com.wrapper.spotify.requests.authorization.client_credentials.ClientCredentialsRequest.execute(ClientCredentialsRequest.java:36)
	at com.henriquenapimo1.david.music.SpotifyAuthorization.clientCredentials_Sync(SpotifyAuthorization.java:28)
	at com.henriquenapimo1.david.music.SpotifyAuthorization.main(SpotifyAuthorization.java:60)

Process finished with exit code 1

and my version of the api is 6.0.0 and i also tried to run this with the 6.3.0 and it fails as well

Cannot reproduce. Maybe your Maven dependencies are outdated? Try a refresh.

I had the same problem after adding the your API today in my project,
I solved it by explicitly updating GSON from version 2.8.5 to version 2.8.6 in my application's build.gradle
dependencies {
    implementation 'com.google.code.gson:gson:2.8.6'
}

Don't know why however...
Maybe some weird stuff in way GSON is distributed ?

Version 6.3.0 is using GSON 2.8.6:
https://github.com/thelinmichael/spotify-web-api-java/blob/ffa49b93b0441a5f149397bae3eb979182fdf4ed/pom.xml#L70-L74
Don't know what's happening here. If there won't be any more details that allow me to reproduce the issue, I'll close this issue in a few days. It can surely be reopened though ;)

I had the same problem after adding your API today in my project,
I solved it by explicitly updating GSON from version 2.8.5 to version 2.8.6 in my application's build.gradle
dependencies {
    implementation 'com.google.code.gson:gson:2.8.6'
}

Don't know why however...
Maybe some weird stuff in way GSON is distributed ?

I tried and IT WORKS! THANK YOU SO MUCH!


⚠ GitLab Server has degraded performance

In 77955d0, GitLab Server (https://gitlab01.its-telekom.eu) experienced degraded performance:

HTTP code: 200
Response time: 6819 ms

Resolved: GitLab Server performance has improved in 1556111.


Change search results event

Is it possible to change view_search_results to search_results? https://prnt.sc/9Z1d6bOiGsau

Hi @bwc69151,
This parameter is currently set to the default defined by the official GA4 script. Modifying it in this package isn't currently supported.
That being said, the changes needed to support this via the config object shpuld be fairly straightforward.
Feel free to open a PR, all contributions welcome.
If I find some time I'll take a look myself 👍

Feel free to open a PR, all contributions welcome.

I am not knowledgeable enough to do it. But it is not a priority for now. I just like one or two words in event names but this one is three.

OK, well I don't think this is something that's wanted widely enough to warrant a change right now.
However, if you do obtain the relevant knowledge to open a PR, feel free to do so 👍
Closing for now.
Thanks again for reaching out.


Remove macaron dependent on models

Will fix #6927

Codecov Report

Merging #6940 into master will increase coverage by <.01%.
The diff coverage is 0%.

@@            Coverage Diff            @@
##           master   #6940      +/-   ##
=========================================
+ Coverage    41.4%   41.4%   +<.01%
=========================================
  Files         441     441
  Lines       59736   59736
=========================================
+ Hits        24731   24736       +5
+ Misses      31767   31762       -5
  Partials     3238    3238

Impacted Files
Coverage Δ

models/mail.go
26.49% <ø> (ø)
:arrow_up:

models/login_source.go
26.98% <0%> (ø)
:arrow_up:

models/repo_list.go
67.89% <0%> (+1.05%)
:arrow_up:

modules/log/event.go
65.98% <0%> (+1.52%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c0fc6cd...e1a8014. Read the comment docs.

@mrsdizzie done. Just copied from binding...


Panic on executing git prev unknown status line prefix ASCII character: 35

Description of the bug
When executing git prev I get this error:
Graphite on  master [$?] ➜ git prev
branchless: creating working copy snapshot
The application panicked (crashed).
Message:  A fatal error occurred:
   0: unknown status line prefix ASCII character: 35

Location:
   git-branchless-lib/src/core/check_out.rs:221

  ━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━ SPANTRACE ━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━

   0: branchless::core::check_out::check_out_commit with effects=<Output fancy=true> git_run_info=<GitRunInfo path_to_git="git" working_directory="/home/dennis/Projects/rust/Graphite" env=not shown> repo=<Git repository at: "/home/dennis/Projects/rust/Graphite/.git/"> event_log_db=<EventLogDb> event_tx_id=EventTransactionId(1264) target=Some(Oid(NonZeroOid(ef007736f5400602348436c978963baa7c51e232))) options=CheckOutCommitOptions { additional_args: [], reset: false, render_smartlog: true }
      at git-branchless-lib/src/core/check_out.rs:107
   1: git_branchless_navigation::traverse_commits with effects=<Output fancy=true> git_run_info=<GitRunInfo path_to_git="git" working_directory="/home/dennis/Projects/rust/Graphite" env=not shown> command=Prev options=TraverseCommitsOptions { num_commits: None, all_the_way: false, move_by_branches: false, oldest: false, newest: false, interactive: false, merge: false, force: false }
      at git-branchless-navigation/src/lib.rs:309

  ━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━ BACKTRACE ━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━
                                ⋮ 3 frames hidden ⋮
   4: branchless::core::check_out::create_snapshot::ha2ce3d73aeffbb12
      at <unknown source file>:<unknown line>
   5: branchless::core::check_out::check_out_commit::h333d15830b408054
      at <unknown source file>:<unknown line>
   6: git_branchless_navigation::traverse_commits::hc20dc93f7e901dd9
      at <unknown source file>:<unknown line>
   7: git_branchless::commands::command_main::ha8d2c10599fa2da4
      at <unknown source file>:<unknown line>
   8: git_branchless_invoke::do_main_and_drop_locals::h492362cb5928ac89
      at <unknown source file>:<unknown line>
   9: git_branchless::commands::main::h655ebb1410b39ed3
      at <unknown source file>:<unknown line>
  10: std::sys_common::backtrace::__rust_begin_short_backtrace::h7995c1697ab0ab37
      at <unknown source file>:<unknown line>
  11: std::rt::lang_start::{{closure}}::hc53d5a782d6d5d7b
      at <unknown source file>:<unknown line>
  12: std::panicking::try::ha86251cf5daa9bea
      at <unknown source file>:<unknown line>
  13: std::rt::lang_start_internal::ha6a51778162f8d22
      at <unknown source file>:<unknown line>
  14: main<unknown>
      at <unknown source file>:<unknown line>
  15: __libc_start_call_main<unknown>
      at <unknown source file>:<unknown line>
  16: __libc_start_main@@GLIBC_2.34<unknown>
      at <unknown source file>:<unknown line>
  17: _start<unknown>
      at <unknown source file>:<unknown line>

Run with COLORBT_SHOW_HIDDEN=1 environment variable to disable frame filtering.
Run with RUST_BACKTRACE=full to include source snippets.
Location: git-branchless/src/commands/mod.rs:235

  ━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━ BACKTRACE ━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━
                                ⋮ 8 frames hidden ⋮
   9: core::result::Result<T,E>::expect::hf0e172a7fee0d4b9
      at <unknown source file>:<unknown line>
  10: git_branchless::commands::main::h655ebb1410b39ed3
      at <unknown source file>:<unknown line>
  11: std::sys_common::backtrace::__rust_begin_short_backtrace::h7995c1697ab0ab37
      at <unknown source file>:<unknown line>
  12: std::rt::lang_start::{{closure}}::hc53d5a782d6d5d7b
      at <unknown source file>:<unknown line>
  13: std::panicking::try::ha86251cf5daa9bea
      at <unknown source file>:<unknown line>
  14: std::rt::lang_start_internal::ha6a51778162f8d22
      at <unknown source file>:<unknown line>
  15: main<unknown>
      at <unknown source file>:<unknown line>
  16: __libc_start_call_main<unknown>
      at <unknown source file>:<unknown line>
  17: __libc_start_main@@GLIBC_2.34<unknown>
      at <unknown source file>:<unknown line>
  18: _start<unknown>
      at <unknown source file>:<unknown line>

Run with COLORBT_SHOW_HIDDEN=1 environment variable to disable frame filtering.
Run with RUST_BACKTRACE=full to include source snippets.

This happens when using the version of git branchless get on nixos.
This is the repo for which it fails: https://github.com/GraphiteEditor/Graphite
Expected behavior
No response
Actual behavior
No response
Version of rustc
No response
Automated bug report
Software version
git-branchless 0.8.0
Operating system
Linux 6.10.3
Command-line
git-branchless bug-report

Environment variables
SHELL=/run/current-system/sw/bin/bash
EDITOR=hx

Git version
> git version
git version 2.44.1

Hooks

Show 7 hooks
Hook post-applypatch
#!/bin/sh
## START BRANCHLESS CONFIG

git branchless hook post-applypatch "$@"

## END BRANCHLESS CONFIG

Hook post-checkout
#!/bin/sh
## START BRANCHLESS CONFIG

git branchless hook post-checkout "$@"

## END BRANCHLESS CONFIG

Hook post-commit
#!/bin/sh
## START BRANCHLESS CONFIG

git branchless hook post-commit "$@"

## END BRANCHLESS CONFIG

Hook post-merge
#!/bin/sh
## START BRANCHLESS CONFIG

git branchless hook post-merge "$@"

## END BRANCHLESS CONFIG

Hook post-rewrite
#!/bin/sh
## START BRANCHLESS CONFIG

git branchless hook post-rewrite "$@"

## END BRANCHLESS CONFIG

Hook pre-auto-gc
#!/bin/sh
## START BRANCHLESS CONFIG

git branchless hook pre-auto-gc "$@"

## END BRANCHLESS CONFIG

Hook reference-transaction
#!/bin/sh
## START BRANCHLESS CONFIG

# Avoid canceling the reference transaction in the case that `branchless` fails
# for whatever reason.
git branchless hook reference-transaction "$@" || (
echo 'branchless: Failed to process reference transaction!'
echo 'branchless: Some events (e.g. branch updates) may have been lost.'
echo 'branchless: This is a bug. Please report it.'
)

## END BRANCHLESS CONFIG

Events

Show 5 events
Event ID: 489, transaction ID: 1262 (message: hook-post-checkout)

RefUpdateEvent { timestamp:<PHONE_NUMBER>.292588, event_tx_id: EventTransactionId(1262), ref_name: ReferenceName("HEAD"), old_oid: 02c31d94ac82864e78247814f7c32a0be798e5b7, new_oid: ca0d1022961569b73b2f7514126f9ef53f8b2c65, message: None }

:
O 8fa46ba 231d xxxx xx xxxxxx xxxxx xxx xxxxxxxxxxxxxx xxxxxxxxxxxxx xxxxxxxxxx xxxxxxx
|\
| o cab8c49 229d (redacted-ref-0) xxx xxxxxxxxxxxxx xxxx xxx xxxxx xxxxx xxxxxx xx xxxxx xxxxxxx
|
O 349ec5d 229d (redacted-ref-1) xxx xxxxxxxxxxxxx xxxx xxx xxxxx xxxxx xxxxxx xx xxxxx xxxxxxx
:
-- truncated because the comment was too long for github

Version of git-branchless
git-branchless-opts 0.8.0
Version of git
git version 2.44.1

Thanks for reporting. This is happening during working copy snapshotting, where we run
git status --porcelain=v2 --untracked-files=no -z

ASCII character 35 = #. This is a valid beginning of a status line when you ask for metadata, like with --branch. However, git-branchless doesn't intend to ask for such metadata, so it fails to parse this. @TrueDoctor if you run the above git status command, what does it print? Does it include any lines with # in the output?

@arxanas
This is the output:
stash 3

I've found this in my git config:
[status]
	branch = true
	showStash = true

Clearing the stash fixes it (will try to test disabling the option as well)
Thanks!

Thanks for confirming. The best fix is probably to update git-branchless to support #. IIRC it should be pretty simple if you want to give it a try; I think there's already a match statement where we match on the first character and handle 1/2/u?
I do wonder if this should be considered a bug in Git. It seems to me like porcelain output should ignore the user configuration for these settings, precisely so that scripts can be written against it without worrying about these kinds of environment differences.

Can you give me a rough location where I should look for the fix?

@TrueDoctor I believe here:
https://github.com/arxanas/git-branchless/blob/aa23e70515d77b2ff2884fdf2ffbba35483ae0be/git-branchless-lib/src/git/repo.rs#L1014

Sorry just came back from a trip but should now have some time to work on this. It looks like # is valid per spec: https://git-scm.com/docs/git-status#_porcelain_format_version_2 and denotes header lines and can be ignored by parsers


Error in incremental backup: weed backup

Sponsors SeaweedFS via Patreon https://www.patreon.com/seaweedfs

Describe the bug
When running the backup with:
./weed backup -server=localhost:9333 -dir="/shares/LynxDigitalizacion" -volumeId=1
Where   -dir="/shares/LynxDigitalizacion" is a NAS volume mounted as NFS.
It works fine the first time, but runnning again same command, throws:
I1029 13:01:35 18205 volume_loading.go:94] volumeDataIntegrityChecking failed verifyNeedleIntegrity /shares/LynxDigitalizacion/1.idx failed: read data [9772313128,9776074523) : EOF I1029 13:01:35 18205 needle_map_sorted_file.go:24] Start to Generate /shares/LynxDigitalizacion/1.sdx from /shares/LynxDigitalizacion/1.idx I1029 13:01:35 18205 needle_map_sorted_file.go:26] Finished Generating /shares/LynxDigitalizacion/1.sdx from /shares/LynxDigitalizacion/1.idx Error synchronizing volume 1: ReadNeedleBody offset<PHONE_NUMBER>, bodyLength 3761408: EOF
System Setup
Centos 8
SeaweedFS 2.07
Started server and volume with: ./weed server -master.port=9333 -volume.port=8890 -dir="./data"
Expected behavior
Also tried running directly the weed backup in a ssh session in the NAS:
./weed backup -server=<IP_ADDRESS>:9333 -dir="/shares/LynxDigitalizacion" -volumeId=1
but got same result, first backup runs well, incremental backup not.
Also tried in a windows 10 PC, no luck
Screenshots

Thanks for the detailed issue report! Appreciate all the details!
Added a fix.

Thank you for the fast response and fix, It works!


aws: Allow creating roles with permissions boundary

@vkareh is this ready for testing?

@vkareh is this ready for testing?

Yes, this is ready


How to use this code

Please tell me, how do I use these functions?

See targets in Makefile for example on how to run the code.


Invalid dircache magic file number

Note
Before you submit your issue, make sure that:

You're using the latest version of Salesforce CLI.
You've searched both open and closed issues for related posts.
You've used the doctor command to diagnose common issues.
You understand that GitHub Issues don't adhere to any agreement or SLA.

If you require immediate assistance, use official channels such as Salesforce Customer Support.

Summary

Steps To Reproduce

IMPORTANT
Provide a repository that's configured to reproduce the issue. If you are unable to provide a repo, please explain why not. The more info we have from the start, the faster we can resolve your issue.
We may close your issue if you don't include proper instructions.

Generate a project with sf project generate or fork dreamhouse-lwc.
Provide detailed step-by-step instructions on how to reproduce the issue.

Expected result

Actual result

System Information

PASTE_VERSION_OUTPUT_HERE

Additional information

duplicate of #2458 .  You didn't provide additional info, but please do on #2458 .  For example, how you got the error (were using vscode ?)

I am using vscode and when tried to retrieve/deploy code from/to the org I am getting this error


Move Vagrant to Docker

Remove Vagrant install guide and add Docker image on Dockerhub instead.

@indigo423 content looks good. It may be that I'm just being an old person here, but is Docker sufficiently widespread to replace Vagrant in this document? If "yes", then ship it.

I would say definitely more widespread than Vagrant and in the meanwhile it is no problem anymore to install Docker on OSX and Windows natively using their hypervisor technologies without the need of VirtualBox and Virtual Machines.


Allow installing with HomeBrew

For example by using GoReleaser: https://blog.alexwendland.com/2020-08-16-different-homebrew-formula-approaches-for-go-binaries/

https://github.com/veracode/homebrew-tap/pull/57

Brew support has now been added. Thank you for suggesting this enhancement.
brew tap veracode/tap
brew install scan_health

❤  I love it. Thank you @antfie !


MH6: Cloud Opt Out Option

As a user, I should be asked if I want to opt-out of cloud backup so that I can opt-out in case I don’t want to allow cloud access.
UX: Refer to screen 1: New Wallet – Enter Name & Cloud checkbox
https://xd.adobe.com/view/a2211587-164a-47be-9d67-85811bb511ea-f772/specs/
Extract from MH6. 3
3. The user is then informed that their backup will be stored on the cloud and they can opt out of it if needed. If they decide to not opt out (take no action), the backup is stored on the cloud. We can show loading messages again if needed.

Changes required:
1. Update UI to show cloud opt-out option.
2. Cloud opt-out should have a new reducer to track response - cloudPermissionGranted or doCloudBackup
3. Cloud backup should only start if cloudPermissionGranted is true.

-Verified this issue on dev app v1.5.0(254)


Robots.txt: Injecting the dependency and changing from the ContentRepository to ContentLoader

We had an issue with the ContentRepository where the robots.txt was working on our localhost, but not working on Azure environments.
After some trial and error, we found out that the same code using the ContentLoader was working on all environments (localhost, Azure-integration, and Azure-Preproduction).

@AbsolunetCSarrazin thank you for the contribution and your time. I tested it on Azure with a single language site but I guess that in the multi lingual site this created an issue. Good catch.   I will create a newer version of the NuGet package

@adnanzameer Many thanks for the updated NuGet package!


kicad: 7.0.10 -> 7.0.11

Description of changes
release blog post
Things done
bump versions.nix

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)

[ ] sandbox = relaxed
[ ] sandbox = true

[x] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[x] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[x] Tested basic functionality of all binary files (usually in ./result/bin/)
24.05 Release Notes (or backporting 23.05 and 23.11 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[x] Fits CONTRIBUTING.md.

Add a :+1: reaction to pull requests you find important.

ouch, KiCad v8 was released
would still want this merged, and probably backported so the latest v7 stays available

#291134 opened, includes this PR's changes
will backport this change to 23.11 manually later on


Scrambeled issues after upgrading Gitea from 1.12.3 to 1.18.5

Description
I have upgrade our Gitea Server from Gitea 1.12.3 to current release (1.18.5)
Displaimer: our Gitea server was installed from someone else, years before and this person has left the company months before I came.
To be able to upgrade Gitea, I had to install a patch for MS-SQL Server (KB3158271), to enable TLS 1.3 support.
Here are the steps I followed:

net stop gitea
.\gitea.exe doctor --config <path_to_app.ini>
.\gitea.exe upgrade --config <path_to_app.ini>
net start gitea

All seams to work fine except 2 issues:

For some "organisations" (at least only one found at this time), there was not possible to create a new repository. Even with "Maximum Number of Repositories" set to "-1".
I found a simple workaround for this:

open organization settings
go to Teams
select the "Owners" team
click on "settings"

and them click on "Update Settings" (without changing anything)

After that, I was able to add new repository to this organization!

This is more complex, we don't have used the "Issues" feature for now with Gitea.
After upgrading Gitea, one of our developer decided to give it a try.
But after adding an issue entry to a repository, the issue got comments from another repository and organization!!

It looks like the content of our DB is corrupt, at least the tables used for comments and issues.
What can I do?
Gitea Version
1.18.5
Can you reproduce the bug on the Gitea demo site?
No
Log Gist
No response
Screenshots
No response
Git Version
2.17.0
Operating System
Windows Server 2012
How are you running Gitea?
Gitea is running as a local service (installed with sc.exe) on Windows 2012 Server instance.
Database
MSSQL

I'm surprised gitea.exe upgrade. I can't remember if we have that subcommand.
I think maybe because some comments lost their issues. Is there any output when executing gitea.exe doctor?

I'm surprised gitea.exe upgrade. I can't remember if we have that subcommand.

As far I as can remember, this was an output from gitea doctor, which want's gitea upgrade to upgrade DB schema

I think maybe because some comments lost their issues. Is there any output when executing gitea.exe doctor?

Here the output, all seems OK, except temporary files which could not be removed!
> .\gitea.exe doctor --config "custom\conf\app.ini"
[1] Check paths and basic configuration
 - [I] Configuration File Path:    XXX
 - [I] Repository Root Path:       XXX
Warning: can't remove temporary file: 'xxx\doctors-order994423791'
 - [I] Data Root Path:             XXX
Warning: can't remove temporary file: 'xxx\doctors-order3907404991'
 - [I] Custom File Root Path:      XXXX
 - [I] Work directory:             XXXX
 - [I] Log Root Path:              XXXX
Warning: can't remove temporary file: 'XXX\doctors-order3962735954'
OK
[2] Check Database Version
OK
[3] Check if user with wrong type exist
OK
[4] Check if OpenSSH authorized_keys file is up-to-date
OK
[5] Synchronize repo HEADs
 - [I] All 408 repos have their HEADs in the correct state
OK

Looks like your database has broken. Some comments come from 4 years ago. Maybe you have to manually clean the database.
SELECT count(*) FROM comment where issue_id NOT IN (SELECT id FROM issue) will help you summarize how many broken comments are in your databases.
And after back up your database, you can delete them.

But after adding an issue entry to a repository, the issue got comments from another repository and organization!!

I guess it should be fixed by re-sync the issue number counter. I will try to find out the SQL from Gitea issue list

For the second problem:

backup your database
empty/truncate the issue_index table
use the sql to re-sync the issue_index: https://github.com/go-gitea/gitea/issues/17070#issuecomment-921034548
replace into issue_index (group_id, max_index) select repo_id, max(`index`) from issue group by repo_id;
(the SQL provided was written for MySQL, it won't differ much for MSSQL)

ooks like your database has broken. Some comments come from 4 years ago. Maybe you have to manually clean the database.
SELECT count(*) FROM comment where issue_id NOT IN (SELECT id FROM issue) will help you summarize how many broken comments are in your databases.

This returns 72, but the comment table had only 31 entries!

For the second problem (update: maybe not related ....)
* backup your database

* empty/truncate the `issue_index` table

* use the sql to re-sync the issue_index: [Error 500 on new issue (not for all repositories) #17070 (comment)](https://github.com/go-gitea/gitea/issues/17070#issuecomment-921034548)

* `` replace into issue_index (group_id, max_index) select repo_id, max(`index`) from issue group by repo_id; ``

* (the SQL provided was written for MySQL, it won't differ much for MSSQL)

If this fix doesn't work (update: after more thoughts, I guess it's not related ...), then I guess maybe some table's auto-increment IDs were reset somehow. Like lunny said, that's a database data corruption ....

It do not look like to problem is in the issue_index table:
SELECT  *  FROM issue_index order by group_id;

+----------+-----------+
| group_id | max_index |
+----------+-----------+
| 36       | 1         |
| 46       | 1         |
| 132      | 1         |
| 520      | 5         |
| 528      | 1         |
+----------+-----------+

and
select repo_id, max([index]) as max_index from issue group by repo_id order by repo_id;

+---------+-----------+
| repo_id | max_index |
+---------+-----------+
| 36      | 1         |
| 46      | 1         |
| 132     | 1         |
| 520     | 5         |
| 528     | 1         |
+---------+-----------+

That's impossible. Maybe they are two different databases.

You are right, I don't know what I've done... Maybe I am too tired!
So, if I understand you right, there are 72 entries in "comment" table which do not have a valid issue_id?
But why they are shown in the issues view?
I don't have any "valid" comment anyway.
All those comments was tests done about 4 or 5 years ago, while testing Gitea.
How can I cleanup my DB, to remove all comments (for any organization/repository) but keep the issue entries?
This way, we could start with an almost clean DB...  I hope!

@lunny @wxiaoguang
I am a little bit lost with the Gitea DB schema, there are several things I don't understand:

is the comment table only used to store comments for issues?
as far as I can see, same issue_id could be possible for any repository for any organization. So how are comments linked to the right issue/repository/organization?

as far as I can see, same issue_id could be possible for any repository for any organization. So how are comments linked to the right issue/repository/organization?

Ok, I think I catch this, the issue_id is a link to id in issue table. So it should be unique!

Ok, I solve this by deleting all entries in comment table:
delete  FROM comment where issue_id > 0 and created_unix <<PHONE_NUMBER>
As I don't have any valid comment for any issue which is prior to this year.


Fixing Activity Stream 2 schemas

Fixes all issues related to AS2 -

https://github.com/adobe/xdm/issues/5 - Superfluous definitions
https://github.com/adobe/xdm/issues/14 - Missing titles and descriptions
https://github.com/adobe/xdm/issues/25 - Missing examples

Notes:

Some schemas still do not have examples, because they are not schemas for objects. Rather they are schemas for array and strings with patterns.
Have removed a few schema files that were not being used. This is separate from issue#5.

Pro Tip: Add query parameter w=1 to the URL of the PR to show only non-whitespace diff.

Almost:
$ find . -name "*.schema.json" | xargs grep -e "description\": \"http" | wc -l
46

46 cases of descriptions that are nothing more than a URL, not even linked.

Oh, I missed these. They were not at the root level. Let me add those ~tomorrow~ on Monday.


fix: time parsing issue of content video response

This is a fix for the time parsing issue when requesting a detailed view of movies and tv shows.
The origin of this issue was probably a change in the tvdb api response of the video content.
The published at string was formatted like this:
"videos" : {
    "results" : [ {
      "published_at" : "2021-02-25 11:45:24 UTC",
    }]
}

Which caused a failure parsing the response as type struct due to a different expected time format.
The solution was to create a custom time struct and override the UnmarshalJSON interface to support the given format.

They have reverted the time format. This fix is obsolete now.


Who watches the watchmen? Disable the emergency pause after 12 months

Quis custodiet ipsos custodes? is a Latin phrase found in the work of the Roman poet Juvenal from his Satires (Satire VI, lines 347–348). It is literally translated as "Who will guard the guards themselves?", though it is also known by variant translations, such as "Who watches the watchers?" and "Who will watch the watchmen?".

-- Wikipedia
365 days after contract initialization, stop responding to emergencyPauseNewDeposits(). Remaining governance functions are unaffected.
Based off #640.

May want to target this branch at restraining-bolt and mark it as a draft until that lands.

Ready for ya @Shadowfiend

Good for another look on green @Shadowfiend


Unwrap hotfixes

This PR provides two hotfixes for the merged PR #2741:

Build fix for MSVC 2015
Fix unconditional moves in tuple_cat

It would be great if @K-ballo could review this.

@hkaiser I applied the improvements suggested by K-ballo and fixed the remaining errors in one of the tests.

Seems like the CircleCI test failed for this because of the 120 min timeout.

@Naios: this patch causes one of the tests to fail: http://rostam.cct.lsu.edu/builders/hpx_gcc_4_9_4_boost_1_61_centos_x86_64_release/builds/111/steps/run_unit_tests/logs/tests.unit.util.tuple (0.18 sec). Would you be able to have a look, please?

@hkaiser Thank you for noticing, yes I'll have a look.

@hkaiser The unit test only fails on GCC, on Clang and MSVC everything is fine.
However I was able to reproduce the issue through following unit test on all toolchains:
    // Don't move references unconditionally (move only types)
    {
        std::unique_ptr<int> i1(new int(11));
        std::unique_ptr<int> i2(new int(22));

        hpx::util::tuple<std::unique_ptr<int>&> f1 =
            hpx::util::forward_as_tuple(i1);
        hpx::util::tuple<std::unique_ptr<int>&&> f2 =
            hpx::util::forward_as_tuple(std::move(i2));

        hpx::util::tuple<std::unique_ptr<int>&, std::unique_ptr<int>&&> result =
            hpx::util::tuple_cat(std::move(f1), std::move(f2));

        HPX_TEST_EQ((*hpx::util::get<0>(result)), 11);
        HPX_TEST_EQ((*hpx::util::get<1>(result)), 22);
    }


[subprocess][go] run the subprocesses from go-land

What does this PR do?
Runs the subprocess from go-land as opposed to forking from within the python interpreter. This should hopefully address memory leak issues we have experienced, as well as resolve the zombie fork issue (triggered by an obscure race-condition) we have experienced.
Motivation
The subprocess32 approach in #830 has helped with the memory leak, but wasn't a truly satisfactory fix as it didn't quite fix the issue on windows. The alternative, setting a global lock on windows would likely be less desirable than a pure-go cross-platform fix. Hopefully this addresses that.
Additional Notes
I've been unable to get the tests to fly on gitlab, they seem fine locally. Let's see what happens on CircleCI. Let's be thorough with the GIL, reference count during the review 😅

We have a data race when parsing the char ** args from go-land.

It looks like there's still a GIL related bug, it could also be a "sticky" thread issue - will address tomorrow.

It may be fixed now after locking the go routine to the thread. Haven't experienced the weird crashes but I will need to verify tomorrow.

Feel free to merge now to test this a bit with a packaged agent, I went through the code quickly and it looks good.
I'll make comments from a thorough review on this PR, a bit later :)


Add arguments to function edit

Add 1 argument ($variable) in funtion edit and 2 argument in function callback.
It's more usefull to create helper for edit column.
Now function edit is call like this
$datatables->edit($column_name,function($row,$alias,$array_variables),$variable);

First argument is the same.
The second is the function where you make change (callback)
The third is an array with your variables.

The function have now 3 argument
function($row,$alias,$array_variables)

$row is the result of the query
$alias is the name of the alias of column before change
$variable is an array with variable of your script

I think we no need third argument to throw variable. in php you can do same thing like this:
https://stackoverflow.com/questions/7885513/php-use-function-for-scope

Hi,
Yes you have right but, for me, this methode is unusual.
I think if you don't add this feature, you should add an exemple in your documentation to explain how to in a case like me who didn't think about it.
That said, if the third argument is not specified, this does not prevent the call from working
Sincerely ...


Mod request

I was wondering if it was possible to add REKT by @steedcrugeon and XTLandertron by @Kerbas-ad-astra.

You should speak to @steedcrugeon and @kerbas-ad-astra to do that

At least try to get their agreement for their mods to be listed.

Well, they probably have gotten a notification because I highlighted them :)

Of course, that depends on what setting they have for GitHub notifications.

I have no objections to REKT being added. What is the preferred process for adding a mod, for future reference?

A simple request to anyone on the CKAN list would do

Re. REKT, as soon as I see the new release you mentioned, I'll get it added

Oh, I see you pushed it to Spacedock, you need to get Github updated as well.  Anyway, I'll get started withthe spacedock file

@steedcrugeon see my comments in the REKT thread, the file has problems

Comments noted, I have rectified the issue (failed merge) and pushed a release.

I'll be doing REKT either this evening or tomorrow.  I pinged @Kerbas-ad-astra about the XTLandertron, will do that when I hear back

Not until I've released 1.0.  I'll let you know when that happens.

@Kerbas-ad-astra Thanks, appreciate the feedback
REKT is done

@linuxgurugamer I'm probably overlooking it, but I can't seem to find REKT in CKAN or in the recent commits. :worried:

REKT is merged now.

Thank you for your help!

Landertrons 1.0.0 is out.  @linuxgurugamer et al, you're clear to move forward.  Testing in KSP 1.2.9 indicates that it will not be compatible out-of-the-box with KSP 1.3, so please be conservative with version compatibility (if you're inheriting from the .version file, it should be okay).

KSP 1.2.9 is breaking stuff? Damn. So much for all those mods with 1.2 or 1.2.99 or such. I'm glad it's just a pre-release.


add a sort-by-distance mode?

I play with many ores on a big map, so having that ability would be useful when deciding on the next mine.

Sure, I never thought of that one, but it should be relatively simple.

This still feels fairly simple: when we render the sites, we obviously know who the player is for whom we're rendering, and every site has its own center position registered. The math isn't hard either.


Add winget install / Update linux tables

Summary

Windows

Added winget instructions
Rearranged the content so that install instructions come first, then support info

Mac

Remove 5.0 references

Linux

Removed 5.0 references
Clarify environment variables

Contributes to dotnet/core#7659
Fixes #30314

@IEvangelist please review. Thanks!


TagBot trigger issue

This issue is used to trigger TagBot; feel free to unsubscribe.
If you haven't already, you should update your TagBot.yml to include issue comment triggers.
Please see this post on Discourse for instructions and more details.
If you'd like for me to do this for you, comment TagBot fix on this issue.
I'll open a PR within a few hours, please be patient!

Triggering TagBot for merged registry pull request: https://github.com/JuliaRegistries/General/pull/107148

Triggering TagBot for merged registry pull request: https://github.com/JuliaRegistries/General/pull/107370

Triggering TagBot for merged registry pull request: https://github.com/JuliaRegistries/General/pull/111037

Triggering TagBot for merged registry pull request: https://github.com/JuliaRegistries/General/pull/113795


[linux] Update logo

Please confirm this pull request meets the following requirements:

[x] I followed the contributing guidelines: https://github.com/github/explore/blob/main/CONTRIBUTING.md.
[x] I am not the sole author or employee of a company who created either the topic I am modifying/adding or the collection entry I am modifying/adding.

Which change are you proposing?

[x] Suggesting edits to an existing topic or collection

Editing an existing topic or collection
I'm suggesting these edits to an existing topic or collection:

[x] Image (and my file is *.png, square, dimensions 288x288, size <= 75 kB)

This logo removes the heavy white background in favor of a simple border. This avoids clashing on dark backgrounds.

Please note: we will close your PR without comment if you do not check the boxes above and provide ALL requested information.

For what it's worth - when you have numerous small changes like these logo updates, feel free to batch them into one PR. Thank you for the contributions!

Thank you! I'd debated this as it started as one and then another... and then I got carried away. 😅


Point to latest buildkit tag

The old tag was failing to build
Closes https://github.com/Islandora-Devops/isle-site-template/issues/62

@joshdentremont - honestly I thought it was already set to main after https://github.com/Islandora-Devops/isle-site-template/pull/49 resulted in https://github.com/Islandora-Devops/isle-site-template?tab=readme-ov-file#set-environment-properties


refactor use black formatter

It's more of a soft recommendation from my side than a serious change request. That is, feel free to just cancel this PR and we'll continue as-is.
Enabling canonical format would require all contributors to:

be comfortable with the visual effect,
set their editor to auto-format using black on save/commit.

The canonical formatting of black allows smoother cooperation.
It's a small project and doesn't need such a tool if it doesn't bring you joy. As far as I can see it brings tremendous value on large projects (>10 contributors).

I'll have to think about this one a bit, I don't want to go to far with the formatting but at the same time it makes sense to be diligent even with small projects.

Merge conflict. No need to keep this PR open, the idea is there, and no manual work was involved to apply formatting.


Cypress-split with cypress-mochawesome-reporter is not generating html and screenshots

Hello.
I have a Cypress suite that runs fine and generates reports in html with screenshots (on error).
I noticed, however, that when running tests with cypress-split, for instance, using SPLIT=1 SPLIT_INDEX=1 with the command npx cypress run ...., the reports are generated only in json, lacking html files and screeshots.
Is there anything that I could investigate furthermore to solve this issue? It's kind of hard to share the whole project source code, so for now I'm sharing the cypress.config.js:
const { defineConfig } = require("cypress");
const cypressSplit = require('cypress-split')
const fs = require('fs')
const temp_dir = 'temp'
const { beforeRunHook, afterRunHook } = require('cypress-mochawesome-reporter/lib');

module.exports = defineConfig({
  video: false,
  videoCompression: false,
  viewportWidth: 1920,
  viewportHeight: 1080,
  experimentalMemoryManagement: true,
  reporter: 'mochawesome',
  reporterOptions: {
    reportDir: 'cypress/reports',
    overwrite: true,
    html: true,
    json: false
   },
  e2e: {
    defaultCommandTimeout: 30000,
    testIsolation: false,
    retries: {
      runMode: 0
    },
    reporter: 'cypress-mochawesome-reporter',
    setupNodeEvents(on, config) {

      require('cypress-mochawesome-reporter/plugin')(on);

      on('before:run', (details) => {
        /* Run before all specs */
        if (!fs.existsSync(temp_dir)) {
          fs.mkdirSync(temp_dir)
        }
      })

      on('after:run', (results) => {
        /* Run after all specs */
        if (fs.existsSync(temp_dir)) {
          fs.rmSync(temp_dir, { recursive: true, force: true })
        }
      })

      // Allows information printed in CI / Terminal by calling cy.task('log', ...anyDebugDataHere)
      on('task', {
        log: message => {
          console.log(message);
          return null;
        },
      })

      // cypress-terminal-report
      const logPrinterOptions = {
        printLogsToConsole: 'onFail'
      }
      require('cypress-terminal-report/src/installLogsPrinter')(on, logPrinterOptions);

      // cypress-split
      cypressSplit(on, config)
      return config
    },
    experimentalInteractiveRunEvents: true,   // use for cypress open mode
  },
  env: {
    my_env_vars...
  }
});

I was using the mochawesome, I will try with cypress-mochawesome-reporter

Ok, so I tested with cypress-mochawesome-reporter and the problem persists: it doesn't generate html files


Update docs

Fix the spacings in the TeX directives and add instructions for setting up inverse search for Okular.

Great, thanks!


jQuery.sap.formatMessage in Topic "Using the title Property in Targets" Is Never Called

URL: https://openui5.hana.ondemand.com/#/topic/1238d706b130433c9bd6b85cfb77cece
I came across the same issue as https://github.com/SAP/openui5/issues/1301 when I tried to bind title according to the snippet from the above mentioned topic:

"title": {
  "parts": ["helperModel>/PRODUCTS_TITLE", "myModel>productName"],
  "formatter": "jQuery.sap.formatMessage"
}

When evaluated, the formatter in BindingInfo is just a string literal ("jQuery.sap.formatMessage") instead of the function which fails formatting the data silently.
According to https://github.com/SAP/openui5/commit/823111c1377363c5d40009e62675d920644bf807, the binding definition should be therefore:
"title": "{ parts: ['helperModel>/PRODUCTS_TITLE', 'myModel>productName'], formatter: 'jQuery.sap.formatMessage' }"

Is there an extra repo for the documentation to which I can contribute? If possible, I'd like to fix it by myself

Hello @boghyon ,
Could you please provide a reproducible example of your issue as JSBin http://jsbin.com/fotetomeji/edit?html,js,output
Regards,
Diana

Hi @Shtilianova,
The example is provided by @serban-petrescu in the mentioned issue https://github.com/SAP/openui5/issues/1301

Hello @boghyon
,
Thank you for sharing this finding. I've created an internal incident<PHONE_NUMBER>. The status of the issue will be updated here in GitHub.
Regards,
Gery

I see that the documentation is updated now. Thanks for fixing it. Closing..


When I run the train.py,  (FileNotFoundError: [Errno 2] No such file or directory: 'dataset\folds.mat') is appear. But the dataset\folds.mat is exist.

sorry. I solve this question.Thanks！

sorry. I solve this question.Thanks！

I have encountered the same problem. May I ask how you resolved it? Thank you


spirv_msl: Put writable SSBOs in the 'device' address space

Hey all, this fixes writable SSBOs being put in the "constant" address spaces causing compile errors when their are written to. This is a quick-fix and I would understand it if more work is required. If that's the case please kindly provide guidance on what should be done.

This PR should be covered by comp/ssbo-array.comp but I don't see a way to run tests against the MSL backend. When running testshaders.py, I only had cosmetic differences in the name of _NN variables maybe because I use ToT glslangValidator.
FYI here is the shader that requires this fix:
; SPIR-V
; Version: 1.0
; Generator: Khronos Glslang Reference Front End; 1
; Bound: 28
; Schema: 0
               OpCapability Shader
          %1 = OpExtInstImport "GLSL.std.450"
               OpMemoryModel Logical GLSL450
               OpEntryPoint GLCompute %4 "main"
               OpExecutionMode %4 LocalSize 1 1 1
               OpSource GLSL 450
               OpSourceExtension "GL_GOOGLE_cpp_style_line_directive"
               OpSourceExtension "GL_GOOGLE_include_directive"
               OpName %4 "main"
               OpName %8 "myBlock"
               OpMemberName %8 0 "a"
               OpMemberName %8 1 "b"
               OpName %10 "myStorage"
               OpMemberDecorate %8 0 Offset 0
               OpMemberDecorate %8 1 Offset 4
               OpDecorate %8 BufferBlock
               OpDecorate %10 DescriptorSet 0
               OpDecorate %10 Binding 0
          %2 = OpTypeVoid
          %3 = OpTypeFunction %2
          %6 = OpTypeInt 32 1
          %7 = OpTypeFloat 32
          %8 = OpTypeStruct %6 %7
          %9 = OpTypePointer Uniform %8
         %10 = OpVariable %9 Uniform
         %11 = OpConstant %6 0
         %12 = OpTypePointer Uniform %6
         %15 = OpConstant %6 1
         %17 = OpConstant %6 256
         %20 = OpTypePointer Uniform %7
         %23 = OpConstant %7 0.02
         %25 = OpConstant %7 1
          %4 = OpFunction %2 None %3
          %5 = OpLabel
         %13 = OpAccessChain %12 %10 %11
         %14 = OpLoad %6 %13
         %16 = OpIAdd %6 %14 %15
         %18 = OpSMod %6 %16 %17
         %19 = OpAccessChain %12 %10 %11
               OpStore %19 %18
         %21 = OpAccessChain %20 %10 %15
         %22 = OpLoad %7 %21
         %24 = OpFAdd %7 %22 %23
         %26 = OpFMod %7 %24 %25
         %27 = OpAccessChain %20 %10 %15
               OpStore %27 %26
               OpReturn
               OpFunctionEnd

From compiling the following with shaderc:
#version 450
layout(set = 0, binding = 0) buffer myBlock {
    int a;
    float b;
} myStorage;
void main() {
    myStorage.a = (myStorage.a + 1) % 256;
    myStorage.b = mod((myStorage.b + 0.02), 1.0);
}

Addressed comment and ran format_all.sh.

The commit seems good. To be sure, there is no distinction between UBOs and SSBOs in Metal?

There isn't, all buffer types are backed by the same object and are set through the same entrypoints (even vertex buffers use that entrypoint).

Thanks!


WebRTC Scalable Media Broadcast.

Hi Erick and Harold,
I don't remember this topic being discussed. What about the stream forwarding for broadcasting?
It would be nice to have in Easyrtc something similar to https://github.com/muaz-khan/WebRTC-Scalable-Broadcast
One of the use cases would be to have a presenter with video and audio (+ desktop) and users connecting to the presentation with their audio (+ video) on demand.
Greetings,
Tolik

It's something that somebody could add as an optional component in the labs directory.
Somebody did bring it up in conversation in the last week, though I don't know if that was in github, the groups, or just via email. Apparently the peer broadcasting thing doesn't work very well for him. The person trying it found that it dropped connections and the quality was low. Of course, this would have been greatly impacted by the quality of the networks he was running it on.
I had the same idea a few years ago and never pursued it because the guy down stream is dependent on the entire chain of people upstream. If any of those guys go away, your connection is lost. Every network issue between peers all the way up the tree affects you. And of course, the latency increases as you go down the tree.

There seems to be no progress on this one :-(

https://webrtc.github.io/samples/src/content/peerconnection/multiple-relay/


Compared to existing solution abapGit section

Hi,
The part
"
Support multiple packages in a Git branch
Support multiple SAP systems in the same Git repo, each in their respective branches
Sync ABAP objects in a released workbench/customizing transport request (shortened as TR below) to specific Git branch
Support configuration changes in customizing transport request
"
All of this is supported in abapGit, suggest updating the readme to reflect this

#28


added_bfs_in_c++

Fixes #[15 , BFS in C++."First steps for issues #15 ]
Language: [C++]

Already implemented


Interacting throws hundreds of console errors

Interacting with this parquet file, https://dig.cmu.edu/mosaic-profiler/#url=https://idl.uw.edu/mosaic/data/athletes.parquet, cross-filtering by interacting with any draggable crosshairs throws an error on almost every pixel during the drag.

TypeError: Cannot read properties of undefined (reading 'source')
    at v (2.CYdY-Tyc.js:84:621)
    at MutationObserver.O (2.CYdY-Tyc.js:84:2097)

Can we close this issue then?

Looks great, I confirmed that there are no more errors emitted to the console.


Update local testing commands

They're out of date.

@chronark can you restore this fork? I can't merge at the moment, but I'm happy to merge these changes.
If you can't easily do that, I'll open a new pull request with the changes bundled and ensure attribution is kept in some manner.

See https://github.com/feross/buffer/pull/334


Display bug

Hi,
I have this display bug when I test this sample :
accept-a-card-payment/using-webhooks/server/php/public/

I ran this example locally and with firefox 74.0.1
Everything seems to works well except this display.
Can you help me please ? Thank you,

Hi @Lecraver, the card element will stretch to fill 100% of its parent element, so I would try adjusting the width on the parent element to make it a bit wider. That should give enough room for the fields.

Hi, thank you for the quick reply !


Wip

So I've tested all of this and I like it all, but I have a question:
Why don't we just grab the service logs for the calculated bandwidth? That has everything we need. I agree that we "don't need it", but it doesn't hurt to have.
I'm glad you changed the object prints > 0 - I should have done that.

hmm i think mainly because i was just trying to sneak in compatibility for my existing 10.11.5 and server 5.1.5 machines as they don't have the service logs
hahaha
i have a lot of those out there because 10.12 and 5.2 has been very flakes for me with service stopping and service randomly restarting compared to 5.1.5
i think also as the debug log has everything we need including bandwidth we might as well just keep looking there
but up to you it's not that hard to change it :)

Fair enough. Merging.