feat(ui): display outdated servers

https://user-images.githubusercontent.com/6705160/148303390-6449551e-c820-4c36-816e-2b1da69ec4ae.mov
Ping #194.

@kylo252 👋  any opinions?

triggering the update-check on the info panel directly will mean that you clearly intend that panel to be used once per-session.

No not really. There are two primary reasons it's only done automatically once per session:

Low effort attempt to avoid triggering rate limits
To signal to users that the feature exist - to make it easily discoverable without having to read a README. This is for example the same reason why the server is automatically expanded when it's installed.

The panel can be used as many times as one wants to.

I didn't notice it was supposed to be triggered by a keymap and it's not working for me.

Hmm, does :nmap <buffer> c and :nmap <buffer> C produce anything?

It's working correctly on this machine at least, maybe I had something messed before. What I suspected from the demo was true,  the check-version does fire automatically.

triggering the update-check on the info panel directly will mean that you clearly intend that panel to be used once per-session. So checking filetypes, settings or anything else might end up being cumbersome.

Also what about potential errors or slow-downs? maybe the automatic check should be opt-in?

Also what about potential errors or slow-downs? maybe the automatic check should be opt-in?

Errors are actually not visible in the UI currently, they should show up in the logs though. As for slowdowns I'm not too worried. I've not measured it but the processes should all mostly be IO-bound. Right now it's hard-capped at 4 concurrent processes. I thought about making it possible to disable, I think it makes sense tbh. But I'd rather make it opt-out, unless there's a strong case to make it opt-in that I'm not seeing?

I've not measured it but the processes should all mostly be IO-bound. Also, it only runs when you open the UI window. Right now it's hard-capped at 4 concurrent processes.

The main realistic improvement I can think of is a timeout
curl
$ curl --help all | rg time
     --connect-timeout <fractional seconds> Maximum time allowed for connection
     --expect100-timeout <seconds> How long to wait for 100-continue
     --happy-eyeballs-timeout-ms <milliseconds> Time for IPv6 before trying IPv4
     --keepalive-time <seconds> Interval time for keepalive probes
 -m, --max-time <fractional seconds> Maximum time allowed for transfer
 -R, --remote-time        Set the remote file's time on the local output
     --retry-delay <seconds> Wait time between retries
     --retry-max-time <seconds> Retry only within this period
 -y, --speed-time <seconds> Trigger 'speed-limit' abort after this time
 -z, --time-cond <time>   Transfer based on a time condition
     --trace-time         Add time stamps to trace/verbose output

npm
$ npm config list -l | rg time
fetch-retry-maxtimeout = 60000
fetch-retry-mintimeout = 10000
fetch-timeout = 300000

powershell
$ Get-Help Invoke-WebRequest -Parameter TimeoutSec

-TimeoutSec <int>

    Required?                    false
    Position?                    Named
    Accept pipeline input?       false
    Parameter set name           (All)
    Aliases                      None
    Dynamic?                     false
    Accept wildcard characters?  false

I thought about making it possible to disable, I think it makes sense tbh. But I'd rather make it opt-out, unless there's a strong case to make it opt-in that I'm not seeing?

The main one I'm thinking of is the rate limiting, e.g. github's API

The main realistic improvement I can think of is a timeout

Ah yeah good point. I think implementing that in the Lua layer by sending a SIGKILL to the process handle after a certain amount of time would be easier (and completely tool agnostic). Question is what is a reasonable timeout? 30s?

The main one I'm thinking of is the rate limiting, e.g. github's API

Yeah I ran into this multiple times during dev and had to constantly switch VPN connection. I wonder if the best course of action is to keep it as-is and try to solve this holistically in #248.

Ah yeah good point. I think implementing that in the Lua layer by sending a SIGKILL to the process handle after a certain amount of time would be easier (and completely tool agnostic). Question is what is a reasonable timeout? 30s?

I would've said something similar, but according to Microsoft:

A Domain Name System (DNS) query can take up to 15 seconds to return or time out. If your request contains a host name that requires resolution, and you set TimeoutSec to a value greater than zero, but less than 15 seconds, it can take 15 seconds or more before a WebException is thrown, and your request times out.

So yeah.. maybe we use the same one as winget? https://github.com/microsoft/winget-cli/blob/cfd8b296f3339f6ef6b714af8d4f9959a78fc9c1/schemas/JSON/settings/settings.schema.0.2.json#L110-L116

Yeah I ran into this multiple times during dev and had to constantly switch VPN connection. I wonder if the best course of action is to keep it as-is and try to solve this holistically in #248.

I'm still in the opinion that it's easier to tell people to install gh and be done with it, since it'll handle the authentication for you without having to pass around any "naked" API keys to the environment, and it can even perform jq queries.
Something to consider, is security. since it's hard(-er) to avoid dealing with that API key without loading it into memory, which would expose it to all the plugins using it. Sure, you can tell the fetcher to read it from a file, but now you have to worry about making sure to not log it. Am I overthinking this, and no ones care? 😅

I'm still in the opinion that it's easier to tell people to install gh and be done with it, since it'll handle the authentication for you without having to pass around any "naked" API keys to the environment, and it can even perform jq queries.

I really want to be conservative with dependencies. Personally, had I seen a plugin like this requiring gh I'd nope out immediately.

Something to consider, is security. since it's hard(-er) to avoid dealing with that API key without loading it into memory, which would expose it to all the plugins using it. Sure, you can tell the fetcher to read it from a file, but now you have to worry about making sure to not log it. Am I overthinking this, and no ones care? 😅

It's all valid points. I haven't given it much thought yet, but what I'm thinking so far is to attempt using the gh utility for all GitHub API calls, and if it fails fall back to the existing PowerShell (Windows only) -> wget -> curl chain.

Let's merge this. I think there's a high risk that GitHub API rate limit will be a problem (albeit a benign one). More incentives to start looking into #248 if anything!


Fix build on Python lower than 3.5

Overview
Something wrong with six - https://travis-ci.org/frictionlessdata/testsuite

FIXED


Feature Request: Export data to an existing Excel file

It is nice if alasql could export the data to an existing Excel file which already created before. It is good if you have an Excel which contains many formatting and macro scripts.

Any inputs to how to update an excel file would be much appreciated.
I have a feeling the "correct" way to do the excel magic would be to have data in seperated files, and one excel with macros that reads data from the files

Thanks for your response. Let me describe more details of our environment. In our environment, we have many formatted Excels with charts inside. Now we are now using Java POI to open the existing Excel and put the raw data in a tabsheet. When the end user open that Excel file, all the formatted reports and charts are correctly shown in other tabsheets.
Though the POI can resolve our problem. But I like alasql syntax to rewrite those jobs. If alasql can export to an existing Excel, it is perfect for us. Thanks.

Sounds like what you really need is a SQL db with excel fetching data live

Our data comes from database, we extract part of data and put in various Excel template using Java POI now. Extraction data using alasql is no problem, thanks for your great tool. What I want is output the results to Excel template which already exists and formatted.

Would like this feature too.


Very different orders of magnitude in ECG output

Hi Dominique!
So I ran NeuroKit on some ECG data that I've collected, and I have vastly different orders of magnitude across participants for the output relating to power in the different frequency bands.  For most of my subjects, the numbers are in the tens of thousands; for others, it's in the hundreds.  I have the same sampling rate for all my subjects.  This doesn't affect the average heart rate (which looks biological - between 60 and 90 bpm) or the RSA.
Do you have any idea what I might be doing wrong?
Thank you so much for your help!
Ellie

Dear @AnteriorInsula ,
Mmmh, I'm not really sure about that. First of all, you could normalize the powers to see if, despite their massive absolute differences, they are evenly spreaded accross your participants. You could have some outliers that for some reason cause those differences. Also, I believe that power, especially in low frequency bands, can vary depending on your  recording length.
Finally, if none of it works, give it a go with the hrv package, which author is far more competent in those matters. If using that package gives you a different (and satisfactory) result, then that means that NeuroKit's algorithm doesn't work properly and must be fixed.
Please let us know of your advances 😉
cheers


Check for additional Charset in Content-Type in function fetchFile(...) in Mediaservice.php

Description
On Shopware there is a functionality to "import" files from an URL. In MediaService.php in function fetchFile(...) there is an identical check for the Content-Type
if ($contentType === 'application/json')
I am using the cpprestsdk for implementing a REST-Client. The method i am using is explicitly setting the charset zu 'utf-8'.
So my Request-Content-Type looks like that:
'application/json; charset=utf-8'
Shopware now tries to get the image from the body sent, but there is only the json with the url i sent. And a file with the json gets created.
Is there any good reason to check for the Content-Type only?
I would suggest something like
if (($contentType === 'application/json') || ($contentType === 'application/json; charset=utf-8'))
To import it from URL only if "application/json" is allowed and set
Any other suggestions / thoughts to it?

maybe instead of checking an explicit string, we could check if it contains application/json

Sounds good to me.

Hello,
Within our company roadmap and work capacity, we try to address each bug or improvement request but admit that not each one will be resolved. To continue our culture of honesty and openness, we are closing this issue to focus on our roadmap on behalf of all Shopware users.
If you feel like this issue is still impacting you, please create a new issue and let us know.
Thank you again for your valuable feedback.


Update Blog “biryani”

Automatically generated by Netlify CMS

👷 Deploy Preview for koyomiya processing.

Name
Link

🔨 Latest commit
a674d0e3ffa5349e4f7369dc068f214b12ce92a6

🔍 Latest deploy log
https://app.netlify.com/sites/koyomiya/deploys/62d02e07cd407900086c610f


Turn off ASC

Hi,
How does one turn off ASC?  I give workshops and I get everyone to turn it on and sometimes they need to turn it off after.  I can't find a doc explaining this.  I know that "turning off security" is a bad idea, but I need to able to tell people how to do it, and it should be available on the site.  Could we add this somewhere?
Tanya

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 75c7f3f6-1c1e-0654-f2e7-79dbfbcc433b
Version Independent ID: da1ac295-09fd-f240-3f61-a09f3cb94dac
Content: Azure Security Center frequently asked questions (FAQ)
Content Source: articles/security-center/security-center-faq.md
Service: security-center
GitHub Login: @rkarlin
Microsoft Alias: rkarlin

@shehackspurple Great to hear that you are able to resolve this. We will now proceed to close this thread. If there are further questions regarding this matter, please reopen it and we will gladly continue the discussion.

I meant that I received your test email.  Sorry for the confusion.  Still
don't know how to downgrade my ASC subscription.
On Mon, Aug 27, 2018, 5:25 PM SaurabhSharma-MSFT<EMAIL_ADDRESS>wrote:

@shehackspurple https://github.com/shehackspurple Great to hear that
you are able to resolve this. We will now proceed to close this thread. If
there are further questions regarding this matter, please reopen it and we
will gladly continue the discussion.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/MicrosoftDocs/azure-docs/issues/14064#issuecomment-416374174,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AZgYC2ORo61kPEXJAFbGNB6SbCqBxg_mks5uVGPkgaJpZM4WOaMm
.


Chart support

We changed our chart support in JVx and should support the same feature set in reactUI

A demo screen: Chart Demo is now available in JVx.mobile project.

Example:
{
    "id" : "C132",
    "name" : "ChaDem-KY_C_data27",
    "className" : "Chart",
    "maximumSize" : "800,600",
    "yAxisTitle" : "Y Axis",
    "xAxisTitle" : "X Axis",
    "title" : "Title",
    "preferredSize" : "350,300",
    "minimumSize" : "16,16",
    "dataBook" : "JVxMobileDemo/ChaDem-KY/data#1",
    "xColumnName" : "TYP",
    "yColumnNames" : [ "Y1", "Y2", "Y3" ],
    "chartStyle" : 1002,
    "parent" : "P122",
    "eventFocusGained" : true,
    "yColumnLabels" : [ "Y1", "Y2", "Y3" ],
    "xColumnLabel" : "Typ",
    "indexOf" : 9,
    "constraints" : "t3;lm;b3;r0"
  }

chartStyle is the important property:
    /** Style constant for showing a line chart. */
    public static final int STYLE_LINES = 0;
    /** Style constant for showing an area chart. */
    public static final int STYLE_AREA = 1;
    /** Style constant for showing a bar chart. */
    public static final int STYLE_BARS = 2;
    /** Style constant for showing a pie chart. */
    public static final int STYLE_PIE = 3;
    /** Style constant for showing an step line chart. */
    public static final int STYLE_STEPLINES = 100;
    /** Style constant for showing an area chart. */
    public static final int STYLE_STACKEDAREA = 101;
    /** Style constant for showing an area chart. */
    public static final int STYLE_STACKEDPERCENTAREA = 201;
    /** Style constant for showing a stacked bar chart. */
    public static final int STYLE_STACKEDBARS = 102;
    /** Style constant for showing a stacked bar chart. */
    public static final int STYLE_STACKEDPERCENTBARS = 202;
    /** Style constant for showing a overlapped bar chart. */
    public static final int STYLE_OVERLAPPEDBARS = 302;
    /** Style constant for showing a bar chart. */
    public static final int STYLE_HBARS = 1002;
    /** Style constant for showing a stacked bar chart. */
    public static final int STYLE_STACKEDHBARS = 1102;
    /** Style constant for showing a stacked bar chart. */
    public static final int STYLE_STACKEDPERCENTHBARS = 1202;
    /** Style constant for showing a overlapped bar chart. */
    public static final int STYLE_OVERLAPPEDHBARS = 1302;
    /** Style constant for showing a ring chart. */
    public static final int STYLE_RING = 103;

any preferences yet on which library we should use to render the charts?

https://d3js.org/ -> would be super flexible but we would probably have to implement chart types pretty much ourselves or copy & adapt some of the demos: https://observablehq.com/@d3/gallery
https://www.chartjs.org -> would be a bit more chart focused and seems to cover most of the chartstyles above https://www.chartjs.org/samples/latest/, there is also a react wrapper we could try: https://github.com/reactchartjs/react-chartjs-2

When I first implemented the chart, i used the primereact chart component which basically uses chartjs. https://www.primefaces.org/primereact/showcase/#/chartdemo
There is not a lot of documentation on primereact, but afaik you can use all chartjs options.

Mh the version of chartjs in prime seems to be a bit old but that should be a good startingpoint at least.
In the worst case we can just write our own wrapper with a similar API and replace the prime one.

We won't create a new charts binding. The existing prime react charts are okay.

d3js is to complex and too much work
Charts is great and currently we don't need the latest version.

And yes, if charts of prime react is too old, we could use this  as template for our own binding!

Displaying the charts via chartjs is now mostly implemented. Most remaining aspects are cosmetic differences. Maybe you guys could have a look where we should do some additional tweaking.
There are still some remaining issues I'll need some input on:

The fifth group on "category charts" is rendered as "Z" in swing but acutually labeled "E" in the data. Is this a bug or can that be overridden at some point?

I can't figure out how to process the data to get the result from the "category charts" page. (Currently it's the sum)

Stacked areas look different in swing but are imho wrong there:

Z is displayed instead of E, as there is a translation de: E en: Z
So all Labels and Categories have to be translated.

If a PIE Chart has set one Y column, the sum of every category stored in X Column is shown per Category.
If two or more Y Columns are set, only the values of the current selected row are shown for every column

The Percentage Area Chart is for some Reason broken in Swing.

A Question about the colors. You copied the Swing colors (They are nearby Swing default, but not very beautiful.) If the default colors of JsChart are better, we can probably use them in swing...

I checked the Percentage Area Chart again. Swing JFreeChart does not support the percentage mode for xy charts.
This is only supported by Vaadin (high charts) and by the jschart.

I've extracted the colors of vaadin charts.
In colors in vaadin have in some charts transparency of 0.75 in most charts they are solid without transparency.
Its not so easy there to have the same transparency in all chart types.
        new SolidColor(94,  144, 233), // #5E90E9
        new SolidColor(210, 110, 104), // #D26E68
        new SolidColor(172, 219, 108), // #ACDB6C
        new SolidColor(240, 221, 106), // #F0DD6A
        new SolidColor(126, 216, 211), // #7ED8D3
        new SolidColor(211, 111, 163), // #D36FA3
        new SolidColor(104,  95, 170), // #685FAA
        new SolidColor(228, 133,  80), // #E48550
        new SolidColor(70,   97, 140), // #46618C
        new SolidColor(152,  87,  80), // #985750
        new SolidColor(141, 173,  95), // #8DAD5F
        new SolidColor(181, 168, 102), // #B5A866
        new SolidColor(73,  119, 128), // #497780
        new SolidColor(133,  65, 110), // #85416E
        new SolidColor(82,   88, 162), // #5258A2
        new SolidColor(140,  92,  66)  // #8C5C42

Thanks for all the feedback. The Pie Chart should behave es expected now and the values display as percentages.
I also made the chart colors configurable via css variables so we can customize that easily.

Gauges have properties for
minValue, maxValue, minWarningValue, maxWarningValue, minErrorValue, maxErrorValue.
The used colors for error, warning, ok are:
/** Color for error value. */
public static final SolidColor COLOR_ERROR      = new SolidColor("#DF5353");
/** Color for warning value. */
public static final SolidColor COLOR_WARNING    = new SolidColor("#DDDF0D");
/** Color for ok value. */
public static final SolidColor COLOR_OK         = new SolidColor("#55BF3B");

I guess this is done and can be closed


Translation

How should I go about translating Another Notes App (should I find the time to do so)?
Just translate values.xmland send it in an additional valuesdirectory corresponding to my language via a pull request?

Just translate values.xmland send it in an additional valuesdirectory corresponding to my language via a pull request?

That's pretty much it. You can do it at any time but if you'd prefer to make a single pull request to translate the whole thing I can notify you before making a release.

Thanks, that would be great.
I'll probably make a single pull request, since I usually work on translations from a text editor (though there are exceptions, such as Stringlate and POEditor, for Android and desktop Linux respectively, since they make my life much easier when translating software strings), so a notification before release would be great (assuming I don't send the pull request earlier, in which case, it would still be great, if there are additional strings added later).

If you want to translate the app you can do it. I'll be making a release soon, I don't think I'll be adding any more strings until then.

Thanks. To be honest, I just got around to starting a sorry while ago.
I currently have some chores to finish, and then I'll return to translating.
Also, there were a few strings that I wasn't able to understand their context, so I'll ask you about them when I return to translate the app.

I'm almost done translating, however there are three points that either need clarification and/or I am stuck, as well as a few more that probably won't translate well, as things are currently within the app.

(Least important, however) Should I leave the name as is, it would you like me to either translate or transliterate it?

"Cancel" and "Undo" share the same word in Hebrew, so I am trying to think to put for "Undo" (I'll probably rely on what I used for translating MiXplorer).

The "note_placeholder_active" string has a bunch of slashes, as well as "nClick" in the value. What am I supposed to do with those?

While I know what strikethrough is, I am currently having a hard time deciding how to translate it, as I can't seem to think, not find, a translation for it as a verb, rather than just a noun.

Additionally, where the number is counted, there could be an issue where if only one item is there, in Hebrew it should be structured thus: "Item one selected", rather than "One item selected". I have had this issue in the past when translating MiXplorer, though I forget what HootanParsa did to take care of that.

You can leave it as is if you think that's best. When I translated in French I decided to leave the name in English because it was a bit long in French. I don't think it matters too much in the end.
Both strings never occur together so that's not really an issue.
You need to escape single quotes with a slash. The \n is a line break escape, you can leave it. If I had used a regular line break the system would have just merged both lines with a space between them.
Here's a good resource that might help you: https://www.microsoft.com/en-us/language/Search?&searchTerm=strikethrough&langID=378&Source=true&productid=0. You can also reformulate it so that it's used as a noun e.g: "Mark checked list items with a strikethrough"

Do you have a particular string in mind for your last point? I think the only place where a number of selected items is shown, only the number itself is shown.
I think the recurrence library used by the app has no Hebrew translation so you'll need to translate it too to have the full interface in one language.

Thanks:

In Hebrew, it should be about the same length (perhaps 2-3 characters more), however I'll do the same as you, for consistency.

It could still potentially be confusing for users, so I did as with MiXplorer, and translated "Cancel" as a noun, and "Undo" as a first-person verb (i.e. rough equivalent of "you undo", though in Hebrew, the "you" is not a separate word, but rather changes the word itself).

Thanks, will follow that as well.

Thanks, this helped me verify that there is no direct equivalent to "strikethrough" as a verb to Hebrew. Formulating the sentence like that is also not coherent than other options I can see, so I'll do that.

Regarding numbers, the particular string is "note_list_item_info".
I understand, though I do not seem to see the other translations alluded to there?

Regarding numbers, the particular string is "note_list_item_info".

This string appears when a list note has more items that can be displayed in preview:

I'll let you see what's the most appropriate way to translate it. You can specify separate strings for one/two/few/many/other as needed.

I understand that I would transfer the library, though I do not seem to see the other translations alluded to there?

It needs to be done separately, the library has its own strings.xml file. The library provides a dialog and a class to show recurrence rules in a localized way, both of which is used by the app.

Yeah, that is precisely what I had meant regarding the order, though I guess Hebrew-speaking users will have to live with it, since I see no way to improve upon that.
Regarding the library, thanks, I was simply looking in the wrong place, I'll get to it soon.

You can move the %d specifier (where the number is inserted) entirely if you want, even omit it.

That is true, however it may look weird to see the number jump right (Hebrew is RTL) when it goes from 1 to 2.
I think it'll be a good idea if I ask friends of mine in our Telegram group for their opinion (though not everyone uses their devices in Hebrew, some (like me) use them in English, some use them in Russian, as well as a few other languages).

I'll close this since the translation process is described in details in TRANSLATION.md. If you find time to finish your translation, you can do it on the Crowdin project, I think it'll be simpler since there are screenshots for every string.

Thanks, these are busy times for me.
Hopefully once I finish replacing/rebuilding/modifying a few living necessities that broke down I be able to get to it.


Add PA and BTI to Marl

Hi,
This is the upstream merge for this commit to SwiftShader:
https://swiftshader-review.googlesource.com/c/SwiftShader/+/56248
Best Regards,
André
Adds an appropriate .note section for Arm Branch Target
Identification and Pointer Authentication to osfiber_asm_aarch64.S.
Furthermore inserts Pointer Authentication to marl_fiber_swap
including BTI landing pad.

Bug: chromium:1145581
Change-Id: I43961c305bd6adf8ee4baaf929341e47be2e2e7f

Thank you for your PR. Looks great!


Update - nuxt/i18n@next

Sorry for missing it in the previous PR with overrides, if you would want I create the PR again but this time it is working as expected you can test it on - https://stackblitz.com/github/buubux/nuxt3-tailwind-kit/tree/main or we can wait next update from nuxt/i18n as it should fix it

There's an error on Vercel when using the latest beta of nuxt-i18n. That's why I downgrade the version to beta.10. Maybe we should rise the issue and wait until it is fixed.
(500 (/__i18n__/precompile))

[nuxt] [request error] [unhandled] [500] ENOENT: no such file or directory, open '/vercel/path0/.nuxt/i18n/config-cfcb45fa.js'

[nuxt] [request error] [unhandled] [500]  (500  (/__i18n__/precompile))
  at processTicksAndRejections (node:internal/process/task_queues:96:5)
  at async precompileMessages (./chunks/app/server.mjs:3970:29)
  at async i18n_options (./chunks/app/_nuxt/i18n.options-8f995de4.mjs:64:23)
  at async vueI18nConfigLoader (./chunks/app/server.mjs:3613:81)
  at async resolveNuxtI18nOptions (./chunks/app/server.mjs:3615:19)
  at async Object.setup (./chunks/app/server.mjs:4245:116)
  at async Object.callAsync (./node_modules/unctx/dist/index.mjs:53:16)
  at async applyPlugin (./chunks/app/server.mjs:166:33)
  at async applyPlugins (./chunks/app/server.mjs:175:5)
  at async createNuxtAppServer (./chunks/app/server.mjs:4983:7)

I guess we can do that, maybe next @nuxt/i18n will fix it without any overrides


Remove 'experiment' from output redactor docs

This will land as default feature in v3.31 so we can remove the experimental caveats from these docs.
@plaindocs should we note the agent minimum version required for the feature anywhere?

This is great!
We've not done so much in the past, but especially where the behavior changes like this we should.
The real question is whether we should document both states? I guess because it is experimental we don't commit to that?
So yeah, :+1: to introduced in Agent v3.31

@StarfallProjects this will affect #1002

I guess because it is experimental we don't commit to that?

🤔 I could see including a link to the release that the experiment is available from too, if we’re documenting the experiment it’s probably worth pointing folks to which version they’d need.

So yeah, 👍 to introduced in Agent v3.31

I’ve tried putting this in a new <p> tag after the description to see how it looks in the preview deploy, let me know what you think.

I wonder if we could put it underneath the name of the config on a new line, rather than in the description? Perhaps just "v3.31 and above" in dark grey?

@scopegate wanna factor this information design into the parameters rework in #1002 ?
@toolmantim do you see that needing an introduction of that field for all backwards params? Or starting now for all going forward?

3.31.0 is live now so this is ready for final review 🙌


Idea: Implement a memory file system

We can implement a memory file system that could be used for tests.
Like https://golang.org/pkg/testing/fstest/

Maybe store files in a map.


Handle deactived webhook case for check-inject

Please provide a description of this PR:
To help us figure out who should review this PR, please put an X in all the areas that this PR affects.

[ ] Ambient
[ ] Configuration Infrastructure
[ ] Docs
[ ] Installation
[ ] Networking
[ ] Performance and Scalability
[ ] Policies and Telemetry
[ ] Security
[ ] Test and Release
[x] User Experience
[ ] Developer Infrastructure

Please check any characteristics that apply to this pull request.

[x] Does not have any user-facing changes. This may include CLI changes, API changes, behavior changes, performance improvements, etc.

@hanxiaop: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

release-notes_istio
9f4549898ba80e539bfab37481610759720292b8
link
true
/test release-notes

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@hanxiaop: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

release-notes_istio
9f4549898ba80e539bfab37481610759720292b8
link
true
/test release-notes

lint_istio
9f4549898ba80e539bfab37481610759720292b8
link
true
/test lint

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@hanxiaop: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

lint_istio
79cd40e475c4848e538f8282df5b6d65a98f0dcd
link
true
/test lint

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@hanxiaop: PR needs rebase.

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

not stale

/test integ-security

This is used to optimize the deactived webhook case.
Before the PR, it is like:
WEBHOOK                     REVISION  INJECTED      REASON
istio-revision-tag-default  default   ✔             Namespace label istio-injection=enabled matches
istio-sidecar-injector      default   ✘             No matching namespace labels () or pod labels ()

After the PR, it is like:
WEBHOOK                     REVISION  INJECTED      REASON
istio-revision-tag-default  default   ✔             Namespace label istio-injection=enabled matches
istio-sidecar-injector      default   ✘             The injection webhook is deactivated, and will never match labels.

@istio/wg-user-experience-maintainers PTAL thanks

not stale

@hanxiaop: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

integ-ambient_istio
555054a71e97dbf8b1cbc266a067f9a1dff92d8c
link
true
/test integ-ambient

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

/retest

not stale

/retest

EasyCLA Expected — Waiting for status to be reported

Has anyone encountered this before?


Event no longer displayed?

Hello,
Since recent update, I notice the event is no longer displayed?

I do not seen this change in release notes, is it normal?
Thanks

The Pages widget displays talks in this way when using the Compact view. It can be customised by modifying layouts/partials/li_compact.html.


Check support for svelte 5

npx svelte-add@latest tailwindcss does not currently work with Svelte 5 – silently fails to install tailwindcss due to dependency issues (doesn't recognize svelte@5 as a valid dependency). But it does update your postcss config which fails to import tw because it failed to install. It's easily fixable with npm install tailwindcss. Would be nice if svelte-add could recognize svelte 5 as a valid dependency, though :-)

This is supported by svelte-adds successor svelte-compose


DDPG example uses BatchNormalization incorrectly

Correct me if I'm wrong, but according to the documentation of tf.keras.layers.BatchNormalization it functions differently depending on whether or not training is set to True.
In the example code ddpg_pendulum.py this mode is never altered. Effectively, I think, this means that normalization has no effect.

@fchollet Isn't the training=true default argument when passing input to model? Which I think is ok, not to define explicitly as is the case in all the TensorFlow tutorials.
@lubiluk In our example, we are not testing our model at all, we are just examining if our reward is increasing and assuring that the DDPG Algorithm works. If we were to export this model to test, yes we would use training=False so that we use a previous running average of dimension values and make testing faster.

Effectively, I think, this means that normalization has no effect.

If you would look at weights being trained, Normalization layer weights are being trained.

@fchollet Isn't the training=true default argument when passing input to model? Which I think is ok, not to define explicitly as is the case in all the TensorFlow tutorials.

No it defaults to False. It is accurate that in the code as written currently, BN does nothing.

If you would look at weights being trained, Normalization layer weights are being trained.

Its trainable weights only. So to be precise, you're not doing BN, you're just doing featurewise scaling and centering with learned coefficients.

Its trainable weights only. So to be precise, you're not doing BN, you're just doing featurewise scaling and centering with learned coefficients.

Yes, If the default is false then the layer was just doing that. I have submitted a PR https://github.com/keras-team/keras-io/pull/246  for the correction.

I think in policy() training should be False in order to use normalization here. IMO, acting in the environment is not part of the training but rather evaluation. If we use training=True everywhere then we also loose BN benefits.

Solved by removing BN. Activating it prevents training altogether.


webpack 4.44.1 alias bug within webpack.config.ts file only

Bug report

What is the current behavior?
Alias { "@/": path.join(__dirname, 'src') + '/'} won't work within webpack.config.ts file, but works fine within webpack.config.js
If the current behavior is a bug, please provide the steps to reproduce.
set alias { "@/": path.join(__dirname, 'src') + '/'}, add import like @/config
Alias can be fixed if we drop last slash: { "@": path.join(__dirname, 'src')}, but is it right? Alias will match external module imports like @babel/core.

What is the expected behavior?
Should work same as webpack.config.js

Other relevant information:
webpack version:  4.44.1
Node.js version:  12.15.0
Operating System: mac os 10.15.6
Additional tools<EMAIL_ADDRESS>

Please report issue to typescript, if it works in webpack.config.js  then it works and there is nothing we can do on our side

It also wont work when I call webpack.config.ts via ts-node api:
require('ts-node/register/transpileonly');
require('./webpack.config.ts');

I believe that, it's not totally typescript issue. But some incompatibility between both or shared packages like glob or some other packages.
When I call webpack with --display-error-details arg, then I see, that alias {"@/": `${path.join(__dirname, 'src')}/`} was not applied during module search. But next alias {"@": path.join(__dirname, 'src')} works fine.

@cainrus we don't use glob


Implement Find in Folder... functionality

Note that I haven't added the command in package.json on purpose. Adding it there would make an entry in the command palette, adding unnecessary noise, since this command can't be run on its own. We should probably go over the rest of the commands and remove those that doesn't make sense to trigger without specifying a hint.
Closes #15.

oh nice I had assumed that you had to register every command in the package.json file! we can update that once this PR is merged (issue: https://github.com/paul-schaaf/talon-filetree/issues/40)

LGTM thanks!


Any plan to release ACRONYM-trained weights?

Good point! yes, we are going to do it.

Done. Check the latest commit.


Proposed move from JSONSimple

Hi,
Based on the stuff I started for using a collaborator to aid mocking and testing reddit interactions in this branch:
https://github.com/beresfordt/jReddit/tree/httpClientCollaborator
And the annoyances of dealing with JSONSimple I started experimenting with using https://github.com/FasterXML/jackson-core and making better use of the apache HttpClient to manage cookies
I have committed a preliminary updated version of User and UserTest which are both simpler in terms of usage and in terms of testing. I have also added (temporarily) an integration test so you can see real reddit interactions with the newer RedditServices
The jackson/HttpClient cookie management branch is here:
https://github.com/beresfordt/jReddit/tree/jackson
The test showing RedditServices interacting with reddit is here:
https://github.com/beresfordt/jReddit/blob/jackson/src/test/java/com/github/jreddit/utils/restclient/RedditServicesIntegrationTest.java
Let me know what you think, or if you have any questions

@beresfordt did you manage to do something related to this?

I did get some way along with it, then life happened and I got distracted. Will check and see where I got to, then get back to you


Added changes such as timestamp, removed colab references, added markup text mentioning usage of flag -q in a command for the file SDK_Custom_Container_Prediction

Added changes such as timestamp, removed colab references, added markup text mentioning usage of flag -q in a command for the file SDK_Custom_Container_Prediction
If you are opening a PR for Official Notebooks under the notebooks/official folder, follow this mandatory checklist:

[x] Use the notebook template as a starting point.
[x] Follow the style and grammar rules outlined in the above notebook template.
[x] Verify the notebook runs successfully in Colab since the automated tests cannot guarantee this even when it passes.
[x] Passes all the required automated checks. You can locally test for formatting and linting with these instructions.
[x] This notebook has been added to the CODEOWNERS file under # Official Notebooks section, pointing to the author or the author's team.
[x] The Jupyter notebook cleans up any artifacts it has created (datasets, ML models, endpoints, etc) so as not to eat up unnecessary resources.

Notebook ran on workbench successfully. But not running on Colab as the notebook involves building & running custom container /docker image. So, haven't included Colab in the notebook.

/gcbrun

Add new code sequence for running in colab

Execution timed out:
Step #4: widgetsnbextension==3.6.0
Step #4: Copying file://source_archived_300c608c-9546-428d-b8fc-ec5bc716f155.tar.gz [Content-Type=application/x-tar]...
Step #4: Copying file://source_archived_edc4017e-c898-4e45-8a12-110c33f16556.tar.gz [Content-Type=application/x-tar]...
Step #4: / [0 files][    0.0 B/  7.4 MiB]
/ [1 files][  7.4 MiB/  7.4 MiB]
Step #4: Operation completed over 1 objects/7.4 MiB.
Step #4: / [0 files][    0.0 B/  7.4 MiB]
/ [1 files][  7.4 MiB/  7.4 MiB]
Step #4: Operation completed over 1 objects/7.4 MiB.
TIMEOUT
ERROR: context deadline exceeded
Finished Step #4

ingestion test failed for: Needs /gcbrun from a collaborator

/gcbrun

I did a /gcbrun, but it did not seem to run the test

/gcbrun

Apparently Cloud build just fixed that bug in the latest release
Might have to gcbrun again to see the fix

/gcbrun


instantiate jwtPayloadJson directly

The original instantiates a string and then converts it to json.  This change instantiates json directly.

need to sign Adobe CLA first

I've signed the Adobe CLA.  I'm not sure why the check is still failing.


chore(repo): Update issue template with support links

Fixes #3627

Test flakiness is fixed in #3676


Add a version number header to credential storage.

This adds a version number to credential storage in order to make in-the-field upgrades easier.  If for some reason we need to extend or change the Credential structure in a way that changes the CBOR, we want to be able to continue to load the old format, and detect that it needs updating.

I'm not entirely opposed to this approach, but another approach in Rust would be to use enum variants for versions. What do you think about something like this?

I thought about doing something like that, but having the standalone version header that is independent of the encoding mechanism means we can switch storage format entirely (to a binary format, or yaml, or whatever) without difficulty; having the version encoded alongside the other fields with the same encoder means that switching storage formats becomes more error-prone, or at least fiddlier.

We're already using a fairly compact binary format, I don't think we're ever going to change that. Managing versions and version conversion is more work this way, particularly once we allow updating credentials - it would be nicer if we could just rely on the serializer and the data structures that we define.

@cobward 's proposed method works, and would require no changes until a second version is added.


四川省苍溪中学

四川省苍溪中学

四川省苍溪中学

@dogfights Please provide us with:

the school official website URL
the school street address, including city and country
an URL of a page on the official website where the school offers an IT-related long-term (>1 year) course
a proof, which shows that the school recognizes the domain you are submitting as an official email domain for the students.

@dogfights You might miss my previous comment. Please react.

@dogfights I am sorry, this request remains unanswered for a while. I have to close it without merging. Please reopen and comment if you have an update regarding the aforementioned issue. Thank you for your understanding!


Blurred Circle on IOS9

I noticed that IOS9 devices show poster instead of video as it should, but there is a blurred circle in the middle that wasn't there on IOS8 and earlier.

I did a temp fix by changing "display" to "none" and "inline" whenever "visibility" was triggered.

We did a fix for this that is also included in https://github.com/VodkaBears/Vide/pull/123


Unable to connect to manager for worker data

Hi, I'm new here and I just installed the app following the section "Setting up".
I read all the issues thread but nothing could help me.
When I launche web.py , I keep getting repeatedly the mesage "Unable to connect to manager for worker data."

I can see nothing but blue square on map.
I'm currently testing with 1 working account.
My accounts.csv looks like :
username,password,provider,model,iOS,id
xxxxxx,xxxxxx,ptc
In config, all i changed is ;
MAP_START, MAP_END and
PLAYER_LOCALE = {'country': 'CA', 'language': 'en', 'timezone': 'Canada/Eastern'}
Thank you.

I'm getting the same on my web.py launch.  Timezone should be America/Toronto for EDST (not Canada).

I assume you also ran scan.py first? (Just checking)

@licorice917 I changed but no change.
@DavePlater Yes

You do not have multiple instances running do you?

@DavePlater No i'm not.
I restart web.py each time i make change in files.

What is the MANAGER_ADDRESS set to in your config.py?
Since config.py is shared between scan.py and web.py they should always think it is the same value, but web.py isn't making the connection.
Are you on windows or linux?
Did you remember to put in your bossland key into the config so the scan.py would actually work?
What is in your scan.log? Maybe the problem is with scan.py and not web.py

@DavePlater I'm on windows.
Is bossland key necessary to run? I thought using old hash key because I didn't want to buy it.
If yes, I'll close this thread.

Yes bossland key is needed now, you need to make sure you get the api key https://talk.pogodev.org/d/51-api-hashing-service-by-pokefarmer and not the pokefarmer account key.
I am not sure that will solve your issue with "Unable to connect to manager for worker data." but it should at least make your scan.py start finding things.


Refactor

Hey @gasolin, @bomsy and I were investigating some issues we were seeing with the bidirection library, which brought us the tests.
Here are some simple refactors for the tests and the library:

tests now read input and output from a fixtures directory
tests now fail when there is an exception. looks like a simple oversight
plugin has some new helper functions updateRule, updateItem,  cloneItem ...
plugin helper functions are extracted outside of the exported function
plugin has a log function for viewing output.

It looks like there's an existing error with rules that have non-bidi declarations e.g.
.toggle-button-end {
  top: 7px;
  offset-inline-end: 0;
}

here's the error we see:
TypeError: Cannot read property 'source' of undefined
    at /Users/jlaster/src/_os/postcss-bidirection/node_modules/postcss/lib/map-generator.js:43:25
    at /Users/jlaster/src/_os/postcss-bidirection/node_modules/postcss/lib/container.js:148:26
    at Rule.each (/Users/jlaster/src/_os/postcss-bidirection/node_modules/postcss/lib/container.js:114:22)
    at Rule.walk (/Users/jlaster/src/_os/postcss-bidirection/node_modules/postcss/lib/container.js:147:21)
    at /Users/jlaster/src/_os/postcss-bidirection/node_modules/postcss/lib/container.js:150:32
    at Root.each (/Users/jlaster/src/_os/postcss-bidirection/node_modules/postcss/lib/container.js:114:22)
    at Root.walk (/Users/jlaster/src/_os/postcss-bidirection/node_modules/postcss/lib/container.js:147:21)
    at MapGenerator.previous (/Users/jlaster/src/_os/postcss-bidirection/node_modules/postcss/lib/map-generator.js:42:23)
    at MapGenerator.isMap (/Users/jlaster/src/_os/postcss-bidirection/node_modules/postcss/lib/map-generator.js:33:25)
    at MapGenerator.generate (/Users/jlaster/src/_os/postcss-bidirection/node_modules/postcss/lib/map-generator.js:296:18)
    at LazyResult.stringify (/Users/jlaster/src/_os/postcss-bidirection/node_modules/postcss/lib/lazy-result.js:296:24)
    at /Users/jlaster/src/_os/postcss-bidirection/node_modules/postcss/lib/lazy-result.js:233:27

Once the other test fixtures are refactored, it would be easy to make a test function as simple as:
test('codemirror', t => run(t, "codemirror", {}));

tests are fixed in a491425b5f4d4578eb4ebd59f2b862c8b3e5ada1 , the reason is I miss-used map instead of filter for return proper declarations set. That lead to the node.insertAfter function won't work with undefined case.


No longer keeping client-side field whitelist

This moves the responsibility of validating field names to the server instead of the client.
In practice, this lets users request newer fields such as census2010, and ensures that the list in the library will not need to be continuously updated.

FYI test error is only for Python nightly. I don't have enough experience with Python to understand exactly what the issue is, but it appears to be unrelated to my change.

Closed with 84a687940a72ed6a8136e04ee83712db43e8844c
Tak skal du have!


Gpu finite difference image error

PR Checklist

[ ] No API changes were made (or the changes have been approved)
[ ] No major design changes were made (or the changes have been approved)
[ ] Added test (or behavior not changed)
[ ] Updated API documentation (or API not changed)
[ ] Added license to new files (if any)
[ ] Added Python wrapping to new files (if any) as described in ITK Software Guide Section 9.5
[ ] Added ITK examples for all new major features (if any)

Refer to the ITK Software Guide for
further development details if necessary.

hmmm, I must have done something wrong here. All I'm wanting to merge is 5cd5f1f0765c1a9001ec17ffde2c9bb2827df0d5

@seanm You need to do a rebase/squash, or that can be done on merge

I manually merged it after rebasing.

Thanks! Saves me from figuring out the git incantations. :)


Internal Errors when running builds

Description
Builds either don’t start running or fail with an internal error.
Area for Triage: Apple
Question, Bug, or Feature?:
Bug
Virtual environments affected

[ ] Ubuntu 16.04
[ ] Ubuntu 18.04
[ ] Ubuntu 20.04
[x] macOS 10.15
[x] macOS 11.0
[ ] Windows Server 2016 R2
[ ] Windows Server 2019

Expected behavior
The build would complete successfully.
Actual behavior
The build is either stuck on starting or fail with an internal error.
Repro steps
A description with steps to reproduce the issue. If your have a public example or repo to share,
please provide the link.

https://github.com/SwiftUIX/SwiftUIX/actions/runs/457625830
Re-run the workflow
Some of the builds won’t start and some fail with internal error

EDIT:
More workflow failures on a paid org:
https://github.com/interact-technology/medCompanion-Apple/actions/runs/466140750
https://github.com/interact-technology/medCompanion-Apple/actions/runs/466644185

Had the same issue. Re-running jobs however succeeded.
Could this somehow be related to long build queues when using macOS runner? (Happens on private/public repos)

Had the same issue. Re-running jobs however succeeded.
Could this somehow be related to long build queues when using macOS runner? (Happens on private/public repos)

@nakkht I tried re-running the same job I think 3 times and different jobs failed each time.

@nakkht I tried re-running the same job I think 3 times and different jobs failed each time.

I'm also experiencing the same issue. My workflow has two jobs. The Ubuntu 20.04 job started immediately, while the macOS 11 one failed to start until it was automatically restarted an hour and a half later.
https://github.com/dominikWin/badlogvis/actions/runs/458499059
However, with the automatically restarted job, it didn't replace the failing PR check of the job that failed to start. Now there are three checks - two passing and one failing.

I'm also experiencing the same issue. My workflow has two jobs. The Ubuntu 20.04 job started immediately, while the macOS 11 one failed to start until it was automatically restarted an hour and a half later.
https://github.com/dominikWin/badlogvis/actions/runs/458499059
However, with the automatically restarted job, it didn't replace the failing PR check of the job that failed to start. Now there are three checks - two passing and one failing.

This has been affecting us in LightGBM as well. I contacted Azure support this morning about this issue (you can read what I sent here) and got this response.

We're not aware of other reports of similar problems since you submitted this & we have not experienced any monitoring alarms, so this is likely limited to your user account or organization only. Unfortunately we are unable to offer support for that here.

I will now close this outage report ticket.

This has been affecting us in LightGBM as well. I contacted Azure support this morning about this issue (you can read what I sent here) and got this response.

We're not aware of other reports of similar problems since you submitted this & we have not experienced any monitoring alarms, so this is likely limited to your user account or organization only. Unfortunately we are unable to offer support for that here.

I will now close this outage report ticket.

I started to encounter this at least 27 days ago (with macos-11.0) and have a bunch of examples:

https://github.com/hyd-dev/cvt-trait/runs/1639089610
https://github.com/hyd-dev/cvt-trait/runs/1639089627
https://github.com/hyd-dev/cvt-trait/runs/1639037522
https://github.com/hyd-dev/cvt-trait/runs/1639021087
https://github.com/hyd-dev/cvt-trait/runs/1634598682
https://github.com/hyd-dev/rust-hut/runs/1639700518

At first, I guess this is related to #2247, but this continued to happen after #2247 has been closed.

I started to encounter this at least 27 days ago (with macos-11.0) and have a bunch of examples:

https://github.com/hyd-dev/cvt-trait/runs/1639089610
https://github.com/hyd-dev/cvt-trait/runs/1639089627
https://github.com/hyd-dev/cvt-trait/runs/1639037522
https://github.com/hyd-dev/cvt-trait/runs/1639021087
https://github.com/hyd-dev/cvt-trait/runs/1634598682
https://github.com/hyd-dev/rust-hut/runs/1639700518

At first, I guess this is related to #2247, but this continued to happen after #2247 has been closed.

+1 here. All of the repositories that have GHA set up I've contributed to after #2247 was resolved have either failing macOS 11.0 jobs, or they take half an hour on average to start.

+1 here. All of the repositories that have GHA set up I've contributed to after #2247 was resolved have either failing macOS 11.0 jobs, or they take half an hour on average to start.

Hi!
We are sorry for inconveniences. We are experiencing queuing issues with macOS 11.0, but unfortunately, currently we are unable to add more capacity for macOS 11.0 runners, so it is still in "preview" mode with only few machines, and macos-latest label still points to macOS 10.15.
Our engineers are actively investigating how we can improve the situation with queues. We will keep you posted.
Until then, please, switch to macos-10.15if it is not critical for you to use Big Sur.
Thank you for your patience.

Hi!
We are sorry for inconveniences. We are experiencing queuing issues with macOS 11.0, but unfortunately, currently we are unable to add more capacity for macOS 11.0 runners, so it is still in "preview" mode with only few machines, and macos-latest label still points to macOS 10.15.
Our engineers are actively investigating how we can improve the situation with queues. We will keep you posted.
Until then, please, switch to macos-10.15if it is not critical for you to use Big Sur.
Thank you for your patience.

Thanks for the update @AlenaSviridenko, hoping macOS 11.0 moves out of “preview” mode soon given it was released ~2months ago to the public.

Thanks for the update @AlenaSviridenko, hoping macOS 11.0 moves out of “preview” mode soon given it was released ~2months ago to the public.

For a few days already builds on macOS 11.0 agents no longer wait in the queue, they are just cancelled over and over, and even when restarted manually. I can't use macOS 10.15 agents as my framework explicitly requires new SwiftUI APIs for macOS, which are available only on maOS 11.0.
If the actual reason is the lack of free agents, could GitHub Actions at least avoid cancelling the builds? I'm fine with waiting in the queue, but why do builds need to be cancelled completely?

For a few days already builds on macOS 11.0 agents no longer wait in the queue, they are just cancelled over and over, and even when restarted manually. I can't use macOS 10.15 agents as my framework explicitly requires new SwiftUI APIs for macOS, which are available only on maOS 11.0.
If the actual reason is the lack of free agents, could GitHub Actions at least avoid cancelling the builds? I'm fine with waiting in the queue, but why do builds need to be cancelled completely?

@AlenaSviridenko Thanks for the response - is there a timeline when macOS 11 will move out of preview, and hopefully will also be updated to more recent version?
I believe most of us that point to macOS11 actually have to point to them, so upgrading more of your runners to new macOS and cancel the preview support might be the only solution to this.

@AlenaSviridenko Thanks for the response - is there a timeline when macOS 11 will move out of preview, and hopefully will also be updated to more recent version?
I believe most of us that point to macOS11 actually have to point to them, so upgrading more of your runners to new macOS and cancel the preview support might be the only solution to this.

Yes, I'm using macOS 11 runners so I can cross-compile for Apple Silicon Macs.

Yes, I'm using macOS 11 runners so I can cross-compile for Apple Silicon Macs.

We're using macOS 11 runners to be sure that the packages we're developing will build and pass tests on macOS 11.

We're using macOS 11 runners to be sure that the packages we're developing will build and pass tests on macOS 11.

Hi!
I am closing this issue, since after pool transition to private preview the situation got better, but we are still looking into the possibility to add more capacity to macOS 11.0 pools.
Please, feel free to create a new issue in case of any other questions. Thanks!

Hi!
I am closing this issue, since after pool transition to private preview the situation got better, but we are still looking into the possibility to add more capacity to macOS 11.0 pools.
Please, feel free to create a new issue in case of any other questions. Thanks!

@AlenaSviridenko As the maintainer of a project that used macos-11.0 as a os target for my CI, I removed that target when it was transitioned to "private preview" since it no longer seemed to work at all for me.  I was watching this bug in the hopes that it would inform me of when I could go back to using macos-11.0.  What should I do now?  Is there an issue that represents "users want to build for macos-11.0 but they can't"?  Or can I somehow request to be included in the "private preview"?  With this bug closed, we seem to be stuck in a state of limbo.

@AlenaSviridenko I’m still seeing a lot of failures, you can check the last ~5 runs here https://github.com/SwiftUIX/SwiftUIX/actions
I hope that by the time Xcode 12.5 is out of beta, that the situation is improved more given it requires macOS Big Sur.


Translatable class causing errors with Doctrine2 entity generator.

I am trying to use the entity generator for Doctrine2. I use this command:
php bin/doctrine orm:generate-entities ../MyApp/Model/Entity --generate-annotations=true

When I run this, I get this error:
[Doctrine\Common\Annotations\AnnotationException]
  [Semantical Error] The annotation "@Doctrine\ORM\Mapping\MappedSuperclass" in class Gedmo\Translatable\Entity\MappedSuperclass\AbstractPersonalTranslation does not exist, or
  could not be auto-loaded.

I tried to see if my classes were not being autoloaded correctly, so in my bootstrap.php file I put $x = new Doctrine\ORM\Mapping\MappedSuperclass(); just to see if it would throw an error. The weird part is that the command ran when I put that in there. However, what I found in my /MyApp/Entity/ folder was this??
/
Gedmo/
    Loggable/
        Entity/
            MappedSuperclass/
                AbstractLogEntry.php
    Translatable/
        Entity/
            MappedSuperclass/
                AbstractPersonalTranslation.php
                AbstractTranslation.php
    Tree/
        Entity/
            MappedSuperclass/
                AbstractColsure.php

It copied Gedmo's source code for some reason? The frustrating part of this as well is that I'm only using the Timestampable class, so I'm not even sure why it's looking in the Translatable class.
Here's a folder structure (with missing folders) of my app, in case that might explain something.
/
MyApp/
    Controller/
    Model/
        Entity/
        Domain/
        Service/
    View/
static/
tests/
vendor/
    bin/
    composer/
    doctrine/
    Gedmo/
    symfony/
    autoload.php
    autoloader.php
    bootstrap.php
    cli-config.php
index.php

And finally, my autoloader.php file:
<?php

spl_autoload_register(function ($class) {

    $vendorDir = dirname(__FILE__);

    $baseDir = dirname($vendorDir);

    $namespaces = include $vendorDir . '/composer/autoload_namespaces.php';
    $psr4 = include $vendorDir . '/composer/autoload_psr4.php';
    $classmap = include $vendorDir . '/composer/autoload_classmap.php';

    $custom_prefixes = [
        'MyApp\\' => [ $baseDir . '/MyApp/' ],
        'Gedmo\\' => [ $vendorDir . '/Gedmo/' ]
    ];

    $prefixes = array_merge($custom_prefixes, $namespaces, $psr4, $classmap);

    foreach ($prefixes as $prefix => $path)
    {
        $len = strlen($prefix);
        if (strncmp($prefix, $class, $len) === 0) {
            // get the relative class name
            $relative_class = substr($class, $len);
            // replace the namespace prefix with the base directory, replace namespace
            // separators with directory separators in the relative class name, append
            // with .php
            foreach ($path as $p) {
                $file = $p . str_replace('\\', '/', $relative_class) . '.php';
                // if the file exists, require it
    	    	if (file_exists($file)) {
    	    	    require $file;
    	    	}
            }
	    }
    }
});

extensions cannot hook into the entity generator, you should bypass it and update some parts manually in that case..

Same error for me. @l3pp4rd do you have more information ? Exception is thrown during any cli action (update, create, validate-schema, etc.).

Hi, so you have yml or xml mapping and attempt to generate entities?

Nope, i'm using annotations and want to generate/update/validate the schema. After playing around I'm stucked with the exact same error you've already "discussed" on google groups (https://groups.google.com/forum/#!topic/symfony2/6gBqevBmPV8).

well, there is an example application, running schema:update does not trigger any error. What framework are you using and how doctrine is bootstrapped?

This was awhile ago, so I'm not 100% sure if this is how I found my solution. But I switched to using vendor, therefore namespaces are autoloaded by that. Then, I added this line in my bootstrap file:
AnnotationRegistry::registerFile(__DIR__ . "/Gedmo/Timestampable/Mapping/Driver/Annotation.php");

Obviously change DIR to where ever you need it to be. Let me know if that works for you.

Thanks @GreeKatrina. Works like expected.

you could also try: Gedmo\DoctrineExtensions::registerAnnotations(); which registers all available annotations for you.


how to disable pkce flow?

I try to disable pkce usage by setting option pkce: false, but when see strategy, pkce still is ictive
my code:
const twitterStrategy =     // <2> Strategy initialization
new Strategy(
{
clientID: process.env.TWITTER_CLIENT_ID,
clientSecret: process.env.TWITTER_CLIENT_SECRET,
clientType: 'public',
callbackURL,
pkce: false,
},
// <3> Verify callback
(accessToken, refreshToken, profile, done) => {
console.log('Success!', { accessToken, refreshToken });
return done(null, profile);
}
)
console.dir(twitterStrategy);
but twitterStrategy is, and it seems that pkce is on
`
Strategy {
name: 'twitter',
_verify: [Function (anonymous)],
_oauth2: {
_clientId: 'Z3lZMlFzMHZocnIwbmtZc001Zmo6MTpjaQ',
_clientSecret: '9E2rUQlpQKuVwKAWpnLcJb53IxjSfhQiZA9sHYwfmB4yOFya1u',
_baseSite: '',
_authorizeUrl: 'https://twitter.com/i/oauth2/authorize',
_accessTokenUrl: 'https://api.twitter.com/2/oauth2/token',
_accessTokenName: 'access_token',
_authMethod: 'Bearer',
_customHeaders: {
Authorization: 'Basic WjNsWk1sRnpNSFpvY25Jd2JtdFpjMDAxWm1vNk1UcGphUTo5RTJyVVFscFFLdVZ3S0FXcG5MY0piNTNJeGpTZmhRaVpBOXNIWXdmbUI0eU9GeWExdQ=='
},
_useAuthorizationHeaderForGET: false,
_agent: undefined
},
_callbackURL: 'http://<IP_ADDRESS>:3000/social/callback/twitter',
_scope: undefined,
_scopeSeparator: ' ',
_pkceMethod: 'S256',
_key: 'oauth:twitter',
_stateStore: PKCESessionStore { _key: 'oauth:twitter' },
_trustProxy: undefined,
_passReqToCallback: undefined,
_skipUserProfile: false,
_userProfileURL: 'https://api.twitter.com/2/users/me?user.fields=profile_image_url,url'
}
`

PKCE is required by Twitter as OAuth2 provider. You can not authenticate with disabled PKCE.

We only provide authorization code with PKCE and refresh token as the supported grant types for this initial launch. We may provide more grant types in the future.

For more information see: https://developer.twitter.com/en/docs/authentication/oauth-2-0/authorization-code
Why do you want to disable PKCE? Is there anything that I missed?

i have app with separated frontend and backend and i try to implement twitter login. google and twitch login works ok, but there is a problem to make twitter login work, so i hoped that oauth 2 can work without pkce

PKCE is required by Twitter as OAuth2 provider. You can not authenticate with disabled PKCE.

We only provide authorization code with PKCE and refresh token as the supported grant types for this initial launch. We may provide more grant types in the future.

For more information see: https://developer.twitter.com/en/docs/authentication/oauth-2-0/authorization-code
Why do you want to disable PKCE? Is there anything that I missed?

i

I suspect this issue is just another aspect of the problem you reported in #36. Twitter OAuth 2.0 requires PKCE and PKCE requires session storage (express-session), so please check if you have it configured correctly. Consider also changing the clientType to confidential, since in your case it's a server handling the authorization flow, not the client application.
If I'm not mistaken, I think Google OAuth flow can be implemented without reliance on session, but I think it requires explicitly disabling state.


Implement schedules

Connect to #198.

Coverage decreased (-0.2%) to 98.82% when pulling de550f5a8b78795247fd731796daaefbc1d0431d on jangsutsr:issue198 into 0f25947d2d3a8f42a6e264774e9d7c58dd50e220 on ansible:master.

@jangsutsr We just had a customer put in a ticket who would like the ability to modify the schedules of management jobs using tower-cli. These don't show up in the normal job template list  so would need to be tied to unified job templates instead.

@michelleperz Thx for pointing out! Will implement system management job to work with schedule.

I think the challenge with allowing for system JT schedules is making the switch of the base endpoint. Whereas we have /api/v1/job_templates/N/, we have /api/v1/system_job_templates/N/ for system JTs. This might be simple to over-ride with the logic you have here. It does seem a little inconsistent because I don't think we can manage system JTs to begin with in tower-cli. If that starts to scope-creep, let's make a new issue for adding support for them generally.

I don't have a problems with the columns that you're trying to provide, but they don't seem to work. For example, in the following example, schedule pk=5 is a schedule on a job template.
$ tower-cli schedule get 5
== ==== ============ ================ ======= =======
id name job_template inventory_source project enabled
== ==== ============ ================ ======= =======
 5 asdf N/A          N/A              N/A        true
== ==== ============ ================ ======= =======

It should figure out that it is of the "job_template" type and then put the pk in that column.
Alternatively, you might have better luck just giving the unified_job_template pk. This won't conflict because of the nature of polymorphic models. However, I think it would still be good to provide the resource type as another column, if you do this.
This constant translation of input arguments to a different internal value is the same magnitude of task that I was doing with roles earlier.

@AlanCoding Hidding display of unified-job-related fields for now. Adding UJT pk is a good idea, while providing resource types an another column could be a bit tricky to implement, as it is not part of the model fields and extra logics are needed to extract resource type from return values, but I will try.

Coverage decreased (-0.1%) to 98.919% when pulling 24c5d0e676450b17d0dd0771e8a544fc82cad819 on jangsutsr:issue198 into 0f25947d2d3a8f42a6e264774e9d7c58dd50e220 on ansible:master.

Coverage decreased (-0.1%) to 98.925% when pulling 214d944fa99308cdbabdfcae77562e3a5bc1caf9 on jangsutsr:issue198 into 0f25947d2d3a8f42a6e264774e9d7c58dd50e220 on ansible:master.

Coverage decreased (-0.1%) to 98.925% when pulling 214d944fa99308cdbabdfcae77562e3a5bc1caf9 on jangsutsr:issue198 into 0f25947d2d3a8f42a6e264774e9d7c58dd50e220 on ansible:master.

Coverage decreased (-0.1%) to 98.926% when pulling 752be1ce4e729a74992413b531428d7703b9c413 on jangsutsr:issue198 into 7c283036d0f4e50c6250bc20c7c48f5ed674a92b on ansible:master.

Coverage decreased (-0.1%) to 98.926% when pulling 952f09ead2ad9a79f2f2d88647e77ef2cd3c8cda on jangsutsr:issue198 into 7c283036d0f4e50c6250bc20c7c48f5ed674a92b on ansible:master.

Coverage decreased (-0.1%) to 98.926% when pulling 704a1f8e3c603a6f97884e5351b7df000c3dc000 on jangsutsr:issue198 into 7c283036d0f4e50c6250bc20c7c48f5ed674a92b on ansible:master.

Checked out recent. Comments here.
The job template column is gone. If we could somehow provide unified_job_template column, that would still be very helpful. I guess not required for MVP right now.
$ tower-cli schedule get --name "quack regularily" -v
*** DETAILS: Getting the record. **********************************************
GET http://server/api/v1/schedules/
Params: {'name': u'quack regularily'}

== ================ =======
id       name       enabled
== ================ =======
 4 quack regularily    true
== ================ =======

The modify command is putting in defaults that it really shouldn't be. In the following example, it set enabled to True. I can repeat this where I had enabled set to False before that command, and it changes it back. That's definitely a bug.
$ tower-cli schedule modify --name asdf --rrule "DTSTART:20160930T131334Z RRULE:FREQ=WEEKLY;INTERVAL=1;BYDAY=SU" -v
*** DETAILS: Checking for an existing record. *********************************
GET http://server/api/v1/schedules/
Params: {u'name': u'asdf'}

*** DETAILS: Writing the record. **********************************************
PATCH http://server/api/v1/schedules/5/
Data: {'enabled': True, 'rrule': u'DTSTART:20160930T131334Z RRULE:FREQ=WEEKLY;INTERVAL=1;BYDAY=SU', 'name': u'asdf'}

Resource changed.
== ==== =======
id name enabled
== ==== =======
 5 asdf    true
== ==== =======

Those are the only 2 points I have. The create, delete, get, and list commands are all working as they should be.

@AlanCoding That bug was caused by another decorator inaccuracy in base.py. Kind of surprised that it has been there for so long.

Coverage decreased (-0.1%) to 98.927% when pulling a8e6b2de15761d3b62bad19e736e0be023def741 on jangsutsr:issue198 into 7c283036d0f4e50c6250bc20c7c48f5ed674a92b on ansible:master.


🐛 Content Start Position is not working in 2.16.3

Describe the bug
Content Start Position is not working in 2.16.3，No matter what value it is modified to, the display result remains unchanged.

Environment:

OS: Windows 11
Obsidian Version (if applicable): 1.7.7

Additional context
Add any other context about the problem here.

@smashell I am having a hard time reproducing this issue.
Can you please attach a sample vault here for me to work from?
There are three different ways to set the content start position for a note (with different levels of hierarchy importance).

Set content start in general settings (this is used if no other content start rules are set for the note -- default_
Set content start in "Folder Images" settings tab (this is used for notes defined in the specified folder if a note specific content start position isn't defined -- sett 3 below)
Set content start in the frontmatter of a note using the custom field name (default field name is content-start -- this setting has the highest priority and will overwrite any other content start rules that would apply to the note otherwise).

Please check your settings and how content start might be being applied to the note in question.
Thank you for taking the time to submit an issue 😀

https://github.com/user-attachments/assets/76ab9a60-4670-463d-8c48-e78b00bb8ab7


fixed bootstrap ready timeout call

Description
According to the documentation, the .kitchen.yml file contains the :ready_timeout parameter under machine_options directly - not bootstrap_options. Because bootstrap_options is passed to the ip_to_bootstrap function, :ready_timeout is not visible.
  # TODO: please create a better solution for the below
  # bootstrap_options shouldn't contain the :ready_timeout value - machine_options does
  # however, I don't want to break previous work or change all the calls made to this function
  # setting a default, as for most people bootstrap_options[:ready_timeout] will be nil
  # another possible workaround is to add a second entry under bootstrap_options in .kitchen.yml

Issues Resolved
The commit 0040fb8 essentially broke mine (and I'm guessing others who are following the doc's standard for the .kitchen.yml file). Added an OR comparison to essentially assign the value of 90 in case bootoptions[:ready_timeout] resolves to nil so as to no longer break.
Check List

[ ] All tests pass.
[ ] All style checks pass.
[ ] Functionality includes testing.
[ ] Functionality has been documented in the README if applicable

Thanks! I completely lost track of this, this is perfect. Thank you for the contribution!


Inject attributes into markup tags.

Is it possible to add tags to markup elements?
For example, adding target="_blank" to anchor tags:
_linkTargetBlank(mobiledoc) {
  let markups = mobiledoc.sections[0] || [];

  // new anchor markup sections
  let newMarkups = markups.map(markup => {
    // skip everything but anchors
    if (markup[0] !== 'a') {
      return markup;
    }

    markup.pushObject(['target', '_blank']);
    return markup;
  });

  // replace markup sections
  mobiledoc.sections[0] = newMarkups;
  return mobiledoc;
},

Customizing the rendering of markups is not supported today, though Garth and I have discussed it.
If you want to use target blank, I suggest using JavaScript to capture the clicks on links and open windows that way.

It would be a welcome feature. Thank you for your response & suggested workaround.


typo: validaiton -> validation

@nschonni : Thanks for your contribution! The author, @davidmu1, has been notified to review your proposed change.

@tfosmark : Thanks for your contribution! The author, @, has been notified to review your proposed change.


which version can exactly run success?

i have worked a whole week for spectator view on hololens2 glass and android phone and ipad,but still cannot run it successful!
1.i use master version and unity2019.2.19f1,package out uwp and .apk,use qrcode detection and(or) azure spatial detection,hololens is ok,but android shows tracking always losted status,i change wifi and network,ping the connectivity,network works fine,but android phone just cannot tracking.
2.i use release 1.1.0,and unity2018.3.14f1,hololens works fine,hololens it's aways ok,but android .apk crashed on cellphone,when open,it crash,android studio logcat shows "Microsoft.MixedReality.SpectatorView.Unity.ScreenRecorderActivity" caused error.
3.both above mssv version clone on mac,run SetupRepository.sh,settle the external project,then open  SpectatorView.Example with matching unity editor,package out xcode project,then package on ipad,finally,100 undefined symbols error come out,whether i use which version of unity editor pack out the xcode project,the "100 undefined symbols" still come out.
now i prepare to use release 1.0.0,follow the instructions again,i hope it works fine,and if some one tell me which exactly version could run successfull,i appreciate that!
these instructions is simple for operate,the main problem is download speed is very slow in china region,every version tooks a whole day to download the external project,then i use half to one hour edit setting and package,then it tell me failed,if i got the high speed for download,i could test all version for spectator view.

I got it working on 2019.2.19 and the latest code of MixedReality-SpectatorView. I'm using an android phone capable of ARCore though.
I encountered some issue regarding the network sockets between hololens and android phone but I got it resolved using the steps from here:
https://forum.unity.com/threads/il2cpp-failing-in-windows-machine.891436/

ten days passed,i have run it succeed!
the network connection problem solved by changing a new wifi,last saturday i was boring at home,then try to work it,and connect works fine! ,i don't understand,the wifi in my company is broken?but i always use it for LAN program testing and pinging right.
but,bad question is:i still can't use the github's project to configurate and run,at present,i found a fine online frient(a good AR/VR programmer),he has one backup of SpectatorView at 2021.4,he configurated it already,then send for me,so solved my problem.
now,i had added local socket network server and client function in project,satisfy my function needy,it works good now,not only could observe the realtime scene as spectator but also send some message to control and display new things.

by the way,i have test several version of unity,and find out only 2019.4.22f1c1 has no problem

That is good to know! I hope you get everything work smoothly for your project.
What device are you using btw? For android, I encountered a problem that video recording is not working.. By chance did it work with the spectator view backup that you got?

android cellphone realme gt neo,as you said,i just test the screen recording function,it does't work either,the countdown stuck at 0,i also notice that:the SpectatorViewExample does't got the storage readwrite permission,so even if the Example could record video,but it can't write on disk,unfotunate,the notebook i use for programming has being taken by my workmate,now i only got a imac without nothing on it,so i can't test add permission for .apk and test it -_-,i think you can test add permission what recording function needy,or add another video record plugin such as UnityRecorder/NatCorder etc,if i got back my notebook,i will post the backup project to github and publish link here.

https://github.com/yinhun2012/MSSV


Get email user from FirebaseUser (Android)

I wan't to get email from FirebaseUser after login with GoogleSignInOptions
void setupFireBase(){
        GoogleSignInOptions gso = new GoogleSignInOptions.Builder(GoogleSignInOptions.DEFAULT_SIGN_IN)
                .requestIdToken(getString(R.string.default_web_client_id))
                .requestEmail()
                .build();
        mGoogleApiClient = new GoogleApiClient.Builder(this)
                .enableAutoManage(this, this)
                .addApi(Auth.GOOGLE_SIGN_IN_API, gso)
                .build();
   ......
    }

After login successfully and get current firebase user. I can get user Display name but i can't get email of user.
I had followed document : https://firebase.google.com/docs/auth/android/google-signin but i can't get right email from firebase account mAuth.getCurrentUser().getEmail() but it return null.
I had create
I used firebase 9.4.0 and 9.6.0.

@phukhanhlee a few things:

This should be filed on the repo firebase/quickstart-android so I am going to close it here.
When you go to the Auth > Sign-In Methods page of your project in the Firebase console. do you have One account per email address on or off?  If you allow multiple accounts per email address, you will get null for FirebaseUser.getEmail().

How do i get the email if i have One account per email address on ?


ckpts json files not available

I am trying to run your example (biomedgpt_inference.ipynb) and the OpenBioMed/ckpts/protein_ckpts/esm2-3b/config.json file is not found. Actually, there are no json files in the ckpts folder. Are theu going to be uploaded or they somewhere I have not notice? Thank you in advanced

Thanks for your attention in our work! Please refer to this link and this link to download the JSON files of model architecture.

But the files I am looking for are not there.

Downloading config.json from https://huggingface.co/facebook/esm2_t36_3B_UR50D/tree/main and put it under OpenBioMed/ckpts/protein_ckpts/esm2-3b/ shall fix the problem.

These files are missing as well: ./ckpts/text_ckpts/biomedgpt-lm-7b

The checkpoints and configs can be downloaded from huggingface.


Add example Jupyter notebooks to online docs

We can also add example Jupyter notebooks to the sphinx docs using the already-installed nbsphinx package.

That sounds nice. Perhaps we need to get the CI testing of the notebooks working before we do that though?

We should likely migrate to py.test so we can use this plugin for that. I'll create a new issue.


Provide viur-cli import tool

viur-cli import command and sub-commands, providing general export tooling for ViUR databases, kinds or specific entities, with the following features:

[ ] Import from Google Datastore Backup
[ ] Import from JSON
[ ] Import from CSV (see #3, csvimport.py)

The features from csvimport.py are necessary, e.g. looking up for keys or codes, replacing values etc. (logics-expressions).

As commented in https://github.com/viur-framework/viur-cli/issues/5#issuecomment-1882918523, this feature would be very useful and should be done using viur-scriptor, but be part of viur-cli.


Feature Request: ResponseBuilder

Related to this comment: https://github.com/seanmonstar/reqwest/issues/154#issuecomment-415962705
It would be nice to be able to manually build Response objects so we can mock out the HTTP interactions in tests

Hm, perhaps adding a From<http::Response> for reqwest::Response, or something like that?

Yea, that would be perfect, actually

Yea, I noticed those too when suggesting it...

Looking in extensions for a Url is also what I was thinking... I'd suggest it should be a unique wrapper newtype, since Url by itself could have different meanings if extensions were filled by other libraries. If it doesn't exist, a sentinel value could make sense...
The KeepCoreThreadAlive type could be changed to hold an Option<Arc<InnerClientHandle>>, and then an empty one can be created.


[multiple selection] Allow disable row (checkbox) and ability to SelectAll

Expected/Feature Behavior:
On multiple selection,  allow specific row (checkbox) to be disabled and the header checkbox (selectall) should be enable when there is one or more allowed selection. The selection should only be those item not disabled for that current page.

@devuser123x1, I'm working on a major architecture revisit at the moment. Anyway, I will include this as a feature request in the backlog.


Introduce __eq intrinsic

This PR introduces an intrinsic __eq<T> (currently T is constrained to integers and bool) that can replace (as shown by the changes in ops.sw) assembly definitions of eq for these types.
edit:

The intrinsic is lowered to Instruction::Cmp in the IR.
The existing intrinsic framework is refactored to normalise how we represent all intrinsics.

#855

I've not looked at the code but I have noticed that there is an issue linked in the description.
If this PR is meant to close the issue then you can use one of a few special keywords that github provides in order to automatically close that issue when this PR is merged in (so that you do not have to close it yourself). You can find more info here.

The IR already as a cmp eq instruction which I'd hope could be used.
https://github.com/FuelLabs/sway/blob/master/sway-ir/src/instruction.rs#L34-L35
https://github.com/FuelLabs/sway/blob/master/sway-ir/src/instruction.rs#L110-L114
If it's not quite functional enough then it should be made so.
Before we get to IR the compiler needs to confirm that the types of each argument are only the builtin types and not structs or other custom types.  And then for reference types like string or b256 they should use different IR, or potentially use a MEQ/memcmp intrinsic instead.
Creating ASM blocks in IRgen isn't really where we want to go, sorry.

The IR already as a cmp eq instruction which I'd hope could be used.
If it's not quite functional enough then it should be made so.

Makes sense. I'll look at using this and get back.

Before we get to IR the compiler needs to confirm that the types of each argument
I'm already doing this, more or less.

And then for reference types like string or b256 they should use different IR, or potentially use a MEQ/memcmp intrinsic instead.
Okay. I'm not handling this right now right now though.

Creating ASM blocks in IRgen isn't really where we want to go, sorry.
I understand this. That's why I pointed out the two options we have.

I've not looked at the code but I have noticed that there is an issue linked in the description. If this PR is meant to close the issue then you can use one of a few special keywords that github provides in order to automatically close that issue when this PR is merged in (so that you do not have to close it yourself). You can find more info here.

Thank you. This PR isn't meant to close the issue, it only implements it partially.

Creating ASM blocks in IRgen isn't really where we want to go, sorry.

I understand this. That's why I pointed out the two options we have.

OK, cool.  Hopefully cmp will work well enough.  The IR needs a bunch of work still -- it doesn't do pointers properly IMO (or to my satisfaction, I guess) which makes by-reference semantics a bit ambiguous, like comparing larger types.  So if it's not yet manageable it wouldn't be the end of the work to allow cmp eq to compare by-ref types for now (and do the correct magic in ASMgen) and we can fix it for pointers later.

Ah I see this commit:

@vaivaswatha
Refactor intrinsics to all have arg and type arg vectors

I see you've already had the same thoughts. Do you find it more ergonomic?

Ah I see this commit:

@vaivaswatha
Refactor intrinsics to all have arg and type arg vectors

I see you've already had the same thoughts. Do you find it more ergonomic?

@otrho suggested that we represent intrinsics in a uniform way, for example during parsing, and later do the checks (number and type of arguments and type arguments) later on. So that motivated me to have this current representation. The idea is that when we have more intrinsics, we can put such information (number of args, type args etc) in a table and validate it with just one piece of code for all intrinsics (I'm sure we'll need exceptions, but in general it should work).


Inconsistent go1.13 pkg/mod/cache/download folder.

What version of Go are you using (go version)?
go version
go version go1.13.1 linux/amd64
Does this issue reproduce with the latest release?
Yes
What operating system and processor architecture are you using (go env)?
go env
GO111MODULE=""
GOARCH="amd64"
GOBIN=""
GOCACHE="/tmp/b/cache"
GOENV="/tmp/b/env"
GOEXE=""
GOFLAGS=""
GOHOSTARCH="amd64"
GOHOSTOS="linux"
GONOPROXY=""
GONOSUMDB=""
GOOS="linux"
GOPATH="/tmp/b"
GOPRIVATE=""
GOPROXY="https://proxy.golang.org,direct"
GOROOT="/nix/store/2kzdq7gyxz9jqfqcrp97z2y03vbw4glc-go-1.13.1/share/go"
GOSUMDB="sum.golang.org"
GOTMPDIR=""
GOTOOLDIR="/nix/store/2kzdq7gyxz9jqfqcrp97z2y03vbw4glc-go-1.13.1/share/go/pkg/tool/linux_amd64"
GCCGO="gccgo"
AR="ar"
CC="/nix/store/7hzmz83nv8khpwsk858yaac7y3idh0a7-gcc-wrapper-8.3.0/bin/cc"
CXX="g++"
CGO_ENABLED="1"
GOMOD=""
CGO_CFLAGS="-g -O2"
CGO_CPPFLAGS=""
CGO_CXXFLAGS="-g -O2"
CGO_FFLAGS="-g -O2"
CGO_LDFLAGS="-g -O2"
PKG_CONFIG="pkg-config"
GOGCCFLAGS="-fPIC -m64 -pthread -fmessage-length=0 -fdebug-prefix-map=/tmp/go-build511834670=/tmp/go-build -gno-record-gcc-switches"

What did you do?
rm -r /tmp/a /tmp/b
mkdir -p /tmp/a/src
git clone https://github.com/wata727/tflint.git /tmp/a/src
cd /tmp/a/src && GOPATH=/tmp/a GOCACHE=/tmp/b/cache GOENV=/tmp/a/env go mod download
mkdir -p /tmp/b/src
git clone https://github.com/wata727/tflint.git /tmp/b/src
cd /tmp/b/src && GOPATH=/tmp/b GOCACHE=/tmp/b/cache GOENV=/tmp/b/env go mod download
diff -r /tmp/a/pkg /tmp/b/pkg

What did you expect to see?
No difference in diff
What did you see instead?
With go1.12, the diff shows no difference, with go1.13 it shows
Only in /tmp/b/pkg/mod/cache/download/sumdb/sum.golang.org/tile/8/0/x001/216.p: 31
Only in /tmp/a/pkg/mod/cache/download/sumdb/sum.golang.org/tile/8/0/x001/216.p: 52

This behavior is used by the nix build system to download and store dependencies for go programs. We are seeing inconsistent hashes with go 1.13 due to differences in the module cache related to the go sum server, which is breaking the build system for certain packages.
This appears to effect the following packages and versions.
<EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS>We have some discussion in https://github.com/NixOS/nixpkgs/pull/71049 and https://github.com/NixOS/nixpkgs/pull/68135
DIsabling the sumdb fixes this. It looks like we're getting a new proof(?) every time for some packages(?).

These are partial tiles as described in https://research.swtch.com/tlog#serving_tiles. They will appear for any part of the tree that isn't completely filled out yet. That's up to half of the tree at any given time, if I remember the design correctly. The packages that are causing problems are probably just in a newer part of the tree than the rest.
I am extremely surprised that disabling the sumdb doesn't change anything. Are you absolutely sure it still downloads those files with GOSUMDB=off? Though I wouldn't necessarily recommend that -- presumably you want to verify that you've got the right files?

Sorry screwed up my negative, GOSUMDB=off fixes this, but in general we would like to use the sum proxy since it provides some nice content security.

I guess since the proof tree is always changing, we should just zero out the pkg/mod/cache/download/sumdb folder when generating the build inputs.

That's what I'd do. Closing, since this is all working as intended.

that still happens when install process breaks for some reason (sudden reboot for example) and that manual fix works. But shouldn't go installer detect that and fix that all by itself? Or at least with a prompt