[Bug]: MudExFileDisplay won't load file from Stream

Contact Details
No response
What happened?
I have a Blazor Server with a upload folder where files are uploaded.
If i want to display one of these files from stream using the following command:
await DialogService.ShowFileDisplayDialog(stream, uploadedFile.uploaded_file_orig_file_name, mimetype, HandleContentError, ex => ex.JsRuntime = JS);
the display control shows as follows:

I checked if the stream is available, which it is.
Unfortunately i cannot use the newest version of MudEx because of a bug in MudBlazor since 6.5.
Expected Behavior
The file should be displayed.
Screenshots
No response
What application type are you referring to?
Other
Custom Application Type
Server
MudBlazor.Extension Version
1.7.61
MudBlazor Version
6.4.1
What browser are you using?
Chrome
Sample Solution
No response
Pull Request
No response
Code of Conduct

[X] I agree to follow this project's Code of Conduct

Stream is fully available on client side?
Can you check if it works with a data url for the stream?
DataUrl.GetDataUrl(stream.ToByteArray())
That means in your case
using Nextended.Blazor.Models;
...

await dialogService.ShowFileDisplayDialog(DataUrl.GetDataUrl(stream.ToByteArray()), uploadedFile.uploaded_file_orig_file_name, mimetype, HandleContentError, ex => ex.JsRuntime = JS);

What do you mean by "fully available on client side"?
File is stored on the servers filesystem.
Testing as follows:

This test does not work.
If you uncomment the bytes-assignment and the second dialog call and comment out the first dialog call you can open small files. Large files get an "URI too Long"-Exception.

Ok understand. I also fixed stream handling but that doesnt help you at all. Because for native file display (That means without custom IMudExFileDisplay implementation like Zip or Markdown handling) also a is created from stream because depending on mimetype iframe, img tag or object tags are used and they need a url

if youre files came from server and I would have you problems I would ensure to have a url for the file itself.
For example if you have your files in a database (or whatever) i would create a Controller to read the files.
I mean like this
using Microsoft.AspNetCore.Mvc;

[Route("api/[controller]")]
[ApiController]
public class FileController : ControllerBase
{
    private readonly IFileRepo _fileRepo;

    public FileController(IFileRepo fileRepo)
    {
        _fileRepo = fileRepo;
    }

    [HttpGet("{id}")]
    public IActionResult GetFileById(string id)
    {
        byte[] fileData = _fileRepo.GetFile(id);
        if (fileData == null || fileData.Length == 0)
        {
            return NotFound();
        }

        return File(fileData, "application/octet-stream"); // Set the appropriate MIME type if you know it.
    }
}

than you can use a url like api/file/123
Hope that helps a bit.

Thank you very much for sharing this bug, i fixed it and it will released in 1.7.68 you can have a look at preview package 1.7.68-prev-2309141720-main
also you can see it running here https://mudex.azurewebsites.net/handle-file-as-streams (all files here are set as stream see code)
Would you explain why you cant update MudBlazor to 6.9 ?

I'll test it tomorow..
Thank you in advance!
I cant Upgrade because of a Bug i reported in MudBlazor (https://github.com/MudBlazor/MudBlazor/issues/7237).
I use exactly that combination of options in MudDataGrid and unfortunately nobody is responding at this time.. but we will see. I personally cant find a working workaround for this so i am Stuck with this Version for the moment.

I created a compatible package with MudBlazor 6.4.1 for you. Hope that helps.
If it does please close this issue.
1.7.68-prev-2309150848-for-mudblazor-6.4.1.

Thanks for the Package!
It helps for mostly all use-cases. Mostly, because i experienced that larger PDF-Files are not loaded.
They can be downloaded, but the preview pane keeps empty.
Any Idea on this?
Update:
It seems that i can update my project to something above 6.4.1 because somebody posted a workarround. I need to do some testing to validate this.

While further testing it seems that the file display components dont dispose properly. May be that its my code doing sth wrong, but RAM-usage increases on every dialog call and stays up even when GC takes place.
Sorry for asking so many questions ;)

No problem your welcome.
For question 1: Pdf and all other native display files like image etc where tag is used needs an url, and maybe your pdf is to big for a data url. I guess you need to playaround with it, or if you can provide a sample pdf I will have a look if I can do something.
For question 2: Stream is currently not disposed on component side because I dont want to close given streams because this can cause side effects. (However for MudExFileDisplayZip they are copied and maybe I need to rethink about disposing given streams )

For your first answer:
I once build a simple file preview (mostly only pdf and images) facing the nearly same problem with larger files. I found a way to do this using following function in "_host.cshtml" :
window.openFileFromStream = async (fileName, contentStreamReference, fileType) => {
    const arrayBuffer = await contentStreamReference.arrayBuffer();
    const blob = new Blob([arrayBuffer], { type: fileType });
    const url = URL.createObjectURL(blob);
    //document.querySelector("embed").src = url;

    const elem = document.getElementById("preview-element");
    if(elem != null){
        elem.src = url;
        await new Promise(resolve => setTimeout(resolve, 1000));
        URL.revokeObjectURL(url);
    }
    else{
        URL.revokeObjectURL(url);
    }

}

I personally dont know if its a nearly clean idea to get rid of the file size issue. Maybe you can check?
Second answer:
I am using this call:
string mimetype = Utilities.Utilities.GetMimeType(uploadedFile.uploaded_file_orig_file_name);

//await DialogService.ShowFileDisplayDialog($"https://localhost:1235/api/file/{uploadedFile.uploaded_file_id}", uploadedFile.uploaded_file_orig_file_name, mimetype, HandleContentError, ex => ex.JsRuntime = JS);

using (Stream stream = GetFileStream(uploadedFile))
{
    await DialogService.ShowFileDisplayDialog(stream, uploadedFile.uploaded_file_orig_file_name, mimetype, HandleContentError, ex => ex.JsRuntime = JS);
}

Seeing the code i would expect the stream to get closed and als release resources. Is there any possibilities for your component to keep data that was read from stream?

Can you test this package? 1.7.68-prev-2309182049-stre...
You can now set url handling to blob the MudExFileDisplay has now a Parameter for that called StreamUrlHandling
If you use a dialog you can set it like this
    private async Task OpenAsDialog()
    {
        var parameters = new DialogParameters {
            { nameof(MudExFileDisplay.StreamUrlHandling), StreamUrlHandling.BlobUrl }
        };
        await dialogService.ShowFileDisplayDialog(SampleFile.Stream, SampleFile.Name, SampleFile.ContentType, HandleContentError, null, parameters);
    }```

Thank you for your always fast replies!
Larger PDF work now! Unfortunatly .zip-files now are broken.

The error is the same on calling the Dialog without the parameters.

The zip and info bug reproducible should be enough. You have a server side rendered project? Maybe there is the difference. Because in my sample https://mudex.azurewebsites.net/handle-file-as-streams it works well

Yes, my project is rendered server side. I tried to open following zip:
open3A 3.8.zip
Dialog starts showing the loading spinner while the debugger prints the error from the screenshot posted earlier ("Cannot access a closed stream)
Dialog call is exacly like you suggested:
Your code:
private async Task OpenAsDialog()
    {
        var parameters = new DialogParameters {
            { nameof(MudExFileDisplay.StreamUrlHandling), StreamUrlHandling.BlobUrl }
        };
        await dialogService.ShowFileDisplayDialog(SampleFile.Stream, SampleFile.Name, SampleFile.ContentType, HandleContentError, null, parameters);
    }

My code:
private async Task OpenAsDialog(UploadedFileModel uploadedFile)
{
    //DialogOptionsEx options = new DialogOptionsEx() { JsRuntime = JS};

    //Stream stream = null;
    try
    {
        string mimetype = Utilities.Utilities.GetMimeType(uploadedFile.uploaded_file_orig_file_name);

        //await DialogService.ShowFileDisplayDialog($"https://localhost:1235/api/file/{uploadedFile.uploaded_file_id}", uploadedFile.uploaded_file_orig_file_name, mimetype, HandleContentError, ex => ex.JsRuntime = JS);

        var parameters = new DialogParameters {
            { nameof(MudExFileDisplay.StreamUrlHandling), StreamUrlHandling.BlobUrl }
        };

        using (Stream stream = GetFileStream(uploadedFile))
        {
            await DialogService.ShowFileDisplayDialog(stream, uploadedFile.uploaded_file_orig_file_name, mimetype, HandleContentError, ex => ex.JsRuntime = JS, parameters);
            //await DialogService.ShowFileDisplayDialog(stream, uploadedFile.uploaded_file_orig_file_name, mimetype, HandleContentError, ex => ex.JsRuntime = JS);
        }
    }
    catch(Exception e)
    {
        Console.Write(e.ToString());
    }

}

Hope this helps ;)

Sorry for Late answering today i was not at home. I see your problem. Your scope is finished to early because you are await the show of the dialog only what returns a IDialogReference from MudBlazor if you want to await the closeing to ensure dispose afterwards you need to await the result of the IDialogRefeference
       using (var stream = SampleFile.Stream) {
           var res = await dialogService.ShowFileDisplayDialog(stream, SampleFile.Name, SampleFile.ContentType, HandleContentError, null, parameters);
           await res.Result;
       }

Thanks for the Explanation!
Seems like everything is working right now.


Build configuration ID is not the one selected in the list

On Teamcity 10.2, the ID selected is not the one slected in the proposed list.

but the id of "Test Matriciel called" is stored as "BT493" and not "Testing_TestEchoMatricielCalled"
(You can see the id when you select "settings" tab)

So a workaround is to modify the ID of the called configuration.

@Mathieu4D  I'm sorry I don't have a time to work on this plugin. If you have time to prepare PR, I will be glad to review it and merge


Make align_buffers as public API

Which issue does this PR close?

Closes #.
Rationale for this change

Buffer alignment is not automatic for FFI (https://github.com/apache/arrow-rs/pull/4681#issuecomment-1674592087). Although there is ArrayData::align_buffers for that, but it is not public API so we cannot use it outside this crate.
What changes are included in this PR?

Are there any user-facing changes?

Hmm, but for FFI API, from imported array and schema, you get a ArrayData
already instead a builder.
On Tue, Sep 26, 2023, 15:28 Raphael Taylor-Davies @.***>
wrote:

@.**** commented on this pull request.
The public API is
https://docs.rs/arrow-data/latest/arrow_data/struct.ArrayDataBuilder.html#method.build_aligned
Otherwise you have to build an ArrayData with incorrect alignment to call
this method, which is technically unsound per the public API contract
—
Reply to this email directly, view it on GitHub
https://github.com/apache/arrow-rs/pull/4863#pullrequestreview-1645296691,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AAAQZ5ZANDZ6XUX7MCT4IHDX4NJI5ANCNFSM6AAAAAA5IKPF7U
.
You are receiving this because you authored the thread.Message ID:
@.***>

Eh, fair enough. Its a bit off, but 😅


Need to use --force for arguments?

This documentation PR flagged that you need to now use arguments: --force true with the action. Could you please take a look? If this is the new way to implement the action please let me know so that we can approve the PR.

I got a warning when using force: true while when using arguments: --force true worked with no warnings hence I have suggested that PR change. Please do let me know if that's not correct.

This was perhaps a documentation issue; there wasn't support for force input in the action.yml
I've approved the documentation change, @juliakm you can take it forward :)


Add ability to specify PATH used by Git extension

I tried looking if this already exists but couldn't find it. I'm trying to use custom binaries for e.g. the git credential helper and for gpg signing. The location of these binaries are in terminal's shell's PATH and work when I use git from the command line.
However, when trying to use the same commands via the Git extension in VSCode, git seems to be unable to find the custom binaries.
I'd like a way to customize the PATH as it is seen by the Git extension via a setting.

@lumaxis, sorry for not getting back to you on this?
What is the OS that you are using? How do you start VS Code?
If you start VS Code from the terminal where PATH is set, VS Code should "inherit" the same environment.


Change rendering app to government-frontend

⚠ This repo is Continuously Deployed: make sure you follow the guidance ⚠
WHAT
Update rendering app to government-frontend
WHY
We'd like to migrate the rendering so we can retire manuals-frontend as on trello ticket.
Trello
https://trello.com/c/e8XNP4Sk/1128-manuals-change-manuals-publisher-and-hmrc-manuals-api-rendering-app
RELATED
https://github.com/alphagov/hmrc-manuals-api/pull/664
https://github.com/alphagov/govuk-developer-docs/pull/3460

Ah, it was because of the change of rendering app -> https://github.com/alphagov/publishing-e2e-tests/pull/482


Object merging in tracking

Hi, do you have any suggestions how to avoid grouping multiple spatially-separated objects into one during tracking?

example:

final output from frame t-1 contains one object labels o1
run tracking for frame t. Tracking outputs 2 disjoint objects with with the same label o1
How to update the code to make sure tracking doesn't output multiple objects under the same label?

Commonly, it's reasonable to have multiple spatially separated objects with the same ID when an object is partially occluded and separated.

If you want to keep only one object from multiple multiple spatially separated objects, a possible solution is to remove the object regions with lower confidence, which can be calculated by the confidence sum of all the region pixels.


As a developer, I would like to see a component diagram in the wiki

[x] Component diagram

Story points: 2
Time estimation: 1 hour
RISK: Low
Priority: High

Validation: I should the diagram in the wiki

Both Michel and Brian have 1sp for that task


Update import path in pure canvas example

In current version, iced::pure::canvas would be unresolved.
It should be iced::pure::widget::canvas.

Why it failed on Ubuntu?


[nvtt] does not support arm64 osx

/Users/leanderSchulten/git_projekte/Lichtsteuerung/vcpkg/buildtrees/nvtt/src/2188752e3f-397baa0c14.clean/src/nvcore/Debug.cpp:611:8: error: "Unknown CPU"
#      error "Unknown CPU"
       ^

@MonicaLiu0311 Why is this https://github.com/microsoft/vcpkg/labels/requires%3Aauthor-response ?

@MonicaLiu0311 Why is this  requires:author-response Waiting for the PR author to respond to this PR ?

I'm so sorry, there was a message that didn't get sent in the drafts, I wanted to remove the patch's header to make it smaller, but that's okay, this can be changed in the next update.


Add Sabayon icon

This adds a simplified logo for Sabayon.
cf issue #14
I did not include the generated files yet, because I had the following error for the preview picture:
./compile.sh: 3: ./compile.sh: wkhtmltoimage: not found

(only wkhtmltopdf is currently in Ubuntu repositories)

The wkhtmltopdf package contains wkhtmltoimage (see packages.ubuntu.com/xenial/amd64/wkhtmltopdf/filelist).

I cherry-picked 75fa4998c0e4512de7bc6f14569f159990c67cf0 into master. Thanks!


Add key to switch search modes

Perhaps ctrl-m
This could cycle between searching globally, per dir, or per session

Maybe use the search modes similar to https://lib.rs/crates/broot /foo is a regular expression. Ofc the slash is a valid command value, so maybe a : could work as the prefix

You're referring to this paragraph?

You may sort by launching broot with --sort-by-size or --sort-by-date. Or you may, inside broot, type a space, then sd, and enter and you toggled the :sort_by_date mode.

I like the idea of :! That would actually make it pretty similar to vim :thinking:
so we could have:
:sort-global, :sort-session, :sort-dir- with :sg, :ss, :sd as short versions
Then as you suggest, /foo, /^foo etc would work as regex searches, while leaving off the / does the normal regex-less search
I really like this idea, thank you :D

Is this implemented now? I don't see any recent commits or PRs that address it.

Nope, I've closed it in favour of #118
Just trying to tidy the issues up :)


Allow l2met fractional milliseconds

Coverage remained the same at 98.754% when pulling 08ff502354d8781a81316cd93a7fb926d916de63 on l2met-timing into 9af16189d4f094455017f816fd8e2f8956f2d350 on master.


Support strings with JSON as input

I was expecting to use this project as a module and work over a parsed string that contains JSON, but it seems I need to bring my parsed data if I want to run a query

You can parse a string containing JSON with the fromjson function from standard jq:
input:
{
  "foo": "[1,2,3,4]",
  "bar": "{\"baz\":[[\"bye\",{\"en\":\"bye\"}],[\"hello\",{\"it\":\"salve\"}]]}",
  "result": "{\"http\":{\"status\":200}}"
}

jq query:
{
  total: (.foo | fromjson | add),
  greeting: (.bar | first(fromjson.baz[] | select(.[0] == "hello")))[1].it,
  status: (.result | fromjson.http.status),
}

output:
{
  "total": 10,
  "greeting": "salve",
  "status": 200
}

Maybe fromjson will help. I can't provide further instruction for feature request with no examples.

@shackra You should be able to decode/unmarshal into a any using the standard library json package and use as input. Something like https://go.dev/play/p/xfaNhSczfSV


[JS] Navbar components implementation

Let's add JS
uwu

We're implementing Nightlight engine soon.


ITMS-90809: Deprecated API Usage UIWebView

I'm using the latest version (4.1.1) of this plugin, but I'm still getting the deprecation message. This is happening in multiple cordova projects, I'm working on.
Any suggestions on how to fix or find the problem?

#536


[BEAM-7516][BEAM-8823] Refactoring FnApiRunner execution logic

This includes the style / refactoring changes related to https://github.com/apache/beam/pull/10291 - to ideally simplify the review of actual functional changes in https://github.com/apache/beam/pull/10291.
r: @robertwb

Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

[ ] Choose reviewer(s) and mention them in a comment (R: @username).
[ ] Format the pull request title like [BEAM-XXX] Fixes bug in ApproximateQuantiles, where you replace BEAM-XXX with the appropriate JIRA issue, if applicable. This will automatically link the pull request to the issue.
[ ] If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.


future-compatibility for vrs 1.2+

The genesis of this PR was my miscommunication and miscoordination of the vr.json → vrs.json renaming with vrs-python. Instead of making vr-spec accommodate vrs-python, I'd like to shift the fix back to vrs-python. Specifically:

Keep the intended naming: 1.1 uses vr.json; 1.2 uses vrs.json. Client code has to adapt as part of that support. That means dropping this PR.
Clarify the intended (but botched by me) correspondence between vrs-python and vr-spec: develop ~ develop, 0.6 ~ 1.1, and (soon) 0.7 ~ 1.2. This is already done in https://github.com/ga4gh/vrs-python README.
Ensure that vrs-python develop and 0.6 branches correctly correspond with vr-spec branches and that they work. (Done and pushed)
Release 0.6.3. (Done; see https://pypi.org/project/ga4gh.vrs/0.6.3/)

The genesis of this PR was my miscommunication and miscoordination of the vr.json → vrs.json renaming with vrs-python. Instead of making vr-spec accommodate vrs-python, I'd like to shift the fix back to vrs-python. Specifically:

Keep the intended naming: 1.1 uses vr.json; 1.2 uses vrs.json. Client code has to adapt as part of that support. That means dropping this PR.
Clarify the intended (but botched by me) correspondence between vrs-python and vr-spec: develop ~ develop, 0.6 ~ 1.1, and (soon) 0.7 ~ 1.2. This is already done in https://github.com/ga4gh/vrs-python README.
Ensure that vrs-python develop and 0.6 branches correctly correspond with vr-spec branches and that they work. (Done and pushed)
Release 0.6.3. (Done; see https://pypi.org/project/ga4gh.vrs/0.6.3/)


Create JATS-support schema

Problem / Motivation
We're going to 'support' JATS, but it will only ever be a subset. It's currently unclear what JATS we will support. (It's still possible to write code to add support for other variants.)
Proposed solution
Create a schema (Schematron?) that indicates what parts of a JATS article will supported. To start with this should fail pretty much everything. As we agree to support more things then we'll relax it.

Created https://github.com/libero/jats-support.

And first support added in https://github.com/libero/jats-support/pull/1.

@thewilkybarkid This is a fantastic idea and I really like it!
Look forward to seeing this progress.

Opened https://github.com/libero/jats-support/pull/2, https://github.com/libero/jats-support/pull/3, https://github.com/libero/jats-support/pull/4 and https://github.com/libero/jats-support/pull/5 add in what we currently support, just <subj-group subj-group-type="heading"> to go.


Support "Use custom workspace" option

Freestyle job has an "Advanced Project Options" section including "Use custom workspace". This allows a custom workspace directory path to be used instead of the default unique workspace.
With Multi-Branch Project Plugin job, the default workspace is currently "workspace/ProjectName/branchName" which makes some sense, allowing each branch to be checked out into a separate directory.
However there are many use cases where a custom workspace directory is required, for example:

JENKINS_HOME is on a disk partition that is slow or low on free space, or for whatever reason the developer wants their project workspace in a different disk partition (e.g. a Ram disk or SSD for build-speed, a network share).
Single Version Control Repository contains multiple projects or sub-projects, located in sub-directories (e.g. git@bitbucket.org:myTeam/myProjectRepo.git/myProject1/ ). In this case a git checkout of a branch will include all projects in the repo.  In the default workspace config, if you have N sub-projects, each job will checkout all N sub-projects resulting in N^2 * (number branches) projects checked out. For jenkins job efficiency in this scenario it is best for all jobs for the sub-projects within myProjectRepo.git to share a common workspace, e.g. ws/myProjectRepo/$BRANCH_NAME. This will result in each project only being checked out once per branch.
Inter-project dependencies implemented by relative path references in the filesystem. Commonly in developer IDE multiple inter-dependent projects can reference eachother's content by simple relative path references when they are located within a common workspace directory (e.g. workspace1/project1/include/hello.h can contain a reference #include "../project2/include/world.h" where both project1 and project2 reside within common parent directory workspace1.  This relationship is still maintained by default within Jenkins Freestyle build jobs since the job workspaces will still be siblings (workspace/project1 and workspace/project2). However with Multi-Branch Project Plugin, these workspaces are pushed down a level (workspace/project1/$BRANCH_NAME and workspace/project2/$BRANCH_NAME) so the relative reference to ../project2/include/world.h is now broken in Jenkins.  A quick-fix for this kind of problem could be to change the current default workspace to "workspace/$BRANCH_NAME/projectName", however a custom workspace option would address more scenarios.

Now available with version 0.2

Awesome,  thanks for implementing this!


⚠ Bofrost.de has degraded performance

In cd170ca, Bofrost.de (https://www.bofrost.de) experienced degraded performance:

HTTP code: 200
Response time: 1301 ms

Resolved: Bofrost.de performance has improved in d1df97f after 9 minutes.


Compute a parametrized Transformation Matrix, to create a projection.

Hi can let me do my next job tomorrow


Allow switching of servers on preview.ideditor.com

Currently you can't switch from live to dev, unlike when you run a local dev server

Yeah, this is because we sync to s3 whatever is in the dist/ folder, and that index.html doesn't include the source switcher.  I'm not really sure the reason but I don't see any issue with adding it there.


Inconsistent use of "app" or "application" literal

https://github.com/canonical/ops-scenario/blob/31ab9dd1c6db1ffa1d5c3b0d9a6b6afffb1a20e4/scenario/state.py#L137-L141

fixed in #86


DO Bot: Fix ICD-10-CM vs ICD10 xrefs

See: https://www.wikidata.org/wiki/Wikidata:Property_proposal/ICD-10-CM

Will be fixed by this next time it runs: https://github.com/SuLab/scheduled-bots/commit/62579bbad4f656e61ad2c14a125ed3d244b5a53a
The incorrect ICD10 statements should get removed by the bot as well, once a new DO release is released


blog: meet our contributors APAC India region

This PR adds the first blog post for India region, in the series of "Meet Our Contributors - APAC" blog series.
Reference issue: https://github.com/kubernetes/community/issues/4469#issuecomment-942422348

Hi folks

Hello @sftim, Happy New Year :)
And thanks for pointing. I've raised the asked PR: https://github.com/kubernetes/contributor-site/pull/279

/hold
for kubernetes/contributor-site#279
(and then we should synchronize the copy, publication date, etc)

@sftim, I've synchronized this PR with the reviewed content & publication date (Jan 10, 2022) from the kubernetes/contributor-site#279
Kindly please review. Thank you!

/hold cancel

/lgtm
/approve


[Frontend] Support capturing dynamically-shaped arrays from outer sco…

…pes in Python programs (#830)
Context: Catalyst supports Jax dynamically-shaped arrays. The current version has a notable limitation: body loop programs do not allow mixing captured dynamically-shaped arrays with the argument ones even if they are of the same dimension. This is because we effectively duplicated dimension variables for the loop-body arguments.
As an illustration, the loop body of the below program takes a as an argument array and x as a captured array. The
experimental_preserve_dimensions flag has the default value of True
@qjit(abstracted_axes={1: 'n'})
def g(x, y):

  @catalyst.for_loop(0, 10, 1, experimental_preserve_dimensions=True)
  def loop(_, a):
    return a * x

  return jnp.sum(loop(y))

a = jnp.ones([1,3], dtype=float)
b = jnp.ones([1,3], dtype=float)
g(a, b)

Description of the Change:
This PR sets the following semantic of loops, depending on the value of the already-existing experimental_preserve_dimensions flag:

True (the default): all dynamic dimension variables will be handled as Jaxpr constants. So

Mixing argument and captured arrays is possible.
No dimension modification is allowed inside loops.

False would handle all the dimensions as Jaxpr implicit arguments.

Mixing argument and captured arrays is not possible.
Dimension modification within the loops are allowed.

[sc-60521]
Benefits: Since this fixes a bug in the dynamic shape array in v0.7.0, it has been cherry-picked from 'main'.
Possible Drawbacks:
Related GitHub Issues:

@rmoyard The original author of this PR was Sergei, I've just cherry-picked it from main, where it was already merged :(


Explicit Dataset RDF and training_data in model RDF

as discussed in #391
Additionally this PR brings a readability update for the generated markdown docs. E.g. the new model RDF docs

Also, the tests are still failing.

@oeway didn't you wonder about zenodo's occasional 503? https://github.com/bioimage-io/spec-bioimage-io/runs/5279715600?check_suite_focus=true

@oeway didn't you wonder about zenodo's occasional 503? https://github.com/bioimage-io/spec-bioimage-io/runs/5279715600?check_suite_focus=true

Ok, but I was more wondering about the rate limit error (code 429 Too Many Requests), for 503, it means zenodo is out of service temporary which can happen and nothing we can do about.


Move events from internal to pkg

Summary
The following PR moves events from internal to pkg
Change Type
Mark the type of change your PR introduces:

[ ] Bug fix (resolves an issue without affecting existing features)
[ ] Feature (adds new functionality without breaking changes)
[ ] Breaking change (may impact existing functionalities or require documentation updates)
[ ] Documentation (updates or additions to documentation)
[x] Refactoring or test improvements (no bug fixes or new functionality)

Testing
Outline how the changes were tested, including steps to reproduce and any relevant configurations.
Attach screenshots if helpful.
Review Checklist:

[x] Reviewed my own code for quality and clarity.
[ ] Added comments to complex or tricky code sections.
[ ] Updated any affected documentation.
[ ] Included tests that validate the fix or feature.
[ ] Checked that related changes are merged.

IMO we should move constructors and interfaces to pkg. But not the whole implementation.

Can we defer this until after #4784 ?

Can we defer this until after #4784 ?

Of course 👍 Do you have any idea how much time you'll need?

I'm guessing not more than 2-3 days
On Thu, Oct 24, 2024 at 7:03 AM Radoslav Dimitrov @.***>
wrote:

Can we defer this until after #4784
https://github.com/mindersec/minder/pull/4784 ?
Of course 👍 Do you have any idea how much time you'll need?
—
Reply to this email directly, view it on GitHub
https://github.com/mindersec/minder/pull/4812#issuecomment-2435386748,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AB4XEN7QMAKGFRY3IQVBHADZ5D42XAVCNFSM6AAAAABQQVCIMWVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDIMZVGM4DMNZUHA
.
You are receiving this because your review was requested.Message ID:
@.***>


Support for Bash on the Windows Subsystem for Linux?

Running Hyper with Bash on WSL as the specified shell in .hyper.js, this extension doesn't work properly. It just opens in the user directory as usual.
Would you be able to add support for Bash on WSL?

I did some hacking yesterday to see if the command could be changed to use the windows toolchain instead. I noticed that the pid passed into https://github.com/hharnisc/hypercwd/blob/master/index.js is not the process id of hyper itself, so it can't be used to identify the session, unless there is a way to map that into a process id. I probably need to look into the hyper code to know what id are they passing around.

Hey @JacobDB and @Shadowys I added support for Windows recently, could you try this pluggin again - not sure if it gracefully handles Bash on the Windows Subsystem 😄

@hharnisc just had a chance to test today, doesn't appear to work with bash. I even tried re-installing all modules, no dice.

Thank you for trying this out @JacobDB - I wonder did it complain about lsof not being a command on the console? If it didn't that must mean that the detected environment is win32 :thinking:

I don't see any errors like that, but this morning I am seeing this error when trying to open a new tab; not sure if it's related.

@hharnisc @JacobDB
I also installed hypercwd with hpm inside WSL and it opens the HOME path, not the current working directory.
Opening a new tab is not throwing any JS error here (but still not opening the cwd), but I will report in case it happens to me.

I'm starting to get the same alert while trying to split:

Yea, it seems fairly intermittent. It happens most often when gulp watch is running on one of my projects.

Sharing some context here about how the working directory is detected, on OS X it uses the lsof command and on Windows it uses a regex on the I/O. (since under standard windows shell it outputs that after each command)
Windows Regex: https://github.com/hharnisc/hypercwd/blob/master/index.js#L13
My guess what is happening here is that hypercwd is detecting windows but then doesn't detect the working directory because bash doesn't output that after each command.

Thanks for the feedback @hharnisc. I can't really help here fixing this issue because of my limited background, but I will share some information about how I'm using cwd now hoping this has some value for you to keep working on this.
As my shell is zsh and I'm using oh-my-zsh, I can use a plugin called last-working-directory that stores the last path in cache (I think it writes the path everytime I cd on my term). It also implements the $ lwd command to cd the path stored in that cache file.
So, with that command available, I setup my shell to manually $ lwd every time I start a new session (no matter if I just opened Hyper, a new tab or split). It smells but it works as expected.

Hi everyone,
I just switched to Windows and WSL and I'm facing the same issue.
In hyper I'm running zsh with the following .hyper.js config:
  shell: 'C:\\Windows\\System32\\bash.exe',
  shellArgs: ['-c', 'zsh']

I did some digging into hyper and hypercwd and yes hypercwd is detecting windows because hyper is running on windows. We could use exec() but unfortunately nodejs' child_process is bound to cmd instead of the running shell. I'm able to exec() into bash but of course it spawns a new instance instead of the running one.
If hyper was able to give access to session.pty on SESSION_ADD in addition to session.pty.pid as we can see in window.js it would be possible to find the current session and access the running shell (its pty) to exec() some pwd command to use in the new tab.
I might fork hyper to test this but wouldn't mind some feedback beforehand.
Cheers

Any progress on getting this working?

Hey @JacobDB :wave: I've added a help wanted badge on this one. I don't have enough time to fully implement this, but would accept a patch from the community. Probably better someone else do this since I'm not a daily user of this setup :smile:

@hharnisc this might help? https://github.com/henrikdahl/hyper-statusline/pull/73

@Stanzilla I don't think that will help, I am just ignoring commands in wsl bash

@enwin Have you tried this:

If hyper was able to give access to session.pty on SESSION_ADD in addition to session.pty.pid as we can see in window.js it would be possible to find the current session and access the running shell (its pty) to exec() some pwd command to use in the new tab.

I forked hyper to share session.pty and I now have access to that object but I'm not sure exactly what do with it. How do you exec something like pwd with that pty object? I'm a bit clueless.
However, everything is supposed to be private (judging by the _ prefixes):


Adding a "Switch your console to dev." or add a link to https://github.com/maorninja/Follow-up-Guide/wiki

I do not know if it's useful since anyone can dev for nintendo...

Did you simply read the sidebar? Might seem so. Let me tell you something:
We're simply getting dev apps for use with ShadowNAND. We are not switching our console to dev. Let me show you my prossess
Luma3DS->ShadowNAND->Downgrade->immediate Update->Home menu
For most of the users who will follow my guide, they would think that this is pointless (Downgrade and update). It works here because we're re-activating the ARM9 exploits that have been de-activated. But here, we aren't activating anything. We're downgrading and updating to get dev-apps. The dev apps in this way will install to NAND for sure and not make it either install to SD or Install FBI 1.x or have black apps.
I'm doing part 3 and after that, I'll ask plailect. Can you close this until tomorrow night/tonight?

Ok thank


ci: use build.env:CSI_IMAGE_VERSION for mini-e2e jobs

By placing CSI_IMAGE_VERSION=v3.1.0 in build.env in the release-v3.1
branch, the CI jobs using single-node-k8s.sh can pickup the version
dynamically.
Other release branches can do the same, and the CI jobs will not need
modifications for each release.

/test ci/centos/job-validation

@MergifyIO rebase

/test commitlint


Migrate to Hermes

Migrate to the Hermes JS engine for the entire project.

Hi @Kinostrome,
I'd be quite keen to be able to help with the process of being able to have a stable release of the new updates to Lexicon. What is something that I could do to help you? I'd be open to helping with documentation, testing, bug swatting. Just keen to get the current updated work into a state where it is fit for deployment.
Cheers,
Simon

Hi @Kinostrome,
I'd be quite keen to be able to help with the process of being able to have a stable release of the new updates to Lexicon. What is something that I could do to help you? I'd be open to helping with documentation, testing, bug swatting. Just keen to get the current updated work into a state where it is fit for deployment.
Cheers, Simon

Hey Simon, thanks for your interest in this—we're really glad to have you on here wanting to help out.
At the moment we're undergoing a bit of a transition. Lexicon v2 is under development internally (with features like push notifications and email deep linking), and development on that is being synced to alpha-v2. We are gearing up to a beta launch of v2, after which we'd like to transition the project to fully open-source.
In the meantime, the master branch still contains the v1 legacy code, and these two branches are not compatible—they can't be merged into one another. Given that v2 is a major version break, this probably makes sense.
One way that you could help out quite a bit is by getting the master branch stable again with any issues that you're encountering. It should be somewhat up-to-date, but we'd be happy to review PRs that are fixing the issues you're encountering. The key point is that we can't merge PRs syncing all changes between alpha-v2 and master. These two branches have to diverge from one another since v2 will contain features that v1 did not support.
We also wrote about this on a recent post in our discussions tab, you can read about it here: https://github.com/lexiconhq/lexicon/discussions/37

We are gearing up to a beta launch of v2, after which we'd like to transition the project to fully open-source.

Cheers, thanks for the update. I'll avoid touching things until such a time as the development workflow is fully open source. Once that transition is made, I'd be more than happy to help.


adding functionnality

implant comment + hightlight
more semantic code
beautiful css

Just accepted, but I think there's one bug: Highlighted portions should still be present after changes have been accepted/rejected, right? If that's the case I've got the fix, and can commit right now.


Replace extern atomicfile module with a library

Maybe, for example, with pytest-atomicwrites.

It's worth noting that the module is actually out of date with the latest Python changes (which is something we had to address in #579), and it appears that there haven't been any recent updates (see here).

This does not appear to be practical at the moment since none of the alternatives provide a similar API.
We will simply need to continue fixing bugs in the extern-ed module for now.


🐛  react-native-reanimated build issue

What were you trying to do?
@mrousavy When I install react-native-vision-camera the application builds correctly. But after installing react-native-reanimated it crashes.
Reproduceable Code
No response
What happened instead?
BUILD FAILED in 28s
error Failed to install the app. Make sure you have the Android development environment set up: https://reactnative.dev/docs/environment-setup.
Error: Command failed: ./gradlew app:installDebug -PreactNativeDevServerPort=8081
FAILURE: Build failed with an exception.

Where:
Build file '/Users/Documents/app/node_modules/react-native-vision-camera/android/build.gradle' line: 231

What went wrong:
A problem occurred evaluating project ':react-native-vision-camera'.

Expected directory '/Users/Documents/app/node_modules/react-native/android' to contain exactly one file, however, it contains more than one file.

Try:

Run with --stacktrace option to get the stack trace.
Run with --info or --debug option to get more log output.
Run with --scan to get full insights.

Get more help at https://help.gradle.org

BUILD FAILED in 28s
at makeError (/Users/Documents/app/node_modules/execa/index.js:174:9)
at /Users/Documents/app/node_modules/execa/index.js:278:16
at processTicksAndRejections (node:internal/process/task_queues:96:5)
at async runOnAllDevices (/Users/Documents/app/node_modules/@react-native-community/cli-platform-android/build/commands/runAndroid/runOnAllDevices.js:109:5)
at async Command.handleAction (/Users/Documents/app/node_modules/react-native/node_modules/@react-native-community/cli/build/index.js:192:9)

info Run CLI with --verbose flag for more details.
npm ERR! code ELIFECYCLE
npm ERR! errno 1
npm ERR<EMAIL_ADDRESS>android: react-native run-android
npm ERR! Exit status 1
npm ERR!
npm ERR! Failed at the<EMAIL_ADDRESS>android script.
npm ERR! This is probably not a problem with npm. There is likely additional logging output above.
npm ERR!      /Users/praca/.npm/_logs/2022-07-05T

15_05_44_102Z-debug.log
Relevant log output
No response
Device
Android
VisionCamera Version
2.13.5
Additional information

[ ] I am using Expo
[X] I have read the Troubleshooting Guide
[X] I agree to follow this project's Code of Conduct
[X] I searched for similar issues in this repository and found none.

"react": "18.0.0"
"react-native": "0.69.3"
"react-native-vision-camera": "^2.14.0"
"react-native-reanimated": "^2.9.1" <--------- After I install this package, the Android build fails with the next error:

What went wrong:
A problem occurred evaluating project ':react-native-vision-camera'.

Expected directory '.../node_modules/react-native/android' to contain exactly one file, however, it contains more than one file.

If I uninstall "react-native-reanimated", the build succeeds.
Could anybody take a look at this issue, please? Thanks in advance!

This PR might fix this issue: https://github.com/mrousavy/react-native-vision-camera/pull/1116

I have the same problem.
I already have react-native-vision-camera in the project. Whenever I install react-native-reanimated and rebuild the project again, it crashes.
It also shows a log with this:
> Configure project :react-native-vision-camera
VisionCamera: node_modules/ found at: /Users/danhsucowboy/Documents/DanHsu/BoxInThePARK/CaptureToEarn/capture2earn-dapp-v0/node_modules
VisionCamera: Building with JSC...
Warning: The 'kotlin-android-extensions' Gradle plugin is deprecated. Please use this migration guide (https://goo.gle/kotlin-android-extensions-deprecation) to start working with View Binding (https://developer.android.com/topic/libraries/view-binding) and the 'kotlin-parcelize' plugin.
VisionCamera: Frame Processors are enabled! Building C++ part...
WARNING:DSL element 'dexOptions' is obsolete and should be removed.
It will be removed in version 8.0 of the Android Gradle plugin.
Using it has no effect, and the AndroidGradle plugin optimizes dexing automatically.

Deprecated Gradle features were used in this build, making it incompatible with Gradle 8.0.
...

with
i got the same issue

Hey! I've rewritten the entire Android codebase of VisionCamera from CameraX to Camera2 in the efforts of ✨ VisionCamera V3.
I just now completed the Camera2 rewrite and I believe the core structure is running, but there might be some edge cases to iron out. Can you try and test the PR #1674 for me to see if you can still reproduce this issue here?
Here's an instruction on how you can test that: https://github.com/mrousavy/react-native-vision-camera/pull/1674#issuecomment-1684104217
If the issue cannot be reproduced with that version/PR anymore, then hoorayy, I fixed it! 🎉
Otherwise please let me know and I'll keep this issue open to keep track of it.
Thank you!


BCP037 - warning: property retentionDays is not allowed on objects of type DatabaseVulnerabilityAssessmentProperties.

Bicep version
v0.4.1124
Describe the bug
Warning in VSC:
The property "retentionDays" is not allowed on objects of type "DatabaseVulnerabilityAssessmentProperties". Permissible properties include "storageContainerSasKey". If this is an inaccuracy in the documentation, please report it to the Bicep Team.
To Reproduce
Create the following vulnerabilityAssessment object in bicep. The warning will appear.
resource vulnerabilityAssessment 'Microsoft.Sql/managedInstances/databases/vulnerabilityAssessments@2021-05-01-preview' = if (database.advancedThreatProtection.enabled && (!empty(database.advancedThreatProtection.vulnerabilityAssessmentScans.storageAccount.name))) {
  name: '${sqlManagedInstance.name}/${databaseRes.name}/Default'
  properties: {
    recurringScans: {
      isEnabled: database.advancedThreatProtection.vulnerabilityAssessmentScans.recurringScans
      emailSubscriptionAdmins: database.advancedThreatProtection.vulnerabilityAssessmentScans.emailSubscriptionAdmins
      emails: database.advancedThreatProtection.vulnerabilityAssessmentScans.emails
    }
    storageContainerPath: !empty(database.advancedThreatProtection.vulnerabilityAssessmentScans.storageAccount.name) ? container.name : ''
    storageAccountAccessKey: !empty(database.advancedThreatProtection.vulnerabilityAssessmentScans.storageAccount.name) ? storageAccount.listKeys().keys[0].value : ''
    retentionDays: !empty(database.advancedThreatProtection.vulnerabilityAssessmentScans.storageAccount.name) ? database.advancedThreatProtection.vulnerabilityAssessmentScans.retentionDays : 0
  }
}

Additional context
Add any other context about the problem here.

Can you confirm that when you deploy, you are getting the expected behavior? IOW, is this retentionDays property being accepted and the resource is behaving the way you want once deployed?


Break during output.

I want to use the model to generate long sentence or some code, but the model can't give me full result.

BTW, I'm using h2oai/h2ogpt-oasst1-512-12b model.

You can change max_new_tokens in UI or CLI to larger values.


Colors not working in demos

Describe the bug
The "select colors" examples do not display colors correctly.
Example: "Select Colors and Flavours / md" example -- all selections are grey.
Example: "Select Colors and Flavours / with global" -- all selections are purple.
Link to Reproduction
The demos you list from this repo's README:

https://codesandbox.io/s/chakra-react-select-demo-65ohb?file=/example.js

https://codesandbox.io/s/chakra-react-select-ts-demo-vz9ut?file=/app.tsx

To Reproduce
Steps to reproduce the behavior:

Visit either demo sandbox
Click a few options in each example

Expected behavior
Each selection should use the color of the name selected, as in the README screen shot.
Screenshots

Desktop (please complete the following information):

OS: OSX
Browser: Chrome 98.0.4758.102

My misunderstanding. Some of the examples aren't meant to use actual colors. Confusing since the choices ARE colors, but I stand corrected.

Yeah I can see where the confusion came from, the data I used for these examples came from the original react-select examples and colors was just one of the simpler list of options to use for examples.  But yeah, in order to apply a color to the tags you have to use the colorScheme prop either on the overall Select component, or as a key in your options items.


cleanup: use ProtobufWkt::BoolValue instead of Protobuf::BoolValue

BoolValue is a protobuf "Well known type" so should be referenced via the ProtobufWkt namespace not Protobuf.
Risk Level: Low
Testing: Existing
Docs Changes: N/A
Release Notes: N/A
Platform Specific Features: N/A

/assign @ggreenway


Task "minimize access" no longer works on 5.2.0

Describe the bug
On 5.1.0, I could observe a large set of changes made during the "minimize access" step. Instead, in the latest release, that appears to fail & be skipped due to a problem with the changes presumably made in #208. The root cause appears to be this find error:
find: File system loop detected; ‘/usr/bin/X11’ is part of the same file system loop as ‘/usr/bin’.

Expected behavior
The "minimize access" step should run.
Actual behavior
TASK [dev-sec.os-hardening : find files with write-permissions for group] ****************************************************************************************************************************************
ok: [none.none] => (item=/usr/local/sbin)
ok: [none.none] => (item=/usr/local/bin)
ok: [none.none] => (item=/usr/sbin)
failed: [none.none] (item=/usr/bin) => {"changed": false, "cmd": "find -L /usr/bin -perm /go+w -type f", "delta": "0:00:00.006142", "end": "2019-05-11 00:21:59.580287", "item": "/usr/bin", "msg": "non-zero return code", "rc": 1, "start": "2019-05-11 00:21:59.574145", "stderr": "find: File system loop detected; ‘/usr/bin/X11’ is part of the same file system loop as ‘/usr/bin’.", "stderr_lines": ["find: File system loop detected; ‘/usr/bin/X11’ is part of the same file system loop as ‘/usr/bin’."], "stdout": "", "stdout_lines": []}
ok: [none.none] => (item=/sbin)
ok: [none.none] => (item=/bin)
...ignoring

TASK [dev-sec.os-hardening : minimize access on found files] *****************************************************************************************************************************************************

TASK [dev-sec.os-hardening : change shadow ownership to root and mode to 0600 | os-02] ***************************************************************************************************************************

Example Playbook
    - name: Harden OS
      include_role:
        name: dev-sec.os-hardening

OS / Environment
$ find /etc/*release -type f,l | xargs cat
DISTRIB_ID=LinuxMint
DISTRIB_RELEASE=19.1
DISTRIB_CODENAME=tessa
DISTRIB_DESCRIPTION="Linux Mint 19.1 Tessa"
NAME="Linux Mint"
VERSION="19.1 (Tessa)"
ID=linuxmint
ID_LIKE=ubuntu
PRETTY_NAME="Linux Mint 19.1"
VERSION_ID="19.1"
HOME_URL="https://www.linuxmint.com/"
SUPPORT_URL="https://forums.ubuntu.com/"
BUG_REPORT_URL="http://linuxmint-troubleshooting-guide.readthedocs.io/en/latest/"
PRIVACY_POLICY_URL="https://www.linuxmint.com/"
VERSION_CODENAME=tessa
UBUNTU_CODENAME=bionic
DISTRIB_ID=Ubuntu
DISTRIB_RELEASE=18.04
DISTRIB_CODENAME=bionic
DISTRIB_DESCRIPTION="Ubuntu 18.04 LTS"

Ansible Version
$ ansible --version
ansible 2.7.10
  config file = /home/kofalt/yar/ansible.cfg
  configured module search path = [u'/home/kofalt/.ansible/plugins/modules', u'/usr/share/ansible/plugins/modules']
  ansible python module location = /usr/local/lib/python2.7/dist-packages/ansible
  executable location = /usr/local/bin/ansible
  python version = 2.7.15rc1 (default, Nov 12 2018, 14:31:15) [GCC 7.3.0]

Role Version
# Release 5.2.0
- name: dev-sec.os-hardening
  src: https://github.com/dev-sec/ansible-os-hardening
  version: 1393c190804652de1774d4c07c0f9fdfaef421d8

Hey @kofalt,
thanks for you report. However this is not really a bug, since the "minimize access" task still works.
The find-task throws an error on /usr/bin/X11 because that's what the find-command does, when it finds a filesystem loop. However the other files inside /usr/bin (and all other directories) are still getting found and the permissions minimized in the next task.
This is also the reason why there's ignore_errors: true on the task.
I'm going to add some documentation on the task!

Makes sense. I got so used to the absolutely-enormous block of green OK from this task that I assumed something had to be wrong! Good to know.


Question: Is there a way to setup/define dynamic parameter as in Dapper?

I've got RAW SQL + expando object with parameters list and in the database field that I'm looking for is of type VARCHAR(200) and my string parameter is parsed by repoDB to NVARCHAR(XXX) which causes slow performance when querying data.
I mitigate this issue by using:
            var @params = new
            {
                Id = id
            };

            TypeMapper.Add<string>(DbType.AnsiString);
            var data = await connection.ExecuteQueryMultipleAsync(query, @params);
            TypeMapper.Remove<string>();

but I'd rather to have something like in dapper:
var parameters = new DynamicParameters();
var customerId = "ALFKI";
parameters.Add("@CustomerId", customerId, DbType.String, ParameterDirection.Input, customerId.Length);
var sql = "select * from customers where CustomerId = @CustomerId";
using (var connection = new SqlConnection(connString))
{
    var customer = connection.QuerySingle<Customer>(sql, parameters);
}

reference: https://www.learndapper.com/parameters
Is it doable in the repodb? Can we select datatype for a query parameters?

AFAIK, RepoDB is leveraging the default behavior of ADO.NET when passing the parameters via parameterized SQL. But allow us to double check this.
There is no other way to override the data type you passed into the parameter, unlesd of course you use the type mapper.
Have you also tried using the QueryField and see if that has change the thing? See here

@mikependon
For that approach what is missing for me is that I can't explicitly decide what DBType will that be

Example from https://repodb.net/operation/executequery#queryfieldquerygroup:
  var param = new QueryGroup(new []
    {
        new QueryField("Id", 10045)
    });

I wish to have:
  var param = new QueryGroup(new []
    {
        new QueryField("Id", DBType.AnsiString,10045)
    });

If we would like to have it ADO.NET-like then at least something like this would be great:
 var results = await _connection.ExecuteQueryMultipleAsync(
                query,
                new { Id = new Microsoft.Data.SqlClient.SqlParameter("Id", SqlDbType.VarChar) }
            );

Yes, we got it. But, there is a logic behind where RepoDB auto detects the type of the column from the DB table and associate the proper type to your command parameter, but AFAIK, by executing via raw SQL it is leveraging the default behavior of ADO. So the NVARCHAR(*) is something like ADO.NET default behavior.

Unfortunately using classes and no raw SQL is not an option in the company that I'm working in. I will create enhancement request for QueryField datatype parameter possibility.


Added integration tests for GET /encounters route

Fixes: #217
Added a set of tests for the GET /encounters route as shown below:

Looks good, thanks for adding the tests! Might just have to resolve the conflict 👍

Merge conflicts resolved


cclient: add libcclient.so target

We need a cc_binary target to create a shared library that's linked all dependencies in.
This can then be exported and linked against from other targets.

Skipping CI because this is a pure devops change.


[rapidjson] Modify the version of cmake_minimum_required()

Fixes https://github.com/microsoft/vcpkg/issues/36187

[x] Changes comply with the maintainer guide
[ ] SHA512s are updated for each updated download
[ ] The "supports" clause reflects platforms that may be fixed by this new version
[ ] Any fixed CI baseline entries are removed from that file.
[ ] Any patches that are no longer applied are deleted from the port's directory.
[x] The version database is fixed by rerunning ./vcpkg x-add-version --all and committing the result.
[x] Only one version is added to each modified port's versions file.

FTR: Upstream has fixed the issue but isn't making new releases.
https://github.com/Tencent/rapidjson/issues/1006

How about downloading https://github.com/Tencent/rapidjson/compare/v1.1.0...6089180ecb704cb2b136777798fa1be303618975.diff as a patch and apply it?

I think this diff is too large.

There is no point in a diff for all changes since the last release when we could directly fetch the final commit. But this would imply switching the version scheme.
OTOH fetching the diff could make sense for selected commits or PRs if applicable.


Small fix with plural.

The problem was when is outdated is ran always if the gem belongs to one group or more always show "groups" in plural.
My diagnosis is if the gem belongs to one group it's incorrect to show "groups" in plural.
My fix was if the gem belongs to one group it should show "group" in singular.

done, I pushed the lasts changes, this PR is ready for code review

Thanks @ryanfox1985!
@bundlerbot r+

Actually, can you squash your commits to a single one to keep the commit history a bit cleaner?
@bunderbot r-

@bundlerbot r-

squashed.

@bundlerbot r+


Fix URL for Augmented LibriSpeech (moved)

Just  a minor fix but the old URL is a Page not found. Found it by using site's search - they had slightly changed the URL composition.

Thanks, Neil!


Connection successful but nothing displayed

I deployed the APM on a fresh EC2 instance and everything went through without any issues.
I can access the UI and log in, but after I re-deployed my app with the credentials from the UI, I get
"Kadira: Successfully connected" but nothing else.
The UI is still displaying the credentials and not loading the data from the app.
Any idea?

Look at the console/network logs on your Meteor application to see if you're getting the same issues as #14.

Nothing in the network logs, but changing the nginx config (as explained at the bottom of #14 ) did the trick. Thanks.


好好看看 maser 源码部署指导文档  对应maser code 能不能部署？？？

好好看看 maser 源码部署指导文档 ， 对应maser code 能不能部署？？？

Hi,
As stated in the readme:
Note: The master branch may be in an unstable or even broken state during development. Please use [releases] instead of the master branch in order to get stable binaries.


[Feature Request] Support for non-unified NLP

UnifiedNlp should list and support for pre-UnifiedNlp network location providers, like gms, AMAPNetworkLocation, BaiduNetworkLocation. etc. these NLP is supported and used by original system, although only 1 of them is used. they works without any configuration. UnifiedNlp should be able to use them like UnifiedNlp-providers. supporting to post-kk (4.4 ~ ) is enough

Yes,it's very useful.

It should be possible to build a UnifiedNlp backend around these providers. I don't think that support for proprietary third party software should be backed into UnifiedNlp.


[webview/iframe] Add Windows, Linux, MAC OS support.

Closing this as duplicate of:
https://github.com/flutter/flutter/issues/41725
https://github.com/flutter/flutter/issues/41726
https://github.com/flutter/flutter/issues/37597
Please follow-up in respective issues for further updates.


#850 Support service suppression

I'm proposing this as a fix for #850, but if you have other ideas on how to fix this then I'm happy to modify or fix anything up.

@jrestall,
Thanks for having already signed the Contribution License Agreement. Your agreement was validated by .NET Foundation. We will now review your pull request.
Thanks,
.NET Foundation Pull Request Bot

@Jetski5822 I assume at that point we can just go on vacation and leave them handle the project ;)

It would appear so @sebastienros !!!


All gather dispatch time optimization

Ticket
#11398 #11857
Problem description
All gather has fairly high dispatch time compared to other ops, sitting at ~20 us for Llama decode with tracing.
Result
After optimization, llama decode dispatch latency has reduced to 8.5 us.
What's changed:

merged sender and receiver into the same kernel and uses rt arg to differentiate between modes
all worker cores now launched at the same time with same ct args
optimized set runtime args on host by getting the address of the runtime arg vector for all cores

Hi @SeanNijjar feel free to review this branch now! It has now rebased on top of Ammar's changes on all gather matmul. Sorry for the delay -- was waiting for local tests to pass

all post commit tests: https://github.com/tenstorrent/tt-metal/actions/runs/10693954147
t3k frequent tests: https://github.com/tenstorrent/tt-metal/actions/runs/10693975621
t3k nightly: https://github.com/tenstorrent/tt-metal/actions/runs/10693985724

Found out a bug in sharded all gather matmul. Fixed and pushed again.
Here are the new set of tests:
all post commits: https://github.com/tenstorrent/tt-metal/actions/runs/10703346127
t3k frequent: https://github.com/tenstorrent/tt-metal/actions/runs/10703338829
t3k nightly: https://github.com/tenstorrent/tt-metal/actions/runs/10703323240

rerun tests
all post commits: https://github.com/tenstorrent/tt-metal/actions/runs/10706751847
t3k frequent: https://github.com/tenstorrent/tt-metal/actions/runs/10706755866
t3k nightly: https://github.com/tenstorrent/tt-metal/actions/runs/10706763082


Appstudio update test-component-pac-yhen

Pipelines as Code configuration proposal
To start the PipelineRun, add a new comment with content /ok-to-test
For more detailed information about running a PipelineRun, please refer to Pipelines as Code documentation Running the PipelineRun
To customize the proposed PipelineRuns after merge, please refer to Build Pipeline customization

Pipelines as Code CI/test-component-pac-yhen-on-pull-request has successfully validated your commit.

StatusDurationName

✅ Succeeded
7 seconds
init

✅ Succeeded
19 seconds
clone-repository

✅ Succeeded
45 seconds
build-container

✅ Succeeded
20 seconds
inspect-image

✅ Succeeded
19 seconds
deprecated-base-image-check

✅ Succeeded
47 seconds
clamav-scan

✅ Succeeded
3 minutes
clair-scan

✅ Succeeded
16 seconds
sbom-json-check

✅ Succeeded
50 seconds
label-check

✅ Succeeded
9 seconds
show-sbom

✅ Succeeded
8 seconds
show-summary

Pipelines as Code CI/test-component-pac-yhen-on-pull-request has successfully validated your commit.

StatusDurationName

✅ Succeeded
7 seconds
init

✅ Succeeded
21 seconds
clone-repository

✅ Succeeded
37 seconds
build-container

✅ Succeeded
17 seconds
inspect-image

✅ Succeeded
38 seconds
deprecated-base-image-check

✅ Succeeded
36 seconds
clamav-scan

✅ Succeeded
9 seconds
clair-scan

✅ Succeeded
9 seconds
sbom-json-check

✅ Succeeded
7 seconds
label-check

✅ Succeeded
7 seconds
show-summary

✅ Succeeded
8 seconds
show-sbom


redo index for graphite endpoint

currently the index for the graphite endpoint is just a simple map in defcache.  this was a quick way to make step 1 work, but it is not org aware , as we move to step 2 and 3 we need to fix this.
what will also be needed for step 2 and 3 is support for graphite's glob-like expressions using {foo,bar}, *, etc.
we could solve this in two ways:
A) just query ES. but this is a little slow. and requires metricdefs being pushed to ES with minimal delay
B) use an optimized index in go.  @dgryski explained me about 2 years ago his work using radix trees and trigrams to build optimized indexes to solve graphite's pattern key searches in carbonserver and carbonapi. we can probably reuse this effort but need to be aware of a few things:

we'll need to extend the index for per-org metrics
when we deprecate metrics, we need to remove them out of the indices on all MT instances.
we need to make sure the index in each instance is complete, even if it was down for a while and missed some metrics that were only sent during that interval. perhaps the primary MT can be made responsible for maintaining a log of index changes or entries, for example in kafka (or ES). which can then be replayed/backfilled.
in the future we'll probably want support for tag based search and changing tags over time. we'll also have multiple versions of the same metric, but with a different interval

i was contemplating putting this on indefinite hold or just aborting this little tangential project, at least until there was a more concrete problem to address here (now that we beefed up ES our metricdef lookups are in pretty good standing), OTOH it seemed like a fun weekend project to prototype this and play with the trigram and radix libraries and see how fast it can get and how much resources it needs. so i took this as far as i get in limited time (and got pretty far)
through https://github.com/Dieterbe/trigramplay I found that many wildcards requests can be answered in <1ms and even the more complicated queries with a whole bunch of wildcards are no more than 15ms (using a list of all metrics in prod and my org for retrieval), but i need more realistic real life tests using MT.
i have a prototype branch for MT which when tested with ./inspect-es -format vegeta-mt-graphite | vegeta attack -duration=100s -rate 200 > vegeta.out results in the following profiles
https://gist.github.com/Dieterbe/b8560143b5305dd212ec092f84050aea
it looks like this is a feasable thing that may bring us faster metricdef lookups, fewer resources, and quicker availability of metadata.
code is close to fully functional https://github.com/raintank/raintank-metric/tree/builtin-index,
testing is a bit hard since grafana doesn't set the x-org-id header though.
i'll pick this up again when i have some spare time. feel free to check it out and play with it.

ok, so with 100k/s ingest, 100k active metrics, secondly points, 1hr retention and +- 3kHz request rate (vegeta rate is 500 but due to the wildcards that becomes more) memory usage because of this is 2.5% of total and it seems <1% of cpu.
commands used:
fake_metrics_to_nsq -nsqd-tcp-address nsqd:4150 -statsd-addr statsdaemon:8125 -orgs 1000 -keys-per-org 100 &
inspect-es --es-addr elasticsearch:9200 -format vegeta-mt-graphite -from=30min | sed 's#localhost#metricTank#' | vegeta attack -rate 500 -duration=20m > attack.out
cat attack.out | vegeta report
Requests      [total, rate]            530863, 500.00
Duration      [total, attack, wait]    17m41.724619029s, 17m41.72399976s, 619.269µs
Latencies     [mean, 50, 95, 99, max]  52.425899ms, 2.479753ms, 388.835396ms, 613.874555ms, 1.39388434s
Bytes In      [total, mean]<PHONE_NUMBER>0, 71540.31
Bytes Out     [total, mean]            0, 0.00
Success       [ratio]                  100.00%
Status Codes  [code:count]             200:530863
Error Set:

go tool pprof --inuse_space metric_tank http://localhost:6063/debug/pprof/heap
Fetching profile from http://localhost:6063/debug/pprof/heap
Saved profile in /home/dieter/pprof/pprof.metric_tank.localhost:6063.inuse_objects.inuse_space.009.pb.gz
Entering interactive mode (type "help" for commands)
(pprof) top30
1899.34MB of 1952.59MB total (97.27%)
Dropped 367 nodes (cum <= 9.76MB)
Showing top 30 nodes out of 43 (cum >= 273.24MB)
flat  flat%   sum%        cum   cum%
1383.29MB 70.84% 70.84%  1383.29MB 70.84%  github.com/dgryski/go-tsz.(*bstream).writeBits
131.97MB  6.76% 77.60%   131.97MB  6.76%  github.com/dgryski/go-tsz.New
91.28MB  4.68% 82.28%    91.28MB  4.68%  runtime.malg
81.10MB  4.15% 86.43%   107.18MB  5.49%  main.NewAggMetric
57.72MB  2.96% 89.39%   189.70MB  9.72%  main.NewChunk
52.44MB  2.69% 92.07%  1410.16MB 72.22%  github.com/dgryski/go-tsz.(*Series).Push
21.21MB  1.09% 93.16%    24.14MB  1.24%  github.com/raintank/raintank-metric/schema.MetricDefinitionFromMetricData
21.09MB  1.08% 94.24%    58.61MB  3.00%  main.(*DefCache).Add
20.22MB  1.04% 95.28%    20.22MB  1.04%  fmt.Sprintf
11.74MB   0.6% 95.88%    11.74MB   0.6%  reflect.mapassign
10.06MB  0.52% 96.39%    10.06MB  0.52%  github.com/tinylib/msgp/msgp.ReadStringBytes
8.79MB  0.45% 96.84%    90.66MB  4.64%  main.NewAggregator
3.84MB   0.2% 97.04%   111.01MB  5.69%  main.(*AggMetrics).GetOrCreate
2.34MB  0.12% 97.16%    11.32MB  0.58%  github.com/raintank/raintank-metric/metric_tank/idx.(*Idx).AddRef
1.76MB  0.09% 97.25%    11.82MB  0.61%  github.com/raintank/raintank-metric/schema.(*MetricData).UnmarshalMsg
0.49MB 0.025% 97.27%    12.31MB  0.63%  github.com/raintank/raintank-metric/schema.(*MetricDataArray).UnmarshalMsg

go tool pprof  metric_tank http://localhost:6063/debug/pprof/profile
Fetching profile from http://localhost:6063/debug/pprof/profile
Please wait... (30s)
Saved profile in /home/dieter/pprof/pprof.metric_tank.localhost:6063.samples.cpu.002.pb.gz
Entering interactive mode (type "help" for commands)
(pprof) top30
23210ms of 35540ms total (65.31%)
Dropped 380 nodes (cum <= 177.70ms)
Showing top 30 nodes out of 196 (cum >= 530ms)
flat  flat%   sum%        cum   cum%
4540ms 12.77% 12.77%     4770ms 13.42%  syscall.Syscall
2160ms  6.08% 18.85%     4780ms 13.45%  runtime.scanobject
1390ms  3.91% 22.76%     1390ms  3.91%  runtime.heapBitsForObject
1340ms  3.77% 26.53%     1620ms  4.56%  strconv.formatBits
1300ms  3.66% 30.19%     3940ms 11.09%  main.(*AggMetric).Add
1190ms  3.35% 33.54%     6560ms 18.46%  runtime.mallocgc
1130ms  3.18% 36.72%     1130ms  3.18%  runtime.memmove
930ms  2.62% 39.34%     1250ms  3.52%  runtime.greyobject
820ms  2.31% 41.64%      820ms  2.31%  runtime.memclr
680ms  1.91% 43.56%      960ms  2.70%  runtime.mapaccess2_faststr
620ms  1.74% 45.30%      620ms  1.74%  runtime/internal/atomic.Xchg
570ms  1.60% 46.90%     2650ms  7.46%  main.graphiteJSON
570ms  1.60% 48.51%     1420ms  4.00%  runtime.selectgoImpl
420ms  1.18% 49.69%      830ms  2.34%  main.consolidate
420ms  1.18% 50.87%      830ms  2.34%  runtime.lock
410ms  1.15% 52.03%      410ms  1.15%  github.com/raintank/raintank-metric/metric_tank/batch.Avg
410ms  1.15% 53.18%     1040ms  2.93%  main.fix
410ms  1.15% 54.33%      410ms  1.15%  runtime.memeqbody
390ms  1.10% 55.43%     2100ms  5.91%  github.com/raintank/raintank-metric/schema.(*MetricData).UnmarshalMsg
370ms  1.04% 56.47%      370ms  1.04%  runtime.futex
360ms  1.01% 57.48%      360ms  1.01%  runtime.duffcopy
350ms  0.98% 58.47%      980ms  2.76%  github.com/dgryski/go-tsz.(*Series).Push
350ms  0.98% 59.45%      350ms  0.98%  runtime.usleep
340ms  0.96% 60.41%      340ms  0.96%  sync/atomic.AddUint32
310ms  0.87% 61.28%      310ms  0.87%  github.com/dgryski/go-tsz.(*bstream).writeBits
300ms  0.84% 62.13%      300ms  0.84%  runtime._ExternalCode
290ms  0.82% 62.94%      290ms  0.82%  runtime.epollwait
280ms  0.79% 63.73%      830ms  2.34%  main.(*Aggregator).Add
280ms  0.79% 64.52%      490ms  1.38%  runtime.deferreturn
280ms  0.79% 65.31%      530ms  1.49%  runtime.heapBitsSweepSpan

for the record `web mallogc` showed that only a marginal fraction came from the idx (radix tree), most was gocql.

snapshot https://snapshot.raintank.io/dashboard/snapshot/Bl8g709S3wu1gLfoFQHoMwHZyTy4JBTf

did one last comparison on a regular MT workload.
new branch:
https://snapshot.raintank.io/dashboard/snapshot/D8PUIg33MrLIzj0wgrRzBMzueUtLv60X
https://snapshot.raintank.io/dashboard/snapshot/HiNYiIoFh7N9q4K9tjcM7zFt4WbCZM6a
master:
https://snapshot.raintank.io/dashboard/snapshot/E91AZpsSDZYHbFVSyH9NkC6JOUjmL7Gn
https://snapshot.raintank.io/dashboard/snapshot/Sp52Ik3HakSPxr2H8av0gQaXXkzjDJQA
looks pretty identical.
conclusion: seems like little overhead, and good performance characteristics.
but only a true test on a prod workload will tell.
i'm going to merge this.


Custom controller gains

The gains must be specified in the YAML file configuration, and ideally, dynamically re-configurable. Default values should provide a decent performance.

Hi guys, @carlosjoserg @Tabjones @manuelbonilla
please review the implementation of the OneTaskInverseKinematics controller, now it reads the PID gains from the lwr_controllers.yaml and it has a topic call to update them (see README for command). Tell me if you have comments, if it's fine in the next days I will do it for the other controllers.

So technically you wrote the gains into a yaml and read them instead of hardcoding them into the source.
Nice work, i'll test it on the lwr as soon as i can.

It looks fine to me. However, I see you are using the pid class from ros control that already has an implementation for this, and it uses a dynamic reconfigure to set the gains, and we should make the most of it.
I would suggest to initialize each of the pid's like in line 68 of the position controller, that is, in our case, something like:
// Load PID Controller using gains set on parameter server
std::string pid_("pid_");
for (int i = 0; i < kdl_chain_.getNrOfJoints(); ++i)
{
    if (!PIDs_[i].init(ros::NodeHandle(n, pid_ +
        joint_handles_.getJoint(i).getName() )))
    {
        ROS_ERROR("Error initializing the PIDs");
        return false;
    }
}

That why, the yaml file can be written like:
  OneTaskInverseKinematics:
    type: lwr_controllers/OneTaskInverseKinematics
    root_name: world
    tip_name: lwr_7_link
    pid_lwr_1_joint: {p: 250,  i: 10, d: 30}
    pid_lwr_1_joint: {p: 220,  i: 10, d: 30}
    pid_lwr_2_joint: {p: 150,  i: 6, d: 20}
    pid_lwr_3_joint: {p: 150,  i: 5, d: 12}
    pid_lwr_4_joint: {p: 90,  i: 5, d: 10}
    pid_lwr_5_joint: {p: 40,  i: 5, d: 7}
    pid_lwr_6_joint: {p: 15,  i: 2, d: 5}

Ok Carlos.
And regarding the dynamic reconfigure, I didn't get if the PIDs have a specific topic so that I can publish gains directly on them, or the reconfiguration is handled inside the controller through the set_gains topic routine.

The dynamic reconfigure and set gains is already being handled by the PID class if you use the bool Pid::init(const ros::NodeHandle &node, const bool quiet) function, take a look at the source at line 93.
Btw, check in the code I gave above that the sum of strings and the getName() call are correct.

Okay! I still have to try to adapt that script to our case.
I was getting wrong with the "reconfigure" thing, I thought that you were talking about the online reconfiguration of the gains, not just the initialization.

I think you are still getting it wrong, since it is about that. Doing it this way will provide both load&initialize gains from the yaml file and reconfigure them online using rosrun rqt_reconfigure rqt_reconfigure.
I didn't write it detailed enough when I posted the issue, my apologies, hope it is clear now.

Well, now it is clear, thanks. I was missing the rosrun command.

Update 1: now the controllers that use control_toolbox::PID meet the issue requirements. All the others still need tweaking and possibly the integration of dynamic-reconfigure.

That's good news! Btw, recall that you are allowed to close the issue as well, though I would wait until the others meet the requirements. Check this to do it via commit, and link the commit to the issue.

Yes, it's ok for me too to wait for the others. At least these first controllers are the ones used by Federico.


[Question] Alarm Style Problem

Question
The notification that came for the webhook alarm view is a single line of text as in the attached image. I want to open all the details but I couldn't.

Alarm Template :   ${app} monitoring availability alert, code is ${code}
What should I do? It doesn't give any information, I have to open the panel every time...

hi, are you mean send alarm content like this

Our latest version 1.6.0 sends this content information by default. What version are you using?

I am using the latest version. The design is not readable, I can't understand where it fell. It was very difficult for me.
Uptime-Kuma style is very nice, can't I make it like this?

We will follow up and optimize


Older video from CBS not available...

... even though can be played in browser

[x] I've verified and I assure that I'm running youtube-dl 2016.09.19

Before submitting an issue make sure you have:

[x] At least skimmed through README and most notably FAQ and BUGS sections
[x] Searched the bugtracker for similar issues including closed ones

What is the purpose of your issue?

[x] Bug report (encountered problems with youtube-dl)

If the purpose of this issue is a bug report, site support request or you are not completely sure provide the full verbose output as follows:
[debug] System config: []
[debug] User config: []
[debug] Command-line args: ['-F', '-v', 'http://www.cbs.com/shows/big_bang_theor
y/video/794877409/the-big-bang-theory-sheldon-s-little-idea/']
[debug] Encodings: locale cp1252, fs mbcs, out cp850, pref cp1252
[debug] youtube-dl version 2016.09.19
[debug] Python version 3.4.4 - Windows-7-6.1.7601-SP1
[debug] exe versions: ffmpeg N-78252-gb62825a, ffprobe N-78252-gb62825a, rtmpdum
p 2.4
[debug] Proxy map: {}
[CBS] 794877409: Downloading SMIL data
ERROR: None of the allowed formats for this user agent were available.
Traceback (most recent call last):
  File "C:\Users\dst\AppData\Roaming\Build archive\youtube-dl\rg3\tmpigpzdgyq\bu
ild\youtube_dl\YoutubeDL.py", line 694, in extract_info
  File "C:\Users\dst\AppData\Roaming\Build archive\youtube-dl\rg3\tmpigpzdgyq\bu
ild\youtube_dl\extractor\common.py", line 355, in extract
  File "C:\Users\dst\AppData\Roaming\Build archive\youtube-dl\rg3\tmpigpzdgyq\bu
ild\youtube_dl\extractor\cbs.py", line 76, in _real_extract
  File "C:\Users\dst\AppData\Roaming\Build archive\youtube-dl\rg3\tmpigpzdgyq\bu
ild\youtube_dl\extractor\cbs.py", line 53, in _extract_video_info
  File "C:\Users\dst\AppData\Roaming\Build archive\youtube-dl\rg3\tmpigpzdgyq\bu
ild\youtube_dl\extractor\theplatform.py", line 40, in _extract_theplatform_smil
youtube_dl.utils.ExtractorError: None of the allowed formats for this user agent
 were available.

Description of your issue, suggested solution and other information
Example: http://www.cbs.com/shows/big_bang_theory/video/794877409/the-big-bang-theory-sheldon-s-little-idea/
This video exists on CBS.com and there is at least a RTMP stream (that I haven't been able to get so far yet)
Also case for some other older videos.

Definetly related to https://github.com/rg3/youtube-dl/issues/10723

will be fixed in the next version.

Definetly related to #10723

no, it's not.


unsafe repository

fatal: unsafe repository ('/github/workspace' is owned by someone else)
To add an exception for this directory, call:
git config --global --add safe.directory /github/workspace

I added like below but doesn't work, same error
      - name: Sync up to CodeCommit
        uses: tsgit18/sync-up-to-codecommit-action@v1
        with:
          repository_name: xxxx
          aws_region: us-west-1
      - name: setup git config
        run: git config --global --add safe.directory /github/workspace

Hey, any update on this? I am facing the same issue.

Thanks for the PR!
Sorry for the late reply.
Merged and released.


Status 500 - Internal Server Error

Hello,
Installed your image a few days ago and set it up in a docker image. Been running flawlessly on my 2022 GMC Acadia. I am able to start, lock/unlock doors, show tire pressures, etc..
That is until today. I tried to start my vehicle using my Home Assistant dashboard script (like always) and noticed a few minutes later that it didn't start. I am seeing the following message after running the docker container (I have removed my personal details and VIN #):
info: OnStar Config {"onstarConfig":{"allowCommands":true,"checkRequestStatus":true,"deviceId":"v4 UUID","onStarPin":"XXXX","password":"XXXXX","refreshInterval":1800000,"username":"user email","vin":"VIN NUMBER"}}
info: MQTT Config {"mqttConfig":{"host":"<IP_ADDRESS>","namePrefix":"","password":"mqtt_password","port":1883,"prefix":"homeassistant","tls":false,"username":"mqtt_user"}}
info: Requesting vehicles
info: Vehicle request status {"status":"success"}
info: Connecting to MQTT {"config":{"username":"mqtt_user","will":{"payload":"false","retain":true,"topic":"homeassistant/VIN NUMBER/available"}},"url":"mqtt://<IP_ADDRESS>:1883"}
info: Connected to MQTT
info: Subscribed to command topic {"topic":"homeassistant/VIN NUMBER/command"}
info: Requesting diagnostics
error: Error {"error":{"message":"Request Failed with status 500 - Internal Server Error","request":{"_closed":true,"_contentLength":383,"_defaultKeepAlive":true,"_ended":true,"_events":{},"_eventsCount":7,"_hasBody":true,"_header":"POST /api/v1/oauth/token/upgrade HTTP/1.1\r\nAccept: application/json\r\nContent-Type: text/plain\r\nAccept-Language: en-US\r\nHost: api.gm.com\r\nConnection: keep-alive\r\nAccept-Encoding: br, gzip, deflate\r\nUser-Agent: Mozilla/5.0 (Linux; U; Android 9; en-US; Google Pixel 2 Build/PI)\r\nAuthorization: Bearer
The last line is way longer, that is just a portion of it. I don;t see any other logs to look at. I completely re-created the docker container image and get the same results.
I'm at a loss. Any ideas to try?
Thanks,
Scott

Ditto. Looking like maybe GM is blocking this access method yet again. ☹

Same here.  It started not responding to lock/unlock/start commands a couple weeks ago with me, but was still getting diagnostics.  Now nothing and the same error as you.

Opened https://github.com/samrum/OnStarJS/issues/211 since any fixes/workarounds would need to happen there.

Things seem to be working again as of this morning.

Doesn't seem to be working for me at the moment. I tried doubling the command timeout but still not receiving a diagnostics response.

Now I'm getting "403 - Forbidden" vs. the 500.

Things seem to be working again. 🤷♂

Yeah, now everything is working better than it was before for me. All the other commands are now working as well.

There's an updated terms of service that the app asks you to agree/deny. I'm not sure if that has to do anything with the failures reported. Obviously this project is a big no no: https://omnibus.gm.com/legal/contents/US/eula_default.pdf


[system-probe] limit http header false positive detections

What does this PR do?
Limits the possibility of having false positive http header detection.

Motivation
We recently had internal examples showing that we could end up with wrong detection of http headers in tcp segments. The point of this PR is not to completely solve the issue, but to reduce the possibility of having such false positive.

Possible Drawbacks / Trade-offs

On the go part, we're touching a very hot path, so we must not introduce too much overhead.
Performance numbers for main
vagrant@agent-dev-paul:/git/datadog-agent$ /git/datadog-agent/test/kitchen/site-cookbooks/dd-system-probe-check/files/default/tests/pkg/network/http/testsuite -test.bench=BenchmarkPath -test.run=none
goos: linux
goarch: arm64
pkg: github.com/DataDog/datadog-agent/pkg/network/http
BenchmarkPath-4   	125108641	         9.596 ns/op	       0 B/op	       0 allocs/op
PASS

Performance numbers for this branch
vagrant@agent-dev-paul:/git/datadog-agent$ /git/datadog-agent/test/kitchen/site-cookbooks/dd-system-probe-check/files/default/tests/pkg/network/http/testsuite -test.bench=BenchmarkPath -test.run=none
goos: linux
goarch: arm64
pkg: github.com/DataDog/datadog-agent/pkg/network/http
BenchmarkPath-4   	132811915	         9.086 ns/op	       0 B/op	       0 allocs/op
PASS
vagrant@agent-dev-paul:/git/datadog-agent$ /git/datadog-agent/test/kitchen/site-cookbooks/dd-system-probe-check/files/default/tests/pkg/network/http/testsuite -test.bench=BenchmarkIsValid -test.run=none
goos: linux
goarch: arm64
pkg: github.com/DataDog/datadog-agent/pkg/network/http
BenchmarkIsValid-4   	100000000	        11.73 ns/op	       0 B/op	       0 allocs/op
PASS

Describe how to test/QA your changes

Reviewer's Checklist

[ ] If known, an appropriate milestone has been selected; otherwise the Triage milestone is set.
[ ] Use the major_change label if your change either has a major impact on the code base, is impacting multiple teams or is changing important well-established internals of the Agent. This label will be use during QA to make sure each team pay extra attention to the changed behavior. For any customer facing change use a releasenote.
[ ] A release note has been added or the changelog/no-changelog label has been applied.
[ ] Changed code has automated tests for its functionality.
[ ] Adequate QA/testing plan information is provided if the qa/skip-qa label is not applied.
[ ] At least one team/.. label has been applied, indicating the team(s) that should QA this change.
[ ] If applicable, docs team has been notified or an issue has been opened on the documentation repo.
[ ] If applicable, the need-change/operator and need-change/helm labels have been applied.
[ ] If applicable, the config template has been updated.

LGTM (aside from a nit) Since we have a benchmark for this method, could you please post a before and after (or consolidate both via https://pkg.go.dev/golang.org/x/perf/cmd/benchstat)

@paulsemel argh, sorry. you did post a benchmark already 😅