Disposing the controller with back button in new package

HI,
I am getting the following error, when I hit back button from a page with youtube video.
i am using youtube_player_iframe on the web. (it works perfectly fine on android).
══╡ EXCEPTION CAUGHT BY WIDGETS LIBRARY ═════════════════════════════
The following JSNoSuchMethodError was thrown building
Overlay-[LabeledGlobalKey#9a698](state: OverlayState#fc15f(entries:
[OverlayEntry#d7e14(opaque: true; maintainState: false), OverlayEntry#beb31(opaque: false;
maintainState: true), OverlayEntry#11da2(opaque: true; maintainState: false),
OverlayEntry#6b51a(opaque: false; maintainState: true)])):
NoSuchMethodError: invalid member on null: 'postMessage'
When the exception was thrown, this was the stack:
packages/youtube_player_iframe/src/players/youtube_player_web.dart 170:16  [_callMethod]
packages/youtube_player_iframe/src/controller.dart 97:35                   pause
packages/notesapp/notes/youtube_local_player.dart 64:17                    deactivate
packages/flutter/src/widgets/framework.dart 4731:12                        deactivate
packages/flutter/src/widgets/framework.dart 1945:12                        _deactivateRecursively

Doctor summary (to see all details, run flutter doctor -v):
[✓] Flutter (Channel beta, 1.19.0-4.3.pre, on Linux, locale en_US.UTF-8)
[✓] Android toolchain - develop for Android devices (Android SDK version 30.0.0)
[✓] Chrome - develop for the web
[✓] Android Studio (version 4.0)
[✓] VS Code (version 1.45.0)
[✓] Connected device (3 available)
Thanks.. (good work with new package :))

I was making mistake..
when I used  _controller.close(); in the dispose, the error went away.
Closing it.

oops getting a new error after pressing the back button from a youtube video page and then going to another page with youtube video.

Duplicate of #300

Any update on this, i see #300  is marked duplicate.


New logo

Hi,
I've noticed that version 4.0.0 preview 1 comes with a new logo. Art is always subjective, but I find the new one more elegant and more pleasing to my eyes, though, at the same time, it's less descriptive, as the letter T is gone. Removing the letter is surely a conscious decision and, even if I feel there's something missing as a result, I also wonder if adding the letter back would spoil the design.

Just my two cents.

Thank you for your feedback, and I'll leave this issue open so others can chime in with their thoughts.
I agree the "T" was a major element of the old logo, but as I had been working through different designs and ideas it was too restrictive in a couple of different ways. Text Grab can copy more than just English text, and it is more than a text editor/processor.
The new logo is more conceptually simple and can be used when communicating all aspects of Text Grab.


Fixed minor bug in deleteClass

Just moved  classIndex.pop(index) below deletion of relationships

Fixed in Aaron's PR


Encode days in intervals as 24 hours in Mongo

Leaving tests to CI.
Edit: Oh yeah, no CI on next-major. Doing it locally too.

Dear Travis, why didn't you run?

Oh, this is a PR to next-major. Shows that I look at the build status before even reading the PR header. :)

If no tests come to life with this change, then we should add a test that does.


Use the /leave command

What feature would you like added?
The character name is no longer needed since the crucible league. Just use the /leave command to leave a party. See this video from GGG: https://www.youtube.com/watch?v=Q5IXQgag0LQ
Why do you want this feature added?
Changing characters would no longer require changing the name in the tool.

Ah nice, glad they finally added that. Will switch over to it in the next update.

Fixed in v0.4.1.


Windows support [C#]

It is based on the macOS support: #679
How to run it
Create a react-native-windows app in C# see this doc, use npx react-native-windows-init --overwrite --language cs
Add lottie-react-native to deps: yarn add
Add node_modules/lottie-react-native/src/windows/LottieReactNativeWindows/LottieReactNativeWindows.csproj to the solution.
Add LottieReactNativeWindows project to the references of the main project.
Add the following to the main project's App.xaml.cs to the constructor.
PackageProviders.Add(new LottieReactNativeWindows.ReactPackageProvider());

Now you can use LottieView!
Using CodeGen & Color Filters
Windows version allows using codegen files: https://docs.microsoft.com/en-us/windows/communitytoolkit/animations/lottie-scenarios/getting_started_codegen
That is the only way to make sure that the colors change.
That is the example on how to use that:

<LottieView
          style={{width: 600, height: 600}}
          source="codegen://LottieWindowsDemoApp.AnimatedVisuals.Data"
          loop
          autoPlay
          colorFilters={[
            {keypath: "PlayPauseColor", color: "#ABABAB"},
          ]}
/>

Where LottieWindowsDemoApp.AnimatedVisuals.Data is the identifier of the class generated by the codegen utility and PlayPauseColor is a special name of the layer supported by the codegen utility.
This code of course assumes that the class Data in namespace AnimatedVisuals is added to your project that is named LottieWindowsDemoApp.

@mandrigin I get error when try to build (see screenshot). I create RN project from scratch and do all your installation instruction.

"lottie-react-native-windows": "git+https://github.com/mandrigin/lottie-react-native-1.git#windows-support-csharp",
"react": "16.11.0",
"react-native": "^0.62.0-0",
"react-native-windows": "^0.62.0-0"

Hmm, try manually adding ReactNative and ReactNative.Managed to the references of LottieAnimationView project

Hmm, try manually adding ReactNative and ReactNative.Managed to the references of LottieAnimationView project

I added ReactNative.Managed see screenshot (screen_vs_studio.jpg) and check if I do this right. After this I try to build, but I get new error when try  to build see screenshot (screen_error.jpg).

Ah, sorry, I think it is because you use react-native-windows 0.62 and this code supports 0.63

Ah, sorry, I think it is because you use react-native-windows 0.62 and this code supports 0.63

Can I do fix for 0.62 ? Because I need 0.62 version for mac os, I can't use 0.63

Ah, sorry, I think it is because you use react-native-windows 0.62 and this code supports 0.63

Can we do fix for 0.62 ? Because I need 0.62 version for mac os, I can't use 0.63

That’s a bit weird but there will be version parity soon. Right now we have to have different versions for Mac and windows.
I can try to look into 0.62 later on but I hope it soon will be unnecessary.

Ah, sorry, I think it is because you use react-native-windows 0.62 and this code supports 0.63

Can we do fix for 0.62 ? Because I need 0.62 version for mac os, I can't use 0.63

That’s a bit weird but there will be version parity soon. Right now we have to have different versions for Mac and windows.
I can try to look into 0.62 later on but I hope it soon will be unnecessary.

Got it, thanks.

@mandrigin I create new project with RN 0.63.2, do all your installation instruction, but still can't build. Please, help.

does it happen when you are doing npx react-native run-windows?

if you have a Visual Studio, it might help if you try building from there... or if you can share the project itself on github somewhere... I haven't seen these errors myself, I assume that they are something to do with the build environment.

there is this article about all the necessary dependencies: https://microsoft.github.io/react-native-windows/docs/rnw-dependencies#windows-development-dependencies

does it happen when you are doing npx react-native run-windows?

Yes

@tarasvakulka can you check that your system is setup according to the article Ove shared?

@tarasvakulka can you check that your system is setup according to the article I’ve shared?

I checked, all the necessary dependencies installed. @mandrigin May be problem in Microsoft.ReactNative.Manged.CodeGen, because when I try to add reference on it to my project in VS, I can't do it VS give me error alert?

@tarasvakulka can you check that your system is setup according to the article I’ve shared?

I checked, all the necessary dependencies installed. @mandrigin May be problem in Microsoft.ReactNative.Manged.CodeGen, because when I try to add reference on it to my project in VS, I can't do it VS give me error alert?

You don’t need Managed.CodeGen dependency I think. What if you try building the solution in VS?

btw, you can ping me at t.me/mandrigin for more real-time debugging... I can’t reproduce that error on my machine...

@tarasvakulka can you check that your system is setup according to the article I’ve shared?

I checked, all the necessary dependencies installed. @mandrigin May be problem in Microsoft.ReactNative.Manged.CodeGen, because when I try to add reference on it to my project in VS, I can't do it VS give me error alert?

You don’t need Managed.CodeGen dependency I think. What if you try building the solution in VS?

I will try bit later.

btw, you can ping me at t.me/mandrigin for more real-time debugging... I can’t reproduce that error on my machine...

Thanks a lot, I will create repo with my code, and ping you.

btw, you can ping me at t.me/mandrigin for more real-time debugging... I can’t reproduce that error on my machine...

This is -> https://github.com/tarasvakulka/TestRnWindows my project. You can try to build and reproduce error on your machine.

I will try tomorrow. I’m in CET, it’s bit early here. I would love it to be merged, so I’m ready to fix whatever needed :)

@tarasvakulka can you check that your system is setup according to the article I’ve shared?

I checked, all the necessary dependencies installed. @mandrigin May be problem in Microsoft.ReactNative.Manged.CodeGen, because when I try to add reference on it to my project in VS, I can't do it VS give me error alert?

You don’t need Managed.CodeGen dependency I think. What if you try building the solution in VS?

I'm try to build solution, but get the same error (see screenshot, sorry for not english VS).
Ошибка    файл ресурсов "D:\Projects\SavePirateWindows\node_modules\react-native-windows\Microsoft.ReactNative.Managed.CodeGen\obj\project.assets.json" не содержит целевого объекта для "netcoreapp3.1". Проверьте, что восстановление выполнено и вы включили "netcoreapp3.1" в TargetFrameworks своего проекта.  SavePirateWindows

@tarasvakulka your project works on my machine when I compile in VS

git clone https://github.com/tarasvakulka/TestRnWindows.git

cd TestRnWindows

.\windows\SavePirateWindows.sln <- opens VS

npx react-native start <- in PowerShell

In VS select x64 and press "Debug -> Start Debugging (F5)".

@tarasvakulka your project works on my machine when I compile in VS

git clone https://github.com/tarasvakulka/TestRnWindows.git
cd TestRnWindows
.\windows\SavePirateWindows.sln <- opens VS
npx react-native start <- in PowerShell
In VS select x64 and press "Debug -> Start Debugging (F5)".

It's great, but how I can fix my error "Check that the restore is complete and you have included "netcoreapp3.1" in the TargetFrameworks of your project"? How and where I can add "netcoreapp3.1"?

I'm running
Microsoft Visual Studio Community 2019
Version 16.7.4
VisualStudio.16.Release/16.7.4+30517.126
Microsoft .NET Framework
Version 4.8.04084

Installed Version: Community

Visual C++ 2019   00435-60000-00000-AA547
Microsoft Visual C++ 2019

ASP.NET and Web Tools 2019   16.7.532.28833
ASP.NET and Web Tools 2019

Azure App Service Tools v3.0.0   16.7.532.28833
Azure App Service Tools v3.0.0

C# Tools   3.7.0-6.20459.4+7ee7c540e3bf19765695b1331c946ddf986d1516
C# components used in the IDE. Depending on your project type and settings, a different version of the compiler may be used.

Common Azure Tools   1.10
Provides common services for use by Azure Mobile Services and Microsoft Azure Tools.

Extensibility Message Bus   1.2.6 (master@34d6af2)
Provides common messaging-based MEF services for loosely coupled Visual Studio extension components communication and integration.

IntelliCode Extension   1.0
IntelliCode Visual Studio Extension Detailed Info

Microsoft JVM Debugger   1.0
Provides support for connecting the Visual Studio debugger to JDWP compatible Java Virtual Machines

Microsoft MI-Based Debugger   1.0
Provides support for connecting Visual Studio to MI compatible debuggers

Microsoft Visual C++ Wizards   1.0
Microsoft Visual C++ Wizards

Microsoft Visual Studio VC Package   1.0
Microsoft Visual Studio VC Package

Mono Debugging for Visual Studio   16.7.5 (112c7bc)
Support for debugging Mono processes with Visual Studio.

Node.js Tools   1.5.20701.1 Commit Hash:b0da3724234b78593207434292d9f891440edea1
Adds support for developing and debugging Node.js apps in Visual Studio

NuGet Package Manager   5.7.0
NuGet Package Manager in Visual Studio. For more information about NuGet, visit https://docs.nuget.org/

ProjectServicesPackage Extension   1.0
ProjectServicesPackage Visual Studio Extension Detailed Info

Test Adapter for Boost.Test   1.0
Enables Visual Studio's testing tools with unit tests written for Boost.Test.  The use terms and Third Party Notices are available in the extension installation directory.

Test Adapter for Google Test   1.0
Enables Visual Studio's testing tools with unit tests written for Google Test.  The use terms and Third Party Notices are available in the extension installation directory.

TypeScript Tools   16.0.20702.2001
TypeScript Tools for Microsoft Visual Studio

Visual Basic Tools   3.7.0-6.20459.4+7ee7c540e3bf19765695b1331c946ddf986d1516
Visual Basic components used in the IDE. Depending on your project type and settings, a different version of the compiler may be used.

Visual F# Tools <IP_ADDRESS> for F# 4.7   16.7.0-beta.20361.3+3ef6f0b514198c0bfa6c2c09fefe41a740b024d5
Microsoft Visual F# Tools <IP_ADDRESS> for F# 4.7

Visual Studio Code Debug Adapter Host Package   1.0
Interop layer for hosting Visual Studio Code debug adapters in Visual Studio

Visual Studio Tools for CMake   1.0
Visual Studio Tools for CMake

VisualStudio.DeviceLog   1.0
Information about my package

VisualStudio.Foo   1.0
Information about my package

VisualStudio.Mac   1.0
Mac Extension for Visual Studio

Xamarin   <IP_ADDRESS>2 (d16-7@033b1a7)
Visual Studio extension to enable development for Xamarin.iOS and Xamarin.Android.

Xamarin Designer   <IP_ADDRESS>5 (remotes/origin/d16-7@79c0c522c)
Visual Studio extension to enable Xamarin Designer tools in Visual Studio.

Xamarin Templates   16.7.85 (1bcbbdf)
Templates for building iOS, Android, and Windows apps with Xamarin and Xamarin.Forms.

Xamarin.Android SDK   <IP_ADDRESS> (d16-7/025fde9)
Xamarin.Android Reference Assemblies and MSBuild support.
    Mono: 83105ba
    Java.Interop: xamarin/java.interop/d16-7@1f3388a
    ProGuard: Guardsquare/proguard/proguard6.2.2@ebe9000
    SQLite: xamarin/sqlite/3.32.1@1a3276b
    Xamarin.Android Tools: xamarin/xamarin-android-tools/d16-7@017078f

Xamarin.iOS and Xamarin.Mac SDK   <IP_ADDRESS> (7ec3751a1)
Xamarin.iOS and Xamarin.Mac Reference Assemblies and MSBuild support.

@tarasvakulka which version of VS do you have?

Also I don't know if that is related, but I noticed that you have both package-lock.json from npm and also yarn.lock from yarn. That might lead to unexpected library versioning. Try to only use yarn and see how it goes. Delete your node_modules and try to run yarn install.

@tarasvakulka which version of VS do you have?

Microsoft Visual Studio Community 2019
Версия 16.8.0
VisualStudio.16.Release/16.8.0+30709.132
Microsoft .NET Framework
Версия 4.8.04084
Установленная версия: Community
Visual C++ 2019   00435-60000-00000-AA193
Microsoft Visual C++ 2019
ASP.NET and Web Tools 2019   16.8.550.19892
ASP.NET and Web Tools 2019
ASP.NET Core Razor Language Services   <IP_ADDRESS>2803+84e121f1403378489b842e1797df2f3f5a49ac3c
Provides languages services for ASP.NET Core Razor.
ASP.NET Web Frameworks and Tools 2019   16.8.550.19892
Дополнительные сведения см. на веб-сайте https://www.asp.net/
Azure Functions and Web Jobs Tools   16.8.550.19892
Azure Functions and Web Jobs Tools
Microsoft JVM Debugger   1.0
Provides support for connecting the Visual Studio debugger to JDWP compatible Java Virtual Machines
Microsoft MI-Based Debugger   1.0
Provides support for connecting Visual Studio to MI compatible debuggers
ProjectServicesPackage Extension   1.0
ProjectServicesPackage Visual Studio Extension Detailed Info
SQL Server Data Tools   16.0.62010.06180
Microsoft SQL Server Data Tools
Test Adapter for Boost.Test   1.0
Enables Visual Studio's testing tools with unit tests written for Boost.Test.  The use terms and Third Party Notices are available in the extension installation directory.
Visual Studio Container Tools Extensions   1.0
Просмотр, диагностика контейнеров в Visual Studio и управление ими.
Visual F# Tools   16.8.0-beta.20507.4+da6be68280c89131cdba2045525b80890401defd
Microsoft Visual F# Tools
Адаптер теста для Google Test   1.0
Включает средства тестирования Visual Studio и модульные тесты для Google Test.  Условия использования и уведомления сторонних производителей см. в каталоге установки расширения.
Диспетчер пакетов NuGet   5.8.0
Диспетчер пакетов NuGet в Visual Studio. Дополнительные сведения о NuGet см. на веб-сайте https://docs.nuget.org/
Инструменты C#   3.8.0-5.20519.18+4c195c3ac1974edcefa76774d7a59a2350ec55fa
Компоненты C#, используемые в интегрированной среде разработки. В зависимости от типа и настроек проекта могут использоваться различные версии компилятора.
Инструменты Microsoft Azure   2.9
Microsoft Azure Tools для Microsoft Visual Studio 2019 — версия 2.9.30924.1
Инструменты Visual Basic   3.8.0-5.20519.18+4c195c3ac1974edcefa76774d7a59a2350ec55fa
Компоненты Visual Basic, используемые в интегрированной среде разработки. В зависимости от типа и настроек проекта могут использоваться различные версии компилятора.
Инструменты Visual Studio для CMake   1.0
Инструменты Visual Studio для CMake
Инструменты непрерывной поставки Microsoft для Visual Studio   0.4
Упрощение настройки конвейеров Azure DevOps из интегрированной среды разработки Visual Studio.
Мастера Microsoft Visual C++   1.0
Мастера Microsoft Visual C++
Общие инструменты Windows Azure   1.10
Предоставляет общие службы для использования мобильными службами и инструментами Microsoft Azure.
 Нажав клавишу F5, можно отправить приложение напрямую в контейнер с отладкой, а клавиши CTRL+F5 позволяют изменить и обновить приложение без повторной сборки контейнера.
Средства TypeScript   16.0.21016.2001
Средства TypeScript для Microsoft Visual Studio
Средства Visual Studio для контейнеров   1.0
Средства Visual Studio для контейнеров
Средства Службы приложений Azure, версия 3.0.0   16.8.550.19892
Средства Службы приложений Azure, версия 3.0.0

Also I don't know if that is related, but I noticed that you have both package-lock.json from npm and also yarn.lock from yarn. That might lead to unexpected library versioning. Try to only use yarn and see how it goes. Delete your node_modules and try to run yarn install.

Ok, few minutes.

I found a "bug" in my project setup similar to this one: https://github.com/microsoft/react-native-windows/issues/6239 and just fixed it.

quotes because it is just ms changed the project setup for libraries in one of the updates

I found a "bug" in my project setup similar to this one: microsoft/react-native-windows#6239 and just fixed it.

It can cause my error when I build solution or not?

It fixes another error when it tries to run the built app. In your case, it didn't even reach that.
Did you try to remove node_modules and re-download again with yarn?

It fixes another error when it tries to run the built app. In your case, it didn't even reach that.
Did you try to remove node_modules and re-download again with yarn?

@mandrigin Man, you made my day, I reinstall node_modules, build project and all works fine!

@mandrigin Could you tell me please, can i put my json files for animations in native side for windows? What folder name it's? Also what is folder name for png files (that i use in my lottie animation) in native side for windows?

@tarasvakulka I remember that Lottie for windows doesn't support external PNGs, just the ones that are built-in (when you export from AfterEffect, it can encode those PNGs into base64 inside the JSON file).
Let me come back to you about the exact folder. If I remember correctly, you just need to add JSON files to the project and setup "copy to the output dir" or something like that... I'll check it today. We ourselves in our project use codegen-ed version actively instead of JSON files directly.

Lottie for windows doesn't support external PNGs

Looking forward to your response about json files, I try bit later too.
About external png, I see pull request https://github.com/windows-toolkit/Lottie-Windows/pull/111, could you explain me please, is it bring external png support for windows or not? Because I have a lot of json files that use external png files, and I don't now what right way to choose, because export from AfterEffect with encode all PNGs into base64, might will make my json files very heavy and with bad perfomance, what you think about it?

@tarasvakulka updated. With the latest commit, you can just put your file myAnimation.json to the Assets folder, do the same dance with Content/Copy Always and then just specify <LottieView source="myAnimation.json" /> and it should work.

Thanks)

@mandrigin Could you please explain once more, for my case when I have a lot of json files where each item use 5-7 png files, what the right way re-export from AfterEffect with encode all PNGs into base64 or may be use codgen can solve my problem with external png for my lottie-animations?

@tarasvakulka i think in your case (many animations that reuse the same png files the CodeGen is the best approach. In general, it’s the one recommended on Windows, because you don’t have to parse anything and also you can use dynamic colors there.

@tarasvakulka i think in your case (many animations that reuse the same png files the CodeGen is the best approach. In general, it’s the one recommended on Windows, because you don’t have to parse anything and also you can use dynamic colors there.

Thanks, I understand correctly that when I generate c# class from my json, I can easily add a path to my png files in generated .cs file?

I think CodeGen will generate it automatically, you might have to specify the folder with the png files. But I think it defaults to Assets.

I think CodeGen will generate it automatically, you might have to specify the folder with the png files. But I think it defaults to Assets.

Understood, thanks again)

hey @mandrigin this looks good to me, thanks a lot for the big effort. Could you help me with the documentation though?

@emilioicai sure! I'm sick now, maybe in a week or two I'll have some time to help.

@mandrigin sure! no worries, I know we took a lot of time to review this so take your time to get well!

@emilioicai I'm finally recovered from my covid. How can I help you with the documentation?

@mandrigin great to hear you are recovered! We would need to add some bits of documentation to the README explaining how to setup an run a project with windows support. A brief example should be sufficient for it..


CPU-Usage

Description
High CPU-Usage.
Steps to reproduce
Activate and use the plugin.
Results
Expected
I except, that after create the visualisation, the cpu-usage is reduced
Actual
While play, about 100% (on one core), about 50-60% withouth wavesurfer.
Additional Information
Please include any additional information necessary here. Including the following:
versions
videojs/wavesurfer
6.7.3
browsers
i personal use firefox...
OSes
... with kali and kubuntu

@hersche can you re-recreate this with a pure video.js example? or a pure wavesurfer.js example?

i have made a fork and found, that in the original demo-"hal.wav", setCurrentTime is called 1391 times in about 8 seconds. well, that can be nice for playing or fluid animations, but it's a bit intensive..
i have changed it that, mostly on progress, it only do the update every 50 time (can be decreased).
with this, it does update 62 times only, but has no visual impact (as i see, but it's still several times in a second).
also i have added it to the finish-play; this caused a incorrect result anyway, adding this should be just proper..
it's a bit ugly, but to force a update on events, i set the counter to 50.
https://github.com/hersche/videojs-wavesurfer/commit/cd7e22f7a8408cbd5365561f944be9c382dd59e9
tell me, when i should do a PR.

@hersche this sounds great, can you make a PR?

// emit the timeupdate event so that the tech knows about the time change
this.trigger('timeupdate');

I wasn't even aware this was in there, related to #60. I would like to get rid of that line as well.

i'm not shure, what this line does, because that's my first mod on videojs-libs at all..
but i make the PR quickly :)

@hersche can you comment out this line (disable the custom tech) https://github.com/collab-project/videojs-wavesurfer/blob/master/src/js/videojs.wavesurfer.js#L770 and any other tech-related lines (like https://github.com/collab-project/videojs-wavesurfer/blob/master/src/js/videojs.wavesurfer.js#L75) and see if this improves things? Also comment out the this.trigger('timeupdate'); line.

@hersche yea you should just:
Do once:

checkout code
npm install
npm run build
npm run start

And you can now make changes and it should automatically rebuild.

ok, i did the test with the 44mb wav-file again and it did not raise the cpu.. as i removed my code, this seems to be a working solution..

@hersche that's good news and fucked up at the same time. Looks like this is a duplicate of #60 :-/

well, then i let my workaround stay for the moment and wait until #60 is closed..
thanks for help me testing there, but about the tech-stuff from videojs, i have no clue..

@hersche can you paste a git diff of your workaround here?

Can you try a clean version without any of your changes, just disabling the tech basically, and see if that fixes it? I'd rather not introduce extra code if it's not needed.

i did this already for the test. i removed my counter, run the test (passing), commented out, what you said, failed on the test, tried it with the 44mb file, you said, it's same like #60 and i decide to stay on my counter-solution then.. i have it right now changed this way, i can commit it, you can reopen the PR and accept it withouth the counter.
but you found the solution with commenting out, so why not simply do a commit like this? i did nothing more than the counter, which i should remove completly and the rest is your work.
for youphptube, i let the counter-workaround enabled for now, because it's working.

for youphptube, i let the counter-workaround enabled for now, because it's working.

I'm just trying to figure out if your counter-workaround is necessary in videojs-wavesurfer in order to fix it in your opionion, but it sounds like it is and you're using it for now until a new videojs-wavesurfer is released without the counter-workaround but with a tech fix.

i have it right now changed this way, i can commit it, you can reopen the PR and accept it withouth the counter.

I'll re-open the PR but can't guarantee I'll merge it but it's a good way to show your ideas using code.

mmh, but when i comment out, what you told me (i would do nothing else, it's only your idea then, as my commit, but well..), then a problem (i already checked this) is, that it will fail with the tests (which are needed to merge anyway). so i have to remove some tests, what should be the last solution..
i mean, make that sense? for me, it's just ok to close the issue and the PR, and wait until a real solution is done. sorry for my weirdness, i was not aware of travis and co.
and my counter-solution definently is no final solution. with the failing tests not even a temporary for the official repo i think.. but for my use, it does the trick.

then a problem (i already checked this) is, that it will fail with the tests (which are needed to merge anyway). so i have to remove some tests, what should be the last solution..

You mean the unit tests of videojs-wavesurfer right?

yes

@hersche you can delete, or move, test/tech.spec.js temporarily if you disabled the registration of the tech. That should fix the tests.

ok

@hersche should be fixed in 2.3.1.


cmake macros should have a namespace

The compiler warnings as errors value was being propagated to the calchart project because they used the same macros.
We should make sure the cmake macro names have a namespace.

Fixed in #48


server/datastore/inmem: fix host removal lock

defer was forgotten so there was no critical section.

Thanks Ferhat. I'll merge this, but please keep in mind that the inmem datastore implementation is deprecated and your attention is best focused elsewhere in the codebase.

@zwass Thanks for info. It was a low hanging fruit :wink:


Issue #8852 fixed.

Issue Reference

Issue #8852 fixed.

Previously by shivendra this issue was  not fixed.
Commit Link - https://github.com/bagisto/bagisto/pull/8853/commits
@suraj-webkul
The issue has been fixed please check the screenshot here

Checked and Found that the profile images are appearing in the reviews now. Please check the screenshot here


Add contribution docs

Additions

CONTRIBUTING.md with steps on how to edit CF.

Review

@Scotchester
@jimmynotjim

Notes

I removed the instruction to increment components' manifests whenever you edit their source code. That responsibility is now listed in the "Release management" section.

Looks right to me, now I gotta go fix my PR.

Rebased. Should be good-to-go.

Whew, finally! ("Finally, Travis", not "finally, @contolini".)


Get-CSOnlineTelephoneNumber -ExpandLocation

Hello!
I'm doing some work with number assignment and am attempting to use the Get-CSOnlineTelephoneNumber with the ExpandLocation switch.
The CmdLet by itself runs fine however when I use -ExpandLocation I get a NullReferenceException.
`PS C:\WINDOWS\system32> Get-CsOnlineTelephoneNumber -ExpandLocation
Object reference not set to an instance of an object.
+ CategoryInfo          : NotSpecified: (:) [Get-CsOnlineTelephoneNumber], NullReferenceException
+ FullyQualifiedErrorId : System.NullReferenceException,Microsoft.Rtc.Management.Hosted.Bvd.GetBvdTelephoneNumberCmdlet
+ PSComputerName        : admin2a.online.lync.com`
I did try a fresh install of the connector on another computer but I continue to get the same error. I've definitely used this switch in the past successfully so I'm not sure what might've changed.
 If anyone has any advice I'd really appreciate it.
Thanks for your time!

Hello @ZB-BT How are you?
Tried and received the same error, however, tried specifying a -TelephoneNumber and did not receive an error.
In case you still receive an error I recommend opening a support ticket directly from your tenant.
Thank you

@get-itips  Thank you very much for the contribution and sharing this explanation. @ZB-BT Hope this comment is helpful for you. If you see a documentation update is required, please feel free to open an issue for the same. We proceed here to close it. Thanks for taking out some time to open the issue. Appreciate and encourage you to do the same in future also.


Update<PHONE_NUMBER>0452_bonus_points_migration.php

Grammatical tweaking to invite purchase notice

We added the MinClass suggested here, but did not tweak the grammar. Thank you for the suggestion (and sorry you did not get attrition on the change, the trouble with code dumps!)


Support for APISIX Standalone mode?

Description
As I user I would like to reduce complexity of APISIX and IngressController configuration by running APISIX in ("standalone mode"). In that mode APISIX is running of the YAML based static configuration, monitoring it and auto-reloading it as necessary. Ingress-Controller would, in this case, be simply responsible for updating that config file in ConfigMap as necessary based on CRDs/Ingress items
There was already a request for this here https://github.com/apache/apisix-ingress-controller/issues/610 but it resulted in a much more complicated (if I understand it correctly) setup (described here) where ingress controller tries to  emulate etcd and is intertwined with ingress-controller. This seems to be a bit more complicated and fragile than I would like it to be.
Is there any interest in simplifying it to actually use the "standalone" mode?
Thanks

This is Apisix subproject which in general is about feature which you dont want to have.
You can use standalone Apisix chart:
https://github.com/apache/apisix-helm-chart/tree/master/charts
just dont enable this project via values: ingress-controller.enabled=false
then you will have staticly controller apisix.

As @daroga0002 said, this project doesn't support this feature and will not add it.
You can just deploy APISIX standalone mode

I suspect we are not understanding each other - I want the  ingress-controller functionality, but more like a traditional ingress controller sense - one that uses CRDs and ingress objects to configure APISIX. It does not seem that far off from what this is. Otherwise this project is very much misnamed

You can just deploy APISIX standalone mode

SMH I don't think you understood what I was asking.


Missing merit queries on BETA

BETA returned some errors:

I think these queries (merit_households_space_heating_demand and mv_buildings_space_heating_load_curve) were removed in this commit https://github.com/quintel/etsource/commit/3c52f35e63daf5f8110f18c69b72b62f45044515, which was authored by @michieldenhaan and committed by @antw. Do you guys know what's going on here?

Looking at the commit, I think the old queries have been replaced by a new one: mv_energy_heat_load_curve. If that's the case, then we can just update the affected chart.

Yes that's correct. I wrote a migration for it (https://github.com/quintel/etmodel/blob/master/db/migrate/20191210103848_fix_mv_demand_curve_chart.rb) but it looks like the old queries are still used in some other queries. I'll fix this!


active-event not being triggered when two calls made back to back

The following JS Fiddle showcases the issue (running 1.6.21.min.js):
https://jsfiddle.net/hp307g3w/1/
You'll see that while the second font's fontactive event is fired, the active is not.

This looks like a bug. Is there any particular reason why you would call load like that?

I tried to simplify my application-logic, which itself will make multiple calls to load depending on how a user interacts with the app. Any timeline on a possible fix? Would be happy to test / confirm.

Any estimate on timeline?

@bramstein This appears to be impacting release 44 of Google Charts. I believe it's causing issue #2179 for us, where users are unable  to draw multiple charts that use the WebFontLoader, since each chart makes its own load call.
Do you have any estimates for when this issue might be addressed?

It looks like this was introduced when we made the modules load asynchronously. I think I know how to fix it, I'll try to find some time for it this week.

Great thanks @bramstein
Looking forward to a fix

@bradoyler Awesome! Thanks for the update!

Any movement here?

The problem grabks reported above was not a problem in 1.6.8, but became a problem starting with 1.6.15.  That might provide an additional clue to narrow this down.

+1 here. Experiencing the same behaviour: making multiple calls to load and only first fires active events. All others just freeze

I'm using a bunk work-around for this. Good luck to you all :|

@onassar could you please share your work-around? Because i only managed to get it work by downgrading to 1.6.7

Can't actually remember. Our code is a bit jumbled at the mo. Looking at it, it looks like I'm tracking fonts being loaded through an array. Should have abstracted it out as a patch, but I assumed owner of this repo would fix the issue.

This is still an issue in 1.6.27. We have a workaround that involves listening to fontloading, fontactive, and fontinactive, and tracking font loading by individual variants instead of the active/inactive events.

Seems to still be an issue in 1.6.28. Version 1.6.10 is the latest that works for me.

Any update on this bug? It's quite old I'd have expected it to be fixed??
For anyone who still needs a fix
I've managed to get it working by downgrading to V1.6.7


Fix typo in Wake County NC

There's a typo near the end of the email that says "Mayor Baldwin" but should instead say "Greg Ford and Commissioners." The submitter copied and pasted from a different template so this is important to fix as soon as possible. The fixed template is below:

To<EMAIL_ADDRESS>CC<EMAIL_ADDRESS>Subject: [*** INSERT UNIQUE SUBJECT LINE***]
Message (Don't forget to replace the [x]'s with your information!) 🔗
Dear Wake County Commissioners,
My name is [YOUR NAME] and I am a resident of Wake County. I urge you and the rest of the board to amend or deny the proposed budget for 2021. I would like to redirect money away from Wake Sheriff's Department and into social service programs that will benefit public health and our own communities, especially communities of color. The proposed budget for Fiscal Year 2021 (http://www.wakegov.com/budget/fy21/Documents/Recommended Budget Book.pdf) suggests cutting ambulances but not law enforcement. Fortunately it does not approve the $8 Million the Sheriff requested for even more officers, but that is less than 10% of the proposed total expenditures ($97,103,645) and it does little to invest in the community. Over 6,000 of my neighbors in Wake County are currently experiencing homelessness and in which nearly 100,000 of our neighbors in Wake County are impoverished and at risk of becoming homeless (www.raleighrescue.org) - these are the issues the board needs to address.
In order to really promote community safety, more law enforcement officers and more detention officers is not the answer - it is more jobs, more educational opportunities, more arts programs, more community centers, more mental health resources, as well as more of a say in how our own communities function. This is a long transition process but change starts with reallocating this funding!
I believe we don’t need a militarized police force. Wake County needs to create a space in which more mental health service providers, social workers, victim/survivor advocates, religious leaders, neighbors, and friends - all of the people who really make up our community - can look out for one another. Greg Ford and Commissioners, will you look out for me, and will you look out for us?
Thank you,
[YOUR NAME]
[YOUR ADDRESS]
[YOUR EMAIL]
[YOUR PHONE NUMBER]

on it now


Impl FromString::FromUtf8Error for StdError

See https://github.com/CosmWasm/cosmwasm/blob/v0.11.1/packages/std/src/errors/std_error.rs#L34-L39
This StdError variant should be raised by the string parsing, however there is no autoconversion with ?, rather we must do something like:
let tokens = tokens.map_err(StdError::invalid_utf8)?;
A minor point for sure, but a nice usability enhancement

I guess we close this when we merge the 0.11 branch into master?


Address ipcache startup perfomance regression

The commit messages should be descriptive, here's the summary line for each.

ipcache: add benchmark for Upsert (regression.txt below)
ipcache: make NamedPortMultiMap an interface (interface.txt below)
ipcache: switch named ports to reference counting (fix.txt below)
ipcache: simplify the named ports update code (cleanup.txt below)

The following is a comparison of running the benchmark added in commit 1 over the course of the four commits.
goos: linux
goarch: arm64
pkg: github.com/cilium/cilium/pkg/ipcache
                      │ regression.txt │             interface.txt             │               fix.txt               │             cleanup.txt             │
                      │     sec/op     │     sec/op      vs base               │   sec/op     vs base                │   sec/op     vs base                │
IPCacheUpsert10-10        97.10µ ±  3%     94.58µ ±  3%       ~ (p=0.052 n=10)   48.84µ ± 5%  -49.70% (p=0.000 n=10)   47.59µ ± 5%  -50.98% (p=0.000 n=10)
IPCacheUpsert100-10      2672.3µ ±  5%    2718.4µ ±  8%       ~ (p=0.481 n=10)   508.3µ ± 5%  -80.98% (p=0.000 n=10)   485.0µ ± 2%  -81.85% (p=0.000 n=10)
IPCacheUpsert1000-10     69.543m ± 13%    66.515m ± 17%       ~ (p=0.481 n=10)   5.282m ± 5%  -92.40% (p=0.000 n=10)   5.056m ± 2%  -92.73% (p=0.000 n=10)
IPCacheUpsert10000-10   4166.59m ±  1%   4299.95m ±  2%  +3.20% (p=0.000 n=10)   48.63m ± 5%  -98.83% (p=0.000 n=10)   44.87m ± 5%  -98.92% (p=0.000 n=10)
geomean                   16.56m           16.47m        -0.55%                  1.589m       -90.40%                  1.513m       -90.86%

The last commit, cleanup.txt removes some now redundant work, and hence gets a mild speedup. If preferred, it can be squashed into the third commit, but like this the algorithmic changes are easier to understand.
goos: linux
goarch: arm64
pkg: github.com/cilium/cilium/pkg/ipcache
                      │   fix.txt   │            cleanup.txt             │
                      │   sec/op    │   sec/op     vs base               │
IPCacheUpsert10-10      48.84µ ± 5%   47.59µ ± 5%       ~ (p=0.165 n=10)
IPCacheUpsert100-10     508.3µ ± 5%   485.0µ ± 2%  -4.58% (p=0.005 n=10)
IPCacheUpsert1000-10    5.282m ± 5%   5.056m ± 2%  -4.28% (p=0.011 n=10)
IPCacheUpsert10000-10   48.63m ± 5%   44.87m ± 5%  -7.74% (p=0.009 n=10)
geomean                 1.589m        1.513m       -4.81%

Note that simply reverting 93cd67f2994a618865fbcdb0294bcd9b4d44036a is not actually a fix, as the quadratic behaviour still lurks. This can be observed by forcefully setting ipcache.needNamedPorts = true when benchmarking:
                      │ main-head.txt  │    revert-with-neednamedports.txt     │
                      │     sec/op     │     sec/op      vs base               │
IPCacheUpsert10-10        95.00µ ±  5%     92.12µ ±  3%  -3.04% (p=0.000 n=10)
IPCacheUpsert100-10      2729.7µ ±  4%    2617.5µ ± 12%       ~ (p=0.165 n=10)
IPCacheUpsert1000-10     70.192m ± 11%    68.974m ± 10%       ~ (p=0.579 n=10)
IPCacheUpsert10000-10   4247.52m ±  3%   4233.62m ±  1%       ~ (p=0.853 n=10)
geomean                   16.68m           16.29m        -2.31%

Fixes: #24987
Address cilium-agent startup performance regression.

/test

technically the namedport map is not the only lock being held while it's locked; the ipcache lock is always held before the namedport map lock is taken. Actually, it seems like we should "promote" this relationship to say that the ipcache lock must be taken before the namedport map.

What I was trying to express in the commit message was that we don't acquire a new lock while holding the namedport mutex (M), and hence don't establish any relations of the form M > X, for any X. I think that's correct. But yes, we do hold the ipcache mutex while acquiring the namedport mutex, and establish IPCache > M. This is precisely why it's crucial to not acquire any other mutex while also holding M.
Tests were green before pushing to clarify the commitmsg and fix a cosmetic issue in the benchmark, but more reruns can't hurt.

/test

/mlh new-flake Cilium-PR-K8s-1.25-kernel-5.4

/test-1.25-5.4

/test

but if it's at all possible to split refactoring and key changes into separate commits, that would help subsequent review and debugging if we ever have to go back and git bisect this change.

@joestringer It took a bit of doing, but I've split the changes up into four commits, see the edited PR description or the commit messages. I hope the changes are a bit clearer now, thanks for the suggestion. PTAL.

Previous CI failures triage:

Cilium-PR-K8s-1.25-kernel-5.4 failed with https://github.com/cilium/cilium/issues/24966
Cilium-PR-K8s-1.27-kernel-net-next failed with something I haven't seen before - creating an issue.

Removing the ready-to-merge label till David had time to look at the optional feedback. Feel free to re-add it you don't plan further changes.

/test

/test-runtime

/test-1.24-5.4

/test-1.25-4.19

/test-1.24-5.4

/test-1.26-net-next

CI triage:

k8s-1.26-kernel-net-next (test-1.26-net-next) failed with https://github.com/cilium/cilium/issues/24687 (we don't have the fix commit<PHONE_NUMBER>b76be4cc93f3d7489ec55166a60ebe)

I'll gamble one rerun and otherwise rebase and run it all again

/test-1.26-net-next

/test


[WebPubSub] Remove useless package ref.

Remove Azure.Core reference.

API changes have been detected in Microsoft.Azure.WebJobs.Extensions.WebPubSub. You can review API changes here
API changes
- Azure.Core

AutoMerge appears to be stuck; manually merging.


Create SECURITY.md

Remove "Security updates will be provided once the project reaches a stable release."


V2.1

Some small change.
Started working on the game module.
Fixed some issue.
Added some "fun" command to anilist (anime) module.
before pushing to master need to finish the clippy fix

small list of new command.
random_image: get a random image.
random_image_nsfw: the same but nsfw.
guild_image: recreate the guild profile picture with the user pp.
guild_image_g: but with all member of all server and not only from the server.
steam_game: get the info of a game.
etc.......


Null object ( empty Transform) not supported in GLTF

Hi,
I am not sure why, but it seems that the GLTF format doesn't accept/understand empty GameObjects ( or from other 3d software, any null objects, we tried with c4d as well, and the problem is the same).
Here's a screenshot of the Unity interface, I exported the Test GameObject, with inside an empty transform. The exported glb doesn't have that empty gameobject.
https://i.imgur.com/cFINLD8.png
Is it something that is per design, or not though out during development or is there some way to achieve this and I am missing something?
I think it's a critical feature if you want the GLTF standard to be widely adopted, this is a missing feature that will be problematic and that any other 3d format do support, especially for complex application that needs 3d content to be flexible and that defines more than the visuals itself, think of character rigs, where you want to have placeholders empty gameobject for hats, or guns, or watch on the wrists, anything that needs to let the code/developer find some placements for adding more visuals.
In our case, we are building a complex architecture with several gltb files, think about a meta structure of a building where you can reference each floors that are in turn defining more content like rooms and furnitures. it makes sense to have glbs for each of these models, so that it can be reused in many different places ( not just in the same building, but in different projects)
Thanks,
Jean

Hi,
Jean
As per glTF specs, nodes (an object of which the hierarchy is composed, pretty much like Unity's GameObjects) without meshes are not supported. So the workaround will be to add minimal invisible meshes to your GameObjects.
However, I strongly believe this feature is indeed critical. As far as I understand it is not a technical limitations but deliberate choice.
And there may be another workaround. One may put any data in extension property of any glTF object, but this is not an elegant solution. You will end up having, so to speak, two hierarchies. One for geometry and another for "transforms"
I think we should to reach out to glTF devs with this proposal.

Fixed in latest release


Make _merge into a slice and add the append keyword (for slices)

Currently, for (now obvious to me) security reasons, a module cannot set up mounts configuration on the project level.
I think this would be to the benefit of the user, if modules could administer one project's mount system for say, put a directory at the root of the project which could be treated as part of assets that the module transform.
Or a module dealing with media transformation could setup an /media directory at the root and mount it into assets/media to user resources or content/media/ to use Page Resources etc...
Currently the module documentation would have to direct the user to copy/paste the mount settings and apply it themselves to their project which is not ideal.
# config/_default/module.yaml
imports:
- path: github.com/mememe/that-media-module
  trustMount: true

We could use something like enableMount but I think using trust makes a stronger statement and pass on to the user the importance of this bool.

I am developing a theme and the themes config contains the following:
[[mounts]]
  source = "assets"
  target = "assets"
[[mounts]]
  source = "layouts"
  target = "layouts"
[[mounts]]
  source = "static"
  target = "static"
[[mounts]]
  source = "node_modules/prismjs"
  target = "assets/prismjs"
[[mounts]]
  source = "node_modules/prism-themes/themes"
  target = "assets/prism-themes"
[[mounts]]
  source = "node_modules/typeface-fira-code/files"
  target = "static/fonts"
[[mounts]]
  source = "node_modules/typeface-roboto-slab/files"
  target = "static/fonts"
[[mounts]]
  source = "node_modules/@tabler/icons/icons"
  target = "assets/tabler-icons"
[[mounts]]
  source = "node_modules/simple-icons/icons"
  target = "assets/simple-icons"

As you can see, I mount a couple of npm dependencies.
I created a new example site which uses the theme like so:
[module]
  _merge = "deep"
  [[module.imports]]
    path = "github.com/schnerring/hugo-gruvbox"

This results in the site not being able to resolve resources from node_modules.
I have to copy and paste the module mounts from the theme to the site and then everything works as expected.
What's interesting is that if I use the module from the local file system via replacements, it works:
[module]
  replacements = "github.com/schnerring/hugo-gruvbox -> ../../hugo-gruvbox"

But the site actually goes looking for the files in ../../hugo-gruvbox/node_modules instead of ./node_modules. Is this intended? Because when running hugo config, the map looks the same in both scenarios and doesn't suggest that Hugo goes looking for files in the replacements directory.


ERROR:root:https://duckduckgo.com ConnectTimeout:

请问有什么解决办法吗
ERROR:root:https://duckduckgo.com ConnectTimeout:  Traceback (most recent call last):   File "/opt/conda/envs/mindsearch/lib/python3.10/site-packages/httpx/_transports/default.py", line 69, in map_httpcore_exceptions     yield   File "/opt/conda/envs/mindsearch/lib/python3.10/site-packages/httpx/_transports/default.py", line 373, in handle_async_request     resp = await self._pool.handle_async_request(req)   File "/opt/conda/envs/mindsearch/lib/python3.10/site-packages/httpcore/_async/connection_pool.py", line 216, in handle_async_request     raise exc from None   File "/opt/conda/envs/mindsearch/lib/python3.10/site-packages/httpcore/_async/connection_pool.py", line 196, in handle_async_request     response = await connection.handle_async_request(   File "/opt/conda/envs/mindsearch/lib/python3.10/site-packages/httpcore/_async/connection.py", line 99, in handle_async_request     raise exc   File "/opt/conda/envs/mindsearch/lib/python3.10/site-packages/httpcore/_async/connection.py", line 76, in handle_async_request     stream = await self._connect(request)   File "/opt/conda/envs/mindsearch/lib/python3.10/site-packages/httpcore/_async/connection.py", line 122, in _connect     stream = await self._network_backend.connect_tcp(**kwargs)   File "/opt/conda/envs/mindsearch/lib/python3.10/site-packages/httpcore/_backends/auto.py", line 30, in connect_tcp     return await self._backend.connect_tcp(   File "/opt/conda/envs/mindsearch/lib/python3.10/site-packages/httpcore/_backends/anyio.py", line 114, in connect_tcp     with map_exceptions(exc_map):   File "/opt/conda/envs/mindsearch/lib/python3.10/contextlib.py", line 153, in __exit__     self.gen.throw(typ, value, traceback)   File "/opt/conda/envs/mindsearch/lib/python3.10/site-packages/httpcore/_exceptions.py", line 14, in map_exceptions     raise to_exc(exc) from exc httpcore.ConnectTimeout

挂一个网络代理吧，你的网络ping不通搜索


Does this support all models of seek camera?

I am curious if this code support models like "Seek ShotPro", "Seek Thermal CompactPro"? Please provide a list of support models if it is possible. Thanks!

Hi. The Python wrapper sits on top of the Seek SDK. The SDK does not support any of the Seek Shot cameras. It does support the Compact series though (except potentially the Compact XR and some really older cameras).

Unfortunately, the Seek Shot does not have any APIs or SDKs


Unable to install OpenPCDet

Ubuntu 20.04
CUDA 11.3
I installed the spconv successfully and everything works fine until python3 setup.py develop.
Here is the output after I entered python3 setup.py develop in the terminal:
/usr/local/lib/python3.8/dist-packages/torch/cuda/init.py:52: UserWarning: CUDA initialization: Unexpected error from cudaGetDeviceCount(). Did you run some cuda functions before calling NumCudaDevices() that might have already set an error? Error 804: forward compatibility was attempted on non supported HW (Triggered internally at  /pytorch/c10/cuda/CUDAFunctions.cpp:109.)
return torch._C._cuda_getDeviceCount() > 0
No CUDA runtime is found, using CUDA_HOME='/usr'
running develop
running egg_info
creating pcdet.egg-info
writing pcdet.egg-info/PKG-INFO
writing dependency_links to pcdet.egg-info/dependency_links.txt
writing requirements to pcdet.egg-info/requires.txt
writing top-level names to pcdet.egg-info/top_level.txt
writing manifest file 'pcdet.egg-info/SOURCES.txt'
/usr/local/lib/python3.8/dist-packages/torch/utils/cpp_extension.py:369: UserWarning: Attempted to use ninja as the BuildExtension backend but we could not find ninja.. Falling back to using the slow distutils backend.
warnings.warn(msg.format('we could not find ninja.'))
reading manifest file 'pcdet.egg-info/SOURCES.txt'
writing manifest file 'pcdet.egg-info/SOURCES.txt'
running build_ext
building 'pcdet.ops.iou3d_nms.iou3d_nms_cuda' extension
creating build
creating build/temp.linux-x86_64-3.8
creating build/temp.linux-x86_64-3.8/pcdet
creating build/temp.linux-x86_64-3.8/pcdet/ops
creating build/temp.linux-x86_64-3.8/pcdet/ops/iou3d_nms
creating build/temp.linux-x86_64-3.8/pcdet/ops/iou3d_nms/src
x86_64-linux-gnu-gcc -pthread -Wno-unused-result -Wsign-compare -DNDEBUG -g -fwrapv -O2 -Wall -g -fstack-protector-strong -Wformat -Werror=format-security -g -fwrapv -O2 -g -fstack-protector-strong -Wformat -Werror=format-security -Wdate-time -D_FORTIFY_SOURCE=2 -fPIC -I/usr/local/lib/python3.8/dist-packages/torch/include -I/usr/local/lib/python3.8/dist-packages/torch/include/torch/csrc/api/include -I/usr/local/lib/python3.8/dist-packages/torch/include/TH -I/usr/local/lib/python3.8/dist-packages/torch/include/THC -I/usr/include/python3.8 -c pcdet/ops/iou3d_nms/src/iou3d_cpu.cpp -o build/temp.linux-x86_64-3.8/pcdet/ops/iou3d_nms/src/iou3d_cpu.o -DTORCH_API_INCLUDE_EXTENSION_H -DPYBIND11_COMPILER_TYPE="_gcc" -DPYBIND11_STDLIB="_libstdcpp" -DPYBIND11_BUILD_ABI="_cxxabi1011" -DTORCH_EXTENSION_NAME=iou3d_nms_cuda -D_GLIBCXX_USE_CXX11_ABI=0 -std=c++14
In file included from /usr/local/lib/python3.8/dist-packages/torch/include/ATen/Parallel.h:140,
from /usr/local/lib/python3.8/dist-packages/torch/include/torch/csrc/api/include/torch/utils.h:3,
from /usr/local/lib/python3.8/dist-packages/torch/include/torch/csrc/api/include/torch/nn/cloneable.h:5,
from /usr/local/lib/python3.8/dist-packages/torch/include/torch/csrc/api/include/torch/nn.h:3,
from /usr/local/lib/python3.8/dist-packages/torch/include/torch/csrc/api/include/torch/all.h:13,
from /usr/local/lib/python3.8/dist-packages/torch/include/torch/extension.h:4,
from pcdet/ops/iou3d_nms/src/iou3d_cpu.cpp:10:
/usr/local/lib/python3.8/dist-packages/torch/include/ATen/ParallelOpenMP.h:83: warning: ignoring #pragma omp parallel [-Wunknown-pragmas]
83 | #pragma omp parallel for if ((end - begin) >= grain_size)
|
pcdet/ops/iou3d_nms/src/iou3d_cpu.cpp: In function ‘int boxes_iou_bev_cpu(at::Tensor, at::Tensor, at::Tensor)’:
pcdet/ops/iou3d_nms/src/iou3d_cpu.cpp:242:55: warning: ‘T* at::Tensor::data() const [with T = float]’ is deprecated: Tensor.data() is deprecated. Please use Tensor.data_ptr() instead. [-Wdeprecated-declarations]
242 |     const float boxes_a = boxes_a_tensor.data();
|                                                       ^
In file included from /usr/local/lib/python3.8/dist-packages/torch/include/ATen/Tensor.h:3,
from /usr/local/lib/python3.8/dist-packages/torch/include/ATen/Context.h:4,
from /usr/local/lib/python3.8/dist-packages/torch/include/ATen/ATen.h:9,
from /usr/local/lib/python3.8/dist-packages/torch/include/torch/csrc/api/include/torch/types.h:3,
from /usr/local/lib/python3.8/dist-packages/torch/include/torch/csrc/api/include/torch/serialize/input-archive.h:6,
from /usr/local/lib/python3.8/dist-packages/torch/include/torch/csrc/api/include/torch/serialize/archive.h:3,
from /usr/local/lib/python3.8/dist-packages/torch/include/torch/csrc/api/include/torch/serialize/tensor.h:3,
from pcdet/ops/iou3d_nms/src/iou3d_cpu.cpp:9:
/usr/local/lib/python3.8/dist-packages/torch/include/ATen/core/TensorBody.h:398:7: note: declared here
398 |   T * data() const {
|       ^~~~
pcdet/ops/iou3d_nms/src/iou3d_cpu.cpp:243:55: warning: ‘T at::Tensor::data() const [with T = float]’ is deprecated: Tensor.data() is deprecated. Please use Tensor.data_ptr() instead. [-Wdeprecated-declarations]
243 |     const float boxes_b = boxes_b_tensor.data();
|                                                       ^
In file included from /usr/local/lib/python3.8/dist-packages/torch/include/ATen/Tensor.h:3,
from /usr/local/lib/python3.8/dist-packages/torch/include/ATen/Context.h:4,
from /usr/local/lib/python3.8/dist-packages/torch/include/ATen/ATen.h:9,
from /usr/local/lib/python3.8/dist-packages/torch/include/torch/csrc/api/include/torch/types.h:3,
from /usr/local/lib/python3.8/dist-packages/torch/include/torch/csrc/api/include/torch/serialize/input-archive.h:6,
from /usr/local/lib/python3.8/dist-packages/torch/include/torch/csrc/api/include/torch/serialize/archive.h:3,
from /usr/local/lib/python3.8/dist-packages/torch/include/torch/csrc/api/include/torch/serialize/tensor.h:3,
from pcdet/ops/iou3d_nms/src/iou3d_cpu.cpp:9:
/usr/local/lib/python3.8/dist-packages/torch/include/ATen/core/TensorBody.h:398:7: note: declared here
398 |   T * data() const {
|       ^~~~
pcdet/ops/iou3d_nms/src/iou3d_cpu.cpp:244:49: warning: ‘T at::Tensor::data() const [with T = float]’ is deprecated: Tensor.data() is deprecated. Please use Tensor.data_ptr() instead. [-Wdeprecated-declarations]
244 |     float ans_iou = ans_iou_tensor.data();
|                                                 ^
In file included from /usr/local/lib/python3.8/dist-packages/torch/include/ATen/Tensor.h:3,
from /usr/local/lib/python3.8/dist-packages/torch/include/ATen/Context.h:4,
from /usr/local/lib/python3.8/dist-packages/torch/include/ATen/ATen.h:9,
from /usr/local/lib/python3.8/dist-packages/torch/include/torch/csrc/api/include/torch/types.h:3,
from /usr/local/lib/python3.8/dist-packages/torch/include/torch/csrc/api/include/torch/serialize/input-archive.h:6,
from /usr/local/lib/python3.8/dist-packages/torch/include/torch/csrc/api/include/torch/serialize/archive.h:3,
from /usr/local/lib/python3.8/dist-packages/torch/include/torch/csrc/api/include/torch/serialize/tensor.h:3,
from pcdet/ops/iou3d_nms/src/iou3d_cpu.cpp:9:
/usr/local/lib/python3.8/dist-packages/torch/include/ATen/core/TensorBody.h:398:7: note: declared here
398 |   T * data() const {
|       ^~~~
x86_64-linux-gnu-gcc -pthread -Wno-unused-result -Wsign-compare -DNDEBUG -g -fwrapv -O2 -Wall -g -fstack-protector-strong -Wformat -Werror=format-security -g -fwrapv -O2 -g -fstack-protector-strong -Wformat -Werror=format-security -Wdate-time -D_FORTIFY_SOURCE=2 -fPIC -I/usr/local/lib/python3.8/dist-packages/torch/include -I/usr/local/lib/python3.8/dist-packages/torch/include/torch/csrc/api/include -I/usr/local/lib/python3.8/dist-packages/torch/include/TH -I/usr/local/lib/python3.8/dist-packages/torch/include/THC -I/usr/include/python3.8 -c pcdet/ops/iou3d_nms/src/iou3d_nms_api.cpp -o build/temp.linux-x86_64-3.8/pcdet/ops/iou3d_nms/src/iou3d_nms_api.o -DTORCH_API_INCLUDE_EXTENSION_H -DPYBIND11_COMPILER_TYPE="_gcc" -DPYBIND11_STDLIB="_libstdcpp" -DPYBIND11_BUILD_ABI="_cxxabi1011" -DTORCH_EXTENSION_NAME=iou3d_nms_cuda -D_GLIBCXX_USE_CXX11_ABI=0 -std=c++14
In file included from /usr/local/lib/python3.8/dist-packages/torch/include/ATen/Parallel.h:140,
from /usr/local/lib/python3.8/dist-packages/torch/include/torch/csrc/api/include/torch/utils.h:3,
from /usr/local/lib/python3.8/dist-packages/torch/include/torch/csrc/api/include/torch/nn/cloneable.h:5,
from /usr/local/lib/python3.8/dist-packages/torch/include/torch/csrc/api/include/torch/nn.h:3,
from /usr/local/lib/python3.8/dist-packages/torch/include/torch/csrc/api/include/torch/all.h:13,
from /usr/local/lib/python3.8/dist-packages/torch/include/torch/extension.h:4,
from pcdet/ops/iou3d_nms/src/iou3d_nms_api.cpp:2:
/usr/local/lib/python3.8/dist-packages/torch/include/ATen/ParallelOpenMP.h:83: warning: ignoring #pragma omp parallel [-Wunknown-pragmas]
83 | #pragma omp parallel for if ((end - begin) >= grain_size)
|
x86_64-linux-gnu-gcc -pthread -Wno-unused-result -Wsign-compare -DNDEBUG -g -fwrapv -O2 -Wall -g -fstack-protector-strong -Wformat -Werror=format-security -g -fwrapv -O2 -g -fstack-protector-strong -Wformat -Werror=format-security -Wdate-time -D_FORTIFY_SOURCE=2 -fPIC -I/usr/local/lib/python3.8/dist-packages/torch/include -I/usr/local/lib/python3.8/dist-packages/torch/include/torch/csrc/api/include -I/usr/local/lib/python3.8/dist-packages/torch/include/TH -I/usr/local/lib/python3.8/dist-packages/torch/include/THC -I/usr/include/python3.8 -c pcdet/ops/iou3d_nms/src/iou3d_nms.cpp -o build/temp.linux-x86_64-3.8/pcdet/ops/iou3d_nms/src/iou3d_nms.o -DTORCH_API_INCLUDE_EXTENSION_H -DPYBIND11_COMPILER_TYPE="_gcc" -DPYBIND11_STDLIB="_libstdcpp" -DPYBIND11_BUILD_ABI="_cxxabi1011" -DTORCH_EXTENSION_NAME=iou3d_nms_cuda -D_GLIBCXX_USE_CXX11_ABI=0 -std=c++14
In file included from /usr/local/lib/python3.8/dist-packages/torch/include/ATen/Parallel.h:140,
from /usr/local/lib/python3.8/dist-packages/torch/include/torch/csrc/api/include/torch/utils.h:3,
from /usr/local/lib/python3.8/dist-packages/torch/include/torch/csrc/api/include/torch/nn/cloneable.h:5,
from /usr/local/lib/python3.8/dist-packages/torch/include/torch/csrc/api/include/torch/nn.h:3,
from /usr/local/lib/python3.8/dist-packages/torch/include/torch/csrc/api/include/torch/all.h:13,
from /usr/local/lib/python3.8/dist-packages/torch/include/torch/extension.h:4,
from pcdet/ops/iou3d_nms/src/iou3d_nms.cpp:8:
/usr/local/lib/python3.8/dist-packages/torch/include/ATen/ParallelOpenMP.h:83: warning: ignoring #pragma omp parallel [-Wunknown-pragmas]
83 | #pragma omp parallel for if ((end - begin) >= grain_size)
|
pcdet/ops/iou3d_nms/src/iou3d_nms.cpp: In function ‘int boxes_overlap_bev_gpu(at::Tensor, at::Tensor, at::Tensor)’:
pcdet/ops/iou3d_nms/src/iou3d_nms.cpp:15:15: warning: ‘at::DeprecatedTypeProperties& at::Tensor::type() const’ is deprecated: Tensor.type() is deprecated. Instead use Tensor.options(), which in many cases (e.g. in a constructor) is a drop-in replacement. If you were using data from type(), that is now available from Tensor itself, so instead of tensor.type().scalar_type(), use tensor.scalar_type() instead and instead of tensor.type().backend() use tensor.device(). [-Wdeprecated-declarations]
15 |   if (!x.type().is_cuda()) {
|               ^
pcdet/ops/iou3d_nms/src/iou3d_nms.cpp:26:24: note: in expansion of macro ‘CHECK_CUDA’
26 | #define CHECK_INPUT(x) CHECK_CUDA(x);CHECK_CONTIGUOUS(x)
|                        ^~~~~~~~~~
pcdet/ops/iou3d_nms/src/iou3d_nms.cpp:54:5: note: in expansion of macro ‘CHECK_INPUT’
54 |     CHECK_INPUT(boxes_a);
|     ^~~~~~~~~~~
In file included from /usr/local/lib/python3.8/dist-packages/torch/include/ATen/Tensor.h:3,
from /usr/local/lib/python3.8/dist-packages/torch/include/ATen/Context.h:4,
from /usr/local/lib/python3.8/dist-packages/torch/include/ATen/ATen.h:9,
from /usr/local/lib/python3.8/dist-packages/torch/include/torch/csrc/api/include/torch/types.h:3,
from /usr/local/lib/python3.8/dist-packages/torch/include/torch/csrc/api/include/torch/serialize/input-archive.h:6,
from /usr/local/lib/python3.8/dist-packages/torch/include/torch/csrc/api/include/torch/serialize/archive.h:3,
from /usr/local/lib/python3.8/dist-packages/torch/include/torch/csrc/api/include/torch/serialize/tensor.h:3,
from pcdet/ops/iou3d_nms/src/iou3d_nms.cpp:7:
/usr/local/lib/python3.8/dist-packages/torch/include/ATen/core/TensorBody.h:303:30: note: declared here
303 |   DeprecatedTypeProperties & type() const {
|                              ^~~~
pcdet/ops/iou3d_nms/src/iou3d_nms.cpp:15:15: warning: ‘at::DeprecatedTypeProperties& at::Tensor::type() const’ is deprecated: Tensor.type() is deprecated. Instead use Tensor.options(), which in many cases (e.g. in a constructor) is a drop-in replacement. If you were using data from type(), that is now available from Tensor itself, so instead of tensor.type().scalar_type(), use tensor.scalar_type() instead and instead of tensor.type().backend() use tensor.device(). [-Wdeprecated-declarations]
15 |   if (!x.type().is_cuda()) {
|               ^
pcdet/ops/iou3d_nms/src/iou3d_nms.cpp:26:24: note: in expansion of macro ‘CHECK_CUDA’
26 | #define CHECK_INPUT(x) CHECK_CUDA(x);CHECK_CONTIGUOUS(x)
|                        ^~~~~~~~~~
pcdet/ops/iou3d_nms/src/iou3d_nms.cpp:55:5: note: in expansion of macro ‘CHECK_INPUT’
55 |     CHECK_INPUT(boxes_b);
|     ^~~~~~~~~~~
In file included from /usr/local/lib/python3.8/dist-packages/torch/include/ATen/Tensor.h:3,
from /usr/local/lib/python3.8/dist-packages/torch/include/ATen/Context.h:4,
from /usr/local/lib/python3.8/dist-packages/torch/include/ATen/ATen.h:9,
from /usr/local/lib/python3.8/dist-packages/torch/include/torch/csrc/api/include/torch/types.h:3,
from /usr/local/lib/python3.8/dist-packages/torch/include/torch/csrc/api/include/torch/serialize/input-archive.h:6,
from /usr/local/lib/python3.8/dist-packages/torch/include/torch/csrc/api/include/torch/serialize/archive.h:3,
from /usr/local/lib/python3.8/dist-packages/torch/include/torch/csrc/api/include/torch/serialize/tensor.h:3,
from pcdet/ops/iou3d_nms/src/iou3d_nms.cpp:7:
/usr/local/lib/python3.8/dist-packages/torch/include/ATen/core/TensorBody.h:303:30: note: declared here
303 |   DeprecatedTypeProperties & type() const {
|                              ^~~~
pcdet/ops/iou3d_nms/src/iou3d_nms.cpp:15:15: warning: ‘at::DeprecatedTypeProperties& at::Tensor::type() const’ is deprecated: Tensor.type() is deprecated. Instead use Tensor.options(), which in many cases (e.g. in a constructor) is a drop-in replacement. If you were using data from type(), that is now available from Tensor itself, so instead of tensor.type().scalar_type(), use tensor.scalar_type() instead and instead of tensor.type().backend() use tensor.device(). [-Wdeprecated-declarations]
15 |   if (!x.type().is_cuda()) {
|               ^
pcdet/ops/iou3d_nms/src/iou3d_nms.cpp:26:24: note: in expansion of macro ‘CHECK_CUDA’
26 | #define CHECK_INPUT(x) CHECK_CUDA(x);CHECK_CONTIGUOUS(x)
|                        ^~~~~~~~~~
pcdet/ops/iou3d_nms/src/iou3d_nms.cpp:56:5: note: in expansion of macro ‘CHECK_INPUT’
56 |     CHECK_INPUT(ans_overlap);
|     ^~~~~~~~~~~
In file included from /usr/local/lib/python3.8/dist-packages/torch/include/ATen/Tensor.h:3,
from /usr/local/lib/python3.8/dist-packages/torch/include/ATen/Context.h:4,
from /usr/local/lib/python3.8/dist-packages/torch/include/ATen/ATen.h:9,
from /usr/local/lib/python3.8/dist-packages/torch/include/torch/csrc/api/include/torch/types.h:3,
from /usr/local/lib/python3.8/dist-packages/torch/include/torch/csrc/api/include/torch/serialize/input-archive.h:6,
from /usr/local/lib/python3.8/dist-packages/torch/include/torch/csrc/api/include/torch/serialize/archive.h:3,
from /usr/local/lib/python3.8/dist-packages/torch/include/torch/csrc/api/include/torch/serialize/tensor.h:3,
from pcdet/ops/iou3d_nms/src/iou3d_nms.cpp:7:
/usr/local/lib/python3.8/dist-packages/torch/include/ATen/core/TensorBody.h:303:30: note: declared here
303 |   DeprecatedTypeProperties & type() const {
|                              ^~~~
pcdet/ops/iou3d_nms/src/iou3d_nms.cpp:61:54: warning: ‘T at::Tensor::data() const [with T = float]’ is deprecated: Tensor.data() is deprecated. Please use Tensor.data_ptr() instead. [-Wdeprecated-declarations]
61 |     const float * boxes_a_data = boxes_a.data();
|                                                      ^
In file included from /usr/local/lib/python3.8/dist-packages/torch/include/ATen/Tensor.h:3,
from /usr/local/lib/python3.8/dist-packages/torch/include/ATen/Context.h:4,
from /usr/local/lib/python3.8/dist-packages/torch/include/ATen/ATen.h:9,
from /usr/local/lib/python3.8/dist-packages/torch/include/torch/csrc/api/include/torch/types.h:3,
from /usr/local/lib/python3.8/dist-packages/torch/include/torch/csrc/api/include/torch/serialize/input-archive.h:6,
from /usr/local/lib/python3.8/dist-packages/torch/include/torch/csrc/api/include/torch/serialize/archive.h:3,
from /usr/local/lib/python3.8/dist-packages/torch/include/torch/csrc/api/include/torch/serialize/tensor.h:3,
from pcdet/ops/iou3d_nms/src/iou3d_nms.cpp:7:
/usr/local/lib/python3.8/dist-packages/torch/include/ATen/core/TensorBody.h:398:7: note: declared here
398 |   T * data() const {
|       ^~~~
pcdet/ops/iou3d_nms/src/iou3d_nms.cpp:62:54: warning: ‘T* at::Tensor::data() const [with T = float]’ is deprecated: Tensor.data() is deprecated. Please use Tensor.data_ptr() instead. [-Wdeprecated-declarations]
62 |     const float * boxes_b_data = boxes_b.data();
|                                                      ^
In file included from /usr/local/lib/python3.8/dist-packages/torch/include/ATen/Tensor.h:3,
from /usr/local/lib/python3.8/dist-packages/torch/include/ATen/Context.h:4,
from /usr/local/lib/python3.8/dist-packages/torch/include/ATen/ATen.h:9,
from /usr/local/lib/python3.8/dist-packages/torch/include/torch/csrc/api/include/torch/types.h:3,
from /usr/local/lib/python3.8/dist-packages/torch/include/torch/csrc/api/include/torch/serialize/input-archive.h:6,
from /usr/local/lib/python3.8/dist-packages/torch/include/torch/csrc/api/include/torch/serialize/archive.h:3,
from /usr/local/lib/python3.8/dist-packages/torch/include/torch/csrc/api/include/torch/serialize/tensor.h:3,
from pcdet/ops/iou3d_nms/src/iou3d_nms.cpp:7:
/usr/local/lib/python3.8/dist-packages/torch/include/ATen/core/TensorBody.h:398:7: note: declared here
398 |   T * data() const {
|       ^~~~
pcdet/ops/iou3d_nms/src/iou3d_nms.cpp:63:56: warning: ‘T* at::Tensor::data() const [with T = float]’ is deprecated: Tensor.data() is deprecated. Please use Tensor.data_ptr() instead. [-Wdeprecated-declarations]
63 |     float * ans_overlap_data = ans_overlap.data();
|                                                        ^
In file included from /usr/local/lib/python3.8/dist-packages/torch/include/ATen/Tensor.h:3,
from /usr/local/lib/python3.8/dist-packages/torch/include/ATen/Context.h:4,
from /usr/local/lib/python3.8/dist-packages/torch/include/ATen/ATen.h:9,
from /usr/local/lib/python3.8/dist-packages/torch/include/torch/csrc/api/include/torch/types.h:3,
from /usr/local/lib/python3.8/dist-packages/torch/include/torch/csrc/api/include/torch/serialize/input-archive.h:6,
from /usr/local/lib/python3.8/dist-packages/torch/include/torch/csrc/api/include/torch/serialize/archive.h:3,
from /usr/local/lib/python3.8/dist-packages/torch/include/torch/csrc/api/include/torch/serialize/tensor.h:3,
from pcdet/ops/iou3d_nms/src/iou3d_nms.cpp:7:
/usr/local/lib/python3.8/dist-packages/torch/include/ATen/core/TensorBody.h:398:7: note: declared here
398 |   T * data() const {
|       ^~~~
pcdet/ops/iou3d_nms/src/iou3d_nms.cpp: In function ‘int boxes_iou_bev_gpu(at::Tensor, at::Tensor, at::Tensor)’:
pcdet/ops/iou3d_nms/src/iou3d_nms.cpp:15:15: warning: ‘at::DeprecatedTypeProperties& at::Tensor::type() const’ is deprecated: Tensor.type() is deprecated. Instead use Tensor.options(), which in many cases (e.g. in a constructor) is a drop-in replacement. If you were using data from type(), that is now available from Tensor itself, so instead of tensor.type().scalar_type(), use tensor.scalar_type() instead and instead of tensor.type().backend() use tensor.device(). [-Wdeprecated-declarations]
15 |   if (!x.type().is_cuda()) {
|               ^
pcdet/ops/iou3d_nms/src/iou3d_nms.cpp:26:24: note: in expansion of macro ‘CHECK_CUDA’
26 | #define CHECK_INPUT(x) CHECK_CUDA(x);CHECK_CONTIGUOUS(x)
|                        ^~~~~~~~~~
pcdet/ops/iou3d_nms/src/iou3d_nms.cpp:74:5: note: in expansion of macro ‘CHECK_INPUT’
74 |     CHECK_INPUT(boxes_a);
|     ^~~~~~~~~~~
In file included from /usr/local/lib/python3.8/dist-packages/torch/include/ATen/Tensor.h:3,
from /usr/local/lib/python3.8/dist-packages/torch/include/ATen/Context.h:4,
from /usr/local/lib/python3.8/dist-packages/torch/include/ATen/ATen.h:9,
from /usr/local/lib/python3.8/dist-packages/torch/include/torch/csrc/api/include/torch/types.h:3,
from /usr/local/lib/python3.8/dist-packages/torch/include/torch/csrc/api/include/torch/serialize/input-archive.h:6,
from /usr/local/lib/python3.8/dist-packages/torch/include/torch/csrc/api/include/torch/serialize/archive.h:3,
from /usr/local/lib/python3.8/dist-packages/torch/include/torch/csrc/api/include/torch/serialize/tensor.h:3,
from pcdet/ops/iou3d_nms/src/iou3d_nms.cpp:7:
/usr/local/lib/python3.8/dist-packages/torch/include/ATen/core/TensorBody.h:303:30: note: declared here
303 |   DeprecatedTypeProperties & type() const {
|                              ^~~~
pcdet/ops/iou3d_nms/src/iou3d_nms.cpp:15:15: warning: ‘at::DeprecatedTypeProperties& at::Tensor::type() const’ is deprecated: Tensor.type() is deprecated. Instead use Tensor.options(), which in many cases (e.g. in a constructor) is a drop-in replacement. If you were using data from type(), that is now available from Tensor itself, so instead of tensor.type().scalar_type(), use tensor.scalar_type() instead and instead of tensor.type().backend() use tensor.device(). [-Wdeprecated-declarations]
15 |   if (!x.type().is_cuda()) {
|               ^
pcdet/ops/iou3d_nms/src/iou3d_nms.cpp:26:24: note: in expansion of macro ‘CHECK_CUDA’
26 | #define CHECK_INPUT(x) CHECK_CUDA(x);CHECK_CONTIGUOUS(x)
|                        ^~~~~~~~~~
pcdet/ops/iou3d_nms/src/iou3d_nms.cpp:75:5: note: in expansion of macro ‘CHECK_INPUT’
75 |     CHECK_INPUT(boxes_b);
|     ^~~~~~~~~~~
In file included from /usr/local/lib/python3.8/dist-packages/torch/include/ATen/Tensor.h:3,
from /usr/local/lib/python3.8/dist-packages/torch/include/ATen/Context.h:4,
from /usr/local/lib/python3.8/dist-packages/torch/include/ATen/ATen.h:9,
from /usr/local/lib/python3.8/dist-packages/torch/include/torch/csrc/api/include/torch/types.h:3,
from /usr/local/lib/python3.8/dist-packages/torch/include/torch/csrc/api/include/torch/serialize/input-archive.h:6,
from /usr/local/lib/python3.8/dist-packages/torch/include/torch/csrc/api/include/torch/serialize/archive.h:3,
from /usr/local/lib/python3.8/dist-packages/torch/include/torch/csrc/api/include/torch/serialize/tensor.h:3,
from pcdet/ops/iou3d_nms/src/iou3d_nms.cpp:7:
/usr/local/lib/python3.8/dist-packages/torch/include/ATen/core/TensorBody.h:303:30: note: declared here
303 |   DeprecatedTypeProperties & type() const {
|                              ^~~~
pcdet/ops/iou3d_nms/src/iou3d_nms.cpp:15:15: warning: ‘at::DeprecatedTypeProperties& at::Tensor::type() const’ is deprecated: Tensor.type() is deprecated. Instead use Tensor.options(), which in many cases (e.g. in a constructor) is a drop-in replacement. If you were using data from type(), that is now available from Tensor itself, so instead of tensor.type().scalar_type(), use tensor.scalar_type() instead and instead of tensor.type().backend() use tensor.device(). [-Wdeprecated-declarations]
15 |   if (!x.type().is_cuda()) {
|               ^
pcdet/ops/iou3d_nms/src/iou3d_nms.cpp:26:24: note: in expansion of macro ‘CHECK_CUDA’
26 | #define CHECK_INPUT(x) CHECK_CUDA(x);CHECK_CONTIGUOUS(x)
|                        ^~~~~~~~~~
pcdet/ops/iou3d_nms/src/iou3d_nms.cpp:76:5: note: in expansion of macro ‘CHECK_INPUT’
76 |     CHECK_INPUT(ans_iou);
|     ^~~~~~~~~~~
In file included from /usr/local/lib/python3.8/dist-packages/torch/include/ATen/Tensor.h:3,
from /usr/local/lib/python3.8/dist-packages/torch/include/ATen/Context.h:4,
from /usr/local/lib/python3.8/dist-packages/torch/include/ATen/ATen.h:9,
from /usr/local/lib/python3.8/dist-packages/torch/include/torch/csrc/api/include/torch/types.h:3,
from /usr/local/lib/python3.8/dist-packages/torch/include/torch/csrc/api/include/torch/serialize/input-archive.h:6,
from /usr/local/lib/python3.8/dist-packages/torch/include/torch/csrc/api/include/torch/serialize/archive.h:3,
from /usr/local/lib/python3.8/dist-packages/torch/include/torch/csrc/api/include/torch/serialize/tensor.h:3,
from pcdet/ops/iou3d_nms/src/iou3d_nms.cpp:7:
/usr/local/lib/python3.8/dist-packages/torch/include/ATen/core/TensorBody.h:303:30: note: declared here
303 |   DeprecatedTypeProperties & type() const {
|                              ^~~~
pcdet/ops/iou3d_nms/src/iou3d_nms.cpp:81:54: warning: ‘T* at::Tensor::data() const [with T = float]’ is deprecated: Tensor.data() is deprecated. Please use Tensor.data_ptr() instead. [-Wdeprecated-declarations]
81 |     const float * boxes_a_data = boxes_a.data();
|                                                      ^
In file included from /usr/local/lib/python3.8/dist-packages/torch/include/ATen/Tensor.h:3,
from /usr/local/lib/python3.8/dist-packages/torch/include/ATen/Context.h:4,
from /usr/local/lib/python3.8/dist-packages/torch/include/ATen/ATen.h:9,
from /usr/local/lib/python3.8/dist-packages/torch/include/torch/csrc/api/include/torch/types.h:3,
from /usr/local/lib/python3.8/dist-packages/torch/include/torch/csrc/api/include/torch/serialize/input-archive.h:6,
from /usr/local/lib/python3.8/dist-packages/torch/include/torch/csrc/api/include/torch/serialize/archive.h:3,
from /usr/local/lib/python3.8/dist-packages/torch/include/torch/csrc/api/include/torch/serialize/tensor.h:3,
from pcdet/ops/iou3d_nms/src/iou3d_nms.cpp:7:
/usr/local/lib/python3.8/dist-packages/torch/include/ATen/core/TensorBody.h:398:7: note: declared here
398 |   T * data() const {
|       ^~~~
pcdet/ops/iou3d_nms/src/iou3d_nms.cpp:82:54: warning: ‘T* at::Tensor::data() const [with T = float]’ is deprecated: Tensor.data() is deprecated. Please use Tensor.data_ptr() instead. [-Wdeprecated-declarations]
82 |     const float * boxes_b_data = boxes_b.data();
|                                                      ^
In file included from /usr/local/lib/python3.8/dist-packages/torch/include/ATen/Tensor.h:3,
from /usr/local/lib/python3.8/dist-packages/torch/include/ATen/Context.h:4,
from /usr/local/lib/python3.8/dist-packages/torch/include/ATen/ATen.h:9,
from /usr/local/lib/python3.8/dist-packages/torch/include/torch/csrc/api/include/torch/types.h:3,
from /usr/local/lib/python3.8/dist-packages/torch/include/torch/csrc/api/include/torch/serialize/input-archive.h:6,
from /usr/local/lib/python3.8/dist-packages/torch/include/torch/csrc/api/include/torch/serialize/archive.h:3,
from /usr/local/lib/python3.8/dist-packages/torch/include/torch/csrc/api/include/torch/serialize/tensor.h:3,
from pcdet/ops/iou3d_nms/src/iou3d_nms.cpp:7:
/usr/local/lib/python3.8/dist-packages/torch/include/ATen/core/TensorBody.h:398:7: note: declared here
398 |   T * data() const {
|       ^~~~
pcdet/ops/iou3d_nms/src/iou3d_nms.cpp:83:48: warning: ‘T* at::Tensor::data() const [with T = float]’ is deprecated: Tensor.data() is deprecated. Please use Tensor.data_ptr() instead. [-Wdeprecated-declarations]
83 |     float * ans_iou_data = ans_iou.data();
|                                                ^
In file included from /usr/local/lib/python3.8/dist-packages/torch/include/ATen/Tensor.h:3,
from /usr/local/lib/python3.8/dist-packages/torch/include/ATen/Context.h:4,
from /usr/local/lib/python3.8/dist-packages/torch/include/ATen/ATen.h:9,
from /usr/local/lib/python3.8/dist-packages/torch/include/torch/csrc/api/include/torch/types.h:3,
from /usr/local/lib/python3.8/dist-packages/torch/include/torch/csrc/api/include/torch/serialize/input-archive.h:6,
from /usr/local/lib/python3.8/dist-packages/torch/include/torch/csrc/api/include/torch/serialize/archive.h:3,
from /usr/local/lib/python3.8/dist-packages/torch/include/torch/csrc/api/include/torch/serialize/tensor.h:3,
from pcdet/ops/iou3d_nms/src/iou3d_nms.cpp:7:
/usr/local/lib/python3.8/dist-packages/torch/include/ATen/core/TensorBody.h:398:7: note: declared here
398 |   T * data() const {
|       ^~~~
pcdet/ops/iou3d_nms/src/iou3d_nms.cpp: In function ‘int nms_gpu(at::Tensor, at::Tensor, float)’:
pcdet/ops/iou3d_nms/src/iou3d_nms.cpp:15:15: warning: ‘at::DeprecatedTypeProperties& at::Tensor::type() const’ is deprecated: Tensor.type() is deprecated. Instead use Tensor.options(), which in many cases (e.g. in a constructor) is a drop-in replacement. If you were using data from type(), that is now available from Tensor itself, so instead of tensor.type().scalar_type(), use tensor.scalar_type() instead and instead of tensor.type().backend() use tensor.device(). [-Wdeprecated-declarations]
15 |   if (!x.type().is_cuda()) {
|               ^
pcdet/ops/iou3d_nms/src/iou3d_nms.cpp:26:24: note: in expansion of macro ‘CHECK_CUDA’
26 | #define CHECK_INPUT(x) CHECK_CUDA(x);CHECK_CONTIGUOUS(x)
|                        ^~~~~~~~~~
pcdet/ops/iou3d_nms/src/iou3d_nms.cpp:93:5: note: in expansion of macro ‘CHECK_INPUT’
93 |     CHECK_INPUT(boxes);
|     ^~~~~~~~~~~
In file included from /usr/local/lib/python3.8/dist-packages/torch/include/ATen/Tensor.h:3,
from /usr/local/lib/python3.8/dist-packages/torch/include/ATen/Context.h:4,
from /usr/local/lib/python3.8/dist-packages/torch/include/ATen/ATen.h:9,
from /usr/local/lib/python3.8/dist-packages/torch/include/torch/csrc/api/include/torch/types.h:3,
from /usr/local/lib/python3.8/dist-packages/torch/include/torch/csrc/api/include/torch/serialize/input-archive.h:6,
from /usr/local/lib/python3.8/dist-packages/torch/include/torch/csrc/api/include/torch/serialize/archive.h:3,
from /usr/local/lib/python3.8/dist-packages/torch/include/torch/csrc/api/include/torch/serialize/tensor.h:3,
from pcdet/ops/iou3d_nms/src/iou3d_nms.cpp:7:
/usr/local/lib/python3.8/dist-packages/torch/include/ATen/core/TensorBody.h:303:30: note: declared here
303 |   DeprecatedTypeProperties & type() const {
|                              ^~~~
pcdet/ops/iou3d_nms/src/iou3d_nms.cpp:97:50: warning: ‘T* at::Tensor::data() const [with T = float]’ is deprecated: Tensor.data() is deprecated. Please use Tensor.data_ptr() instead. [-Wdeprecated-declarations]
97 |     const float * boxes_data = boxes.data();
|                                                  ^
In file included from /usr/local/lib/python3.8/dist-packages/torch/include/ATen/Tensor.h:3,
from /usr/local/lib/python3.8/dist-packages/torch/include/ATen/Context.h:4,
from /usr/local/lib/python3.8/dist-packages/torch/include/ATen/ATen.h:9,
from /usr/local/lib/python3.8/dist-packages/torch/include/torch/csrc/api/include/torch/types.h:3,
from /usr/local/lib/python3.8/dist-packages/torch/include/torch/csrc/api/include/torch/serialize/input-archive.h:6,
from /usr/local/lib/python3.8/dist-packages/torch/include/torch/csrc/api/include/torch/serialize/archive.h:3,
from /usr/local/lib/python3.8/dist-packages/torch/include/torch/csrc/api/include/torch/serialize/tensor.h:3,
from pcdet/ops/iou3d_nms/src/iou3d_nms.cpp:7:
/usr/local/lib/python3.8/dist-packages/torch/include/ATen/core/TensorBody.h:398:7: note: declared here
398 |   T * data() const {
|       ^~~~
pcdet/ops/iou3d_nms/src/iou3d_nms.cpp:98:40: warning: ‘T* at::Tensor::data() const [with T = long int]’ is deprecated: Tensor.data() is deprecated. Please use Tensor.data_ptr() instead. [-Wdeprecated-declarations]
98 |     long * keep_data = keep.data();
|                                        ^
In file included from /usr/local/lib/python3.8/dist-packages/torch/include/ATen/Tensor.h:3,
from /usr/local/lib/python3.8/dist-packages/torch/include/ATen/Context.h:4,
from /usr/local/lib/python3.8/dist-packages/torch/include/ATen/ATen.h:9,
from /usr/local/lib/python3.8/dist-packages/torch/include/torch/csrc/api/include/torch/types.h:3,
from /usr/local/lib/python3.8/dist-packages/torch/include/torch/csrc/api/include/torch/serialize/input-archive.h:6,
from /usr/local/lib/python3.8/dist-packages/torch/include/torch/csrc/api/include/torch/serialize/archive.h:3,
from /usr/local/lib/python3.8/dist-packages/torch/include/torch/csrc/api/include/torch/serialize/tensor.h:3,
from pcdet/ops/iou3d_nms/src/iou3d_nms.cpp:7:
/usr/local/lib/python3.8/dist-packages/torch/include/ATen/core/TensorBody.h:398:7: note: declared here
398 |   T * data() const {
|       ^~~~
pcdet/ops/iou3d_nms/src/iou3d_nms.cpp: In function ‘int nms_normal_gpu(at::Tensor, at::Tensor, float)’:
pcdet/ops/iou3d_nms/src/iou3d_nms.cpp:15:15: warning: ‘at::DeprecatedTypeProperties& at::Tensor::type() const’ is deprecated: Tensor.type() is deprecated. Instead use Tensor.options(), which in many cases (e.g. in a constructor) is a drop-in replacement. If you were using data from type(), that is now available from Tensor itself, so instead of tensor.type().scalar_type(), use tensor.scalar_type() instead and instead of tensor.type().backend() use tensor.device(). [-Wdeprecated-declarations]
15 |   if (!x.type().is_cuda()) {
|               ^
pcdet/ops/iou3d_nms/src/iou3d_nms.cpp:26:24: note: in expansion of macro ‘CHECK_CUDA’
26 | #define CHECK_INPUT(x) CHECK_CUDA(x);CHECK_CONTIGUOUS(x)
|                        ^~~~~~~~~~
pcdet/ops/iou3d_nms/src/iou3d_nms.cpp:143:5: note: in expansion of macro ‘CHECK_INPUT’
143 |     CHECK_INPUT(boxes);
|     ^~~~~~~~~~~
In file included from /usr/local/lib/python3.8/dist-packages/torch/include/ATen/Tensor.h:3,
from /usr/local/lib/python3.8/dist-packages/torch/include/ATen/Context.h:4,
from /usr/local/lib/python3.8/dist-packages/torch/include/ATen/ATen.h:9,
from /usr/local/lib/python3.8/dist-packages/torch/include/torch/csrc/api/include/torch/types.h:3,
from /usr/local/lib/python3.8/dist-packages/torch/include/torch/csrc/api/include/torch/serialize/input-archive.h:6,
from /usr/local/lib/python3.8/dist-packages/torch/include/torch/csrc/api/include/torch/serialize/archive.h:3,
from /usr/local/lib/python3.8/dist-packages/torch/include/torch/csrc/api/include/torch/serialize/tensor.h:3,
from pcdet/ops/iou3d_nms/src/iou3d_nms.cpp:7:
/usr/local/lib/python3.8/dist-packages/torch/include/ATen/core/TensorBody.h:303:30: note: declared here
303 |   DeprecatedTypeProperties & type() const {
|                              ^~~~
pcdet/ops/iou3d_nms/src/iou3d_nms.cpp:147:50: warning: ‘T* at::Tensor::data() const [with T = float]’ is deprecated: Tensor.data() is deprecated. Please use Tensor.data_ptr() instead. [-Wdeprecated-declarations]
147 |     const float * boxes_data = boxes.data();
|                                                  ^
In file included from /usr/local/lib/python3.8/dist-packages/torch/include/ATen/Tensor.h:3,
from /usr/local/lib/python3.8/dist-packages/torch/include/ATen/Context.h:4,
from /usr/local/lib/python3.8/dist-packages/torch/include/ATen/ATen.h:9,
from /usr/local/lib/python3.8/dist-packages/torch/include/torch/csrc/api/include/torch/types.h:3,
from /usr/local/lib/python3.8/dist-packages/torch/include/torch/csrc/api/include/torch/serialize/input-archive.h:6,
from /usr/local/lib/python3.8/dist-packages/torch/include/torch/csrc/api/include/torch/serialize/archive.h:3,
from /usr/local/lib/python3.8/dist-packages/torch/include/torch/csrc/api/include/torch/serialize/tensor.h:3,
from pcdet/ops/iou3d_nms/src/iou3d_nms.cpp:7:
/usr/local/lib/python3.8/dist-packages/torch/include/ATen/core/TensorBody.h:398:7: note: declared here
398 |   T * data() const {
|       ^~~~
pcdet/ops/iou3d_nms/src/iou3d_nms.cpp:148:40: warning: ‘T* at::Tensor::data() const [with T = long int]’ is deprecated: Tensor.data() is deprecated. Please use Tensor.data_ptr() instead. [-Wdeprecated-declarations]
148 |     long * keep_data = keep.data();
|                                        ^
In file included from /usr/local/lib/python3.8/dist-packages/torch/include/ATen/Tensor.h:3,
from /usr/local/lib/python3.8/dist-packages/torch/include/ATen/Context.h:4,
from /usr/local/lib/python3.8/dist-packages/torch/include/ATen/ATen.h:9,
from /usr/local/lib/python3.8/dist-packages/torch/include/torch/csrc/api/include/torch/types.h:3,
from /usr/local/lib/python3.8/dist-packages/torch/include/torch/csrc/api/include/torch/serialize/input-archive.h:6,
from /usr/local/lib/python3.8/dist-packages/torch/include/torch/csrc/api/include/torch/serialize/archive.h:3,
from /usr/local/lib/python3.8/dist-packages/torch/include/torch/csrc/api/include/torch/serialize/tensor.h:3,
from pcdet/ops/iou3d_nms/src/iou3d_nms.cpp:7:
/usr/local/lib/python3.8/dist-packages/torch/include/ATen/core/TensorBody.h:398:7: note: declared here
398 |   T * data() const {
|       ^~~~
Traceback (most recent call last):
File "setup.py", line 34, in
setup(
File "/usr/lib/python3/dist-packages/setuptools/init.py", line 144, in setup
return distutils.core.setup(**attrs)
File "/usr/lib/python3.8/distutils/core.py", line 148, in setup
dist.run_commands()
File "/usr/lib/python3.8/distutils/dist.py", line 966, in run_commands
self.run_command(cmd)
File "/usr/lib/python3.8/distutils/dist.py", line 985, in run_command
cmd_obj.run()
File "/usr/lib/python3/dist-packages/setuptools/command/develop.py", line 38, in run
self.install_for_development()
File "/usr/lib/python3/dist-packages/setuptools/command/develop.py", line 140, in install_for_development
self.run_command('build_ext')
File "/usr/lib/python3.8/distutils/cmd.py", line 313, in run_command
self.distribution.run_command(command)
File "/usr/lib/python3.8/distutils/dist.py", line 985, in run_command
cmd_obj.run()
File "/usr/lib/python3/dist-packages/setuptools/command/build_ext.py", line 87, in run
_build_ext.run(self)
File "/usr/lib/python3.8/distutils/command/build_ext.py", line 340, in run
self.build_extensions()
File "/usr/local/lib/python3.8/dist-packages/torch/utils/cpp_extension.py", line 708, in build_extensions
build_ext.build_extensions(self)
File "/usr/lib/python3.8/distutils/command/build_ext.py", line 449, in build_extensions
self._build_extensions_serial()
File "/usr/lib/python3.8/distutils/command/build_ext.py", line 474, in _build_extensions_serial
self.build_extension(ext)
File "/usr/lib/python3/dist-packages/setuptools/command/build_ext.py", line 208, in build_extension
_build_ext.build_extension(self, ext)
File "/usr/lib/python3.8/distutils/command/build_ext.py", line 528, in build_extension
objects = self.compiler.compile(sources,
File "/usr/lib/python3.8/distutils/ccompiler.py", line 574, in compile
self._compile(obj, src, ext, cc_args, extra_postargs, pp_opts)
File "/usr/local/lib/python3.8/dist-packages/torch/utils/cpp_extension.py", line 456, in unix_wrap_single_compile
cflags = unix_cuda_flags(cflags)
File "/usr/local/lib/python3.8/dist-packages/torch/utils/cpp_extension.py", line 423, in unix_cuda_flags
cflags + _get_cuda_arch_flags(cflags))
File "/usr/local/lib/python3.8/dist-packages/torch/utils/cpp_extension.py", line 1561, in _get_cuda_arch_flags
arch_list[-1] += '+PTX'
IndexError: list index out of range
Please help! Thank you so much!

Click this link :wink:
First search result: https://github.com/pytorch/pytorch/issues/40671

@MartinHahner
Hai Sir,
I had trained my own  dataset (from velodyne 32 lidar) with Rcnn but getting wrong results ,It is producing lots of BBoxes could you please help......
Thanks in advance

@MartinHahner
Hai Sir,
I had trained my own dataset (from velodyne 32 lidar) with Rcnn but getting wrong results ,It is producing lots of BBoxes could you please help......
Thanks in advance

Maybe you can try to remove the boxes with low scores first? This worked (to a certain extend) with pointrcnn for me. Using the pre-trained weights.

Thanks isir,
How did you setup your dataset ,In my case  i am only using velodyne data so i put dummy images .
Could you please give me some elaboration
Thanks in advance
If you dont mind could you please gave me your mail ID sir....

@turtleMaster20
Thanks sir,
How did you setup your dataset ,In my case i am only using velodyne data so i put dummy images .
Could you please give me some elaboration
Thanks in advance
If you dont mind could you please gave me your mail ID sir....

I used the pre-trained weights from the package. My Application is with ROS so I am using the velodyne data directly with the script from here. Look for remove_low_score_nu.
This system architecture is completely pointcloud based so I don't understand why you have to use dummy images (or are you referring to the velodyne pointcloud as images?).
To my understanding PointRCNN is based on PointClouds and RCNN is based on 2D Camera Images.
If you use the above mentioned script then you can just subscribe to the topic from velodyne and should work smoothly with the pre-trained weights or with your own trained weights.

Did you solve this issue?

Just for reference, it may help
Error: List Index out of range
How to solve?
This means your relevant software package installation has some problem,  for me, it is related to nvidia, please refer to the following link for details.
https://spacevision.blog.csdn.net/article/details/121672106
Make sure your nvidia driver and nvidia prob are installed correctly.


[BUG] Could not load ICU data. UErrorCode: 2

Office Tool Plus Version,

Office_Tool_with_runtime_v<IP_ADDRESS>_x64.7z

Operating System,

WinPE 11-10-8 Sergei Strelec (x86/x64/Native x86) 2023.06.25 English version
Loaded with Easy2Boot v2.20 by Steve Si with .isoHW file extension.
I choose to boot in Windows 10 x64 20H1 10.0.19041.1

Error description (required):
If I run Office Tool Plus.exe, it will be crashed at launch.
Here is the screenshot from Process Monitor v3.96 by Sysinternals:

And if I start with
"Office Tool Plus.Console.exe" /start

It will output this error:
Could not load ICU data. UErrorCode: 2

We don't make any warranties for use in non-standard environments.

I'm not demanding any warranties.
But a bug is still a bug.

I'm not demanding any warranties. But a bug is still a bug.

PE is not a standard environments. We won't do anything about bugs in non-standard environments.

Okay.
I've just tested it on Windows 11 x64 Home 23H2 10.0.22631.3007
If you try to rename, delete, or corrupt the file of icudtl.dat within the directory of:
C:\Windows\Globalization\ICU

Then you will receive the same error.
I've looked up on the internet, it seems because of improper unicode support in case of failure or something like that.

Okay. I've just tested it on Windows 11 x64 Home 23H2 10.0.22631.3007 If you try to rename, delete, or corrupt the file with the full path of:
C:\Windows\Globalization\ICU\icudtl.dat

Then you will receive the same error.
The same thing also happened with C:\Windows\System32\icu.dll
I've looked up on the internet, it seems because of improper unicode support in case of failure or something like that. Add a fallback mechanism perhaps?

This is a bug with .NET runtime, you should report it to the .NET team.


Add filter for "AWS compute (EC2) instances" card

We need to apply the following filter for the "AWS compute (EC2) instances" card, shown in both "Ocp on AWS" and "AWS" overview tabs.
filter[service]=AmazonEC2
Fixes https://github.com/project-koku/koku-ui/issues/830

Codecov Report

Merging #831 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #831   +/-   ##
=======================================
  Coverage   74.29%   74.29%
=======================================
  Files         210      210
  Lines        3707     3707
  Branches      648      648
=======================================
  Hits         2754     2754
  Misses        861      861
  Partials       92       92

Impacted Files
Coverage Δ

src/store/awsDashboard/awsDashboardWidgets.ts
100% <ø> (ø)
:arrow_up:

...tore/ocpOnAwsDashboard/ocpOnAwsDashboardWidgets.ts
100% <ø> (ø)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1dff27a...3a1c3a2. Read the comment docs.


Expose Table::new to pub

Since I use scraper elsewhere in my code, it is more efficient to use it directly in table-extract, too. Hence, in this tiny PR I propose adding pub in front of Table::new. I've also updated scraper to the latest version.

Sorry I didn't see this until now, my GitHub notifications must not set up correctly.

Thanks!


Is the vscode min-version needed

The project now has a vscode min-version mandate of 1.85.1.
https://github.com/Dando18/slurm-dashboard/blob/df81059dc92825603753bca1731967b710511d8c/package.json#L18
For some reason, i have to work on vscode 1.81.1 (versions after which incompatible with Windows 7), and finding myself blocked by this mandate.
Is this mandate required by some new vscode API used by the extension? If it's just an arbitrary choice, i would be very grateful if you can change it lower.

Hi, thanks for pointing this out!
I wanted to add CI testing for older vscode releases first, since I only develop on the most recent stable release and don't check older version compatibility.
I added this in #56 and it looks like 1.81.1 passes all the tests. I'll bump a release soon with the updated constraint.

This has been uploaded in a release: v0.0.11
Let me know if there are any issues.