Investigate task not completed warnings

This has been discussed before and was brought up again at https://github.com/gulpjs/gulp/issues/1241#issuecomment-141712495
It would be really awesome if gulp 4 could report to users when they forget to call their callback or return a stream/promise/observable/etc.  I am not sure how to achieve this but I would love if someone could investigate this.
Note: gulp 4 doesn't support sync tasks, so the warning would always be valid (unlike gulp 3.x)

+1, I'd be interested in looking into this.
It would just be a case of checking the function length or checking that the return type is equal to one of these, right? I guess it could just check for any return value, but that could cause problems with coffeescript.
What about disabling the warning: how would people go about doing that if they know what they're doing and don't want to return anything? return through.obj() or something like this.disableSyncWarning()?

You should just be able to use the events emitted by undertaker for start and stop. Maybe warn after a certain amount of time if the stop event isn't emitted?

But if a task takes one second and it warns after two, it will say that it took 1ms time, and then quit before the warning has time to output. That seems like it would be a fairly common case.

@callumacrae if a setTimeout is set inside the on('start') and cleared in the on('stop'), the CLI will run until it is cleared or called because you have more async stuff happening (the timeout).  Currently the CLI exits because there are no inherent async things running (we only nextTick each task, so the async has completed before the task finishes).

@callumacrae @contra and anyone else interested in this, please try out https://github.com/gulpjs/gulp-cli/tree/warn-sync-tasks and give feedback.  It seems to be working in my quick tests but it could probably use a better error message and we might want to make the timeout configurable with a CLI flag.

Still looking for feedback.  The more I think about this, I think I need to add a --timeout flag.

@phated I think a timeout flag is better aligned with other JS tooling (mocha, for example)

Added the timeout flag on the linked branch.  Default is 10000 milliseconds.

I've also merged these changes into the 4.0 branch because I want more people to have eyes on it and it seems a bunch of people are using that branch currently.

@phated the time out flag is really cool and helped with a few items, thanks for including it. Is the intent to have this time out on watch tasks as well?

@ckross01 yeah, in gulp 4 you should call the callback after registering watches also.  This allows the function to be composed anywhere and doesn't get the pipeline stuck on that sync task.  Just had the same discussion with @terinjokes

@ckross01 @terinjokes @callumacrae @contra bikeshed time!  how about we set the timeout to 1 minute?  This is just a debugging tool, so hanging for a minute would be annoying but will still result in the error being printed

I still don't really understand why this needs a timeout. Why not listen to the process beforeExit event or an event fired in gulp and throw if nothing was returned / there was no callback?
I think I'm missing something!

@callumacrae great idea, I have a new implementation over at https://github.com/gulpjs/gulp-cli/tree/new-task-warning-impl and I think this will work much better.  Need some people to test it out

Here is my gulpfile:
var gulp = require('gulp');

gulp.task('complete', function (done) {
	setTimeout(done, 1000);
});

gulp.task('notcomplete', function (done) {
});

gulp.task('notreturned', function () {
});

Output in Gulp 4:
❯ ./node_modules/gulp-cli/bin/gulp.js complete
[12:05:28] Using gulpfile ~/tmp/gulp-if-bug/gulpfile.js
[12:05:28] Starting 'complete'...
[12:05:29] Finished 'complete' after 1 s

❯ ./node_modules/gulp-cli/bin/gulp.js notcomplete
[12:05:32] Using gulpfile ~/tmp/gulp-if-bug/gulpfile.js
[12:05:32] Starting 'notcomplete'...
[12:05:32] The following tasks did not complete: notcomplete
[12:05:32] Did you forget to signal async completion?

❯ ./node_modules/gulp-cli/bin/gulp.js notreturned
[12:05:37] Using gulpfile ~/tmp/gulp-if-bug/gulpfile.js
[12:05:37] Starting 'notreturned'...
[12:05:37] The following tasks did not complete: notreturned
[12:05:37] Did you forget to signal async completion?

Output when using gulp-cli with Gulp 3:
❯ ./node_modules/gulp-cli/bin/gulp.js complete
[12:03:37] Using gulpfile ~/tmp/gulp-if-bug/gulpfile.js
[12:03:37] Starting 'complete'...
[12:03:38] Finished 'complete' after 1 s

❯ ./node_modules/gulp-cli/bin/gulp.js notcomplete
[12:03:43] Using gulpfile ~/tmp/gulp-if-bug/gulpfile.js
[12:03:43] Starting 'notcomplete'...

❯ ./node_modules/gulp-cli/bin/gulp.js notreturned
[12:03:48] Using gulpfile ~/tmp/gulp-if-bug/gulpfile.js
[12:03:48] Starting 'notreturned'...
[12:03:48] Finished 'notreturned' after 60 μs

Everything is as expected, except that the notreturned task doesn't seem to complete in the 4.0 branch.

@callumacrae notreturned isn't supposed to complete in 4.0 as sync tasks were completely removed.  That is actually the reason for adding this warning.  I tested that branch against a similar gulpfile and am hoping to have a few people test it against their actual ones as well as mock ones.  Thanks!

Ah. I'm still not using Gulp 4—I'll be updating in the next couple weeks, though.

The new implementation has been merged into 4.0 - Going to close this.  If anyone has feedback, feel free to post it here

@phated It works well for me. If I'm not mistaken, then the below example code (from gulpjs 4.0) needs to be updated to return del(['build']) ?
/* Define our tasks using plain functions */

// Not all tasks need to use streams
// A gulpfile is just another node program and you can use all packages available on npm
function clean(done) {
  // You can use multiple globbing patterns as you would with `gulp.src`
  del(['build'], done);
}

@dacodekid depends whether you're using del 1 or 2. If you're using del 2, return the promise, otherwise use a callback.
https://github.com/sindresorhus/del/releases/tag/v2.0.0

@callumacrae, no I'm not asking for help :).  The above provided example is actually from gulpjs 4.0 github repo, that emitting task not completed warning, which I thought might be worth mentioning. My bad for not clearly mentioned my intension :)

Oh, sorry! Are you talking about the example from this file? And are you definitely using del 2? https://github.com/gulpjs/gulp/blob/master/docs/recipes/delete-files-folder.md

Nope, but this one - https://github.com/gulpjs/gulp/blob/4.0/README.md
The 'clean' task didn't provide a promise/cb return on the example. While I was just copy/pasting the 'clean' function and call via 'default' task, I got the task not completed warning, that took me to this thread.

Ah, that's wrong and won't work with the latest version of del. I'll fix it later (or if you could send a PR that would be great!)

@callumacrae, Thx :). Created a pull request here - https://github.com/gulpjs/gulp/pull/1309.  Hope it fits with Gulp standards or otherwise plz feel free to reject it :).

It seems like --timeout=0 totally disables this. Is that coincidence or by design? (I first tried --timeout=-1), which didn't work.
For me, this feature just doesn't make sense for every task.
I have several tasks that either have prompts that wait for user input (inquirer) or actually involve sshing to a remote server with an interactive prompt.
Still feel like I should be able to disable this actually in my task options and not just on the cli, though.

@timkelty Is your version of gulp up to date? If you read through the full issue until where was closed, another approach was chosen. (unless, of course, @phated left the timeout code in as well)

@callumacrae I did read through the issue. The links to the mentioned branches are dead, so I'm not sure I'm supposed to see what the other approach was.

Listing your version doesn't help anything as none of this is published yet.  You are on an old version of the 4.0 branch.  The code for sync tasks has been switched to @callumacrae's suggestion.  See https://github.com/gulpjs/gulp-cli/blob/4.0/lib/versioned/^4.0.0-alpha.1/log/syncTask.js

@phated Right, whoops.
I reinstalled my local gulp, but not my global one (gulp command).
Thanks!

Similar issue here.
Setup
λ gulp -v
[10:52:08] CLI version 1.0.0
[10:52:08] Local version 4.0.0-alpha.2

Windows 7
Tasks
var del = require('del');
function clean() {
	return del(['docs', 'coverage', 'build', 'release']);
}

function build() {
	return gulp.series(
		clean
	);
}

Error
λ gulp build
[10:52:22] Using gulpfile C:\project\gulpfile.js
[10:52:22] Starting 'build'...
[10:52:22] The following tasks did not complete: build
[10:52:22] Did you forget to signal async completion?


MINOR: fix help dropdown item font and icon sizes

Describe your changes:
Fixes

fix help dropdown item font and icon sizes
optimize component

Issue :

Resolved :

Type of change:

[x] Bug fix
[x] Improvement
[ ] New feature
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[ ] Documentation

Checklist:

[x] I have read the CONTRIBUTING document.
[ ] My PR title is Fixes <issue-number>: <short explanation>
[ ] I have commented on my code, particularly in hard-to-understand areas.
[ ] For JSON Schema changes: I updated the migration scripts or explained why it is not needed.

@ShaileshParmar11  changes made as per comments!


Question 🙋♂

Hello kid1194,
Thanks for your script.
Before installing it may I ask, where is this better-attach UI element located?
I would like to have an upload button placed in list view, and not in any Doc form. Is this possible?

@charleslcso Hey bro..

Thanks for your script.

You are welcome buddy..

Before installing it may I ask, where is this better-attach UI element located?

This plugin improves the Attach and Attach Image fields in form and web form..

I would like to have an upload button placed in list view, and not in any Doc form. Is this possible?

This is not possible directly using this plugin.
But to achieve what you want, you will need a client script targeting the list view of your doctype and you will need a server script to store the attachment files..
So my question for you is, can you create server scripts or not?
Best regards..

Yes, I can create server script.

@charleslcso Ok..

Do you want the upload button for each row?
Is there a doctype where you want to store the uploaded file?

I want 3 upload buttons above the first row of Contact.
From what I read, I believe I should upload files to DocType File. I'm not sure at the moment, and need to study more.
Basically each user should own their own files, and not readable by others.

Will try today. Nice n appreciated! Also will let you know the result!

@charleslcso You can do that but indirectly, not like adding the upload buttons..
You will need to override a list method and handle the buttons click event manually, something like the following..
⚠ BTW, I don't know if the following code will work or not and I don't know if it will look good or will miss the list layout, so use at your own risk..
frappe.listview_settings['Contact'] = {
    onload: function(list) {
        list.get_header_html_skeleton = function(left = "", right = "") {
            return `

                        <button type="button" class="first_upload_btn btn btn-success btn-sm">
                            ${__('Upload')}
                        </button>

                        <button type="button" class="second_upload_btn btn btn-success btn-sm">
                            ${__('Upload')}
                        </button>

                        ${left}

                            <input class="level-item list-check-all" type="checkbox"
                                title="${__("Select All")}">

                        ${right}

            `;
        };
        // Buttons click event delegation
        list._build_upload_prompt = function(selector) {
            frappe.prompt(
                [
                    {
                        name: 'upload',
                        label: __('Upload'),
                        fieldtype: 'Attach'
                    }
                ],
                function(values) {
                    // Handle the upload file like: values.upload
                    list.page.wrapper.find(selector)
                        .first().html(values.upload).removeAttr('style');
                },
                __('Upload File'),
                __('Submit')
            );
        };
        list.page.wrapper.on('click', '.first_upload_btn', function() {
            // On button click event
            list._build_upload_prompt('.first_upload_value');
        });
        list.page.wrapper.on('click', '.second_upload_btn', function() {
            // On button click event
            list._build_upload_prompt('.second_upload_btn');
        });
    }
};

Best regards..

Hello, thank you to help!
It is interesting that I can override the JS method in such a way.
After some testing, it seems that I cannot override method like this. It has no effect. I'm sure the additions are in place as I can see it in web browser Console, the line will be called, but it just won't have any effect.
No errors in web browser Debug too.
Any idea?

@charleslcso It seems that the method gets called before it is overridden..
How about doing like..
frappe.listview_settings['Contact'] = {
    onload: function(list) {
        let head = list.page.wrapper.find('header.list-row-head');
        if (!head.length) {
            console.log('Unable to find the table head.');
            return;
        }
        head.first().before($(`

                    <button type="button" class="first_upload_btn btn btn-success btn-sm">
                        ${__('Upload')}
                    </button>

                    <button type="button" class="second_upload_btn btn btn-success btn-sm">
                        ${__('Upload')}
                    </button>

        `));
        // Buttons click event delegation
        list._build_upload_prompt = function(selector) {
            frappe.prompt(
                [
                    {
                        name: 'upload',
                        label: __('Upload'),
                        fieldtype: 'Attach'
                    }
                ],
                function(values) {
                    // Handle the upload file like: values.upload
                    list.page.wrapper.find(selector)
                        .first().html(values.upload).removeAttr('style');
                },
                __('Upload File'),
                __('Submit')
            );
        };
        list.page.wrapper.on('click', '.first_upload_btn', function() {
            // On button click event
            list._build_upload_prompt('.first_upload_value');
        });
        list.page.wrapper.on('click', '.second_upload_btn', function() {
            // On button click event
            list._build_upload_prompt('.second_upload_btn');
        });
    }
};

Nice, this approach works. No need to override JS. It will be good if I can override JS too! But that should be another topic.
My final design should be:

show the full file link as shown previously
click the button and it brings up the upload dialog, instead of bringing up the Attach dialog.

Much much appreciate your help.

@charleslcso I'm glad that I was able to help..
And regarding the fieldname property, I'm sorry that I didn't realize my mistake and caused you some problems..
The good thing is that you found tge mistake and fixed it..
Best regards..


lampcontrol nil exception after a few seconds

After a few seconds of starting the game it crashes. Probably initialization of LTN.

Please read #39, this is known and will be fixed shortly.


Refactor FFI to be effectful

Started but needs continuation and more thought... might be that the entire API needs to be run via Effects since really there is mutation happening on the JS side, even if just local state within the classes

Deciding not to do this for now... creation genuinely needs to be in an Effect, as does sample/listen.... but everything else should be referentially transparent from that point in... I think!
@clinuxrulz what do you think?

Closing for now... on one foot, imagining that the compiler does try to optimise - I think something like the following pseudocode would still be okay:
c1 = new Cell()
c2 = c1.map(foo);
c3 = c1.map(foo); // return c2 instead of a new instantiation

Reactive Banana on hackage is probably a good guide on where to use effects and where to be pure. Seek it out for inspiration.


Allow serialization and deserialization for auto tabular predictor

Issue #, if available:
Description of changes:
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Thanks! I've left some comments inline.
Tests are failing, see https://github.com/awslabs/gluon-ts/runs/2245357197#step:5:17 there seem to be a problem with some autogluon import, maybe the version we require needs to be bumped?
Yes, we need to bump the dependency for autogluon.tabular to 0.1.0 as the API has changed. We no longer has a task in autogluon.tabular, TabularPredictor is used directly instead.

Also, it would be nice to update the tests we have to include serialization/deserialization, see test/nursery/test_autogluon_tabular.py

The test failures on Linux are unrelated to the changes in this PR: there is (at least) one flaky test that should be (for now) marked as such: https://github.com/awslabs/gluon-ts/blob/6ac4cc6b2beef045453b58ab10876e96fbd9f502/test/torch/modules/test_torch_distribution_inference.py#L273
You can mark it as "flaky" by decorating it with e.g.
@pytest.mark.flaky(max_runs=5, min_passes=1)

However, it seems that some of the related tests are also failing on Windows


Add support for package.json engines key

Feature request:
Terminals (used in tasks and the interactive Terminal tab in the Panel) should try to load/use the version of node/npm specified in the packages.json "engines" key
Possibly utilizing nvm if it is installed/available on the system is the most straightforward approach.

The terminal doesn't know anything about node, what you're after would be best to happen as part of an extension to your shell or changing your start up scripts.


Add step prop

Thanks for your great package!
As many other sliders it would be nice to have a step prop (for a discrete slider)

Ok, I will add this feature later.You can follow this lib.

Thanks 👍

@jared-94  Hi, I have added step feature, See example, you just use code:
<Slider
    progress={progress}
    minimumValue={min}
    maximumValue={max}
    step={10}
/>

Regrettably, I was busy, just simply did a test, I hope you can help me test it out.
If you have any questions, welcome to call me.
Finally, if you think it's good, please give me a Star, Thank you!

Thanks It works fine !
However, it seems that onSlidingComplete doesn't return the correct value...
Any idea?

@jared-94  This is a bug, I will deal with it asap

@jared-94 Hi, I fixed it!
You can try it!


Rename AzDO extension/task to align with new repo name

Rename extension from devcontainer-build-run to ci (full name will be devcontainers.ci
Rename task from DevContainerBuildRun to DevcontainersCi
Fix up clean-tags script with image name changes in #130
Minor docs updates

/test

/test

/test-force-approve


Update to v3.7.28

update supported erlang versions and minor recipe cleanups
add myself as maintainer
closes #18, closes #19

Checklist

[x] Used a personal fork of the feedstock to propose changes
[x] Reset the build number to 0 (if the version changed)
[ ] Re-rendered with the latest conda-smithy (Use the phrase @conda-forge-admin, please rerender in a comment in this PR for automated rerendering)
[x] Ensured the license file is being packaged.

Hi! This is the friendly automated conda-forge-linting service.
I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.
I do have some suggestions for making it better though...
For recipe:

License is not an SPDX identifier (or a custom LicenseRef) nor an SPDX license expression.

Documentation on acceptable licenses can be found here.

@conda-forge-admin, please rerender

Hi! This is the friendly automated conda-forge-linting service.
I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

@conda-forge/rabbitmq-server this is ready for review/merging


Point to latest webservice build.

Change my semaphore file while you're at it

@coverbeck updating semaphore is really not necessary until we use it more broadly across the team

Takes very little time to update the semaphore.yml so that I don't get any unexpected surprises and have to update it myself after it fails

nevertheless, I'd like to consider updating these as a favour that cannot block PRs
sorry @garyluu

@denis-yuen Saw your comment after I'd started the change to semaphore.

Ok, I will make my own commits alongside these when I see it since it actually is necessary for my work.


(feature) (types) Improve brew tap inspector

Related to #14 having now been implemented in types/brew-tap.sh
The inspect action on the brew-tap type should:

Check if the tap comes from anywhere other than GitHub — the type doesn't currently support installing these
Check if the tap is pinned, and return the correct assertion to replicate this

Re #41 — pinning a tap is no longer supported by Homebrew so the type and its inspector do not need to do this. It would be nice to figure out the first part, though (and in turn, figure out how to make the type support non-GitHub taps).


Remove big query support

Remove the big query session property, and all related configs

Looks good.
As another PR, can you add a new section to the Administration docs covering the new query memory system, and maybe update the https://prestodb.io/docs/current/installation/deployment.html  section to configure the new memory options (and not task memory)?  Also, are we ready to remove task memory limit code?

Yep, I'll definitely add docs for that. We're not quite ready to remove the task memory limit code, but we're getting close


replacing the dead link in GitHub workflow

Description
This PR fixes #403
Notes for Reviewers
Signed commits

[x] Yes, I signed my commits.

Thank you @AdityaAgarwaal

Welcome @Chadha93


proxy

I would like to ask how to use the proxy? I know there is a [proxy] setting in the amule.conf file, but after I set it up, the program cannot connect to the kad server. My proxy uses socks5. I don't know if there is something wrong with my configuration?
[Proxy]
ProxyEnableProxy=1
ProxyType=2
ProxyName=<IP_ADDRESS>
ProxyPort=1080
ProxyEnablePassword=
ProxyUser=
ProxyPassword=

I don't know much about the Proxy in aMule. You should read the official documentation => http://wiki.amule.org/wiki/Usage_Preferences#Proxy
In my experience the Proxys don't work well with UDP traffic and they can leak information like DNS requests, IPfilter download... To use a VPN is easier to configure and more secure.


Why is .addQueryParam("query", "0") in the readme?

Hi, in the project I'm working on, somebody copied the usage of this library including the .addQueryParam("query", "0") statement which now broke because an API endpoint checked for allowed url parameters - and query=0 isn't allowed - so it broke.
Any reason this is in the 'Usage' section of the readme (where blindly people copy-paste from)?

@z3ntu .addQueryParam("query", "0") function in readme file is just sample which shows you that you can add query param to all your requests like apiKey and other default things. So you better to remove it if you don't need it.


fix flaky file discovery tests

Fixes: https://github.com/prometheus/prometheus/issues/3419
fsnotify send invalid updates causing the fd service to send empty group[] struct before the test files are written to disk
Now using an extra sync channel to ignore the fd updates until the test files are written to disk.

cc @grobie

@grobie I think this solves it once and for all.


TS0505A same device HG06104A

Checklist

[X] I have filled out the template to the best of my ability.
[X] This only contains 1 feature request (if you have multiple feature requests, open one feature request for each feature request).
[X] This issue is not a duplicate feature request of previous feature requests.

Is your feature request related to a problem? Please describe.
I Switched from zigbee2mqtt to ZHA because I had some Problems with the Conbee 2 Stick. In zigbee2mqtt i had two Devices which was auto discovered by powercalc because they was marked as Model HG06104A Livarno Lux LED Strip.
Now after I switch to ZHA the same device was marked as TS0505A von _TZ3000_riwp3k79 which not auto discovered because it cant find it the libary.
Describe the solution you'd like
I searched the Hardware in Internet and I think it's the same device.
Please can you Support this as the same device, list under Lidl or tuya so it can Auto discovering.
Here you can Check this: https://zigbee.blakadder.com/Lidl_HG06104A.html
Here it Shows the device Listed by zigbee2mqtt: https://www.zigbee2mqtt.io/devices/HG06104A.html
Describe alternatives you've considered
I know I can add this manual but I Support this Integration and hope other people also use this nice Integration.
Additional context
Screenshot from my added device in ZHA

Screenshot from the Website that showing it's the same device

Fixed with #1748.
Will be in next version.


Allow service reloading

There is no easy way to use
systemctl reload <service>
for a specified service. Puppet will always restart it.
I suggest adding some parameter like $use_reload to systemd::unit_file that will set the restart argument of service.

That seems like a reasonable idea. Could you provide a PR for this please?

That seems like a reasonable idea. Could you provide a PR for this please?

Hi,
here it is https://github.com/camptocamp/puppet-systemd/pull/175

Hi,
here it is https://github.com/camptocamp/puppet-systemd/pull/175


Timeline initializer UI:  simplify a logical expression

The @tl_options in the inner clause had no effect on the end result.
@miq-bot add_label ui, refactoring
@miq-bot assign martinpovolny

Looks good.


Fix update of compendium entries with OggDude Import in Foundry v10

This PR fixes update of compendium entries when reimporting changes from OggDude over already existing compendia.
After installing StarWarsFFG into a new Foundry v10 install I found out that updating the stock OggDude data with my texts input via the OggDude Data Editor no longer worked in Foundry v10 although the console did not report any errors. In order to fix this I made the following changes:

Detect and log failed updates
Log existing compendium entry to make it easier to spot problems when debugging
Fix the update issue by switching pack caching from duplicate to deepClone usage

In case you only want some of these changes merged I provided them in separate commits.
My first approach to fixing the issue was to switch back from the non-existing id property to the existing _id property here:
https://github.com/StarWarsFoundryVTT/StarWarsFFG/blob/692537d45a765f961117aa9ba25b48c83f8b5f1d/modules/importer/import-helpers.js#L2245
While this worked as well, it did not feel right, so I looked for a way to keep using the public API. It turned out that here
https://github.com/StarWarsFoundryVTT/StarWarsFFG/blob/692537d45a765f961117aa9ba25b48c83f8b5f1d/modules/importer/import-helpers.js#L174-L177
we actually got functioning instances from the API, in my specific case instances of ItemFFG. As those were real instances of the class, one could get the entry id with the id getter defined on them. After running duplicate() on the entry, only the properties remained as a bare object. Once I changed this part to use deepClone() the copies of the entries were usable as ItemFFG instances again, thus also allowing me to use the id getter. Interestingly enough the API documentation says that deepClone() does not support advanced object types, but I'll gladly accept that it does.
As a side effect of now having ItemFFG instances instead of plain objects, the console also started to warn me about other locations in the code that still use the pre-v10 Data Model access and should be updated (from what I've read there will be backwards-compatible support until v12, starting v13 those warnings will become errors).
So I think while this fix is somewhat more tinkering with the insides of the system, it should be a more stable way going forward in Foundry v10 support. If you want to play it safe, we could still fix it by switching from entry.id to entry._id.

As a little addition to the above, I was just about to investigate another problem with OggDude Import updates that created new copies of Specializations on subsequent imports instead of updating the previous ones. Turns out that this PR also fixes this other issue as the root cause is the same. If you want to fix it without using deepClone() you would need to change from id to _id here:
https://github.com/StarWarsFoundryVTT/StarWarsFFG/blob/692537d45a765f961117aa9ba25b48c83f8b5f1d/modules/importer/import-helpers.js#L2223
so the old specialization can actually be deleted.

Nice stuff... the use of ._id (raw data) and .id (class getter) all across the system is pretty inconsistent, as it dates back to when the Foundry API itself was very inconsistent pre-v7/8.
I am also happy to accept that deepClone gives us access to the ItemFFG Document. 😅


No such link

There is no 'Additional security verification' link/button! Why does MS always refer to non-existing features or options??

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 63bc4d65-6d76-5bb1-49b8-0415c76667f8
Version Independent ID: bafb894e-abc2-b068-ee53-38c5e20d0740
Content: Set up your two-factor verification methods overview - Azure Active Directory
Content Source: articles/active-directory/user-help/multi-factor-authentication-end-user-first-time.md
Service: active-directory
Sub-service: user-help
GitHub Login: @eross-msft
Microsoft Alias: lizross

@paddotk  Thank you for the feedback. We will review and update accordingly.

@paddotk
The "Additional Security Verification" is NOT a link or button. It is the page that comes after you select NEXT on the prompt that you have to setup More Information.

@paddotk  We will be closing this thread now. Let us know if you need further assistance by re-opening the thread.

@neeleshray-msft Ok, I guess that that title is a bit confusing then. The issue for me was that after switching phones, I no longer had access to the Microsoft Authenticator app that was needed for the MFA, and that there was no way for me to set up a new connection in the app on my new phone. I ended up on that MS help page but it got me nowhere.
The issue was resolved by my organisation temporarily turning off MFA, so that I could reset my account. Pretty rigorous method but necessary, unfortunately.


Output level really low for line use

Since v1.2b2

Thanks for opening this issue. Yes this has been discussed on Discord as well. I'll start with posting a couple test builds with different settings for people to try out as the amount of reduction of output volume for different headphone/earbuds/IEMs really just needs to be a compromise setting determined experimentally.

@gandaja not sure if you are in the discord servers @beta-testers channel so here is a test build with 1bit extra (louder) output to please test and report back on:
picoTracker-4bit-offset.zip
Please UNZIP first to get the uf2 file to install to your picoTracker.

Thanks. Still haven't tried the firmware you provided, I wanted to work v1.2r2 for a few days with my headphones.
Levels are ok, but I notice a loud "pop" whenever a sample starts or finishes playing.

Sorry, I've seen that a similar problem has been described in issue #67.
Will upload a zip soon.

Fixed by #113

I'll close this now as the remaining followup work to allow for different levels is tracked in #116

I'll close this now as followup work for this is tracked in #117


Automated cherry pick of #6967

Cherry pick of #6967 on release-5.29.
/cc  @saturninoabril

Will try to auto merge this PR once all tests and checks are passing. This might take up to an hour.

Trying to auto merge this PR.

Pull Request successfully merged
SHA: 2fc7ffb4e2faae81e7e8f6435e56819a80f3faba


scripts, buidl: more options + support for stdin

Removed the '--json' flag, JSON data is now provided either as a positional argument or via stdin (pipe).

I will also be adding the '--verbose' flag here. Without this flag, the output should only display the paths of the built artifacts.

A Nix formatter would be nice to run against /tmp/data.nix for display purposes, but none of the available nix fmt providers format new lines into the configuration.

Just a quick explanation about the reverts: I had to test the original remote fallback again because I discovered that I also had issues due to the old version being cached in my nix-store. It was indeed broken, but the third try fixed it without any compromises.
I think this is ready to merge after a second pair of eyes.

LGTM beyond the other comment above.

Did some simple manual tests to conclude this pull request, and everything seems to work.
Made sure that:

The positional argument's position does not matter
Extra spaces in the JSON data are allowed
Piping the data also works with the remote command
builtins.fromJSON displays and handles configuration errors


No available methods to filter depth stream

None of the filters from realsense (library) can be applied without modifying the ros-wrapper.  If it is going to be supported by the wrapper an approximate date of release would be great.

Hello @poripsa, we are planning to add the Depth filters in the next releases.

Hi @icarpis I will be trying to do it parallely with librealsense 2.10.0

Thank you @poripsa, that's would be great.
As a reference you can take a look at the implementation of post-processing example.

@icarpis Any update on adding post-processing options to ROS wrapper? Or any guide on how and where to implement them?

@akifh quick way for most filters base_realsense_node. I have skipped decimation filter though, since it would require more changes because of resolution change.

declare filters in header.

        // Decalre filters
        std::shared_ptr<rs2::decimation_filter> decimation_filter;
        std::shared_ptr<rs2::spatial_filter> spatial_filter; // edge-preserving spatial smoothing
        std::shared_ptr<rs2::temporal_filter> temporal_filter; // reduces temporal noise
        std::shared_ptr<rs2::disparity_transform> depth_to_disparity;
        std::shared_ptr<rs2::disparity_transform> disparity_to_depth;

initialize in constructor

    decimation_filter = std::make_shared<rs2::decimation_filter>();
    temporal_filter = std::make_shared<rs2::temporal_filter>();
    spatial_filter = std::make_shared<rs2::spatial_filter>();
    depth_to_disparity = std::make_shared<rs2::disparity_transform>(true);
    disparity_to_depth = std::make_shared<rs2::disparity_transform>(false);

apply filters in BaseRealSenseNode::setupStreams() around line 563

if (stream_type == RS2_STREAM_DEPTH)
{
  f = depth_to_disparity->process(f);
//                            f = decimation_filter->process(f);
  f = spatial_filter->process(f);
  f = temporal_filter->process(f);
  f = disparity_to_depth->process(f);
}

@piotrpolatowski  Thank you for your code :)
But when i insert the lines of code you posted I get errors. But this is probably because I just inserted them in the wrong order. I usually do not program in cpp.
Could you just name the lines in which I have to insert the code you posted?
Would appreciate it.

In case anyone needs a quick fix: I've added the filter code to a forked repo of the realsense library and currently have three of the four filters added (temporal, spatial, and hole filling filter). Currently working on adding in the decimation filter.

[Please Ignore - RealSense system comment]


cargo test failed

Version
0.0.3
cargo tree | grep monoio
monoio v0.0.3 (/home/sebo/Source/github/monoio/monoio) ├── monoio-macros v0.0.2 (proc-macro) (/home/sebo/Source/github/monoio/monoio-macros) monoio-compat v0.0.4 (/home/sebo/Source/github/monoio/monoio-compat) ├── monoio v0.0.3 (/home/sebo/Source/github/monoio/monoio) (*) └── monoio v0.0.3 (/home/sebo/Source/github/monoio/monoio) (*) monoio-examples v0.0.0 (/home/sebo/Source/github/monoio/examples) ├── monoio v0.0.3 (/home/sebo/Source/github/monoio/monoio) (*) ├── monoio-compat v0.0.4 (/home/sebo/Source/github/monoio/monoio-compat) (*)
Platform
The output of uname -a and ulimit -l.
➜  monoio git:(master) uname -a                                                                    [10/12/21 | 1:03:18] Linux sebo-nuc10i7fnh 5.10.79-1-MANJARO #1 SMP PREEMPT Fri Nov 12 20:26:09 UTC 2021 x86_64 GNU/Linux ➜  monoio git:(master) ulimit -l                                                                   [10/12/21 | 1:03:20] 64
Description
cargo test failed
`running 1 test
test tcp::tests::test_rw ... FAILED
failures:
---- tcp::tests::test_rw stdout ----
thread 'tcp::tests::test_rw' panicked at 'Failed building the Runtime: Os { code: 12, kind: OutOfMemory, message: "Cannot allocate memory" }', monoio-compat/src/tcp.rs:143:38
note: run with RUST_BACKTRACE=1 environment variable to display a backtrace
failures:
tcp::tests::test_rw
test result: FAILED. 0 passed; 1 failed; 0 ignored; 0 measured; 0 filtered out; finished in 0.00s`

You can check the memlock settings: https://github.com/bytedance/monoio/blob/master/docs/en/memlock.md

@ihciah It works, thanks !


Switch from cargo-make to Make

AFAIK we do not use any cargo-make relatec functionality therefore we should switch to normal Makefiles

Resolved via #84


How to Refactor Fetching of Motion JPEG

get rid of chrome webrequest
https://stackoverflow.com/questions/44081667/how-to-display-motion-jpeg-binary-data-stream-with-angular-ionic-js

mjpeg fetching is not performant enough in browser


Add support for Qt6

I'm a bit stuck at this point

I'm a bit stuck at this point

What problem?

I'm a bit stuck at this point

What problem?

Missing libicui18n.so dependency on Android, missing pcr2 on iOS (I didn't find any precompiled library file like for Qt5), and libfontconfig which isn't found on Archlinux (but is a dependency).

I'm a bit stuck at this point

What problem?

Missing libicui18n.so dependency on Android, missing pcr2 on iOS (I didn't find any precompiled library file like for Qt5), and libfontconfig which isn't found on Archlinux (but is a dependency).

we can disable android/ios first for qt6

and add_deps("fontconfig") for linux

Well, that's the problem, it's already there:
https://github.com/xmake-io/xmake-repo/pull/1081/files#diff-7aa4b14e36d1159e91dde5eeb2ad987d929eb282d012174f264caa92f50efb1aR10

and add_deps("fontconfig") for linux

Well, that's the problem, it's already there: https://github.com/xmake-io/xmake-repo/pull/1081/files#diff-7aa4b14e36d1159e91dde5eeb2ad987d929eb282d012174f264caa92f50efb1aR10

maybe it only support ubuntu.

I think you should split this patch.
patch 1: update aqt
patch 2: improve qt5
patch 3: support qt6

I think you're right, I'll do that.

Superseded by #2281


typo fix get start zh doc

Proposed changes
Issue Number: close #xxx

Further comments
If this is a relatively large or complex change, kick off the discussion at<EMAIL_ADDRESS>by explaining why you chose the solution you did and what alternatives you considered, etc...

run buildall


Adding FFT in X86_64

Also we should consider the problem described in #558. I know it's a bit harder and very verbose to do in asm, but maybe we can come up with a good solution

This looks good now. Maybe @Gustorn wants to take a look as well? If not we can merge this.


doesn't pass test

Challenge use-css-selectors-to-style-elements has an issue.
User Agent is: Mozilla/5.0 (Windows NT 5.1; rv:50.0) Gecko/20100101 Firefox/50.0.
Please describe how to reproduce this issue, and include links to screenshots if possible.

CatPhotoApp

Click here to view more cat photos.

Things cats love:

cat nip

laser pointers

lasagna

Top 3 things cats hate:

flea treatment

thunder

other cats

  <form action="/submit-cat-photo">
    <input type="radio" name="indoor-outdoor" checked> Indoor
    <input type="radio" name="indoor-outdoor"> Outdoor

    <input type="checkbox" name="personality" checked> Loving
    <input type="checkbox" name="personality"> Lazy
    <input type="checkbox" name="personality"> Energetic

    <input type="text" placeholder="cat photo URL" required>
    <button type="submit">Submit</button>
  </form>

This is a browser specific issue.

Thank you for reporting the issue.
Here are a couple suggestions:
1.Reload the page and run the tests again. A script may have crashed, preventing the tests from running.
2.Try the challenge in incognito mode. A plugin might be interfering with the tests.
3.Try the challenge in a different browser. There may be an issue with your version.
Please try these things in order and let us know what did and didn't work. I can't reproduce your issue right now, so any extra information will be helpful in finding out what's causing your issue.

Hi @dawpes! Thank you for reporting this issue.
This is an issue with CSS tests in Firefox. The main issue is https://github.com/freeCodeCamp/freeCodeCamp/issues/10749 This is a big issue that affects a lot of people, so we are looking to resolve it soon. For now, you'll have to switch to Chrome for any challenges with CSS tests in the beta.
Thanks you for trying out the beta, and happy coding!

I am experiencing this issue as well. Is there a fix being worked on?
Here is the info....
Challenge use-css-selectors-to-style-elements has an issue.
User Agent is: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:52.0) Gecko/20100101 Firefox/52.0.

@heatherdhaz Hi! As mentioned, we're working on this in #10749


Suggestions from JSHint

This is a fantastic little utility. It seems to be just what I need. Thank you.
I took the precaution of running this through JSLint and JSHint, and came up with the following code:
window.onload = function() {
    "use strict";
    var elements = document.getElementsByTagName("*");
    var i;

    function fragment(el, url) {
        var localTest = /^(?:file):/;
        var xmlhttp = new XMLHttpRequest();
        var status = 0;

        xmlhttp.onreadystatechange = function() {
            /* if we are on a local protocol, and we have response
             * text, we'll assume things were sucessful */
            if (xmlhttp.readyState === 4) {
                status = xmlhttp.status;
            }
            if (localTest.test(location.href) && xmlhttp.responseText) {
                status = 200;
            }
            if (xmlhttp.readyState === 4 && status === 200) {
                el.outerHTML = xmlhttp.responseText;
            }
        };

        try {
            xmlhttp.open("GET", url, true);
            xmlhttp.send();
        } catch (err) {
            /* todo catch error */
        }
    }

    for (i in elements) {
        if (elements[i].hasAttribute && elements[i].hasAttribute("data-include")) {
            fragment(elements[i], elements[i].getAttribute("data-include"));
        }
    }
};

Could you, please, submit it as a pull request?


Standard_E20s_v3 shows as available with constrained core available in Esv3-series section

Standard_E20s_v3 doesn't have any option when provisioning to constrain

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 58fe6a40-0b95-f1ed-db11-7a49d4a97ecf
Version Independent ID: 54269236-da55-a1cd-01df-79a0458d9ac9
Content: Azure VM sizes for Windows - Memory
Content Source: articles/virtual-machines/windows/sizes-memory.md
Service: virtual-machines-windows
GitHub Login: @jonbeck7
Microsoft Alias: jonbeck

@jonbeck In this doc, Standard_E20s_v3 shows as Constrained core sizes available but it is not mentioned in this doc for Constrained vCPU capable VM sizes. Can you please confirm that Standard_E20s_v3 is available with Constrained core size option? Thanks :)

I was trying West Europe, but also have tried other regions as well so looks global
--
Paul Tozer
Head of Cloud Services
T: 01827 265000
Quiss Technology plc
Claymore,
Tame Valley Industrial Estate,
Tamworth B77 5DQ.
http://www.quiss.co.uk
This email and any attachments to it are confidential and intended solely for the person to whom they are addressed. They may contain legally privileged information.
If you have received this in error, please delete this message and let us know by emailing<EMAIL_ADDRESS>or telephoning us on +44 (0)1827 265000.
The messaging system from which this e-mail was sent is checked regularly for viruses. However no liability is accepted for any viruses which may be transmitted in or with this e-mail.
Quiss Technology plc may monitor email traffic data and also the content of email for the purposes of security and staff training.
Quiss Technology plc is registered in England and Wales with company number 2248732. Registered office: Claymore, Tame Valley Industrial Estate, Tamworth B77 5DQ.
--

From: Karishma Tiwari - MSFT<EMAIL_ADDRESS>Sent: 30 November 2018 18:29
To: MicrosoftDocs/azure-docs
Cc: Paul Tozer; Mention
Subject: Re: [MicrosoftDocs/azure-docs] Standard_E20s_v3 shows as available with constrained core available in Esv3-series section (#19760)
@PaulTozerhttps://github.com/PaulTozer Can you please provide some details - which region are you trying to deploy? Are you trying to do it via Azure portal?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHubhttps://github.com/MicrosoftDocs/azure-docs/issues/19760#issuecomment-443295505, or mute the threadhttps://github.com/notifications/unsubscribe-auth/ArYEJEz0-TjaQZjxuXPJVduvYt7j2qGcks5u0XkDgaJpZM4Y7YpH.

@PaulTozer Can you please share the steps you are taking to deploy this? Is it via Azure portal. Are you able to see E20sv3 in Azure portal like in the screenshot below?

@PaulTozer Any update? Please share if you are seeing the above in the Azure portal. Thanks.

The below screenshot is from the portal. You can see the constrained for other E models, but E20 doesn’t show
<EMAIL_ADDRESS>--
Paul Tozer
Head of Cloud Services
T: 01827 265000
Quiss Technology plc
Claymore,
Tame Valley Industrial Estate,
Tamworth B77 5DQ.
http://www.quiss.co.uk
This email and any attachments to it are confidential and intended solely for the person to whom they are addressed. They may contain legally privileged information.
If you have received this in error, please delete this message and let us know by emailing<EMAIL_ADDRESS>or telephoning us on +44 (0)1827 265000.
The messaging system from which this e-mail was sent is checked regularly for viruses. However no liability is accepted for any viruses which may be transmitted in or with this e-mail.
Quiss Technology plc may monitor email traffic data and also the content of email for the purposes of security and staff training.
Quiss Technology plc is registered in England and Wales with company number 2248732. Registered office: Claymore, Tame Valley Industrial Estate, Tamworth B77 5DQ.
--
From: Karishma Tiwari - MSFT<EMAIL_ADDRESS>Sent: 03 December 2018 01:49
To: MicrosoftDocs/azure-docs<EMAIL_ADDRESS>Cc: Paul Tozer<EMAIL_ADDRESS>Mention<EMAIL_ADDRESS>Subject: Re: [MicrosoftDocs/azure-docs] Standard_E20s_v3 shows as available with constrained core available in Esv3-series section (#19760)
@PaulTozerhttps://github.com/PaulTozer Any update? Please share if you are seeing the above in the Azure portal. Thanks.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHubhttps://github.com/MicrosoftDocs/azure-docs/issues/19760#issuecomment-443565040, or mute the threadhttps://github.com/notifications/unsubscribe-auth/ArYEJJHxtqtjui_CEOvJ3yS4-NaawZQ5ks5u1IMggaJpZM4Y7YpH.

@Karishma-Tiwari-MSFT Pasted below

@cynthn @zr-msft It looks like the E20s_v3 size does not have a constrained option available on the portal while the document says that it is available in the constrained option. Can either of you please confirm and update the doc? Thanks :)

@Karishma-Tiwari-MSFT I've sent mail to the E-series owner to see what the story is for constrained vCPUs for this size :)

@cynthn Thank you for the quick resolution!! :)
@PaulTozer I apologize for the inconvenience. Thanks for bringing this to our attention. We will now close this issue. If there are further questions regarding this matter, please reopen it and we will gladly continue the discussion.


This software cannot work,

in src/index.js
 connection.onmessage(function (data) {
    store.dispatch(createMessageAction(endpoint, data))
  })

connection does not have the function onmessage
should be someting like
 connection.socket.onmessage(function (data) {
    store.dispatch(createMessageAction(endpoint, data))
 })

Yes that doesn't even at all, it needs to be this:
connection.socket.onmessage = function (data) {
        store.dispatch(createMessageAction(endpoint, data))
      }

      connection.socket.onopen = function () {
        store.dispatch(createConnectionAction(endpoint))
      }

      connection.socket.onclose = function () {
        store.dispatch(createDisonnectionAction(endpoint))
      }

      connection.socket.onerror = function (error) {
        store.dispatch(createErrorAction(endpoint, error))
      }

Also, I don't understand these claims:

creating and opening the socket
retrying the connection when lost, and exponentially backing off
batching writes when offline, and sending when available

Was this a TODO? because the released version does not retry connection or do offline batching!


[AutoPR datafactory/resource-manager] support teradata dataset in adf

Created to sync https://github.com/Azure/azure-rest-api-specs/pull/6568

This PR has been merged into https://github.com/Azure/azure-sdk-for-go/pull/5269


Dark and Light Mode Implemented on the ReactPlay Website

First thing, PLEASE READ THIS: ReactPlay Code Review Checklist

Description
A dark and Light mode implemented on the website, the toggle button can be found at a strategic place at the navbar just beside the ReactPlay logo.
All the user needs to do is toggle the button to switch to the preferred mode.
The react-switch library was used for the toggle component.
Fixes #424
Feature
Please delete options that are not relevant.

[ x ] New feature (non-breaking change which adds functionality)

How Has This Been Tested?
Yes, it has been tested on Chrome and Safari browsers respectively.
It has been tested across all major screen sizes and viewports.
Checklist:

[x] I have performed a self-review of my own code
[x] I have commented my code, particularly in hard-to-understand areas
[x] I have made corresponding changes to the documentation
[x] My changes generate no new warnings
[x] I have added tests that prove my fix is effective or that my feature works
[ ] New and existing unit tests pass locally with my changes
[x] Any dependent changes have been merged and published in downstream modules

Hello @EOEboh I feel the dark theme is not well optimized with the current design language. Also the switch a way off than standard practice. And its not persisting
As a traditional way of working on the aesthetic/style/structure changes, I would suggest preparing a mock and reviewing it with the community before incorporation. You can do it over discord. If the action has already been performed, just point me to the appropriate mopckup.

Hey Koustov, so please what are you saying in summary.
I can't quite understand what you mean sir

Hi @EOEboh, just as @koustov mentioned, the implementation can be a bit more optimized. And also, instead of a toggle, I think that an icon button (like the ideas button) to the right of the navbar is more suitable. The toggle just seems a bit odd, that's just my opinion, let's see what others think about it too.

Hi @EOEboh, just as @koustov mentioned, the implementation can be a bit more optimized.
And also, instead of a toggle, I think that an icon button (like the ideas button) to the right of the navbar is more suitable. The toggle just seems a bit odd, that's just my opinion, let's see what others think about it too.

Hello @EOEboh I feel the dark theme is not well optimized with the current design language. Also the switch a way off than standard practice. And its not persisting
As a traditional way of working on the aesthetic/style/structure changes, I would suggest preparing a mock and reviewing it with the community before incorporation. You can do it over discord. If the action has already been performed, just point me to the appropriate mopckup.

Hey Koustov, so please what are you saying in summary.
I can't quite understand what you mean sir

I think what @koustov is trying to convey is that, try to follow the code structure and best practices of ReactPlay. (like use of variables, functions, commenting, etc.).
Also that before coding out the feature, first design a mockup maybe in Figma or any other software you prefer and then share it with the community and ask for feedback. In that way, if there's any change, you can do it in the mockup and can implement the final mockup with code. If you have any doubts please let us know.

Hello @EOEboh , let me put the items in a bulleted way in this comments for better understanding

When we implement any theme we need to see every element goes well together with it from a contrast perspective. What I felt is, the dark theme here is not adjusted fro that front
e.g.:

The switch here sits at a very odd place, without any specific visual indicator to represent what the switch does

The tech-stack page is not honoring theme selection. Its always dark

The play list page also having the same issue

The expectation would be, that when I switch a theme it should persist for me. Like if I refresh, it should retain my selection. This is not happening

The Most Important item: When we make any major adjustment to UI, process-wise we should create a mockup first . The get this mockup reviewed with the community. Once its approved then we go for implementation/merge. We have done similar process in past (for example we did mock review for Twitter mention implementation)

@EOEboh, I think @koustov has put everything that's needed in an understandable way. Do consider those points when implementing it. So if you need any help in creating this functionality, do let us know.

Is this issue still open?
Is there an existing react play design, so I can easily implement the dark mode features.

It's not in plan for now.

It's not in plan for now.

Alright


Test-DbaSpn, accomodate get-dbaadobject

Fixes #936
Additional PRs in the next few days to make every spn cmdlet use get-dbaadobject
While rewriting it, I used the new messaging system and spotted a few inconsintencies between the documented use of parameters and their mandatory usage.
Also, can the original authors/testers vouch for the $domain parameter ? I found it to be unused and, generally, less than well documented in the way it's used down the code. Maybe it should disappear.

here too, too fast. if $domain isn't needed, it must be cut out.

You can do a combo PR if you like

mwhahaha, ok, I need to submit a bunch for the other cmdlets, too.


SP5: Random line pattern should not return None

presently it does, causing some lines not to be drawn

just kidding! random patterns don't exist. This rendering issue is caused by a paint application bug...


[Event Request] Codeunit 90 add sender on event OnPostItemChargeOnAfterPostItemJnlLine

Hi,
We need to add the sender on event OnPostItemChargeOnAfterPostItemJnlLine to be able to change the way to posting specific purchase invoice item charge line :
    [IntegrationEvent(true, false)]
    local procedure OnPostItemChargeOnAfterPostItemJnlLine(PurchaseHeader: Record "Purchase Header"; PurchaseLine: Record "Purchase Line"; ItemChargeAssignmentPurch: Record "Item Charge Assignment (Purch)")
    begin
    end;

Could you change the property to this event ?

Thanks for reporting this. We agree, and we’ll publish a fix asap, either in an update for the current version or in the next major release. Please do not reply to this, as we do not monitor closed issues. If you have follow-up questions or requests, please create a new issue where you reference this one.
Build ID: 42200.


no video formats found bbc iplayer

Checklist

[ x ] I'm reporting a broken site support issue
[ ] I've verified that I'm running youtube-dl version 2020.07.28
[ ] I've checked that all provided URLs are alive and playable in a browser
[ ] I've checked that all URLs and arguments with special characters are properly quoted or escaped
[ ] I've searched the bugtracker for similar bug reports including closed ones
[ ] I've read bugs section in FAQ

Verbose log

PASTE VERBOSE LOG HERE

/home/steve# youtube-dl --verbose https://www.bbc.co.uk/iplayer/episode/m000m2hj/the-notebook
[debug] System config: []
[debug] User config: []
[debug] Custom config: []
[debug] Command-line args: [u'--verbose', u'https://www.bbc.co.uk/iplayer/episode/m000m2hj/the-notebook']
[debug] Encodings: locale UTF-8, fs UTF-8, out UTF-8, pref UTF-8
[debug] youtube-dl version 2020.07.28
[debug] Python version 2.7.17 (CPython) - Linux-4.15.0-108-generic-x86_64-with-Ubuntu-18.04-bionic
[debug] exe versions: avconv 3.4.6, avprobe 3.4.6, ffmpeg 3.4.6, ffprobe 3.4.6, phantomjs 1000, rtmpdump 2.4
[debug] Proxy map: {}
[bbc.co.uk] m000m2hj: Downloading video page
[bbc.co.uk] m000m2hj: Downloading playlist JSON
[bbc.co.uk] m000m2hg: Downloading media selection XML
ERROR: No video formats found; please report this issue on https://yt-dl.org/bug . Make sure you are using the latest version; type  youtube-dl -U  to update. Be sure to call youtube-dl with the --verbose flag and include its complete output.
Traceback (most recent call last):
File "/usr/local/bin/youtube-dl/youtube_dl/YoutubeDL.py", line 797, in extract_info
ie_result = ie.extract(url)
File "/usr/local/bin/youtube-dl/youtube_dl/extractor/common.py", line 530, in extract
ie_result = self._real_extract(url)
File "/usr/local/bin/youtube-dl/youtube_dl/extractor/bbc.py", line 592, in _real_extract
self._sort_formats(formats)
File "/usr/local/bin/youtube-dl/youtube_dl/extractor/common.py", line 1350, in _sort_formats
raise ExtractorError('No video formats found')
ExtractorError: No video formats found; please report this issue on https://yt-dl.org/bug . Make sure you are using the latest version; type  youtube-dl -U  to update. Be sure to call youtube-dl with the --verbose flag and include its complete output.
Description

WRITE DESCRIPTION HERE
Looks like downloading from iplayer's broke. I've tried youtube-dl -U , also uninstalling/re-installing youtube-dl. Same result. The version of Ubuntu it's running on is Ubuntu 18.04.4 LTS

It's most likely because you need to have authentication to access (at least) this particular requested item, meaning that you cannot watch it (neither download it) without signing in to bbc.

unfortunately same for me (why i'm here) but this is with me signed in and i can watch it in a browser.
youtube-dl --verbose https://www.bbc.co.uk/iplayer/episode/m000m2k7/gravity [debug] System config: [] [debug] User config: [] [debug] Custom config: [] [debug] Command-line args: ['--verbose', 'https://www.bbc.co.uk/iplayer/episode/m000m2k7/gravity'] [debug] Encodings: locale UTF-8, fs utf-8, out UTF-8, pref UTF-8 [debug] youtube-dl version 2020.07.28 [debug] Python version 3.7.7 (CPython) - Linux-5.6.19-158.current-x86_64-with-glibc2.2.5 [debug] exe versions: ffmpeg 4.3.1, ffprobe 4.3.1, rtmpdump 2.4 [debug] Proxy map: {'no': 'localhost,<IP_ADDRESS>/8,::1'} [bbc.co.uk] m000m2k7: Downloading video page [bbc.co.uk] m000m2k7: Downloading playlist JSON [bbc.co.uk] m000m2k6: Downloading media selection XML ERROR: No video formats found; please report this issue on https://yt-dl.org/bug . Make sure you are using the latest version; see  https://yt-dl.org/update  on how to update. Be sure to call youtube-dl with the --verbose flag and include its complete output. Traceback (most recent call last):   File "/usr/lib/python3.7/site-packages/youtube_dl/YoutubeDL.py", line 797, in extract_info     ie_result = ie.extract(url)   File "/usr/lib/python3.7/site-packages/youtube_dl/extractor/common.py", line 530, in extract     ie_result = self._real_extract(url)   File "/usr/lib/python3.7/site-packages/youtube_dl/extractor/bbc.py", line 592, in _real_extract     self._sort_formats(formats)   File "/usr/lib/python3.7/site-packages/youtube_dl/extractor/common.py", line 1350, in _sort_formats     raise ExtractorError('No video formats found') youtube_dl.utils.ExtractorError: No video formats found; please report this issue on https://yt-dl.org/bug . Make sure you are using the latest version; see  https://yt-dl.org/update  on how to update. Be sure to call youtube-dl with the --verbose flag and include its complete output.

BTW other stuff is fine.
but, i think, BBC uses a range of different techniques/providers/formats so it might be one particular setup thats the issue.

Hi,
I've also encountered this problem and I found the issue with the code. I think the problematic section of code is
https://github.com/ytdl-org/youtube-dl/blob/45f6362464d283fe61653c75fbb93a6a87ac6f65/youtube_dl/extractor/bbc.py#L354-L356
self._MEDIASELECTOR_URLS contains multiple URLs, but this section of code only ever uses the first of the URLs, and never the second.
I've fixed it by changing the code to
            try:
                formats, subtitles = self._download_media_selector_url(
                    mediaselector_url % programme_id, programme_id)
                if len(formats) != 0:
                    return (formats, subtitles)
                return (formats, subtitles)

I can confirm that this has fixed the issue for both links in this issue ("Gravity", and "The Notebook").
In order to apply the fix, you need to find where the bbc.py file is located, find line 354, and replace the code with what I have above.

Please check the URL https://www.bbc.co.uk/programmes/b00sbjzv to see which fix will resolve the 'No video formats found' problem there.

Please check the URL https://www.bbc.co.uk/programmes/b00sbjzv to see which fix will resolve the 'No video formats found' problem there.

@ProgrammerAKL The fix that I outlined above also fixes the issue for that URL.

@ProgrammerAKL
tried but not fixed here.

Fixed by https://github.com/ytdl-org/youtube-dl/pull/26821.
Thanks also to @ProgrammerAKL who diagnosed the problem separately.
My patch tries to retrieve and merge formats and subtitles from any parseable playlist from the mediaselector URL list. Comments, tests welcome.


Strict nginx config validation doesn't allow to generate virtual hosts

@martensson I see that you strictly validate nginx config here. The problem is that it is impossible to use nixy for virtual host generation with this approach. Any validation fails with upstream configuration from/etc/nginx/sites-enabled/.... Can you make validation optional for this case?

Not sure I understand, are the config files in sites-enabled included in the main nginx.conf? Should be something like include /etc/nginx/sites-enabled/*. In this case they should also be validated.

I try to use nixy directly for virtual hosts config generation so the validation fails. My nginx_template starts with upstream definitions:
upstream location1 {
  # template
}

upstream location2 {
  # template
}

...

I see, and I can see that it can be an issue for these kind of use-cases. I will look into it once I got some time!

Sorry for the delay, but you can check this commit: https://github.com/martensson/nixy/commit/4935f5fa051831a7e552423442e9b844086a5cb6
Its non-breaking and if it looks OK it should not be a problem to push a new release.

Looks good. Thanks!

Added to latest release as well now! 👍


Improving incremental builds

Using cargo:rerun-if-changed to signal when build.rs should run.

Shouldn't it rerun if api.json changed as well?

bindings-generator/api.json isn't directly used by gdnative-bindings. It's baked into bindings-generator as a 'static str. When the dependencies (bindings-generator) of gdnative-bindings/build.rs change, it'll re-run.


Format checking on date-time fails silently if imports aren't available

https://github.com/Julian/jsonschema/blob/master/jsonschema/_format.py#L205-L211
If the imports for strict_rfc3339 and isodate are not available, the validation comes back as OK, this should either raise an import error or both deps should be included in the package.
>>> datetime_schema = {
...     "$schema": "http://json-schema.org/draft-04/schema#",
...     "type": "object",
...     "properties": {
...         "start": {
...             "format": "date-time"
...         }
...     }
... }
>>> dt_validator = Draft4Validator(datetime_schema, format_checker=jsonschema.FormatChecker())
>>> dt_validator.validate({"start": "asdf"})

after installing strict_rfc3339 and isodate:
>>> datetime_schema = {
...     "$schema": "http://json-schema.org/draft-04/schema#",
...     "type": "object",
...     "properties": {
...         "start": {
...             "format": "date-time"
...         }
...     }
... }
>>> dt_validator = Draft4Validator(datetime_schema, format_checker=jsonschema.FormatChecker())
>>> dt_validator.validate({"start": "asdf"})
Traceback (most recent call last):
  File "<stdin>", line 1, in <module>
  File "/Users/thisisshi/dev/cloud-custodian/lib/python2.7/site-packages/jsonschema/validators.py", line 130, in validate
    raise error
jsonschema.exceptions.ValidationError: 'asdf' is not a 'date-time'

Failed validating 'format' in schema['properties']['start']:
    {'format': 'date-time'}

On instance['start']:
    'asdf'

@thisisshi have you seen the format setuptools extra? It installs any required dependencies for format.

Yea, I see the additional deps there, but failing silently on import error is really unintuitive-- on top of that, passing a format_checker that returns nothing unless extra deps are installed seems counterproductive for validation. I would rather know that I'm missing an import than to unknowingly be validating input that doesn't match the schema.

That's what the spec says should happen. jsonschema just follows it.
On Fri, Apr 6, 2018, 09:31 Sonny<EMAIL_ADDRESS>wrote:

Yea, I see the additional deps there, but failing silently on import error
is really unintuitive-- on top of that, passing a format_checker that
returns nothing unless extra deps are installed seems counterproductive for
validation. I would rather know that I'm missing an import than to
unknowingly be validating input that doesn't match the schema.
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/Julian/jsonschema/issues/395#issuecomment-379254146,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAUIXlVi_0k0ESlW5uUn_g16PYNoQoqdks5tl25PgaJpZM4TIi6T
.

Going to close this, it's just an outcome of the spec saying unknown formats should be ignored, not fail validation, but I'm all ears if you've got suggestions on ways to make this more obvious or if you'd like to discuss further.

Gotcha, it looks to me that the best path forward for this would be to update the docs in such a way to clarify the installation of the extra deps, I'll submit a PR soon

Sounds good! Thanks!


Debugging tools

My problem
Trains don't work and i have no idea why. I have 2 very short and almost identical railroads, one works, one doesn't. There isn't a clear and understandable reason for this, and the dashboard isn't mad at me, so i really can't see any way to identify the issue and figure out how to fix it. Later i built another small road with just 2 stations in a survival world and it just doesn't work at all. The dashboard says it can't find a path from the depot to the first station, but they're linked properly, and once again i don't understand what the issue is.
My solution
A dashboard with an assortment of tools for troubleshooting and possibly (i'd really like this option) an option to manually construct a path by linking rail nodes that the dashboard would accept wothout a question. Tools should at least consist of a log of a path creation to see where and why it fails (or doesn't), a path viewer that would outline where and how trains navigate and a measuring tool to make sure trains fit. Also, among those tools, i'd like to see an option to manually control a train with no restrictions, because now to my understanding there must be a path that the train should be able to follow automatically, but since this doesn't work, at least let me drive it manually.
Additional Information
These tools could help identify bugs and possibly even find workarounds. I think a lot of players would benefit from their existence, and they could be a very helpful learning tool to understand the logic of the trains better.

Share you world and I bet I can find the issue in 5 seconds.

This has probably fixed in 4.0.0. Please verify and reopen this issue as needed.


Type 'Any' does not conform to protocol 'Decodable'

In DictionaryDecoder, we found some build errors, which are caused from the type 'Any' does not conform to protocol 'Decodable' . Please check and fix these if you don't mind.
open func container<Key: CodingKey>(keyedBy type: Key.Type) throws -> KeyedDecodingContainer<Key> {
        let container = try lastContainer(forType: [String: Any].self)
        return KeyedDecodingContainer(KeyedContainer<Key>(decoder: self, codingPath: [], container: container)) // <- error: Type `Any` does not conform to protocol `Decodable`
    }

    open func unkeyedContainer() throws -> UnkeyedDecodingContainer {
        let container = try lastContainer(forType: [Any].self) // <- error: Type `Any` does not conform to protocol `Decodable`
        return UnkeyedContanier(decoder: self, container: container)
    }

...

func nestedContainer<NestedKey>(keyedBy type: NestedKey.Type, forKey key: Key) throws -> KeyedDecodingContainer<NestedKey> where NestedKey : CodingKey {
    decoder.codingPath.append(key)
    defer { decoder.codingPath.removeLast() }

     let value = try find(forKey: key)
     let dictionary = try decoder.unbox(value, as: [String: Any].self) // <- error: Type `Any` does not conform to protocol `Decodable`
     return KeyedDecodingContainer(KeyedContainer<NestedKey>(decoder: decoder, codingPath: [], container: dictionary))
}

func nestedUnkeyedContainer(forKey key: Key) throws -> UnkeyedDecodingContainer {
    decoder.codingPath.append(key)
    defer { decoder.codingPath.removeLast() }

     let value = try find(forKey: key)
     let array = try decoder.unbox(value, as: [Any].self) // <- error: Type `Any` does not conform to protocol `Decodable`
      return UnkeyedContanier(decoder: decoder, container: array)
}

So the workaround is to make Any into AnyDecodable so it ends up something like this:
`public struct AnyDecodable : Decodable {
let value :Any
public init(_ value :T?) {
self.value = value ?? ()
}
public init(from decoder :Decoder) throws {
let container = try decoder.singleValueContainer()
if let string = try? container.decode(String.self) {
  self.init(string)
} else if let int = try? container.decode(Int.self) {
  self.init(int)
} else {
  self.init(())
}
// handle all the different types including bool, array, dictionary, double etc

}
}`
I got that code from this post: https://medium.com/@azamsharp/understanding-type-erasure-in-swift-2bf8fc530653 where they talk about this issue.

@d-date @garsdle  Thanks for the issue and support!
Oh, conditional conformance seems to be causing a build error...
AnyCodable is good idea! I'll refer to it in the future :D
This time, I fixed it in another way https://github.com/tattn/MoreCodable/commit/d8d69ff2411940cb897e98cfefd0b299c603a169.  But it is not cool, so I refactor it later.


Move file I/O of ModelicaStandardTables to ModelicaIO

In https://github.com/UdK-VPT/BuildingSystems/issues/12#issuecomment-157212665 it was discussed that the file I/O (i.e., functions readTxtTable and readMatTable) of the ModelicaStandardTables could be decoupled from the core table features being interpolation and extrapolation. With ModelicaIO (of MSL v3.2.2) already supporting reading MAT files the implementation basics and infrastructure are already available.
@mwetter @thorade FYI.

Resolved by 7ac5e517d594601983f42fe008f43970188b4bb6 in master.


New PLISTs for Updated logicpro & mainstage versions

See that you recently added a new plist for logicpro 10.3.2, but there is also an updated version of mainstage - 3.3.1 (up from 3.3.0) - which I did not see added.

I don't think there are changes to the loops for Mainstage 3.3.1 from 3.3.0. If you investigate the app bundle (ctrl click, show package content) the embedded plist is the same as for 3.3.0.
/Applications/MainStage\ 3.app/Contents/Resources/mainstage330.plist
Applications/MainStage\ 3.app/Contents/version.plist shows

BuildAliasOf
MAMainStage
BuildVersion
2
CFBundleShortVersionString
3.3.1
CFBundleVersion
4685.58
ProductBuildVersion
3M59
ProjectName
MAMainStage
SourceVersion
4685056000000000

@daveweale is correct. No new content for MainStage.


[Routing]Raw route values should be restored after template binder failing binding values when generating a url

From @anobaka on December 6, 2016 7:20
Minimal repro steps

Create a sample .net core web application.
Modify the app.UseMvc... line to:

app.UseMvc(routes =>
{
    routes.MapRoute(
        name: "test",
        template: "{area?}/{controller=Home}/{action=Index}/{id?}"
    );
    routes.MapRoute(
        name: "default",
        template: "{controller=Home}/{action=Index}/{id?}");
});

Add TestController and an Index action in it.
Add var a = Url.Action("Index", "Test"); in Index Action of HomeController.
Run app and visit /.

Expected result
local variable a should be /Test
Actual result
the value of a is /
Further technical details
I checked the source of Routing and found that the raw route values will not be restored after template binder failed binding values. So when the default router was tring to generate url, there was action:Index only left in route values, so it used the default controller Home.
ref:
https://github.com/aspnet/Routing/blob/rel/1.1.0/src/Microsoft.AspNetCore.Routing/Template/TemplateBinder.cs#L238
https://github.com/aspnet/Routing/blob/rel/1.1.0/src/Microsoft.AspNetCore.Routing/Template/TemplateBinder.cs#L279
I think the logic is that all routers should try to bind raw route values to generate url, but not the route values modified by previous router, so the raw route values should be restored after each router binding or routers should use the copy of the raw route values.
Thanks.
Copied from original issue: aspnet/Home#1860

@rynowak

@Eilon - we should investigate this, if there's a bug here this is a good 1.1.1 candidate.

I'm able to reproduce this and it definitely looks wrong.

Looking into it now...

@kichalla - is this fix for 1.1.1? If so, it's fine to merge for 'dev', but we need the bug to remain open so we can track for 1.1.1...

Yeah, it was for 1.1.1 and was merge to 'dev'. Sure, reopening it.

Understood, thanks!

This patch bug is approved. Please use the normal code review process w/ a PR and make sure the fix is in the correct branch, then close the bug and mark it as done.

@kichalla does this just needs to be Closed/3-Done now? The change is already in the right branch?

Oh wait nevermind we need to port the commit, so there's actual work here.

The fix was already merged back (3rd Jan) into 'dev' if that is what you mean: https://github.com/aspnet/Routing/commits/dev

Ah that's right, so we effectively just need to port it.

@Eilon, the change is in https://github.com/aspnet/Routing/tree/rel/1.1.1 and in the dev branch. Doesn't look like we need to do anything more.

Oh weird... we had a 1.1.1 branch for that long? That's cool.

@kichalla if you agree with the facts, it sounds like you can just close this!

if you agree with the facts

I'm interested to see if he does. He likes Pepsi

:-)


Sr omnibot simtest

Playing around with the simulation of the omnibot.

This pull request introduces 12 alerts when merging 9b0670ea72d0ac500ba837312fe445c5383ff2b5 into 3f7828ff78cb725007388ff58d6137ca08ececd8 - view on LGTM.com
new alerts:

7 for Unused import
4 for Unused local variable
1 for Testing equality to None

Comment posted by LGTM.com

You can click on the CI for details

Why is this not building?

Why is this not building?

I think the keys for apt needs to be renewed.

Why is it not building for you?
Regards,
Jason Wang, Computer Eng. Student
Tel:<PHONE_NUMBER> | Skype: Jaw.vuwij

On Nov 6, 2018, at 3:05 PM, Shahryar Rajabzadeh<EMAIL_ADDRESS>wrote:
Why is this not building?
I think the keys for apt needs to be renewed.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or mute the thread.


Add development STRTA support Node.js front/back-end project

Select a CI service to use for builds and releases of this project. Up until now, the project is expected to:

Produce a static bundle for the front-end
Produce a single container image with the front-end bundle and a TypeScript based backend
Be released into an AWS/Fargate based environment managed by Terraform

The project itself is public and intends to continue to be public.

Blocked by https://github.com/PublicMapping/district-builder-2/issues/3.


Change Traefik intro video

Description
This PR changes the video in the readme to the new video made at GopherCon 2017. As it is less than 10m long, it makes a good quick introduction.

Any particular reason to remove the Devoxx video? why not keep it underneath?

Any particular reason to remove the Devoxx video? why not keep it underneath?

Yes: this Devoxx video was old (April 2016), in French, and long. I think it's better to have a 5 minutes intro in (bad) English at first :)
I was thinking of adding a video section in https://awesome.traefik.io to reference all videos.


missing entities and numberplate

Some of the entities seems missing, and not provided anymore.
Happens for my corolla with the "location" and "current month statistics"
but my numberplate seems changing every hour:

It's a few months that I'm having the same behaviour. I have noticed that trying to reload the integration some times makes some sensors to re-appear. Very likely something has changed in the communication protocol and the integration is failing on timeouts or something similar... :-(

Ho istallato il tutto come da procedura (Hacs) ma riesco a vedere solo il numero di targa e nessun'altra entità.
Sul veicolo le autorizzazioni sono tutte attivate e da app è tutto funzionante. Quale potrebbe essere il problema?

Sorry, I don't understand Italian.

Mi spiace, non capisco l'italiano.

I installed everything as per procedure (Hacs) but I can only see the license plate number and no other entities. The permissions on the vehicle are all activated and the app is fully functional. What could be the problem?

I installed everything as per procedure (Hacs) but I can only see the license plate number and no other entities. The permissions on the vehicle are all activated and the app is fully functional. What could be the problem?

Please look here: https://github.com/DurgNomis-drol/ha_toyota/issues/164
This is currently a known issue due to Toyota's recent API changes. We are already working on an adaptation to the latest API. But this might take some time, as there is no public documentation and a lot is trial and error.

We recently released version 2.0.0 of the Custom Component with major changes and support for the new Mytoyota API.
As we unfortunately cannot provide support for Custom Component versions < v2.0.0, I hereby close your issue.
If the issue still applies to the current version, you are of course free to open a new issue. 😊

still same issue with 2.0.0

still same issue with 2.0.0

Please open a new issue if this is the case so that we can better understand and track it.


Change textures to be multiples of 16px

storage_cube.png and companion_cube.png were 10x10px, which makes mipmapping frown. I changed them to be 16px by padding the right and bottom edges, then changed their model to a custom portalcubed:block/cube_all_10x model that crops to the upper-left 10x10px region of the texture. They look the same in-game.
I also nearest-neighbor upscaled mini_blackhole to 16px for the same reason.
Love the mod, and the textures are lovely!

so i accidentally forgor about this and Carter ended up fixing it with all the stuff weve been doing

Swag


Use reponse handler with persist

The persist method uses now the reponse handler to manage response code.
And fix the missing namespace of ApiErrorException.

WDYT @Taluu ?

Hum, kinda late on this, but :+1:


Work on adding IBM MQ headers

Description:
$subject

For now we only support MQRFH2 headers. And also MQMD data like,

The message type (MQMD.MsgType)
The message ID (MQMD.MsgId)
The user associated with the message (MQMD.UserIdentifier)
The application associated with the message (MQMD.PutApplName)
The target queue and queue manager for reply messages (MQMD.ReplyToQ and MQMD.ReplyToQMgr)
Correlation information that enables applications to correlate requests and replies (MQMD.MsgId and MQMD.CorrelId)

We have added support for MQRFH2, MQRFH, MQCIH, MQIIH headers

Closing as these are done now


Enabling Excerpts

Hi Juuso!
Firstly thanks for this great plugin.
I see that you mentioned in your amp_generate.rb file that excerpts are disabled as they case an error. Could you please let me know what error it causes and how I can enable excerpts if required. I'm not familiar with ruby code.
I manually set the excerpts in my code, so if there is any way to enable excerpts it would help.
Thanks!

self.data['excerpt'] = post.to_liquid['excerpt']
This seems to have done the trick.


Multiple panel how to hide previous

I am using multiple panels with different layouts (half/tip/top) in our app. How can I hide or just bind them to the top view's top position? (Like Find My app does)

You can hide the backed panel by calling fpc.move(to: .hidden, animated: false). FindMy app doesn't look like binding them actually, but the technic that its surface position changes in floatingPanelDidMove of the front panel might allow the backed panel to follow front one.

You can hide the backed panel by calling fpc.move(to: .hidden, animated: false). FindMy app doesn't look like binding them actually, but the technic that its surface position changes in floatingPanelDidMove of the front panel might allow the backed panel to follow front one.

Thanks a lot, it works!

Thanks a lot, it works!


Incorrect bash/zsh syntax highlighting

Issue Type: Bug
Vscode gets confused by the following fragment of zsh code (where the first line is taken verbatim from the _arguments completion helper code that is bundled with zsh):
"${(@)^${(@)tmp:#^*:*}//:/[}]"
# This part should not be in the string in zsh

The second line (and everything after in the file) is incorrectly considered part of the string by VSCode's shell syntax highlighting. For some to me unfathomable reason it appears VSCode does not properly detect the end quote of the string on the first line.
Here is how it looks in vscode:

Removing the last ] in the string "fixes" the highlighting (but of course breaks the code):

VS Code version: Code 1.66.2 (dfd34e8260c270da74b5c2d86d61aee4b6d56977, 2022-04-11T07:49:24.808Z)
OS version: Linux x64 5.17.3-arch1-1
Restricted Mode: No

System Info

Item
Value

CPUs
Intel(R) Core(TM) i7-8550U CPU @ 1.80GHz (8 x 2816)

GPU Status
2d_canvas: enabledcanvas_oop_rasterization: disabled_offdirect_rendering_display_compositor: disabled_off_okgpu_compositing: enabledmultiple_raster_threads: enabled_onoop_rasterization: disabled_offopengl: enabled_onrasterization: disabled_softwareraw_draw: disabled_off_okskia_renderer: enabled_onvideo_decode: disabled_softwarevideo_encode: disabled_softwarevulkan: disabled_offwebgl: enabledwebgl2: enabled

Load (avg)
1, 1, 0

Memory (System)
31.12GB (24.32GB free)

Process Argv
--disable-extensions --crash-reporter-id a77f92e1-4f12-4a9f-aad2-4dc61886222c

Screen Reader
no

VM
0%

DESKTOP_SESSION
cinnamon

XDG_CURRENT_DESKTOP
X-Cinnamon

XDG_SESSION_DESKTOP
cinnamon

XDG_SESSION_TYPE
x11

Extensions disabled

After debugging this I believe the issue may be that VSCode gives higher "precedence" to [] than {}. I believe that the [ and ] at the end in the code are in fact unrelated (though I admit the code is hard to read!).
"${var//:/[}]"

is a simplified example that still exhibits the issue. The correct interpretation of it is

$var but with all : replaced with [
A final ] outside the variable substitution.

Zsh processes nested substitutions from inside out, so the whole ${...} is processed before ] is considered, and a lone ] at the end of the string is a normal literal character, nothing fancy going on.

By the way, this is not zsh specific, I can reproduce this with the following bash code, which also syntax highlights incorrectly in vscode in the same manner:
v="a:b"
echo "${v/:/[}]"
# Prints a[b]

We get our shellscript grammar from https://github.com/atom/language-shellscript, but the textmate grammar there is no longer maintained. This issue would need to be solved by adopting a new shellscript grammar: https://github.com/microsoft/vscode/issues/77675