.Net: CompletionsUsage object throws null exception with gpt-4-32k (v0613)

Describe the bug
When using the gpt-4-32k (v0613) Azure OpenAI model, Semantic kernel throws a null reference exception at Microsoft.SemanticKernel.Connectors.OpenAI.ClientCore.CaptureUsageDetails(CompletionsUsage usage)
Switching the model to gpt-4 (v1106-Preview), the usage object is created and does have populated properties.
To Reproduce
Steps to reproduce the behavior:

Run a Semantic Kernel InvokeAsync against a function targeting the gpt-4-32k model. Mine was created by CreateFunctionFromPromptYaml, but this may not be relevant.

Expected behavior
No exception is thrown
Screenshots
The stack trace for the exception that is thrown is:
   at Microsoft.SemanticKernel.Connectors.OpenAI.ClientCore.CaptureUsageDetails(CompletionsUsage usage)
   at Microsoft.SemanticKernel.Connectors.OpenAI.ClientCore.<GetChatMessageContentsAsync>d__27.MoveNext()
   at Microsoft.SemanticKernel.ChatCompletion.ChatCompletionServiceExtensions.<GetChatMessageContentAsync>d__1.MoveNext()
   at Microsoft.SemanticKernel.KernelFunctionFromPrompt.<InvokeCoreAsync>d__3.MoveNext()
   at System.Threading.Tasks.ValueTask`1.get_Result()
   at Microsoft.SemanticKernel.KernelFunction.<InvokeAsync>d__18.MoveNext()

Platform

OS: Windows
IDE: Visual Studio
Language: C#
Source: SK NuGet packages version 1.3.0

Additional context

Same error occurring for us as well:
at Microsoft.SemanticKernel.Connectors.OpenAI.ClientCore.CaptureUsageDetails(CompletionsUsage usage)
at Microsoft.SemanticKernel.Connectors.OpenAI.ClientCore.d__27.MoveNext()
at System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw()
at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)
at Microsoft.SemanticKernel.ChatCompletion.ChatCompletionServiceExtensions.d__1.MoveNext()
at System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw()
at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)
at Microsoft.SemanticKernel.KernelFunctionFromPrompt.d__3.MoveNext()
at System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw()
at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)
at Microsoft.SemanticKernel.KernelFunction.d__18.MoveNext()
at System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw()
at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)
at System.Runtime.CompilerServices.TaskAwaiter`1.GetResult()
at Microsoft.Azure.Comms.Acm.Business.Services.SemanticKernelAdaptor.d__4.MoveNext()
Code:
            KernelArguments kernelarguments = new KernelArguments { { "input", message } };

            return await kernel.InvokeAsync(function, kernelarguments);

And it says Object reference not set to a instance of an object. Enumeration yielded no result.

Unfortunately, I can't reproduce it. Looking at method implementation, there are 3 objects used:

usage: maybe for some reason this information was removed from completion API, that's why this object is null.
Logger: it's always initialized. In case it's not passed to ClientCore, NullLogger will be used instead.
Metering counters: these objects are initialized on ClientCore initialization, and I don't think they are null.

Taking into account, that most probably in this code usage object is null, I've added the PR that temporarily should fix this problem, until we figure out why this happened: https://github.com/microsoft/semantic-kernel/pull/4956

Unfortunately, I can't reproduce it. Looking at method implementation, there are 3 objects used:

usage: maybe for some reason this information was removed from completion API, that's why this object is null.
Logger: it's always initialized. In case it's not passed to ClientCore, NullLogger will be used instead.
Metering counters: these objects are initialized on ClientCore initialization, and I don't think they are null.

Taking into account, that most probably in this code usage object is null, I've added the PR that temporarily should fix this problem, until we figure out why this happened: #4956

we are also getting the same error from this morning, somehow it works with Azure OpenAI acoount-1 but fails with account-2.
screenshot from the debug,
SK nuget version: 0.24.230911.2-preview
method: ClientBase.cs -> InternalGetChatResultsAsync

@rajanikanthr Thanks for confirming, based on your screenshot it looks like Usage is null and PR that I shared above should fix this problem.

This is breaking one of my applications at the moment. I've read the pull request - is there a workaround that I can use?

https://github.com/microsoft/semantic-kernel/issues/4953

New release (1.3.1) has been published https://www.nuget.org/packages/Microsoft.SemanticKernel.Connectors.OpenAI


Support multiple architectures for Docker and provide image tags

It would be nice to support multiple architectures (at least arm64) and tag images with MAVSDK release tag.

Currently images at the DockerHub are not tagged with the MAVSDK release which means it is not possible to freeze the version of a dockerized MAVSDK.
Also I am a bit confused: there is a relatively new mavsdk-ubuntu-22.04 image but it is not listed in build_and_push_docker_images.sh while mavsdk-ubuntu-20.04)  was updated 3 months ago (there latter is present in the file).

It seems that the issue was added twice due to GitHub bug. Duplicates #1869.


setup for red-lists

[x] separate files for each red-list. Part of the datasets folder
[ ] read + feed it to the swt.getStopwords function
[ ] Slice the list on i.e. 500 words in the beginning. Then you'll know if it is good to push further with more redlisted words to "get to" stopwords later in the list/array.

The final list should probably/hopefully contain 200 - 300 words.

Set up an array.filter
https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/Array/filter

Think slicing shoul be part of swt.getStopwords function.
So from swt.getStopwords(wordsCounted.words, redlist) to swt.getStopwords(wordsCounted.words, redlist, maxWords) where maxWords is an integer.


How to call this in angular 2

Hello All,
I am trying to call this in my angular 2 component
like:
require('../../../style/vendors/EventSource.js');
	let es = new EventSource(URL);

But, i am getting the exception that event source :ErrorUncaught (in promise): TypeError: EventSource is not a constructor
TypeError: EventSource is not a constructor
Please suggest me i am doing this in correctly or not?

No clue, pretty much why I've never got on with Angular to be honest. Sorry i cant be more help.
Closing as it's not a bug with the lib, but I'd suggest reaching out to StackOverflow community?


Tempest with ElasticSearch 1.7.3

Seems, that the plugin is not compatible with version 1.7.3, as I was unable to start the cluster with cluster.routing.allocation.type: com.datarank.tempest.allocator.LocalMinimumShardsAllocator enabled.
Can you please verify ?

@stachdude It is somewhat compatible.
I'm not involved in the tempest project but we started using the plugin at my company a few weeks ago and we're also running ES 1.7.3.
Our config:
cluster.routing.allocation.type: com.datarank.tempest.allocator.LocalMinimumShardsAllocator
cluster.routing.allocation.probabilistic.range_ratio: 1.2
However, we do have a problem with the plugin throwing exceptions ocassionally when trying to allocate shards. See #15 which as reported by us.

This should be resolved in Tempest 2.0.2


EditorProperty: rounded corners and label_transparent property

This PR adds rounded corners to EditorProperty, EditorPropertyResource sub-inspectors, and EditorSpinSlider. Having sharp corners worked well in 3.x, but they look out of place in 4.0's new editor theme which is the main purpose of this PR.
It also adds a new property to EditorProperty, label_transparent, which makes the label text display at 0.5 transparency. I added this property because it previously checked for a period in label to make text partially transparent (used for project settings feature tag overrides), but there was a comment in the code saying that this functionality should be moved to project settings instead. As an added bonus, it's exposed to GDScript so plugins can make use of it.
Before and After:

Rounded corners seem nice, however...

label_centered makes the label text and buttons centered vertically when true and top-aligned when false.

This is a replacement for EditorProperty.set_label_reference() which was used by several EditorProperty types to make their text top-aligned but wasn't exposed to GDScript.

I don't see a good reason to introduce a more limited replacement. Can you argue why this is better than exposing the method that already exists and is used?

Fixed a bug where label text could overlap children by a few pixels.
Fixed a bug where the revert icon would overlap text if it had a checkbox (mainly in Control theme overrides).

I think bug fixes should be PR'd separately from enhancement proposals. We can merge them now, without much discussion.

I made the option more limited for a few reasons:

set_label_reference was only ever used to make text top-aligned, so label_centered essentially achieves the same thing.
It's easier to use and understand.
Using the height and position of another node to determine the label's height and position feels like a hack.

I can't think of many cases where a plugin developer would want to position the label text somewhere other than the center or top, except maybe the bottom in which case I could change it to an enum like Label.vertical_alignment. Would this deserve making a proposal for more discussion?
I'll change the commit message and move the bug fixes into another PR.
Thanks for letting me know that I should keep bug fixes and improvements in separate PRs. I'll keep that in mind for any future contributions I do.

I can't think of many cases where a plugin developer would want to position the label text somewhere other than the center or top, except maybe the bottom in which case I could change it to an enum like Label.vertical_alignment. Would this deserve making a proposal for more discussion?

A proposal is always appreciated to have dedicated space for a discussion. Though plugins are always too niche to produce much of it.

Using the height and position of another node to determine the label's height and position feels like a hack.

Ideally, we should always either top-align or center-align. But it seems there is (or used to be at some point?) a need to align the label to a specific part of the property editor. It makes sense for more complex controls to have this option, though I can't think immediately of a single use for it.
At the very least, if we were to change this, an enum is definitely better than "centered" boolean. An enum would make the choice much clearer.

I made a new PR for the bug fixes #58125. I'll remove them from this PR and add the changes suggested by @pycbouh.

@pycbouh I removed the label alignment property because I wasn't what options should be given. I'll probably open a proposal so it can be discussed before opening a new PR with those options separately from this one.
I also updated the main post to reflect the current state of this PR.

This looks lovely! Not sure from your description, where the highlight on the offset array property go? Or did you just not focus on it for the second screenshot?

It still has the highlight, I guess I just forgot to select it when taking the second screenshot.

Rebased and fixed an issue with properties that don't have a control on the right side having too much vertical padding.

Rebased and added margins to EditorPropertyLocalizableString to match Array and Dictionary.

I moved the rounded corners into a new PR, https://github.com/godotengine/godot/pull/59770, as this PR was doing too many things originally and I'm not sure that this even was the best way to solve this problem


KOGITO-9855: Avoid create protobuf folder with root privileges. Fix p…

…ostgresql Dataindex addons integration test reusing testcontainers
jira:https://issues.redhat.com/browse/KOGITO-9855
Many thanks for submitting your Pull Request :heart:!
Please make sure that your PR meets the following requirements:

[ ] You have read the contributors guide
[ ] Pull Request title is properly formatted: KOGITO-XYZ Subject
[ ] Pull Request title contains the target branch if not targeting main: [0.9.x] KOGITO-XYZ Subject
[ ] Pull Request contains link to the JIRA issue
[ ] Pull Request contains link to any dependent or related Pull Request
[ ] Pull Request contains description of the issue
[ ] Pull Request does not include fixes for issues other than the main ticket

How to replicate CI configuration locally?

Build Chain tool does "simple" maven build(s), the builds are just Maven commands, but because the repositories relates and depends on each other and any change in API or class method could affect several of those repositories there is a need to use build-chain tool to handle cross repository builds and be sure that we always use latest version of the code for each repository.
build-chain tool is a build tool which can be used on command line locally or in Github Actions workflow(s), in case you need to change multiple repositories and send multiple dependent pull requests related with a change you can easily reproduce the same build by executing it on Github hosted environment or locally in your development environment. See local execution details to get more information about it.

How to retest this PR or trigger a specific build:

for pull request checks
Please add comment: Jenkins retest this

for a specific pull request check
Please add comment: Jenkins (re)run [kogito-apps|kogito-examples] tests

for quarkus branch checks
Run checks against Quarkus current used branch
Please add comment: Jenkins run quarkus-branch

for a quarkus branch specific check
Run checks against Quarkus current used branch
Please add comment: Jenkins (re)run [kogito-apps|kogito-examples] quarkus-branch

for quarkus main checks
Run checks against Quarkus main branch
Please add comment: Jenkins run quarkus-main

for a specific quarkus main check
Run checks against Quarkus main branch
Please add comment: Jenkins (re)run [kogito-apps|kogito-examples] quarkus-main

for quarkus lts checks
Run checks against Quarkus lts branch
Please add comment: Jenkins run quarkus-lts

for a specific quarkus lts check
Run checks against Quarkus lts branch
Please add comment: Jenkins (re)run [kogito-apps|kogito-examples] quarkus-lts

for native checks
Run native checks
Please add comment: Jenkins run native

for a specific native check
Run native checks
Please add comment: Jenkins (re)run [kogito-apps|kogito-examples] native

for native lts checks
Run native checks against quarkus lts branch
Please add comment: Jenkins run native-lts

for a specific native lts check
Run native checks against quarkus lts branch
Please add comment: Jenkins (re)run [kogito-apps|kogito-examples] native-lts

How to backport a pull request to a different branch?

In order to automatically create a backporting pull request please add one or more labels having the following format backport-<branch-name>, where <branch-name> is the name of the branch where the pull request must be backported to (e.g., backport-7.67.x to backport the original PR to the 7.67.x branch).

NOTE: backporting is an action aiming to move a change (usually a commit) from a branch (usually the main one) to another one, which is generally referring to a still maintained release branch. Keeping it simple: it is about to move a specific change or a set of them from one branch to another.

Once the original pull request is successfully merged, the automated action will create one backporting pull request per each label (with the previous format) that has been added.
If something goes wrong, the author will be notified and at this point a manual backporting is needed.

NOTE: this automated backporting is triggered whenever a pull request on main branch is labeled or closed, but both conditions must be satisfied to get the new PR created.

Quarkus-3 PR check is failing ... what to do ?

The Quarkus 3 check is applying patches from the `.ci/environments/quarkus-3/patches`.
The first patch, called 0001_before_sh.patch, is generated from Openrewrite .ci/environments/quarkus-3/quarkus3.yml recipe. The patch is created to speed up the check. But it may be that some changes in the PR broke this patch.
No panic, there is an easy way to regenerate it. You just need to comment on the PR:
jenkins rewrite quarkus-3

and it should, after some minutes (~20/30min) apply a commit on the PR with the patch regenerated.
Other patches were generated manually. If any of it fails, you will need to manually update it... and push your changes.

PR job #1 was: UNSTABLE
Possible explanation: This should be test failures

Reproducer
build-chain build full_downstream  -f 'https://raw.githubusercontent.com/${AUTHOR:apache}/incubator-kie-kogito-pipelines/${BRANCH:main}/.ci/buildchain-config-pr-cdb.yaml' -o 'bc' -p apache/incubator-kie-kogito-apps -u https://github.com/apache/incubator-kie-kogito-apps/pull/1891 --skipParallelCheckout
NOTE: To install the build-chain tool, please refer to https://github.com/kiegroup/github-action-build-chain#local-execution

Please look here: https://ci-builds.apache.org/job/KIE/job/kogito/job/main/job/pullrequest_jobs/job/kogito-apps-pr/job/PR-1891/1/display/redirect
Test results:

PASSED: 2807
FAILED: 1

Those are the test failures:

org.kie.kogito.index.ProcessDataIndexInfinispanIT.testProcessInstanceEvents
1 expectation failed.JSON path errors doesn't match.Expected: null  Actual: <[{message=Exception while fetching data (/UserTaskInstanceCommentUpdate) : Index 0 out of bounds for length 0, locations=[{line=1, column=12}], path=[UserTaskInstanceCommentUpdate], extensions={classification=DataFetchingException}}]>

PR job #4 was: UNSTABLE
Possible explanation: This should be test failures

Reproducer
build-chain build full_downstream  -f 'https://raw.githubusercontent.com/${AUTHOR:apache}/incubator-kie-kogito-pipelines/${BRANCH:main}/.ci/buildchain-config-pr-cdb.yaml' -o 'bc' -p apache/incubator-kie-kogito-apps -u https://github.com/apache/incubator-kie-kogito-apps/pull/1891 --skipParallelCheckout
NOTE: To install the build-chain tool, please refer to https://github.com/kiegroup/github-action-build-chain#local-execution

Please look here: https://ci-builds.apache.org/job/KIE/job/kogito/job/main/job/pullrequest_jobs/job/kogito-apps-pr/job/PR-1891/4/display/redirect
Test results:

PASSED: 2725
FAILED: 15

Those are the test failures:

org.kie.kogito.index.oracle.ProcessDataIndexOracleHttpIT.testProcessInstanceEvents
java.util.concurrent.CompletionException: java.lang.RuntimeException: Unable to start Quarkus test resource class org.kie.kogito.index.test.quarkus.http.DataIndexOracleHttpQuarkusTestResource

org.kie.kogito.index.oracle.ProcessDataIndexOracleKafkaIT.testProcessInstanceEvents
java.util.concurrent.CompletionException: java.lang.RuntimeException: Unable to start Quarkus test resource class org.kie.kogito.index.test.quarkus.kafka.DataIndexOracleQuarkusKafkaTestResource

org.kie.kogito.index.ProcessDataIndexMongoDBIT.testProcessInstanceEvents
1 expectation failed.JSON path data.UserTaskInstances[0].comments.size() doesn't match.Expected: is <1>  Actual: <0>

org.kie.kogito.index.ProcessDataIndexOracleIT.testProcessInstanceEvents
Failed to load ApplicationContext

org.kie.kogito.index.service.KeycloakMongoIndexingServiceIT.testUnauthorizedUserAccess
java.lang.reflect.InvocationTargetException

org.kie.kogito.index.service.KeycloakOracleIndexingServiceIT.testUnauthorizedUserAccess
java.lang.reflect.InvocationTargetException

org.kie.kogito.explainability.rest.KeycloakExplainabilityServiceIT.shouldReturnUnauthorized
java.lang.reflect.InvocationTargetException

org.kie.kogito.jobs.service.messaging.InfinispanMessagingApiTest.cancelJob
java.lang.RuntimeException: Failed to start quarkus

org.kie.kogito.jobs.service.repository.infinispan.InfinispanJobRepositoryTest.testFindAll
java.lang.RuntimeException: Failed to start quarkus

org.kie.kogito.jobs.service.resource.KeycloakInfinispanJobServiceTest.(?)
java.lang.RuntimeException: Failed to start quarkus

org.kie.kogito.security.KeycloakSecurityCommonsServiceIT.meTest
java.lang.RuntimeException: io.quarkus.builder.BuildException: Build failure: Build failed due to errors [error]: Build step io.quarkus.oidc.deployment.devservices.keycloak.KeycloakDevServicesProcessor#startKeycloakContainer threw an exception: java.lang.RuntimeException: org.testcontainers.containers.ContainerLaunchException: Container startup failed at io.quarkus.oidc.deployment.devservices.keycloak.KeycloakDevServicesProcessor.startKeycloakContainer(KeycloakDevServicesProcessor.java:247) at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native Method) at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62) at java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43) at java.base/java.lang.reflect.Method.invoke(Method.java:566) at io.quarkus.deployment.ExtensionLoader$3.execute(ExtensionLoader.java:909) at io.quarkus.builder.BuildContext.run(BuildContext.java:281) at org.jboss.threads.ContextHandler$1.runWith(ContextHandler.java:18) at org.jboss.threads.EnhancedQueueExecutor$Task.run(EnhancedQueueExecutor.java:2449) at org.jboss.threads.EnhancedQueueExecutor$ThreadBody.run(EnhancedQueueExecutor.java:1478) at java.base/java.lang.Thread.run(Thread.java:829) at org.jboss.threads.JBossThread.run(JBossThread.java:501)Caused by: org.testcontainers.containers.ContainerLaunchException: Container startup failed at org.testcontainers.containers.GenericContainer.doStart(GenericContainer.java:349) at org.testcontainers.containers.GenericContainer.start(GenericContainer.java:322) at io.quarkus.oidc.deployment.devservices.keycloak.KeycloakDevServicesProcessor.lambda$startContainer$4(KeycloakDevServicesProcessor.java:372) at java.base/java.util.Optional.orElseGet(Optional.java:369) at io.quarkus.oidc.deployment.devservices.keycloak.KeycloakDevServicesProcessor.startContainer(KeycloakDevServicesProcessor.java:397) at io.quarkus.oidc.deployment.devservices.keycloak.KeycloakDevServicesProcessor.startKeycloakContainer(KeycloakDevServicesProcessor.java:195) ... 11 moreCaused by: org.rnorth.ducttape.RetryCountExceededException: Retry limit hit with exception at org.rnorth.ducttape.unreliables.Unreliables.retryUntilSuccess(Unreliables.java:88) at org.testcontainers.containers.GenericContainer.doStart(GenericContainer.java:334) ... 16 moreCaused by: org.testcontainers.containers.ContainerLaunchException: Could not create/start container at org.testcontainers.containers.GenericContainer.tryStart(GenericContainer.java:542) at org.testcontainers.containers.GenericContainer.lambda$doStart$0(GenericContainer.java:344) at org.rnorth.ducttape.unreliables.Unreliables.retryUntilSuccess(Unreliables.java:81) ... 17 moreCaused by: org.testcontainers.containers.ContainerLaunchException: Timed out waiting for log output matching '.*Keycloak.*started.*' at org.testcontainers.containers.wait.strategy.LogMessageWaitStrategy.waitUntilReady(LogMessageWaitStrategy.java:47) at org.testcontainers.containers.wait.strategy.AbstractWaitStrategy.waitUntilReady(AbstractWaitStrategy.java:52) at org.testcontainers.containers.GenericContainer.waitUntilContainerStarted(GenericContainer.java:953) at org.testcontainers.containers.GenericContainer.tryStart(GenericContainer.java:485) ... 19 more

org.kie.kogito.trusty.ui.KeycloakTrustyUIServiceIT.(?)
java.lang.reflect.InvocationTargetException

org.kie.kogito.trusty.ui.StaticContentTest.testIndexHtml
java.lang.reflect.InvocationTargetException

org.kie.kogito.trusty.service.common.KeycloakTrustyServiceIT.(?)
java.lang.RuntimeException: io.quarkus.builder.BuildException: Build failure: Build failed due to errors [error]: Build step io.quarkus.oidc.deployment.devservices.keycloak.KeycloakDevServicesProcessor#startKeycloakContainer threw an exception: java.lang.RuntimeException: org.testcontainers.containers.ContainerLaunchException: Container startup failed at io.quarkus.oidc.deployment.devservices.keycloak.KeycloakDevServicesProcessor.startKeycloakContainer(KeycloakDevServicesProcessor.java:247) at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native Method) at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62) at java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43) at java.base/java.lang.reflect.Method.invoke(Method.java:566) at io.quarkus.deployment.ExtensionLoader$3.execute(ExtensionLoader.java:909) at io.quarkus.builder.BuildContext.run(BuildContext.java:281) at org.jboss.threads.ContextHandler$1.runWith(ContextHandler.java:18) at org.jboss.threads.EnhancedQueueExecutor$Task.run(EnhancedQueueExecutor.java:2449) at org.jboss.threads.EnhancedQueueExecutor$ThreadBody.run(EnhancedQueueExecutor.java:1478) at java.base/java.lang.Thread.run(Thread.java:829) at org.jboss.threads.JBossThread.run(JBossThread.java:501)Caused by: org.testcontainers.containers.ContainerLaunchException: Container startup failed at org.testcontainers.containers.GenericContainer.doStart(GenericContainer.java:349) at org.testcontainers.containers.GenericContainer.start(GenericContainer.java:322) at io.quarkus.oidc.deployment.devservices.keycloak.KeycloakDevServicesProcessor.lambda$startContainer$4(KeycloakDevServicesProcessor.java:372) at java.base/java.util.Optional.orElseGet(Optional.java:369) at io.quarkus.oidc.deployment.devservices.keycloak.KeycloakDevServicesProcessor.startContainer(KeycloakDevServicesProcessor.java:397) at io.quarkus.oidc.deployment.devservices.keycloak.KeycloakDevServicesProcessor.startKeycloakContainer(KeycloakDevServicesProcessor.java:195) ... 11 moreCaused by: org.rnorth.ducttape.RetryCountExceededException: Retry limit hit with exception at org.rnorth.ducttape.unreliables.Unreliables.retryUntilSuccess(Unreliables.java:88) at org.testcontainers.containers.GenericContainer.doStart(GenericContainer.java:334) ... 16 moreCaused by: org.testcontainers.containers.ContainerLaunchException: Could not create/start container at org.testcontainers.containers.GenericContainer.tryStart(GenericContainer.java:542) at org.testcontainers.containers.GenericContainer.lambda$doStart$0(GenericContainer.java:344) at org.rnorth.ducttape.unreliables.Unreliables.retryUntilSuccess(Unreliables.java:81) ... 17 moreCaused by: org.testcontainers.containers.ContainerLaunchException: Timed out waiting for log output matching '.*Keycloak.*started.*' at org.testcontainers.containers.wait.strategy.LogMessageWaitStrategy.waitUntilReady(LogMessageWaitStrategy.java:47) at org.testcontainers.containers.wait.strategy.AbstractWaitStrategy.waitUntilReady(AbstractWaitStrategy.java:52) at org.testcontainers.containers.GenericContainer.waitUntilContainerStarted(GenericContainer.java:953) at org.testcontainers.containers.GenericContainer.tryStart(GenericContainer.java:485) ... 19 more

org.kie.kogito.trusty.service.common.api.DecisionsApiV1IT.testGetExecutionById
java.lang.reflect.InvocationTargetException

The API used by test containers to bind the protobuf folder with the fileSystem (withFileSystemBind) is creating as root when it previously doesn't exist. That's not the case when that folder is created by the codegen, that happens when there is any bpm workflow. This code is ensuring that folder exists before binding with test containers.
In order to avoid errors regarding reusing Postgres testcontainers, This PR updates the test to check just that the Process definition are properly indexed.
@wmedvede @fjtirado @pefernan Could you take a look?

PR job #6 was: UNSTABLE
Possible explanation: This should be test failures

Reproducer
build-chain build full_downstream  -f 'https://raw.githubusercontent.com/${AUTHOR:apache}/incubator-kie-kogito-pipelines/${BRANCH:main}/.ci/buildchain-config-pr-cdb.yaml' -o 'bc' -p apache/incubator-kie-kogito-apps -u https://github.com/apache/incubator-kie-kogito-apps/pull/1891 --skipParallelCheckout
NOTE: To install the build-chain tool, please refer to https://github.com/kiegroup/github-action-build-chain#local-execution

Please look here: https://ci-builds.apache.org/job/KIE/job/kogito/job/main/job/pullrequest_jobs/job/kogito-apps-pr/job/PR-1891/6/display/redirect
Test results:

PASSED: 2773
FAILED: 5

Those are the test failures:

org.kie.kogito.it.trusty.QuarkusTrustyExplainabilityEnd2EndIT.doTest
Container startup failed

org.kie.kogito.explainability.rest.KeycloakExplainabilityServiceIT.shouldReturnUnauthorized
java.lang.reflect.InvocationTargetException

org.kie.kogito.jobs.service.messaging.InfinispanMessagingApiTest.cancelJob
java.lang.RuntimeException: Failed to start quarkus

org.kie.kogito.jobs.service.repository.infinispan.InfinispanJobRepositoryTest.testFindAll
java.lang.RuntimeException: Failed to start quarkus

org.kie.kogito.jobs.service.resource.KeycloakInfinispanJobServiceTest.(?)
java.lang.RuntimeException: Failed to start quarkus

Jenkins retest this

PR job #1 was: UNSTABLE
Possible explanation: This should be test failures

Reproducer
build-chain build full_downstream  -f 'https://raw.githubusercontent.com/${AUTHOR:apache}/incubator-kie-kogito-pipelines/${BRANCH:main}/.ci/buildchain-config-pr-cdb.yaml' -o 'bc' -p apache/incubator-kie-kogito-apps -u https://github.com/apache/incubator-kie-kogito-apps/pull/1891 --skipParallelCheckout
NOTE: To install the build-chain tool, please refer to https://github.com/kiegroup/github-action-build-chain#local-execution

Please look here: https://ci-builds.apache.org/job/KIE/job/test/job/main/job/pullrequest_jobs/job/kogito-apps-pr/job/PR-1891/1/display/redirect
Test results:

PASSED: 2722
FAILED: 9

Those are the test failures:

org.kie.kogito.index.ProcessDataIndexInfinispanIT.testProcessInstanceEvents
1 expectation failed.JSON path data.UserTaskInstances[0].attachments.size() doesn't match.Expected: is <1>  Actual: <0>

org.kie.kogito.job.http.recipient.test.JobHttpRecipientDevModeTest.writeYourOwnDevModeTest
java.lang.RuntimeException: Unable to start Quarkus test resource class org.kie.kogito.job.http.recipient.test.HttpRecipientResourceMock

org.kie.kogito.job.http.recipient.test.JobHttpRecipientTest.(?)
java.lang.RuntimeException: Unable to start Quarkus test resource class org.kie.kogito.job.http.recipient.test.HttpRecipientResourceMock

org.kie.kogito.jobs.service.resource.JobServiceManagementResourceIT.testShutdown
java.lang.IllegalStateException: Unable to determine the status of the running process. See the above logs for details

org.kie.kogito.jobs.service.resource.KeycloakJobServiceTest.(?)
java.lang.RuntimeException: Failed to start quarkus

org.kie.kogito.jobs.service.messaging.InfinispanMessagingApiTest.cancelJob
java.lang.RuntimeException: Failed to start quarkus

org.kie.kogito.jobs.service.repository.infinispan.InfinispanJobRepositoryTest.testFindAll
java.lang.RuntimeException: Failed to start quarkus

org.kie.kogito.jobs.service.resource.KeycloakInfinispanJobServiceTest.(?)
java.lang.RuntimeException: Failed to start quarkus

org.kie.kogito.jobs.service.repository.postgresql.PostgreSqlJobRepositoryTest.testFindAll
java.lang.RuntimeException: Failed to start quarkus

PR job #7 was: UNSTABLE
Possible explanation: This should be test failures

Reproducer
build-chain build full_downstream  -f 'https://raw.githubusercontent.com/${AUTHOR:apache}/incubator-kie-kogito-pipelines/${BRANCH:main}/.ci/buildchain-config-pr-cdb.yaml' -o 'bc' -p apache/incubator-kie-kogito-apps -u https://github.com/apache/incubator-kie-kogito-apps/pull/1891 --skipParallelCheckout
NOTE: To install the build-chain tool, please refer to https://github.com/kiegroup/github-action-build-chain#local-execution

Please look here: https://ci-builds.apache.org/job/KIE/job/kogito/job/main/job/pullrequest_jobs/job/kogito-apps-pr/job/PR-1891/7/display/redirect
Test results:

PASSED: 2727
FAILED: 7

Those are the test failures:

org.kie.kogito.job.http.recipient.test.JobHttpRecipientDevModeTest.writeYourOwnDevModeTest
java.lang.RuntimeException: Unable to start Quarkus test resource class org.kie.kogito.job.http.recipient.test.HttpRecipientResourceMock

org.kie.kogito.job.http.recipient.test.JobHttpRecipientTest.(?)
java.lang.RuntimeException: Unable to start Quarkus test resource class org.kie.kogito.job.http.recipient.test.HttpRecipientResourceMock

org.kie.kogito.jobs.service.messaging.InfinispanMessagingApiTest.cancelJob
java.lang.RuntimeException: Failed to start quarkus

org.kie.kogito.jobs.service.repository.infinispan.InfinispanJobRepositoryTest.testFindAll
java.lang.RuntimeException: Failed to start quarkus

org.kie.kogito.jobs.service.resource.KeycloakInfinispanJobServiceTest.(?)
java.lang.RuntimeException: Failed to start quarkus

org.kie.kogito.jobs.service.repository.postgresql.PostgreSqlJobRepositoryTest.testFindAll
java.lang.RuntimeException: Failed to start quarkus

org.kie.kogito.persistence.oracle.OracleStorageServiceIT.testQuery_Equal
Error invoking subclass method

PR job #8 was: UNSTABLE
Possible explanation: This should be test failures

Reproducer
build-chain build full_downstream  -f 'https://raw.githubusercontent.com/${AUTHOR:apache}/incubator-kie-kogito-pipelines/${BRANCH:main}/.ci/buildchain-config-pr-cdb.yaml' -o 'bc' -p apache/incubator-kie-kogito-apps -u https://github.com/apache/incubator-kie-kogito-apps/pull/1891 --skipParallelCheckout
NOTE: To install the build-chain tool, please refer to https://github.com/kiegroup/github-action-build-chain#local-execution

Please look here: https://ci-builds.apache.org/job/KIE/job/kogito/job/main/job/pullrequest_jobs/job/kogito-apps-pr/job/PR-1891/8/display/redirect
Test results:

PASSED: 2776
FAILED: 3

Those are the test failures:

org.kie.kogito.jobs.service.messaging.InfinispanMessagingApiTest.cancelJob
java.lang.RuntimeException: Failed to start quarkus

org.kie.kogito.jobs.service.repository.infinispan.InfinispanJobRepositoryTest.testFindAll
java.lang.RuntimeException: Failed to start quarkus

org.kie.kogito.jobs.service.resource.KeycloakInfinispanJobServiceTest.(?)
java.lang.RuntimeException: Failed to start quarkus

PR job #10 was: UNSTABLE
Possible explanation: This should be test failures

Reproducer
build-chain build full_downstream  -f 'https://raw.githubusercontent.com/${AUTHOR:apache}/incubator-kie-kogito-pipelines/${BRANCH:main}/.ci/buildchain-config-pr-cdb.yaml' -o 'bc' -p apache/incubator-kie-kogito-apps -u https://github.com/apache/incubator-kie-kogito-apps/pull/1891 --skipParallelCheckout
NOTE: To install the build-chain tool, please refer to https://github.com/kiegroup/github-action-build-chain#local-execution

Please look here: https://ci-builds.apache.org/job/KIE/job/kogito/job/main/job/pullrequest_jobs/job/kogito-apps-pr/job/PR-1891/10/display/redirect
Test results:

PASSED: 1580
FAILED: 1

Those are the test failures:

org.kie.kogito.jobs.service.resource.KeycloakMongoDBJobServiceTest.(?)
java.lang.reflect.InvocationTargetException

PR job #1 was: UNSTABLE
Possible explanation: This should be test failures

Reproducer
build-chain build full_downstream  -f 'https://raw.githubusercontent.com/${AUTHOR:apache}/incubator-kie-kogito-pipelines/${BRANCH:main}/.ci/buildchain-config-pr-cdb.yaml' -o 'bc' -p apache/incubator-kie-kogito-apps -u https://github.com/apache/incubator-kie-kogito-apps/pull/1891 --skipParallelCheckout
NOTE: To install the build-chain tool, please refer to https://github.com/kiegroup/github-action-build-chain#local-execution

Please look here: https://ci-builds.apache.org/job/KIE/job/temporary/job/kogito-apps-1.40.x-pr/job/PR-1891/1/display/redirect
Test results:

PASSED: 2799
FAILED: 4

Those are the test failures:

org.kie.kogito.index.oracle.ProcessDataIndexOracleHttpIT.testProcessInstanceEvents
java.util.concurrent.CompletionException: java.lang.RuntimeException: Unable to start Quarkus test resource class org.kie.kogito.index.test.quarkus.http.DataIndexOracleHttpQuarkusTestResource

org.kie.kogito.index.oracle.ProcessDataIndexOracleKafkaIT.testProcessInstanceEvents
java.util.concurrent.CompletionException: java.lang.RuntimeException: Unable to start Quarkus test resource class org.kie.kogito.index.test.quarkus.kafka.DataIndexOracleQuarkusKafkaTestResource

org.kie.kogito.index.ProcessDataIndexOracleIT.testProcessInstanceEvents
Failed to load ApplicationContext

PR check / Build projects / org.kie.kogito.it.jobs.MultipleTimerInstancesIT.boundaryTimerEvent
Failed to load ApplicationContext


feature(ui-ux): evm support for address book

What this PR does / why we need it:
Which issue(s) does this PR fixes?:

Fixes #
Additional comments?:
Developer Checklist:

[ ] Read your code changes at least once
[ ] Tested on iOS/Android device (e.g, No crashes, library supported etc.)
[ ] No console errors on web
[ ] Tested on Light mode and Dark mode*
[ ] Your UI implementation visually matched the rendered design*
[ ] Unit tests*
[ ] Added e2e tests*
[ ] Added translations*

Codecov Report

Merging #4008 (1ddb4a3) into pierregee/evm-convert-screen (23161bc) will decrease coverage by 0.01%.
Report is 1 commits behind head on pierregee/evm-convert-screen.
The diff coverage is 0.00%.

@@                       Coverage Diff                        @@
##           pierregee/evm-convert-screen    #4008      +/-   ##
================================================================
- Coverage                         16.46%   16.45%   -0.01%
================================================================
  Files                               455      456       +1
  Lines                             12319    12376      +57
  Branches                           4104     4135      +31
================================================================
+ Hits                               2028     2037       +9
- Misses                            10250    10298      +48
  Partials                             41       41

Files Changed
Coverage Δ

mobile-app/app/hooks/useWalletAddress.ts
0.00% <0.00%> (ø)

...screens/Portfolio/assets/EmptyEvmPortfolioIcon.tsx
0.00% <ø> (ø)

...igator/screens/Portfolio/components/AddressRow.tsx
0.00% <0.00%> (ø)

.../Portfolio/components/BottomSheetAddressDetail.tsx
0.00% <0.00%> (ø)

...ortfolio/components/BottomSheetAddressDetailV2.tsx
0.91% <0.00%> (ø)

...s/Portfolio/screens/AddOrEditAddressBookScreen.tsx
0.00% <0.00%> (ø)

...or/screens/Portfolio/screens/AddressBookScreen.tsx
0.00% <0.00%> (ø)

shared/store/userPreferences.ts
27.65% <ø> (ø)

... and 5 files with indirect coverage changes
:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more


[SPARK-13439] [Mesos] Document that spark.mesos.uris is comma-separated

@mgummelt I'm guessing you got the wrong PR number? Could you please fix this?

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/51692/
Test FAILed.

The failure is spurious. LGTM.

@olarayej: Fixed.  Thanks.

retest this please

Jenkins, test this please

Test build #51968 has started for PR 11311 at commit 780e73b.

Test build #51968 has finished for PR 11311 at commit 780e73b.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/51968/
Test PASSed.

Merged to master/1.6


Show uninmplemented interface methods in Intellisense completion (after "public" and maybe "override" too)

Environment data
dotnet --info output: not installed
VS Code version: 1.55.2; Linux x64 5.4.0-72-generic snap
C# Extension version: 1.23.11
Steps to reproduce
class Foo : FooBase, ISomeInterface
{
  // ...
  public // after SPACE here, on IntelliSense completion (or CTRL+SPACE)
  // ...
  public override // maybe also here
  // ...
}

Expected  behavior
Completion will list only override methods from base classes, but you can make a huge improvement if you also list all necessary interface methods that haven't been implemented yet. Even though they don't use the keyword, it's conceptually a very similar intent from the programmers' perspective.
You'd just have to make completion automatically delete the override keyword in this case, and then add the method signature.
If deleting it is impossible, you could at least have completion for interface methods suggested after public (space).
Suggestions for required interface methods should appear first priority, before everything else (since in this case, the file is in an error state, and you surely want to fix that right away).
Actual behavior
Currently interface methods are not suggested at all in completion, neither after public or public override.
Yeah, I could use the "Implement interface" light-bulb fix, but I don't like it, because I don't even get to choose where I want the methods in the code, and that's important. Completion solves this.

Also, in both light-bulb and completion, I'm getting tabs even though my files are set to spaces; please fix this too (I do have csharp.format.enable: false, by the way).

I have same issue, while defining interface and do not have intellisense for it's implementations!

This functionality is provided by Roslyn. If you are still having problems, you can open a new issue at https://github.com/dotnet/roslyn/issues


Node Selector assigns wrong architecture for builds

Component
agent
Describe the bug
Recently, I am seeing builds being assigned to the wrong nodes on our cluster.
Inspecting the pods, I can see that the platform env, which comes from the matrix definition, is set to amd64. However, the nodeSelector is set to arm64 instead.
Environment:
  platform:                        linux/amd64

[...]

Node-Selectors:              kubernetes.io/arch=arm64

The WF definition is as follows
platform: ${platform}

matrix:
  include:
    - DISTRIBUTION: ubuntu
      RELEASE: focal
      OS_RELEASE: 20.04
      platform: linux/amd64
    - DISTRIBUTION: ubuntu
      RELEASE: jammy
      OS_RELEASE: 22.04
      platform: linux/amd64
    - DISTRIBUTION: redhat/ubi8-minimal
      RELEASE: latest
      platform: linux/amd64
      OS_RELEASE: rhel8
    - DISTRIBUTION: redhat/ubi9-minimal
      RELEASE: latest
      platform: linux/amd64
      OS_RELEASE: rhel9

Could it be that https://github.com/woodpecker-ci/woodpecker/pull/2048 changed the logic in a way that nodeSelector is always set to CI_SYSTEM_PLATFORM and does not honor platform env anymore?
https://github.com/woodpecker-ci/woodpecker/blob/0eacbe8a33823b75e1ecdd738f6c0cad00bd7d68/pipeline/backend/kubernetes/pod.go#L112
Or maybe one of the changes within the recent months caused this behavior?
Tagging @6543 and @zc-devs as you both did modifications in this area lately.
I am not having enough experience in GO to make an educated judgement right now - all I can see is that CI_SYSTEM_PLATFORM is not honoring platform env and therefore the nodeSelector is wrong in the end :)
System Info
`next-f8e91f00aa`

Additional context
No response
Validations

[X] Read the Contributing Guidelines.
[X] Read the docs.
[X] Check that there isn't already an issue that reports the same bug to avoid creating a duplicate.
[X] Checked that the bug isn't fixed in the next version already [https://woodpecker-ci.org/faq#which-version-of-woodpecker-should-i-use]
[X] Check that this is a concrete bug. For Q&A join our Discord Chat Server or the Matrix room.

I can confirm that the issue is not present in v1.0.2.

@6543 @zc-devs This is somewhat important and should be fixed before the next release or reverted (if no one has time). A response would be appreciated :)

Given that 1.0.2 works and hence everything in main until July 29th should be fine, I suspect #2249 to be the issue.
After testing: jup, main until 3954d85a5b962cc4cc3149a528a84866fe201a92 and the arch/nodeSelector mapping broke with #2249.
@klinux Are you able to look into this and fix the code? I'd revert the PR until it's fixed.

Is your WP server and agent run on arm64? And you want to run step on amd64 by setting platform in the matrix , right? Does it work, if you set it in a step directly rather then in the matrix?

nodeSelector is always set to CI_SYSTEM_PLATFORM and does not honor platform env anymore?

nodeSelector was always set from environment variable. It used to be CI_SYSTEM_ARCH. Then it became CI_SYSTEM_PLATFORM.

Is your WP server and agent run on arm64?

Agent runs on one (random assignment), agent runs on both (one of each).

And you want to run step on amd64 by setting platform in the matrix , right?

Yes, that worked (at least) until #2249. See OP. It might be that another commit broke it but I haven't done further bisecting yet and just looked at the history of pod.go.

Does it work, if you set it in a step directly rather then in the matrix?

I didn't test this but it doesn't matter much for the issue at hand as the matrix assignments as shown in the OP should work. So essentially, the mapping of platform must be honored (if defined) and carried over to the NodeSelector.

Nope, not really. You're right. My bad! I was too fast judging on the history...the issue must be somewhere else.

I've done some tests on 61b567205140d049d510c9414aede9c89e28616d.
Pipeline:
skip_clone: true
platform: linux/mips
steps:
  test:
    image: alpine
    commands:
      - echo Hello from test

Agent on server:
update agents set platform = 'linux/mips';

Then agent doesn't pick up job.
Then I  changed labels on agent:
WOODPECKER_FILTER_LABELS: platform=linux/mips

And agent runs job successfully. But I have no platform env var on the pod.
Also I have CI_SYSTEM_PLATFORM=linux/amd64. And it looks right, because it is set up from Agent's node platform.
I guess, that your agent wrongly picks up job that intended for other agent.
It's difficult to test as I have no different platforms. Maybe labels will help you somehow.

I've figured it out. The matrix notation should look like this
matrix:
  include:
    - DISTRIBUTION: ubuntu
      ARCH: arm64

where ARCH is just an arbitrary key name.
Then, in the pipeline, kubernetes.io/arch must be set in the steps backend_options as follows:
[...]
    backend_options:
      kubernetes:
        nodeSelector:
          kubernetes.io/arch: "${ARCH}"

The documentation also needs to be updated. Will do...

So, there is nothing wrong with nodeSelector and Kubernetes backend. Issue should be renamed.

Platform labels works.
Matrix works too:

matrix:
  PLATFORM:
    - linux/amd64
    - windows/arm64

skip_clone: true
steps:
  test:
    image: alpine
    commands:
      - echo Hello from ${PLATFORM}

3. There is some bug in their combination:
matrix:
  PLATFORM:
    - linux/amd64
    - windows/arm64

labels:
  platform: ${PLATFORM}

skip_clone: true
steps:
  test:
    image: alpine
    commands:
      - echo Hello from ${PLATFORM}

Server log:
{"level":"trace","error":"Cannot unmarshal '<nil>' of type <nil> into a string value","time":"2023-10-11T13:01:30Z","caller":"/woodpecker/server/pipeline/filter.go:69","message":"failed to parse config '.woodpecker.yml'"}


Authenticate with lobby server using API OAuth tokens

See the related PR https://github.com/FAForever/server/pull/473.
The new command replaces hello with a command that works almost the same, except instead of taking a username and password, it takes an OAuth token signed by the API. In order to solve the problem of what to do with the IRC password, we thought of having the server generate a password at random, and send it back to the client.
New auth message:
{
    "command": "auth",
    "token": "<token_string>",
    "unique_id": "<unique_id_string>"
}

IRC password response:
{
    "command": "irc_password",
    "password": "<new_irc_password>"
}

Some details will still need to be worked out.
Wanna have the bug fixed quickly?
Visit Issue hunt...

So what u say is that the irc thing still needs to be done right?

Also what about this
"unique_id": "<unique_id_string>"
I mean when I search it in your PR I can only find it in your tests. What is it for ? Do I need it?

Right, the client would need to read the password sent back by the server and use it to log in to the IRC. I'm not convinced that it's the right thing to do since I think some people log in with a regular IRC client as well as the FAF client, and also we'd be sending the IRC password over an unsecure channel. That's just the quick and dirty solution that we came up with. I think we should probably put more thought into it.
The unique_id is generated by the faf-uid executable. It's not a new field, the client is already sending it with the hello command. I just included it here for completeness.

https://stackoverflow.com/questions/59455089/oauth-2-spring-resttemplate-login-with-refresh-token

Well why is the channel unsecure @Askaholic I think this is ok. Well of cause IRC could also accept api tokens. Tho I think it is incrediable hard to hack that into our IRC...

So turns out the WebClient is reactive and does not fit at all with our CompletableFutures etc. so I think it is a bad idea to use. And the OAuth2RestTemplate does not support using passed refresh_tokens. So I guess I could go either for hacking in refresh_tokens grant in OAuth2RestTemplate or I just use some other Oauth2 library to do all this. I would aim for keeping the RestTemplate but setting the oauth2 header myself with the help of a oauth2 library.

@Brutus5000 do you know anything about this topic. Like how I could get a refresh_token grant? And what would u suggest? Go reactive with WebClient? Or set the headeryour self 🤔

@Askaholic what about reloading session when still in game. The old message had a long called "session" which stored the session id and it was send when reconnecting. Is that still a thing. Also there is a field "localIp" is that still used???


DO NOT MERGE: Test upgrade to protobuf 4.0.0-rc1

Protobuf just released version 4.0.0-rc1. This PR is to attempt to run our tests early to identify potential issues.
There is no language package uploaded for this release candidate yet.
This is a Draft PR - DO NOT MERGE please.

Looks like some of these tests (esp those involving ObjC cocoapods) won't work without the 4.0.0-rc1 packages being uploaded first. Protobuf team said that they will - just being held up by some other issues. Will check again.

4.0.0-rc1 packages for Ruby gems have been uploaded, but not for Cocoapods yet. Will keep monitoring.

4.0.0-rc1 packages for Ruby, C# and Obj-C have been uploaded. Running a new set of tests...

Looks like one big category of error is this one, involving gems dependency:
+ bundle install
Fetching gem metadata from https://rubygems.org/.........
Fetching gem metadata from https://rubygems.org/.
Resolving dependencies...
Bundler could not find compatible versions for gem "google-protobuf":
  In Gemfile:
    grpc was resolved to 1.31.0.dev, which depends on
googleapis-common-protos-types (~> 1.0) was resolved to 1.0.4, which
depends on
        google-protobuf (~> 3.0)

    grpc was resolved to 1.31.0.dev, which depends on
      google-protobuf (>= 4.0.0.rc.1)

Looks like we might need to submit a PR to get this line fixed first: https://github.com/googleapis/common-protos-ruby/blob/master/googleapis-common-protos-types/googleapis-common-protos-types.gemspec#L38

@stanley-cheung We ended up deciding that we are not going to increase the major version yet, and instead we are going to release 3.13.0 next. We're still releasing from the same branch cut, though. Would it be worthwhile to create another pull request like this one to test the 3.13.0-rc3 release?

@acozzette Yes I will do that today. Thanks for letting us know.


Semicolon should be removed after match, if etc. where nothing happens with the return value

match () {
    () => {},
};

if () == () {};

In both examples I would expect rustfmt to remove the semicolon.

Thanks for sharing, but tbh it seems borderline out of scope for rustfmt. I'll leave it open but going to mark as a low priority as it's unlikely we'll ever work on this.

@calebcartwright
Note that for and loop blocks are removed by rustfmt currently. I think if-without-else is in scope of rustfmt and basically the same as for, both of which always have type ().
match and if-else cases can be more complicated since removing the semicolon may break the code. So does loop. But I'm not sure why loop is stripped currently.


Supertokens

https://supertokens.com/use-oss

@andrasbacsai i know its your projects, i am only trying to keep the issues page clean.
Kindly Add and Vote for this request here: https://feedback.coolify.io/
But that is a cool app, seems there are many cool open source projects out there.

Closing this issue as services / features are tracked here. This request has been added to our feedback tool!


Add v3 RPC for sending cluster states to content nodes

@geirst please review
@toregge FYI
Supports sending states for multiple bucket spaces at once, with
possibilities for extending protocol later for sending distribution
config etc. Payload is LZ4-compressed when possible.
If a receiver node does not understand the v3 protocol, the protocol
version is transparently downgraded to legacy v2 RPC.

@geirst PTAL


Fix z-index of red location dot relative to cloud cover

The red dot can appear below the cloud cover on the cloud coverage map - should fix the relative z-indices so that this doesn't happen.

Fixed by #48


Key maps should be different between operating systems.

In Windows, ctrl works as the fn key, but in macOS, command works as the fn key in general.
There are some awesome libraries out there could make this easy:
ccampbell/mousetrap: https://github.com/ccampbell/mousetrap
madrobby/keymaster: https://github.com/madrobby/keymaster

After some digging on the source codes, I'd think that the key binding logic could be split into a separate module for long term implementation and optimization:

For new functions/features will be added, it could be easily adopted to binding into some new key definitions.
For some common use cases like for mobile/touch devices, key bindings can be auto disabled.
Maybe in some cases, people would want to disable the key bindings manually.
Maybe in some cases, people would like to bind different keys to some functions/features rather than the defaults.

And splitting these codes into a separate module can definitely makes the codes more readable, maintainable and extensible.


pdk: init at 3.0.0

Description of changes
Adds the puppet development kit.
Closes #253423
Things done

Built on platform(s)

[X] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)

[ ] sandbox = relaxed
[ ] sandbox = true

[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[X] Tested basic functionality of all binary files (usually in ./result/bin/)
23.11 Release Notes (or backporting 23.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[X] Fits CONTRIBUTING.md.

@ofborg build pdk

Result of nixpkgs-review pr 268128 run on x86_64-linux 1

1 package built:

pdk

I am very much not the person to review this (as I haven't used puppet in nearly a decade and have no idea how the nix ruby infra works). Sorry :/

oh okay, sorry for the ping then. I remember you reviewing a ruby package together with me like ~0.75 years ago and I never touched any other ruby in nixpkgs either :see_no_evil:


⚠ haccp has degraded performance

In afc3742, haccp (https://www.haccp.or.kr) experienced degraded performance:

HTTP code: 400
Response time: 5316 ms

Resolved: haccp performance has improved in d219d45.


Compile and build on Windows system (not WSL)

Currently tested and working fine on WSL but we need to build it too on Windows.

[x] Compile on Windows (x86)
[x] Compile on Windows (x64)
[ ] Fully ported to Windows systems

[ ] Fix --file option for Windows (see #21)

Currently is compiled on branch wip/windows but it's not fully ported.

i can't compile in window from the branch wip/windows so i make a pr to fix it https://github.com/Webtronic-Labs/hip-hip/pull/238

The brach was actually working compiling with Visual Studio 2019, can you explain the actual changes? And which compiler did you use.


[T2] 圖片框架

曾用在 TeaMeow 的 .single .double .triple .quadruple 圖片群組。

[ ] .celled
[ ] .separated
[ ] .one.images
[ ] .two.images
[ ] three.images
[ ] .four.images
[ ] .five.images

用斐波那契比例可好 :> ?

請問那是什麼呢
On Thu, Sep 15, 2016, 17:40 zypeh<EMAIL_ADDRESS>wrote:

用斐波那契比例可好 :> ?
—
You are receiving this because you were assigned.
Reply to this email directly, view it on GitHub
https://github.com/TeaMeow/TocasUI/issues/85#issuecomment-247282943, or mute
the thread
https://github.com/notifications/unsubscribe-auth/AG-FrgF_rFT4A_Dp-ukPbZgk655LFDlrks5qqRKAgaJpZM4J9PzC
.

--
TeaMeow
Not real but feels.
http://www.TeaMeow.com/

倒数第二个

你給了一張圖然後說倒數第二個，我稍微有點不能理解啊www
On Thu, Sep 15, 2016, 17:56 zypeh<EMAIL_ADDRESS>wrote:

[image: image]
https://cloud.githubusercontent.com/assets/1331557/18545880/b296bf9e-7b6d-11e6-80f1-dbfef5023456.png
倒数第二个
—
You are receiving this because you were assigned.
Reply to this email directly, view it on GitHub
https://github.com/TeaMeow/TocasUI/issues/85#issuecomment-247286388, or mute
the thread
https://github.com/notifications/unsubscribe-auth/AG-Frs1p6TnFIUASS80aie2ZmXYywLC2ks5qqRZRgaJpZM4J9PzC
.

--
TeaMeow
Not real but feels.
http://www.TeaMeow.com/

晚上再回答

Wiki
費波那契數列，又譯費氏數列、斐波那契數列、費波拿契數、黃金分割數列。

靠腰這是黃金螺旋吧wwwwww
On Thu, Sep 15, 2016, 19:46 Sean<EMAIL_ADDRESS>wrote:

Wiki
https://zh.wikipedia.org/wiki/斐波那契数列
費波那契數列，又譯費氏數列、斐波那契數列、費波拿契數、黃金分割數列。
—
You are receiving this because you were assigned.
Reply to this email directly, view it on GitHub
https://github.com/TeaMeow/TocasUI/issues/85#issuecomment-247306426, or mute
the thread
https://github.com/notifications/unsubscribe-auth/AG-Frm2F44oR5qVOg5g2DrZn7URhfno8ks5qqTAjgaJpZM4J9PzC
.

--
TeaMeow
Not real but feels.
http://www.TeaMeow.com/

您是說黃金比例嗎?

Wiki


Live events limits

"Difference between overflow meetings and live events
[...]
Additionally, we're increasing the length of the live events from 4 hours to 16 hours and enabling up to 50 concurrent live events per tenant."
Do you mean after acquiring this Advanced Communications add-on?
The note below the paragraph states it is only a temporarily increase till October 1st?

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 09168b55-8244-974e-8bb3-6ec16429a650
Version Independent ID: c17f4f8d-a8bb-3c81-368f-07b932f52ebc
Content: Advanced Communications add-on for Microsoft Teams - Microsoft Teams
Content Source: Teams/teams-add-on-licensing/advanced-communications.md
Service: msteams
GitHub Login: @LanaChin
Microsoft Alias: v-lanac

@bartvermeersch Thank you for submitting feedback.
I think the best way forward is if you open a service ticket in your tenant so this can get resolved ASAP. Based on the outcome let me know if it is something that can be called out in the docs.
Please follow this link to contact support for business products:https://docs.microsoft.com/office365/admin/contact-support-for-business-products
Please keep us posted here on the resolution so we can feed whatever information you discover into the content.


Implement context for minder CLI - be able to create, set, delete and work within a certain context

@rdimitrov what did this refer to?

@JAORMX - The idea is to have the option to set a context for all consecutive minder commands. The context would be i.e. user, project, provider, etc. and every command that you run afterwards would be executed within this context without needing to specify these values explicitly.

Discussion on Discord: https://discordapp.com/channels/1184987096302239844/1185287949240242258/1187401023640326164
TL;DR: we might simply be able to use viper more intentionally and not need new code.

We decided to handle multiple context by leveraging the features we already have through viper. Basically each context would be a new config file that can be specified via the --config flag. One can specify different minder and identity servers, but also cli generic variables such as provider, project, output formatting, etc. Variables which are flagged as required are not read from the config, even though they are bound to viper. This is because cobra expects those flags to passed and the viper value does not take precedence in this case. We can revisit this if a need for specifying, I.e. the profile name as part of the context makes sense for someone. Until then we can consider this issue as completed.

Reading through this a bit more, it seems like maybe adding an environment variable (either directly pointing to the file, or pointing to a directory with .AddConfigPath could be helpful.  I'm putting together a PR to do that.


[e2e] Results of e2e tests in github actions for nft backend and ipv4 family.

There are some test cases failing in the e2e tests results execution
Please check the below link for reference.
https://github.com/kubernetes-sigs/kpng/runs/4362502917?check_suite_focus=true

As we have less no of issues in each of the backends due to lot of issues fixed, closing this issue. We can open new issues for each failures now.


keg_only dependencies and rpath

I have an issue for a package with keg_only dependencies, after compilation the executable does not uses the correct library (checked with ldd), after fiddling around it looks like setting the RPATH with patchelf would solve my issue and indeed it does but is it supposed to work out of the box ?
I created a package libcurl but since there is one on the system already I made it keg_only, when compiling the environment seems correct and everything goes well, the issue is only on the final result (on a .so file in this case).
calling patchelf --set-rpath #{(Formula['libcurl'].prefix / "lib")} ... manually in the install method worked.

I am lost :o
I don't understand what linuxbrew is trying to do but it is playing against me, with my hack above the result is correctly using the keg only libcurl but if I bottle it, uninstall it and reinstall it from the bottle (on the same machine) the library used is now the system curl and an ldd shows that my custom change is gone :(
PS: I am using the libc which came with ubuntu (14.04), not glibc.

Hi, Julien.
brew install curl. It includes libcurl.so.
Linuxbrew does not really support keg_only libraries particularly well. It would need special RPATH support, which it doesn't currently do.
After installing a bottle, Linuxbrew uses patchelf to set the RPATH to $HOMEBREW_PREFIX/lib, which is overwriting you change. This same change is also made after brew bottle. You can use readelf -d to check the value of RPATH in the executable.
Cheers,
Shaun

thanks this is what I thought.

What I did is add the linuxbrew lib path to my system library paths so there is no need to specifically point to it and then set the rpath to the locations of keg only libraries. For me it does the job pretty well.

Yes, modifying ld.so.conf is a good alternative to RPATH that I haven't yet tried out. It's particularly appealing when using Linuxbrew's glibc.

even with the existing code why not set the rpath to include the linuxbrew lib folder and all the keg_only library paths ?
I have a working code that does that, if that's something you are interested to merge I can try to make a pull request out of it.

So far I've had no use for keg_only formula in Linuxbrew. What are you using them for? I have thought of adding to the RPATH of the executables of a formula the lib folder of all its direct dependencies.

I am using them in a similar way to homebrew itself, I take a base ubuntu server os and then our applications on it but I always disliked dependending on what comes with ubuntu since I have little to no control on which versions are available. Until now we simply used what came with the os to build upon, this means things like libcurl which are used by many base packages, but now with linuxbrew I should be able to take full control on what we actually use.
Since I have the linuxbrew lib folder in the system path I would end up using any library installed there even with system applications which would probably a lot of things.
I suppose not having the linuxbrew lib path in the system path shield you from that, I have to think why I wanted to add it in the system path I suppose xD

If you brew install glibc you can modify the ld.so.conf of Linuxbrew separately from the host system.


Enable ERC-20 asset transfers between L1 and L2

Included a bridging script to support asset transfers between Ethereum
and Optimism. Configured associcated settings and packages to support
the bridging script.
To perform a bridging operation:

Deploy a token contract on an L1 network. Note that for testnets,
Optimism does not support Rinkeby as there are no bridging contracts
exist on that chain. (See SDK)
Update the L1_TOKEN_ADDRESS field in .env
Deploy an L2 token contract with npm run deployL2TokenOptimismKovan
Update the L2_TOKEN_ADDRESS field in .env
Run npm run depositTokenToL2 to transfer a certain amount (defined
in bridgeArrowToken.js) of tokens to L2. Similarly, transfer tokens
from L2 back to L1 by running npm run withdrawTokenToL1. It will
take a quite while, so good time to grab a coffee :)
Call balanceOf on respective chains to test if bridging was
successful

Tests were done on here and here.
For each contract, feel free to inspect the transaction logs to check
the correctness of bridging operations.

Yes, there's an easy way! We can simply open a PR to add our token to OP's gateway list.
Then, we can use their GUI for bridging: https://app.optimism.io/bridge.
But I don't have all permissions needed to open that PR. I will make a note in the Discord and we can find a time with @thomasgarrison to do that.

👍 We don't need Thomas to help on this. I can open a PR when we deploy.

In which case, if we're doing it manually, does it make sense to close this PR or do you still see value in some of the changes?

Yes, it makes sense to close this PR since there's a GUI to use.


Not recognizing multiple sourcemaps in the same chunk

Hi, I'm running into an issue similar to #6 . My app has a single chunk: [ 'main.css', 'main.js', 'main.css.map', 'main.js.map' ]. For each chunk, chunkToSourceMapDescriptor will only find and select the first .map pair it finds, causing the css sourcemap to be the only one to be uploaded.
I'm on Webpack 4.8.3 and webpack-bugsnag-plugins 1.2.1. I'm using mini-css-extract-plugin to extract my css - any help would be appreciated, thanks!

Hey @frankieyan thanks for reporting this. Would you be able to provide more info?
It would be absolutely amazing if you could provide a webpack.config.js and some example files that would reliably reproduce this.
Let me know what you can share, or strip out from your project, and I'll be able to help. Cheers!

Hey @bengourley - you can check out this repo: https://github.com/frankieyan/bugsnag-upload-repro It emits both main.css and main.js in a single chunk. To handle this I believe chunkToSourceMapDescriptor will need walk through a chunk and anticipate multiple files.
Let me know if you need more info - I wouldn't mind taking a crack at the fix too if it helps move things forward 👍

Thanks for the repro repo, so helpful 🌟.
I've (hopefully) fixed this in #14 – I've published a prerelease to npm as v1.2.2-0. Do you want to install that and let me know that it fixes your problem?
If it works for you I also just need to route it through our qa procedure, then I can get a stable release out. Cheers!

Just tested and it works great. Thanks for the quick turnaround @bengourley !


error while compileing using  catkin_make

hello,
i hope you are doing fine ,i'm a student at the university i doing my master's thesis about classification using service robots and i'm trying to develop a  new way to classify people like age,gender,how many people are in the group ...etc
so i found a good project named spencerProject then i tried to give it a try and i found that its using an asus camera not like me i have a kinect difference between the drivers openni and openni2 so i tried a lot to make work i finally did but i found that the topic "/spencer/sensors/rgbd_front_top" is the responible for that then i was searching on how to replace it so i across y'r project on github and i found that u haven't change it u just add some detaills to it so i download u'r project and when i tries to make it with catkin_make it's giving me an error thats why i sending this email to ask you to help me i'm stucked i mean my project is not doing the compatibility asus xtion--->microsoftKinect so please reply to me soon as possible i really need that and thank you forgiving time to read this.

this is the error message :
Using these message generators: gencpp;genlisp;genpy
CMake Error at /opt/ros/indigo/share/catkin/cmake/catkinConfig.cmake:75 (find_package):
Could not find a package configuration file provided by
"rwth_pedestrian_tracking" with any of the following names:
rwth_pedestrian_trackingConfig.cmake
rwth_pedestrian_tracking-config.cmake

Add the installation prefix of "rwth_pedestrian_tracking" to
CMAKE_PREFIX_PATH or set "rwth_pedestrian_tracking_DIR" to a directory
containing one of the above files.  If "rwth_pedestrian_tracking" provides
a separate development package or SDK, be sure it has been installed.
Call Stack (most recent call first):
BiternionNets-ROS-master/CMakeLists.txt:7 (find_package)
-- Configuring incomplete, errors occurred!
See also "/home/elbarko/BI_project/build/CMakeFiles/CMakeOutput.log".
See also "/home/elbarko/BI_project/build/CMakeFiles/CMakeError.log".
make: *** [cmake_check_build_system] Error 1
Invoking "make cmake_check_build_system" failed

As the message says, you don't have the rwth_pedestrian_tracking package. You can find it over here: https://github.com/spencer-project/spencer_people_tracking

thank you so mutch  but there are no such file or dir please can you help
me find it i'm new to ROS so i'm learning by time
2016-02-28 23:09 GMT+01:00 Lucas Beyer<EMAIL_ADDRESS>
As the message says, you don't have the rwth_pedestrian_tracking package.
You can find it over here:
https://github.com/spencer-project/spencer_people_tracking
—
Reply to this email directly or view it on GitHub
https://github.com/VisualComputingInstitute/BiternionNets-ROS/issues/2#issuecomment-189955714
.

If you're new to ROS, please do yourself the favor and go through their excellent tutorials and documentation.
To use the package, you need to clone the repository into your ROS workspace's src folder.

yes i did that by saying new i mean this is my first time working with ros and i finished the tutorials

thanks now it telling me that libnite2 not found

[rospack] Error: package 'libnite2' not found

many thanks for helping me i did what y've told to do but now i'm getting
this type of error :
[rospack] Error: package 'libnite2' not found
NiTE_DIR = /common/lib/NiTE2/
LINK_NAME = /home/elbarko/.ros/NiTE2
Link /home/elbarko/.ros/NiTE2 to /common/lib/NiTE2/ already exists.
[100%] Built target cob_body_tracker
/home/elbarko/BI_project/src/BiternionNets-ROS-master/src/dump_tracks.cpp:19:52:
fatal error: spencer_tracking_msgs/TrackedPersons2d.h: No such file or
directory
#include <spencer_tracking_msgs/TrackedPersons2d.h>
^
compilation terminated.
make[2]: ***
[BiternionNets-ROS-master/CMakeFiles/dump_tracks.dir/src/dump_tracks.cpp.o]
Error 1
make[1]: *** [BiternionNets-ROS-master/CMakeFiles/dump_tracks.dir/all]
Error 2
make: *** [all] Error 2
Invoking "make -j4 -l4" failed
i know that ther are no trackedperson2d.msg thats why ther are no file
generated .h so the question is is it ok if i make som modifying to the
spencer project
and thank you for all what u are doing to me u'r awesome
2016-02-29 0:04 GMT+01:00 Larbi Baraka<EMAIL_ADDRESS>
thank you so mutch  but there are no such file or dir please can you help
me find it i'm new to ROS so i'm learning by time
2016-02-28 23:09 GMT+01:00 Lucas Beyer<EMAIL_ADDRESS>
As the message says, you don't have the rwth_pedestrian_tracking
package. You can find it over here:
https://github.com/spencer-project/spencer_people_tracking
—
Reply to this email directly or view it on GitHub
https://github.com/VisualComputingInstitute/BiternionNets-ROS/issues/2#issuecomment-189955714
.

I believe both of these errors are unrelated to BiternionNets-ROS. They are problems with setting up other packages (namely, NiTE2 and spencer_people_tracking).
If it is the case that BiternionNets-ROS is not compatible with the current version of spencer_people_tracking, I will notice and fix that in mid-March. I don't have the time right now, sorry!

thank you thats all what i needed i mean it has to be an error right thank you for what you are doing and please if you did any thing new let me know i will be glad


Fix for console stack

Refactors console execution in order to resolve issue #1134. It does this by changing executef calls to templates which internally manage the stack, similar to how most modern C++ script binding libraries work. The templates also automatically perform type conversion, meaning you don't even need to bother converting your parameters to TorqueScript types - this is all done for you.
Along with this, all public execution calls (such as execute* and evaluate*) now save and restore the stack upon returning. They are also now thread safe, meaning they can be called from other threads (as long as get*Arg functions aren't used).
I've also added some basic tests for the core marshalling functionality in addition to the execution calls. This should hopefully trap any expected future regressions with this functionality.
In addition some callbacks have been corrected to use the correct types instead of strings which was causing a few problems.

Ninja build fails:
../../../../Engine/source/console/console.h:877:122: fatal error: use 'template' keyword to treat 'call' as a dependent template name
        template<typename A> ConsoleValueRef executef(A a) { _EngineConsoleExecCallbackHelper<A> callback( a ); return callback.call<ConsoleValueRef>(); }
                                                                                ^
                                                                                template

This may shed some light.

Added a workaround. Hopefully should resolve the problem your end.

CI appears jammed waiting for executors on the master machine. Not sure what's up.

Looks like for some reason there's a problem with the include paths on Linux. Will have to check it out tomorrow.

afraid I've got some bad news on this one. After applying https://github.com/GarageGames/Torque3D/pull/1171 to correct the query master method, applying this fix-attempt seems to have exposed a leak. breaks 'randomly' within https://github.com/GarageGames/Torque3D/blob/development/Engine/source/platform/platformMemory.cpp#L1750-L1791
latest stacktrace: http://pastebin.com/nc20Ds6H

@azaezel do you have any reproduction steps? A stack trace isn't too useful here as I need to see what's happening leading up to said leak

simplest repro case once that others corrected is just hit query master server

Might have to rearrange these headers. GCC seems to handle these templates pretty badly.

Fixed GCC build. Having a look to see whats going on with your issue @Azaezel

Thanks :). I'll see if I can reproduce sometime soon as well.

Ok mystery solved. Looks like someone forgot to remove a couple of dFree calls ( see https://github.com/GarageGames/Torque3D/blob/59a5261b0298cdd04f1c7ba684e8d85b9dff2057/Engine/source/app/net/serverQuery.cpp#L436 ) which ended up freeing two of the string values in the console stack.

Whoops, that was introduced in #1072. Glad it was someone else's fault though.

Variadic templates FTW...

Merged this into devhead, clean&rebuild, run debug and hit 'GUI editor' and I get this:

Will have a look

Info I should have provided - assert fired in a call to dIsSpace with some random input string. The char val was -18, and the assert was checking for the range 0-255.

Repost from the issue page...
Pushed a fix for this which uses a relative pointer type. In addition I've added a new console variable type which acts as a pointer to a stack string which should help reduce the overall stack size (by reusing the data in the previous frames of the stack).

Hilariously, CI appears to be fine, but when I try to compile this locally I get
/torque/Engine/source/console/console.cpp:1760:33: error: cast from ‘char*’ to ‘U32 {aka unsigned int}’ loses precision [-fpermissive]
       return STR.mBuffer + (U32)sval;
                                 ^
compilation terminated due to -Wfatal-errors.

Any suggestion as to what I should do to that line? Or why some builds might be fine with it?

Looks like your doing a 64bit build, in which case it would be better to use UINTPTR. Will push a fix later.

Ah, that makes sense. Maybe CI isn't doing x64 at the moment. @LuisAntonRebollo?

It's working for me in Windows x32, though I never saw the issues this was supposed to fix. Good to go, pending x64 compatibility :).

 Every time I change a single source file and make, here we go, try to build every dependency project (lucky they're all already built), scan the engine project for dependencies, recompile a whole slew of source files, and then see what the error is now.

@jamesu I recommend, if you have time, following this guide to compile the engine in Ubuntu x64. It would tighten the development loop, rather than me finding errors I don't understand, and you then fixing them blindly! I'm going to have another go fixing things on this end to recommend some changes.

See 57eed9c for the changes I had to make to placate GCC.


Integration with Jetbrains IDEs

I am very unfamiliar with all of the inter-workings of plugins / language-servers, do you imaging your language server would be able to work with either of these?

https://github.com/gtache/intellij-lsp
https://github.com/ballerina-platform/lsp4intellij

If so, could you give a word of advice on how to do so?

This language server should integrate with any LSP client, there should be a guide to integrating LSP servers in the documentation for your IDE integration/plugin.
If there are issues arising from the differing subsets of the spec that are implemented, I'm happy to work together to get something working.
The only comment I'd make is that config is currently unlikely to work easily, there's a change in the works on that front, but getting something working with default config (see https://github.com/nwolverson/purescript-language-server#usage) would be a first step


Isdb 349 ccd search api integration

JIRA link (if applicable)
https://tools.hmcts.net/jira/browse/ISDB-349
Change description
integration with CCD search case api
Does this PR introduce a breaking change? (check one with "x")
[ ] Yes
[x] No

build is done in jenkins but here it's still showing some checks pending. so closing it and will open new PR.


No fling/momentum on scroll (Android Pie 9.0)

Environment

React Native Environment Info:
System:
OS: macOS 10.14.2
CPU: (8) x64 Intel(R) Core(TM) i7-7820HQ CPU @ 2.90GHz
Memory: 990.90 MB / 16.00 GB
Shell: 5.3 - /bin/zsh
Binaries:
Node: 11.3.0 - /usr/local/bin/node
Yarn: 1.12.3 - /usr/local/bin/yarn
npm: 6.5.0 - /usr/local/bin/npm
Watchman: 4.9.0 - /usr/local/bin/watchman
SDKs:
iOS SDK:
Platforms: iOS 12.1, macOS 10.14, tvOS 12.1, watchOS 5.1
IDEs:
Android Studio: 3.2 AI-181.55<IP_ADDRESS>56338
Xcode: 10.1/10B61 - /usr/bin/xcodebuild
npmPackages:
react: 16.6.3 => 16.6.3
react-native: 0.57.8 => 0.57.8
npmGlobalPackages:
react-native-cli: 2.0.1
react-native-git-upgrade: 0.2.7

Description
I installed custom rom PixelExperience on my Xiaomi Redmi 5 Plus.
Since then I'm experiencing scroll issue. If you make the page lose focus - scroll lacks the fling or momentum behaviour.
This only happens in React Native apps.
Live demo.
https://www.youtube.com/watch?v=vG2fTEb_ICg
Emulator works just fine.
I don't think is the custom rom issue since another user (@vforvasile) has reported the same.
Android has some changes for scrolling element https://developer.android.com/about/versions/pie/android-9.0-changes-28#scrolling-element
I tried using SDK 26 and 27 but it didn't solve the issue
Reproducible Demo
The issue described above is present in expo too.
https://snack.expo.io/@alexandrius/c3VwcG

I tried different ROM Resurrection Remix today. It has the same issue with fling.

I tried react-native 0.58.4 today still same issue. I will try to dig into react native code today to get the idea

@alexandrius thank you for digging into this

I have some updates regarding this issue.
I built React Native from source code and these are my observations:
I logged every value in ReactScrollView.java particularly in methods fling() and onOverScrolled() values didn't change before and after loosing focus.
Then I went ahead and removed from from fling()
else if (mScroller != null) {
// FB SCROLLVIEW CHANGE

// We provide our own version of fling that uses a different call to the standard OverScroller
// which takes into account the possibility of adding new content while the ScrollView is
// animating. Because we give essentially no max Y for the fling, the fling will continue as long
// as there is content. See #onOverScrolled() to see the second part of this change which properly
// aborts the scroller animation when we get to the bottom of the ScrollView content.

int scrollWindowHeight = getHeight() - getPaddingBottom() - getPaddingTop();
mScroller.fling(
  getScrollX(), // startX
  getScrollY(), // startY
  0, // velocityX
  correctedVelocityY, // velocityY
  0, // minX
  0, // maxX
  Integer.MIN_VALUE, // minY
  Integer.MAX_VALUE, // maxY
  0, // overX
  scrollWindowHeight / 2 // overY
);

ViewCompat.postInvalidateOnAnimation(this);

// END FB SCROLLVIEW CHANGE
}

Everything seemed to start working after this change except https://github.com/wix/react-native-calendars. I couldn't expend calendar of Agenda component.
Also I understand this is useful logic so it was not an option.
Since the behaviour resembles the behaviour of ScrollView inside ScrollView on native Android. I went ahead and extended ReactScrollView with NestedScrollView
public class ReactScrollView extends NestedScrollView implements ReactClippingViewGroup, ViewGroup.OnHierarchyChangeListener, View.OnLayoutChangeListener
Everything started to work just fine after this.
Here's comparison
https://www.diffchecker.com/EQhp2UJY

@patrickkempff Do you suggest creating my own react-native aar package or do you think #23490 can be implemented in short time?

See my reply on the PR.

OK thanks. But please I see no reason to close this issue. I will try to fix the code without switching to NestedScrollView

OK this issue is much bigger than I thought. I think it's something related to javascript engine of AOSP devices. I'll try to dig deeper for this issue

0.59.0 rc2 has same issue.
I will try https://github.com/react-native-community/jsc-android-buildscripts on the weekend

What is the solution to this problem? @cpojer I can dot find  your RP can you support in this ,thanks a lot.

We had a problem with bad scrolling performance on Android 9.
In our case we hade a Swiper component that rendered a couple of screens ~6-7 each screen rendered a ActivityIndicator. Removing the ActivityIndicator solved the problem for us.

@cpojer @patrickkempff Can you please give me a tip why might this happening? I just need some information where should I be digging at.
Besides swapping ScrollView to NestedScrollView. I tried to comment out some ReactActivity lifecycle methods but the issue is still there. I have only one idea why this might be happening: When the view is overlapped by another view or window the fling behavior stops working.

OK just after writing the comment above I managed to finally fix this issue. It's far from creating PR but here's some insight:
It seems the OverScroller instance is different. Before and after loosing the main focus. I still need to dig more to get why is this even happening.
I added this code to fling()
      OverScroller scroller = getOverScrollerFromParent();
      Log.d("OVERSCROLLER_ALEXANDRIUS = NEW", scroller.toString());
      Log.d("OVERSCROLLER_ALEXANDRIUS = OLD", mScroller.toString());

Here are logs before loosing focus (using the same App.js code I posted when I originally opened the issue)
03-12 16:22:56.334 22374 22374 D OVERSCROLLER_ALEXANDRIUS = NEW: android.widget.OverScroller@f9abd9d
03-12 16:22:56.335 22374 22374 D OVERSCROLLER_ALEXANDRIUS = OLD: android.widget.OverScroller@f9abd9d

And after loosing code
03-12 16:26:02.222 22374 22374 D OVERSCROLLER_ALEXANDRIUS = NEW: android.widget.OverScroller@5b3023c
03-12 16:26:02.222 22374 22374 D OVERSCROLLER_ALEXANDRIUS = OLD: android.widget.OverScroller@f9abd9d

As you can see the hash codes are different.
After I add this code the issue is resolved.
      OverScroller scroller = getOverScrollerFromParent();
      if (mScroller != scroller) {
        mScroller = scroller;
      }

I will try to test native Android app with custom OverScroller fling if the issue is there too. This is Android issue not React Native

For anyone experiencing the issue I suggest applying this patch. I understand this is a hacky way of fix so I'm not going to create a PR.
diff --git a/node_modules/react-native/ReactAndroid/src/main/java/com/facebook/react/views/scroll/ReactScrollView.java b/node_modules/react-native/ReactAndroid/src/main/java/com/facebook/react/views/scroll/ReactScrollView.java
index d39159a..7d0ea33 100644
--- a/node_modules/react-native/ReactAndroid/src/main/java/com/facebook/react/views/scroll/ReactScrollView.java
+++ b/node_modules/react-native/ReactAndroid/src/main/java/com/facebook/react/views/scroll/ReactScrollView.java
@@ -49,7 +49,7 @@ public class ReactScrollView extends ScrollView implements ReactClippingViewGrou
   private static boolean sTriedToGetScrollerField = false;

   private final OnScrollDispatchHelper mOnScrollDispatchHelper = new OnScrollDispatchHelper();
-  private final @Nullable OverScroller mScroller;
+  private @Nullable OverScroller mScroller;
   private final VelocityHelper mVelocityHelper = new VelocityHelper();
   private final Rect mRect = new Rect(); // for reuse to avoid allocation

@@ -330,6 +330,12 @@ public class ReactScrollView extends ScrollView implements ReactClippingViewGrou
       // as there is content. See #onOverScrolled() to see the second part of this change which properly
       // aborts the scroller animation when we get to the bottom of the ScrollView content.

+      OverScroller scroller = getOverScrollerFromParent();
+
+      if (mScroller != scroller) {
+        mScroller = scroller;
+      }
+
       int scrollWindowHeight = getHeight() - getPaddingBottom() - getPaddingTop();

       mScroller.fling(

I can't replicate that bug on Android 9, even on Expo with https://snack.expo.io/@alexandrius/c3VwcG.
Could anyone provide more information on how to replicate this?

I can't reproduce that bug on Android 9, even on Expo with https://snack.expo.io/@alexandrius/c3VwcG.
Could anyone provide more information on how to replicate this?

I'm encountering this bug, I upgraded to the latest react native (0.64) hoping it was fixed but nope, I can't replicate it on emulator but on a real device (nexus on android 9 aosp) its easy to replicate, just navigate from a screen that has a flatlist to another and go back or trigger an alert on that same screen, scrolling its like if you set the decelerationRate to 0

@charpeni It's only happening on AOSP android roms.


How to order plates?

Hey, I am pretty new to ordering PCBs and stuff. I want to build a Corne V4 with Kailh Choc V1 switches. Which of the plates do I need to order? The Alps, Cherry or none of the above?
When I upload the gerber files for the cherry top plates to jlcpcb it looks like this:

And the Gerber file view like this:

Is this how it should be?

Please chose the cherry plate for choc (same plate). And your screenshot looks normal so no problem.


Font size of Navbar in Laughing Therapy page is small

The font size of the elements on the laughing therapy page's navbar is too small compared to the landing page content. Can I work on this issue under SSOC'22?

@MohitNamdev22 I guess it's already fixed.

@Susmita-Dey But on the latest deployment, changes aren't visible 🤔

https://sukoon-stress-free.netlify.app/html/laughtherapy

@MohitNamdev22 Go ahead

The font size is set to 13px in navbar of many sections...
Should i change it to appropriate size(1rem, using clamp) in all of them? @Susmita-Dey

@BhavyaJain711 do it


Auto-Generate Video Previews does not work

Issue and Reproduction steps
Apply effect transformation according to this cloudinary feature Generate an AI-based video preview
Example:
cl.video_url(publicId, { effect: "preview:duration_12"})
It returns invalid url, where this effect is serialized wrong as "e_preview:du_8", which results in response 400
https://res.cloudinary.com/{cloudName}/video/upload/e_preview:du_8/{publicId}

Can you please share the account's cloud name and public_id of the resource and I will be able to pull up the logs and check further. You can always share the details by opening a support ticket here: https://support.cloudinary.com/hc/en-us/requests/new

Submitted #111311

Closing this as it was fixed in Version 2.9.0


remove dependency on ping/ping6 command, send icmp packet natively

remove ping/ping6 dependency

CHANGELOG is mandatory, pls update it

Updated, check if its sufficient


feat: object_ownership

Description
Allow configuring "Object Ownership"
How Has This Been Tested?

[x] I have tested and validated these changes using one or more of the provided examples/* projects

would love to see this get merged soon.

I'm currently doing this outside of the module and trying to update Ownership Controls and Public Access Policy at the same time results in the error
A conflicting conditional operation is currently in progress against this resource. Please try again.
You will need to set up a dependency to keep them from running at the same time.


Fix turnOn/turnOff methods for plugs and lights.

Note: the README refers to general turnOn / turnOff methods which do not exist (at least not in the current version).

Also can you create an Issue for this?


Integrated Terminal Kill Text (Control K) Requires Different Keypress

Version of VS Code: 1.40.1
Your operating system: Windows 7
Quick Summary:
I'm finding that the Kill Text command is not working properly after updating to 1.40.1. When focusing an integrated terminal using git bash as the shell, using the bash keyboard shortcut Control + K does not cut to the end of the line from my cursor. I similarly cannot use Yank / Control + Y to paste this.
It seems like if I hit control + K a second time, the command works as expected. I am able to use control Y afterwards no problem.
Steps to Reproduce:

Terminal: Focus Terminal

Select Default Terminal (git bash)

New Terminal

Type anything and go back to start of the line

Control K

See text in the bottom pane saying (Ctrl + K) was pressed. Waiting for second key of chord...

Nothing happens. I have to hit Ctrl + K again to properly cut text to the end of the line

Honestly, not a huge deal since I can work around it by hitting Ctrl + K a second time, just thought I would bring it up since this was not the same behavior as in version 1.39.2, and the integrated terminal follows other bash defaults fine (like Ctrl + y for yank, for example).

Related https://code.visualstudio.com/updates/v1_40#_chords-are-now-supported-by-default

Thanks @usernamehw that was it, didn't catch that in the release notes


qogir-theme: 2022-05-29 -> 2022-07-17

Description of changes

Update to version 2022-07-17
Replace duplicate files with links
Move patchShebangs to post patch phase
Run pre and post install hooks
Add optional arguments

Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
22.11 Release Notes (or backporting 22.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module
[ ] (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes

[x] Fits CONTRIBUTING.md.

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:
https://discourse.nixos.org/t/prs-ready-for-review/3032/1003


Add buffer.close_button_command to resolve Nvim Tree bdelete issues.

I'd be ok with adding a buffer.close_button_command option that's set to bdelete by default but can be configured to Bdelete if the user wants to. Having bufdelete.nvim as a hard dependency for everyone is not acceptable.
Originally posted by @noib3 in https://github.com/noib3/nvim-cokeline/issues/55#issuecomment-1086947224
This is the best interim solution for Nvim-Tree issues. Open for PRs.
Related #44

Same problem, nvim-tree now requires a custom function to properly handle closing a buffer and focusing on the appropriate window. We need to hook that custom function to the close button cokeline provides.
function delete_curr_buffer()
	local cbn = vim.api.nvim_get_current_buf()
	local buffers = vim.fn.getbufinfo({ buflisted = true })
	local size = 0
	local idx = 0
	for n, e in ipairs(buffers) do
		size = size + 1
		if e.bufnr == cbn then
			idx = n
		end
	end

	if idx == 0 then return end

	if idx == size then
		vim.cmd("bprevious")
	else
		vim.cmd("bnext")
	end
	vim.cmd("bdelete " .. cbn)
end

Does this still need resolving?

on_click event will be in soon, current work in #106


Do you have any suggestions for referencing the keyboard globally?(React)

React I want to click the input in the project to directly pop up the keyboard instead of introducing no components
Vue can be two-way binding

Hello @skyunBoss,
Here's an example of visibility toggling through onFocus and onBlur.
https://codesandbox.io/s/keen-einstein-ck99n?file=/src/index.tsx
Feel free to take this example and adapt it to your needs.
Regards,
Francisco Hodge


Refactor:Define a constant instead of duplicating this literal "mdi:c…

…ompass-outline" 12 times.

Breaking change

Proposed change

Type of change

[ ] Dependency upgrade
[ ] Bugfix (non-breaking change which fixes an issue)
[ ] New integration (thank you!)
[ ] New feature (which adds functionality to an existing integration)
[ ] Deprecation (breaking change to happen in the future)
[ ] Breaking change (fix/feature causing existing functionality to break)
[ ] Code quality improvements to existing code or addition of tests

Additional information

This PR fixes or closes issue: fixes #
This PR is related to issue:
Link to documentation pull request:

Checklist

[ ] The code change is tested and works locally.
[ ] Local tests pass. Your PR cannot be merged unless tests pass
[ ] There is no commented out code in this PR.
[ ] I have followed the development checklist
[ ] I have followed the perfect PR recommendations
[ ] The code has been formatted using Ruff (ruff format homeassistant tests)
[ ] Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

[ ] Documentation added/updated for www.home-assistant.io

If the code communicates with devices, web services, or third-party tools:

[ ] The manifest file has all fields filled out correctly.
Updated and included derived files by running: python3 -m script.hassfest.
[ ] New or updated dependencies have been added to requirements_all.txt.
Updated by running python3 -m script.gen_requirements_all.
[ ] For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.

To help with the load of incoming pull requests:

[ ] I have reviewed two other open pull requests in this repository.

This pull request addresses a code smell where the string literal "mdi:compass-outline" is duplicated multiple times in the code. Repeating string literals can lead to increased maintenance costs, as any changes to the string would need to be updated in multiple places, increasing the risk of errors or inconsistencies.
I have extracted the string literal "mdi:compass-outline" into a constant, ICON_COMPASS_OUTLINE. This constant is now used in all instances where the string was duplicated. By doing this, the code is made more maintainable, reducing duplication and the risk of future errors. This also makes it easier to update the icon in the future, as it only requires changing the constant definition.


[#1894] fix(server): Fix NPE caused by app not found issue

What changes were proposed in this pull request?
Fix the npe issue within shuffle server
Why are the changes needed?
Fix: #1894
Does this PR introduce any user-facing change?
No.
How was this patch tested?
Tested on our test cluster

Merged to master. Thanks @maobaolong @jerqi

@jerqi @rickyma Thanks for your review!