Wrong KeyId for digits on Windows with LogicalKeyboardKey.

Steps to Reproduce

Run this project on Windows Desktop : https://gist.github.com/gaetschwartz/7cf05a7907a1de9a4c28395a264e0897
Press a digit on your keyboard. Notice that the keyId seems to be added to 0x10700000000 when released.

Key
Expected code
Actual code

Digit1
0x31
0x10700000031

Digit2
0x32
0x10700000032

Digit3
0x33
0x10700000033

Logs

[√] Flutter (Channel dev, 1.26.0-17.1.pre, on Microsoft Windows [Version 10.0.19042.746], locale en-US)
    • Flutter version 1.26.0-17.1.pre at C:\Users\Gaetan\Developer\src\flutter
    • Framework revision c40e5294dd (4 days ago), 2021-01-29 08:44:18 -0800
    • Engine revision 5d3477eab4
    • Dart version 2.12.0 (build 2.12.0-259.0.dev)

[√] Android toolchain - develop for Android devices (Android SDK version 30.0.2)
    • Android SDK at C:\Users\Gaetan\AppData\Local\Android\sdk
    • Platform android-30, build-tools 30.0.2
    • Java binary at: C:\Program Files\Android\Android Studio\jre\bin\java
    • Java version OpenJDK Runtime Environment (build 11.0.8+10-b944.6842174)
    • All Android licenses accepted.

[√] Chrome - develop for the web
    • Chrome at C:\Program Files\Google\Chrome\Application\chrome.exe

[√] Visual Studio - develop for Windows (Visual Studio Community 2019 16.8.4)
    • Visual Studio at C:\Program Files (x86)\Microsoft Visual Studio\2019\Community
    • Visual Studio Community 2019 version 16.8.30907.101
    • Windows 10 SDK version 10.0.18362.0

[√] Android Studio (version 4.1.0)
    • Android Studio at C:\Program Files\Android\Android Studio
    • Flutter plugin can be installed from:
       https://plugins.jetbrains.com/plugin/9212-flutter
    • Dart plugin can be installed from:
       https://plugins.jetbrains.com/plugin/6351-dart
    • Java version OpenJDK Runtime Environment (build 11.0.8+10-b944.6842174)

[√] IntelliJ IDEA Community Edition (version 2020.3)
    • IntelliJ at C:\Program Files\JetBrains\IntelliJ IDEA Community Edition 2020.2.3
    • Flutter plugin can be installed from:
       https://plugins.jetbrains.com/plugin/9212-flutter
    • Dart plugin can be installed from:
       https://plugins.jetbrains.com/plugin/6351-dart

[√] Connected device (3 available)
    • Windows (desktop) • windows • windows-x64    • Microsoft Windows [Version 10.0.19042.746]
    • Chrome (web)      • chrome  • web-javascript • Google Chrome 88.0.4324.104
    • Edge (web)        • edge    • web-javascript • Microsoft Edge 88.0.705.50

• No issues found!

Analyzing flutter_application_3...
No issues found! (ran in 1.9s)

[  +60 ms] executing: [C:\Users\Gaetan\Developer\src\flutter/] git -c log.showSignature=false log -n 1 --pretty=format:%H
[  +55 ms] Exit code 0 from: git -c log.showSignature=false log -n 1 --pretty=format:%H
[        ] c40e5294dda34d04cd222dfdf765f171e12e4a8d
[        ] executing: [C:\Users\Gaetan\Developer\src\flutter/] git tag --points-at c40e5294dda34d04cd222dfdf765f171e12e4a8d
[  +51 ms] Exit code 0 from: git tag --points-at c40e5294dda34d04cd222dfdf765f171e12e4a8d
[        ] 1.26.0-17.1.pre
[  +31 ms] executing: [C:\Users\Gaetan\Developer\src\flutter/] git rev-parse --abbrev-ref --symbolic @{u}
[  +35 ms] Exit code 0 from: git rev-parse --abbrev-ref --symbolic @{u}
[        ] origin/dev
[        ] executing: [C:\Users\Gaetan\Developer\src\flutter/] git ls-remote --get-url origin
[  +33 ms] Exit code 0 from: git ls-remote --get-url origin
[        ] https://github.com/flutter/flutter.git
[  +58 ms] executing: [C:\Users\Gaetan\Developer\src\flutter/] git rev-parse --abbrev-ref HEAD
[  +33 ms] Exit code 0 from: git rev-parse --abbrev-ref HEAD
[        ] dev
[  +70 ms] Artifact Instance of 'AndroidGenSnapshotArtifacts' is not required, skipping update.
[        ] Artifact Instance of 'AndroidInternalBuildArtifacts' is not required, skipping update.
[        ] Artifact Instance of 'IOSEngineArtifacts' is not required, skipping update.
[        ] Artifact Instance of 'FlutterWebSdk' is not required, skipping update.
[   +2 ms] Artifact Instance of 'WindowsEngineArtifacts' is not required, skipping update.
[  +15 ms] Artifact Instance of 'MacOSEngineArtifacts' is not required, skipping update.
[  +18 ms] Artifact Instance of 'LinuxEngineArtifacts' is not required, skipping update.
[        ] Artifact Instance of 'LinuxFuchsiaSDKArtifacts' is not required, skipping update.
[   +1 ms] Artifact Instance of 'MacOSFuchsiaSDKArtifacts' is not required, skipping update.
[   +6 ms] Artifact Instance of 'FlutterRunnerSDKArtifacts' is not required, skipping update.
[   +7 ms] Artifact Instance of 'FlutterRunnerDebugSymbols' is not required, skipping update.
[  +55 ms] executing: C:\Users\Gaetan\AppData\Local\Android\sdk\platform-tools\adb.exe devices -l
[  +34 ms] List of devices attached
[   +4 ms] Artifact Instance of 'AndroidGenSnapshotArtifacts' is not required, skipping update.
[        ] Artifact Instance of 'AndroidInternalBuildArtifacts' is not required, skipping update.
[        ] Artifact Instance of 'IOSEngineArtifacts' is not required, skipping update.
[   +5 ms] Downloading Web SDK...
[ +290 ms] Content https://storage.googleapis.com/flutter_infra/flutter/5d3477eab415fbcc3d58624b07f0a768f8208f98/flutter-web-sdk-windows-x64.zip md5 hash: lFj6OMDddFHNFFVhbP7aQg==
[+2705 ms] Downloading Web SDK... (completed in 2,986ms)
[+2943 ms] Artifact Instance of 'MacOSEngineArtifacts' is not required, skipping update.
[        ] Artifact Instance of 'LinuxEngineArtifacts' is not required, skipping update.
[        ] Artifact Instance of 'LinuxFuchsiaSDKArtifacts' is not required, skipping update.
[        ] Artifact Instance of 'MacOSFuchsiaSDKArtifacts' is not required, skipping update.
[        ] Artifact Instance of 'FlutterRunnerSDKArtifacts' is not required, skipping update.
[        ] Artifact Instance of 'FlutterRunnerDebugSymbols' is not required, skipping update.
[  +56 ms] Multiple devices found:
[  +17 ms] Windows (desktop) • windows • windows-x64    • Microsoft Windows [Version 10.0.19042.746]
[        ] Chrome (web)      • chrome  • web-javascript • Google Chrome 88.0.4324.104
[        ] Edge (web)        • edge    • web-javascript • Microsoft Edge 88.0.705.50
[        ] [1]: Windows (windows)
[        ] [2]: Chrome (chrome)
[        ] [3]: Edge (edge)
[   +1 ms] Please choose one (To quit, press "q/Q")
[        ] :
[+105570 ms] 1
[   +9 ms] Skipping pub get: version match.
[  +91 ms] Generating C:\Users\Gaetan\Developer\Projects\flutter_application_3\android\app\src\main\java\io\flutter\plugins\GeneratedPluginRegistrant.java
[  +61 ms] Initializing file store
[   +8 ms] Skipping target: gen_localizations
[   +8 ms] complete
[   +2 ms] Launching lib\main.dart on Windows in debug mode...
[   +3 ms] C:\Users\Gaetan\Developer\src\flutter\bin\cache\dart-sdk\bin\dart.exe --disable-dart-dev
C:\Users\Gaetan\Developer\src\flutter\bin\cache\artifacts\engine\windows-x64\frontend_server.dart.snapshot --sdk-root
C:\Users\Gaetan\Developer\src\flutter\bin\cache\artifacts\engine\common\flutter_patched_sdk/ --incremental --target=flutter --debugger-module-names
--experimental-emit-debug-metadata -DFLUTTER_WEB_AUTO_DETECT=true --output-dill C:\Users\Gaetan\AppData\Local\Temp\flutter_tools.555bdf95\flutter_tool.4cf7b720\app.dill --packages
C:\Users\Gaetan\Developer\Projects\flutter_application_3\.dart_tool\package_config.json -Ddart.vm.profile=false -Ddart.vm.product=false --enable-asserts --track-widget-creation
--filesystem-scheme org-dartlang-root --initialize-from-dill build\c075001b96339384a97db4862b8ab8db.cache.dill.track.dill
[  +31 ms] executing: C:\Program Files (x86)\Microsoft Visual Studio\Installer\vswhere.exe -format json -products * -utf8 -latest -version 16 -requires
Microsoft.VisualStudio.Workload.NativeDesktop Microsoft.VisualStudio.Component.VC.Tools.x86.x64 Microsoft.VisualStudio.Component.VC.CMake.Project
[  +30 ms] Exit code 0 from: C:\Program Files (x86)\Microsoft Visual Studio\Installer\vswhere.exe -format json -products * -utf8 -latest -version 16 -requires
Microsoft.VisualStudio.Workload.NativeDesktop Microsoft.VisualStudio.Component.VC.Tools.x86.x64 Microsoft.VisualStudio.Component.VC.CMake.Project
[        ] [
             {
               "instanceId": "ddb775c4",
               "installDate": "2020-11-02T08:35:49Z",
               "installationName": "VisualStudio/16.8.4+30907.101",
               "installationPath": "C:\\Program Files (x86)\\Microsoft Visual Studio\\2019\\Community",
               "installationVersion": "16.8.30907.101",
               "productId": "Microsoft.VisualStudio.Product.Community",
               "productPath": "C:\\Program Files (x86)\\Microsoft Visual Studio\\2019\\Community\\Common7\\IDE\\devenv.exe",
               "state":<PHONE_NUMBER>,
               "isComplete": true,
               "isLaunchable": true,
               "isPrerelease": false,
               "isRebootRequired": false,
               "displayName": "Visual Studio Community 2019",
               "description": "Powerful IDE, free for students, open-source contributors, and individuals",
               "channelId": "VisualStudio.16.Release",
               "channelUri": "https://aka.ms/vs/16/release/channel",
               "enginePath": "C:\\Program Files (x86)\\Microsoft Visual Studio\\Installer\\resources\\app\\ServiceHub\\Services\\Microsoft.VisualStudio.Setup.Service",
               "releaseNotes": "https://go.microsoft.com/fwlink/?LinkId=660893#16.8.4",
               "thirdPartyNotices": "https://go.microsoft.com/fwlink/?LinkId=660909",
               "updateDate": "2021-01-28T11:54:16.6785795Z",
               "catalog": {
                 "buildBranch": "d16.8",
                 "buildVersion": "16.8.30907.101",
                 "id": "VisualStudio/16.8.4+30907.101",
                 "localBuild": "build-lab",
                 "manifestName": "VisualStudio",
                 "manifestType": "installer",
                 "productDisplayVersion": "16.8.4",
                 "productLine": "Dev16",
                 "productLineVersion": "2019",
                 "productMilestone": "RTW",
                 "productMilestoneIsPreRelease": "False",
                 "productName": "Visual Studio",
                 "productPatchVersion": "4",
                 "productPreReleaseMilestoneSuffix": "1.0",
                 "productSemanticVersion": "16.8.4+30907.101",
                 "requiredEngineVersion": "2.8.3267.30329"
               },
               "properties": {
                 "campaignId": "",
                 "channelManifestId": "VisualStudio.16.Release/16.8.4+30907.101",
                 "nickname": "",
                 "setupEngineFilePath": "C:\\Program Files (x86)\\Microsoft Visual Studio\\Installer\\vs_installershell.exe"
               }
             }
           ]
[  +19 ms] Building Windows application...
[  +12 ms] <- compile package:flutter_application_3/main.dart
[   +1 ms] executing: C:\Program Files (x86)\Microsoft Visual Studio\2019\Community\Common7\IDE\CommonExtensions\Microsoft\CMake\CMake\bin\cmake.exe -S
C:\Users\Gaetan\Developer\Projects\flutter_application_3\windows -B build\windows -G Visual Studio 16 2019
[  +58 ms] -- Selecting Windows SDK version 10.0.18362.0 to target Windows 10.0.19042.
[  +34 ms] -- Configuring done
[  +57 ms] -- Generating done
[   +3 ms] -- Build files have been written to: C:/Users/Gaetan/Developer/Projects/flutter_application_3/build/windows
[   +7 ms] executing: C:\Program Files (x86)\Microsoft Visual Studio\2019\Community\Common7\IDE\CommonExtensions\Microsoft\CMake\CMake\bin\cmake.exe --build build\windows --config
Debug --target INSTALL --verbose
[ +118 ms] Microsoft (R) Build Engine version 16.8.3+39993bd9d for .NET Framework
[   +1 ms] Copyright (C) Microsoft Corporation. All rights reserved.
[  +52 ms] Build started 02-Feb-21 20:40:20.
[ +218 ms] Project "C:\Users\Gaetan\Developer\Projects\flutter_application_3\build\windows\INSTALL.vcxproj" on node 1 (default targets).
[        ] Project "C:\Users\Gaetan\Developer\Projects\flutter_application_3\build\windows\INSTALL.vcxproj" (1) is building
"C:\Users\Gaetan\Developer\Projects\flutter_application_3\build\windows\ZERO_CHECK.vcxproj" (2) on node 1 (default targets).
[   +9 ms] InitializeBuildStatus:
[        ]   Creating "x64\Debug\ZERO_CHECK\ZERO_CHECK.tlog\unsuccessfulbuild" because "AlwaysCreate" was specified.
[  +17 ms] CustomBuild:
[   +2 ms]   All outputs are up-to-date.
[  +29 ms] FinalizeBuildStatus:
[        ]   Deleting file "x64\Debug\ZERO_CHECK\ZERO_CHECK.tlog\unsuccessfulbuild".
[        ]   Touching "x64\Debug\ZERO_CHECK\ZERO_CHECK.tlog\ZERO_CHECK.lastbuildstate".
[        ] Done Building Project "C:\Users\Gaetan\Developer\Projects\flutter_application_3\build\windows\ZERO_CHECK.vcxproj" (default targets).
[  +89 ms] Project "C:\Users\Gaetan\Developer\Projects\flutter_application_3\build\windows\INSTALL.vcxproj" (1) is building
"C:\Users\Gaetan\Developer\Projects\flutter_application_3\build\windows\ALL_BUILD.vcxproj" (3) on node 1 (default targets).
[        ] Project "C:\Users\Gaetan\Developer\Projects\flutter_application_3\build\windows\ALL_BUILD.vcxproj" (3) is building
"C:\Users\Gaetan\Developer\Projects\flutter_application_3\build\windows\runner\flutter_application_3.vcxproj" (4) on node 1 (default targets).
[        ] Project "C:\Users\Gaetan\Developer\Projects\flutter_application_3\build\windows\runner\flutter_application_3.vcxproj" (4) is building
"C:\Users\Gaetan\Developer\Projects\flutter_application_3\build\windows\flutter\flutter_assemble.vcxproj" (5) on node 1 (default targets).
[   +8 ms] InitializeBuildStatus:
[        ]   Creating "x64\Debug\flutter_assemble\flutter_assemble.tlog\unsuccessfulbuild" because "AlwaysCreate" was specified.
[        ] CustomBuild:
[        ]   "The build of 'C:\Users\Gaetan\Developer\Projects\flutter_application_3\build\windows\CMakeFiles\4bdb87ddef31ca86da4ef963de7853cb\flutter_assemble.rule' depends on
'C:\USERS\GAETAN\DEVELOPER\PROJECTS\FLUTTER_APPLICATION_3\WINDOWS\FLUTTER\EPHEMERAL\FLUTTER_WINDOWS.DLL' which is produced by the build of
'C:\Users\Gaetan\Developer\Projects\flutter_application_3\build\windows\CMakeFiles\3339c7d724da7bbac3964e1067c73a09\flutter_windows.dll.rule'. The items cannot be built in
parallel."
[  +65 ms]   Generating C:/Users/Gaetan/Developer/Projects/flutter_application_3/windows/flutter/ephemeral/flutter_windows.dll,
C:/Users/Gaetan/Developer/Projects/flutter_application_3/windows/flutter/ephemeral/flutter_export.h,
C:/Users/Gaetan/Developer/Projects/flutter_application_3/windows/flutter/ephemeral/flutter_windows.h,
C:/Users/Gaetan/Developer/Projects/flutter_application_3/windows/flutter/ephemeral/flutter_messenger.h,
C:/Users/Gaetan/Developer/Projects/flutter_application_3/windows/flutter/ephemeral/flutter_plugin_registrar.h,
C:/Users/Gaetan/Developer/Projects/flutter_application_3/windows/flutter/ephemeral/flutter_texture_registrar.h,
C:/Users/Gaetan/Developer/Projects/flutter_application_3/windows/flutter/ephemeral/cpp_client_wrapper/core_implementations.cc,
C:/Users/Gaetan/Developer/Projects/flutter_application_3/windows/flutter/ephemeral/cpp_client_wrapper/standard_codec.cc,
C:/Users/Gaetan/Developer/Projects/flutter_application_3/windows/flutter/ephemeral/cpp_client_wrapper/plugin_registrar.cc,
C:/Users/Gaetan/Developer/Projects/flutter_application_3/windows/flutter/ephemeral/cpp_client_wrapper/flutter_engine.cc,
C:/Users/Gaetan/Developer/Projects/flutter_application_3/windows/flutter/ephemeral/cpp_client_wrapper/flutter_view_controller.cc, _phony_
[ +928 ms]   [  +56 ms] executing: [C:\Users\Gaetan\Developer\src\flutter/] git -c log.showSignature=false log -n 1 --pretty=format:%H
[  +52 ms]   [  +69 ms] Exit code 0 from: git -c log.showSignature=false log -n 1 --pretty=format:%H
[        ]   [        ] c40e5294dda34d04cd222dfdf765f171e12e4a8d
[        ]   [        ] executing: [C:\Users\Gaetan\Developer\src\flutter/] git tag --points-at c40e5294dda34d04cd222dfdf765f171e12e4a8d
[  +50 ms]   [  +50 ms] Exit code 0 from: git tag --points-at c40e5294dda34d04cd222dfdf765f171e12e4a8d
[        ]   [        ] 1.26.0-17.1.pre
[  +30 ms]   [  +31 ms] executing: [C:\Users\Gaetan\Developer\src\flutter/] git rev-parse --abbrev-ref --symbolic @{u}
[  +44 ms]   [  +43 ms] Exit code 0 from: git rev-parse --abbrev-ref --symbolic @{u}
[   +1 ms]   [        ] origin/dev
[        ]   [        ] executing: [C:\Users\Gaetan\Developer\src\flutter/] git ls-remote --get-url origin
[  +36 ms]   [  +38 ms] Exit code 0 from: git ls-remote --get-url origin
[        ]   [        ] https://github.com/flutter/flutter.git
[  +69 ms]   [  +69 ms] executing: [C:\Users\Gaetan\Developer\src\flutter/] git rev-parse --abbrev-ref HEAD
[  +41 ms]   [  +41 ms] Exit code 0 from: git rev-parse --abbrev-ref HEAD
[        ]   [        ] dev
[  +68 ms]   [  +68 ms] Artifact Instance of 'AndroidGenSnapshotArtifacts' is not required, skipping update.
[        ]   [        ] Artifact Instance of 'AndroidInternalBuildArtifacts' is not required, skipping update.
[        ]   [        ] Artifact Instance of 'IOSEngineArtifacts' is not required, skipping update.
[        ]   [        ] Artifact Instance of 'FlutterWebSdk' is not required, skipping update.
[   +2 ms]   [   +3 ms] Artifact Instance of 'WindowsEngineArtifacts' is not required, skipping update.
[   +8 ms]   [        ] Artifact Instance of 'MacOSEngineArtifacts' is not required, skipping update.
[        ]   [        ] Artifact Instance of 'LinuxEngineArtifacts' is not required, skipping update.
[        ]   [        ] Artifact Instance of 'LinuxFuchsiaSDKArtifacts' is not required, skipping update.
[        ]   [        ] Artifact Instance of 'MacOSFuchsiaSDKArtifacts' is not required, skipping update.
[        ]   [        ] Artifact Instance of 'FlutterRunnerSDKArtifacts' is not required, skipping update.
[        ]   [        ] Artifact Instance of 'FlutterRunnerDebugSymbols' is not required, skipping update.
[  +36 ms]   [  +46 ms] Artifact Instance of 'MaterialFonts' is not required, skipping update.
[        ]   [        ] Artifact Instance of 'GradleWrapper' is not required, skipping update.
[   +2 ms]   [        ] Artifact Instance of 'AndroidGenSnapshotArtifacts' is not required, skipping update.
[        ]   [        ] Artifact Instance of 'AndroidInternalBuildArtifacts' is not required, skipping update.
[        ]   [        ] Artifact Instance of 'IOSEngineArtifacts' is not required, skipping update.
[        ]   [        ] Artifact Instance of 'FlutterWebSdk' is not required, skipping update.
[        ]   [        ] Artifact Instance of 'FlutterSdk' is not required, skipping update.
[        ]   [        ] Artifact Instance of 'WindowsEngineArtifacts' is not required, skipping update.
[        ]   [        ] Artifact Instance of 'MacOSEngineArtifacts' is not required, skipping update.
[        ]   [        ] Artifact Instance of 'LinuxEngineArtifacts' is not required, skipping update.
[        ]   [        ] Artifact Instance of 'LinuxFuchsiaSDKArtifacts' is not required, skipping update.
[        ]   [        ] Artifact Instance of 'MacOSFuchsiaSDKArtifacts' is not required, skipping update.
[        ]   [        ] Artifact Instance of 'FlutterRunnerSDKArtifacts' is not required, skipping update.
[        ]   [        ] Artifact Instance of 'FlutterRunnerDebugSymbols' is not required, skipping update.
[        ]   [        ] Artifact Instance of 'IosUsbArtifacts' is not required, skipping update.
[        ]   [        ] Artifact Instance of 'IosUsbArtifacts' is not required, skipping update.
[   +1 ms]   [        ] Artifact Instance of 'IosUsbArtifacts' is not required, skipping update.
[   +8 ms]   [        ] Artifact Instance of 'IosUsbArtifacts' is not required, skipping update.
[        ]   [        ] Artifact Instance of 'IosUsbArtifacts' is not required, skipping update.
[        ]   [        ] Artifact Instance of 'FontSubsetArtifacts' is not required, skipping update.
[        ]   [        ] Artifact Instance of 'PubDependencies' is not required, skipping update.
[  +44 ms]   [  +60 ms] Initializing file store
[  +17 ms]   [  +17 ms] Skipping target: gen_localizations
[   +5 ms]   [   +5 ms] unpack_windows: Starting due to {}
[ +179 ms]   [ +178 ms] kernel_snapshot: Starting due to {}
[   +2 ms]   [   +2 ms] unpack_windows: Complete
[+2284 ms]   [+2283 ms] C:\Users\Gaetan\Developer\src\flutter\bin\cache\dart-sdk\bin\dart.exe --disable-dart-dev
C:\Users\Gaetan\Developer\src\flutter\bin\cache\artifacts\engine\windows-x64\frontend_server.dart.snapshot --sdk-root
C:\Users\Gaetan\Developer\src\flutter\bin\cache\artifacts\engine\common\flutter_patched_sdk/ --target=flutter --no-print-incremental-dependencies
-DFLUTTER_WEB_AUTO_DETECT\Users\Gaetan\Developer\Projects\flutter_application_3\.dart_tool\package_config.json -Ddart.vm.profile=false -Ddart.vm.product=false --enable-asserts
--packages C:\Users\Gaetan\Developer\Projects\flutter_application_3\.dart_tool\package_config.json --output-dill
C:\Users\Gaetan\Developer\Projects\flutter_application_3\.dart_tool\flutter_build\ba02bbffb1729791b34b1162fd8c0579\app.dill --depfile
C:\Users\Gaetan\Developer\Projects\flutter_application_3\.dart_tool\flutter_build\ba02bbffb1729791b34b1162fd8c0579\kernel_snapshot.d package:flutter_application_3/main.dart
[+5478 ms]   [+5479 ms] kernel_snapshot: Complete
[ +357 ms]   [ +357 ms] debug_bundle_windows_assets: Starting due to {}
[  +89 ms]   [  +89 ms] debug_bundle_windows_assets: Complete
[ +346 ms]   [ +346 ms] Persisting file store
[   +7 ms]   [   +7 ms] Done persisting file store
[   +5 ms]   [   +5 ms] build succeeded.
[   +6 ms]   [   +6 ms] "flutter assemble" took 8,921ms.
[  +62 ms]   [  +62 ms] ensureAnalyticsSent: 59ms
[   +1 ms]   [   +1 ms] Running shutdown hooks
[        ]   [        ] Shutdown hooks complete
[        ]   [        ] exiting with code 0
[  +71 ms] FinalizeBuildStatus:
[        ]   Deleting file "x64\Debug\flutter_assemble\flutter_assemble.tlog\unsuccessfulbuild".
[        ]   Touching "x64\Debug\flutter_assemble\flutter_assemble.tlog\flutter_assemble.lastbuildstate".
[        ] Done Building Project "C:\Users\Gaetan\Developer\Projects\flutter_application_3\build\windows\flutter\flutter_assemble.vcxproj" (default targets).
[  +27 ms] Project "C:\Users\Gaetan\Developer\Projects\flutter_application_3\build\windows\runner\flutter_application_3.vcxproj" (4) is building
"C:\Users\Gaetan\Developer\Projects\flutter_application_3\build\windows\flutter\flutter_wrapper_app.vcxproj" (6) on node 1 (default targets).
[        ] InitializeBuildStatus:
[        ]   Creating "flutter_wrapper_app.dir\Debug\flutter_.5A207A0A.tlog\unsuccessfulbuild" because "AlwaysCreate" was specified.
[   +1 ms] CustomBuild:
[        ]   All outputs are up-to-date.
[  +32 ms] ClCompile:
[        ]   All outputs are up-to-date.
[  +16 ms] Lib:
[        ]   All outputs are up-to-date.
[        ]   flutter_wrapper_app.vcxproj -> C:\Users\Gaetan\Developer\Projects\flutter_application_3\build\windows\flutter\Debug\flutter_wrapper_app.lib
[  +18 ms] FinalizeBuildStatus:
[        ]   Deleting file "flutter_wrapper_app.dir\Debug\flutter_.5A207A0A.tlog\unsuccessfulbuild".
[        ]   Touching "flutter_wrapper_app.dir\Debug\flutter_.5A207A0A.tlog\flutter_wrapper_app.lastbuildstate".
[        ] Done Building Project "C:\Users\Gaetan\Developer\Projects\flutter_application_3\build\windows\flutter\flutter_wrapper_app.vcxproj" (default targets).
[   +5 ms] InitializeBuildStatus:
[        ]   Touching "flutter_application_3.dir\Debug\flutter_.24C1CE9C.tlog\unsuccessfulbuild".
[   +1 ms] CustomBuild:
[        ]   All outputs are up-to-date.
[  +22 ms] ClCompile:
[        ]   C:\Program Files (x86)\Microsoft Visual Studio\2019\Community\VC\Tools\MSVC\14.28.29333\bin\HostX64\x64\CL.exe /c
/IC:\Users\Gaetan\Developer\Projects\flutter_application_3\windows /IC:\Users\Gaetan\Developer\Projects\flutter_application_3\windows\flutter\ephemeral
/IC:\Users\Gaetan\Developer\Projects\flutter_application_3\windows\flutter\ephemeral\cpp_client_wrapper\include /Zi /nologo /W4 /WX /diagnostics:column /Od /Ob0 /D WIN32 /D _WINDOWS/D _HAS_EXCEPTIONS=0 /D _DEBUG /D NOMINMAX /D UNICODE /D _UNICODE /D "CMAKE_INTDIR=\"Debug\"" /D _UNICODE /D UNICODE /Gm- /EHsc /RTC1 /MDd /GS /fp:precise /Zc:wchar_t /Zc:forScope
/Zc:inline /GR /std:c++17 /Fo"flutter_application_3.dir\Debug\\" /Fd"flutter_application_3.dir\Debug\vc142.pdb" /Gd /TP /wd4100 /errorReport:queue
C:\Users\Gaetan\Developer\Projects\flutter_application_3\windows\flutter\generated_plugin_registrant.cc
C:\Users\Gaetan\Developer\Projects\flutter_application_3\windows\runner\flutter_window.cpp
[  +74 ms]   generated_plugin_registrant.cc
[ +359 ms]   flutter_window.cpp
[ +598 ms]   Generating Code...
[  +67 ms] ResourceCompile:
[        ]   All outputs are up-to-date.
[  +22 ms] Link:
[  +13 ms]   C:\Program Files (x86)\Microsoft Visual Studio\2019\Community\VC\Tools\MSVC\14.28.29333\bin\HostX64\x64\link.exe /ERRORREPORT:QUEUE
/OUT:"C:\Users\Gaetan\Developer\Projects\flutter_application_3\build\windows\runner\Debug\flutter_application_3.exe" /INCREMENTAL /NOLOGO ..\flutter\Debug\flutter_wrapper_app.lib
C:\Users\Gaetan\Developer\Projects\flutter_application_3\windows\flutter\ephemeral\flutter_windows.dll.lib kernel32.lib user32.lib gdi32.lib winspool.lib shell32.lib ole32.lib
oleaut32.lib uuid.lib comdlg32.lib advapi32.lib /MANIFEST /MANIFESTUAC:"level='asInvoker' uiAccess='false'" /manifest:embed
/manifestinput:C:\Users\Gaetan\Developer\Projects\flutter_application_3\windows\runner\runner.exe.manifest /DEBUG
/PDB:"C:/Users/Gaetan/Developer/Projects/flutter_application_3/build/windows/runner/Debug/flutter_application_3.pdb" /SUBSYSTEM:WINDOWS /TLBID:1 /DYNAMICBASE /NXCOMPAT
/IMPLIB:"C:/Users/Gaetan/Developer/Projects/flutter_application_3/build/windows/runner/Debug/flutter_application_3.lib" /MACHINE:X64  /machine:x64
flutter_application_3.dir\Debug\Runner.res
[   +1 ms]   flutter_application_3.dir\Debug\flutter_window.obj
[        ]   flutter_application_3.dir\Debug\main.obj
[        ]   flutter_application_3.dir\Debug\run_loop.obj
[        ]   flutter_application_3.dir\Debug\utils.obj
[        ]   flutter_application_3.dir\Debug\win32_window.obj
[        ]   flutter_application_3.dir\Debug\generated_plugin_registrant.obj
[ +151 ms]   flutter_application_3.vcxproj -> C:\Users\Gaetan\Developer\Projects\flutter_application_3\build\windows\runner\Debug\flutter_application_3.exe
[   +5 ms] FinalizeBuildStatus:
[  +10 ms]   Deleting file "flutter_application_3.dir\Debug\flutter_.24C1CE9C.tlog\unsuccessfulbuild".
[        ]   Touching "flutter_application_3.dir\Debug\flutter_.24C1CE9C.tlog\flutter_application_3.lastbuildstate".
[        ] Done Building Project "C:\Users\Gaetan\Developer\Projects\flutter_application_3\build\windows\runner\flutter_application_3.vcxproj" (default targets).
[  +18 ms] Project "C:\Users\Gaetan\Developer\Projects\flutter_application_3\build\windows\ALL_BUILD.vcxproj" (3) is building
"C:\Users\Gaetan\Developer\Projects\flutter_application_3\build\windows\flutter\flutter_wrapper_plugin.vcxproj" (7) on node 1 (default targets).
[  +21 ms] InitializeBuildStatus:
[  +25 ms]   Creating "flutter_wrapper_plugin.dir\Debug\flutter_.48B2457A.tlog\unsuccessfulbuild" because "AlwaysCreate" was specified.
[   +1 ms] CustomBuild:
[        ]   All outputs are up-to-date.
[        ] ClCompile:
[        ]   All outputs are up-to-date.
[        ] Lib:
[        ]   All outputs are up-to-date.
[  +14 ms]   flutter_wrapper_plugin.vcxproj -> C:\Users\Gaetan\Developer\Projects\flutter_application_3\build\windows\flutter\Debug\flutter_wrapper_plugin.lib
[  +13 ms] FinalizeBuildStatus:
[  +14 ms]   Deleting file "flutter_wrapper_plugin.dir\Debug\flutter_.48B2457A.tlog\unsuccessfulbuild".
[        ]   Touching "flutter_wrapper_plugin.dir\Debug\flutter_.48B2457A.tlog\flutter_wrapper_plugin.lastbuildstate".
[        ] Done Building Project "C:\Users\Gaetan\Developer\Projects\flutter_application_3\build\windows\flutter\flutter_wrapper_plugin.vcxproj" (default targets).
[        ] InitializeBuildStatus:
[        ]   Creating "x64\Debug\ALL_BUILD\ALL_BUILD.tlog\unsuccessfulbuild" because "AlwaysCreate" was specified.
[        ] CustomBuild:
[        ]   All outputs are up-to-date.
[        ] FinalizeBuildStatus:
[        ]   Deleting file "x64\Debug\ALL_BUILD\ALL_BUILD.tlog\unsuccessfulbuild".
[        ]   Touching "x64\Debug\ALL_BUILD\ALL_BUILD.tlog\ALL_BUILD.lastbuildstate".
[        ] Done Building Project "C:\Users\Gaetan\Developer\Projects\flutter_application_3\build\windows\ALL_BUILD.vcxproj" (default targets).
[        ] InitializeBuildStatus:
[        ]   Creating "x64\Debug\INSTALL\INSTALL.tlog\unsuccessfulbuild" because "AlwaysCreate" was specified.
[  +17 ms] PostBuildEvent:
[  +12 ms]   setlocal
[        ]   "C:\Program Files (x86)\Microsoft Visual Studio\2019\Community\Common7\IDE\CommonExtensions\Microsoft\CMake\CMake\bin\cmake.exe" -DBUILD_TYPE=Debug -P
cmake_install.cmake
[  +14 ms]   if %errorlevel% neq 0 goto :cmEnd
[        ]   :cmEnd
[        ]   endlocal & call :cmErrorLevel %errorlevel% & goto :cmDone
[  +14 ms]   :cmErrorLevel
[        ]   exit /b %1
[        ]   :cmDone
[        ]   if %errorlevel% neq 0 goto :VCEnd
[        ]   :VCEnd
[  +22 ms]   -- Install configuration: "Debug"
[   +9 ms]   -- Up-to-date: C:/Users/Gaetan/Developer/Projects/flutter_application_3/build/windows/runner/Debug/data/icudtl.dat
[        ]   -- Up-to-date: C:/Users/Gaetan/Developer/Projects/flutter_application_3/build/windows/runner/Debug/flutter_windows.dll
[   +5 ms]   -- Installing: C:/Users/Gaetan/Developer/Projects/flutter_application_3/build/windows/runner/Debug/data/flutter_assets
[   +1 ms]   -- Installing: C:/Users/Gaetan/Developer/Projects/flutter_application_3/build/windows/runner/Debug/data/flutter_assets/AssetManifest.json
[  +25 ms]   -- Installing: C:/Users/Gaetan/Developer/Projects/flutter_application_3/build/windows/runner/Debug/data/flutter_assets/FontManifest.json
[  +13 ms]   -- Installing: C:/Users/Gaetan/Developer/Projects/flutter_application_3/build/windows/runner/Debug/data/flutter_assets/fonts
[        ]   -- Installing: C:/Users/Gaetan/Developer/Projects/flutter_application_3/build/windows/runner/Debug/data/flutter_assets/fonts/MaterialIcons-Regular.otf
[        ]   -- Installing: C:/Users/Gaetan/Developer/Projects/flutter_application_3/build/windows/runner/Debug/data/flutter_assets/kernel_blob.bin
[  +54 ms]   -- Installing: C:/Users/Gaetan/Developer/Projects/flutter_application_3/build/windows/runner/Debug/data/flutter_assets/NOTICES
[   +2 ms]   -- Installing: C:/Users/Gaetan/Developer/Projects/flutter_application_3/build/windows/runner/Debug/data/flutter_assets/packages
[  +13 ms]   -- Installing: C:/Users/Gaetan/Developer/Projects/flutter_application_3/build/windows/runner/Debug/data/flutter_assets/packages/cupertino_icons
[        ]   -- Installing: C:/Users/Gaetan/Developer/Projects/flutter_application_3/build/windows/runner/Debug/data/flutter_assets/packages/cupertino_icons/assets
[        ]   -- Installing:
C:/Users/Gaetan/Developer/Projects/flutter_application_3/build/windows/runner/Debug/data/flutter_assets/packages/cupertino_icons/assets/CupertinoIcons.ttf
[  +39 ms] FinalizeBuildStatus:
[  +12 ms]   Deleting file "x64\Debug\INSTALL\INSTALL.tlog\unsuccessfulbuild".
[  +13 ms]   Touching "x64\Debug\INSTALL\INSTALL.tlog\INSTALL.lastbuildstate".
[        ] Done Building Project "C:\Users\Gaetan\Developer\Projects\flutter_application_3\build\windows\INSTALL.vcxproj" (default targets).
[        ] Build succeeded.
[        ]     0 Warning(s)
[        ]     0 Error(s)
[        ] Time Elapsed 00:00:12.57
[   +1 ms] Building Windows application... (completed in 13.0s)
[ +276 ms] Observatory URL on device: http://<IP_ADDRESS>:65185/51MDfpXVrZk=/
[   +2 ms] Caching compiled dill
[  +34 ms] Connecting to service protocol: http://<IP_ADDRESS>:65185/51MDfpXVrZk=/
[  +85 ms] Launching a Dart Developer Service (DDS) instance at http://<IP_ADDRESS>:0, connecting to VM service at http://<IP_ADDRESS>:65185/51MDfpXVrZk=/.
[  +49 ms] DDS is listening at http://<IP_ADDRESS>:65190/dtkeDCCgPxU=/.
[  +40 ms] Successfully connected to service protocol: http://<IP_ADDRESS>:65185/51MDfpXVrZk=/
[  +15 ms] Activating Dart DevTools...
[+5653 ms] flutter: 0x31
[  +87 ms] flutter: 0x10700000031

Hi @gaetschwartz
Thanks for filing the issue, you're correct, the actual code is different compared to mac or web but it seems to change fast from 0x31 to 0x10700000031 when pressing 1 on the keyboard on windows.  (this might be a regression)

code sample
/// Flutter code sample for LogicalKeyboardKey
import 'package:flutter/foundation.dart';
import 'package:flutter/material.dart';
import 'package:flutter/scheduler.dart';
import 'package:flutter/services.dart';

void main() {
  runApp(MyApp());
}

/// This is the main application widget.
class MyApp extends StatelessWidget {
  static const String _title = 'Flutter Code Sample';

  @override
  Widget build(BuildContext context) {
    return MaterialApp(
      title: _title,
      home: Scaffold(
        appBar: AppBar(title: const Text(_title)),
        body: MyStatefulWidget(),
      ),
    );
  }
}

/// This is the stateful widget that the main application instantiates.
class MyStatefulWidget extends StatefulWidget {
  MyStatefulWidget({Key key}) : super(key: key);

  @override
  _MyStatefulWidgetState createState() => _MyStatefulWidgetState();
}

/// This is the private State class that goes with MyStatefulWidget.
class _MyStatefulWidgetState extends State<MyStatefulWidget> {
  // The node used to request the keyboard focus.
  final FocusNode _focusNode = FocusNode();
// The message to display.
  String _message;

// Focus nodes need to be disposed.
  @override
  void dispose() {
    _focusNode.dispose();
    super.dispose();
  }

// Handles the key events from the RawKeyboardListener and update the
// _message.
  void _handleKeyEvent(RawKeyEvent event) {
    setState(() {
      _message = (event.isControlPressed ? 'CTRL + ' : '') +
          "0x" +
          event.logicalKey.keyId.toRadixString(16) +
          '\n' +
          event.logicalKey.toString();
    });
    print("0x" + event.logicalKey.keyId.toRadixString(16));
  }

  @override
  Widget build(BuildContext context) {
    final TextTheme textTheme = Theme.of(context).textTheme;
    return Container(
      color: Colors.white,
      alignment: Alignment.center,
      child: DefaultTextStyle(
        style: textTheme.headline4,
        child: RawKeyboardListener(
          focusNode: _focusNode,
          onKey: _handleKeyEvent,
          child: AnimatedBuilder(
            animation: _focusNode,
            builder: (BuildContext context, Widget child) {
              if (!_focusNode.hasFocus) {
                return GestureDetector(
                  onTap: () {
                    FocusScope.of(context).requestFocus(_focusNode);
                  },
                  child: const Text('Tap to focus'),
                );
              }
              return Text(_message ?? 'Press a key');
            },
          ),
        ),
      ),
    );
  }
}

Windows Preview

flutter doctor -v
[âˆš] Flutter (Channel master, 1.26.0-18.0.pre.156, on Microsoft Windows [Version 10.0.19042.746], locale en-US)
    â€¢ Flutter version 1.26.0-18.0.pre.156 at C:\Users\Taha\Code\flutter_master
    â€¢ Framework revision 45508985b1 (6 hours ago), 2021-02-02 22:46:04 -0500
    â€¢ Engine revision 2c144c3eeb
    â€¢ Dart version 2.12.0 (build 2.12.0-282.0.dev)
[âˆš] Android toolchain - develop for Android devices (Android SDK version 30.0.3)
    â€¢ Android SDK at C:\Users\Taha\Code\SDK
    â€¢ Platform android-30, build-tools 30.0.3
    â€¢ ANDROID_HOME = C:\Users\Taha\Code\SDK
    â€¢ Java binary at: C:\Users\Taha\Code\android-studio\jre\bin\java
    â€¢ Java version OpenJDK Runtime Environment (build 1.8.0_242-release-1644-b01)
    â€¢ All Android licenses accepted.
[âˆš] Chrome - develop for the web
    â€¢ Chrome at C:\Program Files\Google\Chrome\Application\chrome.exe
[âˆš] Visual Studio - develop for Windows (Visual Studio Community 2019 16.8.3)
    â€¢ Visual Studio at C:\Program Files (x86)\Microsoft Visual Studio\2019\Community
    â€¢ Visual Studio Community 2019 version 16.8.30804.86
    â€¢ Windows 10 SDK version 10.0.18362.0
[âˆš] Android Studio (version 4.1.0)
    â€¢ Android Studio at C:\Users\Taha\Code\android-studio
    â€¢ Flutter plugin can be installed from:
       https://plugins.jetbrains.com/plugin/9212-flutter
    â€¢ Dart plugin can be installed from:
       https://plugins.jetbrains.com/plugin/6351-dart
    â€¢ Java version OpenJDK Runtime Environment (build 1.8.0_242-release-1644-b01)
[âˆš] VS Code (version 1.52.1)
    â€¢ VS Code at C:\Users\Taha\AppData\Local\Programs\Microsoft VS Code
    â€¢ Flutter extension version 3.19.0
[âˆš] Connected device (3 available)
    â€¢ Windows (desktop) â€¢ windows â€¢ windows-x64    â€¢ Microsoft Windows [Version 10.0.19042.746]
    â€¢ Chrome (web)      â€¢ chrome  â€¢ web-javascript â€¢ Google Chrome 88.0.4324.104
    â€¢ Edge (web)        â€¢ edge    â€¢ web-javascript â€¢ Microsoft Edge 88.0.705.53
â€¢ No issues found!

Mac Preview

flutter doctor -v
[✓] Flutter (Channel master, 1.26.0-18.0.pre.156, on macOS 11.1 20C69 darwin-x64, locale en-GB)
    • Flutter version 1.26.0-18.0.pre.156 at /Users/tahatesser/Code/flutter_master
    • Framework revision 45508985b1 (3 hours ago), 2021-02-02 22:46:04 -0500
    • Engine revision 2c144c3eeb
    • Dart version 2.12.0 (build 2.12.0-282.0.dev)

[✓] Android toolchain - develop for Android devices (Android SDK version 30.0.3)
    • Android SDK at /Volumes/Extreme/SDK
    • Platform android-30, build-tools 30.0.3
    • ANDROID_HOME = /Volumes/Extreme/SDK
    • Java binary at: /Applications/Android Studio.app/Contents/jre/jdk/Contents/Home/bin/java
    • Java version OpenJDK Runtime Environment (build 1.8.0_242-release-1644-b3-6915495)
    • All Android licenses accepted.

[✓] Xcode - develop for iOS and macOS
    • Xcode at /Volumes/Extreme/Xcode.app/Contents/Developer
    • Xcode 12.4, Build version 12D4e
    • CocoaPods version 1.10.1

[✓] Chrome - develop for the web
    • Chrome at /Applications/Google Chrome.app/Contents/MacOS/Google Chrome

[✓] Android Studio (version 4.1)
    • Android Studio at /Applications/Android Studio.app/Contents
    • Flutter plugin can be installed from:
      :hammer: https://plugins.jetbrains.com/plugin/9212-flutter
    • Dart plugin can be installed from:
      :hammer: https://plugins.jetbrains.com/plugin/6351-dart
    • Java version OpenJDK Runtime Environment (build 1.8.0_242-release-1644-b3-6915495)

[✓] VS Code (version 1.52.1)
    • VS Code at /Applications/Visual Studio Code.app/Contents
    • Flutter extension version 3.19.0

[✓] Connected device (2 available)
    • macOS (desktop) • macos  • darwin-x64     • macOS 11.1 20C69 darwin-x64
    • Chrome (web)    • chrome • web-javascript • Google Chrome 88.0.4324.96

• No issues found!

Thank you

This will probably be solved with the ongoing https://github.com/flutter/engine/pull/23465 .

@TahaTesser Indeed, because the right keyId is output when the key is pressed but a different one is once the key is released.

As of latest (43c81ff) this problem is no longer reproducible.


TypeError in types/options.d.ts

I'm getting an Error at Version 3.0.0-beta.16
Type 'keyof T' does not satisfy the constraint 'string'.
  Type 'string | number | symbol' is not assignable to type 'string'.
    Type 'number' is not assignable to type 'string'.
    4 | // include Omit type from https://github.com/Microsoft/TypeScript/issues/12215
    5 | type Diff<T extends string, U extends string> = ({ [P in T]: P } & { [P in U]: never } & { [x: string]: never })[T];
  > 6 | type Omit<T, K extends keyof T> = { [P in Diff<keyof T, K>]?: T[P] };
      |                                                ^
    7 |
    8 | type ApolloVueThisType<V> = V & { [key: string]: any };
    9 | type VariableFn<V> = ((this: ApolloVueThisType<V>) => Object) | Object;

I've had to revert back to version 3.0.0-alpha.2 to get things to build again, but that's basically because 3.0.0-alpha.3 introduced TypeScript definitions to this library. I'm not sure why it's failing only now, because I had built my app with 3.0.0-beta.5 and it was working; now it's breaking even when I revert back to 3.0.0-beta.5. This smells like some dependency of vue-apollo recently got updated that caused things to break.

This compiles without the error:
type Diff<T extends string, U extends string> = ({ [P in T]: P } & { [P in U]: never } & { [x: string]: never })[T];
type Omit<T, K extends keyof T> = { [P in Diff<keyof T, K>]?: T[P] };

let x:Omit<{a:string, b: number},'b'> = {
  a: 'test'
}

I think I see what's new... TypeScript 2.9 recently came out, and has breaking changes:
https://github.com/Microsoft/TypeScript/wiki/Breaking-Changes#keyof-now-includes-string-number-and-symbol-keys

If I change options.d.ts from
type Diff<T extends string, U extends string> = ({ [P in T]: P } & { [P in U]: never } & { [x: string]: never })[T];
type Omit<T, K extends keyof T> = { [P in Diff<keyof T, K>]?: T[P] };

to
type Diff<T extends string, U extends string> = ({ [P in T]: P } & { [P in U]: never } & { [x: string]: never })[T];
type Omit<T, K extends keyof T> = { [P in Diff<Extract<keyof T, string>, Extract<K, string>>]?: T[P] };

or
type Property = string | number | symbol;
type Diff<T extends Property, U extends Property> = ({ [P in T]: P } & { [P in U]: never } & { [x: string]: never })[T];
type Omit<T, K extends keyof T> = { [P in Diff<keyof T, K>]?: T[P] };

then the build passes.
I'll put in a PR; most likely it will be the latter change.


Added --geojson flag for geojson output.

E.g. dji-log-parser log.txt --geojson path.geojson --output records.json. Converts the geographic coordinates in the OSD records to a GeoJSON LineString, and outputs a geojson file.

I was thinking the same thing after seeing some paths that consist of thousands of points but actually only cover a few centimeters. I've experimented with the Ramer-Douglas-Peucker algorithm on log paths and it worked well. Maybe I'll add that today.

Oh, it will be great!

@wiseman did you also have a patch that adds GPS Lat / Lon to the extracted images as an EXIF header?

ope, never mind. Looks like that was just added yesterday: https://github.com/lvauvillier/dji-log-parser/commit/9b54ba821e39e9bd3d0bab65267517c99a354f4c


injectBaseStyles cannot be false

It's impossible to disable base style injection because any falsey value will always result in true.
const injectBaseStyles = options["injectBaseStyles"] || true;

src/js/Luminous.js#70
I'd do a one line fix but I think the entire options object block should be refactored to something more modern-like.
E.g.
// ES2015 Object.assign
this.settings = Object.assign({}, defaults, options)

// OR object spread
this.settings = { ...defaults, ...options }

// Or some day in the far future
const injectBaseStyles = options["injectBaseStyles"] ?? true;

this is still an issue today. the fix did not end up in Master so it seems.

Hi @andrejcremoznik @Lefthandmedia, sorry for the extreme delay but the fix for this issue is now released in v2.3.3 🎉


Replacing recent posts by about.md page

I changed config file to
# Defaults
defaults:
  # _posts
  - scope:
      path: ""
      type: pages #posts
    values:
      layout: single
      author_profile: true
      # read_time: true
      # comments: # true
      # share: true
      # related: true

and index.html to
---
<!-- layout: home -->
author_profile: true
permanentlink: /_pages/about.md
---

and I added about.md in _pages
---
title:  "Welcome to Jekyll!"
---

# Welcome

Recent posts disappeared when I committed layout: home but I can't see about.md content in the page.

Your issue is a Jekyll one and not the theme. You need to properly set the permalink for your about.md page
I see you're using permanentlink: /_pages/about.md in the YAML Front Matter. I have no idea what permanentlink is but I don't think it is valid for Jekyll.
What you need to do is delete index.html since that's what is used for the home page and shows the recent posts.
Then you have several choices on how to convert your about.md page into the home page.

Move _pages/about.md to the root of your project and rename it to index.md
Leave the page where it is and add permalink: / to it's Front Matter so Jekyll outputs it at the root of the site e.g. /index.html

I left index.html in the root and added this :
---
layout: single
author_profile: true
permalink: /
---

Still the page is not appearing

That's the issue. The index page doesn't have the content of your about.md page.
Either copy that content into index.html or rename your about.md page accordingly.
The index.html page isn't going to pull content from your about.md page no matter what you do. That's not how Jekyll works.

about.md exist in _pages/about.md
What should I call it then ?

Just do what I suggested above.

Delete index.html
Rename _pages/about.md to index.md and move it in the root of your project (the same place you had index.html)

Or you can keep it where it is and add permalink: / to about.md
Then Jekyll will convert that page to /index.html
If you don't add the permalink it will just convert it to a .html file using the filename you have e.g. about.html

https://jekyllrb.com/docs/permalinks/#front-matter


[Kernel] Adds current azk bin folder to the PATH

This PR adds the current azk bin folder to the PATH.
This is useful when you have more than one azk bin in your machine and want to be sure which one you are running.
Plus, the code hot swap present in azk agent API has been disabled by default and can be turned on by setting env var AZK_AGENT_HOTSWAP=true

very good :+1:


adjusted wallet balance error

Related Issue
To answer issue #647
Work Done
Adjusted the error message to inform the farmer that 100 TFT is required in the wallet.

@Mik-TF I updated the error msg and set the minimum required balance to 50 TFT


Add jdk replacement for PingPerf Test

Add PingPerf test jdk replacement
Related Issue: git_ibm/runtimes/backlog/issues/989

Test link:
hyc_jenkins/grinder 31100
Following output shows the new jdk version:
13:59:29  STEP 26/29: RUN /opt/java/openjdk/bin/java  --version
13:59:30  openjdk 11.0.18-internal 2023-01-17
13:59:30  OpenJDK Runtime Environment (build 11.0.18-internal+0-adhoc..BuildJDK11x86-64linuxNightly)
13:59:30  Eclipse OpenJ9 VM (build master-711ca6c, JRE 11 Linux amd64-64-Bit Compressed References 20230215_486 (JIT enabled, AOT enabled)
13:59:30  OpenJ9   - 711ca6c
13:59:30  OMR      - 6adea03
13:59:30  JCL      - 77de8f8 based on jdk-11.0.18+10)


Update index.yml

update ask questions to Q&A
update request features to Ideas forum

Docs Build status updates of commit eb61651:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

docs/onenote/index.yml
:white_check_mark:Succeeded
View

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching the docs.microsoft.com contributor guidesPost your question in the Docs support channel


Getting started guide doesn't work on macOS

Bug:

What happened:
I tried the "Getting Started with the Ansible Service Broker" document here on my Mac:
https://github.com/openshift/ansible-service-broker#getting-started-with-the-ansible-service-broker
What you expected to happen:
Being able to start a local OpenShift cluster with ASB enabled.
How to reproduce it:
Try this on a Mac:
wget https://raw.githubusercontent.com/openshift/ansible-service-broker/master/scripts/run_latest_build.sh
chmod +x run_latest_build.sh
./run_latest_build.sh

More details:

Command ip doesn't exist on a Mac: https://github.com/openshift/ansible-service-broker/blob/master/scripts/run_latest_build.sh#L36
I modified the file manually to solve this problem.

@aliok can you provide the command you used on mac?


Exporting to unreal stops 3d preview from updating when changing nodes values.

When I export to unreal the 3d view permanently stops respoding to changes in values of some nodes like Tones Range.To fix it either unplug and plug in back some node, change one of the values that forces screen refresh like blending mode in blend node. or restart Material Maker. By the way 3d view still works, rotates and all. It is just that it stops reacting to values input changes.
1.0 on win 10

same with export to godot


Deleting tags without deleting the image

Hello, in my company we have a private registry (v2) and we use tags to determine the latest version of running applications.  Thus it's possible for an image to have several tags.  Is it possible through the API to untag an image without deleting the underlying image.  I've searched the API and so far all I found is:
DELETE /v2//manifests/
Which deletes the image and all tags associated with it, while in many cases I just want to remove one tag.
If an API endpoint isn't available can it be added.
thanks

when delete via
/v2/{0}/manifests/{1}
{0} - image name
{1} - digest for tagged image

@Oleksii-Terekhov : Could you or someone else elaborate on that please?
I wonder what digest you mean exactly...
let's say you push  two tags for the same image:
docker tag localregistry:5000/vltest/zoombie:1.0 localregistry:5000/vltest/zoombie:latest
docker push localregistry:5000/vltest/zoombie:latest
docker push localregistry:5000/vltest/zoombie:1.0

If you next try to get the digest for those two tags, you will get the exact same value in the Docker-Content-Digest HTTP header:
GET http://localregistry:5000/v2/vltest/zoombie/manifests/latest with header Accept: application/vnd.docker.distribution.manifest.v2+json
GET http://localregistry:5000/v2/vltest/zoombie/manifests/1.0 with header Accept: application/vnd.docker.distribution.manifest.v2+json

in short - digest - string like "sha256:3f6952b193ece0b3b3f63e3d888f5a572fa095723a11535e08c42ecc50733435"
we use python:
`
class Registry:
def init(self, host, username, password):
self.hostname = host
self.username = username
self.password = password
def send(self, path, method="GET"):
    result = requests.request(
        method, "{0}{1}".format(self.hostname, path),
        headers={"Accept": "application/vnd.docker.distribution.manifest.v2+json"},
        auth=(self.username, self.password))
    if 200 <= result.status_code <= 299:
        return result
    else:
        raise ValueError('Request error #%s -> %s at url %s' % (result.status_code, result.text,  path))

def list_images(self):
    result = self.send('/v2/_catalog')
    return json.loads(result.text)['repositories']

def list_tags(self, image_name):
    result = self.send("/v2/{0}/tags/list".format(image_name))
    return json.loads(result.text)['tags']

def get_tag_digest(self, image_name, tag_name):
    image_headers = self.send("/v2/{0}/manifests/{1}".format(
        image_name, tag_name), method="HEAD")
    return image_headers.headers['Docker-Content-Digest']

def delete_image_by_digest(self, image_name, tag_digest):
    self.send("/v2/{0}/manifests/{1}".format(image_name, tag_digest), method="DELETE")

`

It looks to me like you are doing the exact same thing as me. And I can assure you, that does not only delete the tag.

Not correct I am afraid. I think you miss the point that it removes the image and all it's associated tags.
So, if you want to delete old/unused/unwanted images - you MUST:

Pull all the GOOD images and tags you want to keep
Delete the tags you no longer need
Loop over catalogue and check if any of the GOOD tags also was deleted. If so :

push those images back to the registry with the tags you wanted to keep

So my conclusion is that this issue report is indeed valid

#1811 is pretty related and describes the root of this issue. My company is running into this as well.
I believe that two tags will only have the same digest if they have the same content. If, for whatever reason, you push the same image content twice but with a different tag each time (as @vidarl  mentioned in comment 3), they will have the same digest. The API does not support deleting just one of those tags. It will delete both.

Currently the only API call for deleting is to delete the entire image manifest, which results in all tags also being deleted. There been discussion on improving the tag APIs in OCI distribution-spec. Until something like that makes it into the spec and then implemented in registries, I'm hacking around this in regclient by pushing a temporary unique manifest to the tag and then delete that unique manifest.

Currently the only API call for deleting is to delete the entire image manifest, which results in all tags also being deleted. There been discussion on improving the tag APIs in OCI distribution-spec. Until something like that makes it into the spec and then implemented in registries, I'm hacking around this in regclient by pushing a temporary unique manifest to the tag and then delete that unique manifest.

This is not implemented in 2.8.1, but implementation is merged in main. #3427


Setup second test case for radiosity.

We determine the form factor between two unit squares that are
perpendicular to each other. The form factor has to be symmetrical and
can be determined analytically.

Coverage remained the same at 53.935% when pulling 1153eb7160a81f30bcbc60367dc6dd9125322f86 on karsten/test-radiosity-90-degrees into 6c1dd65272bed5a267b632f6ff0be788264bc382 on hierarchical.

Coverage remained the same at 53.935% when pulling 1153eb7160a81f30bcbc60367dc6dd9125322f86 on karsten/test-radiosity-90-degrees into 6c1dd65272bed5a267b632f6ff0be788264bc382 on hierarchical.

Coverage increased (+1.0%) to 54.922% when pulling 5582a46a86f077b715d61a220683db5c32b73cc3 on karsten/test-radiosity-90-degrees into 6c1dd65272bed5a267b632f6ff0be788264bc382 on hierarchical.


Update search page styles

https://trello.com/c/lu1zDbsy/267-2-are-we-ready-to-migrate-buyer-frontend-to-govuk-frontend-v3
Simplifying styles on the search pages in preparation of migration to DS3. This was a slightly trickier one to extricate from the migration branch, and has impacted functional tests: https://github.com/alphagov/digitalmarketplace-functional-tests/pull/818

My review checklist
I've:

[ ] looked at the code
[ ] tested locally
[ ] run functional tests locally


sha256sum files incompatable with shasum -c

As implemented by Generate .sha256sum files for release artifacts the resulting .sha256sum files do not meet the requirements of macOS's shasum -c / --check nor the corresponding option in Linux's shasum and sha256sum commands. Currently the sha256sum files contain absolute paths like /{Users,home}/runner/work/just/just/dist/just-$VERSION-$TARGET.tar.gz which will not exist for users wanting to easily verify downloads' hash values.
Since the bin/package  script does a cd $DIST before generating the hash value, a suggested fix is rather than
shasum -a 256 $ARCHIVE > $ARCHIVE.sha256sum
to use shell parameter expansion to remove $DIST from the beginning of the full $ARCHIVE path:
shasum -a 256 ${ARCHIVE#$DIST/} > $ARCHIVE.sha256sum
I've minimally tested that and it seems to do the right thing so that shasum --check *.sha256sum and sha256sum --check *.sha256sum verify the corresponding tar.gz's hash when both are downloaded into the same directory, as is likely typical of most users. To eliminate any user confusion on Windows I suggest doing the same for that target's sha256sum file as well, assuming certutil won't know what to do about the */d/a/just/just/dist/ path in the corresponding sha256sum file.

This was actually fixed in #2358, but I haven't done another release since. Just released 1.36.0, which has correct shasum files with relative paths:
https://github.com/casey/just/releases/tag/1.36.0

Just a heads up for anyone using the shasum files: In #2417 I changed the release workflow to generate a single SHA256SUM file, instead of a .shas56sum file for each artifact. So for upcoming releases, you'll need to download the SHA256SUM file, and run shasum -a 256 -c SHA256SUM --ignore-missing.


update twitter to 5.16 and http to 1.0 fixes security issue

https://github.com/sferik/twitter/issues/672

@mapopa Thanks for the PR! I saw I never pushed the commits belonging to v4.4.1. Sorry about that.

Looks like the build is failing on the public_suffix addition. It requires Ruby 2.1, so it fails on 2.0. I wouldn't want to drop 2.0 support without bumping a major version. Which is what v5 is for. Anyway way around this or can we not merge this fix?

Support for 2.0 has ended https://www.ruby-lang.org/en/news/2016/02/24/support-plan-of-ruby-2-0-0-and-2-1/

In fact even 2.2 is EOL https://www.ruby-lang.org/en/news/2018/06/20/support-of-ruby-2-2-has-ended/

We shouldn't drop Ruby versions in minor/patch releases on the v4 branch. Only drop Ruby versions on the v5/master branch (next major version).
Would we still need to upgrade twitter here then if the build is unfixable?


[Browsing]: Evaluate browsing agents using WebArena

What problem or use case are you trying to solve?
Once we have implemented a browser agent (#1470), we will want to perform evaluation to make sure that it works.
Do you have thoughts on the technical implementation?
To do so, we can use an existing benchmark like WebArena, which is implemented through BrowserGym.
We are incorporating BrowserGym (#1452 #1469 #1470), but once that is done, we can also implement evaluation and perform evaluation of our agents. This could either be done:

by adding OpenDevin support to the BrowserGym evaluation platform
in a separate repo
in this repo
(roughly in order of my personal preference)

Describe alternatives you've considered
Additional context
Blocked by #1452 #1469 #1470

Now that this issue can be implemented, I wonder if the order of your personal preference has changed since then? Do we put the evaluation procedure in this repo?

I don't have a strong preference, so maybe we should follow the convention of SWE-Bench?

Done by @frankxu2004 , thanks!


Gitlab package

Could you please create a package for gitlab?
The code base is located here: https://gitlab.com/gitlab-org/charts/gitlab/-/tree/master/doc/.vale/gitlab

This is something that needs to be maintained by GitLab.


Remove uses of Fatalf which causes the application to quit if a custom logger is provided such as Uber zap

Uber zap's logger does os.Exit() if Fatal() or Fatalf() is called. Since go-ping supports custom loggers and in my case I pass in Uber zap's logger this causes my entire application to exit. Removing Fatal() calls is safer. If we need to ensure this error is handled up the call chain we can panic() which is better since the code can recover from a panic. The code cannot recover from an os.Exit() call.

See https://github.com/go-ping/ping/pull/226


invisible text divs from another page show up on page 2 and following

Link to PDF file (or attach file here):
Configuration:

Web browser and its version: Chrome Version 51.0.2704.36 beta (64-bit)
Operating system and its version: Mac OS X El Capitan 10.11.3 (15D21)
PDF.js version: online version as of May 22, 2016
Is an extension:

Steps to reproduce the problem:

move cursor over the top of page 2, you'll "see" there are non-visible text divs around the page that do not correspond to any displayed text
it becomes hard to select text from the actual text
reach.pdf

What is the expected behavior? (add screenshot)
not being able to select text other than what's visible text
What went wrong? (add screenshot)
text from another page was selectable.
Link to a viewer (if hosted on a site other than mozilla.github.io/pdf.js or as Firefox/Chrome extension):

I see the same problem with Adobe Viewer and Mac OS X Preview. @ldenoue can you explain what we do different?

true, but it's still a strange behavior. The text is not visible and yet it is selectable.
not optimum for extracting text from pdfs :)

@ldenoue by design, PDF can contain the hidden text and it shall be selectable. Hidden text was designed to be under/over the scanned images, but it can be used anywhere.

ok, thanks.
do you know how I could detect that it is not drawn so I can exclude it from the text items returned by getTextContent?

we cannot disable that for the reason that it can be used for scanned images, but you can check what getTextContent is doing and discard text when TextRenderingMode.INVISIBLE is set. Closing the issue as invalid/answered.


CF create-service xsuaa not able to read xs-security.json file

Hello,
I am getting below error while creating XSUAA service instance using xs-security.json file.

Without using -c xs-security.json file , service instance is getting created.

using -c .\xs-security.json file is also not working.

Regards,
Romil A.

Are you in a folder that has a file named xs-security.json?  And do you have correct JSON in this file. The command output is saying it doesn't like the file (my first thought was the path to it), but it could also be indicating a missing file or one with bad JSON in it as well.

Yes, my folder contains xs-security.json file in the same path.

Yes, my folder contains xs-security.json file in the same path.

"xsappname": "myhanaapp2",
    "tenant-mode": "dedicated",
    "description": "Security profile of called application",

Thank you, Thomas for your valuable reply.
Probably something was wrong with the content of my previous file, but not sure what.
I just deleted the xs-security.json file and recreated using the command and it worked fine.
Regards,
Romil A.


Improve Calculator Page UI

I believe that this page can be made to look better by using a different hover property for calculators than underline. Please assign me this issue.

@diyabhandari go ahead

thanks !


[BACKLOG-35709] ConCat Step generates a java.lang.NullPointerException

:white_check_mark: Build finished in 19m 40s
Build command:
mvn clean verify -B -e -Daudit -amd -pl engine,plugins/core/impl

:exclamation: No tests found!
:information_source:  This is an automatic message


[v6] Improve Ignore context

Information
Currently, all module use ConverterServices.serialize. The goal is to give an extra option to know where this method is used. This extra option will be forwarded to Ignore decorator and let developer to know who code serialize his object.
Describe the solution you'd like
class User {
  @Name("id")
  _id: string;

  @Property()
  firstName: string;

  @Property()
  lastName: string;

  @Ignore((value, ctx) => ctx.endpoint) // should not serialized when the object is returned by an endpoint.
  password: string;

  @Ignore((value, ctx) => ctx.mongoose) // should be serialized when the object is returned by an endpoint.
  scopes: string[];

  @Ignore()
  alwaysIgnored: string;
}

For example, with the given User model, password must not serialized by the json-mapper.
To validate the scenario add integration test in this file: https://github.com/TypedProject/tsed/blob/beta/packages/platform-test-utils/src/tests/testResponse.ts#L97
  @Get("/scenario10/:id")
  public testScenario10(@PathParams("id") id: string): string {
     const user = new User();

     user._id = id;
     user.lastName = "lastName";
     user.firstName = "firstName";
     user.password = "password";
     user.scopes = ["admin"];
     user.alwaysIgnored = "alwaysIgnored"

     return user;
  }

Expected:
describe("Scenario10: Model serialization", () => {
  it("should ignore password when a User instance is serialized", () => {
        const response = await request.get("/rest/response/scenario10/1").expect(400);

        expect(response.body).to.deep.equal({
            id: "1",
            lastName: "lastName",
           firstName: "firstName",
           scopes: "scopes"
        });
  })
})

The serialization is performed here for the endpoint: https://github.com/TypedProject/tsed/blob/beta/packages/common/src/platform/services/PlatformHandler.ts#L236
All extra properties given to ConverterService.serialize will be forward to the ctx parameter (cf: @Ignore((value, ctx: JsonHookContext) => ctx.endpoint) /).
Ctx Mapping
In addition, these information must be available in the ctx to allow more advanced usage:

IgnoreContext
Mapping
Description

endpoint
endpoint
The endpoint metadata which contains all info of the current handler

url
ctx.request.url
The current request url

method
ctx.request.method
The current request method "GET", "POST", etc...

Acceptance criteria

[ ] Properties are correctly ignored when the callback match with the JsonHookContext,
[ ] Integration cover the different scenario described in the issue.

Next issues
This issue allow to start the following issues: #808

Could you give me any information about this line, please?
@Ignore((value, ctx) => !ctx.mongoose)

Sure :) Let write more details on the issue ;)

@Ryan-Willpower I think the issue is correctly described now ;)

I think I will try on this task. But I have to learn about the codebase first.

Sure :)
You have to start your branch from beta instead of production ;)

Hello @Ryan-Willpower,
Do you working on it?
See you
Romain

Can it be done at the endpoint level? For the same field - you may want to return the field for some endpoint, but want to ignore for some other.
Also, I'm using services to call mongoose DB -> parse data and return to endpoint function -> endpoint function is doing some other parsing or call some other services and sending the response.
Will the converter take care of ignoring inside the service?

@IARKI  For the endpoint level, this is the following issue #808
Mongoose doesn't use the serializer, it's pretty different in this case. The JsonSchema is used by @tsed/mongoose to create Mongoose schema. Ignore isn't correctly implemented at this level.
But the goal is to improve the Ignore decorator to have a control on the serialized properties depending on the context where the serialization function is used (endpoint, mongoose, etc...).


Support multiple run server configurations

The proposal is something similar to maven-publish that you could have a bunch of different tasks for multiple servers setups.
This allows Monorepo projects for a big network project to setup different types of servers, plugins, modules and configurations.

This should already be possible by configuring your own RunServerTasks, can see a basic example here.
The main thing to note when doing this is that you'll need to add plugin jars to the pluginJars ConfigurableFileCollection yourself, as run-paper won't know about tasks you register on your own.

@jpenilla there is any special function built in the run-paper that you use the get the pluginJars your self that you could expose it publicly?

Nothing special really, it just checks for shadowJar and then jar in that order, and if one is found it's added to pluginJars.
See https://github.com/jpenilla/run-paper/blob/db26283992da89a3486d8edd7c325ca53e1196fe/src/main/kotlin/xyz/jpenilla/runpaper/task/RunServerTask.kt#L323-L328 and https://github.com/jpenilla/run-paper/blob/db26283992da89a3486d8edd7c325ca53e1196fe/src/main/kotlin/xyz/jpenilla/runpaper/RunPaper.kt#L44-L54
I don't think resolvePluginJarTask is something I would like to expose to the API as it's an implementation detail which can change, and does change in the open PR for paperweight-userdev integration.

That make sense, thanks :D


Discussion: Naming scheme for storage of data

Related to the overall discussions on naming schemes, what are some thoughts on naming of saved raw data (and maybe related to that, the parquet files too)? What's the file and folder naming path we should use?

During our discussion meeting, we agreed to look into this more and for me to make a draft of how this might look. This is related to #485 and so will close this in favour of that issue.


eval format

Currently Livepack supports js, esm, cjs formats + exec option.
Input:
export default function fn() {}

Outputs:

Format
Output

js
function fn() {}

esm
export default function fn() {}

cjs
module.exports = function fn() {}

js format is a JS expression which can be inserted in other code e.g. prepended with const f = ....
js is an output format rather than an extra option (like exec) as it implies CommonJS output. import statements cannot be included in an expression.
What's missing?
If code is intended to be eval()-ed it needs to be wrapped in (...) by the user. eval('function fn() {}') returns undefined, as eval() interprets function fn() {} as a function declaration not an expression. eval('(function fn() {})') returns the function as expected.
Where the output needs to include statements, Livepack's output in JS format wraps it in an IIFE. e.g.:
// Input
export default const x = {};
x.x = x;

// JS format output
( () => {
  const x = {};
  x.x = x;
  return x;
} )()

eval format
eval format would return code which can be put directly into eval.
i.e. in first example, function would be already wrapped in (...).
It can also dispense with the IIFE. 2nd example would be output as:
// Eval format output
const x = {};
x.x = x;
x;

Like js format, eval implies CommonJS since import statements cannot be used within eval().
Implications for tests
Tests are currently check JS-format output. So many tests have to include (()=>{...})() boiler plate.
If tests could run against eval-format output, this would make the tests a bit terser.
Also, js format output could be optimized in future (#119). Switching tests to use eval format would avoid that change making the tests harder to read.

This could also be implemented as an outputType option (see #121).

Option name script would be better than eval.


IE9 Upload and FileAPI

Hi Everyone,
I have an issue on the upload feature on ie9
The context :
Front  : Angular js
Back :  JAVA EE
The front side send the file with a REST post service, everything it's ok on IE 10, chrome, etc
I have added the FileAPI files (js + flash) to allow ie9 to manage file thanks to flash
The problem is when i try to get the inputstream on java side
There is the code :
`
@POST
@Path("/add/crs/{IdSuivi}")
@Consumes(MediaType.MULTIPART_FORM_DATA)
@Produces(MediaType.APPLICATION_JSON + ";charset=utf-8")
public Response addDocument(InputStream uploadedInputStream, @PathParam("IdSuivi") int IdSuivi,  @QueryParam("filename") String filename){
	Gson gson = new Gson();
	JsonParser parser = new JsonParser();
	try{
		byte[] bytes = IOUtils.toByteArray(uploadedInputStream);
                    ...
	} catch (IOException tfe) {
                   ...
	}

`
My problem is that on IE9, the inputstream contains the object flash file :
{flashId: "fileapi14563029716892", id: "1456303002854801", name: "test.txt", size: 31, type: "text/plain"}
instead of the file content
Angular js code :
"file" represent the Object send by the ng-file-upload library
this.upload = function (file) {

	uploadDoc(file, file.name, self.trackingFile.idTracking )
	.success(function(res){
           ....
	})
	.error(function(error, status){
          .....
	});
}

this.uploadDoc = function uploadDoc(file,filename,idSuivi) {

var url = baseUrl + urls.addDoc + "/" + idSuivi;
  var req = {
	method: 'POST',
	url: url,
	headers: {
		'Content-Type': 'multipart/form-data'
	},
	params: {'filename': filename},
	data : file
  }

   return $http(req);
}

Can you create a jsfiddle for your js code part

Change it to {..., data: {file: file}} it should be an object containing the file not the file itself. Also remove the content-type header.
Follow the jsfiddle or demo code.


Closes #72, fixed supertest's request.head() webhook check invocation

Just 2 things in this PR:

A simple fix to supertest's req.head() call
Some changes in test/mailinSpec.js to check it's working.

Item 1 is a no-brainer, but item 2 should arise some discussion. From my point of view, the specs are mixing unit and integration tests, which makes testing very difficult. I'm not happy with the way I changed mailinSpec.js at all, but I couldn't find a more simple and elegant solution. Do you see any other way to do it?

@mefernandez awesome. Could you please merge master into this one to allow Travis to run? I just fixed the .travis.ymlfile.

@Flolagale Done. Seems Travis is passing tests Ok.


ARTEMIS-228 accept binary WebSocket frames

I made one small optional modification to the test.. during the merge of this


Add unit tests for dynamic/serviceprincipal, azureclient/environments, clusterauthorizer

Which issue this PR addresses:
https://github.com/Azure/ARO-RP/issues/1593

Fixes
Cleanup and separate test cases in serviceprincipalchecker_test.go
What this PR does / why we need it:
ServicePrincipalChecker now accepts a function with the signature of aad.GetToken, allowing the use of the mocked GetToken function.
Added tests to azureclient/environments and clusterauthorizer that were previously in serviceprincipalchecker.
Add mock of dynamic service principal validator to prevent testing code outside of the service principal checker package.
serviceprincipal is tested by manually creating and modifying the service principal tokens.
Test plan for issue:

New unit tests are added to clusterauthorizer and serviceprincipalchecker packages.
run make test-go
Is there any documentation that needs to be updated for this PR?

No, only unit tests are added.

/azp run e2e

e2e is failing with a null pointer dereference, can you check that? @s-fairchild

@hawkowl Yes I'm looking into the e2e tests

@cadenmarchese Let me know what you think of my last commit, I was able to increase the coverage for the areas you pointed out. Thanks for sharing that cover function it's really helpful!

looks good :+1: can you squash your commits or do a fixup to have only a single one and then let's get this in


It doesn´t support back-tick symbol ( ) it is used in string template javascript.

Hi
It doesn´t support back-tick symbol ( ) it is used in string template javascript, my minify-compress process fail and .min get blank.
https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Template_literals
Thanks

Please read the readme file from the beginnging. Everything is written at this place. In short, there is no ES6 support for yuicompressor.

Thanks, maybe later it can be ES6 sintax support.

For the YUICompressor, In my opinion, I don't think so. This plugin is dependent from YUICompressor and when you follow the repo of it, it is kind of unmaintained. No real progress anymore. So the only option is to get rid of the errors. There is a PR from a contributor, where we can have a release soon, but this is only a workaround and will not solve the problem. Or should get rid of YUICompressor and use Google Closure compiler, which is to much work atm for me and not on my highest priority.

I tested it, with my new version 2.3.0.
Testcode:
let myvar = 'world';
const test = `blaaaa ${myvar}`;
var foo = `ola`;

Output:
'use strict';let myvar="world";const test=`blaaaa ${myvar}`;var foo="ola";

Will release the new version soon.


improve i18n

This app is awesome! :D
Improved some i18n strings for English

Thank you so much for your help :)


⚠ ClamAV has degraded performance

In bd22050, ClamAV (https://spamassassin.apache.org/) experienced degraded performance:

HTTP code: 200
Response time: 57 ms

Resolved: ClamAV performance has improved in a272763.


Improve Exception and Warning handling when using APP mode version

Consider implementing something similar to jupyter_turnkey_phonons in terms of catching Python Exceptions and Warnings, specifically for when using the APP mode version of this application.

This issue is no longer relevant for this repository, as it is solely considering Voilà, where this handling is already at the desired level.


Ignore hidden folders when running terragrunt hclfmt or at least provide an option to ignore paths

Copied from #2895
Describe the solution you'd like
A clear and concise description of what you want to happen.
Ignore hidden folders when running terragrunt hclfmt or at least provide an option to ignore paths.
Use cases:

Using .history folders which store many incomplete versions of terragrunt.hcl files that should not be evaluated
Storing temporary backups of files in .bak folders
Compatibility with any tool that needs to cache or backup terragrunt files in a hidden dir

Describe alternatives you've considered

bash alias to find all .history folders in terragrunt dir and rm-rf them. This is a brutal workaround and one I prefer to avoid
terragrunt hclfmt --terragrunt-exclude-dir '**/.history/*'  --terragrunt-exclude-dir '**/.history/**/*' --terragrunt-check
likely does not work because --terragrunt-exclude-dir only works with --run-all

Additional context
Being able to exclude paths for any terragrunt command including hclfmt seems like common sense to me. I feel I'm missing some obvious solution here. But I couldn't find it on my own.
Also, if you have other *.hcl files in your repository (for example, for Vault), that are under a different formatting regime, it would be very useful to be able to exclude folders.

This sounds completely reasonable.
I added a new label that will prevent this issue from going stale in the future once this PR is merged.
This is not a priority for the maintainers right now, so I'll also mark this issue as something we'd like community contributions to address.

hey @yhakbar
Could I ask for a quick review of #3609 ? I still need to update the documentation, but I just wanted to ensure the logic & naming of the parameters is correct.

hey @yhakbar
Could I ask for a quick review of #3609 ? I still need to update the documentation, but I just wanted to ensure the logic & naming of the parameters is correct.

I'm out until Monday. Please have patience until we can get to this!


feat: extend variable API

[x] Extend variable API
[x] Fix image max width

Resolves #35

Thanks 🙏


Unable to access azure functions from local application despite having correct access and directories.

Describe the bug
For work I am attempting to connect to run an azure function locally. I have all the necessary access and connection strings (confirmed with other colleagues whom can run the app properly) and yet I always get access errors. I've tried specifying the tenant and the subscription but it either refuses to use them or doesn't work anyway.
Related command
az login --tenant  --output none
az account set --subscription
func start
Errors
EventProcessorHost error (Action='Retrieving list of partition identifiers from a Consumer Client.', HostName='', PartitionId='').
[2023-08-14T14:21:25.236Z] Azure.Identity: Azure CLI authentication failed due to an unknown error. See the troubleshooting guide for more information. https://aka.ms/azsdk/net/identity/azclicredential/troubleshoot ERROR: AADSTS53003: Access has been blocked by Conditional Access policies. The access policy does not allow token issuance.
[2023-08-14T14:21:25.237Z]
[2023-08-14T14:21:25.239Z] Trace ID: 402e380e-582f-4f07-9da0-81811a45c900
[2023-08-14T14:21:25.240Z]
[2023-08-14T14:21:25.240Z] Correlation ID: e45c286d-5194-4472-a914-2d02e39142dc
[2023-08-14T14:21:25.241Z]
[2023-08-14T14:21:25.241Z] Timestamp: 2023-08-14 14:21:24Z
[2023-08-14T14:21:25.243Z] Interactive authentication is needed. Please run:
[2023-08-14T14:21:25.244Z] az login --scope https://eventhubs.azure.net/.default.
Issue script & Debug output
EventProcessorHost error (Action='Retrieving list of partition identifiers from a Consumer Client.', HostName='', PartitionId='').
[2023-08-14T14:21:25.236Z] Azure.Identity: Azure CLI authentication failed due to an unknown error. See the troubleshooting guide for more information. https://aka.ms/azsdk/net/identity/azclicredential/troubleshoot ERROR: AADSTS53003: Access has been blocked by Conditional Access policies. The access policy does not allow token issuance.
[2023-08-14T14:21:25.237Z]
[2023-08-14T14:21:25.239Z] Trace ID: 402e380e-582f-4f07-9da0-81811a45c900
[2023-08-14T14:21:25.240Z]
[2023-08-14T14:21:25.240Z] Correlation ID: e45c286d-5194-4472-a914-2d02e39142dc
[2023-08-14T14:21:25.241Z]
[2023-08-14T14:21:25.241Z] Timestamp: 2023-08-14 14:21:24Z
[2023-08-14T14:21:25.243Z] Interactive authentication is needed. Please run:
[2023-08-14T14:21:25.244Z] az login --scope https://eventhubs.azure.net/.default.
Expected behavior
The expected behaviour is to see a message about the service being successfully ran.
Environment Summary
azure-cli                         2.51.0
core                              2.51.0
telemetry                          1.1.0
Dependencies:
msal                            1.24.0b1
azure-mgmt-resource             23.1.0b2
Additional context
I have several azure directories and a couple of subscriptions that I think VS is defaulting to. I've tried specifying valid ones but it always fails

Thank you for opening this issue, we will look into it.

@muslmoha Can you please share your function code after removing any sensitive information ? Which Azure resource you are trying to access. Are you using "DefaultAzureCredential" for authentication?  Based on the error it looks like certain conditional access policy is blocking the sign-in.  You can refer to Troubleshooting sign-in problems with Conditional Access as well to trouble shoot this issue.

Hi,
Sorry for the wait, I've added a .txt with the event hub code, and no I'm using a local settings json that I was provided.
Best,
Mohammed

From: SaurabhSharma-MSFT @.>
Sent: August 15, 2023 3:17 PM
To: Azure/azure-cli @.>
Cc: Mohammed Musleh @.>; Mention @.>
Subject: Re: [Azure/azure-cli] Unable to access azure functions from local application despite having correct access and directories. (Issue #27166)
@muslmohahttps://github.com/muslmoha Can you please share your function code after removing any sensitive information ? Which Azure resource you are trying to access. Are you using "DefaultAzureCredential" for authentication? Based on the error it looks like certain conditional access policy is blocking the sign-in. You can refer to Troubleshooting sign-in problems with Conditional Accesshttps://docs.microsoft.com/en-us/azure/active-directory/conditional-access/troubleshoot-conditional-access as well to trouble shoot this issue.
—
Reply to this email directly, view it on GitHubhttps://github.com/Azure/azure-cli/issues/27166#issuecomment-1679466366, or unsubscribehttps://github.com/notifications/unsubscribe-auth/ALMTF4DSLEHIQB6LNRBZM73XVPDOJANCNFSM6AAAAAA3QAJZZQ.
You are receiving this because you were mentioned.Message ID: @.***>
[FunctionName("RetrieveJsonFile")]
public async Task RunAsync([EventHubTrigger("%RetrieveFileEventHubName%", Connection = "EventHubConnection")] EventData[] events)
{
this.logger.LogInformation($"Received events. Starting transcription retrieval.");

var exceptions = new List<Exception>();

foreach (EventData eventData in events)

{

    try

    {

        string reportFileName = JsonConvert.DeserializeObject<string>(eventData.EventBody.ToString());

        // Start redaction

        this.logger.LogInformation($"Redaction started for report '{reportFileName}'");

        await this.redactionRunner.PerformRedaction(reportFileName);

    }

    catch (Exception e)

    {

        // We need to keep processing the rest of the batch - capture this exception and continue.

        // Also, consider capturing details of the message that failed processing so it can be processed again later.

        exceptions.Add(e);

    }

    // Once processing of the batch is complete, if any messages in the batch failed processing throw an exception so that there is a record of the failure.

    if (exceptions.Count > 1)

    {

        throw new AggregateException(exceptions);

    }

    if (exceptions.Count == 1)

    {

        throw exceptions.Single();

    }

}

}

@muslmoha sorry but I don't this .txt file. Can you share the code over this GitHub issue.

@muslmoha We are still waiting for your response.  Please share the code if you are still having issues. Thanks.

@muslmoha We will now proceed to close this thread as we haven't heard back. If there are further questions regarding this matter, please reopen it and we will gladly continue the discussion.


Ignore lazy val when get public fields

Type of change: other enhancement

Impact: no functional change

Development Phase: implementation
Release Notes

Ignore lazy val fields when called getPublicFields method in generateComponent method.
Example
class Mux2(has_sel: Boolean) extends RawModule {
  lazy val sel = IO(Input(UInt(1.W))).suggestName("sel")
  val in0 = IO(Input(UInt(1.W)))
  val in1 = IO(Input(UInt(1.W)))
  val out = IO(Output(UInt(1.W)))

  if (has_sel) {
    sel
    out := (sel & in1) | (~sel & in0)
  }
  else
    out := in1 | in0
}

I want to use has_sel to configure whether to use sel input port.
Here are the result with/without val sel:
new Mux2(has_sel=true)
circuit Mux2 :
  module Mux2 :
    input in0 : UInt<1>
    input in1 : UInt<1>
    output out : UInt<1>
    input sel : UInt<1>

    node _T = and(sel, in1)
    node _T_1 = not(sel)
    node _T_2 = and(_T_1, in0)
    node _T_3 = or(_T, _T_2)
    out <= _T_3

new Mux2(has_sel=false)
ircuit Mux2 :
  module Mux2 :
    input in0 : UInt<1>
    input in1 : UInt<1>
    output out : UInt<1>

    node _T = or(in1, in0)
    out <= _T

How Do I Implement
I try to find the difference between val foo and lazy val foo, I add this code to debug
def getValNames(c: Class[_]): Set[String] = {
  if (c == rootClass) {
    Set()
  } else {
    c.getDeclaredFields foreach { x => println(s"$x -> ${x.getName}: ${x.getModifiers()}")}
    getValNames(c.getSuperclass) ++ c.getDeclaredFields.map(_.getName)
  }
 }

The difference is Modifiers: val foo has final modifier, and lazy val foo doesn't.
private chisel3.UInt custom.Mux2.sel -> sel: 2
private final chisel3.UInt custom.Mux2.in0 -> in0: 18
private final chisel3.UInt custom.Mux2.in1 -> in1: 18
private final chisel3.UInt custom.Mux2.out -> out: 18
private volatile boolean custom.Mux2.bitmap$0 -> bitmap$0: 66

I think Chisel3 should maintain the lazy val semantic, do not execute it unless user called it.

Does this make it such that you must .suggestName a lazy val to get a name?
I'm sympathetic to the idea that we shouldn't exercise lazy vals if the user doesn't, but as far as I know, it's not possible to check for that... So basically we're left with a tradeoff:

Exercise lazy vals even if the user never does, the work the same as vals for naming reasons (this is the current behavior)
Do not exercise lazy vals, effectively treating them like memoized defs. This is more consistent with the normal behavior of lazy val in Scala but is a break with past behavior.

If a user has side effects relying on the current behavior then (2) would subtly change that.


Simplify task configuration

Move everything except "Built resource to deploy" to advanced section
Signed-off-by: Mustafa Ulu<EMAIL_ADDRESS>

Adding before and after screeshots.


ForeignObjectComparison breaks when related model has custom primary key

Issue Summary
Comparing page revisions raises an exception when one of the changed fields is a ForeignKey to a model that uses a custom primary key (i.e. not id).
This looks very similar to #4180, but it's currently failing in 2.6.x.
Steps to Reproduce

Create a page model with a ForeignKey to a model with a custom primary key.
Add an initial revision with a value for the related model.
Add another revision changing the value of the related model.
Try to compare both revisions.
Uncaught exception error: FieldError: Cannot resolve keyword 'id' into field.

Expected: comparing revisions works correctly, displays the changed foreign key.
I haven't checked with a fresh Wagtail install, but the error happens on our production Wagtail.
Technical details

Python version: 3.7.3
Django version: 2.2.4
Wagtail version: 2.6.1

I have a fix ready, will add a regression test and send a PR.

Fixed in #5681


Update pr template

Monday ticket: https://torchbox.monday.com/boards/1192293412/views/6453316
Description of Changes Made
Update the MR template to reflect the needs of the new torchbox.com site
How to Test
Look at this merge request
Screenshots

Expand to see more

MR Checklist

[ ] Add a description of your pull request and instructions for the reviewer to verify your work.
[ ] If your pull request is for a specific ticket, link to it in the description.
[ ] Stay on point and keep it small so the merge request can be easily reviewed.
[ ] Tests and linting passes.

Unit tests

[ ] Not required
[ ] Added

Documentation

[ ] Updated

Browser testing

[ ] I have tested in the following browsers and environments:

Data protection

[ ] Not relevant
[ ] This adds new sources of PII and documents it and modifies Birdbath processors accordingly

Accessibility

[ ] Automated WCAG 2.1 tests pass
[ ] Manual WCAG 2.1 tests completed
[ ] I have tested in a screen reader
[ ] I have tested in high-contrast mode

Sustainability

[ ] Images are optimised and lazy-loading used where appropriate
[ ] Perfomance and transfer of data considered
[ ] If JavaScript is needed alternatives have been considered
[ ] New font variants have not been added

Hi project team, it would be great to get your thoughts on this new MR template. @Morsey187 I've added you in case you have any comments on things we should be considering for sustainability.

Thanks @helenb - this looks great. Do we need to add a list of environments that we're supporting?


fix npe issue relate with pd

Before this PR, npe will be thrown if pd is not present. After this PR, the stacks trace looks like the following:
Caused by: com.pingcap.tikv.exception.GrpcException: retry is exhausted.
	at com.pingcap.tikv.policy.RetryPolicy.callWithRetry(RetryPolicy.java:77)
	at com.pingcap.tikv.AbstractGRPCClient.callBidiStreamingWithRetry(AbstractGRPCClient.java:129)
	at com.pingcap.tikv.PDClient.getTimestamp(PDClient.java:73)
	at com.pingcap.tikv.TiCluster.getTimestamp(TiCluster.java:39)
	at com.pingcap.tikv.TiCluster.createSnapshot(TiCluster.java:43)
	at com.pingcap.tikv.Main.<clinit>(Main.java:16)
Caused by: com.pingcap.tikv.exception.GrpcException: pd may be not present
	at com.pingcap.tikv.PDClient.getAsyncStub(PDClient.java:296)
	at com.pingcap.tikv.PDClient.getAsyncStub(PDClient.java:59)
	at com.pingcap.tikv.AbstractGRPCClient.lambda$callBidiStreamingWithRetry$2(AbstractGRPCClient.java:131)
	at com.pingcap.tikv.policy.RetryPolicy.callWithRetry(RetryPolicy.java:69)
	... 5 more
ERROR: Non-zero return code '1' from command: Process exited with status 1.

This change is

Exception like this can not be retried. Let's deal this issue in another PR.

@birdstorm PTAL.


Prevent bad memory access when reading specific Jpeg files

Description
The issue was caused by some applications not putting a proper
NULL-terminator to the comment marker when saving an image.
This will cause std::string to access memory past the marker's
data when calculating string length.
Now we pass length of string stored in the marker explicitly, so
there's no need to call strlen() on a random memory.
While it's arguably that applications should put null-terminator
to the comment, there are enough textures in online libraries
which doesn't have null-terminator in the comment string and there's
need to crash on those at all.
Tests
The issue was already discussed there http://lists.openimageio.org/pipermail/oiio-dev-openimageio.org/2013-April/006002.html but seems no conclusion were done there. File from that message will demonstrate the issue. Very much easy to notice the issue when using address sanitizer.

Good catch, LGTM, I will merge this.

Merged into master. Will merge into RB-1.6 in a day or so if no problems crop up in master.


jp version can not repacked [hope fix]

Describe the bug
A clear and concise description of what the bug is.
To Reproduce
Steps to reproduce the behavior:
Specifically apply patch
kh1_first, the game crashes without going to the title screen
kh1_third crashes when trying to go to world map screen by selecting gummi ship from save point
kh2_fifth turns off the character's battle voice (cutscene no mute)
kh2_fifth uses Patcher1.1.4, the sound does not disappear, but custom mdlx cannot be used
Expected behavior
there is no file hash information only for the Japanese version,
and the game crashes (cannot progress) because it cannot be repacked well.
Version used (please complete the following information):

Version: [e.g. v1.14 and v1.2.0]

Affected games (please complete the following information):

KH1, KH2

Formats involved (please complete the following information):

If you apply a patch regardless of format

Additional context
if use the Japanese version with KHPCPatchManager1.2.0 and patch some files (kh1_first, kh1_third, kh2_fifth),
is it possible to add these hash information?

Hey, would need more information for this, but most likely the patch you want to apply needs to be adapted for JP version use (I'm guessing the patch was made for US/EU version). That wouldn't have anything to do with the patcher itself.

Thanks reply but this issue has been resolved


solved pos.args and multiple inputs issue

Fixed python compatibility issues and handled multiple inputs scenario for keras.

ok to test


NeseOS also revealing innocent roblox players

So, I've seen looks like notcarot12 roblox user I scammer. Here's screenshot:

But, she not scamming. Only says "shut up" word. So, NeseOS also revealing innocent roblox players is against GitHub terms of service and the reason why @NeseOSCorporation's GitHub page is taking down is because, they also revealing innocent roblox players (like doxxing roblox players)

Yeah. Brave GitHub to taking down due to doxxing roblox players!

Yeah. Brave GitHub to taking down due to doxxing roblox players!

so NeseOS wasn't taken down because they're actually hosting malware and constantly breaking the copyright infringement of Microsoft themselves.
It seems you guys from azerbaijan do not have any schizophrenia pills, do you?

This has nothing to do with Supermium.


Improve issue templates

Made some pedantic edits to improve brevity and add links to common jumping-off points:

Curly punctuation (' → ’) because it’s okay to have nice things.
Link for “search existing issues” to make it more convenient and actionable.
Reduced verbosity of diagnostic step instruction. (Would be good to link to a “troubleshooting your project” guide here so there isn’t a dead end if the diagnostic is healthy—not sure if such a document exists.)
Swapped order of bug report’s actual and expected result, assuming that helps better frame problems.
Made several minor edits for brevity.

Added a link to the troubleshooting page. :)

Thanks for the great work!