Error on listing HABTM associations with sort key

This issue is somehow related to #364.
Consider having following models.
class Attender
  include Dynamoid::Document

  table name: :attenders

  range :full_name
  field :email

  require_relative 'attender_group'

  has_and_belongs_to_many :groups, class: AttenderGroup, inverse_of: :members
end

class AttenderGroup
  include Dynamoid::Document

  table name: :attender_group

  field :name
  field :description

  has_and_belongs_to_many :members, class: ::Attender, inverse_of: :groups
end

Now I can create Attender, AttenderGroup and add attender to group.
Creating attender:
2.5.5 :004 > ana = Attender.create(full_name: 'Ana')
D, [2019-06-20T19:16:47.473066 #6307] DEBUG -- : list_tables | Request "{}" | Response "{\"TableNames\":[]}"
D, [2019-06-20T19:16:47.473594 #6307] DEBUG -- : (436.71 ms) LIST TABLES
D, [2019-06-20T19:16:47.473648 #6307] DEBUG -- : (437.16 ms) CACHE TABLES
I, [2019-06-20T19:16:47.473696 #6307]  INFO -- : Creating attenders table. This could take a while.
D, [2019-06-20T19:16:47.594624 #6307] DEBUG -- : create_table | Request "{\"TableName\":\"attenders\",\"ProvisionedThroughput\":{\"ReadCapacityUnits\":100,\"WriteCapacityUnits\":20},\"KeySchema\":[{\"AttributeName\":\"id\",\"KeyType\":\"HASH\"},{\"AttributeName\":\"full_name\",\"KeyType\":\"RANGE\"}],\"AttributeDefinitions\":[{\"AttributeName\":\"id\",\"AttributeType\":\"S\"},{\"AttributeName\":\"full_name\",\"AttributeType\":\"S\"}]}" | Response "{\"TableDescription\":{\"AttributeDefinitions\":[{\"AttributeName\":\"id\",\"AttributeType\":\"S\"},{\"AttributeName\":\"full_name\",\"AttributeType\":\"S\"}],\"TableName\":\"attenders\",\"KeySchema\":[{\"AttributeName\":\"id\",\"KeyType\":\"HASH\"},{\"AttributeName\":\"full_name\",\"KeyType\":\"RANGE\"}],\"TableStatus\":\"ACTIVE\",\"CreationDateTime\":1561051007.527,\"ProvisionedThroughput\":{\"LastIncreaseDateTime\":0.000,\"LastDecreaseDateTime\":0.000,\"NumberOfDecreasesToday\":0,\"ReadCapacityUnits\":100,\"WriteCapacityUnits\":20},\"TableSizeBytes\":0,\"ItemCount\":0,\"TableArn\":\"arn:aws:dynamodb:ddblocal:000000000000:table/attenders\",\"BillingModeSummary\":{\"BillingMode\":\"PROVISIONED\",\"LastUpdateToPayPerRequestDateTime\":0.000}}}"
D, [2019-06-20T19:16:47.594959 #6307] DEBUG -- : (121.25 ms) CREATE TABLE
D, [2019-06-20T19:16:47.665408 #6307] DEBUG -- : put_item | Request "{\"TableName\":\"attenders\",\"Item\":{\"created_at\":{\"N\":\"1561051007.595388\"},\"updated_at\":{\"N\":\"1561051007.595639\"},\"id\":{\"S\":\"94326b26-dc3b-4a1e-aa2b-20f7d623bd49\"},\"full_name\":{\"S\":\"Ana\"}},\"Expected\":{\"id\":{\"Exists\":false},\"full_name\":{\"Exists\":false}}}" | Response "{}"
D, [2019-06-20T19:16:47.665960 #6307] DEBUG -- : (69.14 ms) PUT ITEM - ["attenders", {:created_at=>0.1561051007595388e10, :updated_at=>0.1561051007595639e10, :id=>"94326b26-dc3b-4a1e-aa2b-20f7d623bd49", :full_name=>"Ana", :email=>nil, :groups_ids=>nil}, {}]
 => #<Attender:0x00007f9a0bc91b78 @new_record=false, @attributes={:created_at=>Thu, 20 Jun 2019 19:16:47 +0200, :updated_at=>Thu, 20 Jun 2019 19:16:47 +0200, :id=>"94326b26-dc3b-4a1e-aa2b-20f7d623bd49", :full_name=>"Ana", :email=>nil, :groups_ids=>nil}, @associations={}, @attributes_before_type_cast={:created_at=>Thu, 20 Jun 2019 19:16:47 +0200, :updated_at=>Thu, 20 Jun 2019 19:16:47 +0200, :id=>"94326b26-dc3b-4a1e-aa2b-20f7d623bd49", :full_name=>"Ana", :email=>nil, :groups_ids=>nil}, @attributes_changed_by_setter={}, @mutations_from_database=nil, @validation_context=nil, @errors=#<ActiveModel::Errors:0x00007f9a0bc80b70 @base=#<Attender:0x00007f9a0bc91b78 ...>, @messages={}, @details={}>, @previously_changed={}, @mutations_before_last_save=nil>

Creating attender group:
2.5.5 :005 > musicians = AttenderGroup.create(name: 'Musicians', description: 'Active musicians')
I, [2019-06-20T19:17:13.641094 #6307]  INFO -- : Creating attender_group table. This could take a while.
D, [2019-06-20T19:17:13.666881 #6307] DEBUG -- : create_table | Request "{\"TableName\":\"attender_group\",\"ProvisionedThroughput\":{\"ReadCapacityUnits\":100,\"WriteCapacityUnits\":20},\"KeySchema\":[{\"AttributeName\":\"id\",\"KeyType\":\"HASH\"}],\"AttributeDefinitions\":[{\"AttributeName\":\"id\",\"AttributeType\":\"S\"}]}" | Response "{\"TableDescription\":{\"AttributeDefinitions\":[{\"AttributeName\":\"id\",\"AttributeType\":\"S\"}],\"TableName\":\"attender_group\",\"KeySchema\":[{\"AttributeName\":\"id\",\"KeyType\":\"HASH\"}],\"TableStatus\":\"ACTIVE\",\"CreationDateTime\":1561051033.663,\"ProvisionedThroughput\":{\"LastIncreaseDateTime\":0.000,\"LastDecreaseDateTime\":0.000,\"NumberOfDecreasesToday\":0,\"ReadCapacityUnits\":100,\"WriteCapacityUnits\":20},\"TableSizeBytes\":0,\"ItemCount\":0,\"TableArn\":\"arn:aws:dynamodb:ddblocal:000000000000:table/attender_group\",\"BillingModeSummary\":{\"BillingMode\":\"PROVISIONED\",\"LastUpdateToPayPerRequestDateTime\":0.000}}}"
D, [2019-06-20T19:17:13.667083 #6307] DEBUG -- : (25.97 ms) CREATE TABLE
D, [2019-06-20T19:17:13.677350 #6307] DEBUG -- : put_item | Request "{\"TableName\":\"attender_group\",\"Item\":{\"created_at\":{\"N\":\"1561051033.667182\"},\"updated_at\":{\"N\":\"1561051033.667447\"},\"id\":{\"S\":\"e30db0bc-3820-49d2-987b-5b073a9378d2\"},\"name\":{\"S\":\"Musicians\"},\"description\":{\"S\":\"Active musicians\"}},\"Expected\":{\"id\":{\"Exists\":false}}}" | Response "{}"
D, [2019-06-20T19:17:13.677538 #6307] DEBUG -- : (9.93 ms) PUT ITEM - ["attender_group", {:created_at=>0.1561051033667182e10, :updated_at=>0.1561051033667447e10, :id=>"e30db0bc-3820-49d2-987b-5b073a9378d2", :name=>"Musicians", :description=>"Active musicians", :members_ids=>nil}, {}]
 => #<AttenderGroup:0x00007f9a0b109eb8 @new_record=false, @attributes={:created_at=>Thu, 20 Jun 2019 19:17:13 +0200, :updated_at=>Thu, 20 Jun 2019 19:17:13 +0200, :id=>"e30db0bc-3820-49d2-987b-5b073a9378d2", :name=>"Musicians", :description=>"Active musicians", :members_ids=>nil}, @associations={}, @attributes_before_type_cast={:created_at=>Thu, 20 Jun 2019 19:17:13 +0200, :updated_at=>Thu, 20 Jun 2019 19:17:13 +0200, :id=>"e30db0bc-3820-49d2-987b-5b073a9378d2", :name=>"Musicians", :description=>"Active musicians", :members_ids=>nil}, @attributes_changed_by_setter={}, @mutations_from_database=nil, @validation_context=nil, @errors=#<ActiveModel::Errors:0x00007f9a0b108720 @base=#<AttenderGroup:0x00007f9a0b109eb8 ...>, @messages={}, @details={}>, @previously_changed={}, @mutations_before_last_save=nil>

Assigning musician to her group:
2.5.5 :007 > musicians.members << ana
D, [2019-06-20T19:17:40.020569 #6307] DEBUG -- : put_item | Request "{\"TableName\":\"attender_group\",\"Item\":{\"created_at\":{\"N\":\"1561051033.667182\"},\"updated_at\":{\"N\":\"1561051059.993209\"},\"id\":{\"S\":\"e30db0bc-3820-49d2-987b-5b073a9378d2\"},\"name\":{\"S\":\"Musicians\"},\"description\":{\"S\":\"Active musicians\"},\"members_ids\":{\"SS\":[\"94326b26-dc3b-4a1e-aa2b-20f7d623bd49\"]}},\"Expected\":{}}" | Response "{}"
D, [2019-06-20T19:17:40.020814 #6307] DEBUG -- : (25.52 ms) PUT ITEM - ["attender_group", {:created_at=>0.1561051033667182e10, :updated_at=>0.1561051059993209e10, :id=>"e30db0bc-3820-49d2-987b-5b073a9378d2", :name=>"Musicians", :description=>"Active musicians", :members_ids=>#<Set: {"94326b26-dc3b-4a1e-aa2b-20f7d623bd49"}>}, nil]
D, [2019-06-20T19:17:40.038639 #6307] DEBUG -- : put_item | Request "{\"TableName\":\"attenders\",\"Item\":{\"created_at\":{\"N\":\"1561051007.595388\"},\"updated_at\":{\"N\":\"1561051060.021232\"},\"id\":{\"S\":\"94326b26-dc3b-4a1e-aa2b-20f7d623bd49\"},\"full_name\":{\"S\":\"Ana\"},\"groups_ids\":{\"SS\":[\"e30db0bc-3820-49d2-987b-5b073a9378d2\"]}},\"Expected\":{}}" | Response "{}"
D, [2019-06-20T19:17:40.038942 #6307] DEBUG -- : (17.48 ms) PUT ITEM - ["attenders", {:created_at=>0.1561051007595388e10, :updated_at=>0.1561051060021232e10, :id=>"94326b26-dc3b-4a1e-aa2b-20f7d623bd49", :full_name=>"Ana", :email=>nil, :groups_ids=>#<Set: {"e30db0bc-3820-49d2-987b-5b073a9378d2"}>}, nil]
 => #<Attender:0x00007f9a0bc91b78 @new_record=false, @attributes={:created_at=>Thu, 20 Jun 2019 19:16:47 +0200, :updated_at=>Thu, 20 Jun 2019 19:17:40 +0200, :id=>"94326b26-dc3b-4a1e-aa2b-20f7d623bd49", :full_name=>"Ana", :email=>nil, :groups_ids=>#<Set: {"e30db0bc-3820-49d2-987b-5b073a9378d2"}>}, @associations={:groups_ids=>#<Dynamoid::Associations::HasAndBelongsToMany:0x00007f9a0bb2c530 @query={}, @name=:groups, @options={:class=>AttenderGroup, :inverse_of=>:members}, @source=#<Attender:0x00007f9a0bc91b78 ...>, @loaded=false, @target=nil>}, @attributes_before_type_cast={:created_at=>Thu, 20 Jun 2019 19:16:47 +0200, :updated_at=>Thu, 20 Jun 2019 19:17:40 +0200, :id=>"94326b26-dc3b-4a1e-aa2b-20f7d623bd49", :full_name=>"Ana", :email=>nil, :groups_ids=>#<Set: {"e30db0bc-3820-49d2-987b-5b073a9378d2"}>}, @attributes_changed_by_setter={}, @mutations_from_database=nil, @validation_context=nil, @errors=#<ActiveModel::Errors:0x00007f9a0bc80b70 @base=#<Attender:0x00007f9a0bc91b78 ...>, @messages={}, @details={}>, @previously_changed={}, @mutations_before_last_save=nil>

But now when I want to list all my musicians in the group, I get this error:
2.5.5 :008 > musicians.members.all
D, [2019-06-20T19:17:47.913705 #6307] DEBUG -- : describe_table | Request "{\"TableName\":\"attenders\"}" | Response "{\"Table\":{\"AttributeDefinitions\":[{\"AttributeName\":\"id\",\"AttributeType\":\"S\"},{\"AttributeName\":\"full_name\",\"AttributeType\":\"S\"}],\"TableName\":\"attenders\",\"KeySchema\":[{\"AttributeName\":\"id\",\"KeyType\":\"HASH\"},{\"AttributeName\":\"full_name\",\"KeyType\":\"RANGE\"}],\"TableStatus\":\"ACTIVE\",\"CreationDateTime\":1561051007.527,\"ProvisionedThroughput\":{\"LastIncreaseDateTime\":0.000,\"LastDecreaseDateTime\":0.000,\"NumberOfDecreasesToday\":0,\"ReadCapacityUnits\":100,\"WriteCapacityUnits\":20},\"TableSizeBytes\":134,\"ItemCount\":1,\"TableArn\":\"arn:aws:dynamodb:ddblocal:000000000000:table/attenders\",\"BillingModeSummary\":{\"BillingMode\":\"PROVISIONED\",\"LastUpdateToPayPerRequestDateTime\":0.000}}}"
D, [2019-06-20T19:17:47.956185 #6307] DEBUG -- : batch_get_item | Request "{\"RequestItems\":{\"attenders\":{\"Keys\":[{\"id\":{\"S\":\"94326b26-dc3b-4a1e-aa2b-20f7d623bd49\"},\"full_name\":{\"NULL\":true}}]}}}" | Response "{\"__type\":\"com.amazon.coral.validate#ValidationException\",\"message\":\"Invalid attribute value type\"}"
Traceback (most recent call last):
       16: from /Users/mpevec/.rvm/gems/ruby-2.5.5@attendance-tracker/gems/dynamoid-3.2.0/lib/dynamoid/adapter.rb:86:in `read'
       15: from /Users/mpevec/.rvm/gems/ruby-2.5.5@attendance-tracker/gems/dynamoid-3.2.0/lib/dynamoid/adapter.rb:148:in `block (2 levels) in <class:Adapter>'
       14: from /Users/mpevec/.rvm/gems/ruby-2.5.5@attendance-tracker/gems/dynamoid-3.2.0/lib/dynamoid/adapter.rb:54:in `benchmark'
       13: from /Users/mpevec/.rvm/gems/ruby-2.5.5@attendance-tracker/gems/dynamoid-3.2.0/lib/dynamoid/adapter.rb:148:in `block (3 levels) in <class:Adapter>'
       12: from /Users/mpevec/.rvm/gems/ruby-2.5.5@attendance-tracker/gems/dynamoid-3.2.0/lib/dynamoid/adapter_plugin/aws_sdk_v3.rb:192:in `batch_get_item'
       11: from /Users/mpevec/.rvm/gems/ruby-2.5.5@attendance-tracker/gems/dynamoid-3.2.0/lib/dynamoid/adapter_plugin/aws_sdk_v3.rb:192:in `each'
       10: from /Users/mpevec/.rvm/gems/ruby-2.5.5@attendance-tracker/gems/dynamoid-3.2.0/lib/dynamoid/adapter_plugin/aws_sdk_v3.rb:220:in `block in batch_get_item'
        9: from /Users/mpevec/.rvm/gems/ruby-2.5.5@attendance-tracker/gems/aws-sdk-dynamodb-1.30.0/lib/aws-sdk-dynamodb/client.rb:567:in `batch_get_item'
        8: from /Users/mpevec/.rvm/gems/ruby-2.5.5@attendance-tracker/gems/aws-sdk-core-3.54.2/lib/seahorse/client/request.rb:70:in `send_request'
        7: from /Users/mpevec/.rvm/gems/ruby-2.5.5@attendance-tracker/gems/aws-sdk-core-3.54.2/lib/seahorse/client/plugins/response_target.rb:23:in `call'
        6: from /Users/mpevec/.rvm/gems/ruby-2.5.5@attendance-tracker/gems/aws-sdk-core-3.54.2/lib/aws-sdk-core/plugins/response_paging.rb:10:in `call'
        5: from /Users/mpevec/.rvm/gems/ruby-2.5.5@attendance-tracker/gems/aws-sdk-core-3.54.2/lib/aws-sdk-core/plugins/param_converter.rb:24:in `call'
        4: from /Users/mpevec/.rvm/gems/ruby-2.5.5@attendance-tracker/gems/aws-sdk-core-3.54.2/lib/aws-sdk-core/plugins/idempotency_token.rb:17:in `call'
        3: from /Users/mpevec/.rvm/gems/ruby-2.5.5@attendance-tracker/gems/aws-sdk-core-3.54.2/lib/aws-sdk-core/plugins/jsonvalue_converter.rb:20:in `call'
        2: from /Users/mpevec/.rvm/gems/ruby-2.5.5@attendance-tracker/gems/aws-sdk-dynamodb-1.30.0/lib/aws-sdk-dynamodb/plugins/simple_attributes.rb:117:in `call'
        1: from /Users/mpevec/.rvm/gems/ruby-2.5.5@attendance-tracker/gems/aws-sdk-core-3.54.2/lib/seahorse/client/plugins/raise_response_errors.rb:15:in `call'
Aws::DynamoDB::Errors::ValidationException (Invalid attribute value type)

I know that this is related to setting sort key on Attender; it only stores ids without store key (:groups_ids=>#<Set: {"e30db0bc-3820-49d2-987b-5b073a9378d2"}>) and when I try to list them, it uses batch_get_item method with wrong query parameters ({\"Keys\":[{\"id\":{\"S\":\"94326b26-dc3b-4a1e-aa2b-20f7d623bd49\"},\"full_name\":{\"NULL\":true}}]})
I think that, at the moment, querying on associations  can be used only without using sort keys. Also, I'm not sure that my statements are all correct because I'm new in DynamoDB.

Yeah, you are completely right. Dynamoid's associations don't work with sort keys and there is already issue about this problem (https://github.com/Dynamoid/dynamoid/issues/316).
 That's why this known issue still isn't fixed.

Sorry, I haven't look for open issue about that problem.
Anyway, is there any reason why we don't use query (docs here) method instead of batch_get_item when we have range key in our association? The same question for my previous issue #364.

Hmm, I don't understand your question.
Current behavior I would consider as a bug and support of association with composite primary key should be added.
From the other hand BatchGetItem is the most efficient and cheap way to load items by primary key for both simple scalar primary key and composite one.

From the other hand BatchGetItem is the most efficient and cheapest way to load items by primary key for both simple scalar primary key and composite one.

I agree with you, it's the most efficient way, but only if you have both; the primary key and composite one. Using Query API instead of BatchGetItem API, we could be able to get items just with primary key, which would resolve our problem while listing associations with range key. This is maybe less efficient way, but maybe it's better to use Query API in these cases before any bigger refactoring on associations are being done. This is just a proposal which acts as a workaround. Just speaking out loud.

Using Query API instead of BatchGetItem API, we could be able to get items just with primary key, which would resolve our problem while listing associations with range key

I assume you meant partition key when wrote just with primary key.
Yeah, Query api call with condition on partition key like id: [id1, id2, id3, ...] will work for class with sort key (range key) and items with cached partition keys will be loaded. But result will contain associated models as well as some arbitrary models with different sort key (range key) but the same partition one. So result will contain both associated models and not associated.
I would say it would be very dangerous bug because it would be silent. Am I right?

I assume you meant partition key when wrote just with primary key.

Yes, I was thinking about partition key.

I would say it would be very dangerous bug because it would be silent. Am I right?

I'm concerned about this too. I don't have so much practice with DynamoDB/Dynamoid so I don't have an answer at the moment. When I catch some time, I'll try to make changes and test if it works as expected, then we can discuss about it.


Publish v0.2.0 to crates.io

It looks like v0.2.0 didn’t make it to crates.io!

I was going to report some bugs but it turns out they've already been fixed in the unpublished version.
It would be very nice indeed to update the version in crates.io if you can.

@bb010g

https://crates.io/crates/hsluv/0.3.0


What is queues in asyn_distributed_tf.py

What is queues in line 182 of asyn_distributed_tf.py?

and worker_hosts? Also in lines 126 and 127 are both queue?
queue = create_queue(FLAGS.job_name, FLAGS.task_index, workers)
queue =[]


Issue caching Springboot app

Using Licensed already for React app via npm source (works great) but struggling to use for Springboot apps. First, would like to confirm I'm not missing a source that supports Maven pom.xml files. The dependency analysis on Github.com supports them, but I don't think I see a Licensed source for them.
Given that, I converted a clone of the app repo to Gradle so we can use that source, but running "gradle init" on the root directory. It looks like Licensed Gradle support is a bit dated - my first hint was the default config looks for the "runtime" configuration in build.gradle, which has been deprecated in favour of "implementation". I also hit an issue that "implementation" cannot be resolved. I punched through both of those issues by adding this to build.gradle:
configurations {
runtime.extendsFrom implementation {
canBeResolved = true
canBeConsumed = true
}
}
Current status is that Licensed spits out errors like this:

Caching dependency records for Kobai
gradle
Error antlr:antlr (2.7.7)
Error ch.qos.logback:logback-classic (1.2.3)
Error ch.qos.logback:logback-core (1.2.3)

and

Errors:

Kobai.gradle.antlr:antlr
cached: false, filename: /Users/ryanoattes/dev/licensed/data-svcs/gradle/antlr:antlr.dep.yml, version: 2.7.7

'/Users/ryanoattes/git/kobai-data-services/studio-services/gradlew -q -b /Users/ryanoattes/git/kobai-data-services/studio-services/license-20220303-89401-j4ulnu.gradle generateLicenseReport' exited with status 1
FAILURE: Build failed with an exception.

What went wrong:
Some problems were found with the configuration of task ':generateLicenseReport' (type 'CacheableReportTask').

In plugin 'com.github.jk1.dependency-license-report' type 'com.github.jk1.license.task.CacheableReportTask' property 'config.cache.$0.filename' is missing an input or output annotation.
Reason: A property without annotation isn't considered during up-to-date checking.
Possible solutions:

Add an input or output annotation.
Mark it as @Internal.

Please refer to https://docs.gradle.org/7.4/userguide/validation_problems.html#missing_annotation for more details about this problem.

Based on this thread (https://github.com/jk1/Gradle-License-Report/issues/203) it looks like this was a known issue with the Gradle-License-Report plugin that was resolved in Aug 2021 with an upgrade to 2.0 to support Gradle7.
In the Licensed repo, I see a commit (failed build) updating Gradle to the newest version of the plugin from June 2021, but that's before the new plugin was available.
So - That's where I am. If there is Maven support I'd love to drop the whole Gradle thread, but failing that some guidance on where to go from here would be great.

:wave: @RyanOattes

The dependency analysis on Github.com supports them, but I don't think I see a Licensed source for them.

This tool is separate from what you'll see online in a GitHub repo description or its dependency graph and is meant more for local analysis.  Sorry for the confusion there
I don't have much experience with the Java ecosystem and have relied on contributors to build support.  I would gladly welcome any PRs that add Maven support as well as provide any help needed in the integration!  The core challenges are

enumerating all dependencies for an app with name and version at a minimum but hopefully also a description and homepage link
getting access to real files on disk that contain license contents (if any) for each dependency.  IIRC Gradle dependencies don't include license files and so we needed to build some workarounds to pull license contents from online sources - does the same apply to Maven?

Similarly, I'd welcome any PRs that update the Gradle-License-Report plugin to support more Gradle versions!  I'll give that update a shot but it might be quicker and easier if someone with more experience did it 😆

Thanks for the response @jonabc . I'll just wait and watch, then, since I'm not a Java dev!

Java and Oracle was just updated by me as if 3;39 a m

@RyanOattes an update to the Gradle source was shipped in release 4.2.0.  The problems resolved by the update sound very similar to what you called out in this issue.  Can you give that a shot and let me know if you're able to use the Gradle source more reliably now?  There's still no support for Maven unfortunately.


Add CC-BY-4.0 license, fix #15.

@Bibalox
@Niouby

Guys, I really need this to properly package for debian, @Kivutar

Sorry guys, i’m quite busy those days.
Kivutar, Sergio, what to you expect me to do exactly ? I mean, how do I do I had the CC licence on Github ? I don’t want to mess with it.
Jean-Baptiste Bal
+33 (0) 6 52 13 24 39
29, allée des Deux Mondes
38100 GRENOBLE

Le 18 mai 2016 à 05:03, sergio-br2<EMAIL_ADDRESS>a écrit :
@Bibalox https://github.com/Bibalox
@Niouby https://github.com/Niouby
You can view, comment on, or merge this pull request online at:
https://github.com/libretro/retroarch-assets/pull/26 https://github.com/libretro/retroarch-assets/pull/26
Commit Summary
Add CC-BY-4.0 license, fix #15.
File Changes
A COPYING https://github.com/libretro/retroarch-assets/pull/26/files#diff-0 (396)
Patch Links:
https://github.com/libretro/retroarch-assets/pull/26.patch https://github.com/libretro/retroarch-assets/pull/26.patch
https://github.com/libretro/retroarch-assets/pull/26.diff https://github.com/libretro/retroarch-assets/pull/26.diff
—
You are receiving this because you were mentioned.
Reply to this email directly or view it on GitHub https://github.com/libretro/retroarch-assets/pull/26

@Bibalox, just say if you are OK with it :D
well, it's merged already.

Haha, I’m fully ok with it ! We had to add a licence anyway and it seems to be the best solution.
Thanks Sergio.
Jean-Baptiste Bal
+33 (0) 6 52 13 24 39
29, allée des Deux Mondes
38100 GRENOBLE

Le 22 mai 2016 à 20:46, sergio-br2<EMAIL_ADDRESS>a écrit :
@Bibalox https://github.com/Bibalox, just say if you are OK with it :D
well, it's merged already.
—
You are receiving this because you were mentioned.
Reply to this email directly or view it on GitHub https://github.com/libretro/retroarch-assets/pull/26#issuecomment-220848791


works with firmware 5.1?

Hi, I would love to use this, is it tested with 5.1 firmware?

No, i only have a pair of LS50 Wireless for testing. And the latest firmware for those is still 4.1 from 2019.

ok, once I dare to update I will test with my LSX and let you know. Thanks for your code!

works with firmware 5.1 on my KEF LSX.
Thanks.
:-)

Thanks for letting me know.


Disable date?

Hi,
This might be an enhancement request as currently when doing this command:
gam print users allfields > (target csv)
It does not include when an account was Suspended (it only shows TRUE or FALSE and by ADMIN)
Is it possible to include the timestamp when an account was disabled?
Thanks,
Von

Closing as date of disable is not provided by Google API, thus no way for GAM to add.


Add information about API key to README

This is a very impressive application. However, when I started playing with it, I was thrown by the fact that it didn't build without an API key.
In terms of usability, it might be better if there were some dummy stories you could view first. Then you would be more motivated to obtain the API key and see real data.

Hi @garthgilmourni Thanks for the feedback. Yes, I think a mock service would be beneficial to get started 👍 I'll open an issue to work on this


[BUILD] Fix CI profile kyuubi-extension-spark_3.1

Why are the changes needed?

How was this patch tested?

[ ] Add some test cases that check the changes thoroughly including negative and positive cases if possible

[ ] Add screenshots for manual tests if appropriate

[ ] Run test locally before make a pull request

Codecov Report

Merging #645 (f676731) into master (66dcf45) will not change coverage.
The diff coverage is n/a.

:exclamation: Current head f676731 differs from pull request most recent head 1499d5b. Consider uploading reports for the commit 1499d5b to get more accurate results

@@           Coverage Diff           @@
##           master     #645   +/-   ##
=======================================
  Coverage   79.87%   79.87%
=======================================
  Files         120      120
  Lines        4671     4671
  Branches      562      562
=======================================
  Hits         3731     3731
  Misses        624      624
  Partials      316      316

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 66dcf45...1499d5b. Read the comment docs.


Add cmake-format linter

What
Add CI check for cmake-format linter
Why
Ensure a consistent style in CMake files. This is especially important as we start to attract outside collaborators.
Notes
We have prior art in TraitGen
Acceptance Criteria

TODO: Understand the relationship with cmake-lint and cmake-format


Add: elvirbrk.notehighlight2016 v3.7

[X] Have you signed the Contributor License Agreement?
[X] Have you checked that there aren't other open pull requests for the same manifest update/change?

[X] Does your manifest conform to the 1.0 schema?

Microsoft Reviewers: Open in CodeFlow

/azp run

/azp run

That was a duplicate of #20825. Moderator himself opened a duplicate PR. 😂

When going trough old folders i don't actually check for existing PR's because i expect them to be Azure-Pipeline-Passed, eitherway your Publisher and PackageName was wrong and it had less metadata so it dosn't matter as it would be more trouble to get it to repass Validation again


fix(getTokenData): Removing buggy redundent sorting of txs

:tada: This PR is included in version 5.8.8 :tada:
The release is available on npm package (@latest dist-tag)
Your semantic-release bot :package::rocket:


Luis Security Consideration

Could you please give an overview of Luis security, including network security and IAM authentication?
or  point out where the network security and IAM authentication are documented for this service?
[Enter feedback here]

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 902be7bb-e623-ff49-9d9d-e53f17161f06
Version Independent ID: be07779d-229f-5ce4-5ea3-ae1497f650c7
Content: What is Language Understanding (LUIS)? - Azure Cognitive Services
Content Source: articles/cognitive-services/LUIS/what-is-luis.md
Service: cognitive-services
Sub-service: language-understanding
GitHub Login: @aahill
Microsoft Alias: aahi

@RonnieQuan Thanks for the feedback! We are taking a look into this and will get back to you soon.

@RonnieQuan Thanks for the feedback! We are taking a look into this and will get back to you soon.

@SnehaAgrawal-MSFT  This question is critical, could you share your insight ASAP?

@SnehaAgrawal-MSFT  This question is critical, could you share your insight ASAP?

@RonnieQuan You can refer the documentation of encryption and network security for more details on securing your calls to LUIS API. Configuring LUIS with AAD for authentication though is currently not supported. The list of supported services are listed here.

@RonnieQuan You can refer the documentation of encryption and network security for more details on securing your calls to LUIS API. Configuring LUIS with AAD for authentication though is currently not supported. The list of supported services are listed here.

#https://github.com/MicrosoftDocs/azure-docs/issues/68881#issuecomment-759902090 Referenced the issue with the same query to avoid duplication.

#https://github.com/MicrosoftDocs/azure-docs/issues/68881#issuecomment-759902090 Referenced the issue with the same query to avoid duplication.

@RonnieQuan We will now proceed to close this thread. If there are further questions regarding this matter, please tag @RohitMungi-MSFT in your reply.

@RonnieQuan We will now proceed to close this thread. If there are further questions regarding this matter, please tag @RohitMungi-MSFT in your reply.


Support for request hedging (racing) on per try timeout

Title: Support for request hedging (racing) on retry timeout
Description:
This issue is similar to #2784 (which discusses support for sending multiple simultaneous requests and using the first response to manage tail latency) however specifically pertains to handling of a timed out request. This would allow for sending a comparatively lower overall request volume than straight up hedging while being resilient to slow upstreams. It's essentially the same per try timeout behavior in place today, except the original request will not be canceled and the first response received can be used.
I imagine it would make sense to implement #2784 first since that seems like less of an architectural change to the router and then add options to only send the extra requests when the per try timeout is hit.
I'm interested in taking it on

@htuch @mattklein123 Thoughts on this "hedge on timeout" feature? If this makes sense I'll be working with Mike to come up with an design for configuring this + proposed implementation

@mpuncel I invited you to envoyproxy org so I can assign you the issue.

Sounds good! The idea with the timeout approach is that you can cut tail latency while not multiplying traffic volume as much as you would with proactive hedging. Also if request processing time grows organically to surpass the timeout threshold then requests won't fail (although you'll get unnecessary load so you need a mechanism to find this situation and adjust the timeout appropriately)

@mpuncel @snowp this sounds great to me. This has been a feature that has been requested for quite some time. I don't think it should be TOO difficult :), as I did setup the router code to decouple upstream requests from downstream requests quite a long time ago, but it will definitely be a complex change. Please make sure to have some integration tests. All of the cool simulated time work that @jmarantz has been doing should make this a lot easier to test as an integration test.

doc: https://docs.google.com/document/d/1OsDjLtKUweQS0kEQDWs9VF4l46_leQ74dk-G2oQJoNI/edit?usp=sharing

I ran into an issue here I'm not sure how to resolve. It looks like today per try timeouts are only retried if retry_on includes either 5xx or gateway-error. That's because of this case here: https://github.com/envoyproxy/envoy/blob/master/source/common/router/retry_state_impl.cc#L264.
My change is making retries on per try timeouts that do not have a reset at all. I have 3 options to decouple these retries from resets:

keep the existing logic where the per try timeout is only retried if you're retrying 5xx or gateway error.

add a new retry_on case like per-try-timeout

always retry per try timeout (subject to the number of retries remaining).

is probably surprising from a user experience perspective. If i'm setting a per try timeout, isn't that implying I want it to be retried? What does 5xx have to do with a timeout?

is probably the cleanest solution, but will cause divergent behavior between hedged per try timeouts and normal per try timeouts if we don't want to change behavior for existing users. I'm not sure if we'd be able to reconcile the two ever because we would have to break backwards compatibility.

Is the option i'd go with if we could start from the beginning and would be safe if it only applies to the hedged per try timeout case, but again would result in a divergence of behavior between non-hedged vs hedged per try timeouts.

Sorry for coming in late with a drive by comment(should I have opened a separate issue?) but curious if it would be possible or even a good idea to have a hedging policy configured based on the percentile of the overall request latency?
This would require Envoy to support latency monitoring which might be too expensive?
Basically this would be a more adaptive approach then setting per_try_timeout with the downside of the added complexity.

@tommyulfsparre I would recommend opening a separate issue on your request, sounds interesting but I think a bit different then what we are looking at here.

@mpuncel TBH I don't recall the history of how we got to where we are today. I think the general idea is that we want to make sure that even if we specify a per try timeout, we only retry in cases where the user explicitly opts in.

My change is making retries on per try timeouts that do not have a reset at all. I have 3 options to decouple these retries from resets:

I don't quite follow this. Why does your change effect this behavior? Is it because you are going to hedge/retry on a per try timeout?

@mattklein123 yeah. Before this change, there is never a retry that is not in response to a reset (even if in the timeout case it's a local reset).
After further thought, I think it makes sense to keep the RETRY_ON_5XX or RETRY_ON_GATEWAY_ERROR condition. Basically pretends it's a 504.

Just opt in to check the progress of this development. Is this ready to pull the latest code and try out now?
Also, to clarify, when one of the duplicated requests responds, will we cancel other replicas?
Thanks for the great work!

Yeah we're running with this feature in production, and yes the other requests will be reset. Whether this results in request cancelation on the server side will depend on how your server handles resets.

Thanks for the reply @snowp! By "reset" do you mean the load balancer will send a special signal to the server side? Does the server side envoy have a separate port for "reset" traffic (I would imagine the duplicated request is queued before reset)? This might be a trivial question but I want to understand more about the underlying implementation.
Are there a few entry points to how this feature is implemented and used (e.g., any wiki)? Thank you!

iirc for http 1.1 a reset means that envoy closes the connection (I could be wrong here), while for http/2 it means that it sends a RST_STREAM frame to the server. It would be up to the server to handle this - there's no out of band communication of resets


add message compression

from #18: lets also compress this, either using lzstring or a using a custom name mapping. Most likely lzstring which adds ~4kb download is the best solution.

1.6Kb gzipped   https://cdnjs.cloudflare.com/ajax/libs/lz-string/1.4.4/lz-string.min.js
There is a websocket deflate extension.  If we figure out how to enable it maybe we can get that with 0 effort and 0 extra KB and dependencies.

Sec-WebSocket-Extensions:permessage-deflate

-- already on? I had wondered because the actual traffic measured in wireshark was way lower than I expected when I looked. How did you actually measure, looking at the frames or with wireshark?

i think we resolved this, did we?

I thin we still didn't add lzstring, right?   But feel free to close it and I will create another if needed later.

https://github.com/nodeca/pako -- we could use this


Enhancement: Generic controllers

What's the feature you'd like to ask for.
First off, lovely framework. I would like for it to be possible to "inherit routes" when I use starlite.Controller, in code speak this roughly translates to
A "Base Controller" that can have common routes such as

Get by ID
Get by Name
Delete by ID
Get All

All these would return models (in my case, they would be SQLAlchemy objects)
T = TypeVar('T', bound=models.Base)

class BaseController(Controller, Generic[T]):
    model = models.Base

    @get('{resource_id:uuid}')
    async def get_by_id(
        self, resource_id: UUID, session: AsyncSession
    ) -> T | None:
        return await session.get(self.model, resource_id)

Any inherited class can then use this like so
class Foo(BaseController[type[models.Foo]]):
    path = 'foo'
    tags = [path]
    model = models.Foo

class Bar(BaseController[type[models.Bar]]):
    path = 'Bar'
    tags = [path]
    model = models.Bar

Expected Behavior
I should now be able to do /foo/{resource_id} and /bar/{resource_id} and of course, any other routes in the base class should be added.
Additional context

Right now the code example I've shown results in an ImproperlyConfiguredException

starlite.exceptions.http_exceptions.ImproperlyConfiguredException: 500: Parameter '' with type '~T' could not be mapped to an Open API type. This can occur if a user-defined generic type is resolved as a parameter. If '' should not be documented as a parameter, annotate it using the `Dependency` function, e.g., `: ... = Dependency(...)`.

OpenAPI integration would be a plus.

I'm thinking that we have an alternate controller class called GenericController that accepts a single type argument. In __class_getattr__ we take that type arg, create a subclass of GenericController that has the type bound to it, and return that subclass.
Internally, Starlite would have to know to substitute out any type vars in the handler signatures for the referenced type as it models the handler function signatures.
Lets say the generic base looked like this:
class GenericController(Controller, Generic[T]):
    _data_type: type[T]
    def __class_getitem__(cls, data_type: type[T]) -> Self:
        return type(f"Controller[{data_type.__name__}]", (cls,), {"_data_type": data_type})

Then, you'd want to be able to subclass it to add generic methods.
class MyGenericController(GenericController[T], Generic[T]):
    @get()
    def get_handler(service: GenericService[T]) -> T:
         return service.get()

then a concrete implementation
class ThingController(MyGenericController[Thing]):
    dependencies = {"service": Provide(ThingService)}

When starlite was modelling the signature of the handler for ThingController it would have to know to sub out the type var T for the concrete type Thing, which it could access from GenericController._data_type.
Wonder what I don't know that I don't know about this yet :laughing:

I'm thinking that we have an alternate controller class called GenericController that accepts a single type argument. In __class_getattr__ we take that type arg, create a subclass of GenericController that has the type bound to it, and return that subclass.

This sounds like an excellent solution to me.

I'm thinking that we have an alternate controller class called GenericController that accepts a single type argument. In __class_getattr__ we take that type arg, create a subclass of GenericController that has the type bound to it, and return that subclass.

This sounds like an excellent solution to me.

Not alternate - subclass of controller

Hello, wanted to know if it is still in the works or not? I should explicitly state I am not looking for a timeline / commitment, as long as it is in the roadmap it is fine with me 🙂

Hello, wanted to know if it is still in the works or not? I should explicitly state I am not looking for a timeline / commitment, as long as it is in the roadmap it is fine with me 🙂

It is

New PR following branch v2.1 : https://github.com/litestar-org/litestar/pull/2162

Hello, I was notified and found it quite surprising that this got funded. I'd like to mention that wasn't from me, in the interest of fairness to those who actually funded this 🙂

Would this support DTOs?


integrate gofumpt in ci workflow

What would you like to be added:
pre-commit里有这个工具的支持，研究下先集成到咱项目的pre-commit里

Why is this needed:

Please assign to me.

imports-formatter
license-eye


x86 predict build error

Environment
Hardware Environment(Ascend/GPU/CPU):

Uncomment only one  /device <> line, hit enter to put that in a new line, and remove leading whitespaces from that line:
/device cpu

Software Environment:

MindSpore version (source or binary):0.1
Python version (e.g., Python 3.7.5):Python 3.7.5
OS platform and distribution (e.g., Linux Ubuntu 16.04): Ubuntu 18.04
GCC/Compiler version (if compiled from source): gcc 7.5

Describe the current behavior
occurs build error:
CMake Error at src/CMakeLists.txt:56 (add_dependencies):
The dependency target "securec" of target "mspredict" does not exist.
CMake Error at benchmark/CMakeLists.txt:34 (add_dependencies):
The dependency target "securec" of target "benchmark" does not exist.
CMake Error at test/CMakeLists.txt:41 (add_dependencies):
The dependency target "securec" of target "ms-test" does not exist.
CMake Error at module/tvm_kernel/lite/CMakeLists.txt:140 (add_dependencies):
The dependency target "securec" of target "tvm_kernel" does not exist.
Describe the expected behavior
Steps to reproduce the issue

cd mindspore
./build.sh -I x86_64 -j4

Related log / screenshot
Special notes for this issue

please retry building after removing 'build' directory, this rarely happens on x86 platform, we are working on fixing it.

It seems be ok after I delete the depency of securec in CMake.txt

Thank you for the information.

Hi @liuchanchen, could you close the issue if the question has been resolved? Thanks : )


Discrepancies regarding rocket fuels

I don't get why Falcon 9 & Falcon Heavy vehicles are listed with 'different' oxidizers, or 'propellant_1 in the JSON'.
Falcon Heavy:
propellant_1: "subcooled liquid oxygen"
propellant_2: " RP-1 kerosene"

Falcon 9:
propellant_1: "liquid oxygen"
propellant_2: "RP-1 kerosene"

I get that 'subcooled liquid oxygen' and 'liquid oxygen' are technically the same propellant, but for the sake of consistency, they should be the same.
Also, there's a black space in 'propellant_2' in the Falcon Heavy :)

Corrected. Not sure why it was added that way.


Some ideas

These are some ideas to improve the project:

Show all the data in the "textToWriteBox" at the end of the exercise.
In "normal" and "easy" mode, the next key to press will be highlighted.
Adding possibility to "change language": italian or english.
Adding possibility to "change software's colors".
When "startMenu" is opened, if it's in "easy" or "normal" mode, there will be shown two hands positionated on the keys, to show what fingers to use.
Adding "reset Exercise button".
Changing time's format from seconds, to minutes:seconds.
SUGGESTION change text dimension in settings (big, small, medium).
Adding my name, github repository link, and my email to the project, in main menu.
Remember to add sounds.
Adding mediafire download (or something like that) at the end of the work

I suggest to rewrite the ideas as stories, or tasks within stories, because
in the current text it is not clear why these ideas should improve the
project, who benefits from these ideas and, therefore, which one should be
implemented (if any) and in which order.
To frame tasks into stories is important also if these are personal notes,
because in a short time you will probably forget a lot of things about them.
On Sat, Aug 11, 2018, 5:43 PM Ionut Cicio<EMAIL_ADDRESS>wrote:

These are some ideas to improve the project:

Show all the data in the "textToWriteBox" at the end of the
exercise.
In "normal" and "easy" mode, the next key to press will be
highlighted.
Adding possibility to "change language": italian or english.
Adding possibility to "change software's colors".
When "startMenu" is opened, if it's in "easy" or "normal" mode,
there will be shown two hands positionated on the keys, to show what
fingers to use.
Adding "reset Exercise button".
Changing time's format from seconds, to minutes:seconds.
SUGGESTION change text dimension in settings (big, small, medium).
Adding my name, github repository link, and my email to the
project, in main menu.
Remember to add sounds.
Adding mediafire download (or something like that) at the end of
the work

—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/Prometal328/Keyboard-Teacher/issues/23, or mute the
thread
https://github.com/notifications/unsubscribe-auth/ADbYVtg70X-fkFAO3_CJ1WmBTLPAwDCdks5uPvuhgaJpZM4V5NdV
.


Activate Checkstyle rule to avoid star imports

The usage of Star imports within java is generally seen as a bad practice as it leads to tight coupling between packages and might lead to problems when a new version of a library introduces name clashes. see https://checkstyle.sourceforge.io/version/4.4/5.x/config_imports.html - as we do have a tool in place which can prevent the usage, we should activate the rule
<module name="AvoidStarImport">
</module>

see the already raised nit in a pull request https://github.com/open-feature/java-sdk-contrib/pull/810#discussion_r1631573948
wdyt?

thank you for merging this, with a great surprise i realised that checkstyle is not run for test sources do you think this would be desirable? i can proide a pr, but there are a lot of tests which are violating basic naming and formatting conventions, so this would take some time. on the other hand it would be a good first issue.

thank you for merging this, with a great surprise i realised that checkstyle is not run for test sources do you think this would be desirable? i can proide a pr, but there are a lot of tests which are violating basic naming and formatting conventions, so this would take some time. on the other hand it would be a good first issue.

hmm that's strange. We only exclude generated sources through suppression xml [1] . Do you have a clue on why tests are ignores ?
[1] - https://github.com/open-feature/java-sdk-contrib/blob/main/checkstyle-suppressions.xml

        <includeTestSourceDirectory>true</includeTestSourceDirectory>

is missing in the checkstyle config


Constify API, a bit more ...

Pretty straightforward, Travis was ok.
I can reduce its extent, if you think its too much or too late.

Just a couple of minor comments. Otherwise looks good.

I've stopped reviewing the new commit at this point. I think as far as this MR is concerned you should make the minimal fix I proposed above:
ASN1_OBJECT *X509_NAME_ENTRY_get_object(const X509_NAME_ENTRY *ne);

The new commit should be raised as a separate MR as it is so big.

+1 subject to the out-of-date comment noted above being removed.

Apart from missing blank line (which was the case even before this PR, but should be addressed) looks fine to me.

@mattcaswell : fixed and rebase. please proceed.

+1

Merged


Command line history

Addressing issue #38

Coverage decreased (-0.9%) to 82.757% when pulling da87067d06d9c9ddb52b178beff9403f66473a3a on command-line-history into 8eb1e38a8bb0fffcdbc208c6969ce70583e34990 on master.

Coverage decreased (-0.9%) to 82.757% when pulling da87067d06d9c9ddb52b178beff9403f66473a3a on command-line-history into 8eb1e38a8bb0fffcdbc208c6969ce70583e34990 on master.

Gonna add more test cases

Coverage increased (+0.3%) to 83.91% when pulling 6ffdd7fa7378fd814a667dde0463c880505e6c19 on command-line-history into 8eb1e38a8bb0fffcdbc208c6969ce70583e34990 on master.

Coverage increased (+0.3%) to 83.937% when pulling 0cf2fc5311268fd168a6e4d7d3768a4cd6dc5f13 on command-line-history into 6ea4e73d215bea951f2634567e4a82cc45564df8 on master.

Coverage increased (+0.3%) to 83.955% when pulling f15a2b4d42ff6e98617a109b22c62eca540cc52a on command-line-history into a20eaa3e4289dd5acf526e917dea7f684da72dd3 on master.


Can't add Engine via docker.sock

FATA[0000] error adding engine: Get unix:///docker.sock/_ping: unsupported protocol scheme "unix"

Same for me :)

@mauimauer Would you mind sharing how you accomplished this with socat?

You can see an example here https://github.com/ehazlett/dockerfiles/tree/master/docker-proxy


Allow anonymous users to generate CommunicationLogs

Why
Fixes #805.
Integrating EmailNewSubmission into Asks|OffersController broke those forms for anonymous users. CommunicationLog.log_email allows a nil initiator object but the DB does not allow null in the corresponding created_by_id column.
Pre-Merge Checklist

[x] All new features have been described in the pull request
[ ] High quality tests have been added, or an explanation has been given why the features cannot be tested
[ ] All outstanding questions and concerns have been resolved
[ ] Any next steps that seem like good ideas have been created as issues for future discussion & implementation
[ ] Entry added to CHANGELOG.md if appropriate

How
First, the EmailNewSubmission interactor needed to allow a nil user (for when current_user is nil). But this by itself was not sufficient because the nil then causes PG:NotNullViolation.
communication_logs.created_by_id did have a default id set to 1, but this requires persistence code to omit the created_by field if it isn't provided; if a write is issued containing created_by: nil, rails will pass that on to the DB which then rejects it.
Moreover, i don't think it's wise to assume our 'system user' will always have an id of 1. If we really want CommunicationLog entries to have a system user as their default user id, we should explicitly set this in code.
Instead of implementing this additional logic, i've chosen here to drop the default value and changed the column to be nullable. As such, null can represent the same semantics of defaulting to the system user.
Testing

[ ] Tests forthcoming

Outstanding Questions, Concerns and Other Notes
Would love your eyes on this @maebeale, particularly around the question of defaulting created_by_id to 1.

@acherukuri hey there! THANKS for working on this!!!
might we want to consider creating a user upon form submission?

a user that we don't tell the person we created, but we do it under the hood
then the email confirmation could be sent later in the process to a real user, rather than trying to fake out the system's created_by_id data?

if not, i'm ok w removing the user requirement as you've done. just thinking it might be better practice to create the accounts rather than skip the user. (then, we have the additional bonus that after we have more user-facing-user-account pages, we can email all "users" to invite them to actually log in by resetting the password vs creating a new account AND setting the password. not sure everyone else would think this is a bonus, but... :) i do! lol.)

Regardless of whether we decide to silently create accounts or not, definitely agree w you @acherukuri that we shouldn't be defaulting to an id of 1, so glad that's been changed!

@acherukuri hey there! THANKS for working on this!!!
might we want to consider creating a user upon form submission?

a user that we don't tell the person we created, but we do it under the hood
then the email confirmation could be sent later in the process to a real user, rather than trying to fake out the system's created_by_id data?

if not, i'm ok w removing the user requirement as you've done. just thinking it might be better practice to create the accounts rather than skip the user. (then, we have the additional bonus that after we have more user-facing-user-account pages, we can email all "users" to invite them to actually log in by resetting the password vs creating a new account AND setting the password. not sure everyone else would think this is a bonus, but... :) i do! lol.)

Interesting line of thought! I find the approach of filling out a User under the hood to be appealing. Some questions:

What would happen if someone fills out multiple anonymous requests? Would we have a way of reconciling/consolidating their separate user records when they eventually create an account?
How would we then distinguish anonymous requests from those created by logged in users?

@acherukuri hey there! THANKS for working on this!!!
might we want to consider creating a user upon form submission?

a user that we don't tell the person we created, but we do it under the hood
then the email confirmation could be sent later in the process to a real user, rather than trying to fake out the system's created_by_id data?

if not, i'm ok w removing the user requirement as you've done. just thinking it might be better practice to create the accounts rather than skip the user. (then, we have the additional bonus that after we have more user-facing-user-account pages, we can email all "users" to invite them to actually log in by resetting the password vs creating a new account AND setting the password. not sure everyone else would think this is a bonus, but... :) i do! lol.)

@maebeale It's @exbinary who worked on this 😀


Standardize non keyvault parameter/variables to use _ instead of -

Fixing some parameter naming mismatches with caller and template and trying to make the naming more consistent.  I'm open to keeping all the variables coming from vso having - instead of _.  Reason for the change is VSO doesn't let parameters to a template have. - in them. And keyvault doesn't allow _.

Jim opened another I prefer


Upgrade zuul to v1.2.2

https://github.com/Netflix/zuul/releases/tag/v1.2.2
https://github.com/Netflix/zuul/releases/tag/v1.2.1
https://github.com/Netflix/zuul/releases/tag/v1.2.0

The following are updates to groovy filters that aren't part of the library
https://github.com/Netflix/zuul/commit/f9a462b81946e288b8dce776702bb90e44a648b0
https://github.com/Netflix/zuul/commit/11ae37f5928a7c81e374bb0ba64e6ead91f665df
https://github.com/Netflix/zuul/commit/262271981a6001d2afaca69d7559b848d88bc5ef
https://github.com/Netflix/zuul/commit/1a24fc6d25b15400b378bb636fb723576aa025b6


Problem with GBA LINK CABLE ROM Sender v1.2 by FIX94

Hi,
So with the latest update to version 1.1.0, it seems that the GBA file is not recognized. I'm using the Wii method with the Homebrew Channel, Wii Mod Lite, and GBA Link Cable ROM Sender v1.2. I've checked, and the files are in the correct folder (/gba). I’ve tried with the previous version, and it works. I've also tested both versions on a GBA emulator, and both seem to be fine.

Hey there! Just wanted to confirm that the problem was solved when the issue was closed- sorry it took so long to get back to you!!

Hey! My bad, sorry! I realized I just needed to right-click on the Wii Mod Lite interface to access version 1.1.0. Everything's all good now! Thank you for this project and for being so supportive :)


Deezer's API returns alternative release with different GTIN and availability

Lookup using all providers

Providers have returned multiple different GTIN:<PHONE_NUMBER>68 (Spotify, iTunes, Tidal),<PHONE_NUMBER>09 (Deezer)

Lookup without Deezer returns a release which is only available outside of Europe
Lookup using only Deezer returns a release which is only available in Europe with a different barcode
Does this happen because Deezer does not have the other release or because their API is queried from a European server?
We should probably adapt the Deezer provider to return an error message which contains the correct GTIN to lookup instead of returning the result.
GTINs with similar issues:

00602527812519 returns a different Deezer release which is available in 0 regions
00602527650579 even returns two other barcodes, one for Deezer (see case above), and one for iTunes (known issue)
5099908794857: US vs outside of US (Deezer) releases

The problem is actually even worse, the API does this not only for GTIN lookups but even for ID lookups:

ID 324028037 is available in AT/CH/DE, which returns the expected result when queried from DE but ID 53024752 when queried from FR, for example

No idea why Deezer suddenly changed the behavior of their API, but this makes the Deezer provider unusable for releases which are not available in the server's region :sob:

It is a change in behaviour, not too long ago these lookups were still working as expected.
Only recently we got an increasing number of GTIN conflicts caused by Deezer, previously iTunes was the main offender.
According to the logs the issue probably started on June 20:
harmony-log | grep "Providers have returned multiple different GTIN" | grep "(Deezer)"

The following thread on the forum indicates others have been  experiencing different API behaviour recently:
https://en.deezercommunity.com/other-devices-49/deezer-lms-plugin-for-squeezebox-suddenly-not-working-79033

For the time being I have at least made the Deezer provider fail lookups if they return an ID or GTIN which is different from the one which was requested: https://github.com/kellnerd/harmony/commit/4702fcb33183131823dd5620ca9925cf7990e319
Now combined lookups of multiple sources no longer fail because of a GTIN merge conflict.
The error message includes the returned release URL or GTIN, so it is simple to still get these Deezer results if that is desired.


Auto wait (is_ready)

Would be nice to make it possible that start() command that in nature are non-blocking became blocking (with timeout) through configuration.

We can copy from pybar.run_manager.RunManager - > run_run() method. Also have a look at thunkify() decorator.


GH-1032: Add consumer-side batching support

Resolves https://github.com/spring-projects/spring-amqp/issues/1032

Needs (a lot) more tests
Needs support in @RabbirtListener

I think that is type: "Needs support in @RabbitListener"

OK; will issue a new PR for additional tests and @RabbitListener work.


MAISTRA-1739 Fix validation of AuthorizationPolicy fields

It would previously detect the field request.regex.headers as invalid, even though it is supported.
I'm adding a hold as this will only go into 1.1.8

Good point. I added a test

/retest

/retest


One space formatting fix

You know, I like to see beautiful code, so really hope we have auto formatter, such that all these (at least such formatting error) can be done automatically!
Pre-launch Checklist

[ ] I read the Contributor Guide and followed the process outlined there for submitting PRs.
[ ] I read the Tree Hygiene wiki page, which explains my responsibilities.
[ ] I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
[ ] I signed the CLA.
[ ] I listed at least one issue that this PR fixes in the description above.
[ ] I updated/added relevant documentation (doc comments with ///).
[ ] I added new tests to check the change I am making, or this PR is test-exempt.
[ ] All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

I've updated the PR title for a clear&concise commit message.
There is no auto formatting in the framework code, instead the analyser runs a series of checks. I guess one could look at adding one for unnecessary spaces like this with care to avoid false positives (e.g. text in quotes etc.).

@tgucio Thank you! However, I hope to remain at least one "tiny", because then readers will quickly realize this is super small and will not catch their eyes (e.g. when looking at code history).


Added go.mod to config-seed properties folder

#1030
This is a preparatory effort and does not have a material effect on the build since GO111MODULE is not explicitly set. Per the issue above, we need to add this file to get the device-sdk-go module to ignore the config-seed/res/properties directories containing semi-colons. Device-sdk-go is our target first module project.
Signed-off-by: Trevor Conn<EMAIL_ADDRESS>

Could u plz merge this commit into delphi branch?


some issue about the instrumentation in LAVA-M

Hi! When I was using afl-clang-fast to instrument the programs in the LAVA-M set, I finished CC=~/afl-clang-fast CXX=~/afl-clang-fast++ ./configure --prefix=pwd/lava-install LIBS="-lacl", and it shows no error, and when I input make to get the instrumented program, I met the following error:

How can I solve this problem? I would be very grateful if you can take the time to answer this. Thanks a lot.

Can you try a newer clang? Looks like the compiler is crashing for some reason.
@lszekeres may have a better suggestion than I do.

+1 trying new llvm/clang version. what version are you currently using?
If that doesn't work, could you get and paste the stack trace of the crash?

thxs, I reinstall my clang and solved this problem!

Awesome!


use Ringbuf as default map over kernel version 5.8

use Ringbuf as default map over kernel version 5.8. Since ringbuf get better performance and ordered the msgs

Close for now


[Mgmt][Compute] Remove global configuration "multiapi"

https://github.com/Azure/azure-sdk-for-python/issues/24540

/azp run


Polyfill WebSerial with WebUSB for Mobile devices

Checklist

[X] Checked the issue tracker for similar issues to ensure this is not a duplicate.
[X] Described the feature in detail and justified the reason for the request.
[X] Provided specific use cases and examples.

Feature description
Mobile Android browsers/devices only support WebUSB ans so esp-idf-web is currently incompatible with them. VSCode Web also supports USB access so it could be polyfilled.
Use cases
Use code server with a low power Android device.
Alternatives
No response
Additional context
I was already working on the polyfill with the libary from google, but now I will have to change it a bit.
Would you accept a PR?

Yeah sure thing, thanks !


Error when running for first time if database hasn't been populated.

Error details:
Error from Forms when no data in the database, noticed from DateForm.
How to replicate:
Fresh install, run python manage.py runserver
Error output
AttributeError: 'NoneType' object has no attribute 'date'
This can be solved by populating the db, with python runscript -v2 populate_db

can just add this a constraint also to the readme to say the script must be run first.
@rklocke will it cause issues with calculations if it was run during the day and then at midnight, or would the first days calculations just be slightly smaller?

@jethror1 should be easy to solve, it's just because it gets the earliest date in the DailyOrgRunningTotals table to set the earliest possible date that can be selected on the form datepicker. Could check if first_date is empty (no entries in db), and if so then set the 'min' on the datepicker to today.
if it was run in the day then just after midnight, it should just mean the first day's calculations are smaller. If it was run twice in a single day I think it would just overwrite the running total values (as there is a unique date constraint) but would cause issues for other tables as too many rows would be added.
can add fix above when everything is merged?

The issue is solved by not having db connection in forms.py when running migration but only initiate db connection when form class is called.


Enhancing the calculation of Link Margin

Couple of ideas:

Calculating the link margin based on running average of rssi
Using a running average noise-floor for calculation of link margin
Considering to add hysteresis for converting link margin to quality (per spec)

Resolevd in #197.


Differing projection in annotator input

Now that elements can be added as input to annotators, I would expect that each element could have its own projection. For example, I have a reservoir_df that is in UTM and a dam_df data frame that is in Plate Carree. I could feed these as data frames directly into the annotator, but to define the distinct projections, I converted them to gv objects each with their own projection. However, when I feed these into PolyAndPointAnnotator it doesn't honor them. If I give the annotator a crs, I think it overrules everything. If I don't give a crs and just give the gv objects (one as polys and one as points) it takes the first one and assumes the second is the same. Shouldn't it just honor the projection of the element?

Closing.


Add trusted proxy functionality and fixed two typos

Proposed Changes

(Describe the changes and rationale behind them)

I added functionality to write configuration variables to the .env file which the Firefly III application will then use.
Also I fixed two typos in the config.yaml.
Related Issues

#15

merging despite error on docker build. Fix on next PR


Adds example

This PR provides a quick deployment option in order to manually spin up an Envoy container with Coraza-proxy-wasm and the CRS enabled, working in Anomaly Scoring mode (once a certain threshold is reached, requests are going to be denied).
Note that:

example/tests.sh: Has been temporarily added in order to provide immediately a first test that can be manually executed. Soon it is going to be replaced (and most likely deleted) in favor of an updated one that will be under e2e/
WIP: Readme about example usage

Shall we run the example on CI?

The real and only difference was about embedding or not the CRS (e2e was intended to test basic Coraza phases without CRS). I agree about the overlap, working on merging e2e and example logic

Updated: I split the work opening another PR to address the e2e refacor, It may require some specific conversations about response body.

Somehow<EMAIL_ADDRESS>makes the linter work fine but<EMAIL_ADDRESS>breaks it. It am not 100% sure it is the library itself or just a bad dependency resolution but let's defer this to a next PR.
For now I am opening a new PR to get this finally merged https://github.com/corazawaf/coraza-proxy-wasm/pull/30


feat: migrate stacks generate txs, closes LEA-1732

This PR migrates code from the extension to generate the unsigned stacks tx for the STX send flow.
Approach here now uses a separate Provider for each chain/protocol form so that we can handle loading data in the provider. I also did a version using our loader pattern, which seemed ok too, but felt using this approach might be more straightforward with using React context for the forms. We can add a loading state later, etc.
I also removed any helper functions I wasn't directly using with generating the unsigned tx. I realized I had ported over some unnec functions for this work. I got rid of all the stacks connect types.
I did add two new money formatters that can eventually help to replace stacksValue, thought I didn't end up needing them anywhere for now.

I used an approach where for each form we have a SendForm.StacksSetter (or appropriate chain/prototool) to set nec form data. We do this in the extension with NonceSetter. I think we can use this later to load/set fee values, etc. Open to other ideas here too.

I would investigate options where we do not even render the form components until we have this data loaded from the external source. Either the loader pattern, or some kind of route loader if Expo has those.

Great work @fbwoolf
Lots to discuss here though. I think there's some code, and general patterns here, we might want to reconsider bringing over if possible

Yep, agree, I was debating abt just doing a draft PR but wasn't sure how quickly we wanted to push the send form forward. I'll change this to draft and tackle some of the refactoring you pointed out. I mostly wanted to make sure I got feedback on effort here so far. 👍

I am going to open this open for review again. Open to feedback on using the separate providers here vs our loader pattern. I'm happy to switch if people prefer the loader pattern. Expo router doesn't offer loaders.

Working a bit more here to split up the providers bc currently they are named incorrectly. They need to be protocol specific.

Looking at this closer, it might be that we want separate providers per protocol for flexibility, but use the loader pattern per chain so we don't duplicate efforts with loading chain data like fees and nonces. Might try adding that as a next step.

@kyranjamie hoping to get your feedback on how I've addressed your questions. I am now handling all undefined values thru a form loader component, which I think is working well.


IcoMoon icon name synonyms

An icon may have few names. For example, name = "spinner, loader, progress, waiting"

Duplicate of https://github.com/oblador/react-native-vector-icons/pull/946


fix(variance): Ensure array scales always qualify for transformation

Overview

Array scales didn't trigger transformation flow for values.  This explicitly adds a check explicitly for arrays and adds a test to validate the behavior.
Improves logic for looking up scalar values with a hof that returns the appropriate logic (computations were unnecessarily checking the types of scales)
Splits out helpers to a separate file.

PR Checklist

[ ] Related to designs:
[ ] Related to JIRA ticket: ABC-123
[x] I have run this code to verify it works
[x] This PR includes unit tests for the code change

📬Published Alpha Packages:@codecademy/gamut-icons@5.8.2-alpha.7aeed7.0@codecademy/gamut-illustrations@0.17.16-alpha.7aeed7.0@codecademy/gamut-kit@0.5.25-alpha.7aeed7.0@codecademy/gamut-labs@19.19.11-alpha.7aeed7.0@codecademy/gamut-patterns@0.5.4-alpha.7aeed7.0@codecademy/gamut-styles@11.7.2-alpha.7aeed7.0@codecademy/gamut-tests@2.4.19-alpha.7aeed7.0@codecademy/gamut@36.1.1-alpha.7aeed7.0@codecademy/konamimojisplosion@0.2.50-alpha.7aeed7.0@codecademy/markdown-overrides@0.5.62-alpha.7aeed7.0@codecademy/styleguide@43.1.1-alpha.7aeed7.0<EMAIL_ADDRESS>
🚀 Styleguide deploy preview ready!https://61156afa4cb892106c0159d9--gamut-preview.netlify.appDeploy Logs

🚀 Styleguide deploy preview ready!https://611571297edd2d1b48090288--gamut-preview.netlify.appDeploy Logs

📬Published Alpha Packages:@codecademy/gamut-icons@5.8.2-alpha.35a64e.0@codecademy/gamut-illustrations@0.17.16-alpha.35a64e.0@codecademy/gamut-kit@0.5.26-alpha.35a64e.0@codecademy/gamut-labs@19.20.1-alpha.35a64e.0@codecademy/gamut-patterns@0.5.4-alpha.35a64e.0@codecademy/gamut-styles@11.7.2-alpha.35a64e.0@codecademy/gamut-tests@2.4.19-alpha.35a64e.0@codecademy/gamut@36.1.1-alpha.35a64e.0@codecademy/konamimojisplosion@0.2.50-alpha.35a64e.0@codecademy/markdown-overrides@0.5.62-alpha.35a64e.0@codecademy/styleguide@43.2.1-alpha.35a64e.0<EMAIL_ADDRESS>
🚀 Styleguide deploy preview ready!https://61157fc616db1a2781efcefc--gamut-preview.netlify.appDeploy Logs

📬Published Alpha Packages:@codecademy/gamut-icons@5.8.2-alpha.dc88cf.0@codecademy/gamut-illustrations@0.17.16-alpha.dc88cf.0@codecademy/gamut-kit@0.5.26-alpha.dc88cf.0@codecademy/gamut-labs@19.20.1-alpha.dc88cf.0@codecademy/gamut-patterns@0.5.4-alpha.dc88cf.0@codecademy/gamut-styles@11.7.2-alpha.dc88cf.0@codecademy/gamut-tests@2.4.19-alpha.dc88cf.0@codecademy/gamut@36.1.1-alpha.dc88cf.0@codecademy/konamimojisplosion@0.2.50-alpha.dc88cf.0@codecademy/markdown-overrides@0.5.62-alpha.dc88cf.0@codecademy/styleguide@43.2.1-alpha.dc88cf.0<EMAIL_ADDRESS>
🚀 Styleguide deploy preview ready!https://61158351b851f42d7291d7d9--gamut-preview.netlify.appDeploy Logs

📬Published Alpha Packages:@codecademy/gamut-icons@5.8.2-alpha.8588b0.0@codecademy/gamut-illustrations@0.17.16-alpha.8588b0.0@codecademy/gamut-kit@0.5.26-alpha.8588b0.0@codecademy/gamut-labs@19.20.1-alpha.8588b0.0@codecademy/gamut-patterns@0.5.4-alpha.8588b0.0@codecademy/gamut-styles@11.7.2-alpha.8588b0.0@codecademy/gamut-tests@2.4.19-alpha.8588b0.0@codecademy/gamut@36.1.1-alpha.8588b0.0@codecademy/konamimojisplosion@0.2.50-alpha.8588b0.0@codecademy/markdown-overrides@0.5.62-alpha.8588b0.0@codecademy/styleguide@43.2.1-alpha.8588b0.0<EMAIL_ADDRESS>
🚀 Styleguide deploy preview ready!https://61158c4b65dc4c3a3e837fea--gamut-preview.netlify.appDeploy Logs


gpio: add function to get current configuration of pin

Zephyr doesn't contain any function to read current gpio configuration, which may be useful if pins are multipurpose, or if it may be needed to display information about gpios.
This PR adds support for functions to get current configuration of GPIOs and implements it in the drivers for emul, npcx, ite, gecko and stm32.
If driver doesn't implement this function, the gpio_pin_get_config will return the -ENOTSUP.

@chrta @erwango could you take another look?

@mnkp @henrikbrixandersen @gmarull could you please take a look?

Given that likely not many applications would need this functionality, should this API be made optional, disabled by default via Kconfig?

Agreed

Please make this an optional API, disabled by default via Kconfig. The test case, of course, needs to enable it.

Done

Seems we have two very related PRs for extending the GPIO API with query functions. This one and https://github.com/zephyrproject-rtos/zephyr/pull/40325.

@semihalf-barnas-michal - would you be open to working together to create a combined PR for this and #40325? Link to my thoughts on Discord.
https://discord.com/channels/720317445772017664/883445484923011172/981725137688723486
Synopsis:
// basically everything could wrap around this syscall
// map := bitmap of pins being queried in the given port. not an error to specify -1
// e.g. map := 0b101, config => gpio_flags_t config[2];
__syscall int gpio_port_get_config(const struct device *port, gpio_port_pins_t map, gpio_flags_t *config);

int gpio_pin_get_config(port, pin, *config) {
  return gpio_port_get_config(port, BIT(pin), config);
}

// I like the idea of specifying a map here and a single output variable
int gpio_port_get_direction(port, gpio_port pins_t map, gpio_port_pins_t *direction) {
  // either the caller provides a minimally-sized array for config or a maximally sized array goes on the stack here
  gpio_flags_t config[sizeof(gpio_port_pins_t) * sizeof(uint8_t)]; // 128 bytes currently

  *direction = 0;
  // for each bit set in map, set the relevant bit in *direction if config[i] & GPIO_OUTPUT.
}
...

I don't really care about copyright or anything, just interested in getting these API changes in, so I'm OK with

@semihalf-barnas-michal - would you be open to working together to create a combined PR for this and #40325? Link to my thoughts on Discord.
https://discord.com/channels/720317445772017664/883445484923011172/981725137688723486
Synopsis:
// basically everything could wrap around this syscall
// map := bitmap of pins being queried in the given port. not an error to specify -1
// e.g. map := 0b101, config => gpio_flags_t config[2];
__syscall int gpio_port_get_config(const struct device *port, gpio_port_pins_t map, gpio_flags_t *config);

int gpio_pin_get_config(port, pin, *config) {
  return gpio_port_get_config(port, BIT(pin), config);
}

// I like the idea of specifying a map here and a single output variable
int gpio_port_get_direction(port, gpio_port pins_t map, gpio_port_pins_t *direction) {
  // either the caller provides a minimally-sized array for config or a maximally sized array goes on the stack here
  gpio_flags_t config[sizeof(gpio_port_pins_t) * sizeof(uint8_t)]; // 128 bytes currently

  *direction = 0;
  // for each bit set in map, set the relevant bit in *direction if config[i] & GPIO_OUTPUT.
}
...

I don't really care about copyright or anything, just interested in getting these API changes in, so I'm OK with

@semihalf-barnas-michal - would you be open to working together to create a combined PR for this and #40325?

Sure, I don't mind working together to make this API possible.
I see that you have edited the comment, but you proposed to use the gpio get port with bitfield and pointer to array. I do not like the idea of having the array of "unknown" size and iterating over it based on the bits set in variable.
However the idea for getting the direction of whole port is nice.
Should we talk on discord to get a common idea of implementation?

would you be open to working together to create a combined PR for this and #40325?

@cfriedt Sure, I don't mind working together to make this API possible.
I see that you have edited the comment, but you proposed to use the gpio get port with bitfield and pointer to array. I do not like the idea of having the array of "unknown" size and iterating over it based on the bits set in variable.

The size of the array == popcount of the array, so it would definitely be known and the memory would be checked with z_verify. So not really an issue.

However the idea for getting the direction of whole port is nice.

Yeah, the tricky part is that most hardware has a set of word accessible direction / enable registers, so reading that with a single API call is quite cheap (as in #40325).
My original suggestion (getting that from config data) is much more expensive. It might make sense to have two syscalls.

Should we talk on discord to get a common idea of implementation?

Sure, sounds good 👍

The change from @cfriedt was merged, so I've rebased this on top of current main.

@henrikbrixandersen can you please review?


update Azure CLI for compatibility with Python 3.8

Describe the bug
latest build from home-brew (Mac) has incompatibilities with Python 3.8
/usr/local/Cellar/azure-cli/2.1.0/libexec/lib/python3.8/site-packages/azure/storage/blob/_upload_chunking.py:403: SyntaxWarning: "is" with a literal. Did you mean "=="?   if n is 0 or self._buffer.closed: /usr/local/Cellar/azure-cli/2.1.0/libexec/lib/python3.8/site-packages/azure/storage/blob/baseblobservice.py:1009: SyntaxWarning: "is not" with a literal. Did you mean "!="?   if lease_duration is not -1 and \ /usr/local/Cellar/azure-cli/2.1.0/libexec/lib/python3.8/site-packages/azure/storage/blob/baseblobservice.py:2660: SyntaxWarning: "is not" with a literal. Did you mean "!="?   if lease_duration is not -1 and \ /usr/local/Cellar/azure-cli/2.1.0/libexec/lib/python3.8/site-packages/azure/storage/common/_connection.py:82: SyntaxWarning: "is" with a literal. Did you mean "=="?   self.protocol = self.protocol if parsed_url.scheme is '' else parsed_url.scheme
see: https://docs.python.org/3.8/whatsnew/3.8.html#changes-in-python-behavior
The compiler now produces a SyntaxWarning when identity checks (is and is not) are used with certain types of literals (e.g. strings, numbers). These can often work by accident in CPython, but are not guaranteed by the language spec. The warning advises users to use equality tests (== and !=) instead. (Contributed by Serhiy Storchaka in bpo-34850.)
To Reproduce
probably many other ways, for me this arose with az acr login -n {registry}
Expected behavior
no syntax error reporting
Environment summary
brew install azure-cli
{   "azure-cli": "2.1.0",   "azure-cli-command-modules-nspkg": "2.0.3",   "azure-cli-core": "2.1.0",   "azure-cli-nspkg": "3.0.4",   "azure-cli-telemetry": "1.0.4",   "extensions": {     "interactive": "0.4.3"   } }

HI @fengzhou-msft  could you pls help to have a look? thanks.

This warning comes from a dependency SDK azure-storage-blob==1.5.0. We will check with newer versions.

The version bump of azure-storage-blob relies on track 2 adoption. We'll do it after we add support for track 2 SDKs.

Same problem with the command az acr show --query "id" --output tsv
Azure cli installed with homebrew:
This command is in preview. It may be changed/removed in a future release.
{
  "azure-cli": "2.3.1",
  "azure-cli-command-modules-nspkg": "2.0.3",
  "azure-cli-core": "2.3.1",
  "azure-cli-nspkg": "3.0.4",
  "azure-cli-telemetry": "1.0.4",
  "extensions": {}
}

Not sure if a new issue is warranted but I experience similar warnings with the bundled python 3.6 in the azure-cli RPM package. This happens to break terraform.
/usr/lib64/az/lib/python3.6/site-packages/jmespath/visitor.py:32: SyntaxWarning: "is" with a literal. Did you mean "=="?
  if x is 0 or x is 1:
/usr/lib64/az/lib/python3.6/site-packages/jmespath/visitor.py:32: SyntaxWarning: "is" with a literal. Did you mean "=="?
  if x is 0 or x is 1:
/usr/lib64/az/lib/python3.6/site-packages/jmespath/visitor.py:34: SyntaxWarning: "is" with a literal. Did you mean "=="?
  elif y is 0 or y is 1:
/usr/lib64/az/lib/python3.6/site-packages/jmespath/visitor.py:34: SyntaxWarning: "is" with a literal. Did you mean "=="?
  elif y is 0 or y is 1:
/usr/lib64/az/lib/python3.6/site-packages/jmespath/visitor.py:260: SyntaxWarning: "is" with a literal. Did you mean "=="?
  if original_result is 0:

@oszi a fix for your issue is on the way: https://github.com/Azure/azure-cli/pull/13435

Fixed with https://github.com/Azure/azure-cli/pull/13411, will be released with 2.6.0 next Tuesday.

This is the same issue with 2.6.0:
➜  ~ az group create
--name $RESOURCE_GROUP
--location $REGION_NAME
/usr/local/Cellar/azure-cli/2.6.0/libexec/lib/python3.8/site-packages/jmespath/visitor.py:32: SyntaxWarning: "is" with a literal. Did you mean "=="?
if x is 0 or x is 1:
/usr/local/Cellar/azure-cli/2.6.0/libexec/lib/python3.8/site-packages/jmespath/visitor.py:32: SyntaxWarning: "is" with a literal. Did you mean "=="?
if x is 0 or x is 1:
/usr/local/Cellar/azure-cli/2.6.0/libexec/lib/python3.8/site-packages/jmespath/visitor.py:34: SyntaxWarning: "is" with a literal. Did you mean "=="?
elif y is 0 or y is 1:
/usr/local/Cellar/azure-cli/2.6.0/libexec/lib/python3.8/site-packages/jmespath/visitor.py:34: SyntaxWarning: "is" with a literal. Did you mean "=="?
elif y is 0 or y is 1:
/usr/local/Cellar/azure-cli/2.6.0/libexec/lib/python3.8/site-packages/jmespath/visitor.py:260: SyntaxWarning: "is" with a literal. Did you mean "=="?
if original_result is 0:
{
"id": "/subscriptions/a481f10b-726d-493f-930f-ab1bee4b539a/resourceGroups/rg-nwi-aksworkshop",
"location": "northeurope",
"managedBy": null,
"name": "rg-nwi-aksworkshop",
"properties": {
"provisioningState": "Succeeded"
},

How was the "fix" validated? This issue very much exists with v2.6.
az cloud set --name AzureCloud
/usr/local/Cellar/azure-cli/2.6.0/libexec/lib/python3.8/site-packages/jmespath/visitor.py:32: SyntaxWarning: "is" with a literal. Did you mean "=="?
  if x is 0 or x is 1:

Still having this issue.
Azure CLI versions:
{
  "azure-cli": "2.6.0",
  "azure-cli-command-modules-nspkg": "2.0.3",
  "azure-cli-core": "2.6.0",
  "azure-cli-nspkg": "3.0.4",
  "azure-cli-telemetry": "1.0.4",
  "extensions": {
    "azure-devops": "0.11.0"
  }
}

<path-to-python-install>/python3.8/site-packages/jmespath/visitor.py:32: SyntaxWarning: "is" with a literal. Did you mean "=="?
  if x is 0 or x is 1:

Still having this issue as well:
$ az version
/usr/lib64/az/lib/python3.6/site-packages/jmespath/visitor.py:32: SyntaxWarning: "is" with a literal. Did you mean "=="?
  if x is 0 or x is 1:
/usr/lib64/az/lib/python3.6/site-packages/jmespath/visitor.py:32: SyntaxWarning: "is" with a literal. Did you mean "=="?
  if x is 0 or x is 1:
/usr/lib64/az/lib/python3.6/site-packages/jmespath/visitor.py:34: SyntaxWarning: "is" with a literal. Did you mean "=="?
  elif y is 0 or y is 1:
/usr/lib64/az/lib/python3.6/site-packages/jmespath/visitor.py:34: SyntaxWarning: "is" with a literal. Did you mean "=="?
  elif y is 0 or y is 1:
/usr/lib64/az/lib/python3.6/site-packages/jmespath/visitor.py:260: SyntaxWarning: "is" with a literal. Did you mean "=="?
  if original_result is 0:
{
  "azure-cli": "2.6.0",
  "azure-cli-command-modules-nspkg": "2.0.3",
  "azure-cli-core": "2.6.0",
  "azure-cli-nspkg": "3.0.4",
  "azure-cli-telemetry": "1.0.4",
  "extensions": {}
}

The issue with jmespath is fixed in 2.7.0. Issue with azure-multiapi-storage is tracked by #14083.

@fengzhou-msft You previously said this issue was fixed in 2.6.0, why should anyone believe you now?

@asarkar The PR to fix jmespath was planned to release with 2.6.0 but somehow missed the build date. Then it is merged and built into 2.7.0.

I'm still having this issue with 2.9.0.. More details in #14083 14083

Having this issue with 2.10 as well
az storage account list
/usr/local/Cellar/azure-cli/2.10.0/libexec/lib/python3.8/site-packages/azure/multiapi/storage/v2018_11_09/blob/_upload_chunking.py:403: SyntaxWarning: "is" with a literal. Did you mean "=="?
  if n is 0 or self._buffer.closed:
/usr/local/Cellar/azure-cli/2.10.0/libexec/lib/python3.8/site-packages/azure/multiapi/storage/v2018_11_09/blob/baseblobservice.py:1063: SyntaxWarning: "is not" with a literal. Did you mean "!="?
  if lease_duration is not -1 and \
/usr/local/Cellar/azure-cli/2.10.0/libexec/lib/python3.8/site-packages/azure/multiapi/storage/v2018_11_09/blob/baseblobservice.py:2719: SyntaxWarning: "is not" with a literal. Did you mean "!="?
  if lease_duration is not -1 and \
/usr/local/Cellar/azure-cli/2.10.0/libexec/lib/python3.8/site-packages/azure/multiapi/storage/v2018_11_09/common/_connection.py:82: SyntaxWarning: "is" with a literal. Did you mean "=="?
  self.protocol = self.protocol if parsed_url.scheme is '' else parsed_url.scheme
/usr/local/Cellar/azure-cli/2.10.0/libexec/lib/python3.8/site-packages/azure/multiapi/cosmosdb/v2017_04_17/common/_connection.py:91: SyntaxWarning: "is" with a literal. Did you mean "=="?
  self.protocol = self.protocol if parsed_url.scheme is '' else parsed_url.scheme

az version
{
  "azure-cli": "2.10.0",
  "azure-cli-command-modules-nspkg": "2.0.3",
  "azure-cli-core": "2.10.0",
  "azure-cli-nspkg": "3.0.4",
  "azure-cli-telemetry": "1.0.4",
  "extensions": {}
}


用户登录

VSCode Version:
OS Version:

Steps to Reproduce:
请求：希望加一个用户登录，可以同步自己的配置。

Does this issue occur when all extensions are disabled?: Yes/No

English please.
（请讲英文，用翻译软件也可以，不然没人理你……）
Please check if there is already an issue reported by someone.
（以后反馈之前先看看别人是不是早就反馈过了）

duplicate https://github.com/microsoft/vscode/issues/65567

English please. All non-English issues will be closed directly.
（请讲英文，非英文反馈都会被直接关闭）
Please check if there is already covered by an existing issue before you report every time.
（以后反馈之前先看看别人是不是早就反馈过了）

duplicate https://github.com/microsoft/vscode/issues/65567

Sorry for closing this, Please submit the issue in english.


Web export withoug GH pages

What would you like to see changed/added?
Option to disable GH Pages export when using "web" platform option.

How would you like this to work?

Maybe some secret or other method of configuration to control it?

Is a env var ok?


Consider napkin math comment for approximate Augur Ice Age

https://github.com/AugurProject/augur/blob/c1973d49be54288cce7d1b5d0c021ce22a8092ed/packages/augur-core/source/contracts/Augur.sol#L221-L223
I suspect that Augur can go for many upgradeCadence intervals before it stops working so this probably isn't an issue... but I think it would be valuable to add a comment with some napkin math on how many cadences before some contracts will stop working.

Do you mean like when factoring in a hypothetical state rent?

Ah, nevermind.  I misread this code the first time around.m I thought this was an unbounded loop (which it technically is) but it is only actually a loop at all if no one creates a market for an entire upgrade cadence.


Transformer tutorial

This is a little tutorial about how to use tensor2tensor for translation task. Because in first time its hard to understand how this library works.
I had to use this library for a project, I was wondering why not create a little tutorial at the same time, for help others.

Thanks! Could you click the CLA part? (We need this to accept the PR - let us know if there're any problems with that.)

@googlebot I signed it!

@googlebot I fixed it

@googlebot I fixed it.

Hi @afrozenator!  So much.
I added the license.


Bump COMPILER_VERSION to 2024.2

Description
Bump COMPILER_VERSION to 2024.2
Part of inmanta/lsm#693
Self Check:

[ ] Attached issue to pull request
[ ] Changelog entry
[ ] Type annotations are present
[ ] Code is clear and sufficiently documented
[ ] No (preventable) type errors (check using make mypy or make mypy-diff)
[ ] Sufficient test cases (reproduces the bug/tests the requested feature)
[ ] Correct, in line with design
[ ] End user documentation is included or an issue is created for end-user documentation (add ref to issue here: )
[ ] If this PR fixes a race condition in the test suite, also push the fix to the relevant stable branche(s) (see test-fixes for more info)

This PR is not required anymore because we decided to implement https://github.com/inmanta/lsm/issues/693 in a backwards compatible way.


Poor performance with lots of markers

We have a skyblock world with hundreds of islands and we are displaying a marker for every island. This causes the map to be very unresponsive and even taking multiple seconds to display. Maps without that many markers load without any delay.
I think that this could be fixed by not displaying markers that are outside of the viewport (that is, not even adding them to the DOM). It would also be useful if there was an option to only show certain markers at a certain zoom level.

It would also be useful if there was an option to only show certain markers at a certain zoom level.

but that option already exists. Search for minzoom here.

@SimonOrJ Thanks, I didn't know about that option. But the performance still isn't as good as it could be.

Bump


sources of webflow are not up to date

Hello, sources on https://github.com/lime-company/powerauth-webflow/releases are not up to date. Sources in downloaded zip file are different then sources which there are cloned via git.

What command do you use to clone soutces?

git clone https://github.com/lime-company/powerauth-webflow.git powerauth-webflow (but problem is in case when i download sources as zip)

The release zip is created from stable source code which is present in the master branch.
The default branch is develop after git clone. This branch is used for development and does not contain stable source code.
$ git clone https://github.com/lime-company/powerauth-webflow.git
Cloning into 'powerauth-webflow'...
remote: Counting objects: 15604, done.
remote: Compressing objects: 100% (179/179), done.
remote: Total 15604 (delta 61), reused 374 (delta 40), pack-reused 15160
Receiving objects: 100% (15604/15604), 2.85 MiB | 538.00 KiB/s, done.
Resolving deltas: 100% (4537/4537), done.
$ cd powerauth-webflow
$ git status
On branch develop
Your branch is up to date with 'origin/develop'.

nothing to commit, working tree clean

I believe this is the reason why sources differ between clone and zip. If you want to get the same sources, please compare the same branches and same commit (the zip contains source code frozen for the release at a particular commit).

Already explained over the phone support.


Upgrade EPSG to 8.6.1

Before add index 8.6.1 was index 8.6 deleted. Commit e8b90a521e6001271356e6fe4df460d308fb267d


Display part of the copied sequence in the notification toast

When a sequence is copied in the "Sequence" tab, a notification toast appears saying "Selection Copied".
It would be helpful for users to see the start/end/both of the sequence to make sure they copied the appropriate frame or strand.

Yes, I had a look at Benchling and it is quite nice that they display that. As I mentioned in #216, I think it would also be nice to include "Copied top strand sequence" or bottom, so that people are sure what was copied.
To do that with OVE, see here, the onCopied property of the editor could be overriden. In fact, we should probably overload those toasts with our own because they also do other things. For instance, I noticed that when copying, the y-scroll position snaps to top. I don't think this is something SYC is doing, but worth double-checking.


Fix TSBridge UserAgent presentation

Currently TSBridge just sends requests with standard google-cloud-go user agent, leaving the application bit empty.
Let's pick user agent from packer:
google-api-go-client/0.5 Packer/1.6.3 (+https://www.packer.io/; go1.15.2; linux/amd64),gzip(gfe)
google-api-go-client/%VERSION% ts-bridge/%VERSION% (go%VERSION%; %PLATFORM%)

, e.g.:
google-api-go-client/0.5 ts-bridge/0.1 (go1.13.2; linux/amd64)

@nerdinary Adi, PTAL


Merge Two Sorted Arrays

📥 Pull Request
Description
The "Merge Two Sorted Arrays" idea focuses on creating an efficient solution for combining two pre-sorted arrays into a single sorted array. This functionality is essential in various applications, such as data processing, search algorithms, and efficient memory management.
Fixes #1283
Type of change

[ ] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[x] Documentation update

Checklist:

[x] My code follows the style guidelines of this project
[x] I have performed a self-review of my code
[x] I have commented my code, particularly in hard-to-understand areas
[x] I have added tests that prove my fix is effective or that my feature works
[x] New and existing unit tests pass locally with my changes
[x] Any dependent changes have been merged and published in downstream modules

@ajay-dhangar the task has been completed.

Done @ajay-dhangar


Process requests concurrently

This server did not put concurrency into concern at the beginning.
It is quite a difficult job to make sure of everything working well in a concurrent environment.


Adversarial Trainer progress bar

When initiating an adversarial trainer defence and fitting a training set, the progress bar is malfunctioning, it shows something like
Epoch 1/1 1/1 [==============================] - 0s 243ms/step - loss: 0.5083 - accuracy: 0.8477 Epoch 1/1 1/1 [==============================] - 0s 247ms/step - loss: 0.5404 - accuracy: 0.8281 Epoch 1/1 1/1 [==============================] - 0s 249ms/step - loss: 0.4848 - accuracy: 0.8594 Epoch 1/1 1/1 [==============================] - 0s 243ms/step - loss: 0.3498 - accuracy: 0.9023
which from what I can see is one line per each mini-batch

Hi @hussainkarafallah Thank you for using ART and raising this issue! We will take a look as soon as possible.
Would you be interested to investigate a possible solution?


Duplicate response messages sent when multiple browser tabs/windows are open

I'm using this to send messages to users that may have multiple tabs/windows open. I noticed in this case duplicate messages are sent from the proxy. I can also reproduce this with the demo, https://github.com/mthizo247/zuul-websocket-support-demo.
When using the demo, start the proxy and hello app. Open two tabs or windows going through the proxy, http://localhost:7078/, and click connect on both. Enter your name in the "What's your name?" input box, then click send. Observe in the console that two "MESSAGE" responses are received in both. If you have three tabs or windows open, then three "MESSAGE" responses are sent to each.
If you do the same thing going directly to the hello app, http://localhost:7079/, you don't get the duplicate messages.

For me it looks like ProxyWebSocketConnectionManager making subscription per raw destination is the issue.
For example:
If the user subscribes to /user/topic/messages it should be mapped to something like "/user/xxx/topic-[SESSION_ID], which will make the user receive only messages targeting his session.
/org/springframework/messaging/simp/user/UserDestinationMessageHandler.java might be the hint
@mthizo247 What do you think?

I got the same problem, I tried to send a topic message, the message would be received twice when there was two tabs.

Do you have sloved it?@tkec

No @minlingchao1

I have soled it

@minlingchao1 Could you share your solution, please?

as in my project , we authenticate users by token, so principal is not available, so , i conbined toUserId with the payload, and then convertAndSendToUser ...


app: unlink frontend sessions

Unlink frontend sessions. State updates are sent from the server via the /events endpoint, which an open connection using Server-Sent Events.
Note: it'll still retrieve state of whoever modified it last when you refresh, but otherwise it doesn't refresh the page when someone else changes the search/filter or dataset.
https://user-images.githubusercontent.com/3599407/222297446-e55e3c9c-09ad-482b-ad96-7702d1d1cbdf.mp4
https://app.asana.com/0/1203968572964807/1203576734637210/f

hm, how does this not mess up pagination for user A if user B changes the sort order?

Each request for samples includes the "View" (dataset name, sort, start index, etc.). I can double check with a larger dataset.

hm, how does this not mess up pagination for user A if user B changes the sort order?

Opened two tabs - sorted by metadata.size_bytes one ascending and one descending. When scrolling down the first it stayed ascending, and then scrolling the other stayed descending.


Updated search by name function

closes #54

This is ready for review
Note: The final test will continue to fail (and may need rework) till we merge #28 and fix up the json of the already stored data

Think the change might be causing a problem when putting any name into the top searchbox, the filter does not work and there's an error: Uncaught TypeError: d.common_names.concat(...).join is not a function at index.vue:96:46 at Proxy.filter () at Proxy.filterByName (index.vue:95:21) at Proxy.applyAllFilters (index.vue:53:22) at Proxy.handleSearch (index.vue:257:12) at callWithErrorHandling (chunk-SBFBVZFQ.js:1779:18) at callWithAsyncErrorHandling (chunk-SBFBVZFQ.js:1787:17) at emit (chunk-SBFBVZFQ.js:2228:5) at Proxy.search (NavigationBar.vue:65:12) at _createElementVNode.onInput._cache.._cache. (NavigationBar.vue:16:46)

Unfortunately, this is because the json data in the main branch is out of date with the structure the new code expects, we need to fix the data with the correct structure as per my previous commend in #28 and merge those changes before the code in this PR works. Perhaps we should merge that branch in first?


Added commandLineParser.ts to the generated node module

Added commandLineParser.ts to the generated node module, and added thetype information for commandLineParser.ts to typescript_internal.d.ts.

Hi @steveluc, I'm your friendly neighborhood Microsoft Pull Request Bot (You can call me MSBOT). Thanks for your contribution!

This seems like a small (but important) contribution, so no Contribution License Agreement is required at this point. Real humans will now evaluate your PR.

TTYL, MSBOT;

:+1:

:+1:


add unofficial venues request

Hi there. I added support for an api request which is not documented on stockfighter. It returns the list of venues available on the stock exchange.

Hey, this is awesome, thank you! Could you just squash those commits together into one nice clean one, then I think we'd be good to merge :grinning:

Done.

I have a branch called 'websockets' on my fork where I have added additional features, including websockets and unofficial gamemaster endpoints. Not really used to writing ES6. Do you want to check it out, discuss the code offline, and maybe talk about where you see your repo going forward?

@jziggas yeah absolutely, i was planning on adding websocket support but haven't had a chance to do so yet. Let me know when/how you want to chat about it and we can make it happen!