componentWillReceiveProps warning with React 16.9

Hello,
After updating react and react-dom to v16.9.0, this warning appears:
react-dom.development.js:11494 Warning: componentWillReceiveProps has been renamed, and is not recommended for use. See https://fb.me/react-async-component-lifecycle-hooks for details.

* Move data fetching code or side effects to componentDidUpdate.
* If you're updating state whenever props change, refactor your code to use memoization techniques or move it to static getDerivedStateFromProps. Learn more at: https://fb.me/react-derived-state
* Rename componentWillReceiveProps to UNSAFE_componentWillReceiveProps to suppress this warning in non-strict mode. In React 17.x, only the UNSAFE_ name will work. To rename all deprecated lifecycles to their new names, you can run `npx react-codemod rename-unsafe-lifecycles` in your project source folder.

Please update the following components: Motion

According to https://reactjs.org/blog/2019/08/08/react-v16.9.0.html#renaming-unsafe-lifecycle-methods, the componentWillReceiveProps is now deprecated and will be removed from the API on the next major version.

Any update on this ?

When is the reminder to publish set for? Are there any other maintainers who might be able to help you out and publish this in the meantime? I know it's annoying to have people nagging, but getting the newer React support updated would be super helpful! Thank you!

Ah interesting... so sounds like the change is already there and we just need a new version published to npm?
If the maintainers give me the permissions I'll happily do that.

yes, please!

...and now it's 2021 🥺

Someone has forked react-motion to fix this issue: see this thread

Perhaps other projects should reference the fork

@nkbt Any update on this? If there's a need for help with maintaining this, I'm sure there's competent people here willing to help...

I am still getting notifications and emails, btw =)
It is not just the matter of approving PR and pushing new release unfortunately (oh I wish it would be)
Here is some context. It is hard for me to test react-motion in real-world product as I no longer work with any projects using react-motion. So the only way for me now would be to use demo examples only (I remember having a few edge cases beyond those). Also I never really used or worked with anything except main Motion component (plus core), so have basically no idea about things like staggered motion, etc. There was partially completed refactoring which we did not get finished as contributor vanished and I did not have any spare time to finalise all the work myself, thus releasing new version to the public was blocked (still is, as it turns out). Should have reverted all back in hindsight...
@RaddishIoW There were few cases people jumping on and helping out with the library one or a few times and then leaving, so not like there was anyone specific committed to do full on support work on it.
Generally it's quite hard to squeeze opensource in between all the life things like family, baby, travelling, work, personal projects, unless it is used in your work projects and you have ability to contribute as part of your day job (which is not the case for me anymore for quite a while now).
I'll see if I can do anything, but cannot promise much at this point. I want to make sure it is in shape to safely do patch releases without breaking changes (check past PRs and revert unfinished work from master). Then it would be in a maintenance mode (just keep updating critical deps, etc).

2021

How can an amazing project with 20k stars, conf presence (react europe talk), and a fantastic api be abandoned like this by the owner(s)? Completely understand if the owners/contributors don't have time anymore for the project, no blame in that, but couldn't one try in that case to delegate some ownership so someone can simply publish a new version of this package with the necessary code change already being there?

这是来自QQ邮箱的假期自动回复邮件。

您好，我最近正在休假中，无法亲自回复您的邮件。我将在假期结束后，尽快给您回复。

2023

这是来自QQ邮箱的假期自动回复邮件。

您好，我最近正在休假中，无法亲自回复您的邮件。我将在假期结束后，尽快给您回复。

2024

这是来自QQ邮箱的假期自动回复邮件。

您好，我最近正在休假中，无法亲自回复您的邮件。我将在假期结束后，尽快给您回复。

Here we are, almost in 2025, and still nothing. This is abandoned.

这是来自QQ邮箱的假期自动回复邮件。

您好，我最近正在休假中，无法亲自回复您的邮件。我将在假期结束后，尽快给您回复。


Page Reload Issue

Hey, just installed this package, and I'm having an issue where the page is refreshed, the user object doesn't seem to be getting fetched from the session.
Effectively doing something like the following and on page refresh, userData doesn't seem to be getting set (or at least triggering a rerender).
Thanks in advance.
import React from 'react';

import { useAuth } from 'oidc-react';

export const AuthButton: React.FC = () => {
  const auth = useAuth();

  if (!auth.userData) {
    return (
      <button onClick={() => auth.signIn()}>log in</button>
    );
  }

  return (
    <button onClick={() => auth.signOut()}>log out</button>
  );
}

Additional context, this is specifically when autoSignIn={false}.

Hello,
Thank you for the issue! You have covered you app with <AuthProvider>?
Let me test this out on my test repository.

@cobraz , I have the AuthProvider wrapped around my Router in my App.tsx, so it should definitely be available in the component that I'm calling it in, although I have some other providers (like the ApolloProvider) on a higher level.

@cobraz any progress on this? Just upgraded to alpha.5 and the problem persists.

Can you provide an example repository? It would help a lot!

Hey, I ended up switching to react-oidc, thanks again!


create the frontend

too lazy to write the issue, got some work to do, just read this:

@elianiva dic aku masukin @farhan443 jadi collaborator buat frontend yak

siip

bisa pake https://codemirror.net/


Faucet doesn't work with sapling addresses

As there is a check of the length of the address the faucet only recognises Sprout addresses and so won't work with Sapling addresses see https://github.com/zcash/zfaucet/blob/master/faucet/views.py#L78
In addition to the above, even if it did detect Sapling addresses correctly it would likely hit an issue sending from a Sprout address to a Sapling one (or vice versa) directly as it is just using the first returned address from z_listaddresses.
A suggested hacky quick fix could look something like the following https://github.com/garethtdavies/zcash-faucet/commit/ffbfffcd7a033674dd74b9d2e28ed0ac65c48236 where transparent addresses are used to send Sapling txs to keep existing support for Sprout txs. This is utterly untested and uses this method https://github.com/arcalinea/pyZcash/blob/master/pyZcash/rpc/ZDaemon.py#L93 to get the sending t-addr as the existing transparent stuff doesn't use z_sendmany so doesn't have this issue.
A better fix would involve invoking z_validateaddress to detect Sapling/Sprout addresses and selecting the sending address appropriately.

Just updating this. The reason I didn't make a PR and test the above is that I ran into some issues during the setup (I can't recall what exactly). If anyone wants to get this into a working Docker container that'd be awesome 👍


Fixing irb experiment Make file and removing tf dependence

What this PR does / why we need it:
Which issue(s) this PR fixes:

Fixes #
Special notes for your reviewer:
Does this PR introduce a user-facing changes and/or breaks backward compatability?:

Hi @berserkr , thanks for the PR.
Would you please elaborate on

the "fix" to the Makefile
why the dependency should be removed?

Also, if a removal is indeed necessary, then the lines should actually be removed, rather than commented.

Hi @berserkr , thanks for the PR. Would you please elaborate on

Sure, np :)

the "fix" to the Makefile

The Makefile does not have a build tag, so the container is not being built. The Make file has a docker tag instead. The fix is to rename the tag to build.

why the dependency should be removed?

Yes, so TF is not actually used through the demo. This is a PyTorch demo with no calls to TF other than the __version__ property.  I was getting TF failures on my end, for some reason it was complaining about TF GPU not being loaded properly. So, although it could be an environment issue, after debugging I realized that the TF dependency is not really needed..

Also, if a removal is indeed necessary, then the lines should actually be removed, rather than commented.

Should've removed it, old habit to make sure I discuss it before removal :)

@berserkr Thanks for creating this PR! Let me run this locally. I have the feeling that a few more changes are needed to make the demo working (again) :)

@berserkr I was able to reproduce the issue. As already mentioned, there are a few more changes needed to make the IRB demo run smoothly again. I've pushed yet another commit to this PR to add all the changes. Please have a look and check if this demo now runs without any problems.


Add possibility to remove all snapshots by aggregate type

resolves https://github.com/prooph/snapshot-store/issues/3

This uses the mongodb client api. We can improve performance by using the internals directly.

Coverage remained the same at 100.0% when pulling d28cbd629bec4ecc01162eb71f475adf7a487545 on remove_all into 02d8cd15032ab73b79cb194d2884741cac572028 on master.

Just checked the internals again, there is no way to improve performance light I thought there would be. The files have to get queried first, because you cannot delete the chunks other by id, so this is the best way to remove those files.
The only performance optimization I can think of, is to drop the whole collection, if $gridFsName !== $this->defaultSnapshotGridFsName

Coverage remained the same at 100.0% when pulling f0d7428a978a14e1dc35aeb858740de71e9cd599 on remove_all into 02d8cd15032ab73b79cb194d2884741cac572028 on master.

Coverage remained the same at 100.0% when pulling c7e1ffb367788260c3d2a6f4d833c0196e9b34eb on remove_all into 02d8cd15032ab73b79cb194d2884741cac572028 on master.


Cant monitor Fearward

I cannot see active fearwards in my raidgroup - WoW classic
any idea?

Update: i can see Fearward now BUT i also monitor renew.
everytime renew is active on the target the icon is in teh ssame position as ferward - so i cant see the fearward.

yes, the way it is coded right now, each spot will only show a single icon, and whichever the most recent icon to update will show over the top of any others in the same position. I recommend you put different abilities into different positions, which will allow you to see 9 different auras at once.


[monitor/monitor-opentelemetry] Update Testing Coverage

Packages impacted by this PR
@azure/monitor-opentelemetry
Checklists

[x] Added impacted package name to the issue description
[x] Added a changelog (if necessary)

API change check
API changes are not detected in this pull request.


Fix camera plugins initialisation

Description
Since the MediaManager work, there's an issue with the Camera plugin init. This PR tries to fix that.
Type of change

[x] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist

[x] I've read & comply with the contributing guidelines
[ ] I have tested my code for new features & regressions on both mobile & desktop devices, using the latest version of major browsers.
[ ] I have made corresponding changes to the documentation (README.md).
[ ] I've checked my modifications for any breaking changes.

closing, as it's been backported in https://github.com/Genymobile/genymotion-device-web-player/pull/59


Change (some) callbacks to only trigger when complete.

This is a proof-of-concept PR for the issue raised in https://github.com/jpodwys/cache-service/issues/22.  In particular, the caller-provided callback is only called when all of the cache modules have completed.
In making this change, I discovered several other issues that should probably be addressed.

In general the cache-service "writing" APIs (.set(), .mset(), .del(), and .flush()) don't define what the caller-provided callback will be passed on success, failure, or partial failure.  (I suspect cache-service will need to define something like an "aggregate error" to encapsulate the "one or more modules had a problem" scenario.)

The .get() API implies (by "response... null on cache miss") that a cache miss should not pass an error value to the callback; this should likely be explicit.  On the other hand, cache-service's implementation handles module .get() errors by simply trying the next module, so perhaps cache-misses should be handled by an error value, allowing any value (including null and undefined) for a cache-hit.

The module API doesn't specify what should be passed to the callback on success or failure.  Is only the err argument used?  Is nothing inspected, and the callback used only to indicate completion?

Full disclosure: I'm writing a cache-service-file-system module to have file-system-backed persistence for superagent, and also to use for a really cheap persistent data store... no dependencies on redis or memcached required, data is easily human readable and easily programmatically consumable by other tools.  Also, my calling code is promise-based, so I expect for my .then() chains after a .set() to only happen after the data has been written to disk.  (If I didn't have that requirement, I wouldn't put the following code in the .then(), I'd just continue immediately after calling .set().)


Add readOnly and routeByLatency options to Redis Cluster Store

I am running SeaweedFS in a multi-zone AWS environment where latency between the Filer and the Redis cluster is very important. However, by default the Go Redis client communicates with only the master node, which may be in a different AWS zone. This change will add configuration options to allow the Filer's Redis client to read from the closest Redis node, while still writing to the master Redis.

add it to scaffold.go also

A side question: why do you prefer SeaweedFS over s3?

In regards to your question about why SeaweedFS over S3:
We needed a shared filesystem with all of these features:

Highly Available
Scalable
High Performance
Mounts to a Linux filesystem
If self-hosted, can run in Kubernetes without being tied to a specific machine
Can efficiently calculate disk usage

We considered pretty much every option out there:

Amazon S3 (doesn't support Unix filesystem properties very well)
Amazon EFS (only easy to calculate usage of total drive, and is limited to 100 drives for a 4-zone VPC, we would have needed >900)
Rook CephFS (tied to specific machines, hard to manage)
Rook EdgeFS (couldn't get it working, hard to manage)
GlusterFS (also tied to specific machines)
NFS (could not figure out high availability)
Portworx (also tied to specific machines)

And I think there were a couple others that I can't remember.
We didn't originally consider SeaweedFS even though I had come across it in my searches because there wasn't any Helm charts for it, but in the end it proved to be the best solution to our needs:

Highly Available (using StatefulSets, headless Services, and some Helm templating)
Scalable (^ same things for different reasons)
High Performance (especially after adding AWS zone affinity for both Mounter <-> Filer and Filer <-> Redis)
Mounts to a Linux filesystem (using a DaemonSet to manage privileged containers for mounting)
Is not tied to specific machines (Volume, Master, and Filer servers can run as normal pods backed by EBS volumes, which Kubernetes moves and manages)
Can efficiently calculate disk usage (since we are using Redis for the Filer backend, we can write code to scan through the raw file metadata and quickly tally up usage numbers)

I also have a question about the values in scaffold.go. Do you want these options to be enabled or disabled by default? I committed them as enabled by default since it should only help performance, but the Go Redis library has them disabled by default, so I'll leave it up to you.
Also, I don't think I explained this very well, but by default the Redis client will only read and write to the master server for a given shard. The readOnly option allows the Redis client to read from a shard's slave servers as well as the master, but all writes will still go to the master. routeByLatency enables readOnly when true, and allows the Redis client to query and automatically use the closest Redis server for reads instead of picking a random one.
In our case, one of our processes needs to get file information as fast as possible in a synchronous manner, so even sub-millisecond latencies add up. Enabling routeByLatency decreased our overall process times by at least 10% in zones that didn't have the Redis master, and probably decreased our time interacting with SeaweedFS by 30% or more.

Thanks for the detailed answer! It is eye-opening to get this detailed feedback! Thanks!
I address the default value concern with 62b1a346ef33e0d4aa84a568e32a53550b75b590

I don't think that commit is quite what I meant. The Go Redis client already has readOnly and routeByLatency set to false by default. My question was if you thought the scaffold code I committed should show them set to true or not.

How about fcbd04c4253927da2c16821ec1a6565b29de6a6f ?

Yeah, that is the code I was talking about. I'm not sure if you want those set to true or false by default. The author of the Go Redis client has them false by default within his library, but I think setting them to true should only increase performance.

Right. The default values should be true without any downside. Adjusted them in a9b1ee18afdaee0806d91f253fbb35e5ffd49c76

Cool, looks good! :+1:


Do not fail on missing JSON Path (fixes #1049, fixes #1056)

:+1:

I solved this by catching the com.jayway.jsonpath.PathNotFoundException directly where it was needed.

Sounds like the better way.

@SpiReCZ O.k thanks, feel free to submit a pull request with a better fix, then we can just close this one. :)

@SpiReCZ O.k thanks, feel free to submit a pull request with a better fix, then we can just close this one. :)

I mean, from a framework that should do a side job apart from the primary business logic. I guess we do not want the logbook to throw any unneeded exceptions and fail without compromising the request processing.
By that logic, your solution is the best there could be. I was just not sure if that was wanted or by-product of the Option.SUPPRESS_EXCEPTIONS.
I will surely try to create a pull request for my solution if it is any better...

I guess we do not want the logbook to throw any unneeded exceptions and fail without compromising the request processing.
By that logic, your solution is the best there could be.

Technically correct. But... especially JSON path filtering is primarily intended to prevent sensitive data from ending up in logs. It could very well be a trade-off that users would make differently. Essentially it boils down to:

Never fail request processing, even if it means sensitive data might end up in logs
Never log sensitive data, even if it means requests might be rejected

@PascalSchumacher Can you resolve the conflict? I believe your version is a good first fix. We can always make it better later.

I have resolved the merge conflict.

👍


Automatically pull an image if we don't already have it before creating the container

This is done via Docker::Image.create. If it's already there, the command runs almost instantly so no overhead (and only gets called when new service is created anyway)


PMID:12664134

abolished transcription during nitrogen starvation

abolished transcription during nitrogen starvation FYPO:0006148
edit file: 610015d41db8990a2be129a346ab07dd9e1e3079
release: 0711a15632e6bc47878e0403ecc8c0401d4c8bce


MRC-131/ Trim data entry fields

The trim logic is replicated many times. Move the logic to a common class, StringUtils for example.
Also, please updated tests for localDate, int and wholeAmount formatters


Add additional unit tests for repository.ResolvePolicy()

This change is

Needed by https://github.com/cilium/cilium/pull/7108/commits/0ae357de1ce2aa3cc7ce416777e0b99ee74b585b


run ./bin/caffe train through android adb

I compiled caffe-android-lib successfully for armeabi-v7a, and would like to train a model
directly on phone.
Without hassling with UI, I decide to run caffe binary through adb shell. After having the
root permission, I run
./bin/caffe train -solver examples/mnist/lenet_solver.prototxt

However, I got a segmentation fault.
Meanwhile, using libcaffe.so in Android app works perfectly.

I guess that you used some io lib format (say, lmdb in mnist example) as your data input which is not supported yet (please refer to this and this).
BTW, root permission is not required to run executable in adb shell.

I use caffe test in the same way below, got a segmentation fault, too.
./caffe trian --model=lenet_train_test.prototxt  --weights=lenet_iter_10000.caffemodel  --iterations=4

if it is because of the same bug ?

I also got a segmentation fault when I run
./bin/caffe time -model lenet.prototxt
@strin @sh1r0  Have you found the solution?

I also got this problem when I run ./caffe train --solver=lenet_solver.prototxt
And I met some other problem.
Before run this model, I compile caffe-android-lib on ubuntu 14.04 using ndk-r11c as required and compiled successfully with armeabi-v7a. But I try to run binary file, convert_mnist_data, on NanoPC T2, error message “This example requires LevelDB and LMDB; compile with USE_LEVELDB and USE_LMDB.” Thus I go to see conver_mnist_data.cpp, Makefile and Makefile.comfig. When I modified Makefile.config "USE_LEVELDB := 1

USE_LMDB := 1"
to ensure that in convert_mnist_data.cpp we have defined USE_LEVELDB && USE_LMDB, but got the same result.
@sh1r0 could you give me some advice?

@elife33 @DevilGragon
Sorry, it's a known issue and I cannot find the root cause so far.

@DevilGragon
You could do the conversion job on linux. By the way, I'm sure if it's a good idea to train models on Android devices.

actually, it does not compile the src/solvers/*. so I think the train function will not work. While I am looking forward to make it work, for example the mnist train use the sgd_solver.cpp.


email/challenge verification loop

i cant bypass a login challenge, it keeps looping, verifying the account from the same ip btw.
an inbuilt challenge solver should solve this issue, i assume its due to mismatching useragents.

Thanks for raising the issue. I'll keep you updated on this.


Downgrade Flutter to 3.22.3

Flutter version is pinned to 3.22.3 until resource linking issue is resolved on Android release builds with version 3.24.0.

Think the dependencies need downgrading also

Think the dependencies need downgrading also

Addressed with: Update pubspec.lock

cargo clippy issues can be ignored, they got addressed on a separate PR.


Set auto_updates

If there’s a checkbox you can’t complete for any reason, that's okay, just explain in detail why you weren’t able to do so.
After making all changes to the cask:

[x] brew cask audit --download {{cask_file}} is error-free.
[x] brew cask style --fix {{cask_file}} reports no offenses.
[ ] The commit message includes the cask’s name and version.

Additionally, if adding a new cask:

[x] Named the cask according to the token reference.
[x] brew cask install {{cask_file}} worked successfully.
[x] brew cask uninstall {{cask_file}} worked successfully.
[x] Checked there are no open pull requests for the same cask.
[x] Checked that the cask was not already refused in closed issues.

Didn't include cask name and version as this PR modifies multiple casks. I have verified that all of these casks can update themselves.

In the future, please submit separate pull requests for each cask, as more often than not this type of pull request brings problems with one or more of them, and it halts the inclusion of the other ones.
At the very least, these should be distinct commits.
You’re also not adding new casks, so it makes no sense to fill the bottom of the template.

These look OK, so merging in this case


Version 5.0 - Beta Upload

Thanks for contributing to the project!
Please help us keep this project in good shape by going through this checklist.
Replace the empty checkboxes [ ] below with checked ones [X] as they are completed
Remember, you can preview this before saving it.
New Contributors Checklist:

[x] I have read the README and Contributor Guidelines
[x] I have signed the CLA (Contributor License Agreement).

[x] My commits have been verified and signed by GitHub.
[x] My commits are not repeated and should be the only one in this repository,
[x] My commits should not in any shape, way or form, breach any Terms of Conditions of GitHub or any rule that has been invoked in the repository.
[x] All committers have signed the CLA.
[x] All commits must pass the CLA check and other checks neccessary.

Description
Describe briefly what your pull request changes. Focus on the value provided to users.
Does it address any outstanding issues in this project?
Adds #53 into folder.
Tests Necessary to Pass:

[x] CodeFactor

[x] CLA Test

@rutvikpadhiyar000 @AdithyaR07 I have a new account I am using for school now. I will be closing this repo soon and that ryantwt07/python-calculator will be the new repo. Sorry for the inconvenience.


read: add support for custom address types

Add the Reader::Address associated type, which implements the ReaderAddress trait. This trait is implemented for u64 to provide the existing behaviour of supporting multiple address sizes, as well as for Address32 and Address64 which support a single address size.
The dwarfdump example now provides its own address type, which allows it to show symbols associated with relocated addresses in relocatable object files. For example:
    DW_AT_low_pc                main+0x0
    DW_AT_ranges                <rnglist at .debug_rnglists+0x0000000c>
        [ 0] <start-length main+0x0, 0x17> [main+0x0, main+0x17]

    DW_LNE_set_address to main+0x0

Closes #409

This is a breaking change, and adds significant complexity. While I think the dwarfdump support is neat, I'm not completely convinced it is worth it, so I'm going to leave this as a draft for while.
To do:

investigate how much this affects downstream crates
investigate how this integrates with the write support (are the convert_address callbacks still needed?)


Video Player Networking Caching Update

Replace this paragraph with a description of what this PR is changing or adding, and why. Consider including before/after screenshots.
List which issues are fixed by this PR. You must list at least one issue.
If you had to change anything in the flutter/tests repo, include a link to the migration guide as per the breaking change policy.
Pre-launch Checklist

[ ] The title of the PR starts with the name of the plugin surrounded by square brackets, e.g. [shared_preferences]
[ ] I read the Contributor Guide and followed the process outlined there for submitting PRs.
[ ] I read the Tree Hygiene wiki page, which explains my responsibilities.
[ ] I read and followed the Flutter Style Guide and the C++, Objective-C, Java style guides.
[ ] I listed at least one issue that this PR fixes in the description above.
[ ] I added new tests to check the change I am making or feature I am adding, or Hixie said the PR is test exempt.
[ ] I updated pubspec.yaml with an appropriate new version according to the pub versioning philosophy.
[ ] I updated CHANGELOG.md to add a description of the change.
[ ] I updated/added relevant documentation (doc comments with ///).
[ ] I signed the CLA.
[ ] All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

flutter doctor
Doctor summary (to see all details, run flutter doctor -v):
[✓] Flutter (Channel stable, 3.0.5, on macOS 12.4 21F79 darwin-arm, locale zh-Hans-CN)
[!] Android toolchain - develop for Android devices (Android SDK version 32.1.0-rc1)
✗ cmdline-tools component is missing
Run path/to/sdkmanager --install "cmdline-tools;latest"
See https://developer.android.com/studio/command-line for more details.
✗ Android license status unknown.
Run flutter doctor --android-licenses to accept the SDK licenses.
See https://flutter.dev/docs/get-started/install/macos#android-setup for more details.
[✓] Xcode - develop for iOS and macOS (Xcode 13.4)
[✓] Chrome - develop for the web
[✓] Android Studio (version 2021.2)
[✓] VS Code (version 1.69.1)
[✓] Connected device (3 available)
[✓] HTTP Host Availability
! Doctor found issues in 1 category.

Error: The method 'setMockMessageHandler'
isn't defined for the class 'BasicMessageChannel'.
FAILURE: Build failed with an exception.

Is there any hope this pr will land in next 12 months? :)


add stream queryz unit test

Refactor stream_queryz.go, move registerStreamQueryzHandlers to queryctl.go.
Add two funcs: streamQueryzHandler and streamQueryzTerminateHandler.

LGTM


Drop support for PhantomJS

This fixes #33 (working towards #43).
I've removed every phantom reference, and any unused code that that left. It's hard to tell if there are any special cases or logic elsewhere that are now irrelevant, but I can't see anything obvious.

It's hard to tell if there are any special cases or logic elsewhere that are now irrelevant, but I can't see anything obvious.

There's some "pre-hook" logic that can probably be removed, but that's only internals, so I'll open an new issue to clean that up later.


distinctUntilChanged seems to be comparing same value when used with combineLatest

RxJS version:5.0.0-beta.7
Code to reproduce:
const test$ = Rx.Observable.from([1,2,3]);

Rx.Observable.combineLatest(test$)
    .do(x=>console.log('combineLatest:', x))
    .distinctUntilChanged((x,y)=>{console.log('Compare: ', x, y, x === y); return x === y})
    .subscribe(x=>console.log('Output: ', x));

Expected behavior:
combineLatest: [1]
Output:  [1]
combineLatest: [2]
Compare:  [1] [2] false
Output:  [2]
combineLatest: [3]
Compare:  [2] [3] false
Output:  [3]

Actual behavior:
combineLatest: [1]
Output:  [1]
combineLatest: [2]
Compare:  [2] [2] true
combineLatest: [3]
Compare:  [3] [3] true

I believe this is because combineLatest doesn't copy its values Array when it emits. This can be worked around by providing a selector function:
Observable.combineLatest(...sources, (...values) => values)

I'm also experiencing this behavior when using distinctUntilChanged after debounceTime.

@abijr Did you try @trxcllnt suggested workaround?
It seems that combineLatest reuses the same array reference for produced values. For performance, this is ideal to avoid creating new arrays, but it has the side affect of causing distinctUntilChanged to break since it's held reference will always be the same as the latest.
Perhaps a possible long term fix is to have distinctUntilChanged do a deep copy for its cached object to check against future values.

I'm not using combineLatest, I'm using debounceTime, and it has a different type signature. I can't use @trxcllnt's workaround (well, I'm almost sure I can't). But, using filter instead of distinctUntilChanged solved my problem.

@abijr are you sure you can't use my workaround? another way of coding it (without ES6) is:
sourceA.combineLatest(sourceB, function() {
  return Array.prototype.slice.call(arguments);
})
.distinctUntilChanged(...);

Under the covers I can understand why you would want to avoid allocating a new array each call.
From the view point of a consumer though, it's confusing, because that value in the array could have changed out from under you later on down subscriber chain (and you wouldn't know it!).
It seems like an odd side-effect to have in as aren't most operators supposed to be immutable?
Does anyone know what the price would be to allocate a new array on the way out of the operator? (.concat())

@trxcllnt, here's how I'm currently using (trying to use) distinctUntilChanged. As I've mentioned before, I'm not using combineLatest at all. Here is the code that isn't working for me:
this.changes$
  .debounceTime(SAVE_DELAY)
  .distinctUntilChanged(...) // this doesn't work, I swapped this line with filter
  .subscribe(draft => {
    save(draft)
  })

Here's my workaround:
this.changes$
  .debounceTime(SAVE_DELAY)
  .filter(isDifferent()) // continue only if different to last save
  .subscribe(draft => {
    save(draft)
  })

function isDifferent() {
  let tmp: Draft = {...}; //
  return (draft: Draft) => {/* return true if draft and tmp are different */}
}

I hope this clarifies my view/experience on the original issue.

I believe this is because combineLatest doesn't copy its values Array when it emits.

We should probably be copying that array when it emits. It's a perf hit, but I think it's a bug that it doesn't, because it's a footgun.

We should probably be copying that array when it emits. It's a perf hit, but I think it's a bug that it doesn't, because it's a footgun.

An option flag/argument, or documention about the solution would be okay too IMO.

No additional operators are required to illustrate the incorrect and thus surprising behaviour of combineLatest.
This code:
var as = new Rx.Subject();
var bs = new Rx.Subject();

// Default projection
Rx.Observable.combineLatest(as, bs)
    .observeOn(Rx.Scheduler.asap)
    .subscribe(function(c) { console.log('default projection [' + c[0] + ', ' + c[1] + ']') });

// Custom projection
Rx.Observable.combineLatest(as, bs, function(a, b) { return [a, b] })
    .observeOn(Rx.Scheduler.asap)
    .subscribe(function(c) { console.log(' custom projection [' + c[0] + ', ' + c[1] + ']') });

as.next(0);
bs.next('x');
as.next(1);
bs.next('y');
as.next(2);

Produces the output:
default projection [2, y]
 custom projection [0, x]

default projection [2, y]
 custom projection [1, x]

default projection [2, y]
 custom projection [1, y]

default projection [2, y]
 custom projection [2, y]

The lack of array copy within the operator implementation causes incorrect asynchronous results for the default projection.
To fix this:

for the case where a custom projection function is provided, no array copy is required,
for the case of the default projection function, array copy is required to produce correct results.

Thus, only the default projection code path will be affected.
If one values (GC) performance above and beyond "correct" behaviour, one could supply a suitably broken projection function. i.e. a projection function that returns a cached array/object.


Give beeswarm plots fixed limits given input data

Currently, whenever you call autolimits! on an axis with a beeswarm plot in it, you get a different result, because it takes the limits of the current scatter plot, but the algorithm finds a new result given those new limits.
I think it makes more sense to pick fixed limits and then adjust axis size or marker size if that's not enough space. You don't get "more" space for the beeswarm anyway by expanding limits, as the extent depends only on screen space.
This PR simply uses the heuristic that having the same space available for each swarm looks good, so it sets data limits that way. If swarms extend out of an Axis, that probably means that they also overlap each other in the middle anyway. So you're unlikely to get a better image by deviating from the heuristic.

@asinghvi17 wouldn't it maybe be a bit more intuitive if gutter gave the column width instead of half of it? Because mostly you're going to use this with categories anyway where 1 would mean touching and 0.8 a little gap, etc.

@asinghvi17 wouldn't it maybe be a bit more intuitive if gutter gave the column width instead of half of it? Because mostly you're going to use this with categories anyway where 1 would mean touching and 0.8 a little gap, etc.

Hmm, I see what you mean.  Since beeswarms are symmetric at this point I don't see why not, though that would call for a breaking release IMO.


Not using workspace interpreter as the default interpreter

Open a workspace, set interpreter to X
Open a notebook, and it will use Y (where Y is the global default)
We should be using X
this is a regression (should work similar to interactive window - always use workspace interpreter as the default when creating new notebooks).

In my case its either using the one from the metadata or not selecting anything and I have to select a kernel.
That seems good to me, but IDK if its what we want.

Validated.
debugEnv2 as python interpreter. Create new blank notebook. debugEnv2 is preferred kernel:


0.12.1 Failing to compile when included as dependency

Is there an existing issue for this?

[X] I have searched the existing issues.

Is this issue related to iced?

[X] My hardware is compatible and my graphics drivers are up-to-date.

What happened?
Compiling a minimal project that includes iced and nothing else
[package]
name = "iced-test"
version = "0.1.0"
edition = "2021"

# See more keys and their definitions at https://doc.rust-lang.org/cargo/reference/manifest.html

[dependencies]
iced = "0.12"

results in
error[E0053]: method `from` has an incompatible type for trait
   --> C:\Users\xxxx\.cargo\registry\src\index.crates.io-6f17d22bba15001f\iced_widget-0.12.3\src\container.rs:315:10
    |
315 |     ) -> Container<'a, Message, Theme, Renderer> {
    |          ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
    |          |
    |          expected `Element<'a, Message, Theme, Renderer>`, found `Container<'a, Message, Theme, Renderer>`
    |          help: change the output type to match the trait: `iced_renderer::iced_core::Element<'a, Message, Theme, Renderer>`
    |
    = note: expected signature `fn(container::Container<'_, _, _, _>) -> iced_renderer::iced_core::Element<'a, Message, Theme, Renderer>`
               found signature `fn(container::Container<'_, _, _, _>) -> container::Container<'a, Message, Theme, Renderer>`

error[E0308]: mismatched types
   --> C:\Users\xxxx\.cargo\registry\src\index.crates.io-6f17d22bba15001f\iced_widget-0.12.3\src\container.rs:316:9
    |
315 |     ) -> Container<'a, Message, Theme, Renderer> {
    |          --------------------------------------- expected `container::Container<'a, Message, Theme, Renderer>` because of return type
316 |         Element::new(column)
    |         ^^^^^^^^^^^^^^^^^^^^ expected `Container<'_, Message, Theme, Renderer>`, found `Element<'_, Message, Theme, Renderer>`
    |
    = note: expected struct `container::Container<'a, Message, Theme, Renderer>`
               found struct `iced_renderer::iced_core::Element<'_, Message, Theme, Renderer>`

Some errors have detailed explanations: E0053, E0308.
For more information about an error, try `rustc --explain E0053`.
error: could not compile `iced_widget` (lib) due to 2 previous errors
warning: build failed, waiting for other jobs to finish...

It looks like 0.12.1 is resolving iced-widget to a later 0.12.3:
PS D:\xxx\iced-test> cargo tree -i iced_widget
iced_widget v0.12.3
└── iced v0.12.1
    └── iced-test v0.1.0 (D:\Projects\grin-projects\iced-test)
PS D:\xxx\iced-test>

What is the expected behavior?
Compilation
Version
crates.io release
Operating System
Windows
Do you have any log output?
No response

Can't reproduce. Those versions should be compatible, since they are just patches.
Try cargo update.


Support "extended" x registers (16-1023)

This PR is focused into removing 2 main limitations:

Functions can have any number of parameters
Up to 1023 live x registers are supported

This restriction has been easily workarounded so far, but removing this limitation closes a gap that makes development smoother.
Since so far everything worked nicely with just 16 registers, this implementation threats "extended x registers" as an uncommon case, so using them is way slower, but still possible, while reducing memory footprint to bare minimum.
There is still a limitation: NIFs with more than 16 parameters are still not allowed, but this limitation will be likely stay unnoticed.
This PR also fixes an unlikely corruption when having exactly 16 live registers, and enables support of more than > 16 typed y registers (I never observed any crash due to this limitation).
See also for #943 for an alternative approach, decoding is based on Paul's work from that PR.
These changes are made under both the "Apache 2.0" and the "GNU Lesser General
Public License 2.1 or later" license terms (dual license).
SPDX-License-Identifier: Apache-2.0 OR LGPL-2.1-or-later

Should this really be over release-0.6?  I thought this was basically a feature-freeze branch, and that any new features should go in main

Should this really be over release-0.6? I thought this was basically a feature-freeze branch, and that any new features should go in main

In case during our review we find any significant risk about merging it, we can change this PR to main branch anytime, but here some points (I think they are coherent with what we said):

most important: this PR is designed to be an addition that doesn't change any visible API (no need to change existing NIFs, BIFs or any port driver) and no need to reflash boot/lib partition (after a partial flash everything will work as usual). So I would call this a drop-in improvement
on the memory footprint side, we are adding just 12 bytes per context on 32bit archs (when no x_reg > 16 are used) that is negligible
most changes are located in opcodesswitch.h (few hundred lines in total), plus few more in context.h/context.c, so hence again a small portion of code-base is changed. Worst case scenario: if any regression is found we can just revert a couple of commits.

This PR also fixes a bug I found that was leading to a silent corruption when some operations on a map are done when exactly 16 registers are used.
To be fair, we must recognize that functions with a large number of parameters are an anti-pattern, so not really a high priority.
Registers above 16 are more likely used when doing pattern matching on several items on a list, this can be avoided, so again it is not a blocking issue most of the times, but some refactoring might be needed so user experience might be degraded due this kind of issues (you need to iterate over the code to make it acceptable).
Still speaking about user experience I don't think our tooling is helping users detecting this issue during build time, so there is some annoyance in discovering this during runtime.
There is also a competing PR from Paul that solves the same issue but uses 4KiB of memory on 32bit architectures per scheduler, so it has a bigger memory footprint, and requires a number of changes to nifs.c and in other places. So I think that this PR is more suitable for v0.6.x release cycle.
So in short I think this solution can fix some relevant annoyances with little changes, the other way requires improving our tooling to detect problematic code and provide guidance, but I think this approach takes more time. IMHO in any case we need to deal with this before v0.6.
My proposal is merging this PR before beta.1 so we can have time for testing, maybe a beta.2 and a rc.0 release.

In addition to handling more registers for functions, it should be noted that this PR obsoletes PRs #943 and #954 which should be closed shall it be merged.
Yet I do believe registers should be moved to schedulers (#943), as they are with OTP Beam emulator.
Besides, this change has a significant performance impact, as expected by altering the decoding and handling of x registers. When compared to de832ecd744d0189ec689503e274311e7bb26f00 (release-0.6 in the table below), depending on the test, the penalty can be up to +11% on ESP32 while the penalty with #954 is up to +6%.
| pingpong | prime | prng | pi | sudoku solution | sudoku puzzle | pingpong one sched. | prime one sched.
-- | -- | -- | -- | -- | -- | -- | -- | --
esp32 |   |   |   |   |   |   |   |
release-0.6 | 69552709 | 18602285 | 3896894 | 160953587 | 11045278 | 548167669 | 76869418 | 36057216
#1056 | 75406913 | 20158330 | 3154241 | 145239244 | 11290871 | 568947860 | 85814790 | 39912347
esp32 #1056 | 108,4 % | 108,4 % | 80,9 % | 90,2 % | 102,2 % | 103,8 % | 111,6 % | 110,7 %
#954 | 68081162 | 16963051 | 1585761 | 148175726 | 11390868 | 580960664 | 81546236 | 33520870
esp32 #954 | 97,9 % | 91,2 % | 40,7 % | 92,1 % | 103,1 % | 106,0 % | 106,1 % | 93,0 %
  |   |   |   |   |   |   |   |
mac |   |   |   |   |   |   |   |
release-0.6 | 2374779 | 232579 | 12787 | 999045 | 462041 | 17640364 | 337056 | 899591
#1056 | 2407961 | 243902 | 12890 | 1030678 | 463613 | 17936806 | 342999 | 937029
mac #1056 | 101,4 % | 104,9 % | 100,8 % | 103,2 % | 100,3 % | 101,7 % | 101,8 % | 104,2 %
#954 | 2446462 | 237944 | 13430 | 1028761 | 477137 | 17904466 | 341032 | 904125
mac #954 | 103,0 % | 102,3 % | 105,0 % | 103,0 % | 103,3 % | 101,5 % | 101,2 % | 100,5 %
The percentages are represented in the graph below (less than 100% means faster than de832ecd744d0189ec689503e274311e7bb26f00).

The performance argument is an argument indeed, however I don't think that #943 and #954 are suitable for v0.6 releases.
So my plan:

Merging this into release-0.6 branch (while keeping open and umerged #943 and #954) and releasing v0.6.0 with this approach to x registers
Discussing #943 and #945, eventually merge them to main and revert Support more than 16 live x registers  as soon as they are merged

Updated with fee0757
| pingpong | prime | prng | pi | sudoku solution | sudoku puzzle | pingpongone sched. | primeone sched.
-- | -- | -- | -- | -- | -- | -- | -- | --
release-0.6 | 69552709 | 18602285 | 3896894 | 160953587 | 11045278 | 548167669 | 76869418 | 36057216
5e186cf6 | 75406913 | 20158330 | 3154241 | 145239244 | 11290871 | 568947860 | 85814790 | 39912347
esp32 #1056 (5e186cf6) | 108,4 % | 108,4 % | 80,9 % | 90,2 % | 102,2 % | 103,8 % | 111,6 % | 110,7 %
fee07573 | 74839692 | 20616761 | 2906844 | 179870742 | 11272682 | 578148078 | 82313254 | 39281166
esp32 #1056 (fee07573) | 107,6 % | 110,8 % | 74,6 % | 111,8 % | 102,1 % | 105,5 % | 107,1 % | 108,9 %
#954 | 68081162 | 16963051 | 1585761 | 148175726 | 11390868 | 580960664 | 81546236 | 33520870
esp32 #954 | 97,9 % | 91,2 % | 40,7 % | 92,1 % | 103,1 % | 106,0 % | 106,1 % | 93,0 %

As an update, I executed a 21 benchmark suite, after building a release version (compiled with -O2) with esp-idf v4.4.6 and I found in total an average ~104% of the original time, this sounds like an acceptable starting point, but a final approach should be investigated.


bounding box not always working on first try

I open the picture in a new tab (I always do), I click 'edit observations'-->'add observation'-->'add observation'--> I fill in 'Person' in both--> I make one bounding box--> I click to make a second, and the moment I scroll up to the image to make it, it makes the mouse a hand, and says 'Not Found
The requested resource was not found on this server.' when i try to make a bounding box or to save'
Sometimes it works if I refresh and try again, but sometimes I have to try multiple times.

Wrong repository


Migrate to google v6 terraform provider

Benefit
We use terraform to create all of our cloud infrastructure. We need to stay current with the provider to have access to all of the settings and configuration available in GCP
Acceptance Criteria

[ ] Modules use version 6

Notes

https://github.com/hashicorp/terraform-provider-google/releases/tag/v6.0.0
https://registry.terraform.io/providers/hashicorp/google/latest/docs/guides/version_6_upgrade

Risks
Cloud projects can break
Issue Reference
refs #

tfi -upgrade will update your google and google-beta modules to v6. If you can apply without change then you should be good to go.


feature request: support for redis sentinel

Thank you for providing this docker image. We like bull-board and the docker image is very convenient for us.
We run redis with sentinel. Currently we get away with pointing bull board to connect to one of the redis instances but this is brittle and unintuitive.
As bull-board uses ioredis under the hood, which supports sentinel, is it at all thinkable to extend the config of bull-board-docker to also support configuring sentinel instead of a single host?
What are your thoughts? Would you be open for a pull request?

Also posted as https://github.com/Deadly0/bull-board-docker/issues/27.

It's now available :tada:
v1.5.0


@import raleway

adding @import url('https://fonts.googleapis.com/css?family=Raleway:400,300,600'); to the first line of the css would import the raleway font automatically.

Adding @import would block parallel downloading, right?

This is taken from the top answer of a SO question here, which might provide a little more context.
From a page speed standpoint, @import from a CSS file should almost never be used, as it can prevent stylesheets from being downloaded concurrently. For instance, if stylesheet A contains the text:
@import url("stylesheetB.css");

then the download of the second stylesheet may not start until the first stylesheet has been downloaded. If, on the other hand, both stylesheets are referenced in <link> elements in the main HTML page, both can be downloaded at the same time. If both stylesheets are always loaded together, it can also be helpful to simply combine them into a single file.
There are occasionally situations where @import is appropriate, but they are generally the exception, not the rule.

Good post/find @Edward-Lombe thanks for sharing


Getting errors while navigating UI

Skooner version: stable
Metrics server version: 4.2
Getting error at cluster overview tab:

Error:
react-dom.production.min.js:209 TypeError: Cannot read properties of undefined (reading 'usage')
    at podRamChart.tsx:39
    at Ot (lodash.js:954)
    at Function.kn.sumBy (lodash.js:16567)
    at podRamChart.tsx:39
    at Gr (podRamChart.tsx:9)
    at Yo (react-dom.production.min.js:153)
    at Fs (react-dom.production.min.js:175)
    at ya (react-dom.production.min.js:263)
    at lu (react-dom.production.min.js:246)
    at au (react-dom.production.min.js:246)

Getting error at node details tab:

Error:
react-dom.production.min.js:209 TypeError: Cannot read properties of undefined (reading 'conditions')
        at node.tsx:149
        at Sn.render (node.tsx:64)
        at Ns (react-dom.production.min.js:182)
        at js (react-dom.production.min.js:181)
        at ya (react-dom.production.min.js:263)
        at lu (react-dom.production.min.js:246)
        at au (react-dom.production.min.js:246)
        at Qa (react-dom.production.min.js:239)
        at react-dom.production.min.js:123
        at t.unstable_runWithPriority (scheduler.production.min.js:19)

How to solve?

Looks like something isn't correctly testing for undefined. We'll take a look. thx!

That seems like it could be partially related to permissions to view those resources.  However the code does fail to check for this condition and assumes if it received a response, that it should proceed it looks like.  I just started using Skooner yesterday for a project, but will submit a PR this since I'm running into it too.

Also seeing these errors consistent under the same situations as @akelge - while viewing pods in the kube-system namespace or viewing nodes. Started happening when I upgraded to the latest version of skooner.


WIP: Add machineconfiguration API

Generating the docs is failing with:
Generating swagger type docs for machineconfiguration/v1 at machineconfiguration/v1
panic: interface conversion: ast.Expr is *ast.SelectorExpr, not *ast.Ident

goroutine 1 [running]:
github.com/openshift/api/vendor/k8s.io/apimachinery/pkg/runtime.fieldName(0xc00002db00, 0x0, 0x0)
    /home/chris/Code/go/src/github.com/openshift/api/vendor/k8s.io/apimachinery/pkg/runtime/swagger_doc_generator.go:111 +0x1e5
github.com/openshift/api/vendor/k8s.io/apimachinery/pkg/runtime.ParseDocumentationFrom(0xc000018660, 0x20, 0xc000064930, 0x1, 0x1)
    /home/chris/Code/go/src/github.com/openshift/api/vendor/k8s.io/apimachinery/pkg/runtime/swagger_doc_generator.go:185 +0x22f
main.main()
    /home/chris/Code/go/src/github.com/openshift/api/tools/genswaggertypedocs/swagger_type_docs.go:71 +0x1d3
exit status 2
make: *** [Makefile:25: generate] Error 1

Could be some explicit conversion is missing, similar to:
https://github.com/runcom/api/blob/296f4c423703bb8b5b7e122cd4b3fc4153ef1130/build/v1/doc.go#L2

next issue:
[chris@localhost api]$ make build
go build github.com/openshift/api/...
# github.com/openshift/api/vendor/k8s.io/kubelet/config/v1beta1
vendor/k8s.io/kubelet/config/v1beta1/generated.pb.go:264:13: arguments to copy have different element types: []byte and []string
vendor/k8s.io/kubelet/config/v1beta1/generated.pb.go:2205:26: cannot use make(map[string]string) (type map[string]string) as type map[string][]string in assignment
vendor/k8s.io/kubelet/config/v1beta1/generated.pb.go:2294:33: cannot use mapvalue (type string) as type []string in assignment
make: *** [Makefile:8: build] Error 2

Maybe it's this issue: https://github.com/golang/go/issues/23536 ?

the first line 264 error makes sense bc the dAtA is a []byte and v is []string. v is an element of StaticPodURLHeader which is a map[string][]string (see  vendor/k8s.io/kubelet/config/v1beta1/types.go)

for the second error it's hitting:
m.StaticPodURLHeader = make(map[string]string) which goes against the StaticPodURLHeader type which is a map[string][]string] (noted above)
for 3rd it's hitting:
m.StaticPodURLHeader[mapkey] = mapvalue where mapvalue is a string.
Not sure why StaticPodURLHeader is doing this in generated files, but the errors just from poking around seem correct given the def in types.go
Not so familar with the API generation etc tho, but @runcom any idea why this is happening?

moving this over to: https://github.com/openshift/api/pull/301


Angular Module Import

Please update angular-linq.js :
from : .module('angular-linq')
to : .module('angular-linq', [])
Please update readme , to import module : 'angular-linq'

Done. thanks for your feedback. This is starlight forward to understand.
Actually the previous one was assumed the controller was lazy loaded on the config.


setup feedback table

Issue #:
https://github.com/bcgov/met-public/issues/
Description of changes:
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of the met-public license (Apache 2.0).

Codecov Report

Merging #659 (541e0e3) into main (269a44f) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #659   +/-   ##
=======================================
  Coverage   69.04%   69.04%
=======================================
  Files         117      117
  Lines        3114     3114
  Branches      219      219
=======================================
  Hits         2150     2150
  Misses        939      939
  Partials       25       25

Flag
Coverage Δ

metweb
64.03% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files
Coverage Δ

.../src/components/layout/SideNav/SideNavElements.tsx
100.00% <ø> (ø)

Also notice we don't have unit tests for this, we can have that done in a separated PR too


Risk cyclone improvements

Addresses:

#1265
#1295
#1296

Changes

Add layer legend and interaction.
Add different layer data visualization for cyclone on PDC, WFP ADAM and GDACS Risk map.
Add logic for layer visibility from exposure data.
Transform all source data to a similar structure for common visualization.

This PR doesn't introduce:

[ ] typos
[x] conflict markers
[x] unwanted comments
[x] temporary files, auto-generated files or secret keys
[x] console.log meant for debugging
[x] codegen errors

Superseded by https://github.com/IFRCGo/go-web-app/pull/1388


🐞 - CardLarge mobile paddings are not applied

Playground Link
No response
Description
Mobile card paddings are not applied because of CSS specificity:

Angular version
18.2
Taiga UI version
4.5.0
Which browsers have you used?

[X] Chrome
[ ] Firefox
[ ] Safari
[ ] Edge

Which operating systems have you used?

[ ] macOS
[ ] Windows
[ ] Linux
[X] iOS
[ ] Android

Specificity of this file need to be bumped:
https://github.com/taiga-family/taiga-ui/blob/main/projects/addon-mobile/styles/common/card-large.less


Add support for editTimeDisplayType

Overview
This is something I've had rattling in my head for a bit. Allows for a dev to specify which display type they want the editor to show for edit-time design.
Changes

Fixes: https://github.com/microsoft/MixedRealityToolkit-Unity/issues/9991

We appreciate your contribution and thank you for the pull request.
Microsoft Mixed Reality Toolkit version 2 (MRTK2) is currently in limited support. This means that Microsoft is only fixing high priority issues. Unfortunately, this pull request does not meet the necessary priority and will be closed. If you strongly feel that this change deserves more attention, please open a new pull request and explain why it is important.
Microsoft recommends that all new HoloLens 2 Unity applications use MRTK3 instead of MRTK2.
Please note that MRTK3 was released in August 2023. It features an all-new architecture for developing rich mixed reality experiences and has a minimum requirement of Unity 2021.3 LTS. For more information about MRTK3, please visit https://www.mixedrealitytoolkit.org.
Thank you for your continued support of the Mixed Reality Toolkit!


[Not for review] Check the timestamp of iperf3 traffic on Pod

Debugging for ipam test failure issue, check the timestamp of iperf3 traffic on Pod.

/test-e2e
/test-flexible-ipam-e2e

Codecov Report

Merging #3019 (c868674) into main (0feed23) will decrease coverage by 0.09%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main    #3019      +/-   ##
==========================================
- Coverage   40.23%   40.14%   -0.10%
==========================================
  Files         166      166
  Lines       20693    20750      +57
==========================================
+ Hits         8326     8330       +4
- Misses      11558    11602      +44
- Partials      809      818       +9

Flag
Coverage Δ

unit-tests
40.14% <ø> (-0.10%)
:arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files
Coverage Δ

pkg/apiserver/certificate/certificate.go
69.86% <0.00%> (-6.85%)
:arrow_down:

pkg/antctl/command_definition.go
51.97% <0.00%> (-2.01%)
:arrow_down:

...agent/flowexporter/connections/deny_connections.go
49.23% <0.00%> (-1.54%)
:arrow_down:

pkg/apiserver/storage/ram/store.go
76.86% <0.00%> (-1.50%)
:arrow_down:

pkg/agent/flowexporter/exporter/exporter.go
51.60% <0.00%> (-1.19%)
:arrow_down:

.../flowexporter/connections/conntrack_connections.go
52.55% <0.00%> (-0.39%)
:arrow_down:

...ntroller/networkpolicy/networkpolicy_controller.go
54.26% <0.00%> (-0.31%)
:arrow_down:

pkg/flowaggregator/flowaggregator.go
21.63% <0.00%> (-0.29%)
:arrow_down:

pkg/agent/openflow/pipeline.go
21.53% <0.00%> (-0.10%)
:arrow_down:

pkg/antctl/client.go
1.29% <0.00%> (-0.10%)
:arrow_down:

... and 5 more


Key/Value backend not usable with Vault 0.10.0 (versioning enabled) and @VaultPropertySource

Spring Vault is not usable with Vault's versioned Key/Value backend introduced with 0.10.0. The versioned backend is enabled by default which adds another level of severity.
The versioned Key/Value backend entirely changed its API (nested responses, e.g. {data: { data: { here comes the actual payload }}, changed API paths e.g. secret/data/secret-name instead of secret/secret-name). It is possible to read from …/data/… paths but referencing secrets requires a ${data.…} prefix to unwrap nesting.
Using the Key/Value backend allows a uniform API even if versioning is disabled by setting an HTTP header (X-Vault-Kv-Client: v2) but the client has to be aware it's reading from a key-value backend.
Using a newer format (paths, unwrapping) breaks compatibility with older Vault versions and isn't really a good option for @VaultPropertySource(…).

A possible approach could be introducing @VersionedVaultPropertySource to indicate the versioned nature of the underlying backend. A new annotation would give us the possibility to express version-specific attributes and drop renewal. The versioned backend does not support cache timeouts through the TTL property.

Versioned key-value secret backend usage comes with a multitude of usage strategies (here's a list to name some):

Pin to a specific version
Select a specific version during runtime
Use time-based caching and pick a version of a secret
Apply caching based on a user-defined TTL

Expressing just some of the options would require a very broad annotation with possibly mutually exclusive configuration options. Therefore, we should not introduce such a possibility now.
We could introduce path and mount inspection, similar to how vault-cli behaves. We can ask an internal API (sys/internal/ui/mounts) to obtain the mount path and mount options.
The mount info gives insight whether the path belongs to a versioned key-value backend. Based on this information, we can rewrite the request path and unwrap the payload.
It would work with today's @VaultProperties annotation. The change would not require adding the data/ path segment in the annotation declaration and so path declarations can be retained.
A side effect is that an application can declare the path independently from the mount that is available on the server (e.g., use non-versioned in one environment and a versioned backend in another one without the need to change the code).

@mp911de  I did find VaultVersionedKeyValueTemplate.java in 2.1.2.RELEASE. However, it does not seem to be working with @Import(EnvironmentVaultConfiguration.class). Do we have any example on how to use versioned KV store with  EnvironmentVaultConfiguration?
My apologies for comment on a closed thread. However, this appeared to be the right thread to ask this question.

Via VaultTemplate. You cannot inject VaultVersionedKeyValueTemplate as it requires a Vault path to operate on.

@mp911de  Thanks for the quick reply Mark. Here is the problem I am facing.
My kv store is of version2 type.
My code to read properties is as under.  It is reading data correctly but in version 1 format.
vault.sources=secret/data/abcd,secret/data/pqrs is the config provided for reading secrets.
import org.springframework.beans.factory.annotation.Value;
import org.springframework.context.annotation.Configuration;
import org.springframework.context.annotation.PropertySource;
import org.springframework.core.env.ConfigurableEnvironment;
import org.springframework.core.env.MutablePropertySources;
import org.springframework.vault.authentication.ClientAuthentication;
import org.springframework.vault.authentication.TokenAuthentication;
import org.springframework.vault.client.VaultEndpoint;
import org.springframework.vault.config.AbstractVaultConfiguration;
import org.springframework.vault.core.VaultTemplate;
import org.springframework.vault.core.env.VaultPropertySource;

import javax.annotation.PostConstruct;
import java.net.URI;
import java.util.List;

@Configuration
@PropertySource("vault.properties")
public class AppConfig extends AbstractVaultConfiguration {

    @Value("${vault.uri}")
    private URI vaultUri;

    @Value("${vault.token}")
    private String token;

    @Value("#{'${vault.sources:}'.split(',')}")
    private List<String> vaultSources;

    @Autowired
    private ConfigurableEnvironment environment;

    @Autowired
    private VaultTemplate vaultTemplate;

    /**
     * Specify an endpoint for connecting to Vault.
     */
    @Override
    public VaultEndpoint vaultEndpoint() {
        return VaultEndpoint.from(vaultUri);
    }

    /**
     * Configure a client authentication.
     * Please consider a more secure authentication method
     * for production use.
     */
    @Override
    public ClientAuthentication clientAuthentication() {
        return new TokenAuthentication(token);
    }

    @PostConstruct
    public void setPropertySource() {
        MutablePropertySources sources = environment.getPropertySources();
        vaultSources.stream().forEach(vs -> {
            sources.addFirst(new VaultPropertySource(vaultTemplate, vs));
        });
    }
}```

If I remove data from path i.e. `vault.sources=secret/abcd,secret/pqrs`, it simply does not connect and throws exception with 403. This means that it must not be using kv v2.

Can you please help with the change I need to make here to get the properties correctly?

We prefer using GitHub issues for bug reports and feature requests. Please post your question to StackOverflow.

Thanks. I have posted my question here https://stackoverflow.com/questions/56481031/how-to-make-versioned-kv-store-work-with-vaultpropertysource

Is there any planned support for this feature in the 1.1.x releases that are compatible with Spring 4?

@nov1n No. We typically do not backport features.


fix: 修复自定义树取值路径错误问题

👀 PR includes
🐛 Bugfix

[x] Solve the issue and close #0

📝 Description

自定义目录树情况下，默认为 hideMeasure 模式，由于走了统一的补query的逻辑，导致取数异常

:tada: This PR is included in version @antv/s2-v1.5.0-alpha.4 :tada:
The release is available on:

npm package (@alpha dist-tag)
GitHub release

Your semantic-release bot :package::rocket:

:tada: This PR is included in version @antv/s2-v1.6.0-alpha.1 :tada:
The release is available on:

npm package (@alpha dist-tag)
GitHub release

Your semantic-release bot :package::rocket:

:tada: This PR is included in version @antv/s2-v1.7.0-alpha.1 :tada:
The release is available on:

npm package (@alpha dist-tag)
GitHub release

Your semantic-release bot :package::rocket:

:tada: This PR is included in version @antv/s2-v1.8.0-alpha.1 :tada:
The release is available on:

npm package (@alpha dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


Error occurred while using styled-components, typescript, ref, and props together.

Version
styled-components: 2.4.0
Reproduction
https://codesandbox.io/s/vjl61y13m7
Steps to reproduce
Create a file called Foo.tsx, and input the following code:
import * as React from 'react';
import styled from "styled-components";

interface FooProps {
  color: string;
}

export class Foo extends React.Component<FooProps, undefined> {
  private styledButton: any;
  render() {
    return (
      <StyledDiv ref={(ref: any) => this.styledButton = ref}>
        Some contents
      </StyledDiv>
    );
  }
}

const StyledDiv = styled.div`
  color: ${(props: FooProps) => props.color};
`;

Expected Behavior
No Error
Actual Behavior
Got an error:
(12,18): error TS2322: Type '{ ref: (ref: any) => any; children: string; }' is not assignable to type 'IntrinsicAttributes & IntrinsicClassAttributes<Component<ThemedOuterStyledProps<ClassAttributes<H...'.
  Type '{ ref: (ref: any) => any; children: string; }' is not assignable to type 'Readonly<ThemedOuterStyledProps<ClassAttributes<HTMLDivElement> & HTMLAttributes<HTMLDivElement> ...'.
    Property 'color' is missing in type '{ ref: (ref: any) => any; children: string; }'.

Interestingly, if I don't use props in styled-components, no error occurred.
const StyledDiv = styled.div`
  color: black;
`;

cc @styled-components/typers

Sorry, the problem is I didn't pass the color props in StyledDiv, I have focused on ref too much that I forgot about it.
The correct code is:
<StyledDiv
    color="red"
    ref={(ref: StyledDiv) => this.styledButton = ref}>
    Some contents
</StyledDiv>


HydroShare and DataDepot service and publishing plugins.

Creating a service and publishing plugin in for Hydroshare.org and our Data Depot.

I created two separate service plugins for both the main HydroShare and our Data Depot sites. This issue will be closed when the next pr is merged.

Instead of creating more issues, there was three bugs within the HydroShare/Data Depot service and publishing plugin.  They are as follows:

There was no sub service base for both HydroShare/Data Depot for all other types of resources that are being held in the repository.
There were no checks to make sure that you were connected into HydroShare/Data Depot.
There were no checks to see if there were resources that had coverages for geo-discrete resource type.

This issue will be closed when the next pr is merged.


custom padding added to column is incorrectly manipulated by foundation

How can we reproduce this bug?
HTML:

  <row>
    <columns class="card">
      <row>

        <columns class="message-content" style="padding-left: 20px;\">

          <%= "Hi #{@recipient.first_name}," %>

          <%= @body %>

          <button href="<%= @link %>" class="radius">
            <%= @link_text %>
          </button>

        </columns>
      </row>
    </columns>
  </row>

SCSS:
.new-conversation {
  .message-content {
    padding: 1em;
  }
}

What did you expect to happen?
For there to be padding: 1em on th class="message-content"
What happened instead?
    width: 100%;
    color: #0a0a0a;
    font-family: Helvetica, Arial, sans-serif;
    font-weight: normal;
    line-height: 1.3;
    font-size: 16px;
    margin: 0 auto;
    padding: 1em 0;

It adds a 0 after, which is a problem.  I've tried multiple different combinations of padding just for fun, and they are always messed with and never come out as they were written in the scss file.
What email clients does this happen in?
rails 5.1 email preview, chrome browser.

Running into this as well. Any solutions?


Add CiA DS 401 support for object dictionary

ssia.

Instead of using a hard-coded dictionary, this could be part of the EDS parser. See #64


Bug- Dependecy cycles

If create two or more cells then there are dependency cycles created. Can recreate bug using "tests/cell_material.py"
Output in Terminal:
Detected 2 dependency cycles
Dependency cycle detected:
OBCell2_/Geometry Component/GEOMETRY_EVAL() depends on
OBCell1_/Geometry Component/GEOMETRY_EVAL() via 'Cloth Collision'
OBCell2_/Geometry Component/GEOMETRY_EVAL() via 'Cloth Collision'

https://blender.stackexchange.com/questions/177962/understanding-what-dependency-cycle-means-why-it-happens-and-if-it-is-a-caus
Sounds like dependency cycles are unavoidable in physics simulations since both object depend on each other so maybe not a problem


dependency on mixin-deep 1.3.2

Hi folks,
the package has a sub-dependency on mixin-deep 1.3.2, which has a vulnerability (as assessed by github). can you please update your dependencies to resolve this?

According to yarn audit output, the vulnerability is patched within >=1.3.2 <2.0.0 || >=2.0.1, which is in range of our dependencies. Please regenerate Jest in your lock file, so it fetches the 1.3.2 version.


#35: Update lofi girl youtube url

Update the url for Lofi Girl station to point to the new stream url.
#35

@maxence-charriere

I was just about to suggest this MR, that URL points to the correct place for me

@saeedafzal  can you also update the lofi sleepy girl url too, I think it should be https://youtu.be/rUxyKA_-grg

@saeedafzal can you also update the lofi sleepy girl url too, I think it should be https://youtu.be/rUxyKA_-grg

@stuartskelton I've updated the url for the lofi sleepy girl stream

It has been fixed.


Add New Language: PostScript

Description
PostScript is a stack-based programming language, mainly used for vector graphics and printing; however, it is also a general-purpose programming language which can be used for other uses too.

https://github.com/MrKrishnaAgarwal/Awesome-Programming-Languages

I'll take on this issue


Can't tag other users than my followers

Please follow the guide below

Issues submitted without this template format will be ignored.
Please read the questions carefully and answer completely.
Do not post screenshots of error messages or code.
Put an x into all the boxes [ ] relevant to your issue (==> [x] NO spaces).
Use the Preview tab to see how your issue will actually look like.
Issues about reverse engineering is out of scope and will be closed without response.
Any mention of spam-like actions or spam-related tools/libs/etc is strictly not allowed.

Before submitting an issue, make sure you have:

[x] Updated to the lastest version v1.6.0
[x] Read the README and docs
[x] Searched the bugtracker for similar issues including closed ones
[x] Reviewed the sample code in tests and examples

Which client are you using?

[x] app (instagram_private_api/)
[ ] web (instagram_web_api/)

Describe the Bug/Error:
Can't post a comment that tags a person that doesn't follow me.

Paste the output of python -V here: Python 3.8.5
Code:
api.post_comment(media_id, f'@{follower}')
        print(f'Tagged: {follower}')

Error/Debug Log:
Traceback (most recent call last):
  File "/data/data/com.termux/files/usr/lib/python3.8/site-packages/instagram_private_api/client.py", line 523, in _call_api
    response = self.opener.open(req, timeout=self.timeout)                         File "/data/data/com.termux/files/usr/lib/python3.8/urllib/request.py", line 531, in open
    response = meth(req, response)
  File "/data/data/com.termux/files/usr/lib/python3.8/urllib/request.py", line 640, in http_response
    response = self.parent.error(
  File "/data/data/com.termux/files/usr/lib/python3.8/urllib/request.py", line 569, in error
    return self._call_chain(*args)                                                 File "/data/data/com.termux/files/usr/lib/python3.8/urllib/request.py", line 502, in _call_chain
    result = func(*args)
  File "/data/data/com.termux/files/usr/lib/python3.8/urllib/request.py", line 649, in http_error_default
    raise HTTPError(req.full_url, code, msg, hdrs, fp)
urllib.error.HTTPError: HTTP Error 400: Bad Request

During handling of the above exception, another exception occurred:
Traceback (most recent call last):
  File "instaway.py", line 57, in <module>
    main()
  File "instaway.py", line 53, in main
    run(parse_args())
  File "instaway.py", line 45, in run
    api.post_comment(media_id, f'@{follower}')
  File "/data/data/com.termux/files/home/projects/instaway/lib/client.py", line 14, in post_comment
    self.api.post_comment(media_id, comment)
  File "/data/data/com.termux/files/usr/lib/python3.8/site-packages/instagram_private_api/endpoints/media.py", line 266, in post_comment
    res = self._call_api(endpoint, params=params)                                  File "/data/data/com.termux/files/usr/lib/python3.8/site-packages/instagram_private_api/client.py", line 527, in _call_api                                          ErrorHandler.process(e, error_response)
  File "/data/data/com.termux/files/usr/lib/python3.8/site-packages/instagram_private_api/errors.py", line 135, in process
    raise ClientError(error_msg, http_error.code, error_response)                instagram_private_api.errors.ClientError: Bad Request: failed to mention

I found out the issue, some users don't allow tags from users they don't follow. Closing this.


PDF417 South African Driver License reading is not working

Could you have a look at the scanning of South African driver's licenses?
I have tried several ideas (preprocessing, few tweaks in pdf417 detector and decoder), but nothing works so far.
Always I am getting a large number of erasures in the final result. My goal is just to have a valid decoded bytes in the output.
Any advice would be appreciated.

Could you pleas provide a sample image and provide both the expected and the returned/wrong result?

Thanks for quick response.
I can share a publicly available driving licence which also doesn't work when using Xzing pdf417 reader.
The expected output should be a valid ZXing::Result  (DecodeStatus::NoError) that has data in "decodedBytes" ByteArray
The returned result is DecodeStatus::ChecksumError.
I have tried several South African driving licences and didn't get a valid output.

I'm not familiar with the PDF417 code base but have a rough idea how it is supposed to work. I had a look at where the code bails and found that the main issue here seems to be that the decoder seems fundamentally incapable of detecting codes that are upside-down, which seems to be the general case for ZA drivers licenses?
Flipping the image upside down was not sufficient to make it work, though. I also had to rotate it to be perfectly level. See also my remarks in #145.
The straightened and vertically flipped image did give some results then.

If you have a higher resolution scan, you might get away with only flipping it vertically and without perfectly straightening it. Please let me know what you find.

Thanks @axxel
Indeed flipping the detected barcode (detect the barcode then cropping it) and giving attention to its rotation do help in decoding it.
So flipping is a MUST for ZA pdf417 barcodes, rotation is very important but it is not necessarily to be perfectly level ( I mean 0 degree ) especially for good resolution and clean images (images that are not noisy, blurry, or have pixelation)

@axxel The following fix made it work for me without having to flip the image:
+       int increment = 1;
        for (int codewordsRow = firstRow; codewordsRow < lastRow; codewordsRow++) {
                if (codewords[codewordsRow] == nullptr) {
                        continue;
                }
                Codeword codeword = codewords[codewordsRow];
+               if (barcodeRow == -1 && codeword.rowNumber() == barcodeMetadata.rowCount() - 1) {
+                   increment = -1;
+                   barcodeRow = barcodeMetadata.rowCount();
+               }

                //      float expectedRowNumber = (codewordsRow - firstRow) / averageRowHeight;
                //      if (Math.abs(codeword.getRowNumber() - expectedRowNumber) > 2) {
@@ -155,12 +160,10 @@ DetectionResultColumn::adjustCompleteIndicatorColumnRowNumbers(const BarcodeMeta

                int rowDifference = codeword.rowNumber() - barcodeRow;

-               // TODO improve handling with case where first row indicator doesn't start with 0
-
                if (rowDifference == 0) {
                        currentRowHeight++;
                }
-               else if (rowDifference == 1) {
+               else if (rowDifference == increment) {

@tailsu Thanks! Would you care sending a PR (adding a paper trail of your contribution)? :)


Site footer redesign

Mention institute divisions
Introduce a menu which includes links to the terms of use, the privacy policy, and the platform
Define the site-footer height using a Sass variable instead of a fixed value to fix layout breakage in small viewport devices

antleaf/nims-mdr-development#293

There was a conflict with a change in https://github.com/antleaf/nims-hyrax/pull/229 but that has been resolved.


Slow convergence behavior: MACE with qGGMRF prior

When testing MACE with qGGMRF denoiser, we observed that while the converged result seems correct (in the sense that it is close to MBIR recon result), the convergence is slow.
See the slides below for the experiment details (this is included in Lilly weekly update slides on 02/23/2023).
mace_qGGMRF_slow_convergence.pptx
Per Dr. Buzzard's request, I'm recording this issue here, so that we do not lose track of it.

Yes, this qGGMRF prior should be extremely useful for optimization and debugging.


SpiDevice implementations in embedded-hal-bus don't provide a way to use active-high chip select

I am using a SPI display which requires active-high chip select, but all of the SpiDevice implementations don't mention the polarity of their CS pin anywhere. Looking at the implementation, these implementations are all hard-coded to use active-low CS, which won't work for this display. Adding a way of specifying the chip select polarity would make this usable for this case.

pub struct ExclusiveDevice<BUS, CS, D, const CSHIGH = false> {

???

Couldn't you just create an InvertedPin struct that implements the OutputPin trait and does the inversion?
This seems like a non issue to me.

As a matter of fact, I wrote an inverted-pin crate that does exactly that.
In my experience, active-low CS is the overwhelming majority so I think using an inverting wrapper should be enough and there is no pressing need to support this in a dedicated way.
Closing. Feel free to reopen if you think otherwise.


Added FAQ Link

Added FAQ Link

 Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.Dhakne, Pallavi seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.You have signed the CLA already but the status is still pending? Let us recheck it.


Share Open API type across specs

Hi folks,
Forgive me if this is possible and I'm just bad at reading the docs. I currently have a Node.js 'front door' service/public API that calls into a Go core service. The APIs on the Go service are mostly not public, and are defined as OpenAPI v2 specifications (and protos if that in any way makes this easier).
For a limited subset of complex types, I want to 'forward' the types from the Go service's Open API definition into the public API, as a property of another type. Simplified, it would look something like this:
model Service {
  @visibility("read", "update")
  @path
  id: string;
  customerId: string;
  name: string;
  metadata?: TypeFromOtherAPISpec;
}

Ideally, there would be to make an almost 'virtual type' from another open API specification, something like:
model Service {
  @visibility("read", "update")
  @path
  id: string;
  customerId: string;
  name: string;
 @fromOpenApi("/filePathToOtherTypeInOpenApiSchemaFormat")
  metadata?: unknown;
}

Is there a good way to do something like this? Otherwise I can make a build step to do a bunch of string replacement.

Yes you can use useRef from the openapi3 emitter. However seems like we have a bug and it doesn't generate correctly.
https://cadlplayground.z22.web.core.windows.net/?c=aW1wb3J0ICJAdHlwZXNwZWMvb3BlbmFwaTMiOwoKbW9kZWwgRm9vIHsKICBiYXI6IEJhcjsKfQoKQE9wZW5BUEkudXNlUmVmKCIuL2NvbW1vbi%2FFSi5qc29uI2NvbXBvbmVudHMvc2NoZW1hcy9CYXIiKcdZQmFyyllzdHJpbmfEXA%3D%3D&e=%40typespec%2Fopenapi3&options={}
However be careful on the use of it. The value is taken as it is right now so it needs to account where the openapi is going to be emitted.

This should just generate a standard ref with an exact copy of that string right? without the kind and isFinished it is currently generating?
Is there any work around for this? Unfortunately it's a little hard to understand what work-around options are available just from the API ref, so I"m sorta down to using a regex replace on the incorrect outputs or something to get around this.

Indeed, that is the bug right now, we have a release next tuesday, this should be easy enough to fix and make it for that release.
I can't think of any workaround for it unfortunately


Web - Upvote/Downvote Spots Functionality

Create a hook for vote related CRUD endpoints.
Add necessary buttons for upvoting and downvoting a Spot
Make sure to update vote counts as the user changes his/her vote

Details can be seen in #602


[boost-cobalt] Build error on x64-windows

Package<EMAIL_ADDRESS>Host Environment

Host: x64-windows
Compiler: MSVC 19.29.30154.0
vcpkg-tool version: 2024-06-10-02590c430e4ed9215d27870138c2e579cc338772
vcpkg-scripts version: c4467cb68 2024-06-21 (3 days ago)

To Reproduce
vcpkg install boost-cobalt
Failure logs
-- Using cached boostorg-cobalt-boost-1.85.0.tar.gz.
-- Cleaning sources at C:/dev/vcpkg/buildtrees/boost-cobalt/src/ost-1.85.0-74ba267639.clean. Use --editable to skip cleaning for the packages you specify.
-- Extracting source C:/dev/vcpkg/downloads/boostorg-cobalt-boost-1.85.0.tar.gz
-- Using source at C:/dev/vcpkg/buildtrees/boost-cobalt/src/ost-1.85.0-74ba267639.clean
-- Found external ninja('1.10.2').
-- Configuring x64-windows
-- Building x64-windows-dbg
CMake Error at scripts/cmake/vcpkg_execute_build_process.cmake:134 (message):
    Command failed: "C:/Program Files/CMake/bin/cmake.exe" --build . --config Debug --target install -- -v -j21
    Working Directory: C:/dev/vcpkg/buildtrees/boost-cobalt/x64-windows-dbg
    See logs for more information:
      C:\dev\vcpkg\buildtrees\boost-cobalt\install-x64-windows-dbg-out.log
      C:\dev\vcpkg\buildtrees\boost-cobalt\install-x64-windows-dbg-err.log

Call Stack (most recent call first):
  installed/x64-windows/share/vcpkg-cmake/vcpkg_cmake_build.cmake:74 (vcpkg_execute_build_process)
  installed/x64-windows/share/vcpkg-cmake/vcpkg_cmake_install.cmake:16 (vcpkg_cmake_build)
  installed/x64-windows/share/vcpkg-boost/boost-install.cmake:65 (vcpkg_cmake_install)
  ports/boost-cobalt/portfile.cmake:12 (boost_configure_and_install)
  scripts/ports.cmake:191 (include)

C:\dev\vcpkg\buildtrees\boost-cobalt\install-x64-windows-dbg-err.log
ninja: error: unknown target 'install'

C:\dev\vcpkg\buildtrees\boost-cobalt\install-x64-windows-dbg-out.log
Change Dir: 'C:/dev/vcpkg/buildtrees/boost-cobalt/x64-windows-dbg'

Run Build Command(s): "C:/Program Files (x86)/Microsoft Visual Studio/2019/Professional/Common7/IDE/CommonExtensions/Microsoft/CMake/Ninja/ninja.exe" -v -v -j21 install

Your version of VS2019 compiler is too low, upgraded VS2022 to fix the problem.

https://github.com/microsoft/vcpkg/issues/40290#issuecomment-2269639431

Can be closed.


Removing GaussianProcesses

Removing GaussianProcesses as a first step to deal with #127

@ChrisRackauckas I'd merge this and tag a breaking change to deal with the getting stuck on 0.5 problem


~shiftchan Error Code

“A channel name is required after ~shiftchan. This channel will be shifted below that channel.”

(Current error code says
Argument chan_a_name: Union[discord.channel.TextChannel, str] required.
which can be hard to understand. This is suggested style of error code, if it's possible to automate)


1t karambwan cooking on bso

Fishy coded it for osb but it never merged to bso. Cyr said probably a merge error

I don't believe this has been added to BSO. Did magna ever comment on this?


Result Matching

Hi I tried the code but the results that I have got doesnt match with yours
Car<EMAIL_ADDRESS>0.70, 0.70:
bbox AP:31.3119, 29.9161, 11.5392
bev  AP:30.3763, 26.2499, 7.4607
3d   AP:22.4887, 14.2179, 1.6540
aos  AP:31.19, 29.39, 11.02
Car<EMAIL_ADDRESS>0.70, 0.70:
bbox AP:26.7832, 25.6019, 9.3563
bev  AP:25.7784, 22.8520, 5.8164
3d   AP:18.5399, 10.8951, 1.1516
aos  AP:26.67, 25.03, 8.92
Car<EMAIL_ADDRESS>0.50, 0.50:
bbox AP:35.3946, 37.8803, 26.0321
bev  AP:35.5369, 36.4547, 24.9272
3d   AP:34.4769, 33.6819, 18.4919
aos  AP:35.13, 36.91, 24.56
Car<EMAIL_ADDRESS>0.50, 0.50:
bbox AP:31.5161, 35.9322, 23.1850
bev  AP:33.2069, 35.0456, 21.7509
3d   AP:31.0544, 31.3375, 15.9599
aos  AP:31.21, 34.83, 21.76
Pedestrian<EMAIL_ADDRESS>0.50, 0.50:
bbox AP:19.9919, 20.0944, 4.6807
bev  AP:15.2294, 11.7712, 2.1327
3d   AP:13.8624, 8.6885, 1.6790
aos  AP:13.57, 10.21, 2.06
Pedestrian<EMAIL_ADDRESS>0.50, 0.50:
bbox AP:15.1636, 15.2180, 3.5190
bev  AP:10.6819, 9.0586, 1.5779
3d   AP:8.5679, 6.3258, 1.1267
aos  AP:10.29, 8.79, 1.62
Pedestrian<EMAIL_ADDRESS>0.25, 0.25:
bbox AP:19.9919, 20.0944, 4.6807
bev  AP:20.8643, 21.3697, 5.1875
3d   AP:20.7697, 21.2806, 5.0291
aos  AP:13.57, 10.21, 2.06
Pedestrian<EMAIL_ADDRESS>0.25, 0.25:
bbox AP:15.1636, 15.2180, 3.5190
bev  AP:16.3724, 16.4522, 4.0114
3d   AP:16.2533, 16.3138, 3.7973
aos  AP:10.29, 8.79, 1.62
Is there anything I must reconsider in config?
Thanks. I need this to verify if I am running the code correctly

Same as your result, did you do any modification in config?


mDNS refactoring

I'm a bit unsure how we should handle this nicely. Without Trickle we have to wait for all candidates. But mDNS timeouts are between 3-5 seconds. That's a high startup delay. Especially if hosts are not on the same network. Should we migrate baresip ice to trickle and add only mDNS support there?

There are two ICE stacks, "ice" and "trice".
The latter one has multiple interfaces and supports Trickle ICE, it has been in production
for around 8 years. The long term goal is to merge these 2 stacks into one stack.
We could create a new baresip module trice.so and experiment with how it works.
Waiting for all candidates to finish it not so practical, IMHO. You could also add a new flag
to "ice" which says dont wait for all candidates to finish ...

It is also possible to add optional "Trickle Mode" to the current ICE stack, so that we
don't have to wait for all candidate pairs to finish...

There is also another solution, which is to set the mDNS timeout short, e.g. 100ms.

There is also another solution, which is to set the mDNS timeout short, e.g. 100ms.

Since I had already a 100ms default timeout implemented this workaround was easy. Needs some testing...


nvm breaks detox build on MacOS

When using nvm to manage node versions on MacOS(11.1), detox build fails with the following error
nvm is not compatible with the "PREFIX" environment variable: currently set to "/Users/uloco/.nvm/versions/node/v15.6.0"
Run `unset PREFIX` to unset it.
env: node: No such file or directory
Command PhaseScriptExecution failed with a nonzero exit code

Ubuntu works fine with nvm.
Also other builds that need node or npm work fine, it is just happening with detox.
Is detox setting the PREFIX environment variable somewhere? Is there any way of working around this problem?

It is unrealistic to investigate this issue provided the feedback above.

Try wrapping it in a temporary JavaScript file, e.g.:
require('child_process').execSync('my unlucky command', { stdio: 'inherit' })

and run it. Does the result differ?

Detox works fine with a normal nodejs install via .deb from the website.
Since I switched to using nvm I get the error shown above.
I am running a npm script with the just the regular detox build command: detox build -c ios.stage.release

Thanks. Putting it in a separate node script and running it with node <script> solved the issue. Running it in a npm script with npm run <script> does not work though, even if it is a separate script.

But this works in a npm script unset PREFIX && detox build ...

This is not related to Detox at all.

This issue just happens with detox build. I do not have any issues with other npm scripts or libraries. That's why I thought of a detox issue in the first place. I was thinking, that it is quite unlikely that any of you are using nvm and haven't had any issues regarding this. Thanks for clearing things up.

We are actually using NVM in some of our CIs and, as far as I know, that hasn't changed. We also had developers using NVM on their development machines.

Looks like this was still an issue by npm 2 days ago. It used to set the PREFIX env variable for no reason.
Now it is fixed: https://github.com/npm/cli/issues/2398
nvm install-lastest-npm fixes this, whoever lands here. No need to unset prefix anymore.


[Request] Angry IP Scanner

Package Request
Criteria
For a package to be acceptable in the Extras bucket, it should be:

[x] a well-known and widely used tool (e.g. if it's a GitHub project, it should have at least 100 stars and 50 forks)
[x] the latest stable version of the program

Information
Name: Angry IP Scan
Description: IP scanner
Homepage: https://angryip.org/
Download link(s): https://github.com/angryip/ipscan/releases
Some indication of popularity/repute: 2900 stars

Already in extras. ipscan not angryipscan


Add support for initial_values for hardware interfaces when starting simulation.

This PR adds support for initial values to set the hardware's initial states in the simulation.
This functionality is based on the following ros2_control PR:

ros-controls/ros2_control#593

Here is an example of its use in FakeHardware.

ros-controls/ros2_control#598

The ros2_control changes are released but not yet synced.

Hi @destogl, I'm trying to compile this. Is initial_values feature only available in rolling ?

Hi @destogl, I'm trying to compile this. Is initial_values feature only available in rolling ?

Yes, this is rolling-only feature. I am not sure if it is synced already, but it is released.

DCO ?

Sorry about that!

Can you add the same example as you included in this PR here ?

Do you want to have two additional files for it? In this PR I embedded the example of initial_value into the existing one because we actually change only one line compared to the usual examples. TBH I rather prefer approach I done here. Otherwise we just add "file-noise" without much value in them.
If you insist to add an additional example, I'll add it, but as I said, I think it is overkill.

@ahcorde I think we can go on with this in the same way as had to be done for gazebo_ros2_control.

@destogl the PR is ready https://github.com/ignitionrobotics/ign_ros2_control/pull/30


clusters and pools not interchangeable in knife vsphere vm find

What are you trying to do and what's not working?
We don't currently have any resource pools in vcenter, we do have clusters, but knife vsphere vm find demands that a pool be specified and does not take a cluster in place of a pool.
Please paste the command and output (run with -VV). Don't forget to X out any passwords or sensitive information
TX1-GLINN03ML:ma_siteserver garrick.linn$ knife vsphere vm find --pool "Production/Production-DA" --match-name "DA3SHWL021" -VV
INFO: Using configuration from /Users/garrick.linn/Documents/chef/automate-match/.chef/knife.rb
DEBUG: value for config item vsphere_host: da0shas000
DEBUG: value for config item vsphere_path: /sdk
DEBUG: value for config item vsphere_port: 443
DEBUG: value for config item vsphere_nossl:
DEBUG: value for config item vsphere_user: xxxxxx
DEBUG: value for config item vsphere_pass: xxx
DEBUG: value for config item vsphere_pass: xxx
DEBUG: value for config item vsphere_pass: xxx
DEBUG: value for config item vsphere_insecure: true
DEBUG: value for config item proxy_host:
DEBUG: value for config item proxy_port:
DEBUG: value for config item vsphere_dc: Clearview
Pool Production/Production-DA not found
TX1-GLINN03ML:ma_siteserver garrick.linn$

Other details, such as gem version and if you're working with a Linux or Windows VM
Running OSX 10.12.1 on my laptop
chef-provisioning-vsphere (0.10.0)
fog-vsphere (1.7.0)
knife-vsphere (1.2.24)

Thanks for letting us know about this. I will have a look. The method that looks for the pool doesn't support the slashes. We should probably be using find_pool to find a pool, though that would break if we're looking for a compute resource.
Does --pool Production-DA work at all?

Hi sorry for the delay. I tested this against our two clusters on one vcenter, and a pool inside one of those clusters, and it worked:
knife vsphere vm find --pool xxx-Prod --match-name converter # cluster
knife vsphere vm find --pool xxx-Lower --match-name cheftest # cluster
knife vsphere vm find --pool infrastructure_testing --match-name firewall-centos-72-f7a7d77f # pool inside xxx-Lower

We talked a bit in slack... just wanted to confirm you did try --pool "Production-DA". Is there perhaps another object with that same name that we're getting confused on?

Hi Sean...apologies should be coming from my side, I got knocked out by the flu for a few days and then got caught up in other things.
Hmm...I did try a few variations on that, but no dice.  (We do actually have a resource pool now for a redis cluster but that's the only one so far.)  Interestingly, we DO have a cluster named Clearview-Build-Staging which isn't throwing the "not found" error when passed to --pool, although it doesn't currently have any VMs in it.  Biggest difference I can see there is the lack of a slash in the cluster name, although that may be a red herring since (if I understand you correctly) you were able to specify a pool/cluster picked out from a cluster name containing a slash?
TX1-GLINN03ML:automate-match garrick.linn$ knife vsphere pool  list Pool: Production/Production_Tier1-DA/Redis TX1-GLINN03ML:automate-match garrick.linn$ knife vsphere vm find --pool Production-DA --match-name "DA3PMWS101" Pool Production-DA not found TX1-GLINN03ML:automate-match garrick.linn$ knife vsphere vm find --pool Clearview-Build-Staging TX1-GLINN03ML:automate-match garrick.linn$

Hi,
Unfortunately i am running of a fork of an old version and i didn't get to push anything back to main since the initial commit a year ago.
I think i have experienced the issue with the slashes and have that already fixed in our production, i will check that tomorrow and get back with a PR if so.

Hey @garrickmatch no, I can't use a slash. The code takes the pool and recursively searches for a pool or cluster with that name. There are other commands inside the gem that will split the name up on slashes and follow the hierarchy -- the fully/qualified/path isn't actually sent to the API.
Can you attach a screenshot of your cluster either here or in DM in Slack?

Thanks @rhadoo I'd love to see that!

Hi,
Sorry for the late reply.
It seems i have added a --pool-path flag, which makes --pool to be treated as path, going to find_pool() instead of traverse_folders_for_pool().
I don't think i have made any other change related to this.
I will pull current and try to add these.

That's a great way to maintain backwards compatibility. Thanks!