Question: factories.

Do you have any samples for factory using this library?

I think you might need to provide more details around what you are trying to do :)
A simple code example maybe

OK.
I have a controller which is used as a webhook catcher for payment system. Payment system makes a POST providing some JSON value as data. Using this JSON I can detect in field "type" what type of message I have received. Depending of this type I want to make different kind of message processors. And What I want is simply use these processors without new operator.

As a sample see here: https://github.com/ninject/ninject.extensions.factory/wiki/Factory-interface

The default implementation does not support implementing factory interfaces automatically and nor does it support passing runtime arguments when resolving services.
You might get away with something like this.
namespace ConsoleApp10
{
    using System.Diagnostics;
    using Microsoft.Extensions.DependencyInjection;
    using System;
    class Program
    {
        static void Main(string[] args)
        {
            Console.WriteLine("Hello World!");
            ServiceCollection collection = new ServiceCollection();
            collection.AddTransient<Processor>();
            collection.AddTransient<AnotherProcessor>();
            collection.AddTransient<IProcessorFactory, ProcessorFactory>();
            var provider = collection.BuildServiceProvider();

            var processorFactory = provider.GetService<IProcessorFactory>();
            var firstProcessor = processorFactory.GetProcessor("SomeType");
            Debug.Assert(firstProcessor.GetType() == typeof(Processor));

            var secondProcessor = processorFactory.GetProcessor("SomeOtherType");
            Debug.Assert(secondProcessor.GetType() == typeof(AnotherProcessor));
        }
    }

    public interface IProcessorFactory
    {
        IProcessor GetProcessor(string type);
    }

    public class ProcessorFactory : IProcessorFactory
    {
        private readonly IServiceProvider serviceProvider;

        public ProcessorFactory(IServiceProvider serviceProvider)
        {
            this.serviceProvider = serviceProvider;
        }

        public IProcessor GetProcessor(string type)
        {
            if (type == "SomeType")
            {
                return serviceProvider.GetService<Processor>();
            }
            return serviceProvider.GetService<AnotherProcessor>();
        }
    }

    public interface IProcessor
    {
    }

    public class Processor : IProcessor
    {
    }

    public class AnotherProcessor : IProcessor
    {
    }
}

You're welcome


Error match s3 when try to run command

I trying to run this without success:
lane :run_match do
  match(s3_region: 'us-east-1', s3_bucket: 'kolb-apps-ios-match')
end

The following error occurs. What's going on? How to use s3 integration?
Traceback (most recent call last):
	31: from /usr/local/Cellar/fastlane/2.145.0/libexec/bin/fastlane:23:in `<main>'
	30: from /usr/local/Cellar/fastlane/2.145.0/libexec/bin/fastlane:23:in `load'
	29: from /usr/local/Cellar/fastlane/2.145.0/libexec/gems/fastlane-2.145.0/bin/fastlane:23:in `<top (required)>'
	28: from /usr/local/Cellar/fastlane/2.145.0/libexec/gems/fastlane-2.145.0/fastlane/lib/fastlane/cli_tools_distributor.rb:119:in `take_off'
	27: from /usr/local/Cellar/fastlane/2.145.0/libexec/gems/fastlane-2.145.0/fastlane/lib/fastlane/commands_generator.rb:41:in `start'
	26: from /usr/local/Cellar/fastlane/2.145.0/libexec/gems/fastlane-2.145.0/fastlane/lib/fastlane/commands_generator.rb:349:in `run'
	25: from /usr/local/Cellar/fastlane/2.145.0/libexec/gems/commander-fastlane-4.4.6/lib/commander/delegates.rb:15:in `run!'
	24: from /usr/local/Cellar/fastlane/2.145.0/libexec/gems/fastlane-2.145.0/fastlane_core/lib/fastlane_core/ui/fastlane_runner.rb:76:in `run!'
	23: from /usr/local/Cellar/fastlane/2.145.0/libexec/gems/commander-fastlane-4.4.6/lib/commander/runner.rb:476:in `run_active_command'
	22: from /usr/local/Cellar/fastlane/2.145.0/libexec/gems/commander-fastlane-4.4.6/lib/commander/command.rb:153:in `run'
	21: from /usr/local/Cellar/fastlane/2.145.0/libexec/gems/commander-fastlane-4.4.6/lib/commander/command.rb:178:in `call'
	20: from /usr/local/Cellar/fastlane/2.145.0/libexec/gems/fastlane-2.145.0/fastlane/lib/fastlane/commands_generator.rb:108:in `block (2 levels) in run'
	19: from /usr/local/Cellar/fastlane/2.145.0/libexec/gems/fastlane-2.145.0/fastlane/lib/fastlane/command_line_handler.rb:36:in `handle'
	18: from /usr/local/Cellar/fastlane/2.145.0/libexec/gems/fastlane-2.145.0/fastlane/lib/fastlane/lane_manager.rb:56:in `cruise_lane'
	17: from /usr/local/Cellar/fastlane/2.145.0/libexec/gems/fastlane-2.145.0/fastlane/lib/fastlane/runner.rb:45:in `execute'
	16: from /usr/local/Cellar/fastlane/2.145.0/libexec/gems/fastlane-2.145.0/fastlane/lib/fastlane/runner.rb:45:in `chdir'
	15: from /usr/local/Cellar/fastlane/2.145.0/libexec/gems/fastlane-2.145.0/fastlane/lib/fastlane/runner.rb:49:in `block in execute'
	14: from /usr/local/Cellar/fastlane/2.145.0/libexec/gems/fastlane-2.145.0/fastlane/lib/fastlane/lane.rb:33:in `call'
	13: from Fastfile:29:in `block (2 levels) in parsing_binding'
	12: from /usr/local/Cellar/fastlane/2.145.0/libexec/gems/fastlane-2.145.0/fastlane/lib/fastlane/fast_file.rb:159:in `method_missing'
	11: from /usr/local/Cellar/fastlane/2.145.0/libexec/gems/fastlane-2.145.0/fastlane/lib/fastlane/runner.rb:157:in `trigger_action_by_name'
	10: from /usr/local/Cellar/fastlane/2.145.0/libexec/gems/fastlane-2.145.0/fastlane/lib/fastlane/runner.rb:227:in `execute_action'
	 9: from /usr/local/Cellar/fastlane/2.145.0/libexec/gems/fastlane-2.145.0/fastlane/lib/fastlane/runner.rb:227:in `chdir'
	 8: from /usr/local/Cellar/fastlane/2.145.0/libexec/gems/fastlane-2.145.0/fastlane/lib/fastlane/runner.rb:253:in `block in execute_action'
	 7: from /usr/local/Cellar/fastlane/2.145.0/libexec/gems/fastlane-2.145.0/fastlane/lib/fastlane/actions/actions_helper.rb:50:in `execute_action'
	 6: from /usr/local/Cellar/fastlane/2.145.0/libexec/gems/fastlane-2.145.0/fastlane/lib/fastlane/runner.rb:261:in `block (2 levels) in execute_action'
	 5: from /usr/local/Cellar/fastlane/2.145.0/libexec/gems/fastlane-2.145.0/fastlane/lib/fastlane/actions/sync_code_signing.rb:13:in `run'
	 4: from /usr/local/Cellar/fastlane/2.145.0/libexec/gems/fastlane-2.145.0/match/lib/match/runner.rb:58:in `run'
	 3: from /usr/local/Cellar/fastlane/2.145.0/libexec/gems/fastlane-2.145.0/match/lib/match/storage/s3_storage.rb:91:in `download'
	 2: from /usr/local/Cellar/fastlane/2.145.0/libexec/gems/fastlane-2.145.0/fastlane/lib/fastlane/helper/s3_client_helper.rb:50:in `find_bucket!'
	 1: from /usr/local/Cellar/fastlane/2.145.0/libexec/gems/aws-sdk-s3-1.61.2/lib/aws-sdk-s3/bucket.rb:74:in `exists?'
/usr/local/Cellar/fastlane/2.145.0/libexec/gems/aws-sdk-s3-1.61.2/lib/aws-sdk-s3/bucket.rb:79:in `rescue in exists?': [!]  (Aws::S3::Errors::BadRequest)

Have you included the s3_access_key and s3_secret_access_key variables somewhere, either in Matchfile or through the cli?


[Bug] sprite.play_flipbook's complete_function parameter must be optional

v1.5.0
sprite.lua:
...
---@param complete_function fun(self, message_id, message, sender))|nil function to ...
...
function sprite.play_flipbook(url, id, complete_function, play_properties) end

There is a redundant ) character in the method description.
https://defold.com/ref/stable/sprite/#sprite.play_flipbook:url-id-[complete_function]-[play_properties]

Sorry, seems like the issue in defold documentation)

I'll ping you when https://github.com/defold/defold/pull/8036 will be merged

Oh, thank you! Thought I'd catch them all at https://github.com/defold/defold/pull/7955m but not 😁.

Updated the release zip-archive with manual fixes. Please check it out.

Defold 1.6.0 released with a new fixed documentation! Thank you!


[scss] grid-template-areas not formatting as expected

Description
Formatting seems to break when using a SCSS variable in grid-template-areas.
Input
The code looked like this before beautification:
.foo-bar {
    $courseLibrarySearch-content-row1: "search search search . toggleFilters";
    grid-template-areas:
        $courseLibrarySearch-content-row1;

    .foo--showFilters & {
        grid-template-areas:
            $courseLibrarySearch-content-row1
            "assetTypeFilter languageFilter . . .";
    }
}

Expected Output
The code should have looked like this after beautification:
.foo-bar {
    $courseLibrarySearch-content-row1: "search search search . toggleFilters";
    grid-template-areas:
        $courseLibrarySearch-content-row1;

    .foo--showFilters & {
        grid-template-areas:
            $courseLibrarySearch-content-row1
            "assetTypeFilter languageFilter . . .";
    }
}

Actual Output
The  code actually looked like this after beautification:
.foo-bar {
    $courseLibrarySearch-content-row1: "search search search . toggleFilters";
    grid-template-areas:
        $courseLibrarySearch-content-row1;

    .foo--showFilters & {
        grid-template-areas:
            $courseLibrarySearch-content-row1 "assetTypeFilter languageFilter . . ."; // <--  why does this happen
    }
}

Steps to Reproduce
Format the code
Environment
OS: any
Settings
default settings in VSCode

I'm not sure why it is happening. Is it actually breaking functionality or is it simply less then ideal formatting?

It's definitely not ideal to have "rows" showing side-by-side like that

Agreed, I was just trying to understand the severity of the problem.
Preserve newlines should work in this area, but it apparently has a bug.


Release 0.24.0

This PR

updates deployments and gas measurements in data
adds a snapshot data_0.17.0
and updates the Changelog.

10,000 lines!  I think it's mostly contracts.json but still an impressive number.

@ulope that's a real problem. Maybe we can introduce an identifier that changes every time the file changes. https://github.com/raiden-network/raiden-contracts/issues/1083


AssertionError in visualizing trained models.

Hi! Thanks for the excellent work!
After I used train_all_copo_dist.py to train the model and try to visualize it, I found that the dimensions of OBS and Weights did not match, even the same problem in the <new_best_checkpoints>. This problem occurred in every environment I trained, and the number of rows in OBS is always 1 less than the number of columns in Weights.
But I can visualize the <new_best_checkpoints> by the new_vis.py, which is wired.
Traceback (most recent call last):
  File "/home/CoPO_tf/CoPO/copo_code/copo/vis_from_checkpoint.py", line 91, in <module>
    action = policy_function(o, d)
  File "/home/CoPO_tf/CoPO/copo_code/copo/eval/get_policy_function.py", line 170, in __call__
    actions = self.policy(obs_to_be_eval)
  File "/home/CoPO_tf/CoPO/copo_code/copo/vis_from_checkpoint.py", line 72, in policy
    ret = policy_class(weights, obs, policy_name=policy_name, layer_name_suffix="_1", deterministic=deterministic)
  File "/home/CoPO_tf/CoPO/copo_code/copo/eval/get_policy_function.py", line 61, in _compute_actions_for_tf_policy
    assert obs.shape[1] == weights[s].shape[0], (obs.shape, weights[s].shape)
AssertionError: ((20, 96), (97, 256))

The problem must come from the missing LCF dimension. In CoPO we add one extra dimension to the obs to include the social orientation.Best,ZhenghaoOn Mar 8, 2024, at 04:06, gcruiser @.***> wrote:
Hi! Thanks for the excellent work!
After I used train_all_copo_dist.py to train the model and try to visualize it, I found that the dimensions of OBS and Weights did not match, even the same problem in the <new_best_checkpoints>. This problem occurred in every environment I trained, and the number of rows in OBS is always 1 less than the number of columns in Weights.
But I can visualize the <new_best_checkpoints> by the new_vis.py, which is wired.
Traceback (most recent call last):
File "/home/CoPO_tf/CoPO/copo_code/copo/vis_from_checkpoint.py", line 91, in
action = policy_function(o, d)
File "/home/CoPO_tf/CoPO/copo_code/copo/eval/get_policy_function.py", line 170, in call
actions = self.policy(obs_to_be_eval)
File "/home/CoPO_tf/CoPO/copo_code/copo/vis_from_checkpoint.py", line 72, in policy
ret = policy_class(weights, obs, policy_name=policy_name, layer_name_suffix="_1", deterministic=deterministic)
File "/home/CoPO_tf/CoPO/copo_code/copo/eval/get_policy_function.py", line 61, in _compute_actions_for_tf_policy
assert obs.shape[1] == weights[s].shape[0], (obs.shape, weights[s].shape)
AssertionError: ((20, 96), (97, 256))
—Reply to this email directly, view it on GitHub, or unsubscribe.You are receiving this because you are subscribed to this thread.Message ID: @.***>


With SonarQube 5.6.2 upgrade the ADOP_LDAP_ENABLED option doesn't work properly

With SonarQube upgrade, the ADOP_LDAP_ENABLED option doesn't work properly. To elaborate more, if the ADOP_LDAP_ENABLED option is set to false then the SonarQube container crashes with following error -
org.jruby.rack.RackInitializationException: External authentication plugin [LDAP] has been found, but no related configuration has been set. Either update your configuration or remove the plugin
It seems that the ldap plugin is loaded and expects a configuration even though we haven't enabled LDAP.

Fixed in #13


Allow specifying "sub-package" within which the generated builder class will reside

Since all the builder classes that CallBuilder generates are currently dropped into the same namespace, there's a chance that class names will conflict.
To work around that, one can use a longer class name (perhaps prefixed with the name of the method that will be called). This could result, though, in very long class names.
Can you please enhance CallBuilder so that we can specify a sub-package in which the generated builder class will reside?
e.g.
package foo.bar;
class Baz {
    CallBuilder(className="builder.GenerateQuxBuilder")
    public static Qux generateQux();
}

will create foo.bar.builder.GenerateQuxBuilder.
This can then be imported as GenerateQuxBuilder with no risk of conflicts.
Alternatively, you can add an attribute to the annotation to specify the package name separately.

Yes, I agree with this proposal. Specifying the sub-package name wit a separate argument is a more flexible approach (i.e. subpackageName, and later we can add a packageName argument to specify an absolute package path)
I'll get to this eventually - should not be hard to implement. But if you want to send me a PR instead that would be welcome as well!


Request for better indication of available keystrokes

We figured out that it is possible to use keystrokes to execute cells (ctr+enter and shift+enter), but this is not obvious from the GUI. It would be nice if the menu bar could indicate keystrokes and also add an entry for evaluating just the current cell.
There is also no indication that ctr+blank gives autocompetion. So, indicating these functions would be helpful. If there are more keystrokes already implemented, it would also be good to show them within the corresponding menu items.

Thanks for the feedback, we will document this.

I added this to the notebook walkthrough (usage of ctrl+Space is highlighted in the link).
Also, can be searched for:
http://tellurium.readthedocs.io/en/latest/search.html?q=ctrl%2BSpace&check_keywords=yes&area=default

This is very nice! Just one comment: you can run a cell using two different keystrokes, either shift+enter or ctrl+enter. Both have a different effect (move to the next cell or stay where you are). Also Markdown cells can be evaluated like this, replacing the editor by the display of the encoded text.


chore(test): add docker test setup and script

:tada: This PR is included in version 1.0.8-alpha.3 :tada:
The release is available on:

npm package (@alpha dist-tag)
GitHub release

Your semantic-release bot :package::rocket:

:tada: This PR is included in version 1.0.8 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


[UI] make build-ui gives error in Node.js v17.6.0

Current Behavior

While using Node.js v17.6.0 (which is the latest version as of now) if we run make build-ui we will get some errors.
Desired Behavior

make build-ui should not produce errors in Node.js v17.6.0
Screenshots/Logs

Environment

Browser: Chrome Safari Firefox
Host OS: Mac Linux Windows
Meshery Server Version: stable-v
Meshery Client Version: stable-v
Platform: Docker Kubernetes

Contributor Guides and Resources

🎨 Wireframes and designs for Meshery UI in Figma
🖥 Contributing to Meshery UI
🙋🏾🙋🏼 Questions: Layer5 Discussion Forum and Layer5 Community Slack

Hey @adi611 this issue is not specific to meshery . Please refer to this

Hey @adi611 this issue is not specific to meshery . Please refer to this

Ok so should I close it?


chore: remove old audit advisories

Description
Updates yarn-audit-known-issues to exclude some no-longer valid auditAdvisories and unblocks failing CI: Failing CI.
Test plan
./scripts/ci_check_vulnerabilities.sh run locally and in CI.
Related issues
#3445 #3447
Backwards compatibility
Yes

@M-shin usually we have to add to yarn-audit-known-issues file if there is a new vulnerability we've decided is safe to ignore. It looks like in this case there were audit advisories that were unpublished.


Timeout configuration (web)

assets/config -> a config file for general settings like timeout (like in reactUI)

As far as I could research, it is not supported to add assets after the build.
However, I was successful by just adding the file under the web assets folder and it worked.
I added the following file under build/web/assets/assets/config/:
Note: The config folder is missing in the previewer.
app.conf.json:
{
  "requestTimeout": 5
}

Tested with:
flutter build web --release && python3 -m http.server --directory build/web/
Placed file.
Reloaded with CTRL+F5.
The new file is loaded by the browser and being applied on-top the constructor config.
Conclusion:
It works fine this way, but I could break whenever Flutter decides to change their asset loading process, as this is not supported.

Alternative "workaround":
Add an empty app.conf.json file to the build, which can be edited later.

Our client already recognizes loading the app.conf.json file? right? Usually, the pubscpec.yaml contains:

assets/config/

If there's no app.conf.json, at build time, it's not possible to access the file?
Your description is not clear for me, because the asset mapping is currently by directory and not by file. So If flutter will change asset loading, we have other problems as well?
Following scenarios:

The app.conf.json is not available... but after deployment we need it, so we create it manually...
The app.conf.json is available and empty (or contains disabled properties.. comments) -> we simply change the file after deployment

The second scenario should work without problems, right?
The first scenario? What will happen if we add the asset by name to the yaml file? A build error if asset is not available?

It seems like the flutter.assets config in pubspec.yaml doesn't impact us in any way for this issue.
Even though there is no config/ in the pubspec during build, the HTTP request for the file in the subfolder is still made by the browser.
This is the part where Flutter could decide to change this behavior to first assess the generated AssetsManifest.json file which contains a list of all known assets and then fire the request depending on that file.
Example:
In the previewer there is currently only this set in the config:
  assets:
    - assets/

Nevertheless, I can still add the new config folder after the build, and it works (for now).
If Flutter ever decides to change this, this should be the only instance that can break, as our other approaches to asset loading are supported.
Regarding your mentioned scenarios:

Yes, declaring a non-existent file in the assets section makes the build fail.
Currently? Yes, and I also believe that this will work reliably in the future, although assets are defined as static never-changing files, I don't think that there will be ever a change that would prevent editing the file after the build.

The assets are only important for the build.
I guess flutter won't change resource loading because it makes old applications incompatible and it's not important for flutter. Why shouldn't the application dynamically load resources?
Anyway, if we add the file manually after build, it will work.
An empty file is not nice because it's an unused resource.... but a 404 for a not found resource is also not nice...
No perfect solution possible, we should use it as it is.


Consolidate general-purpose analyzers

We have some non-MVC analyzers hanging out in the Mvc.Analyzers package.
Part of: #12288

This is mostly a cut-paste. There are some changes here for consistency and to address deviations between these test projects.


npm run lint failing on osx

I'm following along with the Building a JavaScript Development Environment Pluralsight course, Linting chapter - Demo video.  I just modified package.json and added .eslintrc.json
Running npm run lint produces an error, and creates the attached npm-debug.log file.
There are no spaces in any directories in my projects path.  Can you advise?
npm-debug.txt

Does this issue occur if you download and run the final course exercise project?
Have you assured .eslintrc is in the root of your project? (same path as package.json)

Yes, the issue does occur.  I've copied all files from your repo.  The .eslintrc.json and package.json are both in the root project directory.  The only thing I can see that may be different, is that I'm running in a virtualenv.

That's odd. I'm running the same versions on MacOS just fine. And unfortunately the npm-debug isn't providing me anything actionable. You might try reinstalling Node or installing the latest version of Node. 7.5 also runs fine on my Mac.

Reinstalled, to no avail.  The issue stemmed from having the line 'debugger;'  in index.js

relevant thread: https://github.com/eslint/eslint/issues/7933


Upgrade dependencies

This upgrades apollo, graphql, and lsp dependencies, which contain fixes for some important issues. Specifically this should resolve #123

@divyenduz anything blocking getting this merged?

@ganemone Thanks for raising this, I am merging this PR, it will be release with the next release. Probably over the weekend 🙌


Export: Feather export is uncompressed

Lz4 compression is not installed by default when installing pyarrow through conda.
For ease of use (no need to fiddle with Python environment by end users), this means temporarily feather files are exported uncompressed.
See also: #12500

Tagged won't fix as we need changes to another package.


GOXLR-Mini does not work

The goxlr-mini isn't working at all, the app won't pick it up and / or the daemon can't initialise it.
This issue is due to the system agent that initialises as root the goxlr when plugged in. As the agent looks for a device with the device ID of a full GoXlr, it doesn't pick up the mini.
・Fix :
You can edit the file:
/Library/LaunchAgents/com.adesky.goxlr.plist
and change the id as below:
<key>idProduct</key>
<integer>36836</integer>

then do in Terminal:
launchctl unload /Library/LaunchAgents/com.adesky.goxlr.plist
launchctl load /Library/LaunchAgents/com.adesky.goxlr.plist

Hmmmm, I think it's an error, first it's on the wrong repo (this repository is for the GoXlr-utility and not for the goxlr-on-macos project), and it's a known issue, literally copy / pasted from the known issue post that I just did in the discord server <_>
So as it's a known issue, and on files not added by the goxlr-utility, no need to open an github issue ! :3 (as even on my own repository it's obviously going to be fixed)

@Adelenade apologies, wrong repo


[FLINK-29042][Connectors/ElasticSearch] Support lookup join for es connector

Now es connector could only be used as a sink, but in many business scenarios, we treat es as a index database, thus we should support to make it lookupable in flink.

@MartijnVisser Hi. Could you please give a review? Thanks!

@vahmed-hamdy Since you offered to volunteer to review an Elasticsearch PR, perhaps you could also have a look at this open PR?

@MartijnVisser @vahmed-hamdy Hi, The feature has taken effect in our production environment for one more years, now we want to updrade our es connector, if the feature would be merged, it would be very nice to upgrade directly!

@reta Do you have any considerations before merging this?

@reta Do you have any considerations before merging this?

@MartijnVisser LGTM, we would probably could bring that to OpenSearch connector as well, thank you!

thanks for the contribution
also looks good from my side
i left some minor comments
+1 for having similar things for OpenSearch

@snuyanzin Will you take care of the rest of the review and merge it when you think it's OK?

yes, sure, will try to do it later today/tomorrow

CI failed caused by outdated dev branch, I would rebase on the latest main branch.

@snuyanzin  @MartijnVisser Thanks a lot for your patient work.


Language request: DOT (graph description language)

Language
"DOT is a graph description language. DOT graphs are typically files with the filename extension gv or dot." - source
Additional resources
Wikipedia

As DOT and gv are announced officially among #languages, will there be a new release like v1.24.0?

Yes, DOT will be in the next release soon but you can also get it right now by going to our download page.


Always check return expressions when type checking a file

Fixes #3166. Because we get return types from signatures on demand, and we defer checking function expression bodies, any noImplicitAny errors resulting from widening a return expression may be missed. This change forces these checks when we visit function expression bodies in the checker.

:+1: With the test i mentioned.

lgtm


Tileset content.url to content.uri

Part of #6697
To reflect updates to the 3D Tiles spec, deprecated support for 3D Tiles content.url in favor of content.uri.
Also added a test to make sure tilesets using data uri's for their content load and render.
TODO:

[ ] Once the PR is merged, add a note to #5363.

@ggetz, thanks for the pull request! Maintainers, we have a signed CLA from @ggetz, so you can review this at any time.
:warning: I noticed that CHANGES.md has not been updated. If this change updates the public API in any way, fixes a bug, or makes any non-trivial update, please add a bullet point to CHANGES.md and comment on this pull request so we know it was updated. For more info, see the Pull Request Guidelines.

I am a bot who helps you make Cesium awesome! Contributions to my configuration are welcome.
:earth_africa: :earth_americas: :earth_asia:

Thanks @lilleyse , updated!

Thanks!


Microsoft Edge (Chromium) mirrors map on tab change

Describe the bug
After tab change/minimize latest OL 5.3.0 and previous versions mirror and turns map upside down in new MS Edge (Chromium)
To Reproduce
Steps to reproduce the behavior:

Go to https://openlayers.org/en/latest/examples/navigation-controls.html
Pan around & minimize or change tab
Come back to see :

Expected behavior
Tab change/minimize won't turn map upside down
Microsoft Edge
Version 78.0.262.0 (Official build) dev (64-bit)

Sorry, I guess it is Edge bug.
Reported that to them.
It happens in any canvas element not related to OpenLayers


Highlightings doesn't render when using --load-config

General description of bug:
I have multiple config files in my $HOME/.config/fastfetch/ directory, and I want to load these different config files by using --load-config.
But I've noticed that if in $HOME/.config/fastfetch/ directory, there is config.conf or config.jsonc file when trying to use --load-config. File config.conf/config.jsonc will be loaded first, only after config.conf/config.jsonc file was loaded, will be loaded config file that was set when using --load-config.
Which causes issues with color, highlights and with --set-keyless variables, when multiple variables with the same name exists in config.conf and in config file that user trying to use when passing --load-config argument.
The same thing for using config files from "/usr/local/share/fastfetch/presets", config.conf file being loaded first, and only then config that was set when passing argument --load-config will be loaded, with issues.
The same thing for using config files from "/usr/local/share/fastfetch/presets", config.conf file is loaded first, and only then config from fastfetch presets will be loaded that user set when passing argument --load-config, with issues.
So i think the only solution is just to ignore "$HOME/.config/fastfetch/config.conf" and "$HOME/.config/fastfetch/config.jsonc" and $HOME/.config/fastfetch/config.conf" file when using argument --load-config, and load only config that was set when passing --load-config argument.
That's probably will be better than removing config.conf and using env NO_CONFIG=1 before using fastfetch with passing --load-config argument, I think.

What happened: Have "$HOME/.config/fastfetch/config.conf" file, trying to pass fastfetch --load-config small.conf causes issues with color highlights (all color highlights are white), because "config.conf" file loads first, and only after "config.conf" being loaded "small.conf"
What should happen: "config.conf" file should be ignored, and "small.conf" should be loaded first. (config that was set when trying to pass --load-config argument should be loaded first)
Did it work in an older version: no, I've seen old post  about this issue, so I think this issue is still persists, and still not fixed.
Where did you get the binary: Github dev branch
Does this issue still occurs in the latest dev build? yes

I've also seen this post 377 about this issue, so I hope this will be helpful.
Often helpful information:
Output of fastfetch --version:
fastfetch 1.12.2-457 (x86_64)

The content of the configuration file you use (if any)
(small.conf)
--logo arch_small
--logo-color-1 blue

--color blue
--separator ": "

--set-keyless Start=┌───────────────────────────────┐
--set-keyless End=└───────────────────────────────┘

--os-key "|  OS"
--host-key "|  Host"
--kernel-key "|  Kernel"
--uptime-key "|  Uptime"
--packages-key "|  Packages"
--shell-key "|  Shell"
--wm-key "|  WM"

--structure Title:Start:OS:Host:Kernel:Uptime:Packages:Shell:WM:End

(config.conf):
Actually it looks the same as small.conf but with some differences with --set-keyless and that instead of arch_small there is default arch logo
--logo arch
--logo-color-1 blue
--logo-color-2 blue

--color blue
--separator ": "

--set-keyless Monoline="""""""""""

--set-keyless Software=┌───────── \e[1mSoftware Information \e[0m─────────
--set-keyless Hardware=├───────── \e[1mHardware Information \e[0m─────────
--set-keyless End=└────────────────────────────────────────

--os-key "| OS"
--host-key "| Host"
--kernel-key "| Kernel"
--uptime-key "| Uptime"
--packages-key "| Packages"
--shell-key "| Shell"
--wm-key "| WM"

--gpu-key "| GPU0"
--cpu-key "| CPU"
--memory-key "| Memory"
--terminal-key "| Terminal"
--theme-key "| Theme"
--display-key "| Display (VGA1)"
--locale-key "| Locale"

--structure Title:Monoline:Software:OS:Kernel:Packages:Shell:WM:Terminal:Theme:Hardware:Host:Display:CPU:GPU:Memory:End

Output of fastfetch --list-features:
threads
libpci
vulkan
wayland
xcb-randr
xcb
xrandr
x11
gio
dconf
dbus
zlib
xfconf
sqlite3
egl
glx
osmesa
libpulse
libnm

Does sleep 1 before running fastfetch work? no

PS: Hope this will be helpful!

The problem is that the command line flags are always parsed and loaded after other config files being loaded, because we need the command line flags to override other flags set before. That's also the same reason why an strange environment variable NO_CONFIG is introduced instead of using command line flag --no-config

Did it work in an older version: no, I've seen old https://github.com/fastfetch-cli/fastfetch/issues/377about this issue, so I think this issue is still persists, and still not fixed.

Oh, that explains why I can't reproduce the issue.

Oh okay, that's explains a lot. So I think the current solution (for me atleast lol) just to rename config.conf file to something else like config.conf.bak, for not being loaded, and load custom config files by using --load-config without any issues.
Anyways, glad to hear that my post was helpful, and now you can reproduce the issue! Goodluck in development!

Does env NO_CONFIG=1 fastfetch --load-config your_config work?

Well yes, config.conf file doesn't being loaded first, and only my config file that I've set in --load-config being loaded.

Please test the latest dev build


Add ability for quests to drop wyrmprints

Quests should drop wyrmprints at a random rate. This is especially important for Rise of the Sinister Dominion as duplicate wyrmprints there grant unique materials that are required to progress.

Closed by #464


Fix incorrect placement of material sphere and mesh at the same time in material preview

Fixes #60425

I approved the cicd workflow for testing the commit. The pr will still need review.

Thanks! And congrats for your first merged Godot contribution :tada:

Thanks! And congrats for your first merged Godot contribution tada

Thank you


set of examples to cover

Can we agree on a set of examples to cover
For now I have only considered the first few examples from the "Dataset and examples" chapter from the SPM12 documentation.
@cmaumet  it would probably be easier if we designate a set of examples in advance, along with a few mandatory fields in each example.

Yes!! We could start with the ones in: https://github.com/incf-nidash/nidmresults-examples

@cmaumet  can you pick on specific example pointing to the SPM12 doc, or any kind of documentation ? I don't know where examples from nidm-results come from

@remiadon: those examples are nice because they cover a lot of different use cases in fMRI. I'm happy to help out recovering the corresponding pipelines. As a start, can you read the manuscript at: http://dx.doi.org/10.3389/fninf.2016.00024 if you have not done it already? For each example, the code used to run the analysis should be available in the same GitHub repo, (see "Data sources" in the paper).


Test against multiple versions of ember-data

Test against multiple versions of ember-data. Will make it very easy for us to test against canary.
Locally, run:
$ EMBER_DATA_VERSION=1.0.0-beta.16 node ./config/select-dep-versions.js && ember test
Based on 1.0.0-beta.16 I'm using:
  ember-data 1.0.0-beta.16

$ EMBER_DATA_VERSION=canary node ./config/select-dep-versions.js && ember test
Based on canary I'm using:
  ember-data 1.0.0-beta.17+canary.e8ceeeb4c0

Note: I'm expecting this to fail for canary and beta.16

[x] Remove failing ED versions (for now)
[x] Add documentation to README.md on how to select a version locally

/cc @brendanoh

This is fantastic. Will help people get started which is so critical to early adopters.


SP2-607 Create the Agree Plan controller routing

I did look at that, but because there isn't a view yet or any action to take I didn't add it. I will add a skeleton controller test file.


Grafana agent kubelet metrics

Make it possible to ship Kubelet metrics for tenant namespaces to Grafana cloud.

Should we have some protection against for example accidentally exposing kube-system?

Should we have some protection against for example accidentally exposing kube-system?

You a re thinking about a check that tenant namespaces and extra namespaces don't contain "kube-system"?

Yes, might be useless but just an idea.

It's a fair point but I would argue that it's out of scope for this PR and should be in another one. Feel free to create an issue/PR about it @phillebaba


16401 archived immutable

Summary
If a channel is archived this PR will prevent users from making changes to that channel meta-data.  This includes changes to both the front and back end.
Ticket Link
https://github.com/mattermost/mattermost-server/issues/16401

Hello @arjunagl,
Thanks for your pull request! A Core Committer will review your pull request soon. For code contributions, you can learn more about the review process here.

Hello @arjunagl,
Thanks for your pull request! A Core Committer will review your pull request soon. For code contributions, you can learn more about the review process here.

@cpoile, can you give this a quick "still in draft" review to help guide @arjunagl?

@cpoile, can you give this a quick "still in draft" review to help guide @arjunagl?

@cpoile I keep getting the following on linting
Property 'css' does not exist on type 'DetailedHTMLProps<HTMLAttributes<HTMLDivElement>, HTMLDivElement>'
However I believe I did not introduce a change for this to err, any idea ?

Hi @arjunagl ! I'm sorry, this got buried. Could you merge master and then I'll take a look at it asap? Thanks!

Hi @arjunagl ! I'm sorry, this got buried. Could you merge master and then I'll take a look at it asap? Thanks!

hi @cpoile no worries, merged with master.

This PR has been automatically labelled "stale" because it hasn't had recent activity.
A core team member will check in on the status of the PR to help with questions.
Thank you for your contribution!
/cc @jasonblais @jfrerich @emilyacook

/update-branch

This PR has been automatically labelled "stale" because it hasn't had recent activity.
A core team member will check in on the status of the PR to help with questions.
Thank you for your contribution!
/cc @jasonblais @jfrerich @emilyacook

Hi @arjunagl, thank you for your work on this! Are you still interested in finishing this PR? Let us know if you can't!

Hi @arjunagl, thank you for your work on this! Are you still interested in finishing this PR? Let us know if you can't!

Hi, yes I'm working on this, sorry for the delay in getting back, got a bit carried away, will work on this during the weekend and merge.

Great, thank you! No worries about the delay, I know life gets in the way.

Thanks for your help here, @arjunagl! I've been making some changes that touch a ton of code and probably make it easier to start on this PR from scratch. I'm going to close the PR for now and re-open the issue, but feel free to ping me if you're still interested!


Gnosis router missing transfers

Describe the bug
Last trasnfer completed in August
https://connextscan.io/router/0x048a5ecc705c280b2248aeff88fd581abbeb8587
Additional context
Convo about it in here
https://discord.com/channels/992549151134982234/1169876506579832873

fixed


First pass at CI and release process improvements

Link the Issue(s) this Pull Request is related to.
Each PR should link at least one issue, in the form:
Fixes #123
Use one line for each Issue. This allows auto-closing the related issue when the fix is merged.
Summarize your change.
Describe the reason for the change.
Add a list of changes, and note any that might need special attention during review.
Reference associated tests.
If no new tests are introduced as part of this PR, note the tests that are providing coverage.

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (745e614) 79.84% compared to head (b3cabad) 79.84%.
Report is 5 commits behind head on main.

Additional details and impacted files

@@           Coverage Diff           @@
##             main    #1689   +/-   ##
=======================================
  Coverage   79.84%   79.84%
=======================================
  Files         197      197
  Lines       21767    21792   +25
  Branches     4354     4358    +4
=======================================
+ Hits        17379    17399   +20
+ Misses       2234     2232    -2
- Partials     2154     2161    +7

Flag
Coverage Δ

py-unittests
79.84% <ø> (+<0.01%)
:arrow_up:

Flags with carried forward coverage won't be shown. Click here to find out more.
see 11 files with indirect coverage changes

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 745e614...b3cabad. Read the comment docs.


PyTest && PyENV

Hello, pay attention to the doctor's reports!
The doctor will see you now...

> Checking your Emacs version...
> Checking for Emacs config conflicts...
> Checking for private config conflicts...
> Checking for stale elc files...
> Checking Doom Emacs...

Failed to enable theme: solaire-swap-bg-theme
  ✓ Initialized Doom Emacs 2.0.9
  ✓ Detected 50 modules
  ✓ Detected 169 packages
  > Checking Doom core for irregularities...
    Found font material-design-icons.ttf
    Found font weathericons.ttf
    Found font octicons.ttf
    Found font fontawesome.ttf
    Found font file-icons.ttf
    Found font all-the-icons.ttf
  > Checking for stale elc files in your DOOMDIR...
  > Checking your enabled modules...
    > :lang python
      ! Couldn't find nosetests. Running tests through nose will not work.
      ! Couldn't find pytest. Running tests through pytest will not work.
      ! Couldn't find pyenv in your PATH
    > :lang sh
      ! Couldn't find shellcheck. Shell script linting will not work

There are 4 warnings!
✓ Finished! (2.7579s)

My init.el file modules
 (python +pyenv )
 sh

Please help. I use Arch distribution,All prerequisites are installed.

Can you confirm that running pyenv, shellcheck, etc. from the terminal gives you no errors?

Can you confirm that running pyenv, shellcheck, etc. from the terminal gives you no errors?

The problem is only in the emacs. I have access to pyenv and sh in the terminal.

Run ~/.emacs.d/bin/doom env then restart Emacs.

Run ~/.emacs.d/bin/doom env then restart Emacs.
I've done this before, but I've done it again, and the problem persists.

I upgraded to version 28 and the problem was solved.


avoid calling ffi::PyBuffer_Release twice in PyBuffer::release

Fixes https://github.com/PyO3/pyo3/issues/776.

CI failure looks related. I'm trying to repro it.

Got a repro. (I've found I need to export RUSTUP_TOOLCHAIN=nightly, I think because there are temp directories involved, and rustup override set nightly isn't sufficient to guarantee that nightly runs. Other folks who use stable as their default will probably run into the same issue. Maybe the tests could be tweaked to explicitly invoke cargo +nightly?)

This is a very elegant solution, though I think in practice it's probably sufficient to just replace the whole function implementation with std::mem::drop(self). The cost of "acquiring" the gil is unlikely to be that bad given one must already hold the GIL to call PyBuffer::release

Gotcha, though in that case, why expose the release method at all?

That's a great question - all of this code was written well before I got involved with pyo3! 😄

Let's see what other maintainers say (cc @kngwyu)

Good catch and nice PR, thank you @oconnor663 !

Gotcha, though in that case, why provide the release method at all?

This function was written before forking under the name of rust-cpython, so I don't know why too.


[try2] Move local_authenticator to test lib

@AlanCoding  what do you think about having apps expose their own fixtures in their own module? To me this fixture is closely related to (and depends on) the authentication app, it feels like it should belong there instead, keeping the testing lib for more general fixtures.
I wanted to have the discussion now because moving it later will be annoying for all apps depending on the fixture.

@relrod removing this fixtures from other fixtures like user also broke tests related to the resource registry.
Apps can already put their own fixtures in their own module, like rbac, which has its own test_app/tests/rbac/conftest.py.
What I need this for is https://github.com/ansible/eda-server/pull/674, which is not an app internal to DAB, but a real project using this as a library. Just like these projects will use DAB base views and other things, it makes sense to me to have shared test utils. A user fixture and a user API client fit perfectly well in that scope. I don't care about local_authenticator one way or the other, it's just something that got in the way of employing those other useful things.


nixos/pam: prioritize safer auth methods over fingerprints

Currently if fprintd is enabled, pam will ask for fingerprint
regardless of other configured authentication modules (e.g. yubikey).
This change make fingerprint the last resort of authentication before asking for password.

Motivation for this change
Things done

[X] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
Built on platform(s)

[X] NixOS
[ ] macOS
[ ] other Linux distributions

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
[ ] Tested execution of all binary files (usually in ./result/bin/)
[ ] Determined the impact on package closure size (by running nix path-info -S before and after)
[ ] Ensured that relevant documentation is up to date
[X] Fits CONTRIBUTING.md.

/marvin opt-in
/status needs_reviewer

/needs_merger

/status needs_reviewer

@SuperSandro2000 Can you merge this PR? Other reviewers seem to be unresponsive

@SuperSandro2000 Can you merge this PR? Other reviewers seem to be unresponsive

I don't know pam so I am a bit hesitant.


Web UI display error after adding annotations via REST API.

What does this mean?
Error: [mobx-state-tree] No matching type for union ({ pid: string?; score: (number | null?); readonly: boolean?; hidden: boolean?; parentID: (string | null?); fromSuggestion: boolean?; dynamic: boolean?; locked: boolean?; origin: ("prediction" | "prediction-changed" | "manual")?; meta: ?; normInput: (string | null?); id: identifier?; ouid: number?; results: { id: identifier?; score: (number | null?); from_name: reference((AudioModel | AudioModel | PolygonRegionModel | BrushRegionModel | KeyPointRegionModel | RectRegionModel | EllipseRegionModel | ImageModel | LabelModel | LabelsModel | ParagraphLabelsModel | TextAreaRegionModel | TextAreaModel | ChoiceModel | ChoicesModel | RatingModel | ParagraphsModel | RichTextModel | RichTextModel | TableModel | ChannelModel | TimeSeriesModel | PagedViewModel | TimeSeriesRegionModel | RelationsModel | VideoModel | BrushModel | BrushLabelsModel | HyperTextLabelsModel | KeyPointModel | KeyPointLabelsModel | ListModel | DateTimeM

I get this when I try to display images in the labeling UI after using the REST endpoint to create an annotation.
I am using the ML Backend to first query the backend for predictions, and then I add these predictions as annotations because otherwise they do not end up in the database, apparently.
def predict_for_all_tasks(client: Client, project: Project):

    tasks = take(10, project.get_tasks())
    logger.info(f"Predicting for {pluralize(len(tasks), 'task')}...")

    response = requests.post(
        headers={"Authorization": f"Token {client.api_key}"},
        url="http://localhost:9090/predict",
        json={"tasks": tasks},
    )
    logger.debug(f"Response for prediction:\n {json.dumps(response.json(), indent=2)}")
    response.raise_for_status()
    logger.success(f"Prediction successful.")
    return response.json()["results"]

def create_annotations_from_predictions(client: Client, predictions: List[dict]):
    """
    https://labelstud.io/api#operation/api_tasks_annotations_create

    curl -X POST -H 'Content-type: application/json' https://localhost:8080/api/tasks/{id}/annotations -H 'Authorization
    : Token abc123' --data '{...}'
    """

    logger.info(f"Creating annotations for {pluralize(len(predictions), 'task')}...")

    for prediction in predictions:
        task_id = prediction["result"][0]["task_id"]  # TODO: This is wonky
        logger.info(f"Creating annotation for task {task_id}...")

        payload = {
            "completed_by": 1,  # this has to be an existing user id, otherwise the request fails
            "unique_id": uuid(),
            "result": prediction["result"],
            "was_cancelled": True,
            "ground_truth": True,
            "last_action": "prediction",
            "task": task_id,
            "project": None,
            "updated_by": None,
            "parent_prediction": None,
            "parent_annotation": None,
            "last_created_by": None,
        }

        response = requests.post(
            headers={"Authorization": f"Token {client.api_key}"},
            url=client.get_url(f"/api/tasks/{task_id}/annotations"),
            json=payload,
        )
        logger.debug(f"Response for annotation creation:\n {json.dumps(response.json(), indent=2)}")
        response.raise_for_status()
        logger.success(f"Annotation successful.")

Calling code:
client = initialize_label_studio()
project = initialize_project(client)
...
predictions = predict_for_all_tasks(client, project)
create_annotations_from_predictions(client, predictions)

label-studio                   1.7.0
label-studio-converter         0.0.48rc0
label-studio-ml                1.0.9
label-studio-sdk               0.0.16
label-studio-tools             0.0.1

So for what it's worth: Doing it like this works:
        predictions = predict_for_all_tasks(client, project)

        for prediction in predictions:
            result = prediction["result"]
            task_id = result[0]["task_id"]
            project.create_prediction(task_id, result)

Working with this SDK is not a fun experience!!

Okay, why on earth does the ML backend get triggered again when I press "Label All Tasks" in the GUI? The tasks have already been predicted for! That is why I am doing all of this, so that the predictions get produced beforehand! SO that one does not have to wait for the inference to run for the next task every time on submits a task!

What does this mean?

Your prediction["result"] mismatches with your labeling config. Most likely you use incorrectly from_name field.

why on earth does the ML backend get triggered again when I press "Label All Tasks" in the GUI?

Most likely this toggle is enabled in your setup. ML backend is triggered because of active learning strategy: by design when you click submit, you retrain your model. Then ML backend retrieve the newest predictions from the newest model.

@makseq No, the toggle is off when I go to the project settings. Also, the from_name is not differing. I looked at the diff between a prediction produces by triggering the process from the GUI and a prediction produced via the REST API.
not working:
{
  "annotations": [
    {
      "completed_by": {
        "avatar": null,
        "email"<EMAIL_ADDRESS>        "first_name": "",
        "id": 1,
        "initials": "ja",
        "last_name": ""
      },
      "created_ago": "0 minutes",
      "created_at": "2023-01-20T15:28:53.843705Z",
      "created_username": "<EMAIL_ADDRESS>1",
      "ground_truth": true,
      "id": 126,
      "lead_time": null,
      "parent_annotation": null,
      "parent_prediction": null,
      "project": 170,
      "result": [
        {
          "from_name": "tag",
          "id": "CCEh5geMrzbKa3TYdCrNyM",
          "image_rotation": 0,
          "origin": "inference",
          "original_height": 528,
          "original_width": 624,
          "task_id": 1235,
          "to_name": "image",
          "type": "brushlabels",
          "value": {
            "brushlabels": [
              "crack"
            ],
            "format": "rle",
            "rle": []
          }
        }
      ],
      "task": 1235,
      "updated_at": "2023-01-20T15:28:53.843725Z",
      "was_cancelled": true
    }
  ],
  "data": {
    "image": "/data/local-files/?d=/images/7b3a6559b521f7d27bafde64b6e67a1a.jpeg"
  },
  "id": 1235,
  "predictions": []
}

working:
{
  "annotations": [
    {
      "completed_by": {
        "avatar": null,
        "email"<EMAIL_ADDRESS>        "first_name": "",
        "id": 3,
        "initials": "de",
        "last_name": ""
      },
      "created_ago": "0 minutes",
      "created_at": "2023-01-20T15:30:57.891778Z",
      "created_username": "<EMAIL_ADDRESS>3",
      "ground_truth": false,
      "id": 136,
      "lead_time": 56.564,
      "parent_annotation": null,
      "parent_prediction": 1426,
      "project": 170,
      "result": [
        {
          "from_name": "tag",
          "id": "bdkLi7VCdYMhoCxnaDBkJx",
          "image_rotation": 0,
          "origin": "prediction",
          "original_height": 528,
          "original_width": 624,
          "to_name": "image",
          "type": "brushlabels",
          "value": {
            "brushlabels": [
              "crack"
            ],
            "format": "rle",
            "rle": []
          }
        }
      ],
      "task": 1245,
      "updated_at": "2023-01-20T15:30:57.891797Z",
      "was_cancelled": false
    }
  ],
  "data": {
    "image": "/data/local-files/?d=/images/4c588c8647e45a1670feb0cd16db08fe.jpeg"
  },
  "id": 1245,
  "predictions": []
}

ML backend is triggered because of active learning strategy: by design when you click submit, you retrain your model. Then ML backend retrieve the newest predictions from the newest model.

Okay. Why? That makes no sense to me. The use presses "submit" to confirm an annotation. Why would the design be to re-train the model when a single new annotation is confirmed? What I would expect is a policy API. A user can define a policy that for example states: if num_newly_annotated_datapoints > minimum_new_datapoints_before_retraining and model.score(newly_annotated_datapoints) < mode.score(test_set_of_previously_labeled_datapoints) then model.fit(...)

@mbspng any resolution here? Currently dealing with a somewhat similar issue.


generating token but no notification

Tokens are being generated successfully.  Pushing notifications from firebase console using generated token and it shows as success. But not receiving any notification.

Please explain how the token is generate using electron-push-receiver as I ain't able to get through it


[Windows] Exclude KB5001148 from windows update

Description
[Windows] Exclude KB5001148 from Windows update
Related issue:
Check list

[ ] Related issue / work item is attached
[ ] Tests are written (if applicable)
[ ] Documentation is updated (if applicable)
[ ] Changes are tested and related VM images are successfully generated

/azp run windows2019,windows2022

Agree with this if this KB is not needed as the error I get is
    azure-arm.build_image:
    azure-arm.build_image: Installing windows updates
    azure-arm.build_image:
    azure-arm.build_image: X ComputerName Result     KB          Size Title
    azure-arm.build_image: - ------------ ------     --          ---- -----
    azure-arm.build_image: 1 pkrvmdxit... Accepted   KB4589208    3MB 2021-01 Update for Windows Server 2019 for x64-based Systems (KB4589208)
    azure-arm.build_image: 1 pkrvmdxit... Accepted   KB5011267   80MB 2022-02 Cumulative Update Preview for .NET Framework 3.5, 4.7.2 and 4.8 f...
    azure-arm.build_image: 1 pkrvmdxit... Accepted   KB890830    58MB Windows Malicious Software Removal Tool x64 - v5.117 (KB890830)
    azure-arm.build_image: 1 pkrvmdxit... Accepted   KB5030178   80MB 2023-09 Cumulative Update for .NET Framework 3.5, 4.7.2 and 4.8 for Windo...
    azure-arm.build_image: 1 pkrvmdxit... Accepted   KB5001148    1MB Visual Studio Client Detector Utility
    azure-arm.build_image: 1 pkrvmdxit... Accepted   KB5030214   17GB 2023-09 Cumulative Update for Windows Server 2019 (1809) for x64-based Sy...
    azure-arm.build_image: 2 pkrvmdxit... Downloaded KB4589208    3MB 2021-01 Update for Windows Server 2019 for x64-based Systems (KB4589208)
    azure-arm.build_image: 2 pkrvmdxit... Downloaded KB5011267   80MB 2022-02 Cumulative Update Preview for .NET Framework 3.5, 4.7.2 and 4.8 f...
    azure-arm.build_image: 2 pkrvmdxit... Downloaded KB890830    58MB Windows Malicious Software Removal Tool x64 - v5.117 (KB890830)
    azure-arm.build_image: 2 pkrvmdxit... Downloaded KB5030178   80MB 2023-09 Cumulative Update for .NET Framework 3.5, 4.7.2 and 4.8 for Windo...
    azure-arm.build_image: 2 pkrvmdxit... Downloaded KB5001148    1MB Visual Studio Client Detector Utility
    azure-arm.build_image: 2 pkrvmdxit... Downloaded KB5030214   17GB 2023-09 Cumulative Update for Windows Server 2019 (1809) for x64-based Sy...
    azure-arm.build_image: 3 pkrvmdxit... Installed  KB4589208    3MB 2021-01 Update for Windows Server 2019 for x64-based Systems (KB4589208)
    azure-arm.build_image: 3 pkrvmdxit... Installed  KB5011267   80MB 2022-02 Cumulative Update Preview for .NET Framework 3.5, 4.7.2 and 4.8 f...
    azure-arm.build_image: 3 pkrvmdxit... Installed  KB890830    58MB Windows Malicious Software Removal Tool x64 - v5.117 (KB890830)
    azure-arm.build_image: 3 pkrvmdxit... Installed  KB5030178   80MB 2023-09 Cumulative Update for .NET Framework 3.5, 4.7.2 and 4.8 for Windo...
    azure-arm.build_image: 3 pkrvmdxit... Installed  KB5001148    1MB Visual Studio Client Detector Utility
    azure-arm.build_image: 3 pkrvmdxit... Installed  KB5030214   17GB 2023-09 Cumulative Update for Windows Server 2019 (1809) for x64-based Sy...
    **azure-arm.build_image: Reboot is required, but do it manually**.
    azure-arm.build_image:
    azure-arm.build_image:
    azure-arm.build_image: Validating windows updates installation and skip Microsoft Defender Antivirus
    azure-arm.build_image: Windows updates failed to install: KB5001148
==> azure-arm.build_image: Provisioning step had errors: Running the cleanup provisioner, if present...
==> azure-arm.build_image:


Support /etc/vast/vast.conf as global config

The configuration file is now looked at in the following order:

Specified via --config=path/to/vast.conf
vast.conf in current working directory
${INSTALL_PREFIX}/etc/vast/vast.conf
/etc/vast/vast.conf

I have confirmed this to work in a Debian docker image.


encrypt.dll not found! What is this error?

It's all in the title. Happens right after login successful.

@ssm34 Learn to browse previous issue and troubleshoot yourself first before posting.
#138


Move docindex.yml from steps -> jobs

This PR:

Moves docindex.yml from the steps folder to the jobs folder because it is a collection of jobs, not templates
Prepares for extension of docindex.yml file with additional docs.ms automations

Doc index pipelines for all languages will need to be updated:

Put a pipeline yaml (docindex.yml) in eng/pipelines/ which uses the eng/common template yaml
Update the existing pipeline in DevOps to use the eng/pipelines/docindex.yml instead of the template

The following pipelines have been queued for testing:java - templatejava - template - testsjs - templatenet - templatenet - template - testspython - templatepython - template - tests You can sign off on the approval gate to test the release stage of each pipeline. See eng/common workflow


Remove usage of UIWebView in iOS core project, now WKWebView only

Xamarin.Auth Pull Request
Fixes #432
Checklist

[x] I have included examples or tests
[x] I have updated the change log
[ ] I am listed in the CONTRIBUTORS file
[ ] I have cleaned up the commit history (use rebase and squash)

Changes proposed in this pull request:

Remove UIWebView from Xamarin.iOS library project. Use WKWebView only

 Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.:x: trinnguyen sign nowYou have signed the CLA already but the status is still pending? Let us recheck it.


ParallaxImage can't load the image

<ParallaxImage
  source={require('../../../assets/test/courseTest.png')}
  containerStyle={styles.imageContainer}
  style={styles.image}
  parallaxFactor={0.4}
/>
const styles = StyleSheet.create({
  imageContainer: {
    flex: 1,
    marginBottom: Platform.select({ ios: 0, android: 1 }),
    backgroundColor: 'white',
    borderRadius: 8
  },
  image: {
    resizeMode: 'cover'
  }
})

I use the ParallaxImage component to load the image but the image can't be loaded normally and there is nothing but the spinner on my screen.
<Image
  source={require('../../../assets/test/courseTest.png')}
/>

However, if I use the Image component, the image can be loaded normally.
So what's the cause of this issue?

This problem has been solved. Because the ParalaxImage component should be the item of the  Carousel component, the image can be loaded normally.

@LostLord Indeed, the ParallaxImage component hasn't been created with a standalone usage in mind since you'll always need to link it to another component's scroll position anyway.


Todo/Refactor

Migrate on prettier to avoid difference code style.
Enable recommitted eslint rules avoid stylistics rules.
Upgrade https://github.com/evilebottnawi/favicons/tree/gh-pages and release on pages.
Run test on windows using appveyor.
Implement promise for generate.
Migrate from gulp to jest for testing.
ES6 refactor.

Wait feedback :+1:
//cc @brunocodutra

I'd recommend ava instead of jest.
I tried both in brunocodutra/webapp-webpack-plugin and for some reason ava is several times faster than jest.

I volunteer to improve the testing framework using ava if you agree this is the way to go

@brunocodutra ava fix snapshot testing? it will be great for snapshot image testing to avoid generate broken images?

@evilebottnawi yes it does snapshot testing much like jest
see https://github.com/avajs/ava#snapshot-testing
I'll start working something out and create a PR for us to better evaluate it

@brunocodutra great :+1:

@evilebottnawi regarding the ES6 refactor I was thinking, what about dropping support for node 4, which is reaching EOL this April, and sticking to node > 6 so that we may reasonably get rid of gulp and babel altogether?

@brunocodutra bit early, right now not april :smile:

Transpiling is not that big of a hassle, it's just that @jantimon convinced me it makes it harder for users that face issues to contribute fixes or even open better issue reports.
Either way we can decide about dropping node < 6 independently from the ES6 refactor.

@brunocodutra also i think we should use webpack or rollup for browser usage :+1:

@evilebottnawi sounds reasonable to me

@brunocodutra what do you think about buy domain favicons.xyz for future gh-pages, favicons.io better but very expensive :disappointed:

@evilebottnawi to be honest I think gh-pages are fine

@brunocodutra we will use gh-pages, github allow to add own domain on gh-pages

@evilebottnawi I know, I mean the github domain is fine, is there such a demand for the website to justify owning a domain?
BTW, how about adding a link to it to the project description?

@brunocodutra :+1:

@brunocodutra intresting, need investigate.
I near future i want move favicons to https://github.com/itgalaxy/, leaving you access to the repository.
No important PR is expected in the near future?

@evilebottnawi go ahead, I don't have anything right now

/cc @brunocodutra why we use @babel/polyfill as deps?

@brunocodutra i think we should drop node@4 :+1:


[Sharing NG] Creating invites with expiration date does not work

Describe the bug
Creating invites with expirationDateTime in the payload does not work.
Steps to reproduce

Create an invite including an expiration date (payload: {"roles":["b1e2218d-eef8-4d4c-b82d-0f1a1b48f3b5"],"expirationDateTime":"2024-02-29T23:59:59 0100","recipients":[{"objectId":"058bff95-6708-4fe5-91e4-9ea3d377588b","@libre.graph.recipient.type":"user"}]}:).

Expected behavior
The permission should be created with the given data.
Actual behavior
The server responds with invalid request body.

@JammingBen Are you sure this is a valid time format? Our JSON parser doesn't like that. Bascially we accept RFC3339 timestamps.
e.g. 2024-02-29T23:59:59+01:00 should work.

We have API test covered for sharing with expiration. Should be possible to share with expiration date
https://github.com/owncloud/ocis/blob/ef77055c09858cf2895aab6c9cce223b42d157c8/tests/acceptance/features/apiSharingNg/shareInvitations.feature#L571-L581

I don't think there's a bug here. So I am closing this. @JammingBen please re-open if you disagree.


test server

set test server online with mailing
https://github.com/nodejs/docker-node/blob/master/README.md#how-to-use-this-image
https://hub.docker.com/r/spittet/node-mysql/

created docker in 767bab9d63d70f401a1952e003e84a171c538f33

setup in raspberry pi
with https://hub.docker.com/r/francescou/docker-compose-ui/

installed on raspberry pi without docker (docker-compose's mysql container was not compatible with arm)


geo is not searchable

add mapping to gst

As I see it we have some options:

Have an internal list of the valid db options and check it upfront request

This can be created the first time the users uses the tool and use a cached version of it from that moment if hardcoding is not an option.
This will also allow the usage of a string metric algorithm for suggestions in case the db is not found.

Identify conflictive cases and create the specific mapping for them.

This is a simple and fast solution. But won't protect the user from misspells.

Do the request but if the following object is  returned bail out and notify the user:

{
  "header": {
    "type": "esearch",
    "version": "0.3"
  },
  "esearchresult": {
    "ERROR": "Invalid db name specified: dst"
  }
}

The check can be done here bionode-ncbi.js#L523 skipping the retry loop.
An internal list of valid dbs can be present for suggestions as in the first case

In my opinion the last option is the most suitable. @bmpvieira If you agree I'll create a pull request to solve it. Do you have any other idea?

I think we should go with the first option, check if db is valid and if not present list of valid ones (hardcoded in an internal config file in JSON or YAML format).
Here's one retrieved from the select box on NCBI website (not sure if all work with eutils/biondo-ncbi):
"gquery","All Databases"
"assembly","Assembly"
"bioproject","BioProject"
"biosample","BioSample"
"biosystems","BioSystems"
"books","Books"
"clinvar","ClinVar"
"clone","Clone"
"cdd","Conserved Domains"
"gap","dbGaP"
"dbvar","dbVar"
"nucest","EST"
"gene","Gene"
"genome","Genome"
"gds","GEO DataSets"
"geoprofiles","GEO Profiles"
"nucgss","GSS"
"gtr","GTR"
"homologene","HomoloGene"
"medgen","MedGen"
"mesh,"MeSH"
"ncbisearch","NCBI Web Site"
"nlmcatalog","NLM Catalog"
"nuccore","Nucleotide"
"omim","OMIM"
"pmc","PMC"
"popset","PopSet"
"probe","Probe"
"protein","Protein"
"proteinclusters","Protein Clusters"
"pcassay","PubChem BioAssay"
"pccompound","PubChem Compound"
"pcsubstance","PubChem Substance
"pubmed,"PubMed"
"pubmedhealth","PubMed Health"
"snp","SNP"
"sparcle","Sparcle"
"sra","SRA"
"structure","Structure"
"taxonomy","Taxonomy"
"toolkit","ToolKit"
"toolkitall","ToolKitAll"
"toolkitbook","ToolKitBook"
"toolkitbookgh","ToolKitBookgh"
"unigene","UniGene"

I'll put some time today into this.

I've kind of solved this at the CLI level by switching to yargs (https://github.com/bionode/bionode-ncbi/pull/32) but I think it would be nice to also have these kind of checks internally in the library. Maybe we could somehow reuse yargs choice definition.

Fixed by #33.  Thanks!


Go Templating (Hugo support)

Thank you creating this, I love it.
The only thing missing for me is syntax highlighting (and maybe code completion) for Go Templating.
In particular, the use case of creating templates for the blogging engine Hugo, https://gohugo.io/templates/introduction/
You have mentioned this as future consideration, and I'd love to add a +1 to get this prioritised. Similar templating extensions such as Liquid, create a new filetype to pick such as "HTML (Go)" that provides the correct syntax highlighting.

Unfortunately, I'm no longer using Nova in my daily work -- the editor got too crashy and I've moved on.  What that means is that it's probably not going to happen unless someone contributes an implementation.


Use real examples in API code examples

Please change
    "last_read_at":"last_read_at"

to
   "last_read_at":"2014-11-07T22:01:45Z"

They occur in
$ w3m -dump https://docs.github.com/en/free-pro-team@latest/rest/reference/activity | grep -n last_read_at.*:.*last_read_at
973:  -d '{"last_read_at":"last_read_at"}'
978:  last_read_at: 'last_read_at'
1524:  -d '{"last_read_at":"last_read_at"}'
1531:  last_read_at: 'last_read_at'

However they are not accessible from
https://github.com/github/docs/edit/main/content/rest/reference/activity.md
for me to edit. Nor does Search find what file they are in. Therefore
please make the edit for me. Thanks.

Thanks for opening an issue @jidanni! I believe that information is autogenerated 🤔 but I'll triage this for someone with more knowledge on our rest documentation 💛

👋 @jidanni.
Our API documentation is autogenerated from the API code, which is why you can't find it in the source in this docs repo.

Please change
    "last_read_at":"last_read_at"

I assume you're referring to the code examples? e.g here
These are also autogenerated and at the moment just have placeholder values. We do have plans to generate these with proper examples rather than the placeholders you see.
I'll rename this issue and tag in docs engineering too 🙂

I assume you're referring to...

Yes.
I don't see why impossible/non-working code sample are used, when directly below it real/working ones are used.

I don't see why impossible/non-working code sample are used, when directly below it real/working ones are used.

For integers in examples, it always uses 42 as the number in the code samples. For strings, our generator just defaults to just using the name of the parameter as the example string.
We have plans to improve this to use real examples generated from our schema, so stay tuned! 🙂

GET /repos/{owner}/{repo}/actions/artifacts

Nice

[ ] [ Duplicate of #](url)

moved this to docs engineering to prioritize

👋🏿  @jidanni we're working on this internally, so I'm going to close this issue up. Thanks so much for your passion about docs! We're aiming at having an improved API examples experience for you in the future!


pleroma-bot: init at 0.8.6

Motivation for this change
Things done

[ ] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
Built on platform(s)

[x] NixOS
[ ] macOS
[ ] other Linux distributions

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
[x] Tested execution of all binary files (usually in ./result/bin/)
[ ] Determined the impact on package closure size (by running nix path-info -S before and after)
[ ] Ensured that relevant documentation is up to date
[x] Fits CONTRIBUTING.md.

Result of nixpkgs-review pr 114670 at 312aec13 run on x86_64-linux 1

1 package built:

pleroma-bot

1 suggestion:

warning: python-explicit-check-phase
Consider using pytestCheckHook in checkInputs rather than checkPhase = "pytest";.
Near pkgs/development/python-modules/pleroma-bot/default.nix:24:3:
   |
24 |   checkPhase = "pytest";
   |   ^

Result of nixpkgs-review pr 114670 run on x86_64-linux 1

1 package built:

pleroma-bot

This is a semi-automatic executed nixpkgs-review with nixpkgs-review-checks extension. It is checked by a human on a best effort basis and does not build all packages (e.g. lumo, tensorflow or pytorch).
If you have any questions or problems please reach out to SuperSandro2000 on IRC.
Result of nixpkgs-review pr 114670 run on x86_64-linux 1

1 package failed to build and already failed to build on hydra master:

pleroma-bot: plain log  |  pretty log


chore: add error handler for signup

I tried the react-error-boundary package to handle all errors in the project, but it's more complex while dealing with async functions, and since they already run mutations and building onError functions for most of the actions, so I gave up and only deal with the errors happening during the signup.

[x] add isLoading state to useMaciSignup hook
[x] add onError function to onSignup function
[x] update related UI (mainly ConnectButton)

But still encounter an error like this right after signup:

This error does not affect the user to successfully signed up, but since it appears right after the user signed up successfully, the user might think they fail to sign up, also they need to refresh the page to see the signup button changed to other information (such as View Ballot).
The blocker I'm facing now is that each user/address could only successfully signed up once on the same contract.
I tried to fork the sepolia testnet to my localhost, and could not always signed up successfully, which really suspended my progress dealing with this problem.

confirmation is not a function error is happened because of different versions of ethers.

confirmation is not a function error is happened because of different versions of ethers.

oh but it still blocks the users from using the app fluently. How do you think we should solve this problem?

confirmation is not a function error is happened because of different versions of ethers.

oh but it still blocks the users from using the app fluently. How do you think we should solve this problem?

Have you checked it on main branch?

confirmation is not a function error is happened because of different versions of ethers.

oh but it still blocks the users from using the app fluently. How do you think we should solve this problem?

Have you checked it on main branch?

do you have a more efficient way to check it? since I can only see this error once I successfully signed up, but everyone could only signup once, so I don't know how to trigger this error again.
I tried on forking chain, but there are another problems happening.

You can use different accounts for signup or you can deploy your own maci instance and check it.

Inspect

but that would still need to have attestation on eas

Inspect

but that would still need to have attestation on eas

You can use your own schema, deployer account to do it.

why I mentioned the receipt.confirmation problem is because it happens every time (also on main branch before).
do you also encounter this problem?


Cache finding python3

Signed-off-by: Michael Carroll<EMAIL_ADDRESS>🦟 Bug fix
Summary
Repeated calls of IgnPython find python3 even if it has already been found, which inflates build time.
Checklist

[ ] Signed all commits for DCO
[ ] Added tests
[ ] Updated documentation (as needed)
[ ] Updated migration guide (as needed)
[ ] Consider updating Python bindings (if the library has them)
[ ] codecheck passed (See contributing)
[ ] All tests passed (See test coverage)
[ ] While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by messages.

need to resolve some conflicts

I don't know actually know if this makes sense, I'm going to re-evaluate this after feature freeze.


Anim not found

Version
latest
What browsers are you seeing the problem on?
Chrome, Microsoft Edge, Other
What happened?
So.. i'm recieving this error recently when  i added an animation to main character, it can be noticed that i have other animation in a portal (platformer kaboom game) and it works perfect, it only happen when entering to game, however in a couple of refreshes you can actually see that game works as expected
https://user-images.githubusercontent.com/68512719/192177072-5662f052-4e79-41f5-b7aa-37dc9fda9b2c.mp4
this is a video showing it, also i call loadsprite after scene
i though that is was the network, so i tired to test it in a corporative network, but there is the same error..
then i tried to move loadsprite after imports, but it does not work
i even change the server to a powerful one but it wasn't the server
i tried to call assets in same main file but it gives me other error...
i tried to get support on kaboom's server but all methods failed..
finally Danie told me to create an issue in github for review, Is it possible to developers to get a quick fix? i really need that this issue gets fixed
This is all, i attached a test server on replit in order to show the bug, as i said you need a couple of refreshes to let the game work.
Thanks
What's the expected behavior?
This should load game correctly without any errors regarding anims.
Minimum reproducable code
loadSprite("player", "/sprites/sheet.png", {

	sliceX: 9,

	anims: {
		"idle": {

			from: 0,
			to: 3,

			speed: 3,
			loop: true,
		},
		"run": {
			from: 4,
			to: 7,
			speed: 10,
			loop: true,
		},

		"jump": 8
	},
})
player.onGround(() => {
	if (!isKeyDown("left") && !isKeyDown("right")) {
		player.play("idle")
	} else {
		player.play("run")
	}
})

player.onAnimEnd("idle", () => {

})

onKeyPress("space", () => {
	if (player.isGrounded()) {
		player.jump(JUMP_FORCE)
    player.biggify(3)
		player.play("jump")
	}
})

	onKeyPress("up", () => {
	if (player.isGrounded()) {
		player.jump(JUMP_FORCE)
    player.biggify(4)
		player.play("jump")
	}
})

onKeyDown("left", () => {
	player.move(-MOVE_SPEED, 0)
	player.flipX(true)
  player.biggify(5)
	if (player.isGrounded() && player.curAnim() !== "run") {
		player.play("run")
	}
})

onKeyDown("right", () => {
	player.move(MOVE_SPEED, 0)
	player.flipX(false)
  player.biggify(5)
	if (player.isGrounded() && player.curAnim() !== "run") {
		player.play("run")
	}
})

onKeyRelease(["left", "right"], () => {
	if (player.isGrounded() && !isKeyDown("left") && !isKeyDown("right")) {
		player.play("idle")
	}
})

Live demo
https://pegesourcemain-3.luiscraftyt3.repl.co/jugar

Any answer?

Sorry I didn't understand the problem, the video doesn't seem to show an error, did you get the "Anim not found: (anim name)" error message?

Yes, it shows (anim error) and the anim, normally is a random anim, the issue was partially fixed, but in some cases you can see the error, i think that's why you didn't see any errors, try again


hard coded jenkins tree urls causing issues

In 1.0 version, treeapiurl and apiUrl were in HudsonSettings file but now they are hardcoded as CHANGE_SET_ITEMS_TREE and BUILD_DETAILS_TREE variables in DefaultHudsonClient class. Any particular reason this change was made? My Jenkins instance returns 500 error in getBuildDetails() because of timestamp field in change set.

can you please provide the stack trace and version of your Jenkins instance.

Jenkins version 1.611
HttpServerError 500 is reproducible with a standalone REST client GET request. Removing timestamp from the below URL fixes the issue for me.
http://server:port/job/jobName/jobNumber/api/json?tree=number,url,timestamp,duration,building,result,culprits[fullName],changeSet[items[user,author[fullName],revision,id,msg,timestamp,date,paths[file]],revisions[module,revision]]

@sthatip  we are unable to reproduce the issue. We tried with Jenkins ver. 2.19.2 and latest Hygieia code base. Please try the same and reopen if you still have issues.


⚠ SceneTime has degraded performance

In cbde567, SceneTime ($ST) experienced degraded performance:

HTTP code: 200
Response time: 6542 ms

Resolved: SceneTime performance has improved in d854778 after 6 minutes.


Fixes #166

The status of a subscription will change to completed during the CDR
processing when the last message has been successfully played (or not)

Hey @larubbio, waiting on your answer for this guy.

I haven't had a chance to look at this beyond that first event listener yet
(I was doing it in between compiles last night and didn't get that far on
it).
On Wed, May 13, 2015 at 8:02 AM, Frank Huster<EMAIL_ADDRESS>wrote:

Hey @larubbio https://github.com/larubbio, waiting on your answer for
this guy.
—
Reply to this email directly or view it on GitHub
https://github.com/motech-implementations/mim/pull/243#issuecomment-101705399
.


Added gltf_viewer sample code

Added gltf_viewer, including:

Update of Assimp library
Addition of double-sided and single-sided gltf materials
Support for binary gltf files

It's okay for a PR to have a lot of commits, but in this case I think some of the gltf-specific commits could probably be squashed.
At a high level, I can imagine dividing this work into three chunks: updating the assimp library, enhancing the meshassimp bridge, and adding a new sample app.  I'd expect each of these three chunks to be composed of only 1 or 2 commits.

When I compile your PR I get a lot of warnings:
../../samples/app/MeshAssimp.cpp:678:130: warning: ISO C++11 does not allow conversion from string literal to 'char *' [-Wwritable-strings]
                            setTextureFromPath(scene, &mEngine, mTextures, AOPath, materialName, dirName, outMaterials, mapMode, "aoMap");

If I run gltf_viewer without passing a path to a glTF file it just hangs without starting a window (--help doesn't show anything either).


chore(release): Bump versions for v0.11.0-SNAPSHOT

Description:
Bump versions for v0.11.0-SNAPSHOT
Automated snapshot version bump for the next development cycle.
Related issue(s):

closed as this is an experiment


"Colți", "Aluniș", "Colții de Jos" and "Muscelu Cărămănești" are listed in the drop-down menu

Description:
"Colți", "Aluniș", "Colții de Jos" and "Muscelu Cărămănești" are listed in the drop-down menu alongside its corresponding county and commune, according to the law
Precondition:
The website is up an running.

Step 1
Type "Colți" in the search bar.

Expected results
The location is listed in the drop-down menu as "Colți, Buzău(Colți)".

Step 2
Press "x" button.

Expected results
The location was deleted from the search bar.

Step 3
Type "Aluniș" in the search bar.

Expected results
The location is listed in the drop-down menu as "Aluniș, Buzău(Colți)".

Step 5
Type "Colții de Jos" in the search bar.

Expected results
The location is listed in the drop-down menu as "Colții de Jos, Buzău(Colți)".

Step 6
Press "x" button.

Expected results
The location was deleted from the search bar.

Step 7
Type "Muscelu Cărămănești" in the search bar.

Expected results
The location is listed in the drop-down menu as "Muscelu Cărămănești, Buzău(Colți)".


Allow deployment of AWS Perspectives resources into your own (existing) VPC

Feature name
Give your feature a name.
Is your feature request related to a problem? Please describe.
A description of what the problem is.
Describe the feature you'd like to see implemented
A description of what you would like to see.
Describe the value this feature will add to AWS Perspective
Tell us how this feature might improve AWS Perspective.
Describe alternatives you've considered
A description of any alternative solutions or features you've considered.
Additional context
Add any context or screenshots about the feature request here.

@svozza any update on when this could be expected? Or is there information somewhere on how to use our own VPCs by editing the .yaml files?


Refactor - Unused logic

If there is a target break in a for loop, you want that to be the first case so you don't have to waste any lines.

LGTM

Hello! I'm all for other people who care about this code base and are willing to put the time and energy to contribute things to it having access to it. I've added you both as collaborators on this, and @wenkesj I also gave you npm publish rights.
Ship it :) just follow semver, anytime you publish, please. http://semver.org/


bump alertmanager to v0.27.0 to support new receivers

The new MSTeamsConfig receiver added in https://github.com/VictoriaMetrics/operator/issues/808 is valid since alertmanager v0.26.0, so need to bump the default version.

Thanks for contribution!


Watching a lot of domains can cause program to crash after some time

This comes up for me when I run prefmanager watch --all. After some amount of time the program exits with the following messages:
prefmanager: /bin/sh: startProcess: runInteractiveProcess: pipe: resource exhausted (Too many open files)

Mostly address by: ce89169795f4355acde6d3f468ce9173add52b59


Support Paket as an alternative package manager for #tool and #addin

Now that we have #616, I'd like to have support for using Paket rather than NuGet for #tool and #addin.
There are a few advantages for us (my organization), in being able to use Paket:
Since we are all on OS X, and there is no Homebrew package for nuget (and the official Mono distribution ships an ancient version that doesn't work with our MyGet feed), we opt to use Paket across the board.
We have some addins stored in private MyGet feeds, which requires us either to commit credentials to our repos by encoding them into the #addin directives or to force each dev to alter their NuGet.Config to pull from MyGet. Requiring NuGet just for configuring Cake's package sources is a little much, and storing an ad-hoc tools/NuGet.exe feels weird and adds complexity to setting up a new repo.
Paket allows you to configure package sources in a file that can be checked into the repo, and can rely on env vars to provide credentials to those sources so you don't have to commit credentials along with the source configuration.
It may make sense to use Paket's "groups" feature here.

@kibiz0r There is currently no plans for adding Paket as a provider for #addin or #tool. Since Paket relies on external files in repository such as packet.lock, paket.references and packet.dependencies, I see little benefit from trying to synchronize this with the script code. I think the best solution here would be to fetch packages via Paket from your Cake bootstrapper script.
We could however add support for adding templating support for the #addin and #tool directives that could get values from environment variables or arguments.
// A proposition for how this could work.
#addin "nuget:https://{user}:{password}@myget.com/f/Owner/?package=Foo.Bar"

I think the best solution here would be to fetch packages via Paket from your Cake bootstrapper script.

How would that work? It seems like a chicken-and-egg problem, but I might be missing something crucial here...

See https://github.com/cake-build/cake/blob/develop/build.ps1
Essential, use the cake bootstrap to download paket and run it against a seperatetly defined .dependencies file, and then reference anything cake needs to good old fashion way.

So, wrap Cake? Idk about that... We're using Cake via Homebrew right now, and this was in an effort to reduce the number of components involved in our project automation setup, so I'm inclined to leave Homebrew in control of cake.

@kibiz0r Yes. Having a bootstrapper script responsible for getting Cake (and dependencies not retrievable via the #addin/#tool directive) for you will ensure that the build experience will look the same regardless of if you're building locally on your own computer or running the build on a CI server.
If you want to use something like Paket, I think the best way would be to bootstrap the build process via a shell script that downloads things that you need. You could even do that to ensure that Cake is installed via homebrew if it for some reason would be missing (perhaps a new colleague that's unaware of how your build works).

@kibiz0r
In case you are still interested, I have an example project Example Cake Build Using Paket that uses Cake and paket. As mentioned in the previous threads, the trick was to modify the bootstrapper.

@gep13 This seems to have a solution, is this something you want to keep open?

@gep13 @phillipsj Yes, I think this one can be closed. Since paket relies on paket.dependencies, there is little reason to write a provider for individual packages. Unless I've missed something that is.

@patriksvensson @phillipsj if this were going to be done, I think it would be best implemented in a Cake.Paket.Module, but that would be external to Cake core.  The infrastructure is all there in Cake to allow the implementation of this, it would just need to be created.  Ideally, this would be created as a repo in the cake-contrib organisation.


test: Remove maxInstances from capabilities in wdio.conf.js and skip copied content checking on Edge

The maxInstances in different capability will inherit from up level if it is not configured.
Sometimes the Control-v does not work on Edge browser, and there's not a better way to check the copied content. Checking stage in the test will be passed on Edge but still keep clicking copy button part

Thanks @martinpitt! Update.

Codecov Report

Merging #694 into master will decrease coverage by 0.15%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master     #694      +/-   ##
==========================================
- Coverage    75.6%   75.45%   -0.16%
==========================================
  Files          66       66
  Lines        3324     3324
  Branches      684      684
==========================================
- Hits         2513     2508       -5
- Misses        811      816       +5

Impacted Files
Coverage Δ

components/Form/Password.js
85.71% <0%> (-2.39%)
:arrow_down:

core/sagas/inputs.js
71.42% <0%> (-1.03%)
:arrow_down:

core/selectors.js
92.96% <0%> (-0.79%)
:arrow_down:

core/sagas/blueprints.js
73.57% <0%> (-0.52%)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ee8f3d4...ef66225. Read the comment docs.

@martinpitt, I found copy and paste test failed in this PR. It's a good PR to debug this flaky issue. Could you please leave this PR not merged until flaky issue got fixed? Thanks!

@martinpitt, I just bypass the paste and content checking part on edge. Could you please review this PR if you have time? Thanks!


Parsing error when running tih.py

Following parsing error was seen while running the script
Checking Nothink.org SSH bruteforce IPs
Checking Dragon Research Group VNC probe IP feed
Traceback (most recent call last):
  File "/Threat-Intelligence-Hunter-master/tih.py", line 29, in <module>
Checking CI Army IP feed
    main()
  File "/Threat-Intelligence-Hunter-master/tih.py", line 22, in main
    ip_ioc = parse_ip(args.ip)
  File "\Threat-Intelligence-Hunter-master\bin\parse.py", line 45, in parse_ip
    for line in r:
TypeError: 'NoneType' object is not iterable

Possible issue with CI Army IP feed

54a49bb fixes the issue.


Update performance-guidelines-best-practices-checklist.md

Added that the temporary storage (ephemeral) disk is default to D:\ as some customers change this.

@PhilB-MSFT : Thanks for your contribution! The author(s) have been notified to review your proposed change.


Resolve rowDescription issue caused by parsing based on future protocol

There were issues with parsing rowDescription messages. We were trying to parse a field for the attribute number of the parent type for complex types. That doesn't apply here and shouldn't be parsed. In addition I added more information that was being parsed in the RowDescriptionMessage to the Field type.

This was superseded by Jonathan's PR#27.   This PR will not be merged.


client reference / standard

Branching off from the sharding discussion https://github.com/sigstore/rekor/issues/806 , we considered that clients could perhaps benefit from a retry handler in event of system outage. There was proposal made that we could benefit from a general client guideline / standard. This would not be concerned with the specifics of the client itself, more on how clients would best be suited to interact with sigstore services (rekor, odic, fulcio).

This is being tracked now as part of https://github.com/sigstore/architecture-docs


Added proper tagging for project portfolio

Coverage remained the same at 47.453% when pulling 519336f1c78b65036571af701f41e7ba88c1b0d1 on kianhong95:master into 7f186241fa21aa5943be7a648caae4398caf5d28 on CS2113-AY1819S1-F09-2:master.


feat: [CDS-98106]: Add info that When an environment is added to a Custom Stage, resource constraints do apply, and jobs may get queued based on the environment and infrastructure combination.

Thanks for contributing to the Harness Developer Hub! Our code owners will review your submission.
Description

Please describe your changes: __________________________________
Jira/GitHub Issue numbers (if any): ______________________________
Preview links/images (Internal contributors only): __________________

PR lifecycle
We aim to merge PRs within one week or less, but delays happen sometimes.
If your PR is open longer than two weeks without any human activity, please tag a code owner in a comment.
PRs must meet these requirements to be merged:

[ ] Successful preview build.
[ ] Code owner review.
[ ] No merge conflicts.
[ ] Release notes/new features docs: Feature/version released to at least one prod environment.

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

Please check the Execution Link of the Pipeline for the Website Draft URL. This is located in the Preview Step behind the Harness VPN and also is available in #hdh_alerts. E.g Website Draft URL: https://unique-id--harness-developer.netlify.app. Current Draft URL is: https://66b628bb253e3900a5f4a79a--harness-developer.netlify.app