Transition between routes

Is there a way to use this with react-router to transition between components?
e.g. implement a page transition like http://www.semplicelabs.com/ with additional stagger on the menu items?

Something like this? https://gist.github.com/maisano/8faf4bd123fa9842f4ea

I'm afraid i don't know how to use that.
Tried using it as a parent route component in<EMAIL_ADDRESS>didn't work too well.

@maisano care to help a bit here please?

@gonsfx http://in-flux.github.io/component-router/example ?

oof, i should really add some usage docs to that gist.
@gonsfx the RouteTransition component was written not to be a route component, but a wrapper for rendering children. e.g.:
// in your base route component:
render() {
  return (

      {/** ... **/}
      <RouteTransition pathname={this.props.location.pathname}>
        {this.props.children}
      </RouteTransition>

  );
}

Does that mean all children will animate in the same way? (can't have one child come in from the bottom, another from the right)

in this implementation of <RouteTransition>, all children being added will animate the same. the same goes for children being removed. however, it would be pretty simple to do some path comparisons and pull from a series of preset transition values. you could also pass in the history action for a particular transition.

@chenglou Thanks for pointing me in the right direction
@maisano Thanks for your clarification - that works okay-ish but is a good starting point for further inquiry.
Followup questions:

On initial load of the app, the component shown first is not transitioned in. How can i achieve that?
The RouteTransition only transitions the immediate child - what if i'd like to transition multiple child elements in varying dom hierarchy depths differently - such as fading the body whilst transitioning margin-top on the header, margin-bottom on the footer and staggering transitions on the menu inside the header?

Would we able to see an example using the new api? Struggling to get my head around the changes!

@boyswan not too familiar with the router. I'll defer to @maisano for this one

@boyswan by new api i'm assuming you meant the new react-motion api. i just updated the gist to reflect those changes, though i haven't tested it. conceptually it's largely the same, though a prop's name changed and you no longer need to access the .val key from the interpolated values.

Perfect, thanks for this!

@maisano I seem to be having the same issue as@gonsfx where the initial route does not load...

@mattapperson the initial route doesn't load or doesn't transition? if it's the latter, i think you can get that by adding defaultStyles.

@maisano it was an issue with my styles. the absolute included in this component broke stuff

@mattapperson :+1: yea, that component is more of a demo than anything else.

Would the implementation change dramatically if @chenglou's example was modified to make the transition be a horizontal sliding animation instead of a fading one?

Hi @rclai,
Just replace the scale by translateY: transform: translate(${interpolated[key].x}%).
And replace scale in both willEnter and willLeave methods by respectively x: spring(-100) and x: spring(100).
That should work.

Perhaps I'm missing something, but I'm having an issue with repeating willEnter and willLeave animations for routes. I'm assuming that because  is retaining the keys of each route, when you visit pages the second time, the willLeave animation hook fires on willEnter. Any guidance on this would be greatly appreciated, thank you! I think this library is fantastic but this is probably the one issue keeping me from implementing it on a project.
const routerStyles = props => {
  const { pathKey, children } = props;

  return {
    [pathKey]: {
      opacity: spring(1),
      tY: spring(0),
      postion: 'relative',
      top: spring(0),
      children,
    },
  };
};

const routeWillEnter = (_, { children }) => {
  return {
    opacity: spring(0),
    tY: spring(50),
    position: 'absolute',
    top: 0,
    children,
  };
};

const routeWillLeave = (_, { children }) => {
  return {
    opacity: spring(0),
    tY: spring(-50),
    position: 'absolute',
    top: 0,
    children,
  };
};

And in my render method:
render() {
    const { location, ...props } = this.props;
    const pathKey = this.props.location.pathname.replace(/^\//, '')
      .split('/').shift();
    const children = React.cloneElement(props.children, {
      key: pathKey,
    });

    return (
          {/* ... */}
          <TransitionMotion
            styles={routerStyles({ children, pathKey })}
            willEnter={routeWillEnter}
            willLeave={routeWillLeave}
            className={styles.transitionGroup}
          >
            {interpolatedStyles => {
              return (

                  {Object.keys(interpolatedStyles).map(key => {
                    const {
                      children: router,
                      opacity,
                      position,
                      tY,
                    } = interpolatedStyles[key];

                    const transform = `translate3d(0, ${tY}px, 0)`;

                    return (

                        {router}

                    );
                  })}

              );
            }}
          </TransitionMotion>
          {/* ... */}
    );

@cdebotton it's hard to tell what's wrong from this–what's the usage look like?

@maisano, sure, the implementation looks like this:
  render(): any {
    const { location, ...props } = this.props;
    const pathKey = this.props.location.pathname.replace(/^\//, '')
      .split('/').shift();

    return (

 this._container = c}
          style={{
            backgroundColor: this.props.backgroundColor,
            color: this.props.foregroundColor,
          }}
          className={styles.container}
        >

          <RouterTransition pathKey={pathKey}>
            {this.props.children}
          </RouterTransition>

    );

Sorry for so many posts, but I've at least solved for when the problem happens. If I am transitioning between routes, and then click into another route, the leave animation doesn't fire on the route that is already on the DOM. I believe that this is because the key has not been removed yet from the styles configuration object.
I know that I could add a counter, or a constantly changing key to the key, but that feels hacky to me.

i'm still a little unclear on what the problem you're having is, but based on animations repeating, i would guess it's because you're potentially clobbering the pathKey for multiple routes (e.g. you're passing in the same pathKey for matches at "/foo/bar" and "/foo/baz"). why split on slash and return the first element instead of the entire pathname?

How to get this to work with 0.4.* ? TransitionMotion's api changed and I cannot get this example to work anymore :(

@threepointone we should have one, authoritative answer on how to make RR work with RM. I myself haven't used RR so I can't answer. But this is a recurring question.

yes, we should have an example (indeed, we should also prep an example for their incoming v2 release). I'll start hacking on this today.

This implementation uses 0.4.2 and is used as a wrapper component which takes – amongst other things – Route components.
This is just a simple example, and fades a single component in from 0.75 opacity.
Hope this helps someone.
import React from 'react';

import Pure from 'mixins/Pure';
import { TransitionMotion, spring } from 'react-motion';

const SpringModel = { stiffness: 250, damping: 25, precision: 1 };

const XYZTransitionContainer = React.createClass({
  mixins: [Pure],
  propTypes: {
    id: React.PropTypes.string.isRequired,
    height: React.PropTypes.number.isRequired
  },
  willEnter() {
    return { opacity: 0.75 };
  },
  willLeave() {
    return { opacity: spring(1, SpringModel) };
  },
  getStyles() {
    const { id, children } = this.props;
    return [{
      key: id,
      style: { opacity: spring(1, SpringModel) },
      data: { children }
    }];
  },
  render() {
    const { height } = this.props;
    return (
      <TransitionMotion
        styles={ this.getStyles }
        willEnter={ this.willEnter }
        willLeave={ this.willLeave }>
        { values =>

            { values.map(({ key, style, data }) =>

               { data.children }

            )}

        }
      </TransitionMotion>
    );
  }
});

export default XYZTransitionContainer;

FYI, the newest example in the Wiki Gallery is a RM wrapper for RR.

@andrewgleave - thanks for this! I started doing something like this (except I used a slide transition) and it worked. After maisano released his wrapper I ended up changing to that because it is nicely abstracted
@maisano- Great wrapper!!! I only ran into one issue/improvement which I posted in your repo
Fade in/out:
Unfortunately this is one effect that doesn't look right. I have tried different stiffness/damping settings but when you transition it either moves so quick you don't notice the fade or one page starts to show through the other since it's opacity hasn't set zero yet. Ideally we would want the current route to fade out and once that is complete the new route fade in. I suspect you would need an animation end event to do this (which I believe isn't available yet)? Maybe there is another way to achieve this?
@chenglou - Obviously incredible library but thanks for helping lead us to solutions on how to integrate with major third party components! Your demos are very cool but being able to use react-motion with react-router for example is a big deal. Developers finally have a well designed library to integrate advanced animations in real world apps :)
Expanding upon this concept further doing the following with react-motion would be awesome!
https://www.google.com/design/spec/animation/meaningful-transitions.html
Although maybe this belongs in react-motion-ui-pack :)

Just to note (noted it on the gist a couple of months back): this uses absolute positioning to work. If you don't have the routeTransition around the footer, it won't look correct visually as whatever you wrap the RouteTransition around will go below your footer.

Is there some way to avoid position:absolute ? Maybe we would be able to use some callback to fire when leaving finishes and run enter transition right after that?

It's possible to make this work without position:absolute, but it not so reliable solution yet.
Maybe it will be usefull.
https://github.com/chenglou/react-motion/issues/419

Anthony Chang loves you guys


Is there any plan to support compose web (wasm) in near future?

Yes, we should be able to support WASM without any issues.
I'm waiting for this library to add support for WASM: https://github.com/JetBrains/markdown/issues/140
Which is used for parsing markdown.


Choose field name for select option label on relationships

When specifying a foreign key relationship, it would be helpful to also be able to specify the label field. E.g. in an employees collection with a firstName field, the select value would be _id while the select label would be firstName.
The code would auto-generate a select widget using the value and label settings, as in the Meteoris CRUDSS example video.

The field name might be selected via a drop down menu showing existing field labels. I.e. the end-user creating the CRUDSS would see field labels in the select option, while the value would be the actual field name in the collection.

Having a select widget would smooth the process of creating relationships, as it is relatively easy to make a mistake.


[Hotfix] Allow forcing additional file ops [#OSF-8182]

Purpose
Extend force_archive functionality
Changes

Allow/revert addon_file_moved and addon_file_renamed for OSFS
Improved logging

Side effects
Script takes slightly longer to run
Ticket
[OSF-8182]

I tried force-archiving a registration that had an addon_file_move log. The script exited without errors, but the file that should have been archived didn't get archived. I'll send details on FD.


task1

@PerteGeorge this is your task now, please go ahead. Deadline (when this ticket should be closed) is 2020-12-27T19:44:41.763118.
Estimation here is 100 minutes, that's how much you will be paid.
Remember, you don't have to solve everything in this ticket - you can solve it partially and leave todo markers in the code, which will become future tasks.
If you have any questions don't ask me, I'm not a technical person. Open new tickets instead.
If you don't have time or simply don't want to work on this, you can always resign.

@PerteGeorge please keep in mind that manual assignment of tickets is a bad practice and it is discouraged. Next time, please let me elect the assignee.

@PerteGeorge thank you for resolving this ticket. I've just added it to your active invoice. You can always check all your invoices and more on the Contributor Dashboard.


ci: run Fossa once per weekday

References https://github.com/lightbend/kalix/issues/7448

Hi @ennru,
Thank you for your contribution! We really value the time you've taken to put this together.
We see that you have signed the Lightbend Contributors License Agreement before, however, the CLA has changed since you last signed it.
Please review the new CLA and sign it before we proceed with reviewing this pull request:
https://www.lightbend.com/contribute/cla


If you are using the git profile, you need to set a Git URI in your configuration.  If you are using a native profile and have spring.cloud.config.server.bootstrap=true, you need to use a composite configuration.

I am trying to use S3 as backend for config server. Below is my bootstarp.yml looks like
spring:
  profiles:
    active: awss3
  cloud:
    config:
      profile: test
      label: sample-config
      server:
        awss3:
          region: us-east-1
          bucket: srikanth-sg-demo-config-server
        bootstrap: true

Here is the stack trace when I run my spring boot application
2020-06-02 14:47:44.050  INFO 15056 --- [           main] trationDelegate$BeanPostProcessorChecker : Bean 'org.springframework.cloud.autoconfigure.ConfigurationPropertiesRebinderAutoConfiguration' of type [org.springframework.cloud.autoconfigure.ConfigurationPropertiesRebinderAutoConfiguration] is not eligible for getting processed by all BeanPostProcessors (for example: not eligible for auto-proxying)

  .   ____          _            __ _ _
 /\\ / ___'_ __ _ _(_)_ __  __ _ \ \ \ \
( ( )\___ | '_ | '_| | '_ \/ _` | \ \ \ \
 \\/  ___)| |_)| | | | | || (_| |  ) ) ) )
  '  |____| .__|_| |_|_| |_\__, | / / / /
 =========|_|==============|___/=/_/_/_/
 :: Spring Boot ::        (v2.3.0.RELEASE)

2020-06-02 14:47:46.054  INFO 15056 --- [           main] b.c.PropertySourceBootstrapConfiguration : Located property source: CompositePropertySource {name='configService', propertySources=[MapPropertySource {name='application'}]}
2020-06-02 14:47:46.059  INFO 15056 --- [           main] c.s.java.ConfigserverdemoApplication     : The following profiles are active: awss3
2020-06-02 14:47:47.035  INFO 15056 --- [           main] o.s.cloud.context.scope.GenericScope     : BeanFactory id=7dab5c52-d735-3ddb-a753-639686d963c9
2020-06-02 14:47:47.131  INFO 15056 --- [           main] trationDelegate$BeanPostProcessorChecker : Bean 'org.springframework.cloud.autoconfigure.ConfigurationPropertiesRebinderAutoConfiguration' of type [org.springframework.cloud.autoconfigure.ConfigurationPropertiesRebinderAutoConfiguration] is not eligible for getting processed by all BeanPostProcessors (for example: not eligible for auto-proxying)
2020-06-02 14:47:47.401  INFO 15056 --- [           main] o.s.b.w.embedded.tomcat.TomcatWebServer  : Tomcat initialized with port(s): 7788 (http)
2020-06-02 14:47:47.418  INFO 15056 --- [           main] o.apache.catalina.core.StandardService   : Starting service [Tomcat]
2020-06-02 14:47:47.418  INFO 15056 --- [           main] org.apache.catalina.core.StandardEngine  : Starting Servlet engine: [Apache Tomcat/9.0.35]
2020-06-02 14:47:47.541  INFO 15056 --- [           main] o.a.c.c.C.[Tomcat].[localhost].[/]       : Initializing Spring embedded WebApplicationContext
2020-06-02 14:47:47.541  INFO 15056 --- [           main] o.s.web.context.ContextLoader            : Root WebApplicationContext: initialization completed in 1466 ms
2020-06-02 14:47:47.901  INFO 15056 --- [           main] o.s.s.concurrent.ThreadPoolTaskExecutor  : Initializing ExecutorService 'applicationTaskExecutor'
2020-06-02 14:47:48.181  WARN 15056 --- [           main] ConfigServletWebServerApplicationContext : Exception encountered during context initialization - cancelling refresh attempt: org.springframework.beans.factory.UnsatisfiedDependencyException: Error creating bean with name 'healthIndicatorRegistry' defined in class path resource [org/springframework/boot/actuate/autoconfigure/health/LegacyHealthEndpointCompatibilityConfiguration.class]: Unsatisfied dependency expressed through method 'healthIndicatorRegistry' parameter 0; nested exception is org.springframework.beans.factory.BeanCreationException: Error creating bean with name 'healthContributorRegistry' defined in class path resource [org/springframework/boot/actuate/autoconfigure/health/HealthEndpointConfiguration.class]: Bean instantiation via factory method failed; nested exception is org.springframework.beans.BeanInstantiationException: Failed to instantiate [org.springframework.boot.actuate.health.HealthContributorRegistry]: Factory method 'healthContributorRegistry' threw exception; nested exception is org.springframework.beans.factory.UnsatisfiedDependencyException: Error creating bean with name 'configServerHealthIndicator' defined in class path resource [org/springframework/cloud/config/server/config/EnvironmentRepositoryConfiguration.class]: Unsatisfied dependency expressed through method 'configServerHealthIndicator' parameter 0; nested exception is org.springframework.beans.factory.UnsatisfiedDependencyException: Error creating bean with name 'org.springframework.cloud.config.server.config.CompositeConfiguration': Unsatisfied dependency expressed through method 'setEnvironmentRepos' parameter 0; nested exception is org.springframework.beans.factory.BeanCreationException: Error creating bean with name 'defaultEnvironmentRepository' defined in class path resource [org/springframework/cloud/config/server/config/DefaultRepositoryConfiguration.class]: Invocation of init method failed; nested exception is java.lang.IllegalStateException: You need to configure a uri for the git repository.
2020-06-02 14:47:48.182  INFO 15056 --- [           main] o.s.s.concurrent.ThreadPoolTaskExecutor  : Shutting down ExecutorService 'applicationTaskExecutor'
2020-06-02 14:47:48.185  INFO 15056 --- [           main] o.apache.catalina.core.StandardService   : Stopping service [Tomcat]
2020-06-02 14:47:48.207  INFO 15056 --- [           main] ConditionEvaluationReportLoggingListener :

Error starting ApplicationContext. To display the conditions report re-run your application with 'debug' enabled.
2020-06-02 14:47:48.210 ERROR 15056 --- [           main] o.s.b.d.LoggingFailureAnalysisReporter   :

***************************
APPLICATION FAILED TO START
***************************

Description:

Invalid config server configuration.

Action:

If you are using the git profile, you need to set a Git URI in your configuration.  If you are using a native profile and have spring.cloud.config.server.bootstrap=true, you need to use a composite configuration.

you need to use composite profile and configuration with bootstrap just like the action says
https://cloud.spring.io/spring-cloud-static/spring-cloud-config/2.2.0.RELEASE/reference/html/#composite-environment-repositories

Changed my bootstrap.yml to below composite config
spring:
  profiles:
    active: composite
  cloud:
    config:
      server:
        profile: test
        label: sample-config
        composite:
        - type: awss3
          search-locations: s3://srikanth-sg-demo-config-server/sample-config
      bootstrap: true

And got these exceptions and here is the stack trace
2020-06-02 15:30:46.334  INFO 16192 --- [           main] trationDelegate$BeanPostProcessorChecker : Bean 'org.springframework.cloud.autoconfigure.ConfigurationPropertiesRebinderAutoConfiguration' of type [org.springframework.cloud.autoconfigure.ConfigurationPropertiesRebinderAutoConfiguration] is not eligible for getting processed by all BeanPostProcessors (for example: not eligible for auto-proxying)

  .   ____          _            __ _ _
 /\\ / ___'_ __ _ _(_)_ __  __ _ \ \ \ \
( ( )\___ | '_ | '_| | '_ \/ _` | \ \ \ \
 \\/  ___)| |_)| | | | | || (_| |  ) ) ) )
  '  |____| .__|_| |_|_| |_\__, | / / / /
 =========|_|==============|___/=/_/_/_/
 :: Spring Boot ::        (v2.3.0.RELEASE)

2020-06-02 15:30:46.849  INFO 16192 --- [           main] c.s.java.ConfigserverdemoApplication     : The following profiles are active: composite
2020-06-02 15:30:47.869 ERROR 16192 --- [           main] o.s.boot.SpringApplication               : Application run failed

java.lang.IllegalStateException: Error processing condition on org.springframework.cloud.config.server.config.CompositeRepositoryConfiguration.searchPathCompositeEnvironmentRepository
	at org.springframework.boot.autoconfigure.condition.SpringBootCondition.matches(SpringBootCondition.java:60) ~[spring-boot-autoconfigure-2.3.0.RELEASE.jar:2.3.0.RELEASE]
	at org.springframework.context.annotation.ConditionEvaluator.shouldSkip(ConditionEvaluator.java:108) ~[spring-context-5.2.6.RELEASE.jar:5.2.6.RELEASE]
	at org.springframework.context.annotation.ConfigurationClassBeanDefinitionReader.loadBeanDefinitionsForBeanMethod(ConfigurationClassBeanDefinitionReader.java:184) ~[spring-context-5.2.6.RELEASE.jar:5.2.6.RELEASE]
	at org.springframework.context.annotation.ConfigurationClassBeanDefinitionReader.loadBeanDefinitionsForConfigurationClass(ConfigurationClassBeanDefinitionReader.java:144) ~[spring-context-5.2.6.RELEASE.jar:5.2.6.RELEASE]
	at org.springframework.context.annotation.ConfigurationClassBeanDefinitionReader.loadBeanDefinitions(ConfigurationClassBeanDefinitionReader.java:120) ~[spring-context-5.2.6.RELEASE.jar:5.2.6.RELEASE]
	at org.springframework.context.annotation.ConfigurationClassPostProcessor.processConfigBeanDefinitions(ConfigurationClassPostProcessor.java:331) ~[spring-context-5.2.6.RELEASE.jar:5.2.6.RELEASE]
	at org.springframework.context.annotation.ConfigurationClassPostProcessor.postProcessBeanDefinitionRegistry(ConfigurationClassPostProcessor.java:236) ~[spring-context-5.2.6.RELEASE.jar:5.2.6.RELEASE]
	at org.springframework.context.support.PostProcessorRegistrationDelegate.invokeBeanDefinitionRegistryPostProcessors(PostProcessorRegistrationDelegate.java:280) ~[spring-context-5.2.6.RELEASE.jar:5.2.6.RELEASE]
	at org.springframework.context.support.PostProcessorRegistrationDelegate.invokeBeanFactoryPostProcessors(PostProcessorRegistrationDelegate.java:96) ~[spring-context-5.2.6.RELEASE.jar:5.2.6.RELEASE]
	at org.springframework.context.support.AbstractApplicationContext.invokeBeanFactoryPostProcessors(AbstractApplicationContext.java:706) ~[spring-context-5.2.6.RELEASE.jar:5.2.6.RELEASE]
	at org.springframework.context.support.AbstractApplicationContext.refresh(AbstractApplicationContext.java:532) ~[spring-context-5.2.6.RELEASE.jar:5.2.6.RELEASE]
	at org.springframework.boot.web.servlet.context.ServletWebServerApplicationContext.refresh(ServletWebServerApplicationContext.java:143) ~[spring-boot-2.3.0.RELEASE.jar:2.3.0.RELEASE]
	at org.springframework.boot.SpringApplication.refresh(SpringApplication.java:758) [spring-boot-2.3.0.RELEASE.jar:2.3.0.RELEASE]
	at org.springframework.boot.SpringApplication.refresh(SpringApplication.java:750) [spring-boot-2.3.0.RELEASE.jar:2.3.0.RELEASE]
	at org.springframework.boot.SpringApplication.refreshContext(SpringApplication.java:397) [spring-boot-2.3.0.RELEASE.jar:2.3.0.RELEASE]
	at org.springframework.boot.SpringApplication.run(SpringApplication.java:315) [spring-boot-2.3.0.RELEASE.jar:2.3.0.RELEASE]
	at org.springframework.boot.SpringApplication.run(SpringApplication.java:1237) [spring-boot-2.3.0.RELEASE.jar:2.3.0.RELEASE]
	at org.springframework.boot.SpringApplication.run(SpringApplication.java:1226) [spring-boot-2.3.0.RELEASE.jar:2.3.0.RELEASE]
	at com.srikanth.java.ConfigserverdemoApplication.main(ConfigserverdemoApplication.java:12) [classes/:na]
Caused by: java.lang.NullPointerException: null
	at java.util.concurrent.ConcurrentHashMap.get(Unknown Source) ~[na:1.8.0_151]
	at org.springframework.beans.factory.support.DefaultListableBeanFactory.getBeanDefinition(DefaultListableBeanFactory.java:809) ~[spring-beans-5.2.6.RELEASE.jar:5.2.6.RELEASE]
	at org.springframework.cloud.config.server.composite.CompositeUtils.getEnvironmentRepositoryFactoryTypeParams(CompositeUtils.java:82) ~[spring-cloud-config-server-2.2.0.RELEASE.jar:2.2.0.RELEASE]
	at org.springframework.cloud.config.server.composite.OnSearchPathLocatorPresent.getMatchOutcome(OnSearchPathLocatorPresent.java:49) ~[spring-cloud-config-server-2.2.0.RELEASE.jar:2.2.0.RELEASE]
	at org.springframework.boot.autoconfigure.condition.SpringBootCondition.matches(SpringBootCondition.java:47) ~[spring-boot-autoconfigure-2.3.0.RELEASE.jar:2.3.0.RELEASE]
	... 18 common frames omitted

what are you dependencies?

<properties>
	<java.version>1.8</java.version>
	<spring-cloud.version>Hoxton.RELEASE</spring-cloud.version>
</properties>

<dependencies>
	<dependency>
		<groupId>org.springframework.cloud</groupId>
		<artifactId>spring-cloud-config-server</artifactId>
	</dependency>

	<dependency>
		<groupId>org.springframework.cloud</groupId>
		<artifactId>spring-cloud-config-client</artifactId>
	</dependency>

	<dependency>
		<groupId>com.amazonaws</groupId>
		<artifactId>aws-java-sdk-s3</artifactId>
	</dependency>

	<dependency>
		<groupId>org.springframework.boot</groupId>
		<artifactId>spring-boot-starter-test</artifactId>
		<scope>test</scope>
		<exclusions>
			<exclusion>
				<groupId>org.junit.vintage</groupId>
				<artifactId>junit-vintage-engine</artifactId>
			</exclusion>
		</exclusions>
	</dependency>
</dependencies>

<dependencyManagement>
	<dependencies>
		<dependency>
			<groupId>org.springframework.cloud</groupId>
			<artifactId>spring-cloud-dependencies</artifactId>
			<version>${spring-cloud.version}</version>
			<type>pom</type>
			<scope>import</scope>
		</dependency>
	</dependencies>
</dependencyManagement>

Can you retry with Hoxton.SR5 (the latest)?

Getting same exceptions as above after changing the version to Hoxton.SR5.
Is the syntax for s3 search-locations field correct?
Should I use uri instead of search-locations?

Hello Did this issue resolve ? @srikanth

spring:
  profiles:
    active: composite
  cloud:
    config:
      server:
        profile: test
        label: sample-config
        composite:
        - type: aws
          bucket: s3://srikanth-sg-demo-config-server/sample-config
          region: us-east-1
      bootstrap: true

After changing the type to AWS and bucket and region this issue is gone. But it is having issues with connecting to s3 using proxy.
I have posted other question regarding that. Waiting for reply.

Hi  @spencergibb ,
We are still facing the same issue, Is there a sample project like the one we have for git? Also can we use embedded server for AWS?

@unnisathya92 what issue? Did you move to use composite for bootstrap?

This is the bootstrap config I have
spring:
  profiles:
      active: awss3
  cloud:
    config:
      server:
        awss3:
          region: us-east-1
          bucket: antm-amp-test-service-configs

Following is the snippet of my pom.xml
<parent>
		<groupId>org.springframework.boot</groupId>
		<artifactId>spring-boot-starter-parent</artifactId>
		<version>2.3.1.RELEASE</version>
		<relativePath />
	</parent>
	<properties>
		<java.version>1.8</java.version>
		<spring-cloud.version>Hoxton.SR5</spring-cloud.version>
	</properties>
	<dependencies>
		<dependency>
			<groupId>org.springframework.boot</groupId>
			<artifactId>spring-boot-starter-web</artifactId>
			<version>2.3.0.RELEASE</version>
		</dependency>
		<dependency>
			<groupId>org.springframework.cloud</groupId>
			<artifactId>spring-cloud-config-server</artifactId>
			<version>2.2.3.RELEASE</version>
		</dependency>
		<dependency>
			<groupId>com.amazonaws</groupId>
			<artifactId>aws-java-sdk-s3</artifactId>
			<version>1.11.796</version>
		</dependency>
		<dependency>
			<groupId>org.springframework.boot</groupId>
			<artifactId>spring-boot-starter-test</artifactId>
			<scope>test</scope>
			<exclusions>
				<exclusion>
					<groupId>org.junit.vintage</groupId>
					<artifactId>junit-vintage-engine</artifactId>
				</exclusion>
			</exclusions>
		</dependency>
	</dependencies>

When I run the app in my local, I get AWS connection exceptions, saying unable to connect to the host, even though I have access.
But when I run the same app from an EC2 instance with CLI set up, I get the following error.
2020-06-15 14:35:43.250  INFO 20968 --- [           main] o.s.s.concurrent.ThreadPoolTaskExecutor  : Initializing ExecutorService 'applicationTaskExecutor'
2020-06-15 14:35:43.722  WARN 20968 --- [           main] ConfigServletWebServerApplicationContext : Exception encountered during context initialization - cancelling refresh attempt: org.springframework.beans.factory.UnsatisfiedDependencyException: Error creating bean with name 'healthIndicatorRegistry' defined in class path resource [org/springframework/boot/actuate/autoconfigure/health/LegacyHealthEndpointCompatibilityConfiguration.class]: Unsatisfied dependency expressed through method 'healthIndicatorRegistry' parameter 0; nested exception is org.springframework.beans.factory.BeanCreationException: Error creating bean with name 'healthContributorRegistry' defined in class path resource [org/springframework/boot/actuate/autoconfigure/health/HealthEndpointConfiguration.class]: Bean instantiation via factory method failed; nested exception is org.springframework.beans.BeanInstantiationException: Failed to instantiate [org.springframework.boot.actuate.health.HealthContributorRegistry]: Factory method 'healthContributorRegistry' threw exception; nested exception is org.springframework.beans.factory.UnsatisfiedDependencyException: Error creating bean with name 'configServerHealthIndicator' defined in class path resource [org/springframework/cloud/config/server/config/EnvironmentRepositoryConfiguration.class]: Unsatisfied dependency expressed through method 'configServerHealthIndicator' parameter 0; nested exception is org.springframework.beans.factory.UnsatisfiedDependencyException: Error creating bean with name 'org.springframework.cloud.config.server.config.CompositeConfiguration': Unsatisfied dependency expressed through method 'setEnvironmentRepos' parameter 0; nested exception is org.springframework.beans.factory.BeanCreationException: Error creating bean with name 'defaultEnvironmentRepository' defined in class path resource [org/springframework/cloud/config/server/config/**_DefaultRepositoryConfiguration_**.class]: Invocation of init method failed; nested exception is java.lang.IllegalStateException: You need to configure a uri for the git repository.
2020-06-15 14:35:43.724  INFO 20968 --- [           main] o.s.s.concurrent.ThreadPoolTaskExecutor  : Shutting down ExecutorService 'applicationTaskExecutor'
2020-06-15 14:35:43.730  INFO 20968 --- [           main] o.apache.catalina.core.StandardService   : Stopping service [Tomcat]
2020-06-15 14:35:43.749  INFO 20968 --- [           main] ConditionEvaluationReportLoggingListener :

Error starting ApplicationContext. To display the conditions report re-run your application with 'debug' enabled.
2020-06-15 14:35:43.754 ERROR 20968 --- [           main] o.s.b.d.LoggingFailureAnalysisReporter   :

***************************
APPLICATION FAILED TO START
***************************

Description:

Invalid config server configuration.

Action:

If you are using the git profile, you need to set a Git URI in your configuration.  If you are using a native profile and have spring.cloud.config.server.bootstrap=true, you need to use a composite configuration.

Am I doing something wrong? Not sure why is it looking for DefaultRepositoryConfiguration even though my maven dependency has AWSS3RepositoryConfiguration

Your configuration needs to use the composite profile as mentioned and shown here https://github.com/spring-cloud/spring-cloud-config/issues/1635#issuecomment-643434172

Thanks @spencergibb ,
so if my property file is application-uat.properties sitting in the bucket, is the following config correct
spring:
  profiles:
    active: composite
  cloud:
    config:
      server:
        profile: uat
        composite:
        - type: aws
          bucket: antm-amp-test-service-configs
          region: us-east-1
        bootstrap: true

There's no such property spring.cloud.config.server.profile.

Thanks @spencergibb ,
but is there a way where I can embed this in one server instead of server client configuration?

We've moved beyond the scope of this issue. The closest thing I can think of is spring.cloud.config.server.default-profile, but I think that only works if the client doesn't send one, and config client always does.

Ok, but I dont have a seperate client app, I am planning to have a single app that reads the properties from s3 bucket. would the bootstrap.yml file be still the same?

spring.cloud.config.profile

@spencergibb Thanks worked like a charm.
this is the bootstrap I used
spring:
  profiles:
    active: composite
  cloud:
    config:
      profile: uat
      server:
        composite:
        - type: aws
          bucket: <bucket>
          region: us-east-1
        bootstrap: true
management:
  endpoints:
    web:
      exposure:
        include: "*"

and I don't have enable //@EnableConfigServer annotation for the main class.

I was facing the same issue when I am using awss3 profile(I am not trying to get properties from multiple backends). For me, the issue was I had an environment variable defined with some other value while the value in bootstrap.yml is hardcoded to awss3.
Here is my bootstrap.yml
spring:
  profiles:
    active: awss3
  application:
    name: app
  cloud:
    config:
      profile: development
      server:
        accept-empty: false
        bootstrap: true
        awss3:
          region: ap-south-1
          bucket: bucket1
     label: development

I removed the environment and its working fine.

Any resolution for the same? I am also facing this issue.
I am using native profile.
and provided file uri.
spring.profiles.active=native
spring.cloud.config.server.native.search-locations=file:///C:/Users/username/configrepo/

Any resolution for the same? I am also facing this issue.
I am using native profile.
and provided file uri.
spring.profiles.active=native
spring.cloud.config.server.native.search-locations=file:///C:/Users/username/configrepo/

I tried with yaml file and worked:
server:
  port: 8081
spring:
  profiles:
    active: composite
  cloud:
    config:
      server:
        composite:
        - type: native
          search-locations: file:///C:/Users/username/configrepo/

Any resolution for the same? I am also facing this issue.
I am using native profile.
and provided file uri.
spring.profiles.active=native
spring.cloud.config.server.native.search-locations=file:///C:/Users/username/configrepo/

I tried with yaml file and worked:
server:
  port: 8081
spring:
  profiles:
    active: composite
  cloud:
    config:
      server:
        composite:
        - type: native
          search-locations: file:///C:/Users/username/configrepo/

The following configuration worked for me, if an S3 connection could not be established, I am  reading the configs from local
spring.application.name={APP_NAME}

spring.profiles.active=composite
spring.cloud.config.profile=${ACTIVE_PROFILES}
spring.cloud.config.server.composite[0].type=aws
spring.cloud.config.server.composite[0].bucket=${S3_CONFIG_BUCKET}
spring.cloud.config.label=${ACTIVE_PROFILES}
spring.cloud.config.server.composite[0].region=${S3_CONFIG_REGION}
spring.cloud.config.server.composite[1].type=native
spring.cloud.config.server.composite[1].search-locations=${localDirectory}/amplified-service-configs/TEST/${ACTIVE_PROFILES}

spring.cloud.config.server.bootstrap=true

The following configuration worked for me, if an S3 connection could not be established, I am  reading the configs from local
spring.application.name={APP_NAME}

spring.profiles.active=composite
spring.cloud.config.profile=${ACTIVE_PROFILES}
spring.cloud.config.server.composite[0].type=aws
spring.cloud.config.server.composite[0].bucket=${S3_CONFIG_BUCKET}
spring.cloud.config.label=${ACTIVE_PROFILES}
spring.cloud.config.server.composite[0].region=${S3_CONFIG_REGION}
spring.cloud.config.server.composite[1].type=native
spring.cloud.config.server.composite[1].search-locations=${localDirectory}/amplified-service-configs/TEST/${ACTIVE_PROFILES}

spring.cloud.config.server.bootstrap=true

@spencergibb  hello! I'm trying to use Spring Cloud Config Server with Docker, and when i do Build Dockerfile, i receive an error:
[ERROR] contextLoads  Time elapsed: 0.013 s  <<< ERROR! java.lang.IllegalStateException: Failed to load ApplicationContext
Caused by: org.springframework.beans.factory.BeanCreationException: Error creating bean with name 'healthContributorRegistry' defined in class path resource [org/springframework/boot/actuate/autoconfigure/health/HealthEndpointConfiguration.class]: Bean instantiation via factory method failed; nested exception is org.springframework.beans.BeanInstantiationException: Failed to instantiate [org.springframework.boot.actuate.health.HealthContributorRegistry]: Factory method 'healthContributorRegistry' threw exception; nested exception is org.springframework.beans.factory.UnsatisfiedDependencyException: Error creating bean with name 'configServerHealthIndicator' defined in class path resource [org/springframework/cloud/config/server/config/EnvironmentRepositoryConfiguration.class]: Unsatisfied dependency expressed through method 'configServerHealthIndicator' parameter 0; nested exception is org.springframework.beans.factory.UnsatisfiedDependencyException: Error creating bean with name 'org.springframework.cloud.config.server.config.CompositeConfiguration': Unsatisfied dependency expressed through method 'setEnvironmentRepos' parameter 0; nested exception is org.springframework.beans.factory.BeanCreationException: Error creating bean with name 'defaultEnvironmentRepository' defined in class path resource [org/springframework/cloud/config/server/config/DefaultRepositoryConfiguration.class]: Invocation of init method failed; nested exception is java.lang.IllegalStateException: You need to configure a uri for the git repository.
Caused by: org.springframework.beans.BeanInstantiationException: Failed to instantiate [org.springframework.boot.actuate.health.HealthContributorRegistry]: Factory method 'healthContributorRegistry' threw exception; nested exception is org.springframework.beans.factory.UnsatisfiedDependencyException: Error creating bean with name 'configServerHealthIndicator' defined in class path resource [org/springframework/cloud/config/server/config/EnvironmentRepositoryConfiguration.class]: Unsatisfied dependency expressed through method 'configServerHealthIndicator' parameter 0; nested exception is org.springframework.beans.factory.UnsatisfiedDependencyException: Error creating bean with name 'org.springframework.cloud.config.server.config.CompositeConfiguration': Unsatisfied dependency expressed through method 'setEnvironmentRepos' parameter 0; nested exception is org.springframework.beans.factory.BeanCreationException: Error creating bean with name 'defaultEnvironmentRepository' defined in class path resource [org/springframework/cloud/config/server/config/DefaultRepositoryConfiguration.class]: Invocation of init method failed; nested exception is java.lang.IllegalStateException: You need to configure a uri for the git repository.
Caused by: org.springframework.beans.factory.UnsatisfiedDependencyException: Error creating bean with name 'configServerHealthIndicator' defined in class path resource [org/springframework/cloud/config/server/config/EnvironmentRepositoryConfiguration.class]: Unsatisfied dependency expressed through method 'configServerHealthIndicator' parameter 0; nested exception is org.springframework.beans.factory.UnsatisfiedDependencyException: Error creating bean with name 'org.springframework.cloud.config.server.config.CompositeConfiguration': Unsatisfied dependency expressed through method 'setEnvironmentRepos' parameter 0; nested exception is org.springframework.beans.factory.BeanCreationException: Error creating bean with name 'defaultEnvironmentRepository' defined in class path resource [org/springframework/cloud/config/server/config/DefaultRepositoryConfiguration.class]: Invocation of init method failed; nested exception is java.lang.IllegalStateException: You need to configure a uri for the git repository.
Caused by: org.springframework.beans.factory.UnsatisfiedDependencyException: Error creating bean with name 'org.springframework.cloud.config.server.config.CompositeConfiguration': Unsatisfied dependency expressed through method 'setEnvironmentRepos' parameter 0; nested exception is org.springframework.beans.factory.BeanCreationException: Error creating bean with name 'defaultEnvironmentRepository' defined in class path resource [org/springframework/cloud/config/server/config/DefaultRepositoryConfiguration.class]: Invocation of init method failed; nested exception is java.lang.IllegalStateException: You need to configure a uri for the git repository.
Caused by: org.springframework.beans.factory.BeanCreationException: Error creating bean with name 'defaultEnvironmentRepository' defined in class path resource [org/springframework/cloud/config/server/config/DefaultRepositoryConfiguration.class]: Invocation of init method failed; nested exception is java.lang.IllegalStateException: You need to configure a uri for the git repository.
Caused by: java.lang.IllegalStateException: You need to configure a uri for the git repository.

but my bootstrap yml is:
spring:
  application:
    name: CONFIG-SERVER
  profiles:
    active:
    - git
  cloud:
    config:
      server:
        git:
          default-label: main
          uri: https://github.com/hideyourname/cloud-config-server.git

I have @ConfigServer on my main class and config server dependency on my POM

Any resolution for the same? I am also facing this issue.
I am using native profile.
and provided file uri.
spring.profiles.active=native
spring.cloud.config.server.native.search-locations=file:///C:/Users/username/configrepo/

It will works if rename file bootstrap.yml -> application.yml.

@spencergibb i am facing same issue with updated version. Can you please help me on this? Please see below my sample git repo.
https://github.com/jaganm2018/spring-cloud-function-aws
Already I raise issue : 1903 .
please I’m struggling past 7 days.

Config should be in application.yml not bootstrap.yml.
This is the right way.
Please note !!!

This refrence help me fix my problem: https://cloud.spring.io/spring-cloud-config/multi/multi__spring_cloud_config_server.html.

so hard

The issue arose when I upgraded some of my spring dependencies. I managed to fix this issue by adding the spring bootstrap dependency. This allows the application to use the older legacy bootstrap configuration. More info can be found in the first answer here - https://stackoverflow.com/questions/64994034/bootstrap-yml-configuration-not-processed-anymore-with-spring-cloud-2020-0
		<dependency> 			<groupId>org.springframework.cloud</groupId> 			<artifactId>spring-cloud-starter-bootstrap</artifactId> 		</dependency>

bootstrap: true
Working configuration!!

logging:
level:
com.aric.samples: TRACE
server:
port: 8082
spring:
cloud:
config:
enabled: false #does not mater
server:
jdbc:
enabled: true
sql: select KK, VV from PROPERTIES where APPLICATION=? and PP=? and LL=?
order: 1
datasource:
driver-class-name: com.mysql.cj.jdbc.Driver
username: root
password: mysql@1234
url: jdbc:mysql://localhost:3306/kuebiko_db
#jndi-name: jdbc/config
profiles:
active:
- jdbc
jpa:
#database-platform: org.hibernate.dialect.MySQL5Dialect
show-sql: true
hibernate:
ddl-auto: update

package com.mmk.Insurance.configserver;
import org.springframework.boot.SpringApplication;
import org.springframework.boot.autoconfigure.SpringBootApplication;
import org.springframework.cloud.config.server.EnableConfigServer;
@SpringBootApplication
@EnableConfigServer
public class InsuranceConfigServerApplication {
public static void main(String[] args) {
	SpringApplication.run(InsuranceConfigServerApplication.class, args);
}

}
server.port=8888
spring.cloud.config.server.git.uri=	https://github.com/midde905/Insurance-Config-Server
management.endpoints.web.exposure.include=*
Description:
Invalid config server configuration.
Action:
If you are using the git profile, you need to set a Git URI in your configuration.  If you have set spring.cloud.config.server.bootstrap=true, you need to use a composite configuration.
plz help to reslove

**Also check if you have an Environment Variable set, that overrides the profile. It will also lead to this error! I had "SPRING_PROFILES_ACTIVE" set and it leads to the config being overriden. **


Make buffered.Reader.append accept any ByteSeq.

This is an issue of principle-of-least-surprise, since buffered.Writer
emits ByteSeqs in its output, so having buffered.Reader accept ByteSeqs
at its input makes it symmetrical and least surprising.
This doesn't break any user code, since it only makes an argument type
more general, and does not make any return types more general.
This came up in a discussion in #1639.

@jemc looks like this doesn't quite work. Let me know if you want to talk about the options.
I like the idea of applying the principle-of-least-surprise, but I also think that the example in #1639 was pretty contrived so it shouldn't be the main driver of what we're doing here.

Odd, I didn't see those failures locally - something must have been screwy with my local environment, since those are legitimate failures.

Amended to take a slightly different approach in dfb9914.

@Praetonus mentioned to me that we might also want to consider making buffered.Writer return an Array[Array[U8]] instead of an Array[ByteSeq].  Unlike this PR, that would be a breaking change, and would potentially incur a bit of small overhead for the Writer.write and Writer.writev methods if they still accepted a ByteSeq and had to convert to an Array[U8] internally.  Also, due to that change being more invasive it would probably be best to do it through RFC.
Still, I think it's at least worth considering that idea before merging this one.


change else-if to given/when switch

Feels pointless to alias to $contents just to immediately use given to alias it to $_ you would have had with for by default

Can you combine given and for?
given for @items {
  when Str { $_ }
  when Positional { $_ }
}

Just trying to make the original code more readable.

All given does is temporarily store its argument in $_, which for also does by default.

Also you didn't need to add the parameter to the $_.map: ...
And you could do the same improvement to that inner mapped block
And you can do an implicit map method call ( not that it makes it any clearer )
when Positional {
    @chunks.append: .map: {
        when Pod::Block {
            *.&pod-gist
        }
        when Str {
            $_
        }
    }
}

The code needs help.
If the item is a Pod::Block, it recurses. The rest of the patterns should follow that example.
sub pod-gist should be a multi that accepts either a Pod::Block, Str, or Positional.

That could lead to a cleaner implementation


Use verbose flags in Readme

so people who don't know hugos flags can guess what they mean just from reading.

Yeah, I got to be the merge request 300 :)


how to modify the request headers?

I'm using hls and I want to send the authorization header to the server for each request, how is it possible to do that?

This isn't an issue, in the future please open a discussion on GitHub or a help post in our Discord channel. I also don't know what framework you're using so provide more info when opening issues, don't be lazy otherwise I might close in the future.
You need to configure the HLS instance:
provider.config = {
  xhrSetup: (xhs, url) => {
    xhr.setRequestHeader("Referer", "https://vidmoly.to/");
  }
}


Improve hosting APIs for startup self host scenarios

While updating omnisharp to beta2 I ended up doing this https://github.com/OmniSharp/omnisharp-roslyn/blob/beta2/src/OmniSharp/Startup.cs#L38, because we made it close to impossible to add services if you're the host. I suggest we make it so that the caller of HostingServices.Create can provider types that will be imported by the calling application.
/cc @HaoK @lodejard @Tratcher

Yeah I agree I felt the same way when writing unit tests as well.


Missing Taverna e Bonita

https://taverna.incubator.apache.org/
https://www.bonitasoft.com/
PS: no time for PR

Is https://en.wikipedia.org/wiki/Apache_Taverna awesome enough to be included?


Rename DeepStruct to Config

To make sure DeepStruct doesn't end up being used outside its current purpose without some thought given, I propose we rename the class to Config.
The implementation hasn't been thought through to cover performance or security issues if it's used on incoming data. Using it on config files should be totally fine.

I think it can stay as DeepStruct because that is what it is. It is based on OpenStruct, and is not doing much on top of it tbh.
OpenStruct itself uses :to_sym in 6 different places in ruby 2.3, and in 4 different places in 2.1.x (havent bothered to check earlier). This means ruby developers should be careful with using either OpenStruct or DeepStruct. They are dynamic and as such have their concerns.
From documentation of OpenStruct
# An OpenStruct utilizes Ruby's method lookup structure to find and define the
# necessary methods for properties. This is accomplished through the method
# method_missing and define_method.
#
# This should be a consideration if there is a concern about the performance of
# the objects that are created, as there is much more overhead in the setting
# of these properties compared to using a Hash or a Struct.

TLDR; Use DeepStruct with care in controlled places (such as config is one example but not the only use case). I was even thinking of making this into its own gem for future re-use.
Just my 2c

Ok, so maybe document the proper use-cases of the class at the top of the file. Also, there's already both a deep_struct and deepstruct gem. Let's not add to the confusion. ;)


Added onFocus and onBlur configs for the input field

I added two new configs, onFocus and onBlur to the autocomplete dropdown.  My motivation for making this change is that I wanted to automatically position the field at the top of the screen on focus, and to return the field on blur (similar to google's mobile site).
Note, I couldn't get the npm run commit command to work.  It kept blowing up while trying to find the pre-commit hook in my .git/hooks directory.

This is somewhat related to #51, though not generic.  I can make any necessary tweaks if you are interested in merging.

@klandell I guess #60 fixes your problem ? Shouldn't you close this pr ? 😊

Found another way to do what I wanted, but onBlur didn't get called for me when I tried using it.


Cookie Consent can't be agreed in Safari

In Safari the field "I agree" is not shown in the cookie consent, so it can not be agreed and is always visible.

It now seems to work. I cannot reproduce the problem.


Add dataTables footer callback

Problem
Pagination causes Total to be incorrect. Example below.
Solution
The dataTables gem has a footer callback I think we can use to update total depending on the values in the displayed page.
https://datatables.net/examples/advanced_init/footer_callback.html

@tekHudson I can handle this 👍

Fixed by #541


toString() throws exception when phonNumber is null

phoneNumber is a nullable value, but the method toString calls phoneNumber!. This causes the problem that printing the PhoneNumber e.g. for debugging purposes can crash the app.

Sorry, this bug is not for this library... My bad.


marking my attendance for the week of 12-23-2024

Notes for Reviewers

This PR fixes #

Signed commits

[ ] Yes, I signed my commits.

🚀 Preview for commit 389b4a6850cef72d2d0a37125749d45b884f74ed at: https://676d66c3066491d16f8499fb--meshery-docs-preview.netlify.app


libu2f-host: 1.1.5 -> 1.1.6

Semi-automatic update generated by https://github.com/ryantm/nixpkgs-update tools.
This update was made based on information from https://repology.org/metapackage/libu2f-host/versions.
These checks were done:

built on NixOS
/nix/store/8jbzdkhk2krc8yc37c9bcxsbmam5csaa-libu2f-host-1.1.6/bin/u2f-host passed the binary check.
1 of 1 passed binary check by having a zero exit code.
1 of 1 passed binary check by having the new version present in output.
found 1.1.6 with grep in /nix/store/8jbzdkhk2krc8yc37c9bcxsbmam5csaa-libu2f-host-1.1.6
directory tree listing: https://gist.github.com/bc0958f894bcdad9565006be8be45096
du listing: https://gist.github.com/e9a255d64be0442f7d14fca45cbcb6f0

meta.description for libu2f-host is: '"A C library and command-line tool that implements the host-side of the U2F protocol"'.
cc @wkennington for testing.

Success on x86_64-linux (full log)
Attempted: libu2f-host
Partial log (click to expand)
Removing /nix/store/8jbzdkhk2krc8yc37c9bcxsbmam5csaa-libu2f-host-1.1.6/share/gtk-doc
rmdir: failed to remove '/nix/store/8jbzdkhk2krc8yc37c9bcxsbmam5csaa-libu2f-host-1.1.6/share': Directory not empty
shrinking RPATHs of ELF executables and libraries in /nix/store/8jbzdkhk2krc8yc37c9bcxsbmam5csaa-libu2f-host-1.1.6
shrinking /nix/store/8jbzdkhk2krc8yc37c9bcxsbmam5csaa-libu2f-host-1.1.6/bin/u2f-host
shrinking /nix/store/8jbzdkhk2krc8yc37c9bcxsbmam5csaa-libu2f-host-1.1.6/lib/libu2f-host.so.0.1.6
gzipping man pages under /nix/store/8jbzdkhk2krc8yc37c9bcxsbmam5csaa-libu2f-host-1.1.6/share/man/
strip is /nix/store/j75dgadrff2d1fyc4fczmcgqkid2imdx-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/8jbzdkhk2krc8yc37c9bcxsbmam5csaa-libu2f-host-1.1.6/lib  /nix/store/8jbzdkhk2krc8yc37c9bcxsbmam5csaa-libu2f-host-1.1.6/bin
patching script interpreter paths in /nix/store/8jbzdkhk2krc8yc37c9bcxsbmam5csaa-libu2f-host-1.1.6
checking for references to /build in /nix/store/8jbzdkhk2krc8yc37c9bcxsbmam5csaa-libu2f-host-1.1.6...

Success on x86_64-darwin (full log)
Attempted: libu2f-host
Partial log (click to expand)
/nix/store/qr1r0ylwy250ipxl14b57ndrq0r0gkgr-libu2f-host-1.1.6/lib/libu2f-host.0.dylib: fixing dylib
/nix/store/qr1r0ylwy250ipxl14b57ndrq0r0gkgr-libu2f-host-1.1.6/lib/libu2f-host.0.dylib: fixing dylib
/nix/store/qr1r0ylwy250ipxl14b57ndrq0r0gkgr-libu2f-host-1.1.6/lib/libu2f-host.0.dylib: fixing dylib
/nix/store/qr1r0ylwy250ipxl14b57ndrq0r0gkgr-libu2f-host-1.1.6/lib/libu2f-host.0.dylib: fixing dylib
/nix/store/qr1r0ylwy250ipxl14b57ndrq0r0gkgr-libu2f-host-1.1.6/lib/libu2f-host.0.dylib: fixing dylib
/nix/store/qr1r0ylwy250ipxl14b57ndrq0r0gkgr-libu2f-host-1.1.6/lib/libu2f-host.0.dylib: fixing dylib
/nix/store/qr1r0ylwy250ipxl14b57ndrq0r0gkgr-libu2f-host-1.1.6/lib/libu2f-host.0.dylib: fixing dylib
/nix/store/qr1r0ylwy250ipxl14b57ndrq0r0gkgr-libu2f-host-1.1.6/lib/libu2f-host.0.dylib: fixing dylib
/nix/store/qr1r0ylwy250ipxl14b57ndrq0r0gkgr-libu2f-host-1.1.6/lib/libu2f-host.0.dylib: fixing dylib
/nix/store/qr1r0ylwy250ipxl14b57ndrq0r0gkgr-libu2f-host-1.1.6

Success on aarch64-linux (full log)
Attempted: libu2f-host
Partial log (click to expand)
rmdir: failed to remove '/nix/store/1zp3lxjqbh9nahrjs2rmdph4fickyhw6-libu2f-host-1.1.6/share': Directory not empty
shrinking RPATHs of ELF executables and libraries in /nix/store/1zp3lxjqbh9nahrjs2rmdph4fickyhw6-libu2f-host-1.1.6
shrinking /nix/store/1zp3lxjqbh9nahrjs2rmdph4fickyhw6-libu2f-host-1.1.6/bin/u2f-host
shrinking /nix/store/1zp3lxjqbh9nahrjs2rmdph4fickyhw6-libu2f-host-1.1.6/lib/libu2f-host.so.0.1.6
gzipping man pages under /nix/store/1zp3lxjqbh9nahrjs2rmdph4fickyhw6-libu2f-host-1.1.6/share/man/
strip is /nix/store/jk6j4lh9v5mvjdbdc35sj0zffhhf6s56-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/1zp3lxjqbh9nahrjs2rmdph4fickyhw6-libu2f-host-1.1.6/lib  /nix/store/1zp3lxjqbh9nahrjs2rmdph4fickyhw6-libu2f-host-1.1.6/bin
patching script interpreter paths in /nix/store/1zp3lxjqbh9nahrjs2rmdph4fickyhw6-libu2f-host-1.1.6
checking for references to /build in /nix/store/1zp3lxjqbh9nahrjs2rmdph4fickyhw6-libu2f-host-1.1.6...
/nix/store/1zp3lxjqbh9nahrjs2rmdph4fickyhw6-libu2f-host-1.1.6


Add backup_location option

Resolves https://github.com/gruntwork-io/terraform-google-sql/issues/61
This PR allows the user to optionally set backup_location, which defaults to null. Existing behavior is preserved.
I did not modify the tests, but I can if given some direction.

@robmorgan @yorinasub17, sorry to bother you. Usually these small fixes are responded to pretty quickly, just wanted to make sure this was not missed.
Thanks 👍

Friendly ping on this. We have our own fork for now but I try to use upstream when possible. Any feedback would be appreciated.

Apologies for the delay in responding to this PR. Please see below:
Sunset notice
We believe there is an opportunity to create a truly outstanding developer experience for deploying to the cloud, however developing this vision requires that we temporarily limit our focus to just one cloud. Gruntwork has hundreds of customers currently using AWS, so we have temporarily suspended our maintenance efforts on this repo. Once we have implemented and validated our vision for the developer experience on the cloud, we look forward to picking this up. In the meantime, you are welcome to use this code in accordance with the open source license, however we will not be responding to GitHub Issues or Pull Requests.
If you wish to be the maintainer for this project, we are open to considering that. Please contact us at<EMAIL_ADDRESS>

Closing due to repo sunset


Fix up queries

I'm pretty sure several of these queries could be done more efficiently if I understood Diesel better.

I think this has been done now, but I'm always happy to take more improvements if anyone finds any!


Account Unlink option

Not sure how useful this is ?  http://prnt.sc/elnmgi

@cAstraea , the link doesn't work


Allow to stop transition with pre transition event

All is in the title.
This PR is related to https://github.com/winzou/state-machine/issues/12

In your implementation it's only on opt-in, so that's OK! Thanks!

(And sorry for the super-late merge!)


[Feature] Enable build from experimental ppa

Through a build argument, enable optional use of exp5 ppa to replace the standard upnp1

Available in 2022-10-26


opt Opt the performance of join probe

Proposed changes
Issue Number: close #xxx

Further comments
If this is a relatively large or complex change, kick off the discussion at<EMAIL_ADDRESS>by explaining why you chose the solution you did and what alternatives you considered, etc...

run buildall

(From new machine)TeamCity pipeline, clickbench performance test result:
the sum of best hot time: 55.55 seconds
stream load tsv:          501 seconds loaded<PHONE_NUMBER>9 Bytes, about 142 MB/s
stream load json:         19 seconds loaded<PHONE_NUMBER> Bytes, about 118 MB/s
stream load orc:          64 seconds loaded<PHONE_NUMBER> Bytes, about 16 MB/s
stream load parquet:          30 seconds loaded 861443392 Bytes, about 27 MB/s
insert into select:          29.0 seconds inserted 10000000 Rows, about 344K ops/s
storage size:<PHONE_NUMBER>6 Bytes

run buildall

(From new machine)TeamCity pipeline, clickbench performance test result:
the sum of best hot time: 51.85 seconds
stream load tsv:          512 seconds loaded<PHONE_NUMBER>9 Bytes, about 139 MB/s
stream load json:         19 seconds loaded<PHONE_NUMBER> Bytes, about 118 MB/s
stream load orc:          67 seconds loaded<PHONE_NUMBER> Bytes, about 15 MB/s
stream load parquet:          32 seconds loaded 861443392 Bytes, about 25 MB/s
insert into select:          32.7 seconds inserted 10000000 Rows, about 305K ops/s
storage size:<PHONE_NUMBER>3 Bytes

run buildall

(From new machine)TeamCity pipeline, clickbench performance test result:
the sum of best hot time: 51.04 seconds
stream load tsv:          536 seconds loaded<PHONE_NUMBER>9 Bytes, about 133 MB/s
stream load json:         19 seconds loaded<PHONE_NUMBER> Bytes, about 118 MB/s
stream load orc:          65 seconds loaded<PHONE_NUMBER> Bytes, about 16 MB/s
stream load parquet:          31 seconds loaded 861443392 Bytes, about 26 MB/s
insert into select:          28.9 seconds inserted 10000000 Rows, about 346K ops/s
storage size:<PHONE_NUMBER>3 Bytes

(From new machine)TeamCity pipeline, clickbench performance test result:
the sum of best hot time: 50.84 seconds
stream load tsv:          505 seconds loaded<PHONE_NUMBER>9 Bytes, about 141 MB/s
stream load json:         19 seconds loaded<PHONE_NUMBER> Bytes, about 118 MB/s
stream load orc:          66 seconds loaded<PHONE_NUMBER> Bytes, about 15 MB/s
stream load parquet:          31 seconds loaded 861443392 Bytes, about 26 MB/s
insert into select:          29.0 seconds inserted 10000000 Rows, about 344K ops/s
storage size:<PHONE_NUMBER>5 Bytes


Add autoresume feature for the macOS software grabber

This PR is mainly a workaround for issues that occur after waking the system in some configurations.
Symptoms are described here: #868

Hi, @awawa-dev, is this gonna be merged? Am affected by this issue

Hi, @awawa-dev, is this gonna be merged? Am affected by this issue

Done :)


TextTheme.button doc is misleading

The TextTheme.button documentation says:
  /// Used for text on [RaisedButton] and [FlatButton].
  final TextStyle button;

But RaisedButton actually uses:
textStyle: theme.textTheme.button.copyWith(color: buttonTheme.getTextColor(this)),

So the color of the text on a raised button does not actually come from TextTheme.button but from ButtonTheme.getTextColor, which is misleading.
The documentation should be updated to point out that everything but the color of the text style is used or the text style should just be used as assumed.
Related

https://stackoverflow.com/questions/56517959/flutter-change-all-raised-button-text-color-in-theme

This leaves me with the question of how to actually set a custom theme wide text color for raised buttons?  So if a want to define the text color red for all my raised buttons, I have to set the textColor for every button.

Duplicate of https://github.com/flutter/flutter/issues/19623

Reopening to discuss what the point of textStyle: theme.textTheme.button.copyWith(color: buttonTheme.getTextColor(this)) is.
@HansMuller To make it not a breaking change I would suggest adding a ButtomThemeData.textColor and use it for ButtonTheme.getTextColor if present. In addition to that the documentation of TextTheme.button should be updated to point out that the color is overridden by ButtonTheme.getTextColor.

Closing this due to https://github.com/flutter/flutter/pull/59702 being merged.


Plugin fails building

While ./gradlew assemble works, running ./gradlew --info build fails with:
Execution failed for task ':validatePlugins'.
> Plugin validation failed. See https://docs.gradle.org/6.3/userguide/more_about_tasks.html#sec:task_input_output_annotations for more information on how to annotate task properties.
   > Warning: Type 'ClientNativeRunAgent': property 'graalHome' is not annotated with an input or output annotation.

Fixed with #107


CodeNarcServer unexpected error: Parse Error: Invalid status code

Hello,
I encounter following error message when using npm-groovy-lint on a debian 12.
err.log
As I am not familiar at all with node technology, I am stuck.
Software versions involved:
root@486be283f05f:/home/jenkins# npm-groovy-lint --version
GroovyLint: Successfully processed CodeNarc:
CodeNarc version 3.3.0
npm-groovy-lint version 14.6.0
Embeds:
CodeNarc version 3.3.0

Groovy version 3.0.9 (superlite)

root@486be283f05f:/home/jenkins# npm list -g
/usr/local/lib
├──<EMAIL_ADDRESS>├──<EMAIL_ADDRESS>├──<EMAIL_ADDRESS>└──<EMAIL_ADDRESS>openjdk 17.0.11 2024-04-16
OpenJDK Runtime Environment Temurin-17.0.11+9 (build 17.0.11+9)
OpenJDK 64-Bit Server VM Temurin-17.0.11+9 (build 17.0.11+9, mixed mode)
On another docker image with debian 11, with openjdk autoinstalled by npm-groovy-lint, with all above same version installed, I do not have the error.
Can you help to figure out the problem ?
Details of the debian 12 package installed:
apt-list.log
Maybe that was not the right place to share this problem (I am even not sure it is a npm-groovy-lint bug), apologize in that case just tell me where I should ask for support.

I forgot to mention that the execution continues and seems properly terminating with expected detection done.
The command line used to reproduce the issue is:
npm-groovy-lint  -i '/.git/' -o test.html scripts//*.groovy
Following command line does not shows errors:
npm-groovy-lint  -i '/.git/'  scripts//*.groovy
It seems the error is triggered by the use of "-o test.html" or "-o test.xml" on the command line.
run with "-o test.txt" or "-o test.json"  does not cause the error message

little up to avoid closure of the ticket

@guilcy XML and HTML are direct calls to CodeNarc formatter, it's much better to use txt , json or sarif, as npm-groovy-llint handles pre-processing and post-processing :)

I give it a try on nodejs 22.5.0, unfortunatly got the exact same behavior.
I am wondering how to report that behavior to codenarc maintainer. I don't know what/how codenarc is getting called by npm-groovy-llint, neither how to reproduce it with codenarc alone.
I will check if we can get rid of the html rendering. (xml is not an issue we can suppress it).

@guilcy I added a troubleshooting section that will allow you to see more logs :)
https://nvuillam.github.io/npm-groovy-lint/#troubleshooting

@guilcy I added a troubleshooting section that will allow you to see more logs :)
https://nvuillam.github.io/npm-groovy-lint/#troubleshooting
@nvuillam I will try that, not soon but asap.

@guilcy thanks a lot :)

@nvuillam I give it a try, unfortunatly I am not sure there is much info to understand the problem.
Please find the log attached:
run-npm-groovy-linter.log


Add Heading component to replace header

Heading component allows Header to be deprecated.
Deprecation currently marked in documentation only.
Checklist:

[x] Documentation
[x] Tests
[x] Ready to be merged

Deploy preview for govuk-react processing.
Building with commit 10ea165690c5a7b600a1fd36b66da18e30235ad1
https://app.netlify.com/sites/govuk-react/deploys/5c751ec6a097d8000771dc31

Codecov Report

Merging #571 into master will increase coverage by 0.01%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master     #571      +/-   ##
==========================================
+ Coverage    99.6%   99.61%   +0.01%
==========================================
  Files          88       90       +2
  Lines         506      523      +17
  Branches       50       53       +3
==========================================
+ Hits          504      521      +17
  Misses          2        2

Impacted Files
Coverage Δ

components/header/src/index.js
100% <ø> (ø)
:arrow_up:

components/heading/src/presets.js
100% <100%> (ø)

components/heading/src/index.js
100% <100%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b2b51cc...10d5ae4. Read the comment docs.

approved other than 2 comments


Display an alert on heroku deployments

Trello: https://trello.com/c/goZxffsJ/735-investigate-protecting-the-heroku-smart-answer-preview-apps
We want to avoid the general public being confused about the
information in the Smart Answers preview apps on Heroku.
We are then displaying a big alert banner on top of each page of heroku
deployments, to make very clear that the information shouldn't be
relied upon, and the user should instead refer to gov.uk for the
official information.
Preview

@chao-xian thanks, I tried to add a test to verify the banner is not displayed generally. Let me know if that could be ok.

Nice one @mgrassotti


Got to declaration, highlight symbol, find usages, etc. do not work on DU type if used to qualify unexisting case

There is a DU Msg, which does not have Delete case (yet). Using qualified case name Msg.Delete, it's impossible to jump to Msg type declaration:

However, completion does work as expected:

This seems to work with a small repro in VS:

Go to Definition, semantic highlighting, etc also work. There are some other issues though:

Find Refs and Rename do not pick up the Msg symbol used to qualify and undefined case
Invoking rename from the erroneous Msg case makes all other Msg usages disappear:

So there's definitely an issue here, but I'm not sure if it lies entirely within FCS.

@cartermp It seems the symbol use is not added during type checking, that's why it has no highlighting and that's what we rely on in Rider for navigation as well as highlighting.


Silencing latest warning raised on Swift 3.1.

'M_PI' is deprecated: Please use 'Double.pi' or '.pi' to get the value of correct type and avoid casting.
#115

Merged to master. Thanks!


Crash when take a picture from Camera.

When take a picture from Camera - crash:
Xamarin.iOS: Received unhandled ObjectiveC exception: NSInternalInconsistencyException threading violation: expected the main thread
I've tried put code inside InvokeOnMainThread and DispatchQueue.MainQueue.DispatchAsync - didn't help.

Hi @yyuzyk - I'm catching up on my backlog, sorry for my late response...
Have you been able to resolve this? I tested this with the reference application that is included in this project and I'm not getting this exception when taking a picture. So I'm guessing it's something in the setup of your app. I think we need more context to assess what was happening. Is it a Forms app or plain Xamarin.iOS?


4.0.0-Beta: FLAnimatedImage reference causes compile error

DKImagePicker ver. 4.0.0-Beta uses FLAnimatedImage as dependency (installed with CocoaPod).
The integration/usage causes build error:
/.../Pods/SDWebImage/SDWebImage/FLAnimatedImage/FLAnimatedImageView+WebCache.h:14:9: Include of non-modular header inside framework module 'SDWebImage.FLAnimatedImageView_WebCache': '/.../Pods/FLAnimatedImage/FLAnimatedImage/FLAnimatedImage.h'
"Could not build Objective-C module 'SDWebImage'"
See screenshot.

@zhangao0086 Any updates?

@pak-amsiq Sorry for the later response.
Have you seen this thread? https://stackoverflow.com/a/28552525/907422

@zhangao0086 Thanks for your input.
Setting "Allow Non-modular Includes in Framework Modules" to TRUE fixed this issue.

Closing this thread :) Feel free to re-open if it does not solve your problem :)

@zhangao0086, this issue still appearing.
I was using the old version 3.*, when my build succeeded.
Any other suggestions to fix this issue?
Please reopen this issue.

@pak-amsiq Could you post me a small project that can reproduce this issue?

As mentioned, I wasn't able to reproduce this issue in a example project.
My project includes extensions which uses 'SDWebImage' lib directly, which could interfere with your lib which includes 'SDWebImage'...
I found a solution where I only use main functionality from your lib:
pod 'DKImagePickerController', '4.0.0-beta', :subspecs => ['Core', 'ImageDataManager', 'Resource']
My extensions still includes 'SDWebImage', and doesn't seem to interfere with your library now.
This linking issue could occur due to multiple usages of 'SDWebImage'.
You could close this issue for now, as its not a issue with this solution.
Thank you for your time.

@zhangao0086

@pak-amsiq Thank you very much for your detailed analysis of this issue! I'll look for ways to replace SDWebImage in the future release 😃

@zhangao0086 i am getting following errors when archiving. but no issues when run on iphone or simulator.so i can not archiving.

Could not build Objective-C module 'DKImagePickerController'.
Cannot find interface declaration for 'FLAnimatedImageView', superclass of 'DKPhotoImageView'.
Could not build module 'DKPhotoGallery'

Replaced FLAnimatedImageView with SwiftyGif.


Categories not displayed in the filters

The left and right filters do not display all categories.

open test.visualize.admin.ch, source: int
Search "Ausgaben" including drafts
Select "Öffentliche Ausgaben TEST 3".
4a. Select "Categories" on the colour axis
5a. Display all filters on the right side
or
4b. Leave the colour axis empty
5b. Select the category filter on the left side

Only the root Total and its children are displayed. Level 2 is missing.
Expected behavior
All categories and all levels should be displayed.
Screenshots

Environment (please complete the following information):

Visualize environment and version: TEST v3.7.10 ([bfb9035]
Browser and version : Edge

For dataset "Greenhouse gas emissions" there are also problems with the filters but they are different: all categories appear but without labels and items cannot be selected.

@ortnever Can you tell me if the problem persists I am not able to reproduce anymore those two bugs ? I think the 2nd was fixed through #689 but cannot reproduce the other problem. It may have been solve also by #689 .

hi @ptbrowne , everything is fine now on int.visualize.admin.ch.
fyi : Now that we can choose the environment from int.visualize.admin.ch I will test from that environment using Lindas PROD data or Lindas INT data when there is no PROD dataset to test the feature in question, for example hierarchies.


Roadmap to stable v1.0.0

Let's face it, this project is stable and has been used in production for years :shipit:
However, we're currently following a v0.X.Y release scheme (http://sentimentalversioning.org/).
We should finally make this explicit and fully adhere to SemVer and release a stable v1.0.0.
To a large extend, a stable v1.0.0 helps making BC breaks more explicit and thus the whole project more reliable from a consumer perspective. This project is actively maintained and has received some major updates in the last weeks and has some major updates planned in the next weeks. Given our current versioning scheme, we'd like to ensure all anticipated BC breaks will be merged before the planned v1.0.0 release.
As such, I've set up a roadmap that enlists only the major changes for each version among with planned release dates towards a stable v1.0.0 release:
v0.4.5 :white_check_mark:

Released 2016-11-13
Major performance improvements
Infinite read buffer

v0.4.6 :white_check_mark:

Released 2017-01-25
close event semantics
Standalone Buffer

v0.5.0 :white_check_mark:

Released 2017-03-08
end event semantics
Strict / explicit event semantics and parameters
pipe() semantics

v0.6.0 :white_check_mark:

Released 2017-03-26
Read-/Write-only resources
Enforce non-blocking

v0.7.0

Planned 2017-04
Reduce public API

v1.0.0

Planned 2017-04
No new changes planned, this should merely mark the previous release as "stable"

This ticket aims to serve as a basic overview and does not contain every single change. Please also see the milestone links and the CHANGELOG for more details.
Obviously, this roadmap is subject to change and I'll try to keep it updated as we progress. In order to avoid cluttering this, please keep discussion in this ticket to a minimum and consider reaching out to us through new tickets or Twitter etc.

@clue For 0.x.y, x is usually considered major and y is minor. Why do you plan three breaking releases in one month? Shouldn't those changes be rather in a single release that's basically a RC of v1.0.0 then?

Thanks  @kelunik, I think you're raising a very valid concern :+1:
From a consumer perspective (somebody who's interested in using a stable v1.0.0) this doesn't really matter, as the v1.0.0 will be released at the same date, irrespective of how many intermediary releases there are.
The intermediary v0.x releases are mostly meant for integrators who already build on the existing versions and want a safe upgrade path (the CHANGELOG will list what needs to be changed). These releases DO contain some minor BC breaks, but they're in fact compatible for the most part. Getting these releases out early also helps with updating our other components (such as the HTTP server component), because they require some (but not all) of the changes along the path to the next stable version.
I hope this helps :+1:

@clue The issue with multiple major versions is that version conflicts are way more likely to happen, e.g. if some projects upgrade to ^0.6, but others stay at ^0.4. In some cases ^0.4 || ^0.5 || ^0.6 could be used, but that's not the way people usually do it.

@kelunik Yes, version conflicts are more likely to occur if we release more versions with breaking changes, but this is a trade-off we're willing to take in order to ease the upgrade path to the stable v1.0.0 release. As you've rightfully pointed out, most(!) consumers will in fact be able to target multiple major versions in the meantime. Ultimately, this should be resolved either way once the stable v1.0.0 is out in a few weeks anyway :+1:

Updated now that the v0.5.0 release is out :shipit:

Updated now that the v0.6.0 release is out :shipit:

How does #27 fit in the road map?

How does #27 fit in the roadmap?

Afaict there are no plans to get this in for v1.0.0 at the moment. May I ask you to comment on this ticket if you feel this is something that should block this release? :+1:

I guess it needs a new method and thus breaks BC otherwise, but not sure.

Updated now that the v0.7.0 release is out :shipit:
Unless we find any major blockers, there's hope that this is the last noteworthy release before we get to tag this as v1.0.0 :tada:

The very first stable v1.0.0 release with LTS has just been tagged and released! :tada:


TRITON-2378 Update sshpk for ed25519 support

Testing notes

Confirmed that make check test succeeded.
Pulled these changes into smartdc-auth and confirmed that  make check test succeeded
Pulled these changes into cloudapi and confirmed that  make check succeeded and that I could install the changes via sdcadm update -C experimental cloudapi@TRITON-2378-20231113T181023Z-g073fbb7
Finally, I pulled in these change to node-triton (via smartdc-auth), removed all keys from my account except for an ED25519 key and confirmed that I could make Cloud API requests and provision instances.

Just add the testing notes to the ticket then.


Error Middleware

AB#11126

Can you expand on this one please? What's the need/intent here? Thanks!

@nikithauc is this still a thing or can go away?


Fix next client server mismatch console errors for builder serve

Describe the bug
A clear and concise description of what the bug is.
To Reproduce
Steps to reproduce the behavior:

Go to '...'
Click on '....'
Scroll down to '....'
See error

Expected behavior
A clear and concise description of what you expected to happen.
Screenshots
If applicable, add screenshots to help explain your problem.
Desktop (please complete the following information):

OS: [e.g. iOS]
Browser [e.g. chrome, safari]
Version [e.g. 22]

Smartphone (please complete the following information):

Device: [e.g. iPhone6]
OS: [e.g. iOS8.1]
Browser [e.g. stock browser, safari]
Version [e.g. 22]

Additional context
Add any other context about the problem here.

https://github.com/vercel/next.js/issues/7322#issuecomment-968858477


Weights of memorization in practice

For a user, for each symbol store number that will denote how well the user memorized it.

Look up system in Anki

yes, it's about time to do it

we may turn it on and off in sidebar

Oh, I do not like this idea with a sidebar everywhere. Google navigation guide only allows it in the bottom of the navigation stack.

And why another project for the sprint? We have a milestone for this purpose.

And why another project for the sprint? We have a milestone for this purpose.

Oh yes, I see, it's temporal.

Oh, I do not like this idea with a sidebar everywhere. Google navigation guide only allows it in the bottom of the navigation stack.

today I have a planned conversation with blind teacher. I will ask her.

Google navigation guide only allows it in the bottom of the navigation stack.
@winter-yuki may you please provide a link?

The idea is to replace 'back' button with 'options' in practice and theoretical course

Implement scheduler like in Anki?

Looks like schedulers are not so simple. So these two features will handle this task for some time: #139 and #63

At this time, I suppose, there is little need for any schedulers, they are for self-paced learning, but apparently our app will be used primarily for supervised learning
there are much more urgent tasks and they are listed in Trello


[Feature request] Multi-master replication auto-configuration - REPLICAOF SLAVES

Is your feature request related to a problem? Please describe.
We use KeyDB in Multi-master configuration. As a configuration management system we use Amazon OpsWorks. When we add a new KeyDB node it is automatically configured to be replica of all nodes in the Layer and added to the load balancer.
Already working nodes:
Node A --> REPLICAOF Node B
Node B --> REPLICAOF Node A

Starting new node:
Node C --> REPLICAOF Node A, NodeB

Load balancer:
Node A
Node B
Node C

New replication settings:
Node A --> REPLICAOF Node B, Node C / restart
Node B --> REPLICAOF Node A, Node C / restart
Node C --> REPLICAOF Node A, Node B

Node C is a new, just started node. After some period of time, maybe just 30-60 seconds Node A and Node B will be automatically reconfigured to be replicated from the newly started node and KeyDB service will be restarted.
As a new node can be added to the load balancer before if was added to the replication on already working Nodes A/B and we can have some inconsistency in the dataset, clients can receive the error about missing data if data will be added to the Node C and requested from Node A or Node B.
Describe the solution you'd like
We can add a configuration key REPLICAOF SLAVES which should indicate KeyDB to automatically start replication from all its slaves.
Describe alternatives you've considered
Right now we assume that we can have some inconsistency in the KeyDB data because of the lag in the configuration of the replication.
Additional context
We also can consider to not serve request on KeyDB side if dataset is not yet replicated from the master nodes because we will receive an error. Such approach will help to not serve requests by e newly added node with zero keys and still not finished replication.

@ieslv Try the replica-serve-stale-data no config param.
# When a replica loses its connection with the master, or when the replication
# is still in progress, the replica can act in two different ways:
#
# 1) if replica-serve-stale-data is set to 'yes' (the default) the replica will
#    still reply to client requests, possibly with out of date data, or the
#    data set may just be empty if this is the first synchronization.
#
# 2) if replica-serve-stale-data is set to 'no' the replica will reply with
#    an error "SYNC with master in progress" to all the kind of commands
#    but to INFO, replicaOF, AUTH, PING, SHUTDOWN, REPLCONF, ROLE, CONFIG,
#    SUBSCRIBE, UNSUBSCRIBE, PSUBSCRIBE, PUNSUBSCRIBE, PUBLISH, PUBSUB,
#    COMMAND, POST, HOST: and LATENCY.
#

@yegors, thank you for the information.
With the replica-serve-stale-data no and in case of the Nginx as an LB it will pass connection to the replica but replica will return an error "SYNC with master in progress" and application probably should retry to connect to the cluster again. Nginx can pass connection to the next upstream only in case when it can't connect to the node(without any additional modules).
Maybe in case with HAProxy we can create some kind of check of the data on the replica.

@ieslv Yes its annoying a more advanced "down detection" is needed with HAProxy.  We don't know in advance if a connection will be from a replica so we can't refuse connections outright.

@JohnSully, the case with the "down detection" was an addition to the initial request.
May we have an option like REPLICAOF SLAVES which will mean that the instance should be replicated from all its replicas?


Tweak line wrapings and fix indentations in mysql-wordpress-pv

Performed actions below:

Tweaked long lines
Removed redundant blank lines
Provided 3 spaces for ordered list

Hi @NitishKumar06 , yes, the rendered page seems no any change. But these changes can provide much convenience for our contribution and coordination like multi-lingual localization, later edit and review, and training what a good markdown is.
In recent years, several projects emerge and quickly grow to make markdown prettier, e.g.:

prettier
markdownlint
Stylelint
EditorConfig
and more

In the k8s ecosystem, OpenTelemetry has built prettier markdown check into their CI flow.
That is the reason to perform this kind of change. Hope you can understand. Thanks.

/kind cleanup
/lgtm
/approve


Get the app to run in Docker

It appears the the docker file installs the 3 year old package, we need to build it ourself

This issue was moved to prolike/drop-gdpr#11


Add regression test for Visit

Internal issue: https://madra.cscs.ch/scs/reframe/issues/323

moving to https://jira.cscs.ch/browse/UES-1288


License

Hi! Currently this project doesn't have a license.
Could you please consider to add a license to it? Thanks!

It has a license but was missing a license file. Fixed it now.
Thanks for pointing it out for me!


Updating doc link to Java API's

Description
Updating link to be Java specific.
Checklist:

[x] Set target branch to main (current release) or v.next (next release)
[x] Request a reviewer
[x] Assign a reviewer
[x] Tag reviewer in comment

@D-R-Smith could you please do the first review?

@colinanderson could you please do a second review?


Remove space in controller value for new action link

Description
The generated links for "New Association" have a space preceding the controller name.  The links seem to work but I thought it should be cleaned up.
Summarize
Removed the space preceding the controller name.
Benefits
Saves OCD developers from having to remove spaces in baked templates.
Related Issues
N/A
fixes #
The links generated for "New" actions have a space prefixing the controller name - which seems to work fine, but wanted to clean up.

[Current coverage][cc-pull] is 19.55%

No coverage report found for master at d148323.

Powered by Codecov. Last updated by [d148323...21d71e9][cc-compare]
[cc-base-branch]: https://codecov.io/gh/FriendsOfCake/bootstrap-ui/branch/master?src=pr
[cc-compare]: https://codecov.io/gh/FriendsOfCake/bootstrap-ui/compare/d1483230d1bb46f6ff114ae987ddefd285f09dc7...21d71e94d6f154695a9ee6434e08b3c40599cbbd
[cc-pull]: https://codecov.io/gh/FriendsOfCake/bootstrap-ui/pull/151?src=pr


xgboost and xgboostcpp updates

See #477 for xgboost discussion.
This update might look something like the following:

hunterize latest xgboost
create a new hunter-package for modified xgboost moving forward "xgboost-lite"
merge HEAD xgboost -> xgboost-lite (w/ patches)
update https://github.com/elucideye/xgboostcpp w/ new xgboost-lite
create hunter-package for https://github.com/elucideye/xgboostcpp
integrate https://github.com/elucideye/xgboostcpp in drishti
retrain models using xgboostcpp
create a new drishti release

Currently set for Milestone 6, but it is a long one.  It might make sense to postpone this in order to get an initial hunter package out earlier.  We can always improve it...

Closing this in favor of a more focused near term issue related to using https://github.com/elucideye/xgboostcpp


add newpool method

add newpool method, so use the rpc client pool more  convenience

Thanks a lot for the contribution!
I'm unsure how this would fit golang's idioms though: the current New method already provides a somewhat simple way of creating a grpc pool.
However, I do get your point that having to create a factory can be a bit heavy at times. What do you think that, instead of making a full helper creating the pool in an obscure way, we provided an additional function in the package to returns a default factory?
Something like this:
pool, err := New(DefaultFactory(address), 1, capacity, 0)

with DefaultFactory returning a Factory function.


Enable all unittests in CI

A lot of unittests aren't running on CI because the GHA currently

Runs all tests but only on windows and a bunch of tests have the build tag !windows
On docker ubuntu only the tests with the dag docker ubuntu run

The fix is to add a GHA step that runs make test to run on all OSS

This rule doesn't use any build tags so it will run all tests.

Some of the newly enabled tests are flaky so we mark them to be skipped.

Disable the SONAR scan in PRs created from forks. It won't be able to run because the GHA can't get the secrets for PRs created from a fork.

The failure creates noise in various dashboards because we see the red "x" by the PR.

Fix #587

The first bullet points are not true. There is this step:
      - name: Test
        run: |
          export SHELL=/bin/bash
          export TZ=UTC
          TAGS="test_with_docker" make test/coverage
          make test/coverage/func

It runs all tests thanks to TAGS="test_with_docker" make test/coverage, including generating a coverage report.
Not all tests can run on Windows because they are Linux specific. At the current state, runme does not provide full Windows support. Windows with WSL is recommended.
With regard to the Sonar support and PRs from forks, let's wait for @sourishkrout's comment.

@adambabik Thank you. You're correct and setting TAGS=tags_with_docker should run all tests. In which case, do you know what's going on with respect to service_test.go is running CI?
You can see from my previous run of test all
https://github.com/stateful/runme/actions/runs/9231990310/job/25402625003
That service_test failed in the test_all rule but not on main.
Based on the coverage report (https://github.com/stateful/runme/actions/runs/9229617830/job/25396164592) it does seem like service_test is running on maining.
It looks like test all sets -race=false whereas the test with docker rule doesn't.

With regard to the Sonar support and PRs from forks, let's wait for @sourishkrout's comment.

Makes sense to disable Sonar for forks since we don't want to get into secrets sharing.

In which case, do you know what's going on with respect to service_test.go is running CI?

It is run on Linux but it's omitted on Windows.

You can see from my previous run of test all https://github.com/stateful/runme/actions/runs/9231990310/job/25402625003

This test is simply flaky. It is run in main and on PRs but it sometimes fails due to race condition. runnerv2 is more stable in this respect.

Remove other changes.

Please see my other comment.

Thanks @adambabik and @sourishkrout and sorry for the slow response.
So I'm unsure what to do with this PR because. The original motivation for this PR was

I observed locally that several tests were flaky
On CI the tests were passing consistently on main.

This lead me to conclude that the problem was that some tests were not running under CI. This conclusion was based on a misunderstanding about how tags worked. I assumed that setting tag "test_with_docker" only ran those tests as opposed to all tests + tests with that tag.
As @adambabik points out that's incorrect. So TestRunnerServiceServerExecute_WithInput/SimulateCtrlC is running and presumably passing fairly reliably on CI. I tried again locally on main and its failing for me locally.
    --- FAIL: TestRunnerServiceServerExecute_WithInput/SimulateCtrlC (1.52s)
        service_execute_test.go:724:
            	Error Trace:	/Users/jlewi/git_runme/internal/runnerv2service/service_execute_test.go:724
            	Error:      	"rpc error: code = Unknown desc = exit status 1" does not contain "exit status 130"
            	Test:       	TestRunnerServiceServerExecute_WithInput/SimulateCtrlC
        service_execute_test.go:725:
            	Error Trace:	/Users/jlewi/git_runme/internal/runnerv2service/service_execute_test.go:725
            	Error:      	Not equal:
            	            	expected: 130
            	            	actual  : 1
            	Test:       	TestRunnerServiceServerExecute_WithInput/SimulateCtrlC

So at this point; I don't know why CI is more reliable than local. As a result, I don't know how to fix GHA to make it not mask flakiness. However, this means all my CI changes (except for the sonar one) are solving a non-existent problem so I reverted them.
I'm uncertain what to do about skipping SimulateCtrlC. So I'm good with whatever you want. Skipping the test made more sense if we could reliably reproduce the failure in CI and didn't want to block PRs while we fixed it. But since the failures aren't reliably reproducing in CI the rationale doesn't really hold.
I've left the Sonar change in because I think that makes sense given reasons mentioned previously.
Closing this PR is also a completely reasonable outcome.

@jlewi thanks for the detailed explanation! There could be several reasons why this test fails for you locally, such as bash version, OS (including different Linux distros), terminal settings, and so on.
One of the options we could introduce is to run tests locally in a Docker container. Then we could ensure more reliable behaviour for all contributors, without them having to guess what to install in which version or delaying feedback and waiting for the CI result. However, the fact is that the nature of runme and its ability to execute commands on the host OS will keep  it open for edge cases.

Thanks @adambabik ; I had no idea that function was part of the stdlib. I've applied the suggestion.

@jlewi are the pre commit hooks running for you? Wondering if our contribution guidelines are incomplete

@sourishkrout That was my mistake. I just accepted the suggestion through the GitHub UI and didn't check back to make sure the CI was passing. I'd have to double check that precommits are running on stateful/runme; they run on stateful/runme-vscode.


Added translator support for Modulus token

PR Description
Added support for the modulus operator (%) and the assignment modulus operator (%=) in the CGL translator.
Related Issue
Resolves #116
Working on adding modulus support to the backend.
Shader Sample
This is the PerlinNoise.cgl example code for testing the modulus operator (%) and assignment modulus operator (%=):
shader PerlinNoise {

    // Perlin Noise Function
    float perlinNoise(vec2 p) {
        return fract(sin(dot(p, vec2(12.9898, 78.233))) * 43758.5453);
    }

    // Fragment Shader
    fragment {
        input vec2 vUV;
        output vec4 fragColor;

        void main() {
            float noise = perlinNoise(vUV);
            float height = noise * 10.0;
            vec3 color = vec3(height / 10.0, 1.0 - height / 10.0, 0.0);
            fragColor = vec4(color, 1.0);

            int color2 = 1200 % 10;       //MOD test
            color2 %= 10;                   //ASSIGN_MOD test
        }
    }
}

Checklist

[ ] Have you added the necessary tests?
[x] Only modified the files mentioned in the related issue(s)?
[ ] Are all tests passing?

hii @vishalghige43 can you please fix this and also solve the merge conflict .

hii @vishalghige43 can you please fix this and also solve the merge conflict .

ok,I'll complete it today.


migration: concat all series numbers when multiple

LGTM, but I would prefer @kprzerwa to check it! :)