[HBASE-25246] Backup/Restore hbase cell tags.

@anoopsjohn @virajjasani   I have added a boolean flag (encodeTags/decodeTags) in ProtobufUtil  which will evaluate to true if client cell block support is enabled.
Could you please tell me if I am thinking in the right direction ? Thank you !

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
0m 30s
Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s
No case conflicting files found.

+1 :green_heart:
hbaseanti
0m  0s
Patch does not have any anti-patterns.

+1 :green_heart:
@author
0m  0s
The patch does not contain any @author tags.

_ master Compile Tests _

+0 :ok:
mvndep
0m 25s
Maven dependency ordering for branch

+1 :green_heart:
mvninstall
3m 44s
master passed

+1 :green_heart:
checkstyle
1m 56s
master passed

+1 :green_heart:
spotbugs
3m 39s
master passed

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 13s
Maven dependency ordering for patch

+1 :green_heart:
mvninstall
3m 27s
the patch passed

-0 :warning:
checkstyle
0m 19s
hbase-mapreduce: The patch generated 1 new + 57 unchanged - 0 fixed = 58 total (was 57)

+1 :green_heart:
whitespace
0m  0s
The patch has no whitespace issues.

+1 :green_heart:
hadoopcheck
17m  9s
Patch does not cause any errors with Hadoop 3.1.2 3.2.1 3.3.0.

+1 :green_heart:
spotbugs
4m  5s
the patch passed

_ Other Tests _

+1 :green_heart:
asflicense
0m 38s
The patch does not generate ASF License warnings.

45m 29s

Subsystem
Report/Notes

Docker
ClientAPI=1.40 ServerAPI=1.40 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2745/1/artifact/yetus-general-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/2745

JIRA Issue
HBASE-25246

Optional Tests
dupname asflicense spotbugs hadoopcheck hbaseanti checkstyle

uname
Linux 0869ef374cb1 4.15.0-112-generic #113-Ubuntu SMP Thu Jul 9 23:41:39 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
master / 9a72b27f38

checkstyle
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2745/1/artifact/yetus-general-check/output/diff-checkstyle-hbase-mapreduce.txt

Max. process+thread count
94 (vs. ulimit of 30000)

modules
C: hbase-client hbase-server hbase-mapreduce U: .

Console output
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2745/1/console

versions
git=2.17.1 maven=3.6.3 spotbugs=3.1.12

Powered by
Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
1m  6s
Docker mode activated.

-0 :warning:
yetus
0m  3s
Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck

_ Prechecks _

_ master Compile Tests _

+0 :ok:
mvndep
0m 22s
Maven dependency ordering for branch

+1 :green_heart:
mvninstall
4m 14s
master passed

+1 :green_heart:
compile
2m  2s
master passed

+1 :green_heart:
shadedjars
6m 43s
branch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
1m 29s
master passed

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 16s
Maven dependency ordering for patch

+1 :green_heart:
mvninstall
3m 58s
the patch passed

+1 :green_heart:
compile
2m  0s
the patch passed

+1 :green_heart:
javac
2m  0s
the patch passed

+1 :green_heart:
shadedjars
6m 35s
patch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
1m 28s
the patch passed

_ Other Tests _

+1 :green_heart:
unit
1m  8s
hbase-client in the patch passed.

-1 :x:
unit
138m  1s
hbase-server in the patch failed.

+1 :green_heart:
unit
10m 43s
hbase-mapreduce in the patch passed.

182m 52s

Subsystem
Report/Notes

Docker
ClientAPI=1.40 ServerAPI=1.40 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2745/1/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/2745

JIRA Issue
HBASE-25246

Optional Tests
javac javadoc unit shadedjars compile

uname
Linux e34c7c0cd5b9 4.15.0-65-generic #74-Ubuntu SMP Tue Sep 17 17:06:04 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
master / 9a72b27f38

Default Java
AdoptOpenJDK-11.0.6+10

unit
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2745/1/artifact/yetus-jdk11-hadoop3-check/output/patch-unit-hbase-server.txt

Test Results
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2745/1/testReport/

Max. process+thread count
3941 (vs. ulimit of 30000)

modules
C: hbase-client hbase-server hbase-mapreduce U: .

Console output
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2745/1/console

versions
git=2.17.1 maven=3.6.3

Powered by
Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
1m  3s
Docker mode activated.

-0 :warning:
yetus
0m  3s
Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck

_ Prechecks _

_ master Compile Tests _

+0 :ok:
mvndep
0m 22s
Maven dependency ordering for branch

+1 :green_heart:
mvninstall
4m  2s
master passed

+1 :green_heart:
compile
1m 47s
master passed

+1 :green_heart:
shadedjars
7m 10s
branch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
1m 16s
master passed

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 13s
Maven dependency ordering for patch

+1 :green_heart:
mvninstall
3m 55s
the patch passed

+1 :green_heart:
compile
1m 50s
the patch passed

+1 :green_heart:
javac
1m 50s
the patch passed

+1 :green_heart:
shadedjars
7m 10s
patch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
1m 16s
the patch passed

_ Other Tests _

+1 :green_heart:
unit
1m  8s
hbase-client in the patch passed.

+1 :green_heart:
unit
203m 19s
hbase-server in the patch passed.

+1 :green_heart:
unit
14m 31s
hbase-mapreduce in the patch passed.

251m 18s

Subsystem
Report/Notes

Docker
ClientAPI=1.40 ServerAPI=1.40 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2745/1/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/2745

JIRA Issue
HBASE-25246

Optional Tests
javac javadoc unit shadedjars compile

uname
Linux ce16f382b878 4.15.0-112-generic #113-Ubuntu SMP Thu Jul 9 23:41:39 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
master / 9a72b27f38

Default Java
AdoptOpenJDK-1.8.0_232-b09

Test Results
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2745/1/testReport/

Max. process+thread count
3235 (vs. ulimit of 30000)

modules
C: hbase-client hbase-server hbase-mapreduce U: .

Console output
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2745/1/console

versions
git=2.17.1 maven=3.6.3

Powered by
Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
0m 29s
Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s
No case conflicting files found.

+1 :green_heart:
hbaseanti
0m  0s
Patch does not have any anti-patterns.

+1 :green_heart:
@author
0m  0s
The patch does not contain any @author tags.

_ master Compile Tests _

+0 :ok:
mvndep
0m 13s
Maven dependency ordering for branch

+1 :green_heart:
mvninstall
3m 26s
master passed

+1 :green_heart:
checkstyle
1m 54s
master passed

+1 :green_heart:
spotbugs
3m 35s
master passed

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 13s
Maven dependency ordering for patch

+1 :green_heart:
mvninstall
3m 25s
the patch passed

+1 :green_heart:
checkstyle
1m 56s
the patch passed

+1 :green_heart:
whitespace
0m  0s
The patch has no whitespace issues.

+1 :green_heart:
hadoopcheck
16m 52s
Patch does not cause any errors with Hadoop 3.1.2 3.2.1 3.3.0.

+1 :green_heart:
spotbugs
4m  7s
the patch passed

_ Other Tests _

+1 :green_heart:
asflicense
0m 37s
The patch does not generate ASF License warnings.

44m 45s

Subsystem
Report/Notes

Docker
ClientAPI=1.40 ServerAPI=1.40 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2745/2/artifact/yetus-general-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/2745

JIRA Issue
HBASE-25246

Optional Tests
dupname asflicense spotbugs hadoopcheck hbaseanti checkstyle

uname
Linux f61f15e4c9ca 4.15.0-112-generic #113-Ubuntu SMP Thu Jul 9 23:41:39 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
master / fb6e498b32

Max. process+thread count
94 (vs. ulimit of 30000)

modules
C: hbase-client hbase-server hbase-mapreduce U: .

Console output
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2745/2/console

versions
git=2.17.1 maven=3.6.3 spotbugs=3.1.12

Powered by
Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
1m  5s
Docker mode activated.

-0 :warning:
yetus
0m  3s
Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck

_ Prechecks _

_ master Compile Tests _

+0 :ok:
mvndep
0m 13s
Maven dependency ordering for branch

+1 :green_heart:
mvninstall
3m 59s
master passed

+1 :green_heart:
compile
2m  8s
master passed

+1 :green_heart:
shadedjars
6m 46s
branch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
1m 27s
master passed

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 16s
Maven dependency ordering for patch

+1 :green_heart:
mvninstall
4m 12s
the patch passed

+1 :green_heart:
compile
2m  9s
the patch passed

+1 :green_heart:
javac
2m  9s
the patch passed

+1 :green_heart:
shadedjars
6m 49s
patch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
1m 27s
the patch passed

_ Other Tests _

+1 :green_heart:
unit
1m  6s
hbase-client in the patch passed.

+1 :green_heart:
unit
142m 23s
hbase-server in the patch passed.

+1 :green_heart:
unit
14m 23s
hbase-mapreduce in the patch passed.

191m  2s

Subsystem
Report/Notes

Docker
ClientAPI=1.40 ServerAPI=1.40 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2745/2/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/2745

JIRA Issue
HBASE-25246

Optional Tests
javac javadoc unit shadedjars compile

uname
Linux d2c973f34d9f 4.15.0-65-generic #74-Ubuntu SMP Tue Sep 17 17:06:04 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
master / fb6e498b32

Default Java
AdoptOpenJDK-11.0.6+10

Test Results
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2745/2/testReport/

Max. process+thread count
3992 (vs. ulimit of 30000)

modules
C: hbase-client hbase-server hbase-mapreduce U: .

Console output
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2745/2/console

versions
git=2.17.1 maven=3.6.3

Powered by
Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
1m  3s
Docker mode activated.

-0 :warning:
yetus
0m  3s
Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck

_ Prechecks _

_ master Compile Tests _

+0 :ok:
mvndep
0m 26s
Maven dependency ordering for branch

+1 :green_heart:
mvninstall
4m  0s
master passed

+1 :green_heart:
compile
1m 47s
master passed

+1 :green_heart:
shadedjars
7m 12s
branch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
1m 17s
master passed

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 14s
Maven dependency ordering for patch

+1 :green_heart:
mvninstall
3m 49s
the patch passed

+1 :green_heart:
compile
1m 48s
the patch passed

+1 :green_heart:
javac
1m 48s
the patch passed

+1 :green_heart:
shadedjars
7m 12s
patch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
1m 16s
the patch passed

_ Other Tests _

+1 :green_heart:
unit
1m  8s
hbase-client in the patch passed.

+1 :green_heart:
unit
232m 52s
hbase-server in the patch passed.

+1 :green_heart:
unit
19m 31s
hbase-mapreduce in the patch passed.

287m 12s

Subsystem
Report/Notes

Docker
ClientAPI=1.40 ServerAPI=1.40 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2745/2/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/2745

JIRA Issue
HBASE-25246

Optional Tests
javac javadoc unit shadedjars compile

uname
Linux dbe0fe84efcc 4.15.0-112-generic #113-Ubuntu SMP Thu Jul 9 23:41:39 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
master / fb6e498b32

Default Java
AdoptOpenJDK-1.8.0_232-b09

Test Results
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2745/2/testReport/

Max. process+thread count
3315 (vs. ulimit of 30000)

modules
C: hbase-client hbase-server hbase-mapreduce U: .

Console output
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2745/2/console

versions
git=2.17.1 maven=3.6.3

Powered by
Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@anoopsjohn  Could you please provide your feedback. Thank you !!

Thank you @anoopsjohn  and @virajjasani  for your offline help. Could you guys please review the changes. Thank you !

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
0m 31s
Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s
No case conflicting files found.

+1 :green_heart:
hbaseanti
0m  0s
Patch does not have any anti-patterns.

+1 :green_heart:
@author
0m  0s
The patch does not contain any @author tags.

_ master Compile Tests _

+0 :ok:
mvndep
0m 37s
Maven dependency ordering for branch

+1 :green_heart:
mvninstall
3m 33s
master passed

+1 :green_heart:
checkstyle
1m 55s
master passed

+1 :green_heart:
spotbugs
3m 38s
master passed

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 13s
Maven dependency ordering for patch

+1 :green_heart:
mvninstall
3m 28s
the patch passed

+1 :green_heart:
checkstyle
1m 55s
the patch passed

+1 :green_heart:
whitespace
0m  0s
The patch has no whitespace issues.

+1 :green_heart:
hadoopcheck
17m 12s
Patch does not cause any errors with Hadoop 3.1.2 3.2.1 3.3.0.

+1 :green_heart:
spotbugs
4m  6s
the patch passed

_ Other Tests _

+1 :green_heart:
asflicense
0m 38s
The patch does not generate ASF License warnings.

45m 39s

Subsystem
Report/Notes

Docker
ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2745/3/artifact/yetus-general-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/2745

JIRA Issue
HBASE-25246

Optional Tests
dupname asflicense spotbugs hadoopcheck hbaseanti checkstyle

uname
Linux 6c4fa894bec6 4.15.0-112-generic #113-Ubuntu SMP Thu Jul 9 23:41:39 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
master /<PHONE_NUMBER>

Max. process+thread count
94 (vs. ulimit of 30000)

modules
C: hbase-client hbase-server hbase-mapreduce U: .

Console output
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2745/3/console

versions
git=2.17.1 maven=3.6.3 spotbugs=3.1.12

Powered by
Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
1m  4s
Docker mode activated.

-0 :warning:
yetus
0m  3s
Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck

_ Prechecks _

_ master Compile Tests _

+0 :ok:
mvndep
0m 22s
Maven dependency ordering for branch

+1 :green_heart:
mvninstall
4m 13s
master passed

+1 :green_heart:
compile
2m  2s
master passed

+1 :green_heart:
shadedjars
6m 40s
branch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
1m 29s
master passed

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 16s
Maven dependency ordering for patch

+1 :green_heart:
mvninstall
4m  4s
the patch passed

+1 :green_heart:
compile
2m  4s
the patch passed

+1 :green_heart:
javac
2m  4s
the patch passed

+1 :green_heart:
shadedjars
6m 40s
patch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
1m 27s
the patch passed

_ Other Tests _

+1 :green_heart:
unit
1m  8s
hbase-client in the patch passed.

+1 :green_heart:
unit
137m 22s
hbase-server in the patch passed.

+1 :green_heart:
unit
11m  3s
hbase-mapreduce in the patch passed.

182m 41s

Subsystem
Report/Notes

Docker
ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2745/3/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/2745

JIRA Issue
HBASE-25246

Optional Tests
javac javadoc unit shadedjars compile

uname
Linux 8d8a4f8dfdf5 4.15.0-65-generic #74-Ubuntu SMP Tue Sep 17 17:06:04 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
master /<PHONE_NUMBER>

Default Java
AdoptOpenJDK-11.0.6+10

Test Results
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2745/3/testReport/

Max. process+thread count
4087 (vs. ulimit of 30000)

modules
C: hbase-client hbase-server hbase-mapreduce U: .

Console output
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2745/3/console

versions
git=2.17.1 maven=3.6.3

Powered by
Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
1m 24s
Docker mode activated.

-0 :warning:
yetus
0m  3s
Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck

_ Prechecks _

_ master Compile Tests _

+0 :ok:
mvndep
0m 21s
Maven dependency ordering for branch

+1 :green_heart:
mvninstall
4m 21s
master passed

+1 :green_heart:
compile
2m  9s
master passed

+1 :green_heart:
shadedjars
7m 24s
branch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
1m 24s
master passed

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 15s
Maven dependency ordering for patch

+1 :green_heart:
mvninstall
4m  6s
the patch passed

+1 :green_heart:
compile
2m  2s
the patch passed

+1 :green_heart:
javac
2m  2s
the patch passed

+1 :green_heart:
shadedjars
7m 34s
patch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
1m 26s
the patch passed

_ Other Tests _

+1 :green_heart:
unit
1m 21s
hbase-client in the patch passed.

+1 :green_heart:
unit
230m 23s
hbase-server in the patch passed.

+1 :green_heart:
unit
14m 47s
hbase-mapreduce in the patch passed.

281m 12s

Subsystem
Report/Notes

Docker
ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2745/3/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/2745

JIRA Issue
HBASE-25246

Optional Tests
javac javadoc unit shadedjars compile

uname
Linux 45329940c8c0 4.15.0-112-generic #113-Ubuntu SMP Thu Jul 9 23:41:39 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
master /<PHONE_NUMBER>

Default Java
AdoptOpenJDK-1.8.0_232-b09

Test Results
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2745/3/testReport/

Max. process+thread count
3427 (vs. ulimit of 30000)

modules
C: hbase-client hbase-server hbase-mapreduce U: .

Console output
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2745/3/console

versions
git=2.17.1 maven=3.6.3

Powered by
Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
1m 29s
Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s
No case conflicting files found.

+1 :green_heart:
hbaseanti
0m  0s
Patch does not have any anti-patterns.

+1 :green_heart:
@author
0m  0s
The patch does not contain any @author tags.

_ master Compile Tests _

+0 :ok:
mvndep
0m 22s
Maven dependency ordering for branch

+1 :green_heart:
mvninstall
4m  8s
master passed

+1 :green_heart:
checkstyle
2m  3s
master passed

+1 :green_heart:
spotbugs
4m  0s
master passed

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 13s
Maven dependency ordering for patch

+1 :green_heart:
mvninstall
3m 56s
the patch passed

+1 :green_heart:
checkstyle
1m 59s
the patch passed

+1 :green_heart:
whitespace
0m  0s
The patch has no whitespace issues.

+1 :green_heart:
hadoopcheck
19m 21s
Patch does not cause any errors with Hadoop 3.1.2 3.2.1 3.3.0.

+1 :green_heart:
spotbugs
4m 18s
the patch passed

_ Other Tests _

+1 :green_heart:
asflicense
0m 32s
The patch does not generate ASF License warnings.

50m 37s

Subsystem
Report/Notes

Docker
ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2745/4/artifact/yetus-general-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/2745

JIRA Issue
HBASE-25246

Optional Tests
dupname asflicense spotbugs hadoopcheck hbaseanti checkstyle

uname
Linux b40041f4f5cf 4.15.0-112-generic #113-Ubuntu SMP Thu Jul 9 23:41:39 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
master / 7a532f8328

Max. process+thread count
84 (vs. ulimit of 30000)

modules
C: hbase-client hbase-server hbase-mapreduce U: .

Console output
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2745/4/console

versions
git=2.17.1 maven=3.6.3 spotbugs=3.1.12

Powered by
Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
1m 13s
Docker mode activated.

-0 :warning:
yetus
0m  3s
Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck

_ Prechecks _

_ master Compile Tests _

+0 :ok:
mvndep
0m 26s
Maven dependency ordering for branch

+1 :green_heart:
mvninstall
4m  6s
master passed

+1 :green_heart:
compile
2m  4s
master passed

+1 :green_heart:
shadedjars
6m 43s
branch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
1m 31s
master passed

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 16s
Maven dependency ordering for patch

+1 :green_heart:
mvninstall
4m  7s
the patch passed

+1 :green_heart:
compile
2m  4s
the patch passed

+1 :green_heart:
javac
2m  4s
the patch passed

+1 :green_heart:
shadedjars
6m 38s
patch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
1m 30s
the patch passed

_ Other Tests _

+1 :green_heart:
unit
1m  6s
hbase-client in the patch passed.

+1 :green_heart:
unit
139m 42s
hbase-server in the patch passed.

+1 :green_heart:
unit
11m 13s
hbase-mapreduce in the patch passed.

185m 19s

Subsystem
Report/Notes

Docker
ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2745/4/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/2745

JIRA Issue
HBASE-25246

Optional Tests
javac javadoc unit shadedjars compile

uname
Linux 60e0c87b0b19 4.15.0-65-generic #74-Ubuntu SMP Tue Sep 17 17:06:04 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
master / 7a532f8328

Default Java
AdoptOpenJDK-11.0.6+10

Test Results
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2745/4/testReport/

Max. process+thread count
3812 (vs. ulimit of 30000)

modules
C: hbase-client hbase-server hbase-mapreduce U: .

Console output
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2745/4/console

versions
git=2.17.1 maven=3.6.3

Powered by
Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
1m  9s
Docker mode activated.

-0 :warning:
yetus
0m  3s
Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck

_ Prechecks _

_ master Compile Tests _

+0 :ok:
mvndep
0m 29s
Maven dependency ordering for branch

+1 :green_heart:
mvninstall
4m  2s
master passed

+1 :green_heart:
compile
1m 54s
master passed

+1 :green_heart:
shadedjars
7m 18s
branch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
1m 17s
master passed

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 14s
Maven dependency ordering for patch

+1 :green_heart:
mvninstall
3m 58s
the patch passed

+1 :green_heart:
compile
1m 52s
the patch passed

+1 :green_heart:
javac
1m 52s
the patch passed

+1 :green_heart:
shadedjars
7m 16s
patch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
1m 18s
the patch passed

_ Other Tests _

+1 :green_heart:
unit
1m 11s
hbase-client in the patch passed.

+1 :green_heart:
unit
207m 38s
hbase-server in the patch passed.

+1 :green_heart:
unit
15m  2s
hbase-mapreduce in the patch passed.

256m 46s

Subsystem
Report/Notes

Docker
ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2745/4/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/2745

JIRA Issue
HBASE-25246

Optional Tests
javac javadoc unit shadedjars compile

uname
Linux<PHONE_NUMBER>5f 4.15.0-112-generic #113-Ubuntu SMP Thu Jul 9 23:41:39 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
master / 7a532f8328

Default Java
AdoptOpenJDK-1.8.0_232-b09

Test Results
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2745/4/testReport/

Max. process+thread count
3386 (vs. ulimit of 30000)

modules
C: hbase-client hbase-server hbase-mapreduce U: .

Console output
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2745/4/console

versions
git=2.17.1 maven=3.6.3

Powered by
Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
2m 45s
Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s
No case conflicting files found.

+1 :green_heart:
hbaseanti
0m  0s
Patch does not have any anti-patterns.

+1 :green_heart:
@author
0m  0s
The patch does not contain any @author tags.

_ master Compile Tests _

+0 :ok:
mvndep
0m 27s
Maven dependency ordering for branch

+1 :green_heart:
mvninstall
3m 58s
master passed

+1 :green_heart:
checkstyle
2m 28s
master passed

+0 :ok:
refguide
3m 58s
branch has no errors when building the reference guide. See footer for rendered docs, which you should manually inspect.

+1 :green_heart:
spotbugs
15m 48s
master passed

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 14s
Maven dependency ordering for patch

+1 :green_heart:
mvninstall
4m  6s
the patch passed

+1 :green_heart:
checkstyle
2m 20s
the patch passed

+1 :green_heart:
whitespace
0m  0s
The patch has no whitespace issues.

+0 :ok:
refguide
3m 53s
patch has no errors when building the reference guide. See footer for rendered docs, which you should manually inspect.

+1 :green_heart:
hadoopcheck
21m 22s
Patch does not cause any errors with Hadoop 3.1.2 3.2.1 3.3.0.

+1 :green_heart:
spotbugs
18m 19s
the patch passed

_ Other Tests _

+1 :green_heart:
asflicense
0m 54s
The patch does not generate ASF License warnings.

91m  4s

Subsystem
Report/Notes

Docker
ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2745/5/artifact/yetus-general-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/2745

JIRA Issue
HBASE-25246

Optional Tests
dupname asflicense spotbugs hadoopcheck hbaseanti checkstyle refguide

uname
Linux 8a9496c2edbe 4.15.0-112-generic #113-Ubuntu SMP Thu Jul 9 23:41:39 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
master / d50816fe44

refguide
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2745/5/artifact/yetus-general-check/output/branch-site/book.html

refguide
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2745/5/artifact/yetus-general-check/output/patch-site/book.html

Max. process+thread count
122 (vs. ulimit of 30000)

modules
C: hbase-client hbase-server hbase-mapreduce . U: .

Console output
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2745/5/console

versions
git=2.17.1 maven=3.6.3 spotbugs=3.1.12

Powered by
Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
2m 43s
Docker mode activated.

-0 :warning:
yetus
0m  3s
Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck

_ Prechecks _

_ master Compile Tests _

+0 :ok:
mvndep
0m 26s
Maven dependency ordering for branch

+1 :green_heart:
mvninstall
4m  9s
master passed

+1 :green_heart:
compile
2m 49s
master passed

+1 :green_heart:
shadedjars
6m 38s
branch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
4m  5s
master passed

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 12s
Maven dependency ordering for patch

+1 :green_heart:
mvninstall
4m  3s
the patch passed

+1 :green_heart:
compile
2m 47s
the patch passed

+1 :green_heart:
javac
2m 47s
the patch passed

+1 :green_heart:
shadedjars
6m 38s
patch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
4m  6s
the patch passed

_ Other Tests _

+1 :green_heart:
unit
175m 39s
root in the patch passed.

217m 43s

Subsystem
Report/Notes

Docker
ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2745/5/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/2745

JIRA Issue
HBASE-25246

Optional Tests
javac javadoc unit shadedjars compile

uname
Linux ed17bffb66f4 4.15.0-65-generic #74-Ubuntu SMP Tue Sep 17 17:06:04 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
master / d50816fe44

Default Java
AdoptOpenJDK-11.0.6+10

Test Results
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2745/5/testReport/

Max. process+thread count
6661 (vs. ulimit of 30000)

modules
C: hbase-client hbase-server hbase-mapreduce . U: .

Console output
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2745/5/console

versions
git=2.17.1 maven=3.6.3

Powered by
Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
1m 34s
Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s
No case conflicting files found.

+1 :green_heart:
hbaseanti
0m  0s
Patch does not have any anti-patterns.

+1 :green_heart:
@author
0m  0s
The patch does not contain any @author tags.

_ master Compile Tests _

+0 :ok:
mvndep
0m 23s
Maven dependency ordering for branch

+1 :green_heart:
mvninstall
4m 10s
master passed

+1 :green_heart:
checkstyle
2m 19s
master passed

+0 :ok:
refguide
4m 16s
branch has no errors when building the reference guide. See footer for rendered docs, which you should manually inspect.

+1 :green_heart:
spotbugs
15m 29s
master passed

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 13s
Maven dependency ordering for patch

+1 :green_heart:
mvninstall
3m 58s
the patch passed

+1 :green_heart:
checkstyle
2m 41s
the patch passed

+1 :green_heart:
whitespace
0m  0s
The patch has no whitespace issues.

+0 :ok:
refguide
4m 36s
patch has no errors when building the reference guide. See footer for rendered docs, which you should manually inspect.

+1 :green_heart:
hadoopcheck
21m 50s
Patch does not cause any errors with Hadoop 3.1.2 3.2.1 3.3.0.

+1 :green_heart:
spotbugs
14m 23s
the patch passed

_ Other Tests _

+1 :green_heart:
asflicense
0m 45s
The patch does not generate ASF License warnings.

85m 15s

Subsystem
Report/Notes

Docker
ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2745/6/artifact/yetus-general-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/2745

JIRA Issue
HBASE-25246

Optional Tests
dupname asflicense spotbugs hadoopcheck hbaseanti checkstyle refguide

uname
Linux af3c98939729 4.15.0-112-generic #113-Ubuntu SMP Thu Jul 9 23:41:39 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
master / d50816fe44

refguide
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2745/6/artifact/yetus-general-check/output/branch-site/book.html

refguide
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2745/6/artifact/yetus-general-check/output/patch-site/book.html

Max. process+thread count
122 (vs. ulimit of 30000)

modules
C: hbase-client hbase-server hbase-mapreduce . U: .

Console output
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2745/6/console

versions
git=2.17.1 maven=3.6.3 spotbugs=3.1.12

Powered by
Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
1m 10s
Docker mode activated.

-0 :warning:
yetus
0m  3s
Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck

_ Prechecks _

_ master Compile Tests _

+0 :ok:
mvndep
0m 26s
Maven dependency ordering for branch

+1 :green_heart:
mvninstall
4m 24s
master passed

+1 :green_heart:
compile
3m  2s
master passed

+1 :green_heart:
shadedjars
7m  4s
branch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
4m 24s
master passed

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 14s
Maven dependency ordering for patch

+1 :green_heart:
mvninstall
4m 23s
the patch passed

+1 :green_heart:
compile
2m 53s
the patch passed

+1 :green_heart:
javac
2m 53s
the patch passed

+1 :green_heart:
shadedjars
8m 10s
patch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
4m 32s
the patch passed

_ Other Tests _

-1 :x:
unit
163m  9s
root in the patch failed.

206m 15s

Subsystem
Report/Notes

Docker
ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2745/6/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/2745

JIRA Issue
HBASE-25246

Optional Tests
javac javadoc unit shadedjars compile

uname
Linux 23218a5db8c7 4.15.0-65-generic #74-Ubuntu SMP Tue Sep 17 17:06:04 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
master / d50816fe44

Default Java
AdoptOpenJDK-11.0.6+10

unit
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2745/6/artifact/yetus-jdk11-hadoop3-check/output/patch-unit-root.txt

Test Results
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2745/6/testReport/

Max. process+thread count
3716 (vs. ulimit of 30000)

modules
C: hbase-client hbase-server hbase-mapreduce . U: .

Console output
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2745/6/console

versions
git=2.17.1 maven=3.6.3

Powered by
Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

This seems relevant?
[ERROR] Failures:
[ERROR] org.apache.hadoop.hbase.replication.multiwal.TestReplicationEndpointWithMultipleAsyncWAL.testInterClusterReplication
[ERROR]   Run 1: TestReplicationEndpointWithMultipleAsyncWAL>TestReplicationEndpoint.testInterClusterReplication:243 Waiting timed out after [30,000] msec Failed to replicate all edits, expected = 2500 replicated = 2499
[ERROR]   Run 2: TestReplicationEndpointWithMultipleAsyncWAL>TestReplicationEndpoint.testInterClusterReplication:243 Waiting timed out after [30,000] msec Failed to replicate all edits, expected = 2500 replicated = 2400
[ERROR]   Run 3: TestReplicationEndpointWithMultipleAsyncWAL>TestReplicationEndpoint.testInterClusterReplication:243 Waiting timed out after [30,000] msec Failed to replicate all edits, expected = 2500 replicated = 3031
[INFO]

Failed test TestReplicationEndpointWithMultipleAsyncWAL ran successfully locally.
[INFO] -------------------------------------------------------
[INFO]  T E S T S
[INFO] -------------------------------------------------------
[INFO] Running org.apache.hadoop.hbase.replication.multiwal.TestReplicationEndpointWithMultipleAsyncWAL
[INFO] Tests run: 7, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 106.975 s - in org.apache.hadoop.hbase.replication.multiwal.TestReplicationEndpointWithMultipleAsyncWAL
[INFO]
[INFO] Results:
[INFO]
[INFO] Tests run: 7, Failures: 0, Errors: 0, Skipped: 0
[INFO]

@virajjasani  Added test case according to your feedback. Thank you !

Thanks @shahrs87 , after QA results, this is good to go.

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
0m 36s
Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s
No case conflicting files found.

+1 :green_heart:
hbaseanti
0m  0s
Patch does not have any anti-patterns.

+1 :green_heart:
@author
0m  0s
The patch does not contain any @author tags.

_ master Compile Tests _

+0 :ok:
mvndep
0m 24s
Maven dependency ordering for branch

+1 :green_heart:
mvninstall
3m 54s
master passed

+1 :green_heart:
checkstyle
2m 44s
master passed

+0 :ok:
refguide
4m 40s
branch has no errors when building the reference guide. See footer for rendered docs, which you should manually inspect.

+1 :green_heart:
spotbugs
16m  5s
master passed

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 15s
Maven dependency ordering for patch

+1 :green_heart:
mvninstall
4m 47s
the patch passed

+1 :green_heart:
checkstyle
2m 52s
the patch passed

+1 :green_heart:
whitespace
0m  0s
The patch has no whitespace issues.

+0 :ok:
refguide
4m 51s
patch has no errors when building the reference guide. See footer for rendered docs, which you should manually inspect.

+1 :green_heart:
hadoopcheck
22m 26s
Patch does not cause any errors with Hadoop 3.1.2 3.2.1 3.3.0.

+1 :green_heart:
spotbugs
16m 53s
the patch passed

_ Other Tests _

+1 :green_heart:
asflicense
0m 53s
The patch does not generate ASF License warnings.

91m 33s

Subsystem
Report/Notes

Docker
ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2745/8/artifact/yetus-general-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/2745

JIRA Issue
HBASE-25246

Optional Tests
dupname asflicense spotbugs hadoopcheck hbaseanti checkstyle refguide

uname
Linux 25d55069f2e5 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
master / d50816fe44

refguide
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2745/8/artifact/yetus-general-check/output/branch-site/book.html

refguide
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2745/8/artifact/yetus-general-check/output/patch-site/book.html

Max. process+thread count
138 (vs. ulimit of 30000)

modules
C: hbase-client hbase-server hbase-mapreduce . U: .

Console output
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2745/8/console

versions
git=2.17.1 maven=3.6.3 spotbugs=3.1.12

Powered by
Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
0m 38s
Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s
No case conflicting files found.

+1 :green_heart:
hbaseanti
0m  0s
Patch does not have any anti-patterns.

+1 :green_heart:
@author
0m  0s
The patch does not contain any @author tags.

_ master Compile Tests _

+0 :ok:
mvndep
0m 18s
Maven dependency ordering for branch

+1 :green_heart:
mvninstall
4m 31s
master passed

+1 :green_heart:
checkstyle
2m 41s
master passed

+0 :ok:
refguide
4m 35s
branch has no errors when building the reference guide. See footer for rendered docs, which you should manually inspect.

+1 :green_heart:
spotbugs
16m 53s
master passed

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 13s
Maven dependency ordering for patch

+1 :green_heart:
mvninstall
3m 44s
the patch passed

+1 :green_heart:
checkstyle
2m  0s
the patch passed

+1 :green_heart:
whitespace
0m  0s
The patch has no whitespace issues.

+0 :ok:
refguide
3m 24s
patch has no errors when building the reference guide. See footer for rendered docs, which you should manually inspect.

+1 :green_heart:
hadoopcheck
17m 13s
Patch does not cause any errors with Hadoop 3.1.2 3.2.1 3.3.0.

+1 :green_heart:
spotbugs
13m  9s
the patch passed

_ Other Tests _

+1 :green_heart:
asflicense
0m 53s
The patch does not generate ASF License warnings.

78m 25s

Subsystem
Report/Notes

Docker
ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2745/9/artifact/yetus-general-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/2745

JIRA Issue
HBASE-25246

Optional Tests
dupname asflicense spotbugs hadoopcheck hbaseanti checkstyle refguide

uname
Linux e84c716ba4af 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
master / d50816fe44

refguide
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2745/9/artifact/yetus-general-check/output/branch-site/book.html

refguide
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2745/9/artifact/yetus-general-check/output/patch-site/book.html

Max. process+thread count
138 (vs. ulimit of 30000)

modules
C: hbase-client hbase-server hbase-mapreduce . U: .

Console output
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2745/9/console

versions
git=2.17.1 maven=3.6.3 spotbugs=3.1.12

Powered by
Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
1m 54s
Docker mode activated.

-0 :warning:
yetus
0m  3s
Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck

_ Prechecks _

_ master Compile Tests _

+0 :ok:
mvndep
0m 23s
Maven dependency ordering for branch

+1 :green_heart:
mvninstall
5m 15s
master passed

+1 :green_heart:
compile
3m 28s
master passed

+1 :green_heart:
shadedjars
7m 47s
branch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
4m 41s
master passed

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 13s
Maven dependency ordering for patch

+1 :green_heart:
mvninstall
4m 31s
the patch passed

+1 :green_heart:
compile
3m 19s
the patch passed

+1 :green_heart:
javac
3m 19s
the patch passed

+1 :green_heart:
shadedjars
7m 52s
patch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
5m 14s
the patch passed

_ Other Tests _

+1 :green_heart:
unit
187m 58s
root in the patch passed.

235m 18s

Subsystem
Report/Notes

Docker
ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2745/9/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/2745

JIRA Issue
HBASE-25246

Optional Tests
javac javadoc unit shadedjars compile

uname
Linux f4a7dba55820 4.15.0-112-generic #113-Ubuntu SMP Thu Jul 9 23:41:39 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
master / d50816fe44

Default Java
AdoptOpenJDK-11.0.6+10

Test Results
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2745/9/testReport/

Max. process+thread count
7160 (vs. ulimit of 30000)

modules
C: hbase-client hbase-server hbase-mapreduce . U: .

Console output
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2745/9/console

versions
git=2.17.1 maven=3.6.3

Powered by
Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
0m 44s
Docker mode activated.

-0 :warning:
yetus
0m  3s
Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck

_ Prechecks _

_ master Compile Tests _

+0 :ok:
mvndep
0m 30s
Maven dependency ordering for branch

+1 :green_heart:
mvninstall
4m 50s
master passed

+1 :green_heart:
compile
2m 56s
master passed

+1 :green_heart:
shadedjars
8m 42s
branch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
4m 16s
master passed

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 14s
Maven dependency ordering for patch

+1 :green_heart:
mvninstall
4m 37s
the patch passed

+1 :green_heart:
compile
2m 36s
the patch passed

+1 :green_heart:
javac
2m 36s
the patch passed

+1 :green_heart:
shadedjars
6m 31s
patch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
3m 18s
the patch passed

_ Other Tests _

-1 :x:
unit
334m 37s
root in the patch failed.

376m 29s

Subsystem
Report/Notes

Docker
ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2745/9/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/2745

JIRA Issue
HBASE-25246

Optional Tests
javac javadoc unit shadedjars compile

uname
Linux 37406d813ce9 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
master / d50816fe44

Default Java
AdoptOpenJDK-1.8.0_232-b09

unit
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2745/9/artifact/yetus-jdk8-hadoop3-check/output/patch-unit-root.txt

Test Results
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2745/9/testReport/

Max. process+thread count
6476 (vs. ulimit of 30000)

modules
C: hbase-client hbase-server hbase-mapreduce . U: .

Console output
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2745/9/console

versions
git=2.17.1 maven=3.6.3

Powered by
Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
0m 33s
Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s
No case conflicting files found.

+1 :green_heart:
hbaseanti
0m  0s
Patch does not have any anti-patterns.

+1 :green_heart:
@author
0m  0s
The patch does not contain any @author tags.

_ master Compile Tests _

+0 :ok:
mvndep
0m 29s
Maven dependency ordering for branch

+1 :green_heart:
mvninstall
3m 26s
master passed

+1 :green_heart:
checkstyle
2m  3s
master passed

+0 :ok:
refguide
3m 23s
branch has no errors when building the reference guide. See footer for rendered docs, which you should manually inspect.

+1 :green_heart:
spotbugs
12m 21s
master passed

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 14s
Maven dependency ordering for patch

+1 :green_heart:
mvninstall
3m 29s
the patch passed

+1 :green_heart:
checkstyle
2m 29s
the patch passed

+1 :green_heart:
whitespace
0m  0s
The patch has no whitespace issues.

+0 :ok:
refguide
3m 26s
patch has no errors when building the reference guide. See footer for rendered docs, which you should manually inspect.

+1 :green_heart:
hadoopcheck
17m  6s
Patch does not cause any errors with Hadoop 3.1.2 3.2.1 3.3.0.

+1 :green_heart:
spotbugs
15m 40s
the patch passed

_ Other Tests _

+1 :green_heart:
asflicense
0m 52s
The patch does not generate ASF License warnings.

73m 49s

Subsystem
Report/Notes

Docker
ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2745/10/artifact/yetus-general-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/2745

JIRA Issue
HBASE-25246

Optional Tests
dupname asflicense spotbugs hadoopcheck hbaseanti checkstyle refguide

uname
Linux 65e80cadad18 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
master / d50816fe44

refguide
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2745/10/artifact/yetus-general-check/output/branch-site/book.html

refguide
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2745/10/artifact/yetus-general-check/output/patch-site/book.html

Max. process+thread count
139 (vs. ulimit of 30000)

modules
C: hbase-client hbase-server hbase-mapreduce . U: .

Console output
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2745/10/console

versions
git=2.17.1 maven=3.6.3 spotbugs=3.1.12

Powered by
Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
1m 42s
Docker mode activated.

-0 :warning:
yetus
0m  3s
Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck

_ Prechecks _

_ master Compile Tests _

+0 :ok:
mvndep
0m 21s
Maven dependency ordering for branch

+1 :green_heart:
mvninstall
4m 21s
master passed

+1 :green_heart:
compile
2m 51s
master passed

+1 :green_heart:
shadedjars
7m  0s
branch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
4m 26s
master passed

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 12s
Maven dependency ordering for patch

+1 :green_heart:
mvninstall
4m 12s
the patch passed

+1 :green_heart:
compile
2m 49s
the patch passed

+1 :green_heart:
javac
2m 49s
the patch passed

+1 :green_heart:
shadedjars
7m 32s
patch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
4m 36s
the patch passed

_ Other Tests _

+1 :green_heart:
unit
190m 37s
root in the patch passed.

233m 52s

Subsystem
Report/Notes

Docker
ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2745/10/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/2745

JIRA Issue
HBASE-25246

Optional Tests
javac javadoc unit shadedjars compile

uname
Linux 6adb003477c5 4.15.0-112-generic #113-Ubuntu SMP Thu Jul 9 23:41:39 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
master / d50816fe44

Default Java
AdoptOpenJDK-11.0.6+10

Test Results
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2745/10/testReport/

Max. process+thread count
6588 (vs. ulimit of 30000)

modules
C: hbase-client hbase-server hbase-mapreduce . U: .

Console output
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2745/10/console

versions
git=2.17.1 maven=3.6.3

Powered by
Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@shahrs87 TestIncrementalBackupWithBulkLoad looks suspicious, it's throwing NPE for the past 2 builds:
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2745/9/testReport/
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2745/10/testReport/
Can you once confirm locally? Unless quite many changes required, we can merge this soon anyways.

TestIncrementalBackup succeeds locally
[INFO] -------------------------------------------------------
[INFO]  T E S T S
[INFO] -------------------------------------------------------
[INFO] Running org.apache.hadoop.hbase.backup.TestIncrementalBackup

[INFO] Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 222.134 s - in org.apache.hadoop.hbase.backup.TestIncrementalBackup
[INFO]
[INFO] Results:
[INFO]
[INFO] Tests run: 1, Failures: 0, Errors: 0, Skipped: 0

@virajjasani

TestIncrementalBackupWithBulkLoad succeeds locally.
[INFO] -------------------------------------------------------
[INFO]  T E S T S
[INFO] -------------------------------------------------------
[INFO] Running org.apache.hadoop.hbase.backup.TestIncrementalBackupWithBulkLoad

[INFO] Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 221.513 s - in org.apache.hadoop.hbase.backup.TestIncrementalBackupWithBulkLoad
[INFO]

@virajjasani

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
0m 37s
Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  1s
No case conflicting files found.

+1 :green_heart:
hbaseanti
0m  0s
Patch does not have any anti-patterns.

+1 :green_heart:
@author
0m  0s
The patch does not contain any @author tags.

_ master Compile Tests _

+0 :ok:
mvndep
0m 25s
Maven dependency ordering for branch

+1 :green_heart:
mvninstall
3m 39s
master passed

+1 :green_heart:
checkstyle
2m  3s
master passed

+0 :ok:
refguide
3m 32s
branch has no errors when building the reference guide. See footer for rendered docs, which you should manually inspect.

+1 :green_heart:
spotbugs
12m 33s
master passed

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 13s
Maven dependency ordering for patch

+1 :green_heart:
mvninstall
3m 25s
the patch passed

+1 :green_heart:
checkstyle
2m  4s
the patch passed

+1 :green_heart:
whitespace
0m  0s
The patch has no whitespace issues.

+0 :ok:
refguide
3m 20s
patch has no errors when building the reference guide. See footer for rendered docs, which you should manually inspect.

+1 :green_heart:
hadoopcheck
18m 17s
Patch does not cause any errors with Hadoop 3.1.2 3.2.1 3.3.0.

+1 :green_heart:
spotbugs
14m  7s
the patch passed

_ Other Tests _

+1 :green_heart:
asflicense
0m 57s
The patch does not generate ASF License warnings.

74m 39s

Subsystem
Report/Notes

Docker
ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2745/11/artifact/yetus-general-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/2745

JIRA Issue
HBASE-25246

Optional Tests
dupname asflicense spotbugs hadoopcheck hbaseanti checkstyle refguide

uname
Linux ba9e3a7b127e 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
master / d50816fe44

refguide
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2745/11/artifact/yetus-general-check/output/branch-site/book.html

refguide
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2745/11/artifact/yetus-general-check/output/patch-site/book.html

Max. process+thread count
137 (vs. ulimit of 30000)

modules
C: hbase-client hbase-server hbase-mapreduce . U: .

Console output
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2745/11/console

versions
git=2.17.1 maven=3.6.3 spotbugs=3.1.12

Powered by
Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
1m 56s
Docker mode activated.

-0 :warning:
yetus
0m  4s
Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck

_ Prechecks _

_ master Compile Tests _

+0 :ok:
mvndep
0m 34s
Maven dependency ordering for branch

+1 :green_heart:
mvninstall
5m 29s
master passed

+1 :green_heart:
compile
3m 55s
master passed

+1 :green_heart:
shadedjars
8m 44s
branch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
5m 20s
master passed

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 15s
Maven dependency ordering for patch

+1 :green_heart:
mvninstall
5m 52s
the patch passed

+1 :green_heart:
compile
3m 54s
the patch passed

+1 :green_heart:
javac
3m 54s
the patch passed

+1 :green_heart:
shadedjars
9m  1s
patch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
5m 17s
the patch passed

_ Other Tests _

+1 :green_heart:
unit
184m 18s
root in the patch passed.

237m 43s

Subsystem
Report/Notes

Docker
ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2745/11/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/2745

JIRA Issue
HBASE-25246

Optional Tests
javac javadoc unit shadedjars compile

uname
Linux 1007169da2fc 4.15.0-65-generic #74-Ubuntu SMP Tue Sep 17 17:06:04 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
master / d50816fe44

Default Java
AdoptOpenJDK-11.0.6+10

Test Results
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2745/11/testReport/

Max. process+thread count
6560 (vs. ulimit of 30000)

modules
C: hbase-client hbase-server hbase-mapreduce . U: .

Console output
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2745/11/console

versions
git=2.17.1 maven=3.6.3

Powered by
Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
0m 29s
Docker mode activated.

-0 :warning:
yetus
0m  4s
Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck

_ Prechecks _

_ master Compile Tests _

+0 :ok:
mvndep
0m 14s
Maven dependency ordering for branch

+1 :green_heart:
mvninstall
3m 23s
master passed

+1 :green_heart:
compile
2m 19s
master passed

+1 :green_heart:
shadedjars
6m 47s
branch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
3m 21s
master passed

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 13s
Maven dependency ordering for patch

+1 :green_heart:
mvninstall
3m 28s
the patch passed

+1 :green_heart:
compile
2m 22s
the patch passed

+1 :green_heart:
javac
2m 22s
the patch passed

+1 :green_heart:
shadedjars
6m 28s
patch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
3m 19s
the patch passed

_ Other Tests _

-1 :x:
unit
261m 57s
root in the patch failed.

297m  3s

Subsystem
Report/Notes

Docker
ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2745/11/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/2745

JIRA Issue
HBASE-25246

Optional Tests
javac javadoc unit shadedjars compile

uname
Linux afc4e8329107 4.15.0-112-generic #113-Ubuntu SMP Thu Jul 9 23:41:39 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
master / d50816fe44

Default Java
AdoptOpenJDK-1.8.0_232-b09

unit
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2745/11/artifact/yetus-jdk8-hadoop3-check/output/patch-unit-root.txt

Test Results
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2745/11/testReport/

Max. process+thread count
3382 (vs. ulimit of 30000)

modules
C: hbase-client hbase-server hbase-mapreduce . U: .

Console output
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2745/11/console

versions
git=2.17.1 maven=3.6.3

Powered by
Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
0m 35s
Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s
No case conflicting files found.

+1 :green_heart:
hbaseanti
0m  0s
Patch does not have any anti-patterns.

+1 :green_heart:
@author
0m  0s
The patch does not contain any @author tags.

_ master Compile Tests _

+0 :ok:
mvndep
0m 24s
Maven dependency ordering for branch

+1 :green_heart:
mvninstall
4m 55s
master passed

+1 :green_heart:
checkstyle
2m 39s
master passed

+0 :ok:
refguide
4m 20s
branch has no errors when building the reference guide. See footer for rendered docs, which you should manually inspect.

+1 :green_heart:
spotbugs
12m 47s
master passed

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 14s
Maven dependency ordering for patch

+1 :green_heart:
mvninstall
3m 39s
the patch passed

+1 :green_heart:
checkstyle
2m 10s
the patch passed

+1 :green_heart:
whitespace
0m  0s
The patch has no whitespace issues.

+0 :ok:
refguide
3m 52s
patch has no errors when building the reference guide. See footer for rendered docs, which you should manually inspect.

+1 :green_heart:
hadoopcheck
17m 36s
Patch does not cause any errors with Hadoop 3.1.2 3.2.1 3.3.0.

+1 :green_heart:
spotbugs
13m 36s
the patch passed

_ Other Tests _

+1 :green_heart:
asflicense
0m 50s
The patch does not generate ASF License warnings.

76m  8s

Subsystem
Report/Notes

Docker
ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2745/12/artifact/yetus-general-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/2745

JIRA Issue
HBASE-25246

Optional Tests
dupname asflicense spotbugs hadoopcheck hbaseanti checkstyle refguide

uname
Linux 7eeb192d3220 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
master / c327680125

refguide
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2745/12/artifact/yetus-general-check/output/branch-site/book.html

refguide
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2745/12/artifact/yetus-general-check/output/patch-site/book.html

Max. process+thread count
137 (vs. ulimit of 30000)

modules
C: hbase-client hbase-server hbase-mapreduce . U: .

Console output
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2745/12/console

versions
git=2.17.1 maven=3.6.3 spotbugs=3.1.12

Powered by
Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
1m 12s
Docker mode activated.

-0 :warning:
yetus
0m  4s
Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck

_ Prechecks _

_ master Compile Tests _

+0 :ok:
mvndep
0m 25s
Maven dependency ordering for branch

+1 :green_heart:
mvninstall
4m  7s
master passed

+1 :green_heart:
compile
2m 52s
master passed

+1 :green_heart:
shadedjars
6m 42s
branch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
4m 25s
master passed

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 13s
Maven dependency ordering for patch

+1 :green_heart:
mvninstall
4m  3s
the patch passed

+1 :green_heart:
compile
2m 57s
the patch passed

+1 :green_heart:
javac
2m 57s
the patch passed

+1 :green_heart:
shadedjars
6m 56s
patch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
4m 21s
the patch passed

_ Other Tests _

+1 :green_heart:
unit
178m 55s
root in the patch passed.

221m  0s

Subsystem
Report/Notes

Docker
ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2745/12/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/2745

JIRA Issue
HBASE-25246

Optional Tests
javac javadoc unit shadedjars compile

uname
Linux bf59e0e01cd2 4.15.0-65-generic #74-Ubuntu SMP Tue Sep 17 17:06:04 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
master / c327680125

Default Java
AdoptOpenJDK-11.0.6+10

Test Results
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2745/12/testReport/

Max. process+thread count
6869 (vs. ulimit of 30000)

modules
C: hbase-client hbase-server hbase-mapreduce . U: .

Console output
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2745/12/console

versions
git=2.17.1 maven=3.6.3

Powered by
Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
0m 32s
Docker mode activated.

-0 :warning:
yetus
0m  3s
Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck

_ Prechecks _

_ master Compile Tests _

+0 :ok:
mvndep
0m 21s
Maven dependency ordering for branch

+1 :green_heart:
mvninstall
3m 41s
master passed

+1 :green_heart:
compile
2m 25s
master passed

+1 :green_heart:
shadedjars
6m 36s
branch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
3m 18s
master passed

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 13s
Maven dependency ordering for patch

+1 :green_heart:
mvninstall
3m 27s
the patch passed

+1 :green_heart:
compile
2m 16s
the patch passed

+1 :green_heart:
javac
2m 16s
the patch passed

+1 :green_heart:
shadedjars
6m 30s
patch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
3m 20s
the patch passed

_ Other Tests _

-1 :x:
unit
258m 28s
root in the patch failed.

293m 56s

Subsystem
Report/Notes

Docker
ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2745/12/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/2745

JIRA Issue
HBASE-25246

Optional Tests
javac javadoc unit shadedjars compile

uname
Linux 36105f308f81 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
master / c327680125

Default Java
AdoptOpenJDK-1.8.0_232-b09

unit
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2745/12/artifact/yetus-jdk8-hadoop3-check/output/patch-unit-root.txt

Test Results
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2745/12/testReport/

Max. process+thread count
3749 (vs. ulimit of 30000)

modules
C: hbase-client hbase-server hbase-mapreduce . U: .

Console output
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2745/12/console

versions
git=2.17.1 maven=3.6.3

Powered by
Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.


Optional Angular Icons

[x] I'm sure this issue is not a duplicate.

The Optional Angular icons are too close in color.  The tiny little badges for each shield are cute but are so hard to read they don't really provide assistance.

The two options I see are:

Change the Angular shield to the color of the backing technology (e.g orange for HTML, pink for Scss)
Use the HTML/Scss icons as a base and apply a tiny angular shield in the lower right. (basically invert the design) To me this actually makes a bit of sense. Its not really an Angular file, its a html file thats used by Angular.

More info: https://github.com/vscode-icons/vscode-icons#optional-angular-icons

@cgatian The thing is that Optional Angular Icons are optional. If you don't like them just remove the declarations from your settings and the icons shown will be the default of their file extension.

On Sun, Nov 19, 2017, 8:12 AM Jimi (Dimitris) Charalampidis <
<EMAIL_ADDRESS>wrote:

@cgatian https://github.com/cgatian The thing is that Optional Angular
Icons are optional. If you don't like them just remove the declarations
from your settings and the icons shown will be the default of their file
extension.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/vscode-icons/vscode-icons/issues/1279#issuecomment-345516010,
or mute the thread
https://github.com/notifications/unsubscribe-auth/ABq8agi9Z-t6M3SjLw189vCvFDitl6uLks5s4ClHgaJpZM4QAdiM
.

The thing is. The icons are small and indistinguishable. If I don't like  them Maybe I should use a different icon pack.

@cgatian, just some considerations:

You can use the icons you like most and associate them to your preferred file extensions by using our custom icons functionality.

I see that you have a point and we could certainly try your second proposal about inverting the icons. Nevertheless, I suspect we'll end up inverting the problem and some people may complain about the Angular icon being indistinguishable but, at least, if we have the 2 options people will be able to choose.

Finally, changing the icon set is indeed another option to consider and we encourage you to do so if you're not happy with the one you're using. I don't certainly understand why people uses this as some kind of threat in OSS projects. Plus, when they know (I see you contribute to some projects) that this is maintained by people dedicating their free time to a tool being used for free by anyone who is willing to do so.

That being said, I really think it's worth the effort to make a second optional Angular icon pack so users can have more options (this would include myself as an Angular dev :wink: ).

Closing this for good.


Fix Dropdown not accepting Number 0 on payload

Description
Dropdown box accepts number 0 on payload.
Related Issue(s)
Closes #661
Checklist

[ ] I have read the contribution guidelines
[ ] Suitable unit/system level tests have been added and they pass
[ ] Documentation has been updated

[ ] Upgrade instructions
[ ] Configuration details
[ ] Concepts

[ ] Changes flowforge.yml?

[ ] Issue/PR raised on FlowFuse/helm to update ConfigMap Template
[ ] Issue/PR raised on FlowFuse/CloudProject to update values for Staging/Production

Labels

[ ] Backport needed? -> add the backport label
[ ] Includes a DB migration? -> add the area:migration label

Hi
One of first times I have made a pull-request to GitHub.
Are the test failing something to to with my modifications? It seems that these errors are quite common in other PR's.
At least on the issues that is complaining appear to be working (Hide Page/Groups)


Intrusion Detection Plugin

OPNsense 24.1.9_4-amd64
FreeBSD 13.2-RELEASE-p11
OpenSSL 3.0.14
In this plugin after editing a rule to ether disable or enable the rule. Under policy and rule adjustment the rule only shows the id. It no longer shows the message indicating exactly what rule it is. You have to try to remember the rule id which is very tedious. Last time i remember the rule adjustments would list what the rule is.

This is an example of the message rule adjustments used to show. It still shows the message in the rules tab under administration.


AZCOPY_LOG_LOCATION

Which version of the AzCopy was used?
Note: The version is visible when running AzCopy without any argument
10.1.2
Which platform are you using? (ex: Windows, Mac, Linux)
Windows 10 64 bit
What command did you run?
Note: Please remove the SAS to avoid exposing your credentials. If you cannot remember the exact command, please retrieve it from the beginning of the log file.
set AZCOPY_LOG_LOCATION=c:\azcopy

What problem was encountered?
Log file location does not change.
How can we reproduce the problem in the simplest way?
Is this the correct way to change the log location?  Try in Windows Powershell.
Have you found a mitigation/solution?
I tried the same process for logs as described here but that didn't seem to work.

Are you sure you're setting your environment variables correctly?
I'm unable to reproduce this. I set my environment variables as following in powershell:
$env:AZCOPY_LOG_LOCATION="<wherever>"

I was pretty sure I wasn't setting it correctly but couldn't figure out the correct keystrokes.
Thanks.
brian

It worked great except the plans are still in the C:\Users\bbieber.azcopy\plans.

I just ran into this issue today actually. The documents here https://docs.microsoft.com/en-us/azure/storage/common/storage-use-azcopy-configure?toc=/azure/storage/blobs/toc.json dont really lay out the proper usage as adreed-msft has in the comment above. Not sure how to request an update on the docs, but it might not be a terrible idea to help others.

@normesta ?

Hello. This section of content describes how to set log file location - Change the location of plan and log files.

Yes, however, there is no "$" in the docs, which adreed-msft noted in the comment above and was needed to fix it. That's what is missing in the docs that made it work for me.

Oh, wow. Nice catches. I also am surprised the settings doesn't persist (tho, there's no config file to hold it that I saw so that makes sense). If you can call that out it would be appreciated for future folks to hopefully not end up back here. :)

I noticed that this setting doesn't persist after the session is closed but we don't document that behavior. Should we call this out?

I'm not sure @normesta. On one hand, it's standard behavior of environment variables. On the other hand, we are likely to have some users who aren't familiar with that standard behavior. So probably its worth mentioning it.

is it possible to set the AZCOPY_LOG_LOCATION to a folder on an azure storage account? For example setting it to a "logs" folder in the destination storage account.


Error with Livereload and Connect

the first and the second time it works correctly, but then i edit css again, save and Gulp gives error

Support questions http://stackoverflow.com/questions/tagged/gulp


Addition of eslint plugin

This pull request adds an eslint plugin which validates tsdoc comment blocks. This should resolve #154

 Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.:x: bafolts sign nowYou have signed the CLA already but the status is still pending? Let us recheck it.

I will make the suggested changes here and comment back when I am done. Thanks for the feedback.

I believe I have made all the suggested improvements. Let me know if there are any more.

Thanks so much for putting this together! This rule will be really useful.
Most of the remaining comments are fairly superficial, and they can probably be addressed in a follow-up PR if you like.

I have made all the requested changes. It appears something with the build is failing in the playground directory. If I update the @types/react-dom version to 16.9.3 locally I can fix the problem, but for the life of me I can't get rushstack to build with the version I specify in playground/package.json.

It's this old issue.  The TSDoc repo was serving as a guinea pig for the Yarn package manager, but Yarn really doesn't play well with DefinitelyTyped.  There's an active megathread where they're finally trying to sort this out.  @iclanton I wonder if we should just switch to PNPM for the time being?
I've pushed a fix to your branch.


PTVS incorrectly infers return type as int when it should be bool

In this case BankAccount.overdrawn is inferred to be (self) ->int
Should be (self) -> bool
class BankAccount(object):
    def __init__(self, initial_balance=0):
        self.balance = initial_balance
    def deposit(self, amount):
        self.balance += amount
    def withdraw(self, amount):
        self.balance -= amount
    def overdrawn(self):
        return self.balance < 0

class SecuredBankAccount(BankAccount):
    def withdraw(self, amount):
        if amount > 10000:
            print("must be verified")
        return super().withdraw(amount)

my_account = BankAccount(15)
my_account.withdraw(5)
print(my_account.balance)
print(my_account.overdrawn())

Microsoft Visual Studio Community 2017
Version 15.6.5
...
Python   15.6.18072.2
Interpreter: Python 3.6

Because of comparison chaining (e.g. 2 < 4 < 6), we need to treat the return type within an expression as the type of the "successful" value. Changing this is going to require adding a feature to the analyzer to determine the type of an overall expression instead of just evaluating it on each operation.
Not saying we won't do it, but it's currently working as designed.


Fixed Debian/Ubuntu packaging

This should close #3687

Tested on debian10, it fixes the issue #3687.

I confirm it work ... tested on scisoft12 without hdf5plugin installed.


Bug fix - In Async mode, if primary ASE is resulting in connection…

Bug fix - In Async mode, if primary ASE is resulting in connection timeouts, shifting to secondary ASE is not working.
BackupAseToken is not needed. Primary and Secondary ASE's in a cluster will use the same sideband auth token.

Business logic of shifting ASE endpoints:

The first time when handler configuration loads, currentEndpoint variable is set to the primaryAseEndPoint.
In case of ASE timeout/refused exceptions, shiftEndpoint method is called with the ASE endpoint that it tried as an argument.
The currentEndpoint value will be switched to the other endpoint that shiftEndpoint receives.
Ex: If shiftEndpoint receives primaryAseEndPoint as argument, currentEndpoint will be set to backupAseEndPoint. If
shiftEndpoint receives backupAseEndPoint as argument, currentEndpoint will be set to primaryAseEndPoint.


Reduce the raceyness of where we get the path attribute for Node objects

Previously if you had a module AND a symlink to that module in the same
node_modules tree then the value of the path attribute would
non-determinstic due to read-package-tree doing everything async.
This was causing intermittent failures on node 6.x.

Rubberstamp :sheep::rocket::fire: if this satisfies Travis.

You can cherry-pick 40ed972bd47704aa063cfac2154e5cf5e623d45e over into this PR (if you think that’s the right way to fix the CI failures, that is)

Hi just stumbled upon this issue because I was trying to profile read-package-tree and a fresh npm it of this repo isn't green. Is there anything I can do to help get this merged as I'd like to contribute more patches, but don't want travis yelling at me :-)

IIRC, most of this has actually already landed (as uh, sub-commit borrowings) and what remains won't improve things, I don't think.  The plan is to supersede this module with read-module-list, which needs a squash and more tests and to have the rpt interfaces finished.
They mostly work, I've patched it into npm before and most stuff is ok, but they're not yet filtering out everything that they should be, and there's also a decision to make about where we draw that line, some things probably should be included and sent on to npm that currently aren't. Also they don't currently iterate into symlinks, which is something we want to do conditionally.

oh mm, let me rerun Travis for this a few times and see if it actually is helping it stay green… if it is, there's no reason not to land it.

@iarna thanks for merging. With what you just said then, I shouldn't bother investigating this package's perf charactistics as it'll soon be superseded?


Imported channel missing tags in channel_list

The Issue
If you import a certificate into a wallet, it shows up in channel_list but there are missing tags which prevent it from being used in the LBRY app.
Missing on imported cert:

"can_sign": true (I can sign with it, so it should be there and true right?)
"category": "claim" (LBRY app looks for this, show "imported"?)
"confirmations": 7629 (Not a big deal, but should be consistent?)
"expiration_height": 634237 (Not a big deal, but should be consistent?)
"expired": false (Not a big deal, but should be consistent?)
"is_pending": false  (Not a big deal, but should be consistent?)
"is_spent": false,

Regular claim:
  {
    "address": "bU7B3xbdrL8bekSgv4UWXSoq9kyyasmJZt",
    "amount": 0.1,
    "blocks_to_expiration": 255345,
    "can_sign": true,
    "category": "claim",
    "claim_id": "d476653e7a24e5ea4c4011d4df47d602825a18b7",
    "confirmations": 7629,
    "decoded_claim": true,
    "expiration_height": 634237,
    "expired": false,
    "has_signature": false,
    "height": 371263,
    "hex": "08011002225e0801100322583056301006072a8648ce3d020106052b8104000a034200043d3ea2424bb25f7c47c7db1281d66761cf338f59dc1c5996e5d73293b0494eeb8333a39a07f0d7e62f72e1913fad83c3a5b321a252ade9d4c27149525802d978",
    "is_mine": true,
    "is_pending": false,
    "is_spent": false,
    "name": "@quickpubtest111",
    "nout": 0,
    "permanent_url": "@quickpubtest111#d476653e7a24e5ea4c4011d4df47d602825a18b7",
    "txid": "8ad35b26ecfe5a91afc54d51fe32e88cbb6d62791003c17df5ef2b7778b1bf32",
    "value": {
      "certificate": {
        "keyType": "SECP256k1",
        "publicKey": "3056301006072a8648ce3d020106052b8104000a034200043d3ea2424bb25f7c47c7db1281d66761cf338f59dc1c5996e5d73293b0494eeb8333a39a07f0d7e62f72e1913fad83c3a5b321a252ade9d4c27149525802d978",
        "version": "_0_0_1"
      },
      "claimType": "certificateType",
      "version": "_0_0_1"
    }
  },

Imported claim:
 {
    "address": "bJycBWVzfrktyTVf7ytYU4yBi67rK6cAaN",
    "amount": 0.01,
    "claim_id": "0d1fe0a3a2607bfdd4c263c668e895911341eee6",
    "claim_sequence": 1,
    "decoded_claim": true,
    "depth": 4392,
    "effective_amount": 0.01,
    "has_signature": false,
    "height": 374500,
    "hex": "08011002225e0801100322583056301006072a8648ce3d020106052b8104000a034200049446d78d14a0c491ba0c49689345a1c8adf44ee6bf22f23deb52128b37ed0ef446ddb56e3204f9f7c43c00f36998f75dca6045d0f6ae304955bc3645b8217783",
    "is_mine": false,
    "name": "@import-test",
    "nout": 0,
    "permanent_url": "@import-test#0d1fe0a3a2607bfdd4c263c668e895911341eee6",
    "supports": [],
    "txid": "f2f7357d4c4f0394afd72374405767e72f31702178388e108e40d81d38214c09",
    "valid_at_height": 374500,
    "value": {
      "certificate": {
        "keyType": "SECP256k1",
        "publicKey": "3056301006072a8648ce3d020106052b8104000a034200049446d78d14a0c491ba0c49689345a1c8adf44ee6bf22f23deb52128b37ed0ef446ddb56e3204f9f7c43c00f36998f75dca6045d0f6ae304955bc3645b8217783",
        "version": "_0_0_1"
      },
      "claimType": "certificateType",
      "version": "_0_0_1"
    }
  }

Steps to reproduce

Import a channel certificate
Run channel_list
Notice missing category flags

System Configuration

LBRY Daemon version:
LBRY App version:
LBRY Installation ID:
Operating system:

Anything Else

Screenshots

According to a convo with Lex, he will be importing wallet public keys along with channels, so this issue should be solved with the new wallet. Will confirm with @eukreign
@eukreign does channel_import / export already take this into account?

Closing per comments above, will will be dealt with in channel import/export (https://github.com/lbryio/lbry/issues/1409)


Replace http:// with https:// in cherokee links in docs/deploying

Replace http:// with https:// in cherokee links in docs/deploying.

fixes #4245

Please rebase to the 2.0.x branch.

@davidism
Thank you for your reviewing. I edited this PR to change its base to 2.0.x. Did I get what you meant?

You need to rebase and force push as well

@davidism
Thank you. Sorry but I didn't find how to modify this existing PR with git-rebase. I will recreate PR.

You can change the base branch to 2.0.x with the following commands:
git rebase --onto origin/2.0.x origin/main
git push -f

（By the way, change the commit message to something like "Update cherokee links in docs/deploying" will be more descriptive.）

@greyli
Thank you for your detailed commands. I have perhaps done it!

Not yet. When you did it, this PR will only contain one commit. Try to find more details about changing the base branch here.
I tried to force push this on my computer but failed. Did you enable the "Allow edits and access to secrets by maintainers" option on the bottom of the right sidebar on this page?

Hmm.. thank you and so sorry for your time. I think it's good to recreate PR after all...

Not yet. When you did it, this PR will only contain one commit. Try to find more details about changing the base branch here.

I made one commit with two files.

I tried to force push this on my computer but failed. Did you enable the "Allow edits and access to secrets by maintainers" option on the bottom of the right sidebar on this page?

Yes, off course.

Recreated as #4249 .


[CSS text-rendering] Update unoff spec link to CR

There's also a SVG2 draft spec on a new location (https://svgwg.org/svg2-draft/), I don't know if the CR will move to that location in the future... I would assume it is not preferred over the CR though.

Hey.. I'm new to this 😉

It's a bit confusing, but this feature is actually about using the property in HTML for the purpose of enabling high-quality kerning and ligatures, not the behavior in SVG. As the behavior in HTML is unspecified (see the note at https://developer.mozilla.org/en-US/docs/Web/CSS/text-rendering), the status is considered "unofficial".

You're right, how silly of me not to realize that. I should pay more attention, I roam alot of specs.
Anyhow, the updated link in this PR points to https://www.w3.org/TR/SVG2/ which is the successor of  https://www.w3.org/TR/SVG11/

I've just updated the link as well as the description, it should be a bit more clear now what this feature is about and the status of the property. Thanks!


Integration tests

Test the whole process from starting the server, sending a request and receiving some HTML.

We've got some good integration testing going now, check it out.
We have an issue with reading a large fixture file though, fs.readFileSync doesn't seem too great at this, see: https://stackoverflow.com/questions/25783161/asserting-files-that-have-the-same-content

@alex-page Nice, we'll switch to a hashing fixture model :)

Implemented with #31


Support for updated PSP handling for system-upgrade-controller (SUC) from charts

system-upgrade-controller (SUC) chart (https://github.com/rancher/charts/tree/dev-v2.7/charts/system-upgrade-controller) is a Managed Rancher chart currently used by RKE2/k3s v2prov provisioning framework to upgrade system-agent on downstream clusters' nodes. "Managed Rancher chart" here means the chart is automatically installed/uninstalled/upgraded without explicit user interaction.
The Issue
The chart currently deploys PSP and related resources and even with the recent change to not deploy PSPs if API is not available, there is a potential issue with upgrade flow.
Consider the following scenario:

k8s 1.24 RKE2 downstream cluster is provisioned from Rancher

This deploys SUC chart to the downstream cluster which in turn creates PSP and related resources from psp.yaml file.
Helm creates a secret of type "Helm Release" to store objects that got created

The downstream cluster is upgraded to k8s 1.25 (on Rancher release 2.7.2)

k8s 1.25+ no longer serves PSP API; however that "Helm Release" secret still has a record of PSP resource created

If SUC needs to be upgraded/reinstalled, it will fail because helm uninstall / helm upgrade would fail due to having record of PSP created on install (see https://github.com/helm/helm/issues/11287). SUC upgrade/reinstall will be triggered by Rancher upgrade to version after 2.7.2, but there are probably other cases where it will be triggered.

Solution Outline
Block (defer) upgrade to 1.25+ until Rancher deploys a version of the SUC chart that has the PSPs disabled, and ensure the chart has actually rolled out before proceeding with the actual upgrade to 1.25+
Additional Solution Details
Courtesy of @Oats87
v2prov Planner Modifications

managesystemagentplan.go needs to set a condition after it checks the status of the bundle, to see if the bundle is ready: https://fleet.rancher.io/cluster-bundles-state (bonus points if the condition contains a hash or something of the bundle so that we don’t have the possibility of inconsistency if we reuse the condition in the future). It also needs to check for the version of k8s on the cluster object and if it’s >= 1.25, make sure to disable PSP via the chart option detailed below.
planner.go needs to be modified to not allow an upgrade to 1.25+ (i.e. halt any plan modifications) if the bundle condition for ready is not set, AND ANY plans have been delivered to any of the nodes. There will probably have to be additional functionality added to the store.go load cluster to see if there are any plans that have been delivered already. Otherwise, proceed with reconcilation.  Ideally, we should provide feedback about this to the user, and this is the one and only time they can revert their K8s version, but that should not be advertised.

Chart Updates
Need to update SUC chart to support a flag that completely turns off PSP.
global:
  cattle:
     psp:
        enabled: true

The actual chart should have:
{{- if .Values.global.cattle.psp.enabled }}
{{- if not (.Capabilities.APIVersions.Has "policy/v1beta1/PodSecurityPolicy") }}
  {{- fail "The target cluster does not have the PodSecurityPolicy API resource. Please disable PSPs before proceeding." -}}
{{- else }}
apiVersion: policy/v1beta1
kind: PodSecurityPolicy

...

{{- end }}
{{- end }}

This will need to be updated in rancher/system-charts in rancher-k3s-upgrader, and then eventually in the rancher/charts repo.
Misc
Parent Issue: https://github.com/rancher/rancher/issues/38701

Tests to be included during validation:

On 2.7.0 - deploy RKE2 1.24 cluster (Node driver or custom cluster). Upgrade Rancher to 2.7.2-rc (with fix) or 2.7-head , verify the SUC has upgraded. Verify user is able to upgrade RKE2 to 1.25.
On 2.7.0 - deploy k3s 1.24 cluster (Node driver or custom cluster). Upgrade Rancher to 2.7.2-rc (with fix) or 2.7-head , verify the SUC has upgraded. Verify user is able to upgrade k3s to 1.25.

This issue has been merged into 2.7-head and can now be tested. I've added some lengthy test steps to the PR that QA can reference, if there are any issues please reach out asap.

QA TEST PLAN

Scenario
Test Case

1
Validate SUC upgrades after upgrading Rancher v2.7.1 -> v2.7-head + RKE2 node driver cluster v1.24 → v1.25

2
Validate SUC upgrades after upgrading Rancher v2.7.1 -> v2.7-head + K3s node driver cluster v1.24 → v1.25

3
Create etcd snapshot with RKE2 node driver cluster v1.24 in Rancher v2.7.1, upgrade Rancher to v2.7-head, upgrade to v1.25 and restore

4
Create etcd snapshot with K3s node driver cluster v1.24 in Rancher v2.7.1, upgrade Rancher to v2.7-head, upgrade to v1.25 and restore

The build for this PR has partially passed after several restarts. The provisioning tests were flakey, but passed on prior ci executions. Regardless, the most recent run has published the required assets needed to test this issue, so testing is good to go

Upon testing test scenario 3 and 4 in the above scenario, the following UI issue was found. As such, going to mark this issue as blocked until that is resolved.

Closed UI issue as it appeared to have been a fluke; I consistently am not seeing the reported behavior on RKE2/K3s. I can proceed forward with the test plan now, so updating to QA Working.

Validated that this is addressed. See details below:
ENVIRONMENT DETAILS

Rancher install: Docker
Rancher version

Fresh install: v2.7.0
Upgraded: v2.7.0 -> v2.7-head

Browser: Chrome

TEST RESULT

Scenario
Test Case
Result

1
Validate SUC upgrades after upgrading Rancher v2.7.1 -> v2.7-head + RKE2 node driver cluster v1.24 → v1.25
:white_check_mark:

2
Validate SUC upgrades after upgrading Rancher v2.7.1 -> v2.7-head + K3s node driver cluster v1.24 → v1.25
:white_check_mark:

3
Validate SUC upgrades after upgrading Rancher v2.7.1 -> v2.7-head + RKE2 imported cluster v1.24 → v1.25
:white_check_mark:

4
Validate SUC upgrades after upgrading Rancher v2.7.1 -> v2.7-head + K3s imported cluster v1.24 → v1.25
:white_check_mark:

5
Create etcd snapshot with RKE2 node driver cluster v1.24 in Rancher v2.7.1, upgrade Rancher to v2.7-head, upgrade to v1.25 and restore
:white_check_mark:

6
Create etcd snapshot with K3s node driver cluster v1.24 in Rancher v2.7.1, upgrade Rancher to v2.7-head, upgrade to v1.25 and restore
:white_check_mark:

7
On a fresh install of Rancher v2.7-head, validate SUC upgrades after upgrading RKE2 imported cluster v1.23 -> v1.24 -> v1.25
:white_check_mark:

8
On a fresh install of Rancher v2.7-head, validate SUC upgrades after upgrading K3s imported cluster v1.23 -> v1.24 -> v1.25
:white_check_mark:

VALIDATION STEPS
Scenario 1

Provisioned a v1.24 RKE2 downstream cluster with RKE2 Default set as PSP value.
Validated that the cluster and nodes come up as Active in Cluster Management and Cluster Explorer.
Verified the workloads/pods in System project page are up and Active.
Navigated to RKE2 cluster's workload and took note of the SUC version (v0.9.1) and that rancher/system-agent:v0.2.13-suc.
Upgraded to Rancher to the latest v2.7-head.
Validated that the cluster and nodes did not auto-upgrade and that they remained in Active state in both Cluster Management and Cluster Explorer.
Took note again of the SUC version; validated that SUC upgraded and image rancher/system-agent:v0.3.2-suc successfully upgraded.
Upgraded the cluster to v1.25 and ensure the PSA level is set to rancher-restricted.
Validate that the upgrade was successful and that the cluster and nodes are still Active in Cluster Management and Cluster Explorer.
Viewed the cluster YAML and validate that spec.defaultPodSecurityAdmissionTemplateName  is set to rancher-restricted.
Created a new pod with the container image nginx:latest and default settings in the test namespace; validated that the pod DOES NOT create.

Scenario 2

Repeated scenario 1, but using K3s as the downstream cluster instead.
Validated that all steps were successful as mentioned in scenario 3, but with K3s instead.

Scenario 3

Navigated to a client machine and created an RKE2 cluster to be later imported into Rancher.
As a standard user, navigated to Rancher UI.
Imported the RKE2 cluster; validated that the cluster and nodes came up as Active.
Verify the workloads/pods in System project page are up and Active.
Upgraded Rancher to v2.7-head; validated that the cluster and nodes did not auto-upgrade and remained Active.
Took note that the system-upgrade-controller image tag is at v0.10.0.
Edited the cluster config of the 1.24 cluster and updated the K8s version to 1.25.
Upgraded the cluster and see the following:

Validated that the cluster and nodes upgraded successfully to v1.25 and are Active in Cluster Management and Cluster Explorer.
Verified the workloads/pods in System project page are up and Active.
Validated that the system-upgrade-controller image tag still at v0.10.0.

Scenario 4

Repeated scenario 3, but used an imported K3s cluster instead.

Scenario 5

Provisioned a v1.24 RKE2 downstream cluster with RKE2 Default set as PSP value.
2, Validated that the cluster and nodes come up as Active in Cluster Management and Cluster Explorer.
Verify the workloads/pods in System project page are up and Active.
Navigated to RKE2 cluster's workload and took note of the SUC version and that rancher/system-agent:v0.2.13-suc.
Upgraded to Rancher to the latest v2.7-head.
Validate that the cluster and nodes did not auto-upgrade and that they remain in Active state in both Cluster Management and Cluster Explorer.
Took note again of the SUC version; validated that SUC upgraded and image rancher/system-agent:v0.3.2-suc successfully upgraded.
Took an etcd snapshot of the RKE2 downstream cluster.
Created deployments d1 ,d2 and d3 , all with nginx:latest as the container image.
Validated that they all come up as Active .
Upgraded the cluster to v1.25 and ensure the PSA level is set to rancher-restricted .
Validated that the upgrade was successful and that the cluster and nodes are still Active in Cluster Management and Cluster Explorer.
Viewed the cluster YAML and validate that spec.defaultPodSecurityAdmissionTemplateName  is set to rancher-restricted.
Restored the etcd snapshot with options cluster configuration, Kubernetes version and etcd.
Validated the following items:

Cluster is back at v1.24
Cluster configuration is back to the v1.24 configuration and is not at the v1.25 configuration
The SUC version is back at the v1.24 viewed version
The d1 , d2 and d3 deployments do not appear

Scenario 6

Repeated scenario 5, but used K3s instead as the downstream cluster.
Validated that all steps were successful as mentioned in scenario 5, but using a K3s downstream cluster.

Scenario 7

Navigated to a client machine and created an RKE2 cluster to be later imported into Rancher.
As a standard user, navigated to Rancher UI.
Imported the RKE2 cluster; validated that the cluster and nodes came up as Active.
Verify the workloads/pods in System project page are up and Active.
Took note that the system-upgrade-controller image tag is at v0.9.1.
Edited the cluster config of the 1.24 cluster and updated the K8s version to 1.25.
Upgraded the cluster and see the following:

Validated that the cluster and nodes upgraded successfully to v1.25 and are Active in Cluster Management and Cluster Explorer.
Verified the workloads/pods in System project page are up and Active.
Validated that the system-upgrade-controller image tag upgraded to v0.10.0.

Scenario 8

Repeated scenario 7, but used a K3s imported cluster instead with the same successful results.