[$1000] iOS - LHN - The green + button moves

If you haven’t already, check out our contributing guidelines for onboarding and email<EMAIL_ADDRESS>to request to join our Slack channel!

Action Performed:

Open the App/iOS and login with any account
Click on FAB button
Select New Chat or New Group and then close it

Expected Result:
The FAB button should not move
Actual Result:
The FAB button moves down
Workaround:
Unknown
Platform:

Where is this issue occurring?

iOS

Version Number: <IP_ADDRESS>
Reproducible in staging?: Yes
Reproducible in production?: Yes
Email or phone of affected tester (no customers): any
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation
https://user-images.githubusercontent.com/93399543/189195867-e7b6accc-0664-4dec-8f28-9a32df91cddd.mp4
Expensify/Expensify Issue URL:
Issue reported by: @thesahindia & Applause - Internal Team
Slack conversation: https://expensify.slack.com/archives/C01GTK53T8Q/p1661937997800789
View all open jobs on GitHub

Hi, I had reported it here.
It's more noticeable in iPad
https://user-images.githubusercontent.com/83179295/189351776-bf687433-caf6-41f0-9d40-bb45b2f73def.mov

Reassigning as I'm ooo for the next 9 days.

job post

This seems like an issue to me -> https://github.com/Expensify/App/issues/10905#issuecomment-1241927509
https://user-images.githubusercontent.com/85645967/189996312-ccb8f0a2-0be9-4b89-8521-94d549f9c400.mov
But not this https://github.com/Expensify/App/issues/10905#issue-1366788309
https://user-images.githubusercontent.com/85645967/189996078-0ca684b5-e1b0-43af-8c10-fa60c6b99c6d.mp4
@Expensify/design Can someone share your thoughts
Also, we have a proposal here please checkout the after-fix video is that the expectation?

@Santhosh-Sellavel I agree with you

And yes, the proposal vid looks good to me.

@ctkochan22  / @shawnborton  should I hire @vladnobenladen?

@jboniface Not yet

Oh, @shawnborton Just confused by your comments.
Do you agree that,

the issue needs to be addressed only on iPad or Tablets
Phone already looks fine
And fixed behavior is expected on iPad/tab alone.
Or Do we need this handled for the phone also?

Please clarify, thanks!

IIRC the fab used to work fine, it used to float correctly. Maybe there was some regression which caused this.
I think the fab should float when keyboard is open because it's easy to access while chatting.

IIRC the fab used to work fine, it used to float correctly. Maybe there was some regression which caused this.
I think the fab should float when keyboard is open because it's easy to access while chatting.

I would also expect the same while chatting fab should float!
cc: @shawnborton

Hmm I kind of think the FAB should just stay stuck to the bottom of the chats list view.
@thesahindia what exactly do you mean by this:

IIRC the fab used to work fine, it used to float correctly. Maybe there was some regression which caused this.
I think the fab should float when keyboard is open because it's easy to access while chatting.

Did it used to float right above the keyboard?

Yeah it used to.

Got it, so then it sounds like this is a regression?

Got it, so then it sounds like this is a regression?

@shawnborton
I'm not sure, check out the below video behavior was correct at the beginning and end. In between, it was messed up
https://user-images.githubusercontent.com/85645967/190205965-fa633d56-9db8-4be4-8e62-ed951b3b2a7b.MP4

Got it, so then it sounds like this is a regression?

Yeah It is a regression, here's a video of this working fine earlier (it's from https://github.com/Expensify/App/issues/10354 which was closed because it wasn't a bug) -
https://user-images.githubusercontent.com/83179295/190206841-3c977a99-b87d-4011-80ce-5b55a8b84687.mov

Solid that's a regression!

Got it, okay so yeah it seems like the video here is correct behavior then.

Hi @thesahindia and @Santhosh-Sellavel - I've just been assigned this as Jeremy has now left and I'm confused as to the next steps.
Can one of you provide a suggestion as to the next steps from a management standpoint? Should I look at hiring someone, or do one of you want to take this on as C+?
Job Post - https://www.upwork.com/ab/applicants/1569366797023916032/job-details

This is still open to proposals

@aimane-chnaif
Your proposal is redundant as https://github.com/Expensify/App/issues/10905#issuecomment-1244097571

We are not moving forward as it does not meet our requirements!

Not overdue

Not overdue

Going to double this one, since we don't have any accepted proposals

Not overdue

@jliexpensify Can we bump this to weekly while we wait, also we can double the price for this one!

@Santhosh-Sellavel I made it Weekly, but I only just doubled 3 days ago...so let's wait until next week?

Ah Sorry, I missed your comment 3 days ago. @jliexpensify

Doubled - https://expensify.slack.com/archives/C01GTK53T8Q/p1664851140216699

Proposal
we can remove this file https://github.com/Expensify/App/blob/main/src/components/FAB/index.ios.js,
as this file was added for this issue https://github.com/Expensify/App/issues/2151 and code was added in this [PR] for iPad FAB button issue. (https://github.com/Expensify/App/pull/2305/files) , but now we are using ScreenWrapper and under this file we are using KeyboardAvoidingView so no need to add KeyboardAvoidingView for to FAB as parent screen SidebarScreen is wrapped in ScreenWrapper
video that shows that after removing file, its working fine in iPhone 13 and iPad pro
https://drive.google.com/file/d/12HCy-tr3GH4Qn-oWR_cZLi2UEcJlnJ9Q/view?usp=sharing

@Santhosh-Sellavel can you please clarify in detail what is not met?
You mean you don't like both Solution 1 and Solution 2?

Can you add a recording of behavior after applying the solutions?

Can you elaborate on this

but now we are using ScreenWrapper and under this file, we are using KeyboardAvoidingView so no need to add KeyboardAvoidingView for to FAB as parent screen SidebarScreen is wrapped in ScreenWrapper

@Santhosh-Sellavel Yes sure,

we have added KeyboardAvoidingView for FAB in ios specific for iPad in this PR and this is the issue, you can check the description here
at that time we were not using the KeyboardAvoidingView for the ScreenWrapper, please check this file https://github.com/aliabbasmalik8/Expensify.cash/edit/IS-2151-fab-hidden-issue/src/components/ScreenWrapper.js
now we are using  KeyboardAvoidingView under ScreenWrapper, so no need to wrap the FAB component under KeyboardAvoidingView, as we are wrapping SidebarScreen under ScreenWrapper, and its using KeyboardAvoidingView

Also your proposal seems like redundant of Solution 1 #10905 (comment)

I missed checking here but I think that this is the solution

video that shows that after removing file, its working fine in iPhone 13 and iPad pro
https://drive.google.com/file/d/12HCy-tr3GH4Qn-oWR_cZLi2UEcJlnJ9Q/view?usp=sharing

@Santhosh-Sellavel can you please check this video and give feedback if this video is satisfied the requirement or not, as I think this is as per this comment

Thanks for the proposals.
@jayeshmangwani

I missed checking https://github.com/Expensify/App/issues/10905#issuecomment-1248953829 but I think that this is the solution

If that is the case we should go with the first one if that proposal is accepted.
But before proceeding, @tgolen this issue also revolves around the keyboard, can you verify this too got fixed? Can you confirm, please?
Thanks!

Bump @tgolen to answer @Santhosh-Sellavel 's question!

I'm going to place a HOLD on this and add the issue to this master tracking issue: https://github.com/Expensify/App/issues/10273
I think some of the problems should go away once that is done.

On hold

I removed the HOLD on this and assigned it to me because this is fixed in https://github.com/Expensify/App/pull/11586

@tgolen - thanks! Since it's fixed by another PR, could we remove this Upworks job?

Yeah, it's fine to remove it.
On Thu, Oct 13, 2022 at 4:04 PM Jason Li @.***> wrote:

@tgolen https://github.com/tgolen - thanks! Since it's fixed by another
PR, could we remove this Upworks job?
—
Reply to this email directly, view it on GitHub
https://github.com/Expensify/App/issues/10905#issuecomment-1278223978,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AAJMAB3EZSX4GLOV7WKZLX3WDCBNDANCNFSM6AAAAAAQIAA66A
.
You are receiving this because you were mentioned.Message ID:
@.***>

Upworks job removed

PR is still in progress

@tgolen - this is now an Internal issue right? Could I remove myself and @Santhosh-Sellavel from this GH?

That proposal sounds great! 🟢 from me

Sorry @tgolen I'm a little confused: did you need a $750 Upworks job created for https://github.com/Expensify/App/pull/11586? And Santhosh and Aimane invited?
I'm just trying to work out if I need to do anything...thanks.

@jliexpensify let's move that convo over to #11586.

As far as this issue is concerned, I think it basically totally reset when I took it off hold. We need a $1000 job created in UpWork and hire @aimane-chnaif for the proposal they gave right above this.

@tgolen
Just reviewed it works well on iPad & Tab. Workswell Android Tab Web also But iPad Safari alone seems to be sloppy as it was earlier.
https://user-images.githubusercontent.com/85645967/199301952-4b2dfca2-2d2c-4840-b243-15f451d8a81d.mp4

Seem the PR is already up for this one if we are good with the above let's assign this to @aimane-chnaif, thanks!

We need a $1000 job created in UpWork and hire @aimane-chnaif for the proposal they gave right above this.

Thanks for clarifying @tgolen - I'll get this sorted now.

Internal - https://www.upwork.com/ab/applicants/1587570510876553216/job-details
External - https://www.upwork.com/jobs/~0137afe133f0fca3ca
Hired @aimane-chnaif and @Santhosh-Sellavel

@Santhosh-Sellavel Thanks for reporting that! I think it's OK for this issue. I noticed there is another issue for handling view rotation on iPad better, and that's probably more related to the bug you're seeing in iPad safari: https://github.com/Expensify/Expensify/issues/136195

@jliexpensify Given that we're still early and no proposals have been accepted, I'm assigning myself per the new BZ process: https://stackoverflow.com/c/expensify/questions/14597/14598#14598.

@JmillsExpensify - Happy for you to assign this one over to yourself, however, my understanding was that we had an approved proposal from @aimane-chnaif

The Upwork job was just created so I figured no biggie, but please take it back if you'd like!

@jliexpensify Don't forget to get the BZ checklist kicked off above please!

@jliexpensify Just wanted to circle back and make sure you've gone through the linked BZ checklist?

@JmillsExpensify I previously posted here around what parts of the checklist I should be doing, and you mentioned changes were coming.
I'm still confused here: am I doing the entire checklist? The first 3 items sound like they should be reviewed by the primary engineer (Tim), whilst the last few items are related to payment, which isn't due yet.

@jliexpensify I don't recall saying don't fill out the checklist, as any changes to Melvin are unfortunately not retro-active. All good, here's an example checklist I got on Friday. That should clear up your questions.

Thanks @JmillsExpensify, appreciate you sharing that checklist. I've updated the one above to mirror yours.
Regression test question posted here - https://expensify.slack.com/archives/C01SKUP7QR0/p1668379720583589

@Santhosh-Sellavel and @tgolen - I've done the regression test GH, and have tagged you both in the checklist. Cheers!

I've filled out the first two checkboxes for identifying the PR. @Santhosh-Sellavel would you like to create a slack thread for discussing if any changes are necessary for the checklist?

Quick follow-up question: @jliexpensify has payment been issued to contributors?

Thread started here

Sorry @JmillsExpensify - dropped the ball on this one! I'll sort out payment now.

@Santhosh-Sellavel , @aimane-chnaif and @thesahindia apologies for the delay: once you accept, I'll pay out $1000 to each of you.

Accepted, thanks!

I'll pay out $1000 to each of you.

I believe it's $250 for me (reporting compensation)

Thank you @jliexpensify! Echoing your last comment, this is the last todo before we can close this issue.

@Santhosh-Sellavel @tgolen A discussion in #contributor-plus has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:

@jliexpensify the BugZero checklist is finished now so this issue is OK to close out now. I'll let you do the honors.

Nice work, thanks @tgolen , @aimane-chnaif , @Santhosh-Sellavel, @shawnborton and @JmillsExpensify !


Use custom CMake modules for interactive_markers and tf

as suggested by @psigen in #197

Coverage increased (+0.02%) to 79.29% when pulling 4cf5eaf5ca3bbcface6191fdee3a6d3804a4bfd2 on build/use_findX.cmake into acd983ca1dfc8135c6113061006b67af6b58d37a on master.

Coverage decreased (-0.02%) to 79.243% when pulling 75e5352d202c30e136eace4bc495a74b69c7b16c on build/use_findX.cmake into acd983ca1dfc8135c6113061006b67af6b58d37a on master.

I am pretty sure the only reason that ROS CMake files don't use this is because the mechanism only recently made it to the CMake repos on 14.04 and wouldn't have been supported when many of them were last touched.
I think we should use it here if these are effectively private CMake modules.  I don't think these find_XXXX directives will leak out through the find_package(aikido) call, right?

I see that we use pkg_check_modules to find the dependencies, but then use find_path and find_library to set the x_INCLUDE_DIRS and x_LIBRARIES variables instead of using the output from pkg-config directly. Is this necessary because the output of pkg-config includes the offending gtest invocations? If so, can you add a comment to that effect?

That's actually for the case pkg-config failed to find the .pc file so that CMake does the second try with find_path and find_library. I believe pkg-config has nothing to do the offecding gtest invocations.

I was considering creating an IMPORTed target for the dependency libraries and using target_include_directories and target_link_libraries to specify PUBLIC (or INTERFACE) dependencies. This would have the advantage of correctly percolating transitive dependencies through Aikido.

I like this idea even though I haven't used that mechanism yet. Let me create an issue for that.

I don't think these find_XXXX directives will leak out through the find_package(aikido) call, right?

I believe so.

Coverage remained the same at 79.266% when pulling e5fc1f3a698b8fbe107b311cc5984da46d94fc57 on build/use_findX.cmake into 36d3a308949b565184b0c4147042de0dae03dedb on master.

Coverage remained the same at 79.29% when pulling 45b3c83eef4669063f52ece0f834fcabb5197a6c on build/use_findX.cmake into bb5a1b215888f1179ec1dfa8082e688fe535341d on master.


Fix celery module import in comments.

Implements: https://github.com/airbnb/caravel/issues/1468
@mistercrunch ^^

LGTM


media_priors

Hi All,
I have some questions about setting the media_priors.

Is there a way to change the default HalfNormal distribution to something else, say, Gamma?
I ask because suppose I have reason to believe that the PDF should peak at certain positive value (but we know that the HalfNormal is zero-biased).

Why do we 1-center the costs? What happens if I do not 1-center it? Especially when the costs do not even go into the model as training data but are only used to set the default media_priors.
I can understand the reason behind 1-centering the dependent and independent variables of the model. But why the media_priors?

I have the same questions here.
For question 2, I'm not sure what the underlying principle for 1-centering. In our case, 1-centering results in a higher marketing contribution as compared to dividing the media spend by the max value.


Public repository support for Audit Proofs

In order to support both public auditing and a generated signature over root hashes by a hosted auditing pool (#125) we need to be able to host audit proofs in some public repository for consumption by any third party auditor should they see fit.
Requirements

[x] Store roots for all epochs to allow audits between arbitrary epochs (#209)
[x] Audit proofs support serialization in a backwards compatible format (e.g. protobuf)
[x] A new tool needs to be created to retrieve said audit proofs from some public storage, verify them, and emit the previous & new root hashes to verify against local versions

[x] We are going to start with S3 as the storage medium, since it's a well known standard blob storage
[x] Will build command-line app to support download and verifying the audit proofs (which will be a new crate having a dependency on the akd crate)
[x] (future) Eventually support a QR code generation say in a web page after verification which can be verified in the client application(s)

[ ] We need to add an optional trait to the Directory which if implemented will upload the audit proof after a publish to some public repository

Items checked assuming draft PR passes


Rename Policy to AlertPolicy

Feature Description
"Policy" is very overloaded term in the kubernetes ecosystem.
Describe Alternatives
Other names might be fine, provided they're more specific than Policy.

This work has been started in https://github.com/newrelic/newrelic-kubernetes-operator/pull/60

The work is largely done with #82


Offsets

See:
https://github.com/UCSD-PL/RefScript/blob/master/tests/todo/offsets.ts

Addressed by https://github.com/UCSD-PL/RefScript/commit/7b8331e7a539d5e48e52df31163f039a16f62208


Implement Real-Time Feed Updates

New posts, likes, comments update in real-time

New posts, likes, comments update in real-time via Firestore listeners.


Enhanced Bazaar Menu

LividDogg
Nice looking sb menu, bazar and other interfaces where instead of blocks you have to click on its buttons

Used to be #34


Release new version

Could you please do a release to pub.dev, so we can access the new version?
Thank you.

Working on it!


contact form

what happens with emails sent via contact form > probably they are sent to our gmail address and not to the list > must be tested and changed

problem is that the riseup list through which distribute our emails holds back mails of certain providers. We have to accept them manually which is not done regularly. We will broaden the moderators of that list to have that process more regularly.


alert problem

name: xxx-aaa
type: "frequency"
index: xxx-*
num_events: 1
timeframe:
  minutes: 10
doc_type: "xxx"
use_count_query: true
query_delay:
  minutes: 1
alert:
  - "debug"

run_every = 2 minutes
At least 1 events occurred between 2016-03-08 12:35 CST and 2016-03-08 12:45 CST
At least 1 events occurred between 2016-03-08 12:37 CST and 2016-03-08 12:47 CST
At least 1 events occurred between 2016-03-08 12:38 CST and 2016-03-08 12:48 CST
At least 1 events occurred between 2016-03-08 12:40 CST and 2016-03-08 12:50 CST
At least 1 events occurred between 2016-03-08 12:42 CST and 2016-03-08 12:52 CST
At least 1 events occurred between 2016-03-08 12:44 CST and 2016-03-08 12:54 CST

Why call alarm function every two minutes?

You probably want to set the realert option.


CPU usage too much  when use the sdpmanager.

Hi @murillo128
I am testing your sdpmanager.  the cpu useage will  reach 300% when  plan-b and unified plan use together.
test demo:
https://github.com/notedit/sdpmanager-playground
How to Reproduce:
open  https://xxxxx:8000/  add three unified stream.
then open  https://xxxxxx:8000/planb.html, watch the  stream  will show this.

Update to the latest version fix this.   sorry.

the curious thing is that it shouldn't affect if you are not using h264 .. will have to investigate further..


Fix broken circle-ci badge

Closes #2473

:tada: This PR is included in version 5.6.0 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


ASP.NET Core 2.2 kestrel server's performance issue

※Describe the bug
I'm facing problem with kestrel server's performance. I have following scenario :
TestClient(JMeter) -> DemoAPI-1(Kestrel) -> DemoAPI-2(IIS)

I'm trying to create a sample application that could get the file content as and when requested. TestClient(100 Threads) requests to DemoAPI-1 which in turn request to DemoAPI-2. DemoAPI-2 reads a fixed XML file(1 MB max) and returns it's content as a response(In production DemoAPI-2 is not going to be exposed to outside world).
When I tested direct access from TestClient -> DemoAPI-2 I got expected result(good) which is following :

Average : 368ms
Minimum : 40ms
Maximum : 1056ms
Throughput : 40.1/sec

But when I tried to access it through DemoAPI-1 I got following result :

Average : 48232ms
Minimum : 21095ms
Maximum : 49377ms
Throughput : 2.0/sec

As you can see there is a huge difference.I'm not getting even the 10% throughput of DemoAPI-2. I was told kestrel is more efficient and fast compared to traditional IIS. Also because there is no problem in direct access, I think we can eliminate the possible of problem on DemoAPI-2.
※Code of DemoAPI-1 :
using (var httpClientHandler = new HttpClientHandler())
        {
            httpClientHandler.ServerCertificateCustomValidationCallback = (message, cert, chain, errors) => { return true; };
            using (var client = new HttpClient(httpClientHandler))
            {
                var req = new HttpRequestMessage(HttpMethod.Get, url);
                req.Headers.Add(HeaderUserAgent, UserAgentValue);
                var response = await client.SendAsync(req).ConfigureAwait(false);
                string buffer = null;
                using (var stream = await response.Content.ReadAsStreamAsync().ConfigureAwait(false))
                {
                    var read = new byte[DataChunkSize];
                    var bytes = stream.Read(read, 0, DataChunkSize);

                    while (bytes > 0)
                    {
                        buffer += System.Text.Encoding.UTF8.GetString(read, 0, bytes);
                        bytes = stream.Read(read, 0, DataChunkSize);
                    }
                }
                return buffer;
            }
        }

※Code of DemoAPI-2 :
[HttpGet("Demo2")]
public async Task<IActionResult> Demo2Async(int wait)
  {
      try
      {
          if (wait > 0)
          {
              await Task.Delay(wait);
          }
          var path = Path.Combine(Directory.GetCurrentDirectory(), "test.xml");
          var file = System.IO.File.ReadAllText(path);
          return Content(file);
      }
      catch (System.Exception ex)
      {
          return StatusCode(500, ex.Message);
      }
  }

Additional context

Both APIs are async.
Both APIs are hosted on different servers (Windows Server 2016).
DemoAPI-1(kestrel) is a self-contained API(without reverse proxy)
TestClient(jMeter) is set to 100 thread for this testing (want to test upto 1000 threads).
No other configuration is done for kestrel server as of now.
There are no action filter, middleware or logging that could effect the performance as of now.
Communication is done using SSL on 5001 port.
Wait parameter for DemoAPI2 is set to 0 as of now.
The CPU usage of DEMOAPI-1 is not over 40%.
I've performed similar test for 100KB and 500KB files and didn't have any problem.

https://stackoverflow.com/questions/56387959/asp-net-core-2-2-kestrel-servers-performance-issue
Screenshots
I've attached the performance monitor's screenshot.

If this is not the correct place for this question please let me know where should I ask about this.

Looking at your Code  you open/Close HttpClientHandler for each request, that could lead to the classic HttpClient port exhaustion problem.
See e.g. https://www.stevejgordon.co.uk/httpclient-creation-and-disposal-internals-should-i-dispose-of-httpclient on how to properly use these types.
Then you should rethink that buffer/String encoding logic as already noted on Stack Overflow, for the sync behaviour, the amount of String concatenation, Byte arrays etc.

@Tornhoof

Then you should rethink that buffer/String encoding logic as already noted on Stack Overflow, for the sync behaviour, the amount of String concatenation, Byte arrays etc.

Thanks for pointing it out.
I've updated read stream code to following but didn't see much difference:
string base64Encoded = null;
                var request = new HttpRequestMessage(HttpMethod.Get, url);
                var response = await this.httpClient.SendAsync(request, HttpCompletionOption.ResponseContentRead).ConfigureAwait(false);

                if (response.StatusCode.Equals(HttpStatusCode.OK))
                {
                    var content = await response.Content.ReadAsByteArrayAsync().ConfigureAwait(false);
                    base64Encoded = Convert.ToBase64String(content);
                }

if read was blocking then it should be should affect CPU usage in some way but as you can seen in the image CPU usage is around 40% only.

Looking at your Code you open/Close HttpClientHandler for each request, that could lead to the classic HttpClient port exhaustion problem.

So I should use HttpClientFactory instead of HttpClient to avoid overhead of re-initialization and disposal of HttpClient and related socket resources, right?
But...

Does it really have that big of a impact? I mean I'm getting performance below 10% of DemoAPI-2.
Can port exhaustion has that big of an impact?
Will similar problem occur on ASP.NET too? or is it just with ASP.NET Core?

Also, thanks for the link, it's an interesting article (didn't know about the this issue).
Regards,
Vishwas

Yes, you should use HttpClientFactory and yes, the Httpclient Problems exists on ASP.Net too.
As for impact, it's hard to tell, it's an obvious problem in your code and very easy to fix.

I would suggest not buffering the response and read the raw network stream
and hand it off to stream reader for processing. For larger requests it
could be a consideration.
On Fri, 31 May 2019, 08:26 vishwas-trivedi<EMAIL_ADDRESS>wrote:

@Tornhoof https://github.com/Tornhoof
Thank you!
I'm working on a sample to deploy and re-check the same.
I'll share the results soon.
Regards,
Vishwas
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/aspnet/AspNetCore/issues/10681?email_source=notifications&email_token=ADKSKTFLCHXFDC6V46MM2TDPYDHIZA5CNFSM4HRS7XAKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODWUNXJQ#issuecomment-497605542,
or mute the thread
https://github.com/notifications/unsubscribe-auth/ADKSKTDSKYK465XG7ULMP4DPYDHIZANCNFSM4HRS7XAA
.

@Tornhoof
Thank you, I was able to confirm that the problem was indeed because of HttpClient.
I was able achieve comparatively better results which is as following :

Average : 734ms
Minimum : 63ms
Maximum : 1841ms
Throughput : 34.1/sec

It's not as fast as DemoAPI-2 but I think I can work with it.
Regards,
Vishwas Trivedi

@DAllanCarr

Those bytes will be held in memory. I would suggest not buffering the response and read the raw network stream and hand it off to stream reader for processing. For larger requests it could be a consideration.
…
On Fri, 31 May 2019, 08:26 vishwas-trivedi, @.***> wrote: @Tornhoof https://github.com/Tornhoof Thank you! I'm working on a sample to deploy and re-check the same. I'll share the results soon. Regards, Vishwas — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub <#10681?email_source=notifications&email_token=ADKSKTFLCHXFDC6V46MM2TDPYDHIZA5CNFSM4HRS7XAKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODWUNXJQ#issuecomment-497605542>, or mute the thread https://github.com/notifications/unsubscribe-auth/ADKSKTDSKYK465XG7ULMP4DPYDHIZANCNFSM4HRS7XAA .

I would be grateful if you could provide a sample. I want to return response in base-64 format from DemoAPI-1 as you can see in my previous comment(https://github.com/aspnet/AspNetCore/issues/10681#issuecomment-497600974).
Regards,
Vishwas

You can try adapting CryptoStream but it seems you have the perf hike from
httpclient work.
On Fri, 31 May 2019, 10:40 vishwas-trivedi<EMAIL_ADDRESS>wrote:

@DAllanCarr https://github.com/DAllanCarr
Those bytes will be held in memory. I would suggest not buffering the
response and read the raw network stream and hand it off to stream reader
for processing. For larger requests it could be a consideration.
… <#m_-8827034674454892256_>
On Fri, 31 May 2019, 08:26 vishwas-trivedi, @.***> wrote: @Tornhoof
https://github.com/Tornhoof https://github.com/Tornhoof Thank you! I'm
working on a sample to deploy and re-check the same. I'll share the results
soon. Regards, Vishwas — You are receiving this because you are subscribed
to this thread. Reply to this email directly, view it on GitHub <#10681
https://github.com/aspnet/AspNetCore/issues/10681?email_source=notifications&email_token=ADKSKTFLCHXFDC6V46MM2TDPYDHIZA5CNFSM4HRS7XAKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODWUNXJQ#issuecomment-497605542>,
or mute the thread
https://github.com/notifications/unsubscribe-auth/ADKSKTDSKYK465XG7ULMP4DPYDHIZANCNFSM4HRS7XAA
.
I would be grateful if you could provide a sample. I want to return
response in base-64 format from DemoAPI-1 as you can see in my previous
comment(#10681 (comment)
https://github.com/aspnet/AspNetCore/issues/10681#issuecomment-497600974
).
Regards,
Vishwas
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/aspnet/AspNetCore/issues/10681?email_source=notifications&email_token=ADKSKTFS3RPZ4UATLZ3HYOTPYDW77A5CNFSM4HRS7XAKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODWUXYDY#issuecomment-497646607,
or mute the thread
https://github.com/notifications/unsubscribe-auth/ADKSKTHBA5JG5FHI4WASHBDPYDW77ANCNFSM4HRS7XAA
.

@Tornhoof
Just wanted to confirm whether there's a way to use this in .netstandard 2.0 library project as well?
All I could find from official document was how to use it with DI, so can it be used without DI as well?


Fix some doc issues

Add unit for buffer_size;
Add value range of top_k.

This fixes #419 and #421


broken CircleCI integration

CircleCI is run, but it's not being reported in PRs.

Hi @mcollina, is this still an issue?

Things are fine now


Explore ability to compile to Linux

Determine what is needed to build a release for Linux, either via Mac directly, docker, etc.

Github action is now compiling to Ubuntu latests as a test prior to merge to main. However, no linux build artifact is harvested and included in the releases.


269 ref files rest api

@ismagilani Just have one comment for you to address. Otherwise, it looks good.

Thanks Hong! I am going to update beta now if that's ok with you.

@ismagilani Go ahead. Thanks. I think server restart should be good enough without rebuilding.


Relationship between Release and Config / Build is the wrong way around

https://github.com/deis/controller/pull/792 has uncovered some inconsistencies in our data model on Release.
Problem
Currently things are set up so that Release is the child object of Config and Build via ForeignKey with CASCADE delete set.
Each Config and Build object can be re-used across multiple Release objects, if nothing changes on the respective object. Such as: User A does 50 releases but they are only config changes, then the build object will always stay the same.
In many parts of the code when doing deploy and that fails we only delete the Release object, thinking the ForeignKey relationship is going to take care of it but that doesn't happen since Release is a child object, not a parent.
Why is this a problem?
If only the Release object is remove then the Config object stays behind. When creating new releases it seems we are doing things like selecting the latest Config from the App or something... If the latest Config object is poisoned in a way that is hard to fix then.
Basically the User ends up in a situation where it becomes pretty hard / impossible to recover from
Experiment
I did a quick experiment and used the DB directly after creating a few releases with combinations of config and build changes - First I tried deleting a release by hand, no config / build objects went away, and then I went and deleted a config object attached to 2 releases and both releases went away.
Potential solutions
I reviewed a few solutions and how they would affect us

Flip the FK relationship around

This would require the biggest rewrite as Config and Build objects can't be created without Release

Start programmatically handling the "when to delete config / build as well" and such

Brittle as I will also have to look at all the latest() usages and try to reconcile things

Create a 1:1 between Release and Config/Build and severing the Config/Build tie with the app_id making Release the only connection, turning a Release into a ledger of sorts

Allows us to treat the Release as an artefact but will make the DB bigger

@helgi  I see your point about strange behavior after deleting a Release, but the Release object is not intended to be deleted.  I don't believe we exposed an API for that.  Where are we seeing this come up?  Rollbacks maybe?

We delete Release objects ourselves if are in the middle of a deploy and that bombs - There's at least 2 if not 3 places that do that. This is not an end user triggerable thing beyond messing up their deploy in some way (see #792 for intentional mess up)

Sorry, #785 has the intentional mess up story that triggers this

I think the third option seems the cleanest and most reasonable. If I understand correctly, every time a config value changes or a build changes we create a new release object. This is actually a pretty reasonable thing in my opinion. If you were doing releases manually and you needed to change config values that would more than likely result in a new release.

This issue was moved to teamhephy/controller#64


Default values for backup_window and maintenance_window conflict

Commit 5ebc8bfe1d479755256521f2660a853126b1f512 introduces a conflict between the default value of backup_window and that of the new maintenance_window parameter.
They must not overlap.

@robinbowes Thank you for prompt feedback! Reverted.


refactor porter

Eip Address Management via CRD
refactor Porter High Availability
Changes to the BgpConf/BgpPeer API to be compatible with the gobgp API and to support viewing status.
Some other changes

Signed-off-by: Duan Jiong<EMAIL_ADDRESS>

/assign @zheng1

/lgtm
/approve

Here is some error
root@master:~# kubectl apply -f https://raw.githubusercontent.com/kubesphere/porter/master/deploy/porter.yaml
namespace/porter-system unchanged
customresourcedefinition.apiextensions.k8s.io/bgpconfs.network.kubesphere.io configured
customresourcedefinition.apiextensions.k8s.io/bgppeers.network.kubesphere.io configured
customresourcedefinition.apiextensions.k8s.io/eips.network.kubesphere.io configured
role.rbac.authorization.k8s.io/leader-election-role unchanged
error: error parsing https://raw.githubusercontent.com/kubesphere/porter/master/deploy/porter.yaml: error converting YAML to JSON: yaml: line 44: did not find expected '-' indicator

/assign @FeynmanZhou

Here is some error
root@master:~# kubectl apply -f https://raw.githubusercontent.com/kubesphere/porter/master/deploy/porter.yaml
namespace/porter-system unchanged
customresourcedefinition.apiextensions.k8s.io/bgpconfs.network.kubesphere.io configured
customresourcedefinition.apiextensions.k8s.io/bgppeers.network.kubesphere.io configured
customresourcedefinition.apiextensions.k8s.io/eips.network.kubesphere.io configured
role.rbac.authorization.k8s.io/leader-election-role unchanged
error: error parsing https://raw.githubusercontent.com/kubesphere/porter/master/deploy/porter.yaml: error converting YAML to JSON: yaml: line 44: did not find expected '-' indicator

There was an indentation error, the keyboard mishandled when I submitted it.

@Patrick-LuoYu Do we have the relevant guides for these two features in v0.4.0? How to test them from the end user side?

@Patrick-LuoYu @duanjiong @zheng1 Do we have the relevant guides for these two features in v0.4.0? How to test them from the end user side?

End-users look at the documentation on the line, unclear we improve the documentation, there are problems with the issue we fix on the line, with the use of documentation is also a test, why do we have to get a separate set of test cases.


Fatal error for rmf_traffic_schedule-1

Bug report
Required information:

Operating system and version: Ubuntu 20.04
OpenRMF installation type: From source, following install in https://github.com/open-rmf/rmf for galactic
OpenRMF version or commit hash: latest commit, 92972bffbdb3c4e8e4bfb8b1238047d876c07f38
ROS distribution and version: galactic
ROS installation type: from binary
Package or library, if applicablle: N/A

Description of the bug
get error [rmf_traffic_schedule-1] [FATAL] [1660195044.439489807] [rmf_traffic_schedule_primary]: Failed to correctly load participant registry: yaml-cpp: error at line 9, column 16: bad conversion in terminal
No map displayed in rviz, but the lift and doors are present
Steps to reproduce the bug

Launch RMF using ros2 launch rmf_demos office_demo.launch
See the error displayed in rviz panel and error message in terminal

Look for a file called .rmf_schedule_node.yaml in the directory that you are launching RMF from. Please copy/paste the contents of that file into a gist and share a link to the gist here. That will help us diagnose if something has gone wrong within RMF to lead to this error.
After you've done that, delete the file and everything should go back to working as normal.
We should improve the error message to specify the file location and to recommend fixing or deleting it as a solution to this error.

- operation: Add   participant_description:     name: caato_1     group: caato     responsiveness: Responsive     profile:       footprint:         type: Circle         index: 0       vicinity:         type: Circle         index: 1       shape_context:         - 0.5         - 0.6
So thank Dr.Grey, it was resolved after deleting this file.


Introduction to java servlets

Article checklist
ATTENTION: In your PR - add the ISSUE (topic form) # that this PR corresponds to. You can do this by also adding a comment that states "This fixes #(enter your Idea Content Form #)" to link and close your Idea Content (issue) when the PR is merged.
NOTE: (Please ensure that you have only one open issue + linked pull request at a time. This will ensure that we complete the article in a timely manner from inception to publishing.)
If you have not already please go over our Resources Page for more tips and tricks on how to improve our overall technical writing.
Preliminary Checks - Formatting and Structure

[x] Is the article you are submitting an in-depth and unique article? Does it go beyond what is in the official docs and what is covered in other blog sites. See these articles as examples.
[x] Does your article follow any of the suggested structure formats? - see example formats
[x] Is your article properly formatted in Markdown? - see Github Markdown guide
[X] Have you used the correct folder and file structure? - see Contribution Guidelines
[x] Is your article over 750 words? - Tool: Wordcounter.net
[X] Have you used our preferred heading structure? - H3 (###) and up
[x] Does your article provide enough value and detail about your topic? - Articles should be clear, accurate, and fully explained.
[x] Can your article be understood by beginners? - Assume the audience is smart but has no prior exposure to the common terminology in your article.
[x] Have you included a hero image that is 600x400 pixels and have the copyright to use it? - Tools: Pixlr Image Editor for resizing and Unsplash for Creative Commons images
[x] In your PR - add a comment that states "This fixes #(enter your Idea Content Form #)" to link and close your Idea Content (issue) when the PR is merged.

Grammar & plagiarism checks

[x] Have you spellchecked and grammar checked your article? - Tools: Write&Improve - ProWritingAid -  Grammarly
[x] Please place your article through a 3rd party plagiarism checker? We suggest using Quetext, this tool is free and has a daily limit. We typically accept articles with 10% or less.
[x] Have you checked your article for readability? - Tool: Hemmingway
[ ] Have you added sources for quotes and images that aren't yours?

Technical checks

[x] Are your code snippets properly formatted for syntax highlighting - see Syntax guide

Contribution guidelines
For first-time contributors and for more details, see Contributing Guidelines
This fixes #2898

plagiarism check done

hello @Dawe-7 done with requested changes. Thank you

@munenekelvin, Kindly go through the suggestions once more because I can see some that have not been implemented. Plus, include the prerequisites section.

@Dawe-7 done.

@hectorkambow, This article is ready for final review.
cc: @louisefindlay23

Hi @munenekelvin
Thanks for this article. Easy to follow through and quite informative. Keep up the good work.
Just minor changes.
cc: @Dawe-7


Fix crashes on Android

@tominou Thank you for the PR. I see the changes mostly checking null, would you use if () { return; } pattern to avoid too many indentation changes?

@ratson Changes made. Better this way indeed ^^


collect build content from pom.xml or gradle.build

check: https://github.com/h1alexbel/sr-detection/issues/69#issuecomment-2373633132

@h1alexbel 2 puzzles #117, #118 are still not solved.

@h1alexbel the puzzle #118 is still not solved; solved: #117.

@h1alexbel the puzzle #122 is still not solved; solved: #117, #118.


libsodium-sys: split lib.rs in multiple files

Splits lib.rs in multiple files corresponding to the original c header files. Now it's easier to maintain libsoidum-sys.

Thanks for this pull request, it'll make the maintenance of libsodium-sys a lot easier in the future. It'll take a while for me to review the patch though (nothing personal, I review all commits to sodium oxide since it's a cryptographic library), that's why I haven't merged it yet.
Just wanted to let you know that the patch is well appreciated.


Feat idle connection resiliency

Idle Connection Resiliency aims to provide built-in reconnection logic that restores most of the session state in a wide subclass of connection break situations, in which connection failure happens before client starting sending the command.

/azp run

/azp run

/azp run public-mssql-jdbc.linux


Is it possible to slide down and close the activity ?

Since the issue is solved I guess someone can close this issue.


Change logo with the new one

Upload the new logo

@ClementMayer Could you provide the SVG for this?
Also for @maeldebon we'll need to extract only the triangle part for the favicon.

Could you try with this one? I havent got the horizontal on SVG but this one should be ok.
Substra_Logo couleur_RVB.svg.zip

The vertical logo won't fit into the layout. I'll try to modify the SVG you gave me so that it is horizontal and then provide it to @maeldebon.

Substra logo new.zip
@maeldebon here are the SVG for the horizontal logo and all of the favicons. I included 2 versions of the horizontal logo: one with whitespace and one without. I think the one without should be the one to be included.

Alright, thanks!

@ClementMayer It looks like the SVG you gave me declares the text as SVG shapes but the triangle itself is actually a PNG image. Do you have a full-shape version available ? Even one without text is fine, I'll assemble them together.

Could you tell me if this one is ok?
Substra_Sigle couleur_RVB.svg.zip

It's the same thing, it's actually an inlined JPEG within a SVG with SVG white shapes on top of it.

Ok so I need to wait the Graphical designer at the end of August.

No worries, let me know then!


Invalid sprite message in second screen.

I also got a hang after a while in second screen, after kill first wave of aliens, but not alwais (with me Green message of invalid Sprite)

Re-write the sprite image adding/removing code.
Now has better error messages if this re-occurs.


No sound after video compression

No sound after video compression

Hi @Yange820 Yange820
use below mp4parser:isoparser for compress lib instead of 1.1.22
implementation 'com.googlecode.mp4parser:isoparser:1.0.6'

doesnt work, gives dependencies issues of duplicate files etc in 1.0.6 ... any solution to no sound after compression in 2.2.3?

Hi @Yange820,
Instead of his gradle dependency, do one thing copy his entire lib package and paste it in your project folder and use gradle dependencies -> implementation 'com.googlecode.mp4parser:isoparser:1.0.6' it will work. It's working for me.

I have chosen a new plan. But thank you for your reply
------------------ 原始邮件 ------------------
发件人: "Dibakar<EMAIL_ADDRESS>发送时间: 2020年4月28日(星期二) 下午4:33
收件人<EMAIL_ADDRESS>抄送: "颜格"<979291980<EMAIL_ADDRESS>主题: Re: [Tourenathan-G5organisation/SiliCompressor] No sound after video compression (#139)
Hi @Yange820,
Instead of his gradle dependency, do one thing copy his entire lib package and paste it in your project folder and use gradle dependencies -> implementation 'com.googlecode.mp4parser:isoparser:1.0.6' it will work. It's working for me.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or unsubscribe.

Hi @Yange820,
Instead of his gradle dependency, do one thing copy his entire lib package and paste it in your project folder and use gradle dependencies -> implementation 'com.googlecode.mp4parser:isoparser:1.0.6' it will work. It's working for me.

It workd for me, Thanks!


ntr Trm8-Trm82 complex

Trm8-Trm82 complex
synonyms
tRNA (m7G46) methyltransferase
tRNA m7G methylation complex
refs
https://www.ncbi.nlm.nih.gov/pubmed/18184583
https://www.ncbi.nlm.nih.gov/pubmed/17382321
https://www.ncbi.nlm.nih.gov/pubmed/18164779
parent
tRNA methyltransferase complex (GO:0043527)
standard def
suggest
A protein complex involved in the catalysis of the formation of the modified nucleotide 1-methyl~adenosine~ guanine (m17) in tRNA. In yeast, it is a heterotetramer of two subunits, Trm8 (catalytic) and Trm82 (WD repeat).

The synonyms and references indicate G methylation but your def indicates adenosine methylation.
? Confirm def please?

Ok; just checking; and I must say that PMID: 18164779 is a really cool paper!!
What is the m17? do you mean nt 46?

yes thats a hangove from the old def too...

A protein complex involved in the catalysis of the formation of the modified nucleotide 7-methylguanine (at position 46  in certain tRNAs, such as tRNA(phe). In yeast, it is a heterotetramer of two subunits, Trm8 (catalytic) and Trm82 (WD repeat).

@ValWood , I think it should be named tRNA (m7G46) methyltransferase complex to be consistent with it's sibs. Your suggested name would be a synonym.

OK!

GO:0106143


vscript: Move squirrel types to their respective files

Mostly taken from primedev, just moves some structs around.
Things to test:

Does the video game run
Do script commands work (ei script_client, script, ...)
Idk

This one is gonna require a lot more extensive testing to actually verify correctness. That's not gonna happen. So the best we can do is just test in prod and hope that any issues get reported back to us (no remote logging to do that automatically ;-;)


Chocolatey GUI does see newest version of packages

Crawling through the history of Issues here, this looks like a recurring bug (#585).
Description
There is at least one package with update available in my list. I can see it via Power Shell command. Yet the latest version does not show up in the Chocolatey GUI.
System
chocolatey 0.10.15
chocolatey-gui 0.16.0
PowerShell 5.1.18362.145
Windows 10 Pro 1903
Screenshots

@jmacura the issue that you link to was fixed in version 0.17.0 which hasn't shipped yet.  You are still using 0.16.0.  If you want to take the pre-release for a spin, you can find the installation instructions on the readme of this repository.

Honestly, it really didn't crossed my mind, that it takes almost 2 years to make a new release...
Seriously, what's blocking the 0.17.0 to be shipped to the public?

@jmacura this is a community driven open source project, and there are no timescales associated with releases.  The pre-release version is currently considered stable, and there are upstream reasons why we haven't yet shipped 0.17.0.  My suggestion would be that you install the pre-release version, and when 0.17.0 is shipped, it will be a simple upgrade to move to the latest version.


Multiple Choice Template for NFL, MLB, NBA,

What team will [Player's name] sign with?
use Event expiration date and time picker
Outcomes Must Include

Other (Field)
Unsigned

Added Resolution Rules
Player named must have signed a contract on or before the markets Event Expiration
If the player signs with a team not named in the outcomes, "Other (Field)" should be determined the winning outcome
If the player is not officially signed by the markets Event Expiration "Unsigned" should be determined the winning outcome

added - closing


⚠ Bofrost.es has degraded performance

In ea512d7, Bofrost.es (https://www.bofrost.es) experienced degraded performance:

HTTP code: 200
Response time: 1526 ms

Resolved: Bofrost.es performance has improved in ba1ae8b after 1 hour, 22 minutes.


check if ms parameter is a number for delay method

👍

Bluebird used to do this but it was removed because users expected setTimeout like behavior and things having .valueOf working.
You can use a type checker to enforce this if you'd like.

It's a shame, it can cause an edge effect... 🤕


Bump mockito and bytebuddy

Description
Bump mockito and bytebuddy
Related Issues
N/A

Check List

[ ] New functionality includes testing.

[ ] All tests pass

[ ] New functionality has been documented.

[ ] New functionality has javadoc added

[X] Commits are signed per the DCO using --signoff
[X] Commit changes are listed out in CHANGELOG.md file (See: Changelog)

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@reta I will take care of the pending 2.x backports for all the bumps from this week.


Missing checksums for other than Linux in 0.35.0 release

What happened:
Missing checksums for windows in 0.35.0 release
091d89fff91eac8c6437b291b6a35dde692231ba92c8b44a47f648113d3aec38  syft_0.35.0_linux_amd64.rpm
583433c8d31ae8b78b033f2907686ca3c67b9c2e8687fe2401e17a1b28d6bea6  syft_0.35.0_linux_arm64.deb
5912abf7a5b8bfa30f1bd00ec4f8715734adbab10f413c7bbef9b1cea47e55d0  syft_0.35.0_linux_arm64.tar.gz
5eddcf20dc3d19dd2a23ec5fd1c29dd74a9589dd3a799708a881b9cd6205fccc  syft_0.35.0_linux_amd64.tar.gz
9b921e8de17d1413c508ae8cead80c11e892af19bb3c430c1024e9da6b5bbc06  syft_0.35.0_linux_amd64.deb
f14d16df7554c97199450ec7c0f49313a6932551065619afd1c6d1c67f34abab  syft_0.35.0_linux_arm64.rpm

What you expected to happen:
052915bde04071ec5e60ad20181ff74f9c72d474a857164560a3c7b40dd4a832  syft_0.34.0_darwin_amd64.zip
0efee88a90e46f86be62f45cdeb416d2e0734dcfebc6f4fec6b41bcbbd2645fa  syft_0.34.0_linux_amd64.tar.gz
12466317791a760038484e6e8ae5789672b00a5b9960e32ee30cf214ca05310b  syft_0.34.0_linux_amd64.rpm
7f38731850caea76fab26809743ab18ddcdc23d2e88c4448bcbfb4f90bbebc43  syft_0.34.0_linux_arm64.deb
84dd287cebba6c0278a883dbb233c0ae38b0c9c1d272e01a4c7046bba46a9c07  syft_0.34.0_darwin_arm64.zip
8eb6ef0305f371b7567b709947944ea5eeb5f342bcf40723f43f861661a18c51  syft_0.34.0_linux_arm64.rpm
d733efcef8bc0316478b80fe97a01216f5be4a2c4fa749dc78a2510783f5bbd2  syft_0.34.0_linux_amd64.deb
fc8e2cee22cc82a69a1919fa0b559f750fa7fca44bc8b576709bc5f2bcab481c  syft_0.34.0_linux_arm64.tar.gz
ffbaffa938dbb8c3510c59ae0b96bda2d5f90c4ad7af9077d6480fac1ac6efaa  syft_0.34.0_windows_amd64.zip

How to reproduce it (as minimally and precisely as possible):
cat syft_0.35.0_cheksums.txt

Anything else we need to know?:
Nope
Environment:

Output of syft version:
OS (e.g: cat /etc/os-release or similar):

Thanks @marcinbojko! I'll check the go-releaser config and see where we went wrong here. Just added windows builds recently so really appreciate the issue report!

Thanks @spiffcs, I've created syft chocolatey package, and before I'll upgrade it to use AU I wanted to play with the manual approach first.
Thanks for the excellent software

#740 should round this out and fix it for future releases. Thanks for the quick heads up!

These will be included in either the v0.35.2 release or the v0.36.0 release. We release fairly often so expect it to show up soon. Apologies for cutting v0.35.1 which had vulnerability remediation without this PR being merged.

Unfortunately, release 0.36.0 is also missing checksums

Apologies @marcinbojko:
It looks like the release was cut before https://github.com/anchore/syft/commit/c350bd55f61d64786f05463f952be55c512c553c was merged. We had tested our changes locally and found the checksums to be generating, but this part was not caught before we approved the release. I'll follow up again on the our next release to be sure this change is effective for our new process.


Barebones documentation

Adding sphinx documentation

Codecov Report

Merging #63 into master will increase coverage by 0.06%.
The diff coverage is 100%.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6d6e1b5...f8b8790. Read the comment docs.


Is there a way to use this with the time library to send snaps at specific times?

Title says it all, thanks in advance!

You do realise this is deprecated right?


Update to match breaking API change in the pony standard library (RFC 69)

Also update http dependencies to pick up its changes related to the same
RFC.
This change is backwards compatible with ponyc 0.40.0

The tests against nightly were failing due do this.

@ergl this doesnt need a release notes entry as its an application and the changes are "end user interesting" given that it isnt a library.

@SeanTAllen Okay, I've removed them.

There appear to be other failures against nightly.

@SeanTAllen I've bumped the appdirs dependency, I think it should be fine now

I pushed an update to the appdirs dependency as apparently that was needed for... reasons I need to look into.

@ergl you beat me to it


frontend: Explore adding unit tests for React components

Just as it's important to write tests for your APIs in the backend, is just as important to write tests in the frontend as its complexity increases. Manually testing can only take you so far.

Zustand stores should also be tested. This article provides a way to go about how to do such a thing.


Migrate to config flow

Introduce config flow

Hi, thanks for picking up maintenance of this plugin!
I've also been hit by some of the issues you seem to have fixed here, thanks! But also noticed the deprecation by Hein, and already planned to port TCP support from this plugin to
https://github.com/robbinjanssen/home-assistant-omnik-inverter - this HASS plugin from Robbin already has config flow support :partying_face:
The first step is already in progress, bringing it to the reusable python-omnikinverter https://github.com/klaasnicolaas/python-omnikinverter/pull/134 package.
When TCP support is done, perhaps you're interested in migrating to and aiding in maintenance of https://github.com/robbinjanssen/home-assistant-omnik-inverter and related Python packages? That way there won't be two more-or-less-identical plugins around, which has confused me as beginning HASS user.

Hi @MarijnS95
Thanks for the suggestion. Always happy to join forces and to learn from others. Relatively new to python myself, got a C/C++ background.
Let me know how you'd like to proceed and let's pick up from there.
Cheers

@hultenvp For now I'll keep working on the TCP backend and keep you / this project in the loop, you can also follow the above PR to track progress.
Then, as time goes on and TCP source support lands in python-omnikinverter and https://github.com/robbinjanssen/home-assistant-omnik-inverter it is probably up to everyone to test the new functionality and make the switch, after which it is - however weird it feels to say this - probably recommended to also archive this approach and recommend everyone to use the unified plugin.
That implies the unified plugin works for everyone, which may take some time. You're of course always free to do however you wish with this plugin :smile:

Hi @hultenvp, apologies for not checking in yet. The TCP backend feature has finally landed in https://github.com/klaasnicolaas/python-omnikinverter/pull/134 and https://github.com/robbinjanssen/home-assistant-omnik-inverter/pull/110 so I can recommend you to switch to that integration instead of implementing/maintaining it yourself :tada:
Contributions are always welcome, I have some more improvements planned for it too!

@heinoldenhuis hijacking this thread to make you aware too; how do you feel about pointing to https://github.com/robbinjanssen/home-assistant-omnik-inverter as a viable alternative for your plugin?

Would prefer if this extension still lives, because this version supports my Trannergy with TCP stream.
The version of robbinjanssen not yet, however the implementation looks quit clean within the current releases of HA.

The version of robbinjanssen not yet

@rob-on-git What exactly do you need? I implemented the TCP stream in that plugin and it has has also been released.
If there's anything that plugin needs to do to be compatible with your Trannergy let me know! Even if it's just adding it to the list of supported models - because I can't test this for you :wink:

Hi both.
I agreed with Marijn to sunset this integration. Haven't done it yet, I'm a winter coder ;-).
My proposal is that you check Marijn's integration. If it does not work then I'm fine keeping this one alive till support could be added.
It will be here anyway till the weather turns sour again.
Cheers

If there's anything that plugin needs to do to be compatible with your Trannergy let me know

I have to verify what might be the issue, but when configuring within the GUI, i cannot connect to the TCP stream (while i do see traffic)

With serial 0: a short burst of traffic, and timing out
With serial of device: Short burst of traffic and saying 'cannot connect'

PS: It's a Trannergy model SGN4000TL


Editors: Shadow Block Class

Create a shadow block editor class which any editor controller will extend if it uses shadow blocks (toolbox and workspace editor). Functions that manage shadow blocks can be inherited from this class.

Addressed in #149.


SDL_GamerController Instance Id

Hi
Quick query. Have been looking at the Sdl2ControllerTracker.
On start up it loops through the number of joysticks based on the SDL_NumJoysticks. It uses that index to check if the Joystick is a Gamecontroller and then opens the controller using that same index.
In the method description for SDL_GameControllerOpen it mentions that this index is NOT the same as the instanceId that should be used later to identify which controller is firing an event (the .which property of later controller events).
However in your example you compare this .which property to the original index of the controller. I also do not notice a way to get back the actual instanceId of a newly created controller. There only appears to be the function to get back a controller from an instanceId.
Is the method description accurate for SDL_GameControllerOpen? does the actual instanceId need to be exposed somewhere or am i missing something?
hope that makes sense
thanks
EDIT: I might as well ask it here. I couldn't work out why you fire Sdl2Events.ProcessEvents() three times in the NeoDemo loop line 225 ish. I've found i don't seem to need to even call this when I have subscribed already. would appreciate if there is some flushing / issues that require this.

As far as I can tell, you are right about this, but I'm not an expert on SDL2's controller handling. The "instance ID" of a controller is technically different from the index you use to "open" it, and has to be queried separately using SDL_JoystickInstanceID. That function is already exposed in Veldrid.SDL2, as is SDL_GameControllerGetJoystick, which is needed to get an SDL_Joystick from an SDL_GameController. It turns out that in practice, opening a joystick / game controller with index 0 results in an instance ID of 0, so there's no functional difference on my machine. However, I only have on controller plugged in, and there doesn't seem to be any guarantee in the SDL2 API that this would always be true. So it's definitely more correct to actually query for the iD. Sdl2ControllerTracker has been updated on the master branch to do that.

EDIT: I might as well ask it here. I couldn't work out why you fire Sdl2Events.ProcessEvents() three times in the NeoDemo loop line 225 ish. I've found i don't seem to need to even call this when I have subscribed already. would appreciate if there is some flushing / issues that require this.

Yeah, that's just a copy/paste error, which I'll fix. However, you do need to call Sdl2Events.ProcessEvents() somewhere to pump the SDL2 event loop. Subscribing to the callback by itself doesn't cause the events to be processed automatically -- you still have call the method.

Thanks for the response, all makes sense. I didn't notice SDL_JoystickInstanceID, for some reason it isn't in the package I restore. I see it was added to the repo 30th March, so I assume it is in 4.6.1, but perhaps i have to wait for it to feed through or clone master. no doubt something odd my end. thanks again

Yes unfortunately it was added in the commit after 4.6.1. So it will be included in the next version, but otherwise you can get it from the master branch here (or a prerelease package).

sorry to ask, but as i'm unable to use the master branch (some complications on arch linux i think), am keen to use a pre-release package from myget. but i seem to be being dense, i don't see anything later than 4.6.1 on 29th march. pretty sure i'm missing something obvious. thanks


captureException() fails with HTTP Status Code 413

I'm browserify & minify my code base into a single huge JS with just a few lines of code (but many, many characters per line obviously). While the code itself works fine, it fails to upload any captured exception to getsentry.com with HTTP Status Code 413.
I could nail it down to the minification. If I'm running the unminified version (still one huge JS file, but this time with many lines of code) then POSTing the exception works as expected. I'm guessing that the reason is that Raven tries to submit callstack information and gets thrown off by the fact that pretty much everything is in a single line of code.
In an ideal world I want to upload my source map to Sentry and have Raven-Node/Sentry figure the rest out. Or maybe I should use raven-js instead of raven-node although I'm running server-side?

That's definitely the problem. We also don't even support source maps for node. That's exclusively a browser JavaScript feature for us now.
Since this is a bit confusing to me, can you share some context on why you'd do this for a Node deployment in the first place?

https://github.com/arabold/serverless-sentry-plugin -- this is why :)
We're developing projects for AWS Lambda using the popular Serverless framework. For AWS Lambda it is common to browserify and minify the code base as it improves loading time. The link above is for a plugin that automatically instructs your code to report errors to Sentry.

Running into the same issue.  Any update or work around for this?
Thanks!

just got bit by this too...   4 hrs of life...

@sid137 sorry to hear that :(
I'll look into this more today, especially since it seems we'll have more folks with long single lines after the recent webpack compatibility workaround in v2.0.0 and the generally increasing popularity of lambda.
Sourcemap support is a relevant topic here, and it's on the roadmap, but it's definitely a bigger undertaking and we don't consider it to be quite as crucial of a feature as it is in the browser, for a number of reasons. A fix for the 413 problem specifically should be pretty straightforward, hopefully just a "if line longer than x, truncate" check.

Fixed in https://github.com/getsentry/raven-node/commit/8e111ffd1be85ac18e51f446c05ede9f513171cc#diff-50e3aa130a4f97a42ee2cf111c7b1d9d
Also confirmed that stack size for raw express.js app, bundled with browserify and uglifyjs is below 50kb, which fits easily into payload limit.


Equality comparison by properties

Summary
When comparing values, AssertJ takes a very strong opinion that the objects are defined by their fields, which is contrary to general Java best practice and makes testing interface-based code difficult. It seems that AssertJ will internally use property-based access as some kind of fallback, but it has eager fast-fail on some very ordinary use cases.
Instead, AssertJ should prefer property-based access when it's declared, and it should not perform invasive introspection if a perfectly suitable public property is available.
Example
interface MailMessage {
  String getTemplate();
  InternetAddress getRecipient();
}

class HelloMessage implements MailMessage {
  @Override public final String getTemplate() { return "hello"; }
  @Getter @Setter InternetAddress recipient;
}

@Getter
@Setter
class GenericMessage implements MailMessage {
  String template;
  InternetAddress recipient;
}

In my code, I want to assert that, after processing, var original = new HelloMessage() and var result // instanceof GenericMessage have the same property values. However, trying to use assertThat(result).usingRecursiveComparison().isEqualTo(original) produces this error:
GenericMessage can't be compared to HelloMessage as  does not declare all GenericMessage fields, it lacks these: [template]

template is most certainly declared as a property, which is all that most infrastructure cares about, and the old isEqualToComparingFieldByField, even though named "field", handled this fine.

Similarly, it would be nice if we could force PROPERTIES to be used, rather than fields.
Or another way to put it, I suppose, is to only use a property as a comparison if it has a get____() function built in.

I agree, we already have created https://github.com/assertj/assertj-core/issues/2189, it is a wip but as it's rather complex I can't say when this will be addressed.

@chrylis I'm finishing off https://github.com/assertj/assertj/issues/2189 which will allow to provide the way to introspect nodes to be compared in the recursive comparison (properties, fields ... implementor choice).
I try reproducing your issue but could not which I think is due to the use of https://github.com/assertj/assertj/blob/main/assertj-core/src/main/java/org/assertj/core/util/introspection/PropertyOrFieldSupport.java#L65 in the recursive comparison which looks at property first and field second.
Here's the code I ran which is a simplified version of your example:
  @Test
  void should_pass_with_property_based_introspection() {
    // GIVEN
    Message actual = new HelloMessage();
    Message expected = new GenericMessage("hello");
    // WHEN/THEN
    then(actual).usingRecursiveComparison()
                .isEqualTo(expected);
  }

  interface Message {
    String getTemplate();
  }

  class HelloMessage implements Message {
    public final String getTemplate() {
      return "hello";
    }

  }

  class GenericMessage implements Message {
    String template;

    public GenericMessage(String template) {
      this.template = template;
    }

    @Override
    public String getTemplate() {
      return template;
    }
  }

@chrylis , we have finally got the time to address  #2189 which is why I'm closing this issue.
I actually wrote a test using an introspection strategy that addresses this issue, see:
I'm planning to expose the ComparingProperties introspection strategy implementation in AssertJ so that it's available out of the box for users like yourself (we'll likely do the same with ComparingFields).
We need to discuss in the team to switch the default introspection strategy implementation to ComparingProperties, I'm closing this issue and might create another one to decide on the the default introspection strategy.
Feel free to comment on the issue if you feel it's not fully addressed and we'll be happy to reopen it.


"The package 'NLog' tried to add a framework reference to 'System.IO.Compression' which was not found in the GAC. This is possibly a bug in the package."

Type (choose one):

Bug

NLog version: (e.g. 4.2.3)
5.0.0-beta09
Platform:  .NET Framework 4.7
Issue
When installing the NuGet package of 5.0.0-beta09 to my .NET Framework 4.7 unit test project, I get the following error:
Attempting to gather dependency information for package 'NLog.5.0.0-beta09' with respect to project 'Tests.NetFramework', targeting '.NETFramework,Version=v4.7'
Gathering dependency information took 662,02 ms
Attempting to resolve dependencies for package 'NLog.5.0.0-beta09' with DependencyBehavior 'Lowest'
Resolving dependency information took 0 ms
Resolving actions to install package 'NLog.5.0.0-beta09'
Resolved actions to install package 'NLog.5.0.0-beta09'
Found package 'NLog 5.0.0-beta09' in 'C:\Source\Toolkit\packages'.
Package 'NLog.5.0.0-beta09' already exists in folder 'C:\Source\Toolkit\packages'
Install failed. Rolling back...
Package 'NLog.5.0.0-beta09' does not exist in project 'Tests.NetFramework'
Executing nuget actions took 1,1 sec
Failed to add reference. The package 'NLog' tried to add a framework reference to 'System.IO.Compression' which was not found in the GAC. This is possibly a bug in the package. Please contact the package owners for assistance.
  Reference unavailable.
Time Elapsed: 00:00:01.7830560
========== Finished ==========

I thereby contact the package owners for assistance!

Manually installing System.IO.Compression from NuGet beforehand appears to work around this issue.

I noticed a build warning after doing the above. Possibly related?
4>    There was a conflict between "System.Security.AccessControl, Version=<IP_ADDRESS>, Culture=neutral, PublicKeyToken=b03f5f7f11d50a3a" and "System.Security.AccessControl, Version=<IP_ADDRESS>, Culture=neutral, PublicKeyToken=b03f5f7f11d50a3a".
4>        "System.Security.AccessControl, Version=<IP_ADDRESS>, Culture=neutral, PublicKeyToken=b03f5f7f11d50a3a" was chosen because it was primary and "System.Security.AccessControl, Version=<IP_ADDRESS>, Culture=neutral, PublicKeyToken=b03f5f7f11d50a3a" was not.
4>        References which depend on "System.Security.AccessControl, Version=<IP_ADDRESS>, Culture=neutral, PublicKeyToken=b03f5f7f11d50a3a" [C:\Users\saares\.nuget\packages\system.security.accesscontrol\4.0.0\ref\netstandard1.3\System.Security.AccessControl.dll].
4>            C:\Users\saares\.nuget\packages\system.security.accesscontrol\4.0.0\ref\netstandard1.3\System.Security.AccessControl.dll
4>              Project file item includes which caused reference "C:\Users\saares\.nuget\packages\system.security.accesscontrol\4.0.0\ref\netstandard1.3\System.Security.AccessControl.dll".
4>                C:\Users\saares\.nuget\packages\system.security.accesscontrol\4.0.0\ref\netstandard1.3\System.Security.AccessControl.dll
4>        References which depend on "System.Security.AccessControl, Version=<IP_ADDRESS>, Culture=neutral, PublicKeyToken=b03f5f7f11d50a3a" [].
4>            C:\Users\saares\.nuget\packages\system.threading.accesscontrol\4.0.0\ref\netstandard1.3\System.Threading.AccessControl.dll
4>              Project file item includes which caused reference "C:\Users\saares\.nuget\packages\system.threading.accesscontrol\4.0.0\ref\netstandard1.3\System.Threading.AccessControl.dll".
4>                C:\Users\saares\.nuget\packages\system.threading.accesscontrol\4.0.0\ref\netstandard1.3\System.Threading.AccessControl.dll
4>            C:\Users\saares\.nuget\packages\system.io.filesystem.accesscontrol\4.0.0\ref\netstandard1.3\System.IO.FileSystem.AccessControl.dll
4>              Project file item includes which caused reference "C:\Users\saares\.nuget\packages\system.io.filesystem.accesscontrol\4.0.0\ref\netstandard1.3\System.IO.FileSystem.AccessControl.dll".
4>                C:\Users\saares\.nuget\packages\system.io.filesystem.accesscontrol\4.0.0\ref\netstandard1.3\System.IO.FileSystem.AccessControl.dll
4>            C:\Users\saares\.nuget\packages\netstandard.library\2.0.0\build\netstandard2.0\\ref\mscorlib.dll
4>              Project file item includes which caused reference "C:\Users\saares\.nuget\packages\netstandard.library\2.0.0\build\netstandard2.0\\ref\mscorlib.dll".
4>                C:\Users\saares\.nuget\packages\netstandard.library\2.0.0\build\netstandard2.0\\ref\mscorlib.dll
4>    C:\Program Files (x86)\Microsoft Visual Studio\2017\Enterprise\MSBuild\15.0\Bin\Microsoft.Common.CurrentVersion.targets(1987,5): warning MSB3277: Found conflicts between different versions of the same dependent assembly that could not be resolved.  These reference conflicts are listed in the build log when log verbosity is set to detailed.

Same happens to me

same here

Does anyone know how to fix this?

I tried to take a look but I do not understand how the NuGet package is even generated. The published NuSpec has comments along the lines of **BREAKING CHANGE in beta08 !!** but I cannot find such text anywhere in the source tree and GitHub search here also gives me nothing.
Can you provide some relevant code references so this can be investigated?

The nuget package description is edited on nuget.org. A bit easier to maintain descriptions.

Opened https://github.com/NuGet/Home/issues/5813 with regard to the assembly reference warnings.

Thanks!
I'm also unsure how to fix this. I'm now one holiday, will try to check this before the end of next week

Very strange that NET 4.7 attempts to use the dependencies of NetStandard.
NET47 should use the closest match, which is NET45, and not NetStandard. Almost sound like https://github.com/NuGet/Home/issues/4165

@sandersaares + @osoykan Are you using latest VS2017 (Version 15.3.2) ?

Have now removed the following unneeded package-references from the NLog 5-project (See #2269):
    "System.IO.FileSystem.AccessControl": "4.0.0",
    "System.Security.AccessControl": "4.0.0",
    "System.Threading.AccessControl": "4.0.0"

But I think these "conflict" warnings are just telling you, that your current target-framework is using a higher version of the specified package-references. Which is okay for NetCore2/NetStandard2 projects as they have higher versions than NetStandard15

Looks like something has been fixed for NLog in VS2017 15.3.3 (Released August 29th):
https://developercommunity.visualstudio.com/content/problem/96301/vs-153-update-causes-package-is-not-compatible-for.html

@snakefoot,
It was not 15.3.3, it is 15.3.2 i think. i'll give a try with new version of visual studio, hope they fixed this.

But it actually looks like these warnings are "expected", and should be handled manually with binding-correction (See solution):
https://developercommunity.visualstudio.com/content/problem/95070/could-not-load-file-or-assembly-systemruntime-vers.html#reply-98340
Still not sure why you get errors when targeting Net462 and Net47 as they should use the Net45-nuget-lib. Maybe it is because your Net47-project is depending on a NetStandard-library that depends on NLog? (In this case binding correction is apparently needed).

I confirm that I see no change in behavior after upgrading to latest VS 15.3.3. Both problems still occur (the IO.Compression thing and the reference conflict warnings).

@sandersaares Can you edit your original starting post, and attach an example project with dependency on NLog 5.0 BETA09, which reproduces the problem with IO.Compression ?

I would dispute that "are meant to be there" but I hope you meant to say "are there due to tooling defects".
I do not have on hand a solution to repro the problem but the steps are very simple:

Create a new .NET Standard 2.0 library project.
Add a new .NET Framework 4.7 unit test project.
Add a reference the class library.
Attempt to install NLog 5.0.0-beta09 into the unit test project.
Get error about S.IO.Compression

@sandersaares Yes I can reproduce the issue. If I manually add the following references to the test-project before installing NLog as nuget, then it works fine:
System.IO.Compression
System.IO.Compression.FileSystem
I think the correct solution is to add the following option to your test-project before installing NLog-nuget-package (Should be done for all full NetFramework-projects that references NetStandard-projects):
<RestoreProjectStyle>PackageReference</RestoreProjectStyle>
See also: https://www.hanselman.com/blog/ReferencingNETStandardAssembliesFromBothNETCoreAndNETFramework.aspx

@snakefoot is there something we could do about this?

No I think it is working as intended. It is just tooling noise, because people are trying to use NetStandard assemblies from NetFramework projects. Nlog 4.5 should make less noise, and people will learn to configure their NetFramework projecr correct, before adding dependency to NetStandard assemblies.
Sent from my Samsung device
-------- Original message --------
From: Julian Verdurmen<EMAIL_ADDRESS>Date: 27/10/2017 10:57 (GMT+01:00)
To: NLog/NLog<EMAIL_ADDRESS>Cc: Rolf Kristensen<EMAIL_ADDRESS>Mention<EMAIL_ADDRESS>Subject: Re: [NLog/NLog] "The package 'NLog' tried to add a framework   reference to 'System.IO.Compression' which was not found in the GAC. This is   possibly a bug in the package." (#2255)
@snakefoothttps://github.com/snakefoot is there something we could do about this?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHubhttps://github.com/NLog/NLog/issues/2255#issuecomment-339914626, or mute the threadhttps://github.com/notifications/unsubscribe-auth/AK-fnGIik2JZLaapIuBpkHJ0elsuRyrgks5swZr-gaJpZM4O7Im9.

because people are trying to use NetStandard assemblies from NetFramework projects

This is a normal scenario and should not be causing "tooling noise". Now I do suspect it may just be a fault of tooling bugs and there may indeed not be much that can be done here from NLog side but you cannot possibly call this working as intended. The issue should be reported to tooling authors (if not already) and hopefully fixed.
The issues I reported above with Microsoft seem to have not caught much interest from Microsoft so I ran out of ideas for now, though.

Are you getting any noise when you have configured RestoreProjectStyle correctly for the NetFramework to support NetStandard dependencies?
Sent from my Samsung device
-------- Original message --------
From: Sander Saares<EMAIL_ADDRESS>Date: 27/10/2017 11:44 (GMT+01:00)
To: NLog/NLog<EMAIL_ADDRESS>Cc: Rolf Kristensen<EMAIL_ADDRESS>Mention<EMAIL_ADDRESS>Subject: Re: [NLog/NLog] "The package 'NLog' tried to add a framework   reference to 'System.IO.Compression' which was not found in the GAC. This is   possibly a bug in the package." (#2255)
because people are trying to use NetStandard assemblies from NetFramework projects
This is a normal scenario and should not be causing "tooling noise". Now I do suspect it may just be a fault of tooling bugs and there may indeed not be much that can be done here from NLog side but you cannot possibly call this working as intended. The issue should be reported to tooling authors (if not already) and hopefully fixed.
The issues I reported above with Microsoft seem to have not caught much interest from Microsoft so I ran out of ideas for now, though.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHubhttps://github.com/NLog/NLog/issues/2255#issuecomment-339925483, or mute the threadhttps://github.com/notifications/unsubscribe-auth/AK-fnHVqbfGW4-LTFi9IY7-sPjCJ0fhWks5swaXngaJpZM4O7Im9.

I reject the claim that there is a "correct" RestoreProjectStyle for such a situation. All such configuration values are correct. Yes, there may be configuration changes that work around things but that does not make them "correct".

Im guessing that is your way of saying, that the NLog package is working, and you are going to create a new issue for Microsoft to fix Visual Studios way of consuming NetStandard packages in full NetFramework projects
Sent from my Samsung device
-------- Original message --------
From: Sander Saares<EMAIL_ADDRESS>Date: 02/11/2017 11:11 (GMT+01:00)
To: NLog/NLog<EMAIL_ADDRESS>Cc: Rolf Kristensen<EMAIL_ADDRESS>Mention<EMAIL_ADDRESS>Subject: Re: [NLog/NLog] "The package 'NLog' tried to add a framework   reference to 'System.IO.Compression' which was not found in the GAC. This is   possibly a bug in the package." (#2255)
I reject the claim that there is a "correct" RestoreProjectStyle for such a situation. All such configuration values are correct. Yes, there may be configuration changes that work around things but that does not make them "correct".
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHubhttps://github.com/NLog/NLog/issues/2255#issuecomment-341374990, or mute the threadhttps://github.com/notifications/unsubscribe-auth/AK-fnES75GVMcztGL9uU0PnWnPDILyw4ks5syZVRgaJpZM4O7Im9.

As NLog 4.5 now supports (practically) all the platforms added in NLog 5 - without breaking changes - NLog 4.5 should be used instead of NLog 5.
As this is an NLog 5 issue, we will close this. If this is still an issue in NLog 4.5, please create a new issue and reference to this one, thanks!

I confirm that using 4.5-rc3 appears to result in successful package installation in my scenario.

Thanks for the confirmation!

I'm targeting NetFramework 4.7.2 where the System.IO.Compression version is 4.2.0. However NLog marked its dependency for System.IO.Compression version is 4.0.0. Due to this, the Visual Studio Installer (setup generator for Visual Studio 2017) always include both System.IO.Compression version 4.0.0 and 4.2.0 into the generated setup output.


Drop aggregate-error and p-cancelable

Both are now platform-native:

https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/AggregateError
https://developer.mozilla.org/en-US/docs/Web/API/AbortSignal

The whole module needs to be rewritten to make use of these APIs. I'm thinking that when they're all settled and count hasn't been reached, the module can just return Promise.any(input)

👍

I'm thinking that when they're all settled and count hasn't been reached, the module can just return Promise.any(input)

I don't understand. You want it to return a single value then, when the expectation is to get an array of values of the specified count? That sounds very wrong. We could potentially add an option to allow it to return less than count without throwing.

Promise.any() will return an aggregate error exactly like the module is doing, except it builds one for you. Is that not what's happening?

Ah, it was not clear to me that you meant that it should throw like Promise.any, since you used the wording "return".


Fixup broken link to external django documentation

https://docs.djangoproject.com/en/dev/topics/python3/#unicode-literals returns 404.  Updated link to historical archive.

Please advise re: test failure at https://travis-ci.org/PythonCharmers/python-future/builds/286144338?utm_source=github_status&utm_medium=notification.  I don't think it could have been caused by my change.


Added postgresql-license. Closes #323

:+1:

I wonder if we should look at the MYSQL license models as well.  These non-documented features are a PITA.

Couldn't agree more: Looks like MySQL is in the clear from the user-guide

Is there anything else to add to this?

The MySQL license uses the license general-public-license, is this good to merge?

Thanks!


Fixed URL in influxdb kube-config and updated readme

I noticed that the kubectl deploy for influxdb did not work - the external and internal URL and version of API was incorrect.

Can one of the admins verify this patch?

I signed it!

ok to test

Thanks for the fix @huliz!


Workaround the Windows CI install issue.

Fails trom time to time with:
info: installing component 'rustc'
memory allocation of 16777216 bytes failed
Error: The process 'C:\Rust\.cargo\bin\rustup.exe' failed with exit code<PHONE_NUMBER>

on  Build (windows-latest, i686-pc-windows-gnu, feat_os_windows)

This still seems to happen (on x86_64-pc-windows-gnu): https://github.com/uutils/coreutils/pull/2269/checks?check_run_id=2650288868

ah :'(


Cache ideal state and external view paths in RoutingEntry

We see sawtooth allocation patterns in brokers which aren't queried, this allocation comes mainly from maintaining routing tables. Most of this needs to be fixed in Helix, but this small change to store the paths in the routing entries is helpful.

Codecov Report

Merging #8296 (270af0e) into master (e498a71) will decrease coverage by 56.63%.
The diff coverage is 100.00%.

@@              Coverage Diff              @@
##             master    #8296       +/-   ##
=============================================
- Coverage     70.82%   14.18%   -56.64%
+ Complexity     4239       81     -4158
=============================================
  Files          1631     1586       -45
  Lines         85461    83608     -1853
  Branches      12877    12674      -203
=============================================
- Hits          60527    11861    -48666
- Misses        20749    70860    +50111
+ Partials       4185      887     -3298

Flag
Coverage Δ

integration1
?

integration2
?

unittests1
?

unittests2
14.18% <100.00%> (+0.01%)
:arrow_up:

Flags with carried forward coverage won't be shown. Click here to find out more.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e498a71...270af0e. Read the comment docs.


Prints server info on istioctl version

Similar to what kubectl version does, this patch adds the ability
to show server's info on the output.
The default behavior is to just show client info. The flag --remote
was added to show server information. Fetching server info might take
some time, so, it's an opt-in feature rather than a default behavior.
This patch also modifies the output to match the kubectl behavior, i.e.:

Dumps the version structure
Adds JSON and YAML output formats

This is useful for debugging purposes, where one can easily find
the version of each Istio component in the control plane that's
actually deployed.
Examples of usage:

mixs version -o yaml
galley version -o json
istioctl version --remote
istioctl version --remote --short
istioctl version --remote -o yaml

Closes #2491.

[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by:
To fully approve this pull request, please assign additional approvers.
We suggest the following additional approver: nmittler
If they are not already assigned, you can assign the PR to them by writing /assign @nmittler in a comment when ready.
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

istioctl/OWNERS
pkg/OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@jwendell: The following test failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-presubmit.sh
18b9b8850fce58ebcdadb9f09ba3cc677967a7f8
link
/test istio-presubmit

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@liamawhite I've changed the behavior to match the kubectl one. Updated the commit message accordingly. Next natural step is to improve the gitVersion string, but it's better to do it in another PR so that this one doesn't become giant.

@jwendell could you provide an example of the new command in your initial comment?
You may also need to make a trivial change in order to retrigger the circleci tests.

@jwendell: The following test failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-unit-tests.sh
bcc615927bf61e1cbc73d35561860eac7f06e902
link
/test istio-unit-tests

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@jwendell: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-unit-tests.sh
bcc615927bf61e1cbc73d35561860eac7f06e902
link
/test istio-unit-tests

prow/istio-pilot-e2e-envoyv2-v1alpha3.sh
bcc615927bf61e1cbc73d35561860eac7f06e902
link
/test istio-pilot-e2e-envoyv2-v1alpha3

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@jwendell: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-unit-tests.sh
bcc615927bf61e1cbc73d35561860eac7f06e902
link
/test istio-unit-tests

prow/istio-pilot-e2e-envoyv2-v1alpha3.sh
bcc615927bf61e1cbc73d35561860eac7f06e902
link
/test istio-pilot-e2e-envoyv2-v1alpha3

prow/istio-pilot-multicluster-e2e.sh
bcc615927bf61e1cbc73d35561860eac7f06e902
link
/test istio-pilot-multicluster-e2e

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@jwendell: The following test failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/e2e-bookInfoTests-v1alpha3.sh
18bbe8e48563aed0fd38cbd5b25a653904d3667c
link
/test e2e-bookInfo-envoyv2-v1alpha3

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

/retest

@jwendell: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/e2e-bookInfoTests-v1alpha3.sh
18bbe8e48563aed0fd38cbd5b25a653904d3667c
link
/test e2e-bookInfo-envoyv2-v1alpha3

prow/istio-unit-tests.sh
18bbe8e48563aed0fd38cbd5b25a653904d3667c
link
/test istio-unit-tests

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

Here are some outputs with this new behavior:
$ istioctl version
version.BuildInfo{Version:"2e0baef4078274315464da8bbee1fb8d533ce93f-dirty", GitRevision:"2e0baef4078274315464da8bbee1fb8d533ce93f-dirty", User:"jwendell", Host:"jw-laptop", GolangVersion:"go1.10.3", DockerHub:"docker.io/istio", BuildStatus:"Modified"}

$ istioctl version --short
2e0baef4078274315464da8bbee1fb8d533ce93f-dirty

$ istioctl version -o json
{
  "clientVersion": {
    "version": "2e0baef4078274315464da8bbee1fb8d533ce93f-dirty",
    "revision": "2e0baef4078274315464da8bbee1fb8d533ce93f-dirty",
    "user": "jwendell",
    "host": "jw-laptop",
    "golang_version": "go1.10.3",
    "hub": "docker.io/istio",
    "status": "Modified"
  }
}

$ istioctl version --remote
client version: version.BuildInfo{Version:"2e0baef4078274315464da8bbee1fb8d533ce93f-dirty", GitRevision:"2e0baef4078274315464da8bbee1fb8d533ce93f-dirty", User:"jwendell", Host:"jw-laptop", GolangVersion:"go1.10.3", DockerHub:"docker.io/istio", BuildStatus:"Modified"}
citadel version: version.BuildInfo{Version:"1.0.0", GitRevision:"3a136c90ec5e308f236e0d7ebb5c4c5e405217f4", User:"root@71a9470ea93c", Host:"", GolangVersion:"go1.10.1", DockerHub:"docker.io/istio", BuildStatus:"Clean"}
egressgateway version: version.BuildInfo{Version:"1.0.0", GitRevision:"3a136c90ec5e308f236e0d7ebb5c4c5e405217f4", User:"root@71a9470ea93c", Host:"", GolangVersion:"go1.10.1", DockerHub:"docker.io/istio", BuildStatus:"Clean"}
galley version: version.BuildInfo{Version:"1.0.0", GitRevision:"3a136c90ec5e308f236e0d7ebb5c4c5e405217f4", User:"root@71a9470ea93c", Host:"", GolangVersion:"go1.10.1", DockerHub:"docker.io/istio", BuildStatus:"Clean"}
ingressgateway version: version.BuildInfo{Version:"1.0.0", GitRevision:"3a136c90ec5e308f236e0d7ebb5c4c5e405217f4", User:"root@71a9470ea93c", Host:"", GolangVersion:"go1.10.1", DockerHub:"docker.io/istio", BuildStatus:"Clean"}
pilot version: version.BuildInfo{Version:"1.0.0", GitRevision:"3a136c90ec5e308f236e0d7ebb5c4c5e405217f4", User:"root@71a9470ea93c", Host:"", GolangVersion:"go1.10.1", DockerHub:"docker.io/istio", BuildStatus:"Clean"}
policy version: version.BuildInfo{Version:"1.0.0", GitRevision:"3a136c90ec5e308f236e0d7ebb5c4c5e405217f4", User:"root@71a9470ea93c", Host:"", GolangVersion:"go1.10.1", DockerHub:"docker.io/istio", BuildStatus:"Clean"}
sidecar-injector version: version.BuildInfo{Version:"1.0.0", GitRevision:"3a136c90ec5e308f236e0d7ebb5c4c5e405217f4", User:"root@71a9470ea93c", Host:"", GolangVersion:"go1.10.1", DockerHub:"docker.io/istio", BuildStatus:"Clean"}
telemetry version: version.BuildInfo{Version:"1.0.0", GitRevision:"3a136c90ec5e308f236e0d7ebb5c4c5e405217f4", User:"root@71a9470ea93c", Host:"", GolangVersion:"go1.10.1", DockerHub:"docker.io/istio", BuildStatus:"Clean"}

$ istioctl version --remote --short
client version: 2e0baef4078274315464da8bbee1fb8d533ce93f-dirty
citadel version: 1.0.0
egressgateway version: 1.0.0
galley version: 1.0.0
ingressgateway version: 1.0.0
pilot version: 1.0.0
policy version: 1.0.0
sidecar-injector version: 1.0.0
telemetry version: 1.0.0

$ istioctl version --remote -o yaml
clientVersion:
  golang_version: go1.10.3
  host: jw-laptop
  hub: docker.io/istio
  revision: 2e0baef4078274315464da8bbee1fb8d533ce93f-dirty
  status: Modified
  user: jwendell
  version: 2e0baef4078274315464da8bbee1fb8d533ce93f-dirty
meshVersion:
- Component: citadel
  Info:
    golang_version: go1.10.1
    host: ""
    hub: docker.io/istio
    revision: 3a136c90ec5e308f236e0d7ebb5c4c5e405217f4
    status: Clean
    user: root@71a9470ea93c
    version: 1.0.0
- Component: egressgateway
  Info:
    golang_version: go1.10.1
    host: ""
    hub: docker.io/istio
    revision: 3a136c90ec5e308f236e0d7ebb5c4c5e405217f4
    status: Clean
    user: root@71a9470ea93c
    version: 1.0.0
- Component: galley
  Info:
    golang_version: go1.10.1
    host: ""
    hub: docker.io/istio
    revision: 3a136c90ec5e308f236e0d7ebb5c4c5e405217f4
    status: Clean
    user: root@71a9470ea93c
    version: 1.0.0
- Component: ingressgateway
  Info:
    golang_version: go1.10.1
    host: ""
    hub: docker.io/istio
    revision: 3a136c90ec5e308f236e0d7ebb5c4c5e405217f4
    status: Clean
    user: root@71a9470ea93c
    version: 1.0.0
- Component: pilot
  Info:
    golang_version: go1.10.1
    host: ""
    hub: docker.io/istio
    revision: 3a136c90ec5e308f236e0d7ebb5c4c5e405217f4
    status: Clean
    user: root@71a9470ea93c
    version: 1.0.0
- Component: policy
  Info:
    golang_version: go1.10.1
    host: ""
    hub: docker.io/istio
    revision: 3a136c90ec5e308f236e0d7ebb5c4c5e405217f4
    status: Clean
    user: root@71a9470ea93c
    version: 1.0.0
- Component: sidecar-injector
  Info:
    golang_version: go1.10.1
    host: ""
    hub: docker.io/istio
    revision: 3a136c90ec5e308f236e0d7ebb5c4c5e405217f4
    status: Clean
    user: root@71a9470ea93c
    version: 1.0.0
- Component: telemetry
  Info:
    golang_version: go1.10.1
    host: ""
    hub: docker.io/istio
    revision: 3a136c90ec5e308f236e0d7ebb5c4c5e405217f4
    status: Clean
    user: root@71a9470ea93c
    version: 1.0.0

@jwendell looks pretty cool!  I noticed you ran a /retest - if circleci is failing you may consider a rebase to solve the problem.

@sdake It's rebased already...

/lgtm

[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by: liamawhite
To fully approve this pull request, please assign additional approvers.
We suggest the following additional approver: nmittler
If they are not already assigned, you can assign the PR to them by writing /assign @nmittler in a comment when ready.
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

istioctl/OWNERS [liamawhite]
pkg/OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

/assign @geeknoid

/lgtm
/approve

[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: ldemailly, liamawhite
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

istioctl/OWNERS [ldemailly,liamawhite]
pkg/OWNERS [ldemailly]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Please add unit tests for all new functionality in the pkg/version package. I think it was at 100% coverage before, so let's keep it there.
Thanks.

/hold

New changes are detected. LGTM label has been removed.

@geeknoid done. Now it's 100% covered!

Thanks.

/lgtm
/approve

[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: geeknoid, ldemailly, liamawhite
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

istioctl/OWNERS [geeknoid,ldemailly,liamawhite]
pkg/OWNERS [geeknoid,ldemailly]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@geeknoid thanks, should the do-not-merge/hold label be removed?

nice feature added @jwendell - confirmed code coverage didn't regress.

yes that's done with "/hold cancel" (or removing it form the labels)
(no need to force merge)


capture 10 consecutive backtraces

@scareything Here's the compare link for the differences I introduced after you reviewed this branch: https://github.com/openziti/ziti-tunnel-sdk-c/compare/227eb40f44db81c1576b9d507bc65c96428245cf..ad61167d083875cc5bc780fdce3e850da0901225