More refactoring on consumer and Adding Duel request from chat

Name of the branch is not the most accurate anymore ups.
Basically i've changed the consumer so that it deletes any pending invites on the room when a room is started.
Also i've adding the sendDuelRequest in Manage social wich used to do nothing,
Now it connects you to the game, create a gameRoom sends redirect you to that room and sends an invite to the player.
We don't have to put the redirection tho, it's to be discussed,
To test it, just use the Send Duel Request from profile, friends or Chat tab.

this is in the other pull request


Take advantage of CloudFront or CloudFlare as a CDN for RethinkDB.

It's so easy to set something like this up and there's plenty of benefits (required HTTPS, Geo-CDN, ...)
https://aws.amazon.com/cloudfront/details/
https://www.cloudflare.com/overview/

This issue is not relevant anymore, due to we are using Netlify.


feat: Configurable CLI flags

Add 'appmap index' options via appMap.appMap.indexOptions setting Add '--verbose' flag to 'index' and 'scan' via appmap.commandLineVerbose

:tada: This PR is included in version 0.107.0 :tada:
The release is available on:

v0.107.0
GitHub release

Your semantic-release bot :package::rocket:


nativeEnum invalid_type_error not returning error on wrong enum

Zod returns Invalid enum value although invalid_type_error is set.
Steps to reproduce
const schema = z.nativeEnum({MY_ENUM:"MY_ENUM"}, {
  invalid_type_error: "this is an error",
})

console.log("result", schema.parse("AAA"));
// returns error "Invalid enum value. Expected 'MY_ENUM', received 'AAA'"

Expected behavior
When the type is wrong, Zod should return whatever I give in  invalid_type_error.
In the example, it should return this is an error
If invalid_type_error is meant to be used for something else, I would expect the following:

Add in the nativeEnum documentation section what is invalid_type_error for
Add with JS Docs what is invalid_type_error for
Add an invalid_enum_error to the params of nativeEnum where we can define a custom message.

Is this what you are looking for?
const schema = z.nativeEnum( { MY_ENUM: 'MY_ENUM' }, {
    errorMap: ( issue, ctx ) => {
        if ( issue.code === 'invalid_enum_value' ) {
            return { message: 'this is an error' }
        }
        return { message: issue.message ?? '' }
    },
} )

const result = schema.safeParse( 'AAA' )
!result.success && console.log( result.error.issues )
// [
//     {
//         received: "AAA",
//         code: "invalid_enum_value",
//         options: [ "MY_ENUM" ],
//         path: [],
//         message: "this is an error"
//     }
// ]

If you found my answer satisfactory, please consider supporting me. Even a small amount is greatly appreciated. Thanks friend! 🙏
https://github.com/sponsors/JacobWeisenburger

Hi @JacobWeisenburger, thanks for your answer.
This issue is not about if it's possible to show a custom type error with errorMap
It is about how the nativeEnum helper is built since it is misleading that there is an invalid_type_error that is not documented and does not work as I intuitively would expect. So, I wrote in the points above what I would expect from the helper.

Thanks for your kind words. I was just trying to see if you are requesting a feature enhancement or just looking for a work around.

Also came accross this. Thought I customized all the errors until I found out invalid_type_error isn't actually applied in z.nativeEnum. This seems like a bug to me rather than an enhancement.

I can work on that! @JacobWeisenburger

You can now specify this error message with the message field #3169

This implementation hasn't fixed all scenarios, the message overwrites even the required error.
If the value is undefined, it should return the required error message.
If the value is defined but invalid, it should return the invalid error message.


please clean up the mesh and retry.

when i run ' python batch.py', there is a bug:
['tmp.obj']
igl::opengl::glfw::Viewer usage:
[drag]  Rotate scene
A,a     Toggle animation (tight draw loop)
F,f     Toggle face based
I,i     Toggle invert normals
L,l     Toggle wireframe
O,o     Toggle orthographic/perspective projection
T,t     Toggle filled faces
Z       Snap to canonical view
[,]     Toggle between rotation control types (trackball, two-axis
valuator with fixed up, 2D mode with no rotation))
<,>     Toggle between models
;       Toggle vertex labels
:       Toggle face labels
Offline optimization mode
use b_d = 4.1
bijectivity ON
random 2-edge initial cut for closed surface
No UV provided, initialized to all 0
area of triangle No.18564 (0-index) is 0
vertex indices (0-index) are 9987 9970 9494
area of triangle No.29282 (0-index) is 0
vertex indices (0-index) are 15573 15574 15575
area of triangle No.43411 (0-index) is 0
vertex indices (0-index) are 21559 21561 21580
area of triangle No.46797 (0-index) is 0
vertex indices (0-index) are 23202 24043 24101
area of triangle No.51016 (0-index) is 0
vertex indices (0-index) are 26011 25138 26114
area of triangle No.75614 (0-index) is 0
vertex indices (0-index) are 38329 37490 38330
area of triangle No.101009 (0-index) is 0
vertex indices (0-index) are 50434 50424 50217
area of triangle No.112803 (0-index) is 0
vertex indices (0-index) are 56312 56893 56124
area of triangle No.113286 (0-index) is 0
vertex indices (0-index) are 56324 57234 56304
area of triangle No.116316 (0-index) is 0
vertex indices (0-index) are 58626 58625 58582
area of triangle No.118220 (0-index) is 0
vertex indices (0-index) are 59808 58427 58424
area of triangle No.118931 (0-index) is 0
vertex indices (0-index) are 58522 58524 58371
area of triangle No.128351 (0-index) is 0
vertex indices (0-index) are 64314 64117 64128
please clean up the mesh and retry.
can you tell me how to solve? thanks!

It looks like there are triangles with 0 area in the mesh. You should probably merge these triangles into a single vertex, e.g., merging vertex 64314 64117 64128 into a single vertex as suggested by
area of triangle No.128351 (0-index) is 0
vertex indices (0-index) are 64314 64117 64128

This should resolve the issue. Since OptCuts generates maps without any triangle flip, it does not allow 0-area degenerated triangles in the input at the first place.

thanks


Wrong result on rule validation screen for expired certs (EXPOSUREAPP-8468)

This PR addresses Exposureapp-8468.
Hot to test:
-Scan the QR code (can be found inside the ticket)
-Check if the result after validation is the same as the expected one (screenshot)
Screenshot:

How does this fixes the wrong text? So your screenshot looks like the expected result, but I don't get it.

How does this fixes the wrong text? So your screenshot looks like the expected result, but I don't get it.

the failed result view has basically two elements (wrong format & cert not valid anymore).
The logic to show one of these elements is basically "boolish" and was not correct. This was adjusted to show the correct failed result.


[zh] Sync container-checkpoint and watch-from-storage

Sync 2 feature gates:
content/zh-cn/docs/reference/command-line-tools-reference/feature-gates/container-checkpoint.md
content/zh-cn/docs/reference/command-line-tools-reference/feature-gates/watch-from-storage-without-resource-version.md

/lgtm
/approve


Support for Legacy IE78?

Yeah, I know. Who cares about IE7&8, right? Sadly, my clients demand support for those ancient browsers, so I have to figure out a way to appease them.
I don't mind rolling up my sleeves, forking this project and making edits myself, I just was wondering if anyone could point me in the right direction of where I could modify a few lines to make this work in IE7&8…
Thanks!

I think it's fair to say, we'll close this for now. I don't think anyone should be supporting IE7 or 8 at this point.


default shell set on cloud synced settings bugs out on macOS  (but not linux). Why? How can I fix this?

[x] I am on the latest Hyper.app version

[x] I have searched the issues of this repo and believe that this is not a duplicate

OS version and name:  Windows and macOS

Hyper.app version: 3.0.2

Link of a Gist with the contents of your .hyper.js: https://github.com/jcklpe/Configs/blob/master/hyper-js/.hyper.js

Issue
I have a linux, and a windows machine at home. I have a mac at work. The windows machine needs the config set to C:\\Windows\\System32\\bash.exe in order to open with bash on start up.
I sync my configs via cloud.
Linux does not have any issue with this.
But on the mac I got at work gives me the following error on start up: execvp(3) failed.: No such file or directory.
If I leave the shell config setting blank then my windows machine will default to cmd.exe which is no good.
Is it possible to set these configs conditionally based on what OS context they're being opened in?

https://github.com/zeit/hyper/issues/3703
is the only thing I could find with the same error.


Fix browser support configurations of Map/Set/WeakMap/WeakSet

Fixes #793.

Super useful if you could drop in a screengrab of the compat table you're using to derive these numbers.  Cautious here as we don't test Opera, ie mobile or FF mobile in CI.

Okay, is there an example screenshot?

Opera, ie mobile or FF mobile

I also don't know those browsers. But old configs probably doesn't work with those browsers.

Example for Map from https://developer.mozilla.org/en/docs/Web/JavaScript/Reference/Global_Objects/Map:

We'd like to make sure that proposed changes to targeting configs are not guesses, but are based on tests. A screenshot of our tests running in that browser before and after the polyfill is ideal. but failing that, citing an authoritative source of compat data is good enough.

Thanks.

Map

Set

WeakMap

WeakSet

I'll be absent for a few days because I'm going to the center of universe 🚀

I agree with contribution terms of this project.

I see, wait a moment please.

Fixed. If it is okay, I'll squash my commits.

Of course :-) Thanks for responding so swiftly!

Thanks for improving our browser support coverage for these polyfills. This will be released as part of version 3.11.0.


[vs-media-player] Spotify send no (valid) code!

Hi, I'm trying to do integration with the extension, when access to the redirect url displays the following message: Your account has been authorized with Spotify. You can close that browser / tab now, but when you access the visual code, it displays the following message at the top: [vs-media-player] Spotify send no (valid) code!

@lucasfernandes4472
Do you have spotify premium?

@mkloubert yes

@lucasfernandes4472
What is the URL in your browser after the message Your account has been authorized with Spotify...`` has been displayed?

@mkloubert I am using localhost as the authorization URL.

What are the names of the query parameters which are submitted? Are there values which are empty?

@mkloubert the parameters configured on the object are clientID, clientSecret, redirectURL

I'm having this issue too on ubuntu. I got the authorized message after visiting the redirect url, then [vs-media-player] Spotify send no (valid) code!. Any known issue ? Do you need additional infos ?

Same problem. Message "Your account has been authorized with Spotify". There is no requests/confirmations before this message.

Same problem here...

Any news?

Sorry for the late answer ... I have tested the Spotify integration and I found out, that some feature like selecting a track from the bottom bar do not work anymore. But downloading lists or searching songs do work.
The authorization process itself also works for me.
I will have a deeper look on that. I am not sure if that has something to do with API changes in VSCode, Spotify Web API or both.

Cheers @mkloubert ! Please keep us updated on this topic, I would love to be able to select tracks through the bottom bar :) Thanks for the package nonetheless!


commit for appending data planning

This draft PR is very messy. I am opening a PR so that the team can see what I have been up to. My forked main branch is up to date with this information as well. I do not think that this PR should necessarily be merged into main yet (or at all, until these things are actually fleshed out).
Overarching ideas for the folders that have changes:

scratch:

added some code from the make thresholds function that was commented out
added the figure I made for the overall plan

api pull

adding some very underdeveloped code and plans for running this workflow every ~3 hours

qaqc

same as above, but in regards to appending the flagged data to the incoming data from the sonde.

@juandlt-csu let's meet and deal with the conflicts that our two PRs are going to create 🥇


A<|> example incorrect?

https://github.com/Raku/RakuDoc-GAMMA/blob/55b706315dcd92e5657c9a317c2ab449c5713c5a/rakudoc_draft_3.rakudoc#L509-L512
I believe this to be wrong, as the | is part of B<>, rather than A<>.  I believe the example should be:
    The use of A<B<this program>| PROGNAME> is subject to the terms and conditions
    laid out by A<B<our company>| VENDOR>, as specified at:

        A<B<(Please visit our website) |> TERMS_URLS>

On a related note: having a space before PROGNAME and VENDOR implies whitespace should be trimmed from the A<> key?

I believe the example is correct as it stands.
Note that the =begin code block surrounding those three lines has an :allow< B > option.
So those B<...> markups will be invisible (or, rather, will be prerendered) in the output text.
Each B<...> is being used to highlight the feature being described
in the preceding paragraph, not as an example of actual RakuDoc usage.
In other words, the text is supposed to be rendered:

Alias placement codes may also specify a default display text, before the
alias name and separated from it by a |. When a display is specified,
it will be used if the requested alias cannot be found (and an "unknown alias"
warning will be issued in that case):
    The use of A<this program | PROGNAME> is subject to the terms and conditions
    laid out by A<our company | VENDOR>, as specified at:

        A<(Please visit our website) | TERMS_URLS>

...thereby hightlighting the instances of a "default display text, before the alias name and separated from it by a |".
Of course, in an actual RakuDoc usage of the A<...> code, it would definitely be
an error to close the nested B<...> after the |, instead of before it.

having a space before PROGNAME and VENDOR implies whitespace should be trimmed from the A<> key?

Yes, IMHO whitespace should be ignored both fore and aft of the alias key.


Design for Create Skill Contribution wizard

To improve the contribution experience, UXD recommends dividing the contribution form into wizard steps. The current contribution task is long and complex and would benefit from being broken into smaller, more manageable steps. This allows the user to focus on smaller tasks and not feel overwhelmed and allows us to provide more detailed instructions and tailored contextual help.
UXD is working with the content team to finalize the microcopy. Another issue will be created to capture those changes.
The initial step is to select which contribution type the user wants to submit: Knowledge or Skill. In this case we are looking at the skill contribution experience. For knowledge see issue #402
Step 1: Details
The user details should be pulled in from Git if possible. The user can add contributors. Once the wizard is submitted, the newly added contributor(s) will receive a notification. The brief summary should include a a less than 60 character description of the purpose of this contribution. The detailed description should contain a 40 character or more description of the contribution. The Directory path determines the domain/subdomain in the taxonomy this contribution will appear.

Step 2: Create training data
Users will need a minimum of 5 examples. If thier skill is a grounded skill and requires context, they will need to add a context for each QNA pair. User will not be able to move to the next step until all 5 samples have been filled. Note, a scroll bar will appear within the content area for users to scroll their content if needed.

Step 3: Attributions
We are hoping most of the attribution details could be pulled in during the document ingestion process. A warning icon alerts the user of something that needs their attention. Users can click edit to modify the details.

Step 4: Review
The last step in the wizard includes a summary of what the user has input so they may confirm before submitting their contribution. Clicking Submit sends a notification to the InstructLab triager to review the submission.

Hi @Mdenisco! Some feedback:

UXD recommends

It might be a good idea to explain this acronym for community members who aren't familiar.
Step 1: Details

The user details should be pulled in from Git if possible.

It would probably make sense for there to be a user onboarding step where the user's git username (for whatever git system is backing the installation of instructlab, may be github, may be something else) is configured as a one-time exercise against a user profile.

Once the wizard is submitted, the newly added contributor(s) will receive a notification.

What is the form of the notification? Is it an email? Is it an in-app notification? Is it transitory (eg a toaster popup) or in a queue inside the app?

The brief summary should include a a less than 60 character description of the purpose of this contribution. The detailed description should contain a 40 character or more description of the contribution.

How do these map to the fields in the qna.yaml? The qna.yaml format for skills only has one such field - the task_description field. Which - brief summary or detailed description - is meant to map to task_description? For the one that does not - why does it exist and what would it be used for?

The Directory path determines the domain/subdomain in the taxonomy this contribution will appear.

Why not just ask the user for a name for the skill, and use that name as the leaf directory name in the taxonomy? Triagers are going to likely change where in the taxonomy the contribution lives anyway. Exposing end users to the directory tree might make this seem more complicated than it is.
You could probably have them select a suggestion of where it lives in the tree (as a separate field from what they want to name it) as a nested category list, where each directory in the tree past taxonomy/ is a category / subcategory / subsubcategory / etc.
Step 2: Create training data
Calling this step "training data"
I wouldn't name this create training data. Because it isn't training data. :) It's seed data that will be used to generate training data for the model at the end of sdg generation. But we're not at that step yet. I would simply call this "Create quiz" or "create questions and answers" something like that - what it is so it won't cause confusion about other parts of the process.
Disambiguate between knowledge and skill and what is possible
It would be nice to have more contextual information about the differences between the types up front and more examples of what is a skill vs. knowledge. In our initial pilot, the difference between what you can do with a skill vs. a knowledge contribution was the biggest point of confusion so addressing that inline with this design would be very helpful for users.

If thier skill is a grounded skill and requires context, they will need to add a context for each QNA pair.

If they're creating a grounded skill, there must be a context for every question and answer pair. The way this is laid out, it makes it seem as if a context is something that question and answer pairs can have or not have arbitrarily within the skill. They either all have it (grounded skill) or none have it (compositional skill.)
So you probably need a control higher up, or even have a branch in this wizard between composition and grounded skills. I would suggest the latter with additional as to why one would use one vs. the other.
The context should visually probably be above the question and answer drafts since you have to start with the grounding and draft the question and answer from that. Not vice-versa. You want to reinforce the appropriate order of operations.
The context is likely going to be much longer than a single line. You can look through sample skills in the taxonomy repo to see this.
What is the difference between compositional and grounded skills?
Because these are two different skill types, it might make sense to disambiguate between the two types up front for the user and ask which they intend?
Sample question and answer text in fields
The sample question and answer text isn't super helpful. It might be better to have actual sample question and answer text in there.
Step 3: Attributions
Attributions for context data entered in skills qna.yaml is not the same as for knowledge qna.yaml. We don't accept pdfs in skills qna.yaml, so the context in skills qna.yaml right now is not processed in the same way we process PDFs for knowledge qna.yaml. That means there is no automated process for determining attribution. These fields will need to be filled out manually.
It would make sense to display the context above the attribution fields to be filled out.
Even better. Provide the attribution fields on the same screen as the context, instead of having the user copy/paste context from three different sources, then have to backtrack / retrace their steps through the same 3 again.
Step 4: Review
This review is going to be quite long. It might be nice to have each of the qna pairs of the skill in a row of cards or something that could be flipped through. And with the attribution data attached to any contexts that may or may not be there based on the skill being grounded or compositional.
General feedback
Compositional skills are the most difficult type of skill to contribute. It would really make sense to review good, successful skills that are already in the tree, and perhaps provide them as samples or templates users could go through. Dumping them to a long howto document isn't going to be as helpful as being able to look at actual successful skill samples.

Thanks for your feedback, @mairin and @nimbinatus. We'll work on getting this incorporated and post an update/share at the next sync after shutdown.


Cr 20826 argoexec sensitive log

Fixes #TODO
Motivation

Modifications

Verification

Beyond this PR

Looks like this was replaced by #12368

Yeah this has occurred several times already


Add MANIFEST.in

Ensure that the license file is part of the source that is published on PyPI.

Thanks for the suggestions, Fabian. It's my first time publishing anything to PyPi, I figured I would miss something. I'll republish later and bump the version in the dependencies over on HA core to match.


UISACQCOMP-219 Add typings for the ACQ 'ResponseErrorsContainer' utils

Typings for https://github.com/folio-org/stripes-acq-components/pull/817

Sorry, @usavkov-epam, I'm not a TS guy. Maybe somebody else from Corsair (@SergeYvas?) can take a look.


bump(go-apiops): bump to v0.1.24, bugfixes

fixes a bug in openapi2kong with port parsing

hi @Tieske thanks for getting this over the line. when can we expect a new release of deck containing this change? it's currently a blocker for us


Support the same wildcard driver matching at runtime as with the compiler

Compiler uses this logic:
https://github.com/google/iree/blob/master/iree/compiler/Dialect/HAL/Target/ExecutableTarget.cpp#L65-L100
But looks like I still need to add this to the runtime:
https://github.com/google/iree/blob/master/iree/hal/driver_registry.cc

#3937 starts to give us the structure we need to do this. Duping to #3817 as this is going to be done as part of it.


Update twitter:url to https

Pre-Submission Checklist

[ ] Your pull request targets the staging branch of freeCodeCamp.
[ ] Branch starts with either fix/, feature/, or translate/ (e.g. fix/signin-issue)
[ ] You have only one commit (if not, squash them into one commit).
[ ] All new and existing tests pass the command npm test. Use git commit --amend to amend any fixes.

Type of Change

[v] Small bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds new functionality)
[ ] Breaking change (fix or feature that would change existing functionality)
[ ] Add new translation (feature adding new translations)

Checklist:

[ ] Tested changes locally.
[ ] Addressed currently open issue (replace XXXXX with an issue no in next line)

Closes #XXXXX
Description

Hi @sumnermic
Thanks a lot for pull request, however this file is going away in our upcoming development
Please check https://www.freecodecamp.org/forum/t/hacktoberfest-2018-update/231160 for updates.
Happy contributing.


[Bug]: Panic occurred at runtime.

System Info
System:
OS: Linux 5.4 Debian GNU/Linux 11 (bullseye) 11 (bullseye)

CPU: (2) x64 Intel(R) Xeon(R) Gold 6140 CPU @ 2.30GHz

Memory: 6.91 GB / 7.77 GB

Container: Yes

Shell: 5.1.4 - /bin/bash

Binaries:
Node: 22.1.0 - /usr/local/bin/node

Yarn: 1.22.19 - /usr/local/bin/yarn

npm: 10.7.0 - /usr/local/bin/npm

bun: 1.1.7 - ~/.bun/bin/bun

Details
Running rsbuild build in Docker on Jenkins causes this panic. However it builds successfully in my M1 Mac.
In Jenkins:

$ rsbuild build

  Rsbuild v0.6.8

Panic occurred at runtime. Please file an issue on GitHub with the backtrace below: https://github.com/web-infra-dev/rspack/issues

Message:  should have dependency id

Location: crates/rspack_plugin_javascript/src/dependency/context/require_context_dependency.rs:92

Run with COLORBT_SHOW_HIDDEN=1 environment variable to disable frame filtering.

Run with RUST_BACKTRACE=full to include source snippets.

━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━ BACKTRACE ━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━

 1: start_thread

    at <unknown source file>

 2: clone

    at <unknown source file>

error: script "build" was terminated by signal SIGABRT (Abort)

Aborted (core dumped)

The command '/bin/sh -c bun run build' returned a non-zero code: 134

In Mac:

Reproduce link
No response
Reproduce Steps
will update this

This panic may happen when the code includes require.context("./foo") and "./foo" can not be resolved.
When it is reproducsible on linux only, your code or deps might include require.context("./foo") and there is a directory named foo with different case like Foo.

Rspack should give a good error/warn message instead of panic.

That's good to know. I will check if the third party code has infact incorrect path. But I think it would be great to have this as a compilation error rather than a panic. Let me know if I should close this?

That's good to know. I will check if the third party code has infact incorrect path. But I think it would be great to have this as a compilation error rather than a panic. Let me know if I should close this?

Please just keep it open.

I have created a reproduction and a bug report issue for it, see: https://github.com/web-infra-dev/rspack/issues/6735
I will close this issue to avoid duplication


Can we use decimals?

Hi!
It's really a nice component that you created!
I'm trying to use it to rate things with 0.5 steps but I seem to only receive integer values (from onChange or onMove).
Is the decimal only possible with the default value or I missed something?
Thanks for you help!

Hey Francis and thank you! You're right, the onChange and onMove callbacks receive only integer values. I believe it's a common user experience to rate, and it's also harder and less intuitive to tap half of the star. Nevertheless, the component will display decimal values received in the rating prop (when it displays the total rating).
If I understood your case correctly, you want to use a scale from 0 to 5 with 0.5 step when user rate something. What about using the 0-10 scale then? I mean, you can set maxRating=10 to display 10 stars when asking your users to rate. Will that work for you?


Missing Nonce in token

Hello,
After following the instructions in this This guide https://docs.microsoft.com/en-us/microsoftteams/platform/tabs/how-to/authentication/tab-sso-code , I managed to authenticate the user in my Tab app.
However, the issue is when I'm sending this token to the backend, the token is rejected because the "nonce" claim is missing, and I did not find any mention in the doc on how to get this nonce claim.
Can you help me?
Thanks

@MaelAbgrall - We have tested below sample but it was working fine at our end.
https://github.com/OfficeDev/Microsoft-Teams-Samples/tree/main/samples/tab-sso/csharp
Could you please refer this sample once and let us know if you are getting same for this sample?


refactor: include filepaths if attaching multple text files

include filepaths if attaching multple text files
$ aichat --file ./file1 --file ./file2 -- compare
 compare
`./file1`:
~~~~~~
This is file1
~~~~~~
`./file2`:
~~~~~~
This is file2
~~~~~~

Somehow only --file=$path is accepted, but not -f $path or --file $path to attach the file content on 0.15.0; is this intentional?

@Konfekt I didn't find the problem you mentioned.

I should have said that this is on Linux inside Zsh.
For example, inside ~/,
$ aichat -f .profile check syntax
Welcome to aichat 0.15.0
Type ".help" for more information.
respondent>

$ aichat -f=.profile check syntax
The syntax of your script appears to be correct, assuming it is intended to be used within a Bash shell script.

I would have expected both commands to work similarly.
Note that -f= is not documented, so maybe it does something wrong, but for me this is more useful.

you have to use -- to split file args and text args.
-- $ aichat -f=.profile check syntax
++ $ aichat -f=.profile -- check syntax

Originally intended to be consistent with REPL .file command
> .file
Usage: .file <files>...  -- <text>...

Now it seems like there is a misunderstanding, I would make -f/--file accept a value every time in the next version.


Question: Best serialisation method for performance

Hi Max
A great project and sincerely thank you for it.
In your opinion is grpc-dotnet serialisation most likely to out perform other methods?
I read that Protobuf is highly regarded for speed but your benchmark results don't seem to reflect this.
Thanks.
Fig

Hi lefig.
The "grpc-dotnet" and "ServiceModelGrpc.proto-emulation" benchmarks demonstrate that Google.Protobuf is a winner.
Google.Protobuf is highly performant and it is expected - no reflection, only generated code.
About others, you see numbers.
Tests transfer this SomeObject. You can try other structures, closer to your domain area, it may slightly change the numbers, also there are other tests in Benchmarks.sln:
> ServiceModel.Grpc.Benchmarks.exe --filter *Marshaller*

Here are more benchmarks.

Hi Max,
Thank you for coming back with your thoughts.
Also the docmentation and examples that you provide are very educational.
Coming from a WCF Duplex background I am still trying to find the best approach for GRPC.
Best,
Fig

Hi lefig,
I close this issue. It would be interesting if you could share "WCF Duplex background" in another issue.


release: add update_ccruntime_images.sh

Created the update_ccruntime_images.sh script which should help on update the runtime-payload and pre-install images accross the ccruntimes variants.
Fixes #204
Signed-off-by: Wainer dos Santos Moschetta<EMAIL_ADDRESS>

Usage:
$ ./update_ccruntime_images.sh -h
This script updates the runtime-payload and pre-install images on all the
ccruntime deployment files.

Usage: ./update_ccruntime_images.sh [-h] [-c] [-p commit] [-k commit]
Where
-c: use CI images
-h: print this help message
-p: preinstall image commit
-k: runtime-payload image commit

Example of use:
./update_ccruntime_images.sh -k 6abfb9deadc03154f91896e78ea024e55928c9f4 -c
Skipping overlay: /home/wmoschet/go/src/github.com/confidential-containers/operator/config/samples/ccruntime/base
Updating overlay: /home/wmoschet/go/src/github.com/confidential-containers/operator/config/samples/ccruntime/default
Updating overlay: /home/wmoschet/go/src/github.com/confidential-containers/operator/config/samples/ccruntime/peer-pods
Updating overlay: /home/wmoschet/go/src/github.com/confidential-containers/operator/config/samples/ccruntime/s390x
[Warning] Do not know how to handle: /home/wmoschet/go/src/github.com/confidential-containers/operator/config/samples/ccruntime/ssh-demo

And the changes applied:
diff --git a/config/samples/ccruntime/default/kustomization.yaml b/config/samples/ccruntime/default/kustomization.yaml
index 07b3b25..ccea3a7 100644
--- a/config/samples/ccruntime/default/kustomization.yaml
+++ b/config/samples/ccruntime/default/kustomization.yaml
@@ -10,7 +10,7 @@ images:
 - name: quay.io/confidential-containers/container-engine-for-cc-payload
   newTag: 98a790e8abdcc06c4b629b290ebaa217bf82e305
 - name: quay.io/confidential-containers/runtime-payload
-  newName: quay.io/confidential-containers/runtime-payload
+  newName: quay.io/confidential-containers/runtime-payload-ci
   newTag: kata-containers-6abfb9deadc03154f91896e78ea024e55928c9f4-x86_64

 patches:
diff --git a/config/samples/ccruntime/peer-pods/kustomization.yaml b/config/samples/ccruntime/peer-pods/kustomization.yaml
index ed445b4..f86121a 100644
--- a/config/samples/ccruntime/peer-pods/kustomization.yaml
+++ b/config/samples/ccruntime/peer-pods/kustomization.yaml
@@ -10,7 +10,7 @@ images:
 - name: quay.io/confidential-containers/container-engine-for-cc-payload
   newTag: 98a790e8abdcc06c4b629b290ebaa217bf82e305
 - name: quay.io/confidential-containers/runtime-payload
-  newName: quay.io/confidential-containers/runtime-payload
+  newName: quay.io/confidential-containers/runtime-payload-ci
   newTag: kata-containers-6abfb9deadc03154f91896e78ea024e55928c9f4-x86_64

 patches:
diff --git a/config/samples/ccruntime/s390x/kustomization.yaml b/config/samples/ccruntime/s390x/kustomization.yaml
index 13007ee..469e6ba 100644
--- a/config/samples/ccruntime/s390x/kustomization.yaml
+++ b/config/samples/ccruntime/s390x/kustomization.yaml
@@ -7,11 +7,11 @@ resources:
 - ../base

 images:
-- name: quay.io/confidential-containers/runtime-payload
-  newName: quay.io/confidential-containers/runtime-payload
-  newTag: kata-containers-6abfb9deadc03154f91896e78ea024e55928c9f4-s390x
 - name: quay.io/confidential-containers/container-engine-for-cc-payload
   newTag: 98a790e8abdcc06c4b629b290ebaa217bf82e305
+- name: quay.io/confidential-containers/runtime-payload
+  newName: quay.io/confidential-containers/runtime-payload-ci
+  newTag: kata-containers-6abfb9deadc03154f91896e78ea024e55928c9f4-s390x

 patches:
 - patch: |-

The lack of review seems to indicate there isn't interest on the feature. So dropping this PR...

The lack of review seems to indicate there isn't interest on the feature. So dropping this PR...

I'd revive this one, @wainersm.  The lack of reviews just indicates that folks are overloaded, but I do have interest on getting this one in.


The Semantic Web

It would be great if somebody with a knowledge of Microformats or Schema.org could help make the site more semantic.

I'm thinking the site is long overdue of a spruce. That said, are microformats still a thing anymore? Do actual humans use this stuff?
Generally speaking though I'm for it. I guess if we can make it easy for Google to pick up event information, we should!

Woah, check me replying to issues from 2013 - I thought this was the somebody-should repo!

They are, see http://schema.org/Event (in particular).
Google is quite fond of them, https://developers.google.com/search/docs/guides/intro-structured-data


wait for tcp port available (win32)

Wait for server ready on windows platforms. This helps to allow a minimal windows platforms support. Related to issue #1

Why is this a Windows only feature? I don't see any Windows specific code.

So, to sum up the requirements. a) The feature needs to work on all platforms, Windows, macOS and Linux. b) There needs to be an additional documentation section explaining how to use the module in a portable (but slightly less safe) way. c) There need to be new tests for success (random and specific port) and failure cases (timeout, failed web app start, connection error other than ECONNREFUSED).

I hope we still have a chance to get to a usable feature on this issue.
And as the other PR was a mistake, so we leave it closed, but I will address all issues mentioned by you in the following points.
Regarding your sum up on requirements above:
a) The feature should work in Linux, macOS and Windows: done, and tested on all of them,
b) Additional documentation: done, added a section on launching servers with this "portable" feature,
c) New tests: (all of them in a new script:  test/start_port.js, which is a modified version of test/start_fd.js)
- success (random port): done,
- success (specific port): done,
- timeout, done (reduced to 500 mS so we don't slow down tests too much),
- failed web app start: done, we got a timeout plus server emitted specific error,
- connection error other than ECONNREFUSED: done, we got a timeout plus server emitted specific error
Also regarding to tests, I needed a way to skip fd tests on windows, so I used some tap functionality to skip them all on win32 platforms. It may look hacky, so just let me know if you know a cleaner way.
About the "no reject handler" remark: the reject case was added so is fixed now (done). Also I want to apologize for my misunderstanding on the process, I answered in the conversation with some explanation in the timeout logic and thought that was enough, that's why I included the comment in the code (In no way I meant to offend you nor to ignore any of your comments).
About the "this constant does nothing" remark, sorry I had missed your last comment, is fixed now (done).
About the "me still missing the point" as this is not meant to be a Mojolicious specific module, I think I understand that. I removed the ENV variable used to avoid fd passing, and also the "listenAddress()" function, so to avoid any "Hidden magic" as you mentioned on other remark.
To let the customer choose how to launch the child server process, a new launch function, launchPortable(), is defined.
The reason I separate both cases is that the logic changes a lot between them, as launchPortable needs the port to be closed before spawning the server, otherwise the "first" race condition will trigger a lot (almost always on a mac). launch() in the other hand, needs to close the port after the server opened the passed fd. And for the retry and timeout functionality, I cannot see any case in which that functionality would make sense when using fd passing, as the port should be up all the time.


docs: Add precedence information to Secret, ConfigMaps and ExtraEnv

Signed-off-by: Mateus Oliveira<EMAIL_ADDRESS>Describe the behavior changes introduced in this PR
Chgeck the precedence of Secret, ConfigMaps and ExtraEnv, and document it.
Linked Issues
resolves #802
related to #468
Testing Instructions
Create a pelorus instance with the content of test.yaml, create secret and configmap with oc apply -f file, with the secret.yaml and config.yaml files, and check the logs of each deployexporter, with oc logs -n pelorus name (you can get the name with oc get pod -n pelorus).

add tests to check with 2 (or more) secrets (or configmaps) are passed, which has the precedence, as talked to @mpryc

Ok so in short:
extraEnv - casino
secret - 2nd
configmap - looser

So it's reversed order to what's here:
https://github.com/konveyor/pelorus/blob/master/charts/pelorus/subcharts/exporters/templates/_deploymentconfig.yaml#L45-L68
I suspect that when two configmaps are present then the bottom one wins, however I am unsure if the list is properly ordered for the {{- range }} helm option: https://github.com/konveyor/pelorus/blob/master/charts/pelorus/subcharts/exporters/templates/_deploymentconfig.yaml#L46

Here is some helm issue where it's non-deterministic... but that's something we need to confirm and possibly fix by having different method or document properly https://github.com/helm/helm/issues/4375

Closing without merge to do not let it hanging


New File type that tracks whether the file is an input or output file or both

Introduce a newtype File direction to track how files are used to replace use of FilePath.
The type File In indicates that the file is for reading, File Out for writing and File InOut for both.
Annotating the type of file paths in this way makes it clear how files are used.  The most notable improvements are found where the InOut annotation is used.  In these cases, the file path is used to both open the file for reading and writing and in some cases, the fact that the file is written to is non-obvious.
New functions have been added to parse CLI arguments for files in this new typesafe scheme.
The process of making the code more type-safe around files also helped identify a bug where we used a file bash completer for a directory when we should have used directory.
This is a large PR and it isn't necessary to merge it all at once.  The PR is mostly to demonstrate that this is possible and the first commit serves as a good first step in this direction.
Future work
This PR lays the ground work for:

Expanding the File type to support special pseudo-files like "-" for stdin and stdout described in https://github.com/input-output-hk/cardano-node/issues/5016.
Supporting a second type parameter content for describing the contents of the file.  For example CBOR vs JSON.
Tightening type-safety by providing more typesafe versions of read/write functions and not use the escape hatch File and unFile that is currently used in the code as often.
Using the annotations to improve the documentation making it clear which CLI options are inputs and which are outputs.

The last commit shows the replacement of HasFileMode type class with plain functions.

Superseded by https://github.com/input-output-hk/cardano-node/pull/5105


Adding v1beta1 Ordering Semantics

This is required for Watch.
Where applicable, the semantics are copied from Node and the Android SDK. The Unit test is copied 1:1 from the Node SDK.

Review addressed. Thanks.

LGTM; @garrettjonesgoogle should +2


Discussion: Style-guides

Hi! 👋
A big issue that we're facing on a project is the lack of style-guides to refer to during code reviews - leading to a lot of inconsistencies and anti-patterns.
I noticed that theres a tracking issue (#14) that's been closed but with intent to carry on adding docs on as-they-come basis. I was also happy to see the AirBnB guide referenced 👏
I'm very keen to kick off a PR to get something added but wanted to get a discussion going first to see what peoples thoughts are right now, since (#14) is now quite old!
Some thoughts:

AirBnB's JS style guide is awesome so I +1 using them as default.
Many existing projects may throw lint errors/warnings if we enforce all of AirBnBs rules
As per the above, it could be worth encouraging users to only lint & update files as they're touched & provide details on that work flow.
Tweaking or Removing the guidelines/rules RBP provide should be hassle free & clearly instructed.
Do we copy in the whole file? Reference it? Agree on and create a subset?
Do we add RBP specific rules?

Completely agree that a JS style guide that automatically enforced is invaluable. I'm not sure if I understand your question completely tho, as this project is currently using both:

Airbnb JavaScript Style Guide
Airbnb React/JSX Style Guide

See package.json here and here! This will detect errors during the build step and it should also highlight problems in your editor if you have the appropriate plugin install. I feel as tho I am missing something here tho???

Ahh, I should have been more clear - sorry!
I mean in terms of docs, a .md file that explains the guidelines in a wordy way, wether that be a copy of the Airbnb GLs, a short write up that justifies it and references it or something along those lines.
The eslint additions are great but I feel there's room for some docs that support them - could be wrong though, having the eslint rules ship out with the boiler plate might just be enough!

That would be great, maybe just a quick summary with a link to the Airbnb Style Guide, followed by a brief description of the overrides! Is that more like what you think should happen?

Yeah! That sounds pretty decent! :D
I'll put together a PR this evening to get things rolling!

@spen Hi! Do you still want to pursue this?

Hey @KarandikarMihir! Sure thing, this managed to slip by as I've had a pretty full plate lately!
I hadn't noticed the references either - oops!
I'll aim to at least open a PR this weekend - probably nothing comprehensive right away though as I'm currently working on a few projects with code-styles that are a little different to AirBnB / RBP styles.
That said if anybody else is currently working with RBP and feels better positioned to open a PR I'd be happy to review and support if they beat me to it :D

@spen Sorry, somehow I missed the notification. Really great work. Thanks! Let's iterate in #1533 😃
P. S. It's okay if you can't spend much time on this. Since it's a doc and not a core functionality, we can let it hang for a longer period than usual.

Closing due to inactivity, but if this gets traction again let's start a discussion.


iohook .node is not a valid win32 application

Package JSON Node ABI
"iohook": {
"targets": [
"node-75",
"electron-85"
],
"platforms": [
"win32",
"darwin",
"linux"
],
"arches": [
"x64",
"ia32"
]
}
iohook version 0.9.1
Error
resources\app.asar.unpacked\node_modules\iohook\builds\electron-v80-win32-x64\build\Release\iohook.node is not a valid Win32 application.
?\C:\Users\Financials Unlimited\AppData\Local\Programs\eyesmarty\resources\app.asar.unpacked\node_modules\iohook\builds\electron-v80-win32-x64\build\Release\iohook.node
at process.func [as dlopen] (electron/js2c/asar.js:140)
at Object.Module._extensions..node (internal/modules/cjs/loader.js:1034)
at Object.func [as .node] (electron/js2c/asar.js:149)
at Module.load (internal/modules/cjs/loader.js:815)
at Module._load (internal/modules/cjs/loader.js:727)
at Function.Module._load (electron/js2c/asar.js:769)
at Module.require (internal/modules/cjs/loader.js:852)
at require (internal/modules/cjs/helpers.js:74)
at Object. (C:\Users\Financials Unlimited\AppData\Local\Programs\eyesmarty\resources\app.asar\node_modules\iohook\index.js:10)
at Object. (C:\Users\Financials Unlimited\AppData\Local\Programs\eyesmarty\resources\app.asar\node_modules\iohook\index.js:397)

facing same issue any progress with the solution
?

@WilixLead ?

I'm also looking for a fix for this.
The workaround is to manually download the build from here https://github.com/wilix-team/iohook/releases/tag/undefined0.9.1
The one you're looking for is https://github.com/wilix-team/iohook/releases/download/undefined0.9.1/iohook-v0.9.1-electron-v80-win32-x64.tar.gz
You need to extract it in the folder the application is looking for it, which in your case is resources\app.asar.unpacked\node_modules\iohook\builds\electron-v80-win32-x64.

Getting the same error - "\node_modules\iohook\builds\electron-v87-win32-x64\build\Release\iohook.node is not a valid Win32 application.". Also tried what @italodeandra mentioned. Downloaded and extracted the build folder. Then after running the app I'm getting  -
"Error: The module '....\node_modules\iohook\builds\electron-v87-win32-x64\build\Release\iohook.node'
was compiled against a different Node.js version using
NODE_MODULE_VERSION 80. This version of Node.js requires
NODE_MODULE_VERSION 87. Please try re-compiling or re-installing."
Any other solution???

That's a different issue and seems weird. Did you download the version 87 from the this link? If yes, I suggest downgrading your Node.js version and trying again (it will probably ask you to install a different version).

This is a current issue with v0.9.1 release. For windows install v0.9.0 and for linux and mac you can use v0.9.1. Will resolve very soon.

Still not fixed even on v0.9.2. What is the recommended environment?

My previous workaround is not working anymore. It seems you removed the release I was using to download the build. 😢

@italodeandra sorry for delay here. It should download the correct build if you have the correct config in your package. Share your config, it's probably the case that you're using an electron/node combination that's not build.

@ash0x0 It's working fine now. Thanks!


Document how to override elements in a junction project one depends on

See original issue on GitLab
In GitLab by [Gitlab user @jjardon] on Mar 26, 2018, 14:36
The approach outlined in https://gitlab.com/BuildStream/buildstream/issues/321#note_65232874 should cover how to override how certain elements get built in a junction.
This is appropriate material for an example in the user facing example documentation.
Original report:
It should be possible to overlap elements already present in a junction
Use case:
we would like to use the freedesktop-sdk to build gnome-build-meta (see https://gitlab.gnome.org/GNOME/gnome-build-meta/issues/21), but is currently not possible because freedesktop-sdk already includes, for example, glib or gtk+
Do not build glib or gtk+ in gnome-build-meta is not an option as GNOME devs needs to always build the latest, while freedesktop-sdk project will stick with the current stable version
Seems this is not possible at the moment?

In GitLab by [Gitlab user @tristanvb] on Mar 26, 2018, 14:58
We may want to explore making some enhancement to handle these cases better, until we can identify what the ideal enhancements might be, there are some tricks which can be played.
As far as I can see there are two important cases here: Things which are built in both freedesktop-sdk and in gnome-build-meta:

Which nothing in freedesktop-sdk depends on

In this case we simply need not depend on those things from gnome-build-meta

Which other things in freedesktop-sdk depends on

In this case, so far we are talking about API/ABI stable components glib and gtk+, technically speaking it is not entirely necessary that things built in freedesktop-sdk be built against the desired version of glib in the gnome-build-meta repo. Because of their API/ABI stable nature, it should be possible to just overwrite what was built in freedesktop-sdk

Another trick we can employ, given that gnome-build-meta now uses the project.refs file; it is now possible to explicitly set the ref used by cross junction elements (currently bst track supports cross junction tracking, however addressing of cross project elements on the command line is not yet supported, so you cannot yet say: bst track freedesktop-sdk-junction.bst:core/glib.bst for example)
Another trick we can employ is to add some support to freedesktop-sdk specifically for GNOME, i.e. we can add some project options to freedesktop-sdk which are set by GNOME's junction to that, and have conditional statements in freedesktop-sdk build things in such a way that fits GNOME requirements better.
It is possible we need something better, such that we could entirely replace an element declaration across a junction boundary in a parent project; I'm not sure what the best solution would be or if it's entirely required, but let's stay open to suggestions.

In GitLab by [Gitlab user @jjardon] on Mar 26, 2018, 15:08
Please, do not focus in the GNOME case; it was only an example; also, I have already tried to explain in the description why "not depend on those things from gnome-build-meta" is not an option
I think it should be part of the design that even if I depend on another project via junctions, I should be able to independenly overwrite any element (because I want to use a new version of a specific component, or because I have to apply a patch is not applicable in the base project)
So I'd say that "entirely replace an element declaration across a junction boundary in a parent project" is probably the only real solution here

In GitLab by [Gitlab user @tristanvb] on Mar 26, 2018, 15:23

Please, do not focus in the GNOME case; it was only an example;

Yes, and examples here are very useful for us to gain insight into what will work for everyone.

also, I have already tried to explain in the description why "not depend on those things from gnome-build-meta" is not an option

Please elaborate then, note that I said from, and not in.
What I mean to say here, is if freedesktop-sdk builds something, we need not pull it in when building gnome-build-meta.
It is entirely possible, and junctions are designed for this, that you can depend on specific things across a junction without pulling in the full junctioned project.
So what I mean to express when I say that:

In this case we simply need not depend on those things from gnome-build-meta

Is that we can just ignore the fact that it is described in freedesktop-sdk, and only build the one in gnome-build-meta. This is only true if gnome-build-meta does not depend on things in freedesktop-sdk which already internally depend on things we want to ignore in freedesktop-sdk, though.
Does this explanation make more sense now ?

I think it should be part of the design that even if I depend on another project via junctions, I should be able to independenly overwrite any element (because I want to use a new version of a specific component, or because I have to apply a patch is not applicable in the base project)

Before jumping into designing a new feature, we need to first asses whether the current feature set can adequately satisfy the requirements, and I feel that you have not thoroughly comprehended my initial reply, yet.
For a new version of something, it is already possible to override versions of things with the project.refs file.
For applying a specific patch, or using a conditional configure argument; it is also possible to make conditional build instructions using project options within the freedesktop-sdk project for it's consumers; so that gnome-build-meta is able to select a feature which freedesktop-sdk exposes for it.
These approaches may not be the one that you want, but they do achieve the desired result. And as I said, let's stay open minded to suggestions for additional features, but let's also stay cautious about overloading BuildStream with multiple features which achieve the same result.

In GitLab by [Gitlab user @jjardon] on Mar 26, 2018, 15:30
[Gitlab user @tristanvb]

For a new version of something, it is already possible to override versions of things with the project.refs file.

Nice! any docs somewhere that explain how to use this?

For applying a specific patch, or using a conditional configure argument; it is also possible to make conditional build instructions using project options within the freedesktop-sdk project for it's consumers; so that gnome-build-meta is able to select a feature which freedesktop-sdk exposes for it.

mmm, I think GNOME project and the freedesktop one should be independent; I should be able to change elements in the GNOME one without interact with the freedesktop one at all (same way it's posible to build glib master in my Debian Stable machine, without having to interact with the Debian project at all)

In GitLab by [Gitlab user @tristanvb] on Mar 26, 2018, 15:38

Nice! any docs somewhere that explain how to use this?

Yes, there is the reference docs of the project.refs format

mmm, I think GNOME project and the freedesktop one should be independent; I should be able to change elements in the GNOME one without interact with the freedesktop one at all (same way it's posible to build glib master in my Debian Stable machine, without having to interact with the Debian project at all)

I agree that having to upstream patches to the junctioned project is not perfectly ideal, and issue #292 is not really helping in this regard.
On the other hand, there are multiple ways to view the problem.
One approach for example:

Keeping in mind that a junction shares a lot of common properties to any other element
That a junction has Sources and stages a sub project internally
It is also possible for gnome-build-meta to use a patch source to apply against a junction
Or to maintain a fork of a junctioned project

Until such a time that the upstream freedesktop-sdk accepts a patch to allow some conditional instructions to be applied for building a different flavor of a given element, for it's consumers, one of which is gnome-build-meta

In GitLab by [Gitlab user @tristanvb] on Mar 27, 2018, 06:03

It is also possible for gnome-build-meta to use a patch source to apply against a junction

On further thought, I think a similar approach solves your desired case, with something like this:
kind: junction

sources:
# First source for the junction is the junctioned project
- kind: git
  url: ...
# Now we can just overwrite elements inline, lets overwrite the junctioned
# glib element with our glib.bst override
#
- kind: local
  path: overrides/glib.bst
  directory: elements

In GitLab by [Gitlab user @tristanvb] on Mar 27, 2018, 11:19
changed title from {-It should be possible to overlap elements already present in a juncti-}on to {+Document how to override elements in a junction project one depends +}on

In GitLab by [Gitlab user @tristanvb] on Mar 27, 2018, 11:19
changed the description

In GitLab by [Gitlab user @tlater] on Apr 19, 2019, 17:28
mentioned in merge request !1300

In GitLab by [Gitlab user @tristanvb] on Nov 5, 2020, 07:29
It is now supported and documented to override elements in a subproject, since landing !2094.
Closing this.


Re-introducting dumps v1 support for Meilisearch v1?

Following the discussion with @Kerollmops but can interest any people in the core team to have your opinion
What we want when releasing v1 is to ensure most people will use it. One of the issue is the migration: currently, someone using Meilisearch v0.20.0 cannot migrate to v0.28.0 (so future meilisearch v1)
See the following table in the specs: https://github.com/meilisearch/specifications/blob/main/text/0105-dumps-api.md#34-dump-version-support
We just realized this could be a huge issue for our users; indeed, until last August, we had more users in v0.20.0 and before than in v0.21.0 and after, meaning we have a lot of people to migrate to v1! See the Amplitude graph (internal only)
I open this issue following my discussion with Kero, to see if it's possible to make the v1 dump support come back, or if it's really impossible.
Another question: is it really useful to avoid these two steps since we made a lot of breaking API? Are v0.20.0 and v0.24.0 really different regarding the main API routes (/search, /documents)? Same question for v0.20.0 -> v0.24.0 and v0.24.0 -> v0.28.0? I mean, it could be useful to let these two steps if the breaking are big between v0.20.0 and v0.24.0

@meilisearch/core-team I would like to have your opinion on this 😇

is it really useful to avoid these two steps since we made a lot of breaking API?

If someone wants to do it, I think he'll be happier with a one-step process and then fix your settings than a two or three steps process to fix your settings in the exact same way finally.
Also, we're emitting warnings when something changes or a setting has been renamed. To me, it's way easier to follow a one-step process with every warning happening at the same time than aggregating everything over multiple steps.

I open this issue [...] to see if it's possible to make the v1 dump support come back

Yes, it's possible.

Closed in favor of https://github.com/meilisearch/meilisearch/issues/2985


Admin Panel: User Manager implementation

We should have User Manager with ability to manage users and users roles.
todo:

user manager
roles
password reset
profiles editor

moved to https://github.com/flextype-plugins/admin/issues/81


Re-enable CNI test

For https://github.com/istio/istio/issues/20487
DO NOT MERGE until I revert the default image change

@howardjohn: The following test failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

integ-pilot-local-tests_istio
1bb170eef4ec9fdf2b551d2a88da2b1c226bb8cd
link
/test integ-pilot-local-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@howardjohn: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

integ-pilot-local-tests_istio
1bb170eef4ec9fdf2b551d2a88da2b1c226bb8cd
link
/test integ-pilot-local-tests_istio

integ-conformance-k8s-tests_istio
1bb170eef4ec9fdf2b551d2a88da2b1c226bb8cd
link
/test integ-conformance-k8s-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@howardjohn: The following test failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

integ-mixer-k8s-tests_istio
8159475481e8c6eef13c8e38a5e9a6dd6e97fef1
link
/test integ-mixer-k8s-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

/retest


Reformat CHANGELOG.md

🤔 What's changed?
Used the standard github.com/cucumber/changelog CLI tool to reformat the CHANGELOG.md file.
⚡ What's your motivation?
The changelog tool will be used in the release process, and I want minimal changes in the actual release commits.
🏷 What kind of change is this?

:bank: Refactoring/debt/DX (improvement to code design, tooling, documentation etc. without changing behaviour)

♻ Anything particular you want feedback on?
Did it mangle anything?
📋 Checklist:

[x] I agree to respect and uphold the Cucumber Community Code of Conduct

This text was originally generated from a template, then edited by hand. You can modify the template here.

OK I think this is good to go now.


[Automation] Generate Fluent Lite from Swagger imagebuilder#package-2024-02

[Automation] Generate Fluent Lite from Swagger imagebuilder#package-2024-02

/azp run java - imagebuilder - mgmt - tests

API change check
APIView has identified API level changes in this PR and created following API reviews.
com.azure.resourcemanager:azure-resourcemanager-imagebuilder


Break down Go tasks into separate issues

Go tasks need to be separated into individuals so we can pick up specific tasks.
Preferably tag the simplest as good first issue.
@eifrah-aws

@yipin-chen Please see if this one can be closed since youve already opened separate tasks for go


⚠ Bofrost.es has degraded performance

In 89d4227, Bofrost.es (https://www.bofrost.es) experienced degraded performance:

HTTP code: 200
Response time: 1609 ms

Resolved: Bofrost.es performance has improved in 08f1dea after 6 minutes.


Confusing tooltip and action on default notification API

Repo: use the default notifications API sample to see this behavior (https://github.com/microsoft/vscode-extension-samples/blob/main/notifications-sample/src/extension.ts#L24C3-L28C4)
When a notification is shown there is a "settings" icon on the notification window.  Upon hover you get a tooltip that says "Configure Notification" (english version).  When you click on the icon the action is "Manage Extensions" -- these are not the same meaning.
Consider re-wording the tooltip to match what that actually actions available are.

To what?

To what?

Well I'll defer to the product owners...especially since I've only seen one menu from that settings button ever in my personal usage...but questions I had/have as a user...

What does "Configure Notification" mean, I don't see any option to configure anything about this notification?
What else goes in that menu when I click it from a notification? Is it only "Manage Extension" if so, then just make the tooltip match that
What is the intent of "Manage Extension" from a notification window as a primary action? Is that a natural place one would expect to find that? When does it make sense?
Why does it show persistently when I have actions, but not if I just show an info/error message with no actions (but shows on hover)? Why the difference?
The action itself seems to just launch the extension page and not the settings...not knowing what "manage extension" meant I expected to take it to Settings->Extension-> my extension settings...but it doesn't.

So I dunno, but based on my experience, I think I'd just change it to match what appears to be the only available option from that icon - "Manage Extension"

But that is not the only available option in the menu. Notifications from core are free to provide any secondary actions they want. Only extensions get the single entry.

Notifications from core are free to provide any secondary actions they want.

I assume 'core' here refers to the shell, this is not an exposable API that extension authors can add their own secondary actions in that menu location (or at least if it is I cannot find it in the API docs).
Putting my PM hat on -- do we have data to show how many times only the single action is shown in the menu versus additional ones from the core?
I guess to me, so far all I've seen is one option ever and so the tip and action are confusing to me as a user.  The "do not show again" i've always seen as a checkbox within the notification not in the subsequent action drop-downs.
But I'll make a few suggestions since the it might appear the only one that is truly "configure notification" is really the 'don't show me again' (which as I've said I've never experienced it hidden in that menu) and others that I've experiences have nothing to do with configuring the notification.
Suggestions:

if only one menu option will be shown, match the tooltip to be that of the only menu option shown.  So default it would look like this would mean the tooltip would get "Manage Extension" and the only action is "Manage Extension"
Genericize it more since it is mixing things that you indicate may come from the core that might? be actual notification configuration, but also may not.  Change it to "Additional options" or "Additional actions"
combine the two above.  have the if() check if only one option, then if it isn't choose a better generic term.

I guess in the end I'm just saying as a user the 98% case I've seen (giving myself room for error I may have missed) is that it is only one option and has nothing to do with actually configuring the notification.

I am fine changing the tooltip, but I do not think it makes any sense to change the tooltip based on what actions are in the dropdown. Think about the gear icon as a way to access secondary actions for the notification that are not shown as primary buttons. So the name would have to reflect that and be static, not depending on the contents.

the gear icon as a way to access secondary actions for the notification that are not shown as primary buttons

I guess I'm just sharing feedback that my lived experience with the product is that it has never been this.  Would love to see the scenarios where it does this, but I've just never seen it outside of the reason I logged this feedback.

So the name would have to reflect that and be static, not depending on the contents.

Yeah I think this is the best as well (localization easier, etc., etc.)

Going with "More Actions..." which is what we use in all other places where we have a "..." dropdown menu.


About timeout cases

Hello,
I want to ask you an error about this issue. In documentation, it says i can handle statusCode on catch block.

But when i try to handle statusCode, it always return undefined. I have a timeout exception but I couldn't handle it. It becomes in catch block and error is not an object. It return a string and this string is localized. I mean it writes in local language. How can i handle timeout exceptions? (BTW I am using 0.16.4)

Is it still the case with 0.18.3?

Unfortunately the error persists. I upgraded to 0.18.3.

Other thing which I couldn't handle, error prints in local language. I couldn't disable to translate it. If it always return english, it will be solution for me.


ChroniquesOublieesContemporain Version 3.17.0

Submission Checklist
Required

[x] The pull request title clearly contains the name of the sheet I am editing.
[x] The pull request title clearly states the type of change I am submitting (New Sheet/New Feature/Bugfix/etc.).
[x] The pull request makes changes to files in only one sub-folder.
[x] The pull request does not contain changes to any json files in the translations folder (translation.json is permitted)

New Sheet Details

The name of this game is: <   >  (i.e. Dungeons & Dragons 5th Edition, The Dresden Files RPG)

The publisher of this game is: <   > (i.e. Wizards of the Coast, Evil Hat)

The name of this game system/family is: <   > (i.e. Dungeons & Dragons, FATE)

[ ] I have followed the Character Sheets Standards when building this sheet.

[ ] I have authorization from the game's publisher to make this an official sheet on Roll20 with their name attached.
[ ] This game is not a traditionally published game, but a copy of the game rules can be purchased/downloaded/found at: <   >
[ ] This sheet is for an unofficial fan game, modification to an existing game, or a homebrew system.

Changes / Description
Created 3 sub-tabs (ability rolls, traits list and buffs list) on the abilities tab to make it less cluttered

Character Sheet Info Roll20 Internal Use only.


Not relevant suggestions for methods

OK:

Not OK:

Is it well known limitation or the addin is not working properly in my environment?
(windows 7 x64).

I have this issue as well. I believe it comes from sublime itself (or possibly another package) which tries to guess what you can write. It is based on the content of the file, and not the output from racer.
I would actually like this plugin to disable other autocompleters when inside a rust file. It is super annoying as you never know if the suggestions are legit, or not. It actually turns this plugin useless, which makes me sad.

+1


Build binaries before images

What this PR does / why we need it:
Binaries must be already built for the image build to succeed.
Special notes for your reviewer:
Release note:

NONE

/lgtm
/approve


Enable find_package(vrslib) & install libraries and vrs binary

Summary:
Add vrs_ libs to vrs::namespace

Set some libs dependencies as PRIVATE
Remove keyword STATIC, since it is the default behavior
Add rules for installation and usage with cmake find_package(vrslib)

Since vrslib is using IMPORTED cmake targets (::) we don't know if they are static or dynamic. We so need to retrieve at find_package all vrs dependencies on the fly.

How to use it then in cmake:
find_package(vrslib REQUIRED)
add_executable(foo foo.cpp)
target_link_libraries(foo vrs::vrslib vrs::vrs_utils)
#vrs includes and dependencies will come transitively

Differential Revision: D35664218

Closing. Replaced with #42


[ Feature Request ] Add conditional extension

Is your feature request related to a problem? Please describe.
Yes, This will eliminate the ugly if-else blocks. I don't know it is feasible or not. Just an idea.
Describe the solution you'd like
I want to achieve something like this.
.when(condition,stylesWhenTrue )

example

'John'.text.size(30).when(1==1, ___ ).color(Colors.white).make()

Additional context
This is just an idea that is similar to laravel query builder
https://laravel.com/docs/8.x/queries#conditional-clauses

I want To work on this issue

@delikin @GautamSharma05 go ahead

it will be nice addition


Altex - Jobs do not start with a capital letter

ENVIROMENT: production
URL: https://peviitor.ro/
Browser: Chrome
Device: laptop
OS: Windows 10
STEPS TO REPRODUCE:
Open URL in browser
Write the job title
See the job list.
EXPECTED RESULT:
To see all jobs with capital letters.
ACTUAL RESULT:
You see all jobs with lowercase letters.

Fixed, please try again.


[FLINK-15322][hive] Parquet test fails with Hive versions prior to 1.2.0

What is the purpose of the change
Fix parquet test for Hive versions prior to 1.2.0
Brief change log

Don't test date type for parquet tables in Hive versions prior to 1.2.0

Verifying this change
This change is a trivial rework / code cleanup without any test coverage.
Does this pull request potentially affect one of the following parts:
NA
Documentation
NA

cc @bowenli86 @JingsongLi @xuefuz @zjuwangg
It's a trivial change. Please have a look. Thanks.


Lists az cli version 2.0.65 as pre-req but that's not released yet

is 2.0.65 really a pre-req?
Latest release is 2.0.64:
https://github.com/Azure/azure-cli/releases

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 93aa980e-1970-235c-228a-7b19880171b8
Version Independent ID: 6f7937a4-12e0-d61c-3bd8-c6347ec48385
Content: Tutorial - Create an Azure Red Hat OpenShift cluster
Content Source: articles/openshift/tutorial-create-cluster.md
Service: openshift
GitHub Login: @TylerMSFT
Microsoft Alias: twhitney

Yes, 2.0.65 is required but is not released yet. There is a problem with 2.0.64 that prevents the tutorial from working.

#please close

Thanks @TylerMSFT
@clauslund  We will now close this issue. If there are further questions regarding this matter, please tag me in a comment. I will reopen it and we will gladly continue the discussion.


ghci: unknown GLUT entry glutInit on Darwin, GHC 7.10.3

GLUT version is <IP_ADDRESS>, this feels related to the https://ghc.haskell.org/trac/ghc/ticket/10568 saga.
dlsym (used by hs_GLUT_getProcAddress) does not find glutInit, however the framework is actually loaded. Compiled binaries work fine.
Prelude> :m +Graphics.UI.GLUT
Prelude Graphics.UI.GLUT> getArgsAndInitialize
*** Exception: user error (unknown GLUT entry glutInit)

...
Prelude Graphics.UI.GLUT System.Posix.DynamicLinker> dlsym Default "glutInit"
*** Exception: user error (dlsym: dlsym(RTLD_DEFAULT, glutInit): symbol not found)

Starting ghci with DYLD_INSERT_LIBRARIES=/System/Library/Frameworks/GLUT.framework/GLUT serves as a workaround, however I'm not sure what's the best way to resolve this problem properly.

Alas, I can't really help here, and I'm not sure if this issue is related to the Trac issue or not. I don't develop on Mac OS X and dynamic linking under that OS is a mystery to me, :confused:  so I would need some help from others. Patches are happily accepted!
Which Mac OS X version is it, BTW?

This is 10.11.3, I'll try to get more information from the linker when I get a chance.

I get the same error on Linux with ghc-7.10.3 and GLUT-<IP_ADDRESS>.
Symptoms are the same: exception when trying to run main from ghci, while compiled binary works fine.

FYI: I can reproduce this locally now:
sp@Klappkatze:~/repos/haskell/GLUT(master)$ lsb_release -a; uname -a
No LSB modules are available.
Distributor ID:	Ubuntu
Description:	Ubuntu 15.10
Release:	15.10
Codename:	wily
Linux Klappkatze 4.2.0-30-generic #36-Ubuntu SMP Fri Feb 26 00:58:07 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux
sp@Klappkatze:~/repos/haskell/GLUT (master)$ stack init
Using cabal packages:
- GLUT.cabal

Selecting the best among 7 snapshots...

Downloaded lts-5.8 build plan.
Caching build plan
Fetched package index.
Populated index cache.
* Matches lts-5.8

Selected resolver: lts-5.8
Initialising configuration using resolver: lts-5.8
Total number of user packages considered: 1
Writing configuration to file: stack.yaml
All done.
sp@Klappkatze:~/repos/haskell/GLUT (master)$ stack build
half-<IP_ADDRESS>: using precompiled package
stm-<IP_ADDRESS>: using precompiled package
random-1.1: using precompiled package
text-<IP_ADDRESS>: using precompiled package
fixed-<IP_ADDRESS>: using precompiled package
StateVar-<IP_ADDRESS>: using precompiled package
OpenGLRaw-<IP_ADDRESS>: configure
OpenGLRaw-<IP_ADDRESS>: build
ObjectName-<IP_ADDRESS>: download
ObjectName-<IP_ADDRESS>: configure
ObjectName-<IP_ADDRESS>: build
ObjectName-<IP_ADDRESS>: copy/register
OpenGLRaw-<IP_ADDRESS>: copy/register
GLURaw-<IP_ADDRESS>: download
GLURaw-<IP_ADDRESS>: configure
GLURaw-<IP_ADDRESS>: build
GLURaw-<IP_ADDRESS>: copy/register
OpenGL-<IP_ADDRESS>: download
OpenGL-<IP_ADDRESS>: configure
OpenGL-<IP_ADDRESS>: build
OpenGL-<IP_ADDRESS>: copy/register
GLUT-<IP_ADDRESS>: configure
Configuring GLUT-<IP_ADDRESS>...
GLUT-<IP_ADDRESS>: build
Preprocessing library GLUT-<IP_ADDRESS>...
[ 1 of 24] Compiling Graphics.UI.GLUT.Raw.Tokens ( src/Graphics/UI/GLUT/Raw/Tokens.hs, .stack-work/dist/x86_64-linux/Cabal-<IP_ADDRESS>/build/Graphics/UI/GLUT/Raw/Tokens.o )
...
[24 of 24] Compiling Graphics.UI.GLUT ( src/Graphics/UI/GLUT.hs, .stack-work/dist/x86_64-linux/Cabal-<IP_ADDRESS>/build/Graphics/UI/GLUT.o )
In-place registering GLUT-<IP_ADDRESS>...
GLUT-<IP_ADDRESS>: copy/register
Installing library in
/home/sp/repos/haskell/GLUT/.stack-work/install/x86_64-linux/lts-5.8/7.10.3/lib/x86_64-linux-ghc-7.10.3/GLUT-<IP_ADDRESS>-JNIRygqUREF8PATQIIv0CL
Registering GLUT-<IP_ADDRESS>...
Completed 11 action(s).
sp@Klappkatze:~/repos/haskell/GLUT (master)$ stack ghci
Configuring GHCi with the following packages: GLUT
GHCi, version 7.10.3: http://www.haskell.org/ghc/  :? for help
ghc: panic! (the 'impossible' happened)
  (GHC version 7.10.3 for x86_64-unknown-linux):
	Loading temp shared object failed: /tmp/ghc13666_0/libghc_1.so: undefined symbol: glutStrokeRoman

Please report this as a GHC bug:  http://www.haskell.org/ghc/reportabug

sp@Klappkatze:~/repos/haskell/GLUT (master)$ cd examples/RedBook4
sp@Klappkatze:~/repos/haskell/GLUT/examples/RedBook4 (master %)$ stack ghc Stroke.hs
[1 of 1] Compiling Main             ( Stroke.hs, Stroke.o )
Linking Stroke ...
sp@Klappkatze:~/repos/haskell/GLUT/examples/RedBook4 (master)$ ./Stroke
sp@Klappkatze:~/repos/haskell/GLUT/examples/RedBook4 (master)$

This used to work in ghci at some point in time, too. I'll take a look...

This seems to have changed between GHC 7.8 and 7.10, since it works fine in GHCi 7.8:
$ /opt/ghc/7.8.4/bin/ghci
GHCi, version 7.8.4: http://www.haskell.org/ghc/  :? for help
Loading package ghc-prim ... linking ... done.
Loading package integer-gmp ... linking ... done.
Loading package base ... linking ... done.
λ> import Graphics.UI.GLUT
λ> getArgsAndInitialize
Loading package transformers-<IP_ADDRESS> ... linking ... done.
Loading package array-<IP_ADDRESS> ... linking ... done.
Loading package deepseq-<IP_ADDRESS> ... linking ... done.
Loading package bytestring-<IP_ADDRESS> ... linking ... done.
Loading package containers-<IP_ADDRESS> ... linking ... done.
Loading package binary-<IP_ADDRESS> ... linking ... done.
Loading package fixed-<IP_ADDRESS> ... linking ... done.
Loading package half-<IP_ADDRESS> ... linking ... done.
Loading package text-<IP_ADDRESS> ... linking ... done.
Loading package OpenGLRaw-<IP_ADDRESS> ... linking ... done.
Loading package GLURaw-<IP_ADDRESS> ... linking ... done.
Loading package ObjectName-<IP_ADDRESS> ... linking ... done.
Loading package stm-<IP_ADDRESS> ... linking ... done.
Loading package StateVar-<IP_ADDRESS> ... linking ... done.
Loading package OpenGL-<IP_ADDRESS> ... linking ... done.
Loading package GLUT-<IP_ADDRESS> ... linking ... done.
("<interactive>",[])

I don't know how robust of a solution this is, but I can fix the error by making this change:
diff --git a/cbits/HsGLUT.c b/cbits/HsGLUT.c
index dab31ff..0f2026d 100644
--- a/cbits/HsGLUT.c
+++ b/cbits/HsGLUT.c
@@ -140,7 +140,7 @@ hs_GLUT_getProcAddress(const char *name)
   if (firstTime) {
     firstTime = 0;
     /* Get a handle for our executable. */
-    handle = dlopen(NULL, RTLD_LAZY);
+    handle = dlopen("libglut.so", RTLD_LAZY);
   }

   return handle ? dlsym(handle, name) : NULL;

This makes GLUT work in GHCi 7.8.4, 7.10.3, and 8.0.1-rc4, using 64-bit Linux.

I'll give this a try, but I still don't understand why this change is needed when glut is in extra-libraries.

Closing this one, see the discussion in #23.


styled function getting wrong theme object in Jest tests

Duplicates

[X] I have searched the existing issues

Latest version

[X] I have tested the latest version

Current behavior 😯
I've just migrated one of my components from JSS to the styled components, as described on the migration page.  Everything works fine in storybook, and the correct (custom) theme object is being applied. But when running unit tests, if I check applied styles to the rendered component, it's not getting the custom theme.  It only ends up with the default theme object within styled.
Expected behavior 🤔
Should pass in correct theme object in Jest environment.
Steps to reproduce 🕹
Steps:

Create custom theme using createTheme
Create component using styled and use elements from the theme within the styles
Test applied styles in a Jest unit test, using toHaveStyle by wrapping the component in a ThemeProvider with the custom theme and rendering with @testing-library/react.

Context 🔦
We need to be able to test that the correct colors are being applied, depending on if it's dark or light theme, and under different breakpoints.
Your environment 🌎
System:
OS: Windows 10 10.0.18363
Binaries:
Node: 14.17.0 - C:\Program Files\nodejs\node.EXE
Yarn: 1.22.15 - ~\AppData\Roaming\npm\yarn.CMD
npm: 7.18.1 - ~\src\quantum\node_modules.bin\npm.CMD
Browsers:
Chrome: 96.0.4664.45
Edge: Spartan (44.18362.1593.0)

It doesn't look like this bug report has enough info for one of us to reproduce it.
Please provide a CodeSandbox (https://material-ui.com/r/issue-template-latest), a link to a repository on GitHub, or provide a minimal code example that reproduces the problem.
Note: from what you describe, you are testing component style in different breakpoints. I suggest you checkout chromatic which is a tool from the storybook team for visual testing. I think it will give you more confidence than using Jest. Feel free to neglect my suggestion if you already have considered it.

@siriwatknp thanks for the reply.  My mention of breakpoints was more of a detail about my use, than an issue.  The problem is that the theme object that's coming into the styled function isn't the theme  passed into the MUI ThemeProvider when running jest tests.  It's just the default theme object. I've had to work around it, by creating a wrapper function that passes in the theme returned from the useTheme hook instead.  What's weird is that in action, when running in storybook it all works fine.  But in Jest it's just the defaults.  I'll try and mock up a repro to share.  I encountered this on a private codebase in my company.

@michaelfaith make sure you use the ThemeProvider coming from @mui/material/styles.

Any suggestions on where I might dig into for that?

Can you provide the link to the repo?

Any suggestions on where I might dig into for that?

Can you provide the link to the repo?

The code sandbox is here:  https://codesandbox.io/s/mui-styled-issue-mpk2u?file=/src/Demo.test.tsx
The repo for the project I'm experiencing the issue is in our corporate repos, and unfortunately not shareable. I tried setting that sandbox up with a boiled down version of what I'm trying to do, and replicate the config that I figured would affect this.  The only thing I wasn't able to do in the sandbox, that we have in our project is this jest mock in the jest.setup.ts, to help with consistent snapshotting.  codesandbox doesn't appear to support jest.mock like that.  Do you think that could impact this?
jest.mock('@mui/utils/useId', () => jest.fn().mockReturnValue('mui-test-id'));

Removing that mock didn't make a difference.

I found a stackoverflow post with someone seemingly having the exact same issue: https://stackoverflow.com/questions/69328284/jest-rtl-failure-mui-v5-emotion-theme-issue  I've encouraged them to post a reproduction here, if they have one.  I've been struggling to recreate it outside of our project.  I didn't think to mention before, we're working in a yarn (1.x) workspaces environment, in case that is helpful at all.

I found a stackoverflow post with someone seemingly having the exact same issue: https://stackoverflow.com/questions/69328284/jest-rtl-failure-mui-v5-emotion-theme-issue I've encouraged them to post a reproduction here, if they have one. I've been struggling to recreate it outside of our project. I didn't think to mention before, we're working in a yarn (1.x) workspaces environment, in case that is helpful at all.

will try to reproduce it this week. will post an update on this issue.

@siriwatknp I am the individual that posted the SO post that @michaelfaith is referencing.  I too posted an issue here, but it got closed for not having a code sandbox.  Unfortunately, there is something within our corporate projects that is to blame it looks like.  I can get the ThemeProvider to work and inject the theme just fine if I just do a very basic example in a code sandbox.
@michaelfaith What version of Jest and RTL are you using?  Maybe MUI is expecting a certain version so that it knows how to pass along the theme when invoke in Jest.  We are using 27.3.1 of jest and 12.1.2 of @testing-library/react.

@siriwatknp  @shaneajeffery we were finally able to get this working.  And it's not entirely clear how.  I tried incrementally reducing the packages from our project to isolate the dependencies.  It started, working at some point, and so I started slowly adding dependencies back, and it never stopped working.  So at the end of that exercise we ended up with the same package.json, but an updated yarn.lock with newer versions of a number of the packages.  Some notable ones:
@emotion/styled 10.0.27 -> 10.3.0
@emotion/styled-base 10.0.31 -> 10.3.0
@emotion/jest 11.6.0 -> 11.7.1
jest & @jest/core 27.4.3 -> 27.4.5
@testing-library/react remained unchanged at 12.1.2

@siriwatknp @michaelfaith It is most certainly a dependency issue.  I went ahead and just updated all of my dependencies in my package.json to the latest using https://www.npmjs.org/package/npm-check-updates and
npx npm-check-updates -u
npm install

Now, my issue is gone and I don't need to use the useTheme anymore to inject the theme into the styled component.
The issue has to be the older version of Emotion + MUI + Jest not playing well together.  If someone else runs into this issue, I would ensure that you are on the latest version of all of the libraries and seeing where that gets you.  I wish I had more of a clear-cut answer, but this issue is really just a trial-and-error bit due to the sheer volume of dependencies in the tree.

@michaelfaith @shaneajeffery Thanks for the info, it will save a lot of time for other people!

Note @emotion/styled & @emotion/react should be >= 11 for MUI v5
Yeah, that's a good point.  We have this declared in our package.json.

"@emotion/react": "^11.7.0",
"@emotion/styled": "^11.6.0",

It looks like storybook is pulling in the older emotion:
"<EMAIL_ADDRESS>  version "6.4.9"
  dependencies:
    "@emotion/core" "^10.1.1"
    "@emotion/is-prop-valid" "^0.8.6"
    "@emotion/styled" "^10.0.27"
    "@storybook/client-logger" "6.4.9"
    core-js "^3.8.2"
    deep-object-diff "^1.1.0"
    emotion-theming "^10.0.27"
    global "^4.4.0"
    memoizerific "^1.11.3"
    polished "^4.0.5"
    resolve-from "^5.0.0"
    ts-dedent "^2.0.0"


Download P1861 second run data

The P1861 project apperently has some new sequencing data in another run. this needs to also be downloaded.
Cave: some samples that were in the initial test run were not sequenced again:
P1861_APA23_T_S_S41_L006 | run1 | P1861 | APA23-TS | S41 | L006
P1861_APA32_T_S_S42_L006 | run1 | P1861 | APA32-TS | S42 | L006
P1861_APA45_T_S38_L006 | run1 | P1861 | APA45-T | S38 | L006
P1861_APA53_T_S39_L006 | run1 | P1861 | APA53-T | S39 | L006
P1861_APA61_T_S40_L006 | run1 | P1861 | APA61-T | S40 | L006
P1861_APA61_T_S_S43_L006 | run1 | P1861 | APA61-TS | S43 | L006

Wrote mail to support on 2024-05-30

Data has been downloaded


TypeError: Cannot read property 'call' of undefined

const emitter = new EventEmitter();

emitter.once('my-event', () => console.log('OK 1'));
emitter.once('my-event', () => console.log('OK 2'));

emitter.emitAsync('my-event');

TypeError: Cannot read property 'call' of undefined
    at EventEmitter.emitAsync (…/node_modules/eventemitter2/lib/eventemitter2.js:455:35)

Is it possible this is a bug?

Looks like it, I don't have too much time to look into it, but if you could send a PR or an explanation of what's wrong it'll speed up fixing it.

Sure thing. I'll see to look into it.

Thank you! It's likely something to do with iterating through handlers in emiAsync on line e455


remove kubectl installation from Dockerfile

kubectl doesn't seem to be in use anywhere within the code, so removing it from the Dockerfile should simplify the image creation and shrink the image size somewhat

https://github.com/project-codeflare/multi-cluster-app-dispatcher/blob/7171e8e951b3121f172bf969cc3cc55589c3c9b8/hack/run-e2e-kind.sh#L382
I found this in the testing directory. Is the Dockerfile installing kubectl for testing? If it is then I'm wondering whether another Dockerfile needs to be created as CI specific tooling and code shouldn't be part of the final controller image.

@KPostOffice feel free to merge this if you have no rights, I will merge it in the morning.


Fixed linter errors

What this PR does / why we need it: Fix linter errors.
Which issue this PR fixes : fixes #1446
Special notes for your reviewer:
Release note:

@JimmyCYJ: Adding do-not-merge/release-note-label-needed because the release note process has not been followed.

One of the following labels is required "release-note", "release-note-action-required", or "release-note-none".
Please see: https://github.com/kubernetes/community/blob/master/contributors/devel/pull-requests.md#write-release-notes-if-needed.
Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@JimmyCYJ: The following test failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-presubmit.sh
04e193cbaa172ac896b5dac29d37693ae2b741eb
link
/test istio-presubmit

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@JimmyCYJ: The following test failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-presubmit.sh
eb4850516b915ff1de1ef2e6e687f57a4d34152a
link
/test istio-presubmit

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@JimmyCYJ: The following test failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-presubmit.sh
05a62e3085912990318c99de6f7fdf973ccc5fd5
link
/test istio-presubmit

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

Thanks for doing this, please fix the presubmit.sh https://k8s-gubernator.appspot.com/build/istio-prow/pull/istio_istio/1787/istio-presubmit/386/

/lgtm


File type is blank in Windows 7 and Windows 10

Using
<input type="file" ngf-select ng-model="uploadSelections.csvFile" />

whenever I look at $scope.uploadSelections.csvFile.type in Mac OS, it returns text/csv as expected.
However, in Windows (7 and 10 tested), running Chrome and IE11, $scope.uploadSelections.csvFile.type returns an empty string ''. The file object looks like this
File {}
  lastModified:<PHONE_NUMBER>000
  lastModifiedDate: Tue Dec 15 2015 19:10:07 GMT-0800 (Pacific Standard Time)
  name: "filename.csv"
  size: 20524
  type: ""
  webkitRelativePath: ""
  __proto__: File

Any help would be appreciated.

There is not much to do since it is browser specific. You can add a function to guess the file type from the extension for the files that don't have the type reported as a workaround.

@danialfarid, this actually is not browser specific. It seems like it is more OS specific. This issue happens in both Chrome and IE in Windows 7 and 10, but works fine in Chrome in OSX.

File type property cannot be set programmatically so the best way is to have the check for file extension in the pattern.

I am having this issue as well. .csv type is empty on file upload

@danialfarid  I am also facing the same issue file type empty on windows but working fine with ubuntu.
also tried ngf-pattern="*" but no success.
any solution for the same?

Hello! I come from the future to tell you not to rely on filetype mime type when using FileList since on Windows this is blank.
Just had this exact same problem, commenting here since this is the only reference to this problem I've found online.
-                if (fileList[0].type === 'text/csv') {
+                if (/\.csv$/i.test(fileList[0].name)) {

Cheers!


Valve intro video: try to load a MOV file if the BIK file doesn't exist.

The macOS Portal version uses a .mov file, so if the .bik file doesn't exist, let's try that.

Today I learned :)


Add Japanese support

Sorry for the late response.
I can add this, but I won't make it automatically switch the language.
So you'd need to manually replace the messages file.
Is this fine with you?

OK, so please.


Abalone Model: Regression and Classification

So the normal model for the Abalone dataset is a regression model, we should also make a classification version just to flex out the SageWorks classes and Web Interfaces.

Done :)


chore: revert posthog js version nump

posthog bump broke e2e tests, we need to revert the change

Allure Report
allure-report-publisher generated test report!

processReports: ✅ test report for 015ea863

passed
failed
skipped
flaky
total
result

Total
32
0
4
0
36
✅


Render error traces differently

The tracer in main now tracks errors too:

https://github.com/simonw/datasette/issues/2405

This works by adding a new {"error": "error string here"} key to the traces.

This feature won't actually do anything until the next Datasette alpha release, but I'm going to ship it as a major version anywhere since it won't break existing older Datasette versions.

Against 0.64.8:

Against Datasette main: