Gumbel noise samples

Thanks for your great work! I have a question about Gumbel noise. Standard Gumbel noise can be sampled using G = -log(-log(u)), however in the code I find that you're using  log(u)-log(1-u), which is not equivalent. Could you explain it please?

Oh, after I read the original paper I realized this is a special case for binary case.

Sorry for the late reaction. Glad you found the answer. Good luck!


Added support for ON DELETE CASCADE to the schema

no-issue
We are in the process of creating migrations to add ON DELETE CASCADE
to the members_stripe_* tables to make bulk deletion faster. This change
allows us to support the constraint at db initialisation from the schema

Hey @kevinansfield short n sweet change to support cascade deletes in schema.js - I think we shouldn't merge until after the release this week though - have it all go in together


Add Support for custom Scoring Profiles

After reviewing, this won't work as I expected, will need to figure out another way to allow custom Scoring Profiles (via the configuration)


add openshift docs

update kfctl install instructions
update kfctl binaries with 1.2.0 version
fix markdown formatting on readme page

Is this pending on anything @moficodes?

it is waiting on the multiuser kfdef being merged into kubeflow manifest.
if we decide to not merge it for the time being, I will then change this pr to use my own github repo for manifest.


docs(api): Improve sentry_sdk.trace type hints

Type hints for sentry_sdk.trace decorator function now indicate that the decorator returns a function with the same signature as it was called with. Previously, the type hints indicated that the decorator could return Any, which caused users to lose type hints for decorated functions.
Before this change:

After this change:

Fixes GH-2460

@sentrivana Is docs the correct commit message scope here? It seems appropriate to me since type hints in Python aren't part of the code, but rather they serve only to document expected types. Or do you have a different idea?

@szokeasaurusrex Looking at sentry folks seem to usually either go with ref or fix for type hint fixes/changes so I'd probably pick one of those.


adding a hashtable

[ /] Top-level README “Table of Contents” is updated
[ /] README for this challenge is complete
[/ ] Summary, Description, Approach & Efficiency, api
[ /] Link to code
[/ ] Feature tasks for this challenge are completed
[ /] Unit tests written and passing


Add preprocess & capability for custom dataset for mt

PR types

New features
PR changes

Others
Description

Add preprocess & capability for custom dataset for mt.

In order to verify the correctness of  our changes, could you reproduce the experimental results on IWSLT14 de->en dataset?

Do we plan to merge this into master branch?

@guoshengCS

@guoshengCS


updated java and scoverage versions

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/bdg-utils-prb/80/Build result: FAILURE[...truncated 32 lines...]Triggering bdg-utils-prb ? 2.10,1.5.2,2.3.0,centosTriggering bdg-utils-prb ? 2.11,2.0.0,2.3.0,centosTriggering bdg-utils-prb ? 2.10,1.3.1,2.6.0,centosTriggering bdg-utils-prb ? 2.11,1.5.2,2.3.0,centosbdg-utils-prb ? 2.10,1.3.1,2.3.0,centos completed with result SUCCESSbdg-utils-prb ? 2.10,1.4.1,2.6.0,centos completed with result SUCCESSbdg-utils-prb ? 2.11,1.5.2,2.6.0,centos completed with result FAILUREbdg-utils-prb ? 2.10,1.6.1,2.3.0,centos completed with result SUCCESSbdg-utils-prb ? 2.11,1.3.1,2.6.0,centos completed with result SUCCESSbdg-utils-prb ? 2.10,1.4.1,2.3.0,centos completed with result SUCCESSbdg-utils-prb ? 2.11,1.3.1,2.3.0,centos completed with result SUCCESSbdg-utils-prb ? 2.11,1.6.1,2.3.0,centos completed with result SUCCESSbdg-utils-prb ? 2.11,1.4.1,2.6.0,centos completed with result SUCCESSbdg-utils-prb ? 2.11,2.0.0,2.6.0,centos completed with result SUCCESSbdg-utils-prb ? 2.10,1.5.2,2.6.0,centos completed with result SUCCESSbdg-utils-prb ? 2.10,2.0.0,2.6.0,centos completed with result SUCCESSbdg-utils-prb ? 2.11,1.6.1,2.6.0,centos completed with result SUCCESSbdg-utils-prb ? 2.11,1.4.1,2.3.0,centos completed with result SUCCESSbdg-utils-prb ? 2.10,2.0.0,2.3.0,centos completed with result SUCCESSbdg-utils-prb ? 2.10,1.6.1,2.6.0,centos completed with result SUCCESSbdg-utils-prb ? 2.10,1.5.2,2.3.0,centos completed with result SUCCESSbdg-utils-prb ? 2.11,2.0.0,2.3.0,centos completed with result SUCCESSbdg-utils-prb ? 2.10,1.3.1,2.6.0,centos completed with result SUCCESSbdg-utils-prb ? 2.11,1.5.2,2.3.0,centos completed with result FAILURE
Test FAILed.

I've rebased this and opened a new PR as #92.


Fix secrets: 1Password slowness, human meddling, checks

Plan:

[x] https://github.com/TBD54566975/ftl/issues/1946
[x] https://github.com/TBD54566975/ftl/issues/1889
[x] https://github.com/TBD54566975/ftl/issues/1947

✅ On hold to batch together breaking changes

[x] https://github.com/TBD54566975/ftl/issues/1948
[x] https://github.com/TBD54566975/ftl/issues/1949
[ ] https://github.com/TBD54566975/ftl/issues/1906

Closing the epic as the next task is slightly independant


Update jvrc_description to jrl-umi3218 repository

Pull Request Test Coverage Report for Build<PHONE_NUMBER>
Details

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 98.544%

Totals

Change from base Build<PHONE_NUMBER>:
0.0%

Covered Lines:
880

Relevant Lines:
893

💛  - Coveralls


As a user, I want to see all unused data loaders, transformers, scratchpads, data exporters, charts, and sensors and be able to easily delete them.

Is your feature request related to a problem? Please describe.
A clear and concise description of what the problem is. Ex. I'm always frustrated when [...]
Describe the solution you'd like
A clear and concise description of what you want to happen.
Describe alternatives you've considered
A clear and concise description of any alternative solutions or features you've considered.
Additional context
Add any other context or screenshots about the feature request here.

We updated the file browser to indicate unused block files in this PR. Here are the docs. Files can easily be deleted from the file browser by right-clicking the file and selecting Delete file.


CMD Project

Hi,
This PR to add a new intermediate java application -> Desktop Applications
Assigned with issue #59
I hope this project helps other developers
Thanks

Thanks

Thanks


Flails have infinite durability

When hitting mobs with a flail (whether left or right-clicking), no durability is lost. At least in the 1.12.2 version.

Thanks for yet another bug report :)
Will investigate in a few days when I am home again


WIP: Condense multiple paths sent to prometheus into single routes for rai…

…ls apps
One controller and action could manage thousands of unique paths which in turn would create
thousands of unique timeseries. This places an unnecessarily high load on prometheus.
This commit replaces absolute paths with references to the controller and action that handled it.
If no route is found then we will continue to send the original path.
This is only for rails apps. Non rails apps will continue to send the original path.
Example
blogs/8, blogs/9 => blogs#view
https://trello.com/c/lUibintk/369-cut-down-the-number-of-metrics-exposed-for-dynamic-paths

Left a few codestyle comments as requested by @kentsanggds - nothing big, only a couple of really minor things you could change if you wanted to.


Add configs for broker stats update frequency

This allows to configure the initial delay and update frequency for broker stats. This is useful for dev and test clusters.

https://github.com/apache/pulsar/issues/687


feat(app): adjust application layout style

This PR adjusts the application layout style to match the current design from the Figma project.

[x] Sidebar
[x] Navbar

This PR is depending on https://github.com/themesberg/flowbite-react/pull/825

This PR is depending on themesberg/flowbite-react#825

flowbite-react PR merged

I saw same details, but I think we can address in another issues


Updated MultiQC and updated snaps

PR checklist

[ ] This comment contains a description of changes (with reason).
[ ] If you've fixed a bug or added code that should be tested, add tests!
[ ] If you've added a new tool - have you followed the pipeline conventions in the contribution docs
[ ] If necessary, also make a PR on the nf-core/nanostring branch on the nf-core/test-datasets repository.
[ ] Make sure your code lints (nf-core lint).
[ ] Ensure the test suite passes (nextflow run . -profile test,docker --outdir <OUTDIR>).
[ ] Check for unexpected warnings in debug mode (nextflow run . -profile debug,test,docker --outdir <OUTDIR>).
[ ] Usage Documentation in docs/usage.md is updated.
[ ] Output Documentation in docs/output.md is updated.
[ ] CHANGELOG.md is updated.
[ ] README.md is updated (including new tool citations and authors/contributors).

Closing this PR, having the latest MultiQC version doesn't have an impact on results quality, moving this issue to a lower priority to avoid blocks


fix typo in repo name

fixed typo

@jakemulley are you able to advise - have i tried to be helpful but also unhelpful?


makefile support on each supported hardware ?

i would like to use periph/bootstrap so we can deploy golang and flutter ( source and binaries) to embedded devices...
We use makefile such that it allows us to use make in Github Actions and on our embedded devices with no changes except maybe some sniffing in the makefiles to detect GOOS , GOARCH, etc
Here is an example of make being used in this way:  https://github.com/getcouragenow/booty/blob/master/makefile
Here is it running: https://github.com/getcouragenow/booty/actions/runs/468914088
SO , I was wondering if your bootstrap installs make on each device ?

On a Raspbian I see it being installed indirectly. I forget how to determine the dependency that got it installed. I don't know for other distros (e.g. Armbian)

On a Raspbian I see it being installed indirectly. I forget how to determine the dependency that got it installed. I don't know for other distros (e.g. Armbian)


Upgrade to the latest httpclient

Apache HttpClient is on version 4.5.3.  Upgrade to this version to benefit from any bug fixes, and security or performance improvements.

Run a couple of DMSDK and regular tests. No issues found so far.


Fix security patches reported in #1599

I think this is the fix:
https://github.com/photo/frontend/pull/1600/commits/65bb09e3c226412a77d2cc9468c1a183dfbf4535


Prepare v1.17 stable branch

Signed-off-by: André Martins<EMAIL_ADDRESS>Please ensure your pull request adheres to the following guidelines:

[ ] For first time contributors, read Submitting a pull request
[ ] All code is covered by unit and/or runtime tests where feasible.
[ ] All commits contain a well written commit description including a title,
description and a Fixes: #XXX line if the commit addresses a particular
GitHub issue.
[ ] If your commit description contains a Fixes: <commit-id> tag, then
please add the commit author[s] as reviewer[s] to this issue.
[ ] All commits are signed off. See the section Developer’s Certificate of Origin
[ ] Provide a title or release-note blurb suitable for the release notes.
[ ] Are you a user of Cilium? Please add yourself to the Users doc
[ ] Thanks for contributing!

Fixes: #issue-number
<!-- Enter the release note text here if needed or remove this section! -->

/test-backport-1.17

The CI has passed, the Documentation failed, the new change is here. The successful test run is here


UI Button: Dynamic Properties

Description
It should be possible to override the configuration of the button at runtime by passing in msg.<property> messages to change the following properties:

[ ] Label
[ ] Icon
[ ] Tooltip

Have you provided an initial effort estimate for this issue?
I have provided an initial effort estimate

Closed by https://github.com/FlowFuse/node-red-dashboard/pull/864


Pydantic Errors for Hdl21 Types

There are quite a few places in Hdl21 where we recognize it will be a common error to confuse one type of thing for another, and provide some very targeted user feedback to help with the confusion. Module._attr_type_error serves as a prime example, which does stuff like so:
https://github.com/dan-fritchman/Hdl21/blob/524373b7f4b8f14a47f2ee5287863fe0ff58d630/hdl21/module.py#L375
    if isinstance(val, (Generator, Primitive, ExternalModule)):
        msg = f"Cannot add `{type(val).__name__}` `{val.name}` to `Module` `{m.name}`. Did you mean to make an `Instance` by *calling* it - once for params and once for connections - first?"
    elif isinstance(val, Module):
        msg = f"Cannot add `{type(val).__name__}` `{val.name}` to `Module` `{m.name}`. Did you mean to make an `Instance` by *calling* to connect it first?"
    elif isinstance(val, (GeneratorCall, PrimitiveCall, ExternalModuleCall)):
        msg = f"Cannot add `{type(val).__name__}` `{val}` to `Module` `{m.name}`. Did you mean to make an `Instance` by *calling* to connect it first?"
    else:
        msg = f"Invalid Module attribute {val} of type {type(val)} for {m}. Valid `Module` attributes are of types: {list(ModuleAttr.__args__)}"
    raise TypeError(msg)

One place these errors do not show up - and we have not been providing great feedback - is in the ValidationErrors commonly generated by our many Pydantic dataclasses. The feedback is particularly poor for union types, like from this snippet here:
import hdl21 as h

@h.paramclass
class MyParams:
    m = h.Param(dtype=h.Instantiable, desc="Module to instantiate")

MyParams(h.Mos) # <= Look here

Produces:
pydantic.error_wrappers.ValidationError: 4 validation errors for MyParams
m
  instance of Module expected (type=type_error.arbitrary_type; expected_arbitrary_type=Module)
m
  instance of ExternalModuleCall, tuple or dict expected (type=type_error.dataclass; class_name=ExternalModuleCall)
m
  instance of GeneratorCall expected (type=type_error.arbitrary_type; expected_arbitrary_type=GeneratorCall)
m
  instance of PrimitiveCall, tuple or dict expected (type=type_error.dataclass; class_name=PrimitiveCall)

(a) That's a mouthful
(b) All of the Call types are not really front-page user-facing things; it's probably not obvious what any of them are

Since it's probably pretty unclear, the fix is:
MyParams(h.Mos()) # <= Note `Mos()` here

Good news is, we learned quite a bit about customizing these Pydantic validations while upgrading our Scalar numeric type. Scalar is now more or less this:
class Scalar(BaseModel):
    """
    Generally this means
    ````python
    Union[Prefixed, Literal]
    ```
    with built-in automatic conversions from each of:
    ```python
    [str, int, float, Decimal]
    ```
    when used in `paramclass` definitions.
    """
    __root__: Union[Prefixed, Literal]

Seems we could apply this to a few more. Or at least one - Instantiable - would help quite a lot.

Related: #157


Silence sphinx warnings

This prepares our docstrings for the improvements to napoleon in the upcoming sphinx release (I'm not aware of a fixed date, though). napoleon now has a stricter syntax for parameter type specs with napoleon_use_param = True, which allows it to link to all referenced types.
We can't do much about the inherited docstrings, though, so we'd probably have to fix that upstream.

[ ] eventually closes #3370
[x] Passes isort . && black . && mypy . && flake8
[ ] User visible changes (including notable bug fixes) are documented in whats-new.rst
[ ] New functions/methods are listed in api.rst

@spencerkclark, while working on this PR I got a warning about CFTimeOffset not being linkable in CFTimeIndex.floor / ceil / round. Looking through the code, I can only find BaseCFTimeOffset, there's no CFTimeOffset class (maybe we should rename that base class?).
Anyway, I don't think any of those is part of the public api? If the methods on CFTimeIndex are public, I think we either shouldn't reference these classes or make them public (or add a glossary term to define what CFTimeOffset means).

Anyway, I don't think any of those is part of the public api? If the methods on CFTimeIndex are public, I think we either shouldn't reference these classes or make them public (or add a glossary term to define what CFTimeOffset means).

Thanks for catching this; I agree they are not currently public API, so let's remove the references to them in docstrings of public functions.  And it's true, I think CFTimeOffset would be a better name for the base class, but we can wait until later to act on that.

Thanks a lot @keewis !

unfortunately, we won't be able to get this to work until the defaults channel includes sphinx version 3.2.0: pinning sphinx in doc.yml doesn't work, RTD will install sphinx from defaults, even if there's already a sphinx version installed. There has already been some effort to fix that, but I don't know if there was any progress on this since then.

@keewis: this is great!

most of the broken links are due to other sections (mostly the See Also section), but to fix that, napoleon has to first add support for preprocessing those sections.

Thanks @keewis. Great work!

A Napoleonic PR! (pun intended)


Support error tracking and APM for dart_frog

Description
https://pub.dev/packages/dart_frog
Dart Frog is a server-side framework, similar to NodeJS and friends.

Consider adding a header util instead of parsing headers manually, issue.
Check if the single hub/scope won't attach spans to the wrong transaction, this could be possible due to the nature of the Dart SDK being user SDKs as of now (Mobile, Web).

I would happily transfer ownership of the library I wrote for it: https://pub.dev/packages/sentry_dart_frog

@kahest Possible to adopt sentry_dart_frog to close this issue out?

We'll leave this issue open to track and gather interest, however we won't focus on it now (unless demand is high), due to our mobile focus and lack of interest of users


Unable to list runbooks within Skype

When asking to list my Azure Automation Runbooks in the Skype client I don't get any returned. When running the same command (list runbooks) in Microsoft Teams or Slack.
Stefan
[MSFT]

👍  I am having the same issue.
Asking the bot: list runbooks, I keep getting the following error twice: "Sorry, my bot code is having an issue"


add links to binder

for convenience: https://mybinder.org/v2/gh/Hekstra-Lab/reciprocalspaceship/master?filepath=docs%2Fexamples

Codecov Report

Merging #8 into master will decrease coverage by 0.05%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master       #8      +/-   ##
==========================================
- Coverage   98.53%   98.48%   -0.06%
==========================================
  Files          30       30
  Lines        1164     1123      -41
==========================================
- Hits         1147     1106      -41
  Misses         17       17

Flag
Coverage Δ

#unittests
98.48% <ø> (-0.06%)
:arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files
Coverage Δ

reciprocalspaceship/dtypes/base.py
96.34% <0.00%> (-0.27%)
:arrow_down:

reciprocalspaceship/dataset.py
96.48% <0.00%> (-0.10%)
:arrow_down:

reciprocalspaceship/dataseries.py
100.00% <0.00%> (ø)

reciprocalspaceship/dtypes/batch.py
100.00% <0.00%> (ø)

reciprocalspaceship/dtypes/phase.py
100.00% <0.00%> (ø)

reciprocalspaceship/dtypes/m_isym.py
100.00% <0.00%> (ø)

reciprocalspaceship/dtypes/mtzint.py
100.00% <0.00%> (ø)

reciprocalspaceship/dtypes/stddev.py
100.00% <0.00%> (ø)

reciprocalspaceship/dtypes/weight.py
100.00% <0.00%> (ø)

reciprocalspaceship/dtypes/mtzreal.py
100.00% <0.00%> (ø)

... and 4 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4622945...7ec036f. Read the comment docs.

This seems like a cool idea -- I'm not super familiar with binder, but it seems like a good way to lower the barrier to entry for trying out rs. I'll have more of a look and potentially add some additional links in the "quickstart" sections.

Thanks! This looks useful.

:rocket:


Adding email support

Currently the roadmap has a section about adding support for email. I would like to work on this but need some clarification about the roadmap.
Does it make sense to work on this now? My impression is that a lot of the supporting libraries are in place, and the problem is just to write some simple wrappers around them and "connect everything up". But, I'm not sure how this fits in with other priorities.
What features are "must haves" for a first version of this system? I looked at Django as a reference. In that framework, the email system is described as a "light wrapper" around existing libraries, and basically gives you two functions: send_mail(...) and send_mass_mail(...). Perhaps that could serve as a guide? Alternatively, it looks like the Phoenix docs just provide some examples of how to use a library (bamboo) to send email. Would an example illustrating how to use emile/mrmime/letters together, inside a dream app, be helpful?
Also, should integrations with other providers (SES, mailgun, etc.) be handled in separate libraries? This appears to be how Django does this, e.g. django-ses.

I think all of this should be done in separate libraries, with a few examples here in the Dream repo, as you suggest. Some of what's in the roadmap isn't meant for Dream directly, but needs to exist in the ecosystem in general, for the ecosystem to be useful for Web work. Writing examples is a good way to check whether the support exists, works well, and is easy to use. So, the Phoenix support sounds about right.
A first version of the email system should be usable for authentication emails (email confirmation, password reset, etc.). It should be able to pass spam filters, provided the user (app author) has the right mail provider accounts and setup on their end.

Usually emails are sent via queues. I would say we need this first :)

Just to give you some projects about emails:

mrmime (https://github.com/mirage/mrmime) which is a decoder/encoder of emails
emile (https://github.com/dinosaure/emile) which parses email addresses
colombe (https://github com/mirage/colombe) which is an implementation of SMTP in OCaml
and we currently working on DKIM/SPF and DMARC

Usually emails are sent via queues. I would say we need this first :)

@thangngoc89, this is something I was wondering about too. When building a python web app, it's pretty common to include celery and have task workers available for handling jobs that need to occur in the background (e.g. sending email(s), generating a report, recurring scheduled tasks, etc.).
Is there a standard solution for message queues in OCaml? Is that an important component of putting together a useful email example? I found amqp-client and ocamlmq. I would imagine ocaml-redis might work as well; I've used both redis and rabbitmq for celery.

@jsthomas we are missing a persistent queue solution on OCaml. The backend could be redis/rabbitmq/sql

I've been experimenting with building simple email features. I posted a short example here that uses RabbitMQ to queue email jobs; a background worker process pulls tasks from the queue and sends them via Mailgun's API.
Since Mailgun also supports SMTP, I tried using letters as well, but had some difficulties with an exception I don't understand yet. I posted an issue here, hopefully I can get that sorted out and add an SMTP example as well.

I've also added a blog post that walks through the example with more explanation and references.

The bug about SMTP is fixed, I will try to cut a release as soon as I can.

@jsthomas, thanks for the excellent blog post. I learned a lot from it. It's a great digest of the state of the ecosystem, various alternatives, external services, and a neat example.
I think we can/should do a few things to make it more "visible" from the Dream repo:

I'll create a README section for complete, big examples, and link your example from there. @tcoopman's Dream+TEA+Tailwind example can also go there.

We might be able to work a pared-down version of the example into the repo itself, if we register an email account, and a trial Mailgun account configured to be able to send only to our email account. Then, it shouldn't be a problem to let people run instances of the example without registering anything at Mailgun themselves. They can basically try out the OCaml side of things without any entanglements. It would be a sort of "email playground." What do you think about this?

I'll move some of the library recommendations into the Community projects section (and probably rename it).

If we do (2), we probably need an email provider that has some kind of API that would allow us to delete emails automatically, maybe by API call. It would be annoying to have to log into it to check for any bad spam etc., better just delete it every day or something from a cron job :) I already have the Dream playground dedicated host, which we can run such a job from.

As for the email-sending system, it looks like a pretty straightforward design internally. Each setup needs...

A queue. We need to exercise several options to make sure the framework is actually well-designed. I think we should initially support:

in-memory queues, for getting started.
(maybe) some kind of locally-persisted, brokerless queues, to avoid any Docker or cloud entanglements (as was also probably implied by @yawaramin's suggestion on Discuss). Ideally, we could use or bind something ready-made, rather than writing our own convention for using SQL here (though I've done so for internal projects).
Redis, recommending a Docker container. The other option here is to offer RabbitMQ, but for small-to-medium deployments Redis will do, and the advantage is that both the user might be using Redis for other purposes already, and we as the developers will gain more experience with Redis, and will have less to initially support.
Amazon SQS, as a typical and popular cloud provider.

Senders:

Mailgun
(maybe) Amazon SES

As I understand it, both Mailgun and SES favor APIs rather than SMTP. It would be good to exercise at least one sender that favors SMTP. Does a good such sender even exist at this point?
We would then need to write good docs on how to contribute additional queue and sender back ends.
A final note: I haven't looked into this at all, but since eml is not constrained to output HTML (it outputs "just strings"), it may be useful in compiled email templates.
I think anything involving Redis, Amazon, etc., should be in separate repos (similar to how Caqti is separate from Dream).
As for the in-Dream API, I think we need to provide guidance to users on how to trigger email rendering asynchronously (such as using Lwt.async, or through a queue), and then, ideally, we would provide some one send function that triggers the whole back end, like in Django (@jsthomas).
The overall integrated email "system" might be separate from Dream as well — but then we need to figure out queueing. Actually, it seems like figuring out how the libraries should be factored into repos is more challenging than the actual system itself, and the only reason for all this unfortunate factoring is to avoid dragging in a ton of dependencies.

So I think for an initial version, we can have some "core" dream-mail library that has a queue interface (signature) and a sender interface (signature), but does not implement them. It will also come with dream-mail-memory, dream-mail-redis, dream-mail-sqs for plugging into the queue interface, and dream-mail-mailgun, etc., plugging into the sender interface. When these are linked into a project by the web developer, they will add their module into ref lists inside the base dream-mail.
All these libraries for specific integrations can be in the same dream-mail repo, but as separate opam packages, to separate their potentially extensive dependencies. Maybe dream-mail-memory can come with the core library.
This seems pretty similar to how Caqti works, with its opt-in support for SQLite, MariaDB, and PostgreSQL.
Over time, as we find additional major uses for the queues, we will figure out how to factor them out into their own library.

Also, I think that setup is not Dream-specific, so you don't need the dream- prefix, and feel free to come up with some creative name for this :)

(Although, if we build a Dream-friendly HTTP client library and you choose to use that for accessing APIs, the library will become vaguely Dream-related again, but by that point the requset and response types will be factored out so that it's not necessary to depend on the server to get the client)

I don't think the email interface would need to bundle the queue interface. In fact, I don't think an email interface would be needed at all, given sending email would requires only a few functions to build up the email and actually send it. It would make more sense for such code to belong to a SMTP client library, or a Mailgun client library .etc. What I think really needed here is an easy queuing interface. In the past I've used Lwt.stream + Lwt_stream.n_iter for a simple in-memory queue (it was for a small user-base, so persistent was not needed).
To be fair, I think it's also okay to have an email interface/signature, and having various library implement that signature, similar to other frameworks such as Django.

To be fair, I think it's also okay to have an email interface/signature, and having various library implement that signature, similar to other frameworks such as Django.

That's basically what I'm suggesting. I think people will want to be able to switch services without potentially rewriting their client code, due to different integrations being implemented differently.

I don't think the email interface would need to bundle the queue interface.

I agree with this in principle, and in the long term, but we need to put the queue interface somewhere to start with, and it seems silly to create yet another library when it's not needed as a separate library yet. So I'm suggesting to develop it within the mail library for ease of development, and we can git filter-branch it out later into its own repo.

I've written a small library that provides a consistent interface for sending email against different services (currently Mailgun, Sendgrid, and SMTP). Feedback on whether this would be useful to dream users is welcome.

@jsthomas, I just tried the library and was able to land an email (into my spam folder, of course) using its Mailgun example! Thanks!
The library is definitely useful for Dream users. I left some initial feedback in the library issues/PRs.
I'd like to create some kind of "email sandbox," where we have pre-registered Dream-controlled Mailgun, Sendgrid, SES, etc., accounts, configured to send only to a Dream-controlled read-only inbox, which people can view. That way, people can write some test email code without having to register all these accounts just to mess around with the code. I suppose that might be against the terms of some of these services :P I'll have to check.
Does anyone know of an email account provider that can offer easy read-only access to an account inbox?


ContainerNetworkInterfaceConfiguration.container_network_interfaces field should be readonly?

The field container_network_interfaces is something only set by the server, should it be a variable instead of a parameter?

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 26cd54e5-fcc5-b13e-6f77-c615b3b54d5b
Version Independent ID: fab72fce-a084-c217-f2f8-ddb47681a3fc
Content: azure.mgmt.network.v2020_06_01.models.ContainerNetworkInterfaceConfiguration class
Content Source: docs-ref-autogen/azure-mgmt-network/azure.mgmt.network.v2020_06_01.models.ContainerNetworkInterfaceConfiguration.yml
GitHub Login: @lmazuel
Microsoft Alias: lmazuel

@jeking3 Following up to know if your issue is resolved.


Sending empty string to search endpoint results in Retrofit "bad request"

Moved the issue from a different project:
"When I due to code blunder send an empty search string to the api, it results in retroFit error "bad request", which is incomprehensible and requires debugging (at least on first encounter). RetroFit also sends the url causing the error, and when launching that url in a browser, a comprehensible Spotify (?) error message is shown: "No such query"
The combination of the url and its Spotify error message leads me directly to the cause of the error. It is suggested that the original error message (by far) is more pinpointing and helpful than the abstraction presented by Retrofit. If possible, pass the real cause along as a sub-error message or similar."

This is now fixed - please see Error Handling section for details


rcl_logging: 2.3.0-1 in 'rolling/distribution.yaml' [bloom]

Increasing version of package(s) in repository rcl_logging to 2.3.0-1:

upstream repository: https://github.com/ros2/rcl_logging.git
release repository: https://github.com/ros2-gbp/rcl_logging-release.git
distro file: rolling/distribution.yaml
bloom version: 0.10.7
previous version for package: 2.2.1-2

rcl_logging_interface
* Install includes to include/${PROJECT_NAME} (#85 <https://github.com/ros2/rcl_logging/issues/85>)
* Contributors: Shane Loretz

rcl_logging_noop

No changes

rcl_logging_spdlog

No changes

Please hold for coordinated merge.


etcd-cpp-api3 not support ipv6

how to make the etcd-cpp-apiv3 support ipv6?

Good question... IPv6 address is not supported currently ...

Good question... IPv6 address is not supported currently ...

Implemented in #262.


[NEW ALGORITHM] Heavy Light Decomposition

Issue will be closed if:

You mention more than one algorithm. You can create a separate issue for each algorithm once the current one is completed.
You propose an algorithm that is already present or has been mentioned in a previous issue.
You create a new issue without completing your previous issue.

Note: These actions will be taken seriously. Failure to follow the guidelines may result in the immediate closure of your issue.

Name:
[NEW ALGORITHM]  Heavy Light Decomposition
About:
Optimizes queries on tree paths, beneficial in competitive programming.

Labels:
new algorithm, gssoc-ext, hacktoberfest, level1

Assignees:

[x] Contributor in GSSoC-ext
[x] Want to work on it

Do not create multiple issues.


NullPointer Exception

The ViewDrag Helper throws a NullPointer when no Floating Action Button is attached.

Fixed by checking whether floating action button has been attached.


[FLINK-5549] [core] TypeExtractor fails with RuntimeException, but should use GenericTypeInfo

Fixes FLINK-5549.

+1 to merge

Merging...


Can't update page type output for existing pages

To reproduce:

Open page demo "Blog entry output"
Select "Edit defaults"
Press "Edit"
Add something to the layout
Clear cache
Check any blog entries, those are not effected - they ARE NOT.
If you create New blog entry, the change is present.

How it should be:
Just like by deleting something from Output layout, also when adding I should be asked, if I want to effect all existing items, or just new ones.
It's BIG problem!
Imagine I have 1000 posts, and now I want to add a banner to all of them Details. There is no way I can do it :(. Only removing works.

V 8.1.0

This is a duplicate of the other report, and is resolved in the same way: click on Setup on Child Pages and copy it out from there.

Will test tomorrow!

Works, but there is another problem. Will create issue.


Interested in appyevor integration ?

Hey,
I have forked your project and setup and deployment pipeline which builds the x86 and x64 project without the Unix subproject with AppVeyor. In my opinion this ci/cd pipeline could benefit the whole project as we could set it up to push build tagged with release or nightly build without much afford.
Please let me know if you are interested. If so I would submit a PR.
Regards Artur

That would be great. The last time I have looked into CI/CD for this project the problem was the VC++ support for the NativeCore sub project which requires a windows host. Now AppVeyor has free windows agents with Visual Studio and GitHub Actions too.
When you have finished the appveyor.yml config, please make a pull request.

Sound good. I may finish it tomorrow currently I can't get it to build the x64 and x86 project and persist the build files so that I can package them into one combined zip. I could easily fix this by migrating to a manual msbuild matrix but let me see if I can get it working with the automated builds first.

They I just managed to complete the AppVeyor pipeline.
See https://github.com/ReClassNET/ReClass.NET/pull/182
I could also setup a github release on a specific branch or tag. This would automatically publish the artifact to github, this would require you to provide appveyor with a auth token. Please let me know if we require this feature.


Remove setup.cfg, pyscaffold. Add pyproject.toml, setuptools-scm

Applicable Issues

https://github.com/eiffel-community/etos/issues/248

Description of the Change
This change migrates the etos-client package to pyproject.toml with dynamic versioning via setuptools-scm. The setup.cfg file and pyscaffold are removed.
Alternate Designs
Possible Drawbacks
Sign-off
Developer's Certificate of Origin 1.1
By making a contribution to this project, I certify that:
(a) The contribution was created in whole or in part by me and I
have the right to submit it under the open source license
indicated in the file; or
(b) The contribution is based upon previous work that, to the best
of my knowledge, is covered under an appropriate open source
license and I have the right under that license to submit that
work with modifications, whether created in whole or in part
by me, under the same open source license (unless I am
permitted to submit under a different license), as indicated
in the file; or
(c) The contribution was provided directly to me by some other
person who certified (a), (b) or (c) and I have not modified
it.
(d) I understand and agree that this project and the contribution
are public and that a record of the contribution (including all
personal information I submit with it, including my sign-off) is
maintained indefinitely and may be redistributed consistent with
this project or the open source license(s) involved.
Signed-off-by: Andrei Matveyeu<EMAIL_ADDRESS>

This solution is identical to how it is now done in ETOS packages:

https://github.com/eiffel-community/etos-environment-provider/pull/107
https://github.com/eiffel-community/etos-library/pull/36


[Auth] Need API to allow for getting a Session without actually signing in/persisting via the client

My use case is an app where a user with a phone account can migrate to an apple sign-in account, and we do so by first getting a valid Apple session, then calling a migrate function on our server using both the current user session and the new Apple session, and then if that succeeds, logging into the apple account with auth.setSession using the apple session.
We can't work around this by creating an independent AuthClient like so:
// create a new AuthClient, so in case migration fails we don't log out the user
let independentAuthClient = AuthClient(
    url: supabaseURL.appendingPathComponent("/auth/v1"),
    localStorage: InMemoryAuthStorage(), // Subclass which does not persist the session
    logger: nil
)
newUserSession = try await independentAuthClient.signInWithIdToken(credentials: .init(
    provider: .apple,
    idToken: token
))

Because it turns out AuthClient init actually points to a singleton.
Previously I forked the library to include a method getSessionFromIdToken which does the same API call as signInWithIdToken but then simply returns the Session rather than persisting it and "logging in" client side, but we'd like to see that officially supported.
Alternatively, support for multiple AuthClients (not pointing to a single dependency) would help too.
P.S. thank you for the quick turnaround on my last issue!
EDIT: Made a mistake with the original post thinking a function previously existed in the library.

Hi @MilesV64
Sorry for the late reply, but I was a bit confused because I couldn't remember ever having this getSessionFromIdToken method in the library 😅, your EDIT made things clearer.
Supporting multiple client instances is something that I want to tackle for a while, instead of adding this method, I prefer adding support for multiple instances.
I'll work on this next.

Started to work on a PR for this: https://github.com/supabase/supabase-swift/pull/445

Thank you @grdsdev! And yea, my mistake with the original post and appreciate you working on multiple instances!
One nice-to-have would be being able to access the defaultHeaders of supabaseClient (currently it's internal) so we don't need to hard code those headers in the newly created auth instance.

Hi, thanks a lot for this! Sorry for just now finding this, but there's an issue: when creating a new AuthClient, it still uses the shared eventEmitter which is causing bugs due to the new authClient sending events which I cannot differentiate. Link to comment on the PR https://github.com/supabase/supabase-swift/pull/445/files#r1714098710


current_role.district should try to be an integer

Pull Request Test Coverage Report for Build 1008

3 of 5 (60.0%)  changed or added relevant lines in 1 file are covered.
No unchanged relevant lines lost coverage.
Overall coverage decreased (-0.04%) to 58.657%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

scripts/to_database.py
3
5
60.0%

Totals

Change from base Build 1006:
-0.04%

Covered Lines:
996

Relevant Lines:
1698

💛  - Coveralls


MapRange included

MapRange  provides a mapping between values and value descriptions. The implementation of SetRange is changed from using a ListSet to List. Several other minor changes where made where appropriate.

This branch is not yet ready for review. Currently, implicit conversion between (Int, String) to (Integral, String) (for example) is not working.

Implicit conversions for pairs are now provided. This branch is therefore ready for review.

:+1:


Multiple fixes

Multiple fixes needed in order to fully be able to run tox.
Fixes: https://github.com/metacloud/gilt/issues/66

Hi @ssbarnea please resubmit without the travis changes.  We don't use travis, and don't have any plans to use it in the future.  Unfortunately, we don't want to allow travis access to our github org.

@retr0h Sure. I will keep travis on my fork in order to validate the changes. I am bit perplexed about how you evaluate any PR with a CI running on them but I will take all measures needed to make these small fixed ship.
The travis is a bit inconvenient but as a note, having a travis file does not mean you need to enable it. It could still prove very useful for anyone forking gilt.

The travis is a bit inconvenient but as a note, having a travis file does not mean you need to enable it. It could still prove very useful for anyone forking gilt.

That's a good point.  I hadn't thought of that.  Once this lands, I'd be open to your travis change.  Thanks !

  py27-unit: commands succeeded   py36-unit: commands succeeded   py27-lint: commands succeeded   py36-lint: commands succeeded   doc: commands succeeded   congratulations :)

Thanks @ssbarnea 🎸


[Broken] vrt download stopped working

Checklist

[X] I'm reporting a broken site support
[X] I've verified that I'm running youtube-dlc version 2020.10.31
[X] I've checked that all provided URLs are alive and playable in a browser
[X] I've checked that all URLs and arguments with special characters are properly quoted or escaped
[X] I've searched the bugtracker for similar issues including closed ones

Verbose log

PASTE VERBOSE LOG HERE

Description

WRITE DESCRIPTION HERE
Till last month or so downloading from vrt.nu worked without problems, now it fails as follows:
[debug] System config: []
[debug] User config: []
[debug] Custom config: []
[debug] Command-line args: ['-v', 'https://www.vrt.be/vrtnu/a-z/merlina/2/de-klopgeest/', '-u', 'PRIVATE', '-p', 'PRIVATE', '--verbose']
[debug] Loading archive file None
[debug] Encodings: locale cp1252, fs utf-8, out utf-8, pref cp1252
[debug] youtube-dlc version 2020.11.07
[debug] Python version 3.7.4 (CPython) - Windows-10-10.0.19041-SP0
[debug] exe versions: ffmpeg 4.2.1, ffprobe 4.2.1
[debug] Proxy map: {}
[VrtNU] Logging in
[VrtNU] Requesting a token
[VrtNU] de-klopgeest: Downloading webpage
[VrtNU] de-klopgeest: Downloading JSON metadata
ERROR: Unable to download JSON metadata: HTTP Error 410: Gone (caused by <HTTPError 410: 'Gone'>); please report this issue on https://github.com/blackjack4494/yt-dlc . Make sure you are using the latest version; see  https://github.com/blackjack4494/yt-dlc  on how to update. Be sure to call youtube-dlc with the --verbose flag and include its complete output.
File "c:\program files\python37\lib\site-packages\youtube_dlc\extractor\common.py", line 632, in _request_webpage
return self._downloader.urlopen(url_or_request)
File "c:\program files\python37\lib\site-packages\youtube_dlc\YoutubeDL.py", line 2316, in urlopen
return self._opener.open(req, timeout=self._socket_timeout)
File "c:\program files\python37\lib\urllib\request.py", line 531, in open
response = meth(req, response)
File "c:\program files\python37\lib\urllib\request.py", line 641, in http_response
'http', request, response, code, msg, hdrs)
File "c:\program files\python37\lib\urllib\request.py", line 569, in error
return self._call_chain(*args)
File "c:\program files\python37\lib\urllib\request.py", line 503, in _call_chain
result = func(*args)
File "c:\program files\python37\lib\urllib\request.py", line 649, in http_error_default
raise HTTPError(req.full_url, code, msg, hdrs, fp)

I have the same issue...
[debug] System config: []
[debug] User config: []
[debug] Custom config: []
[debug] Command-line args: ['--no-check-certificate', '--verbose', '-f', 'bestvideo[ext=mp4]+bestaudio[ext=m4a]/best[ext=mp4]/best', 'https://www.vrt.be/vrtnu/a-z/undercover/2/undercover-s2a9/']
[debug] Loading archive file None
[debug] Encodings: locale cp1252, fs utf-8, out utf-8, pref cp1252
[debug] youtube-dlc version 2020.11.07
[debug] Python version 3.9.0 (CPython) - Windows-10-10.0.17763-SP0
[debug] exe versions: ffmpeg 3.4, ffprobe 3.4
[debug] Proxy map: {}
[VrtNU] undercover-s2a9: Downloading webpage
[VrtNU] undercover-s2a9: Downloading JSON metadata
ERROR: Unable to download JSON metadata: HTTP Error 410: Gone (caused by <HTTPError 410: 'Gone'>); please report this issue on https://github.com/blackjack4494/yt-dlc . Make sure you are using the latest version; type  youtube-dlc -U  to update. Be sure to call youtube-dlc with the --verbose flag and include its complete output.
File "youtube_dlc\extractor\common.py", line 632, in _request_webpage
File "youtube_dlc\YoutubeDL.py", line 2316, in urlopen
File "urllib\request.py", line 523, in open
File "urllib\request.py", line 632, in http_response
File "urllib\request.py", line 561, in error
File "urllib\request.py", line 494, in _call_chain
File "urllib\request.py", line 641, in http_error_default


⚠ Bofrost.fr has degraded performance

In feef666, Bofrost.fr (https://www.bofrost.fr) experienced degraded performance:

HTTP code: 200
Response time: 1472 ms

Resolved: Bofrost.fr performance has improved in 3389748 after 9 minutes.


[BUG] Exception Encountered at Block #57436 in SubQuery

Could you please provide additional details regarding this issue, @devpavan04?


Load GitRepo in API before deleting issue

Fix #20921.
The ctx.Repo.GitRepo has been used in deleting issues when the issue is a PR.

make L-G-T-M work

Please send backport


Add meta to server and clients

Sometimes its nice to force something to run on eg. servers. This could be eg. an ingress controller.
So, we need to add a meta to each VM, given its role ["server", "client"]

fixed with ce867294c444785dd8c0d17971bce0c7c28af810


Support for using cloud/blob storage as persistent storage

I've been wanting to deploy this to cloud run, but from what I understand, this code relies on persistent storage outside of the docker image, this makes it hard to use "short lived" cloud tools that lack persistent storage. Is my understanding correct, or am I missing something?
One solution for this could be to use smart_open, this should let the code work as normal for local storage, and then if you add for example gs:// or s3:// to the file path, it would understand that this is a reference to a cloud storage, and try to read the file from there.
One drawback would of course be the increased size of the docker image.

Yes, I do believe that should work for Google Cloud, and it is on my list of things to try (I should have included it in the original post, sorry).
The problem with that specific solution is that it would only work with Google Cloud. I have done something similar for Azure Blob Storage previously (using another tool), so I would assume a similar approach would work with the other cloud vendors as well.
I guess it comes down to where you want the complexity, in a docker file, or in the code :)
I can try the mentioned solution when I have some free time, and then update here afterwards.

I guess it comes down to where you want the complexity, in a docker file, or in the code :)

And who wants / has to maintain it.

I don't have any data to sync atm, but I have been able to run it as a Cloud Run job with mounting a bucket as filesystem (will try with data sometime this weekend or next week). For anyone interested, heres the dockerfile for an alpine based image:
FROM golang:alpine AS builder

RUN apk --update --no-cache add git fuse fuse-dev;
RUN go install github.com/googlecloudplatform/gcsfuse@master

FROM python:3.10-alpine

ENV MNT_DIR /mnt/tmp
ENV HOME /mnt/tmp
RUN mkdir -p /app

COPY --from=builder /go/bin/gcsfuse /usr/bin
COPY gcsfuse_run.sh /app/gcsfuse_run.sh
RUN chmod +x /app/gcsfuse_run.sh

RUN apk --update --no-cache add tini
RUN pip install withings-sync

ENTRYPOINT ["tini", "--"]

CMD ["/app/gcsfuse_run.sh"]

And the gcsfuse_run.sh script (think I only changed the final exec command at the bottom):
#!/bin/sh
# Copyright 2021 Google LLC
#
# Licensed under the Apache License, Version 2.0 (the "License");
# you may not use this file except in compliance with the License.
# You may obtain a copy of the License at
#
#    http://www.apache.org/licenses/LICENSE-2.0
#
# Unless required by applicable law or agreed to in writing, software
# distributed under the License is distributed on an "AS IS" BASIS,
# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
# See the License for the specific language governing permissions and
# limitations under the License.
# [START cloudrun_fuse_script]
set -eo pipefail

# Create mount directory for service
mkdir -p $MNT_DIR

echo "Mounting GCS Fuse."
gcsfuse --debug_gcs --debug_fuse $BUCKET $MNT_DIR
echo "Mounting completed."

# Run the web service on container startup. Here we use the gunicorn
# webserver, with one worker process and 8 threads.
# For environments with multiple CPU cores, increase the number of workers
# to be equal to the cores available.
# Timeout is set to 0 to disable the timeouts of the workers to allow Cloud Run to handle instance scaling.
exec withings-sync
# [END cloudrun_fuse_script]

@jrast I guess we can close this unless you want to keep it for documentation purposes?

Yea, seems like there is a working solution and this can be closed. Even if closed, the issue can still be referenced of someone comes up with questions in this direction.


USB Support?

WinFile already has support for USB-based drives.  What specific features are you wondering about?


Revert "commit 1"

Reverts dwarkesh0337/nextjs-blog-theme#1

👷 Deploy Preview for sweet-maamoul-8d0c3f processing.

Name
Link

🔨 Latest commit
3c08d01b2cde1739ed4223ebc02f362e15c829fc

🔍 Latest deploy log
https://app.netlify.com/sites/sweet-maamoul-8d0c3f/deploys/63844434ab63c900081fe41c


HTTPS connections are not working

Check why unirest is failing making HTTPS requests and fix it.

I will investigate this.


[irods/irods#7265] Minor reorganization + CMake TLC (4-3-stable)

In service of irods/irods#7265

#'d


Add a new script to autogenerate a YAML FASTT file for customization

Idea
@pabloarosado suggested that we write a script that will take a table, e.g. a feather file in garden, and autogenerate the matching YAML file that we use to customise FASTT. This would make it much faster to do the FASTT customisation step.

Marking this as "nice to have", but it's also something we could do very quickly (e.g. 1h).

Just noting that we now have CLI command  etl-metadata-export which generates YAML file from feather for customisation. Not sure if this is exactly what Pablo wanted, but it could always be improved.

Yes, exactly, I think that tool is already very useful (thanks Mojmir!). We can think of different ways in which we can improve it, but for now, I think we can close this issue.


Adds installs_on_pks flag to Get method of products.go

Thank you for contributing to the go-pivnet API library!

Have you made this pull request to the develop branch?
 Yes but integration tests are failing because the slug “pivnet-resource-test” no longer exists

@aaronmeza Please sign the Contributor License Agreement!
Click here to manually synchronize the status of this Pull Request.
See the FAQ for frequently asked questions.

@aaronmeza Thank you for signing the Contributor License Agreement!


Change to use pyomnisci instead of pymapd

There's new functionality in pyomnisci, so it would be good to use that instead of pymapd.
https://github.com/omnisci/pyomnisci
https://pypi.org/project/pyomnisci/

@mikehinchey I have a work in progress here: https://github.com/omnisci/ibis-omniscidb/pull/29/checks?check_run_id=1970318902
it seems that using pyomnisci from github master branch it is working. but from pypi it is not working. could we have a new release with the changes on master?

Hi @xmnlab we released v0.27.0 today. Please let me know if this resolves your issue. https://pypi.org/project/pyomnisci/0.27.0/

thanks @jclay ! I will move forward that PR. thank you so much!

It seems also it will need a new release for pyomniscidb as the current release is pinning rbc to 0.2.2
https://github.com/omnisci/omniscidb/blob/v5.5.2/python/setup.py
and this version is using pymapd:
/opt/hostedtoolcache/Python/3.7.10/x64/lib/python3.7/site-packages/rbc/omniscidb.py:8: in
from pymapd.cursor import make_row_results_set
E   ModuleNotFoundError: No module named 'pymapd'
any plans for a new release for pyomniscidb?


Bug #509 #526 Modal Issue Inside Datatable and Different Views Issue Inside Stacked Chart

Description:

Component/Datatable (Bug  #509 ) :
There was an issue inside the modal, when it was open the dropdown was getting overlap now the issue is resolved completely.

Component/Stacked Chart (Bug #526) :
Inside the Stacked Chart there was Issue regarding the views(Mobile, Tablet) For this also the issue is resolved and now the views are properly working.

Screenshots:

Components/Datatable :

Component/Stacked Chart:
            1. Mobile View:

               2. Reset View:

               3. Tablet View :

Checklist:

[x] My code follows the style guidelines of this project
[x] I have performed a self-review of my own code
[x] I have commented my code, particularly in hard-to-understand areas
[x] I have made corresponding changes to the documentation
[x] My changes generate no new warnings
[x] I have added tests that prove my fix is effective or that my feature works
[x] New and existing unit tests pass locally with my changes

Changes Reviewed and PR Approved


IPT admin UI improvement - allow download of source files from admin menu

I have inherited an IPT with many datasets, quite a few of which have xlsx spreadsheet data sources. Those spreadsheets are only available through the IPT, and it's a bit of a pain not to have an easy way of downloading them. I imagine this is a fairly common scenario for others too.
I can understand that the source files might potentially contain sensitive data which isn't published. So it doesn't make sense to have a link to the source files on the dataset page where you can download the DwCA etc, but wouldn't it make sense to have a download button from the admin interface (e.g. on http://localhost:8080/manage/source.do?r=test&id=test)?

Looks like it's related to #1008

Hi @ rukayaj, thank you for the suggestion. At this time, there is no active development on the IPT, but we will keep your suggestion in mind when this picks up again.

Implemented in https://github.com/gbif/ipt/pull/1537

Hello @rukayaj ,
I'm sorry (and a bit shameful) I didn't see you also did the implementation, not just created the issue!
I totally write the same feature on my side without noticing your PR....
The good news: it has been merged and should be available in the next release.
Regards,
Sylvain
GBIF France


cannot extract Chinese comma symbol

I'm using textract and it's awesome! I can easily extract content from any of my .doc or .docx files.
 Hoping to be taking a good look at all the various issues/PRs this time next week.

@lcc19941214 Not an issue anymore?
The last time I spent time working textract stuff I was working this. Didn't check anything in but believe I was close to resolving this.

FWIW, the fix for this was just published as textract 2.1, thanks!


Code Examples please

There is a lack of code examples across most of the EF documentation that is posted.
[Enter feedback here]

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 22833d32-1979-01e4-f839-b74a96dbbf74
Version Independent ID: ab56412a-464e-d13f-62b5-4831e9a61349
Content: IndexAttribute.IsUnique Property (System.ComponentModel.DataAnnotations.Schema)
Content Source: EF/xml/System.ComponentModel.DataAnnotations.Schema/IndexAttribute.xml
Product: entity-framework
Technology: entity-framework-6
GitHub Login: @dotnet-bot
Microsoft Alias: avickers

@Devlynn the documentation for EF6 is no longer being actively maintained. For EF Core, most of the code samples are in our conceptual documentation, with the API documentation usually linking to the relevant page.


how to reproduce the results on hpatches dataset

Hi,  thanks for your great work.
I want to reproduce the results on hpatches dataset. I use this tool box.
Could you tell me the hyperparameters of LoFTR on hpatches dataset, such as ransac thr?

Hi, for each pair, we use num_matches≤1024, θc=0.1, ransac_thr=3. Other settings are described as in the paper.

The toolbox you're using is using pydegensac, which is not the same as opencv:
https://github.com/GrumpyZhou/image-matching-toolbox/blob/83e55bf5ad6a950534aa3c9a89fcbb89a9c7ece8/immatch/utils/hpatches_helper.py#L172


fixes #3333 uses ample to get table splits

Would this benefit 2.1?

Would this benefit 2.1?

There are some benefits in edge cases.  My only concern w/ landing it in 2.x is causing new bugs.  We could just change the code in to 2.x to log at debug and get a lot of the benefit of this PR.

I have tried running the script that provoked the bug on this branch and I do not see the exceptions occurring

After running the script (outlined in #3333) I no longer see the exceptions and instead see these logs (after enabling debug logging):
2023-04-25T12:04:57,128 [schema.LinkingIterator] DEBUG: Tablets end row and prev end row not equals s;1674;1337 s;235;2011
2023-04-25T12:04:57,382 [schema.LinkingIterator] DEBUG: Resetting scanner to [s;1674%00; : []<PHONE_NUMBER>854775807 false,s<%00; : []<PHONE_NUMBER>854775807 false)


Unable to install via composer

I can't install the repo when I try to install our library fufulabs/fitbit
Here's my composer.json in fufulabs/fitbit
{
    "name": "fufulabs/fitbit",
    "version": "0.6",
    "type": "library",
    "description": "Fitbit library with OAuth.",
    "keywords": ["fitbit"],
    "homepage": "https://github.com/fufulabs/fitbitphp",
    "license" : "Apache-2.0",
    "authors": [
        {
            "name": "Ryan Martinsen",
            "email"<EMAIL_ADDRESS>            "homepage": "http://ryanmartinsen.com"
        },
        {
            "name": "Eli White",
            "homepage": "http://eli-white.com"
        }
    ],
    "require": {
        "php": ">=5.3.0",
        "and/oauth": "0.7.*@dev"
    },
    "autoload": {
        "psr-0": {
            "Fitbit": "lib/"
        }
    }
}

The error when I try to install fufulabs/fitbit via composer to a different project:
Problem 1
    - fufulabs/fitbit dev-master requires and/oauth 0.7.*@dev -> no matching package found.
    - fufulabs/fitbit dev-master requires and/oauth 0.7.*@dev -> no matching package found.

Debugging it in the fufulabs/fitbit project, I can successfully install and/oauth but in a different project utilizing fufulabs/fitbit library requiring and/oauth, the and/oauth won't install
Any thoughts?

Update:
I tried adding  "minimum-stability": "beta" in my composer.json in fufulabs/fitbit but project A still won't install fufulabs/fitbit due to and/oauth not being found.

Update: I am now able to install the repo but I used the stable version.

I will mark main branch as stable soon. Thank you for reminder.


feat: add data-plane-instance heartbeat

What this PR changes/adds
Adds a DataPlaneSelectorManager that takes care of checking the dataplanes availability.
Why it does that
Avoid failing transfers for unavabilable data planes.
Further notes

note that data-plane-self-registration still "deletes" itself instead of "unregistering". It will fixed in a subsequent pr

Linked Issue(s)
Closes #4220
Please be sure to take a look at the contributing guidelines and our etiquette for pull requests.

Codecov Report
Attention: Patch coverage is 37.55656% with 138 lines in your changes are missing coverage. Please review.

Project coverage is 67.09%. Comparing base (7f20ba5) to head (ae4baf2).
Report is 286 commits behind head on main.

Files
Patch %
Lines

.../selector/store/sql/SqlDataPlaneInstanceStore.java
10.00%
36 Missing :warning:

...tor/dataplane/client/DataPlaneSignalingClient.java
0.00%
22 Missing :warning:

...dataplane/selector/DataPlaneSelectorExtension.java
0.00%
20 Missing :warning:

...sql/schema/BaseSqlDataPlaneInstanceStatements.java
0.00%
17 Missing :warning:

...selector/spi/instance/DataPlaneInstanceStates.java
0.00%
10 Missing :warning:

...tor/store/sql/schema/DataPlaneInstanceMapping.java
0.00%
9 Missing :warning:

...plane/selector/spi/instance/DataPlaneInstance.java
79.41%
7 Missing :warning:

...ane/selector/spi/store/DataPlaneInstanceStore.java
0.00%
4 Missing :warning:

...selector/manager/DataPlaneSelectorManagerImpl.java
90.62%
3 Missing :warning:

.../postgres/PostgresDataPlaneInstanceStatements.java
0.00%
2 Missing :warning:

... and 8 more

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4230      +/-   ##
==========================================
- Coverage   71.74%   67.09%   -4.65%
==========================================
  Files         919     1044     +125
  Lines       18457    20785    +2328
  Branches     1037     1157     +120
==========================================
+ Hits        13242    13946     +704
- Misses       4756     6362    +1606
- Partials      459      477      +18

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


The first is just a warning to inform you that pdfjs will use the fake worker. The second warning is displayed during feature detection. Both does not indicate any sort of error.
I am working on a better integration of pdfjs web worker.
BTW, what is the browser ? are you using webpack ?

Webpack yes, and the warning about fake worker occur at least on Chrome and Firefox.
Is it possible to get rid of the warning?

Please update to the latest version. The warning should disappear.

Thank you!

Actually, still this warning remains at least on chrome.
pdf.worker.js:24096The provided value 'moz-chunked-arraybuffer' is not a valid enum value of type XMLHttpRequestResponseType.
Is it possible to remove this also?

Sorry, this warning cannot be removed without changing the pdf.js source code.


prometheus: fix build

Motivation for this change

Prometheus was failing due to the http-client version (0.6.4) being
out-of-bounds (prometheus requires >=0.4 && <0.6).

Things done

Jailbroke it.

[x] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
Built on platform(s)

[x] NixOS
[ ] macOS
[ ] other Linux distributions

[x] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[x] Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
[x] Tested execution of all binary files (usually in ./result/bin/)
[ ] Determined the impact on package closure size (by running nix path-info -S before and after)
[ ] Ensured that relevant documentation is up to date
[x] Fits CONTRIBUTING.md.

Notify maintainers
cc @peti @basvandijk @ElvishJerricco @vaibhavsagar

@peti Definitely! I see how that's helpful.
Done.


[RFC] bundling + tooling

[x] Drop Rollup and just use Babel for transpilation, no need to bundle the library
[ ] Use file extensions in imports statements, so it is valid ESM and module resolution would work without bundling in the browser (i.e. someone could use unpkg.com urls and <script type="module"> instead of webpack). You can change the import lint rule to enforce this
[x] Use webpack to bundle E2E tests

@rtsao can you help how I should change the import rule lint to enforce this?

IIRC there’s a way to enforce that relative imports have file extensions.
I think I tried this out but it didn’t support auto-fixing, so we’ll probably want to codemod the changes.

is enforcing file extensions still a priority? this eslint rule seems to do what we want. i could take care of the codemod fairly quick

That would be great @chasestarr !


Encourage the use of secondary wikidata tags

https://wiki.openstreetmap.org/wiki/Key:wikidata#Secondary_Wikidata_links
Such tags should include:

[ ] operator:wikidata=* #769
[ ] network:wikidata=* #770
[ ] brand:wikidata=* #552 #768
[ ] architect:wikidata=* #771
[ ] artist:wikidata=* #772
[x] subject:wikidata=* #533
[ ] name:etymology:wikidata=*
[x] flag:wikidata=* #218
[ ] buried:wikidata=*

Such tags should include:

operator:wikidata=*
network:wikidata=*
brand:wikidata=*
architect:wikidata=*
artist:wikidata=*
subject:wikidata=*
name:etymology:wikidata=*
flag:wikidata=*
burried:wikidata=*

#533 is for subject:wikidata

@tyrasd you mismatched the list entries and the links to the corresponding PRs / issues.

oh, it's fixed now. thanks for the hint :blush:

architect:wikidata and artist:wikidata are quite dubious, as are typically unverifiable by survey and only importable from third-party sources.

architect:wikidata and artist:wikidata are quite dubious, as are typically unverifiable by survey and only importable from third-party sources.

It depends. Most of the public art in my city is signed by the artist or has a small plaque with the artist’s name on it.

Yes, some of them have. But vast majority - do not.

I think that’s an unreasonable standard for including a field in a preset, especially if it ends up being hidden by default. The photos I posted above are by no means exceptional. If a public sculpture doesn’t have a visible indication of its creator, it’s fine to avoid selecting the field from the dropdown menu.
In any case, the concern you’re raising is broader than this issue, since the Artwork preset already has an Artist field and the Building preset already has an Architect field. As long as those fields exist, their associated Wikidata fields shouldn’t be subject to additional scrutiny about verifiability.

if it ends up being hidden by default

In such case it would be fine, I guess

model:wikidata


add intl extension to php images

This PR adds the intl extension to the php8-based images (php7.4 is shortly to end support)
Closes #628

confirmed present in images:
~/sites/lagoon-images  $ docker run --rm -it testlagoon/php-8.0-cli:pr-629 php -m | grep intl
intl
~/sites/lagoon-images  $ docker run --rm -it testlagoon/php-8.1-fpm:pr-629 php -m | grep intl
intl


djv 2.0.8 doesn't open

windows 10 version 20H2
build: 19042.985
AMD Ryzen Threadripper 2920X
Logs have no error that I can see.
Application runs, but does not display a window, even after minutes of waiting.
version 1.3 of DJV_view.exe works fine.
djv.log

Installed 2.0.7. Doesn't open either.
Installed 2.0.6 Bingo! It works fine.

I have three GTX 1080i cards in this system, which probably makes it an odd build.
Ok, so this may be frustrating, but as you can see I've installed 2.0.6, and things are working fine.
I went back and installed 2.0.8 without uninstalling 2.0.6, and 2.0.8 seems to work fine now.
I just uninstalled all versions:
Then installed 2.0.8 and it works fine.
Something must have happened when installing 2.0.6 that fixed the installation of 2.0.8?
The original djv.log file is from the first installation of 2.0.8 where the window never opened, it just made that log.
As I said, there are no errors in that log, but the GUI never drew, and you can see it exit without opening anything.
Sorry I can't be more help.

This is the current log file... but of course, everything is working fine.
djv.log

Thanks, I'm glad it's working now, though I'm not sure what caused the issue. The preferences should be specific to each version so I don't think that was it. If it happens again let me know, otherwise I'll close this issue.


Migrate "modes" into ES6 modules for #3118

This one seems straightforward ... feedback is most welcome.

👍 awesome! To get this working with index.html, it'll need a few more changes to index.html in order to properly pull in the combined modes.js file and avoid including the deleted modes individual files: https://gist.github.com/tmcw/d88da26c8f9dd520110e416216d60141

There were some messy merge conflicts so I resolved them and merged.. Thanks @davidchouse!

Thanks for the cleanup @bhousel!


Implement proxy

Virtcontainers reached a point where it needs to rely on the hyperstart proxy if we want to go further. This PR solves issue #85 by implementing two proxy interfaces, a raw hyperstart intended to communicate directly  with hyperstart, and a real proxy responsible to do the abstraction layer with the VM.

@sameo @dlespiau please take a look at this PR, this is the first step in getting the proxy for virtcontainers.

adding proxy is also a job in runv
see the 5th item in https://github.com/hyperhq/runv/issues/415


npm WARN errors when running install

When you run the npm install command, you get three warnings:
npm WARN vendor No description
npm WARN vendor No repository field.
npm WARN vendor No license field.
These are just warnings, not errors, and they're just helpful things to have in package.json
You can find the npm documentation on the formatting for package.json here: https://docs.npmjs.com/files/package.json
I can add these things to the file if you don't mind me doing it, haha.

Discovered this could be suppressed with private:true in package.json, going to file a PR with this change


Update changelog for #1582

Updating changelog for #1582 so we can make a new minor release for the type fixes.

This change is

We also need to update version links at the end of the changelog file.

Another good catch. Done.


It is a great job. And will you release the training scripts and files?

Tuning scripts are going through a process. We will release it as soon as possible.

@xuhzyy We have released the training scripts.


Support browserify 11

Right now the dependency specifies ^10.0.0. If it will work with v11, just update the package.json file and republish.

fixed in<EMAIL_ADDRESS>


"random" training time for every 500 iterations

Hi, I met this problem recently.
I modified the faster rcnn architecture, and there should be no obvious bugs since the resultant mAP is not a wired value.
However, I noticed from the log that the training time for every 500 samples were very different, sometimes it was around 0.6, whereas sometimes it approached 1.8 !
I quickly recall my previous log, and found 0.6 should be the right one.
I was trying to solve this problem, and found that every time the training time was high, there would be an extra running process (see the figure below, with PID = 18312, I used "nvidia-smi" to check). And when I used "nvidia-smi" command again, this extra process suddenly disappeared, and the training time become normal again( = 0.6)
Could anyone suggest any reasons for this issue!
Thanks a lot !

This phenomenon can be caused by a lot of reasons. Please follow the issue template to provide more details.

Sorry I thought it is less related to the code, and thought it might be a general question. I will close this and use the template to post a new one!


cni: revisioned install-cni & istio-cni binaries

Enables multiple install-cni daemonsets and istio-cni plugins to be installed & run on each node

Appends the Istio revision to the install-cni daemonset, istio-cni binaries, and cni config

Each plugin instance checks the revision of the pod it is being invoked against and skips setting up the redirect if the revision does not match its own

[ ] Ambient

[ ] Configuration Infrastructure

[ ] Docs

[ ] Dual Stack

[ ] Installation

[x] Networking

[ ] Performance and Scalability

[ ] Policies and Telemetry

[ ] Security

[ ] Test and Release

[ ] User Experience

[ ] Developer Infrastructure

@eoinfennessy: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

release-notes_istio
56e4bc5d70f7728ee8ea34cd5a41757b385b2c68
link
true
/test release-notes

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@bleggett, thanks for the info regarding ambient compatibility and work on #48253. It makes sense to wait until that gets merged before doing any further work on this implementation. In the meantime, I'll prepare a doc to share & discuss with the Istio community outlining requirements, motivations, and use cases.
In short, this work aims to help support canary-based upgrades without requiring node cordoning/node pools, and may have use cases in soft multi-tenancy environments where tenants require independent upgrades to Istio and CNI.
If my understanding is correct, after #48253 merges, ambient mode will no longer configure iptables rules on the host netns. Perhaps this could help to make revision support for CNI possible in ambient mode? Having said that, the possibility of scoping this work to non-ambient use cases only could also be considered.

@howardjohn, the basic use case is for supporting canary rollouts where there may have been changes to the cni layer. It's hard for me to see how cordoning off nodes would help, as user applications would also need to be cordoned to the same nodes running the updated cni. Maybe I'm missing something?

Yes, that is exactly how it would work.
Do we really have users that want to run multiple daemonsets on every single node for every revision? Soon we will fill up the whole node just to cp a binary onto the host...
What changes are they worried about in CNI? Is it theoretical issues or legitimate ones? CNI has been incredibly stable with minimal changes for years

It's certainly theoretical, but I don't know the risk in practice, nor the impact should changes need to be made.  I suppose, if changes are required, then you could force something like this to go along with those changes at that time.
The daemon sets should be removed once the older version of the control plane is torn down, so I don't think you'll have a bunch of istio-cni revs running forever.  That would just be rude :)

To add some background, the new operator we are working on will support automation of canary rollouts of the control plane (creating a new control plane and deleting the old control plane after it is no longer managing any proxies, with a following grace period; users will still need to manually migrate their namespaces and applications to the new control plane).  As part of this work, we are going through and addressing issues we are finding in the existing revisioning.  CNI is one of those components that currently does not support revisioning, hence this PR.  HTH.

To add some background, the new operator we are working on will support automation of canary rollouts of the control plane (creating a new control plane and deleting the old control plane after it is no longer managing any proxies, with a following grace period; users will still need to manually migrate their namespaces and applications to the new control plane). As part of this work, we are going through and addressing issues we are finding in the existing revisioning. CNI is one of those components that currently does not support revisioning, hence this PR. HTH.

With sidecars (no ambient), do you have users requiring revisions of istio-cni?  We don't see any users asking for it.  In place upgrade for istio-cni seems working well for our users.

@linsun , in the past we have had to fix bugs in cni well after ..0 releases (as we tend to lag on the product side).  This leads me to believe that cni is not used broadly across the community, or users of cni also lag, or they patch them independently.
Regarding in-place upgrades, we are getting more and more requests to support canary rollouts.  Being able to support that through an operator makes the process of managing them much simpler.
  It doesn't do any good to add support after you need it.
I'd also like to hear why people think this is a risky change.  To me, this shouldn't be very controversial.  It's adding support that should have been there when revisions were first introduced.  I'd say it's riskier to not have it and we've been lucky up to this point.

@linsun , in the past we have had to fix bugs in cni well after ..0 releases (as we tend to lag on the product side). This leads me to believe that cni is not used broadly across the community, or users of cni also lag, or they patch them independently.

FWIW our product (more or less) mandates CNI usage

Lastly, as revisions are a supported feature, I believe that ensuring that they are properly implemented across the project should be a priority. It doesn't do any good to add support after you need it.

It is correctly implemented per the projects (current) view of "correct". Lack of revisions in CNI is not an oversight but an intentional design decision. CNI is quite different from Istiod and the same principals that apply to Istio do not necessarily apply to CNI

@howardjohn , is that documented somewhere, e.g. in an RFC?  I recall having many conversations in the environments working group about how global resources should be handled with revisions (e.g. What do we do if we add/remove permissions from a ClusterRole?), and the feature was really rolled out over several releases as these types of problems were encountered and resolved.
As far as CNI goes, any changes to ports, etc., on the proxy will necessitate a change to CNI, and this has happened in the past.  If we want to restrict those types of changes and mark those settings as API, then...

Regarding in-place upgrades, we are getting more and more requests to support canary rollouts. Being able to support that through an operator makes the process of managing them much simpler.

Yep, and I share your desire to support canary rollouts. Canary rollouts exist to prevent disruption to existing user workloads during an upgrade. The goal with ambient at least, and the recent inpod work, is to disconnect the CNI agent (and thus plugin) entirely from the datapath of existing user workloads, so that the CNI agent can be upgraded in-place without disruption to existing workloads. It is already disconnected from the control plane.
In general I prefer revisions as a way to manage canary deployments of Istio and give users explicit blast radius control, but revisions are for blast radius control existing workload traffic. Which means things like the control plane and the data plane, arguably - but not the CNI, if we are doing things correctly.

As far as CNI goes, any changes to ports, etc., on the proxy will necessitate a change to CNI, and this has happened in the past. If we want to restrict those types of changes and mark those settings as API, then...

https://istio.io/latest/docs/setup/additional-setup/cni/#upgrade
Here we say

The CNI plugin at version 1.x is compatible with control plane at version 1.x-1, 1.x, and 1.x+1, which means CNI and control plane can be upgraded in any order, as long as their version difference is within one minor version.

IMO that should read "The CNI agent" but either way that's the current standard for the CNI-CP skew we sign up to support.

Closing. After discussions regarding the Sail operator & CNI at yesterday's WG meeting, Red Hat have decided that a global CNI config will be offered instead of this revision-based approach.

Thank you @eoinfennessy for your understanding - pls keep us posted on how this goes.

Also opened https://github.com/istio/istio/issues/49009 to track this more broadly


KFP/Airflow generic component operators should handle dependency download errors gracefully

Whenever the generic component operator is unable to download the prerequisites, e.g. in https://github.com/elyra-ai/elyra/blob/master/elyra/kfp/operator.py#L178-L179, no error is returned by curl, resulting in downstream errors, such as the one we've encountered and fixed in https://github.com/elyra-ai/elyra/pull/2623

Potential solution: add https://curl.se/docs/manpage.html#--fail-with-body, which should abort processing when a dependency cannot be downloaded.


Perform a full regression test of ibm.com Library - Carbon upgrade to 10.11.0

User Story

As a  [user role below]:
ibm.com Library adopter

I need to:
ensure the stability of the ibm.com Library after the Carbon 10.11.0 upgrade

so that I can:
safely use the latest version of Carbon in my ibm.com application.

Additional information

Background is contained in issue (#1876)
The Carbon upgrade must not adversely affect functioning of the components used by the adopters
Browser Stack link
Browser Standard
Browser versions to be tested:  Tier 1 browsers will be tested with defects created as Sev 1 or Sev 2.  Tier 2 browser defects will be created as Sev 3 defects.
Platforms to be tested, by priority:  1)  Desktop  2)  Mobile  3)  Tablet
Mobile & Tablet iOS versions: 13.1 and 13.3
Mobile & Tablet Android versions: 9.0 Pie and 8.1 Oreo
Browsers to be tested:  Desktop: Chrome, Firefox, Safari, Edge, Mobile: Chrome, Safari, Samsung Internet, UC Browser, Tablet: Safari, Chrome, Android
Accessibility Checklist
Creating a QA bug
Refer to pull request for the deploy preview links Issue (#1950) - Use the Package React and not Experimental environments
Our goal is to complete this testing by the end of this week.  The bugs created will be reviewed and prioritized to decide whether the fixes will be included in the April release.
When creating any bugs from this testing, link them to epic (#1876)

Acceptance criteria

[ ] Accessibility testing is complete.  Pattern is compliant.
[ ] All browser versions are tested
[ ] All operating systems are tested
[ ] All devices are tested
[ ] Defects are recorded and retested when fixed

Testing of the patterns was finished on Thursday April 9.  Masthead and Footer testing is still needed.  Their testing issues are needed and should be finished by the EOD 4/10.


App crashes right when navigation starts

I noticed that sometimes the app will crash right when the navigation is started, maybe like every 1 in 5 times. Not sure why, but here is the log:
flutter: 37.469336123127631, -121.91077421576946
MapboxNavigation.NavigationMapView WARNING UIViewController.automaticallyAdjustsScrollViewInsets is deprecated use MGLMapView.automaticallyAdjustContentInset instead.
<nav-native> No tile endpoint config specified! Using tileDir directly!
<nav-native> Tiles path = ""
<nav-native> Creating navigator v.32.0.0
[delegation.RouteMapViewController] Unimplemented delegate method in RouteMapViewController: NavigationServiceDelegate.navigationService(_:shouldDiscard:). This message will only be logged once.
[delegation.RouteMapViewController] Unimplemented delegate method in RouteMapViewController: NavigationServiceDelegate.navigationService(_:shouldPreventReroutesWhenArrivingAt:). This message will only be logged once.
[delegation.TopBannerViewController] Unimplemented delegate method in TopBannerViewController: NavigationServiceDelegate.navigationService(_:shouldPreventReroutesWhenArrivingAt:). This message will only be logged once.
[delegation.BottomBannerViewController] Unimplemented delegate method in BottomBannerViewController: NavigationServiceDelegate.navigationService(_:shouldPreventReroutesWhenArrivingAt:). This message will only be logged once.
[delegation.FlutterMapboxNavigationView] Unimplemented delegate method in FlutterMapboxNavigationView: NavigationViewControllerDelegate.navigationViewController(_:roadNameAt:). This message will only be logged once.
[delegation.TopBannerViewController] Unimplemented delegate method in TopBannerViewController: NavigationServiceDelegate.navigationService(_:didPassSpokenInstructionPoint:routeProgress:). This message will only be logged once.
[delegation.BottomBannerViewController] Unimplemented delegate method in BottomBannerViewController: NavigationServiceDelegate.navigationService(_:didPassSpokenInstructionPoint:routeProgress:). This message will only be logged once.
[delegation.RouteMapViewController] Unimplemented delegate method in RouteMapViewController: NavigationServiceDelegate.navigationService(_:didPassVisualInstructionPoint:routeProgress:). This message will only be logged once.
[delegation.BottomBannerViewController] Unimplemented delegate method in BottomBannerViewController: NavigationServiceDelegate.navigationService(_:didPassVisualInstructionPoint:routeProgress:). This message will only be logged once.
[delegation.FlutterMapboxNavigationView] Unimplemented delegate method in FlutterMapboxNavigationView: NavigationViewControllerDelegate.navigationViewController(_:shapeFor:). This message will only be logged once.
[delegation.FlutterMapboxNavigationView] Unimplemented delegate method in FlutterMapboxNavigationView: NavigationViewControllerDelegate.navigationViewController(_:mainRouteStyleLayerWithIdentifier:source:). This message will only be logged once.
[delegation.FlutterMapboxNavigationView] Unimplemented delegate method in FlutterMapboxNavigationView: NavigationViewControllerDelegate.navigationViewController(_:simplifiedShapeFor:). This message will only be logged once.
[delegation.FlutterMapboxNavigationView] Unimplemented delegate method in FlutterMapboxNavigationView: NavigationViewControllerDelegate.navigationViewController(_:mainRouteCasingStyleLayerWithIdentifier:source:). This message will only be logged once.
[delegation.FlutterMapboxNavigationView] Unimplemented delegate method in FlutterMapboxNavigationView: NavigationViewControllerDelegate.navigationViewController(_:shapeFor:legIndex:). This message will only be logged once.
MGLShapeCollection initialized with MGLFeatures will not retain attributes.Use MGLShapeCollectionFeature to retain attributes instead.This will be logged only once.
[connection] nw_endpoint_handler_set_adaptive_read_handler [C110.1 <IP_ADDRESS>:443 ready channel-flow (satisfied (Path is satisfied), viable, interface: en0, ipv4, dns)] unregister notification for read_timeout failed
[connection] nw_endpoint_handler_set_adaptive_write_handler [C110.1 <IP_ADDRESS>:443 ready channel-flow (satisfied (Path is satisfied), viable, interface: en0, ipv4, dns)] unregister notification for write_timeout failed
* thread #1, queue = 'com.apple.main-thread', stop reason = EXC_BAD_ACCESS (code=1, address=0x4)
    frame #0: 0x00000001dea2cd80 GLEngine`gleRunVertexSubmitARM + 2696
GLEngine`gleRunVertexSubmitARM:
->  0x1dea2cd80 <+2696>: ldr    w8, [x8, w16, uxtw]
    0x1dea2cd84 <+2700>: str    w8, [x12], #0x4
    0x1dea2cd88 <+2704>: add    x8, x15, #0x20            ; =0x20
    0x1dea2cd8c <+2708>: add    x15, x15, #0x18           ; =0x18
Target 0: (Runner) stopped.
Lost connection to device.

Stale issue message


feat: refactor codebase and cleanup

Description

Refactor code base and cleanup.
Add poetry as package management to leverage locking deps.
Add some CI check (commit-lint and merge conflicts)
CI lint and format using (ruff)
Add mypy
Add safety for deps vulnerability checks.
Add bandit for code vulnerability check.
Update Dockerfile (Image size increased by 24mb, 150 -> 174)

fixes - #152 #153 #154 #155

@uniqueg as discussed, naming src/tesk_core to tesk/service would make sense, but wouldn't that steer away from  naming convention followed for released of modules, or will we keep the same name for the docker images (tesk-core) and just change the name in the code base (service)?

everything seems to work post python version 3.11, I'll shift make name change, ie src->tesk at least, rest need to be discussed.

Also, why are Python 3.8, 3.9 and 3.10 failing, @JaeAeich?
On the other hand, it's not clear to me why we are even testing multiple Python versions, TESK is not a library. We pick one version and use that version, no need to support multiple Python versions...

Also, why are Python 3.8, 3.9 and 3.10 failing, @JaeAeich?
On the other hand, it's not clear to me why we are even testing multiple Python versions, TESK is not a library. We pick one version and use that version, no need to support multiple Python versions...

I have no idea, lack of backwards compatibility ig, I haven't touched any code of tesk_core yet. Should I free python version to 3.11 and above (for pyproject.toml)? Will remove the other versions from API.
Also core seems to use kubernetes client v9 and rn its on v29 :face_in_clouds: , I'll definetely have to refactor core code as well in order to start to use same k8s client version on api.

IG, changing the name of github actions workflow (to comply with other file name and repos) tripped it and its not showing tests, but all the tests passed. You can check it as well and I have simulated in on a clean ubuntu docker image just to be sure :)

IG, changing the name of github actions workflow (to comply with other file name and repos) tripped it and its not showing tests, but all the tests passed. You can check it as well and I have simulated in on a clean ubuntu docker image just to be sure :)

I think you need to update the test names in the branch protection rules. If you don't have the permissions (which I think you do) I'll do it when reviewing tomorrow.

which I think you do

I don't have 'em! I don;t see branch protections rules in settings :cry: .

Hey there are some TODOs that I'll take care in this PR itself, please ignore those and review the rest :)

Hey there are some TODOs that I'll take care in this PR itself, please ignore those and review the rest :)

They're here: https://github.com/elixir-cloud-aai/TESK/settings/branches
You need to edit the rule for branch main, then under "Require status checks to pass before merging" you need to use the search box to add the checks by name, e.g., "code-vulnerabilities" or "Semantic PR title".
Anyway, I have done that now in case you don't have access to that setting.

Yeah I don't have the rights, but thanks for updating it :)

We need codecov token, and helm CI is not running, we need to test that as well, I have broken that into multiple jobs to comply with a "consistency".
Apart from that since this PR has grown big enough why not discuss some extra things I found while studying other repos and etc etc.

Consider adding DCO check in CI.
Consider adding OSS licence compliance that shows that well what is say :), we can add its card to the readme as well with codecov, coverage.

We need codecov token, and helm CI is not running, we need to test that as well, I have broken that into multiple jobs to comply with a "consistency".
Apart from that since this PR has grown big enough why not discuss some extra things I found while going through other repos and etc etc.

Consider adding DCO check in CI.
Consider adding OSS licence compliance (license scan seems to be free 🤞 ) that shows, well what is says :), we can add its card to the readme as well with codecov, coverage.

Sure, feel free to add (low priority) issues for these :)

We need codecov token, and helm CI is not running, we need to test that as well, I have broken that into multiple jobs to comply with a "consistency".
Apart from that since this PR has grown big enough why not discuss some extra things I found while going through other repos and etc etc.

Consider adding DCO check in CI.
Consider adding OSS licence compliance (license scan seems to be free 🤞 ) that shows, well what is says :), we can add its card to the readme as well with codecov, coverage.

CODECOV_TOKEN is now set for this repo. Not sure what you need for the Helm CI, but I think we should merge this ASAP before it gets even more unwieldy. I propose that you remove the part that installs the chart for now (we can get it back from master later on), which is likely the one that fails at the moment? Or even remove the entire workflow.

We're getting there, just a few small issues before we can merge.
However, sth is weird about your Git workflow. Several (but not all) files are shown here as completely new, even though there were just moved or a few lines were changed (e.g., pyproject.toml, some but not all test files moved from service to test_service). Try to figure out why that is and avoid it in the future, because it makes things hell to review and also you git blame will show you as the author of all of that code, even if you are not.

I don't think there is anything wrong with my workflow, the issue was that the code files were not formatted at all and had inconsistent spacing even between two words :sweat_smile: , plus fixing some minor issues to comply with Google's python coding guide like changing string concatenation to f string, these kind of small fixes were cluttered all around the code base. I believe that is the cause of this weird blame thing. But if it happens again I'll be sure to check into it :)

@uniqueg can you please give me codecov badge from here (supposedly :crossed_fingers: ).


Fixing kai_enabled=false

When creating a new workspace with kai_enabled = false we receive the following error:
If we create it with kai_enabled = true or kai_enabled = null it works.
╷
│ Error: Provider produced inconsistent result after apply
│
│ When applying changes to module.singlestoredb_workspace["ui"].singlestoredb_workspace.this, provider "provider["
Tested manually all the cases:

not indicating the field (null)
false
true

And all created workspaces without issues, unlike before.
https://memsql.atlassian.net/browse/ECS-1750
https://memsql.slack.com/archives/C04Q32QQBT6/p1734595727129479

https://github.com/singlestore-labs/terraform-provider-singlestoredb/actions/runs/12418344303


feat: add update_balance to vm::testing::Contract

Description
Add update_balance to vm::testing::Contract.
It will be used by cosmwasm-simulator.
Types of changes

[ ] Bug fix (changes which fixes an issue)
[x] New feature (changes which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[ ] ETC (build, ci, docs, perf, refactor, style, test)

Checklist

[x] I followed the contributing guidelines.
[x] I have updated the documentation accordingly.
[x] I have added tests to cover my changes.
[x] The PR title and commits are followed conventional commit form.

I close this because #181 makes this change out of the scope of Contract.


Replace interaction engine

I've replaced the interaction engine and updated the demo interaction to run with the new engine.


Remove DocumentParser.parse & FieldMapper.parse

After the TranslogIndexer introduction (https://github.com/crate/crate/pull/16007)
and several other cleanups in the MapperService area
DocumentParser.parse was only used to create the tombstone docs.
Given that they have no source, they can easily be created directly -
which allows us to get rid of all the remaining Document/FieldMapper
parse infrastructure.
Everything now goes through the ValueIndexer mechanisms.

can we also remove ParseContext class?

Good point. Yes that was possible. I removed it.

a nitpicking on commit message - the whole DocumentParser is removed, not only DocumentParser.parse

I had mixed up DocumentMapper/DocumentParser. Should be good now.


unindent code in services-networking/connect-applications-service.md

services-networking/connect-applications-service.md , so ti can run as hoped

see
86182@LAPTOP-QMUNSEPQ MINGW64 /d/opensource/website (master)
$ ./scripts/lsync.sh    content/zh/docs/concepts/services-networking/connect-applications-service.md
content/zh/docs/concepts/services-networking/connect-applications-service.md is still in sync

/approve

/approve cancel

CLA signed

Reapproving since CLA check is passing.
/lgtm
/approve