Fix sysctl -a line parsing for FreeBSD

Hello,
I ran in to a problem while using this nice module on FreeBSD.
Error: /Stage[main]/MyModule::Config/Sysctl[security.bsd.see_other_uids]: Could not evaluate: Error: security.bsd.see_other_uids is not a valid sysctl key
Error: /Stage[main]/MyModule::Config/Sysctl[security.bsd.see_other_gids]: Could not evaluate: Error: security.bsd.see_other_gids is not a valid sysctl key
These are valid keys for FreeBSD, so it shouldn't be giving the error. I tracked it down to https://github.com/hercules-team/augeasproviders_sysctl/blob/master/lib/puppet/provider/sysctl/augeas.rb#L81
value = line.split('=')
It's splitting each line of output from sysctl -a, looking for the equals sign, so it can extract the key and the value. The problem is that the output from Linux has an equals sign seperator, while the output from BSD has a colon ":" seperator. Since it can't match the key with the colon seperator it throws the error.
I fixed it by changing L81 to a RegExp value = line.split(/(=|:)/) that matches on either an equals sign, or a colon.
Thanks

Coverage remained the same at 88.304% when pulling 2418cee437a7eecb58e5c4b5ade077dacfadc2af on mikej-hc:master into 012cd99bb6f1fdf210a2bc1c3f153138643dfb48 on hercules-team:master.

I see what you're doing, but it's not strictly equivalent. Iirc, there were cases when values contained =. Let's consider a line with the content:  a.b.c = 3=4.
Old code:
irb(main):001:0> "a.b.c = 3=4"
=> "a.b.c = 3=4"
irb(main):002:0> line="a.b.c = 3=4"
=> "a.b.c = 3=4"
irb(main):003:0> value = line.split('=')
=> ["a.b.c ", " 3", "4"]
irb(main):004:0> key = value.shift.strip
=> "a.b.c"
irb(main):005:0> value = value.join('=').strip
=> "3=4"

Your code
irb(main):016:0> line="a.b.c = 3=4"
=> "a.b.c = 3=4"
irb(main):017:0> value = line.split(/(=|:)/)
=> ["a.b.c ", "=", " 3", "=", "4"]
irb(main):018:0> key = value.shift.strip
=> "a.b.c"
irb(main):019:0> value = value.shift.to_s.strip
=> "="

Thanks for the feedback. I updated the PR.

Coverage decreased (-0.1%) to 88.166% when pulling b6eab3d09e6823b7056ef79cc33fc460f3419b5d on mikej-hc:master into 012cd99bb6f1fdf210a2bc1c3f153138643dfb48 on hercules-team:master.

Coverage decreased (-0.1%) to 88.166% when pulling b6eab3d09e6823b7056ef79cc33fc460f3419b5d on mikej-hc:master into 012cd99bb6f1fdf210a2bc1c3f153138643dfb48 on hercules-team:master.

Is there any chance of some progress on this, I've just come across this because I got an error of Sysctl[kern.ipc.soacceptqueue]: Could not evaluate: Error: kern.ipc.soacceptqueue is not a valid sysctl key whilst trying to use this module.

That looks good to me (although a bit harder to understand). Do you think you could add tests for this?

I'm new to Ruby and having trouble getting the tests to build. Do you have insight what I'm doing wrong? Thanks.
bundle install --path vendor
bundle exec rake spec
Cloning into 'spec/fixtures/modules/augeasproviders_core'...
I, [2017-10-20T13:00:59.225131 #35669]  INFO -- : Creating symlink from spec/fixtures/modules/augeasproviders_sysctl to /root/src/augeasproviders_sysctl
/usr/local/rvm/rubies/ruby-2.1.10/bin/ruby -I/root/src/augeasproviders_sysctl/vendor/ruby/2.1.0/gems/rspec-core-3.7.0/lib:/root/src/augeasproviders_sysctl/vendor/ruby/2.1.0/gems/rspec-support-3.7.0/lib /root/src/augeasproviders_sysctl/vendor/ruby/2.1.0/gems/rspec-core-3.7.0/exe/rspec --pattern spec/\{aliases,classes,defines,unit,functions,hosts,integration,type_aliases,types\}/\*\*/\*_spec.rb --color

An error occurred while loading ./spec/unit/puppet/provider/sysctl/augeas_spec.rb.
Failure/Error: raise("Missing augeasproviders_core dependency") if Puppet::Type.type(:augeasprovider).nil?

Puppet::Error:
  Could not autoload puppet/type/sysctl: Could not autoload puppet/provider/sysctl/augeas: Missing augeasproviders_core dependency
# ./lib/puppet/provider/sysctl/augeas.rb:6:in '<top (required)>'
# ./vendor/ruby/2.1.0/gems/puppet-5.3.2/lib/puppet/util/autoload.rb:68:in 'load'
# ./vendor/ruby/2.1.0/gems/puppet-5.3.2/lib/puppet/util/autoload.rb:68:in 'load_file'
# ./vendor/ruby/2.1.0/gems/puppet-5.3.2/lib/puppet/util/autoload.rb:83:in 'block in loadall'
# ./vendor/ruby/2.1.0/gems/puppet-5.3.2/lib/puppet/util/autoload.rb:81:in 'each'
# ./vendor/ruby/2.1.0/gems/puppet-5.3.2/lib/puppet/util/autoload.rb:81:in 'loadall'
# ./vendor/ruby/2.1.0/gems/puppet-5.3.2/lib/puppet/util/autoload.rb:208:in 'loadall'
# ./vendor/ruby/2.1.0/gems/puppet-5.3.2/lib/puppet/metatype/manager.rb:126:in 'newtype'
# ./lib/puppet/type/sysctl.rb:6:in '<top (required)>'
# ./vendor/ruby/2.1.0/gems/puppet-5.3.2/lib/puppet/util/autoload.rb:68:in 'load'
# ./vendor/ruby/2.1.0/gems/puppet-5.3.2/lib/puppet/util/autoload.rb:68:in 'load_file'
# ./vendor/ruby/2.1.0/gems/puppet-5.3.2/lib/puppet/util/autoload.rb:194:in 'load'
# ./vendor/ruby/2.1.0/gems/puppet-5.3.2/lib/puppet/metatype/manager.rb:171:in 'type'
# ./spec/unit/puppet/provider/sysctl/augeas_spec.rb:5:in '<top (required)>'
# ------------------
# --- Caused by: ---
# RuntimeError:
#   Missing augeasproviders_core dependency
#   ./lib/puppet/provider/sysctl/augeas.rb:6:in '<top (required)>'

Finished in 0.00058 seconds (files took 3.12 seconds to load)
0 examples, 0 failures, 1 error occurred outside of examples

[Coveralls] Outside the Travis environment, not sending data.
/usr/local/rvm/rubies/ruby-2.1.10/bin/ruby -I/root/src/augeasproviders_sysctl/vendor/ruby/2.1.0/gems/rspec-core-3.7.0/lib:/root/src/augeasproviders_sysctl/vendor/ruby/2.1.0/gems/rspec-support-3.7.0/lib /root/src/augeasproviders_sysctl/vendor/ruby/2.1.0/gems/rspec-core-3.7.0/exe/rspec --pattern spec/\{aliases,classes,defines,unit,functions,hosts,integration,type_aliases,types\}/\*\*/\*_spec.rb --color failed

It looks like you also need augeasproviders_core @mikej-hc and that's about all that I can suggest.
I too am new to Ruby and try to interact with it as little as Puppet allows me to (which is far too much for my liking) but this is definitely an area that I need to learn.

I've had a good look into how you are supposed to add the augeasproviders_core module when you're testing this module and there's nothing online that in any way helps to explain what on earth you're supposed to do.  There is zero direction anywhere.
There is this comment: check that you have the augeasproviders_core module present in this issue but I already had guessed that.  How you actually go about ensuring that that module is present I have no clue.  This is extremely frustrating

@rick-pri Check and make sure that the augeasproviders_core module is listed in the .fixtures.yml file in the module.
It appears to be in my copy, but may have been removed at some point. Also, you may need to remove spec/fixtures/modules/* manually and try again if something went wrong.

Hi @trevor-vaughan it seems that I do have a .fixtures.yml file and it specifies the repo:
fixtures:
  repositories:
    "augeasproviders_core":
      repo: "git://github.com/hercules-team/augeasproviders_core.git"
  symlinks:
    augeasproviders_sysctl: "#{source_dir}"

Actually, I can see that the module gets imported by watching the directory as the test run so the issue seems to be maybe one of pathing.

The error starts with An error occurred while loading ./spec/unit/puppet/provider/sysctl/augeas_spec.rb
If I do a require_relative with unit/puppet/provider/sysctl/augeas_spec I get another failure.  I'm not sure that my ruby environment is clean as I'm just using the system ruby install on Ubuntu and then I've gem installed the likes of puppet.
I had a look at using rbenv but it doesn't seem to just work like a python virtualenv so I'll have to come back to this when I can be bothered ... ruby just makes me sad every time I have to work with it.

@rick-pri Try following these instructions for setting up a test environment. I generally prefer rvm over rbenv because it tends to work around system issues better.
http://simp.readthedocs.io/en/master/getting_started_guide/ISO_Build/Environment_Preparation.html

I followed that as far as I could.  I have rvm installed, tried to activate rvm (how do you know if you're using the rvm?  virtualenv changes the shell on sourcing the env so you know when you're in the virtualenv).
I've done a bundle install and it installed a bunch of stuff.  Now in python venv that would have been installed to the virtualenv, and I'd have been able to see the contents of the venv with a pip list, but the documentation seems to imply that I have to create a gemset maybe, and that somehow I have to install into the gemset?

@rick-pri You should be good to go.
You can see what Ruby you're using by running rvm list and you can see what is installed via bundler by bundle list.
The shell doesn't change by default due to not wanting to disrupt the developer's environment.
Think of rvm as venv and bundle as pip and you're not far off.

@raphink Any reason not to merge this?

Fixed in #30


hare Run I/O test m0crate: command not found

[root@ssc-vm-1061 hare]# hctl bootstrap --mkfs singlenode.yaml
2020-10-30 00:36:02: Generating cluster configuration... OK
2020-10-30 00:36:03: Starting Consul server on this node............ OK
2020-10-30 00:36:13: Importing configuration into the KV store... OK
2020-10-30 00:36:15: Starting Consul on other nodes... OK
2020-10-30 00:36:15: Updating Consul configuraton from the KV store... OK
2020-10-30 00:36:15: Waiting for the RC Leader to get elected....... OK
2020-10-30 00:36:20: Starting Motr (phase1, mkfs)... OK
2020-10-30 00:36:48: Starting Motr (phase1, m0d)... OK
2020-10-30 00:36:52: Starting Motr (phase2, mkfs)... OK
2020-10-30 00:38:00: Starting Motr (phase2, m0d)... OK
2020-10-30 00:38:04: Checking health of services...  PATTERN [FILE]...
Try 'grep --help' for more information.
Usage: grep [OPTION]... PATTERN [FILE]...
Try 'grep --help' for more information.
[root@ssc-vm-1061 hare]# dd if=/dev/urandom of=/tmp/128M bs=1M count=128
128+0 records in
128+0 records out
134217728 bytes (134 MB) copied, 0.961014 s, 140 MB/s
[root@ssc-vm-1061 hare]# m0crate -S /tmp/m0crate-io.yaml
-bash: m0crate: command not found
[root@ssc-vm-1061 hare]# /opt/seagate/cortx/hare/libexec/m0crate-io-conf > /tmp/m0crate-io.yaml
Usage: grep [OPTION]... PATTERN [FILE]...
Try 'grep --help' for more information.
Usage: grep [OPTION]... PATTERN [FILE]...
Try 'grep --help' for more information.
[root@ssc-vm-1061 hare]# m0crate -S /tmp/m0crate-io.yaml
-bash: m0crate: command not found
[root@ssc-vm-1061 hare]# cd libexec/m0crate-io-conf
-bash: cd: libexec/m0crate-io-conf: No such file or directory
[root@ssc-vm-1061 hare]# cd libexec
-bash: cd: libexec: No such file or directory
[root@ssc-vm-1061 hare]# ls
AUTHORS  CODE_OF_CONDUCT.md  hare.spec  hctl     Jenkinsfile  Makefile      README.md  rules            stubs    utils   VERSION
cfgen    CONTRIBUTING.md     hax        jenkins  LICENSE      provisioning  rfc        singlenode.yaml  systemd  vendor
[root@ssc-vm-1061 hare]# /opt/seagate/cortx/hare/utils/m0crate-io-conf > /tmp/m0crate-io.yaml
-bash: /opt/seagate/cortx/hare/utils/m0crate-io-conf: No such file or directory
[root@ssc-vm-1061 hare]# ls
AUTHORS  CODE_OF_CONDUCT.md  hare.spec  hctl     Jenkinsfile  Makefile      README.md  rules            stubs    utils   VERSION
cfgen    CONTRIBUTING.md     hax        jenkins  LICENSE      provisioning  rfc        singlenode.yaml  systemd  vendor
[root@ssc-vm-1061 hare]# /utils/m0crate-io-conf > /tmp/m0crate-io.yaml
-bash: /utils/m0crate-io-conf: No such file or directory
[root@ssc-vm-1061 hare]# cd utils
[root@ssc-vm-1061 utils]# ls
bootstrap-node        gen-uuid            h0q               hare-node-join  hare-status      next-epoch  README.md
check-service         get-entrypoint      hare-bootstrap    hare-reportbug  m0crate-io-conf  node-name   s3auth-disable
consul-watch-handler  get-process-state   hare-drive-state  hare-shutdown   m0trace-prune    pcs-chart   update-consul-conf
elect-rc-leader       get-service-health  hare-node         hare-start      mk-consul-env    proto-rc
[root@ssc-vm-1061 utils]# ls
bootstrap-node        gen-uuid            h0q               hare-node-join  hare-status      next-epoch  README.md
check-service         get-entrypoint      hare-bootstrap    hare-reportbug  m0crate-io-conf  node-name   s3auth-disable
consul-watch-handler  get-process-state   hare-drive-state  hare-shutdown   m0trace-prune    pcs-chart   update-consul-conf
elect-rc-leader       get-service-health  hare-node         hare-start      mk-consul-env    proto-rc
[root@ssc-vm-1061 utils]# m0crate-io-conf > /tmp/m0crate-io.yaml
-bash: m0crate-io-conf: command not found
[root@ssc-vm-1061 utils]# ./m0crate-io-conf > /tmp/m0crate-io.yaml
Usage: grep [OPTION]... PATTERN [FILE]...
Try 'grep --help' for more information.
Usage: grep [OPTION]... PATTERN [FILE]...
Try 'grep --help' for more information.
[root@ssc-vm-1061 utils]# dd if=/dev/urandom of=/tmp/128M bs=1M count=128
128+0 records in
128+0 records out
134217728 bytes (134 MB) copied, 1.007 s, 133 MB/s
[root@ssc-vm-1061 utils]# m0crate -S /tmp/m0crate-io.yaml
-bash: m0crate: command not found

Here, the specific path m0crate needs to be given.
This command works well (path lies in the cortx-motr directory)
'''
./cortx-motr/motr/m0crate/m0crate  -S /tmp/m0crate-io.yaml
'''
This looks to be fix in documentation only.

Here, the specific path m0crate needs to be given.
This command works well (path lies in the cortx-motr directory)
'''
./cortx-motr/motr/m0crate/m0crate  -S /tmp/m0crate-io.yaml
'''
This looks to be fix in documentation only.

./motr/m0crate/m0crate -S /tmp/m0crate-io.yaml works


Update README.md for branch opencv-3.1

Thanks for your contribution!
But the master branch has been bumped to opencv v4.1. So I will be closing this PR.


CFE bug inferring / instantiating universal functions

The following prints '3' in DDC:
import 'dart:math' as math;

void main() {
  var list = [1, 2, 3];
  var val = list.fold(0, math.max);
  print(val);
}

but fails in the new CFE with:
max.dart:5:31: Error: A value of type '<T extends dart.core::num>(dart.math::max::T, dart.math::max::T) → dart.math::max::T' can't be assigned to a variable of type '(dart.core::int, dart.core::int) → dart.core::int'.
Try changing the type of the left hand side, or casting the right hand side to '(dart.core::int, dart.core::int) → dart.core::int'.

Note, the old FE is instantiating math.max as math.max<int> based on context.
@kmillikin @leafpetersen @a-siva

If math.max is replaced with (x, y) => math.max(x, y), it appears to infer the correct instantiation.

@stereotype441 @crelier @sigmundch

Duplicate of issue #31586.


Centralize exception creation

Closes #1374.
Closes #1372.
\c @alazier

Overall looks good. Lets try to finish this up today to minimize conflicts.

@alazier added test coverage.

Couldn't we just make a function which returns bool and XCTAssertTrue? Would be a bit less confusing I think. Otherwise everything looks good to me.

Couldn't we just make a function which returns bool and XCTAssertTrue? Would be a bit less confusing I think.

Done.

:+1:


Big ping

The question is simple why high ping?
Worker and pool are on the local network

@Konstantin35 Care to elaborate? I don't see the problem.

@oliverw as you can see in the screenshots each sent shares a delay of 1000ms and 500ms is too much time because of this many orphan blocks
I am currently using only Ethash possible and on other algorithms the same problem

I still don't get what you mean with ping. What I can see on your first screenshot is that the accepted time is extremely high.

The lower the ping – the better.
In mining core there is such a problem as to look for the cause of such a large delay, since mining core is much more effective than open-ethereum-pool
sorry for bad English

No problem. We really need to get to the root of this. I'm going to prepare a special build for you with much more logging.

@Konstantin35 Could you try to reproduce this behavior while having Miningcore run with logLevel: "debug" (config.json)?

Easy way to see where the wait is, grab a packet capture on both your client and server only capturing that port.  Pull those in to wireshark and compare the two, you should see pretty quickly where the wait is.
Command would be something like:
tcpdump -i any -s0 'port 3072' -w cap1.pcap
Run that just long enough to see the issue and then kill it.  You'll now have your traffic in the cap1.pcap file, open that in wireshark.  So the same on the both client and server (change filename so you don't stomp each other).

@Konstantin35 Any news on this?

Maybe :
Open ethereum pool  is a proxy and a stratum. Response is from proxy to client.  You didnt really know how many time response is between proxy and ethereum node.

Here are the files
core.log
cap1.zip

@Konstantin35 Checking.

@oliverw I didn't understand

[2019-05-16 16:02:27.4920] [D] [mix] [0HLMPVM4UV40B] [NET] Received data: {"id":40,"method":"mining.submit","params":["0x1f67a69b581f9339ad1f8ff1b52726753a79dde4","0000005a","000007ac2913"]}
[2019-05-16 16:02:27.4920] [D] [mix] [0HLMPVM4UV40B] [NET] Waiting for data ...
[2019-05-16 16:02:27.4932] [D] [mix] [0HLMPVM4UV40B] [PIPE] Received data: {"id":40,"method":"mining.submit","params":["0x1f67a69b581f9339ad1f8ff1b52726753a79dde4","0000005a","000007ac2913"]}
[2019-05-16 16:02:27.4932] [D] [mix] [0HLMPVM4UV40B] Dispatching request 'mining.submit' [40]
[2019-05-16 16:02:27.4932] [D] [mix] SubmitShareAsync(0HLMPVM4UV40B)
[2019-05-16 16:02:27.4932] [D] [mix] Compute()
[2019-05-16 16:02:28.3044] [D] [mix] [0HLMPVM4UV40B] Sending: {"result":true,"error":null,"id":40}
[2019-05-16 16:02:28.3044] [I] [mix] [0HLMPVM4UV40B] Share accepted: D=0,5

According to the log you provided the time is indeed spent inside Miningcore. In the example above , processing the submitted share takes 0.81sec.

[2019-05-16 16:02:27.4932] [D] [mix] Compute()
[2019-05-16 16:02:28.3044] [D] [mix] [0HLMPVM4UV40B] Sending: {"result":true,"error":null,"id":40}

Almost the 100% of the time is spent inside the DAG computation.

here are some parameters
Desktop.zip

@oliverw I noticed that when you first start miningcore delay and there is 1 - 3 ms, reboot the server and latency 600 - 800 ms, and remove the generated dag file, run miningcore dag generated new files and again latency 1 - 3 ms.

To make everything work correctly, you will have to generate new dag files after each reboot of the server

To make everything work correctly, you will have to generate new dag files after each reboot of the server
For the test is not very important and a big delay
On the working server, you should specify the path for dwg files in the tmp folder to avoid the server memory overflow, I think the problem is solved

Everything worked all night fine, but after running the second instance of parity chain CLO again delay 500 - 800 ms

try 'top' and look system health, 8gb it's few,  probably system swaping. Is it ssd hd ?

Perhaps few resources but on the production server will be more more worried about the fluctuations of the delay are too many min - max, it is certainly the case in miningcore very long obrabatyvat solutions.
Here are the server statistics:
https://drive.google.com/file/d/1bn8W8C6n-8-j2hEqKfIm9kmNJ5p-JDOg/view?usp=sharing

statistic felling good , is it in production with two parity instance ?
hyper v has variable performance, it is possible that performance collapses when main node lacks memory.

This could be a hyper-v problem (I highly doubt it in this case), but all the time is spent after a mining.notify has been sent.  From your capture you have above, you can see that in this particular call, there's 48 seconds before it responds.  This is a single TCP stream that I've filtered out.  There are several that are > 10s all waiting for that mining.notify.

I guess your problem is the DAG File. Pool need so check every share against the ethereum DAG file. If your file is located on a disk, then your disk I/O is crucial to the checking process. For a simple test create a filespace in your server RAM and place the DAG file in there.  There is a  dagDir option in the miningcore config to relocate the DAG file.


Element Finder finds the last element from similar elements on the page (search from the bottom of the page)

Describe the bug
Element Finder finds the last element from several similar elements on the page (basically, it starts search from the bottom of the page).
All kinds of "getElementBy" were tried.
Expected behavior
The first elements from the similar elements shall be found starting from the top of the page
Desktop (please complete the following information):

OS: Win 11
Browser chrome
Version 128.0.6613.138

Hi @AVAV19 ,
Can you please help me with selector you are using .

Hi, In this case it is ClassName::td-list-column-langs-link
Andrei
On Wed, Sep 18, 2024 at 5:45 AM Dharmesh @.***> wrote:

Hi @AVAV19 https://github.com/AVAV19 ,
Can you please help me with selector you are using .
—
Reply to this email directly, view it on GitHub
https://github.com/Dhruv-Techapps/acf-docs/issues/427#issuecomment-2357999623,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/BLLVEDZ6FXGT2CYKCIXP3FDZXFDU3AVCNFSM6AAAAABOL6ZLA2VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDGNJXHE4TSNRSGM
.
You are receiving this because you were mentioned.Message ID:
@.***>

Basically, there are 7 class elements td-list-column-langs-link, but the extension selects and clicks only on the last element though it is supposed to select the first element.

We just tested the className selector on our test page and it clicks all the elements which matches that class name and not last one.

document.querySelectorAll("button").forEach((ele) => {
    ele.addEventListener("click",(e) => console.log(e.target))
});

Would recommend to change the selector to more narrow down the button on which you like to click.

regex in url or element finder?

If possible, both options (replace ?):
in url https://gengo.com/t/jobs/details/ ?
element finder: //a[@href="https://gengo.com/t/jobs/details/ ?  "]

URL support partial match as well https://getautoclicker.com/docs/4.x/configuration/url/
xpath you can use contains check for partial check https://getautoclicker.com/docs/4.x/action/element-finder/
for further queries connect over discord https://discord.gg/ubMBeX3


Added clock_getcpuclockid to more targets

Draft for now - will make a normal pull request once build passes.

r? @JohnTitor
(rust_highfive has picked a reviewer for you, use r? to override)


Issues making requests?

Translated:
Subject: I can't make a request
Description:
I press the "request" tab
Results:
The page that opens tells me that there was a problem and that I must refresh the page
Backend version: develop-39bd5b85
Frontend version: develop-c8330ba7
User Agent: Mozilla/5.0 (Linux; Android 10; K) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/<IP_ADDRESS> Mobile Safari/537.36
Page: https://couchers.org/user/doritosalvaje
User: z154 (35837)

I don't know what's happening here, I feel there may be a pattern.

Was not a pattern


[Frontend] Allow -emit-interface with -typecheck

Textual module interfaces don't actually depend on SILGen, so we shouldn't need to run SILGen (or serialize an entire binary module) if we're just trying to emit a textual interface. On the other hand, if we are going to run SILGen and then SIL diagnostics, we shouldn't delay those diagnostics by spending time emitting a textual interface, or for that matter a TBD file.
Using this, update all the ModuleInterface tests that use -emit-module -o /dev/null to use -typecheck instead, except for those using -merge-modules.

@swift-ci Please smoke test

@swift-ci Please test source compatibility

Aha, yes, the very thing I changed was, in fact, being tested.

Debug source compat, Release source compat.
@swift-ci Please smoke test


Error: can't convert Sawyer::Resource to Array when no OctoKit data returned

when trying to run this generator I'm hitting the following error:
/Users/tbn/.rvm/gems/ruby-2.3.1/gems/github_changelog_generator-1.14.1/lib/github_changelog_generator/octo_fetcher.rb:101:in `concat': can't convert Sawyer::Resource to Array (Sawyer::Resource#to_ary gives NilClass) (TypeError)
	from /Users/tbn/.rvm/gems/ruby-2.3.1/gems/github_changelog_generator-1.14.1/lib/github_changelog_generator/octo_fetcher.rb:101:in `block in github_fetch_tags'
	from /Users/tbn/.rvm/gems/ruby-2.3.1/gems/github_changelog_generator-1.14.1/lib/github_changelog_generator/octo_fetcher.rb:269:in `iterate_pages'
	from /Users/tbn/.rvm/gems/ruby-2.3.1/gems/github_changelog_generator-1.14.1/lib/github_changelog_generator/octo_fetcher.rb:98:in `github_fetch_tags'
	from /Users/tbn/.rvm/gems/ruby-2.3.1/gems/github_changelog_generator-1.14.1/lib/github_changelog_generator/octo_fetcher.rb:69:in `block in get_all_tags'
	from /Users/tbn/.rvm/gems/ruby-2.3.1/gems/github_changelog_generator-1.14.1/lib/github_changelog_generator/octo_fetcher.rb:286:in `block in check_github_response'
	from /Users/tbn/.rvm/gems/ruby-2.3.1/gems/retriable-2.1.0/lib/retriable.rb:54:in `block in retriable'
	from /Users/tbn/.rvm/gems/ruby-2.3.1/gems/retriable-2.1.0/lib/retriable.rb:48:in `times'
	from /Users/tbn/.rvm/gems/ruby-2.3.1/gems/retriable-2.1.0/lib/retriable.rb:48:in `retriable'
	from /Users/tbn/.rvm/gems/ruby-2.3.1/gems/github_changelog_generator-1.14.1/lib/github_changelog_generator/octo_fetcher.rb:285:in `check_github_response'
	from /Users/tbn/.rvm/gems/ruby-2.3.1/gems/github_changelog_generator-1.14.1/lib/github_changelog_generator/octo_fetcher.rb:69:in `get_all_tags'
	from /Users/tbn/.rvm/gems/ruby-2.3.1/gems/github_changelog_generator-1.14.1/lib/github_changelog_generator/generator/generator_tags.rb:9:in `fetch_and_filter_tags'
	from /Users/tbn/.rvm/gems/ruby-2.3.1/gems/github_changelog_generator-1.14.1/lib/github_changelog_generator/generator/generator_generation.rb:8:in `compound_changelog'
	from /Users/tbn/.rvm/gems/ruby-2.3.1/gems/github_changelog_generator-1.14.1/lib/github_changelog_generator.rb:34:in `run'
	from /Users/tbn/.rvm/gems/ruby-2.3.1/gems/github_changelog_generator-1.14.1/bin/github_changelog_generator:5:in `<top (required)>'
	from /Users/tbn/.rvm/gems/ruby-2.3.1/bin/github_changelog_generator:23:in `load'
	from /Users/tbn/.rvm/gems/ruby-2.3.1/bin/github_changelog_generator:23:in `<main>'
	from /Users/tbn/.rvm/gems/ruby-2.3.1/bin/ruby_executable_hooks:15:in `eval'
	from /Users/tbn/.rvm/gems/ruby-2.3.1/bin/ruby_executable_hooks:15:in `<main>'

I've tried it with several other Ruby versions, uninstalled and reinstalled the gen again, but nothing works... any clue what I'm doing wrong?

Thanks for this report, @Turbo87. Let's figure it out!

thanks to @rwjblue we've figured it out: this was caused by an outdated .github_changelog_generator file. the repository was recently moved to another organization but the file wasn't updated. while this was not a real issue of the generator, the error message could be improved though to tell you that the repository wasn't found.

@Turbo87 Thanks for figuring it out!

@Turbo87 To improve chances of us fixing your issue, do you have a before/after of the .github_changelog_generator file?

@olleolleolle see https://github.com/ember-cli/ember-cli-mocha/commit/d712d0968485c03118ebb8517c282a372919013d

I have a hard time reproducing this failure. Things I tried:

pointing it at olleolleolle/github-changelog-generator
pointing it at olleolleolle/olleolleolle.github.io which has 0 tags (does not fail)

Hm. Hm. Is it about having transferred ownership of the repo?

Now! Now I can.
Using the original ember-cli-mocha one!

Is it about having transferred ownership of the repo?

It might be. I know that GitHub is redirecting some stuff, but maybe not everything.


LambdaTest: dashboard query fix

Summary
This PR is to make a correction in the queries of the newly added LambdaTest - HyperExecute Overview dashboard.

@sjyothi54 there's a small fix required in the newly added dashboards. Can you please review this PR? Also please let me know when can this be deployed. Thanks!

@sjyothi54 there's a small fix required in the newly added dashboards. Can you please review this PR? Also please let me know when can this be deployed. Thanks!

hey @saksham-gg, I am merging PR now you can expect it to be live by Thursday

Thanks for merging @sjyothi54. By any chance is it possible to get this live before Thursday? Some NewRelic<>LambdaTest users are waiting for this feature.

Thanks for merging @sjyothi54. By any chance is it possible to get this live before Thursday? Some NewRelic<>LambdaTest users are waiting for this feature.

The deployment will be handled by the Jumpstart team. If you have any concerns or urgent issues, please raise them in the #help-jumpstart channel.


Change in how openshift parses templates. Type of field 'required' changed from String to Bool.

Is this the same issue as #49?  Which version of the oc client are you using?

Yes, it is. I use oc v<IP_ADDRESS>0-185-g2f7757a.
I tried to find the change on origin but only thing I managed to find is another template that already uses bools instead of strings.


Fatal access violation error

I noted the example console application exiting with fatal memory access violation error. I am not sure what is causing it.
One time it was from WinCertMaker. But not always consistent, specifically when running on release mode in VS.

The issue seem to be with polly. Removed it.

Appears to be fixed after removal of polly


Error if path has spaces

If your project has a space in its path the call to execSync will fail because the unescaped space(s) causes the remainder of the command to be interpreted as command-line argument(s).

@dgsmith2 this doesn't seem to solve:
rxjs-5-to-6-migrate -p path\ to\ your/tsconfig.json

This issue needs to be reopened, because it really is a bug that needs to be resolved for Windows users. The file path is not just unescaped for tsconfig, but also the tslint and the rxjs-5-to-6migrate.json, and uses absolute paths.
If, for example, your user name in Winddows is "First Last", your path will look like "C:\User\First Last..." for all of the above files, breaking the install.

I've made a pull request that should fix this issue.

I just looked, there's a week old PR from dgsmith2 with almost exactly the same issue. The failure to accept this PR will be stopping a lot of people from upgrading to Angular 6. It's a hot topic off the back off IO18, so this should be seen to sooner rather than later.

yes this issue is big barrier to migrate angular 5 to angular 6 :(

Fixed and published as part of 0.1.4.


Hover consistency with Visual Studio

Fixes #2610
I also changed the display order so that it looks similar to VS's behavior:

@paladique Thanks for the PR! LGTM
cc @akshita31

Looks I need to fix a test too! Working on that now.

@paladique Note that you also need to update
1) Hover Provider: single csproj at root of workspace
       Hover returns structured documentation with proper newlines:

@paladique Thank you for your contribution. Looks good to me :)

@rchande Should we have a changelog entry for this ?


Update to latest protobuf

Updating protobuf to latest 3.6.0 release.

Tests are now all passing. PTAL.

@garrettjonesgoogle is there a simple way to do that?
Perhaps more importantly, shouldn't the CI be doing that anyway? I haven't looked under the hood but I thought that's what the smoke tests were for. Is that what the task that is currently being skipped does?

I don't know of a simple way to do that. The point of CI for artman is to smoke test the generation process, not the library calling process; that's a separate type of smoke test that I don't think is automatically called anywhere currently.

@garrettjonesgoogle if there is not a simple way to do this can we instead have language owners review the changelog for the most recent release and merge if there aren't any objections?
Unless there are major issues we need to get on this because it's blocking the release of new features for us as well.

Ok let's go with that.

@alexander-fenster @pongad @lukesneeringer @chrisdunelm (or @jskeet) could you please review the changes in protobuf 3.6.0 here and +1 or approve this PR if you're okay to upgrade the tools to use this release.
Ruby, PHP, & Java are good to go.

Unless there's a breaking change to protobuf wire format itself, Go shouldn't be affected. LGTM

As far as I'm aware it should be fine to do this for C#.

I'm fine since Node.js does not use protoc now.


ValueError: too many values to unpack

So I tried running the script on my Raspberry Pi 4 with the following command:
python3 oled.py /dev/i2c-1 1 1 0 0

And I got this error:
Traceback (most recent call last):
  File "/home/user/PyXCursor/oled.py", line 108, in <module>
    newbuffer = getFrameAsByteList()
  File "/home/user/PyXCursor/oled.py", line 82, in getFrameAsByteList
    iarray, xhot, yhot = cursor.getCursorImageArrayFast()
ValueError: too many values to unpack (expected 3)

Any way I can fix this?
Thank you in advance.

Interesting. Are you sure you haven't modified the pyxcursor code at all? Is the raspberry pi running X11 (not headless and not wayland)?
ctypes on ARM / rasbperry pi could behave completely differently for all I know. You could try changing the line that's causing the error to just print whatever cursor.getCursorImageArrayFast() is returning, might shed some light on it.

The Pi is running an X VNC server - with nothing connected to the HDMI ports. I was just running the Python script raw without the *.sh file with this repo. While on this topic, I actually was looking for a way to scale the output properly, as setting height to 32 only utilizes the bottom half of the 128x32 display, which I find odd. I plan on trying to play some video games with this strange setup.

There may be some slight differences with how the 128x32 version is addressed, I've not looked into it.
I feel I should also mention that if you just want to use the screen with a raspberry pi, you can connect it to the GPIO pins and use one of the more official ways to drive it (adafruit libraries etc). I wouldn't be surprised if there's a dt_overlay that just works out of the box, I know there's drivers for the small TFT displays. Much less fun though!
Also if you just connect the display to one of the other i2c ports you can probably up the clock speed a fair bit.

Yeah, I have it connected directly to the GPIO's i2c. I've tried using the official Adafruit libraries, I can't figure it out. I'd also prefer to use this script because it's optimized - at least, compared to the official driver. Not only that, the cursor is not required for what I intend to use this tiny OLED for - how would I go about removing the Xcursor stuff? Also, how would I up the i2c clock speed?
Thanks in advance,

Foxy6670

To get rid of the cursor it should be enough to just delete lines 79 to 84.
There's more than one way to change i2c clock speed on raspberry pi, I think you can just put something in /boot/config.txt, if you google there should be tutorials on it.


node v10 pre-built native binding

Output:
node-pre-gyp info it worked if it ends with ok
node-pre-gyp info using<EMAIL_ADDRESS>node-pre-gyp info using<EMAIL_ADDRESS>| linux | x64
node-pre-gyp info check checked for "/opt/project-glacier/node_modules/lzma-native/binding-v3.0.7-node-v64-linux-x64/lzma_native.node" (not found)
node-pre-gyp http GET https://node-pre-gyp.addaleax.net/lzma-native/lzma_native-v3.0.7-node-v64-linux-x64.tar.gz
node-pre-gyp http 404 https://node-pre-gyp.addaleax.net/lzma-native/lzma_native-v3.0.7-node-v64-linux-x64.tar.gz
node-pre-gyp ERR! Tried to download(404): https://node-pre-gyp.addaleax.net/lzma-native/lzma_native-v3.0.7-node-v64-linux-x64.tar.gz
node-pre-gyp ERR! Pre-built binaries not found for<EMAIL_ADDRESS>and<EMAIL_ADDRESS>(node-v64 ABI, musl) (falling back to source compile with node-gyp)
node-pre-gyp http 404 status code downloading tarball https://node-pre-gyp.addaleax.net/lzma-native/lzma_native-v3.0.7-node-v64-linux-x64.tar.gz
gyp info it worked if it ends with ok

Published as<EMAIL_ADDRESS>Let me know if you run into any other trouble!


add Expand listener and possiblity to toggle on click automatically

Expand listener (fire event when the expand status is changed)
toggle on click automatically by adding     app:el_toggle_on_click="true" on ExpandableLinearLayout to toggle automatically when the layout is clicked

Can you clarify the benefit of adding this?
In my understanding this replaces the onClickListener (an Android standard that all developers are familiar with) with a custom handler that essentially does the same thing but is less flexible.
More code means more maintenance effort and more possibility for bugs to hide. I want to be sure that any code added to the library is justified by its usefulness.

By adding this, you can create an expandable content without calling findViewById, setOnClickListener,  onClick, toggle (but it's optionnal).

I'm not a big fan of hardcoded behaviour, particularly when it only covers one of the many possible use cases.
This could be handled in a much cleaner way by the client by simply extending the layout and adding the onClick behaviour there. It would accomplish the same goal without adding complexity to the upstream code.
Regarding the new ExpandListener, can you give me a practical example where you'd need it and the existing OnExpansionUpdateListener wouldn't do?

I'm a fan of simple, comprehensible and customisable code.

I was asking for a specific real-world example where you would need the ExpandListener and the existing OnExpansionUpdateListener wouldn't do.

Can you can detect expand/collapse events with OnExpansionUpdateListener ?

Sure. If the value is 0 the view is collapsed, otherwise it's expanded.
You can also call isExpanded() at any time (for example, in response to an OnExpansionUpdateListener callback.

But it think it's more comprehensible with onToggle(boolean expanded)

I disagree. You failed to provide a specific example where you would use that callback in an actual product. The fact that it's more understandable is irrelevant if no one will use the feature.
I don't want to add code unless there's a clear benefit to the user of the library, especially when there's a perfectly acceptable alternative already implemented.
Sorry, but I'm rejecting this pull request.


Set syntax for syntax test file

Whose first line is like
# SYNTAX TEST "Git Attributes.sublime-syntax"

where # is a comment punctuation.

Done in 5e4a3d681b9f67476ec666c87941726521ce55ea.


Not working in Oreo, cannot see buttons.

Hi @AVINASH21AK
It's Oreo screenshot on the REEADME.md. Could you provide additional details

All 4 Dialog variants were tested on API28, API22, API19, API16 and API10. We don't find "cannot see buttons" errors. Please provide additional information/logs and we will reopen this ticket or create new one by yourself. Thank you.
1st Dialog variant (CLASSIC-non-AppCompat):
.setDialogType(DialogType.CLASSIC)
.setDialogManagerFactory(null)

2nd Dialog variant (CLASSIC-AppCompat):
DialogManager.Factory appCompatDialogManagerFactory = new AppCompatDialogManager.Factory();
...
.setDialogType(DialogType.CLASSIC)
.setDialogManagerFactory(appCompatDialogManagerFactory)

3rd Dialog variant (APPLE-non-AppCompat):
.setDialogType(DialogType.APPLE)
.setDialogManagerFactory(null)

4th Dialog variant (APPLE-AppCompat):
DialogManager.Factory appCompatDialogManagerFactory = new AppCompatDialogManager.Factory();
...
.setDialogType(DialogType.APPLE)
.setDialogManagerFactory(appCompatDialogManagerFactory)


Cannot load BartPhoTokenizer when i load the tokenizer use syllabel

When i try to load to load the tokenizer use syllable, i get an error "module transformers.models.bartpho has no attribute BartPhoTokenizer".
i used transformers 4.15.0. I tried to clean my folder ~/.cache/huggingface/transformers but i still get the same error.
Can you help me! Thanks.

It's weird. The tokenizer is already available on transformers: https://github.com/huggingface/transformers/tree/3d587c53432c7c392aa08f582015c846ca076540/src/transformers/models/bartpho
Can you try reinstall transformers version 4.12.0 and see whether the error still happens?

Please could you also help post this issue to huggingface's transformers ? Thanks.

i've tried reinstall transformers version 4.12.0 but i still get this error

I just tried reinstalling transformers, and it works without any error w.r.t. the tokenizer.

It might be the case that your Python IDE was not configured with a proper Python version and transformers library?

i have this error when i reinstall transformers version 4.12.0. How can i fix this error

It's "vinai/bartpho-syllable", not "vinai/bartpho-syllablel".

i am sorry about that, but i still get the same error

https://huggingface.co/docs/transformers/model_doc/bartpho is available since version 4.12.0.
I cannot help. I have no idea what's going on with your installation/configuration.

I appreciate your help so much.

Did you install sentencepiece: pip install sentencepiece

From Nguyen Luong Tran:
https://github.com/huggingface/transformers/issues/9862#issuecomment-787481015
=> reset runtime and install sentencepiece.

i tried to reset colab runtime and install sentencepiece, it's work for me. Thank you so much.

i tried to reset colab runtime and install sentencepiece, it's work for me. Thank you so much.


Minor linux GUI layout improvements (#1298)

Fix undo visuals1319 (#1328)

Fix undo/redo of com visualization

Support undo/redo of FrameToggleVisibilityAction

Update CHANGELOG.md

Description of changes made in this PR and others earlier in 4.4 stream.

include visualizer repo update

Update continuous-integration.yml

No caching of builds for now due to osx upgrade

Fix coordinate value text being cutoff by too short text field

Fix text overflow in short TextFields; Adjust font & tooltip for motions

Start, current, end time and speed text fields were too short to
accomodate 3 digits of seconds with 3 decimal precision
"Motion" text was very small, changed to derive from default system
font but bolded
Motion name label overflows for long file names; add dynamic tooltip
to show complete filename

Update 'Simulate' text label to derive from system font but bolded

Fix look & feel bug with Gnome (GTK) where slider values are always shown

Fix (properly) text field width by assigning preferred num columns

Apply similar fix to coordinate viewer

Co-authored-by: Ayman Habib<EMAIL_ADDRESS>Fixes issue #<issue_number>
Brief summary of changes
Testing I've completed
CHANGELOG.md (choose one)

no need to update because...
updated...

Port/test fixes from @halleysfifthinc

@halleysfifthinc @carmichaelong Can we check the Look and Feel on OSX and linux of the artifact from this PR before merging? Looking good on windows but I'm worried about osx inadvertently affected. Is there more to testing than checking the look-and-feel and behavior of motion slider and coordinate sliders?

I will take a look at the Linux artifact tonight. Only the look/layout is changed, so there shouldn't be (couldn't be, to the best of my knowledge) any changes to slider behavior.

On OSX, tried loading some models and motions and moving sliders around. All of that seemed to work well! Didn't notice much difference between 4.3 and this version, however, one big plus is that with my computer on dark mode, the font colors chosen are much better (seems like it chooses a typical light mode set instead of attempting to do a half-filled-dark-mode)!
Noticed a couple of issues, but all of these existed in 4.3 (i.e., 1) if the window width is too narrow, the panels in the top bar are pushed to two rows and can't be accessed well, 2) in the Coordinates tab, "Values" and "Speed" are not centered over the corresponding boxes).

Everything still looks good. (Pics in #1298 are still accurate).
(Though I will note that the Linux artifact is broken due to the adolc libs not being copied correctly opensim-core#2930)

Thanks @halleysfifthinc will merge, if you can assess the fix for adolc or suggest a best fix, that would be awesome. 👍


Pdf support

Please add pdf images support

+1

I don't think we will be adding this feature in the near future.

Per #1991 you can now write your own decoder/encoder for PDF. Just have to conform to SDWebImageCoder protocol. Closing this PR as we will not add and maintain any PDF handling.


entity framework is not selectable

Discussed in https://github.com/seclerp/rider-efcore/discussions/143

Originally posted by mmahtabb February 13, 2023
Hi

Last night I have some updates on rider and plugins after that I realized that the Enity framework is not selectable any more.
I searched a lot and downGrade the UI version to 223.1 but it still doesnt work
I got no error.
When I migrate from the tool menu which is on the top the migration would created but the file is not shown in my migration folder and I cant Update db, the error is there is no migration
How can I solve this problem?

Related to #142


Replace links with channel IDs in chat.channels

https://[ptb.]discord.com/channels/9876/1234567891234 -><PHONE_NUMBER>234

Fixed in 1e8179b67beca376a816e9245549d2d2c3d43b75

https://github.com/dominik-korsa/discord-integration/releases/tag/v3.2.0


[Experiment] Figure out why PR is crashing in CI

[crashtracker] Add builder class for CrashInfo
wrap macro
use the wrap macro more
stacktrace
stackframe
moved wrap function to common
more functions implemented
actually add the files
Fixup after merge
more builder functions
with_thread
siginfo
all builder implemented
Add handle type, and use it
make handle.take() a little nicer
sharpen the wrapper macros
add to_endpoint functions
normalizer
resolve names
make the builder consistently return a result
make crashtracker.c compile
example works, need to add a stack trace
extract result macro
nicer macros for extract result
stacktrace in example
finished C++ example
os_info
licence
headers
blazesym is only for unix
more cfg unix
format
even more cfg unix
unix
hopefully the last unix move:
do almost nothing

What does this PR do?
A brief description of the change being made with this pull request.
Motivation
What inspired you to submit this pull request?
Additional Notes
Anything else we should know when reviewing?
How to test the change?
Describe here in detail how the change can be validated.

Codecov Report
Attention: Patch coverage is 0.22650% with 881 lines in your changes missing coverage. Please review.

Project coverage is 70.19%. Comparing base (aa684fc) to head (2178bef).

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #788      +/-   ##
==========================================
- Coverage   71.25%   70.19%   -1.07%
==========================================
  Files         301      313      +12
  Lines       44704    45352     +648
==========================================
- Hits        31854    31835      -19
- Misses      12850    13517     +667

Components
Coverage Δ

crashtracker
38.06% <0.23%> (-6.84%)
:arrow_down:

crashtracker-ffi
5.65% <0.00%> (-2.76%)
:arrow_down:

datadog-alloc
98.73% <ø> (ø)

data-pipeline
91.38% <ø> (+0.44%)
:arrow_up:

data-pipeline-ffi
86.29% <ø> (ø)

ddcommon
81.60% <0.00%> (-1.68%)
:arrow_down:

ddcommon-ffi
64.83% <0.00%> (-3.85%)
:arrow_down:

ddtelemetry
59.45% <ø> (ø)

ddtelemetry-ffi
22.13% <ø> (ø)

dogstatsd
89.45% <ø> (ø)

dogstatsd-client
79.77% <ø> (ø)

ipc
82.76% <ø> (-0.11%)
:arrow_down:

profiling
84.30% <ø> (ø)

profiling-ffi
77.46% <ø> (ø)

serverless
0.00% <ø> (ø)

sidecar
37.96% <ø> (ø)

sidecar-ffi
0.00% <ø> (ø)

spawn-worker
50.36% <ø> (ø)

tinybytes
93.60% <ø> (ø)

trace-mini-agent
72.38% <ø> (ø)

trace-normalization
98.23% <ø> (ø)

trace-obfuscation
95.77% <ø> (ø)

trace-protobuf
77.67% <ø> (ø)

trace-utils
93.05% <ø> (-0.38%)
:arrow_down:


Test for checking combination of parameters

Description of feature
We should provide a comprehensive test that checks for the main combinations of parameters, even if it is only for ourselves to make sure everything is running as expected.
We can create the matrix strategy (at least partially) as in rnaseq https://github.com/nf-core/rnaseq/blob/master/.github/workflows/ci.yml

As discussed, we already have enough test coverage (unless the reviewers ask for something specific)


It should be possible to stop programs in the middle of an action

It should be possible to stop a running action/query with an appropriate method on AppExecutor, and stop the execution of subsequent commands.
This will allow pressing "cancel" in almond-dialog-agent to stop a command that takes too long.

If we ever want this, it will need changes in ThingTalk. But I'm not sure we need this.


Remove codeSigning EKU?

@mastahyeti @btoews can you help me remember why in #152 we added the codeSigning EKU when there is an email SAN? How are those related?
https://github.com/FiloSottile/mkcert/blob/a2b1208e9c7d6a9588bce49729cfedbdf9f8be21/cert.go#L96-L98

I had been using mkcert while I was developing
https://github.com/github/smimesign. I don’t recall if Github’s commit
signature checking requires the code signing EKU. @ptoomey3 could check
maybe. Regardless, I don’t need the EKU myself any longer, but it might be
useful to someone doing some kind of Git signing with mkcert.
On Sun, Oct 25, 2020 at 3:55 PM Filippo Valsorda<EMAIL_ADDRESS>wrote:

@mastahyeti https://github.com/mastahyeti @btoews
https://github.com/btoews can you help me remember why in #152
https://github.com/FiloSottile/mkcert/pull/152 we added the codeSigning
EKU when there is an email SAN? How are those related?
https://github.com/FiloSottile/mkcert/blob/a2b1208e9c7d6a9588bce49729cfedbdf9f8be21/cert.go#L96-L98
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/FiloSottile/mkcert/issues/303, or unsubscribe
https://github.com/notifications/unsubscribe-auth/AAIXLBML7HVF3GSSR6YCGZDSMR7DLANCNFSM4S6RVBTA
.

I'll try pushing up a quick change to see what happens if we mint a cert for SMIME signatures without that extension.

Nothing in CI broke when I disabled adding this extension for certs used for SMIME signatures in our tests.

Awesome, thank you for checking!


Use base net types for IP and CIDR fields in API

We currently use anonymous fields in a struct to extend the net.IP etc. types.  I think we should use typedef to extend ... which means implementing certain key methods on the derived types (JSON marshaling and String() )
I think this is a clearer approach when accessing the methods on the original type since you need to explicitly recast to the original type to access the methods.  This makes it clear that the methods work on the original type not the derived type.
Motivation:  It fixes up the YAML output for types that are nil able, where we want to omit the field from the YAML if the value is nil.  If we subclass using a struct then the struct cannot be nil'ed without making it a pointer in the API.

I think we should go one further and try and use the base net types ... and then somehow fixup the yaml marshaler and unmarshaler to handle arbitrary types.

@robbrockbank I think we decided not to do this.


Pixark server setup errors

When trying to start up the server it seems to download everything fine but when looking into the console it spits out a lot of errors that just repeat and stop the server from working not sure what the problem is entirely.

Don't see any errors there, only warnings. What makes you say the server is not working properly? Have you installed the dependencies for the server?

What dependencies do I need?

It got past CubeWorldServer:Warning: compose_generator.cpp 66 cubesvr::CComposeGenerator::ComposeColumn biome not exists. 255. Now its giving me this repeatedly.

Yep, but so what? Are all the ports listening?

Yes it says all ports are listening.

I don't understand the issue then

The server isn't actually starting it gets stuck in a endless loop.

I see the server in my server browser on the game but if I try to join I get a connection timeout. If I stop the server it tells me that PixARKServer.exe is a unknown function and that 0 bytes have been written.

When trying to start up the server it seems to download everything fine but when looking into the console it spits out a lot of errors that just repeat and stop the server from working not sure what the problem is entirely.

I am having the EXACT same issue as the OP.


OpenID Configuration and WS-Federation (Passive) Configuration sections are marked as configured by default

Describe the issue:
OpenID Configuration and WS-Federation (Passive) Configuration sections  are marked as configured  by default  , even though its not configured yet by the user.

How to reproduce:
1.Login
2.Create a service provider
3.Navigate to Inbound Authentication Configuration section
pack:https://drive.google.com/file/d/1h3ynCA_1kLKPovRahbDtrtGvFYxXkbvs/view

Same behaviour was observed in IS 5.11 as well


add simple unbox feature into test plugin

and use it in the object passing test to verify behavior
@lesters please review

👍


Initial release for a conda-forge pkg

Thanks for the library it looks great! I would like to have a conda pkg that people can install based on conda-forge. I have started that work here: https://github.com/conda-forge/staged-recipes/pull/731
The only thing needed is an "official" release with a git tag that I can use to freeze the build of the pkg.
Also, would someone want to be added as a maintainer for that conda pkg? If not I am ok doing that.
Thanks!

Hi Daniel,
Thank you for your help. It would be great to bundle paratext in a conda package. I will create a tag for the official release. As you are with continuum, I am fine with you being the maintainer for conda.
Best,
Damian

@danielfrg i'm happy to volunteer to help w/ maintainership of the conda-forge recipe

Great. Note that this is a conda-forge package so it will not be in the main (continuum controlled) namespace and the build process is open.
The build seams to be working in linux and py2.7 now. We can update it to build on the other platforms once the other OS X and py3 issues are solved. Once a tag is on the git repo we are probably good to merge that conda recipe.
@wesm I added you as maintainer in the conda-forge feedstock here: https://github.com/conda-forge/staged-recipes/pull/731

Hi @danielfrg ,
Ideally, most future versions should be backwards compatible. Hence the delay for a release tag. I will clean up the paratext import a bit, and then tag the repo. Sorry for the delay.
Best,
Damian

Not a problem I will wait for that and then finish the conda-forge recipe when its done.


0.2.0 release

Could a new 0.2.0 release be created given the last one was in 2022?

Thanks for your request! We've just released the new 0.2.0.
In the future we will release more often!


Mobile preview/overlay in story mode for Tour authoring

Most tours are authored in a landscape oriented screen (on a desktop computer), but might be consumed on a device in landscape or portrait orientation. Because of how Voyager resizes, in portrait mode the right and left sides of a view might be clipped. A way to address this issue could be to include an overlay on the Explorer window in Story while authoring tours that indicates how the current view will be displayed on a portrait oriented screen. Another option could be a mobile preview button.
This ticket relates to "Views during a tour can be clip when in portrait aspect ratio" #98
For an example see tour stop 4 on the Roberto Clemente's Batting Helmet scene
https://3d.si.edu/object/3d/roberto-clementes-batting-helmet:92c986d0-2b8d-43c1-8354-e9a2e80d0f9e

Added as aspect ratio toolbar in v0.22.0


vs throws error after autocomplete

VSCode Version: Code 1.3.1 (e6b4afa53e9c0f54edef1673de9001e9f0f547ae, 2016-07-12T13:35:06.227Z)
OS Version: Windows_NT ia32 10.0.10586

Steps to Reproduce:

It actually works, but VSC  doesn't update

@Draethorian pls provide reproducible steps. What was the content of the file before and after you invoked intellisense? Where was the cursor? The error message seems to indicate that the linter saw only ./like.componen rather than the whole string. Did you perform any additional edits?

Closing since no additional information has been provided and I am not able to reproduce the issue.


Possible leak in FixedChannelPool

I've been trying to debug a very odd problem we're seeing in our use of FixedChannelPool. I can acquire and release channels from the pool just fine, but eventually a situation occurs where the internal acquiredChannelCount does not match what has actually been released and acquired. This leads to a situation where the pool thinks it's got the maximum amount of channels outstanding, even though all the channels have already been release, leading to a pending acquire queue which never progresses.
I have forked FixedChannelPoolTest.java and managed to replicate the issue. In order to make it happen, I need to spawn about a hundred threads, each acquiring and releasing about 50,000 channels before I can get an acquired channel discrepancy. This of course leads me to believe it's an obscure race condition somewhere. Another interesting thing to note is that this only occurs if I explicitly close the channel before releasing it. If I don't close it, it doesn't seem to happen.
Or perhaps I'm doing something wrong. It wouldn't be the first time. Any help would be appreciated.

Let me have a look

@kennethjor can you also include which version of netty?

@normanmaurer his fork is 4.0.34.Final-SNAPSHOT

@kennethjor hmm I think your test is not correct and so it will show the error. The problem is that you completely exit the for loop on an error while acquire and not wait for the latch to be completely countdown.
Please try this test code and see if you still see the issue (I not see it with this):
    @Test
    public void testAcquireReleaseMany() throws Exception {
        EventLoopGroup group = new LocalEventLoopGroup(8);
        LocalAddress addr = new LocalAddress(LOCAL_ADDR_ID);
        Bootstrap cb = new Bootstrap();
        cb.remoteAddress(addr);
        cb.group(group)
                .channel(LocalChannel.class);

        ServerBootstrap sb = new ServerBootstrap();
        sb.group(group)
                .channel(LocalServerChannel.class)
                .childHandler(new ChannelInitializer<LocalChannel>() {
                    @Override
                    public void initChannel(LocalChannel ch) throws Exception {
                        ch.pipeline().addLast(new ChannelInboundHandlerAdapter());
                    }
                });

        // Start server
        Channel sc = sb.bind(addr).syncUninterruptibly().channel();
        CountingChannelPoolHandler handler = new CountingChannelPoolHandler();

        int maxChannels = 8;
        final ChannelPool pool = new FixedChannelPool(cb, handler, maxChannels, Integer.MAX_VALUE);

        ExecutorService executor = Executors.newCachedThreadPool();
        final int n = 50;
        final int m = n * 1000;
        final CountDownLatch latch = new CountDownLatch(n);
        final Set<Channel> channels = Collections.newSetFromMap(new ConcurrentHashMap<Channel, Boolean>());
        final AtomicInteger rounds = new AtomicInteger();
        for (int i=0 ; i<n ; i++) {
            executor.execute(new Runnable() {
                @Override
                public void run() {
                    try {
                        for (int i = 0; i < m; i++) {
                            rounds.incrementAndGet();
                            Future<Channel> future1 = pool.acquire().syncUninterruptibly();
                            assertTrue(future1.isSuccess());
                            Channel channel = future1.getNow();
                            assertNotNull(channel);
                            channels.add(channel);
                            try {
                                channel.close().syncUninterruptibly();
                            }
                            catch (Throwable e) {
                                e.printStackTrace();
                                //System.out.println("Close error: " + e.getClass().getName() + ": " + e.getMessage());
                            }
                            try {
                                pool.release(channel).syncUninterruptibly();
                            }
                            catch (IllegalStateException e) {
                                if (!e.getMessage().equals("Channel is unhealthy not offering it back to pool")) {
                                    throw e;
                                }
                            }
                            catch (Throwable e) {
                                System.out.println("Release error: " + e.getClass().getName() + ": " + e.getMessage());
                            }
                        }
                    }
                    catch (Throwable e) {
                        System.out.println("Error: " + e.getClass().getName() + ": " + e.getMessage());
                    }
                    latch.countDown();
                }
            });
        }
        latch.await();
        Thread.sleep(500);

//        assertEquals(channels.size(), handler.channelCount());
//        assertEquals(rounds.get() - channels.size(), handler.acquiredCount());
//        assertEquals(rounds.get(), handler.releasedCount());

        sc.close().syncUninterruptibly();
        for (Channel channel : channels) {
            channel.close().syncUninterruptibly();
        }
        group.shutdownGracefully();

        // Check internal acquired count.
        Field acquiredChannelCountField = FixedChannelPool.class.getDeclaredField("acquiredChannelCount");
        acquiredChannelCountField.setAccessible(true);
        int acquiredChannelCount = (Integer) acquiredChannelCountField.get(pool);
        assertEquals(0, acquiredChannelCount);
    }

To make it easier I just adjusted the code you provided and not did any more changes there.

@normanmaurer Thank you for the very quick reply. I did see that as well and modified the test. Newest version is pushed to my fork, but I'm still seeing the error. Full test output:
/usr/lib/jvm/java-8-oracle/bin/java -ea -server -dsa -da -ea:io.netty... -XX:+AggressiveOpts -XX:+TieredCompilation -XX:+UseBiasedLocking -XX:+UseFastAccessorMethods -XX:+OptimizeStringConcat -XX:+HeapDumpOnOutOfMemoryError -Xbootclasspath/p:/home/kenn/.m2/repository/org/mortbay/jetty/alpn/alpn-boot/8.1.6.v20151105/alpn-boot-8.1.6.v20151105.jar -D_ -D_ -Didea.launcher.port=7533 -Didea.launcher.bin.path=/home/kenn/Storage/local/idea-IC-143.381.42/bin -Didea.junit.sm_runner -Dfile.encoding=UTF-8 -classpath /home/kenn/Storage/local/idea-IC-143.381.42/lib/idea_rt.jar:/home/kenn/Storage/local/idea-IC-143.381.42/plugins/junit/lib/junit-rt.jar:/usr/lib/jvm/java-8-oracle/jre/lib/jfr.jar:/usr/lib/jvm/java-8-oracle/jre/lib/resources.jar:/usr/lib/jvm/java-8-oracle/jre/lib/charsets.jar:/usr/lib/jvm/java-8-oracle/jre/lib/jsse.jar:/usr/lib/jvm/java-8-oracle/jre/lib/plugin.jar:/usr/lib/jvm/java-8-oracle/jre/lib/jce.jar:/usr/lib/jvm/java-8-oracle/jre/lib/javaws.jar:/usr/lib/jvm/java-8-oracle/jre/lib/deploy.jar:/usr/lib/jvm/java-8-oracle/jre/lib/rt.jar:/usr/lib/jvm/java-8-oracle/jre/lib/management-agent.jar:/usr/lib/jvm/java-8-oracle/jre/lib/jfxswt.jar:/usr/lib/jvm/java-8-oracle/jre/lib/ext/jfxrt.jar:/usr/lib/jvm/java-8-oracle/jre/lib/ext/cldrdata.jar:/usr/lib/jvm/java-8-oracle/jre/lib/ext/localedata.jar:/usr/lib/jvm/java-8-oracle/jre/lib/ext/dnsns.jar:/usr/lib/jvm/java-8-oracle/jre/lib/ext/sunpkcs11.jar:/usr/lib/jvm/java-8-oracle/jre/lib/ext/nashorn.jar:/usr/lib/jvm/java-8-oracle/jre/lib/ext/sunjce_provider.jar:/usr/lib/jvm/java-8-oracle/jre/lib/ext/sunec.jar:/usr/lib/jvm/java-8-oracle/jre/lib/ext/zipfs.jar:/home/kenn/Projects/netty/transport/target/test-classes:/home/kenn/Projects/netty/transport/target/classes:/home/kenn/Projects/netty/buffer/target/classes:/home/kenn/Projects/netty/common/target/classes:/home/kenn/.m2/repository/org/javassist/javassist/3.19.0-GA/javassist-3.19.0-GA.jar:/home/kenn/.m2/repository/junit/junit/4.12/junit-4.12.jar:/home/kenn/.m2/repository/org/hamcrest/hamcrest-core/1.3/hamcrest-core-1.3.jar:/home/kenn/.m2/repository/org/hamcrest/hamcrest-library/1.3/hamcrest-library-1.3.jar:/home/kenn/.m2/repository/org/easymock/easymock/3.2/easymock-3.2.jar:/home/kenn/.m2/repository/cglib/cglib-nodep/2.2.2/cglib-nodep-2.2.2.jar:/home/kenn/.m2/repository/org/objenesis/objenesis/1.3/objenesis-1.3.jar:/home/kenn/.m2/repository/org/easymock/easymockclassextension/3.2/easymockclassextension-3.2.jar:/home/kenn/.m2/repository/org/jmock/jmock-junit4/2.6.0/jmock-junit4-2.6.0.jar:/home/kenn/.m2/repository/org/jmock/jmock/2.6.0/jmock-2.6.0.jar:/home/kenn/.m2/repository/org/mockito/mockito-core/1.10.8/mockito-core-1.10.8.jar:/home/kenn/.m2/repository/ch/qos/logback/logback-classic/1.0.13/logback-classic-1.0.13.jar:/home/kenn/.m2/repository/ch/qos/logback/logback-core/1.0.13/logback-core-1.0.13.jar:/home/kenn/.m2/repository/org/slf4j/slf4j-api/1.7.5/slf4j-api-1.7.5.jar com.intellij.rt.execution.application.AppMain com.intellij.rt.execution.junit.JUnitStarter -ideVersion5 io.netty.channel.pool.FixedChannelPoolTest,testAcquireReleaseMany "Until Failure"
10:53:35.502 [main] DEBUG i.n.u.i.l.InternalLoggerFactory - Using SLF4J as the default logging framework
10:53:35.506 [main] DEBUG i.n.c.MultithreadEventLoopGroup - -Dio.netty.eventLoopThreads: 16
10:53:35.513 [main] DEBUG i.n.util.internal.PlatformDependent0 - java.nio.Buffer.address: available
10:53:35.513 [main] DEBUG i.n.util.internal.PlatformDependent0 - sun.misc.Unsafe.theUnsafe: available
10:53:35.514 [main] DEBUG i.n.util.internal.PlatformDependent0 - sun.misc.Unsafe.copyMemory: available
10:53:35.514 [main] DEBUG i.n.util.internal.PlatformDependent0 - java.nio.Bits.unaligned: true
10:53:35.515 [main] DEBUG i.n.util.internal.PlatformDependent - Java version: 8
10:53:35.515 [main] DEBUG i.n.util.internal.PlatformDependent - -Dio.netty.noUnsafe: false
10:53:35.515 [main] DEBUG i.n.util.internal.PlatformDependent - sun.misc.Unsafe: available
10:53:35.515 [main] DEBUG i.n.util.internal.PlatformDependent - -Dio.netty.noJavassist: false
10:53:35.632 [main] DEBUG i.n.util.internal.PlatformDependent - Javassist: available
10:53:35.632 [main] DEBUG i.n.util.internal.PlatformDependent - -Dio.netty.tmpdir: /tmp (java.io.tmpdir)
10:53:35.632 [main] DEBUG i.n.util.internal.PlatformDependent - -Dio.netty.bitMode: 64 (sun.arch.data.model)
10:53:35.633 [main] DEBUG i.n.util.internal.PlatformDependent - -Dio.netty.noPreferDirect: false
10:53:35.678 [main] DEBUG i.n.util.internal.ThreadLocalRandom - -Dio.netty.initialSeedUniquifier: 0x38319457c435ea7c (took 15 ms)
10:53:35.712 [main] DEBUG io.netty.buffer.ByteBufUtil - -Dio.netty.allocator.type: unpooled
10:53:35.713 [main] DEBUG io.netty.buffer.ByteBufUtil - -Dio.netty.threadLocalDirectBufferSize: 65536
10:53:35.713 [main] DEBUG io.netty.buffer.ByteBufUtil - -Dio.netty.maxThreadLocalCharBufferSize: 16384
Acquire error: java.nio.channels.ClosedChannelException: null
Acquire error: java.nio.channels.ClosedChannelException: null
Acquire error: java.nio.channels.ClosedChannelException: null
Acquire error: java.nio.channels.ClosedChannelException: null
Acquire error: java.nio.channels.ClosedChannelException: null

java.lang.AssertionError:
Expected :0
Actual   :8
  <Click to see difference>

	at org.junit.Assert.fail(Assert.java:88)
	at org.junit.Assert.failNotEquals(Assert.java:834)
	at org.junit.Assert.assertEquals(Assert.java:645)
	at org.junit.Assert.assertEquals(Assert.java:631)
	at io.netty.channel.pool.FixedChannelPoolTest.testAcquireReleaseMany(FixedChannelPoolTest.java:409)
	at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
	at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
	at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
	at java.lang.reflect.Method.invoke(Method.java:497)
	at org.junit.runners.model.FrameworkMethod$1.runReflectiveCall(FrameworkMethod.java:50)
	at org.junit.internal.runners.model.ReflectiveCallable.run(ReflectiveCallable.java:12)
	at org.junit.runners.model.FrameworkMethod.invokeExplosively(FrameworkMethod.java:47)
	at org.junit.internal.runners.statements.InvokeMethod.evaluate(InvokeMethod.java:17)
	at org.junit.runners.ParentRunner.runLeaf(ParentRunner.java:325)
	at org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:78)
	at org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:57)
	at org.junit.runners.ParentRunner$3.run(ParentRunner.java:290)
	at org.junit.runners.ParentRunner$1.schedule(ParentRunner.java:71)
	at org.junit.runners.ParentRunner.runChildren(ParentRunner.java:288)
	at org.junit.runners.ParentRunner.access$000(ParentRunner.java:58)
	at org.junit.runners.ParentRunner$2.evaluate(ParentRunner.java:268)
	at org.junit.runners.ParentRunner.run(ParentRunner.java:363)
	at org.junit.runner.JUnitCore.run(JUnitCore.java:137)
	at com.intellij.junit4.JUnit4IdeaTestRunner.startRunnerWithArgs(JUnit4IdeaTestRunner.java:136)
	at com.intellij.rt.execution.junit.JUnitStarter.prepareStreamsAndStart(JUnitStarter.java:234)
	at com.intellij.rt.execution.junit.JUnitStarter.main(JUnitStarter.java:74)
	at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
	at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
	at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
	at java.lang.reflect.Method.invoke(Method.java:497)
	at com.intellij.rt.execution.application.AppMain.main(AppMain.java:144)

Process finished with exit code 255

I also see quite a few "connection refused" exceptions, but I'm not sure they are related to the bug so I've filtered them out. While it didn't happen this time, usually the discrepancy is exactly equal to the number of ClosedChannelException seen. Not sure if this is related though.
Could it be that the acquire code will increment the internal counter even if the acquire failed?

@normanmaurer Sorry I completely missed your point about properly waiting for the latch. You are quite right, that was an oversight on my part. I will close this issue and continue to look for the error in my own code, I must be using the channel pools wrong or something.


[Flaky test] OpChainSchedulerServiceTest

Example run:
https://github.com/apache/pinot/actions/runs/4266643576/jobs/7427410628

@61yao

Ack. Will take a look.


Custom symbols aren't showing up

examplesymbol.zip

Fixed in https://github.com/TerryCavanagh/diceymodgeons/commit/990ad5f0303cff6cfa246607a8aa16802dddcc0f! Thanks!


feat: Add HTML export option ↗

The HTML export is functional now. This was a pretty straightforward implementation.  Either way is fine, ig.

Harshit Raj
Senior Undergraduate
CSE, IIT Kanpur
harshitraj.xyzhttps://harshitraj.xyz/

From: Rashmi G R @.>
Sent: Friday, November 17, 2023 12:22 AM
To: 1-Harshit/ed-eater @.>
Cc: Harshit Raj @.>; Mention @.>
Subject: Re: [1-Harshit/ed-eater] feat: Add HTML export option ↗ (PR #29)
@rashmigr01 commented on this pull request.

In src/components/editor/EditorAreaMenu.tsxhttps://github.com/1-Harshit/ed-eater/pull/29#discussion_r1396192677:

                const blob = new Blob([htmlToSave], { type: "text/html" });

                  const fileName = "ed-eater.html";

                  const url = URL.createObjectURL(blob);

                  const a = document.createElement("a");

                  a.href = url;

                  a.download = fileName;

                  document.body.appendChild(a);

                  a.click();

                  URL.revokeObjectURL(url);

                  document.body.removeChild(a);

          } else {

                  alert("There is no content to save as HTML.");

When the editor is cleared out(with no content), the alert pops up because the inner HTML is entirely empty. It doesn't contain the template HTML (header, body..) code. So, I thought an alert was preferable. Do you think a blank HTML file should be downloaded instead?
—
Reply to this email directly, view it on GitHubhttps://github.com/1-Harshit/ed-eater/pull/29#discussion_r1396192677, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AR5WKUERWXWOSTN7ZDIORYLYEZOIXAVCNFSM6AAAAAA7NVWPZKVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMYTOMZVGIYDSOJUGY.
You are receiving this because you were mentioned.Message ID: @.***>

Sure, I'll let them download an empty file then 😆

@rashmigr01 I have got this weird feeling that if I export html and then read the same HTML my editor won't allow that. I guess we should also extend reading logic to HTML. Comments?

Reformatting done:

Abstract download function
Clear prop logic, shift to function
Allow empty file downloads

@1-Harshit Do you mean that we should allow HTML files in out 'Open' option implementation?

Yup, do want to extend the reading logic?
AND if you do please take care or #23 as well, pretty please.

@1-Harshit Do you mean that we should allow HTML files in out 'Open' option implementation?

Yup, do want to extend the reading logic? AND if you do please take care or #23 as well, pretty please.

Sure, I'll add the read logic here and a separate PR for the size limit issue


Add Beckfoot Oakbank Academy

http://www.oakbank.org.uk/
http://www.oakbank.org.uk/wp-content/uploads/depts/sixth/ict-computing-courses.pdf

@JoeCalvert Pull request merged. Thank you!
For the record: this is the page with official proof that the domain belongs to this school: http://www.oakbank.org.uk/notice-to-all-beckfoot-oakbank-students/

Cheers!


Upgrade to Spring Boot 2.6.0

Description
Describe the changes made and why they were made.
Ignore if these details are present on the associated Apache Fineract JIRA ticket.
Checklist
Please make sure these boxes are checked before submitting your pull request - thanks!

[x] Write the commit message as per https://github.com/apache/fineract/#pull-requests

[x] Acknowledge that we will not review PRs that are not passing the build ("green") - it is your responsibility to get a proposed PR to pass the build, not primarily the project's maintainers.

[x] Create/update unit or integration tests for verifying the changes made.

[x] Follow coding conventions at https://cwiki.apache.org/confluence/display/FINERACT/Coding+Conventions.

[x] Add required Swagger annotation and update API documentation at fineract-provider/src/main/resources/static/api-docs/apiLive.htm with details of any API changes

[x] Submission is not a "code dump".  (Large changes can be made "in repository" via a branch.  Ask on the developer mailing list for guidance, if required.)

FYI our guidelines for code reviews are at https://cwiki.apache.org/confluence/display/FINERACT/Code+Review+Guide.

@vidakovic This upgrades the Spring Boot to 2.6.0 - an upgrade that was unblocked by the config file rework. If you can approve and merge this, as next step I'll then rework the OAuth and twofactor authentication, and write some test cases for both of them.

Overall looks good to me. Just one caveat: at the moment there is no compatible Spring Cloud release for Spring Boot 2.6.0. Just in case someone is using that combination in customized projects. For the Fineract release it's irrelevant.

Overall looks good to me. Just one caveat: at the moment there is no compatible Spring Cloud release for Spring Boot 2.6.0. Just in case someone is using that combination in customized projects. For the Fineract release it's irrelevant.
@ptuomola any ideas why the Travis stuff is failing? Other than that I think this can be approved.

The GitHub Gradle build runs exactly the same code as the Travis one, so I think we're safe here. Overall I think the Travis is much more susceptible to all kinds of disturbances (load, timing etc) than the GitHub one - and the Github is faster. I think we should reduce the Travis one to just run the SonarQube analysis (as that can't be integrated to GitHub).


rustup: bring in Miri backtrace-rs pruning fix

The pruning logic in backtrace has always been broken in Miri. But now there's a fix!

@bors r+

:pushpin: Commit 4f30af52738c163c39e1d928c36664e627ee31db has been approved by saethlin
It is now in the queue for this repository.

:hourglass: Testing commit 4f30af52738c163c39e1d928c36664e627ee31db with merge b8a97c4b975a4d75cafc267c9bb20f26d8fae292...

:sunny: Test successful - checks-actions
Approved by: saethlin
Pushing b8a97c4b975a4d75cafc267c9bb20f26d8fae292 to master...


qiskit/visualization/state_visualization.py needs testing

The code in qiskit/visualization/state_visualization.py needs testing. Current coverage is:

file
statements
missing
coverage

qiskit/visualization/state_visualization.py
392
369
6%

(This is a follow up from https://github.com/Qiskit/qiskit-terra/issues/300#issuecomment-489324685)

Still a valid issue: https://coveralls.io/builds/24960860/source?filename=qiskit/visualization/state_visualization.py

on hold until #2968 is decided.

Is this still workable?

@gabriellm1 it is! Probably following the https://github.com/Qiskit/qiskit-terra/pull/4544 style.

can I work on this? This is my first issue.

hi @gabriellm1 are you working on this? If not I will assign to @abzsd

Go ahead guys :)

thanks @gabriellm1 😄 @abzsd I'm assigning to you, let us know if you have any questions

Update for Santa:elf:- QGoGP
✅ state_visualization.py is now 56.84% covered! (improvement over the 6% at start but a dedicated test would be great!) https://coveralls.io/builds/44969725/source?filename=qiskit%2Fvisualization%2Fstate_visualization.py
Will update comment/add more comments if cause is found/fixed!

Python version 3.9.7
qiskit-terra version: 0.19.1

Did you have any change to have a look @abzsd ?

Hi If @abzsd is no longer working on this issue, I'd love to be assigned and write the tests.

reassigned to @smturro2 due to no response from @abzsd 😄 Let us know if you need any assistance @smturro2! You can review the snapshot testing instructions in the contributing guidelines for guidance on mpl testing

Hi @javabster thanks for assigning the issue. There seems to be tests in the snapshot testing for many of the functions in state_visualization. Was there specific tests in mind?

ah yes I see what you mean @smturro2! By checking the link to the coverage report I can see there are still quite a few lines (highlighted in red) that don't have test coverage. Some of these could be covered by more snapshot tests (e.g. adding another snapshot test with different arguments) and others could be covered by regular unit tests (e.g. I see a lot of the lines that raise errors are uncovered, it would be good to write unit tests that check the error is raised correctly). You don't need to reach 100% coverage, but I think if we could reach 80% coverage that would be great!

I don't think we actually catch the snapshot tests in the coverage report - all the snapshots are in test/ipynb, but the coverage report just runs stestr run, which only looks in test/python.  So we actually probably have slightly better coverage than it looks like we do, but we're not detecting it.
That said, we're definitely under-testing the visualisation modules, so any further efforts to help out on them are always welcome!

Hi @smturro2 are you still working on this issue?

@javabster im no longer working on this👍🏻

ok thanks for letting me know, I'll unassign you so that others can jump in if they would like to work on it :)

sure thing @PSD-20, I'll assign to you! If you haven't contributed to terra before please read the contributing guide, and if you are new to open-source/github in general you might find these videos  helpful.

Ohk. Also, Can you please assist me with how I should begin with this particular issue.

Hi @PSD-20 to get started with this you can see the coverage report for this file here: https://coveralls.io/builds/61022961/source?filename=qiskit%2Fvisualization%2Fstate_visualization.py
As you can see there are lots of lines of code highlighted in red, which means that they are lacking tests to cover them. So you would need to write some tests that would cover these lines of code. You can see examples of other tests for the visualisation module in test/python/visualization.

Hi, is this issue open and not assigned, could I work on this issue?


fix(bazel-extractor): update docker image for c++17

we can't get a new enough clang/libstdc++ using the gcr.io bazel image,
so I switched to debian sid.

Fixes #4401.


download composer dependencies in parallel

testing... do not merge yet

Not a big fan of a new dependency for this to be honest =)

Its just a perf related change (dev only). Since the build doesnt take hours I am fine with closing it unmerged.


POL-36 AWS Unencrypted RDS instances

initial release for POL-36 AWS Unencrypted RDS instances
Description
This policy checks all Relational Database Service (RDS) instances and reports on any that are unencrypted. When such an RDS instance is detected, the user can choose to delete by enabling 'delete action' option as mentioned in Enable delete action section below.
Issues Resolved
When an Unencrypted RDS instance is detected, an email action is triggered automatically to notify the specified users of the incident. Users then have the option to delete the RDS instance after manual approval if needed.
Contribution Check List

[x] All tests pass.
[x] New functionality includes testing.
[x] New functionality has been documented in the README if applicable
[x] New functionality has been documented in CHANGELOG.MD

Running Template Link:
https://governance.rightscale.com/org/1105/projects/60073/policy-incidents/5cdd392438e25e007152d7c9
Screenshot:

Approving, looks fine from my end for the most part, though I think there's may be one more mistake at least, in that your check is wrong. Check is asserting what you want to happen -- should probably be
check val(item, "storage_encrypted")

It looks like storage_encrypted is a boolean, rather than a string like "false" -- well it should be easy to figure out in testing. When its a boolean can just feed the result to check directly and not have the eq().

Thanks, @psschroeter I updated and even I tried to call API in 'datasource' and its working as expected.


FCS_RBG_EXT.1 Random Bit Generation

This is sel-based but is lacking a selection.
Also, need to include downstream selections of Hash and KeyedHash.

Added a selection from FCS_CKM.1/SK and some other stuff.


[DIST] pyinstaller for windows not working

the error was 'requests not found'. we may have to rebuild the docker image with a newer version of pyinstaller.

this has been resolved in the latest version of wsinfer-zoo. instead of requests, we use the huggingface hub client.


Port Machine's USFM generation changes to machine.py

Changes to USFM generation in Machine from https://github.com/sillsdev/machine/pull/160 need to be ported to machine.py.

Changes have already been ported from sillsdev/machine#160 and sillsdev/machine#163. However, there have been more USFM related changes in Machine since then that also need to be ported over.


Merge Stage to Main

Sync stage to main
Before: https://main--homepage--adobecom.hlx.page/homepage/index-loggedout?martech=off
After: https://stage--homepage--adobecom.hlx.page/homepage/index-loggedout?martech=off

I approved it for my part but I would highly recommend to get QA approved before merging it.


add a changelog

👋
This has been a lovely experience to quickly get a dark mode set up and running! In debugging a flash of styles in the dark mode switch, I went looking to see what has been changed since my version was outdated. It would be very helpful if you had a changelog to read for these situations.
Thanks again for your work here!

Glad to hear you're enjoying Nightwind!
And thanks for bringing this up, I've been thinking about adding a changelog for a while. Will do it later today!

Glad to hear you're enjoying Nightwind!
And thanks for bringing this up, I've been thinking about adding a changelog for a while. Will do it later today!

Closing this as I've added the Changelog.

Closing this as I've added the Changelog.


some https site can not be connected with HTTPSClient

can not connect some site. e.g. https://echo.websocket.org
https://www.ssllabs.com/ssltest/analyze.html?d=echo.websocket.org
Safari can respond 404 but HTTPSClient reset connection by peer
related
https://github.com/Zewo/OpenSSL/pull/13

Merged fix. for now OpenSSL does not specify cipher_list


[Model] Fix ActiveRecord sorted collection

This is a fix for #608.
It also introduces tests against ActiveRecord 5.0.
The fix about sorted records is cover by a test, but there are still 10 errors on other subjects when running tests with AR 5.
I'didn't run unit tests as they are already failing.

@inkstak You'll need to sign the contributor agreement: https://www.elastic.co/contributor-agreement
Would love for this to be merged in.

Confirm this fix works for me, without it result order is all over the place. Had to monkeypatch it in as Rails 5 has been out long enough.

@nickrivadeneira any updates on this?

@connorshea I'm not a elasticsearch member unfortunately, I was just making sure that instak signed the agreement so this could be merged in when the elasticsearch team looks at it. This repo seems to be dead though :( The person we need is @karmi

I confirm I signed the agreement. The github check is not up to date.

@inkstak, you were correct, the check has indeed been out of sync -- it's corrected now.
@nickrivadeneira, it's not dead, I just have a hard time keeping up with all the gems across the two repos. I'll pull the patch and verify locally and merge.

@karmi Makes sense. Thanks for looking into this one

Hi, I've merged the patch into master, many thanks for that, and apologies again for the delay. I'm not sure when I'll get to a release, but if you want a patch release with the change, I can do it anytime.
(So, one reason why processing PRs is not a simple "pull, run tests, rewrite commit message, push" is that I needed fix all this while doing the pull, so the tests are green and we can add more patches on top of the branch without fear...)

Thanks 👍


#762 fixed Navbar links and some other issues.

Some fixes here is probably not valid anymore since we updated the navbar. We happily merge the other changes if you update the pull request or make a new one :)

what?  I thought I fixed all the conflicts?  And it sounds like probably my hard work on the contributors page is moot anyway...?  :(  So I don't even know if it's worth fixing it all as it's all been done no?

I'm closing this.  Apparently someone else decided to make the contributor page look nice (the only thing that looks awful is that some of the cards with longer names throws off the neatness of the columns (that's one thing I did- just widened the width of the card-item).  So my contribution was pretty much wiped (and my ducky easter egg is gone as well).  Thank you for the chance to try though- I was super proud I was able to figure out the menu issue on the contributor page (drop down wouldn't open lol) before the massive overhaul done in the meantime and the design I did - I liked the black background lol.

@CQW-Code Sorry your pull requests didn't get merged :/ we get a lot of pull requests and we try to merge as many ass possible from everyone. Still good work and you should be proud ;)
Feel free to do new pull requests maybe one with just the easter egg? :)

I forgot the easter egg when I did the tools page! lol.. I'll add back soon.


Timestamp read from database is treated as if it was in JVM timezone

When reading a DateTime value I get a timestamp that is shifted back by my JVM timezone offset.
Server is in UTC, JVM in Europe/Warsaw (UTC+2). When I try to read a DateTime value 2021-08-13T11:00:00Z I get 2021-08-13T09:00:00Z.
Is this driver bug or am I doing something wrong?
I'm using clickhouse-jdbc 0.3.2-patch11 (revision: 27f8951). ClickHouse <IP_ADDRESS>.
package test;

import com.clickhouse.jdbc.ClickHouseConnection;
import com.clickhouse.jdbc.ClickHouseDataSource;
import com.clickhouse.jdbc.ClickHouseDriver;
import org.junit.jupiter.api.Assertions;
import org.junit.jupiter.api.Test;

import java.sql.Connection;
import java.sql.SQLException;
import java.time.Instant;
import java.util.Optional;
import java.util.TimeZone;

public class TimeTests {
    private final static String URL = "jdbc:clickhouse://localhost:18123/";
    private final static String USERNAME = "default";
    private final static String PASSWORD = "";

    static {
        System.out.println(ClickHouseDriver.class.getPackage().getImplementationVersion());
        TimeZone.setDefault(TimeZone.getTimeZone("Europe/Warsaw"));
    }

    @Test
    void testReading() throws SQLException {
        var dataSource = new ClickHouseDataSource(URL);
        try (var conn = dataSource.getConnection(USERNAME, PASSWORD)) {
            prepareTestTable(conn);

            execSql("INSERT INTO dates(d) VALUES (toDateTime(toUnixTimestamp('2021-08-13 11:00:00', 'UTC'), 'UTC'))", conn);

            try (var stmt = conn.createStatement()) {
                var rs = stmt.executeQuery("SELECT formatDateTime(d, '%F %T'), toUnixTimestamp(d), d FROM dates");
                Assertions.assertTrue(rs.next());
                Assertions.assertEquals("2021-08-13 11:00:00", rs.getString(1));
                Assertions.assertEquals(Instant.parse("2021-08-13T11:00:00Z"), Instant.ofEpochSecond(rs.getLong(2)));
                var ts = rs.getTimestamp(3);
                // Assertion below fails with:
                // Expected :2021-08-13T11:00:00Z
                // Actual   :2021-08-13T09:00:00Z
                // looks like UTC date from server was treated as if it was in JVM TZ (Europe/Warsaw = UTC+2)
                Assertions.assertEquals(Instant.parse("2021-08-13T11:00:00Z"), ts.toInstant());
            }
        }
    }

    void prepareTestTable(ClickHouseConnection conn) throws SQLException {
        Assertions.assertEquals(TimeZone.getTimeZone("UTC"), conn.getServerTimeZone());
        Assertions.assertEquals(TimeZone.getTimeZone("Europe/Warsaw"), conn.getJvmTimeZone());
        Assertions.assertEquals(Optional.empty(), conn.getEffectiveTimeZone());

        execSql("DROP TABLE IF EXISTS dates", conn);
        execSql("CREATE TABLE dates (d DateTime) ENGINE=Memory", conn);
    }

    void execSql(String sql, Connection conn) throws SQLException {
        try (var stmt = conn.createStatement()) {
            stmt.execute(sql);
        }
    }

}

I believe the issue is in the way getTimestamp works. Value is read correctly from database, as 2021-08-13 11:00:00 at UTC:

but here:
https://github.com/ClickHouse/clickhouse-jdbc/blob/27f8951cdc380bf1799f76efc21fc377fc6d5981/clickhouse-jdbc/src/main/java/com/clickhouse/jdbc/ClickHouseResultSet.java#L626-L634
it's read into dt as LocalDateTime(2021-08-13T11:00) (tz is null here, but both possible code paths give the same result). Then it's copied into defaultCalendar which is at JVM's time zone.

Hi @piotrp, sorry for the late response. The behavior is same as MySQL and legacy driver, but I agree that use_server_time_zone option is really confusing. Perhaps you can use DateTime column with timezone argument or use_time_zone option as shown in below example?
https://github.com/ClickHouse/clickhouse-jdbc/blob/f285b73d45597e29cf36dff4daf4cb4f9f53453a/clickhouse-jdbc/src/test/java/com/clickhouse/jdbc/ClickHouseStatementTest.java#L578-L593

No, the legacy driver worked correctly. I stumbled upon this issue when I tried upgrading and my JDBC code using getTimestamp failed.
I created a test case at https://github.com/piotrp/clickhouse-driver-issue-1048, where you can see that the same test passes when run with legacy driver, and fails with the new one. I also added a test demonstrating that round trip with setTimestamp/getTimesatamp doesn't work correctly. This should be runnable under Java 17 by:
docker-compose up -d
mvn --fail-at-end test

Thanks for this pointer, for now I worked around this by using getObject(.., Instant.class). Fortunately I'm using hand-crafted row mappers, so it was easy to do.

Thanks for sharing the test case. Legacy driver does not support timezone very well mainly due to the text-based data format. It's been enhanced in the new driver and this test case was added to ensure the driver works in the same way as MySQL.
It's recommended to use getObject instead of getTimestamp/getDate not only because it turns LocalDate/LocalDateTime/OffsetDateTime over legacy Date/Timestamp, but also ~10x better performance.
Let me see if I can fix this together with #955.

Timezone is now taken also from server response (in case of http). This should solve the issue.


Sider menu disappear when close and restart the app

Describe the bug

Sider menu disappear when close and restart the app.
To Reproduce

open guppy
import exist project
close guppy
open guppy again. Sider menu disapper

Expected behavior

The side menu is always displayed.
Or there is other way to show sider menu (click a button?)
Screenshots

Environment (please complete the following information):

OS: Mac OS 10.13.3
Version: 0.2
Node version: v8.9.1

Additional context
If i create a new project or import a exist project, sider appear again.

Today, i tried to use electronStore.set(‘redux-state’, null) to reset redux-state in devtool.
it seem work well after restart guppy. I have used version v0.0.1.  I don't know if it is because of this.

My guess is that this will be fixed in 0.3 when it's released, but release may still be a ways away


[Bug][package_info_plus]: version is different on iOS and android

Platform
iOS Simulator (iOS 15.4) and physical iPhone 6 (iOS 12.5.5)
Plugin
package_info_plus:
Version
1.3.0
Flutter SDK
flutter stable 3.0.1
Steps to reproduce
Given the following version in pubspec.yaml (which follow https://semver.org/ convention):
version: 0.3.7-alpha+42
When on android,
ìnfo.version` returns "0.3.7-alpha"
When on iOS
ìnfo.version` returns just "0.3.7"
Expected behvaviour would be that this package returns the same value for ìnfo.,version` independent of the platform.
Code Sample
No response
Logs
-

Flutter Doctor
[√] Flutter (Channel stable, 3.0.1, on Microsoft Windows [Version 10.0.19043.1766], locale de-DE)
    • Flutter version 3.0.1 at C:\src\flutter
    • Upstream repository https://github.com/flutter/flutter.git
    • Framework revision fb57da5f94 (5 weeks ago), 2022-05-19 15:50:29 -0700
    • Engine revision caaafc5604
    • Dart version 2.17.1
    • DevTools version 2.12.2

[√] Android toolchain - develop for Android devices (Android SDK version 30.0.2)
    • Android SDK at C:\Users\user\AppData\Local\Android\sdk
    • Platform android-31, build-tools 30.0.2
    • Java binary at: C:\Program Files\Android\Android Studio\jre\bin\java
    • Java version OpenJDK Runtime Environment (build 1.8.0_242-release-1644-b01)
    • All Android licenses accepted.

[√] Chrome - develop for the web
    • Chrome at C:\Program Files\Google\Chrome\Application\chrome.exe

[!] Visual Studio - develop for Windows (Visual Studio Build Tools 2017 15.9.34)
    • Visual Studio at C:\Program Files (x86)\Microsoft Visual Studio\2017\BuildTools
    • Visual Studio Build Tools 2017 version 15.9.28307.1440
    • Windows 10 SDK version 10.0.17763.0
    X Visual Studio 2019 or later is required.
      Download at https://visualstudio.microsoft.com/downloads/.
      Please install the "Desktop development with C++" workload, including all of its default components

[√] Android Studio (version 4.1)
    • Android Studio at C:\Program Files\Android\Android Studio
    • Flutter plugin can be installed from:
       https://plugins.jetbrains.com/plugin/9212-flutter
    • Dart plugin can be installed from:
       https://plugins.jetbrains.com/plugin/6351-dart
    • Java version OpenJDK Runtime Environment (build 1.8.0_242-release-1644-b01)

[√] IntelliJ IDEA Community Edition (version 2021.2)
    • IntelliJ at C:\Program Files\JetBrains\IntelliJ IDEA Community Edition 2021.2
    • Flutter plugin can be installed from:
       https://plugins.jetbrains.com/plugin/9212-flutter
    • Dart plugin can be installed from:
       https://plugins.jetbrains.com/plugin/6351-dart

[√] VS Code (version 1.68.0)
    • VS Code at C:\Users\user\AppData\Local\Programs\Microsoft VS Code
    • Flutter extension version 3.42.0

[√] Connected device (4 available)
    • sdk gphone x86 (mobile) • emulator-5554 • android-x86    • Android 11 (API 30) (emulator)
    • Windows (desktop)       • windows       • windows-x64    • Microsoft Windows [Version 10.0.19043.1766]    • Chrome (web)            • chrome        • web-javascript • Google Chrome 102.0.5005.115
    • Edge (web)              • edge          • web-javascript • Microsoft Edge 100.0.1185.44

[√] HTTP Host Availability
    • All required HTTP hosts are available

! Doctor found issues in 1 category.

still waiting for a response here

I am not sure what you expect, the plugin is simply providing what Flutter puts on the info.plist. If Flutter is not copying over the -alpha part, it is not on the plugins fault.
You should report this to the flutter/flutter project.

Well, the expected behaviour is as I wrote in the original question.
That the issue originates from Flutter and not from this plugin is an important inside which I didn't have until now.
Then I agree obviously, but nevertheless it would be nice to have this problem fixed. Will report this on Flutter


⚠ BCR Bot has degraded performance

In 69a1f08, BCR Bot (https://bcr.alternativasinteligentes.com/BCRApi/web/chatbot) experienced degraded performance:

HTTP code: 200
Response time: 823 ms

Resolved: BCR Bot performance has improved in 9b265d1.


V0p3p8a

Codecov Report

Merging #95 (808ef77) into master (18f7b83) will increase coverage by 6.69%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master      #95      +/-   ##
==========================================
+ Coverage   78.64%   85.34%   +6.69%
==========================================
  Files           5        4       -1
  Lines         459      423      -36
==========================================
  Hits          361      361
+ Misses         98       62      -36

Impacted Files
Coverage Δ

src/IndividualDisplacements.jl
75.00% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 18f7b83...808ef77. Read the comment docs.