kubernetes-dashboard and tiller won't connect to Kubernetes API on fresh install

Rancher Versions:
Server: 1.3.3
kubernetes (if applicable): 1.5.1
Docker Version:
1.12.3
OS and where are the hosts located? (cloud, bare metal, etc):
Single RancherOS host running on a VM.
Setup Details: (single node rancher vs. HA rancher, internal DB vs. external DB)
Single node rancher.
Environment Type: (Cattle/Kubernetes/Swarm/Mesos)
Single Kubernetes environment.
Steps to Reproduce:
I've now been able to replicate this twice (both fresh installs) on two different remote VMs (one private cloud and one public cloud), but didn't see this problem when I used VirtualBox running on my own laptop.
Results:
Neither kubernetes-dashboard nor tiller are able to connect to the Kubernetes API. On kubernetes-dashboard I see this in the logs:
Using HTTP port: 9090
Creating API server client for https://<IP_ADDRESS>:443
Error while initializing connection to Kubernetes apiserver. This most likely means that the cluster is misconfigured (e.g., it has invalid apiserver certificates or service accounts configuration) or the --apiserver-host param points to a server that does not exist. Reason: the server has asked for the client to provide credentials
Refer to the troubleshooting guide for more information: https://github.com/kubernetes/dashboard/blob/master/docs/user-guide/troubleshooting.md

and on tiller I see this:
Cannot initialize Kubernetes connection: the server has asked for the client to provide credentialspanic: runtime error: invalid memory address or nil pointer dereference
[signal SIGSEGV: segmentation violation code=0x1 addr=0x28 pc=0x401a19]

goroutine 1 [running]:
panic(0x155bd80, 0xc42000a030)
	/usr/local/go/src/runtime/panic.go:500 +0x1a1
main.start(0x201e620, 0x2051450, 0x0, 0x0)
	/home/ubuntu/.go_workspace/src/k8s.io/helm/cmd/tiller/tiller.go:93 +0x739
k8s.io/helm/vendor/github.com/spf13/cobra.(*Command).execute(0x201e620, 0xc42000a250, 0x0, 0x0, 0x201e620, 0xc42000a250)
	/home/ubuntu/.go_workspace/src/k8s.io/helm/vendor/github.com/spf13/cobra/command.go:603 +0x439
k8s.io/helm/vendor/github.com/spf13/cobra.(*Command).ExecuteC(0x201e620, 0x0, 0x1708aa4, 0x12)
	/home/ubuntu/.go_workspace/src/k8s.io/helm/vendor/github.com/spf13/cobra/command.go:689 +0x367
k8s.io/helm/vendor/github.com/spf13/cobra.(*Command).Execute(0x201e620, 0x2051144, 0x16f6045)
	/home/ubuntu/.go_workspace/src/k8s.io/helm/vendor/github.com/spf13/cobra/command.go:648 +0x2b
main.main()
	/home/ubuntu/.go_workspace/src/k8s.io/helm/cmd/tiller/tiller.go:80 +0x16c

In both cases, this seems to be the pertinent bit:
Reason: the server has asked for the client to provide credentials

and seems to be indicating that the client is attempting to connect to the API without providing an authentication token.
Using one of the deployed containers, if I try to connect to the Kubernetes API without providing an authentication token (e.g. curl -k https://<IP_ADDRESS>:443) then I get an Unauthorized response, but I'm able to verify that I can connect to the API using the provided token as follows:
TOKEN_VALUE=$(cat /var/run/secrets/kubernetes.io/serviceaccount/token)
curl --cacert /var/run/secrets/kubernetes.io/serviceaccount/ca.crt -H "Authorization: Bearer $TOKEN_VALUE" https://<IP_ADDRESS>:443

By running kubectl get secrets --all-namespaces | grep service-account I'm able to find all of the service-account tokens that exist, and by running commands like get --namespace default -o jsonpath="{.data.token}" secret default-token-z00td | base64 -D for each of these, I can see that the correct token has been set everywhere.
Finally, by viewing the Kubernetes config in the API for the Dashboard I can see that it has a volume definition for /var/run/secrets/kubernetes.io/serviceaccount, though I'm unable to confirm this within the running container as the container doesn't start.
I've also tried installing more recent versions of Rancher (1.3.4, 1.4.0 and 1.4.1), and the problem also seems to occur in those, but with the downside that you no longer have the Rancher dashboard to help you debug what's going wrong in these more recent versions.
Any ideas on why this might be happening and/or where I go from here?

#7241 seems to be more or less the same issue.

I see the same issues on my install:
Rancher Versions:
Server: 1.4.1
kubernetes (if applicable): 1.5.2
Docker Version:
1.12.6
OS and where are the hosts located? (cloud, bare metal, etc):
Ubuntu 16.04 LTS virtual machine on hyper-v
Setup Details: (single node rancher vs. HA rancher, internal DB vs. external DB)
HA rancher, seperate DB
Environment Type: (Cattle/Kubernetes/Swarm/Mesos)
Cattle/Kubernetes environment.

I just tried installing tcpdump on the Kubernetes API container, and while I was able to observe packets coming from the kubernetes-dashboard container while it attempted to start, all of these were encrypted from the very start (TLS 1.2/1.3 I guess), so this wasn't at all helpful.
My understanding with these more recent versions of TLS is that it doesn't even help to have the keys as Diffie Hellman is now also used to provide perfect forward secrecy, so how does anyone debug this stuff?

I had the same problems with Docker 1.12.3, for me updating docker to 1.12.6 solved it.

Hi @silhouette, thanks for the suggestion, but this does not seem to have fixed things for me.
I upgraded the version of Docker used on one of the two clusters I have from 1.12.5 to 17.03.0-ce, and it seemed like it improved things because the 'Replicas' column now showed 1, instead of 0 of 1, but by viewing the logs I could see it still had the same error message (Reason: the server has asked for the client to provide credentials) as before.

@dchambers I've seen this on a fresh Rancher/k8s installation. At that time I spoke with one of my colleagues about it, and he said that the problem comes from how k8s handles authentication when not communicating over SSL.
Essentially, if the config contains auth credentials, but the target is using HTTP, kubectl/helm refuse to send the credentials. Rancher rejects the communication because it wants credentials.
I was able to get past this by putting an ELB up in environments where I could do that. In other environments I run HAProxy on the Rancher Server (for single server instances) or on a separate instance (for HA environments).  All of my communication is then to the load balancer and over SSL-backed TCP, with the load balancer talking to the Rancher servers over TCP. You want to use SSL/TCP instead of HTTP/S to avoid issues with websockets. Using self-signed certificates with k8s is a whole different issue, so if you have a real cert or can get one via LetsEncrypt or some other means, it will make your life easier.
Since making this change, all k8s environments that I spin up work perfectly the first time.
The other, less-interesting option is to remove authentication from Rancher Server. I don't recommend doing this, but if you have a test environment you can spin up, you'll see that with no auth on Rancher, k8s works over HTTP. Turn auth on in Rancher, and k8s will stop working until you communicate over an encrypted channel.
I hope this helps! If you need any asisstance with an HAProxy config or ELB guidance, I can provide additional guidance.

Hi @oskapt, sorry for the delay coming back to you, and thank you so much for the offer of help here!

Essentially, if the config contains auth credentials, but the target is using HTTP, kubectl/helm refuse to send the credentials. Rancher rejects the communication because it wants credentials.

This sounds vaguely plausible, but I don't really understand what's going on here well enough to be completely sure. One thing I am certain of is that I didn't set any auth credentials myself during the install.

I was able to get past this by putting an ELB up in environments where I could do that. In other environments I run HAProxy on the Rancher Server (for single server instances) or on a separate instance (for HA environments). All of my communication is then to the load balancer and over SSL-backed TCP, with the load balancer talking to the Rancher servers over TCP.

I don't think this can help me in my case because Helm and the Kubernetes Dashboard are communicating directly with the Kubernetes API using the kubernetes service defined within the default namespace -- so they just use the hostname kubernetes to do this. Therefore, it's my understanding that there is no ELB involved. However, it does seem likely that it will be an auth issue like you say.

The other, less-interesting option is to remove authentication from Rancher Server. I don't recommend doing this, but if you have a test environment you can spin up, you'll see that with no auth on Rancher, k8s works over HTTP.

This sounds promising! Can you please descrive how this is done and I'll give it a try?

@dchambers I've tried reproducing this on a few different setups and have been unsuccessful so far. All were tested with Rancher 1.3.3.

AWS on RancherOS v0.7.1
DigitalOcean with CoreOS stable
Locally ( Ubuntu 16.04 )

Have you run into this problem with Rancher 1.4.x or 1.5.x?
Another note, all Docker versions above 1.12.x are currently unsupported in Kubernetes.

@dchambers I've tried reproducing this on a few different setups and have been unsuccessful so far. All were tested with Rancher 1.3.3.

AWS on RancherOS v0.7.1
DigitalOcean with CoreOS stable
Locally ( Ubuntu 16.04 )

Hi @joshwget, thanks so much for trying all of this.

Have you run into this problem with Rancher 1.4.x or 1.5.x?

Yes, I've seen this problem on both 1.4.x and 1.5.x. I continue to use 1.3.3 only because it's the last version with an in-built Kubernetes dashboard.

Another note, all Docker versions above 1.12.x are currently unsupported in Kubernetes.

Okay, let me try upgrading the cluster with Docker 1.12.3 (the other cluster had Docker 1.12.5) to 1.12.6, and see if that helps...

@dchambers Can you share the Rancher registration URL used on the hosts in your setup? Are these communicating with Rancher via HTTP or HTTPS?

Hi @joshwget, it's like http://xxx.yyy.net:8080, so not https.

Are those really "fresh" installs on newly provisioned hosts (VMs, droplets, whatever)?
Because I have seen this problem when trying to start from scratch on a host. Deleting the containers is not enough, I also had to delete the volumes. Bringing up a rancher k8s environment on a cleaned hosts works for me.

I stumbled upon this issue while testing Kubernetes on Rancher (v1.5.6) with https://github.com/fayazg/tritonK8ssupervisor
This sets up a new environment completely automatically with Terraform and Ansible. I have done that about five times during the last two days. The kubernetes-dashboard has not come up a single time.
The error msg is always:
Using HTTP port: 9090
Creating API server client for https://<IP_ADDRESS>:443
Error while initializing connection to Kubernetes apiserver. This most likely means that the cluster is misconfigured (e.g., it has invalid apiserver certificates or service accounts configuration) or the --apiserver-host param points to a server that does not exist. Reason: the server has asked for the client to provide credentials
Refer to the troubleshooting guide for more information: https://github.com/kubernetes/dashboard/blob/master/docs/user-guide/troubleshooting.md
Here it tries to use https.

Apologies for not sharing sooner, but here's the work-around I was provided for this issue until a proper fix is made available.

The only I did differently was: kubectl -n kube-system delete services --all
at the last step. Then restarted the whole k8s stack and once it was all back the dashboard was working. Thanks, @dchambers !

We've fixed the stale secret issue as of v1.5.7 by moving how we install the secret. Fresh installs shouldn't hit this issue. The caveat is that if you upgrade to v1.5.7 and already had a broken k8s setup, it won't fix it.
If you clean up your hosts by following the docs on what to clean up after deleting k8s, you should have a clean set up.
http://docs.rancher.com/rancher/v1.6/en/kubernetes/deleting/

I had tried all the suggested fixes with not avail. I ended up editing the kubernetes template and turning on Enable Kubernetes role-based access control with integrated Rancher authentication.
And then set plane isolation to required and everything started working. Cost me about $75 more a month :)


Enable additional features by using sessionStorage

Description
Enable flagged features by acting on sessionStorage. For example:
Define a new feature flag
export type AvailableFeature = 'cost'

Open a browser tab with PCUI, then go to the console and type
window.sessionStorage.setItem('additionalFeatures', '["cost"]')

Reload the page and the cost flag will be active!
How Has This Been Tested?
Repeated the same procedure explained in the description (on Chrome)
PR Quality Checklist

[x] I added tests to new or existing code
[ ] I removed hardcoded strings and used react-i18next library (useTranslation hook and/or Trans component), see an example here
[ ] I made sure no sensitive info gets logged at any time in the codebase (see here) (e.g. no user info or details, no stacktraces, etc.)
[ ] I made sure that any GitHub issue solved by this PR is correctly linked
[ ] I checked that infrastructure/update_infrastructure.sh runs without any error
[x] I checked that npm run build builds without any error
[ ] I checked that clusters are listed correctly
[ ] I checked that a new cluster can be created (config is produced and dry run passes)
[ ] I checked that login and logout work as expected

In order to increase the likelihood of your contribution being accepted, please make sure you have read both the Contributing Guidelines and the Project Guidelines
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

praise: simple and effective!


I have input select and has options but my valid data is also shown in unmatch ?

I am using this   {
label: "Country",
key: "country",
fieldType: {
type: "select",
options: [     { label: "United States", value: "USA" },
{ label: "Canada", value: "Canada"},
{ label: "United Kingdom", value: "UK" },
{ label: "Australia", value: "Australia" },
{ label: "Other", value: "Other" }],
},
example: "Select your country",
validations: [
{
rule: "required",
errorMessage: "Country selection is required",
level: "error",
},
],
},
and in my csv i have Canada data but it show that Canada  is in unmatched data why ? does we have to write any validation rule if we want to pass valid data and gives select option only for invalid data ??

Hey @abhishekchauhan-ipseity this sounds like a duplicate of https://github.com/UgnisSoftware/react-spreadsheet-import/issues/141 if I understand correctly. If not feel free to reopen a ticket with an example file and configuration.


[DOC] Automated model interface generation on aws llms

What do you want to do?

[X] Request a change to existing documentation
[ ] Add new documentation
[ ] Report a technical problem with the documentation
[ ] Other

Tell us about your request. Provide a summary of the request.
We will enable automated model interface generation on AWS managed llms (Bedrock models, Comprehend APIs, Textract APIs)
*Version: List the OpenSearch version to which this issue applies, e.g. 2.14, 2.12--2.14, or all.
2.16
What other resources are available? Provide links to related issues, POCs, steps for testing, etc.
Connector we support:
All blueprints with Amazon or Bedrock prefix in docs folder will have this feature:
https://github.com/opensearch-project/ml-commons/tree/main/docs/remote_inference_blueprints

@b4sjoo - Will you be producing the doc PR?

@hdhalter Added!

@hdhalter Added!

Let me know if it needs a tech review or if it's ready for a doc review. Thanks!

@hdhalter I think it's ok to go for a doc review now


Add type: module to fix use in node

postcss-cli hates the shit out of ESM, so I made a manual build 🤷
To be clear we need to change to type: module because the component-classes are written in ESM.

I'm planning to squash and merge, so no need to reword commits, right?

I'm planning to squash and merge, so no need to reword commits, right?

Ah, so long as there's at least 1 commit that triggers a release such as fix: or feat: or a body with BREAKING CHANGE in it, it should trigger a release. Everything else won't but might be used in a changelog. Will your "Fix" commit trigger?

The commit message going back into main will be fix: use ESM to unbreak component-classes

@digitalsadhu - any concerns with this merging?

Go for it


Link to T&Cs and Privacy Policy from Menu

[ ] Link T&C link to G$ T&C
[ ] Link Privacy Policy to G$ Privacy policy

Privacy Policy - https://www.gooddollar.org/privacy-policy#
T&Cs - https://www.gooddollar.org/terms-of-use

@L03TJ3 another one to pick up if you have time this sprint :)

verified on feature branch

verified on prod


numberParser test

Hello ,
            esParser("3,14"); // -> 3.14
            esParser("3.14"); // -> 314

Having these lines of code I'd like to know if there is any way the 2nd console log returns NaN instead of 314.
I checked your repository tests and found this is the default behaviour but I'm working on a banking project and this way can bring me serious problems.

#353 needs to be implemented for that. Help very much appreciated. Closing in favor of #353.


Feature/apvs 1372/advance claims train update

Updated advance train claims to take return time

Added migration to have return time
Updated html to have return time
Updated insert expense for new field
Updated expense domains to account for new field
Updated validation on train expense
Updated e2e advance claim

Checklist

[x] Unit tests
[x] End-to-End tests
[x] Code coverage checked
[x] Coding standards

Make external site advance train expense claim description consistent with internal


Added extension 'setDistanceToRightEdge' to UIView

Checklist

[x] I checked the Contributing Guidelines before creating this request.
[x] New extensions are written in Swift 4.
[x] New extensions support iOS 8.0+ / tvOS 9.0+ / macOS 10.10+ / watchOS 2.0+.
[x] I have added tests for new extensions, and they passed.
[x] All extensions have a clear comments explaining their functionality, all parameters and return type in English.
[x] All extensions are declared as public.
[x] I have added a changelog entry describing my changes.

          4 Messages

:book:
Thank you for submitting a pull request to SwifterSwift. The team will review your submission as soon as possible.

:book:
iOS: Executed 540 tests, with 0 failures (0 unexpected) in 19.558 (22.795) seconds

:book:
tvOS: Executed 506 tests, with 0 failures (0 unexpected) in 3.604 (4.549) seconds

:book:
macOS: Executed 369 tests, with 0 failures (0 unexpected) in 1.771 (2.259) seconds

  Generated by :no_entry_sign: Danger


Refactored examples

I've switched to examples into using sqlite as proposed by @carllerche.
Futher, I'm proposing an refactored examples folder that would make it easier to run the examples from root, as well as run the examples using different databases using features. See the README file for the quickstart. I'm thinking that should make it quite easy for folks to get started.

@carllerche I reworked the cli a bit to be able to generate new examples easier, i though that would fit with the overall codegen vibe of this repo. See the README in toasty-examples for more info.

Thanks for taking a stab at this. I am with you that it should be easier to build the examples. I don't think adding "knowledge" of examples in the CLI is the way forward. Maybe open an issue to discuss ideas? I suspect a build.rs file will be the best way forward.


Expose django slugify in jinja filters

As a Network Automation Engineer, I want the django slugify utility function to be exposed for use in Nautobot jinija2 templates, so that I can have feature parity with the fact it is already exposed as a django template filter.
I will know this is complete when the django slugify function is exposed a registered jinja2 filter.

Hey team! Please add your planning poker estimate with Zenhub @glennmatthews @gsnider2195 @HanlinMiao @jathanism @timizuoebideri1


Vite environments (modes) and lasso

Vite supports multiple environments via specifying a flag --mode {stage} during build command: https://vitejs.dev/guide/env-and-mode.html
The problem is when building on local with lasso vite for some reason ignores these .env.{stage} files. In documentation it is said that:
In addition, environment variables that already exist when Vite is executed have the highest priority and will not be overwritten by .env files. For example, when running VITE_SOME_KEY=123 vite build.

Can it be related that Lasso runs vite and passes the same environment as laravel currently have which overrides variables from .env.{stage} files?

The only way to fix it that I found is to override LASSO_BUILD_COMMAND to '' and run npm run build --mode {stage} manually and just use lasso as a bundle publishing tool.

Hey @ggolda I'm very sorry for the delay in this issue. Are you still having this issue or still need assistance?


Fix mg building on darwin by changing to new upstream

For context, this is for the issue https://github.com/NixOS/nixpkgs/issues/71136.
This PR now sets the upstream to https://github.com/ibara/mg. For context I will leave the original comment (which patched the original upstream using patches from https://github.com/ibara/mg which apply missing header files on darwin) below.
Original comment:
I am not happy with this at all. It avoids using libbsd at all on darwin because there are conflicting header files, particularly the header string.h.
Ideally that would be the thing to fix upstream. But in the meantime, this patch should do the trick. This is taken from https://github.com/ibara/mg and the license of the patch is the same as mg itself. Homebrew and macports carry https://github.com/ibara/mg. Fink does not package it. Debian and many Linux distributions carry https://github.com/hboetes/mg. NetBSD pkgsrc carries the hboetes version albeit from 2011 (!). Something also relevant, is that MacOS as of MacOS Catalina removed their very old (pre-GPLv3) Emacs from the base operating system, and actually replaced it with a reasonably recent version of mg.
The patch declares a header file apple.h, which files include if target is darwin (checks for presence of __APPLE__). This header file also references the three source files futimens.c, reallocarray.c and strtonum.c. The former and  latter are from https://github.com/ibara/mg. Also of note is that futimens was added to macOS as of 10.13, but 10.12 does not have it so it still is necessary to patch it for now. There might be a better way.
From the OpenBSD source tree is _null.h and tree.h. There is a check so that if __APPLE__ is present then it will include them from this source tree.
Now, the makefile GNUMakefile will not link against libbsd on darwin, by checking the output of uname in much the same way as it did already for FreeBSD.
I would really appreciate testing on NixOS and other Linux distributions!
This applies to the same version in 19.09 and nixpkgs-unstable.

Motivation for this change
This package is not marked as broken, but it is on macOS. It is a generally useful small emacs-like editor. The package in nixpkgs is also quite old, so it makes sense to update it to the most recent release from the upstream source repository.
Things done

[x] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
Built on platform(s)

[ ] NixOS
[x] macOS
[x] other Linux distributions

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[x] Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
[x] Tested execution of all binary files (usually in ./result/bin/)
[x] Determined the impact on package closure size (by running nix path-info -S before and after)
[x] Ensured that relevant documentation is up to date
[x] Fits CONTRIBUTING.md.

Would it make sense to just use ibara/mg to not having to patch it ourself?

Would it make sense to just use ibara/mg to not having to patch it ourself?

I think so? It removes the dependency on libbsd.
I have just tested it and it works just as fine. Should I push to this PR?

Yes.

@GrahamcOfBorg build mg


NextJS  - If package.json has build: next build firebase deploy will fail

The package.json cannot have the build: next build script or firebase function will fail to deploy. This is very reproducible and happens every time.
example package.json
    "scripts": {
        "dev": "next dev",
        "build": "next build"
    }

I've encountered this error when it's the final stages when the function is building.
Error: Could not find 'pages' directory , which is very vague and confusing, but after figuring out a lot of issues , I am perplexed why this is an issue.
I am using src/pages folder structure in NextJS.
firebase.json
{
    "hosting": {
        "source": ".",
        "cleanUrls": true,
        "ignore": ["firebase.json", "**/.*", "**/node_modules/**", "functions/"],
        "rewrites": [
            {
                "source": "**",
                "function": "ssrNextFunc"
            },
            {
                "source": "**/**",
                "function": "ssrNextFunc"
            }
        ],
        "headers": [
            {
                "source": "**",
                "headers": [
                    {
                        "key": "Strict-Transport-Security",
                        "value": "max-age=63072000; includeSubDomains; preload"
                    }
                ]
            }
        ]
    }
}

There seems to be a mismatch somewhere as if you try to override this with anything else eg. build: next build src/ it will say this command will be ignored and firebase will use it's default and deploy will work.
BUT if it's build: next build, this doesn't get ignored, so I assume this means it must be matching firebase's build script, but the frustrating thing is that this will fail the deploy, and I do not know why for the life of me.

suddenly having the same issue on project that was perfectly deployable a couple of days ago


resolve issue #52 Missing side shadows on drop downs

Resolves issue #52 by enabling visible overflow on dropdown element groups

@evanjd yeah noticed that- cleaned up!

@cla-bot check


Failed to establish a new connection: [Errno 61] Connection refused',)': /auth.login

I'm running trains-server locally (for testing purposes on OSX). After a bit of fiddeling, I think the docker containers work as expected, at least I don't see any errors (when running without -d). I'm following the trains-server suggestion of setting ~/trains.conf simply to
api {
    host: "http://localhost:8008"
}

I tried running trains-init, but when going to the localhost:8080\admin, generating the credentials does not work (\admin is redirected to \profile). Does not work here means, that a spinner appears, and after a few seconds it disappears but nothing else happens.
So when testing the matplotlib example, nothing seems to happen, instead I get many lines of
Retrying (Retry(total=239, connect=239, read=240, redirect=240, status=240)) after connection broken by 'NewConnectionError('<urllib3.connection.HTTPConnection object at 0x11c0030b8>: Failed to establish a new connection: [Errno 61] Connection refused',)': /auth.login

It seems that something is not working with respect to the api server? This is how I'm running it and its output:
sudo docker run --restart="always" --name="trains-apiserver" --network="host" -v /opt/trains/logs:/var/log/trains -v /opt/trains/config:/opt/trains/config allegroai/trains:latest apiserver
Password:
[2019-07-18 23:21:22,100] [9] [WARNING] [trains.schema] failed loading cache: [Errno 2] No such file or directory: '/opt/trains/server/schema/services/_cache.json'
[2019-07-18 23:21:22,101] [9] [INFO] [trains.schema] regenerating schema cache
[2019-07-18 23:21:23,528] [9] [INFO] [trains.server] ################ API Server initializing #####################
[2019-07-18 23:21:23,530] [9] [INFO] [trains.database] Initializing database connections
[2019-07-18 23:21:23,531] [9] [INFO] [trains.database] Registering connection to auth-db (mongodb://<IP_ADDRESS>:27017/auth)
[2019-07-18 23:21:23,532] [9] [INFO] [trains.database] Registering connection to backend-db (mongodb://<IP_ADDRESS>:27017/backend)
[2019-07-18 23:21:23,534] [9] [INFO] [trains.init_data] Applying mappings to host: http://<IP_ADDRESS>:9200
[2019-07-18 23:21:23,795] [9] [INFO] [trains.init_data] [{'mapping': 'events_log', 'result': '{"acknowledged":true}'}, {'mapping': 'events_training_debug_image', 'result': '{"acknowledged":true}'}, {'mapping': 'events_plot', 'result': '{"acknowledged":true}'}, {'mapping': 'events', 'result': '{"acknowledged":true}'}]
[2019-07-18 23:21:24,073] [9] [INFO] [trains.server] Exposed Services: auth.create_credentials auth.create_user auth.edit_user auth.fixed_users_mode auth.get_credentials auth.get_token_for_user auth.login auth.logout auth.revoke_credentials auth.validate_token events.add events.add_batch events.debug_images events.delete_for_task events.download_task_log events.get_multi_task_plots events.get_scalar_metric_data events.get_scalar_metrics_and_variants events.get_task_events events.get_task_latest_scalar_values events.get_task_log events.get_task_plots events.get_vector_metrics_and_variants events.multi_task_scalar_metrics_iter_histogram events.scalar_metrics_iter_histogram events.vector_metrics_iter_histogram models.create models.delete models.edit models.get_all models.get_all_ex models.get_by_id models.get_by_task_id models.set_ready models.update models.update_for_task projects.create projects.delete projects.get_all projects.get_all_ex projects.get_by_id projects.get_unique_metric_variants projects.update tasks.close tasks.completed tasks.create tasks.delete tasks.edit tasks.failed tasks.get_all tasks.get_all_ex tasks.get_by_id tasks.ping tasks.publish tasks.reset tasks.set_requirements tasks.started tasks.stop tasks.stopped tasks.update tasks.update_batch tasks.validate users.create users.delete users.get_all users.get_all_ex users.get_by_id users.get_current_user users.get_preferences users.set_preferences users.update
Loading config from /opt/trains/server/config/default
Loading config from file /opt/trains/server/config/default/hosts.conf
Loading config from file /opt/trains/server/config/default/logging.conf
Loading config from file /opt/trains/server/config/default/apiserver.conf
Loading config from file /opt/trains/server/config/default/secure.conf
Loading config from file /opt/trains/server/config/default/services/events.conf
Loading config from file /opt/trains/server/config/default/services/tasks.conf
Loading config from /opt/trains/config
 * Serving Flask app "server" (lazy loading)
 * Environment: production
   WARNING: This is a development server. Do not use it in a production deployment.
   Use a production WSGI server instead.
 * Debug mode: off

I guess I must be doing something wrong. Any help is greatly appreciated.

What version of trains-server are you running?
Also, try running netstat -natp to see if your apiserver is actually listening on port8008.


Progressive Myoclonic Epilepsy typo

**Mondo term (ID Label): Progressive Myoclonic Epilepsy MONDO:0020074
**Bug/Typo/Error description: The term Progressive Myoclonic Epilepsy should be changed to Progressive Myoclonus Epilepsy   (Myoclonic -> Myoclonus)
**Your nano-attribution (ORCID): ClinGen ID/Autism GCEP
If you don't have an ORCID, you can sign up for one here

this has already been changed in the edit file and will be available in the next  release (I plan to do a release on Friday)


Rails 5.2.1

Awesome project! 🥇

Rails 5.2.1 update!
Removed elastisearch-rails , replaced by searchkick
Removed carrierwave, replaced by activestorge
Webpacker added
Updated dependences
Replaced phantomJs by chrome-webdriver

All functions seems to be working fine on my dev environment. And all specs are passing
NOTES:

The upload system was changed to Rails 5.2 ActiveStorage, so previous Carrierwave uploads will not work. should be ported back to ActiveStorage.
elasticsearch-rails is no more. I've replaced it for searchkick, just run this lines to reindex:

Post.reindex
User.reindex
Tag.reindex

Hi @hibiken
now all specs pass on Rails 5.2.1. I think is ready for a QA.
btw is this project still alive ?
best

more additions.

multiple image support
oembed support
a better wysiwyg
automatic title detection
lead is automatic too. more performant approach , I think
responses are unified as a Post model

More additions

code blocks with language formatting via Prism-js
a video record component to build posts with recorded video


Avoid recursion for OCI

Implemented non recursive function calls for OCI

Signed-off-by: naveensrinivasan<EMAIL_ADDRESS>

@sudo-bmitch would like your thoughts on this PR. Related to issue https://github.com/guacsec/guac/issues/350

I am unable to create a stackoverflow, and as such, this hypothesis does not provide a viable solution. Therefore, I am closing this PR.


Issue with TLS 1.2

I am getting this error with  -Verbose switch when testing a new alert. I believe this is related to ms office 365 forcing TLS 1.2.
Is there a way to configure TLS version in elastalert?
ERROR:root:Error while running alert email: Error connecting to SMTP host: [SSL: WRONG_VERSION_NUMBER] wrong version number (_ssl.c:727)

I'm having the exact same problem using MS SMTP relay.
Did you manage to find a resolution for this?

Unfortunately no. :(
Sent from my iPhone
On Oct 15, 2019, at 8:03 AM, Ashlee Jones<EMAIL_ADDRESS>wrote:

I'm having the exact same problem using MS SMTP relay.
Did you manage to find a resolution for this?
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHubhttps://github.com/Yelp/elastalert/issues/2357?email_source=notifications&email_token=AMXBVYRWTJQMEJAYA2D5TSTQOW5RTA5CNFSM4IGPV752YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEBIVDZA#issuecomment-542200292, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AMXBVYRM2OQHJ43GHPYDYWLQOW5RTANCNFSM4IGPV75Q.

For anyone else having this issue, I gave up with trying to get MS working and used a gmail address on port 465. Worked pretty much out the box.
Appears Elastalert is using SSL and not STARTTLS which is why it doesn't work.
Would be great to get this working with MS though.

This issue may be due to this not being merged
Add parameter 'smtp_ca_file', fix STARTTLS problem #2681

in order to work against STARTTLS, you must remove the line
smtp_ssl
This will start elastalert with STARTTLS
I tested this in O364 and it worked for me.

@keshara
yelp / elastalert is not maintained, so I think you should discuss it with elastalert2.
https://github.com/jertel/elastalert2


Curl error of interpolation is too large for non-conforming Nedelec elements

Hi @amartinhuertas,
When the mesh is non-conforming and Nedelec elements are used, the error of the FEFunction produced by the interpolate function is too far away from the FEM solution based on the same mesh with the same order. I have the following MWE:
using Gridap, GridapDistributed, GridapP4est
using PartitionedArrays
import MPI
import Printf: @printf

function refine_model(octree_model, eh, refine_frac)
  ∇xeh, dΩ = ∇ × eh, Measure(Triangulation(octree_model), 10)
  err_indicator = map(dc -> sqrt.(get_array(dc)), local_views(∫(eh ⋅ eh + ∇xeh ⋅ ∇xeh)dΩ))
  strategy = FixedFractionAdaptiveFlagsMarkingStrategy(refine_frac, 1e-2)
  ref_coarse_flags = map(partition(get_cell_gids(octree_model.dmodel))) do indices
    flags = zeros(Cint, length(indices))
    flags .= nothing_flag
  end

  update_adaptivity_flags!(
    ref_coarse_flags,
    strategy,
    partition(get_cell_gids(octree_model)),
    err_indicator;
    verbose=false)

  refined_model, _ = GridapP4est.adapt(octree_model, ref_coarse_flags)
  return refined_model
end

function compute_l2_and_hcurl_norms(uh, dΩ)
  ∇xuh = ∇ × uh
  l2normsq, hcurlseminormsq = ∑(∫(uh ⋅ uh)dΩ), ∑(∫(∇xuh ⊙ ∇xuh)dΩ)
  sqrt(l2normsq), sqrt(l2normsq + hcurlseminormsq)
end

function curr_item(items)
  local_views(items).item_ref[]
end

MPI.Init()

u(x) = VectorValue(cospi(x[1])cospi(x[2]), sinpi(x[1])sinpi(x[2]))
f(x) = ∇(∇ ⋅ u)(x) - Δ(u)(x) + u(x)
ranks = distribute_with_mpi(LinearIndices((prod(MPI.Comm_size(MPI.COMM_WORLD)),)))
coarse_model = CartesianDiscreteModel((0, 1, 0, 1), (1, 1))
model = OctreeDistributedDiscreteModel(ranks, coarse_model, 4)
reffe = ReferenceFE(nedelec, Float64, 1)

for i in 0:3
  V = FESpace(model, reffe; conformity=:Hcurl, dirichlet_tags="boundary")
  U = TrialFESpace(V, u)
  Ω = Triangulation(model)
  dΩ, dΩ⁺ = Measure(Ω, 5), Measure(Ω, 10)
  a(u, v) = ∫((∇ × u) ⋅ (∇ × v) + (u ⋅ v))dΩ
  l(v) = ∫(f ⋅ v)dΩ⁺
  uh_fem = solve(AffineFEOperator(a, l, U, V))
  uh_ipl = interpolate(u, U)
  eh_fem, eh_ipl = uh_fem - u, uh_ipl - u
  fem_l2err, fem_hcurlerr = compute_l2_and_hcurl_norms(eh_fem, dΩ⁺)
  ipl_l2err, ipl_hcurlerr = compute_l2_and_hcurl_norms(eh_ipl, dΩ⁺)
  println("\n----------------------- Iteration $(i) -----------------------")
  @printf "FEM           errors: L2 = %.6f, H(curl) = %.6f.\n" fem_l2err fem_hcurlerr
  @printf "Interpolation errors: L2 = %.6f, H(curl) = %.6f.\n" ipl_l2err ipl_hcurlerr
  @printf "Interpolation  / FEM: L2 = %.6f, H(curl) = %.6f.\n" ipl_l2err/fem_l2err ipl_hcurlerr/fem_hcurlerr
  println("-----------------------------------------------------------\n")
  vtk_fields = ["FEM error" => curr_item(eh_fem), "FEM curl error" => curr_item(abs ∘ (∇ × eh_fem)),
  "Interpolation error" => curr_item(eh_ipl), "Interpolation curl error " => curr_item(abs ∘ (∇ × eh_ipl))]
  writevtk(Triangulation(curr_item(model)), "fem_vs_interpolation", cellfields=vtk_fields)
  model = refine_model(model, uh_fem - u, 0.1)
end

The output of the above script is:
----------------------- Iteration 0 -----------------------
FEM           errors: L2 = 0.001016, H(curl) = 0.006460.
Interpolation errors: L2 = 0.001016, H(curl) = 0.006460.
Interpolation  / FEM: L2 = 1.000139, H(curl) = 1.000023.
-----------------------------------------------------------

----------------------- Iteration 1 -----------------------
FEM           errors: L2 = 0.001006, H(curl) = 0.005423.
Interpolation errors: L2 = 0.001004, H(curl) = 0.010116.
Interpolation  / FEM: L2 = 0.998606, H(curl) = 1.865236.
-----------------------------------------------------------

----------------------- Iteration 2 -----------------------
FEM           errors: L2 = 0.000971, H(curl) = 0.004370.
Interpolation errors: L2 = 0.000967, H(curl) = 0.014372.
Interpolation  / FEM: L2 = 0.995770, H(curl) = 3.288731.
-----------------------------------------------------------

----------------------- Iteration 3 -----------------------
FEM           errors: L2 = 0.000881, H(curl) = 0.003094.
Interpolation errors: L2 = 0.000873, H(curl) = 0.018460.
Interpolation  / FEM: L2 = 0.990350, H(curl) = 5.966791.
-----------------------------------------------------------

At iteration 0, the mesh is conforming, the curl error of the interpolation is nearly the same as that of the FEM solution. However, at iterations 1-3, the mesh becomes non-conforming, and the curl error of the interpolation is increasingly different from that of the FEM solution.
I also have the mesh and the curl error comparison at iteration 3.

Notice that the curl error is really large around the jump of different level of refinement elements.

The interpolation is not curl-conforming.

Can you try to interpolate a FE function in the FE space to see if the interpolation error is zero?

Can you try to interpolate a FE function in the FE space to see if the interpolation error is zero?

Yes, I interpolated the FEM solution into the FE space, and the interpolation error was zero.

Can you try to do the same test with lagrangian elements?

Yes, I interpolated the FEM solution into the FE space, and the interpolation error was zero.

Can you try to interpolate an analytical function which you know is going to be in the FE space into the FE space and see whether the interpolation error is zero?

Can you try to do the same test with lagrangian elements?

Do you mean solving the same Maxwell's equation using Lagrangian elements?

Can you try to interpolate an analytical function which you know is going to be in the FE space into the FE space and see whether the interpolation error is zero?

Yes, the error is zero up to machine precision.

Do you mean solving the same Maxwell's equation using Lagrangian elements?

No. To solve a poisson problem with lagrangian elements, and see whether you have a similar behaviour as with Nedelec (i.e.. higher interpolation errors at the regions where there are jumps in refinement level).
If the interpolation error is zero with functions in FE space, then I am positive the hanging DoF constraints coefficients are computed correctly, so I am not sure if there is anything wrong in the results you are showing.
In these experiments, you are only using a single quadtree in the forest, correct?

Here are the results of a Poisson problem test.
----------------------- Iteration 0 -----------------------
FEM           errors: L2 = 0.000246, H1 = 0.012765.
Interpolation errors: L2 = 0.000246, H1 = 0.012766.
Interpolation  / FEM: L2 = 1.000962, H1 = 1.000077.
-----------------------------------------------------------

----------------------- Iteration 1 -----------------------
FEM           errors: L2 = 0.000218, H1 = 0.011541.
Interpolation errors: L2 = 0.000219, H1 = 0.011575.
Interpolation  / FEM: L2 = 1.004337, H1 = 1.002911.
-----------------------------------------------------------

----------------------- Iteration 2 -----------------------
FEM           errors: L2 = 0.000166, H1 = 0.009167.
Interpolation errors: L2 = 0.000168, H1 = 0.009228.
Interpolation  / FEM: L2 = 1.011550, H1 = 1.006596.
-----------------------------------------------------------

----------------------- Iteration 3 -----------------------
FEM           errors: L2 = 0.000111, H1 = 0.006566.
Interpolation errors: L2 = 0.000114, H1 = 0.006671.
Interpolation  / FEM: L2 = 1.029868, H1 = 1.016066.
-----------------------------------------------------------

The Lagrangian interpolation seems correct.

If the interpolation error is zero with functions in FE space, then I am positive the hanging DoF constraints coefficients are computed correctly, so I am not sure if there is anything wrong in the results you are showing.

Is Nedelec interpolation on non-conforming mesh something new? It is for sure an issue that the Nedelec interpolation is not curl-conforming.

In these experiments, you are only using a single quadtree in the forest, correct?

Yes. I also tried 4 quadtrees, the results are similar, i.e. the interpolation error is much larger than the FEM error.

ok, I will take a look when I have some time.


Revert hack for reading IvyArtifactName

@bot-gradle test this

Sorry some internal error occurs, please contact the administrator @blindpirate

@bot-gradle test and merge

OK, I've already triggered a build for you.


Add installation section in README

@kahliburke Would you like to post an announcement for the availability of the project?


JetpackFallFix breaks hands in Lethal Company VR

When this mod is turned on, the hands are only above the player and they doesnt move

Seems to be the same issue as https://github.com/Hamunii/JetpackFallFix/issues/2 (Harmony patches breaking after thowing in an ILHook) so I'm closing this


diff for luatest assert failures

Intercept output like this
...some_test.lua:116: expected:
{
    ...
}
actual:
{
   ...
}

And print sole "display differences" hyperlink to show the same in a diff window

hyperlinks:

click to any:

it all works if you add this to your project:
luatest-pretty-table.zip
It pretty-prints tables as jsons with sorted keys for stability (tables retain no order)


[Touchable] Customizing "press rect offset" of touchable components

The press-rect offset defines a box around a touchable component in which a touch still counts. I'd like to be able to customize this box (specifically set the press-rect offset to (0,0,0,0)) by exposing it as a prop. Looking for suggestions for what to name the prop, or maybe there is already a term for this in the HCI literature.

Thank you for reporting this issue and appreciate your patience. We've  notified the core team for an update on this issue. We're looking for a response within the next 30 days or the issue may be closed.

I like the idea of defining an area around a touchable component where the touch still counts. What's the way to handle this now? Just increase the size and padding which could potentially break the design?

That's a bit different since that increases the area that you can tap to start a touch. This issue is about customizing an enclosing box in which a touch is retained but not necessarily started.


docs: don't use alias methods

Summary

Updates the current docs to not use the aliased methods that are going to be removed in v30 (see #https://github.com/jestjs/jest/issues/13164).
I've done a dedicated PR for this to try reduce some of the overall diff of completing #13164 - @SimenB do you think this should be applied to the older docs as well?
Test plan

No tests are needed.

@SimenB do you think this should be applied to the older docs as well?

Yeah, that probably makes sense 👍


Fixed link-order, code-format/conformance, outdated enumerator, updated submodule

Fixed dependency link-order (came up with TPP-mlir).
Fixed/updated outdated enumerator.
Removed trailing newlines/spaces.
Removed superfluous includes.
Use inclusion guards.

@egeor will the code reformatting create challenges with other branches we have with this code?


'r' when typing on workflowy turns on extension

Solution: Go back to ALT+R

https://github.com/benfrancis314/reading_project/pull/170


FTC branding (left)

It seems there is some FTC branding in the LTC version?

Moving this to https://github.com/fiatswindle/omnilite-q-a/tree/main


egrep IP regex optimizations

IP selecting regex shortened on the repetitions of \.[1-9]{1,3} part 3 times

Thank you!


axp2101 wrong set for charging?

Hi Peter,
line 150 or so:
should "_pmu->setChargerConstantCurr(XPOWERS_AXP192_CHG_CUR_780MA)" for AXP2101 be:
"_pmu->setChargerConstantCurr(XPOWERS_AXP2101_CHG_CUR_800MA);" ????
maybe this will affect some of your boards with this new code

thanks is fixed ;)


Fix autoprovisioning with spot nodes

Fixes / Features

Fixes workload rendering when using spot, without this change xpk workload create errors like:
[XPK] Waiting for `Creating Workload`, for 0 seconds
error: error parsing /tmp/tmp242uhnfs: error converting YAML to JSON: yaml: line 33: could not find expected ':'
[XPK] Task: `Creating Workload` terminated with code `1`

Adds required pod tolerations when using node auto-provisioning with spot nodes.  Without the tolerations cluster autoscaler will not create new spot node pools.

Testing / Documentation
Node auto-provisioning with spot

Created a xpk cluster with --spot flag.
Created a workload with a different topology than the cluster default.
Observed a nodepool being created with the new workload topology using spot TPU nodes.

Node auto-provisioning without spot
TODO
Not auto-provisioning
TODO

[ y/n ] Tests pass
[ y, not needed ] Appropriate changes to documentation are included in the PR

zone: 'us-central2'>] finished with error: Try a different location, or try again later: Google Compute Engine does not have enough resources available to fulfill request: us-central2-b

/retest


chore: bump @interslavic/utils

Fixes superlative adverbs:

See: https://github.com/medzuslovjansky/js-utils/pull/34

Pull Request Test Coverage Report for Build<PHONE_NUMBER>
Details

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 5.047%

Totals

Change from base Build<PHONE_NUMBER>:
0.0%

Covered Lines:
129

Relevant Lines:
2943

💛  - Coveralls


What about a group event 'WillRemove'?

Hey,
The reason is to be able to access the component's data right before it is removed, what are your thoughts on this?
Example: I've got a TargetComponent which holds a target ID, and on it being added the target is retained, but when I want to release the target, I need to either create a flag willBeDestroyed and use that to reference the component or hold a list and iterate over it to confirm it being removed, so I think having this event will be of great benefit for certain things.
Cheers

With the common practice of using systems and reactive system all access is basically deferred. I strongly advise to not use group events directly on a regular basis, only if you're aware of the potential consequences. It's a very common practice to have a DestroyedComponent to flag entities as destroyed. This way all systems still have access to all the data before the entity will be destroyed for real in on of the last systems.

btw, group.OnEntityRemoved will give you access to the removed component

When you say group events directly what exactly do you mean?
This is the approach I've started using with Triggers
     protected override ICollector<GameEntity> GetTrigger(IContext<GameEntity> context)
        {
            return context.CreateCollector(GameMatcher.Target.AddedOrRemoved(), GameMatcher.AIState.AddedOrRemoved(), GameMatcher.MoveComplete.Added());
        }

Do you mean events like OnEntityRemoved etc?

@sschmid i think the point of this question to ask for a reactive system trigger that fires at the same time as Removed() currently does, but that gives the reactive system access to the component that just got removed.
That is: we know we can get the component from the .Removed() event but we want it in the reactive system so we can process it before it gets deleted.
@bit-chimp In my case I work around this by having a lot of intermediate components (e.g. adding RemoveThingComponent instead of actually removing ThingComponent. Then i can write an RS that reacts on RemoveThing.Added() which then processes the data in the ThingComponent and finally, actually calls e.RemoveThing().

You have 3 options:

Flagging an entity with a component like DestroyedComponent (common practice)
using group.OnEntityRemoved
using entity.OnComponentRemoved


added to showcase

[ ] I have followed (at least) the PR section of the contributing guide.

Hi @johnvincentio, I believe it's a duplicate of #14557. We are sorting the showcase date desc, new contributions are added to the top of the list. I'm sorry but your product doesn't qualify for the showcase. We are looking for content that ranks well among these dimensions:

Open source projects
Creative Content (nonmaterial design encouraged)
High volume traffic
High-quality UI

Thank you for taking the time to share your project!


Rtk reconstruction using different slice thickness

Hi all,
I am using rtk for recontsruction ...i have a query is it possible to reconstruct using fdk for variable slice thickness of CT
For example i have a CT with :width 217mm(512)
:height 217mm(512)
no. of slices :120
slice thickness is 1mm

Opening three times the same issue is not acceptable (see #539 and #540). @Vivek95vs has been blocked from the organization.


Fix pylint error

This plus changes committed directly to main (https://github.com/microsoftgraph/msgraph-training-python/commit/5611cd7d1aa0f941225dc193ba92033b07d1b519) fix #82.

Glad to see this issue fixed, wanted to ask if we know when the tutorial doc will be updated?
https://learn.microsoft.com/en-us/graph/tutorials/python?tabs=aad&tutorial-step=3
I was working through this today and ran into the AttributeError: 'GraphRequestAdapter' object has no attribute 'get_token' issue that was fixed with this commit.
Thanks!

Thanks @Joshua-Donovan! It looks like our docs build didn't pick up this change. I requested a rebuild and that seems to have fixed it.


Train inpainting model/LoRA/TI

Reference: https://github.com/huggingface/diffusers/blob/main/examples/research_projects/dreambooth_inpaint/train_dreambooth_inpaint.py

Note that this code wont be able to run, but it may be a good base ig.


User can like/dislike an article S18

@mayarali @MohammedAnsary @omarelhariry

Please Use rubocop

@AndrewMagdy  done

@bassemmagdy
remove the last method upvote/downvote

@bassemmagdy you can add the pending documentation label and @mina should review your documentation

@MinaHany94 @omaressameldin

@MohammedAnsary

@bassem I have many errors due to missing controllers and models in your folder please pull master and resolve conflicts then tag me again to review

@MohammedAnsary

Wrong resolving for conflicts and css errors in almost everyrhing ... please recheck the code

@MohammedAnsary  check branch MergeLikeDislikeArticles and merge I just pulled from master and added the story

@MohammedAnsary

@MohammedAnsary


created juila programme that converts radian to degree

Write a programme to convert radian to degree.
Why:
Closes #1185
What's being changed:
Check off the following:

[x] I have reviewed my changes in staging (look for "Automatically generated comment" and click Modified to view your latest changes).
[x] For content changes, I have completed the self-review checklist.

Please do 3 things below:
* replace current comment with `# Write a programme to convert radian to degree`

* write 2 lines that will print input and output

* add your name to contributor list in the `README.md` file under this folder

Thank you, @Adarsh-jaiss!

-- All changes have been successfully done :)
-- kindly review it once again

In general, we would like to have the users to give a value and then the code will print the answer after. e.g. if value is 1, the answer should be 57.29577951308232. Or if value is 8, the answer should be<PHONE_NUMBER>046586.
The format looks like this below, and please keep # Write a program to convert Radian to Degree.
# Write a program to convert Radian to Degree

# your code that ask for a value and then print answer after

Please refer to more julia files to see the code format.
If I am not clear, please do let me know as well.
Thank you, @Adarsh-jaiss!

Thanks for the review 👍🏻


Annotation: ability to switch to the next document before finishing the current one

duplicate for task with Next button


Add StartBeforeSynced configuration flag

When StartBeforeSynced is set, let lnd daemon completely start even if the
chain is not fully synchronized.

Could you explain the motivation behind this change? We currently wait for safety reasons.

The main motivation for this configuration flag is to improve the user experience when running lnd in a mobile device. If a user doesn't use the app for more than few days and then open it, she needs to wait a lot (more than several minutes depending on her network connection) in order to do any operation.
And this is the case, even if the user is willing to take the risk that the channel is closed and want to make a payment. In fact, there is a way for the user to check - in a less secure way - that the channel is not closed by querying external blockchain explorers before making the payment.
In fact, even without this configuration parameter, the same situation can arise when lnd is running and there is some connectivity problem for an important period of time. synced_to_chain will be false, but lnd will work.
Additionaly, if we think more conceptually,  as @alexbosworth wrote:

Considering that the tip is always potentially in the future, are we ever really caught up?


Only one player can see the initial table cards

For some reason, the initially spread out cards are not visible to both players anymore.
Spreading out the cards should be in the opposite direction, so that the upper left corner is visible for all cards instead of the lower right (top-down) one.

The problem was that the spreading out stopped as soon as a "card action" was received, and this did not only include actions playing cards, but also dealing cards.


Consistent jupyter messaging

Right now everything is built on the predicate of loading a notebook from disk. As I'm fleshing this out, I'm noticing it matches up much better to be reacting to changes in state. The notebook document itself is a final state representation that can be turned back into the messages that put the application state together.

With our switch to consistency with commutable, I'd say we are in a good state.


Include inheritance problem test for polystat integration

A test with unexpected mutual recursion is successfully generated in #141


Does not log exception when using DrainingControl

When using KafkaConsumer.SourceWithOffsetContext with DrainingControl and an exception is thrown within a flow, nothing gets logged making it very difficult to debug what actually occurred. Here's the sample app that will demonstrate this.
using System;
using Akka;
using Akka.Actor;
using Akka.Configuration;
using Akka.Streams;
using Akka.Streams.Dsl;
using Akka.Streams.Kafka.Dsl;
using Akka.Streams.Kafka.Helpers;
using Akka.Streams.Kafka.Settings;
using Akka.Util.Internal;
using Confluent.Kafka;
using Serilog;

namespace StreamsDoesntLog
{
    class Program
    {
        static void Main(string[] args)
        {
            Log.Logger = new LoggerConfiguration()
                .MinimumLevel.Debug()
                .WriteTo.Console()
                .CreateLogger();

            var actorSystemConfig =
                ConfigurationFactory.ParseString(@"
                        akka.loglevel=DEBUG
                        akka.loggers=[""Akka.Logger.Serilog.SerilogLogger, Akka.Logger.Serilog""]
                        ")
                    .WithFallback(ConfigurationFactory.FromResource<ConsumerSettings<object, object>>(
                        "Akka.Streams.Kafka.reference.conf"));

            using var system = ActorSystem.Create("system", actorSystemConfig);
            using var materializer = system.Materializer();

            var consumerConfig = new ConsumerConfig
            {
                EnableAutoCommit = true,
                EnableAutoOffsetStore = false,
                AutoOffsetReset = AutoOffsetReset.Earliest
            };

            var consumerSettings = ConsumerSettings<Byte[], Byte[]>.Create(system, Deserializers.ByteArray, Deserializers.ByteArray)
                .WithBootstrapServers("localhost:9092")
                .WithStopTimeout(TimeSpan.Zero)
                .WithGroupId("group1");

            consumerConfig.ForEach(kv => consumerSettings = consumerSettings.WithProperty(kv.Key, kv.Value));

            var committerSettings = new CommitterSettings(10, TimeSpan.FromSeconds(10), 2);

            KafkaConsumer.SourceWithOffsetContext(consumerSettings,
                    Subscriptions.Topics("events-topic"))
                .Select(result =>
                {
                    throw new Exception("won't get logged");
                    return "don't return";
                })
                .AsSource()
                .ToMaterialized(
                    Committer.SinkWithOffsetContext<string>(committerSettings),
                    Keep.Both)
                .MapMaterializedValue(t1 =>
                    DrainingControl<NotUsed>.Create(t1.Item1, t1.Item2.ContinueWith(t2 => NotUsed.Instance)))
                .Run(materializer).IsShutdown.Wait();
        }
    }
}

Ok. I figured out that the exception is made available in t1.Item2 if I do this.
.MapMaterializedValue(t1 =>
    DrainingControl<NotUsed>.Create(t1.Item1, t1.Item2.ContinueWith(t2 =>
    {
        // Exceptions in the stream show up here. If you don't catch it here, it gets swallowed up
        if (t2.Exception != null)
        {
            _logger.Fatal(t2.Exception, "Stream shutdown unexpectedly");
        }

        return NotUsed.Instance;
    })));

Is this the right way to handle an exception?

@ayoung Well, in your sample, before using DrainingControl you have a source, that is materialized into pair (IControl, Task<NotUsed>). Probably we should add tuple items naming here to simplify understanding, but it is actually (IControl Control, Task<NotUsed> StreamCompletion). So, to create DrainingControl, you are passing there special object to contol the stream execution (IControl) and the stream task.
Then, you were using IsShutdown.Wait() which was just starting separate "shutdown" task, and you were waiting for it's completion. And it was completed without issues. It is just a special task that is representing asynchronous shutdown process. When IsShutdown is completed, you may be safe that source will not produce elements anymore.
Instead, you would better use  StreamCompletion.Wait() - that is, wait for stream to complete it's internal task, processing task. It is not the same as IsShutdown task, because after stopping the source it may still take some time to stop internal actors and processing.
So, if you need to check what's up with source processing task, StreamCompletion property is what you need.

I guess we may close this issue, since by design you are getting Task object that you are able to ignore, or log exceptions - whatever you want.

I changed it to use StreamCompletion.Wait() but it still does not expose the exception within StreamCompletion.Exception. i.e. that property is null.

@ayoung Ah, yeah, actually in the sample above StreamCompletion task will not throw because we are ignoring consuming exception in continuation.
So, while your way of handing exception in the second comment works (if you just need to log it and then ignore), here is how you can pass exception to outside of the stream:
KafkaConsumer.SourceWithOffsetContext(consumerSettings, Subscriptions.Topics("events-topic"))
	.Select(result =>
	{
		throw new Exception("won't get logged");
		return "don't return";
	})
	.AsSource()
	.ToMaterialized(
		Committer.SinkWithOffsetContext<string>(committerSettings),
		Keep.Both)
	.MapMaterializedValue(t1 =>
		DrainingControl<NotUsed>.Create(t1.Item1, t1.Item2.ContinueWith(t2 =>
		{
			// If consuming actually failed - we will re-throw it's failure exception
			if (t2.Exception != null)
				throw t2.Exception;

			return NotUsed.Instance;
		})))
	.Run(materializer).StreamCompletion.Wait(); // Throws AggregateException

So the idea is that DrainingControl.SteamCompletion contains the actual execution task, passed in t1.Item2.  And you can either handle exception in task continuation (as you did), or just let it pass in "Failed" state in StreamCompletion property and handle it from outside of the stream.


Add snowballdevice endpoint

Issue #, if available:
Fix snowballdevice validation errors
Post \"https://snowballdevice.snow.amazonaws.com/\": dial tcp: lookup snowballdevice.snow.amazonaws.com on <IP_ADDRESS>:53: no such host

Description of changes:
Testing (if applicable):
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

/lgtm


Poetry export does not export local editable requirements correctly

[x] I am on the latest Poetry version.
[x] I have searched the issues of this repo and believe that this is not a duplicate.
[x] If an exception occurs when executing a command, I executed it again in debug mode (-vvv option).

OS version and name: MacOS Catalina 10.15.7
Poetry version: 1.1.4
Python version: 3.9.0
Link of a Gist with the contents of your pyproject.toml file: https://gist.github.com/pawelrubin/c20a783832924952dc0c0b9fa88974f0
Link of a Gist with the contents of your poetry.lock file:
https://gist.github.com/pawelrubin/19731324b4ed3b1f3d50c6634befc016
Link of a Gist with the contents of your example_pkg/setup.py file:
https://gist.github.com/pawelrubin/563bba1d591959c674c8aca81d3918ad

Issue

Local editable packages are not exported correctly by poetry. Thus, pip install -r requirements.txt fails with error:
ERROR: Invalid requirement: 'example-pkg @ /Users/pawelvewd/projects/test_poetry/example_pkg' (from line 3 of requirements.txt)
Hint: It looks like a path. File 'example-pkg @ /Users/pawelvewd/projects/test_poetry/example_pkg' does not exist.

Expected result
-e ./example_pkg["foo"] ; python_version >= "3.9"

Current result
example-pkg @ /Users/pawelvewd/projects/test_poetry/example_pkg; python_version >= "3.9"

the path should be relative IMO
Poetry does not export extras
Poetry does not export develop = true (editable mode)

Took a similar to @bow:
freeze:
	poetry export -f requirements.txt --output requirements.txt
	sed -i '' '/my-package/d' requirements.txt
	echo "-e sub-dir/" >> requirements.txt

+1 running into this as well

I opened a PR following @bow suggestion. Hopefully I can get a maintainer to look at it.


data/PDBBind_processed not found

in preprocess_pdbbind.py, line 18,19
if input_dir.is_dir():
raise ValueError(f"The PDBbind dataset not found: {input_dir}.")
I doubt if this is right. If I put unziped folder PDBBind_processed under data/, the path will be data/PDBBind_processed, which is a directory, I think it is
if not input_dir.is_dir():

Dear Yingde,
Thank you for your interest in our model and for bringing this issue to our attention. As you pointed out, this is a bug, and I have fixed it.
Thank you again for your valuable feedback. I will close the issue as resolved, but please feel free to reopen it if you encounter any further issues.
Best regards,
Shuya Nakata.


[SPARK-26218][SQL] Overflow on arithmetic operations returns incorrect result

What changes were proposed in this pull request?
When an overflow occurs performing an arithmetic operation, we are returning an incorrect value. Instead, we should throw an exception, as stated in the SQL standard.
How was this patch tested?
added UT + existing UTs (improved)

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution/4249/
Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution-unified/353/
Test PASSed.

Merged build finished. Test PASSed.

Test build #92132 has started for PR 21599 at commit 5c662f6.

Test build #92132 has finished for PR 21599 at commit 5c662f6.

This patch fails Scala style tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/92132/
Test FAILed.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution-unified/354/
Test PASSed.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution/4250/
Test PASSed.

Test build #92133 has started for PR 21599 at commit fad75fa.

Test build #92133 has finished for PR 21599 at commit fad75fa.

This patch fails Spark unit tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/92133/
Test FAILed.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution-unified/358/
Test PASSed.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution/4254/
Test PASSed.

Test build #92140 has started for PR 21599 at commit 8591417.

Test build #92140 has started for PR 21599 at commit 8591417.

Test build #92140 has finished for PR 21599 at commit 8591417.

This patch fails Spark unit tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/92140/
Test FAILed.

@cloud-fan @gatorsmile the main issue which is causing the UT failures, now, is that since before we were allowing overflows, in aggregations we could have an overflow eventually fixed by another overflow on the opposite direction (see the two UT failures in the Range suite).
The problem here is that we can know whether an overflow occurs only checking at the incoming operands, so we cannot defer after the whole aggregation is performed to check if the overflow occurred or not.  The way MySQL deals with this case is returning a DECIMAL as result of the aggregation (it the starting datatype is BIGINT, then a DECIMAL(41, 0)). Probably we can do something similar, but that would be a quite huge behavior change and I am not sure it is acceptable in a minor release.
Therefore, I'd like to know your thoughts about this, since on one side it is a pretty serious bug which should be fixed, on the other I cannot think of any solution which doesn't involve behavior changes.
Thank you.

is this a regression in Spark 2.3? which commit caused it?

@cloud-fan it is not a regression, it has been like that at least since 2.0...

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution-unified/378/
Test PASSed.

Test build #92172 has started for PR 21599 at commit 9c3df7d.

Test build #92172 has finished for PR 21599 at commit 9c3df7d.

This patch fails Spark unit tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/92172/
Test FAILed.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution-unified/408/
Test PASSed.

Test build #92208 has started for PR 21599 at commit ebdaf61.

Test build #92208 has finished for PR 21599 at commit ebdaf61.

This patch fails Spark unit tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/92208/
Test FAILed.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution-unified/414/
Test PASSed.

Test build #92216 has started for PR 21599 at commit a0b862e.

Test build #92216 has finished for PR 21599 at commit a0b862e.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/92216/
Test PASSed.

kindly ping @gatorsmile @hvanhovell

@cloud-fan @gatorsmile @hvanhovell what do you think about deciding a strategy about how to handle this case and try to make it happen in 2.4 as this is a correctness bug? Thanks.

Test build #93107 has started for PR 21599 at commit 7bba22f.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution-unified/1009/
Test PASSed.

Test build #93107 has finished for PR 21599 at commit 7bba22f.

This patch fails Spark unit tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/93107/
Test FAILed.

kindly ping @cloud-fan @gatorsmile @hvanhovell

I prefer returning null, and introduce a strict mode in Spark 3.0. We can revisit all the returning null cases and think if we should fail if strict mode is on.

ah that's a good point. Then maybe we should keep this "java style behavior" and add "strict mode" later.
cc @rxin @rednaxelafx

I don't think we can change behavior like this without introducing a config. In Spark 3.0 we will add a "strict mode" and closely follow SQL standard. But for Spark 2.4, how about we keep the "java style behavior" as it is? We can add some document about it though.

Build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution-unified/5666/
Test PASSed.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution-unified/12002/
Test PASSed.

Test build #106781 has started for PR 21599 at commit 77f26f2.

Test build #106781 has finished for PR 21599 at commit 77f26f2.

This patch fails Spark unit tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/106781/
Test FAILed.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution-unified/12011/
Test PASSed.

Test build #106792 has started for PR 21599 at commit 74cd0a4.

Test build #106792 has finished for PR 21599 at commit 74cd0a4.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/106792/
Test PASSed.

What's the performance penalty associated with these overflow checks? I imagine that there's a certain space of real-world workloads where overflows are unlikely (e.g. count aggregates, where it's extremely unlikely that we'll have more than Long.MaxValue records in our dataset) and the additional performance overhead of overflow checking could have an adverse impact on query performance.
For this reason alone, I suspect that we need to feature-flag this change so that users can opt-out of the behavior change (or, more likely, opt-in). I'm very sympathetic to the view that Spark should be "correct by default" here, but I'm also open to pragmatic compromises which let us make incremental progress here: having opt-in overflow checking is better than having no overflow checking at all. Also, this isn't a trapdoor decision: later, in a separate PR, we could choose to flip the default value of the new flag or choose to remove the flag and always perform overflow checking.
(p.s. have you considered using Java 8's new addExact(), etc. to perform the overflow-checking? AFAIK that operation has an efficient implementation in some JDKs: https://stackoverflow.com/a/26350973/590203)

Ok, since @cloud-fan too suggested to have this under a flag, I am introducing it.

have you considered using Java 8's new addExact(), etc. to perform the overflow-checking?

no I haven't, I'll do asap, thanks.

@JoshRosen I checked using the addExact. The only issue I see with it is that it is present only for int and long. Since our operations handle double and float too, we would need to further specialize the operations for those datatypes. I'd prefer to investigate this in a followup/different Jira if you agree.

Test build #106933 has started for PR 21599 at commit 2cfd946.

Test build #106933 has finished for PR 21599 at commit 2cfd946.

This patch fails to build.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/106933/
Test FAILed.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution-unified/12138/
Test PASSed.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution-unified/12139/
Test PASSed.

Test build #106936 has started for PR 21599 at commit 25c853c.

Test build #106936 has finished for PR 21599 at commit 25c853c.

This patch fails Spark unit tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/106936/
Test FAILed.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution-unified/12162/
Test PASSed.

Test build #106960 has started for PR 21599 at commit 00fae1d.

Test build #106960 has finished for PR 21599 at commit 00fae1d.

This patch fails Spark unit tests.
This patch merges cleanly.
This patch adds no public classes.

/cc @wangyum, since this is relevant to https://issues.apache.org/jira/browse/SPARK-28024: to actually close out SPARK-28024 we might have to decide on what should be the default behavior (and I'm fine making that change in a separate PR), but wanted to flag you for review in light of the new progress on this PR.

I'll loop back later to take a more careful look at this PR's changes in light of the latest updates. In the meantime, it'd also be great to get another review from someone more familiar with codegen, especially for the internal interface changes to support the overflow checking code generation.
/cc @cloud-fan @gatorsmile

Test build #107024 has started for PR 21599 at commit 8e9715c.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution-unified/12217/
Test PASSed.

Test build #107024 has finished for PR 21599 at commit 8e9715c.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/107024/
Test PASSed.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution-unified/12780/
Test PASSed.

Test build #107651 has started for PR 21599 at commit 1dff779.

Test build #107651 has finished for PR 21599 at commit 1dff779.

This patch fails Spark unit tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/107651/
Test FAILed.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution-unified/12829/
Test PASSed.

Test build #107703 has started for PR 21599 at commit 37e19ce.

Test build #107703 has finished for PR 21599 at commit 37e19ce.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/107703/
Test PASSed.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution-unified/13048/
Test PASSed.

Test build #107938 has started for PR 21599 at commit 98bbf83.

Test build #107938 has finished for PR 21599 at commit 98bbf83.

This patch fails Spark unit tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/107938/
Test FAILed.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution-unified/13052/
Test PASSed.

Test build #107942 has started for PR 21599 at commit 650ea79.

Test build #107942 has finished for PR 21599 at commit 650ea79.

This patch fails SparkR unit tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/107942/
Test FAILed.

retest this please

Test build #107960 has started for PR 21599 at commit 650ea79.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution-unified/13070/
Test PASSed.

Test build #107960 has finished for PR 21599 at commit 650ea79.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/107960/
Test PASSed.

For overflow checking, I do think Math.addExtract is better, although it doesn't work for byte/short and float/double.

For byte/short, we add them as int(this is how java adds 2 bytes), and then check if it exceeds the range of byte/short, and then cast it back to byte/short. I think this should be faster than checking the signum.
For float/double, I'm not sure we can check overflow by signum. And float/double can be Infinity at the beginning, so I don't really know how to detect overflows. Can you check other databases?

For the interpreted version, we can implement custom Numeric in places like ByteType#numeric and add overflow check.

thanks for your comment @cloud-fan. I am working in order to address your comments.
Regarding to 2, in Postgres, any operation involving an infinite returns infinite, while +infinite - infinite returns NaN. I am not sure why you have concerns using signum for detecting overflow. May you elaborate it? That's basically the definition of an overflow...

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution-unified/13339/
Test PASSed.

Test build #108238 has started for PR 21599 at commit 538e332.

Test build #108238 has finished for PR 21599 at commit 538e332.

This patch fails to build.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/108238/
Test FAILed.

Test build #108247 has started for PR 21599 at commit 3de4bfb.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution-unified/13349/
Test PASSed.

Test build #108247 has finished for PR 21599 at commit 3de4bfb.

This patch fails Spark unit tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/108247/
Test FAILed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution-unified/13350/
Test PASSed.

Merged build finished. Test PASSed.

Test build #108248 has started for PR 21599 at commit 3baecbc.

Test build #108251 has started for PR 21599 at commit a247f9f.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution-unified/13353/
Test PASSed.

Test build #108248 has finished for PR 21599 at commit 3baecbc.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/108248/
Test PASSed.

Test build #108251 has finished for PR 21599 at commit a247f9f.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/108251/
Test PASSed.

LGTM except a few comments, thanks for working on it!

thank you @cloud-fan for you help on this!

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution-unified/13505/
Test PASSed.

Test build #108409 has started for PR 21599 at commit 582d148.

Test build #108409 has finished for PR 21599 at commit 582d148.

This patch fails Spark unit tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/108409/
Test FAILed.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution-unified/13514/
Test PASSed.

Test build #108418 has started for PR 21599 at commit b809a3f.

Test build #108418 has finished for PR 21599 at commit b809a3f.

This patch fails PySpark unit tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/108418/
Test FAILed.

retest this please

Test build #108443 has started for PR 21599 at commit b809a3f.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution-unified/13539/
Test PASSed.

Test build #108443 has finished for PR 21599 at commit b809a3f.

This patch fails due to an unknown error code, -9.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/108443/
Test FAILed.

retest this please

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution-unified/13549/
Test PASSed.

Test build #108453 has started for PR 21599 at commit b809a3f.

Test build #108453 has finished for PR 21599 at commit b809a3f.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/108453/
Test PASSed.

thanks @gengliangwang , I added them.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution-unified/13561/
Test PASSed.

Test build #108467 has started for PR 21599 at commit ce3ed2b.

Test build #108467 has finished for PR 21599 at commit ce3ed2b.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/108467/
Test PASSed.

thanks, merging to master!

thank you all for your great help on this!


BUG: runtime error when checking Vulnerabilities

Describe the bug
scorecard fails with the following error message when run on this specific github repository:
❯ GITHUB_AUTH_TOKEN=$GITHUB_ACCESS_TOKEN go run main.go --show-details  --repo=https://github.com/parcel-bundler/parcel --checks=Vulnerabilities
Starting [Vulnerabilities]
Finished [Vulnerabilities]

RESULTS
-------
Aggregate score: ?

Check scores:
|-------|-----------------|---------------------------------------------------|---------|----------------------------------------------------------------------------|
| SCORE |      NAME       |                      REASON                       | DETAILS |                         DOCUMENTATION/REMEDIATION                          |
|-------|-----------------|---------------------------------------------------|---------|----------------------------------------------------------------------------|
| ?     | Vulnerabilities | internal error:                                   |         | https://github.com/ossf/scorecard/blob/main/docs/checks.md#vulnerabilities |
|       |                 | vulnerabilitiesClient.ListUnfixedVulnerabilities: |         |                                                                            |
|       |                 | internal error: osv-scanner panic: runtime error: |         |                                                                            |
|       |                 | invalid memory address or nil pointer dereference |         |                                                                            |
|-------|-----------------|---------------------------------------------------|---------|----------------------------------------------------------------------------|
Error: check runtime error: Vulnerabilities: internal error: vulnerabilitiesClient.ListUnfixedVulnerabilities: internal error: osv-scanner panic: runtime error: invalid memory address or nil pointer dereference
2023/05/03 17:18:55 error during command execution: check runtime error: Vulnerabilities: internal error: vulnerabilitiesClient.ListUnfixedVulnerabilities: internal error: osv-scanner panic: runtime error: invalid memory address or nil pointer dereference
exit status 1

Reproduction steps
Steps to reproduce the behavior:

git clone this repo. I used commit d4624f7fa4f524f8da4f14ce3f5f309323f5feba for this report. However, it's worth noting that the error was also present with release 4.10.5 (in which case, there is no valid output, just a SIGSEGV with an exit status 2)
Run GITHUB_AUTH_TOKEN=$GITHUB_ACCESS_TOKEN go run main.go --show-details  --repo=https://github.com/parcel-bundler/parcel --checks=Vulnerabilities with a valid github access token
The run fails after a few seconds. The error also happens when running all checks, but limited to this same vulnerabilities check. Removing --show-details from the command changes nothing.

I've been able to reproduce consistently with this repo, but no other ones. There is nothing immediately obvious (to me) in that repo that would explain the error.
Expected behavior
The tool(s) should not panic :scream:
Additional context
It looks like the actual bug might be in osv-scanner, but I'm not sure whether that's the case or if it's the way scorecard runs it that is the problem. I have not tested osv-scanner separately to verify. I have not seen any obviously related bug in their repo though.
I've also tried running the docker and standalone release version 4.10.4 and 4.10.5, all fail.
I'm running debian/linux, with go version go1.19.8 linux/amd64.

Thanks for the report, but osv-scanner is the one panicing here. You can usually reproduce the bug if you run osv-scanner from the base of the repo:
osv-scanner -r .
As of #2896 we do recover from the panic so it doesn't crash scorecard as well. However the 4.10.5 release would panic as it doesn't have that PR.

Thanks @spencerschrock and sorry for the noise. I've opened https://github.com/google/osv-scanner/issues/364 based on your suggestion. Hopefully the actual bug can be fixed (I'm not exactly proficient in go, so I'll leave it to the pros :sweat_smile: )


Support for multiple return variables

It's really not that complicated, here is how it works in Lua (which GDscript is inspired by):
function return_three_values()
    return 1, "string", {"an array"}
end

an_int, a_string, an_array = return_three_values()

Currently you would just create an array and put your variables in there, but there are three issues with that:

You have to pull them out of the array again
Its not as easy to read
Its not typed

in Lua (which GDscript is inspired by):

Actually GDScript was inspired by Python where this feature as in several other languages, called "tuple"

in Lua (which GDscript is inspired by):

Actually GDScript was inspired by Python where this feature as in several other languages, called "tuple"

It also has dictionaries, which are inspired by Lua's.

It also has dictionaries, which are inspired by Lua's

They are?  They seem extremely similar to Python's dictionaries.  Lua instead has Tables, which though conceptually similar to Dictionaries have some pretty fundamental differences that GDScript doesn't seem to have?

It also has dictionaries, which are inspired by Lua's

They are? They seem extremely similar to Python's dictionaries. Lua instead has Tables, which though conceptually similar to Dictionaries have some pretty fundamental differences that GDScript doesn't seem to have?

Oh, It seems like I have overlooked something there. GDscript also supports the lua syntax of dictionaries:
var table = {
    key = "value"
}

instead of pythons
var table = {
    "key" : "value"
}

http://docs.godotengine.org/en/3.0/getting_started/scripting/gdscript/gdscript_basics.html#dictionary

I would opt for python/c# style tuples
func get_data():
    return (get_player(), get_health(), get_score())

var player
var health
var score
(player, health, score) = get_data()

Also possible support for something like a, b, c = 5, 6, 7 as in python

Would love for a Python-esque multiple return syntax.

@atbigelow Please don't bump issues without contributing significant new information. Use the :+1: reaction button on the first post instead.

Feature and improvement proposals for the Godot Engine are now being discussed and reviewed in a dedicated Godot Improvement Proposals (GIP) (godotengine/godot-proposals) issue tracker. The GIP tracker has a detailed issue template designed so that proposals include all the relevant information to start a productive discussion and help the community assess the validity of the proposal for the engine.
The main (godotengine/godot) tracker is now solely dedicated to bug reports and Pull Requests, enabling contributors to have a better focus on bug fixing work. Therefore, we are now closing all older feature proposals on the main issue tracker.
If you are interested in this feature proposal, please open a new proposal on the GIP tracker following the given issue template (after checking that it doesn't exist already). Be sure to reference this closed issue if it includes any relevant discussion (which you are also encouraged to summarize in the new proposal). Thanks in advance!


Automatically go back to default nick once it's available

This could be done with NOTIFY and such


Lowercase

Resolving #14 by adding an option to convert to lower case.

oops, made an error let me try again.


Updated the Generics Manifesto

Updated the Generics Manifesto on the state of the different features.

@swift-ci Please smoke test

Thanks! The changes look good to me but let's wait until one of the reviewers nominated by Jordan signs off.

Why not just remove the things which have made it to official releases? The document would be more helpful if it was slimmed of the parts which made it in to Swift 3 (and 3.1 when that's released).

It makes sense to me for the manifesto to record notes of things that were implemented.  Manifestos like this aren't really meant to be teaching aids, and they have value as design artifacts that gets lost if you have to backtrace through the version history to read the original document.

@swift-ci Smoke test

@swift-ci please smoke test

@swift-ci please smoke test