update proxy sha to latest

[ ] Configuration Infrastructure
[ ] Docs
[ ] Installation
[ X ] Networking
[ ] Performance and Scalability
[ ] Policies and Telemetry
[ ] Security
[ ] Test and Release
[ ] User Experience
[ ] Developer Infrastructure
Pull Request Attributes
Please check any characteristics that apply to this pull request.
[ ] Does not have any changes that may affect Istio users.

@GregHanson: The following test failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

integ-security-k8s-tests_istio_release-1.8
15ce5b636f46e806565d4be9271f75f281a3b092
link
/test integ-security-k8s-tests_istio_release-1.8

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@GregHanson: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

integ-security-k8s-tests_istio_release-1.8
15ce5b636f46e806565d4be9271f75f281a3b092
link
/test integ-security-k8s-tests_istio_release-1.8

integ-distroless-k8s-tests_istio_release-1.8
15ce5b636f46e806565d4be9271f75f281a3b092
link
/test integ-distroless-k8s-tests_istio_release-1.8

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@GregHanson: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

integ-security-k8s-tests_istio_release-1.8
15ce5b636f46e806565d4be9271f75f281a3b092
link
/test integ-security-k8s-tests_istio_release-1.8

integ-distroless-k8s-tests_istio_release-1.8
15ce5b636f46e806565d4be9271f75f281a3b092
link
/test integ-distroless-k8s-tests_istio_release-1.8

integ-operator-controller-tests_istio_release-1.8
15ce5b636f46e806565d4be9271f75f281a3b092
link
/test integ-operator-controller-tests_istio_release-1.8

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@GregHanson: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

integ-security-k8s-tests_istio_release-1.8
15ce5b636f46e806565d4be9271f75f281a3b092
link
/test integ-security-k8s-tests_istio_release-1.8

integ-distroless-k8s-tests_istio_release-1.8
15ce5b636f46e806565d4be9271f75f281a3b092
link
/test integ-distroless-k8s-tests_istio_release-1.8

integ-operator-controller-tests_istio_release-1.8
15ce5b636f46e806565d4be9271f75f281a3b092
link
/test integ-operator-controller-tests_istio_release-1.8

integ-pilot-k8s-tests_istio_release-1.8
15ce5b636f46e806565d4be9271f75f281a3b092
link
/test integ-pilot-k8s-tests_istio_release-1.8

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@GregHanson: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

integ-security-k8s-tests_istio_release-1.8
15ce5b636f46e806565d4be9271f75f281a3b092
link
/test integ-security-k8s-tests_istio_release-1.8

integ-distroless-k8s-tests_istio_release-1.8
15ce5b636f46e806565d4be9271f75f281a3b092
link
/test integ-distroless-k8s-tests_istio_release-1.8

integ-operator-controller-tests_istio_release-1.8
15ce5b636f46e806565d4be9271f75f281a3b092
link
/test integ-operator-controller-tests_istio_release-1.8

integ-pilot-k8s-tests_istio_release-1.8
15ce5b636f46e806565d4be9271f75f281a3b092
link
/test integ-pilot-k8s-tests_istio_release-1.8

integ-telemetry-k8s-tests_istio_release-1.8
15ce5b636f46e806565d4be9271f75f281a3b092
link
/test integ-telemetry-k8s-tests_istio_release-1.8

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@GregHanson: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

integ-security-k8s-tests_istio_release-1.8
15ce5b636f46e806565d4be9271f75f281a3b092
link
/test integ-security-k8s-tests_istio_release-1.8

integ-distroless-k8s-tests_istio_release-1.8
15ce5b636f46e806565d4be9271f75f281a3b092
link
/test integ-distroless-k8s-tests_istio_release-1.8

integ-operator-controller-tests_istio_release-1.8
15ce5b636f46e806565d4be9271f75f281a3b092
link
/test integ-operator-controller-tests_istio_release-1.8

integ-pilot-k8s-tests_istio_release-1.8
15ce5b636f46e806565d4be9271f75f281a3b092
link
/test integ-pilot-k8s-tests_istio_release-1.8

integ-telemetry-k8s-tests_istio_release-1.8
15ce5b636f46e806565d4be9271f75f281a3b092
link
/test integ-telemetry-k8s-tests_istio_release-1.8

release-test_istio_release-1.8
15ce5b636f46e806565d4be9271f75f281a3b092
link
/test release-test_istio_release-1.8

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@GregHanson: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

integ-security-k8s-tests_istio_release-1.8
15ce5b636f46e806565d4be9271f75f281a3b092
link
/test integ-security-k8s-tests_istio_release-1.8

integ-distroless-k8s-tests_istio_release-1.8
15ce5b636f46e806565d4be9271f75f281a3b092
link
/test integ-distroless-k8s-tests_istio_release-1.8

integ-operator-controller-tests_istio_release-1.8
15ce5b636f46e806565d4be9271f75f281a3b092
link
/test integ-operator-controller-tests_istio_release-1.8

integ-pilot-k8s-tests_istio_release-1.8
15ce5b636f46e806565d4be9271f75f281a3b092
link
/test integ-pilot-k8s-tests_istio_release-1.8

integ-telemetry-k8s-tests_istio_release-1.8
15ce5b636f46e806565d4be9271f75f281a3b092
link
/test integ-telemetry-k8s-tests_istio_release-1.8

release-test_istio_release-1.8
15ce5b636f46e806565d4be9271f75f281a3b092
link
/test release-test_istio_release-1.8

unit-tests_istio_release-1.8
15ce5b636f46e806565d4be9271f75f281a3b092
link
/test unit-tests_istio_release-1.8

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@GregHanson: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

integ-security-k8s-tests_istio_release-1.8
15ce5b636f46e806565d4be9271f75f281a3b092
link
/test integ-security-k8s-tests_istio_release-1.8

integ-distroless-k8s-tests_istio_release-1.8
15ce5b636f46e806565d4be9271f75f281a3b092
link
/test integ-distroless-k8s-tests_istio_release-1.8

integ-operator-controller-tests_istio_release-1.8
15ce5b636f46e806565d4be9271f75f281a3b092
link
/test integ-operator-controller-tests_istio_release-1.8

integ-pilot-k8s-tests_istio_release-1.8
15ce5b636f46e806565d4be9271f75f281a3b092
link
/test integ-pilot-k8s-tests_istio_release-1.8

integ-telemetry-k8s-tests_istio_release-1.8
15ce5b636f46e806565d4be9271f75f281a3b092
link
/test integ-telemetry-k8s-tests_istio_release-1.8

release-test_istio_release-1.8
15ce5b636f46e806565d4be9271f75f281a3b092
link
/test release-test_istio_release-1.8

unit-tests_istio_release-1.8
15ce5b636f46e806565d4be9271f75f281a3b092
link
/test unit-tests_istio_release-1.8

integ-ipv6-k8s-tests_istio_release-1.8
15ce5b636f46e806565d4be9271f75f281a3b092
link
/test integ-ipv6-k8s-tests_istio_release-1.8

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@GregHanson: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

integ-security-k8s-tests_istio_release-1.8
15ce5b636f46e806565d4be9271f75f281a3b092
link
/test integ-security-k8s-tests_istio_release-1.8

integ-distroless-k8s-tests_istio_release-1.8
15ce5b636f46e806565d4be9271f75f281a3b092
link
/test integ-distroless-k8s-tests_istio_release-1.8

integ-operator-controller-tests_istio_release-1.8
15ce5b636f46e806565d4be9271f75f281a3b092
link
/test integ-operator-controller-tests_istio_release-1.8

integ-pilot-k8s-tests_istio_release-1.8
15ce5b636f46e806565d4be9271f75f281a3b092
link
/test integ-pilot-k8s-tests_istio_release-1.8

integ-telemetry-k8s-tests_istio_release-1.8
15ce5b636f46e806565d4be9271f75f281a3b092
link
/test integ-telemetry-k8s-tests_istio_release-1.8

release-test_istio_release-1.8
15ce5b636f46e806565d4be9271f75f281a3b092
link
/test release-test_istio_release-1.8

unit-tests_istio_release-1.8
15ce5b636f46e806565d4be9271f75f281a3b092
link
/test unit-tests_istio_release-1.8

integ-ipv6-k8s-tests_istio_release-1.8
15ce5b636f46e806565d4be9271f75f281a3b092
link
/test integ-ipv6-k8s-tests_istio_release-1.8

integ-multicluster-k8s-tests_istio_release-1.8
15ce5b636f46e806565d4be9271f75f281a3b092
link
/test integ-multicluster-k8s-tests_istio_release-1.8

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@GregHanson: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

integ-security-k8s-tests_istio_release-1.8
15ce5b636f46e806565d4be9271f75f281a3b092
link
/test integ-security-k8s-tests_istio_release-1.8

integ-distroless-k8s-tests_istio_release-1.8
15ce5b636f46e806565d4be9271f75f281a3b092
link
/test integ-distroless-k8s-tests_istio_release-1.8

integ-operator-controller-tests_istio_release-1.8
15ce5b636f46e806565d4be9271f75f281a3b092
link
/test integ-operator-controller-tests_istio_release-1.8

integ-pilot-k8s-tests_istio_release-1.8
15ce5b636f46e806565d4be9271f75f281a3b092
link
/test integ-pilot-k8s-tests_istio_release-1.8

integ-telemetry-k8s-tests_istio_release-1.8
15ce5b636f46e806565d4be9271f75f281a3b092
link
/test integ-telemetry-k8s-tests_istio_release-1.8

release-test_istio_release-1.8
15ce5b636f46e806565d4be9271f75f281a3b092
link
/test release-test_istio_release-1.8

unit-tests_istio_release-1.8
15ce5b636f46e806565d4be9271f75f281a3b092
link
/test unit-tests_istio_release-1.8

integ-ipv6-k8s-tests_istio_release-1.8
15ce5b636f46e806565d4be9271f75f281a3b092
link
/test integ-ipv6-k8s-tests_istio_release-1.8

integ-multicluster-k8s-tests_istio_release-1.8
15ce5b636f46e806565d4be9271f75f281a3b092
link
/test integ-multicluster-k8s-tests_istio_release-1.8

release-notes_istio_release-1.8
15ce5b636f46e806565d4be9271f75f281a3b092
link
/test release-notes_istio_release-1.8

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

/test unit-tests_istio_release-1.8

/retest

Why this PR is not merging..

/retest

@bianpengyuan in the tide link it shows https://github.com/istio/istio/pull/28366 in front of this one (and tests are still running for it)

@GregHanson Ok, thanks! Not sure why tide was not showing that when I checked. It seems a bit slower than normal merging, not sure if it is because of the flake.

Automator beat us to it:
https://github.com/istio/istio/pull/28358


Laravel 10

Hi. Can you please add support for laravel 10?

Hi, I just released a new version. Could you give it a try and let me know if it works? Thank you!


Issue #942 ,Responsiveness

Fixes Issue

Changes proposed

Screenshots

Note to reviewers

share your changes so that i can review

Hi @codervivek5 , This are the changes I did in styling:
/* Media queries for small devices */
@media screen and (max-width: 767px) {
.container {
flex-direction: column;
align-items: center;
padding-top: 20px;
}
.container img {
width: 100%;
max-width: 40px;
height: auto;
margin: 2px 40px;
}
.container a {
font-size: 16px;
}
.content {
text-align: center;
padding: 0 20px;
}
.content h1 {
font-size: 40px;
}
.content h4 {
font-size: 16px;
margin-top: 20px;
padding-right: 20px;
}
.local input[type='search'] {
padding: 10px 20px;
font-size: 18px;
}
.Accessories-box {
width: 100%;
margin: 20px 0;
}
.rectangle-42 {
height: 150px;
}
.product-name {
font-size: 18px;
}
.container .sec-img{
max-width: 1000px;
}
}
/* Media queries for larger mobile devices and tablets */
@media screen and (min-width: 768px) and (max-width: 991px) {
.content h1 {
font-size: 60px;
}
.content h4 {
font-size: 18px;
}
.container img {
width: 100%;
max-width: 70px;
height: auto;
margin: 20px 0;
}
.container .sec-img{
max-width: 1000px;
}
}
/* Media queries for tablets and smaller laptops */
@media screen and (min-width: 992px) and (max-width: 1199px) {
.content h1 {
font-size: 70px;
}
.content h4 {
font-size: 20px;
}
.container img {
width: 100%;
max-width: 70px;
height: auto;
margin: 20px 0;
}
.container .sec-img{
max-width: 1000px;
}
}

bro share screens shot

See @codervivek5  Screenshots,

kindly mention your issue number

Hi, My issue number is #942
Not responsive for mobile devices, I want to make it responsive #942

ok got it but you need to make some more changes like FAQ section is perfect

reduced the size of the Google button and mobile and set them side by side only for mobile devices
reduced the image size of "our services"
also fix the product size like headphones and t-shirts size

HI @codervivek5 I did changes as per your wish,
My issue no is #942 ..

headphone section in not fixed see the price tag is overflow to other

Done @codervivek5 , See this :

Issue #942.

ok now perfect

Hi @codervivek5 ,
I have one request for you plz change my label to level3 it only count level wise.
See this.

Thankyou for let me know about this


Avoid auto-applying GE plugin if its marker is on the buildscript classpath

Instead of only checking for the group/artifact ID of the plugin's JAR, DefaultAutoAppliedPluginHandler now also checks for the plugin marker's coordinates.
Moreover, this PR adds a test for applying the GE plugin via an init script which documents the current behavior: the application triggered by --scan comes before the application triggered in a settingsEvaluated hook in the init script.
Follow-up on #22674.

@bot-gradle test PullRequestFeedback

OK, I've already triggered the following builds for you:

PullRequestFeedback build

@bot-gradle test and merge

No milestone for this PR. Please set a milestone and retry.

@bot-gradle test and merge

@bot-gradle test and merge

Your PR is queued. See the queue page for details.

OK, I've already triggered a build for you.


Minikube IP Address fixup for ingress demonstration

Tested on Minikube for macOS.
When using Minikube, the IP address listed in kubectl get ingress is the internal Minikube IP address and is not available on the web browser.
Added advice to the user that when using Minikube, add the Minikube IP address to the Hosts file instead of the IP address displayed in kubectl get ingress.

/lgtm

/approve


nixos/tools: add desktopConfiguration option (to seed configuration into configuration.nix)

Motivation for this change
In 20.09 we added a GNOME ISO. It would be really great if, for all graphical iso's, we seed a configuration that isn't commented and only used in those respective iso's. I believe @samueldr first suggested this on the thread about adding a GNOME ISO. My current disposition is that we should block on this, I think we will have enough time to get this feature in, and it would make having another ISO feel more meaningful. If not, I'm not sure about backporting.
I also cleaned up the configuration.nix a bit, @ttuegel mentioned we should not call plasma "KDE" so I made that change to the generated configuration.nix along with some other things.
I will say, off the bat, the only issue with this is the configuration desktopConfiguration isn't indented properly. Anyone knowing perl or who can spot the mistake (I'm sleepy :grin: ) please mention.
Things done

[x] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
Built on platform(s)

[x] NixOS
[ ] macOS
[ ] other Linux distributions

[x] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
[ ] Tested execution of all binary files (usually in ./result/bin/)
[ ] Determined the impact on package closure size (by running nix path-info -S before and after)
[ ] Ensured that relevant documentation is up to date
[x] Fits CONTRIBUTING.md.

@ofborg test nixos-generate-config

Just my 2¢, but I wouldn't block the release on this new feature. If it is deemed to be really desirable, I guess backporting this self-contained feature early in the release process wouldn't be an issue.
It's not like this was a regression, we've been generating the commented-out section for a good while, so going with it for just a bit longer isn't going to cause problems.

Just my 2¢, but I wouldn't block the release on this new feature. If it is deemed to be really desirable, I guess backporting this self-contained feature early in the release process wouldn't be an issue.
It's not like this was a regression, we've been generating the commented-out section for a good while, so going with it for just a bit longer isn't going to cause problems.

I'll take your advice as former RM :+1:

Do i understand it correctly that the behavior should be like

download GNOME ISO
just install
have GNOME desktop installed

that sounds very intuitive

Do i understand it correctly that the behavior should be like
1. download GNOME ISO

2. just install

3. have GNOME desktop installed

that sounds very intuitive

Precisely. The most basic user should have an aligned configuration for the image they have chosen to use

Do i understand it correctly that the behavior should be like
1. download GNOME ISO

2. just install

3. have GNOME desktop installed

that sounds very intuitive

Precisely. The most basic user should have an aligned configuration for the image they have chosen to use

Though I will add that "2. just install" probably won't be a reality because they still have to configure a user manually.

A solution for that, at least at the cli front, is that nixos-generate-config creates a users.nix to be added to the imports of configuration.nix. And maybe it can have some behavior where it prompts you for

single user multi user creations
setup password on first boot or immutable users with a hashed password (we could handle the hashing ourselves)
also add flags on the cli

The "setup password on first boot" is actually an option that a lot gui's I think could accommodate, like I think gnome-initial-setup can do it and in pantheon (maybe if I poke them in a way we could use). That's considered an "OEM type" install and it's actually the most convenient for the enduser for a single user system. Anyways, I'd want to steer from the discussion of having a graphical installer and then just focus on that issue of having a not so intuitive user creation.

On that note, nixos-generate-config is an actually confusing name for the tool is it not? It doesn't actually create you a really usable configuration and you can't continue to generate your config with this tool subsequently. What could be ideal is a cli tool to actually generate nix configs. @mkg20001 told me about his tool that basically does exactly this https://github.com/ssd-solar/conf-tool. It has a seed, like I'm trying to do here, but it also has templates that a distributor can setup. While I enjoy this improvement I've made here, it's nothing radical like I really want that could also be fed into making a gui installer actually viable.


Fix(Consents): Fix email reply to.

Fixes https://github.com/carpentries/amy/issues/2030

@lauryndbrown I think you need to rebase against develop. I remember I fixed this error: https://github.com/carpentries/amy/runs/3330839656?check_suite_focus=true


server cannot be started in hit-refresh mode

The Project documentation lists the following command line arguments that should be passed to FtCLI constructor:
--port=1234         Tells the server to listen to TCP port 1234
--lifetime=5000     The server will die in five seconds (useful for integration testing)
--refresh           Run the server in hit-refresh mode
--daemon            Runs the server in Java daemon thread (for integration testing)
--threads=30        Processes incoming HTTP requests in 30 parallel threads
--max-latency=5000  Maximum latency in milliseconds per each request
                    (longer requests will be interrupted)

However, in the class org.takes.http.Options our method implementation that checks if we are in hit-refresh mode is currently implemented as follows:
public boolean hitRefresh() {
	return this.map.containsKey("hit-refresh");
}

There is an inconsistency between this.map.containsKey("hit-refresh"); and the command line argument --refresh. The will make org.takes.http.Options#hitRefresh() to always return false
The Latency method this.map.get("max-latency"); is matched well to the command line argument --max-latency

@yegor256 please take a look at it and dispatch (see par.21)

@simonjenga right, typo fixed in f36296d

@yegor256 You forgot to make the same change in the example App where it states:
Then, run it like this:
$ java -cp take.jar App.class --port=8080 --refresh

@simonjenga fixed in 95b291d thanks


virtual-scroll: improve performance

Right now virtual scroll is re-rendering viewport items on every scroll position change. We can improve performance by running re-render only if viewport gets closer to rendered boundaries.

When you scroll with swipe gesture on mobile, list will scroll for a while, causing continuous scroll event emitting. We should handle this situation somehow and render something when scroll gets slow.

Both problems solved in https://github.com/footballista/ftb-cmp/commit/c128c1d024ee834728411699d1a688d4c7ff685d
We've removed state change triggering and added native DOM manipulation on scroll


feat: migrate field (component field or input) to signal

Per file and per component and per field
ng g ngxtension:convert-di-to-inject --path $FilePathRelativeToProjectRoot$ --field $SelectedText$

Same thing can be done using vscode tasks: https://code.visualstudio.com/docs/editor/variables-reference#_predefined-variables
This can be a one-click thing in webstorm where you select the field and click the run button in the top bar run configurations.

The migration will follow this steps:

Check if it's already a signal -> skip
convert the field to signal
find the usages and if it's being assigned use set or update depending on the use case
replace only reads to include () -> we already do this for signal inputs
replace the template references -> we already do this for signal inputs

At this point we can easily migrate to signals by select a field and running a migration schematic
This should work for most of the cases and fail for some advanced ones, but we're not reaching for perfection here 😄

Closing as already will be handled by the fwk https://github.com/angular/angular/pull/57214


Stop the music with button

Hi I'm quite new to python but I've used your code to play music along side a light show. I'd like to stop the music playing unless my button latch is true. I can't use GOTO in pyton to skip the code, and I can't use an IF before CLASS.
If you have an idea how to do it I'd appreciate your help
Proton lights with dim & Music v3.11.zip
.

You can achieve that easily using interrupts.
Button is wired between GP16 and GND, we'll use can_play global variable that can be set to True if the music should play, False otherwise.
# define handler that manipulates our variable
def stop_music(_):
    global can_play
    can_play = False

can_play = True
button = Pin(16, Pin.IN, Pin.PULL_UP)
button.irq(trigger=Pin.IRQ_FALLING, handler=stop_music)

while can_play:
    mySong.tick()
    sleep(0.04)

The playback stops immediately once the button is pressed.


svd2rust: 0.31.3 -> 0.31.4

Automatic update generated by nixpkgs-update tools. This update was made based on information from https://github.com/rust-embedded/svd2rust/releases.
meta.description for svd2rust is: Generate Rust register maps (structs) from SVD files
meta.homepage for svd2rust is: https://github.com/rust-embedded/svd2rust
meta.changelog for svd2rust is: https://github.com/rust-embedded/svd2rust/blob/v0.31.4/CHANGELOG.md
Updates performed

Rust version update

To inspect upstream changes
Impact
Checks done

built on NixOS
The tests defined in passthru.tests, if any, passed
found 0.31.4 with grep in /nix/store/hnqr6jr23660hnlfpzsazn7m3bhsp6l3-svd2rust-0.31.4
found 0.31.4 in filename of file in /nix/store/hnqr6jr23660hnlfpzsazn7m3bhsp6l3-svd2rust-0.31.4

Rebuild report (if merged into master) (click to expand)

1 total rebuild path(s)

1 package rebuild(s)

First fifty rebuilds by attrpath
svd2rust

Instructions to test this update (click to expand)

Either download from Cachix:
nix-store -r /nix/store/hnqr6jr23660hnlfpzsazn7m3bhsp6l3-svd2rust-0.31.4 \
  --option binary-caches 'https://cache.nixos.org/ https://nix-community.cachix.org/' \
  --option trusted-public-keys '
  nix-community.cachix.org-1:mB9FSh9qf2dCimDSUo8Zy7bkq5CX+/rkCWyvRCYg3Fs=
  cache.nixos.org-1:6NCHdD59X431o0gWypbMrAURkbJ16ZPMQFGspcDShjY=
  '

(The Cachix cache is only trusted for this store-path realization.)
For the Cachix download to work, your user must be in the trusted-users list or you can use sudo since root is effectively trusted.
Or, build yourself:
nix-build -A svd2rust https://github.com/r-ryantm/nixpkgs/archive/f9f9155f67df9f7ea684c6203f6ecb0424621c65.tar.gz

Or:
nix build github:r-ryantm/nixpkgs/f9f9155f67df9f7ea684c6203f6ecb0424621c65#svd2rust

After you've downloaded or built it, look at the files and if there are any, run the binaries:
ls -la /nix/store/hnqr6jr23660hnlfpzsazn7m3bhsp6l3-svd2rust-0.31.4
ls -la /nix/store/hnqr6jr23660hnlfpzsazn7m3bhsp6l3-svd2rust-0.31.4/bin

Pre-merge build results
We have automatically built all packages that will get rebuilt due to
this change.
This gives evidence on whether the upgrade will break dependent packages.
Note sometimes packages show up as failed to build independent of the
change, simply because they are already broken on the target branch.
Result of nixpkgs-review run on x86_64-linux 1

1 package built:

svd2rust

Maintainer pings
cc @newAM for testing.

Result of nixpkgs-review pr 278816 run on x86_64-linux 1

1 package built:

svd2rust


Implemented: Pending review & its detail Review count page(#285)

Related Issues

Closes #285
Short Description and Why It's Useful

Implemented the Pending review page
Implemented  the Review count page , which is the details page of the pending review page.

Screenshots of Visual Changes before/after (If There Are Any)

Contribution and Currently Important Rules Acceptance

[x] I have read and followed contribution rules

Closing as merged in https://github.com/hotwax/inventory-count/pull/289


Crash when trying to save listed Websocket flows

Steps to reproduce the problem:

Make a websocket request with python websocket. Test url is ws://<IP_ADDRESS>:4200
Try to write flow to disk
Crash

Any other comments? What have you tried so far?
Traceback (most recent call last):   File "mitmproxy/tools/console/master.py", line 281, in run   File "site-packages/urwid/main_loop.py", line 278, in run   File "site-packages/urwid/main_loop.py", line 376, in _run   File "site-packages/urwid/main_loop.py", line 682, in run   File "site-packages/urwid/main_loop.py", line 719, in _loop   File "site-packages/urwid/raw_display.py", line 393, in <lambda>   File "site-packages/urwid/raw_display.py", line 493, in parse_input   File "site-packages/urwid/main_loop.py", line 403, in _update   File "site-packages/urwid/main_loop.py", line 503, in process_input   File "mitmproxy/tools/console/window.py", line 84, in keypress   File "site-packages/urwid/container.py", line 1116, in keypress   File "mitmproxy/tools/console/statusbar.py", line 155, in keypress   File "mitmproxy/tools/console/statusbar.py", line 110, in keypress   File "mitmproxy/tools/console/statusbar.py", line 133, in prompt_execute   File "mitmproxy/tools/console/statusbar.py", line 21, in __call__   File "mitmproxy/tools/console/master.py", line 388, in save_flows   File "mitmproxy/tools/console/master.py", line 382, in _write_flows   File "mitmproxy/io.py", line 27, in add   File "mitmproxy/contrib/tnetstring.py", line 66, in dump   File "mitmproxy/contrib/tnetstring.py", line 57, in dumps   File "mitmproxy/contrib/tnetstring.py", line 142, in _rdumpq   File "mitmproxy/contrib/tnetstring.py", line 142, in _rdumpq   File "mitmproxy/contrib/tnetstring.py", line 149, in _rdumpq ValueError: unserializable object: <WebSocketFlow (4 messages)> (<class 'mitmproxy.websocket.WebSocketFlow'>)
System information
Mitmproxy version: 2.0.1 (release version) Precompiled Binary Python version: 3.5.2 Platform: Linux-4.4.0-89-generic-x86_64-with-debian-stretch-sid SSL version: OpenSSL 1.1.0e  16 Feb 2017 Linux distro: debian stretch/sid

Thanks for reporting this!
I believe this should already be fixed by https://github.com/mitmproxy/mitmproxy/pull/2114
Would you mind trying with the current git master version?

Thanks. I just upgraded to the latest release 2.0.2 and am getting the same error.
`Traceback (most recent call last):
File "mitmproxy/tools/console/master.py", line 281, in run
File "site-packages/urwid/main_loop.py", line 278, in run
File "site-packages/urwid/main_loop.py", line 376, in _run
File "site-packages/urwid/main_loop.py", line 682, in run
File "site-packages/urwid/main_loop.py", line 719, in _loop
File "site-packages/urwid/raw_display.py", line 393, in
File "site-packages/urwid/raw_display.py", line 493, in parse_input
File "site-packages/urwid/main_loop.py", line 403, in _update
File "site-packages/urwid/main_loop.py", line 503, in process_input
File "mitmproxy/tools/console/window.py", line 84, in keypress
File "site-packages/urwid/container.py", line 1116, in keypress
File "mitmproxy/tools/console/statusbar.py", line 155, in keypress
File "mitmproxy/tools/console/statusbar.py", line 110, in keypress
File "mitmproxy/tools/console/statusbar.py", line 133, in prompt_execute
File "mitmproxy/tools/console/statusbar.py", line 21, in call
File "mitmproxy/tools/console/master.py", line 388, in save_flows
File "mitmproxy/tools/console/master.py", line 382, in _write_flows
File "mitmproxy/io.py", line 27, in add
File "mitmproxy/contrib/tnetstring.py", line 66, in dump
File "mitmproxy/contrib/tnetstring.py", line 57, in dumps
File "mitmproxy/contrib/tnetstring.py", line 142, in _rdumpq
File "mitmproxy/contrib/tnetstring.py", line 142, in _rdumpq
File "mitmproxy/contrib/tnetstring.py", line 149, in _rdumpq
ValueError: unserializable object: <WebSocketFlow (4 messages)> (<class 'mitmproxy.websocket.WebSocketFlow'>)
mitmproxy has crashed!
Please lodge a bug report at:
https://github.com/mitmproxy/mitmproxy
Shutting down...
$ mitmproxy --version
Mitmproxy version: 2.0.2 (release version) Precompiled Binary
Python version: 3.5.2
Platform: Linux-4.4.0-89-generic-x86_64-with-debian-stretch-sid
SSL version: OpenSSL 1.1.0e  16 Feb 2017
Linux distro: debian stretch/sid `

mitmproxy v2.0.2 does not yet contain this fix.
Please try the current git master version.

Looks like it is working as expected. Thanks!


Not all "My List" contents showing up.

not sure how to get debug for it, but not all of the shows in "My List" show up...

Duplicate of https://github.com/asciidisco/plugin.video.netflix/issues/42


Ignore exceptions from type coercion in value comparison

It's a simple change to avoid exceptions getting thrown from coercion of complex types from string back to the object to completely break the comparison. I have the feeling that this method needs a bit more work, as calling ToString() and then converting it back into a type can fail for many types, even the less complex ones.

@dotnet-policy-service agree [company="Milano Engineering GmbH"]

@dotnet-policy-service agree company="Milano Engineering GmbH"


transparency

Is transparency supported or has that been omitted in favour of speed?

Transparency is a missing feature, just because we haven't implemented it. Patches are welcome, as long as they don't slow down the rest of the library.


skip when network status.serviceNetwork is nil

Skip when the network config status.serviceNetwork is nil
related issue: https://github.com/openshift/cluster-kube-apiserver-operator/issues/1564

@tkashem @p0lyn0mial

/reopen

@vrutkovs

We don't use Github issues to track CKAO issues, please file a new one at https://issues.redhat.com/, project OCPBUGS, component "kube-apiserver"

/close


Update to latest MongoDB 4.x java driver

Update from old Mongo Java driver 3.x to 4.x (see MongoDB Compatibility)

See the following migration guide for the Mongo driver:
https://www.mongodb.com/docs/drivers/java/sync/current/legacy/#api-changes

See the following in Compatibility Changes in MongoDB 4.2 about the geoNear command:
https://www.mongodb.com/docs/manual/release-notes/4.2-compatibility/#remove-support-for-the-geonear-command


Why not support Widows & Linux & MacOS

Why not support Widows & Linux & MacOS??

As depends only on flutter, the package support Widows & Linux & MacOS, i do use on windows, linux and macos

@rodolfogoulart Actually, that's not quite right, trackpad scrolling seems to be broken on Windows. Any listview under this Tabbar doesn't scroll with finger gestures on trackpad on windows, and you have to drag the screen (click and move) as if you were on mobile to scroll or drag the side bar, so I would consider from that that windows is stil not officially supported.

@JanHitako i have this problem too. But you can fix this using a ScrollBehavior
class CustomScrollBehavior extends MaterialScrollBehavior {
  // Override behavior methods and getters like dragDevices
  @override
  Set<PointerDeviceKind> get dragDevices => {
        PointerDeviceKind.touch,
        PointerDeviceKind.mouse,
        PointerDeviceKind.trackpad,
      };
}

Just wrap your listview on a ScrollController
ScrollConfiguration(
      behavior: CustomScrollBehavior(),
      child: ListView()    <- your listView
)

@rodolfogoulart Yes, I resolved the issue this way as well, it also work as expected by either wrapping it in a NestedViewController when applicable or using any other parent that passes their own ScrollController down the widget tree containing the TabBar. Essentially, if there’s a standard ScrollController available to pass down, it functions correctly. Otherwise, it defaults to this unusual behavior. I might look into this further and submit a PR, but I currently don’t have much time but still consider this to not be fully supporting windows at the moment.


[FEATURE REQUEST] Adding icons to navbar

Description
Is your feature request related to a problem? Please describe.
I observed that there is no icons beside anchor tags in navbar.
Describe the solution you'd like
I'll add icons beside anchor tags in navbar.
Additional Information
Context
By adding it, it looks more attractive
Additional Notes (optional)
I am SSOC'24 Contributor.
Please assign me this task.

@akshitagupta15june  Kindly assign me this issue under SSoC'24.


feat(Popup): add focus trap

This PR introduces focus trap functionality to Popup - this will allow to focus popup's content right after popup is opened.
TODO

[x] introduce focus trap examples
[ ] update CHANGELOG

API
// focusable popup content will be trapped by default
<Popup trigger={<Button .. />} content={<Input />} />

// focusTrap={false} will disable default focus trap
<Popup focusTrap={false} trigger={<Button .. />} content={<Input />} />

// it is possible to customize focus trap behavior
<Popup focusTrap={{ isClickableOutsideFocusTrap: false, elementToFocusOnDismiss: null }}
  trigger={<Button .. />}
  content={<Input />}
/>

FAQ

Why Portal component is not reused here? It seems that it already supports Focus Trap functionality.

Should be clear about that - the final goal of all the refactoring process around Popup component is to end up at the point where there won't be any code duplication - and this implies that finally Popup will reuse Portal's functionality. At the same it is intentionally step-by-step process taken into consideration, for the sake of ensuring that only the necessary parts are introduced to both components, as well as there is clear separation of concerns between them.

Where we are at the moment with Popup?

This PR will solidify final bits of the functionality expected from the Popup on the client side - after that the next plans are to do inner refactoring by reusing Portal component as part of Popup's implementation - with the interface and behavior exposed to the client for Popup won't be affected anyhow.

can you add unit test that cover the changes? Especially if we want to do internal refactoring.

@jurokapsiar
yes, but could we, please, start with reviewing the functionality itself - whether it satisfies the criterias. When we agree on that, I will add the tests. Also, given that this is a highly anticipated feature, I would rather split the PRs to not introduce the unnecessary delay (note that there were no tests for that before).


fix: Redacted mention of specific Yocto LTS releases

We support the two latest (at any given time), and this already seems out-dated.
Ticket: Men-7484
Changelog: None

I see this is approved, but ci gitlab pipeline failed. Should I merge this or ... ?

Author: Nick Anderson<EMAIL_ADDRESS>Date:   Fri Aug 23 14:33:14 2024 -0500
fix: Redacted mention of specific Yocto LTS releases
We support the two latest (at any given time), and this already seems out-dated.

Ticket: Men-7484
Changelog: None

Commit 5bb69024486d56c2b785a182cbdfed8bde7e3740 is not signed off! Use --signoff with your commit. Make sure that the Author of the commit matches the one in Signed-off-by
Cleaning up project directory and file based variables 00:01
ERROR: Job failed: exit code 1

Opened backport pr https://github.com/mendersoftware/mender-docs/pull/2453


Fixing E2E Flake Redeploy VM

Which issue this PR addresses:

Fixes
Here are the flakes (with logs) I was able to discover that this PR should resolve:

500 responses on the redeploy request
A successful request, that never redeploys the node

What this PR does / why we need it:

Test plan for issue:

Is there any documentation that needs to be updated for this PR?

/azp run e2e

/azp run e2e

/azp run e2e

Having looked at this and tested the resiliency of the azure go sdk - I think this is a K8s event "reliability" issue. K8s Events are not guaranteed, especially over short timeframes (like a vm redeploy that takes <40s - the default heartbeat for Node readiness). I believe we're just seeing a Node go down and come back up between heartbeats, so K8s is none the wiser and doesn't bother populating Events it wouldn't know how to generate anyway.
While it looks strange to remove a test entirely, I think this is proper here - this test does not test the functionality/reliability of our code, but rather, the system underneath (kubelet/Events/Node readiness). What we really care about is: if I redeploy (successfully), do my Nodes come back up eventually?


Module not found: Error: Can't resolve 'angular-tree-component'

It can be stuped but I'm novice with angular and npm, but really want to use your lib.
I installed your package via npm, as mentioned at https://angular2-tree.readme.io/docs/getting-started. Npm says that I need to install a couple of peer dependencies like angular/common and angular/core. I installed them too with rxjs and zone.js.
But after all of this manipulation I still have error:

Module not found: Error: Can't resolve 'angular-tree-component'

Of course I have
import { TreeModule } from 'angular-tree-component';
@NgModule({
  imports: [..., TreeModule],
  ...
})

in my module. What is the reason of this error? Why angular cant find your module? And how to fix that? May be that problem related with angulat/cli that I use to serve and generate?

If you use angular cli then you already have angular/core and angular/common installed.
Do you have angular-tree-component in your package.json?
Can you send a link to your code on github?
Doesn't sound like an issue with the library - I'm closing the issue and if I can reproduce it I'll reopen it.

Yes, the problem was in lack of dependency in package.json. Thanks.


Hero Idea, Name: V2 ( name/lore is work in progress)

I know we arn't at heros yet but i just wanted to put this here so I wouldnt forget. Close it if you want I will reopen later.
Other notes: I really need help balancing numbers and talents, as well as coming up with better lore if anyone wants to help.
Stats:
Primary Attribute: Int
Base Health: 500
Base armor: 4
Base Attack: 35
Base Range: 475
Base Strength: 20.          Str.Gain: 1.9
Base Agility: 20.             Agi.Gain: 1.9
Base Intelligence: 20.    Int.Gain:  2.4
Standard for everything other stat
1rst ability: Wave Dance
Dash to target area quickly wile letting out 2 attacks to the closest unit
range 100/200/300/400, cooldown 20/15/10/6
2nd ability: Morph Damage (toggle)
Morph a portion of your physical damage into magic damage(right click and other sources)
Mana per second 50/65/80/95
Maximum % 25/50/75/100
Speed (%/s) 2/5/7/10
Hidden ability: Reverse Morph (like morphling it reverses the previous ability and shares the %/s upgrade and mana/s)
3rd ability: Breaching Wave
a medium speed aoe circular wave  originates from the hero and travels to the maximum range applies a slow and a debuff that lasts 8 seconds and reduces armor and magic resistance
range 150/200/250/300
slow% 5/10/15/20
armor reduction 3/5/7/10
magic resist reduction % 10/20/30/40
4th/ultimate ability: Tidal Strike
fires a thin aoe shot in a straight line (windrunners powershot) that does physical damage(affected by morph damage ability)
Damage 200/300/400
Range    800/900/1000
Talents:

20% mana regen/+ 200 health
200 attack range/ + 35 damage
15% Lifesteal/ + 8 all stats
300 cast range/ Max movement speed

Other/lore: So this is a hybrid of a hero from another game and morphling so idk how unique it is which might be its killing point, but i think it is interesting enough as a hybrid damage semi carry that isnt too tanky, has good mobility/chasing skills, and is an adaptable source of damage. I didn't really have lore in mind while creating it but i thought since it is similar to morphling I could use that to my advantage so here I go.
After Experiment 1 went haywire the Midigurshian, a sentient race of lifeforms with a knack for science, forced a group of their scientists to send experiment 1 to the far edges of the galaxy in an asteroid and cease their research. Upset with his creations banishment, Klyaxos, a particularly insidious researcher, stole away with a single cell from experiment 1. Night after night Klyaxos toiled in his own lab, desperately trying to recreate the semi-sentient creature from before to no avail.Years went by and noone saw or heard of the old reasearcher, until one night the townsfolk woke up to Kylaxos's lab exploding. The Goo had bonded with Kylaxos! The now monsterous scientist slew many Midigurshians on his way to the asteroid cannon where it launched of in search of its first creation.
 Pretty much it is a green morphling that is slightly taller and has 4 tentacles instead of arms. If anyone wants to make better lore I have no problem.

Closed to keep the github clean. Repost it when we are doing heroes.

Understood
On Feb 12, 2017 12:35 PM, "l34Um1"<EMAIL_ADDRESS>wrote:

Closed to keep the github clean. Repost it when we are doing heroes.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/AngelArenaAllstars/suggestions/issues/167#issuecomment-279234239,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AYcC-waWqoD3AROCR-TIbIIHBbljCYIwks5rb0L1gaJpZM4L-SjJ
.


[diags][cxx-interop] Update diagnostic for 'begin' to suggest using a for-loop instead.

Does not fix the fix-it. The current fix it will be left as a stop-gap solution and we can hopefully update this fix it in the near future to actually plop in a for loop (too much work for this PR though).
It's important to change this wording ASAP so that people aren't lead astray.

@swift-ci please test


HUD elements are invisible with Knob Control

I don't actually know which side is causing this conflict, so I'm mentioning the issue to both mod creators. After playing the Invasion modpack and acquiring the Cyberware Hudjack, I was unable to see my power levels. After quite a lot of removing and adding and swapping mods I eventually narrowed it down to Knob Control. Put it in, HUD disappears. Take it out, HUD returns.
No idea what could be causing that though since I'm entirely unfamiliar with Knob Control, and there are no errors thrown that I'm aware of. Everything apparently works as normal, just without the HUD.

Update: after messing around in the configs, it looks like the "remove potion icons" setting in Knob Control is to blame. Changed that to False and the Cyberware HUD stuff shows up again.
Still not sure which side is causing the issue though. Might be this side attaching HUD elements to things they probably shouldn't be, might be Knob Control being too broad in their definition of "potion icons".
Either way, hope this helps.

It seems to be this issue here: https://github.com/Flaxbeard/Cyberware/blob/28a61675f0839b59416a8ab200efbc13ef66754f/src/main/java/flaxbeard/cyberware/common/handler/HudHandler.java#L131
Knob control and a hand full of others mods like potion Icon remover cancel this event all together to not show potions, Its in turn canceling the potion drawing event on Pre, and since yours draws on post it is never called. If you switch it on your side. it will be compatible with other mods that cancel the potion events.


edit instance condition

using a conditional operator instead of a basic condition is a good practice and the code looks neat.
and i am new  here so please reply, that would make my day even i am sure i didn't follow your instructions properly.

Hi @RaisingRay,
Thanks for your interest in contributing!
Unfortunately we can't accept this change because it doesn't work correctly--it never sets the "instance" field so new WinAppDriver() is called every time. Also, as mentioned in our guidelines we do not accept changes only to code formatting and style, such as switching a conditional block to a ternary.
I think a better way to improve this code would be to use a static initializer as mentioned in this comment--you might consider testing and then submitting that change instead.
I will close this PR for now, but we're glad you're here, and we hope you enjoy continuing to code with Calculator!


docs: add task reference section to PR template

Changing Closes into Part of should be enough. I don't want PR template to be complex.


Fix responsiveness of Links (QR) page

This PR fixes issue #638.
The page was not responsive on mobile and long texts were spilling out of their containers.
That has been fixed by adjusting the height of the buttons and wrapping texts.

The downside of this is that the buttons no longer have equal height, but I do not think this is a deal breaker.

Note for reviewers:
An alternative fix would be to set overflow to hidden, add display ellipsis (...) when text overflows and prevent text from wrapping with nowrap. The disadvantage is that users will not see some of the text.
.links {
    .button {
      display: inline-block; /* Make sure the button takes the width of its content */
      white-space: nowrap;
      overflow: hidden; /* Hide overflow text */
      text-overflow: ellipsis; /* Display ellipsis (...) when text overflows */
    }
  }
}

Thanks for taking the time to review! ❤

It does not work for me locally:

addressed in #860


white screen when.setKiosk is call

hi, when i run my app, i trie to show it only when he 's completely load. so i set show to false when i create the browserWindow and i use remote.getCurrentWindow().setKiosk(true); when i catch event 'did-finish-load in the render side . but for 1s i got a white screen. Do yu know how to fix this?
Thanks

We have some problems with kiosk mode, I'm merging this to #1054.

i ve the same error with setFullScreen, i use an X Window to show my atom-shell app so i don t really need kiosk mode but this white screen really annoy me. a way to avoid it?

On Linux kiosk mode is the same with fullscreen mode. I don't know a way to avoid it.

ok, thanks for this information, i didn t know that but this code give the same thing too:
in main.js:
app.on('ready', function() {
// Create the browser window.
var atomScreen = require('screen');
var size = atomScreen.getPrimaryDisplay().workAreaSize;
mainWindow = new BrowserWindow({ width: size.width, height: size.height,frame: false, show: false });
mainWindow.loadUrl('file://' + __dirname + '/index.html');
});
and in index.html:
onload = function() {
var loadstop = function() {
remote.getCurrentWindow().show();
};
webview.addEventListener("did-stop-loading", loadstop);
};
even this code give me the white screen


Message producer not starting new span

This is a new feature and I think it's a bug. Let's say you receive an http request that means you have to send a message. The result should be a new span. If we count the spans in the brewery, I bet they have changed since last week.

Assuming that we take the set up into account we should have the following flow:
We should have 6 spans:

first HTTP incoming message with its parent (2 spans)
then there is the message sent and received (2 spans)
then I'm calling rest template to myself with the HTTP message (1 span)
then I'm receiving that HTTP message (2 spans  but one is the same as the one in the first step)

2 + 2 + 1 + 1 = 6 spans. ATM we're missing this part:

then there is the message sent and received


ECS Constant cannot be found

After enabling the crew of the ECS Constant with a new grav drive in the mission "First Contact", the subsequent activity "Locate the ECS Constant" is added.  A marker is provided but the ship is not there.

Details
I am given a new activity mission to "Locate the ECS Contact" when completing the "First Contact" mission via the Grav Drive ending.  At this point I am given a new activity titled "Locate ECS Constant" - This typically places a marker in the Porima system where it's first found but the ship is not there.  Sometimes the marker is in another system or planet but every time I grav drive to the location the game provides the ship is nowhere to be found.
Game Version
<IP_ADDRESS>
Language
English (EN)
New Game
Yes
Reproduction Steps
I have never finished this mission so it was never difficult to recreate.  I am unaware if my situation is unique but I cannot locate a solution to this issue, even if it's user error (which is also possible lol)

Duplicate of #243


[icons] Generate TypeScript instead of JavaScript

An alternative to #22108
$ github-linguist
50.40%  TypeScript
49.58%  JavaScript
0.01%   HTML
0.00%   Shell

But now we have to transpile those tsx files. Did we have some issues with the generated code that requires type-checking? If not we might was well generate js.
Seems like wasted effort just to appear like using TypeScript. The easier part is to just use actual typescript.

@eps1lon At minium we have here a reproduction with https://github.com/mui-org/core-plus-pickers/pull/5#discussion_r470219583 🤷♂

just to appear like using TypeScript.

@eps1lon Yes, this is the only objective: appearance. I think is as important as what's behind the appearance. We could almost argue that appearance than intrinsic value is more important for a User Interface project 😁.
I was covering the problem in https://github.com/mui-org/material-ui/pull/22108#issuecomment-670943765:

Short term: the reported JavaScript vs TypeScript ratio doesn't seem to draw an accurate representation of the usage of TypeScript in the codebase: 5% of TypeScript sources?!
Long term: we are progressively moving toward a codebase fully written in TypeScript, once we will have fully migrated the components, we would still have GitHub reports a majority of JavaScript files which will be still misleading for new users. Why? because the icons account for half the files in the repository.

We could almost argue that appearance is more important than intrinsic value for a User Interface project 😁.

I have a big problem with this statement morally. This mentallity will hurt us long term. It doesn't build trust with users which is important for a big component library. I do object to these changes and

But the stats are wrong either way. At least previously we didn't intentionally manipulate them.

-- https://github.com/mui-org/material-ui/pull/22108#issuecomment-670944883
still applies

Also on a practical note: Seems like yarn lint and yarn typescript take each a minute longer now.

It doesn't build trust with users which is important for a big component library.

@eps1lon I agree with the "trust" and "long term" part of the comment. It's all about the perceived value and feeling of depending on/using the product. Trust is a big part of it, it's definitely something we should optimize for. We should also be long term focused. My point is that this pull request aims for increasing trust, in the long term. I think that Matt offers a great transition with his comment.

If there's an issue with how the github algorithm calculates language content of repos, please work to get that changed instead.

@mbrookes I have been looking at the scope of the options available before going in this direction. While they are no great answer, I would qualify this one as the "best worse alternative". Here are the options we have:

We do nothing. Once we have migrated the whole codebase to TypeScript (without the icons), we would get an inaccurate report, letting people misleading think we still significantly use JavaScript, while, in reality, we don't.

Current:
94.62%  JavaScript
5.37%   TypeScript
0.01%   HTML

Long term:
54.96%  TypeScript
45.03%  JavaScript
0.01%   HTML

We remove the icons from the git repository. This would prevent us to accurately review the change in the source from Google as well as improvement in the generation script. Result:

89.34%  JavaScript
10.64%  TypeScript
0.02%   HTML

We flag the generated icons as "generated". We can use the linguist-generated option. However, GitHub indicates that it would have the same downsides as 2. https://docs.github.com/en/github/administering-a-repository/customizing-how-changed-files-appear-on-github. Result:

89.34%  JavaScript
10.64%  TypeScript
0.02%   HTML

We flag the generated icons as "vendor". As described in https://github.com/github/linguist#vendored-code. But these files aren't vendors, they are sources. Result:

89.34%  JavaScript
10.64%  TypeScript
0.02%   HTML

We go all-in in TypeScript. We generate TypeScript files. Result:

50.40%  TypeScript
49.58%  JavaScript
0.01%   HTML
0.00%   Shell

Which option would you rather go for?
Interestingly:

GitHub flags /docs and /examples as linguist-documentation. I wonder if we would want to include them from the statistics. Aren't demos and examples as important as the source?
GitHub flags the manual .d.ts files we generate as linguist-vendor. I wonder if we would want to include them in the statistics. They are not generated not coming from an external source.
All the current TypeScript statistics (5%) come from the generated framer files, the tests, and the build scripts. Nothing from the actual components.

This opens the following question, what should we include for the "Languages" statistics? What do developers expect this to account for?

Seems like yarn lint and yarn typescript take each a minute longer now.

@eps1lon These files should be already ignored from TypeScript and eslint linting. The reported time seems really close to the one from the next branch. If you were expecting faster runs, the regression is likely coming from another change.

think that we can migrate the icons to TypeScript, and include all the sources we have, to be inclusive and help us track more accurately where we are in the TypeScript coverage.
.gitattribute
# Set the default behavior, in case people don't have core.autocrlf set.
* text=auto
/docs/* -linguist-documentation
/examples/* -linguist-documentation
*.d.ts -linguist-vendored

Output:
57.93%  TypeScript
42.07%  JavaScript
0.01%   HTML

How about we set the icons as "vendor"? They originally come from Google. This could be good enough: They won't be taken into account in the source stats, not skewing them in any direction. We would retrain the git diff advantage of storing the icons in the repository.

Moving to #22397


feat: Adventurer Metadata not showing up on mintsquare

Metadata not showing:
https://mintsquare.io/asset/starknet-testnet/0x03a3873202c0db08fc47966e758579da6281d3c3d4cff71640e0c98ebbad4df0/7

I can't see any problem in the metadata, however it seems contract is not following correct interface.
Calling and joining array from starkscan (https://testnet.starkscan.co/contract/0x03a3873202c0db08fc47966e758579da6281d3c3d4cff71640e0c98ebbad4df0) we get:
data:application/json,
{
  "description": "Adventurer",
  "name": "loaf",
  "image": "https://ipfs.io/ipfs/{{.webp",
  "attributes": [
    { "trait_type": "Race", "value": "Elf" },
    { "trait_type": "Home Realm", "value": "Stolsli" },
    { "trait_type": "Order", "value": "Power" },
    { "trait_type": "Birthdate", "value": "1676262189" },
    { "trait_type": "Health", "value": "100" },
    { "trait_type": "Level", "value": "1" },
    { "trait_type": "Strength", "value": "0" },
    { "trait_type": "Dexterity", "value": "0" },
    { "trait_type": "Vitality", "value": "0" },
    { "trait_type": "Intelligence", "value": "0" },
    { "trait_type": "Wisdom", "value": "0" },
    { "trait_type": "Charisma", "value": "0" },
    { "trait_type": "Luck", "value": "0" },
    { "trait_type": "XP", "value": "0" },
    { "trait_type": "Neck", "value": "Wand" },
    { "trait_type": "Status", "value": "Idle" }
  ]
}

Odd that the neck has a wand (will need to see why that happened). But in starkscan the contract is marked without ERC721 when compared to the realms contract (which has metadata on aspect) (https://testnet.starkscan.co/contract/0x016a1b978c62be5c30faa565f2086336126db3f120fbe61f368d8e07f289ef03):

Any ideas on what it's missing? Will look into it.

it could potentially be a manual thing that the marketplace needs to set.
Wand: this was bug in first couple of Adventurers - is fixed now


[QUESTION] Is there any way to customize rows appending/deleting

Hello!
In our application we animate rows deletion/addition/modification with UITableView's deleteRows, insertRows and reloadRows inside performBatchUpdates. I haven't found any of these functions are called in TableDirector, does it mean it always use reloadData to update table?
Is there any way to customize this behaviour, for example, to call insertRows if I'm going to add some rows to exiting section?
//Thanks!

Found an answer in closed issues. See #69 #43


Review scope of doc-warden tool

In pull request #320 we discussed removing some of the package indexing logic from the doc-warden tool since not all of it is required anymore. It turns out that we need to index packages in order to accurate check capitalization of README.md file headers, and for presence information for CHANGELOG.md (and variants) files.
This issue is to do a bit of an overall review of the scope of the doc-warden tool and whether we can remove some functionality and reduce the complexity of the tool (i.e. not having to have deep knowledge of package types/formats to do its work).

With the conversion of .rst files to .md  in the python repo some of the DocWarden logic might need to be updated also.
There is also the issue of moving all changelog logic into the eng/common directory

Closing this since most of those changes were eventually made in eng/common rather than doc warden.


Building on the latest version of XCode?

I'd like to try and contribute some fixes, but I can't get it to build on the latest version of xcode/yosemite.  Has anyone been able to build it on xcode 6.1.1? I'm getting stuck trying to build shortcutrecorder.
Any ideas, such as where I can get a prebuilt version of shortcut recorder that can be linked, would be greatly appreciated!

I am have the  same problem ... did you go any further ?

No, sorry. I gave up, and did something else instead.


Add graceful processing for non-latin symbols: Error: Unknown rune: 1087

Hello!
Thank you for your awesome library!  I'm using it for CLI management.
I recently discovered that ishell fails when I enter some non-latin letters, for example "привет" accidentally.
And ishell stopping immediately:
root@cli> привет
Error: Unknown rune: 1087

<application stopped>

Could you add graceful processing for this case and just return error "incorrect rune" to CLL shell without stopping ishell application?
Thank you for your attention!

What version of ishell are you using ?

The behaviour I'm getting is different. Yes, there is an error message but the application is not getting terminated.
❯ go run example/main.go
Sample Interactive Shell
>>> привет
Error: Unknown rune: 1087
>>> |

This one: fb8c158a6681dcda157e2bdbe8fe7b0b419c7cbb

Oh, that's awesome! I will rebase to this branch and check! Thank you!

There are differences between v1 and v2 (current master). You will have to do couple of refactors to make your app compatible.

You can re-open this if the issue still exists.

Also, you can put the characters in quotes as a workaround.
❯ go run example/main.go
Sample Interactive Shell
>>> greet "привет"
Hello привет
>>>

Hello! Is there any plan to fix this? I can do this if it doesn't require a lot of refactoring and won't break something.
While commands can be latin-only it is quite common to use unicode in filenames or command arguments.

@abiosoft what do you think about providing custom splitter in config (defaulting to current shlex.Split)?
I can make a PR. Seems like the least invasive option.

go-shlex caused it:
	cmd := "D:\\codes\\测试\\aaaa.exe asdasd"
	fmt.Println(shlex.Split((cmd)))


Microk8s status is unaware of offline master-voter node

Hello,
Given a high-availability setup, what is the expected behavior when one of the master nodes (but not the leader) is powered off? For the underlying dqlite database, it means one of the voters is powered off.
The official docs indicate that:

If the leader node gets “removed” ungracefully, e.g. it crashes and never comes back, it will take up to 5 seconds for the cluster to elect a new leader.
Promoting a non-voter to a voter takes up to 30 seconds. This promotion takes place when a new node enters the cluster or when a voter crashes.

So, I expect that if a voter crashes or it's powered-off, then a non-voter is promoted to a voter in 30 seconds, or the cluster gets out of high-availability.
Here is my cluster. I turned off bignode, and then it appears as NotReady. However, it's still listed as a master node (voter, I assume) in the output of microk8s status, long after the 30 seconds and the status keeps reporting the cluster as high-available.
Is this normal? Can you reproduce it?
ubuntu@bluenode:~$ microk8s kubectl get nodes -o wide
NAME         STATUS     ROLES    AGE    VERSION                    INTERNAL-IP      EXTERNAL-IP   OS-IMAGE             KERNEL-VERSION     CONTAINER-RUNTIME
bignode      NotReady   <none>   2d1h   v1.21.1-3+08fd9d63ea534e   <IP_ADDRESS>   <none>        Ubuntu 20.04.2 LTS   5.4.0-1038-raspi   containerd://1.4.4
masternode   Ready      <none>   2d1h   v1.21.1-3+08fd9d63ea534e   <IP_ADDRESS>   <none>        Ubuntu 20.04.2 LTS   5.4.0-1038-raspi   containerd://1.4.4
laptop       Ready      <none>   24h    v1.21.1-3+ba118484dd39df   <IP_ADDRESS>   <none>        Ubuntu 20.10         5.8.0-59-generic   containerd://1.4.4
bluenode     Ready      <none>   24h    v1.21.1-3+08fd9d63ea534e   <IP_ADDRESS>   <none>        Ubuntu 20.04.2 LTS   5.4.0-1028-raspi   containerd://1.4.4

ubuntu@bluenode:~$ microk8s status
microk8s is running
high-availability: yes
  datastore master nodes: <IP_ADDRESS>:19001 <IP_ADDRESS>:19001 <IP_ADDRESS>:19001
  datastore standby nodes: <IP_ADDRESS>:19001
addons:
  enabled:
    dashboard            # The Kubernetes dashboard
    dns                  # CoreDNS
    ha-cluster           # Configure high availability on the current node
    metallb              # Loadbalancer for your Kubernetes cluster
    metrics-server       # K8s Metrics Server for API access to service metrics
  disabled:
    helm                 # Helm 2 - the package manager for Kubernetes
    helm3                # Helm 3 - Kubernetes package manager
    host-access          # Allow Pods connecting to Host services smoothly
    ingress              # Ingress controller for external access
    linkerd              # Linkerd is a service mesh for Kubernetes and other frameworks
    portainer            # Portainer UI for your Kubernetes cluster
    prometheus           # Prometheus operator for monitoring and logging
    rbac                 # Role-Based Access Control for authorisation
    registry             # Private image registry exposed on localhost:32000
    storage              # Storage class; allocates storage from host directory
    traefik              # traefik Ingress controller for external access

Thank you,
Dan

I did some more testing and narrowed it to the following steps.
Given a cluster with 4 nodes, 3 nodes are master nodes and one is a standby node.
Run microk8s stop on the standby node and on master-voter node. The 2 nodes will appear as NotReady, but the cluster remains in high-availability node. The expected behavior is to turn off high-availability, since only 2 nodes are still working.

@danrg you are right that in the case were we are in a three node cluster and one of the nodes powers off we do not display a warning in the microk8s status. In this configuration (only two nodes running) you are expected to immediately add a third node so dqlite can form a quorum needed in its normal operation.
@MathieuBordere, I understand this is a case where dqlite assumes the powered off node will come back eventually. Is there a way to detect nodes falling behind so we can warn the user in an appropriate way?

@danrg Can you confirm it only happens when you power off both a master node and a standby node?
When there are 3 voters, 2 online voters is sufficient to have majority, but indeed it's not HA because it will break when one of those last 2 servers goes down.
If it also happens when only a master node is offline and the standby node is not promoted, it's probably a bug.
@ktsakalozos There's currently no way that dqlite reports that one of the nodes is down/falling behind. There would have to be some mechanism where the leader node tries to contact all the nodes and reports the last time it saw the nodes online or something similar. This does not necessarily mean those nodes are down, there might be a network issue e.g.
I'm not sure if this should be part of dqlite itself, I can image some monitoring system that detects that the node is down and then tries to remove it from the dqlite cluster (while it still has quorum) and afterwards adds a new healthy node.

@MathieuBordere Indeed, it only happened when powering off both a master and a standby node.


Solution to issue: #7080 Modified load_dataset function, so that it prompts the user to select a dataset when subdatasets or splits (train, test) are available

Feel free to give suggestions please..
This PR is raised because of issue: https://github.com/huggingface/datasets/issues/7080

This PR gives solution to https://github.com/huggingface/datasets/issues/7080

Checking whether the dataset has splits or subdatasets.
Printing the available splits/subdatasets.
Asking the user to choose which one to load.
Loading only the selected dataset based on the user's input.

Key Changes:

Available Splits/Subdatasets: The code checks for available splits/subdatasets using builder_instance.info.splits.keys().
User Prompt: If splits are found, it prints them out and prompts the user to select one.
Loading Based on User Input: The dataset is loaded based on the user's choice.

This way, the dataset loading function will interactively prompt the user to select which subdataset or split they want to load instead of automatically loading all of them.

I think the approach presented in https://github.com/huggingface/datasets/pull/6832 is the one we'll be taking.
Asking user input is not a good idea since load_dataset is used a lot in server that don't have someone in front of them to select a split


[Happy Clock] New App

Just a new happy clock that shows the time, battery, lock state and whether the step goal is reached or not:

And here an example when the battery level is low.

That looks great - thanks!


Fix 1.10 Supervisor deprecation warnings

Fixed all deprecation warnings derived from the usage of :simple_one_for_one strategy

@filipecabaco thanks, this looks great.
Could you add a changelog entry. Does this work as a patch update to the package version

Not quite due to test dependencies. I've tested in 1.6 due to the fact that it's the current Ace minimum elixir requirement and ex_doc and earmark require elixir 1.7.
I tried to push ex_doc version down with no effect 😅so we'll have this warning constantly although it doesn't seem to affect anything.
ex_doc needed elixir 1.7 from 0.18 onward but earmark I wasn't able to find the release where they started requiring it.
How I tested
From the Ace project folder:
docker run -v $(pwd):/ace -e MIX_ENV=test -it elixir:1.6-otp-21-alpine sh
Command:
cd ace && \
mix local.hex --force && \
mix deps.get && \
mix test && \
mix format --check-formatted && \
mix dialyzer --halt-exit-status

Maybe the way to go is actually change the Ace elixir requirement to 1.7 but that would no longer be a patch 😓meaning that Changelog would need a bump in minor.
What's your opinion on this?

We had some problems with dialyzed on earlier Elixir versions, that we
never fixed.
At the time we thought it was too soon to drop older support.
However that was at least a year ago.
I am quite happy to drop versions and make the next breaking release. If we
do that I would suggest make the minimum version 1.9 so it's not too soon
when we next have this discussion.
On Mon, 16 Mar 2020, 11:53 Filipe Cabaço<EMAIL_ADDRESS>wrote:

Not quite due to test dependencies. I've tested in 1.6 due to the fact
that it's the current Ace minimum elixir requirement and ex_doc and
earmark require elixir 1.7.
I tried to push ex_doc version down with no effect 😅so we'll have this
warning constantly although it doesn't seem to affect anything.
ex_doc needed elixir 1.7 from 0.18 onward but earmark I wasn't able to
find the release where they started requiring it.
How I tested From the Ace project folder:
docker run -v $(pwd):/ace -e MIX_ENV=test -it elixir:1.6-otp-21-alpine sh
Command:
cd ace && \
mix local.hex --force && \
mix deps.get && \
mix test && \
mix format --check-formatted && \
mix dialyzer --halt-exit-status
Maybe the way to go is actually change the Ace elixir requirement to 1.7
but that would no longer be a patch 😓meaning that Changelog would need a
bump in minor.
What's your opinion on this?
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/CrowdHailer/Ace/pull/141#issuecomment-599494609, or
unsubscribe
https://github.com/notifications/unsubscribe-auth/ABMXHHUQU26YXWN5QSJJY2LRHYHKVANCNFSM4LLRXX2Q
.

I can tackle that in this PR and as a result push minor to 0.19.0. I'll also take the opportunity to bump up dependency versions with mix deps.update --all.

Great, that should help us close down some of the long standing pull
requests that we have
On Mon, 16 Mar 2020, 12:33 Filipe Cabaço<EMAIL_ADDRESS>wrote:

I can tackle that in this PR and as a result push minor to 0.19.0. I'll
also take the opportunity to bump up dependency versions with mix
deps.update --all.
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/CrowdHailer/Ace/pull/141#issuecomment-599510926, or
unsubscribe
https://github.com/notifications/unsubscribe-auth/ABMXHHSBER5U32P64I3NCJDRHYMAVANCNFSM4LLRXX2Q
.

CI failed in dializer step 😓 but I had the same issue with the other commit on this PR...
I don't have any working theory's on why it could be failing in Travis and not locally (classic "it works on my machine") .
Does anyone have any idea on what it could be so I can try and debug it / fix it?

Is it just me that can't see CI integrating with github?
Have they changed that but I can't see anything on this PR which normally shows the status of tests.
What OTP version are you using we should update that in travis if also update Elixir

Can't see the status either... Here's the config I've updated in the last commit
https://travis-ci.org/github/CrowdHailer/Ace/jobs/663107446/config
language: elixir
elixir:
  - 1.9.4
otp_release:
  - 21.3
env:
  - MIX_ENV=test
before_script:
  - mix local.hex --force && mix local.rebar --force && mix deps.get
script:
  - mix test
  - mix format --check-formatted
  - mix dialyzer --halt-exit-status
cache:
  directories:
    - _build
before_cache:
  # should only keep the dialyzer artifacts
  - mix clean
  - mix deps.clean --all

Needed to add mix local.rebar --force

Ok, after bump there's actually an error on travis
https://travis-ci.org/github/CrowdHailer/Ace/builds/666081967
lib/ace/http2/connection.ex:37:no_return
Function init/1 has no local return.

Which is weird... will try do debug it a bit more

Please why is this not merged?

Issues in CI 😅
Not sure why though...
https://travis-ci.org/github/CrowdHailer/Ace/jobs/669637405

Merged, because all the tests pass.
I would accept a PR for github actions. I seem to have lost track of my access to travis, also if dialyzer is not simple to fix a PR to remove that would be helpful.

@CrowdHailer Do you have an idea of when this minor update will be pushed to Hex? Apologies if I'm missing some context - looked around at the various issues and PRs and can't see any info on that

Looks like there was no reason 0.19 was not pushed to hex. it's in the changelog. I will push it now


Issues with initial installation

Thank you for the theme! I had some issue setting up papermod from the given instructions. These were the three things tripping me up:

Missing taxonomy definition

Error: Failed to serve the site
Error: Page `/Users/oliver/Projects/personal/oschrenk.dev/content/content/posts/papermod-installation.md` has taxonomy `tags` which is not defined in config.toml

This was solved by adding
taxonomies = [
  { name = "tags", feed = true},
]

to the main body of the config

Missing Extra config

Error: Failed to serve the site
Error: Failed to render pager 1
Error: Reason: Failed to render 'section.html' (error happened in 'index.html').
Error: Reason: Variable `config.extra.papermod.language_direction` not found in context while rendering 'section.html'

The installation procedure does mention to copy sample files, which makes the extra config required. But the extra config is missing in the installation procedure.
This was solved by adding the [extra.papermod] section of the sample config to my config.

Section posts/_index.md not found

Error: Failed to serve the site
Error: Failed to render section '/Users/oliver/Projects/personal/oschrenk.dev/content/_index.md'
Error: Reason: Failed to render 'index.html' (error happened in a parent template)
Error: Reason: Function call 'get_section' failed
Error: Reason: Section `posts/_index.md` not found.

This is a misunderstanding between an initial empty setup of zola and the theme.
a) zola init creates an empty content directory already
b) cp -r themes/papermod/content content as outlined in the installation procedure actually actually then copies the content into the existing content, resulting in a directory structure like
content/
  content/
    _index.md
    ...

This was solved via
rm -rf content/content
cp -r themes/papermod/content/* content/

I'm on zola --version: 0.19.1 and it appears that the configuration schema has changed regarding feeds, specifically:
# ...

# When set to "true", a feed is automatically generated.
generate_feeds = false

# The filenames to use for the feeds. Used as the template filenames, too.
# Defaults to ["atom.xml"], which has a built-in template that renders an Atom 1.0 feed.
# There is also a built-in template "rss.xml" that renders an RSS 2.0 feed.
feed_filenames = ["atom.xml"]

# ...

this change causes building the site with PaperMod to break in a variety of places, specifically in the following templates that reference the generate_feed and feed_filename attribute which no longer appears to be valid:

templates/partials/head.html
templates/section.html
templates/tags/single.html

Aside from overriding these templates in my own project, is there a known-workaround for dealing with this issue?
Would you be open to PR's to fix the templates in this repo directly?

Sure thing, please feel free!
I'm unfortunately no longer using zola - but I'll gladly accept PRs so that people who like this theme
can profit from eachothers fixes.
Thanks!

@cydave Why are you no longer using zola and what are you using now?

Error: Failed to serve the site
Error: Failed to render pager 1
Error: Reason: Failed to render 'section.html'
Error: Reason: Variable config.feed_filenames not found in context while rendering 'section.html'
I still encounter this problem when run zola serve


[proposal][JDBC] Split the DataSourceFactory into individual interfaces

Currently DataSourceFactory has four methods:

https://github.com/osgi/osgi/blob/fc60c8dd5eec809c91c054b5c22a79d873e173bc/org.osgi.service.jdbc/src/org/osgi/service/jdbc/DataSourceFactory.java#L235
https://github.com/osgi/osgi/blob/fc60c8dd5eec809c91c054b5c22a79d873e173bc/org.osgi.service.jdbc/src/org/osgi/service/jdbc/DataSourceFactory.java#L249
https://github.com/osgi/osgi/blob/fc60c8dd5eec809c91c054b5c22a79d873e173bc/org.osgi.service.jdbc/src/org/osgi/service/jdbc/DataSourceFactory.java#L261
https://github.com/osgi/osgi/blob/fc60c8dd5eec809c91c054b5c22a79d873e173bc/org.osgi.service.jdbc/src/org/osgi/service/jdbc/DataSourceFactory.java#L273

Each of those methods has the following restriction:

throws SQLException If the ... cannot be  created.

Of course such a case includes, that the one does not creating the ... type at all. To mitigate this there was recently a property added to declare what can be created:
https://github.com/osgi/osgi/blob/fc60c8dd5eec809c91c054b5c22a79d873e173bc/org.osgi.service.jdbc/src/org/osgi/service/jdbc/DataSourceFactory.java#L51
But this still requires effort on the implement side and special consideration on the client side e.g. having lookup/fallback mechanism to decide what feature is supported and even require supporting older implementations by still fallback to the classic approach.
I therefore like to propose (maybe for R9 as this is a major version change) to split up these interfaces having one for each single purpose to support clear implementation and handling:

DataSourceFactory
ConnectionPoolDataSourceFactory
XADataSourceFactory
DriverFactory

it would then be just a matter of implementing each supported interface and register the service under multiple interfaces, or one can even think about extenders that for example provide pooling on top of plain sources, ManagedServiceFactory implementations that support being configured with a set of default properties and son on.
Implications:

Providers possibly need to add additional interfaces and register their service with them, but this seems trivial to archive
Clients possibly need to track more services, actually a client is most of the time only interested in exactly one method, I even would assume that DataSource createDataSource(Properties props) is the one that actually is almost ever used as support for the others is completely irregular across providers, and pooling is most often better handled on the client-layer, for example pax-jdbc offers many pooling implementations and even generic XA support serving better than rely on drivers adding such an implementation.
The JPA Spec might be upgraded, as this mandates usage of DataSource createDataSource(Properties props) this could even be handled in a backward compatible way, as the method will remain the same in v1 + v2
Existing DataSourceFactory must be updated, but one can provide a compatibility layer that collects old DataSourceFactorys and registering a wrapper under the new interfaces using reflection to delegate to the classic implementation using the OSGI_JDBC_CAPABILITY property if available and just delegate if not available. This will allow a smooth transition for any consumer and/or provider.

FYI @stbischof @grgrzybek

Thanks for noticing me @laeubi. I'll be back to reviewing the state of pax projects wrt OSGi CMPN changes after Jan 1st.
Enjoy the holiday season!

I think the proposal here is large enough to require us to use the Contribution Guidelines to have requirements and design discussions. Please follow this process for this proposal. Thanks.

Still an issue.

Still an issue ...


jikkou use config-override with multiple configs failed

Hello everyone,
Follow up issue on
https://github.com/streamthoughts/jikkou/issues/416
https://github.com/streamthoughts/jikkou/issues/454
We are using the jikkou config-override feature that was made by @fhussonnois
It worked when we had only 1 file but when using multiple files with multiple overrides it gives out an error:
Error: JikkouRuntimeException: Multiple config was defined for Kafka Connect cluster 'use-override' through the metadata.annotation 'jikkou.io/config-override'

To Reproduce
just use 2 configs that have config-override to 2 different clusters:
apiVersion: "kafka.jikkou.io/v1beta1"
kind: "KafkaConnector"
metadata:
  name: connect1
  labels:
    kafka.jikkou.io/connect-cluster: "use-override"
  annotations:
    jikkou.io/config-override: |
      {"url": "http://mycluster1:8083"}

and:
apiVersion: "kafka.jikkou.io/v1beta1"
kind: "KafkaConnector"
metadata:
  name: connect2
  labels:
    kafka.jikkou.io/connect-cluster: "use-override"
  annotations:
    jikkou.io/config-override: |
      {"url": "http://mycluster2:8083"}

and then run:
jikkou apply -f <the path to those configs>

Expected behavior
That jikkou won't block 2 config-overrides when running a single jikkou apply command on 2(or more) files.
Jikkou should apply first file, with first config override and then second file with second override.
Runtime environment

Jikkou: running from main as i was asked here: https://github.com/streamthoughts/jikkou/issues/454 (this is after a fix to this feature)

Thanks a lot for your attention 🙏

Hi @arnoldyahad, there is a check that all the configurations supplied through the jikkou.io/config-override annotation are the same for each kafka.jikkou.io/connect-cluster. Here you are using the same identifier use-override for two distinct clusters.
You need define a distinct cluster identifier for each connect-cluster. e.g.,

kafka.jikkou.io/connect-cluster: "mycluster1",
kafka.jikkou.io/connect-cluster: "mycluster2"

thanks a lot for the quick response!
I tested and using different identifier works for multiple config files 🙏


library App

Related Issue
Closes: #280
Describe the changes you've made
Edited libraryApp project .
Describe if there is any unusual behaviour of your code(Write NA if there isn't)
NA
Checklist:

[x] My code follows the style guidelines of this project.
[x] I have performed a self-review of my own code.
[x] I have commented my code, particularly in hard-to-understand areas.
[x] I have made corresponding changes to the documentation.
[x] New and existing unit tests pass locally with my changes.

Screenshots

@991rajat I have edited the libraryApp files and replaced with my code as instructed. Please look into this PR.

Congratulations on merging of first PR. :tada:
Thanks for this awesome contribution. :star_struck:
Keep Contributing.


Contribution Proposal: SASL_PLAINTEXT GSSAPI Authentication Support

Hi KafkaJS team,
First of all, thank you for maintaining KafkaJS. It has been an essential part of our projects, and I appreciate all the effort that goes into it.
I’ve recently developed support for SASL_PLAINTEXT GSSAPI authentication in KafkaJS, a feature the library currently does not support out of the box and need the use of a Custom AuthProvider and strong knowledge of the GSSAPI protocol. I’m aware that in the past, there has been some reluctance around adding GSSAPI due to the dependency on the native Kerberos library (krb5). However, I believe I’ve found a way to make this integration smoother and more flexible for users.
Proposal
Implementation: I've added the necessary logic for SASL_PLAINTEXT GSSAPI authentication.
Optional Dependency: To address concerns about the need for native Kerberos libraries, I can make the kerberos package an optional peer dependency. This way, users who need GSSAPI support can choose to install kerberos, while others won't be affected.
Benefits
Flexibility: By making Kerberos an optional dependency, the library remains lightweight for those who don’t need GSSAPI.
Expanded Use Case: This feature will enable KafkaJS to be used in environments where SASL_PLAINTEXT with GSSAPI is required, increasing the library's usability in enterprise settings.
Next Steps
I'd love to contribute this feature to KafkaJS. Please let me know if you're open to this addition, and if so, I can create a pull request for you to review.
Looking forward to your feedback and thoughts on how we can move forward with this.
Thanks for considering this contribution!

Hey Team,
Just bumping up the contribution proposal...

same here


How to get the bash from the PHP (aka the opposite)?

// it would be nice if something like this existed:
$bash_command = curl_get_bash_equivalent($curl);
// 'curl -X POST "http://..."'

curl_close($curl);

An interesting idea, if anyone else +1s this I'll look into it.

👍

In theory this could be done via a good AST as the base, ex. https://github.com/nikic/php-ast . If you make certain assumptions (code in the top level scope, don't resolve variables), then you can get the function names and parameters.
Here's a POC:
https://github.com/elijah-z142/curl-php-parser/blob/master/README.md
-elijah
Runtime Converter (Online PHP to Java Converter)

An interesting idea, if anyone else +1s this I'll look into it.

just released a library exactly for that https://github.com/biganfa/php2curl
converts PHP request to command line cURL

Looks like the above library solves this issue, closing


Unable to manually merge code snippets

Does this issue occur when all extensions are disabled?: Yes

VS Code Version: 1.68-insider
OS Version: Windows 11

Steps to Reproduce:

Have some conflicts in code snippets (i.e. settings sync turned off locally and code snippets modified, then select to merge manually when reenabling settings sync)
:bug: clicking Accept Remote or Accept Local does nothing

I then canceled the manual merge, retried the 'Turn on settings sync' flow, and selected to merge (not merge manually). Settings sync said I had a conflict in the settings.json file (which I already resolved conflicts in), and did not flag conflicts in code snippets. I'd expected settings sync to complain about conflicts in the code snippets file instead.

This seems to be fixed now


TOTP Registration backend

Handle the backend requests when registering the TOTP method.
ACs

TOTP secret can be generated
Codes can be validated
No QR generation logic in the backend- we'll leave this to the front end
Refactor existing logic to be compatible with new MFA module

Notes

The following library has been previously recommended https://github.com/Spomky-Labs/otphp

Pull requests

[ ] https://github.com/silverstripe/silverstripe-mfa/pull/74
[ ] https://github.com/creative-commoners/silverstripe-webauthn/pull/2
[ ] https://github.com/silverstripe/silverstripe-totp-authenticator/pull/4

PRs posted to the description.
The MFA module has now got strong PHP 7 types and a 7.1 minimum, and contains an encryption adapter which defaults to using https://github.com/defuse/php-encryption.
The TOTP and WebAuthn modules have been updated to match this, and TOTP now uses https://github.com/Spomky-Labs/otphp to provide a provisioning URI for the QR code to the frontend, validate the user inputted TOTP code after having scanned it (via a React library to render the QR code), ask MFA to encrypt the secret and store it against the new registered method in the DB. TOTP also will register itself as unavailable as a registration method if you haven't defined the SS_MFA_SECRET_KEY environment variable in your project yet.
WebAuthn has been updated to register itself as an unavailable registration method when you aren't running HTTPS (it doesn't work without HTTPS anyway at the browser level).


Possible to remove Tensorflow  dependency?

Thank you for your amazing code! It's been extremely helpful for some dissertation projects.
I've recommended your codebase to quite a few academic/industry researchers. Their biggest adoption hurdle seems to be getting PyTorch & Tensorflow to play nicely together with CUDA.
Do you think it's possible to remove the Tensorflow dependency altogether? (i.e. a pure-Pytorch approach?) Or do you recommend against re-implementing fused_bias_act / upfirdn2d in Pytorch?
Please let me know what you think - thanks!

Currently this implementation does not depend on tensorflow except for converting checkpoints from tensorflow. Do you mean CUDA custom kernels (fused_bias_act & upfirdn2d)? It is not depend on tensorflow, but yes, it seems like that this causes many problems.
Actually this repository contains pytorch native implementations for upfirdn2d (https://github.com/rosinality/stylegan2-pytorch/blob/master/op/upfirdn2d.py#L152), and implementing fused_bias_act in pytorch will be easy. But it will cause quite large slowdowns during training (almost 2x).

Sorry for the Tensorflow mixup, looks like the CUDA kernels are the main issue.
I didn't realize how much the fused operations reduce runtime. But in the short-term, we can try using your native upfirdn2d code and replace fused_bias_act.
Thanks for responding so quickly.


Replace the AnnotationStorage.lastModified-getter with a proper hash-method

The current lastModified-getter, which only contains a time-stamp, is a fairly crude way of detecting if the stored data has actually been changed. In particular, when the getRawValue-method is used, the lastModified-getter doesn't cope with data being modified from the "outside".
To fix these issues[1], and to prevent any future bugs in this code, this patch introduces a new AnnotationStorage.hash-getter which computes a hash of the currently stored data. To simplify things this re-uses the existing MurmurHash3_64-implementation, which required moving that file into the src/shared/-folder, since its performance should be good enough here.

[1] Given how the AnnotationStorage.lastModified-getter was used, this would have been limited to printing of forms.

/botio-windows browsertest

Looks good; thanks!


[PHP] 0.10.8 refactor, variable heightlights and code intelligence

Variables are not hightlighted(dark theme) and code intelligence is not triggered for local variable, they were fine in 0.10.6
Variable refactor is broken, it now affects variable with same starting string. It was fine in 0.10.6

Variable selection still includes the trailing "-", as I recall there's a fix for that.

I am working on Win7 x64.

Was just about to post the same thing for php variable highlighting on Dark (Visual Studio) theme. It worked with the previous version.

(1.) By design, the Dark (Visual Studio) theme only has a very few colors. I fixed that and had to remove the color for variable. If you like the color, use the new Dark+ default theme.
Code assist seems to work from me. I used this example
<?php

public function demo{
    $variable1 = 9;
    $variableB->C = 9;
    assert($variable11);
}
>

(2.) You are right, I have to investigate
(3.) This got fixed for February

I think (2) happens on javascript as well (so it might be for all languages)

Is it also possible that we keep variable refactor within the function scope instead of the whole file?

@bingzheyuan You are asking for deeper PHP support with real language understanding. It's not something we, the core VS Code team, will be able to provide. We lack deeper PHP knowledge and the resources. We are actually hoping someone from the community would be interested of implementing a more sophisticated PHP extension.

yall need to assign a new guy to this. aeschli is fighting for some reason. closed another report I opened claiming its not true even when I had before and after screenshots.

the screenshots from the closed thread.
before:

after:

i have a few machines i keep refusing to update now because the Dark Not Plus changed >_>
when it comes to visual assets like themes, you shouldn't just change them ever. you should only ever add new ones or fix bugs. not remove features.

@bobmajdakjr Bod, did you try switching to the Dark+ theme? It's FIle > Preferences > Color Theme.

yes dark+ works as intended. what i'm qqing about is having broke dark not plus instead of just adding dark+ and leaving the previous alone.

https://code.visualstudio.com/Updates#_editor tries to explain the motivation behind the changes. Sorry for back and forth in the recent months, but we hope we now have a solution for both classic VS users as well as users that the classic VS theme is too limited. And there's always lots of other themes to pick from.

Tested again on version 0.10.10, code intelligence is still not triggered for local variables.

I looked at (2)
For PHP we offer only 'Change All Occurrences' which looks at the current selection and finds occurrences based on the current settings of the 'Find' widget. It's basically find/replace, without the find widget.
If you want to replace only full words, then you have to open the find widget and check the 'whole words' settings. That setting is persistent and then also 'Change All Occurrences' with follow this setting. There's also a keybinding shortcut (Alt+w) to toggle that while word settings without the need to open the find widget
Some other languages have a real 'rename symbol' support. We don't have that for PHP.
I'm closing this issue: (1) is expected, it has to do with the design of our themes: Use the Dark plus themes if you like variable highlighting
(3) got fixed a while ago.

@aeschli how about the code intelligence problem in the last reply? It was fine in v0.10.6 and get lost since v0.10.8.

@bingzheyuan You need to adjust this little setting to make it work again: https://github.com/Microsoft/vscode/issues/4355#issuecomment-197921835

The variables intellisense issue is #3815. It will be fixed in the March release.

@Morgy93 That wasn't my question but your comment is very helpful as well, thanks.
@aeschli OK, then no more problem about this issue now, thanks for the great work.


Added support to resize remote image: #16

A path is 'remote' if net.url.Parse(path).Scheme is not empty.
TwoTier.RemoteLocalPath convert URL to local path which is then use for storage,cache and thumbnails.
Since I'm far from an expert level in golang, I'm not sure this is the right way to handle this part.
Please note this a work in progress since I think that security is not handled with this patch.

I'm working on a rewrite of the caches and won't be available until I finish.

No problem, I really understand since I'm also quite busy with work on my side.


Remove 'sdk' repo exclusion in non-source build scenario

Fixed via https://github.com/dotnet/installer/commit/a4860bb6bfe918f278ef1bb6f7409099e81a1c0f


How can i run samples in tests;

I changed the project, but i can not open the project, eg hello
can not import E:\build\Microsoft.netcore.native.targets

The tests need to be built and run using runtest script. They cannot be run directly from Visual Studio. The tests use old version of the build system that is not compatible with Visual Studio. We would like to switch the test over to the new build system in future to fix this.
If you need to debug and run the test in VS, it is best to extract the tests into regular project.

Thanks for the answer.


feat: Add support for setting http_keep_alive_timeout_sec

Purpose
Add support to configure the http_keep_alive_timeout_sec value when using an EXTERNAL_MANAGED Load Balancing Scheme.

@jimdaga thx for the PR. Lint tests are failing. can u plz follow this doc and fix the issue.

Hi @imrannayer I have corrected the lint error. Please let me know if you have any other feedback, thank you!

/gcbrun


Customer Segmentation ML Model

Title and Issue number

Customer Segmentation ML Model(K Means Clustering and Hierachical Clustering )
Close #4246

Checklist:

[x] I have mentioned the issue number in my Pull Request.
[x] I have commented my code, particularly in hard-to-understand areas
[x] I have created a helpful and easy to understand README.md

@MohitGupta121