[Feature Request] add quotes around strings when saving an array to a file

Godot version:
3.1
OS/device including version:
OS: Manjaro 18.0.4 Illyria
Kernel: x86_64 Linux 4.20.17-1-MANJARO
DE: KDE 5.56.0 / Plasma 5.15.3
if i have
[[22, "2019-04-08 17:16:26"], [7, "2019-04-08 17:16:16"], [4, "2019-04-08 17:16:19"], [4, "2019-04-08 17:16:30"], [0, 0], [0, 0], [0, 0], [0, 0], [0, 0], [0, 0]]
in a file, and i read the file to an array
JSON.parse(file.get_as_text()).result on parse_json(file.get_as_text())
it returns
[[22, 2019-04-08 17:16:26], [7, 2019-04-08 17:16:16], [4, 2019-04-08 17:16:19], [4, 2019-04-08 17:16:30], [0, 0], [0, 0], [0, 0], [0, 0], [0, 0], [0, 0]],
which is all fine and good, but once i save it back to a file, it saves without the quotes, so when i try to read the data again it'll return Null cuz theres no quotes around the dates. i made a workaround for my specific case, but there should be some sort of flag to arrays to print it with quotes around strings. maybe something like array.print_with_quotes() or just array.str() cuz str(array) prints without quotes

Use var2str and str2var for serialization.


Fix: debounce fetch apps

closes #999.

Travis automatic deployment:
https://pr1021--safereact.review.gnosisdev.com/app

@nicosampler what's up with this ticket?

@nicosampler are you going to finish this or somebody needs to take this?

I've been working on it, and I got stuck working with the debounce function, for some reason (that could not discover yet), the function is being re-created due to a re-render all the time and that force the requests to be triggered all the time.
Feel free to take a look, I'm working with TXs now.

I got stuck working with the debounce function, for some reason

In that case you should ask for help, we can't help if we don't know you need it

I did, worked on it with Fernando, then I had to move to another ticket.

I did, worked on it with Fernando, then I had to move to another ticket.

Working silently with someone on a fix != sharing a problem with a team so anyone can take a look at it

Travis automatic deployment:
https://pr1021--safereact.review.gnosisdev.com/app

Travis automatic deployment:
https://pr1021--safereact.review.gnosisdev.com/app

Debounce is working, set to 500ms
Prevents calling the endpoint if it happens to be an invalid URL
URLs data discovery is memorized (so once a manifest.json is requested, it won't be requested again in the same session)
I added a dependency that is quite small, but I'm not sure if it's a good idea to let it or reimplement it in-house (use-lodash-debouce)

Travis automatic deployment:
https://pr1021--safereact.review.gnosisdev.com/app

@Agupane im working on safe apps refactor so it's fine for now, I will type it

Travis automatic deployment:
https://pr1021--safereact.review.gnosisdev.com/app

Travis automatic deployment:
https://pr1021--safereact.review.gnosisdev.com/app

I still get a chunk of error by writing an ULR. Is not as aggressive like it is in prod where there like 5 error per character you type, but there they are. I don't know how much we can avoid it, so this is just how I see it in this PR right now

I've tried to type this URL https://ipfs.io/ipfs/QmTgnb1J9FDR9gimptzvaEiNa25s92iQy37GyqYfwZw8Aj/

I still get a chunk of error by writing an ULR. Is not as aggressive like it is in prod where there like 5 error per character you type, but there they are. I don't know how much we can avoid it, so this is just how I see it in this PR right now
I've tried to type this URL ipfs.io/ipfs/QmTgnb1J9FDR9gimptzvaEiNa25s92iQy37GyqYfwZw8Aj

Well, we can prevent logging the errors. But sometimes they're useful.
The thing with the number of errors has to do with how fast you type if you take more than 500ms between keystrokes, then you'll have an error per char.
Said so, we can increase the 500ms delay, or set it as an ENV var so it's easier to tweak it when needed? Not sure. @mikheevm, @nicosampler

It's totally fine log these errors, a partial URL is not a valid safeApp. Regarding the 500ms, I think it's the standard.

Yeah I agree that logging these errors is perfectly fine.

Travis automatic deployment:
https://pr1021--safereact.review.gnosisdev.com/app

Travis automatic deployment:
https://pr1021--safereact.review.gnosisdev.com/app

Gotcha. Then It's fine for me

Travis automatic deployment:
https://pr1021--safereact.review.gnosisdev.com/app

Travis automatic deployment:
https://pr1021--safereact.review.gnosisdev.com/app


Simplify calculation of transfer fee

This is a simplification to the way we handle the transfer fee: it eliminates a couple of function calls, and avoids subtracting an amount only to then readd it and expecting to get back the original minuend.
We may want to just reject this, pending Scott D's refactor - I leave that up to you.
Reviews: @JoelKatz, @seelabs

Current coverage is 62.30%

Merging #1533 into develop will increase coverage by +0.01% as of db2ffad

@@            develop   #1533   diff @@
=======================================
  Files           892     892
  Stmts         63175   63164    -11
  Branches          0       0
  Methods           0       0
=======================================
- Hit           39358   39357     -1
  Partial           0       0
+ Missed        23817   23807    -10

Review entire Coverage Diff as of db2ffad

Powered by Codecov. Updated on successful CI builds.

@nbougalis Apart from simplifying the code, what you've done in this PR is replace the calculation: amt + (transferRate*amt - amt) with transferRateamt. One way these two calculations will differ is when mantissas of transferRateamtandamt` differ by ten or less. In that case, the old calculation will charge a fee of zero, and the new calculation will charge a small fee.
This difference could cause some transactions to now fail that would have succeeded with the old calculation.
My thoughts: Your PR improves the code, and improves the accuracy of the fee calculation. But it may also introduces a change to what transactions will succeed (though that may be just a theoretical concern). I'm very close to a PR for the new payment code. With that so close I don't think we should make this change. What do you think?

@seelabs: yep, I figured this could trigger miniscule differences which is why I tagged you, although I haven't seen one in over 40 hours of runtime.
The new payment code is obviously going to clean this and more up, and if you and David want to drop this PR in favor of the new code, I'm fine with that.

I like the simplification, but we can also hold off. I'm fine either way.
:+1:

I incorporated these changes into the main flow PR, so I'm closing this one.


No "Attention Required" message on the "Project overview" form when submitting a new project without project overview data [6]

Describe the Bug:
When creating a new project, and adding any data except for "Project Overview" (including no data at all),
and then submitting the project, the user faces a non-descriptive error message instead of being directed to the "Project Overview" form with the "Attention required" status
Probability (how likely the bug is to happen, scored from 1-5): 2-3
Effect (how bad the bug is when it does happen, scored from 1-5): 3
Poor feedback and no indication on how to fix the error. Potentially quite a bit of work lost if the user doesn't figure out what is wrong
Steps to reproduce the behaviour:

Login
Create a new project
Go directly to the "review and submit" page (or add any milestones, etc. just no project overview data)
Hit 'Submit'

Issues:

The user is the presented with a cryptic "an error occurred" message instead of being redirected to the Overview form
The Submit button is active ( @nanyangpro @suhafa I think it should be inactive in this case)

Screenshots:

Looks good. Attention Required appears and the submit button is disabled when the overview is incomplete.


Different hash mechanism for ref type

🚀 The feature, motivation and pitch
Right now, with the following configuration, if you update the VERSION of input_data, the json_process step still only check the ref class type and caches the result of the previous VERSION. So if you want the pipeline to run correctly, you need to update the VERSION of all later steps, which is not ideal.
{
step : {
        input_data: {
            type: "input_data",
            input_dir: "input_folder"
        },
        json_process: {
            type: "json_process",
            dataset_dict: {
                type: "ref",
                ref: "input_data",
            },
        },
}

Alternatives
For ref type parameters, the caching module should also hash the VERSION + class name so that it can be rerun if necessary.
Additional context
No response

Seems like the version also got hashed. Not sure why the pipeline found the cache in my first run


Missing setter method for property allowedMethods in AbstractConfiguration

...that is all: the function setAllowedMethods() is missing in AbstractConfiguration.

In here, it's done in https://github.com/mezzio/mezzio-cors/blob/37d8146281391eb6fc08d381f3e1e79b15328956/src/Configuration/RouteConfiguration.php#L77-L85
Id' say that AbstractConfiguration should probably be dropped, and only the interface should survive :thinking:

ah, ok.
Because class ProjectConfiguration extends AbstractConfiguration mezzio-cors can not work with project config.

I have write my own ProjectConfiguration extends AbstractConfiguration with ProjectConfigurationFactory, put it in my ConfigProvider and it works :)
<?php

declare(strict_types=1);

namespace App\Configuration;

use Mezzio\Cors\Configuration\ConfigurationInterface;
use Mezzio\Cors\Configuration\Exception\InvalidConfigurationException;
use Mezzio\Cors\Exception\BadMethodCallException;
use Webmozart\Assert\Assert;

use function array_unique;
use function array_values;
use function call_user_func;
use function in_array;
use function is_callable;
use function lcfirst;
use function sprintf;
use function str_replace;
use function ucfirst;
use function ucwords;

abstract class AbstractConfiguration implements ConfigurationInterface
{
    /**
     * @psalm-var list<string>
     */
    protected $allowedOrigins = [];

    /**
     * @psalm-var list<string>
     */
    protected $allowedMethods = [];

    /**
     * @psalm-var list<string>
     */
    protected $allowedHeaders = [];

    /** @var string */
    protected $allowedMaxAge = ConfigurationInterface::PREFLIGHT_CACHE_DISABLED;

    /** @var bool */
    protected $credentialsAllowed = false;

    /**
     * @psalm-var list<string>
     */
    protected $exposedHeaders = [];

    /**
     * @psalm-param array<string,mixed> $parameters
     */
    public function __construct(array $parameters)
    {
        try {
            $this->exchangeArray($parameters);
        } catch (BadMethodCallException $exception) {
            throw InvalidConfigurationException::create($exception->getMessage());
        }
    }

    /**
     * @param array<string,mixed> $data
     */
    public function exchangeArray(array $data): self
    {
        $instance = clone $this;

        /** @psalm-suppress MixedAssignment */
        foreach ($data as $property => $value) {
            $property = lcfirst(str_replace('_', '', ucwords($property, '_')));
            $setter   = sprintf('set%s', ucfirst($property));
            $callable = [$this, $setter];
            if (! is_callable($callable)) {
                throw BadMethodCallException::fromMissingSetterMethod($property, $setter);
            }

            call_user_func($callable, $value);
        }

        return $instance;
    }

    /**
     * @psalm-param list<string> $origins
     */
    public function setAllowedOrigins(array $origins): void
    {
        Assert::allString($origins);

        $origins = array_values(array_unique($origins));

        if (in_array(ConfigurationInterface::ANY_ORIGIN, $origins, true)) {
            $origins = [ConfigurationInterface::ANY_ORIGIN];
        }

        $this->allowedOrigins = $origins;
    }

    public function allowedOrigins(): array
    {
        return $this->allowedOrigins;
    }

    public function setAllowedMethods(array $methods): void
    {
        Assert::allString($methods);
        $methods = array_values(array_unique($methods));
        $this->allowedMethods = $methods;
    }

    public function allowedMethods(): array
    {
        return $this->allowedMethods;
    }

    /**
     * @psalm-param list<string> $headers
     */
    public function setAllowedHeaders(array $headers): void
    {
        Assert::allString($headers);
        $this->allowedHeaders = array_values(array_unique($headers));
    }

    public function allowedHeaders(): array
    {
        return $this->allowedHeaders;
    }

    public function setAllowedMaxAge(string $age): void
    {
        if ($age) {
            Assert::numeric($age);
        }

        $this->allowedMaxAge = $age;
    }

    public function allowedMaxAge(): string
    {
        return $this->allowedMaxAge;
    }

    /**
     * @psalm-param list<string> $headers
     */
    public function setExposedHeaders(array $headers): void
    {
        Assert::allString($headers);
        $this->exposedHeaders = array_values(array_unique($headers));
    }

    public function exposedHeaders(): array
    {
        return $this->exposedHeaders;
    }

    public function credentialsAllowed(): bool
    {
        return $this->credentialsAllowed;
    }

    public function setCredentialsAllowed(bool $credentialsAllowed): void
    {
        $this->credentialsAllowed = $credentialsAllowed;
    }

    public function allowedCredentials(): bool
    {
        return $this->credentialsAllowed;
    }

    public function setAllowedCredentials(bool $credentialsAllowed): void
    {
        $this->credentialsAllowed = $credentialsAllowed;
    }
}

There is no reason to have methods configured on project level.
The project configuration detects automatically which request methods are supported by the requested endpoint.
If you want to have request method specific configurations, you have to configure it per-route and that is why it is not registered to the project configuration.
Could you probably explain the use-case why you need this setting on the project level?

I want to allow the same methods in many requests. For this I need the ProjectConfiguration. In the other requests, the RouteConfiguration overwrites the ProjectConfiguration.

@bitkorn

I want to allow the same methods in many requests.

And these are already defined in your routing configuration and mezzio-cors will check your routes:

It uses the mezzio-router to match the incoming URI. It starts with the HTTP request method which is provided by the Request via the Access-Control-Request-Method header and checks all request methods until it matches a route. If that route states to be explicit, the response is created immediately.
If the route is not explicit, all request methods are checked to provide a list of possible request methods to the client.

https://docs.mezzio.dev/mezzio-cors/v1/intro/#features
Or did I miss something?

I define the routes in the module's ConfigProvider as an Array.
The client threw "Missing Allowed Method". That's why I wanted a ProjectConfiguration with "allowed_methods". But, now I can't recreate the behavior of the client.

by default, the cors module allows any request method by default (by any I mean any which is allowed by the route configuration, i.e. via allowed_methods within routes).
If you do not limit the request method by the route configuration, no changes needed as the cors module automatically reads allowed_methods from your route.
Configuring methods on a project level makes no sense at all since some endpoints are usually POST and some are GET and others are DELETE or maybe PATCH/PUT. But thats not the rule for all endpoints and thus I've never added this functionality to the project config on purpose.
Maybe you experienced a bug which was fixed in v1.0.2 but since this issue is just 2 days old and v1.0.2 was released back in 2020, I don't think thats the case.
However, I'd love to see the configuration to understand what you try to achieve. IMHO, its not necessary to configure project wide allowed_methods.


Can not find

I downloaded this using the plugin manager but it does not show up in my plugins.  Any ideas?  I'm on a W10 system.

i cannot replicate this problem. Does the search function work for eq3?

I just installed everything on anther computer and it's all working.  Thanks for looking into it
Shof B
My Web Site
http://www.l-and-l.nethttp://www.l-and-l.net/
Check out my Soundcloud stream @
https://soundcloud.com/shofb
And my YouTube MyKits demos @
http://www.youtube.com/channel/UCjKNiE1s2YlJYPsAKbe8vhg

From: Daniel Huber<EMAIL_ADDRESS>Sent: Tuesday, June 19, 2018 9:12 PM
To: dhuber81/huaba
Cc: ShofB; Author
Subject: Re: [dhuber81/huaba] Can not find (#1)
i cannot replicate this problem. Does the search function work for eq3?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHubhttps://github.com/dhuber81/huaba/issues/1#issuecomment-398547640, or mute the threadhttps://github.com/notifications/unsubscribe-auth/AD4wDCxbB5QL-hra97Vbm9h8ZvNTz-nmks5t-Wk6gaJpZM4UqcQh.


FIX ERROR : [webpack-cli] Failed to load ' webpack.config.js' config  AND add DOCKER build

Hi @luongchung!
Although adding docker is cool, as you modified something like colors, images, etc in this PR, I can't merge it.

Sorry !!! I was added unnecessary parts to the merge request.
Waiting for update merge request


RapidJson causes C5054 on MSVC

Hello,
The embedded version of RapidJson causes C5054 warnings on MSVC with C++20. They have fixed it on their side using static casts. Is it possible to update the library in Cereal?
Thanks
Dimitris

Workaround (surround any include giving you the problem):
#ifdef _WIN32
#pragma warning(push)
#pragma warning(disable: 5054) // Include\cereal\external\rapidjson\document.h does '|' with two different enum types
#endif
#include <cereal/archives/json.hpp>
#ifdef _WIN32
#pragma warning(pop)
#endif


RawGit is shutting down. Please revoke any url points to it.

bash <(curl -sLo- https://raw.githubusercontent.com/szero/volascripts.sh/master/install.sh)

Is work fine. I have to replace all string on install.sh, from https://rawgit.com/ to https://raw.githubusercontent.com/, thought.
Got better solutions?

Rename it to somewhat like this  https://github.com/szero/volascripts.sh/raw/master/install.sh would works.


Moving IOCUtil from kie-wb-common to uberfire

@paulovmr it might make sense to move this to Errai. Wdyt @mbarkley ? This could be similar to the instance provider but instead of injecting Instance we'd inject something like a ContextualInstance ....

@mbarkley nice, like the idea. the newInstance vs getInstance issue definitely points to a bug in the workbench. We'd have to go through the linked PR and make sure there's no application scoped bean involved and if there is we'd have to change it to dependent scope when applying the fix.

Linked PR: https://github.com/droolsjbpm/kie-wb-common/pull/386

Hi @csadilek @mbarkley , I agree, it makes more sense moving this to Errai.
@csadilek Wdyt about us closing this PRs and opening a new ticket on JIRA to take care of this?

@paulovmr sounds good, unless this refactoring was needed for something right away, we can of course merge this first. If not, let's put this into Errai.

@csadilek No, it's not needed right now, we can wait for this to be put into Errai. Do you mind creating the ticket? I think you could add more details since you are more familiar with Errai's particularties. :)

@paulovmr ok @mbarkley created a jira: https://issues.jboss.org/browse/ERRAI-961


404 error on datagrid stop other references

Hi, I'm using the version 1.2.0 and now we have a problem:
<List title="List of Invoices" {...props} filters={<InvoiceFilter />}>
    <Datagrid>
      <TextField label="InvoiceId" source="InvoiceId" />
      <DateField source="DateInvoce" label="Date Invoice" />
      <TextField label="Payer Email" source="PayerEmail" />
      <TextField label="Total" source="Total" />
      <ReferenceField
        label="User"
        source="IdUser"
        reference="users"
        linkType="show"
      >
        <TextField source="UserName" />
      </ReferenceField>
      <ShowButton label="View Invoice" />
    </Datagrid>
  </List>;

If I don't have a record in my database with this IdUser, or my REST API return a 404 in the reference field, the ReferenceField stop looking for the others IdUser referenced.
Any ideas? Thanks.

Hi! Can I help with this issue? Thanks ;)

Is it a regression dating from 1.2? If yes, it can be caused either by #647 or #596.

Exactly, in the last version we don't have this problem... thanks

Just to make sure I understand:

The datagrid displays references up to a certain line, and then, once it hits the line where IdUser is null, it stops looking for the reference on the following lines?
Do you see an error message in the console?
Which rest client are you using?
Which is the last version where it used to work?

Hi @fzaninotto here you have my responses:

Exactly.
crudResponse.js:145 Not Found
jsonServerRestClient
I'm not totally sure... but I think that in 1.0.0 all works fine.

Thank you so much!

I have test to add alloEmpty too, but it not works.

Hi, any news about this issue? Thanks

Can't reproduce on 1.3.4 anymore. Feel free to reopen if needed


Pluggable listener pre-connection filters

Envoy currently supports SO_ORIGINAL_DST and proxy protocol version 1 for supplying connection metadata (original connection destination, and source in case of proxy protocol). If both are configured, it is somewhat unclear what should be done, even though current implementation will search for alternative listener based on the SO_ORIGINAL_DST, but then use remote and destination information from proxy protocol when creating the connection.
It would be nice to make the listener optional functionality like these pluggable, allowing a listener to be configured with an explicitly specified set of "pre-connection filters" that process the incoming connection before a Connection object is created. This would also allow plugging in new connection metadata providers without adding new hard-wired options into the Listener implementation. Each "pre-connection" filter should have their own json configuration so that the main Listener configuration would not need to be extended for new kinds of metadata providers.
Further integrating SSL/TLS termination into this new plugin framework could allow SSL/TLS metadata to be provided from proxy protocol version 2 TLVs for Envoy logging and access control purposes.
This is not a "feature request" as such but intended to find out if any thoughts on this front are out there.

This seems reasonable to me. We now have a fairly generic extension registration system that can be used to build this. If you feel like working on this it would be good to do a bit longer form design in terms of what the config would look like (also needs v2 analog in proto) and the extension interfaces.
cc @htuch @dnoe

It might make sense to try and intercept the v2 LDS API with this, see https://github.com/lyft/envoy-api/blob/master/api/lds.proto. We already have an explicit notion of metadata in the Listener and FilterChain messages that can be used to provide opaque data for stats/logging or other filters, essentially what we're adding here is a way to provide additional sources of the metadata, beyond explicit statement in the config protos (or JSON).
We could also potentially do something similar to what we did with EDS and LB, add a notion of metadata match to FilterChainMatch if it's useful.

On Jul 18, 2017, at 8:05 AM, Matt Klein<EMAIL_ADDRESS>wrote:
This seems reasonable to me. We now have a fairly generic extension registration system that can be used to build this. If you feel like working on this it would be good to do a bit longer form design in terms of what the config would look like (also needs v2 analog in proto) and the extension interfaces.

Cool! I have plans of adding additional metadata sources, so working on this makes perfect sense. I’m new enough to hot have noticed Envoy API v2 work or plans before, is there something on the approach, goals, timeline, etc. on v2?
Jarno

On Jul 18, 2017, at 8:08 AM, htuch<EMAIL_ADDRESS>wrote:
It might make sense to try and intercept the v2 LDS API with this, see https://github.com/lyft/envoy-api/blob/master/api/lds.proto https://github.com/lyft/envoy-api/blob/master/api/lds.proto. We already have an explicit notion of metadata in the Listener and FilterChain messages that can be used to provide opaque data for stats/logging or other filters, essentially what we're adding here is a way to provide additional sources of the metadata, beyond explicit statement in the config protos (or JSON).
We could also potentially do something similar to what we did with EDS and LB, add a notion of metadata match to FilterChainMatch if it's useful.

Is this also v2, or is there any of this in the current Envoy?
Jarno

@jrajahalme please take a look through https://github.com/lyft/envoy-api

Yeah, as Matt points out, the repo has all the approach/goals stuff. In terms of timeline, we're working on locking down the API and implementing the subset of it that matches v1 right now. I'm hoping we'll have the v1 subset of v2 implemented within roughly a month.
After that, we need to plumb in all the additional v2 features that weren't in v1. I've started to track these at https://github.com/lyft/envoy/issues?q=is%3Aopen+is%3Aissue+label%3A"v2+API", but there's a bunch missing there, I'll be adding them as time allows in the next week or two.

@jrajahalme Are you still after something like this post #1246? If so, are you interested in working on this?

Yes,
I’ll prototype something locally first. Could you give me a pointer to the plugin registration mechanism mentioned in this thread before?
Jarno

On Aug 10, 2017, at 2:20 AM, htuch<EMAIL_ADDRESS>wrote:
@jrajahalme https://github.com/jrajahalme Are you still after something like this post #1246 https://github.com/lyft/envoy/pull/1246? If so, are you interested in working on this?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub https://github.com/lyft/envoy/issues/1276#issuecomment-321498716, or mute the thread https://github.com/notifications/unsubscribe-auth/AGN128Djvx4etrgPG4vVsNPO-EgQkE8qks5sWstxgaJpZM4ObFmx.

@jrajahalme Great! See https://github.com/lyft/envoy/blob/master/include/envoy/registry/registry.h for the factory registration bit.


Fix: Allow ConfigClusterLocator to load cluster specific customResources

Hey, I just made a Pull Request!
Resolves #17224
Also reworking KubernetesFanOutHandler unit tests to make use of jest helpers to improve readability.
:heavy_check_mark: Checklist

[x] A changeset describing the change and affected packages. (more info)
[ ] Added or updated documentation
[x] Tests for new functionality and regression tests for bug fixes
[ ] Screenshots attached (for UI changes)
[x] All your commits have a Signed-off-by line in the message. (more info)

@backstage/kubernetes-maintainers leaving this one in your capable hands :hands:


Add dependency injection and reduce properties of the request context

@nrempel I've tested everything I could except issuing credentials.

@nrempel Added one fix after going through the alice-faber demo.


[bug] WindowBuilder.icon is not working

Describe the bug
let icon = Icon::File(PathBuf::from(iconPath));

let app_window = WindowBuilder::new(
    &_app,
    &appid,
    WindowUrl::External(entry.parse::<Url>().unwrap()),
)
    .title(title)
    .icon(icon).unwrap()
    .disable_file_drop_handler()
    .build().unwrap();

no any errors or panics, just doesn't work

test icon here

Reproduction
No response
Expected behavior
No response
Platform and versions
Environment
› OS: Windows 10.0.19044 X64
› Webview2: 106.0.1370.52
› MSVC:
- Visual Studio Community 2019
- Visual Studio 15 ���ɹ��� 2017
› Node.js: 16.17.0
› npm: 8.19.2
› pnpm: 7.13.5
› yarn: 1.22.19
› rustup: 1.25.1
› rustc: 1.63.0
› cargo: 1.63.0
› Rust toolchain: stable-x86_64-pc-windows-msvc

Packages
› @tauri-apps/cli [NPM]: 1.0.5
› @tauri-apps/api [NPM]: 1.0.2
› tauri [RUST]: 1.1.1,
› tauri-build [RUST]: 1.1.1,
› tao [RUST]: 0.14.0,
› wry [RUST]: 0.21.1,

App
› framework: Svelte

App directory structure
├─ .git
├─ .vscode
├─ embedded
├─ local-cargo
├─ node_modules
├─ public
├─ src
└─ src-tauri

Stack trace
No response
Additional context
No response

also tried ico, didn't work either.

worked for me here

make sure the path is correct.

my bad, i didn't describe it clearly. it does work on the first window but not work on the later windows.
so, setting a.ico to the first window, it works.
then, setting b.ico to the second window, it doesn't work.

btw, is there any special size or format for the png icon, it looks weird as you have tested, i also tested ico, it looks fine.

reproducible test case here
both of two issues can be reproducible

setting the second window's icon doesn't work
weird png icon looking(maybe incompatible pattern format? i don't know much about png format)

icon-test.zip

weird png icon looking(maybe incompatible pattern format? i don't know much about png format)
That's just Windows scaling down your image. You should be using an ico with multiple size or use a png with an appropriate size, 32x32 is good in most cases.


Update minimal dependencies for Electron apps

Also add a function which changes the trash dependencies based on the version of Electron used. This adds the semver package as a dependency.
Fixes #86.

Great PR but just a couple of things. Are these still correct and/or needed?
recommends: [
  'lsb-release'
],
suggests: [
  'gir1.2-gnomekeyring-1.0',
  'libgnome-keyring0'
],

Also, I've been thinking about the behavior of this option. Should user values under options.depends be always appended to the default values? We're packaging electron apps, so they will always need the default dependencies. Or leave the current behavior (replace all dependencies with user values) but state on the README that the default dependencies are the minimum ones for any electron app to work on Debian and they should always be included (unless there's a specific case that I can't think of).
Last, the README says that the default for options.depends is an empty array, which has never been true and with this PR we should put that there.

libgnomekeyring0

It is still listed in Electron as a development dependency for some reason. (Check the build scripts.)

lsb_release

It was added to Atom here: https://github.com/atom/atom/pull/6888
Perhaps it should go into suggests, since it seems to be a diagnostic tool.

Should user values under options.depends be always appended to the default values?

I think this should be the behavior. We'll need to minor version bump. (Side note: we should add a NEWS.md file, see Electron Packager for an example.)

Last, the README says that the default for options.depends is an empty array, which has never been true and with this PR we should put that there.

👍

I agreed with lsb_release being either removed or moved to Suggests
So, appending user dependencies to the default ones is a good idea but I've also been thinking if this change might break other apps that use this software expecting the old behavior. This change is somewhere in between a major and a minor version increment.
Also, should we be worried about duplicate dependencies? By appending user dependencies to the default ones, there might be duplicates. We should also check for that. I don't think having duplicates will create problems but it's something that shouldn't happen.

Well, I say minor because we're still not above v1. If someone is using this package, I hope they're using ^, which would mean they would have to manually upgrade anyway.
Mitigating the backlash that was in the /usr/lib issue would be the addition of NEWS.md.
I agree with deduplication of dependencies. I think JavaScript has sets?

I added them to the issue summary.
I think the last two points should go into a separate PR.


Remove default "Uncategorized" category when other categories are selected

Figure out a hook/action/filter to use to remove the default category when:

Number of selected categories is greater than 1
Default "Uncategorized" category is in selected categories.

@rpeterman-gp I'm going to add this one to the Four Kitchens queue

@rpeterman-gp
Is this for existing posts or for new posts?
Asking this because a default category is required for wordpress posts, but only when you create a post without selecting another category, so:

when you create a post without selecting a category, the default category will be associated to it.
when you create a post with a category selected, the default one won't be associated to the post.

Wontfix!


Investigate why TMCS takes longer than Shapley in 6-node experiment

See results attached in #56

Too old, probably obsolete --> close


Anchor tags in cross-site iframes doesn't open on click

Describe the bug
Most anchor tags in cross-site iframes doesn't open on click.
To Reproduce
Open this demo website:
https://s.erry.dev/?q=fb
Tapping (clicking) on the Facebook.com links opens them as expected.
Other links (e.g. Bloomberg, Wikipedia) won't open on click.
Long pressing and open works for all of them.
Smartphone:

Device: Xiaomi 11 Ultra
Android Version: 12
Kiwi Browser Version: 101.0.4951.40 (Play Store), 103.0.5060.103 (dev)

Additional context
This bug doesn't exist in any other mobile browsers that I tested, including chrome, chromium, firefox, edge, and yandex. So, iI am assuming that a filter feature is implemented in the Kiwi browser to block unwanted popups and redirections.
Disabling all extensions and the built-in ad-blocker doesn't solve this issue. I have also enabled pop-ups & redirections in the website settings.

Not exactly. In this video you can see that nothing happens when I click on any link but the Facebook one on the top.
https://user-images.githubusercontent.com/23471930/179405466-d5bc3262-1b99-44c4-b28c-96fde736c5bb.mp4


Package not install everytime

Six Package not installed
There is a issue whenever we use pip3 install six it only downloads a six-1.12.0.dist-info folder but it does not give the package.
I have tried it multiple times by pip too.
I have to download files maually and place it to that package.

Sounds like a pip bug. Try pip install -U pip.
If you can repeat the issue try to create a minimal reproducible example in a VM image or Dockerfile and raise the issue on https://github.com/pypa/pip

We would at least need to see the actual error to debug.


Update hello_world.md

It's change the method's Visual Studio at click

 Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.:x: tanopaterno sign nowYou have signed the CLA already but the status is still pending? Let us recheck it.

The documentation has been updated since the pull request was opened. The file that's updated in the pull request no longer exists in the repo. We'll close the PR.


[web] support felt test for firefox on windows

felt test --browser=firefox command runs both unit tests and integration tests.
It works on Linux and Mac now, it's better to increase the support to Windows.
We can also add one test to Windows LUCI bots to run, so that we can make sure that tooling won't break other changes. Running more tests on Windows bots (since Linux is already running them), won't add more value, and use resources.

Our story for Windows engine hacking is to use WSL, where Firefox should work already.


[QUERY]Documentation on using Template specs with Azure Sdk for .Net

Library name and version
Azure.ResourceManager.Resources
Query/Question
Hello,
I am searching for documentation on how to use Azure Template Specs. I have found some unit tests to guide me in a direction. But I cannot find any documentation on how to use Template Specs together with c# to create a Azure Deployment. Can anybody point me in the right direction?
Environment
No response

Label prediction was below confidence level 0.6 for Model:ServiceLabels: 'Search:0.3433485,ARM:0.24157965,Azure.Core:0.02576224'

Thank you for your feedback.  Tagging and routing to the team member best able to assist.

Hi @wimeling we have a sample program here that might help you: https://github.com/Azure-Samples/resources-dotnet-deploy-using-arm-template


Change of ownership for the OctopusDeploy plugin

Description

We have transferred the ownership of the OctopusDeploy plugin for Jenkins to the Octopus team from its original maintainer @badriance
https://github.com/OctopusDeploy/octopus-jenkins-plugin
Submitter checklist for changing permissions

Always

[x] Add link to plugin/component Git repository in description above

For a newly hosted plugin only

[ ] Add link to resolved HOSTING issue in description above

For a new permissions file only

[ ] Make sure the file is created in permissions/ directory
[ ] artifactId (pom.xml) is used for name (permissions YAML file).
[ ] groupId / artifactId (pom.xml) are correctly represented in path (permissions YAML file)
[ ] Check that the file is named plugin-${artifactId}.yml for plugins

When adding new uploaders (this includes newly created permissions files)

[x] Make sure to @mention an existing maintainer to confirm the permissions request, if applicable
[x] Use the Jenkins community (LDAP) account name in the YAML file, not the GitHub account name
[x] All newly added users have logged in to Artifactory at least once

I confirm that this is a mutually agreed upon change of ownership.


Support YARN for resource management

It should be possible to generate a Rust client for the Hadoop RPC protocol and communicate with YARN for resource management.

There is no need to implement this by the hadoop protocol, you can simply use the java to start/stop the sail process from my point.

There is no need to implement this by the hadoop protocol, you can simply use the java to start/stop the sail process from my point.

Thanks for the suggestion! This is a viable approach. We'll evaluate the path forward when we start to work on this.

There is no need to implement this by the hadoop protocol, you can simply use the java to start/stop the sail process from my point.

Thanks for the suggestion! This is a viable approach. We'll evaluate the path forward when we start to work on this.

Yes, I think I have some experience on this. If you want to do this, I'm glad to join this design discussion

@zuston Thanks for your interest in this! We'd love to have you in the design discussion.
What do you think about the option that uses the Hadoop RPC protocol in Rust? Admittedly, this is a non-trivial option that I haven't seen many people doing. The benefit is that the JVM won't be a dependency of Sail, so the user experience remains straightforward.


Appoint to swift 4.2

I noticed that the AttributedLib.podspec file did not update to the 2.2.0 version. So in pod update , pod would be updated to latest version

Codecov Report

Merging #58 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master      #58   +/-   ##
=======================================
  Coverage   64.35%   64.35%
=======================================
  Files           8        8
  Lines         331      331
=======================================
  Hits          213      213
  Misses        118      118

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fb6b512...72ef436. Read the comment docs.

@Arcovv This is great work! Thank you so much!


When I enter Chinese characters after the custom embed format content. the cursor position does not update

When I enter Chinese characters after the custom embed format content. the cursor position does not update
https://github.com/user-attachments/assets/092939e7-9d17-41cd-82ae-a7bdb1b68df0
But entering English is fine.
Steps for Reproduction

custom Embed format

class ReferenceBlock extends Embed {
  // ... other code
}

using the format insert content
continue input some Chinese characters

Expected behavior:
enter the Chinese characters. the cursor update position
Actual behavior:
the position is error
Platforms:
mac M2 . Chrome
Version:
2.0.2

I have the same problem


[Site] Upgrade 2.16

Q
A

Bug fix?
no

New feature?
no

Issues
None

License
MIT

Need any help there?

Need any help there?

Ha! I was about to say "No, all good - it's working" and then I saw the tests. Should be ok :). I'll check those. I tried all the affected demos - everything is working minus the small detail fixed by #1561, which is not new to 2.16

All good now - waiting for a GH sync issue to resolve so I can upgrade to include #1561


Add intermediate_size to GPT-NeoX models

The current implementation only allows to set intermediate_size for Llama models, but I would like to be capable to change the intermediate_size in GPT-NeoX models.
I have tested this implementation under a quick training, inference and conversion and it seems that it doesn't give any bugs. I hope it helps!

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

This looks good. Need to make it consistent with mamba and RWKV. We also need some TODO statements about revisiting this once we add swiglu.
@jahatef is on it

Added support for mamba and RWKV, and added TODOs.

With these changes, is there a point to having separate Linear and LLaMA Linear definitions? At a glance it looks like all the differences are configurable, with the only difference being what is assumed as the default behavior if unspecified.

Refactored the activations and MLP layer to get rid of our redundant llama mlp class, and added some activations functions from https://arxiv.org/pdf/2002.05202.


fix: JSONForm multiselect field with invalid option crash

Description
When invalid Options is passed to a multiselect field in a JSONForm, the widget crashes.
Example of invalid Options
{{ [ { label: "asd", value: "zxc"}, null ] }}

The second option is null which makes the whole Options property as invalid.
Fixes #20791
Type of change

Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

Manual
Cypress

Test Plan

Add Testsmith test cases links that relate to this PR

Issues raised during DP testing

Link issues raised during DP testing for better visiblity and tracking (copy link from comments dropped on this PR)

Checklist:
Dev activity

[x] My code follows the style guidelines of this project
[x] I have performed a self-review of my own code
[x] I have commented my code, particularly in hard-to-understand areas
[ ] I have made corresponding changes to the documentation
[x] My changes generate no new warnings
[x] I have added tests that prove my fix is effective or that my feature works
[x] New and existing unit tests pass locally with my changes
[ ] PR is being merged under a feature flag

QA activity:

[ ] Test plan has been approved by relevant developers
[ ] Test plan has been peer reviewed by QA
[ ] Cypress test cases have been added and approved by either SDET or manual QA
[ ] Organized project review call with relevant stakeholders after Round 1/2 of QA
[ ] Added Test Plan Approved label after reveiwing all Cypress test

/ok-to-test sha=236f11f

/build-deploy-preview env=release skip-tests=true

Observations: @ashit-rath

There is no detailed error message on debugger
On deploying the app with null value, the JSONForm buttons seems grey and does not follow theme color

https://www.loom.com/share/27ace33d9fca4e7781b4ed757cdf915d

Tested this PR and LGTM

No app breakage on passing invalid options

/ci-merge-check

/ci-merge-check

/ci-merge-check

/ci-merge-check


[BEAM-9940] Set timer family spec for TimerDeclarations in dataflow r…

…unner
Please add a meaningful description for your change here

Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

[ ] Choose reviewer(s) and mention them in a comment (R: @username).
[ ] Format the pull request title like [BEAM-XXX] Fixes bug in ApproximateQuantiles, where you replace BEAM-XXX with the appropriate JIRA issue, if applicable. This will automatically link the pull request to the issue.
[ ] Update CHANGES.md with noteworthy changes.
[ ] If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.

R: @boyuanzz

retest all please

Run Java PreCommit

Run Java PreCommit


Highlight the default profile in new-tab flyout

Summary of the Pull Request
This commit makes the default profile in the new-tab flyout show up
at the top and gives it bold text.

References
None.

PR Checklist

[ ] Closes #xxx
[x] CLA signed. If not, go over here and sign the CLA
[x] Tests added/passed
[ ] Requires documentation to be updated
[ ] I've discussed this with core contributors already. If not checked, I'm ready to accept this work might be rejected in favor of a different grand plan. Issue number where discussion took place: #xxx

Detailed Description of the Pull Request / Additional comments
None.

I'm a little curious how this will play with #805. Right now, the shortcuts for Ctrl+shift+N will open the N'th profile, and the dropdown is listed in order. So it's immediately clear that the 1st entry is Ctrl+shift+1, etc.
With this change, the entry at the top of the dropdown might not be Ctrl+Shift+1. I'm not saying that's bad, but it might be a little weird.

Yeah, this is definitely awkward.  I'm undoing the reordering of the profiles, but keeping the font weight contrast.

What happens if it becomes possible to have multiple profiles open by default?  Does making the font bold not end up looking messy with two or more profiles as default, compared to the remaining which will be listed in regular weight?
Could you perhaps move the default to the top and use a separator to distinguish the defaults from the other profiles?

The rationale behind me highlighting “the” default profile is that in Windows, a menu item of a control is usually marked bold if its action is equivalent to that of (double-)clicking the control.  In our case, since clicking simply the the plus button is equivalent to selecting the default profile in the flyout, marking that profile bold gives the user an affirmative mental feedback.
Even if we’re to make it possible to open multiple profiles by default, we’re still going to have “the” default profile that is what opens up when the user creates a new tab without specifying a profile.  Therefore I don’t think that’s going to be a problem logically.
发件人: Martin<EMAIL_ADDRESS>发送时间: 2019年5月21日 21:43
收件人<EMAIL_ADDRESS>抄送<EMAIL_ADDRESS><EMAIL_ADDRESS>主题: Re: [microsoft/terminal] Highlight the default profile in new-tab flyout (#888)
What happens if it becomes possible to have multiple profiles open by default? Does making the font bold not end up looking messy with two or more profiles as default, compared to the remaining which will be listed in regular weight?
Could you perhaps move the default to the top and use a separator to distinguish the defaults from the other profiles?
―
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHubhttps://github.com/microsoft/terminal/pull/888?email_source=notifications&email_token=AH3NPEVPPIGOKHDJDCMQMXLPWP365A5CNFSM4HNZNVZKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODV36H7I#issuecomment-494396413, or mute the threadhttps://github.com/notifications/unsubscribe-auth/AH3NPER7HWR4FRG2IW57TWTPWP365ANCNFSM4HNZNVZA.

@fghzxm  As far as I am aware, the Add button only displays a flyout, and there is not double click action.  I thought the default profiles, are the tabs which will open when you first launch Windows Terminal from the Taskbar, or Start Menu/Screen.

The add (“+”) button launches “the” default profile without asking which profile to launch, while its slibling V button displays the flyout.  Therefore their behavior is indeed related.  I could have explained it clearer though.
As for the launched-by-default set of profile, even though they are technically a kind of “default” profiles, they’re not related to the plus button’s behavior.  In fact what this profile set constitutes should be largely irrelevant after the Terminal is launched.  I therefore don’t think it particularly useful to top-pin these profiles.  (With that being said, we could probably add the ability to specify a group of “favorite” profiles to be top-pined in this flyout (and possibly be treated specially in other ways as well) nevertheless, if there will actually be users who’re going to add so many profiles that navigating through even the profile list becomes painful.)
发件人: Martin<EMAIL_ADDRESS>发送时间: 2019年5月21日 21:57
收件人<EMAIL_ADDRESS>抄送<EMAIL_ADDRESS><EMAIL_ADDRESS>主题: Re: [microsoft/terminal] Highlight the default profile in new-tab flyout (#888)
@fghzxmhttps://github.com/fghzxm As far as I am aware, the Add button only displays a flyout, and there is not double click action. I thought the default profiles, are the tabs which will open when you first launch Windows Terminal from the Taskbar, or Start Menu/Screen.
―
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHubhttps://github.com/microsoft/terminal/pull/888?email_source=notifications&email_token=AH3NPEVWX6F2VH6YYIC7A63PWP5TVA5CNFSM4HNZNVZKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODV37UMI#issuecomment-494402097, or mute the threadhttps://github.com/notifications/unsubscribe-auth/AH3NPEXGYJN2FBTNIGSCJFDPWP5TVANCNFSM4HNZNVZA.


Allow increment strategy for not defined types

Q
A

Type
bug/improvement

BC Break
no

Summary

As decimal128 is not provided by doctrine types, it may be created as custom type. But even if mongo allows to use increment strategy with decimal128, doctrine throws an exception, that increment storage strategy is not allowed. Only doctrine restriction is to deal with. No other implementation is needed.

As decimal128 is not provided by doctrine types, it may be created as custom type.

Yes and no - we should rather ship the new type by default, allowing users to use it without implementing custom types. This would also allow us to not allow the increment strategy for all types by default but rather allow it for the new decimal128 type.
Would you be up for adding the decimal128 type to ODM 2.0?

Note that in order to increment a Decimal128 object one will need to convert it to a string, calculate the increment (likely using bcadd() from BCMath), and convert the result back to a Decimal128 object1.
The driver's handling of Decimal128 is currently limited to conversion to/from a string. It does not implement the necessary do_operation object handler to allow math operations on these objects. PHPC-847 is tracking implementation of the compare_objects handler to allow two Decimal128 objects to be compared with one another. While that's likely simpler than implementing do_operation, it is still not a trivial task.
On a related note, Internal operator overloading and GMP improvements was implemented in PHP 5.6 (https://github.com/php/php-src/pull/342). GMP only supports integer math. The RFC did allude to supporting BCMath but I don't think that was ever implemented. That is likely because the bcmath extension does not provide any objects with which to implement the handlers -- unlike gmp, which provides both a procedural API and an object-oriented API using the GMP class.
The relevant code for actually handling the "increment" storage strategy is in PersistenceBuilder:
https://github.com/doctrine/mongodb-odm/blob/e7c926b8a0cae830c0b7f48005afde83fd3921a2/lib/Doctrine/ODM/MongoDB/Persisters/PersistenceBuilder.php#L149-L151
@uLow: That will require some modifications to actually support the feature you're asking for. Simply adding STORAGE_STRATEGY_INCREMENT to the list of allowed strategies isn't going to cut it.
Thinking more generally, the best way to implement this may be to allow types (either custom or ODM's built-in types) to implement some interface that provides a method to calculate an increment.This would basically be a limited form of operator overloading used expressly for ODM's increment strategy. If implemented, a future Decimal128 type in ODM could then implement this interface and utilize BCMath internally as it wishes.

Alternatively, a future ODM type for Decimal128 might convert it to a string for its PHP representation to save users the trouble of doing so themselves. This would be similar to how BSON dates are converted to a PHP DateTime when set on entities.

Given the excellent explanation by @jmikola, I'm closing this one here. Just allowing the increment strategy will do you no good since we'd also have to use bcmath to calculate the difference to send to the database server. Without that, you might as well not use the Decimal128 type and stick with 64-bit numbers.
I've created #1835 to track the feature request to add a new Decimal128 type which would also incorporate the logic to properly calculate the difference when using an increment strategy. Given our current progress on 2.0 and the timeline, I've scheduled it for inclusion in a 2.1 release.


If an action is pinned to a commit, this is most likely as a security precaution, so always update pinned commits to the commit hash corresponding to the latest tag.
Fixes https://github.com/dependabot/dependabot-core/issues/2470.

This seems right to me, thanks! cc @infin8x double checking that you agree this is the desired behavior

Makes sense to me!

I'm fixing those failing cargo specs on a different branch those are unrelated. Not sure why most of the suites are getting killed at 5m on here, but if the actions suite passes I'm going to merge this, thanks so much @reitermarkus

@jurre Just wondering, has this reached production? Because I'm still having actions updated from a commit hash to a tag.

It's just the PRs titles that still have the tag name which confused me. Sorry about that!

@rosslh was that because the old PR was still open, or did we create it after the fix went live with the wrong title?


InvertibleDiffEqOperator ?

https://github.com/SciML/SciMLOperators.jl/blob/fb0e1e0d73adfd27b5a47602f7cfe2e21c8164dc/src/operators/basic_operators.jl#L114-L127
Would a more general InvertibleDiffEqOperator that just checks has_ldiv, has_ldiv! make more sense?
struct InvertibleDiffEqOperator{T<:Number, FType}
  F::FType
  #
  function InvertibleDiffEqOperator(F)
  @assert has_ldiv(F) | has_ldiv!(F) "F doesn't have Base.\, or LinearAlgebra.ldiv! defined"
  new{eltype(F),typeof(F)}(F)
  end
end

also lazy adjoint, inverse wrappers for complete operator algebra

also a lazy inverse, InvertedOperator

based on https://github.com/SciML/LinearSolve.jl/blob/main/src/preconditioners.jl


slider not working in chrome

What should happen?
progress bar background color dose not change according to value .
What happens instead?
I need to change progress bar color changes according to value
Possible Solution
Test Case and/or Steps to Reproduce (for bugs)
How to reproduce:
1.create and html input type="range" tag
2.provide the css for progress bar and progress bar thumb.
3.
Context
need to fill the progress bar background according to thumb position value.
but input[type="range"] parameter take an overflow:"hidden" option .
i didn't want this i need to support progress bar like it works in other browsers.
Your Environment

Foundation version(s) used:
Browser(s) name and version(s): Version 71.0.3578.98
Device, Operating System and version: windows 8
Link to your project:

@rushikeshk-gdb  - you should probably close this right?


Line breaks in code block are missing

reader url: https://r.jina.ai/https://fastapi.tiangolo.com/advanced/advanced-dependencies/
The line breaks and indent are missing, it's extremely important for python code 🥲

i think it is our tidyMarkdown function issue, @nomagick could u look at it?

This was the behaviour of the turndown default rule.
Now it should be better.
https://github.com/jina-ai/reader/commit/ee008ebe10a172a31228d42e92d70bba45b5fd72

Thanks, It's improved! However the code block is not quoted, could you please have a look?


Stuck scroll position

As per http://forum.ionicframework.com/t/default-scrolling-problem/536
This happens quite a lot and makes the scroll experience jumpy. What happens is that the scroll seems to go "off page" - and then stay there.
Specifically, this seems to happen on scrolling content that has pull to refresh active

I am facing this issues also now. I scroll a bit on the page and the scroll bar get stuck and starts producing the error: TypeError: zyngaCore.effect.Animate.route is not a function. (In 'zyngaCore.effect.Animate.route(self.__isDecelerating)', 'zyngaCore.effect.Animate.route' is undefined)


Delete barrier drafts

@CWaszczuk-DIT If you use the tab key you focus behind the modal and skip around behind it, we may need to change the approach on this?


[BUG] state name can't be added as a logger variable

Description
It's often useful to log the current state name along with the other parameters.
logHelper.add(currentState->getName(), "state"); doesn't work because it returns pointer to the name of the state.
Even if the State::getName return type is changed to a reference to pointer( const char *&getName();) the following compile error occurs:

CANOpenRobotController/lib/spdlog/helper/LogHelper.h:104:30: error: no matching function for call to ‘to_string(const char*&)’

Not sure what can be a quick and clean fix.

We would need to store and return the state name as an std::string and not a const char*. Given it is not much used anywhere else this should be possible without breaking anything and quite useful actually.
Otherwise, a very quick fix is to declare an std::string in your state machine and update it in the update method. If you pass the reference to that string then you are good.


Fix in-place update of arrays in Link.serialize and optimizers.Adam

Taking over #7425
Fixes #7424

Jenkins, test this please.

Jenkins CI test (for commit 48865038c1f53e54dd5fb0c92cf86dcb726b3377, target branch master) succeeded!

@niboshi the CI failures seem to be happening in TestLinkFromToChainerx when mixing it with ideep arrays.

PTAL

Jenkins, test this please

Jenkins CI test (for commit c45ddc8cc98fb56ce809742e3e6dd42b0973de70, target branch master) succeeded!


Cedar/Proto.c: fix session deletion not being triggered in certain cases

ProtoHandleDatagrams() takes care of deleting a session if marked as halted.
However, the check is performed when a packet for that session is received; that never happens if the remote host doesn't send at least a packet.
This commit fixes the issue by moving the check into the loop that iterates through all sessions.

Build failure fixed in microsoft/vcpkg#12569, but vcpkg is not updated in the Windows image on Azure Pipelines.


⚠ Bofrost.at has degraded performance

In 998c2a4, Bofrost.at (https://www.bofrost.at) experienced degraded performance:

HTTP code: 200
Response time: 1660 ms

Resolved: Bofrost.at performance has improved in fe7ff6b after 308 days, 16 hours, 25 minutes.


Add pry-remote to Gemfile.

We normally run our dev environment with foreman/bowler so our process to be debugged is not in the foreground.

Yay https://github.com/Mon-Ouie/pry-remote#usage


Added a way to configure more than 3 colors

Description
I wanted to have more options for colors in my highlighting, and I saw how the default is hardcoded to just 3 colors, which is why I created this addition.
This PR adds a setting "rainbow-end.colors" which allows for overriding the configured colors with a variable amount of user-defined colors, which via an event listener allows for hot-reloading. This is also configurable through the settings UI, if wanted.
I also added support for repeat/until for Lua, as described in https://www.lua.org/manual/5.4/manual.html#3.3.4
Example
"rainbow-end.colors": [
  "#987654", "#547698", "#769854", "#abc123"
]

Review points
I don't know how to best handle that there are 2 ways to set the colors now, especially as I think differentiated support for different theme styles is really neat. My best bet is what I have submitted here: Just allowing the setting to be an override.
I am open to implement fixes and making this better based on feedback.

Wow !!!!! Thanks !!!!


Make protoc version parser able to handle 'libprotoc 3.6.1'

Bug: https://github.com/openweave/openweave-wdlc/issues/38

Can you comment on what failed with the prior regular expression and what the new regular expression addresses?
It looks like you're adding support for extended regular expressions, for portability, you should probably use -E vs. -r.

I created the attached script, based on running git tag -l based on a clone of https://github.com/protocolbuffers/protobuf.git. The script attempts to use both the baseline regular expression, both using BSD and GNU sed, as well as the proposed regular expression, both using BSD  and GNU sed.
At least for my environment, the proposed regular expressions fail with:
/usr/local/gnu/bin/sed: -e expression #1, char 1: unknown command: `-'

for GNU sed and:
sed: 1: "-r
": invalid command code -

for BSD sed. For the baseline regular expression, both BSD and GNU sed successfully handle any x.y.z version but fail those with "-extra" bits or those of the form x.y.z.p.

I haven't investigated this nearly as much as you have at this point. But here's what I have.

Can you comment on what failed with the prior regular expression and what the new regular expression addresses?

Probably not. I did nothing to debug the previous pattern, just wrote my own based on my extremely limited understanding of sed. I didn't even go into this knowing what versions you were targeting.
On my workstation I have the following:
$ protoc --version
libprotoc 3.6.1
$ sed --version
sed (GNU sed) 4.7
Packaged by Debian

And with those versions the pattern as currently written does not detect my version of protoc.
I'm in the process of getting access to our build servers to determine what their output is. What I do have is this:
configure: error: protobuf version between 3.3.0 and 3.9.1, inclusive, is required. However, /usr/local/google/home/mosaic-role/slave/repo_clients/internal/master/out/host/linux-x86/bin/protoc is version unknown.
Please try downloading and installing 'https://github.com/protocolbuffers/protobuf/releases/download/v3.3.0/protoc-3.3.0-linux-x86_64.zip' or later.
make[1]: *** [Makefile:534: config.status] Error 1

But I don't think that helps much until you have the specific output of protoc --version and sed --version

Our build systems have this sed:
$ sed --version
sed (GNU sed) 4.7
Packaged by Debian
Copyright (C) 2018 Free Software Foundation, Inc.

Our build systems have this sed:
$ sed --version
sed (GNU sed) 4.7
Packaged by Debian
Copyright (C) 2018 Free Software Foundation, Inc.

That's the same version in my attached test for "GNUSED", so at least we have an apples-to-apples comparison there.

Okay, from our build servers:
~$ protoc --version
libprotoc 3.7.1

It sounds like what I need to do is to update this pull request so that it passes all of the tests in  protoc-version-test.sh.zip as well as parsing the version strings from our systems. Is that all that is required to get this merged?

It sounds like what I need to do is to update this pull request so that it passes all of the tests in protoc-version-test.sh.zip as well as parsing the version strings from our systems. Is that all that is required to get this merged?

Ideally, we can figure out why the test is failing on the build machine since the test file I uploaded indicates that it should work for the version cited. Can we capture the od -x output of protoc --version on the build machine? Maybe there is an escape character or something in there fouling up the regular expression.

I'm not going to be able to capture it on the build machine because that takes time and requires access I don't have. I can capture it on my workstation, however, where the sed pattern also fails.
> protoc --version | od -x
0000000 696c 7062 6f72 6f74 2063 2e33 2e36 0a31
0000020

I updated my proposed pattern in your script.  I don't have an easy way to test BSD sed, I'm not familiar with BSD and it looks like compiling just sed is non-trivial. From running your tests on my system with GNU sed this new pattern seems strictly better in various ways including recognizing patterns like 3.11.0-rc2 as 3.11.0 and not mis-recognizing <IP_ADDRESS> as 6.1.3.

Great, confirmed, this builds on my workstation within our larger system.


Build socket-based token exchange as fallback auth mechanism

For whatever reason, socket.io doesn't always send the cookies header when it connects. Build a system where we manually send the authToken cookie over a socket message to authenticate the connection

Ended up trying the alternative in 27bfc7ed156446080bac28943b0d08bdb447fc5c. Hopefully that works?


Policy generated when deny_nonsecure_transport = true is incomplete/outdated

Description
The policy generated when deny_nonsecure_transport = true is incomplete/outdated
Versions

Module version [Required]: 1.3.1
Terraform version: 1.6.6
Provider version(s): 5.21.0

Expected behavior
When enabling via the web console, we see the generated policy to be:
{
    "Version": "2012-10-17",
    "Id": "efs-policy-wizard-01983604-a016-498a-b73c-a6956f8caa13",
    "Statement": [
        {
            "Sid": "efs-statement-ba87d44a-9919-4ded-969e-b42792f6e334",
            "Effect": "Allow",
            "Principal": {
                "AWS": "*"
            },
            "Action": [
                "elasticfilesystem:ClientRootAccess",
                "elasticfilesystem:ClientWrite",
                "elasticfilesystem:ClientMount"
            ],
            "Condition": {
                "Bool": {
                    "elasticfilesystem:AccessedViaMountTarget": "true"
                }
            }
        },
        {
            "Sid": "efs-statement-d04fd86d-0ea8-49dc-9d76-b6383171d3a7",
            "Effect": "Deny",
            "Principal": {
                "AWS": "*"
            },
            "Action": "*",
            "Condition": {
                "Bool": {
                    "aws:SecureTransport": "false"
                }
            }
        }
    ]
}

This policy allowed my ecs containers to properly mount the volume.
Actual behavior
When deny_nonsecure_transport = true (which is the default), this module generates an incomplete policy:
{
    "Sid": "NonSecureTransport",
    "Effect": "Deny",
    "Principal": {
        "AWS": "*"
    },
    "Action": "*",
    "Resource": "arn:aws:elasticfilesystem:us-east-1:12345678912:file-system/fs-0114bc825a22274e46",
    "Condition": {
        "Bool": {
            "aws:SecureTransport": "false"
        }
    }
}

This policy is insufficient for ecs containers to mount the volume when transit_encryption is enabled.
(Seems like this issue has been reported before without a response https://github.com/terraform-aws-modules/terraform-aws-efs/issues/11)

This issue has been resolved in version 1.4.0 :tada:


Installing npm dependency from public GitHub repository fails

In one of my projects I use simple-caldav which contains the following line in its package.json:
dependencies: {
  "ical.js": "github:TimDaub/ical.js#feat/detect-module-mode-build",
  ...
}

It points to a branch here. I've submitted a PR to the upstream repo, but it seems they're not having much time for maintenance.
Anyways, my GH action in the project that has simple-caldav as a dependency looks like this
# This workflow will do a clean install of node dependencies, build the source code and run tests across different versions of node
# For more information see: https://help.github.com/actions/language-and-framework-guides/using-nodejs-with-github-actions

name: Node.js CI

on:
  push:
    branches: [ master ]
  pull_request:
    branches: [ master ]

jobs:
  build:

    runs-on: ubuntu-latest

    strategy:
      matrix:
        node-version: [10.x, 12.x, 14.x]

    steps:
    - uses: actions/checkout@v2
    - name: Use Node.js ${{ matrix.node-version }}
      uses: actions/setup-node@v1
      with:
        node-version: ${{ matrix.node-version }}
    - run: npm ci
    - run: npm test

However, when it runs npm ci, it fails like this
npm ERR! Error while executing:
npm ERR! /usr/bin/git ls-remote -h -t<EMAIL_ADDRESS>npm ERR!
npm ERR! Warning: Permanently added the RSA host key for IP address '<IP_ADDRESS>' to the list of known hosts.
npm ERR<EMAIL_ADDRESS>Permission denied (publickey).
npm ERR! fatal: Could not read from remote repository.
npm ERR!
npm ERR! Please make sure you have the correct access rights
npm ERR! and the repository exists.
npm ERR!
npm ERR! exited with error code: 128

@TimDaub did you find any workarounds?

Nope, I'm quite confused by this problem. E.g. why does it say git ls-remote? Is npm using git internally?
I could imagine another notation within package.dependencies could make a difference. But I haven't tested that yet.

Thought the same and even tried that locally and works fine locally

@TimDaub I ended up releasing the forks as my own libraries publicly scoped to NPM since a project was breaking deployments because of this issue. It's a workaround but it's something :)

@TimDaub
Same issue here.
A very annoying problem...
Have you find any solution?

ended up releasing the forks as my own libraries publicly scoped to NPM since a project was breaking deployments because of this issue. It's a workaround but it's something :)

Unfortunately, it's not an option I have.

What ended up fixing it for me is adding the unknown host in my ssh config before npm ci:
...
- run: mkdir -p $HOME/.ssh/ && echo "<IP_ADDRESS>" >> $HOME/.ssh/known_hosts
- run: npm ci
...

It's far from perfect, but works well as a work around for now. Additionally, disabling ssh's key checking via config may be an option too. I prefer to go with this more narrow solution.

This is still an issue... An alternative solution is replacing the resolved url in the package lock file, for example:
<EMAIL_ADDRESS>becomes<EMAIL_ADDRESS>

Having the same issue, but within my workflows' docker build step. There has to be easier ways to disseminate SSH agent keys/known hosts info to different contexts when SSH-git actions are so commonplace

This is still a bug. I'm now going to implement the workaround @TimDaub suggested and it'll probably work but still... It hit me just as I released an version and I had no time to fiddle with private keys so github action can read public github URLs.
The attached screenshot does not compute and this bug should be opened.

This is still an issue for me with npm ci to install dependencies in GitHub actions. Sometimes it works and sometimes it fails.

For me this issue started occurring when I tried to switch from npm install to npm ci so for some of you switching to npm install may be another workaround.

I fixed this in my workflows by adding an extra step after the actions/checkout@v2 (with persist-credentials: false) step:
      - name: Checkout
        uses: actions/checkout@v2
        with:
          persist-credentials: false

      - name: Reconfigure git to use HTTP authentication
        run: >
          git config --global url."https://github.com/".insteadOf
<EMAIL_ADDRESS>
Changing from SSH to HTTP makes everything work across all workflows using npm ci (which has several benefits over npm install). If you need to authenticate, use a PAT instead of SSH:
git config --global url."https://${{ secrets.GH_TOKEN<EMAIL_ADDRESS><EMAIL_ADDRESS>

An update on my earlier workaround in this thread. A problem that I've discovered is that according to GitHub settings:

Secrets are not passed to workflows that are triggered by a pull request from a fork.

Hence, it becomes useless when trying to collaborate with others.

I fixed this in my workflows by adding an extra step after the actions/checkout@v2 (with persist-credentials: false) step:
      - name: Checkout
        uses: actions/checkout@v2
        with:
          persist-credentials: false

      - name: Reconfigure git to use HTTP authentication
        run: >
          git config --global url."https://github.com/".insteadOf
<EMAIL_ADDRESS>
Changing from SSH to HTTP makes everything work across all workflows using npm ci (which has several benefits over npm install). If you need to authenticate, use a PAT instead of SSH:
git config --global url."https://${{ secrets.GH_TOKEN<EMAIL_ADDRESS><EMAIL_ADDRESS>

this did fix my problem so thank you for that. Out of curiosity though is there any security lost by doing this? I don't care enough to not use this fix for the project I need it on but I am left wondering.

@wallind There is no difference in terms of transport security. HTTPS and SSH rely on similar underlying crypto. Persisting your credentials by adding your secret PAT to the global git config (the last bit of my comment) does have security implications, but it's the default behavior of the Checkout action already (persist-credentials: true) so no security is "lost" per se. If you don't want the PAT hanging around, run some form of post-job cleanup.

Why is this issue closed? I am still having this same issue and the workarounds are just that... workarounds.

This is probably caused by npm/cli#2610.

Ah, yeah it is. Thanks.

Workaround:

fwiw: my team swapped to use Yarn for performance improvements in the CI/CD and now the HTTP protocol workaround isn't needed. Just saying 🤷♂

I fixed this in my workflows by adding an extra step after the actions/checkout@v2 (with persist-credentials: false) step:
      - name: Checkout
        uses: actions/checkout@v2
        with:
          persist-credentials: false

      - name: Reconfigure git to use HTTP authentication
        run: >
          git config --global url."https://github.com/".insteadOf
<EMAIL_ADDRESS>
Changing from SSH to HTTP makes everything work across all workflows using npm ci (which has several benefits over npm install). If you need to authenticate, use a PAT instead of SSH:
git config --global url."https://${{ secrets.GH_TOKEN<EMAIL_ADDRESS><EMAIL_ADDRESS>

Thanks for sharing! 👏🏼
I created an action here if someone else need something like this in the future

I'm having the same issue here https://github.com/dword-design/nuxt-mail/issues/94 and it seems to be an NPM-only thing. Yarn fetches the archived repo snapshots while NPM does some Git stuff with the SSH URL, which is probably the reason for the issue. The SSH to HTTPS replacement workaround is not really an option imho because the end user has to do it with his package-lock.json. So publishing a scoped package is probably the only way to do it.

FWIW, using npm@8 has finally fixed this my issue.

FWIW, using npm@8 has finally fixed this my issue.

Switching from node 14.x to 16.x solved the problem for me (using "npm ci")

Currently working in dev & prod. Based on @TimDaub original post:

I think I finally ended up solving it for good. This is what you'll have to do:

Backup your current RSA keypair at ~/.ssh
Generate a new RSA keypair on your system ssh-keygen -t rsa -C<EMAIL_ADDRESS>Ideally don't overwrite your existing keypair at ~/.ssh by entering a custom path.
Take the contents of the generated *.pub key and add it to your SSH keys in your GitHub account settings
In your repo that has the action, navigate to Settings > Secrets and add SSH_PRIVATE_KEY the contents of the private key file that was generated
Then in your repo's workflow file, add the following before -run: npm ci

For more details, check https://github.com/webfactory/ssh-agent

^ This still works and works well and is the only fix that I feel comfortable with. HTTPS over Github is out of the question imo. So to anyone just stumbling onto this -- I highly recommend you follow his steps.
We use a simple azure PaaS to run a react app, but our component library is not yet published or ready to be published, but does have some awesome functionality for a few components. Ergo, we needed that, along with the deps, then build and deploy. All I had to do was gen the key, add it and configure as mentioned (you can obviously name the secret whatever you want). Here is an edited example:
# Docs for the Azure Web Apps Deploy action: https://github.com/Azure/webapps-deploy
# More GitHub Actions for Azure: https://github.com/Azure/actions.

name: Build and deploy react/node app to Azure Web App Service

... on & env var removed for brevity ...

jobs:
  build:
    runs-on: ubuntu-latest

    steps:
      - uses: actions/checkout@v2

      - name: Set up Node.js version & configure GH actions so they can npm install from our own repo
        uses: actions/setup-node@v1
        with:
          node-version: '16.13.2'

      - uses<EMAIL_ADDRESS>        with:
          ssh-private-key: ${{ secrets.SSH_SECRET_KEY }}

      - name: npm install from package-lock, run unit tests, & build
        run: |
          npm ci
          npm run test --if-present
          npm run build:dev

      - name: Upload artifact for deployment job
        uses: actions/upload-artifact@v2
        with:
          name: <app_name>
          path: ${{ env.AZURE_WEBAPP_PACKAGE_PATH }}

  deploy:
    runs-on: ubuntu-latest
    needs: build
    environment:
      name: 'Production'
      url: ${{ steps.deploy-to-webapp.outputs.webapp-url }}

    steps:
      - name: Download artifact from build
        uses: actions/download-artifact@v2
        with:
          name: <app_name>

      - name: 'Deploy App Service'
        id: deploy-to-webapp
        uses: azure/webapps-deploy@v2
        with:
          app-name: <app_name>
          slot-name: 'Production'
          publish-profile: ${{ secrets.PUBLISH_PROFILE }}
          package: .

@AndrewJHart the only thing I don't understand is how the github account is relevant here. If CI can be triggered without any action from this specific account — why it even considers this account's SSH key? The SSH connection is between github action runner and github repo, I don't even understand where/when gihub account could become relevant here, but it indeed works (CI is triggered by pushing git tags by my account, I wonder if it will stop working if different account will be pushing tags)

I haven't had any luck getting the workarounds to succeed for this. And however this is broken, there are no hints in --verbose to tell me what has gone wrong


/usr/bin/xdg-open: 801: /user/bin/xdg-open: : permission denied

I have followed the instructions on your page.
then cd skypy
python3 skyspy.py
This opens dump1090 with
webserver started
('127.0.01', 50957)
/usr/bin/xdg-open: 801: /user/bin/xdg-open: : permission denied
Then it finds the dongle opens up dump1090 and shows aircraft ( opens the skyspy.html but does not pass the aircrft info to it)
I suspect the error with xdg-open is the problem so how do i give permission to it ???
Thank you in advance
Graeme

Issue was fixed after reinstalling some dependencies https://github.com/neilnm/skyspy/issues/2


Upading the readme, to stop others from wasting time on a known andro…

I hope this helps others.

That's not an issue with this module.
Since we don't even use onActivityResult method.


Post release doc update

Adding changes in docs that have been supposed to be done prior the release but have been forgotten. See the commit msgs for details. Summary:

updated list of envars
update reporting tutorials

Added a fixup commit fixing typos and small grammar issues

Left some grammar-related suggestions to fix up some of the wording. Optional.


Nolana

This is my Christmas present to the FOLIO Community: A tested single-server fresh installation documentation for Nolana.

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.6 out of 7 committers have signed the CLA.:white_check_mark: enettifee:white_check_mark: sekjal:white_check_mark: inkuss:white_check_mark: ostephens:white_check_mark: julianladisch:white_check_mark: zburke:x: Ian WallsIan Walls seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.You have signed the CLA already but the status is still pending? Let us recheck it.

Ah, these has merge conflicts, but they are (almost) all in the files which I did not touch. Must be that origin/nolana had been changed in the meantime, massively. I have been only working on this for less than one week, since last Wednesday. I only changed singleserverfreshinstall.md. Will it be my task to resolve conflicts other than in singleservefreshinstall.md, to get this PR merged ?

Why does git hub show me a "merge conflict" like this:
`<<<<<<< HEAD

In the same file, change log_timezone and timezone, otherwise they will be UTC.
=======

67ee15336fbba885575de693ae6be7f3d41720ac
`
It is obvious that I want to insert the line. How can I stop git hub from doing this ?

@inkuss can you sync your working branch first (which should pick up the Nolana updates, I think) and then try the merge?

@enettifee , I did that, but I am getting the same conflicts (which I would then have to resolve locally)
`git remote -v
inkuss  https://github.com/inkuss/docs.git (fetch)
inkuss  https://github.com/inkuss/docs.git (push)
origin  https://github.com/folio-org/docs.git (fetch)
origin  https://github.com/folio-org/docs.git (push)
kuss@hbz-187-11 MINGW64 ~/folio/docs (nolana)
$ git pull origin nolana
From https://github.com/folio-org/docs

branch            nolana     -> FETCH_HEAD
Auto-merging content/en/docs/_index.md
CONFLICT (content): Merge conflict in content/en/docs/_index.md
Auto-merging content/en/docs/Settings/System_software_versions/System_software_versions.md
CONFLICT (content): Merge conflict in content/en/docs/Settings/System_software_versions/System_software_versions.md
Auto-merging content/en/docs/Settings/Settings_circulation/settings_circulation.md
CONFLICT (content): Merge conflict in content/en/docs/Settings/Settings_circulation/settings_circulation.md
CONFLICT (add/add): Merge conflict in content/en/docs/Platform essentials/Permissions/_index.md
Auto-merging content/en/docs/Platform essentials/Permissions/_index.md
Auto-merging content/en/docs/Platform essentials/Item status/itemstatus.md
CONFLICT (content): Merge conflict in content/en/docs/Platform essentials/Item status/itemstatus.md
Auto-merging content/en/docs/Metadata/Inventory/MARCAuthority.md
CONFLICT (add/add): Merge conflict in content/en/docs/Getting started/Installation/singleserverfreshinstall.md
Auto-merging content/en/docs/Getting started/Installation/singleserverfreshinstall.md
Auto-merging content/en/docs/ERM/Licenses/_index.md
CONFLICT (content): Merge conflict in content/en/docs/ERM/Licenses/_index.md
Auto-merging content/en/docs/ERM/Agreements/_index.md
CONFLICT (content): Merge conflict in content/en/docs/ERM/Agreements/_index.md
CONFLICT (add/add): Merge conflict in content/en/docs/Bulk Edit/_index.md
Auto-merging content/en/docs/Bulk Edit/_index.md
Auto-merging content/en/docs/Acquisitions/Orders/_index.md
CONFLICT (content): Merge conflict in content/en/docs/Acquisitions/Orders/_index.md
Auto-merging content/en/docs/Access/Circulation log/circ_log.md
CONFLICT (content): Merge conflict in content/en/docs/Access/Circulation log/circ_log.md
Automatic merge failed; fix conflicts and then commit the result.`

Let me try something else, since I have only changed one file...

Created a new Pull Request, Closing this one.


Adapt workflows WIP

Start to work on some of the issues listed in #49 and start to use hdf5 tables for intermediate results.

Overall h5 table functionality should be working now, but still some stuff to do:

Move infected cell detection and preprocess_per_cell_statistic to separate job(s), see here
Change logic of arguments for the outlier detection, see here
Clean up the scripts in antibodies
Fix tests and make sure all results are correct ...

Also, we should keep in mind making it easier to re-run the pipeline smoothly in the same folder with different hyperparameters and for different input keys (e.g. serum_iga vs. serum_igg).
(Should be done in a separate PR though)
cc @imagirom

I don't think the way we pass the arguments for the outlier predicate make sense right now: https://github.com/hci-unihd/batchlib/blob/workflows/batchlib/workflows/cell_analysis.py#L224-L231
I would rather not pass any additional arguments and check in misc/tagged_outliers if we have a <PLATE NAME>_tagger_state.csv. Note that we get the misc_folder location as an argument.
@wolny would this make sense?

@constantinpape do you refer to the construction of the OutlierPredictate as in here: https://github.com/hci-unihd/batchlib/blob/master/batchlib/outliers/outlier.py#L50? By default we do take misc/tagged_outliers if nothing was given: https://github.com/hci-unihd/batchlib/blob/master/batchlib/outliers/outlier.py#L16. The plate_name needs to be specified somewhere though

The plate_name needs to be specified somewhere though

But this always corresponds to the folder name.
So I don't understand why you give the arguments to the parser when it doesn't make sense to use anything but the default values anyways.

ah you mean removing those: https://github.com/hci-unihd/batchlib/blob/workflows/batchlib/workflows/cell_analysis.py#L257-L260? Sure I agree, it's obsolete now

This is moving along pretty good. From my side most of the major changes are done.
Before merging, the following things should still be done:

check that results look good for a big plate to check that we don't have any obvious bugs. @tischi, could you do this at some point tomorrow? I am computing this right now: /g/kreshuk/data/covid/sandbox/h5-tables2/titration_plate_20200403_154849, should be there in the morning.
make sure that the plot function still work properly, I changed quite a few things in there ... Could you have a look at this at some point, @imagirom?
Fix #67. I will look into this.

In addition, @imagirom is working on the infected cell detection and the background subtraction now.
We can merge this PR independently of this, but can also wait for it, I don't mind either way.
Also there's a few smaller things I still want to do, but we don't need to wait for this either.
Just putting it here so I can keep track of it:

Try hdf5 tables with varlen strings (need to check if this works with java)
Use the same plot function for image level and well level plots
Clean up TODOs and FIXMEs. There are still quite a few of these scattered throughout the code that are either outdated or easy to fix.

I have added some commits towards proper background subtraction and better infected cell detection (In particular fixed a bug where nuclei were considered background in 3b3c39f).
Also, the IgG serum channel is now used by default for the boundary predictions (as they were trained on that channel), see f7952c1.
I will check some of the plots tomorrow.
All the preliminary work for #53, #54, #55 should be done, so I should be able to address all of those tomorrow.


[Feature Request] Selection Tools in Icy Draw

Hello I love the work you've done with Icy Draw.
I know as an ANSI Artist one of the most widely used featiures is the "selection" tools which has been a feature of most drawing tools even going back to TheDraw/AcidDraw.

Being able to select blocks and move them, stamp, flip, move elements underneath and making them transparent, etc.
These are invaluable tools to any ANSI artist and I'd love to see them implemented in your program! :)

It has a wide range of selection tools - you can even select by char, non rectangular selections and so on.
So I don't know what's missing.
Just "select" and use cut / paste. You can create new layers, move them around.
There is a selection tool that allows you to select by chars/attribute. If you hit shift while selecting with the selection tool it adds to the selection. ctrl removes from the selection.
If you paste you get options for rotate/x/y/stamp and so on.

Thanks for the quick response! Yes the selection tools you have in place are dope that's why I'm making this request.
Here's a quick screencap showing the Move functionality (M)

It helps to have a visual representation of your selection. Move it around the campus to get a preview of what it would look like and place it where it needs to go.
Setting the selected block to go underneath elements or be transparent, as I show in that screencast with the letters layering underneath each other, saves a ton of time.
I also know artists frequently use this block selection's "Stamp" functionality to save time.
I remember you saying that you don't do much drawing yourself, so I'm providing feedback based on a feature I use all the time and wouldn't be able to switch without. I am confident other old sceneheads would feel the same way.
This feature isn't unique to modern editors; it's been a standard since AcidDraw.
Right now you have cut/copy/paste which is fine but not as precise and involves a lot of trial and error/guess work.

Another example for context

As said - it's a cut & paste thing in icy draw - here a demo that shows some bits and non rectangular selections:
https://github.com/mkrueger/icy_tools/assets/341098/acbd3314-f318-4ec2-9b4b-f4d661bbd40a

Or you can use selection to replace chars:
https://github.com/mkrueger/icy_tools/assets/341098/1d5d6fa9-72f6-4b1c-83e1-c92e21477e3a

That's interesting. I don't have the same functionality as you. The keyboard shortcuts don't work on Windows 11 Pro for me. Can you help me troubleshoot that?
A few selection questions:

What's the difference between a yellow and white dotted line selection?
How do I deselect this yellow dashed area?

Y hotkeys are broken atm - I need to fix that. Some update in one of the libs I use seem to have broken them. I need to look if it got fixed.
The yellow thing is the border of the layer you're on. There is an option in the view menu to deactivate that. But I think it's useful when working with layers.

Closing -> no response. Selection tool is part of icy draw. If there is an issue with it reopen.

I was waiting to respond when hotkeys were fixed, is that done now?


Bonds initiation with model pointer

I have redefined the bonds initiation with pointer to model.
@akabla does it sound reasonable?
commit 55843c5  (files: definition.jl, utility.jl, processing.jl)
Future extensions:

[ ] More than one level of clustering
[ ] Different models for different bonds (model will be a vector of pointers with specified bond numbers for each model)

pointers currently not used
(amount of memory to save information is negligible)


strange visualizer window in Vapor3.4

I just installed Vapor 3.4 on MacOS Big Sur. When I open Vapor, the visualizer window is transparent. After importing a WRF-ARW file, a black visualizer window with only 1/4 size appears on the lower-left corner. Any fix? Thanks very much.

@seanboulder The transparent visualizer is something we've looked at before, but your report may put more emphasis on getting this fixed.  Note for team: #2488 reports the same issue.
The visualizer taking up 1/4 of your window is new to me though .  Can you provide us with the verison of Vapor you're using, the OS you're using, and/or a sample file and a session file?  We'll try to reproduce it and the better we can replicate what you see, the more likely we'll be able to fix it.
Thanks for reporting this.

@sgpearse @clyne
Vapor Version: <IP_ADDRESS>aeef18
Macbook Pro 2020, Big Sur 11.4
Sample WRF data: https://drive.google.com/file/d/1wgOp2hwhjRmO8s0FXxgBFG4vuSdmxWv5/view?usp=sharing
I also reported the same problem on vapor.discourse.group
I tried Vapor 3.3, it doesn't have this small window problem.
Many thanks.

I've confirmed that this works fine with the attached data set on Catalina (Mac OSX 10.15.7). I guessing this is a Big Sur problem. We'll have to see if we can run down a 11.x Mac.

Also being reported by ViggoHanst on our forum. :\

As well as by user yochen.

I am also seeing this issue on Big Sur with the window only being quarter filled. I am also seeing a different issue that I think is related, which is why I'm posting this here. I am unable to drag the red handles to adjust the plotted region. When I try to drag the handle, the visualized box rotates instead. I am guessing this is because the code thinks the handle is somewhere else on the screen based on the full window instead of the quarter window that is displayed--just a guess though.

I'm able to verify this reported bug using the 3.4 installer.
If I open VAPOR from a local build and import the attached WRF file, VAPOR will crash with this message on screen:
shaomeng@cisl-watson VAPOR-git/build % ./bin/vapor.app/Contents/MacOS/vapor
qt.qpa.window: <QNSWindow: 0x7f86c91bb100; contentView=<QNSView: 0x7f86c91ba940; QCocoaWindow(0x7f86c91ba820, window=QWidgetWindow(0x7f86c91b8540, name="QGLWidgetClassWindow"))>> has active key-value observers (KVO)! These will stop working now that the window is recreated, and will result in exceptions when the observers are removed. Break in QCocoaWindow::recreateWindowIfNeeded to debug.
num threads = 16
num threads = 16
num threads = 16
num threads = 16
num threads = 16
num threads = 16
num threads = 16
num threads = 16
num threads = 16
num threads = 16
num threads = 16
num threads = 16
num threads = 16
num threads = 16
num threads = 16
num threads = 16
zsh: bus error  ./bin/vapor.app/Contents/MacOS/vapor

@shaomeng do you have the resources to troubleshoot and repair?

No, I don't have experience with OpenGL in QT, nor how VAPOR initializes an
OpenGL environment etc.
On Thu, Jul 1, 2021 at 6:41 AM clyne @.***> wrote:

@shaomeng https://github.com/shaomeng do you have the resources to
troubleshoot and repair?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/NCAR/VAPOR/issues/2751#issuecomment-872213014, or
unsubscribe
https://github.com/notifications/unsubscribe-auth/AAGG6JNH5XW65LGKWYHH3DTTVRO7BANCNFSM46PESYNA
.

Suggestions on how we resolve this then? @stasj is probably the one that needs to look at it, but I don't believe he has access to a Mac OSX 11.x system...

Given that VAPOR 3.3 runs well on Big Sur (which I have verified to be true) while VAPOR 3.4 doesn't, I think it's more likely a VAPOR problem rather than a macos problem: something changed in vapor wrt OpenGL from VAPOR 3.3 to 3.4. I can help with testing, but I'd agree that it'd make things a lot easier if Stas has a Big Sur machine.

If that is the case then I have no idea what could be the culprit. I thought it would be the QOpenGLWidget however that has not changed since Vapor 3.1

Do we have another Mac that would could update to 11.x that @stasj can lay hands on? @sgpearse what about our test systems?

@sgpearse will have one of our loaner macs updated to 11.x and hand the system over to @stasj for troubleshooting this problem.


Add ability to capture Mouse Down/UP events on Canvas

This is to enable the ability to define a time range.
Alternatively - expose a onCanvasTimerange.
This scenario is necessary if I want to enable my users to select a timerange on the canvas, then create a new activity on that time range.
If this feature is acceptable, I'd be happy to work on it.

hi @morsh thanks for this idea.  I believe this would interfere with canvas drag:

mousedown + drag scrolls the canvas
mouse up releases drag

im not sure how to allow for this and not irritate 99% of users

Might this be doable on drag-disabled Timelines?
That means a Timeline that's controlled by visisble time start/end.

I'm sorry but this seems like to specific of a use case to your specific need to introduce to this library.  Managing when and how to fire those events would complicate the codebase for something that not everyone is going to use.
I'm going to close this issue.  If you feel strongly that this should be in the library, please feel free to fork the repo and get a working example going.  If there are enough users that are behind implementing this in the library we can look at implementing it then.

Editing or adding items isn't too specific a use case, but doing it using a gesture of clicking and dragging on the timeline but only when the timeline is locked is pretty specific.
It's possible I don't fully understand what you want here, which means that I'll need to see it in code. Feel free to fork and submit a PR but I can't make any promises that it will be added.  The API of this library is already way too loose IMO. Introducing yet another handler will make it more so.  Maybe after a major refactor of this library's structure will allow for you to implement this in your code (without augmenting the library api).


How to start the videos at a specific time?

Hello, this is more a doubt of how to use than a real issue...
I'm trying to start the videos at a specific time, but I couldn't do that before the video start.
If I let the video start automatically and then call controller.seekTo( ... )  when press a button, for instance, the video goes correctly to the specific time.
Can you help me with that?
Thanks!

I would also like to know this as well as how to stop a video at a specific time. Thanks!

Extremely sorry for the late respond, was quite busy since last time I updated the plugin. Will look like into the problem.

@malder08 in version 4, there's startAt property. You may use it to start video at specific time.


Support unary minus operator on vectors

@TheSandvichMaker on HMN pointed out that we don't support unary minus for vectors. Oops.

Doh, not sure how we missed that. We can get that implemented pretty easily / quickly

Closed. Added in #130


[SE-0111] Update for removal of argument labels from function types

@mwwa do we need to backport?