The details of subscription displayed inproperly

Date: 2016/05/06
[Test category]: creative Test
[Steps to reproduce]

Log in marketplace as customer;
Select a service to make a subscription named as "test", then assign customer to this subscription;
Click on "MY SUBSCRIPTIONS", select the subscription which subscribed just now to see the details;
Input some words of the search box to make the search result null or do not contain the "test".

[Expected result]
In step 3, the details of "test" should be displayed successfully;
In step 4, the details of "test" should not be displayed.
[Observed result]
In step 3, the details of "test" was displayed successfully;
But in step 4, the details of "test" was still displayed.

Hello.
The behaviour proposed in expected result is inconsistent with existing column filter. If you filterout currently chosen subscription, it will not disappear from the details view. In my opinion we should keep it consistent and change both functionalities (column filter and subscription filter) or none.
Regards, Dawid.

...we should keep it consistent
Yes.
and change both ... or none.
I vote for both. I think the details pane should be consistent with the selection in the table.

@mdehn
Please decide.

Please do not show the details if no subscription is selected in the list of subscriptions.
So change both.

[Build] 2016/08/09 verified


CSUB-312:   Conditionally panic! in migrations when testing

so that future tests would crash if unexpected situations happen and we would have to inspect the crashes and figure out how to deal with potential corner cases
@nathanwhit, @CAGS295 - what would happen if even despite tests such panic happens when migrating a mainnet node ?

I haven't explored yet what happens under panics. We need to consider what happens when the scheduled upgrade fails. I suggest having a feature option for testing and otherwise never panic.

Failing job in CI if we're using log::warn! directly instead of the warn_or_panic! - https://github.com/gluwa/creditcoin/actions/runs/3744124997/jobs/6357132834
PASS -> https://github.com/gluwa/creditcoin/actions/runs/3744195353/jobs/6357285397 after the current changes.

Codecov Report

Merging #820 (234c82b) into dev (80ed87a) will not change coverage.
The diff coverage is 0.00%.

@@           Coverage Diff           @@
##              dev     #820   +/-   ##
=======================================
  Coverage   78.05%   78.05%
=======================================
  Files          66       66
  Lines       10609    10609
=======================================
  Hits         8281     8281
  Misses       2328     2328

Impacted Files
Coverage Δ

pallets/creditcoin/src/lib.rs
81.70% <ø> (ø)

pallets/creditcoin/src/migrations/v6.rs
89.21% <0.00%> (ø)

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more


Consider Adding Semantic Versioning

Potentially need to add semver versioning to allow us to use keepachangelog.
Unblocks: #2

This is currently an initial release to gauge interest, so is missing release bundles and the all-important changelog 😄
There is a future plan to provide official tagged releases (which will of course follow SemVer), as well as pre-built container images and a simplified deployment process.


Only reset curwin->w_nrwidth_line_count if it makes sense

Problem:   ml_open() resets curwin->w_nrwidth_line_count but the caller may
pass in a buffer that is not equal to curwin->w_buffer. In that case
there should be no reason to reset curwin->w_nrwidth_line_count.
Solution:  Only reset curwin->w_nrwidth_line_count if buf == curwin->w_buffer.
Avoids unnecessary re-calculation of curwin->w_nrwidth_width. For example popup_create() calls ml_open() with a newly created buffer that is not equal to curwin->w_buffer at popupwin.c:2100. Should be no reason to reset nrwidth_line_count in that case I don't think.
Ref: https://github.com/neovim/neovim/pull/21493

Actually, this assignment seems completely unnecessary.

True, the b_ml.ml_line_count == wp->w_nrwidth_line_count check in number_width() will fall through regardless if it has changed.

Updated the PR and commit message.

Included in patch 9.0.1089, (which referenced the wrong issue).


train with muliple gpu get error: Out of range:  End of sequence

I am training with tensorflow2.0 with multiple GPU. It got the following errors. But if I use only one GPU it ran without any error. My tensorflow version is tensorflow-gpu-2.0.0:
tensorflow.python.framework.errors_impl.CancelledError: 4 root error(s) found.
  (0) Cancelled:  Operation was cancelled
     [[{{node cond_6/else/_59/IteratorGetNext}}]]
  (1) Out of range:  End of sequence
     [[{{node cond_4/else/_37/IteratorGetNext}}]]
  (2) Out of range:  End of sequence
     [[{{node cond_7/else/_70/IteratorGetNext}}]]
     [[metrics/accuracy/div_no_nan/ReadVariableOp_6/_154]]
  (3) Out of range:  End of sequence
     [[{{node cond_7/else/_70/IteratorGetNext}}]]
0 successful operations.
1 derived errors ignored. [Op:__inference_distributed_function_83325]

Function call stack:
distributed_function -> distributed_function -> distributed_function -> distributed_function

and this is my code:
import tensorflow as tf
import tensorflow_datasets as tfds

data_name = 'uc_merced'
dataset = tfds.load(data_name)
train_data, test_data = dataset['train'], dataset['train']

def parse(img_dict):
    img = tf.image.resize_with_pad(img_dict['image'], 256, 256)
    label = img_dict['label']
    return img, label

train_data = train_data.map(parse)
train_data = train_data.batch(96)

test_data = test_data.map(parse)
test_data = test_data.batch(96)

strategy = tf.distribute.MirroredStrategy()
with strategy.scope():
    model = tf.keras.applications.ResNet50(weights=None, classes=21, input_shape=(256, 256, 3))
    model.compile(optimizer='adam',
            loss='sparse_categorical_crossentropy',
            metrics=['accuracy'])

model.fit(train_data, epochs=50, verbose=2, validation_data=test_data)
model.save('model/resnet_{}.h5'.format(data_name))

Can you please provide the full stack trace so we can debug this further? How many GPUs did you run this with?
Also can you test with the latest TF 2 nightly?
(For reference, I tried with the latest TF and not able to repro)

I ran with 4 GPUs. This thefull stack trace:
Epoch 1/50
22/22 - 78s - loss: 3.4754 - accuracy: 0.2224 - val_loss: 0.0000e+00 - val_accuracy: 0.0000e+00
Epoch 2/50
22/22 - 9s - loss: 2.1286 - accuracy: 0.3386
Traceback (most recent call last):
  File "simple.py", line 76, in <module>
    model.fit(train_data, epochs=50, verbose=2, validation_data=test_data)
  File "/home/soft/anaconda3/lib/python3.7/site-packages/tensorflow_core/python/keras/engine/training.py", line 728, in fit
    use_multiprocessing=use_multiprocessing)
  File "/home/soft/anaconda3/lib/python3.7/site-packages/tensorflow_core/python/keras/engine/training_v2.py", line 370, in fit
    total_epochs=1)
  File "/home/soft/anaconda3/lib/python3.7/site-packages/tensorflow_core/python/keras/engine/training_v2.py", line 123, in run_one_epoch
    batch_outs = execution_function(iterator)
  File "/home/soft/anaconda3/lib/python3.7/site-packages/tensorflow_core/python/keras/engine/training_v2_utils.py", line 86, in execution_function
    distributed_function(input_fn))
  File "/home/soft/anaconda3/lib/python3.7/site-packages/tensorflow_core/python/eager/def_function.py", line 457, in __call__
    result = self._call(*args, **kwds)
  File "/home/soft/anaconda3/lib/python3.7/site-packages/tensorflow_core/python/eager/def_function.py", line 494, in _call
    results = self._stateful_fn(*args, **kwds)
  File "/home/soft/anaconda3/lib/python3.7/site-packages/tensorflow_core/python/eager/function.py", line 1823, in __call__
    return graph_function._filtered_call(args, kwargs)  # pylint: disable=protected-access
  File "/home/soft/anaconda3/lib/python3.7/site-packages/tensorflow_core/python/eager/function.py", line 1141, in _filtered_call
    self.captured_inputs)
  File "/home/soft/anaconda3/lib/python3.7/site-packages/tensorflow_core/python/eager/function.py", line 1224, in _call_flat
    ctx, args, cancellation_manager=cancellation_manager)
  File "/home/soft/anaconda3/lib/python3.7/site-packages/tensorflow_core/python/eager/function.py", line 511, in call
    ctx=ctx)
  File "/home/soft/anaconda3/lib/python3.7/site-packages/tensorflow_core/python/eager/execute.py", line 67, in quick_execute
    six.raise_from(core._status_to_exception(e.code, message), None)
  File "<string>", line 3, in raise_from
tensorflow.python.framework.errors_impl.CancelledError: 5 root error(s) found.
  (0) Cancelled:  Operation was cancelled
	 [[{{node cond_7/else/_70/IteratorGetNext}}]]
  (1) Out of range:  End of sequence
	 [[{{node cond_6/else/_59/IteratorGetNext}}]]
	 [[replica_3/metrics/accuracy/AssignAddVariableOp_1/_103]]
  (2) Out of range:  End of sequence
	 [[{{node cond_5/else/_48/IteratorGetNext}}]]
  (3) Out of range:  End of sequence
	 [[{{node cond_6/else/_59/IteratorGetNext}}]]
	 [[metrics/accuracy/div_no_nan/ReadVariableOp_4/_150]]
  (4) Out of range:  End of sequence
	 [[{{node cond_6/else/_59/IteratorGetNext}}]]
0 successful operations.
0 derived errors ignored. [Op:__inference_distributed_function_83325]

Function call stack:
distributed_function -> distributed_function -> distributed_function -> distributed_function -> distributed_function

I will try tf-nightly later.

@guptapriya I can not repro for tf-nightly-gpu. But for tensorflow-gpu-2.0 I reproduce the error every time. Is this a bug of tensorflow2.0?

@honeytidy that's possible, we've fixed a number of issues since TF 2.0 branch was cut.


Mark members as public / private

I've never consciously decided which members should be publicly accessible and which shouldn't. De facto this means all members are accessible and changing the names of these members or their signatures may theoretically break someone's code. Even if these members were never meant to be used directly.
It needs to be made explicit what can be accessed publicly.
HOW

use private to hide member. This will cause the bundler to mangle the names of those members. Causing code to break.
log a deprecation warning. Doesn't break anyone's code. But means we're kicking the can down the road

Which members?

since the constructor options are obviously pubic, it makes sense to also make their accompanying properties public
these also must be public:

init
render
processGCode
clear
_readFromStream
resize

Can we safely make everything else private?
Can we make the parser private?

Some of this was done as part of #154 to get the API docs in a decent state.
Apparently this ticket isn't as much of a breaking change as I thought. Adding a lot of private modifiers didn't cause the generated files in dist to be changed.
This means we can just tweak it as part of the docs as we go. And since this ticket isn't well scoped anyway I'll close it :-)


The order of  output data for basis with higher angular

In libcint's program_ref, it shows for Cartesian GTO with d angular output data is sorted as xx, xy, xz, yy, yz, zz. I want to know how the output data in buf are sorted for Cartesian GTO and real spheric GTO with higher angular momentum as f and g.  Thank you.

For cartesian AO, it's quite simple to know with this example
from pyscf import gto

mol = gto.M(atom='Au .0 .0 0', basis='def2-tzvp', spin=1, cart=True).build()

for i,a in enumerate(mol.ao_labels()):
    print(i,a)

For spheric ones, setting cart=False will give an order like f-3, f-2, f-1, f0, f1, .... Hope this is what you want, since some other programs also use this notation.


Rc/syncautomata

I've prepared the apps for checking the synchronization of DFAs. The version is based on the current master. I've also included all changes (hope that are all :) that we discussed in the morning. The last version seems to be OK, at least I haven't seen any runtime error.
If you hesitate to merge all changes you can, at least, include changes on DLTSProduct and related tests.

These two new commits makes the application runnable on Salamon. The crucial fix is in the last commit. The APP(RF) is only a cosmetic change.


Content was splited when set mode avoid-all

Here is the output style:

Here is the configure:
get w or h from the element of react useMeasure
  const opt = {
    filename: `${name}-${moment().format('YYYYMMDDHHmmss')}.pdf`,
    margin: 80,
    image: { type: 'jpeg', quality: 1 },
    html2canvas: {
      useCORS: true,
      allowTaint: true,
      scale: 3,
      width: w+160,
      height: h,
    },
    pagebreak: { mode: 'avoid-all' },
    jsPDF: {
      unit: 'px',
      format: 'a4',
      orientation: 'portrait',
    },
  };

you can modify jsPDF options as below:
jsPDF: {       unit: 'pt',       format: 'a4',       orientation: 'portrait',     },
and if you don't want to split some elements , you can add container to wrap them.

you can modify jsPDF options as below: jsPDF: { unit: 'pt', format: 'a4', orientation: 'portrait', }, and if you don't want to split some elements , you can add container to wrap them.

I'm also interested in getting this to work. What do you mean by container? A div?


Feat upgrader framework

This PR is trying to add the upgrader framework to AM https://gravitee.slab.com/posts/upgraders-d2r8w0uf
It will provide similar code base for running upgraders in all products.
Related PR: https://github.com/gravitee-io/helm-charts/pull/226

I have to give a closer look and see how Upgraders work at gio-node level but for now, I wondering why the webauthn.auth.js has been updated?

I don't know why this commit was included because I pushed it with the latest things from master but anyway, I just removed it for the PR


Can't use auto-completion for client attributes

For example, if you type client.place, then the IDE should remind you with all the params in the Endpoint of place.

Hey Jay,
Thanks for reaching out.
This is actually something I wanted to do from the begining! But I was having problem figuring out how to change the signatures of returned functions.  Do you have any suggestions on how to achieve this?
I will definitely go back to it and try to figure it out. In the mean time, the kwargs should be documented in the doc string already though it's not ideal as a proper auto-completion.
Cheers

closing stagnant discussion. Feel free to re-open


Verify the gas limit is within the system configured limits

In the pallet-evm runner, if a max_extrinsic has been set for the runtime BlockWeights, we need to make sure the requested gas limit does not go above the configured value.

Isn't this already handled by the dispatchable declarations? https://github.com/paritytech/frontier/blob/master/frame/evm/src/lib.rs#L174

Indeed, you're right. Closing.


Use banner text from dataflow-server-core

Remove existing banner and include banner.txt from POM
Update to use dataflow-server snapshot
Update name to use in MANIFEST

This depends on https://github.com/spring-cloud/spring-cloud-dataflow/pull/1033

This need to wait as RC1, afaik, will go with SCDF 1.1.0.RC1.

Btw, why would we do this. Now banner will have text Data Flow Server for Apache Yarn 1.1.0.BUILD-SNAPSHOT (or whatever version is build). Yarn and SCDF core may have different versions. I makes much more sense to use server impl version rather than SCDF core version.

Ah, right, now I looked that other PR.

Squashed and fixed merge per https://github.com/spring-cloud/spring-cloud-dataflow-server-yarn/commit/896e37a11906d061823571d29a76832ac13dedca


FieldCustomizer not working in 1.3.2

Thank you for reporting an issue or suggesting an enhancement. We appreciate your feedback - to help the team to understand your needs, please complete the below template to ensure we have the necessary details to assist you.
Category

[ ] Question
[ ] Typo
[x ] Bug
[ ] Additional article idea

If you are planning to share a new feature request (enhancement / suggestion), please use SP Dev UserVoice at http://aka.ms/sp-dev-uservoice.

Expected or Desired Behavior
Using versions

generator-sharepoint 1.3.2
gulp 3.9.1
npm 4.6.1
yarn 1.1
yo 2.0.0

I create a simple project, accept all defaults, gulp serve --nobrowser, and I expect to see the field customizer to render. It doesn't seem to "kick in".
I have recorded a video to repro the steps
https://www.youtube.com/watch?v=xDb5W4qGGwM
Observed Behavior
I expected to see the percentage field update. But I see no changes.
Steps to Reproduce
I have recorded a video to repro the steps
https://www.youtube.com/watch?v=xDb5W4qGGwM

Hi @maliksahil
From the video I see that on the URL you treat the field name as "Percent", but in the column name is "Percentage". Could you double check whether you are using the same internal name?
If the string from the URL query parameter doesn't match with any column, this is the expected behavior.

That was it .. and I also had a bug in my JSON format. Working fine now in both classic and modern sites. Thanks for your help!


Output control plane ip as ingress

This feature existed but somehow got lost in refactoring

Yes! Thanks, @captnCC.


Don't set data-semantic attributes yourself (these are generated by SRE)

You should not set data-semantic attributes yourself, as they are maintained by SRE.  So
https://github.com/limefrogyank/siunitx-pcc/blob/51e6c1e4d8e9429ee7451ffe2176db45501f6dbf/src/siunitx.ts#L111
should not include the attributes list.

This might have been before I understood the difference between mathspeak and clearspeak.  Not sure why I did this...


Added changeScene API

This is to address the many topics for switching scene in PlayCanvas. The page and helper script I wrote doesn't seem to be enough https://developer.playcanvas.com/en/user-manual/packs/loading-scenes/
So I'm adding the most common use case to the API.
I'm split on the first param though.
With loadSceneHierarchy, the first param is either the URL or SceneRegistryItem of the scene to load and this has been kept for backwards compatibility.
However, for ease, I would like it to have be the scene name or SceneRegistryItem as using the URL is not user friendly and by using the scene name, it saves the user from having to search for the SceneRegistryItem themselves.
Changing scenes becomes a one liner with this change:
this.app.scenes.changeScene('name of scene');

I confirm I have read the contributing guidelines and signed the Contributor License Agreement.

Project to test this PR with : https://playcanvas.com/project/979499

Right now in SceneRegistry#_loadSceneData there is this code:
        let url = sceneItem;

        if (sceneItem instanceof SceneRegistryItem) {
            url = sceneItem.url;
        } else {
            sceneItem = this.findByUrl(url);
            if (!sceneItem) {
                sceneItem = new SceneRegistryItem('Untitled', url);
            }
        }

It could be shortened into this code:
        let url = sceneItem;
        if (typeof sceneItem === 'string') {
            sceneItem = this.findByUrl(url) || this.find(url) || new SceneRegistryItem('Untitled', url);
        }
        url = sceneItem.url;

Then you can delete this code in SceneRegistry#changeCode aswell:
if (!(sceneItem instanceof SceneRegistryItem)) {
    sceneItem = this.find(sceneItem);
}

Overall it removes lines of code and SceneRegistry#changeCode would also accept URL's (and SceneRegistry#loadSceneData would also accept scene names).
I don't know if scene names and scene URL's could conflict though (in my little testing everything worked as it should and the unit tests are also happy).

Right now in SceneRegistry#_loadSceneData there is this code:
        let url = sceneItem;

        if (sceneItem instanceof SceneRegistryItem) {
            url = sceneItem.url;
        } else {
            sceneItem = this.findByUrl(url);
            if (!sceneItem) {
                sceneItem = new SceneRegistryItem('Untitled', url);
            }
        }

It could be shortened into this code:
        let url = sceneItem;
        if (typeof sceneItem === 'string') {
            sceneItem = this.findByUrl(url) || this.find(url) || new SceneRegistryItem('Untitled', url);
        }
        url = sceneItem.url;

Then you can delete this code in SceneRegistry#changeCode aswell:
if (!(sceneItem instanceof SceneRegistryItem)) {
    sceneItem = this.find(sceneItem);
}

Overall it removes lines of code and SceneRegistry#changeCode would also accept URL's (and SceneRegistry#loadSceneData would also accept scene names).
I don't know if scene names and scene URL's could conflict though (in my little testing everything worked as it should and the unit tests are also happy).

I like the idea that loadScene* and changeScene can all take a name, URL or SceneRegistryItem and would make the loadScene* functions more flexible.
Any opinions from the rest of the engine team?

I've added @kungfooman's suggestion on being able to use the scene name and added a few more tests

Thank you for the changes @yaustar
Since SceneRegistry#changeScene is basically SceneRegistry#loadSceneHierarchy with a preface, it can be rewritten as exactly that to reduce quite some lines of code (and makes future rewrites easier I think too):
    changeScene(sceneItem, callback) {
        /**
         * This function is called before the new scene hierarchy is added.
         *
         * @param {SceneRegistryItem} sceneItem - The scene item
         */
        const preface = (sceneItem) => {
            const app = this._app;
            // Destroy/Remove all nodes on the app.root
            const rootChildren = app.root.children;
            while (rootChildren.length > 0) {
                const child = rootChildren[0];
                child.reparent(null);
                child.destroy?.();
            }
            app.applySceneSettings(sceneItem.data.settings);
        };
        this.loadSceneHierarchy(sceneItem, callback, preface);
    }

SceneRegistry#loadSceneHierarchy just needs to handle the preface:
    loadSceneHierarchy(sceneItem, callback, preface) {
        this._loadSceneData(sceneItem, false, (err, sceneItem) => {
            if (err) {
                if (callback) {
                    callback(err);
                }
                return;
            }
            if (preface) {
                preface(sceneItem);
            }
            this._addHierarchyToScene(sceneItem.url, sceneItem.data, callback);
        });
    }

Using arrow functions is reducing code size aswell, you don't need to worry about self (arrow functions inherit this and its fixed/unchangeable). Babel takes care to rewrite it into ES5:
	  _proto.changeScene = function changeScene(sceneItem, callback) {
	    var _this2 = this;

	    var preface = function preface(sceneItem) {
	      var app = _this2._app;
	      var rootChildren = app.root.children;

	      while (rootChildren.length > 0) {
	        var child = rootChildren[0];
	        child.reparent(null);
	        child.destroy == null ? void 0 : child.destroy();
	      }

	      app.applySceneSettings(sceneItem.data.settings);
	    };

	    this.loadSceneHierarchy(sceneItem, callback, preface);
	  };

I'm not keen on use the preface as loadSceneHierarchy is existing public API and traditionally, the callback is the last param

I kinda liked the idea because it would lead to more code reduction afterwards for SceneHierarchy#_addHierarchyToScene, since its basically just a stub for its inner function called _loaded, but I see your point 👍

We could create a new private function that does what you suggest I suppose? That way that preface is not exposed as public API nor changes the existing?

We could create a new private function that does what you suggest I suppose?

That sounds like a good idea and I just tested and it works:
    loadSceneHierarchy(sceneItem, callback) {
        this._loadSceneHierarchy(sceneItem, callback);
    }
    _loadSceneHierarchy(sceneItem, callback, preface) {
        this._loadSceneData(sceneItem, false, (err, sceneItem) => {
            if (err) {
                if (callback) {
                    callback(err);
                }
                return;
            }
            if (preface) {
                preface(sceneItem);
            }
            this._addHierarchyToScene(sceneItem.url, sceneItem.data, callback);
        });
    }

And then you can just use this private method in SceneRegistry#changeScene

I've made the changes to DRY but it feels off as it's adding some complexity for a few extra lines 🤔

I am running into an issue loading SeeMore as non-trivial scene and for some reason it doesn't destroy the old camera:

(one camera rendering over the other)
I can fix it by adding this to your onBeforeAddHierarchy():
app.scene?._activeCamera?.node?.destroy();

But I don't understand it, shouldn't the camera be in app.root anyway or what else is required to completely destroy a scene?

I am running into an issue loading SeeMore as non-trivial scene and for some reason it doesn't destroy the old camera:

(one camera rendering over the other)
I can fix it by adding this to your onBeforeAddHierarchy():
app.scene?._activeCamera?.node?.destroy();

But I don't understand it, shouldn't the camera be in app.root anyway or what else is required to completely destroy a scene?

That's old, there's no scenes in that project

Testing with a Seemore fork with changing scenes with the existing stable engine and the double render is there too: https://playcanvas.com/project/983477/overview/f-seemore

Edit: I just tried it with my branch and can't reproduce your issue?

Thank you for testing, I downloaded SeeMore in 2019 but I also just tested the last version and it has the same issue.

Open https://playcanv.as/p/MflWvdTW/
Get both cameras: cams = pc.app.root.find("name", "Camera");
Delete as you do in this PR:

const rootChildren = pc.root.children;
while (rootChildren.length > 0) {
    const child = rootChildren[0];
    child.reparent(null);
    child.destroy?.();
}

It still renders skybox for you too?

The first cam seems to "survive" 🧟

Edit: I just tried it with my branch and can't reproduce your issue?

Thank you for testing, I downloaded SeeMore in 2019 but I also just tested the last version and it has the same issue.

Open https://playcanv.as/p/MflWvdTW/
Get both cameras: cams = pc.app.root.find("name", "Camera");
Delete as you do in this PR:

const rootChildren = pc.root.children;
while (rootChildren.length > 0) {
    const child = rootChildren[0];
    child.reparent(null);
    child.destroy?.();
}

It still renders skybox for you too?

The first cam seems to "survive" 🧟

I tried this with engine 1.56.0 (current stable) and loadSceneSettings + Hierarchy methods and the issue is there too.
This means it's not a new issue that this PR introduces

I am also not quite happy with onBeforeAddHierarchy and I realized that we basically just need an event...
The first step would be to move your scene clearing code into class Scene (where it imo belongs). Since Scene already extends EventHandler, we have events without any changes.
New method for src/scene/scene.js:
    clear() {
        this.fire("clear");
        const app = getApplication();
        // Destroy/Remove all nodes on the app.root
        const rootChildren = app.root.children;
        while (rootChildren.length > 0) {
            const child = rootChildren[0];
            child.reparent(null);
            child.destroy?.();
        }
        this?._activeCamera?.node?.destroy();
    }

(the last line with _activeCamera fixes the SeeMore issue/bug, until someone comes up with a better solution)
The SceneRegistry#changeScene turns into:
    changeScene(sceneItem, callback) {
        const app = this._app;
        app.scene.once("beforeAddHierarchy", (sceneItem) => {
            app.scene.clear();
            app.applySceneSettings(sceneItem.data.settings);
        });
        this.loadSceneHierarchy(sceneItem, callback);
    }

onBeforeAddHierarchy is completely removed and you can remove that extra private method.
Finally, in loadSceneHierarchy, instead of:
            if (onBeforeAddHierarchy) {
                onBeforeAddHierarchy(sceneItem);
            }

            const app = this._app;

We simply have to fire the event while passing sceneItem:
            const app = this._app;
            app.scene.fire("beforeAddHierarchy", sceneItem);

I would not use _activeCamera at all .. I want to remove it from code base, as it's just a hack added by particle system rendering. I'm not entirely what this is trying to solve, but it should be done differently.

I would not use _activeCamera at all ..

Yes, I can imagine that, for testing I just needed a way to clear the entire scene, since deleting only app.root.children still retains one camera. I don't know why, just that it can be deleted by that _activeCamera line. Do you have an idea how to fix this?

I'm less keen to add an event into a system that hasn't used them before. It feels a bit overkill and would like to put a pin in it here for team review.
In regards to Seemore, I will create a new ticket to investigate as that's odd but not introduced by this PR. Maybe due to th use of zones or portals?

It's really strange the Camera component survives the scene hierarchy getting deleted. There must be some code re-adding it or similar?
If you have a repro, it'd be interesting to trace layer composition:
pc.Tracing.set(pc.TRACEID_RENDER_ACTION, true);
at the point the hierarchy is deleted, I'd expect this to print no render actions - meaning no cameras are in the scene.


:bug: article.showEdit  is true in config file when defaults should be false

Describe the bug
I noticed that the edit button is present on articles on my site even though I didn't enable this. In the documentation for configuration it indicates that article.showEdit defaults to false however in this code I am seeing it set to true.
To Reproduce
Steps to reproduce the behavior:
Create a new project and create a post. View the post and the edit button should be present without any changes to configuration.
Expected behavior
I would expect the edit button not to be shown since it should be false by default.

@nunocoracao this was fixed in #490 . I think you can close this one


enemies("enemy name").stats() returns undefined?

const gdb = require("genshin-db")

console.log(gdb.enemies("Anemo Samachurl").stats())

logs undefined so I tried checking if the enemy exists console.log(gdb.enemies("Anemo Samachurl")) and it logged a enemy object. I am using version<EMAIL_ADDRESS>

You need to pass in the level of the enemy.
gdb.enemies("Anemo Sama").stats(90)

@theBowja oh, tho did u forget to add the type into the .d.ts file? cuz stats() doesn't show up as a suggestion

ah you're right i forgot to add the type. my bad. i'll add that next version


feat: Add CommandInput

Add the new type CommandInput. This type supports serde and clap (using FromStr) and is supposed to be used where users need to specify commands which are to be executed.
There are 3 ways to define commands (here TOML is used):

as one string: command = "echo test"
as command and args as string array: command = {command = "echo", args = ["test1", "test2"] }
additionally specify error treatment:  command = {command = "echo", args = ["test1", "test2"], on_failure = "ignore" }

In the first example the full command and the args are split using shell_words which requires special escaping or quoting when spaces are contained. In the other examples every string is taken literally as given (but TOML escapes may apply when parsing TOML).
This PR only adds the new type, using it on existing commands will be a breaking change.

@nardoor thanks a lot for the review and the very valuable suggestions!
I changed basically all as you suggested and think this is ready for a re-review.
The only question I have is about the naming of on_failure - maybe on_error is a better name, what do you think?

@nardoor thanks a lot for the review and the very valuable suggestions!
I changed basically all as you suggested and think this is ready for a re-review.
The only question I have is about the naming of on_failure - maybe on_error is a better name, what do you think?

I feel like on_failure is fine, as it has a broader meaning.
I'm glad you found my comments useful. I'll look at your changes tomorrow!


Programming mode: Add addtional-labels to jobs pod specs

Hello again!
I've been playing around with the programming mode, having lots of fun so far!
This PR modifies the generation of the pod template to include the optional additional-labels property to the job definition.
The reasons are the same as in PR #55
jobs:
  mem-attack:
    image: docker.io/luckysideburn/kubeinvaders-stress-ng:latest
    command: "stress-ng"
    additional-labels:
      test-label: "test"
    args:
      - --help

which would generate a job with a pod template like:
INFO:root:pod_template = {'metadata': {'annotations': None,
              'creation_timestamp': None,
              'deletion_grace_period_seconds': None,
              'deletion_timestamp': None,
              'finalizers': None,
              'generate_name': None,
              'generation': None,
              'labels': {'app': 'kubeinvaders',
                         'approle': 'chaosnode',
                         'pod_name': 'mem-attack-exp',
                         'test-label': 'test'},
              'managed_fields': None,
              'name': 'mem-attack-exp',
              'namespace': None,
              'owner_references': None,
              'resource_version': None,

Thanks again for all your work!

Wow @ruben-rodriguez thank you very much! I really needed some contributions like this!
I think it is a good feature and I will merge it!
the programming mode is the feature that can be to this project more seriuous aspect.  I am planning to add to the yaml also a parameters for checking URLs during experiment in order to have in one single dashboard for show how latency of services change during che chaos session.

Hi @ruben-rodriguez, I added https://github.com/lucky-sideburn/KubeInvaders/commit/d1f95f6023442f9179414fd11dfcd8721dee70b6 for showing additional label in the example chaos problem on web interface. Thanks! I just pushed new changes to the docker image v.1.9.5

Great! I'm glad you liked it! Happy to contribute, and thanks for the heads up! 🚀


Sum of Cubes

Title of article
Write a Java programme to find sum of cubes of first n natural numbers.
Additional information
1^3 + 2^3 + 3^3 + ... + n^3

Code of Conduct

[X] I have read and agree to the Codinasion project's Code of Conduct

Hey, Where can I add the code so I can create PR ?

Hii @NeelPatel31
Thanks for showing your interest in this open source project 😃
Please follow these steps :-

fork this repo
create a new branch
create a programme folder (if not already created)
create sum-of-cubes folder
add the solution.java
open a pull request

done !!!
For more info, please see the contributing guide


Make all OOM errors fatal in couchjs

Overview

Testing recommendations

Related Issues or Pull Requests

Checklist

[ ] Code is written and works correctly
[ ] Changes are covered by tests
[ ] Any new configurable parameters are documented in rel/overlay/etc/default.ini
[ ] A PR for documentation changes has been made in https://github.com/apache/couchdb-documentation

Derps. We can't do this as it'd be backwards incompatible with views that would otherwise have built. With this change we'd end up stuck on a doc that caused it.


Add a default locale setting

Fixed in 0f1f2ce9b1c80. I've decided to hold off on implementing analogous defaults for outputCalendar and numberingSystem because they're somewhat more painful to implement.


721 rich editor

Description
Please provide a summary of the pull request and the issue it fixes. Please add necessary details, context, dependencies, explanation of when review is needed (see next section), etc.
Fixes #(add issue number here and remove parentheses)
Review Time Estimate
Please give your idea of how soon this pull request needs to be reviewed by selecting one of the options below. This can be based on the criticality of the issue at hand and/or other relevant factors.

[ ] Immediately
[ ] Within a week
[ ] When possible

Type of changes
Please select a relevant option:

[ ] Bug fix (non-breaking change which fixes an issue).
[ ] New feature (non-breaking change which adds functionality).
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected).
[ ] Other (any another change that does not fall in one of the above categories.)

Checklist:
Please select all applicable options:

[ ] I have signed the Rokwire Contributor License Agreement (CLA). (Any contributor who is not an employee of the University of Illinois whose official duties include contributing to the Rokwire software, or who is not paid by the Rokwire project, needs to sign the CLA before their contribution can be accepted.)
[ ] I have updated the CHANGELOG.
[ ] I have read the Contributor Guidelines.
[ ] I have performed a self-review of my own code.
[ ] I have commented my code, particularly in hard-to-understand areas.
[ ] My change requires updating the documentation.
[ ] I have made necessary changes to the documentation.
[ ] I have added tests related to my changes.
[ ] My changes generate no new warnings.
[ ] New and existing unit tests pass locally with my changes.
[ ] Any dependent changes have been merged and published in downstream modules.

The heading 2 option is also making the text center-aligned. Please fix this. Thanks.

Save button is staying disabled even after adding a description. Please see the example below:

@bingzhang, you can remove the header tool from both add and edit pages. It looks like we will have to revisit that based on how the headers could appear in the Illinois app. Hopefully, that'll also remove some of the existing questions. Thanks.

Hi, @bingzhang,
There is a difference in the font size between Add and Edit modes. In the edit mode, the font size is much smaller. Please see the screenshots below:
Add page:

Edit page:

I have tested this PR in detail. The PR looks good except for the above issue. Please fix this. Thank you!


Fix some minor GUI issues with autocomplete

feedbackToUser.length() is always > 0?

Not necessary. feedbackToUser.length() > 0 indicates that there are suggestions for command names.


Default Magento 2.4.3-p1 demo store with sample data, Hyva 1.1.9. console errors Alpine

We get console errors and the multimenu is not working on mobile and malfunctions on desktop mode (submenu hover doesn't show level 3 menu). See attachment.

.

Is this in a clean 1.1.9 install on m2.4.3 ?
On Fri, 7 Jan 2022, 23:39 DHS Services, @.***> wrote:

We get console errors and the multimenu is not working on mobile and
malfunctions on desktop mode (submenu hover doesn't show level 3 menu). See
attachment.
[image: m243p1_hyva119_multimenu_console-errors]
https://user-images.githubusercontent.com/70269551/148567804-1992ce86-ac4f-4aff-a6ea-3aac6e9cbe90.JPG
.
—
Reply to this email directly, view it on GitHub
https://github.com/ProxiBlue/hyva-proxiblue-multimenu/issues/2, or
unsubscribe
https://github.com/notifications/unsubscribe-auth/ABGDJVHPBOTDO5O7S6DONUDUU4CMPANCNFSM5LPBQT5Q
.
Triage notifications on the go with GitHub Mobile for iOS
https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675
or Android
https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.
You are receiving this because you are subscribed to this thread.Message
ID: @.***>

Yes it is, but m2.4.3-p1

.

Thanks. Will do a clean install and see if i can reproduce.
On Sat, 8 Jan 2022, 00:46 DHS Services, @.***> wrote:

Yes it is, but m2.4.3-p1
[image: hyva-version]
https://user-images.githubusercontent.com/70269551/148577200-c4a3aaf1-1d85-4313-a137-50a64267cc65.JPG
.
—
Reply to this email directly, view it on GitHub
https://github.com/ProxiBlue/hyva-proxiblue-multimenu/issues/2#issuecomment-1007559803,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/ABGDJVCVUQ677R7XZZOZ5RLUU4KIDANCNFSM5LPBQT5Q
.
Triage notifications on the go with GitHub Mobile for iOS
https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675
or Android
https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.
You are receiving this because you commented.Message ID:
@.***>

Hello, I can reproduce this issue on a clean 2.4.3-p1 and clean 1.1.9 install.

The fact it works in my upgraded 1.1.9 is likely due to custom theme files in site theme.
I will produce an update to make this compatible again

Ok, so the reason this still works in my upgraded 1.1.9, is due to custom theme, and placement of header.phtml, which instantiates the menu object via alpine

Hello,
I have updated the code to make a new release 1.3.0 that is compatible with hyva 1.1.9 and teh split menu files.
Please update, ensuring you get version 1.3.x range of the module
Uploading Peek 2022-01-08 14-04.mp4…

Works like a charm! Thank you very much.

Great, I will close this ticket then.
PS: you will see an improvement I had done (over standard hyva menus) is that the menu is not populated 2 x in the DOM (which can be huge)
The menu data is copied between mobile and desktop menu containers when required, so it only occupies one section at a time, thus making for a lot smaller page load size.


docs: setup folder structure

BREAKING CHANGE: I was just trying to make double message separated by blank space

There are 3 files that were placed in the wrong folder.

.gitignore
LICENSE
README.md

Those files should be placed in the root directory, not in src. Move it then we all good
I think I didn't give you branch naming yet. So we will figure it out later on.

One more comment, you need to ignore dist folder


The excepthook hides errors completely on Windows

Basically what the title says, this particular issue has driven me nuts in the past few weeks as the anaconda tool stopped uploading from our CI server without any recognisable error message. I don't really see a need for overriding it, take responsibility for your exceptions :)

Ping?

Ping?


helm charts incubator - new location - broken index?

Hi guys
trying to update / install a chart from new location I got:
 message": "Error fetching helm URLs: [Error in HTTP GET of [https://charts.helm.sh/incubator/patroni-0.16.3.tgz], received: 404 Not Found]",

Looks like the same issue as in #24426 but for incubator instead of stable

This is a duplicate of #24426 and was fixed in https://github.com/helm/charts/pull/24430. If you're still getting this error, try helm repo update or delete and re-add the repo.

but it's not fixed. I checked the index just now
$ curl -s https://charts.helm.sh/incubator/index.yaml | grep patroni-0.16.3
    - https://charts.helm.sh/incubator/patroni-0.16.3.tgz

My mistake, you are correct. Let's fix this

@urmet please try again

incubator looks all fine now. But I did find 2 bad paths in stable index when I started looking.
$ curl -s https://charts.helm.sh/stable/index.yaml | grep tgz | grep -v "/packages/"
    - https://charts.helm.sh/stable/percona-1.2.2.tgz
    - https://charts.helm.sh/stable/percona-xtradb-cluster-1.0.7.tgz

not actually relevant to this issue and these two are not the newest versions of their charts, so really unlikely to be noticed by users.

Thanks @urmet, closing this issue. Linked a PR to fix those, and thanked you there.

thank you guys! remove and readd repo helped then.


Removing non-root entities (inside parent)

Noticed this error when trying to use the ``UserInterface.Active.RemoveEntitymethod on an entity with a parent. It works on entities at the root level:GeonBit.UI.Exceptions.InvalidStateException: 'Child element to remove does not belong to this entity!'```
What's the canonical way to remove entities inside a parent? Do you really heave to remove it from the parent first?

I think the canonical way to remove an item is to call .RemoveChild from the parent entity. Is it right? I thought it really means detaching it from the parent but I think it means really deleting it.

Not sure what you did there but the error is saying you are trying to remove an element from a parent, but the element is not a child of it.
Ie you can't do:
panel.RemoveChild(element);

unless you call
panel.AddChild(element);

first.
Regarding your second question - not sure what you mean - removing is just detaching you can do
panel.AddChild(elem);
panel.RemoveChild(elem);
panel.AddChild(elem);

As many times as you like and the element will end up working fine. You can ofc add it to other elements as well.
If you have any code to illustrate a bug in that mechanism please post it, meanwhile I'm closing.

'Remove' in c# just mean Remove, same as in geonbit.ui (for example see Remove behavior of the built-in c# collections - its all the same). And you don't really 'delete' objects in c#, they are managed by the GC.

Aha I see. It's very convenient. Thank you!


doc(k8s-operator): document customizing enabled auto-instrumentations for nodejs with kubernetes-operator

The change
Current documentation states that it isn't possible to disable specific nodejs auto-instrumentation packages when using kubernetes-operator, but that isn't true after next kubernetes operator release, that allows enabling instrumentations based on OTEL_NODE_ENABLED_INSTRUMENTATIONS environment variable.
Draft PR: waiting for release of merged PR
This documentation change is caused by feature enabled by merged PR
that currently isn't released (hence the DRAFT status of this PR),
and another PR that built the foundation for it.

@atsu85 any updates, can you take a look at my feedback? feel free to ask questions if you are unsure how to proceed

can you take a look at my feedback?

@svrnm, sorry for noticing this so late and thanks for the feedback.
Please take a look, I hope my solution is OK.

FYI: amended commits to fix linting errors (only includes changes done by npm run fix:format)

I saw that Spelling check action was failing, because of  nestjs in the link title:

so I replaced it with @opentelemetry/instrumentation-express, in hope that it shouldn't fail spell check action and rebased&squashed it on top of latest main branch

Thank you @atsu85


add image for code output for all Python Guide getting started page

Getting started page

Wouldn't it be necessary to crop the images @techemmy ?

Could you switch to a light theme please as the rest of the screenshots?

Oh, Light theme. I will switch it to light mode.

Wouldn't it be necessary to crop the images @techemmy ?

@ndonkoHenri The pictures are cropped.

@FeodorFitsner I also converted images for interactive code to gifs for a better experience. What do you think?

Merge and published in a separate branch that can be seen here: https://more-screenshots.flet-website.pages.dev/docs/guides/python/getting-started
Imho pics look bulky. Could be more compact, don't you think? And if it's just "Hello, world" in a window you can resize it down to avoid huge white space. Look for the example here: https://more-screenshots.flet-website.pages.dev/docs/
And if you are making a screenshot of a window on Mac please do not cut shadow arround the window - it loses its macOS charm and smoothness without a shadown ;) Example here: https://more-screenshots.flet-website.pages.dev/docs/

Oh, got it. I couldn't find a way of recording videos for gif on macOS without having to cut around its window. Please, do you know any?

I think we could be OK with static images.

Alright. Then, I'll update the gifs back to static images.


feat(autocrud): Add id,style,className properties to AutoCrud and AutoForm

Add id,style,className properties to AutoCrud and AutoForm
Fixes #1640

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.


Main program is not terminating if the package is pulled from the central for the first time

Description:
If the java.jdbc module is not present in the local repository the program is not exiting after the execution.
Steps to reproduce:

If the module is in the local repository delete it ( can use the cmd rm -rf ~/.ballerina/repositories/central.ballerina.io/bala/ballerinax/java.jdbc)
Run the below program and it will download the module to the local repo and run. But you will see the program is not exiting after the execution.

import ballerinax/java.jdbc;
import ballerina/io;

public function main() returns error? {
    // Initializes the JDBC client.
    jdbc:Client jdbcClient = check new ("jdbc:h2:file:./dbdir2/bbes/java_jdbc",
        "rootUser", "rootPass");
    check jdbcClient.close();
    io:println("After client close");
}

If you run the program again, it is exiting after the execution. (Now the java.jdbc module is available in the local repository)

Refer to the video for more details.
https://user-images.githubusercontent.com/16300038/141365849-123ee444-64b1-4b13-bdb8-cfc201b268e3.mov
Affected Versions:
Ballerina Swan Lake Beta 3
Language specification 2021R1
Update Tool 1.3.6

Checked in beta4 and couldn't not reproduce in beta4. hence closing the issue.


Fix memory leak caused by KafkaEntryFormatter#encode

Fixes #303
The KafkaEntryFormatter#encode will cause memory leak because the Netty ByteBuf wrapper of MemoryRecords' internal ByteBuffer won't be released.

@dockerzhang PTAL and try to reproduce again.

@dockerzhang PTAL and try to reproduce again.


StoreCode from Cookies

User Story
As a user, I want to see products in the preferrable currency
Description & Motivation
Users shall be able to switch currency for the same page path. So that can give a correct overview of products in a preferable way.
Deliverables
MagentoGraphqlClientImpl class shall be extended to support special cookie param for determining store code.
Inside the initModel method check if the cookie param is there. If it is valid then use it otherwise go with the default steps (getCustomHttpHeaders or readFallBackConfiguration).
It shall be configurable in order to make it flexible and secure. MagentoGraphqlClientImpl configuration shall have the following parameters:

Allow store code definition via cookies (checkbox)
Store code cookie param name (default value "store")
Allowed store codes (an array of allowed store codes)

Acceptance Criteria

Store code can be changed via cookie parameter if it is defined in the MagentoGraphqlClientImpl configuration if it is enabled and defined in the list of allowed store codes.

This functionality is already possible today without cookie. The store code for GraphQL class is send via HTTP header, see https://devdocs.magento.com/guides/v2.4/graphql/send-request.html.
To use multiple stores with Magento and also allow users switching between them the typical AEM approach us to setup MSM site structures in AEM. See docs for details.

Hey!
We can not use the MSM approach exactly for this case because links for such pages are used around the world.
It's true that the StoreCode param is sent via header but MagentoGraphqlClientImpl returns an immutable map and the original list of params can not be changed. It can not be changed even via java reflection (probably because the class loader from our bundle is different).

Hey guys, any updates?


Make CD pipeline work based on GitHub tags

As a release manager, I want to trigger a Github action to deploy a version of FAM based on a release tag in the repository (not a branch)
Additional Context
Currently, the flyway lambda function is passed information about the github branch that is being deployed. When the lambda is run, this github context is passed as parameters to the execution call. The lambda function downloads the repo (at the correct branch) to get the scripts. When we deploy from a tag, the lambda function code (not our code) gets confused and can't download the repo.
Acceptance Criteria

[ ] Make a new S3 bucket in the infrastructure. Upload the flyway sql scripts to the bucket before running flyway
[ ] Run flyway with an S3 configuration (instead of a github configuration). Will require permissions in AWS

Definition of Done

[ ] Ready to Demo in Sprint Review
[ ] Does what I have made have appropriate test coverage?
[ ] Documentation and/or scientific documentation exists and can be found
[ ] Peer Reviewed by 2 people on the team
[ ] Manual testing of all PRs in Dev and Prod
[ ] Merged

Duplicate as #438


APK can not upload to google play when set target SDK to 30

Godot version:

3.2.3
OS/device including version:

Issue description:

You uploaded an APK with an invalid signature (learn more about signing). Error from apksigner: ERROR: MIN_SIG_SCHEME_FOR_TARGET_SDK_NOT_MET: Target SDK version 30 requires a minimum of signature scheme v2; the APK is not signed with this or a later signature scheme
Steps to reproduce:
Minimal reproduction project:

cc @m4gr3d

So this should already be resolved for custom build on Godot 3.2.4. @alexzheng Can you check with the latest beta for Godot 3.2.4 after enabling custom build and check that the generated apk is properly signed?
The issue remains however for users that wants to use the prebuilt apk without relying on custom builds.
For that scenario, it should be feasible to resolve the issue by replacing jarsigner in the Android export logic with apksigner. That change will also affect how signing is done for the prebuilt apk.

However, in 3.2.4 beta, after enable custom build and install the android build template, set the export format to Export APK,  all of my projects just crash when run on Android devices,  the logcat message shows:

12-23 17:00:07.988 11928 11928 F DEBUG   : Build fingerprint: 'Xiaomi/chiron/chiron:9/PKQ1.190118.001/V<IP_ADDRESS>.PDEMIXM:user/release-keys'
12-23 17:00:07.988 11928 11928 F DEBUG   : Revision: '0'
12-23 17:00:07.988 11928 11928 F DEBUG   : ABI: 'arm64'
12-23 17:00:07.988 11928 11928 F DEBUG   : pid: 11841, tid: 11897, name: GLThread 60525  >>> com.xunyougame.puzzlesgame <<<
12-23 17:00:07.988 11928 11928 F DEBUG   : signal 6 (SIGABRT), code -6 (SI_TKILL), fault addr --------
12-23 17:00:07.988 11928 11928 F DEBUG   : Abort message: 'java_vm_ext.cc:542] JNI DETECTED ERROR IN APPLICATION: can't call java.lang.ClassLoader android.content.ContextWrapper.getClassLoader() on instance of org.godotengine.godot.Godot'

@alexzheng That's expected behavior. The Godot class no longer extends the Activity class, and so you need to check your code for usage of getClassLoader() and make sure they're being called from an activity reference instead of a Godot reference.

I did not call getClassLoader in my code, I only used the admob module :
https://github.com/kloder-games/godot-admob

@alexzheng Looking at the code, it's an actual bug resulting from forgetting to migrate the old java modules logic when the update to the Godot class was done.
I'll provide a PR to fix the getClassLoader() issue.

I can confirm the getClassLoader issue have fixed by this PR.
Since there are other issues in 3.2.4 beta, I have not uploaded an APK file build by 3.2.4 yet, I can not confirm this issue.


TypeError: Cannot create property 'rules' on string 'SyntaxError'

This Liquid-Markdown file causes vscode-remark to crash with the following error message when I try to format the file in VS Code:

TypeError: Cannot create property 'rules' on string 'SyntaxError'

It would be good to know where the syntax error occurs so it could be fixed in the document. Even better would be for vscode-remark to handle formatting of the Markdown document without any problems.

Even just selecting the following list in the same Markdown document and doing "Format Selection" leads to the same error:
* When initiating a `Purchase` payment order, you need to make sure that the
  field `generateRecurrenceToken` is set to `true`. This recurrence token
  will stored in the [authorization transaction][transaction]
  sub-resource on the underlying payment resource.
* When initiating a `Verify` payment order, a recurrence token will be generated
  automatically. This recurrence token is stored in the
  [verification][verification-transaction]  sub-resource on the underlying
  payment resource.

I may have figured out what's going on here. Creating a .remarkrc.yml file seems to consistently produce this error. Might it be the case that vscode-remark tries to parse .remarkrc.yml as JSON?

Yep, seems like '**/*remarkrc*' is always parsed as JSON:
https://github.com/mrmlnc/vscode-remark/blob/fad8495e238ad2d3f312733ca09049761862f960/src/extension.ts#L61-L67
Since SyntaxError is returned here instead of actually throwing an error, SyntaxError is treated as valid config by whichever method is calling getWorkspaceConfig which is pretty poor form. I see a lot of } catch (err) { return 'SyntaxError'; } around in the codebase, which is not only swallowing the problem and making it impossible to figure out what the actual probelm is, but it makes the vscode-remark codebase think that everything is okay and merrily continue attempting to use 'SyntaxProblem' as a valid object of the type that was supposed to be returned.
Sorry, but this is pretty bad. While parsing .remarkrc.yml as YAML would fix my issue, I think the whole codebase needs a revision to stop swallowing errors and returning strings as though they were valid objects. Why are those catch statements there in the first place? Can't the errors just bubble up to VS Code so they can be displayed in the console?


How KONG connect to remote postgres

How KONG connect to remote postgres?
write the KONG_PG_HOST like
postgres://user:pass@ipaddress:port ?

It connects through TCP. pg_host should only be the host (or ip address) of your server.

@thibaultcha
I have connect it by these Environment
docker run -d --name kong \
              -e "KONG_DATABASE=postgres" \
	      -e "KONG_PG_USER=kong" \
	      -e "KONG_PG_PASSWORD=kong" \
	      -e "KONG_PG_DATABASE=kong" \
              -e "KONG_PG_HOST=<IP_ADDRESS>" \
              -e "KONG_PG_PORT=5432" \
              -p 8000:8000 \
              -p 8443:8443 \
              -p 8001:8001 \
              -p 7946:7946 \
              -p 7946:7946/udp \
              kong

suggest that these Environments should be write clearly in the readme.md

I think it's clear enough in the config file.

ok,thank you


pass credentials with ajax requests

The  latest UI's ajax wrapper miss xhr.withCredentials = true

Hi @vixns,
Can you confirm the version you are using (hit g v in the UI to see an alert with the UI version) please?
Also, does this prevent HTTP Basic Auth from working or is there some other effect?

I just tested the latest UI (0.15.0-SNAPSHOT) with http basic auth turned on and it worked as expected, so I'm not sure what functionality is breaking here.

I am using marathon Version 0.14.0-SNAPSHOT with latest UI (0.15.0-SNAPSHOT), the auth/authorization plugins from https://github.com/mesosphere/marathon-example-plugins updated with latest plugin interface (0.14.0-SNAPSHOT) and https.
The Authorization header is present in the main request, but not the ajax ones.
All ajax requests return 401 http codes, because Authorization header is missing
xhr.withCredentials = true should fix this

Ah, I understand then. Thanks for the PR!


[CESKATELEVIZE.CZ] ČT still doesn't work after the 2018.07.21 release

Please follow the guide below

You will be asked some questions and requested to provide some information, please read them carefully and answer honestly
Put an x into all the boxes [ ] relevant to your issue (like this: [x])
Use the Preview tab to see what your issue will actually look like

Make sure you are using the latest version: run youtube-dl --version and ensure your version is 2018.07.21. If it's not, read this FAQ entry and update. Issues with outdated version will be rejected.

[x] I've verified and I assure that I'm running youtube-dl 2018.07.21

Before submitting an issue make sure you have:

[x] At least skimmed through the README, most notably the FAQ and BUGS sections
[x] Searched the bugtracker for similar issues including closed ones
[ ] Checked that provided video/audio/playlist URLs (if any) are alive and playable in a browser

What is the purpose of your issue?

[x] Bug report (encountered problems with youtube-dl)
[ ] Site support request (request for adding support for a new site)
[ ] Feature request (request for a new functionality)
[ ] Question
[ ] Other

The following sections concretize particular purposed issues, you can erase any section (the contents between triple ---) not applicable to your issue

`D:\MOVIE>youtube-dl -U
youtube-dl is up-to-date (2018.07.21)
D:\MOVIE>youtube-dl --no-check-certificate https://www.ceskatelevize.cz/ivysilani/898281-arabela/280350950200005-arabela-na-uteku
[CeskaTelevize]<PHONE_NUMBER>00005-arabela-na-uteku: Downloading webpage
[CeskaTelevize]<PHONE_NUMBER>00005-arabela-na-uteku: Downloading JSON metadata
Traceback (most recent call last):
File "main.py", line 19, in
File "C:\Users\dst\AppData\Roaming\Build archive\youtube-dl\rg3\tmpphie_b_3\build\youtube_dl_init_.py", line 472, in main
File "C:\Users\dst\AppData\Roaming\Build archive\youtube-dl\rg3\tmpphie_b_3\build\youtube_dl_init_.py", line 462, in _real_main
File "C:\Users\dst\AppData\Roaming\Build archive\youtube-dl\rg3\tmpphie_b_3\build\youtube_dl\YoutubeDL.py", line 2001, in download
File "C:\Users\dst\AppData\Roaming\Build archive\youtube-dl\rg3\tmpphie_b_3\build\youtube_dl\YoutubeDL.py", line 792, in extract_info
File "C:\Users\dst\AppData\Roaming\Build archive\youtube-dl\rg3\tmpphie_b_3\build\youtube_dl\extractor\common.py", line 502, in extract
File "C:\Users\dst\AppData\Roaming\Build archive\youtube-dl\rg3\tmpphie_b_3\build\youtube_dl\extractor\ceskatelevize.py", line 130, in _real_extract
File "C:\Users\dst\AppData\Roaming\Build archive\youtube-dl\rg3\tmpphie_b_3\build\youtube_dl\utils.py", line 561, in sanitized_Request
File "C:\Python\Python34\lib\urllib\request.py", line 267, in init
File "C:\Python\Python34\lib\urllib\request.py", line 293, in full_url
File "C:\Python\Python34\lib\urllib\request.py", line 322, in _parse
ValueError: unknown url type: 'Error'
D:\MOVIE>youtube-dl --no-check-certificate --proxy socks5://<IP_ADDRESS>:443
https://www.ceskatelevize.cz/ivysilani/898281-arabela/280350950200005-arabela-na-uteku
[CeskaTelevize]<PHONE_NUMBER>00005-arabela-na-uteku: Downloading webpage
Traceback (most recent call last):
File "main.py", line 19, in
File "C:\Users\dst\AppData\Roaming\Build archive\youtube-dl\rg3\tmpphie_b_3\build\youtube_dl_init_.py", line 472, in main
File "C:\Users\dst\AppData\Roaming\Build archive\youtube-dl\rg3\tmpphie_b_3\build\youtube_dl_init_.py", line 462, in _real_main
File "C:\Users\dst\AppData\Roaming\Build archive\youtube-dl\rg3\tmpphie_b_3\build\youtube_dl\YoutubeDL.py", line 2001, in download
File "C:\Users\dst\AppData\Roaming\Build archive\youtube-dl\rg3\tmpphie_b_3\build\youtube_dl\YoutubeDL.py", line 792, in extract_info
File "C:\Users\dst\AppData\Roaming\Build archive\youtube-dl\rg3\tmpphie_b_3\build\youtube_dl\extractor\common.py", line 502, in extract
File "C:\Users\dst\AppData\Roaming\Build archive\youtube-dl\rg3\tmpphie_b_3\build\youtube_dl\extractor\ceskatelevize.py", line 74, in _real_extract
File "C:\Users\dst\AppData\Roaming\Build archive\youtube-dl\rg3\tmpphie_b_3\build\youtube_dl\extractor\common.py", line 761, in _download_webpage
File "C:\Users\dst\AppData\Roaming\Build archive\youtube-dl\rg3\tmpphie_b_3\build\youtube_dl\extractor\common.py", line 627, in _download_webpage_handle
File "C:\Users\dst\AppData\Roaming\Build archive\youtube-dl\rg3\tmpphie_b_3\build\youtube_dl\extractor\common.py", line 599, in _request_webpage
File "C:\Users\dst\AppData\Roaming\Build archive\youtube-dl\rg3\tmpphie_b_3\build\youtube_dl\YoutubeDL.py", line 2211, in urlopen
File "C:\Python\Python34\lib\urllib\request.py", line 464, in open
File "C:\Python\Python34\lib\urllib\request.py", line 482, in _open
File "C:\Python\Python34\lib\urllib\request.py", line 442, in _call_chain
File "C:\Users\dst\AppData\Roaming\Build archive\youtube-dl\rg3\tmpphie_b_3\build\youtube_dl\utils.py", line 1102, in https_open
File "C:\Python\Python34\lib\urllib\request.py", line 1183, in do_open
File "C:\Python\Python34\lib\http\client.py", line 1137, in request
File "C:\Python\Python34\lib\http\client.py", line 1182, in _send_request
File "C:\Python\Python34\lib\http\client.py", line 1133, in endheaders
File "C:\Python\Python34\lib\http\client.py", line 963, in _send_output
File "C:\Python\Python34\lib\http\client.py", line 898, in send
File "C:\Users\dst\AppData\Roaming\Build archive\youtube-dl\rg3\tmpphie_b_3\build\youtube_dl\utils.py", line 1068, in connect
File "C:\Users\dst\AppData\Roaming\Build archive\youtube-dl\rg3\tmpphie_b_3\build\youtube_dl\socks.py", line 270, in connect
File "C:\Users\dst\AppData\Roaming\Build archive\youtube-dl\rg3\tmpphie_b_3\build\youtube_dl\socks.py", line 266, in _make_proxy
File "C:\Users\dst\AppData\Roaming\Build archive\youtube-dl\rg3\tmpphie_b_3\build\youtube_dl\socks.py", line 221, in _setup_socks5
File "C:\Users\dst\AppData\Roaming\Build archive\youtube-dl\rg3\tmpphie_b_3\build\youtube_dl\socks.py", line 192, in _socks5_auth
File "C:\Users\dst\AppData\Roaming\Build archive\youtube-dl\rg3\tmpphie_b_3\build\youtube_dl\socks.py", line 131, in _recv_bytes
File "C:\Users\dst\AppData\Roaming\Build archive\youtube-dl\rg3\tmpphie_b_3\build\youtube_dl\socks.py", line 126, in recvall
EOFError: 2 bytes missing
D:\MOVIE>youtube-dl --no-check-certificate --proxy <IP_ADDRESS>:41258 https://www.ceskatelevize.cz/ivysilani/898281-arabela/280350950200005-arabela-na-uteku
[CeskaTelevize]<PHONE_NUMBER>00005-arabela-na-uteku: Downloading webpage
ERROR: Unable to download webpage: <urlopen error EOF occurred in violation of protocol (_ssl.c:600)> (caused by URLError(SSLEOFError(8, 'EOF occurred in violation of protocol (_ssl.c:600)'),))
D:\MOVIE>youtube-dl --no-check-certificate --verbose https://www.ceskatelevize.cz/ivysilani/898281-arabela/280350950200005-arabela-na-uteku
[debug] System config: []
[debug] User config: []
[debug] Custom config: []
[debug] Command-line args: ['--no-check-certificate', '--verbose', 'https://www.ceskatelevize.cz/ivysilani/898281-arabela/280350950200005-arabela-na-uteku']
[debug] Encodings: locale cp1252, fs mbcs, out cp850, pref cp1252
[debug] youtube-dl version 2018.07.21
[debug] Python version 3.4.4 (CPython) - Windows-7-6.1.7601-SP1
[debug] exe versions: none
[debug] Proxy map: {}
[CeskaTelevize]<PHONE_NUMBER>00005-arabela-na-uteku: Downloading webpage
[CeskaTelevize]<PHONE_NUMBER>00005-arabela-na-uteku: Downloading JSON metadata
Traceback (most recent call last):
File "main.py", line 19, in
File "C:\Users\dst\AppData\Roaming\Build archive\youtube-dl\rg3\tmpphie_b_3\build\youtube_dl_init_.py", line 472, in main
File "C:\Users\dst\AppData\Roaming\Build archive\youtube-dl\rg3\tmpphie_b_3\build\youtube_dl_init_.py", line 462, in _real_main
File "C:\Users\dst\AppData\Roaming\Build archive\youtube-dl\rg3\tmpphie_b_3\build\youtube_dl\YoutubeDL.py", line 2001, in download
File "C:\Users\dst\AppData\Roaming\Build archive\youtube-dl\rg3\tmpphie_b_3\build\youtube_dl\YoutubeDL.py", line 792, in extract_info
File "C:\Users\dst\AppData\Roaming\Build archive\youtube-dl\rg3\tmpphie_b_3\build\youtube_dl\extractor\common.py", line 502, in extract
File "C:\Users\dst\AppData\Roaming\Build archive\youtube-dl\rg3\tmpphie_b_3\build\youtube_dl\extractor\ceskatelevize.py", line 130, in _real_extract
File "C:\Users\dst\AppData\Roaming\Build archive\youtube-dl\rg3\tmpphie_b_3\build\youtube_dl\utils.py", line 561, in sanitized_Request
File "C:\Python\Python34\lib\urllib\request.py", line 267, in init
File "C:\Python\Python34\lib\urllib\request.py", line 293, in full_url
File "C:\Python\Python34\lib\urllib\request.py", line 322, in _parse
ValueError: unknown url type: 'Error'`

If the purpose of this issue is a site support request please provide all kinds of example URLs support for which should be included (replace following example URLs by yours):

Single video: https://www.youtube.com/watch?v=BaW_jenozKc
Single video: https://youtu.be/BaW_jenozKc
Playlist: https://www.youtube.com/playlist?list=PL4lCao7KL_QFVb7Iudeipvc2BCavECqzc

Note that youtube-dl does not support sites dedicated to copyright infringement. In order for site support request to be accepted all provided example URLs should not violate any copyrights.

Still no luck.. I've used "youtube-dl -U" to make sure the version is up to date.. Could you help me troubleshoot this..? Thank you.

I have this same issue too, they must something changed. I hope that fix will be soon:

debug:

I have this same issue too, they must something changed. I hope that fix will be soon:

debug:

I have this same issue too, they must something changed. I hope that fix will be soon.

I have this same issue too, they must something changed. I hope that fix will be soon.

Command youtube-dl --verbose --no-check-certificate https://www.ceskatelevize.cz/ivysilani/898281-arabela/280350950200005-arabela-na-uteku just works. This ticket should be closed, IMHO.


<EMAIL_ADDRESS>Hash check failed

Updating 'totalcommander' (9.22a -> 9.50)
Downloading new version
tcmd950x64.exe (2.4 KB) [=====================================================================================] 100%
Checking hash of tcmd950x64.exe ... ERROR Hash check failed!
App:         extras/totalcommander
URL:         http://totalcommander.ch/win/tcmd950x64.exe
First bytes: 3C 21 44 4F 43 54 59 50
Expected:    a84cb6a6bb00353b8ec10bf078a83ec0f5badb5841ea36c1a8dce3c36ffb4d9b
Actual:      eee5b0af414bf93219f714bdd0434e208b5bcac50f25b12e418c670734ea891f

Based on the size of downloaded file you downloaded webpage. If you open the downloaded file in text editor it will show that you have this page blocked (by firewall/anything)
Cannot reproduce from 4 different geo locations


Adding more descriptive options

When running pumpkin-cli --help, the options are not necessarily clear; and (what is more bothersome), it is not clear from the output what the possible values are for the different options.
This PR aims to address this by adding more descriptive documentation for the different options in combination with clarifying what the possible values are for the different options. All of the documentation now uses the verbatim_doc_comment so that it is in line with the rest of our documentation (and more importantly, that clap doesn't perform any weird line-breaking).

@EmirDe Would it be possible for you to check the links I added to the papers for the different options? I did a best-effort search for what was mentioned but I cannot be entirely sure if everything is correct unfortunately

I also removed the CliArg type in this PR. We used to have it because formatting was not configured on the underlying types, however, now that is the case so it can be removed.

Since this is about the presentation of --help, it would be nice to fill in the author, version and about fields in the #[command(...)] macro.

I have added this information to the crate-level information (which should be the default that clap uses); please let me know if this is what you had in mind!


host given a random port

Using this config:
example.net, www.example.net {
  tls off
  redir https://example.com{uri}
}
www.example.com {
  redir https://example.com{uri}
}
example.com {
  root www/example/public
}

The first 2 hosts, example.net, www.example.net should be on port 80 but are assigned 2015.

I think tls off is the reason for that. I know before now, Caddy defaults to port 2015 if scheme and port is not specified. With tls off, it disables automatic http/https and reverts to the previous behaviour.
Why not use http://example.net, http://www.example.net instead.

This should probably be patched. I'll look into it soon!

Okay, so... I'm not sure what to do here. The docs (see "Addresses") suggest that 443 is the default port for hosts that don't look like localhost. But this is only because the letsencrypt package configures it this way; when you say tls off you disable letsencrypt from working, so it can't serve on port 443 - thus it reverts to the default port 2015.
I'm not actually sure this is a bug; probably should be documented, yes, but would you really want Caddy to deviate from its default port assignment?

I disagree. tls off should mean "use http" and therefore use the default http port. And the default http port should be 80 like it is if you were to do http://example.com

Okay, but consider this: tls off means "don't use https" - not "use port 80".

The default port of "don't use https" should be port 80. I can't think of a sane reason why it should be a random port like 2015 that no one is expecting. http is port 80 in everyone's mind.

I prefer caddy defaulting to a port > 1024 so it doesn't need to run with root.
Until caddy and go support privilege separation, I recommend 2015 as the default.

I agree this will need more discussion before we make a major change like this. Both points are valid. One is logical and the other is intuitive (but technically complicated).

First, apologize to chime in on an old issue.
While the docs suggests that 443 is the default port, it's not really accurate from user perspective. Caddy also provides redirection from http to https.
So from the outside (i know nothing about the internal) when tls is on, Caddy listen on 2 ports: 80 & 443.
With 'tls off', they would expect: -443. and yet, what they get is: -80 -443 +2015. it is confusing.
I'm agree with @matthewp here, Caddy should listen to port 80 by default, with fallback to 2015 when it's failed.

While the docs suggests that 443 is the default port, it's not really accurate from user perspective. Caddy also provides redirection from http to https.

The docs I see indicate 2015 is the default when not using TLS:
https://caddyserver.com/docs/getting-started

Open your browser to http://localhost:2015 to see it working.

it is confusing.

But if you run ./caddy, the output will clearly report the site and port used:
example.com:2015

The docs I see indicate 2015 is the default when not using TLS:

But that's not what I'm talking about :).
I'm talking about the Addresses docs which linked by @mohlt.

example.com              # Host: example.com, Port: 443

while maybe it's technically right, but from user's point of view it's not. it's "80 and 443".
and that, make port 2015 as the default become unintuitive.

Maybe the best way to explain it is this:

The default port is 2015 in all cases (unless you change it with the -port flag).
If automatic HTTPS is activated (which it is by default if certain conditions are met), the default port for that host becomes 443. It also opens port 80 to serve HTTP redirects and ACME challenges.

I explain it that way in the docs because the site address by itself is enough to activate automatic HTTPS, effectively changing the port to something else. I agree it could be clearer; what do you think about my explanation I just gave? I'm trying to boil it down to two or three clear sentences.

Yes, I understand that, and your docs is clear enough to me. but even your first response to this issue is that you'll patch it soon. I guess because it looks like the right thing to do. and I believe it's important to look right.
Defaulting to non-standard port, and needing an explicit port for standard http, just doesn't feel right. I'm just trying to propose a compromise. I mean, how about two default ports? both 80 and 2015, depending on ability to bind low ports.
That way, those who expect implicit port for standard http, and who expect it to just run without the privilege will get satisfied.
Maybe this is one of those cases that you gave us something nice and we ended up wanting more :). I'm sorry if for that.

but even your first response to this issue is that you'll patch it soon.

Well, that's a little disingenuous to say -- keep reading, you'll see I misclassified the problem and changed my mind.

Defaulting to non-standard port, and needing an explicit port for standard http, just doesn't feel right.

Keep in mind that root privileges (or special capabilities) are required to bind to low ports, which has to be done "explicitly" by the operator, so I think it's fair to default to a higher port that just works with no configuration needed.
AFAIK most people use Caddy in dev environments anyway, and don't want to deal with the hassle of configuring it to run low ports. That slows down the development process.

I'm just trying to propose a compromise. I mean, how about two default ports? both 80 and 2015, depending on ability to bind low ports.

Frankly, because the point of Caddy is to make HTTPS the default (port 443), but that goal is a little different in dev environments where 2015 works just fine. Also, two default ports is confusing (as we've seen in this issue; I've done a poor job explaining it in the docs).

Maybe this is one of those cases that you gave us something nice and we ended up wanting more :). I'm sorry if for that.

No need to be sorry; the feedback and discussion is good. I find value in it and take it into consideration at least, even if I don't bow to every wish I've received. (Caddy would be an utter mess already if I did do that, to be honest.)
So, to recap, I'm still convinced the current behavior of the program is correct, but perhaps I can clear up the documentation regarding it.

Well, that's a little disingenuous to say -- keep reading, you'll see I misclassified the problem and changed my mind.

I did say first ... :)

Also, two default ports is confusing (as we've seen in this issue; I've done a poor job explaining it in the docs).

and i believe there is no amount of docs could solve this kind of problem. the real cause for this issue is the reporter didn't read the docs. or he would know that he only need to remove the first block to get what he wanted. you already provided the redirection for free.
but it is understandable, his config is based on his intuition, based on his knowledge from other webservers.

Frankly, because the point of Caddy is to make HTTPS the default (port 443), but that goal is a little different in dev environments where 2015 works just fine.

But your main features, what set caddy different from others -- https by default, http2, le, on-demand tls -- are much more usable on production. why not make it easier for it?
Combine this with le rate limit, people came from other webservers first instinct would be to disable tls for some of their sites. and this whole cycle will repeat again.

@jahmad,
I think it's pretty simple--you start caddy and it will tell you what port it's serving content on for the site.
So at this point you're not even suggesting doc patches because there is no amount of docs could solve this kind of problem.
What's your solution to get caddy running on ports lower than 1024 without root access?

I think it's pretty simple--you start caddy and it will tell you what port it's serving content on for the site.

In dev, yeah. not so much in production, when you use caddy with any init system of your favorite. start caddy, everything looks fine, then you find out actually it's not, then you need to look at the log.

What's your solution to get caddy running on ports lower than 1024 without root access?

this is only important if 80 is the only default port. that's what the fallback for. to make current difficulties as irrelevant to this issue.

this is only important if 80 is the only default port. that's what the fallback for. to make current difficulties as irrelevant to this issue.

But falling back to another port would cause ACME challenges to fail. It simply cannot happen. It's either port 80 or it's no port at all; the server should refuse to start.
I'll try to clear up the documentation on this and then I'll close the issue once I'm done with that.

But falling back to another port would cause ACME challenges to fail. It simply cannot happen. It's either port 80 or it's no port at all; the server should refuse to start.

Wait, I thought we're talking about when tls is off, why would ACME challenges needed here?

Oh, right. My bad.
Still, I'm just going to change the documentation then consider this issue closed.

Hey @mholt, a lot of your reasoning has to do with dev, but I don't understand it. Why would I use a different instance of Caddy for every web project I'm developing? Why wouldn't I just stick a caddy file in my ~/dev folder and serve the entire thing?  That's what I do.... and I absolutely do want port 80 for this, typing localhost:somerandport/my/project is lame compared to localhost/my/project.

Before Caddy, did you just run nginx or Apache or whatever as root, then?

Yep.

You can do that with Caddy too, of course. Then you won't have to type :2015. (Although my Chrome history auto-completes it for me.)

Oh, so you're saying that if running as root then 80 will be the default http port?

No, but you can use -port 80 to make the default port, or just do http://localhost in your Caddyfile or something like that.

Ok, then we're back to the discussion of, why are the defaults the chosen defaults? :-)  What is the workflow that we are favoring?
Go ahead and do what you think is right and close this issue, but would be nice if we could continue the discussion either way.

@mholt from what i can gather, you don't want to change caddy's behaviour because you don't want to make the code more complicated. that's your main concern.
what i fail to understand is, from my point of view, it seems this change could simplify it, not make it more complicated.
when is caddy running on port 80?
currently: it's when user explicitly requested it, or when tls is managed by caddy. when is it managed? when user doesn't provide their own cert, when caddy can't bind low port, and bla bla, users need to read the docs for clarity.
i think it's too much rule, and can be simplified to: when caddy can bind low port.
or, did i missed something important here?

from what i can gather, you don't want to change caddy's behaviour because you don't want to make the code more complicated. that's your main concern.

I do mind extra complexity, but more than just not wanting to change behavior, I'm not convinced it needs to be changed.

when is caddy running on port 80?

Caddy is configurable; the answer to that question is not easy.
Here's the better question: What is the default port?
Answer: The default port is 2015.
Extended answer: Automatic HTTPS changes the port to 443 unless explicitly overwritten in the config. It also opens port 80. It does this regardless of the default port.
In other words, automatic HTTPS and the "default port" have nothing to do with each other.
No new arguments for changing the default port to 80 have come up; except that port 80 only sometimes works (if running as root, which we don't recommend anyway -- unless you use setcap but that only works in Linux and few developers will want to bother with that) and port 2015 will nearly always work.
So feel free to carry on the discussion, but I'm checking out of it so I can get things done.

I do mind extra complexity, but more than just not wanting to change behavior, I'm not convinced it needs to be changed.

Well, that's all what i'm trying to do. convince you. and no, i won't continue it either when i already failed :). thank you for the discussion.


[manila-csi-plugin] added helper named templates for labels

This PR moves various labels listings from individual Kubernetes component manifests into common named templates, into _helpers.tpl. This is inspired by (borrowed / stolen from :)) cinder-csi's chart that does this too, and I think is nicer than what manila-csi currently does.
No effective change in rendered YAML output, please see https://gist.github.com/gman0/5b711294cdbbbc7445f426bfd0b44c3f (only some key-value pairs are reordered but that has no real effect).

What this PR does / why we need it:
Which issue this PR fixes(if applicable):
fixes #
Special notes for reviewers:

Release note:

NONE

/approve
/lgtm


Add voice-overlay-ios

Adding the voice-overlay-ios library
Project URL
https://github.com/algolia/voice-overlay-ios
Category
Voice category (new) inside UI
Description
Voice overlay helps you turn your user's voice into text, providing a polished UX while handling for you the necessary permissions.
Checklist

[x] Only one project/change is in this pull request
[x] Has unit tests, integration tests or UI tests
[x] Addition in chronological order (bottom of category)
[x] Supports iOS 9 / tvOS 10 or later
[x] Supports Swift 4 or later
[x] Has a commit from less than 2 years ago
[x] Has a clear README in English

          1 Warning

:warning:
Too many changes (when adding, please keep it to one project per Pull Request)

  Generated by :no_entry_sign: Danger

The danger warning triggered because I am adding a new sub-category Voice

hey @spinach, thanks for contributing! I saw your library a couple days ago somewhere and I was already gonna add it to next week's AwesomeiOS.Weekly 🎉

Thanks @lfarah 😄


More generic api

It's needed for https://github.com/CanalTP/mimirsbrunn/pull/350. I need to save data into a database instead of doing it into memory. Providing this API allowed me to do it.

Updated.

Thanks a lot for your help! Could you also make a release please? :3

v0.13.2 published

Thanks again!

welcome


Twitch usernames starting with a number raise an sqlite error

Partially solved by moving to CSV files. Needs to be addressed when writing the consolidation script

Fixed by add an underscore to the start of their name


[Cherry-pick] Keep user-provided dynamic axes (#1442)

Cherry-pick of #1442 for hot-fix 1.4.3

force landing given this doesn't touch stalled keras test


feat(dispatch): recorded simulator versions and digests for simulation runs

closes #3195

Uses simulators database to validate requested simulator/version
Raises BadRequestException if an image isn't registered for the requested simulator/version
Saves digest (hash) for simulator/version to SimulationRun
Added common data models for simulators and simulation runs
Added simulatorDigest to SimulationRunUpdate. I added this when thinking about using the SBatch service to get image digests. This could be removed. I ended up not using this and instead getting digests from the simulators database.

@bilalshaikh42 the key thing to review is the integration of the simulator API (L307 of apps/api/src/simulation-run/simulation-run.service.ts).

:tada: This PR is included in version 5.8.0 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


build.json missing ?

hi
thanks for your work
for a custom build you say "Set the features you don't want to false in build.json"
i don't see any build.json or i'm missing something ?

Hi @quasiperfect ,
I have updated the Readme. Custom build option was present in v3 . In the current version, it has been removed as it broke some functionalities. V4 is already ~50KB less in size than V3 so I don't think you would need that. Removing a functionality changed the size by around 1 or 2 KB. So I felt it was better to optimize the whole library instead of providing that option.
I would definitely like to bring it back once I figure out a way in which it doesn't break the other functionalities.

@ritz078 thanks for you fast replay
i wasn't worried about the size only performance
i will set to false the parser options i don't use (twitter etc)

That should solve it for you. Performance wise v4 is lot better.


Innacurate start and till time of slices attained

Hi @taylorlu
Thanks for your awesome integration on the UIS-RNN code. We have made a custom UIS-RNN model based on our data and getting somewhat decent accuracy but the slice timings when the speaker changes are slightly off by some margin in majority of the cases. (either the start time starts a bit early even when the particular speaker has not started speaking or the till time ends early when the particular speaker is still speaking)
Can you please throw some light on what can be the issues for the cause.
Thanks in advance.

The timings accurary also depends on the speaker feature, perhaps you need to find a more robust speaker feature extractor which can anti-noise, and also, change the sliding window size or hopsize may result in a different segmentation.

The timings accurary also depends on the speaker feature, perhaps you need to find a more robust speaker feature extractor which can anti-noise, and also, change the sliding window size or hopsize may result in a different segmentation.

Thanks @taylorlu for the prompt reply. Can you please suggest how we can make our speaker feature extractor more prone to the isssues or can suggest some other speaker feature extractors for the same too.
Thanks a lot.


Uncaught Error: Cannot find module Util

I get this error when running sharp
constructor.js:3 Uncaught Error: Cannot find module 'util'
    at webpackMissingModule (constructor.js:3)
    at Object../node_modules/sharp/lib/constructor.js (constructor.js:3)
    at __webpack_require__ (bootstrap:24)
    at fn (hot module replacement:61)
    at Object../node_modules/sharp/lib/index.js (index.js:3)
    at __webpack_require__ (bootstrap:24)
    at fn (hot module replacement:61)
    at Module../src/utils/sharpImage.js (sharpImage.js:1)
    at __webpack_require__ (bootstrap:24)
    at fn (hot module replacement:61)

Webpack version
    "webpack": "^5.10.0",
    "webpack-cli": "^4.2.0",
    "webpack-dev-server": "^3.11.0"

I hope this information helped. Please feel free to re-open with more details if further assistance is required.


Public directory on keybase.pub not found, strange log lines

This evening I noticed my public directory on keybase.pub (https://keybase.pub/jcassee/) no longer exists. Also this line keeps appearing in my logs (not sure if related):
2016-09-24T20:31:40.392922 ▶ [WARN kbfs connection.go:414] 1fc MDServerRemote: DoCommand error: "MDServerErrorThrottle{ProvisionedThroughputExceededException: The level of configured provisioned throughput for the table was exceeded. Consider increasing your provisioning level with the UpdateTable API}"; retrying in 9.13107888s
my log id: beb67a8a11da2e22ec18281c

Also, /keybase/kbfs.error.txt contains exactly one line with the same error: md-server: MDServerErrorThrottle{Duplicate re-registration}

Looks like it's back now.  Does it look ok for you now?  We were getting hit with a lot of traffic this morning, and it was preventing access for some (possibly keybase.pub) -- hence those throttle errors.  Please close out if everything looks ok now.

Yes, it's working again. Thanks for the explanation!


npm: command not found

I am trying to add Vue Json component to an existing project. I'm following the instructions but I am getting this error:
-bash:  npm: command not found .

Do you have npm installed?


Refactor way to read OPENAI-API-KEY

https://chat.openai.com/share/54687dac-6909-49b7-922b-75727a048ca3

https://github.com/jabrena/spring-boot-user-beans/pull/97


🔧 Update template

This pull request merges the current state of the template used here into this project so that it is up to date.

:tada: This PR is included in version 1.1.0 :tada:
The release is available on:

v1.1.0
GitHub release
Docker container (sebbo2002/fhem-log2db:1.1.0)
v1.1.0

Your semantic-release bot :package::rocket:


Issue 18 : Re-enable systemtest + Add JAVA_HOME export to Jenkins file

Signed-off-by: Mesbah<EMAIL_ADDRESS>

As discussed with Simon and Shelley, setting JAVA_HOME to the SDK under test in the Jenkinsfile solves the problem, as STF requires JAVA_HOME to be set in order for it to figure out which JDK to use for compiling STF and systemtest artifacts.

I made the update to Jenkinsfile in my branch and ran ran a few builds to test:
Here's a openjdk9_openj9_systemtest_x64_linux build I launched manually with "nightly" SDK : https://ci.adoptopenjdk.net/view/work%20in%20progress/job/openjdk9_openj9_systemtest_x64_linux/33/consoleFull

Here's a openjdk9_openj9_test_x86-64_linux build launched with upstream SDK: https://ci.adoptopenjdk.net/view/OpenJDK%20tests/job/Mesbah_openjdk9_openj9_test_x86-64_linux/1/console

In both the cases, java.home , java8_bindir, and java8_compiler are now pointing to the SDK under test.

@sophia-guo - could you please review the changes and confirm that adding JAVA_HOME export in Jenkinsfile will not have any negative side effects in any other jobs?