Atlas water quality sensor bugfix

Replace while loops in the Atlas Water Quality sensor code with for loops that have a timeout value.
This should address #28

Were you able to read from the sensors with out the while loop ? I had trouble when I used a single command I2C_Master_write with out while loop.

It seems to work fine so far. DO is reporting 9.1.
Unfortunately, I only have 1 WQ sensor on the testing rig so I can't see how it works for all of them right now. I don't know if we'll get a full rig for the CI node.

Confirmed that the Atlas sensors no longer cause the firmware to hang when unplugged.


Could we have a feature which load/refresh the comments every 5 seconds

I am new to Jquery, but realized this plugin is pretty cool. Now I would like to reload/refresh the comments container every 5 seconds, googled and tried, but the experience is not so good.
What I am looking for is that only some new comments being added or removed, not the whole div or page being refreshed.
Thanks!

This is a feature that should be imlemented using web sockets instead of polling the API every X second. Moreover, it should be implemented on the application's end, not the other way around. The web socket implementation is highly dependent on the application for which reason it cannot be implemented directly to the jquery-comments. However, you can utilize the "createComment" and "deleteComment" functions if you end up implementing the feature to your application.

Thanks Joona, but createComment and deleteComment will cause the UI
refresh, what I am looking for is the comment area automatically add new
comment and hide removed comments without refresh, is there any suggestion?
On Mon, Jul 4, 2016 at 6:21 PM, Joona Tykkyläinen<EMAIL_ADDRESS>wrote:

Closed #53 https://github.com/Viima/jquery-comments/issues/53.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/Viima/jquery-comments/issues/53#event-711871222, or mute
the thread
https://github.com/notifications/unsubscribe/AELnwaJlIaG-LVxjfr_lJ6zSHZjLXUjHks5qSN67gaJpZM4IjGuO
.

I'm not quite sure what do you mean by the UI refresh as neither delete nor create rebuilds the DOM but only the one specific element is manipulated.

Sorry I didn't express clearly, I mean the comment area could automatically
load new comments, the visual effect is a new comment is being inserted at
the top without flashing. :-)
On Wed, Jul 6, 2016 at 4:31 PM, Joona Tykkyläinen<EMAIL_ADDRESS>wrote:

I'm not quite sure what do you mean by the UI refresh as neither delete
nor create rebuilds the DOM but only the one specific element is
manipulated.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/Viima/jquery-comments/issues/53#issuecomment-230710704,
or mute the thread
https://github.com/notifications/unsubscribe/AELnwcOhswUGD1Lw-yUzq_O60Q3rGoAoks5qS2fIgaJpZM4IjGuO
.

Still no sure what do you mean by flashing, are you sure you are not reloading the plugin on a addComment or deleteComment callback? If you look at the source (addComment -function) you can see that only the created element is added to DOM without UI refresh.

I think you are right, add/deleteComment is perfectly working for me.
Thanks!
On Wed, Jul 13, 2016 at 3:27 PM, Joona Tykkyläinen<EMAIL_ADDRESS>
wrote:

Still no sure what do you mean by flashing, are you sure you are not
reloading the plugin on a addComment or deleteComment callback? If you look
at the source (addComment -function) you can see that only the created
element is added to DOM without UI refresh.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/Viima/jquery-comments/issues/53#issuecomment-232277486,
or mute the thread
https://github.com/notifications/unsubscribe/AELnwZhz10HGEBKxcC9Gp51FVfGI3yazks5qVJN1gaJpZM4IjGuO
.

Hi. I have successfully implemented calls to createComment and removeComment to programatically update the comments widget. What I'm having trouble with is updated comments.... as calling the putComment method doesn't seem like a viable option. Any ideas?


only lower caps on sans dialogue

In the game, the sans dialogue usually is in all lower case, but there are some instances where he does have words capitalized. And for some reason, I can't type in capital letters when I have sans selected. If you could fix this, that would be awesome.

You can't type caps as Sans because I designed it that way. :)
I don't recall any places in the game where Sans has capitalized text.
Refresh my memory? It's probably not hard to undo this but I do like the
"flavor" of having Sans speak in lowercase even if you try to make him use
caps.
On Wed, Apr 6, 2016 at 9:40 PM, MrFluffCat<EMAIL_ADDRESS>wrote:

In the game, the sans dialogue usually is in all lower case, but there are
some instances where he does have words capitalized. And for some reason, I
can't type in capital letters when I have sans selected. If you could fix
this, that would be awesome.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub
https://github.com/valrus/undertale-dialog-generator/issues/50

Nothing much, most of the time it is lowercase. Sometimes he mixes up
things like writing I in uppercase. Just goes to show how lazy he is.
On 7 April 2016 at 18:47, Ian McCowan<EMAIL_ADDRESS>wrote:

You can't type caps as Sans because I designed it that way. :)
I don't recall any places in the game where Sans has capitalized text.
Refresh my memory? It's probably not hard to undo this but I do like the
"flavor" of having Sans speak in lowercase even if you try to make him use
caps.
On Wed, Apr 6, 2016 at 9:40 PM, MrFluffCat<EMAIL_ADDRESS>wrote:

In the game, the sans dialogue usually is in all lower case, but there
are
some instances where he does have words capitalized. And for some
reason, I
can't type in capital letters when I have sans selected. If you could fix
this, that would be awesome.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub
https://github.com/valrus/undertale-dialog-generator/issues/50

—
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub
https://github.com/valrus/undertale-dialog-generator/issues/50#issuecomment-206988669

--
Vriendelijke groet van Valentijn Vermeij

OK, I'm calling this "as designed." Sans speaks in lowercase, any time he doesn't it's wrong, this is official IDTHV canon now, I proclaim it thus.


feat: delay jinja evaluation for script

This delays the Jinja evaluation for the script contents. That means that we can also inject a lot of variables into the script by using jinja.
Such as ${{ PREFIX }} or ${{ PYTHON }}.
For example the following two examples work on Windows and on Unix:
build:
  script: cargo install --root ${{ PREFIX }} .
  # or
  script: ${{ PYTHON }} -m pip install .

These variables are also available as environment variables. However, since we are using cmd.exe and bash on the different operating systems, the syntax to expand environment variables is not the same (%PREFIX% vs $PREFIX).
Alternatives we considered (or are considering):

add a jinja function env("PREFIX") that expands to either %PREFIX% or $PREFIX depending on execution context. Might not work well with different interpreters.
automatically convert $PREFIX to %PREFIX% as a string replacement on cmd.exe

TODO

[x] missing values from context
[ ] Adjust the recipe rendering CEP because now we need the variables from the Context later as well

Something that we might want to think about is that this does not solve the case for e.g. CMake or Meson that both have ${MESON_ARGS} or ${CMAKE_ARGS} defined in their activation scripts that make them work quite OK cross-platform.

We could still add the env function, e.g.:
script:
  - cmake ${{ env("CMAKE_ARGS") }} .
  - ninja install

Or we change the way we do activation completely (to work like pixi) and add everything to the Jinja context :)

Or we change the way we do activation completely (to work like pixi) and add everything to the Jinja context :)

To me, from a user perspective, this makes the most sense. Adding all the environment variables after activation to the env jinja object that is.
It might also be slightly confusing to users which variables are available when but at least we provide a consistent way to access environment variables.

Would this have an expanded path hard-coded when the recipe is rendered? That would make rebuilding a conda package like with reproducible-builds impossible.

Actually, it's a requirement for the reproducible builds to build the packages in the exact same prefix regardless, so that's not really an issue. A lot of packages ship files with the prefix in some text files (such as .pc files etc.) and e.g. Debian also builds packages in the same folder always afaik. So I hope that being stable against changes in the filesystem location is not a requirement for reproducible builds.


Login as Guest

Add a checkbox to login as a guest, which disables the password field so that pressing enter logs users in as guests rather than advancing the focus. For continuity, perhaps create a settings file to store the last state.

Installing the ini4j library to handle a .ini file for configuration.

Completed by commit 1faf2ac.


Don't merge: testing #2166 with ci_matching_branch

Testing #2166 against https://github.com/gazebosim/sdformat/pull/1325 using ci_matching_branch/* names and https://github.com/osrf/homebrew-simulation/commit/4d2d61f8ed6ab09f314f3a39e62adc956c834bd2
Server: explicitly skip auto-inertial calculation
Automatic inertial calculation may not work in
Root::Load, so explicitly configure the loader
to skip auto-inertial calculation.
Do not merge

this didn't actually use https://github.com/gazebosim/sdformat/pull/1325 because it used bottles instead of building from source; let me try again

@osrf-jenkins run tests please


Why find bottom and side line before transform?

https://github.com/princewang1994/TextSnake.pytorch/blob/6e890ef75a0f9e82b7dfe6ea4c4200ad2664840d/dataset/dataload.py#L151
After transform, polygons will change. Bottom and side line still correct for disk cover?

Hi, find_bottom_and_sideline finds two bottoms using cosine metric mentioned in the paper. The cosine metric would be changed after augmentation, for example, it can be warp heavily so you may unable to find the correct bottoms and sidelines.
BTW, find_bottom_and_sideline record index of edge, but not the exact coordinates. After transforming, it produce the geometric target, so it works well.

Thank you, now i understand. I will close this issues.


Error in module, always shows weight for unequipped items...

Below issue is when using: Foundry 0.7.9 / 5E 1.2.2 / Variant Encumbrance  v0.3 / Tidy 5E Sheet 0.4.10
Characters (player-owned) always show encumbrance of all items in inventory even when selecting "Equipped" or other filters for encumbrance.
When a filter is selected I receive the following error messages (one or the other, sometimes both) in the console:
Error: Invalid scope for flag categorys
at Actor5e.getFlag (foundry.js:30217)
at convertItemSet (VariantEncumbrance.js:174)
at calculateEncumbrance (VariantEncumbrance.js:330)
at VariantEncumbrance.js:65
at Function._call (foundry.js:2496)
at Function.call (foundry.js:2481)
at Tidy5eSheet._render (foundry.js:4547)
at async Tidy5eSheet._render (foundry.js:5157)
Uncaught (in promise) Error: Invalid scope for flag categorys
at Actor5e.getFlag (foundry.js:30217)
at convertItemSet (VariantEncumbrance.js:174)
at updateEncumbrance (VariantEncumbrance.js:211)
at VariantEncumbrance.js:108
at Function._call (foundry.js:2496)
at Function.callAll (foundry.js:2456)
at Function._handleUpdateEmbeddedEntity (foundry.js:30047)
at Actor5e.updateEmbeddedEntity (foundry.js:30015)
at async Actor5e.updateEmbeddedEntity (entity.js:199)
at async Tidy5eItemSheet._onSubmit (foundry.js:5251)

#25 has resolved this issue, the distributed release of VE is being updated now to fix this.

#25 has resolved this issue, the distributed release of VE is being updated now to fix this.


FinRL_Ensemble_StockTrading_ICAIF_2020 Error with DAX Data

Hello,
I just changed the DOW30 Data to DAX data in the FinRL_Ensemble_StockTrading_ICAIF_2020 file.
df = YahooDownloader(start_date = '2009-01-01',                      end_date = '2021-07-06',                      ticker_list = config.DAX_30_TICKER).fetch_data()
However, I then receive an error when running the code. When running the code cell
df_summary = ensemble_agent.run_ensemble_strategy(A2C_model_kwargs,                                                  PPO_model_kwargs,                                                  DDPG_model_kwargs,                                                  timesteps_dict)
I receive the error
ValueError: Expected parameter loc (Tensor of shape (1, 27)) of distribution Normal(loc: torch.Size([1, 27]), scale: torch.Size([1, 27])) to satisfy the constraint Real(), but found invalid values: tensor([[nan, nan, nan, nan, nan, nan, nan, nan, nan, nan, nan, nan, nan, nan, nan, nan, nan, nan, nan, nan, nan, nan, nan, nan,          nan, nan, nan]])
When using DOW30 data, the code runs properly.
Thank you in advance for any help.

This is usually caused by NaN or inf values in the datasets. You may try to replace the NaN values or inf values in the final datasets with 0 like this:
processed_full = processed_full.fillna(0)
processed_full = processed_full.replace(np.inf,0)

Thank you for your response! I already tried that, my preprocessing looks like that:
`fe = FeatureEngineer(
use_technical_indicator=True,
tech_indicator_list = tech_indicators,
use_turbulence=True,
user_defined_feature = True,
use_vix = True)
processed = fe.preprocess_data(df)
processed = processed.copy()
processed = processed.fillna(0)
processed = processed.replace(np.inf,0)`
However, the error stills occurs.

Probably one of the tickers is not giving you data. I recommend to download
the data and inspect it. Then remove or replace the faulty ticker.
It's a guess. I happend to me often when adding my own tickers
On Mon, Jan 17, 2022, 9:57 AM Kartolon @.***> wrote:

Thank you for your response! I already tried that, my preprocessing looks
like that:
`fe = FeatureEngineer(
use_technical_indicator=True,
tech_indicator_list = tech_indicators,
use_turbulence=True,
user_defined_feature = True,
use_vix = True)
processed = fe.preprocess_data(df)
processed = processed.copy()
processed = processed.fillna(0)
processed = processed.replace(np.inf,0)`
However, the error stills occurs.
—
Reply to this email directly, view it on GitHub
https://github.com/AI4Finance-Foundation/FinRL/issues/431#issuecomment-1014686352,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/ACMXHQ6YLA256W4DTGO3IKTUWQ35FANCNFSM5MCWPKOA
.
You are receiving this because you are subscribed to this thread.Message
ID: @.***>

Thank you for your input. I had a closer look at the data, but I could not find any fauly entries or missing values. I also plotted all of them individually and it looked all fine to me.

It works. 之前我使用A股的000100就是有同样的错误，今天对full processed data进行操作后已经可以运行了。

need to do the same to value like -inf, so the complete fix shall be:
processed_full = processed_full.fillna(0)
processed_full = processed_full.replace(np.inf,0)
processed_full = processed_full.replace(-np.inf,0)


navigationBarTitleImage prop doesn't show image

Version
Tell us which versions you are using:

react-native-router-flux v3.38.0
react-native v0.4.1

Expected behaviour
Nav bar header should show the image included.
Actual behaviour
Image included doesn't show.
Steps to reproduce

<Scene         key="login"         component={LoginForm}         sceneStyle={{ paddingTop: 0 }}         panHandlers={null} // disables swiping back         navigationBarTitleImage={require('../assets/images/navbar-logo.png')}      />    </Scene>

I will add that this is the first time I'm trying to use navigationBarTitleImage.

Hi, thank you for this awesome module!
I also have the same issue:

react-native v0.42.0
react-native-router-flux v3.38.0

Any news about this?

Are you able to find it in the inspector? Maybe you need to add better styles with navigationBarTitleImageStyle and our defaults need to be updated.

I've tried basically anything, can't get it to work.

Just noticed I wasn't using the latest build. Anyways, for best styling you have to change titleWrapperStyle, navigationBarStyle, and navigationBarTitleImageStyle defaults.
titleWrapperStyle: marginTop: 0, position: 'relative', top: 0
navigationBarStyle: justifyContent: 'center', alignItems: 'center'
navigationBarTitleImageStyle: resizeMode: 'contain' and of course include width, height

I'm having the same issue:

iOS: 10.2 (I didn't tried Android)
react-native: 0.42.0
react-native-router-flux: 0.38.0

<Scene
      key="Home"
      component={Home.App}
      initial={true}
      navigationBarTitleImage={require('app/src/assets/images/navigation/titleLogo.png')}
      type="replace"
      />

I cannot see any RCTImageView when debugging the view's hierarchy in Xcode, next is how the nav bar is rendered:

I tried with navigationBarBackgroundImage and it works fine.

@m-revetria You are using the release build, use the master

Hi @omerdn1! Thanks for your response.
I just tried using master but then react-native start started giving this error:
Failed to build DependencyGraph: @providesModule naming collision:
  Duplicate module name: jsc-heap-capture
  Paths: /path-to-app/node_modules/react-native-router-flux/node_modules/react-native/local-cli/server/middleware/heapCapture/package.json collides with /path-to-app/node_modules/react-native/local-cli/server/middleware/heapCapture/package.json

This error is caused by a @providesModule declaration with the same name across two different files.
Error: @providesModule naming collision:
  Duplicate module name: jsc-heap-capture
  Paths: /path-to-app/node_modules/react-native-router-flux/node_modules/react-native/local-cli/server/middleware/heapCapture/package.json collides with /path-to-app/node_modules/react-native/local-cli/server/middleware/heapCapture/package.json

This error is caused by a @providesModule declaration with the same name across two different files.
    at HasteMap._updateHasteMap (/path-to-app/node_modules/react-native/packager/src/node-haste/DependencyGraph/HasteMap.js:158:13)
    at /path-to-app/node_modules/react-native/packager/src/node-haste/DependencyGraph/HasteMap.js:133:31
error Command failed with exit code 1.

Any idea on how to solve it?
Regards

@omerdn1  you should set at least width and height on navigationBarTitleImageStyle and it should work fine, already on navbar center.

@m-revetria I'm having this same issue, but I think it is about using git packages on package.json. I'm investigating.

@m-revetria I did it. The problem comes when you install from a git repository. If you just delete the folder node_modules from react-native-router-flux inside your project's node_modules, it will be ok. Let us know if it works.

@filipemonteiroth That works. Thanks so much!
Can't wait for the next release to have that bug fixed.

The problem with this approach though is that everytime you do npm i to install a new dep that node_modules will come back.

Hi guys, any news with this issue? :)

User have the option to use a custom Navbar component. I did that with v3.36.0.
I'm just going to copy and past the new Navbar into my project and modify it until this is fixed. If I find a clean solution, I'll submit a PR.

Hola! Has there been any updates to this issue? Also, @AndrewHenderson any luck?

@Samueljoli it seems you can simply use react-redux connect function to wrap your scenes to wrap them. I just discovered this myself in the Switch example. Hope this helps!
<Scene
    key="root"
    component={connect(state=>({profile:state.profile}))(Switch)}
    tabs={true}
    unmountScenes
    selector={props=>props.profile.sessionID ? "main" : "signUp"}
    >
    <Scene key="signUp" component={SignUp}/>
    <Scene key="main" component={Main}>
</Scene>


nightly go-ipfs builds on distributions page

I think we're at the point where we should start thinking about setting up automated nightly builds, and pushing them to dists. Teamcity can likely do this for us, at least up to the point where we need to publish the new page.
Some random related thoughts:

need to make sure we unpin old nightly versions to not run out of gateway space
should we use teamcity? what other options are out there for this?
should add link to 'nightlies' on front page of dist to advertise we have them (RCs too!)
should have manual verification at first. don't hand the keys over to the robots!

cc @lgierth @chriscool @Kubuxu

ref https://github.com/ipfs/go-ipfs/issues/2828#issuecomment-242221987

Also: https://github.com/ipfs/distributions/issues/77

The build/add/pin and move-old-pins-to-archive-host steps are almost exactly what all of the websites and mirrorings need too.
:arrow_right: ipfs-pages

If given a choice, I would ask it as Docker images, too.
Automated Builds on Docker Hub would be helpful, since it can automatically generate image tags based on each branch.
Just my 2c.

docker builds are available for every commit hash on master from https://hub.docker.com/r/ipfs/go-ipfs/

Thanks, @Kubuxu. For nightlies I was also thinking in feature branches, too. Not just master, since some experiments live in other branches. Sorry for the confusion.

@pataquets agreed, having nightly builds for feature branches (feat/datastore-configs for example) would be a great thing to have.

I think it is every commit hash or it might be something our infrastructure does on deployment. I am not sure.

When the 'create image tag for each branch' feature was introduced, I found that legacy ABs were not using it automatically. You have to add the blank, unconfigured line manually. However, it gets configured by default for new ABs.
It might be also that branches have slashes on names and I'm not sure of how this maps to image tags, not sure.


remove badge for now

Codecov Report
Base: 74.47% // Head: 47.43% // Decreases project coverage by -27.03% :warning:

Coverage data is based on head (7932a2f) compared to base (3ec99ad).
Patch has no changes to coverable lines.

Additional details and impacted files
@@             Coverage Diff             @@
##             main      #41       +/-   ##
===========================================
- Coverage   74.47%   47.43%   -27.04%
===========================================
  Files          12       12
  Lines        1191     1191
===========================================
- Hits          887      565      -322
- Misses        248      567      +319
- Partials       56       59        +3

Flag
Coverage Δ

go_tests
?

mysql_tests
?

pg_tests
?

singlestore_tests
47.43% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files
Coverage Δ

lspostgres/postgres.go
0.00% <0.00%> (-78.19%)
:arrow_down:

driver.go
0.00% <0.00%> (-75.00%)
:arrow_down:

logger.go
33.33% <0.00%> (-66.67%)
:arrow_down:

internal/logger.go
60.00% <0.00%> (-40.00%)
:arrow_down:

apply.go
43.96% <0.00%> (-39.69%)
:arrow_down:

lsmysql/mysql.go
52.09% <0.00%> (-23.20%)
:arrow_down:

lsmysql/skip.go
60.22% <0.00%> (-19.32%)
:arrow_down:

api.go
76.08% <0.00%> (-17.40%)
:arrow_down:

dgorder/dependencies.go
82.00% <0.00%> (-16.00%)
:arrow_down:

lssinglestore/singlestore.go
71.14% <0.00%> (+48.99%)
:arrow_up:

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.


mis-alignment of button element of highlight-closing-pr-in-open-issues

This is the current look of the button whose element is not properly centred.

This OS and font-dependent, on my computer it's centered


Is it possible to specify unit of measurement in TransitionMotion?

In the TransitionMotion example https://github.com/chenglou/react-motion/#transitionmotion- , both willLeave and styles prop initialization in  has height value as number. There is no unit of measurement. It looks react-motion treat it as px. Is there any possibility to choose "em" or other units?

Yes, you can provide whatever you want. For example:
<Motion defaultStyle={{ height: 0 }} style={{ height: spring(10) }}>
  { value =>
Content
 }
</Motion>


Preset distribution: do not duplicate ingredient path

https://github.com/IDSIA/sacred/pull/769 had a typo that causes the scaffolding path to be concatenated twice. This PR fixes that typo and adds a test case for one instance which broke (passes in old Sacred, fails before this PR, passes after this PR).

@thequilo for review


SET unsafe_enable_version_guessing=true does not work with duckdb 1.1.3

tried the new update of iceberg extension, unfortunately getting error that SET unsafe_enable_version_guessing=true; is not supported

@djouallah  you beat me to opening this issue by a whole week!

same

Not sure if this is the cause, but the config option unsafe_enable_version_guessing is defined in Load() whereas in other extensions it seems to be usually defined in LoadInternal(). Maybe @teaguesterling would know from the implementation in #79?
https://github.com/duckdb/duckdb-iceberg/blob/main/src/iceberg_extension.cpp#L30-L39

I'm working on a fix for this (as best as I understand it). It's a bit hard to test as I think this only manifests when loading the extension when it's loaded from a different build.

I mucked up my dev environment but was able to get it sorted and test this out. @naoyak was right, and this was a simple change. My testing indicates this works, but I am happy to share an unsigned build if anyone else wants to test.


All text fields show up as required in configuration modals

Migrated from GitLab: https://gitlab.com/meltano/meltano/-/issues/1518
Originally created by @DouweM on 2019-12-24 16:48:52

View 2 previous comments from the original issue on GitLab


ENH: Enabled adding more point lists, in order to adding more separat…

…e segments to the same liver territory

This closes #170.


VS Code error:  module .civet was resolved to .civet.tsx

Hello there!
I set up a very basic Civet project. Everything seems to be working fine. The only issue I'm experiencing so far is the following error in VSCode:

Despite the error, I can still jump between modules using the Civet extension.  Any clue on how to stop VSCode from complaining?
Thank you,
Ilio.

Hi Daniel,
Thanks for the suggestion. Ideally, I would like to keep TypeScript out of the picture and just write Civet code that gets compiled to JavaScript. I tried to add a jsconfig.json file with the settings suggested in the Getting Started page (which includes jsx: preserve), but VSCode was still complaining.
After moving to TypeScript (typescript, ts-node, @types/node), tsconfig.json started producing the desired effect (I also instructed VSCode to use the TypeScript installation from node_modules/).
I guess there's no way to circumvent TypeScript, correct?
Thank you.

Did you try creating a tsconfig.json file without actually using TypeScript? (Shouldn't need to install or use those packages.)
The error (really, a warning) is caused by the plugin running TypeScript on your code to try to detect errors (and types). This is what you're configuring. It doesn't mean you actually need to write TypeScript types or run your code via TypeScript; you can continue to tool by compiling to JS and running that directly.
We should look into whether we can specify a default for JSX mode so that including a tsconfig.json file isn't necessary.

Hi Erik,
I just removed TypeScript from my my (very) basic project, while keeping tsconfig.json – and it seems to be working fine, thank you!
Still, I would find it a bit surprising to land on a project with a tsconfig.json file, just to discover that there's no use of TypeScript at all in the project toolchain. Since VSCode own documentation mentions that:

jsconfig.json is tsconfig.json with "allowJs" attribute set to true,

my hope was to use jsconfig.json in place of tsconfig.json when using Civet in a purely JavaScript project. Maybe the Civet LSP extension can fallback tojsconfig.json if no tsconfig.json is present.
I'm also curious to know what TypeScript installation the Civet extension is using when the TypeScript SDK is overridden at the workspace level  (via the "typescript.tsdk" in the project .vscode/settings.json). As different releases of VSCode ships with different versions of TypeScript, to improve reproducibility I usually have "typescript.tsdk"  point to use the installation in node_modules/. Would it also affect how the LSP extension type-checks the code?
Thank you!

Having the LSP default to "preserve" if no jsx option is specified is good idea.
Additionally there is more we should do to properly support jsconfig.json as well.
As for "typescript.tsdk" ideally the Civet LSP should respect what is configured though I'm not sure if it currently does.
Thanks for the thoughtful feedback!


Changes to test suite to facilitate version 12 differences, minor bug…

@zancas
Fixes: #320, #328, #329, #330, #335, #370
Improvements to testing suite to facilitate version 12 differences, as well as bugs found

@zancas
Rebased given the last major change.

lgtm


how to configure what would work normally?

Localhost on server, Whatsapp on bind (depends on the payload u are trying to build, Whatsapp bind will give u Whatsapp binded rat) then blue button on the bottom of the screen

Hi Anirudhmalik/Xhunter
Can i use a payload in PDF
On Sun, 12 Mar 2023, 14:16 Annxhilator, @.***> wrote:

[image: Screenshot_2023-03-07-21-40-36-876_com.xhunter.jpg]
https://user-images.githubusercontent.com/116150595/223459381-5099af95-e63c-47a4-9535-65ce08208bf0.jpg
Localhost on server, Whatsapp on bind (depends on the payload u are trying
to build, Whatsapp bind will give u Whatsapp binded rat) then blue button
on the bottom of the screen
—
Reply to this email directly, view it on GitHub
https://github.com/anirudhmalik/xhunter/issues/118#issuecomment-1465196992,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/A5NIYBYVG2PTGPA6OMS4M43W3XEDBANCNFSM6AAAAAAVSSSYLA
.
You are receiving this because you are subscribed to this thread.Message
ID: @.***>

Hi Anirudhmalik/Xhunter
Can i use a payload in PDF
On Sun, 12 Mar 2023, 14:16 Annxhilator, @.***> wrote:

[image: Screenshot_2023-03-07-21-40-36-876_com.xhunter.jpg]
https://user-images.githubusercontent.com/116150595/223459381-5099af95-e63c-47a4-9535-65ce08208bf0.jpg
Localhost on server, Whatsapp on bind (depends on the payload u are trying
to build, Whatsapp bind will give u Whatsapp binded rat) then blue button
on the bottom of the screen
—
Reply to this email directly, view it on GitHub
https://github.com/anirudhmalik/xhunter/issues/118#issuecomment-1465196992,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/A5NIYBYVG2PTGPA6OMS4M43W3XEDBANCNFSM6AAAAAAVSSSYLA
.
You are receiving this because you are subscribed to this thread.Message
ID: @.***>

Nope


False drift for some lambda function empty string field

Description
Some fields introduced by provider update are not normalized correctly (it seems the state is not always consistent depending if it's refreshed or not)
  - foo (aws_lambda_function):
    ~ ImageUri: <nil> => ""
    ~ SigningJobArn: <nil> => ""
    ~ SigningProfileVersionArn: <nil> => ""

Environment

OS: linux
driftctl version: 0.1.0

How to reproduce
Terraform code in lambda function supplier test help reproduce this.
Launch driftctl before and after a terraform refresh. The refreshed run show a drift.
Possible Solution
We should apply the same normalization from state and remote

running 0.1.1 against our own lambdas (on TF 0.13.5, not 0.14.2) I see this drift, is it related?
Found drifted resources:
  - driftctl-version (aws_lambda_function):
    ~ LastModified: "2020-11-25T13:50:24.157+0000" => "2020-12-14T15:18:34.926+0000"
    ~ PackageType: <nil> => "Zip"
    ~ Environment.0.Variables.LATEST_VERSION: "v0.0.10" => "v0.1.1"

@sjourdan It is not related, drift you are seeing is an expected behaviour.
Typically a case to be handled by resource field ignore which is in progress in #28


Section edit and delete UI

Add UI for editing and deleting sections. The edit form might need to be made more compact.

Codecov Report

Merging #9 (5cee35a) into master (fcbefff) will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##             master       #9   +/-   ##
=========================================
  Coverage     91.76%   91.76%
  Complexity      300      300
=========================================
  Files            29       29
  Lines          1215     1215
=========================================
  Hits           1115     1115
  Misses          100      100

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fcbefff...0c683f3. Read the comment docs.


CrayFits as part of Crayfish

GitHub Issue: discussed in Tech Call.
What does this Pull Request do?
Merges the CrayFits code as a directory within Crayfish. Keeps all git history.
What's new?
CrayFits code

Re-licenses it as MIT (formerly GPL, probably because we thought all Islandora code had to be)
Does this change require documentation to be updated?  - hardly, though it does permit some implementation code to be simplified
Does this change add any new dependencies? Possibly - though each microservice has its own requirements. See composer.json.
Does this change require any other modifications to be made to the repository (i.e. Regeneration activity, etc.)?  No
Could this change impact execution of existing code? no.

How should this be tested?

Set up a site to use Crayfits from Crayfish (this could be done in buildkit or on a whole VM if anyone's still setting up that way)
Note that you still need the separate FITS webservice
You should be able to generate FITS derivatives.

Additional Notes:
Any additional information that you think would be helpful when reviewing this PR.
Interested parties
Tag (@ mention) interested parties or, if unsure, @Islandora/8-x-committers

Update readme.


add springs feature profiles + XRAY support :TASK 4969 +Refactoring CQRS Domain: TASK 4820

[XXXX- - Please use the Work Item number and Title as PR Name, not subtasks]
📲 What
add springs feature profiles + XRAY support :TASK 4969 +
Refactoring CQRS Domain: TASK 4820
🤔 Why
Why it's needed, background context.
🛠 How
More in-depth discussion of the change or implementation.
👀 Evidence
Screenshots / external resources / links / etc.
Link to documentation updated with changes impacted in the PR
🕵 How to test
Notes for QA
✅ Acceptance criteria Checklist

[ ] Code peer reviewed?
[ ] Documentation has been updated to reflect the changes?
[ ] Passing all automated tests, including a successful deployment?
[ ] Passing any exploratory testing?
[ ] Rebased/merged with latest changes from development and re-tested?
[ ] Meeting the Coding Standards?

/azp run

/azp run

/azp run

/azp run

/azp run


Segfault when running manimgl

Describe the bug
Running manimgl with or without arguments results in a segfault
Code:
n/a
Wrong display or Error traceback:

Additional context
The crash began after #1383 was merged.

@eulertour Can you run with the debugger and post the backtrace?
gdb -batch -ex "run" -ex "bt" manimgl

Also, if the problem is with manimpango, can you check whether it works with ManimCE?

I went back to the version you mentioned, and then created a new conda environment, installed manimgl and ran it without any errors.
git checkout ad332c586341a665b2e69d4dbea8b023c66d575d
conda create -n manim_1387 python=3.8
source activate manim_1387
pip install -e . -i https://pypi.tuna.tsinghua.edu.cn/simple/
manimgl

And I feel that there is nothing in #1383 that will cause a segfault

@naveen521kk The first command

the second command

it works with ManimCE.
@TonyCrane If you weren't aware, ManimPango is a custom-written C extension for using Pango.
https://github.com/ManimCommunity/ManimPango/blob/main/manimpango/cmanimpango.pxd

does this command show Seg Fault?
python -c "import manimpango"

No

for the results about using gdb, you don't have debugging symbols installed see https://wiki.python.org/moin/DebuggingWithGdb

You don't have to help, I almost never use Text anyway.
I'm suggesting to make the change optional because the functionality isn't necessary to use manim and the code is unstable.

rather try running python using the verbose mode,
python -v -m manimlib

I'm suggesting to make the change optional because the functionality isn't necessary to use manim and the code is unstable.

Try removing text_mobject.py and run it also fix imports? I kinda feel like this isn't because of ManimPango.

I made a pastebin here: https://pastebin.com/dzV8dJpW.
manim runs normally if I comment out the imports of manimlib.mobject.svg.text_mobject and manimlib.animation.numbers (which imports text_mobject).

The paste says, https://pastebin.com/dzV8dJpW, the import manimlib.mobject.svg.text_mobject was successful which means there is nothing to do with ManimPango. line 1264
so after the import 'pyglet.gl' # <_frozen_importlib_external.SourceFileLoader object at 0x7fd22d9faf70> it shows Seg Fault? Try checking out to https://github.com/3b1b/manim/commit/96d9a66faf59bc97f709ebdd8a10685e1e141da5 and see if there is a Seg Fault there?
I think this should be the cause of Seg Faults https://github.com/3b1b/manim/commit/368a6c3d1ca8dadc5e2808d551a3746f2b192c40

@eulertour try setting env var PYTHONFAULTHANDLER to 1. Send what it says.  see https://docs.python.org/3/library/faulthandler.html

Running on both 96d9a66 and 368a6c3 runs normally. Dumping the traceback gives https://pastebin.com/HqsELR16.
I don't know if the problem is caused by ManimPango either. From what I've looked at it seems to be some interaction between ManimPango and moderngl that causes the problem. But being able to use manim is more important than being able to use pango, so to prevent breaking the entire library it makes more sense just to make it optional.

Just a last try, remove this line in __init__.py and run it?
https://github.com/3b1b/manim/blob/b7e2abb8016021f468c2f4c98790c94a75040a3f/manimlib/__init__.py#L26

It still segfaults when that line is commented, and I verified that the import wasn't occurring anywhere else.

Try compiling manimpango yourselves, maybe that fixes it?
python -m pip install manimpango --no-binary :all: --force

Compiling locally fixes the problem on ad332c5 and master.

Ah, I understand what happens, there are two different Pango version one used by manimpango and the other one from your system. Since, it's linux and gnome, any window which is opened uses pango for text rendering and this conflicting version, causing a segmentation fault. That's a reason I always recommend Linux users to install without using wheels, https://github.com/manimcommunity/manimpango#note, and I created those wheels only for the case of RTD build on Community Edition. It's also a notable reason why there don't exist wheels for pycairo outside of Windows.
For other OS like Mac and windows, this doesn't happen because the system uses its own rendering system and not Pango.


Prep for 0.12.1: Version Updates

Description
MERGE INTO RELEASE BRANCH v0.12.0 ONLY.

Version Updates
Added 0.12.1 to the Whats New in README.md. This tag does not exist yet
NEWS.md is not updated yet.

Checklist
Essentials

[ ] Passed code style checking (make lint)
[ ] Changes are complete (i.e. I finished coding on this PR)
[ ] All changes have test coverage
[ ] For user-facing API changes, API doc string has been updated.
[ ] To my best knowledge, examples are either not affected by this change, or have been fixed to be compatible with this change

Changes

[ ] Feature1, tests, (and when applicable, API doc)
[ ] Feature2, tests, (and when applicable, API doc)

Comments

If this change is a backward incompatible change, why must this change be made.
Intersting edge cases to note here

Not for this PR, but we really should have a script that updates all version numbers in one shot.


Dark mode on ZTM

It does not work  after add this extension

what is the problem?

Today the option for dark mode disappeared. Sidebar toggle still works. But no longer is there an option for dark mode in the drop down menu with autocomplete and auto play.

We updated our extension, the dark mode toggle bar will be in the popup.


README: fix typo in observable.withStateMachine

This fix some typo in observable.withStateMachine documentation

Nice, thanks!


Implement Model Output types for training on 3d locations

Allows training with 3d locations. Requires dimensionality of arena_dims in the config file to match that of the locations in the dataset

Nice!!!
On Sat, Jun 22, 2024, 11:31 AM Aramis Tanelus @.***>
wrote:

Allows training with 3d locations. Requires dimensionality of arena_dims
in the config file to match that of the locations in the dataset
You can view, comment on, or merge this pull request online at:
https://github.com/neurostatslab/vocalocator/pull/68
Commit Summary

38826bd
https://github.com/neurostatslab/vocalocator/pull/68/commits/38826bd4e2076bd4876502d3b810f3ea5bf88c72
Initial implementation of 3d locations

File Changes
(2 files https://github.com/neurostatslab/vocalocator/pull/68/files)

M vocalocator/outputs/gaussian.py
https://github.com/neurostatslab/vocalocator/pull/68/files#diff-82751fe0cb651113661d0a5fa279bb2d6396f3896286d474a4ad2bcc4a76737c
(151)
M vocalocator/training/trainer.py
https://github.com/neurostatslab/vocalocator/pull/68/files#diff-856208b723b2781a448da06912515342902224d2f095ee1bd1d01d57b6203dc7
(5)

Patch Links:

https://github.com/neurostatslab/vocalocator/pull/68.patch
https://github.com/neurostatslab/vocalocator/pull/68.diff

—
Reply to this email directly, view it on GitHub
https://github.com/neurostatslab/vocalocator/pull/68, or unsubscribe
https://github.com/notifications/unsubscribe-auth/AAE3NUOZI65BST2LXCYFDA3ZIWKDLAVCNFSM6AAAAABJXQXBHOVHI2DSMVQWIX3LMV43ASLTON2WKOZSGM3DOOBXGU4TINY
.
You are receiving this because you are subscribed to this thread.Message
ID: @.***>


prepare v0.5.0 release

I'd suggest we include https://github.com/tokio-rs/bytes/pull/318 in this.


[3] Can't move category to root

As the title says, you can't move a child category to the root

Fixed in laravel-forum-frontend.


Saving a template POSTs to an invalid URL

Fetching and updating regular documents works just fine, but when updating a page/template in the template manager modal, it adds an extra slash in the URL, resulting in a 404 on my back-end.

I'll fix this in the next release.


Electron libportaudio image not found - binding.gyp enhancement

I got hit with the Image not found error for libportaudio when I packaged up my electron application and ran it on a different machine, application ran fine on the development machine though. After digging through some documents about node-gyp, I was suggested to look for the linker section of the naudiodon.node binary and found out that the LC_PATH was set to an absolute path of the build/Release path on my development machine. What I did to make it work was to change the OTHER_LDFLAGS of OS=="mac" to "-Wl,-rpath,@loader_path/" which tells the linker to look for libraries relative to the binary file location.

Hi, thanks for the feedback, I'm sorry you hit a problem.
I don't have access to a Mac at the moment but if you would like to test this change and raise a PR I'm happy to update.

I can confirm this indeed fixes the Image not found problem

I can confirm this indeed fixes the Image not found problem

Can confirm the above works as well. I.E changing to snippet below in binding.gyp:
  "conditions" : [
    [
      'OS=="mac"', {
        'xcode_settings': {
          'GCC_ENABLE_CPP_RTTI': 'YES',
          'MACOSX_DEPLOYMENT_TARGET': '10.7',
          'OTHER_CPLUSPLUSFLAGS': [
            '-std=c++11',
            '-stdlib=libc++',
            '-fexceptions'
          ],
          'OTHER_LDFLAGS': [
            "-Wl,-rpath,@loader_path"
          ]
        },

Please update this if possible, otherwise I'm happy to put in a PR.
Many thanks


Last min

Issue #, if available:
Description of changes:
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Hi @davinci07, thank you for the pull request!
To help us better understand the intent of the pull request, kindly update the PR title and body with a description of the changes being committed.


Error: Couldn't allocate enough memory

Describe the bug
yarn workspace @packages/package bundle does not work as expected
`
➤ YN0019: │ yargs-parser-npm-20.2.9-a1d19e598d-8bb69015f2.zip appears to be unused - removing
➤ YN0019: │ yargs-parser-npm-9.0.2-a0a3214d46-59276dc17b.zip appears to be unused - removing
➤ YN0019: │ yauzl-npm-2.10.0-72e70ea021-7f21fe0bba.zip appears to be unused - removing
➤ YN0019: │ zen-observable-ts-npm-1.2.3-4a54eb0466-0548b555c6.zip appears to be unused - removing
➤ YN0019: │ zwitch-npm-1.0.5-5911cef6ce-28a1bebaca.zip appears to be unused - removing
➤ YN0000: └ Completed in 2s 686ms
➤ YN0000: ┌ Link step
➤ YN0007: │ type-graphql@npm:1.1.1 [a5641] must be built because it never has been before or the last one failed
➤ YN0007: │ dtrace-provider@npm:0.8.8 must be built because it never has been before or the last one failed
➤ YN0007: │ @apollo/protobufjs@npm:1.0.5 must be built because it never has been before or the last one failed
➤ YN0007: │ core-js@npm:3.8.2 must be built because it never has been before or the last one failed
➤ YN0007: │ jss@npm:9.8.7 must be built because it never has been before or the last one failed
➤ YN0007: │ type-graphql@npm:1.1.1 [422b9] must be built because it never has been before or the last one failed
➤ YN0007: │ type-graphql@npm:1.1.1 [00665] must be built because it never has been before or the last one failed
➤ YN0000: └ Completed in 4s 506ms
➤ YN0000: Creating archive
➤ YN0000: Copying files to archive
➤ YN0001: Error: Couldn't allocate enough memory
at Qr.allocateBuffer (/Users/project/.yarn/releases/yarn-3.0.2.cjs:177:21994)
at Qr.allocateSource (/Users/project/.yarn/releases/yarn-3.0.2.cjs:177:22426)
at Qr.setFileSource (/Users/project/.yarn/releases/yarn-3.0.2.cjs:177:22684)
at Qr.writeFilePromise (/Users/project/.yarn/releases/yarn-3.0.2.cjs:177:26970)
at Woe.g (/Users/project/.yarn/releases/yarn-3.0.2.cjs:172:9287)
at async vN (/Users/project/.yarn/releases/yarn-3.0.2.cjs:172:7182)
at async Qr.copyPromise (/Users/project/.yarn/releases/yarn-3.0.2.cjs:172:13426)
at async /Users/project/.yarn/plugins/@ojkelly/plugin-build.cjs:44:2003
at async Function.start (/Users/project/.yarn/releases/yarn-3.0.2.cjs:275:2287)
at async /Users/project/.yarn/plugins/@ojkelly/plugin-build.cjs:44:1567
➤ YN0000: Failed with errors in 12s 399ms
To Reproduce

yarn workspace @packages/package bundle

Expected behavior
Creates a bundle
Desktop (please complete the following information):

OS: macOS

Additional context
Yarn bundle version: latest
Yarn berry version: yarn-3.0.2.cjs

Couldn't allocate enough memory

Do you have a ballpark on how big the bundle would be?
How much RAM does that system have?
I'd suspect were loading the contents of the file into memory to zip, instead of say streaming it.
If so, definitely warrants a fix.

Macos info:
16 GB 2400 MHz DDR4
2,6 GHz 6-Core Intel Core i7
Bundle uncompressed: 2 861 939 299 bytes (2,88 GB on disk) for 2 836 items
Bundle.zip: 70.5mb

It could be that I am a little bit overloading bundle command.
I removed some of the unneeded files with .bundleignore
Not getting this error anymore

Yeah, I'll still look and see if we're zipping as efficiently as possible, as we ideally shouldn't hit memory limits to zip a file.
Glad you could resolve by reducing what goes to the bundler. Same principle as docker here, as we need to copy the repo first, then do stuff. The less we copy the faster it can go. But, as I want this whole tool to be really generalisable, we can't predict what you wont need, you've gotta specify it.

It seemed that my directory contained some docker volume like
tmp

postgres-data
redis-data
amqp-data

and so on, this boalooned the bundle alot


WIP: Make pod and profile names unique in OCI test

What type of PR is this?
/kind flake
What this PR does / why we need it:
Making the profile and pod name unique to the test scenario.
Which issue(s) this PR fixes:
None
Does this PR have test?
None
Special notes for your reviewer:
None
Does this PR introduce a user-facing change?

None

Codecov Report

Merging #1835 (848c3a2) into main (8a1e8da) will not change coverage.
The diff coverage is n/a.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1835   +/-   ##
=======================================
  Coverage   49.11%   49.11%
=======================================
  Files          71       71
  Lines        6984     6984
=======================================
  Hits         3430     3430
  Misses       3420     3420
  Partials      134      134


Detect .hs-boot files

Fixes #22

I've converted this to a draft until I can confirm it works locally. Sorry for the wasted time.


Uploaded images become inaccessible after the domain was changed.

Describe the bug
Uploaded images become inaccessible after the domain was changed. I only tested it in development env.
To Reproduce
Steps to reproduce the behavior:

Under domain.old, you uploaded your custom avatar.
You updated domain.old to domain.new, and the uploaded avatar became inaccessible.

Domain changes are very common.

Expected behavior
Uploaded files should serve well no matter what the domain is.
Screenshots

Platform

Device: Desktop
OS: macOS Ventura 13.6.1
Browser and version: Chrome 122.0.6261.129 (Official Build) (x86_64)
Version: v1.2.5

Thanks for the feedback. It seems that the storing avatars relies on absolute paths. Modifying it to a new domain could potentially introduce new issues. Saving them as relative paths might be a better option. 🤔

@LinkinStars
Yeah, uploaded files should be stored as relative paths. And, for those already deployed in production, the fixing should implement a mechanism (maybe an independent command tool) to automatically update existing data.

@LinkinStars I found that all images in a question, answer or avatar have this issue. I've changed the issue title.

I would like to solve this issue once the solution is settled. 👀

Fwiw, I ran into this issue with logo and favicon as well under the branding settings when originally testing how to go about setting up answer.

@LinkinStars Thank you for your detailed response!
⚠ I haven't read much of the relevant code yet so I might miss some background knowledge of Answer. I'll make a summary to see if I have understood correctly.
I am also in favor of building this functionality as a ./answer command option.
And let's split a URL into 2 major parts for the convenience in describing:

PROTOCOL://HOSTNAME:PORT
PATH

BASE_PATH
RELATIVE_PATH

I think the ABSOLUTE_IMAGE_PATH could be renamed to IMAGE_PATH_PREFIX (if there will be other types of files in the future, maybe it could be UPLOADS_PATH_PREFIX).
There are 2 major types of uploaded files:

For any external storage provided by 3rd-party services (S3, OSS, ...), files are stored as PROTOCOL://HOSTNAME:PORT + PATH in DB with no doubt.
For files stored locally, application codes can directly use IMAGE_PATH_PREFIX + RELATIVE_PATH, only RELATIVE_PATH is stored in DB. This usage of IMAGE_PATH_PREFIX can be delivered by documentation:

2.1. By default, the value of IMAGE_PATH_PREFIX is /
2.2. For files need to be moved to a new directory, the value of IMAGE_PATH_PREFIX is BASE_PATH (e.g. new/dirname/)
2.3. For files need to be moved to another self-hosted place different from the Answer instance, the value of IMAGE_PATH_PREFIX is PROTOCOL://HOSTNAME:PORT + BASE_PATH (e.g. https://statics.self-hosted.com/uploads/)

Pseudocode:
// When fetching existing data to rewrite:
getImageURL(image) {
    if (isSelfHosted(image)) {
        return IMAGE_PATH_PREFIX + image.path;
    } else {
        return image.path;
    }
}

As for the ./answer fix image from a to b command, I think the from a and to b args are not needed. Because what are stored in DB are always RELATIVE_PATHs.

Or, are the two args used for auto-migrating uploaded files (mv SRC DST)?
The description above assumes that an admin move uploaded files manually.

This task seems heavy for a Go & Answer beginner (exactly me 🤣).
If the coding job is real complicated under your estimation, I think it's better be done by your team.

Take it easy. You can try your best, and we will help you solve any problems together. 💪

@LinkinStars Okay then, I'll give it another try.

@LinkinStars
I have another thought on external storage type...
If the uploads dataset is huge, the migration could be very time-consuming because it needs to query & filter out all urls of avatars and urls in texts of questions & answers, and then write them back to DB.
What if Answer saves all types of uploads with relative paths with a prefix marker? Like: :NUM:/uploads/post/57pxxvykQFj.jpeg
:NUM: is a storage url prefix version number. And the version number maps to a URL prefix string, which is used to replace the :NUM: marker in a relative path stored in DB.
The default value of NUM is 0 mapping to "/", it deals with local uploads type. When an Answer admin decides to move the uploads directory to another path, the admin just needs to change 0 to map to "/new/path" after files are settled down.
If the admin adds an external storage, since there is a visit_url_prefix config field for every storage plugin, Answer knows if it is a new prefix. If it is, it increases NUM, and set it as active so that any subsequent uploads use the new active NUM.
Let's say there is a new type of site_info called uploads, it looks like:
{
    "url_prefix_versions": {
        // ":0:/uploads/post/57pxxvykQFj.jpeg"
        "0": "/",

        // ":1:/uploads/post/57pxxvykQFj.jpeg"
        "1": "https://s3.east-1.xxx.com/",

        // ":2:/uploads/post/57pxxvykQFj.jpeg"
        "2": "https://abc.oss-cn-hangzhou.aliyuncs.com/",

        ...
    },

    "url_prefix_versions_active": 1,
    // or [1, 2, ...] if Answer is to support multiple storages at the same time

    // other properties...
}

With this solution, those relative paths hardly need to be changed.
The basic migrate operation process is:

The admin copies their uploads to another place.
Then the admin updates the corresponding NUM's mapping.
The admin now can delete uploads in the old place.

And still, ./answer migrate image from_a to_b could be treated as the last resort to rewrite paths in DB. But if the version number solution is adopted, this migrate functionality is better be integrated in the admin UI. It can provide migration status like progress, affected number of urls, etc.
However, migration of large dataset may not be common. The consideration is whether it is worth implementing such a feature to address a rare scenario.
If this idea is rejected, I will try to implement the previously discussed solution.

@LinkinStars Okay, it was just a thought. 👀
I would like to confirm some details:
The env var
Does this var need to be supported both in Config File and Environment Variable?

In config file: service_config.upload_url_prefix

Used when site is running.

Environment Variable: UPLOAD_URL_PREFIX

Used for installation

Default value: "/"

It actually affects all kinds of uploads, so I think upload is more proper. And it may include PROTOCOL://HOSTNAME:PORT, so UPLOAD_URL_PREFIX is better than UPLOAD_PATH_PREFIX.
The command
./answer fix upload PREFIX_SRC PREFIX_DST

Additionally, there is another requirement. We believe it would be helpful to provide an environment variable, ABSOLUTE_IMAGE_PATH, which users can set to true. In this way, Answer will default to using absolute paths for storing images. This consideration is made for existing users who may copy the content to other places where the images won't display if relative paths are used.

@LinkinStars I made some attempts on the var part. The consideration you mentioned before (I made it bold & italic) seemd hard to achieve: The var (UPLOAD_URL_PREFIX) is closely associated with service_config.upload_path.

If an admin moves the uploaded files locally, they need to change service_config.upload_path at the same time:

And Answer's static router also needs to be changed: https://github.com/Octobug/incubator-answer/blob/8a8086c87b188e60d9310e234fc3c5353c43f46e/internal/router/static_router.go#L42
Otherwise they need to use other static server (e.g. Nginx) to serve the files. Is this acceptable?

Now I prefer to tell admins to use a symlink. 🤔

If an admin moves the uploaded files to other host that needs to be accessed via an absolute URL, UPLOAD_URL_PREFIX doesn't help at all. Because service_config.upload_path cannot reach to other host.

This var seems to be unnecessary for absolute URLs. Uploading files via plugins also doesn't need it.

@Octobug 🤔 I got it. So, for now, we can consider only three scenarios:

Using relative paths: UPLOAD_URL_PREFIX defaults to "/"
Using absolute paths with the website domain: UPLOAD_URL_PREFIX is "http://answer.cn:8080/"
Using absolute paths with a third-party service: UPLOAD_URL_PREFIX is "https://s3.east-1.xxx.com/" (Of course, this scene is already handled by the plugin. Just an example.)

~This consideration is made for existing users who may copy the content to other places where the images won't display if relative paths are used.~ That would simplify the problem. What do you think?

@LinkinStars
Right, there are three scenarios for now. But scenario 2. seems weird 🤔. What benefits does storing absolute URLs bring (we don't have disagreement on 3.)? The only benefit I can think of is that admins can use a reverse proxy server (like Nginx) to route the requests of these absolute URLs to where those uploaded files are.

@LinkinStars Aha. Okay, I'll submit a PR a few days later (with the fix command). Thank you for your patience!

@LinkinStars Okay, thank you for your patience! In this case, it seems that your first solution is better. :D That is, make the var a boolean. Although the name may need to be changed from ABSOLUTE_IMAGE_PATH to UPLOAD_ABSOLUTE_URL.

UPLOAD_USE_ABSOLUTE (I prefer this one)

@Octobug 😄 Maybe we can use UPLOAD_USE_ABSOLUTE_URL. Thanks for your patience as well. This whole discussion has made the whole issue more clear.

@LinkinStars Aha, okay. I'll submit a PR a few days later together with the fix command.

@LinkinStars Here's my version of the fix command, I would like to know your opinion. 👀
answer fix upload SRC_PREFIX DST_PREFIX [--continue] [--offline|online] [--dry-run] [--limit]
When the fix command starts, it checks if there is a tmp file: .fix_upload_interrupted.

If there isn't, it generates one.
If there is, it tells the user that the previous fix was interrupted, and the user need to remove the file if they are to start a fresh fix, or use the --continue switch to continue.
When there isn't any data left that matches the SRC_PREFIX, it removes .fix_upload_interrupted then exit.

Switches:

--continue: the execution might be interrutped, some of the data is rewritten and the rest of them isn't. It works with the .fix_upload_interrupted.

All data that matches the DST_PREFIX will be ignored.

--offline: it requires the admin to shut down the Answer site, and it works in batch mode.
--online: it allows the fix to happen when a Answer site is up. It fixes a row of data one at a time, and it locks the data preventing it from being load into the web editor, so that the user won't submit the wrong version of links after the fix is done.

But this kind of "read lock" seems impossible. I haven't done any research on it. This switch might not be feasible.

If it is feasible in go command, I would like to implement smaller granularity fix: fix upload [branding|avatar|quesition]
--dry-run: only do the test, shows what data will be affected, and shows the "before" and "after", with a limit (e.g. first 10 entries).
--limit: fix limit rows and exit.

@Octobug Very thoughtful consideration. I have only one suggestion. I recommend that this command be run offline, but it's not mandatory. It would be advisable to include instructions in the documentation, suggesting users to run it offline. Otherwise, it would require handling various unexpected concurrency situations, such as table locking, which would make the implementation more complex. 🤔

Okay. I have the feeling that I will give up the --online switch. :D


Introduces the ability to add custom template expression (Issue #44)

Added a renderer object to keep track of available expressions and the functions that return what to replace them with.
I used the new renderer for all the existing expression and exposed it's register function so that new expressions can be added from the user's configurations.

Thanks


Roll our own continue-on-error

Following the adventures of #208 and seeing that it wasn't magically fixed when I merged it, I think it's easiest to just do our own thing.

Personally I think it would be better for us to figure out out how to make continue on error work.
I'll spend a little time on this today.


upgrade to ids 2.5 version and automapper 8.1.1 crash

when i open the url http://localhost:9000/Configuration/Clients
and throw an unhandled exception
it is automapper 8.1.1 version problem
MissingMethodException: Method not found: 'AutoMapper.IMappingExpression2<!0,!1> AutoMapper.IMappingExpression2.ConstructUsing(System.Linq.Expressions.Expression1<System.Func2<!0,!1>>)'.
Skoruba.IdentityServer4.Admin.BusinessLogic.Mappers.ClientMapperProfile..ctor()
TargetInvocationException: Exception has been thrown by the target of an invocation.
System.RuntimeTypeHandle.CreateInstance(RuntimeType type, bool publicOnly, bool wrapExceptions, ref bool canBeCached, ref RuntimeMethodHandleInternal ctor)
TypeInitializationException: The type initializer for 'Skoruba.IdentityServer4.Admin.BusinessLogic.Mappers.ClientMappers' threw an exception.
Skoruba.IdentityServer4.Admin.BusinessLogic.Mappers.ClientMappers.ToModel(PagedList clients)
TargetInvocationException: Exception has been thrown by the target of an invocation.
System.RuntimeTypeHandle.CreateInstance(RuntimeType type, bool publicOnly, bool wrapExceptions, ref bool canBeCached, ref RuntimeMethodHandleInternal ctor)
System.RuntimeType.CreateInstanceSlow(bool publicOnly, bool wrapExceptions, bool skipCheckThis, bool fillCache)
System.Activator.CreateInstance()
AutoMapper.Configuration.MapperConfigurationExpression.AddProfile() in MapperConfigurationExpression.cs
AutoMapper.MapperConfiguration.Build(Action configure) in MapperConfiguration.cs
AutoMapper.MapperConfiguration..ctor(Action configure) in MapperConfiguration.cs
Skoruba.IdentityServer4.Admin.BusinessLogic.Mappers.ClientMappers..cctor()

How did you solve this issue?
Thanks.

https://github.com/AutoMapper/AutoMapper/issues/3117

Thanks 👍🏼

I suppose if you upgrade ids to 2.5.0 and Automapper to 8.1.1 (this version is in the dependencies here https://www.nuget.org/packages/IdentityServer4.EntityFramework.Storage/), it should resolve the issue

Even more, it's discussed here https://github.com/IdentityServer/IdentityServer4/issues/3227 and the issue is part of Release Notes https://github.com/IdentityServer/IdentityServer4/releases


[Language Text] Add support for entity resolution in NER

See swagger for details.

This has been addressed


Error When Switching Buffers

Description
When switching between buffers quickly I receive an error.
Expected Behavior
I expect to be able to switch windows at any speed without seeing lspsaga errors.
Actual Behavior
Error executing vim.schedule lua callback: ...josh/.vim/plugged/lspsaga.nvim/lua/lspsaga/lightbulb.lua:30: line value outside range
stack traceback:
        [C]: in function 'nvim_buf_set_extmark'
        ...josh/.vim/plugged/lspsaga.nvim/lua/lspsaga/lightbulb.lua:30: in function '_update_virtual_text'
        ...josh/.vim/plugged/lspsaga.nvim/lua/lspsaga/lightbulb.lua:73: in function 'render_action_virtual_text'
        ...josh/.vim/plugged/lspsaga.nvim/lua/lspsaga/lightbulb.lua:113: in function 'callback'
        ...Cellar/neovim/0.7.2_1/share/nvim/runtime/lua/vim/lsp.lua:1535: in function 'handler'
        ...Cellar/neovim/0.7.2_1/share/nvim/runtime/lua/vim/lsp.lua:1025: in function ''
        vim/_editor.lua: in function <vim/_editor.lua:0>

Details
From what I've seen this happens when I'm switching from code which contains code actions, which I believe is why it's referencing lightbulb.lua.

nvim --version output:

NVIM v0.7.2
Build type: Release
LuaJIT 2.1.0-beta3
Compiled by brew@Monterey

Features: +acl +iconv +tui
See ":help feature-compile"

   system vimrc file: "$VIM/sysinit.vim"
  fall-back for $VIM: "/usr/local/Cellar/neovim/0.7.2_1/share/nvim"

Run :checkhealth for more info

Operating system:
MacBook Pro version 12.5
lspsaga commit:
9922e17c8e535328462fa246cc8fde32d9f72371

Please provide reproduce step with min config . I can't reproduce your problem.

I can't reproduce after upgrading.


Recreate Auth0 under different subdomain

Currently the subdomain used is humancellatlasstaging.auth0.com. It needs to be changed to something more appropriate. This will mean migrating the existing configurations to a new auth0 tenant.

Currently blocking on getting a google service account to setup google as an OIDC provider in auth0

Complete! the new auth domain is czi-single-cell.auth0.com


Functor instance invalid

The Elem constructor is strict in v, which is bogus for a Functor. The constructor should be made lazy, and the forcing done by other functions.

You are right that it is overly strict for fmap (f . g) = fmap f . fmap g to hold in the case of bottoms. For example fmap (const () . const undefined) == fmap (const ()) . fmap (const undefined) does not hold. However, I do wonder in what cases that is that an actual problem? I wonder in particular, as I really like my data-structures to be unable to contain any thunk if they are in WHNF. This makes a common class of space leaks just go away.
Put differently I currently believe that it is OK or even preferable for data structures that do not model control to be this strict. It is clear to me that for Applicative and Monad we want to have the lazy versions that can deal with bottoms. It is not yet clear to me, what we loose from an overly strict Functor that is not an Applicative.


Download Error "as no match could be found on youtube"

I'm having a problem when I download a song or playlist from spotify but I never had a problem with spotdl, I always use it and it works great for me (thanks to the developers for that).
I use the "spotdl" command with the playlist or song link. The following error appears on the console: "as no match could be found on youtube".
I hope you can solve it, maybe it is temporary or maybe because of the Google servers crash a few days ago that affected YouTube, however I download from Spotify.
Thank you very much to all!
**daredevil@Mateo-Fumis-PC:**/mnt/c/Users/Mateo/Documents/HACKING/Linux/spotify-downloader$ spotdl https://open.spotify.com/track/2rc7BkzO8qepMFAxHtOrXc
Fetching Song...
Skipping Blanco (https://open.spotify.com/track/2rc7BkzO8qepMFAxHtOrXc) as no match could be found on youtube
  0%|                                                 |ETA: ?, ~min/song

Can reproduce on spotDL v3.1.4 installed from master, and pytube 10.1.0

might be fixed. try installing from master.zip

I have this issue aswell. Reinstalled many times many different things.

Using the master.zip & latest install of ffmpeg
Windows 2004 (OS Build 19041.685)
ffmpeg version 2020-12-15-git-32586a42da-full_build-www.gyan.dev

Same on Debian Linux 4.19.0-13-amd64 #1 SMP Debian 4.19.160-2 (2020-11-28) x86_64 GNU/Linux

Same issue on Anaconda install
Windows 10
spotdl 3.1.4
python 3.8.5
ffmpeg version git-2019-12-23-5b42d33

i got the same problem as well

might be fixed. try installing from master.zip

Not fixed.

here is the Traceback I get when trying to download playlist from master.zip :
Traceback (most recent call last):
  File "C:\Users\avy1\Anaconda3\Scripts\spotdl-script.py", line 33, in <module>
    sys.exit(load_entry_point('spotdl', 'console_scripts', 'spotdl')())
  File "e:\nosave\musique_dl\spotify-downloader-master\spotdl\__main__.py", line 113, in console_entry_point
    downloader.download_multiple_songs(songObjList)
  File "e:\nosave\musique_dl\spotify-downloader-master\spotdl\download\downloader.py", line 88, in download_multiple_songs
    self.downloadTracker.load_song_list(songObjList)
  File "e:\nosave\musique_dl\spotify-downloader-master\spotdl\download\progressHandlers.py", line 177, in load_song_list
    self.backup_to_disk()
  File "e:\nosave\musique_dl\spotify-downloader-master\spotdl\download\progressHandlers.py", line 196, in backup_to_disk
    remove(self.saveFile)
TypeError: remove: path should be string, bytes or os.PathLike, not NoneType
  0%|          |ETA: ?, ~min/song

I'm working on a fix on my fork(https://github.com/k0mat/spotify-downloader/) and will make PR when its finished. Although it's work in progress it should work on most songs and some playlists.
Instruction to use it:
uninstall old versions:
pip uninstall pytube
pip uninstall spotdl

install new versions:
python -m pip install git+https://github.com/nficano/pytube
pip install https://github.com/k0mat/spotify-downloader/archive/next-rel-dev.zip

@k0mat looks good! Can you open a draft PR so we can stay up to date? - Then mark as ready for review, when it's ready.
@MikhailZex can you add @k0mat to the joiners team?

@Silverarmor I've created and updated a PR(https://github.com/spotDL/spotify-downloader/pull/1057). As of this PR spotdl does work correctly, I've succesfully downloaded a ~60 song playlist without errors. But there may be some edge cases when it doesn't, so some problems are to be expected, as usual.
One problem is that currently you have to manually install newest version of pytube python -m pip install git+https://github.com/nficano/pytube that is 10.1.0, 10.0.0 doesn't work

@k0mat Thanks for working on a solution for the problem.
I'm running into an error.
PS C:\Users\user\Music\MUSIC\New Music> spotdl https://open.spotify.com/track/08mG3Y1vljYA6bvDt4Wqkj?si=SxezdxmlTx-CaVoucHmrUA
  0%|                                                                                |ETA: ?, ~min/songTraceback (most recent call last):
  File "C:\Users\user\AppData\Local\Programs\Python\Python39\Scripts\spotdl-script.py", line 33, in <module>
    sys.exit(load_entry_point('spotdl==3.2.0rc0', 'console_scripts', 'spotdl')())
  File "c:\users\user\appdata\local\programs\python\python39\lib\site-packages\spotdl\__main__.py", line 88, in console_entry_point
    downloader.download_single_song(song)
  File "c:\users\user\appdata\local\programs\python\python39\lib\site-packages\spotdl\download\downloader.py", line 283, in download_single_song
    download_song(songObj, self.displayManager, self.downloadTracker)
, in download_song
    youtubeHandler = YouTube(
_
    self.prefetch()
  File "c:\users\user\appdata\local\programs\python\python39\lib\site-packages\pytube\__main__.py", line 183, in prefetch
    self.js_url = extract.js_url(self.watch_html)
  File "c:\users\user\appdata\local\programs\python\python39\lib\site-packages\pytube\extract.py", line 143, in js_url
    base_js = get_ytplayer_config(html)["assets"]["js"]
  File "c:\users\user\appdata\local\programs\python\python39\lib\site-packages\pytube\extract.py", line 202, in get_ytplayer_config
    raise RegexMatchError(caller="get_ytplayer_config", pattern="config_patterns")
pytube.exceptions.RegexMatchError: get_ytplayer_config: could not find match for config_patterns
  0%|                                                                                |ETA: ?, ~min/song

@Mad-Chicken Put that on the PR #1057 please - It is unrelated to this issue.

Ok, was not sure if it was related.
#1058

@Mad-Chicken Post it as a comment on PR #1057.
DO NOT open an issue here for it.

@Mad-Chicken seems like you are not using the latest version of pytube. Try updating it with python -m pip install git+https://github.com/nficano/pytube

I'm working on a fix on my fork(https://github.com/k0mat/spotify-downloader/) and will make PR when its finished. Although it's work in progress it should work on most songs and some playlists.
Instruction to use it:
uninstall old versions:
pip uninstall pytube
pip uninstall spotdl

install new versions:
python -m pip install git+https://github.com/nficano/pytube
pip install https://github.com/k0mat/spotify-downloader/archive/next-rel-dev.zip

Tried these 4 commands to get it working - I still get "path should be string, bytes or os.PathLike, not NoneType"

@k0mat @Mad-Chicken @outerepic
Lets keep discussion about this fork on the PR (#1057) please. Avoid cluttering up this issue. Further comments about the PR/fork will be deleted for sake of keeping this issue easier to read.

@k0mat Thanks for working on a solution for the problem.
I'm running into an error.
PS C:\Users\user\Music\MUSIC\New Music> spotdl https://open.spotify.com/track/08mG3Y1vljYA6bvDt4Wqkj?si=SxezdxmlTx-CaVoucHmrUA
  0%|                                                                                |ETA: ?, ~min/songTraceback (most recent call last):
  File "C:\Users\user\AppData\Local\Programs\Python\Python39\Scripts\spotdl-script.py", line 33, in <module>
    sys.exit(load_entry_point('spotdl==3.2.0rc0', 'console_scripts', 'spotdl')())
  File "c:\users\user\appdata\local\programs\python\python39\lib\site-packages\spotdl\__main__.py", line 88, in console_entry_point
    downloader.download_single_song(song)
  File "c:\users\user\appdata\local\programs\python\python39\lib\site-packages\spotdl\download\downloader.py", line 283, in download_single_song
    download_song(songObj, self.displayManager, self.downloadTracker)
, in download_song
    youtubeHandler = YouTube(
_
    self.prefetch()
  File "c:\users\user\appdata\local\programs\python\python39\lib\site-packages\pytube\__main__.py", line 183, in prefetch
    self.js_url = extract.js_url(self.watch_html)
  File "c:\users\user\appdata\local\programs\python\python39\lib\site-packages\pytube\extract.py", line 143, in js_url
    base_js = get_ytplayer_config(html)["assets"]["js"]
  File "c:\users\user\appdata\local\programs\python\python39\lib\site-packages\pytube\extract.py", line 202, in get_ytplayer_config
    raise RegexMatchError(caller="get_ytplayer_config", pattern="config_patterns")
pytube.exceptions.RegexMatchError: get_ytplayer_config: could not find match for config_patterns
  0%|                                                                                |ETA: ?, ~min/song

I am running into the same error :(

Working on my side!
good job :)

Working on my side!
good job :)

Hi Arcyno,
What are you doing differently?
uninstall old versions: pip uninstall pytube pip uninstall spotdl Install new versions:  python -m pip install git+https://github.com/nficano/pytube  pip install https://github.com/k0mat/spotify-downloader/archive/next-rel-dev.zip

I have done exactly as mentionned in the previous post that you quoted.
To be more exact I use anaconda environment, with python 3.8.5

After getting it working, the songs are sometimes live versions and they're radio versions, so no swearing

Hello,
Just wanted to mention that the "could not find match for config_patterns" error was fixed in pytube 10.4.1 for me and now I can download normally 👍
Many thanks to the devs working on this!
python -m pip install git+https://github.com/nficano/pytube
pip show pytube
Name: pytube
Version: 10.4.1

Hi everyone, still getting this issue due to a versioning related issue with pytube.
This install command installs pytube3 and not pytube. The pytube3 version from pypi and github is 9.6.4 which has the regex problem and some other problems once the regexes are ported from head.

pip install spotdl
...
Installing collected packages: pytube3
Successfully installed pytube3-9.6.4

How can I use pytube 10.x.x instead of pytube3 9.x.x for my spotdl invocations?
Thanks!

Hi everyone, still getting this issue due to a versioning related issue with pytube.
This install command installs pytube3 and not pytube. The pytube3 version from pypi and github is 9.6.4 which has the regex problem and some other problems once the regexes are ported from head.

pip install spotdl
...
Installing collected packages: pytube3
Successfully installed pytube3-9.6.4

How can I use pytube 10.x.x instead of pytube3 9.x.x for my spotdl invocations?
Thanks!

@ZhouYii did you even read any of the above comments? Multiple answer your question.
pip uninstall pytube
python -m pip install git+https://github.com/nficano/pytube
pip show pytube

@ZhouYii did you even read any of the above comments? Multiple answer your question.
pip uninstall pytube
python -m pip install git+https://github.com/nficano/pytube
pip show pytube

I can still reproduce this error:
spotdl installed from master, 3.1.4, commit hash 162d7ce
pytube installed from master, 10.4.1
pip cache was cleared,
Issue staying open.

I can still reproduce this error:
spotdl installed from master, 3.1.4, commit hash 162d7ce
pytube installed from master, 10.4.1
pip cache was cleared,
Issue staying open.

I think @ZhouYii means that, even if you manually install pytube, spotdl (either the default version from pip or @k0mat 's version) actually is using pytube3, which is unaltered by the manual install of pytube and thus kept at v9.6.4. I'm having the same issue whatever I try, and am unable to download anything (playlists, albums or individual songs). Specifically:
With pip3 install spotdl and pip3 install https://github.com/spotDL/spotify-downloader/archive/v3.1.0.zip (which are probably the same thing), before and after uninstalling and manually installing pytube with pip3 install git+https://github.com/nficano/pytube:

playlist and album download attempts give error TypeError: remove: path should be string, bytes or os.PathLike, not NoneType
track download attempts give error Skipping . . . as no match could be found on youtube

With pip3 install https://github.com/spotDL/spotify-downloader/archive/master.zip, before and after uninstalling and manually installing pytube with pip3 install git+https://github.com/nficano/pytube:

playlist and album download attempts give error TypeError: cannot unpack non-iterable NoneType object
track download attempts give error  Skipping . . . as no match could be found on youtube

With @k0mat's version, before and after uninstalling and manually installing pytube with pip3 install git+https://github.com/nficano/pytube:

playlist and album downloads fetch the track list, then get stuck at TypeError: __init__() missing 1 required positional argument: 'pattern' (or at least I get bored of waiting at that point)
track download attempts give error  Skipping . . . as no match could be found on youtube

Also, both @k0mat 's version and v3.1.0 install (and thus use, I guess) pytube3 which, as I said, is unaffected by manual reinstall of pytube (pip3 show pytube gives v10.4.1, pip3 show pytube3 gives v9.6.4). Just installing spotdl with pip3 appears to use a-pytube-fork-for-spotdl-users v.9.6.4, so presumably also unaffected by manual reinstalls of pytube.
I'm probably not being of much help, just wanted to confirm that the error persists and I haven't been able to find a combination that works. If I'm leaving something out please let me know, and thanks to all the developers for your work.

I think @ZhouYii means that, even if you manually install pytube, spotdl (either the default version from pip or @k0mat 's version) actually is using pytube3, which is unaltered by the manual install of pytube and thus kept at v9.6.4. I'm having the same issue whatever I try, and am unable to download anything (playlists, albums or individual songs). Specifically:
With pip3 install spotdl and pip3 install https://github.com/spotDL/spotify-downloader/archive/v3.1.0.zip (which are probably the same thing), before and after uninstalling and manually installing pytube with pip3 install git+https://github.com/nficano/pytube:

playlist and album download attempts give error TypeError: remove: path should be string, bytes or os.PathLike, not NoneType
track download attempts give error Skipping . . . as no match could be found on youtube

With pip3 install https://github.com/spotDL/spotify-downloader/archive/master.zip, before and after uninstalling and manually installing pytube with pip3 install git+https://github.com/nficano/pytube:

playlist and album download attempts give error TypeError: cannot unpack non-iterable NoneType object
track download attempts give error  Skipping . . . as no match could be found on youtube

With @k0mat's version, before and after uninstalling and manually installing pytube with pip3 install git+https://github.com/nficano/pytube:

playlist and album downloads fetch the track list, then get stuck at TypeError: __init__() missing 1 required positional argument: 'pattern' (or at least I get bored of waiting at that point)
track download attempts give error  Skipping . . . as no match could be found on youtube

Also, both @k0mat 's version and v3.1.0 install (and thus use, I guess) pytube3 which, as I said, is unaffected by manual reinstall of pytube (pip3 show pytube gives v10.4.1, pip3 show pytube3 gives v9.6.4). Just installing spotdl with pip3 appears to use a-pytube-fork-for-spotdl-users v.9.6.4, so presumably also unaffected by manual reinstalls of pytube.
I'm probably not being of much help, just wanted to confirm that the error persists and I haven't been able to find a combination that works. If I'm leaving something out please let me know, and thanks to all the developers for your work.

I also experienced all of that and search for thread for countless hours then I wonder if updating to python 3.9 will fix all of my problem. guess what? it fixed all of my problem

I also experienced all of that and search for thread for countless hours then I wonder if updating to python 3.9 will fix all of my problem. guess what? it fixed all of my problem

OK, sorry for the n00b question... I have installed python 3.9 but how do I make it the default python to use? It's installed as python3.9 and python3 --version still says 3.8.5...
I have a faint memory of completely breaking my system the last time I uninstalled (some version of) python, so I'm not confident at all here!

OK, sorry for the n00b question... I have installed python 3.9 but how do I make it the default python to use? It's installed as python3.9 and python3 --version still says 3.8.5...
I have a faint memory of completely breaking my system the last time I uninstalled (some version of) python, so I'm not confident at all here!

Hi all, I wanted to chime in on this thread to resolve the issue with different pytube versions yielding an error on @k0mat 's fork of the repo that would otherwise work well. If the comment should be moved to his PR please let me know, but since there is already paper trail in this issue it looked like the correct place.
@mberasategi mentioned a few comments earlier:

I think @ZhouYii means that, even if you manually install pytube, spotdl (either the default version from pip or @k0mat 's version) actually is using pytube3, which is unaltered by the manual install of pytube and thus kept at v9.6.4. I'm having the same issue whatever I try, and am unable to download anything (playlists, albums or individual songs). Specifically:

I'm probably not being of much help, just wanted to confirm that the error persists and I haven't been able to find a combination that works. If I'm leaving something out please let me know, and thanks to all the developers for your work.

You were actually of great help :). I checked the site-packages location for a fresh Python install, and discovered that both pytube and pytube3 are installed under the same import name pytube. So they collide, probably causing the unpredictable behavior.
With that knowledge I was able to reproduce both the Regex error, and get a fix for it, using a fresh install in Miniconda (feel free to use your own flavor or re-use an existing env), by first installing the fork, and then overwriting the existing pytube3 install with the newest pytube version.
conda create -y -n spotdl python=3.8 && conda activate spotdl
pip install https://github.com/k0mat/spotify-downloader/archive/next-rel-dev.zip
pip uninstall pytube3 -y
python -m pip install git+https://github.com/nficano/pytube

I can confirm the correct pytube version is installed via python ~/<virtual env root folder>/envs/spotdl/lib/python3.8/site-packages/pytube/version/py which gives me 10.4.1

Hi all, I wanted to chime in on this thread to resolve the issue with different pytube versions yielding an error on @k0mat 's fork of the repo that would otherwise work well. If the comment should be moved to his PR please let me know, but since there is already paper trail in this issue it looked like the correct place.
@mberasategi mentioned a few comments earlier:

I think @ZhouYii means that, even if you manually install pytube, spotdl (either the default version from pip or @k0mat 's version) actually is using pytube3, which is unaltered by the manual install of pytube and thus kept at v9.6.4. I'm having the same issue whatever I try, and am unable to download anything (playlists, albums or individual songs). Specifically:

I'm probably not being of much help, just wanted to confirm that the error persists and I haven't been able to find a combination that works. If I'm leaving something out please let me know, and thanks to all the developers for your work.

You were actually of great help :). I checked the site-packages location for a fresh Python install, and discovered that both pytube and pytube3 are installed under the same import name pytube. So they collide, probably causing the unpredictable behavior.
With that knowledge I was able to reproduce both the Regex error, and get a fix for it, using a fresh install in Miniconda (feel free to use your own flavor or re-use an existing env), by first installing the fork, and then overwriting the existing pytube3 install with the newest pytube version.
conda create -y -n spotdl python=3.8 && conda activate spotdl
pip install https://github.com/k0mat/spotify-downloader/archive/next-rel-dev.zip
pip uninstall pytube3 -y
python -m pip install git+https://github.com/nficano/pytube

I can confirm the correct pytube version is installed via python ~/<virtual env root folder>/envs/spotdl/lib/python3.8/site-packages/pytube/version/py which gives me 10.4.1

Fixed in v.3.2.1

Fixed in v.3.2.1

@Codingboy65

@Codingboy65

Update to v3.3.3

This did not solve anything, same error, am I missing anything?

Please run spotdl https://open.spotify.com/track/0VjIjW4GlUZAMYd2vXMi3b?si=TNiemvONQviXQpWPSiR2Gw and show the exact output

Download worked!

Works fine then. If you get "as no match could be found on youtube", that literally tells you the issue

so spotdl does not work for all songs?

Yeah but if no match is found on YouTube is it supposed to then download it directly from Spotify, or is that not how it works?

Downloading from Spotify violates its TOS.
spotDL downloads from youtube if a match is found


Feature/search zoo datasets

Added ability to list zoo datasets that fit certain criteria. Started with "media_type",
"task", and "max_size" (GB of required download, if full dataset must be downloaded).
`# List all zoo datasets with media_type "image", which support
# "detection" tasks, and which require at most 1GB download.
#
    foz.list_zoo_datasets(
        task="detection",
        media_type="image",
        max_size=1.0,
    )

`
Release Notes

Currently, I'm getting the media_type and task info from the tags property, but this is incomplete - not all datasets have all allowed tasks listed in tags. I think we should create separate properties to list these, as I've done for dataset._download_size, although I am open to changing any/all of this.
Would like to add support for the following: if I check for tasks segmentation, it should return all datasets that have either semantic or instance segmentation. Same idea for classification, detection, etc.
This logic should be able to extend to datasets that users add to the zoo when we build the pytorch wrapper. They would just need to specify these details.
Am I missing anything?

What areas of FiftyOne does this PR affect?

[ ] App: FiftyOne application changes
[ ] Build: Build and test infrastructure changes
[x] Core: Core fiftyone Python library changes
[x] Documentation: FiftyOne documentation changes
[ ] Other

@jacobmarks just following up here: do you think fiftyone zoo datasets list is sufficient or would you like to have a way to discover datasets in Python itself?
Also, thoughts on this question?

Either way, I could see value in wiring up the dataset sizes so that they're visible and potentially filterable via fiftyone zoo datasets list. One sticky point here is that the CLI method breaks things down on a per-split basis, but I don't think we have per split size data in all cases right now.

@brimoor thanks for following up. My thinking is that if someone is doing some exploration in a jupyter notebook, they may want to get a list of available datasets, filterable at least by size and tags, IN the notebook, without leaving the notebook. I know you can do CLI commands from a notebook, but it isn't as natural.
The idea is not to give them full specs on the size of each split of the dataset, but rather to give them the minimum download size so they know if it is worth downloading right then and playing around with. This is in line with the desire to add quickstart-classification, quickstart-pcd, etc.
I also think if we go this direction, we might want to add a kwarg minimum_download = False to datasets, and if set to True, this would grab and download the smallest possible subset of the data (or course, for some datasets this may not make sense). This could be paired with a minimum_download_size (in Python and CLI) which would overcome the splits issue you alluded to.
Thoughts on this?


The main control and the node are currently on the same machine, and the deployed service cannot be started. I looked at the startup script and there is a space in the execution path. What could be the problem?

the framework version is 2.1.0

That version of php has a bug, which was fixed afterwards. Now the more stable version is 2.4, you can upgrade it.

那个版本的php有bug, 之后修复了，现在比较稳定的版本是2.4，可以升级一下。

Docker upgraded from 2.1.0 to 2.4.0 and found that the version number is stored in the data table, is there any effect?

docker从2.1.0 升级2.4.0，发现版本号是存在数据表里的，有影响吗？

This version number can be ignored and is of little use.

这个版本号可以不管，用处不大。

After upgrading from 2.1.0 to 2.4.0, the situation shown in Remark 3 will appear after restarting. But ~ business services can now be executed, what is the reason?

从2.1.0升级到2.4.0，重启以后会有如备注图3所示的情况出现。但~业务服务，现在可以执行，这是什么原因？

These services will not affect the business.

这几个服务挂了也不会影响业务。

In the beginning, these basic services (see the picture above) are all running normally, but business services cannot be started on the platform. What is the reason? The following figure shows the service log.

一开始，这几个基础服务(见上一提问的图)，都运行正常，但业务服务在平台无法启动
这个是什么原因呢？下图是服务日志。

Refresh the status , maybe the status is wrong when the service is started.

刷新一下状态, 可能服务刚起来状态不对。


AddNamedViews and AddNamedOperations don't work in the FederatedStore

The federated store incorrectly automatically overrides the handlers to use a delegate handler.

Merged into develop.


Add [MNWS]Modern Naval Weapon System - AERO pack from SpaceDock

This pull request was automatically generated by SpaceDock on behalf of Johnny005611, to add [MNWS]Modern Naval Weapon System - AERO pack to CKAN.
Mod details:
name = /mod/1923/%5BMNWS%5DModern%20Naval%20Weapon%20System%20-%20AERO%20pack
author = Johnny005611
abstract = MNWS all single-part fighters
license = CC BY SA 4.0
Homepage = https://forum.kerbalspaceprogram.com/index.php?/topic/173339-144mnws-modern-naval-weapon-system-bdac-addon/
description = This part only contains all MNWS single-part fighters and bombers.
No weapon included.
Better working with mod Single part aviation.
Including:
CFA44A
DRAGON
EDI
F15E
F16C
F16XL
F22
F35
H20A
H20B
J10
J15
J20
MNWS
NATF MK.I
NATF MK.II
NH80
UCAV MK.I
UCAV MK.II
UH60
V22
Please direct questions about this pull request to Johnny005611.

This was added in #6686.


Broken ellipse after recompiling

I tried to recompile the app with ant -buildfile etc/build/build.xml all and it made all the shapes look a bit different from clean checkout, and made ellipse broken (it became rect) at all — see attached image.
Browser didn't matter, I tried Firefox 49.0 and Chromium 53.0.2785.143.
The problem was reproduced on my Ubuntu 16.10, as well as with clean Docker image with Ubuntu 14.04.
FROM ubuntu:trusty
ADD . /
WORKDIR war
RUN apt-get update -qq
RUN apt-get -y --force-yes install python3.4 patch ant openjdk-7-jdk
RUN ant -buildfile ../etc/build/build.xml all
RUN echo $'import http.server, socket, sys\n\
class V6(http.server.HTTPServer):\n\
  address_family = socket.AF_INET6\n\
http.server.test(ServerClass=V6, \n\
                 HandlerClass=http.server.SimpleHTTPRequestHandler, \n\
                 bind="::", \n\
                 port=int(sys.argv[1]))' > /httpserver.py
CMD /usr/bin/python3.4 /httpserver.py 80

Any errors on the console?

No errors, but a number of warnings: http://pastebin.com/Ar0f17Bu

I mean the browser console when you run the app. If you have dev=1 set you need mxGraph correctly available as described in https://github.com/jgraph/draw.io/issues/16.

No, I don't use dev=1.
The only difference Firefox reports in recompiled app:
14:23:12.426 element not found 1 localhost:32787:1:1
14:23:12.451 Synchronous XMLHttpRequest on the main thread is deprecated because of its detrimental effects to the end user's experience. For more help, check http://xhr.spec.whatwg.org/ 1 app.min.js:324:226

Unfortunately I cannot find out, what "element" is written about, since 1:1 is definitely wrong row/column pointer.
Chromium reported only about application cache loading progress, from which I found that recompiled cache.manifest is empty:
CACHE MANIFEST

# THIS FILE WAS GENERATED. DO NOT MODIFY!
# 10/19/2016 03:48 PM

As far as I found, restoring original cache.manifiest doesn't help.
Practically the only thing that changed is theme in app.min.js. To find out what changes, I processed the repository one (old) and recompiled one (new) app.min.js through js-beautifuer and looked at diff.
I found that the only thing changed is line
Graph.prototype.defaultThemes[Graph.prototype.defaultThemeName] = mxUtils.parseXml('%long xml%').documentElement;

after recompilation the inner xml literal is replaced with empty string. So it probably somehow collides with templates compilation.

This will be fixed in the next release (via another repo). Thanks!


Make table view filters configurable

I'm open to discussion on this, but I think the table view default filters should be configurable in some way, since usage of SQL Lab views can vary.
(I also think the UX functionality of the boolean filter field is unintuitive, but that's a separate change.)
@mistercrunch

I agree that the CRUD filter is pretty awful. The goal of the original PR was to remove the clutter related to SQL views.
I'm hoping we can use move away from FAB's crud for this view soon, but in the meantime I'm not sure how to deal with the clutter.
Maybe we need 2 different ModelView classes which lead to 2 different menu items one for views and one for table.

Codecov Report

Merging #5583 into master will increase coverage by <.01%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master    #5583      +/-   ##
==========================================
+ Coverage   63.58%   63.58%   +<.01%
==========================================
  Files         358      358
  Lines       22742    22743       +1
  Branches     2530     2530
==========================================
+ Hits        14461    14462       +1
  Misses       8266     8266
  Partials       15       15

Impacted Files
Coverage Δ

superset/connectors/sqla/views.py
64.65% <100%> (+0.3%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 39ff9de...2d581be. Read the comment docs.

@jeffreythewang you may also need to update this logic: https://github.com/apache/incubator-superset/blob/master/superset/connectors/sqla/models.py#L892.

@john-bodley I just realized this filter is being applied. If I'm reading this correctly, this means that non-admins are not able to view or edit datasources created via SQL Lab. Is that intentional?

My bad. I realized we do an additional permissions check internally that runs through that default_query when editing tables. However, I can see some issues with applying that filter to the underlying default_query when the intention was just to remove clutter from the table list. Is there a particular reason why the filter exists there as well as in the URL params?


remap 'ctrl+k' as new 'leader' key

There are many key bindings start with 'ctrl+k', so the 'ctrl+k' is like the 'leader' key in Vim. But I have bound 'ctrl+k' to a new shortcut, so all the key bindings strat with 'ctrl+k' were invalid. Please provide a way to remap 'ctrl+k' as new leader key.

@GraysonGao does this SO post help you?
https://stackoverflow.com/questions/51907158/how-to-remap-all-ctrlk-chords-at-once-in-vscode

@GraysonGao does this SO post help you?
https://stackoverflow.com/questions/51907158/how-to-remap-all-ctrlk-chords-at-once-in-vscode

That really works! Thank you very much. Although there are many "ctrl+k" shortcuts, I only use a few of them, it's OK to remap manually.


eslint version is unsupported

Describe what should be investigated or refactored
=============

WARNING: You are currently running a version of TypeScript which is not officially supported by @typescript-eslint/typescript-estree.

You may find that it works just fine, or you may not.

SUPPORTED TYPESCRIPT VERSIONS: >=4.3.5 <5.4.0

YOUR TYPESCRIPT VERSION: 5.5.4

Please only submit bug reports when using the officially supported version.

closed, we fixed this manually