Simulator Tests in CI

Add 3 tests to verify bridge.py and the all processes of manager.py correctly startup and keep running for 60 seconds. Each need Carla simulator to run in parallel.
First two test simply verify that connection to Carla is possible and that bridge.py works as expected.
The third runs manager and bridge. Checks processes are running and that car can be engaged.
Bridge.py looks like a lot of changes but it is mostly creating a Bridge class and putting some functionality in functions
Also speeds up simulation by changing post processes to false
Failed rebasing from https://github.com/commaai/openpilot/pull/24009 so new pr here.

Tried running the tests on my computer, but ran into a few issues:

The tests wasn't actually waiting for messages to come in. Be careful when using submaster, if no messages have been received yet all struct values will have their default values. Already fixed this by adding a check for sm.all_alive()
Carla seems to segfault sometimes when one of the test exits. Can we fix this by closing the connection properly?
Shutting down the tests always fails with AssertionError: can only join a child process, causing the exit code to be negative
I'm seeing some time.sleep() to wait for things to come online. Those sleeps are usually flaky and cause unnecessary random test failures, and in the best case they make the tests slower than needed. Replace those by checking for the actual condition (e.g. is bridge running correctly), and add a high upper bound (like you do for the engaged checks).

Thanks for the improvements. I removed some time.sleep calls and all the processes should close safely now.

To engage openpilot press 1 a few times while focused on bridge.py to increase the cruise speed.

I guess this commit broke the keyboard control (Cruise_up).


pgvecto-rs: How does pgvectorscale compare to pgvecto-rs? Where pgvecto-rs is also built with Rust and pgrx.

How does pgvectorscale compare to pgvecto-rs? Where pgvecto-rs is also built with Rust and pgrx.

Different set of indexes. Pgvectorscale adds disk-friendly indexes, while pgvecto-rs seems to add more functionality around existing pgvector index types


Make Event#property take Object

Given that the properties is a map from String to Object, there's no need to restrict values to be Strings

True, good point!


10640 owner builder enabled check fix

Fixes #10640
Basically if an owner was editor and his org gets builder, he will still be editor because of former builder_enabled?check.
It looks like there was a good reason for this to be how it was, so please explain @javitonino :)

Feature, not bug!


Add feature for tasks to be able to add multiline tasks

Currently, tasks are only single-lined. Add feature for tasks to be able to add multiline tasks.

I will try this out too. Can I work on this?

@PriyavKaneria Sure go ahead. 😄

@sanskaromar Raised a PR can you please review it


Update ## Configuring a custom message

Added a link to the configuration part.
Sorry that I forget to update this part.

Any comments?

Oops sorry


Change the resend verification link to a reply form with post request.

This fixed #560
I tried to keep it in the same style as the existing link but maybe I missed something.
By default my editor removed white spaces on the end of the line. If wanted I will revert that part.

Perfect. Thanks @tvbeek!


Make compatible with Python 3

This should be pretty easy--mostly just augmenting 2to3 output.

PR merged. Thanks!


type declarations for exported items

Hey Ben!
Thanks a lot for your contribution! We will check this 👍🏼


Add TNGF

revise from Add TNGF #121
please review ngap PR first for supporting the ngap type

Hi @Hiro6666
Please help to fix the conflicts.
Thanks!

Already fixed, @ianchen0119 please review.
Tks !

Run the following commands to update ngap package. This would help you pass the CI.
go get github.com/free5gc/ngap@main
go mod tidy


Vanilla deployment fails due to timeout in oidc-authservice

Describe the bug
I was deploying kubeflow 1.7 with provided instructions using the manifests. After reviewing the pod status, the pods/authservice-0 continued to remain in pending status as it was not able to create a PVC.
==========Installing oidc-authservice==========
Release "oidc-authservice" does not exist. Installing it now.
NAME: oidc-authservice
LAST DEPLOYED: Thu May 11 12:52:44 2023
NAMESPACE: default
STATUS: deployed
REVISION: 1
TEST SUITE: None
Waiting for oidc-authservice pods to be ready ...
running command: kubectl wait --for=condition=ready pod -l 'app in (authservice)' --timeout=240s -n istio-system
error: timed out waiting for the condition on pods/authservice-0
Waiting for oidc-authservice pods to be ready ...
running command: kubectl wait --for=condition=ready pod -l 'app in (authservice)' --timeout=240s -n istio-system
error: timed out waiting for the condition on pods/authservice-0
Waiting for oidc-authservice pods to be ready ...
running command: kubectl wait --for=condition=ready pod -l 'app in (authservice)' --timeout=240s -n istio-system

Steps To Reproduce
Follow vanilla deployment steps.
Expected behavior
Vanilla deployment should without any issues.
Environment

Kubernetes version : 1.25
Using EKS (yes/no), if so version? 1.25
Kubeflow version: v1.7.0
AWS build number: aws-b1.0.0
AWS service targeted (S3, RDS, etc.)

Screenshots
If applicable, add screenshots to help explain your problem.
Additional context
I manually installed the EBS CSI driver and that resulted in the PV and PVC being created successfully. We should probably update the eksctl command here and make the corresponding changes in the terraform deployment as well.

We have it as a step in documentation pointing to steps in EKS docs - https://awslabs.github.io/kubeflow-manifests/docs/deployment/create-eks-cluster/#important-if-you-are-using-an-eks-version--123-install-the-amazon-ebs-csi-driver-by-following-the-instructions-herehttpsdocsawsamazoncomekslatestuserguideebs-csihtml since eksctl did not have single line argument for this
It is installed by default in terraform deployment.

Oops, sorry I missed that. It is possible to launch add-ons via eksctl. See https://eksctl.io/usage/addons/.

@askulkarni2 I am seeing same issue even after adding EBS CSI add on.
It seems like, the PVC is not being created for authservice-0 pod in istio-system namespace. So, its just in pending stage.
Did you have to do anything else after adding EBS CSI driver?

@paravatha feel free to open a new issue if it is not resolved. Also, check the ebs csi driver pod logs to see if there are any errors.


Watched spending: don't import to watching wallet

We don't need to import an address from the spending wallet to the watching wallet to be able to watch it; every address of the node's wallets will trigger a walletnotify action.
Currently we systematically import a watched address to the watching wallet even if it's a spending address, so we have a lot of addresses in both wallets for no gains.

Added optional callback urls to getnewaddress so CN can add a watch in a single call.  The clients won't have to call getnewaddress followed by a watch request of this newaddress anymore

Did you also remove the importaddress to the watching wallet when trying to watch a spending wallet address?

Can't find those changes locally.  Maybe changed my mind also : let the caller do the 2 calls and wrap those 2 calls into something called watchNewBitcoinAddress


Update notebooks and bug fix

Update the notebooks to the latest solver.

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 66.4%. Comparing base (45409b9) to head (964665c).

Additional details and impacted files
@@          Coverage Diff          @@
##            main     #18   +/-   ##
=====================================
  Coverage   66.4%   66.4%
=====================================
  Files         11      11
  Lines       1351    1352    +1
=====================================
+ Hits         898     899    +1
  Misses       453     453

Flag
Coverage Δ

unittests
66.4% <100.0%> (+<0.1%)
:arrow_up:

Flags with carried forward coverage won't be shown. Click here to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


Formatting is breakin while pasting value like this "1111 1111", if mask is space

Paste value like this "1111 1111 1111" breaks formatting in insertRawSubstr if maskChar is space.

import InputMask from 'react-input-mask'
....
            <InputMask
                maskChar=" "
                mask="9999-9999-9999"
                value={value}
            />

@zerkalica Can't merge this PR because we need to be able copy and paste back whole string from input without changes even if value have some spaces, like "1111-11  -1   ". I implemented another workaround for broken formatting, please try to build and test latest version from this repo.

Ok, thanks


document the supported module formats

Improve installation docs to mention support for:

ESM
CommonJS
TypeScript

Fixed in v1.2.0


override the change_form to add few more dependency to display markdown editor in form

We have been using markdown for one of the text field, and for our templates we have added the import of required js/html of polymer component in change_form.html under templates/admin/<app_name>. As simple_history uses regular change_form.html template which overrides from admin/change_form.html it doesn't render the field in specific format as required. How do we override the chagne_form.html for the simple_history app?

Can you explain this a little more clearly? Are you referring to object_history_form.html?

Yes. I would like to override some field in the form which is displayed using object_history_form.html.
For one of the text field, I am returning polymer component, and in order to render it correctly, it needs js/html dependency.

So you just want to add the js/html dependency to the page that renders object_history_form.html? For the js, you should be able to use something from here https://docs.djangoproject.com/en/2.0/topics/forms/media/. For the html, you can simply overwrite the form the simple history uses (which is set (here)[https://github.com/treyhunner/django-simple-history/blob/master/simple_history/admin.py#L26]). So within the admin you can write
class TestAdmin(SimpleHistoryAdmin):
    object_history_form_template = 'templates/admin/<app_name>/simple_history_change_form.html`

Works perfectly fine. Thank you.


refactor status with prometheus

Thanks, please fix CI @mxlxm

Thanks, please fix CI @mxlxm

done, sorry for the late response.


Is the project still in maintaining?

The code was last updated on Jan 23, 2021, after one year passed, it still supports cypress 4.5 only, but the latest version is 9.5.
I'm looking forward to the PRs could be reviewed and the upstream project could be going on.

Let's move to fork, what is the best fork of this library?

Removed my fork and recreated as standalone - https://github.com/simonsmith/cypress-image-snapshot
Contributions welcome there


patched again

start.js:17 [Deprecation] Synchronous XMLHttpRequest on the main thread is deprecated because of its detrimental effects to the end user's experience. For more help, check https://xhr.spec.whatwg.org/.
loadFile @ start.js:17
www.googletagmanager.com/gtag/js?id=UA-108811301-1:1 Failed to load resource: net::ERR_BLOCKED_BY_CLIENT
a.pub.network/surviv-io/pubfig.min.js:1 Failed to load resource: net::ERR_BLOCKED_BY_CLIENT
1.3.5.js:2 Uncaught ReferenceError: webpackJsonp is not defined
at 1.3.5.js:2
webpack_override.js:55 Uncaught TypeError: Cannot read property 'prototype' of undefined
at Object.webpack_inject (webpack_override.js:55)
at n (manifest.feb53671.js:1)
at window.webpackJsonp (manifest.feb53671.js:1)
at webpack_inject (webpack_override.js:48)
at webpack_override.js:115
app.81fad321.js:1 Uncaught TypeError: Cannot read property 'stack' of null
at window.onerror (app.81fad321.js:1)
manifest.feb53671.js:1 Uncaught TypeError: Cannot read property 'call' of undefined
at n (manifest.feb53671.js:1)
at Object.yZ5m (1.3.5.js?=1533309954533:42990)
at n (manifest.feb53671.js:1)
at window.webpackJsonp (manifest.feb53671.js:1)
at 1.3.5.js?=1533309954533:2
app.81fad321.js:1 Uncaught TypeError: window.freestar.deleteAdSlots is not a function
at removeAds (app.81fad321.js:1)
at o.ge (app.81fad321.js:1)
at WebSocket.ws.onmessage (app.81fad321.js:1)

Note if you're using AdBlock, you might not be able to click "Quit game" for some reason, dunno if it's just me.

Never mind was just a typo on my end, all works now. 😄


how to auto open all infowindow of my markers using cluster markers?

I know how to show the infowindow of a marker, but in this case I do not know how to do it for the topic of the cluster. How can I do to auto open all the infowindow of my markers?
[
  {
    "position": {
      "lat": myLocation.lat- 0.0000001,
      "lng": myLocation.lng- 0.0000001
    },
    "name": "uno",
    "address": "Aiea Shopping Center_99-115 Aiea Heights Drive #125_Aiea, Hawaii 96701",
    "phone": "808-484-0000",
    title: "1Welcome to \n" +
         "Cordova GoogleMaps plugin for iOS and Android",
    snippet: "This plugin is awesome!",
  },
  {
    "position": {
      "lat":  myLocation.lat- 0.0001000,
      "lng": myLocation.lng- 0.0001000
    },
    "name": "dos",
    "address": "Pearlridge Center_98-125 Kaonohi Street_Aiea, Hawaii 96701",
    "phone": "808-484-0000",
    title: "1Welcome to \n" +
         "Cordova GoogleMaps plugin for iOS and Android",
    snippet: "This plugin is awesome!",
  },
  {
    "position": {
      "lat":  myLocation.lat- 0.0090000,
      "lng": myLocation.lng- 0.0090000
    },
    "name": "lejos",
    "address": "Pearlridge Center_98-125 Kaonohi Street_Aiea, Hawaii 96701",
    "phone": "808-484-0000",
    title: "1Welcome to \n" +
         "Cordova GoogleMaps plugin for iOS and Android",
    snippet: "This plugin is awesome!",
  }
];

 markerCluster= map.addMarkerCluster({
      boundsDraw: false,
      markers:markers ,
      icons: [
          {min: 2, max: 100, url: "./img/i1.png", anchor: {x: 16, y: 16}},
          {min: 100, max: 1000, url: "./img/i2.png", anchor: {x: 16, y: 16}},
          {min: 1000, max: 2000, url: "./img/i3.png", anchor: {x: 24, y: 24}},
          {min: 2000, url: "./img/i4.png",anchor: {x: 32,y: 32}}
      ]
    });
    markerCluster.on(plugin.google.maps.event.MARKER_CLICK, function (position, marker) {

     //marker.get("name")

    });

Not available. Only clicked marker is available for marker cluster.

:( thanks...

There is nothing you can do more than in the document page.
https://github.com/mapsplugin/cordova-plugin-googlemaps-doc/blob/master/v2.3.0/class/MarkerCluster/README.md


[DOC] - Document the Nebari GitHub team structure

Preliminary Checks

[X] This issue is not a question, feature request, RFC, or anything other than a bug report. Please post those things in GitHub Discussions: https://github.com/nebari-dev/nebari/discussions

Summary
We need to document what the teams in https://github.com/orgs/nebari-dev/teams mean, what are their responsibilities, and how to join each team.
Steps to Resolve this Issue
tbd

xref: https://github.com/nebari-dev/governance/issues/39


Automate zarf version updates

This project appears to be using a fairly old version of the zarf init package. This could cause issues with newer zarf cli versions.

@ntwkninja this should be resolved with the credential fixes and it looks to be back in working order, closing the issue.


kwallet is not unlocked with SDDM

Describe the bug
After logging in with SDDM I see the following window:

Every time. This is annoying and should not happen. Previously, no manual intervention was necessary. This is a regression in 20.09.
This is like #83095, but for 20.09 this time.
To Reproduce
Steps to reproduce the behavior:

Enable NetworkManager, SDDM and Plasma.
Store Wi-Fi password in KDE Wallet (store password for this user only - encrypted).
Set KDE Wallet password to password used to log in.
Log out.
Observe the above-mentioned window.

Expected behavior
No manual intervention should be necessary.
Notify maintainers

@ttuegel @nyanloutre
Metadata
Please run nix-shell -p nix-info --run "nix-info -m" and paste the result.

system: "x86_64-linux"
host os: Linux 5.4.72, NixOS, 20.09.1469.13d0c311e3a (Nightingale)
multi-user?: yes
sandbox: yes
version: nix-env (Nix) 2.3.7
channels(xfix): ""
channels(root): "nixos-20.09.1469.13d0c311e3a, home-manager-20.09"
nixpkgs: /nix/var/nix/profiles/per-user/root/channels/nixos

Maintainer information:
# a list of nixpkgs attributes affected by the problem
attribute:
# a list of nixos modules affected by the problem
module: plasma5

Yeah, I think Q.A finding showed this was true.

cc @ttuegel

It's possible this may be fixed with https://github.com/NixOS/nixpkgs/pull/101369 (backport https://github.com/NixOS/nixpkgs/pull/102347 ) because IIRC before the changes there sddm didn't  the same qt version as the other plasma packages... But we need to check it..

Ugh.

Don't have much time to look at this, but last time a few things pieces of info that could help:

Check for kwallet-pam in coredumpctl (the coredump itself won't be very helpful, but at least we know it's getting that far.
Try increasing the kwallet-pam max from 1000 to 10000 in https://github.com/KDE/kwallet/blob/bc9713e2725ab1c4311866f751c674a38584bd92/src/runtime/kwalletd/main.cpp#L44
Might want check if any env vars are over the 1000 char limit. They get cut off which can lead to kwallet-pam crash.

It's possible this may be fixed with #101369 (backport #102347 ) because IIRC before the changes there sddm didn't the same qt version as the other plasma packages...

They didn't use different Qt versions before the branch-off, but this has been broken much much longer than that.

I think 21.05 fixes this, so closing.


Add documentation to many public members and populate the example dir

Should increase the score of the package
Prepare to release v0.4.1

Trying to fix the score:

@grant @subfuzion – ya'll should play with "suggest changes" in PRs – is nice!


Tiny (0.01s) Gaps Between Audio Outputs from stftPitchShift.shiftpitch()

I tried to write an LADSPA plugin using stftPitchShift. However, whenever I call shiftpitch(), it adds a very tiny (about 0.01s) fade in and out at the start and end of each buffer it processes. Here is the plugin code.
I've attempted to solve it by:

Changing the hop rate, setting the hop rate to 1 to use SDFT instead of STFT.
Enabling RMS normalization.

Unfortunately, these attempts did not work.

As mentioned in #18, #33, #34 and finally in the readme file, your have to use the StftPitchShiftCore instance inside of your own STFT pipeline for real-time audio signal processing. The StftPitchShift instance can't do this stuff.

I've tried to use the StftPitchShiftCore in here.
But the gaps are still there.

The STFT pipeline provided in this project cannot handle a continuous audio stream. It only handles a finite audio file at once. This is exactly the reason, why you hear gaps in the continuous (endless, not finite) audio stream. Instead you have to implement your own STFT pipeline with required capability.

Further reading: DAFX (chapter 7 Time-frequency processing)


raw.data is not a matrix

Hello! I am using RCAv2, I follow the tutorial here: https://github.com/prabhakarlab/RCAv2. I received the error: "Error in t.default(raw.data) : argument is not a matrix" when I run this code: PBMCs <- RCAv2::dataLogNormalise(PBMCs). Do you know how to solve this problem? Thanks!

Hello! I got the same proplem,  whem running this step: PBMCs<-RCAv2::dataLogNormalise(PBMCs) , an error occur: Error in t.default(raw.data) : argument is not a matrix.


Custom player/vehicle heading for warps

Can you add a option to select a destination player/vehicle heading for warps, cant make the player face the right way, It would need the entrance warp facing a certain way to get the right heading on the other side, other than that love the warps with permissions!

This is already implemented into the teleport function


Missing "!" on pagination last condition

Q
A

Bug fix?
yes

New feature?
no

BC breaks?
no

Deprecations?
no

Tests pass?
yes

Thanks @ehibes!


Integrate HTML5 drag and drop API as alternative of classical mouse t…

…racking and allow better dnd experience outside jstree itself

The changes look great! I will merge ASAP, I am not merging right away, as I will need to immediately update a few lines, which will take some time:

I will see if all HTML5 events can be delegated - binding on each node individually will be very slow on large trees
I will remove the usage of jQuery inside redraw_node, as it will be very slow on large trees too

Thank you for the contribution and for the great work! I will get back to you in a few days when I can merge the request.
Best regards,
Ivan

@vakata Any chance to merge this soon? Seems like a very valuable addition.
Hope it will make it in the next stable version.

@gpetrov Sorry, I haven't found the time to properly test this out, but I hope I will in the next week.
Best regards,
Ivan

I just added this to the DND plugin. Thank you for the wonderful idea, unfortunately I could not merge this because of the expensive jQuery operations in redraw_node, and the events bound in the same function, but I built on this example managed to make it fully compatible with the all other options (large drag/drop target, the open_timeout, etc).
Once again - thank you.
Best regards,
Ivan

:+1: Thanks a lot


[UI][Environment] [Advanced mode] add the scroll option if needed.

For replay this bug you need:
Test case

Go to SS -> Environment -> Advanced mode.

Result: you can observe the scrolling option without any reasons.

Commit ID   94bfb244e145a74bd01125e17dc546e94184fadb

I see this scroll in advanced mode. But is it a real bug?

@zubaidullo WDYT?

If that page is empty have scroll then it's bug

Ok


Revert "activities should be optional"

Reverts statelyai/xstate#2751
I'm unsure if this change has been sound. We can, of course, make this optional at the type level but in reality this property is always defined on the StateNodeDefinition object (that is returned from the stateNode.definition getter):
https://github.com/statelyai/xstate/blob/c1503b1219d995ebf0f45de46036c5a1d7e6442f/packages/core/src/StateNode.ts#L522
A side note is that the value fallback (|| []) is actually redundant because this.activities is always an array:
https://github.com/statelyai/xstate/blob/c1503b1219d995ebf0f45de46036c5a1d7e6442f/packages/core/src/StateNode.ts#L442-L444
cc @huan

I'm ok with the reversion.
I sent this PR because when I'm studying the XState I found that the activities have to be set even I do not need it at all. After reading docs I saw it was documented as deprecated then I think it should be optional.
Thanks for the careful reviewing BTW!


Ensure critical threshold

Checks without a CRITICAL threshold will never be seen by 90% of Rackspace customers so add CRITICAL threshold to various alarms.

This seems fine, we'll probably need better commit messages (more than just titles) and a bug
https://github.com/rcbops/rpc-openstack/blob/master/CONTRIBUTING.md#commits

@kstev also please squash these two commits into one

@kstev please don't squash them into one commit.

Mixing two unrelated functional changes in the same commit.

from https://github.com/rcbops/rpc-openstack/blob/master/CONTRIBUTING.md#commits

@prometheanfire the second commit is a typo fix to something introduced in the first commit, so they can be squashed

ah, ok then

Will try to address bug 1085 with this as well. That okay?

Ya, it looks like that's what this addresses.

@kstev so the commit title needs to be something like 'ensure all alerts have both warning/critical thresholds'
#1085 looks like it's asking for only warning which I don't necessarily agree with

This PR seems to address #1091 but not #1085. The latter is simply pointing out that "CRITICAL" is not a correct status for high disk utilization.
This PR may well be related to 1085, though, in that it at least reports a "WARNING" status. However, it will still report a CRITICAL status, and provides no method to not specify a critical level or to skip warning of critical status.

👎
Core does not understand warning thresholds hence this pull looses the use. We would never see warning. For the disk utilization we only have to fix my old bugs, not report vitrtual scsi device like iscsi, so we only monitor the actual physical disks and not so much instance activity

WARNINGs can still be polled via the MaaS API and email alerts can be configured for WARNING.
Not creating CORE tickets for metrics that are non-CRITICAL is a benefit.
For compute hosts with qcow images on local disk backing the instances, we get CRITICAL alerts for /dev/sda when there is high instance disk I/O for example.

@JCallicoat sure but 99% of customers do not look in the dashboard so use is still limited.

@kstev I'd change this PR to just address #1091. The discussion around #1085 should happen in that issue, and once a decision is made a separate PR can be made to address that.
Also, you're failing on flake8 for the commit title:
hacking/rpco_checks.py:1:1: R802  git commit title ('Add warning and critical thresholds for various alarms') should be under 50 chars

I think I have something that will address #1085. Will target in another PR.

👎  @kstev you'll need to have the CRITICAL alerts first, otherwise we'll never see them - WARNING will always match first

recheck 61f57a5

recheck RPC-AIO-Ceph

@kstev looks like you'll need to rebase this commit. Jenkins is reporting:
"GitHub pull request #1090 of commit 61f57a51778a2c1b8d59a86e29f763608eea5153, has merge conflicts."

👍

:+1: @BjoernT are you okay with this as it stands?


format: json->jsonapi

The specification claims the format to be 'jsonapi', but the examples
use 'json'

I believe this is already being addressed in PR #137. @fawzi, if you agree, then please close this PR (not merging).

yep handled in #137 (going the other way jsonapi -> json)


"Critical dependency" warning coming from userAgent.js

What is the current behavior?

What's happening that seems wrong?

When running npm build in an Express-based and webpack-using application that has imported the Deepgram SDK, I get the following message:
WARNING in<EMAIL_ADDRESS>12:29-90
Critical dependency: the request of a dependency is an expression
<EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS> @ ./js/transcription/DeepgramTranscriptionProcess.ts

(The last line being our codebase, natch)
Also when running new Deepgram, the following line gets logged: "Could not load package details"
I'm importing Deepgram with import { Deepgram } from '@deepgram/sdk'; because that's what makes Typescript happy, but doing it the way you outline in your docs, with require, still causes the same results.
Steps to reproduce

To make it faster to diagnose the root problem. Tell us how can we reproduce the bug.

I haven't made a vanilla express app with webpack and imported Deepgram to try to repro, but I imagine that will do it. There are a few StackOverflow posts that point to webpack being unhappy about the way the package details are being built.
Expected behavior

What would you expect to happen when following the steps above?

No warnings and no superfluous console.loggin' :sunglasses: :cloud_with_lightning:
Please tell us about your environment

We want to make sure the problem isn't specific to your operating system or programming language.

Operating System/Version: Ubuntu 20.04
Language: TypeScript
Browser: N/A

Other information

Anything else we should know? (e.g. detailed explanation, stack-traces, related issues, suggestions how to fix, links for us to have context, eg. stack overflow, codepen, etc)

thankyou :sun_with_face:

Also I'll note that I haven't tried to suppress this warning in our own webpack, which seems to be how people have "gotten around" this issue for other libraries

This is solely this Express back-end, yes. This is on behalf of Daily's transcription integration we have with y'all. :blush: Which works great, but I'm working on moving our code over to using your SDK instead of just via websockets. :tada:

Nice! Just wanted to make sure. We have folks try to use it in the browser which is currently a no-no. I'm looking into this now.

I think I've got it solved. Testing now. Will actually be a good change as it opens the door for a browser-ified version in the future.

Whew! I think we've got it solved. @ablwr, I haven't published an official version with the update yet, but could you try installing<EMAIL_ADDRESS>and see if that resolves the warnings? If so, we'll publish it as the official release.
It seems to be resolved in my test project with express/webpack.

Yes, thank you! The warnings are now gone. :tada: :tada: :tada: :tada: :tada:

Sweet. We'll get 1.3.1 officially released ASAP. Thanks for reporting this and giving me a ton of info to help reproduce it!

<EMAIL_ADDRESS>is released. I'm closing this issue.


UI Overhaul

Overhauled the UI and moved away from custom, styled-components and instead moved to Mantine to speed up development.
This should also address #39
Not sure if we have more settings needs but for now I just put dark / light colorscheme in place. Also note that the settings page has a relatively sparse placeholder About text - maybe we want a bit more here?

@fde31 I've noticed 2 things while using it.

If I target a host: http://localhost:3000?h=c74bull32.local the URI gets updated to http://localhost:3000/parameters and while it does stay connected to the remote host i care about, if i refresh the page, my connection is lost.
If i have 2 patches, one with parameters and 1 without, I can load the patcher with parameters and they show up, but then if I load the patcher that has no parameters, I still see the old parameters from the old patcher. If i select the <none> patcher, the parameters correctly disappear.

Really looking good though!!

I fixed the URL query params not being sticky and ensured that they also persist across navigation.
The second item I can actually not reproduce. Do u have an error in the console when u see that? I did notice that I run into segmentation faults once in a while when unloading a patcher or switching but maybe that's specific to me running the Runner on my device?

@fde31 you're correct, i had some weird setup and those patchers weren't loading.. so, scratch that 2nd thing.
url param seems good!

requested another review @x37v
Feel free to merge if OK with u


[Dubbo-7332] Fix QOS Ready command

Fix QOS Ready command return OK when DubboBootstrap is not ready
What is the purpose of the change
Fix issue: #7332
Brief changelog
M dubbo-config/dubbo-config-api/src/main/java/org/apache/dubbo/config/bootstrap/DubboBootstrap.java
Only change one line, which initializes ready as false instead of true.

Verifying this change
Follow this checklist to help us incorporate your contribution quickly and easily:

[x] Make sure there is a GITHUB_issue field for the change (usually before you start working on it). Trivial changes like typos do not require a GITHUB issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
[x] Format the pull request title like [Dubbo-XXX] Fix UnknownException when host config not exist #XXX. Each commit in the pull request should have a meaningful subject line and body.
[x] Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
[ ] Write necessary unit-test to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add sample in dubbo samples project.
[ ] Run mvn clean install -DskipTests=false & mvn clean test-compile failsafe:integration-test to make sure unit-test and integration-test pass.
[ ] If this contribution is large, please follow the Software Donation Guide.

This bug may be caused by this problem.
https://github.com/apache/dubbo/pull/5873#discussion_r400616808
@Hinsteny

Codecov Report

Merging #7333 (3c2282d) into master (eef6b45) will decrease coverage by 0.28%.
The diff coverage is 100.00%.

@@             Coverage Diff              @@
##             master    #7333      +/-   ##
============================================
- Coverage     59.06%   58.78%   -0.29%
+ Complexity      462      461       -1
============================================
  Files          1044     1044
  Lines         42480    42436      -44
  Branches       6229     6198      -31
============================================
- Hits          25090    24944     -146
- Misses        14591    14683      +92
- Partials       2799     2809      +10

Impacted Files
Coverage Δ
Complexity Δ

.../apache/dubbo/config/bootstrap/DubboBootstrap.java
41.61% <100.00%> (-0.42%)
0.00 <0.00> (ø)

...va/org/apache/dubbo/remoting/TimeoutException.java
0.00% <0.00%> (-33.34%)
0.00% <0.00%> (ø%)

...bo/config/event/listener/LoggingEventListener.java
37.50% <0.00%> (-25.00%)
0.00% <0.00%> (ø%)

...dubbo/remoting/exchange/support/DefaultFuture.java
70.79% <0.00%> (-17.24%)
0.00% <0.00%> (ø%)

...bbo/common/bytecode/CustomizedLoaderClassPath.java
28.00% <0.00%> (-16.00%)
0.00% <0.00%> (ø%)

...va/org/apache/dubbo/remoting/exchange/Request.java
72.54% <0.00%> (-15.69%)
0.00% <0.00%> (ø%)

...ng/transport/dispatcher/WrappedChannelHandler.java
47.82% <0.00%> (-15.22%)
0.00% <0.00%> (ø%)

...ng/transport/dispatcher/all/AllChannelHandler.java
68.96% <0.00%> (-13.80%)
0.00% <0.00%> (ø%)

...dubbo/common/status/support/LoadStatusChecker.java
50.00% <0.00%> (-11.54%)
0.00% <0.00%> (ø%)

...in/java/org/apache/dubbo/common/utils/JVMUtil.java
81.13% <0.00%> (-11.33%)
0.00% <0.00%> (ø%)

... and 47 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update eef6b45...3c2282d. Read the comment docs.

@nickwongwong  hi, thanks for your contribution
If we modify the inital state of ready field, shall it can be adapted to the expose way by ServiceConfig?
ServiceConfig may not start DubboStarter and QOS Ready command will alaways fail.

@nickwongwong hi, thanks for your contribution
If we modify the inital state of ready field, shall it can be adapted to the expose way by ServiceConfig?
ServiceConfig may not start DubboStarter and QOS Ready command will alaways fail.

It may a good way to change the state of ready to true after ServiceConfig doExport, while keeping the initial state of ready to false.
Please review my new commits~

If there are two ServiceConfig, first success and second failed, the ready should be true?

I think ready should reflect more status than just checking exported services.
But still, it's a good start, we can enhance it later together.


Inclusion of a Tutorial on an Idealized Case & Parameter Description of Feature Detection

Description

an additional tutorial notebook on tracking of a 2d test blob
two additional notebooks on the effect of feature detection parameters

Work mainly contributed by @snilsn and reviewed and updated by me.
Checklist

[x] Have you followed our guidelines in Section "Contributing" from README.md?

[x] Have you checked already existing notebooks to get an idea about our tutorial style?

[x] Have you extensively used markdown elements to structure and explain your notebook?

[x] Have you self-reviewed your code / notebook and corrected any misspellings?

[ ] Have you uploaded your example data to zenodo (see README) if needed?

does not apply

[x] Have you checked if your notebook is running in the recommended standard conda enviroment [see here]((docs/RunningTutorials.md) and updates the list of required python packages if needed?

[x] Have you carefully checked that sphinx-based rendering is still working correctly?

[ ] Have you written descriptive commit messages?

I am always bad on this aspect :-)

[x] Have you kept your pull request small and limited so that it is easy to review?

[x] Have the newest changes been merged into this branch?

@JuliaKukulies : The update should address most of your comments.

@JuliaKukulies : all suggested correction should be included now! What do you think: Ready to merge?


Inaccurate description

The description said the library is 1KB, but the code is indeed 7.62 KB.
Even the minified dist version is 3.2K

It's inaccurate from day one, but sadly no one cares and keep promoting it as such - no matter that it even never been 1kb.

the gzipped size is 1.35KB, so it's close-ish. most js libs now advertise gzipped size, which would be the size over the wire in the majority of real-world deployments.

The current minified, gzipped bundle from master is 1427 bytes or 1.39 KB.
This will often be summarized as 1 KB, depending on what rounding rules you are using.

@beenotung @olstenlarck I don't know in other programming languages ecosystems, but in JavaScript land, whenever you see "x.xKB library", it universally refers to the library minified and gzipped. For example, preact which is currently 3.5KB, uncompressed is 8.7KB and 20 KB unminified.
The current size of Hyperapp is 1427~1408 B or 1.39~1.37 KB, depending on how you compress it: gzip, zopfli, brotli, etc. To calculate the KB size, you divide the number of bytes by 1024, which is the number of bytes in 1 Kilobyte.

1427B / 1024B = 1.39KB

Check out BundlePhobia to see how large a library is, instead of calculating all of this yourself.
For example: https://bundlephobia.com/result?p=hyperapp

@olstenlarck  Yup. It's inaccurate from day one, but sadly no one cares and keep promoting it as such - no matter that it even never ever been 1kb.

Don't misinform other people. As you follow the same convention on your own projects, you can't claim ignorance either.

Although it seems that particular one is due for an update. The only true thing from day one is you trolling this organization.


application opens in dock (not in menu bar) unexpectedly when connect/disconnect to the external Monitor

Platform: Darwin 000-MBP.dhcp.icnl.sap.corp 17.5.0 Darwin Kernel Version 17.5.0: Fri Apr 13 19:32:32 PDT 2018; root:xnu-4570.51.2~1/RELEASE_X86_64 x86_64 i386 MacBookPro11,3 Darwin
Kap Version: <IP_ADDRESS>7
Steps to reproduce

start kap.
connect/disconnect mac to the external monitors

Current behaviour
kap runs in the dock, not the menu bar and opens the new window separated to the menu bar.
Expected behaviour
anything happens
Workaround
?

Thanks, @albinekb
BTW, do you have any plan to fix it?

I dont have access to external screen so can’t reproduce, there is however an open PR that I think addresses this, were also rewriting Kap completely for 3.0 with a different approach to cropping, so this will eventually get resolved

Thank you!

The problem is gone after mac os system upgrade to 10.13.5.
Can I close this bug or keep it?

Thanks for the update @star114, it's an intermittent issue so it's likely still there even though you're not able to consistently recreate it after updating macOS. I'll close this in favour of the other related issues for now.


Fix to correctly filter out node_modules from coverage report

This is an update to the TestRunners gather files to include in coverage process. In testing we have found that node_modules were being included in the generated coverage report, which was throwing off our coverage numbers. Our setup is as follows;
app/
   package.json
   node_modules/
   configs.js
   app.js
   specific-application-directory/

OK, looks legit, thanks.


fix: filters push out apply button on dashboard

SUMMARY
Changed behaviour of too big filter block:

Added class and calculated height (100%-padding) for blocks -> otherwise scroll was appearing in every chart
Added auto overflow for blocks on dashboards so scroll will appear when there will be too many filters
Added menuPortalTarget because dropdown menu was limited to the box of chart.

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
Before:

After:

TEST PLAN

ADDITIONAL INFORMATION

[x] Has associated issue: #11419
[ ] Changes UI
[ ] Requires DB Migration.
[ ] Confirm DB Migration upgrade and downgrade tested.
[ ] Introduces new feature or API
[ ] Removes existing feature or API

Codecov Report

Merging #11580 into master will decrease coverage by 5.13%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master   #11580      +/-   ##
==========================================
- Coverage   66.60%   61.46%   -5.14%
==========================================
  Files         876      420     -456
  Lines       42146    26182   -15964
  Branches     3943        0    -3943
==========================================
- Hits        28070    16093   -11977
+ Misses      13973    10089    -3884
+ Partials      103        0     -103

Flag
Coverage Δ

cypress
?

javascript
?

python
61.46% <ø> (-0.69%)
:arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files
Coverage Δ

superset/db_engines/hive.py
0.00% <0.00%> (-85.72%)
:arrow_down:

superset/db_engine_specs/hive.py
53.90% <0.00%> (-30.08%)
:arrow_down:

superset/db_engine_specs/presto.py
69.76% <0.00%> (-12.53%)
:arrow_down:

superset/db_engine_specs/mysql.py
79.59% <0.00%> (-12.25%)
:arrow_down:

superset/examples/world_bank.py
97.10% <0.00%> (-2.90%)
:arrow_down:

superset/examples/birth_names.py
96.51% <0.00%> (-2.33%)
:arrow_down:

superset/views/database/mixins.py
80.70% <0.00%> (-1.76%)
:arrow_down:

superset/models/core.py
87.60% <0.00%> (-1.66%)
:arrow_down:

superset/views/core.py
73.77% <0.00%> (-0.49%)
:arrow_down:

superset/connectors/sqla/models.py
90.35% <0.00%> (-0.28%)
:arrow_down:

... and 458 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 600a6fa...6fad95c. Read the comment docs.

@graceguo-supercat @ktmud curious if you have any objection to this solution. This issue has come up several times in the past, and I heven't seen a solution yet that makes everyone happy. This seems like at least a step in the right direction. Thoughts?

I think this makes sense. But is there a way to make only the chart content the scrollable area, i.e., make the chart title sticky?

I think this makes sense. But is there a way to make only the chart content the scrollable area, i.e., make the chart title sticky?

agreed, make sense. let's make the filter box title sticky. @kkucharc 🙏

@ktmud do you think there would be much value in making the Apply button sticky on the bottom, so the filters start to scroll behind it? Or is that just hogging the limited real estate?

As much as I like it to be sticky too, I think your point about limited real estate is more important.

I appreciate your feedback and input 👍  I will figure our and propose something.


make pytest happy

should fix #140

Codecov Report

Merging #141 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #141   +/-   ##
=======================================
  Coverage   91.08%   91.08%
=======================================
  Files           9        9
  Lines         740      740
=======================================
  Hits          674      674
  Misses         66       66

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0729d4f...9217f05. Read the comment docs.


Correct way to use ItemsWidget?

Hello! a bit of a newbie question here, but I'm trying to figure out how to effectively append widgets into an ItemsWidget inside of  a popup.     I saw how this was done in the widgets.rs example, but frankly I don't completly understand it :) I assume that I need to use the items_builder method like this:
            .items_builder(
                move |bc, index| {

                    println!("called .items_builder");
                    let text = bc.get_widget(id).get::<HashMap>("list")
                    .clone();

                    TextBlock::new().margin((0, 0, 0, 2)).text(text).build(bc)
                }
            )

to the best of my knowledge, the .items_builder method is what appends the entities to the ItemsWidget, but if I have a function, something like this to create a popup:

fn data_popup(target: Entity, build_context: &mut BuildContext, data: HashMap<String, f64> ) -> Entity {
    Popup::new()
    .target(target)
    .open(true)
    .width(300.0)
    .padding(8.0)
    .height(350.0)
    .child(
        ItemsWidget::new()
            .margin((0, 0, 0, 8))
            .padding(8.0)
            .height(100.)
            .width(260)
            .enabled(true)
            .id("items")
            .child(
                Button::new()
                .text("Close")
                .v_align("bottom")
                .h_align("center")
                .max_width(80.0)
                .on_click(
                    move |states, _| {
                        states.get_mut::<MainViewState>(target).popup_action(PopupAction::Close); // this will close the popup when update() is run
                        true
                    }
                )
            .build(build_context)
            )
            .items_builder(
                move |bc, index| {
                    let fetched = bc.get_widget(target).get::<HashMap<String, f64>>("list")
                    .clone();

                    println!("the fetched is: {:?}", fetched);
                    TextBlock::new().margin((0, 0, 0, 2)).text(format!("{:?}", fetched)).build(bc)
                }
            )
        .build(build_context)
    )
    .build(build_context)
}

I call this function, doing something like this in the update function where data is of the type Hashmap<String, f64>:

                    let container = ctx.entity_of_child(INPUTS_CONTAINER).unwrap();
                    let current_entity = ctx.entity;

                    for x in data {
                        main_view(ctx.widget()).list_mut().insert(x.0.to_string(), *x.1); // puts the data variable into the list field of MainView
                    }

                    println!("[*] adding {:?} to list", main_view(ctx.widget()).list());
                    let build_context = &mut ctx.build_context();

                    let popup = data_popup(current_entity, build_context, data.clone());
                    println!("[*] showing data popup");
                    build_context.append_child(container, popup);

after the code above is executed, the popup appears, looking like this:

I'm probably not using the .items_builder correctly. What is the correct way to use ItemsWidget?

You need to set the count property on the ItemsWidget when you add items to it.
in data_popup() on ItemsWidget:
 ItemsWidget::new()
            .count(data.len())
            .margin((0, 0, 0, 8))
            .padding(8.0)
            .height(100.)
            .width(260)
            .enabled(true)
            .id("items")

Otherwise, the ItemsWidget won't update itself because both the state's value and the widget's property is 0.
ItemsWidget.rs line 14.
I will add some documentation and an example of how to use it

Oh ok, so the count is  incremented each time it is built using:
let len = main_view(ctx.widget()).list().len();
items_widget(ctx.child("items")).set_count(len + 1);

the only problem with that is that in my case, I have to use the data_popup() function to create a popup, and if I add ctx: Context as a parameter, that causes a lot of borrowing and lifetime issues since ctx has to explicitly be Context<'static>,  and if I want to pass a reference to ctx into the data_popup function instead, then it has to be 'static as well, which causes issues. Is there any way that I can increment the counter in a different way?

Oh wait, nvm I figured it out. Thanks for all of the help!

Oh ok, so the count is incremented each time it is built using:

No, not really.The count property is the count of the items in the ItemsWidget.So if you set the count property to 4, it will call the items_builder() 4 times, and builds and displays 4 children.

if I add ctx: Context as a parameter, that causes a lot of borrowing and lifetime issues since ctx has to explicitly be Context<'static>

I think Context does need to be static. All you need is a mutable reference: ctx: &mut Context in the data_popup() fn's signature.

@thivmcthiv2 could we close this issue or do you have any further questions.

I dont have further questions about the widget. Thanks for the help!


updated addTarget selectors to the new Swift2.2 #selector syntax

Swift 2.2 update gave us a new syntax for the addTarget(selector...) methods and ensures type safety by utilizing a #selector(...) style which verifies existence of targeted methods in a pre runtime environment.
I've made the appropriate updates and will attach this PR to a new issue for your consideration.
Thank you.

Since you bought beer at a Swift Heads Meetup, I'll go ahead and approve this PR. 👍😀 Thanks!

Hahaha full circle!!!

-Steve Jobs

On Mar 22, 2016, at 4:56 PM, Swift Code X<EMAIL_ADDRESS>wrote:
Since you bought beer at a Swift Heads Meetup, I'll go ahead and approve this PR. 👍😀 Thanks!
—
You are receiving this because you authored the thread.
Reply to this email directly or view it on GitHub


Separate contrib to another repo

We briefly discussed establishing a more open place for contributions that are mostly related to integrating Proto.Actor .NET with different infrastructure, like persistence, DI, clustering and so on.
Shall we do it? How is it aligned with repo structure for other langs?

Shall we do it?

IMO definitely yes :)

How is it aligned with repo structure for other langs?

I don't think that's a problem. The only other really mature repo is the Go one and from what I can tell it doesn't contain anything like that anyway. And if the question comes up for protoactor-go then I guess it might depend a bit on what's the typical way to do it in Go repos.
@rogeralsing Do you agree?
The bigger question then would be what to move out.

✔  Persistence providers - Seems like a given
✔  Wire serializer - Fits the criteria as well I think
✔  Tracing - I would say probably yes, given that OpenTracing is in the process of becoming OpenTelemetry, but opentracing-dotnet seems to have quite some way to go before GA (still in it's first alpha version)
❓  Cluster providers - Since the beginning Consul has always been treated as the default provider due to it's light weight and ease of use. I'm not entirely convinced of this anymore. I could imagine a lot of users might prefer to use a k8s provider instead.
❓ DI/Scheduler/Persistence - Then there are a few ones which aren't related to integrating with other infrastructure, but that I'm not sure if they should be considered "core" or more as useful extensions. Should they stay in the main repo, or should some of them also be considered as "contrib" packages?

but opentracing-dotnet seems to have quite some way to go before GA (still in it's first alpha version)

I assume you meant opentelemetry-dotnet. It's not that they have a long way to go, it's the OpenTelemetry as a standard is in alpha, so it's quite premature to base anything on it.
IMO we could implement embedded diagnostics using System.Diagnostics (diagnostic source and activity) and both OpenTracing and OpenTelemetry (in the future) could just use it.

I could imagine a lot of users might prefer to use a k8s provider instead.

That's true, we'd rather use a native k8s provider. I don't expect dramatic changes in clustering, except getting rid of singletons when the ActorSystem round is wrapped. I think that the Consul provider can happily live in the contrib repo.

DI integration for the Microsoft default ASP.NET Core DI container is in the contrib folder already, so I think it should be moved among other things.

I assume you meant opentelemetry-dotnet. It's not that they have a long way to go, it's the OpenTelemetry as a standard is in alpha, so it's quite premature to base anything on it.
IMO we could implement embedded diagnostics using System.Diagnostics (diagnostic source and activity) and both OpenTracing and OpenTelemetry (in the future) could just use it.

👍 Sounds like a plan

I created https://github.com/AsynkronIT/protoactor-dotnet-contrib
Do we agree to move the existing contrib, persistence and Consul cluster?
I also suggest placing the simple cluster provider to Proto.Cluster project.

The proto files don't need to be in the same root directory ?

@Damian-P what do you mean?

In the remote and the cluster csproj files we include the proto files:
<Protobuf Include="Protos.proto" GrpcServices="Server" ProtoRoot=".; ..\..\src"/>

Ah, yes, good point. I will check what are we referencing from the core project. Thanks for the heads-up 👍

Sorry I misunderstood. Only the providers will be moved... The Remote and the Cluster projects stay in the core project.

Correct.

Yep agree let's start out with those.

Need to complete #500 first, projects in contrib will reference nuget packages.

ok, lets go with this!

Contrib projects are here https://github.com/AsynkronIT/protoactor-dotnet-contrib


Expo SDK 52 support: fix LinkingContext import for react navigation 7

Fix LinkingContext import for React Navigation 7 (used in Expo SDK 52)
Update react-navigation devDeps to 7.0.0 for improved typing during module dev for Expo 52

After this fix, an app using solito and the new Expo 52 goes from error state to working again. See https://github.com/nandorojo/solito/issues/498
Now realizing that this is basically a duplicate of https://github.com/nandorojo/solito/pull/497, feel free to close

I think there’s a conflict now


Thanks for using PyTorch-Ignite !

Hey @pseeth @ethman
Recently find out your repository where you are using Ignite for train/eval of the DL models.
As being one of Ignite's core team, I'm pleased to see its spread out :) Thanks for using it 👍
If you, guys, have a feedback on the lib, would like to contribute some common features or need a support for some functionalities, please, do not hesitate to reach out us on github, pytorch discuss forum or pytorch slack.
I'm closing this issue as it's not one :)

Thanks for checking us out! Yeah Ignite is really nice and was a breeze to use. Thanks for giving me something I didn't have to put under full test coverage! Every feature I looked for was pretty much there, or it was easy to attach a handler to it.
I noticed you have a list of projects that use Ignite on the Ignite readme. Feel free to add us if you like as an example, as this would be the only audio one on the list, I think.

Thanks for this nice feedback !

I noticed you have a list of projects that use Ignite on the Ignite readme. Feel free to add us if you like as an example, as this would be the only audio one on the list, I think.

@pseeth yes, I forgot to ask you that. Definitly, I'll add your repository there !


Add extra mounts to istio using operator

Bug Description
Not sure if I'm doing this right but I tried to add extra mounts to istio , but no errors and no volumes .
Version
ray: ~ $ istioctl version
client version: 1.11.4
control plane version: 1.11.4
data plane version: 1.11.4 (2 proxies)

Additional Information
ingressGateways:
    - enabled: true
      k8s:
        resources:
          requests:
            cpu: 1000m
            memory: 1Gi
        volumes:
        - name: config
          volumeSource:
            secret:
              secretName: config
        volumeMounts:
        - name:  config
          mountPath: /root/.config

And also , if I set requests.cpu to 1 I got errors like
 v1alpha1.IstioOperator.Status: Spec: unmarshalerDecoder: json: cannot unmarshal number into Go value of type string

but 1000m works , not sure if this is expected ?

I've found secretVolumes definitions , sorry for the trouble


Remove tabs and newlines from URLs

This might sound weird, but both URL standard[1] specifies it,
and browsers do that as well.
Although the standard specifies it as a "validation error",
this is not a hard error.
This actually happens in the wild: as of now, this Google's page[2]
has the following fragment:
<a class="glue-header__link"
                              href="/intl/ru_ALL
/drive/download/"
>

Yes, the newline here is in the middle of the link, and browsers
do ignore it.
[1] https://url.spec.whatwg.org/#concept-basic-url-parser
[2] https://www.google.com/intl/ru/drive/download/

I know that this solution looks rather dirty, so it probably would be better to not merge it before discussing it a bit.

I don't think that it is dirty, it looks good to me. The only addition that we might consider is making an option to allow users to disable this feature. I don't know if it makes sense, but perhaps someone wants these white spaces in the URL for some reason.

One observation I can make is that the logic to parse the URL is in func Parse(rawurl string) (*URL, error). So, perhaps it would be better to strip tabs and newlines in it. Feel free to correct me if I'm wrong.

Also, since the created function isn't called anywhere else, wouldn't it be better to make it private?

Yes. I initially left it exported because I wanted to use it in my code as well: Request.AbsoluteURL doesn't report errors (which sadly can't be fixed without breaking API), so I had to normalize and resolve relative URLs myself.
In any case, I agree that it's better not add more exported functions without good reason. I can live with this function copy-pasted until v3 comes and fixes the API issues that causes me to require the function to begin with :).

The only addition that we might consider is making an option to allow users to disable this feature. I don't know if it makes sense, but perhaps someone wants these white spaces in the URL for some reason.

I believe they should never appear in URL in unescaped forms, and this code doesn't touch their escaped forms. In theory someone might have use cases insane enough to rely on that some servers do accept unescaped tabs AND might treat them differently than escaped ones, but I'd argue that in this scenario he better use custom code instead of generic crawler framework.

My bad, you are right. Please fix the golint issues and it's ready to merge

@WGH- could you rebase this PR?

Sorry, I forgot to update the status of this PR. With #673, this PR is no longer necessary.


fix: upgrade to<EMAIL_ADDRESS>

Fixes #1620

we need to wait for chrome to catch up

https://github.com/apify/crawlee/actions/runs/3339372998

I guess the e2e tests will still fail on platform, but they should pass on local at least.

e2e tests fail across the board, but it doesn't seem related to this PR.. 😕

Investigating


reactive text

How can i make the displayed text reactive?
I am using this with vue and vue-i18n, a translator.
I am passing the data from computed into :data-pt-title="sTooltip"
and sTooltip is in the computed object that returns this.$i18n.t('path-to-text')

You can try to add data-pt-observer="true". This will watch for attribute changes also.

the page freezed when i added that attribute

I never used Vue with jQuery, but I'm pretty sure it's an anti-pattern in general. I think you'll need to force a rerender or something, so the old tooltip element will be removed, and a new will be added.
Alternatively you can also set it manually using $(el).protipSet({ title: 'My title' }).


Cannot start new line from the end of a comment

To reproduce, start writing a comment like the one below and press enter.
// <|>

Expected behavior:
//
// <|>

Actual behavior (enter is ignored)
// <|>

This may be because we don't specify a language configuration json file in the vscode extension's package.json.
See https://github.com/rust-lang-nursery/rls-vscode/blob/master/language-configuration.json as an example of what rls uses

This may be because we don't specify a language configuration json file in the vscode extension's package.json.

We ignore language configuration stuff and try to do all the things ourselves. This goes against how vscode typically work, but I think ultimately is the better approach: language configuration does not know about syntax, so it can go only so far. Compare, for example, how ra_lsp's extend selection and VS Code's build one works.
I believe this particular issue is caused by our on-enter handler here: https://github.com/rust-analyzer/rust-analyzer/blob/0952b928addce602bef9b671d7904033df39f632/crates/ra_analysis/src/lib.rs#L227-L231. In theory, it could be better than the built-in one, but in practice, I expect we have more bugs currently :)

Excellent catch!
I wonder if we should have a test for this...
Seems tricky to write, because it's the VS Code which should be behind the wheel here (currently, we have zero tests for typescript code...)


Fix crash when viewing agencies on map

Fix crash when viewing agencies on map by checking searchType before assuming results have stopId field. Fixes #619
This change assumes bookmarks should not be shown when agencies are being shown.
If bookmarks and agencies should be shown at the same time, the following changes should be made to this PR:

original line 839 should not be removed
new line 848 should be removed
new line 847 can be combined with new line 850 to create an else if statement

@oey192 apologies for taking as long as I have on getting back to you on this. This looks great, and I'm going to merge it. I'd love to see you add a test or two verifying that this method works properly, but I don't want to block merging on it. Thank you for your help!


Revert "Follow up task_spawn change from kernel side"

Summary
since the prototype of task_spawn restore to the origin
This reverts commit 58293abb8e896bb04f3a76bf8b48206debe68f26.
Depends on https://github.com/apache/incubator-nuttx/pull/4027
Impact
Avoid API compatibility issue
Testing

@xiaoxiang781216 I understand that @slorquet took issue with this change. It was done in master not the last release correct? Even if it were in the last release. It will show up in the build.  I do not think is should be reverted it just needs to be documented as a breaking (build) change.
How can we improve if we keep it all the same?

@xiaoxiang781216 I understand that @slorquet took issue with this change. It was done in master not the last release correct? Even if it were in the last release. It will show up in the build. I do not think is should be reverted it just needs to be documented as a breaking (build) change.
How can we improve if we keep it all the same?

task_spawn has the old prototype and behaviour, nxtask_spawn has the new prototype and behaviour.

@davids5 yep no issue with this technical change, it saves a bit of stack and is more posix compliant
posix_spawn has the *pid parameter, but the function here is task_spawn, which is not in posix (seems so)
Having task_spawn returns the PID and have one less parameter is at least consistent with VXWorks: http://beru.univ-brest.fr/~singhoff/ENS/UE_temps_reel/TP-VXWORKS/CORRECTION/Man-VxWorks-1.pdf
yes it's in master, so there are no release notes yet. This might just need to be a reminder to document this in the next release notes :)
Moreover, you have no ability to test this, because all is going to be well if the apps master matches the nuttx master
The issue happens only with "old" apps.


Support i386/x86 platforms

Build busybox for x86 platforms (GOARCH=386). The PR is split into two commits in case you want to build the binary yourself.
Depends on: gokrazy/tools#75

Thanks! I confirmed that building the binary on my machine yields the same result as what you included in your PR.


Create Application of Box-Model in CSS.md

Description 📜Application of Box-Model in CSS
Fixes #6941

Type of change 📝Application of Box-Model in CSS

[X ] Doc#umentation (Content Creation in the form of codes or tutorials)

Domain of Contribution 📊

[X] Frontend Dev #HTML/CSS/JS

Checklist ✅

[X] I follow Contributing Guidelines & Code of conduct of this project.
[X] I have performed a self-review of my own code or work.
[X] I have commented my code, particularly in hard-to-understand areas.
[X] My changes generates no new warnings.

Then no need to mention the image credits, Just mention the reference links.

@2024-SANDHYA actually the whole content is written by me . I haven't copied it from any source . Do i still need to mention any reference link ?

@2024-SANDHYA actually the whole content is written by me . I haven't copied it from any source . Do i still need to mention any reference link ?

Taking reference doesn't mean coping. You might have studied it from somewhere, and put it in your own words. So, you need to mention that link here.

@kashishahuja2002 I have added external reference links. Kindly review.

@2024-SANDHYA Please merge my pr if all seems good to the team.


APT whitelist request for libgnome2-dev

This is all but the last 3 matches either in changelog or documentation files or in comments. The last 3 things are the deprecated gnome-score functions, that can only do anything if the application using them is installed setgid group games. So this is only code that uses setgid(), but nothing that is installed setgid.


Host AK Sco data set in a publicly available space

The file is ~50 Mb and I would like to keep it out of this repository if possible.
Options: figshare, zenodo

Now available at https://figshare.com/articles/ALMA_AK_Sco_12CO_J_2_1_Visibilities/2066022 and noted in the cookbook.


Delete study

Description: To be able to delete study from the study settings page

[x] Password confirmation before delete
[x]  Move study to a dormant stage
[ ] #422
[x] Ability to restore back to the normal state within this cool-off period
[x] Delete all backups / Indexes or reindex
[ ] #423

Closing this in favour of #422 and #423


Update new Service Monitor

@shirhatti,
Thanks for your contribution as a Microsoft full-time employee or intern. You do not need to sign a CLA.
Thanks,
Microsoft Pull Request Bot

@mcy94w Any blockers on merging this?


Connector Samples are Woefully Lacking

The sample connectors provided do not cover topics like Partition & Hierarchy Discovery or the Password Synchronization. Sample Connectors contain a number of bugs. Failure to cover distinguished name configurations (Samples only use "None" distinguished name type). I spent hours dealing with "DN is unavailable" errors caused by including a DN column in the schema. Renaming the column to "mydn" fixed my issues, so there is a conflict if an injested csentry has an attributeentry named "dn". Arg!

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 61b54e1b-514a-d354-0f14-10194f64b08a
Version Independent ID: 4b9bcb87-3197-4ef4-672a-68daf5022078
Content: PowerShell Connector
Content Source: MIMDocs/reference/microsoft-identity-manager-2016-connector-powershell.md
Service: active-directory
GitHub Login: @billmath
Microsoft Alias: davidste

The following issue is being closed due to the age. If this is still an issue, please re-submit this. Thank you.
#please-close


How to handle data that contains zeros

I've used an application of this Dirichlet package by user xuod for the analysis of Morris watermaze data, which is a type of constant sum probability data. Briefly, the data comes from mice swimming in a circular waterfilled pool having four quadrants superimposed on it. The time in each quadrant is recorded over 1 minute, and the dirichlet test is used to determine if the time spent is uniform between all quadrants, or if it non-uniform, suggesting a bias for a particular quadrant. The mice are trained to locate an escape platform hidden in the "target quadrant" which is a test of their memory. It sometimes happens that the data may contain values that are zero when a mouse spends no time at all in one of the quadrants, and the dirichlet.test_uniform() python function fails to converge the model when zeros are present in the data.
Is there any work-around or good solution to address this issue? Can the dataset be transformed in some way to eliminate the zeros without fundamentally altering the data? It seems that adding a constant value to every data point, which gets around the problem of taking the log of zero, would change the data inappropriately.
Thanks for any feedback.

Hi @uraniborg .
I am having a similar problem, I am trying to use the mle method to estimate the Dirichlet parameters, but whenever I have samples (probability vectors, summing to 1) with a component of 0, I get the NotConvergingError. I have tried to tweak the values with a small epsilon but the problem persists.
I am wondering if you have found a solution so far.


Traverse paths in the same order as parent snapshot

This is the 2nd partial fix to #513.
The archivepipe requires the snapshot paths and the backup paths to be
traversed in the same order, and they were sorted differently: the backup paths
by full path, and the snapshot by basename path.

This looks good, thanks for the code! Before merging it, it would be great to have a test for the bad behavior...


Get rid of sweep subcommand

It was mentioned in #51 that

Also it appears that the --version flag doesn't work:
$ cargo sweep -V
cargo-sweep.exe-sweep
$ cargo sweep --version
cargo-sweep.exe-sweep
$ cargo sweep --version -v
cargo-sweep.exe-sweep

The Why
This is because cargo will still pass the subcommand to a third-party cargo extension which this project worked around by having a matching sweep subcommand which did all the hard work. This meant that the output showed up as cargo-sweep.exe-sweep since it was actually operating on the sweep subcommand which didn't have a version (and also explains the trailing -sweep.
To make things look nicer I followed cargo-criterion's method of having a hidden subcommand argument that eats the sweep subcommand that is passed in.
Possible Issues
This can cause confusing behavior if people invoked the command directly since the command doesn't appear in the help text, but I think this is fine since all the documentation I could see showed invoking the command using cargo.
Alternative Approach
Another technique (which I would be open to switching over to use instead) is from cargo-tarpaulin which does essentially what this library did, but has the version information on the subcommand and overrides the bin name in clap as cargo so that cargo-tarpaulin tarpaulin --version will display cargo-tarpaulin ... instead of cargo-tarpaulin-tarpaulin ...
I would be open to switching the the above technique as well since it seems less confusing if for whatever reason someone directly calls the bin instead of trying to use it through cargo. I just wanted to put this PR out here to get the ball rolling first (and because I only saw the alternate technique while I was writing up this text :sweat_smile:)

Looks like the CI changes are from some unrelated issue. Also was sifting through the issue tracker and saw that the issue being addressed in this PR was also mentioned in #44
I decided to take a look at more tools just to get an idea of what others do and here's what I've got
Approach 1
Eat the subcommand using a hidden arg that is consumed

cargo-criterion

Approach 2
Have the bin name appear as cargo and use a subcommand

cargo-tarpaulin
cargo-add and cargo-rm (added by cargo-edit)
flamegraph
cargo-udeps

Approach 3
Fail when trying to be run directly with a message saying to invoke using cargo. Beyond that follow the technique of Approach 2

cargo-bloat

Approach 4
Mimic the interface when invoking as cargo-tool and cargo tool while hiding the tool subcommand in cargo-tool

cargo-expand
cargo-fuzz

Approach 5
Same as Approach 4, but somehow detect when being invoked by cargo so that doing cargo-tool tool fails instead of working

cargo-insta

And that exhausts all the cargo commands that I have installed on my computer. So it looks like most commands fit into one of a few categories, the closest one this tool currently fits into is Approach 2 currently. I think my preference would be

Approach 5
Approach 4
Approach 2
Approach 3
Approach 1

Approach 4 and 5 both make the interface appear as users would normally expect (where invoking with cargo-tool and cargo tool yield the same results)
Approach 2 and 3 both at least make what is happening obvious but are both invoked as cargo tool or cargo-tool tool
Approach 1 could cause confusion since there is a hidden arg being used that would be an issue when someone invokes the tool directly
I'll have to look into how Approach 5 works, but it is currently my most preferred

This is a really great summary, thank you for writing it up!
I am not a giant fan of 5; I think cargo-sweep on its own is totally fine and we should support it. 4 seems easy to implement, I'm going to put up a PR with those changes shortly. I do notice it prints cargo-sweep instead of cargo sweep, but that seems like a small price to pay to avoid cargo-sweep  without a subcommand silently doing nothing.

Ugh, this has the same problem I had in cargo-deadlinks - cargo sweep sweep is itself a valid command that means "clean the directory named sweep", and you can't distinguish it from cargo-sweep sweep sweep, which is invalid.
Ok, giving a hard error when the sweep subcommand is missing seems reasonable to me (5 in your list).

After the clap 4 migration, here's the output of --version:
$ cargo sweep --version
cargo-sweep-sweep 0.6.2
$ cargo-sweep --version
cargo-sweep 0.6.2

Technically it's working.

currently the output from cargo-sweep -h is
A tool for cleaning unused build files created by Cargo

Usage: cargo-sweep <COMMAND>

Commands:
  sweep  A tool for cleaning unused build files created by Cargo
  help   Print this message or the help of the given subcommand(s)

Options:
  -h, --help     Print help information
  -V, --version  Print version information

which I think corresponds to approach 2. I think it's ok to close this for now.


Cache is based exactly on what?

Describe the bug
I'm trying and use a cache for CircleCI, storing it so that I don't have to regenerate, but it detects all files have changed even if none of them actually has
Wonder if that's simply because the checkout dates are newer than the cache restoration date, and if we could fix that somehow with content-based caching (also, maybe this has been fixed already in the latest version)

Mm, maybe this issue should be discussed in Pod::From::Cache, is @finanalyst who knows what the cache is using to recompile files.


Improve language on which DNS solvers are called

Improve language on which DNS solvers are called, see https://github.com/jetstack/cert-manager/issues/3272

/cc @jakexks

/lgtm


Merge in changes included in Meson 1.5.0rc1

Hmm, this isn't mergeable yet. There's a BLAS-related error in the macos-clang job (encoding related, should be easy to resolve), and CPU feature support related failures:
FAILED unittests/featurestests.py::FeaturesTests::test_any - TypeError: Interpreter.__init__() got an unexpected keyword argument 'mock'
FAILED unittests/featurestests.py::FeaturesTests::test_conflict_args - TypeError: Interpreter.__init__() got an unexpected keyword argument 'mock'
FAILED unittests/featurestests.py::FeaturesTests::test_failures - TypeError: Interpreter.__init__() got an unexpected keyword argument 'mock'
FAILED unittests/featurestests.py::FeaturesTests::test_happy_path - TypeError: Interpreter.__init__() got an unexpected keyword argument 'mock'

Updated to 1.5.2 and tested with the full NumPy CI (which looks good) in https://github.com/numpy/numpy/pull/27550#issuecomment-2411258185. Unit test failures here don't seem relevant after all.


Template parameter for onSubmit Hook

Helo @aldeed
Would it be possible to passe the template for the onSubmit hook?
Something like that:
    onSubmit: function(insertDoc, updateDoc, currentDoc, template) {},

William

Same question here. Would like to access a reactive stored in the template

I think the best solution here is to add aldeed:template-extension pkg and use the new this.template.get(myProp). Let me know if that works for you.

@aldeed my natural thought was that the callbacks would provide you the parent template context; perhaps there should be: this.template (autoform) and this.parentTemplate(parent) and the template parameter can be removed from the hooks function signatures?

I'm not sure it's worth doing since you can get the template and any parent templates through blaze/templating pkg APIs now.

@aldeed So how do you access the parent template?
I have a ReactiveVar attached to my Template instance, which shows/hides an "add/insert" form:
Template.oneTimeTasks.onCreated(function() {
    this.shouldDisplayAddForm = new ReactiveVar(false);
});

And I need to be able to manipulate that ReactiveVar from an "onSuccess" AutoForm hook, to close/destroy the add/insert form template:
AutoForm.hooks({
    'add-one-time-task-form': {
	    onSuccess: function(formType, error) {
		    ????.shouldDisplayAddForm.set(false);
		    displayNotice('success', 'Task added!');
	    }
    },
});

Here's the template code:
template(name="oneTimeTasks")
    h1 One-Time Tasks
    button.btn.btn-primary#add-one-time-task-button.dropdown-form-button
	    i.fa.fa-plus
	    | Add One-Time Task
    if shouldDisplayAddForm
	    +oneTimeTaskAdd

template(name="oneTimeTaskAdd")
    .dropdown-form
	    +autoForm id="add-one-time-task-form" class="one-time-task-form" schema="OneTimeTaskSchema" type="method" meteormethod="addOneTimeTask" doc=null resetOnSuccess=true
		    ...

+1

+1

Althought onSuccess doesn't have the template argument I confirmed that you can access the template using this.template (instead of Template.instance()).
AutoForm.hooks({
  sampleForm: {
    onSuccess: function (formType, result) {
      this.template.parent().parent().yourReactiveVari(undefined);
    }
  }
});

@pbibalan Thanks!! That works perfectly.


feat: add ServiceFilter query

After discussing with @MR2011  I've got it.
Lets keep it like it is for the Frontend devs 👍


(feature) Page Labels

I think it would be useful implement Page Labels, so that pages in front matter are different from body matter.
This can be fould in the PDF Specification itself.

Closing as duplicate of issue #3165.


Make target for building wheel

Fixes #1005
Summary
Adds a wheel target to the Makefile.
Running make wheel will build a .whl package for the available python version to the root of the project.
Running make clean will remove all *.whl files from the project root.

Thanks @smaragden for helping us on this! I just left a small comment regarding the command used to build the wheel.

Oh, and if you want GitHub to automatically link the issue to this PR, you need to remove the back ticks around "Fixes #1005" in the PR description.

When merging, please squash the commits and use the Summary from the PR as message.

Codecov Report

Merging #1031 (fb18ffc) into master (a84265c) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #1031   +/-   ##
=======================================
  Coverage   79.30%   79.30%
=======================================
  Files         113      113
  Lines        6102     6102
=======================================
  Hits         4839     4839
  Misses       1263     1263

Flag
Coverage Δ

unittests
79.30% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a84265c...fb18ffc. Read the comment docs.

Thank you @smaragden!


cmd/build: syntax error: unexpected default

What version of Go are you using (go version)?

$ go version
go version go1.17.3 darwin/arm64

Does this issue reproduce with the latest release?
yes
What operating system and processor architecture are you using (go env)?
go env Output
$ go env
GO111MODULE=""
GOARCH="arm64"
GOBIN=""
GOCACHE="/Users/andig/Library/Caches/go-build"
GOENV="/Users/andig/Library/Application Support/go/env"
GOEXE=""
GOEXPERIMENT=""
GOFLAGS=""
GOHOSTARCH="arm64"
GOHOSTOS="darwin"
GOINSECURE=""
GOMODCACHE="/Users/andig/go/pkg/mod"
GONOPROXY=""
GONOSUMDB=""
GOOS="darwin"
GOPATH="/Users/andig/go"
GOPRIVATE=""
GOPROXY="https://proxy.golang.org,direct"
GOROOT="/opt/homebrew/Cellar/go/1.17.3/libexec"
GOSUMDB="sum.golang.org"
GOTMPDIR=""
GOTOOLDIR="/opt/homebrew/Cellar/go/1.17.3/libexec/pkg/tool/darwin_arm64"
GOVCS=""
GOVERSION="go1.17.3"
GCCGO="gccgo"
AR="ar"
CC="clang"
CXX="clang++"
CGO_ENABLED="1"
GOMOD="/Users/andig/htdocs/evcc/go.mod"
CGO_CFLAGS="-g -O2"
CGO_CPPFLAGS=""
CGO_CXXFLAGS="-g -O2"
CGO_FFLAGS="-g -O2"
CGO_LDFLAGS="-g -O2"
PKG_CONFIG="pkg-config"
GOGCCFLAGS="-fPIC -arch arm64 -pthread -fno-caret-diagnostics -Qunused-arguments -fmessage-length=0 -fdebug-prefix-map=/var/folders/sv/rs_453y57xj86xsbz3kw1mbc0000gn/T/go-build3611841643=/tmp/go-build -gno-record-gcc-switches -fno-common"
GOROOT/bin/go version: go version go1.17.3 darwin/arm64
GOROOT/bin/go tool compile -V: compile version go1.17.3
uname -v: Darwin Kernel Version 21.1.0: Wed Oct 13 17:33:24 PDT 2021; root:xnu-8019.41.5~1/RELEASE_ARM64_T8101
ProductName:	macOS
ProductVersion:	12.0.1
BuildVersion:	21A559
lldb --version: lldb-13<IP_ADDRESS>
Swift version 5.5.1-dev

What did you do?

Define string const with name default, see https://go.dev/play/p/h1LUBx4AOru:
const default = "ABCDEFGH"

What did you expect to see?
No error
What did you see instead?
syntax error: unexpected default, expecting name
Might be something really stupid, but I cannot recall default being a reserved word?

Well, it is a keyword used in case statements https://go.dev/ref/spec#Keywords.

Of course... thank you!


Element uses deprecated document.registerElement

Per MDN :
document.registerElement() is deprecated in favor of customElements.define()
Code does not appear to work in latest version of Firefox due to this.

This is being fixed in #67.


Styling. Closes #11

Add pul-assets gem (branding and initial styling)
Clean up styles files
Remove row class for carousel block
Remove sidebar on show view
Add blacklight layout to include header

Coverage remained the same at 100.0% when pulling a8f7d6afd35c4ff1d1fea4995c88315cf244c954 on styles into be01d89ba0ac9a1dbb5695d14f43e899a4367d67 on master.


Functional tests

Addition of functional tests to ensure that the PR's don't break the existing functionality of Kraken similar to functional tests in Cerberus. This eases the code review and ensures the commits are non-breaking.
( PS: It would also enable contributors without cluster to open PR's for minor enhancements confidently :D )

Fixed by #184, thanks to @paigerube14.


travis-ci integration

All tests are passing now, and only a few lines are required to reap the benefits of GitHub/travis-ci integration.
For the indicator button in the README.md to work, you will have to login to travis-ci.org with GitHub once, and activate the webhook on netCDF's GitHub page http://docs.travis-ci.com/user/getting-started/. Then just update the button with the new links.

Based on feedback from some of our other teams here, we're reviewing travis-ci integration with netcdf.  I see the original repository this pull requested from has been deleted, which seems perfectly reasonable.
Would you have any interest in re-submitting a pull request? If not, I can look at the files in the pull request log and integrate/evaluate changes myself, giving you credit in the release notes; this would not be captured in your GitHub statistics, however, so I thought I would throw this out there and see if you were interested.

No idea why the original branch disappeared. I created a new pull request #106.


Issues with localConfigInfo in common_push.go

/kind bug

How did you run odo exactly?
So... for some reason, LocalConfigInfo is imported twice into component/create.go here:
https://github.com/openshift/odo/blob/master/pkg/odo/cli/component/create.go#L48
Which then imports it twice in common_push.go...
https://github.com/openshift/odo/blob/master/pkg/odo/cli/component/common_push.go#L31
type CommonPushOptions struct {
	ignores []string
	show    bool

	sourceType       config.SrcType
	sourcePath       string
	componentContext string
	LocalConfigInfo  *config.LocalConfigInfo

	pushConfig         bool
	pushSource         bool
	forceBuild         bool
	doesComponentExist bool

	*genericclioptions.Context
}

Because in *genericclioptions.Context we also import LocalConfigInfo...
https://github.com/openshift/odo/blob/master/pkg/odo/genericclioptions/context.go#L314
Causing a conflict when implementing: https://github.com/openshift/odo/pull/2532
Because LocalConfigInfo ends up being blank..
This needs to be fixed in order to no longer have any conflicting LocalConfigInfo's / null pointers.
Actual behavior
Incorrect LocalConfigInfo being returned
Expected behavior
Correct LocalConfigInfo being returned.
We should also refactor the code that's being used in common_push.go as it conflicts with code that's also in component/describe.go which uses a different way to retrieve the local context / LocalConfigInfo.
Any logs, error output, etc?
Running https://github.com/openshift/odo/pull/2532 pulls in incorrect LocalConfgInfo.

Ping @mik-dass  and @girishramnani I believe you two are the best suited for the task. I tried some simple debugging but found I would fix one bug, cause 99 others haha

/kind code-refactoring

/project "Sprint 180"

/area component

Setting priority as high as this is affecting us adding new features (odo create -o json) and this has already as well as can cause more issues in the future.

ping @mik-dass @girishramnani

and it seems this is happening at multiple places -

Describe uses ComponentOptions which has context ( which has localconfiginfo ) https://github.com/openshift/odo/blob/de1aa2bcb44e8f1106d49454952c718b814e9fe4/pkg/odo/cli/component/describe.go#L31
similarly watchOptions https://github.com/openshift/odo/blob/de1aa2bcb44e8f1106d49454952c718b814e9fe4/pkg/odo/cli/component/watch.go#L45
PortforwardOptions
https://github.com/openshift/odo/blob/df2a46a67cfbcce11c2be29340a6bde961d187b2/pkg/odo/cli/debug/portforward.go#L33
StorageDeleteOptions https://github.com/openshift/odo/blob/de1aa2bcb44e8f1106d49454952c718b814e9fe4/pkg/odo/cli/storage/delete.go#L30
StorageListOptions https://github.com/openshift/odo/blob/949bcb3c01d40a3dfaf4b379b8a49f894d7e11df/pkg/odo/cli/storage/list.go#L34
URLListOptions
https://github.com/openshift/odo/blob/de1aa2bcb44e8f1106d49454952c718b814e9fe4/pkg/odo/cli/url/list.go#L32

@cdrage

So... for some reason, LocalConfigInfo is imported twice into component/create.go here:
https://github.com/openshift/odo/blob/master/pkg/odo/cli/component/create.go#L48
Which then imports it twice in common_push.go...
https://github.com/openshift/odo/blob/master/pkg/odo/cli/component/common_push.go#L31

It's more helpful to refer the commit pointed to by master at the time of opening an issue instead of referring to the master branch since master keeps getting updated throughout the day. :wink:


Add a loader option to exclude/include files in a module's dependency tree

Do you want to request a feature or report a bug?
Request a feature.

What is the current behavior?
If the current behavior is a bug, please provide the steps to reproduce.

What is the expected behavior?
If this is a feature request, what is motivation or use case for changing the behavior?
The current include and exclude loader options allow developers to include/exclude particular files, but in many cases its far more useful to include/exclude entire branches in the dependency tree.
This will become more and more important (specifically in the case of babel-loader) as more and more browsers begin to natively support ES2015+ features. Right now it's common for module authors to publish the compiled versions of their code, but I don't think that should be considered a best practice going forward.
Consider this scenario: if one or more of my module dependencies publish their source files as ES2015, it's much more complicated than it should be to include them in the transpilation step while also excluding all other modules because it requires intimate knowledge of that module's dependency tree.
You can whitelist (via include) certain modules, but this won't always work because you need to know the full module path, which is problematic since npm sometimes installs a module directly under node_modules and other times it installs a module in a nested node_modules folder.
To solve this issue, I think it'd be nice to add something like an excludeTree option. This option would accept an array of npm module names and exclude any files in that module's source as well as any files in the source of any of its dependencies (via package.json).
{
  excludeTree: ['react', 'core-js'],
}

excludeTree is useful for cases where most of your dependencies need to be transpiled. Today, however, the norm is that most of your dependencies are published as ES5, so in these cases what you generally want to do is something like the following (which assumes a matchesExcludeTree() function exists):
{
  exclude: (absPath) => {
    // Exclude all node modules *unless* they're in the following list
    // of packages (and their dependencies).
    return absPath.includes('node_modules') &&
        !matchesExcludeTree(absPath, ['autotrack']);
  }
}

Perhaps in this case it makes sense to have exclude/excludeTree work in conjunction with include/includeTree. That way the above imperative logic could be rewritten declaratively like this:
{
  exclude: /node_modules/,
  includeTree: 'autotrack'
}

For some additional context as to why this is a problem, see this issue:
https://github.com/googleanalytics/autotrack/issues/137
Please mention other relevant information such as the browser version, Node.js version, webpack version and Operating System.

I think that's what the issuer filter is supposed to allow you to do

@Kovensky, I don't think the issuer option helps here.
In theory you would be able to exclude any resource that wasn't "issued" via one of your source files or one of the known modules that needs transpilation, but in practice this isn't possible.
It could work if the exclude option (when taking a function) were passed both the source file and the issuer, but it's not.
I've also tried just using the issuer option, but that doesn't work either since it doesn't include the entry file.

This is not possible in a nice way. Imagine a module is required by two modules. It not clearly defined if it's exclude or not. We could throw on those cases, but that's weird.

In the case of a transpiler like babel-loader I think it's safe to say: if at least one module requires this file, it should be transpiled.
This may not be as cut and dry for other types of loaders; I haven't spent as much time thinking about that, but perhaps it should be up to the loader to determine whether to throw or not?
@sokra, what about the suggestion that the exclude function be called with not only the file path but also the issuer path as well? I think that would help quite a bit for this case.

I agree that it shouldn't be considered a best practice to assume all dependencies are already transpiled to ES5 and thus to recommend the exclusion of all node_modules for babel-loader. If all my users are on ES2015-supported browsers, shipping them ES5 code is an unnecessary deoptimization (since transpiled code is larger, for one). And even if you need to transpile to ES5, the most efficient place for that transpilation to occur is when the application is built (where it can be ensured that babel helpers are not being duplicated, for example), so even developers who must ship ES5 would benefit from depending on libraries that are not pre-transpiled to ES5.
With all that said, the current include/exclude options for babel-loader have problems, as this issue describes. So I'm adding another voice here - I think this is something webpack could improve.


Incorrect config/plugins.js example

The JS meilisearch library expects the API Key to be provided in camelCase.
However, the configuration object in the sample uses snake_case.
module.exports = () => ({
  //...
  meilisearch: {
    // Your meili host
    host: "http://localhost:7700",
    // Your master key or private key
    api_key: "masterKey",
  }
  //...
})

Tripped me up, as after following the tutorial I got the "MeiliSearchApiError: The X-MEILI-API-KEY header is missing." error.
Done some digging around to see what went wrong and found that this configuration object goes straight to meilisearch library, so it should be configured like it says in the docs over there.
I guess this is also worth mentioning just in case configuration becomes more advanced, so as to point people to the right direction from the start, but this is out of scope for my PR.
P.S. Great project overall :heart:

Thanks a lot for raising and fixing this issue 🔥


Introduce Provider for the SslContext

provides the SslContext depending on its availability
automatically registers SslContext in PipelineRegistry
unifies different implementations of SslReqHandlers
removes the need for default handlers
simplifies dynamic class loading

Codecov Report

:exclamation: No coverage uploaded for pull request base (master@2360da7). Click here to learn what that means.
The diff coverage is 84.21%.

@@            Coverage Diff            @@
##             master    #5855   +/-   ##
=========================================
  Coverage          ?   83.01%
  Complexity        ?    12131
=========================================
  Files             ?     1424
  Lines             ?    46466
  Branches          ?     5723
=========================================
  Hits              ?    38575
  Misses            ?     5215
  Partials          ?     2676

Impacted Files
Coverage Δ
Complexity Δ

.../java/io/crate/protocols/ssl/SslConfiguration.java
79.46% <ø> (ø)
1 <0> (?)

...crate/protocols/ssl/SslConfigurationException.java
100% <ø> (ø)
1 <0> (?)

...crate/protocols/postgres/PostgresWireProtocol.java
85.6% <100%> (ø)
36 <0> (?)

sql/src/main/java/io/crate/plugin/SQLModule.java
100% <100%> (ø)
2 <0> (?)

...java/io/crate/protocols/ssl/SslConfigSettings.java
95% <100%> (ø)
10 <9> (?)

...main/java/io/crate/plugin/HttpTransportPlugin.java
88.23% <100%> (ø)
9 <0> (?)

...ava/io/crate/protocols/postgres/PostgresNetty.java
87.5% <100%> (ø)
20 <0> (?)

...rc/main/java/io/crate/plugin/PipelineRegistry.java
94.91% <71.42%> (ø)
17 <3> (?)

...ava/io/crate/protocols/ssl/SslContextProvider.java
60.71% <75%> (ø)
6 <4> (?)

...ava/io/crate/protocols/postgres/SslReqHandler.java
88.88% <85%> (ø)
7 <6> (?)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2360da7...a386599. Read the comment docs.


Selected widget is darker than it should be

Hi,
Thanks for an amazing package!
I think I did everything like in the example, but the widget that is supposed to be highlighted is darker than it should be for some reason. The colors that should be there are much lighter.

Maybe you can suggest what is causing this? I am not experienced with color blending at all.

It may be because your Selected component has a display animation. When flutter intro obtains the position of the component according to the Globalkey, the component has not really been displayed, so it is not highlighted. You can try to see if adding a delay can solve the problem.

Actually, the reason appeared to be a bit different.
The issue happened when the banner ad was on the screen during the intro, you can see from the demo below that something isn't right.
When I removed the banner ad from the screen, everything works perfectly.
Maybe this information is useful for you, but regardless I can resolve it on my side too.

Feel free to close this issue.

I'm facing the same issue. Any reason why it's highlighted part gets dark?
https://user-images.githubusercontent.com/35165481/119669331-691bf380-be51-11eb-83b9-bd17dfd67766.mov

@hashirshoaeb, I'd suggest starting with checking whether you have any widgets that re-render inside the scene (in my case, the banner ad). If possible, remove widgets one by one and see if the issue persists to isolate it.

@boroma4 Thanks for a quick response. Should I look into the widgets inside the highlighted part or the whole screen in general?

@hashirshoaeb I hadn't figured the root cause when I was dealing with this, so I can't tell for sure. If I got what you are saying correctly, then the whole screen (basically the whole area that gets dim, idk if things outside of it can cause the issue). I couldn't also reproduce it with anything except for the ad.


az-471-terra-light-client

The pallet is considered WIP / POC, therefore this PR omits a couple of important features:

Benchmarks are not ready, left at the stage where they compile (just so)
There are mappings from Tendermint types to storage ready types in our pallet but not into other direction

It's mainly opened so that the overall architecture / design (especially around storage) can be reviewed.
Storage revolves around the idea of maintaining last N (where N is configurable) headers, ordered by their insertion time, with the oldest entry evicted.
Another important feature would be to make the pallet into a client factory - i.e. it would support any number of bridged chains, and maintain a mapping between their unique id and options plus headers storage.

Let's cut a feature branch from main and target PRs at that.

You mean for the entire bridge?

There's one more approach that could decrease the cost of using the pallet: instead of mapping between *Storage types and the Tendermint ones we can wrap them with a struct that we control:
struct LightBlockWrapper(tendermint_light_client_verifier::types::LightBlock);

and write Encode/Decode for LightBlockWrapper. Now, when we read from storage we no longer have to call expensive try_into() as now it's just a wrapper. Additionally, there's no trying anymore since the inner type is exactly what we need.


Add "[BETA]" to initial dialog title.

"[BETA]" appeared int the main application window but not on the initial dialog.  Make sure users see that they are using a beta version on startup.  "[BETA]" is now part of the application name instead of explicitly being added to the window title.

Thanks!


Add to manifest that bluetooth is required for this app. We don't want someone buying it without bluetooth.

 Add to manifest that bluetooth is required for this app. We don't want someone buying it without bluetooth. #40