Updating Regions Component with State Change

I am having trouble provoking a re-rendering of the regions when the props change.  Here is a simple example:
var React = require('react');
import WaveSurfer from 'react-wavesurfer';
window.WaveSurfer = require('wavesurfer.js');
let Regions = require('./Regions').default;

class SongCard extends React.Component {
  constructor(props) {
    super(props);
    this.state = {
      playing: false,
      pos: 0,
      regions: {
        eoi: {
          id: 'eoi',
          start: 5,
          end: 6
        }
      }
    };
    this.togglePlay = this.togglePlay.bind(this);
    this.handleTogglePlayClick = this.handleTogglePlayClick.bind(this);
    this.handlePosChange = this.handlePosChange.bind(this);
    this.handleMoveRegionsClick = this.handleMoveRegionsClick.bind(this);
  }
  togglePlay() {
    this.setState({
      playing: !this.state.playing
    });
  }
  handleTogglePlayClick() {
    this.togglePlay();
  }
  handlePosChange({ wavesurfer, originalArgs}) {
    this.setState({
      pos: originalArgs[0]
    })
  }
  handleMoveRegionsClick() {
    const newState = Object.assign({}, this.state, {
      regions: {
        eoi: {
          start: this.state.regions.eoi.start+10,
          end: this.state.regions.eoi.end+10,
          id: 'eoi'
        }
      }
    });
    this.setState(newState);
  }
  render () {
    return (

            <button type="button" className="btn btn-primary btn-xs" onClick={this.handleMoveRegionsClick}>Change Region</button>

          <WaveSurfer
            audioFile={'https://ia902606.us.archive.org/35/items/shortpoetry_047_librivox/song_cjrg_teasdale_64kb.mp3'}
            pos={this.state.pos}
            onPosChange={this.handlePosChange}
            playing={this.state.playing}
          >
            <Regions regions={this.state.regions} />
          </WaveSurfer>

      );
  }
};

export default SongCard;

When I call setState() within handleMoveRegionsClick(), SongCard's state is updated, but it does not trigger a reload of the Region's props.
Could anyone point me in the right direction for how to solve this?  Thanks!

I modified the example app and got the same behavior here: https://github.com/briankeane/react-wavesurfer.git
in src/plugins/regions.js it does not call componentWillReceiveProps on state change.  If you have a sec to give me some guidance I'd really appreciate it.  Thanks!

Finally got it working by changing shouldUpdateComponent() in src/react-wavesurfer.js to return true if the regions have been updated.

@briankeane ,
Would you be able to post a code snippet here or a PR of the change you made?
I'm having the exact same issue, changing:
  shouldComponentUpdate() {
    return true;
  }

in src/react-wavesurfer.js doesn't seem to resolve the issue for me. componentWillReceiveProps inside of the regions component is still not called.

No prob -- I just made a new component called CustomWavesurfer.jsx and put this in it:
import Wavesurfer  from 'react-wavesurfer';

class CustomWavesurfer extends Wavesurfer {
  shouldComponentUpdate(nextProps, nextState) {
    return true
  }
}
export default CustomWavesurfer;

Then require my CustomWavesurfer instead of the real one.  I didn't pull request because I'm assuming there's a good reason for the way it's set up now.

Actually I think this functionality is just missing. The fix you posted rerenders very often (everytime a prop changes) and so is only a quickfix. The proper solution would be to add the componentWillReceiveProps function in the regions plugin and update the regions state. I'm open for a PR if anyone is up to it :balloon:

Should be fixed in v0.8.5 – please update.


DAD not detected

Converting a bruker .d of an LC-DAD-MS experiment to mzML fails to include the DAD data.

What kind of instrument?

It is a Bruker HCTultra ETD II
I uploaded both the .d and the mzML to:
https://drive.google.com/drive/folders/1UKCcn6OqyBPKN5D98IqNo48BSCiz97HB?usp=sharing

The DAD data is probably in the .u2 file. Do you have any Idea how I could troubleshoot msConvert?


Add timestamp to aggregator output file name

Also add and correct some type annotations

Yep, guilty as charged


[ui] update login page

Updating per issue #929. Let me know if I need to update the example component to remove the other fields to match what's in the issue.

Signed-off-by: Jeeyun Lim<EMAIL_ADDRESS>

We will need to update the docs to add the new .welcome class right?

@adityarb88 thanks for the reminder! I'll create a PR for the website update.


Pipelining versus NETCONF Session

Hello,
We have observed that pipelining has specified in chapter 4.5 of RFC 4741 is supported by Netopeer2, meaning that a given RPC on a given NETCONF Session is pepelined until the previous one ( one the same NETCONF Session ) ended.
But there remains an ambiguity in the RFC in the case where the two parallel RPCs are in different NETCONF Sessions. After a bit of prototyping, it seems that Netopeer does not do pipelining between two NETCONF Sessions, can you confirm this observation?

Yes, 2 NETCONF sessions are independent and their RPCs should execute in parallel, to whatever extent permitted (mostly limited by sysrepo).

Thanks for your support


 As per discussion @tw4l , we'll go with text-muted for now. TBD on a future commit.
But then I approved PR before fixing full stops. Will get another PR in :-)


fix: forecast for next day matches with data

first forecast in array is the next day, not current day

I am guessing you are using met.no as your weather provider as it is missing the current days forecast.  Weather integrations should include the current days forecast as the forecast[0] element. There is an issue and a pending PR to fix that.
https://github.com/home-assistant/core/issues/74235
Your PR will break the card for every other integration that is doing the correct thing.

I just noticed your location is the US, so probably a different integration being used. If it's the NWS one then things are complicated by the fact that it has 2 forecasts per day.

I am guessing you are using met.no as your weather provider as it is missing the current days forecast. Weather integrations should include the current days forecast as the forecast[0] element. There is an issue and a pending PR to fix that. home-assistant/core#74235 Your PR will break the card for every other integration that is doing the correct thing.

Yes that is true, I was using met.no and NWS has even more issues.  I wonder if matching the date might help in all these cases.

NWS has even more issues

Same for me.

Hopefully a better solution in #45


Push config changes to change feed

@sbaogang @jinruh
(1) Push every group/env config change to changes feed and also send slack and mail
Change feed type: ASG Config Change, Deploy Env Config Change
(2) Refactoring config history handler
Example message output:
(1) For Group Launch Configuration change:
Anonymous updated the config for group123 on Wed Jan 20 09:28:05 PST 2016. The changes are:
Name                                      Original Value                            Current Value
email_recipients<EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS>(2) For Auto Scaling Group change:
Name                                      Original Value                            Current Value
maxSize                                   1                                         2
terminationPolicy                         OldestInstance                            Default
(3) For Scaling Policy change:
Name                                      Original Value                            Current Value
scaleUpPolicies                           [{policyName:group123_scaleup_rule, scaleSize:1, coolDownTime:20, ARN:null}]  [{policyName:group123_scaleup_rule, scaleSize:1, coolDownTime:30, ARN:null}]
scaleDownPolicies                         [{policyName:group123_scaledown_rule, scaleSize:-1, coolDownTime:20, ARN:null}]  [{policyName:group123_scaledown_rule, scaleSize:-1, coolDownTime:20, ARN:null}]
(4) For agent config change:
Name                                      Original Value                            Current Value
STOPPING.max_retry                        3                                         2

Superseded by #17


How to repair directv.com

Guide
https://iptv-org.github.io/epg/guides/en/directv.com.xml
Description
After some research I found out directv.com is giving timeouts because they are checking some extra headers...
After testing almost all possibilities I found out it was Accept-language and Connection...
By adding a couple of lines to directv.com.config.js it started working again!

Enjoy and Take Care!
Ben

:) thanks bro.... I try.... :)

Hello!
For the rest of th directv epg's, what would be the process?
I'm referring to:
- directv.com.uy
- directv.com.ar

Thanks in advance.

Hello!
For the rest of th directv epg's, what would be the process? I'm referring to:
- directv.com.uy
- directv.com.ar

Thanks in advance.

go to https://www.directv.com.uy/ and tell me what you see
if you get 403 it means your IP probably got banned (too many tries)
if you get their website fine the config files should work
Cheers
B

Resolved by 684251ed8315cb6a1131dbe590110f597d6cef43

@benbelgium Is directv.com still working for you? I get 'Error: Connection timeout'. Visiting the website works fine on VPN.  I have the grabber running through same VPN. I also have --delay=10000 and --timeout=30000 to be sure.

@benbelgium Is directv.com still working for you? I get 'Error: Connection timeout'. Visiting the website works fine on VPN.  I have the grabber running through same VPN. I also have --delay=10000 and --timeout=30000 to be sure.

screw them, every day another problem, I've had it with directv
to answer your question: no, I stopped using them so I don't know anymore


Add:

FreeTV.us
FreeTV LIVE
https://cdn-ue1-prod.tsv2.amagi.tv/linear/amg01024-olympusat-chiquilines-ono/playlist.m3u8

Please add accordingly in main iptv playlist


Build only blocks with transactions

Posting empty rollups blocks on DA layer is not cost-effective. Rollmit should provide option to build blocks only if there are any transactions.

Closed by https://github.com/rollkit/rollkit/pull/760


added golem as publisher

all test cases were successful.

@Feyrbrand Could you remove all files you committed which are unrelated to the project!

@Feyrbrand Yes, tests/resources/parser/test_data/de/Golem_2024_04_28.html.gz


Bee binary asset name does not contain version number

Summary
The bee binary asset name does not contain the version number for certain assets: darwin, linux, windows.
It contains the version number in the case of Deb or Rpm packages. It would be good to include the version number for all binary assets.
On some OSes (e.g. WIndows, Mac) this will yield ordered filenames (see screenshot) and if there are multiple versions downloaded it can be confusing.

Thanks for creating this issue. Tagging @vandot

I agree that this is not necessary, it just makes people's life easier and less confusing on Mac and Windows when you have to manually download and install new versions.
I don't understand what this has to do with the project being written in golang. For example Geth includes the version number (and also the beginning of the commit hash) in their packaged filenames.

@agazso geth is one of the projects and if you ask me not the shiniest example how you should do things, we already have to many repos and scripts that use this filename structure to work
If filename is really important to you you can always rename it after you download it, simple as that
I will close this issue


.dxf file creation fixes

Fixes are implemented to create 2d .dxf outline files for each change in airfoil section, as well as the tip and root of each wing segment. Guide curve files are also created. documentation is updated to reflect these fixes.


Examples

Hey,
I have written two sample files that I would like to discuss.
How should we organize, order and name the examples?
Please take a look to the notebooks and tell me, what's missing in the description.

Great! Only:

please initialize f_neq in both examples
please initialize pressure in the decaying example

Maybe also merge the observable branch into this branch and use the new observable reporter.
I would like to merge the other one soon. That would ensure compatibility with the changes.

OK, #48 is merged. Can you adapt the reporters in this way?


changing import in main.go for fixing issue #1

Install via
go get -u github.com/mia-platform/miactl
doesn't works.
This pull request should Fixes #1 issue.

I tried but go package management is still something obscure for me if you want to install from github. :-)

Bravo @davidebianchi !
I was not sure that it is needed to hardcode gitlab in all files. Go it's a little bit strange. I'm going to create the installer for brew and linux

No, I don't think this is correct. I should see how to import local dependency, as of now in this branch you could try the cli, but I want to fix this in a better way

After some digging, I found a method of go modules to use the relative path: replace.
But, if we use this method the requirement is that every sub package has a go.mod file, so every submodule will be a separated module from the project.
As of now I prefer to maintain the implementation of this PR, but we could decide later to use the replace directive.


az failed to install ml

Describe the bug
I have an issue installing the ML extension in Azure Pipeline. It seems there is an error with pip inside the extension. I'm trying to install the ML extension, but I haven't set up any specific Python package versions since I don't need them. and it was working correctly before 11/09/2024
Related command
az extension add --name ml
Errors
cli.azure.cli.core.azclierror: An error occurred. Pip failed with status code 2. Use --debug for more information.
az_command_data_logger: An error occurred. Pip failed with status code 2. Use --debug for more information.
Issue script & Debug output
Skipping link: not a file: https://pypi.org/simple/pyasn1-modules/
Given no hashes to check 21 links for project 'pyasn1-modules': discarding no candidates
Collecting pyasn1-modules>=0.2.1 (from google-auth<3.0.dev0,>=2.14.1->google-api-core<3.0.0,>=1.0.0->opencensus<1.0.0,>=0.11.4->opencensus-ext-azure->ml==2.29.0)
Created temporary directory: C:\Users\v-muanati\AppData\Local\Temp\pip-unpack-439cbr19
https://files.pythonhosted.org:443 "GET /packages/1d/67/6afbf0d507f73c32d21084a79946bfcfca5fbc62a72057e9c23797a737c9/pyasn1_modules-0.4.1.tar.gz HTTP/1.1" 200 310028
Downloading pyasn1_modules-0.4.1.tar.gz (310 kB)
-------------------------------------- 310.0/310.0 kB 4.8 MB/s eta 0:00:00
Added pyasn1-modules>=0.2.1 from https://files.pythonhosted.org/packages/1d/67/6afbf0d507f73c32d21084a79946bfcfca5fbc62a72057e9c23797a737c9/pyasn1_modules-0.4.1.tar.gz (from google-auth<3.0.dev0,>=2.14.1->google-api-core<3.0.0,>=1.0.0->opencensus<1.0.0,>=0.11.4->opencensus-ext-azure->ml==2.29.0) to build tracker 'C:\Users\v-muanati\AppData\Local\Temp\pip-build-tracker-9w9n8sox'
Created temporary directory: C:\Users\v-muanati\AppData\Local\Temp\pip-build-env-tf2i8nvn
Installing build dependencies: started
Running command pip subprocess to install build dependencies
Using pip 23.2.1 from C:\Program Files\Microsoft SDKs\Azure\CLI2\Lib\site-packages\pip (python 3.10)
Collecting setuptools
Obtaining dependency information for setuptools from https://files.pythonhosted.org/packages/cb/9c/9ad11ac06b97e55ada655f8a6bea9d1d3f06e120b178cd578d80e558191d/setuptools-74.1.2-py3-none-any.whl.metadata
Using cached setuptools-74.1.2-py3-none-any.whl.metadata (6.7 kB)
Using cached setuptools-74.1.2-py3-none-any.whl (1.3 MB)
Installing collected packages: setuptools
Successfully installed setuptools-74.1.2
[notice] A new release of pip is available: 23.2.1 -> 24.2
[notice] To update, run: C:\Program Files\Microsoft SDKs\Azure\CLI2\python.exe -m pip install --upgrade pip
Installing build dependencies: finished with status 'done'
Getting requirements to build wheel: started
Running command Getting requirements to build wheel
Getting requirements to build wheel: finished with status 'done'
ERROR: Exception:
Traceback (most recent call last):
File "C:\Program Files\Microsoft SDKs\Azure\CLI2\lib\site-packages\pip_internal\cli\base_command.py", line 180, in exc_logging_wrapper
status = run_func(*args)
File "C:\Program Files\Microsoft SDKs\Azure\CLI2\lib\site-packages\pip_internal\cli\req_command.py", line 248, in wrapper
return func(self, options, args)
File "C:\Program Files\Microsoft SDKs\Azure\CLI2\lib\site-packages\pip_internal\commands\install.py", line 377, in run
requirement_set = resolver.resolve(
File "C:\Program Files\Microsoft SDKs\Azure\CLI2\lib\site-packages\pip_internal\resolution\resolvelib\resolver.py", line 92, in resolve
result = self._result = resolver.resolve(
File "C:\Program Files\Microsoft SDKs\Azure\CLI2\lib\site-packages\pip_vendor\resolvelib\resolvers.py", line 546, in resolve
state = resolution.resolve(requirements, max_rounds=max_rounds)
File "C:\Program Files\Microsoft SDKs\Azure\CLI2\lib\site-packages\pip_vendor\resolvelib\resolvers.py", line 427, in resolve
failure_causes = self._attempt_to_pin_criterion(name)
File "C:\Program Files\Microsoft SDKs\Azure\CLI2\lib\site-packages\pip_vendor\resolvelib\resolvers.py", line 239, in _attempt_to_pin_criterion
criteria = self._get_updated_criteria(candidate)
File "C:\Program Files\Microsoft SDKs\Azure\CLI2\lib\site-packages\pip_vendor\resolvelib\resolvers.py", line 230, in _get_updated_criteria
self._add_to_criteria(criteria, requirement, parent=candidate)
File "C:\Program Files\Microsoft SDKs\Azure\CLI2\lib\site-packages\pip_vendor\resolvelib\resolvers.py", line 173, in _add_to_criteria
if not criterion.candidates:
File "C:\Program Files\Microsoft SDKs\Azure\CLI2\lib\site-packages\pip_vendor\resolvelib\structs.py", line 156, in bool
return bool(self._sequence)
File "C:\Program Files\Microsoft SDKs\Azure\CLI2\lib\site-packages\pip_internal\resolution\resolvelib\found_candidates.py", line 155, in bool
return any(self)
File "C:\Program Files\Microsoft SDKs\Azure\CLI2\lib\site-packages\pip_internal\resolution\resolvelib\found_candidates.py", line 143, in
return (c for c in iterator if id(c) not in self._incompatible_ids)
File "C:\Program Files\Microsoft SDKs\Azure\CLI2\lib\site-packages\pip_internal\resolution\resolvelib\found_candidates.py", line 47, in _iter_built
candidate = func()
File "C:\Program Files\Microsoft SDKs\Azure\CLI2\lib\site-packages\pip_internal\resolution\resolvelib\factory.py", line 206, in _make_candidate_from_link
self._link_candidate_cache[link] = LinkCandidate(
File "C:\Program Files\Microsoft SDKs\Azure\CLI2\lib\site-packages\pip_internal\resolution\resolvelib\candidates.py", line 293, in init
super().init(
File "C:\Program Files\Microsoft SDKs\Azure\CLI2\lib\site-packages\pip_internal\resolution\resolvelib\candidates.py", line 156, in init
self.dist = self._prepare()
File "C:\Program Files\Microsoft SDKs\Azure\CLI2\lib\site-packages\pip_internal\resolution\resolvelib\candidates.py", line 225, in _prepare
dist = self._prepare_distribution()
File "C:\Program Files\Microsoft SDKs\Azure\CLI2\lib\site-packages\pip_internal\resolution\resolvelib\candidates.py", line 304, in _prepare_distribution
return preparer.prepare_linked_requirement(self._ireq, parallel_builds=True)
File "C:\Program Files\Microsoft SDKs\Azure\CLI2\lib\site-packages\pip_internal\operations\prepare.py", line 538, in prepare_linked_requirement
return self._prepare_linked_requirement(req, parallel_builds)
File "C:\Program Files\Microsoft SDKs\Azure\CLI2\lib\site-packages\pip_internal\operations\prepare.py", line 653, in _prepare_linked_requirement
dist = _get_prepared_distribution(
File "C:\Program Files\Microsoft SDKs\Azure\CLI2\lib\site-packages\pip_internal\operations\prepare.py", line 69, in _get_prepared_distribution
abstract_dist.prepare_distribution_metadata(
File "C:\Program Files\Microsoft SDKs\Azure\CLI2\lib\site-packages\pip_internal\distributions\sdist.py", line 48, in prepare_distribution_metadata
self._install_build_reqs(finder)
File "C:\Program Files\Microsoft SDKs\Azure\CLI2\lib\site-packages\pip_internal\distributions\sdist.py", line 118, in _install_build_reqs
build_reqs = self._get_build_requires_wheel()
File "C:\Program Files\Microsoft SDKs\Azure\CLI2\lib\site-packages\pip_internal\distributions\sdist.py", line 95, in _get_build_requires_wheel
return backend.get_requires_for_build_wheel()
File "C:\Program Files\Microsoft SDKs\Azure\CLI2\lib\site-packages\pip_internal\utils\misc.py", line 697, in get_requires_for_build_wheel
return super().get_requires_for_build_wheel(config_settings=cs)
File "C:\Program Files\Microsoft SDKs\Azure\CLI2\lib\site-packages\pip_vendor\pyproject_hooks_impl.py", line 166, in get_requires_for_build_wheel
return self._call_hook('get_requires_for_build_wheel', {
File "C:\Program Files\Microsoft SDKs\Azure\CLI2\lib\site-packages\pip_vendor\pyproject_hooks_impl.py", line 321, in _call_hook
raise BackendUnavailable(data.get('traceback', ''))
pip._vendor.pyproject_hooks._impl.BackendUnavailable: Traceback (most recent call last):
File "C:\Program Files\Microsoft SDKs\Azure\CLI2\lib\site-packages\pip_vendor\pyproject_hooks_in_process_in_process.py", line 77, in build_backend
obj = import_module(mod_path)
File "importlib_init.py", line 126, in import_module
File "", line 1050, in _gcd_import
File "", line 1027, in _find_and_load
File "", line 992, in _find_and_load_unlocked
File "", line 241, in _call_with_frames_removed
File "", line 1050, in _gcd_import
File "", line 1027, in _find_and_load
File "", line 1006, in _find_and_load_unlocked
File "", line 688, in _load_unlocked
File "", line 883, in exec_module
File "", line 241, in call_with_frames_removed
File "C:\Users\v-muanati\AppData\Local\Temp\pip-build-env-tf2i8nvn\overlay\Lib\site-packages\setuptools_init.py", line 22, in
import distutils_hack.override  # noqa: F401
File "D:\a_work\1\s\build_scripts\windows\artifacts\Python\Lib\site-packages_distutils_hack/override.py", line 1, in
File "D:\a_work\1\s\build_scripts\windows\artifacts\Python\Lib\site-packages_distutils_hack/init.py", line 77, in do_override
File "D:\a_work\1\s\build_scripts\windows\artifacts\Python\Lib\site-packages_distutils_hack/init.py", line 63, in ensure_local_distutils
File "importlib_init.py", line 126, in import_module
File "C:\Users\v-muanati\AppData\Local\Temp\pip-build-env-tf2i8nvn\overlay\Lib\site-packages\setuptools_distutils\core.py", line 14, in
from .config import PyPIRCCommand
File "C:\Users\v-muanati\AppData\Local\Temp\pip-build-env-tf2i8nvn\overlay\Lib\site-packages\setuptools_distutils\config.py", line 7, in
import email.message
File "email\message.py", line 15, in
File "email\utils.py", line 29, in
File "socket.py", line 51, in
ModuleNotFoundError: No module named '_socket'
Removed pyasn1-modules>=0.2.1 from https://files.pythonhosted.org/packages/1d/67/6afbf0d507f73c32d21084a79946bfcfca5fbc62a72057e9c23797a737c9/pyasn1_modules-0.4.1.tar.gz (from google-auth<3.0.dev0,>=2.14.1->google-api-core<3.0.0,>=1.0.0->opencensus<1.0.0,>=0.11.4->opencensus-ext-azure->ml==2.29.0) from build tracker 'C:\Users\v-muanati\AppData\Local\Temp\pip-build-tracker-9w9n8sox'
Removed build tracker: 'C:\Users\v-muanati\AppData\Local\Temp\pip-build-tracker-9w9n8sox'
cli.azure.cli.core.extension.operations: Command '['C:\Program Files\Microsoft SDKs\Azure\CLI2\python.exe', '-m', 'pip', 'install', '--target', 'C:\Users\v-muanati\.azure\cliextensions\ml', 'C:\Users\V-MUAN~1\AppData\Local\Temp\tmpt833177p\ml-2.29.0-py3-none-any.whl', '-vv', '--disable-pip-version-check', '--no-cache-dir']' returned non-zero exit status 2.
cli.azure.cli.core.extension.operations: Pip failed so deleting anything we might have installed at C:\Users\v-muanati.azure\cliextensions\ml
cli.azure.cli.core.azclierror: Traceback (most recent call last):
File "D:\a_work\1\s\build_scripts\windows\artifacts\cli\Lib\site-packages\knack/cli.py", line 233, in invoke
File "D:\a_work\1\s\build_scripts\windows\artifacts\cli\Lib\site-packages\azure/cli/core/commands/init.py", line 663, in execute
File "D:\a_work\1\s\build_scripts\windows\artifacts\cli\Lib\site-packages\azure/cli/core/commands/init.py", line 726, in _run_jobs_serially
File "D:\a_work\1\s\build_scripts\windows\artifacts\cli\Lib\site-packages\azure/cli/core/commands/init.py", line 697, in _run_job
File "D:\a_work\1\s\build_scripts\windows\artifacts\cli\Lib\site-packages\azure/cli/core/commands/init.py", line 333, in call
File "D:\a_work\1\s\build_scripts\windows\artifacts\cli\Lib\site-packages\azure/cli/core/commands/command_operation.py", line 121, in handler
File "D:\a_work\1\s\build_scripts\windows\artifacts\cli\Lib\site-packages\azure/cli/command_modules/extension/custom.py", line 16, in add_extension_cmd
File "D:\a_work\1\s\build_scripts\windows\artifacts\cli\Lib\site-packages\azure/cli/core/extension/operations.py", line 344, in add_extension
File "D:\a_work\1\s\build_scripts\windows\artifacts\cli\Lib\site-packages\azure/cli/core/extension/operations.py", line 173, in _add_whl_ext
knack.util.CLIError: An error occurred. Pip failed with status code 2. Use --debug for more information.
cli.azure.cli.core.azclierror: An error occurred. Pip failed with status code 2. Use --debug for more information.
az_command_data_logger: An error occurred. Pip failed with status code 2. Use --debug for more information.
cli.knack.cli: Event: Cli.PostExecute [<function AzCliLogging.deinit_cmd_metadata_logging at 0x000001EB9BB14550>]
az_command_data_logger: exit code: 1
cli.main: Command ran in 90.840 seconds (init: 0.633, invoke: 90.207)
telemetry.main: Begin splitting cli events and extra events, total events: 1
telemetry.client: Accumulated 0 events. Flush the clients.
telemetry.main: Finish splitting cli events and extra events, cli events: 1
telemetry.save: Save telemetry record of length 3371 in cache
telemetry.main: Begin creating telemetry upload process.
telemetry.process: Creating upload process: "C:\Program Files\Microsoft SDKs\Azure\CLI2\python.exe C:\Program Files\Microsoft SDKs\Azure\CLI2\Lib\site-packages\azure\cli\telemetry_init_.pyc C:\Users\v-muanati.azure"
telemetry.process: Return from creating process
telemetry.main: Finish creating telemetry upload process.
Expected behavior
It should not show an error
Environment Summary
azure-cli                         2.51.0 *
core                              2.51.0 *
telemetry                          1.1.0
Extensions:
azure-devops                       1.0.1
communication                    1.8.0b1
Dependencies:
msal                            1.24.0b1
azure-mgmt-resource             23.1.0b2
Python location 'C:\Program Files\Microsoft SDKs\Azure\CLI2\python.exe'
Extensions directory 'C:\Users\v-muanati.azure\cliextensions'
Python (Windows) 3.10.10 (tags/v3.10.10:aad5f6a, Feb  7 2023, 17:20:36) [MSC v.1929 64 bit (AMD64)]
Additional context
No response

Thank you for opening this issue, we will look into it.

Having the same issue. Worked fine until today

I can't repro now, I think it's already been fixed?
pyasn1-modules released new version yesterday but the wheel is not provided.

Ref: https://pypi.org/project/pyasn1-modules/0.4.1/#files


arrow-cpp: add cuda support

arrow-cpp: add cuda support
python3Packages.pyarrow: add cuda support

Description of changes
This PR adds optional cuda support for arrow-cpp and
python3Packages.pyarrow.
It depends on #171874.
Because the sandbox requires an option extra-sandbox-paths set correctly to
run the tests (and a GPU of course) and because a few cuda-unrelated tests appear
to link transitively to libcuda, we can't run any tests that link to libcuda during
build. See https://github.com/NixOS/nix/issues/4489 for details.
I successfully performed some rudimentary operations with pyarrow and things appear
to be working:
Fire up ipython from a shell:
nix-shell -p '((import ./. {}).python3.withPackages(p: with p; [ pyarrow pandas numpy ipython ]))' --run ipython

Then, in ipython:
In [1]: import pyarrow as pa, pyarrow.cuda as cu, pandas as pd, numpy as np

In [2]: df = pd.DataFrame(dict(a=list("aabbc"), b=[1, 2, 3, 4, 5]))

In [3]: t = pa.Table.from_pandas(df)

In [4]: ctx = cu.Context()

In [5]: batch, = t.to_batches()

In [6]: buf = cu.serialize_record_batch(batch, ctx)

In [7]: buf
Out[7]: <pyarrow._cuda.CudaBuffer at 0x7fb1135a8040>

In [8]: buf.to_numba()
Out[8]: <numba.cuda.cudadrv.driver.MemoryPointer at 0x7faff1c95730>

In [9]: num = buf.to_numba()

In [10]: num.context.device
Out[10]: <numba.cuda.cudadrv.devices._DeviceContextManager at 0x7faff1c95640>

In [11]: num.context.device.name
Out[11]: b'NVIDIA GeForce RTX 2080 SUPER'

Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[x] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[x] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[x] Tested basic functionality of all binary files (usually in ./result/bin/)
22.05 Release Notes (or backporting 21.11 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module
[ ] (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes

[x] Fits CONTRIBUTING.md.

Closing this out; I don't have time to work on it right now.


Don’t make FAIL cause fatal errors

In accordance with making WARN emit warnings, FAIL now takes on WARN’s previous behaviour, which was to emit an error, but not stop assembling.

I don't think this is likely to break anything, but if it does, this could potentially be reimplemented as a new ERROR keyword.

Not sure about this. The reason I had for changing the behaviour of WARN is that it doesn't make sense to have WARN and FAIL functions if they do basically the same thing: Show an error message.
To me, WARN is supposed to show a warning message but continue, like GCC #warning, and FAIL should show the message and stop, like #error. It doesn't make sense to continue assembling after an error because the code may not even make sense (for example, you check if a number is positive and fail if not, then use the number to allocate memory with DS).

Oh, for some reason I was under the impression that #error would continue, at least so it could find all the errors… Maybe I just haven't used these kinds of keywords much lately; my bad!

I've just checked, I was wrong about #error. However, it still doesn't feel like a good idea to continue assembling after the code explicitly has a statement telling the assembler to stop.

Ok, now I remember, -Wfatal-errors makes it behave like I said...

Hm… Do you think it would make sense to allow both behaviours? (if so, I'd probably use a new ERROR keyword for the new behaviour).

It might make sense for the assembler to continue after a syntax error (I disagree, in lots of cases that creates a long list of fake errors caused by the first one) but I'm completely against letting it continue if the code says it has to stop.

And I just don't see the point in adding more keywords for this. Error and fail can be easily mistaken.

OK, I'll leave this closed then.

This is actually the intended original behaviour: http://www.chrisantonellis.com/files/gameboy/asmotor-v0.1.0-manual.pdf I don't know when WARN changed to become yet another error, but that was a mistake.

In macros it can be helpful to warn the user of a wrong argument or completely abort the assembly process. This is possible with the FAIL and WARN commands. FAIL and WARN take a string as the only argument and will print it out as a regular warning or error with a line number.
FAIL stops assembling immediately while WARN continues after printing the error message.


Packages don't install to python3 library

When following the instructions, sudo pip3 install -e . installs to the pwd and not into the python libraries. How can I rectify this?

Those instructions where a bit old and I now recommend using a virtual envoriment such as Conda. Please check the updated README.md in #863845fdd016838424e12b969483c8516201eba8.

Also, in the old guidelines, sudo pip3 install -e . should be run in the package directory (in case you were not doing so).


pytz missing in requirements.txt

The newly added dependency on pytz is missing in the requirements.txt file (as of tg-archive 1.1.1).
# docker run -it --rm python:3.10 /bin/bash
root@ea4803a88961:/# pip install tg-archive==1.1.1
Collecting tg-archive==1.1.1
  Downloading tg-archive-1.1.1.tar.gz (28 kB)
  Preparing metadata (setup.py) ... error
  error: subprocess-exited-with-error

  × python setup.py egg_info did not run successfully.
  │ exit code: 1
  ╰─> [8 lines of output]
      Traceback (most recent call last):
        File "<string>", line 2, in <module>
        File "<pip-setuptools-caller>", line 34, in <module>
        File "/tmp/pip-install-_y3qx6gu/tg-archive_f8161a99aa3a49f99c04d3eb8ea3fcb6/setup.py", line 5, in <module>
          from tgarchive import __version__
        File "/tmp/pip-install-_y3qx6gu/tg-archive_f8161a99aa3a49f99c04d3eb8ea3fcb6/tgarchive/__init__.py", line 6, in <module>
          import yaml
      ModuleNotFoundError: No module named 'yaml'
      [end of output]

  note: This error originates from a subprocess, and is likely not a problem with pip.
error: metadata-generation-failed

× Encountered error while generating package metadata.
╰─> See above for output.

note: This is an issue with the package mentioned above, not pip.
hint: See above for details.

[notice] A new release of pip available: 22.3.1 -> 23.0.1
[notice] To update, run: pip install --upgrade pip
root@ea4803a88961:/# pip install PyYAML
Collecting PyYAML
  Downloading PyYAML-6.0-cp310-cp310-manylinux_2_17_aarch64.manylinux2014_aarch64.whl (733 kB)
     ━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━ 733.7/733.7 kB 7.3 MB/s eta 0:00:00
Installing collected packages: PyYAML
Successfully installed PyYAML-6.0
WARNING: Running pip as the 'root' user can result in broken permissions and conflicting behaviour with the system package manager. It is recommended to use a virtual environment instead: https://pip.pypa.io/warnings/venv

[notice] A new release of pip available: 22.3.1 -> 23.0.1
[notice] To update, run: pip install --upgrade pip
root@ea4803a88961:/# pip install tg-archive==1.1.1
Collecting tg-archive==1.1.1
  Using cached tg-archive-1.1.1.tar.gz (28 kB)
  Preparing metadata (setup.py) ... error
  error: subprocess-exited-with-error

  × python setup.py egg_info did not run successfully.
  │ exit code: 1
  ╰─> [10 lines of output]
      Traceback (most recent call last):
        File "<string>", line 2, in <module>
        File "<pip-setuptools-caller>", line 34, in <module>
        File "/tmp/pip-install-2ff4jqgs/tg-archive_23604a55fee94a65b16d5f1555e0a3b2/setup.py", line 5, in <module>
          from tgarchive import __version__
        File "/tmp/pip-install-2ff4jqgs/tg-archive_23604a55fee94a65b16d5f1555e0a3b2/tgarchive/__init__.py", line 8, in <module>
          from .db import DB
        File "/tmp/pip-install-2ff4jqgs/tg-archive_23604a55fee94a65b16d5f1555e0a3b2/tgarchive/db.py", line 7, in <module>
          import pytz
      ModuleNotFoundError: No module named 'pytz'
      [end of output]

  note: This error originates from a subprocess, and is likely not a problem with pip.
error: metadata-generation-failed

× Encountered error while generating package metadata.
╰─> See above for output.

note: This is an issue with the package mentioned above, not pip.
hint: See above for details.

[notice] A new release of pip available: 22.3.1 -> 23.0.1
[notice] To update, run: pip install --upgrade pip
root@ea4803a88961:/# pip install pytz=2022.7.1
ERROR: Invalid requirement: 'pytz=2022.7.1'
Hint: = is not a valid operator. Did you mean == ?

[notice] A new release of pip available: 22.3.1 -> 23.0.1
[notice] To update, run: pip install --upgrade pip
root@ea4803a88961:/# pip install pytz==2022.7.1
Collecting pytz==2022.7.1
  Downloading pytz-2022.7.1-py2.py3-none-any.whl (499 kB)
     ━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━ 499.4/499.4 kB 4.8 MB/s eta 0:00:00
Installing collected packages: pytz
Successfully installed pytz-2022.7.1
WARNING: Running pip as the 'root' user can result in broken permissions and conflicting behaviour with the system package manager. It is recommended to use a virtual environment instead: https://pip.pypa.io/warnings/venv

[notice] A new release of pip available: 22.3.1 -> 23.0.1
[notice] To update, run: pip install --upgrade pip
root@ea4803a88961:/# pip install tg-archive==1.1.1
Collecting tg-archive==1.1.1
  Using cached tg-archive-1.1.1.tar.gz (28 kB)
  Preparing metadata (setup.py) ... done
Collecting telethon==1.24.0
  Downloading Telethon-1.24.0-py3-none-any.whl (528 kB)
     ━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━ 528.5/528.5 kB 6.1 MB/s eta 0:00:00
Collecting jinja2>=2.11.3
  Downloading Jinja2-3.1.2-py3-none-any.whl (133 kB)
     ━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━ 133.1/133.1 kB 15.8 MB/s eta 0:00:00
Requirement already satisfied: PyYAML>=5.4.1 in /usr/local/lib/python3.10/site-packages (from tg-archive==1.1.1) (6.0)
Collecting cryptg==0.2.post2
  Downloading cryptg-0.2.post2.tar.gz (16 kB)
  Preparing metadata (setup.py) ... done
Collecting Pillow>=8.3.2
  Downloading Pillow-9.4.0-cp310-cp310-manylinux_2_28_aarch64.whl (3.1 MB)
     ━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━ 3.1/3.1 MB 22.8 MB/s eta 0:00:00
Collecting feedgen>=0.9.0
  Downloading feedgen-0.9.0.tar.gz (217 kB)
     ━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━ 217.9/217.9 kB 27.3 MB/s eta 0:00:00
  Preparing metadata (setup.py) ... done
Collecting python-magic>=0.4.24
  Downloading python_magic-0.4.27-py2.py3-none-any.whl (13 kB)
Collecting cffi>=1.0.0
  Using cached cffi-1.15.1-cp310-cp310-manylinux_2_17_aarch64.manylinux2014_aarch64.whl (449 kB)
Collecting pycparser
  Using cached pycparser-2.21-py2.py3-none-any.whl (118 kB)
Collecting pyaes
  Downloading pyaes-1.6.1.tar.gz (28 kB)
  Preparing metadata (setup.py) ... done
Collecting rsa
  Downloading rsa-4.9-py3-none-any.whl (34 kB)
Collecting lxml
  Downloading lxml-4.9.2-cp310-cp310-manylinux_2_17_aarch64.manylinux2014_aarch64.manylinux_2_24_aarch64.whl (6.8 MB)
     ━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━ 6.8/6.8 MB 19.8 MB/s eta 0:00:00
Collecting python-dateutil
  Downloading python_dateutil-2.8.2-py2.py3-none-any.whl (247 kB)
     ━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━ 247.7/247.7 kB 17.7 MB/s eta 0:00:00
Collecting MarkupSafe>=2.0
  Downloading MarkupSafe-2.1.2-cp310-cp310-manylinux_2_17_aarch64.manylinux2014_aarch64.whl (26 kB)
Collecting six>=1.5
  Downloading six-1.16.0-py2.py3-none-any.whl (11 kB)
Collecting pyasn1>=0.1.3
  Downloading pyasn1-0.4.8-py2.py3-none-any.whl (77 kB)
     ━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━ 77.1/77.1 kB 13.1 MB/s eta 0:00:00
Building wheels for collected packages: tg-archive, cryptg, feedgen, pyaes
  Building wheel for tg-archive (setup.py) ... done
  Created wheel for tg-archive: filename=tg_archive-1.1.1-py3-none-any.whl size=29787 sha256=c489f3b6fc1723ac04c4d4cc24a59def1eab75835519dece6a1b42afaa8c0cf1
  Stored in directory: /root/.cache/pip/wheels/fc/26/31/f47be0d9ed0a9514c9c3ab8dd5cdb7b3030632dfbe73c77284
  Building wheel for cryptg (setup.py) ... done
  Created wheel for cryptg: filename=cryptg-0.2.post2-cp310-cp310-linux_aarch64.whl size=36172 sha256=9258d90d477969b2e8606ac84f6778b352321e1992977a4b8cf2db157a55ed79
  Stored in directory: /root/.cache/pip/wheels/5b/57/c5/a0cd09a10e131b660dc2c22e48a1ff1f58100881411f4ea068
  Building wheel for feedgen (setup.py) ... done
  Created wheel for feedgen: filename=feedgen-0.9.0-py2.py3-none-any.whl size=44370 sha256=e217499a1ceec5cbb22018e71d91df729e17fee2daaac044fb2f8c5600a156aa
  Stored in directory: /root/.cache/pip/wheels/af/65/6a/b476c887721f4ae97f7a46225de4dfe46c623ca62a448239d2
  Building wheel for pyaes (setup.py) ... done
  Created wheel for pyaes: filename=pyaes-1.6.1-py3-none-any.whl size=26347 sha256=09aa18945138ee1f16bdcb4138f0c2233b9ddef4ec2f856d29b5f0afb9c04250
  Stored in directory: /root/.cache/pip/wheels/60/9b/97/e53da26f9cc31f82f8c9bf9870328e72888be92cc4660f4a06
Successfully built tg-archive cryptg feedgen pyaes
Installing collected packages: pyasn1, pyaes, six, rsa, python-magic, pycparser, Pillow, MarkupSafe, lxml, telethon, python-dateutil, jinja2, cffi, feedgen, cryptg, tg-archive
Successfully installed MarkupSafe-2.1.2 Pillow-9.4.0 cffi-1.15.1 cryptg-0.2.post2 feedgen-0.9.0 jinja2-3.1.2 lxml-4.9.2 pyaes-1.6.1 pyasn1-0.4.8 pycparser-2.21 python-dateutil-2.8.2 python-magic-0.4.27 rsa-4.9 six-1.16.0 telethon-1.24.0 tg-archive-1.1.1

pytz is a part of the Python standard library. Can't recollect from which version on. Which version are you using?

@knadh Python 3.10.10 via https://hub.docker.com/_/python.
❯ docker run -it --rm python:3.10 python -V
Python 3.10.10

Ah, my bad! Released version 1.1.2 with pytz added to requirements. pytz is no apparently no longer recommended as timezone functions are now available in the stdlib. I misread that.


Add wheel installation instructions to INSTALLING.md and ensure they work for model examples and demos

cc: @mbahnasTT @dvartaniansTT @Shubhamsaboo
Adding this as a requirement for WH readiness.

Waiting on customer team feedback

@tt-rkim thanks for the whl installation enablement. We'll test it this week on both GS and WH, and update you.
@dvartaniansTT @rbartonTT @jerryliangTT, would you please test the whl and we give back our feedback? Thanks!

Thank you so much guys
Again please review the whole instructions again to make sure you have everything. There has been quite a few changes to things like apt get packages which may require you to re-run commands.

Waiting for feedback from #12609

From Dalar:
I confirm falcon7b model demo passes. and the WHL installation was smooth. but all models demos need to pass for an official WHL release as we see in the CI some model demos failed.
The detailed instructions added to the issue description such as following the installation guide from the whl branch/tag ... the note regarding env variables setting, ... should be added to the installation instructions for the customers as well.
From from my convo w/ @ksriv001 :
Yeah... this is one of those things where we want to make things as uniform and one-track as possible for users, but it's a piece of technical debt that we carried over from YEARS ago. I talked with the ttnn talking heads on this one, and we settled on treating the "production" environment as one which doesn't have ARCH_NAME or TT_METAL_HOME set
I actually came up with some ideas to try to see if I can add some better detection + error messaging to stop users of the wheel from setting too many env vars... let me know if you guys want that

@ksriv001 loves it for 🦙
CLOSE!


The format of the error messages are not unified (ending period)

In general, some error messages end with a period:
#: src/wtforms/validators.py:269 src/wtforms/validators.py:294
msgid "This field is required."
msgstr ""

#: src/wtforms/validators.py:327
msgid "Invalid input."
msgstr ""

#: src/wtforms/validators.py:387
msgid "Invalid email address."
msgstr ""

#: src/wtforms/validators.py:423
msgid "Invalid IP address."
msgstr ""

#: src/wtforms/validators.py:466
msgid "Invalid Mac address."
msgstr ""

but some don't:
#: src/wtforms/csrf/core.py:96
msgid "Invalid CSRF Token"
msgstr ""

#: src/wtforms/csrf/session.py:63
msgid "CSRF token missing"
msgstr ""

#: src/wtforms/csrf/session.py:71
msgid "CSRF failed"
msgstr ""

#: src/wtforms/csrf/session.py:76
msgid "CSRF token expired"
msgstr ""

#: src/wtforms/fields/core.py:534
msgid "Invalid Choice: could not coerce"
msgstr ""

#: src/wtforms/fields/core.py:538
msgid "Choices cannot be None"
msgstr ""

#: src/wtforms/fields/core.py:545
msgid "Not a valid choice"
msgstr ""

source: https://github.com/wtforms/wtforms/blob/master/src/wtforms/locale/wtforms.pot
This make the UI look a little inconsistent when these messages show together.

Do we need to add periods for these messages? If yes, I can submit a PR to fix this. This PR may involve these changes:

Update the messages in the source
Regenerate the mo file
Update the messages in the test
Maybe also update all the translations (some translation adds the missing period for the target language, some don't)?

Thank you for your reporting.
I suppose it would make sense to have periods everywhere. Your PR is welcome!


Set up CI to update image with releases of FAST packages

I noticed at the moment when it's building the image it's using previously cached stages so we'll need it to do --no-cache when building the new docker image triggered by the releases of FAST packages or else the image will won't contain the new packages.


Uptake err handling for credential denial

handle credential denial errrs
added tests

Codecov Report

Merging #148 (5228380) into main (3cf0bcb) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #148   +/-   ##
=======================================
  Coverage   27.79%   27.79%
=======================================
  Files          20       20
  Lines        1558     1558
=======================================
  Hits          433      433
  Misses       1051     1051
  Partials       74       74

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.


EOFError: when wr.pandas.to_parquet() in glue job

I get an EOFError: when wr.pandas.to_parquet() in glue job
  File "/glue/lib/installation/awswrangler/pandas.py", line 729, in to_s3
    extra_args=extra_args)
  File "/glue/lib/installation/awswrangler/pandas.py", line 805, in data_to_s3
    objects_paths += receive_pipes[i].recv()
  File "/usr/local/lib/python3.6/multiprocessing/connection.py", line 250, in recv
    buf = self._recv_bytes()
  File "/usr/local/lib/python3.6/multiprocessing/connection.py", line 407, in _recv_bytes
    buf = self._recv(4)
  File "/usr/local/lib/python3.6/multiprocessing/connection.py", line 383, in _recv
    raise EOFError
EOFError

During handling of the above exception, another exception occurred:

Traceback (most recent call last):
  File "/tmp/runscript.py", line 137, in <module>
    raise e_type(e_value).with_tracsback(new_stack)
AttributeError: 'EOFError' object has no attribute 'with_tracsback'

Hi @LeoHsu0802, thanks for report it.
Any chance of your data be bigger than the available memory?
Could you try to run the same workload with procs_cpu_bound=1? (It will slowdown the parallelism but will save a considerable piece of memory.)

Hi @igorborgest  thanks for reply
I try procs_cpu_bound=1 and it works !


Thank you.

As already discussed in multiple other issues and discussion threads (e.g. #418, #380, #381, #319, #349, #320), this is probably related to insufficient RAM.
I would highly recommend to cross-compile. Otherwise you can try to add some swap or check if compiling single-threaded (add -j 1) helps.

As already discussed in multiple other issues and discussion threads (e.g. #418, #380, #381, #319, #349, #320), this is probably related to insufficient RAM. I would highly recommend to cross-compile. Otherwise you can try to add some swap or check if compiling single-threaded (add -j 1) helps.

Thank you for the fast, correct help.
The "sudo ninja -j1 -C build" command helped, successfully compiled.


Jenkinsfile to check lint improvements in PR

WIP
Working on top of #1060
Uses the Jenkins java APIs to get the master result.

(closing to avoid PR noise of this WIP)


python311Packages.oracledb: 1.4.0 -> 1.4.1

Changelog: https://github.com/oracle/python-oracledb/blob/v1.4.1/doc/src/release_notes.rst
Description of changes

Things done

Built on platform(s)

[ ] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
23.11 Release Notes (or backporting 23.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[ ] Fits CONTRIBUTING.md.

Result of nixpkgs-review pr 255334 run on x86_64-linux 1

4 packages built:

python310Packages.oracledb
python310Packages.oracledb.dist
python311Packages.oracledb
python311Packages.oracledb.dist


haskellPackages: update stackage and hackage

This Merge
This PR is the regular merge of the haskell-updates branch into master.
This branch is being continually built and tested by hydra at https://hydra.nixos.org/jobset/nixpkgs/haskell-updates. You may be able to find an up-to-date Hydra build report at cdepillabout/nix-haskell-updates-status.
We roughly aim to merge these haskell-updates PRs at least once every two weeks. See the @NixOS/haskell team calendar for who is currently in charge of this branch.
haskellPackages Workflow Summary
Our workflow is currently described in pkgs/development/haskell-modules/HACKING.md.
The short version is this:

We regularly update the Stackage and Hackage pins on haskell-updates (normally at the beginning of a merge window).
The community fixes builds of Haskell packages on that branch.
We aim at at least one merge of haskell-updates into master every two weeks.
We only do the merge if the mergeable job is succeeding on hydra.
If a maintained package is still broken at the time of merge, we will only merge if the maintainer has been pinged 7 days in advance. (If you care about a Haskell package, become a maintainer!)

More information about Haskell packages in nixpkgs can be found in the nixpkgs manual.

This is the follow-up to #228965. Come to #haskell:nixos.org if you have any questions.

I'm sorry, due to current situation I cancelled the jobset.  I expect it to get back in about two days, with much of work done over one or two days following that.  I hope it's not an issue; otherwise we could try to find some other approach.

BTW, I expect that you're aware that no "breaking changes" are allowed in these couple of weeks.

I'm sorry, due to current situation I cancelled the jobset. I expect it to get back in about two days, with much of work done over one or two days following that. I hope it's not an issue; otherwise we could try to find some other approach.

No problem, there's no real urgency in this iteration and I lack time anyways. I've restarted the aborted jobs now since the queue was pretty empty (<2000 jobs).

Yes, probably.  staging-next #231026 will probably merged this weekend, so it will be redone afterwards, but not a problem.

I cancelled the old builds in favor of the new ones.  I assume that's what you'd want, but feel free to override that.

When Hydra gets a long a bit more, I'd merge this PR before branch-off (likely later today), as there are no breaking changes present.
This will cause a full rebuild of haskellPackages on staging-next (which shouldn't break anything though), is that okay with you @vcunat? I'm guessing staging-next is not a very pressing issue at the moment, as it doesn't target branch-off?

Yes, the last iteration for 23.05 is already on master and new one hasn't started yet.


Investigate encryption on mobile side

Investigate:

How FaceId works on mobile. Should user be able to decrypt the key with both FaceId and password?
Check if argon2 works on mobile (because of wasm). Maybe this? https://github.com/inokawa/react-native-wasm / https://github.com/cawfree/react-native-webassembly

https://docs.expo.dev/versions/latest/sdk/local-authentication/ Seems like FaceID, TouchID only give us a boolean value if the user is able to authenticate or not, it does not give us any kind of a "key".
That leaves us a few ways we can proceed:

Use only faceid and nothing else (similar to how Phantom does that). But that way it seems like we either don't encrypt wallet or we keep the encryption password on device. FaceID falls back to phone passcode by itself, but if user's phone doesn't have a password, then we are unable to block wallet access.

https://github.com/leather-wallet/mono/assets/22010816/7ad77184-a027-41fa-ac16-c639a63086e5

Use faceid to autofill the encryption password AND have a password field (still, need to keep the encryption password on device)

Ditch biometrics and just use a plain password field.

Yes, we are able to use argon2, but we are unable to use the wrapper that argon2-browser package provides us. We can only use argon2-browser's wasm file with https://github.com/cawfree/react-native-webassembly (was able to make it work in the expo app). So we need to write our own js wrapper for it, shouldn’t be too crazy to do so i think.


Missing check whether fieldset contains config.region_of_interest

While the VirtualShipConfiguration() class contains lots of checks whether the json file itself is consistent, there are no checks whether the fieldsets are also consistent with the json. That could of course be expected if the whole run is done in one go; but if the data downloading is separated from the virtual ship running (and the json file is changed between these operations), then users could get a FieldOutOfBoundError error.
Would it be useful to add an explicit check that region spanned by the fieldset.U.lon and fieldset.U.lat is equal to or larger than the config.region_of_interest?
For example by adding the code below?
    if fieldset.U.lon.min() > config.region_of_interest["West"]:
        raise ValueError("FieldSet western boundary is within region of interest. Please run download_data.py again.")
    if fieldset.U.lon.max() < config.region_of_interest["East"]:
        raise ValueError("FieldSet eastern boundary is within region of interest. Please run download_data.py again.")
    if fieldset.U.lat.min() > config.region_of_interest["South"]:
        raise ValueError("FieldSet southern boundary is within region of interest. Please run download_data.py again.")
    if fieldset.U.lat.max() < config.region_of_interest["North"]:
        raise ValueError("FieldSet northern boundary is within region of interest. Please run download_data.py again.")

Definitely useful. Added, but replaced within with outside ;-)


Fix disabled fields in repo settings UI

Fix disabled fields in repo settings UI when external wiki/tracker is used.
Before
After

LGTM

LGTM


example app for multiple helm charts

This is a sample app, that allows running multiple helm commands or scripted actions to install an app.

@kontsevoy


Update public url to include filename

Description
The public url has the product as sub dir. Thus we need to include it to access the content.
Issues Resolved
Resolves https://github.com/opensearch-project/opensearch-build/issues/1264
Check List

[x] Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Codecov Report

Merging #1265 (6525bcf) into main (c704963) will decrease coverage by 21.94%.
The diff coverage is n/a.

:exclamation: Current head 6525bcf differs from pull request most recent head 031afcf. Consider uploading reports for the commit 031afcf to get more accurate results

@@              Coverage Diff              @@
##               main    #1265       +/-   ##
=============================================
- Coverage     94.09%   72.15%   -21.95%
  Complexity       11       11
=============================================
  Files           127       16      -111
  Lines          2863       79     -2784
  Branches         10       10
=============================================
- Hits           2694       57     -2637
+ Misses          159       12      -147
  Partials         10       10

Impacted Files
Coverage Δ

src/assemble_workflow/bundle_recorder.py

src/ci_workflow/ci_target.py

...eg_test/integ_test_runner_opensearch_dashboards.py

src/test_workflow/integ_test/service.py

src/ci_workflow/ci_check_list.py

src/test_workflow/test_recorder/test_recorder.py

src/paths/output_dir.py

...rc/test_workflow/test_recorder/test_result_data.py

src/manifests/bundle/bundle_manifest_1_0.py

src/paths/script_finder.py

... and 101 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c704963...031afcf. Read the comment docs.

Why isn't the job-name-opensearch part of the url sufficiently unique?

If I look at something like bundle-build in S3 it's hard to know what that really is I guess. And also think it's good not to rely on the job name in case we move/combine things?

Please provide background for this change, its a breaking change to the url schema

This is the bug issue. https://github.com/opensearch-project/opensearch-build/issues/1264

Thanks for the bug link, I would prefer to see is that there is a directory structure on disk and after the build/assembly process that structure is exactly the same as what is uploaded to s3.  With this change it looks like only the s3 pathing is changing but not the local paths, were the local paths already changed - hence this bug?

Thanks for the bug link, I would prefer to see is that there is a directory structure on disk and after the build/assembly process that structure is exactly the same as what is uploaded to s3. With this change it looks like only the s3 pathing is changing but not the local paths, were the local paths already changed - hence this bug?

This is how the disk structure:
-builds
-opensearch
-opensearch-dashboards
-dist
-opensearch
-opensearch-dashboards
This is same as the S3 structure. The current issue is that the location data inside bundle manifest yml is wrong (missing the sub dir).
The reason why disk bundle is working is that the disk output is updated properly here https://github.com/opensearch-project/opensearch-build/blob/main/src/run_assemble.py#L30
However, the output logic for endpoint is handled separately inside https://github.com/opensearch-project/opensearch-build/blob/c7049633b1f6727f2f8fae7292949ca353b6ae37/src/assemble_workflow/bundle_recorder.py#L47
This reminds me that we may further extend @dblock  's suggestion as follows:

add filename to build manifest so that bundle process no longer needs to worry about inferring such from build name

unify the output logic to handle both file and url. https://github.com/opensearch-project/opensearch-build/blob/c7049633b1f6727f2f8fae7292949ca353b6ae37/src/run_assemble.py#L30 Thus base url will be passed into this. Bundle Recorder no longer needs the base_url https://github.com/opensearch-project/opensearch-build/blob/c7049633b1f6727f2f8fae7292949ca353b6ae37/src/assemble_workflow/bundle_recorder.py#L19

Created a separate PR to handle the new attribute in build manifest to reduce potential size of this PR https://github.com/opensearch-project/opensearch-build/pull/1270

Related PR https://github.com/opensearch-project/opensearch-build/pull/1270 has been merged, rebasing this branch first to get latest change.

Introduce a BundleLocation to unify the logic for disk and endpoint bundle logic. Verified locally that location information is correctly set in the bundle manifest for both cases.
Send for review on the functional part. Unit test is in progress.

👍

Magnificent!


Support for Multiple Tags? (Both required and split_words)

It doesn't seem like it supports more than one tag for a field
I tried the followings and it doesnt seem to work,
with semicolon
type config struct {
myfield1 string `required:"true";split_words:"true"`
}

with comma
type config struct {
myfield1 string `required:"true",split_words:"true"`
}

I tried with colon
type config struct {
myfield1 string `required:"true":split_words:"true"`
}

Am I missing something or is it not supported?

ah ! it was space !
for people with same problem here this works for me
type config struct {
myfield1 string `required:"true" split_words:"true"`
}


Fix Order suspend/unsuspend HTTP method

@see
https://manage.resellerclub.com/kb/answer/1077
https://manage.resellerclub.com/kb/node/1452

Thank you for your PR


🚧Improve window auto size

Description:
To allow this pull request to be merged, please make sure that the following items of this pull request are complete.
This pull request closes #12
✅The pull request head branch must be a feature branch with the syntax 'feature/-sync-testing'.
✅The pull request base branch must be a 'main' or 'preview' branch..
✅The pull request head branch contains a valid issue number.
✅The pull request title matches the linked issue title exactly.
✅The pull request assignees match the assignees of the issue.
✅The pull request labels match the labels of the issue.
✅The pull request organizational projects match the organizational projects of the issue.
✅The pull requests milestone matches the milestone of the issue.

Additional Info:

Pull requests are automatically synced with the associated issue upon creation by one of the KinsonDigital workflow bots.
The associated issue is the issue number that is embedded in the pull request head branch.
The list above will be automatically updated as the pull request's various settings match or do not match the associated issue.
To manually sync the pull request to the issue, create a comment with the [run-sync] command.

Note You must be an admin member of the organization to use this command.

[x] Sync with the issue.  Use this to enable or disable this pull request from syncing with its associated issue.

[!Note]
Added the following https://github.com/KinsonDigital/KdGui/labels/💎enhancement 's

Enhanced how control groups resize themselves by considering the width of the group title so the title is not clipped.
Added the property NoResize to the IControlGroup interface and ControlGroup class to enable and disable resizing of the control group.

[!Note]
Added https://github.com/KinsonDigital/KdGui/labels/✨new-feature listed below:

Added the property NoResize to the IControlGroup interface and ControlGroup class to enable and disable resizing of the control group.


iOS safari playback issues

Reported by @ericxtang.
On mobile safari:
Playback defaults to lowest bitrate, and doesn’t move up the bitrate ladder.

The video has a “pulsating” visual artifact.

Cold cache load time varies btw 2s and 10s, with occasional timeouts.

From @Thulinma

The iOS issues (well, the first two, anyway) are non-issues: the pulsating effect is the result of how we transcode (needs a transcoding config change to fix) and the bit rate not going up is the result of slow delivery (iOS clients use download speeds for segments to figure out if they can go to a higher quality or not).

I think it would make sense to tackle these two issues one by one:

First, see if we can repro the "lowest bitrate issue" - if the player is not defaulting the lowest bitrate for someone with plenty of bandwidth then that just re-affirms Jaron's point that that the player is just defaulting to the bitrate that is most appropriate given how fast it can currently download segments and then there is a good chance that the original report was caused by the player being unable to download segments quickly enough (low bandwidth?) causing the lowest bitrate to be the default. If the player does default to the lowest bitrate despite plenty of bandwidth being available then there is likely a deeper issue to investigate
Then, we can see if we can repro the "pulsating" visual artifact and then change the transcoding configuration to get playback that does not have the artifact

This does appear to be a regression, unfortunately — got side-by-side livepeer.studio and livepeer.fun streams, and this is a common result:

Gotta be related to the fact that segment download times are way, way faster on the old system (left old right new)

Which is in turn probably related to the fact we're booting up a new MistOutHLS per stream. Filing that now, previous discussion is here https://discord.com/channels/423160867534929930/900210676591652985/1007052633577639968

Fixed by https://github.com/DDVTECH/mistserver/commit/ba108f6fb52c57412626026cb95b1a9be0bc06bc
There was a problem related to blocking output on the last (most recent) segment present in an HLS playlist. This change excludes the last segment from the playlist, fixing this problem at the cost of one segment of latency. We can revisit this when we want to try and flip LL-HLS back on.


Fix comment typo

Hi! Sorry, but i will not be able to accept your pull request, because we are rewriting all documentation. But anyway, thank you very much for your help!


Identify root spans with inherited context

Root spans that inherit their trace context from incoming headers are
now properly identified as root spans and logged. Independently this
fixes and tests a bug where outgoing contexts were not attached to all
requests.
Fixes #152.

@ofrobots PTAL.

@ofrobots Ready for another look.

@ofrobots Ready for another look.

LGTM, but can you verify that url.parse works correctly even for non-object, non-string argument.

From the node documentation, "options can be an object or a string. If options is a string, it is automatically parsed with url.parse().". Url parse will throw an exception for non-object, non-string arguments but that is exactly what the documentation says will happen.

Thanks for checking. I think the behavior we want here is that we should allow the exception to be thrown, but we shouldn't be the throwers. If the fix looks ugly, feel free to ignore my previous recommendation for optimization.

The fix will just involve doing an additional set of string and object type checks. I will undo the optimization for now since it would result in more total checks (even if some get optimized away).


test: update perf tests to use esm

Code change checklist

[ ] Added/updated unit tests
[ ] Updated /docs. For new functionality, at least API.md should be updated
[ ] Verified that there is no significant performance drop (yarn mobx test:performance)

Pull Request Test Coverage Report for Build<PHONE_NUMBER>
Details

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 87.378%

Totals

Change from base Build<PHONE_NUMBER>:
0.0%

Covered Lines:
3312

Relevant Lines:
3624

💛  - Coveralls


create rutika pr.md

Hi GSSOC Team!
This is PR I raised but is not merged
Could you review and merge it
https://github.com/vishal02527/My-Strength-Shree-Krishna/pull/646/

The PA requested few changes so please complete those
As of now no points can be assigned


Dissolve percent

Hello
I can't find a way to add the  parameter for Dissolve composite like in this command line
gm composite -dissolve 50 a.jpg b.jpg combined.jpg
This is the code I tried to use but it doesn't seem to do anything
img1.Composite(img2, CompositeOperator.Dissolve);
and it's missing the second parameter like Magick.net has
img1.Composite(img2, CompositeOperator.Blend, "50");
Thank you.

This library is no longer actively maintained and you do need that argument. Not sure if this library has a method to set an image attribute/property but if it has you should call SetArtifact("compose:args", "50");. This is what is done in Magick.NET

Ok, thanks. I'll check that. I use both of them anyway. GM only for blurs, gaussian blurs and haldclut.


chore: update AFGO

Signed-off-by: Andriy Holovko<EMAIL_ADDRESS>

Codecov Report

Merging #65 (bfbbadd) into main (3b57684) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main      #65   +/-   ##
=======================================
  Coverage   86.19%   86.19%
=======================================
  Files          13       13
  Lines        2130     2130
=======================================
  Hits         1836     1836
  Misses        169      169
  Partials      125      125

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3b57684...bfbbadd. Read the comment docs.


prediction confidence intervals for regression models

+1 on this!

coolio - I'm going to save this for 0.22.1 release :)


🏇 Data models for the Job Board app

Tasks:

[x] Create the following data models :
- Job_Type
- Location
- Years_Of_Experience
- Preference
[ ] Create tests for the models.

The data models in the ERD:

#29


Swift bug: Messages' widths are not consistent

I have seen this issue with my program (in Swift) for a while. Thus I was very happy to see the new code SwiftExample. Unfortunately that code has the same issue with mine when widths of messages may be changed.
To reproduce:

image 1 is the screen of the device in portrait from the beginning
image 2 is the screen after rotating the device into landscape then rotating back to portrait

I have just played with few different screen sizes on my simulator. Look like SwiftExample can run well in iPhone 4 - 5s but not any bigger ones. Could be screen size detection code problem?
Bellow is iPad screen:

I just saw this also Very interesting.

Thanks for the fix, I am so eager for that!
What is the main code for fixing that sizing problem? Is that two bellow lines in ViewDidLoad?
       self.collectionView?.setNeedsLayout()
       self.collectionView?.layoutSubviews()
My quick test in my app with above code seems not working. Will check further tonight.

Good for now. It is turn out my app using older JSQMessagesViewController library - version 7.2. After updating into 7.3 and then adding two above lines, the sizing problem is fixed for my app. Look like the bug is fixed somewhere in versions > 7.2 - 7.3, plus your new fix in Swift.
Thanks all again :)

👍 🎉 closing as resolved


Run all paragraphs sequentially

What is this PR for?
This PR introduces "run all" behaviour for a note in a sequential manner. The "Run All paragraphs" button will now run the notebook sequentially. There is a UX change as part of this PR, which is discussed below. Any suggestions to make it better are welcome.
Following is the approach taken in brief:

Replace the behaviour of "Run All paragraphs" to "Run All sequentially"
Submit paragraphs to the respective scheduler only after the previous one completes execution (via wait-notify mechanism)
Communicate the status of the sequential run to client over websocket
Since the paragraphs won't be submitted immediately, changing their status is a challenge while keeping the code maintaining it at one place. Therefore, the approach I have taken is to keep the status of the paragrahs as-is and disallow explicit run of individual paragraphs when sequential run is in progress (see GIF for details).

What type of PR is it?
Improvement
Todos
What is the Jira issue?
https://issues.apache.org/jira/browse/ZEPPELIN-2368
How should this be tested?

Have a notebook with different interpreter types (e.g. sh, md, spark etc.)
Click "Run All paragraphs"
The paragraphs should run sequentially
While sequential run is in progress, explicit run of paragraphs should not be allowed
Correct sequential run state should be communicated to the browser when note is loaded

Screenshots (if appropriate)

Questions:

Does the licenses files need update? No
Is there breaking changes for older versions? Probably not, but the UX would be different
Does this needs documentation? Yes

@namanmishra91 Thanks for the contribution. But the implementation is a little complicated to me. I think the easiest implementation is just run paragraphs sequentially in backend. Look at the following code.
https://github.com/apache/zeppelin/blob/master/zeppelin-server/src/main/java/org/apache/zeppelin/socket/NotebookServer.java#L1681
persistAndExecuteSingleParagraph run paragraph in non-blocking way. What we need to do it to run it blocking way.

@zjffdu

What we need to do it to run it blocking way.

The  code does exactly that. It might look complicated overall as a lot of code is related to handling and passing of sequential run state to UI. For backend changes, please check runAllParagraphsSequentially() in NotebookServer.java.
In a gist, sequential run is ultimately performed by SequentialNoteRunner.java which basically runs a paragraph, blocks until it is complete and then submits the next one. If it helps, I can divide this into 2 PRs : one for backend only changes and another for integration with frontend.

@namanmishra91  I don't mean your PR doesn't do it correctly. I mean you could do it in an easier approach with less code changes. Just modifying persistAndExecuteSingleParagraph to make it run paragraph in a blocking way should be sufficient.

@zjffdu Thanks for the feedback. Directly modifying the persistAndExecuteSingleParagraph method will lead to the current behaviour getting lost completely. The reason I chose to not overwrite the existing code flow was that there were suggestions on the JIRA that we should retain the current (concurrent) behaviour as well. Hence, added a new code path in backend as well as UI.

@namanmishra91 I don't see the current behavior is retained in this PR. Personally I don't think the current behavior needs to be retained.  Even we want to keep the current behavior, it should be easy to make persistAndExecuteSingleParagraph to be both blocking and non-blocking (Just add one flag). I don't think it is necessary to invoke any frontend change, backend change should be sufficient.

ping @namanmishra91

@zjffdu Yeah, I can change the implementation to make persistAndExecuteSingleParagraph paragraph blocking. Then we won't need UI side changes for separate event handling etc. However, we will still need other UI changes for paragraph state management because the execution workflow is changing. Just to make sure that we are on the same page, let me take a moment to explain why those will be needed:
Unless we want to change the zeppelin architecture of separate interpreter queues, we need to hold paragraphs to prevent them from being executed. Currently all paragraphs get submitted immediately and their status changes to PENDING. With the above approach, only one paragraph will be in any interpreter's queue at any given point of time; hence the status of yet-to-be executed paragraphs will not get updated and the communication to the user that those paragraphs will run eventually will be lost. This will be a major change in the UX. We need to discuss and think about what should be the best way to handle this but as a preliminary implementation, we need to prevent explicit runs of the paragraphs that are not running yet. This will require maintaining state about whether a run all is in progress and passing this to front-end.
Let me know your thoughts on the above.

@namanmishra91 I don't understand why it would invoke frontend. Backend know more context about paragraph status and backend could control the workflow of paragraph running easily.

@namanmishra91 I made another PR #2627  which only change the backend code. Let me know whether this meet your requirement.

https://github.com/apache/zeppelin/pull/2627 merged
maybe close this PR?

Closed as PR 2627 addresses the same thing


Usage of API in "next" branch?

Hi, how can i generate a token and use the API in the "next" branch?

API requests are not implemented yet for the next-branch

If I'm not mistaken, I believe this has been taken care of by now. You can head over to /restadmin/index to generate one now.

I can confirm that REST API does work, but the URL has changed: cockpit/api/collections/get/{{collectionName}}?token={{apikey}}

The api work also to get thumbnails ?

It doesn't work for thumbnails am I correct?


[v6] Fix kernel of double backward of max_pooling_2d

This PR fixes a bug found in #7923.  v = maxval was missing.  master branch is already fixed by #7939, which is confirmed by #8328, too.

pfnCI, test this please.

Jenkins CI test (for commit f1d847389dbe6afbbedbb292cc5fe3fd6b0d5c78, target branch v6) succeeded!

LGTM! Waiting for https://github.com/chainer/chainer/pull/8075#issuecomment-548304889 to pass the CI failure.

pfnCI, test this please.

Jenkins CI test (for commit f1d847389dbe6afbbedbb292cc5fe3fd6b0d5c78, target branch v6) succeeded!


Add a label that is ScreenReferenced

IF IT IS A NEW FEATURE REQUEST, INCLUDE THIS PART:
Feature description
MapWindow has the ability to draw a label like a map title directly in the map and referenced to the screen rather than the projection. I have been using this for quite some time and would like to transfer that functionality to DotSpatial. Basically I display a map to the user with a quick title in the upper left that does not change position when the user navigates the map. Once they are satisfied with the extents they then export the map as an image. The image has the title as a reference.
In MW I had used this code
Dim hndDraw As Integer = mapMain.NewDrawing(MapWinGIS.tkDrawReferenceList.dlScreenReferencedList)
and see a reference to it in the DS code but am not sure how to use it.
many thanks,
AGP

I have a proposed workaround for this.  have GitHub desktop but just need someone to direct me how to submit a pull request.
AGP


Stop User From Buy Now if Not Logged In!

If User Is not Logged In The Buy Now should Not redirect it to payments page.
Currently Even IF user is not Logged In it redirects to Payments page which is Wrong.
A simple alert can be shown to login to purchase the book.(use Material UI alert Component)
To Know if User is Logged In or Not use UserContext or Observe in navbar etc components to get better Idea.

Issues are assigned on the basis of first come first serve. So I have assigned it to @logicalahara

@Mrhb787 this one is now assigned to me?

@Mrhb787 ok

@Mrhb787 Raised the PR. Please review. I have updated the message to look it more appropriate.


Extract all image versions from templates.

I just specified the values in a constant for now, but we can do
something more sophisticated if we want.

rktbot run tests

rktbot run tests

rktbot run tests


Product create doesn't create non-existing value for dropdown attributes

What I'm trying to achieve
To dynamically create values for dropdown attributes on a product creation page.
Steps to reproduce the problem

Attribute with or without values
Go to the product creation form
Fill the form
Input a non existing value

MyAttribute expects a value but none were given

What I expected to happen
Having the value passed inside the variable so it would be created (note: the mutation should be able to create values dynamically--to verify)
Screenshots

System information
Operating system: Arch
Browser: FF68

Must have been fixed some time ago.


chore(documentation): updating repository URL and name to the new location

Issue number: #2302
Summary
Changes

Please provide a summary of what's being changed

finds and replaces all instances of awslabs/aws-lambda-powertools-python to current repo url
finds and replaces all instances of awslabs.github.io/aws-lambda-powertools-python to new url
User experience

Please share what the user experience looks like before and after this change

Checklist
If your change doesn't seem to apply, please leave them unchecked.

[X] Meet tenets criteria
[X] I have performed a self-review of this change
[X] Changes have been tested
[X] Changes are documented
[X] PR title follows conventional commit semantics

Is this a breaking change?
RFC issue number:
Checklist:

[ ] Migration process documented
[ ] Implement warnings (if it can live side by side)

Acknowledgment
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.
Disclaimer: We value your time and bandwidth. As such, any pull requests created on non-triaged issues might not be successful.

Codecov Report
Patch coverage: 100.00% and project coverage change: -0.07 :warning:

Comparison is base (f02f134) 97.15% compared to head (b1ca6c3) 97.08%.

:exclamation: Current head b1ca6c3 differs from pull request most recent head 9b27b5d. Consider uploading reports for the commit 9b27b5d to get more accurate results

:exclamation: Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.
Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #2499      +/-   ##
===========================================
- Coverage    97.15%   97.08%   -0.07%
===========================================
  Files          157      157
  Lines         7345     7343       -2
  Branches       533      519      -14
===========================================
- Hits          7136     7129       -7
- Misses         160      161       +1
- Partials        49       53       +4

Impacted Files
Coverage Δ

aws_lambda_powertools/logging/logger.py
99.44% <ø> (ø)

aws_lambda_powertools/tracing/tracer.py
99.01% <ø> (-0.99%)
:arrow_down:

aws_lambda_powertools/utilities/batch/base.py
94.08% <ø> (ø)

...bda_powertools/utilities/idempotency/exceptions.py
100.00% <ø> (ø)

...wertools/utilities/idempotency/persistence/base.py
97.15% <ø> (ø)

aws_lambda_powertools/utilities/parameters/ssm.py
97.59% <ø> (ø)

...bda_powertools/utilities/parser/models/dynamodb.py
100.00% <ø> (ø)

...s_lambda_powertools/utilities/parser/models/sqs.py
100.00% <ø> (ø)

...ws_lambda_powertools/utilities/batch/decorators.py
100.00% <100.00%> (ø)

... and 3 files with indirect coverage changes

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.


Code restructure and refactor

IMPORTANT: Where possible all PRs must be linked to a Github issue
Fixes #[issue number]
Type
Choose one: (Bug fix | Feature | Documentation | Testing | Code health | Release | Other)
Checklist

[ ] I have written Unit tests for any new feature(s) and edge cases for bug fixes
[ ] I have added any strings visible on UI components to the strings.xml file
[ ] I have updated the  CHANGELOG.md file for any notable changes to the codebase
[ ] I have run ./gradlew spotlessApply and ./gradlew spotlessCheck to check my code follows the project's style guide
[ ] I have built and run the fhircore app to verify my change fixes the issue and/or does not break the app

@pld @ndegwamartin @ekigamba
Here are some classes the you can review:
View Configuration
Using Android Views (XML or CustomViews)

Every configurable UI will have to implement this interface. ConfigurableView
The view configuration will be provided through sub classes implementing the interface named Configuration
An example of such configuration is RegisterViewConfiguration
As you can see on the configuration file there is helper method for providing default configurations.
Configuration model can be populated with properties from assets, database or build configurations
See how BaseRegisterActivity uses the view configuration to configure it's views. The subclass should only  provide configurations most implementation should be done on the base class.

Composable Views
I tried Jetpack Compose on the login page. It's pretty awesome to work with we'll benefit a lot from using it for configurable views.
Here is the Login Screen that is using Jetpack Compose.
Form CompsableViews I implemented new contract called ConfigurableComposableView that is used to provide view configurations.
These are the configurations used on the new Login Page LoginViewConfiguration
Here is the BaseLoginActivity
ApplicationConfiguration
I also implemented the ApplicationConfiguration model and ConfigurableApplication  interface that has the method configureApplication

This PR on FHIRCore is in a state that it can be used, however, the tests are not fully migrated:

The code that was refactored to the engine module has some tests from the old module that needs to be moved
Documentation on code structure  and architecture is not yet done
Questionnaire and Record Vaccine need refactor - the code does not look good. Elly will need more context for the refactor i.e. understanding of which pieces we need to move to the shared module.

Most of the existing functionalities of the current EIR app have been ported to the new code base though there are a few bugs identified that can be resolved:

There is an issue with loading record vaccine form for users with no immunization history, however for users that have had an immunization before the form works well. I think this will be resolved once the merge conflicts on the refactor branch are addressed.
Implemented  a new and more efficient tool for loading data to the register, there is still some pending implementation (i.e. refreshing data when sync is complete and when a new client has been registered - will work on this just needs some updates on the code)

CC @pld @ellykits @ndegwamartin


JWT Token re-new sample

Regarding your hint, please provide a sample on how to do that on the client side for javascript and C#. Or is the accessTokenFactory automatically invoke again when the Token has expired?
"The access token function you provide is called before every HTTP request made by SignalR. If you need to renew the token in order to keep the connection active (because it may expire during the connection), do so from within this function and return the updated token."

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: d0da2144-3730-f8ef-1d16-a89f11fd6198
Version Independent ID: 6d8f5bc8-8f5c-ba13-b7f2-0366eac46f81
Content: Authentication and authorization in ASP.NET Core SignalR
Content Source: aspnetcore/signalr/authn-and-authz.md
Product: aspnet-core
GitHub Login: @tdykstra
Microsoft Alias: anurse

@anurse  please respond.

Or is the accessTokenFactory automatically invoke again when the Token has expired

The accessTokenFactory is invoked for every request, so you can check the expiry of the token within it. Here's some pseudo-code (AccessToken, IsExpired and GetTokenAsync need to be provided, the implementation depends on how your tokens work):
AccessToken currentToken = null;
var connection = new HubConnectionBuilder()
    .WithUrl("...", options => {
        options.AccessTokenFactory = async () =>
        {
            if(currentToken == null || IsExpired(currentToken))
            {
                currentToken = await GetTokenAsync();
            }
            return currentToken.BearerToken;
        };
    })
    .Build();

A JWT token should include the expiry in the token itself, so it should be possible to check this against DateTime.Now in your IsExpired method. Exactly how that works depends on what you are using to provide your tokens.

@anurse  thanks for the response. I'll leave it up to you if you want to add this to the doc. It's very discoverable from the page.

@anurse Thanks for clarifications about the invocation cycle.
At least I expected a running sample for a Javascript Client and a .Net Client. and
why do you close that issue. Documenation os still not updated!
@Rick-Anderson I guess you never developed a real project otherwise you couldn't say "it's discoverable
from the page". Because it's not.

Please provide in the documention following examples

Javascript Client with JWT auth/re-auth to real Asp.Net Core WebApp with SignalR hub
.NET Client with JWT auth/re-auth to real Asp.Net Core WebApp with SignalR hub

You can close that issue. I digged through the samples and with regards to that issue I now know how to do it https://github.com/aspnet/SignalR/issues/2864#issuecomment-415953308
Maybe you can reference that samples in the documenation

@ericbrunner thanks for reporting back. It looks like this is the sample
https://github.com/aspnet/SignalR/tree/release/2.2/samples/JwtSample

Or is the accessTokenFactory automatically invoke again when the Token has expired

The accessTokenFactory is invoked for every request, so you can check the expiry of the token within it. Here's some pseudo-code (AccessToken, IsExpired and GetTokenAsync need to be provided, the implementation depends on how your tokens work):
AccessToken currentToken = null;
var connection = new HubConnectionBuilder()
    .WithUrl("...", options => {
        options.AccessTokenFactory = async () =>
        {
            if(currentToken == null || IsExpired(currentToken))
            {
                currentToken = await GetTokenAsync();
            }
            return currentToken.BearerToken;
        };
    })
    .Build();

A JWT token should include the expiry in the token itself, so it should be possible to check this against DateTime.Now in your IsExpired method. Exactly how that works depends on what you are using to provide your tokens.

Do you have a similar code snippet for javascript?


Additional information on supplier / customer parts list

As an User
I want to have further information displayed on the supplier and customer parts list

ID
Production Country
batchId
van

so that a search for parts is easier for me and I have a better user experiance.
Hints / Details
Acceptance Criteria

[ ] Columns are available for user and can be used to detect the parts

Out of Scope

...

won't do


Added locale params to specific methods

Added optional locale to the following methods' object parameter:

getObjectsByType
getObjectType
getObjectsBySearch

Thanks Flynn! 👍


Add a --kubeconfig flag in the root command

Is your feature request related to a problem? Please describe.
After working on #2497 I realized that there is no global Kubernetes configuration setting. This means that each tool is responsible for resolving the configuration file using their own hierarchy. This probably works for the most part as most tools will look for the env var $KUBECONFIG or in the path ~/.kube/config. Each individual tool seems to either define its set of possible flags but there is no guaranteed overlap. It would be a lot better to have a single place to configure Kubernetes configuration for all tools.
Describe the solution you'd like

Given A Zarf CLI command that connects to k8s executes.
When A --kubeconfig flag is passed in the root command.
Then The --kubeconfig path should be used for client configuration.

Describe alternatives you've considered
The alternative would be to leave things as it is and just allow each tool to define their own hierarchy of picking up configuration.
Additional context
N/A

this would be also helpful in case working with k3s, as zarf is not considering the default path for the kubeconfig /etc/rancher/k3s/k3s.yaml


Passing StateNotifier as argument to a ConsumerWidget

I am really new to Flutter, so excuse me if this is suppose to be like this. Feel free to remove this issue if neccessary.
Description
I have created a ConsumerWidget called ListViewWidget, this takes in a provider. Unfortunately, inside this scope, I cannot call
provider.state. Following exception is given:
Class 'StateNotifierProvider' has no instance getter 'state'.
Receiver: Instance of 'StateNotifierProvider'
Tried calling: state
file: main.dart
void main() {
  runApp(ProviderScope(child: MyApp()));
}

final provder = StateNotifierProvider((ref) => ListNotifier(List<Item>(5)));

class MyApp extends StatelessWidget {
  @override
  Widget build(BuildContext context) {
    return MaterialApp(
        ......
        home: MyHomePage());
  }
}

class MyHomePage extends ConsumerWidget {
  @override
  Widget build(BuildContext context, ScopedReader watch) {
    return Scaffold(
      body: Center(child: ListViewWidget(provider)),
      floatingActionButton: FloatingActionButton(
        onPressed: () {
          context.read(provider).add(Item("exampleId"));
        },
      ),
    );
  }
}

file: list-view.dart

class ListViewWidget extends ConsumerWidget {
  final provider;

  ListViewWidget(this.provider, {Key key}) : super(key: key);

  @override
  Widget build(BuildContext context, ScopedReader watch) {
    final item = watch(provider.state);

    return GridView.count(
      crossAxisCount: 3,
      children: List.generate(item.length, (index) {
        return Center(child: Icon(Icons.folder));
      }),
    );
  }
}

The only working solution for this is to send provider.state when I have the ConsumerWidget in a seperate file. Why shouldn't we be able to send provider as it is and then call provider.state inside the ConsumerWidget?
      body: Center(child: ListViewWidget(provider.state)),

I tried recreating the issue with the folowing code:
class NumbersNotifier extends StateNotifier<List<int>> {
  NumbersNotifier() : super([]);

  void add(int number) {
    state = [...state, number];
  }

  void delete(int number) {
    state = [
      for (final loopNumber in state) if (number != loopNumber) loopNumber,
    ];
  }
}

void main() {
  runApp(ProviderScope(child: MyApp()));
}

final provider = StateNotifierProvider((ref) => NumbersNotifier());

class MyApp extends StatelessWidget {
  @override
  Widget build(BuildContext context) {
    return MaterialApp(
      debugShowCheckedModeBanner: false,
      title: 'Flutter Demo',
      theme: ThemeData(
        primarySwatch: Colors.blue,
        visualDensity: VisualDensity.adaptivePlatformDensity,
      ),
      home: MyHomePage(),
    );
  }
}

class MyHomePage extends ConsumerWidget {
  @override
  Widget build(BuildContext context, ScopedReader watch) {
    return Scaffold(
      body: Center(child: ListViewWidget(provider)),
      floatingActionButton: FloatingActionButton(
        onPressed: () {
          context.read(provider).add(5);
        },
      ),
    );
  }
}

class ListViewWidget extends ConsumerWidget {
  final StateNotifierProvider<NumbersNotifier> passedProvider;

  ListViewWidget(this.passedProvider, {Key key}) : super(key: key);

  @override
  Widget build(BuildContext context, ScopedReader watch) {
    final item = watch(passedProvider.state);

    return GridView.count(
      crossAxisCount: 3,
      children: List.generate(item.length, (index) {
        return Center(child: Icon(Icons.folder));
      }),
    );
  }
}

But it seems to be working as expected. I think it would be easier if you could provide all the code so we can copy paste the solution and try it out :).

@socketopp @RobertBrunhage If your use ConsumerWidget then your don't need use any provider like parameter, ScopedReader watch all providers. Your can remove provider from the ListViewWidget and watch it with ScopedReader this is a power of the ConsumerWidget.

@iamarnas Maybe I misunderstood but the question is how you would send a provider through the contructor which can be a valid case if you use private providers to limit the scope.
I updated my code example to make this more obvious!

@RobertBrunhage With Riverpod don't need send a provider through the contructor 😁 Consumer read them all in the UI.

@iamarnas If the provider is private (the provider can only be used in that file) and the widget is in another file you have to pass it through the constructor, or else you can not access it.

@RobertBrunhage Yes. But I personally privat providers only combine with anothers providers otherwise I leave them globals. Send a provider through the contructor is to boilerplate to me.

@RobertBrunhage, @iamarnas, I have just updated my code so you can copy and test it.
I just discovered that the error, i.e. difference between @RobertBrunhage and my code.
It seems that it works to pass the provider as parameter, but if you do, one have to specifify the type:
final StateNotifierProvider<ListNotifier> _provider;
When adding the type, the error goes away.

@socketopp Wrote that in the bottom of my first comment 😃

This seems to be working as expected. If I remove the type from the passedProvider I recieve the same error as you which I think is expected

Glad it is working for you now!
just be aware that if you have your provider not private you don't have to pass it through the constructor, as @iamarnas was talking about!

You need to type your provider and specify a generic constraints:
abstract class Fetchable<State> implements StateNotifier<State> {
  Future<State> fetchData();
}

class PaginatedListView<Notifier extends Fetchable<State>, State> extends StatefulWidget {
  final StateNotifierProvider<Notifier, State> provider;
  final Widget? Function(State item) itemBuilder;


Heads up.  These are state developments that are in the works.

Some of the ideas in fastsql, the ones that work, will be moved to sql eventually.  Having separate tables does not appear to be a good idea.  H2 has no INSERT IGNORE except in mysql mode and it is slow.

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.