When getting scripts, ensure there's an active context

JsDiagGetScripts() will return JsNoCurrentContext if there's not an active context. Ensure there is an active context so it can return the scripts.

In the process of writing a test for the fix I ran into more issues.  I think this should be a complete fix.  @akrantz can you try it out?

@digitalinfinity Does this look reasonable to you?

@kfarnung The updated code works in terms of being able to return scripts when GetScripts() is called. However, the script is loaded as "Unknown script code" and therefore debugging doesn't work. The source is built by webpack into "index.win32.bundle.js" and has associate source map "index.win32.bundle.js.map".
The VS Code debugger trace shows:
← From target: {"method":"Debugger.scriptParsed","params":{"scriptId":"1","url":"Unknown script code","startLine":0,"startColumn":0,"endLine":15,"endColumn":0,"executionContextId":0,"hash":"","isLiveEdit":false,"sourceMapURL":"index.win32.bundle.map","hasSourceURL":false}}
← From target: {"method":"Debugger.scriptParsed","params":{"scriptId":"3","url":"Unknown script code","startLine":0,"startColumn":0,"endLine":2,"endColumn":0,"executionContextId":0,"hash":"","isLiveEdit":false,"sourceMapURL":"index.win32.bundle.js.map","hasSourceURL":false}}

I'm unclear why the url here is "Unknown script code".
The script is loaded via a call to JsRun() for two bundles. The first is "excel-udf-host.win32.bundle" which is for the custom function runtime code. The second is "index.win32.bundle" which is the script built for my Excel add-in.

I didn't have breakpoints set but hitting pause in VSCode will generate a break event followed by getting source. I have tracepoints in VS on protocol message request and response:
{"type":"request","payload":{"id":25,"method":"Debugger.getScriptSource","params":{"scriptId":"1"}}},
{"type":"response","payload":{"id":25,"result":{"scriptSource":"!function(e){var t={};function n(r){if....

@digitalinfinity  The comment above shows the service handler providing the script source but it's not appearing in VS Code or Chrome. Since Kyle is on vacation, it would help if someone else can assist with understanding what's going on here. I'm continuing to drill into this and find out.

@kfarnung @digitalinfinity I made progress yesterday in getting the scripts to show. There are two JavaScript files loaded use JsCreateExternalArrayBuffer/JsRun(). The Office runtime code was specifying JS_NO_SOURCE_CONTEXT (-1) for the script context parameter. I updated the code to pass 0/1 to the calls. The scripts now show up in VS Code.
However, breakpoints are not working. I'll be investigating this more today.
One other thing I noticed is that the calculation of the hash is not implemented. As two scripts could share the same filename, I am wondering if we should have the hash calculated so it can differentiate between two different files with the same name.
I also have made changes to the sample exe to add a --buffer argument which allows it to load the script using JsCreateExternalArrayBuffer/JsRun instead of RunScript.
I would like to have the sample exe support multiple script files, but hadn't come up with the best way to do this. Right now, the first arg is the script and the rest of the args are specified for that script. I am considering adding a --script parameter which can be used to add additional scripts. This would allow the additional script(s) to be loaded and run first (without args), and then the main script is run with args as is done now. Another approach might be to use "--" to separate scripts and each group between "--" would be a script with its args, so each group can be have args specified and run.

@kfarnung @digitalinfinity Having found and fixed the problem in my code causing the deadlock when processing the command queue, this looks good. I made a separate PR for the sample exe changes.


5 set python version in devcontainer to 311

Closes #5

deleted branch as we discovered that ROS Humble is incompatible with 3.11 and requires 3.10. Aligned within Mission Software Team on 2024-04-09.


Error while deploying to Azure App service

We are trying to Deploy Azure App Service from GitHub Actions using Windows Self-Hosted Action Runner
Using task - https://github.com/Azure/webapps-deploy
workflow -
- name: Deploy to Azure WebApp
uses: Azure/webapps-deploy@v2
with:
# app-name: ${{ env.AZURE_WEBAPP_NAME }}
publish-profile: ${{ secrets.AZURE_WEBAPP_PUBLISH_PROFILE }}
package:  './myapp/PackageTmp'
We are getting below error -
Deployment Failed with Error: Error: Failed to deploy web package to App Service. SyntaxError: Error parsing E:\actions-runner\AR_work_actions\Azure\webapps-deploy\v2\node_modules\tunnel\package.json: Unexpected token < in JSON at position 2
Can you please suggest.
Thanks

Hey @vinaysandela Can you please confirm if

The app-name field is commented or uncommented because deployment is going to fail without it.
Is it running fine on github hosted runners?(windows-latest/ ubuntu-latest)?
The package path provided is correct or not.

Also please check if the dependencies required by the app are being fulfilled or not. Visit example workflows for more context. please let us know if it works.

@vinaysandela any updates on this issue? Can you share your workflow if the issue still persists.

@BALAGA-GAYATRI I got the same issue on my self-hosted runners.
Package deployment using ZIP Deploy initiated.
Error: Failed to deploy web package to App Service.
Error: Deployment Failed with Error: Error: Failed to deploy web package to App Service.
SyntaxError: Error parsing /opt/actions-runner/_work/_actions/azure/webapps-deploy/v2/node_modules/tunnel/package.json: Unexpected token < in JSON at position 2

It seems there is a unresolved git diff in the package.json of tunnel in the current
v2 release.
{
<<<<<<< HEAD
  "name": "tunnel",
  "version": "0.0.6",
=======
  "_from"<EMAIL_ADDRESS>  "_id"<EMAIL_ADDRESS>  "_inBundle": false,
  "_integrity": "sha512-1h/Lnq9yajKY2PEbBadPXj3VxsDDu844OnaAo52UVmIzIvwwtBPIuNvkjuzBlTWpfJyUbG3ez0KSBibQkj4ojg==",
  "_location": "/tunnel",
  "_phantomChildren": {},
  "_requested": {
    "type": "version",
    "registry": true,
    "raw"<EMAIL_ADDRESS>    "name": "tunnel",
    "escapedName": "tunnel",
    "rawSpec": "0.0.6",
    "saveSpec": null,
    "fetchSpec": "0.0.6"
  },
  "_requiredBy": [
    "/typed-rest-client"
  ],
  "_resolved": "https://registry.npmjs.org/tunnel/-/tunnel-0.0.6.tgz",
  "_shasum": "72f1314b34a5b192db012324df2cc587ca47f92c",
  "_spec"<EMAIL_ADDRESS>  "_where": "E:\\Repos\\GHActions\\webapps-deploy\\node_modules\\typed-rest-client",
  "author": {
    "name": "Koichi Kobayashi",
    "email"<EMAIL_ADDRESS>  },
  "bugs": {
    "url": "https://github.com/koichik/node-tunnel/issues"
  },
  "bundleDependencies": false,
  "deprecated": false,
>>>>>>> 798e43877120eda6a2a690a4f212c545e586ae31
  "description": "Node HTTP/HTTPS Agents for tunneling proxies",
  "devDependencies": {
    "mocha": "^5.2.0",
    "should": "^13.2.3"
  },
  "directories": {
    "lib": "./lib"
  },
  "engines": {
    "node": ">=0.6.11 <=0.7.0 || >=0.7.3"
  },
  "homepage": "https://github.com/koichik/node-tunnel/",
  "keywords": [
    "http",
    "https",
    "agent",
    "proxy",
    "tunnel"
  ],
  "license": "MIT",
  "main": "./index.js",
  "name": "tunnel",
  "repository": {
    "type": "git",
    "url": "git+https://github.com/koichik/node-tunnel.git"
  },
  "scripts": {
    "test": "mocha"
<<<<<<< HEAD
  },
  "devDependencies": {
    "mocha": "^5.2.0",
    "should": "^13.2.3"
  },
  "engines": {
    "node": ">=0.6.11 <=0.7.0 || >=0.7.3"
  }

,"_resolved": "https://registry.npmjs.org/tunnel/-/tunnel-0.0.6.tgz"
,"_integrity": "sha512-1h/Lnq9yajKY2PEbBadPXj3VxsDDu844OnaAo52UVmIzIvwwtBPIuNvkjuzBlTWpfJyUbG3ez0KSBibQkj4ojg=="
,"_from"<EMAIL_ADDRESS>}
=======
  },
  "version": "0.0.6"
}
>>>>>>> 798e43877120eda6a2a690a4f212c545e586ae31

I've been deploying webapps-deploy@v2 fine till about 30 days ago then this error started occurring. Looking at files on the server we confirmed that the package.json file looked like @rbinder-vg's file.
Can confirm rolling back to webapps-deploy@v1 let's us get past this issue.

I am facing the same issue. And I can confirm @rbinder-vg's finding.

This issue should be re-opened and addressed. I am also facing the same error/problem and have had to resort back to webapps-deploy@v1 to get it working.

We have fixed this issue in our last release, please try using v2 and see if it's working fine.
Closing this, please re-open or create new issue in case of any issues.


refactor: set minimum rules_nodejs version to 6.0.5

This will get bumped again to 6.1.0 once https://github.com/bazelbuild/rules_nodejs/pull/3736 landed

Let's just land that first so you don't have to bump again

Let's just land that first so you don't have to bump again

It's just waiting on a stamp

merged it


Fix missing null check for JDBC init script

In PR https://github.com/testcontainers/testcontainers-java/pull/7680, a new feature was introduced to support multiple init scripts in JdbcDatabaseContainer. However, during this update, a critical null check was inadvertently removed from the JdbcDatabaseContainer.runInitScriptIfRequired method. This check was responsible for ignoring null values for the initScript parameter.
As a result, when no init script is defined, a null value is passed to ScriptUtils.runInitScript, leading to an exception being thrown and preventing the database container from starting.
This commit reinstates the missing null check, ensuring that undefined init scripts are properly handled. Additionally, a test has been added to verify that the issue is resolved and the database container can start without an init script.

Thanks for your contribution, @mmorshedi!


Add alloc to the crate graph

alloc has been added to the crate graph.
Completions work, but they are available even when the user has not declared an extern crate alloc. Is this the correct approach?
Fixes #2376.

I think this is a good start. Properly requiring extern crate here would need some more tweaking.
bors merge


Amend download data tables text

INFO

At the bottom of each Concepts page there is a link to download the latest version of the 'Data Tables'. This should say 'NPD Data Tables.
After clicking on this link, the user is eventually taken to a page with a green 'Download' button. The title of this page is 'Download Data Tables file' - it should be changed to 'Download NPD Data Tables file'.

ACCEPTANCE CRITERIA

At the bottom of each Concepts page, the title of the link is changed from 'Click here to download the latest version of the Data Tables' to 'Click here to download the latest version of the NPD Data Tables'.
After clicking this link and eventually being taken to the download page, the title of this page is changed from 'Download Data Tables file' to 'Download NPD Data Tables file'.

Assigning to @GMcGill-DfE to approve.

Approved

Assigning to @cacquani to action

Tested and successfully released to production on 07/10/2020. Ticket closed.


feat: canonicalQueryWhitelist

🔗 Linked issue

https://github.com/harlan-zw/nuxt-seo/issues/276
❓ Type of change

[ ] 📖 Documentation (updates to the documentation or readme)
[ ] 🐞 Bug fix (a non-breaking change that fixes an issue)
[ ] 👌 Enhancement (improving an existing functionality)
[x] ✨ New feature (a non-breaking change that adds functionality)
[ ] 🧹 Chore (updates to the build process or auxiliary tools and libraries)
[ ] ⚠ Breaking change (fix or feature that would cause existing functionality to change)

📚 Description

Adds support for having query params in the canonical URL, this is important when using query param pagination or searching.
Default whitelist:
[
  'page',
  'sort',
  'filter',
  'search',
  'q',
  'category',
  'tag',
],

Thanks for the update!
I suggest marking such changes as breaking, as these new defaults have SEO implications.

Every RC update is potentially breaking, I should have left it as a beta but too late for that 😕
Trying to get it stable asap


Update gif for card static

Related Ticket(s)
Enhancement to #1125
Description
Trimmed down the animated gif for Card static - cut time at start and finish, as well as excess frames for non-card pages.
Changelog
New

N/A

Changed

animated gif for Card static

Removed

N/A

Hey @RichKummer, I know you're out right now but catching this link to a Slack discussion with Shixie & James re the tag in static Card.


Microbenchmark regressions related to GC changes

This tracker is for issues related to:

Dart VM

Flutter has a microbenchmark that just send 1MB of data back and forth between the host platform and Flutter via platform channels.  It had 2 major regressions in the past month that appear to be related to GC changes.  I'm not sure if those regressions were expected.
Resources:

Suspected Regression PR 1: https://dart.googlesource.com/sdk.git/+/57f68b377a700616300c52ab8977bc9a12fa0b9b
Suspected Regression PR 2: https://github.com/dart-lang/sdk/commit/305c3e30c6aea9c05a1abec35eb5f7e09f716348
The microbenchmark: https://github.com/flutter/flutter/blob/a184f4f2bc65c3e06e19f6fd6ba63464ff47c739/dev/benchmarks/platform_channels_benchmarks/lib/main.dart#L232
Results of regression 1: https://flutter-flutter-perf.skia.org/e/?begin=1654299791&end=1656090848&keys=X797bf4cedf04c3cac8ff628e7b1d2a24&requestType=0
Results of regression 2: https://flutter-flutter-perf.skia.org/e/?begin=1650870000&end=1651302000&queries=sub_result%3Dplatform_channel_basic_binary_2host_1MB&requestType=0

cc @a-siva @rmacnak-google

//cc @rmacnak-google was there any actionable item from these two micro benchmark regressions ?


Use clang-offload-bundler to access hipcc-built source kernels

This replaces building an so and using extractkernel


StaticLibraryAttribute handling doesn't work unless it happens to be in the Windows namespace

Summary
I'm trying to update https://github.com/wravery/webview2-rs to the latest versions of the windows-rs crates, and I ran into a couple of issues with windows-bindgen. It's evaluating these if statements in the wrong order, so anytime it does not start with the Windows. namespace it emits the dynamic link attribute whether or not there's a StaticLibraryAttribute:
    if gen.std || !gen.namespace.starts_with("Windows.") {
        let library = library.trim_end_matches(".dll");

        quote! {
            #[link(name = #library)]
            extern #abi {
                #link_name
                pub fn #ident(#(#params),*) #return_type;
            }
        }
    } else if let Some(library) = gen.reader.method_def_static_lib(signature.def) {

I was already working around a separate issue with the WebView2LoaderStatic.lib and the gnu toolchain by patching the #[link] attributes with a regex, so I was able to modify the regex pattern to handle this, but for any other user of windows-bindgen with static libraries, I don't think it's outputting the correct #[link] attributes anymore.
Crate manifest
https://github.com/wravery/webview2-rs/blob/main/crates/bindings/Cargo.toml

Crate code
https://github.com/wravery/webview2-rs/blob/main/crates/bindings/build.rs (comment out the lines where it reads the file back in, runs the contents through `patch_bindings`, and writes the file back out).

Hi Bill, I thought we added a test for your scenario...? If not, we really should. 😏

I thought I remembered there being one too, but I haven't found it yet. We might be thinking of this sample in the win32metadata project.

I think the issue has always been that it's too difficult to test since it requires metadata and that requires the whole win32metadata  toolchain, which is why I've been working so hard on bringing up riddle to handle that directly.

Seems like we can just evaluate method_def_static_lib before all else and it should work fine.
https://github.com/microsoft/windows-rs/blob/101467caf5c14f051556577dea0b50744e294304/crates/libs/bindgen/src/rust/functions.rs#L228
I tried to test it but since your binding generator patches up the link attributes anyway, it seems a little pointless to have this in windows-rs at all. Thoughts?

That's a fair question, I think it depends on if anyone else has ever used this feature, and I'm guessing they probably haven't if I'm the only one who noticed. I'm likely the only one patching the link attribute as well, since this changed the output and the pattern no longer matched.
What might work even better in my scenario would be a way to pass in substitutions to bindgen, e.g. if a (case-insensitive) library with the specified name is about to be used in a link attribute, substitute this string for the entire link attribute. Theoretically there might be other cases where you'd want to just re-route to a shim DLL, or in my case, use more complicated cfg_attr attributes to embed alternate link attributes depending on the target.
What do you think of this approach instead, and then we could just remove all of the StaticLibraryAttribute handling? If this seems reasonable but you don't have time, I can try to put it in a PR.

The other challenge with standardizing this is that the use case here only covers static libs for MSVC but the attribute isn't specific about that.

That makes sense to me. Do you have any pointers for how to get started with riddle vs. winmd files? Is that a WinRT specific thing, or does it work with C++ headers as well?

I'm still working on riddle support for Win32/COM APIs. The idea is that not only will it be able to parse .winmd files but it should also be able to parse .h and .idl files so that we can produce Win32 metadata directly.


libtxt: per-character font fallback

Currently with libtxt if you have a text file that contains a variety of Unicode characters (and you don't have a font on your system that has all of them), it won't display properly, because it doesn't do per-character font fallback.
The old text system did do per-character font fallback.
You can test this using the "Test Font Fallback" feature of the dev/manual_tests/text.dart test (see https://github.com/flutter/flutter/pull/12791).
This is critical for i18n.

cc @jason-simmons

This has landed


[FEATURE REQ] [Diagnostics] Contract to get region from where the request was served

More info:

Goal - For a particular request, from which region this request was served.

We have added getRegionsContacted() API in CosmosDiagnostics for each request. This is done.


[Feature Request] Linter rule to enforce consistent API version across codebase

Is your feature request related to a problem? Please describe.
Currently, Bicep requires hard-coding the API version, i.e. specifying it explicitly next to each parent resource. It must be a literal string, it doesn't support a variable, e.g.:
resource cluster 'Microsoft.ServiceFabric/clusters@2021-06-01' existing = {
  // ...
}

This may easily lead to an inconsistency between API versions of the same resource type across different Bicep files. Moreover, nothing prevents using multiple API versions within the same file.
Note, this is not the case in regular ARM template: it supports using a variable/parameter, which may come from a single location:
{
  "name": "Common",
  "type": "Microsoft.Resources/deployments",
  "apiVersion": "[variables('deploymentApiVersion')]",
  "properties": {
    "mode": "Incremental",
    "templateLink": {
      "uri": "[parameters('template_Common')]",
      "contentVersion": "<IP_ADDRESS>"
    }
  }
},
{
  "name": "Resource1",
  "type": "Microsoft.Resources/deployments",
  "apiVersion": "[variables('deploymentApiVersion')]",
  "properties": {
    "mode": "Incremental",
    "templateLink": {
      "uri": "[parameters('template_Resource1')]",
      "contentVersion": "<IP_ADDRESS>"
    },
    "parameters": {
      "apiProfile": {
            "value": "[reference('Common').outputs.apiProfile.value]" // a source of truth for all API versions used across the codebase
          },
  },
  "dependsOn": [
    "[resourceId('Microsoft.Resources/deployments', 'Common')]"
  ]
}

Describe the solution you'd like
In the leu of a solution for https://github.com/Azure/bicep/issues/10683 and an improvement towards https://github.com/Azure/bicep/issues/622, I propose a linter rule which would:

Either require an API version to be the same in all files in the folder (per resource type)
Or enforce a certain API version to be used (again, per resource type)

Somewhat related to #622


Get rid of pause container

We introduced a pause container to have a pod running when all containers have finished execution.
Since hyperstart has added support for keeping a pod alive, we should get rid of the pause container and port the changes into clearcontainers repo instead.
In case of docker, we may not want this behaviour altogether, this should be passed as a additional parameter to the agent to indicate if the pod should be kept around.

@amshinde - can you update this issue?

This issue is related to https://github.com/clearcontainers/agent/issues/81.
Indeed, we need to fix the agent first, and then we will be able to adapt virtcontainers.

@sboeuf  -- can we update / close?

Yes, can be closed !


[BUG] Not able to send SPL tokens

Describe the bug
It is not possible to send SPL on iOS tokens as the gas is 0.
To Reproduce
Steps to reproduce the behavior:

Go to SOL
Click on a SPL
try to send
See error

Expected behavior
Able to send SPL Tokens
Screenshots

Version 1.2.2

QA done.


Add shoot reference protection for DNS secrets

How to categorize this PR?

/area robustness
/kind enhancement
/priority normal
What this PR does / why we need it:
This PR adds a new controller to GCM which scans shoot objects for referenced DNS provider secrets in order to protect them from deletion requests as long as they are actively being referenced. More information can be found in the contained documentation.
Which issue(s) this PR fixes:
Fixes #2738
Release note:

Gardener now protects DNS provider secrets from deletion requests as long as they are still being referenced by one or multiple shoot clusters. More information can be found in the documentation `docs/concepts/controller-manager.md#Shoot Reference Controller`.

/needs changes
/status author-action

Several updates and changes since the last review round:

Gardener managed secrets in the Garden cluster (SSH Keypair, Kubeconfig, Monitoring) are now labelled with gardener.cloud/role.
The shoot reference controller disregards secrets with gardener.cloud/role to decrease the amount of iterated secrets and in favor of adding another secret controller like proposed from @timebertt (discussed in internal meeting).
Finalizers are now patched instead of updated.
In case of deletion, finalizers are only removed if shoot the shoot was successfully deleted by Gardener (no gardener finalizer).
The Gardener client is passed to shoot related controller of GCM in favor of the whole ClientMap which reduces error handling.
CreateWorker now injects the passed context and further objects into the reconcile.Reconciler implementation.

Is that to be consistent with the injection of the context injection or is there more to it?

The idea was to align it more with the reconcilers we wrote for the extensions and the Controller-Runtime in general. Handing it over instead would have worked as well.

Thanks for your valuable feedback. I addressed all your comments.

No comments, just one question: Will all of this work if the new Gardener version (with this change) is deployed but there are still shoots which weren't reconciled yet (i.e., shoots whose ssh-keypair/kubeconfig secrets don't have the role labels yet)?

Good question @rfranzke! I'll work but of course the reconciler then needs to cache and iterate over a lot more secrets in the beginning. Are you proposing to split the PR up and release it in two iterations?

I'm not proposing anything yet :) Just wanted to raise this question. If you think this is not a problem then let's get it in as is.

Well, thanks @rfranzke! To be on the safe side, I opened #2844 which should then be released first after this PR gets merged.

/do-not-merge and wait for #2844 to be released.

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

/unhold
/needs-rebase

/remove needs rebase


echo_client doesn't call echo_client_on_new_stream() with FreeBSD

Thank you for developing a great library.
I am testing lsquic with FreeBSD 13.1-RELEASE and am having the following problem with echo_client:

Though client connects to server on localhost and lsquic_conn_make_stream() is called in echo_client_on_new_conn(), on_new_stream event which is echo_client_on_new_conn() is not called.
As a result, no stdin input is read and connection is automatically closed.

Is this a correct behavior or is there anything wrong with it?
I'll attach the logs.
client.log
server.log

This has been solved by specifying -s locahost:port for echo_client.
I apologize for the inconvenience.


How to invalidate form if FieldArray length is 0?

I'm trying to invalidate a form based on the length of the field array.
So if the validate function returns {} to signify that the form is valid, and it returns {itemSupplier: 'Whoops'} if itemSupplier is wrong, I assumed Id be able to do something like:
const validate = formData => {
  return formData.list.length === 0
  ? {list: 'Min length is 0'}
  : {}
}

I've tried a few other things, including:
const validate = formData => {
  return formData.list.length === 0
  ? {list: ['Min length is 0']}
  : {}
}

and
const validate = formData => {
  return formData.list.length === 0
  ? {list: [{itemName: 'Min length is 0']}
  : {}
}

Any help would be appreciated

According to the docs, you need to report errors of the whole array in the _error key.
const validate = data => {
    const errors = {};

    if ( data.list.length ) {
        // apply validation to each item individually
    } else {
       // or perhaps make it an array, so you can use both per-item errors and array errors
        errors.list = {
            _error: "bla"
        };
    }
}


[✨] rename component$ to $$

Is your feature request related to a problem?
no actually, just an readability improvement
Describe the solution you'd like
currently, we have
export const MyComp = component$(() => {
  ...
});

the idea is to rename a long component definition to a short one
export const MyComp = $$(() => {
  ...
});

having that two key features of framework $() - reactive function and $$() - reactive component, make it shorter and simpler
Describe alternatives you've considered
no alternatives I see
Additional context
No response

Thanks for the suggestion @dmitryuck
This is not a small change and will affect lots of people (especially content creators) and overall perception of stability of the framework.
Personally I like component$ as I believe it conveys better the meaning to the developer. ($ and $$ might be too close and thus confusing)
We also predict that most of the time, components will be generated either by CLI, nx generators, snippets or copy& paste, so it's not as common as reactive functions.
So while we like to keep names short, it's not a change we are planning to consider for the near future.
I'm closing it for now, but thanks again for trying to make Qwik better!


ModulePaths Include doesn't work as described here

The example under the heading "The following example specifies that only a single assembly should be included in code coverage" does not work or me. I had to modify ModulePath line as follows for it to work -
<ModulePath>.*Fabrikam.Math.dll$</ModulePath>
Brad

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 43dc6fcf-df9f-9d2a-5c6e-8da0f6925afc
Version Independent ID: d0bf2cae-9b59-d537-7acb-7af5f560d8c1
Content: Customizing Code Coverage Analysis - Visual Studio
Content Source: docs/test/customizing-code-coverage-analysis.md
Product: visual-studio-windows
Technology: vs-ide-test
GitHub Login: @Mikejo5000
Microsoft Alias: mikejo

@kendrahavens @AbhitejJohn Should the example be updated as suggested, from
Fabrikam.Math.dll to .*Fabrikam.Math.dll$ ? It's a little puzzling why the regular expression is required for specifying a single assembly...

At least .* has to be added at the beginning ( .*Fabrikam.Math.dll). Otherwise it's not working as we full path match is required.

I will go ahead and update the doc. Thx!


Bug/minification error

Pull Request Test Coverage Report for Build 75

4 of 4 (100.0%)  changed or added relevant lines in 4 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage increased (+0.001%) to 99.817%

Totals

Change from base Build 72:
0.001%

Covered Lines:
546

Relevant Lines:
547

💛  - Coveralls

Pull Request Test Coverage Report for Build 75

4 of 4 (100.0%)  changed or added relevant lines in 4 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage increased (+0.001%) to 99.817%

Totals

Change from base Build 72:
0.001%

Covered Lines:
546

Relevant Lines:
547

💛  - Coveralls


Does the plugin work in research mode?

Hi,
I'm currently trying to make an Unity app that works with HoloLens streams, so I work with the research mode enabled. I currently have issues with getting the stream from the POV camera and I found your plugin that could help me. I could find anywhere mentioned if it works in research mode as well so I am asking before trying it.
Thank you.

Here is a sample project which makes use of the short-throw time-of-flight depth camera (research stream) and photo-video camera streams in Unity through IL2CPP build support.

Thank you so much, that helped.


[HUDI-8160] Verify the consistency of the user-defined schema and the existing hoodie scheme when creating the hoodie table

Change Logs
Verify that the user-defined schema and the hoodie table schema are consistent when creating a table.
Impact
When the hoodie schema is inconsistent with the user-defined schema, the table creation fails. To avoid failure during writing.
Risk level (write none, low medium or high below)
None
Documentation Update
None
Contributor's checklist

[x] Read through contributor's guide
[x] Change Logs and Impact were stated clearly
[x] Adequate tests were added if applicable
[ ] CI passed

It looks like we still have test failures.

@huangxiaopingRD Hi, we still have genkins CI failures.


Documentation missing for CallbackFunction

File: themes/default/content/registry/packages/aws/api-docs/lambda/_index.md
The lambda object is supposed to have a function called CallbackFunction as mentioned in this guide. However the linked documentation page doesn't include that function.

Today, we don't publish SDK-specific documentation and CallbackFunction is specific to the NodeJS SDK. As a workaround, you can use the doc strings that are embedded as part of the code.

I understand. However, the guide I mentioned does link to the docs at that location for more information on CallbackFunction. It says, "For more information about the properties available on CallbackFunction, refer to the API documentation."
Perhaps this link in this guide should be updated to point at the relevant documentation in the Node SDK?


Make SFX for Hestmor Crawling In Flesh

So imagine a steep mountain of flesh:

Basically imagine both her claws and legs digging into the flesh meat as she crawls upwards.
Here's the animation:

@vitormaduro @Hhk187
HestmorFleshCrawl.zip


Marketplace is bad at detecting licenses

Prime examples:

https://marketplace.visualstudio.com/items/donjayamanne.python/license
https://marketplace.visualstudio.com/items/donjayamanne.javadebugger/license

It seems to do with non-SPDX identifiers in the license field of package.json, however when a valid SPDX identifier exists it just dumps the contents of LICENSE on the webpage. Why not just always do that...?

This was fixed in Microsoft/vscode-vsce#66. Extension developers need to update to the latest vsce.

Created DonJayamanne/pythonVSCode#145

Created DonJayamanne/javaVSCode#5


Fix 'addEventListener' used before it was defined

In JavaScript, prior to ES6, variable and function declarations are hoisted to the top of a scope,
so it's possible to use identifiers before their formal declarations in code.
This can be confusing and some believe it is best to always declare variables and functions before using them.
Source: http://eslint.org/docs/rules/no-use-before-define

Seems legit!


Some features are possible under Windows 11 but not shown up when guided trough the options

Thank you very much for your script. One of the most reliable once I found.
"Only show option for disabling context menu items for windows 10 users"
Those options are working also on Windows 11 (23H2) when we choose to revert back to the Windows 10 styled context menu.

Heya,
This was somewhat intended at the time to reduce the amount of options, with the release of Windows 11 a lot more were added to the script. Additionally the context menu options often reappeared with Windows updates.
I can definitely understand there's still a usecase for them though, I have just pushed an update so these options once again show up for W11 users that selected the revert to Windows 10 context menu option. 46df0a7


SpongeVanilla can not overwrite recipes but SpongeForge can.

Using:
Minecraft: 1.12.2
SpongeAPI: 7.1.0-4f54ce0d
Sponge: 1.12.2-7.1.5-SNAPSHOT
SpongeVanilla: 1.12.2-7.1.5-RC135
While using vanilla it seems the Minecraft ID cannot be "overwritten", in this case "minecraft:arrow" which can be done using SpongeForge.
Server crashes logging this: https://hastebin.com/cenumefave.rb
Originally posted by @Mariomm-marti in https://github.com/SpongePowered/SpongeCommon/issues/2159#issuecomment-446487710

Used this issue as a test to try to create issues from comments, to see what would happen. Needed to move cross-repo to SV, so I just did it manually.


[FEATURE REQUEST] Add wiki page on how to setup a complete repository

Is your feature request related to a problem? Please describe.
Currently there is a Hello World wiki page covering the basics. It would be nice to have a guide covering a complete setup e.g. for "teams" working with Git and automated tests.
Describe the solution you'd like
It would be nice to have a wiki page covering the following parts:

[x] Prerequisites
[x] How to setup the Git repository
[x] How to setup the .gitignore file
[x] How to setup the Unity project for that repository
[x] How to setup Entitas-Redux for that Unity project
[x] Simple code example
[x] How to setup the tests

Describe alternatives you've considered
Entitas experts might create more complex examples e.g. how to create a "Pong" with Entitas-Redux.

I would like to work on this. Please ping me if you want me to :)

Hi @matthiashermsen, I apologize for the delayed response; after I move on Dec 18th I will be able to be more responsive and my general engagement for this framework will be picking up.
I am more than happy to make it easier for the community to update the wiki. As a goal for myself I'd like to be able to check in on the changes over time to make sure the information is accurate and conveyed well. For now I have opened up the wiki so that it is editable by the public which should give you the access you desire. If I need to limit this access in the future I will make that known in advance and work with those interested to updating the content to make sure they still retain that ability.
Thanks for your interest in this project and expressing interest in making this easier for developers to use! I'll check in later this month and see if there is any helpful feedback or direction I can give with regards to the content, but your checklist items listed so far seem reasonable.

@jeffcampbellmakesgames np! take your time :)
I will try to create a page in some days and let you know, so you can review it if you want

The new wiki page can be found here
https://github.com/jeffcampbellmakesgames/Entitas-Redux/wiki/How-to-setup-a-new-Github-project-with-Unity-and-tests
@jeffcampbellmakesgames please review it whenever you want :)
Please also have a look at my changes here
https://github.com/jeffcampbellmakesgames/Entitas-Redux/wiki/Installation#install-via-git-url
This wiki page still needs to be added to the page list, I don't know where to put it.

Hey @matthiashermsen, thanks for digging into this further. Now that I'm moved in and have internet again I am catching up on ER work and your updates to the wiki. Will get back to you shortly

Hey @matthiashermsen, thanks for digging into this further. Now that I'm moved in and have internet again I am catching up on ER work and your updates to the wiki. Will get back to you shortly

I also added "back to top" links, I think this is better for fast navigation :)

I also added "back to top" links, I think this is better for fast navigation :)

I'll have some time this weekend for ER, but I wanted to share some general feedback. Overall looks great, but a few specific thoughts arose as I read through the tutorial that I wanted to get your thoughts on:
I think that this tutorial does a better job of covering Hello World than the page I created which covers more of an introduction to ECS and ER concepts. I'd like to at minimum rename the titles to match, but another thought is that it might be worth breaking up this tutorial into two; one for basic Unity project setup and the other which would be focused more specifically on a simple Hello World tutorial after the project is setup.
I would make this section on adding a .gitignore smaller and more generic. This is one of those areas that teams customize a great deal based on their own preferences. It'd be less confusing for a new user overall if we pointed them to the GitHub Unity .gitignore as a general step in setting up their project and not delve into any specifics that might be based on taste or style.
There is a lot of great content here for testing that feels like it's large enough that it would be worth removing into its own section separate from a Getting Started or Project Setup page, perhaps with more of a contextual bent on best practices for unit-testing EntitasRedux. It might be worth also adding unit test setup information for those using the test runner with native Unity support (NUnit) as not everyone might be using Rider or XUnit.

I'll have some time this weekend for ER, but I wanted to share some general feedback. Overall looks great, but a few specific thoughts arose as I read through the tutorial that I wanted to get your thoughts on:
I think that this tutorial does a better job of covering Hello World than the page I created which covers more of an introduction to ECS and ER concepts. I'd like to at minimum rename the titles to match, but another thought is that it might be worth breaking up this tutorial into two; one for basic Unity project setup and the other which would be focused more specifically on a simple Hello World tutorial after the project is setup.
I would make this section on adding a .gitignore smaller and more generic. This is one of those areas that teams customize a great deal based on their own preferences. It'd be less confusing for a new user overall if we pointed them to the GitHub Unity .gitignore as a general step in setting up their project and not delve into any specifics that might be based on taste or style.
There is a lot of great content here for testing that feels like it's large enough that it would be worth removing into its own section separate from a Getting Started or Project Setup page, perhaps with more of a contextual bent on best practices for unit-testing EntitasRedux. It might be worth also adding unit test setup information for those using the test runner with native Unity support (NUnit) as not everyone might be using Rider or XUnit.

I think that this tutorial does a better job of covering Hello World than the page I created which covers more of an introduction to ECS and ER concepts. I'd like to at minimum rename the titles to match, but another thought is that it might be worth breaking up this tutorial into two; one for basic Unity project setup and the other which would be focused more specifically on a simple Hello World tutorial after the project is setup.

Yes, I think we could / should split it into multiple pages :)

I would make this section on adding a .gitignore smaller and more generic. This is one of those areas that teams customize a great deal based on their own preferences. It'd be less confusing for a new user overall if we pointed them to the GitHub Unity .gitignore as a general step in setting up their project and not delve into any specifics that might be based on taste or style.

Yes, that's true. I just discovered some optimizations so I added them to the .gitignore template. (e.g. ignore the Unity project .sln file because there is no need to add it to the version.

There is a lot of great content here for testing that feels like it's large enough that it would be worth removing into its own section separate from a Getting Started or Project Setup page, perhaps with more of a contextual bent on best practices for unit-testing EntitasRedux. It might be worth also adding unit test setup information for those using the test runner with native Unity support (NUnit) as not everyone might be using Rider or XUnit.

True

@jeffcampbellmakesgames Yes, we should split that tutorial. I would suggest the following modifications to the wiki:

[ ] Remove wiki content from the main README file => see #36
[ ] Complete missing page for Entity-Indexes
[ ] Complete missing page for Groups
[ ] Complete missing page for Systems

- [x] How to setup a git repository for Unity (no need for that)

[x] Installation (can be found here )
[ ] Genesis Setup (Below installiation)
[ ] Essential ECS Concepts (Add it to this page )
[ ] Change the Hello World page to a minimum and refer to the other pages for setup
[ ] How to test your project
[ ] Add pages for best practises e.g.

Scene management
Communication between ER and Unity
Abstraction for Unity related code for mocks (tests outside from Engine)
...

I think that this tutorial does a better job of covering Hello World than the page I created which covers more of an introduction to ECS and ER concepts. I'd like to at minimum rename the titles to match, but another thought is that it might be worth breaking up this tutorial into two; one for basic Unity project setup and the other which would be focused more specifically on a simple Hello World tutorial after the project is setup.

Yes, I think we could / should split it into multiple pages :)

I would make this section on adding a .gitignore smaller and more generic. This is one of those areas that teams customize a great deal based on their own preferences. It'd be less confusing for a new user overall if we pointed them to the GitHub Unity .gitignore as a general step in setting up their project and not delve into any specifics that might be based on taste or style.

Yes, that's true. I just discovered some optimizations so I added them to the .gitignore template. (e.g. ignore the Unity project .sln file because there is no need to add it to the version.

There is a lot of great content here for testing that feels like it's large enough that it would be worth removing into its own section separate from a Getting Started or Project Setup page, perhaps with more of a contextual bent on best practices for unit-testing EntitasRedux. It might be worth also adding unit test setup information for those using the test runner with native Unity support (NUnit) as not everyone might be using Rider or XUnit.

True

@jeffcampbellmakesgames Yes, we should split that tutorial. I would suggest the following modifications to the wiki:

[ ] Remove wiki content from the main README file => see #36
[ ] Complete missing page for Entity-Indexes
[ ] Complete missing page for Groups
[ ] Complete missing page for Systems

- [x] How to setup a git repository for Unity (no need for that)

[x] Installation (can be found here )
[ ] Genesis Setup (Below installiation)
[ ] Essential ECS Concepts (Add it to this page )
[ ] Change the Hello World page to a minimum and refer to the other pages for setup
[ ] How to test your project
[ ] Add pages for best practises e.g.

Scene management
Communication between ER and Unity
Abstraction for Unity related code for mocks (tests outside from Engine)
...

@matthiashermsen This all looks good to me for a next pass;  Genesis Setup (Below installiation) is likely to change in the near future since Genesis v2 is going to be coming.

How to test your project using the Unity Test Runner (currently with NUnit) | no need to do it like this anymore https://www.youtube.com/watch?v=DZpvUnj2dGI

Exactly, there is a test runner in Unity now and tests can be run from the Editor as well as many IDEs.

@matthiashermsen This all looks good to me for a next pass;  Genesis Setup (Below installiation) is likely to change in the near future since Genesis v2 is going to be coming.

How to test your project using the Unity Test Runner (currently with NUnit) | no need to do it like this anymore https://www.youtube.com/watch?v=DZpvUnj2dGI

Exactly, there is a test runner in Unity now and tests can be run from the Editor as well as many IDEs.

Closing this in favor of the docs board
https://github.com/jeffcampbellmakesgames/Entitas-Redux/projects/3

Closing this in favor of the docs board
https://github.com/jeffcampbellmakesgames/Entitas-Redux/projects/3


Whois Command

Command that shows advanced info on a user.

Command will need some setup from the you.
I'll link how to set it up in the docs, when v1.0.3 releases.
(3/17/2023) Pending push to main branch!


Move the optimized images

I actually was going to do it myself first, sorry lol

Haha :+1:

So when you need to move a file you need to rename a file to insert directory goal/the file ?
The more you know :)

Oh, and here are the non-optimized original versions of the branding arts since the optimization was reverted. ( for the sake of consistency ) :

This makes the logo larger. Is it really something we want?

Larger as in file size? Well if every other asset is not optimized anymore, then I feel we should do the same thing. They might re-optimize it later on, so I don't think a wallpaper that is compressed two times is a good idea. The current "wallpapers" with the right path have the big logos. The one in the root directory would need to be replaced with the ones that I supplied above. I don't think we want the wallpapers with the logos to be slightly different in quality.

No, the logo at the bottom left. Try the Swipe comparison in files changed.

You mean bottom right? There is nothing at the bottom left corner. Alcaro reverted the optimization, so now it is bigger again. The point of the images I provided above is so that it could get smaller again, also without the optimization that Alcaro removed :)

You're right... It makes the RetroArch logo at the bottom right smaller. Here's a before after...
Before

After

I like the changes! :+1:  The logo looks sharper.

Alright, let's merge it then.


Question about voxelization

Voxelization class voxelizes point input ofxyz to zyx format. Is there any specific reason for this?

It's just a convention. An underlying reason can be we usually take the height channel (z-axis in LiDAR coordinates) as the feature channel. After all bird view projection is most consistent with 3D space in the driving scene (compared to other orthogonal projections from other views).

Thanks for your explanation. However, since mmdet3d support both Lidar and Depth point clouds, this convention exhibits some limitations when performing voxelization for Depth PC dataset like ScanNet.

It's a potential problem for different kinds of coordinates indeed. Currently because voxel-based methods are not suitable for indoor datasets, it will not affect any models up to now. If there is any need for this in the future, I would prefer to converting the depth points to LiDAR points before voxelization.


⚠ Hartman Foundation has degraded performance

In 4dbe847, Hartman Foundation (https://gordonhartman.com/) experienced degraded performance:

HTTP code: 200
Response time: 2592 ms

Resolved: Hartman Foundation performance has improved in 1f72522.

Resolved: Hartman Foundation performance has improved in 1f72522.


hasSelfSelectedPronouns boolean fix

Details

Fixed Issues

$ https://github.com/Expensify/App/issues/6110
Tests / QA

On iOS or android log in.
Click on Profile icon to get settings opions, Click Profile.
Confirm Profile screen loads and its not a blank white screen.

Tested On

[ ] Web
[ ] Mobile Web
[ ] Desktop
[x] iOS
[ ] Android

Screenshots

Web

Mobile Web

Desktop

iOS

Android

🚀 Cherry-picked to staging by @roryabraham in version: 1.1.11-1 🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
success ✅

🕸 web 🕸
success ✅

@Expensify/applauseleads please QA this PR and check it off on the deploy checklist if it passes.

🚀 Deployed to production by @roryabraham in version: 1.1.11-1 🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
success ✅

🕸 web 🕸
success ✅

🚀 Deployed to staging by @roryabraham in version: 1.1.11-2 🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
success ✅

🕸 web 🕸
success ✅

🚀 Deployed to production by @yuwenmemon in version: 1.1.12-3 🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
success ✅

🕸 web 🕸
success ✅


Parsing Json Rico Data

Hello,
This study is interesting and, amazing.
My issue is about parsing a json. How did you get bounding boxes and classes from json data on Rico Dataset ? If you have  the text files which includes the bounding boxes and classes of objects for object detection , can you share the files or can you share your parse code ?
For Example :
You were mentioning that "Chronometer"  is a class which you used. But in the rico dataset , I couldnt find this class label -"Chronometer"  in the components labels of Rico Dataset.  Also , the some bounding  boxes were labeled wrongly .
Thank you !

Same problem as SerdarHelli.


Slightly simplify python loops and attr access

Just some minor readability improvements that accumulated during debugging bugs in my custom model code.

Thanks a lot again for this @lgeiger , I'm merging in now, will do that revert on my end.


Add NoxPlayer version <IP_ADDRESS>

[x] Have you signed the Contributor License Agreement?
[x] Have you checked that there aren't other open pull requests for the same manifest update/change?

[x] Does your manifest conform to the 1.0 schema?

Note: <path> is the name of the directory containing the manifest you're submitting.

Microsoft Reviewers: Open in CodeFlow

Why is it failing?

@vedantmgoyal2009 we're looking into this issue.

@vedantmgoyal2009 we've traced it down to one of the back end systems we call during validation. Once this gets resolved, we hope things will start running smoothly again. No ETA yet.

/azp run

Any progress on this?

@vedantmgoyal2009 we're still investigating this issue. We haven't isolated the root cause yet. It is related to one of our underlying dependencies for static analysis.

/azp run

/azp run

/azp run


unable to activate devtools

Is there an existing issue for this?

[X] I have searched the existing issues
[X] I have read the guide to filing a bug

Steps to reproduce
dipak@dipaks-MacBook-Pro ~ % flutter pub global activate devtools
The current Dart SDK version is 3.0.0-290.3.beta.

Because pub global activate depends on devtools any which doesn't support null
  safety, version solving failed.

The lower bound of "sdk: '>=2.1.0-dev <3.0.0'" must be 2.12.0 or higher to enable null safety.
For details, see https://dart.dev/null-safety

Actual results
should install dev tools
Flutter Doctor output

flutter doctor -v
[✓] Flutter (Channel beta, 3.9.0-0.2.pre, on macOS 13.3 22E252 darwin-x64, locale en-IN)
    • Flutter version 3.9.0-0.2.pre on channel beta at /Users/dipak/development/flutter-beta
    • Upstream repository https://github.com/flutter/flutter.git
    • Framework revision 0df8557c56 (5 days ago), 2023-03-23 22:02:01 -0500
    • Engine revision 1cc4b2d280
    • Dart version 3.0.0 (build 3.0.0-290.3.beta)
    • DevTools version 2.22.2

[✓] Android toolchain - develop for Android devices (Android SDK version 33.0.2)
    • Android SDK at /Users/dipak/Library/Android/sdk
    • Platform android-33, build-tools 33.0.2
    • ANDROID_HOME = /Users/dipak/Library/Android/sdk
    • ANDROID_SDK_ROOT = /Users/dipak/Library/Android/sdk
    • Java binary at: /Applications/Android Studio.app/Contents/jre/Contents/Home/bin/java
    • Java version OpenJDK Runtime Environment (build 11.0.13+0-b1751.21-8125866)
    • All Android licenses accepted.

[✓] Xcode - develop for iOS and macOS (Xcode 14.2)
    • Xcode at /Applications/Xcode.app/Contents/Developer
    • Build 14C18
    • CocoaPods version 1.12.0

[✓] Chrome - develop for the web
    • Chrome at /Applications/Google Chrome.app/Contents/MacOS/Google Chrome

[✓] Android Studio (version 2021.3)
    • Android Studio at /Applications/Android Studio.app/Contents
    • Flutter plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/9212-flutter
    • Dart plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/6351-dart
    • Java version OpenJDK Runtime Environment (build 11.0.13+0-b1751.21-8125866)

[✓] IntelliJ IDEA Community Edition (version 2022.3.3)
    • IntelliJ at /Applications/IntelliJ IDEA CE.app
    • Flutter plugin version 72.1.4
    • Dart plugin version 223.8888

[✓] VS Code (version 1.76.2)
    • VS Code at /Applications/Visual Studio Code.app/Contents
    • Flutter extension version 3.60.0

[✓] Connected device (3 available)
    • iPhone 14 Pro Max (mobile) • 3D1BFBC6-6609-40F0-B8F0-BB10A8425A88 • ios            •
      com.apple.CoreSimulator.SimRuntime.iOS-16-2 (simulator)
    • macOS (desktop)            • macos                                • darwin-x64     • macOS
      13.3 22E252 darwin-x64
    • Chrome (web)               • chrome                               • web-javascript • Google
      Chrome 111.0.5563.110

[✓] Network resources
    • All expected network resources are available.

Hi @dipakp2726, I think you may need to file this on the devtools repo so they can investigate. You will get the same issue if you run the command using dart pub global activate devtools instead of flutter pub global activate devtools so I don't think this is an issue with the flutter tool.
Closing as I believe this should not be filed here. If you are redirected here, kindly leave a comment below and I will reopen this issue.
PS: this issue is only the beta and master channels. You can activate it on the stable channel just fine.
Thank you

on stable channel request/response inside network tab always shows blank.

dipak@192 ~ % dart pub global activate devtools
Package devtools is currently active at version 2.9.4.
The current Dart SDK version is 3.0.0-290.3.beta.
Because pub global activate depends on devtools any which doesn't support null
safety, version solving failed.
The lower bound of "sdk: '>=2.1.0-dev <3.0.0'" must be 2.12.0 or higher to enable null safety.
For details, see https://dart.dev/null-safety
its still same even if i use
dart pub global activate devtools

Hi @dipakp2726, I meant you should file an issue on the devtools repo so that they could investigate.


HTML Attribute Tab Complete Doesn't Include Equals And Quotes

Is your feature request related to a problem? Please describe.
When using tab completion for HTML attributes, it doesn't include the equals symbol and quotes. After pressing tab, it looks like this:

Describe the solution you'd like
I want the equals symbol and the quotes included when using tab completion. The quotes should use the value in VSC's html.completion.attributeDefaultValue.
After pressing tab it should look like this:

Checklist

[x] I have checked and made sure that the proposal adheres to this plugin's principles

Additional context
This Liquid extension does it.

Closing in favour of 345 which has a little more context and breadcrumbs. Still planning on doing it when someone has the capacity.


fix: change download csv parameter

Description
Resolve: https://github.com/Magickbase/ckb-explorer-public-issues/issues/385

Seems that this PR is covered by https://github.com/Magickbase/ckb-explorer-frontend/pull/21

Seems that this PR is covered by #21

Can we close this PR because it seems to be covered by #21 @zhangyouxin

Seems that this PR is covered by #21

Can we close this PR because it seems to be covered by #21 @zhangyouxin

Repost


Review type validator control flow

Here I switched to this suggested implementation:
https://webassembly.github.io/spec/core/appendix/algorithm.html
There is still something breaking that I don't fully understand, removing block.wast from excludedInvalidWasts shows a couple of points where this breaks.
@electrum since you have been working on the control flow recently, I would love review/fixes/suggestions by you :pray:

Thanks to @evacchi pairing, we found the last missing detail and now it finally clicked.
Ready for review!


Add first SIGINT test to an agent (not the NameSever agent)

Added first test related to SIGINTs. As for the first commit, only an agent which is not the NameServer is tested.
In relation to #20

Tests are not passing beacuse the teardown is not being done correctly in test_sigint_no_handling.
However, I think this is how it should behave as of now. Perhaps we could close #20 and open a new issue with the suggestion of 2-step interruption, while leaving this PR open?

I have been working on implementing #60 , but it is not done yet. Even though I got all the tests to pass once through tox -e py35 on commit ff7ed4b , there is something I'm still missing.
I think it is related to the different ways there are for terminating an agent. I also wonder if there is a better way for handling the signals than counting them.

Despite passing all tests with the four Python versions tested by Travis CI in this repository, in my fork the CI build failed, more precisely, the Python 3.3 version. Relevant parts are pasted below.
It seems the test_sigint_agent_shutdown is the most problematic. Without the time.sleeps, every try has failed.
...
=================================== FAILURES ===================================
__________________________ test_sigint_agent_shutdown __________________________
[gw4] linux -- Python 3.3.5 /home/travis/build/Flood1993/osbrain/.tox/py33/bin/python3.3
nsaddr = <IP_ADDRESS>:18932
    def test_sigint_agent_shutdown(nsaddr):
        """
        Test SIGINT (simulation) signal on a non NameServer agent.

        A single signal is sent: we want the agent to shut down gracefully.
        Two seconds are given to give enough time to free the resources.
        """
        class NewAgent(Agent):
            def simulate_SIGINT(self):
                os.kill(os.getpid(), signal.SIGINT)

        ns = NSProxy(nsaddr)

        # Test SIGINT on an Agent based on the new class
        AgentProcess('new', nsaddr=nsaddr, base=NewAgent).start()
        new = Proxy('new', nsaddr)
        new.run()
        assert 'new' in ns.list()
        assert new.ping() == 'pong'
        new.simulate_SIGINT()
        time.sleep(2)
        with pytest.raises(Exception):
            assert new.ping() == 'pong'
>       assert 'new' not in ns.list()
E       assert 'new' not in {'Pyro.NameServer': 'PYRO:Pyro.NameServer@<IP_ADDRESS>:18932', 'new': 'PYRO:obj_59072630f42e4d8e8acb6bbf7143164f@localhost:36653'}
E        +  where {'Pyro.NameServer': 'PYRO:Pyro.NameServer@<IP_ADDRESS>:18932', 'new': 'PYRO:obj_59072630f42e4d8e8acb6bbf7143164f@localhost:36653'} = <Pyro4.core._RemoteMethod object at 0x7f643fc03710>()
E        +    where <Pyro4.core._RemoteMethod object at 0x7f643fc03710> = <osbrain.proxy.NSProxy at 0x7f643fc0ea50; connected; for PYRONAME:Pyro.NameServer@<IP_ADDRESS>:18932>.list
osbrain/tests/test_agent.py:101: AssertionError
==================== 1 failed, 236 passed in 33.32 seconds =====================
ERROR: InvocationError: '/home/travis/build/Flood1993/osbrain/.tox/py33/bin/pytest --basetemp=/home/travis/build/Flood1993/osbrain/.tox/py33/tmp --cache-clear -n 8 -sv --pep8 --flakes --mccabe --cov --boxed'
___________________________________ summary ____________________________________
ERROR:   py33: commands failed
The command "tox" exited with 1.
fter_script.1
3.51s$ pip install codecov coveralls
Collecting codecov
  Downloading codecov-2.0.5-py2.py3-none-any.whl
Collecting coveralls
  Downloading coveralls-1.1-py2.py3-none-any.whl
Collecting requests>=2.0.0 (from codecov)
  Using cached requests-2.13.0-py2.py3-none-any.whl
Collecting coverage (from codecov)
  Downloading coverage-4.3.4.tar.gz (361kB)
    100% |################################| 364kB 1.6MB/s
Collecting argparse (from codecov)
  Downloading argparse-1.4.0-py2.py3-none-any.whl
Collecting docopt>=0.6.1 (from coveralls)
  Downloading docopt-0.6.2.tar.gz
Installing collected packages: docopt, argparse, coverage, requests, coveralls, codecov
  Running setup.py install for docopt
  Running setup.py install for coverage
    building 'coverage.tracer' extension
    gcc -pthread -Wno-unused-result -DNDEBUG -g -fwrapv -O3 -Wall -Wstrict-prototypes -g -fstack-protector --param=ssp-buffer-size=4 -Wformat -Werror=format-security -fPIC -I/opt/python/3.3.5/include/python3.3m -c coverage/ctracer/datastack.c -o build/temp.linux-x86_64-3.3/coverage/ctracer/datastack.o
    gcc -pthread -Wno-unused-result -DNDEBUG -g -fwrapv -O3 -Wall -Wstrict-prototypes -g -fstack-protector --param=ssp-buffer-size=4 -Wformat -Werror=format-security -fPIC -I/opt/python/3.3.5/include/python3.3m -c coverage/ctracer/filedisp.c -o build/temp.linux-x86_64-3.3/coverage/ctracer/filedisp.o
    gcc -pthread -Wno-unused-result -DNDEBUG -g -fwrapv -O3 -Wall -Wstrict-prototypes -g -fstack-protector --param=ssp-buffer-size=4 -Wformat -Werror=format-security -fPIC -I/opt/python/3.3.5/include/python3.3m -c coverage/ctracer/module.c -o build/temp.linux-x86_64-3.3/coverage/ctracer/module.o
    gcc -pthread -Wno-unused-result -DNDEBUG -g -fwrapv -O3 -Wall -Wstrict-prototypes -g -fstack-protector --param=ssp-buffer-size=4 -Wformat -Werror=format-security -fPIC -I/opt/python/3.3.5/include/python3.3m -c coverage/ctracer/tracer.c -o build/temp.linux-x86_64-3.3/coverage/ctracer/tracer.o
    gcc -pthread -shared -L/opt/python/3.3.5/lib -Wl,-rpath=/opt/python/3.3.5/lib build/temp.linux-x86_64-3.3/coverage/ctracer/datastack.o build/temp.linux-x86_64-3.3/coverage/ctracer/filedisp.o build/temp.linux-x86_64-3.3/coverage/ctracer/module.o build/temp.linux-x86_64-3.3/coverage/ctracer/tracer.o -L/opt/python/3.3.5/lib -lpython3.3m -o build/lib.linux-x86_64-3.3/coverage/tracer.cpython-33m.so
    Installing coverage script to /home/travis/virtualenv/python3.3.5/bin
    Installing coverage-3.3 script to /home/travis/virtualenv/python3.3.5/bin
    Installing coverage3 script to /home/travis/virtualenv/python3.3.5/bin
Successfully installed argparse-1.4.0 codecov-2.0.5 coverage-4.3.4 coveralls-1.1 docopt-0.6.2 requests-2.13.0
after_script.2
1.43s$ codecov
      _____          _
     / ____|        | |
    | |     ___   __| | ___  ___ _____   __
    | |    / _ \ / _  |/ _ \/ __/ _ \ \ / /
    | |___| (_) | (_| |  __/ (_| (_) \ V /
     \_____\___/ \____|\___|\___\___/ \_/
                                    v2.0.5
==> Detecting CI provider
    Travis Detected
==> Preparing upload
==> Processing gcov (disable by -X gcov)
    Executing gcov (find /home/travis/build/Flood1993/osbrain -type f -name '*.gcno'  -exec gcov -pb  {} +)
==> Collecting reports
    Generating coverage xml reports for Python
    + /home/travis/build/Flood1993/osbrain/coverage.xml bytes=38602
==> Appending environment variables
    + TRAVIS_OS_NAME
    + TRAVIS_PYTHON_NAME
==> Uploading
    .url https://codecov.io
    .query job=208524068&pr=false&branch=sigint_tests&package=py2.0.5&slug=Flood1993%2Fosbrain&service=travis&commit=a8ba637239f66f6ebebf4fcf192dd1cd196ab5a9&build=8.4
    Pinging Codecov...
    Uploading to S3...
    https://codecov.io/github/Flood1993/osbrain/commit/a8ba637239f66f6ebebf4fcf192dd1cd196ab5a9
after_script.3
0.61s$ coveralls
Submitting coverage to coveralls.io...
Coverage submitted!
Couldn't find a repository matching this job.
'url'
Done. Your build exited with 1.```

@Flood1993 save your current pip freeze. Then try to pip install --upgrade -r requirements.txt. If it works after that, then either forget about it or (better) "debug" until you get which package version upgrade made things work again.

As of 8032599 , the only SIGINT we are handling with the _sigint_handler is the first one, and the others are handled by the default Python handler (treated as KeyboardInterrupt).
I also have added some tests for checking that processes are really getting killed when they should. However, the tests are failing for detecting alive threads. Right now we are reading the /proc directory to find the PID's of the processes on the system, and checking against each PID of our agents/nameserver. However, apart from not currently working, this only works on Linux based systems.

Integrated into #249


[Webpack][ISSUE#818][BotBuilder-AI][BF-Connector] Fix webpack dependency warning

Fixes #818
Description
This pull request fixes the critical dependency warning reported in BotBuilder-AI and BotFramework-Connector.
We followed the same approach used in BotFramework-Emulator that uses an external file to set Fetch as part of the Global object here.
BotBuilder-AI warning solution
we updated the way that the Fetch API is required in the httpRequestUtils  class to use an external file.
Testing
First, we added tests for the logic added to the library.

Second, we modified a browser-bot to test the package fixed. Then, we tested it using Edge, Chrome and Firefox browsers.

Finally, we tested the case that fetch is not part of the Global object. To do that, we modified a console-echo-bot to use the package fixed. We decided to use this bot since it is the one that doesn’t use the BotBuilder package. This package has a sub-dependency that adds the fetch function to the Global object in this line before running the QnA code.
The next image shows the qna-console-bot running as we expected.

BotFramework-Connector warning solution
we updated the way that the Form-Data and Fetch APIs are set as part of the global object in the index file of the library.
Testing
First, we added tests for the logic added to the library.

Second, we tested the package fixed using a browser-bot. The next image shows the result of the Webpack build process before and after updating the BF-Connector package. In this case, the APIs are already part of the Window object in the browsers.

Finally, we configure an echo-bot to use the package with the new code and it works as we expected.

Testing
The next image shows the result of the build process running on the branch with the fixes for the Webpack dependency warnings on BotBuilder-AI and BF-Connector.

Pull Request Test Coverage Report for Build 98361

15 of 16 (93.75%)  changed or added relevant lines in 4 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage decreased (-0.02%) to 84.392%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

libraries/botframework-connector/src/globals.ts
5
6
83.33%

Totals

Change from base Build 97224:
-0.02%

Covered Lines:
8442

Relevant Lines:
9678

💛  - Coveralls

@Bill7zz please address @stevengum  comment and re-submit.

Hi @cleemullins, we already submitted these changes that @stevengum asked for. What's left only is the re-review of the changes


ci: Greenkeeper/ts node 7.0.0

:tada: This PR is included in version 2.0.0 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


feat: add product statuses to result component

@zlatanpham I've also added the translation for all languages (only english is correct, others need to be updated)


[PubGrub] Add support for handling tools version in the resolver

This adds support for handling tools version in the resolver as an
incompatibility instead of it being implicit when computing which
version are available. This is a big improvement over the current legacy
resolver where we emit no diagnostics if the resolution fails because of
the tools version.
rdar://problem/53947020

@swift-ci smoke test

@swift-ci smoke test linux


fix: fix eq check for actor kv

Changes

[!WARNING]
This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more

#1752  👈 (View in Graphite)
#1750
#1745
#1719
#1718
#1717
#1716
#1715
#1714
#1712
#1711
#1710
#1709
#1708
#1707
#1706
#1695
main

How to use the Graphite Merge Queue
Add the label merge-queue to this PR to add it to the merge queue.
You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has required the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.


Massive workflow refactor: split into reusable parts

3 separate workflows have been introduced - reuse-copr-build,
reust-tests-7to8 and reuse-tests-8to9.
This should make adding new tests a bit easier.

/rerun

Proof of work:
/rerun - https://github.com/fernflower/leapp/actions/runs/2447483469
/rurun-all - https://github.com/fernflower/leapp/actions/runs/2447653500

@fernflower review in progress. pls update the pr-welcome-msg.yml as well

Okay, final run:
/rerun - https://github.com/fernflower/leapp/actions/runs/2454018337
/rerun-all 901 - https://github.com/fernflower/leapp/actions/runs/2454019736

Okay, this https://github.com/oamg/leapp/pull/776/commits/7cf2eeea4c0c3f30a7e8e92e196574e8a368f51d should fix it.
Removing WIP label, scheduling all runs now.
/rerun-all 901 - https://github.com/fernflower/leapp/actions/runs/2454223657
/rerun 900 - https://github.com/fernflower/leapp/actions/runs/2454225147
/rerun - https://github.com/fernflower/leapp/actions/runs/2454225713
/rerun-all - https://github.com/fernflower/leapp/actions/runs/2454227848

Okay, another try with https://github.com/oamg/leapp/pull/776/commits/b67c84b037fd2ee48951e0739f4dd8a493ac5140 =)
/rerun-all 901 - https://github.com/fernflower/leapp/actions/runs/2454290013
/rerun 900 - https://github.com/fernflower/leapp/actions/runs/2454291311
/rerun-all - https://github.com/fernflower/leapp/actions/runs/2454291735
/rerun - https://github.com/fernflower/leapp/actions/runs/2454292124


Infinite Lava Fluid Tank

Issue description:
If you use a Minecraft bucket filled with lava on a fluid tank, in my case an Advanced Fluid Tank, you can glitch it to give you infinite lava.
Expected Results:
Lava bucket should empty and fill tank with 1,000mB of Lava.
Steps to reproduce:

Take a Bucket filled with Lava
Place a Fluid Tank
Put the bucket in the "Input" slot of the fluid tank
The fluid tank fills up without emptying the bucket
Fluid tank becomes full
Filled lava bucket is then placed in "Output"

Version:
Minecraft: 1.10.2
Forge: <IP_ADDRESS>1
Mekanism 1.10.2 9.2.2 FINAL
ATLauncher <IP_ADDRESS>
Resonant Rise: <IP_ADDRESS>-b

Please update to the latest version of Mekanism, is fixed in 9.2.2FINAL-fix3


Implement KEM en-/decoders

In #123, PKCS#8 encoders for Dilithium, Falcon and Sphincs+ were added.
However, the initial message also links draft for Kyber. Why was it not included in the PR (I can't see any mention of Kyber in Files changed)?
In https://github.com/open-quantum-safe/oqs-provider/issues/84#issuecomment-1296125057, @baentsch mentions that KEM algorithms do not need to have encoder/decoder functions. What if I want to use openssl to generate Kyber1024 keypair? I didn't find a way to do it, even in raw form.

The answer to the question is "Yes": Indeed there are no en-/decoders for Kyber (or any other PQ-KEM). The rationale was that we (thought we)'d need to persist key material only for PQ-signature algorithms (for X.509 etc)... Which openssl commands would/should benefit from persisting PQ-KEM key material (beyond key gen)?

Btw is there a way to do Kyber keygen, where openssl at least outputs keys in their raw form? Similar to what libOQS actually returns when keygen function executes? I know I can use any programming language and run libOQS from there, but I guess it would be nice to have in openssl as it is system-wide command-line application.

@Muzosh Considering the above, do you still see a need for exporting KEM keys? Which standard(s) would you like to see this following then? If so, would you want to re-name this issue to "Implement KEM en-/decoders" (listing the standards this should implement)?

Sorry, I didn't find the time to get back to it. I will think about it.

@baentsch you mentioned CMS with KEM as an example. I'm actually working on a PQ version of something very similar: CDOC. In the reference implementation of CDOC2 (new version that I'm trying to make quantum-safe), they are currently using ECDH and RSA for creating Content Encryption Key for recipients. Therefore KEM encoders might come in handy to serialize Kyber and other PQ-KEM public keys in different key distribution systems.
I have other ways on how to generate and store Kyber keys myself for now, so there is no rush.

Thanks for letting us know.

KEM encoders might come in handy to serialize Kyber and other PQ-KEM public keys

Agreed.

I have other ways on how to generate and store Kyber keys myself for now, so there is no rush.

Meaning that I can wait for more use cases from others, so it becomes more relevant and worth.

@baentsch, my colleagues and I are working on implementing the KEM features of RFC4210bis in OpenSSL. We've made good progress and successfully tested everything with RSA-KEM, and we'd like to do it with post-quantum algorithms too. Our bottleneck is the lack of KEM encoders and decoders in the provider.
We'd like to test it with Kyber (because we already have an implementation in Java), but eventually we'll want to test it with all post-quantum KEMs.
If you are looking for a good use case - I think this is it. The work done so far is in this branch of OpenSSL, we'll merge it into the upstream project as soon as everyone is happy with it (CC @rajeev-0).

@ralienpp This indeed sounds like a good use case. Two immediate questions:

Can you provide a list of openssl commands you'd want to use/possibly already test this (RSA-KEM) with?
Is there a list of OIDs for (PQ)KEMs we could use (if I get you right you already have Kyber implemented in Java, so probably already use some... Can you point to the code or another location please)?

To the best of my knowledge, no OIDs are defined yet. In our experiments we use a dummy value of 1,2,3,4,1945,1111,9999 for Kyber512, with the intention to replace it as soon as the world moves on.
The logic can be triggered via openssl's cmp command. Here's a recipe you can follow to invoke the KEM-related logic from the aforementioned openssl branch. The test environment requires a CMP server and a CMP client, both can be simulated with OpenSSL. A scenario can look like this:
$cd openssl/test/recipes/80-test_cmp_http_data/Mock
# Run the server with a KEM key in one terminal
$openssl cmp -config server_withkem.cnf -verbosity 8 -port 1700

# in another terminal, run the client
$openssl cmp -server <IP_ADDRESS>:1700 -config test_withserverkem.cnf -section "Mock commands" -no_proxy <IP_ADDRESS> -cmd ir -cert signer.crt -key signer.key -srvcert kem.crt -certout out.test.pem

The configuration files, certificates and keys used by the mock are a part of the repository, so the example should work out of the box.
To tinker with a post-quantum KEM, you'll need a KEM certificate. At the moment I have no elegant of producing one (normally I'd do it with OpenSSL :-). I'm attaching a sample I concocted manually, by taking a classic cert, replacing the subject public key with the raw bytes of Kyber512 as returned by liboqs/python and wrapped in a BitString, changing the algorithm OID; then signing it it with an RSA key and updating the signature.
kem-cert-experiment.zip

Is there a list of OIDs for (PQ)KEMs we could use (if I get you right you already have Kyber implemented in Java, so probably already use some... Can you point to the code or another location please)?

I have found that BouncyCastle expanded on OQS's OIDs in their BCObjectIdentifiers.java.
Process for finding this was really hard and frustrating, because documentation of PQ capabilities in BC is almost non-existent. But following their variables in this class, you can construct an KEM OID that they use for various PQ KEM algorithms.

To tinker with a post-quantum KEM, you'll need a KEM certificate. At the moment I have no elegant of producing one (normally I'd do it with OpenSSL :-)

Could you please provide openssl commands you'd use to do this? The only suitable command(s) I can think of are genpkey and req -new. The former works fine for the private key (also storing it with a suitably added encoder works OK), but the latter (intended to create and store the public key) doesn't quite work -- arguably because it (correctly) cannot use the (KEM!) algorithm to sign (the CSR).
So, beyond the CMP example above (beginning only when key & cert exists), can you please provide openssl commands you can use right now to create a classic crypto KEM certificate (without --internally-- triggering the use of a signature function for that algorithm)? Those would be the first commands I'd like to check correct function of the new KEM en/decoders with. If such openssl commands don't (yet) exist, I guess this use-case/issue will need to move "upstream".

You could create the certificate without generating the CSR by using openssl x509 with -force_pubkey. e.g.
openssl x509 -new -subj "/CN=KEM_CERT" -CA <root.crt> -CAkey <root.key>  -out <kem.crt> -force_pubkey <kem_pub.pem>  -extensions SAN -extfile <(printf "[SAN]\nbasicConstraints=critical,CA:false\nkeyUsage=critical,keyEncipherment")

You could create the certificate without generating the CSR by using openssl x509 with -force_pubkey. e.g.
openssl x509 -new -subj "/CN=KEM_CERT" -CA <root.crt> -CAkey <root.key> -out <kem.crt> -force_pubkey <kem_pub.pem> -extensions SAN -extfile <(printf "[SAN]\nbasicConstraints=critical,CA:false\nkeyUsage=critical,keyEncipherment")

Well, this command uses a public key in a file (the "-force_pubkey" argument), but how is (a representation of) the public key stored in such file in the first place? According to https://github.com/openssl/openssl/discussions/22121#discussioncomment-7041853 no such command exists.
In other words, this issue cannot be resolved before https://github.com/openssl/openssl/issues/22132 is resolved.


Support loading custom metadata blocks

We need to support people having their own custom metadata blocks. See upstream docs on this.

We need to provide a maintenance job to load TSV based metadata blocks

Also needed for changes happening upstream, like for v4.16 (citation block changed, see point 5 of upgrade instruction)

We need a job exporting the (so called) "dynamic) schema, adding it to the Solr instance and reload. (see also upstream docs)

I would love to use dataverse-kubernetes to spin up Dataverse with the custom metadata block included in https://github.com/IQSS/dataverse/issues/6289 by @doigl

This was implemented today in https://github.com/IQSS/dataverse-ansible/pull/135 for dataverse-ansible and I put some screenshots from my testing in a comment at https://github.com/IQSS/dataverse-ansible/issues/133#issuecomment-555227955
@poikilotherm thanks for updateSchemaMDB.sh!

Great! We're going to test it as well!

@4tikhonov perfect! Thanks!
@donsizemore I just gave you and @poikilotherm a shout out in this thread called "custom metadata blocks now easier to spin up and evaluate" - https://groups.google.com/d/msg/dataverse-community/uKretKox_io/4FyPVAMYBgAJ
Thanks again! 🎉 🎉 🎉


Sage 9.5

Will this be updated to provide Sage 9.5 ?

https://github.com/conda-forge/sagelib-feedstock/pull/130


Subtitle changing not working

Idk if is a Clappr issue
Browser:
Chrome, Opera, Tizen
OS:
Windows 10, Tizen
Clappr Version: 0.2.71
Steps to reproduce:

first step
Init clappr with following settings and HLS source

{
	"parentId": "clappr-container",
	"width": "100%",
	"shakaConfiguration": {
		"preferredAudioLanguage": "pt-BR",
		"streaming": {
			"rebufferingGoal": 15
		}
	},
        "plugins": [LevelSelector, AudioTrackSelector, DashShakaPlayback, Smooth],
	"source": "http://***/76/source/hls/video/sd/video.m3u8",
	"externalTracks": [{
		"language": "pt-BR",
		"languageName": "Português",
		"src": "resources/subtitles/pt-BR.vtt",
		"id": 0,
		"lang": "pt-BR",
		"label": "Português",
		"kind": "subtitles"
	}, {
		"language": "en-US",
		"languageName": "Inglês",
		"src": "resources/subtitles/en-US.vtt",
		"id": 1,
		"lang": "en-US",
		"label": "Inglês",
		"kind": "subtitles"
	}]
}

Added buttons to change subtitle
function setSubtitle(subtitle) {
	var video, textTracks;
	video = document.querySelector('video');
	textTracks = video.textTracks;

	for (var i = 0; i < textTracks.length; i++) {
		if (video.textTracks[i].language == subtitle.language) {
			video.textTracks[i].mode = 'showing';
		} else if (video.textTracks[i].language && video.textTracks[i].kind == 'subtitles') {
			video.textTracks[i].mode == 'hidden';
			//video.textTracks[i].mode == 'disabled';
		}
	}
};

Code is working good, I debugged many times, also tried with setTimeout. If I manually set textTrack.mode to hidden on console works.
I was expecting subititle to be hidden after I set mode == 'hidden' but both subtitles are showing.

@matheusrufca latest version of Clappr should handle subtitles and automatically display a button in mediacontrols when subtitles are available.
Take a look at playback config documentation.

Hi @kslimani , thanks for your message.
I changed Clappr version to 0.2.73 and nested externalTracks config inside playback options but didnt solve nor show subtitles button.
Am I missing something?

Oh, i see, i think this is because external track support has been added only for html5_video playback (ie: .mp4 source). It seems it is not implemented (yet) for HLS source.

Hmm, thanks. what is weird is subtitles are working and when I set to hide via console works too.
But would be nice a native player handler for changing subtitles on streaming.
I'm running out of time now, but I can contribute in near future on this feature.

There is an internal plugin in Clappr to handle subtitles (feature added here) - but currently, hlsjs playback supports only subtitles which are embeded in manifest. (external track support has not been aded yet for hls, only for mp4 source)
For example, test with source in clappr Demo page.


feat: Profiling the exec's memory and elapsed time

cd examples/hello-world
cargo run --features "prove"
The log will be like:
Memory used before exec: Ok(37126144)
Memory used after exec: Ok(53264384)
exec elapse = 105 ms
Memory usage after proving: Ok(475447296)
proving peak mem = 472385488, prove elapse = 37568 ms
I know the factors of 391, and I can prove it!
It means that, in exec, only ~20MB is used (However, the peak memory is not clear yet). The time is only 105 ms, much less than total proving time 37 sec.

Just for self-test. Closed this PR.


Module not found: Can't resolve 'next/dist/server/web/spec-extension/response'

Hi Supabase community. Awesome toolkit you have build here!
I found a bug when upgrading from v1.2.3 to v.1.3.0.
It seems to be related to the new "withMiddleWareAuthRequired" helper:
error - ./node_modules/@supabase/supabase-auth-helpers/nextjs/utils/withMiddlewareAuthRequired.js:6:0 Module not found: Can't resolve 'next/dist/server/web/spec-extension/response'
The problem might be that we are using next 11 and you guys are using next 12.
Project Info:

Expo sdk 44
Next js 11.0.1
Supabase js 1.30.7

Same issue here, with NextJs 11.1.0-0.45.3

+1

I am using<EMAIL_ADDRESS>and<EMAIL_ADDRESS>and facing the same issue, but with ts-node only.
Downgrading to<EMAIL_ADDRESS>works. It seems that ts-node follows this import and errors out:
https://github.com/supabase-community/supabase-auth-helpers/blob/7a275700b0db392c43b3e381ec801cc779a4dd54/src/nextjs/utils/withMiddlewareAuthRequired.ts#L2
The error being:
ReferenceError: Response is not defined
    at Object.<anonymous> (./node_modules/next/server/web/spec-extension/response.ts:10:35)

It's a NextJS app but I was using ts-node for transpiling the GraphQL API endpoint using nexusjs for GraphQL server type generation, as shown in the guide:
https://nexusjs.org/docs/getting-started/tutorial/chapter-setup-and-first-query.
The package.json script called:
ts-node --transpile-only -P nexus.tsconfig.json pages/api/graphql

And the file pages/api/graphql imports and uses withAuthRequired, not even withMiddlewareAuthRequired.

This version of the library is no longer maintained. Migrate to @supabase/auth-helpers-nextjs.


pinger_test is flaky

Which jobs are flaking: unit tests
Which test(s) are flaking: pinger_test
Testgrid link: https://github.com/submariner-io/submariner/runs/4562958089?check_suite_focus=true
Reason for failure:
Pinger when the pinger is stopped
  should no longer update the statistics
  /go/src/github.com/submariner-io/submariner/pkg/cableengine/healthchecker/pinger_test.go:151
I1217 16:43:42.823708    5966 pinger.go:104] Starting pinger for IP "<IP_ADDRESS>"

• Failure [0.207 seconds]
Pinger
/go/src/github.com/submariner-io/submariner/pkg/cableengine/healthchecker/pinger_test.go:39
  when the pinger is stopped
  /go/src/github.com/submariner-io/submariner/pkg/cableengine/healthchecker/pinger_test.go:146
    should no longer update the statistics [It]
    /go/src/github.com/submariner-io/submariner/pkg/cableengine/healthchecker/pinger_test.go:151

    Timed out after 0.202s.
    Expected
        <*healthchecker.LatencyInfo | 0xc000196b40>: {
            ConnectionError: "",
            ConnectionStatus: "",
            Spec: {Last: "0s", Min: "0s", Average: "0s", Max: "0s", StdDev: "0s"},
        }
    not to equal
        <*healthchecker.LatencyInfo | 0xc0004e6930>: {
            ConnectionError: "",
            ConnectionStatus: "",
            Spec: {Last: "0s", Min: "0s", Average: "0s", Max: "0s", StdDev: "0s"},
        }

    /go/src/github.com/submariner-io/submariner/pkg/cableengine/healthchecker/pinger_test.go:110

    Full Stack Trace
    github.com/submariner-io/submariner/pkg/cableengine/healthchecker_test.glob..func2.5(0x3)
    	/go/src/github.com/submariner-io/submariner/pkg/cableengine/healthchecker/pinger_test.go:110 +0xfb
    github.com/submariner-io/submariner/pkg/cableengine/healthchecker_test.glob..func2.9.2()
    	/go/src/github.com/submariner-io/submariner/pkg/cableengine/healthchecker/pinger_test.go:152 +0x70
    github.com/submariner-io/submariner/pkg/cableengine/healthchecker_test.TestHealthChecker(0xc0002e5e00)
    	/go/src/github.com/submariner-io/submariner/pkg/cableengine/healthchecker/healthchecker_suite_test.go:35 +0xa5
    testing.tRunner(0xc0002e5e00, 0x1fbcac0)
    	/usr/lib/golang/src/testing/testing.go:1193 +0x203
    created by testing.(*T).Run
    	/usr/lib/golang/src/testing/testing.go:1238 +0x5d8

Anything else we need to know: this has been seen on a number of PRs.

I ran this locally with -untilFails many hundreds of times w/o failure. What's strange is that it fails in the initial verifyPingStats before it even stops it but the "the IP is reachable" test that also calls verifyPingStats doesn't fail.  The only difference is that the pingInterval is shorter (100 ms) than the other test (300 ms) so perhaps the actual ping itself sometimes takes a bit longer. I'll take a look at that.

In all the failures I’ve seen, the output was all 0s; does that mean that the ping was too fast to be measured, or that none had been measured at all? It might be worth logging the number of received pings.

In all the failures I’ve seen, the output was all 0s; does that mean that the ping was too fast to be measured, or that none had been measured at all? It might be worth logging the number of received pings.

I was thinking the first ping hadn't happened yet but perhaps 100ms interval is sometimes too small to produce a measurable difference. Either way, with this test case, we just want to make sure the pinger has started so we can verify that it stopped so we just need to ensure one ping occurred and not measure a difference - I'll change the test accordingly.


Minor changes

Hi,

Added simulation for delete
Added requirements
Updated changelog message

And thanks for your work

Hey, thanks! This is my first Python project, and I don't really used it more, really happy to see that it still helps people out :)
Thanks for the modifications too.
Also, if you want to maintain the project, just let me know!

I'll merge it tomorrow and bump the version too.


Fix clang 15 -pedantic warnings

emu2413.c:402:29: warning: a function declaration without a prototype is deprecated in all versions of C [-Wstrict-prototypes] static void makeDefaultPatch() {
                            ^
                             void
emu2413.c:411:29: warning: a function declaration without a prototype is deprecated in all versions of C [-Wstrict-prototypes] static void initializeTables() {
                            ^
                             void
2 warnings generated.

Thank you. This project does not intend to eliminate all pedantic warnings, but the patched content should be corrected for consistency.

Sorry for late reply. Thank you for adopting emu2413!!

@okaxaki I did not realize when I made this PR, but seems like it will become a compiler default in future gcc and clang versions.
Reference: https://archives.gentoo.org/gentoo-dev/message/dd9f2d3082b8b6f8dfbccb0639e6e240

@orbea Thank you for information.