Unable to read anything from older Daikin Altherma EKHBX008AA9T1

Hi,
I have been testing your work against my older Daikin Altherma.
And it does not work.
I fully understand that you have not tested this, and that I am a bit on my own here. But nevertheless...
I have come this far:

I get a NACK response {0x15, 0xEA} if I send something the unit does not accept.
Attempt to read any register (0-255) using your msg format {0x03, 0x40, regNo, CS} gives the above NACK response. I have tried all 256 values.
I have looked at serial port signals using an oscilloscope and they seem fine.
I have verified that the first byte of the message is indeed the message length. If I send fewer bytes that the length byte indicates, I get no response.
I have tried to remove the checksum (and set length to 0x02) and I still get the NACK response.

So it is clear that the serial communication by itself works.
And it seems that my unit use a different but similar message protocol than what you have implemented.
My questions then are:

what approach did you use in your initial work to reverse engineer the message protocol
do you (or someone you know about) sit on any information that would enable me to try to read data from my unit.

Any info would be appreciated.
And of course, I would be willing to contribute all my findings to your project.
Thanks and kind regards
Jon

Hello @Jonkrist
Sorry for the late reply.
Until now, all the ESPAltherma users reported a full compatibility with their Altherma/ROTEX with X10A port. But it seems that some (old?) Althermas do not implement the same protocol as all others and reject (0x15, 0xAC) every registry queries...
The approach I would suggest (which is the approach I initially used) is to use DChecker (a Daikin software interfacing with X10A) and see first if it gets data from your heat pump and, if so, using which protocol.
Seeing that the NACK reply is consistent with the protocol used in other Althermas, I would assume that the difference is minimal.
Hope you can figure it out!

Hi,
Thanks for replying.
I Will see if I can find a place a link to DChecker and give it a try. If
you have a download link that would be highly appreciated.
Right now I am testing Arnold Niessen’s P1P2 approach.
Thanks again.
Jon
søn. 16. jan. 2022 kl. 22:47 skrev Raomin @.***>:

Hello @Jonkrist https://github.com/Jonkrist
Sorry for the late reply.
Until now, all the ESPAltherma users reported a full compatibility with
their Altherma/ROTEX with X10A port. But it seems that some (old?)
Althermas do not implement the same protocol as all others and reject
(0x15, 0xAC) every registry queries...
The approach I would suggest (which is the approach I initially used) is
to use DChecker (a Daikin software interfacing with X10A) and see first if
it gets data from your heat pump and, if so, using which protocol.
Seeing that the NACK reply is consistent with the protocol used in
other Althermas, I would assume that the difference is minimal.
Hope you can figure it out!
—
Reply to this email directly, view it on GitHub
https://github.com/raomin/ESPAltherma/issues/74#issuecomment-1013958711,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AKSVNHSUCWNCHS2VRV2MXWLUWM4IZANCNFSM5LD2YH3Q
.
Triage notifications on the go with GitHub Mobile for iOS
https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675
or Android
https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.
You are receiving this because you were mentioned.Message ID:
@.***>

You'll find it here: https://www.thermalsupplyinc.com/daikin-service-checkers/

Thanksa lot -  found it 😊
Jon
Fra: Raomin @.>
Sendt: 17. januar 2022 22:08
Til: raomin/ESPAltherma @.>
Kopi: Jonkrist @.>; Mention @.>
Emne: Re: [raomin/ESPAltherma] Unable to read anything from older Daikin Altherma EKHBX008AA9T1 (Issue #74)
You'll find it here: https://www.thermalsupplyinc.com/daikin-service-checkers/
—
Reply to this email directly, view it on GitHub https://github.com/raomin/ESPAltherma/issues/74#issuecomment-1014885894 , or unsubscribe https://github.com/notifications/unsubscribe-auth/AKSVNHS4PV2KPT2I2WWG673UWSAJHANCNFSM5LD2YH3Q .
Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675  or Android https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub .
You are receiving this because you were mentioned.Message ID: @.***>

Hej,
same issue here, getting this back, which I guess confirms the connection is fine.
I was so excited when I found this project - but had some doubts as the unit is also quite old, also an EKHB.
espaltherma/log Querying register 0x61...
espaltherma/log ERR: Time out on register 0x61! got 2/10 bytes

espaltherma/log 0x15 0xea
...

@Jonkrist Any luck yet with the protocol? Happy to do some testing here too ...
Best,
-T

Quick update, I am very sure now this is the same protocol as here in #46.
To confirm I modified a few things according to the guidance from @raomin in this post.
So pretty much changed
char prep[] = {0x03, 0x40, regID, 0x00} to char prep[] = {0x02, regID, 0x00} and then only adjusted the command lengths.
And then in default.h did
{0x54,2,103,2,1,"test"}
And that gives me something more useful. Now I am pretty much stuck as I don't know how to adjust the converters/labels ... :)
But this seems to confirm it uses the same protocol from issue 46 ...
espaltherma/log Querying register 0x54...
espaltherma/log ERR: Time out on register 0x54! got 18/22 bytes

espaltherma/log 0x54 0x20 0x16 0x50 0x15 0x78 0x17 0xc4 0x14 0xdc 0x15 0x01 0x00 0x1c 0x00 0x00 0x00 0x9b
or
espaltherma/log 0x54 0x20 0x16 0x50 0x15 0x60 0x17 0xc4 0x14 0xdc 0x15 0x01 0x00 0x1c 0x00 0x00 0x00 0xb3

Hey! That's good progress indeed...!
From #46 it appears that only 4 registries are available, U T P S, ie 0x55 0x54 0x50 0x53
They are indeed queried with {0x02, regID, CRC}
From what I could find in D-Checker, it's what Daikin calls 'S protocol".
Looking inside D-Checker file under \Storage\DataModule\Conv\S there is a default.txt file, it contains precious info on the S protocol and some info on values:
U,0,1,201,%s,,1,1,0,Operation Mode,-1,-1,-1,-1,-1,-1,-1,1,
T,13,1,151,%.0f,A,1,1,0,R/C Setpoint,-1,-1,1,-1,-1,-1,1,0,
T,12,1,312,%.2f,A,1,1,0,Delta-Tr(deg),-1,-1,1,-1,-1,-1,-1,0,
U,1,1,204,%s,,1,1,0,Error Code,-1,-1,-1,-1,-1,-1,-1,0,
U,2,1,204,%s,,1,1,0,Thermo Off Error,-1,-1,-1,-1,-1,-1,-1,0,
U,3,1,204,%s,,1,1,0,Warning Code,-1,-1,-1,-1,-1,-1,-1,0,
U,4,1,204,%s,,1,1,0,Caution Code,-1,-1,-1,-1,-1,-1,-1,0,
T,0,2,103,%.2f,A,1,1,0,Indoor Suction Air Temp.,0,-1,1,-1,-1,-1,1,0,
T,2,2,103,%.2f,A,1,1,0,Indoor Heat Exchanger Temp.,1,-1,1,-1,-1,-1,1,0,
T,4,2,103,%.2f,A,1,1,0,Outdoor air temp.,2,-1,1,-1,-1,-1,1,2,
T,6,2,103,%.2f,A,1,1,0,Outdoor heat exchanger temp.,3,-1,1,-1,-1,-1,1,0,
T,8,2,109,%.2f,A,1,1,0,Discharge pipe temp.,4,-1,2,-1,-1,-1,1,5,
T,10,2,103,%.2f,A,1,1,0,Fin Temp.,-1,-1,1,-1,-1,-1,1,0,
P,0,2,103,%.2f,A,1,1,0,HP Sensor,-1,-1,1,-1,-1,-1,2,3,
P,2,2,103,%.2f,A,1,1,0,LP Sensor,5,-1,1,-1,-1,-1,2,4,
S,4,1,200,%.0f,A,1,1,0,INV Comp. Frequency(Hz),6,-1,2,-1,-1,-1,-1,7,
S,6,1,200,%s,D,1,1,0,52C Output,0,-1,-1,-1,-1,-1,-1,0,
S,0,2,152,%.0f,A,1,1,0,EV (pls),7,-1,3,-1,-1,-1,-1,0,
S,2,1,164,%.0f,A,1,1,0,Outdoor Fan (Upper)(rps),-1,-1,3,-1,-1,-1,-1,0,
S,3,1,164,%.0f,A,1,1,0,Outdoor Fan (Lower)(rps),-1,-1,3,-1,-1,-1,-1,0,
S,8,1,200,%s,D,1,1,0,20R (SV) Output,1,-1,-1,-1,-1,-1,-1,0,
S,7,1,200,%s,D,1,1,0,20S (4-way) Output,2,-1,-1,-1,-1,-1,-1,0,
S,10,1,200,%s,D,1,1,0,Crankcase Heater,3,-1,-1,-1,-1,-1,-1,0,
S,5,1,200,%s,D,1,1,0,Comp. Preheat,-1,-1,-1,-1,-1,-1,-1,0,
S,11,1,200,%s,D,1,1,0,Ener-Cut Output,-1,-1,-1,-1,-1,-1,-1,0

My understanding of this file:
[RegID],[Offset/Position in the response],[data size], [convID],[type for display]...[label]...
So you should take default.h and adjust like so with the values in the file:
[RegID],[Offset/Position in the response],[convID],[data size],-1, [label]
For the converters, the ones in ESPAltherma should match.
Looking back at #46, it looks that the HP always return 16 bytes, whilw ESPAltherma (protocol @) has a variable length given in the response. So you should change this too.
Something like: comm.h:32
  while ((len < 16 + 2) && (millis() < (start + SER_TIMEOUT)))

this should work.
Have fun!

Almost there (I hope).
Implemented as per your kind guidance. 0x50 gives no response - which actually correlates with the screenshot from #46 (no "HP Sensor" & "LP Sensor" in the screenshot of the Daikin tool either over there.
So commented these 2 lines out.
Got no actual errors but also no values so looked into the code and in converters.h changed below to account for the changed offset of the response.
// readRegistryValues(data[1], data);
readRegistryValues(data[0], data);
...
// input += labels[i]->offset + 3;
input += labels[i]->offset + 1;

And got (limited) success! (also added some debug code to see the raw values).
Converter 164 & 312 missing.
The temperatures make little sense, unit was not running. The 20 ... 22 °C could be some indoor temp, but outside temp. was more like 5 °C. Note that #46 screenshot also shows some weirdness, discharge pipe temperature @-64 °C etc. @DDoykov.
espaltherma/log Querying register 0x55...
espaltherma/log 0x55 0x01 0x00 0x00 0x00 0x00 0x1e 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x8b
espaltherma/log Querying register 0x54...
espaltherma/log 0x54 0xf0 0x15 0xdc 0x14 0x4c 0x16 0xdc 0x14 0x14 0x2a 0x01 0x00 0x1d 0x00 0x00 0x00 0x08
espaltherma/log Querying register 0x53...
espaltherma/log 0x53 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0xac
espaltherma/ATTR {"Operation Mode":"Heating",
"Error Code":" 0",
"Thermo Off Error":" 0",
"Warning Code":" 0",
"Caution Code":" 0",
"R/C Setpoint":0,
"Delta-Tr(deg)":"Conv 312 not avail.",
"Indoor Suction Air Temp.":21.9375,
"Indoor Heat Exchanger Temp.":20.8594,
"Outdoor air temp.":22.2969,
"Outdoor heat exchanger temp.":20.8594,
"Discharge pipe temp.":84.1562,
"Fin Temp.":0.00390625,
"INV Comp. Frequency(Hz)":"OFF",
"52C Output":"OFF",
"EV (pls)":0,
"Outdoor Fan (Upper)(rps)":"Conv 164 not avail.",
"Outdoor Fan (Lower)(rps)":"Conv 164 not avail.",
"20R (SV) Output":"OFF",
"20S (4-way) Output":"OFF",
"Crankcase Heater":"OFF",
"Comp. Preheat":"OFF",
"Ener-Cut Output":"OFF"}

Hi,
Great work !
I had laud this avsides for a while and have tried the S1S2 interface
approach. Ref.
https://github.com/Arnold-n/P1P2Serial
I have got this working somewhat - I can read some temperatures and
operational status.
But your feedback gives some hope, and I will give it a try as soon as I
get a chance.
I will post my S1S2 work as soon as I have wrapped it up.
Thanks for posting your findings.
Best regards
Jon
ons. 16. feb. 2022 kl. 00:15 skrev Kobbe1 @.***>:

Almost there (I hope).
Implemented as per your kind guidance. 0x50 gives no response - which
actually correlates with the screenshot from #46
https://github.com/raomin/ESPAltherma/issues/46 (no "HP Sensor" & "LP
Sensor" in the screenshot of the Daikin tool either over there.
So commented these 2 lines out.
Got no actual errors but also no values so looked into the code and in
converters.h changed below to account for the changed offset of the
response.
// readRegistryValues(data[1], data);
readRegistryValues(data[0], data);
...
// input += labels[i]->offset + 3;
input += labels[i]->offset + 1;
And got (limited) success! (also added some debug code to see the raw
values).
Converter 164 & 312 missing.
The temperatures make little sense, unit was not running. The 20 ... 22 °C
could be some indoor temp, but outside temp. was more like 5 °C. Note that
#46 https://github.com/raomin/ESPAltherma/issues/46 screenshot also
shows some weirdness, discharge pipe temperature @-64 °C etc. @DDoykov
https://github.com/DDoykov.
espaltherma/log Querying register 0x55...
espaltherma/log 0x55 0x01 0x00 0x00 0x00 0x00 0x1e 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x8b
espaltherma/log Querying register 0x54...
espaltherma/log 0x54 0xf0 0x15 0xdc 0x14 0x4c 0x16 0xdc 0x14 0x14 0x2a 0x01 0x00 0x1d 0x00 0x00 0x00 0x08
espaltherma/log Querying register 0x53...
espaltherma/log 0x53 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0xac
espaltherma/ATTR {"Operation Mode":"Heating",
"Error Code":" 0",
"Thermo Off Error":" 0",
"Warning Code":" 0",
"Caution Code":" 0",
"R/C Setpoint":0,
"Delta-Tr(deg)":"Conv 312 not avail.",
"Indoor Suction Air Temp.":21.9375,
"Indoor Heat Exchanger Temp.":20.8594,
"Outdoor air temp.":22.2969,
"Outdoor heat exchanger temp.":20.8594,
"Discharge pipe temp.":84.1562,
"Fin Temp.":0.00390625,
"INV Comp. Frequency(Hz)":"OFF",
"52C Output":"OFF",
"EV (pls)":0,
"Outdoor Fan (Upper)(rps)":"Conv 164 not avail.",
"Outdoor Fan (Lower)(rps)":"Conv 164 not avail.",
"20R (SV) Output":"OFF",
"20S (4-way) Output":"OFF",
"Crankcase Heater":"OFF",
"Comp. Preheat":"OFF",
"Ener-Cut Output":"OFF"}
—
Reply to this email directly, view it on GitHub
https://github.com/raomin/ESPAltherma/issues/74#issuecomment-1040892730,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AKSVNHS27QSUPBI64X7UHXDU3LNBLANCNFSM5LD2YH3Q
.
Triage notifications on the go with GitHub Mobile for iOS
https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675
or Android
https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.
You are receiving this because you were mentioned.Message ID:
@.***>

@Kobbe1 got some status update?

@Kobbe1 and @raomin
Sorry - I have not had that much time to play with this lately. But finally got some spare time today.
As I said earlier, I have successfully implemented the P1P2 adapter by Arnold and have managed to decode some data from it.
Looking at what I get from Dchecker, it is not very much that agree.
I have a Altherma floor heating/hot water system, and I expect the the S protocol DEFAULT file is not set up for that.
I will try to do some digging into these files to see if I get any further.
One problem I have is that I only found D-Checker version <IP_ADDRESS> and the S protocol DEFAULT file has an .ldd extension and is not readable. Any suggestions?
Here is a screenshot of what I get together with what I get from the P1P2 adapter:

The only temperatures that match is "outdoor heat exchange temp" vs water temp (which is most probably the outgoing water temp to the floor loops,
I also see that the OnOff values to the right seems to change with compressor on/off.
My next step now is to have a look at @Kobbe1 's  changes and see if I can get something meaningful from this data.
I will keep you posted, but this is not my highest priority just now. Sry about that.

So ALTHERMA(OLD).h should look something like this?
`#include "labeldef.h"
// This file is a definition file for the ESPAtherma.
// uncomment each value you want to query for your installation.
LabelDef PROGMEM labelDefs[] = {
{0x75,0,1,201,-1,"Operation Mode"},
{0x54,13,1,151,-1,"R/C Setpoint"},
{0x54,12,1,312,-1,"Delta-Tr(deg)"},
{0x75,1,1,204,-1,"Error Code"},
{0x75,2,1,204,-1,"Thermo Off Error"},
{0x75,3,1,204,-1,"Warning Code"},
{0x75,4,1,204,-1,"Caution Code"},
{0x54,0,2,103,-1,"Indoor Suction Air Temp."},
{0x54,2,2,103,-1,"Indoor Heat Exchanger Temp."},
{0x54,4,2,103,-1,"Outdoor air temp."},
{0x54,6,2,103,-1,"Outdoor heat exchanger temp."},
{0x54,8,2,109,-1,"Discharge pipe temp."},
{0x54,10,2,103,-1,"Fin Temp."},
{0x50,0,2,103,-1,"HP Sensor"},
{0x50,2,2,103,-1,"LP Sensor"},
{0x53,4,1,200,-1,"INV Comp. Frequency(Hz)"},
{0x53,6,1,200,-1,"52C Output"},
{0x53,0,2,152,-1,"EV (pls)"},
{0x53,2,1,164,-1,"Outdoor Fan (Upper)(rps)"},
{0x53,3,1,164,-1,"Outdoor Fan (Lower)(rps)"},
{0x53,8,1,200,-1,"20R (SV) Output"},
{0x53,7,1,200,-1,"20S (4-way) Output"},
{0x53,10,1,200,-1,"Crankcase Heater"},
{0x53,5,1,200,-1,"Comp. Preheat"},
{0x53,11,1,200,-1,"Ener-Cut Output"},
};
`

Here is how I left it back then. Not all of them give useful data but getting most important temperatures and wether unit is on or off. Has been in operation since then without changes.
`{0x55,1,204,1,-1,"Error Code"},
{0x55,0,201,1,-1,"Operation Mode"},
{0x54,8,103,2,-1,"Storage Temp."},
{0x54,10,103,2,-1,"Fin Temp."},
{0x54,0,103,2,-1,"E03 Refrigerant Temp."},
{0x54,2,103,2,-1,"E04 Inlet Temp."},
{0x54,4,103,2,-1,"Outdoor air temp."},
{0x54,6,103,2,-1,"Outlet Temp."},
{0x54,13,151,1,-1,"R/C Setpoint"},
{0x54,12,312,1,-1,"Delta-Tr(deg)"},
{0x55,2,204,1,-1,"Thermo Off Error"},
{0x55,3,204,1,-1,"Warning Code"},
{0x55,4,204,1,-1,"Caution Code"},
//{0x50,0,103,2,-1,"HP Sensor"},
//{0x50,2,103,2,-1,"LP Sensor"},
{0x53,4,200,1,-1,"INV Comp. Frequency(Hz)"},
{0x53,6,200,1,-1,"52C Output"},
{0x53,0,152,2,-1,"EV (pls)"},
{0x53,2,164,1,-1,"Outdoor Fan (Upper)(rps)"},
{0x53,3,164,1,-1,"Outdoor Fan (Lower)(rps)"},
//{0x53,2,152,1,-1,"Outdoor Fan (Upper)(rps)"},
//{0x53,3,152,1,-1,"Outdoor Fan (Lower)(rps)"},
{0x53,8,200,1,-1,"20R (SV) Output"},
{0x53,7,200,1,-1,"20S (4-way) Output"},
{0x53,10,200,1,-1,"Crankcase Heater"},
{0x53,5,200,1,-1,"Comp. Preheat"},
{0x53,11,200,1,-1,"Ener-Cut Output"},
`

Hello,
i'm using a HPSU 508 BJ 2012.
X10A has 8 ports. i'm connecting the NODEMCU v3 with the X10A but only 0x15 0xea is reported in the terminal.
i used the code from pitylee:
#include "labeldef.h"
// This file is a definition file for the ESPAtherma.
// uncomment each value you want to query for your installation.
LabelDef PROGMEM labelDefs[] = {
{0x75,0,1,201,-1,"Operation Mode"},
{0x54,13,1,151,-1,"R/C Setpoint"},
{0x54,12,1,312,-1,"Delta-Tr(deg)"},
{0x75,1,1,204,-1,"Error Code"},
{0x75,2,1,204,-1,"Thermo Off Error"},
{0x75,3,1,204,-1,"Warning Code"},
{0x75,4,1,204,-1,"Caution Code"},
{0x54,0,2,103,-1,"Indoor Suction Air Temp."},
{0x54,2,2,103,-1,"Indoor Heat Exchanger Temp."},
{0x54,4,2,103,-1,"Outdoor air temp."},
{0x54,6,2,103,-1,"Outdoor heat exchanger temp."},
{0x54,8,2,109,-1,"Discharge pipe temp."},
{0x54,10,2,103,-1,"Fin Temp."},
{0x50,0,2,103,-1,"HP Sensor"},
{0x50,2,2,103,-1,"LP Sensor"},
{0x53,4,1,200,-1,"INV Comp. Frequency(Hz)"},
{0x53,6,1,200,-1,"52C Output"},
{0x53,0,2,152,-1,"EV (pls)"},
{0x53,2,1,164,-1,"Outdoor Fan (Upper)(rps)"},
{0x53,3,1,164,-1,"Outdoor Fan (Lower)(rps)"},
{0x53,8,1,200,-1,"20R (SV) Output"},
{0x53,7,1,200,-1,"20S (4-way) Output"},
{0x53,10,1,200,-1,"Crankcase Heater"},
{0x53,5,1,200,-1,"Comp. Preheat"},
{0x53,11,1,200,-1,"Ener-Cut Output"},
};
is it possible to read the "grey" HPSU?

Hello,
i'm using a HPSU 508 BJ 2012. X10A has 8 ports. i'm connecting the NODEMCU v3 with the X10A but only 0x15 0xea is reported in the terminal.
i used the code from pitylee: #include "labeldef.h" // This file is a definition file for the ESPAtherma. // uncomment each value you want to query for your installation.
LabelDef PROGMEM labelDefs[] = { {0x75,0,1,201,-1,"Operation Mode"}, {0x54,13,1,151,-1,"R/C Setpoint"}, {0x54,12,1,312,-1,"Delta-Tr(deg)"}, {0x75,1,1,204,-1,"Error Code"}, {0x75,2,1,204,-1,"Thermo Off Error"}, {0x75,3,1,204,-1,"Warning Code"}, {0x75,4,1,204,-1,"Caution Code"}, {0x54,0,2,103,-1,"Indoor Suction Air Temp."}, {0x54,2,2,103,-1,"Indoor Heat Exchanger Temp."}, {0x54,4,2,103,-1,"Outdoor air temp."}, {0x54,6,2,103,-1,"Outdoor heat exchanger temp."}, {0x54,8,2,109,-1,"Discharge pipe temp."}, {0x54,10,2,103,-1,"Fin Temp."}, {0x50,0,2,103,-1,"HP Sensor"}, {0x50,2,2,103,-1,"LP Sensor"}, {0x53,4,1,200,-1,"INV Comp. Frequency(Hz)"}, {0x53,6,1,200,-1,"52C Output"}, {0x53,0,2,152,-1,"EV (pls)"}, {0x53,2,1,164,-1,"Outdoor Fan (Upper)(rps)"}, {0x53,3,1,164,-1,"Outdoor Fan (Lower)(rps)"}, {0x53,8,1,200,-1,"20R (SV) Output"}, {0x53,7,1,200,-1,"20S (4-way) Output"}, {0x53,10,1,200,-1,"Crankcase Heater"}, {0x53,5,1,200,-1,"Comp. Preheat"}, {0x53,11,1,200,-1,"Ener-Cut Output"}, };
is it possible to read the "grey" HPSU?

You have to make the converter and comm changes.
Also where is that definition from?

Hello, sorry for my bad English,
what changes do I need to make for communication? Unfortunately, I'm not so good at programming.

Hello, sorry for my bad English,
what changes do I need to make for communication? Unfortunately, I'm not so good at programming.

Hi, I will share my experience as I have a very close HP (EKHBX008)
I had several issues at the same time and you need to check them also

Wrong board selected in my platformio.ini and I needed to create a custom profile for my ESP32 board (AZ delivery)

[platformio]
default_envs = esp32_az_delivery

[env:esp32_az_delivery]
platform = espressif32
board = az-delivery-devkit-v4
framework = arduino
monitor_speed = 115200
upload_speed = 115200
; Uncomment this line to allow for remote upgrade. If name resolution does not work for you, replace with the IP of ESPAltherma
; upload_port = ESPAltherma.local
; Uncomment this line if you want to define the protocol. Autodetected otherwise.
; upload_protocol = espota
lib_deps =
        PubSubClient

There were defects on the cable connection and need to change my dupont connectors

I used the wrong profile for my heat pump which is quite old (2009 I guess) Like some users, I'm using an Altherma HP with a 8-pins X10 connector so I made custom 8-pins Dupont connectors in order to avoid problems and avoid mistakes.
Important : for such old HP, I need to stick on PROTOCOL_S_ROTEX or PROTOCOL_S (except 0x50 registers) HP profiles
#include "def/PROTOCOL_S.h"
Now everything is fine and I'm receiving values from the HP. Looking good.

@Kobbe1 Here is my current status (see added comments on how much I trust each):
`
// 0x50 not supported by RDLQ014AA6V3
// 0x53 seems to be a collection of booleans
{0x53, 0, 200, 1, -1, "Circulation pump"},              // Nov 2022 -> OK, verified against control console
{0x53, 3, 200, 1, -1, "External heater?"},              // Nov 2022 -> OK
{0x53, 5, 200, 1, -1, "Priority to domestic water"},    // Nov 2022 -> OK
{0x53, 6, 200, 1, -1, "Burner inhibit from solaris"},   // Nov 2022 -> OK

// Testing stuff....
{0x54, 0, 153, 2, -1, "Refrig. Temp. liquid side(C)"},  // Nov 2022 -> OK, verified against control console E-03 / R13T
{0x54, 2, 153, 2, -1, "Inlet water temp.(C)"},          // Nov 2022 -> OK, verified against control console E-04 / R14T
{0x54, 4, 153, 2, -1, "Outlet Water Temp.(C)"},         // Nov 2022 -> OK, verified against control console / R12T
{0x54, 6, 153, 2, -1, "D(C)"},                          // Nov 2022 -> Could be R11T?
{0x54, 8, 153, 2, -1, "DHW tank temp.(C)"},             // Nov 2022 -> OK, verified against control console
{0x54, 10, 103, 2, -1, "F(C)"},                         // Nov 2022 -> Wrong! Seems to be one/two booleans?!
// Byte 12 seems to be a 1 byte value, evolving during day in continuous way
// 0x1b mid-day, 0x24 mid night -> some delta temp??
{0x54, 12, 101, 1, -1, "Delta-Tr(deg)"},                // Nov 2022 -> most probably the "Weather dependent set point"
{0x54, 13, 151, 1, -1, "R/C Setpoint(C)"},

{0x55, 0, 201, 1, -1, "Operation Mode"},
{0x55, 1, 204, 1, -1, "Error Code"},
{0x55, 2, 204, 1, -1, "Thermo Off Error"},
{0x55, 3, 204, 1, -1, "Warning Code"},
{0x55, 4, 204, 1, -1, "Caution Code"},
// TODO: seems to reply on 0x56 as well, but not used by dchecker...
{0x56, 0, 103, 2, -1, "????"},

`
The RxxT match this schema:

And the kind of graphs I get:

Awesome @agrenott - thanks a lot!

@nicolasvila Your post made me review this again, and I realized that I am still using my old code while it seems by now the S-protocol got merged into the code, must have missed that before. As you seem to have the same unit as mine - can you tell me what readings exactly you are getting? I mean what sensors you can read ... I might upgrade if there is anything in there that I missed back then in February :)

@Kobbe1, Here are below the kind of values I obtain from def/PROTOCOL_S.h
Quite similar as you display on your dashboard. I still have doubts on the real "labels" matching these values, as for example outdoor temp is way to high (currently we are around 10°C)

Thanks, very similar indeed. The standard labels do not apply for our model. You can easily manually match 4 temperatures by comparing with the unit display: outlet water temp + storage tank temp are on the normal display, and refrigerant and water inlet are accessible through the parameter menu under E03 & E04.
Or see agrenott's post and edit the def file accordingly ...
Only 1 temperature not fully clear - @agrenott seems to think its the inlet to the backup heater, which could very well be as it is very close to the outlet temp. Way to verify would be to compare when the backup heater is on - but it is still way too warm for that here :)

Yes, I understand. I'll stick with PROTOCOL_S_ROTEX then. For DHW, I guess this value is unreliable as my HP is not used for DHW :-)
Back to the different protocols, that's surprising anyway to obtain the same values with different calls.
What does mean the third field ? I obtain the same value with 103 or 153.
using PROTOCOL_S_ROTEX
{0x54, 0, 153, 2, -1, "Refrig. Temp. liquid side(C)"},
{0x54, 2, 153, 2, -1, "Inlet water temp.(C)"},
{0x54, 4, 153, 2, -1, "Outlet Water Temp.(C)"},
{0x54, 6, 153, 2, -1, "D(C)"},
using PROTOCOL_S
{0x54, 0, 103, 2, -1, "Indoor Suction Air Temp.(C)"},
{0x54, 2, 103, 2, -1, "Indoor Heat Exchanger Temp.(C)"},
{0x54, 4, 103, 2, -1, "Outdoor air temp.(C)"},
{0x54, 6, 103, 2, -1, "Outdoor heat exchanger temp.(C)"},

You can see the various converters: https://github.com/raomin/ESPAltherma/blob/main/include/converters.h#L84
103 vs. 153 is signed vs. unsigned values; so you'll get same results for raw values "< max / 2" (eg. 0-127 for 1 byte)


Vid did not work

As of yesterday, IBLiSSINYT; Its not a keybind that doesn't work, It might be a bug were I can't switch continually or hold down that keybind. Please check into quick switching.(It happened after the update)

Same i have this problem too


🚧Improve perf of uploading GPU vertex data

I have done the items below . . .

[X] I have updated the title by replacing the '<title>' section.

Description
In the GPUBufferBase class, refactor the UploadVertexData() method TData param to be an IN parameter as well as the generic parameter if required.
Before refactoring this, collect some performance data and also measure performance after to verify that performance is being improved.  If not implemented properly, performance can be worse.
Refer to this video for explanation:
Acceptance Criteria
This issue is finished when:

[ ] Code documentation added if required
[ ] Unit tests added
[ ] All unit tests pass

ToDo Items

[ ] Draft pull request created and linked to this issue
[X] Priority label added to issue (low priority, medium priority, or high priority)
[X] Issue linked to the proper project
[X] Issue linked to proper milestone
[ ] Unit tests have been written and/or adjusted for code additions or changes
[ ] All unit tests pass

Issue Dependencies
No response
Related Work
No response

Groomed


Download icon doesn't show up for some users.

Hi guys, we are not able to see download icon on top-right of page for some users, but some other users are able to see that download icon.
Can anyone suggest some workaround for same.

@Jaski96  can you please re-open if you can provide more info. I cannot reproduce this.
Also, can you check if you have any JS errors and that you're running on AEM CS using latest ASC?


Allow player and bots to select spawn base from available base instead of always fixed ones

As a player, I wanted myself and AI to select spawn base for new units from available base instead of always fixed ones to improve game play strategy
Right now the agent spawn is always from the initial base (unless that base is being taken) which makes the gameplay kind of predicable and less strategic
One proposal will be:
When the agent is about to be spawn, has a threashold (like 5 seconds) to let player/AI to decide the base to be used, otherwise default to the default calculated base

Latest logic allows player and bot to have a fixed time to select before the respawn of unit happen, right now is fixed in length, but will eventually expose in the setting
In AgentSpawnManager.cs, where the allow time (ALLOW_UNIT_CONFIG_TIME) to config must always be smaller than total allowed unit config time (UNIT_CONFIG_TIME) as leave 1 - 2 seconds for server to save and update the setting (otherwise the setting maybe in, but the unit is already spawn)

    public static int UNIT_CONFIG_TIME = 12;

    public static int ALLOW_UNIT_CONFIG_TIME = 10;

    public static int DEFAULT_DELAY = 20;

    private void _notifyAgentConfigServer(String unitID, Team.TeamCode team)
...


Add trim option to export_layers script

This was a great resource, thanks for sharing it! I ended up needing to be able to trim sprites as well, which was easy enough. I slightly restructured the arguments of exportLayers to take the entire data object collected by the dialog, which should make supporting additional options in the spritesheet export easier. Then I added a trim option which is dynamically hidden and shown depending on the value of spritesheet since this option has no effect if the user is not exporting in spritesheet mode.
Please feel free to close this if you think it's unnecessary, but figured I'd open the PR in case it helps!

Hey! I reviewed it and it looks totally fine. The feature is welcome, even more as the implementation is clean and non intrusive. Thanks for the PR!


Misc UI improvements

This is an interim PR with some minor changes.
I am submitting this now as the next step are major changes to elements.py to add context menu help text and tweak right click menu functionality, and to avoid a headache rolling these changes forwards into 0.8.x these would probably be better once the restructuring done in 0.8 has been retrofitted to 0.7 and rolled forward.

Ok - I'll wait for the elements.py restructuring in main to be done. I'll review and approve the PR as quickly as I can once it appears.


Fix broken link in Update email-troubleshooting-guide.md (#350)

Update email-troubleshooting-guide.md

Docs Build status updates of commit 8a48363:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

dynamics-gp/installation/email-troubleshooting-guide.md
:white_check_mark:Succeeded
View

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching the docs.microsoft.com contributor guidesPost your question in the Docs support channel


Releases are not tagged

It would be very useful if the releases of the plugin were also tagged here in git. :slightly_smiling_face:

Each release of the plugin has its own version. But do you mean a git tag?

Yes, that is what i mean.
I was trying to look at the diffs between releases, but it is a bit more cumbersome if i also have to figure out in which commits the releases are done.

Also, thanks for creating the plugin! It is very much appreciated!!

Thanks a lot and I understand! Normally it's not considered mandatory to tag all releases. But what would you recommend?

I retro-tagged (more or less) the changes of minor version : 0.1, 0.2, 0.3, 0.4.

Awesome, this is perfect! Thanks!

It's my turn to thank you. These issues help improve the quality of software.


Update getting started steps to include steps for fixing pystache installation error

Signed-off-by: Shubham Saxena<EMAIL_ADDRESS>Does not contribute to any existing issue.
What did you do?
Updated the Getting Started steps on the README.md file to include a note which highlights the steps to fix a failure of installation of one of the packages (pystache).
Why did you do it?
Installation of pystache was failing because setuptools stopped supporting 2to3 version 58 onwards. Since pipenv doesn't currently support pinning the version of setuptools, the fix has to be applied manually. Moreover, since pipenv virtual environment creation installs (close to) the latest version of setuptools, this issue is likely to be faced by everyone following the Getting Started steps from this point onwards.
How have you tested it?
Tested the steps on my own local machine (twice).
Were docs updated if needed?

[ ] No
[ ] Yes
[x] N/A

Type of change

[x] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

[x] My code follows the style guidelines of this project
[x] I have performed a self-review of my own code
[ ] I have commented my code, particularly in hard-to-understand areas
[x] My changes generate no new console logs
[x] Fixes entire issue
[ ] Partial fix for issue

@shubham599 any updates on this issue? Thank you.
FYI @demilolu

Instead of adding workaround to the docs, @shubham599 removed pystache and tested the solution. See #155 and issue #152.


Fix ballistic shield backpack code

Code: https://game8.co/games/Helldivers-2/archives/446540

Thanks!


Intrastat

Followed the comments from; https://docs.microsoft.com/en-us/dynamics365/unified-operations/financials/localizations/tasks/transfer-transactions-intrastat
using Installed product version : Microsoft Dynamics 365 for Finance and Operations, Enterprise edition (7.3)
Installed platform version : Update12 (7.0.4709.41124)
This product is licensed to:
d365try.onmicrosoft.com
Serial number: eb84c22f-b952-4ca4-9306-54b39cee72db
and there is nothing to select from the lookup against the released product. please feedback. Thanks

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 85a5eb7a-3e08-5770-f406-41e3cf0ed9e5
Version Independent ID: 70b1259d-7e99-622c-2bd5-7880c1373dd2
Content: Transfer transactions to the Intrastat - Finance & Operations | Dynamics 365 | #MSDyn365FO
Content Source: articles/financials/localizations/tasks/transfer-transactions-intrastat.md
Service: dynamics-ax-applications
GitHub Login: @Anasyash
Microsoft Alias: anasyash

@Anasyash please review this documentation issue and update the topic if needed.

Bug 280778 has been logged to track this issue.

The topic is complete. Please log a support request for further assitance.


Extensions/SCM input box: typing Cmd+F does not open editor find box

Steps to Reproduce:

click into SCM or Extensions input box
type Cmd+F

=> 🐛  editor does not show find box.
I guess this is because of those input boxes being actual editors, but they should not steal keybindings.

When Cmd+F is trriggered in the SCM or Extensions input box, it use the focus code editor as the priority selection. However, users usually expect to open find widget at the active code editor.
File: src/vs/editor/browser/editorExtensions.ts
export abstract class EditorCommand extends Command {

	public runCommand(accessor: ServicesAccessor, args: any): void | Promise<void> {
		...
		const editor = codeEditorService.getFocusedCodeEditor() || codeEditorService.getActiveCodeEditor();
		...
	}

}

I think that different editor should be use for different command. What makes me unsure is whether we shoud add a distinction process here.

We closed this issue because we don't plan to address it in the foreseeable future. If you disagree and feel that this issue is crucial: we are happy to listen and to reconsider.
If you wonder what we are up to, please see our roadmap and issue reporting guidelines.
Thanks for your understanding, and happy coding!


Add swift:5.4-focal

Adding Swift 5.4 to the mix so PRs would be tested on 5.2, 5.3, and 5.4. Alternatively we could use the strategy of oldest (5.2) and latest (now 5.4) supported.

Since we don't pay for CI and it's all parallelised I'm happy to do all 3


⚠ Bofrost.at has degraded performance

In b461418, Bofrost.at (https://www.bofrost.at) experienced degraded performance:

HTTP code: 200
Response time: 823 ms

Resolved: Bofrost.at performance has improved in 68e9f7c after 18 minutes.


Simplify integration with flakes/access to inputs in "treefmt.nix"

Is your feature request related to a problem? Please describe.
It would be nice / easier / cleaner if the integration would not require to define custom-functions. It was a hassle to adjust the treefmtEval function to pass-through inputs to be able to use a package from input, maybe this can be adjusted that all arguments like on imports/modules can be used automatically:
      treefmtEval = eachSystem (pkgs:
        treefmt-nix.lib.evalModule pkgs (import ./treefmt.nix {
          inherit nixfmt;
          system = pkgs.system;
        }));

Describe the solution you'd like
Maybe they can be provided by treefmt-nix.lib. instead?
Describe alternatives you've considered
see above
Additional context

Oops, this somehow skipped my attention. You can use overlays, or extend the _module.args with more variables.
      treefmtEval = eachSystem (pkgs:
        treefmt-nix.lib.evalModule pkgs {
          imports = [ ./treefmt.nix ];
          _module.args.inputs = inputs;
        });

Then in the treefmt.nix:
{ inputs, ... }:
{
  // ...
}

Hey, no worries - did far more nix since then and explored different options 😃


fix(app): keep 404 but redirect from base to files

Fixes issue where "homepage" aka "/" was redirecting to 404 @shanewilson @cy @ithinkicancode ?

👍


Error importing JSONParser

In our code base when we try to import JSONParser with import { JSONParser } from '@streamparser/json'; we get the following error TS2307: Cannot find module '@streamparser/json' or its corresponding type declarations..
Currently as a work around we are importing it with const jsonStreamParsers = require('@streamparser/json'); which works fine.
My question is, do you have any insights to why the usual import is failing? Or is this likely a problem with the configuration of our project in some way?
Thanks.

Related https://github.com/MatrixAI/Polykey/issues/516

Hi @tegefaulkes ,
Which version of @streamparser/json are you using?
Which bundler are you using (webpack, rollup, esbuild, ...)?
The types are embedded in the package: https://github.com/juanjoDiaz/streamparser-json/blob/main/packages/plainjs/package.json#L8-L15 so there shouldn't be any problem.
You can check in your node_modules folder that the package is installed and the types are where they should be.
You can see here that a bunch of people is using it without a problem.

Our tsconfig specifies "module": "CommonJS".
If we use a simple script like this:
import { JSONParser } from '@streamparser/json';

async function main() {
  console.log(JSONParser);
}

main();

Then attempt to compile with tsc it gives us this:
[nix-shell:~/Projects/Polykey]$ tsc ./test.ts
test.ts:1:28 - error TS2307: Cannot find module '@streamparser/json' or its corresponding type declarations.

1 import { JSONParser } from '@streamparser/json';
                             ~~~~~~~~~~~~~~~~~~~~

Found 1 error in test.ts:1

Current version of @streamparser/json is 0.0.12.
The tsc is 4.9.3.
We use lots of other packages, this is the first we have encountered this problem. Is it because of different package configuration?

We don't use any bundler. It's just tsc.
We're also using swc, but swc does not have the same problem.

Full tsconfig.json is:
{
  "compilerOptions": {
    "outDir": "./dist",
    "tsBuildInfoFile": "./dist/tsbuildinfo",
    "incremental": true,
    "sourceMap": true,
    "declaration": true,
    "allowJs": true,
    "strictNullChecks": true,
    "noImplicitAny": false,
    "experimentalDecorators": true,
    "esModuleInterop": true,
    "allowSyntheticDefaultImports": true,
    "resolveJsonModule": true,
    "moduleResolution": "node",
    "module": "CommonJS",
    "target": "ES2022",
    "baseUrl": "./src",
    "paths": {
      "@": ["index"],
      "@/*": ["*"]
    },
    "noEmit": true
  },
  "include": [
    "./src/**/*",
    "./src/**/*.json",
    "./tests/**/*",
    "./scripts/**/*",
    "./benches/**/*"
  ],
  "ts-node": {
    "require": ["tsconfig-paths/register"],
    "transpileOnly": true,
    "swc": true
  }
}

I have it fixed on my end.
As a hint, I went to the dist/package.json file and removed this part:
  "typesVersions": {
    "*": {
      "*": ["./src/*"]
    }
  },

The typings were immediately matched in my VS Code.
Not sure why the typesVersions prop is an issue, but apparently that's the case.

Cool, are you going to release a new version with the fix?

Thanks for the hint.
The issue seems caused by a bug in Typescript: https://github.com/microsoft/TypeScript/issues/43133
I'll do a fix asap 🙂

This is fixed as part of 0.0.13.
Thanks for your patience!

Nice!


empty build being generated when running vite build --watch

Explanation:
when running vite build --watch, it initially builds correctly. However, after the first change to generates an empty build
Codesandbox reproduction: https://codesandbox.io/s/vite-plugin-chrome-extension-watch-build-bug-py0nd?file=/src/main.tsx
Reproduction steps:

open the code sandbox link
run yarn start (vite build --watch) and check the /dist directory. you'll notice that it's built correctly
09
change
Hello World
 in main.tsx to
Hello

check the /dist dir again you will notice that only 2 files are generated manifest.js and manifest.json

Build log:
build started...

Find entry files
main: src/main.tsx

✓ 22 modules transformed.
dist/manifest.json        0.13kb
dist/index.html           0.28kb
dist/main.js              0.12kb / brotli: 0.09kb
dist/vendor.6ad9ec51.js   127.61kb / brotli: 36.10kb
built in 6251ms.

build started...

Find entry files
src/manifest.json

✓ 23 modules transformed.
Generated an empty chunk: "manifest"
dist/manifest.json   0.13kb
dist/manifest.js     0.00kb / brotli: 0.00kb
built in 64ms.

Thank you for this great plugin, please let me know if there's anything I can do to help :)

Indeed --watch option is not available now, and it is in the current work. I will make it work normally as soon as possible.

Thank you :). if it's possible I'd like to help by contributing code, but I don't know if I'll be free before the weekend

+1 for this! loving this package but supporting --watch would be perfect

Any updates on this? Is there any way we could help?

+1

@infix Can we please have an update on this?

Is this issue dead?

Indeed --watch option is not available now, and it is in the current work. I will make it work normally as soon as possible.

Hello, can you fix this as soon as possible, it would be very useful

I am also interested in this

I wasn't happy with the npm-watch solution. @StarkShang I think you are probably very busy or have moved on from this project, but maybe you could point where to where in the code you think I would need to adjust to support --watch and I could potentially open a PR for this? Or even just a rough sketch for how you think you would tackle solving this? Thanks!

is there any update on this matter?

Looking forward to this feature, when will it be supported?


add default values for all nullable

Add default values for all nullable properties, without it we can get NPE at WebBrowserInfo.fromMap() at the main device_info_platform_interface plugin
more info here:
https://github.com/fluttercommunity/plus_plugins/issues/255

Oh I see now the new PR. If the previous one is no longer required, can you close it?

Please look this (more correct) solution: #258

can you also please merge with main

I am going to continue on the other PR making all values nullable

Thank you but still not available here https://pub.dev/packages/device_info_plus
Update please.


Request more workflow template for Item Journal and FA Journal

The system already have workflow template for general journal (MS-GJBAPW and MS-GJLAPW).
So, please also do:

Implement more workflow template for Item journal (maybe: MS-IJBAPW and MS-IJLAPW) for "Item journal" page.
Implement more workflow template for Fixed Asset (maybe: MS-FAJBAPW and MS-FAJLAPW) for "FA journal" page.

We currently don't have plans to extend this. If you feel strongly about this make sure to add this as product suggestion on https://aka.ms/bcideas.


⚠ Samsung has degraded performance

In af649a2, Samsung (https://samsung.com) experienced degraded performance:

HTTP code: 200
Response time: 2244 ms

Resolved: Samsung performance has improved in a072a11.


Add ungit GUI

would you be interested in rebasing your PR @zigarn ?

just take into account GUI clients are now ordered through popularity order as determined by Google Trends 12 month view ( #975 )
while I don't think nobody is going to be very picky, at least an effort should be made to keep an approximated order

PR rebased.
I ordered ungit between git-cola and gitbox: https://trends.google.com/trends/explore?q=git cola,ungit,gitbox,aurees,cycligent

Thanks for rebasing. This looks good, except that the filename for the image has a typo (x2 instead of 2x) which causes a broken image on the GUIs page.

Oh right.
Fixed.


Language fallback

Hello!
Thanks for the great plugin, it is currently my favorite setup for i18n in gatsby.
I am considering to to add support to it for a fallback language, as described in i18next https://www.i18next.com/overview/configuration-options#languages-namespaces-resources
Looking at your repository, I've found this line https://github.com/microapps/gatsby-plugin-react-i18next/blob/master/src/plugin/wrapPageElement.tsx#L111 which seems to setup i18next for using the default language as a fallback.
This solution is pretty neat, though we could enhance it to support the i18next "classic" options.
I am curious what is your opinion on this feature, and how you would see it implemented.
I am not exactly sure where to start, but would love to look a bit more at it with your advices/guidance.
Thanks in advance,
cheers
PS: i've noted from closed PR that you mention that this feature is not supported yet, and that you'd welcome a PR (here, there)
PS.2: it seems that the reason the "fallback" language is "not working" could be that the default language data is not loaded or passed to the wrapPageElement.tsx component? Maybe something to be done in createNode?

Hum, actually it seems that on a page graphql query, not specifying the $language variable, returns all locales, and then allow the fallback on the correct default language.
export const query = graphql`
  query {
    locales: allLocale {
      edges {
        node {
          ns
          data
          language
        }
      }
    }
  }
`;

If the site is multilingual then you'd be loading up multiple languages with this approach which isn't ideal, the context has i18n data including fallback language so it could probably be exposed at the filter level and passed as a second parameter to only load 2


Footnotes throw following error: Cannot read properties of undefined (reading 'references')

When calling the parse method on a string with footnotes the function blows up.
Repro steps:
md = new MarkdownIt();
const result = md.parse("Hello some footnote. [^1]\nSome other stuff\n\n[^1]: Footnote content\n");

the md content is read from disk and it looks like this:
Hello some footnote. [^1]
Some other stuff

[^1]: Footnote content

Version in package.json: ^13.0.1

Thank you that was it. Though, weird that it doesn't break when footnotes are not there


fix bug judgment date update to document date

Changes in this PR:
Fix bug - update judgment date to document date
Trello card / Rollbar error (etc)
https://trello.com/c/d8xx20TW/1229-eui-bug-dates-not-showing-replace-all-references-to-document-date-judgmentdateasstring-with-documentdateasstring
Screenshots of UI changes:
Before
Judgment

Press Summary

After
Judgment

Press Summary

[ ] Requires env variable(s) to be updated

 EUI | Bug | Dates not showing | Replace all references to document date .judgment_date_as_string with .document_date_as_string

@Donna-H @timcowlishaw I think ultimately, we want to replicate the running order for static metadata panels to match the form version on the Review screen so that editors can more easily locate things as they will be in the same place. We're doing this on the spat panel for instance. E.g. NCN top left etc.

@Terry-Price yes we have planning this week can be added to that session for next sprint


Add CodeQL Scanning

Default configuration from Github for CodeQL
Adding the first round of code scanning.

looks like it doesn't scan dependencies? you gonna add this to "all the repos"?

codeql exists in the ziti repo at this time. i added it and didnt' know you had a PR for it :)


Enable CRC32-C by default in BK client

Motivation
In Pulsar 2.0 when we switched to BK 4.7 we had the option to use CRC32-C as checksum for BK. CRC32-C is considerably faster than CRC32 since it uses hardware instructions to compute. We didn't immediately switch the default to crc32-c to allow for release rollback (Pulsar 2.0 -> 1.22).
We can now enable this, since rolling back from 2.1 -> 2.0 will work now.
Fixes #1371

do we need to document the upgrade path?

In this case it would a notice to users that the default was changed.
In general we should have a place were to collect all the notices/warning for a release. One option could be to keep adding to http://pulsar.apache.org/release-notes/ but in a HTML commented out section, which we can un-comment at the release time. What do you think?

+1 that works for me.


URL Rewriting topic+sample update for 3.0

Fixes #13338
Internal Review Topic

Sample update to 3.0 confirmed working.
Whole-topic versioning.
There are no significant content updates here. Fortunately, it ✨ Just Works!:tm: ✨ for 3.0.

@anurse  - who should help look at this?

@mikaelm12 is my co-author on this and worked on the original topic with me.

https://github.com/aspnet/AspNetCore/commits/master/src/Middleware/Rewrite/src
Not much there ... I don't think we explicitly call out limiting domains for RedirectToWwwRule, but that would be fairly quick to determine from API docs and IntelliSense.

Yup! @guardrex is right. I'll review this in full on Monday!

@mikaelm12 There are no content changes on the PR, and the sample is unchanged except for the update to 3.0. If there aren't framework changes (breaking changes, new/modified API), then you don't need to perform an in-depth review unless you want to.

any 3.0 changes to URL rewriting?

Nope


[Bug][server-api] copy the node ,the preTasks is error

When we copy a node form process definition,the value preTasks is the source node .when we link the noe previous node ,this value would't change .when start a process instance from fail node ,this error may cause that some copy node which agter the failed node  will not execute.

Yeah, there is a problem, and I will try to fix.


Adds JUJU to the Kubernetes Provider listing

This feature adds Juju provisioning to the kube-up script. It currently
parses out the pre-requisits on debian/ubuntu based systems and installs
them if they are missing.
From there we followed the integration path that was found in the
libvirt-coreos path, implementing the methods found in the boilerplate
and calling juju service calls. There are a few "arbitrary sleeps" in
the code to allow the cloud provider to settle and properly deploy.
These are work-around cases from the script executing faster than juju
was able to communicate from the state server to subsequent nodes. I
left comments inline at these points.
To exercise this:
export KUBERNETES_PROVIDER=juju
cluster/kube-up.sh

It will spin up a ref arch with 1 Kubernetes Master, 2 minions, and run
the cluster validation checks against the deployment. Bridging the gap
between the juju specific bits and the upstream recommended guides for
getting started with Kubernetes.
To note, if you do not have a "current environment" set in Juju, it will
spin up the quickstart integration wizard in interactive mode, allowing
you to configure juju, and add the proper provider/use it. Otherwise it
assumes you're in the provider you wish to use, and will deploy there.

It seems that the flags for the various binaries are stored outside this repo, at places like https://github.com/whitmo/charm-kubernetes-master/blob/master/files/apiserver.upstart.tmpl.
For the other cloud providers which support kube-up.sh, the flags are in our repository.  This allows us to make changes in a single commit to both the source code and the flags for all those distros.
Is there a reason to have the code for juju split across repos in this way?

Thanks for the review!
The current structure of our repositories reflects a pattern we use to separate concerns in the charm store - but this does not reflect the pattern you would need to perform easy updates as the kuberentes project moves foward. I apologize for not recognizing that before issuing the PR.
I'll get the charms/bundle pulled into this branch and we will certainly look into conglomerating our resources that are outside of the GCP namespace so it's easier to track.

@chuckbutler @whitmo
Have you thought about whether your goal is (1) to have periodic releases of Kubernetes-on-JuJu, or (2) to ensure that Kubernetes-on-JuJu is always compatible with the very latest K8s source code.   Option (2) comes with higher expectations in terms of test automation and your overall level of involvement in the kubernetes project.
If your goal is (1), then we should talk about whether this PR is needed at all.
If it is (2), then this PR is definitely the right direction, but I expect additional steps will be needed too, such as moving JuJu Charm files into the kubernetes repo, as mentioned above; and running kubernets e2e test continuously, etc.
I'm happy to see either outcome.  Also, it is fine to start with 1 and move to 2 in the future.

Bunch of comments on the bash script... I'll reassign to @erictune to decide whether it's OK to merge though, I'm not very familiar with Juju (well, I know what it is and that's that...) so I'd prefer if someone else would take a look at it.
Let me know if you need me to take another look at the shell scripts later in the code review.
Cheers,
Filipe

Thank you for the review @filbranden. I'll be working on implementing the comments and should have this ready for re-review on Monday.
Cheers!

Thanks, @filbranden.  All your comments look reasonable to me.

@chuckbutler hoping to hear your thoughts on https://github.com/GoogleCloudPlatform/kubernetes/pull/5414#issuecomment-79253588

@erictune,
We’ve had a bit of a discussion around this to ensure everyone working on the Juju Kubernetes integration is on the same page. We’re all in agreement that having the Juju Charms and Bundles in the Kubernetes repository is in the best interest of our project moving forward.  We’re actively working on addressing the automation of e2e testing - and currently have some basic stand up testing and validation running in our CI. It’s not as automated as requested above, but we’re working towards that end. If you’re interested in the CI reports, you can view them here:   http://reports.vapour.ws/all-bundle-and-charm-results/gh%3Awhitmo%252Fbundle-kubernetes
Adding the visibility of Juju as an officially supported (and hopefully recommended) method to deploy K8’s - we feel this brings users a new and different way to deploy a cluster that has implications beyond just standing up Kubes.
We plan to continue adjusting the charms to ensure they work with the latest upstream, and to provide configuration options to run different releases. We would like to continue to support this moving forward as the project evolves.
What do you feel are the next steps for the team to proceed forward?

I'm happy to hear you plan to work on e2e testing, and I'm happy for users to have Juju as an option for deploying Kubernetes.
I think the next steps are:

you fix the build failure
I'll merge this PR
over time, the Juju+Kubernetes folks to try to get as many of the e2e tests passing as possible.
as you do that, you will probably send additional PRs to extent the cluster/juju/... files.
we may make reasonable requests for features or file reorganizaton on those future PRs

Looking at the build failure, it looks like it doesn't like the boilerplate at the top of your shell scripts.
You may need to do this to run precommit checks:
``
cd kubernetes/.git/hooks/
ln -s ../../hooks/prepare-commit-msg .
ln -s ../../hooks/commit-msg .

I've looked several places and I don't see a CLA that would apply to this PR. Let me know if you think this is wrong, or need to talk about it off-PR.

@erictune we're at a point that we should probably talk off PR. I'm going to pull @whitmo and @mbruzek into the thread.

@erictune I've got confirmation from legal that our CLA is now signed, and our team has joined the CLA google group. Can you confirm that this is indeed the case?

I can't see the CLA yet. Let's wait one day to see if things need time to propagate through my side.

@chuckbutler contact me at<EMAIL_ADDRESS>

Ongoing offline CLA discussion...

I've verified CLA offline.


Property 'accessToken' does not exist on type 'UserInfo | NoUserInfo'.ts(2339)

const { accessToken } = await getUser();
Attempted to retrieve the accessToken according to the example given in the documentation but it is resulting in a Typescript error.
Property 'accessToken' does not exist on type 'UserInfo | NoUserInfo'.ts(2339)

Hi there, which version of the library are you using?

I’m using 0.6.1

I noticed that in the library, accessToken is missing under NoUserInfo interface

I see the issue, it's missing from the interface as you mentioned: https://github.com/workos/authkit-nextjs/blob/main/src/interfaces.ts#L26-L32
I'll get a fix up soon.

Thanks for the help


Better instruction for configuring InfluxDB interface

The README.md doesn't include detailed instructions on how to configure InfluxDB for the newly installed VictoriaMetrics addon.
This is a problem for less experienced Home Assistant and InfluxDB users (like me).
Detailed instructions would allow the effective installation/configuration of this plugin.
As it is, people may just get stuck at configuring InfluxDB for VM and finally give up on the whole thing and remove the VictoriaMetrics addon.
It would also be important to explain how to validate the setup so that people can be sure that data is collected properly and can be queried as well (e.g.: via Grafana)

Hi, is this doc not enough?
https://github.com/fuslwusl/homeassistant-addon-victoriametrics/blob/main/victoria-metrics/DOCS.md
I tried my best to explain the right configuration and usage.
Better docs are welcome as pullrequests.

Yes, that documentation is good enough and using it is how I finally solved the issue and made VM working in my Home Assistant instance.
However, I missed it for the first couple of attempts and only noticed it much later (due to being  beginner and not used to the "Documentation" tab of addons). I tried to make it work only via the README.md and didn't notice the content of the Documentation tab at all.
I would recommend linking the DOCS.md into the README.md of the repo as well so that everybody finds it easily.
In the "Installation and configuration" section, under point 3, I would write something like this:
Configure VictoriaMetrics using its [addon configuration documentation](DOCS.md) which can also be found on the Documentation tab of the addon in the Home Assistant settings.

instead of the current text:
Read the add-on documentation in the Victoria Metrics documentation tab

I can propose the change with a PR if you think it makes things better.

Thanx for your feedback. README.md updated.

I would add it would be useful to be a little more specific with these influxdb config options:
  host: <<<ADD-ON HOSTNAME FROM VICTORIA METRICS ADD-ON PAGE>>>
  port: 8428 # Victoria Metrics port

Then because it is stated Add influxdb integration to your homeassistant config it implies that the influxdb documentation should be completed which includes creating a db and users, it would be helpful to state:
Add influxdb integration to your homeassistant config - only complete the Installation step and make sure the integration starts
Thanks for your work on this!


js-smooth updates

Probably needs more testing before merging but this is a start!

Or maybe it needs more testing after merging :D


Update Gen-Gherkin Feature File Template and Plugin Tests

Description
Update to the feature file template and plugin tests
Linked Items:
Closes/Fixes/Resolves #8 #10
Added

Describe any new features.

Changed

Describe any changes in existing functionality.

Deprecated

Describe any deprecated features.

Removed

Describe any removed features.

Fixed

Describe any bug fixes.

Security

Describe any security-related changes.

Checklist:

[ ] I updated project documentation to reflect my changes.
[ ] My changes generate no new warnings.
[ ] I updated new and existing unit tests to account for my changes.
[ ] I linked the associated item(s) to be closed.
[ ] I bumped the version.
[ ] I added the labels corresponding to my changes.

Looks like something is happening incorrectly for the sorting of when requirements are encountered within a scenario and not top level feature assignment.
If you run the gen-gherkin-behaviors command on the calculator.yaml file, mathmessagehandler_api_feature_file output has the requirement for SQRT-2 put with the first scenario vs the second like it is assigned within the mathmessagehandler.yaml definition file.

Remember to utilize the PR checklist, have some things missing for this PR.


OWASP Dependency Check - False Positive for v.2.0.1

FP Report: https://github.com/jeremylong/DependencyCheck/issues/6385
Suppression
<suppress base="true">
   <notes><![CDATA[
   FP per issue #6385
   ]]></notes>
   <packageUrl<EMAIL_ADDRESS>   <cpe>cpe:/a:file:file</cpe>
</suppress>

Link to test results: https://github.com/jeremylong/DependencyCheck/actions/runs/7490798572
See: https://jeremylong.github.io/DependencyCheck/general/suppression.html

on Apr 13 Suppress rule has been added to the generatedSuppressions branch.


make ArborX::Ray compatible as a predicate for batched queries;

This is pr to make make ArborX::Ray working as a predicate for batched queries.
I ran into and then resolved an issue #435.

I would ask to expand the scope of this PR to include all instances of free form initializer lists in that test file. For example, as soon as one implements equals(Ray, Ray), things will not compile again.

I would ask to expand the scope of this PR to include all instances of free form initializer lists in that test file. For example, as soon as one implements equals(Ray, Ray), things will not compile again.

Could you suggest a grep keywords list to find all the instances?

Could you suggest a grep keywords list to find all the instances?


added total orders to asset details

Fixes #1510

Changes proposed in this PR:

added total orders value to asset details

waiting for updates in ocean.js

will work on some other placement somewhere as current implementation breaks easily with bigger numbers:

Also tending towards calling it "sales" in the UI which could still be explained further in info tooltip where we could explain what "order" means.

Maybe too early but this gives us some nice space to summarize in future whatever more key metrics about an asset we come up with, like "xxx sales by xxx different accounts." or so


Fix sandbox close in SDK tests

When SDK tests fail it seems that the sandboxes are not properly closed. There are still some (around 15) sandboxes running after the action ends. They are killed after some time by what could be the action runner timeout cleanup.

This is fixed on the beta branch.


Fix ui tests

Running ui tests locally produces these outputs, but never in CI.
I'm not sure why, but I will delete it anyway.
bors r+


Connect family member to patient

🚀 Feature Proposal
It's necessary to develop functionality that allow connecting a patient with a family member.
Example
Inside the patient record, it could be add the family member's information (TBD).

we need an option to be able to connect family parents siblings with the patient
View in Slack


[TextField] Allow custom colors in FormLabel

A continuation of: #26697. I have noticed this working on https://github.com/mui-org/material-ui-store/commit/c54f85d582c43326cb5aa45dd6262bc989f6368d#r53613823.
I have also noticed that ToggleButton wasn't handled but I'm not taking care of it.

I have also noticed that ToggleButton wasn't handled but I'm not taking care of it.

ToggleButton is already handled in this PR. https://github.com/mui-org/material-ui/pull/27046

ToggleButton was handled in this PR. #27046

@siriwatknp Not completely, this is on HEAD:
https://github.com/mui-org/material-ui/blob/d5943120c0a15d3953a81e83c5e5cc0f8667b610/packages/material-ui/src/ToggleButtonGroup/ToggleButtonGroup.js#L200


RDKTV-9392:org.rdk.Bluetooth auto-connect doesnot work properly

Reason for change: Changes for Auto-Connect
Test Procedure: Validating using Axi device
Risks: None
Signed-off-by: Tapaswini Padhy<EMAIL_ADDRESS>

Cleaning up older PRs. Please create new PR on latest sprint if required.


Face alignment speed up and GPU usage

To whom it may concern,
This repo provided really amazing tools. Thanks for the great work.
I tried face alignment, extract features by using this lib. I found the face alignment may cost 1.3s to process an image. After reading the code, I realized the mtcnn is not running on GPU. A a little bit changes were made, e.g., torch.FloatTensor => torch.cuda.FloatTensor, Pnet() =>Pnet().cuda(), etc.
This increased the face alignment speed per image from 1.3 to 0.8s. It works, however, the result does not make me satisfied. Is there a way to make the face detection/alignment run faster?
There is another thing make me confused. The GPU usage is very low, 1%~2%. Please see the attachments.

I'm not sure if this is due to I didn't configured the GPU properly or it is just one of the advantages of this library.
The installed CUDA version is 9.2, Cudnn version is 7.4. Graphic card is RTX 2070. It reports an error after I run the python code. Can anyone tell me how to fix it?

Again, many thanks for the great work!

@Wenlong0913 hello,I also want to improve the speed ,but there is poor promotion after using cuda. Have you find better method to accelerate?If so,can you please tell me?Thank you very much.

@Wenlong0913 hello,I also want to improve the speed ,but there is poor promotion after using cuda. Have you find better method to accelerate?If so,can you please tell me?Thank you very much.
Nope.
Perhaps you can try this implementation. It's faster.
https://github.com/Seanlinx/mtcnn

@Wenlong0913 I am facing the same problem. Could you give some hints on how much it is faster than this one? And do you think the key point of low gpu usage is mtcnn itself or in-efficient implementation? BTW. I am trying to find a way to modify mtcnn in this repo to improve speed.

Check out this fork: https://github.com/innerlee/face.evoLVe.PyTorch
Speed Comparison
original
In [1]: from PIL import Image
   ...: from detector import detect_faces

In [2]: img = Image.open('../disp/Fig1.png').convert('RGB')

In [3]: %time detect_faces(img)
CPU times: user 2.85 s, sys: 172 ms, total: 3.02 s
Wall time: 610 ms

the fork
In [1]: from PIL import Image

In [2]: from evolveface import detect_faces, show_results

In [3]: img = Image.open('disp/Fig1.png').convert('RGB')

In [4]: %time detect_faces(img)
CPU times: user 255 ms, sys: 6.05 ms, total: 261 ms
Wall time: 42.3 ms

@innerlee so it's all about pillow-simd?

There are lots of code optimization also

@innerlee Does it affect model performance?

Purely speed changes. The bottleneck is not model inference.

@innerlee I'm checking it out. Great work

@innerlee Hello, can u share what's the estimated time for training this repo using full dataset of Celeb-1M? I tried using 4 GPU but my estimated time is too long like 200 days for a single batch. I cannot believe it. After ten hours of training using only 1/3 of data, it's still at the first epoch with batch 1920/411750. Can u share ur training status? Thx

I use the provided weights for inference. Haven't tried training :shrug:

I also have this issue, I'm running the dataset on Tesla K80


Integration api

Summary
feat: added news endpoints ( /info & /cards )
Known Issues
none
Trello Card
https://trello.com/c/GpBRNMZb

bad PR


Question: own styles

EDIT: Please delete this issue. Everything works as expected. Sorry !!!!

Unfortunately, I don't know where to place my question, so I'll place it here once.
There is the possibility to define your own styles. Suppose I have generated a style "test.csl" and it is located in the same directory as my adoc-file.
The following code does not work:
= My first document using asciidoctor-bibliography
:bibliography-database: test.bib
:bibliography-style: test.csl

Compiling leads to:
asciidoctor: FAILED: C:/test/test.adoc: Failed to load AsciiDoc document - no CSL node: nil
How do I integrate these own styles?

No problem, @pddzaic. 😄
Thanks for using the gem. Feel free to let us know if you find any problems.


Update eslint dependency to 0.11.0

Thanks :)

There is already PR #19 that fixes this issue for all eslint versions 0.x

:+1:


Use pesudo terminals for debugger

This is merely a prototype using the VS Code pseudo terminals when debugging.
Alleviates problems such as:

Storing history in shell
Hiding commands used to launch debugger (e.g. cwd, env variables, python command, & other)

@int19h @karthiknadig /cc
Old

New

Details about the pseudo terminals can be found here https://code.visualstudio.com/updates/v1_37#_extension-terminals
Technical details

Debugger will send a custom message to VSC extension to launch the terminal instead of passing this to vsc (i.e. instead of runInTerminal, send runInTerminalExt

Extension will handle this event
Spawn the process with the required arguments
Create a pseudo terminal with the provided title, and hook up the input and output.
Output from stdout will be sent to pseudo terminal.

Challenges:

Handling keyboard interrupts (ctrl+esc)

Not supported, will need to file an issue upstream on VSC

Input will need to be sent to debug adapter via a custom request or similar.
When debugging ends, what do we do with the pseudo terminal? It isn't a real terminal. Guess we could leave it around. Leave it as a dedicated terminal for the debugger.

We'd rather have VS Code giving us a way to prevent adding command to shell history.


Error in getTEvents

It seems this error goes all the way back to the code provided in the book.  Really appreciate you making your examples available.
sNeg is off by a minus sign causing it to be reset to 0 every loop.  sNeg<-h  is never executed.  Events are only being triggered on the positive side (sPos>h).  Subtracting diff.loc[i] seems to be the easiest fix but you might prefer a different way.

Upon closer inspection I'm incorrect about where the error is.  The issue is actually the .abs() in diff = np.log(gRaw).diff().dropna().abs().  Taking the absolute value means only positive values are accumulated and sNeg never accumulates any value while sPos is always counting up regardless of whether the difference is positive or negative.
While plotting the values I also spotted a separate issue.  The daily volatility mean is being used as an input:  tEvents = getTEvents(close,h=dailyVol.mean()).  This is a definite issue with 'peeping into the future' as the .mean() would never be known until the very end.  Maybe we should consider using a rolling window with some number of previous daily volatilities (and not the current day).

Hi @tmorgan4,
Thanks for the insightful feedback and correction. Before I merge the pull request, I think it would be very instructive for others (including me), if you could demonstrate the differences in output between the old version and the fixed version using a notebook; especially the effect it has on the labeling exercises. If/when you provide that I'd be happy to merge your pull request including the notebook demo.
Also good catch on the leakage. A rolling window could work, I'll have to think on it a little bit more when I have some time.

I'd be happy to put together some documentation on the changes. Give me a day or so and I'll get it posted.

@BlackArbsCEO I apologize for the delay on getting the notebooks added. I spent a few days trying to get everything working on my work PC and eventually gave up. It works much smoother on my mac but it means I need to work from home. I should be able to get it put together this week.

@tmorgan4 if your work PC happens to be windows, I found that Cell 23 can be modified to utilize the following platform check to run in single-threaded mode:
import platform
if platform.system() == "Windows":
    cpus = 1
else:
    cpus = cpu_count() - 1


v0.8.0: prep docs and references

Signed-off-by: hasheddan<EMAIL_ADDRESS>
Description of your changes

Updates references and docs to point to new versions of Crossplane and stacks.
How has this code been tested?

n/a
Checklist

I have:

[x] Run make reviewable to ensure this PR is ready for review.
[x] Ensured this PR contains a neat, self documenting set of commits.
[x] Updated any relevant documentation and examples.
[ ] Reported all new error conditions into the log or as an event, as
appropriate.

For more about what we believe makes a pull request complete, see our
definition of done.

haha apparently i can approve a PR more than once 🤔


TypeError: init() takes from 1 to 2 positional arguments but 3 were given

Hello,
I had a custom search command working with the python2 version of splunklib. I moved now to python3 and I have this error:
01-20-2023 16:07:54.435 INFO  ChunkedExternProcessor - Running process: /opt/splunk/bin/python3.7 /opt/splunk/etc/apps/cdc_ipam_exp/bin/ipamextr.py
01-20-2023 16:07:54.530 ERROR ChunkedExternProcessor - stderr: Traceback (most recent call last):
01-20-2023 16:07:54.530 ERROR ChunkedExternProcessor - stderr:   File "/opt/splunk/etc/apps/cdc_ipam_exp/bin/ipamextr.py", line 11, in <module>
01-20-2023 16:07:54.530 ERROR ChunkedExternProcessor - stderr:     from splunklib.searchcommands import \
01-20-2023 16:07:54.530 ERROR ChunkedExternProcessor - stderr:   File "/opt/splunk/etc/apps/cdc_ipam_exp/bin/../lib/splunklib/searchcommands/__init__.py", line 149, in <module>
01-20-2023 16:07:54.530 ERROR ChunkedExternProcessor - stderr:     from .environment import *
01-20-2023 16:07:54.530 ERROR ChunkedExternProcessor - stderr:   File "/opt/splunk/etc/apps/cdc_ipam_exp/bin/../lib/splunklib/searchcommands/environment.py", line 120, in <module>
01-20-2023 16:07:54.530 ERROR ChunkedExternProcessor - stderr:     splunklib_logger, logging_configuration = configure_logging('splunklib')
01-20-2023 16:07:54.530 ERROR ChunkedExternProcessor - stderr:   File "/opt/splunk/etc/apps/cdc_ipam_exp/bin/../lib/splunklib/searchcommands/environment.py", line 103, in configure_logging
01-20-2023 16:07:54.530 ERROR ChunkedExternProcessor - stderr:     fileConfig(filename, {'SPLUNK_HOME': splunk_home})
01-20-2023 16:07:54.530 ERROR ChunkedExternProcessor - stderr:   File "/opt/splunk/lib/python3.7/logging/config.py", line 79, in fileConfig
01-20-2023 16:07:54.530 ERROR ChunkedExternProcessor - stderr:     handlers = _install_handlers(cp, formatters)
01-20-2023 16:07:54.530 ERROR ChunkedExternProcessor - stderr:   File "/opt/splunk/lib/python3.7/logging/config.py", line 145, in _install_handlers
01-20-2023 16:07:54.530 ERROR ChunkedExternProcessor - stderr:     h = klass(*args, **kwargs)
01-20-2023 16:07:54.530 ERROR ChunkedExternProcessor - stderr: TypeError: __init__() takes from 1 to 2 positional arguments but 3 were given

I'm running Splunk 8.1.12 (under Linux) and I am using the latest SDK 1.7.2
My env python is 3.8
The script I am using is:
#!/usr/bin/env python

import sys,os

sys.path.insert(0, os.path.join(os.path.dirname(__file__), "..", "lib"))
import time
import csv
from ipaddress import ip_address, IPv4Network

from ipam_api import API as IpamApi
from splunklib.searchcommands import \
        dispatch, GeneratingCommand, Configuration, Option, validators

@Configuration()
class IPAMExtrCommand(GeneratingCommand):

        def generate(self):
                api = IpamApi("https://ipam3/")
                views = api.get_view_list()

                for view in views:
                        nv = view['name']
                        if nv != 'default':
                                with api.csv_export('network', network_view=nv, stream=True) as r:
                                        f = (line.decode('utf-8') for line in r.iter_lines())
                                        reader = csv.DictReader(f)
                                        prefix = reader.fieldnames[0]
                                        for row in reader:
                                                dictout = { '_time': time.strftime("%Y-%m-%d") }
                                                if not 'address*' in row.keys():
                                                        continue
                                                del row[prefix]
                                                cidr_i= IPv4Network(row['address*']+'/'+row['netmask*']).prefixlen
                                                net32= { 'network_32': int(ip_address(row['address*'])) }
                                                cidr= { 'cidr': cidr_i }
                                                subnet= { 'subnet': row['address*']+ '/' + str(cidr_i) }
                                                dictout.update(row)
                                                dictout.update(net32)
                                                dictout.update(subnet)
                                                dictout.update(cidr)
                                                yield dictout

dispatch(IPAMExtrCommand, sys.argv, sys.stdin, sys.stdout, __name__)

Please can you help me to fix this?
thanks,
Fausto

Hi @akaila-splunk, yesterday I found the cause for this error. In my logging.conf I had an entry for "splunklib". That logging.conf was working in the past, with an older splunklib SDK. So I removed the entries below and the error disappeared.
[logger_splunklib]
qualname = splunklib
level = NOTSET
handlers = splunklib
propagate = 0

[handler_splunklib]
# Select this handler to log events to $SPLUNK_HOME/var/log/splunk/splunklib.log
class = logging.handlers.RotatingFileHandler
args = ('/opt/splunk/var/log/splunk/splunklib.log', 'a', 524288000, 9, 'utf-8', True)
level = NOTSET
formatter = searchcommands


Add filtering of examples to webpack config

Codecov Report

Merging #1396 into master will not change coverage by %.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #1396   +/-   ##
=======================================
  Coverage   54.85%   54.85%
=======================================
  Files         255      255
  Lines       23473    23473
  Branches     5275     5275
=======================================
  Hits        12875    12875
  Misses      10598    10598

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3b930fd...0c3f97b. Read the comment docs.


Support prometheus scratching for control plane which disables anonymous-auth

bearerTokenFile will be used to authenticate apiserver and kubelet. Since prometheus-k8s already support to get nonResourceUrls /metrics, authorization will work as well.
Signed-off-by: Jiaxin Shan<EMAIL_ADDRESS>What type of PR is this?
/kind feature
What this PR does / why we need it:
control plane which disables anonymous-auth will fail the prometheus scratching requests to secure port. Adding bearerTokenFile to the configuration helps prometheus send request with prometheus service account token.
Which issue(s) this PR fixes:

Fixes #1721
Special notes for your reviewer:
Does this PR introduce a user-facing change?:

NONE

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

I believe the master branch also lacks this functionality. A standard way of adding it would be to start with the master branch and then backport to release branches. Starting with master is safer as we have presubmits there.

@mm4tt sounds good. I will submit a new one against master. Thanks

Close this one, I create https://github.com/kubernetes/perf-tests/pull/1722 against master instead. Once it's approved, it will be cherry-picked back to existing versions


Update Teams-add-in-for-Outlook.md

Need to add hard requirement for supported Exchange mailbox for the user trying to schedule the Teams Meeting with the add-in.  I don't know how to add the doc link in-line, so I just pasted the public URL, please fix that;

@JohanFreelancer9 Copy editing is needed for this PR. Thanks.

@LanaChin PR has been copyedited and is ready for final review, could you please check and merge? Thanks!


query null check issue

query null check issue to InboundSms.cs
#hacktoberfest

Hi @onpoc - thanks for opening this PR - can you relate this to a particular issue? If it's something you're seeing - feel free to open an Issue

Codecov Report

Merging #228 into master will decrease coverage by 0.00%.
The diff coverage is 80.00%.

@@            Coverage Diff             @@
##           master     #228      +/-   ##
==========================================
- Coverage   89.89%   89.89%   -0.01%
==========================================
  Files         385      385
  Lines       11304    11307       +3
  Branches     1100     1101       +1
==========================================
+ Hits        10162    10164       +2
  Misses        968      968
- Partials      174      175       +1

Impacted Files
Coverage Δ

Vonage/LegacyNexmoLibrary/Messaging/InboundSms.cs
91.83% <80.00%> (-1.65%)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 69a6e1b...38f2a79. Read the comment docs.

Thanks for your valuable comments and coverage reports.
Since I raised pull request to avoid null risk, and after null check will have to update relevant unit test code as well. This way code coverage will have no impact and enhance code too.
If feel, changes are right to enhance COQ (Code of Quality) then can merge.

Thanks for your valuable comments and coverage reports.
Since I raised pull request to avoid null risk, and after null check will have to update relevant unit test code as well. This way code coverage will have no impact and enhance code too.
If feel, changes are right to enhance COQ (Code of Quality) then can merge.


Adding no overwrite and local only options to the pod repo push command

Checklist

[x] I've run bundle exec rspec from the root directory to see all new and existing tests pass
[x] I've followed the fastlane code style and run bundle exec rubocop -a to ensure the code style is valid
[x] I've read the Contribution Guidelines
[x] I've updated the documentation if necessary.

Motivation and Context
The PR adds new parameters to the Cocoapods command pod repo push that were missing from the Fastlane action but were present on the Cocoapods command.
Description
Two new options are being added to the pod repo push command:
no_overwrite, which disallows pushing a spec that would overwrite an existing one
local_only, which skips the step of pushing to its remote, basically acting like a dry run.
Testing Steps
I've follow the rules found on https://github.com/fastlane/fastlane/blob/master/Testing.md. I've also tested the command locally, and found no issues.

Hey
Is there anything missing from my pull request?

Looks great, thanks for the PR!


labstack/echo dependency is vulnerable

❯ go mod why -m github.com/labstack/echo
# github.com/labstack/echo
...
github.com/UnnoTed/fileb0x
github.com/labstack/echo

Warning:(178, 2)  Dependency go:github.com/labstack/echo:v3.2.1+incompatible is vulnerable, safe version v3.3.6+incompatible CVE-2022-40083 9.6 URL Redirection to Untrusted Site ('Open Redirect') vulnerability with high severity found   Results powered by Checkmarx(c)

https://github.com/advisories/GHSA-crxj-hrmp-4rwf

Fix open redirect vulnerability in handlers serving static directories (e.Static, e.StaticFs, echo.StaticDirectoryHandler)

None of those are used in fileb0x because when the Updater option is enabled (which makes use of echo) it creates a GET endpoint "/" that requires a basic auth to access and serves a list of file names and sha256 hash.
https://github.com/UnnoTed/fileb0x/blob/master/template/files.go#L293
Quote from the README section "Update files remotely":

How it works?
By enabling the updater option, the next time that you generate a b0x, it will include a http server, this http server will use a http basic auth and it contains 1 endpoint / that accepts 2 methods: GET, POST.
The GET method responds with a list of file names and sha256 hash of each file. The POST method is used to upload files, it creates the directory tree of a new file and then creates the file or it updates an existing file from the virtual memory file system... it responds with a ok string when the upload is successful.


[W07H03] Added canEat tests that checks if instanceof has been used and added move method tests

lgtm


Stack overflow when using Django Debug Toolbar 1.8 (works fine in 1.7)

Good afternoon, I'm getting a stack overflow error when I try to use DJDT 1.8 on routes served by the Wagtail CMS. The same routes / pages work with DJDT 1.7. I'm running Django 1.11.2 and Wagtail 1.10.1. Here's the trace:
Fatal Python error: Cannot recover from stack overflow.

Current thread 0x00007f5d3f7f8700 (most recent call first):
  File "/venv-path/django/utils/functional.py", line 215 in wrapper
  File "/venv-path/django/template/base.py", line 835 in __init__
  File "/venv-path/django/template/base.py", line 685 in __init__
  File "/venv-path/django/template/base.py", line 600 in compile_filter
  File "/venv-path/django/template/defaulttags.py", line 826 in do_for
  File "/venv-path/django/template/base.py", line 513 in parse
  File "/venv-path/django/template/base.py", line 230 in compile_nodelist
  File "/venv-path/django/template/base.py", line 191 in __init__
  File "/venv-path/django/template/loaders/base.py", line 44 in get_template
  File "/venv-path/django/template/engine.py", line 136 in find_template
  File "/venv-path/django/template/engine.py", line 162 in get_template
  File "/venv-path/django/template/backends/django.py", line 39 in get_template
  File "/venv-path/django/template/loader.py", line 21 in get_template
  File "/venv-path/django/template/loader.py", line 67 in render_to_string
  File "/venv-path/wagtail/wagtailcore/blocks/base.py", line 259 in render
  File "/venv-path/wagtail/wagtailcore/blocks/stream_block.py", line 377 in __html__
  File "/venv-path/wagtail/wagtailcore/blocks/stream_block.py", line 380 in __str__
  File "/venv-path/django/utils/encoding.py", line 76 in force_text
  File "/venv-path/debug_toolbar/panels/templates/panel.py", line 128 in _store_template_info
  File "/venv-path/django/dispatch/dispatcher.py", line 193 in <listcomp>
  File "/venv-path/django/dispatch/dispatcher.py", line 193 in send
  File "/venv-path/django/test/utils.py", line 106 in instrumented_test_render
  File "/venv-path/django/template/base.py", line 207 in render
  File "/venv-path/django/template/backends/django.py", line 66 in render
  File "/venv-path/django/template/loader.py", line 68 in render_to_string
  File "/venv-path/wagtail/wagtailcore/blocks/base.py", line 259 in render
  File "/venv-path/wagtail/wagtailcore/blocks/stream_block.py", line 377 in __html__
  File "/venv-path/wagtail/wagtailcore/blocks/stream_block.py", line 380 in __str__
  File "/venv-path/django/utils/encoding.py", line 76 in force_text
  File "/venv-path/debug_toolbar/panels/templates/panel.py", line 128 in _store_template_info
  File "/venv-path/django/dispatch/dispatcher.py", line 193 in <listcomp>
  File "/venv-path/django/dispatch/dispatcher.py", line 193 in send
  File "/venv-path/django/test/utils.py", line 106 in instrumented_test_render
  File "/venv-path/django/template/base.py", line 207 in render
  File "/venv-path/django/template/backends/django.py", line 66 in render
  File "/venv-path/django/template/loader.py", line 68 in render_to_string
  File "/venv-path/wagtail/wagtailcore/blocks/base.py", line 259 in render
  File "/venv-path/wagtail/wagtailcore/blocks/stream_block.py", line 377 in __html__
  File "/venv-path/wagtail/wagtailcore/blocks/stream_block.py", line 380 in __str__
  File "/venv-path/django/utils/encoding.py", line 76 in force_text
  File "/venv-path/debug_toolbar/panels/templates/panel.py", line 128 in _store_template_info
  File "/venv-path/django/dispatch/dispatcher.py", line 193 in <listcomp>
  File "/venv-path/django/dispatch/dispatcher.py", line 193 in send
  File "/venv-path/django/test/utils.py", line 106 in instrumented_test_render
  File "/venv-path/django/template/base.py", line 207 in render
  File "/venv-path/django/template/backends/django.py", line 66 in render
  File "/venv-path/django/template/loader.py", line 68 in render_to_string
  File "/venv-path/wagtail/wagtailcore/blocks/base.py", line 259 in render
  File "/venv-path/wagtail/wagtailcore/blocks/stream_block.py", line 377 in __html__
  File "/venv-path/wagtail/wagtailcore/blocks/stream_block.py", line 380 in __str__
  File "/venv-path/django/utils/encoding.py", line 76 in force_text
  File "/venv-path/debug_toolbar/panels/templates/panel.py", line 128 in _store_template_info
  File "/venv-path/django/dispatch/dispatcher.py", line 193 in <listcomp>
  File "/venv-path/django/dispatch/dispatcher.py", line 193 in send
  File "/venv-path/django/test/utils.py", line 106 in instrumented_test_render
  File "/venv-path/django/template/base.py", line 207 in render
  File "/venv-path/django/template/backends/django.py", line 66 in render
  File "/venv-path/django/template/loader.py", line 68 in render_to_string
  File "/venv-path/wagtail/wagtailcore/blocks/base.py", line 259 in render
  File "/venv-path/wagtail/wagtailcore/blocks/stream_block.py", line 377 in __html__
  File "/venv-path/wagtail/wagtailcore/blocks/stream_block.py", line 380 in __str__
  File "/venv-path/django/utils/encoding.py", line 76 in force_text
  File "/venv-path/debug_toolbar/panels/templates/panel.py", line 128 in _store_template_info
  File "/venv-path/django/dispatch/dispatcher.py", line 193 in <listcomp>
  File "/venv-path/django/dispatch/dispatcher.py", line 193 in send
  File "/venv-path/django/test/utils.py", line 106 in instrumented_test_render
  File "/venv-path/django/template/base.py", line 207 in render
  File "/venv-path/django/template/backends/django.py", line 66 in render
  File "/venv-path/django/template/loader.py", line 68 in render_to_string
  File "/venv-path/wagtail/wagtailcore/blocks/base.py", line 259 in render
  File "/venv-path/wagtail/wagtailcore/blocks/stream_block.py", line 377 in __html__
  File "/venv-path/wagtail/wagtailcore/blocks/stream_block.py", line 380 in __str__
  File "/venv-path/django/utils/encoding.py", line 76 in force_text
  File "/venv-path/debug_toolbar/panels/templates/panel.py", line 128 in _store_template_info
  File "/venv-path/django/dispatch/dispatcher.py", line 193 in <listcomp>
  File "/venv-path/django/dispatch/dispatcher.py", line 193 in send
  File "/venv-path/django/test/utils.py", line 106 in instrumented_test_render
  File "/venv-path/django/template/base.py", line 207 in render
  File "/venv-path/django/template/backends/django.py", line 66 in render
  File "/venv-path/django/template/loader.py", line 68 in render_to_string
  File "/venv-path/wagtail/wagtailcore/blocks/base.py", line 259 in render
  File "/venv-path/wagtail/wagtailcore/blocks/stream_block.py", line 377 in __html__
  File "/venv-path/wagtail/wagtailcore/blocks/stream_block.py", line 380 in __str__
  File "/venv-path/django/utils/encoding.py", line 76 in force_text
  File "/venv-path/debug_toolbar/panels/templates/panel.py", line 128 in _store_template_info
  File "/venv-path/django/dispatch/dispatcher.py", line 193 in <listcomp>
  File "/venv-path/django/dispatch/dispatcher.py", line 193 in send
  File "/venv-path/django/test/utils.py", line 106 in instrumented_test_render
  File "/venv-path/django/template/base.py", line 207 in render
  File "/venv-path/django/template/backends/django.py", line 66 in render
  File "/venv-path/django/template/loader.py", line 68 in render_to_string
  File "/venv-path/wagtail/wagtailcore/blocks/base.py", line 259 in render
  File "/venv-path/wagtail/wagtailcore/blocks/stream_block.py", line 377 in __html__
  File "/venv-path/wagtail/wagtailcore/blocks/stream_block.py", line 380 in __str__
  File "/venv-path/django/utils/encoding.py", line 76 in force_text
  File "/venv-path/debug_toolbar/panels/templates/panel.py", line 128 in _store_template_info
  File "/venv-path/django/dispatch/dispatcher.py", line 193 in <listcomp>
  File "/venv-path/django/dispatch/dispatcher.py", line 193 in send
  File "/venv-path/django/test/utils.py", line 106 in instrumented_test_render
  File "/venv-path/django/template/base.py", line 207 in render
  ...

Thread 0x00007f5d4bcb3700 (most recent call first):
  File "/usr/lib64/python3.5/selectors.py", line 376 in select
  File "/usr/lib64/python3.5/socketserver.py", line 232 in serve_forever
  File "/venv-path/django/core/servers/basehttp.py", line 174 in run
  File "/venv-path/django/core/management/commands/runserver.py", line 149 in inner_run
  File "/venv-path/django/utils/autoreload.py", line 227 in wrapper

Thread 0x00007f5d61887740 (most recent call first):
  File "/venv-path/django/utils/autoreload.py", line 281 in reloader_thread
  File "/venv-path/django/utils/autoreload.py", line 298 in python_reloader
  File "/venv-path/django/utils/autoreload.py", line 332 in main
  File "/venv-path/django/core/management/commands/runserver.py", line 110 in run
  File "/venv-path/django/core/management/commands/runserver.py", line 101 in handle
  File "/venv-path/django/core/management/base.py", line 330 in execute
  File "/venv-path/django/core/management/commands/runserver.py", line 62 in execute
  File "/venv-path/django/core/management/base.py", line 283 in run_from_argv
  File "/venv-path/django/core/management/__init__.py", line 355 in execute
  File "/venv-path/django/core/management/__init__.py", line 363 in execute_from_command_line
  File "manage.py", line 15 in <module>
Aborted

I'm fine with running 1.7 for now, but am at a loss with where to start digging into this issue. Any ideas, advice, or hopefully solutions? Thanks in advance.

I can confirm the same problem when using DDT 1.8 with Django 1.8.

I've seen the same issue--it was triggered for me when using a StreamField block that specified a template.  Adding that template to the SKIP_TEMPLATE_PREFIXES debug toolbar config was a workaround.  As I recall (though it was some time ago), the root issue was that the block object renders a template in its __str__ method, which led to infinite recursion in the TEMPLATES panel of the debug toolbar.

@gasman I thought you might want to have a look at this issue.

Possibly related to https://github.com/wagtail/wagtail/issues/2874...?

I've experienced the same thing with DDT 1.8, Django 1.11.2 and Wagtail 1.10.1.
Reproduced it with Python 3.6, 3.6.1 and 3.7a
After some investigation, there is an infinite loop created in panels.py:128, in Wagtail's case the value here can be a StructValue which string representation is actually a template rendering which triggers a signal template_rendered.

I've monkey-patched it to get it working for those using Wagtail. The patch is here:
https://github.com/FlipperPA/django-debug-toolbar/commit/e68cfa509566bf5332c37f03c0fd9753a873d491
I don't expect this should be a P.R., since it is Wagtail specific.

Another hotfix for this is to exclude templates used by StructBlock from debug toolbar. E.g.
class MyStructBlock(StructBlock):
    ...
    class Meta:
        ...
        template = 'myblocks/structblock.html'

And add to settings.py file:
DEBUG_TOOLBAR_CONFIG = {
    'SKIP_TEMPLATE_PREFIXES': ('django/forms/widgets/', 'admin/widgets/', 'myblocks/structblock.html'),
}

From DDT doc for SKIP_TEMPLATE_PREFIXES:

Templates starting with those strings are skipped when collecting rendered templates and contexts. Template-based form widgets are skipped by default because the panel HTML can easily grow to hundreds of megabytes with many form fields and many options.

Works for me.

We had this issue with Django Debug Toolbar 1.8 and django-floppyforms and fixed this problem in a similar way:
DEBUG_TOOLBAR_CONFIG = {
    'SKIP_TEMPLATE_PREFIXES': (
        'django/forms/widgets/',
        'admin/widgets/',
        'floppyforms/'
    ),
    'DISABLE_PANELS': {
        'debug_toolbar.panels.redirects.RedirectsPanel',
        'debug_toolbar.panels.redirects.TemplatesPanel'
    },
}

We also decided to disable the TemplatesPanel by default because it was slowing the page heavily. Page loads were three times as slow in comparison with Django Debug Toolbar 1.7.

Fixed in https://github.com/wagtail/wagtail/pull/3738 - I think this can be closed, as it's a Wagtail issue.

Thanks @gasman!

Also affects django-el-pagination==3.1.0, adding 'el_pagination/', to SKIP_TEMPLATE_PREFIXES helps.


line 2, in      from PIL import Image ModuleNotFoundError: No module named 'PIL'

This is not an issue of the script. Please install the correct python dependences, read the README.md or refer to the official python docs.


Run source code through tool to achieve consistent formatting

We need to: evaluate tool to format code and if there is one that suits the needs - integrate it into this repository.

Implemented.


63 add home view

Closes #63

Codecov Report

Merging #64 (144a05f) into release-candidate (ffc8e95) will not change coverage.
The diff coverage is n/a.

@@                 Coverage Diff                 @@
##           release-candidate       #64   +/-   ##
===================================================
  Coverage             100.00%   100.00%
===================================================
  Files                     53        53
  Lines                   1285      1280    -5
===================================================
- Hits                    1285      1280    -5

Impacted Files
Coverage Δ

...YugiAcademy/YuGiOh/cards/card_management_system.py
100.00% <0.00%> (ø)

...Oh/booster_packs/booster_pack_management_system.py
100.00% <0.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.


e2e test check for files exist does not run

Describe the bug
File index.test.ts line 28 method toBeTruthy is not called to check if optimized files exists.
Expected behavior
Test runs and checks for existing optimized images.

Thanks!