A question about Datasets

Hello author, thank you for providing the project code. But I would like to ask you, how should I prepare the data set before training the model

Up

same question
MVTech need to set train file?

@ztk985 @roberto722
I'm sorry too late.
You can download MVTecAD datasets in here.

@jamdodot
Yes.
If you want to train a model for bottle class, you need to set the target as bottle.
python main.py --yaml_config ./configs.yaml DATASET.target capsule

@jamdodot
Yes. If you want to train a model for bottle class, you need to set the target as bottle.
python main.py --yaml_config ./configs.yaml DATASET.target capsule

I also want to ask [example] model overview.ipynb. Is this file the inference process? Is it using a trained model?

@jamdodot
[example] model overview.ipynb is a tutorial example for one batch of training dataset.
The purpose of the notebook file is to check the process of the MemSeg.


bugfix: Recursively extracts text from a pdfminer layout object

The high-resolution mode of the partitioned PDF merges layouts extracted by pdfminer with those identified by a deep layout recognition model. During testing, I encountered issues with certain PDF files, such as the one attached below.
test_pdfminer_text_extraction.pdf
Upon debugging, I discovered that the problem stemmed from the layout extraction phase performed by pdfminer. For the first page of the PDF, pdfminer extracted two layout objects: one containing a few words, and another categorized as an ImageTextRegion with a None text attribute. Note that the bounding box of this ImageTextRegion nearly matches the entire page's bounding box.
The merge_inferred_with_extracted_layout function compares each extracted layout with the inferred layout. Despite the deep layout recognition model accurately predicting the correct layout, the merging rules prioritize the layout objects provided by pdfminer. As a result, since all inferred layouts fall within the bounding box of the large ImageTextRegion, the merge rules retain the ImageTextRegion and discard the inferred layouts. This approach is generally reasonable, as pdfminer is typically more reliable than deep layout and OCR models.
However, in this instance, pdfminer produced incorrect results. The ImageTextRegion contains embedded text elements, but it is classified merely as an image with no text. This issue can be attributed to the flawed design of the PDF itself. Nonetheless, it would be beneficial for our system to handle such cases more gracefully.
Since I am not very familiar with the unstructured source code, the temporary solution I came up with is to recursively extract text from pdfminer objects that are identified as having no text. If no text is found, the outcome remains unchanged. However, if sub text objects are discovered within, the merge rules will prioritize retaining the pdfminer extracted results, ultimately leading to the correct outcome.
Here are some extraction results for your reference.

page1_layout_pdfminer

page1_layout_od_model

page1_layout_final

Hi @Fleandre,
Thank you for your contribution and for bringing this issue to our attention. Your PR, including the sample document, has been incredibly helpful in identifying and reproducing this problem.
I believe I understand your ultimate goal: to preserve inferred elements (generated by the object detection model) within larger embedded image elements (generated by pdfminer) in the final output.
While your PR attempts to address this by filling in the text of the larger embedded image element with text from inner embedded text elements, I've realized that this approach might not fully resolve the issue as intended.
To address this more comprehensively, I've created a separate PR that I believe will better solve the problem you've identified. You can find it here: https://github.com/Unstructured-IO/unstructured/pull/3456
I'd love to hear your thoughts on this alternative approach. Your input has been valuable in driving this improvement, and I appreciate your contribution to making our system more robust.
Let me know if you have any questions or if you'd like to discuss this further.

Great! Your solution far surpasses mine, offering a better approach to tackling this issue. I'll be closing this pull request and proceeding with your implementation.

Great! Your solution far surpasses mine, offering a better approach to tackling this issue. I'll be closing this pull request and proceeding with your implementation. @christinestraub


PyUp Integration / Updates to CI integration

Codecov Report

:exclamation: No coverage uploaded for pull request base (master@102774e). Click here to learn what that means.
The diff coverage is n/a.

@@            Coverage Diff            @@
##             master       #7   +/-   ##
=========================================
  Coverage          ?   85.33%
=========================================
  Files             ?        2
  Lines             ?       75
  Branches          ?       14
=========================================
  Hits              ?       64
  Misses            ?        9
  Partials          ?        2

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 102774e...763dc46. Read the comment docs.


[NuGet.org Bug]: Broken link "Read more" in warning

Impact
It bothers me. A fix would be nice
Describe the bug
After just uploading the snupkg symbol file for my package I got the (correct) message:
The symbols for this package have not been indexed yet. They are not available for download from the
NuGet.org symbol server. Symbols will be available for download after both validation and indexing are complete.
Symbols validation and indexing may take up to an hour. [Read more](https://aka.ms/NuGetSymbolsPackageValidation).

However, the "Read more" link does not work and just loads a Bing search page. This is the link URL: https://aka.ms/NuGetSymbolsPackageValidation
Repro Steps

Upload package (nupkg)
Upload symbols (snupkg)
Click the "Read more" link in the warning

Expected Behavior
Some site explaining the wait should open, instead of a standard Bing search page.
Screenshots
No response
Additional Context and logs
No response

Very strangely, this link appears to be working for me. However, I do know that aka.ms redirects to Bing for non-existent names. Could you try that URL with cURL/httpie/Invoke-WebRequest?
PS C:\Users\jver> http GET https://aka.ms/NuGetSymbolsPackageValidation -v
GET /NuGetSymbolsPackageValidation HTTP/1.1
Accept: */*
Accept-Encoding: gzip, deflate
Connection: keep-alive
Host: aka.ms
User-Agent: HTTPie/3.0.2

HTTP/1.1 301 Moved Permanently
Cache-Control: max-age=0, no-cache, no-store
Connection: keep-alive
Content-Length: 0
Date: Mon, 22 Aug 2022 21:29:58 GMT
Expires: Mon, 22 Aug 2022 21:29:58 GMT
Location: https://docs.microsoft.com/nuget/create-packages/symbol-packages-snupkg#nugetorg-symbol-server
Pragma: no-cache
Request-Context: appId=cid-v1:7d63747b-487e-492a-872d-762362f77974
Server: Kestrel
Strict-Transport-Security: max-age=31536000 ; includeSubDomains
X-Response-Cache-Status: True

I tried again, and this time it worked. I investigated a bit. This time aka.ms resolved to <IP_ADDRESS> (which works).

HTTP request sent, awaiting response... 302 Moved Temporarily
Location: https://www.bing.com?ref=aka&shorturl=NuGetSymbolsPackageValidation [following]
--2022-08-23 00:23:57--  https://www.bing.com/?ref=aka&shorturl=NuGetSymbolsPackageValidation
Resolving www.bing.com (www.bing.com)... 2620:1ec:c11::200, <IP_ADDRESS>, <IP_ADDRESS>
Connecting to www.bing.com (www.bing.com)|2620:1ec:c11::200|:443... connected.
HTTP request sent, awaiting response... 200 OK
Length: unspecified [text/html]

I am in the Netherlands, where it most of the times resolves to European server. That leads to Bing.
Must be a (mis)synchronization thingy.

This seems like a bug with aka.ms itself. This service is outside of my team's scope but I will try to pass this information along and find a proper owner. Thank you so much for the additional information and debugging!

Feel free to close this when it's out of your control.

I've opened an internal ticket with the appropriate team. I'll leave this issue open for the next week or so for tracking purposes. Thanks again.

Hey @dorssel, could you try to reproduce the problem again? I took some steps prescribed by our internal partner team which should fix the problem. It looks like there was a clean-up procedure which make this link inactive due to some unexpected settings but that should be fixed now.

Yep, looks good.


1 refactor logger code

Added new logger, parameter checking, client.
Added download tool.
Refactor modules after discussion with JW.
Fixed and re-ran notebooks.
Completes the following as well.

https://github.com/casangi/graphviper/issues/3
https://github.com/casangi/graphviper/issues/2

This is just waiting on a ticket to get space on the aoc cluster and a slurm test.

Changing this from draft to actual pull request. As per yesterdays discussion, slurm work will take more time and be added to another ticket.


Revert thrift to 0.13.0

Closes #34

Seems that this is not an issue with 0.13.0.
Should it be posted as an issue at apache/thrift?

Running the tutorial mass-spring-damper case also for over 40 000 seconds with no crash issues.
Crash was consistently reproducible at slightly above 18 000 seconds with thrift 0.14. LGTM.


Multiple copies of the same WebAssembly binary created when building

Environment

Operating System: Linux
Node Version:     v18.13.0
Nuxt Version:     3.6.3
Nitro Version:    2.5.2
Package Manager<EMAIL_ADDRESS>Builder:          vite
User Config:      devtools, css, build, vite, app
Runtime Modules:  -
Build Modules:    -

Reproduction
Minimal Reproduction
Instructions to reproduce issue:

Build the application for production
npm run build
Observe 2 instances of the same wasm file being added to the dist directory with 2 seperate names.

ℹ vite v4.4.9 building for production...
ℹ ✓ 97 modules transformed.
...
ℹ .nuxt/dist/client/_nuxt/test.45b7855d.wasm
ℹ .nuxt/dist/client/_nuxt/test-45b7855d.wasm

Describe the bug
When using the same WebAssembly file (.wasm) on the main thread and within a worker, Nuxt will save 2 copies of the .wasm file upon building.

Details/Example
testModule.ts and test.worker.ts both use and thus instantiate the .wasm file.

testModule.ts is used for short tasks that won't lead to the website freezing
test.worker.ts is used for thousands of short tasks or one large task that have to put in a worker in order to prevent freezing

app.vue imports and uses both of these depending on what the user is doing.
On compiling, Nuxt saves separate copies of the .wasm file for testModule.ts and test.worker.ts

This is problematic due to .wasm files typically being fairly large, so it would be ideal to only save one copy of them for distribution.
Additional context
No response
Logs
No response

/cc @antfu Do you have any idea why?


Added --advertise-address "awslocal"

Add support --advertise-address "awslocal".
This can be used to automatically detect AWS instance local host IP addresses, within an AWS host / ECS cluster.
A local host IP is useful, as users may have different security address or host binding for local IP's, and external IP's for security reasons.
Also added more details into help documentation command.
The sister issue posted is : #7343

@PicoCreator Thanks!


add support to import rename

Expressions such as import stuff.{member => renamedMember} were
not understood by macwire, which was incorrectly using member rather
than renamedMember.

This PR also includes the wireSet PR which I just merged - can you rebase?

Done.


Async handler

Is this asyncHandler export intended just as a convenience vs requiring it directly in other modules?
Also might consider adding an async update to 2.x along with these changes since it touches all the same code.

Correct, it's a convenience.  Wrt updating to async 2.x, I don't see much value since the next logical upgrade would be to async/await.

In general, I'm not a fan of exposing things like that since versioning can get tricky as you tie yourself to their major updates etc.  But in this case, I doubt the 7 line file will change too much. ;-)
Re async, just wanted to push forward with making everything use 2.x when it's only a matter of fixing up the auto results params.  Seems helpful to do more module dedup and is less invasive than the async/await switchover.


[GreenCityChat] - jdk 11 migration to jdk 21

GreenCityChat
Migrate project version from 11 to 21.
Summary:

[ ] Migrated from jdk 11 to idk 21
[ ] Migrated from SpringBoot 2.3.3.RELEASE to SpringBoot 3.2.1
[ ] Migrated from JavaxEE to JakartaEE
[ ] Migrated from SpringFox to Springdoc-OpenApi
[ ] Migrated from Swagger version 2.9.2 to version 3.0.0
[ ] Updated all dependancies to latest versions in pom.xml

Closed 2024-05-02


Setup rustfmt config

For consistent code formatting this change adds a rustfmt configuration to be used by developer tooling and CI.

[ ] Referenced an issue explaining the need for the change
[ ] Updated all relevant documentation in docs
[ ] Updated all code comments where relevant
[ ] Wrote tests
[ ] Updated CHANGES.md

@Liamsi Having them explicit will help communicate what is expected.


⚠ Bofrost.lu has degraded performance

In 1e4ec01, Bofrost.lu (https://www.bofrost.lu) experienced degraded performance:

HTTP code: 200
Response time: 2740 ms

Resolved: Bofrost.lu performance has improved in b7ea7d2 after 6 minutes.


Simple implementation

Hi there! Thanks so much for making this library!
I'm looking for a drop-dead simple way to use this library, but it appears to be wrapped in Webpack and importing multiple files.
Do you have a completely compiled file, (maybe even minified) that I can pop into my site and it will just target the png on the page.
I'm trying to pause a png after 5 seconds and/or click.
Any help would be great. I've read your docs about vanilla implementation, but the file just won't play nice since they require imports.

I have no separate standalone build (for now) but there is a workaround. You can use the compiled script from the npm (https://unpkg.com/apng-js@1.1.1/lib/index.js). Add it to the page via

Thanks for the reply. I saw you mentioned this JS in the documentation. What is the most basic code I use with this to target a png on my page? Thanks again for the quick reply!

@davidmz how we can build our own js?
any tutorial/guide/link will be helpful


bugfix for import components dir in alert container

it fail when import container from release

Coverage decreased (-0.01%) to 1.376% when pulling 56b2e7dfdb04a451c6e1daf50e837ed838e2e99f on embbnux:bugfix-AlertContainer into 4cc852788f7de4173fa89dc268e7dddce6294010 on ringcentral:master.

Coverage decreased (-0.01%) to 1.376% when pulling d053a1b5986afc6287babac084afb9426999258a on embbnux:bugfix-AlertContainer into 4cc852788f7de4173fa89dc268e7dddce6294010 on ringcentral:master.


Syntax highlight is broken :(

Using brackets {} breaks the syntax highlights.
Let me know what you need!
I'm using https://github.com/ellisonleao/gruvbox.nvim

Have you taken a look at the troubleshooting section in the README? Sounds like you're missing a parser dependency.

Sorry for the late reply.
I had all parser dependencies from the time I wrote the issue!
I will try again later, right now I'm using another solution :+1:. Will give more feedback.

Still, have weird syntax highlights. (Changed my color scheme)

I already had all the dependencies, but done again TSIntall tsx css typescript

Yep, I can reproduce. Seems like the issue was the apostrophe in the comment: my raw-text scanner just straight up doesn't handle comments 🤦. I'm surprised this didn't come up earlier to be honest. Should be fixed soon.

Awesome, thanks a lot, great work! :)


chore: clean up remaining uses of ethers-core

How do we intend to phase out that type?

@gakonst Given that we only need a small fraction of all the chains and methods in NamedChain, and this enum is the only thing use ethers-core for (outside of tests), I think we should make our own temporary NamedChain enum in reth-primitives

Seems fine w me -- do we want to move parts of this in alloy-rs/chains?

No I don't think so, at least not yet


Enhance install script to support clustered-storage

Added new parameter eve_install_clustered_storage_sizeGB
Creates a ZVOL of size eve_install_clustered_storage_sizeGB  and mounts ext4 on that volume.
That volume is where all k3s components persist the data. See pkg/k3s/cluster-init.sh

Tested
Installation and verified all k3s  components start.

Sorry I did not see this comment. I am not 100% clear on your suggestion eve_install_kubevirt_reserve_for_eve. Are you saying using that parameter we reserve some space for eve components and use rest for clustered storage ?

Correct.
Then we can later figure out a reasonable non-zero default for this, and none of it will depend on the size of the total storage.

Ok then why do we even need  eve_install_kubevirt_reserve_for_eve ?  Basically if it is a kubevirt hv type we can set the following defaults as part of installation.

ZFS reserved space (5%)
EVE reserved space (say 20GB)

The rest can we used for clustered storage.  Since no customer is going to use kubevirt image for many more months we can adjust the 2) internally until we find the optimal value.

2. EVE reserved space (say 20GB)

Do we currently have an argument for this?

I do not see anything in https://github.com/lf-edge/eve/blob/master/docs/BOOTING.md

Tested installation:
2023-06-06 21:49:20 : EVE-OS installation started
2023-06-06 21:49:20 : Nuked partition tables on nvme0n1
2023-06-06 21:49:20 : Nuked partition tables on sda
2023-06-06 21:49:20 : Nuked partition tables on sdb
2023-06-06 21:49:25 : Installing EVE-OS on device nvme0n1
2023-06-06 21:49:25 : Installing persist on disk(s) sda,sdb
2023-06-06 21:49:25 : EVE install server : zedcloud.alpha.zededa.net
2023-06-06 21:49:25 : INFO: RANDOM_DISK_UUIDS =
2023-06-06 21:49:25 : SKIP_ZFS_CHECKS = true
2023-06-06 21:49:25 : Kubevirt image installing ZFS and EVE reserved storage sizeGB 100
2023-06-06 21:49:25 : ZFS raid level:
2023-06-06 21:49:29 : Installing ZFS filesystem, MULTIPLE_DISKS = true
2023-06-06 21:50:04 : Creating ZFS pool with raid level:
2023-06-06 21:50:04 : Pool creation command:  /dev/sda /dev/sdb true 100
2023-06-06 21:50:04 : Preparing ZFS pool and mounts
2023-06-06 21:50:04 : Creating clustered-storage
2023-06-06 21:50:04 : AvailableGB : 1438  ReservedGB : 100
2023-06-06 21:50:04 : Creating clustered-storage volume of size 1338G
2023-06-06 21:50:05 : Formatting /dev/zd0 to ext4
2023-06-06 21:50:15 : mount_part PART = CONFIG DISK = nvme0n1 TARGET = /config
2023-06-06 21:50:16 : SOFT_SERIAL = 5aafe05f-8e79-4a5c-9796-c689bdbd9bf3
2023-06-06 21:50:16 : mount_part PART = INVENTORY DISK = sdc TARGET = /run/INVENTORY
2023-06-06 21:50:16 : EVE-OS installation will store report to USB inside /INVENTORY/5aafe05f-8e79-4a5c-9796-c689bdbd9bf3
2023-06-06 21:50:18 : No TPM; Generating soft device certificate
2023-06-06 21:50:24 : EVE-OS installation completed, device will now reboot/poweroff

I do not see anything in https://github.com/lf-edge/eve/blob/master/docs/BOOTING.md

What were you looking for? That file does show e.g., the zfs-related install grub options and you added the new option to it.


Can't get device_url of iOS device

Version information

ATX Version: You can get from python -matx version
1.1.1
Python Version: You can get from python -V
2.7.10

What steps will reproduce the problem?
1.Start wda on iOS device
2.Connect with the device on atxweb
3.Failed - internal server error

@ijasonyi atx-web

Pls use pip install atx-webide==0.1.1.dev72 temporarily, and I'll update soon.

@ijasonyi 进度什么样了

@qjjy29 @codeskyblue  Using 0.1.1.dev72 has already been proved successfully with iOS device testing. I have to check all functions and then publish 0.1.2, which can be installed directly


Does any form of visibility / metrics / eventing require Redisson Pro

From what I can tell it does. I don't think this is justified. No one should be using a library - casually or otherwise - without metrics and a basic eventing system.
There's many fine features of this product that I'd be HAPPY with as commercial only, including most of its task scheduling, but metrics is an absolute no-go.
Of course my needs may be different from others, but I ask you to reconsider this. Even providing a basic eventing system that OSS could build metrics from would be great.

Thanks for sharing your opinion. Unfortunately, this feature can't be part of OSS project. My apologies, if you have to choose the other solution in this case.


Install juicefs-csi-driver throw kind "CSIDriver" in version "storage.k8s.io/v1" on k8s 1.15

as the document said, CSI-driver support k8s version v1.13+
btw in k8s 1.14/1.15 CSI feature is Beta
so need an install file which
apiVersion: storage.k8s.io/v1beta1
# apiVersion: storage.k8s.io/v1

kind: CSIDriver

so need an install file which

Yeah, you are right. We'll do more Kubernetes version test. Thanks!

so need an install file which

Yeah, you are right. We'll do more Kubernetes version test. Thanks!

So this should be fixed, thanks!

So this should be fixed, thanks!


Incorrect polyfills & unexpected change of behavior 2023-12-19

What
Something changed on this URL today that gave us some unexpected errors: https://cdn.polyfill.io/v3/polyfill.min.js?features=Intl.~locale.en,Intl.~locale.se,ResizeObserver. It does not seem to be working correctly, as none of these need to be polyfilled in Chrome but I am getting 382kb of overrides. Full contents found here: https://gist.github.com/MarcusCaspeco/3d08928e50b4f370aacfcdaa83e772e3
Furthermore, when I remove the .min part of the URL, I expect to see the full script without minification, but instead I get this (this should be the output of both the .min and the non-minified script:)
/*
 * Polyfill service v3.111.0
 * For detailed credits and licence information see https://polyfill.io.
 *
 * Features requested: Intl.~locale.en,Intl.~locale.se,ResizeObserver
 *
*/

/* No polyfills needed for current settings and browser */

I am on the latest stable version of Chrome on Windows.
Details
We have been using following polyfill CDN URL in production for a long time: https://cdn.polyfill.io/v3/polyfill.min.js?features=Intl.~locale.en,Intl.~locale.se,ResizeObserver.
Something changed today which gave us unexpected errors, likely due to a conflict with other packages. We can't go back in time to verify and check exactly what happened, but we think this file used to be empty but now it isn't.
Our workaround was to simply remove the polyfills as these features are now supported by all browsers that we need to support.

We run today also in this same problem with this polyfill URL:
https://cdn.polyfill.io/v3/polyfill.min.js?features=default,Array.prototype.includes,Array.prototype.find,NodeList.prototype.forEach,Element.prototype.scroll,fetch

Another workaround, if the polyfill script cannot be removed, might be to remove the cdn. part like the documentation suggests today.
https://polyfill.io/v3/polyfill.min.js?features=Intl.~locale.en,Intl.~locale.se,ResizeObserver seems correct to me (no overrides)

Hi all, thanks for the issue, I believe I have now fixed this caching issue, could you please let me know if you still see incorrect responses once you've cleared your browser cache?

LGTM 👍 Thanks for the quick response


Create mobile layout for landing page

It's not 100% intuitive that the drawer opens on the left side when we click on the burger which is on the right side. Also, the right side of the screen is much easier to reach with the thumb


bau: Unblock failed GHA

Apparently GH workflows don't run with
actions/setup-java@1df8dbefe2a8cbc99770194893dd902763bee34b. Version c3ac5dd0ed8db40fedb61c32fbe677e6b355e94c is in our whitelist so should be ok.

What version of setup-java is this? Will we need to adjust the dependabot config?

What version of setup-java is this? Will we need to adjust the dependabot config?

What do you mean? It's version c3ac5dd0ed8db40fedb61c32fbe677e6b355e94c. Not sure if we'll need to adjust the dependabot config.

What version of setup-java is this? Will we need to adjust the dependabot config?

What do you mean? It's version c3ac5dd0ed8db40fedb61c32fbe677e6b355e94c. Not sure if we'll need to adjust the dependabot config.

I meant which semantic version does that hash refer to (e.g. v3.9.0 is 1df8dbefe2a8cbc99770194893dd902763bee34b on this dependabot PR). If we merge this, then dependabot will try and update to the latest version. We can pin the dependabot config to stop it doing that if needed.

Ah, the commit c3ac5dd0ed8db40fedb61c32fbe677e6b355e94c can be found at https://github.com/actions/setup-java/compare/v3.6.0...actions:v3.8.0 so the version would be 3.8.0.

Do we want one of these in the dependabot config? https://docs.github.com/en/code-security/dependabot/dependabot-version-updates/configuring-dependabot-version-updates#example-disabling-version-updates-for-some-dependencies
I think we probably want
      - dependency-name: "actions/setup-java"
        # Ignore only new versions for 4.x and 5.x
        versions: ["3.x"]

I'm a little confused as to why 3.9.0 doesn't work here - it was fine for connector so it would be good to know why.

I'm a little confused as to why 3.9.0 doesn't work here - it was fine for connector so it would be good to know why. I've rebased the other PR in case it was just a stale branch.

It'd be good to know why too, but I stopped short of investigating as this is supposedly a known issue.

Closing as the issue is resolved: https://github.com/alphagov/pay-webhooks/actions/runs/3957817175.


4 gpus works fine while 8 gpus causes memory leakage and runs slow?

I tested sync inplace abn on 8 x GTX TITAN and 8 x TITAN Xp machine. In both case, using 4 gpus works well while memory leakage appears when 8 gpus are adopted.
gpu: GeForce GTX TITAN and TITAN Xp
cuda: 8.0
pytorch: 0.4.1
gcc: 5.2.0

Did you mean your GCC is 5.2.0? Also, did you compile pytorch from source or used conda?
I have the same configs but get errors when trying to run.

@Spandan-Madan , yes, gcc is 5.2.0. I use conda to install pytorch and test my own code with sync inplace abn incorporated.

I get the same problem.

same problem.
8 gpus died, 4 gpus works well, 6 gpus very slow :(

same problem

Thank you, the newest version solves the problem.


launchagent custom json-url

Hi. how can i rebuild the PKG for the launchagent to include my custom json url?. cheers

Happy Tuesday, @alexmateescu!
The following may prove helpful:
Nudge Post-install

Nudge uses https://github.com/munki/munki-pkg to build its packages. You can create a new pkg by following the readme on that github.


How can I handle case where i Need to handle same value with diffrent keys?

class User:Mappable
{
dynamic var name:Srtring?
dynamic var players:List()
func mapping(map: Map) {
name <- map["name"]
players <- (map["players"] ,listTransform())
// this key can be friends in other scenarion but need to map same Player object .
}
}
How can I acheive this .?

You could do something like:
        if let players = map.JSON["players"] {             // Set values         } else if let friends = map.JSON["friends"] {             // Set values         }


LinesReaderObservable blocks application thread

Hi. I have the following program which uses Monix 3.0.0-RC1 or Monix 2.3.3
package example

import java.io.{BufferedReader, InputStreamReader}
import monix.reactive.Observable
import scala.collection.mutable.ListBuffer

object Program {
  def main(args: Array[String]) = {
    val pb = new ProcessBuilder("seq", "40000")
    val p = pb.start()

    val out = Observable.fromLinesReader(new BufferedReader(new InputStreamReader(p.getInputStream)))
    val err = Observable.fromLinesReader(new BufferedReader(new InputStreamReader(p.getErrorStream)))

    val capturedErr = ListBuffer[String]()
    println("before")
    // Following line blocks!
    err.foreach(line => capturedErr.append(line))(monix.execution.Scheduler.Implicits.global)
    println("after")

    out.foreach(println)(monix.execution.Scheduler.Implicits.global)

    Thread.sleep(5000)
  }
}

which never terminates. The problem happens on line
err.foreach(line => capturedErr.append(line))(monix.execution.Scheduler.Implicits.global)

and only when the process p produces enough data. Eg. it works for new ProcessBuilder("seq", "10000").

The reason for the observed behavior above is that with smaller stdout all stdout of seq command fits into the buffer and seq can terminate before its output is read by our code, seq's stderr is closed and blocking(in.readLine()) (from LinesReaderObservable) returns null when reading stderr.
On the other hand when output of seq is too big, it cannot fit into the buffer, so seq is paused by OS while it's stderr is still open. Now the code above tries to read from stderr and it's blocked because reading happens synchronously and there is nothing to read. And because our code is blocked before reading seq's stdout seq remains blocked and it's deadlock.

Here is simpler code which exhibits problem in LinesReaderObservable
package example

import java.io.{BufferedReader, InputStreamReader, PipedInputStream, PipedOutputStream}

import scala.collection.mutable.ListBuffer

import monix.reactive.Observable

object Program {
  def main(args: Array[String]) = {
    val pos = new PipedOutputStream()
    val pis = new PipedInputStream(pos)
    //pos.close()

    val err = Observable.fromLinesReader(new BufferedReader(new InputStreamReader(pis)))

    val capturedErr = ListBuffer[String]()
    println("before")
    // Following line blocks!
    err.foreach(line => capturedErr.append(line))(monix.execution.Scheduler.Implicits.global)
    println("after")
  }
}

The problem is that LinesReaderObservable calls in.readLine() in application thread instead thread pool thread. And since there is nothing to read in.readLine() blocks the application.
If you uncomment pos.close(), application won't be blocked because in.readLine() would get null immediately.

I think that possible solution is to change unsafeSubscribeFn in LinesReaderObservable to never call fastLoop and always call reschedule.


Replaced with Radio Buttons

Fixes #9838
I've changed the input type of the buttons in the "Reports" section of the Admin Page to Radio Buttons.
I've not removed the styles because after removing the styles the buttons were showing as clustered instead of properly aligned. However, I've removed the JS implementations.
Also changed the name of the filter from "BooleanButtonSelect" to "BooleanFilterSelect"
Please check the following:

[ ] Do the tests still pass?[^1]
[ ] Does the code comply with the style guide?

[ ] Run make lint from the Wagtail root.

[ ] For Python changes: Have you added tests to cover the new/fixed behaviour?
[ ] For front-end changes: Did you test on all of Wagtail’s supported environments?[^2]

[ ] Please list the exact browser and operating system versions you tested:
[ ] Please list which assistive technologies [^3] you tested:

[ ] For new features: Has the documentation been updated accordingly?

Please describe additional details for testing this change.
[^1]: Development Testing
[^2]: Browser and device support
[^3]: Accessibility Target

Can you please also update the description with some screenshots of before and after

Oh ok, thanks for the minor clean-up and merging the PR...
And "Mehul Aggarwal" works pretty good for the contributor name.


Cleanup deprecated methods from SPI

https://hibernate.atlassian.net/browse/HSEARCH-2770

I verified each step foollowing along with the Infinispan project, so I know that these are safe now :)

pushed a new version

fixed the javadoc
removed SearchFactoryIntegrator

No idea why the javadoc didn't fail locally?

ok, CI confirmed it's green: I'll merge it. Thanks for the review!


Fix answer correctness confidence intervals

While the main_score in the metrics.rag.answer_correctness.token_recall metric was recall, the score_name field was f1 and the confidence interval values were taken from F1.

See for example, the score value is 0.29 (of recall), but the score_ci_low, score_ci_high and score_name fields refer to F1.

This PR:

Sets the score_name field for instance and global levels to the main_score defined for each MetricPipeline.
Copies the confidence interval values of the main_score (e.g. recall_ci_low and recall_ci_high) to the score_ci_low and score_ci_high fields.
Also moved the test which involves only recall calculation (i.e. no models involved) to the module top-level, so it runs in CI.
Fixed the catalog names of the RAG answer correctness metrics in the module tests.

@elronbandel @yoavkatz

Seems to me that steps 1 and 2 are general for every MetricPipeline. WDYT?
It would have been nice to copy the confidence interval fields only if they exists. Is there a CopyIfExists opetator?

Hi. I think it's a good point - although it may be a fix which is not backward compatible.
We we make the change , it should be in
self.prepare_score = Copy(
field_to_field=[
[
f"score/instance/{self.metric._add_score_prefix(self.main_score)}",
"score/instance/score",
],
[
f"score/global/{self.metric._add_score_prefix(self.main_score)}",
"score/global/score",
],
],
)
@elronbandel - What do you think?


master

Hey, if you want to make a contribution to this repository, please follow these instructions:
https://github.com/GoogleChrome/custom-tabs-client/blob/master/CONTRIBUTING.md
Sorry for inconvenience.
Setting code aside, can you educate us on what the specific benefits are for updating gradle versions. Are old versions blocking something at the moment?

The benefits is that developers can easily work with your repo using Instant Run in Android Studio.

Hi @IgorGanapolsky , Thanks for the Pull Request. The Instant Run feature is still on Android Studio Canary and it seems we would have to include and alpha version of the build tools ('com.android.tools.build:gradle:2.0.0-alpha6') for it work. It's probably worth waiting until the feature reaches mainstream.

@pasko What in the world is Rietveld?  I tried to learn about it, but it seems old-school :)

It is truly very old school, but it is the tool in use for collaborative development of the Chrome browser. Sorry about that :)


Chords

It is quite inconvenient that the chords have to be provided alphabeticaly ordered when this is not the case in Music XML. I am terying to resolve this in VexFlow but it by far more complicted than expected.
If I do not resolve that the processing of the chords' accidentals, ... will be very complicated.

There is already a PR in VexFlow addressing the order of Chords
https://github.com/0xfe/vexflow/pull/1387

I agree with your approach. Thanks for fixing that, your work is very valuable to the community!

Keep up the good work; this looks very promising.

Thanks for the positive feedback @acidjunk! Let me know if you'd like to get involved in what we're doing.


Simulation Invariants

Closes: #144
Closes: #175

Codecov Report

Merging #270 (2eb1695) into main (b097ff5) will increase coverage by 0.04%.
The diff coverage is 30.30%.

:exclamation: Current head 2eb1695 differs from pull request most recent head 5b7994b. Consider uploading reports for the commit 5b7994b to get more accurate results

@@            Coverage Diff             @@
##             main     #270      +/-   ##
==========================================
+ Coverage   18.44%   18.48%   +0.04%
==========================================
  Files         133      134       +1
  Lines       20926    20959      +33
==========================================
+ Hits         3860     3875      +15
- Misses      16433    16449      +16
- Partials      633      635       +2

Impacted Files
Coverage Δ

x/gamm/keeper/invariants.go
30.30% <30.30%> (ø)

x/gamm/keeper/pool.go
77.77% <0.00%> (+6.94%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b097ff5...5b7994b. Read the comment docs.


Fix kubearchive database secret extraction

ExternalSecret are using go templates when using template to create the target secret. If the key to access contains a dot (e.g. db.user), we must use an index function to access it otherwise is is looking for an object(db) containing another object (user).

/ltgm

/lgtm


Existing Elastic Beanstalk Environments not showing in new Publish to AWS experience

Describe the bug
I have multiple Elastic Beanstalk environments that I publish to using the existing "Publish to AWS Elastic Beanstalk" tool without issue. When I try to use the new Publish to AWS tool, those existing environments are not shown in the list.
To Reproduce
To reproduce this issue, I right-click on the project name and select "Publish to AWS". The existing environments do not show in the list of targets.
Expected behavior
Existing Elastic Beanstalk environments should show in the list of targets.
Screenshots

First screenshot shows my legacy list. Note that the second screen shot shows an environment that doesn't even exist anymore and does not show any of the ones on my legacy list.
Computer (please complete the following information):

Windows Version: 11
Visual Studio Version: 2022 Community
AWS Toolkit for Visual Studio Version: <IP_ADDRESS>

Additional context
This has been an ongoing issue since the Publish to AWS option first appeared and has not been resolved as of yet.

Hi @ScottDellinger , thank you for reaching out. Are your existing Beanstalk deployments .NET Framework based applications that are running on Windows Beanstalk images? (If not, can you please describe your applications and the beanstalk compute)

Hi @awschristou ... that is correct... they are the default Windows images running in the Elastic Beanstalk environments with .NEt Core 3.1 applications.

Thank you for the clarification. We've been getting a fair bit of feedback about Windows image based Beanstalk environments not appearing in the "Existing Target" list. We didn't have a specific issue filed for this scenario, so I've renamed this issue to represent it.
Work is currently in progress to add support for listing existing Windows based Beanstalk Environments in the underlying deploy tool - https://github.com/aws/aws-dotnet-deploy/pull/702. When this improvement becomes available in a future release of the deploy tool, we'll be able to onboard it to the Toolkit's Publish to AWS experience. I will pin this issue for visibility, given the interest it is receiving.

The deploy tool has been updated to support deployments to existing Windows Beanstalk environments and released as version 1.5.4.
We have a test build of the Toolkit that integrates this new deploy tool release, see below for the download details. If you try it out, please leave a comment to share your experience with it.
File: AWSToolkitPackage.v17.vsix.zip
Version: <IP_ADDRESS>60
Sha384 Hash: A78EBF1E278CE3D1506BC10F153481D6B287FB099200E8A4DD86CF26B6F5B48B2CD97D520A5746DC9C054BC771EDDD10

Version <IP_ADDRESS> of the Toolkit is now available. It contains an update to the Publish to AWS experience that supports deploying .NET Core/5+ projects to existing Beanstalk environments that use Windows based images.


Where is lcslog - the archiving database?

Where is lcslog - the archiving database, where can I find it?

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: bfbe74fb-9f37-d757-cd86-160de8a0293f
Version Independent ID: 53b9bac5-009d-5486-a38a-013b55699a1f
Content: Schema reference for Skype for Business Server 2015
Content Source: Skype/SfbServer/schema-reference/schema-reference.md
Service: unspecified
Product: skype-for-business-itpro
GitHub Login: @SerdarSoysal
Microsoft Alias: serdars

are you asking where in the network lcslog is placed? or asking where the reference describing the file and its structure is?


Create a Drogon Backend Example

Create a Drogon backend example project as part of the official repository.
Move current examples to integration tests.

Drogon's website and it's source code  should serve as an example for now.


The Dockerfile no longer regenerates a functioning docker image

Running the test data through the resulting container gives this error:
    from bx.bitset import *
ImportError: /usr/local/lib/python2.7/site-packages/bx/bitset.so: undefined symbol: PyUnicodeUCS2_FromStringAndSize

Solution: find specific versions of python libraries used in existing docker image (1.1.1) and update the requirements.txt to include them.
bx-python==0.7.3
Cython==0.27.3
numpy==1.13.3
pysam==0.13
RSeQC==2.6.4
virtualenv==15.1.0


Updating menu entries

Removing Primer for Authors, adding Atlas under Learn

Hey @blimpa, what is needed to finalize this PR?

Hey @blimpa, what is needed to finalize this PR?

It's ready! I should've merged it before. Doing it now!


Allow setting more than one validation pattern for data

I am actually looking for this capability from a form. That plugin seems to use the Grav\Common\Data validate() method.
So what I want to do is set more than one validation pattern, such that they all need to pass. Sure, this can almost certainly be done using a complex regular expression, but Grav is supposed to make the developer's life easy and this would help.
I envisage blueprint/form YAML something like:
  validate:
    pattern: ['^((?!https?:\/\/)(?:\R|.))*$', '\w\s+\w']

and then Grav\Common\Data\Validation->validatePattern() could be modified to include a test for $value being an array, and loop through that if needed.
Happy to code, test, and submit this as a PR if you think it's a good idea. Wanted to float the idea first.

Thanks for the answer, I don't know much about Grav's FE validation yet. It's probably best implemented as a plugin at this stage, in that case. If my need becomes greater, I could build one.
I am genuinely curious to know more about the nature of the FE validation issues you are talking about. This would be useful to know for building this plugin.


Rework windows pipeline to sign less (and min builds)

Combines the user and system installer signing steps into one

Moves to min builds (smaller size), but this also increases the build time.

Utilize the archive build step instead of manually zipping the output.

Looks to be working now, Im going to merge this in, we can revert if any issues arrise.


fix anchor location

Description
fix anchor location
Completed Tasks

[x] I have read the Contributing Guide.
[x] The pull request is complete (implemented / written).

Coverage decreased (-0.01%) to 93.505% when pulling 5a91e31c133f5f43569e56bfa5588952b1670c90 on noraj1337:patch-2 into 87080b5773aea49a81fbc6793c98ca2424390785 on lsegal:master.


dagger up in todoapp failing

Hi there,
I was going through the getting started guide but ran into some issues that I wasn't sure how to debug. Any guidance would be helpful!
3:08PM INF funnyName | computing    environment=s3
3:08PM INF source | computing    environment=s3
3:08PM INF source | completed    environment=s3 duration=0s
3:08PM INF app.source | computing    environment=s3
3:08PM INF app.source | completed    duration=0s environment=s3
3:08PM INF app.ctr | computing    environment=s3
3:08PM INF funnyName | completed    environment=s3 duration=1.3s
3:08PM INF app.ctr | completed    environment=s3 duration=1.8s
3:08PM INF app.build | computing    environment=s3
3:08PM INF app.build | completed    duration=100ms environment=s3
3:08PM INF s3bucket.source | computing    environment=s3
3:08PM INF s3bucket.source | completed    duration=100ms environment=s3
3:08PM INF s3bucket.url | computing    environment=s3
3:08PM INF s3bucket.url | #17 4.179 fatal error: Could not connect to the endpoint URL: "https://s3.amazonaws.com/todoapp.microstaging.io?list-type=2&prefix=competent_lederberg%2F&encoding-type=url"    environment=s3
3:08PM ERR s3bucket.url | failed: process "/bin/bash --noprofile --norc -eo pipefail -c opts=()\nif [ -d /source ]; then\n\top=sync\nfi\n[ -n \"$OPT_CONTENT_TYPE\" ] && opts+=\"--content-type $OPT_CONTENT_TYPE\"\n[ -n \"$OPT_DELETE\" ] && opts+=\"--delete\"\naws s3 sync ${opts[@]} /source \"$TARGET\"\necho -n \"$TARGET\" \\\n\t| sed -E 's=^s3://([^/]*)/=https://\\1.s3.amazonaws.com/=' \\\n\t> /url" did not complete successfully: exit code: 1    environment=s3 duration=4.5s
3:08PM FTL system | failed to up environment: task failed: process "/bin/bash --noprofile --norc -eo pipefail -c opts=()\nif [ -d /source ]; then\n\top=sync\nfi\n[ -n \"$OPT_CONTENT_TYPE\" ] && opts+=\"--content-type $OPT_CONTENT_TYPE\"\n[ -n \"$OPT_DELETE\" ] && opts+=\"--delete\"\naws s3 sync ${opts[@]} /source \"$TARGET\"\necho -n \"$TARGET\" \\\n\t| sed -E 's=^s3://([^/]*)/=https://\\1.s3.amazonaws.com/=' \\\n\t> /url" did not complete successfully: exit code: 1
    environment=s3```

Hi @aviaviavi,
It worked without a flinch for me (just reinstalled Dagger from scratch + followed https://docs.dagger.io/1003/get-started/).
Can you please describe the steps you followed ?

Sure, I ran:
git clone https://github.com/dagger/examples
cd examples
./import-tutorial-key.sh
dagger up

Which, as far as I can tell, is what the tutorial describes, but please let me know if I'm missing something

cd examples/todoapp

On it :-)

Ok, I reseted my keys, installed from brew, followed exactly your steps and it worked again. That's odd :'(
Can you please tell me your dagger version ? You should have this one:
$ dagger version
dagger 0.1.0-alpha.20 (8462963) darwin/amd64

Yep
~/d/e/todoapp ❯❯❯ dagger version
dagger 0.1.0-alpha.20 (8462963) darwin/amd64

Are you connected to a mobile hotspot ?

No, a home network. I was on a spotty connection when I first tried it, but now I'm on a very solid connection and still seeing the same issue

Can you please ping me on the discord channel ? My id is francky#6966

@aviaviavi, still interested to see live. I still haven't been able to reproduce it

Thank you for helping with this @grouville!
If you are still having issues @aviaviavi, let us know.
Closing for now 👍🏻


ROX-11605: Display clusterIdToRetentionInfo in clusters list and cluster panel

Description
Follow up #2182

Adapt ClusterDeletion component from CertificateExpiration but without icon

Not applicable if clusterRetentionInfo === null
in D days if 'daysUntilDeletion' in clusterRetentionInfo
Excluded from deletion if isExcluded
Deletion is turned off if !isExcluded

Clusters table

Render Cluster Deletion column if feature flag is enabled
Omit row actions unless role has READ_WRITE_ACCESS for Cluster resource

Cluster side panel

Render Cluster Deletion column if feature flag is enabled

Changed files

Edit cypress/fixtures/clusters/health.json

Add clusterIdToRetentionInfo property

Edit cypress/helpers/clusters.js

Factor out visitClustersWithFixture helper function
Remove clusters request from route matcher map for visitClusterById function for forward compatibility with cluster page
Add clusterRetentionInfo prop in visitClusterByNameWithFixture and visitClusterByNameWithFixtureMetadataDatetime functions

Add cypress/integration/clusters subfolder and move clusters.test.js into it

Add cypress/integration/clusters/clusterDeletion.test.js

Edit src/Containers/Clusters/ClusterEditForm.tsx

Add clusterRetentionInfo prop

Edit src/Containers/Clusters/ClustersSidePanel.tsx

Import Cluster from frontend proto type and add as unknown as Cluster cast to get rid of Partial<Cluster> | null type
Replace getClusterById with fetchClusterWithRetentionInformation function call
Destructure clusterRetentionInfo property from cluster response
Add comment about future code to prevent possible edge case from not updating retention info after save

Edit src/Containers/Clusters/ClustersTablePanel.js

Replace fetchClustersAsArray with fetchClustersWithRetentionInfo function call
Add clusterIdToRetentionInfo,  hasReadWriteAccessForCluster and isDecommissionedClusterRetentionEnabled properties to arg of getColumnsForClusters function call

Add src/Containers/Clusters/Components/ClusterDeletion.tsx

Edit src/Containers/Clusters/Components/ClusterSummary.tsx

Add ClusterRetentionInfo and isDecommissionedClusterRetentionEnabled props

Edit src/Containers/Clusters/cluster.helpers.tsx

Add getClusterDeletionStatus function

Edit src/Containers/Clusters/clusterTypes.ts

Re-export Cluster type from frontend cluster proto, as first step to supersede this container types file

Edit src/Containers/Clusters/clustersTableColumnDescriptors.js

Add clusterIdToRetentionInfo,  hasReadWriteAccessForCluster and isDecommissionedClusterRetentionEnabled properties
Update column width classes
Push Cluster Deletion column if feature flag is enabled
Push row actions if role has READ_WRITE_ACCESS for 'Cluster' resource

Edit src/services/ClustersService.ts

Add fetchClustersWithRetentionInfo function
Rename getClusterById with getClusterWithRetentionInforation function

Edit src/types/cluster.proto.ts

Factor out ClusterLabels
Rename ManagerType as ClusterManagerType

Edit src/types/clusterService.proto.ts

Add ClusterResponse, ClustersResponse, DecommissionedClusterRetentionInfo types

Residue

Replace imports from clusterTypes.ts with imports from frontend cluster proto
Rewrite files in TypeScript
Conditionally render other actions only if READ_WRITE_ACCESS for 'Cluster' resource

Checklist

[x] Investigated and inspected CI test results
[x] Added integration tests

Testing Performed
manual testing

export ROX_DECOMMISSIONED_CLUSTER_RETENTION=true in ui also verified does not render if false

yarn deploy-local in ui

yarn build in ui

yarn start in ui

Visit /main/clusters: see GET /v1/clusters has new property
{
    clusterIdToRetentionInfo: {},
    clusters: […]
}

Click cluster: see GET /v1/clusters/id has new property
{
    cluster: {…},
    clusterRetentionInfo: null
}

integration testing

export CYPRESS_ROX_DECOMMISSIONED_CLUSTER_RETENTION=true in ui/apps/platform
yarn cypress-open in ui/apps/platform

clusters.test.js
clusters/clusterDeletion.test.js see it skip tests without above feature flag export

Good question about API. A possible motivation is to avoid adding more state into the cluster object.
A future refactoring might distinguish cluster configuration from cluster state.


Fix crash on URL with ?

Description
Fixes https://github.com/dust-tt/tasks/issues/514

Risk

Deploy Plan

PMRW


THE G.O DONT DETECT THE FILE

when i select the file json on Genshin Optimizer the file stills loading infinitly and dont do nothing.How can i fix it?

Please use this website to validate the json file's text. If it is not valid please upload the json file to this issue so that we may further help with the issue.

I am going to close this issue no new information has been given in a while. Please feel free to reopen this issue or to open a new issue should any problems come up.


Correctly import generic dependencies

Fixes #772
@riverar can you confirm that the WinUI example you mentioned has also been fixed - you should not need to import IObservableVector.

@kennykerr Will do.


alternate tables annotation not inherited by subcontexts

I created an alternate table/view alt_x on table x. On table x I set the alternate table for the compact context to be the alt_x. I only see the alt_x displayed on the recordset but not in the nested tables. Explicitly specifying compact/brief fixed this.

@RFSH If this is fixed, please assign @robes to review and close the issue..

@hongsudt I just merged the PR.

appears to work in my test


Fix #104: CLI flags for disabling default dependencies and cli

Add new cli flag "--disable-default-dependencies"
When this flag is passed, the default dependencies will not be
included.
Add new cli flag "--disable-cli"
This flag can be used to disable installing CLI.

Awesome, thanks!

Thanks.

Crap, I'll look into it.

@crohr can I add some form of higher level tests that actually executes the pkgr command?

@jacob-carlborg sure, go ahead!

Hmm, I don't think I'll have time to fix this until next week. Feel free to revert my changes, I'm using my own fork right now anyway.


remove fallback to indexdao for critical workflow.

This PR contains following things.

Removed falling back to indexDAO for critical workflow like scheduling workflows
Only UI call back will be fall back to indexDAO.
Wrote unit test
Fix existing unit test.

The dashboard also has fields for searching using name? Can you please verify that works as well.


DSD-1054: Footer

Fixes JIRA ticket DSD-1073
This PR does the following:

The React Footer component passed QA and we can merge it into the repo. I set it to 1.1.0 and it can wait until 8/14 (next release date if not 8/4).
Everything in this PR has already been peer reviewed. This PR really only updates the version and points to development.
The static version isn't part of the React component implementation so that can come later.

How has this been tested?
Locally in Storybook and Turbine.
Accessibility concerns or updates

There is accessibility documentation in the Footer Storybook page, but this is based on the existing Footer. If we ever update the Footer, that accessibility information should then be updated.

Checklist:

[ ] I have updated the Storybook documentation accordingly.
[ ] I have added relevant accessibility documentation for this pull request.
[ ] All new and existing tests passed.

Front End Review:

[ ] Review the Vercel preview deployment once it is ready.

Updated.


Include catkin directories

Without this, it won't build without sourcing setup.bash first (which is not a necessary step).
Note that this will mean it fails the first time you try to release
it as a deb on the osrf build farm as it is a sandboxed environment.

Also added a more convenient launcher arg configuration for users of the library.

@stonier did you add the Eclipse files (.cproject, .project and the .settings directory) on purpose? They contains at least the YUJIN_WORKSPACE variable...

@ipa-mig no, this PR was supposed to be only the first commit. Didn't expect to have the team working continually on this branch. I'll close this one and create pull requests individually.

New PR with just the catkin fix in #16


No way to suppress cross-domain script errors from logging?

  As a result, we are drowning in a large volume of these errors:
"Script error: The browser's same-origin policy prevents us from getting the details of this exception. Consider using the 'crossorigin' attribute."
This is great in general, but unfortunately it's not helping us anymore as we've caught all the obvious problems causing it, and now it's just unhelpfully logging a zillion errors a day.  We know, we know, people are bad at writing ad javascript.
I've tried suppressing this exception like we do our other exceptions, as seen here:
https://zone.msn.com/gameplayer/gameplayerHTML.aspx?game=msmahjong&instance=default
Unfortunately, it doesn't seem to work.  Looking at the AI unminified source, this seems to be because there's a special case where it's send with a different message:
https://az416426.vo.msecnd.net/scripts/b/ai.2.js
Am I misinterpreting this, and we actually suppress from being sent in some way?

So exactly how are suppressing exceptions (without decoding all of your source on the link provided).
At the end of the day both exceptions and cors exceptions eventually call and following the track path.
Send Cors: https://github.com/microsoft/ApplicationInsights-JS/blob/master/extensions/applicationinsights-analytics-js/src/JavaScriptSDK/ApplicationInsights.ts#L729
sendExceptionInternal: https://github.com/microsoft/ApplicationInsights-JS/blob/master/extensions/applicationinsights-analytics-js/src/JavaScriptSDK/ApplicationInsights.ts#L399
And in both cases they are tagged as exceptions...
So depending on how you are suppressing will depend on any guidance we can provide.
In the short term the simplest way would be to add you own window.onerror handler (before the snippet / initialization of app insights) detect the Cors situation and just return true (telling us that you have handled the exception and we wont process it).
One trick I've done on a previous team was to detect the "source" of the exception (the url) and if it's not in a list of "supported" domains (main page and cdn's) then just throttle reporting of the exception (to only 1) and for consistent bad actors add code to the page to complete drop the details.

On page ready we call this:
if(appInsights && appInsights.queue){
appInsights.queue.push(function() {
appInsights.addTelemetryInitializer(zoneSuppressExceptions);
});
} else if (appInsights && appInsights.addTelemetryInitializer) {
appInsights.addTelemetryInitializer(zoneSuppressExceptions);
}
In this based on event type & consent we return false to not log it:
var zoneSuppressExceptions = function(envelope) {
if (envelope.baseType === 'ExceptionData' && envelope.baseData.exceptions) {
I'll take a look at your suggestions, thanks.

Just a minor point, you should also check the length of the queue as if it's empty it's already been processed and adding anything to it won't actually get processed.
So changing the following will probably help and I'd also do this well before page ready
if(appInsights && appInsights.queue && appInsights.queue.length > 0) {
Also all exceptions are tagged with the data type, so just changing your if check to following would catch both normal exceptions and CORS.
if (envelope.baseType === 'ExceptionData') {

Following up here, thanks for the advice, it worked like a charm.  For anyone else's reference:

CORS exceptions show up as baseType 'ExceptionData', with no exceptions property.  Here's how we're catching them:
if (envelope.baseType === 'ExceptionData') {
if (typeof (envelope.baseData.exceptions) === 'undefined' &&
envelope.baseData.message &&
envelope.baseData.message.indexOf('same-origin policy prevents us from getting the details of this exception') >= 0)
{
// Log at 1%.
var samplingPercentage = 0.01;
var samplingRandom = Math.random();
                  return samplingRandom < samplingPercentage;
          }


[Bug] After k8s submit fail, submit again cause  once submit multi-jobs.

Search before asking

[X] I had searched in the issues and found no similar issues.

Java Version
1.8
Scala Version
2.11.x
StreamPark Version
2.1.2
Flink Version
1.16
deploy mode
kubernetes-application
What happened
I guess I submit failed, real jobs had been submitted, but streampark did not get the running jobs state.
Error Exception
No response
Screenshots

Are you willing to submit PR?

[ ] Yes I am willing to submit a PR!(您是否要贡献这个PR?)

Code of Conduct

[X] I agree to follow this project's Code of Conduct

@minchowang Hello, is flink-kubernetes-v2 enabled?

@minchowang Hello, is flink-kubernetes-v2 enabled?

Currently, I use default mode based on releases-2.1.2.


setLevel upgrade and allow channels to be disabled

Some automations (Groups and Scenes in my case) call setLevel with 2 parameters: Percent and Duration.  Added an override to accept the duration which is then ignored.  Also added settings for disabling individual channels.  Defaults to all enabled.

So basically the only real change is the level percentage ?

2 changes:

setLevel override which accepts a second duration parameter which is subsequently ignored.
on, off, and setLevel all check if each channel is enabled before performing the action on the channel.

Ok I'll approve a new PR once you have made notes of the changes in the code at the top of the file and above the line " *  1.0.0 - Initial release" with a version bump included in the file... make the version bump from 1.0.0 to 1.0.1 on line 35 and be sure to make the changelog line to reflect your username here.


Issue running update-haproxy.py

user@myipaddress:~/haproxy-autoscale$ /usr/bin/python update-haproxy.py --access-key='***********************' --secret-key='**********************************' --security-group='my-sg'
INFO:root:no "--servicename" OR "--haproxy" arguments found, defaulting to restarting service haproxy
INFO:root:Getting instances for netadmin-sg.
INFO:root:Generating configuration for haproxy.
Traceback (most recent call last):
File "update-haproxy.py", line 89, in
main(args)
File "update-haproxy.py", line 57, in main
instances=instances)
File "/home/xdeploy/haproxy-autoscale/haproxy_autoscale/haproxy_autoscale.py", line 90, in generate_haproxy_config
return Template(filename=template).render(instances=instances)
File "/usr/local/lib/python2.7/dist-packages/Mako-1.0.6-py2.7.egg/mako/template.py", line 462, in render
return runtime.render(self, self.callable, args, data)
File "/usr/local/lib/python2.7/dist-packages/Mako-1.0.6-py2.7.egg/mako/runtime.py", line 838, in _render
**kwargs_for_callable(callable, data))
File "/usr/local/lib/python2.7/dist-packages/Mako-1.0.6-py2.7.egg/mako/runtime.py", line 873, in _render_context
_exec_template(inherit, lclcontext, args=args, kwargs=kwargs)
File "/usr/local/lib/python2.7/dist-packages/Mako-1.0.6-py2.7.egg/mako/runtime.py", line 899, in exec_template
callable(context, *args, **kwargs)
File "templates_haproxy_tpl", line 22, in render_body
KeyError: 'security-group-1'
This is what I get when I run the update file. I saw somewhere that you mentioned that the config won't work this way and it is just a template. How do I set the update-haproxy.py to simply pull from the 'my-sg' security group?
Can you please assist with this issue?
Regards,
Idan.

Yeah basically you need to be somewhat familiar with HAProxy configuration syntax. Hopefully the example template can provide you a good starting point though. For example, see where instances['security-group-1'] is referenced in the template? You need to change security-group-1 to match whatever security group name you're trying to use (my-sg).

Oh I see, how about the instances themselves? Do I need to reference that in the update file? are there any more configurations of this sort that I should be aware of in the update file? Sorry for the ignorance. I am new to this. Your too seems to be exactly what I need to be working with.

No, that for loop iterates over each instance in the security group and adds them to the HAProxy configuration. If your security group name is my-sg and you want them in a pool that is fronted with a VIP listening on port 80, here is probably the configuration you're looking for, or something like this anyway.

Ok I see how that works! I will test it and let you know if that works for me. Thank you for your prompt response and assistance. I really appreciate that.

Should update-haproxy.py remain untouched? The change is only in the haproxy.conf file correct?

The only file you should need to change is the template.

I've changed the haproxy.tpl and ran the command again and this is what I get:
Traceback (most recent call last):
File "update-haproxy.py", line 7, in
from haproxy_autoscale import get_running_instances, file_contents, generate_haproxy_config, restart_haproxy
File "/home/xdeploy/haproxy-autoscale/haproxy_autoscale/init.py", line 2, in
from haproxy_autoscale import *
File "/home/xdeploy/haproxy-autoscale/haproxy_autoscale/haproxy_autoscale.py", line 6, in
from mako.template import Template
ImportError: No module named mako.template
I've also changed my haproxy.cfg to have this config:
        % for instance in instances['my-sg']:
server ${ instance.id } ${ instance.private_dns_name }
% endfor

Did you install using setup.py? Looks like you might be missing a dependency (Mako).

I just did install the mako dependency and was able to run the setup.py and it installed properly. This is what I am getting now:
[xdeploy@ip-96-115-209-154 haproxy-autoscale]$ /usr/bin/python update-haproxy.py --access-key='AKIAIP7S2OFSBJBBPODA' --secret-key='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' --security-group='netadmin-sg' --region='us-west-1'
INFO:root:no "--servicename" OR "--haproxy" arguments found, defaulting to restarting service haproxy
INFO:root:Getting instances for netadmin-sg.
INFO:root:Generating configuration for haproxy.
Traceback (most recent call last):
File "update-haproxy.py", line 89, in
main(args)
File "update-haproxy.py", line 57, in main
instances=instances)
File "/home/xdeploy/haproxy-autoscale/haproxy_autoscale/haproxy_autoscale.py", line 90, in generate_haproxy_config
return Template(filename=template).render(instances=instances)
File "/usr/lib/python2.7/site-packages/Mako-1.0.6-py2.7.egg/mako/template.py", line 462, in render
return runtime.render(self, self.callable, args, data)
File "/usr/lib/python2.7/site-packages/Mako-1.0.6-py2.7.egg/mako/runtime.py", line 838, in _render
**kwargs_for_callable(callable, data))
File "/usr/lib/python2.7/site-packages/Mako-1.0.6-py2.7.egg/mako/runtime.py", line 873, in _render_context
_exec_template(inherit, lclcontext, args=args, kwargs=kwargs)
File "/usr/lib/python2.7/site-packages/Mako-1.0.6-py2.7.egg/mako/runtime.py", line 899, in exec_template
callable(context, *args, **kwargs)
File "templates_haproxy_tpl", line 29, in render_body
KeyError: 'security-group-2'
I understand that the security-group-2 is erroring because I haven't defined that. I only defined the security-group-1 to be my-sg. Do I need to create the template in the /usr/lib/python2.7/site-packages/Mako-1.0.6-py2.7.egg/mako/template.py destination?
Also when I add the:
% for instance in instances['my-sg']:
server ${ instance.id } ${ instance.private_dns_name }
% endfor
To my haproxy config it breaks haproxy and I cant browse to the 9000/stats page.
Regards,
Idan.

The only template you should be editing is the one you're specifying on the command line. What's happening is that Mako is rendering your template into a (hopefully usable) HAProxy configuration. If HAProxy doesn't like the configuration file then there is probably something wrong with the template. The gist I linked to earlier is probably mostly what you're looking for and you shouldn't need to change much to get it working.

Oh I see I was trying to add the
% for instance in instances['my-sg']:
server ${ instance.id } ${ instance.private_dns_name }
% endfor
To the already existing haproxy config that I have setup. Maybe I will troubleshoot with a brand new config containing what you gave me.
I will test and see if that works. Thanks!

So this is what I got so far:

haproxy.tpl -

global
maxconn 6000
user haproxy
group haproxy
daemon
defaults
log     global
mode    tcp
option  tcplog
log <IP_ADDRESS> local1 info
option  dontlognull
retries 3
maxconn 6000
timeout connect      8000ms
timeout client      80000ms
timeout server     80000ms
frontend http_in
bind *:80
mode http
redirect scheme https code 301
frontend https_in
bind *:443
option tcplog
mode tcp
default_backend mycluster
backend mycluster
mode http
balance roundrobin
% for instance in instances['my-sg']:
server ${ instance.id } ${ instance.private_dns_name }
% endfor
#frontend java :8080,:8443
mode http
maxconn 50000
default_backend java_servers
#backend java_servers
mode http
balance roundrobin
% for instance in instances['security-group-2']:
server ${ instance.id } ${ instance.private_dns_name }
% endfor
listen stats
mode http
stats enable
stats uri /stats
stats auth netadmin:netadmin
bind :9000

Getting this error

user@ipaddress:~/haproxy-autoscale$ /usr/bin/python update-haproxy.py --access-key='##############' --secret-key='###########################' --security-group='sg-sg'
Traceback (most recent call last):
File "update-haproxy.py", line 7, in
from haproxy_autoscale import get_running_instances, file_contents, generate_haproxy_config, restart_haproxy
File "/home/xdeploy/haproxy-autoscale/haproxy_autoscale/init.py", line 2, in
from haproxy_autoscale import *
File "/home/xdeploy/haproxy-autoscale/haproxy_autoscale/haproxy_autoscale.py", line 1, in
from boto.ec2 import EC2Connection, get_region
ImportError: No module named boto.ec2
Have any ideas about the boto.ec2?

I tried using what you game me for the template but I was getting an error starting the haproxy service.

Breakthrough! I was able to execute the command successfully!
user@ipaddress:~/haproxy-autoscale$ sudo /usr/bin/python update-haproxy.py --access-key='##############' --secret-key='###########################' --security-group='my-sg' --region='us-east-1'
INFO:root:no "--servicename" OR "--haproxy" arguments found, defaulting to restarting service haproxy
INFO:root:Getting instances for netadmin-sg.
INFO:root:Generating configuration for haproxy.
INFO:root:Comparing to existing configuration.
INFO:root:Existing configuration is outdated.
INFO:root:Writing new configuration.
INFO:root:Restarting haproxy.

Restarting haproxy haproxy                                                                                [ OK ]

The only issue is that when I vim the haproxy.cfg file the config hasn't changed. Is the config that is generated by the haproxy.tpl stored somewhere else? Do I need to change the location of the new haproxy.cfg file after it been generated? I apologies for all the questions but I feel that I am close to resolving this and any assistance would be appreciated.
Regards,
Idan.

Ok so the new haproxy.cfg file is created in the root directory of "haproxy-autoscale" just need to know how to get it created at /etc/haproxy/
Also the IP addresses in the new cfg file are presented as follow:
server i-00b1b79asd ip-192-168-1-2.ec2.internal
server i-04423e559s ip-192-168-1-23.ec2.internal
server i-0e3b675c6c ip-192-168-1-34.ec2.internal
server i-04a1439878 ip-192-168-1-10.ec2.internal
I thought it should be by ip address not dns name.
Regards,
Idan.

Ok, fixed the IP thing. instance.private_ip_address did the trick. Now just the location of the new cfg file that is created. If you could assist me with that I would be forever grateful.

It seems like I got everything to work but can only pull from one region. I tried declaring both regions as so:
user@ipaddress:/etc/haproxy$ sudo /usr/bin/python update-haproxy.py --access-key='##############' --secret-key='############################' --security-group='netadmin-sg' --region='us-east-1' --region='us-west-2'
I get:
an error when trying to do it for the west region.
[ALERT] 165/151159 (7359) : parsing [/etc/haproxy/haproxy.cfg:38] : 'server domainname.com' : invalid address: 'ec2.internal' in 'ec2.internal'
And the cfg file contains the west instances as follow:
server ipaddress.domainname.com ec2.internal domainname2.com domainname3.com domainname4.com <IP_ADDRESS>:443 check
It seems to be getting all dns names from west but its executing properly in east.
Any thought on:

How to execute the command to pull from both regions?
The error with the west instances?

Sorry I totally dropped the ball on this.

There is no option to run this with more than one region. It might be possible to do and I welcome any commits, but I don't really maintain this anymore so it's not something I personally can pursue.
Try just using one region at a time and see if you get the same errors.

Just following up to see if there's anything else I can help with before closing this.

Hi Mark,
No, everything is figured out! Thanks for all the help!
Regards,
Idan.

No problem.


Should we move from MySQL driver 5.1.46 to 8.0.11?

Should we move mysql-connector-java from 5.1.46 to 8.0.11?
Per their website:

MySQL Connector/J 8.0 is highly recommended for use with MySQL Server 8.0, 5.7, 5.6, and 5.5. Please upgrade to MySQL Connector/J 8.0.

The only concern I would have is if they built for a higher Java version than the lowest version Atlassian supports for Jira.

It depends on what version of mysql-connector-java Atlassian recommend.

This page says "f you are installing Jira, download the recommended MySQL driver JDBC Connector/J 5.1. "

Let's keep the current driver until something breaks or there is a new recommendation.

Final thought:
When the database technology group recommends for a new driver version then it's a suggestion from technology group to application developer to use the latest database driver.
It's the task of the application developer, e.g. Atlassian Jira, to use and test the drivers and recommend and/or package the database drivers.
It's not the task of the application user or administrator to jump to versions and let's be truthful here, rather clueless.
I would rather keep to recommendations here. Always open to discuss.


Update utils.py

This change will force the original finding, having a jira issue linked to it, to update the jira issue as well. Having it that way, the linked jira issue of the orignial finding will be re-opened as well.

@FallenAtticus Any thoughts on my comment? Will close this in a week otherwise.

I think if a finding gets reopened in JIRA, it makes sense to also reopen it in JIRA. Using save to jira is probably the generic approach to get the issue in jira updated from defect dojo.

@valentijnscholten doesn't that function reopen duplicates? I don't think duplicates should be pushed to JIRA. I may be misinterpreting here though.

This code is called when a new finding is imported that is a duplicate of an existing (original) finding, which is closed/mitigated. In this case the original gets reactivated. If that original has a jira issue linked, it makes sense to reopen that jira issue as well. But we can't just always say push_to_jira=True as it could create a new jira issue if there is none. Also this push to jira is not explicitly chosen by the user, so we may have to push only the status to JIRA and not overwrite the description etc by pushing from save()


Bing maps broken?

Noticed today that our ol3 doesn't render Bing maps.
The example seems also broken
http://twpayne.github.io/ol3/remote-vector/examples/bing-maps.html

It's working with the official one: http://openlayers.org/en/v3.15.0/examples/bing-maps.html

It can be a non (anymore) valid key.

The examples at http://twpayne.github.io/ol3/remote-vector/examples/ are very old and must not be used


Error when running using nodejs

i got this error when trying to deobfuscate a long javascript
i can give the javascript in private if want to check.
➜ npm run test

<EMAIL_ADDRESS>test
tsc && node dist/test.js

[2023-12-08T20:55:03.921Z]: Starting pass 1
[2023-12-08T20:55:03.923Z]: Executing UnusedVariableRemover
[2023-12-08T20:55:03.983Z]: Executed UnusedVariableRemover, modified false
[2023-12-08T20:55:03.984Z]: Executing ConstantPropgator
[2023-12-08T20:55:04.058Z]: Executed ConstantPropgator, modified true
[2023-12-08T20:55:04.059Z]: Executing ReassignmentRemover
[2023-12-08T20:55:04.111Z]: Executed ReassignmentRemover, modified true
[2023-12-08T20:55:04.111Z]: Executing DeadBranchRemover
[2023-12-08T20:55:04.150Z]: Executed DeadBranchRemover, modified false
[2023-12-08T20:55:04.150Z]: Executing ObjectPacker
[2023-12-08T20:55:04.178Z]: Executed ObjectPacker, modified false
[2023-12-08T20:55:04.179Z]: Executing ProxyFunctionInliner
[2023-12-08T20:55:04.238Z]: Executed ProxyFunctionInliner, modified true
[2023-12-08T20:55:04.238Z]: Executing ExpressionSimplifier
[2023-12-08T20:55:04.290Z]: Executed ExpressionSimplifier, modified true
[2023-12-08T20:55:04.290Z]: Executing SequenceSplitter
[2023-12-08T20:55:04.334Z]: Executed SequenceSplitter, modified true
[2023-12-08T20:55:04.334Z]: Executing ControlFlowRecoverer
[2023-12-08T20:55:04.363Z]: Executed ControlFlowRecoverer, modified false
[2023-12-08T20:55:04.379Z]: Executing PropertySimplifier
[2023-12-08T20:55:04.454Z]: Executed PropertySimplifier, modified false
[2023-12-08T20:55:04.454Z]: Executing ObjectSimplifier
[2023-12-08T20:55:04.498Z]: Executed ObjectSimplifier, modified false
[2023-12-08T20:55:04.499Z]: Executing StringRevealer
[2023-12-08T20:55:04.551Z]: Executed StringRevealer, modified true
[2023-12-08T20:55:04.551Z]: Starting pass 2
[2023-12-08T20:55:04.551Z]: Executing UnusedVariableRemover
[2023-12-08T20:55:04.593Z]: Executed UnusedVariableRemover, modified true
[2023-12-08T20:55:04.593Z]: Executing ConstantPropgator
[2023-12-08T20:55:04.632Z]: Executed ConstantPropgator, modified false
[2023-12-08T20:55:04.632Z]: Executing ReassignmentRemover
[2023-12-08T20:55:04.671Z]: Executed ReassignmentRemover, modified false
[2023-12-08T20:55:04.672Z]: Executing DeadBranchRemover
[2023-12-08T20:55:04.703Z]: Executed DeadBranchRemover, modified false
[2023-12-08T20:55:04.704Z]: Executing ObjectPacker
[2023-12-08T20:55:04.742Z]: Executed ObjectPacker, modified false
[2023-12-08T20:55:04.742Z]: Executing ProxyFunctionInliner
[2023-12-08T20:55:04.767Z]: Executed ProxyFunctionInliner, modified true
[2023-12-08T20:55:04.767Z]: Executing ExpressionSimplifier

Fatal error in , line 0
Fatal JavaScript invalid size error 169220804

#FailureMessage Object: 000000ED0FDF4230
1: 00007FF6645E027F node_api_throw_syntax_error+175631
2: 00007FF6644F60AF v8::CTypeInfoBuilder::Build+12543
3: 00007FF6653866D2 V8_Fatal+162
4: 00007FF664EA1505 v8::internal::FactoryBasev8::internal::Factory::NewFixedArray+101
5: 00007FF664D26B83 v8::internal::FeedbackNexus::ic_state+65795
6: 00007FF664D45700 v8::Context::GetIsolate+15600
7: 00007FF664B91CE0 v8::internal::CompilationCache::IsEnabledScriptAndEval+25952
8: 00007FF66509EB61 v8::internal::SetupIsolateDelegate::SetupHeap+558193
9: 00007FF5E532C2C7

Looks like an out of memory error, is the file very large?

the original file is only 32kb. when formatted it is 36kb. not really large but it stucked trying to process in the website and in nodejs

Can you upload your script to Pastebin and I will take a look


range() and aggregateWindow() with right stamps is producing time shifts when using multiple times

Steps to reproduce:
Its not a runtime bug, its a conceptual problem. The problem is that the range filter is always including the start parameter and excluding the stop paramters (time >= start && time < stop). This query is not working with right stamped aggrgeates. The query must be (time > start && time <= stop) for right stamped data. But range() has no parameter to change the behavior. and aggregateWindow() is right stamped by default.
Let me explain the problem with some example. Lets say we have some raw data and we have aggregates for 1min resolution and the average. This will lead to the following time series:
...
01:00:00 -> (data for 00:59:00 - 01:00:00)
01:01:00 -> (data for 01:00:00 - 01:01:00)
01:02:00 -> (data for 01:01:00 - 01:02:00)
01:03:00 -> (data for 01:02:00 - 01:03:00)
01:04:00 -> (data for 01:03:00 - 01:04:00)
01:05:00 -> (data for 01:04:00 - 01:05:00)
...

Everything is fine until now. But what if we have another aggregate on this data, also right stamped with the normal usage of range(). And lets say 15min resolution:
...
01:00:00 -> (data for 00:44:00 - 00:59:00)
01:15:00 -> (data for 00:59:00 - 01:14:00)
01:30:00 -> (data for 01:14:00 - 01:29:00)
...

Now we have a timeshift of 1min. Every record is not representing the time range of (time-resolution until time) its 1 Minute off.
Lets now use the same query again (we aggregate 15min again to a 15 resolution). Just to show the problem. I had this problem because my raw data was sometimes pre aggregated, sometimes not.
...
01:00:00 -> (data for 00:29:00 - 00:44:00)
01:15:00 -> (data for 00:44:00 - 00:59:00)
01:30:00 -> (data for 00:59:00 - 01:14:00)
...

Now we have a time shift of 16 minutes
The reason of this problem ist that if you want to aggregate data with right stamps (and you are assuming all aggregates are right stamped) you have to use a range filter like this: time > start && time <= stop. If you are only using left stamped aggregates the filter must be time >= start && time < stop.
Workaround
There are two workaround:

Use left stamped aggregates allways timeSrc must be set to _start in the aggregateWindow() function
add one nanosecond to start and stop in the range() filter

https://www.influxdata.com/blog/the-plan-for-influxdb-3-0-open-source/#heading4


Your license file doesn't list google as the owner, it just says "[name of copyright owner]"

You mean in the appendix of the license file?  I think those are instructions for others on how to use the apache license.  But I might be missing something?

I think we are good here, so closing this.  But please reopen if I misunderstood.


Link to sampler and propagation config in OTel operator docs

https://github.com/open-telemetry/opentelemetry-operator/pull/1442 implements a gap in configuration docs for the otel operator. We should link to these in the operator docs.
Alternatively, we can work to pull these docs into the operator docs on the website.

This is still valid, I would prefer to have this not linked but copied (wdyt @open-telemetry/operator-approvers ?)

id be happy for us to copy it over, I believe we want to centralize docs on the docs site moving things over from our own repo.


Is wavelength bspline required when defining emissivity data?

Maybe I'm setting up my emissivity data wrong, but I'm getting the following error when running coll.compute_diagnostic_signal:

The following code is stuff I ripping from tofu_sparc so things might have changed.
When I define my (R,Z) mesh and bsplines, I do:

When I define my (wavelength) mesh, I do:

When I define my (emissivity) mesh, I do:

When I define my wavelength mesh, I had commented out making a bspline since it wasn't needed, but I guess now it is? What I'm guessing I should do to fix things is

replace my commented out wavelength bspline with:

coll.add_bsplines(
            key='nlamb_'+key_diag,
            deg=1
            )

to match how I did it with the (R,Z) mesh and to maintain the reference

replace the reference in the emissivity data to ref=('m0_bs1','nlamb_'+key_diag+'_bs1')

Does that sound right? What do you think?

So yes, I remember I had started re-working that part and may have made spectral bsplines necessary without noticing.
I'd advise you basically un-comment the spectral mesh creation, and instead comment out the add_ref() and add_data().
coll.add_mesh_1d(
     key='mlamb_'+key_diag,
     knots=lamb*1e-10,
     deg=1,
    units='m',
)

Then just declare the spectral mesh as a reference for the emissivity
coll.add_data(
    key='emiss_'+key_diag,
    data=emiss2d_tmp_m0,
    ref=('m0_bs2', 'mlamb_bs1'),
    units='ph/s/m3/sr/m',
)

Sounds good! I'll test a low-resolution version and let you know if it works out

Seems like things are working now. Thank you very much!