Underscore is no longer supported in URL host name!

Home Assistant release (hass --version):
0.33.0
Python release (python3 --version):
Python 3.5.2
Component/platform:
switch/rest
Description of problem:
Today, after upgrade to 0.33.0 all my esp8266 components disappeared. The default DNS name of every arduino-flushed esp8266 (like NodeMCU) is something like 'esp_1e1989.' (with HEX device id, same as in MAC address). Now it appears like home-assistant can no longer handle underscore (_) in the name.
Expected:
Should work as before.
Problem-relevant configuration.yaml entries and steps to reproduce:
switch:
  - platform: rest
    resource: http://esp_1e1989./led
    name: esp_1e1989_led

Traceback (if applicable):
ERROR:homeassistant.components.switch:Error while setting up platform rest
Traceback (most recent call last):
  File "C:\Users\_smarthome_svc\Python35\lib\site-packages\requests\packages\idna\core.py", line 327, in uts46_remap
    raise IndexError()
IndexError

During handling of the above exception, another exception occurred:

Traceback (most recent call last):
  File "C:\Users\_smarthome_svc\Python35\lib\site-packages\requests\models.py", line 370, in prepare_url
    host = idna.encode(host, uts46=True).decode('utf-8')
  File "C:\Users\_smarthome_svc\Python35\lib\site-packages\requests\packages\idna\core.py", line 340, in encode
    s = uts46_remap(s, std3_rules, transitional)
  File "C:\Users\_smarthome_svc\Python35\lib\site-packages\requests\packages\idna\core.py", line 332, in uts46_remap
    _unot(code_point), pos + 1, repr(domain)))
requests.packages.idna.core.InvalidCodepoint: Codepoint U+005F not allowed at position 4 in 'esp_1e1989.'

During handling of the above exception, another exception occurred:

Traceback (most recent call last):
  File "C:\Users\_smarthome_svc\Python35\lib\site-packages\homeassistant\helpers\entity_component.py", line 150, in _async_setup_platform
    entity_platform.add_entities, discovery_info
  File "C:\Users\_smarthome_svc\Python35\lib\asyncio\futures.py", line 361, in __iter__
    yield self  # This tells Task to wait for completion.
  File "C:\Users\_smarthome_svc\Python35\lib\asyncio\tasks.py", line 296, in _wakeup
    future.result()
  File "C:\Users\_smarthome_svc\Python35\lib\asyncio\futures.py", line 274, in result
    raise self._exception
  File "C:\Users\_smarthome_svc\Python35\lib\concurrent\futures\thread.py",line 55, in run
    result = self.fn(*self.args, **self.kwargs)
  File "C:\Users\_smarthome_svc\Python35\lib\site-packages\homeassistant\components\switch\rest.py", line 55, in setup_platform
    requests.get(resource, timeout=10)
  File "C:\Users\_smarthome_svc\Python35\lib\site-packages\requests\api.py", line 70, in get
    return request('get', url, params=params, **kwargs)
  File "C:\Users\_smarthome_svc\Python35\lib\site-packages\requests\api.py", line 56, in request
    return session.request(method=method, url=url, **kwargs)
  File "C:\Users\_smarthome_svc\Python35\lib\site-packages\requests\sessions.py", line 474, in request
    prep = self.prepare_request(req)
  File "C:\Users\_smarthome_svc\Python35\lib\site-packages\requests\sessions.py", line 407, in prepare_request
    hooks=merge_hooks(request.hooks, self.hooks),
  File "C:\Users\_smarthome_svc\Python35\lib\site-packages\requests\models.py", line 302, in prepare
    self.prepare_url(url, params)
  File "C:\Users\_smarthome_svc\Python35\lib\site-packages\requests\models.py", line 372, in prepare_url
    raise InvalidURL('URL has an invalid label.')
requests.exceptions.InvalidURL: URL has an invalid label.

Additional info:
Please, note that this is default DNS name, this is not my code and I have no intention to put additional custom code for handling DNS. I pretty like how it works.

I been on 33.1
I've tried downgrade. 33.3 looks same, 33.2 & 33.1 now looks like this:
ERROR:homeassistant.components.switch:Error while setting up platform rest
Traceback (most recent call last):
  File "C:\Users\_smarthome_svc\Python35\lib\site-packages\homeassistant\helpers\entity_component.py", line 148, in _async_setup_platform
    entity_platform.add_entities, discovery_info
  File "C:\Users\_smarthome_svc\Python35\lib\asyncio\futures.py", line 361,in __iter__
    yield self  # This tells Task to wait for completion.
  File "C:\Users\_smarthome_svc\Python35\lib\asyncio\tasks.py", line 296, in _wakeup
    future.result()
  File "C:\Users\_smarthome_svc\Python35\lib\asyncio\futures.py", line 274,in result
    raise self._exception
  File "C:\Users\_smarthome_svc\Python35\lib\concurrent\futures\thread.py",line 55, in run
    result = self.fn(*self.args, **self.kwargs)
  File "C:\Users\_smarthome_svc\Python35\lib\site-packages\homeassistant\components\switch\rest.py", line 48, in setup_platform
    body_on.hass = hass
AttributeError: 'str' object has no attribute 'hass'
WARNING:homeassistant.components.recorder:Ended unfinished session (id=44 from 2016-11-20 21:33:09.064246)
WARNING:homeassistant.components.recorder:Found unfinished sessions

So, downgrade does not help to recover from this state... Not sure if I have a good backup

You last bug is fix in 0.32.3 and you first bug, remove the dot at end of hostname.

I can not do that, dot is part of the host name and it works only with dot Both in browser and in previous hass. Note the traceback says "codepoint 5F at position 4"

Look like '_' is realy not valid: https://github.com/kjd/idna/issues/17

Can you test my PR?

You can temporarily downgrade your requests package to workaround this bug with pip3 install requests==2.11


CI:add xattr test

Codecov Report

Merging #1671 (88e12b1) into main (6f4200f) will increase coverage by 0.05%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main    #1671      +/-   ##
==========================================
+ Coverage   61.80%   61.86%   +0.05%
==========================================
  Files         133      133
  Lines       22607    22607
==========================================
+ Hits        13973    13986      +13
+ Misses       7074     7056      -18
- Partials     1560     1565       +5

Impacted Files
Coverage Δ

pkg/vfs/reader.go
84.67% <0.00%> (-1.28%)
:arrow_down:

pkg/meta/sql.go
67.18% <0.00%> (-0.21%)
:arrow_down:

pkg/object/object_storage.go
76.78% <0.00%> (ø)

pkg/sync/sync.go
44.99% <0.00%> (+0.54%)
:arrow_up:

pkg/sync/cluster.go
41.78% <0.00%> (+9.85%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6f4200f...88e12b1. Read the comment docs.


Feature request: Allowing to set dual stack ip's when creating new network

Currently it is not possible to set an IPv4 and IPv6 address simultaneously:

It is either or at the moment.

See https://github.com/portainer/portainer/pull/3717 as we have just recently added support for IPv6, which is in portainerci/portainer:develop, and will be released as part of Portainer 1.24.0


Add in safety measure to the -u flag to prevent accidental cache wipe

I recently wanted to look at an RSS feed without having to go into my url file and manually add in the feed, so I took a quick look at the man page and ran the command newsboat -u <(echo "foo.bar/rss"). After doing this and returning to using newsboat as normal I noticed that the entire cache was wiped.
Some methods to prevent others from making this mistake such as including a warning in the man / help / documentation should be done at a minimum. Though preferably a different cache file should be used for each different URL file (or a similar fix.)

Sorry you've lost data! Hope you got backups.
The "First Steps" section of the docs mention cleanup-on-quit already, but I agree that we could probably do better than that. I remember https://github.com/newsboat/newsboat/issues/1963 where we discussed adding a flag that acted like all of -u/-c/-C at once, but that swims against the XDG practice of putting different kinds of files into different directories. Any other ideas?

Luckily I do have a relatively recent backup!
Any of these methods could work in combination or on their own to prevent people like me from making this mistake:

Make it clear in the --help and man page that -u will overwrite the cache without also using -c
Make -u put the cache file in /tmp or use no cache unless a cache file is specified with -c
Default cleanup-on-quit to false when using -u (unless explicitly specified in the users config)
Adding a separate way to look at a feed without using -u, such as reading feeds from standard input.

Related: #1183

-u urlfile seems doesn't support here-string:
newsboat -u <<<'http://url_of_feed'
failed


for Checkout, two questions to discuss

How to store guest’s order information (it is not going to database now, so we don’t have an order id) (Just from a presentation perspective, it doesn’t matter whether we save it or not as we are not going to show the database? )

How to close the order when user click on checkout (mark the status from open to close)
My thought is when check out - - in the backend, we just update the order from open to close (if it is a guest, we can also just create an order with the status of close)

My thought is when check out - - in the backend, we just update the order from open to close (if it is a guest, we can also just create an order with the status of close)

Put this issue under comment for  another issue 'checkout'


Fix nested calls between @Lazy static properties

Variable expressions lost owner class context cause they are wrapped into the holder class. Now variable initialization is handled by a private static method in the owning class.

Looks good on initial glance.
Just confirming, non-static nesting was working but static not?
Also, has a Jira been created to track this?

It only affects to static properties since inner class is used as wrapper of variable for lazy initialization.
I have just reported the issue (GROOVY-7872).

merged, thanks!


Time to re-generate spreadsheets ???

Hi Augustine,
Once we have made the corrections that have been under discussion, I think it would be a good idea
to regenerate (and up the version number) on all the spreadsheets.
There have been significant changes.
If we do that, it may not be necessary to manually update the RIT spreadsheet, since the data online is correct...
But, for example, the changes we are making to SELF will have implications for the RIT spreadsheet, but not only that one!  E.g.

After you regenerate the spreadsheets, whenever that happens, as before, I will need to manually edit before we re-post.
Let's discuss when you have a chance...   THANKS !!!

When we do regenerate the spreadsheets, we should use the system information about class labels.
Up until now, I was manually editing the class label column.  And, unfortunately, I'm discovering that there are some inconsistencies, due to the fact that some decisions got made along the way.  For example, I was inconsistent in merging #DOG and DOG under the class label DOG.  (sigh).  There is also an inconsistency in whether HOME+WORK or HOMEWORK was used as the class label.
The main issue is that if we are going public with our current system, we probably don't want to make these changes to the system right away, because departing from the data that Yang used for training will introduce bigger problems...
There are also at least a few signs that we are in principle able to recognize, but which we do not seem to have represented on the DAI.  We could get Carey to produce those signs, as we did with TRIANGLE, for example.  These include, so far, SURGERY+AGENT
There is an issue with the class labels for index signs (IX and POSS), which we should resolve when we make these other changes...  most likely by changing some of the main entry labels, so that we don't need to rely on variant labels for determination of class labels.

FWIW, these are the changes that I think should be made with respect to existing spreadsheets.
4 occurrences in the DSP Sentences file, where the main entry #DOG should be assigned to the class label DOG (rather than #DOG).
In the WLASL spreadsheet, all main entries = HOME+WORK or HOME_2+WORK should have class labels HOMEWORK, rather than HOME+WORK.
There is one instance in the DSP signs spreadsheet and one in the DSP sentences spreadsheet where main entry LOBSTER should be assigned to class label CRAB/LOBSTER (rather than LOBSTER). There are also 8 instances of main entry LOBSTER_3 in the RIT signs file that should also be assigned to class label CRAB/LOBSTER.
There is one instance of main entry SIT+DCL:C\couch shaped object"" in the DSP signs file, and one instance of SIT+DCL:crvd-U\couch shaped object"" in the ASLLVD spreadsheet, both of which should be assigned to class label COUCH.
There are several instances of main entry TIME+DCL\circular object"" (4 in the ASLLVD spreadsheet and 1 in the DSP signs spreadsheet) that should be assigned to class label CLOCK.
There is 1 occurrence of WANT_3+NEG in the DSP sentences file that should be assigned to class label WANT+NEG.
I don't know why this looks different in the ASLLVD spreadsheet, as compared with the WLASL spreadsheet:

There may be other similar inconsistencies in the spreadsheets we are generating...

Screenshots from above
DSP sentences file - corrections
Class label should be DOG

=========
Class label should be CRAB/LOBSTER

=========
Class label should be WANT+NEG

WLASL spreadsheet corrections
Class label should be HOMEWORK

Corrections to the DSP signs file
Class label should be CRAB/LOBSTER

===========
Class label should be COUCH

===========
Class label should be CLOCK

Corrections to RIT signs file
Class label should be CRAB/LOBSTER

Corrections to ASLLVD file
These should all have class label COUCH

======
These should all have class label CLOCK

ASLLRP corrections
Class label should be DOG


Provide pluggable authorization handlers

A service may want to restrict methods that a client can invoke.  For example, requiring a client to have an OAuth access token with certain scopes.
Shelf middleware could be used in front of the rpc handler - but this means that every method would need to allow the  same set of scopes.
A pluggable handler would be useful. Perhaps allowing access to the shelf context in case HTTP headers or body need to be introspected.
This might be extended to a more general purpose mechanism - not just for authorization. Provide  pre/post method interception handlers.
Not sure how hard it would be to implement, but annotations like this would be really sweet:
@ApiMethod(method: 'POST', path: 'resource/{name}/update', scopes: ["http://foo.com/update"])

Hi Warren,
I will look into this. In the case of extending the ApiMethod annotation I expect you would like the scopes to be validated by the framework, right?
Cheers,
/gustav

Yes - exactly!

This would also be great, since the generated discovery API document should include the scopes necessary for each request.
Is there an ETA for this feature? I am struggling to build an API with dart-lang/rpc that provides proper authentication (I want to use JWT).

Hi Matthias,
Would it be possible for you to use the shelf package in conjunction with the RPC package to achieve this. E.g. something like how the logging is done in the RPC example, https://github.com/dart-lang/rpc-examples/blob/master/bin/shelf_sample.dart.
Basically you setup a shelf pipeline and add the JWT authentication handler as middleware?
/gustav

That does sort of work - but it is not optimal.
The example above is for authentication. Assuming you want all methods to be protected, it is probably OK to have a blanket shelf filter that protects everything.
But what if you want some methods to be "public" (i.e. not protected).  You have to do some kind of filtering in shelf -which gets really awkward.
And authorization will almost always be finer grained. EG: "Admins" can call this method, but not normal users.  To do that in shelf you are going to need a parallel set of URL filters that mirror your RPC methods.  That seems really kludgy.
Being able to filter at the method level on scopes makes this much simpler to implement vs. shelf filters.
I am guessing that people will want a general purpose method of  pre and post  method interceptors. If you had such a mechanism you could implement authorization scope filters with a plugin.

Thanks for your reply @wibling.
That's how I do it at the moment:
  var apiRouter = shelf_route.router()
    ..add('/api/v1/account', null, apiHandler, exactMatch: false, middleware: loginMiddleware)
    ..add('/api', null, apiHandler, exactMatch: false)
  ;

Although that works it creates a problem: the authorization and validation is done on a path level. So if, for some reason, I move my account routes to another path (eg: /api/v1/user) my loginMiddleware will suddenly become inactive.
It also becomes a bit difficult to add different scopes for different routes, since I suddenly need to maintain the router setup, with the different paths, and make sure that they are in sync with the routes defined in my API.

Perhaps a new issue should be created?
Define a plugin mechanism for RPC.   The plugins should allow for pre and post method handlers, and should give access to the current request context. Perhaps the plugin should be able to access annotations on the method.
Such a plugin could be used to implement things like scope handlers.

I think that this could be a really great features too, it could be a really great mecanisme to implement authentification, check access level etc.

<EMAIL_ADDRESS>I see your points. I am myself a bit preoccupied with another project at
the moment.
Faisal is this something you are interested in and have time to look at?
/gustav
On Mon, Aug 31, 2015 at 6:52 PM, Vink<EMAIL_ADDRESS>wrote:

I think that this could be a really great features too, it could be a
really great mecanisme to implement authentification, check access level
etc.
—
Reply to this email directly or view it on GitHub
https://github.com/dart-lang/rpc/issues/31#issuecomment-136426930.

@wibling Yep I'll take this task on. Been wanting this too.

Great!
/gustav
On Wed, Sep 2, 2015 at 3:56 PM, Faisal Abid<EMAIL_ADDRESS>wrote:

@wibling https://github.com/wibling Yep I'll take this task on. Been
wanting this too.
—
Reply to this email directly or view it on GitHub
https://github.com/dart-lang/rpc/issues/31#issuecomment-137090033.

Update on this, been super busy with work, but it's coming!

@FaisalAbid any update? :)

Maybe a small POC so others can add to it?

The first great addition would be to allow scopes to be defined on the ApiMethod. There wouldn't need to be any additional handling since then, at least, we could write middleware that does authentication or checking for given scopes.

Hello) Any updates? @FaisalAbid


403 error

Hey. Nice script thanks . I just installed but for some reason a lot of sites I try produce a 403 error. I've tested other proxy and they seems fine so I know it's not an ip block . Could you help me please

Cunt


Migrate to standard Java enumerations vs @IntDef / @StringDef

I think we should consider this to remove the dependency on Android SDK annotations for features that are readily available in the Java language itself.
This was an optimization we initially based of did but ProGuard will clean this up already.
From the ProGuard Manual
class/unboxing/enum

Simplifies enum types to integer constants, whenever possible.

Also this tweet from Jake Wharton supports the best practice might not have much purpose anymore.

Both ProGuard and R8 will optimize trivial enums into ints. They were never inefficient, just some FUD spread by the Android team. Kotlin's enums are the same as Java's in the bytecode so there's no difference.

/cc @jparise @RicoYao @ay8s

Agree. This was bad advice to begin with (we do the same in our own codebase and it should be cleaned up.)

@shashachu  👋 ! Thanks for the input, I'll migrate this soon

Fixed!


wrangler publish

This is the parent issue tracking the implementation of wrangler publish.
Usage
In it's simplest form, you can write a worker, say at index.js, and run: wrangler publish index.js --name myscriptname, and -

it'll 'bundle' your script into a single file, and publish it to myscriptname.<your subdomain>.workers.dev
Much like wrangler dev, we aim to provide a default experience that's immediately useful, so you shouldn't have to setup a bundler/compiler for most usecases.  So, you can use modules from npm, create separate modules, use react (todo: --jsx <reference> for other libraries), use typescript, and it should all Just Work. (more details on the tracking issue for wrangler dev)
Much like wrangler dev, wrangler publish will also automatically infer whether your script is in the service-worker format or the newer ES modules format.
You can publish to your own domain/zone with wrangler publish <script> --name <name> --zone somedomain.com --route "somedomain.com/path/*"

You'll note that you can pass a domain directly to zone, instead of a zone_id. wrangler publish should work with both forms of configuration.

A remaning task here is to implement custom builds. Tracking that here https://github.com/cloudflare/wrangler2/issues/120 and closing this issue.


Improve useFloating hook

useFloating hook
Refinements
comments cleanup and reactiveness
Box module, example broke :(
cleanup
format lint
improve useFloating
update example

@abdel-17 Can you keep the file structure similar to React's floating ui port? the create file doesn't make much sense to me personally.
So lib/hooks/use-floating.svelte.ts

sure was just experimenting with keeping the types next to the hook

LGTM


[broker] change getWorkerService method to throw UnsupportedOperationException

Fix #9633
Motivation
When we set functionsWorkerEnabled=false in broker.conf, broker don't support management function of functionWorker.
But when we try to appy those method. Broker will throw NullPointerException  instead of throwing a more user friendly error that explain the problem.
This PR is trying to fix it.
Modifications

Throw an exception instead of returning null
Add unit test for normal and abnormal conditions

Documentation

Does this pull request introduce a new feature? ( no)

/pulsarbot run-failure-checks


Improper converter check

Can someone please check this converter check in topology.py?
Shouldn't it be a if converter is None: ?
Or am I just missing something in the flow?

Hi @shubh0508 Yes it definitely looks like the case!  Would you like to submit a PR fixing it? We value you contribution! :)


missing chemical treats disease for tamoxifen

q={
  "message": {
    "query_graph": {
      "nodes": {
        "n00": {
          "category": "biolink:Disease"
        },
        "n01": {
          "category": "biolink:ChemicalSubstance",
          "id": "CHEBI:41774"
        }
      },
      "edges": {
        "e00": {
          "predicate": "biolink:treats",
            "subject": "n01",
            "object": "n00"
        }
      }
    }
  }
}

No answers

This has answers as of #83.


plural_or_not method return "s" for value 0

robot/utils/misc.py
method plural_or_not  return "s" for value 0

Could you clarify what's the problem?

When ask method plural_or_not for values  (0) or (-1) return "s" ,
in example message size is
-1 element plural_or_not(-1) -> "-1 elements", and i think it should be
"-1 element"

I'm not a native English speaker, but AFAIK you need to use the plural form with zero items.

OK, maybe I jump the gun, its more complex then i was previously expected
there is zero element
http://mathworld.wolfram.com/ZeroElement.html
also
https://www.grammar-monster.com/lessons/singular_plural_number.htm
I think it should stay as is.

Yeah, the behavior with zero shouldn't change. The situation with -1 is a lot less clear, but apparently it is more often considered singular. I'm fine that being changed.

update in code #3461

I commented the PR. Can you please also update the issue title?


Implement Skyhash 2.0 spec

This implements the Skyhash 2.0 spec documented in skytable/docs#32.

Ready to go for first Skyhash 2.0 iteration. Merging in


Convert platform-specific path delimiters to native platform delimiters.

Use a more elegant method of passing exec and its arguments to child_process.spawn()
Also:

Convert Windows path delimiters to Unix path delimiters on Unix platforms.
Convert Unix path delimiters to Windows path delimiters on Windows platforms.

Could you also add a test for this? It's been broken a few times already.

I'm still working on this.

I've decided to change this and just use a more elegant way of passing the exec and args to the child process.
Judging by the way you've wrote your unit tests, the sh option is only supposed to be true if the cmd string is a series of bash/shell commands, and not the name of a build script or build command.

Well.. if sh is true. The command will be spawned with a shell (e.g. bash or cmd.exe.) If it is false the OS will directly exec the command.
Exec has a limitation in that it doesn't support arguments "in the command". Other than that either is fine.
I tend to avoid sh because it feels faster to not start a shell and then spawn the command in there - but I don't think it has any noticeable impact on execution time in most cases.

Closing as inactive. Please open a new PR if you intend to keep working on this.


PHP7 compatibility

How do you use Sentry?
Sentry SaaS (sentry.io)
SDK version
^4.3
Steps to reproduce
DebugStdOutLogger and DebugFileLogger are having this method signature:
public function log($level, \Stringable|string $message, array $context = []): void

This isn't compatible with PHP7
Expected result
The code should be either compatible with "php": "^7.2|^8.0" (as defined in composer.json) or the php requirement in composer.json should remove ^7.2
Actual result
Syntax error when using within PHP7.

The logger we provide is only compatible with the current PSR3 logger interface. We will add additional loggers in the future, for now, please create your own.

On a site with PHP PHP 8.0.28 and composer 2.2.18, after installing sentry/sentry 4.4.0, I'm getting the error:
Composer detected issues in your platform: Your Composer dependencies require a PHP version ">= 8.1.0".

Composer detected issues in your platform: Your Composer dependencies require a PHP version ">= 8.1.0".

These are issues bound to your dev environment or other dependencies: your last execution of Composer was done under PHP 8.1 (probably locally) and you produced a composer.lock for that version. Use a proper local dev environment with the right version of PHP to fix it.

The logger we provide is only compatible with the current PSR3 logger interface.

@cleptric the PSR-3 has been updated that way, but you still may use the previous signature (with wider argument types, but stricter return type) and maintain backward compatibility, see PSR Evolution for further details. As a practical example, see: https://3v4l.org/GivGp


As phono user I want to control components reuse on the pipeline level, so I can decide how to use component.

SingleUse type should not be referenced from components, but should be accessed via pipeline.

This is not needed as it's determined by the user how pipes are executed.


Provide a sync way to check if an app is run inside gnosis safe

We got a request for easy detection if the app is loaded as a safe app that doesn't require loading the SDK - in the web version, one can use desktop.referrer, but not on the desktop. It could be done with the query params.

Suggestion from @taylorjdawson

You could add a data- attribute to the iframe element and then I believe dapps could access this to determine if they are in a gnosis safe context

Since there is a requirement to auto-login with gnosis (if you want to release your app into gnosis apps) I would expect the straight-forward way how to detect the gnosis provider availability. If I am trying to getInfo() from the safe, it failed on CORS, which you can't handle by try-catch statement. So what is the recommended approach to detect it? Because I've inspected the React library (which I don't use), where it's used try-catch as well, so probably it has to get failed.

getInfo() uses .postMessage and not http, it cannot fail with a CORS request.
Could you share the code? The problem must be somewhere else

I am getting this err when I am trying to get safe info out of the iframe

Oh, srry. it is probably trouble with Sentry integration.... :/

Ok, so the error is not related to the gnosis safe info. But when I am trying to get safe info, there is no error, but the app is just stuck.

Ok, so the error is not related to the gnosis safe info. But when I am trying to get safe info, there is no error, but the app is just stuck.

could you share the code?

I just checked, and other apps are working, so we'd need a production case to check it.

The code is very simple, before I mount the app I am waiting for this try-catch statement. And it looks that the Promise is never resolved.
try {
      const gnosisSdk = new SafeAppsSDK()
      const safeInfo = await gnosisSdk.safe.getInfo()
      return safeInfo
    } catch (e) {
      console.log('Gnosis Safe is not detected', e)
    }

ok, thanks

Hi, this feature would be useful for me: I work in an App that uses Gnosis, but 99% of our users don't use a multisig, so this is for very limited users. We also use web3js, but given we install @gnosis.pm/safe-apps-web3-react, it brings the SDK as a dependency, which also brings its own copy of ethers package, which is huge.
I understand that these packages are required, but I'd like to be able to know if I'm in Gnosis context so I can only load them in these scenarios, and not for all users. Thanks!

Hi, this feature would be useful for me: I work in an App that uses Gnosis, but 99% of our users don't use a multisig, so this is for very limited users. We also use web3js, but given we install @gnosis.pm/safe-apps-web3-react, it brings the SDK as a dependency, which also brings its own copy of ethers package, which is huge.
I understand that these packages are required, but I'd like to be able to know if I'm in Gnosis context so I can only load them in these scenarios, and not for all users. Thanks!
edit:
currently, to detect if I'm in Gnosis context, I use
const { connector: currentConnector } = useWeb3React()
if (currentConnector instanceof SafeAppConnector) {

but by importing SafeAppConnector I get the whole SDK as mentioned above

There's an async approach above that may help. Unfortunately, synchronous is not possible because browsers do not have such a mechanism

It could be done with the query params.

I've just got reminded that it's possible with query params @dasanra

how's the query params approach?
The async approach still requires importing SafeAppsSDK, which I think still implies loading the entire SDK even for those users that are not in gnosis, which is the problem that I want to avoid in the first place

Query params approach isn't possible at the moment. If you import the SDK only when the app is loaded in an iframe, the chances are high that the iframe is coming from the safe

Hey all!
Wondering if anyone has found a definitive solution to this since. We're having this exact problem now — we want to support being a Safe App in our frontend, but also have the same app support standalone usage.
The solution linked by @mikhailxyz works, but I really don't like the idea of delaying our app load by 200ms for everyone, especially given we expect the vast majority of sessions to not be within a safe.
I can also imagine making an environment variable that puts the app into "safe mode" and deploying our app twice — once with it on, once off (for the main deployment). But this just seems like a lot of effort.


Delete API endpoint

It would be nice to have an API endpoint to delete subdomain records that are no longer required.
Example:
POST /delete
{
    "subdomain": "8e5700ea-a4bf-41c7-8a77-e990661dcc6a"
}

I personally prefer keeping the API as small as possible, and as the accounts take so very little storage space I see no urgent need for the endpoint. That said, I'm not strictly against this, and would probably accept a PR implementing the functionality.

I'd be happy to implement this, but it doesn't seem like there's much demand so I'll leave it for now.

I think this would be very useful, especially if you have a lot of certificates which do the validation via acme-dns. I'll implement this and create a pull request.

@webcompas  but why would you delete them? Do people create lots of subdomains that they don't need long term?

Yes, at least in my case there are many testing systems which partially exist only for a short time. So we would like to keep the database clean from so many unused subdomains. As this isn't a big deal to implement I don't see a reason why this feature shouldn't be added.

Please merge my pull request #209


When in stacked mode, the export/details button are not aligned with the title of the active object

Closed by #38


[BUG] TypeError for ComposableTimeSeriesForestClassifier

I was trying to follow the tutorial for "Univariate time series classification with sktime" but ran into an error with the time series forest classifier ComposableTimeSeriesForestClassifier. Copied the code exactly, everything was fine for a single time series tree.
Code:
tsf = ComposableTimeSeriesForestClassifier(
    estimator=time_series_tree,
    n_estimators=100,
    criterion="entropy",
    bootstrap=True,
    oob_score=True,
    random_state=1,
    n_jobs=-1,
)

Error:
TypeError                                 Traceback (most recent call last)
<ipython-input-25-a9421957ffb2> in <module>()
      7     oob_score=True,
      8     random_state=1,
----> 9     n_jobs=-1,
     10 )

TypeError: Can't instantiate abstract class ComposableTimeSeriesForestClassifier with abstract methods _set_oob_score_and_attributes

(Google Colab, no GPU/TPU)

The problem still exists

The problem still exists

Hey @Jackxiini
Please could you give us a bit more information so we can look into it?
Specifically:

What version of sktime are you using?
Please can you give us some example code snippets that you're using so we can reproduce the issue.
What python version are you using?

@tonybagnall, sounds like it didn´t get resolved? Reopening until we´ve either confirmed it´s resolved or validated the reappearance of the bug.

this example is no longer in the notebooks, but I just tested this and it works fine.
from classification.compose import ComposableTimeSeriesForestClassifier
from datasets import load_gunpoint
from sktime.transformations.panel.summarize import RandomIntervalFeatureExtractor
from sklearn.tree import DecisionTreeClassifier
from sklearn.pipeline import Pipeline
import numpy as np
steps = [
(
"extract",
RandomIntervalFeatureExtractor(n_intervals="sqrt", features=[np.mean, np.std])
),
("clf", DecisionTreeClassifier())
]
time_series_tree = Pipeline(steps)
trainX, trainY = load_gunpoint(split="train")
testX, testY = load_gunpoint(split="test")
tsf = ComposableTimeSeriesForestClassifier(
estimator=time_series_tree,
n_estimators=100,
bootstrap=True,
oob_score=True,
random_state=1,
n_jobs=-1,
)
tsf.fit(trainX, trainY)
if tsf.oob_score:
print(tsf.oob_score_)
print(tsf.score(testX,testY))
so I'm going to close this issue.


Update heap-sort.cpp

This works too!!
Have a look

Make this pull request by creating a different file and name it as HeapSort1.cpp!! As the previous one doesn't require changes.

Hey Atul,
This is kind of a personal mail.
May I ask are you from JECRC University?
On Thu, Oct 1, 2020 at 11:11 AM Atul Sharma<EMAIL_ADDRESS>wrote:

Merged #17 https://github.com/Iltwats/hacktoberfest/pull/17 into main.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/Iltwats/hacktoberfest/pull/17#event-3827595167, or
unsubscribe
https://github.com/notifications/unsubscribe-auth/AMJG2S6KWASB5LOSM4Z4A2LSIQI7VANCNFSM4R76JKUQ
.


Binary Tree/Mirror of a Binary Tree (JAVA)

[x] I searched or browsed the repo’s other issues to ensure this is not a duplicate.
[x] This Algo/DS is worth adding to this repository.
[x] Assign this issue to me (I want to work on this).

[x] I ensure that I am not already assigned to 2 or more issues.

[x] I will send my PR only after I'm assigned to this issue by any maintainer.
[x] I understand that I will be unassigned from this issue if I fail to send a PR for this within a week.

Kindly assign me this issue under Contribute-a-thon'21

@marizvi GFI 👍

Kindly attach the input/output screenshots of the algorithm here.

yeah sure.

This input is already a part of code.
The output is below..

is this much fine sir?

LGTM


Received unexpected error: when i exec chains_test.go

This is where things go wrong：

blockNumber =====  0x33af
address =====  e6d8ff7eddb380c99b898c04b78edda4a92cc966
hashes =====  []
blockNumber =====  0x93130
    chains_test.go:186: delay for ack@chainA 15.430340792s
    chains_test.go:216:
        	Error Trace:	/Users/binny/go/src/yui-ibc-solidity/tests/e2e/chains_test.go:216
        	Error:      	Received unexpected error:
        	            	All attempts fail:
        	            	#1: failed to execute a transaction: &{{[] 0 232807 [0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0] [] 0x09c8f5d14efcd2eb8ada8121154a872f8186ba458e0b081738f29c74f9d5f010 0x0000000000000000000000000000000000000000 232807 0xdeb835b13d51e2bbb3f2737eb7ffedbb81dc28eac41f10c2387c19c109ccc669 13273 0} []}
        	Test:       	TestChainTestSuite/TestChannel
    --- FAIL: TestChainTestSuite/TestChannel (154.75s)

FAIL

Debugger finished with the exit code 0

I think this is an error related to packet timeout. Can you confirm that this PR(https://github.com/hyperledger-labs/yui-ibc-solidity/pull/138) will fix it in your setting? @binny1024

Thanks a lot, I'll try it next week

If the error reproduces after applying #138, please open this issue again.


Mark standardize as deprecated

Following #277 and some internal discussion we are moving away from Dataset standardisation.
We believe its current implementation is not the best fit for NNPs but for the moment we are leaving the option there for backwards compatibility. It will be removed at some point.
We could instead simply remove the feature altogether or make it more sensible, like offering alternative approaches as to how the mean is computed.
This is your last chance if you have an opinion about this!
Closes #277

Time is up! I am merging this.


[WIP] Change handle functions to return enum instead of boolean #339

cc @hellendag, just getting a quick gut check before I plunge into changing more handlers.

Ah, you should coordinate with @johanneslumpe -- see #340.
I like the wrapper function for checking whether the event is handled.

Doh, should have looked. @johanneslumpe I'm happy to let you carry on with this and close mine.

@guitardave24 like @hellendag said, nice approach with the handler function. Do you mind me integrating that into my PR?

johanneslumpe Sounds good, once that's done I'll close out my PR.

@johanneslumpe Sure, that works for me.

@guitardave24 It's in now :)


Cape Priority Toggle

For some reason #10 was closed without any warning from the OP. I see issue #7 but I still think the option should exist.
Currently Kappa prioritizes official Mojang capes over OptiFine, which does not reflect native OptiFine behavior.
However, this behavior is certainly desirable for some users. This is a request for a toggle, with the default being OptiFine > Mojang, in order to parody OptiFine correctly.
However if the goals of this mod is to truly be a "no-frills" type deal, perhaps simply parodying OptiFine's behavior would be better than adding a toggle.

wai + wontfix + migration cape user detected
Mojang capes are prioritized because they're official capes. This is a Minecraft mod, not an OptiFine mod.
If you want me to go into detail, then there are three reasons why I'm keeping it this way:

By prioritizing Mojang capes, I can claim that I'm more on the side of Mojang should they get angry with lawyers, but this is only a minor point. I will comply with a C&D should I get sent one, but maybe perhaps it should be OptiFine worrying about it more than me.
It is easier to just check if a game profile has a cape texture and store the OptiFine cape there than it is to keep a map of game profiles per cape textures, and adding hooks to clear that map to prevent leaking memory, and preventing the official cape from rendering, etc. Kappa is very barebones, and that's what allows for a single binary to work with multiple Minecraft snapshots sometimes multiple releases even. The current code injection points are unusually stable compared to the rest of the game, but the necessary code to make OptiFine priority over Mojang work would increase the surface area of Kappa for breakages across versions.
I sincerely believe that capes should be customizable and available to general public via official means including "rare" and one-of-a-kind capes. The rarity and exclusivity of anything digital only fuels a cesspool of toxic behavior, be it Minecraft capes, usernames, Twitter handles, Discord usernames, etc. Mojang's "solution" of migration and bedrock pre-owning capes is just a techbro nonsolution, they only serve to maintain the status quo.

Also, a toggle would require configuration, thus requiring a configuration screen, and a way to activate said screen. Also also, since we're talking injection points, changing the priority would require the user to restart the entire game, which can be outrageously annoying to do if the user is playing on a particularly large modpack. Avoiding this by adding runtime checks would not only marginally slow down the client (more than TLS would a CDN, btw), but also likely lead to undefined behavior, which is fixed by restarting the client. The only good solution would to enforce OptiFine cape priority over Mojang without configuration.
I don't wish to emulate OptiFine's behavior, I want a small and clean way to add Minecaft capes to snapshots. These are all reasons I've talked about in public channels before. If I wanted to emulate OptiFine's behavior but better, I'd contribute to Sodium, Starlight, and even Iris. This is my mod, and I think that saying "no" every few months to people asking for priority or why Kappa isn't working is a better use of my time compared to thoroughly testing a much larger code base prone to edge cases every single wednesday when snapshots are coming out. Not to mention, the toxic background of Minecraft modding, like yourself, where people order you to add stuff instead of politely asking why something is the case, specially if the mod has detailed documentation .

I'm not deeply familiar with the implementation of something like this, hence why I didn't just do it and then open a PR.
I didn't think it would be so much trouble, sorry.
It was just a polite request, not a demand. I'm sorry if it came across aggressive.


[Feature Request] Add configuration option to allow subpath for the webserver

First of all, thank you for your great work!
I am working in a way to add a configuration option (--webpath) to allow the web interface to be hosted in a subpath, like "/sendria".
This is particular important for me as I would like to run it behind a reverse proxy with multiple other projects.
I am opening this request for a future PR.
Thank you.

Hello @allangood
Thank you for your proposal! It may take some time, however I think it's worth to add. I'll try to start working on it in a while.

I have the same requirement. Looking forward to your PR :-)

Hi guys,
I've already started work on it. I've already finished with hardest (from my point of view) part, I mean frontend ;) And now need to find some time for backend and polishing. Hope will find and finish soon.

Hi @sbusch, @allangood ,
I just pushed some initial, but mostly working version of sendria, which can work in subpath. You can install it from using pip:
pip install git+https://github.com/msztolcman/sendria.git@non-root-ui-sendria
It requires new param when starting sendria, i.e.:
--http-url-prefix /asd/
And slighlty modified nginx config (rewrite pragma), you can see whole config in https://github.com/msztolcman/sendria/blob/non-root-ui-sendria/addons/nginx-non-root.conf
Can you take a look is this working fine or not? I will try to test it more in few days, however other pair of eyes would be very useful :)

Hello @msztolcman ,
Thank you for your update!
I've tried to build but couldn't build the assets:
/home/sendria/.local/bin/webassets -m sendria.build_assets build
Traceback (most recent call last):
  File "/home/sendria/.local/bin/webassets", line 8, in <module>
    sys.exit(run())
  File "/home/sendria/.local/lib/python3.9/site-packages/webassets/script.py", line 578, in run
    sys.exit(main(sys.argv[1:]) or 0)
  File "/home/sendria/.local/lib/python3.9/site-packages/webassets/script.py", line 572, in main
    return GenericArgparseImplementation(env).main(argv)
  File "/home/sendria/.local/lib/python3.9/site-packages/webassets/script.py", line 557, in main
    return self.run_with_argv(argv)
  File "/home/sendria/.local/lib/python3.9/site-packages/webassets/script.py", line 549, in run_with_argv
    return self.run_with_ns(ns)
  File "/home/sendria/.local/lib/python3.9/site-packages/webassets/script.py", line 531, in run_with_ns
    env = self._setup_assets_env(ns, log)
  File "/home/sendria/.local/lib/python3.9/site-packages/webassets/script.py", line 509, in _setup_assets_env
    env = PythonLoader(ns.module).load_environment()
  File "/home/sendria/.local/lib/python3.9/site-packages/webassets/loaders.py", line 272, in __init__
    self.module = import_module(module_name)
  File "/home/sendria/.local/lib/python3.9/site-packages/webassets/importlib.py", line 36, in import_module
    __import__(name)
  File "/home/sendria/.local/lib/python3.9/site-packages/sendria/build_assets.py", line 4, in <module>
    environment = configure_assets(False, False)
  File "/home/sendria/.local/lib/python3.9/site-packages/sendria/http/core.py", line 272, in configure_assets
    assets = webassets.Environment(directory=config.STATIC_DIR, url=config.CONFIG.url_static)
AttributeError: 'NoneType' object has no attribute 'url_static'

Am I missing something?

Hi @allangood,
I missed some problems with running webassets manually. It's not related to this issue, will fix this later. Please run sendria with -a switch, then it should automatically create assets. This works fine on newly created vps. Also, I've updated nginx config, now it works with url's without trailing /.


Exomes

I would like to test this method to joint call exomes via TERRA/firecloud.  I am unclear what file I should be using for  the two intervals lists.
For eval_interval_list I think "gs://broad-references/hg38/v0/exome_evaluation_regions.v1.interval_list" should be okay as it just looks like hg38 exons.
Less clear to me is what I should be using for unpadded_intervals_file;  Is this asking for unpadded exon capture regions, or should I just use the gs://.../hg38.even.handcurated.20k.intervals which are used for WGS?
Thanks!

The unpadded interval file is being used by the workflow to genotype the GVCFs, so the exon capture regions provided by the lab or sequencing provider would be used here.


issue with imports

I keep getting this error on a fresh install.
loading the modules as import { SHA256, EncBase64, EncUtf8 } from 'crypto-js'; seems to fix the issue.
is this a bug? or is my setup broken?
to clarify; I use es modules to load code

hmm, maybe not, just seems to become a warning instead of an error...

Are you using Angular? if so see the sample https://github.com/authts/sample-angular-oidc-client-ts

I'm not using a framework, but I do use rollup and ts as my toolchain. as far as I can see this is an issue with crypto-js, because if I look into the files in node_modules they aren't es modules. could that possibly be the issue?

@kherock what can we do here?

Does importing the type definitions @types/crypto-js help?

@chris-kruining you're right in noticing that crypto-js doesn't provide es-modules, it only exports UMD/CJS. You'll need to include @rollup/plugin-commonjs in your rollup config in order to resolve those imports.


Button of dropdown list "Sort by" is displayed on the Login & Registration Pages

Pre-condition:
User is not logged in
Step:

Open Login Page: https://iced-latte.uk/auth/login
Go to Registration Page: https://iced-latte.uk/auth/registration

ER: Button of dropdown list "Sort by" is not displayed on the Login & Registration Pages
FR: Button of dropdown list "Sort by" is displayed on the Login & Registration Pages

Fixed: https://github.com/Sunagatov/Iced-Latte-Frontend/pull/142

Approved
test: https://github.com/Sunagatov/Iced-Latte-QA/blob/development/UI/test_dropdawn_not_present.py

fixed


Updating French translations

Updating French translations
Main menu

Settings
Text & Editor

What is "ANSI (Windows code page)" in the section "Décodage de secours" ("Fallback Decoding" in english)? I can't figure out what it is and I can't find a translation for it (if I have to translate it).
Advanced

Right-click menus
Right-click in editor

Right-click on tab

Misc
Search bar

File pop-up

Status bar

Undo warning pop-up

Remarks
I found that when you save a file, the strings "Text Documents", "All Supported Files" and "Unknown" are not in resw files but in FilePickerFactory.cs and cannot be translated. Are they to be moved to Resources.resw?

thx, I don't have time actually for update translations...
Merci de votre travaille infiniment...

Thanks! You don't have to translate "ANSI (Windows Code Page)" in this case, this is the legacy default windows code page that system will be using based on your system locale. I will move "Text Documents", "All Supported Files" and "Unknown" to resource file eventually so you can do it later.


Adding 5 new crawlers, changed Microsoft Office identification string due to a new UA string

I saw a crawler with this UA: Mozilla/4.0 (compatible; ms-office) and added "ms-office" as a new crawler string. But this seems to break a normal UA Matching. Should i remove "ms-office" as crawler UA?

I saw a crawler with this UA: Mozilla/4.0 (compatible; ms-office) and added "ms-office" as a new crawler string. But this seems to break a normal UA Matching. Should i remove "ms-office" as crawler UA?

Yes, I think we should remove that for now 👍🏻

Awesome, thanks 👍


[HOLD for payment 2024-10-11] [$75] Migrate AccessOrNotFoundWrapper from withOnyx to useOnyx

Coming from https://expensify.slack.com/archives/C01GTK53T8Q/p1725973460005309?thread_ts=1725905735.105989&cid=C01GTK53T8Q
Migrate src/pages/workspace/AccessOrNotFoundWrapper.tsx to use useOnyx instead of withOnyx.
Upwork Automation - Do Not Edit

Upwork Job URL: https://www.upwork.com/jobs/~021834285721381801565
Upwork Job ID:<PHONE_NUMBER>381801565
Last Price Increase: 2024-09-12
Automatic offers:

akinwale | Reviewer | 103949065

Issue OwnerCurrent Issue Owner: @abekkala

dibs

Proposal
Please re-state the problem that we are trying to solve in this issue.
Migrate AccessOrNotFoundWrapper from withOnyx to useOnyx
What is the root cause of that problem?
A new feature
What changes do you think we should make in order to solve the problem?
We need to migrate the withOnyx here to use useOnyx. We also need to make sure the key we pass to useOnyx will be the collection member key to prevent the app crashes.
After using useOnyx, we can remove the type here
https://github.com/Expensify/App/blob/7748eff72fc43ecaf3db6159928d8d581a63ab99/src/pages/workspace/AccessOrNotFoundWrapper.tsx#L168
What alternative solutions did you explore? (Optional)

Note to self: PR not deployed yet

@mkzie2 Unfortunately, I wasn't able to find your Upwork profile. Can you post that here so that I can send you an upwork payment offer? Thanks!

@abekkala It's at https://www.upwork.com/freelancers/~019f73367b03c6d784

PAYMENT SUMMARY FOR OCT 11

Fix: @mkzie2 [$75] OFFER
PR Review: @akinwale [$75] OFFER

@akinwale payment sent and contract ended - thank you! 🎉
@mkzie2 once offer is accepted in Upwork I'll send payment!

@mkzie2 payment sent and contract ended - thank you! 🎉


📅 Quad-weekly meeting (2020-10-19)

Meeting date/time (UTC)
19 October, 2020
16:30 (9:30am PT, 12:30pm EST)
Instructions for joining the meeting
Zoom Meeting:
https://zoom.us/j/94160052429
Meeting ID: 941 6005 2429
Dial by your location
+1<PHONE_NUMBER> US (San Jose)
+1<PHONE_NUMBER> US (Houston)
+1<PHONE_NUMBER> US (Tacoma)
+1<PHONE_NUMBER> US (Germantown)
+1<PHONE_NUMBER> US (Chicago)
+1<PHONE_NUMBER> US (New York)
Agenda
Note: Add a comment on this issue to propose items for the agenda.
Notetaker
TBD

Two things from me:

I took down the BLM banner on amp.dev to put up the AMP Fest banner. Now, I've take down the AMP Fest banner. I assume we want to restore BLM, but I wanted to ask people.
Do we need a formal process to let anyone apply for a talk at future AMP Fests?


[Android] Add Android Matter Device App for automation testing

Problem

Need to improve automated testing with Matter device types
Difficult to verify Various type of devices

Change overview

Create new matter device app to support automated testing with Android devices (Phone, Tablet and so on)

Testing

1st build with "./scripts/build/build_examples.py --target android-arm64-st-device-app build" command
Excute Android studio and make project st-device-app on /examples
Install apk file on Android phone such as Galaxy and Pixel
SmartThings App and Hub can commission st-device-app and It is possible to test full automation

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

There is a lot of files with the license header. I think that this should be fixed at least for java files... Also, in the readme I can read that the app is an Android app which allows to commission Matter application. However, it's named "st-device-app", where the "st" is for SmartThings (I guess). Does it mean that this app somehow requires SmartThings ecosystem or it is generic enough to run everywhere without such dependency? If the latter is true, maybe it should be named in a more generic way?

yeah "st" is for SmartThings and agreed it should be renamed in a more generic way and not company specific

@andy31415 could you please give another pass on this PR considering the review comments have been addressed? We want to merge this PR soon else we need to rebase / resolve conflict multiple times. Thanks

@woody-apple to resolve

@andy31415 to take another look.

@woody-apple to look at this failing job.


MPO format is not supported

ValueError: unsupported image format, expected one of: dict_keys(['BMP', 'GIF', 'JPEG', 'PNG', 'TIFF', 'WMF']), got 'MPO'

This is unsupported by the upstream package, see https://github.com/scanny/python-pptx/issues/787.
closed.


Add "Show dialog result" for "Close dialog" action

Is your feature request related to a problem? Please describe.
When the "Close Dialog" action is used, there is no way to specify whether the dialog is closing successfully or failed
Describe the solution you'd like
Need to add the ability to customize the options for closing the dialog


Support for Image Sequences

OTIO supports both ImageSequenceReference and regular ExternalReference which points to a still image (e.g. target_url = "...whatever/something.png")
Here are some workarounds for reading these into AVFoundation are explained here: https://img.ly/blog/how-to-make-videos-from-still-images-with-avfoundation-and-swift/

I wonder also, if this technique for adding new codec support to AVFoundation could work? https://github.com/Vidvox/hap-in-avfoundation

Hey hey! I did a small amount of work on the hap stuff with Tom and Vidvox on that. They are good friends. Im not sure if the implementation there is 'the way to go' these days.
id be curious what @bangnoise says - ill ping Tom who was the primary architect on HAP

Hi hi - long time since I've done anything like this with AVFoundation, not sure I have much to contribute on what works these days - sorry!


Api 23 min?

Try run this code, but notify min api 23
    private val observers = ArraySet<ObserverWrapper<in T>>()

In actuality I use this code extract SO
open class Event<out T>(private val content: T) {

    var hasBeenHandled = false
        private set // Allow external read but not write

    /**
     * Returns the content and prevents its use again.
     */
    fun getContentIfNotHandled(): T? {
        return if (hasBeenHandled) {
            null
        } else {
            hasBeenHandled = true
            content
        }
    }

    /**
     * Returns the content, even if it's already been handled.
     */
    fun peekContent(): T = content
}

ArraySet is a part of lifecycle library as you can see:
import androidx.collection.ArraySet

So there should be no problem with resolving it.


Training Enterance

Hello there，
Thank you for open-sourcing such fantastic work!
I have been trying to train your model from scratch.
However, I was unable to locate the training entry.
Would you kindly provide it?
Thanks.

Thank you for your interest in our work! We have added the training file. Run python train_model.py -mode x to train the model without fine-tuning. Change the variable version in the code to 1 or 2 to train on IU-Xray and MIMIC-CXR accordingly. The reinforcement learning code is in the file but needs cleaning. We will provide a more formal training script soon.


⚠ Fortnite has degraded performance

In 393f640, Fortnite (https://fortnite.com) experienced degraded performance:

HTTP code: 200
Response time: 1691 ms

Resolved: Fortnite performance has improved in 84b4aeb.


Add tpr stats output, and periodic warning when gen_tpr < 90% of max_tokens

Periodically (every 10s) alerts users when the average number of generated tokens is less than 90% of max_tokens. This is important if users are using the tool to estimate total requests per second based on their real-world context/response sizes,  but the models are returning considerably shorter responses in testing (due to different/automated prompts).

I think a more suitable approach would be to add another metric that measures actual generated tokens such that, with each report, user can see "attempted" and "actual". Then they can decide about the relevance of the overall test results based on their use-cases.

Need a change of approach to a metrics output one.

Those metrics should be part of the stats output, let me know what you think of those (I added 10th//90th/avg), happy to remove some or rename them.

Need a change of approach to a metrics output one.

Those metrics should be part of the stats output, let me know what you think of those (I added 10th//90th/avg), happy to remove some or rename them. I do think a warning is useful though (it's easy to ignore if you're just running a single test and haven't dug into the tool). Maybe a single one after the test is finished/terminated?

I think p10, p90 and avg should be fine. I'm wodndering though if it is better to make an aggregate in the sliding window rather than per request? this way it would match, and be comparable to, existing gen_tpm?

Need a change of approach to a metrics output one.

Those metrics should be part of the stats output, let me know what you think of those (I added 10th//90th/avg), happy to remove some or rename them. I do think a warning is useful though (it's easy to ignore if you're just running a single test and haven't dug into the tool). Maybe a single one after the test is finished/terminated?

I think p10, p90 and avg should be fine. I'm wodndering though if it is better to make an aggregate in the sliding window rather than per request? this way it would match, and be comparable to, existing gen_tpm?

I'm not sure I understand - can you explain what you mean?

Need a change of approach to a metrics output one.

Those metrics should be part of the stats output, let me know what you think of those (I added 10th//90th/avg), happy to remove some or rename them. I do think a warning is useful though (it's easy to ignore if you're just running a single test and haven't dug into the tool). Maybe a single one after the test is finished/terminated?

I think p10, p90 and avg should be fine. I'm wodndering though if it is better to make an aggregate in the sliding window rather than per request? this way it would match, and be comparable to, existing gen_tpm?

I'm not sure I understand - can you explain what you mean?

I'm suggesting we add 3 new aggregate metrics in the sliding window that represent p10, p90 and avg actual tokens generated instead of your proposal. This way users will have comparable metrics to theoritical gen_tpm based on max_tokens.

Need a change of approach to a metrics output one.

Those metrics should be part of the stats output, let me know what you think of those (I added 10th//90th/avg), happy to remove some or rename them. I do think a warning is useful though (it's easy to ignore if you're just running a single test and haven't dug into the tool). Maybe a single one after the test is finished/terminated?

I think p10, p90 and avg should be fine. I'm wodndering though if it is better to make an aggregate in the sliding window rather than per request? this way it would match, and be comparable to, existing gen_tpm?

I'm not sure I understand - can you explain what you mean?

I'm suggesting we add 3 new aggregate metrics in the sliding window that represent p10, p90 and avg actual tokens generated instead of your proposal. This way users will have comparable metrics to theoritical gen_tpm based on max_tokens.

Practically speaking when I run this with the existing contexts, I did not see the number change. It is almost always a const value.
Does it make sense to show the same number 3 times? I would think avg would be sufficient maybe a 95th but I dont see the benefit.


#issue83 tpcds

save tpcds result into files. This PR can be merged firstly to see how the output files change.

is this pr still needed?

is this pr still needed?
nope, as the PR277 has override it


Helm install Error

What happened:
[root@test-1 charts]# helm install kueue kueue/ --create-namespace --namespace kueue-system
Error: INSTALLATION FAILED: unable to build kubernetes objects from release manifest:
 error validating "": error validating data: [apiVersion not set, kind not set]

What you expected to happen:
install success
How to reproduce it (as minimally and precisely as possible):
git clone https://github.com/kubernetes-sigs/kueue.git
cd kueue/charts
helm install kueue kueue/ --create-namespace --namespace kueue-system

Anything else we need to know?:
I tried helm template ./charts/kueue --values ./charts/kueue/values.yaml to debug where did this error happen,
then I find out:
---
# Source: kueue/templates/visibility/kustomization.yaml
resources:
- apiservice.yaml
- role_binding.yaml
- service.yaml
---

This is where helm got Error, so I tried to remove kueue/templates/visibility/kustomization.yaml, it works.
So I wonder, should we remove this file?
Environment:

Kubernetes version (use kubectl version): v1.26.0
Kueue version (use git describe --tags --dirty --always): main
Cloud provider or hardware configuration:
OS (e.g: cat /etc/os-release):
Kernel (e.g. uname -a):
Install tools: Helm
Others: helm version: v3.9.0

I can help fix that, just need to make sure if that is feasible first.
/assign

@PBundyra What do you think?

I found that this bug may not be easily fixed by removing the kustomization.yaml.
Maybe we need to keep the file, but still have to fix this bug.
I tried add apiVersion and kind for it:
apiVersion: kustomize.config.k8s.io/v1beta1
kind: Kustomization
resources:
  - apiservice.yaml
  - role_binding.yaml
  - service.yaml

But it still don't work:
[root@test-1 charts]# helm install kueue kueue/ --namespace kueue-system
Error: INSTALLATION FAILED: unable to build kubernetes objects from release manifest:
 resource mapping not found for name: "" namespace: "" from "":
no matches for kind "Kustomization" in version "kustomize.config.k8s.io/v1beta1"

I'll keep trying to fix this.

@B1F030 We can remove the kueue/templates/visibility/kustomization.yaml file since helm doesn't recognize customization files.

cc @mimowo

Here is where we copy the visibility files for helm: https://github.com/kubernetes-sigs/kueue/blob/a68c95860549a85061ae53db73d32de4df3c3446/hack/update-helm.sh#L99-L120. I think we should omit this file.

Here is where we copy the visibility files for helm:
https://github.com/kubernetes-sigs/kueue/blob/a68c95860549a85061ae53db73d32de4df3c3446/hack/update-helm.sh#L99-L120
. I think we should omit this file.

Yes, that's right.

If we simply remove the kustomization.yaml, there will be new problems:
[root@test-1 charts]# kubectl get resourceflavor
E1215 18:17:09.715081   24954 memcache.go:255] couldn't get resource list for visibility.kueue.x-k8s.io/v1alpha1:
 the server is currently unable to handle the request
E1215 18:17:09.723755   24954 memcache.go:106] couldn't get resource list for visibility.kueue.x-k8s.io/v1alpha1:
 the server is currently unable to handle the request
No resources found

Is this another bug?

Are you asking about config/components/visibility/kustomization.yaml, or  charts/kueue/templates/visibility/kustomization.yaml?
I think we should remove it from charts/kueue/templates/visibility/kustomization.yaml, and make sure it does not get copied during ./hack/update-helm.sh. Is there an issue in that case?

Are you asking about config/components/visibility/kustomization.yaml, or charts/kueue/templates/visibility/kustomization.yaml?

charts/kueue/templates/visibility/kustomization.yaml

Oh, in that case I'm not sure, it requires investigation.

@B1F030 Which kubernetes version do you use? You're using v1.26.0 the same as kubectl version?

@B1F030 Which kubernetes version do you use? You're using v1.26.0 the same as kubectl version?

yes

@B1F030 Recently, we fixed some permission errors related to the visibility server. So, could you verify if this error still happens?

@B1F030 Recently, we fixed some permission errors related to the visibility server. So, could you verify if this error still happens?

I repulled the git repositry, and try the steps again:
git clone https://github.com/kubernetes-sigs/kueue.git
cd kueue/charts
helm install kueue kueue/ --namespace kueue-system

still the same problem...
[root@test-1 charts]# helm install kueue kueue/ --namespace kueue-system
Error: INSTALLATION FAILED: unable to build kubernetes objects from release manifest:
error validating "": error validating data: [apiVersion not set, kind not set]

The file kueue/templates/visibility/kustomization.yaml still exists.

The file kueue/templates/visibility/kustomization.yaml still exists.

@B1F030 Yes, we haven't removed that file yet. I would like to ask if https://github.com/kubernetes-sigs/kueue/issues/1459#issuecomment-1857626239 still happens.

@B1F030 Yes, we haven't removed that file yet. I would like to ask if #1459 (comment) still happens.

Still the same. If I remove that kustomization.yaml and helm install, Errors still happen.

@B1F030 Yes, we haven't removed that file yet. I would like to ask if #1459 (comment) still happens.

Still the same. If I remove that kustomization.yaml and helm install, Errors still happen.

That error happens only for helm charts? Have you seen the same error when using all-in-one installation manifests (kubectl apply --server-side -k "github.com/kubernetes-sigs/kueue/config/default?ref=main") as well?

That error happens only for helm charts? Have you seen the same error when using all-in-one installation manifests (kubectl apply --server-side -k "github.com/kubernetes-sigs/kueue/config/default?ref=main") as well?

both.

I could reproduce the above error in v1.26.3 cluster. Also, that error doesn't happen in v1.27.3 cluster.
If we disable VisibilityServer feature-gate in the v1.26 cluster, https://github.com/kubernetes-sigs/kueue/issues/1459#issuecomment-1857626239 seems to happen.

@B1F030 Should we work only on https://github.com/kubernetes-sigs/kueue/issues/1459#issuecomment-1857440067 error in this issue? And then, should we work on https://github.com/kubernetes-sigs/kueue/issues/1459#issuecomment-1857626239 in a separate issue?

@B1F030 Should we work only on #1459 (comment) error in this issue? And then, should we work on #1459 (comment) in a separate issue?

SGTM

@B1F030 So, can you create a PR to fix https://github.com/kubernetes-sigs/kueue/issues/1459#issuecomment-1857440067 error?

@B1F030 So, can you create a PR to fix #1459 (comment) error?

I updated the above comment since I put the incorrect link :(

@B1F030 So, can you create a PR to fix #1459 (comment) error?

This part could be fixed by simply remove the file kueue/templates/visibility/kustomization.yaml, right?

@B1F030 So, can you create a PR to fix #1459 (comment) error?

This part could be fixed by simply remove the file kueue/templates/visibility/kustomization.yaml, right?

Also, we should improve scripts to generate helm charts:
https://github.com/kubernetes-sigs/kueue/issues/1459#issuecomment-1857465076

Also, we should improve scripts to generate helm charts:
#1459 (comment)

Got it. I'm glad to help.


[RFC] Add criteria and define a removal process for inactive users

Link for easy reading

Can you add a section on what tool you plan to use to do this?

Done

I did research about what tools exist and results are:

I found that the CNCF is using the devstats project to aggregate activity data and open issues like this to cleanup the members. The pr seems to be a manual action based on data from their devstats dashbaord which is a deployment of the devstats project.
Github action https://github.com/peter-murray/inactive-users-action which seems to out of maintenance
Gist with code to list all inactive users https://gist.github.com/psa-jforestier/28a5de5d262ac2af5b00595e651696d0
Our own script to list the contributions of a user https://github.com/cloudfoundry/community/blob/main/toc/working-groups/contributions-for-user.sh
@christopherclark are there any LFX data which could be used here like the devstats in CNCF?

None of the above options is optimal but they could be used as a direction in case we implement our own thing.

Starting final comment period, which will end Tuesday November 21.

A graphql query like the one below could be used:
query {
  user(login: "rkoster") {
    contributionsCollection(organizationID: "O_kgDOAAl8sg", from: "2022-11-14T15:00:00Z") {
      hasAnyContributions
    }
  }
}

Github API graphql explorer can be found here.

Or as a single query for the org:
{
  organization(login: "cloudfoundry") {
    membersWithRole(first: 50) {
      nodes {
        login
        contributionsCollection(organizationID: "O_kgDOAAl8sg") {
          hasAnyContributions
        }
      }
    }
  }
}

Needs pagination

Looks good to me.

RFC looks good! I have only one wish: As the WG leads are responsible for their members, there should be an easy to use tool for checking the activity status according to this RFC.

RFC looks good! I have only one wish: As the WG leads are responsible for their members, there should be an easy to use tool for checking the activity status according to this RFC.

@jochenehret There is a script available in this repository called contributions-for-user.sh) which can be used. E.g. I used it to generate https://github.com/cloudfoundry/community/pull/680#issuecomment-1815943223 and https://github.com/cloudfoundry/community/pull/660#issuecomment-1815959686. It can generate all the contribution of a user for a WG. Does it full fill your expectations?


Alter the steps

in the azure-iot-sample documentation, the description on how to get the IoTHub connection string is wrong.
The current description points to the device connection string (which is not there due to the usage of certificates in a DPS). But even if it was there, this is also not the connectionstring we want.
What we need is a connection string of the IoTHub itself, as found in the shared access policies, with sufficient rights.
Alter the steps in to section To get your IoT Hub Connection String to:

Go to the Azure Portal.
Click on your IoT Hub.
Under Settings, click Shared access policies.
Click on the iothubowner policy. The permissions and keys are shown.
In Shared access keys, Copy the text under Connection string-primary key.

This will give the readers the correct connectionstring.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 523ad25d-ef35-4653-4bb4-d01795828e4d
Version Independent ID: 25b26299-d3ca-45fa-54a1-923c0aca80d0
Content: Azure Sphere with Azure IoT Hub - sample application
Content Source: AzureSphere/articles/app-development/azure-iot-sample.md
Product: azure-sphere
GitHub Login: @pennyo
Microsoft Alias: azurespheredocs

Thank you for your feedback. We updated the topic with the recommended changes. Please let us know if we need to make additional changes.


update CI and .node-version to use node 16.0.0

Refs: https://github.com/mobu-of-the-world/mobu/issues/105
Updates

Introduce node 16.0.0

Update CI to use node 16.0.0 as well

@kachick
This pull requests updates .node-versions to use 16.x. Netlify respects .node-version file.

@kachick
As addressed in https://github.com/mobu-of-the-world/mobu/pull/108/commits/71c7664769769d70cf2a368b310e1642b814ebc9 , I dropped node 14.x support from linting/testing

go bold

Thanks for your all of works! 🎉


cmake: DYNAMIC_ARCH build broken on OS X

With latest develop, DYNAMIC_ARCH build on OS X fails with symbol(s) not found for architecture x86_64 errors for symbols like _xtrsm_outucopy_ZEN", referenced from:  _gotoblas_ZEN in libopenblas.a(setparam_ZEN.c.o).
See for example this Github Actions log: https://github.com/leezu/OpenBLAS/runs/719019580?check_suite_focus=true
The Makefile build works https://github.com/leezu/OpenBLAS/runs/719019582?check_suite_focus=true
Besides this bug, would it be sensible to enable Github Actions CI for OpenBLAS repo? I'm happy to open a PR with an slightly extended version of https://github.com/leezu/OpenBLAS/commit/560c39d4ea2cc541674b5be10c4972d271f05d3b used to produce above log.

Please pull from develop, not master - the latter is almost three years out of date. There is a github action for homebrew builds in the develop tree, though it currently fails in an xcode version check after the successful build.

This issue is about the develop version. Sorry for using the wrong word in the description.

Oh, I see. From your log the problem seems to be not so much ZEN architecture but the essentially unimplemented "quadruple precision support, not sure why a CMAKE build would suddenly attempt this on OSX. Would you happen to have set EXPRECISION=1 or QUAD_PRECISION=1 in an environment variable like CFLAGS, perhaps in the context of a different project ? (Alos not sure what to make of the cmake... -DANDROID=1 either  - was this an attempt to cross-compile ?)

Can you make this go away with -DNO_EXPRECISION=1 ? (Can't replicate this on Linux, possibly osx should be treated like the BSDs where this option gets set automatically since #2076)

I'm trying the cmake -DDYNAMIC_ARCH=1 -DNOFORTRAN=0 -DBUILD_WITHOUT_LAPACK=0 -DUSE_THREAD=1 -DUSE_LOCKING=1 .. build at https://github.com/leezu/OpenBLAS/actions/runs/120209434 and cmake -DDYNAMIC_ARCH=1 -DNOFORTRAN=0 -DBUILD_WITHOUT_LAPACK=0 -DUSE_THREAD=1 -DUSE_LOCKING=1 -DNO_EXPRECISION=1 .. build at https://github.com/leezu/OpenBLAS/actions/runs/120209642
The DANDROID was taken from the Conan package file (where it is only set on Linux / Android): https://github.com/conan-io/conan-center-index/blob/375275ef84db5afd7aa22f618b774180c829958c/recipes/openblas/all/conanfile.py#L63-L65

Thanks @martin-frbg. According to above Github Actions runs, -DNO_EXPRECISION=1 fixes the DYNAMIC_ARCH cmake build on macOS.
In general, could you recommend "how experimental" you would consider the cmake build to be? Is there a plan to consider it "stable" at some point?

The problem with the cmake build is that it is a comparatively late addition where the gmake build already used some trickery (recursions and kernel configuration files that use gmake conditional syntax), and not all combinations of options will have been tested on all platforms. Your build logs seem to suggest that USE_LOCKING may not have been passed correctly, I'll check that later today.

@martin-frbg there is also another issue when building with cmake -DDYNAMIC_ARCH=1 -DNOFORTRAN=0 -DBUILD_WITHOUT_LAPACK=0 .. on OSX:
2020-06-01T19:07:57.5971040Z In file included from /Users/runner/runners/2.263.0/work/OpenBLAS/OpenBLAS/build/kernel/CMakeFiles/sgemm_kernel_SKYLAKEX.c:7:
2020-06-01T19:07:57.5971320Z /Users/runner/runners/2.263.0/work/OpenBLAS/OpenBLAS/kernel/x86_64/sgemm_kernel_16x4_skylakex_3.c:504:34: error: inline assembly requires more registers than available
2020-06-01T19:07:57.5974160Z     for(;n_count>23;n_count-=24) COMPUTE_n24
2020-06-01T19:07:57.5974290Z                                  ^
2020-06-01T19:07:57.5974860Z /Users/runner/runners/2.263.0/work/OpenBLAS/OpenBLAS/kernel/x86_64/sgemm_kernel_16x4_skylakex_3.c:454:5: note: expanded from macro 'COMPUTE_n24'
2020-06-01T19:07:57.5975260Z     "vbroadcastss %8,%%zmm0; vmovups %10,%%zmm1; vmovups %11,%%zmm2;"\
2020-06-01T19:07:57.5975390Z     ^
2020-06-01T19:07:57.5975500Z /Users/runner/runners/2.263.0/work/OpenBLAS/OpenBLAS/kernel/x86_64/sgemm_kernel_16x4_skylakex_3.c:504:34: error: inline assembly requires more registers than available
2020-06-01T19:07:57.5976110Z /Users/runner/runners/2.263.0/work/OpenBLAS/OpenBLAS/kernel/x86_64/sgemm_kernel_16x4_skylakex_3.c:454:5: note: expanded from macro 'COMPUTE_n24'
2020-06-01T19:07:57.5976240Z     "vbroadcastss %8,%%zmm0; vmovups %10,%%zmm1; vmovups %11,%%zmm2;"\
2020-06-01T19:07:57.5976330Z     ^
2020-06-01T19:07:57.5976440Z /Users/runner/runners/2.263.0/work/OpenBLAS/OpenBLAS/kernel/x86_64/sgemm_kernel_16x4_skylakex_3.c:504:34: error: inline assembly requires more registers than available
2020-06-01T19:07:57.5976980Z /Users/runner/runners/2.263.0/work/OpenBLAS/OpenBLAS/kernel/x86_64/sgemm_kernel_16x4_skylakex_3.c:454:5: note: expanded from macro 'COMPUTE_n24'
2020-06-01T19:07:57.5977160Z     "vbroadcastss %8,%%zmm0; vmovups %10,%%zmm1; vmovups %11,%%zmm2;"\
2020-06-01T19:07:57.5977260Z     ^
2020-06-01T19:07:57.5977360Z /Users/runner/runners/2.263.0/work/OpenBLAS/OpenBLAS/kernel/x86_64/sgemm_kernel_16x4_skylakex_3.c:505:34: error: inline assembly requires more registers than available
2020-06-01T19:07:57.5977810Z     for(;n_count>19;n_count-=20) COMPUTE(20)
2020-06-01T19:07:57.5977910Z                                  ^
2020-06-01T19:07:57.5978400Z /Users/runner/runners/2.263.0/work/OpenBLAS/OpenBLAS/kernel/x86_64/sgemm_kernel_16x4_skylakex_3.c:421:5: note: expanded from macro 'COMPUTE'
2020-06-01T19:07:57.5978520Z     "vbroadcastss %7,%%zmm0; vmovups %9,%%zmm1; vmovups %10,%%zmm2;"\
2020-06-01T19:07:57.5978630Z     ^
2020-06-01T19:07:57.5978730Z /Users/runner/runners/2.263.0/work/OpenBLAS/OpenBLAS/kernel/x86_64/sgemm_kernel_16x4_skylakex_3.c:506:34: error: inline assembly requires more registers than available
2020-06-01T19:07:57.5979170Z     for(;n_count>15;n_count-=16) COMPUTE(16)
2020-06-01T19:07:57.5979270Z                                  ^
2020-06-01T19:07:57.5979760Z /Users/runner/runners/2.263.0/work/OpenBLAS/OpenBLAS/kernel/x86_64/sgemm_kernel_16x4_skylakex_3.c:421:5: note: expanded from macro 'COMPUTE'
2020-06-01T19:07:57.5979880Z     "vbroadcastss %7,%%zmm0; vmovups %9,%%zmm1; vmovups %10,%%zmm2;"\
2020-06-01T19:07:57.5979970Z     ^
2020-06-01T19:07:57.5980080Z /Users/runner/runners/2.263.0/work/OpenBLAS/OpenBLAS/kernel/x86_64/sgemm_kernel_16x4_skylakex_3.c:507:34: error: inline assembly requires more registers than available
2020-06-01T19:07:57.5980500Z     for(;n_count>11;n_count-=12) COMPUTE(12)
2020-06-01T19:07:57.5980610Z                                  ^
2020-06-01T19:07:57.5981100Z /Users/runner/runners/2.263.0/work/OpenBLAS/OpenBLAS/kernel/x86_64/sgemm_kernel_16x4_skylakex_3.c:421:5: note: expanded from macro 'COMPUTE'
2020-06-01T19:07:57.5981200Z     "vbroadcastss %7,%%zmm0; vmovups %9,%%zmm1; vmovups %10,%%zmm2;"\
2020-06-01T19:07:57.5981300Z     ^
2020-06-01T19:07:57.5981410Z /Users/runner/runners/2.263.0/work/OpenBLAS/OpenBLAS/kernel/x86_64/sgemm_kernel_16x4_skylakex_3.c:508:32: error: inline assembly requires more registers than available
2020-06-01T19:07:57.5981830Z     for(;n_count>7;n_count-=8) COMPUTE(8)
2020-06-01T19:07:57.5981930Z                                ^
2020-06-01T19:07:57.5982420Z /Users/runner/runners/2.263.0/work/OpenBLAS/OpenBLAS/kernel/x86_64/sgemm_kernel_16x4_skylakex_3.c:421:5: note: expanded from macro 'COMPUTE'
2020-06-01T19:07:57.5982530Z     "vbroadcastss %7,%%zmm0; vmovups %9,%%zmm1; vmovups %10,%%zmm2;"\
2020-06-01T19:07:57.5982620Z     ^
2020-06-01T19:07:57.5982710Z /Users/runner/runners/2.263.0/work/OpenBLAS/OpenBLAS/kernel/x86_64/sgemm_kernel_16x4_skylakex_3.c:509:32: error: inline assembly requires more registers than available
2020-06-01T19:07:57.5983710Z     for(;n_count>3;n_count-=4) COMPUTE(4)
2020-06-01T19:07:57.5983820Z                                ^
2020-06-01T19:07:57.5984500Z /Users/runner/runners/2.263.0/work/OpenBLAS/OpenBLAS/kernel/x86_64/sgemm_kernel_16x4_skylakex_3.c:421:5: note: expanded from macro 'COMPUTE'
2020-06-01T19:07:57.5984650Z     "vbroadcastss %7,%%zmm0; vmovups %9,%%zmm1; vmovups %10,%%zmm2;"\
2020-06-01T19:07:57.5984740Z     ^
2020-06-01T19:07:57.5984840Z /Users/runner/runners/2.263.0/work/OpenBLAS/OpenBLAS/kernel/x86_64/sgemm_kernel_16x4_skylakex_3.c:510:32: error: inline assembly requires more registers than available
2020-06-01T19:07:57.5985320Z     for(;n_count>1;n_count-=2) COMPUTE(2)
2020-06-01T19:07:57.5985420Z                                ^
2020-06-01T19:07:57.5985900Z /Users/runner/runners/2.263.0/work/OpenBLAS/OpenBLAS/kernel/x86_64/sgemm_kernel_16x4_skylakex_3.c:421:5: note: expanded from macro 'COMPUTE'
2020-06-01T19:07:57.5986030Z     "vbroadcastss %7,%%zmm0; vmovups %9,%%zmm1; vmovups %10,%%zmm2;"\
2020-06-01T19:07:57.5986120Z     ^
2020-06-01T19:07:57.5986220Z /Users/runner/runners/2.263.0/work/OpenBLAS/OpenBLAS/kernel/x86_64/sgemm_kernel_16x4_skylakex_3.c:511:19: error: inline assembly requires more registers than available
2020-06-01T19:07:57.5986330Z     if(n_count>0) COMPUTE(1)
2020-06-01T19:07:57.5986410Z                   ^
2020-06-01T19:07:57.5986910Z /Users/runner/runners/2.263.0/work/OpenBLAS/OpenBLAS/kernel/x86_64/sgemm_kernel_16x4_skylakex_3.c:421:5: note: expanded from macro 'COMPUTE'
2020-06-01T19:07:57.5987030Z     "vbroadcastss %7,%%zmm0; vmovups %9,%%zmm1; vmovups %10,%%zmm2;"\
2020-06-01T19:07:57.5987110Z     ^
2020-06-01T19:07:57.5987190Z 10 errors generated.

reference: https://github.com/leezu/OpenBLAS/runs/728422254?check_suite_focus=true

Hmm. Wonder why that is - when the build gets there it must have confirmed that AVX512 support is available. Possibly an OSX LLVM bug ?

@martin-frbg But why would cmake -DDYNAMIC_ARCH=1 -DNOFORTRAN=0 -DBUILD_WITHOUT_LAPACK=0 -DUSE_THREAD=1 -DUSE_LOCKING=1 -DNO_EXPRECISION=1 .. work (see log above)?

No idea unless builds happened on different hardware (one Xeon so including the AVX512 "SkylakeX" kernels, the other not)

Maybe. I added a commit https://github.com/xianyi/OpenBLAS/pull/2638 to print the CPU arch. It now shows

machdep.cpu.brand_string: Intel(R) Xeon(R) CPU E5-1650 v2 @ 3.50GHz
machdep.cpu.family: 6
machdep.cpu.model: 58
machdep.cpu.extmodel: 3
machdep.cpu.extfamily: 0
machdep.cpu.stepping: 9
machdep.cpu.feature_bits:<PHONE_NUMBER>3948011519
machdep.cpu.leaf7_feature_bits: 643 0
machdep.cpu.leaf7_feature_bits_edx:<PHONE_NUMBER>
machdep.cpu.extfeature_bits:<PHONE_NUMBER>
machdep.cpu.signature: 198313
machdep.cpu.brand: 0
machdep.cpu.features: FPU VME DE PSE TSC MSR PAE MCE CX8 APIC SEP MTRR PGE MCA CMOV PAT PSE36 CLFSH MMX FXSR SSE SSE2 SS HTT SSE3 PCLMULQDQ MON VMX SSSE3 CX16 SSE4.1 SSE4.2 x2APIC POPCNT AES VMM PCID XSAVE OSXSAVE TSCTMR AVX1.0 RDRAND F16C

Confused... but one difference appears to be that the cmake build lost the "-O2" , wonder how and when that happened (and disabling optimization for the skx sgemm kernel is sufficient to break the gmake build).

The "-O2" was removed from system.cmake in #1279 , possibly on the premise that the "correct" way to handle this in cmake would be to specify a CMAKE_BUILD_TYPE or to set CMAKE_C_FLAGS. The default build type (with neither Debug or Release specified) seems to invoke the compiler without any optimization, which for some reason makes llvm run out of registers in the case of that one AVX512-heavy source file.

Thank you @martin-frbg for investigating this and finding the CMAKE_BUILD_TYPE=Release fix. This is indeed a confusing issue.. Do you think that's worth a bug report to the Clang team? (Though need to verify first if it happens on latest clang)

Probably could not hurt (googling found lots of references to that "more registers than available" message but most seemed to be for ARM or 32bit x86). Sorry for messing up your PR BTW - at first I had actually got it wrong and thought overoptimization was causing the problem.
There is currently one other difference between gmake and cmake builds, cmake is missing the
MAX_STACK_ALLOC=2048 that was introduced in #482 to speed up gemv/ger for small matrix sizes. I'll see if I can address that tomorrow


write_scrollback_file:open to use $EDITOR

The write_scrollback_file:open command opens the scrollback in my OS default text editor.
Going through the code:
https://github.com/ghostty-org/ghostty/blob/ffc4c6e2856d6b6d86d0f83a288da520dce7bf33/src/Surface.zig#L4184-L4190
It does seem to be the intended behavior, but would it be possible to instead open it in $EDITOR. In my case neovim.

@NishantJoshi00 I also use neovim and you just need a desktop file to set filetypes for neovim and then set it as the default.
❯ cat ~/.local/share/applications/nvim.desktop
[Desktop Entry]
Name=Neovim
Categories=Utility;TextEditor;
Comment=Neovim Text Editor
Exec=nvim %F
Icon=gvim
Keywords=Text;editor;
MimeType=text/english;text/plain;text/x-makefile;text/x-c++hdr;text/x-c++src;text/x-chdr;text/x-csrc;text/x-java;text/x-moc;text/x-pascal;text/x-tcl;text/x-tex;application/x-shellscript;text/x-c;text/x-c++;
StartupNotify=false
Terminal=true
Type=Application

Then set nvim as the default for plain text (assuming linux):
❯ xdg-mime default nvim.desktop text/plain

I think using xdg-open is good

@NishantJoshi00 I also use neovim and you just need a desktop file to set filetypes for neovim and then set it as the default.
❯ cat ~/.local/share/applications/nvim.desktop
[Desktop Entry]
Name=Neovim
Categories=Utility;TextEditor;
Comment=Neovim Text Editor
Exec=nvim %F
Icon=gvim
Keywords=Text;editor;
MimeType=text/english;text/plain;text/x-makefile;text/x-c++hdr;text/x-c++src;text/x-chdr;text/x-csrc;text/x-java;text/x-moc;text/x-pascal;text/x-tcl;text/x-tex;application/x-shellscript;text/x-c;text/x-c++;
StartupNotify=false
Terminal=true
Type=Application

Then set nvim as the default for plain text (assuming linux):
❯ xdg-mime default nvim.desktop text/plain

@grimm26 You suggestion seems to only work when the current ghostty terminal instance is spawned by another terminal instance? This is also mentioned in this issue: https://github.com/ghostty-org/ghostty/issues/3334#issuecomment-2564296601

@grimm26 You suggestion seems to only work when the current ghostty terminal instance is spawned by another terminal instance? This is also mentioned in this issue: #3334 (comment)

Very strange. This was working when I launch ghostty from the panel (Mint Linux 22), not from within another terminal. I had launched ghostty from another terminal previously in the same X session. Maybe I was using the same ghostty session?
I rebooted to start fresh and write_scrollback_file action did NOT work in ghostty started from the panel.
The other funny thing is that the open_config action does work.


Please add description in readme.md

How Use
...
And why don't use QEMU, in your VM?

So, currently the steps for building fox32os yourself are a bit complicated. I'll try my best to explain them here, then in the future I'll take these instructions and try to condense them down to put into the readme.
Also feel free to join the fox32 Discord server for further help :3
First, set up the Rust toolchain by following the instructions here. You'll need this in order to build fox32asm and gfx2inc.
Currently the process includes cloning multiple repositories, all of which are available here.
You want the directory structure to look something like this:

project_root/

fox32asm/

src/
...

fox32rom/

main.asm
...

fox32os/

main.asm
...

tools/

gfx2inc/
...

Then, cd into the fox32asm/ folder and run cargo build --release.
Then, cd back to the project root, then cd into tools/gfx2inc/ and run cargo build --release.
Finally, cd into the fox32os/ folder and run the build.sh script. This will create a disk image called fox32os.img, which can be run with fox32.
Hopefully these instructions make sense, let me know if you need further help :3

And why don't use QEMU, in your VM?

Mostly because I don't know how QEMU works internally, and creating my own little VM was the easiest option :P

Now that the build system has been overhauled to use make, I think this can be closed now.


Open child window

Are tauri supports new opening child window from application and if yes, how to do it?

Tauri does support it.  Code sample as following:
  tauri::async_runtime::spawn(async move {
    app_handle
      .clone()
      .create_window(
        "sample",
        WindowUrl::App("sample.html".into()),
        |window_builder, webview_attributes| {
          let builder
```= window_builder.inner_size(400.0, 200.0).decorations(true).visible(true);
          (builder, webview_attributes)
        },
      )
      .unwrap();
});

duplicate of #1643

@xuchaoqian  that's just creating normal windows programmatically, not child windows.

Thank you. I've learned that now:).

@xuchaoqian that's just creating normal windows programmatically, not child windows.

@amrbashir I don't know why but I cannot use import statement in my app and it leads to import error. something like cannot use import out of module and like this.
now I don't have access to my system but will share complete error msg.

@xuchaoqian tnx for your help 🙏😊

@rdwnsjjd it is porbably because you're using vanillajs and your script tag doesn't have type="module" attribute on it.

@amrbashir I use pure js with jquery

@rdwnsjjd This is not a Tauri issue but with how you have your html/js setup. please ask for Tauri issues only and on related issues that relate to the problem. Other stuff can be asked in our discord server.


Jz/insert data

all CompE related data in backend/MakeMyDegree/fixture/, ready for demo
scraping scripts inside scrape_purdue/
script to initialize the DB with API calls: backend/MakeMyDegree/scripts/loader.py
To initialize the DB with Purdue CompE related data, run python manage.py runscript loader in backend/

LGTM


Explain graphically the relation between sbi, pyknós and nflows.

Create a block diagram and associated caption explaining the relationsip between the three packages.

yes yes yes we want this-- looking forward to seeing a first draft (this can be done quickly, btw, no need for super fancy graphics or tikz-whatever)

(Probably this won't be needed anymore once we migrate to flowtorch.)

related to #336


Using archlinux and neovim version 8.1  ->  package.preload['which-key']not found in lazy cache error.

Hi @Allaman ,
Your config looked quite cool and felt like trying to use your configs as base, but I am getting error when starting neovim.
I might've set this wrong. As I copied the whole repo to my ~/.config/nvim folder if this requires some other steps..
More info of the neovim version:
NVIM v0.8.1
Build type: Release
LuaJIT 2.1.0-beta3
Compiled by builduser
```
`
Error:

Error detected while processing /home/penguin/.config/nvim/init.lua:
E5113: Error while calling lua chunk: /home/penguin/.config/nvim/lua/core/mappings.lua:36: module 'which-key' not found:
        no field package.preload['which-key']not found in lazy cache
        no file './which-key.lua'
        no file '/usr/share/luajit-2.1.0-beta3/which-key.lua'
        no file '/usr/local/share/lua/5.1/which-key.lua'
        no file '/usr/local/share/lua/5.1/which-key/init.lua'
        no file '/usr/share/lua/5.1/which-key.lua'
        no file '/usr/share/lua/5.1/which-key/init.lua'
        no file './which-key.so'
        no file '/usr/local/lib/lua/5.1/which-key.so'
        no file '/usr/lib/lua/5.1/which-key.so'
        no file '/usr/local/lib/lua/5.1/loadall.so'

Any clue why it causes such error? I tried to downgrade neovim but it didn't seem to help.

Actually there is even more in the error output, but not sure how to fix it.
Error detected while processing BufReadPost Autocommands for "*":
Error executing lua callback: /usr/share/nvim/runtime/filetype.lua:22: Error executing lua: /usr/share/nvim/runtime/filetype.lua:23: Vim(runtime):E5113
: Error while calling lua chunk: /home/penguin/.config/nvim/after/ftplugin/lua.lua:1: module 'which-key' not found:
        no field package.preload['which-key']not found in lazy cache
        no file './which-key.lua'
        no file '/usr/share/luajit-2.1.0-beta3/which-key.lua'
        no file '/usr/local/share/lua/5.1/which-key.lua'
        no file '/usr/local/share/lua/5.1/which-key/init.lua'
        no file '/usr/share/lua/5.1/which-key.lua'
        no file '/usr/share/lua/5.1/which-key/init.lua'
        no file './which-key.so'
        no file '/usr/local/lib/lua/5.1/which-key.so'
        no file '/usr/lib/lua/5.1/which-key.so'
        no file '/usr/local/lib/lua/5.1/loadall.so'
stack traceback:
        [C]: in function 'require'
        /home/penguin/.config/nvim/after/ftplugin/lua.lua:1: in main chunk
        [C]: in function 'nvim_cmd'
        /usr/share/nvim/runtime/filetype.lua:23: in function </usr/share/nvim/runtime/filetype.lua:22>
        [C]: in function 'nvim_buf_call'
        /usr/share/nvim/runtime/filetype.lua:22: in function </usr/share/nvim/runtime/filetype.lua:11>
stack traceback:
        [C]: in function 'nvim_cmd'
        /usr/share/nvim/runtime/filetype.lua:23: in function </usr/share/nvim/runtime/filetype.lua:22>
        [C]: in function 'nvim_buf_call'
        /usr/share/nvim/runtime/filetype.lua:22: in function </usr/share/nvim/runtime/filetype.lua:11>
stack traceback:
        [C]: in function 'nvim_buf_call'
        /usr/share/nvim/runtime/filetype.lua:22: in function </usr/share/nvim/runtime/filetype.lua:11>

Hi @thepenguinthatwants, glad that you like it :)
Looks like plugins are not installed.
Can you run :Lazy sync? If not try running nvim --headless "+Lazy! sync" +qa (once).

Oh my cool thanks, I did try to run :Lazy sync, but as plugin was not installed it failed.
nvim --headless "+Lazy! sync" +qa, works very well thanks!

t


Misc tidying up

Includes some minor HTML and CSS refactoring, as well as adding some missing alt tags. (@hflynn Hopefully I caught all of them!)

2 remaining html proofer errors are fixed on #36 so 👍 to having fixed all the missing alt tags

Looks good on staging, merging thanks


explore the brand

We've evolved a pretty stable mission and set of brand values over the years. We've got a pretty solid understanding of who our customers are, what product we're building for them, and our basic nomenclature. We've tried for years to figure out the visual design side of Gratipay, without much success. I think as a first step towards improving in this area, we should have some expert help exploring a number of visual possibilities for the Gratipay brand. We need some fresh, professional eyes.

Agreed.

I don't have a background in brand, but I did go to CMU for HCI. I think these days brand and "interaction style" are closely linked, so count me in if I can help.

Thanks @elliottw! :-)

Speaking of interaction styles being on brand or not, I just posted this concept for interactive signup and donate widgets to be placed on project sites:
https://github.com/gratipay/gratipay.com/issues/3676

We can't afford professional design help right now (https://github.com/gratipay/inside.gratipay.com/issues/298) . :-(
Closing, to be reopened when we're further along.

Hey @whit537, I have branding experience, I'd be willing to put in some time on that if you just want to make me part of the team (frankly, Aspen has been a disincentive to contributing as a developer).

Invite sent! :-)

to be reopened when we're further along.

Reopening in light of https://github.com/gratipay/grtp.co/issues/103#issuecomment-229479424.

Design was Slack's secret sauce (according to its designers).
Also:

In 1999 Jakob Nielsen listed 4 ways in which a website can communicate trustworthiness: design quality, up-front disclosure, comprehensive and current content, and connection to the rest of the web. In our study, we observed that these very same factors continue to influence users.

https://www.nngroup.com/articles/trustworthy-design/ (two months ago)

I just had an intro meeting with a designer who also works here at Catapult (and uses Gratipay to pay for his membership! :). He's going to get us a quote for this.

He got back to me with a quote, and we're aiming to discuss on the 25th. I need to talk to him about https://github.com/gratipay/inside.gratipay.com/issues/411 before saying more here.

Bouncing back over to https://github.com/gratipay/inside.gratipay.com/issues/298#issuecomment-242416375 before proceeding here.