tf dataset cache behave differently with filter for TF 1.x

Please make sure that this is a bug. As per our
GitHub Policy,
we only address code/doc bugs, performance issues, feature requests and
build/installation issues on GitHub. tag:bug_template
System information

Have I written custom code (as opposed to using a stock
example script provided in TensorFlow):  Yes
OS Platform and Distribution (e.g.,
Linux Ubuntu 16.04): Linux Ubuntu 16.04
Mobile device (e.g. iPhone 8, Pixel 2, Samsung Galaxy) if
the issue happens on mobile device: NA
TensorFlow installed from (source or
binary): binary (pip)
TensorFlow version (use command below): v1.15.0-rc3-22-g590d6eef7e 1.15.0
Python version: - Bazel
version (if compiling from source): NA
GCC/Compiler version (if compiling from
source): NA
CUDA/cuDNN version: - GPU model and memory: NA

You can collect some of this information using our environment capture
script
You can also obtain the TensorFlow version with: 1. TF 1.0: python -c "import tensorflow as tf; print(tf.GIT_VERSION, tf.VERSION)" 2. TF 2.0: python -c "import tensorflow as tf; print(tf.version.GIT_VERSION, tf.version.VERSION)"
Describe the current behavior
When applying filter before cache on tf.data.Dataset, the outputs when caching to file compared to caching to memory are different.
Describe the expected behavior
They should be the same.
TF 2x is working as expected.
Standalone code to reproduce the issue
Cache to memory
import tensorflow as tf

tf.enable_eager_execution()

data = tf.data.Dataset.from_tensor_slices(list(range(50)))
data = data.filter(lambda x: tf.random.uniform([]) < 0.5)
data = data.cache()

outputs = [x for x in data]
outputs_1 = [x for x in data]

assert len(outputs) == len(outputs_1)

for x, y in zip(outputs, outputs_1):
    assert x.numpy() == y.numpy()

Cache to file
import tensorflow as tf

tf.enable_eager_execution()

data = tf.data.Dataset.from_tensor_slices(list(range(50)))
data = data.filter(lambda x: tf.random.uniform([]) < 0.5)
data = data.cache('/tmp/dummy_data')

outputs = [x for x in data]
outputs_1 = [x for x in data]

assert len(outputs) == len(outputs_1)

for x, y in zip(outputs, outputs_1):
    assert x.numpy() == y.numpy()

Other info / logs Include any logs or source code that would be helpful to
diagnose the problem. If including tracebacks, please include the full
traceback. Large logs and files should be attached.

Was able to reproduce the issue with TF 1.15.2. Please find the Gist here. Thanks!

Hi, I am facing a similar issue and I've managed to replicate the problem too. Is there a fix for this?

In TF 1, cache does not work with eager iteration (i.e. from elem in dataset). You should either use TF 2 or append repeat to the end of your dataset consume multiple epochs.

Hi @jsimsa, thank you for your reply. I tried replicating it in non-eager and still experienced the same issue.
Why are you saying that cache does not work with eager mode in TF 1? By "does not work", do you mean it will not behave properly?

In TF 1, memory-based cache only support reuse through subsequent repeat. This is because the implementation uses an in-memory cache that is owned by the iterator and thus different iterators will have different caches. This is not an issue for file-based caches because different iterators can access the same file-based cache.
This is fixed in TF 2 where a single in-memory cache is shared among all iterators created for a dataset.


Implement the onComplete callback for the Mutation widget

This PR implements the onComplete callback for  the Mutation widget. It also adds some extra safety when tearing down an ObservableQuery.
Breaking changes
n/a
Fixes / Enhancements

Fixed a scenario where the dispose method was calling close on the observableQuery but might not have been initialised.
Added the onComplete callback for  the Mutation widget.

Docs

Updated the Mutation example with the new onComplete callback.

:tada: This PR is included in version 1.0.0 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


feat: enable prepare and repair tools in Core Service

Description
Enabling prepare and repair tools in Core Service
Issue linked
Closes #1579
Checklist

[ ] I have tested my changes locally.
[X] I have added necessary documentation or updated existing documentation.
[X] I have followed the coding style guidelines of this project.
[X] I have added appropriate unit tests.
[X] I have reviewed my changes before submitting this pull request.
[X] I have linked the issue or issues that are solved to the PR if any.
[X] I have assigned this PR to myself.
[X] I have added the minimum version decorator to any new backend method implemented.
[X] I have made sure that the title of my PR follows Conventional commits style (e.g. feat: extrude circle to cylinder)

Looks like that the repair tools are not ready...

Nice to see it supported as it can quite useful for some workflows. Also nice to get ride of the skip linux conditions.😁

Step by step 😆 there are some tests still failing, but parity is the goal!


Saving nifti files with MedImage Object data from dicom files

within load_and_save.jl in src, for the save function it seems as if it expects a nifti file to manipulate.
with the MedImage object formulated with data from a dicom file, does a path for an equivalent nifti file is expected by the save function?
Is dicom to nifti file conversion prominent here,
or
we can get away with loading spatial metadata into the MedImage object, from both the formats, and
[]for Nifti File
--manipulating the origin nifti file
[]for Dicom File
--creating and manipulating an empty nifti file

This issue is no longer relevant, since the original load_and_save.jl has undergone changes, a lot of them and a basic idea for implementation of the final load_and_save.jl is underway.


Fix for handling undefined translations in relationship field

In case that no translation is available for the current locale, the relationship field did not show any text or 'undefined'. This fix improves getting an translation by first looking for the current locale, then for the Laravel app's fallback locale and then for the first locale that is available. Further the javascript code was improved and some error cases are handled and reported to console.
Note: Would be nice to factor out the Javascript in order to avoid the code duplication.

A new inspection was created.

The inspection completed: No new issues

Thanks for submitting this @cplewnia ! I'm going to defer this to @pxpm since this the relationship field is his baby 😄
@pxpm what do you think?

Hello @cplewnia
Thanks again for your contribution. I'v just submited PR #3262 that allows us to test your solution agains the master branch.
I will be closing this one as I'v pulled your commits into that other branch.
Wish you the best,
Pedro


Add Job class and Money class

Add both Job and Money class as baseline implementation. Somewhat of placeholders first due to high dependency on Job class.

Codecov Report

Merging #46 (c876a0f) into master (bc8d11a) will decrease coverage by 2.70%.
The diff coverage is 0.00%.

@@             Coverage Diff              @@
##             master      #46      +/-   ##
============================================
- Coverage     72.15%   69.45%   -2.71%
  Complexity      399      399
============================================
  Files            70       72       +2
  Lines          1232     1280      +48
  Branches        125      132       +7
============================================
  Hits            889      889
- Misses          311      359      +48
  Partials         32       32

Impacted Files
Coverage Δ

src/main/java/seedu/address/model/job/Job.java
0.00% <0.00%> (ø)

src/main/java/seedu/address/model/job/Money.java
0.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bc8d11a...c876a0f. Read the comment docs.

Testing has been added for greater code coverage.


PSCE-408 feat: adds flags to set git provider information when interacting with the API

Description

This feature simplifies running trestle-bot in different contexts.

Adds an environment variable option for passing in token info
Fixes a bug around checking for with_token input
Allows Git provider type and url information to be provided and falls back to the existing method of detection.

Fixes #200
Stacked with #215
Type of change

[X] New feature (non-breaking change which adds functionality)

How has this been tested?

[X] Unit testing added
[x] Local Testing - Verify the feature
[x] Regression Testing - Verify does not introduce a breaking chang

[X] GitHub Actions
[X] Existing container image implementation

Checklist

[X] My code follows the style guidelines of this project
[x] I have performed a self-review of my own code
[X] I have commented my code, particularly in hard-to-understand areas
[x] I have made corresponding changes to the documentation
[X] My changes generate no new warnings
[X] I have added tests that prove my fix is effective or that my feature works
[x] New and existing unit tests pass locally with my changes
[ ] Any dependent changes have been merged and published in downstream modules

Putting back into draft to rebase and resolve conflicts.


Concurrent calls to client.search() failed when using "ldaps"

I'm wondering if the functions on a client can be called concurrently?
I have a small test application which takes a list of usernames, fetch their details from ldap using ldapjs and print them to the console. Currently I implement it in the way that it create a single ldapjs client, bind it and then call "search" for each of the usernames concurrently.
It works fine when I'm connecting with unsecured "ldap" protocol. But when switched to "ldaps", all search still returns the event emitter, but some of them will never call "end" or "error".
I'm wondering if it is safe to call another search while one is still not finished? Thanks.
Environment:
windows 7
node v0.12.9
ldapjs 1.0.0

might have found the problem:
in lib/client/client.js, on the last few lines of function "Client.prototype._sendSocket",
conn.write(message.toBer(), writeCallback);

If I understand correctly, this guarantees that the message (search request) is written to the socket before calling writeCallback, which will return the event emitter back to the caller. However, this might be too late in some cases. As I have noticed that the "end" event is fired before the callback of "search" is called. In which case the caller will never be able to receive that event as it hasn't got a chance to register event handler yet.
Maybe we should make sure the emitter is returned to the caller so that they have the chance to register event handler before any event arrive? My initial thought is as follow. Hopefully you could provide more help on this?
try {
    writeCallback();
    return conn.write(message.toBer());

  } catch (e) {
    if (timer)
      clearTimeout(timer);

    log.trace({err: e}, 'Error writing message to socket');
    emitter.emit('error', e);
  }

btw, the issue I'm having only seem to affect "ldaps" protocol so far. and the above fix works for me.

@javefang Could you collect trace-level logs from this situation?

any plan in integrating this? there is also a fork with this fix only based on an old version .. https://github.com/hpi-schul-cloud/node-ldapjs/commit/3d470ab339c203560ad9816158dfb5695fff36ab

If someone wants to create a PR with the fix we can look at it. Make sure to add a test as well.

👋
On February 22, 2023, we released version 3 of this library. As a result, we are closing this issue/pull request.
Please see issue #839 for more information, including how to proceed if you feel this closure is in error.


Updated lookup table with conversion for ć

A lowercase accented c was missing from the table

@bfunky Any chance you could merge this pr?


feat: add --all-namespaces flag to func list

Fixes: https://github.com/boson-project/faas/issues/224
Signed-off-by: Lance Ball<EMAIL_ADDRESS>

Converting to WIP so I can add func describe -A.

Actually, it doesn't make sense with describe since that command is used to describe a single function in a single directory.


clone_model method doesn't follow keras API?

in util.py there is the line
clone = Sequential.from_config(config,custom_objects)
I can run the examples if I remove the second argument. But otherwise throws an error that 3 arguments are passed instead of 2. Should these be there?

Actually, never mind. I've temporarily removed passing custom_objects to Sequential.from_config. This should resolve it for now, if you don't use custom_objects. I'll properly fix this and add support to Keras for this later (about to go on vacation).


Support 'connection reset by peer' fault

Hello,
I wanted to get the community opinion about implementing a new type of fault which would terminate the connection with a RST message and cause a SocketException to be thrown on the client side. I think it would be useful for increasing the test coverage levels of the http clients.
Thanks!

If you know a way to get past Java's socket abstraction sufficiently to do this, I think it would be a great addition. I'll happily merge.

Sounds great! Also, do you have a CLA that I would need to sign in order to contribute?

Nope, no CLA required at this point.

I'm going to close this as I assume there'll be a PR opened as/when you work on this.


RangeError: Maximum call stack size exceeded with ED 3.14

Tested on brand new Ember install:
DEBUG: -------------------------------
DEBUG: Ember           : 3.14.1
DEBUG: Ember Data      : 3.14.0
DEBUG: Model Fragments : 4.0.0
DEBUG: -------------------------------

Uncaught (in promise) RangeError: Maximum call stack size exceeded
    at new CoreStore (-private.js:12583)
    at new Store (-private.js:15820)
    at Function.create (core_object.js:673)
    at FactoryManager.create (index.js:552)
    at instantiateFactory (index.js:362)
    at lookup (index.js:290)
    at processInjections (index.js:403)
    at buildInjections (index.js:419)
    at injectionsFor (index.js:434)
    at FactoryManager.create (index.js:499)

The problem is in CoreStore constructor

Same issue here...

Ember-Data 3.13+ isn't supported yet. There is a WIP PR at https://github.com/lytics/ember-data-model-fragments/pull/339

Thanks @jakesjews , I'm aware of this and downgraded to 3.12, just wanted to make sure that this was tracked

no problem @IAmJulianAcosta! This ticket reminded me that I needed to update the readme so it was helpful.

@jakesjews Would be awesome if you add an assertion that Ember Data is 3.12 or less. Maybe just a peerDependency? This error is hard to debug as the error is thrown very early and does not contain any helpful information.

I was getting this error on what appeared to be compatible versions: https://github.com/lytics/ember-data-model-fragments/issues/224#issuecomment-573101228

This is fixed in ED 3.17.1 and 3.18. It was a bug in the ED store.


Issues running on Termux

Hi
Thanks for your code.
I git cloned and checked out only your Alpine Linux branch and installed. But, this is my shell output:
❯ npm run dev

><EMAIL_ADDRESS>dev
> vite

  VITE v5.4.8  ready in 557 ms

  ➜  Local:   http://localhost:5173/
  ➜  Network: use --host to expose
  ➜  press h + enter to show help
Error: spawn /usr/bin/google-chrome ENOENT                                                                                at ChildProcess._handle.onexit (node:internal/child_process:286:19)
    at onErrorNT (node:internal/child_process:484:16)
    at process.processTicksAndRejections (node:internal/process/task_queues:90:21)

And, the container image booted up successfully in my browser, but as I am on a Tablet, I couldn't enter "root" at the login prompt. When I select the screen to type, the virtual keyboard is off screen and when the keyboard is back on screen, the field isn't selected, so it is a Catch 22! The hack I have learnt to get the keyboard back in similar situations, which in the Samsung flavour of Android is pressing a particular button, doesn't work in the browser context, like it does in other apps, such as Termux and RVMC Viewer, for example.

Generally, if I press the chevron button at the far right of the bottom bar of the Samsung Android OS, the virtual keyboard comes back onscreen, and then typing in the active field on the screenbis possible. But, doing the same hack in this situation and context, instead, moves the browser page to prior viewed page and so, the loaded and booted VM of the Alpine Linux image is lost! Any idea of a workaround?

Hi @b9Joker108 I don't think by default the v86 is configured as mobile friendly 😅
There is a work around using Xterm.js which may work better on a mobile tablet.
Check out this branch: https://github.com/nadchif/in-browser-virtual-machine/tree/boot-linux-terminal
Please try it out and share how it goes 🤞😊

I am a bit confused how I check out and git clone that branch. I was amazed that I actually did the last one successfully! Could you please spoon-feed me a bit more?

Sure,
First, clone the repository:
git clone https://github.com/nadchif/in-browser-virtual-machine.git

Then checkout the branch
git checkout boot-linux-terminal

I am a bit confused, as I installed the branch: boot-linux-terminal, which is the Alpine image, specifically last time and had the issue with the virtual keyboard, as per this issue. But, you are telling me pretty much to do the same thing, but have made a note about Xterm.js. I don't understand how I ensure that Xterm.js is specified, if I just do the same commands I did initially?


chore(publish) fix multi-arch publication check (jenkins-infra/helpdesk/issues/2890)

Description
This PR is related to jenkins-infra/helpdesk/issues/2890.
It fixes the publication script to ensure that all images declinations and Linux CPU architectures are checked for a given tag.
Once merged, this PR will rebuild and republish all the images for the following tags:
2.319.1
2.319.2
2.319.3
2.320
2.321
2.322
2.323
2.324
2.325
2.326
2.327
2.328
2.329
2.330
2.331
2.332
2.332.1
2.332.2
2.333
2.334
2.335
2.336
2.337
2.338
2.339
2.340
2.341
2.342
2.343
2.344

and also for lts + weekly
=> The rationale is that these tags all have at least 1 image that was re-published by the "quickstart" branch job (as per https://github.com/jenkins-infra/helpdesk/issues/2890#issuecomment-1104201895), leading to an outdated Docker image manifest (application/vnd.oci.image.index.v1+json wrapped under an application/vnd.docker.distribution.manifest.v2+json enveloppe, instead of an application/vnd.docker.distribution.manifest.list.v2+json which support multiple CPU architectures).
So we have to republish all of them now.
Testing
Running the script locally with the flag -n (dry run) led to a full docker buildx rebuil of ALL these tags. Means that the script works at least partially.
Check List

[x] Make sure you are opening from a topic/feature/bugfix branch (right side) and not your main branch!
[x] Ensure that the pull request title represents the desired changelog entry
[x] Please describe what you did
[x] Link to relevant issues in GitHub or Jira
[x] Link to relevant pull requests, esp. upstream and downstream changes
[x] Ensure you have provided tests - that demonstrates feature works or fixes the issue

I think you're proposing the best path forward.  The container images that were originally written by the weekly and LTS build processes have already been overwritten by the build from the "quickstart" branch.  We can't undo that change.  Since we can't undo that change, we're best served by running the build to update those images from the master branch.

Let's wait for Monday 25 then 👍

@timja @MarkEWaite I'm ready for this to be merged (trusted.ci is in good shape, I'll monitor)


qs1

add details about pg_qs.index_generation_interval

Learn Build status updates of commit aae68d5:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

articles/postgresql/flexible-server/concepts-query-store.md
:white_check_mark:Succeeded

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching the learn.microsoft.com contributor guidesPost your question in the Learn support channel

@ssen-msft
Can you review the proposed changes? IMPORTANT: When the changes are ready for publication, add a #sign-off comment to signal that the PR is ready for the review team to merge.
#label:"aq-pr-triaged"
@MicrosoftDocs/public-repo-pr-review-team

Learn Build status updates of commit 12f2f29:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

articles/postgresql/flexible-server/concepts-query-store.md
:white_check_mark:Succeeded

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching the learn.microsoft.com contributor guidesPost your question in the Learn support channel

@sunilagarwal
Thanks for the approval!
@ssen-msft
Could you review this proposed update to your article and enter #sign-off in a comment if it's ready for merge?
Thanks.

Hi Courtney,
I was able to review it offline; looks good.
My github-msft account is busted though (old phone broke, 2 FA auth app didn't "transfer"). Can you proceed with this note?
Thanks

From: Courtney Wales @.>
Sent: Monday, November 28, 2022 7:31 AM
To: MicrosoftDocs/azure-docs @.>
Cc: Saikat Sen @.>; Mention @.>
Subject: Re: [MicrosoftDocs/azure-docs] qs1 (PR #101459)
@sunilagarwalhttps://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fsunilagarwal&data=05|01|Saikat.Sen%40microsoft.com|3f203594d1ea4f785b1d08dad1559eec|72f988bf86f141af91ab2d7cd011db47|1|0|638052462910340606|Unknown|TWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D|3000|||&sdata=t%2B4DiKz8O98ut4ytDBZsMbLw1bZpPC8NCPILzvlnafM%3D&reserved=0
Thanks for the approval!
@ssen-msfthttps://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fssen-msft&data=05|01|Saikat.Sen%40microsoft.com|3f203594d1ea4f785b1d08dad1559eec|72f988bf86f141af91ab2d7cd011db47|1|0|638052462910340606|Unknown|TWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D|3000|||&sdata=B3GQ56AOZkILvEt3qqs08F3nY3Pc%2BaH%2FqOB7NY1nSEY%3D&reserved=0
Could you review this proposed update to your article and enter #sign-off in a comment if it's ready for merge?
Thanks.
—
Reply to this email directly, view it on GitHubhttps://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2FMicrosoftDocs%2Fazure-docs%2Fpull%2F101459%23issuecomment-1329303542&data=05|01|Saikat.Sen%40microsoft.com|3f203594d1ea4f785b1d08dad1559eec|72f988bf86f141af91ab2d7cd011db47|1|0|638052462910340606|Unknown|TWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D|3000|||&sdata=8y6VdT8xcJioIB%2BlidkazwZqpp%2B4Rnj%2F7zPM0T%2BgK8w%3D&reserved=0, or unsubscribehttps://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FANYO5C7NETVHJDCARDMEN3DWKTF5DANCNFSM6AAAAAASAXW7OA&data=05|01|Saikat.Sen%40microsoft.com|3f203594d1ea4f785b1d08dad1559eec|72f988bf86f141af91ab2d7cd011db47|1|0|638052462910340606|Unknown|TWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D|3000|||&sdata=%2F0lQNilYRt5mBVlUb6o%2FsTCBpMCFT3PwkXlebZcAJo0%3D&reserved=0.
You are receiving this because you were mentioned.Message ID: @.***>


Double Clicking XRef moves cursor to wrong field

Describe the bug
Double clicking on an XRef field to go to that location results in the one below it being selected and going to that location instead.
Environment (please complete the following information):

OS: Win 10
Java Version: 11
Ghidra Version: 10.1_DEV f00f7afa6b0d30f9032a9e3dbee43d3e340cc36a
Ghidra Origin: locally built

Additional context
This is a bit more difficult to reproduce than described but if you try it enough times you should encounter it.

This just changed recently.   I will see if I can find an example case.


Redesign loggers

Summary:
From @bob-carpenter

Our loggers should just take these, as in:
logger.info() << "Gradient evaluation took " << ...;
Or we should have a polyadic info function that could look like:
logger.info("Gradient evaluation took ", deltaT, " seconds");

Description:
Our loggers were introduced as a stepping stone to getting us to a better design.
We can use this issue to discuss different designs for the loggers.
Additional Information:
cc @sakrejda
Original comment from: https://github.com/stan-dev/stan/pull/2570#r201154784
Current Version:
v2.17.1

The current implementations are:
https://github.com/stan-dev/stan/blob/develop/src/stan/callbacks/logger.hpp
https://github.com/stan-dev/stan/blob/develop/src/stan/callbacks/stream_logger.hpp


[ENH] add type hinting to _shapelet_transform init

Reference Issues/PRs
Part of #1910 and references #1454

What does this implement/fix? Explain your changes.
Added type hints to __init__ method inside of _shapelet_transform.py
Does your contribution introduce a new dependency? If yes, which one?
New dependency added: "typing" library
Any other comments?

For parameters with optional values, which format is preferred for aeon?
A) Optional[int]
B) Union[None, int]
I think option A is the generally preferred, but I saw option B in other aeon code.
E.g. aeon/similarity_search/query_search.py
"contract_max_n_shapelete" parameter uses int, but has np.inf as a default.
Np.inf is a float. Is it ok to modify that parameter to be "int or float"?
E.g. contract_max_n_shapelet_samples: Union[int, float] = np.inf

PR checklist

For all contributions

[X] I've added myself to the list of contributors. Alternatively, you can use the @all-contributors bot to do this for you.
[X] The PR title starts with either [ENH], [MNT], [DOC], [BUG], [REF], [DEP] or [GOV] indicating whether the PR topic is related to enhancement, maintenance, documentation, bugs, refactoring, deprecation or governance.

ah sorry, still a WIP


Send search events to Google Analytics

Set up a Google Analytics thing for tracking searches people are doing on the apps and userland pages.

https://developers.google.com/analytics/devguides/collection/analyticsjs/sending-hits
https://developers.google.com/analytics/devguides/collection/analyticsjs/command-queue-reference#send


Post UX: A user can click on a post timestamp to view the individual post

Given that I am a user viewing planetary.link
When I click on the post timestamp
then I should be taken to the individual post page for that post.

Duplicate


Announcement: Lightning Inspector for Community Site Pages Issue with Winter '23

With the Winter '23 release you may run into issues using the Salesforce Lightning Inspector. Enhanced Domains have been turned on across all orgs as of the Winter '23 release, which causes the Lightning Inspector to break on Communities' Site Pages - a Known Issue has been created with some background as well.
As you may have noticed, this repository has not been very actively maintained over the past few years. We've had some internal changes, so please bear with us as we determine next steps with this product. A branch with the fix has been created, but this change has not been merged or deployed yet. In the meantime, you can build the Lightning Inspector locally with the fix by forking this repository, cloning this branch, and following the local setup steps here.
More detailed instructions below:

Fork this repository by clicking the Fork button in the top right corner

In the following screen, you can enter in a custom name for your repository or leave it the same

De-select the Copy the 'main' branch only checkbox at the bottom of the screen and click Create Fork

Clone the app locally through the CLI or by downloading the zip file

Open up your terminal and navigate to the directory containing your project ie. cd ~/aj/lightning-inspector-fork

Check out the branch containing the fix: git checkout pr/80. You should see a message like:

Branch 'pr/80' set up to track remote branch 'pr/80' from 'origin'.
Switched to a new branch 'pr/80'

Open up a browser like Google Chrome and type in chrome://extensions/
Click the Developer Mode checkbox in the top right corner
Click the Load Unpacked Extensions button in the left corner
Select the directory containing your fork ie. ~/aj/lightning-inspector-fork
You're ready to go!

We recognize this is a workaround and thank you all for the patience - enjoy inspecting!

Not sure it is working.  Removed the old one and Lightning tab not showing

I did finally get it working after doing a couple more steps...

I'm on Windows 11 and have had to make some tiny tweaks to get some of these commands to work.

I'm using NVM for Windows.
had to update package.json to use set instead of export
had to install windows build tools
had to run yarn config set msvs_version 2017 --global
but after all of that, everything appears to run successfully

In this order:

fork repo
clone locally
run setup
nvm install lts (nvm for windows doesn't use the --)
npm install yarn -g
yarn install
yarn build
git checkout pr/80
I'm using Edge (chromium) so I opened Edge and went to extensions and followed the steps above. Dev Mode > load unpackaged > picked my cloned directory > it shows up in my list of extensions but says it has errors
With the dev console open, Lightning Inspector is never an option in the toolbar across the top.

I've also done all of this on actual Chrome and got the same results.
I've also run all of the setup commands on the pr/80 branch directly and tried reloading the extension. no go.
any thoughts?


Accept payload as byte array

Related Github tickets

#465
#464

Background
Changes the input type for the payload variable from string to byte. Serializing string as byte[] is a bit clumsy.
Testing completed

[ ] a list of actions that you've performed to ensure that this PR works as intended
[ ] 99% of the times you should have an item: "wrote tests"

Breaking changes

[ ] I have checked my code for breaking changes
[ ] If there are breaking changes, there is a supporting migration.

Does this also mean the contract will need to encode everything appropriately for the receiver chain?

Yes. BTW just to mention this once again, this way of executing jobs is a temporary one. Once I start my work on gas management & scheduler, you'd only need to pass in the job_id and payload.


clickhouse doesn't start when using HTTPS Port

I installed ClickHouse on Ubuntu 18.04.
I want to use HTTPS.
I added following line to the config.xml file
<listen_host>::</listen_host>
Until now everything is working fine, but when I add one of the following lines
<https_port>8443</https_port> <tcp_port_secure>9440</tcp_port_secure>
and then try to start clickhouse-server I get following error
● clickhouse-server.service - ClickHouse Server (analytic DBMS for big data)
   Loaded: loaded (/etc/systemd/system/clickhouse-server.service; enabled; vendor preset: enabled)
   Active: activating (auto-restart) (Result: exit-code) since Thu 2018-12-27 15:11:15 CET; 308ms ago
  Process: 17525 ExecStart=/usr/bin/clickhouse-server --config=/etc/clickhouse-server/config.xml (code=exited, status=70)
  Process: 17524 ExecStartPre=/bin/chown clickhouse:clickhouse -R /etc/clickhouse-server (code=exited, status=0/SUCCESS)
  Process: 17523 ExecStartPre=/usr/bin/chown clickhouse:clickhouse -R /etc/clickhouse-server (code=exited, status=0/SUCCESS)
 Main PID: 17525 (code=exited, status=70)

I found an issue where someone had the same error
https://github.com/yandex/ClickHouse/issues/1981#issuecomment-411760273
But when I change the user to root as suggested in the comment I just get another error.
● clickhouse-server.service - ClickHouse Server (analytic DBMS for big data)
   Loaded: loaded (/etc/systemd/system/clickhouse-server.service; enabled; vendor preset: enabled)
   Active: activating (auto-restart) (Result: exit-code) since Thu 2018-12-27 15:29:11 CET; 1s ago
  Process: 17689 ExecStart=/usr/bin/clickhouse-server --config=/etc/clickhouse-server/config.xml (code=exited, status=232/ADDRESS_FAMILIES)
  Process: 17688 ExecStartPre=/bin/chown clickhouse:clickhouse -R /etc/clickhouse-server (code=exited, status=0/SUCCESS)
  Process: 17687 ExecStartPre=/usr/bin/chown clickhouse:clickhouse -R /etc/clickhouse-server (code=exited, status=0/SUCCESS)
 Main PID: 17689 (code=exited, status=232/ADDRESS_FAMILIES)

Dec 27 15:29:11 ubuntu systemd[1]: clickhouse-server.service: Main process exited, code=exited, status=232/ADDRESS_FAMILIES
Dec 27 15:29:11 ubuntu systemd[1]: clickhouse-server.service: Failed with result 'exit-code'.

How can I configure HTTPS and use it?

Please, show clickhouse-server logs. Even when server cannot start it write some information to log files.

I'm sorry I should have looked in the error logs first, the problem is solved.
There was a problem with a certificate.


netbox-sync removes and adds the same data without changes

netbox-sync changes the "Untagged VLAN" field of the vmk ports for ESXi hosts on each run. During a run, the VLAN is entered. On the next run it is removed again and so on.
This leads to a lot of changes in the changelog. I am sure that no changes have been made to the vCenter or ESXi host between each sync.
first run:
2022-10-10 13:39:01,689 - DEBUG2: Trying to find prefix for IP: <IP_ADDRESS>/16
2022-10-10 13:39:01,698 - DEBUG2: Found IP '<IP_ADDRESS>/16' matches global prefix '<IP_ADDRESS>/16'
2022-10-10 13:39:01,731 - DEBUG2: Found existing NetBox IP address object: <IP_ADDRESS>/16
2022-10-10 13:39:01,731 - DEBUG2: Parsing 'IP address' data structure: <IP_ADDRESS>/16
2022-10-10 13:39:01,731 - DEBUG2: Found matching prefix VLAN 24 (DC-01) for untagged interface VLAN.
2022-10-10 13:39:01,732 - DEBUG2: Parsing 'interface' data structure: vmk0 (tstesx201.b00.dc01b.example.com)
2022-10-10 13:39:01,732 - INFO: Interface 'vmk0 (tstesx201.b00.dc01b.example.com)' attribute 'untagged_vlan' changed from 'None' to '24 (DC-01)'
2022-10-10 13:39:01,732 - DEBUG: Updated interface object: vmk0 (tstesx201.b00.dc01b.example.com)
2022-10-10 13:39:01,732 - DEBUG2: Parsing 'interface' data structure: vmk1 (tstesx201.b00.dc01b.example.com)
2022-10-10 13:39:01,732 - DEBUG2: Trying to find prefix for IP: <IP_ADDRESS>/16
2022-10-10 13:39:01,741 - DEBUG2: Found IP '<IP_ADDRESS>/16' matches global prefix '<IP_ADDRESS>/24'
2022-10-10 13:39:01,747 - DEBUG2: Found existing NetBox IP address object: <IP_ADDRESS>/16
2022-10-10 13:39:01,747 - DEBUG2: Parsing 'IP address' data structure: <IP_ADDRESS>/16
2022-10-10 13:39:01,747 - DEBUG2: Found matching prefix VLAN 4 (vMotion) for untagged interface VLAN.
2022-10-10 13:39:01,747 - DEBUG2: Parsing 'interface' data structure: vmk1 (tstesx201.b00.dc01b.example.com)
2022-10-10 13:39:01,747 - INFO: Interface 'vmk1 (tstesx201.b00.dc01b.example.com)' attribute 'untagged_vlan' changed from 'None' to '4 (vMotion)'
2022-10-10 13:39:01,747 - DEBUG: Updated interface object: vmk1 (tstesx201.b00.dc01b.example.com)

second run:
2022-10-10 13:58:53,936 - INFO: Setting attribute 'untagged_vlan' for 'vmk0 (tstesx201.b00.dc01b.example.com)' to None
2022-10-10 13:58:53,936 - DEBUG2: Trying to find prefix for IP: <IP_ADDRESS>/16
2022-10-10 13:58:53,945 - DEBUG2: Found IP '<IP_ADDRESS>/16' matches global prefix '<IP_ADDRESS>/16'
2022-10-10 13:58:53,978 - DEBUG2: Found existing NetBox IP address object: <IP_ADDRESS>/16
2022-10-10 13:58:53,978 - DEBUG2: Parsing 'IP address' data structure: <IP_ADDRESS>/16
2022-10-10 13:58:53,978 - DEBUG2: Found matching prefix VLAN 24 (DC-01) for untagged interface VLAN.
2022-10-10 13:58:53,979 - DEBUG2: Parsing 'interface' data structure: vmk0 (tstesx201.b00.dc01b.example.com)
2022-10-10 13:58:53,979 - DEBUG2: Parsing 'interface' data structure: vmk1 (tstesx201.b00.dc01b.example.com)
2022-10-10 13:58:53,979 - INFO: Setting attribute 'untagged_vlan' for 'vmk1 (tstesx201.b00.dc01b.example.com)' to None
2022-10-10 13:58:53,979 - DEBUG2: Trying to find prefix for IP: <IP_ADDRESS>/16
2022-10-10 13:58:53,988 - DEBUG2: Found IP '<IP_ADDRESS>/16' matches global prefix '<IP_ADDRESS>/24'
2022-10-10 13:58:53,994 - DEBUG2: Found existing NetBox IP address object: <IP_ADDRESS>/16
2022-10-10 13:58:53,994 - DEBUG2: Parsing 'IP address' data structure: <IP_ADDRESS>/16
2022-10-10 13:58:53,994 - DEBUG2: Found matching prefix VLAN 4 (vMotion) for untagged interface VLAN.
2022-10-10 13:58:53,995 - DEBUG2: Parsing 'interface' data structure: vmk1 (tstesx201.b00.dc01b.example.com)

Hi @cfrietschy,
apologies for not even commenting on your bug report. This should not happen. I will have a look into it.

Hey,
I'm trying to fix this bug but unsure how to investigate it probably and need your help 😃.
Would you be able to run the script with a host_include_filter set to this particular host where this is happening? I would need the output of -l DEBUG3 redirected to a file.
Then two or three runs where this behavior is observable. That should definitely cover it and then I would be able to debug it easily.
Thank you very much.

Which part of the log do you need exactly? I run it 3 times and the log is 238M in size. :)

Wow, that's great. I know it's huge. If you tar.gz it it should get quite a bit smaller. You could send it to my mail address here:
https://github.com/bb-Ricardo/fritzinfluxdb/blob/468d3900dc08920257be22c0871531ed941579f7/fritzinfluxdb.py#L32

Hey, just wondering. Did you already send the logs? Haven't received anything, so was just curious.

Hey, just wondering. Did you already send the logs? Haven't received anything, so was just curious.

No, I have not sent the logs yet. Unfortunately, I have to anonymize the data first. Otherwise I can't send them to you. I haven't had time to do that yet.

Well if it helps, I would just need all the log lines of the host parsing part including the output from the VMWare API.

Hi,
I tried to replicate this with a clean instance of NetBox and only one source, with the target of reducing the log file size. Unfortunately I was unable to reproduce this.
Log files contains too many sensitive information to be shared.
How can we tackle this?

any updates? would a remote session be possible?

Hey,
Thank you for looking into this. This is definitely a possibility and I already have an idea of how to mitigate this.
Would need to keep the original attribute content until the end and drop attributes from syncing if current content and original content are the same.

And for the "which component is the right value" problem, you could just add to the documentation, that the last source will overwrite those. Or better make it configurable, which source will be the "true source"

Hey @sHorst @rizlas @cfrietschy,
I just pushed a new commit to the development branch. Would you be able to test if this fixes the observed behaviour?
Thank you

hey, it fixes the issue, only the first element will set the field .. in the default configuration (order vcenter/redfish) this leads to no description in netbox. It would be better to have it the other way around, but it fixes the problem.

The last source should set the final attribute value.
At least thats how it is implemented.

correct, thought the description was comming from the other source .. but my point stands, that in the default, it will lead to the description net beeing set, for interfaces, since the redfish import will set it to '', the vcenter will set it to the connected vSwitch.

Hi, we are experiencing the same behaviour. When we set "disable_vlan_sync" to "False", NetBox Sync changes the vlan assigned to the vNICs each time it runs. The first time it sets the vlan to None, the second time it sets the vlan to the correct value, the third time it sets the vlan to None, the fourth time it sets the vlan to the correct value, and so on. Always without making any changes to NetBox or vCenter.
All retrieved vlans are already present in Netbox.
When "disable_vlan_sync" is "True" the problem does not occur.
We also tried with the development branch but the behaviour is the same.
The DEBUG log is very verbose and full of sensitive data, which line are you interested in? Anonymising it is very laborious.
Thank you

Did you try to reorder the sorces in the config file? The last one sets the value, even though the log will tell you the intermediate value.

Hi, we are experiencing the same behaviour. When we set "disable_vlan_sync" to "False", NetBox Sync changes the vlan assigned to the vNICs each time it runs. The first time it sets the vlan to None, the second time it sets the vlan to the correct value, the third time it sets the vlan to None, the fourth time it sets the vlan to the correct value, and so on. Always without making any changes to NetBox or vCenter.
All retrieved vlans are already present in Netbox.
When "disable_vlan_sync" is "True" the problem does not occur.
We also tried with the development branch but the behaviour is the same.
The DEBUG log is very verbose and full of sensitive data, which line are you interested in? Anonymising it is very laborious.
Thank you

How many sources are you using in your configuration?

Still happening in dev branch.
My config is:
One source in config file
disable_vlan_sync = True
ignore_unknown_source_object_pruning = true

Yes, this seems to be a different issue. Then one which got fix definitely stemmed feom having more then one source and the same attribute gets overwritten.
@rizlas A short online debug session?

Mail incoming

@rizlas Do you have vlan_sync enabled or disabled? From our conversation I remember you disabled it a few month ago. Just wanted to be sure.

Yes it is disabled

This seems to be the issue. Just for testing purposes would you be able to enable this option again and try to sync a few times and see if it still occurs?
exactly what @francesco-noc described in his https://github.com/bb-Ricardo/netbox-sync/issues/245#issuecomment-1589442477

Hey @rizlas, @francesco-noc,
I just pushed a fix to the "fix/disable-vlan-sync-option-#245" branch. Would you be able to checkout this branch and run a few tests?
Thank you.

Yeah 🙌🏻 this is it. My side it is fixed for both hosts and vms virtual interfaces.

I have to run a few additional tests but it should work now.

Same behavior with disable_vlan_sync = False

Awesome, thank you for the feedback. Probably gonna be a 1.5.0


Groupby-Apply runs function twice for each group

Example:

import time
import pandas as pd
import dask.dataframe as dd

def func(df):
    print("Processing ...")
    total = sum(df['D'])
    time.sleep(5)
    print("Processed: {}".format(total))
    return total

def create_pandas_df():
    return pd.DataFrame({'A': "test", 'B': "foo", 'C': "bar", 'D': [1, 2, 3, 4, 5]})

def main():
    df = create_pandas_df()
    print(df)
    ddf = dd.from_pandas(df, npartitions=1)

    keys = ['A', 'B', 'C']
    # Data only has one group if groupby A,B,C
    result = ddf.groupby(keys).apply(func, meta=('total', 'int')).compute()

    print(result)

if __name__ == '__main__':
    main()

Output:
      A    B    C  D
0  test  foo  bar  1
1  test  foo  bar  2
2  test  foo  bar  3
3  test  foo  bar  4
4  test  foo  bar  5
Processing ...
Processed: 15
Processing ...
Processed: 15
A     B    C
test  foo  bar    15
Name: total, dtype: int64

Sample data only has one group but user function with sleep(5) is executed twice for same group. I don't believe it's a bug which we didn't find out earlier. I'm confused here. I want to understand what happened in the back for handling this one group calculation.
Dask version: 0.17.0

Dask dataframe runs the function once immediately to determine types.  You can avoid this extra call by providing metadata with the meta= keyword.

The

The initial call is on a tiny fake dataset, and so usually doesn't take much time.

Thanks for super fast response! How can I pass meta when creating dask dataframe by read_csv()?
In this example, it sleeps twice instead of once which caused extra cost.

In this case this is pandas calling your function twice, not dask:
In [7]: type(df)
Out[7]: pandas.core.frame.DataFrame

In [8]: df.groupby(['A', 'B', 'C']).apply(func)
Processing ...
Processed: 15
Processing ...
Processed: 15
Out[8]:
A     B    C
test  foo  bar    15
dtype: int64

From the pandas docstring:
Notes
-----
In the current implementation ``apply`` calls func twice on the
first group to decide whether it can take a fast or slow code
path. This can lead to unexpected behavior if func has
side-effects, as they will take effect twice for the first
group.

For dask, this twice-on-first-group thing will happen for each partition. So the duplication could be more than once - depend on partition number.

For dask, this twice-on-first-group thing will happen for  each partition. So the duplication could be more than once - depend on  partition number.

Correct. Dask just calls groupby-apply on each partition. The only thing you can do as a user is make sure you pass in meta to groupby(...).apply(func, meta=...), which will make sure func isn't called until compute time where it can happen in parallel or across a cluster.

Got it. Thank you!

For dask, this twice-on-first-group thing will happen for  each partition. So the duplication could be more than once - depend on  partition number.

Correct. Dask just calls groupby-apply on each partition. The only thing you can do as a user is pass in meta to groupby(...).apply(func, meta=...), which will ensure func isn't called until compute time where it can happen in parallel or across a cluster.

Is this true? Even when I use meta in my usage, I've found that each partition/group is still being executed twice. Is there a particular version of dask that has the meta keyword preventing the double execution? This is quite problematic for me as my group by apply has side effects.

Do you have an example of it applying twice?
In [8]: df = pd.DataFrame({"A": [1, 2, 3, 4], "B": ['a','a', 'b', 'b']})

In [9]: ddf = dd.from_pandas(df, 2)

In [10]: def f(x):
    ...:     print(x)
    ...:     return x
    ...:


Having so much red underlined code (errors) makes VSCode very slow to edit these files

VSCode Version: 1.22.1
OS Version: MacOS 10.12.6

Steps to Reproduce:
(I'm using the Flow Language Support extension and mostly experience it when the extension marks a big bunch of code as having errors but this issue spans other files that have large amount of text with errors.)

Have a big amount of text underlined in red (having errors)
Performance of VSCode in this file becomes so slow to be able to edit this file

@sharno Can you please give a very specific example, like a file which reproduces this consistently for you

@alexandrudima
I don't remember though how to reproduce it in other files without using Flow.
So, this is a dummy repo I made for this issue: https://github.com/sharno/vscode-performance-errors. You'll probably just need to do an npm install and install the Flow Language Support extension to make the errors appear in the editor

I can reproduce some slowness. Each line has about 15 errors. i.e. there are 15 errors that span almost the entire file. The browser is a bit struggling to paint so many squiggles. Note the somewhat high Paint times:

To investigate if we could deduplicate error squiggles and have only one drawn per line instead of the current N overlapping.


Angular CLI Installation Error

I am using npm version 3.10.10, when I try to install angular-cli (npm install -g @angular/cli) it will only creating "npm-debug" file in folder.
npm-debug.log

I am getting same issue

Heya, I went through the log you posted and the error seems to be this:
92427 verbose stack Error<EMAIL_ADDRESS>postinstall: `node lib/post_install.js`
92427 verbose stack spawn C:\Windows\system32\cmd.exe;C:\Program Files\MongoDB\Server\3.4\bin ENOENT
92427 verbose stack     at exports._errnoException (util.js:1020:11)
92427 verbose stack     at Process.ChildProcess._handle.onexit (internal/child_process.js:197:32)
92427 verbose stack     at onErrorNT (internal/child_process.js:376:16)
92427 verbose stack     at _combinedTickCallback (internal/process/next_tick.js:80:11)
92427 verbose stack     at process._tickCallback (internal/process/next_tick.js:104:9)
92428 verbose pkgid<EMAIL_ADDRESS>92429 verbose cwd C:\Users\admin\Desktop\centralogic\angular-clone
92430 error Windows_NT 6.1.7601
92431 error argv "C:\\Program Files\\nodejs\\node.exe" "C:\\Program Files\\nodejs\\node_modules\\npm\\bin\\npm-cli.js" "install" "-g" "@angular/cli"
92432 error node v6.11.3
92433 error npm  v3.10.10
92434 error file C:\Windows\system32\cmd.exe;C:\Program Files\MongoDB\Server\3.4\bin
92435 error path C:\Windows\system32\cmd.exe;C:\Program Files\MongoDB\Server\3.4\bin
92436 error code ELIFECYCLE
92437 error errno ENOENT
92438 error syscall spawn C:\Windows\system32\cmd.exe;C:\Program Files\MongoDB\Server\3.4\bin
92439 error<EMAIL_ADDRESS>postinstall: `node lib/post_install.js`
92439 error spawn C:\Windows\system32\cmd.exe;C:\Program Files\MongoDB\Server\3.4\bin ENOENT
92440 error Failed at the<EMAIL_ADDRESS>postinstall script 'node lib/post_install.js'.
92440 error Make sure you have the latest version of node.js and npm installed.
92440 error If you do, this is most likely a problem with the uglifyjs-webpack-plugin package,
92440 error not with npm itself.
92440 error Tell the author that this fails on your system:
92440 error     node lib/post_install.js
92440 error You can get information on how to open an issue for this project with:
92440 error     npm bugs uglifyjs-webpack-plugin
92440 error Or if that isn't available, you can get their info via:
92440 error     npm owner ls uglifyjs-webpack-plugin
92440 error There is likely additional logging output above.
92441 verbose exit [ 1, true ]

It seems to be something with your MongoDB install and the<EMAIL_ADDRESS>package. Perhpas node from there is causing problems?
You should open an issue at their repository: https://github.com/webpack-contrib/uglifyjs-webpack-plugin


By not providing "FindCeres.cmake" in CMAKE_MODULE_PATH this project has   asked CMake to find a package configuration file provided by "Ceres", but  CMake did not find one.

Hello,
I am new to Linux and ROS, and I can't comprehend this warning.
I am having trouble installing Cartographer to use on my Raspberry Pi. I am using Ubuntu 20.04 and ROS Noetic.  I already installed Ceres-Solver, but this is still popping up.
Please let me know what I can do to fix this problem.

Hy.
It migth be too late for you, but I faced the same problem and I just wanted to share the solution I found in case someone else need it. I'm using Ubuntu 20.04 and Ros2 Humble (which forced me to do all the installation from source).
First, how did i get here. I found some problems with this packages regarding something about the "abs" library. I found the solution at this post #1726, but then I got the same problem you are facing. The solution was quite easy, since I just needed to install the following libraries (I found it on stack overflow, question 65588745, but i dont know if I'm allow to link it):
sudo apt install libgoogle-glog-dev
sudo apt-get install libgflags-dev
sudo apt-get install protobuf-compiler libprotobuf-dev
Then a new problem appear since "SuitSparse" was not found. I tried almost everything from the issue 993 of the package "cartographer" (cartographer_project -> cartographer). I recommend everyone to look at that post since you may find different answers which may be even better than mine. I changed the "Cmake.txt" from that package as explained in the issue. At line 39, where it looks for the Ceres package just erase the "Required components" part.
Finally I got a problem with "PCL". just install the library as i explained before sudo apt install libpcl-dev, get the ros packages "perception_pcl" and "pcl_msg" and with that everything should work.
Sorry for such a long answer, but I hope it helps you.
Regards.


docs: removed repetitive text in the hero paragraph

It originally contained the phrase: "The Virtual DOM Replacement for React." twice.
Please describe the changes this PR makes and why it should be merged:
Status

[ ] Code changes have been tested against prettier, or there are no code changes
[ ] I know how to update typings and have done so, or typings don't need updating

Semantic versioning classification:

[ ] This PR changes the codebase

[ ] This PR includes breaking changes (methods removed or renamed, parameters moved or removed)
[ ] This PR changes the internal workings with no modifications to the external API (bug fixes, performance improvements)

[ ] This PR only includes non-code changes, like changes to documentation, README, etc.

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.


Update handler should use UpdateItem

Currently it does a full replace using dynamodb "PutItem", but maybe we want to do "UpdateItem"
Otherwise we ought to change the swagger to use the PUT action rather than the PATCH action.
Ref #47

Connected to #229

Closing in favor of overwriting item to avoid duplicate complexity of update statements.

Aaron, should we switch back to PUT then?

Not in my opinion, since were not moving the resource to a new identifier. The merging still occurs, just not in the database directly.


Add a ready-check.sh script to take advantage of OpenShift lifecycle management

https://github.com/openshift/openshift-tools/pull/3318

[test]

[ok to test]


Design System > Component > Top Navigation > Ecommerce 4 > Text overlapping issue

Describe the bug
Text overlapping issue
Steps to reproduce bug
1.Go to 'https://stage-react.raaghu.ai/?path=/story/components-top-navigation--ecommerce-4'
2. Navigate to 'Component > Top Navigation > Ecommerce 4  '
Actual result-
Text overlapping issue
Screenshots

Expected result-
Text should not be overlapped

Fixed on staging

Fixed on stage


Fix JSON property deserialization

incorrect naming preventing correct deserialization
  - snake/camel case conversion not configured properly
  - non-standard extra underscores before numeral in address_line_1/2
add appropriate Jackson JSON annotations to make use of builders

have submitted:
        "residential_address": {
            "address_line_1": "string",
            "address_line_2": "string",
            "care_of": "string"
        }

and correctly stored in db:
    "_id" : ObjectId("63329fda0699894a4820301e"),
    "name" : "bob1",
    ...
    "resigned_on" : ISODate("2022-09-20T00:00:00.000Z"),
    "residential_address" : {
        "address_line_1" : "string",
        "address_line_2" : "string",
        "care_of" : "string"
    },
    "_class" : "uk.gov.companieshouse.officerfiling.api.model.entity.OfficerFiling"
}

this PR resolves defect DACT-134 - to be added to descriptions


samples limit is not honored by failed rows checks

We discovered an issue with sample limits not being applied when using failed row checks.
checks for my_db.my_table [daily]:
    - failed rows:
        samples limit: 5
        # Any row that matches this dataset filter fails
        fail condition: 1 = 1
        name: test check

Some things we've tried with a similar configuration as above:

Even though the samples limit is explicitly defined in the check, the sampler collects the complete dataset, not applying the limit of 5 as specified in the definition.
The bug is apparent when using both the fail condition  and fail query .
If the samples limit is left out of the definition, still the whole dataset is collected, and not the default of 100 rows as mentioned in the documentation.
Other  types of checks do correctly apply the samples limit, we've verified this with failed_count  and missing_count checks. The LIMIT can be seen being applied when inspecting the SQL queries generated by Soda.

Confirmed not working on Soda Core 3.1.2
Mention in soda-core channel in the soda community slack
To reproduce the issue
from pyspark.sql import SparkSession
from soda.scan import Scan
from soda.sampler.sampler import Sampler, SampleContext

# custom sampler to print the amount of rows being sampled
class CountRowsSampler(Sampler):
    def store_sample(self, sample_context: SampleContext):
        print(f'sample size: {len(sample_context.sample.get_rows())}')

spark_session = SparkSession.builder.config('spark.app.name', 'pytest-spark').getOrCreate()

# 101 entries, to see that the sampler does not honor the explicit(5) or default limit(100)
data = [['1']] * 101
df = spark_session.createDataFrame(data=data, schema=['number_one'])
df.createOrReplaceTempView('dataframe')

# setup the scan
scan = Scan()
scan.add_spark_session(spark_session=spark_session)
scan.set_data_source_name('spark_df')

check = """
checks for dataframe:
    - failed rows:
        samples limit: 5
        # Any row that matches this dataset filter fails
        fail condition: 1 = 1
"""
scan.add_sodacl_yaml_str(check)
scan.sampler = CountRowsSampler()

scan.execute()

prints:
sample size: 101

SAS-2664

I made a first attempt at a partial fix for this: https://github.com/sodadata/soda-core/pull/1986
This works for the failed row checks that use fail condition. For those checks it was possible to decouple the sampling from executing the check, by making allow_samples an adjustable argument on Query.store. The UserDefinedFailedRowsExpressionQuery executes an additional SampleQuery after calling its parent's store method to collect and store the samples.
However this approach doesn't work for the failed row checks that use fail query. The coupling between sampling and evaluating the result of the check was heavier and I couldn't figure out how to do it without having to refactor larger parts of  the code that are used for this check. The calculation of the failed_row_count metrics for these types of check rely on collecting the whole sample and calculating the size of the returned dataset. Applying a limit implicitely would mean this metric would be off for any checks that return a row count higher than the sample limit.
Can I get some thoughts from the Soda Team on:

my approach for the failed row checks that use fail condition. Does it make sense? I don't fully grasp the Soda codebase and architecture yet, but I thought this made sense.  I saw the same strategy is applied by the DuplicateQuery and the  ReferenceQuery
Do you see any easy way for fixing it for the failed row checks that use fail query? Or is my assesment correct that it most likely needs a bigger refactoring effort to make it happen?

After your initial replies I'll have a look at adding unit tests to the PR

When going over my first solution with a colleague, I realised this is not going to solve the issue for us because of the whole dataframe still being collected for failed row checks that use fail condition on this line to compute the number of failed rows: https://github.com/sodadata/soda-core/blob/main/soda/core/soda/execution/query/query.py#L204
Calculating the number of failed rows by retrieving the complete dataset and computing the length of it, has scaling limitations, which we encounter pretty frequently in our environment. Going around that needs refactoring on a deeper level than what my solution provides so far. When I have time, I'll try to figure out what is needed to solve the root cause of this scaling limitation

Could we add get_row_length functionality in the class DbSample(Sample) like so?
    def get_row_length(self) -> int:
        if not self.row_length:
            try:
                client = bigquery.Client()

                result = client.query(f"SELECT COUNT(*) FROM `{self.data_source}`").result()

                self.row_length = next(iter(result)).values()[0]
            except:
                self.row_length = len(self.cursor.fetchall())

        return self.row_length
        ```

This was addressed in 3.3.5, you can now have user defined metric check with a failed rows query in one check, making the failed rows sample possible to be limited.
We do not want to do any post-fact limit (i.e. use the sample limit after collecting data) as that would hinder the performance, memory consumption and act inconsistently with other checks where all limits are applied to the sample queries.


[DSS-363]: Carousel buttons non-functional in React

Description
The Previous/Next button action in the React version of the Carousel does not function.
Screenshots

Carousel

Testing in sage-lib

Navigate to Carousel
Verify next and prev arrow now function

Testing in kajabi-products

(LOW) Fix for prev/next arrow functionality in the Carousel React component.

Related
DSS-363

Here is another approach and a little more common use of calling functions.

Appreciate the suggestion! Works great and I've updated it to use that approach. Thanks again!

:shipit:


Can't make shared overlay when make RaceData.

I am making new race.
I separated race model and made slots(torso, hand, feet, head etc).
Separated slot share 1 overlay like HumanMale example( only torsor, feet, hand, legs are shared)

Add torso_slot to baseRecipe.
Add torso_overlay to torso_slot.
To share torso_overlay by leg_slot, drop leg_slot to "Add Slot" in inspector of torso_slot.
Can't share torso_overlay by leg_slot.

I can't make share overlay like example race.
Is this issue?

Hi, this is a known issue.  It should be fixed in the release-26 branch, we just haven't pushed it to the store yet.  You want to try grabbing that is see if it fixes your issue?
If you want to just overwrite the affected files, they are:
SlotData.cs
CharacterBaseEditor.cs
RecipeEditor.cs
DynamicCharacterAvatar.cs

working beautifully~
thank you a lot!


v2.0-rc

NEXT MAJOR release
The following items are to be included with the next release of the auro-flighline, all PRs are to be from the feature branch to v2.0-rc branch.

[ ] https://github.com/AlaskaAirlines/auro-flightline/issues/15
[ ] https://github.com/AlaskaAirlines/auro-flightline/issues/4
[ ] #25

closing in favor of issues and milestones


Watch task does not support entry points with only CSS

Submit a feature request or bug report

[x] I've read the guidelines for Contributing to Roots Projects
[ ] This is a feature request
[x] This is a bug report
[x] This request isn't a duplicate of an existing issue
[x] I've read the docs and NPM Debugging Guidelines post and followed them (if applicable)
[x] This is not a personal support request that should be posted on the Roots Discourse forums

What is the current behavior?
Adding an entry point in resources/assets/config.json with only a SCSS file does not inject the CSS using HMR.
What is the expected or desired behavior?
Adding an entry point with only a stylesheet should inject the CSS with HMR.

Bug report
When I began writing this issue I thought this related to secondary entry points in general but turns out that this only happens when it's an entry point without a script file. I guess this might be a webpack limitation? As this still works as expected when building the assets using yarn run build, but not when using yarn run start, I'll stick to filing this as a bug report.
Please provide steps to reproduce, including full log output:

Create a resources/assets/styles/secondary.scss file
echo "body { background-color: #ccc; }" >| resources/assets/styles/secondary.scss

Add a second entry point in resources/assets/config.json
{
  "entry": {
    "main": [
      "./scripts/main.js",
      "./styles/main.scss"
    ],
    "secondary": [
      "./styles/secondary.scss"
    ],
    "customizer": [
      "./scripts/customizer.js"
    ]
  },
  ....
  ]
}

Enqueue the stylesheet in `app/setup.php
add_action('wp_enqueue_scripts', function () {
    wp_enqueue_style('sage/main.css', asset_path('styles/main.css'), false, null);
    wp_enqueue_style('sage/secondary.css', asset_path('styles/secondary.css'), false, null);
    wp_enqueue_script('sage/main.js', asset_path('scripts/main.js'), ['jquery'], null, true);
}, 100);

Launch the watch process
yarn run start

Note that the background color is white rather than gray.

Notes:

__webpack_hmr event source message which contains the second entry point.
dev tools screenshot showing that the stylesheet is enqueued but only one style blob is delivered (main).

Please describe your local environment:
WordPress version: 4.8
OS: macOS Sierra
NPM/Node version: 5.0.3/8.1.0
Where did the bug happen? Development or remote servers?
Development
Is there a related Discourse thread or were any utilized (please link them)?
https://discourse.roots.io/t/managing-scss-themes-with-webpack/9293

Thanks for taking the time to provide such a detailed issue report. This will definitely be helpful. I'll try to address this issue this weekend.
Does it work if you add an empty scripts/secondary.js file?
touch resources/assets/scripts/secondary.js

  "entry": {
    "main": [
      "./scripts/main.js",
      "./styles/main.scss"
    ],
    "secondary": [
      "./scripts/secondary.js",
      "./styles/secondary.scss"
    ],
    "customizer": [
      "./scripts/customizer.js"
    ]
  }

If that works, then the quick fix is as simple as iterating over all entry points and appending a js file if there isn't one already.

Unfortunately no. In addition to what you mentione, I also have to enqueue the script for the stylesheet to get loaded.

Yea I'm having the same issue. I'm trying to have multiple css files to optimize the front end. The build command works fine but the watch command does not save multiple css files into the dist/ folder. Is there a fix coming soon for this? I'm having to run yarn build every time I update my stylesheets.

@myleshyson afaik there's no fix. It's part of the roadmap for webpack but probably wont exist for a while:

https://medium.com/webpack/the-new-css-workflow-step-1-79583bd107d7
https://github.com/webpack/webpack/issues/5046

It's still something I might be able to address via BrowserSync. BS writes its own script snippet that gets loaded onto every page, and I know that snippet can be customized. I think I could use that feature of BS to load the script that serves the styles; this would actually enable me to serve everything in memory, which would hopefully improve performance.
For now the workaround would be to enqueue the script file that gets generated during development.
Something like this should work:
if (WP_ENV === 'development')
    wp_enqueue_script('sage/secondary.js', asset_path('scripts/secondary.js'), [], null, true);
}

(To be clear, yes you want to load a SCRIPT. During normal yarn build, that script is empty, but during watch, that script is what loads your styles.)

I ended up just replacing the build system with Laravel Mix and it worked exactly as expected with browsersync. I have two files (main.css and critical.css) and they both compile with BS. I love Sage, and definitely not trying to say Sage should use Laravel Mix, but I guess I'm wondering whats different about the way the sage build system works vs Laravel Mix?

Do you have any snippet to provide about Mix "-isation" of the build ? Thx !

Hey @mtx-z sure thing.
I deleted the resources/assets/build/ directory and completely replaced package.json with the default Laravel package.json. I replaced some packages then installed via yarn.
Then I copied the webpack.mix.js and webpack.config.js to the root directory
cp node_modules/laravel-mix/setup/** ./

Then in config/assets.php I changed the manifest directory to mix-manifest.json instead of assets.json.
And that's it! Here is my webpack.mix.js file
let mix = require('laravel-mix');
let ImageminPlugin = require('imagemin-webpack-plugin').default;
let CopyWebpackPlugin = require('copy-webpack-plugin');
let imageminMozjpeg = require('imagemin-mozjpeg');

/*
 |--------------------------------------------------------------------------
 | Mix Asset Management
 |--------------------------------------------------------------------------
 |
 | Mix provides a clean, fluent API for defining some Webpack build steps
 | for your Laravel application. By default, we are compiling the Sass
 | file for your application, as well as bundling up your JS files.
 |
 */

mix.js('resources/assets/scripts/main.js', 'scripts/')
   .js('resources/assets/scripts/customizer.js', 'scripts/')
   .sass('resources/assets/styles/main.scss', 'styles/')
   .sass('resources/assets/styles/critical.scss', 'styles/')
   .copyDirectory('resources/assets/images', './dist/images')
   .setPublicPath('dist')
   .options({
     processCssUrls: false
   })
   .browserSync({
    proxy: 'keith.dev',
    files: [
      'dist/**/*',
      'resources/**/*'
    ]
   });

if (mix.inProduction()) {
    mix.version();
    mix.webpackConfig({
    plugins: [
      // Copy the images folder and optimize all the images
      new CopyWebpackPlugin([{
        from: './resources/assets/images',
        to: './images'
      }]),
      new ImageminPlugin({
        test: /\.(jpe?g|png|gif|svg)$/i,
        optipng: { optimizationLevel: 7 },
        gifsicle: { optimizationLevel: 3 },
        pngquant: { quality: '65-90', speed: 4 },
        svgo: { removeUnknownsAndDefaults: false, cleanupIDs: false },
        plugins: [imageminMozjpeg({ quality: 60 })],
     })
    ]
  })
}

Works like a charm.

@myleshyson Kudos dude! I am using Laravel Mix on a non-Sage theme and you solved a few issues that I was trying to wrap my brain around.

I solved this with adding in config.js (Before public-path.js is added.)
`if (argv.watch) {
const styleEntrypoints = []
const isScriptExt = (ext) => {
return ['.js', '.jsx', '.ts', '.tsx'].includes(ext)
}
const isStyleExt = (ext) => {
return ['.css', '.scss', '.sass', '.less'].includes(ext)
}
Object.keys(module.exports.entry).forEach(id => {
const extnames = module.exports.entry[id].map(file => {
return path.extname(file)
})
if (!extnames.some(isScriptExt) && extnames.some(isStyleExt)) {
  // This is a only styles entry point.
  styleEntrypoints.push(id)
}

})
Object.keys(module.exports.entry).forEach(id =>
module.exports.entry[id].unshift(path.join(__dirname, 'helpers/fix-style-entrypoints.js?settings=' + encodeURIComponent(JSON.stringify({ styleEntrypoints })))))
}`
Then added helpers/fix-style-entrypoints.js
`/* eslint-env browser /
/ globals __resourceQuery, FIXING_STYLE_ENTERIES */
if (typeof FIXING_STYLE_ENTERIES === 'undefined' || !FIXING_STYLE_ENTERIES) {
FIXING_STYLE_ENTERIES = true // eslint-disable-line no-global-assign
if (__resourceQuery) {
var querystring = require('querystring')
var parsedQuerystring = querystring.parse(__resourceQuery.slice(1))
var settings = JSON.parse(parsedQuerystring.settings)
if (settings && settings.styleEntrypoints && settings.styleEntrypoints.length && document.styleSheets && document.styleSheets.length) {
  const styleSheets = document.styleSheets
  const styleEntrypoints = settings.styleEntrypoints

  for (var i = 0; i < styleSheets.length; i++) {
    styleEntrypoints.forEach(id => {
      if (styleSheets[i].href && styleSheets[i].href.match(`styles/${id}.css`)) {
        const script = document.createElement('script')
        const src = styleSheets[i].href.replace('styles', 'scripts').replace('.css', '.js')
        script.type = 'text/javascript'
        script.src = src
        document.getElementsByTagName('head')[0].appendChild(script)

        console.log(`Injected script ${src}`)
      }
    })
  }
}

}
}
`
Only works as long as there is at least one script enqueued.

#2172


Organization / project logo?

Hey all @rust3ds/active, I thought it might be nice for the project to have a logo to go along with the new README and the planned release. I whipped this one up quickly (but I'm by no means a designer/artist), let me know what you think.
Edit: scaled to a couple common sized I found on GitHub, then full size. It doesn't scale quite as well as I'd hoped, maybe I'll see if I can improve that at all:

uncropped (slight margin on edges)

cropped down to content (no margin)

I made it using all freely licensed images:

https://freesvg.org/handheld-3d-game-system (public domain)
https://rustacean.net/ (public domain)
https://carbon.now.sh (free use according to their website / github)

Thoughts? Any changes to make? @Meziu will probably have to set the icon as an organization owner, I would guess.

Haha, nice! This is miles better than the static GitHub icon, affirmative from me 👍

Well, after adding it, I must say it looks great! This will stay for sure. We could add it around as default icon for some other things (maybe default logo of cargo-3ds executables?)

Well, after adding it, I must say it looks great! This will stay for sure. We could add it around as default icon for some other things (maybe default logo of cargo-3ds executables?)

I was thinking about other use cases, I wouldn't be opposed to making it the default logo instead of $DEVKITPRO/libctru/default_icon.png, but we'd have to figure out how to ship the image with cargo-3ds itself (probably doable, but perhaps slightly annoying with an include_bytes! and writing a file to disk on each build, or something). Also we'd probably want to shrink it down to match the 48x48 size of the default one.
Otherwise there aren't too many cases I can think of, since cargo-3ds isn't shipped like a normal graphical application bundle it doesn't make much sense to try and use it as the icon there. We can see if any other use cases come up that make sense though.

@Meziu thanks for setting the new image! It looks like it got cropped a little by GitHub (you can see here) which I realized is probably because I forgot to make sure it's square, can you try this version to see if that helps?

cropped to square, with small margin

I've fixed the icon cropping, thanks.

Cool, I think we are done with this for now then! Thanks


Support for other package managers out of the box

Ideally via config file so it would not have to be repeated in every script all over again.

This should already work.

Yes, you are correct, I haven't noticed in docs or anywhere else. Perfect. Love wsrun! ❤


Problem generating predictions

Hi,
Thank for resolving the previous issues, but I'm still having some problems generating predictions despite following the exact instructions in the ReadME.
After successfully installing SciREX, I followed the 4 training instructions:
    Extract the dataset files in folder tar -xvzf scirex_dataset/release_data.tar.gz --directory scirex_dataset
    Export path to scibert export BERT_BASE_FOLDER=<path-to-scibert> . This path should contain two files atleast - vocab.txt and weights.tar.gz. Download the file here https://s3-us-west-2.amazonaws.com/ai2-s2-research/scibert/pytorch_models/scibert_scivocab_uncased.tar and untar it.
    Run CUDA_DEVICE=<cuda-device-num> bash scirex/commands/train_scirex_model.sh main to train main scirex model
    Run CUDA_DEVICE=<cuda-device-num> bash scirex/commands/train_pairwise_coreference.sh main to train secondary coreference model.

However, when I tried to follow the instructions to generate the predictions
scirex_archive=outputs/pwc_outputs/experiment_scirex_full/main \
scirex_coreference_archive=outputs/pwc_outputs/experiment_pairwise_coreference/main \
cuda_device=<cuda-device-num> \
bash scirex/commands/predict_scirex_model.sh

I got an error saying that the pwc_outputs/experiment_pairwise_coreference/main doesn't exist. I check the directory and find that instead of experiment_pairwise_coreference, there is experiment_coreference, so I change the second line of the prediction instruction to scirex_coreference_archive=outputs/pwc_outputs/experiment_coreference/main and I get the following error:
ModuleNotFoundError: No module named 'scirex'
Predicting Salient Clustering
Traceback (most recent call last):
  File "scirex/predictors/predict_salient_clusters.py", line 25, in <module>
    predict(sys.argv[1], sys.argv[2], sys.argv[3])
  File "scirex/predictors/predict_salient_clusters.py", line 5, in predict
    clusters = [json.loads(line) for line in open(clusters_file)]
FileNotFoundError: [Errno 2] No such file or directory: 'test_outputs//cluster_predictions.jsonl'
Predicitng Salient Clusters using gold clusters as filter
Traceback (most recent call last):
  File "scirex/predictors/predict_salient_clusters_using_gold.py", line 11, in <module>
    from scirex.predictors.utils import *
ModuleNotFoundError: No module named 'scirex'
Predicting Relations End-to-End
Traceback (most recent call last):
  File "scirex/predictors/predict_n_ary_relations.py", line 16, in <module>
    from scirex.predictors.utils import merge_method_subrelations
ModuleNotFoundError: No module named 'scirex'
Predicting relations End-to-End with gold cluster filtering
Traceback (most recent call last):
  File "scirex/predictors/predict_n_ary_relations.py", line 16, in <module>
    from scirex.predictors.utils import merge_method_subrelations
ModuleNotFoundError: No module named 'scirex'
Predicting Relations on gold clusters
Traceback (most recent call last):
  File "scirex/predictors/predict_n_ary_relations.py", line 16, in <module>
    from scirex.predictors.utils import merge_method_subrelations
ModuleNotFoundError: No module named 'scirex'
Evaluating on all Predicted steps
Traceback (most recent call last):
  File "scirex/evaluation_scripts/scirex_relation_evaluate.py", line 7, in <module>
    from scirex.metrics.clustering_metrics import match_predicted_clusters_to_gold
ModuleNotFoundError: No module named 'scirex'
Evaluating on all predicted steps with filtering using gold salient clusters
Traceback (most recent call last):
  File "scirex/evaluation_scripts/scirex_relation_evaluate.py", line 7, in <module>
    from scirex.metrics.clustering_metrics import match_predicted_clusters_to_gold
ModuleNotFoundError: No module named 'scirex'

Any idea how I can fix this?

I also had this problem. My solution was to update PYTHONPATH with the root of the SciREX repo. This way, scripts that are run from subdirectories can still access packages defined at the top-level of SciREX.
e.g. export PYTHONPATH=$PYTHONPATH:<path to SciREX/ root>

Hi both, Thanks for bringing this to my attention. I will add it to the README. In general, you can set the PYTHONPATH. I normally run all my code from scirex root directory so I never got this error
@Yichabod Please let me know if setting PYTHONPATH works for you

Pretty sure that running the code from the SciREX root directory does not solve this problem.
I did rn
scirex_archive=outputs/pwc_outputs/experiment_scirex_full/main \
scirex_coreference_archive=outputs/pwc_outputs/experiment_coreference/main \
cuda_device=<cuda-device-num> \
bash scirex/commands/predict_scirex_model.sh

(as written in the README), from the root of the SciREX directory, and I ran into this problem

@successar my outputs repository seemed to be missing some information so I am retraining the models and then am going to see if modifying the python path works.

@successar Now when I try to run the prediction, it doesn't generate anything. Instead, I get the following errors:
After a long series of info messages:
  Predicting NER
  instances = [instance for instance in Tqdm.tqdm(instances)]
  File "/opt/conda/envs/scirex/lib/python3.7/site-packages/allennlp/data/dataset_readers/dataset_reader.py", line 134, in <listcomp>
    instances = [instance for instance in Tqdm.tqdm(instances)]
  File "/opt/conda/envs/scirex/lib/python3.7/site-packages/tqdm/_tqdm.py", line 1005, in __iter__
    for obj in iterable:
  File "/home/ml1955/task-and-method-annotation/SciREX/scirex/data/dataset_readers/scirex_full_reader.py", line 141, in _read
    with open(file_path, "r") as g:
FileNotFoundError: [Errno 2] No such file or directory: 'test_outputs//ner_predictions.jsonl'
...
 File "scirex/predictors/predict_clusters.py", line 22, in predict
    documents = [json.loads(line) for line in tqdm.tqdm(open(coreference_scores_file))]
FileNotFoundError: [Errno 2] No such file or directory: 'test_outputs//coreference_predictions.jsonl'
...
Predicting Relations on gold clusters
Traceback (most recent call last):
  File "scirex/predictors/predict_n_ary_relations.py", line 109, in <module>
    predict(argv[1], argv[2], argv[3], argv[4], int(argv[5]))
  File "scirex/predictors/predict_n_ary_relations.py", line 48, in predict
    relation_threshold = json.load(open(archive_folder + '/metrics.json'))['best_validation__n_ary_rel_global_threshold']
FileNotFoundError: [Errno 2] No such file or directory: 'outputs/pwc_outputs/experiment_scirex_full/everything//metrics.json'

Note that I was unable to train the coreference model (it would freeze after the info messages, even when I changed the batch_size in the libsonnet file to 5 so that it would run on my GPU). However, I don't think the coreference model is needed for NER. (I only care about getting the NER part working).
Any ideas?

Hi
Is this the full error message ? Is the problem occurring after the first command in this file ? https://github.com/allenai/SciREX/blob/master/scirex/commands/predict_scirex_model.sh
Can you try creating a directory called "test_outputs" before running the prediction command ?

Can you confirm problem is occurring before line 10 in above file ?

OK I created a test_output directory and it seemed to work


added content-length header for nonempty content

For issue is only one question: Should we handle situation when req.headers already contains content-length header?

Sorry for mistakes

I dont understand why server gets content-length=0 header even in case when it has not been sent. But I think it another issue

sorry but I cant fix scala 3 build

got it


Introduce DeferredType that allows linking types together without having to pass a reference to the actual type object or use callbacks

When specifying a field type, I have to either provide the actual object instance, or use a callback that delegates the call to a registry to fetch the single instance of that type.
$filters = new InputObjectType([
    'name' => 'StoryFiltersInput',
    'fields' => [
        'tags' => [
            'type' => fn() => Type::nonNull( Type::listOf( $registry->get(SomeOtherType::class) ) ),
        ]
    ]
]);

I wonder why it works like that. Maybe this is for legacy reasons. But I would find it way easier if I could just link types by a FQCN or GraphQL type name.
So what if we create something like this:
final class DeferredType extends GraphQLType
{
    public function __construct(public readonly string $name)
    {
    }

    public function toString() : string
    {
        return $this->name;
    }
}

$filters = new InputObjectType([
    'name' => 'StoryFiltersInput',
    'fields' => [
        'tags' => [
            'type' => Type::nonNull( Type::listOf( new DeferredType(SomeOtherType::class) ) ),
        ]
    ]
]);

Now the type can be added to the schema. As soon as the type is needed, it needs to resolve the DeferredType to the actual type.
But that only happens when it is needed.
From an API perspective, it feels so much nicer to define things like this than to go with the callbacks + registry approach.

How about TypeReference over DeferredType?

As soon as the type is needed, it needs to resolve the DeferredType to the actual type.

That would require including a type loader with the schema, not every schema has one. I guess we could throw when encountering a type reference but the schema has no type loader.

How about TypeReference over DeferredType?

I like it!

That would require including a type loader with the schema, not every schema has one. I guess we could throw when encountering a type reference but the schema has no type loader.

Sounds good

Updated the PR to reflect TypeReference.

That's true, but why should it be fully possible to work on its own? Isn't that design decision (made long time) one of the reasons why we now have all these callbacks to make things lazy again?

One problem could be that types can be part of multiple schemas. While I have been following the one-schema approach, I know from Lighthouse that there is definite interest in having multiple schemas. Thus, the schema can not really be a part of types themselves.
A lot of APIs assume that types work by themselves. Consider ImplementingType::getInterfaces() and its many uses - if we introduced type references, we would somehow have to weave in the schema whenever calling it.

One problem could be that types can be part of multiple schemas.

Definitely, and I'm currently in the process of introducing another schema next to our large 250 type schema.
It's up to the developer to make sure that the Schema has a loader that is able to find those types.
Currently, this is done by directly linking types together and thus giving this certainty. But in bigger schema's (with lazy callable) this is often postponed via a locator/registry and then can still blow up when the type is not available.
So that would be the same as with the new approach right?

I don't mind having the schema take the responsibility of type loading. Perhaps, it can even be beneficial to have context dependent types - for example, a referenced type could be different depending on which schema the type is in.
Again, the main issue I see is making all the current APIs work with it. Basically all methods on types, fields and argument objects that return a Type will no longer work outside the context of a schema. I would like to avoid an API that can be misused or that works only sometimes, so we would have to move the methods around: ImplementingType::getInterfaces() would become Schema::getInterfaces(ImplementingType $type). Same with probably a dozen other methods.

Again, the main issue I see is making all the current APIs work with it. Basically all methods on types, fields and argument objects that return a Type will no longer work outside the context of a schema. I would like to avoid an API that can be misused or that works only sometimes, so we would have to move the methods around: ImplementingType::getInterfaces() would become Schema::getInterfaces(ImplementingType $type). Same with probably a dozen other methods.

Yes it will be a lot of work. If we are going to move those responsibilities it would mean a breaking change, is that a problem?
Because if it's ok to break it then we can start to work on it.

I am not planning to take on such a large scale change for the upcoming v15. It has plenty of breaking changes already and is nearing completion. Maybe after that, but it will be a while. Feel free to do a proof-of-concept and play with some ideas in the meantime. I think https://github.com/webonyx/graphql-php/pull/1151 is not the way to go.


Upgrading cloud sdk 178.0.0 to LATEST throws errors in tests

ERROR: gcloud crashed (SSLHandshakeError): [SSL: CERTIFICATE_VERIFY_FAILED] certificate verify failed (_ssl.c:727)

@vilasj FYI

https://stackoverflow.com/questions/46221601/gcloud-crashed-sslhandshakeerror-in-gcloud-app-deploy


Terminal link detection issues

Testing #21021
linkComputer.test.ts contains a set of tests used for editor link detection. Some links that do not get fully detected in the terminal. Some do get detected, but partially or contain trailing periods, etc:
// Click here to learn more. https://go.microsoft.com/fwlink/?LinkID=513275&clcid=0x409
// Click here to learn more. https://msdn.microsoft.com/en-us/library/windows/desktop/aa365247(v=vs.85).
aspx
<!-- !!! Do not remove !!!   WebContentRef(link:https://go.microsoft.com/fwlink/?LinkId=166007, area:Adm
in, updated:2015, nextUpdate:2016, tags:SqlServer)   !!! Do not remove !!! -->
For instructions, see https://go.microsoft.com/fwlink/?LinkId=166007.</value>
For instructions, see https://msdn.microsoft.com/en-us/library/windows/desktop/aa365247(v=vs.85).aspx.</
value>
x = "https://en.wikipedia.org/wiki/Zürich";
請參閱 http://go.microsoft.com/fwlink/?LinkId=761051。
x = "file:///foo.bar";
x = "file://c:/foo.bar";
x = "file://shäres/foo.bar";
Some text, then http://www.bing.com.

Upstream issue https://github.com/sourcelair/xterm.js/issues/583

Another case from #21361:
bash-3.2$ echo "https://task.krümplr.com/signup?referral=51cfe998f397460200000001"
https://task.krümplr.com/signup?referral=51cfe998f397460200000001
bash-3.2$

Another case from https://github.com/Microsoft/vscode/issues/31460:
https://api.darksky.net/forecast/YOURAPIKEY/-23.5567497,-46.6541193'

I also face an issue with links that contain spaces:
# works
/path/to/file.yml

# does not work and I don't expect it to
/path/to/file with space.yml

# does not work, but it'd be great if it worked
/path/to/file\ with\ space.yml

After trying various combinations of backslashes, quotes etc., I could not find any means to make a path that contains spaces highlightable

Similarly, http://<IP_ADDRESS>:99 does not work

@apechimp that should work?

That does work. I think it must have something to do with how the program that is outputting my url outputs it then. I'll see if I can isolate it.

I'm seeing this issue after updating to 1.27.1
Specifically relative file paths beginning with a . are no longer clickable. This is a big workflow hit for me because I often run unit tests in the integrated terminal and I rely on the links being clickable to quickly open files associated with test failures.
I've tried running code --disable-extensions and am still able to reproduce the bug. I can confirm this worked before updating to 1.27.1

@Hbbb that's another issue that is fixed in 1.27.2

Currently links on Windows don't work when the opened folder (initial cwd) has a space in the path because this regex pulls the section before the first space:
https://github.com/Microsoft/vscode/blob/079518239fa8643678b74ef87fbe687ce760e3c7/src/vs/workbench/parts/terminal/electron-browser/terminalLinkHandler.ts#L304-L310
This doesn't appear to be easily to fix so deferring until https://github.com/xtermjs/xterm.js/issues/583

I also have this issue with paths that wrap on 2 lines when using vertical terminal layout.
1.27.2 on Windows

On windows (using crosscompilation) I ve got output like
/home/coCENSOREDngeAdapter.hpp:12:1: error: 'shit' does not name a type; did you mean 'wait'?

It's not clickable since on windows _preprocessPath checks that link should start with c:
 if (!link.match('^' + winDrivePrefix))
https://github.com/Microsoft/vscode/blob/73ff13f5debf91fc1d7a89a2f336543b2baa1ee5/src/vs/workbench/contrib/terminal/browser/terminalLinkHandler.ts#L261
Just for those who wants a dirty hack solution:
patch out this check changing platform comparision in the electrion minified js code
Binary file node.dll matches
resources/app/out/vs/workbench/workbench.main.js:if(!i)return Promise.resolve(null);var r=n.normalize(n.resolve(i)),o=t.extractLinkUrl(r);if(!o)return Promise.resolve(null);var a=s.URI.file(o),c=t.extractLineColumnInfo(e),l={startLineNumber:c.lineNumber,startColumn:c.columnNumber};return t._editorService.openEditor({resource:a,options:{pinned:!0,selection:l}})})},e.prototype._validateLocalLink=function(e,t){this._resolvePath(e).then(function(e){return t(!!e)})},e.prototype._validateWebLink=function(e,t){t(!0)},e.prototype._handleHypertextLink=function(e){var t=s.URI.parse(e);this._openerService.open(t)},e.prototype._isLinkActivationModifierDown=function(e){return"ctrlCmd"===this._configurationService.getValue("editor").multiCursorModifier?!!e.altKey:r.isMacintosh?e.metaKey:e.ctrlKey},e.prototype._getLinkHoverString=function(){return"ctrlCmd"===this._configurationService.getValue("editor").multiCursorModifier?i.localize(0,null):r.isMacintosh?i.localize(1,null):i.localize(2,null)},e.prototype._preprocessPath=function(e)
////// change 3===this._platform to 3000===this._platform
{if(3000===this._platform){

https://github.com/Microsoft/vscode/blob/73ff13f5debf91fc1d7a89a2f336543b2baa1ee5/src/vs/workbench/contrib/terminal/browser/terminalLinkHandler.ts#L251
Hope MS will change the source code as well

then CMD+Click will open http://localhost:8080/), the last ) is unexpected

This seems to happen to all urls that contain the ipv6-address notation for http, e.g. http://[2001:dead:beef::1]:80/, even without a port.

https://github.com/Microsoft/vscode/issues/72775

I just hit this issue when running reek. The link https://github.com/troessner/reek/blob/v5.4.0/docs/Control-Parameter.md in:
[70, 72, 74, 76]:ControlParameter: Runner#dispatch is controlled by argument 'command' [https://github.com/troessner/reek/blob/v5.4.0/docs/Control-Parameter.md]
...is being parsed as https://github.com/troessner/reek/blob/v5.4.0/docs/Control-Parameter.md], which is not a valid link.

For me, in Linux, file paths are not being recognized when they contain a + anywhere

Will this be fixed anytime soon? It's very common for Windows users to have a username Firstname and Lastname. Meaning it will include spaces. Breaking Xterm.js which in term breaks the terminal that VSCode implements. A project folder in the user folder C:\Users\John Doe\Documents\Github\com.example.app would break the "clickable" path's in the terminal.
See: https://github.com/xtermjs/xterm.js/issues/583

No eta, you can :+1: the issue to help with prioritization though.

From the SSH extension:

Reminder: You may only use this software with Visual Studio family products,
as described in the license (https://go.microsoft.com/fwlink/?linkid=2077057)

The link includes the trialing ), and thus doesn;'t redirect to the license.

Not sure if this is covered above (I see a similar issue mentioned on Windows, but I see this on macOS). A filename is not linked if it contains a space anywhere, even not in the part that's included in the terminal output!
Eg., I have a folder named dart-sample and I open it and run a test that outputs test/test.dart and this links:

However if my folder name is dart sample (with a space), then this text is not linked - even though the space is not part of the terminal output (only part of the full path that it should link to).

Just adding my 2c ( and a thumb's up ) from OSX: file paths tend to work correctly for me unless they are in the root of the current directory.
For example, anything in a subdirectory (.vscode/) correctly hyperlinks, while anything in the root ( like Rakefile ) never hyperlinks

https://github.com/microsoft/vscode/pull/90336 just got merged which fixes the majority of web/protocol related links as it uses the same link detector as the editor. To turn on this new feature (in tomorrow's Insiders) you can set this in settings:
"terminal.integrated.experimentalLinkProvider": true

Note that while more web cases will be covered, using this setting will break all local file link detection currently. The plan is to keep this issue open until the functionality gap is closed and provider-based is the new default.

Ok scratch that, after merging in https://github.com/microsoft/vscode/pull/95072, functionality should be just as good as with the old system. Here's a demo of what you get, notice the trailing . on the URL isn't part of the link and any word can be clicked which triggers and auto-fills quick access.

Lots of work has happened in this area recently. In stable you can turn on the new "link provider" based links in the terminal that will fix a lot of these problems, and should cover all the ones in the original issue comment as the terminal now leverages monaco's detection for web/file protocol links. I'm going to call this finished with https://github.com/microsoft/vscode/issues/96266
If there is still support missing, feel free to file issues on them, but note that for more obscure links it will soon be possible to detect links within extensions so I may close it in favor of that. See https://github.com/microsoft/vscode/issues/91290 for the API proposal (I'll be updating that issue soon).

To verifier: Test the links in the original comment.


Roll engine<PHONE_NUMBER>9c..d90223fadfd2 (5 commits)

https://github.com/flutter/engine/compare/37779318019c...d90223fadfd2
git log<PHONE_NUMBER>9c..d90223fadfd2 --date=short --no-merges --format='%%ad %%ae %%s'
2018-08-09<EMAIL_ADDRESS>Roll Dart to version 1be785ae2ddb1754a184cd638ab719e94d86b4e9 (flutter/engine#5985)
2018-08-09<EMAIL_ADDRESS>Fixed invalid call site of runWithEntrypointAndCallback (flutter/engine#5984)
2018-08-09<EMAIL_ADDRESS>Removed callback for HeadlessDartRunner (flutter/engine#5983)
2018-08-08<EMAIL_ADDRESS>Revert "Temporarily add travis/analyze.sh back for Chrome bot (#5961)" (flutter/engine#5966)
2018-08-08<EMAIL_ADDRESS>Roll src/third_party/skia 9c9611fcc1bb..0d5d0659a684 (7 commits) (flutter/engine#5980)
The AutoRoll server is located here: https://flutter-engine-flutter-roll.skia.org
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

@rmistry @liyuqian : New roll has been created by https://flutter-engine-flutter-roll.skia.org

Commit queue failed; closing this roll.

PullRequest is not longer mergeable. Closing it.