Unable to install node module in network guarded by http proxy

Describe the bug
Context:
Gitlab CI/CD runners in our organization runs on a limited network and we need to use a web proxy to contact external URL. We pass environment variables to let the system know that it should use http proxy.
Problem:
When we build a docker image for a matrix bot npm silently fails to download the rust binding necessary for the node module to work.
By explicitly calling the download-lib.js script I get the following error that indicates me that the scripts fails to initiate a connection and timeout. This makes me think that the DownloadHelper ignores environment variables that defines which proxy to use.
Downloading lib matrix-sdk-crypto.linux-x64-gnu.node from https://github.com/matrix-org/matrix-rust-sdk/releases/download/matrix-sdk-crypto-nodejs-v0.1.0-beta.1/matrix-sdk-crypto.linux-x64-gnu.node
Error: timeout
    at /app/node_modules/node-downloader-helper/dist/index.js:1:13440
    at <anonymous>
    at process.processTicksAndRejections (node:internal/process/task_queues:95:5)

To Reproduce
Steps to reproduce the behavior:

Have a network proxy that filters HTTP(s) connections
Export http_proxy and https_proxy environment variables with the proxy information
Use npm to install modules
Rust library is not downloaded and it fails silently

Expected behavior
The rust library should be correctly downloaded or at least clearly report that the installation failed during ǹpm install`
Additional context
We pass http_proxy and https_proxy environment variables to our docker build command in the CI to configure applications to use the proxy.
Logs
From one test machine in the same network with limited access.
npm install log:
bousse-e@tpinfo4:~/tmp/naomod-zoom-bot$ npm i
npm WARN deprecated<EMAIL_ADDRESS>this library is no longer supported
npm WARN deprecated<EMAIL_ADDRESS>request-promise has been deprecated because it extends the now deprecated request package, see https://github.com/request/request/issues/3142
npm WARN deprecated<EMAIL_ADDRESS>Please upgrade  to version 7 or higher.  Older versions may use Math.random() in certain circumstances, which is known to be problematic.  See https://v8.dev/blog/math-random for details.
npm WARN deprecated<EMAIL_ADDRESS>request has been deprecated, see https://github.com/request/request/issues/3142

added 171 packages, and audited 172 packages in 43s

22 packages are looking for funding
  run `npm fund` for details

found 0 vulnerabilities
npm notice
npm notice New major version of npm available! 8.5.1 -> 9.1.3
npm notice Changelog: https://github.com/npm/cli/releases/tag/v9.1.3
npm notice Run npm install -g<EMAIL_ADDRESS>to update!
npm notice

execution of the bot:
bousse-e@tpinfo4:~/tmp/naomod-zoom-bot$ node main.js
/comptes/bousse-e/tmp/naomod-zoom-bot/node_modules/@matrix-org/matrix-sdk-crypto-nodejs/index.js:234
    throw loadError
    ^

Error: Cannot find module '@matrix-org/matrix-sdk-crypto-nodejs-linux-x64-gnu'
Require stack:
-<EMAIL_ADDRESS>- /comptes/bousse-e/tmp/naomod-zoom-bot/node_modules/matrix-bot-sdk/lib/e2ee/CryptoClient.js
- /comptes/bousse-e/tmp/naomod-zoom-bot/node_modules/matrix-bot-sdk/lib/index.js
- /comptes/bousse-e/tmp/naomod-zoom-bot/main.js
    at Function.Module._resolveFilename (node:internal/modules/cjs/loader:933:15)
    at Function.Module._load (node:internal/modules/cjs/loader:778:27)
    at Module.require (node:internal/modules/cjs/loader:1005:19)
    at require (node:internal/modules/cjs/helpers:102:18)
    at Object.<anonymous> (/comptes/bousse-e/tmp/naomod-zoom-bot/node_modules/@matrix-org/matrix-sdk-crypto-nodejs/index.js:174:31)
    at Module._compile (node:internal/modules/cjs/loader:1103:14)
    at Object.Module._extensions..js (node:internal/modules/cjs/loader:1155:10)
    at Module.load (node:internal/modules/cjs/loader:981:32)
    at Function.Module._load (node:internal/modules/cjs/loader:822:12)
    at Module.require (node:internal/modules/cjs/loader:1005:19) {
  code: 'MODULE_NOT_FOUND',
  requireStack: [
<EMAIL_ADDRESS>    '/comptes/bousse-e/tmp/naomod-zoom-bot/node_modules/matrix-bot-sdk/lib/e2ee/CryptoClient.js',
    '/comptes/bousse-e/tmp/naomod-zoom-bot/node_modules/matrix-bot-sdk/lib/index.js',
    '/comptes/bousse-e/tmp/naomod-zoom-bot/main.js'
  ]
}

This issue should be posted in matrix-org/matrix-rust-sdk.


movie details parameters attempted, will resume work in the morning

pending approval in the morning

Alternate code has been pulled and merged


[FEATURE REQUEST] AudioSR: Versatile Audio Super-resolution at Scale

A new thing helping to "restore" low-res audio in a similar way as images https://audioldm.github.io/audiosr/
Has code too https://github.com/haoheliu/versatile_audio_super_resolution

This could really help improve outputs from models such as AudioLDM, I'll add it to the backlog.

This could really help improve outputs from models such as AudioLDM, I'll add it to the backlog.

this would be very very cool!  I got some results and I can say it's very useful on 33k hz samples .   Jonathan Fly was also looking into that repo! it needs some bug fixing and optimization..
🔉


Rename package Bigleaf to BigLeaf

@JuliaRegistrator register branch=rename_BigLeaf

Comments on pull requests will not trigger Registrator, as it is disabled. Please try commenting on a commit or issue.

After a discussion on Slack, I learned that renaming the case of a package creates more problem than it solvers. An example is having two packages with the same name on lower-case file systems in the registry.
Hence, I have to refrain from renaming the package. Please, ignore this request, as I rename the repository back to its old name.


Patch libEffekseerNativeForJava.dylib to work with Intel Macs

Recompiled libEffekseerNativeForJava.dylib for x86_64.

Will this work on ARM Macs too?

What steps did you do to compile this @4193883-eng ?

This library works on Intel Macs, but it is x86_64 only, so it does not work on Apple Silicon.

This library works on Intel Macs, but it is x86_64 only, so it does not work on Apple Silicon.

it does. rosseta exists)

What steps did you do to compile this @4193883-eng ?

recompiled and replaced the dylib

Will this work on ARM Macs too?

it does. although it comes with a performance hit, it is negligible. if someone wants they can implement a switch case that loads an appropriate binary depending on the architecture. i won't as i am not experienced in java

although i could make a universal binary...
i'll think about that

Please give me the universal binary, and use Release compile options (no debug symbols)

Universal binary would definitely be preferred. Rosetta's performance hit especially in large modded contexts is going to be a real pain for users.

LGTM. Merged as I don't have any mac too :)


Updates to Templates

Updated API Versions
Updated script extension handler version
securestring for passwords and keys
protected settings for script extension for security

@glennswest  please review


can i remove fastjson depency in dubbo 2.7.8

i do not use dubbo-serialization-fastjson , can i remove fastjson?
Fastjson is often found to have serious security vulnerabilities

You can exclude like this in your project  by yourself
  <dependency>
              <groupId>org.apache.dubbo</groupId>
               <artifactId>dubbo</artifactId>
               <version>${dubbo.version}</version>
                <exclusions>
                    <exclusion>
                        <artifactId>com.alibaba</artifactId>
                        <groupId>fastjson</groupId>
                    </exclusion>
                </exclusions>
            </dependency>


Add asf.yaml file.

Default Scheme is:
https://gitbox.apache.org/schemes.cgi?hadoop-api-shim
Presently dropping mails on common-dev:
https://lists.apache.org/thread/b0jwhv4tccv0jk5b85w6fs8q224ol7yv
Making it sync with main hadoop & thirdparty repo:
https://github.com/apache/hadoop/blob/trunk/.asf.yaml
https://github.com/apache/hadoop-thirdparty/blob/trunk/.asf.yaml

merged.
@ayushtkn at least for these initial changes, i'm happy with a commit-then-review: so feel free to +1 and merge yourself, especially for the build setup. On my local branch I had github set up to run the build and tests...we need to replicate that here


Public API for controlling the EOL style

For cross-platform reasons (see FirebaseExtended/firepad#315), I need to force the editor to use a particular line ending. I see setEOL/pushEOL on the model, but that seems to change the current contents of the editor but not set the EOL permanently -- if the editor is cleared or replaced with other text, the set EOL can be lost.
From poking around the code, I found that the default EOL comes from SimpleResourcePropertiesService.getEOL, and varies by platform, but first it tries to read the files.eol configuration value. Thus I can fix the problem by setting that value:
import { StaticServices } from 'monaco-editor/esm/vs/editor/standalone/browser/standaloneServices';
StaticServices.configurationService.get().updateValue('files.eol', '\r\n');

This works, but I don't think this is supposed to be a public interface. Can some better way to enforce a particular line ending be added to the editor or text model?

What we used as a solution was to replace all setValue calls with -
function newSetValue(model, newValue) {
  model.applyEdits([{ text: newValue, range: model.getFullModelRange()}]);
}

Yes, setValue calls will reset the EOL to the new content passed in. The solution is to change the EOL after calling setValue or to use applyEdits to change the contents.


Add a wiki: 7 Days to Die

Link to origin wiki: https://7daystodie.fandom.com/wiki/7_Days_to_Die_Wiki
Link to destination (independent) wiki: https://7daystodie.wiki.gg/wiki/7_Days_to_Die_Wiki

Thanks for the submission! Will be in the v3.11.1 release, pending approval from Chrome and Firefox.


Error in the input path

OSX, Cmake as default, when I run the command "./cmt ./Vid_D_person.avi", it gives me error.
--->
OpenCV Error: Assertion failed (size.width>0 && size.height>0) in imshow, file /tmp/opencv20150407-97477-xpu2s2/opencv-2.4.11/modules/highgui/src/window.cpp, line 261
libc++abi.dylib: terminating with uncaught exception of type cv::Exception: /tmp/opencv20150407-97477-xpu2s2/opencv-2.4.11/modules/highgui/src/window.cpp:261: error: (-215) size.width>0 && size.height>0 in function imshow
Abort trap: 6
Update:
if I run the command: ./cmt ./*.mpg, it will work as expect. So guess maybe it will not support the avi file, but the testing data files from your website are all avi files.

Unfortunately I am not familiar with OSX, but to me it seems that OpenCV is unable to decode the video stream. They videos from my hp are all mpeg-4 encoded (by ffmpeg). If you manage to solve this, please let me know.


Fix typography issue of the dropdown button

Types of Changes
Prerequisites
Please make sure you can check the following two boxes:

[x] I have read the CONTRIBUTING document
[x] My code follows the code style of this project

Contribution Type
What types of changes does your code introduce? Put an x in all the boxes that apply:

[x] Bug fix (non-breaking change which fixes an issue, please reference the issue id) https://github.com/ZEISS/precise-ui/commit/f0a141579faaaff6290ff9901e492afb78a4871c
[ ] New feature (non-breaking change which adds functionality, make sure to open an associated issue first)
[ ] Breaking change (fix or feature that would cause existing functionality to change)
[ ] My change requires a change to the documentation
[ ] I have updated the documentation accordingly
[ ] I have added tests to cover my changes
[x] All new and existing tests passed

Description
This is a simple bugfix of the dropdown button font-size.

 Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.


In flow, annotate function parameters with type any just, like for TypeScript.

Define type $any and emit type annotation for function parameters.
This is needed with examples with nested null checks, where the fact that a field (even immutable) was alreadt null checked is not tracked by Flow.

More discussion in https://github.com/cristianoc/genType/pull/157, where an alternative solution was explored.


Relationship between hits in hits.tsv and input peaks range

I noticed that some of the hits in the hits.tsv file appear to fall outside the range of the input peaks. Is the hits calling performed within a region surrounding the peaks rather than strictly limited to the precise boundaries of each peak? If my understanding is incorrect, a detailed explanation would be greatly appreciated. Thank you for your assistance!

Hi Yanbo,
Yes, by default, finemo looks at 1000 bps around the peak summit (column 1 + column 10 here) regardless of the interval size. You can adjust this using the -w/--region-width argument in the extract regions commands.
Hope this helps!

Thanks Austin!!😊


Checkstyleissuessolved

Contains
Brief description of what the PR does like "Fixes #12345"
#3798
Sir/Madam I have solved checkstyle issues in Terasology project.
The files that are changes are -
1: engine/src/main/java/org/terasology/math/Rotation.java
2: engine/src/main/java/org/terasology/particles/ParticlePool.java
3: engine/src/main/java/org/terasology/rendering/primitives/BlockMeshGeneratorSingleShape.java
4: engine/src/main/java/org/terasology/rendering/primitives/ChunkTessellator.java
5: engine/src/main/java/org/terasology/rendering/world/WorldRendererImpl.java
How to test
Brief description of how to test / confirm this PR before merging

Can one of the admins please verify this patch?


Floating cursor docs

Explains what a "floating cursor" is in the docs.
Fixes https://github.com/flutter/flutter/issues/132411

The referenced gif will be added in https://github.com/flutter/assets-for-api-docs/pull/226.

Yeah, having a screenshot is a huge improvement!

I've removed the screenshot as it's not possible to generate in a script, and I've linked to the relevant Apple docs.

@Hixie Thanks for the guidance, I've updated it to integrate something close to what you've written. One thing I changed was not mentioning the "blob" at the bottom of the placeholder cursor, which I didn't see when I tried this on an iOS 17 simulator.


Update client3:circe, client3:core to 3.8.10

Updates

com.softwaremill.sttp.client3:circe
com.softwaremill.sttp.client3:core

from 3.8.5 to 3.8.10.
GitHub Release Notes - Version Diff
I'll automatically update this PR to resolve conflicts as long as you don't change it yourself.
If you'd like to skip this version, you can just close this PR. If you have any feedback, just mention me in the comments below.
Configure Scala Steward for your repository with a .scala-steward.conf file.
Have a fantastic day writing Scala!

Adjust future updates
Add this to your .scala-steward.conf file to ignore future updates of this dependency:
updates.ignore = [ { groupId = "com.softwaremill.sttp.client3" } ]

Or, add this to slow down future updates of this dependency:
dependencyOverrides = [{
  pullRequests = { frequency = "30 days" },
  dependency = { groupId = "com.softwaremill.sttp.client3" }
}]

labels: library-update, early-semver-patch, semver-spec-patch, commit-count:1

Superseded by #182.


Is the PryBinding hook necessary?

It's already handled by RuboCop and if I want to disable it, I need to disable both the RuboCop cop and the PryBinding hook.

I didn't realize rubocop had a cop which reported these sorts of issues when I merged the original pull request in #48. I've removed this hook in 00fba92238ad44d17a6a8575bc7bce62e57a8aac.
As discussed in https://github.com/brigade/overcommit/issues/122#issuecomment-87114806, starting with Overcommit 0.24.0 we'll be disabling almost all hooks by default, so this should no longer become an issue either way.

Thanks @sds !


fix: check that MsgChannelUpgradeInit is signed by authority

Description

closes: #4186

Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.

[ ] Targeted PR against correct branch (see CONTRIBUTING.md).
[ ] Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
[ ] Code follows the module structure standards and Go style guide.
[ ] Wrote unit and integration tests.
[ ] Updated relevant documentation (docs/) or specification (x/<module>/spec/).
[ ] Added relevant godoc comments.
[ ] Provide a commit message to be used for the changelog entry in the PR description for review.
[ ] Re-reviewed Files changed in the Github PR explorer.
[ ] Review Codecov Report in the comment section below once CI passes.

Codecov Report

Merging #4773 (c82d053) into 04-channel-upgrades (63c3010) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Additional details and impacted files

@@                 Coverage Diff                  @@
##           04-channel-upgrades    #4773   +/-   ##
====================================================
  Coverage                80.25%   80.25%
====================================================
  Files                      197      197
  Lines                    15020    15023    +3
====================================================
+ Hits                     12054    12057    +3
  Misses                    2495     2495
  Partials                   471      471

Files
Coverage Δ

modules/core/04-channel/types/msgs.go
79.02% <ø> (ø)

modules/core/keeper/msg_server.go
63.83% <100.00%> (+0.14%)
:arrow_up:


docs: fix two typos (array or requests -> array of requests, no much -> not much)

@janbuchar, could you please merge it? I might be missing something; I don't see the merge button.


Add workflow file to run arm-based testing with sanitizers

Fixes: #520

Running tests.

Seems it failed... I just pushed an update, let's see how it goes.

Running...

@lemire hmm, it is still failing... Off the top of your head, do you have any idea?

It looks like a permission problem. I am not sure what the source of the issue is.

I have never seen this error:
CMake Error: Cannot open file for write: /home/runner/work/ada/ada/build/Testing/Temporary/LastTest.log.tmp
CMake Error: : System Error: Permission denied

Let us run the tests...

@anonrig I suspect that the memory sanitizer is still busted. :-(
It finds problems inside the standard library.
(It is clearly unrelated to this PR.)

@CarlosEduR Yes. But at least we are now checking that things build, which is good.


tail: don't add trailing \n if input doesn't end with one

Fix a bug where tail would inappropriately add a newline to the last
line of output even though the input did not end with one.

I have added the copyright notice, and rebased on main.

I don't understand the GNU warnings lately?!
thanks for this patch btw :)


Ignore files in deps dir when resolving wit packages

Some operating systems will add files randomly to directories.
Considering files inside deps currently serve no purpose and will cause an error on UnresolvedPackage::parse_dir, I think ignoring any files inside is the best option for user experience.
If that changes, it would be easy to tweak this filter to allow certain extensions.

Thanks for the review @alexcrichton . I made the changes and included a test.


TVA

DO NOT REMOVE OR SKIP THE ISSUE TEMPLATE

[X] I understand that I will be blocked if I intentionally remove or skip any mandatory* field

Checklist

[X] I'm reporting that yt-dlp is broken on a supported site
[X] I've verified that I have updated yt-dlp to nightly or master (update instructions)
[X] I've checked that all provided URLs are playable in a browser with the same IP and same login details
[X] I've checked that all URLs and arguments with special characters are properly quoted or escaped
[X] I've searched known issues and the bugtracker for similar issues including closed ones. DO NOT post duplicates
[X] I've read the guidelines for opening an issue
[X] I've read about sharing account credentials and I'm willing to share it if required

Region
Canada
Provide a description that is worded well enough to be understood
Trying with: yt-dlp -vU 'https://www.qub.ca/tvaplus/tva/la-voix/saison-10/episode-4-auditions-a-l-aveugle-1098657536'.
Failed due to invalid JSON metadata. I've manually applied this patch and it worked fine. The file has changed so it's not a clear patch. But the core of it (replacing the proxy JSON with metadata extractor from the page) works perfectly.
So, can we please merge this patch to yt-dlp?
Provide verbose output that clearly demonstrates the problem

[X] Run your yt-dlp command with -vU flag added (yt-dlp -vU <your command line>)
[ ] If using API, add 'verbose': True to YoutubeDL params instead
[X] Copy the WHOLE output (starting with [debug] Command-line config) and insert it below

Complete Verbose Output
[debug] Command-line config: ['-vU', 'https://www.qub.ca/tvaplus/tva/la-voix/saison-10/episode-4-auditions-a-l-aveugle-1098657536']
[debug] Encodings: locale UTF-8, fs utf-8, pref UTF-8, out utf-8, error utf-8, screen utf-8
[debug] yt-dlp version<EMAIL_ADDRESS>from yt-dlp/yt-dlp [f10589e34] (pip)
[debug] Python 3.12.1 (CPython arm64 64bit) - macOS-14.2.1-arm64-arm-64bit (OpenSSL 3.2.1 30 Jan 2024)
[debug] exe versions: ffmpeg 6.1.1 (setts), ffprobe 6.1.1, rtmpdump 2.4
[debug] Optional libraries: Cryptodome-3.19.1, brotli-1.1.0, certifi-2024.02.02, mutagen-1.47.0, requests-2.31.0, sqlite3-3.45.1, urllib3-2.1.0, websockets-12.0
[debug] Proxy map: {}
[debug] Request Handlers: urllib, requests, websockets
[debug] Loaded 1798 extractors
[debug] Fetching release info: https://api.github.com/repos/yt-dlp/yt-dlp/releases/latest
Latest version<EMAIL_ADDRESS>from yt-dlp/yt-dlp
yt-dlp is up to date<EMAIL_ADDRESS>from yt-dlp/yt-dlp)
[Qub] Extracting URL: https://www.qub.ca/tvaplus/tva/la-voix/saison-10/episode-4-auditions-a-l-aveugle-1098657536
[Qub]<PHONE_NUMBER>: Downloading JSON metadata
ERROR: [Qub]<PHONE_NUMBER>: Unable to download JSON metadata: HTTP Error 404: Not Found (caused by <HTTPError 404: Not Found>); please report this issue on  https://github.com/yt-dlp/yt-dlp/issues?q= , filling out the appropriate issue template. Confirm you are on the latest version using  yt-dlp -U
  File "/opt/homebrew/Cellar/yt-dlp/2023.12.30/libexec/lib/python3.12/site-packages/yt_dlp/extractor/common.py", line 718, in extract
    ie_result = self._real_extract(url)
                ^^^^^^^^^^^^^^^^^^^^^^^
  File "/opt/homebrew/Cellar/yt-dlp/2023.12.30/libexec/lib/python3.12/site-packages/yt_dlp/extractor/tva.py", line 67, in _real_extract
    entity = self._download_json(
             ^^^^^^^^^^^^^^^^^^^^
  File "/opt/homebrew/Cellar/yt-dlp/2023.12.30/libexec/lib/python3.12/site-packages/yt_dlp/extractor/common.py", line 1072, in download_content
    res = getattr(self, download_handle.__name__)(url_or_request, video_id, **kwargs)
          ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/opt/homebrew/Cellar/yt-dlp/2023.12.30/libexec/lib/python3.12/site-packages/yt_dlp/extractor/common.py", line 1036, in download_handle
    res = self._download_webpage_handle(
          ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/opt/homebrew/Cellar/yt-dlp/2023.12.30/libexec/lib/python3.12/site-packages/yt_dlp/extractor/common.py", line 906, in _download_webpage_handle
    urlh = self._request_webpage(url_or_request, video_id, note, errnote, fatal, data=data, headers=headers, query=query, expected_status=expected_status)
           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/opt/homebrew/Cellar/yt-dlp/2023.12.30/libexec/lib/python3.12/site-packages/yt_dlp/extractor/common.py", line 863, in _request_webpage
    raise ExtractorError(errmsg, cause=err)

  File "/opt/homebrew/Cellar/yt-dlp/2023.12.30/libexec/lib/python3.12/site-packages/yt_dlp/YoutubeDL.py", line 4082, in urlopen
    return self._request_director.send(req)
           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/opt/homebrew/Cellar/yt-dlp/2023.12.30/libexec/lib/python3.12/site-packages/yt_dlp/networking/common.py", line 114, in send
    response = handler.send(request)
               ^^^^^^^^^^^^^^^^^^^^^
  File "/opt/homebrew/Cellar/yt-dlp/2023.12.30/libexec/lib/python3.12/site-packages/yt_dlp/networking/_helper.py", line 204, in wrapper
    return func(self, *args, **kwargs)
           ^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/opt/homebrew/Cellar/yt-dlp/2023.12.30/libexec/lib/python3.12/site-packages/yt_dlp/networking/common.py", line 325, in send
    return self._send(request)
           ^^^^^^^^^^^^^^^^^^^
  File "/opt/homebrew/Cellar/yt-dlp/2023.12.30/libexec/lib/python3.12/site-packages/yt_dlp/networking/_requests.py", line 343, in _send
    raise HTTPError(res, redirect_loop=max_redirects_exceeded)
yt_dlp.networking.exceptions.HTTPError: HTTP Error 404: Not Found

The above exception was the direct cause of the following exception:

Traceback (most recent call last):
  File "/opt/homebrew/Cellar/yt-dlp/2023.12.30/libexec/lib/python3.12/site-packages/yt_dlp/extractor/common.py", line 850, in _request_webpage
    return self._downloader.urlopen(self._create_request(url_or_request, data, headers, query))
           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/opt/homebrew/Cellar/yt-dlp/2023.12.30/libexec/lib/python3.12/site-packages/yt_dlp/YoutubeDL.py", line 4114, in urlopen
    raise _CompatHTTPError(e) from e
yt_dlp.networking.exceptions._CompatHTTPError: HTTP Error 404: Not Found

Duplicate of #4989


No cookies popup in embeds

Use Case
As a user embedding the viewer in another webpage, I don't want the cookies popup appearing in every instance of the viewer on my website every time it loads.
Acceptance Criteria
When a link starts with https://simularium.allencell.org/embed?... the cookies popup is not triggered (because data is not saved?).
Details
Is this possible? Can we not save cookies (or anything else) for embeds?
Or can we have it only appear once on each embedding page and not be required on every reload?
Here's an example of how annoying this is.

@thao-do this is the page where I'm testing embeds, and here's the iframe code:
<iframe src="https://simularium.allencell.org/embed?trajUrl=https://readdy-working-bucket.s3.us-west-2.amazonaws.com/outputs/actin_compression_cytosim_readdy.simularium&t=199" frameborder="0" allowfullscreen></iframe>

I have altered the cookie banner trigger condition - it's no longer shown when I open the github page.
@blairlyons can you double check?

You might want to make a separate ticket for the small screen warning dialog by the way

It works! Thanks!!


Default keyboard mapping collides with "replace"

cmd+alt+f is the mapping for replace on mac. While I really like my source code to be formatted, being able to search & replace with a shortcut is slightly more important :)
I have changed the binding to cmd+alt+l - AFAICT that's not used for anything else.

Are you referring to https://github.com/piuccio/sublime-esformatter ? You should report it there.

Ugh, I copied the first github link from their README, without ensuring that it's for the project that I really meant. I'm sorry and embarrassed :/


Update Storybook stories to CSF 3.0 format

🙋 Feature Request
We need to update our existing Storybook stories from using storiesOf to the new CSF 3.0 format so that we can upgrade our Storybook version. See the comment by Kyle below about the expected work.
When starting a new component or hook add your name below or mention it in slack or standup to avoid two people working on the same one. Which isn't expected to be an issue until there are only a few left to refactor).
List of stories/packages to update (may or may not include the chromatic + subcomponent stories per package):

[ ] useButton
[ ] useCalendar
[ ] dnd stories
[ ] useGrid
[ ] useFocusRing
[ ] useHover
[ ] useMove
[ ] useMenu
[ ] useModal
[ ] useOverlayPosition
[ ] useSelectableList
[ ] aria Slider stories
[ ] useSelectableList
[ ] ActionBar
[ ] ActionGroup
[ ] Alert
[ ] Breadcrumbs
[ ] Button stories (all of em)
[ ] ButtonGroup
[ ] Calendar
[ ] Card https://github.com/adobe/react-spectrum/pull/3148
[ ] CardView https://github.com/adobe/react-spectrum/pull/3148
[ ] Checkbox stories
[ ] Color stories
[ ] ComboBox stories
[ ] Contextual help
[ ] Datepicker stories
[ ] Dialog
[ ] Divider
[ ] Form
[ ] Icon
[x] IllustratedMessage - https://github.com/adobe/react-spectrum/pull/3197
[x] HelpText - https://github.com/adobe/react-spectrum/pull/3152
[x] Label - https://github.com/adobe/react-spectrum/pull/3152
[ ] Layout
[x] Link - https://github.com/adobe/react-spectrum/pull/3146
[ ] List
[ ] ListBox
[ ] Menu
[x] Meter - https://github.com/adobe/react-spectrum/pull/3157
[ ] Numberfield
[ ] Overlays
[ ] Pagination
[ ] Picker
[ ] Progress
[ ] Provider
[ ] Radio
[ ] SearchField
[ ] Sidenav
[ ] Slider
[x] Statuslight - https://github.com/adobe/react-spectrum/pull/3157
[x] Switch - https://github.com/adobe/react-spectrum/pull/3129
[ ] Table
[ ] Tabs
[ ] Tag
[ ] Textfield
[ ] Toast
[ ] Tooltip/TooltipTrigger - https://github.com/adobe/react-spectrum/pull/3211
[ ] Tree (not released)
[x] View - https://github.com/adobe/react-spectrum/pull/3196
[x] Well - https://github.com/adobe/react-spectrum/pull/3129
[ ] spectrum-icons

🧢 Your Company/Team
RSP

Prior work: https://github.com/adobe/react-spectrum/pull/2425

prior work was done with a codemod right? can we do that again?

Perhaps? I haven't looked into it but if so that would be awesome. Otherwise this is a checklist that we can gradually chip away at. @reidbarber I think you used the codemod previously

Yeah, the codemod helped, but it definitely requires some manual cleanup to get them to a best-practice state for CSF. Mainly ending up with a lot of render functions referencing example components declared in the file. I did a decent amount, maybe easy to take a look at  https://github.com/adobe/react-spectrum/commit/5cf946e671759bc1b820b8c4291f1e26012eafc1#diff-f28ec1c2b8aef4f9e1f35bf453f95dc0a84b7ba2b7b13d7e53824eef6ebfa9bd starting with Avatar. Some are probably good to go.
I think it might be easiest to do a few at a time and start with simpler components, rather than doing everything in one PR. This umbrella issue should definitely help.

Can we use the codemod to target one component at a time? might be good to combine how nice it is to look at just a single file at a time plus the ease of automating most of it

Codemods for reference:
to convert storiesOf to CSF:
npx sb migrate storiesof-to-csf --glob="**/Accordion.stories.tsx" --parser=tsx
to convert CSF 2 to CSF 3
npx sb migrate csf-2-to-3 --glob="**/Accordion.stories.tsx" --parser=tsx

Using the code modes does 50% of the work. There is one code mod to migrate to CSF and a second to migrate to CSF 3.0. That is the minimum work for a PR to be submitted. Additional optimizations and refactors are covered below.
Optimizations and refactors

Generally, condense the number of stories.

We review the existing stories and determine if there is duplication with Chromatic or stories that could be moved to Chromatic.

Many components story files have multiple renders functions; we should try to rewrite them so there is only the initial declaration.
Once https://github.com/adobe/react-spectrum/pull/3123 is merged controls will be introduced and there are additional optimizations of reducing stories that could occur. This would be a second round of optimizations for components that have already been migrated to CSF 3.0.

Note:
Some tests use story components and these tests may break. They should be fixable by adding an import and a couple lines of code, see https://github.com/adobe/react-spectrum/pull/3148/files#diff-3ef103560236269b49ca02cc46a7b9f7894b45739ce00c38da98ab4b385abe65R15-R29 for an example.

Resolved by https://github.com/adobe/react-spectrum/pull/4399


cannot read property of undefined

Trying to get started with jest and getting this error. Any help?
saiko: ~/code/tsi-mattress-match $ jest __tests__/tmp-test.js
Using Jest CLI v12.0.1, jasmine2
TypeError: Cannot read property '_config' of undefined
    at isTestFilePath (/home/saiko/code/tsi-mattress-match/node_modules/jest-cli/src/TestRunner.js:96:11)
    at Array.filter (native)
    at TestRunner.promiseTestPathsMatching (/home/saiko/code/tsi-mattress-match/node_modules/jest-cli/src/TestRunner.js:179:42)
    at getTestPaths (/home/saiko/code/tsi-mattress-match/node_modules/jest-cli/src/jest.js:51:23)
    at runJest (/home/saiko/code/tsi-mattress-match/node_modules/jest-cli/src/jest.js:152:10)
    at readConfig.then.config (/home/saiko/code/tsi-mattress-match/node_modules/jest-cli/src/jest.js:245:16)

If I run jest without specifying a file the only output that is displayed is:
Using Jest CLI v12.0.1, jasmine2

looks like it only appears when running a single test file.
https://github.com/facebook/jest/pull/948 should fix it

Sorry! We now finally have the ability to write integration tests for Jest and we can make sure we won't be breaking this again. I'll tag with a fix 12.0.2 today.


Anatomizer issue: search by UniprotID

Initializing a GeneAnatomy object with UniProtID raises a warning that there are multiple UniProtIDs associated and then an error, for example:
>> g = GeneAnatomy("P11362")
/home/eugenia/anaconda3/lib/python3.5/site-packages/kami-0.1-py3.5.egg/anatomizer/new_anatomizer.py:414:
 AnatomizerWarning: More than one UniProt Accession Number found for 'ENSP00000432972'
  ensp, AnatomizerWarning

---------------------------------------------------------------------------
AttributeError                            Traceback (most recent call last)
<ipython-input-11-379402b9ab2b> in <module>()
----> 1 g = GeneAnatomy("P11362")

~/anaconda3/lib/python3.5/site-packages/kami-0.1-py3.5.egg/anatomizer/new_anatomizer.py in __init__(self, query, features, merge_features, nest_features, merge_overlap, nest_overlap, nest_level, offline)
   1296         if features and self.found:
   1297             # feature_list = get_features(self.canonical)
-> 1298             feature_list = get_ipr_features(self.selected_iso, self.canonical)
   1299             # construct fragments from features found
   1300             fragnum = 0

~/anaconda3/lib/python3.5/site-packages/kami-0.1-py3.5.egg/anatomizer/new_anatomizer.py in get_ipr_features(selected_ac, canon)
    567         search_ac = selected_ac
    568     entry = ipr_matches_root.find("protein[@id='%s']" % search_ac)
--> 569     matchlist = entry.findall('match')
    570     for feature in matchlist:
    571         if feature.get('dbname') not in ignorelist:

AttributeError: 'NoneType' object has no attribute 'findall'

Ok, UPD: it happends only in 'online' mod (for offline mode it works)

Note: P11362 is not a UniProtID, it's a UniProt accession code, see the raw text page for the fields.
Back in the days of the Exploratorium we ran into what seems to be this same issue. Mitchel used to say that UniProtACs were not unique, but UniProtIDs were. So we ended up using FGFR1_HUMAN rather than P11362. That was 6 years ago, so I don't know if UniProt has changed to avoid this issue.


ng update migration 'Remove Browserslist configuration files that matches the Angular CLI default configuration.' fails with non-descript error when

Command
update
Is this a regression?

[ ] Yes, this behavior used to work in the previous version

The previous version in which this bug was not present was
No response
Description
The ng update from version 14 to 15 migration fails with the following nondescript error if you have a node_modules "backup", for example node_modules2, folder in the project directory
This is technically "my fault", but it would be nice if we had a better description of what is going on, I had to add a bunch of logs to the cli code to figure out where and what made it fail.
Here is the specific error:
Remove Browserslist configuration files that matches the Angular CLI default configuration.
× Migration failed: Unknown browser query `basedir=$(dirname "$(echo "$0" | sed -e 's`. Maybe you are using old Browserslist or made typo in query.
  See "<logs>\angular-errors.log" for further details.

Minimal Reproduction
Arrange your directories in the following fashion:
├───angular-root-directory
│   ├───node_modules
│   ├───node_modules2
│   ├───src
│   ├───package.json
│   ├───angular.json
│   ├───tsconfig.json
And run the @angular/cli migrations with a command equivalent to this one:
ng update @angular/cli --from 14 --to 15 --migrate-only --allow-dirty --force
The node_modules2 directory must have the npm packages too.
The specific cause of the "crash" is the presence of the browserslist file in /node_modules2/.bin/ because line 80 of
@schematics\angular\migrations\update-15\remove-browserslist-config.js tries to parse the source of the browserslist executable
Here is "my" line 80: const { defaults: browsersListConfig, ...otherConfigs } = browserslist.parseConfig(tree.readText(path));
Exception or Error
Remove Browserslist configuration files that matches the Angular CLI default configuration.
× Migration failed: Unknown browser query `basedir=$(dirname "$(echo "$0" | sed -e 's`. Maybe you are using old Browserslist or made typo in query.
  See "<logs>\angular-errors.log" for further details.

Actual log:
[error] BrowserslistError: Unknown browser query `basedir=$(dirname "$(echo "$0" | sed -e 's`. Maybe you are using old Browserslist or made typo in query.
    at unknownQuery (<PROJECT_ROOT>\node_modules\browserslist\index.js:283:10)
    at Function.select (<PROJECT_ROOT>\node_modules\browserslist\index.js:1149:15)
    at <PROJECT_ROOT>\node_modules\browserslist\index.js:314:29
    at Array.reduce (<anonymous>)
    at resolve (<PROJECT_ROOT>\node_modules\browserslist\index.js:304:34)
    at browserslist (<PROJECT_ROOT>\node_modules\browserslist\index.js:406:21)
    at <PROJECT_ROOT>\node_modules\@schematics\angular\migrations\update-15\remove-browserslist-config.js:91:43
    at async callRuleAsync (<PROJECT_ROOT>\node_modules\@angular-devkit\schematics\src\rules\call.js:78:18)

Your Environment
_                      _                 ____ _     ___
    / \   _ __   __ _ _   _| | __ _ _ __     / ___| |   |_ _|
   / △ \ | '_ \ / _` | | | | |/ _` | '__|   | |   | |    | |
  / ___ \| | | | (_| | |_| | | (_| | |      | |___| |___ | |
 /_/   \_\_| |_|\__, |\__,_|_|\__,_|_|       \____|_____|___|
                |___/

Angular CLI: 15.2.5
Node: 16.20.0
Package Manager: npm 8.19.4
OS: win32 x64

Angular: 15.2.6
... animations, cdk, common, compiler, compiler-cli, core, forms
... language-service, localize, material
... material-moment-adapter, platform-browser
... platform-browser-dynamic, router

Package                         Version
---------------------------------------------------------
@angular-devkit/architect       0.1100.7
@angular-devkit/build-angular   15.2.5
@angular-devkit/core            15.2.5
@angular-devkit/schematics      15.2.5
@angular/cli                    15.2.5
@angular/flex-layout            15.0.0-beta.42
@schematics/angular             15.2.5
rxjs                            6.6.3
typescript                      4.9.5

Anything else relevant?
No response

Closed via https://github.com/angular/angular-cli/pull/24998#event-8988228543


move optional content to end

this needs further passes.
(i used https://addons.mozilla.org/en-US/firefox/addon/scott-rigby/ for the "sign off", and realized that it's just an added line here. Wondering if this has any legal relevance at all. In any way: I am not willing to add my full name and my private email to each and every commit. I sense that this has its roots at GNU or Torvalds or similar entities.
See, signing CLA's and (in commercial context) NDA's is fine to me, but what you ask for here, is simply discriminating, because those who don't want name/email in each commit, cannot contribute)
Signed-off-by: I. Lazaridis<EMAIL_ADDRESS>

got now:
Commit sha: a2b96e4, Author: Lazaridis, Committer: GitHub; Expected "Lazaridis<EMAIL_ADDRESS>but got "I. Lazaridis<EMAIL_ADDRESS>one last try...

close in favor of #2291


View and select sections of a large text file

I am in the planning stages of using Scintilla as a 'virtual window' in VB.Net to view a small section of a large text file whilst keeping the rest in memory. I will use a separate vertical scroll control, and load the relevant lines to Scintilla when the scroll-control is clicked or changed.
One aspect I do not understand, though: Imagine a window full of text. You left-click-and-hold, somewhere in the text, then move the mouse to the top of the window. When that happens, the text starts to scroll up, and the text becomes selected, until you release the mouse-button, and the selection completes. My question: How to achieve this? There is no event that I can think of that would respond to a mouse moving up to, and then away from, the top or bottom of a window.
Also, if you have any tips or suggestions on implementing a 'virtual window', I would be interested to hear them.

Ya, that's a tricky question. I've wondered about doing the same thing before -- to make Scintilla just a window into a larger file, but I've never tried it.
In a standard Windows Forms control, you could track the mouse movement with a combination of the MouseMove event and the Capture property on the control. That's basically what you're describing.. capturing the mouse and tracking it even when it leaves the bounds of the control. I'm not sure if either that event or property work on ScintillaNET because the native Scintilla and ScintillaNET do so much overriding of the WndProc function that I'm not sure those things still bubble up.


GPS coordinate mapping to issac sim coordinates.

First of all, thanks for the work put in to create the simulator. I have been trying to run examples and also trying to understand how different components interact with each other. My use case is to create an outdoor scene and process images are they are being captured by the USD camera in Issac-Sim.
I sometimes notice errors (drone is stuck on the same frame forever, altitude errors etc.) while flying the simulator through QGroundControl. I am trying to debug these cases. As part of this, I wanted to trace how GPS co-ordinates on QGroundControl map are being mapped to the coordinate space of Issac-Sim scene.  If I want the drone to move towards an object in the scene, how would that be mapped to GPS location on QGroundControl? Thank you for any help.

In this link link for the description of gps information, I hope it will be helpful to you.

I will recommend for you to take a closer look at the Conference Paper, section III-D (sensor modeling) - the math behind the GPS projection is there. You can also change the coordinates of the center of the projection by following the link suggested by @fyl1991.
The code for the GPS implementation is here.
Hope this helps.


[EN] Feedback for: /web/fundamentals/?hl=en

Guys (gilrs),
I am so lost in your new UI. I have no idea where to find my developer console listing the applications that I have created or am creating. I wasted 30 minutes just trying to start. Stop trying to sell me more stuff or get me to learn new stuff, or attend conference or whatever. I just want to go to my workbench.
Apply your own grand advice on good website design - users want to get to where they want quickly and easily. So far your UI is completely useless in this regard. I am still lost.

Thanks for the feedback, we're still working to make things better, so stay tuned!


Find the minimum android SDK that is required to launch the container app in play store

We can target Android 8.0 as the minimum @divyahariharan2103 ! (that will reach ~95% of our audience)

perfect !! Thank you @burrage


Feature request: Google Voice specific variant?

Any chance the dev team here would consider a new application just for Google Voice? There really is no real desktop solution for Voice much like YakYak covers with Hangouts as a cross-platform option.
Could also offer an SMS alternative with the future of Hangouts being somewhat bleak for those using that. Just a suggestion but already appreciate the great app you've provided with YakYak.

we're very barely maintaining yakyak and not interested in google voice, not me at least.


Multiplication of two polynomial using linked list

Kindly recheck now done with .java extension

refer to issue #1


Add property to disable wxStdDialogButtonSizer wxButton member generation

Description:

Currently, code generation for wxStdDialogButtonSizer generates wxButton* member variables for each button used. While that's fine if you need those variables, it results in warnings from clang-cl and clang-tidy about unused members. Usually, you don't actually need these -- calling functions like GetAffirmativeButton() allows you to access most buttons without needing member variables.
At the very least, we should add a property that let's the user disable generation of button members -- with the help text suggesting alternatives like GetAffirmativeButton().

This is actually a bug in it's current implementation. Currently, member variables are only generated if wxStdDialogButtonSizer has class access set to something other than none (the default is none). However, while enabling class access does generate variables in the header file, it doesn't always assign them. The only time they get assigned is if the user requested a button that requires calling AddButton(new new wxButton). That only happens if the form is not a dialog, either Save or ContextHelp buttons are requested.
It is valid to create the class member variables if AddButton is called -- that should not generate a compiler warning since the variables are initialized in the source code, and there are marked as being used. While the dev might or might not need them, I don't think this case justifies a property to supress generation -- particularly since most of the time the variables won't be created even if the dev requests them.


Add --version flag for ansible-language-server

I thought it would be useful to have the --version flag option in cli, so I added it.
After:
$ ./bin/ansible-language-server --version
0.8.0

I added a test.


Image get Rotated after applying RoundCornerImageProcessor

if i load the image without applying RoundCornerImageProcessor the image will load perfectly but when i apply RoundCornerImageProcessor it will rotate the image.
my code
 let modifier = AnyModifier { request in
           var r = request
           if let token = getAuthToken() {
                  r.setValue(token, forHTTPHeaderField: "AuthToken")
           }

          return r
 }

let url = URL(string: "http://xyz.com/images/mycoolimage.jpg")
let processor = RoundCornerImageProcessor(cornerRadius: 60)
self.userProfileImage.kf.setImage(with: url, placeholder: UIImage(named: "ico-menu-user-default"), options: [.requestModifier(modifier),.processor(processor)])

following is the screen shot

does i am doing something wrong or it's a bug ?

Maybe related to #535
However, I cannot reproduce this issue for an image with non-top orientation exif. The round corner processor is doing nothing on the image orientation. So it is a bit weird.
Can you upload this image in this issue? So I can take a look at it.
And for a quick "workaround", maybe you could follow the NormalizingProcessor way to see whether it could work or not. (But it should not be necessary.)

Since there is no additional comment, I will close it now. If there are any other similar cases, feel free to reopen this one or just create a new issue.


docs: add example of CLI with options

The current CLI doc hasn't an example. I couldn't understand how to use options when I first time see docs.
So, this PR purpose is add a simple example.
Thank you :)

Should be closed because of #1321.


[1.x] Update MXNet-TRT docs with the new optimize_for API

Description
Update MXNet-TRT docs with the new optimize_for API.
Also update the numbers, run on a V100 system.

Just a reminder, we're waiting for an update to the installation instructions specific to building with TRT before merging.

@samskalicky I am still waiting for updates from Wei, who is still trying to build it.
I would suggest to merge this PR and I will make another one with the build instructions

Thanks for the update on this Serge.  Looks good to me.  Small nit with code samples, but let's call it non-blocking.


fix(beaker): suppress 10_avc_check restraint plugin

fix(beaker): suppress 10_avc_check restraint plugin
It has happpened that this plugin sometimes ran after the dummy task, it reported fail
that there was some AVC (probabaly from other thing) which then failed the job and thus
mrack treated this as a provisioning failure.
This patch instructs restraint to not run this plugin and thus avoid this situation.
test: speed-up tests by mocking gethostbyaddr
Tests that are using mrack outputs are slowed down by
socker.gethostbyaddr for adhoc IP addresses. This resolution mostly
fails and the test is slow (multiple seconds timeout for single IP).
With this, all python tests are executed within 1.5s.
Notes
The other patch  was created so that I can run the tests locally effectively.

LGTM


dapp: upgrade Capacitor to version 3

Fixes #2654
First manual tests look good. We need end-to-end test... 😑
When we discover that any permission is missing while we use the app we just add it then.
Important is to check that the build (remove ./android folder and run yarn capacitor:init:android again) in the manifest ./android/app/src/AndroidManifest.xml does not include any permissions than internet (at the bottom of the file, highlighted with comment).
We need to check how this conflicts with @palango his changes to use SQLite. My hope is that because his plugin targets Cordova directly that it does not care about this upgrade...

Perfect. 👌🏾
@palango are you now testing your SQLite stuff on top of this? 🤔

Perfect. 👌🏾
@palango are you now testing your SQLite stuff on top of this? 🤔

Yes


Add support for the "X-Poedit-WPHeader" header?

Poedit allows for a X-Poedit-WPHeader header to be defined in the POT file to help extract theme and plugin header strings (documented here). grunt-wp-i18n should already handle that, but it might be worth adding support for it anyways.

Closing as wontfix for now due to lack of interest.


Fix ConcurrentModificationException

closes #1099
Please review and probably test this, to make sure I didn't introduce some side-effect.

Good Point. I think a CopyOnWriteArrayList might be a good option here. I'll push an updated commit later.


Rando Style Fixos

https://trello.com/c/jXETj5xq/89-ross-fix-what-you-broke-and-then-apologize-to-everyone

I apologize to everyone.


Redis Cluster deployment

The Redis Cluster will allow the Middleware to decrease the time it takes the Middleware to fetch the data.
The cluster replica should be placed in each Middleware location. It will be especially important with the Middleware working as a distributed system as part of #68.
On top of this, the Redis Cluster should be able to easily facilitate the new replica that could be deployed automatically with the Middleware. More thought will have to be placed into this, as this will be a critical point for Middleware in terms of accessing the planning resources.

The cluster has been successfully deployed using the redis-stack-server image.
Requires, testing of the replication, persistence and pod failure.

All tests have passed.

/close


Move binary suffix to new units package

A units package makes sense here and sounds better. Code has no other
changes.

Current coverage is 95.41%

Merging #2 into master will not affect coverage as of 036bace

@@            master      #2   diff @@
======================================
  Files            7       7
  Stmts          131     131
  Branches        24      24
  Methods          0       0
======================================
  Hit            125     125
  Partial          1       1
  Missed           5       5

Review entire Coverage Diff as of 036bace

Powered by Codecov. Updated on successful CI builds.


Remodel preevy profile

Problem Description
The Preevy profile is currently two things:

A persistent state which can be saved either locally or remotely. Contains the tunneling key, default flags and driver data.
A map of references to the persistent states ("context"), which is always saved locally. Maps a local name to the location of the persistent state.

Managing the two using a single set of CRUD actions is confusing. Specifically:

command
state
reference

create
✅
✅

import
❌
✅

ls
❌
✅

rm
❌ if remote ✅ if local
✅

cp
✅
⚠ creates a new reference, fails if it exists

config update
✅
❌

current and use
❌
✅

Prior art
Docker CLI
Docker CLI has multiple contexts stored locally, and no state. Context is only editable using the CLI context commands. All CRUD operations on the context are supported in addition to import/export in blob format.
Usage:  docker context COMMAND

Manage contexts

Commands:
  create      Create a context
  export      Export a context to a tar archive FILE or a tar stream on STDOUT.
  import      Import a context from a tar or zip file
  inspect     Display detailed information on one or more contexts
  ls          List contexts
  rm          Remove one or more contexts
  show        Print the name of the current context
  update      Update a context
  use         Set the current docker context

kubectl
Similarly to Docker CLI, kubectl has multiple contexts and no state. Contexts are stored in the kubeconfig file and are editable both using the CLI and directly by editing the file. Multiple kubeconfig files are allowed, with merging logic.
Examples: (source)
kubectl config view
kubectl config get-contexts                          # display list of contexts
kubectl config current-context                       # display the current-context
kubectl config use-context my-cluster-name           # set the default context to my-cluster-name
kubectl config set-cluster my-cluster-name           # set a cluster entry in the kubeconfig
kubectl config set-cluster my-cluster-name --proxy-url=my-proxy-url
kubectl config set-credentials kubeuser/foo.kubernetes.com --username=kubeuser --password=kubepassword
kubectl config set-context --current --namespace=ggckad-s2
kubectl config unset users.foo                       # delete user foo

Pulumi
Pulumi has a single context set locally via the login command (and unset via logout). The context references the state which can be stored on various backends (local, s3, gc, azblob, Pulumi Cloud).
Examples (source)
pulumi login # default Pulumi Cloud
pulumi login https://api.pulumi.acmecorp.com # self hosted Pulumi
pulumi login file://~
pulumi login s3://my-pulumi-state-bucket

There is no option to override the context on a specific command like in e.g, docker --context <context> ... or kubectl --context <context> ...
Suggested solutions
I suggest changing the preevy profile commands to only manage the state: tunneling key, default flags and driver data.
CRUD operations on the profile:
preevy profile create [url] [...args] # unspecified args will be prompted for
preevy profile rm <url>
preevy profile config view
preevy profile config update [...args]
preevy profile key
preevy profile cp <src> <dest>
preevy profile mv <src> <dest> # cp and rm

The reference to the profile can currently be expressed fully by the URL of the profile. There is no additional data (e.g, credentials or storage parameters).
We can support either a single context (a-la Pulumi), or a list of contexts similar to Docker CLI/kubectl and our existing features.
Option 1: Multiple contexts
This essentially allows referencing multiple profiles using local names.
Introduce a new entity "context" and a CLI topic preevy context:
preevy context add <name> <url>
preevy context update <name> <url>
preevy context rm <name>
preevy context ls
preevy context show
preevy context use <name>

The profile creation command can have flags to also add a new context or set an existing context with the new profile:
preevy profile create [--set-context <name>] [url] [...args]

Override context for a specific command
This is currently supported with the --profile global flag. We'll need to rename it to --context:
preevy up --context <name>

Convenience command init
preevy init -> preevy profile create --set-context default

Option 2: Single context
The main UX change here is dropping support for local names for the profile URLs.
Changing the current profile is done via the preevy profile use command:
preevy profile use <url>
preevy profile current # shows the URL

Looks good!
I think having multiple context and having a way to override context is important, especially if preevy is used by other tools (like Docker extension that always use a specific context created by the extension).
While we can separate the profile/context commands, I think we should see how we can make it easy to make it go end-in-end.
For example:
Preevy init: profile create (params) -> context add (alias) --use
Preevy init: --from=(url):  context add (alias) (url) --use
Preevy move/migrate-profile: preevy profile copy, preevy context update, preevy profile rm
I think it's important that the main flows will be clear and won't require multiple commands
Migration can be relatively easy as (we can use deprecation policy and make these commands hidden):
Preevy profile use -> preevy context use
Preevy profile rm* -> preevy context rm
Preevy profile import -> preevy context add (alias) (url) --use
Preevy profile current -> preevy context show
** Not sure if we need preevy profile mv, also since we currently have profile rm, it might worth using preevy profile remove/delete for backward compatibility (maybe add flags that differ between clearing the data, and removing the container which might not always be possible or desired).


Nightride FM soundscape

I've already added it to my own install (thank you for the custom feature!), but I think Nightride FM would make a great addition to the built-in repertoire. They have different flavors of synthwave spread over four YouTube livestreams, which translates nicely to a Soundscape comprised of four tracks.

Nightride FM: https://www.youtube.com/watch?v=uYfxDF_QR94
ChillSynth FM: https://www.youtube.com/watch?v=UedTcufyrHc
Datawave FM: https://www.youtube.com/watch?v=Y9q6RYg2Pdg
Spacesynth FM: https://www.youtube.com/watch?v=5-anTj1QrWs

ChillSynth has been added to settings in 1.3.0 (just released). :)


Preserve as much information as possible for Datetime values

As @flaviut noted, currently the internal representation of different datetimes can sometimes be the same, due to the way time zones are handled (e.g., 1978-02-07T01:02:03Z, 1978-02-07T01:02:03+00:00, and ``1978-02-07T01:02:03-00:00`). A better representation should be achieved, perhaps inspired by https://gist.github.com/flaviut/7382d036b5cfc612cfb0#file-lex-nim-L33-L45 .

Fixed with commit c41554f5cf132f989c83ba0d39c223a999e7a196


Sequence base class

Addresses part of issue #454
Changes:

New class hierarchy:

Sequence < EmbeddedFactorSequence < EmbeddedSequence classes. The last one is a special case of the factored sequence with only one factor and handy properties that add syntactic sugar.
RecurrentEncoder class which takes a sequence. SentenceEncoder and FactoredEncoder are moved to the neuralmonkey.encoders.recurrent module and are special cases of RecurrentEncoder.

RecurrentEncoder takes input_sequence parameter. Arguments vocabulary/ies, data_id[s], max_length, and embedding_size moved from encoders to sequences.
Decoder takes embedding_source: EmbeddedSequence instead of embedding_encoder: SentenceEncoder
Other decoders (SequenceLabeler, WordAlignmentDecoder) updated to work with RecurrentEncoder.
hidden_states renamed to states
post-edit.ini scenario updated to use LSTM with RecurrentEncoder and manually created Sequence. Other test cases still use SentenceEncoder.

zacalo to kricet, ale trenovani funguje normalne
Coder: <neuralmonkey.encoders.recurrent.RecurrentEncoder object at 0x2ad40451b668> does not have a data attribute.

Jo, to je v checking modulu, kterej se musí updatnout. dík


Typo in QUERY_RESPONSE_REFINE_PROMPT causing incorrect refine prompt

When asking the LLM to evaluate a response the following improper prompt is passed:
"We want to understand if the following query and response isin line with the context information"
With the assumed intent being:
"We want to understand if the following query and response is in line with the context information"
The base.py file has a missing character in the definition of QUERY_RESPONSE_REFINE_PROMPT.  A space was left off the first line so the "is" and "in" become "isin"
QUERY_RESPONSE_REFINE_PROMPT = (
"We want to understand if the following query and response is"
"in line with the context information: \n {query_str}\n"
"We have provided an existing YES/NO answer: \n {existing_answer}\n"
"We have the opportunity to refine the existing answer "
"(only if needed) with some more context below.\n"
"------------\n"
"{context_msg}\n"
"------------\n"
"If the existing answer was already YES, still answer YES. "
"If the information is present in the new context, answer YES. "
"Otherwise answer NO.\n"
)

Fixed!


Show 'Add People' button for implicit admins

r? @keybase/react-hackers

ping @keybase/react-hackers

Rebased on master and added a few more tests.

lol, sorry @chrisnojima didn't realize you were reviewing too


Missing test-cases for election-day

Hey, when mentoring election-day I have seen the following code:
// IncrementVoteCount increments the value in a vote counter
func IncrementVoteCount(counter *int, increment int) {
	*counter += 2
}

It only passes as there is only the following test case:
	{
			name:      "Call to IncrementVoteCount with a pointer to an int with a value of 2 and increment of 2",
			counter:   &twoVotes,
			increment: 2,
			expected:  4,
		},

We should add further test cases here

I faced it accidentally it is a good catch


fix: preserve magic code when login

Details

Fixed Issues

$ https://github.com/Expensify/App/issues/21293
$ https://github.com/Expensify/App/issues/23087
PROPOSAL:
Tests

Navigate to Sign-in page on two tabs
Enter account > Continue
Verify that it redirects to magic code input on both tabs
Enter an invalid magic code with 6 characters on the first tab
Verify that the error appears and the magic code is still preserve
Press Didn't receive a magic code on the second tab
Verify that all errors on the first tabs are cleared

[x] Verify that no errors appear in the JS console

Offline tests

QA Steps

Navigate to Sign-in page on two tabs
Enter account > Continue
Verify that it redirects to magic code input on both tabs
Enter an invalid magic code with 6 characters on the first tab
Verify that the error appears and the magic code is still preserve
Press Didn't receive a magic code on the second tab
Verify that all errors on the first tabs are cleared

[x] Verify that no errors appear in the JS console

PR Author Checklist

[x] I linked the correct issue in the ### Fixed Issues section above
[x] I wrote clear testing steps that cover the changes made in this PR

[x] I added steps for local testing in the Tests section
[x] I added steps for the expected offline behavior in the Offline steps section
[x] I added steps for Staging and/or Production testing in the QA steps section
[x] I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
[x] I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
[x] I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).

[x] I included screenshots or videos for tests on all platforms
[x] I ran the tests on all platforms & verified they passed on:

[x] Android / native
[x] Android / Chrome
[x] iOS / native
[x] iOS / Safari
[x] MacOS / Chrome / Safari
[x] MacOS / Desktop

[x] I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
[x] I followed proper code patterns (see Reviewing the code)

[x] I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
[x] I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
[x] I verified that comments were added to code that is not self explanatory
[x] I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
[x] I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method

[x] If any non-english text was added/modified, I verified the translation was requested/reviewed in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:

[x] I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
[x] I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
[x] I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
[x] I verified the JSDocs style guidelines (in STYLE.md) were followed

[x] If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
[x] I followed the guidelines as stated in the Review Guidelines
[x] I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
[x] I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
[x] I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
[x] I verified that if a function's arguments changed that all usages have also been updated correctly
[x] If a new component is created I verified that:

[x] A similar component doesn't exist in the codebase
[x] All props are defined accurately and each prop has a /** comment above it */
[x] The file is named correctly
[x] The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
[x] The only data being stored in the state is data necessary for rendering and nothing else
[x] If we are not using the full Onyx data that we loaded, I've added the proper selector in order to ensure the component only re-renders when the data it is using changes
[x] For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
[x] Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
[x] All JSX used for rendering exists in the render method
[x] The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions

[x] If any new file was added I verified that:

[x] The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory

[x] If a new CSS style is added I verified that:

[x] A similar style doesn't already exist
[x] The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG))

[x] If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
[x] If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
[x] If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
[x] If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
[x] If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
[x] I have checked off every checkbox in the PR author checklist, including those that don't apply to this PR.

Screenshots/Videos

Web

https://github.com/Expensify/App/assets/113963320/dfb2cac3-5298-40df-a462-7d04514e13e4

Mobile Web - Chrome

https://github.com/Expensify/App/assets/113963320/115e9e0b-d507-4f8f-ad3e-a17d080782df

Mobile Web - Safari

https://github.com/Expensify/App/assets/113963320/70e9a917-c0bc-4870-96a7-d94bd841ca88

Desktop

https://github.com/Expensify/App/assets/113963320/9f4ab2f9-bf0b-428f-a162-e8edb14af46a

iOS

https://github.com/Expensify/App/assets/113963320/e274c4bb-fd64-4376-bb95-1544040375fa

Android

https://github.com/Expensify/App/assets/113963320/807e2bb0-ce13-4ce6-9e80-91606a18d987

🚀 Deployed to staging by https://github.com/danieldoglas in version: 1.3.42-13 🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
success ✅

🕸 web 🕸
success ✅

🚀 Deployed to production by https://github.com/jasperhuangg in version: 1.3.42-26 🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
success ✅

🕸 web 🕸
success ✅

🚀 Deployed to staging by https://github.com/danieldoglas in version: 1.3.44-0 🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
success ✅

🕸 web 🕸
success ✅


Uniform SDK, system version and available frameworks checks.

We have a big mess on the way we check for these things and we should uniform and keep only the best and recommended way to check for these things.
Feel free to comment or edit this description directly.
Concretely we need to adopt the best way to:
Check the platform
a. #ifdef TARGET_OS_MAC
b. #ifdef TARGET_OS_IPHONE
c. #if defined(TARGET_OS_IPHONE) || defined(TARGET_IPHONE_SIMULATOR)
Check the build time SDK version
a. #ifdef __IPHONE_8_0/__MAC_10_10
b. #if __IPHONE_OS_VERSION_MIN_REQUIRED >= 60000/#if MAC_OS_X_VERSION_MIN_REQUIRED >= MAC_OS_X_VERSION_10_9
c. #if MACOSX_DEPLOYMENT_TARGET < __MAC_10_10 || IOS_DEPLOYMENT_TARGET < __IPHONE_7_0
Check the runtime system version
a. [[[UIDevice currentDevice] systemVersion] floatValue] >= 7.0
b. #define SYSTEM_VERSION_GREATER_THAN_OR_EQUAL_TO(v)  ([[[UIDevice currentDevice] systemVersion] compare:v options:NSNumericSearch] != NSOrderedAscending)
c. floor(NSFoundationVersionNumber) > NSFoundationVersionNumber_iOS_6_1
OS X?
Check if AppKit is available (for CLI tools)
a. #ifdef NSAppKitVersionNumber10_0
b. respondsToSelector:?
c. __has_import(<AppKit/NSColor.h>)
Check if defined vs check value
a. Prefer #ifdef VALUE
b. Prefer directly #if VALUE
c. Use both #if defined(VALUE) && VALUE as it may be defined but set to 0 (never the case?).
Other check used in CocoaLumberjack that hopefully won't be longer needed
a. #ifdef MAC_OS_X_VERSION_10_9
b. [NSTimer instancesRespondToSelector:@selector(tolerance)]
c. #if !OS_OBJECT_USE_OBJC
d. #if __IPHONE_OS_VERSION_MAX_ALLOWED >= 50000

I think we solved those issues and the issue can be closed.


Cannot run with or without installing transformer.

Hi, I found I cannot run the learned token pruning whether I install the transformers or not.
If I install transformer, it will raise the error of ValueError: Some specified arguments are not used by the HfArgumentParser: ['--masking_mode', 'soft', '--weight_decay_threshold', '0.0', '--lambda_threshold', '0.1', '--temperature', '0.0001']. I think it is because these arguments are customized in src/transformers.
If I go with an environment which doesn't install the transformer, it will have ModuleNotFoundError: No module named 'transformers'. It simply cannot import from /src .
If I force the code of run_glue_ltp with sys.path.insert(1, './src/'). It will have the error of pkg_resources.DistributionNotFound: The 'sacremoses' distribution was not found and is required by this application .
Can you tell me how to run the code properly? Thanks.

the same...


CURE-1372 Adding pom file

Summary

Adding pom.xml file so we can publish the package to Nexus and Code Artifact.
Result

We don't need the pom file for this.


Recommend fix for not enough training time to user.

In some case (>1GB), CLI takes forever to complete the last iteration. (>30min or >1hr). The training screen is stuck at the message "Finalizing screen". We need to add some feedback saying the tool is still running and completing the training.

#19


Make A001 warns when method shadows a builtin (or create a new rule for this)?

Hi, first of all, thank you for building this tool, saved me time integrating tens of similar tools into the project.
Now, here's the problem I noticed recently: for variables we have A001 to warn when it shadows a builtin. However, builtins can also be shadowed by methods, but A001 does not catch that. Here's a situation where it can cause trouble:
class C:
    @staticmethod
    def list() -> None:
        pass

    @staticmethod
    def repeat(value: int, times: int) -> list[int]:
        return [value] * times

If you pass this to pyright it will warn at the return type of repeat, like this:
a.py:7:43 - error: Expected type expression but received "() -> None" (reportGeneralTypeIssues)

From the error message, looks like list in the second method signature is understood as the list method we defined above, not the list builtin. This is highly confusing, but I'm not sure if this really belongs to A001 though as this problem only happen at type level, you can't refer to that method inside another method.
Anyway, it costs me almost an hour to realize what's wrong (yep, I'm that noob), so I think I should just write this down in case another poor soul is also facing the same problem 🤷

I think we may have done this originally, but it ended up being more confusing than helpful. I think this could be useful though. We'd probably want to flag at the usage site (like list[int]), not the definition site (def list), since it's totally valid for a class to define a function named list. The confusion comes when you reference that function within the class scope.

Ah sorry, I believe this is A003?
foo.py:3:9: A003 Class attribute `list` is shadowing a Python builtin

Ouch, sorry for wasting your time. I looked at the end of my config and see the ignorelist having only id there so I thought A003 is being partially enabled, turned out there is another line completely disabled that rule. I tried with A003 enabled and it does warn at the definition of list(), thank you.


fix: use StringMap type for better type safety in utility functions

📝 Description
Refactored utility functions to use UnknownMap type (Record<string, unknown>) for better type safety and flexibility.
⛳ Current behavior (updates)

Functions used Record<string, string> or Object, causing potential type issues and limited flexibility.
Used @ts-ignore to bypass type checking.

🚀 New behavior

Functions now use UnknownMap type for better type safety and flexibility.
Removed @ts-ignore comments by addressing type issues directly.
Updated function signatures to handle unknown values more robustly.

💣 Is this a breaking change (Yes/No):
No

Summary by CodeRabbit

Refactor

Enhanced type safety and clarity by updating internal functions to utilize more specific type definitions.

@wingkwong Hello, I've modified the types based on the feedback you provided earlier. The pull request is still open, so please review it when you have a chance. If further changes aren't needed, I'll plan to close it. thank you

Closing - let's keep it as it is first.


adding output and isOptionalAlwaysEnabled options to CLI

Thanks for opening this, it looks great! Can you reply to the Googlebot to make sure you've signed the CLA? Once you do I'll approve your other PR!


Your URL didn't respond with the value of the challenge parameter.

Description
Describe your issue here.
My test setup was working perfectly fine. But once I restarted ngrok, I am trying to put the new endpoints, none of the requests r coming to ngrok. I am missing something here. When I do a postman request I do get the request, same with oauth, but not for any events.
What type of issue is this? (place an x in one of the [ ])

[ ] bug
[ ] enhancement (feature request)
[ ] question
[ ] documentation related
[ ] example code related
[ ] testing related
[ ] discussion

Requirements (place an x in each of the [ ])

[ ] I've read and understood the Contributing guidelines and have done my best effort to follow them.
[ ] I've read and agree to the Code of Conduct.
[ ] I've searched for any related issues and avoided creating a duplicate issue.

Bug Report
Filling out the following details abo

ut bugs will help us solve your issue sooner.
Reproducible in:
package version:
node version:
OS version(s):
Steps to reproduce:

Expected

result:
What you expected to happen
Actual result:
What actually happened
Attachments:
Logs, screenshots, screencast, sample project, funny gif, etc.

@santhinisjr - What is your ngrok output showing when the challenge request comes through? Also can you doublecheck that the port your app is listening on is the same port you're running ngrok on?

i dont see  any requests from slack on ngrok output, yes both are listening to the same port

@santhinisjr If you use ngrok in their free plan, your subdomain in ngrok.io can be changed after a certain time or every time you restart the ngrok process.

On the free plan, ngrok's URLs are randomly generated and temporary. If you want to use the same URL every time, you need to upgrade to a paid plan so that you can use the subdomain option for a stable URL with HTTP or TLS tunnels and the remote-addr option for a stable address with TCP tunnels.

https://ngrok.com/docs#getting-started-stable
Please make sure whether you're using the currently active domain for the Request URL in the Slack app configuration page. Also, ngrok's local dashboard is useful for easily checking requests/responses through the proxy: http://localhost:4040/inspect/http

i updated the new ngrok urls in slack configuration page, ngroks local dashboard doesnt show any requests from slack app

Just to add it to it, I see that this ngrok URL works for the same Internet otherwise gives tunnel not found error. If that's the case , i guess that's the issue. Any clue on how to fix this ?

I see that this ngrok URL works for the same Internet otherwise gives tunnel not found error.

What do you mean by this? Does this mean the ngrok.io URL is reachable from your network?
I'm unsure about what's happening to your tunnel. As we are not the ngrok team, we may not be able to help you out regarding the issues around ngrok. Possibly, to completely terminating the ngrok and your app processes, restarting your computer may worth trying. Anyway, I hope you'll resolve the issue soon!


Incremental build broken when switching branches

Sometimes when switching between branches, the incremental build is broken, with the following error:
[8/621] Building NuttX for px4fmu-v4 with nsh
FAILED: px4fmu-v4/NuttX/nuttx/nuttx-export/include/nuttx/config.h
cd /home/beat/px4/src/Firmware/build_px4fmu-v4_default && /usr/bin/rm -rf /home/beat/px4/src/Firmware/build_px4fmu-v4_default/px4fmu-v4/NuttX/nuttx/nuttx-export && /usr/bin/make --no-print-directory --quiet -C /home/beat/px4/src/Firmware/build_px4fmu-v4_default/px4fmu-v4/NuttX/nuttx -r CONFIG_ARCH_BOARD=px4fmu-v4 export > nuttx_build.log
In file included from ./stdio/lib_libdtoa.c:47:0,
				 from stdio/lib_libvsprintf.c:236:
/home/beat/px4/src/Firmware/build_px4fmu-v4_default/px4fmu-v4/NuttX/nuttx/include/math.h:52:25: fatal error: arch/math.h: No such file or directory
 #  include <arch/math.h>
						 ^
compilation terminated.
ERROR: arm-none-eabi-gcc failed: 1
	   command: arm-none-eabi-gcc -MT bin/lib_libvsprintf.o  -M -std=gnu99 -Wall -Wextra -Werror -Wdouble-promotion -Wframe-larger-than=1024 -Wlogical-op -Wpacked -Wpointer-arith -Wshadow -Wno-sign-compare -Wno-unused-parameter -Wno-nonnull-compare -Wno-misleading-indentation -Wall -Wextra -Werror -Wdouble-promotion -Wframe-larger-than=1024 -Wlogical-op -Wpacked -Wpointer-arith -Wshadow -Wno-sign-compare -Wno-unused-parameter -Wno-nonnull-compare -Wno-misleading-indentation -Wbad-function-cast -Wmissing-parameter-type -Wnested-externs -Wstrict-prototypes -Wno-bad-function-cast -Wno-cpp -Wno-implicit-function-declaration -Wno-maybe-uninitialized -Wno-missing-field-initializers -Wno-nested-externs -Wno-old-style-declaration -Wno-pointer-sign -Wno-type-limits -Wno-unused-but-set-variable -Wno-unused-function -Wno-unused-label -Wno-unused-variable -Os -fno-strict-aliasing -fno-strength-reduce -fomit-frame-pointer -funsafe-math-optimizations -fno-builtin-printf -ffunction-sections -fdata-sections -g -mcpu=cortex-m4 -mthumb -march=armv7e-m -mfpu=fpv4-sp-d16 -mfloat-abi=hard -I. -isystem /home/beat/px4/src/Firmware/build_px4fmu-v4_default/px4fmu-v4/NuttX/nuttx/include -D__KERNEL__ -pipe -fno-common stdio/lib_libvsprintf.c
make[1]: *** [.depend] Error 1
In file included from ./stdio/lib_libdtoa.c:47:0,
				 from stdio/lib_libvsprintf.c:236:
/home/beat/px4/src/Firmware/build_px4fmu-v4_default/px4fmu-v4/NuttX/nuttx/include/math.h:52:25: fatal error: arch/math.h: No such file or directory
 #  include <arch/math.h>
						 ^
compilation terminated.
make[1]: *** [bin/lib_libvsprintf.o] Error 1
make: *** [libc/libc.a] Error 2

It looks like the NuttX patches are not applied when rebuilding. make clean does resolve it, but I think this should work incrementally as well.
I never had this problem before the NuttX upgrade.
@dagar Can you have a look?

Is the NuttX submodule changing in these situations?
Generally I'm a little paranoid and do make distclean between branches, but I'm often jumping between branches off of latest master, and branches off of stable.
We should still make incremental build reliable.

Is the NuttX submodule changing in these situations?

I think so but I haven't explicitly checked that.
Thanks for looking into it.

It's actually not obvious what's going on here. If you use a build with an IO (eg px4fmu-v3) changing the submodules cause cmake to rerun and the nuttx build gets into a bad state, but only for the FMU.

Is it possible that the patch's stamps are not fully qualified paths?


fix building docs on windows

Fixes the script for building the docs on windows. At some point the sources seem to have been moved into the source directory and the relevant change was made to the makefile but not to the windows script.

Thanks for the patch. I think that this is a candidate for 0.49 final.

I agree, it would be good to backport this. I assume the errors will be fixed by: #5455

@stuartarchibald @esc Will you "backport" (only two words...) this with one of your finalizing commits for 0.49.0 or do you want me to rebase this?

@ARF1 no worries, I think we will take of it.

/AzurePipelines run

NOTE: Someone needs to go and manually test this on a windows box.

@stuartarchibald thanks for testing!


Partial naming collision

Hello,
Not a bug, just something to be aware of. I just ran into an error due to having a partial named _head.haml.html in my application.html.haml. It was then load app/views/forem/forums/_head.html.erb.
Maybe something like _forum_head.html.erb?
Thanks,
Albert

That's due to Rails' view inheritance.. it does make it interesting..

Aha - indeed I am using inherited views. Good catch, something I'll have to be mindful of in the future as I plan to leverage engines all over the place.

Could you show us how you're referencing this partial in your layout? Could be that you need to give it a more absolute path.

Ah - yeah, that will also work. It was just:
= render :partial => 'head'

but it should have been application/head.
Thanks, great project by the way!!

Rightio, glad you got this solved :)
Thanks for the super kind words!


More legacy tuple cleanup

@swift-ci Please test

@swift-ci Please test source compatibility

@xedin I've been thinking about how to fix the broken cases in test/expr/closure/anonymous.swift. It might be a bit easier now with the recent changes...

@swift-ci Please test source compatibility


Intro code cannot work

Hello,
I was reading again the intro on the webiste but i found out that the full game code (can be found here) cannot work because of the score variable that is not scope of the lose scene ...
Score is declared inside the game scene, but we try to get it in the lose scene which cannot work.

More specifically, putting the score variable into the scene is never explained, but instead just put into the full code example at the bottom of the page;
This line isn't explained: scene("lose", (score) => {

The full code below does work, but yeah it's not explaining we're passing score through go("lose", score) and the lose scene gets it from the function argument. I'll add explanation soon.


Please add Rohan Law to those business accepting Monero

Criminal defense firm in Atlanta, Georgia USA accepting Monero for Payment of services to defend clients in maters pending in the State of Georgia.  www.rohan.law

Updated Monero wallet address for business payments…
monero: 49qAa59VfVn7eZksq7CWm6TeiiC152S2MT6cbt7vV3VYXk5vVg4uPhuLE5sKvt1E13CFpDGcbEFXWi6VNf3Eoq8h3ngxTyT
Kind regards,
Douglas Brooks Rohan,   		Esq.
Tu mejor opción legal
t.<PHONE_NUMBER>
e<EMAIL_ADDRESS><EMAIL_ADDRESS>w.	www.rohan.law http://www.rohan.law/
s.	375 Northridge Road, Suite 120, Atlanta, GA 30350
https://www.facebook.com/RohanLawPC https://www.facebook.com/AbogadoRohan/ https://twitter.com/RohanLawPC https://twitter.com/AbogadoRohan https://www.instagram.com/explore/locations/163770873671772/rohan-law-pc-injuries-criminal-defense/ http://instagram.com/abogadorohan https://www.linkedin.com/company/rohan-law-pc/ https://www.youtube.com/channel/UCkLVYgh-EblFl9zykZ5nNww
https://www.avvo.com/attorneys/30341-ga-douglas-rohan-502591.html

On Feb 12, 2018, at 10:00 AM, luigi1111<EMAIL_ADDRESS>wrote:
Closed #577 https://github.com/monero-project/monero-site/issues/577 via #579 https://github.com/monero-project/monero-site/pull/579.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub https://github.com/monero-project/monero-site/issues/577#event-1469621475, or mute the thread https://github.com/notifications/unsubscribe-auth/AiPRBM1oEsWBBGRVjSQ7OXcuXBne40f2ks5tUFHygaJpZM4Rv1_s.


SNI in Secondary config

In the configuration provided for the tunnel server, the fake address we gave is registered and we have to change SNI to our domain to make it work.
Thank you for fixing it in the next update or giving a solution so that we don't have to change them manually.
Thankful

If you're talking about v2ray clients, you don't need to add sni, you just have to manually tick "allow insecure" for it to work.
But we're adding domain support as well soon.

Domain support is also added.


Sozo call command

Related to https://github.com/dojoengine/dojo/issues/1663.
Closes DOJ-263.
Add sozo call command to be able to directly call view functions without using starkli.

Great first pass @remybar.
Could we also add the BlockId as an argument? This will allow the user to configure it. 👍

Sure ! Thanks for the review ser !

@remybar could we also create a test module into the ops/src? That would be better as more tests will be added in the future.

@remybar I've merged a commit on main for a hot fix on regression for sozo auth grant writer, I've taking also this opportunity to create the test module. Let me know if some questions arise during the rebase.


Detector Geometry for Multi-Paneled and Mobile Detectors

Opening this issue, which is near and dear to the hearts of programmers (including users) at LCLS. Well, maybe hated and feared might be more appropriate.
My issue is:
We'd like to build support for a user-friendly interface into complicated camera geometries into scikit-xray. Together can we discuss the best way to do this?
Our most commonly used camera, the CSPAD, looks like this:

The four "groups" of 8 panels each can move with respect to one another. None of the individual elements are perfectly flat nor orthogonal. Needless to say, dealing with the geometry of this thing is a real pain.
I have written the following code to deal with geometries:

https://github.com/LinacCoherentLightSource/psgeom
https://github.com/tjlane/thor/blob/master/src/python/xray.py#L429

The first link implements a hierarchical geometry organization,
https://confluence.slac.stanford.edu/display/PSDM/Detector+Geometry
The second, a vector representation of each panel,
https://github.com/tjlane/thor/blob/master/src/python/xray.py#L147
Neither of these schemes was originally created by me, but both are in use at our facility, so we've tried to support both. The latter implementation also nicely provides for reciprocal space calculations, which can be invaluable.
Finally: we've done a lot of work on calibrating the geometry of detectors in space, mostly using Bragg peaks from known crystalline samples. Just a heads-up, as code supporting those kinds of things is likely good to leave to a future discussion.
Related Issues
#32
#199
#286
Related Closed Issues
#18
#37
#161

Can thor.xray be used with a single flat panel detector?

I am kind of  happy to loop back around to CSPAD, I sat next to the people at Cornell who were designing the chips when I was an undergrad.
I took a quick skim of the linked code and it looks like a major use is to get (h, k, l, i)/(x, y, z, i) lists out of the detector?
If I am understanding correctly,  e have similarly spirited code for taking a stack of images taken at different detector positions (which is very similar, CSPAD just takes the pictures in parallel).  The work flow then goes something like
hkl, I = my_snowflake_detector(snowflake_raw_data)
result1 = my_function(hkl, I)
result2 = other_function(resuslt1)
final_result = last_function(result2)

where the my_snowflake_detector is just a callable (maybe a callable class) that knows how to turn the input data into a set of coordinate positions and pixel intensities.  This way all of the details about the camera and how the data was taken are wrapped up in my_snowflake_detector and the rest of the code should be sharable between experiments.
Exploiting partials, currying, and callable classes will probably be important for making some of this work nicely.
We are also big fans of layered APIs, at the bottom there are things that are very explicit and at the top there are very thin layers, that may end up being very specialized, provide the 'nice' interface to the users/data storage (ex, we probably want to have a high level function which is do_some_analysis(run_id) that inside knows how to get the relevant data from our database and then dispatch out to the lower layer functions to actually do the work).

@ericdill thor.detector style stuff works for any detector composed of flat planes. So yes, a single-panel "typical" detector is a special case. I've used it for pilatus and rayonix detectors before. I think if a system works for the CSPAD it will work for any rayonix or other usual detector.
There is some discussion in our community about handling any detector, e.g. a curved detector. I personally think this is overengineering -- never have I actually seen any concrete plans for such a detector, and it can make things much more complex.
@tacaswell you are correct, the main use case is:

getting pixel positions in reciprocal space and
locating the intensity data that corresponds to each pixel

but there is one final use case that is very important:
3. providing easy ways to manipulate the geometry for optimization/calibration purposes
e.g. we often use experimental data to refine the detector position in real space.
@tacaswell can you link to the snowflake code here? Thx :)

The snowflake code that @tacaswell referenced above is vaporware. The (rough) concept is that these callable classes live in beamline-specific repositories (e.g., https://github.com/NSLS-II-CSX/csxtools) and are canned data analysis pipelines that correspond to known data collection routines.  They would take in some sort of reference to data and the produce some analyzed output.  For example,
from dataportal import DataBroker as db, fetch_events
from skxray.core import recip, utils
from matplotlib import pyplot as plt
from xray_vision.mpl_plotting import recip_plotter

class SomeCallableClass:
    def __call__(self, scan_id):
        # Load data
        hdr = db[scan_id]
        events = fetch_events(hdr)
        images = Images(hdr, 'detector_name')
        # Use metadata to convert to Q
        hkl = recip.process_to_q(hdr.motor_angles, hdr.detector.shape,
                                 hdr.detector.pixel_size,
                                 hdr.calib.calib_center,
                                 hdr.calib.sample_distance,
                                 hdr.calib.wavelength, hdr.UB)
        # Convert (h, k, l, intensity) array to a regularly spaced grid
        mean, occupancy, std_err, oob, bounds = utils.grid3d(hkl, images)
        # Plot data
        fig, ax = plt.subplots(ncols=3)
        # recip_plotter does not yet exist, but as I wrote this is seemed
        # sensible to make a plotter helper function for this
        recip_plotter(ax, mean, occupancy, std_err)
        plt.show()

@ericdill understand the paradigm better now, thanks. Actually this isn't too far from what we have now.
That said, even if something like the previous post is the ultimate user interface, representing and manipulating the experimental geometry (e.g. tilting a detector, or changing it's distance from the interaction site) is a common thing to do that is hidden in the above. I guess the question becomes, should the code to do those geometric manipulations live:

In skxray
In some other common repo beamline specific stuff is built on top of
Fully in beamline specific repos

I like options 1 and 2 b/c they share code that is complicated and challenging to re-write. Options 2 and 3 mean that skxray can say more as an algorithms library, less as a utilities library. What are you guys thoughts? Really a question of scope.
cc @tacaswell

I agree that these seem like the only three options.
I agree that option 3 is not a good one because it seems like it would lead to a lot of copy/paste code, which is demonstrably poor design.
I think I prefer Option 2.  I see a couple of advantages that a common detector-repo provides.

Tightly scoped... It seems like this library provides one function: Convert my raw measured data into useful scientific data so that I can analyze it. I like tightly scoped libraries, it keeps the interface in/out easy.
It seems like a detector manipulation repo would be rife with weird dependencies and it would be nice to keep that segregated from the weird dependencies that skxray is already picking up

OK I think I agree. I don't think the geometry code would use many, if any, additional dependencies beyond what we have in skxray already. That said, a tightly scoped detector library makes some sense to me.
tag external code that could provide a foundation, by no means complete for a general purpose library: https://github.com/LinacCoherentLightSource/psgeom
cc @chrisvam @chuckie82 for opinions: where should detector manipulation code live?

@tjlane Do you have any interest in making thor an 'affiliated package' of scikit-beam?  @tacaswell can explain a little better what an affiliated package is.  Basically this --> http://www.astropy.org/affiliated/

@ericdill in short... yes. I am wondering, though, if it's better to move it into the skbeam org? thoughts?


[FEAT]:  RAG with Graph

What would you like to see?
Support for RAG with graph functionality.
https://python.langchain.com/v0.1/docs/use_cases/graph/constructing/
https://neo4j.com/labs/genai-ecosystem/llm-graph-builder/

Moved to https://github.com/Mintplex-Labs/anything-llm/issues/1008