Remove invalid URL to bzip.org site

We cannot download http://www.bzip.org/1.0.6/bzip2-1.0.6.tar.gz
It looks like the http://www.bzip.org domain is not registered anymore.
I have a build failing because of this:
https://ci.appveyor.com/project/dacap/laf/build/job/dvkndsw752mrvg4t

Thanks!
However, this should have worked regardless because the other URL works and vcpkg tries all the listed URLs until it succeeds. Was that not the case in your CI?

Thanks @alexkaratarakis. About the failed URL, actually the problem is that the first URL does work but an HTML file is downloaded, so the hash comparison fails and then the whole process fails (maybe vcpkg could delete the package and try the next URL in this case, or detect that the downloaded file is an HTML file or a different type of the expected one):

@dacap We currently download in a partial file file.zip.part and hash-check that. We rename it to file.zip only if it succeeds. Not sure what happened here, but I am not sure if there is a better way to handle this.

@alexkaratarakis IMO I think that test_hash() could do a better job instead of failing with a FATAL_ERROR.
For each url the file should be downloaded and the hash tested, if the hash fails, the downloaded file should be deleted and a new url tried. If all url/hashes fails, in that point we should show the fatal error.


Added four movement functions

These new functions can be called by the AI and will have the same effect as pressing the arrow keys.
PAC-18: The game/agent interface must contain methods that allow the agent to control Pac-Man

added as draft PR to test automations

Rolled in PAC-17, which includes functions that can be called by the AI for updated game information.


Android: Use captions, Caption text size and Caption styles

Requires API Proposal
This issue may require a new API, or a change to an existing API. An API proposal should be added and discussed before proceeding with implementation. The API proposal can be added in the comments of this issue or linked as a separate issue.
Description
The AccessibilityInfo API supports getting the values of many system-level accessibility settings, but caption settings are not one of them.  Both iOS and Android have support for various caption-related settings, such as whether they are enabled by default, the text size and color, the text style, and the background color.
Building any experience in React Native that relies on audio being played should have a captioned alternative, and it should use these caption settings for the default display.
React Native version:
v0.63
Expected Behavior
The AccessibilityInfo API should have a way to query the various caption settings.
Android Details
The CaptioningManager class (https://developer.android.com/reference/android/view/accessibility/CaptioningManager) is the way you can get access to the value of these settings.
iOS Details
On iOS the Media Accessibility Framework (https://developer.apple.com/documentation/mediaaccessibility/) provides these values.

While this is technically an issue, it's not very common that anyone would need to query this data in React Native, as it's unlikely they will be rendering captions themselves with RN, rather than in a video player itself.


Getting started

Hi,
Thanks for this project! I'm quite new to Go but I'd like to use this program to record sessions of my VNC server. I'm not sure how to get started however. Would it be possible for you to provide a small getting started document? For example as readme.md in the examples folder.
Would be greatly appreciated!
Kind regards.

Hi,
You can use the files under the example folder, they are functional little
programs that demonstrate what you can do with the code
or you can use saily's vnc-recorder https://github.com/saily/vnc-recorder
project - he created a command line interface over this proj that has a lot
of flags for you to play with.
In general, after building it and playing around a lot with
video encodings,
I got to the conclusion that real-time h264/5 encoding (or any other modern
/ high-end encoding),
will be highly CPU consuming (which may be ok in some scenarios), but in
mine we ended up opting for saving the video in a minimally compressed
format, and encoding it later using AWS facilities.
Regards,
Amit.
On Wed, Jul 1, 2020 at 5:49 PM EWouters<EMAIL_ADDRESS>wrote:

Hi,
Thanks for this project! I'm quite new to Go but I'd like to use this
program to record sessions of my VNC server. I'm not sure how to get
started however. Would it be possible for you to provide a small getting
started document? For example as readme.md in the examples folder.
Would be greatly appreciated!
Kind regards.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/amitbet/vnc2video/issues/15, or unsubscribe
https://github.com/notifications/unsubscribe-auth/AAXNOAB4D2BTJ4V47INTEGTRZNEG3ANCNFSM4ONPVS2Q
.


chat_english alternatives

An issue I've heard get brought up is that sometimes the chat_english.txt replacement process might screw up / miss the file and cause other mods' localization to not get loaded.
It might be worth just using a different file entirely that overrides the entries in chat_english entirely. chat_english was originally chosen for hud mods because it was fairly small file that would be easy to keep up to date, but that doesn't really matter too much if you are automatically generating the file -- there's nothing special about chat_english itself and there are many other localization files that can contain the relevant entries. And since chat_english is pretty much only used by huds and (afaik) no other localization files get regularly modded, using a different file to avoid collisions is a good approach imo.
For reference, the load order of files is as follows:

replay_english
youtube_english
valve_english
gameui_english
valve_english (again)
platform_english
vgui_english
tf_english
chat_english
tf_proto_obj_defs_english
serverbrowser_english

Unfortunately I can't remember if earlier loads have priority over later loads, or later loads overwrite earlier loads. It should be pretty quick to test, just try it with one of the many early ones and with serverbrowser_english and see which one works.

That would fix my issue. Currently this app overwrites my entire custom 'translation' ingame.
Thank you JarateKing for contributing. Your work on teamfortress.tv is very valuable for HUD enthusiasts.

@CrazyGunman2C4U is your custom translation inside a VPK? The tool should be basing all of its modifications off of existing chat_english.txt/tf_english.txt files.

Also @JarateKing a few corrections, looks like serverbrowser_english.txt isn't loaded unless you open the server browser. Also, closecaption_english.txt is loaded between chat_english.txt and tf_proto_obj_defs_english.txt

Odd about serverbrowser_english.txt, I didn't verify that the strings were actively being used but it did show up in procmon when starting tf2 without doing anything special.
closecaption_english.txt is for captions rather than localization (despite the same naming convention) so it wouldn't be a valid option, I didn't mention it for that reason. It wouldn't be a good candidate anyway even if that weren't the case, since editing it is even more common than using custom chat_english in the first place.

@PazerOP No, it's inside a folder \tf\custom<hud-name>\resource\chat_english.txt
I haven’t changed a thing since mentioning it in the discord chat.

The new method involving "closecaption_.txt" seems to work well. This should fix any incompatibilities.


Allow custom service domains

Please add support for custom url addresses for services, like an internal GitLab server at https://mygitlab.com.br
  content_panel:
    repo:
      service: gitlab # github or gitlab.
      custom_url: https://mygitlab.com.br
      repo: group/project/subproject
      branch: main

I don't have experience with this, is it same as the GitLab except the hostname (gitlab.com)?

Yes, it's the same structure but starts with another hostname, eg. https://mygitlab.com.br/group/project/subproject/-/blob/main/.gitlab-ci.yml

I see, will refactor this part to be configurable.

You can use the hb.content_panel.repo.service_baseurl to specify the self-hosted GitLab server since https://github.com/hbstack/content-panel/releases/tag/v0.7.0.

Thanks! It's working perfectly.


Test framework for automated config and validation of advanced features on bare-metals

Either using existing iaas_launcher or different python module to automate deployment and test validation of advanced features (like SRIOV, DPDK, MTU setting change, VLAN config, etc.) on bare-metals.

Aricent have the CI script for feature testing for bare-metals, doing more tests.

Base test framework is ready, performing features testing for SRIOV, VLAN, and MTU.

MTU testing done, working on SRIOV, and VLAN testing.

MTU, VLAN, SRIOV test cases done.
DPDK test cases ongoing.
Need to test overall CI/CD.

Test cases are completed for all the advanced features:
MTU, VLAN, SRIOV, DPDK
Overall integration of test cases done and testing is ongoing.
Facing issues while testing DPDK in CI/CD which is a known issue.

Need a PR, documentation, integration with CI, view results.


gohugo.io rss / atom is invalid

HI,
I use the feed  https://github.com/gohugoio/hugo/releases.atom
The generated links are wrong: /gohugoio/hugo/releases/tag/v0.30
this ist not a correct URL.
I'm using JetBrains Omea Reader.

Using a browser works.
The coorect link should be https://github.com/gohugoio/hugo/releases/tag/v0.30

Hey, @gmtju52 I thought we had published the right feed in an autodisovery tag. I'll take care of that. This is the correct public feed (for news, including releases): https://gohugo.io/news/index.xml


Offer: sparc64 Linux build machine

I would like to make a SPARC T3-2 server running Linux available to the AdoptOpenJDK project.
It is large enough to be shared (currently used by GCC Compile Farm project).
@sxa is evaluating the possibility of using this machine for JVM builds and suggested I create a ticket for tracking purposes.

@zv-io is it only running Linux or is there the option to get some Solaris VM's?

At present, it only runs Linux due to what is likely a hardware bug (it can dual-boot Solaris, but only one OS will run at a time). In brief, LDOMs work fine except the network stack crashes after one or two packets are transferred so they're effectively useless. Trust me, we tried.
See also: https://openjdk.java.net/jeps/381. Does this mean SPARC is more, or less, important now?

For now it will continue to be important to us for JDK8. In theory we could build JDK11 too on the right level of Solaris. That JEP refers to later versions so we wouldn't be able to build the next LTS (JDK17) for Solaris or SPARC :-(

I am commenting on behalf of Adélie Linux, who are working on a SPARC port of musl libc and eventually the distro itself. Adélie's goals probably align well enough here to make it worth mentioning that we'd be interested in hosting SPARC hardware for Adoptium (Solaris and/or Linux).
Do you know if any of the member organizations would be interested in supplying hardware or funding for it?

I am commenting on behalf of Adélie Linux, who are working on a SPARC port of musl libc and eventually the distro itself. Adélie's goals probably align well enough here to make it worth mentioning that we'd be interested in hosting SPARC hardware for Adoptium (Solaris and/or Linux).
Do you know if any of the member organizations would be interested in supplying hardware or funding for it?

Hi @zv-io - Do you already have Sparc Hardware that's being hosted or is this a case of offering some Rackspace so to speak?

The only SPARC hardware we have available today is:

The T3-2 (mine personally) but it can only run one OS at a time due to a hardware defect and it needs to run Linux to support the cfarm.
An unknown model Fujitsu in a storage unit somewhere that we could probably dig up, but is unlikely worth the time

Regarding the offer above, Adélie has its own (not mine) rack space and will happily host an additional SPARC machine in exchange for being allowed to test things on it.

The only SPARC hardware we have available today is:

The T3-2 (mine personally) but it can only run one OS at a time due to a hardware defect and it needs to run Linux to support the cfarm.
An unknown model Fujitsu in a storage unit somewhere that we could probably dig up, but is unlikely worth the time

Regarding the offer above, Adélie has its own (not mine) rack space and will happily host an additional SPARC machine in exchange for being allowed to test things on it.

Hi @zv-io - thanks for the kind offer from yourself and Adélie.  We do already have rackspace hosting with a few providers for our Solaris hosts (and are also going to engage a cloud provider.  we'd certainly welcome folks with Solaris / Sparc / Linux expertise on the project.  Our community tends to work out of slack adoptium.net/slack.html and we have a dedicated solaris channel there.

The T3-2 (mine personally) but it can only run one OS at a time due to a hardware defect and it needs to run Linux to support the cfarm.

@zv-io Genuinely curious - what's the hardware defect? I always assumed Solaris and Linux LDoms would always just work side by side.

@sxa

what's the hardware defect? I always assumed Solaris and Linux LDoms would always just work side by side
Essentially with Solaris installed fresh, LDOMs can be created as normal, except the network stack crashes after 1-2 packets are transferred. The primary domain continues to work fine while any others need to be fully stopped and started. It doesn't matter which interface(s) are used, or how the network is configured, but we've had a half dozen people look at it and it seems to be a problem only with this specific system.

And so an LDOM without a reliable network connection is effectively useless. Doesn't matter if it's their "reference" Linux, Debian, Ubuntu, or another instance of Solaris.
@karianna

Our community tends to work out of slack adoptium.net/slack.html and we have a dedicated solaris channel there.
Thanks! I may check it out at some point.

That JEP refers to later versions so we wouldn't be able to build the next LTS (JDK17) for Solaris or SPARC :-(

I cannot comment on Solaris but on Linux SPARC, at least, OpenJDK 15 and 16 still manages to build and run fine in the interpreter-only "Zero" configuration, using GCC 9.
(Building with GCC 8 or 10 causes the resulting JDK to crash with "longjmp causes uninitialized stack frame", sadly)

I'm going to close this. Unfortunately it is unlikely to be practical for us to release on this platform since we would need to be able to run the restricted TCK which is a not insignificant amount of work which the people authorised to do would not be able to take on :-(


HMRC webchat

Add a webchat shim for HMRC’s eGain implementation. This is currently limited to one page: the HMRC self-assessment contact page.

Are there some screens of this in action?

I'm not seeing any JS specs for this. Should we have some test coverage?

@alextea I hadn’t actually realised that, but either way we don’t have a transition-property mixin and I want that as we’ve got so many things we’re transitioning. I guess I could use all as a property but that seems a little heavy handed.

@fofr the short answer: yes. The long answer: because the process relies on there being a human at the other end, end-to-end testing is not possible. We definitely should have some unit tests though.

We have added some tests for what we can independent of the 3rd party service. Attached is an image of the banner, as there is currently no one in the queue to answer the web chat I cannot demonstrate what happens when you click accept (that is in HMRC's control anyway).

I am going to merge this as it needs to be deployed today. I worked with Robin on this and we have reviewed each-others code. I take full responsibility if this breaks anything today in production.

It looks like a hidden iframe is causing problems on all HMRC contact pages.
Try mousing over "deaf" on this page:
https://www.gov.uk/government/organisations/hm-revenue-customs/contact/accessibility-and-specialist-services
Or copying the top email address on this page:
https://www.gov.uk/government/organisations/hm-revenue-customs/contact/air-passenger-duty

I think this is meant to fix this: https://github.com/alphagov/static/pull/671

@fofr @bradwright fix for that in https://github.com/alphagov/static/pull/672


Partial PyPy support

This PR introduces partial support for PyPy. There are still crashing testcases that may point to larger issues.

PyPy seems to have issues with PY_VECTORCALL_ARGUMENTS_OFFSET, it is not able to perform vector calls when given this flag (workaround implemented).

PyPy does not intern keyword names passed to C API vector calls, so a more costly comparison is needed (workaround implemented).

nanobind co-locates binding-specific data with the Python type object. When PyPy subclasses a nanobind class, it does not allocate enough memory to store this additional information, which causes crashes

(Giving up on PyPy for now until remaining Py_LIMITED_API subtleties are all worked out and PyPy has caught up with these APIs.)


Upgrade node image version and switch to Debian

As a result of this, the image size has pratically doubled. I'll keep using alpine linux as the issue I tried to solved with this change wasn't because of it, but will upgrade to Node 14 in another pull-request


will this support presto driver?

Hi, I'm wondering if sqltools will support presto driver recently? or how can I get it work on my own?
I'm new to vscode + sqltools, but i really like it.
Any advice will help, thanks.

hey @kekeadou , depends. Someone needs to implement the driver. I'm not familiar with Presto, so I can't tell you I'ld support it now. Although anyone can implement this following this guide: https://vscode-sqltools.mteixeira.dev/contributing/support-new-drivers
I'll close this issue since I can't support it now, but anyone interested in developing it can reach out to me and I'll provide some assistance.


Bundle Creation Addition

Small changes to bundle creation (similarly to NHC and SNR PRs)

Moving NMO icons to assets directory
Add two new targets for updating and resting the CSV under bundle directory (containerImage, createdAt, and icon fields)
Reset bundle's createdAt field (after updating operator-sdk to v1.26.0 it adds the createdAt field after running make bundle)

/lgtm

Similar problem as it was in #50 for OCP 4.13, thus it irrelevant to the PR changes.
/override ci/prow/4.13-openshift-e2e

/retest


julia> Pkg.add("LinearAlgebra") ERROR: unknown package LinearAlgebra

julia> Pkg.add("LinearAlgebra")
ERROR: unknown package LinearAlgebra

The LinearAlgebra package is part of the Julia standard library so you don't need to install it

I'm closing this as un-related to Gurobi.jl.
If you have other questions, feel free to post them on Discourse: https://discourse.julialang.org/c/domain/opt


Need warnings when less toCSS throws

Because we don't try/catch here: https://github.com/bitovi/steal/blob/master/less.js#L30
if root.toCSS() throws an exception you won't know why. We should wrap this in a try/catch and reject if it throws.

I guess this won't be longer relevant when #335 gets in; root.toCSS is no longer there and the promise will be rejected if less throws. https://github.com/bitovi/steal/pull/335/files#diff-8ecb6318cc46da5624b1b3dcd58358caR36

@matthewp closing this one... closed by #335.


Execution failed for task ':app:runSbg'

Environment

tns info:

✔ Component nativescript has 6.0.3 version and is up to date.
✔ Component tns-core-modules has 6.0.7 version and is up to date.
✔ Component tns-android has 6.0.2 version and is up to date.
✔ Component tns-ios has 6.0.2 version and is up to date.

package.json:

{
  "nativescript": {
    "id": "org.abc.appname",
    "tns-android": {
      "version": "6.0.2"
    },
    "tns-ios": {
      "version": "6.0.2"
    }
  },
  "description": "App description.",
  "license": "SEE LICENSE IN <your-license-filename>",
  "repository": "<fill-your-repository-here>",
  "scripts": {
    "lint": "eslint \"app/**/*.js\""
  },
  "dependencies": {
    "@nstudio/nativescript-loading-indicator": "^1.0.0",
    "@proplugins/nativescript-image-swipe": "^5.0.0",
    "@proplugins/nativescript-themes": "^2.1.0",
    "lodash": "4.17.15",
    "nativescript-barcodescanner": "3.2.2",
    "nativescript-blur": "^2.0.0",
    "nativescript-bottom-navigation": "2.0.1",
    "nativescript-camera": "^4.5.0",
    "nativescript-photoviewer": "^2.1.5",
    "nativescript-sqlite": "2.3.3",
    "nativescript-theme-core": "1.0.6",
    "nativescript-ui-sidedrawer": "7.0.0",
    "nativescript-uuid": "0.0.1",
    "rxjs": "6.5.2",
    "tns-core-modules": "^6.0.6",
    "typescript": "^3.5.1",
    "webpack-bundle-analyzer": "^3.4.1"
  },
  "devDependencies": {
    "data": "^0.6.1",
    "eslint": "6.1.0",
    "nativescript-dev-webpack": "^1.0.3",
    "node-sass": "4.12.0"
  },
  "gitHead": "99999",
  "readme": "NativeScript Application",
  "author": "Author Name"
}

Describe the bug
I was able to build the app successfully for android until {N} latest 5.x version.
Since {N} 6.x android fails but ios works.
The log shows following error:
Execution failed for task ':app:runSbg'.

Process 'command '/Library/Java/JavaVirtualMachines/adoptopenjdk-8.jdk/Contents/Home/bin/java'' finished with non-zero exit value 1

To Reproduce
tns build android --bundle
Additional context
Log output:
Webpack compilation complete.
Built aar for nativescript-blur
Built aar for nativescript-photoviewer
Project successfully prepared (android)
Building project...
Gradle build...
         + setting applicationId
         + applying user-defined configuration from /Volumes/Data MSD/projects/apps/Native-App/DrawerApp/shop-catalog/app/App_Resources/Android/app.gradle
         Applying settings from /Volumes/Data MSD/projects/apps/Native-App/DrawerApp/shop-catalog/app/App_Resources/Android/settings.json
         + using andorid X library androidx.legacy:legacy-support-v4:1.0.0
         + adding nativescript runtime package dependency: nativescript-optimized-with-inspector
         + adding aar plugin dependency: /Volumes/Data<EMAIL_ADDRESS>         + adding aar plugin dependency: /Volumes/Data MSD/projects/apps/Native-App/DrawerApp/shop-catalog/node_modules/nativescript-barcodescanner/platforms/android/barcodescanner-release-2.1.6.aar
         + adding aar plugin dependency: /Volumes/Data MSD/projects/apps/Native-App/DrawerApp/shop-catalog/node_modules/nativescript-barcodescanner/platforms/android/nativescript_barcodescanner.aar
         + adding aar plugin dependency: /Volumes/Data MSD/projects/apps/Native-App/DrawerApp/shop-catalog/node_modules/nativescript-blur/platforms/android/nativescript_blur.aar
         + adding aar plugin dependency: /Volumes/Data MSD/projects/apps/Native-App/DrawerApp/shop-catalog/node_modules/nativescript-camera/platforms/android/nativescript_camera.aar
         + adding aar plugin dependency: /Volumes/Data MSD/projects/apps/Native-App/DrawerApp/shop-catalog/node_modules/nativescript-photoviewer/platforms/android/nativescript_photoviewer.aar
         + adding aar plugin dependency: /Volumes/Data MSD/projects/apps/Native-App/DrawerApp/shop-catalog/node_modules/nativescript-ui-sidedrawer/platforms/android/TNSSideDrawer-release.aar
         + adding aar plugin dependency: /Volumes/Data MSD/projects/apps/Native-App/DrawerApp/shop-catalog/node_modules/nativescript-ui-core/platforms/android/TNSCore-release.aar
         + adding aar plugin dependency: /Volumes/Data MSD/projects/apps/Native-App/DrawerApp/shop-catalog/node_modules/tns-core-modules-widgets/platforms/android/widgets-release.aar
Exception in thread "main" java.lang.RuntimeException: Class not found OnNavigationItemReselectedListener
        at org.nativescript.staticbindinggenerator.Generator.getClass(Generator.java:549)
        at org.nativescript.staticbindinggenerator.Generator.getInterfacesFromCache(Generator.java:532)
        at org.nativescript.staticbindinggenerator.Generator.writeBinding(Generator.java:283)
        at org.nativescript.staticbindinggenerator.Generator.generateBinding(Generator.java:171)
        at org.nativescript.staticbindinggenerator.Generator.processRows(Generator.java:234)
        at org.nativescript.staticbindinggenerator.Generator.generateBindings(Generator.java:121)
        at org.nativescript.staticbindinggenerator.Generator.writeBindings(Generator.java:97)
        at org.nativescript.staticbindinggenerator.Main.main(Main.java:53)

FAILURE: Build failed with an exception.

* What went wrong:
Execution failed for task ':app:runSbg'.
> Process 'command '/Library/Java/JavaVirtualMachines/adoptopenjdk-8.jdk/Contents/Home/bin/java'' finished with non-zero exit value 1

* Try:
Run with --stacktrace option to get the stack trace. Run with --info or --debug option to get more log output. Run with --scan to get full insights.

* Get more help at https://help.gradle.org

BUILD FAILED in 33s
Command ./gradlew failed with exit code 1

Experiencing the same issue. I just upgraded to nativescript 6 from nativescript 5.4.

Hi :) Could you share an app with this error?

Also, could you try updating nativescript-bottom-navigation to 2.0.3?

In my case unfortunately I cannot as it's corporate, not private project. But I followed your suggestion and found that I had to update nativescript-pulltorefresh plugin, as it was deprecated and a new one was created. This fixed the issue for me.
@thd-fox run a search through your project's node_modules folder and search where OnNavigationItemReselectedListener is used. Look at the plugin and update/replace/remove it. This will solve the issue.

@vmutafov and @maxorlovsky Thank you both! the update of nativescript-bottom-navigation to 2.0.3 fixed the execution fail (for me).


Sonos devices; discovered, added then disabled

Hi all, I am using home assistant on the raspberry pi with several components and they work well, but for the life of me I cannot get Sonos devices appearing.
I have 6 Sonos speakers in 3 groups, Home Assistant discovers them in the log and but then straight away disables the Sonos component.
I'm not sure how to debug this further.
15-11-28 09:55:19 homeassistant.components.discovery: Found new service: DLNA http://<IP_ADDRESS>:1400/xml/device_description.xml
15-11-28 09:55:19 homeassistant.components.discovery: Found new service: DLNA http://<IP_ADDRESS>:80/dms/device.xml
15-11-28 09:55:19 homeassistant.components.discovery: Found new service: DLNA http://<IP_ADDRESS>:1400/xml/device_description.xml
15-11-28 09:55:19 homeassistant.components.discovery: Found new service: DLNA http://<IP_ADDRESS>:80/dms/device.xml
15-11-28 09:55:19 homeassistant.components.discovery: Found new service: DLNA http://<IP_ADDRESS>:49153/nmsDescription.xml
15-11-28 09:55:19 homeassistant.components.discovery: Found new service: DLNA http://<IP_ADDRESS>:1400/xml/device_description.xml
15-11-28 09:55:19 homeassistant.components.discovery: Found new service: sonos <IP_ADDRESS>
15-11-28 09:55:19 homeassistant.core: Bus:Handling <Event platform_discovered[L]: discovered=<IP_ADDRESS>, service=sonos>
15-11-28 09:55:19 homeassistant.components.discovery: Found new service: sonos <IP_ADDRESS>
15-11-28 09:55:19 homeassistant.core: Bus:Handling <Event platform_discovered[L]: discovered=<IP_ADDRESS>, service=sonos>
15-11-28 09:55:19 homeassistant.components.discovery: Found new service: sonos <IP_ADDRESS>
15-11-28 09:55:19 homeassistant.core: Bus:Handling <Event platform_discovered[L]: discovered=<IP_ADDRESS>, service=sonos>
15-11-28 09:55:19 homeassistant.components.discovery: Found new service: sonos <IP_ADDRESS>
15-11-28 09:55:19 homeassistant.core: Bus:Handling <Event platform_discovered[L]: discovered=<IP_ADDRESS>, service=sonos>
15-11-28 09:55:19 homeassistant.components.discovery: Found new service: sonos <IP_ADDRESS>
15-11-28 09:55:19 homeassistant.core: Bus:Handling <Event platform_discovered[L]: discovered=<IP_ADDRESS>, service=sonos>
15-11-28 09:55:19 homeassistant.components.discovery: Found new service: sonos <IP_ADDRESS>
15-11-28 09:55:19 homeassistant.core: Bus:Handling <Event platform_discovered[L]: discovered=<IP_ADDRESS>, service=sonos>
15-11-28 09:55:19 homeassistant.components.media_player.sonos: Added 3 Sonos speakers
15-11-28 09:55:19 homeassistant.components.media_player.sonos: Added 3 Sonos speakers
15-11-28 09:55:20 homeassistant.components.media_player.sonos: No Sonos speakers found. Disabling: homeassistant.components.media_player.sonos
15-11-28 09:55:20 homeassistant.components.media_player.sonos: No Sonos speakers found. Disabling: homeassistant.components.media_player.sonos
15-11-28 09:55:20 homeassistant.components.media_player.sonos: No Sonos speakers found. Disabling: homeassistant.components.media_player.sonos
15-11-28 09:55:20 homeassistant.components.media_player.sonos: No Sonos speakers found. Disabling: homeassistant.components.media_player.sonos
15-11-28 09:55:20 homeassistant.components.media_player: Updating media_player entities

I've seen the same thing happening on  similar setup with 4 Sonos devices.
Multiple threads discover the devices but 1/5 fails. Strangely enough more devices are discovered than there's devices on the network.
Will try to get a copy of the log asap I've got access to the system again.

I wouldn't worry too much about the warning that things are being disabled. Looks like we're too eager in printing those messages:
When the sonos component is loaded based on one of its devices being discovered, it should only setup the discovered device. Instead, it is doing another full discovery of Sonos devices. If too many discoveries are done in quick succession (6 times in your case!) the Sonos devices will stop responding which results in our Sonos platform printing that it is disabled.
Looking at your logs, it does find 6 devices and those should show up in the UI.

Hi balloob thanks for your message it solved my issue, ended up being I was just confused.
The sonos components were actually appearing with chromecast type icons and I just assumed that they were been picked up via the cast component (like if you try and cast from the google play music app sonos devices appear with cast icons) and the fact I was seeing "No Sonos speakers found. Disabling" lead me to believe the sonos component was not working as it should and something else for the sonos devices would appear in the frontend.
Also don't know if this also contributed to me been confused but my android tv, plex and sonos were all named "Living Room" so would/or tried to appear as "media_player.living_room". I have now given all the devices a unique name and everything is working as it should.
Thanks again for you help :)


YJDH-433 | KS-Backend: Optimize YouthApplication querying

Description :sparkles:
YouthApplication:

Add indexes to fields:

created_at -> faster unexpired()/expired() querying
email
receipt_confirmed_at -> faster active() querying
social_security_number

Adding indexes to the email and social_security_number fields should
optimize matches_email_or_social_security_number querying as
PostgreSQL should combine the separate indexes for email and
social_security_number when querying with their OR combination.

See "Combining Multiple Indexes" in PostgreSQL documentation:
https://www.postgresql.org/docs/12/indexes-bitmap-scans.html

YouthApplicationQuerySet:

Remove _annotate_existence_duration as unnecessary
Simplify _unexpired_q_filter, now it can use created_at index

Issues :bug:
YJDH-433
Testing :alembic:
Screenshots :camera_flash:
Additional notes :spiral_notepad:

Codecov Report

Merging #702 (c92dc27) into develop (92bf80b) will increase coverage by 31.20%.
The diff coverage is 100.00%.

@@             Coverage Diff              @@
##           develop     #702       +/-   ##
============================================
+ Coverage    63.71%   94.91%   +31.20%
============================================
  Files          759      110      -649
  Lines        19027     3796    -15231
  Branches      1816        0     -1816
============================================
- Hits         12123     3603     -8520
+ Misses        6547      193     -6354
+ Partials       357        0      -357

Impacted Files
Coverage Δ

.../migrations/0023_index_youth_application_fields.py
100.00% <100.00%> (ø)

backend/kesaseteli/applications/models.py
98.28% <100.00%> (-0.01%)
:arrow_down:

...nd/shared/shared/service_bus/service_bus_client.py
33.33% <0.00%> (-57.58%)
:arrow_down:

backend/shared/shared/yrtti/yrtti_client.py
37.50% <0.00%> (-53.13%)
:arrow_down:

...plications/applicationList/listItem/ListItem.sc.ts

...ator/migrations/0003_changes_for_calculator_api.py

.../applications/migrations/0021_allow_blank_batch.py

...d/kesaseteli/youth/src/pages/already_activated.tsx

...ents/applicationReview/consentView/ConsentView.tsx

...browser-tests/application-page/step2.components.ts

... and 644 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 92bf80b...c92dc27. Read the comment docs.


Documentation for OPS error tracing

Documentation added -
https://github.com/podaac/swodlr/wiki/User-Request-Error-Tracing-in-Production-Environments

@ymchenjpl doc is ready.

@viviant100 @joshgarde  Good start on the doc.  Here are my suggestions:

Is there are way to add the user's Product_ID number to each of the different log group events ?  When I look at the each Cloudwatch log group, I only see the Request ID numbers, and when I expand the details, I don't see the user's Product_ID which makes it very hard to troubleshoot.
Under the Request section, please add the API URL and example of curl command
Under the Response section, please add example of a fully completed Product_ID so we can see all the stages it goes through.
For ERROR status, what are the corrective actions ?
If a user asks about a Product_ID which was started a week ago, the CloudWatch log groups will have many new logs since then, so what is best way to find the old Product_ID and where it got stuck?   Would the Kibana metrics dashboard be another way to troubleshoot?

@ymchenjpl

Is there are way to add the user's Product_ID number to each of the different log group events ? When I look at the each Cloudwatch log group, I only see the Request ID numbers, and when I expand the details, I don't see the user's Product_ID which makes it very hard to troubleshoot.

Yes, any action which is taken as a result of a user request contains a product_id prefix on the logs. The only time that field isn't added is during initialization when a user's request hasn't been started yet. Example + explanation added - https://github.com/podaac/swodlr/wiki/User-Request-Error-Tracing-in-Production-Environments#example-log-entry

https://github.com/podaac/swodlr/wiki/User-Request-Error-Tracing-in-Production-Environments#example-log-entry

SWODLR probably isn't the easiest to query via CURL because it's GraphQL driven. Maybe an example using Postman/Insomnia might be better? The API URL is also probably better suited for somewhere else in the docs.

Under the Response section, please add example of a fully completed Product_ID so we can see all the stages it goes through.

The product id provided as an example is a currently completed job in the UAT environment, but it's not guaranteed to be always there as we reset/update that UAT environment. It also won't appear in the OPS/SIT environments.

For ERROR status, what are the corrective actions ?

Depends on the error. In the description, I noted that ERRORs that result from SDS issues aren't correctable from the SWODLR system perspective. The actions from there will need to be to alert the dev team and then the SDS team to look into what occurred.
An error occurred during product generation; the user should be given some basic information about this error.
If the error was caused by the SDS, no further tracing can be performed on the SWODLR end of the system.

If a user asks about a Product_ID which was started a week ago, the CloudWatch log groups will have many new logs since then, so what is best way to find the old Product_ID and where it got stuck? Would the Kibana metrics dashboard be another way to troubleshoot?

The section on the page that goes into timestamping should help sort through where to start tracing those types of cases. The basic idea is to grab SWODLR's status logs and their timestamps, then use the timestamps to figure out what timestamps to filter through in the log groups - https://github.com/podaac/swodlr/wiki/User-Request-Error-Tracing-in-Production-Environments#efficiently-tracing-errors

Also, how do we find the details for a user, and what requests they have submitted? Ok, I see the example in the Getting Started page.

Yeah, that's a future feature we're planning to implement this PI. We need to add in administrator commands to allow that type of search. For now, the user should be able to get that information from the UI.
Hope this answered some of the concerns


dart2js: get rid of 'holders'

Types that are not instantiated but are used in type tests have 'holders'.
Instead of holders, the type should be generated. The generated type will be really small since it has no methods.
The interceptors should be used for primitive types.

@rakudrama The comments containing TODOs refering to this bug seem to be completely out of sync - for example, there is no emitRuntimeTypeSupport anymore. I would like to close this issue and file a new one for the problem mentioned in your last comment (if that still is a problem).


White screen when load uchiwa

Please,
move the directory of bower_componets  from /opt/uchiwa/src/bower_components to /opt/uchiwa/src/public/bower_components
tks
joao

Hi @jcmartins
Did you installed Uchiwa 0.5.0 from the packages? If so, I recommend you to downgrade to 0.4.0 until new packages are available (we found an issue within the uchiwa-build cookbook that provoked this exact problem, which has just been fixed).
Sorry for the inconvenient.

0.5.1 packages are now available. Thank you for reporting this issue.


Add category input

Follow up to https://github.com/github/codeql-action/pull/446
This PR introduces a new action input for both the analyze and upload actions for further configurability. The category is only applied as a substitute for the default analysis_key/environment, and it won't be applied if the sarif already contains an automation id.
Merge / deployment checklist

[x] Confirm this change is backwards compatible with existing workflows.
[x] Confirm the readme has been updated if necessary.

Upcoming versions of codeql database analyze will support the --category flag directly and put it into the SARIF. Should we look for that mechanism when it is supported? cc @aeisenberg

Should this be updating the runner too? My understanding of this work was it's to allow parallel builds on 3rd party CI/CD, which means people using the runner and the external /sarifs endpoint.

Should this be updating the runner too? My understanding of this work was it's to allow parallel builds on 3rd party CI/CD, which means people using the runner and the external /sarifs endpoint.

That makes sense, thanks!

I run a test and this worked, it populated the category on the sarif https://github.com/dsp-testing/daverlo-main-flow/actions/runs/816024707
I'm going to hold off this PR a bit more, as I needed to specify tools: latest in order to succeed, as the default was still picking up v2.5.2 20210421 https://github.com/dsp-testing/daverlo-main-flow/actions/runs/816011280


Keep improving merge bash script

We are working on a shell/bash script that helps with safe merging between development/main branches.
We will also need this for handling changes with staging/preview branches.
Creating a ticket to keep this going, it's more an infrastructure feature than project work.
https://github.com/cagov/drought.ca.gov/issues/167

I'm going to close this one.
Since we opened this Issue, it's been my experience that one script rarely fits all scenarios. Yet, our current scripts are a great starting point for most tasks. I recommend we keep this practice going, without the goal of creating one script to rule them all.


[E2E Test Failure] Getting data source of all items by title fails

Test: QueryTests > SimpleDataSource
GET .../tables/Movies?$orderBy=Title desc&$top=1000
<<< 200 OK

It should return 248 items with Yojimbo being the first title.
It actually returns 50 items.

Fixed in #187


Explanatory no results in Workflow A.1

https://arax.ncats.io/?source=ARS&id=7e23ddd1-ab6a-46c3-a67e-86f0ebff196b
ROHBTB2-entity_neg_reg_entity-Gene

{
  "description": "No knowledge provider supports query.",
  "logs": [],
  "message": {
    "knowledge_graph": {
      "edges": {},
      "nodes": {}
    },
    "query_graph": {
      "edges": {
        "e01": {
          "object": "n0",
          "predicates": [
            "biolink:entity_negatively_regulates_entity"
          ],
          "subject": "n1"
        }
      },
      "nodes": {
        "n0": {
          "categories": [
            "biolink:Gene"
          ],
          "ids": [
            "NCBIGene:23221"
          ]
        },
        "n1": {
          "categories": [
            "biolink:Gene"
          ]
        }
      }
    },
    "results": []
  },
  "status": "Unsupported",
  "validation_result": {
    "message": "",
    "n_edges": 0,
    "n_nodes": 0,
    "size": "1 kB",
    "status": "PASS",
    "version": "1.1.1"
  }
}

Explanatory Agent currently doesn't support the predicate "biolink:entity_negatively_regulates_entity". We are in the process of a major design update and would be able to answer these queries post-implementation (expected by September Relay).

Check in mid august

https://arax.ncats.io/?source=ARS&id=58b7d225-8e9b-453e-9f8b-3ebe640eaaca


mednaffe: 0.8.8 -> 0.9.0

Automatic update generated by nixpkgs-update tools. This update was made based on information from https://github.com/AmatCoder/mednaffe/releases.
meta.description for mednaffe is: "GTK-based frontend for mednafen emulator"
meta.homepage for mednaffe is: "https://github.com/AmatCoder/mednaffe"
meta.changelog for mednaffe is: ""
Updates performed

Version update

To inspect upstream changes

Release on GitHub

Compare changes on GitHub

Impact

Checks done (click to expand)

built on NixOS

The tests defined in passthru.tests, if any, passed

0 of 0 passed binary check by having a zero exit code.

0 of 0 passed binary check by having the new version present in output.

found 0.9.0 with grep in /nix/store/a67pm0przdc02q1hjzz00kxdmh1cww64-mednaffe-0.9.0

directory tree listing: https://gist.github.com/f0c6a8537bb30f7749fcf55a9bfffdbb

du listing: https://gist.github.com/f9751fa9ace5ba437cf74fe00ac78fdf

Rebuild report (if merged into master) (click to expand)

3 total rebuild path(s)

1 package rebuild(s)

1 x86_64-linux rebuild(s)
1 i686-linux rebuild(s)
0 x86_64-darwin rebuild(s)
1 aarch64-linux rebuild(s)

First fifty rebuilds by attrpath
mednaffe

Instructions to test this update (click to expand)

Either download from Cachix:
nix-store -r /nix/store/a67pm0przdc02q1hjzz00kxdmh1cww64-mednaffe-0.9.0 \
  --option binary-caches 'https://cache.nixos.org/ https://nix-community.cachix.org/' \
  --option trusted-public-keys '
  nix-community.cachix.org-1:mB9FSh9qf2dCimDSUo8Zy7bkq5CX+/rkCWyvRCYg3Fs=
  cache.nixos.org-1:6NCHdD59X431o0gWypbMrAURkbJ16ZPMQFGspcDShjY=
  '

(The Cachix cache is only trusted for this store-path realization.)
For the Cachix download to work, your user must be in the trusted-users list or you can use sudo since root is effectively trusted.
Or, build yourself:
nix-build -A mednaffe https://github.com/r-ryantm/nixpkgs/archive/866d0ae4e7cf45bfdd074e7759cb6aa99095312e.tar.gz

After you've downloaded or built it, look at the files and if there are any, run the binaries:
ls -la /nix/store/a67pm0przdc02q1hjzz00kxdmh1cww64-mednaffe-0.9.0
ls -la /nix/store/a67pm0przdc02q1hjzz00kxdmh1cww64-mednaffe-0.9.0/bin

Pre-merge build results
We have automatically built all packages that will get rebuilt due to
this change.
This gives evidence on whether the upgrade will break dependent packages.
Note sometimes packages show up as failed to build independent of the
change, simply because they are already broken on the target branch.
Result of nixpkgs-review run on x86_64-linux 1

1 package built:

mednaffe

Maintainer pings
cc @sheenobu @yegortimoshenko @AndersonTorres for testing.

YEHOO! LGTBorg, LGTM.

YEHOO! LGTBorg, LGTM.


Patient and Staff classes that extend the user class.

Patient and Staff Class. In the patient class upcoming appointments list and other methods are commented out because I wasn't sure if we were using specific methods like add and remove appointments.

I think I saw these in PR 8, is this just to separate them?

Too many changes have been made in #8 that would lead to this being an extremely unsafe merge.

commits combined with #8, this Branch is no longer needed


All versions and deletes change feed mode - preview feature activation

I'm looking to try this feature. I've enabled Continuous 30 day backup and I requested the Preview feature on the Azure Subscription. How long does it typically take for the feature activation to be approved? I've been waiting for over a week so far.

@jcocchi ?


Add composed device model storage and everest device model storage.

Describe your changes
Created composed device model storage and everest device model storage like stated in https://github.com/EVerest/everest-core/tree/doc/config-service/doc/config_service#next-steps-to-adjust-ocpp201-and-libocpp
Issue ticket number and link
#844
Checklist before requesting a review

[x] I have performed a self-review of my code
[ ] I have made corresponding changes to the documentation
[x] I read the contribution documentation and made sure that my changes meet its requirements

This looks good!
I would like to see at least some parts of this documented here as part of the OCPP201 module documentation:
* Class diagram + explaination

* Variable attributes and variable characteristics for externally managed variables

* Sequence of variable access for internally and externally managed variables

ok, in doc.rst? Or where else?

This looks good!
I would like to see at least some parts of this documented here as part of the OCPP201 module documentation:
* Class diagram + explaination

* Variable attributes and variable characteristics for externally managed variables

* Sequence of variable access for internally and externally managed variables

ok, in doc.rst? Or where else?

Yep :+1:

This looks good!
I would like to see at least some parts of this documented here as part of the OCPP201 module documentation:
* Class diagram + explaination

* Variable attributes and variable characteristics for externally managed variables

* Sequence of variable access for internally and externally managed variables

ok, in doc.rst? Or where else?

Yep 👍

Ok, added!

Is there still a change requested?

:+1:
please merge https://github.com/EVerest/libocpp/pull/768 and update the dependencies.yaml in this PR afterwards


update installation and update instructions

Imo the current example how to install and update hugo-academic could be simplified.
The submodule approach does not have the option to view the changelog as the old approach did but users can do that now from your update posts in a better way anyways :)

@pat-s thanks for the suggestion! I'll consider this more at the weekend. We'll need to update other parts of the docs too if we make this change to the Readme. The main drawback to using submodules is that less users will be familiar with the concept (compared to clone) as it's a bit more advanced.
Also, you can still view the Git commit history (changelog) if you cd into the submodule after it's been setup and initiated.

Also, you can still view the Git commit history (changelog) if you cd into the submodule after it's been setup and initiated

Thanks for the heads-up, was not aware of it!
Its up to you :) I'll do it this way for quite some time now - just thought it would be easier for others as well. In the end its of course your decision whats suggested in the README - I won't be mad if you keep it as it is :+1:

@pat-s thanks again for your feedback!
The default installation now uses submodules and the documentation website has been updated appropriately - see https://sourcethemes.com/academic/docs/install/ and https://sourcethemes.com/academic/docs/update/
The update instructions in the README will be updated to match the docs website in due course.

@gcushen great, glad that it inspired you to use this approach in the future :+1:


Contributed: What is an Ontology

Please revise your example in the article to use data from the KGC 2020 or KGC 2021 .ttls.

Done


Fix missing test badge

This PR creates a master workflow for the unit and integration tests, which dispatches the to separate unit and integration test runs.

format!


Automatic load

Hi, and thank you for this great plugin :clap:
I would love require('coverage').load() to be automatically called when opening a file, have the coverage signs automatically loaded, and the coverage file automatically reloaded on changes.
This could probably be done with some LUA scripting, but a more generic approach could be to add a auto_load configuration option to load coverage data if needed on file opening. Maybe an additional auto_toggle option would be nice to display the signs automatically too?
What do you think?

I believe all of what you're asking for is already possible using something like:
require("coverage").setup({
  auto_reload = true,  -- automatically reload coverage file on changes
})

-- automatically load the coverage signs when opening a file
vim.api.nvim_create_autocmd({"BufEnter"}, {
  pattern = {"*.py"}, -- any file extension you're interested in
  callback = function()
    -- place (show) the signs immediately after loading
    require("coverage").load(true)
  end,
})


game running very slowly

map is taking a LOT of time to print, it's a bother to even move.
it may be caused by the init_colors(), not sure.
attron() may also reduce the framerate since the windows console is not optimal

seems like deleting the attron's functions fixed the whole issue

many calls to wattron are to heavy for the CMD. will find a proper solution later - for now, added a boolean to use (or not) colors when printing the cells.
it'll be used later with main(args)

for the non-colored version:
we could before printing get the whole line already formatted, and print it at once. it would then avoid doing unnecessary steps (for each, having a addch()).

(to stay open for a while)
for the color version, we could create as many str as there is different noise values. see screenshot:

the highlighted ;;;;;;;;;;; is ONE str on which we apply a wattron
that way, it would considerably reduce the wattron function call


ConEmu Settings

Can you please update your Gist with your current shell settings for the dark them that you are using in oh-my-posh?  Maybe even include that xml in the package.
thanks!

Done and updated the README :shipit:

thanks!


HDDS-5724. Add RaftpeerId when getting scm roles

What changes were proposed in this pull request?
Add RaftpeerId for the shell command " ozone admin scm roles"
In the current scm log files, some of the raft related logs lack explicit Addresses, so it is hard to distinguish the SCM nodes from the abstract UUID.  We can add the RaftPeerId into the command -> ozone admin scm roles, which can help find the SCM node mentioned in logs.
What is the link to the Apache JIRA
https://issues.apache.org/jira/browse/HDDS-5724
Please replace this section with the link to the Apache JIRA)
How was this patch tested?
CI

@ChenSammi , Pls take a look

LGTM, can we do similar change for OM also?

OM uses OmNodeId as RaftPeerID, such as "om1" "om2" "om3 ", while SCM use scmUUID as RaftPeerID, and thus the log trace could be confusing for finding the right SCM node.
Right  now the OM side will print NodeId, i am wandering the followings:

should we unifiy the RaftPeerId usage for OM and SCM ? (obviously UUID is better for indicating the physical node)
after that we could unify the pattern the getting om/scm roles  return

LGTM, can we do similar change for OM also?

@bharatviswa504
OM uses OmNodeId as RaftPeerID, such as "om1" "om2" "om3 ", while SCM use scmUUID as RaftPeerID, and thus the log trace could be confusing for finding the right SCM node.
Right now the OM side will print NodeId.
I am wondering the followings:

should we unifiy the RaftPeerId usage for OM and SCM ? (obviously UUID is better for indicating the physical node)
after that we could unify the pattern the getting om/scm roles  return

You are right, I missed that we use node id as raft peer id in OM, and which is now already shown..
Lets not go the route of peerID unification, as if we want to do we need to consider fresh/old installation.
Where in fresh installations we can generate UUIDS, and old we should we should have as it is.

Thank You @Xushaohong  for the contribution and @JacksonYao287 for the review

LGTM, can we do similar change for OM also?

@bharatviswa504
OM uses OmNodeId as RaftPeerID, such as "om1" "om2" "om3 ", while SCM use scmUUID as RaftPeerID, and thus the log trace could be confusing for finding the right SCM node.
Right now the OM side will print NodeId.
I am wondering the followings:

should we unifiy the RaftPeerId usage for OM and SCM ? (obviously UUID is better for indicating the physical node)
after that we could unify the pattern the getting om/scm roles  return

You are right, I missed that we use node id as raft peer id in OM, and which is now already shown..
Lets not go the route of peerID unification, as if we want to do we need to consider fresh/old installation.
Where in fresh installations we can generate UUIDS, and old we should we should have as it is.

Do you mean that the unification needs some concern about compatibility? Because someone may have already set up the cluster.
Actually what I concern about is what if om nodes vary, such as from ABC to ABD, the corresponding log only shows abstract node name instead of specific UUID pointing to the specific node. This is the disadvantage.


add patches to virt-controller

What this PR does / why we need it:

Adds the CustomizeComponents field to the KubeVirt CR
Allows for optional Patches to be specified

This PR will allow users to customize the virt-controller, virt-handler, virt-api, and all other resources that are created by the virt-operator.
We need this to allow users to be able to customize the way kubevirt is ran in each of their environments. This gives users the power to specify where components can be scheduled, customizing flags and other use cases. If a user defines an invalid patch the operator will fail to deploy.
This current draft PR only adds this logic for the virt-controller. An example KubeVirt CR is as follows:
---
apiVersion: kubevirt.io/v1alpha3
kind: KubeVirt
metadata:
  name: kubevirt
  namespace: kubevirt
spec:
  certificateRotateStrategy: {}
  configuration: {}
  customizeComponents:
    patches:
    - resourceType: Deployment
      resourceName: virt-controller
      patch: '[{"op": "remove", "path": "/spec/template/spec/containers/0/livenessProbe"}]'
      type: json
    - resourceType: Deployment
      resourecName: virt-controller
      patch: '{"metadata":{"annotations":{"patch": "true"}}}'
      type: strategic
  imagePullPolicy: IfNotPresent

Which issue(s) this PR fixes:
Fixes #3365
Special notes for your reviewer:

How do we feel able the name customizeComponents? I also ended up using the name ComponentsCustomization in the config struct. I think these two should be consistent, but would like opinions on what naming makes more sense?

Is there any reason to continue passing individual arguments to functions such as NewControllerDeployment instead of passing the who config object?

Release note:
Adds `customizeComponents` to the kubevirt api

@davidvossel @rmohr  does this approach look correct to implement for all components?

Don't want to creep in additional features, but I wonder if this would be applicable to virt-launchers as well? As we would like to add a sidecart with the libvirt_exporter (https://github.com/kumina/libvirt_exporter/), for example.

Don't want to creep in additional features, but I wonder if this would be applicable to virt-launchers as well? As we would like to add a sidecart with the libvirt_exporter (https://github.com/kumina/libvirt_exporter/), for example.

Independent if that makes sense (probably does): We are exposing metrics for all VMIs through virt-handler, in case you are not aware of it. Let us know if you are missing something there. Have a look at https://kubevirt.io/user-guide/#/installation/monitoring?id=monitoring-kubevirt-components

So for example, if someone installs kubevirt, then mutates the kubevirt spec to include a patch, how does our controller know to roll out that change. Right now it's only keying off image name/registry.

It gets updated from this function since the correct install strategy will no longer exist
https://github.com/kubevirt/kubevirt/pull/3612/files#diff-bd81c399ded8070883a8f861d513f5e8R442

what happens (or should happen) if someone modifies the KubeVirt CR with a patch after install? It looks like we might ignore those changes today until the KubeVirt version is updated, then the patches would kick in?

To make everything react fast and easy to grasp I am still for doing the patches always when we load the install strategy and always just dump the plain shipped install strategy. That makes is absolutely clear and understandable what will happen: If patches are provided in the CR they are applied, if they are not there they are not. Of course that can be done by dumping the proper install strategy over and over, but it is mentally much more difficult to grasp and no questions like this will arise: If I roll back to the previous version which had patches and I don't provide the patches, will it still have them? You simply always get what we release + your patches on the CR. No exception.

One additional note, after we merge the subresource PR, the generation metadata field will only be bumped on the kubevirt cr, if the spec changes. Like on e.g. Deployments I would suggest to add the generation as a metadata annotation to all our artifacts. This will make it pretty easy to detect changes then.

Of course that can be done by dumping the proper install strategy over and over, but it is mentally much more difficult to grasp and no questions like this will arise: If I roll back to the previous version which had patches and I don't provide the patches, will it still have them? You simply always get what we release + your patches on the CR. No exception.

We talked about this out of band, and it makes sense. I hit a snag in my thought process later on in the day though
In this model you're outlining where patches are applied after the install strategy is generated, how do we detect whether patches need to apply to an object? Do we need to do a deep equals on all the cached object's specs to see if the (cached spec == (install strategy spec + patches))?
I avoided doing the deep equals of specs in the operator logic because some of the controllers mutate default spec fields. We even do this in the VMI API. For example with a VMI, if some fields aren't set our mutation webhook will set them by default when the VMI is posted. If we tried to compare our original spec to the one persisted in etcd, they would have differences.
I like your idea here, but I'm unsure how we know when to apply patches and when not to. We shouldn't unconditionally apply patches each time the reconcile loop pops.
thoughts?

@davidvossel did you see my suggestion with the generation field? That is how Native controllers detect the need to rollout changes without deep equal checks.

@davidvossel did you see my suggestion with the generation field? That is how Native controllers detect the need to rollout changes without deep equal checks.

For deployments for instance, are you referring to the pod-template-hash? something like pod-template-hash: 7c6b4f5448?
We don't really have to have your status change to do something like this. We'd just  need to hash the kubevirt spec and add that as an annotation or label to every object we create. Right?

For deployments for instance, are you referring to the pod-template-hash? something like pod-template-hash: 7c6b4f5448?

Yes, the combination of metadata.generation, status.observedGeneration and controller-revision-hash: 5bddc49df8. We can then add annotations like kubevirt-generation on our resources.
stretch goal: Finally our controller can then thanks to these fields make use of the ControllerRevision object, which would open up more possibilities regarding to nice rollbacks.

This is a really powerful tool, I am wondering if there are circumstances where I could gain abilities I didn't previously have through it.
As an example, I assume it's possible to create a JSON patch such that instead of creating the kubevirt resource, I'll create my own choice of privileged pod.
Do we expect that anyone who can edit the kubevirt CR can also create whatever resources they want in the cluster?

This is a really powerful tool, I am wondering if there are circumstances where I could gain abilities I didn't previously have through it.
As an example, I assume it's possible to create a JSON patch such that instead of creating the kubevirt resource, I'll create my own choice of privileged pod.
Do we expect that anyone who can edit the kubevirt CR can also create whatever resources they want in the cluster?

Yes. This is the assumption. We don't expect that someone would give a third person just the capability to just modify the kubevirt CR but no other rights on the install namespace. With that assumption anyone who can edit this CR has all right anyway, at least implicitly since we have the super-privileged virt-operator serviceaccount in that namespace.

As an example, I assume it's possible to create a JSON patch such that instead of creating the kubevirt resource, I'll create my own choice of privileged pod.

There is one additional restriction (more to help people not making mistakes, less to prevent the scenario described above): One can only patch objects which we create. The patches are applied to resources managed by kubevirt directly in virt-operator. Objects which are not managed by virt-operator can't be patched.

I have updated the patches to be applied on create instead of being applied to the install strategy and saved to the config map. I then updated the logic for when to deploy to add a generation annotation to the objects and to check if that matches the current kubevirt generation. https://github.com/kubevirt/kubevirt/pull/3612/files#diff-d5561d66dec277d1e552dd8ac98e1cfcR70
I only updated the "sync" logic for deployments to test. When testing I then realized that every object that we manage will be updated everytime the kubevirt cr is updated. So if a user changes some configuration value, or the ca certification configuration, etc, all objects will also be updated even though nothing about their deployments should chance.
I think I'm misunderstanding the proposed solution for using generation? Or as @davidvossel mentioned maybe adding a hash of the spec.CustomizeComponents to each object we manage would be a way to avoid unneeded updates to the components?

I only updated the "sync" logic for deployments to test. When testing I then realized that every object that we manage will be updated everytime the kubevirt cr is updated. So if a user changes some configuration value, or the ca certification configuration, etc, all objects will also be updated even though nothing about their deployments should chance.

We can discuss if that would still be good enough. I don't expect that this will happen too often. Further Deployments and DaemonSets use hashes already. So it would be pretty much a no-op. They should not roll out new pods due to this if the patches content did not change.

I think I'm misunderstanding the proposed solution for using generation? Or as @davidvossel mentioned maybe adding a hash of the spec.CustomizeComponents to each object we manage would be a way to avoid unneeded updates to the components?

Yes, the hash in addition to generation would be the cleanest solution. I would however still expect to see a generation bump on the components metadata. I am not 100% sure if we need that right now.

We can discuss if that would still be good enough. I don't expect that this will happen too often. Further Deployments and DaemonSets use hashes already. So it would be pretty much a no-op. They should not roll out new pods due to this if the patches content did not change.

If at minimum the annotation for the generation will change every time this will then roll out new pods, unless we only add the annotation to the top level "deployment" and do not have the generation injected into the spec.template.metadata.annotation

If at minimum the annotation for the generation will change every time this will then roll out new pods, unless we only add the annotation to the top level "deployment" and do not have the generation injected into the spec.template.metadata.annotation

That is a good point. We should probably not inject it there.

The generation number has been added as an annotation to the top level objectmeta.
The hash of the customizeComponents has been added to the top level annotation, as well as the pod level.

If the CR is updated the generation will always get updated for each object, when the customizeComponents section changes it will update all components (since the generation will again change) but the hash will also change so all new pods will also be rolled out. The patches are applied during the syncing process, and not saved to the install strategy as previously discussed.
I still need to add more unit tests as well as add a new functional test.

The generation number has been added as an annotation to the top level objectmeta.
The hash of the customizeComponents has been added to the top level annotation, as well as the pod level.

Why do we need item 2 here? Is there a reason we need to force pod rollouts? shouldn't pod rollouts naturally occur if the patch mutates something in the pod template of a deployment without us needing to be involved?

Why do we need item 2 here? Is there a reason we need to force pod rollouts? shouldn't pod rollouts naturally occur if the patch mutates something in the pod template of a deployment without us needing to be involved?

Yes, the pod rollouts will naturally occur if that patch changes something in their spec. My thought was that if a patch changes something that is not a pod (configmap, secret, etc) we would still needs the pods to restart to pick up those changes.

Yes, the pod rollouts will naturally occur if that patch changes something in their spec. My thought was that if a patch changes something that is not a pod (configmap, secret, etc) we would still needs the pods to restart to pick up those changes.

I am not aware of anything where we would not pick up these changes at this stage. The only things which come to my mind are certificates and config changes. Both should be dynamically picked up at this stage.

/retest

/test pull-kubevirt-goveralls

/restest

/lgtm cancel
It is broken now, due to another patch going in first.
The PR seems to introduce new api violations (they are now checked).

It is broken now, due to another patch going in first.
The PR seems to introduce new api violations (they are now checked).

run make generate to see what the violation is. It should be pretty easy. It's usually just that the variable name in a struct doesn't match the json name.
So for example, this works
MyValue string `json:"myValue"`
And this causes a faliure.
MySuperValue string `json:"myValue"`
You might need to add the
+listType=[set|atomic|map] sort of thing to lists as well if it complains about listType

/retest

/retest

/retest

@ashleyschuett I think you need to re-run make generate.  It might be worth rebasing during the process as well.

/lgtm

/retest


Adding in a well received resource organizer for Research

In comparison to the other options, Zotero is one of the most recommended resources to use for being free and accessible.

Thanks for adding!


Linux Segmentation fault - Running on either runtime:2.2 or runtime:3.0 Docker image

This issue tracker is for documentation
For product issues, use https://github.com/aspnet/EntityFramework/issues
I have followed the "Spatial Data - EF Core" instructions to the letter, and the example works perfectly on Windows. When running on an "mcr.microsoft.com/dotnet/core/runtime:2.2" Docker image (or 3.0), which has also had:
RUN apt-get update
RUN apt-get --yes --force-yes install libsqlite3-mod-spatialite

Added in the Dockerfile I get:
Info Infrastructure: Entity Framework Core 2.2.6-servicing-10079 initialized 'AbCoreDbContext' using provider 'Microsoft.EntityFrameworkCore.Sqlite' with options: MigrationsHistoryTable=os.migrations LoadSpatialite using NetTopologySuite
Info Command: Executed DbCommand (32ms) [Parameters=[], CommandType='Text', CommandTimeout='30']
PRAGMA foreign_keys=ON;
./entrypoint.sh: line 2:     8 Segmentation fault      dotnet CounterApp.dll

The version of libsqlite3-mod-spatialite that gets installed by apt-get is:
lrwxrwxrwx  1 root root       23 Feb  5  2016 mod_spatialite.so -> mod_spatialite.so.7.1.0
lrwxrwxrwx  1 root root       23 Feb  5  2016 mod_spatialite.so.7 -> mod_spatialite.so.7.1.0
-rw-r--r--  1 root root  5879944 Feb  5  2016 mod_spatialite.so.7.1.0
in the folder:
/usr/lib/x86_64-linux-gnu
Any ideas? I need to be able to generate a SpatiaLite database on a Linux Docker instance.

Wrong place


p2p: add back disable dht option

Motivation
p2p option disable-dht was removed by mistake

bors merge


add spar cap width/angle based blade structure component

the blade structure parameterisation is now generalized and there's no method to specify the chordwise position of the spar cap, its angle relative to the rotor plane and width. a component that either simply computes these properties which could then be used for constraints is one option, another option is to have these quantities available as design variables.

Related to this, create a setup method for defining the blade structure from scratch which at present is not so easy. the method should add necessary regions and webs:
setup_bladestructure(nr=11, nw=3)

and placement of region boundaries should be based on the chordwise fraction, since the surface fraction is not intuitive.
for placement of the spar cap, the user should be able to specify e.g. maximum thickness location or chordwise fraction as well as angle.


Checked-In examples/ctapcli/target Directory Makes Repo Quite Large

There's a target directory checked in under examples/ctapcli/target. This makes a checkout ~228MB. You might want to consider rewriting history to remove that directory, as just git rm'ing it will leave the objects reachable from history.

Yes, sorry. That's what I meant by rewrite history. There's a GitHub article that might be helpful: https://docs.github.com/en/authentication/keeping-your-account-and-data-secure/removing-sensitive-data-from-a-repository#purging-a-file-from-your-repositorys-history. It's aimed at sensitive data but the process is the same.

Deleted examples/ctapcli/target
This reduced the size to about 130M when I checked out.
:smile:

@gkelly Thanks for the advice!
:laughing:


html-webpack-plugin has a warn that does not meet expectations.

System Info
System:
OS: macOS 14.0
CPU: (10) arm64 Apple M2 Pro
Memory: 71.67 MB / 32.00 GB
Shell: 5.9 - /bin/zsh
Binaries:
Node: 18.12.1 - ~/Library/Caches/fnm_multishells/64416_1698647082843/bin/node
npm: 8.19.2 - ~/Library/Caches/fnm_multishells/64416_1698647082843/bin/npm
pnpm: 8.1.0 - ~/Library/Caches/fnm_multishells/64416_1698647082843/bin/pnpm
Browsers:
Chrome: 118.0.5993.117
Safari: 17.0
npmPackages:
@rspack/cli: 0.3.7 => 0.3.7
@rspack/core: 0.3.7 => 0.3.7
@rspack/dev-server: 0.3.7 => 0.3.7
Details
https://github.com/sheinsight/rspack-demo-contenthash/tree/html-plugin-warn

Reproduce link
https://github.com/sheinsight/rspack-demo-contenthash/tree/html-plugin-warn
Reproduce Steps

pnpm install
pnpm run build

same as #https://github.com/web-infra-dev/rspack/issues/4467


Add Url and Method to HttpClient Error log

Add url and method to the error log in HttpClient when the request fails without a response.
The log entry after the changes will look like this,
020-12-22T18:27:42.564Z - error: HTTP request failed: Nock: Disallowed net connect for "x.x.x.x:xxxx/v1/info"
{
  "message": "Nock: Disallowed net connect for \"x.x.x.x:xxxx//v1/info\"",
  "name": "NetConnectNotAllowedError",
  "config": {
    "url": "http://x.x.x.x:xxxx/v1/info",
    "method": "get"
  },
  "stack": "Some stack trace"
  "code": "ENETUNREACH"
}

Bug: NGPBUG-137177

Pull Request Test Coverage Report for Build 4947

0 of 0   changed or added relevant lines in 0 files are covered.
1 unchanged line in 1 file lost coverage.
Overall coverage remained the same at 89.135%

Files with Coverage Reduction
New Missed Lines
%

core/utils/src/HttpClient.js
1
87.11%

Totals

Change from base Build 4868:
0.0%

Covered Lines:
9406

Relevant Lines:
10181

💛  - Coveralls

Pull Request Test Coverage Report for Build 4947

0 of 0   changed or added relevant lines in 0 files are covered.
1 unchanged line in 1 file lost coverage.
Overall coverage remained the same at 89.135%

Files with Coverage Reduction
New Missed Lines
%

core/utils/src/HttpClient.js
1
87.11%

Totals

Change from base Build 4868:
0.0%

Covered Lines:
9406

Relevant Lines:
10181

💛  - Coveralls


 If for whatever reason, on one of the RabbitMQ, the exchange doesn't exist, logstash crashes with the following vague message (in my case, I called the exchange 'logstash'):
{:timestamp=>"2015-11-04T13:18:12.208000-0700", :message=>"The error reported is: \n  NOT_FOUND - no exchange 'logstash' in vhost '/'"}

If it's any useful, here is the config:
input {
        # Some info
        rabbitmq {
                queue => "logstash_queue"
                host => "<IP_ADDRESS>"
                exchange => "logstash"
        }
}

Logstash shouldn't crash due to that issue. It should keep trying (like when it fails to connect to it).
I don't remember having this issue on 1.5.X.
System info:

Ubuntu 14.04.3 LTS 64 bit
Logstash 2.0.0 from Elastic repositories.
RabbitMQ from Ubuntu repositories (the system on which they run is also using Ubuntu 14.04.3 LTS 64 bit).

Thanks for reporting this @ThomasdOtreppe ! I'll take a look sometime this week

Any updates on this?

Any update? This is a pretty serious bug.

What do you mean by "crashes", does the entire JVM process terminate?

Yes.

@ThomasdOtreppe I'll try and take a look tomorrow.
@michaelklishin your thoughts? Should we be handling this differently at the Logstash level?

@andrewvc declare things that do not exist?

@andrewvc a good behaving amqp client should declare missing exchanges, queues and bindings and that's what the logstash rabbitmq input also should do.
I also ran into this issue
Besides that, the "exchange_type" parameter seems to be optional, whilst for the output plugin it is an obligatory parameter. Not a huge problem as such, but both input & output rabbitmq plugins should have the same behavior in this regard.

@andrewvc Have you had a chance to test?

@smetj @ThomasdOtreppe thanks for your input, I have a patch up here: https://github.com/logstash-plugins/logstash-input-rabbitmq/issues/48
I'm hoping to merge it and release it soon.

@smetj @ThomasdOtreppe correction, the patch is here: https://github.com/logstash-plugins/logstash-input-rabbitmq/pull/72


(4.1.0) InnertubeError: Something went wrong at PlayerCaptionsTracklist!

Steps to reproduce
i'm using getBasicInfo function with ANDROID client. no idea which videos in particular cause this error to occur, it seems to happen once in a while without ties to any specific video.
code snippet:
import { Innertube } from 'youtubei.js';
const yt = await Innertube.create();

try {
    info = await yt.getBasicInfo('video id here', 'ANDROID');
} catch (e) {
    console.log(e);
}

Failure Logs
InnertubeError: Something went wrong at PlayerCaptionsTracklist!
This is a bug, please report it at https://github.com/LuanRT/YouTube.js/issues
    at Parser._Parser_printError (node_modules/youtubei.js/dist/src/parser/parser.js:405:18)
    at Parser.parseItem (node_modules/youtubei.js/dist/src/parser/parser.js:242:77)
    at Parser.parseResponse (node_modules/youtubei.js/dist/src/parser/parser.js:185:31)
    at new MediaInfo (node_modules/youtubei.js/dist/src/core/MediaInfo.js:34:29)
    at new VideoInfo (node_modules/youtubei.js/dist/src/parser/youtube/VideoInfo.js:53:9)
    at Innertube.<anonymous> (node_modules/youtubei.js/dist/src/Innertube.js:111:20)
    at Generator.next (<anonymous>)
    at fulfilled (node_modules/youtubei.js/dist/src/Innertube.js:4:58)
    at process.processTicksAndRejections (node:internal/process/task_queues:95:5) {
  info: {
    stack: "TypeError: Cannot read properties of undefined (reading 'map')\n" +
      '    at new PlayerCaptionsTracklist (node_modules/youtubei.js/dist/src/parser/classes/PlayerCaptionsTracklist.js:23:64)\n' +
      '    at Parser.parseItem (node_modules/youtubei.js/dist/src/parser/parser.js:237:32)\n' +
      '    at Parser.parseResponse (node_modules/youtubei.js/dist/src/parser/parser.js:185:31)\n' +
      '    at new MediaInfo (node_modules/youtubei.js/dist/src/core/MediaInfo.js:34:29)\n' +
      '    at new VideoInfo (node_modules/youtubei.js/dist/src/parser/youtube/VideoInfo.js:53:9)\n' +
      '    at Innertube.<anonymous> (node_modules/youtubei.js/dist/src/Innertube.js:111:20)\n' +
      '    at Generator.next (<anonymous>)\n' +
      '    at fulfilled (node_modules/youtubei.js/dist/src/Innertube.js:4:58)\n' +
      '    at process.processTicksAndRejections (node:internal/process/task_queues:95:5)'
  },
  date: 2023-03-26T01:24:42.567Z,
  version: '4.1.0'
}

Expected behavior
i expect getBasicInfo to either handle such errors by itself, or emit an error event for me to handle it
Current behavior
getBasicInfo crashes the entire project by throwing an uncatchable error :(
Version
Default
Anything else?
No response
Checklist

[X] I am running the latest version.
[X] I checked the documentation and found no answer.
[X] I have searched the existing issues and made sure this is not a duplicate.
[X] I have provided sufficient information.

getBasicInfo crashes the entire project by throwing an uncatchable error :(

Are you sure this throws an error? These parser warnings are not supposed to crash your program. The only thing that should be affected is the PlayerCaptionsTracklist node, unless you rely on data this node holds somewhere else in your code. You should still get most of the data (try logging the info object and remove the try-catch to verify this), but the captions prop will be null.
Relevant bits of code:
https://github.com/LuanRT/YouTube.js/blob/ade5feb31cae5115527204dc8171d0a00c7617e1/src/parser/youtube/VideoInfo.ts#L44
https://github.com/LuanRT/YouTube.js/blob/ade5feb31cae5115527204dc8171d0a00c7617e1/src/parser/youtube/VideoInfo.ts#L96
https://github.com/LuanRT/YouTube.js/blob/ade5feb31cae5115527204dc8171d0a00c7617e1/src/parser/parser.ts#L471
Anyway, thanks for reporting! I'll look into fixing it this week.


Take into account max onion blob size when pathfinding

Currently pathfinding for QueryRoutes and SendPayment assumes a fix hop limit of 20 hops. This is no longer true now that there is the variable-size tlv payload.
With a variable payload it is possible to have more than 20 hops. But the maximum number of hops could also be less, for example when a large custom field is delivered to one of the hops.
Pathfinding needs to take the onion payload size into account.
Possibly we also need the option to pass in an external 'reserve' size, to allow for applications that use the QueryRoutes result and append additional hops. This is typically done for rebalancing channels (send to self).

Fixed #3841.


Update CHANGELOG.md

NOTE: Please read the CONTRIBUTING.md guidelines before submitting your patch,
and ensure you followed them all:
https://github.com/Kong/kong/blob/master/CONTRIBUTING.md#contributing
Summary
Minor grammer errors.
Full changelog
Issues resolved
Fix #XXX

 Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

@parth818 Thank you for taking the time to submit a PR, but the wording change is not needed.


No Option to View Password While Typing

Description
Currently, there is no option to view the password while typing in the password field, making it difficult for users to verify what they have entered. Adding a "Show Password" toggle will allow users to view their password as they type, improving usability.
Steps to Reproduce

Navigate to the password input field.
Start typing a password.
Notice there is no option to reveal the password while typing.

Expected Behavior

A "Show Password" toggle (e.g., an eye icon) should be added next to the password field. When clicked, it should allow the user to see the password in plain text.
Clicking the toggle again should revert the password back to hidden.

Possible Solution

Implement a toggle button or icon (such as an eye icon) next to the password field that toggles between showing and hiding the password by changing the input field type from password to text.

Screenshot

Additional Context
By adding this feature, users will have the option to verify their passwords easily, reducing the chance of mistakes and improving the overall user experience.

Dear @ANSHIKA-26  ,
I hope you're doing well. I would like to request this project assignment to contribute to. I'm eager to get involved and apply my skills to make a meaningful impact.
Looking forward to your response.
Best regards,
Aryan Gaur

issue resolved already @aryangaur380


WIP: add option to upgrade pip/setuptools inside venv

Fixes https://github.com/tox-dev/tox-venv/issues/17
This PR adds a --upgrade-venv command line option as well as a upgrade_venv config (boolean) option, that is false by default. When True, the pip and setuptools inside the test venvs are upgraded to the currently available version on PyPI.
This is to make the behavior of the environments created via tox-venv more similar to the default ones created with virtualenv, where the default behavior is to always install the latest pip and setuptools (and wheel), unless --no-dowload option is passed.
I haven't written a specific test yet because I first would like to gather some feedback that this is the way to do it, as I've never written a tox plugin myself and am not familiar with tox API.

BTW, the CI will fail for unrelated reasons as reported in #22 (the tests need to be updated for the latest tox 3.1.2)

This PR would still be subject to #24.
Alternatively, consider #25, which re-uses the tried-and-true functionality from virtualenv to install whatever versions of pip and setuptools and wheel come with virtualenv.

Thanks again @anthrotype for opening this. I'm closing in favor of #25.


Is MySQL supported with line graphs?

Hey, absolutely loving Motor, it's exactly what I was looking for. But I'm having a bit of trouble with graphs.
This could be my tenuous grasp on MySQL showing, but it seems like line graphs aren't working for MySQL queries, and I'm not sure why.
Here's a simple enough query
SELECT
    DATE(users.created_at) AS date,
    COUNT(users.id) AS counter
FROM users
GROUP BY date
ORDER BY date DESC;

However when I go to graph it as a line graph (or anything other than table or value) it just displays an empty graph

Rails version: 6.1.1 - Api Only app
Motor-admin version: 0.2.10
Am I missing something or doing something stupid? It's entirely possible.

@jonnyom thanks for reporting this bug - it has been fixed in the newest version!
https://rubygems.org/gems/motor-admin/versions/0.2.12


Add async calls to (Azure) OpenAI

Current Invoke does not allow for async calls to OpenAI api.
This is a blocker for adoption where non blocking use is needed (or unelegant hacks needs to be added on top).
The proposal is to add an ainvoke interfase, that works with the same inputs and resolves to the same outputs.

Good call - I need to do that.

Hi @sethjuarez, I see that it is already implemented in promptflow.core
In fact all Prompty implementation is more complete there. (Escaping, handling of tools in parser, streaming, token count)
Is there a plan to unify the base parsing?

Tool handling, streaming, and token count already work in prompty (if it reports tokens of course). I do agree that I need to add async invokers. Give me a couple of days to get it in (some folks are also working on json_schema enhancements).


Update UI in open in CircuitVerse page for LTI assignments

First checkout to the lms-lti branch and run CircuitVerse locally and check app/views/lti/open_incv.html.erb
currently the view look like below

Expected Feature
You need to update the view according the below

The page should automatically redirect to the group link in 2-3 seconds
Reference Code
https://github.com/CircuitVerse/CircuitVerse/blob/261533d00b386dc7721636561c5f91d42384543a/app/views/lti/open_incv.html.erb#L1
Note

Please make PR against lms-lti branch
Please comment below if you are starting work on this issue

I want to work on this issue.!

I want to work on this issue.!

yah go ahead 🎉

Can I work on this issue?

Can I work on this issue?

I think @vedant-jain03 is working? Please ask him once before starting

Ok

@vedant-jain03 are you working on this right now?

@vedant-jain03 are you working on this right now?

Yes I am working on it!

Closing via #2373


Add the notion of global pipeline properties

When building pipelines, there are configurations that are duplicated in multiple nodes. We should introduce the notion of global pipeline configuration that is then propagated to all nodes (e.g. a common token, a common data path, etc).
The user UI could be similar to the node properties but in the context of the pipeline.

The main concept was introduced in #1708 and there are specific issues to address the specific propagation of properties throughout nodes.


PyTorch models

Hi,
It seems that support for PyTorch models is currently limited to bert and xlm. Would it be possible to add support for lighter models, e.g. DistilBERT or ALBERT?
Do you think that using these models would hurt the performance of the scorers significantly?
Thanks!

Thanks for the suggestion! I updated to Transformers 3.3.1 and added DistilBERT & ALBERT. The main thing is defining an *BERTForMaskedLMOptimized class for speed. You can follow my example to add support for other MLMs. Pull requests welcome 🙂.
I also ran the two on BLiMP. Though ALBERT improves on downstream tasks like GLUE over RoBERTa, its BLiMP scoring is on par with BERT. Likewise, DistilBERT does similar to BERT on GLUE, but is much worse on BLiMP (78% vs 84%).
Possible takeaways:

DistilBERT's KD objective and taking alternate layers has an effect. Quantifier and island effects performance degrades significantly (maybe the knowledge was encoded in the offset layers? maybe probabilities are now too soft?).
Having pre-training match evaluation is likely more important. We saw this with LibriSpeech in our paper. Here, ALBERT and BERT are trained on the same corpus, while RoBERTa is trained on a larger corpus that may cover BLiMP better.

# distilbert-base-cased
anaphor_agreement:  0.983
argument_structure:  0.7857777777777778
binding:  0.7335714285714285
control_raising:  0.7788
determiner:  0.970375
ellipsis:  0.915
filler_gap:  0.7464285714285716
irregular_forms:  0.9555
island_effects:  0.54925
npi_licensing:  0.7901428571428571
quantifiers:  0.5895
subject_verb_agreement:  0.8965000000000001
overall:  0.782955223880597

# albert-xxlarge-v2
anaphor_agreement:  0.956
argument_structure:  0.8375555555555555
binding:  0.7912857142857143
control_raising:  0.865
determiner:  0.9395
ellipsis:  0.8735
filler_gap:  0.8188571428571427
irregular_forms:  0.9255
island_effects:  0.74975
npi_licensing:  0.9115714285714285
quantifiers:  0.6739999999999999
subject_verb_agreement:  0.8808333333333334
overall:  0.8435820895522389

Grand job, thanks a lot!

Hi,
I'm extending the framework to include another PyTorch model. When using MLMScorerPT we don't need to pass a vocab, do we? I couldn't find any function where it is actually used..
Thank you!
PS: Very cool work :)

Hi,
I'm extending the framework to include another PyTorch model. When using MLMScorerPT we don't need to pass a vocab, do we? I couldn't find any function where it is actually used..
Thank you!
PS: Very cool work :)


WIP: Test all settings values round-trip cleanly to_json and back

Important for being able to safely modify settings through the REST API.
https://github.com/ManageIQ/manageiq/issues/17201
https://bugzilla.redhat.com/show_bug.cgi?id=1558031
Currently fails on several regexps and symbols.  Diff listed here: https://github.com/ManageIQ/manageiq/issues/17201#issuecomment-385925194
@miq-bot add-label test
cc @Fryguy

This may be worth moving to manageiq-api where we could also test actual read then write via API.
But first let's see if we can fix the problematic settings...

I recall our discussion in #17201, and I'm still good with removing as much as possible, but the regexes are going to have to stay (maybe we can round-trip them as Strings?


[BUG]

WARNING: Github Issues are publicly visible, do not post sensitive information here.
You may want to check "Hide sensitive information" before taking screenshots or copying logs.

Describe the bug
A clear and concise description of what the bug is.
To Reproduce
Steps to reproduce the behavior:

Go to '...'
Click on '....'
Scroll down to '....'
See error

Screenshots / Logs
If applicable, add screenshots and or copy log to help explain your problem.
Paste logs here
```Error deleting message, API responded with status 403!	{"message":"Cannot execute action on a DM channel","code":50003}

**Affects** (Add an X to items that apply)
- [x ] DMs
- [ ] DM Groups
- [ ] Channel
- [ ] Channel (NSFW)
- [ ] Server (All Channels)
- [Can't delete friends messages at dm channel ] Other (explain)

**System:**
 - OS: [e.g. Windows 10]
 - Browser [chrome]

It is not possible to delete the other person's message in a DM channel.
This is a discord restriction and can't be circumvented in any other way.


Use GraphQL for NRQL conditions.

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.


[Pornhub] Give better error for geo-restriction than Unable to extract title

DO NOT REMOVE OR SKIP THE ISSUE TEMPLATE

[X] I understand that I will be blocked if I intentionally remove or skip any mandatory* field

Checklist

[X] I'm reporting that yt-dlp is broken on a supported site
[X] I've verified that I have updated yt-dlp to nightly or master (update instructions)
[X] I've checked that all provided URLs are playable in a browser with the same IP and same login details
[X] I've checked that all URLs and arguments with special characters are properly quoted or escaped
[X] I've searched known issues and the bugtracker for similar issues including closed ones. DO NOT post duplicates
[X] I've read the guidelines for opening an issue
[X] I've read about sharing account credentials and I'm willing to share it if required

Region
Canada
Provide a description that is worded well enough to be understood
Parsing the title fails on each run. The issue occurs for all videos on Pornhub, using both stable and nightly builds. Same result with or without quotes around the URL. The issue has been occurring for several days, and I've had no problems downloading from other sites.
The common locations for the title look fine in the DOM:
<title>Wild College Orgy: three Hot Babes get Naughty with Students at Dorm Party - Pornhub.com</title>
and
<meta name="twitter:title" content="Wild College Orgy: Three Hot Babes Get Naughty with Students at Dorm Party">
This issue seems similar to #7527 (Closed in Jul 2023)
Provide verbose output that clearly demonstrates the problem

[X] Run your yt-dlp command with -vU flag added (yt-dlp -vU <your command line>)
[X] If using API, add 'verbose': True to YoutubeDL params instead
[X] Copy the WHOLE output (starting with [debug] Command-line config) and insert it below

Complete Verbose Output
╰─○ yt-dlp -vU "https://www.pornhub.com/view_video.php?viewkey=66266bc7d9ef2"

[debug] Command-line config: ['-vU', 'https://www.pornhub.com/view_video.php?viewkey=66266bc7d9ef2']
[debug] Encodings: locale UTF-8, fs utf-8, pref UTF-8, out utf-8, error utf-8, screen utf-8
[debug] yt-dlp version<EMAIL_ADDRESS>from yt-dlp/yt-dlp-nightly-builds [6b54cccdc] (zip)
[debug] Python 3.12.3 (CPython x86_64 64bit) - Linux-6.8.0-31-generic-x86_64-with-glibc2.39 (OpenSSL 3.0.13 30 Jan 2024, glibc 2.39)
[debug] exe versions: none
[debug] Optional libraries: certifi-2023.11.17, requests-2.31.0, sqlite3-3.45.1, urllib3-2.0.7
[debug] Proxy map: {}
[debug] Request Handlers: urllib, requests
[debug] Loaded 1810 extractors
[debug] Fetching release info: https://api.github.com/repos/yt-dlp/yt-dlp-nightly-builds/releases/latest
Latest version<EMAIL_ADDRESS>from yt-dlp/yt-dlp-nightly-builds
yt-dlp is up to date<EMAIL_ADDRESS>from yt-dlp/yt-dlp-nightly-builds)
[PornHub] Extracting URL: https://www.pornhub.com/view_video.php?viewkey=66266bc7d9ef2
[PornHub] 66266bc7d9ef2: Downloading pc webpage
ERROR: [PornHub] 66266bc7d9ef2: Unable to extract title; please report this issue on  https://github.com/yt-dlp/yt-dlp/issues?q= , filling out the appropriate issue template. Confirm you are on the latest version using  yt-dlp -U
  File "/home/deepblue/.local/bin/yt-dlp/yt_dlp/extractor/common.py", line 734, in extract
    ie_result = self._real_extract(url)
                ^^^^^^^^^^^^^^^^^^^^^^^
  File "/home/deepblue/.local/bin/yt-dlp/yt_dlp/extractor/pornhub.py", line 306, in _real_extract
    'twitter:title', webpage, default=None) or self._html_search_regex(
                                               ^^^^^^^^^^^^^^^^^^^^^^^^
  File "/home/deepblue/.local/bin/yt-dlp/yt_dlp/extractor/common.py", line 1357, in _html_search_regex
    res = self._search_regex(pattern, string, name, default, fatal, flags, group)
          ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/home/deepblue/.local/bin/yt-dlp/yt_dlp/extractor/common.py", line 1321, in _search_regex
    raise RegexNotFoundError('Unable to extract %s' % _name)

I've been doing further debugging using --write-pages and --print-traffic and have identified the cause. Documenting here in case others have similar issues.
Aylo (formerly MindGeek) is blocking access to their sites, including PornHub, in the US States of Utah, Virginia, Texas, Montana, Mississippi, Arkansas and North Carolina in response to recently enacted age-verification laws in those states. In my case, my desktop and my server are in different locations, so the site was only blocked on my server.
yt-dlp supported sites affected:

Pornhub
Thumbzilla
Tube8
YouPorn
RedTube

if we intend on fixing this someone with an IP address in one of the impacted US states will need to share a page dump of the blocked page

Sure. I've attached a basic "Save Page as..." HTML file for the geo-blocked Pornhub page in my initial issue here: Pornhub.zip (accessed from Texas). I can provide more info if needed (Full curl trace, debug headers, HTML from each of the 7 geo blocked states, and/or from all of the 5 supported Aylo websites that have geo-block restrictions, etc.). I'm happy to help debug or provide whatever info is helpful.
The page contents are quite clear regarding geo-blocking.

Pornhub.zip

@ClearBlueOcean could you add --write-pages to the command you used in the OP and share the .dump file

Dump file attached.
Uploading 66266bc7d9ef2_https_-_www.pornhub.com_view_video.phpviewkey=66266bc7d9ef2.zip…

Or if easier: my repository

diff --git a/yt_dlp/extractor/pornhub.py b/yt_dlp/extractor/pornhub.py
index d94f28ceb..97e2260d9 100644
--- a/yt_dlp/extractor/pornhub.py
+++ b/yt_dlp/extractor/pornhub.py
@@ -294,6 +294,11 @@ def dl_webpage(platform):
                 'PornHub said: %s' % error_msg,
                 expected=True, video_id=video_id)

+        if age_verify_msg := self._search_regex(
+                r'(your elected officials in \w+ are requiring us to verify your age before allowing you access to our website)',
+                webpage, 'age verification message', default=None):
+            self.raise_geo_restricted(f'PornHub said: {age_verify_msg}')
+
         if any(re.search(p, webpage) for p in (
                 r'class=["\']geoBlocked["\']',
                 r'>\s*This content is unavailable in your country'))

(ahem) North Carolina ? Maybe r'\w+(?:\s+\w+){,2}' ?

I have the same problem.

Anyone is free to open a PR with the above patch. Minimal effort required

I encountered the same issue (located in Europe), because of the age verification prompt.
Workaround:

Open the website in a browser.
Validate the age verification prompt.
With yt-dlp, use the --cookies-from-browser ... option with the corresponding browser.

I recommend Firefox, to avoid troubles with the locked cookies (which require to close the browser), and now the encrypted cookies (#10927)…


support manual recording of investments

Two buttons added viz. add and delete investments
Bot stats shows profit considering start balance and
additional investments

Hey @ullasbharadwaj , thanks for your work!
Unfortunately, I don't think this PR is ready to be merged without some rework. Here is the remarks that I have:

The explanation text is not easily readable and in one paragraph
Its formatting is not consistent. If no investment is logged, then the explanation text is displayed as a block of code. Else, it is written in bold.
Why deleting investment if I enter 0 and also add a button delete investment? Just choose one in order to KISS
If I add an investment and already one existed, then the previous one is deleted.

Btw, i keep thinking that it is totally doable to do an automated investment detection, because I don't think this functionnality would be used so much if it is not automatic.