Including all the features in a tf-idf transformation of a Tribuo's example

Hello,
I am facing a problem while using Tribuo for a tf-idf transformation use case.
My use case
I would like to use Tribuo to create an tf-idf transformer that transforms a phrase into a vector.
My problem
I would like every sentence to be projected into the space represented by the whole set of features (a vector containing a value for each word of my vocabulary for example). For example, if I train my transformer with the sentences "Hello I am John" and "Hello I am William", my set of features (my vocabulary) is : "HELLO", "I", "AM", "JOHN", "WILLIAM". When I transform a dataset containing these two sentences, it works (both sentences yield vectors in the space represented by the whole set of features).
But when I transform an example (even if I densify the example after the transformation), it does not include the features that are not present in the example itself in its representation. For instance, if I transform the example created from the sentence “Hello I am Charles”, the result is a vector in the space composed of the features "HELLO", "I", "AM”, “Charles” but "JOHN" and "WILLIAM” are missing. When I call the isDense method on this densified example, it returns false (and an investigation made me see that this comes from the fact that my example size is smaller than the features size despite the densification that I apply).
I added a code sample below to illustrate this problem and all the facts that I mention above. Please, does anyone see what I am doing wrong there?
Thank you in advance.
Victor
Code sample
import org.tribuo.Example;
import org.tribuo.MutableDataset;
import org.tribuo.classification.Label;
import org.tribuo.classification.LabelFactory;
import org.tribuo.data.columnar.FieldProcessor;
import org.tribuo.data.columnar.RowProcessor;
import org.tribuo.data.columnar.processors.field.TextFieldProcessor;
import org.tribuo.data.columnar.processors.response.FieldResponseProcessor;
import org.tribuo.data.text.impl.TokenPipeline;
import org.tribuo.datasource.ListDataSource;
import org.tribuo.transform.TransformationMap;
import org.tribuo.transform.TransformerMap;
import org.tribuo.transform.transformations.IDFTransformation;
import org.tribuo.util.tokens.impl.WhitespaceTokenizer;

import java.util.*;
import java.util.stream.Collectors;

public class TribuoTest {
    private static final String ATTRIBUTE_NAME = "PHRASE";

    public static void main(String[] args) {
        // create a row processor to create tribuo examples
        RowProcessor<Label> rowProcessor = createRowProcessor();

        // create data
        List<String> data = Arrays.asList(
                "Hello I am John",
                "Hello I am William"
        );
        List<Example<Label>> dataExamples = createExampleList(rowProcessor, data);
        MutableDataset<Label> dataset = createDataset(dataExamples);

        // create an IDF transformer
        TransformerMap transformer = createTransformer(dataset);

        // dataset tranformation
        MutableDataset<Label> tranformedDataset = transformer.transformDataset(dataset);
        System.out.println(tranformedDataset.getData());
        //[ArrayExample(numFeatures=4,output=HELLO I AM JOHN,weight=1.0,features=[(PHRASE@1-N=Hello, 0.0)(PHRASE@1-N=I, 0.0), (PHRASE@1-N=John, 0.6931471805599453), (PHRASE@1-N=am, 0.0), ]), ArrayExample(numFeatures=4,output=HELLO I AM WILLIAM,weight=1.0,features=[(PHRASE@1-N=Hello, 0.0)(PHRASE@1-N=I, 0.0), (PHRASE@1-N=William, 0.6931471805599453), (PHRASE@1-N=am, 0.0), ])]
        tranformedDataset.densify();
        System.out.println(tranformedDataset.getData());
        //[ArrayExample(numFeatures=5,output=HELLO I AM JOHN,weight=1.0,features=[(PHRASE@1-N=Hello, 0.0)(PHRASE@1-N=I, 0.0), (PHRASE@1-N=John, 0.6931471805599453), (PHRASE@1-N=William, 0.0), (PHRASE@1-N=am, 0.0), ]), ArrayExample(numFeatures=5,output=HELLO I AM WILLIAM,weight=1.0,features=[(PHRASE@1-N=Hello, 0.0)(PHRASE@1-N=I, 0.0), (PHRASE@1-N=John, 0.0), (PHRASE@1-N=William, 0.6931471805599453), (PHRASE@1-N=am, 0.0), ])]
        System.out.println(tranformedDataset.getFeatureMap().keySet());
        //[PHRASE@1-N=John, PHRASE@1-N=am, PHRASE@1-N=Hello, PHRASE@1-N=I, PHRASE@1-N=William]

        // tribuo example tranformation
        String phrase = "Hello I am Charles";
        Example<Label> example = createExample(rowProcessor, phrase);
        Example<Label> transformedExample = transformer.transformExample(example);
        System.out.println(transformedExample);
        //ArrayExample(numFeatures=4,output=HELLO I AM CHARLES,weight=1.0,features=[(PHRASE@1-N=Charles, 1.0)(PHRASE@1-N=Hello, 0.0), (PHRASE@1-N=I, 0.0), (PHRASE@1-N=am, 0.0), ])
        transformedExample.densify(dataset.getFeatureMap());
        System.out.println(transformedExample);
        //ArrayExample(numFeatures=4,output=HELLO I AM CHARLES,weight=1.0,features=[(PHRASE@1-N=Charles, 1.0)(PHRASE@1-N=Hello, 0.0), (PHRASE@1-N=I, 0.0), (PHRASE@1-N=am, 0.0), ])
        System.out.println(transformedExample.isDense(dataset.getFeatureMap()));
        //false
    }

    private static RowProcessor<Label> createRowProcessor() {
        Map<String, FieldProcessor> fieldProcessors = Collections.singletonMap(
                ATTRIBUTE_NAME,
                new TextFieldProcessor(
                        ATTRIBUTE_NAME,
                        new TokenPipeline(new WhitespaceTokenizer(), 1, false)
                )
        );
        return new RowProcessor<>(
                new FieldResponseProcessor<>(
                        ATTRIBUTE_NAME,
                        "",
                        new LabelFactory()
                ),
                fieldProcessors
        );
    }

    private static MutableDataset<Label> createDataset(List<Example<Label>> exampleList) {
        return new MutableDataset<>(
                new ListDataSource<>(exampleList, new LabelFactory(), null)
        );
    }

    private static List<Example<Label>> createExampleList(RowProcessor<Label> rowProcessor, List<String> data) {
        return data.stream().map(d -> createExample(rowProcessor, d)).collect(Collectors.toList());
    }

    private static Example<Label> createExample(RowProcessor<Label> rowProcessor, String data) {
        Optional<Example<Label>> exampleOptional = rowProcessor.generateExample(
                Collections.singletonMap(
                        ATTRIBUTE_NAME,
                        data
                ),
                false);
        if (exampleOptional.isEmpty()) {
            throw new RuntimeException("Tribuo's example generation did not succeed");
        }
        return exampleOptional.get();
    }

    private static TransformerMap createTransformer(MutableDataset<Label> dataset) {
        TransformationMap transformationMap = new TransformationMap(Collections.singletonList(new IDFTransformation()));
        return dataset.createTransformers(transformationMap, true);
    }
}

I think you're hitting a bug/misspecification in how densify works, because we expect that the feature map you supply contains all the features that the example contains, plus all the other features you wish to make dense. However we don't verify that this is true, so the logic gets all confused.
If you make another dataset that contains all three examples, then use the feature map from that for the densify calls, then things behave as expected.
We'll have a think how best to fix this, I'm not sure if modifying the contract for densify so it adds all the features in the example into the list first is better, or if it should throw an exception and have updated documentation explicitly specifying the contract. It may even be both, where Example.densify(FeatureMap) adds extra features, and Example.densify(List<String>) throws an exception if the example contains features not present in the list.

Hello,
Thank you very much for your answer. For information, I’ve juste tried to do what you suggested and it worked.
Regarding the possible ways to fix it that you mentioned, it would be better to add example features in densification in my opinion.
Another interesting way could be to create another method (or to update the densify one) taking a list of features as argument and that creates an example with the listed features and ignore / remove the ones that are not in this list. In that case you are sure that the example has the same features as the dataset you used to fit the vectoriser (which is a recurrent need according to me when one wants to compare an example to the dataset to measure distances for example).

I think on reflection we're going to modify densify so that it adds the blank features whatever, though that will require a more complicated rewrite of the internals of the densify methods (and it might be a little slower).
For your use case of measuring distances between examples then I'd recommend using org.tribuo.math.la.SparseVector.createSparseVector(Example<T>, ImmutableFeatureMap, boolean) and/or org.tribuo.math.la.DenseVector.createDenseVector(Example<T>, ImmutableFeatureMap, boolean) which will build a vector, inserting zeros as appropriate. The SGDVector interface exposes several distance calculations (euclidean/l2, manhattan/l1, cosine), and it should be possible to construct more of them by iterating the vectors if we don't have the one you need.
I'm not sure what treatment you want of the features that are present in an example but not in the dataset/feature map, but in Tribuo pretty much all the methods will ignore features not present in the feature map and they won't contribute to the output.


Tax calculation needs to be implemented

The function for tax calculation for all players with a house in the current round has not yet been created. A first implementation is needed.

Tax calculations have been implemented (including late calculation), and seem to work correct:


Version 1.3.0 is not downloadable with Cocoapods

It looks like the new podspec wasn't pushed to the trunk via pod trunk push.

Thanks for letting us know, Kaan. Should be fixed now 👍


add Fedora 37 support

No changes in repositories in Fedora 37 release

No f37 aio packages yet and, oddly, there are aio packages for f36 but not f35.  https://yum.puppetlabs.com/


Files (JS/CSS) are already compressed but YSlow still grades as "F" and lists all files that are minified

Using Adobe CQ's built-in gzip that compresses/minifies all JS and CSS. However, YSlow still gives a grade of "F" for these files. It even says that googleanalytics.js is a "plain text component that should be sent compressed", but it is already compressed by Google.

I also had this. +1


How to delete files uploaded to server?

Question
I want to delete files uploaded to server example /files/1213-123-12312-2312 (uuid)
Setup details
Please provide following details, if applicable to your situation:

Linux
Used tusd version: 2.4.0
Used tusd data storage: disk store
Used tusd configuration: what req should i send?
Used tus client library:  tus-js-client

Send a DELETE request to the upload URL: https://tus.io/protocols/resumable-upload#termination


Implement Homepage Content Updates

Problem statement
Content improvements for the homepage were identified in #11940 based on user testing. They need to be implemented on the homepage.
What you need to know

These updates are from ticket #11940 - see Audrey for more information
Content Update Doc

Acceptance criteria

[ ] Implement Content Updates per Audrey's doc/guidance

Added the doc to the ticket


Rebuild with Node 14.5.3

Hi everyone,
thanks for the awesome work. Could you maybe trigger a re-build of this and the ng-cli-image?
There is a bug in node 14.5.2, which should be fixed in 14.5.3, causing karma pipeplines to fail.
The current image runs on node 14.5.2 or at least that is what the cli output tells me.
For reference see:
https://github.com/karma-runner/karma/issues/3588
https://github.com/karma-runner/karma/issues/3571

Thanks for bringing this to our attention, I will look into it.

We've just switched our pipeline to use the freshly build latest-image and it works like a charm :+1:
Thank you very much

That was quick - I just wanted to write about the updated latest build ;)
Glad it works out for you, don't hesitate to open a new issue if anything comes up. Thank you for your contribution!


Windows commands for Key Generation page

We need the windows version of our Mac/Linux instructions for generating validator keys.

Dependency instructions and links
terminal/PowerShell commands
specify python version

python3 - https://docs.python.org/3/using/windows.html
python through choco - https://chocolatey.org/packages/python
pip3 - https://pip.pypa.io/en/stable/installing/
pip through choco - https://chocolatey.org/packages/pip
git - https://git-scm.com/download/win
git through choco - https://chocolatey.org/packages/git
Commands:
git clone https://github.com/ethereum/eth2.0-deposit-cli.git
cd eth2.0-deposit-cli
pip3 install -r requirements.txt
python setup.py install
python cli/deposit.py


ffmpeg-vaapi: add level 6.2 test

add test_level for ICL- test_level_8k for ICL+

@uartie  PR update, please review, Thanks
For the config, if I set level = 6.2 , the the casename in baseline/full.default would be :
"test/ffm...........,level=level1,..........slices=1)" , seems that float number will change to some other string .  May be that is a bug in slash?  So I set 10 times as wished,  then divided in  real test.

please rebase with master

For the config, if I set level = 6.2 , then the casename in baseline/full.default would be :
"test/ffm...........,level=level1,..........slices=1)" , seems that float number will change to some other string . May be that is a bug in slash? So I set 10 times as wished, then divided in real test.

Maybe we should convert 'level' to a string in gen_hevc_cbr_level_variants, then back to a float inside the test.

For the config, if I set level = 6.2 , then the casename in baseline/full.default would be :
"test/ffm...........,level=level1,..........slices=1)" , seems that float number will change to some other string . May be that is a bug in slash? So I set 10 times as wished, then divided in real test.

Maybe we should convert 'level' to a string in gen_hevc_cbr_level_variants, then back to a float inside the test.

@uartie  I try to give a string to  slash.parametrize( "level", [ "6.1" ], but the case name still is (...level=level0...),
I expect to get  (...level=6.1..) in baseline/full.default , can you give me some advice? Is 10 times as wished acceptable?

For the config, if I set level = 6.2 , then the casename in baseline/full.default would be :
"test/ffm...........,level=level1,..........slices=1)" , seems that float number will change to some other string . May be that is a bug in slash? So I set 10 times as wished, then divided in real test.

Maybe we should convert 'level' to a string in gen_hevc_cbr_level_variants, then back to a float inside the test.

@uartie I try to give a string to slash.parametrize( "level", [ "6.1" ], but the case name still is (...level=level0...),
I expect to get (...level=6.1..) in baseline/full.default , can you give me some advice? Is 10 times as wished acceptable?

Yes, you are right.  I guess slash does not honor the . character in any parameters.  So I suppose 10x seems to be the best solution for normalization.

Please rebase with latest master branch... you have one extra commit in this PR that's already on master.


Issue: Local dev server reads undefined when using nested arrays in query

With this Prisma schema:
model Customer {
  uuid      String   @id @default(uuid())
  firstName          String        @default("")
  lastName           String        @default("")
  email              String        @unique
  phoneUuid          String
  phone              Phone         @relation(fields: [phoneUuid], references: [uuid])
}

And this query:
query MyQuery {
  listCustomers(where: {
    OR: [
      { firstName: { contains: "bla" } },
      { lastName: { contains: "bla" } }
    ]
  ) {
    uuid
    firstName
    lastName
    email
    phone {
      number
    }
  }
}

GraphQL Yoga seems to be receiving the parameters incorrectly, returning an empty result since Prisma can't understand the request:

{
    "data": {
        "listCustomers": []
    }
}

I've tried deploying onto AppSync itself and the query does function over there, so I think it may be some slip-up related to the development server.

Fix will be released as part of 1.0.0-rc.5.


HB-Service errors after new update

Hey there,
The new config UI update seems to have messed up Homebridge service. It keeps ending the process with “Code 1 signal null”.

Please fill in the issue template - including all the information requested.


Was the category subcommand removed?

I just downloaded the latest version of apt-cyg, and I noticed that category is listed as a subcategory:
category <category>      : List all packages in given <category>.

but trying to use it results in the following error:
$ apt-cyg category games
cat: '': No such file or directory

I then looked at README.md, and sure enough it seems that the category subcommand is not in there. Was this feature removed from the program, and if so, why?
I was hoping to be able to use it to remove all installed packages of a given category, maybe with something like:
apt-cyg category games | apt-cyg remove

You just downloaded apt-cyg, but you never updated setup.ini, maybe.
Try following:
apt-cyg update
apt-cyg category games

If you still fail it, please report the result of below commands:
apt-cyg pathof setup.ini
ls -l "$(apt-cyg pathof setup.ini)"

In the case to uninstall all packages of a given category, try following:
apt-cyg category games | xargs apt-cyg remove

This worked perfectly, thank you.


minor document fix

I think the argument name was wrong, not the line you modified

No sorry,

just tested it, its getting only jobId as argument, not job.

Yes sorry, you're right

Thanks!


Implement chain monitor logging for stale event logs

Figment logs indicate that nodes sometimes do not respond because they may be lagging behind other nodes, to the point that the entitlement was already processed by a quorum of nodes when a lagging node is starting. This change would add logging to the chain monitor to detect when an event is processed > 4s after the block occurred, as a way to determine how far behind the entitlement request a node is when it (finally) responds.

I deprioritized this because:

this issue should not cause the entitlement check to fail to complete, and in fact only happens as described if the check did complete
we solved the outage that was motivating this investigation. I think this only makes sense to look into at this time if our xchain stack fails to produce a check result.


[PE-D][Tester B] Incorrect handling of d/ prefix

Invalid date error handling format.
It suggest that there is an "Invalid date" however, I entered a valid date but only missing the time but it still suggest that I entered an invalid date.
It would be nice to have an additional error handling that lets reader know they are missing out on the time instead.

Labels: type.FeatureFlaw severity.Low
original: Zack-Tay/ped#8

It is specified in the UG that a valid date should include a date and time.


Double negative fix is not good

Is your feature request related to a problem? Please describe.
When encountering array.thing.size > 0 the suggested solution is !array_thing.empty?
Describe the solution you'd like
This double negative, the ! and empty?, is less readable than array_thing.any?
Describe alternatives you've considered
None
Additional context
It is easier to read this way, besides (and this is a purely personal peeve) the ! can sometimes be missed if, for example, the variable starts with an l. !list_of_things could easily misread as list_of_things

RuboCop cannot distinguish between the types of receivers such as ary.size > 0 and str.size > 0. This leads to different behaviors as follows:
# When the receiver is an Array object
!ary.empty? # => OK
ary.any?    # => OK

# When the receiver is a String object
!str.empty? # => OK
str.any?    # => NoMethodError

To avoid this incompatibility during autocorrection, Style/ZeroLengthPredicate cop is necessary to use !var.empty?.

Ah I fully understand, we do not want to break working code. Thanks for the
response. Can you close this or do I have to?
On Thu, 13 Jun 2024 at 17:28, Koichi ITO @.***> wrote:

RuboCop cannot distinguish between the types of receivers such as ary.size

0 and str.size > 0. This leads to different behaviors as follows:

When the receiver is an Array object
!ary.empty? # => OKary.any?    # => OK
When the receiver is a String object
!str.empty? # => OKstr.any?    # => NoMethodError
To avoid this incompatibility during autocorrection,
Style/ZeroLengthPredicate cop is necessary to use !var.empty?.
—
Reply to this email directly, view it on GitHub
https://github.com/rubocop/rubocop/issues/12992#issuecomment-2166164729,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AABGYXN7YEPPYHQXPWJRKBDZHHCCTAVCNFSM6AAAAABJIR6SH6VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDCNRWGE3DINZSHE
.
You are receiving this because you authored the thread.Message ID:
@.***>

It's already closed. Thank you for sharing your concern.


Fix Session Page Of Mentor Dashboard

I have designed the session page.

@anmode

@anmode done the changes

I have update some things....actually data api se dena. m api provide kr rha hu jo mera data fetch kr rhi h uska use krna ...
https://grabtern-backend.vercel.app/api/mentors/mentorDetail/anmode

{"mentorDetail":{"username":"anmode","name":"Anmol Agrawal","email":"anmol2002.aa1@gmail.com","mobile":9368086395,"internAt":"Google Summer of Code 2022","image":"https://res.cloudinary.com/grabtern-cloud/image/upload/v1688361690/og87pyq4vyptl1dlmffs.png","currentStatus":"Student software developer","description":"I have experience creating websites and web applications as a front-end developer. I have professional expertise dealing with C# and Next, and I specialize in JavaScript. I have also worked with React, typescript, and Vue. View my portfolio or get in touch!\n\nThere was more to come. I have a keen interest in blockchain-related things, ML, AI, and data science.\nSo I am also working on developing these abilities right now","social":{"linkedin":"https://www.linkedin.com/in/anmol-agrawal-748389151/","twitter":"https://twitter.com/A2_anmolagrawal","_id":"64bcf6f41cee943c2cc9a7b3"},"sessions":[{"name":"1 on 1 Mentorship","type":"video-meeting","duration":"30","description":"Achieve your goals faster with customized road map","price":"80","_id":"64bcf6f41cee943c2cc9a7b0"},{"name":"Resume Review","type":"video-meeting","duration":"15","description":"Get your resume reviewed.","price":"51","_id":"64bcf6f41cee943c2cc9a7b1"}],"schedules":[],"testimonials":[]}}

@anmode done the changes


Remove window.fileupload_opts global usage, use data attributes instead

Overview
This removes a two usage of inline scripts usage where we declare a global to ensure the jQuery file upload widget gets passed config or to use for allowing generated upload title lengths to be customised.
However, the same capability can be provided by the built in data attributes parsing of jQuery & the File Upload widget without relying on globals.

This PR gets us a step closer on the CSP compliance side by removing the need for the global variable.
This PR does not need a deprecation note as the global (now data attributes) already come from the file upload model and have documented ways to be customised outside of the HTML template or JS.

Details
jQuery data is used by the jQuery file upload widget and will automatically parse data attributes as objects/or JS primitive values - see https://api.jquery.com/data/
jquery File Upload will automatically parse the data attributes and treat as the default options for initialisation (already used for the url) - see https://github.com/blueimp/jQuery-File-Upload/wiki/API#data-attributes
I have also validated that the regex gets correctly parsed from the data attribute, this is handled automatically by the file upload plugin. See _isRegExpOption & _getRegExp ->
https://github.com/blueimp/jQuery-File-Upload/blob/0e92a4d4613d4ed5231ee0d8513519f2e04f99ba/js/jquery.fileupload.js#L1503

Relates to #9771 - avoiding globals for UI specific configs
Relates to #1288 & #7053 - ongoing work for CSP compliance

Testing
Note: I have done some smoke testing of this across a range of scenarios in Firefox 130, Safari 17.1, Chrome 130.

Documents: Go to upload and test out a file with length > 255 (or set a custom model with a shorter length).
Images: Go to upload, test out a file with length > 255 (or use a custom image model with a shorter length).
Images: Go to upload, test out a file size > 10mb (check message is correct) - https://examplefile.com/image/jpg/11-mb-jpg
Images: Go to upload, test out an unsupported file extension (check message is correct)

Screenshot
Observe the same messages are showing and client-side validation is running, for max size and image extension.

Rebased & fixups applied.


OCR scan andorid + ios

I try it scan for andorid and IOS but I see , Android only scan horizontal and IOS only scan vertical.
I can andorid + ios scan vertical . Can the library do it?

@thunq96 the library only provides algorithm API. https://github.com/yushulx/flutter_ocr_sdk/blob/main/example/lib/camera/camera_manager.dart
mrzDetector.recognizeByBuffer(bytes, width, height, stride, format)

Android only scan horizontal and IOS only scan vertical.

The scanning orientation is determined by the Flutter camera plugin. On Android, the format of the acquired camera frame is NV21, which means it is rotated by 90°, whereas on iOS, the format of the image is bgra8888. That's why you can scan vertically on iOS.

@thunq96 how can you scan vertically on both Android and iOS? You can decode NV21 to RGB before calling recognizeByBuffer().

@yushulx Thank you, but if I want to scan in multiple dimensions without turning on automatic rotation in the device, can I do that?

@yushulx  Where Can I get trial key for flutter?

I went to the website to request a trial key for mobile but when I added it to flutter it didn't work and it still said No license.

@thunq96 The license key (DLS2eyJoYW5kc2hha2VDb2RlIjoiMjAwMDAxLTE2NDk4Mjk3OTI2MzUiLCJvcmdhbml6YXRpb25JRCI6IjIwMDAwMSIsInNlc3Npb25QYXNzd29yZCI6IndTcGR6Vm05WDJrcEQ5YUoifQ==) in my example can work right?


Better document distinction between channel/chain monitor

For some/many users, a unified API would be preferable. Abstraction layer might be convenient?

ChainMonitor is the abstraction layer. I'm not entirely sure what's to be done here?

Is there a preferred module to use here, as it seems like ChainMonitor & ChannelMonitor do quite similar things?
Opened this as there seemed to be confusion from one of our users, @arik-so any thoughts?
I'm happy to close if we feel it's a non issue.

I think the confusion stems from the objects sounding so similar, even though they clearly refer to very different components. This is a hard one, but imo, definitely a big source of confusion.

Hmm, they do sound somewhat similar. Some of the confusion may stem from the fact that we have a generic interface a user could implement, but they probably want to just use a ChainMonitor. Is https://lightningdevkit.org/architecture/ not clear on this matter, or should we increase visibility of that page?


Use docker compose for cassandra integration tests

Which problem is this PR solving?

https://github.com/jaegertracing/jaeger/issues/5485

Description of the changes

updated cassaandra-integration-test.sh to use docker compose
update dependabot

How was this change tested?

bash scripts/cassandra-integration-test.sh 3 v003 v1 bash scripts/cassandra-integration-test.sh 3 v003 v2 bash scripts/cassandra-integration-test.sh 4 v004 v1 scripts/cassandra-integration-test.sh 4 v004 v2

Checklist

[ ] I have read https://github.com/jaegertracing/jaeger/blob/master/CONTRIBUTING_GUIDELINES.md
[ ] I have signed all commits
[ ] I have added unit tests for the new functionality
[ ] I have run lint and test steps successfully

for jaeger: make lint test
for jaeger-ui: yarn lint and yarn test

Signed-off-by: Your Name<EMAIL_ADDRESS>
I would advise you to fix this setting in your git.


Fix signatures for one parameter functions

Resolves #6

Tagged the wrong issue on this one. Meant to say it resolves #9


Please update this example due to the deprecation of the JSON library.

https://github.com/CycloneDX/cyclonedx-dotnet-library/blob/main/docs/articles/getting-started.md
CycloneDX.JSON has been marked as deprecated. Please provide an update for how to use the new structure.
Thanks in advance.

I don't know why MS was listing it as deprecated but now it is not listed that way in nuget. Weird. Never mind.

Are you confusing the namespace with the package name?
CycloneDX.Core is the correct library to use as laid down in getting-started.md
The CycloneDX.Json library is deprecated.
The C# using CycloneDX.Json; is used to access the Json-Namespace inside the CycloneDX.Core library.

No, it was just nuget being weird. I unloaded the solution and reloaded it and it stopped being reported as deprecated.

but thanks for this library. It is saving me a lot of time. <3


Update amqp-client to 5.5.1

Updates com.rabbitmq:amqp-client from 5.5.0 to 5.5.1.
I'll automatically update this PR to resolve conflicts as long as you don't change it yourself.
If you'd like to skip this version, you can just close this PR. If you have any feedback, just mention @scala-steward in the comments below.
Have a nice day!

Codecov Report

:exclamation: No coverage uploaded for pull request base (master@16b27ef). Click here to learn what that means.
The diff coverage is n/a.

@@            Coverage Diff            @@
##             master     #143   +/-   ##
=========================================
  Coverage          ?   97.56%
=========================================
  Files             ?       13
  Lines             ?      123
  Branches          ?        0
=========================================
  Hits              ?      120
  Misses            ?        3
  Partials          ?        0

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 16b27ef...8c882fa. Read the comment docs.


Unable to access built-in filters using the documentation example

Per https://www.11ty.dev/docs/filters/#access-existing-filters
The example didn't work for me, and appeared to be trying to print some toString()-ified version of the function:
<img src="function(...args) {
      benchmark.before();
      let ret = callback.call(this, ...args);
      benchmark.after();
      return ret;
    }"> alt="this is an alternate">

But this tweak worked:
module.exports = function(eleventyConfig) {
  eleventyConfig.addShortcode("myCustomImage", function(url, alt) {
    return `<img src="${eleventyConfig.getFilter("url")(url)}"> alt="${alt}">`;
  });
};

https://github.com/11ty/eleventy/blob/82d83f55b92624b7b307c3814c80c7f83b264d7f/src/UserConfig.js#L200-L207

Ah yes yours is correct, can you PR?

can you PR?

Done; #679

Thank you!


Inventory change Bug

Inventory change   Cannot show changed items in game

This feature was never implemented.
Inventory Changer was just a static addition.


Testing

It would probably be a good thing to work out how to build a good library of tests for this thing. One nice thing about that is that the "sh, grep, sed" requirement goes away for the development environment.

I am using Sharness for automatic tests: https://github.com/dashohoxha/egpg/tree/master/tests
But I am having problems because gpg has a "nasty" behaviour, it always pops up a window for getting the passphrase. Maybe this is a nice feature for the normal operation of the scripts, but for automatic testing it breaks the "automatic" part. Do you know how to work around this?

By the way, the solution that I used was to use tesk keys that don't have a passphrase. No passphrase, no pinentry needed, no popup.


Tip Calculator

The Tip Calculator is a simple tool that helps users split a bill among multiple people, including the tip. The user inputs the total bill amount, selects a tip percentage and specifies the number of people sharing the bill. The calculator outputs:

The total amount, including the tip
The calculated tip amount
The amount each person needs to pay

Please assign me this task under hacktoberfest2024

hi, i would like to work on this issue, kindly assign it to me as well!

hi, @gaurav75dhod I want to work on this issue , please assign me this issue.

hello @gaurav75dhod @shivigoyal4321 , i would like to contribute to this by providing a solution in javascript, please assign me this issue.

Hi @mohamedfarhan-m, the repository owner will assign the issue. Kindly, reach out to them.

Hi @tanya-code01, thanks for collaborating on this. However, I don't have any permissions to assign this issue to anybody. Please reach out to the owner of the repository.

@gaurav75dhod i have already added a PR for the same, kindly check

hello @mohamedfarhan-m , i would like to contribute to this issue by providing a solution in javascript, please assign me this task.

hello, thankyou so much so for letting me know & yes i definitely will.
On Fri, Oct 11, 2024 at 9:05 PM gaurav75dhod @.***>
wrote:

Hi @mohamedfarhan-m https://github.com/mohamedfarhan-m, the repository
owner will assign the issue. Kindly, reach out to them.
—
Reply to this email directly, view it on GitHub
https://github.com/strivedi4u/hacktoberfest2024/issues/159#issuecomment-2407663075,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/BKGT7IOPVZQO5VCFZLW7WNLZ27V2JAVCNFSM6AAAAABPQNCJA2VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDIMBXGY3DGMBXGU
.
You are receiving this because you commented.Message ID:
@.***>


Read API

As in #6 an update variant of insert classes is described, a further read variant should be generated.
In particular, the only additional information should be:

the id
the ctime

It would be rather useful to return objects, rather than dicts, to the packages directly consuming Qibodb in Python (of course for CLI dicts are perfectly fine).

This might be partially addressed by 756622c6f2dc8086b9d5d11625e0b5a85e308859 (to be properly tested)


How to debug unreachable https?

I use my home network (ATT U-Verse) to serve an ASP .NET website on a Windows 8.1 Pro machine with IIS 8.5.  Because Chrome requires https for doing audio recording, I want to move to https. I followed the instruction video at https://www.netometer.com/blog/?p=1758 , and everything corresponds until I test the actual https link in the browser (on the server itself, an other machine on the home network, or externally via my phone with data), which gives me a This page can’t be displayed"" or equivalent message.  I added port 443 to the Norton firewall rule I already had.  The http access still works, however.  Netmon 3.4 shows no TLS or SSL traffic.  I also tried disabling the Norton firewall temporarily.  This leads me to believe that the problem is that either the ATT NVG510 router I have is blocking port 443, or that ATT itself is blocking it.  Looking at the router settings on the Packet Filter page, it seems none of the default "Drop"rules are enabled, and there is an "Enable Packet Filters" button. Do I specifically have to set up a "Pass" rule?
Does anyone have any ideas on what I could do?  Can't I actually do this on my home server? My web site is www.jtlanguage.com .
Thanks.
-John

There's a port scanner a https://www.grc.com he calls it "ShieldsUP". The 'all ports' version gives a colourful block of ports that are open, closed or filtered.

Have you tried first to do telnet localhost 443 to see if you can connect locally.
Have you added binding to your IIS with port 443 in and attached SSL cert to it?
Are you forwarding port 443 from your router to web server?
It's not working as port 443 is not responding.
{ ~ }  » nmap -sS www.jtlanguage.com                                                             ~
Starting Nmap 7.40 ( https://nmap.org ) at 2017-06-23 12:28 ope
Nmap scan report for www.jtlanguage.com (<IP_ADDRESS>)
Host is up (0.023s latency).
rDNS record for <IP_ADDRESS>: 162-236-130-44.lightspeed.sntcca.sbcglobal.net
Not shown: 999 filtered ports
PORT   STATE SERVICE
80/tcp open  http
Nmap done: 1 IP address (1 host up) scanned in 7.79 seconds
{ ~ }  » telnet www.jtlanguage.com 443                                                           ~
zsh: command not found: telnet
{ ~ }  » telnet www.jtlanguage.com 443                                                       ~ 127
HTTP/1.1 400 Bad Request
Content-Type: text/html; charset=us-ascii
Server: Microsoft-HTTPAPI/2.0
Date: Fri, 23 Jun 2017 11:30:06 GMT
Connection: close
Content-Length: 326

Bad Request

Bad Request - Invalid Verb
HTTP Error 400. The request verb is invalid.

Connection to host lost.
C:\WINDOWS\system32>telnet <IP_ADDRESS> 443
Connecting To <IP_ADDRESS>...Could not open connection to the host, on port 443: Connect failed

@ber5ien Thank you so much!  It was the port forwarding. I'd forgotten all about that, even though I had to do it for port 80 back when I first set up the web site.  For other router NGV510 users out there, this is done on the Firewall->NAT/Gaming page, adding a hosted application referencing the HTTPS service and the web server machine name.
@rdebath Thanks also for the reference to the cool ShieldsUp page which was useful in the process of debugging this.
Again thanks to both of you for taking the time to help me out.  I really appreciate it.

Sorry for opening it again but noticed that your setup is not completed :)
What you need to do now is setup http -> https redirect.

Create a new entry in your IIS with pointing it to a different directory than your website.
(Every redirect needs to have it is own folder otherwise it will override the web.config)
Add binding for http only then setup a redirect as per picture below.
Then remove http binding from your old IIS entry.
Test!

So all your visitors will be automatically moved to your site using https instead of http.
The only problem is that you will need to revert your changes during the renewal as it only renew it using http as far as I remember. The only solution for that would be to use URL rewrite module to ignore the path this software is using to validate the URL and not to redirect it.

Actually, I'm working on this now.  I tried doing the redirect in IIS, but I would get "too many redirects" errors in Chrome, and Edge and IE wouldn't connect at all.  I'm working on doing the redirect in my MVC code, from a response someone got on StackOverflow, which seems to work so far, though I had to hack it a bit to keep my WCF service working. I also had to fix a number of things to handle both "http" and "https" in urls.  Here's my MVC hack to Global.asax.cs to do the redirect:
`        protected void Application_BeginRequest(Object sender, EventArgs e)
{
// Handle http to https redirection here.
if (Request.IsLocal)
{
return;
}
else
{
// If connecting to a machine on the local network, don't redirect.
if (!Request.Url.Host.StartsWith("www."))
return;
            // If for the service, don't redirect.
            if (Request.CurrentExecutionFilePathExtension == ".svc")
                return;

            switch (Request.Url.Scheme)
            {
                case "https":
                    Response.AddHeader("Strict-Transport-Security", "max-age=31536000");
                    break;
                case "http":
                    var path = "https://" + Request.Url.Host + Request.Url.PathAndQuery;
                    Response.Status = "301 Moved Permanently";
                    Response.AddHeader("Location", path);
                    break;
            }
        }
    }

`
This only works if I use "http" in the service url.  Can services use https also?  If I use https, I get an "Endpoint not found exception".
Any thoughts on this?
Thanks.

Hi,
I don’t think you need this
ase "http":
var path = "https://" + Request.Url.Host + Request.Url.PathAndQuery;
Response.Status = "301 Moved Permanently";
Response.AddHeader("Location", path);
break;
as you already do a redirect using IIS.
If you can post screenshoots of binding you use in the folders you pointing the iis entry I can then check it for you.
Sent from Mail for Windows 10
From: jtsoftware
Sent: 23 June 2017 17:06
To: Lone-Coder/letsencrypt-win-simple
Cc: Rafal Zdziech; Mention
Subject: Re: [Lone-Coder/letsencrypt-win-simple] How to debug unreachablehttps? (#463)
Actually, I'm working on this now. I tried doing the redirect in IIS, but I would get "too many redirects" errors in Chrome, and Edge and IE wouldn't connect at all. I'm working on doing the redirect in my MVC code, from a response someone got on StackOverflow, which seems to work so far, though I had to hack it a bit to keep my WCF service working. I also had to fix a number of things to handle both "http" and "https" in urls. Here's my MVC hack to Global.asax.cs to do the redirect:
` protected void Application_BeginRequest(Object sender, EventArgs e)
{
// Handle http to https redirection here.
if (Request.IsLocal)
{
return;
}
else
{
// If connecting to a machine on the local network, don't redirect.
if (!Request.Url.Host.StartsWith("www."))
return;
// If for the service, don't redirect.
if (Request.CurrentExecutionFilePathExtension == ".svc")
return;
        switch (Request.Url.Scheme)
        {
            case "https":
                Response.AddHeader("Strict-Transport-Security", "max-age=31536000");
                break;
            case "http":
                var path = "https://" + Request.Url.Host + Request.Url.PathAndQuery;
                Response.Status = "301 Moved Permanently";
                Response.AddHeader("Location", path);
                break;
        }
    }
}

`
This only works if I use "http" in the service url. Can services use https also? If I use https, I get an "Endpoint not found exception".
Any thoughts on this?
Thanks.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or mute the thread.

While ASP.NET development is interesting, I think this question should be discussed elsewhere, as you would have the same issues with any certificate. thanks for using LEWS though ::)


Fix darwin tcl tk

Things done:

[ ] Tested via nix.useChroot.
[x] Built on platform(s): darwin.
[ ] Tested compilation of all pkgs that depend on this change.
[x] Tested execution of binary products.
[x] Fits CONTRIBUTING.md.

Extra
Fixes #13377

Hm. I actually only wanted to request the second commit, the first one already got accepted. (Still not mastered github.)

gitk runs! Thanks.


Document specific engine log messages

There are script log messages in a following format:
(room:%d) [%s %d]
where ags will print error location in square brackets, using a single letter and a number.
https://github.com/adventuregamestudio/ags/blob/12b7f62fce17bb5fdbf4aa5464268b3dcbcebd67/Engine/debug/debug.cpp#L369
May be worth documenting their meaning somewhere. But also have to note that these may be engine-specific and change in future (just in case).

There was the idea of GameFeatures that we didn't fleshed out, perhaps with a link to/from the Log Panel page.

Yes, I think "engine logging" topic in Engine section would look better, because this is not really a game feature, it's just engine reporting about something.

Hey, I don't understand what the ? means in this case. It's not the game script (module ?), Room Script, or the Dialog Script. Which script is it than that would cause the ? character?

Edit: I think G means global script and ? means is any other script module.

Right, and that's kind of weird. I think it's possible that this code was written at the time when custom modules did not exist, so the ? means "undefined behavior". Perhaps we should change it to something, like M or a module's index.


[Clean] Clean up Element

[ ] Element and UIkit both have icon and input as components, can we verify that we can remove components from Element (are they being used anywhere @nikoloza?)

Yes @youzi we can remove whole components folder from element.


MUMUP-2156 : Add a logout link to header when sidebar is hidden

:+1:

Resolves #41

Y no "Log out" text?

@nblair - its in the title if they hover. Didn't want a lot of noise in the header. Worth revisiting if people complain :repeat:

Looks like screen reader will pick up title, so fine for now :+1:


Styling tos

Description
Fixes # (issue)
Type of change
Please delete options that are not relevant.

[ ] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[ ] This change requires a documentation update

Change Status

[ ] Complete, tested, ready to review and merge
[ ] Complete, but not tested (may need new tests)
[ ] Incomplete/work-in-progress, PR is for discussion/feedback

How Has This Been Tested?

[ ] Test A
[ ] Test B

Checklist

[ ] My code follows the style guidelines of this project
[ ] I have performed a self-review of my own code
[ ] My code has been reviewed by at least one peer
[ ] I have commented my code, particularly in hard-to-understand areas
[ ] I have made corresponding changes to the documentation
[ ] My changes generate no new warnings
[ ] I have added tests that prove my fix is effective or that my feature works
[ ] New and existing unit tests pass locally with my changes
[ ] There are no merge conflicts

 Styling of Terms of Service and Privact Policy

 Styling of Terms of Service and Privact Policy

 [Parent] [Styling] - View Terms of Service and Privacy Policy


Add no_std support

It would be great to have no_std support for thiserror, and after a look over the codebase I don't think it would be very difficult, I'm just inexperienced with proc-macros. The only drawbacks (and thus make no_std compatibility require a feature flag) would be that std::error::Error and std::path are not core or alloc friendly. For the most part, migration would be easy as changing std imports to core or alloc, but for the aforementioned roadblocks I propose the following:
Add #![cfg_attr(feature = "no_std", no_std)] to the root of the thiserror crate to enable no_std for the no_std feature
Add a feature to both thiserror and thiserror-impl, possibly something like no_std, this would look about like this
# In thiserror
[features]
default = []
no_std = ["thiserror-impl/no_std"]

# In thiserror-impl
[features]
default = []
no_std = []

And then for problematic areas, like thiserror/src/aserror.rs and thiserror/src/display.rs, simply conditionally compile them when the no_std feature is not active using #[cfg(not(feature = "no_std))]
Lastly there'd be the normal changing std to core/alloc, but adding conditional compilation to places where aserror.rs and display.rs are used would also be needed

Closing in favor of #64 to keep the discussion in one place.

Oh, I'm sorry, I didn't see that PR


chore: Add vite to root package.json

Necessary to prevent multiple versions of vite getting installed

Codecov Report
Patch and project coverage have no change.

Comparison is base (b497aa9) 88.75% compared to head (abafd9d) 88.75%.

:exclamation: Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.
Additional details and impacted files
@@           Coverage Diff           @@
##            alpha    #5722   +/-   ##
=======================================
  Coverage   88.75%   88.75%
=======================================
  Files          72       72
  Lines        2401     2401
  Branches      624      624
=======================================
  Hits         2131     2131
  Misses        222      222
  Partials       48       48

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.


Scrollbar height calculation when there are few items in the table

In our use case we have a table in the scroll.viewPortItems and there are cases, when the table is shorter than the actual screen height. When the page is loaded, the scrollbar appears and after the content height is calculated, it disappears. It's causing the page to flicker. Is there a way to prevent it from appearing?

  <virtual-scroller #scroll [items]="tableTypes" (vsUpdate)="rf.detectChanges()" [parentScroll]="timeline">

        name
        REFERENCE VALUE
        Units

  </virtual-scroller>

Please convert this to a StackBlitz


ODB-27: Cleaning up around improved argument parser

Remaining TODOs with improved arg parser:
parse views
manage extract method (see #7 )
update/rewrite the select_files and pre_process_data methods in the CLI to respect the .toml files (This will require reworking the dump_to_toml) method on Odb too.
Also, implement a "convert" method in order to update a .odb to a .hdf5

Fix CLI views parsing now that it's not a member of OdbVisualizer

As of 2023/02/22, views parsing is all finished.
So, still todo:
extractor #7
update/rewrite select_files, pre_process_data, and dump_to_toml

Update 2023/02/23
Looks like it will make sense to implement most CLI functionality once in the state.py file, which will allow us to call it from the arg parser or the CLI. DRY

Update 2023/02/23:
Old functionality back to working, more efficient
Still need:
generate config file if it does not exist
add extract method (parametrize both abaqus python scripts)

Update 2023/02/23:
Extractor basically needs to read the input like the CLI, but then do the extraction.
What do we do with extracted data? Pickle a dataframe? Plot?
Are we plotting other stuff?
Do we ever need to specify step number? Do we ever want to specify step number?
Can we always find part(s) the same way that we find nodeset(s)?
print(odb.rootAssembly.instances["PART-1-1"].nodeSets.keys())
print(odb.rootAssembly.instances.keys())


removed unused keyword "contract" from testinvoke in help output

The help for testinvoke had an extra "contract" keyword that didn't reflect the actual command syntax

Coverage remained the same at 52.555% when pulling 8b630ace18faf25e828cb1005d797e51156b8044 on hal0x2328:master into 658e85855efb398388a9c50bf209c943454b86c8 on CityOfZion:master.


Make the solution work with nested subworkflows

It's not clear how reading from meta.yml will function when using nested subworkflows, i.e. subworkflows that import another subworkflow. This might work from the get-go or might prove more difficult than anticipated.

Fully implemented by  #12


Plot Twist No Fansub: Update domain

Closes: #3844
Checklist:

[x] Updated extVersionCode value in build.gradle for individual extensions
[ ] Updated overrideVersionCode or baseVersionCode as needed for all multisrc extensions
[x] Referenced all related issues in the PR body (e.g. "Closes #xyz")
[x] Added the isNsfw = true flag in build.gradle when appropriate
[x] Have not changed source names
[ ] Have explicitly kept the id if a source's name or language were changed
[x] Have tested the modifications by compiling and running the extension through Android Studio
[ ] Have removed web_hi_res_512.png when adding a new extension

does this works? there is another issue (#3303) that says that chapter list not work

Yes.

change a word in popularMangaFromElement. That caused the list to not appear.

Close the other issue too


[bzip2] fixes for building release-only

Restore the possibility to build bzip2 with a release-only triplet.
I'd also suggest to move one of the CI pipelines to test ports for this configuration, which is very common in production.
Closes #12799

EOL is now LF only, sorry for the very noisy diff. Luckily GitHub has an option in the diff view to hide whitespace-only changes

The error on baseline will be fixed in PR #12766.

@cenit: please stop mixing port fixes with smaller script fixes. Your are invalidating all the cached archives which use vcpkg_fixup_pkgconfig() and don't depend on bzip2. Although you might not see the benefit of message(STATUS "Checking file: ${_file}") since you probably only dealt with ports installing only a few *.pc files it is quite important to know where the error occurred if you have to deal with a port installing 20+ *.pc files

That's a problem for port creators, not port users. For the same reasons there is no output for vcpkg_fixup_cmake_targets or many others.
We should assume that when you install the port, it should just work, and output should be minimal as it always has been

We should assume that when you install the port, it should just work

This PR here already shows the opposite of such an assumption

This PR here already shows the opposite of such an assumption

again, that's not a reason to fill up user screen with unnecessary debug information.
Such problems should be detected during review and from CI

@cenit with that logic vcpkg should not output anything. The messages are meant as progress messages not debug info. If you would rather like to see 'fixing pkgconfig x of y' I can make that change. I would also like to see some progress messages for fixup_cmake because ports like qt and vtk take a long time to fixup due to the amount of small file io.

with that logic vcpkg should not output anything

tbh I'd love it :)
Output only in case of errors, otherwise just a sequence of
"Starting package 1/97"
"Finishing package 1/97"
....
"Starting package 97/97"
"Finishing package 97/97"
such a lovely output 😄

Maybe just a global verbosity flag should be added for vcpkg? Then every port user can control amount of information they'd wish to see...

of course, on files (with a fixed standardized syntax) of course you can write as much as you want!

@LilyWangL, any news here? All CI fails looks like not really related to this particular PR...

I've also hit this issue, and am eager to see this fix merged.

The CI fails is not related with this PR, it will be fixed by PR #12856.

@cenit, please follow common git commit practices:

Make only one change per commit and avoid including unrelated changes

The changes to the file scripts/cmake/vcpkg_fixup_pkgconfig.cmake are unrelated to "[bzip2] fixes for building release-only" (commit a3e2935e71ba2322bc7e715604eff41a70be450b)

@gitcop-devel, this repo contains examples that contradict this rule ;)


Metadata for figshare

We need to create metadata for the figshare file, link it from the readme. @cbahlai will have to upload the metadata directly because it's hosted on her account so email it to her

I'll work on the basis of our original matedata and paste the updated version here.

I pulled stuff from the blog post with the metadata and wrote a breif metdata file :)

Yeah! I'm glad that post works. :)
Saisi
On Thursday, September 8, 2016, Christie Bahlai<EMAIL_ADDRESS>wrote:

I pulled stuff from the blog post with the metadata and wrote a breif
metdata file :)
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/cbahlai/lampyrid/issues/2#issuecomment-245791421, or mute
the thread
https://github.com/notifications/unsubscribe-auth/AP0JllbzscoT8gDp_DkI5qpZEvls5W4oks5qoLQ0gaJpZM4IFiZJ
.

--
Saisi Xue,
PhD Student
Department of Chemical Engineering & Material Science,
DOE Great Lakes Bioenergy Research Center,
Michigan State University
3815 Technology Boulevard,
Lansing, MI  48910.


Nodes not removed from API on instance termination

Description
The delete-node.service systemd unit has an ExecStop directive to remove the node from the Kubernetes API. Presumably this should run when the instance is gracefully terminated but that does not seem to be the case. The node remains in the API and transitions to the NotReady state.
Steps to Reproduce
From the EC2 console:

Terminate a functioning worker instance.
Observe the node is not removed from Kubernetes API with kubectl get node.

To verify the delete-node.service, from inside a functioning worker node:

Run systemctl stop delete-node.
Observe the node is removed from Kubernetes API with kubectl get node.
Run systemctl restart kubelet; systemctl start delete-node.
Observe node is added to the API.

This was reproduced on both Fedora and Flatcar workers.
Expected behavior
On EC2 instance termination, systemd handles the shutdown and runs ExecStop for the delete-node.service unit, removing the node from the Kubernetes API.
Environment

Platform: aws
OS: fedora-coreos, flatcar-linux (default OS release)
Release: 597ca4acce0ddc6116a55660438284d4e5c88270
Terraform: 0.14.7
Plugins: Provider plugin versions:

+ provider registry.terraform.io/hashicorp/aws v3.25.0
+ provider registry.terraform.io/hashicorp/helm v2.0.3
+ provider registry.terraform.io/hashicorp/kubernetes v2.0.2
+ provider registry.terraform.io/hashicorp/local v2.1.0
+ provider registry.terraform.io/hashicorp/null v2.1.2
+ provider registry.terraform.io/hashicorp/random v3.0.1
+ provider registry.terraform.io/hashicorp/template v2.2.0
+ provider registry.terraform.io/hashicorp/tls v3.1.0
+ provider registry.terraform.io/poseidon/ct v0.8.0

Possible Solution

Link to a PR or description.

Looks like this is fixed on Flatcar by adding the following to the delete-node.service unit:
Requires=docker.service
After=docker.service

This should ensure that the ExecStop happens before the Docker daemon goes down.
Having more trouble with Fedora, I tried adding a dependency on network.target because I guessed it may be losing network connectivity before the kubectl delete node gets executed. However that doesn't seem to have helped, so I'll keep poking.

Here's the error thrown by the podman call in delete-node.service on Fedora:
bash[36140]: Error: OCI runtime error: sd-bus call: Resource deadlock avoided

systemctl stop delete-node should work every time when run directly, I think you have it in the repro instructions just for comparison.
Have you tried shutting down the node (not terminate)? I don't expect cloud provider implementations of "termination" to really promise anything about graceful OS shutdown. Shutdown is probably the more reasonable expectation to test, plus you'll more easily be able to obtain logs.

@vixus0 I was managing this in our environment using a python script. check this if it helps.

@dghubble Sure, I just tested this with sudo shutdown -h now (I hope I understood you correctly) and observed the same behaviour.
I checked the logs for delete-node.service once nodes were restarted. On Fedora, I see:
Mar 29 13:20:52 ip-10-0-19-139 systemd[1]: Stopping Delete Kubernetes node on shutdown...
Mar 29 13:20:53 ip-10-0-19-139 podman[21790]: 2021-03-29 13:20:53.392338336 +0000 UTC m=+0.459533649 container create db887a06b45be5ec79ac1dd834dd709b42ad1d804815cc0edcc155e87d80e2c4 (image=quay.io/poseidon/kubelet:v1.20.5, name=pedantic_payne, io.buildah.version=1.19.6, maintain>
Mar 29 13:20:53 ip-10-0-19-139 bash[21790]: Error: OCI runtime error: sd-bus call: Resource deadlock avoided
Mar 29 13:20:53 ip-10-0-19-139 podman[21974]: 2021-03-29 13:20:53.876832087 +0000 UTC m=+0.171011455 container cleanup db887a06b45be5ec79ac1dd834dd709b42ad1d804815cc0edcc155e87d80e2c4 (image=quay.io/poseidon/kubelet:v1.20.5, name=pedantic_payne, io.buildah.version=1.19.6, maintai>
Mar 29 13:20:53 ip-10-0-19-139 systemd[1]: delete-node.service: Control process exited, code=exited, status=126/n/a
Mar 29 13:20:53 ip-10-0-19-139 systemd[1]: delete-node.service: Failed with result 'exit-code'.
Mar 29 13:20:53 ip-10-0-19-139 systemd[1]: Stopped Delete Kubernetes node on shutdown.

On Flatcar, I see the following:
Mar 29 12:37:56 ip-10-0-27-19 systemd[1]: Stopping Delete Kubernetes node on shutdown...
Mar 29 12:37:57 ip-10-0-27-19 systemd[1]: delete-node.service: Control process exited, code=exited, status=2/INVALIDARGUMENT
Mar 29 12:37:57 ip-10-0-27-19 systemd[1]: delete-node.service: Failed with result 'exit-code'.
Mar 29 12:37:57 ip-10-0-27-19 systemd[1]: Stopped Delete Kubernetes node on shutdown.

The fix for Flatcar proposed in my PR does seem to solve the issue and removes nodes as expected. Not sure what's going on with Fedora.
Let me know if you need me to try anything else, I have some clusters up and running.
@vamshisiddarth Thanks for the link, actually I had read your article previously :slightly_smiling_face: I'm using aws-node-termination-handler on my real clusters which takes care of draining/cordoning nodes in response to spot instance events. I don't think that applies to this issue though, as it applies to the services that come out of the box with Typhoon.

After working with my changes for some time, I'm inclined to agree that it's worth running a separate process to reconcile the node state in the Kubernetes API against the cloud API since there will always be some cases where the node doesn't come down cleanly.


Document the generation of ECDSA private keys

Add a note in the README.md how to generate an ECDSA key.

I'm not sure if this is possible to add ECDSA support efficiently with all the openssl regex/parsing/signing that's going on in acme-tiny. Thoughts?

It is, all you need is exactly that one line that this PR implies.

I have been using acme-tiny with a private key and a CSR generated in such manner since before I opened this PR including with the latest version.

@diafygi code support is only needed for ECC account keys, but not for ECC private keys for certificates.

Gotcha. I feel like before merging this, a test should be added for ECDSA account keys. I could probably write the test, but it might be a while before I get around to it. However, totally open to adding a test as part of this pull request or opening another pull request.

I'll leave someone else to pursue these changes

Why a test for an account key? This pull request has nothing to do with account keys? I am using ecc private keys for my domains with acme-tiny for years now. This little update of the docs would be nice for everyone else.


Conversion to onnx

Hi,
As mentioned in convert_to_onnx.py script, I couldnt convert to onnx with dcn layers. Is there a pretrained model available with conv layers instead of dcn.?

Hi. I have not tried to convert the model to onnx, and unfortunately do not have a pretrained model without dcn layers. There is a discussion about this issue here that might be helpful for you.


feat(package): add @sapphire/result package

Fixes #273
Copies Result code from both framework and Lexure and exposes both Result and Maybe into it's own package. See issue for more details.

oh ffs


Remove statefulness of pre-approved witness DID log

As noted here I don't love that we're holding onto this pending state somewhere. As noted in that comment these are the ideas I came up with

/.well-known/pending-did.jsonl being the log in it's pending state
allowing the DID controller to update their did.jsonl with the pending state as the last entry, and specifying how a resolver would interpret this state (ie fallback to previous version unless a param was included)
specifying they need to remember this pending state

Action: Leave in the spec -- consider clarifying why that is done. @swcurran

Reviewed the spec and I think this is clear (although there is markdown error -- I'll fix that).
Closing this issue.


Kubeflow operator versioning

Adds to Operator Roadmap issue #193 to track:
Currently the kubeflow operator is hard coded with version 0.1.0. A new versioning mechanism needs to implement to avoid following issues:

Kubeflow and kfctl have moved from 0.7 to 1.0, operator does not reflect such change.

The version of the docker image for the operator is aipipeline/kubeflow-operator:v0.1.0 which was built with an older version of kfctl (aka. it was built with kfctl 0.7.0 instead of latest 1.0.0). When the version number of the docker image is fixed, it is not able to reflect any new kubeflow release.

The CSV and other manifests kept in operatorhub.io also is outdated and out of sync.

We need a dynamic versioning mechanism for kubeflow operator to keep up with the kubeflow releases.

I keep thinking about this - does the operator and the manifests need to match? Since the operator could handle multiple versions of manifests as long as there are not crazy breaking changes, it might make sense to decouple these and not have to release the operator and manifests together.
Is it a plan for kfctl itself to be released with every manifests update and vice versa? @animeshsingh @jlewi

I would not expect manifests and kfctl to be on different release cyles.

A way to look at it is like  KF Control Plane CLI + KF Configuration files which are needed for that CLI to work for a Kubeflow version.  Now it maybe possible the CLI works with Configuration files with previous or next versions, but won't be something which project is testing or standing for. So ideally would not make sense to advertise so as well.

My question stems from seeing the same change in approach in Knative project (https://github.com/knative-sandbox/operator/issues/56) - they are decoupling manifests and the operator like Kubeflow does, but AFAIU they are also looking at decoupling the versions - i.e. the operator can handle multiple versions of manifests/knative and thus you do not need to rebuild and/or redeploy the operator for a small change in manifests and vice versa - you do not need a new version of manifests for a fix/feature in the operator.
It think with a fast moving project like Kubeflow is, it would make sense to think about similar approach and built in support for this.


queues?page=1&jobsPerPage=10 pending

Many pending request queues?page=1&jobsPerPage=10 what run minutes
if redis server is down

Why is not returned 404 or 50X errors?

You can make the polling every 30 sec or more (check settings).
If one of your services is down, what is the expected behaviour?

Momentan response 50X for example

Why to wait if other fetch run every x sec

I'm not sure I understand the question.
the board updates its data by polling the server, if you services are down... what it should do? stop the polling?

In browser in network tab I see 3+ pending connections. Why it start new one if previous not finished?

And in H3Adapter base path I think is not added to all routes because some routes are generated before setting base path
That is called  I think first automatically on adapter is created
 setApiRoutes(routes) {
        routes.forEach(({ route, handler, method: methodOrMethods }) => {
            const methods = Array.isArray(methodOrMethods) ? methodOrMethods : [methodOrMethods];
            methods.forEach((method) => {
                this.registerRoute(route, method, handler);
            });
        });
        return this;
    }
    ```

and after setBasePath

Also It return me 204 no content and not finish to load page at infinit here
routes.forEach((route) => {
            this.uiHandler.push({
                path: `${this.basePath}${route}`,
                handler: (0, h3_1.eventHandler)(async (event) => {
                    try {
                        const { body } = (await handler)({
                            queues: this.bullBoardQueues,
                            params: (0, h3_1.getRouterParams)(event, { decode: true }),
                            query: (0, h3_1.getQuery)(event),
                            body: method !== 'get' ? await (0, h3_1.readBody)(event) : {},
                        });

                        // return body;
                        return typeof (await body) === 'undefined' ? '' : body;
                    }
                    catch (e) {
                        if (this.errorHandler) {
                            const { body, status } = this.errorHandler(e);
                            return (0, h3_1.createError)({
                                statusCode: status,
                                data: body,
                            });
                        }
                    }
                }),
                method
            });
        });

With return typeof (await body) === 'undefined' ? '' : body; return blank page with 200 ok not 204 no content.


chore: remove unused v0.2 upgrade handler

Delete the old and unused code for the upgrade handler from v0.1 to v0.2.

Summary by CodeRabbit

New Features

Streamlined application initialization process.

Bug Fixes

Removed outdated upgrade handling logic to simplify upgrades.

Refactor

Eliminated unnecessary imports and types related to upgrade management.
Removed the AppUpgrade struct and associated upgrade functions.

superseeded by #974


Incorrect language icon displayed on Discord

What is the issue?
Selecting the Flat or Atom language icons results in the usage of the Material one instead. e.g:
Expected outcome:

What actually happens:

(This is the icon for the Material Language icon themes)

A fix would be appreciated :)
Cheers

Resolved by https://github.com/Azn9/JetBrains-Discord-Integration/commit/8dab8da05778aefc37cf0b7fb4aa4da541cecd24

Seems to work now, however I have to manually change the icon theme in the project's discord xml file because the editor does not override / update the file's value.

You can set the theme to "default" in the project options ;)


how to connect asia server with Mac os？

Wait a moment,
are you sure you want to create an issue with this launcher?
If you have gameplay issues start a new BugReport at HermesProxy: https://github.com/WowLegacyCore/HermesProxy

Go inside your winterspring-launcher-config.json (open it with an editor) and replace
at the bottom "Realmlist": "logon.everlook.org"
with the new value "Realmlist": "asia.everlook-wow.net"

Go inside your winterspring-launcher-config.json (open it with an editor) and replace at the bottom "Realmlist": "logon.everlook.org" with the new value "Realmlist": "asia.everlook-wow.net"
On MacOS the config is stored in /Users/<your name>/WinterspringLauncher/

I've tried modifying the Realmlist but nothing seems to work. My winterspring-launcher-config.json is:
{
  "ConfigVersion": 1,
  "GitRepoWinterspringLauncher": "0blu/WinterspringLauncher",
  "GitRepoHermesProxy": "WowLegacyCore/HermesProxy",
  "GitRepoArctiumLauncher": "Arctium/WoW-Launcher",
  "WindowsGameDownloadUrl": "default",
  "MacGameDownloadUrl": "http://<IP_ADDRESS>:8080/WoW_Classic_<IP_ADDRESS>618_macOS_new.zip",
  "GamePatcherUrl": "default",
  "HermesProxyPath": "./hermes-proxy",
  "GamePath": "./World of Warcraft 1.14.0",
  "ArctiumLauncherPath": "./arctium-launcher",
  "RecreateDesktopShortcut": false,
  "AutoUpdateThisLauncher": false,
  "Realmlist": "asia.everlook-wow.net"
}

When I start the launcher, the terminal shows the logs:
Starting WoW...
Starting HermesProxy...
19:42:40 |  Server  | Server          | Starting Hermes Proxy...
19:42:40 |  Server  | Server          | Version 2023-10-19 *official* 3.10.0
19:42:40 |  Server  | Server          | Modern (Client) Build: V1_14_0_40618
19:42:40 |  Server  | Server          | Legacy (Server) Build: V1_12_1_5875
19:42:40 |  Storage | GameData        | Loading data files...
19:42:40 |  Server  | VersionChecker  | Loaded 833 legacy opcodes.
19:42:40 |  Server  | VersionChecker  | Loaded 1639 modern opcodes.
19:42:42 |  Storage | GameData        | Finished loading data.
19:42:42 |  Network | Server          | External IP: <IP_ADDRESS>
19:42:42 |  Server  | Server          | Starting BnetTcpSession service on <IP_ADDRESS>:1119...
19:42:42 |  Network | NetworkThread   | Network Thread Starting
19:42:42 |  Server  | Server          | Starting BnetRestApiSession service on <IP_ADDRESS>:8081...
19:42:42 |  Network | NetworkThread   | Network Thread Starting
19:42:42 |  Server  | Server          | Starting RealmSocket service on <IP_ADDRESS>:8084...
19:42:42 |  Network | NetworkThread   | Network Thread Starting
19:42:42 |  Server  | Server          | Starting WorldSocket service on <IP_ADDRESS>:8086...
19:42:42 |  Network | NetworkThread   | Network Thread Starting
19:42:53 |  Server  | BnetTcpSession  | Accepting connection from <IP_ADDRESS>:60471.
19:42:54 |  Network | AuthClient      | C P>S | Connecting to auth server... (realmlist addr: logon.everlook.org:3724) (resolved as: <IP_ADDRESS>:3724)
19:42:54 |  Error   | AuthClient      | Login failed. Reason: FAIL_UNKNOWN_ACCOUNT
19:47:54 |  Error   | AuthClient      | C P<S | Socket Closed By Server


Command line tool to convert markdown files to slide pdf

I want to store the source file in an repository and publish the newest version via a commit triggering an CI instance.
A command line tool for at least linux would be nice, that takes the source file and produces the PDF, like the export functionality.

Duplicate of #50


Update DFIR-Script.ps1

I Modified the data collected about running processes.
Now there are two CSVs:

UniqueProcessHash, which lists all the unique running processes's path alongside their hash
ProcessList, which list all the running processes with lots of metadata about them

Great addition, merged! Thanks.


[Proposal] Fire events on relationship creation

Presently there is no way to know when a relationship has been created via
Model::find(1)->something->save($anotherSomething);

This proposal puts forward the idea of firing relationship.creating, relationship.created, relationship.destroying, relationship.destroyed events in the same manner as saving a model.
This allows us to do awesome things like setup another relationship automatically when this relationship is setup, or send a "Dude someone joined your crew" email when a new relationship is added!

This doesn't cover pivot tables +1

+1

::thumbs_up::

:thumbs_up:

+1

+1 for pivot tables

+1

I created something similar for belongsToMany relation : https://github.com/fico7489/laravel-pivot

I encountered this missing missing this feature several times and feels like this is basic need in any project flow. For example, while creating appointment model, i need to calculate the amount of the services/packages (which are relation models). then on create observer doesn't make any sense as these relationships are not yet created when it fires.

:+1: from me as well.
Example:
Two models, a Project has many Expenses. If a project uses a foreign currency, say Euro, and you have expenses for that project in US Dollars, and you want to convert the expense to the projects local currency upon saving.
This isn't that easy to do as the relation isn't available for events like creating, creating, saving and saved for new expenses.


Gh 826 hbase

Codecov Report

Merging #829 into develop will increase coverage by 3.87%.
The diff coverage is 73.52%.

@@              Coverage Diff              @@
##             develop     #829      +/-   ##
=============================================
+ Coverage      58.64%   62.52%   +3.87%
+ Complexity      2669     1196    -1473
=============================================
  Files            489      525      +36
  Lines          12241    13797    +1556
  Branches        1343     1559     +216
=============================================
+ Hits            7179     8626    +1447
- Misses          4474     4533      +59
- Partials         588      638      +50

Impacted Files
Coverage Δ
Complexity Δ

.../main/java/uk/gov/gchq/gaffer/commonutil/Pair.java
0% <0%> (ø)
0 <0> (?)

...java/uk/gov/gchq/gaffer/commonutil/StringUtil.java
0% <0%> (ø)
0 <0> (?)

...ava/uk/gov/gchq/gaffer/store/ElementValidator.java
71.42% <0%> (-3.04%)
0 <0> (-16)

...n/java/uk/gov/gchq/gaffer/commonutil/ByteUtil.java
0% <0%> (ø)
0 <0> (?)

...q/gaffer/store/schema/SchemaElementDefinition.java
61.01% <0%> (-0.35%)
0 <0> (-38)

...re/coprocessor/processor/GroupFilterProcessor.java
100% <100%> (ø)
0 <0> (?)

...r/hbasestore/coprocessor/scanner/StoreScanner.java
100% <100%> (ø)
0 <0> (?)

...ffer/hbasestore/coprocessor/GafferCoprocessor.java
100% <100%> (ø)
0 <0> (?)

...essor/processor/PreAggregationFilterProcessor.java
100% <100%> (ø)
0 <0> (?)

...ssor/processor/PostAggregationFilterProcessor.java
100% <100%> (ø)
0 <0> (?)

... and 110 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 08293be...4183fe5. Read the comment docs.

I've made the requested changes, so it should be ready for another review. Thanks.


update pattern-matching doc

Hello :)
In my use case, I'm using Success like this Success(json:, viewers_count:), the documentation was missing this use case, so I had some issue finding the right syntax
Let me know if something is not good

Thanks!


Track metadatas lead to huge memory consumption over time

When applying a tracker to a large scale dataset with plenty of metadata, the metadatas property of Tracks grows uncontrollably and ends up dominating the consumed memory. As an example, processing 24-hours worth of AIS data from Europe and the North Atlantic region manages to crash a system with 128GB of RAM!!
The existing StatesLengthLimiter is a handy tool for limiting the length of maintained states history for Tracks, however it does not impose any restrictions to the metadatas property. It would therefore be useful if we could implement an equivalent class that limits the length of the metadatas, so as to avoid memory bottlenecks.

Perhaps we store metadata delta instead of a brand new metadata with each new appended state to a track?


Can the label be a float value?

do a regression by network

yes, it's.
you need to set up regressio objection function

This issue is closed due to lack of activity in the last 90 days. Feel free to ping me to reopen if this is still an active issue. Thanks!


[Bug]:

All of the following criteria must be met

[X] All Requirements must be installed.
[X] Full Latest.log file included. If no file exists then leave this unchecked and state so.

All of the following are optional to answer

[ ] Tried reinstalling the Game.
[ ] Tried reinstalling MelonLoader.
[ ] Tried restarting PC.
[ ] Was able to see the Start Screen.

Describe the issue.
Internal FailureFailed to initialize MelonLoader: Failed to load library!确定内部故障初始化MelonLoader失败:加载库失败!确定

Did you attach your log file?

[ ] Yes, I attached my log file to the text box above.
[ ] No, I could not find a log file at {Game_Directory}\MelonLoader\Latest.log

This is most likely caused by Unicode characters in the path, similar to #497


Controller by function not working when templateProvider is used

Setting the controller by function does not seem to work when setting the template with the templateProvider
Does not load the controller
templateProvider: function ($http, $stateParams, OBJ) {
   ...
},
controller: function () {
    return 'view2Ctrl';
}

...while this loads the controller
templateProvider: function ($http, $stateParams, OBJ) {
   ...
},
controller: 'view2Ctrl'

See this plnkr for an example.
The controller should print "loaded view2Ctrl" to the console on load

Okey so I just tried to use controllerProvider instead and it seems to work
controllerProvider: function () {
    return 'view2Ctrl';
}

is this the correct way to do this? Or was I just lucky?

okey sorry missed this in docs, closing this


Caching of "generic" previews is incorrect

Right now we cache all of our previews, like converted Markdown and plain text.
We also cache the "generic" preview for files of an otherwise unrecognized type. This preview template can present a variety of file meta-data like title, description, etc. However, this meta-data can change (at least, be appended) after the preview is generated, in which case the preview becomes stale.
We should probably always generate generic previews in real time. In which case, we probably want to hit the database once, load all of the relevant meta-data, and then write out the preview.

We need an API for loading several meta-data attributes at once. Then we should load all of the meta-data for all of the results in one transaction. We know the template fields in advance, although we don't necessarily know whether the generic preview will be used...?


Allow to override build date with SOURCE_DATE_EPOCH

Allow to override build date with SOURCE_DATE_EPOCH
in order to make builds reproducible.
See https://reproducible-builds.org/ for why this is good
and https://reproducible-builds.org/specs/source-date-epoch/
for the definition of this variable.
This date call only works with GNU date.
This PR was done while working on reproducible builds for openSUSE.

Thanks for the submission!

@bmwiedemann do you need me to tag a new release so that we can build a new package with this patch?

It is sufficient, if the next release is within the next 6 months.


Update aws-java-sdk-bundle to 1.12.364

Updates com.amazonaws:aws-java-sdk-bundle from 1.12.360 to 1.12.364.
I'll automatically update this PR to resolve conflicts as long as you don't change it yourself.
If you'd like to skip this version, you can just close this PR. If you have any feedback, just mention me in the comments below.
Configure Scala Steward for your repository with a .scala-steward.conf file.
Have a fantastic day writing Scala!

Adjust future updates
Add this to your .scala-steward.conf file to ignore future updates of this dependency:
updates.ignore = [ { groupId = "com.amazonaws", artifactId = "aws-java-sdk-bundle" } ]

Or, add this to slow down future updates of this dependency:
dependencyOverrides = [{
  pullRequests = { frequency = "@monthly" },
  dependency = { groupId = "com.amazonaws", artifactId = "aws-java-sdk-bundle" }
}]

labels: library-update, early-semver-patch, semver-spec-patch, commit-count:1

Superseded by #2440.


Device List and Rack Group Filter

Minor little thing (probably a typo):
In 1.6.1-r1 I noticed that when I show a device list (Devices -> Devices), the filter choices under "Rack Group" aren't a list of the Rack Groups, but a list of the Sites.
The "Rack Group" filter under "Racks -> Racks" is perfectly fine.
Sorry - I don't know if it's a new thing or if it has been there and I just didn't notice sooner

Sigh

Don't beat yourself up @jeremystretch
Just want to chime in to thank you for the hard work. Our company appreciates the wonderful software.


[FEAT] Unique Code Generation for New Chat Groups

Generate unique alphanumeric codes of 5-6 characters for each new chat group.
Ensure that the generated codes are unique across all existing groups.
Consider scalability and performance implications, especially as the number of groups grows.
Integrate the code generation logic into the process of creating new chat groups.
There should be a new input when a user is joining a group. A user can join a group by entering group name or unique code.
There should be a option for the Admin to copy the group name or unique code.

If you have any doubts, feel free to ask in comments.

Hi @jatiinyadav , I would like to work on this issue. Can you assignee it to me ?

Hi @pankildoshi,
Any updates?

Hi @jatiinyadav ,
Yes, I have created Seevice for creating Unique code and I have updated Create and Join group methods accordingly.
On UI side I'm thinking, once user creates the room they should see a pop up/modal for room code with copy button. Also code can be copied from chat room. Currently working on UI part.
If you have any suggestions or specifics please let me know. I'll try to close this as soon as possible.

But Does that mean We want to allow users to join Room with Group Code as well as Group Name? Can you clarify this for me?

Okay @jatiinyadav , Instead of popup, I'll keep two buttons like these.
But Does that mean We want to allow users to join Room with Group Code as well as Group Name? Can you clarify this for me?

Yes