functional-tester:Integrate etcd runner into etcd tester

exposed etcd runner logic as a lib
incorporate etcd runner lib to etcd-tester
FIX #7026

all fixed. PTAL cc\ @heyitsanthony @xiang90 @gyuho

Have you tried running locally?

@gyuho @xiang90 , i have tried to run it locally with watcher and lock-racer turned on. they run without any problem. however, i noticed that watcher takes 10-20 to finish.

@fanminshi
The runner stressers relies on the checking logic in the runner itself. So check() actually does nothing, right?
However, if the round finishes before the checking happens inside the runner, then the runner can be canceled without doing any checks. Right?

Will the runner have to complete a round before the tester can try the next fault for the checking to be effective? It seems like that strategy will make the test case rate unacceptably slow.

@xiang90 the checking logic is in the runner itself. all check() in tester does it to make sure there aren't any error returned by runner. no error => check() passes.
the round can't finish without runner being finished. so all the internal checking phase will be part of the round. However, if we cancel the context before runner does its internal check, then runner will not perform its check and return us a cancelled context error.

@heyitsanthony yeah, the current implementation is to have the runner finish its business within a tester round before starting the next one. it is quite slow since watcher might take 20 seconds to finish.

@fanminshi that is too slow to be useful; that's why the lease stresser had to be redesigned.
Two comments:

This requires a lot of changes to the runner code; I'm not sure that the solution is to compile everything into a single binary. A more extensible way of doing, which won't mean trying to shoehorn it into the tester interfaces, would be to have a stresser that will launch an arbitrary binary + arguments, instead of  baking handling specific runner handling into the etcd-tester code. If it's designed right, this can be reused to run the benchmark tool as well. This is also something that could be useful for namazu testing.  The check phase would get its data from stderr.

If the runner expects to run on the cluster long term, perhaps the way to handle it is to launch the runner binary and SIGSTOP on cancel() to pause it then SIGCONT on the next stress().

@heyitsanthony I'll think about the design a bit more.

close this in favor of #7672


new students Richa added

@rk05-lenavo Your PR is literally an empty Markdown file.
Please do not spam


"'str' object has no attribute 'get'" error using parameter file and --handle-extended-json-format

**Describe the bug
Command Name
az deployment create --location WestUS --template-file ./master1.json --parameters @master1.dev.params.json --handle-extended-json-format
Errors:
'str' object has no attribute 'get'

To Reproduce:
Steps to reproduce the behavior. Note that argument values have been redacted, as they may contain sensitive information.

Use these files:
bug.zip
az deployment create --location WestUS --template-file ./master1.json --parameters @master1.dev.params.json --handle-extended-json-format
!) error

NOTE: If I leave out the parameter file (use a defaultValue for the param) or leave off --handle-extended-json-format (but I need that because I normally hande commets), everything works fine
Expected Behavior
Should begin deployment
Environment Summary
macOS-10.14.6-x86_64-i386-64bit
Python 3.8.1
Shell: bash

azure-cli 2.0.80 *

Additional Context

add to S172

@StephenWeatherford Hi, could you please upgrade the version of CLI to the latest version (2.8.0) and have a try?

Because there is no reply to this question for a long time, I will close it temporarily. If you have any questions, please feel free to let us know.


Kotlin. Not able to call "to" method in module.

Hello,
I ran into one annoying problem, here is the code snippet:
toothpick.config.Module

class MyModule : Module() {
    fun test(a: Class<*>, b: Class<*>) {
        bind(a).to(b)
    }
}

Problem here is that it actually calls extension method "to" which is used to create pairs and I can't avoid it. Event if I select proper method in auto-complete it still uses extension one. I believe there is a limitation of Kotlin. What do you think is the best way to workaround? Maybe provide alternative method, say "bindTo"?
Thanks!

My fault, sorry, the solution is:
    fun <A: Any, B: A> test(a: Class<A>, b: Class<B>) {
        bind(a).to(b)
    }

Thx for closing and giving the answers to others.
2018-05-18 13:54 GMT-07:00 Arkadii Ivanov<EMAIL_ADDRESS>
My fault, sorry, the solution is:
fun <A: Any, B: A> test(a: Class<A>, b: Class<B>) {
    bind(a).to(b)
}

—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/stephanenicolas/toothpick/issues/292#issuecomment-390329653,
or mute the thread
https://github.com/notifications/unsubscribe-auth/ABv33e_otqG9Tb4QYPf54ufnv_zn3H5Hks5tzzUegaJpZM4UFViu
.


BUG off-by-one error in test for binning

@damonge I found this error while building this conda package.

Ah, good catch. Thanks!


fix: Improve Request.user_data serialization

resolves #524

This adds validation to Request.user_data so that the user cannot pass in data that is not JSON-serializable.

I just wonder whether we should not separate "user data" and "our Crawlee metadata". Currently, everything is stored in the user_data field. Let's say the Request would have 2 fields - user_data and crawlee_data / crawlee_metadata. Or is there any problem/drawback with this separation?

Something something platform :slightly_smiling_face: We need to persist this stuff when running on Apify, so it needs to be a part of user_data in the end. I guess we could separate the representation of "Crawlee Request" and "Payload for enqueue request API call" better, probably with/after #94.

Something something platform 🙂

Correct, the request fields are validated, we cant just add something the platform doesn't expect.


Introduce a way to add custom colours to COLOR_MAP easily.

It would be extremely useful to the end user if they could add their own colours to the COLOR_MAP/PALETTE without having to modify constants.py.
I'm thinking a section in the cfg files could be added with the entry CUSTOM_COLORS or similar, and the dictionary corresponding to it could be merged with COLOR_MAP at runtime?

I like your suggestion!

Related to #310

Is there a way to do this with the Enum implemented in #342 ?

I'm not sure that Enum should be implemented at all. I think we should discuss/implement/close #342 before coming back and reconsidering this one .

In matplotlib one can set default colourmaps like this:
import matplotlib.pyplot as plt
plt.set_cmap('coolwarm')

can we maybe have a similar approach?
So the idea is:
all colours already have their variables, like WHITE, BLACK, YELLOW etc.
which are called like this in
WHITE = Colors.white.value
colors.py,
but what actually is the colours is looked up by what colormap is currently active.

but what actually is the colours is looked up by what colormap is currently active.

I don't understand what you mean by this.
Also, before implementing anything more on colors, I'd like to finish and close #342. It's stuck on needing more feedback because the proposed implementation doesn't seem to fix all existing problems.

This was being blocked by #342, which was actually superseded by #488, which has been merged. So let's pick this one back up.
@kolibril13 I think I understand you now! Is this what you mean?
>>> import manim as mn
>>> from manim import color as C
>>> C.RED
'#FC6255'
>>> mn.set_cmap("logo")
>>> C.RED
'#E07A5A'    # <-- our logo's red

Yess, exactly!

I think I'm onboard with this in general. However, note there will be a big difference between matplotlib and manim. When you change colormap in matplotlib, it changes the default color that it uses when you don't specify a color. For example, the color of the line plotted by plt.plot(x, y) changes. But even after choosing a colormap, you can do plt.plot(x, y, c='r') and it will use the standard red.
The example above actually changes what C.RED means. Which is distinctly different to the above. So I'm not entirely sold yet. Would like to see what others think.

#784 I believe this plugin feature could handle this issue as soon as it's merged in. One could create a plugin, manim-ThemeManager which could be responsible for handling color maps (i.e. this doesn't have to be part of core manim). How the author of such a plugin wishes to treat this is entirely up to them, but a suggestion would be to have predefined color palettes in a convenient format like json.
>>> from manim import *
>>> from manim_thememanager import tm
>>> tm.set_style("DarkTheme.json")
>>> tm.set_highlights("OtherTheme.json")
>>> # Do rest of project code using custom color
>>> Circle(color=tm.RED) # or something similar

I think I like that idea. This allows for a clean core and complete freedom to determine how color themes work.


1855/pagination toggle

What's included?
Toggle button for pagination on application lists; withdrawn, draft and applied, switches between 'old' previous/next pagination, and alphabetical pagination.
Who should test?
✅ Product owner
✅ Developers
✅ UTG
How to test?

visit the withdrawn, draft and applied list pages
toggle pagination type
test pagination functionality.

Risk - how likely is this to impact other areas?
🟢 No risk - this is a self-contained piece of work
🟠 Medium risk - this does change code that is shared with other areas
🔴 High risk - this includes a lot of changes to shared code
Additional context

PREVIEW:DEVELOP
can be OFF, DEVELOP or STAGING

muted a failing test suite so i can get the preview url up and running, will not merge this branch until the suite is fixed


"...: unary operator expected" error building on Windows 7

I just fetched the latest master branch and ran script/build.sh from a Cygwin terminal window:
Retrieving lein-cljsbuild/cljs-compat/1.0.0-SNAPSHOT/cljs-compat-1.0.0-20151218.091126-41.pom from clojars
Retrieving lein-cljsbuild/cljs-compat/1.0.0-SNAPSHOT/cljs-compat-1.0.0-20151218.091126-41.jar from clojars
script/build.sh: line 17: [: /cygdrive/c/Program: unary operator expected
Please install npm before running this script.

I was able to get the script to work by changing line 17 to quote the which command, e.g.  "`which npm`" instead of just `which npm`.
I'll submit a PR with this change in a few minutes.

PR #2115 fixes this for me.

Closed by #2115


CP-121: Django 1.9 Upgrade (backwards compatible changes, part 2)

See an overview of the changes here.

Looks good :shipit:

We removed this as a dependency, closing.


[Bug]: "$" Symbol Included When Copying Commands

Bug Summary
"$" Symbol Included When Copying Commands
Bug Description
When users attempt to copy commands from the documentation (such as npm install, npm start, etc.), the $ symbol is included in the copied text. This leads to errors when they paste and run the commands in the terminal, as the $ symbol is not part of the command and causes a failure in execution.
Steps to Reproduce

Go to the readme file .
Click on any of the provided command blocks (e.g., $ npm install).
Copy the command.
Paste it into the terminal and attempt to execute it.

Expected Behavior
Users should be able to copy commands without the $ symbol. Only the command itself (e.g., npm install) should be copied to avoid terminal errors.
Actual Behavior
The $ symbol is included when users copy the commands, causing the terminal to throw an error.
Screenshots or Logs (Optional)

After coping one of them , here is the paste result
$ npm install
Severity
Major - impacts significant functionality
Environment

[X] Local Development
[ ] Staging
[ ] Production
[ ] Other

System Information (Optional)
Chrome

Please assign me this issue.


Borderline by Columbine unsupported.

Check if issue with swaglyrics or whether song lyrics unavailable on Genius.

stripper -> Columbine-Borderline
version -> 0.2.6

added


zhTW localization (Taiwan server)

Added translations for zhTW localization
Added zhTW-specific logic for getting bonusSkills in handlePlayerProfessionStatsV1

I tested your solution and it seems to work fine
I am not merging this PR directly due to many conflicts, but I just added your files and solution manually
Included in 1.7.8+


[BUG] [Warning in PlatformIO projects] Directory "include" is not availaible

** Which version the bug has been detected **
Luos engine 2.4.3
Describe the bug
PlatformIO can't find "include" directory, so the SDK raises a warning.
In Luos engine PlatformIO projects, "inc" directories should be replaced by "include".

Fixed in luos_engine 2.6.0


ci: deploy documentation on releases

Which problem is this PR solving?

#440

Short description of the changes

Add a job in circle ci that deploys docs to the gh-pages branch
Docs deploy when a tag matching /^v\d+\.\d+\.\d+$/ regex is pushed

Codecov Report

Merging #629 into master will decrease coverage by 1.74%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master     #629      +/-   ##
==========================================
- Coverage   92.31%   90.56%   -1.75%
==========================================
  Files         177      175       -2
  Lines        8728     8944     +216
  Branches      758      796      +38
==========================================
+ Hits         8057     8100      +43
- Misses        671      844     +173

Impacted Files
Coverage Δ

...pentelemetry-core/test/internal/validators.test.ts
50% <0%> (-50%)
:arrow_down:

...elemetry-core/test/trace/spancontext-utils.test.ts
55.55% <0%> (-44.45%)
:arrow_down:

...lemetry-core/test/trace/ProbabilitySampler.test.ts
56.52% <0%> (-43.48%)
:arrow_down:

...s/opentelemetry-core/test/trace/NoopTracer.test.ts
60% <0%> (-40%)
:arrow_down:

...s/opentelemetry-core/test/context/B3Format.test.ts
63.39% <0%> (-36.61%)
:arrow_down:

...ges/opentelemetry-core/test/trace/NoopSpan.test.ts
63.63% <0%> (-36.37%)
:arrow_down:

...s/opentelemetry-core/test/trace/tracestate.test.ts
65.06% <0%> (-34.94%)
:arrow_down:

...ntelemetry-core/test/trace/NoRecordingSpan.test.ts
71.42% <0%> (-28.58%)
:arrow_down:

...ackages/opentelemetry-core/src/platform/node/id.ts
71.42% <0%> (-28.58%)
:arrow_down:

...ges/opentelemetry-plugin-https/test/utils/utils.ts
33.33% <0%> (-26.67%)
:arrow_down:

... and 40 more

@open-telemetry/javascript-approvers we need more reviews for this one!

Last question: what will be the domain name for gh-pages(documentation) after last change?

https://open-telemetry.github.io/opentelemetry-js/

@mayurkale22 now that this is merged, someone with access to settings has to enable gh-pages. I don't have access.

@mayurkale22 now that this is merged, someone with access to settings has to enable gh-pages. I don't have access.

Even I don't have access to settings tab, maybe @tedsuo can help here.

I asked in gitter, but nobody responded


1848 Fix broken unpkg links for redux-saga

| ------------------------ | ---  |
| Fixed Issues?            | Fixes #1848  |
| Patch: Bug Fix?          |  Yes  |
| Major: Breaking Change?  |  No  |
| Minor: New Feature?      |  No  |
| Tests Added + Pass?      | No |
| Any Dependency Changes?  |  No  |

Fixes broken unpkg links for redux-saga

Thanks!


Fix issue where activities are not synchronised correctly with entities

please create a test to show the issue

Fixed in: 23f4115


Proposed process for writing new guides

A few people have proposed new guides. @bkeepers and I briefly discussed coming up with a process to manage these.
If this looks good I'll rework the existing new-guide issues so they match this format.
cc @kytrinyx @hzoo @thejameskyle @lee-dohm @shazow @TheLarkinn who have discussed new guides
cc @sophshep @jeejkang @brennaheaps for the design part of it

Thanks all for feedback! Made everyone's edits. Also added checkboxes @bkeepers because checklists are great. We can iterate and improve as we learn.


Improved behaviour when decoding nullable values that did not come from the encoder

If a type is nullable and we got None input, we should decode as None and not the _NULL_TYPE class.
Otherwise it causes strange behaviour

I think this would break the from_dict. For example:
  @dataclass
  class PayloadWithNullable(InputModel):
      required: str
      opt_nullable: Nullable[Optional[str]] = None

# ...
assert PayloadWithNullable.from({'required': 'foo'}) == PayloadWithNullable(required='foo', opt_nullable=None)
assert PayloadWithNullable.from({'required': 'foo', 'opt_nullable': None}) == PayloadWithNullable(required='foo', opt_nullable=NULL)

Those asserts are both true @jsangilve ?
The second one should also be
assert PayloadWithNullable.from({'required': 'foo', 'opt_nullable': None}) == PayloadWithNullable(required='foo', opt_nullable= None)


Facility changes impact application

In gitlab by @A-Lawrence on Aug 29, 2016, 16:04
As we move forward we don't want facility setting changes to impact an application.
As such, the list of settings below should be copied from the vt_facility row to the vt_application row so they remain as they are at the point of selection.  These settings should be able to be changed by an admin (issue #513):

training_required
statement_required
references_required (qty)
should_perform_checks
will_auto_accept

In gitlab by @A-Lawrence on Aug 29, 2016, 16:04
mentioned in issue #513

In gitlab by @A-Lawrence on Aug 29, 2016, 17:45
mentioned in commit 45603c815a24ddce823f4a4dd2a31b0dcb2e313d

In gitlab by @A-Lawrence on Aug 29, 2016, 17:45
mentioned in commit 4a785c13926206cd0a06ca3152f61f0aebd6844f

In gitlab by @A-Lawrence on Aug 29, 2016, 17:45
mentioned in commit 78dc9cc8fd66848585831adb7130cd5693b364ca

In gitlab by @A-Lawrence on Aug 29, 2016, 17:45
mentioned in commit c08eca033b4669b9c11d1db1f81668ca07c75678

In gitlab by @A-Lawrence on Aug 29, 2016, 17:45
mentioned in commit 13efb4c5a7a271065494a4206ea13265d748182c

In gitlab by @A-Lawrence on Aug 29, 2016, 17:45
mentioned in commit a0635a54cfced65820336b5af04fae1eb8c563e6

In gitlab by @A-Lawrence on Aug 29, 2016, 17:45
mentioned in commit da67a5693bc985a44d70c115d8a64513611b5117

In gitlab by @A-Lawrence on Aug 29, 2016, 17:45
mentioned in commit e9d06c1f3bd421def725c944742987d3bd13fd33

In gitlab by @A-Lawrence on Aug 29, 2016, 17:45
mentioned in commit 4167a8c296222292560741a742f77f2fb6a68443

In gitlab by @A-Lawrence on Aug 29, 2016, 17:45
Status changed to closed by commit a486d5e491c0828ac59c9d991b5bc857e85c7cf0

In gitlab by @A-Lawrence on Aug 29, 2016, 17:45
Removed ~160393 label

In gitlab by @A-Lawrence on Aug 30, 2016, 23:15
mentioned in commit a486d5e491c0828ac59c9d991b5bc857e85c7cf0


btScalar: Don't use SSE intrinsics on MSVC ARM (UWP)

Without this change build would fail at least for UWP ARM targets with MSVC 2017.

Bump :)

Bump :)


Live Chart: 405 Status (Method Not Allowed)

Steps to repro:

git clone https://github.com/dsuryd/dotnetify-react-demo-vs2017.git
Launch VS2017 with the solution file in LiveChart/
Right-click on project.json and select Restore Packages
Run in Debug or Release mode (with IIS Express or LiveChart with Chrome)
See a blank chart in web browser. View the javascript console to see:

OPTIONS http://localhost:61201/dotnetify 405 (Method Not Allowed)

The example was outdated.  The latest should not give you any more problem.

That fixed it, thanks! (There are problems with the other two React template projects, I'll post a new ticket)


Keep factories updates

Currently, the system allows a single-shot update of fully backed keep factory and keep factory selector addresses. KEEP staked factory address is not upgradeable.
In this PR we added a possibility to upgrade all three addresses within a certain time period (180 days) from the system initialization.
This is a two-step upgrade that can be finalized after 48 hours of governance delay.
To begin the upgrade owner has to provide three addresses:

KEEP-stake backed keep factory,
ETH-only-bonded keep factory,
Keep factory selector.

It is required that KEEP-stake backed factory address is always provided to a valid value different than 0. Remaining two addresses are optional for the system to work, so zero addresses are allowed. This is also a safety switch that lets us disable fully backed keep factory and operate only on KEEP-staked factory.

👀

Went through the code, agree with all @Shadowfiend's comments, and posted 3 more. Other than that, it looks good to me. Waiting for the updates! 🙌

I am excited, it's much simpler than https://github.com/keep-network/tbtc/pull/722 and I am no longer worried about gas cost.

It's ready for a next round.

Something went awry with linting, not clear what happened. Going to give it an extra run.


Merge upstream

Just get our fork in line with upstream which includes all the changes we have made.

Nevermind Mctalian already opened this PR


Fix NameError when execute Rails/HttpStatus cop without Rack

Rails/HttpStatus cop with symbolic style raise NameError (uninitialized constant Rack).
class FooController < ApplicationController
  def bar
    render :foo, status: 418
  end
end

$ rubocop --only Rails/HttpStatus app/controllers/foo_controller.rb -d
For /Users/onaka/sample_app: configuration from /Users/onaka/.gem/ruby/2.6.0/gems/rubocop-0.54.0/config/default.yml
Inheriting configuration from /Users/onaka/.gem/ruby/2.6.0/gems/rubocop-0.54.0/config/enabled.yml
Inheriting configuration from /Users/onaka/.gem/ruby/2.6.0/gems/rubocop-0.54.0/config/disabled.yml
Inspecting 1 file
Scanning /Users/onaka/sample_app/app/controllers/foo_controller.rb
An error occurred while Rails/HttpStatus cop was inspecting /Users/onaka/sample_app/app/controllers/foo_controller.rb:3:4.
uninitialized constant Rack
Did you mean?  Racc
/Users/onaka/.gem/ruby/2.6.0/gems/rubocop-0.54.0/lib/rubocop/cop/rails/http_status.rb:131:in `custom_http_status_code?'
/Users/onaka/.gem/ruby/2.6.0/gems/rubocop-0.54.0/lib/rubocop/cop/rails/http_status.rb:104:in `offensive?'
...

I think that there are 3 solutions.

Add rack gem in runtime dependency

Too strong solution.
I want to extract Rails cops to another gem. :cry:

Disable this cop if rack cannot be loaded

I failed to find a way to notify the user to install rack gem to enable this cop.  :thinking:

Disable custom_http_status_code? check if rack cannot be loaded

This makes false positive in case of HTTP status which can not be written as symbol.
This solution needs to tell the user to install Rack to know why false positives exist.

3 and tell to users via Offense Message is better.
What do you think?
Replace this text with a summary of the changes in your PR.
The more detailed you are, the better.

Before submitting the PR make sure the following are checked:

[x] Wrote good commit messages.
[ ] Commit message starts with [Fix #issue-number] (if the related issue exists).
[x] Feature branch is up-to-date with master (if not - rebase it).
[x] Squashed related commits together.
[ ] Added tests.
[x] Added an entry to the Changelog if the new code introduces user-observable changes. See changelog entry format.
[x] The PR relates to only one subject with a clear title
and description in grammatically correct, complete sentences.
[x] Run rake default or rake parallel. It executes all tests and RuboCop for itself, and generates the documentation.

I failed to find a way to notify the user to install rack gem to enable this cop. 🤔

That'd be my preference and I thought this is what we had implemented.
//cc @anthony-robin

We really need to decide what exactly are we doing here. Maybe it's best to just drop this cop completely, as it relies on Rack being loaded, which I assume almost no one does while running RuboCop. Guess I didn't think enough when reviewing the original PR.

Or we can try to require rack and make the cop a no-op if that fails. For some reason I thought this was how the cop was working, but then I didn't think that often you'd run RuboCop without bundle exec and then gems like rack won't be present.

I like to drop the cop. But I think that dependent to Rack gem is also good.

But I think that dependent to Rack gem is also good.

It'd be odd to have a direct dependency to something that's optional. I'd rather just drop this cop if I have to choose between the two.

@onk

I failed to find a way to notify the user to install rack gem to enable this cop. 🤔

My suggestion won't lead to the best code, but what about having a warning if we were unable to load Rack and define the class body otherwise? Something like...
class HttpStatus < Cop
  require 'rack/utils'
  include ConfigurableEnforcedStyle

  def_node_matcher :http_status, <<-PATTERN
    {
      (send nil? {:render :redirect_to} _ $hash)
      (send nil? {:render :redirect_to} $hash)
    }
  PATTERN

  def_node_matcher :status_pair?, <<-PATTERN
    (pair (sym :status) ${int sym})
  PATTERN

  # ...
rescue LoadError
  warn Rainbow('HttpStatus cop requires Rack. I am really sorry').yellow
end

I'm closing this PR due to no recent activity. Feel free to re-open it if you ever come back to it.

@akhramov That's a reasonable approach as far as I'm concerned.


how to load external url from ionic2 app and listen page event?

Ionic version:  (check one with "x")
[ ] 1.x
[x ] 2.x
I'm submitting a ...  (check one with "x")
[ ] bug report
[ ] feature request
[ x ] support request => Please do not submit support requests here, use one of these channels: https://forum.ionicframework.com/ or http://ionicworldwide.herokuapp.com/
Current behavior:

Hi guys, i want to load external url inside my ionic2 app, though i find  that "cordova-plugin-inappbrowser" provides a web browser view that displays web page, but i want to display this web page as a division of my ionic2 app, then i find that "iframe" tag can embed a webpage inside my ionic2 page, but how to listen web page event? is there a efficient way to achieve this goal than "iframe" tag?
Expected behavior:

i expect there is a efficient way to load external url inside my ionic2 app, and listen this web page event.
Steps to reproduce:

Related code:
insert any relevant code here

Other information:

Ionic info: (run ionic info from a terminal/cmd prompt and paste output below):
insert the output from ionic info here

you are probably better off asking at https://forum.ionicframework.com/
The forums are a better place to ask questions where as github is more focused for specific bug reports.

Hello! Thanks for opening an issue with us! As this seems like more of a support question i will urge that you ask this question on our forum or on our slack channel. Thanks for using Ionic!

Thanks, i will ask this question on ionicframework forum.


Attach images to notes

Is your feature request related to a problem? Please describe.
I intend to add image feature where users can attach image while writing their notes so that they can effectively express their artwork
Describe the solution you'd like
No response
Describe alternatives you've considered
No response
Additional context
No response
Code of Conduct

[X] I agree to follow this project's Code of Conduct

@Vaibhav2002 @Suryansh1720001 I want to work on this feature as a part of Gssoc2023. Could you assign this issue to me

@ManogjnaSinguluri i have a better idea, can you try adding markdown support in the editor, so users can write in markdown format, user can add images, add headings and all markdown formatting. The content is also display with the markdown formatting.
Can you do this?

Great! Sure I will do that

Great! Sure I will do that

Closing this issue


Add she's not in love with the concept by KMB and Eden

Song Name
she's not in love with the concept
Artist Name
KMB and Eden
Source
Youtube
Youtube Link
fNqWpUVbx_c
Direct File Link
No response
Song ID
766165
Start Offset [ms]
0
Extra
Created from Auto Nong.
Created for level: 58825144

accept


[v2.9] EKS: Cluster details not displayed

Setup
Rancher version: v2.9-3c48a195381ad55f9fef7e9bf32b1593d43368ca-head
Browser type & version: Chrome latest
Describe the bug
AKS (Vue UI): Cluster details not displayed, Subnet and service role information is missing.
To Reproduce

Create EKS cluster and import it from Rancher UI
Once cluster becomes Active, edit cluster and check the fields

Screenshots

Spec:
eksConfig:
    amazonCredentialSecret: cattle-global-data:cc-4v4rm
    displayName: cpinjani-eks29
    ebsCSIDriver: null
    imported: false
    kmsKey: null
    kubernetesVersion: '1.28'
    loggingTypes: []
    nodeGroups:
      - arm: null
        desiredSize: 1
        diskSize: 20
        ec2SshKey: null
        gpu: false
        imageId: null
        instanceType: t3.medium
        labels: {}
        launchTemplate: null
        maxSize: 1
        minSize: 1
        nodeRole: >-
          arn:aws:iam::REDACTED:role/cpinjani-eks29-node-instance-role-REDACTED
        nodegroupName: group1
        requestSpotInstances: false
        resourceTags: {}
        spotInstanceTypes: null
        subnets:
          - subnet-08d04305e92081795
          - subnet-02b9ee3a4ea2fab0d
          - subnet-07e95c09365177dfd
        tags: {}
        userData: null
        version: '1.28'
    privateAccess: false
    publicAccess: true
    publicAccessSources:
      - <IP_ADDRESS>/0
    region: us-west-2
    secretsEncryption: false
    securityGroups: []
    serviceRole: null
    subnets: []
    tags: {}

will be a combination of automated and manual testing. moving to To Test

Validation passed, details are being displayed https://github.com/rancher/dashboard/issues/11412#issuecomment-2233277767


Hydrus friendly log files

Hydrus allows you to import tags from txt files with matching filenames. The current log files that Grabber is able to generate almost work, but it adds all the tags to one line with no separators. Hydrus imports the tags per line, so you end up with one giant tag for stuff like %general% or %all%. Which of course makes sense for filenames, but doesn't work out so well for the text files.
for example if you use something like:
%all:includenamespace,excludenamespace=general,unsafe%
rating:%rating%
%general%
you get:
copyright:something character:char1 character:char2
rating:safe
tag1 tag2 tag3
instead of what hydrus would expect:
copyright:something
character:char1
character:char2
rating:safe
tag1
tag2
tag3
Or even simply separating the tags with commas would at least make it possible to run the txt files through some regex to replace the commas with line breaks.
Maybe there's a way to do all this already and I'm just being a bozo?
JetBoom has made a script that does it along side a greasemonkey script, if that is helpful in any way.

Why don't you simply set your separator to "new line"?
Something like this should do the trick:
 %all:includenamespace,excludenamespace=general,unsafe,separator=\n%
rating:%rating%
%general,separator=\n%

Both \n and \r are supported IIRC.

That works perfectly, thank you. I'm a bozo after all, for not seeing that. It's even right next to the namespace stuff I was looking at >.<
I had included %general% separately in an attempt to get it to list after the namespaced stuff. Doesn't seem like it does that though, it doesn't make a difference when importing the tags anyways, so that's fine.
Another quick question. Is there any way to retroactively generate these txt files for images that have already been downloaded? Similar to the "rename existing images" tool?

@AdvancedNeanderthal, out of curiosity, what's the point of using the two programs interchangeably? For me, Grabber does everything I'm looking for.

I use Hydrus for tagging and managing the files I have already downloaded, including non booru related stuff like video and various media. It also allows you to sync with public tag repositories. It actually does have a built in way of downloading from various boorus, but I just prefer Grabber in that respect. Mainly because the Hydrus downloader ignores a lot of namespaces (like rating) and doesn't browse thumbnails, it simply mass downloads everything from whatever tags you feed it.

I use Hydrus for tagging and managing the files I have already downloaded, including non booru related stuff like video and various media.

Except for the "including non booru related stuff like video and various media" part, wouldn't the rest of the usage be covered by having a local booru fed by Grabber?
Or is the fact that everything is self-contained on the filesystem through files (therefore not locking you with any specific software or booru) an important reason?
Just curious because I've been asked many times to include a booru directly inside Grabber, so I'm wondering if being compatible with Hydrus files would be a "good enough" solution.
Also curious because I definitely should try Hydrus, given how messy is my filesystem.

It also allows you to sync with public tag repositories

What's a "public tag repositories" if I may ask? :smile:

Another quick question. Is there any way to retroactively generate these txt files for images that have already been downloaded? Similar to the "rename existing images" tool?

Not currently AFAIK, but that's totally feasible.
I created an issue to track this suggestion, see issue #1008. :+1:
I'll close this one in the meantime.

I do like the idea of using Grabber, rather than a local booru. For some reason, I really like using the app. But it works fine to use a local booru, and that's what I've done for a long time. The major downside I can see is that the setup time of a locally run board is longer, and I suspect it stumps most casual users.

Except for the "including non booru related stuff like video and various media" part, wouldn't the rest of the usage be covered by having a local booru fed by Grabber?

I haven't used a local booru so I couldn't say for sure. As BarryMode mentioned, Hydrus is likely easier to set up for most people. There's an installer and a portable version that you can simply unpack and run. Adding images can be done by dragging and dropping files or folders into hydrus and checking a box to load the tags from txt files, or pull the tags from the filename via regex. You can also set automatic importing on specified folders. A few other possible points that come to mind:
-"system tags" so you don't have to rely on tags like "new" or "tagme".
-de-duplicates automatically based on hash (on import: adds any new tags, then ignores the duplicate file) & has a built-in method to find visually similar files
-hotkeys and built in media viewer makes tagging and other tasks fairly quick
-portable. Pair it with a portable install of Grabber and you can travel the WORLD with your collection of cute pics. That's what everyone here collects right? kawaii rating:safe -lewd
-although it's easy to get started, it has a lot of "advanced" features and options as well. https://hydrusnetwork.github.io/hydrus/help/index.html
Again, I've never used a local booru so idk if they also do any of these things.

What's a "public tag repositories" if I may ask? :smile:

The public tag repositories are essentially just giant user generated pools of tags mapped to files by their hash value. The main one being the one the dev hosts. It can be messy and inconsistent at times, but is nice for just quickly getting some tags on files that don't have any. You're still better off importing your tags directly from where you got the image imo. More info halfway down this page

Or is the fact that everything is self-contained on the filesystem through files (therefore not locking you with any specific software or booru) an important reason?

It doesn't necessarily lock you in to the software in the sense that you can export your files exactly as they were (txt files and all) but it does store them in a somewhat non human-friendly way. It renames them to their sha256 value then sticks them in a client_files folder, or wherever you specify. It doesn't remove their extensions or modify them in anyway (aside from renaming them) so worst-case scenario; if exporting fails, you could go grab everything from that folder (then use grabber to re-organize everything :smile:). I'd say that this is an important option to have, but if local boorus also have a decent export option and some sort of way to retrieve files in case of catastrophe, I wouldn't give any extra points to hydrus here.

Thanks a lot for the detailed explanation!
Looks like a really interesting software.
I'll definitely give it a go to see if there's things that could be improved in Grabber based on some Hydrus features, as well as trying to improve the compatibility.

collection of cute pics. That's what everyone here collects right? kawaii rating:safe -lewd

... right 👀

It doesn't necessarily lock you in to the software since you can export your files exactly as they were (txt files and all) but it does store them in a somewhat non human-friendly way. It renames them to their sha256 value then sticks them in a client_files folder, or wherever you specify. It doesn't remove their extensions or modify them in anyway (aside from renaming them) so worst-case scenario; if exporting fails, you could go grab everything from that folder (then use grabber to re-organize everything 😄).

That's quite unfortunate that the files are being moved and renamed.
Even symlinks sound more convenient.


Transactions-management app #96

Closes #96
Thank you

heyy @Kritika30032002  please check this pr.

Thanks for your Valuable contribution.
Don't forget to star the repo.


About the idea to further enhance the performance.

Hi, I have conducted experiment minigemini arch to Qwen series model, it has a good performance.
However, the performance didn't strong enough compare to some SOTA small models such as MiniCPMv2 LLavaUHD etc.
Which used a very large input and slicing technology.
As such, am just wonder, how can we further pushing the boundry of mini-gemini, and make mini-gemini great again?
The currently baseline I got from qwen7b is slightly same as gemma7b's on MMMU, but this is actually not very satisfying.
Here are some thoughts to further improve on my mind:

Make larger input resolution on clip-vit, since the final token num are determined by this one, I have tried enlarge 336 -> 448, result in 1024 visual tokens, but surprisely, the result got worser;
Add a Resampler replace MLP, I tried, the loss didn't get converge.

So here is I want talk about: How should we exactly make some improvement?
Hoping for your discussion and insights, guid me on the right path.

I also changed llm to qwen1.5, and the performance will be somewhat improved.

In the encoder section, I replaced it with deepseekvl's hybrid and there was also a small increase.
In the data section, the allava data itself is somewhat dirty, cleared a wave, and then manually translated the Chinese version, and added some interlm-xc data, and it was also increased a bit.

Feel that our directions are very similar, if interested, you can leave the contact information to communicate.

Allava had a Chinese version.  What do u mean by deepseek's hybrid? Minigemini already a hybrid arch.
interlm-xcomposer data could be even more dirty.

There is a Chinese version of Allava, but both the Chinese and English versions are dirty. In the Chinese version of allava, there are many phenomena of picture-text mismatch, translation dislocation and translation hallucination. For example, grep “宁静湖畔” in allava-cn , the result is a high probability of picture and text mismatch. Therefore, it is necessary to clean allava-en and allava-cn, and the addition of allava-cn can also bring about the improvement of indicators.
Minigemini has a mixed structure, but after the experiment, deepseek-vl will be slightly better.
Interlm-xcomposer data, I specifically refer to the sft phase, such as aokvqa, okvqa, lvis data

How did u clean allava data and manually translate to Chinese version? Would share the data after shared? that would be very nice


[Redesign] Package Statistics or Package Version Statistics pages without a "groupby" in the query is empty

Notice that there is no checkboxes:
https://preview-dev.nugettest.org/stats/packages/BaseTestPackage
https://preview-dev.nugettest.org/stats/packages/BaseTestPackage/1.0.0
The page works as expected for:
https://preview-dev.nugettest.org/stats/packages/BaseTestPackage?groupby=Version
https://preview-dev.nugettest.org/stats/packages/BaseTestPackage/1.0.0?groupby=Version
This issue does not appear on live:
https://www.nuget.org/stats/packages/BaseTestPackage

Closed as duplicate of https://github.com/NuGet/NuGetGallery/issues/4174


Subcomponent inside subcomponent

After the new Android studio latest stable update, it is not able to use Subcomponent inside subcomponent.
Sample project : https://github.com/vestrel00/android-dagger-butterknife-mvp.git
Android Studio Details : Android Studio 3.0.1
Build #AI-171.4443003, built on November 9, 2017
JRE: 1.8.0_152-release-915-b01 amd64
JVM: OpenJDK 64-Bit Server VM by JetBrains s.r.o
Windows 10 10.0

Wrong Dagger. github.com/google/dagger is component Dagger.


Feature/34/support wasm

(this is based over #33)
Closes #34.
Attempt to support WASM. This builds and runs in a WASM application, but requires the following PRs:

https://github.com/sebcrozet/instant/pull/17 -- provide Instant::checked_sub. Needs instant release > 0.1.3 (https://github.com/sebcrozet/instant/issues/18)
https://github.com/Amanieu/parking_lot/pull/231 -- use instant::Instant. Needs release > 0.10.2.

Holy heck! That's amazing!!
Thanks so much for these contributions - I'm somewhat time-constrained this week, but I'll try to get them merged this weekend!

Sweet :v:, both the PRs are merged, simply waiting on their release, so we can refer to the released versions in here :rocket:

So, I love this! Two things that I'd like to see in this PR still:

[ ] some way to test this in CI, would hate to accidentally undo this work (if you're not sure how to do that, feel free to send me a snippet that I can try with - I have zero experience with wasm-targeted rust code, but have an idea how to integrate it in the ci system)

[ ] a Changelog entry crediting you! (:

Heya, quality checkboxes, my favourite :v:. I'm halfway through writing CI tests, but it needs a change in wasm-pack (https://github.com/rustwasm/wasm-pack/pull/851) so that wasm-pack doesn't try to compile native crates on the wasm32-unknown-unknown target.

Heya, I got tests running through wasm-pack:
$ wasm-pack test --headless --firefox -- --no-default-features --features "std wasm-bindgen"

Running target/wasm32-unknown-unknown/debug/deps/direct-8375365da32962c5.wasm
Set timeout to 20 seconds...
Running headless tests in Firefox on `http://<IP_ADDRESS>:39841/`
Try find `webdriver.json` for configure browser's capabilities:
Not found
running 7 tests

test direct::correct_wait_time ... ok
test direct::all_capacity_check_rejects_excess ... ok
test direct::rejects_too_many_all ... ok
test direct::never_allows_more_than_capacity_all ... ok
test direct::all_1_identical_to_1 ... ok
test direct::rejects_too_many ... ok
test direct::accepts_first_cell ... ok

test result: ok. 7 passed; 0 failed; 0 ignored
# .. more output

Something that happens in the sinks and streams tests is the elapsed time is not strictly greater than the boundary value, so the > assertion sometimes fails. I've set it to be >= in 4cf4910b432709df1cde4adbfc4864fb28da1428, but I think for true correctness it should be strictly greater than?
Also, the error message from the browser web driver only includes the panic message and no true line number, which is why I copied the assertion operation, so we get:
    error output:
-        panicked at 'elapsed: 200ms', tests/sinks.rs:1:1
+        panicked at 'expected i.elapsed() > Duration::from_millis(200), elapsed: 200ms', tests/sinks.rs:1:1

I haven't updated .circleci config yet, but may call it a day today.

I've updated circleci config, though I wouldn't know if it works until it's run. Also, there is a way to run tests without wasm-pack, which I've tried and works, so if the wasm-pack PR doesn't have any activity for a while then I may switch the implementation.

Heya, long break, but the two dependencies above are published. I've taken them in and rebased over master.
The one item still pending is CI, the PR to update wasm-pack is still pending -- I've just refreshed that as well, so hopefully it's accepted.

Oooh, that's super exciting - I'll check your changes out this weekend, hopefully we can get wasm support shipped soon!

bors try

It looks like the wasm tests you added are failing because it doesn't have jq available... this is weird.
Since the circleci config is auto-generated by cargo template-ci (and so will get overwritten unless we perform trickery), maybe it's easier to install a github action to run the tests in a wasm environment? Maybe https://github.com/marketplace/actions/wasm-pack-action could work there?

Gotcha, shall try that in the next two days :v:

Heya, been spending time on getting wasm-pack to pass through features correctly, need to get that working for the download action to pick it up. Shall come back to this when that one is resolved.


Create standard Merlin dtypes in the merlin.dtypes module

Original Merlin Dtypes proposal slides
This PR creates a merlin.dtype module that provides translations between a standard set of Merlin dtype descriptors and the dtype descriptors from external frameworks that we commonly use or interact with: Numpy, Pandas, cuDF, Tensorflow, Torch, and Triton. It also provides a mechanism for registering new sets of dtypes with mappings to Merlin dtypes. External frameworks are treated as optional and the relevant dtype mappings are only loaded/registered if the necessary packages are available (in order to avoid creating hard dependencies on e.g. deep learning frameworks or inference servers in Merlin Core.)
This has several benefits over using Numpy dtypes:

We can directly represent unknown dtypes with a non-None value without defaulting them to object (like Numpy does)
We can capture information in our dtypes that's used in Pandas/cuDF extension dtypes
We're not forced to do lossy translations between external frameworks with Numpy as a constraining intermediary

It also lets us limit the set of dtype translation tables required to one, since we can use these Merlin dtypes as a Rosetta stone for translating between any pair of frameworks that each provide a Merlin dtype mapping.
There are related PRs adjusting downstream libraries to use these dtypes:

NVTabular: https://github.com/NVIDIA-Merlin/NVTabular/pull/1707
Models: https://github.com/NVIDIA-Merlin/models/pull/912
Systems: https://github.com/NVIDIA-Merlin/systems/pull/239
Dataloader: N/A (no changes required)

Some of the code this PR lays the groundwork for replacing:

Type normalization in ColumnSchema
Type translation when serializing Schema objects to Protobuf files
Type translation between Numpy and DL frameworks in the dataloaders
Type translation between Numpy and Triton types when writing Triton configs
Type translation between Numpy and Feast types when retrieving features

The tests on the downstream repos that run on this PR don't run against the downstream repo branches that adjust for these changes, so they'll continue failing here even if the PR is fine. The tests on the downstream repo PRs do run against this branch, so we should be looking at them to determine when we're ready to merge this.

Also didn't have a place to comment, but we may want to refactor the executor functionality to use the merlin dtypes to detect whether your a list or not. I dont know if that should happen by probing the dtype directly  (for is_list and is_ragged) or by refactoring is_list_dtype.


doc(skeleton-ts-webpack): name in readme

Renamed the title in the readme. Not sure if that was left intentionally. If so remove this pr.

Thanks.


Default template losing 'publicly visible' status when versioned

Please complete the following fields as applicable:
Expected behaviour:
The default template should still be visible on the 'Customizable templates' tab of the templates page and available to researchers when they create a plan.
Actual behaviour:
When the default template is versioned, it's visibility is set to 'organisationally visible' if the org that owns it is not a funder

@briri when i test on roadmap stage the customized default (Digital Curation Centre) template remains visible in the customizable templates table for admins and available to end users creating a new plan. but now I can also see the customized version in the public DMP Templates list (see screenshot). the customized version of the template should not appear in the public list.

ok. this is a larger issue than I originally anticipated. I can exclude the default template from the public templates page, but the current logic behind the create plan page would never find a customized version of the default template.

after further discussion, closing this issue and @briri is creating two new issues to address after template versioning is done


feature suggestion: must use value

so we require explicit chains, but I don't like the look of..
_.chain(a)
    .map('a')
    .forEach((a) => {})
    .value();

I think the code would be clearer and more likely correct if any chains ending in value() are assigned to something, so the above code would have to be
var description = _.chain(a)
    .map('a')
    .value();
_.forEach(description, (a) => {})

and it would prevent chains not being assigned (e.g. useless code)
wdyt?
btw sorry I know I haven't submitted a pr for my last feature but still slowly switching on your rules on our large codebase...

Well, since Lodash v4, forEach and its kind all end implicit chaining, so you could technically write
_(a)
    .map('a')
    .forEach((a) => {})

Which would make this redundant. If you use the chain-style with as-needed, it would warn against this, and then no-double-unwrap would warn against the extra .value().
Also, this would assume that everyone uses each function for its intended use.
I've seen people use map, filter and especially some for side effects, and in some cases it's too hard for the plugin or Eslint itself to check for that.

Yes, im aware we could use implicit chaining but i was outvoted, other developers preferred consistency/simplicity over elegance.
A better description might be "avoidCallsOnlyForSideEffects" with an ignore option or somesuch defaulting to forEach.. i guess that doesnt really address my forEach chain issue unless i make the ignores more specific but it does address my side-effects concern.

And it would be easy to tell if lodash was used only for side effects (basically determine if the parent is a statement), just difficult to tell if it was used for value and side effects (but again possibleb

Possibly related, I've been thinking that there should be a rule about requiring that the output of _.each does not get used, and another that the output of other collection methods DO get used.
This would help prevent people using _.map for side effects only.

Yes, that would be good.

You make a good point - the whole point of giving options to rules like chain-style is not to make assumptions like I just made.
I'd say something like collection-method-value would work.

Good rule, it found 4 cases of confusing code. I am wondering if for my other concern, which is purely stylistic, another rule "disallow-chain-methods"(with option for methods to not allow chaining with) might make sense so I could disallow forEach within a chain ?


fix: Conversion of tabular dataset to tensors

Summary of Changes
Fixed conversion of tabular dataset to tensors and associated tests.

:tada: This PR is included in version 0.25.0 :tada:
The release is available on:

v0.25.0
GitHub release

Your semantic-release bot :package::rocket:


macports: Try building 19.0.2

No point building anything below CX22 as they won’t function on macOS Sonoma without a major overhaul


Update mixer/test/client tests to use dynamic ports

Now they are using fixed ports started from 29000.   In some environment, some of ports are used, the tests fail.

Can we close this issue now?


Test are not included in the report when the Before hook fails

I have code to log in to my application in the before hook , when the log in fails in my report I am only see the before and after execution and not the execution of my tests, I was expecting to see the my tests are listed in the report as failed.
this is my wdio.conf configutaion:
{ 	specs: [ 		'./test/spec/**/*.js' 	], 	maxInstances: 10, 	capabilities: [{ 		maxInstances: 1, 		browserName: '', 	}], 	sync: true, 	logLevel: 'info', 	logOutput: './wdioLogs/', 	outputDir: './wdioLogs/', 	coloredLogs: true, 	deprecationWarnings: false, 	bail: 0, 	screenshotPath: './errorShots/', 	baseUrl: '', 	waitforTimeout: 10000, 	connectionRetryTimeout: 90000, 	connectionRetryCount: 3, 	services: ['selenium-standalone'], 	framework: 'mocha', 	reporters: ['spec', ['allure', { 		disableWebdriverScreenshotsReporting: false, 	}]], 	mochaOpts: { 		ui: 'bdd', 		timeout: 600000 	}, }
I am using webdriverIO 5.7.8 and @wdio/allure-reporter 5.7.8

@raulcabero
First, all v5 reporter issues should be reported in monorepo v5 https://github.com/webdriverio/webdriverio/issues/new/choose
Second,

I am only see the before and after execution and not the execution of my tests, I was expecting to see the my tests are listed in the report as failed.

It is because mocha doesn't run tests if before hook failed. So we don't have any info about what tests do you have.


[B.Tech Tea Shop] Adding content to Blog Section

Describe the Feature you want to end
Using html and adding content relatable

Expected behavior
this helps to know more about the website and products quality

Screenshots (optional)

Additional context (optional )

@MohitGupta121 Kindly, assign this to me.

@SnigdhaP2022 please be sure that you add before and after screenshots in your PR to able to merge it.


Fix update of version in resave.py

@joshmoore This fixes the update of version in newly-generated zarr.
Don't know if the previous approach would be expected to work, but it wasn't doing anything.

Thanks, @will-moore


how to pronounce the word "colcon"?

a simple question : P

col-con
Please see the title of the README of this repo describing the expanded meaning of the name.

thanks


Request: Limitless Bardic/Skaldic Performance Mythic Ability

would be great to include also azata and martyr performances.


mksyscall_windows.go should optionally treat string as UTF16 even if function does not end with W

When creating stubs for Windows DLL routines, mksyscall_windows.go currently maps string parameters to *byte by default and to *uint16 (with UTF-16 conversion) only if the function's name ends in W. There are many Windows routines that take UTF-16 strings but do not end in W. It would be more generally useful if there were a per-syscall or per-parameter option to specify the string width. I'm trying to use mksyscall_windows for a project, and I have to use *uint16 + manual string conversion all over the place because our UTF-16-accepting APIs do not end in W.
(As a side not, it's not clear to me if it's really supported to use mksyscall_windows outside of the go source tree, although there is precedent in some packages on GitHub.)
I'm happy to make the change to mksyscall_windows if someone else will do the bikeshedding for me on how to specify this :). E.g. if I want to import BOOL PathCchIsRoot(PCWSTR), what should I write? The following? Other ideas?
//sys PathCchIsRoot(p string [utf16]) (r bool)

@alexbrainman

... It would be more generally useful if there were a per-syscall or per-parameter option to specify the string width. I'm trying to use mksyscall_windows for a project, and I have to use *uint16 + manual string conversion all over the place because our UTF-16-accepting APIs do not end in W.

Converting Go string into []uint16 is not free. So we're always try to leave it for the caller to decide if that price is worth it.
Also, quite often you have *uint16 field of a struct parameter, rather than *uint16 parameter. You proposal won't handle these.
I don't think it is worth complicating //sys syntax and mksyscall_windows.go code.
But feel free to copy mksyscall_windows.go and change it to your liking. I've done it few times myself.

... (As a side not, it's not clear to me if it's really supported to use mksyscall_windows outside of the go source tree, although there is precedent in some packages on GitHub.)

Use it if it works for you, but be prepared if it breaks your programs and all.
I always use it for my projects - it allows me concentrate on the job rather than spend time making syscalls right. These mistakes can be fatal.
Also mksyscall_windows.go generates GC safe code for syscalls with string parameters (applicable to your case).
Feel free to reopen if I left something out.
Alex


Support PMD code analysis in the Maven task

Hi @HSAR, I'm your friendly neighborhood Microsoft Pull Request Bot (You can call me MSBOT). Thanks for your contribution!

In order for us to evaluate and accept your PR, we ask that you sign a contribution license agreement. It's all electronic and will take just minutes. I promise there's no faxing. https://cla.microsoft.com.

TTYL, MSBOT;

@HSAR, Thanks for signing the contribution license agreement so quickly! Actual humans will now validate the agreement and then evaluate the PR.
Thanks, MSBOT;

@msftclas Signed CLA, although I'm not sure why I needed to as I am a full-time employee of Microsoft.

I've had an email back from Jason regarding the CLA. He has rejected the CLA since it wasn't required, and so there aren't any problems there.

LGTM


Initial cleanup of binders-related code

This is a bunch of small fixes we made while working together with @W95Psp on the binders issue. I kept the non-controversial changes and cleaned them up.

The charon breakage is expected (I changed a type), the fix is straightforward.


interp: fix type check on function signature

Perform function declaration type check from the global scope, to avoid
possible collisions of local variables with package names.
Fixes #957.

Perform function declaration type check from the global scope, to avoid
possible collisions of local variables with package names.
Fixes #957.

Is this commit message above still correct? Because in this one you say we use the global scope, but then in the latest commit you say "use upperLevel instead of global". So which is it? When for each child of the return statement we do
typ, err = nodeType(interp, sc.upperLevel(), returnSig.child[1].fieldType(i))

are we using the global scope or not?

I clarified the commit message.


HMR doesn't works

Looks like HMR doesn't works. When I make some changes in app.css I have full refresh whole page instead of hot swap.

Sorry, not reloading just loosing my state of application. For example make recall to server.

Need console log output to give any help. Also webpack config settings.

I use it only with standard settings from this repo.

I'm pretty sure you need something like style-loader and/ or css-loader to do this. I'll take a look into this more though.

confirmed, see webpack docs for more info on implementing and using these to do hmr with css

you need to run npm run start:hmr

@gdi2290 but I use npm run server:dev:hmr


Python unit.beta._not_found_test.NotFoundTest.test_future_stream_unary_not_found test is flaky

https://grpc-testing.appspot.com/job/gRPC_pull_requests_linux/1799/testReport/junit/(root)/python_linux_opt/py27_test_unit_beta__not_found_test_NotFoundTest/
[0mRunning       unit.beta._not_found_test.NotFoundTest.test_future_stream_unary_not_found
[91mERROR         unit.beta._not_found_test.NotFoundTest.test_future_stream_unary_not_found
[0m2 tests finished:
	1 successful
	1 unsuccessful
	0 skipped
	0 expected failures
	0 unexpected successes
Interrupted Tests:
	[]

Errors/Failures:
[91munit.beta._not_found_test.NotFoundTest.test_future_stream_unary_not_found[0m
[1mtraceback:[0m
Traceback (most recent call last):
  File "/usr/lib/python2.7/unittest/case.py", line 329, in run
    testMethod()
  File "/var/local/git/grpc/src/python/grpcio_tests/tests/unit/beta/_not_found_test.py", line 66, in test_future_stream_unary_not_found
    rpc_future.result()
  File "/var/local/git/grpc/py27/local/lib/python2.7/site-packages/grpc/beta/_client_adaptations.py", line 111, in result
    raise _abortion_error(rpc_error_call)
RemoteError: RemoteError(code=StatusCode.UNKNOWN, details="Exception iterating requests!")

[1mstdout:[0m

[1mstderr:[0m
ERROR:root:Exception iterating requests!
Traceback (most recent call last):
  File "/var/local/git/grpc/py27/local/lib/python2.7/site-packages/grpc/_channel.py", line 203, in consume_request_iterator
    request = next(request_iterator)
TypeError: list object is not an iterator

Unexpected successes: []
Test failure

Seen again: https://grpc-testing.appspot.com/job/gRPC_pull_requests_macos/1817/

@nathanielmanistaatgoogle I'm still seeing this at master head:
Testing gRPC Python...
SUCCESS       unit.beta._not_found_test.NotFoundTest.test_blocking_unary_unary_not_found
Running       unit.beta._not_found_test.NotFoundTest.test_future_stream_unary_not_found
ERROR         unit.beta._not_found_test.NotFoundTest.test_future_stream_unary_not_found
2 tests finished:
	1 successful
	1 unsuccessful
	0 skipped
	0 expected failures
	0 unexpected successes
Interrupted Tests:
	[]

Errors/Failures:
unit.beta._not_found_test.NotFoundTest.test_future_stream_unary_not_found
traceback:
Traceback (most recent call last):
  File "/usr/local/google/home/atash/src/grpc-2/py34/lib/python3.4/site-packages/grpc/beta/_client_adaptations.py", line 109, in result
    return self._future.result(timeout=timeout)
  File "/usr/local/google/home/atash/src/grpc-2/py34/lib/python3.4/site-packages/grpc/_channel.py", line 298, in result
    raise self
grpc._channel._Rendezvous: <_Rendezvous of RPC that terminated with (StatusCode.UNKNOWN, Exception iterating requests!)>

During handling of the above exception, another exception occurred:

Traceback (most recent call last):
  File "/usr/lib/python3.4/unittest/case.py", line 58, in testPartExecutor
    yield
  File "/usr/lib/python3.4/unittest/case.py", line 577, in run
    testMethod()
  File "/usr/local/google/home/atash/src/grpc-2/src/python/grpcio_tests/tests/unit/beta/_not_found_test.py", line 66, in test_future_stream_unary_not_found
    rpc_future.result()
  File "/usr/local/google/home/atash/src/grpc-2/py34/lib/python3.4/site-packages/grpc/beta/_client_adaptations.py", line 111, in result
    raise _abortion_error(rpc_error_call)
grpc.framework.interfaces.face.face.RemoteError: RemoteError(code=StatusCode.UNKNOWN, details="Exception iterating requests!")

stdout:

stderr:
ERROR:root:Exception iterating requests!
Traceback (most recent call last):
  File "/usr/local/google/home/atash/src/grpc-2/py34/lib/python3.4/site-packages/grpc/_channel.py", line 203, in consume_request_iterator
    request = next(request_iterator)
TypeError: 'list' object is not an iterator

Unexpected successes: []
Test failure
FAILED: py34.test.unit.beta._not_found_test.NotFoundTest [ret=1, pid=19568]
FAILED: py34.test.unit.beta._not_found_test.NotFoundTest

Bummer. I'll take another look.

@soltanmm-google: at bd827887ffbb57a95990130f585913b13f44a5b7 this passed for me with ./tools/run_tests/run_tests.py --language=python --newline_on_success --regex=_not_found_test --runs_per_test=1000 --jobs=200. Would you happen to have a means of reproducing a failure?

Closing as this has not been confirmed to have been seen since the integration of pull request 9310 which was authored to fix it.


Submitting Assignment 2 for Python

What changes are you trying to make? (e.g. Adding or removing code, refactoring existing code, adding reports)
==> Completing and submitting assignment-2 for Python in a new assignment-2 branch
What did you learn from the changes you have made?
==> Using numpy to read CSV files, control structures to iterate and summarize data, writing user defined functions to perform special operations on data
Was there another approach you were thinking about making? If so, what approach(es) were you thinking of?
==> As have to work within a predefined structure for writing our code, I have not implemented or explore any other approaches except what was asked in the assignment.
Were there any challenges? If so, what issue(s) did you face? How did you overcome it?
==> Understanding the assignment problem statement, read the available material, Internet search, listening the recording
How were these changes tested?
==> Locally by using the source CSV data and also by creating a duplicate file to run and test each line item of the code
A reference to a related issue in your repository (if applicable)
Checklist

[ ] I can confirm that my changes are working as intended

Hi @pedram-aliniaye-asli
Thanks for your comments. My replies below in bold:

In the patient_summary function, for each operation, you are going to return only one number as a result not a list of numbers. So it can be just simply:
summary_values = np.mean(data, axis=ax)
==>
In this block of code:
if(check_zeros(data_mean)):
return True
else:
return False

Hi @pedram-aliniaye-asli
Thank you for your comments. My replies in Bold below:
++++++
In the patient_summary function, for each operation, you are going to return only one number as a result not a list of numbers. So it can be just simply:
summary_values = np.mean(data, axis=ax)
++++++
==> I'm not sure about this change. The problem asks to find Avg, Min or Max of total 60 patients across 40 days of data. That means we have to perform either average, min or max operations on 40 data points for 60 patients, resulting in unique 60 data sets that are stored in "summary_values" variable as a list/array. It won't be a single number, but 60 unique numbers as can be seen in the output as well. Could you please clarify what you mean by your comments above?
++++++
2) In this block of code:
if(check_zeros(data_mean)):
return True
else:
return False
++++++
==> Understood, I have modified the assignment by removing this redundant if-else condition and have resubmitted it here for your review.
**3) If you remember, in one of our work periods, I asked you the issue I find with the check_zeros(x) pre-defined function. I showed that it is producing wrong result altogether. It will always give False irrespective of the data send to evaluate. It will never return True. We verified that by changing the data that should ideally return True value, but the function still returned False value. You were going to check that and update what should be the right code for this function.
You can change the data set as below and check the function behavior. The existing function will return False even though the expected result should be True for this dataset:
x = [0, 0, 0, 5.9, 5.55, 6.225, 5.975, 6.65, 6.625, 6.525, 6.775, 5.8, 6.225, 5.75, 5.225, 6.3, 6.55, 5.7, 5.85, 6.55, 5.775, 5.825, 6.175, 6.1, 5.8, 6.425, 6.05, 6.025, 6.175, 6.55, 6.175, 6.35, 6.725, 6.125, 7.075, 5.725, 5.925, 6.15, 6.075, 5.75, 5.975, 5.725, 6.3, 5.9, 6.75, 5.925, 7.225, 3, 5.95, 6.275, 5.7, 6.1, 6.825, 5.975, 6.725, 5.7, 6.25, 6.4, 7.05, 5.9]
To get True, you can use the below code to get that value:
flag = [] #Initialising an empty list
for i, val in enumerate(x):
if(val == 0):
flag.append(i)
print(flag)
Let us know all your update on the check_zeros() function in the Slack for everyone to take a note of that.**


Training on Custom dataset

I have a dataset of 4000 images on which I have to train with pretrained weights (let's say yolact_im700_54_800000.pth), I have made changes in backbone.py "strict=True" as told in issue https://github.com/dbolya/yolact/issues/27 . But still, nothing improved after training. It got worse
could someone help me how to train on a new dataset with pretrained weights or how to do transfer learning?

Hey @dbolya
I have tried decreasing the learning rate as you told me but there is no improvement in segmentation and also result of the bounding box got bad.
You can see in the result attached below

You might want to try something like in #334.
Also make sure you're not training too long. With that small of a dataset, 40k training iterations is probably enough.

Thank you so much for your advice @dbolya ..I will get back to you once I m done with the training!

Hey @dbolya , I have tried the method you told me.. I think it will get better by fine-tuning
the model with adjusting learning rate n decay.
But In some results, I am getting double segmentation for the same object as shown below!
Could you tell me why this could be happening

Hey @dbolya , I have tried the method you told me.. I think it will get better by fine-tuning
the model with adjusting learning rate n decay.
But In some results, I am getting double segmentation for the same object as shown below!
Could you tell me why this could be happening

change cross_class_nms from False to True (--cross_class_nms=True)

Hey, I am also trying to do transfer learning on a custom dataset. My questions are:

In what range should the lr be? Currently I am using 1e-4
I start from a pre-trained yolac model (resnet101), but I get

even after training for quite some time.
Do you have any intuition on what could be going wrong? And thanks a lot for this amazing repo @dbolya !

You might want to try something like in #334.
Also make sure you're not training too long. With that small of a dataset, 40k training iterations is probably enough.

I have done as you told me with learning rate

at 1e -5 and a dataset of 2000 with only a single class but still, I m getting very low mAP for the mask.

And also some wrong detections

No detection in this picture

@sree3333 Are you sure your annotations are correct? It's really weird how it almost perfectly segments out some random object and calls it a person, but not the actual person in the center of the image.
And for

I have done as you told me with learning rate

Did you add the .detatch() in #334?

Hi @dbolya , thanks for your quick responses
Yes, I have added .detatch() in #334
Our annotations are good we have checked once again!
I also checked these images with pre-trained weights, it is giving the same result ..It is detecting some other random thing.
Could you please why this could happen!
Thanks a ton for helping me out.

Sorry for the delay on this one. Are you still having this issue? If so, what does the output of the model look like on these images if you don't modify the original code, just use the off the shelf COCO models. The COCO models already should be able to detect people well, so there might be something wrong with your dataset definition.


[Android] Understand How to Migrate Your Existing Android XML Project to Jetpack Compose

Understand How to Migrate Your Existing Android XML Project to Jetpack Compose
Proposed article introduction
If you are a developer and you have a big project that is written in XML, you may  be in need of migrating that Project to Jetpack Compose which is  Android’s modern toolkit for building native UI. It simplifies and accelerates UI development on Android. Quickly bring your app to life with less code, powerful tools, and intuitive Kotlin APIs.
In this tutorial, we will go through step by step of migrating an existing project into fully being a compose project. Also we will look into ways of using XML views in Jetpack compose.
Key takeaways

A detailed guide on how to migrate an XML project to Compose, step by step.
Understanding How to Migrate a single Activity or a Fragment.
Understanding How to Include Views in Compose that don't yet have a composable e.g (Google Maps)

Article quality
This article takes the reader beyond what is provided in the official documentation and teaches the reader the way of migrating an existing project to compose. Also, the article tries and explains how to use XML Views in Compose in components that do not have composables yet e.g Google Maps. The same content isn't fully explained well on other blog sites.
References
N/A

https://www.youtube.com/watch?v=Pur_0KroFR8

https://www.youtube.com/watch?v=Pur_0KroFR8

Hello @WanjaMIKE thank you pointing out
I agree that the video also tries to explain what I am planning to write, but some people prefer understanding something that is written rather than watching a video and forwarding it to the part that he/she wants.
An article is easy to skim and scan to the part that interests you.
Thank you in advance.

Also @WanjaMIKE
Google has a codelab on the same which has a lot of content and well explained steps so I don't think your article would provide a lot of original content.


Playback Buttons Vanish When Playback Queue in Focus

I have checked that there are no issues with similar or the same content
I have checked the FAQ (https://github.com/MarshallOfSound/Google-Play-Music-Desktop-Player-UNOFFICIAL-/wiki/FAQ) and the answer I am looking for is not there
I have double checked and can reproduce the issue

Program Version: google-play-music-desktop-player-3.6.0-1.x86_64
OS:  Fedora 24
uname -a
Linux  4.7.4-200.fc24.x86_64 #1 SMP Thu Sep 15 18:42:09 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux
Description:
When an album is open in the main window, bringing up the playback queue causes GUI elements to disappear from the playback bar.
Symptoms observed:

GUI elements will disappear from the playback bar
Certain elements will pop in and out on mouse hover, but disappear again when focus is lost
Pressing the "hamburger" menu icon to bring the sidebar will briefly pull the sidebar into view, but it will immediately retreat, For the time it is within view, it is blank.

Steps to Reproduce

Queue an album to play.
While it is playing, open another album in the main program window.
While the album information and tracks are available in the main window, click on the "Open Queue" button in the bottom-right corner to bring up the current playlist.
When both album and playlist are displayed on the screen, move the mouse towards the bottom left of the screen to cause various GUI elements to disappear.

Screenshot failed to attach. Uploading it here for the time being

@AdmiralAsshat You appear to be the victim of Google changing some things on their side.  Hopefully they will fix this bug soon.


p5.js texture -> Magic Leap

Bumping into a weird issue trying to use p5.js on Magic Leap and could use a 2nd set of eyes 👀
(This is all toward having p5 draw canvas texturess for use in a-frame/three.js, which I have working in Chrome)
Currently on v0.0.488
Boiled it down to a trivial example that shows the error:
opening
https://p5-exokit.glitch.me/
on ML produces this show stopper in the console:

10-17 20:18:23.246  4145     4 I exokit  : ---------------------exokit start 1
10-17 20:18:25.894  4145     6 I exokit  : __bionic_open_tzdata_path: ANDROID_DATA not set!
10-17 20:18:25.894  4145     6 I exokit  : __bionic_open_tzdata: couldn't find any tzdata when looking for GMT!
10-17 20:18:25.894  4145     6 I exokit  : __bionic_open_tzdata_path: ANDROID_DATA not set!
10-17 20:18:25.894  4145     6 I exokit  : __bionic_open_tzdata: couldn't find any tzdata when looking for posixrules!
10-17 20:18:27.272  4145     6 I exokit  : TypeError: Cannot read property 'push' of null
10-17 20:18:27.272  4145     6 I exokit  :     at _addListener (events.js:234:16)
10-17 20:18:27.272  4145     6 I exokit  :     at addListener (events.js:259:10)
10-17 20:18:27.272  4145     6 I exokit  :     at addEventListener (/package/src/Event.js:21:14)
10-17 20:18:27.272  4145     6 I exokit  :     at new p5 (https://cdnjs.cloudflare.com/ajax/libs/p5.js/0.7.2/p5.js:49007:14)
10-17 20:18:27.272  4145     6 I exokit  :     at _globalInit (https://cdnjs.cloudflare.com/ajax/libs/p5.js/0.7.2/p5.js:48414:7)
10-17 20:18:27.272  4145     6 I exokit  :     at emit (events.js:187:15)
10-17 20:18:27.272  4145     6 I exokit  :     at EventEmitter.emit (domain.js:442:20)
10-17 20:18:27.272  4145     6 I exokit  :     at _emit (/package/src/Event.js:60:40)
10-17 20:18:27.272  4145     6 I exokit  :     at window._emit (/package/src/core.js:1439:28)
10-17 20:18:27.272  4145     6 I exokit  :     at _emit (/package/src/Event.js:38:14)

Created a super simple sketch just to show the issue
https://glitch.com/edit/#!/p5-exokit?path=index.html
Maybe p5 is using something Exokit doesn't support? Will dig around more..

The throwing p5.js code:
// Bind events to window (not using container div bc key events don't work)

  for (var e in this._events) {
    var f = this['_on' + e];
    if (f) {
      var m = f.bind(this);
>>>>>>> window.addEventListener(e, m, { passive: false });
      this._events[e] = m;
    }
  }


systemd service: fix start up ordering

the service needs to have After=wayland-session.target otherwise it'll
be started in parallel to the compositor which might not be fully
configured.
ps. sorry I overlooked this setting when I was sending the previous pull request.

Thanks!

Where is the wayland-session.target coming from, who provides it?
Only what I have is graphical-session.target


Add integration test for gardener rbac

What this PR does / why we need it:
Adds a test that checks

if rbac is enabled on the gardener cluster and
if a service account can access (list shoots) in the garden ns.

Special notes for your reviewer:
cc @vlerenc @marwinski
Is it sufficient to check if a service account can access the garden ns or should we also test it for a oidc authenticated user?
Release note:

Added integration test to check if RBAC is enabled and if the `garden` namespace is protected.

Is it sufficient to check if a service account can access the garden ns or should we also test it for a oidc authenticated user?

Yes, it is, because we anyway cannot make any assumptions about how authentication is handled in the garden cluster. Thank you!


Arduino Nano_decawave ranging issue

hi, im working on arduino nano with decawave for ranging application, im using the code from github. i have tested all th examples in the file, but im not getting any ranging result. can any one please let me know where im struggling, herewith i attached the pin connections and code and result . pls review and giv ur input.(https://github.com/thotro/arduino-dw1000/)...
my pin connection:
d2- irq
d9-rstn
miso-11
mosi-12
cs-10
clk-13
power supply for decawave from external dc supply.
my serial terminal output:
DW1000-arduino-ranging-tag
DW1000 initialized ...
Committed configuration ...
Device ID: DECA - model: 1, version: 3, revision: 0
Unique ID: EUI: 0:0:0:0:255, OUI: 255:255:255
Network ID & Device Address: PAN: 10, Short Address: 2
Device mode: Data rate: 110 kb/s, PRF: 16 MHz, Preamble: 2048 symbols (code #4), Channel: #5
the output struck here and no result anymore after this

 Device ID: DECA - model: 1, version: 3, revision: 0 seems that your connection from arduino to dw1k is good. Must be something else.

hi , i have to ranging output after i gave separate power to decawave with small wire. but i have error reading,,distance changine with error. even when i kept a tag closer to anchor it showing 0.40 m distance, whether i should hav antenna ,,pls support me,,any algorithm shold use in code, alraeady assymtric ranging algorithm is used in the code,but stil error coming


added Tour to export

was unable to use Tour without exporting it via the index.js

Thank you Martin!


Improving example scripts

I want to add better description for example scripts and place them into separate folders

Codecov Report
Patch and project coverage have no change.

Comparison is base (c8336c7) 92.26% compared to head (039529c) 92.26%.

:exclamation: Current head 039529c differs from pull request most recent head 3c628f9. Consider uploading reports for the commit 3c628f9 to get more accurate results

Additional details and impacted files
@@           Coverage Diff           @@
##             main       #3   +/-   ##
=======================================
  Coverage   92.26%   92.26%
=======================================
  Files           3        3
  Lines         336      336
=======================================
  Hits          310      310
  Misses         19       19
  Partials        7        7

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


Increase success rate by adding back to queue the "timeout" videos

This would be nice, but I think even a simple retry would help in many cases. At least with some datasets served from a CDN it seems sometimes a download gets stuck but the next attempt works just fine (when just simulating by downloading the same file over and over with wget).
Currently the tool only supports retrying whole shards, right? Img2dataset let's you retry single files, too.


upgrading to 0.41.0 results in TypeError: args.slice is not a function

When using 0.34.0 my app loads fine. When upgrading to 0.41.0, trying to load the app results in TypeError: args.slice is not a function on my index route
Full traceback:
Error while processing route: app.index args.slice is not a function TypeError: args.slice is not a function
    at parseComputedArgs (http://<IP_ADDRESS>:4200/assets/vendor.js:172540:18)
    at exports.default (http://<IP_ADDRESS>:4200/assets/vendor.js:172575:30)
    at Module.callback (http://<IP_ADDRESS>:4200/assets/vendor.js:172983:48)
    at Module.exports (http://<IP_ADDRESS>:4200/assets/vendor.js:111:32)
    at Module._reify (http://<IP_ADDRESS>:4200/assets/vendor.js:148:59)
    at Module.reify (http://<IP_ADDRESS>:4200/assets/vendor.js:135:27)
    at Module.exports (http://<IP_ADDRESS>:4200/assets/vendor.js:109:10)
    at Module._reify (http://<IP_ADDRESS>:4200/assets/vendor.js:148:59)
    at Module.reify (http://<IP_ADDRESS>:4200/assets/vendor.js:135:27)
    at Module.exports (http://<IP_ADDRESS>:4200/assets/vendor.js:109:10)
ember-metal.js:3988 TypeError: args.slice is not a function
    at parseComputedArgs (-build-computed.js:6)
    at exports.default (-build-computed.js:41)
    at Module.callback (lazy-computed.js:7)
    at Module.exports (loader.js:106)
    at Module._reify (loader.js:143)
    at Module.reify (loader.js:130)
    at Module.exports (loader.js:104)
    at Module._reify (loader.js:143)
    at Module.reify (loader.js:130)
    at Module.exports (loader.js:104)

Debugger confirms that args is an object, not an array:

...which seems to originate in lazy-computed.js:

... where it gets passed to build-computed.js

If this is still an issue, please post back.


backdrop-filter not working

Steps To Reproduce

Playground for https://codesandbox.io
Playground for https://codepen.io
Playground for https://play.vuejs.org
Error Message & Stack Trace
<!-- Provide a log message if relevant -->

Your Environment

modern-screenshot: [e.g. 4.4.9]
Browser: [e.g. chrome 111.0.5563.64]

Any plan to fix it?


PageTitle - Wrong instructions re migrating Blazor WebAssembly to BWA

Description
In the section mentioned here: https://learn.microsoft.com/en-us/aspnet/core/migration/70-80?view=aspnetcore-8.0&tabs=visual-studio#convert-a-hosted-blazor-webassembly-app-into-a-blazor-web-app
The suggested instruction to replace
<title>...</title>

with
<HeadOutlet @rendermode="new InteractiveWebAssemblyRenderMode(prerender: false)" />
<PageTitle>...</PageTitle>

may not be entirely accurate. The PageTitle component does not have any effect in this context and won't render anything, neither in Static SSR nor in WASM.
The original purpose of the <title>...</title> element in index.html was to provide a default title for all pages that don't have a local <PageTitle>...</PageTitle> override (though such an override can be placed in MainLayout.razor, its effect only becomes visible after the WASM loads, not during the app's initial loading phase).
To maintain the original functionality of <title>...</title> from index.html, the correct content might instead be:
<HeadOutlet @rendermode="new InteractiveWebAssemblyRenderMode(prerender: false)" />
<title>...</title>

If this adjustment seems appropriate, I'm ready to prepare a PR to correct the instructions.
There are also alternative methods to achieve the same effect.
cc @guardrex
PS: To reproduce

Create a new BWA in Visual Studio (WASM global interactivity).
Go to App.razor and apply this change:

-<HeadOutlet @rendermode="InteractiveWebAssembly" />
+<HeadOutlet @rendermode="new InteractiveWebAssemblyRenderMode(prerender: false)" />
+<PageTitle>MyTitle</PageTitle>

Go to Home.index and remove the <PageTitle>Home</PageTitle>
Start the app, the will be no title set for the Home page.

Page URL
https://learn.microsoft.com/en-us/aspnet/core/migration/70-80?view=aspnetcore-8.0&tabs=visual-studio#convert-a-hosted-blazor-webassembly-app-into-a-blazor-web-app
Content source URL
https://github.com/dotnet/AspNetCore.Docs/blob/main/aspnetcore/migration/70-80.md
Document ID
534ab561-09c5-c33b-4394-0effba34d666
Article author
@Rick-Anderson

Morning @hakenr ☕ ... The BWA project template doesn't have a <title> element in the App component ...
https://github.com/dotnet/aspnetcore/blob/main/src/ProjectTemplates/Web.ProjectTemplates/content/BlazorWeb-CSharp/BlazorWeb-CSharp/Components/App.razor#L5-L26
... and we were trying to get devs converted to an exact BWA OOB app. Therefore, guidance for retaining <title> from index.html wasn't included. Also ... IIRC 🤔 ... they had a reason for not retaining it, and I seem to recall that when I tested with it there was some funky artifact ... a failure or strange 👽 undesirable behavior ... with using a <title> tag, but I don't recall what happened.
They have at least one open issue for page titles 👉 https://github.com/dotnet/aspnetcore/issues/50268 👈 that I don't think deals with what you've reporting here. They might have one or more additional title-related issues.
Since we're trying to match what the current template produces, your concern should to go to the product unit for investigation/resolution. They may decide that it's ok to break from the template in the guidance, but they'll need to make that call. Otherwise, your PU issue might lead to a change in the project template, perhaps even for .NET 9.
Open for them on their repo ...
https://github.com/dotnet/aspnetcore/issues
... to ask about it, and please add the ping/cross-link back here in case they determine that they'd like to address something in the doc on it ...
cc: @guardrex https://github.com/dotnet/AspNetCore.Docs/issues/32521

@guardrex The guidance I'm referencing suggests adding <PageTitle>...</PageTitle> to the new App.razor component. This line is not part of the BWA template and does not work.
Please let's not focus on my workaround (adding <title>...</title> to App.razor). Instead, let's address the problem in the guidance where it suggests adding something that is neither aligned with the BWA template nor functional.
If my code change doesn’t appeal to you (no worries, it might have issues), and if there's no better solution, perhaps we could update the guidance to clearly state that "setting the default page title, which is used during the page startup phase (initial HTML served from the server), is not supported in BWA Interactive WebAssembly without prerendering" (if that is the case?). It would be more helpful than recommending <PageTitle>...</PageTitle>, which does not work.

Sorry ... yes ... I did just notice that. I was too focused on the <title> workaround piece, which I think presented a problem.
Let's cross-link to the layout approach because that's what the PU favors. Here's the link ...
<xref:blazor/components/control-head-content?view=aspnetcore-8.0#set-a-page-title-for-components-via-a-layout

In this scenario, the layout functions as an interactive client component, rendering the title only after the WASM runtime starts. This differs from the original behavior, where the title was set in the initial HTML served by the server. Should we mention this change in the guidance?
(There are several other features dropped from the original Blazor WASM setup, like the loading progress indicator, that aren't mentioned by the guidance either. Just wondering if we should highlight this title-aspect of the migration.)

Yes! I think these are great recommendations so that devs aren't surprised. I'm sorry that there wasn't more time to explain these aspects when the content was written. Even rushing, I wasn't finished at GA with .NET 8 updates (and I'm still not finished). That's the magnitude of the shift in docs for the .NET 8 release.

... and BTW ... it wasn't done in a total vacuum ... Mackinnon signed off on this guidance here ...
https://github.com/dotnet/AspNetCore.Docs/pull/32144
... and very few 🦖 RexHacks™ 🦖 get past his watchful 👁! 😆

Create a new BWA in Visual Studio (WASM global interactivity).

... but that's not the migration path for this section.

This wasn't intended as a migration scenario, but rather as proof that the <PageTitle>...</PageTitle> component in App.razor of a BWA WebAssembly application without prerendering does not function correctly.

I do see another change to make. I'm going to go ahead and fix this myself right now, but ping me if you've already started and I'll stop. I think our timezone differences have it late there, so you might be 🛌💤 now.

No, I haven't started working on this yet. Since my original solution wasn't approved, I'll leave this up to you unless you specifically request that I modify the guidance in a certain way.
BTW, I'm in the UTC+2 timezone (CEST, Prague), so it's 4:20pm here in Europe right now. What is your timezone?

I'll set my PR up as an "addresses" PR, so you to make further modifications that you think would be helpful. For example, the loss of the loading progress indicator could link over to ...
https://learn.microsoft.com/aspnet/core/blazor/fundamentals/startup#client-side-loading-progress-indicators
<xref:blazor/fundamentals/startup#client-side-loading-progress-indicators>

... with some explanation.
Plus, whatever else you think would be helpful and any changes to what I'm doing now.

UTC+2 timezone (CEST, Prague)

I see ... not late then. I think it's UTC−04:00 [US east coast (EST)]. I'm in Melbourne, Florida, so I'm on the "Space Coast" with the bonus of many 🚀 to watch blasting off. I wish I could get to Europe. Prague is definitely on my list of cities to visit. It looks like such travel will need to wait until retirement.

@hakenr ... Ok ... that's done. I recommend taking it from there with further modifications, including to what I just did. I'm (as usual) rushing a bit 🏃♂ with that to get on with other work. Thanks for this issue! Great 👁 as usual on catching problems like this! 🏅

@guardrex Probably not - it's "just" a guidance on how to migrate from one project setup to another, and this might not be the best place to detail all the differences between them. A cross-link could be appropriate, but there probably isn't an article that explains all the differences and limitations... :-D


[ENH] Allow Flight/Stealth -> combat for Bartender4 and ConsolePort

🟢 How does GSE currently work
Bartender4 and ConsolePort use a normal version of LibActionButton.  LAB has the limitation of not supporting click as a button type.  This build allows it and uses custom as a variant.
🟢 Describe the solution you'd like
This change essentially modifies LAB and adds "click" as a button type.  GSE can then use that to set the state of the button and switch from flight or mining to combat without having to clear combat first.
This will work for Bartender4 and ConsolePort initially.  ElvUI uses its own modifications to LAB that I would need to incorporate in a subsequent version.

Note: The paging function has to be turned off for druids and potentially rogues.  The issue is when Bartender4 pages, the bar is replaced with the contents of another hidden bar.  Even If I bind a button to that bar the "click" state is not transferred to the new bar.

This cause #1710


Fix PlanetShine indentation

One of the mods that caused https://github.com/KSP-CKAN/NetKAN-Infra/pull/220
GitHub highlights this syntax error nicely, now that all netkans are marked as YAML (https://github.com/KSP-CKAN/NetKAN/pull/8566), so I think it was a good thing to do in the end.

https://github.com/KSP-CKAN/NetKAN/blob/339d2f3dc336ec880be6b587a352d0e0d809d583/NetKAN/PlanetShine.netkan#L7-L9

I'll ignore "Line too long" linting errors for JSONs.


Gulp 3 is no longer supported

Category

[ ] Question
[ ] Typo
[x] Bug
[ ] Additional article idea

Expected or Desired Behavior
yo @microsoft/sharepoint  should be updated to use Gulp 4.
Observed Behavior
Command yo @microsoft/sharepoint with all default settings for SharePoint Online Application Customizer generates project with dev-dependency from gulp 3.9.1.
Gulp 3 is not compatible with NodeJS 12 LTS. It crashes with exception https://github.com/gulpjs/gulp/issues/2324
The single solution is to use Gulp 4 that doesn't depend on outdated packages.
Steps to Reproduce

Install NodeJS LTS (it's 12.13.0 currently)
run npm install -g yo gulp @microsoft/generator-sharepoint
run yo @microsoft/sharepoint with all defaults
try to build solution gulp bundle --ship
You will receive exception https://github.com/gulpjs/gulp/issues/2324

Thanks for the comment.
Unfortunately, you are using an unsupported of Node. SPFx currently only supports Node 10x. Please uninstall Node 12, and re-install Node 10.

@bcameron1231
Thank you, not so good news. I hope, new nodejs LTS version will be supported soon.


General Submodule update

, refs #0

Job VTB Documentation on 6cc5330 wanted to post the following:
View the site here
This comment will be updated on new commits.


Feature/5238 qa cert maintenance table

Why Cert Events and TEE showing propertyNames instead empty value?

If there is no data we should show something like this. ⬇

This should be something like this ⬇

Example:

Why Cert Events and TEE showing propertyNames instead empty value?

If there is no data we should show something like this. ⬇

Currently we are displaying dummy data. I believe a later ticket will connect the api to fetch real data.

Then put the place holder for No data available. As per other table.
When we will connect the APIs for other table we will display data.

Apology. I thought there are data for test-summary. Could you revert the dummy data, so table headers are shown.
Sorry for that.


build: Allow to blacklist some functional tests

Currently we have a GO_TEST_FUNC_ARGS variable which is passed directly to go test. With that we can do something like make check GO_TEST_FUNC_ARGS='-run "TestAuth.*"' to run only TestAuth{Sanity,Basic,Oauth,Override,Ignore} tests.
But it is a hassle to run all tests but TestFetch for example. An idea would be to maybe deprecate the GO_TEST_FUNC_ARGS in favor of GO_TEST_RUN_REGEXP and GO_TEST_DONT_RUN_REGEXP.
To run only TestAuth tests the invocation would be make check GO_TEST_RUN_REGEXP='TestAuth.*'.
To run all the tests but TestFetch: make check GO_TEST_DONT_RUN_REGEXP='TestFetch'.
To run all the auth test but override: make check GO_TEST_RUN_REGEXP='TestAuth.*' GO_TEST_DONT_RUN_REGEXP='TestAuthOverride' (or '.*Override').
Some other (probably bit crazy) notes:

I couldn't find any builtin command to list all the tests that would be executed, so a hacky way to get the list would be:

git grep -P 'func Test\w+\(\w+\s+\*testing\.T\)' tests | grep -o '\bTest[[:alnum:]]\+' | sort -u

run grep '$(GO_TEST_RUN_REGEXP)' on that list to get a whitelist
run `grep -v '$(GO_TEST_DONT_RUN_REGEXP)' on that whitelist to get a final list of tests to run
prepare the final list to something like (test1)|(test2)|...|(testN)
We could then run `go test -run '$(prepared_final_list)' github.com/coreos/rkt/tests

I'd like to get to #1422 before this one..

@jonboulle: Right. This one is just a brain dump, so I won't forget about it. It was basically a reaction for #1544.

Related issue here: https://github.com/intelsdi-x/rkt/issues/27
/cc @woodbor