Edge-case in multiple-iteration bootstrapping

If we modify iterative-ckks-bootstrapping.cpp from
//    Plaintext ptxt = cryptoContext->MakeCKKSPackedPlaintext(x, 1, depth - 1, nullptr, numSlots);
to
    Plaintext ptxt = cryptoContext->MakeCKKSPackedPlaintext(x, 1, 0, nullptr, numSlots);
we get the error of Bootstrapping number of RNS moduli 11 must be greater than initial number of RNS moduli 31

The scenario Yuriy mentioned in our meeting was if you start with 5 levels remaining, then you should be able to bootstrap up until 10 levels. This scenario in iterative-ckks-bootstrapping.cpp works (set the depth to depth - 5).
The one you're describing above is when you start with 31 levels. Bootstrapping would reduce your # levels to 10, so I'm not sure why you would want to bootstrap in this case. @yspolyakov can you confirm that we want to bootstrap here instead of throwing an exception?

I thought the crux of the issue was that the error message isn't particularly helpful? I might be misunderstanding this.

Btw calling EvalBootstrap normally without iterations on 31 levels does perform the bootstrap on the ciphertext to 10 levels. So either way for this scenario, we should make the with/without iterative bootstrapping cases have the same behavior.

Discussed it with Yuriy, and the plan is to change the logic to return the original ciphertext if it is has a higher number of levels than what we would get after bootstrapping.


Problem with set_linear_velocity() (don't want to throw objects)

Hi, I have a problem with set_linear_velocity() it does not work. I don't know if I'm using it properly, but it works in GodotPhysics3D. In my game i have "pick up" and "move" objects.
This is the code for moving objects, and it works (it's in the _process loop):
var object = player.move_object
var object_pos = object.global_transform.origin
var loc = player.act_loc.global_transform.origin
object.set_linear_velocity((loc - object_pos) * 13)

But, here is the code where i have a problem. This is for throw objects, and this doesn't work in Jolt Physics (This is not in a loop, just a function):
var object_pos = object.global_transform.origin
var loc = igrac.loc_throw.global_position
loc.y += 0.5
object.set_linear_velocity((lokacija-pozicija_objekat)*3)

This code doesn't throw the object in Jolt, it just releases it in place.

Sorry, I found the fix. I had some problems in the rigid body. My bad...


Data unavailable since installing 115.x

Data unavailable since installing 115.x, tried reinstall but still not working.

@quiggles do you have any errors in your logs? I have had no problems with data on 115 and still working correctly on 116b0.
Have you completely uninstalled the integration through HACS, rebooted, then reinstalled the integration and set it up again through Integrations?

I am having the same issue. It looks like the entities changed and the "spacex" string from the entities has been removed, so "sensor.spacex_latest_launch_time" is now "sensor.latest_launch_time".
May need to update your Lovelace dashboards.

Yes that is correct. That was listed as a breaking change. Entity ids changed as part of a previous update.


Webhooks and subscriptions should support Epic Link changes

We currently do not support webhook events coming from Jira Server for updating an Epic Link for an issue.
When an epic link is assigned in an issue, Jira Server sends a webhook with event issuelink_created. We currently do not support this event, so the event is ignored and not processed. When an Epic Link is removed, it sends an issuelink_deleted event. When an Epic Link is changed from one Epic to another, both events are sent, with the issuelink_deleted event being the first one sent.
Jira Cloud sends these same events in the same scenarios, but also sends an event with type jira:issue_updated in all cases, which is why it currently works with Jira Cloud.
Here is a proposed solution:

For Jira Server:

When we get an issuelink_created event,  make a post saying the Epic Link was changed to (value)
When we get an issuelink_deleted event, make a post saying the Epic Link (value) was removed from the issue

For Jira Cloud:

(A) Handle the same way as Jira Server. And ignore the changes to Epic Link in jira:issue_updated events.
OR
(B) Ignore issuelink_created and issuelink_deleted events, and continue to process jira:issue_updated events with Epic Link changes in them. This option makes for cleaner posts, because a change in Epic Link will result in one post instead of two, but involves some conditional logic based on Server vs Cloud.

Originally, https://mattermost.atlassian.net/browse/MM-18738

If you're interested please comment here and come join our "Contributors" community channel on our daily build server, where you can discuss questions with community members and the Mattermost core team. For technical advice or questions, please  join our "Plugin: Jira" community channel.
New contributors please see our Developer's Guide and our Plugins Guide.

👍 for option (B)

I'd like to work on this.

Thank you @codevbus for taking this on, feel free to join the conversation and ask for any help you might need at https://community-daily.mattermost.com/core/channels/jira-plugin.

@codevbus Are you still interested in finishing this ticket?

@iamsayantan Sorry about the delay on this. I'll get back soon!

Sure. No problem.

@mickmister ping

@iamsayantan I've verified the behavior you describe works with Jira Cloud and Jira Server 8.x.  I've determined that the behavior with Jira Server that I describe in the description is specifically for Jira Server 7.x, which this plugin currently supports.
Here is a sample docker-compose.yml that I use to run Jira Server 7.13 locally.
version: '3'
services:
  jira:
    image: atlassian/jira-software:7.13
    ports:
      - "8080:8080"

To be clear, the task here is to have the feature work properly for Jira Server 7.x, while also continuing to support the others. We can determine which version of Jira Server of being used by hitting the endpoint described here. We would only want to check if the installed version is Jira Server, and the event type is issuelink_created or issuelink_deleted.
@levb @aaronrothschild This situation is a bit of a corner case, but customers on Jira Server 7.x do not have working events regarding Epic Link as a result. 1/5 I think we should just move forward and not support this to avoid the complexity here, and tell customers to upgrade to 8.x to have this functionality working properly for them.


Allow work to be marked explicitly not cacheable via annotation

Tasks can be marked as @CacheableTask and artifact transforms can be marked as @CacheableTransform when the author of these work items deems them worthwhile to store in the cache. There are however tasks and transforms that are inherently not cacheable. For example, tasks that only move things around the local disk, like Copy: these should not be stored in any cache.
Currently when looking at the code of a task or transform that is not marked as cacheable it is hard to tell if it is not marked because it shouldn't be cacheable or if it was just never considered to be made cacheable.

We could add something like like a @NonCacheable annotation could help. If we add something like this, providing a reason for not caching in the annotation could be a good idea, too.
Another option would be to add parameters to the existing annotations, like @CacheableTask(disable = true, because = "...").
Yet another option would be to add a new annotation to mark work as cacheable that could supersede @CacheableTask and @CacheableTransfrom (e.g. a new @Cacheable annotation), and add parameters to that to disable caching.

No matter how we mark tasks as non-cacheable, it would allow both people looking at the source code, as well as Gradle's own validations to check whether cacheability has been considered for a task, and warn if it hasn't.

cc: @gradle/execution

We should consider this in 7.1.

This looks good :)
I like the idea in general of marking something as Cacheable, but with a marker that it's probably slower to fetch from the cache than just compute, as it leaves open the possibility that in the future Gradle and/or the build author could make a more nuanced choice, while also addressing our immediate need. i.e
I wonder if we should pick annotations to distinguish "this can't be cached for a fundamental reason" from "this probably isn't worth caching" That could mean providing e.g.

@Cacheable
@Cacheable(likelyFasterToRecomputeThanToFetchFromCache=true) (with a better name :))
@NotCacheable
Where initially 2 & 3 behave the same other than for reporting to the build author.

I wonder if we should start to introduce a distinction between cacheable and should cache for Tasks. If I understand correctly, with the new enforced input/output declarations in Gradle 7 almost all tasks should be inherently cacheable. Whether it makes sense to cache the task outputs is separate, and can be a lot more dependent on the particular Task invocation.
For example, I'm sure there are Copy tasks with very expensive filtering logic that would make sense to cache.
The nice thing about this distinction is that it can lead to smarter infrastructure to make decisions about when to cache build outputs, rather than relying on the plugin author making this decision up front.
Perhaps this is mostly about language: I would find it unfortunate to label something as @NotCacheable when in fact the outputs could be cached, but in 99% of cases this doesn't make sense.

I agree that NotCacheable should be used only if something is truly not cacheable, and I'm not sure what the reason could be. There is a potential issue with relocability when task inputs point to things outside of the project (like an SDK installed somewhere) using absolute paths on the machine. This is different than using absolute path for things inside your project which should be fixable, but it impacts remote cache.
So I agree that we should have more granularity in the annotation. Something like:

cacheable

cacheable but potentially not worth it.

cacheable but only works on the same machine (so this can be part of a local cache but not a remote cache)

not cacheable.

should be very rare, and definitively not used for Jar/Copy/etc...
1/2/3 could be combined technically, so it makes sense that it's the same annotation with some parameters.

The challenge is figuring out how much to declare for 2, as I hope we can get to a point where Gradle can adapt its strategy for using remote cache based on machine performance vs network speed.


projectile configuration make projectile's candidate display error in emacs 29

Hello!Thanks for you contribution.
The candidate content is displayed incorrectly when i use the projectile-find-file function in my project file.If i comment the following content in init-projectile.el, it can be displayed normally.
  ;; (when (executable-find "rg")
  ;;   (setq-default projectile-generic-command "rg --files --hidden"))

before comment

after

Odd, I can't reproduce this. Are you on Windows perhaps? It looks like the line endings in the rg output are unexpected.

I use arch linux under pure wayland, and I tried emacs28 but the problem persists.I'm not sure if it's a system problem.
Expected behavior
Show project files when use C-c p f
Current behavior
All filenames incorrectly displayed on one line.

Steps to reproduce

clone this repositorie
create the following directory

├─example
│  ├─src
│  │  ├─main.py
│  ├─setup.py
│  ├─.projectile

start emacs and use C-x C-f to open setup.py, then use C-c p f to search for project files.

System Information
os: Arch Linux x86_64
kernel: 6.1.12-arch1-1
wm: sway
rg: ripgrep 13.0.0
emacs: 28.2/29.0

Thanks, those reproduction steps were perfect. I've committed a fix now.


.http.ApiError

020-07-01 00:44:35.378 INFO     >>> GET http://ec2-ip:8081/rendez_vous
2020-07-01 00:44:35.390 INFO     <<< GET http://ec2-ip:8081/rendez_vous [200]
2020-07-01 00:44:35.390 DEBUG    content-type: application/json
2020-07-01 00:44:35.390 DEBUG    content-length: 22
2020-07-01 00:44:35.391 DEBUG    date: Wed, 01 Jul 2020 00:44:35 GMT
2020-07-01 00:44:35.391 INFO     {
"id": null,
"ok": false
}
2020-07-01 00:44:35.392 DEBUG    heartbeat thread starting
2020-07-01 00:44:35.392 INFO     waiting for being selected
2020-07-01 00:44:35.393 INFO     >>> GET http://ec2-ip:8081/heartbeat/None
2020-07-01 00:44:35.402 WARNING  <<< GET http://ec2-ip:8081/heartbeat/None [404]
2020-07-01 00:44:35.402 DEBUG    content-length: 0
2020-07-01 00:44:35.402 DEBUG    date: Wed, 01 Jul 2020 00:44:35 GMT
2020-07-01 00:44:35.403 ERROR    error while sending heartbeat, exiting
Traceback (most recent call last):
File "/home/xain-fl/python/sdk/xain_sdk/participant.py", line 227, in run
self.heartbeat()

try to update it to latest


Tried to register two views with the same name VRTQuad

System:
OS: macOS 13.2.1
CPU: (12) x64 Intel(R) Core(TM) i7-8850H CPU @ 2.60GHz
Memory: 230.17 MB / 16.00 GB
Shell: 5.8.1 - /bin/zsh
Binaries:
Node: 16.10.0 - ~/.nvm/versions/node/v16.10.0/bin/node
Yarn: 1.22.19 - /usr/local/bin/yarn
npm: 7.24.0 - ~/.nvm/versions/node/v16.10.0/bin/npm
Watchman: 2<IP_ADDRESS> - /usr/local/bin/watchman
Managers:
CocoaPods: 1.11.3 - /Users/muhammadbilal/.rvm/gems/ruby-2.7.6/bin/pod
SDKs:
iOS SDK:
Platforms: DriverKit 22.2, iOS 16.2, macOS 13.1, tvOS 16.1, watchOS 9.1
Android SDK:
API Levels: 27, 28, 29, 30, 31, 33
Build Tools: 30.0.2, 30.0.3, 31.0.0, 33.0.0, 34.0.0
System Images: android-30 | Google APIs Intel x86 Atom, android-31 | Intel x86 Atom_64, android-31 | Google APIs Intel x86 Atom_64, android-31 | Google Play Intel x86 Atom_64, android-33 | Google APIs Intel x86 Atom_64
Android NDK: Not Found
IDEs:
Android Studio: 2021.3 AI-213.7172.25.2113.9014738
Xcode: 14.2/14C18 - /usr/bin/xcodebuild
Languages:
Java: 11.0.18 - /usr/bin/javac
npmPackages:
@react-native-community/cli: Not Found
react: 18.2.0 => 18.2.0
react-native: 0.71.4 => 0.71.4
react-native-macos: Not Found
npmGlobalPackages:
react-native: Not Found
m facing this issue on andorid as well as ios any solution???
Invariant Violation: Tried to register two views with the same name VRTQuad, js engine: hermes
LOG  Running "SafeSigNZ" with {"rootTag":11}
ERROR  Invariant Violation: "SafeSigNZ" has not been registered. This can happen if:

Metro (the local dev server) is run from the wrong folder. Check if Metro is running, stop it and restart it in the current project.
A module failed to load due to an error and AppRegistry.registerComponent wasn't called., js engine: hermes

Hey, did you solve this?

what?

From: Stephan Müller @.>
Sent: Sunday, October 29, 2023 7:26 PM
To: ViroCommunity/viro @.>
Cc: Muhammad Bilal @.>; Author @.>
Subject: Re: [ViroCommunity/viro] Tried to register two views with the same name VRTQuad (Issue #201)
Hey, did you solve this?
—
Reply to this email directly, view it on GitHubhttps://github.com/ViroCommunity/viro/issues/201#issuecomment-1784128901, or unsubscribehttps://github.com/notifications/unsubscribe-auth/A5FM5ZLG5OV53COJQTDWXR3YBZKQLAVCNFSM6AAAAAAW4NFMESVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTOOBUGEZDQOJQGE.
You are receiving this because you authored the thread.Message ID: @.***>

closing in favor of #136


Deprecation

We should point people @GambolingPangolin's wonderful new library:
https://github.com/bitnomial/bitcoind-rpc
We should also put a deprecation warning out on hackage and point people to that new lib.

Agreed.  We should wait until we release bitcoind-rpc 0.3, since the current version does not cover all the functionality of this library.


Feat: configure option for bundling some packages in one PR

It often happens that a bigger framework has multiple packages (react, storybook, ...) if you use a lot of them and they all get updated with a new release, dependabot opens PRs for every single module.
I would like to see a feature to make it configurable to combine updates for specific packages always into one single PR opened by dependabot.

Hi @timomayer, this looks like a duplicate of https://github.com/dependabot/dependabot-core/issues/1190. It's definitely on our radar, but our current setup makes it hard, so it might be a while before this lands.


Problem with get_data in Quick start example

Hi there,
I am very looking forward to study the data and therefore using your package.
I have a problem when using your quick start examples. It seems to be an issue with the downloaded .zip files (for example csv_pca.zip). I run the code just as suggested.
I tried to manually download the .zip-file and set download=False, but that lead to a FileNotFoundError.
Here is my .ipynb with the occuring error message:
pip install folktables

Requirement already satisfied: folktables in d:\programmierung\jupyter\envs\master_thesis_pre\lib\site-packages (0.0.11)Note: you may need to restart the kernel to use updated packages.

Requirement already satisfied: requests in d:\programmierung\jupyter\envs\master_thesis_pre\lib\site-packages (from folktables) (2.27.1)
Requirement already satisfied: numpy in d:\programmierung\jupyter\envs\master_thesis_pre\lib\site-packages (from folktables) (1.21.5)
Requirement already satisfied: pandas in d:\programmierung\jupyter\envs\master_thesis_pre\lib\site-packages (from folktables) (1.4.0)
Requirement already satisfied: sklearn in d:\programmierung\jupyter\envs\master_thesis_pre\lib\site-packages (from folktables) (0.0)
Requirement already satisfied: python-dateutil>=2.8.1 in d:\programmierung\jupyter\envs\master_thesis_pre\lib\site-packages (from pandas->folktables) (2.8.2)
Requirement already satisfied: pytz>=2020.1 in d:\programmierung\jupyter\envs\master_thesis_pre\lib\site-packages (from pandas->folktables) (2021.3)
Requirement already satisfied: urllib3<1.27,>=1.21.1 in d:\programmierung\jupyter\envs\master_thesis_pre\lib\site-packages (from requests->folktables) (1.26.8)
Requirement already satisfied: certifi>=2017.4.17 in d:\programmierung\jupyter\envs\master_thesis_pre\lib\site-packages (from requests->folktables) (2021.10.8)
Requirement already satisfied: idna<4,>=2.5 in d:\programmierung\jupyter\envs\master_thesis_pre\lib\site-packages (from requests->folktables) (3.3)
Requirement already satisfied: charset-normalizer~=2.0.0 in d:\programmierung\jupyter\envs\master_thesis_pre\lib\site-packages (from requests->folktables) (2.0.11)
Requirement already satisfied: scikit-learn in d:\programmierung\jupyter\envs\master_thesis_pre\lib\site-packages (from sklearn->folktables) (1.0.2)
Requirement already satisfied: six>=1.5 in d:\programmierung\jupyter\envs\master_thesis_pre\lib\site-packages (from python-dateutil>=2.8.1->pandas->folktables) (1.16.0)
Requirement already satisfied: joblib>=0.11 in d:\programmierung\jupyter\envs\master_thesis_pre\lib\site-packages (from scikit-learn->sklearn->folktables) (1.1.0)
Requirement already satisfied: scipy>=1.1.0 in d:\programmierung\jupyter\envs\master_thesis_pre\lib\site-packages (from scikit-learn->sklearn->folktables) (1.5.4)
Requirement already satisfied: threadpoolctl>=2.0.0 in d:\programmierung\jupyter\envs\master_thesis_pre\lib\site-packages (from scikit-learn->sklearn->folktables) (3.1.0)

from folktables import ACSDataSource, ACSEmployment

data_source = ACSDataSource(survey_year='2018', horizon='1-Year', survey='person')
acs_data = data_source.get_data(states=["CA"], download=True)
features, label, group = ACSEmployment.df_to_numpy(acs_data)

Downloading data for 2018 1-Year person survey for CA...

data\2018\1-Year\csv_pca.zip may be corrupted. Please try deleting it and rerunning this command.

Exception:  File is not a zip file

---------------------------------------------------------------------------

FileNotFoundError                         Traceback (most recent call last)

Input In [18], in <module>
      1 from folktables import ACSDataSource, ACSEmployment
      3 data_source = ACSDataSource(survey_year='2018', horizon='1-Year', survey='person')
----> 4 acs_data = data_source.get_data(states=["CA"], download=True)
      5 features, label, group = ACSEmployment.df_to_numpy(acs_data)

File D:\Programmierung\Jupyter\envs\master_thesis_pre\lib\site-packages\folktables\acs.py:34, in ACSDataSource.get_data(self, states, density, random_seed, join_household, download)
     32 def get_data(self, states=None, density=1.0, random_seed=0, join_household=False, download=False):
     33     """Get data from given list of states, density, and random seed. Optionally add household features."""
---> 34     data = load_acs(root_dir=self._root_dir,
     35                     year=self._survey_year,
     36                     states=states,
     37                     horizon=self._horizon,
     38                     survey=self._survey,
     39                     density=density,
     40                     random_seed=random_seed,
     41                     download=download)
     42     if join_household:
     43         orig_len = len(data)

File D:\Programmierung\Jupyter\envs\master_thesis_pre\lib\site-packages\folktables\load_acs.py:120, in load_acs(root_dir, states, year, horizon, survey, density, random_seed, serial_filter_list, download)
    116 first = True
    118 for file_name in file_names:
--> 120     with open(file_name, 'r') as f:
    122         if first:
    123             sample.write(next(f))

FileNotFoundError: [Errno 2] No such file or directory: 'data\\2018\\1-Year\\psam_p06.csv'

Hi, it looks like you're using Windows, which may break some of the downloading and path manipulation logic in the repo. We don't support Windows, but it might be helpful to look into modifying os.path.join to work on your OS in the file folktables/load_acs.py. I'm closing this issue, but if you believe the downloading issue isn't Window's specific please re-open it.

Hi,
As a fellow windows user I ran into this same issue.
Thought I would post the solution I came up with for any other windows users who want to use this dataset.
As @millerjohnp suggested, within folktables/load_acs.py  find the function initialize_and_download.
modify the line of code setting the url (line 73 at the time of writing this)
From: url = os.path.join(base_url, remote_fname)
To: url = base_url + "/" + remote_fname
The reason for this change is that os.path.join on windows will put a '' in between the path, but for a url the separator should always be '/' no matter the os.
Note: There are other libraries that exist for combining url paths that could be used but this worked for my purposes.


Add support for Switch

XML:
https://developer.android.com/reference/android/widget/Switch
Composable:
?

@pocmo I have searched for the documentation of Compose Switch, I could not find anything. I am sure it exists because I have used it before:
val checkedState = remember { mutableStateOf(singlePlayer) }

    Switch(checked = checkedState.value, onCheckedChange = {
        checkedState.value = it
        onCheckedChange(it)
    })

https://foso.github.io/Jetpack-Compose-Playground/material/switch/
https://developer.android.com/reference/kotlin/androidx/compose/material/package-summary#switch


Transparency on PNG

Hi! I know this subject has been replied before but I still have a situation using your library and trying to get a cropped transparent PNG. I'm using the attached file to be cropped and this is how I call the library:
CropImage.ActivityBuilder cropImageActivityBuilder = CropImage.activity(imagePath);
		if (squareAspect)
		{
			cropImageActivityBuilder.setAspectRatio(100, 100)
					.setFixAspectRatio(true);
		}

		cropImageActivityBuilder
				.setGuidelines(CropImageView.Guidelines.ON)
				.setAutoZoomEnabled(false)
				.setOutputUri(croppedImage)
				.setOutputCompressFormat(Bitmap.CompressFormat.PNG);

		Intent intent = cropImageActivityBuilder.getIntent(mCallerActivity);
		mCallerActivity.startActivityForResult(intent, mRequestId);

Everytime I get the transparent PNG file with the transparent pixels replaced by black ones. Have anyone got into a similar situation? Is this an expected behavior for this library?
I've tried the sample app and it does not return the image with the transparent pixels replaced by black ones but I'm really confused at this point because I've checked my code and the image enters as a transparent background PNG and the one I get is the same but with the problem I describe above.

I have retested the flow for PNG again in the "quick-start" sample app and it works, that is, transparent pixels remain transparent.
From a technical perspective, the only place when bitmap can drop the transparent data is when it is saved. At this point, the raw pixels are encoded into the target format, if PNG is used then the transparent data is encoded, and that's what I have seen.
So I don't have an answer for you on what can go wrong except, the library is 100% supports transparent data in PNG format and I'm open if you prove otherwise.

i have same problem above. when selecting png image with background transparent from gallery, the transparent parts get black after cropping image.
you can see the below screen shot i have attached. @ArthurHub

I am also facing the same problem

Hi! I know this subject has been replied before but I still have a situation using your library and trying to get a cropped transparent PNG. I'm using the attached file to be cropped and this is how I call the library:
CropImage.ActivityBuilder cropImageActivityBuilder = CropImage.activity(imagePath);
		if (squareAspect)
		{
			cropImageActivityBuilder.setAspectRatio(100, 100)
					.setFixAspectRatio(true);
		}

		cropImageActivityBuilder
				.setGuidelines(CropImageView.Guidelines.ON)
				.setAutoZoomEnabled(false)
				.setOutputUri(croppedImage)
				.setOutputCompressFormat(Bitmap.CompressFormat.PNG);

		Intent intent = cropImageActivityBuilder.getIntent(mCallerActivity);
		mCallerActivity.startActivityForResult(intent, mRequestId);

Everytime I get the transparent PNG file with the transparent pixels replaced by black ones. Have anyone got into a similar situation? Is this an expected behavior for this library?
I've tried the sample app and it does not return the image with the transparent pixels replaced by black ones but I'm really confused at this point because I've checked my code and the image enters as a transparent background PNG and the one I get is the same but with the problem I describe above.

Any Luck? please help

i have same problem above. when selecting png image with background transparent from gallery, the transparent parts get black after cropping image. you can see the below screen shot i have attached. @ArthurHub

Facing same issue Can you provide any guidance?

Try this CropImage.activity().setOutputCompressFormat(Bitmap.CompressFormat.PNG).setAspectRatio(1,1).start(this);


Weird training results

Hi, thank you for your great work.
I hava a question for the ControlNet training
I am just trying to train ControlNet with canny edge condition using OpenImage Dataset to reproduce or mimic your traning scheme. I preserve all training setting with the tutorial you gave us. However, the results is so weird like below and that was not recovered even after many training iterations.
Did you have a experience like me during training? or is there any opinion to this phenomenon?
I just want to get some opinion or intuition about this from you.
Thank you.
The prompt is fixed by "a high-quality, detailed, and professional image"
Input

Ourput

Recon

generate paired prompts and then use larger batch size (perhaps by accumulation)

generate paired prompts and then use larger batch size (perhaps by accumulation)

What's the appropriate batch size, from your experience?

generate paired prompts and then use larger batch size (perhaps by accumulation)

What's the appropriate batch size, from your experience?

Do you solve this problem?

generate paired prompts and then use larger batch size (perhaps by accumulation)

What's the appropriate batch size, from your experience?

Do you solve this problem?

No, after many experiments, I tentatively concluded that the training code has unknown bug.


Fix broken links and images.

Signed-off-by: jjlee050<EMAIL_ADDRESS>

Pull Request Test Coverage Report for Build 1231

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 71.86%

Totals

Change from base Build 1230:
0.0%

Covered Lines:
3381

Relevant Lines:
4705

💛  - Coveralls


use older api to get dpi

use older api to get dpi
GetDpiForSystem only supports version above win10.
Reference below url:
https://docs.microsoft.com/zh-tw/windows/win32/directwrite/how-to-ensure-that-your-application-displays-properly-on-high-dpi-displays#gdi
GetDC, GetDeviceCaps, ReleaseDC supports version above win 2000.

oops!
I don't notice that I push including my ide folder.

#11


HDDS-1893. Fix bug in removeAcl in Bucket.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Comment

0
reexec
49
Docker mode activated.

_ Prechecks _

+1
dupname
0
No case conflicting files found.

+1
@author
0
The patch does not contain any @author tags.

+1
test4tests
0
The patch appears to include 1 new or modified test files.

_ trunk Compile Tests _

0
mvndep
18
Maven dependency ordering for branch

+1
mvninstall
586
trunk passed

+1
compile
371
trunk passed

+1
checkstyle
74
trunk passed

+1
mvnsite
0
trunk passed

+1
shadedclient
832
branch has no errors when building and testing our client artifacts.

+1
javadoc
167
trunk passed

0
spotbugs
418
Used deprecated FindBugs config; considering switching to SpotBugs.

+1
findbugs
606
trunk passed

_ Patch Compile Tests _

0
mvndep
25
Maven dependency ordering for patch

+1
mvninstall
555
the patch passed

+1
compile
381
the patch passed

+1
javac
381
the patch passed

+1
checkstyle
84
the patch passed

+1
mvnsite
0
the patch passed

+1
whitespace
0
The patch has no whitespace issues.

+1
shadedclient
662
patch has no errors when building and testing our client artifacts.

+1
javadoc
167
the patch passed

+1
findbugs
632
the patch passed

_ Other Tests _

+1
unit
305
hadoop-hdds in the patch passed.

-1
unit
1698
hadoop-ozone in the patch failed.

+1
asflicense
35
The patch does not generate ASF License warnings.

7428

Reason
Tests

Failed junit tests
hadoop.ozone.client.rpc.TestCommitWatcher

hadoop.hdds.scm.pipeline.TestPipelineClose

hadoop.ozone.client.rpc.TestOzoneAtRestEncryption

hadoop.ozone.client.rpc.TestOzoneRpcClient

hadoop.ozone.client.rpc.TestSecureOzoneRpcClient

hadoop.ozone.om.TestScmSafeMode

hadoop.ozone.client.rpc.TestOzoneRpcClientWithRatis

Subsystem
Report/Notes

Docker
Client=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/hadoop-multibranch/job/PR-1216/1/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/1216

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient findbugs checkstyle

uname
Linux 14cc1a017ec2 4.4.0-138-generic #164-Ubuntu SMP Tue Oct 2 17:16:02 UTC 2018 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
personality/hadoop.sh

git revision
trunk / b964b81

Default Java
1.8.0_212

unit
https://builds.apache.org/job/hadoop-multibranch/job/PR-1216/1/artifact/out/patch-unit-hadoop-ozone.txt

Test Results
https://builds.apache.org/job/hadoop-multibranch/job/PR-1216/1/testReport/

Max. process+thread count
4524 (vs. ulimit of 5500)

modules
C: hadoop-ozone/ozone-manager hadoop-ozone/integration-test U: hadoop-ozone

Console output
https://builds.apache.org/job/hadoop-multibranch/job/PR-1216/1/console

versions
git=2.7.4 maven=3.3.9 findbugs=3.1.0-RC1

Powered by
Apache Yetus 0.10.0 http://yetus.apache.org

This message was automatically generated.


CompactLogicx issue when write array

Array 3 items
conn.initiateConnection({port: 44818, host: '<IP_ADDRESS>' , routing: [0x01 ,0x00,0x01,0x00 ]}, connected);
//works fine
conn.writeItems('N7:0', [66], valuesWritten);  // You can write a single array item too.
//this works fine too
conn.writeItems('N7:1,2', [256,44], valuesWritten);
//but this throw error
 conn.writeItems('N7:0,1,2', [15,66,26], valuesWritten);

All log
[17229,512552929] Initiate Called - Connecting to PLC with address and parameters:
[17229,514342543] { port: 44818, host: '<IP_ADDRESS>', routing: [ 1, 0, 1, 0 ] }
[17229,516549778] Connection cleanup is happening
[17229,517895964 <IP_ADDRESS>] Attempting to connect to host...
[17229,520609974 <IP_ADDRESS>] TCP Connection Established to <IP_ADDRESS> on port 44818 - Will attempt EIP Connection
[17229,526448776 <IP_ADDRESS>] EIP Register Session Response Received - connection confirmed
[17229,527033550 <IP_ADDRESS>] Session Handle is 0xF024D00
[17229,527443668 <IP_ADDRESS>] Preparing to WRITE N7:0,1,2

buffer.js:784
    throw TypeError('value is out of bounds');
          ^
TypeError: value is out of bounds
    at TypeError (<anonymous>)
    at checkInt (buffer.js:784:11)
    at Buffer.writeInt16LE (buffer.js:900:5)
    at bufferizePCCCItem (/media/mer/sshd/Projekty/RFID/src/node_modules/nodepccc/nodePCCC.js:1841:25)
    at NodePCCC.prepareWritePacket (/media/mer/sshd/Projekty/RFID/src/node_modules/nodepccc/nodePCCC.js:542:3)
    at NodePCCC.writeItems (/media/mer/sshd/Projekty/RFID/src/node_modules/nodepccc/nodePCCC.js:328:7)
    at NodePCCC.connected [as connectCallback] (/media/mer/sshd/Projekty/RFID/src/bradleyTest/test.js:24:10)
    at NodePCCC.onEIPConnectReply (/media/mer/sshd/Projekty/RFID/src/node_modules/nodepccc/nodePCCC.js:280:8)
    at Socket.<anonymous> (/media/mer/sshd/Projekty/RFID/src/node_modules/nodepccc/nodePCCC.js:225:26)
    at Socket.EventEmitter.emit (events.js:95:17)

This looks like register 0 is not accessible via write array.
Am I doing something wrong?

I think it is just the syntax you are using, and I will leave the issue open as it should have logged an error instead of crashing, and I will fix that eventually, but..
If you want to write an array of 3 integers starting at N7:0, try writing using:
...
conn.writeItems('N7:0,3', [15,66,26], valuesWritten);
...
N7:0 is the start address and 3 is the array length.  You don't need to specify the middle elements.  Just like a much longer array would be N7:0,100.
Please try this and let me know.

I am closing as I believe this works.


[Graphql] Update node version

Update node.js version:

[x] docker
[x] staging
[ ] production

JFYI: https://github.com/metaspace2020/metaspace/pull/637

Install NVM (already installed)
curl https://raw.githubusercontent.com/creationix/nvm/master/install.sh | bash
source ~/.bashrc

Upgrade to the new version (v16.20)
v18 is the LTS, but it is not compatible with ubuntu 18.04.
# Install the version
nvm install 16.20.0

# Set 16.20.0 as default
nvm alias default 16.20.0

# Update default version to be used
nvm use default

I see next on logs:
npm notice
npm notice New major version of npm available! 8.19.4 -> 9.6.6
npm notice Changelog: https://github.com/npm/cli/releases/tag/v9.6.6
npm notice Run npm install -g<EMAIL_ADDRESS>to update!
npm notice

I think it is necessary to update npm too?

I see next on logs:
npm notice
npm notice New major version of npm available! 8.19.4 -> 9.6.6
npm notice Changelog: https://github.com/npm/cli/releases/tag/v9.6.6
npm notice Run npm install -g<EMAIL_ADDRESS>to update!
npm notice

I think it is necessary to update npm too? @lmacielvieira

For now let's leave this version, which is matching to node v16. Once we update to the latest node, after updating ubuntu, we also update the npm.


Length of peripheral/transit input boxes are too wide

It feels like the width of the numeric input boxes is too wide in comparison to the rest of the buttons in the same column and also given the small amount of text they will contain. Perhaps they could be made less wide

Agree. Reduced the size by 30%.


feat(icons): add projection-first and projection-third

What is the purpose of this pull request?

[x] New Icon
[ ] Bug fix
[ ] New Feature
[ ] Documentation update
[ ] Other:

Description

Adds icons for the standard symbols representing first and third angle projections.
Icon use case

These symbols are used:

in technical drawings to indicate the projection method
in some mathematical contexts for a similar purpose
in some 3D applications for a similar purpose

Alternative icon designs

Icon Design Checklist
Concept

[x] I have provided valid use cases for each icon.
[x] I have not added any a brand or logo icon.
[x] I have not used any hate symbols.
[x] I have not included any religious or political imagery.

Author, credits & license

[ ] The icons are solely my own creation.
[ ] The icons were originally created in # by @
[ ] I've based them on the following Lucide icons:
[x] I've based them on the following design: ISO 128-30:2001 A.2, ISO 128-30:2001 B.2

Naming

[x] I've read and followed the naming conventions
[x] I've named icons by what they are rather than their use case.
[x] I've provided meta JSON files in icons/[iconName].json.

Design

[x] I've read and followed the icon design guidelines
[x] I've made sure that the icons look sharp on low DPI displays.
[x] I've made sure that the icons look consistent with the icon set in size, optical volume and density.
[x] I've made sure that the icons are visually centered.
[x] I've correctly optimized all icons to three points of precision.

Before Submitting

[x] I've read the Contribution Guidelines.
[x] I've checked if there was an existing PR that solves the same issue.

Feels to dense.

I'm not familiar with the use cases, can you provide some example screenshots?

volume based variant
Open lucide studio
Open lucide studio


Support multiple parents

Sometimes words have more than one parent, depending on context.
Spanish example:  in "Él se siente mejor," the verb is "sentirse", to feel.  But in the below extract, it's "sentarse", to sit down:

Yo hice ademán de tomar asiento.    —¿Quién le ha dicho que se siente? —murmuró don Basilio

Czech example (from Mycheze in Discord):

hoře is a a declension of hora the regular form of hoře and a conjugation of hořet. Two nouns and a verb all use the same "word." And their meanings aren't even close. First one's mountain, second's is sorrow or grief and the verb is to feel love.

App design
Things to consider

would a word with multiple parents have the same status for each parent?  e.g. would "se siente" have the same status, even though it's really two different words?  I think that should be good enough -- doesn't occur often enough to make a big difference, and gets very messy/impossible otherwise.
when presenting the mouseover pop-up, presumably just list both parents, one after the other, with all of their extra data.
when showing term references, will need to include multiple parents and all the children - perhaps separated by parent, so that the meanings aren't interleaved

UX
For users, I think using "tags" as the parents would be easiest, allowing spaces in the tags, and making an ajax call to get the current list of words.  I like the way that Lute currently shows the parent's definition in the dropdown:

I'm not sure how to replicate that with tags.

Added to the develop branch, will smoke test it for a bit on my prod site before launching it.

Launched in https://github.com/jzohrab/lute/releases/tag/v2.0.13.  :tada:


Custom Retry Strategy

Hello,
I am wondering why it is not possible to set a custom retry strategy in case of job failure:
More precisely, the developer can only define the way backoff must be increased (either exponentially or linearly) but it is not possible to change initial backoff value nor maximum backoff value (they are set to 30 sec and 3600 sec respectively and they cannot be changed).
Thanks!

It is possible, just not well documented:
https://github.com/firebase/firebase-jobdispatcher-android/issues/115

Thanks a lot!


Support for secret files

It would be great to be able to pass the API token as a file instead of an environment variable, using secret mounts in Docker swarm, for example. This could be implemented by allowing to set the API_TOKEN_FILE environment variable to a path of a file containing the actual token; the code would need to check whether that variable is set and points to a readable file, then read that; otherwise, fall back to the API_TOKEN environment variable.
If you're interested, I'm happy to send a PR!

Hi there! It's great to see you contributing! This product is open-source, which means you're welcome to make as many requests as you'd like. We appreciate your help and hope you enjoy being part of our community!

PR #12  resolved the problem, thanks to @Radiergummi's efforts.


Could you please support poetry?

I like poetry.
I like kivy too.
But I don't know how to like them meanwhile.
So, how to install kivy with poetry?

I'm not familiar with poetry, but from a brief look you do poetry add kivy[base]==2.0.0. So basically it's the same as the pip install commands shown in the docs, except you write poetry add ... instead of pip install ....

poetry add kivy[base]==2.0.0 did not work for me because neither pip nor poetry are able to find this package.
What you can do instead, @dada0z is to install this using the poetry add command which supports git and also supports downloaded packages. To learn more about these commands, check the poetry docs: https://python-poetry.org/docs/cli/#add
To do this for the stable release of kivy using poetry, try:
poetry add https://github.com/kivy/kivy/archive/stable.zip
You could also use poetry add git+<.git REPO LINK>#<BRANCH>


feat (templates): [cluster] migrate to bicep

closes: #571187
WHY
we wanted to move our last ARM json template (cluster-stamp) to bicep, so we fully support this lang for deploying from the AKS Baseline.
What Changed?

all API version were updated to the latest
follow bicep templating in AKS Baseline
create separated submodules for Ensure deployments
added default property values when possible
previous resource comments are now migrated to actual code comments
remove the arm json template  & modify instructions to use the bicep
align previous usage of role definition ids. We are still concatenating, ideally in the future this should be moved over existing resources.

HOW to Test?
You should be able to follow the instructions and successfully deploy an AKS Baseline cluster having a full bicep experience along the road.

w00t @ckittel current version is working.

Nice work!  Just one more small observation ^, and this can be merged.

Great job, @ferantivero & @ckittel. Thank you guys!


[CLDC-1222] (WIP) Convert lettings log import to background job

Introduces wisper, resque jobs to process long-runing tasks

@mseedat-moj we already use redis and sidekiq for queueing and background job processing so probably better to use those here also rather than introducing wisper and resque as well


Improve Get-VMInformation.ps1

This should greatly improve the performance of Get-VMInformation.ps1 (my testing showed a ~3.5x speed increase), make it more portable (does not require rsc/rsc.exe and can run anywhere PowerShell >= 3.0 will), and cleans up the credential handling to make it more secure.

So I tried this script out on Windows today and it has a small issue that I'm going to attempt to fix by using System.Net.Http.HttpClient anywhere that I need to do a GET against an API endpoint and also provide a body.
In my script I attempt to gather information about an account using this endpoint via:
Invoke-RestMethod -Uri https://$endpoint/api/accounts/$account -Headers $headers -Method GET -WebSession $webSessions["$account"] -Body "email=$($rscreds.UserName)&password=$($rscreds.GetNetworkCredential().Password)&account_href=/api/accounts/$account"

It appears that your API requires that credentials for this call be sent in the body of the GET request in order to be authorized, and, although that is RFC-compliant, .NET does not support it as a part of Invoke-RestMethod.  I am not familiar with System.Net.Http.HttpClient but I'm going to see if I can move to it instead.  I do not get this issue on my macOS system.

@JonZeolla You should be able to use a web session cookie as an alternative. Auth once, and use the web session for the subsequent calls.
Auth: https://github.com/rs-services/cos_assets/blob/master/RightLink_Utilization/Get-OrgUtilizationData.ps1#L52-L63
Use web session: https://github.com/rs-services/cos_assets/blob/master/RightLink_Utilization/Get-OrgUtilizationData.ps1#L97
RS API Example Docs: http://docs.rightscale.com/api/api_1.5_examples/authentication.html#powershell-example-call

That last commit should fix it up, I was already using a web session cookie but it appears that when I last attempted this without a -Body on the GET requests, I was adding account_href as a filter to  my calls against instances which was failing because you can't do that.  I need to test this on Windows still, but it worked fine on my macOS box.

@srpomeroy is there a better way to approach this other than asking for the endpoint for each account specified, or just trying all of the possible endpoints?  I looked for it in the documentation but wasn't able to find a single smart URL endpoint so we don't need the us-3, us-4 stuff.  In my script if someone provides a parent account it will automatically pull the right endpoints for the children.

Okay, tested this on Windows and macOS, both are working just fine.  Ready for review.

@rshade merged in #14


Fix compile errors for all feature combinations

Floresta-chain

The bitcoin/bitcoinconsensus feature was still needed for the verify_with_flags method on Transaction
BlockHeader is used without the feature

Floresta-cli

Made jsonrpc not optional, as it is needed for the main function to actually run a client
Changed the way we get the florestad path

Floresta-common

Remove no-std feature to avoid the mutually exclusive features, as advised in https://doc.rust-lang.org/cargo/reference/features.html#mutually-exclusive-features. If std feature is not set, we are in no_std

Floresta-watch-only

Update the common dependency accordingly

Florestad

Make json-rpc feature use compact-filters as the Rpc trait methods require compact filters
Missing conditional compilation

Rust script to check all feature combinations
Since we don't have yet a CI check to know whether all feature combinations compile (and compiled tests are successful), here's a helpful Rust script. It requires itertools as dependency.

Rust script
use itertools::Itertools;
use std::process::{Command, Stdio};

const BASE_DIR: &str = "/your/path/to/Floresta";

fn main() {
    // Define crates and features in a list format
    let crates = vec![
        ("floresta-chain", vec!["bitcoinconsensus"]),
        ("floresta-cli", vec![]), // No features
        (
            "floresta-common",
            vec!["std", "descriptors-std", "descriptors-no-std"],
        ),
        ("floresta-compact-filters", vec![]), // No features
        ("floresta-electrum", vec![]),        // No features
        ("floresta-watch-only", vec!["memory-database", "std"]),
        ("floresta-wire", vec!["pruned_utreexo_chainstate"]),
        (
            "floresta",
            vec![
                "bitcoinconsensus",
                "memory-database",
                "electrum-server",
                "watch-only-wallet",
            ],
        ),
        (
            "florestad",
            vec![
                "compact-filters",
                "zmq-server",
                "experimental-p2p",
                "json-rpc",
            ],
        ),
    ];

    for (crate_name, features) in crates {
        // Determine the path to the crate's Cargo.toml
        let path = get_path(crate_name);

        println!("\nRunning tests for {crate_name} with {MAGENTA}default{RESET} features...\n");
        if crate_name == "floresta-cli" {
            build_florestad();
        }
        test_default(&path, crate_name);

        if features.is_empty() {
            // If there are no features we have already checked all the possibilities
            continue;
        }

        println!("\nRunning tests for {crate_name} with {MAGENTA}no{RESET} features...\n");
        test_no_features(&path, crate_name);

        // Loop through each feature combination to test it
        let len = features.len();
        let combinations = (1..=len).flat_map(|n| features.iter().cloned().combinations(n));

        for comb in combinations {
            let feature_list = comb.iter().join(", ");
            println!(
                "\nRunning tests for {crate_name} with features: {MAGENTA}{feature_list}{RESET}\n"
            );
            test_features(&path, crate_name, &feature_list);
        }
    }
}

fn test_features(path: &str, crate_name: &str, features: &str) {
    let status = Command::new("cargo")
        .args(&[
            "test",
            "--manifest-path",
            &format!("{}/Cargo.toml", path),
            "--no-default-features",
            "--features",
            features,
        ])
        .env("RUSTFLAGS", "-Awarnings") // Suppress warnings but keep errors
        .stdout(Stdio::null())
        .status()
        .expect("Failed to execute 'cargo test' with features");

    if !status.success() {
        panic!(
            "\n{}Tests failed for {} with features {}{}",
            RED, crate_name, features, RESET
        );
    } else {
        println!("OK");
    }
}

fn test_no_features(path: &str, crate_name: &str) {
    let status = Command::new("cargo")
        .args(&[
            "test",
            "--manifest-path",
            &format!("{}/Cargo.toml", path),
            "--no-default-features",
        ])
        .env("RUSTFLAGS", "-Awarnings") // Suppress warnings but keep errors
        .stdout(Stdio::null())
        .status()
        .expect("Failed to execute 'cargo test'");

    if !status.success() {
        panic!(
            "\n{}Tests failed for {} with no features{}",
            RED, crate_name, RESET
        );
    } else {
        println!("OK");
    }
}

fn test_default(path: &str, crate_name: &str) {
    let status = Command::new("cargo")
        .args(&["test", "--manifest-path", &format!("{}/Cargo.toml", path)])
        .env("RUSTFLAGS", "-Awarnings") // Suppress warnings but keep errors
        .stdout(Stdio::null())
        .status()
        .expect("Failed to execute 'cargo test'");

    if !status.success() {
        panic!(
            "\n{}Tests failed for {} with default features{}",
            RED, crate_name, RESET
        );
    } else {
        println!("OK");
    }
}

fn build_florestad() {
    let status = Command::new("cargo")
        .args(&[
            "build",
            "--manifest-path",
            &format!("{}/florestad/Cargo.toml", BASE_DIR),
        ])
        .env("RUSTFLAGS", "-Awarnings") // Suppress warnings but keep errors
        .stdout(Stdio::null())
        .status()
        .expect("Failed to execute 'cargo test'");
    assert!(status.success(), "Couldn't compile florestad");
}

fn get_path(crate_name: &str) -> String {
    if crate_name == "florestad" {
        format!("{}/{}", BASE_DIR, crate_name) // 'florestad' is in the root of base_dir
    } else {
        format!("{}/crates/{}", BASE_DIR, crate_name) // Other crates are under 'crates/' in base_dir
    }
}

const RESET: &str = "\x1b[0m";
const MAGENTA: &str = "\x1b[1;35m";
const RED: &str = "\x1b[91m";

Pushed to solve a fmt lint ;)

Small improvement: eliminated some implicit features by adding dep: and made memory-database feature actually optional

ACK 19be41c. The script you made is very handy!


Memory leaks in 'tlse.c'

When checking with "valgrind --leak-check=full", it seems some memory leaks are detected:

==30771== 38,400 bytes in 1 blocks are definitely lost in loss record 41 of 50
==30771==    at 0x4C2FD5F: realloc (in /usr/lib/valgrind/vgpreload_memcheck-amd64-linux.so)
==30771==    by 0x44B2F9: tls_load_root_certificates (tlse.c:9525)
==30771==    by 0x44BBEC: SSL_CTX_root_ca (tlse.c:9869)
==30771==    by 0x44FF61: SSL_CONNECT (ssl.SSL_CONNECT.h:31)
==30771==
==30771== 256,122 bytes in 1 blocks are definitely lost in loss record 42 of 50
==30771==    at 0x4C2DB8F: malloc (in /usr/lib/valgrind/vgpreload_memcheck-amd64-linux.so)
==30771==    by 0x44BB8D: SSL_CTX_root_ca (tlse.c:9865)
==30771==    by 0x44FF61: SSL_CONNECT (ssl.SSL_CONNECT.h:31)

The latter can easily be fixed by adding a 'TLS_FREE(buf)' at line 9883 but I guess this is not the preferred way?

Thanks for reporting this. I think I fixed it, but I cannot test it now. Can you confirm it is OK?

Thanks, that is fast! And indeed, your fixes solve the issue. All OK on my side now.

Yes, it can be closed.


(fix) nvidia resource limits "classic mode"

What this PR does / why we need it: fixes reference so that classic mode workflow vars look in the right addon
Which issue this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close that issue when PR gets merged): fixes #
Special notes for your reviewer:
If applicable:

[ ] documentation
[ ] unit tests
[ ] tested backward compatibility (ie. deploy with previous version, upgrade with this branch)

Release note:

NONE

@ritazh fyi


Cede back connection pool control to user Was: Singleton per connection params PG connection pool

Right now there is a connection pool per instance of PGVectorHelper subclass. This causes problems when multiple are used. It should be a Singleton as best can be managed.

That's done. Alas it's another breaking change.


bug: Class init parameter name disappears from attribute docstring using separate_signature

Description of the bug
When calling a method on an input argument to a class __init__ while having separate_signature: true, the parameter name disappears from the rendered instance attribute docstring, leaving only the attribute name and the method called on the input argument.
To Reproduce

python -m venv .venv
. .venv/bin/activate
pip install mkdocstrings-python
python

# mkdocs.yml
site_name: test-site
plugins:
  - mkdocstrings:
      default_handler: python
      handlers:
        python:
          options:
            separate_signature: true

<!-- test.md -->
::: test

# test.py

class SomeClass:
    """This is a class that does something."""

    def __init__(self, some_float: float) -> None:
        self.as_hex = some_float.hex()
        """The hex value of the input float."""

Expected behavior

I expect the rendered docstring for the as_hex instance attribute to say as_hex = some_float.hex().
Actual behavior

With separate_signature: true, the some_float part disappears, and what is rendered is only as_hex = hex().
Environment information
python -m mkdocstrings_handlers.python.debug  # | xclip -selection clipboard

System: Linux-6.8.0-49-generic-x86_64-with-glibc2.39
Python: cpython 3.13.1 (/home/stefan/test-mkdocstrings/.venv/bin/python)
Environment variables:
Installed packages:

mkdocs v1.6.1
mkdocstrings v0.27.0
mkdocstrings-python v1.12.2
griffe v1.5.1

Thanks for the report @connesy.
This behavior is configurable with this setting: https://mkdocstrings.github.io/python/usage/configuration/signatures/#annotations_path.
Note though that we already have one special case, for enumeration values: Class.ENUM_VALUE.value will not be shortened to value (which wouldn't be cross-reference'able) but to ENUM_VALUE.value. We could consider doing the same thing for other kinds of objects. I suppose some_float here is a float? Not sure how hard it would be.

I suppose some_float here is a float?

Yes, there's a reproducible example in the details of my issue.

This behavior is configurable with this setting: https://mkdocstrings.github.io/python/usage/configuration/signatures/#annotations_path.

I would think this would be a different setting (if it existed) thanannotations_path, since this is not about the type annotation of the argument, but the actual value of the instance attribute.

Yeah, I agree that would make more sense.

I guess it could follow the value of annotatipns_path, but only shorten objects paths, not method and attribute paths.
import module.submodule

class SomeClass:
    def __init__(self, value: module.submodule.SomeType):
        self.parsed_value = module.submodule.module_instance.method()

In this case, the type annotation will be shortened (or not) based on annotations_path, but so could parsed_value, e.g. module_instance.method() for brief and module.submodule.module_instance.method() for full.

So basically removing all parts that are modules. I can imagine a few edge cases where users would still want to show the module parts because otherwise the rest would be ambiguous (several different modules providing a function with the same name for example). The safest bet here is to render what's in the source. Any other "smart" shortening would feel a bit arbitrary IMO.
I'll review existing docs to see how this setting is used, and how it affects attributes rendering, and whether we can easily change it without breaking use-cases.


Slow start mode "expires" when more members added to the cluster.

Title: Slow start mode "expires" when more members added to the cluster.
Description:

When a new member joins the cluster and slow start is configured the current pod which still should be in slow start are getting all the request that they would as if the slow start window finished already. One picture is worth a thousand words so please see the attached screenshot:

You can see that the red line starts gradually which is what I'd expect from a slow start however once the new pod (member) is added (the green line) the amount of requests directed to the red line suddenly jumps. The slow starts is configured for 300s but the "jolt" happens within a bit more than one minute from the start.
Repro steps:

kubectl scale --replicas=2 deploy/aiohttp-service; sleep 75; kubectl scale --replicas=3 deploy/aiohttp-service

   "ISTIO_VERSION": "1.17.3",
   "version": "43cd81989c499d2382fd80ac077b14d728fe41eb/1.25.7-dev/Clean/RELEASE/BoringSSL",

edit: fixed my english a bit

This is somewhat related to #28512 so I'm going to highlight @nezdolik (I hope that's okay).

@palmobar i believe this issue has been reported by Istio users before and i was not able to reproduce the problem with vanilla Envoy setup, so more information from your side will be useful. Could you provide:

All the slow start configuration you are using (slow_start_window, aggression, min_weight_percentage)
Load balancer type
Was there any change in red pod health status during the slow start window?

@nezdolik There was no change in pod's health (there is no health check configured at all, except the istio's injected sidecar has readiness probe defined), please see the cluster's configuration (taken from envoy's dump) on the bottom. I believe the relevant bit is that one:
      "round_robin_lb_config": {
       "slow_start_config": {
        "slow_start_window": "300s"
       }
      }

The istio configuration looks like the following:
$ kubectl get destinationrule/aiohttp-service -o yaml # removed uninteresting bits (like annotations and labels) for brevity
apiVersion: networking.istio.io/v1beta1
kind: DestinationRule
[...]
spec:
  host: aiohttp-service
  trafficPolicy:
    loadBalancer:
      simple: ROUND_ROBIN
      warmupDurationSecs: 300s

    {
     "version_info": "2023-08-14T14:19:53Z/53",
     "cluster": {
      "@type": "type.googleapis.com/envoy.config.cluster.v3.Cluster",
      "name": "outbound|8080||aiohttp-service.default.svc.cluster.local",
      "type": "EDS",
      "eds_cluster_config": {
       "eds_config": {
        "ads": {},
        "initial_fetch_timeout": "0s",
        "resource_api_version": "V3"
       },
       "service_name": "outbound|8080||aiohttp-service.default.svc.cluster.local"
      },
      "connect_timeout": "10s",
      "circuit_breakers": {
       "thresholds": [
        {
         "max_connections":<PHONE_NUMBER>,
         "max_pending_requests":<PHONE_NUMBER>,
         "max_requests":<PHONE_NUMBER>,
         "max_retries":<PHONE_NUMBER>,
         "track_remaining": true
        }
       ]
      },
      "metadata": {
       "filter_metadata": {
        "istio": {
         "default_original_port": 8080,
         "services": [
          {
           "name": "aiohttp-service",
           "host": "aiohttp-service.default.svc.cluster.local",
           "namespace": "default"
          }
         ],
         "config": "/apis/networking.istio.io/v1alpha3/namespaces/default/destination-rule/aiohttp-service"
        }
       }
      },
      "common_lb_config": {
       "locality_weighted_lb_config": {}
      },
      "filters": [
       {
        "name": "istio.metadata_exchange",
        "typed_config": {
         "@type": "type.googleapis.com/envoy.tcp.metadataexchange.config.MetadataExchange",
         "protocol": "istio-peer-exchange"
        }
       }
      ],
      "transport_socket_matches": [
       {
        "name": "tlsMode-istio",
        "match": {
         "tlsMode": "istio"
        },
        "transport_socket": {
         "name": "envoy.transport_sockets.tls",
         "typed_config": {
          "@type": "type.googleapis.com/envoy.extensions.transport_sockets.tls.v3.UpstreamTlsContext",
          "common_tls_context": {
           "tls_params": {
            "tls_minimum_protocol_version": "TLSv1_2",
            "tls_maximum_protocol_version": "TLSv1_3"
           },
           "alpn_protocols": [
            "istio-peer-exchange",
            "istio"
           ],
           "tls_certificate_sds_secret_configs": [
            {
             "name": "default",
             "sds_config": {
              "api_config_source": {
               "api_type": "GRPC",
               "grpc_services": [
                {
                 "envoy_grpc": {
                  "cluster_name": "sds-grpc"
                 }
                }
               ],
               "set_node_on_first_message_only": true,
               "transport_api_version": "V3"
              },
              "initial_fetch_timeout": "0s",
              "resource_api_version": "V3"
             }
            }
           ],
           "combined_validation_context": {
            "default_validation_context": {
             "match_subject_alt_names": [
              {
               "exact": "spiffe://cluster.local/ns/default/sa/default"
              }
             ]
            },
            "validation_context_sds_secret_config": {
             "name": "ROOTCA",
             "sds_config": {
              "api_config_source": {
               "api_type": "GRPC",
               "grpc_services": [
                {
                 "envoy_grpc": {
                  "cluster_name": "sds-grpc"
                 }
                }
               ],
               "set_node_on_first_message_only": true,
               "transport_api_version": "V3"
              },
              "initial_fetch_timeout": "0s",
              "resource_api_version": "V3"
             }
            }
           }
          },
          "sni": "outbound_.8080_._.aiohttp-service.default.svc.cluster.local"
         }
        }
       },
       {
        "name": "tlsMode-disabled",
        "match": {},
        "transport_socket": {
         "name": "envoy.transport_sockets.raw_buffer",
         "typed_config": {
          "@type": "type.googleapis.com/envoy.extensions.transport_sockets.raw_buffer.v3.RawBuffer"
         }
        }
       }
      ],
      "round_robin_lb_config": {
       "slow_start_config": {
        "slow_start_window": "300s"
       }
      }
     },
     "last_updated": "2023-08-14T14:19:53.526Z"
    },

Please let me know if there is any information or experiment I can provide/do so that it would help you to navigate/reproduce this issue

Also inspired by your question(s) I checked if during the expriment the pods change the state and it doesn't look like they do (e.g. the pod doesn't go into not ready state):
k get po --watch
[...]
aiohttp-service-99857644c-5wpzp   0/2     Pending   0          0s
aiohttp-service-99857644c-5wpzp   0/2     Pending   0          0s
aiohttp-service-99857644c-5wpzp   0/2     Init:0/1   0          0s
aiohttp-service-99857644c-5wpzp   0/2     PodInitializing   0          1s
aiohttp-service-99857644c-5wpzp   1/2     Running           0          2s
aiohttp-service-99857644c-5wpzp   2/2     Running           0          3s
aiohttp-service-99857644c-2gd7b   0/2     Pending           0          0s
aiohttp-service-99857644c-2gd7b   0/2     Pending           0          0s
aiohttp-service-99857644c-2gd7b   0/2     Init:0/1          0          0s
aiohttp-service-99857644c-2gd7b   0/2     PodInitializing   0          2s
aiohttp-service-99857644c-2gd7b   1/2     Running           0          3s
aiohttp-service-99857644c-2gd7b   2/2     Running           0          3s

I started playing a bit more with pods around and found something very very weird, so where there is no slow start defined and I scale up deployment in a succession 1 -> 2 -> 3 you can see that the pods receive immediatelly their fair share of traffic like so (these tails on the left are due to how prometheus calculates each data point based on a time span of a range vector):

Now when slow start is in effect I'd expect to see something similar but the new pods would be ramping up slowly (over the slow start window) but instead I see this behaviour:

and this:

so it looks like when a new pod joins the cluster the older pod suddenly receives more traffic which is very very unexpected. Also when 1 pod is running and 2nd one joins then it immediatelly receives 50% of the traffic. When the 3rd pod joins then it ramps up slowly but the older pod all of a sudden is getting circa. 60% of the traffic (the second pod is receiveing around 30% of the traffic) and the third pod is receiving the rest while slowly ramping up.

/assign

We are seeing the same behavior (version 1.17.2)

@palmobar looking at your config you are using locality weighted load balancing. Are the 3 pods from the experiment in the same locality?

@nezdolik sorry for the slow answer but I was on family holidays with little access to the outside world.
How am I using locality weighted load balancing? In the config I can see locality_weighted_lb_config": {} which would mean that it's not set? Last time I was checking weights they're always the same for each pod.

Hi @palmobar, no worries. Are you able to curl clusters admin endpoint on Envoy pod?(E.g. curl http://{$ENVOY_POD_IP}:8001/clusters) and verify that all endpoints for the cluster from test belong to same priority and locality? (or attach the output for cluster here so i could verify).
LocalityWeighhtedLbConfig proto message does not have any fields, so when locality_weighted_lb_config field is configured it enables locality weighted load balancing in conjunction with supplied load balancing weights and localities for endpoints: https://www.envoyproxy.io/docs/envoy/latest/intro/arch_overview/upstream/load_balancing/locality_weight

@nezdolik
I was already looking into that before in this ticket here: https://github.com/envoyproxy/envoy/issues/28512
Here is the clusters for the cluster on which I can reproduce the issue. Looks like the envoy port is only on localhost so I did this (I changed the ip addresses). There are three pods in the cluster:
$ istioctl dashboard envoy aiohttp-service-99857644c-4g94z --browser=false
$ curl -LSs http://localhost:15000/clusters | grep aiohttp-service
outbound|8080||aiohttp-service.default.svc.cluster.local::observability_name::outbound|8080||aiohttp-service.default.svc.cluster.local
outbound|8080||aiohttp-service.default.svc.cluster.local::default_priority::max_connections::4294967295
outbound|8080||aiohttp-service.default.svc.cluster.local::default_priority::max_pending_requests::4294967295
outbound|8080||aiohttp-service.default.svc.cluster.local::default_priority::max_requests::4294967295
outbound|8080||aiohttp-service.default.svc.cluster.local::default_priority::max_retries::4294967295
outbound|8080||aiohttp-service.default.svc.cluster.local::high_priority::max_connections::1024
outbound|8080||aiohttp-service.default.svc.cluster.local::high_priority::max_pending_requests::1024
outbound|8080||aiohttp-service.default.svc.cluster.local::high_priority::max_requests::1024
outbound|8080||aiohttp-service.default.svc.cluster.local::high_priority::max_retries::3
outbound|8080||aiohttp-service.default.svc.cluster.local::added_via_api::true
outbound|8080||aiohttp-service.default.svc.cluster.local::eds_service_name::outbound|8080||aiohttp-service.default.svc.cluster.local
outbound|8080||aiohttp-service.default.svc.cluster.<IP_ADDRESS>:8080::cx_active::0
outbound|8080||aiohttp-service.default.svc.cluster.<IP_ADDRESS>:8080::cx_connect_fail::0
outbound|8080||aiohttp-service.default.svc.cluster.<IP_ADDRESS>:8080::cx_total::0
outbound|8080||aiohttp-service.default.svc.cluster.<IP_ADDRESS>:8080::rq_active::0
outbound|8080||aiohttp-service.default.svc.cluster.<IP_ADDRESS>:8080::rq_error::0
outbound|8080||aiohttp-service.default.svc.cluster.<IP_ADDRESS>:8080::rq_success::0
outbound|8080||aiohttp-service.default.svc.cluster.<IP_ADDRESS>:8080::rq_timeout::0
outbound|8080||aiohttp-service.default.svc.cluster.<IP_ADDRESS>:8080::rq_total::0
outbound|8080||aiohttp-service.default.svc.cluster.<IP_ADDRESS>:8080::hostname::
outbound|8080||aiohttp-service.default.svc.cluster.<IP_ADDRESS>:8080::health_flags::healthy
outbound|8080||aiohttp-service.default.svc.cluster.<IP_ADDRESS>:8080::weight::1
outbound|8080||aiohttp-service.default.svc.cluster.<IP_ADDRESS>:8080::region::eu-west-1
outbound|8080||aiohttp-service.default.svc.cluster.<IP_ADDRESS>:8080::zone::eu-west-1b
outbound|8080||aiohttp-service.default.svc.cluster.<IP_ADDRESS>:8080::sub_zone::
outbound|8080||aiohttp-service.default.svc.cluster.<IP_ADDRESS>:8080::canary::false
outbound|8080||aiohttp-service.default.svc.cluster.<IP_ADDRESS>:8080::priority::0
outbound|8080||aiohttp-service.default.svc.cluster.<IP_ADDRESS>:8080::success_rate::-1
outbound|8080||aiohttp-service.default.svc.cluster.<IP_ADDRESS>:8080::local_origin_success_rate::-1
outbound|8080||aiohttp-service.default.svc.cluster.<IP_ADDRESS>:8080::cx_active::0
outbound|8080||aiohttp-service.default.svc.cluster.<IP_ADDRESS>:8080::cx_connect_fail::0
outbound|8080||aiohttp-service.default.svc.cluster.<IP_ADDRESS>:8080::cx_total::0
outbound|8080||aiohttp-service.default.svc.cluster.<IP_ADDRESS>:8080::rq_active::0
outbound|8080||aiohttp-service.default.svc.cluster.<IP_ADDRESS>:8080::rq_error::0
outbound|8080||aiohttp-service.default.svc.cluster.<IP_ADDRESS>:8080::rq_success::0
outbound|8080||aiohttp-service.default.svc.cluster.<IP_ADDRESS>:8080::rq_timeout::0
outbound|8080||aiohttp-service.default.svc.cluster.<IP_ADDRESS>:8080::rq_total::0
outbound|8080||aiohttp-service.default.svc.cluster.<IP_ADDRESS>:8080::hostname::
outbound|8080||aiohttp-service.default.svc.cluster.<IP_ADDRESS>:8080::health_flags::healthy
outbound|8080||aiohttp-service.default.svc.cluster.<IP_ADDRESS>:8080::weight::1
outbound|8080||aiohttp-service.default.svc.cluster.<IP_ADDRESS>:8080::region::eu-west-1
outbound|8080||aiohttp-service.default.svc.cluster.<IP_ADDRESS>:8080::zone::eu-west-1c
outbound|8080||aiohttp-service.default.svc.cluster.<IP_ADDRESS>:8080::sub_zone::
outbound|8080||aiohttp-service.default.svc.cluster.<IP_ADDRESS>:8080::canary::false
outbound|8080||aiohttp-service.default.svc.cluster.<IP_ADDRESS>:8080::priority::0
outbound|8080||aiohttp-service.default.svc.cluster.<IP_ADDRESS>:8080::success_rate::-1
outbound|8080||aiohttp-service.default.svc.cluster.<IP_ADDRESS>:8080::local_origin_success_rate::-1
outbound|8080||aiohttp-service.default.svc.cluster.<IP_ADDRESS>:8080::cx_active::0
outbound|8080||aiohttp-service.default.svc.cluster.<IP_ADDRESS>:8080::cx_connect_fail::0
outbound|8080||aiohttp-service.default.svc.cluster.<IP_ADDRESS>:8080::cx_total::0
outbound|8080||aiohttp-service.default.svc.cluster.<IP_ADDRESS>:8080::rq_active::0
outbound|8080||aiohttp-service.default.svc.cluster.<IP_ADDRESS>:8080::rq_error::0
outbound|8080||aiohttp-service.default.svc.cluster.<IP_ADDRESS>:8080::rq_success::0
outbound|8080||aiohttp-service.default.svc.cluster.<IP_ADDRESS>:8080::rq_timeout::0
outbound|8080||aiohttp-service.default.svc.cluster.<IP_ADDRESS>:8080::rq_total::0
outbound|8080||aiohttp-service.default.svc.cluster.<IP_ADDRESS>:8080::hostname::
outbound|8080||aiohttp-service.default.svc.cluster.<IP_ADDRESS>:8080::health_flags::healthy
outbound|8080||aiohttp-service.default.svc.cluster.<IP_ADDRESS>:8080::weight::1
outbound|8080||aiohttp-service.default.svc.cluster.<IP_ADDRESS>:8080::region::eu-west-1
outbound|8080||aiohttp-service.default.svc.cluster.<IP_ADDRESS>:8080::zone::eu-west-1c
outbound|8080||aiohttp-service.default.svc.cluster.<IP_ADDRESS>:8080::sub_zone::
outbound|8080||aiohttp-service.default.svc.cluster.<IP_ADDRESS>:8080::canary::false
outbound|8080||aiohttp-service.default.svc.cluster.<IP_ADDRESS>:8080::priority::0
outbound|8080||aiohttp-service.default.svc.cluster.<IP_ADDRESS>:8080::success_rate::-1
outbound|8080||aiohttp-service.default.svc.cluster.<IP_ADDRESS>:8080::local_origin_success_rate::-1

The wights are:
outbound|8080||aiohttp-service.default.svc.cluster.<IP_ADDRESS>:8080::weight::1
outbound|8080||aiohttp-service.default.svc.cluster.<IP_ADDRESS>:8080::weight::1
outbound|8080||aiohttp-service.default.svc.cluster.<IP_ADDRESS>:8080::weight::1

Ok, so clearly there are multiple localities (zones) involved in this scenario. Will you be able to correlate which endpoint from the test/graph belonged to which zone? That would help to better craft the test to reproduce the issue programmatically.
Slow start does not work perfectly with cross priority, cross locality load balancing.

I think you might be onto something here, look at this graph:

The first two lines are:

red: zone eu-west-1c
green: zone eu-west-1a

The third line (a new pod introduced to the cluster:

teal: zone eu-west-1b

this line is jumping up to receive 33% of the traffic immediatelly (no warmup period applies) but the other pods decrease by equal amounts so it's like warmup was never in effect.
The fourth line (purple) is the same zone as the red line:

purple: zone eu-west-1c

You can see that the red line "jumps up" but also the purple line will get more traffic than the other pods, in here it looks like the wormup is in effect (to a degree at least).
The gold line is the same zone as purple and red:

gold: zone eu-west-1c

In here it looks like warmup is in effect, red and. purple pods "jump up" (same zone) other pods gradually lose share of the traffic.

@nezdolik so am I right in thinking that istio turns on locality load balancing by default which causes the slow start to be calculated separately for each locality?
After adjusting my DestinationRule in the following way the slow start feature works exactly as described:
apiVersion: networking.istio.io/v1beta1
kind: DestinationRule
metadata:
  annotations:
    kubectl.kubernetes.io/last-applied-configuration: |
  name: aiohttp-service
  namespace: default
spec:
  host: aiohttp-service
  trafficPolicy:
    loadBalancer:
      localityLbSetting:
        enabled: false
      simple: ROUND_ROBIN
      warmupDurationSecs: 180s

@palmobar i know little about Istio, but looking at Envoy config yes, locality weighted load balancing does not work well with slow start for your specific scenario.

@nezdolik should the documentation be updated to reflect that? It's not obvious for us mere mortals ;>

@palmobar definitely the docs need to be updated. Will do it next week.


/devportal and /manager redirects

Looks good so far but the login link from the /manager/gateways (http://oauth2proxy.localtest.me:4180/login?f=%2Fmanager%2Fgateways in local test), leads to the Login for Developers with various login options. It should go to the API Provider login

Fixed in latest commit

Still needs more work - the last commit adds ?identity=provider to all restricted pages including /devportal, e.g. /devportal/applications which is not appropriate.
I will add a conditional to look at the route and add provider only when appropriate and otherwise use the default (developer).


feat: updated color token of kyndryl logo

Summary
Updated Icons stories with new color token
ADO Story
Link here (if applicable).
Figma Link
https://www.figma.com/design/CQuDZEeLiuGiALvCWjAKlu/branch/qMpff4GuFUEcsMUkvacS3U/Applications---Component-Library?node-id=14889-81933&node-type=instance&m=dev
Checklist

[ ] Used Conventional Commit messages as outlined in the contributing guide.

[ ] Noted breaking changes (if any).

[ ] Documented/updated all props, events, slots, parts, etc with JSDoc.

[ ] Ran the analyze command to update Storybook docs.

[ ] Added/updated Stories with controls to cover all variants.
[ ] Ran test locally to address any failures.
[ ] Added/updated the Figma link for the Story's Design tab.

Screenshot

Out of Sync.Hence closing it.


[GLUTEN-1507][VL] fix issue that GlutenBroadcastJoinSuite run tests using spark without gluten enabled

What changes were proposed in this pull request?
fix glutenBroadcastJoinSuite test case run issue
(Fixes: #1507)
How was this patch tested?
manual tests via run the suit.

Run Gluten Clickhouse CI

@zzcclp CH backend fails with below error. Do you have any clue?
[ERROR] /home/jenkins/agent/workspace/Gluten/gluten-ci/gluten/gluten-ut/spark32/src/test/scala/org/apache/spark/sql/execution/joins/GlutenBroadcastJoinSuite.scala:22: error: object GlutenBroadcastHashJoinExecTransformer is not a member of package io.glutenproject.execution

there are some new import classes in [GlutenBroadcastJoinSuite.scala](https://github.com/oap-project/gluten/pull/1508/files/68816fca31fe8c9f1181c1129725ef441c0d77ee#diff-122faeeba795303466551f2ac9c31f8162aa7542e489b52c224ffd81cf7af7d9) which are only  for velox backend, please replace them with base abstract class


dUpdated the SEO in sanity for the 2021 conference, also updated the R…

…EADME.md file

This is just a change to the README file. Did you mean to have something else?

Nevermind, I see you messaged me that you updated stuff in Sanity


RTM failed to login

Describe the bug
When we are trying to login into RTM sdk its gives error code 2, I have generated token from console, tried both temp token and token generated by user id but same result, I have also tried to login by passing token as null as shown in example but no luck.
login failed errorCode:2
AgoraRtmClient.login (package:agora_rtm/src/agora_rtm_client.dart:229:7)
<asynchronous suspension>

I have used following latest dependency version
agora_rtm: ^1.5.0

same error

Has anyone found a solution to this problem? Please

Any solution yet?

have you double-checked your appId and token? BTW pls try the latest version.


Add exposeAdditionalProperties option

see #7 for motivation

Coverage remained the same at 100.0% when pulling fe4ea9a12acff4f0a9f667f8db02f3ac812a1819 on LinusU:expose-additional-properties into df765a50c0c1de4fdbe4ce9cef2d910df4d8ba3e on expressjs:master.

+1

ping @jonathanong, what do you think about this? ☺

I think it would be useful to specify either a truthy/falsy value or an array of properties to whitelist.
Some packages add additional error properties that you might not want to propagate to the user.


Update transformer version

Hello, I try to use hugging face api in my code, but the transformer version is too old(4.18) ,which is not compatible with my code, how can I get a newer transformer with OFA model ?

Hello，I had a problem similar to yours. Do you have the answer now?

same here, can't find OFAtokenizer and OFAmodel in transformers.

same question,have you guys ever solved the problem?


Authentication and Authorization for the GraphQL

The problem faced currently?
How can we solve it?

If you want this feature to be implemented, give it a thumbs up reaction, so that we can determine which features are important to you.
👍

👍 i think this feature is very Important！

Just to be clear, authentication and authorisation is already supported for GraphQL. This issue is regarding adding the user management endpoints to the GraphQL layer

This module will be removed


More details about adding a new stemmer.

For my use case - replacing one stemmer with advanced one - I had to go through all the process: creating Java stemmer from SBL algorithm, integrating it into the Java bundle, tweaking the bundle and then finally generating JavaScript files. I've refactored Readme completely - to split the process into individual steps and provide more details for each of them.

Thank you. Can we find some place for Quick Start (or env check) somewhere:
git clone https://github.com/mazko/jssnowball.git
cd jssnowball/
make bundle
git checkout -- js_snowball/eclipse/
make bundle
# edit js_snowball/lib/snowball.bundle.java :es6: code :end:
npm i -g babel-cli esjava
npm i babel-preset-es2015 babel-plugin-transform-es2015-modules-umd
make esjava

Sure, originally I had another How to build section for this, besides Adding a new stemmer. It turned out to be just simplified variant of same procedure so I removed it (expecting end user will skip unnecessary steps).
I have an idea how to integrate it. But I am afraid I still do not understand the following blocks, i.e. why make bundle is executed twice:
git clone https://github.com/mazko/jssnowball.git
cd jssnowball/
make bundle

git checkout -- js_snowball/eclipse/
make bundle

Is that second call necessary? Can you elaborate the purpose a bit?
Thanks.

make bundle twice is just workaround, it just works. The only purpose is somebody has to refactor makefile and split make bundle to more steps )

I considered that second make bundle to be a redundant step. But I did that procedure again and finally I am able to see some difference. In the first run Java stemmers are built from SBL files in

snowball_cache/out/java/org/tartarus/snowball/ext and
js_snowball/eclipse/src/org/tartarus/snowball/ext

That snowball.bundle.java bundle is hence built not from the original js_snowball/eclipse folder, but from the regenerated one.  So now it is clear why this folder has to be checked out again from GitHub.
But the is one remaining magic to me. Why the second run doesn't trigger regenerating Java code like in the first run?

But the is one remaining magic to me. Why the second run doesn't trigger regenerating Java code like in the first run?

I am not sure (this was a long time ago), but I guess $(java_src_out)/$(java_src_scheme)/%Stemmer.java  remains unchanged https://github.com/mazko/jssnowball/blob/master/GNUmakefile#L195 and thus makefile does not trigger this rule


Add source ID level HTML view

Description
Checklist
Please confirm that this pull request has done the following:

[ ] #91
[x] Documentation added (where applicable)
[x] Changelog item added to changelog/

Fix #93

again @znichollscr you are a magician, is this good to merge?

This looks good to directly, merge with no additional action required on my part - will do in 15, unless I hear back from you
Fix #93

@znichollscr looks like I have stuffed up, as the version info was not incremented... I am a little confused how that step folds in, it must be a post-merge process? Or just now a matter of triggering the Bump version action?

looks like I have stuffed up... Or just now a matter of triggering the Bump version action?

Nah we're all good, just trigger the bump version action now and off we go: https://github.com/PCMDI/input4MIPs_CVs/actions/workflows/bump.yaml.

(We could automate version incrementing in future, but I tend to have lots of MRs so we could quickly end up at 6.5.100 which seems more harmful than helpful to me...)

(We could automate version incrementing in future, but I tend to have lots of MRs so we could quickly end up at 6.5.100 which seems more harmful than helpful to me...)

At this moment I agree with you. For the CMIP6_CVs, which are far more stable, and not iterating daily, I have versioning baked into every commit.. But at this moment with all the iteration to a workable repo, manual is good for now.
Did we want to catch any other loose ends before 6.5.20 is minted?

Did we want to catch any other loose ends before 6.5.20 is minted?

I can do the fix to the different variants of abandoned, maybe after that?


[Diagnostics] A couple of clean-ups for AddMissingArguments

In preparation to extend this fix to support more then just closures:

Cover single explicit tuple argument -> N parameters via missing arguments fix

Expand tuple into N arguments to cover expect parameters.
This covers cases like this:
func foo(_: (Int, Int) -> Void) {}
foo { (bar: (Int, Int)) in } // used a single tuple type `(Int, Int)`
                             // instead of two distinct arguments

Fix missing argument diagnostic to support closures with captures
NFC: Remove "trailing" from method name for closures with missing args

@swift-ci please smoke test


[Coverage Maps] Add 'last updated' dates, if possible

Implemented for O2 and Three via self-hosted tile server.

Now implemented for all networks through self-hosted tiles


can you add some another funcs

popfunc
peekfunc

thank you in advance

Hi @Nyx2022 , could you please write use case where you need such methods?

maybe you need a different data structure? because the priority queue's main responsibility is to push/peek/pop based on priority func


Compilation fails with clang due to intrinsics

Compiler errors with Debian clang version 3.5.2-1 with target: x86_64-pc-linux-gnu

$>CC=clang make
...
In file included from enc/encode_block.c:41:
In file included from enc/write_bits.h:42:
In file included from common/common_block.h:31:
In file included from common/simd.h:132:
In file included from common/simd/v128_intrinsics_x86.h:32:
common/simd/v64_intrinsics_x86.h:110:12: error: argument to '__builtin_ia32_psrldqi128' must be a constant integer
; (__m128i)__builtin_ia32_psrldqi128(__a, (c)*8); }) : b;
           ^                              ~~~~~
common/simd/v64_intrinsics_x86.h:110:12: error: can't convert between vector and non-scalar values ('void' and 'v64' (aka '__m128i'))
  return c ? __extension__ ({
           ^ ~~~~~~~~~~~~~~~~
common/simd/v64_intrinsics_x86.h:504:12: error: argument to '__builtin_ia32_pslldqi128' must be a constant integer
; (__m128i)__builtin_ia32_pslldqi128(__a, (c)*8); });
           ^                              ~~~~~
common/simd/v64_intrinsics_x86.h:504:10: error: returning 'void' from a function with incompatible result type 'v64' (aka '__m128i')
  return __extension__ ({
         ^~~~~~~~~~~~~~~~
common/simd/v64_intrinsics_x86.h:508:12: error: argument to '__builtin_ia32_psrldqi128' must be a constant integer
; (__m128i)__builtin_ia32_psrldqi128(__a, (c + 8)*8); });
           ^                              ~~~~~~~~~
common/simd/v64_intrinsics_x86.h:508:10: error: returning 'void' from a function with incompatible result type 'v64' (aka '__m128i')
  return __extension__ ({
         ^~~~~~~~~~~~~~~~
In file included from enc/encode_block.c:41:
In file included from enc/write_bits.h:42:
In file included from common/common_block.h:31:
In file included from common/simd.h:132:
common/simd/v128_intrinsics_x86.h:89:12: error: argument to '__builtin_ia32_psrldqi128' must be a constant integer
; (__m128i)__builtin_ia32_psrldqi128(__a, (c)*8); }), __extension__ ({
           ^                              ~~~~~
common/simd/v128_intrinsics_x86.h:89:12: error: argument to '__builtin_ia32_pslldqi128' must be a constant integer
; (__m128i)__builtin_ia32_pslldqi128(__a, (16 - c)*8); })) : b;
           ^                              ~~~~~~~~~~
common/simd/v128_intrinsics_x86.h:89:27: error: passing 'void' to parameter of incompatible type '__m128i' (vector of 2 'long long' values)
  return c ? _mm_or_si128(__extension__ ({
                          ^~~~~~~~~~~~~~~~
/usr/include/clang/3.5.2/include/emmintrin.h:817:22: note: passing argument to parameter '__a' here
_mm_or_si128(__m128i __a, __m128i __b)
                     ^
In file included from enc/encode_block.c:41:
In file included from enc/write_bits.h:42:
In file included from common/common_block.h:31:
In file included from common/simd.h:132:
common/simd/v128_intrinsics_x86.h:528:12: error: argument to '__builtin_ia32_pslldqi128' must be a constant integer
; (__m128i)__builtin_ia32_pslldqi128(__a, (c)*8); });
           ^                              ~~~~~
common/simd/v128_intrinsics_x86.h:528:10: error: returning 'void' from a function with incompatible result type 'v128' (aka '__m128i')
  return __extension__ ({
         ^~~~~~~~~~~~~~~~
common/simd/v128_intrinsics_x86.h:532:12: error: argument to '__builtin_ia32_psrldqi128' must be a constant integer
; (__m128i)__builtin_ia32_psrldqi128(__a, (c)*8); });
           ^                              ~~~~~
common/simd/v128_intrinsics_x86.h:532:10: error: returning 'void' from a function with incompatible result type 'v128' (aka '__m128i')
  return __extension__ ({
         ^~~~~~~~~~~~~~~~
1 warning and 13 errors generated.
Makefile:69: recipe for target 'enc/encode_block.o' failed
make: *** [enc/encode_block.o] Error 1

I am experiencing the same issue on OS X

+1 mac 10.11

WFM now.


web demo error

@ldenoue Have you resolved this? It only works in Linux btw.

No because I’m on Mac.
But it being browser based, why does it only run on Linux?
What can I modify to make it run elsewhere?

It highly depends on the browser (specifically, the WebGL implementation of that browser) so I don't have any other advice than debugging the errors one by one.
In my case, I tested it on Chrome, Ubuntu 16.04.


[SEMANTIC-65] [Bug] Environment variables in tests doesn't match test.env.example file

Is this a new bug in dbt_metrics?

[X] I believe this is a new bug in dbt_metrics
[X] I have searched the existing issues, and I could not find an existing issue for this bug

Current Behavior
Currently, the environment variables required to run the tests locally are not named correctly in the test.env.example file. Additionally, a required dbt_target field is not provided in the example file.
Expected Behavior
The naming should be:
POSTGRES_TEST_PASS -> POSTGRES_TEST_PASSWORD
POSTGRES_TEST_DBNAME -> POSTGRES_TEST_DB

Additionally, a new dbt_target field should be added.
Steps To Reproduce

Clone the repo locally
Delete the test.env file locally, if it exists
Rename the test.env.example file to test.env
Try run the test suite.

 Seems like it should just require an update to:

test.env.example file

PR is open at #179


Fixed return of some linux commands that return the command string as…

When run on an Oracle Linux remote host, the output of the Quality Check currently returns:
ConvertFrom-Json: ./SAP-on-Azure-Scripts-and-Utilities/QualityCheck/QualityCheck.ps1:872
Line |
 872 |      $script:_vmmetadata = $_result | ConvertFrom-Json
     |                                       ~~~~~~~~~~~~~~~~
     | Conversion from JSON failed with error: Unexpected character encountered while parsing value: <. Path '', line 0, position 0.
ConvertFrom-Json: ./SAP-on-Azure-Scripts-and-Utilities/QualityCheck/QualityCheck.ps1:1334
Line |
1334 |  … $script:_azurediskconfig = RunCommand -p $_command | ConvertFrom-Json
     |                                                         ~~~~~~~~~~~~~~~~
     | Conversion from JSON failed with error: Unexpected character encountered while parsing value: <. Path '', line 0, position 0.

This is due to the return value being an array with the first object being a substring of the command that was sent to the remote host.
This PR is my attempt at fixing it.

hi Marcus,
if you can share the HTML output with me on<EMAIL_ADDRESS>I can check the output.
my assumption at the moment is that the output is too long, you can also try to remove these lines from the json file:
    {
        "CheckID": "IC-9006",
        "Description": "installed packages",
        "OS": ["SUSE","RedHat","OracleLinux"],
        "OSVersion": ["all"],
        "HardwareType": ["VM", "HLI"],
        "DB": ["HANA", "MSSQL", "Oracle", "Db2", "ASE"],
        "Role": ["DB","ASCS","APP"],
        "RunInLocalMode": true,
        "CommandType": "OS",
        "ProcessingCommand": "rpm -qa",
        "PostProcessingCommand": "",
        "RootRequired": true,
        "ShowInReport": true,
        "HighAvailability": [false,true],
        "HighAvailabilityAgent": ["SBD","FencingAgent"]
    },

the issue I saw was not related to a string being not formated correct, it was an overflow of a string that then came back in the next command.
thanks

Howdy @msftphleiten ,
I've sent the report to you via email as requested.
Thanks for your help!

closing as it is now added in the code already, thanks for providing the great feedback!


Shell scripts should use nullglob

While investigating another issue, I noticed that brew update --force was executing this:
++ for DIR in '"$HOMEBREW_REPOSITORY"' '"$HOMEBREW_LIBRARY"/Taps/*/*'
++ [[ -d /usr/local/Homebrew/Library/Taps/*/*/.git ]]

Since I don't have any taps, the glob is turning into a path containing literal asterisks, which is probably not intentional.
This and other shell scripts in Homebrew should probably turn on nullglob at the top: shopt -s nullglob

Since I don't have any taps

This itself is unsupported but I can see an argument for setting it for this particular script. Could you try and open a pull request? This document should help and we're happy to walk you through anything else.
Thanks!


use the correct column name to get schema names

https://github.com/crate/pgjdbc/pull/22

@chaudum pls review


Add A Batch

You don't need anything accept windows. Pro's it's better bash. Con's it requires windows.

The system is built on Linux, not windows, so this can't happen.


Improve documentation of credentials classes and functions.

An API reviewer reported being confused by the credentials classes and functions. To be fair, it is confusing in an API to have a class that is public and concrete but not instantiable. We can't change the shape of the API elements without changes in the core that I suspect aren't going to happen, but it's good to know that we should embellish the documentation.

Now that I take a good serious look at it (and again review the API feedback), I don't think there's any action to be taken here. Most of what was confusing about the security elements in the Beta API has been addressed in the GA API, and what remains is forced on us by the shape of the Core API.


validation: add global chainId check

Closes https://github.com/ethereum-optimism/security-pod/issues/100
Test currently failing due to name mismatches.
It is likely and acceptable for a chain to already exist at chainId.network, so we need a way of checking whether it is the "same chain" or not. Using the name seems reasonable, since that it is required to be unique also .
=== RUN   TestGloballyUniqueChainId
    /Users/georgeknee/code/ethereum-optimism/superchain-registry/validation/chainId_test.go:22: Chain OP-Mainnet with ID 10 exists in global chain list with name OP Mainnet
    /Users/georgeknee/code/ethereum-optimism/superchain-registry/validation/chainId_test.go:22: Chain Zora Sepolia with ID 999999999 exists in global chain list with name Zora Sepolia Testnet
    /Users/georgeknee/code/ethereum-optimism/superchain-registry/validation/chainId_test.go:22: Chain Lyra with ID 957 exists in global chain list with name Lyra Chain
    /Users/georgeknee/code/ethereum-optimism/superchain-registry/validation/chainId_test.go:22: Chain Orderly Network with ID 291 exists in global chain list with name Orderly Mainnet
    /Users/georgeknee/code/ethereum-optimism/superchain-registry/validation/chainId_test.go:22: Chain PGN with ID 424 exists in global chain list with name PGN (Public Goods Network)
    /Users/georgeknee/code/ethereum-optimism/superchain-registry/validation/chainId_test.go:22: Chain Base Sepolia with ID 84532 exists in global chain list with name Base Sepolia Testnet
    /Users/georgeknee/code/ethereum-optimism/superchain-registry/validation/chainId_test.go:22: Chain OP-Sepolia with ID 11155420 exists in global chain list with name OP Sepolia Testnet
    /Users/georgeknee/code/ethereum-optimism/superchain-registry/validation/chainId_test.go:22: Chain PGN Sepolia with ID 58008 exists in global chain list with name Sepolia PGN (Public Goods Network)

Open to suggestions on how to resolve this. i think it seems reasonable to require the same name in both repos?

My preferred solution would be:

If the chain is not in the upstream repo: we do the chain ID + name + short name uniqueness checks ourselves
If the chain is in the upstream repo: make sure everything added here matches

What do you think of that?

@mds1 I updated the logic to match your suggestion.
I also went through the existing chains to add a short name and correct the existing names where discrepancies exist.
Further, the contributing guide has been updated.
Note that this will conflict with in flight PRs.

Checking OptimismPortalProxy 0x16Fc5058F25648194471939df75CF27A2fdC48BC
    -- Success: 0x189aBAAaa82DfC015A588A7dbaD6F13b1D3485Bc == 0x16Fc5058F25648194471939df75CF27A2fdC48BC.admin().
    -- Success: 0xDEe57160aAfCF04c34C887B5962D0a69676d3C8B == 0x16Fc5058F25648194471939df75CF27A2fdC48BC.GUARDIAN().
    !! Error calling 0x16Fc5058F25648194471939df75CF27A2fdC48BC.L2_ORACLE()
    !! Error: 0x90E9c4f8a994a250F6aEfd61CAFb4F2e895D458F != 0x16Fc5058F25648194471939df75CF27A2fdC48BC.L2_ORACLE(),
             which is 0x0000000000000000000000000000000000000000

├─ [648] 0x16Fc5058F25648194471939df75CF27A2fdC48BC::L2_ORACLE() [staticcall]
    │   ├─ [192] 0x215b3A2d1766616d1C4701f3D117348711BaAe93::L2_ORACLE() [delegatecall]
    │   │   └─ ← EvmError: Revert

So it's reverting because L2_ORACLE method does not exist on the target contract. And the 0x215b3A2d1766616d1C4701f3D117348711BaAe93 contract is the FPAC OptimismPortal2 where the L2OO has been removed. So I think we need to use chainUpgradedToFPAC for basesep now. (I did not realize Base Sepolia upgraded to FPAC but seems they have)

Thanks, need to get better at parsing those traces :-) Is there anything we can do to make that easier

(I did not realize Base Sepolia upgraded to FPAC but seems they have)

I did run this check on main and it passes, so there must be something linked to my renaming changes on this branch  which are causing the test to fail.
I think we actually just need to update chainUpgradedToFPAC for opsep (not basesep).

I think we actually just need to update chainUpgradedToFPAC for opsep (not basesep).

Ah yes, foundry runs tests in parallel so the console.logs get a little confusing. But given the address you are correct

In favour of #320


adding proper header and footer and tictactoe game is not showing result on game draw

proper header can be made for proper viewing
also the tictactoe game is not showing black screen on draw
pls assign this issue under gssoc'23 tag

I know how to fix this , So would like to work on this project. Please assign it to me under GSSOC'23