DDOSLogger Info, Warning, Debug, and Verbose logs do not appear in Console.app when streaming from iOS simulator.

Checklist

[x] I have read and understood the CONTRIBUTING guide
[x] I have read the Documentation
[x] I have searched for a similar issue in the project and found none

Description
DDOSLogger Info, Warning, Debug, and Verbose logs do not appear in Console.app when streaming from iOS simulator.
Steps To Reproduce

Implement a log message (via Swift or Objective-C, it doesn't matter) using DDOSLogger via any method that uses a DDLogFlag value of .info, .debug, .warning, or .verbose.
Run that statement on an iOS or iPadOS simulator while streaming logs to Console.app on the same Mac.
These log messages do not appear even when Info and Debug logs are enabled in Console.app.

Expected behavior
Every log message sent to CocoaLumberjack should appear in Console.app when Info and Debug logs are enabled in Console.app, even when streaming from the iOS simulator.
Environment info

Info
Value

Platform Name
any Simulator device

Platform Version
at least as far back as iOS 16-17, probably before that, too

CocoaLumberjack Version
latest

Integration Method
spm

Xcode Version
e.g. Xcode 15+

Repro rate
all the time

Repro project link
n/a

Additional Context
Ultimately this is an Apple bug. The bug dates back years and years. However CocoaLumberjack should be aware of a longstanding bug like that and provide an automatic workaround that doesn't require end users to discover this shortcoming the hard way.
Specifically, this switch statement in DDOSLogger needs to be rethought:
switch (logMessage->_flag) {
    case DDLogFlagError  :
        os_log_error(logger, "%{public}s", msg);
        break;
    case DDLogFlagWarning:
    case DDLogFlagInfo   :
        os_log_info(logger, "%{public}s", msg);
        break;
    case DDLogFlagDebug  :
    case DDLogFlagVerbose:
    default              :
        os_log_debug(logger, "%{public}s", msg);
        break;
}

Recommendations
The following changes should be made:

All Devices: Warning logs should never be downgraded to os_log_info(...), they should be sent at the default: os_log(...). This is true both for simulator and non-simulator target devices. OSLogType.info has special characteristics that make it unsuitable for use with warning-level logs (the characteristics of info logs are best described in the WWDC presentation the first year that Unified Logging was introduced).

Simulators: When running against a simulator, Info, Debug, and Verbose logs should be upgraded as if they had been logged at Warning, so that they can actually appear in the Console.app when streamed from the simulator. This workaround can be removed if Apple ever addresses it, but since the bug has existed for at least five years, there's seemingly little chance of that ever happening.

Alternatives Considered
Given the current implementation of DDOSLogger, the only workaround for existing consumers is to roll their own upgrade, lifting all affected log statements streaming from a Simulator up to an Error log level. This is not an acceptable workaround, however, since Error logs also have a special treatment in log systems (not just in Console.app/Unified Logging). This workaround also puts a big burden on consumers because they would have to edit every call site that logs via DDLogInfo(...) etc. It would be far less invasive to surgically edit the implementation of DDOSLogger to implement a targeted workaround that only affects simulator builds, leaving all call sites intact.

First of all thanks for taking the time to describe everything in detail, including recommendations!
Downgrade of Warning to Info
You're right that this is incorrect! They should be upgraded to error, which is what the .warning function on Logger in OSLog does as well:

Missing messages in Console.app
I'm a bit torn here...
Reading a bit further in the forum you linked, I found this answer by Quinn.
Using CocoaLumberjack version 3.8.4, I was able to reproduce his findings:
Everything logged with .info or above is visible in Console.app:

This lines up with .debug messages not being shown, which was also classified as bug by Quinn in the forums.
Also matching Quinn's findings, I'm able to see these messages when using the Terminal:

Last but not least, I see all messages in Xcode's Console as well (Xcode 15.2):

Long story short, I don't think it's that simple to add a workaround in CocoaLumberjack.
In its current form, the bug seems to only affect the Console.app, not the logging SDK itself.
Personally, I've never used the Console.app to read Simulator logs, though I can see that it might be helpful to see other logs (not only the application's logs).
Given that all log messages show up correctly in Xcode, we shouldn't generally raise .debug logs to a higher level.
I could imagine adding a "level mapper" of sorts to DDOSLogger, though. This could be used to map our log levels to the ones of OSLog. We'd then provide two default implementations:

One that basically does what the current implantation does.
One that's only available when building for Simulator, that raises .debug to either .default or .info.
Users of CocoaLumberjack would then still need to add a little more code, but not implement the whole workaround themselves.

What do you think?

You're right that this is incorrect! [Warning logs] should be upgraded to error

I left something out from my description. I've noticed that off-the-shelf there is not DDLogMessage() or DDLog() etc method that logs at a neutral level equivalent with os_log(...) (the default OSLogType). If Warning logs get upgraded to Error, then there's still no way to produce a log that is higher than a debug/info but not an error.

I could imagine adding a "level mapper" of sorts to DDOSLogger, though

I think this idea is interesting. I've worked on projects where logging requirements change as different platform teams become subject to belated cross-platform logging standards. These standards can force teams to raise or lower log levels across the board, which can potentially wreak havoc on a codebase as thousands of log statements have to be audited to raise or lower the level to the new standard. It would be far easier to define a level mapping in one place, and leave call sites and team-specific logging practices untouched.

I've noticed that off-the-shelf there is not a neutral DDLogMessage() or DDLog() or DDLogDefault() etc method that logs at a neutral level equivalent with os_log(...) (OSLogType .default).

That's due to CocoaLumberjack not having a 'neutral' log level. To be honest, I haven't really understood the concept of a 'neutral' log level - and have often seen it being overused if there was one.
FWIW, I've changed the default in the switch to use the OS_LOG_TYPE_DEFAULT in #1410.

I think this idea is interesting.

Feel free to have a look at #1410 and see if the solution I've implemented there would fit your needs.


werfault  why?

How do you open the werfault.exe for inject and why U choose that

Hi @xiaotsai,
we chose to inject to the werfault.exe process because windows expects it to open tcp connections (for error reporting).
as for how do we open it,
we call RtlCreateProcessParameters and RtlCreateUserProcess as can be viewed in main.cpp:
https://github.com/Konis-Bros/Espio/blob/main/loader/Espio/main.cpp

OK thank you


Default value for a question is not displayed when editing a question from a template

It is currently hidden (display:none;) from the edit question. Additionally, changing question format on the edit question form does nothing. Related to #337

All looks good. Closing out.


Modify listener interface in meta client

Modify listener interface in meta client, needed by https://github.com/vesoft-inc/nebula-storage/pull/180.

Hold on, there could be more changes as for PartManager

Ready

Ready, verified.

LGTM.


Add 'appendExtension' option

This option allows the .webp extension to be appended to the path instead of replacing the original extension.
Example:
gulp.src('./img/foo.{png,jpg}')
  .pipe(webp({appendExtension: true}))
  .pipe(gulp.dest('.'));

Creates two images: foo.png.webp and foo.jpg.webp.

No thanks, just use gulp-rename.

Usually I agree with stuff like this, but in this case it just seems so much more trouble... Renaming after webp() won't work:
gulp.src('./img/foo.{png,jpg}')
  .pipe(webp())
  .pipe(rename(function (path) {
    console.log(path.extname); // => '.webp';
    // Great... what was the original extension again?
  });

While renaming it before doesn't feel right...
gulp.src('./img/foo.{png,jpg}')
  .pipe(rename(function (path) {
    // Add the .webp extension so it can be replaced with the
    // .webp extension... It feels so hacky having to do this.
    path.extname += '.webp';
    // Now I'll have a PNG/JPG stream with a WEBP extension.
  })
  .pipe(webp())
  .pipe(gulp.dest('.'));

While, IMHO, when the plugin does that for you, everything just seems to be in the right place. No room for confusion. No time lost. And I don't see it going against the "do one thing and do it well" filosofy, quite the opposite.
If you stick to the rename() solution, I believe it would be a good idea to at least add such an example to the docs.
Anyway, thanks for the plugin.


Document baseModels and childrenModelCount as expand parameters

Following server-side addition.

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.


Promotion disappears after saving empty form

Steps to reproduce:

Add new promotion
Save without entering anything
Reload page

Expected result

Display the initial promotion form

Actual result

Empty promotion
!Screenshot from 2023-10-19 10-42-19-20231019-084219.png|width=3714,height=1986!

[public] Automated response: This issue is linked to the internal issue https://shopware.atlassian.net/browse/NEXT-31168.
[created from NEXT-31168, comment 485535]

[public] Hello,
Within our company roadmap and work capacity, we try to address each bug or improvement request but admit that not each one will be resolved. To continue our culture of honesty and openness, we are closing this issue to focus on our roadmap on behalf of all Shopware users.
If you feel like this issue is still impacting you, please create a new issue and let us know. Thank you again for your valuable feedback.
[created from NEXT-31168, comment 492302]


fix(source-map-support): always install it in lambda externals

Current dependencies on/for this PR:

main

PR #6   👈

This comment was auto-generated by Graphite.


Impro 1754 showers cli

Adds convection-ratio CLI and ConvectionRatioFromComponents plugin to derive the convection ratio from the convective and dynamic precipitationi rate components.
Testing:

[x] Ran tests and they passed OK
[x] Added new tests for the new feature(s)

 Here is an overview of what got changed by this pull request:

Issues
======
- Added 2

Complexity increasing per file
==============================
- improver/cli/convection_ratio.py  2
- improver_tests/acceptance/test_convection_ratio.py  3
- improver_tests/convection/test_ConvectionRatioFromComponents.py  5

Clones added
============
- improver_tests/convection/test_ConvectionRatioFromComponents.py  1

See the complete overview on Codacy

 Here is an overview of what got changed by this pull request:

Complexity increasing per file
==============================
- improver_tests/acceptance/test_convection_ratio.py  3
- improver_tests/convection/test_ConvectionRatioFromComponents.py  5
- improver/cli/convection_ratio.py  2

Clones added
============
- improver_tests/convection/test_ConvectionRatioFromComponents.py  1

See the complete overview on Codacy

 Here is an overview of what got changed by this pull request:

Complexity increasing per file
==============================
- improver_tests/acceptance/test_convection_ratio.py  3
- improver/cli/convection_ratio.py  2
- improver_tests/convection/test_ConvectionRatioFromComponents.py  5

Clones added
============
- improver_tests/convection/test_ConvectionRatioFromComponents.py  1

See the complete overview on Codacy

 Here is an overview of what got changed by this pull request:

Complexity increasing per file
==============================
- improver_tests/acceptance/test_convection_ratio.py  3
- improver_tests/convection/test_ConvectionRatioFromComponents.py  5
- improver/cli/convection_ratio.py  2

Clones added
============
- improver_tests/convection/test_ConvectionRatioFromComponents.py  1

See the complete overview on Codacy

 Here is an overview of what got changed by this pull request:

Issues
======
- Added 1

Complexity increasing per file
==============================
- improver_tests/convection/test_ConvectionRatioFromComponents.py  5
- improver_tests/acceptance/test_convection_ratio.py  3
- improver/cli/convection_ratio.py  2

Clones added
============
- improver_tests/convection/test_ConvectionRatioFromComponents.py  1

See the complete overview on Codacy

 Here is an overview of what got changed by this pull request:

Complexity increasing per file
==============================
- improver_tests/acceptance/test_convection_ratio.py  3
- improver/cli/convection_ratio.py  2
- improver_tests/convection/test_ConvectionRatioFromComponents.py  5

Clones added
============
- improver_tests/convection/test_ConvectionRatioFromComponents.py  1

See the complete overview on Codacy

 Here is an overview of what got changed by this pull request:

Complexity increasing per file
==============================
- improver/cli/convection_ratio.py  2
- improver_tests/acceptance/test_convection_ratio.py  3
- improver_tests/convection/test_ConvectionRatioFromComponents.py  5

Clones added
============
- improver_tests/convection/test_ConvectionRatioFromComponents.py  1

See the complete overview on Codacy

 Here is an overview of what got changed by this pull request:

Complexity increasing per file
==============================
- improver/cli/convection_ratio.py  2
- improver_tests/acceptance/test_convection_ratio.py  3
- improver_tests/convection/test_ConvectionRatioFromComponents.py  5

Clones added
============
- improver_tests/convection/test_ConvectionRatioFromComponents.py  1

See the complete overview on Codacy

 Here is an overview of what got changed by this pull request:

Issues
======
- Added 1

Complexity increasing per file
==============================
- improver_tests/acceptance/test_convection_ratio.py  3
- improver/cli/convection_ratio.py  2
- improver_tests/convection/test_ConvectionRatioFromComponents.py  5

See the complete overview on Codacy

 Here is an overview of what got changed by this pull request:

Complexity increasing per file
==============================
- improver_tests/acceptance/test_convection_ratio.py  3
- improver_tests/convection/test_ConvectionRatioFromComponents.py  5
- improver/cli/convection_ratio.py  2

See the complete overview on Codacy


Recommend Atom instead of textmate

As suggested by @ismaelga

Why not just add Atom as another option? Textmate still works...

Textmate has been kind of deprecated by sublime. I haven't heard of anyone still using it, especially someone coming to the scene after Sublime.

Roger!


DevOps Projects has been renamed to DevOps Starter.

[Enter feedback here]
It would appear that the DevOps Projects has been renamed to DevOps Starter.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 5098fbad-7df5-7c62-9d56-6e9646b86d0c
Version Independent ID: 14e2f627-2215-4373-1071-7698bcc9354d
Content: CI/CD pipeline with Azure DevOps Projects - Azure IoT Edge
Content Source: articles/iot-edge/how-to-devops-project.md
Service: iot-edge
GitHub Login: @shizn
Microsoft Alias: xshi

Hello @ksaye
Thanks for the feedback! I agree we need to update the document. We will give an update on this soon.

@ksaye
I have assigned the issue to the content author for further review and update the doc as appropriate.

@v-tcassi is working on this update. Tom, please resolve this issue when the changes are published.
#reassign:v-tcassi

@SatishBoddu-MSFT Hi! The changes addressing this issue have officially published. You can check them out here. Thanks @ksaye for bringing this to our attention!

We will now proceed to close this thread. If there are further questions regarding this matter, please tag me in your reply. We will gladly continue the discussion and we will reopen the issue.
Please also do visit Microsoft Q&A the home for technical questions and answers at Microsoft.


docker, runtime: Update iproute2 and bpftool images

Signed-off-by: Kornilios Kourtis<EMAIL_ADDRESS>https://github.com/cilium/image-tools/pull/162
https://github.com/cilium/image-tools/pull/161
https://github.com/cilium/image-tools/pull/163
Fixes: #18281

/test

test-1.22-4.19

test-1.16-4.9

Failed with Kubernetes DNS did not become ready in time: https://jenkins.cilium.io/job/Cilium-PR-K8s-1.22-kernel-4.19/223/consoleFull Seems unrelated, but we need to double check. We'll need to create an issue for it if it doesn't happen again.
test-1.22-4.19

Now it failed with:

20:17:25  FAIL: terminating containers are not deleted after timeout
20:17:25  Expected
20:17:25      <*errors.errorString | 0xc001059de0>: {
20:17:25          s: "Pods are still not deleted after a timeout: 4m0s timeout expired",
20:17:25      }

/mlh new-flake Cilium-PR-K8s-1.16-kernel-4.9

/mlh new-flake Cilium-PR-K8s-1.16-kernel-4.9

k8s-1.16-kernel-4.9 failed with Monitor log did not contain 2 ingress and 3 egress TCP notifications after a timeout: https://jenkins.cilium.io/job/Cilium-PR-K8s-1.16-kernel-4.9/530/testReport/junit/Suite-k8s-1/16/K8sDatapathConfig_MonitorAggregation_Checks_that_monitor_aggregation_restricts_notifications/ I can't find a single previous occurence of this in issues or in DataStudio, so could be related even if it doesn't seem.
If it doesn't happen again, we'll need a create an issue for this as well :-(
test-1.16-4.9

made: https://github.com/cilium/cilium/issues/18437 (sorry, made it before I saw your /mlh command).

Now it failed with:
20:17:25 FAIL: terminating containers are not deleted after timeout

Yep, I saw that error, but the first test failure is still Kubernetes DNS did not become ready in time (K8sDatapathConfig AutoDirectNodeRoutes Check connectivity with sockops and direct routing). At this point, I'd say it's worth digging.

Now it failed with:
20:17:25 FAIL: terminating containers are not deleted after timeout

Yep, I saw that error, but the first test failure is still Kubernetes DNS did not become ready in time (K8sDatapathConfig AutoDirectNodeRoutes Check connectivity with sockops and direct routing). At this point, I'd say it's worth digging.

Ah sorry, somehow missed that. Thanks!

This also looks very suspect:

[2022-01-10T17:07:44.616Z] FAIL: Cilium cannot be installed
[2022-01-10T17:07:44.616Z] Expected
[2022-01-10T17:07:44.616Z]     <*errors.errorString | 0xc000608730>: {
[2022-01-10T17:07:44.617Z]         s: "Failed to retrieve ip a output: Failed to exec "ip -j a s" cmd on "k8s1" node:  (exit status 1) output: cmd: kubectl exec -n kube-system log-gatherer-gkhmh -- ip -j a s\nExitcode: 1 \nErr: exit status 1\nStdout:\n \t \nStderr:\n \t Error from server: unexpected EOF\n\t \n",
[2022-01-10T17:07:44.617Z]     }
[2022-01-10T17:07:44.617Z] to be nil

Closing this and starting fresh.


Error: Schema must contain uniquely named types but contains multiple types named "User".

Hi,
I've updated to v0.1.17 and i've this error : Error: Schema must contain uniquely named types but contains multiple types named "User".
I'm using json-schema and the error occurs when i generate the sdk because i have 2 operations using the same responseSchema.
In v0.1.16 it was working.

Working on a fix https://github.com/Urigo/graphql-mesh/pull/470
So could you try the canary version of that PR?

Thanks @ardatan ! I've tested with 0.1.18-alpha-fcee3d65.0 and it doesn't seem to work. I've always the same error while generating the SDK. e.g Schema must contain uniquely named types but contains multiple types named "User".
I'm using that command to genereate the sdk: yarn graphql-mesh generate-sdk --operations ./src/data/**/*.graphql --output ./src/generated/sdk.ts

Could you create a reproduction as a repo or a sandbox using CodeSandbox?

Sure a reproduction here: https://github.com/Achilles4400/graphql-mesh-json-schema
ResponseSchema seems to work but impossible to use the same RequestSchema in 2 operations.

i've updated the reproduction to 0.1.18-alpha-7279acf5.0 and the problem persists.

I saw you're using "^ prefix. Could you use exact version without ^ prefix on versions? Thanks!

Yes sorry, i removed "^ prefix but it changes nothing... 0.1.18-alpha-7279acf5.0 is the good version?

https://codesandbox.io/s/pedantic-sammet-i4uje
This includes a working example based on reproduction. I added Query field which is necessary to build a valid GraphQL Schema, and also updated the example query because it didn't match with the schema.

Thanks 0.1.18-alpha-2ac9d01a.0is working in my repo too: https://github.com/Achilles4400/graphql-mesh-json-schema

Available in v0.1.18!


feat: implement 'max_bold_weight_infelicity' config option to allow bold fonts with the weight different from FC_WEIGHT (200)

…
fixes #51

@neeasade @laserswald
i would like to have at least one review before merging

LGTM 🏄

thanks!


stream send behavior after stream send is shutdown

The current code pretends Ok when pushing more data to a stream send after it is shutdown:
https://github.com/cloudflare/quiche/blob/fd5e028e1ec29c964d79ce8fb5bf623669cebfc8/src/stream.rs#L925
I bumped into a case, where it seems causing a problem that consumes the send capacity and impacts other streams.  I was wondering what was the rationale of not returning error? And is this a known issue, or maybe I missed something?

Thanks, this seems a legitimate concern to me. Wonder what others think.

I wrote a small test case to illustrate this issue. Here is the gist. (It's based on 0.6.0 or master head @b335378.).
The test shows two things:

After the server has shutdown stream 4 write, the call stream_send() still returns Ok with non-zero size until Ok(0) after a few calls. Ideally stream_send() should return Err.

stream_send() on another stream 8 failed afterwards, which means the above stream 4 writes were not no-ops.  If comment out the stream 4 writes,  then stream 8 write will succeed.


Do not call setSecret on any unmasked secrets

Right now, every value that's pulled from Doppler is marked as a secret in GitHub Actions, which means any workflow using this action ends up with a ton of unnecessary redactions.
For example, if you have the following Doppler values:
NODE_ENV = test
WORKER_COUNT = 3

Then every output that includes test and the number 3 gets redacted, making the output rather difficult to read. Now I'm unable to tell the real difference between Listing and Downloading secrets, but from what I can tell from the api
docs only List Secrets includes the visibility information, so I had to change how secrets are pulled.
Fixes #16

I have not directly tested this logic yet, wanted to see what the GitHub action would say. I will look at trying to test this logic internally as well.

Did some internal testing and got this to a state where it works!

Anything I need to do about the test failures?

Ping @watsonian


pagination default activity background color is not work.

i copy the code from https://flowbite-react.com/pagination and ui show the pagination is miss default activity style.

@Isaac-chip which version are you using? We do have a template for reporting bugs, next time, please, use it.

@rluders  ok.


feat: update eslint config in React templates

Closes #10772
I wanted to improve a bit the ling rules for the TS template, adding more type aware rules. The strict set is too strict for a starter, but I added manually my preferred one: @typescript-eslint/no-unnecessary-condition (catches so much dead branch when refactoring). Also added one to remove this as I wanted to remove since way to long (see #10772)
Also discovered that no-non-null-assertion is enabled by default, which is bad IMO. I don't agree with the opinion of the TS-ESLint team. TS will never be a sound type system (can't find the issue/discussion from the core team that says it's out of scope). This tool is a sharp knife, but a useful one, we use ourself quite a lot in the Vite codebase. And the diff in the TS template clearly shows that this is a better assertion than a as.

@nickmccurdy would you help us with a review here?

Let's move forward to get more feedback from users. We can keep the discusion open.

Sounds good! 👍 I'll still check these notifications.

I just scaffolded a project and was a bit confused, by only two rules being overwritten, one of them turning of @typescript-eslint/no-unnecessary-condition. I understand that one might find this rule too strict, but that seems like a very personal preference to me. First thing I did was remove the line (to turn on the rule).
My opinion would be that a starter template should rely on the tools its using (i.e. plugin:@typescript-eslint) and shouldn't add unnecessary noice on top. To a new user, having this one rule explicitly turned of would look very important and they might assume it is necessary for a React/TS/Vite template, when in fact it has nothing to do with a template, and is just a personal preference.

We are in the process of upgrading our quickstart to the latest version of Vite and found that the addition of 'plugin:@typescript-eslint/recommended-requiring-type-checking' has two issues:

It requires a much stricter adherence to types than before. This can be cumbersome for prototyping phases with more liberal use of any and for using less-than-ideally typed libraries.
More importantly, ESLint doesn't pick up changes to other files, and seems to be very eagerly caching lint results (at least in VS Code). This means that while TypeScript has already picked up new types, ESLint is still showing a Lint warning, which can be quite frustrating.

 While I agree we should not change too much thing from the default, this one is harmful as it was suggesting people that as HTMLElement is better than ! which is not the case. This rule will be moved to strict in the next version of TS-ESLint: https://github.com/typescript-eslint/typescript-eslint/discussions/6014

@xixixao Thanks for the feedback, that's true that the cache issues with types in ESLint can be annoying.
I wanted to promote a bit this kind of more advanced rules, but the usage of Vite templates is more wide than the start of a new app. I will revisit this to see how we can keep an eslint config for hooks without giving the impression that this is the right config for a team building a production application (I've seen to many teams sticking with the default rules of CRA that are lacking support for TS)

@ArnaudBarre I am not arguing for cast as HTMLElement (I think it's just as harmful as !). My personal opinion is to use neither us as nor ! and rather have an additional type check, even though it might never be needed (but avoid normalizing casting in the code base). But I also didn't want to argue about my personal preference on this rule but rather point out that it is still a personal preference (if this matter would really be this clear cut, the discussion could be opened with @typescript-eslint and would be resolved there). And in this case, I was arguing for keeping things simple by just leaving them as they come from upstream (i.e., don't overwrite the rule).
TLDR; I was confused by this single rule being overwritten. Had to spend time figuring out why this (from my perspective) reasonable rule was turned off (and assumed it was because of some problem with React). Went ahead and turned it back on.

@xixixao I see your point, but I was happy all the setup for ESLint with types was already done. Turning the rules off seems a lot simpler, in this case, than turning them on. It would be a pity to have it removed.

@essenmitsosse good news v6 was just so I will update the template and remove this line while keeping the !
In that exact case as an example, adding a custom check will not make the error more easy to debug (error that is instantly detectable if it happens).
Yeah this is not trivial to setup, but the question is should it be the role of the default template to do so. I will discuss this with the team


[question] [feature request] DDPG VecEnv support

I'm currently working to speed up a project using the stable-baselines DDPG algorithm. My environment can be easily converted into VecEnv. But I figured out that your DDPG doesn't support the VecEnv.
I'm wondering why you didn't implement it? Lack of time, hard to deal with?
Thank you in advance.

Hello,
Duplicate of https://github.com/hill-a/stable-baselines/issues/170 (related to #495 )
In short, SAC/TD3/DDPG were designed for using them on real robot, so where multiprocessing is not possible. I would recommend using PPO/A2C for fast training using massive multiprocessing (where sample efficiency is not a problem but wall clock time is)
In theory, SAC/TD3/DDPG could be extended to multiprocessing (this will maybe easier to do so with v3 #576 ), however, in practice, this would complicate the current code (maybe a wrapper around the replay buffer would be a solution).

Perhaps this is solved with #684 ?

Perhaps this is solved with #684 ?

Only partially solved, we would need to change all the logging around (this would complexify the code a bit) and for some algorithm (like DDPG), we are using a UnvecWrapper (for legacy reason, not planned in the next version) to have only one environment, so switching to a VecEnv may break other things unfortunately.


Bug: Using mock-fs in beforeEach hooks breaks console.log()s

For some reason, using mock-fs in beforeEach() hooks causes all calls to console.log in it() functions to throw a ENOENT, no such file or directory '/path/to/project/node_modules/callsites' error.
const mock = require("mock-fs");

describe("tests", () => {
  beforeEach(() => {
    mock({
      "/foo/bar": {}
    });
  });

  afterEach(() => {
    mock.restore();
  });
  it("should fail", () => {
    console.log(`This console.log will cause an error`);
  });
});

envinfo:
  System:
    OS: macOS Sierra 10.12.6
    CPU: x64 Intel(R) Core(TM) i7-4770HQ CPU @ 2.20GHz
  Binaries:
    Node: 8.4.0
    Yarn: 1.3.2
    npm: 5.6.0
  npmPackages:
    jest:
      wanted: ^22.4.2
      installed: 22.4.2

Reproduction repo: https://github.com/AriaMinaei/jest-mock-fs-bug

I'll try to shed some light on this issue.
callsites is used in the buffered console under the write method, to understand the origin of the log and provide a better experience.
https://github.com/facebook/jest/blob/124067e7d662364d40fc662ef54bfddd798c57c4/packages/jest-util/src/buffered_console.js#L24
https://github.com/facebook/jest/blob/124067e7d662364d40fc662ef54bfddd798c57c4/packages/jest-util/src/buffered_console.js#L53-L54
This method is used here:
https://github.com/facebook/jest/blob/124067e7d662364d40fc662ef54bfddd798c57c4/packages/jest-runner/src/run_test.js#L85
seems that the error comes from mock-fs, from here. Which indicates that this import to callsites is actually taken cared by the mocked fs and not by the real one.
The runTest function is imported from the test_worker which means it has the same context as the test itself (and mock-fs's).
There is a similar issue in mock-fs repo.
I'm not sure what is the wanted behavior here, but using this example should work fine.

To add more, if mock() from mock-fs is called inside the it() block, everything works fine. The error only happens if mock() is called in the beforeEach() block.

Seems to me that calling console.log just before calling mock-fs is a workaround. https://github.com/nknapp/jest-mock-fs-bug

I've started on support for an overlay option for mock-fs.  This should fix the lazy require issue.  In the meantime, @nknapp's workaround is an alternative (calling console.log() before mocking the filesystem).

Possible workaround
const fsMock = require('mock-fs')

const logsTemp = []
let logMock

exports.mock = (config) => {
  logMock = jest.spyOn(console, 'log').mockImplementation((...args) => {
    logsTemp.push(args)
  })
  fsMock(config)
}

exports.restore = () => {
  logMock.mockRestore()
  fsMock.restore()
  logsTemp.map(el => console.log(...el))
}

happends on most recent jest@24


RAINCATCH-911 - Sync cloud backbone

h4. Motivation
Create sync wrapper for cloud.
h4. Status

[x] backbone
[x] custom handlers setup
[x] unit tests
[x] functional tests
[x] documentation (separate repo)
[x] readme
[ ] publish module

@paolobueno Applied all comments

@paolobueno This PR is blocked by build issues ticket I mentioned.


Issue/Bug with query context module

Hi Jan,
With @hypnobunny we believe there could be a subtle issue in line 337 of file /src/java/org/jpl7/Query.java:
qid = Prolog.open_query(Prolog.new_module(Prolog.new_atom(contextModule)), Prolog.Q_CATCH_EXCEPTION, predicate, 	term0);
PL_open_query was being called with the default contextModule value ('user') as opposed to the module determined from application of :/2. While this will not cause an issue for most predicates, meta-predicates with 'module-sensitive' arguments will be affected (as seen here:
http://www.swi-prolog.org/pldoc/man?CAPI=PL_open_query).
Changing the context module term passed to PL_open_query to reflect the module determined from :/2 or contextModule by default ensures correct behaviour of meta-predicates in JPL (which is what we need for our application when using SWI in a Multiagent system). We think a solution would be to change contextModule to just module to look as follows:
qid = Prolog.open_query(Prolog.new_module(Prolog.new_atom(module)), Prolog.Q_CATCH_EXCEPTION, predicate, 	term0);
Would you mind confirming this and if it is correct whether you can make the change in the codebase (so that we avoid having to keep a separate version for us)?
Thanks
Sebastian

Commit f74fb1beb93f0457c5258b134dd3a883a518df30 has fixed this. Still the issue of user as default contextModule needs to be dealt with: why not NULL?


Artifact not found on the snapshot repository.

The artifact listed on the README is not working, I've browsed the repository to see if it was perhaps a DNS issue, but it seems to be missing, the folder me/devnatan does not exist.
repositories {
    maven("https://s01.oss.sonatype.org/content/repositories/snapshots/")
}

dependencies {
    implementation("me.devnatan:yoki:0.0.1-SNAPSHOT")
}

Fixed in v0.1.1 👍🏽


Add test for FakeRepository.get_hashes()

Closes #960
Changelog-friendly one-liner: Add test for FakeRepository.get_hashes()
Contributor checklist

[x] Provided the tests for the changes.
[x] Gave a clear one-line description in the PR (that the maintainers can add to CHANGELOG.md on release).
[ ] Assign the PR to an existing or new milestone for the target version (following Semantic Versioning).

Thanks, @hramezani! 🎉


add missing "it" in ch01-01-building-an-intuition.md

simple, quick fix to change "This feels like should work" to "This feels like it should work"

Thank you!


Ignore count during GPU accumulation

I confirm that this contribution is made under the terms of the license found in the root directory of this repository's source tree and that I have the authority necessary to make this contribution on behalf of its copyright owner.
FYI @oyving

Shouldn't we fix the plus method in NodeResources instead?

Shouldn't we fix the plus method in NodeResources instead?

Seems like it's used for several things, was unsure if other method callers expect count > 1. It'd be great if we can just change NodeResources::plus instead

@mpolden should review this ...

We're missing some unit tests here.

Added test in https://github.com/vespa-engine/vespa/pull/28587


mesa: add valgrind support

Motivation for this change
Completing the work to fix #25917, I think.
Things done

[x] Tested using sandboxing
(nix.useSandbox on NixOS,
or option build-use-sandbox in nix.conf
on non-NixOS)
Built on platform(s)

[x] NixOS
[ ] macOS
[ ] Linux

[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
[ ] Tested execution of all binary files (usually in ./result/bin/)
[x] Fits CONTRIBUTING.md.

cc @vcunat

Making a core package like mesa dependent on valgrind doesn't seem very desirable to me.
Surely mesa doesn't need to depend on valgrind just to install a suppression file?

It's not a suppression file, it's code within mesa that informs valgrind that XYZ memory is ok to access — see discussion in #25917. Since libdrm already depends on valgrind-light now (b4bb39642e80205355593468d8514c7e6a27d96a), mesa does anyway.

Right, my understanding is that there's a macro call defined in valgrind headers that is used to insert specific code patterns into the resulting binaries.  Those are then recognized when interpreted by valgrind.
It's only a build time dependency a valgrind-light is pretty light.


creating a restaurant tile component

this PR contains a basic restaurant tile component that can be used in the browse page.
tiles currently look like this:

Maybe can u put on the tile what the 2 is. I'm guessing its for 2 people, but maybe have it say x people.

Maybe can u put on the tile what the 2 is. I'm guessing its for 2 people, but maybe have it say x people.

Good point. It's actually for price, so I called that out specifically


Ignore gomega bump in uaa v74.5.x branch.

[#186906681]

Can be bumped only after we change the legacy-bosh-docker-image there.
Seems the image is updated for develop branch, is the same update very hard to v74?

Can be bumped only after we change the legacy-bosh-docker-image there.

Seems the image is updated for develop branch, is the same update very hard for v74?

I think so. The image used in v74 is very old one, and according to the comment in concourse/v74-5-x-lts/pipeline.yml work required to upgrade is not trivial. The image change in develop branch was for done for a specific reason.

Approved based on the assumption that we will divest from v74 soon. (Otherwise, ignoring a bump adds burden to the monthly dependency audit process too).


Autocomplete fails with openai gpt-4o model "Invalid 'stop': array too long.

Relevant environment info
"tabAutocompleteModel": {
    "model": "gpt-4o-mini",
    "title": "gpt-4o-mini",
    "provider": "openai",
    "maxStopWords": 20,
    "apiBase": "https://openai-proxy.example.com/v1",
    "apiKey": "sk-xxxxxxxxxxxxxxxxxxxxxxxxxxxx"
  },

Description
this is reopen of this issue
To reproduce
No response
Log output
HTTP 400 Bad Request from https://openai-proxy.example.com/v1/chat/completions {
"error": {
 "message": "Invalid 'stop': array too long. Expected an array with maximum length 4, but got an array with length 9 instead.",
"type": "invalid_request_error",
"param": "stop",
"code": "array_above_max_length" } }

Autocomplete with Bedrock also fails due to the same issue, the API can only take a maximum of 4 stop sequences. An issue for that is open here: #2296

Thanks for the reference at @cgweddle , this seems to be an issue for a handful of providers. Added this to our list of autocomplete bugfixes to tackle in the near future 👍


Added missing verb

IMHO there is a verb missing in the sentence "...but you won't be able to which interactions occurred....".
What's changed, or what was fixed?

Added verb "tell" into the sentence.

CC: @petele

@jeffposnick & @philipwalton - not sure if these docs are generated from the Workbox git repo, or if they come from ours. Can you figure it out and fix? Thanks!

Thanks @Svenmay for spotting and fixing this!

Any update on where these docs are generated/coming from?

Everything under https://github.com/google/WebFundamentals/tree/master/src/content/en/tools/workbox/reference-docs is auto-generated from the JSDoc present in the Workbox source code, using the scripts found in https://github.com/google/WebFundamentals/tree/master/gulp-tasks/workbox. Whenever we cut a new release of Workbox, we need to manually run those scripts and then commit the updated docs to this WebFundamentals repo.
Everything not under https://github.com/google/WebFundamentals/tree/master/src/content/en/tools/workbox/reference-docs is manually written and committed directly to this WebFundamentals repo.

:tada: This has been pushed live to https://developers.google.com/web/


/setup doesn’t appear to fully work

I compiled the AdvancedLED example. When I go to /setup from my web browser I get the following response:
{"setup_uri":"X-HM://005277SG7YK72","pin":"111-11-111"}
Instead of a qrcode.

Could you provide me a log from ESP starting from rebooting until this moment
Thanks
From: Vweston @.>
Sent: Friday, March 26, 2021 10:59 PM
To: Yurik72/ESPHap @.>
Cc: Subscribed @.***>
Subject: [Yurik72/ESPHap] /setup doesn’t appear to fully work (#85)
I compiled the AdvancedLED example. When I go to /setup from my web browser I get the following response:
{"setup_uri":"X-HM://005277SG7YK72","pin":"111-11-111"}
Instead of a qrcode.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub https://github.com/Yurik72/ESPHap/issues/85 , or unsubscribe https://github.com/notifications/unsubscribe-auth/AKDREXJHI5UULCECZPPYKO3TFTYS5ANCNFSM4Z4CVJTQ .  https://github.com/notifications/beacon/AKDREXJX7YWMDWF6UEGTJWDTFTYS5A5CNFSM4Z4CVJT2YY3PNVWWK3TUL52HS4DFUVEXG43VMWVGG33NNVSW45C7NFSM4MRULFYA.gif

Here is a log from re-booting the 8266 device.
#$⸮c⸮⸮ls⸮`⸮⸮o⸮*WM: [1] Configure WiFi
Info
Exit
WM: [1] AutoConnect
WM: [2] Connecting as wifi client...
WM: [3] STA static IP:
WM: [2] setSTAConfig static ip not set, skipping
WM: [1] Connecting to SAVED AP: BN**
WM: [3] Using Password: L*****S***
*WM: [3] WiFi station enable
*WM: [3] enableSTA PERSISTENT ON
*WM: [1] connectTimeout not set, ESP waitForConnectResult...
*WM: [2] Connection result: WL_CONNECTED
*WM: [3] lastconxresult: WL_CONNECTED
*WM: [1] AutoConnect: SUCCESS
*WM: [1] STA IP Address: <IP_ADDRESS>
*WM: [3] unloading

HomeKit: init_storage_ex size 0x1c1
Home Integration: hap_services added chararacteristic  0: 23
Home Integration: hap_services added chararacteristic  1: 25
Home Integration: homekit_is_paired 0
HomeKit: Free heap: 28280
HomeKit: Starting server
HomeKit: storage init 0
HomeKit: Using existing accessory ID: 7F:E9:13:47:9C:FC
HomeKit: find pairings
HomeKit: Preinit pairing context
HomeKit: Using user-specified password: 111-11-111
HomeKit: Free heap: 21936
HomeKit: Calculating public key len=384
HomeKit: Calculating public key result 0
HomeKit: arduino_homekit_preinit success
HomeKit: Configuring mDNS
HomeKit: Wifi Sleep type:2
HomeKit: Set Wifi Sleep type :0
HomeKit: MDNS.begin: EspLed-7FE9, IP: <IP_ADDRESS>
HomeKit: Init server over `

I also noted that if I use /browse it shows the file setup.html with 0 (zero) bytes.
I have not tried this on a ESP32 device yet, but if you need me I can.
thanks for this project. It is starting to really come together.

I did try compiling it for a nodeMCU-32s, but was unable to get it compiled with the following error
`
In file included from /var/folders/_3/vxnqz7t138z2bkfd27wb91gh0000gq/T/arduino_modified_sketch_200835/EspHapAdvancedLed.ino:17:0:
/Users/vweston/Documents/Arduino/libraries/ESPHap/hapweb/hap_webserver.hpp: In function 'void saveFileBrowse()':
/Users/vweston/Documents/Arduino/libraries/ESPHap/hapweb/hap_webserver.hpp:433:59: error: cannot convert 'const char*' to 'const __FlashStringHelper*' for argument '1' to 'void saveFile(const __FlashStringHelper*, const __FlashStringHelper*)'
saveFile(FPSTR(FILE_BROWSE_FILE), FPSTR(FILE_BROWSE_HTML));
^
/Users/vweston/Documents/Arduino/libraries/ESPHap/hapweb/hap_webserver.hpp: In function 'void saveSetup()':
/Users/vweston/Documents/Arduino/libraries/ESPHap/hapweb/hap_webserver.hpp:446:47: error: cannot convert 'const char*' to 'const __FlashStringHelper*' for argument '1' to 'void saveFile(const __FlashStringHelper*, const __FlashStringHelper*)'
saveFile(FPSTR(FILE_SETUP), FPSTR(SETUP_HTML));
^
/Users/vweston/Documents/Arduino/libraries/ESPHap/hapweb/hap_webserver.hpp: In function 'void saveIndex()':
/Users/vweston/Documents/Arduino/libraries/ESPHap/hapweb/hap_webserver.hpp:450:57: error: cannot convert 'const char*' to 'const __FlashStringHelper*' for argument '1' to 'void saveFile(const __FlashStringHelper*, const __FlashStringHelper*)'
saveFile(FPSTR(FILE_INDEX), FPSTR(INDEX_HTML_INTERNAL));
^
/var/folders/_3/vxnqz7t138z2bkfd27wb91gh0000gq/T/arduino_modified_sketch_200835/EspHapAdvancedLed.ino: In function 'void setup()':
EspHapAdvancedLed:86:35: error: cannot convert 'const char*' to 'const __FlashStringHelper*' for argument '1' to 'void set_indexhml(const __FlashStringHelper*)'
set_indexhml(FPSTR(INDEX_HTML));
^
Multiple libraries were found for "WiFi.h"
Used: /Users/vweston/Documents/Arduino/hardware/espressif/esp32/libraries/WiFi
Not used: /Applications/Arduino.app/Contents/Java/libraries/WiFi
exit status 1
cannot convert 'const char*' to 'const __FlashStringHelper*' for argument '1' to 'void set_indexhml(const __FlashStringHelper*)'
`
hope this helps.
-vw

On ESP32 i do not have compilation problem.
So, please check

You are using latest version of ESPHap library v1.1 or better latest commit
You are using ESP32 board library 1.0.5

As well please read suggestions on isssue #51  .
I would say there is not a problem with that. SPIFFS system are used for this purpose, therefore  right partition should be selected. SPIFFS should be formatted. It coud happens with same device with previous firmware before.
So,

Completelly clean (ERASE) ESP
Upload any data to SPIFFS (It will be formatted)
/browse should works and you should see your ESP file system

Any news ?

I gave up compiling for ESP32 after installing the Arduino IDE 1.8.13 on a clean install of MacOS Catalina. I used the Board Manager to install ESP8266 (v 2.7.4) & ESP32 (v 1.0.5 & even v 1.0.6).  I think the ESP32 problem is an Arduino IDE issue where it isn’t recognizing the compiler directives. I’ll deal with the ESP32 later, for Now I’’m working on ESP8266 D1 Mini boards.
As for the ESP8266, that compiles correctly, but setup is still not displaying anything but what I shared earlier. I also flashed it to a D1 Mini with a Erase Flash option. Still no luck. The setup.html file is created, but is zero bytes according to /browse option. Otherwise it appears to work great.
-- VW

On Mar 29, 2021, at 1:00 AM, Yurik72 @.***> wrote:

Any news ?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub, or unsubscribe.

after playing around with this, I was able to get a reliable result. Since setup.html was always a zero byte file I started there. I revised saveFile() in hap_webserver.hpp. here is the code I revised in hap_webserver.hpp
`//void saveFile(const __FlashStringHelper* name, const __FlashStringHelper* content) {
//	String data = FPSTR(content);
//	String filename = name;
//	if (!filename.startsWith("/")) filename = "/" + filename;
//	//INFO("Save file %s", filename.c_str());
//	//INFO("Save file content %s", data.substring(1,90).c_str());
//	File fb = SPIFFS.open(filename, "w+");
//	if (fb)
//		fb.print(data);
//	else
//		ERROR("Save file failed %s", filename.c_str());
//	if (fb)
//		fb.close();
//}
void saveFile(const __FlashStringHelper* name, const __FlashStringHelper* content) {
//String data = FPSTR(content);
String filename = name;
if (!filename.startsWith("/")) filename = "/" + filename;
//INFO("Save file %s", filename.c_str());
//INFO("Save file content %s", data.substring(1,90).c_str());
File fb = SPIFFS.open(filename, "w+");
if (!fb)
ERROR("Save file failed %s",filename.c_str());
else {
fb.print(content);
//Serial.println(fb.size());  //read the file size here
fb.close();
//INFO("%s File Saved", filename.c_str());
}
}`
what I found was that data was always empty with the saveSetup() call therefore making setup.html always empty. by eliminating  //String data = FPSTR(content); and just printing content directly it appears to always work. I think because __FlashStringHelper* has already occurred. Not sure on that.
here is my saveSetup()
void saveSetup() { 	saveFile(FPSTR(FILE_SETUP), FPSTR(SETUP_HTML)); };
It seams to work perfectly for index.html, setup.htm and file browse.html at least for ESP8266 boards. It should be ok for ESP32 but not tested.
/setup.html displays correctly with the appropriate qrcode & scans & adds the accessory properly now.
as for /setup it appears to be doing what is says.
{"setup_uri":"X-HM://00527Y91QYK72","pin":"111-11-111"}
just like it was told to do.
 server.on(PSTR("/setup"),[]() {server.send(200,  FPSTR(TEXT_PLAIN), get_setup_json());});  \
it returns correctly. I just don't know how to get /setup to return /setup.html so that the pairing qrcode displays.
Hope this helps

Ok, I found an error, this is happens due to low memory on ESP.
File setup is 26k. If free heap is less is not written... :)  This is my mistake. currently I have implemented proper way to save file
However is not finish with final logic. When file should be overwritted. Always , If not exists.....
You can check and help me with pull request

I've updated my EspHap library with your recent changes and am currently using them in my tests. So far its working great. I'll keep testing but haven't seen any issues so far. Great work!! I'll let you know if I find any issues.


Redirect URI did not match a registered redirect URI

I get such error
The redirect URI in the request: http://localhost:62506/signin-google did not match a registered redirect URI.
Could you tell me what can be wrong?

You're missing some configuration on the Google side, you need to register the application with Google and set the parameters in Startup.Auth.GoogleSettings.cs

I did just that.
Created Web Client in Google, added Google+ API, set allowed redirect URI to http://localhost:62506/

I think the allowed redirect URL should be http://localhost:62506/signin-google


[Bug]: [Python] Respect BigQuery insert byte size limit when writing batched rows

What happened?
Similar to #24979 but handle the with_batched_input case.
Users can batch their BQ rows and write a PCollection of batches to BigQuery. These batches can exceed the byte size limits of BigQuery inserts [1]. Handle this case by splitting large batches into smaller ones and doing separate flushes.
[1] https://cloud.google.com/bigquery/quotas#streaming_inserts
Issue Priority
Priority: 3 (minor)
Issue Components

[X] Component: Python SDK
[ ] Component: Java SDK
[ ] Component: Go SDK
[ ] Component: Typescript SDK
[X] Component: IO connector
[ ] Component: Beam examples
[ ] Component: Beam playground
[ ] Component: Beam katas
[ ] Component: Website
[ ] Component: Spark Runner
[ ] Component: Flink Runner
[ ] Component: Samza Runner
[ ] Component: Twister2 Runner
[ ] Component: Hazelcast Jet Runner
[ ] Component: Google Cloud Dataflow Runner

+1, this is impacting our ability to turn on autosharding since the check only happens when autosharding is disabled.


[Bug]: Invalid Device Ordinal on ROCm

Your current environment
PyTorch version: 2.4.0.dev20240415+rocm6.0
Is debug build: False
CUDA used to build PyTorch: N/A
ROCM used to build PyTorch: 6.0.32830-d62f6a171

OS: Ubuntu 22.04.4 LTS (x86_64)
GCC version: (Ubuntu 11.4.0-1ubuntu1~22.04) 11.4.0
Clang version: Could not collect
CMake version: version 3.29.2
Libc version: glibc-2.35

Python version: 3.10.12 (main, Nov 20 2023, 15:14:05) [GCC 11.4.0] (64-bit runtime)
Python platform: Linux-5.15.0-102-generic-x86_64-with-glibc2.35
Is CUDA available: True
CUDA runtime version: Could not collect
CUDA_MODULE_LOADING set to: LAZY
GPU models and configuration: AMD Instinct MI300X (gfx942:sramecc+:xnack-)
Nvidia driver version: Could not collect
cuDNN version: Could not collect
HIP runtime version: 6.0.32830
MIOpen runtime version: 3.0.0
Is XNNPACK available: True

CPU:
Architecture:                       x86_64
CPU op-mode(s):                     32-bit, 64-bit
Address sizes:                      52 bits physical, 57 bits virtual
Byte Order:                         Little Endian
CPU(s):                             384
On-line CPU(s) list:                0-383
Vendor ID:                          AuthenticAMD
Model name:                         AMD EPYC 9654 96-Core Processor
CPU family:                         25
Model:                              17
Thread(s) per core:                 2
Core(s) per socket:                 96
Socket(s):                          2
Stepping:                           1
Frequency boost:                    enabled
CPU max MHz:                        3707.8120
CPU min MHz:                        1500.0000
BogoMIPS:                           4792.43
Flags:                              fpu vme de pse tsc msr pae mce cx8 apic sep mtrr pge mca cmov pat pse36 clflush mmx fxsr sse sse2 ht syscall nx mmxext fxsr_opt pdpe1gb rdtscp lm constant_tsc rep_good nopl nonstop_tsc cpuid extd_apicid aperfmperf rapl pni pclmulqdq monitor ssse3 fma cx16 pcid sse4_1 sse4_2 x2apic movbe popcnt aes xsave avx f16c rdrand lahf_lm cmp_legacy svm extapic cr8_legacy abm sse4a misalignsse 3dnowprefetch osvw ibs skinit wdt tce topoext perfctr_core perfctr_nb bpext perfctr_llc mwaitx cpb cat_l3 cdp_l3 invpcid_single hw_pstate ssbd mba ibrs ibpb stibp vmmcall fsgsbase bmi1 avx2 smep bmi2 erms invpcid cqm rdt_a avx512f avx512dq rdseed adx smap avx512ifma clflushopt clwb avx512cd sha_ni avx512bw avx512vl xsaveopt xsavec xgetbv1 xsaves cqm_llc cqm_occup_llc cqm_mbm_total cqm_mbm_local avx512_bf16 clzero irperf xsaveerptr rdpru wbnoinvd amd_ppin cppc arat npt lbrv svm_lock nrip_save tsc_scale vmcb_clean flushbyasid decodeassists pausefilter pfthreshold avic v_vmsave_vmload vgif v_spec_ctrl avx512vbmi umip pku ospke avx512_vbmi2 gfni vaes vpclmulqdq avx512_vnni avx512_bitalg avx512_vpopcntdq la57 rdpid overflow_recov succor smca fsrm flush_l1d
Virtualization:                     AMD-V
L1d cache:                          6 MiB (192 instances)
L1i cache:                          6 MiB (192 instances)
L2 cache:                           192 MiB (192 instances)
L3 cache:                           768 MiB (24 instances)
NUMA node(s):                       2
NUMA node0 CPU(s):                  0-95,192-287
NUMA node1 CPU(s):                  96-191,288-383
Vulnerability Gather data sampling: Not affected
Vulnerability Itlb multihit:        Not affected
Vulnerability L1tf:                 Not affected
Vulnerability Mds:                  Not affected
Vulnerability Meltdown:             Not affected
Vulnerability Mmio stale data:      Not affected
Vulnerability Retbleed:             Not affected
Vulnerability Spec rstack overflow: Mitigation; safe RET
Vulnerability Spec store bypass:    Mitigation; Speculative Store Bypass disabled via prctl and seccomp
Vulnerability Spectre v1:           Mitigation; usercopy/swapgs barriers and __user pointer sanitization
Vulnerability Spectre v2:           Mitigation; Retpolines, IBPB conditional, IBRS_FW, STIBP always-on, RSB filling, PBRSB-eIBRS Not affected
Vulnerability Srbds:                Not affected
Vulnerability Tsx async abort:      Not affected

Versions of relevant libraries:
[pip3] numpy==1.26.4
[pip3] pytorch-triton-rocm==3.0.0+0a22a91d04
[pip3] torch==2.4.0.dev20240415+rocm6.0
[pip3] torchvision==0.19.0.dev20240415+rocm6.0
[conda] No relevant packagesROCM Version: 6.1.33591-3a954afdc
Neuron SDK Version: N/A
vLLM Version: 0.4.0.post1
vLLM Build Flags:
CUDA Archs: Not Set; ROCm: Disabled; Neuron: Disabled
GPU Topology:
Could not collect

🐛 Describe the bug
Issue with invalid ordinal when running with tp=2 on ROCm:
python benchmarks/benchmark_throughput.py --input-len=50 --output-len=100 --model=mistralai/Mistral-7B-v0.1 --tensor-parallel-size=2 --enforce-eager
Namespace(backend='vllm', dataset=None, input_len=50, output_len=100, model='mistralai/Mistral-7B-v0.1', tokenizer='mistralai/Mistral-7B-v0.1', quantization=None, tensor_parallel_size=2, n=1, use_beam_search=False, num_prompts=1000, seed=0, hf_max_batch_size=None, trust_remote_code=False, max_model_len=None, dtype='auto', gpu_memory_utilization=0.9, enforce_eager=True, kv_cache_dtype='auto', quantization_param_path=None, device='cuda', enable_prefix_caching=False, enable_chunked_prefill=False, max_num_batched_tokens=None, download_dir=None)
INFO 04-16 23:49:56 pynccl.py:58] Loading nccl from library librccl.so.1
INFO 04-16 23:49:56 config.py:523] Disabled the custom all-reduce kernel because it is not supported on AMD GPUs.
2024-04-16 23:49:58,704	INFO worker.py:1724 -- Started a local Ray instance.
INFO 04-16 23:50:00 llm_engine.py:87] Initializing an LLM engine (v0.4.0.post1) with config: model='mistralai/Mistral-7B-v0.1', speculative_config=None, tokenizer='mistralai/Mistral-7B-v0.1', tokenizer_mode=auto, revision=None, tokenizer_revision=None, trust_remote_code=False, dtype=torch.bfloat16, max_seq_len=32768, download_dir=None, load_format=auto, tensor_parallel_size=2, disable_custom_all_reduce=True, quantization=None, enforce_eager=True, kv_cache_dtype=auto, quantization_param_path=None, device_config=cuda, decoding_config=DecodingConfig(guided_decoding_backend='outlines'), seed=0)
(pid=1376632) INFO 04-16 23:50:01 pynccl.py:58] Loading nccl from library librccl.so.1
INFO 04-16 23:50:04 selector.py:38] Using ROCmFlashAttention backend.
(RayWorkerVllm pid=1376787) INFO 04-16 23:50:04 selector.py:38] Using ROCmFlashAttention backend.
(RayWorkerVllm pid=1376787) ERROR 04-16 23:50:04 ray_utils.py:50] Error executing method init_device. This might cause deadlock in distributed execution.
(RayWorkerVllm pid=1376787) ERROR 04-16 23:50:04 ray_utils.py:50] Traceback (most recent call last):
(RayWorkerVllm pid=1376787) ERROR 04-16 23:50:04 ray_utils.py:50]   File "/home/vllm_install/vllm/vllm/engine/ray_utils.py", line 43, in execute_method
(RayWorkerVllm pid=1376787) ERROR 04-16 23:50:04 ray_utils.py:50]     return executor(*args, **kwargs)
(RayWorkerVllm pid=1376787) ERROR 04-16 23:50:04 ray_utils.py:50]   File "/home/vllm_install/vllm/vllm/worker/worker.py", line 97, in init_device
(RayWorkerVllm pid=1376787) ERROR 04-16 23:50:04 ray_utils.py:50]     torch.cuda.set_device(self.device)
(RayWorkerVllm pid=1376787) ERROR 04-16 23:50:04 ray_utils.py:50]   File "/home/vllm_install/venv/lib/python3.10/site-packages/torch/cuda/__init__.py", line 399, in set_device
(RayWorkerVllm pid=1376787) ERROR 04-16 23:50:04 ray_utils.py:50]     torch._C._cuda_setDevice(device)
(RayWorkerVllm pid=1376787) ERROR 04-16 23:50:04 ray_utils.py:50] RuntimeError: HIP error: invalid device ordinal
(RayWorkerVllm pid=1376787) ERROR 04-16 23:50:04 ray_utils.py:50] HIP kernel errors might be asynchronously reported at some other API call, so the stacktrace below might be incorrect.
(RayWorkerVllm pid=1376787) ERROR 04-16 23:50:04 ray_utils.py:50] For debugging consider passing AMD_SERIALIZE_KERNEL=3.
(RayWorkerVllm pid=1376787) ERROR 04-16 23:50:04 ray_utils.py:50] Compile with `TORCH_USE_HIP_DSA` to enable device-side assertions.
(RayWorkerVllm pid=1376787) ERROR 04-16 23:50:04 ray_utils.py:50]

This with building on latest main. Was hoping this was fixed with https://github.com/vllm-project/vllm/pull/3770, but no amount of environmental configuration has helped either (CUDA_VISIBLE_DEVICES, etc).

I get same error
(vllm) ehartford@tw003:~/models/dolphin-2.9.2-qwen2-72b$ python -m vllm.entrypoints.openai.api_server --trust-remote-code --tensor-parallel-size 8 --model /home/ehartford/models/dolphin-2.9.2-qwen2-72b
INFO 05-27 20:36:35 config.py:569] Disabled the custom all-reduce kernel because it is not supported on AMD GPUs.
2024-05-27 20:36:37,825 INFO worker.py:1749 -- Started a local Ray instance.
INFO 05-27 20:36:40 llm_engine.py:103] Initializing an LLM engine (v0.4.2) with config: model='/home/ehartford/models/dolphin-2.9.2-qwen2-72b', speculative_config=None, tokenizer='/home/ehartford/models/dolphin-2.9.2-qwen2-72b', skip_tokenizer_init=False, tokenizer_mode=auto, revision=None, rope_scaling=None, tokenizer_revision=None, trust_remote_code=True, dtype=torch.bfloat16, max_seq_len=131072, download_dir=None, load_format=LoadFormat.AUTO, tensor_parallel_size=8, disable_custom_all_reduce=True, quantization=None, enforce_eager=False, kv_cache_dtype=auto, quantization_param_path=None, device_config=cuda, decoding_config=DecodingConfig(guided_decoding_backend='outlines'), seed=0, served_model_name=/home/ehartford/models/dolphin-2.9.2-qwen2-72b)
Special tokens have been added in the vocabulary, make sure the associated word embeddings are fine-tuned or trained.
INFO 05-27 20:36:57 selector.py:56] Using ROCmFlashAttention backend.
(RayWorkerWrapper pid=2194398) INFO 05-27 20:36:57 selector.py:56] Using ROCmFlashAttention backend.
(RayWorkerWrapper pid=2194149) ERROR 05-27 20:36:57 worker_base.py:146] Error executing method init_device. This might cause deadlock in distributed execution.
(RayWorkerWrapper pid=2194149) ERROR 05-27 20:36:57 worker_base.py:146] Traceback (most recent call last):
(RayWorkerWrapper pid=2194149) ERROR 05-27 20:36:57 worker_base.py:146]   File "/home/ehartford/miniconda3/envs/vllm/lib/python3.11/site-packages/vllm-0.4.2+rocm613-py3.11-linux-x86_64.egg/vllm/worker/worker_base.py", line 138, in execute_method
(RayWorkerWrapper pid=2194149) ERROR 05-27 20:36:57 worker_base.py:146]     return executor(*args, **kwargs)
(RayWorkerWrapper pid=2194149) ERROR 05-27 20:36:57 worker_base.py:146]            ^^^^^^^^^^^^^^^^^^^^^^^^^
(RayWorkerWrapper pid=2194149) ERROR 05-27 20:36:57 worker_base.py:146]   File "/home/ehartford/miniconda3/envs/vllm/lib/python3.11/site-packages/vllm-0.4.2+rocm613-py3.11-linux-x86_64.egg/vllm/worker/worker.py", line 105, in init_device
(RayWorkerWrapper pid=2194149) ERROR 05-27 20:36:57 worker_base.py:146]     torch.cuda.set_device(self.device)
(RayWorkerWrapper pid=2194149) ERROR 05-27 20:36:57 worker_base.py:146]   File "/home/ehartford/miniconda3/envs/vllm/lib/python3.11/site-packages/torch/cuda/__init__.py", line 404, in set_device
(RayWorkerWrapper pid=2194149) ERROR 05-27 20:36:57 worker_base.py:146]     torch._C._cuda_setDevice(device)
(RayWorkerWrapper pid=2194149) ERROR 05-27 20:36:57 worker_base.py:146] RuntimeError: HIP error: invalid device ordinal
(RayWorkerWrapper pid=2194149) ERROR 05-27 20:36:57 worker_base.py:146] HIP kernel errors might be asynchronously reported at some other API call, so the stacktrace below might be incorrect.
(RayWorkerWrapper pid=2194149) ERROR 05-27 20:36:57 worker_base.py:146] For debugging consider passing HIP_LAUNCH_BLOCKING=1.
(RayWorkerWrapper pid=2194149) ERROR 05-27 20:36:57 worker_base.py:146] Compile with `TORCH_USE_HIP_DSA` to enable device-side assertions.

did you solve this?

ehartford

Hello Eric, I just encountered the same issue as you. Have you resolved it?

did you solve this?

Did you solve this? Several of my machine encountered this issue at the same time.

did you solve this?

Did you solve this? Several of my machine encountered this issue at the same time.

Reinstalling the conda env can solve this.

did you solve this?

Did you solve this? Several of my machine encountered this issue at the same time.

Reinstalling the conda env can solve this.

how to do this?

did you solve this?

Did you solve this? Several of my machine encountered this issue at the same time.

Reinstalling the conda env can solve this.

I will try this if I encounter it again

Do you still have the issue? Please update.

Closing this issue as the issue should have been resolved. Please open a new one if you run into the similar issue again


The definition of hand’s approximate geometric center

Please provide a link to the documentation entry, for example: https://google.github.io/mediapipe/solutions/hands.html#multi_hand_world_landmarks
Description of issue (what needs changing):
Could you please give more information about the definition of hand's approximate geometric center? I couldn't quiet understand this origin of coordinate system. If there are some picture to describe it will be better
Kinds of documentation problems:
Clear description
For example, why should someone use this method? How is it useful?
Knowing the origin of gesture's coordinate is important when we use the gesture skeletion ouput. But if I don't know the definition of hand's approximate geometric center, I don't know the coordinate of the gesture in world coordinate also.

Hi @IDownToEarth ,
"multi_hand_world_landmarks" field contains the hand landmarks on each detected hand in real-world 3D coordinates which is in meters with the origin at the hand's approximate geometric center. Could you please check with the latest version.

I just find this part do some description, but I am still confused with the hand's approximate geometric center, I still not know the origin of the coordinate system.
Another person also has the same question.
https://groups.google.com/g/mediapipe/c/lrcaVbeI7h4

Hello @IDownToEarth,
We are upgrading the MediaPipe Legacy Solutions to new MediaPipe solutions However, the libraries, documentation, and source code for all the MediapPipe Legacy Solutions will continue to be available in our GitHub repository and through library distribution services, such as Maven and NPM.
You can continue to use those legacy solutions in your applications if you choose. Though, we would request you to check new MediaPipe solutions which can help you more easily build and customize ML solutions for your applications. These new solutions will provide a superset of capabilities available in the legacy solutions. Thank you


npm run email not working?

if you are on Windows, using CMD
 "email": "cp .env ./node_modules/react-email && email dev --dir src/email --port 3001", will not work. you will most probably get 'cp' is not recognized as an internal or external command,
operable program or batch file.
then, all StackOverflow answers will say, replace cp with copy, and it still wouldn't work due to The syntax of the command is incorrect.
this one was working for me (thanks ChatGPT)
in the package.json email script, use this one:
"email": "copy .env .\\node_modules\\react-email & email dev ^--dir src\\email ^--port 3001"

It is because cp is executable in linux/unix os, maybe try using git bash in vscode terminal.

For the people having issues on MacOs
do the following :  check
https://react.email/docs/getting-started/manual-setup

sudo chown -R 501:20 "/Users/joelkarhamba/.npm"


Updated to HTML5 Mode

Ok to merge to master independently.  The additional gulp plugin allows gulp to serve this properly without any backend changes.  However, it should NOT be pushed to the live site without the corresponding backend changes in genome/civic-server#294 since the HTML5 mode URLs require a backend change to allow refreshing the page.
Added a simple handler for routing errors.  Any time that CIViC isn't able to reach the requested state, the user will be redirected to home, and presented with a modal alert to inform them of the error.
Change to the sitemap reflects change in genome/civic-server#294 to avoid undoing the change when a new build of the client is pushed.
closes #680

Eventually, this will close #680 but it could take a few days after this gets pushed live for Google to re-index the site

Rebased onto master to fix conflicts


Garbage-collect cache.nixos.org

Is your feature request related to a problem? Please describe.
We need to reduce our S3 storage costs.
https://discourse.nixos.org/t/the-nixos-foundations-call-to-action-s3-costs-require-community-support/28672
Describe the solution you'd like
Write a program that does the following:

Delete old NixOS/Nixpkgs releases from https://releases.nixos.org/. (Instead of deleting, we could move them to Glacier as an intermediate step.) Specifically:

For every NixOS release older than 2 years, delete all point releases except the most recent. E.g. for nixos-14.04, we keep nixos-14.04.630.8a3eea0 (since that's the latest) and delete all the others.
For every NixOS release younger than 2 years, delete all pre-releases older than 1 month.
For Nixpkgs, we don't have stable releases, so just delete all releases older than 2 years.

Run a garbage-collect on cache.nixos.org, using the following store paths as roots:

The contents of every store-paths.xz from the NixOS/Nixpkgs releases.
The current Hydra roots (see hydra-update-gc-roots.
The fallback-paths.nix files from every stable Nix release.
Every content-addressed store path (i.e. whose .narinfo has a CA field). This prevents GC-ing source tarballs.
Every store path older than TBD whose name ends in .tar.[gz|xz|lzma|.... This prevents GC-ing source tarballs that predate the introduction of the CA field.
Every store path whose .narinfo is younger than 2 years.

Please not. As described in https://discourse.nixos.org/t/the-nixos-foundations-call-to-action-s3-costs-require-community-support/28672/4, GC'ing should be the last resort.
There's been plenty of alternatives suggested in the discourse post, but in general, there's some ways described how we can keep a GET https://cache.nixos.org/nar/…* working, without having to keep all NAR files in the S3 bucket.

The most significant cost bump is due to direct access to the S3 bucket. See https://github.com/NixOS/nixos-org-configurations/issues/277#issuecomment-1741777458 .

@flokli No, GCing is definitely necessary. It's what we promised to Amazon.

@flokli No, GCing is definitely necessary. It's what we promised to Amazon. (The increase in data traffic to the S3 bucket is the most pressing, but we also need to reduce storage costs.)

I assume we didn't promise AWS to GC, but to reduce the amount of data we store there, no?

I think it is important to have a meeting on the subject to set the expectations straight, @edolstra
We made multiple suggestions of a task force to explore getting the historical data somewhere else, etc. I feel like it's important to not let those help proposals down.
The people who want to unblock the situation and make it better needs more communication from the people driving this matter.
I propose to convene a meeting to discuss laying out a plan for our S3 situation w.r.t. to AWS promises, it should include:

timeline for letting folks figuring out a better solution than GC'ing
timeline for executing a GC if we don't meet our alternative solution deadline

Otherwise, people have been working for naught and this is disrespectful. And I agree that if nothing happens, we should just proceed with the GCing solution.

I assume we didn't promise AWS to GC, but to reduce the amount of data we store there, no?

Well, that's the same thing (unless we migrate away from S3 entirely). We can of course mirror closures elsewhere before GCing, if we want to pay the egress costs.

I propose to convene a meeting

Good idea.
GCing is not super-urgent (compared to dealing with the increase in traffic costs), but we should be able to show AWS that we're making some progress.

Well, that's the same thing (unless we migrate away from S3 entirely).

No - for example, we could migrate away from S3 partially and use a cheaper/less reliable tier of long term storage for older/lesser accessed files. We'd keep the strong reliability and performance benefits of S3 for the most important paths, and less important paths could be held on other best-effort mirrors. That's just one potential set of "intermediate solutions", there is likely a whole gradient of them.
(This is not an invitation to design such a solution here - the fact that they potentially exist and would be viable is sufficient for the sake of this argument.)

we could migrate away from S3 partially

That's what I meant with "We can of course mirror closures elsewhere before GCing".

Here we go, please fill this to discuss: https://crab.fit/cachenixosorg-size-reduction-strategies-420938

@flokli @edolstra @zimbatm let's meet the 24th October, at 4PM CEST, according to that poll.

That's in 30 minutes.  Coordination in https://matrix.to/#/#infra:nixos.org I guess?

This issue has been mentioned on NixOS Discourse. There might be relevant details there:
https://discourse.nixos.org/t/2023-10-24-re-long-term-s3-cache-solutions-meeting-minutes-1/34580/1


14.20 patch?

Approximately when will you update to Renz patch 14.20?

I have been using it for 3 months and I also used the previous renzski and I did not encounter any bans.


header added

in this pull req

Header Added
https://github.com/deyemiobaa/Movie-Database/projects/2#card-80460690

Optional request:  You can make the header responsive to mobile displays


ADDED SPACE CRAFT GAME

Description
Before each game, players have the opportunity to modify their spacecraft models directly in the editor. This is where they can purchase new blocks and make adjustments to their design. Once players are satisfied with their modifications and feel prepared, they can enter the game with their customized spacecraft.
Fixes:  #2249

Type of change

[x] Bug fix (non-breaking change which fixes an issue)
[x] New feature (non-breaking change which adds functionality)
[x] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[x] This change requires a documentation update

Checklist:

[x] I have made this from my own
[x] I have taken help from some online resourses
[x] My code follows the style guidelines of this project
[x] I have performed a self-review of my own code
[x] I have commented my code, particularly in hard-to-understand areas
[x] I have made corresponding changes to the documentation
[x] My changes generate no new warnings

ATTACH SCREEN-SHOTS / DEPLOYMENT LINK

@Sulagna-Dutta-Roy

Even this project also same. I can't merge it and unable to review this. My repository will break.
If you're working in open source program you shouldn't have pushed more than certain files ideally 1-6 files. If the code breaking my repository, then I will not accept it. Thanks @TheNikhilRaj


Help: Error when building Unity project

Hi,
I've added the latest version of Json.net package (12.0.3) to my Unity project, but when I build the project to test on my iOS device I get the following error:
Exception: /Applications/2019.4.6f1/Unity.app/Contents/il2cpp/build/deploy/net471/UnityLinker.exe did not run properly!
UnityEditorInternal.Runner.RunProgram (UnityEditor.Utils.Program p, System.String exe, System.String args, System.String workingDirectory, UnityEditor.Scripting.Compilers.CompilerOutputParserBase parser) (at /Users/builduser/buildslave/unity/build/Editor/Mono/BuildPipeline/BuildUtils.cs:128)
UnityEditorInternal.Runner.RunManagedProgram (System.String exe, System.String args, System.String workingDirectory, UnityEditor.Scripting.Compilers.CompilerOutputParserBase parser, System.Action`1[T] setupStartInfo) (at /Users/builduser/buildslave/unity/build/Editor/Mono/BuildPipeline/BuildUtils.cs:71)
UnityEditorInternal.AssemblyStripper.RunAssemblyLinker (System.Collections.Generic.IEnumerable`1[T] args, System.String& out, System.String& err, System.String linkerPath, System.String workingDirectory) (at /Users/builduser/buildslave/unity/build/Editor/Mono/BuildPipeline/AssemblyStripper.cs:166)
UnityEditorInternal.AssemblyStripper.StripAssembliesTo (System.String outputFolder, System.String& output, System.String& error, System.Collections.Generic.IEnumerable`1[T] linkXmlFiles, UnityEditorInternal.UnityLinkerRunInformation runInformation) (at /Users/builduser/buildslave/unity/build/Editor/Mono/BuildPipeline/AssemblyStripper.cs:159)
UnityEditorInternal.AssemblyStripper.RunAssemblyStripper (UnityEditorInternal.UnityLinkerRunInformation runInformation) (at /Users/builduser/buildslave/unity/build/Editor/Mono/BuildPipeline/AssemblyStripper.cs:301)
UnityEditorInternal.AssemblyStripper.StripAssemblies (System.String managedAssemblyFolderPath, UnityEditorInternal.BaseUnityLinkerPlatformProvider unityLinkerPlatformProvider, UnityEditorInternal.IIl2CppPlatformProvider il2cppPlatformProvider, UnityEditor.RuntimeClassRegistry rcr, UnityEditor.ManagedStrippingLevel managedStrippingLevel) (at /Users/builduser/buildslave/unity/build/Editor/Mono/BuildPipeline/AssemblyStripper.cs:178)
UnityEditorInternal.IL2CPPBuilder.Run () (at /Users/builduser/buildslave/unity/build/Editor/Mono/BuildPipeline/Il2Cpp/IL2CPPUtils.cs:327)
UnityEditorInternal.IL2CPPUtils.RunIl2Cpp (System.String tempFolder, System.String stagingAreaData, UnityEditorInternal.IIl2CppPlatformProvider platformProvider, System.Action`1[T] modifyOutputBeforeCompile, UnityEditor.RuntimeClassRegistry runtimeClassRegistry) (at /Users/builduser/buildslave/unity/build/Editor/Mono/BuildPipeline/Il2Cpp/IL2CPPUtils.cs:65)
UnityEditor.iOS.PostProcessiPhonePlayer.CrossCompileManagedDlls (UnityEditor.iOS.PostProcessiPhonePlayer+BuildSettings bs, UnityEditor.iOS.PostProcessiPhonePlayer+ProjectPaths paths, UnityEditor.AssemblyReferenceChecker checker, UnityEditor.RuntimeClassRegistry usedClassRegistry, UnityEditor.Build.Reporting.BuildReport buildReport) (at /Users/builduser/buildslave/unity/build/PlatformDependent/iPhonePlayer/Extensions/Common/BuildPostProcessor.cs:898)
UnityEditor.iOS.PostProcessiPhonePlayer.PostProcess (UnityEditor.iOS.PostProcessiPhonePlayer+BuildSettings bs, UnityEditor.iOS.PostProcessiPhonePlayer+ProjectPaths paths, UnityEditor.RuntimeClassRegistry usedClassRegistry, UnityEditor.Build.Reporting.BuildReport buildReport) (at /Users/builduser/buildslave/unity/build/PlatformDependent/iPhonePlayer/Extensions/Common/BuildPostProcessor.cs:731)
UnityEditor.iOS.PostProcessiPhonePlayer.PostProcess (UnityEditor.iOS.PostProcessorSettings postProcessorSettings, UnityEditor.Modules.BuildPostProcessArgs args) (at /Users/builduser/buildslave/unity/build/PlatformDependent/iPhonePlayer/Extensions/Common/BuildPostProcessor.cs:679)
UnityEditor.iOS.iOSBuildPostprocessor.PostProcess (UnityEditor.Modules.BuildPostProcessArgs args) (at /Users/builduser/buildslave/unity/build/PlatformDependent/iPhonePlayer/Extensions/Common/ExtensionModule.cs:45)
Rethrow as BuildFailedException: Exception of type 'UnityEditor.Build.BuildFailedException' was thrown.
UnityEditor.iOS.iOSBuildPostprocessor.PostProcess (UnityEditor.Modules.BuildPostProcessArgs args) (at /Users/builduser/buildslave/unity/build/PlatformDependent/iPhonePlayer/Extensions/Common/ExtensionModule.cs:49)
UnityEditor.Modules.DefaultBuildPostprocessor.PostProcess (UnityEditor.Modules.BuildPostProcessArgs args, UnityEditor.BuildProperties& outProperties) (at /Users/builduser/buildslave/unity/build/Editor/Mono/Modules/DefaultBuildPostprocessor.cs:27)
UnityEditor.PostprocessBuildPlayer.Postprocess (UnityEditor.BuildTargetGroup targetGroup, UnityEditor.BuildTarget target, System.String installPath, System.String companyName, System.String productName, System.Int32 width, System.Int32 height, UnityEditor.BuildOptions options, UnityEditor.RuntimeClassRegistry usedClassRegistry, UnityEditor.Build.Reporting.BuildReport report) (at /Users/builduser/buildslave/unity/build/Editor/Mono/BuildPipeline/PostprocessBuildPlayer.cs:340)
UnityEngine.GUIUtility:ProcessEvent(Int32, IntPtr) (at /Users/builduser/buildslave/unity/build/Modules/IMGUI/GUIUtility.cs:197)

My class:
namespace TestGame
{

    using System.Globalization;
    using Newtonsoft.Json;
    using Newtonsoft.Json.Converters;

    public partial class GameModel
    {
        [JsonProperty("playerTwoColor")]
        public string PlayerTwoColor { get; set; }

        [JsonProperty("tokens")]
        public Token[] Tokens { get; set; }

        [JsonProperty("playerOneColor")]
        public string PlayerOneColor { get; set; }

        [JsonProperty("isLocalPlayersTurn")]
        public bool IsLocalPlayersTurn { get; set; }

        [JsonProperty("gameGrid")]
        public long[][] GameGrid { get; set; }

        [JsonProperty("gridSize")]
        public long GridSize { get; set; }
    }

    public partial class Token
    {
        [JsonProperty("player")]
        public long Player { get; set; }

        [JsonProperty("coord")]
        public Coord Coord { get; set; }
    }

    public partial class Coord
    {
        [JsonProperty("x")]
        public long X { get; set; }

        [JsonProperty("y")]
        public long Y { get; set; }
    }

    public partial class GameModel
    {
        public static GameModel FromJson(string json) => JsonConvert.DeserializeObject<GameModel>(json, TestGame.Converter.Settings);
    }

    public static class Serialize
    {
        public static string ToJson(this GameModel self) => JsonConvert.SerializeObject(self, TestGame.Converter.Settings);
    }

    internal static class Converter
    {
        public static readonly JsonSerializerSettings Settings = new JsonSerializerSettings
        {
            MetadataPropertyHandling = MetadataPropertyHandling.Ignore,
            DateParseHandling = DateParseHandling.None,
            Converters =
            {
                new IsoDateTimeConverter { DateTimeStyles = DateTimeStyles.AssumeUniversal }
            },
        };
    }
}

Then from one of my game C# scripts I call:
        GameModel game;// = GameModel();

        if (match.Data != null)
        {
            var x = System.Text.Encoding.UTF8.GetString(match.Data);

            Debug.Log($"Data: {x}");
            game = GameModel.FromJson(x)
        }
        else
        {
            Debug.Log("New Game");
        }

The TestGame class was generated via https://app.quicktype.io and it seems to work ok in a small C# Console app via the standard Newtonsoft.Json library from Nuget.
Any help appreciated

Hi @gavinb80! Thanks for reporting this! I reformatted your description a little. I conclude from your error message that you're using Unity 2019.4.6.f1, but I cannot make any other informative guesses on what could be the cause here, sorry to say. I will try reproduce the issue and report back on my findings.

Two suggestions I have looking in a very cursory manner at the error:

Look at the stripping level setting in the Project Settings, also if it is for specific classes being stripped out and add them to the link.xml to prevent that;
Make sure you are using the AOT version of Newtonsoft for the iOS build.

Make sure you are using the AOT version of Newtonsoft for the iOS build.

If you're using the UPM package, or even importing the package as-is with it's entire content, then it should already be configured to automatically select the AOT compatible build on iOS. Good to double-check though!

If you have 2019.4.* Unity version, don`t use "jillejr.newtonsoft.json-for-unity": "12.0.301" , use "jillejr.newtonsoft.json-for-unity": "12.0.201" instead inside manifest.xml and it will build it sucessfully.

I got this error when build webgl on 12.0.301 version. On older I still build webgl success.
Fatal error in Unity CIL Linker System.ArgumentException: Member 'System.Void System.Runtime.CompilerServices.NullableAttribute::.ctor(System.Byte)'

@trongcongdn2 That error seems related to what's mentioned in #54. A fix for that can be found in #72 and is coming in v12.0.302
As for your sample @gavinb80, I was unable to reproduce it on both Low and Medium stripping level as it built successfully. On High stripping level issue #54 took precedence. That error may be the one you refered to here, but I'm unsure.
I will be including the following link.xml config just to make sure:
<linker>
	<assembly fullname="Newtonsoft.Json">
		<type fullname="Newtonsoft.Json.Converters.IsoDateTimeConverter" preserve="all"/>
	</assembly>
</linker>

I will close this issue via PR #72. Please don't refrain from reopening this or creating a new issue if any similar errors ever appear.

@trongcongdn2 That error seems related to what's mentioned in #54. A fix for that can be found in #72 and is coming in v12.0.302
As for your sample @gavinb80, I was unable to reproduce it on both Low and Medium stripping level as it built successfully. On High stripping level issue #54 took precedence. That error may be the one you refered to here, but I'm unsure.
I will be including the following link.xml config just to make sure:
<linker>
	<assembly fullname="Newtonsoft.Json">
		<type fullname="Newtonsoft.Json.Converters.IsoDateTimeConverter" preserve="all"/>
	</assembly>
</linker>

I will close this issue via PR #72. Please don't refrain from reopening this or creating a new issue if any similar errors ever appear.


Giving file name as parameter to get-text than giving the path

can i give file  name instead of file path to the method get-text
It would be great if it is possible for my requirement.
And it would be helpful if u suggest any library for my requirement, my requirement is to read a doc and docx files and display the read data in an text area. we get files by onClick or by drag and drop
thank you in advance!

Hi @DivyaD2805 , thanks for raising this question. You can easily pass only the filename if you are sitting in the same directory. For the second segment, a bit more context in terms of code will be necessary.

Hey ! @abhinaba-ghosh  thanks for replying  !
Actually the file is not stored in any of the directory..it will input by user onClick or by Drag and Drop
so that time can i send the file what i catch into the get-text method
Thanks


docfx documentation artifacts should be created by github actions

currently, you have to run the project in release mode, then the html are updated and can be commited.
This should be done by a github action, so that html files no longer are part of repo
see
https://dotnet.github.io/docfx/index.html#publish-to-github-pages

this is resolved a while ago


tf.slice triggers XLA recompilation on each call despite static shape, while xla.dynamic_slice does not

Issue type
Performance
Have you reproduced the bug with TensorFlow Nightly?
Yes
Source
binary
TensorFlow version
2.18.0-dev20240919
Custom code
Yes
OS platform and distribution
No response
Mobile device
No response
Python version
No response
Bazel version
No response
GCC/compiler version
No response
CUDA/cuDNN version
No response
GPU model and memory
No response
Current behavior?
When using tf.function with jit_compile=True, I've observed that tf.slice leads to XLA recompilation at each function call, even when the tensor shape are static. Explicitly using tensorflow.compiler.tf2xla.python.xla.dynamic_slice instead resolves this issue and prevents recompilation.
Expected behavior: tf.slice should not trigger XLA recompilation when shapes are static, similar to xla.dynamic_slice.
Actual behavior: tf.slice causes XLA recompilation on each call leading to a 100x slower performance.
Question: Shouldn't tf.slice be automatically converted to xla.dynamic_slice or an equivalent XLA operation to avoid unnecessary recompilation?
Standalone code to reproduce the issue
import time

import tensorflow as tf
import tensorflow.compiler.tf2xla.python.xla as xla

@tf.function(jit_compile=True)
def func_xla_slice(n):
  range = tf.range(100)
  slice = xla.dynamic_slice(range, [n], [50])
  return slice

@tf.function(jit_compile=True)
def func_tf_slice(n):
  range = tf.range(100)
  slice = tf.slice(range, [n], [50])
  return slice

if __name__ == '__main__':
  print(tf.version.VERSION)

  # tracing calls
  func_xla_slice(tf.constant(0))
  func_tf_slice(tf.constant(0))

  start = time.time()
  for i in range(1, 50):
    func_xla_slice(tf.constant(i))
  print(f"XLA slice took {(time.time() - start) * 1000:.0f} ms")

  start = time.time()
  for i in range(1, 50):
    func_tf_slice(tf.constant(i))
  print(f"TF slice took {(time.time() - start) * 1000:.0f} ms")

Relevant log output
XLA slice took 19 ms
TF slice took 2016 ms

I would like to know more about this issue.
I have a thought of solution that if we could make a custom wrapper function which wraps the xla.dynamic_slice operation. By using wrapper internally, maybe we will be able to address the recompilation issue. And then, Replace calls to tf.slice with xla_optimized_slice in XLA-compiled functions.

@nicolaspi,
As mentioned the difference is more when I tried to execute the code on tensorflow v2.17(2.18.0-dev20240922), but whereas on tf-nightly, the time taken for the execution is reduced than the v2.17. Kindly find the gist of it here. Thank you!

@tilakrayal Thank you for the performance comparison. While the gap has narrowed in nightly, tf.slice is still significantly slower (28x) than xla.dynamic_slice. Why is the issue marked as awaiting response from author? The core problem remains unchanged :)


Reduce default heightmap sampling from 2 to 1

There's no good reason to subsample by default, see discussion in https://github.com/ignitionrobotics/ign-rendering/pull/180#discussion_r551661502.
This also needs to be changed in Heightmap.hh once that's merged forward, so I'll keep this PR as a draft until:

[x] #458 is merged
[x] then a 10 ➡ 11 PR is merged
[x] this PR is updated to also change the default sampling on the C++ code

Codecov Report

Merging #459 (5e685d0) into master (ed198a0) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #459   +/-   ##
=======================================
  Coverage   87.56%   87.56%
=======================================
  Files          64       64
  Lines        9704     9704
=======================================
  Hits         8497     8497
  Misses       1207     1207

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ed198a0...5e685d0. Read the comment docs.

Codecov Report

Merging #459 (5e685d0) into master (ed198a0) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #459   +/-   ##
=======================================
  Coverage   87.56%   87.56%
=======================================
  Files          64       64
  Lines        9704     9704
=======================================
  Hits         8497     8497
  Misses       1207     1207

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ed198a0...5e685d0. Read the comment docs.

This PR is ready for review

This PR is ready for review

changes look good. Just need to update the heightmap test expectations to fix the failing tests

changes look good. Just need to update the heightmap test expectations to fix the failing tests

@scpeters , I'd like to make sure you agree with this change from the physics point of view

@scpeters , I'd like to make sure you agree with this change from the physics point of view


test: correct a couple of tests for Windows

On Windows, we do not emit the base type pointer and instead will fill
that in at runtime just like the resilient strategy.  Permit this in the
IRGen checks.

Replace this paragraph with a description of your changes and rationale. Provide links to external references/discussions if appropriate.

Resolves SR-NNNN.

CC: @eeckstein @jckarter

@swift-ci please test

Build failed
Swift Test OS X Platform
Git Sha - 753613cc338460bb6df6a931199c511eda3b2a82

Build failed
Swift Test Linux Platform
Git Sha - 753613cc338460bb6df6a931199c511eda3b2a82

@swift-ci please test

Build failed
Swift Test Linux Platform
Git Sha - 753613cc338460bb6df6a931199c511eda3b2a82

Build failed
Swift Test OS X Platform
Git Sha - 753613cc338460bb6df6a931199c511eda3b2a82

@swift-ci please test

Build failed
Swift Test Linux Platform
Git Sha - 753613cc338460bb6df6a931199c511eda3b2a82

Build failed
Swift Test OS X Platform
Git Sha - 753613cc338460bb6df6a931199c511eda3b2a82


Heroku default subdomain Host fix

I found a bug in the readme.md - I made a fix
I forked the project and created a branch with the fix (I tried it, it works):
Before the fix the talos manager web didn't come up (the youtube video is wrong):
https://www.youtube.com/watch?v=TCIkPvC9_ZA&t=8m38s

The two sections don't seem to make sense in this PR and I'm not sure why we're switching the order of the sections.
The minimal fix is to just add the heroku config:set HOST=$(heroku config:get HEROKU_APP_DEFAULT_DOMAIN_NAME) step to the heroku subdomain section right?

The two sections don't seem to make sense in this PR and I'm not sure why we're switching the order of the sections.
The minimal fix is to just add the heroku config:set HOST=$(heroku config:get HEROKU_APP_DEFAULT_DOMAIN_NAME) step to the heroku subdomain section right?

Because:
heroku labs:enable runtime-dyno-metadata
will give us the HEROKU_APP_DEFAULT_DOMAIN_NAME
And HOST has to be equal to HEROKU_APP_DEFAULT_DOMAIN_NAME or this won't work.
Disclaimer: I haven't ran my fix from scratch, but updating HOST (when following the youtube was projectname>.herokuapp.com) to be the value of HEROKU_APP_DEFAULT_DOMAIN_NAME (-.herokuapp.com) was the fix.

creating another one