layer: revamp for readability

When adding verbiage for restriction on duplicate entries in the tar
archive, it was not immediately clear where this information would be
organized.
This revamp seeks to make the document on the whole more suitable for
implementors and be interpretable for compliance.
Signed-off-by: Vincent Batts<EMAIL_ADDRESS>

Fixes #196
@opencontainers/image-spec-maintainers PTAL
For convenience, the view or the document is https://github.com/vbatts/oci-image-spec/blob/clarify_tar_entry_order/layer.md

@vbatts I had another PR trying to add intro text. Want to use any of it? https://github.com/opencontainers/image-spec/pull/231

@philips yeah for sure. I can carry-over your commit.

Closes #231

Fixes #220

now git show --check fails on travis? but not for me locally... does someone have an ubuntu box to run this on to see if git show --check reports issues for them?

On Wed, Sep 07, 2016 at 11:53:32AM -0700, Vincent Batts wrote:

does someone have an ubuntu box to run this on to see if git show
--check reports issues for them?

$ git --version
git version <IP_ADDRESS>.g85f0837
$ git show --oneline --check 6059128
6059128 layer: add introductory comments
config.md:64: trailing whitespace.
+{
config.md:74: trailing whitespace.

   "ExposedPorts": {

config.md:77: trailing whitespace.

   "Env": [

strange. @philips did not touch config.md, and my git did not report any issues with that commit...
[vbatts@bananaboat] {clarify_tar_entry_order} ~/src/opencontainers/image-spec$ git --version
git version 2.9.0

Regardless, I fixed those spaces and pushed an update. PTAL

On Wed, Sep 07, 2016 at 12:45:31PM -0700, Vincent Batts wrote:

strange. @philips did not touch config.md…

$ git show --oneline --stat 6059128a66
6059128 layer: add introductory comments
config.md        | 366 +++++++++++++++++++++++++++++++++++++++++++++++++++++++
layer.md         |  15 ++-
serialization.md | 366 -------------------------------------------------------
3 files changed, 377 insertions(+), 370 deletions(-)
$ git show --oneline --stat -M50 6059128a66
6059128 layer: add introductory comments
serialization.md => config.md |  0
layer.md                      | 15 +++++++++++----
2 files changed, 11 insertions(+), 4 deletions(-)
It was renamed.  Maybe your Git has automatic rename detection without
needing a hint like -M50.
In any case, while I like the serialization.md → config.md rename (and
it was mentioned in the IRC chat copied in #231 1), I think it may
have been accidental in #231 and that we should drop it here.  It
doesn't really impact the layer rewrite, and it's half-baked:
$ git describe --always origin/pr/255
v0.4.0-82-gce722f3
wking@ullr ~/src/opencontainers/image-spec $ git grep serialization.md v0.4.0-82-gce722f3
v0.4.0-82-gce722f3:Makefile:    serialization.md
v0.4.0-82-gce722f3:README.md:This specification defines how to create an OCI Image, which will generally be done by a build system, and output an image manifest, a filesystem serialization, and an image configuration. At a high level the image manifest contains metadata about the contents and dependencies of the image including the content-addressable identity of one or more filesystem serialization archives that will be unpacked to make up the final runnable filesystem. The image configuration includes information such as application arguments, environments, etc. The combination of the image manifest, image configuration, and one or more filesystem serializations is called the "OCI Image".
v0.4.0-82-gce722f3:README.md:* An image manifest and filesystem serialization (base layer)
v0.4.0-82-gce722f3:manifest.md:    The referenced configuration object is a JSON blob that the runtime uses to set up the container, see Image JSON Description.
v0.4.0-82-gce722f3:media-types.md:- application/vnd.oci.image.config.v1+json: Container config JSON
v0.4.0-82-gce722f3:schema/spec_test.go: validate(t, "../serialization.md")

fair
On Wed, Sep 7, 2016 at 3:56 PM W. Trevor King<EMAIL_ADDRESS>wrote:

On Wed, Sep 07, 2016 at 12:45:31PM -0700, Vincent Batts wrote:

strange. @philips did not touch config.md…

$ git show --oneline --stat 6059128a66
6059128 layer: add introductory comments
config.md | 366 +++++++++++++++++++++++++++++++++++++++++++++++++++++++
layer.md | 15 ++-
serialization.md | 366
3 files changed, 377 insertions(+), 370 deletions(-)
$ git show --oneline --stat -M50 6059128a66
6059128 layer: add introductory comments
serialization.md => config.md | 0
layer.md | 15 +++++++++++----
2 files changed, 11 insertions(+), 4 deletions(-)
It was renamed. Maybe your Git has automatic rename detection without
needing a hint like -M50.
In any case, while I like the serialization.md → config.md rename (and
it was mentioned in the IRC chat copied in #231 1), I think it may
have been accidental in #231 and that we should drop it here. It
doesn't really impact the layer rewrite, and it's half-baked:
$ git describe --always origin/pr/255
v0.4.0-82-gce722f3
wking@ullr ~/src/opencontainers/image-spec $ git grep serialization.md
v0.4.0-82-gce722f3
v0.4.0-82-gce722f3:Makefile: serialization.md
v0.4.0-82-gce722f3:README.md:This specification defines how to create an
OCI Image, which will generally be done by a build system, and output an
image manifest, a filesystem serialization, and an image configuration. At a high level the image
manifest contains metadata about the contents and dependencies of the image
including the content-addressable identity of one or more filesystem
serialization archives that will be unpacked to make up the final runnable
filesystem. The image configuration includes information such as
application arguments, environments, etc. The combination of the image
manifest, image configuration, and one or more filesystem serializations is
called the "OCI Image".
v0.4.0-82-gce722f3:README.md:* An image manifest and
filesystem serialization (base layer)
v0.4.0-82-gce722f3:manifest.md: The referenced configuration object is a
JSON blob that the runtime uses to set up the container, see Image JSON
Description.
v0.4.0-82-gce722f3:media-types.md:-
application/vnd.oci.image.config.v1+json: Container config JSON
v0.4.0-82-gce722f3:schema/spec_test.go: validate(t, "../serialization.md")
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/opencontainers/image-spec/pull/255#issuecomment-245397481,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAEF6YY2cX426Ews_vjbBZeGVlgPg44nks5qnxbbgaJpZM4J0hox
.

rebased on the updated #231, which removes the file rename.
PTAL

(tests pass)

LGTM

@vbatts also, I didn't realize this change was missed in the rebase https://github.com/opencontainers/image-spec/pull/255/files#r77901622

REJECT

Rejected

@philips broken link? what was missed in the rebase?

LGTM
@vbatts the link was to a comment that is now hidden because you fixed the issue. Thanks!

@opencontainers/image-spec-maintainers please take a look and LGTM

LGTM
Nits can be taken care of in later PRs.
Thanks for doing this. This was greatly needed.


Don't eat exceptions from faulted Tasks.

If explicitly testing for IsCompleted then one must also test for IsFaulted and if not handling the exception, return the faulted Task.

Does it also make sense to return the task if it is cancelled?

Are you sure the test is in the right place? When the Task isn't completed then it will be awaited, and the state machine should handle returning a faulted task.
It is when the Task IsCompleted is true that we need to check whether it is faulted, no?

Oh darn it. Some of these are not right in other ways, too.

No, it's the only flaw with it.
More haste, less speed.
PTAL, but I want a test hitting at least a couple of these paths before merge. Coming up soon.

Should the task also be returned if it is cancelled?

At the time we first added some of these I was thinking that since they were in a hot path and if cancellation had been requested it was likely to happen in a subsequent task anyway, so I deliberately left that out. If we're having a check anyway, maybe it's as well to check for that too. I wonder how light that check is.

We can switch on task.Status and have faulted, canceled completed all in one test.

Right. That should do it, I think.

Just a couple of minor things. Looks good!

I can't see why the exception isn't happening in the test in .NET core, and as such whether the bug is in the code or the test. It's late here, so I won't be looking at it again for some time, but maybe you can see what the issue is.

I'd actually fixed that problem and introduced something silly. This is good to go.
It occurs to me that now we're explicitly looking at the status we can in fact do anything in the switch for failed tasks; as is returns the failure immediately, continuing to the method that would await it would result in that method failing. The latter would perhaps have a slightly better call-stack, in terms of the method names seen, but the former (as currently is in this PR) would be marginally faster. It's much of a muchness, I suppose.

LGTM


Hide Temperature Hue Motion Sensor "excludeSensorTypes": ["ZHATemperature"] isn't working

Issue

Hello Eric, many thanks for your plugin.
I'd like to hide the Temperature from the Hue Motion Sensors from my HomeKit setup because I've other Temperature Sensors that are more accurate than the Hue Motion Sensors.
I tried the steps you described it at several closed issues and at the wiki - but unfortunately I couldn't get it working.
Neither the  "excludeSensorTypes": ["ZHATemperature"] ist working nor the "excludeSensorTypes": ["ZLLTemperature"]
The temperatures are still shown at the Home App
At the moment my config.json is looking like that

{
"platform": "Hue",
"users": {
"abcedefghijklmno": "somepasscode"
},
"name": "Hue",
"host": „192.168.xxx.xx",
"excludeSensorTypes": ["ZLLTemperature","ZHATemperature"],
"forceHttp": true,
"lights": true
},

Do you have a suggestion what the problem could be?
Regards
Christian
homebridge-hue.json.gz
Log Messages

Debug Files

With that config.json, you're not exposing any sensors through Homebridge Hue.  I think they're exposed natively by the Hue bridge?  Unfortunately, that's all-or-nothing, so the only way to achieve what you want is to remove the Hue bridge from HomeKit and to expose all devices, incl. Hue lights and sensors, though Homebridge Hue.

Hello Erik,
thank you for your fast reply.
If I delete the hue bridge from my homekit setup vis the home app and add it afterwards via the homekit plugin are my rules, scenes and names for the lamps gone, or they're still safed on the bridge and appearing unchanged after the transfer?
Regards

Hue bridge groups and scenes are actually Zigbee groups and scenes, and are stored in the lights non-volatile memory.  API resources are stored on the Hue bridge, incl. names, rules, schedules, etc.
Homekit groups, scenes, automations, room assignments and service and accessory names are stored in the HomeKit database on your iOS device(s), and are lost when you (temporarily) remove the corresponding accessory.


Fix all the colon spacing

I don't even know how to fix that. I don't think I can as I don't have write access to this repo.

See Commit
👍


backup path

The settings:
{"online_sync_enabled": false, "zip_backup_path": "F:/custom_path/SublimePackagesBackup.zip"}
does not work! It still prompts the location of my desktop.

Apologies for not looking into this earlier. If this is still happening, please share your debug log. Closing due to age.


Loading jars using lib folder

Hey guys,
I've got  Scala [2.11.8] Spark [2.1.0] Hadoop [2.8.0] {Hive ✓} on Ubuntu 16.04.
It is installed from zip archive. I'm running it from spark-notebook folder using ./bin/spark-notebook
I'm trying to add a simple jar through lib folder under spark-notebook.
And, the problem is it doesn't work.
Here's my source for jar:
package sample
object people {
  class Person (age: Int, name: String) {
    def say: Unit = {
	println ("Hi, I'm" + name)
    }
  }
}

sbt file:
name := "sample"
version := "1.0"
organization := "org.example"
scalaVersion := "2.11.8"

Here's a result of import from jar located under spark-notebook/lib folder using sbt console

And here's spark-notebook one

Interestingly it works for spark-notebook 0.6.3 and spark 1.6.3 version under Windows 10 with same notebook setup. (0.7.0+ wont work on windows :( )
Hope for your help.
Thanks in advance!

+1

Indeed, the adding the jar into the lib folder isn't enough, this is because the spark-notebook script/s are listing explicitly all jars added to the classpath.
Also, another problem will happen if you want to use these jars on the executors because they won't be added to the Spark configuration.
The recommended way would be (let me know if make sense, and worth improving):

Add the path in the var env EXTRA_CLASSPATH: it uses : as paths separator and will add the jar into the driver's classpath
Add the path in the var env ADD_JARS: this one uses , as paths separator and will the jar into the executors' classpath

So you could do something like:
# copy the jar
cp my-lib.jar lib

# launch with my-lib in both driver and executors classpaths
EXTRA_CLASSPATH=../lib/my-lib.jar ADD_JARS=../lib/my-lib.jar bin/spark-notebook

HTH


Fixes - Timedelta comparison incompatibility

On the latest versions of numpy and pandas, direct comparison of numpy and pandas timedeltas is broken. These fixes allow the use of the latest numpy and pandas by making all timedelta comparisons be between two pandas timedeltas.

Coverage remained the same at 80.445% when pulling 1063da33679d79b2b33ca80539345f0e5ef0d806 on fixes into 582e208bb10820805172939cb35383dfbd9f51b8 on master.

Coverage remained the same at 80.445% when pulling 1063da33679d79b2b33ca80539345f0e5ef0d806 on fixes into 582e208bb10820805172939cb35383dfbd9f51b8 on master.


Add default value for justify-content

According to the standard, the default value for justify-content if it is not specified is flex-start.
Source: https://www.w3schools.com/cssref/css3_pr_justify-content.asp

[X] I have read freeCodeCamp's contribution guidelines.
[X] My pull request has a descriptive title (not a vague title like Update index.md)
[X] My pull request targets the master branch of freeCodeCamp.
[X] None of my changes are plagiarized from another source without proper attribution.
[X] My article does not contain shortened URLs or affiliate links.

LGTM

Thank you for your contribution to the page! 👍
We're happy to accept these changes, and look forward to future contributions. 🎉


luaL_loadbufferx

The mode check can be implemented by checking if first character is \x1b. (that's what lua does internally via LUA_SIGNATURE[0]: http://www.lua.org/source/5.1/ldo.c.html#f_parser http://www.lua.org/source/5.3/ldo.c.html#f_parser)
Related to https://github.com/ThePhD/sol2/issues/508

Closed with #34.


Allow empty fetchresult

[ x ] I have added the tests to cover my changes.
[ x ] I have updated the documentation, VERSION, and CHANGELOG accordingly.
[ x ] I have read the CONTRIBUTING document.

covalent_ui.app.fetch_result previously assumed that the requested result exists in the dispatch db. This is not always the case, as the result might not yet have hit the db when the UI is notified of the result.
With this PR, fetch_result checks if the db actually contains the desired result and returns an empty response if not. Previously an unhandled IndexError would be raised by the expression res[0][1] if res is an empty list.

Looks good. Let's return a 400 status code though.


[Ironsworn] Update Burdens to reflect the new sheet

Changes / Comments
Quick text update for the burdens:

They are now Cursed and Tormented

They were updated in the latest versions of Ironsworn so just keeping this reflecting the new version.
Keeping the variables the same as to preserve player data.
Roll20 Requests
Comments are very helpful for reviewing the code changes. Please answer the relevant questions below in your comment.

[x] Does the pull request title have the sheet name(s)? Include each sheet name.
[x] Is this a bug fix?
[ ] Does this add functional enhancements (new features or extending existing features) ?
[ ] Does this add or change functional aesthetics (such as layout or color scheme) ?
[ ] If changing or removing attributes, what steps have you taken, if any, to preserve player data ?
[ ] If this is a new sheet, did you follow Building Character Sheets standards ?

If you do not know English. Please leave a comment in your native language.

Greetings @LeeRhodes
There was another update for Ironsworn this week. It looks like that may have resulted in conflicts. These will need to be resolved so I can merge them.

Cassie

Going to close this PR and raise a new one, the conflict is causing me issues.


Correction for raw affiliation Schulich School of Medicine and Dentistry, Western University, London, Ont

Correction needed for raw affiliation Schulich School of Medicine and Dentistry, Western University, London, Ont
raw_affiliation_name: Schulich School of Medicine and Dentistry, Western University, London, Ont
new_rors: 02grkyz14
previous_rors: 02agqkc58
works_examples: W4386156185;W4389828318;W4317722126
contact: a9267ae2f7442cf36c4a6dd0c79900a5:2634bab696282793 @ uwo.ca

This issue was accepted and ingested by the OpenAlex team on 2024-12-19. The new affiliations should be visible within the next 7 days.


need support for delimited wire format

We use the delimited wire format in the project: each message is prepended with varuint32 indicating its length. This corresponds to parseDelimitedFrom in Google protobuf, or decodeDelimited() in protobufjs.
Similar functionality is needed in protouf-es, both for reading and writing.

Hey @cc32d9, you are referring to the length-delimitation described in https://github.com/protocolbuffers/protobuf/issues/10229, correct?
This is a reasonable request. Can I ask in what context you are using this feature? Are you reading from a stream, or are you looking into splitting a buffer into messages?

hi, I'm designing and prototyping this protocol: https://github.com/fixpayments/pbtx_rpc
The MVP will use HTTP POST requests, so message framing is not a problem because there's content-length header. But The protocol is designed for IoT devices, and they may need different ways of transport. For example, a sequence of records on an SD card. Or a LoRa connection which is totally unreliable and dropping messages is a normal daily life there. But LoRa is an extreme example and anyway it needs additional mechanisms for delivery assurance. But a possibility to send a sequence of messages in a single HTTP POST call would be appealing.
So, ideally, we need a mechanism to read a sequence of messages from a stream, so that each message is prepended by its varint32 length. Also, a corresponding message writer which can produce such a stream.

Thanks for the context, @cc32d9.
Unfortunately, we don't have a single standard for streams in JavaScript, but I think we can provide basic functions to serialize and parse, and also some helpful functions for implementing streams in Node or with WHATWG streams.
Expect a PR soonish :)

@cc32d9, this PR implement basic support for size-delimited messages: https://github.com/bufbuild/protobuf-es/pull/387
Let us know if that would work for your use case.

@cc32d9, this is now available in v1.1.0.
You can find some documentation here.


Code in 0-starter doesn't match write up

Trying to follow https://docs.microsoft.com/en-us/learn/modules/react-get-started/ -- it notes that the starter project (0-starter) should have two folders (public, src) and have snowpack.config.js included - but it has none of that.  All that's there is the package.json. Without that, following the tute and running npm start script results in a snowpack server with no index file - pretty confusing for a user just starting up.
Best,
D

Yeah it's missing. I just wend to the code/1-getting-started/end folder and copied the snowpack.config.js file. It works after that

Did the same - should be fine for anyone with a basic familiarity with
node, ms learn, etc... more thinking for front end folks who are just
starting with concepts around running builds, etc
On Wed, Apr 7, 2021 at 2:09 AM Samiullah Khan @.***>
wrote:

Yeah it's missing. I just wend to the code/1-getting-started/end folder
and copied the snowpack.config.js file. It works after that
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/MicrosoftDocs/mslearn-react/issues/2#issuecomment-814630621,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/ADTAMALDI625GL5FRFCGU3TTHPZITANCNFSM42LPEJYQ
.

This tripped me up too. The language here should be changed to e.g. 'in /code/3-state-events/end'

I did everything manually. I created two empty files both public and src. And it work with snowpack.config.js file.

This is completely my fault. I filed PR #1 and forgot to actually merge it. Sorry for all of the confusion!!


Add alternative to deprecated annotations

Following discussion from https://github.com/doctrine/mongodb-odm/issues/1459#issuecomment-255722659
Instead of just saying that this class is deprecated (and probably got a lot of issues related to that) add an alternative to it.

@alcaeus should be ok now.

Awesome, thanks! 🍻

Ah, forgot one can now change target branch of PR, approved changes and left for evening to merge manually :baby:

👍


What's the mistake, please?

https://github.com/AlekPet/ComfyUI_Custom_Nodes_AlekPet/assets/131615326/06e592f5-a4a9-4bc4-9691-ee3e7c3a2aa2

This question has already been asked Error here, but I did not receive additional information, I will conduct more tests.  Thanks, I'll look into it.

Fixed the error, everything should work now, update and check.

Yes, it's back to normal now. Thank you


Linting the javascript code

As discussed in #13314 I have gone thru the code with ESLint to make it follow Standard style. There is one commit per linting rule as requested.
Reviewing this is probably easiest to do commit by commit.
ping @zackw

What about using this https://github.com/Flet/semistandard ? Yes, I know about semicolons in JavaScript. But I like semicolons!

I personally prefer without semicolons but it would be easy to update the pull request to include them.
Should be noted that standard is much more popular compared to semistandard. 132 872 downloads in the last month versus 10 329.

When it comes to JavaScript, I also have a strong preference for fully semicolon-ed code.  The "automatic semicolon insertion" rules are somewhat counterintuitive, and relying on them can get you into trouble.

So here's how I suggest we move forward on this.
I am going to annotate each commit with either :+1: or :-1:, and in the latter case, an explanation of why I don't like the changes made.  You rebase your patch series with all of the :+1: commits shuffled before all of the :-1: commits.  Since the weekend is coming up, I will give @ariya and @Vitallium until Tuesday morning (Feb. 9) to file objections, and then (assuming there are none) I will merge all of the :+1: commits.  That cuts down your merge burden and we can then iterate on the rest of it.
Do we want to think about having some degree of automatic checking for new lint errors in our JS?

Oh, also, did you lint anything outside src/?

To reduce the risk I recommend the following.
First, separate all the style-related change (cosmetics) that does not change the semantics of the code. This includes e.g. unifying string literals to use single quote, adding/removing whitespaces, etc. In this step, try to adhere as much possible to existing code, e.g. since we use semicolons, don't remove them. Instead of using standards, this is easier done using JSCS. Take a look at my other project, Esprima, where checking for this is a simple JSCS call (https://github.com/jquery/esprima/blob/master/package.json#L75). Side note: @mikesherov and I gave a talk on this subject: https://www.youtube.com/watch?v=954lRqSI_Ro.
After that, the semantics-related change needs to be evaluated carefully. Changing == to === is not to be taken lightly. This is not about style preference or popularity. This is simply because it is not always obvious (this is JavaScript after all) why it was written that way and thus changing it without taking a pause and think can lead to a latent defect.
I think it's easier for @zackw and me (and others) to review the change if you create a dedicated pull request for the first step first (style changes) and it's fine to have it in a series of small commits.

This includes e.g. unifying string literals to use single quote

Those are semantically the same in javascript

, adding/removing whitespaces, etc.

That shouldn't change the semantics of the code? Unless your breaking ASI which I aren't doing...

Changing == to === is not to be taken lightly.

True, but I went thru each change very carefully and I'm 100% that they don't change anything. I've commented why on that commit as well...

Oh, also, did you lint anything outside src/?

Nope :)

So here's how I suggest we move forward on this.
...

That sounds good :+1:

Do we want to think about having some degree of automatic checking for new lint errors in our JS?

The plan here was to be able to use the standard command (which is eslint with a provided config) but if you want to stick to 4 spaces that won't work (semicolons could be solved by using semistandard). One way would be to write our own eslint-config.

This includes e.g. unifying string literals to use single quote
Those are semantically the same in javascript
, adding/removing whitespaces, etc.
That shouldn't change the semantics of the code? Unless your breaking ASI which I aren't doing...

Not sure I follow. I completely agree that this doesn't change semantics as that was exactly what I wrote.

The plan here was to be able to use the standard command...

standard is simply too opinionated. I agree with @zackw that we should pick a style as close as possible to the existing style and other surrounding code.
@LinusU Did you take a look at JSCS?

Not sure I follow. I completely agree that this doesn't change semantics as that was exactly what I wrote.

Sorry, I must have misread

standard is simply too opinionated.

That's the beauty with it :)

Did you take a look at JSCS?

Haven't looked at it too much but from what I have understand it doesn't recognise potential code bugs which eslint does. E.g. unused variables, accidental globals...
Looking at npm it seems like eslint is more popular, with more than twice the downloads. I guess it doesn't matter too much though...

standard is simply too opinionated.
That's the beauty with it :)

Sure, if you want to start a new project from scratch. But here in this context, we have to consider many different factors, including a close resemblance to other related code. Our JavaScript code is minuscule compared to C++, what good it is to change all JavaScript code to indent with 2-space if the majority is 4-space C++ code?

Did you take a look at JSCS?
Haven't looked at it too much but from what I have understand it doesn't recognise potential code bugs which eslint does. E.g. unused variables, accidental globals...

That's precisely the point. Let's separate style unification vs potential code bugs.

Looking at npm it seems like eslint is more popular, with more than twice the downloads. I guess it doesn't matter too much though...

We all love ESLint, but popularity here is not a factor that improves software quality.

Sure, if you want to start a new project from scratch. But here in this context, we have to consider many different factors, including a close resemblance to other related code. Our JavaScript code is minuscule compared to C++, what good it is to change all JavaScript code to indent with 2-space if the majority is 4-space C++ code?

Yeah I understand where you're coming from, I just personally like standard very much but I understand why you might not want to adapt it.
How do you feel about rebasing with only the things that have been :+1:ed and then we can move forward with JSCS after that?

... then we can move forward with JSCS after that?

I think we should investigate JSCS use before making that decision. Otherwise, that may lead to another additional work.

Closing to due to lack of follow-ups.


Add basic XCM configuration

The fully working bridge may be started by using branches, mentioned in https://github.com/paritytech/parity-bridges-common/issues/2547. I'm going to open multiple PRs to make it easier to review - some PRs need a different set of reviewers
From bridges perspective, we need an XCM configuration to be able to dispatch inbound messages. I'm not pretending to be an XCM expert, so I'm opening this PR to ask questions and collectively understand what we need. This PR doesn't do anything with bridge - it just adds the xcm_executor::Config, required to be able to execute XCM programs.
Some important points:

I haven't added the pallet-xcm to runtime, because IIUC we don't need it here. However if you think we need it, we may try to plug it in;
I've mentioned Kawabunga parachain - it is the parachain, which will be bridging with the Bulletin chain over Polkadot BH, which is not available;
I'll leave explicit PR comments where I need some help and/or we may need to discuss something.

Also pinging https://github.com/orgs/paritytech/teams/bridges-core for review

@zdave-parity Could you, please, approve if you have no more comments. Or else give one of reviewers a write access to this repo. We can't merge without that. Thank you!


GM: Move more interface attributes into CarSpecs

Description
Moved the following fields into the CarSpecs:

minEnableSpeed for cars that do not fit into the existing 7mph/10kph categories
tireStiffnessFactor
steerActuatorDelay, newly added to base CarSpecs class. I put 0.1 as a hopefully sensible default.

Additionally, I set the default lateral tune to torque since only two cars still use PID.
This has the overall effect of heavily reducing most of the GM interface, except for the Volt and Escalade ESV which need to specify the PID tune, and the Silverado min enable speed logic.
Verification
CI testing

Can you rebase?

There's a lot to verify here, can you split it out? Like switching the torque vs. pid tune setting and the min steer/engage speeds?

We've moved the car interfacing code to our opendbc repository, which is now the new home for car ports and fingerprints. Please re-open your pull request against opendbc at your convenience by using this command below. This will transform all changes under selfdrive/car/ to opendbc_repo/opendbc/car/. Make sure you have initialized submodules beforehand and have checked out the latest opendbc commit.
PR_NUMBER=33045
curl -L https://github.com/commaai/openpilot/pull/$PR_NUMBER.patch | sed -e 's/selfdrive\/car/opendbc_repo\/opendbc\/car/g' | git apply -v --reject

Simply replace the PR number with your own. Once done, add the files, fix any conflicts, and open a new PR. Alternatively, you may start a new PR from scratch if that is easier for you.


Failed to update powershell preview by winget because it told me need the old(now) version package(msi) to uninstall

Prerequisites

[X] Write a descriptive title.
[X] Make sure you are able to repro it on the latest released version
[X] Search the existing issues.
[X] Refer to the FAQ.
[X] Refer to Differences between Windows PowerShell 5.1 and PowerShell.

Steps to reproduce
winget install --id Microsoft.Powershell.Preview --source winget
Now I didn't notice that I even need the old package to uninstall the powershell in windows control panel?
I firstly installed powershell by winget too
Expected behavior
insatll finished

Actual behavior
Found an existing package already installed. Trying to upgrade the installed package...
Found PowerShell Preview [Microsoft.PowerShell.Preview] Version <IP_ADDRESS>
This application is licensed to you by its owner.
Microsoft is not responsible for, nor does it grant any licenses to, third-party packages.
Successfully verified installer hash
Starting package install...
The installer will request to run as administrator, expect a prompt.
Installation abandoned

Environment data
Name                           Value
----                           -----
PSVersion                      7.5.0-preview.2
PSEdition                      Core
GitCommitId                    7.5.0-preview.2
OS                             Microsoft Windows 10.0.26244
Platform                       Win32NT
PSCompatibleVersions           {1.0, 2.0, 3.0, 4.0…}
PSRemotingProtocolVersion      2.3
SerializationVersion           <IP_ADDRESS>
WSManStackVersion              3.0

OS Data
C:\WINDOWS\system32              26244       彼方           00330-80000-00000-AA835 10.0.26244

Windows update log
=== Logging started: 2024/7/14/星期日  23:50:53 ===
Action start 23:50:53: INSTALL.
Action start 23:50:53: FindRelatedProducts.
Action ended 23:50:53: FindRelatedProducts. Return value 1.
Action start 23:50:53: AppSearch.
Action ended 23:50:53: AppSearch. Return value 1.
Action start 23:50:53: AddExplorerContextMenuOpenPowerShell_DeleteIfOff.
Action ended 23:50:53: AddExplorerContextMenuOpenPowerShell_DeleteIfOff. Return value 1.
Action start 23:50:53: AddFileContextMenuRunPowerShell_DeleteIfOff.
Action ended 23:50:53: AddFileContextMenuRunPowerShell_DeleteIfOff. Return value 1.
Action start 23:50:53: AddToPath_SetDefault.
Action ended 23:50:53: AddToPath_SetDefault. Return value 1.
Action start 23:50:53: DisableTelemetry_DeleteIfOff.
Action ended 23:50:53: DisableTelemetry_DeleteIfOff. Return value 1.
Action start 23:50:53: EnableMU_SetDefault.
Action ended 23:50:53: EnableMU_SetDefault. Return value 1.
Action start 23:50:53: EnablePsRemoting_DeleteIfOff.
Action ended 23:50:53: EnablePsRemoting_DeleteIfOff. Return value 1.
Action start 23:50:53: RegisterManifest_SetDefault.
Action ended 23:50:53: RegisterManifest_SetDefault. Return value 1.
Action start 23:50:53: UseMU_SetDefault.
Action ended 23:50:53: UseMU_SetDefault. Return value 1.
Action start 23:50:53: LaunchConditions.
Action ended 23:50:53: LaunchConditions. Return value 1.
Action start 23:50:53: ValidateProductID.
Action ended 23:50:53: ValidateProductID. Return value 1.
Action start 23:50:53: CostInitialize.
Action ended 23:50:53: CostInitialize. Return value 1.
Action start 23:50:53: FileCost.
Action ended 23:50:53: FileCost. Return value 1.
Action start 23:50:53: CostFinalize.
Action ended 23:50:55: CostFinalize. Return value 1.
Action start 23:50:55: MigrateFeatureStates.
Action ended 23:50:56: MigrateFeatureStates. Return value 1.
Action start 23:50:56: InstallValidate.
Action ended 23:51:36: InstallValidate. Return value 1.
Action start 23:51:36: RemoveExistingProducts.
CustomAction  returned actual error code 1612 (note this may not be 100% accurate if translation happened inside sandbox)
MSI (s) (FC:B0) [23:51:36:451]: Product: PowerShell 7-preview-x64 -- Error 1714. The older version of PowerShell 7-preview-x64 cannot be removed.  Contact your technical support group.  System Error 1612.

Error 1714. The older version of PowerShell 7-preview-x64 cannot be removed.  Contact your technical support group.  System Error 1612.
Action ended 23:51:36: RemoveExistingProducts. Return value 3.
Action ended 23:51:36: INSTALL. Return value 3.
Property(S): UpgradeCode = {39243D76-ADAF-42B1-94FB-16ECF83237C8}
Property(S): WINDOWS_PRODUCT_NAME = Windows 10 Pro
Property(S): ProductName = PowerShell 7-preview-x64
Property(S): UNIVERSAL_C_RUNTIME_INSTALLED = C:\WINDOWS\System32\ucrtbase.dll
Property(S): PWRSHPLUGIN_VERSION = C:\WINDOWS\System32\pwrshplugin.dll
Property(S): ADD_PATH = 1
Property(S): REGISTER_MANIFEST = 1
Property(S): USE_MU = 1
Property(S): ENABLE_MU = 1
Property(S): VersionFolder = C:\Program Files\PowerShell\7-preview\
Property(S): ApplicationProgramsFolder = C:\ProgramData\Microsoft\Windows\Start Menu\Programs\PowerShell\
Property(S): dir29BCD5E4F7C373C512ED73538E9DCDDC = C:\Program Files\PowerShell\7-preview\assets\
Property(S): dirC8E9F16F9A20BA1D5DDCCA5A45CDBB30 = C:\Program Files\PowerShell\7-preview\cs\
Property(S): dir62737D9B68FCE1A160FD7060BABA7D16 = C:\Program Files\PowerShell\7-preview\de\
Property(S): dirA0F95362C57A863D0BBD3169843E0168 = C:\Program Files\PowerShell\7-preview\en-US\
Property(S): dirE9741044F11F34C9FB894C3195538F19 = C:\Program Files\PowerShell\7-preview\es\
Property(S): dir129AF85AD0C10215FE56B9AC914B957D = C:\Program Files\PowerShell\7-preview\fr\
Property(S): dir1264D4B514CA91C40526D37CCEB9A7FC = C:\Program Files\PowerShell\7-preview\it\
Property(S): dir73E2E403359779398A69DED9DDBC6DCE = C:\Program Files\PowerShell\7-preview\ja\
Property(S): dir7420AA9104B3567C205C9A83CC1F34A7 = C:\Program Files\PowerShell\7-preview\ko\
Property(S): dir2C1939E11D676420ED32C4A4AB5AE75F = C:\Program Files\PowerShell\7-preview\Modules\CimCmdlets\
Property(S): dir10CFC3C98E09FE79358AC32CCD4B96E5 = C:\Program Files\PowerShell\7-preview\Modules\Microsoft.PowerShell.Archive\
Property(S): dirC50829A786E72246CACCBE4C6689C6C9 = C:\Program Files\PowerShell\7-preview\Modules\Microsoft.PowerShell.Archive\en-US\
Property(S): dir31B5BAA615507779F83CF03A348466C1 = C:\Program Files\PowerShell\7-preview\Modules\Microsoft.PowerShell.Diagnostics\
Property(S): dir788172CBE294D89D86540F1EBB3FD60E = C:\Program Files\PowerShell\7-preview\Modules\Microsoft.PowerShell.Host\
Property(S): dirECB880C70FDD8930882746B467651E08 = C:\Program Files\PowerShell\7-preview\Modules\Microsoft.PowerShell.Management\
Property(S): dirF05D78794A7CFC1D6D5C075B45BAC8F5 = C:\Program Files\PowerShell\7-preview\Modules\Microsoft.PowerShell.PSResourceGet\
Property(S): dir8D8C89A7042272443AAD6B15FD28E0C3 = C:\Program Files\PowerShell\7-preview\Modules\Microsoft.PowerShell.PSResourceGet\dependencies\
Property(S): dir77ED6D9C3E903DBD86023B4147613C43 = C:\Program Files\PowerShell\7-preview\Modules\Microsoft.PowerShell.Security\
Property(S): dir0E88D2CCD80746F7EDF99F9DD1687BAA = C:\Program Files\PowerShell\7-preview\Modules\Microsoft.PowerShell.Utility\
Property(S): dir41B4E481D523428CC40AC292A82551B8 = C:\Program Files\PowerShell\7-preview\Modules\Microsoft.WSMan.Management\
Property(S): dir49D8912EEC014CC5E115AF458DCF2CA4 = C:\Program Files\PowerShell\7-preview\Modules\PackageManagement\
Property(S): dir6C1BB471B6383C089D81F64B5DD73478 = C:\Program Files\PowerShell\7-preview\Modules\PackageManagement\coreclr\netstandard2.0\
Property(S): dir19137259174FA168E2A98C0DE7F5C4CF = C:\Program Files\PowerShell\7-preview\Modules\PackageManagement\DSCResources\
Property(S): dir32587E315FA1A97FDDB567A3286EF048 = C:\Program Files\PowerShell\7-preview\Modules\PackageManagement\DSCResources\MSFT_PackageManagement\
Property(S): dir0D916A27AF9AF236C5132EEBFBDF56FE = C:\Program Files\PowerShell\7-preview\Modules\PackageManagement\DSCResources\MSFT_PackageManagementSource\
Property(S): dirEAB721D6318D568A49AEA38030918B44 = C:\Program Files\PowerShell\7-preview\Modules\PowerShellGet\
Property(S): dir5D179693457FD105A9BF6EE22FDC2AAB = C:\Program Files\PowerShell\7-preview\Modules\PowerShellGet\DscResources\MSFT_PSModule\
Property(S): dir42FACA0A4431D6480656ABB87B1268A4 = C:\Program Files\PowerShell\7-preview\Modules\PowerShellGet\DscResources\MSFT_PSModule\en-US\
Property(S): dirDF497608BA3EF44FCA2A32F0C4D4F352 = C:\Program Files\PowerShell\7-preview\Modules\PowerShellGet\DscResources\MSFT_PSRepository\
Property(S): dir12B4128448EF2722B624A35F57971FF5 = C:\Program Files\PowerShell\7-preview\Modules\PowerShellGet\DscResources\MSFT_PSRepository\en-US\
Property(S): dirE5A887F74A82AB96B8AB7CCEF82F47B2 = C:\Program Files\PowerShell\7-preview\Modules\PowerShellGet\en-US\
Property(S): dirDB2CEFA56C315B226653C4E64FBEF160 = C:\Program Files\PowerShell\7-preview\Modules\PowerShellGet\Modules\PowerShellGet.LocalizationHelper\
Property(S): dirE01946542067D1C861CC7DF0D5BB8ACF = C:\Program Files\PowerShell\7-preview\Modules\PowerShellGet\Modules\PowerShellGet.ResourceHelper\
Property(S): dirCA5C513F14E66F0D1B7DAF9CBBE23DBD = C:\Program Files\PowerShell\7-preview\Modules\PowerShellGet\Modules\PowerShellGet.ResourceHelper\en-US\
Property(S): dir2576B73BDE30FA4D2C1C913F436EF71A = C:\Program Files\PowerShell\7-preview\Modules\PSDiagnostics\
Property(S): dir1C5AA76211D7FE86DC7DDC23EB034410 = C:\Program Files\PowerShell\7-preview\Modules\PSReadLine\
Property(S): dirB1FC05811EF7A59C452FB6DCD3FE826E = C:\Program Files\PowerShell\7-preview\Modules\PSReadLine\net462\
Property(S): dirB09703E2A790A1385FA41A6FB108B1B1 = C:\Program Files\PowerShell\7-preview\Modules\PSReadLine\net6plus\
Property(S): dir182A15E851610C69D5B4E57FFB3174FD = C:\Program Files\PowerShell\7-preview\Modules\PSReadLine\_manifest\spdx_2.2\
Property(S): dir64C4A7E6FBFA999B0B1089C3B6329808 = C:\Program Files\PowerShell\7-preview\Modules\ThreadJob\
Property(S): dirB1948D3067EC6852D865F155890B6A49 = C:\Program Files\PowerShell\7-preview\pl\
Property(S): dirA795EBE3D9A05E237E5ECB87AF8C70B2 = C:\Program Files\PowerShell\7-preview\preview\
Property(S): dir9D9F1D6767B1AD48B2122A8C111752AD = C:\Program Files\PowerShell\7-preview\pt-BR\
Property(S): dir89E392FF051220BD65ACE074648AC9F2 = C:\Program Files\PowerShell\7-preview\ref\
Property(S): dirCE7DB17C1E42197C1A13CE00FCD6442E = C:\Program Files\PowerShell\7-preview\ru\
Property(S): dir842155AEA241156657E942697D8F273E = C:\Program Files\PowerShell\7-preview\Schemas\PSMaml\
Property(S): dirDB5D004B9B9F05D25686B885C26EAB34 = C:\Program Files\PowerShell\7-preview\tr\
Property(S): dirE68CFAB1AC98CEEAB4F0562418F0F3D2 = C:\Program Files\PowerShell\7-preview\zh-Hans\
Property(S): dirF9B025A6638C5CB49BF617BB6C290F31 = C:\Program Files\PowerShell\7-preview\zh-Hant\
Property(S): WixUIRMOption = UseRM
Property(S): WIXUI_INSTALLDIR = INSTALLFOLDER
Property(S): ALLUSERS = 1
Property(S): ARPNOMODIFY = 1
Property(S): INSTALLFOLDER = C:\Program Files\PowerShell\
Property(S): ProgramFiles64Folder = C:\Program Files\
Property(S): TARGETDIR = D:\
Property(S): ProgramMenuFolder = C:\ProgramData\Microsoft\Windows\Start Menu\Programs\
Property(S): dir24CCF01988855BEFB4C3BF8108980D51 = C:\Program Files\PowerShell\7-preview\Modules\
Property(S): dirBBE36A532E108F528F909E24675FC239 = C:\Program Files\PowerShell\7-preview\Modules\PackageManagement\coreclr\
Property(S): dirC2F54593B7F8D16F7F85F04D0C6B9AB1 = C:\Program Files\PowerShell\7-preview\Modules\PowerShellGet\DscResources\
Property(S): dir2B0623C7E40F0436837D94AF7CEA2B2E = C:\Program Files\PowerShell\7-preview\Modules\PowerShellGet\Modules\
Property(S): dir83AD83F09EEC1C0E5496565C1309747B = C:\Program Files\PowerShell\7-preview\Modules\PSReadLine\_manifest\
Property(S): dir3197FD2AB1E0FD018C36EA35DF8817F3 = C:\Program Files\PowerShell\7-preview\Schemas\
Property(S): ARPPRODUCTICON = PowerShellExe.ico
Property(S): ARPHELPLINK = https://github.com/PowerShell/PowerShell
Property(S): WIXUI_EXITDIALOGOPTIONALCHECKBOXTEXT = Open PowerShell
Property(S): WixShellExecTarget = [VersionFolder]pwsh.exe
Property(S): REINSTALLMODE = dmus
Property(S): Manufacturer = Microsoft Corporation
Property(S): ProductCode = {E0C3B95F-7B7E-4DA9-B70F-C47507AE7BE7}
Property(S): ProductLanguage = 1033
Property(S): ProductVersion = <IP_ADDRESS>
Property(S): DefaultUIFont = WixUI_Font_Normal
Property(S): WixUI_Mode = InstallDir
Property(S): ErrorDialog = ErrorDlg
Property(S): SecureCustomProperties = PWRSHPLUGIN_VERSION;UNIVERSAL_C_RUNTIME_INSTALLED;WIX_DOWNGRADE_DETECTED;WIX_UPGRADE_DETECTED
Property(S): WIX_UPGRADE_DETECTED = {661AF5A8-2FC6-4BA4-A457-90FE7F8E31CC}
Property(S): MsiLogFileLocation = C:\Users\彼方\AppData\Local\Packages\Microsoft.DesktopAppInstaller_8wekyb3d8bbwe\LocalState\DiagOutputDir\WinGet-Microsoft.PowerShell.Preview.<IP_ADDRESS>-2024-07-14-23-50-51.186.log
Property(S): PackageCode = {ED3159A3-3BC6-497C-ACDE-4292CC481288}
Property(S): ProductState = -1
Property(S): PackagecodeChanging = 1
Property(S): REBOOTPROMPT = S
Property(S): REBOOT = ReallySuppress
Property(S): CURRENTDIRECTORY = C:\Users\彼方
Property(S): CLIENTUILEVEL = 2
Property(S): CLIENTPROCESSID = 2364
Property(S): VersionDatabase = 200
Property(S): MsiSystemRebootPending = 1
Property(S): VersionMsi = 5.00
Property(S): VersionNT = 603
Property(S): VersionNT64 = 603
Property(S): WindowsBuild = 9600
Property(S): ServicePackLevel = 0
Property(S): ServicePackLevelMinor = 0
Property(S): MsiNTProductType = 1
Property(S): WindowsFolder = C:\WINDOWS\
Property(S): WindowsVolume = C:\
Property(S): System64Folder = C:\WINDOWS\system32\
Property(S): SystemFolder = C:\WINDOWS\SysWOW64\
Property(S): RemoteAdminTS = 1
Property(S): TempFolder = C:\Users\彼方\AppData\Local\Temp\
Property(S): ProgramFilesFolder = C:\Program Files (x86)\
Property(S): CommonFilesFolder = C:\Program Files (x86)\Common Files\
Property(S): CommonFiles64Folder = C:\Program Files\Common Files\
Property(S): AppDataFolder = C:\Users\彼方\AppData\Roaming\
Property(S): FavoritesFolder = C:\Users\彼方\Favorites\
Property(S): NetHoodFolder = C:\Users\彼方\AppData\Roaming\Microsoft\Windows\Network Shortcuts\
Property(S): PersonalFolder = C:\Users\彼方\Documents\
Property(S): PrintHoodFolder = C:\Users\彼方\AppData\Roaming\Microsoft\Windows\Printer Shortcuts\
Property(S): RecentFolder = C:\Users\彼方\AppData\Roaming\Microsoft\Windows\Recent\
Property(S): SendToFolder = C:\Users\彼方\AppData\Roaming\Microsoft\Windows\SendTo\
Property(S): TemplateFolder = C:\ProgramData\Microsoft\Windows\Templates\
Property(S): CommonAppDataFolder = C:\ProgramData\
Property(S): LocalAppDataFolder = C:\Users\彼方\AppData\Local\
Property(S): MyPicturesFolder = C:\Users\彼方\Pictures\
Property(S): AdminToolsFolder = C:\ProgramData\Microsoft\Windows\Start Menu\Programs\Administrative Tools\
Property(S): StartupFolder = C:\ProgramData\Microsoft\Windows\Start Menu\Programs\Startup\
Property(S): StartMenuFolder = C:\ProgramData\Microsoft\Windows\Start Menu\
Property(S): DesktopFolder = C:\Users\Public\Desktop\
Property(S): FontsFolder = C:\WINDOWS\Fonts\
Property(S): GPTSupport = 1
Property(S): OLEAdvtSupport = 1
Property(S): ShellAdvtSupport = 1
Property(S): MsiAMD64 = 6
Property(S): Msix64 = 6
Property(S): Intel = 6
Property(S): PhysicalMemory = 16092
Property(S): VirtualMemory = 641
Property(S): LogonUser = 彼方
Property(S): UserSID = S-1-5-21-3440601734-2057412974-162595477-1001
Property(S): UserLanguageID = 2052
Property(S): ComputerName = XIAOMIBOOKPRO
Property(S): SystemLanguageID = 2052
Property(S): ScreenX = 1024
Property(S): ScreenY = 768
Property(S): CaptionHeight = 34
Property(S): BorderTop = 1
Property(S): BorderSide = 1
Property(S): TextHeight = 16
Property(S): TextInternalLeading = 3
Property(S): ColorBits = 32
Property(S): TTCSupport = 1
Property(S): Time = 23:51:36
Property(S): Date = 2024/7/14
Property(S): MsiNetAssemblySupport = 4.8.9032.0
Property(S): MsiWin32AssemblySupport = 6.3.26244.5000
Property(S): RedirectedDllSupport = 2
Property(S): AdminUser = 1
Property(S): MsiRunningElevated = 1
Property(S): Privileged = 1
Property(S): USERNAME = 彼方
Property(S): DATABASE = C:\WINDOWS\Installer\24e37fb5.msi
Property(S): OriginalDatabase = C:\Users\彼方\AppData\Local\Temp\WinGet\Microsoft.PowerShell.Preview.<IP_ADDRESS>\PowerShell-7.5.0-preview.3-win-x64.msi
Property(S): UILevel = 3
Property(S): MsiUIProgressOnly = 1
Property(S): MsiUIHideCancel = 1
Property(S): ACTION = INSTALL
Property(S): MIGRATE = {661AF5A8-2FC6-4BA4-A457-90FE7F8E31CC}
Property(S): ROOTDRIVE = D:\
Property(S): CostingComplete = 1
Property(S): OutOfDiskSpace = 0
Property(S): OutOfNoRbDiskSpace = 0
Property(S): PrimaryVolumeSpaceAvailable = 0
Property(S): PrimaryVolumeSpaceRequired = 0
Property(S): PrimaryVolumeSpaceRemaining = 0
Property(S): INSTALLLEVEL = 1
MSI (s) (FC:B0) [23:51:36:476]: Windows Installer installed the product. Product Name: PowerShell 7-preview-x64. Product Version: <IP_ADDRESS>. Product Language: 1033. Manufacturer: Microsoft Corporation. Installation success or error status: 1603.

=== Logging stopped: 2024/7/14/星期日  23:51:36 ===

Visuals

Might be due to https://github.com/PowerShell/PowerShell/pull/20420?

可能是由于 #20420？

It seems that they have some connections with the registy problem, but I still have no idea of why it needs the older version package to uninstall
And more important, How to fix it? The only way to uninstall is to delete relevant files manually, but it's too troublesome that I don't want to do it.

I have the same problem when trying to upgrade from 7.4.2 to 7.4.3. Both update via winget and installing a fresh MSI failed due to the following:
CustomAction  returned actual error code 1612 (note this may not be 100% accurate if translation happened inside sandbox)
MSI (s) (9C:04) [15:23:08:651]: Product: PowerShell 7-x64 -- Error 1714. The older version of PowerShell 7-x64 cannot be removed.  Contact your technical support group.  System Error 1612.

Error 1714. The older version of PowerShell 7-x64 cannot be removed.  Contact your technical support group.  System Error 1612.
Action ended 15:23:08: RemoveExistingProducts. Return value 3.
Action ended 15:23:08: INSTALL. Return value 3.

I can also not uninstall Powershell 7.4.2 via winget.

@heaths any ideas on how we can fix this?

Windows Installer has always needed the old source to uninstall: https://devblogs.microsoft.com/setup/rebuilding-the-installer-cache/ (and many others in my old blog). That package is the source of truth. If the files under the installer cache are deleted manually (e.g., CCleaner) or permissions changed such that MSI wipes out the now-untrusted folder, the packages are gone.
The new Visual Studio Installer attempts to work around this by carefully zapping (not msizap - which is woefully unsafe) product registration in very specific scenarios. Contact me internally for source.
Packages under the installer cache should never be touched. It's sort of the Achilles heal of Windows Installer.

Is it possible this is what is affecting issues in this item https://github.com/PowerShell/PowerShell/issues/23970? Issues with upgrading from 7.4.2-->7.4.3, for me it silently fails and for others winget seems to not be able to find the package at all. cc @denelon

As long as Windows Installer installed the package successfully, it caches it. But beyond what little diagnostic information is in #23970, more information is needed like Windows Installer logs of the initial attempt. Last I looked at the PowerShell MSI source as well, it does not explicitly call ResolveSource - which no package should generally - which can also cause this problem.
To enable diagnostic logging of an initial attempt in a clean machine (VM or otherwise), see https://learn.microsoft.com/windows/win32/msi/msilogging. It should be set to voicewarmupx.

Sorry for I didnt kown such thing.
If you wanna uninstall and there is no old version msi program existing, download it first at https://mygit.osfipin.com/
It may help you~


Write documentation

With almost 200 stars I think it is now time to set up some documentation. It should contain:

An explanation of the philosophy behind blackjax;
A high-level example;
A /comprehensive/ API documentation, including the elementary modules;
An example that shows how to use building blocks to eg. plot trajectories;
Notebook examples.

Closed by #155


Update documentation for recipe_extreme_index

Change documentation text, because the diagnostic (extreme_index.R) works only for daily data (the documentation said it should work for any temporal resolution).
When looking for the documentation file to change, I realized, that the documentation file is called:
recipe_combined_climate_extreme_index.html
while the recipe is called:
recipe_extreme_index.yml
Should the name of the documentation file (or the recipe) be changed as well?

Description

Closes #2921
Link to documentation: recipe_combined_climate_extreme_index.rst

Before you get started

[x] ☝ Create an issue to discuss what you are going to do

Checklist
It is the responsibility of the author to make sure the pull request is ready to review. The icons indicate whether the item will be subject to the 🛠 Technical or 🧪 Scientific review.

[x] 🛠 This pull request has a descriptive title
[x] 🛠 Documentation is available
[x] 🛠 Tests run successfully
[x] 🛠 The list of authors is up to date
[x] 🛠 All checks below this pull request were successful

To help with the number of pull requests:

🙏 We kindly ask you to review two other open pull requests in this repository

thanks very much @katjaweigel :beer: I can review this, just pls let me know when it's good to go :wrench:

Should the name of the documentation file (or the recipe) be changed as well?

Well spotted, let's change the name of the documentation page so it matches the recipe.

@katjaweigel I assigned this to the upcoming release because it seems quite a small change. But please remove it from the milestone again if you think it cannot be done.

@bouweandela Yes, thanks it is only a short text change in the documentation and a renamed file.
@valeriupredoi Thanks, the PR is ready to be reviewed.

Thanks @valeriupredoi! I checked/removed the points above (there are not many left, because only the documentation, not the code or recipe is changed).

Thanks for your contribution @katjaweigel and the review @valeriupredoi! Looks good to me too so I'm merging now 👍


windows alternate tasks

because shell commands work quite differently in windows, we could allow configuration for tasks specific to OS, such as:
[tasks.echo]
run = 'echo $FOO'
run_windows = 'echo %FOO%'

or maybe something like this:
[tasks.echo]
run = 'echo $FOO'
[tasks-windows.echo]
run = 'echo %foo%'

I think the former is what I prefer, though I can think of a few different ways to present this like maybe a tasks.os.windows key, though that would prevent anyone from having a task labeled "os" so it would have drawbacks.

I am using Mise on Windows, and I encountered some difficulties with shell command compatibility. To address the differences in shell commands across operating systems, I propose adding an os.windows/os.unix section in the TOML configuration that can override any configuration. This approach allows users to specify OS-specific settings not only for tasks but for other sections as well, such as [settings], [tools], or any other sections that may benefit from customization.
The configuration would work as follows: when an OS-specific section (e.g., [os.windows]) is provided, it will inherit properties from the main configuration, but any properties specified in the OS-specific section will override the main configuration values. This enables users to customize tasks and tools with a high degree of flexibility while keeping platform-specific variations organized and easy to manage.
Example of Proposed Structure:
Base Configuration:
[tasks.clean]
description = "Clean the build directory before building"
run = '''
    echo "Cleaning..." > clean.log
'''

OS-Specific Override:
[os.windows]
[tasks.clean]
description = "Windows-specific clean task"
shell = "PowerShell" # specify shell for Windows

[os.unix]
[tasks.clean]
shell = "bash" # specify shell for Unix

Benefits:
Consistency and Clarity: Each task can inherit tags and configurations from the base [tasks] section, while also applying OS-specific overrides as needed.
Flexibility: Beyond tasks, any other configuration sections (e.g., [settings], [tools]) can be similarly customized with platform-specific values without impacting the main configuration.
Ease of Use: This structure keeps OS-specific commands and settings consolidated, making it straightforward to understand and modify configurations for different environments.
This approach balances flexibility and clarity, allowing projects to handle platform-specific configurations more seamlessly while minimizing redundancy.
If I receive an OK with this proposal, I can implement the issue.
Thanks.

you could do this today with MISE_ENV=windows and have a mise.windows.toml file

I think it's not working correctly currently?

How is the merge done also? Do we expect the task to be fully redefined or merged?
How does one unset a value also?

I’ve opened a https://github.com/jdx/mise/pull/2967 that enables the execution of scripts on Windows. We can discuss it, and I’ll make any necessary changes.

I think it's not working correctly currently?
How is the merge done also? Do we expect the task to be fully redefined or merged? How does one unset a value also?

this bug should be fixed in #2973


XRuby Documentation for 24 Pull Requests

Create docs/24PullRequests.md describing what contributions to serve up for the party.
Part of exercism/discussions#101

What do we want to include in here?  I am assuming the "main" portion of the documentation will have the introductory/explanatory information...
So I envision this as being something of a "partial" document to be included in the larger...
## Ruby Track

Labels that are great targets for the 24 Pull Requests can be found in xruby/issues

* 24 Pull Requests
* First Timers
* Abandoned? (closed but might be good pickings!)

Brainstorming here...

@kytrinyx Any notes to add here, or should I create this file?  Last few  hours before the start.


3.0.3 when?

Hello,
On v3/master branch are already a lot of changes which e.g. fix memory leaks.
I suggest releasing new versions more often to have a chance to use less buggy version on production. Now I need to restart Nginx instances every day because of memory leaks...
So my question is - when 3.0.3? :)

Hi @avkarenow,
Indeed, we had a lot of contributions since our last release in April. All contributions are detailed here:
https://github.com/SpiderLabs/ModSecurity/blob/738e328723e16d5472495993e84f2a22d306975e/CHANGES#L4-L81
There are too many pull requests there are still open (https://github.com/SpiderLabs/ModSecurity/pulls). We are closing those in order to cook a new release :)
Also, there are some issues that we are willing to close before release:
https://github.com/SpiderLabs/ModSecurity/milestone/12
For 3.0.4 we will try to target for 3 months after 3.0.3.
In the mean while you can use the v3/master branch.
Thanks for asking :)


React Fragments have UNDEFINED types in snapshots

Do you want to request a feature or report a bug?
Bug
What is the current behavior?
When using a snapshot test with a React Fragment The snapshot has UNDEFINED as node types.
If the current behavior is a bug, please provide the steps to reproduce and
either a repl.it demo through https://repl.it/languages/jest or a minimal
repository on GitHub that we can yarn install and yarn test.
For example:
import React from 'react';

it('doesnt render Unknown for React Fragments', () => {
  expect(
    <React.Fragment>
      Hello World
    </React.Fragment>,
  ).toMatchSnapshot();
});

Generates this snapshot:
// Jest Snapshot v1, https://goo.gl/fbAQLP

exports[`doesnt render Unknown for React Fragments 1`] = `
<UNDEFINED>

    Hello World

</UNDEFINED>
`;

Here is an example repo: https://github.com/adriantoine/jest-fragment-bug (note that it's not using Enzyme or enzyme-to-json, only Jest).
What is the expected behavior?
It renders the Fragment node with the <React.Fragment>...</React.Fragment> type or an empty node type as it is possible with Babel (<>...</>).
Please provide your exact Jest configuration
It is in the example repo above and it is reproduceable with any config.
Run npx envinfo --preset jest in your project directory and paste the
results here
  System:
    OS: macOS High Sierra 10.13.1
    CPU: x64 Intel(R) Core(TM) i7-6920HQ CPU @ 2.90GHz
  Binaries:
    Node: 9.7.1
    Yarn: 1.5.1
    npm: 5.7.1
  npmPackages:
    jest:
      wanted: ^22.4.2
      installed: 22.4.2

If you think that is an issue, I'm happy to look at a fix in pretty-format although we need to agree if it should be rendered as <React.Fragment>...</React.Fragment> or <>...</>.
Thanks!

You need to actually render it.
diff --git c/__tests__/__snapshots__/index.js.snap w/__tests__/__snapshots__/index.js.snap
index efb0fba..6752fd8 100644
--- c/__tests__/__snapshots__/index.js.snap
+++ w/__tests__/__snapshots__/index.js.snap
@@ -1,9 +1,7 @@
 // Jest Snapshot v1, https://goo.gl/fbAQLP

 exports[`doesnt render Unknown for React Fragments 1`] = `
-<UNDEFINED>
-
-    Hello World
-
-</UNDEFINED>
+
+  Hello World
+
 `;
diff --git c/__tests__/index.js w/__tests__/index.js
index d6fd98b..5d97f53 100644
--- c/__tests__/index.js
+++ w/__tests__/index.js
@@ -1,9 +1,12 @@
 import React from 'react';
+import TestRenderer from 'react-test-renderer';

 it('doesnt render Unknown for React Fragments', () => {
   expect(
-    <React.Fragment>
-      Hello World
-    </React.Fragment>,
+    TestRenderer.create(
+      <React.Fragment>
+        Hello World
+      </React.Fragment>,
+    ).toJSON(),
   ).toMatchSnapshot();
 });
diff --git c/package.json w/package.json
index a421a45..bcabcb6 100644
--- c/package.json
+++ w/package.json
@@ -7,7 +7,8 @@
     "babel-preset-env": "^1.6.1",
     "babel-preset-react": "^6.24.1",
     "jest": "^22.4.2",
-    "react": "^16.2.0"
+    "react": "^16.2.0",
+    "react-test-renderer": "^16.2.0"
   },
   "scripts": {
     "test": "jest"
diff --git c/yarn.lock w/yarn.lock
index 8d1eb7e..9a51f56 100644
--- c/yarn.lock
+++ w/yarn.lock
@@ -2936,6 +2936,14<EMAIL_ADDRESS>     minimist "^1.2.0"
     strip-json-comments "~2.0.1"

<EMAIL_ADDRESS>+  version "16.2.0"
+  resolved "https://registry.yarnpkg.com/react-test-renderer/-/react-test-renderer-16.2.0.tgz#bddf259a6b8fcd8555f012afc8eacc238872a211"
+  dependencies:
+    fbjs "^0.8.16"
+    object-assign "^4.1.1"
+    prop-types "^15.6.0"
+
<EMAIL_ADDRESS>   version "16.2.0"
   resolved "https://registry.yarnpkg.com/react/-/react-16.2.0.tgz#a31bd2dab89bff65d42134fa187f24d054c273ba"

As a fragment is never rendered, it won't show up in the snapshot (stringified toJSON is { type: 'span', props: {}, children: [ 'Hello World' ] }).
If you think it should, open up an issue at the react repo.

Adding another child to the fragment results in Array:
diff --git i/__tests__/__snapshots__/index.js.snap w/__tests__/__snapshots__/index.js.snap
index 6752fd8..d7bbd2a 100644
--- i/__tests__/__snapshots__/index.js.snap
+++ w/__tests__/__snapshots__/index.js.snap
@@ -1,7 +1,12 @@
 // Jest Snapshot v1, https://goo.gl/fbAQLP

 exports[`doesnt render Unknown for React Fragments 1`] = `
-
-  Hello World
-
+Array [
+
+    Hello World
+  ,
+
+    Hello World
+  ,
+]
 `;
diff --git i/__tests__/index.js w/__tests__/index.js
index 5d97f53..e901901 100644
--- i/__tests__/index.js
+++ w/__tests__/index.js
@@ -6,6 +6,7 @@ it('doesnt render Unknown for React Fragments', () => {
     TestRenderer.create(
       <React.Fragment>
         Hello World
+        Hello World
       </React.Fragment>,
     ).toJSON(),
   ).toMatchSnapshot();

Not the most optimal output

I'm seeing this as well:
Test:
const Test = () => <>x</>;
expect(ReactTestUtils.createRenderer().render(<Test />)).toMatchSnapshot();

Produces the following snapshot:
<UNDEFINED>
  x
</UNDEFINED>

cc @cpojer (via internal discussion https://fburl.com/rmhf5kf8)

@kassens do we support the intermediate representation .render returns? All examples I can find calls toJSON() on it

@SimenB As far as I can tell it works for everything else. Seems like the only thing missing is for the code that prints UNDEFINED here to drop that.

Fair enough 🙂

Fix should be here: https://github.com/facebook/jest/blob/84b17fb59c1d9fd7f964b5f2bfd9d7e2b898f89a/packages/pretty-format/src/plugins/react_element.js#L34-L42

Fix in flight, see above PR

Thank you for taking care of this!

No sweat, I checked your repo against the PR and it fixes it:


[stable/rabbitmq] Reduce readiness/liveness probes frequency

Signed-off-by: juan131<EMAIL_ADDRESS>What this PR does / why we need it:
Currently, readiness/liveness probes are executed every 5 seconds which is causing high CPU usage on certain clusters. This PR increases the timeoutSeconds & periodSeconds of these probes to reduce the frequency so they reduce the impact on the cluster performance.
Which issue this PR fixes

fixes #3855

Checklist
[Place an '[x]' (no spaces) in all applicable fields. Please remove unrelated fields.]

[x] DCO signed
[x] Chart Version bumped
[x] Variables are documented in the README.md

/assign @tompizmor @desaintmartin


Incremental jobs w/ more than 2 inputs hang, "failed to deserialize parent hashtree"

Behavior
Incremental jobs with 1.5.0-RC1+ hang when they have more than 2 inputs.  This may or may not be related to the numbers of inputs, but pipelines with 1 or 2 inputs and incremental true seem to work as expected.
For example, take this pipeline:
{
    "transform": {
        "image": "agispof/simpletest:master",
        "cmd": [
            "python",
            "/root/service.py",
            "--input_dir",
            "/pfs/a_times_x_squared",
            "--input_dir_2",
            "/pfs/b_times_x",
            "-c",
            "/pfs/config/configurations/a_times_x_squared_plus_b_times_x/a_times_x_squared_plus_b_times_x.json",
            "--output_dir",
            "/pfs/out"
        ]
    },
    "pipeline": {
        "name": "_test_w_a_times_x_squared_plus_b_times_x"
    },
    "input": {
        "cross": [
            {
                "atom": {
                    "repo": "_test_w_a_times_x_squared",
                    "branch": "master",
                    "glob": "/",
                    "name": "a_times_x_squared"
                }
            },
            {
                "atom": {
                    "repo": "_test_w_b_times_x",
                    "branch": "master",
                    "glob": "/",
                    "name": "b_times_x"
                }
            },
            {
                "atom": {
                    "repo": "test_w",
                    "branch": "master",
                    "glob": "/configurations/a_times_x_squared_plus_b_times_x/*",
                    "name": "config"
                }
            }
        ]
    },
    "incremental": true
}

Other incremental pipeline run fine to completion, while this one just stays "running":
➜  keeps_running_bug (master) ✗ pachctl list-job
ID                                   OUTPUT COMMIT                                              STARTED                DURATION           RESTART PROGRESS STATE
713d7605-d090-4b89-b5eb-27dc43ae69c3 _test_w_a_times_x_squared_plus_b_times_x/-                 Less than a second ago -                  0       0 / 1    running
0af35848-d3fe-4b84-859b-1d34ac783ab3 _test_w_b_times_x/427eefedcd38476da0b136e777f0071f         23 seconds ago         Less than a second 0       1 / 1    success
0fcc48da-cd2e-4427-a704-97e305f1d55c _test_w_b_times_x/38527679ba974d09b572f11d4a5ad75e         23 seconds ago         Less than a second 0       0 / 0    success
535e1e37-b420-414a-8c64-3a1a32af5a1f _test_w_a_times_x_squared/79d8d0f2edc6477a94ac1bf1708d3fc7 33 seconds ago         Less than a second 0       1 / 1    success
40d74061-1e4b-46f0-99f5-149cb83c7900 _test_w_a_times_x_squared/50062271ec014247a35a6f94a0daa698 33 seconds ago         Less than a second 0       0 / 0    success
596cde58-a4c7-4c89-9329-f14341397388 _test_w_x_squared/88cb9ad6961743e9ad72163896955627         58 seconds ago         Less than a second 0       1 / 1    success
6ffdbe8f-fcff-451f-bc9b-4f125e2adc84 _test_w_x_squared/a5fe75cb79ae4292b1a7c205e01635da         58 seconds ago         Less than a second 0       0 / 0    success

The job doesn't output any regular logs, but the raw logs show a bunch of errors like this:
{"pipelineName":"_test_w_a_times_x_squared_plus_b_times_x","pipelineId":"a9a4dedde75a40dc9ecfca96f122e458","jobId":"713d7605-d090-4b89-b5eb-27dc43ae69c3","workerId":"pipeline--test-w-a-times-x-squared-plus-b-times-x-v1-zfkml","data":[{"hash":"sfo+HobJfM2lrmAycfCax9BAYhIq/aFiTfvN786r4Ho="},{"hash":"lIjGS6WOVXnESK142a0Sx8/SxkFRXCUsb5Y2WX73RCY="},{"path":"/configurations/a_times_x_squared_plus_b_times_x/a_times_x_squared_plus_b_times_x.json","hash":"bA0epPtniVnux0qNsYp5GXe9tPyYmsS6c63Q8tvnzP4="}],"ts":"2017-06-27T16:23:24.614595078Z","message":"process call finished - request: job_id:\"713d7605-d090-4b89-b5eb-27dc43ae69c3\" data:\u003cfile_info:\u003cfile:\u003ccommit:\u003crepo:\u003cname:\"_test_w_a_times_x_squared\" \u003e id:\"79d8d0f2edc6477a94ac1bf1708d3fc7\" \u003e \u003e file_type:DIR size_bytes:607 hash:\"\\261\\372\u003e\\036\\206\\311|\\315\\245\\256`2q\\360\\232\\307\\320@b\\022*\\375\\241bM\\373\\315\\357\\316\\253\\340z\" \u003e parent_commit:\u003crepo:\u003cname:\"_test_w_a_times_x_squared\" \u003e id:\"50062271ec014247a35a6f94a0daa698\" \u003e name:\"a_times_x_squared\" branch:\"master\" \u003e data:\u003cfile_info:\u003cfile:\u003ccommit:\u003crepo:\u003cname:\"_test_w_b_times_x\" \u003e id:\"427eefedcd38476da0b136e777f0071f\" \u003e \u003e file_type:DIR size_bytes:474 hash:\"\\224\\210\\306K\\245\\216Uy\\304H\\255x\\331\\255\\022\\307\\317\\322\\306AQ\\\\%,o\\2266Y~\\367D\u0026\" \u003e name:\"b_times_x\" branch:\"master\" \u003e data:\u003cfile_info:\u003cfile:\u003ccommit:\u003crepo:\u003cname:\"test_w\" \u003e id:\"58671ff6418b47988f763b19a9b01f0f\" \u003e path:\"/configurations/a_times_x_squared_plus_b_times_x/a_times_x_squared_plus_b_times_x.json\" \u003e file_type:FILE size_bytes:24 hash:\"l\\r\\036\\244\\373g\\211Y\\356\\307J\\215\\261\\212y\\031w\\275\\264\\374\\230\\232\\304\\272s\\255\\320\\362\\333\\347\\314\\376\" \u003e name:\"config\" branch:\"master\" \u003e parent_output:\u003cname:\"b9896f72fbb55de9e58537766ed6ba85aac6696c12456285ef0e4aad163b18b4883f\" \u003e , response: \u003cnil\u003e, err failed to deserialize parent hashtree: unsupported HashTreeProto version 0, duration: 65.078081ms"}

I checked to make sure that the data is there for the specific commits on which the pipeline was running.
To Reproduce
Follow the instructions here: https://github.com/abhitopia/pachy_bug/tree/master/keeps_running_bug

I can confirm that the problem is not limited to more than 2 inputs. I am having same issues with following pipeline as well -
 9ee906ca-24b3-4c61-9c84-9b8244cee403
ID: 9ee906ca-24b3-4c61-9c84-9b8244cee403
Pipeline: _test_workflow_a_times_x_squared
Started: 26 minutes ago
State: running
Progress: 0 / 1
Worker Status:
WORKER              JOB                 DATUM               STARTED
Restarts: 0
ParallelismSpec: <nil>

Input:
{
  "cross": [
    {
      "atom": {
        "name": "config",
        "repo": "test_workflow",
        "branch": "master",
        "commit": "342da2c59605439088c7bbeabe95e353",
        "glob": "/configurations/a_times_x_squared/*"
      }
    },
    {
      "atom": {
        "name": "x_squared",
        "repo": "_test_workflow_x_squared",
        "branch": "master",
        "commit": "7ed9bd89d3d84e9d8620441a6d92c10e",
        "glob": "/"
      }
    }
  ]
}

Transform:
{
  "image": "agispof/simpletest:master",
  "cmd": [
    "python",
    "/root/service.py",
    "--input_dir",
    "/pfs/x_squared",
    "-c",
    "/pfs/config/configurations/a_times_x_squared/a_times_x_squared.json",
    "--output_dir",
    "/pfs/out"
  ]
}

stale


Adding support for Elder Maul

Cannot be accepted until runelite accepts https://github.com/runelite/runelite/pull/17895/commits

This is now good to be merged as the PR that it depends on was merged https://github.com/runelite/runelite/pull/17895

@capslock13 mentioning you here as you've done these PRs in the past. Just wanted to get your eyes on it to see if you think it's good as well


feature request: background image

Hi, I/we use spectre on like 6 projects.  ( eg https://www.ubaycap.com )
It be nice to have a built in background image with full bleed.
Cheers.

IMHO This is indeed a very nice feature for a modern CSS framework


python3Packages.protonvpn-nm-lib: 3.10.0 -> 3.11.0

Description of changes
Contains fix for protonvpn_reconnect.service generated after using any of the ProtonVPN services.

Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
22.11 Release Notes (or backporting 22.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module
[ ] (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes

[x] Fits CONTRIBUTING.md.

Backporting as the version from 22.05 does not work because of dbus dependencies

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:
https://discourse.nixos.org/t/protonvpn-no-module-named-dbus/19651/4

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:
https://discourse.nixos.org/t/prs-ready-for-review/3032/1046

@ofborg build python3Packages.protonvpn-nm-lib


firebase_core: Failed to Build iOS App - Firebase Module Redefinition

Is there an existing issue for this?

[x] I have searched the existing issues.

Which plugins are affected?
Core
Which platforms are affected?
iOS
Description
Description
When attempting to build the iOS app, the build process fails with errors related to a redefinition of the Firebase module and issues emitting a precompiled header for the bridging header file. This prevents the app from being built and launched on the simulator.
Environment

Xcode Version: 16.2
macOS Version: Sonoma 14.5
Flutter Version: 3.27.1
Firebase SDK Version: 3.9.0
iOS Deployment Target: 18.0

Expected Behavior
The app should build successfully without errors and launch on the simulator.
Observed Behavior
The following errors occur during the build process:
Error (Xcode): redefinition of module 'Firebase'
/Users/xxx/code/foo/my_app/ios/Pods/Firebase/CoreOnly/Sources/module.modulemap:0:7

Error (Xcode): failed to emit precompiled header '/Users/xxx/Library/Developer/Xcode/DerivedData/Runner-elopyndyahddlwghimmamhrolobf/Build/Intermediates.noindex/PrecompiledHeaders/Runner-Bridging-Header-swift_25AUGCNBX54WL-clang_3C7LSRA2V4KFR.pch' for bridging header '/Users/rahmitufanoglu/code/studylife/studylife_app/ios/Runner/Runner-Bridging-Header.h'

Additional Context

The issue seems to be related to the integration of Firebase and possibly duplicate definitions or module conflicts.
The error with the precompiled header could indicate issues with the bridging header file or project settings.

Workarounds Tried

Cleaned the build folder (Cmd + Shift + K in Xcode).
Deleted the DerivedData folder and rebuilt.
Reinstalled CocoaPods dependencies with pod deintegrate && pod install.
Verified the Runner-Bridging-Header.h file for correctness.
Ensured all Firebase dependencies are up-to-date.

Request for Help

Guidance on resolving the Firebase module redefinition error.
Steps to troubleshoot the precompiled header issue.
Any necessary updates or changes to the project's Podfile, bridging header, or other configurations.

Attachments

Podfile
Relevant parts of Runner-Bridging-Header.h
Screenshot or logs (if applicable).

Feel free to customize further with your specific environment details or any additional troubleshooting steps you’ve tried!
Reproducing the issue
Create a new Flutter project (v. 3.27.1) and integrate firebase_core 3.9.0
Firebase Core version
3.9.0
Flutter Version
3.27.1
Relevant Log Output

Flutter dependencies

Expand Flutter dependencies snippet

Replace this line with the contents of your `flutter pub deps -- --style=compact`.

Additional context and comments
No response

Hi @RahmiTufanoglu, I’m unable to reproduce this issue on my end. Could you try the potential solutions mentioned in this similar issue to see if they resolve it for you?

@SelaseKay The solution in the linked issue did not work. I am using the swift package manager.


Possible note area per device

fqdn/devices/1
Is there space to extend the db to include a possible text area for notes..
"user has iPhone, running IOS 1.2.3, installed wg app from Apple Store.."
(for users with multiple devices this seems to make more sense.. )
Possibly fqdn/devices/1/edit being able to change the Name and being able to append -iphone-xsmax or something was the intent..
Is there a max length on the Name field?
Thank you in advance..

Great suggestion. Would a description field suit this use case?


net: app: fix packet family check on incoming encrypted packets

Commit 753daa65f918 ("net: pkt: Compute TX payload data length")
removed the default packet setup on incoming packets belonging
to the rx_pkt pool.  We were previously setting the packet family
during this processing.
In _net_app_ssl_mainloop() we are setting the IP header length based
on a packet family check.  This is now failing as packet family has
not been set.
Let's set the packet family prior to those checks.
Signed-off-by: Michael Scott<EMAIL_ADDRESS>

NOTE: This fixes DTLS on LwM2M and is required for: https://github.com/zephyrproject-rtos/zephyr/pull/5267

@pfl : FYI.

@pfl Can you take a look at the new change to this patch?
Before the MTU changes here: https://github.com/zephyrproject-rtos/zephyr/commit/753daa65f9181b8ea89a1597b7aaa30a45910f44#diff-36fffa10c9a7f7bf15b267b17920b155
net_pkt_append() had it's own calculation for how much data could be appended to the buffer when not using TCP:
struct net_if iface = net_context_get_iface(ctx);
max_len = net_if_get_mtu(iface);
/ Optimize for number of jumps in the code ("if"
* instead of "if/else").
*/
max_len -= NET_IPV4TCPH_LEN;
if (net_context_get_family(ctx) != AF_INET) {
max_len -= NET_IPV6TCPH_LEN - NET_IPV4TCPH_LEN;
}
How would you like me to handle this now?  We're using the pkt->data_len value (which is currently not set for incoming packets).
Currently, I dummied in 0x1000 to confirm that this was causing the issues I was seeing with this patch.

@pfl after looking through the older code and comparing to the newer code, I have to ask why we're filtering on "if (pkt && slab != &rx_pkts) {"?
What about the MTU code doesn't apply to handling rx packets?

How would you like me to handle this now? We're using the pkt->data_len value (which is currently not set for incoming packets).

For incoming packets the "MTU" or actually packet length in that case is known only on packet reception. When acquiring a net_pkt or similar to hold the RX data, we don't have a clue yet, as the incoming packet length is not known. @jukkar mentioned that the RX path will figure it out. It would of course be nice to fill in this value to pkt->data_len, but it's not really needed as there is nothing we can do with or for the MTU except accept the fact that a finite amount of bytes were sent by the sender.

New version of this patch posted (and rebased on today's master):
I split the behavior into 2 sections:

Re-add the removed portion of the default packet setup setting net_context, iface and family in net_pkt.c
Use the incoming request_buf len to set the pkt->data_len appropriately so that net_pkt_append can be called w/o error.

@mike-scott, First of all, sorry for the delay with looking into this.

We're using the pkt->data_len value (which is currently not set for incoming packets).

Can you please elaborate on that?
And given that you're likely on holidays (Merry Xmas/Happy NY), let me theorize myself: You shouldn't be using pkt->data_len, it's an internal pkt variable. Also, it's valid only for TX pkt's (it's naming in https://github.com/zephyrproject-rtos/zephyr/commit/753daa65f9181b8ea89a1597b7aaa30a45910f44 is unfortunate, and it should be renamed, actually, I get an idea to make it union with some existing member, which is vice-versa used only for RX pkts.)

So, 2nd commit mesage:

net: net_app: set packet data_len on incoming packets

This fixes a bug when calling net_pkt_append[_all] which uses
pkt->data_len as part of the maximum packet length calculation
when the net_context is set.

The only explanation is that you receive incoming packet, parse it, then try to reuse for sending. Can you please confirm that? And maybe it's not "you" but "net_app code, maybe specifically TLS-related code". Can you confirm that too? I'd say that's a problem, because RX vs TX packets belong to different pools. Even if that works w/o problems, that's somehow undermines the idea of having separate pools (effectively, there're separate pools for benefits they give (e.g. avoid RX-by-TX and vice-versa starvation), but "reuse" approach effectively works it around, killing the benefits it gives (e.g. there still can be starvation, TX will hog on RX buffers). Why do we have separate pools at all then?

I'm +1 on the 1st commit, the same as @pfl.


"Not started" status not documented

Under the section "Check processing status for a rule" it mentions "The following status messages can be shown for Dynamic rule processing status:"
It does however not include "Not started", which my newly created dynamic group is now in:

It would be good to know how long I should wait until it processes.

Document Details
⚠ Do not edit this section. It is required for learn.microsoft.com ➟ GitHub issue linking.

ID: 24c25353-cfb3-811c-a970-2a04678eff6e
Version Independent ID: 145d404a-f7ed-17f6-79a6-0204ab7ee70b
Content: Create or edit a dynamic group and get status - Microsoft Entra ID
Content Source: docs/identity/users/groups-create-rule.md
Service: entra-id
Sub-service: users
GitHub Login: @barclayn
Microsoft Alias: barclayn

@jepperaskdk
Thanks for your feedback! We will investigate and update as appropriate.

@jepperaskdk
Thank you for bringing this to our attention.
I've delegated this to content author, who will review it and offer their insightful opinions.

@jepperaskdk thank you for pointing this out. We have created a work item to track this internally and make the necessary updates. #please-close


2.3.0: test suite is failing

============================================================================
Testsuite summary for OpenEXR 2.3.0
============================================================================
# TOTAL: 1
# PASS:  0
# SKIP:  0
# XFAIL: 0
# FAIL:  1
# XPASS: 0
# ERROR: 0
============================================================================
See IlmImfTest/test-suite.log
============================================================================

test-suite.log

<mock-chroot> sh-5.0# ./IlmImfTest/.libs/lt-IlmImfTest testMultiPartSharedAttributes
tempDir = /var/tmp/IlmImfTest_ORZEXUAZ

=======
Running testMultiPartSharedAttributes
Testing multi part APIs : shared attributes, header...
/usr/include/c++/9/bits/stl_vector.h:1060: std::vector<_Tp, _Alloc>::const_reference std::vector<_Tp, _Alloc>::operator[](std::vector<_Tp, _Alloc>::size_type) const [with _Tp = Imf_2_3::Header; _Alloc = std::allocator<Imf_2_3::Header>; std::vector<_Tp, _Alloc>::const_reference = const Imf_2_3::Header&; std::vector<_Tp, _Alloc>::size_type = long unsigned int]: Assertion '__builtin_expect(__n < this->size(), true)' failed.
Aborted (core dumped)

should be the problem

(gdb) where
#0  0x00007ffff74f73b8 in raise () from /lib64/libc.so.6
#1  0x00007ffff74d800c in abort () from /lib64/libc.so.6
#2  0x0000000100030400 in std::__replacement_assert (__file=<optimized out>, __line=<optimized out>, __function=<optimized out>, __condition=<optimized out>)
    at /usr/include/c++/9/ppc64le-redhat-linux/bits/c++config.h:463
#3  0x00000001000a7dc0 in std::vector<Imf_2_3::Header, std::allocator<Imf_2_3::Header> >::operator[] (__n=0, this=<optimized out>) at /usr/include/c++/9/bits/locale_facets.h:877
#4  (anonymous namespace)::testMultiPartOutputFileForExpectedFailure (headers=..., fn="/var/tmp/IlmImfTest_DKABSQOC/imf_test_multipart_shared_attrs.exr",
    failMessage="Header : empty header list passed") at testMultiPartSharedAttributes.cpp:153
#5  0x00000001000a7f68 in (anonymous namespace)::testHeaders (fn="/var/tmp/IlmImfTest_DKABSQOC/imf_test_multipart_shared_attrs.exr") at /usr/include/c++/9/bits/char_traits.h:300
#6  0x00000001000aa5b8 in testMultiPartSharedAttributes (tempDir=...) at testMultiPartSharedAttributes.cpp:512
#7  0x0000000100022c0c in main (argc=<optimized out>, argv=0x7ffffffff3f8) at main.cpp:197

It appears that the STL std::vector [] operator for array indexing aborts (or throws an exception) when accessing an empty array. This may be newer behaviour than I've seen. In my tests, the address of the 0th item of an empty vector gives no error,  an returns an undefined pointer, which is harmless because the OpenEXR library ignores the pointer with an empty header list.
If we can confirm that is the cause of the problem, the test should be changed to pass NULL when headers.size() ==0. However, changing a test to avoid a crash kinda weakens the point of having a test.

MSVC now also barfs on taking the address of the 0th element of an empty vector.

Ah, in that case I'll update the test to pass NULL and see if that gets us further

I believe this is now fixed: if anyone with gcc9 on ppc64le or similar and can confirm, we'll close out the issue

Looks good to me, i686, x86_64 and ppc64le pass all tests now (all Fedora Rawhide with gcc9). While armv7, aarch64 and s390x still expose another test failure(s), reports to follow.

Thanks for checking. I'll close this and stand by for new issue(s)

Thanks for checking. I'll close this and stand by for new issue(s)

issues opened, I'll also try to run all the subtest individually, right now it could be only the first failure found, not all. Please be patient when waiting for the details.


Include backpack contents

Right now backpack contents are ignored when decomposing and tracking recipes. Make it so when the user opens their backpack, the contents are stored in the metadata to be referenced later.

Resolved in v0.3.1


UIApplication.endBackgroundTask(_:) Risk

Describe the bug
[BackgroundTask] Background Task 1 ("Called by Flurry_iOS_SDK, from -[FlurryDataSenderBase registerNewTask:]"), was created over 30 seconds ago. In applications running in the background, this creates a risk of termination. Remember to call UIApplication.endBackgroundTask(_:) for your task in a timely manner to avoid this.
This Bug is About
Please choose the closest item by replacing [ ] with [x].

[ ] Integration
[x] Analytics
[ ] Ads
[ ] Messaging/Push
[ ] IAP
[ ] Remote Configuration
[ ] Flurry Website/Dashboard
[ ] Other

Platform
Please choose the platform(s) that you are having the issue by replacing [ ] with [x].

[x] iOS
[ ] tvOS
[ ] WatchOS

Environment
Please tell us the versions of Flurry SDK, XCode, and iOS you are using.

Flurry SDK: pod 'Flurry-iOS-SDK/FlurrySDK', '~> 11.1.1'
XCode:Version 12.0 (12A7209)
iOS:14.0

To Reproduce
Steps to reproduce the behavior:

Turn app to background sometimes
Turn app to foreground
The XCode console will report this warnning

Additional context
Are you using Flurry Push/Messaging? No
(iOS) Are you using CocoaPods or manual binary integration? We use CocoaPods

@StartingZhou we made the fix for this issue and it will be out with the next GA release in March.

@StartingZhou Please upgrade to v11.2.1 for the fix of this risk

We just had updated the flurry version to v11.2.1 last year, and for now this issue no more appear, thank you very much


Documented the process of loading data into a running preferences server

Here's the promised small "how to" process made for this August demo.
Let me know if you have any comments.

@amatas and @mrtyler thanks for your feedback, this is ready again for another round of review.

LGTM. Thanks, Javi!
Alfredo, feel free to merge this when you're satisfied with Javi's responses to your comments.


SAK-34036 - Update CKEditor to 4.9.1 and update all plugins

I'm putting WIP on this one. Looks like the elfinder either needs to be upgraded or we may need to wait on CKEditor 4.9.1
I'm looking at https://github.com/ckeditor/ckeditor-dev/issues/1835 for the ckeditor possible issue and
https://github.com/Studio-42/elFinder/issues/2070 for elfinder
It may be both, stay tuned!

They pushed out a 4.9.1 release today, no webjar yet.

CKEditor 4.9.1 up, currently waiting on image2 4.9.1 plugin, maybe that will be up tomorrow.
https://mvnrepository.com/artifact/org.sakaiproject.webjars/ckeditor-image2


Realistic provisioning minimalization and speedup.

@sk4zuzu if we are talking about managed clusters, we do not need this task I believe. What do you think?

@mkyc correct :+1:, I don't think running full epicli apply is needed here if we are going to use AKS/EKS, so we probably don't need such optimizations that much.

Ok, so closing it as not relevant in current plan.


Colab example for bangla text classification with tf-hub

This colab shows how to use embedding exporter to create text embedding module from pretrained word vectors and use the resulting module for text classification. Language used here is Bangla for demonstrating usage of TF-Hub with non-English languages.
Colab link : https://colab.research.google.com/drive/19mIB6o7623KRVq45ciG8xLozrjOO_1Yq

Thanks Mayeesha, looks very nice!

Thanks for the contribution! Merged in https://github.com/tensorflow/hub/commit/241577b2e614e8f47b8cc1388e837d52b5022647.


List all k8s debuggable containers

What

User can list debuggable container across k8s pods
Runs make fmt against syscall files

Why

This is a precursor step to pick which container to debug within the TUI. Also valuable in its own right.

How Tested
Screencast from 2024-11-07 15-20-10.webm

@eharris128 merging... do you mind adding the enhancements in a new PR

@eharris128 merging... do you mind adding the enhancements in a new PR

Yes for sure. I mentioned above but --list-debuggable-pod-containers would be a flag requiring a user to pass in a --pod $name as well yes?

@eharris128 merging... do you mind adding the enhancements in a new PR

Yes for sure. I mentioned above but --list-debuggable-pod-containers would be a flag requiring a user to pass in a --pod $name as well yes?

It doesn't need to be an explicit pod parameter. It can be the default pod name based on the logic that's there already where we "ensure" the pod name. If a pod flag is not specified we pick the first available pod.

We already have the pod, podName, err := ensurePod(ctx, api, nsName, commandParams.TargetPod) line that takes care of picking up / resolving the pod name. Need to use that podName when we call listK8sDebuggableContainers()

Yup makes sense. I will add in a --list-debuggable-pod-containers flag that will do just this.


Overlap halo exchange with process interior computations

Hi everyone,
I was wondering why there is no API for asynchronous halo exchange operations (i.e. ExchangeFaceNbrDataAsync()).
Let us take for example the Kelly error indicator. Here the implementation is on a high level
Compute local fluxes
Loop over interior faces
    Compute interior face contribution from local flux
Flux halo exchange
Loop over shared faces
    Compute shared face contribution from halo flux

Where on many problems a significant amount of time is spend in the halo exchange (which seems to come from blocking, caused by a non-balanced number of faces per process due to SFC-based partitioning).
   Method                                          Min          Max          Average   Percent
    ComputeEstimates                            7.378202      8.495196      7.936699  5.811934
      Compute Flux                              0.700778      1.784863      1.242821  0.910100
      Compute Interior Contribution             1.527185      3.961211      2.744198  2.009538
      Compute Shared Contribution               0.572313      4.205808      2.389060  1.749476
        MPI_Isend                               0.090345      0.096088      0.093216  0.068261
        MPI_Irecv                               0.037915      0.039215      0.038565  0.028241
        MPI_Waitall                             0.107493      3.755939      1.931716  1.414569
      MPI_Allreduce                             0.030123      0.333609      0.181866  0.133178
      MPI_Scan                                  0.014639      1.185199      0.599919  0.439312
      MPI_Bcast                                 0.008716      0.019208      0.013962  0.010224
      MPI_Recv                                  0.000355      0.012049      0.006202  0.004542
      MPI_Waitall                               0.003129      0.003398      0.003263  0.002390
      MPI_Isend                                 0.006833      0.014329      0.010581  0.007748
      MPI_Irecv                                 0.006353      0.006575      0.006464  0.004733
      MPI_Iprobe                                0.030429      0.034960      0.032695  0.023942
      MPI_Testall                               0.006042      0.017356      0.011699  0.008567
      MPI_Send                                  0.014568      0.014568      0.014568  0.005334
      MPI_Test                                  0.014372      0.014372      0.014372  0.005262
      MPI_Wait                                  0.006091      0.006091      0.006091  0.002230

where the MPI_Waitall is https://github.com/mfem/mfem/blob/a37c8e3acbfc5b7b2eba39511a6d0d86cbba0f88/fem/pgridfunc.cpp#L266-L267 . I know this is not the full story here, but I assume that a good chunk of the performance hit can be explained this way.
 My idea is to split ParGridFunction::ExchangeFaceNbrData into 2 functions
ParGridFunction::AsyncExchangeFaceNbrDataStart
ParGridFunction::AsyncExchangeFaceNbrDataEnd
or that AsyncExchangeFaceNbrDataStart returns some object coming from some sync helper class, such that users calls some function, e.g. "WaitForSync", manually (and on destruction this one is called automatically).
Is there anything preventing us from this kind of overlapped computation that I am missing here? If this is too error prone for the user facing part, can we agree on having an internal API for this?

Hi @termi-official,
I think what you propose here should be possible and it won't be too hard to implement. To use this asynchronous communication in the library will require some changes too. If you plan to use the async exchange version directly in your code, the second part can be implemented later, I suppose.
Do you want to propose a PR to add the async exchange, or do you prefer we do that?

Hi @v-dobrev ! I can try to pick this up later, as I do not have the time right now to tackle these kinds of optimizations anytime soon (but they are on my TODO list). If introducing async operations into MFEM becomes priority on your end, then I don't want to be the bottleneck either.


Add Autowiring diagnostic routines

These routines are intended to be used to diagnose Autowiring issues from a debugger that is capable of evaluating function calls.  None of these routines make stateful changes to the system.  These methods assume that the debugger will run these functions from the thread context current in the debugger.

@gtremper I might need your help with this one, I think the issue is down to the string parsing for type names and this will probably need debugging on the platform where the error is happening.


For example:
Look of the code in ".vue" file (IDE: phpStorm).

At the same time, console message is correct.

Is that a problem of phpStorm?

Yes, it is.

@Zzzen  how did you make tslint run well?
请问怎么弄出来提示的？我试了不行。

下载这个仓库，安装好依赖就可以了。你确定使用的是最新版的tsc和vscode?@danielding

@Zzzen  试了，不行啊

What about English ?))

seperate the ts from vue file works, just write a ts file

Are you using the lastest vscode and tsc? I just downloaded this repo and everything worked fine @CodeLookBook

Should work if you're using Vetur.

As for WebStorm, it looks like code within a SFC in <script lang="ts"> doesn't really get the TypeScript treatment due to https://youtrack.jetbrains.com/issue/WEB-30807. Please vote there if you (like me) want that and arrived here trying to make that work.

Thanks for linking to that @wuservices!
I encourage other WebStorm users to surface feedback there.
Google Translate: 我鼓励其他WebStorm用户在那里提供反馈。


⚠ Bofrost.lu has degraded performance

In e4c8618, Bofrost.lu (https://www.bofrost.lu) experienced degraded performance:

HTTP code: 200
Response time: 1904 ms

Resolved: Bofrost.lu performance has improved in 6e3ab55 after 6 minutes.


Objective C Version

Hello,
I need Objective C version for this. Can you please provide ?

not sorry


Added rocket to link2

Please make a new PR using the naming convention described in the contributing doc.


Update containerd to 6c7abf7c76c1973d4fb4b0bad51691de84869a51.

Fixes https://github.com/kubernetes-incubator/cri-containerd/issues/492.
This PR:

Updated containerd to https://github.com/containerd/containerd/commit/6c7abf7c76c1973d4fb4b0bad51691de84869a51 to fix the image pulling issue and containerd deadlock issue.
Fix hack/update-vendor.sh @miaoyq. sed should do more precise regexp match, it changes CRITOOL version for me because it also contains v1.0.0.

Signed-off-by: Lantao Liu<EMAIL_ADDRESS>

/test pull-cri-containerd-node-e2e

k
/test pull-cri-containerd-node-e2e

/test pull-cri-containerd-node-e2e

/test pull-cri-containerd-build