reflection not working as expected? routes in tenants.php seem to require fully-specified controller paths

I have installed the latest hyn on a vanilla install of laravel with laravel-auth.
After adding routes to routes/tenants.php the route handlers cannot find controller classes unless they are fully specified. I expected reflection to find the controllers as per usual. Have I got something mis-configured?
This works
Route::get('login', 'App\Http\Controllers\Auth\LoginController@showLoginForm')->name('login');
This doesn't work
Route::get('login', 'Auth\LoginController@showLoginForm')->name('login');
Information
running on homestead

hyn/multi-tenant version: 5.2.6
laravel version: 5.6
database driver and version: mysql
webserver software and version: nginx/1.14.0 (Ubuntu)
php version: 7.2

tenants.php
<?php

/*
|--------------------------------------------------------------------------
| Tenant Routes
|--------------------------------------------------------------------------
*/
Route::group([
	'middleware'	=>	[
		'web',
	],
], function() {
	Route::get('/', function () {
		return view('tenant.welcome');
	});

	## Auth::routes(); # login/logout/etc

	Route::get('login', 'App\Http\Controllers\Auth\LoginController@showLoginForm')->name('login');
	Route::post('login', 'App\Http\Controllers\Auth\LoginController@login');
	Route::post('logout', 'App\Http\Controllers\Auth\LoginController@logout')->name('logout');

	// Registration Routes...
	Route::get('register', 'App\Http\Controllers\Auth\RegisterController@showRegistrationForm')->name('register');
	Route::post('register', 'App\Http\Controllers\Auth\RegisterController@register');

	// Password Reset Routes...
	Route::get('password/reset', 'App\Http\Controllers\Auth\ForgotPasswordController@showLinkRequestForm')->name('password.request');
	Route::post('password/email', 'App\Http\Controllers\Auth\ForgotPasswordController@sendResetLinkEmail')->name('password.email');
	Route::get('password/reset/{token}', 'App\Http\Controllers\Auth\ResetPasswordController@showResetForm')->name('password.reset');

	Route::get('/home', 'App\Http\Controllers\HomeController@index')->name('home');
});

tenancy.php config
<?php

/*
 * This file is part of the hyn/multi-tenant package.
 *
 * (c) Daniël Klabbers<EMAIL_ADDRESS> *
 * For the full copyright and license information, please view the LICENSE
 * file that was distributed with this source code.
 *
 * @see https://laravel-tenancy.com
 * @see https://github.com/hyn/multi-tenant
 */

use Hyn\Tenancy\Database\Connection;

return [
    'models' => [
        /**
         * Specify different models to be used for the global, system database
         * connection. These are also used in their relationships. Models
         * used have to implement their respective contracts and
         * either extend the SystemModel or use the trait
         * UsesSystemConnection.
         */

        // Must implement \Hyn\Tenancy\Contracts\Hostname
        'hostname' => \Hyn\Tenancy\Models\Hostname::class,

        // Must implement \Hyn\Tenancy\Contracts\Website
        'website' => \Hyn\Tenancy\Models\Website::class
    ],
    'website' => [
        /**
         * Each website has a short random hash that identifies this entity
         * to the application. By default this id is randomized and fully
         * auto-generated. In case you want to force your own logic for
         * when you need to have a better overview of the complete
         * tenant folder structure, disable this and implement
         * your own id generation logic.
         */
        'disable-random-id' => false,

        /**
         * The random Id generator is responsible for creating the hash as mentioned
         * above. You can override what generator to use by modifying this value
         * in the configuration.
         *
         * @warn This won't work if disable-random-id is true.
         */
        'random-id-generator' => Hyn\Tenancy\Generators\Uuid\ShaGenerator::class,

        /**
         * Enable this flag in case you're using a driver that does not support
         * database username or database name with a length of more than 32 characters.
         *
         * This should be enabled for MySQL, but not for MariaDB and PostgreSQL.
         */
        'uuid-limit-length-to-32' => env('LIMIT_UUID_LENGTH_32', false),

        /**
         * Specify the disk you configured in the filesystems.php file where to store
         * the tenant specific files, including media, packages, routes and other
         * files for this particular website.
         *
         * @info If not set, will revert to the default filesystem.
         * @info If set to false will disable all tenant specific filesystem auto magic
         *       like the config, vendor overrides.
         */
        'disk' => null,

        /**
         * Automatically generate a tenant directory based on the random id of the
         * website. Uses the above disk to store files to override system-wide
         * files.
         *
         * @info set to false to disable.
         */
        'auto-create-tenant-directory' => true,

        /**
         * Automatically rename the tenant directory when the random id of the
         * website changes. This should not be too common, but in case it happens
         * we automatically want to move files accordingly.
         *
         * @info set to false to disable.
         */
        'auto-rename-tenant-directory' => true,

        /**
         * Automatically deletes the tenant specific directory and all files
         * contained within.
         *
         * @see
         * @info set to true to enable.
         */
        'auto-delete-tenant-directory' => true,

        /**
         * Time to cache websites in minutes. Set to false to disable.
         */
        'cache' => 10,
    ],
    'hostname' => [
        /**
         * If you want the multi tenant application to fall back to a default
         * hostname/website in case the requested hostname was not found
         * in the database, complete in detail the default hostname.
         *
         * @warn this must be a FQDN, these have no protocol or path!
         */
        'default' => env('TENANCY_DEFAULT_HOSTNAME'),
        /**
         * The package is able to identify the requested hostname by itself,
         * disable to get full control (and responsibility) over hostname
         * identification. The hostname identification is needed to
         * set a specific website as currently active.
         *
         * @see src/Jobs/HostnameIdentification.php
         */
        'auto-identification' => env('TENANCY_AUTO_HOSTNAME_IDENTIFICATION', true),

        /**
         * In case you want to have the tenancy environment set up early,
         * enable this flag. This will run the tenant identification
         * inside a middleware. This will eager load tenancy.
         *
         * A good use case is when you have set "tenant" as the default
         * database connection.
         */
        'early-identification' => env('TENANCY_EARLY_IDENTIFICATION', true),

        /**
         * Abort application execution in case no hostname was identified. This will throw a
         * 404 not found in case the tenant hostname was not resolved.
         */
        'abort-without-identified-hostname' => false,   # disabled to allow access to admin dashboard without subdomain

        /**
         * Time to cache hostnames in minutes. Set to false to disable.
         */
        'cache' => 10,

        /**
         * Automatically update the app.url configured inside Laravel to match
         * the tenant FQDN whenever a hostname/tenant was identified.
         *
         * This will resolve issues with password reset mails etc using the
         * correct domain.
         */
        'update-app-url' => false,
    ],
    'db' => [
        /**
         * The default connection to use; this overrules the Laravel database.default
         * configuration setting. In Laravel this is normally configured to 'mysql'.
         * You can set a environment variable to override the default database
         * connection to - for instance - the tenant connection 'tenant'.
         */
        'default' => env('TENANCY_DEFAULT_CONNECTION'),
        /**
         * Used to give names to the system and tenant database connections. By
         * default we configure 'system' and 'tenant'. The tenant connection
         * is set up automatically by this package.
         *
         * @see src/Database/Connection.php
         * @var system-connection-name The database connection name to use for the global/system database.
         * @var tenant-connection-name The database connection name to use for the tenant database.
         */
        'system-connection-name' => env('TENANCY_SYSTEM_CONNECTION_NAME', Connection::DEFAULT_SYSTEM_NAME),
        'tenant-connection-name' => env('TENANCY_TENANT_CONNECTION_NAME', Connection::DEFAULT_TENANT_NAME),

        /**
         * The tenant division mode specifies to what database websites will be
         * connecting. The default setup is to use a new database per tenant.
         * In case you prefer to use the same database with a table prefix,
         * set the mode to 'prefix'.
         *
         * @see src/Database/Connection.php
         */
        'tenant-division-mode' => env('TENANCY_DATABASE_DIVISION_MODE', 'database'),

        /**
         * The database password generator takes care of creating a valid hashed
         * string used for tenants to connect to the specific database. Do
         * note that this will only work in 'division modes' that set up
         * a connection to a separate database.
         */
        'password-generator' => Hyn\Tenancy\Generators\Database\DefaultPasswordGenerator::class,

        /**
         * The tenant migrations to be run during creation of a tenant. Specify a directory
         * to run the migrations from. If specified these migrations will be executed
         * whenever a new tenant is created.
         *
         * @info set to false to disable auto migrating.
         *
         * @warn this has to be an absolute path, feel free to use helper methods like
         * base_path() or database_path() to set this up.
         */
        'tenant-migrations-path' => database_path('migrations/tenants'),

        /**
         * The default Seeder class used on newly created databases and while
         * running artisan commands that fire seeding.
         *
         * @info requires tenant-migrations-path in order to seed newly created websites.
         *
         * @warn specify a valid fully qualified class name.
         */
        'tenant-seed-class' => false,
//      eg an admin seeder under `app/Seeders/AdminSeeder.php`:
//        'tenant-seed-class' => App\Seeders\AdminSeeder::class,

        /**
         * Automatically generate a tenant database based on the random id of the
         * website.
         *
         * @info set to false to disable.
         */
        'auto-create-tenant-database' => true,

        /**
         * Automatically generate the user needed to access the database.
         *
         * @info Useful in case you use root or another predefined user to access the
         *       tenant database.
         * @info Only creates in case tenant databases are set to be created.
         *
         * @info set to false to disable.
         */
        'auto-create-tenant-database-user' => true,

        /**
         * Automatically rename the tenant database when the random id of the
         * website changes. This should not be too common, but in case it happens
         * we automatically want to move databases accordingly.
         *
         * @info set to false to disable.
         */
        'auto-rename-tenant-database' => true,

        /**
         * Automatically deletes the tenant specific database and all data
         * contained within.
         *
         * @info set to true to enable.
         */
        'auto-delete-tenant-database' => env('TENANCY_DATABASE_AUTO_DELETE', true),

        /**
         * Automatically delete the user needed to access the tenant database.
         *
         * @info Set to false to disable.
         * @info Only deletes in case tenant database is set to be deleted.
         */
        'auto-delete-tenant-database-user' => env('TENANCY_DATABASE_AUTO_DELETE_USER', false),

        /**
         * Define a list of classes that you wish to force onto the tenant or system connection.
         * The connection will be forced when the Model has booted.
         *
         * @info Useful for overriding the connection of third party packages.
         */
        'force-tenant-connection-of-models' => [
//            App\Tenant\User::class
        ],
        'force-system-connection-of-models' => [
//            App\Tenant\User::class
        ],
    ],

    /**
     * Global tenant specific routes.
     * Making it easier to distinguish between landing and tenant routing.
     *
     * @info only works with `tenancy.hostname.auto-identification` or identification happening
     *       before the application is booted (eg inside middleware or the register method of
     *       service providers).
     */
    'routes' => [
        /**
         * Routes file to load whenever a tenant was identified.
         *
         * @info Set to false or null to disable.
         */
        'path' => base_path('routes/tenants.php'),

        /**
         * Set to true to flush all global routes before setting the routes from the
         * tenants.php routes file.
         */
        'replace-global' => true,
    ],

    /**
     * Folders configuration specific per tenant.
     * The following section relates to configuration to files inside the tenancy/<uuid>
     * tenant directory.
     */
    'folders' => [
        'config' => [
            /**
             * Merge configuration files from the config directory
             * inside the tenant directory with the global configuration files.
             */
            'enabled' => false,

            /**
             * List of configuration files to ignore, preventing override of crucial
             * application configurations.
             */
            'blacklist' => ['database', 'tenancy', 'webserver'],
        ],
        'routes' => [
            /**
             * Allows adding and overriding URL routes inside the tenant directory.
             */
            'enabled' => false,

            /**
             * Prefix all tenant routes.
             */
            'prefix' => null,
        ],
        'trans' => [
            /**
             * Allows reading translation files from a trans directory inside
             * the tenant directory.
             */
            'enabled' => false,

            /**
             * Will override the global translations with the tenant translations.
             * This is done by overriding the laravel default translator with the new path.
             */
            'override-global' => true,

            /**
             * In case you disabled global override, specify a namespace here to load the
             * tenant translation files with.
             */
            'namespace' => 'tenant',
        ],
        'vendor' => [
            /**
             * Allows using a custom vendor (composer driven) folder inside
             * the tenant directory.
             */
            'enabled' => false,
        ],
        'media' => [
            /**
             * Mounts the assets directory with (static) files for public use.
             */
            'enabled' => true,
        ],
        'views' => [
            /**
             * Adds the vendor directory of the tenant inside the application.
             */
            'enabled' => false,

            /**
             * Specify a namespace to use with which to load the views.
             *
             * @eg setting `tenant` will allow you to use `tenant::some.blade.php`
             * @info set to null to add to the global namespace.
             */
            'namespace' => null,

            /**
             * If `namespace` is set to null (thus using the global namespace)
             * make it override the global views. Disable to
             */
            'override-global' => true,
        ]
    ]
];

webserver.php config
<?php

/*
 * This file is part of the hyn/multi-tenant package.
 *
 * (c) Daniël Klabbers<EMAIL_ADDRESS> *
 * For the full copyright and license information, please view the LICENSE
 * file that was distributed with this source code.
 *
 * @see https://laravel-tenancy.com
 * @see https://github.com/hyn/multi-tenant
 */

return [

    /**
     * Apache2 is one of the most widely adopted webserver packages available.
     *
     * @see http://httpd.apache.org/docs/
     * @see https://www.digitalocean.com/community/tutorials/how-to-install-linux-apache-mysql-php-lamp-stack-on-ubuntu
     */
    'apache2' => [
        /**
         * Whether the integration with Apache2 is currently active.
         */
        'enabled' => false,

        /**
         * Define the ports of your Apache service.
         */
        'ports' => [
            /**
             * HTTP, non-SSL port.
             *
             * @default 80
             */
            'http' => 80,
            /**
             * HTTPS, SSL port.
             *
             * @default 443
             */
            'https' => 443
        ],

        /**
         * The generator taking care of hooking into the Apache services and files.
         */
        'generator' => \Hyn\Tenancy\Generators\Webserver\Vhost\ApacheGenerator::class,

        /**
         * The view that holds the vhost configuration template.
         */
        'view' => 'tenancy.generators::webserver.apache.vhost',

        /**
         * Specify the disk you configured in the filesystems.php file where to store
         * the tenant vhost configuration files.
         *
         * @info If not set, will revert to the default filesystem.
         */
        'disk' => null,

        'paths' => [

            /**
             * Location where vhost configuration files can be found.
             */
            'vhost-files' => [
                '/etc/apache2/sites-enabled/'
            ],

            /**
             * Actions to run to work with the Apache2 service.
             */
            'actions' => [
                /**
                 * Action that asserts Apache2 is installed.
                 */
                'exists' => '/etc/init.d/apache2',
                /**
                 * Action to run to test the apache configuration.
                 *
                 * @set to a boolean to force the response of the test command.
                 * @info true succeeds, false fails
                 */
                'test-config' => 'apache2ctl -t',
                /**
                 * Action to run to reload the apache service.
                 *
                 * @info set to null to disable reloading.
                 */
                'reload' => 'apache2ctl graceful'
            ]
        ]
    ],

    /**
     * Nginx webserver support.
     *
     * @see http://nginx.org
     */
    'nginx' => [
        /**
         * Whether the integration with nginx is currently active.
         */
        'enabled' => false,

        /**
         * The php sock to be used.
         */
        'php-sock' => 'unix:/var/run/php/php7.1-fpm.sock',

        /**
         * Define the ports of your nginx service.
         */
        'ports' => [
            /**
             * HTTP, non-SSL port.
             *
             * @default 80
             */
            'http' => 80,
            /**
             * HTTPS, SSL port.
             *
             * @default 443
             */
            'https' => 443
        ],

        /**
         * The generator taking care of hooking into the nginx services and files.
         */
        'generator' => \Hyn\Tenancy\Generators\Webserver\Vhost\NginxGenerator::class,

        /**
         * The view that holds the vhost configuration template.
         */
        'view' => 'tenancy.generators::webserver.nginx.vhost',

        /**
         * Specify the disk you configured in the filesystems.php file where to store
         * the tenant vhost configuration files.
         *
         * @info If not set, will revert to the default filesystem.
         */
        'disk' => null,

        'paths' => [

            /**
             * Location where vhost configuration files can be found.
             */
            'vhost-files' => [
                '/etc/nginx/sites-enabled/'
            ],

            /**
             * Actions to run to work with the Nginx service.
             */
            'actions' => [
                /**
                 * Action that asserts nginx is installed.
                 */
                'exists' => '/etc/init.d/nginx',
                /**
                 * Action to run to test the nginx configuration.
                 *
                 * @info set to a boolean to force the response of the test command.
                 *  true succeeds, false fails
                 */
                'test-config' => '/etc/init.d/nginx configtest',
                /**
                 * Action to run to reload the nginx service.
                 *
                 * @info set to null to disable reloading.
                 */
                'reload' => '/etc/init.d/nginx reload'
            ]
        ]
    ]
];

Error log
[2018-08-31 05:02:24] local.ERROR: Class Auth\LoginController does not exist {"exception":"[object] (ReflectionException(code: -1): Class Auth\\LoginController does not exist at /home/chris/tenant/vendor/laravel/framework/src/Illuminate/Container/Container.php:767)
[stacktrace]
#0 /home/chris/tenant/vendor/laravel/framework/src/Illuminate/Container/Container.php(767): ReflectionClass->__construct('Auth\\\\LoginContr...')
#1 /home/chris/tenant/vendor/laravel/framework/src/Illuminate/Container/Container.php(646): Illuminate\\Container\\Container->build('Auth\\\\LoginContr...')
#2 /home/chris/tenant/vendor/laravel/framework/src/Illuminate/Container/Container.php(601): Illuminate\\Container\\Container->resolve('Auth\\\\LoginContr...', Array)
#3 /home/chris/tenant/vendor/laravel/framework/src/Illuminate/Foundation/Application.php(734): Illuminate\\Container\\Container->make('Auth\\\\LoginContr...', Array)
#4 /home/chris/tenant/vendor/laravel/framework/src/Illuminate/Routing/Route.php(226): Illuminate\\Foundation\\Application->make('Auth\\\\LoginContr...')
#5 /home/chris/tenant/vendor/laravel/framework/src/Illuminate/Routing/Route.php(796): Illuminate\\Routing\\Route->getController()
#6 /home/chris/tenant/vendor/laravel/framework/src/Illuminate/Routing/Route.php(757): Illuminate\\Routing\\Route->controllerMiddleware()
#7 /home/chris/tenant/vendor/laravel/framework/src/Illuminate/Routing/Router.php(678): Illuminate\\Routing\\Route->gatherMiddleware()
#8 /home/chris/tenant/vendor/laravel/framework/src/Illuminate/Routing/Router.php(658): Illuminate\\Routing\\Router->gatherRouteMiddleware(Object(Illuminate\\Routing\\Route))
#9 /home/chris/tenant/vendor/laravel/framework/src/Illuminate/Routing/Router.php(642): Illuminate\\Routing\\Router->runRouteWithinStack(Object(Illuminate\\Routing\\Route), Object(Illuminate\\Http\\Request))
#10 /home/chris/tenant/vendor/laravel/framework/src/Illuminate/Routing/Router.php(608): Illuminate\\Routing\\Router->runRoute(Object(Illuminate\\Http\\Request), Object(Illuminate\\Routing\\Route))
#11 /home/chris/tenant/vendor/laravel/framework/src/Illuminate/Routing/Router.php(597): Illuminate\\Routing\\Router->dispatchToRoute(Object(Illuminate\\Http\\Request))
#12 /home/chris/tenant/vendor/laravel/framework/src/Illuminate/Foundation/Http/Kernel.php(176): Illuminate\\Routing\\Router->dispatch(Object(Illuminate\\Http\\Request))
#13 /home/chris/tenant/vendor/laravel/framework/src/Illuminate/Routing/Pipeline.php(30): Illuminate\\Foundation\\Http\\Kernel->Illuminate\\Foundation\\Http\\{closure}(Object(Illuminate\\Http\\Request))
#14 /home/chris/tenant/vendor/fideloper/proxy/src/TrustProxies.php(57): Illuminate\\Routing\\Pipeline->Illuminate\\Routing\\{closure}(Object(Illuminate\\Http\\Request))
#15 /home/chris/tenant/vendor/laravel/framework/src/Illuminate/Pipeline/Pipeline.php(151): Fideloper\\Proxy\\TrustProxies->handle(Object(Illuminate\\Http\\Request), Object(Closure))
#16 /home/chris/tenant/vendor/laravel/framework/src/Illuminate/Routing/Pipeline.php(53): Illuminate\\Pipeline\\Pipeline->Illuminate\\Pipeline\\{closure}(Object(Illuminate\\Http\\Request))
#17 /home/chris/tenant/vendor/laravel/framework/src/Illuminate/Foundation/Http/Middleware/TransformsRequest.php(31): Illuminate\\Routing\\Pipeline->Illuminate\\Routing\\{closure}(Object(Illuminate\\Http\\Request))
#18 /home/chris/tenant/vendor/laravel/framework/src/Illuminate/Pipeline/Pipeline.php(151): Illuminate\\Foundation\\Http\\Middleware\\TransformsRequest->handle(Object(Illuminate\\Http\\Request), Object(Closure))
#19 /home/chris/tenant/vendor/laravel/framework/src/Illuminate/Routing/Pipeline.php(53): Illuminate\\Pipeline\\Pipeline->Illuminate\\Pipeline\\{closure}(Object(Illuminate\\Http\\Request))
#20 /home/chris/tenant/vendor/laravel/framework/src/Illuminate/Foundation/Http/Middleware/TransformsRequest.php(31): Illuminate\\Routing\\Pipeline->Illuminate\\Routing\\{closure}(Object(Illuminate\\Http\\Request))
#21 /home/chris/tenant/vendor/laravel/framework/src/Illuminate/Pipeline/Pipeline.php(151): Illuminate\\Foundation\\Http\\Middleware\\TransformsRequest->handle(Object(Illuminate\\Http\\Request), Object(Closure))
#22 /home/chris/tenant/vendor/laravel/framework/src/Illuminate/Routing/Pipeline.php(53): Illuminate\\Pipeline\\Pipeline->Illuminate\\Pipeline\\{closure}(Object(Illuminate\\Http\\Request))
#23 /home/chris/tenant/vendor/laravel/framework/src/Illuminate/Foundation/Http/Middleware/ValidatePostSize.php(27): Illuminate\\Routing\\Pipeline->Illuminate\\Routing\\{closure}(Object(Illuminate\\Http\\Request))
#24 /home/chris/tenant/vendor/laravel/framework/src/Illuminate/Pipeline/Pipeline.php(151): Illuminate\\Foundation\\Http\\Middleware\\ValidatePostSize->handle(Object(Illuminate\\Http\\Request), Object(Closure))
#25 /home/chris/tenant/vendor/laravel/framework/src/Illuminate/Routing/Pipeline.php(53): Illuminate\\Pipeline\\Pipeline->Illuminate\\Pipeline\\{closure}(Object(Illuminate\\Http\\Request))
#26 /home/chris/tenant/vendor/laravel/framework/src/Illuminate/Foundation/Http/Middleware/CheckForMaintenanceMode.php(62): Illuminate\\Routing\\Pipeline->Illuminate\\Routing\\{closure}(Object(Illuminate\\Http\\Request))
#27 /home/chris/tenant/vendor/laravel/framework/src/Illuminate/Pipeline/Pipeline.php(151): Illuminate\\Foundation\\Http\\Middleware\\CheckForMaintenanceMode->handle(Object(Illuminate\\Http\\Request), Object(Closure))
#28 /home/chris/tenant/vendor/laravel/framework/src/Illuminate/Routing/Pipeline.php(53): Illuminate\\Pipeline\\Pipeline->Illuminate\\Pipeline\\{closure}(Object(Illuminate\\Http\\Request))
#29 /home/chris/tenant/vendor/hyn/multi-tenant/src/Middleware/EagerIdentification.php(29): Illuminate\\Routing\\Pipeline->Illuminate\\Routing\\{closure}(Object(Illuminate\\Http\\Request))
#30 /home/chris/tenant/vendor/laravel/framework/src/Illuminate/Pipeline/Pipeline.php(151): Hyn\\Tenancy\\Middleware\\EagerIdentification->handle(Object(Illuminate\\Http\\Request), Object(Closure))
#31 /home/chris/tenant/vendor/laravel/framework/src/Illuminate/Routing/Pipeline.php(53): Illuminate\\Pipeline\\Pipeline->Illuminate\\Pipeline\\{closure}(Object(Illuminate\\Http\\Request))
#32 /home/chris/tenant/vendor/hyn/multi-tenant/src/Middleware/HostnameActions.php(76): Illuminate\\Routing\\Pipeline->Illuminate\\Routing\\{closure}(Object(Illuminate\\Http\\Request))
#33 /home/chris/tenant/vendor/laravel/framework/src/Illuminate/Pipeline/Pipeline.php(151): Hyn\\Tenancy\\Middleware\\HostnameActions->handle(Object(Illuminate\\Http\\Request), Object(Closure))
#34 /home/chris/tenant/vendor/laravel/framework/src/Illuminate/Routing/Pipeline.php(53): Illuminate\\Pipeline\\Pipeline->Illuminate\\Pipeline\\{closure}(Object(Illuminate\\Http\\Request))
#35 /home/chris/tenant/vendor/laravel/framework/src/Illuminate/Pipeline/Pipeline.php(104): Illuminate\\Routing\\Pipeline->Illuminate\\Routing\\{closure}(Object(Illuminate\\Http\\Request))
#36 /home/chris/tenant/vendor/laravel/framework/src/Illuminate/Foundation/Http/Kernel.php(151): Illuminate\\Pipeline\\Pipeline->then(Object(Closure))
#37 /home/chris/tenant/vendor/laravel/framework/src/Illuminate/Foundation/Http/Kernel.php(116): Illuminate\\Foundation\\Http\\Kernel->sendRequestThroughRouter(Object(Illuminate\\Http\\Request))
#38 /home/chris/tenant/public/index.php(55): Illuminate\\Foundation\\Http\\Kernel->handle(Object(Illuminate\\Http\\Request))
#39 {main}

"Functioning as expected" is my reply.
Laravel does a bit of work for you under the hood when loading routes.  It's not reflection.  The controller namespace is explicitly defined in your app's RouteServiceProvider (https://github.com/laravel/laravel/blob/master/app/Providers/RouteServiceProvider.php#L17).  Since tenants.php is loaded by the Hyn package, not by RouteServiceProvider, it can't possibly know your namespace.  Additionally, you MAY want to change it.  For this reason, we leave it as a blank slate for you.  We also don't force the web middleware group on you, so you'll need to define that as well if you wish to use things like session or cookies.
It's a simple fix though.  Just wrap your entire tenants.php route file in something similar to this:
Route::middleware('web')->namespace('App\Http\Controllers')->group(function() {
    // ....

    // your routes here!

    // ....
});

Also take into consideration we don't know whether you want to add tenant specific api or web routes. These require different middleware.

Thank you - I was unaware of the functionality to specify the namespace for the middleware and it completely answers my question. Is it possible to add to this to the documentation? Starting new on laravel and on multi-tenant it wasn't obvious to me what hyn/multi-tenant is and isn't doing with regard to namespaces for routes in tenants.php

@Deracination adding it make sense, would you be able to PR the change yourself? https://github.com/tenancy/docs


[BUG] Serverside lua error: gmod_wire_expression2/init.lua:366: attempt to index field 'directives' (a nil value)

Had the bug happen again, this time the game actually returned a proper stacktrace:
addons/wire/lua/entities/gmod_wire_expression2/init.lua:366: attempt to index field 'directives' (a nil value)
   0.  __index - [C]:-1
    1.  ResetContext - addons/wire/lua/entities/gmod_wire_expression2/init.lua:366
     2.  fn - addons/wire/lua/entities/gmod_wire_expression2/init.lua:693
      3.  unkown - addons/ulib/lua/ulib/shared/hook.lua:109

Happened twice within a minute, not sure how to reproduce as it's from server console.
Original issue: https://github.com/wiremod/wire/issues/2311

Had a hunch it might've been this, https://github.com/wiremod/wire/blob/master/lua/entities/gmod_wire_expression2/init.lua#L693


fix: account for not requiring redundant GitHubRepo header

:tada: This PR is included in version 1.0.0-alpha.29 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


Chg: switch to a single servie and disable ingress usage by default

I've decided to switch to a single service and LoadBalancer type as this way we can have a single NLB exposed with correct certificates, so that the whole application could be exposed with a single FQDN, but different certificates including Amazon controlled ones

Do multiple 'ports' definitions in the same service work with Helm values files?

Yes it is


Neovim py3eval fix

Fix #203

Waiting to merge until @tomtomjhj opens an issue with neovim so I can link to it. May also want to include a fix for the warning message not being displayed if it isn't too difficult.


HNC: kubectl plugin does not show hierarchical-namespaces in the Usage section

hierarchical-namespaces is added in the Usage section in the root command. However, when typing kubectl hns, the output shows:
Manipulates hierarchical namespaces provided by HNC

Usage:
  kubectl [command]

Available Commands:
  config      Manipulates the HNC configuration
  create      Creates a subnamespace under the given parent.
  ...

Ideally, the Usage section should be kubectl hierarchical-namespaces [command]
This also impacts the usage section of subcommands. For example, when typing kubectl hns create, the usage section is:
Usage:
  kubectl create -n PARENT CHILD [flags]

Ideally, it should be kubectl hierarchical-namespaces create -n PARENT CHILD [flags]
P.S. We should probably also change kubectl hierarchical-namespaces to kubectl hns once we fix the issue described above.

cc:
@adrianludwin
@yiqigao217
@adrianchung

/close

This is fixed in #615


fix(js): added release step to the pipeline

Signed-off-by: blu3beri<EMAIL_ADDRESS>

It seems this is missing the updates to the build file?

Added it now. I guess I restored some work and accidentally included the addition of the release stuff.


[Question]

Big thanks for this quick start guide.  Look everywhere on the web and this guide was the only one that was current.  It has helped me immensely.  I just upgraded to the latest version and I have two questions.  What is causing these warnings. -
Warning: C:/Users/4dunc/Desktop/mining/desktop-wallet/xcashdtwallet/workspaces/shared-lib/apis/window-api-consts.ts is part of the TypeScript compilation but it's unused.
Add only entry points to the 'files' or 'include' properties in your tsconfig.
and
I am getting this error in my updated code.
[15248:0505/120624.763:ERROR:CONSOLE(1)] "Uncaught (in promise) TypeError: Failed to fetch", source: devtools://devtools/bundled/panels/elements/elements.js (1)
Any idea what it might be.  I narrowed it down to the upgrade of angular but that is all I have figured out.
One other question sandbox is set to true in production.  Is this correct?
"production": {
"configId": "production",
"mainLogFile": "main.log",
"mainLogLevel": "error",
"isIconAvailable": false,
"isSandbox": true,
"isOpenDevTools": false
Thanks again...

Hi @minerjed, thanks for the feed back.
Could you provide more details about how to reproduce. What did you do exactly ?
Dont forget to mention your node and npm versions.

About sandbox default is true. So yeah should be true in production unless you want to use dynamic dependancies from preload script. By the way, its is disabled when developing  because the scripts are not bundled by webpack yet.

Running on Windows 10, node v18.14.2, and npm 9.5.0.  No changes just downloaded the code and built.  When issue the command 'npm run start' I get these warnings.

The other warning I am getting "[15248:0505/120624.763:ERROR:CONSOLE(1)] "Uncaught (in promise) TypeError: Failed to fetch", source: devtools://devtools/bundled/panels/elements/elements.js (1)" does not show up so it is not an issue with your code.
Thanks

Lately, I did not have time to fix this, but I am about to.
Stay tuned.

Funning just looked at this again last week I looked.  I tried the update again and not seeing the "Add only entry points" message now.  As for this error "[15248:0505/120624.763:ERROR:CONSOLE(1)] "Uncaught (in promise) TypeError: Failed to fetch", source: devtools://devtools/bundled/panels/elements/elements.js " it is related to electron v24.  I am currently running ^23.3.13" but when I upgrade to any version v24 or higher get the error message.
These are the notable changes in electron v24
Stack Changes
Chromium 112.0.5615.49
[New in Chrome 112] (https://developer.chrome.com/blog/new-in-chrome-112/)
[New in Chrome 111] (https://developer.chrome.com/blog/new-in-chrome-111/)
[New in DevTools 112] (https://developer.chrome.com/blog/new-in-devtools-112/)
[New in DevTools 111] (https://developer.chrome.com/blog/new-in-devtools-111/)
Node.js 18.14.0
V8 11.2
The new error I ran into is when I build the install scripts and run the install, I get a blank screen when I run the application.  When I remove the sandbox line and build the install scripts it works fine.  Did not look at this very long so it may be something I have set up incorrectly.
Thanks...

Thanks for your inputs @minerjed. It was a journey though with everything to fix and upgrade.
Feel free to check and let me know if I have missed something.

Do you know what was causing the error "[15248:0505/120624.763:ERROR:CONSOLE(1)] "Uncaught (in promise) TypeError: Failed to fetch", source: devtools://devtools/bundled/panels/elements/elements.js" ?

Did not catch that one while upgrading sorry. Do you still have it ?
Checkout last version and compare with your project.

Looks like it was some sort of chrome.scripting issue.  Support was added in electron V26.x.  I upgraded electron to V26.6.0 and error is gone. https://github.com/electron/electron/pull/39676
Thanks for all the help....

I attempted to upgrade to your latest version but ran into a bunch of webpack issue.  Did not take the time to figure out.  I did upgrade angular and like I said I am on electron V26.  That is good enough for now.  Thanks again.


[kwok] Provided service for exec

What type of PR is this?

/kind featureg
What this PR does / why we need it:
Which issue(s) this PR fixes:

Fixes #236
Special notes for your reviewer:
Does this PR introduce a user-facing change?

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

Hi @nikola-jokic, would you be interested in reviewing exec, I've implemented it and only have tests left. currently struggling with the --stdin and --tty parameters, It seems that the test cannot cover this.

Thank you for your review it was very helpful 😄

You are welcome! Thank you for asking me :smile:


docs(react-router-redux): create working example, based on others

This example works, is fairly simple and uses the same template outlining examples on the website. Is this ok or should I add anything else? Is it possibly preferable to use withRouter instead of wrapping the <ConnectedApp/> component in a <Route/>?

Thanks, but this tips it past the point of excess complexity. I wanted to keep the example down to a bare minimum. It doesn't need to be copy/paste-able, as the vast majority will need to customize it further in some way.
What would work better is an example we can drop into the tree. We had multiple examples before, but I think just a single CRA-based example would be more that sufficient. If you could work up that as a PR, that would be much appreciated!

@timdorr sounds good, thanks for the direction. I'll work something up either tomorrow or the next day. Would this be ok to live inside the directory: react-router/packages/react-router-redux/examples/?

Yep, that's the right place.


Detect/indication if a report is sent

Thank you for this great library!
There doesn't seem to be a way to detect if a report was sent? It would be quite helpful in my case because I would like to trigger a backlight on button activity.
If joystick.update() could return True/False that would do the trick, or is there an existing mechanism?

I added a return here. Did the job.
        # Send the USB HID report if required.
        if always or self._last_report != self._report:
            try:
                self._device.send_report(self._report)
                self._last_report[:] = self._report
            except OSError:
                # This can occur if the USB is busy, or the host never properly
                # connected to the USB device.  We just drop the update and try later.
                if halt_on_error:
                    raise
            return True


Android support is not there for UI Customization

we have implemented Zoho SalesIQ for our flutter mobile app. The zoho team has done great job, it is working fine with our app, but there are few issues, that should be improved by your end.

UI customization only for iOS, but need support for Android.
The chat icon is visible across all screens of the app, need support to customize so that when we want we could call a method and same for dismiss.

need support for UI customization for Android in the same way as you are providing for iOS.

Please provide a feedback for this issue, ASAP.

Hi @khan-raptee,
Thanks for writing to us.
UI Customisation
Please add the below attributes in the SalesIQ theme.

colorAccent - theme color attribute.

Sample code:
<!--  The below theme will be used, when the device is in dark mode  -->
<style name="Theme.SalesIQ.Base.Dark" parent="Theme.SalesIQ.Dark" >
            <item name="colorAccent">#0000ff</item>
</style>

<!--  The below theme will be used, when the device is in dark mode  -->
<style name="Theme.SalesIQ.Base.DarkActionBar" parent="Theme.SalesIQ.Light" >
            <item name="colorAccent">#00ff00</item>
</style>

Also, visit our help document to learn more about customizations.
Launcher visibility
Kindly refer to this documentation for changing the visibility of the chat icon(launcher).
For further queries, please feel free to write us at<EMAIL_ADDRESS>We will be happy to assist you.
Regards,
Bhahirathan M,
Zoho SalesIQ.

Hi @khan-raptee,
As there is no recent activity from your side, we are closing this issue. You can reopen this again anytime. Meanwhile, please check out our latest version.
Please feel free to write back to us at<EMAIL_ADDRESS>if the issue persists.
Best regards,
Bhahirathan M
Zoho SalesIQ.


Text on a button

Make a way to render text into an image to put onto a button

I'm happy with this for now.  Would be nice to do word-wrap but I'll raise that as a separate issue.


Fix tsconfig resolution for navigation

Fixes #192772
Tested following scenarios -

Relative path without json at the end
Relative path with json at the end
tsconfig which resolves to a module in node_modules

Tested on Linux & Windows

@mjbvz can you take a look and approve these changes it looks ok?

Thanks @ronakj! This will be in the next VS code insiders build


Add 0.6.0 support

Dortania recently went through a very large rebuild site wise and so thought I'd help out with fixing links on older pages and adding more hardware support with 0.6.0.
Sorry for the large PR, hopefully it's not too much work to go through. Thanks very much in advance!

Thanks, looks ok, merged.
I have been checking https://github.com/acidanthera/OpenCorePkg/ every couple of days waiting for the 0.6.0 release, but it seems to be dragging a bit. So I hadn't actually started looking at it.

Oh if you're curious, August 3rd is the planned release. There shouldn't be any more config changes from now till then(hopefully), most changes will be on the backend


Change the sentence for adding a picture to illustrate your article

 Change the sentence for adding a picture to illustrate your article


4.8_Explain_everything_related_to_Linux_Kernel_Mentorship_Program

Description 📜
Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context.
Fixes # <issue_number_here>

Type of change 📝

[x] Documentation (Content Creation in the form of codes or tutorials)

Domain of Contribution 📊

[x] Open Source

Checklist ✅

[x] I follow Contributing Guidelines & Code of conduct of this project.
[x] I have performed a self-review of my own code or work.
[x] I have commented my code, particularly in hard-to-understand areas.
[x] My changes generates no new warnings.
[x] I'm GWOC'21 contributor

Screenshots / Gif (Optional) 📸

@Aryamanz29 Hey, pls review and tell if any further changes are required, thanks!

Don't raise PR to main branch


Throw on heartbeat when activity task times out

What was changed

Adds a new ActivityTaskTimedOutException subclassed from ActivityCompletionException
This exception is now thrown on heartbeating when the activity task has exceeded the start-to-close or schedule-to-close timeout
Adds a getStartedTimestamp  method to ActivityInfo for the started_time field from PollActivityTaskQueueResponse. This is needed to calculate if the start-to-close timeout has been exceeded.
Added two new test cases in ActivityTimeoutTest and updated an existing test case in WorkflowClosedRunningActivityTest

Why?

Because of heartbeat throttling, an activity task can keep running even though it has exceeded its timeouts and is heartbeating. This change moves these failures up in time, for more efficient activity processing and to reduce cases where multiple attempts of the same activity are executing simultaneously.
Checklist

Closes #1770

How was this tested:

Ran above unit tests using gradle:
./gradlew :temporal-sdk:test --tests "io.temporal.workflow.activityTests.ActivityTimeoutTest"
./gradlew :temporal-sdk:test --tests "io.temporal.workflow.activityTests.cancellation.WorkflowClosedRunningActivityTest.activitySeesActivityNotExistException[*]"

Any docs updates needed?

https://docs.temporal.io/dev-guide/java/features#activity-heartbeats

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

Hrmm. I don't think this is a custom exception type, I think this is just a cancellation. Today timeout results in cancellation to the activity, correct? We can't break people's code that have that existing expectation, e.g. catch (CanceledFailure.
Also, @Quinn-With-Two-Ns, I am curious if Go and Core do client-side preempted timeouts. Does that apply for heartbeat timeout too? I think they may. But my initial thought is that there is existing behavior that, besides worker shut down, a Java activity can't receive a cancel outside of the heartbeat throttle window and I am unsure it's worth changing that for everyone.
If you rely on more precise activity timeouts, I think you should maintain that timer in the activity yourself.

Hrmm. I don't think this is a custom exception type, I think this is just a cancellation. Today timeout results in cancellation to the activity, correct? We can't break people's code that have that existing expectation, e.g. catch (CanceledFailure.

As far as I can tell today, this becomes ActivityNotExistsException when a NOT_FOUND status is returned from Temporal server, indicating that the activity task's token cannot be found since it's no longer valid. A "not found" message here is confusing because it does not clearly communicate the underlying cause of the failure. It makes it look like the activity got lost somehow by Temporal server. Moreover, this exception is only thrown when the heartbeat reached the server, which due to heartbeat throttling can be unpredictable.
I haven't been able to reproduce this at an SDK level, but perhaps cancellation occurs in certain other timeout situations? In that case ActivityCanceledException would be thrown when the heartbeat is successful and the cancel_requested bit is set on the GRPC response. Source is all here.
Either way, these are all subclasses of ActivityCompletionException, and do not have CanceledFailure in their hierarchy. Existing guidance on .heartbeat() suggests catching the superclass anyways. This new exception type also extends that same superclass. I suppose this could be a subclass of ActivityNotExistsException to preserve existing behavior. That seems odd, but maybe is worth the tradeoff for consistency?
As for handling this in activity code (or an interceptor), I could certainly do that, but the activity task coming from Temporal server has all the information to calculate and enforce these deadlines accurately. This change will make timeout failures more consistent. Due to heartbeat throttling, you get into the situation where activity code continues to run even when it's already 100% known that any heartbeat or success/failure will be rejected by the server.
General guidance seems to be to heartbeat regularly in order to detect when your activity needs to exit early. From a user perspective, it is clear when your code could be pre-empted and if you don't try/catch anything, you're going to get the right before (in this case, the activity will retry on start-to-close and simply exit on schedule-to-close). This change works well within that existing behavior. I do agree that starting to raise InterruptedException is a much more severe and risky change because it would change behavior substantially and because it's easy to mishandle InterruptedException in code. But this change doesn't go down that path.

I could certainly do that, but the activity task coming from Temporal server has all the information to calculate and enforce these deadlines accurately.

This timeout information is made available on ActivityInfo, and you can probably write an interceptor that does this for you.
Besides the obvious fear of changing everyone's behavior to client-side timeouts by default, there are two other concerns: 1) client side cannot report timeout to server side so the workflow-side error may change if client side happens first (or client side has to just not send anything after timeout), and 2) there has been talk of allowing activity option updates server side and/or after the activity starts, which can include timeouts.

I think if we make start and schedule time visible, then this is just a simple matter of subtraction from timeouts. I hesitate to make the helper visible because I am not sure we want to encourage users writing their own timeout checks that race with the server (it can be racy whether someone failing based on this timeout responds to the server in time with their failure before the server hits the same timeout).

hm so in Go we do cancel the context based on the activity deadline  that we do derive from the timeout in Go we effectively do have a hasTaskTimedOut by checking if the deadline is expired. If the context is deadline is expired in Go I believe the heartbeat will fail.
I am not sure we should be returning a different exception on a "local" timeout. We document that heartbeat returns ActivityCompletionException on any reason to cancel the activity. Not sure what the "racey" concerns are @cretz ? Doesn't seem any worse then the current race with heartbeat throttling and timeouts?

I'll note we also have this issue open

Not sure what the "racey" concerns are @cretz ? Doesn't seem any worse then the current race with heartbeat throttling and timeouts?

What are you gonna return to the server on activity timeout from the client side? If nothing, no problem. I can get behind adding this if it's the case in Go. Would like to know what Core does too.

What are you gonna return to the server on activity timeout from the client side? If nothing, no problem.

Let me look into this some more too. In a similar change in temporal-ruby, I just don't send an activity task response back because I know it's already timed out (or about to) on the server anyways and is likely to be rejected. If there's a small amount of clock skew, this should get both the worker and server into the same state.
Even without that, if it wins the race with the server, the attempt will be failed, and the server will retry the activity according to the retry policy. As far as I can tell, it's the same outcome as the activity task timing out on the server, with some differences possibly in what gets logged and emitted to metrics. Having a message about a timeout being logged is better than not found (the current experience).

In Go we should return the cancelled error  I believe

Even without that, if it wins the race with the server, the attempt will be failed, and the server will retry the activity according to the retry policy.

@jeffschoner - This is not necessarily true. For instance a schedule to close timeout is not retryable, but if client side wins then it may retry only to fail immediately but potentially be another (cloud-chargeable) activity attempt. Also, different error types of a retry policy can be marked non-retryable, so if it's racy on what that error type is, then different retry policy may apply. And what gets emitted to metrics does matter. And in general what the activity failure event looks like in history matters too (it says what timeout type it hit, etc).
If we aren't ok with allowing the server to decide timeouts (which is the safest, even if Go didn't, need to check core), then we should probably just consider dropping the task. Otherwise the user can fail themselves if they want to do client-side failure for any reason, including timeout.
We have future plans of delivering cancellation unrelated to heartbeating which makes this unnecessary (there are talks of bidirectional gRPC streams here).

We have future plans of delivering cancellation unrelated to heartbeating which makes this unnecessary (there are talks of bidirectional gRPC streams here).

I was talking with @antstorm elsewhere about the new approach to cancellation APIs in the Rust core-based SDKs too. It sounds like there are some shorter and longer term plans to take some better approaches overall.
I'll send out a new PR to add start time to ActivityInfo. The scheduled time is already present. With that, I can implement this as an interceptor included in all workers to get where I need to go in the shorter term. I'm willing to take on more consistent timeout failures over subtle retry behavior changes, but I understand that may not be more broadly acceptable.

Looks like @Quinn-With-Two-Ns got this in in #1798. Thanks!


the plugins but in error the lands plugin

the perworldplugin prevents the lands plugin from working correctly without giving us an error
plugin link::https://www.spigotmc.org/resources/lands-⭕-land-claim-plugin-✅-grief-prevention-protection-gui-management-nations-wars-1-20-support.53313/

the perworldplugin prevents the lands plugin from working correctly without giving us an error
plugin link::https://www.spigotmc.org/resources/lands-⭕-land-claim-plugin-✅-grief-prevention-protection-gui-management-nations-wars-1-20-support.53313/

Its a premium plugin, I don't buy it. Please send a log or I will close this issue

there is no error just the plugin commands do not work
I will send you the video of the problem
https://cdn.discordapp.com/attachments/1225527564018126988/1230637049296457759/Desktop_04-18-2024_23-50-09-197.mp4?ex=662ccad0&is=662b7950&hm=8479b18061f27fb8e7697e8be30923fe02d8b0e28f8de63201b718b6ffd3d2eb&

there is no error just the plugin commands do not work
I will send you the video of the problem https://cdn.discordapp.com/attachments/1225527564018126988/1230637049296457759/Desktop_04-18-2024_23-50-09-197.mp4?ex=662ccad0&is=662b7950&hm=8479b18061f27fb8e7697e8be30923fe02d8b0e28f8de63201b718b6ffd3d2eb&

Is a premium plugin I can't fix it. I recommend you make a network.

.+great if we solve the problem just by closing the tickets I understand why the plugin "has no problem"

@MaxifeuxG I can't understand how people ask for support thinking that I have all the Spigot plugins purchased so I can try them. Don't close it as fixed, but as unplanned


error when calling via https

Hi,
I recently upgraded to 2.6.0 and having problems when sending a request with https.
By calling (for example) https://foo.com/bar I get the following error:
MockWebServer[63548] connection from /<IP_ADDRESS> crashed
java.lang.IllegalArgumentException: Unexpected header: �	���3�9�/�5�
	at com.squareup.okhttp.Headers$Builder.add(Headers.java:238)
	at com.squareup.okhttp.mockwebserver.MockWebServer.readRequest(MockWebServer.java:607)
	at com.squareup.okhttp.mockwebserver.MockWebServer.access$1500(MockWebServer.java:94)
	at com.squareup.okhttp.mockwebserver.MockWebServer$4.processOneRequest(MockWebServer.java:520)
	at com.squareup.okhttp.mockwebserver.MockWebServer$4.processConnection(MockWebServer.java:482)
	at com.squareup.okhttp.mockwebserver.MockWebServer$4.execute(MockWebServer.java:424)
	at com.squareup.okhttp.internal.NamedRunnable.run(NamedRunnable.java:33)
	at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1145)
	at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:615)
	at java.lang.Thread.run(Thread.java:744)

However http://foo.com/bar works. Am I missing a configuration step or something when using https?

Are you enabling HTTPS on your MockWebServer?

Not yet I think. How do I enable HTTPS on my MockWebServer?

That's a better question for StackOverflow than this bug tracker. This bug tracker is for feature requests & bug reports only.


IWBSButton DataTarget will create an access violation on destroy with FastMM enabled.

FastMM will raise an exception when DataTarget is assigned on a IWBSButton and destruction of the form.
This is a work around I have found to ensure it is set to NIL
destructor TIWBSButton.Destroy;
var
  LDataTarget: Pointer;
begin
  try
    if Assigned(FDataTarget) then
    begin
      LDataTarget := @FDataTarget;
      if LDataTarget <> nil then
      begin
        try
          Pointer(FDataTarget) := nil;
        except
        end;
      end;
    end;
  finally
    inherited;
  end;
end;

To replicate enabled FastMM4 debug options on the IWBSDemo start demo and then exit.
To fix without using this above, edit Unit2 and add a FormDestroy event
IWBSButton49.DataTarget := nil;

Yes, I can reproduce this.
But what is the reason for this happening?
Why only happen with FullDebugMode enabled?
Why only happen with FDataTarget and not with FDataParent?
And how did you find this fix?

Might be because de IDE itself is holding a reference to the interface - this way the object will not be freed when de application is closed and FastMM collects the informaiton about non-freed memory.
You can reproduce this even with a simple project without FastMM and 'ReportMemoryLeaksOnShutdown' set to true. Just at the 'DataTarget' to your watchlist....


[feature] Copy constructor for IRenderTarget

Is your feature request related to a problem? Please describe.
My post-processing VisTrace extension relies a lot on rendertargets, so it'd be beneficial for me to be able to copy IRenderTargets around.
Describe the solution you'd like
I want a copy constructor to be added to IRenderTarget which would
Describe alternatives you've considered
There is no (good) alternative to this.

Just some quick researching before implementing.. virtual copy constructors don't exist :trollface:

The interface class shouldn’t have a copy constructor, the derived class should…


Need to add isGoogleLogin to settings

With the auto-login settings, can you add the isGoogleLogin option, from the chatgpt-api?
From chatgpt-api readme:

Alternatively, if your OpenAI account uses Google Auth, you shouldn't encounter any of the more complicated Recaptchas — and can avoid using these third-party providers. To use Google auth, make sure your OpenAI account is using Google and then set isGoogleLogin to true whenever you're passing your email and password. For example:
const api = new ChatGPTAPIBrowser({
  email: process.env.OPENAI_EMAIL,
  password: process.env.OPENAI_PASSWORD,
  isGoogleLogin: true
})

Hi there, this extension is no longer using chatgpt-api for its browser-based autologin flow. If you'd like to use the google/microsoft login instead of usual login, you should not provide email/password in your setting. Since those login flows use their respective auth methods (not via openai, e.g. on accounts.google.com and login.microsoft.com).

@Andrew-Gee I was able to spare some time to implement this


how to Monitoring playbackRate Changes ？

hi
when i changed playbackRate， i hope have a Callback,  like  OnPlaybackRateChanged
but  i don't know , how to do this
can you help me ?
thank you very much

What type of URL are you trying to play?

mp4 file    http://player.alicdn.com/video/editor.mp4

You can use getInternalPlayer to listen to the ratechange event of the <video> element.
Very rough example:
class Player extends React.Component {
	state = {
  	playbackRate: 1
  }
  onClickToggle = () => {
  	this.setState({ playbackRate: this.state.playbackRate === 1 ? 2 : 1 })
  }
  onReady = player => {
  	player.getInternalPlayer().addEventListener('ratechange', e => {
	    console.log(`rate changed to ${e.target.playbackRate}`)
    })
  }
  render () {
  	const { playbackRate } = this.state
    return (
    	<div>
        <ReactPlayer
          url='http://player.alicdn.com/video/editor.mp4'
          playing
          controls
          onReady={this.onReady}
          playbackRate={playbackRate}
        />
        <button onClick={this.onClickToggle}>Toggle</button> Rate: {playbackRate}
      </div>
    )
  }
}

https://jsfiddle.net/s8bn2xdq/


latitude and longitude sometimes appears in request URL in scientific notation resulting in a 400 response code

for example a longitude supplied as a double of -0.000066 appears in the get URL as -6.6E-5 resulting in HTTP response code: 400

Hey thanks for the report. I could reproduce the issue and fixed it with the latest release. it will take a few hours for maven central to be in sync.


Upgrade to version 1.3.0

Obviously, like the title says.
An Upgrade would be nice.  .

Hi!
I think I'll do 1.3.1 directly, it should be out in a few days. Let me know if there is something from 1.3.0 which you really need now.
When it is released, the plugin will install crowdsec from the OPNsense packages, we don't have our own binary repository or even a build server for FreeBSD, like we have on Linux. We'll see what we can do to avoid lagging too much behind new versions.

https://github.com/crowdsecurity/opnsense-plugin-crowdsec/releases/tag/v0.0.5
The binaries include crowdsed 1.3.0 with a few changes from the master branch
I'll update the official freebsd port after 1.3.1

1.3.1-rc1 is here - https://github.com/crowdsecurity/opnsense-plugin-crowdsec/releases/tag/v0.0.6


Fix the errors mentioned in PR#1

This PR fixes the errors mentioned by @hsluoyz in #1.

lgtm.
Next step is to setup CI and code coverage badges.


Doesn't work with models on diferent drive?

I am getting this error due to the fact that my models are on a different SSD than where the sd-webui is located.
Is there any fix for this? I have yet to try it if the sd-webui is also located on that drive but can try that later when I have some free time.
This is the error I get when trying to load the model previews though.
  File "C:\stable-diffusion-webui\venv\lib\site-packages\gradio\routes.py", line 337, in run_predict     output = await app.get_blocks().process_api(   File "C:\stable-diffusion-webui\venv\lib\site-packages\gradio\blocks.py", line 1015, in process_api     result = await self.call_function(   File "C:\stable-diffusion-webui\venv\lib\site-packages\gradio\blocks.py", line 833, in call_function     prediction = await anyio.to_thread.run_sync(   File "C:\stable-diffusion-webui\venv\lib\site-packages\anyio\to_thread.py", line 31, in run_sync     return await get_asynclib().run_sync_in_worker_thread(   File "C:\stable-diffusion-webui\venv\lib\site-packages\anyio\_backends\_asyncio.py", line 937, in run_sync_in_worker_thread     return await future   File "C:\stable-diffusion-webui\venv\lib\site-packages\anyio\_backends\_asyncio.py", line 867, in run     result = context.run(func, *args)   File "C:\stable-diffusion-webui\extensions\sd-model-preview-xd\scripts\modelpreview.py", line 233, in show_model_preview     return show_preview(modelname.replace(".ckpt","").replace(".safetensors",""), directories)   File "C:\stable-diffusion-webui\extensions\sd-model-preview-xd\scripts\modelpreview.py", line 291, in show_preview     html_code, found_md_file, found_txt_file = search_and_display_previews(name, paths)   File "C:\stable-diffusion-webui\extensions\sd-model-preview-xd\scripts\modelpreview.py", line 194, in search_and_display_previews     relative_path = os.path.relpath(path, current_directory)   File "C:\Users\User\.pyenv\pyenv-win\versions\3.10.6\lib\ntpath.py", line 744, in relpath     raise ValueError("path is on mount %r, start on mount %r" % ( ValueError: path is on mount 'F:', start on mount 'C:'
Thanks!

Ok I tested using a location outside of the install directory but didnt try a separate drive entirely. I dont know why it would be different but I will do some testing.


chore(deps): update terraform github.com/terraform-ibm-modules/terraform-ibm-observability-instances to v2.11.0

This PR contains the following updates:

Package
Type
Update
Change

github.com/terraform-ibm-modules/terraform-ibm-observability-instances
module
minor
v2.10.3 -> v2.11.0

Release Notes

terraform-ibm-modules/terraform-ibm-observability-instances (github.com/terraform-ibm-modules/terraform-ibm-observability-instances)
v2.11.0
Compare Source
Features

added the ability to create an auth policy which allows the atracker service object writer access to the COS target. This will only be created if passing a value for the cos_targets input variable, and if service_to_service_enabled is true and skip_atracker_cos_iam_auth_policy is false inside the cos_targets list object. (#433) (653b662)

Configuration
📅 Schedule: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).
🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.
♻ Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.
👻 Immortal: This PR will be recreated if closed unmerged. Get config help if that's undesired.

[ ] If you want to rebase/retry this PR, check this box

This PR has been generated by Renovate Bot.

/run pipeline

/run pipeline

/run pipeline


ci: add transaction replay daily job for compatibility testing

The tip commit will need to be dropped before landing as it is only used to test that the CI job is working as intended.

Need to use https://github.com/diem/diem/pull/7787 to actually replay all transactions (otherwise only those after the latest state snapshot are executed.)

/land


Test examples files in configmap directory

Test the configMap examples added in https://github.com/kubernetes/website/pull/13078

@tengqm you fear about the cache PR seems to be a valid one.
I made a typo in the filename, Travis run and failed, then i've corrected the file using forced-pushed and now Travis still use the old file.
Any thoughts how i can force invalidate the file ?
@zparnold fyi

/check-cla

/check-cla

@tengqm any chance you might know what is going on here ?
the error says
examples_test.go:592: configmap/configmaps.yaml: number of expected types (1) doesn't match number of docs in YAML (2)
examples_test.go:620: Directory configmap: Expected 2 examples, Got 1

but we got 2 examples no ?
apiVersion: v1
kind: ConfigMap
metadata:
  name: special-config
  namespace: default
data:
  special.how: very
---
apiVersion: v1
kind: ConfigMap
metadata:
  name: env-config
  namespace: default
data:
  log_level: INFO

digging a bit more i can see that we parse the yaml file and then the above error is due to this logic

/hold until https://github.com/kubernetes/website/pull/13145 is merged and then rebase

/hold

once https://github.com/kubernetes/website/pull/13145 is merged, rebase and carry on

/hold cancel

ready for review @cody-clark , thanks !

/lgtm
/approve

as always thank you very much @tengqm


Added working syntax to ignore field

Replaced non-working gorm:"-" syntax with sql:"-" to ignore a field in a struct

See #1041 for details

I think you need to search github issues history. your gorm version is out of date.


Fix Trino typo

Why are the changes needed?
fix trino typos
How was this patch tested?

[ ] Add some test cases that check the changes thoroughly including negative and positive cases if possible

[ ] Add screenshots for manual tests if appropriate

[ ] Run test locally before make a pull request

@Kiss736921, thanks for contribution, merged to master/1.7


[TechDocs CLI] Publishing to AES256 encrypted S3 bucket

In our org, we have a default policy that denies unencrypted uploads to buckets via headers.  This prevents uploading objects to the bucket without encryption.
Normally, when using the AWS CLI, this is resolved by passing --sse AES256 as a command line arg.  It does not seem that this is possible with the techdocs-cli publish command.
Can it be added?
For reference, here is the bucket policy in question causing the issue.  As soon as we remove this section of the policy, the command functions as expected:
{
    "Version": "2012-10-17",
    "Statement":
    [
        {
            "Sid": "DenyIncorrectEncryptionHeader",
            "Effect": "Deny",
            "Principal":
            {
                "AWS": "*"
            },
            "Action": "s3:PutObject",
            "Resource":
            [
                "arn:aws:s3:::testbucket/*",
                "arn:aws:s3:::testbucket"
            ],
            "Condition":
            {
                "StringNotEquals":
                {
                    "s3:x-amz-server-side-encryption": "AES256"
                }
            }
        },
        {
            "Sid": "DenyUnencryptedUploads",
            "Effect": "Deny",
            "Principal":
            {
                "AWS": "*"
            },
            "Action": "s3:PutObject",
            "Resource":
            [
                "arn:aws:s3:::testbucket/*",
                "arn:aws:s3:::testbucket"
            ],
            "Condition":
            {
                "Null":
                {
                    "s3:x-amz-server-side-encryption": "true"
                }
            }
        }
    ]
}

@camilaibs just wondering about these PRs to close this issue.

@garyniemen - both PRs have been merged and released https://github.com/backstage/backstage/pulls?q=is%3Apr+is%3Aclosed+author%3Atherynamo.
I've tested this with sse and everything works as expected. I'd also expect AES256 to work accordingly - but I have no buckets to test that with at the moment.

@nomeelnoj - seems like the support has been added. would you be able to test this at your end?

@nomeelnoj - seems like the support has been added. would you be able to test this at your end?

Hi @nomeelnoj, just pinging you, looking forward to hearing good news 🙂

Hi! @nomeelnoj - Closing this issue for now. Please re-open if needed.


cardano-testnet | Fix redundant error in creation of artifacts from failed test workspaces

Description
Sometimes after tests in cardano-testnet fail, workspace tar-ing fails as well with this cryptic error:
basename: extra operand ‘build-0-test-baf6b13ac090f575’

(see for example this build log https://github.com/IntersectMBO/cardano-node/actions/runs/11024038455/job/30616484791#step:16:14 )
This is annoying because you have to scroll through multiple lines of tar output to get to the actual test failures.
This PR aims to fix that.
Checklist

[ ] Commit sequence broadly makes sense and commits have useful messages
[ ] New tests are added if needed and existing tests are updated.  These may include:

golden tests
property tests
roundtrip tests
integration tests
See Runnings tests for more details

[ ] Any changes are noted in the CHANGELOG.md for affected package
[ ] The version bounds in .cabal files are updated
[ ] CI passes. See note on CI.  The following CI checks are required:

[ ] Code is linted with hlint.  See .github/workflows/check-hlint.yml to get the hlint version
[ ] Code is formatted with stylish-haskell.  See .github/workflows/stylish-haskell.yml to get the stylish-haskell version
[ ] Code builds on Linux, MacOS and Windows for ghc-8.10.7 and ghc-9.2.7

[ ] Self-reviewed the diff

Note on CI
If your PR is from a fork, the necessary CI jobs won't trigger automatically for security reasons.
You will need to get someone with write privileges.  Please contact IOG node developers to do this
for you.

@palas I wasn't able to reproduce this locally on in CI for some reason. I understand that's what happening, that there's a space in the file name. I don't suspect find to insert spaces out of the blue there, so it looks like the directory has space in int. I suspect that's the offender: https://github.com/IntersectMBO/cardano-node/blob/72642b5d2dddf50c87184bafba49f2becd3de4bf/cardano-testnet/test/cardano-testnet-test/Cardano/Testnet/Test/Cli/Transaction.hs#L47 because the basename complains about build-0-somehash.


Player crash after 4 hour and 13 minutes

Hi,
Player crash because of out of memory excemption.
Logfile show this:
04:13:45.520 (Error): Updating Shader Resource View failed: HRESULT: [0x8007000E], Module: [General], ApiCode: [E_OUTOFMEMORY/Out of memory], Message: Für diesen Vorgang sind nicht genügend Speicherressourcen verfügbar.
04:13:45.546 (Error): Updating Shader Resource View failed: HRESULT: [0x8007000E], Module: [General], ApiCode: [E_OUTOFMEMORY/Out of memory], Message: Für diesen Vorgang sind nicht genügend Speicherressourcen verfügbar.
2023_07_31-23_31_44_692.log
What can i do?
Thank You for your Support.

Hi @KurtKomell . I'm sorry to hear that. Can you provide more details so I can narrow down the potential problem? Were you using video-playback by any chance?

I use the ndi Input and spout Input to in different PCs. I can send you the exportfolder for the Player.exe.

Oh. I can see that. The NDI-Plugin we're using seems to have some memory and resource-leaks.
Which resolution did you use for the transferred image?

Hi i use 1080p or 720p in both situation the player stop after 4 or 5 hours. It doesnt matter to be spout or ndi in. I think it is a problem of the Nvida rtx. I cannt Test it on a intel system. I do this later. Now i have a  inquirey to show my installation from  7 am till 6 pm. So i would be nice to here from you with a solution. I can load my export folder up and send to you. Maybe i try to reboot the system all 4 hours, thats not the best way but a workaround. Thank you very much.

Hi Kurt. A link to the export-folder would be very useful. You can send me a private DM on discord or post it here.

Hi Pixtur,
here the link zum Folder.
please answer me wehn you get it then i can delete it.
https://1drv.ms/u/s!AmxCgNCjTM1PhfdpGjEu-PHSLpKYWg?e=9UILP3

After some experimentation, I could reproduce a similar problem wit the player: For me the timing was;

It's quite interesting that you had a out of memory exception just before the crash.
But it's quite strange that the suspent-times are sooo close together.
I will try to investigate further.

Some sites recommended to increase TdrDelay but I don't believe that this is related to the current issue.
https://learn.microsoft.com/en-us/windows-hardware/drivers/display/tdr-registry-keys

It looks like the freeze is occurring after 1024^2 frames which probably means there is a resource leak, e.g. in the handling of SRVs (the tier 2 limit for them being 1M). I will try to investigate further.

It took some time to narrow this down but now it should be fixed in the next version.


postCreateProject not executing

After running a fresh install of Sage with composer create-project roots/sage project dev-master, the postCreateProject interactive portion of the install process fails to execute anything.
Here's my output:
troymcginnis@Troys-MacBook-Pro:themes$ composer create-project roots/sage project dev-master
Installing roots/sage (dev-master de27307b820305302fe2c5defd4bbee4e02a1dc3)
  - Installing roots/sage (dev-master master)
    Cloning master

Created project in project
Loading composer repositories with package information
Installing dependencies (including require-dev) from lock file
  - Installing composer/installers (v1.4.0)
    Loading from cache

  - Installing paragonie/random_compat (v2.0.10)
    Loading from cache

  - Installing illuminate/contracts (v5.4.27)
    Loading from cache

  - Installing doctrine/inflector (v1.2.0)
    Loading from cache

  - Installing illuminate/support (v5.4.27)
    Loading from cache

  - Installing illuminate/container (v5.4.27)
    Loading from cache

  - Installing illuminate/events (v5.4.27)
    Loading from cache

  - Installing psr/log (1.0.2)
    Loading from cache

  - Installing symfony/debug (v3.3.6)
    Loading from cache

  - Installing symfony/finder (v3.3.6)
    Loading from cache

  - Installing illuminate/filesystem (v5.4.27)
    Loading from cache

  - Installing illuminate/view (v5.4.27)
    Loading from cache

  - Installing illuminate/config (v5.4.27)
    Loading from cache

  - Installing roots/sage-lib (9.0.0-beta.4)
    Loading from cache

  - Installing symfony/yaml (v3.3.6)
    Loading from cache

  - Installing hassankhan/config (0.10.0)
    Loading from cache

  - Installing brain/hierarchy (2.3.0)
    Loading from cache

  - Installing soberwp/controller (9.0.0-beta.4)
    Loading from cache

  - Installing symfony/polyfill-mbstring (v1.5.0)
    Loading from cache

  - Installing symfony/translation (v3.3.6)
    Loading from cache

  - Installing nesbot/carbon (1.22.1)
    Loading from cache

  - Installing symfony/process (v3.3.6)
    Loading from cache

  - Installing symfony/console (v3.3.6)
    Loading from cache

  - Installing illuminate/console (v5.4.27)
    Loading from cache

  - Installing roots/sage-installer (1.3.1)
    Loading from cache

  - Installing squizlabs/php_codesniffer (2.9.1)
    Loading from cache

paragonie/random_compat suggests installing ext-libsodium (Provides a modern crypto API that can be used to generate random bytes.)
illuminate/support suggests installing symfony/var-dumper (Required to use the dd function (~3.2).)
illuminate/filesystem suggests installing league/flysystem (Required to use the Flysystem local and FTP drivers (~1.0).)
illuminate/filesystem suggests installing league/flysystem-aws-s3-v3 (Required to use the Flysystem S3 driver (~1.0).)
illuminate/filesystem suggests installing league/flysystem-rackspace (Required to use the Flysystem Rackspace driver (~1.0).)
symfony/translation suggests installing symfony/config ()
symfony/console suggests installing symfony/event-dispatcher ()
symfony/console suggests installing symfony/filesystem ()
illuminate/console suggests installing guzzlehttp/guzzle (Required to use the ping methods on schedules (~6.0).)
illuminate/console suggests installing mtdowling/cron-expression (Required to use scheduling component (~1.0).)
Generating autoload files
Do you want to remove the existing VCS (.git, .svn..) history? [Y,n]? Y
> Roots\Sage\Installer\ComposerScript::postCreateProject
troymcginnis@Troys-MacBook-Pro:themes$

As you can see at the end of composer run, the postCreateProject generates no further output.
Thoughts?

weird, can't re-reproduce and we haven't seen any other reports of this
does running composer run-script post-create-project-cmd from the theme directory cause the interactive prompt to start?
have you tried updating composer?
what's your version of php running locally?

Must be an environment issue...
I've updated to composer v1.6.3 and am running php 7.0.8 locally.
Running composer run-script post-create-project-cmd from the theme directory seems to do nothing other than output: > Roots\Sage\Installer\ComposerScript::postCreateProject.
Running the following does work, however:
./vendor/bin/sage meta
./vendor/bin/sage config
./vendor/bin/sage preset


Wrap app in self-executing function

To allow better testing and no longer require global variables.

Fixed in 605e94ec1acdd65b9037b6cf4d688acbec821864


linux kernel: increase build timeout from 2 to 4 hrs

Motivation for this change
We've recently seen a many kernel build timeouts on hydra like this: https://hydra.nixos.org/eval/1481520?filter=linuxPackage  so let's increase the timeout.
We'll see if 4 hours are sufficient (hey, it's a lot faster than chromium builds :smile:)
Please backport to 18.09, ZHF #45960.
Things done

[x] noop, just increased timeout

cc @vcunat @samueldr @thoughtpolice

backported in 10eec001313582d92e9881dcb57cb91364035be6.
@vcunat @samueldr on 18.09, previous timeout was still the default 1 hour, which may explain the aarch64 issues. It had been increased to 2hrs on master before.


Update and rename HeatControl-Core.netkan to HeatControlCore.netkan, with Nertea seal-of-approval

We don't usually change identifiers, it breaks stuff in horrible ways. Is there an extraordinarily good reason for that change?

Standardization. Plus, these are very new. I would be surprised if there was anyone pointing at them yet.
Also note that I did ask to let me handle adding these updates, including the new sub-packs... they were not present yet, thus choosing an indentifier would have fallen to me and there would have been no issue. I only discovered less than an hour ago that someone already added them despite my request to the contrary.

The problem isn't really with things pointing at them but with users having them installed, the clients use identifiers to identify and compare mods so changing those basically means that users who already had e.g. HeatControl-Core installed will now have a client saying they don't and instead they will get an AutoDetected (AD) mod named HeatControlCore. To them it'll be the same mod though since they (GUI users) see the names rather than the identifiers. Changing the name and not the identifier though will work since that'll just be updated on the next Refresh.
As for standardization CKAN doesn't really have one, some older mods like FirespitterCore follow the model proposed in this PR. Newer ones like InterstellarFuelSwitch-Core and IR-Model-Rework-* use dashes. Even some older additions lite RasterPropMonitor-Core use a dash.
You did indeed ask to handle these things and had they been uploaded somewhere closer to the mods being updated there had been no issue. I'm the one who added them since we had users asking for these mods aswell as opening issues and PRs to index them rather than having stale files around. To the best of my ability I also followed the relationship matrix posted on the forums to minimize friction with the files to come.

Well, you could have sent them my way, I would gladly have handled their questions :( Now I get to go over all my stuff again, which I already spent more time on than I expected it to take, fix all the identifiers, re-test, do all of the pull requests again (even those that aren't renames themselves, since most of them ross-reference the wrong identifiers), and despite all of it I end up with a situation I am unhappy with.
Well, there goes an evening. Please reject all my pending pull requests. I'm out of time today, well deal with this tomorrow.

You could just add dashes to your pending PRs and commit the changes, click the "files changed" in the top and then click the pen symbol which will allow you to edit both filename and the file itself and then commit to the branch. The bot will retest everything for you. There's no need to close and restart all PRs.

Adding blocked-on-other label just so we don't accidentally merge something with a differentiated identifier present. Tbh I don't really know which blocked-on-* is more correct so I just grabbed one.

@lOmicronl : I'm here to say that I hugely appreciate the effort you've put into this, and part of that appreciation is me wanting to make sure we make things as easy as possible for you. While changing an extant identifier breaks our model, I've more than sufficient gitomancy to adjust the identifiers on the other PRs as they're merged. If they're good to go, then I'm happy to weave them into the repo personally.
So please, don't close your PRs or feel that you need to re-test them. You are awesome for devoting so much time to this, and we can absolutely make adjustments during the merge process.
Many thanks again,
~ Paul

With the exception of the CTT adjustments, I think I've got everything merged! In general, I have:

Merged all changes except ident renames.
Used provides for NearFuturePropulsionNTRConfigs, giving it an alias. (This is absolutely sanctioned by the spec.)
Am happy to throw provides about for other aliases, but would prefer to do so when the alias difference is substantial (eg; NearFuturePropulsionNTRConfigs vs NearFuturePropulsionExtras).
Almost certainly made a mistake somewhere, because I'm human and it's late.

@lOmicronl , thank you again for all your hard work! I very much appreciate it!

@pjf Thank you for your encouragement and assistance! I spent the entire day being really quite miffed about having (for the lack of a better word) the project pulled out from under my feet without notice, and this helps me feel a lot better.
I must admit, the 'provides' field is probably the one part of the spec that I didn't fully understand, so I steered clear of using it. Creating aliases with it is a pretty neat idea.
Today I'll have to poke at github (the interface is still quite new to me) to find out which of the patches I entered already got pulled in, because I didn't get around to making pull requests for all of them yet. There's probably 3 or 4 left. I'll try to make sure there's not another rename crisis in them before submitting.


"Code can be found here" link is broke

Greetings!
Love the idea. I noticed that the "code can be found here" link in the readme.md file is broke, though.

Thanks! Just fixed it.


populate Suggest iteratively

Help wanted
Unclear statement on how to populate Suggestion list iteratively
Context
Referring to the docs here and here I am trying to populate
s := []prompt.Suggest{
		{Text: "users", Description: "Store the username and age"},
		{Text: "articles", Description: "Store the article text posted by user"},
		{Text: "comments", Description: "Store the text commented to articles"},
	}

iteratively, instead of specifying the items one by one. In particular, my use case is to populate the suggestion list with the keys of a map[string]interface{}. Whenever I try to access and populate the field s.Text I get an error

s.Text undefined (type []prompt.Suggest has no field or method Text)

although the structure Suggest does possess Text as property, does it not?
Do we have a shorthand grammar to do so?

In the example above s is an array of Suggest. In order to access the Text field in one of the Suggest elements you need to index into the array - s[0].Text

You are right, thank you for the clarification!


Application Primary Contact ETL

Looks like that symbol means there is no trailing newline. Still missing semicolons, though probably doesn't matter.


AST changes on Week 5 are not all bolded

The AST addition "Assign(string, exp)" on week 5 is not bolded. First image shows the AST definition on week 4, and second image shows the unbolded addition of the Assign AST on week 5.

Thanks for reporting this! Just fixed it - the Assign constructor is now bolded in this listing.


runc: 1.0.0-rc92 -> 1.0.0-rc93

Motivation for this change
Update runc to the latest release.

apparmor and selinux build tags are now enabled by default
apparmor_parser is not required any more

Things done

[x] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
Built on platform(s)

[x] NixOS
[ ] macOS
[ ] other Linux distributions

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
[x] Tested execution of all binary files (usually in ./result/bin/)
[x] Determined the impact on package closure size (by running nix path-info -S before and after)
[ ] Ensured that relevant documentation is up to date
[x] Fits CONTRIBUTING.md.

cc @NixOS/podman


Window.getComputedStyle does not implement interface Element

Expected Behavior
Diagram shown.
Current Behavior
TypeError: Argument 1 of Window.getComputedStyle does not implement interface Element.
Steps to Reproduce (for bugs)
Just try to draw anything.
Environment

Chart.js version: 2.7.3
Browser name and version: firefox 63.0.3 (64-bit)
Other libs: jQuery 3.3.1

@consciencia please provide a codepen or jsfiddle that reproduces your issue.

Closing due to lack of test case


Bump log4j to 2.17

Signed-off-by: Shenoy Pratik<EMAIL_ADDRESS>Description
Bumped up log4j to 2.17
Issues Resolved
https://cve.mitre.org/cgi-bin/cvename.cgi?name=CVE-2021-45105
https://github.com/opensearch-project/opensearch-build/issues/1365
Check List

[ ] New functionality includes testing.

[ ] All tests pass, including unit test, integration test and doctest

[ ] New functionality has been documented.

[ ] New functionality has javadoc added
[ ] New functionality has user manual doc added

[x] Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Build is failing ...

Build is failing ...

I see version conflict for log4j. Is the core artifact for 1.2.3 ready with log4j 2.17.0?
org.apache.logging.log4j:log4j-api between versions 2.17.0 and 2.16.0

Build is failing ...

I see version conflict for log4j. Is the core artifact for 1.2.3 ready with log4j 2.17.0?
org.apache.logging.log4j:log4j-api between versions 2.17.0 and 2.16.0

Yes, see https://github.com/opensearch-project/OpenSearch/pull/1774

It's pretty clear from ./gradlew :plugin:dependencyInsight --configuration runtimeClasspath --dependency org.apache.logging.log4j:log4j-api that the problem is that the 1.2.3-SNAPSHOT build is bringing in the old log4j.
org.apache.logging.log4j:log4j-api:2.16.0 -> 2.17.0
\--- org.opensearch:opensearch:1.2.3-SNAPSHOT:20211218.163135-5
     +--- project :legacy
     |    \--- runtimeClasspath
     \--- project :opensearch
          +--- runtimeClasspath
          +--- project :legacy (*)
          \--- project :protocol
               +--- project :ppl
               |    \--- runtimeClasspath
               \--- project :sql
                    \--- project :legacy (*)

It looks like we were never able to get a 1.2.3-SNAPSHOT successfully built with that change because of the build failure in performance-analyzer. I PRed https://github.com/opensearch-project/opensearch-build/pull/1387 removing it to see if that fixes it.

Codecov Report

Merging #345 (1f59355) into 1.2 (57ead85) will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##                1.2     #345   +/-   ##
=========================================
  Coverage     99.90%   99.90%
  Complexity     2687     2687
=========================================
  Files           256      256
  Lines          6524     6524
  Branches        420      420
=========================================
  Hits           6518     6518
  Misses            5        5
  Partials          1        1

Flag
Coverage Δ

sql-engine
99.90% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 57ead85...1f59355. Read the comment docs.

@ps48 please backport this to main, and bump main version to 1.3.0


release 1.4.0

Is there anything holding back the release of 1.4.0? commanded and eventstore itself are already 1.4.0 so it might be a good idea to publish this one as well?

Published to Hex as v1.4.0.


Reproductionablity for createjson

should the number of labels be 10?

is this the expected result?

Sounds like according to @arshinmar that it is supposed to be 10. See the DESED dataset section in http://dcase.community/challenge2020/task-sound-event-detection-and-separation-in-domestic-environments


docs: Adjust keyboard shortcuts for macOS users.

Some shortcuts on macOS are different than Windows/Linux ones, specifically:

PgUp -> Fn + Up Arrow
PgDn -> Fn + Down Arrow
End -> Fn + Right Arrow
Enter -> Return

Those shortcuts are present both in the ? hotkeys docs and the user docs.
A possible feature would be to tweak the docs and add info for macOS users, if the user agent suggests they're on a Mac.

This is in templates/zerver/keyboard_shotcuts.html + similar files in templates/zerver/help/.
I think we could do a conditional on User-Agent, but might be worth trying a parenthetical and seeing how that looks, to start.

Was it closed? I don't see it on my mac.

Oh, the PR only did it for the /help/ docs, not here, but still marked itself as fixing this.  Reopened since we still need to do the second (in-app) half.

I implemented tooltips that appear above the keyboard shortcuts with Mac equivalents in PR #3715 for both the keyboard shortcuts modal and the Keyboard shortcuts user doc.

@zulipbot claim

@timabbott @trueskawka Mind taking a look at #3715 that I opened for this issue?

As discussed in #3715, the best way to show this would be to change the content of the docs/modal according to a User Agent detection of the user on a Mac operating system.
Temporarily abandoning this issue as I look into how to implement this. @zulipbot abandon

WIP


WIP do not merge - debugging CI

add --verbose for sometimes-failing test
re https://github.com/joernio/joern/pull/3229

green
https://github.com/joernio/joern/actions/runs/5657570256/job/15326920117?pr=3229#step:4:386


[BUG] Console error is shown if a user enters unsupported year

Describe the bug
In Year field in datepicker, a user can enter the year number. If we enter invalid year number (For example: 1000000) Then a console error is being shown and the calendar is not clickable anymore even though you re enter a valid date.
There should be a boundary on maximum Year that should be used. For example: 9999?
User should not allow to enter any symbols except numbers:
-, +, etc…
Reproduction
Steps to reproduce the behavior:

Go to https://sqrrl.github.io/wc-datepicker/#demo
Change the year to 1000000
Open the console
See the js error

Expected behavior
A clear and concise description of what you expected to happen.
Screenshots
https://ibb.co/NTq67rF
Context
I tested this on your demo.

Device: Macbook Pro
Operating System: MacOS
Browser: Chrome

Thanks for reporting. Will look into it.

Fixed with v0.5.2.

Thanks @Sqrrl  this bug was fixed.


Add functionality to write to a temp file through url arguments

This feature is similar to the existing option that allows url arguments to be passed in as command line arguments. Instead, we create a temporary file in /tmp/ and write the url arguments to this file, separated by newlines. The temporary file name is then passed to the command as a command line argument.
Because of this behaviour, the command line args option and the temporary file option should be mutually exclusive.
We can then use this to pass secret values to the running process as command line arguments are easily visible through process status.

writing to a temp file without cleanup? I'd prefer set it as env

@tsl0922 you are right that with temp file, we are relying on the receiver to delete the file. we considered passing via env var (https://github.com/tsl0922/ttyd/pull/745/) and one side effect is that env vars are easily visible if you run ps e.
While it's true that users with permissions to /proc/<pid>/environ would also have permission to read the temp file, internal security review prefers we reduce the likelihood of accidental information leakage.
Would you prefer if we add both the env and file options? We will only use the file option but maybe others will find the env option helpful too.

@tsl0922 I updated the PR and addressed your comments. Let me know if you have more feedback

@tsl0922 Hi any updates?

@tsl0922 Hi any updates?

@tsl0922 Hi any updates on this PR?

Hi @tsl0922, would you still be interested in this feature?

@tsl0922 hi this patch is a bit outdated, but we are happy to do the work to update it if you want to take this


Checking foreignKey value if exists on the table in related queries

Let's assume that we have a pagination URL like this;
http://localhost:3000/api/users/66/posts

Currently, Axe API doesn't check whether the user id (66) exists on the table. This query will be returned empty anyway. But, it should throw 404.
~> Devs should be able send ignoreParentId~

Soft-delete should be supported by the model's soft-delete field

This issues depends on  #168


Extra-deps ?

In stack, i can use extra-deps to build from github, but how to do that with hpack ?

There's nothing special about extra-deps from hpack's point of view: they're Haskell packages that you can put in your dependencies. Stack has some documentation that may be helpful.


Requests' details are not being prined in the report

Karate 1.0.1 and 1.1.0.RC1
post/get request are not printed in the report for Scenario Outlines. (in regular scenarios the issue doesn't occur)

I'm sorry for such a short description without details, but I just found it and don't have much time for preparing example. This above is a screenshot from my project.
If you have a problem with reproducing the issue I can then prepare some example.
I tested 1.0.0 and it works fine.

@intest I wasted half an hour because it was for DYNAMIC scenario outlines, not just scenario outlines
next time PLEASE provide a way to replicate

@ptrthomas oops... I'm sorry, I didn't realise that there is a difference in executing dynamic and non-dynamic scenario outlines and that this details could be important. I promise to provide such information in a future.
For my excuse - I have also deadlines in work so I was submitting in a hurry :/

@intest no worries. it is also a reminder to myself

OK..
One more thing - I also noticed that in a header/title of executed scenario outline there is only "Scenario: [1.x.yy]" instead of "Scenario Outline: [1.x.yy]", like it was in version 0.9.6 :)
Not sure if it is by purpose or some very trivial bug..

it was wrong earlier. everything is a scenario at runtime.

1.1.0 released


Add in Pos new signatures of operators

Those operators should be augmented with newly implemented class Offset.

Notice: no need for this!
vcl::utils::Offsets inherit from vcl::vect::Vect2. So, the signatures of the operators already embed this class (while not accessing its speicalize accessors/mutators dx() and dy() but there is no mandatory need for this.
--> the first "won't do" issue of this project.


Fix error: "Error: Cannot add route when fastify instance is already started!"

add await to fix "Cannot add route when fastify instance is already started"

@yonathan06

Thanks @LevanKvirkvelia !

@LevanKvirkvelia published with version 3.0.2


Preloaded Sample Data does not match Image in User Guide

Preloaded sample data

User Guide image

A very minor concern but since the sample data presented does not match, should we change to fit it or is it fine as it is?

Will be adding in sample addressbook


Use double to represent coordinates

It might be comfortable to do vector operations.

double value cannot be passed as NTTP.

fixed