DWD integration?

Hey guys,
I was wondering if there's a chance to support the DWD integration to get Official Warning for Germany? :)
https://www.home-assistant.io/integrations/dwd_weather_warnings/

Hey, thanks for the idea! Support for DWD will be added in the next update after this is resolved: https://github.com/home-assistant/core/issues/51502

Added in https://github.com/MrBartusek/MeteoalarmCard/commit/baf667ce8056408343a44e6987d3fd85a1ce85e3


Remove the SSoT CSVs from the top-level directory and update website references

Website RMD should reference CSV at the package level

Fixed by https://github.com/OHDSI/GIS/commit/952093340b0b49b872e61a285393d2532962e16d


Enhancement Request: Alphabetical sorting of item types

Wondered if the starting items could be alphabetically organized by type. So common items in alphabetical order, then unique items, then spells. A bubble sort based on the item name and type or if needed, to go into each asset and assign a value that can be sorted. Problem with the latter is that when new expansions come out, numbers have to be adjusted, but it wouldn't be that too hard if using existing names and types would not be possible.
Not at all urgent, but something that come up when playing recently.

Simple to do, but going to fix the 1.4 white screen issue first...


Update use-case-naming-conventions.md

Added link to ODA C&C BDD guidelines aat https://projects.tmforum.org/wiki/display/TAC/ODA+++Behaviour+Driven+Design(BDD)+Feature+Guidelines

Cross link ODA CA with ODA Conformance BDD guidelines


CelStub implementation

implemented a fake cel library to work with while we figure out how to access the real one

@ashithasantosh

PR#23627


Updated Bloch sphere

Use Bloch sphere from QuTiP.

Summary
Use Bloch sphere from QuTiP.  This supersedes #423.
Details and comments
Fixes z-axis label issue in previous PR.

@nonhermitian I think we need a line in changelog here too. Then I can merge.


⚠ SceneTime has degraded performance

In 0a7c1a0, SceneTime ($ST) experienced degraded performance:

HTTP code: 200
Response time: 1456 ms

Resolved: SceneTime performance has improved in 9853bfc after 7 minutes.


Issues building in docker and where to find a stable version?

pls advise on installing this library
on the develop branch(default)
building in docker according to the readme fails with:
[100%] Linking CXX executable ../bin/MIOpenDriver
/opt/rocm/lib/libamd_comgr.so.1: undefined reference to<EMAIL_ADDRESS>clang-10: error: linker command failed with exit code 1 (use -v to see invocation)
driver/CMakeFiles/MIOpenDriver.dir/build.make:129: recipe for target 'bin/MIOpenDriver' failed
make[2]: *** [bin/MIOpenDriver] Error 1
CMakeFiles/Makefile2:5170: recipe for target 'driver/CMakeFiles/MIOpenDriver.dir/all' failed
make[1]: *** [driver/CMakeFiles/MIOpenDriver.dir/all] Error 2
Makefile:160: recipe for target 'all' failed
make: *** [all] Error 2
Command failed: ['/usr/bin/cmake', '--build', '/usr/local/cget/build/tmp-4dfe9a83dfc240a3a52a268db1fbd00c/build', '--config', 'Release', '--', '-j', '8']
Failed to build package ROCmSoftwarePlatform/MIOpen
root@7825d58ac070:/#

i also tried the branches master and rocm and got
N: See apt-secure(8) manpage for repository creation and user configuration details.
E: Failed to fetch http://archive.ubuntu.com/ubuntu/dists/xenial/universe/source/Sources  System error resolving 'archive.ubuntu.com:80' - getaddrinfo (2: No such file or directory)
E: Failed to fetch http://archive.ubuntu.com/ubuntu/dists/xenial-updates/universe/source/Sources  System error resolving 'archive.ubuntu.com:80' - getaddrinfo (2: No such file or directory)
E: Failed to fetch http://security.ubuntu.com/ubuntu/dists/xenial-security/universe/source/Sources  System error resolving 'security.ubuntu.com:80' - getaddrinfo (2: No such file or directory)
E: Failed to fetch http://archive.ubuntu.com/ubuntu/dists/xenial-backports/main/binary-amd64/Packages  System error resolving 'archive.ubuntu.com:80' - getaddrinfo (2: No such file or directory)
E: Some index files failed to download. They have been ignored, or old ones used instead.
Error: error building at STEP "RUN apt-get update && DEBIAN_FRONTEND=noninteractive apt-get install -y curl apt-utils wget software-properties-common": error while running runtime: exit status 100

i also tried apt installing it in a newer rocm docker container but it migraphx wouldnt import in python (undefined symbol: _Py_ZeroStruct).
furthermore onnxruntime with migraphx backend also didnt work out.
i am confused. where would i get a working instance of this library, or stable releases? preferably just a docker container which i can use for migraphx python api.
my aim was just to evaluate performance of onnx models with amd gpu acceleration (specific for inference), and maybe learn to optimize/ integrate a onnx model on amdgpu

The error: undefined symbol: _Py_ZeroStruct is most likely due to the version of python being different than the one used to build MIGraphX. We have an ongoing issue #590 to deal with this.
If you are looking to use a docker container with MIGraphX, I suggest using the following:
docker pull mevermeulen/rocm-migraphx:3.7
docker run --device=/dev/kfd --device=/dev/dri -it mevermeulen/rocm-migraphx:3.7
[in container]: export PYTHONPATH=/src/AMDMIGraphX/build/lib/
[in container]: cd /src/AMDMIGraphX/build; cmake -DPYTHON_EXECUTABLE=/usr/bin/python3 ..
[in container]: make migraphx_py- jN # (N cpu cores)

When you try python3, it should allow you to import migraphx if done correctly.
Alternatively, if you want to test our ONNX runtime EP, follow the docker instructions here.

great, because of permissions had to use:
sudo podman  run --network=host --device=/dev/kfd --device=/dev/dri --group-add video --ipc=host -it mevermeulen/rocm-migraphx:3.7

and it worked with around 10ms/image on resnet50  (and vega64) sample code adapted from onnxruntime.
the onnxruntime from here doesnt build; but
this will suffice for my experiments for now


Provide a good example for using  'setState' in NotebookRendererApi

Testing #99001
Maybe this is just my lack of understand with the notebook API, but all of the other methods in INotebookRendererApi seem to have clear instructions on what they're used for (onWillDestroyCell and onDidCreateCell are good examples). But for setState and getState I'm a bit unsure of how i'm suppose to use this. It seems as if once I set this in the entry point for the renderer the state is persisted, so this makes it a bit ambiguous on its use. Maybe if there was a good example for this.

Thanks, merging into https://github.com/microsoft/vscode/issues/99320. I want to move those types from a copypasta'd .d.ts into its own package with appropriate documentation 🙂


Update plotting API

This implements the plotting API as discussed in https://github.com/astropy/regions/issues/12

add plot method to base class
Add abstract make_patch method to base class
Implement make_patch for Circle regions as an example

The testing should probably be done as part of https://github.com/astropy/regions/pull/20

Can I merge this?

@joleroi - apart from the naming suggestion, looks good to me!

(@joleroi - It looks like you have both tabs and spaces used as indents. For most editors you can set to use spaces only for tabs as well, so it's worth opting in it).

@bsipocz that's very well possible :smile: I switched to vim on monday after having used emacs for almost 10 years now (I feel like a 5 year old when typing). May the editor gods have mercy upon my soul ...

Switching to vim from emacs? :cry:
Should I call 999, or would you like to talk about it?

I would like to show you my awesome working environment that took me 4 days to set up but will make me so much more productive in the future :+1:

Do you still believe in fairy tales? ;)

@bsipocz  Can you please have a look at appveyor? Maybe one just has to restart it but I never figured out how ...

@joleroi -looks like a fluke, I've restarted it.
If you login to appveyor there should be a "restart-PR" button on the top right part of the actual build. If you don't see that then Christoph needs to add you appveyor admin rights.

I don't see this button. @cdeil can you give me appveyor admin rights?
Ok to merge now?

I don't see the restart button on Appveyor for the astropy/regions repo either.
Probably only @astrofrog and @keflavich have such powers?
https://github.com/orgs/astropy/teams/regions-developers

AFAIK appveyor has different rights atos github, e.g. I have it for regions as well as most astropy repos, though not having commit rights for most of them.

@cdeil - you now have appveyor privileges (actually for all astropy repos). @bsipocz - can you log in to appveyor and let me know what email address you've used to sign up? (you can let me know by email)

@astrofrog - Thanks.
Just in case others face this: I had to log out and log back in and select "Astropy account" at login to be able to get these Appveyor admin powers for Astropy repos. It still shows me logged in as Christoph Deil after though, so that is pretty confusing.
Anyways: green light from appveyor for this PR now.

@cdeil - Yep, that's one of the many annoying things about appveyor ;)

Ah yes, @bsipocz you already have access to all repos on appveyor :)

@astrofrog - :+1: all, or most, it's the same as I haven't tried to do anything with may of them anyway ;)


Add ZZZ space

Add space for ...
Etherscan: https://etherscan.io/address/0xc75f15ada581219c95485c578e124df3985e4ce0
CoinGecko: https://www.coingecko.com/en/coins/zzz-finance
Website: https://zzz.finance/
Twitter: https://twitter.com/zzzfinance

@gokaiorg, made the changes as requested. Let me know if there is any further issues!


Notify processes to refresh their environment variables

Closes https://github.com/axodotdev/cargo-dist/issues/1614
This currently only handles the powershell installer, not msi. If someone wants to add and test msi support that would be great! Also, can someone please take over updating snapshot tests for me? I tried but got weird diffs like this:

And a few other failures I couldn't figure out.

The opening post here https://github.com/axodotdev/cargo-dist/issues/1614#issue-2727351448 discusses the problem in detail.
I opted to bring in the (well known?) implementation from the powershell gallery
https://www.powershellgallery.com/packages/PSCI/1.0.4/Content/core\utils\Update-EnvironmentVariables.ps1
I tested this on a Windows machine and this does indeed seem to work for me! Here's a video of me showing that

previously I did not have .local/ in the registry
then I ran the patched installer
then it was in the registry (but still the cli tool air was not accessible yet)
then I restarted Powershell and air was available

https://vimeo.com/1040789276?share=copy#t=0

@fdcastel noted that it did not work for him. I believe I can explain that. Likely what happened was:

He ran the old installer once. It updated the registry, but did not tell processes to update their environments
He patched the old installer with the code in this PR, but did not restart his machine
He ran the patched installer. It detected that the registry had been updated already, and did not update it again (thus, not pushing an environment refresh notification).
Because no refresh notification was pushed, it looks like nothing happened

Running Get-Item -Path "HKCU:\Environment" would likely show an updated Path for him, even though ruff won't be accessible at the command line until after a system restart.

Hi! Thank you very much for taking this on!
I can take over updating the snapshot tests. :slightly_smiling_face:

I tried but got weird diffs like this:

Ah, I bet that comes down to the cargo insta version. 1.41.0 added support for a second snapshot format so it added the snapshot_kind: key; if you're using an older version, it'll remove those keys when updating snapshots. That's not a big deal though, for now insta will transparently read snapshots whether it's got them or not.

I've pushed an update with snapshots and a couple minor tweaks:

Silencing a couple PSScriptAnalyzer errors that aren't relevant to us, and
Linking to the source and version number of the function.

@fdcastel makes a good point in https://github.com/axodotdev/cargo-dist/issues/1614#issuecomment-2555309058 that I do think should be considered before merging
I thought for sure SetEnvironmentVariable() was only for the current process, but it does seem like it can modify the user registry with something like this:
Environment.SetEnvironmentVariable(userEnvVar, user, EnvironmentVariableTarget.User);

If target is EnvironmentVariableTarget.User, the environment variable is stored in the HKEY_CURRENT_USER\Environment key of the local computer's registry. It is also copied to instances of File Explorer that are running as the current user. The environment variable is then inherited by any new processes that the user launches from File Explorer.

The main thing that strikes me as odd is why this hasn't been recommended by any online resources that I found! It does seem "more official" than this approach though.
At the very bottom in "Applies to" it looks like it does support quite old .Net
https://learn.microsoft.com/en-us/dotnet/api/system.environment.setenvironmentvariable?view=net-9.0
https://learn.microsoft.com/en-us/dotnet/api/system.environmentvariabletarget?view=net-9.0

@DavisVaughan, absolutely!
As a Windows user and programmer for, err... longer than I care to admit, I can vouch for this method being ancient. But it works😉.
But it is practically a newborn compared to those ancient Win32 messages -- which predate even the .NET framework itself! 😄

Whew, okay, holy cow. Windows powershell is SUCH a minefield with anything PATH related.
I have determined that there are a few issues, all related to the fact that for PATH in particular, it is not uncommon for users to use expandable variables in their PATH, like: PATH = \.local\bin;%EXPANDME%, where they also have another environment variable of EXPANDME = 'my\path'. The idea is that when you print PATH at Command Prompt or Powershell, those get "expanded" into the underlying value somewhat dynamically.
The issue with SetEnvironmentVariable()
SetEnvironmentVariable() cannot be used for PATH. It is a very useful tool, but not for PATH. In the Registry it forcibly changes PATH from a REG_EXPAND_SZ data type to a REG_SZ data type. This means that %EXPANDME% will be in the PATH but will no longer ever expand to the right value.
There is no workaround to SetEnvironmentVariable() for this. It will always set the data type to REG_SZ.
The current use of Get-ItemPropertyValue is already expanding
The way cargo-dist currently works is to "get" the current Path value, tweak as required, and then re "set" it.
The problem is that currently "get"ting the Path value using Get-ItemPropertyValue is expanding it!
https://github.com/axodotdev/cargo-dist/blob/7872825c67f02f23d483432499fb394a9405c8de/cargo-dist/templates/installer/installer.ps1.j2#L517
i.e. from the above example %EXPANDME% would be expanded into my\path as we retrieved it, then we'd hardcode it back to my\path as we "set" the Path, meaning if I update EXPANDME in the future then my Path won't respond to the change anymore. I believe it has already permanently expanded my %NVM_HOME% and %NVM_SYMLINK% variables 😬.
Here is a way to avoid expansion:
$Item = Get-Item -LiteralPath 'registry::HKEY_CURRENT_USER\Environment'
$Item.GetValue('Path', '', 'DoNotExpandEnvironmentNames')

The current use of New-ItemProperty is forcing a REG_SZ type
Right here: https://github.com/axodotdev/cargo-dist/blob/7872825c67f02f23d483432499fb394a9405c8de/cargo-dist/templates/installer/installer.ps1.j2#L539C13-L539C29
Note -PropertyType String. That causes the Path to get stored as REG_SZ, which is the same problem as SetEnvironmentVariable(). Luckily, if we use -PropertyType ExpandString then it will correctly get stored as REG_EXPAND_SZ.
You can see this issue in this screen shot which was taken after using the current version of the installer. See how everything else is REG_EXPAND_SZ?

Is there no hope?
There is an excellent post all about this here:
https://stackoverflow.com/questions/69236623/adding-path-permanently-to-windows-using-powershell-doesnt-appear-to-work/69239861#69239861
It includes an Add-Path helper that solves all of these problems and more:

It uses GetValue('Path', '', 'DoNotExpandEnvironmentNames') when retrieving the current Path
It uses -Type ExpandString when creating/updating the Path
It broadcasts WM_SETTINGCHANGE by utilizing [Environment]::SetEnvironmentVariable() to create and then immediately remove a dummy environment variable, which has the side effect of sending out WM_SETTINGCHANGE. Pretty clever I think. And uses the "officially exposed" API to broadcast that message.
It even updates the current Path by modifying $env:Path before it exits, so you don't even technically have to restart your shell (we could remove this part if it makes us uncomfortable)


215 - Bad Authentification data

Hi,
When I start setup_welcome_messages.rb with heroku, I get this error. The oauth is broken ?
Getting welcome message list.
GET ERROR occurred with /1.1/direct_messages/welc
ome_messages/list.json:
Error: #Net::HTTPBadRequest:0x0000000001f53e48
{"errors":[{"code":215,"message":"Bad Authenticat
ion data."}]}
Message IDs:
./scripts/setup_welcome_messages.rb:224:in : undefined method `each' for nil:NilClass (NoM
ethodError)
Thank for helping me :(

And the same thing for setup_webhooks.rb...
Setting a webhook configuration... POST ERROR occurred with /1.1/account_activity/webhooks.json?url=https%3A%2F%2Flegacybotdm.herokuapp.com%2Flegacybotdm, request: Error code: 400 #<Net::HTTPBadRequest:0x0000000002250358> Error Message: {"errors":[{"code":215,"message":"Bad Authentication data."}]} {"code"=>215, "message"=>"Bad Authentication data."}


AttributesTable: remove from results

Hey @tmcgee!
Is there a nice way to remove a record from results? Let's say that I did spatial Search and then I want to remove one or some of the resulted records, maybe through a custom column or context menu in hovered line of table. I know how to "inject" custom columns there, my problem is to interact with the table data.
Thanks!

Maybe with populateGrid topic publication? Or there is a more polished way?

I digged into AttributesTable stuff and now I'm working to include this option:

The idea is to remove graphics from results (highlights and all) and the record from table.
Valid?

@carrbrpoa Using a menu option is what I would do though not sure that a Remove option belongs in the Clear menu. Perhaps create a new separate button? @roemhildtg started a discussion about adding custom buttons is in issue #69.

Actually I intend to contribute this feature to AttributeTable, others could benefit from it.
The goal is to clear selected lines of results grid and purple/highlighted/whatever circles around the found features. I could put it in another menu, no problem, just seemed ok to me in Clear.


Remove use of vtk during mmg compilation

Fix compilation error when more than one vtk is compiled on the laptop we do not need vtk in mmg

oki, and milestone added


[R] Collect crashes on R when partioning col is in parquet files and in subfolder names

Describe the bug, including details regarding any error messages, version, and platform.
Building datasets from folders, subfolders and parquet files can make R arrow crashes:
Here is the reprex (run the 3 tests separatly):
# test one hive field in parquet and folder name crashes --------
library(tidyverse)
data <- tibble(
  x = 1:10,
  g = floor(0:9/5))
if(fs::file_exists("/tmp/test")) fs::dir_delete("/tmp/test")
# building subfolders
walk(0:1, ~{
  dd <- data |> filter(g==.x)
  fn <- str_c("/tmp/test/g=", .x, "/part-0.parquet")
  fs::dir_create(str_c("/tmp/test/g=", .x))
  arrow::write_parquet(dd, fn)})
arrow::open_dataset("/tmp/test/g=1") |> collect() # ok
arrow::open_dataset("/tmp/test/g=0") |> collect() # ok
arrow::open_dataset("/tmp/test/")  |> collect()  # crashes

# test two hive field in parquet and not in folder name ok --------
library(tidyverse)
data <- tibble(
  x = 1:10,
  g = floor(0:9/5))
if(fs::file_exists("/tmp/test")) fs::dir_delete("/tmp/test")
walk(0:1, ~{
  dd <- data |> filter(g==.x)
  fn <- str_c("/tmp/test/", .x, "/part-0.parquet")
  fs::dir_create(str_c("/tmp/test/", .x))
  arrow::write_parquet(dd, fn)})
arrow::open_dataset("/tmp/test/1") |> collect() # pass
arrow::open_dataset("/tmp/test/0") |> collect() # pass
arrow::open_dataset("/tmp/test/")  |> collect()  # pass

# test three hive field not in parquet but in folder name ok --------
library(tidyverse)
data <- tibble(
  x = 1:10,
  g = floor(0:9/5))
if(fs::file_exists("/tmp/test")) fs::dir_delete("/tmp/test")
walk(0:1, ~{
  dd <- data |> filter(g==.x) |> select(-g)
  fn <- str_c("/tmp/test/g=", .x, "/part-0.parquet")
  fs::dir_create(str_c("/tmp/test/g=", .x))
  arrow::write_parquet(dd, fn)})
arrow::open_dataset("/tmp/test/g=1") |> collect() # pass
arrow::open_dataset("/tmp/test/g=0") |> collect() # pass
arrow::open_dataset("/tmp/test/")  |> collect() # pass

Using arrow 15.0.1, MacOS 14.4, RStudio, R 4.3.3
Component(s)
R

Hey @xtimbeau, I can't reproduce this, I get,
> arrow::open_dataset("/tmp/test/")  |> collect()  # crashes
Error in `arrow::open_dataset()`:
! Type error: Unable to merge: Field g has incompatible types: double vs int32

I wonder if this is related to what's crashing your session in https://github.com/apache/arrow/issues/40627. Similar to that one, attaching a debugger as in https://arrow.apache.org/docs/r/articles/developers/debugging.html#running-r-code-with-the-c-debugger-attached would be the best next step here.


Feedback is not triggered after audio channel volume is changed from Companion

To reproduce the error:

Create a button that sets the volume of an audio channel
Create feedback on the button that changes the button background based on the set volume
Press the button

The feedback doesn't run if the volume is changed from Companion. If you change the volume on the RCV itself, then the feedback runs as expected.

This is resolved in the next release.


Update dependencies and things

Is there gonna be a release with this 28 update? It looks like the argument of TabLayout#addOnTabSelectedListener in the design support lib has been changed to BaseOnTabSelectedListener, from OnTabSelectedListener. Ran into NoSuchMethod exception at runtime until the library was recompiled with 28.

I didn't plan on it. Maybe I can before the whole library gets rewritten...

it'd be great if there will be a release. for a large code base, the eventual migration to androidx is probably better done in stages. but that's just my 2 cents.


DockviewApi.toJSON doesn't include panel titles

Hi, I absolutely love the work you're doing with this library :), and am trying to use it.
Describe the bug
I think I've run into a bug where the panel title is not included in the JSON, causing the title to reset to the id when you refresh (persistent layout).
Steps to reproduce the behavior:

Create a panel with a title, the panel renders with the correct title.
Check DockviewApi.toJSON()
See blank title

Expected behavior
Expected title to be included in the JSON
{
   "id":"xlfqnma9wioq948mmf6mh7u2",
   "contentComponent":"heatmap",
   "params":{
      "title":"Heatmap"
   },
   "title":""
}

Thank you and thanks for the report. Which version are you using?
I have an example here using the latest version 1.7.2 which seems to persist and reload a custom panel title but I may be missing something. You might be able to adjust my example to "break it"?
https://codesandbox.io/p/sandbox/github/mathuo/dockview/tree/master/packages/docs/sandboxes/layout-dockview

I think I've narrowed it down.
It seems to happen only when I have a title, and a prop called title.
  api.addPanel({
    id: "panel_1",
    component: "default",
    // title here
    title: "Heatmap",
    params: {
      // title here also
      title: "Heatmap",
    },
  });

Reproducible codesandbox:
view link: https://lnz49u-3000.csb.app/
https://codesandbox.io/p/sandbox/stoic-napier-lnz49u?file=%2Fsrc%2Fapp.tsx%3A26%2C1-33%2C6

Click reset Layout, title of panel_1 should be Heatmap
Refresh, title changes to panel_1

https://github.com/mathuo/dockview/assets/36898190/22b73b73-5ce4-4885-85ee-8dcc1ed85b21

Sandbox example using the build created from this branch as evidence of a working fix.
https://codesandbox.io/s/layout-dockview-forked-2nfmmq

That seems great!

1.7.3 published with fix - thanks for the help in finding the bug

I think I've discovered another related bug:
If I use api.updateParameters inside a panel, it resets the title, even though the original title was not in the params

Damn, sorry yeah I see this - seems to be an existing bug again. I will take a deeper look at this logic and add tests.

Sandbox example using a copy that has these changes https://github.com/mathuo/dockview/pull/265 here.
Shows examples of both api.setTitle and api.updateParameters being used and covering the case where somebody may name a custom parameter title.
Looks good to me currently, will take some more checks too.

I think I'm still seeing the bug, gonna try and make a sandbox

My bad, just had to clean node_modules.
Looks good, Thanks!

v.1.7.4 published with fixes


Bandcamp: "ValueError: unknown url type" randomly happening

Hello!
I have an error that seems to randomly happen when downloading bandcamp content. I apologize in advance for the difficulties to reproduce the bug, but it's been happening in all my albums downloads recently.
For instance I was downloading this album http://music.gamechops.com/album/spindash-2 with the following command:
youtube-dl -x  -c -R 20 --audio-format vorbis --autonumber-size 2  -o "%(autonumber)s - %(title)s.%(ext)s" http://music.gamechops.com/album/spindash-2

And here is the error that may pop randomly when downloading a song:
Traceback (most recent call last):
  File "/usr/bin/youtube-dl", line 9, in <module>
    load_entry_point('youtube-dl==2015.9.9', 'console_scripts', 'youtube-dl')()
  File "/usr/lib/python2.7/site-packages/youtube_dl/__init__.py", line 410, in main
    _real_main(argv)
  File "/usr/lib/python2.7/site-packages/youtube_dl/__init__.py", line 400, in _real_main
    retcode = ydl.download(all_urls)
  File "/usr/lib/python2.7/site-packages/youtube_dl/YoutubeDL.py", line 1658, in download
    url, force_generic_extractor=self.params.get('force_generic_extractor', False))
  File "/usr/lib/python2.7/site-packages/youtube_dl/YoutubeDL.py", line 671, in extract_info
    return self.process_ie_result(ie_result, download, extra_info)
  File "/usr/lib/python2.7/site-packages/youtube_dl/YoutubeDL.py", line 724, in process_ie_result
    extra_info=extra_info)
  File "/usr/lib/python2.7/site-packages/youtube_dl/YoutubeDL.py", line 671, in extract_info
    return self.process_ie_result(ie_result, download, extra_info)
  File "/usr/lib/python2.7/site-packages/youtube_dl/YoutubeDL.py", line 832, in process_ie_result
    extra_info=extra)
  File "/usr/lib/python2.7/site-packages/youtube_dl/YoutubeDL.py", line 724, in process_ie_result
    extra_info=extra_info)
  File "/usr/lib/python2.7/site-packages/youtube_dl/YoutubeDL.py", line 671, in extract_info
    return self.process_ie_result(ie_result, download, extra_info)
  File "/usr/lib/python2.7/site-packages/youtube_dl/YoutubeDL.py", line 717, in process_ie_result
    return self.process_video_result(ie_result, download=download)
  File "/usr/lib/python2.7/site-packages/youtube_dl/YoutubeDL.py", line 1328, in process_video_result
    self.process_info(new_info)
  File "/usr/lib/python2.7/site-packages/youtube_dl/YoutubeDL.py", line 1590, in process_info
    success = dl(filename, info_dict)
  File "/usr/lib/python2.7/site-packages/youtube_dl/YoutubeDL.py", line 1532, in dl
    return fd.download(name, info)
  File "/usr/lib/python2.7/site-packages/youtube_dl/downloader/common.py", line 342, in download
    return self.real_download(filename, info_dict)
  File "/usr/lib/python2.7/site-packages/youtube_dl/downloader/http.py", line 60, in real_download
    data = self.ydl.urlopen(request)
  File "/usr/lib/python2.7/site-packages/youtube_dl/YoutubeDL.py", line 1865, in urlopen
    return self._opener.open(req, timeout=self._socket_timeout)
  File "/usr/lib64/python2.7/urllib2.py", line 423, in open
    protocol = req.get_type()
  File "/usr/lib64/python2.7/urllib2.py", line 285, in get_type
    raise ValueError, "unknown url type: %s" % self.__original
ValueError: unknown url type: //popplers5.bandcamp.com/download/track?enc=mp3-128&fsig=b4f344e93c9e69e7bd735bc2463128c4&id=3437592711&stream=1&ts=1443966805.0

Hence I has to restart the download where it stopped (using  --playlist-start) each time the error happened, and I eventually managed to download the whole album.

That was fast. Thanks! :)

This is still happening for me on master, @dstftw.
%  youtube-dl https://suduaya.bandcamp.com/album/beyond-galaxies
[Bandcamp:album] beyond-galaxies: Downloading webpage
[download] Downloading playlist: Beyond Galaxies
[Bandcamp:album] playlist Beyond Galaxies: Collected 9 video ids (downloading 9 of them)
[download] Downloading video 1 of 9
[Bandcamp] 1-feel-the-moment: Downloading webpage
Traceback (most recent call last):
  File "/usr/bin/youtube-dl", line 9, in <module>
    load_entry_point('youtube-dl==2015.10.13', 'console_scripts', 'youtube-dl')()
  File "/usr/lib/python3.5/site-packages/youtube_dl/__init__.py", line 410, in main
    _real_main(argv)
  File "/usr/lib/python3.5/site-packages/youtube_dl/__init__.py", line 400, in _real_main
    retcode = ydl.download(all_urls)
  File "/usr/lib/python3.5/site-packages/youtube_dl/YoutubeDL.py", line 1665, in download
    url, force_generic_extractor=self.params.get('force_generic_extractor', False))
  File "/usr/lib/python3.5/site-packages/youtube_dl/YoutubeDL.py", line 671, in extract_info
    return self.process_ie_result(ie_result, download, extra_info)
  File "/usr/lib/python3.5/site-packages/youtube_dl/YoutubeDL.py", line 832, in process_ie_result
    extra_info=extra)
  File "/usr/lib/python3.5/site-packages/youtube_dl/YoutubeDL.py", line 724, in process_ie_result
    extra_info=extra_info)
  File "/usr/lib/python3.5/site-packages/youtube_dl/YoutubeDL.py", line 671, in extract_info
    return self.process_ie_result(ie_result, download, extra_info)
  File "/usr/lib/python3.5/site-packages/youtube_dl/YoutubeDL.py", line 717, in process_ie_result
    return self.process_video_result(ie_result, download=download)
  File "/usr/lib/python3.5/site-packages/youtube_dl/YoutubeDL.py", line 1295, in process_video_result
    format['http_headers'] = self._calc_headers(full_format_info)
  File "/usr/lib/python3.5/site-packages/youtube_dl/YoutubeDL.py", line 1181, in _calc_headers
    cookies = self._calc_cookies(info_dict)
  File "/usr/lib/python3.5/site-packages/youtube_dl/YoutubeDL.py", line 1188, in _calc_cookies
    pr = compat_urllib_request.Request(info_dict['url'])
  File "/usr/lib/python3.5/urllib/request.py", line 268, in __init__
    self.full_url = url
  File "/usr/lib/python3.5/urllib/request.py", line 294, in full_url
    self._parse()
  File "/usr/lib/python3.5/urllib/request.py", line 323, in _parse
    raise ValueError("unknown url type: %r" % self.full_url)
ValueError: unknown url type: '//popplers5.bandcamp.com/download/track?enc=mp3-128&fsig=cdf28c8d0a3e10a7857dd7a33c4e26c4&id=2823640413&stream=1&ts=1444409320.0'

+1

Fixed in 2015.10.16.


Files with '+' in their name not being excluded when in excluded paths

If I have a file called say HomeViewSpec+Rotation.swift in the excluded folder UnitTests and make a change to it in a PR, the plugin will incorrectly lint this file 🤕
I believe it's the escaping of the + which is messing with it. I'll attempt a PR to fix this...

Interesting, thanks for opening an issue! A PR would be lovely but if you can't get to it I can take a look next week.

No worries, turned out to be a simple fix. Nice to do a little bit of ruby again!


Clarify dashes are required for openssl list command

Fixes #19013
CLA: trivial

Checklist

Agree trivial

24 hours has passed since 'approval: done' was set, but as this PR has been updated in that time the label 'approval: ready to merge' is not being automatically set.  Please review the updates and set the label manually.

Merged, thanks for the contribution.

This appears to have broken make doc-nits:
/usr/bin/perl ./util/find-doc-nits -c -n -l -e
doc/man1/openssl.pod: openssl does not implement -cipher-algorithms
doc/man1/openssl.pod: openssl does not implement -cipher-commands
doc/man1/openssl.pod: openssl does not implement -digest-algorithms
doc/man1/openssl.pod: openssl does not implement -digest-commands
doc/man1/openssl.pod: openssl does not implement -mac-algorithms
doc/man1/openssl.pod: openssl does not implement -public-key-algorithms
doc/man1/openssl.pod: openssl does not implement -standard-commands
doc/man1/openssl.pod:1: SYNOPSIS entry B<-standard-commands> missing from OPTIONS
doc/man1/openssl.pod:1: SYNOPSIS entry B<-digest-commands> missing from OPTIONS
doc/man1/openssl.pod:1: SYNOPSIS entry B<-cipher-commands> missing from OPTIONS
doc/man1/openssl.pod:1: SYNOPSIS entry B<-cipher-algorithms> missing from OPTIONS
doc/man1/openssl.pod:1: SYNOPSIS entry B<-digest-algorithms> missing from OPTIONS
doc/man1/openssl.pod:1: SYNOPSIS entry B<-mac-algorithms> missing from OPTIONS
doc/man1/openssl.pod:1: SYNOPSIS entry B<-public-key-algorithms> missing from OPTIONS

Hmmm, actions weren't enabled in this PR, right (because it apparently needs to be enabled once on per-user basis)?
This goes to show that we need to enable running actions whenever we see it not being so...

@tmshort  yes I noticed that was an issue - I have started looking at the Perl in find-doc-nits to see how it needs to be fixed.
@levitte Is that a suggestion for me?  I'm able to run 'make doc-nits' and view the problem locally.
Sorry - this was supposed trivial way to get involved with the project....... I'm happy to continue to dig into it.

See #19044

@levitte Is that a suggestion for me?

Ah, no, sorry, that was to @openssl, especially those among us who admin this repo. There's a button we see that we need to press to enable github actions to run on PRs that you (@crox) make. We didn't, and thereby didn't see that failing doc checks, which are otherwise caught by our actions setup.


Configure eslint-plugin-jsx-a11y

eslint-plugin-jsx-a11y is already present in our package.json but hasn't been configured yet. Adding this to our linter will prevent accessibility issues on the website.
Here are the docs for configuring it.
If possible, try and solve all the lint issues that are found due to adding this plugin.

Thank you so much @haideralipunjabi!!

Fixes #552


docker alpine dockerfile突然出现问题

错误如下：
Step 9/10 : RUN wget -O $USER_HOME/version.json https://api.github.com/repositories/131236938/git/refs/heads/master     && git clone https://github.com/drogonframework/drogon $DROGON_INSTALLED_ROOT
---> Running in b4440f40220f
--2022-12-19 22:53:55--  https://api.github.com/repositories/131236938/git/refs/heads/master
Resolving api.github.com (api.github.com)... <IP_ADDRESS>
Connecting to api.github.com (api.github.com)|<IP_ADDRESS>|:443... connected.
HTTP request sent, awaiting response... 200 OK
Length: 394 [application/json]
Saving to: '/drogon/version.json'
 0K                                                       100% 7.79M=0s

2022-12-19 22:53:55 (7.79 MB/s) - '/drogon/version.json' saved [394/394]
Cloning into '/drogon/install'...
Removing intermediate container b4440f40220f
---> 4412f172bdfc
Step 10/10 : RUN cd $DROGON_INSTALLED_ROOT     && sed -i 's/bash/sh/' ./build.sh     && ./build.sh
---> Running in 0a49de52251d
Submodule 'trantor' (https://github.com/an-tao/trantor.git) registered for path 'trantor'
Cloning into '/drogon/install/trantor'...
Submodule path 'trantor': checked out '625458079fd4344dba2f5e9093596fe8b9d4fa0c'
Created building folder: ./build
Entering folder: ./build
Start building drogon ...
-- The C compiler identification is GNU 11.2.1
-- The CXX compiler identification is GNU 11.2.1
-- Detecting C compiler ABI info
-- Detecting C compiler ABI info - failed
-- Check for working C compiler: /usr/bin/gcc
-- Check for working C compiler: /usr/bin/gcc - broken
-- Configuring incomplete, errors occurred!
See also "/drogon/install/build/CMakeFiles/CMakeOutput.log".
See also "/drogon/install/build/CMakeFiles/CMakeError.log".
CMake Error at /usr/share/cmake/Modules/CMakeTestCCompiler.cmake:69 (message):
The C compiler
"/usr/bin/gcc"

is not able to compile a simple test program.
It fails with the following output:
Change Dir: /drogon/install/build/CMakeFiles/CMakeTmp

Run Build Command(s):/usr/bin/make -f Makefile cmTC_f8d99/fast && /usr/bin/make  -f CMakeFiles/cmTC_f8d99.dir/build.make CMakeFiles/cmTC_f8d99.dir/build
make: /usr/bin/make: Operation not permitted
make: *** [Makefile:127: cmTC_f8d99/fast] Error 127

CMake will not be able to correctly generate this project.
Call Stack (most recent call first):
CMakeLists.txt:3 (project)
./build.sh: exit: line 40: Illegal number: -1
The command '/bin/sh -c cd $DROGON_INSTALLED_ROOT     && sed -i 's/bash/sh/' ./build.sh     && ./build.sh' returned a non-zero code: 2

不知道是不是更新了什么配置，导致创建镜像失败

。。。。
不知道为什么突然好了，dockerfile啥也没变，就把母鸡系统换了个高版本


Add e2e timeout to Dockerhub runs and update Makefile default

Signed-off-by: Shubham Sharma<EMAIL_ADDRESS>Description
Earlier e2e test timeout was only applicable for GHCR cron runs, now it's also extended to Dockerhub.
The Makefile is also updated to always use a default value if the environment variable is unset.
Issue reference
NA
Checklist
Please make sure you've completed the relevant tasks for this PR, out of the following list:

[ ] Code compiles correctly
[ ] Created/updated tests
[ ] Extended the documentation

MacOS
gotestsum --jsonfile /Users/runner/work/cli/cli/test-e2e-standalone.json --format standard-verbose -- -timeout 20m -count=1 -tags=e2e ./tests/e2e/standalone/...
Linux
gotestsum --jsonfile /home/runner/work/cli/cli/test-e2e-standalone.json --format standard-verbose -- -timeout 10m -count=1 -tags=e2e ./tests/e2e/standalone/...

@shubham1172 one suggestion ... for the self hosted e2e alone keep the timeout at 15 mins .... It is only timeout and that should not affect the actual tests ... The point is do we need the complex conditions to set different values based on arch?

It's better to fail early if something goes wrong, isn't it? The difference is mostly due to podman vs docker in Mac and other runners. We CAN revert this to use a single value, but let's do it in a separate PR since a part of this logic is already merged to master, but I am OK with keeping different timeouts too. Let me know your thoughts.

@shubham1172 one suggestion ... for the self hosted e2e alone keep the timeout at 15 mins .... It is only timeout and that should not affect the actual tests ... The point is do we need the complex conditions to set different values based on arch?

It's better to fail early if something goes wrong, isn't it? The difference is mostly due to podman vs docker in Mac and other runners. We CAN revert this to use a single value, but let's do it in a separate PR since a part of this logic is already merged to master, but I am OK with keeping different timeouts too. Let me know your thoughts.

IMO it can be done as a separate PR.


Start and end line numbers of "undo"/"redo" actions are not showing correctly.

I am looking for a way to get the range that will be inserted/deleted, when monaco editors "undo" action is performed.
Ideally I use the onDidChangeModelContent to get the range that has been pasted, entered, removed. But for undo/redo action, although I can get hold of isUndoing/isRedoing on the event, the startLineNumber and endLineNumbers are always showing the line where the undo action is being performed. But it does not show the actual lines and positions where the undo action is going to happen.
this.editor.onDidChangeModelContent(e => {
    if(e.isUndoing){
    const {startLineNumber,endLineNumber}   = e.changes[0].range;
       // performing my logic on these line numbers here.
   }

How can I get hold of these start and end line numbers on undo/redo actions ?

The events fire after the edit has occurred. The event is called onDidChangeModelContent. It is not possible to participate before the undo/redo actions execute, you can only observe their edits. So if a user types a at position (1,1), then the undo will show a deletion of range (1,1,1,2), etc.

@alexdima  To put things this way. I am showing custom glyph markers, I am able to move the markers on the line numbers when a user clicks on Enter, Remove or Delete. But when a user clicks on "Undo"/"Redo" I am not able to get hold of the linenumbers that were inserted or deleted.
Is there a way in which I can get hold of the range of linenumbers that were inserted/deleted when an undo/ redo action is performed.
For example from the below screenshot you can observe that the highlighted range I deleted, once I undo, the undo event on "onDidChangeModelContent" is not giving me the line numbers that are being inserted back. So my expectation is
On Undo --> I need to know the start linenumber/end line number of the word(s)/line(s) that were undone.

Example of Pasting :-
On pasting I get the range of line numbers that the user pasted from the event onDidPaste and I can compute my logic as can be shown below.
this.editor.onDidPaste(e => {
   const {startLineNumber, endLineNumber} = e.range;
   const addedRangeOfLines = this.getRange(startLineNumber, endLineNumber);
   const indexOffset = 1;
   this.updateAllLineNumberAfter(startLineNumber, endLineNumber, addedRangeOfLines, indexOffset);
 });

onDidChangeModelContent contains all the information of the edit that was applied to the editor. A change event consists always of a range (which can be collapsed) and of a text (which can be empty).
e.g.

deleting aaa is represented as a replacement of a range of 3 characters with ''
inserting aaa is represented as a replacement of a collapsed range with aaa

The event onDidChangeModelContent describes completely the change that happened to the text model. It is not necessary to use additional listeners, such as onDidPaste or others.

@alexdima sorry, I am a bit lost here. Suppose I delete 2 lines ( lines 3 and 4 per say ) and perform an "undo" action, I want to know that the lines being undone are startLineNumber : 3, endLineNumber: 4. Is there any way I can get the line numbers being done ?

@DineshKarri443  I'm really sorry, but I cannot help you further. As I wrote above, all the information that describes how the model is changed (including when undoing) is contained in the change event. I am sorry that I am not explaining this well enough, but I don't understand what you're not understanding. I cannot offer more help than this, please consider asking your question on StackOverflow.


continue.dev doesn't load in vscode.dev - tries to use node js module

Before submitting your bug report

[X] I believe this is a bug. I'll try to join the Continue Discord for questions
[X] I'm not able to find an open issue that reports the same bug
[X] I've seen the troubleshooting guide on the Continue Docs

Relevant environment info
vscode.dev

Description
I went to vscode.dev
I installed the continue.dev extension from the extension marketplace.
The extension doesn't load. I see the following error in the extension host worker output.
2024-08-28 22:51:02.357 [error] Error: Cannot load module 'child_process'
	at m (https://main.vscode-cdn.net/stable/fee1edb8d6d72a0ddff41e5f71a671c23ed924b9/out/vs/workbench/api/worker/extensionHostWorker.js:112:483)
	at eval (https://continue.vscode-unpkg.net/Continue/continue/0.0.412/extension/out/extension.js#vscode-extension:42:86)
	at node_modules/node-machine-id/dist/index.js (https://continue.vscode-unpkg.net/Continue/continue/0.0.412/extension/out/extension.js#vscode-extension:43:6)
	at __require (https://continue.vscode-unpkg.net/Continue/continue/0.0.412/extension/out/extension.js#vscode-extension:14:50)
	at src/util/vscode.ts (https://continue.vscode-unpkg.net/Continue/continue/0.0.412/extension/out/extension.js#vscode-extension:906:38)
	at __init (https://continue.vscode-unpkg.net/Continue/continue/0.0.412/extension/out/extension.js#vscode-extension:11:56)
	at src/activation/environmentSetup.ts (https://continue.vscode-unpkg.net/Continue/continue/0.0.412/extension/out/extension.js#vscode-extension:56212:5)
	at __init (https://continue.vscode-unpkg.net/Continue/continue/0.0.412/extension/out/extension.js#vscode-extension:11:56)
	at src/extension.ts (https://continue.vscode-unpkg.net/Continue/continue/0.0.412/extension/out/extension.js#vscode-extension:68537:5)
	at __init (https://continue.vscode-unpkg.net/Continue/continue/0.0.412/extension/out/extension.js#vscode-extension:11:56)
	at eval (https://continue.vscode-unpkg.net/Continue/continue/0.0.412/extension/out/extension.js#vscode-extension:68542:1)
	at I.xb (https://main.vscode-cdn.net/stable/fee1edb8d6d72a0ddff41e5f71a671c23ed924b9/out/vs/workbench/api/worker/extensionHostWorker.js:112:627)
	at async Promise.all (index 0)
	at async s.n (https://main.vscode-cdn.net/stable/fee1edb8d6d72a0ddff41e5f71a671c23ed924b9/out/vs/workbench/api/worker/extensionHostWorker.js:96:6410)
	at async s.m (https://main.vscode-cdn.net/stable/fee1edb8d6d72a0ddff41e5f71a671c23ed924b9/out/vs/workbench/api/worker/extensionHostWorker.js:96:6373)
	at async s.l (https://main.vscode-cdn.net/stable/fee1edb8d6d72a0ddff41e5f71a671c23ed924b9/out/vs/workbench/api/worker/extensionHostWorker.js:96:5830)

I believe child_process is a node specific module that allows launching child processes.
To reproduce

Go to vscode.dev
Click on extensions and load continue.dev
Click on the continue.dev icon; it just has a spinner
Click on output and look at the extension host output window

Log output
No response

@jlewi Continue is not and probably won't for a while be compatible with browser-only versions of VS Code like vscode.dev. It's not just because we use child_process, but because we require local databases like SQLite and LanceDB. Someday we may put in the extensive effort to package for both pure browser and local, but for now this is a major undertaking (not that we expect it to be this bad, but it took VS Code ~10 years I believe...)
That said, you should still be able to use Continue on something like code-server, which is actually backed by a real machine

Would it make sense to start by using switching to VS Code APIs like vscode.workspace.fs and vscode.Uri instead of node specific APIs?
That would get us closer and limit the work down the road to deal with the databases only.

@sestinj Thanks for clarifying that continue.dev doesn't work on in vscode.dev. I think there might be a bug somewhere then because extensions that don't support the browser should be marked as such and not show up in vscode.dev as installable.
If you look at GitHub Copilot for example in the extension market place you can see it won't let you install it.
I think it might be as simple as deleting the browser line your package.json
https://github.com/continuedev/continue/blob/832de225c2fbbc8c64866413585bd4453399c8d6/extensions/vscode/package.json#L59
Relevant documentation

Extensions that have only a main entry point, but no browser are not web extensions. They are ignored by the web extension host and not available for download in the Extensions view.

because we require local databases like SQLite and LanceDB. Someday we may put in the extensive effort to package for both pure browser and local

Have you thought about defining a Continue API that separates parts that can run in the browser from those that can't? This way if you want to run in the browser you don't need to run the full codeserver server you just need to run the Continue Backend?
I think this is advantageous because I think codeserver has some sharp edges if you run in a scale to zero mode. For example the UI won't be accessible until the server is up and you can lose unsaved changes when scaling down. vscode for web solves this problem since files/state can still be stored on your local machine.
Use Case
I really like Continue because it brings Claude (and other models) into VSCode (demo video). Compared to Claude/ChatGPT playgrounds VSCode for web + Continue have a couple of really nice advantages

vscode for web is a richer playground - e.g. File Browser + access to local files
Cheaper pay for what you use without being locked into subscriptions

I work on RunMe.  This creates a really great UX for interacting with AIs and tools (video).
Continue is very complementary

I regularly use Continue to chat with Claude to come up with commands
I'd like to use Continue to chat withy my notes

All good points made here! For now I've deleted the browser entry point as suggested: https://github.com/continuedev/continue/commit/855211d887f720ca09b2ba1ffdb2f74aa1599224
There will be many additional modifications needed to convert our entire core (which is assumed not to have access to VS Code APIs so that we can re-use it for the Jetbrains extension), so it's not likely on the short-term roadmap. When we get there though the biggest things will be replacing all usages of "fs", "child_process", "path", lancedb, sqlite, and a few others


Add Vagrantfile for building on OS X

I put this Vagrantfile together to make the build process easier on OS X (my main dev environment for my fork of this repo). All it does is install and start the Docker service on an Ubuntu Vivid base, but from there it only takes a vagrant ssh and cd /vagrant; make to build the Dockerfiles.

@jbhannah How would you feel about using docker-machine for this instead of Vagrant?

@jbhannah I've just pushed changes to make the build scripts OSX-compatible. I've tested this with docker-machine running a Virtualbox machine and it works fine. Would you like to try it out?


Add activity notification library

Fixes #243
Describe the changes you have made in this pr -

[x] Added activity notification library
[x] Added notification for starring project
[x] Added tests
[x] Link to notifications page
[x] Web push
[ ] Icon for web push

Demonstration video (Activity Notification)

Demonstration video (Web push notifications)

MP4 on google drive
Users enable browser notifications by visiting the Notifications page and clicking enable. The browser will ask them for permission and if granted, generate encryption and authentication keys, as well as a cloud endpoint for sending notifications to the device, which are sent to the server and stored in the database. This process needs to be repeated for every device that the user wants to receive push notifications on. The user can then click the test button to send a test notification to itself.
The server also needs to identify itself to the browser's cloud push notification endpoint. It does this by generating a public/private key pair. You can do this by running Webpush.generate_key in the rails console:
$ rails console
Running via Spring preloader in process 8655
Loading development environment (Rails 6.0.1)
[1] pry(main)> Webpush.generate_key
=> #<Webpush::VapidKey:2ab51f32dbe8 :public_key=BAAS5N5HuL4ElT1hBU1ZdGfRrXq1Ja90gOR7IjwZXfSU4ZfogrIMVtnerHgsI2TLoidFPSH32_H89thI1l9Rdn4= :private_key=XPwmYJgtRybLJDWXNKIDVOdgXQzJzl0Uj29sw_52Bwo=>

These keys need to be exposed to the application by setting the following environment variables:

VAPID_PUBLIC_KEY
VAPID_PRIVATE_KEY

One final step is to add the icon for the push notifications. Currently, I did not specify an icon, so it defaults to the browser logo (in chrome at least). Please advise as to which image to use for the icon.
Ping @tachyons
Replacement for #706

Coverage increased (+0.1%) to 82.605% when pulling a56276e7bd844d61ccb674568a91dd315392289d on junron:243notifications into 3e621595ab0ddd7429a1a5ef6475e7170280d2f7 on CircuitVerse:stories/new_ux.

Everything resolved! @tachyons

Great work,  Can someone from @CircuitVerse/gci-mentors help reviewing the ui and the functionality?

@tachyons
All issues pointed out resolved!
Mentors can test out my PR at https://demo.circuitverse.chatbox2.ml/. The database has been seeded with rails db:seed so you can login with the default credentials.
The icon issue has still now been resolved.

@tachyons Could you advise on a suitable icon to use for the push notifications? It should be square and be at least 140px by 140px

I am using this image:


add to_dot.jl for creating dot file for ComputationalGraph

Codecov Report
Attention: 204 lines in your changes are missing coverage. Please review.

Comparison is base (65aa72b) 63.99% compared to head (c347b76) 61.39%.

Files
Patch %
Lines

src/backend/to_dot.jl
0.00%
203 Missing :warning:

src/frontend/GV.jl
50.00%
1 Missing :warning:

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.
Additional details and impacted files
@@               Coverage Diff               @@
##           computgraph     #166      +/-   ##
===============================================
- Coverage        63.99%   61.39%   -2.60%
===============================================
  Files               65       66       +1
  Lines             4805     5010     +205
===============================================
+ Hits              3075     3076       +1
- Misses            1730     1934     +204

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


[RFC]: A Graph Optimization System in vLLM using torch.compile

Motivation.
At a high level, we at Neural Magic are writing a custom compiler for Torch Dynamo to define a system within vLLM where we can write graph transformations. The main goal is a separation of concerns between high-level model definitions and certain performance-critical low-level decisions. This is especially important for optimizations that are particularly invasive to the model definitions, that break abstractions, that cross boundaries between layers, or that aren't universally valid or useful. If these optimizations are made as part of the model definitions, it becomes much more difficult to add new models.
We are working on the following for an initial set of optimizations using this system, described in detail in the Proposed Passes section.

Fusing quantize operations onto LayerNorm kernels (both for fp8 and int8 and both static and dynamic quantization)
Fusing the MLP section containing GEMM, SiLU, Mul, and quantize operations
Rewriting Gemm + AllReduce + Layer Norm + Gemm to a Fused Gemm-ReduceScatter + LayerNorm + Fused AllGather Gemm, in order to take advantage of the Flux kernels from ByteDance

Although this system operates as a custom compiler inside of Torch Dynamo, it’s best to think of it as an optimization system in vLLM rather than a compiler. Rather than a vertical compiler stack that lowers high-level tensor operations through successive layers of IR, we are taking the simple and pragmatic approach of improving vLLM’s ecosystem of custom kernels rather than replacing it.
Going forward, based on our experience at Neural Magic of what worked well in DeepSparse, we have a perspective on how graph optimizations should fit into vLLM and how it should fit in with the PyTorch team’s plans with torch.compile. In short we think:

A graph optimization/compilation system can be a power multiplier for vLLM developers.
Torch.compile is not likely to be good enough to replace custom kernels at least for linear layers.
vLLM should not treat torch.compile as a black box.
We should build a system that vLLM developers control that interoperates well with Torch Inductor.
This graph optimization system should be kept lightweight – vLLM should not try to become a graph compiler.

[RFC] A Graph Optimization System in vLLM using torch.compile
Proposed Change.
#6377
Feedback Period.
No response
CC List.
No response
Any Other Things.
No response

Sounds exciting! From my POV on the torch.compile team, I think we'd definitely be very interested in supporting custom passes within Inductor better.

Sounds exciting! From my POV on the torch.compile team, I think we'd definitely be very interested in supporting custom passes within Inductor better. This has been something we've been particularly interested in recently, and I suspect that it should be possible (without that much work) to make your lives much easier :)

That is great to hear. Ultimately we want this to integrate with Inductor as natively as possible. We'd appreciate whatever help we can get there, and better support for custom passes would be phenomenal.

Hi, does it means (or something like) that we wont notice fused_add_rms_norm in model definition (just write rms_norm and residuals) and the graph optimization mechanism will recognize it and call the fused kernel (but not compile it directly into assembles)?

Hi, does it means (or something like) that we wont notice fused_add_rms_norm in model definition (just write rms_norm and residuals) and the graph optimization mechanism will recognize it and call the fused kernel (but not compile it directly into assembles)?

@gx16377 , we don't do this currently but it is something we are thinking about for future iterations of the optimizer.

FYI: a simple solution for using torch.compile: https://github.com/vllm-project/vllm/pull/8398

Unmarking this as stale, but will close once the initial tranche of custom inductor passes are in!

https://github.com/vllm-project/vllm/pull/10867
https://github.com/vllm-project/vllm/pull/10906
https://github.com/vllm-project/vllm/pull/9886


PhantomJS app deploy with APEX

Someone trying to deploy app thats need to have a phantomjs instance running, I try to follow some boilerplates on internet but when I deploy nothing goes right :/
Some one with a success case to help me :) ?

You're in luck! Check out https://github.com/apex/capture. Unfortunately you have to deploy the binary each time, but it works

@tj i saw that :/ but in case where I put this exec? on functions/myfunc/src or in functions/myfunc ? I try to running that but got this err:
{
  "errorMessage": "spawn /var/task/src/phantomjs_linux-x86_64 ENOENT",
  "errorType": "Error",
  "stackTrace": [
    "exports._errnoException (util.js:870:11)",
    "Process.ChildProcess._handle.onexit (internal/child_process.js:178:32)",
    "onErrorNT (internal/child_process.js:344:16)",
    "nextTickCallbackWith2Args (node.js:437:9)",
    "process._tickDomainCallback (node.js:392:17)"
  ]
}

You should be fine making it relative to the CWD: https://github.com/apex/capture/blob/master/index.js#L13

@tj I try to run the example on lambda but got this err :/
   ⨯ Error: function capture: RequestEntityTooLargeException: Request must be smaller than 69905067 bytes for the CreateFunction operation

Hmm weird it used to work

phantomjs-prebuilt works fine for me with Apex.

Make sure the executable has the approviate executable flag with chmod +x bin/phantomjs.
This solved the problem for me.


Race condition when calling ToRasterizer on a path

Commit 5114238b14c768e1326188138fffac72f0d5531a made canvas.(*Path)'s ToRasterizer function unsafe to call concurrently, because it modifies the global Tolerance value.
Race conditions look roughly like this (the odd paths come from building with Bazel, but they're readable nonetheless):
WARNING: DATA RACE
Read at 0x000105a54628 by goroutine 428:
  github.com/tdewolff/canvas.(*Path).ToRasterizer()
      external/com_github_tdewolff_canvas/path.go:1930 +0x54
  github.com/tdewolff/canvas/renderers/rasterizer.(*Rasterizer).RenderPath()
      external/com_github_tdewolff_canvas/renderers/rasterizer/rasterizer.go:120 +0xa60
  github.com/tdewolff/canvas.(*Canvas).RenderTo()
      external/com_github_tdewolff_canvas/canvas.go:707 +0x554
  [ ... confidential part of stack trace elided ... ]

Previous write at 0x000105a54628 by goroutine 435:
  github.com/tdewolff/canvas.(*Path).ToRasterizer()
      external/com_github_tdewolff_canvas/path.go:1933 +0xd4
  github.com/tdewolff/canvas/renderers/rasterizer.(*Rasterizer).RenderPath()
      external/com_github_tdewolff_canvas/renderers/rasterizer/rasterizer.go:113 +0x74c
  github.com/tdewolff/canvas.(*Text).RenderAsPath()
      external/com_github_tdewolff_canvas/text.go:1145 +0x55c
  github.com/tdewolff/canvas/renderers/rasterizer.(*Rasterizer).RenderText()
      external/com_github_tdewolff_canvas/renderers/rasterizer/rasterizer.go:128 +0xb8
  github.com/tdewolff/canvas.(*Canvas).RenderTo()
      external/com_github_tdewolff_canvas/canvas.go:709 +0x5bc
  [ ... confidental part of stack trace elided ... ]

the last call in the confidential part of the stack trace is roughly shaped like this:
c := canvas.NewFromSize(canvas.A4)
ctx := canvas.NewContext(c)

drawToCanvas(ctx)

resolution := canvas.DPI(300)

img := image.NewRGBA(image.Rect(0, 0, int(c.W*resolution.DPMM()+0.5), int(c.H*resolution.DPMM()+0.5)))
draw.Draw(img, img.Bounds(), image.NewUniform(color.White), image.Point{}, draw.Over)

raster := rasterizer.FromImage(img, canvas.DPI(300), canvas.DefaultColorSpace)
c.RenderTo(raster) // <- race detected here
raster.Close()

I think a reasonable solution to this would be to either protect the changed tolerance value with a mutex (which would essentially single-thread all operations that go through this path, which sounds bad from a performance-vs-gain perspective) or to make the tolerance a local value of ToRasterizer and pass it through to called functions as a parameter or something like that.

Thanks for the bug report. The way the tolerance is adjusted is indeed a bit sloppy. The solution however requires a bit refactor in the way that functions are defined. The global Tolerance is used in many places and would need to be passed along everywhere. I will keep you updated.

I've fixed the issue and added the tolerance parameter for explicit control when calling the Flatten(), Stroke(), and Offset() functions.

Sorry for getting back so late, I just wanted to drop a note that I appreciate the quick fix. Thanks :)


Add .ruby to the list of ruby file extensions

Can be found in Rails partial, eg .html.ruby

Can be found in Rails partial, eg .html.ruby

I've not see this usage before. Could you point me to some examples of usage?

There are ~2000 results on github with the .ruby extension. I have never seen that extension used or even encouraged in the ruby world.

Nevertheless people definitely seem to be using it so...

Thanks, it's in the list of default rails template file extensions, eg like: .erb, .slim, .haml (and .ruby). I used it in a view that needed a lot of ruby logic


HAL issue - base64 turns into html

You can paste here any base64 text and it turns into HTML in the core.
https://github.com/pfrazee/ctznry/blob/3eacfec2bd888755f2317dea7b590073ba868f1f/static/js/com/popups/edit-profile.js#L139

I've applied CSPs to the frontend and backend so that blobs should no longer get autoexec power


Using shared AnimatedSprite for multiple characters

Hi there, first let me thank you for this wonderful library.
Thanks to everyone who keeps this project going!
Scenario
Imagine a Lemmings-like scenario where you have multiple instances of the same animation. Since the animation is always the same, a single shared AnimationSprite should be sufficent to draw multiple characters at different positions. So far, this works as expected.
Problem
The animation of each character should be time-shifted, so that the animations do not run synchronously. Ideally there would be an offset that just shifts the animation in time. I have tried to forward and rewind the animation for each draw call with Update and IsReversed but nothing worked.
So, I'd like to suggest a feature that supports this use case - or find a workaround :-)

Thanks for the suggestion @mk1024, I'll look into this.
I'm currently working on updating the core part of the lib to use the new released AsepriteDotNet, so it may be a few days before I can get to this, but I'll post anyy updates here in this thread


Replacing the stack trace of an anyhow error

Hello. My company has a use case where we'd like to replace the stack trace of an anyhow while maintaining the context.
As a motivating use case. I left out a lot of irrelevant details to simplify.
struct OrigError;

// spawn a worker
let (input_tx, input_rx) = sync::mpsc::channel();
let (output_tx, output_rx) = sync::mpsc::channel();
thread::spawn(move || {
  loop {
    let input = input_rx.recv();
    // process(input)
    output_tx.send(Err(anyhow::anyhow!(OrigError)));
  }
})

fn do_work(input: Input) -> anyhow::Result<Output> {
  input_tx.send(input);
  let result = output_rx.recv();
  // Here, we would like the stack trace of the receiving side rather
  // than the stack within the worker thread. It's more useful to know
  // which callsite failed rather than the stack inside the worker.
  result
}

I originally thought it might involve using anyhow::anyhow!() which creates a stack trace
if let Err(e) = result && e.is::<OrigError>() {
  return Err(anyhow::anyhow!("New stack trace").context(result));
}

This successfully gives a new stack trace, but loses context.
This rust playground illustrates my confusion here
https://play.rust-lang.org/?version=stable&mode=debug&edition=2021&gist=9e784df20991893689d17155c502b60e
(copy pasted here)
#[derive(thiserror::Error, Debug)]
#[error("It's an OrigError")]
struct OrigError;

fn main() {
    // Works
    let e = anyhow::anyhow!(OrigError);
    assert!(e.is::<OrigError>());

    // Works
    let e = anyhow::anyhow!("new").context(OrigError);
    assert!(e.is::<OrigError>());

    // Does not work
    let e = anyhow::anyhow!("new").context(anyhow::anyhow!(OrigError));
    assert!(e.is::<OrigError>());
}

I was a little confused by the behavior of .context(another_anyhow) - as it does not appear to transfer the contexts of another_anyhow. I also could not find a way to directly replace the stacktrace on an err (eg err.replace_stacktrace()).
Some poorly formed solution ideas. Open to better ideas too or other suggestions within the existing API.

Change anyhow's .context() to specially handle nested anyhow - and transfer over the context stack
Add an explicit API for replacing the stacktrace

Thank you! We love anyhow over here.

You can't assign an arbitrary Backtrace, but you can cause a new backtrace to be captured as follows:
use anyhow::anyhow;
use std::env;
use std::error::Error;
use std::fmt::{self, Debug, Display};
use thiserror::Error;

#[derive(Error, Debug)]
#[error("It's an OrigError")]
pub struct OrigError;

struct EraseBacktrace(anyhow::Error);

impl Error for EraseBacktrace {
    fn source(&self) -> Option<&(dyn Error + 'static)> {
        self.0.source()
    }

    // no fn backtrace()
}

impl Display for EraseBacktrace {
    fn fmt(&self, formatter: &mut fmt::Formatter) -> fmt::Result {
        Display::fmt(&self.0, formatter)
    }
}

impl Debug for EraseBacktrace {
    fn fmt(&self, formatter: &mut fmt::Formatter) -> fmt::Result {
        Debug::fmt(&self.0, formatter)
    }
}

fn main() {
    env::set_var("RUST_LIB_BACKTRACE", "1");
    let file = file!();

    let (e0, line) = (anyhow!(OrigError).context("Thing failed"), line!());
    dbg!(&e0, format_args!("\n{:?}", e0));
    assert!(e0.backtrace().to_string().contains(&format!("{file}:{line}")));

    let (e1, line) = (anyhow!(EraseBacktrace(e0)), line!());
    dbg!(&e1, format_args!("\n{:?}", e1));
    assert!(e1.backtrace().to_string().contains(&format!("{file}:{line}")));
}

Hi. Thanks for the message! I've implemented this strategy, but it doesn't quite work because e1.is::<OrigError>() or e1.downcast_ref::<OrigError>().is_some() isn't true.
Full code sample (adapted from the one you posted - adding two more asserts).
use anyhow::anyhow;
use std::env;
use std::fmt::{self, Debug, Display};

#[derive(thiserror::Error, Debug)]
#[error("It's an OrigError")]
pub struct OrigError;

struct EraseBacktrace(anyhow::Error);

impl std::error::Error for EraseBacktrace {
    fn source(&self) -> Option<&(dyn std::error::Error + 'static)> {
        self.0.source()
    }

    // no fn backtrace()
}

impl Display for EraseBacktrace {
    fn fmt(&self, formatter: &mut fmt::Formatter) -> fmt::Result {
        Display::fmt(&self.0, formatter)
    }
}

impl Debug for EraseBacktrace {
    fn fmt(&self, formatter: &mut fmt::Formatter) -> fmt::Result {
        Debug::fmt(&self.0, formatter)
    }
}

fn main() {
    env::set_var("RUST_LIB_BACKTRACE", "1");
    let file = file!();

    let (e0, line) = (anyhow!(OrigError).context("Thing failed"), line!());
    dbg!(&e0, format_args!("\n{:?}", e0));
    assert!(e0
        .backtrace()
        .to_string()
        .contains(&format!("{file}:{line}")));

    let (e1, line) = (anyhow!(EraseBacktrace(e0)), line!());
    dbg!(&e1, format_args!("\n{:?}", e1));
    assert!(e1
        .backtrace()
        .to_string()
        .contains(&format!("{file}:{line}")));

    // these asserts fail.
    assert!(e1.downcast_ref::<OrigError>().is_some());
    assert!(e1.is::<OrigError>());
}

I see — I think you're out of luck. You would need to use a different library.


Add quota support in resource calculator response

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.


Munich Airport v2 and time-warp 5

New with lon/lat, STARs, many airlines, quite balanced, fun to play. Different color for time-warp 2 and 5.

:+1:

thx, i hope i got the git-logic right this time
2015-11-03 14:15 GMT+01:00 Glenn Langford<EMAIL_ADDRESS>
[image: :+1:]
—
Reply to this email directly or view it on GitHub
https://github.com/zlsa/atc/pull/217#issuecomment-153348481.

@harp71 Munich looks great! A small suggestion for your next pull request:

there are many advantages to making changes in a separate topic branch, see a discussion here for example:
https://git-scm.com/book/de/v1/Git-Branching-Branching-Workflows

yeah, thats what i intended to to. i get it next time, hopefully :)
2015-11-03 14:24 GMT+01:00 Glenn Langford<EMAIL_ADDRESS>
@harp71 https://github.com/harp71 Munich looks great! A small
suggestion for your next pull request:

there are many advantages to making changes in a separate topic
branch, see a discussion here for example:
https://git-scm.com/book/de/v1/Git-Branching-Branching-Workflows

—
Reply to this email directly or view it on GitHub
https://github.com/zlsa/atc/pull/217#issuecomment-153351118.

Is there a problem with merging this?

@harp71 you have to wait for @zlsa, he is the only one with permission to merge.

Really sorry about the delay, I've been really busy recently.

@zlsa No worries, thanks for the merge!

thx!
2015-11-09 15:32 GMT+01:00 Jon Ross<EMAIL_ADDRESS>
Really sorry about the delay, I've been really busy recently.
—
Reply to this email directly or view it on GitHub
https://github.com/zlsa/atc/pull/217#issuecomment-155079342.

"I´m usefull, i´m having a wonderfull time!" (Dr. Zoidberg)
2015-11-09 15:35 GMT+01:00 harP<EMAIL_ADDRESS>
thx!
2015-11-09 15:32 GMT+01:00 Jon Ross<EMAIL_ADDRESS>
Really sorry about the delay, I've been really busy recently.
—
Reply to this email directly or view it on GitHub
https://github.com/zlsa/atc/pull/217#issuecomment-155079342.


Conflicting tables component selector : BasicTables,SmartTables

I'm submitting a ...
[ ] bug report

Do you want to request a feature or report a bug?

Bug

What is the current behavior?

The selector name between BasicTables and SmartTables is same.

If the current behavior is a bug, please provide the steps to reproduce and if possible a minimal demo of the problem via
https://plnkr.co or similar (you can use this template as a starting point: http://plnkr.co/edit/tpl:AvJOMERrnz94ekVua0u5).

What is the expected behavior?

What is the motivation / use case for changing the behavior?

Please tell us about your environment:

Angular version: 2.0.0-rc.X
Browser: [all]

Other information (e.g. detailed explanation, stacktraces, related issues, suggestions how to fix, links for us to have context, eg. stackoverflow, gitter, etc)

Basic Table Component.ts
Smart Table Component.ts

@genz10, thanks for your bug report. This was fixed in https://github.com/akveo/ng2-admin/commit/c85eae7e4bc2d4338495adef653719e1f46dabf8.


configure travis to deploy to pypi and gh releases on every build?

https://www.appveyor.com/docs/deployment/github
nice thing is that this makes it easy for people to get the latest code.
some considerations:

seems that this is some duplication of the nightly builds. is one better than the other?
we currently treat GH master as a dev branch and releases as the stable branch. automatically publishing/deploying the libraries that aren't "stable" could break programs that pull FLOSS from pypi.

the second consideration is more serious. thoughts? @mr-tz @Maijin

after discussing with @mr-tz, decided against this configuration due to the above concerns.


Troubles with moving models into devices

Dear Chainer community.
I faced with some strange error, I try to do data parallel computation, as  it in the manual
I ran it on four Tesla V100:
models['model_0'] = MyModel()
models['model_0'].to_gpu(0)

for i in range(1,n_of_gpu):
    models["model_{}".format(i)] = copy.deepcopy(models['model_0'])
    models["model_{}".format(i)].to_gpu(i)
    print("model: {} sent to gpu: {}".format(i,i))
print(models["model_1"].embed.W.data.device)
print(models["model_2"].embed.W.data.device)
print(chainer.__version__)
print(cupy.__version__)

The output is:
model: 1 sent to gpu: 1
model: 2 sent to gpu: 2
model: 3 sent to gpu: 3
<CUDA Device 0>
<CUDA Device 0>
<CUDA Device 0>
3.2.0
2.2.0

So, models don't move into devices 1 2 and 3. What's wrong?

Oh, I found that if I move a line models['model_0'].to_gpu(0) below the cycle, it works!
But it looks like models["model_{}".format(i)].to_gpu(i) can't work if model is already moved from cpu to gpu, why?

Oh, I just found that if I move a line models['model_0'].to_gpu(0) below the cycle, it works!
But it looks like models["model_{}".format(i)].to_gpu(i) can't work if model is already moved from cpu to gpu, why?

Sorry for not responding long time.
Currently Link (and classes like Chain that are inherited from Link) ignores to_gpu call if the Link is already on GPU.
We're currently trying to address this issue by changing to_gpu to perform GPU-to-GPU transfer in Chainer v5 (#4139).

You can now use link.to_device(chainer.backends.cuda.Device(0)) instead of link.to_gpu(0) to force transfer between GPU devices.


[5.5] orWhereDate() should accept two arguments

There is a check in the orWhereDate method body for accepting two arguments,
but the third argument ($value) seems doesn't have a default value.
BTW, In 5.6 there is more "date based orWhere". I'm not sure whether should I add tests for them in 5.6 branch.

5.5 is open for bugfixes only.

@jmarcher Should I open another PR for 5.6?
I think this is a "bug" because the method body has a check but the argument doesn't have a default value, it must be forgotten.


Add manual testing and use case

Added use cases for Add and Edit commands for manual testing regarding customer/employee/supplier.  Resolve #243
Removed unfulfilled NFRs.
Added the Add command for manual testing.

LGTM


cmd/go: covermode always results in build ID mismatch

Go version
go version go1.22.4 linux/amd64
Output of go env in your module/workspace:
GO111MODULE='auto'
GOARCH='amd64'
GOBIN=''
GOCACHE='/tmp/.gocache'
GOENV='/root/.config/go/env'
GOEXE=''
GOEXPERIMENT=''
GOFLAGS=''
GOHOSTARCH='amd64'
GOHOSTOS='linux'
GOINSECURE=''
GOMODCACHE='/root/go/pkg/mod'
GONOPROXY='<redacted>'
GONOSUMDB='<redacted>'
GOOS='linux'
GOPATH='/root/go'
GOPRIVATE='<redacted>'
GOPROXY='https://proxy.golang.org,direct'
GOROOT='/usr/local/go'
GOSUMDB='sum.golang.org'
GOTMPDIR=''
GOTOOLCHAIN='local'
GOTOOLDIR='/usr/local/go/pkg/tool/linux_amd64'
GOVCS='<redacted>'
GOVERSION='go1.22.4'
GCCGO='gccgo'
GOAMD64='v1'
AR='ar'
CC='gcc'
CXX='g++'
CGO_ENABLED='0'
GOMOD=''
GOWORK=''
CGO_CFLAGS='-O2 -g'
CGO_CPPFLAGS=''
CGO_CXXFLAGS='-O2 -g'
CGO_FFLAGS='-O2 -g'
CGO_LDFLAGS='-O2 -g'
PKG_CONFIG='pkg-config'
GOGCCFLAGS='-fPIC -m64 -Wl,--no-gc-sections -fmessage-length=0 -ffile-prefix-map=/tmp/go-build4162348479=/tmp/go-build -gno-record-gcc-switches'

What did you do?
First I pre-compiled the standard library with -trimpath and -covermode.
go build -trimpath -covermode=atomic std

Then I asked whether the net package was stale.
go list -f '{{.Stale}} {{.StaleReason}}' -trimpath -covermode=atomic net

What did you see happen?

true build ID mismatch

What did you expect to see?

false

Note that it works as expected without -covermode.

Related Issues

cmd/go: `-cover` flag is not reported by `go version -m` #67366 (closed)
cmd/go: list with -export and -covermode=atomic fails to build #65264 (closed)
cmd/cover: support -mod and other build flags #35869
cmd/go: coverpkg flag should be part of cache key #66504
cmd/cover: inconsistent NumStmt: changed from 1 to 2 #45506 (closed)
cmd/go: TestMissingCC fails when run at HEAD after `make.bash` #56888 (closed)
cmd/cover: failing TestFuncWithDuplicateLines #30861 (closed)
cmd/cover: inconsistent NumStmt error #30746 (closed)

(Emoji vote if this was helpful or unhelpful; more detailed feedback welcome in this discussion.)

Thanks for the report. I will take a look later this week.

Hi @rittneje , it appears that this problem is already fixed on tip, and will be present in 1.23. The fix CL is https://go-review.googlesource.com/c/go/+/560236. It also looks as though that fix is going to be back-ported to 1.22, so in theory if you update to Go 1.22.6 when it rolls out in August, that should take care of it. Thanks.


Bump deps and clear the release notes

Signed-off-by: Tim Smith<EMAIL_ADDRESS>

closing in favor of #5295. That did not clear the release notes but we'll do that before release.


[useSelector] throw missing selector error also in production

https://github.com/reduxjs/react-redux/blob/master/src/hooks/useSelector.js#L99-L101
What is the current behavior?
When selector is not provided the error is not thrown in production mode.
What is the expected behavior?
The error should be thrown in production mode also. Not sure why there is an additional production mode check. If it is for performance reasons, checking !selector is of the same performance as checking the "string" !== "string".
Perhaps some compilers remove the block completely during compile time?

This is because the error is the result of passing in bad input. This should be caught during development and not make its way to production. Once in production, that error message is not helpful to end users, so we hide it.

Just to mention that there might be cases where this is not caught in development, when the selector is dynamically passed from the parent component to the reusable "presentational" component which has useSelector(selector_passed_from_props).


[Bug Report] [el-button] [accessibility WCAG section508]

Element UI version
2.15.13
OS/Browsers version
MacOs Ventura 13.2.1 (22D68) / Chrome 110.0.5481.177 (arm64)
Vue version
2.7.14
Reproduction Link
https://element.eleme.io/#/en-US/component/button
Steps to reproduce
Go on https://element.eleme.io/#/en-US/component/button
Open Google Lighthouse in dev tool, run Accessibility test
What is Expected?
No Accessibility error.
What is actually happening?
Buttons do not have an accessible name
When a button doesn't have an accessible name, screen readers announce it as "button", making it unusable for users who rely on screen readers.
https://dequeuniversity.com/rules/axe/4.4/button-name?utm_source=lighthouse&utm_medium=devtools
Failing Elements
button.el-button

Suggestions : could provide default title and/or aria-label ? With override through props ?

Better accessibility is a harmonious operation, perhaps we can focus on here


Login Page - 1.4.4

Code of Conduct

[X] I agree to follow this project's Code of Conduct.

Submission validity

[X] This is not a personal support request, that should be posted on discussions community.
[X] I checked current issues and this request isn't a duplicate of an existing issue, opened or closed.

Self troubleshooting

[X] I've read the documentation and made sure to follow it.
[X] I've read the troubleshooting first steps and frequent issues guides.

Version
1.9.2
Description
According to the WCAG 1.4.4 criteria, text can be resized without assistive technology up to 200 percent without loss of content or functionality.
Users might need to zoom text and content. To allow them to do so, CSS attributes and properties should be contained only in CSS files and style attributes.
We can find size attributes on the inputs of the page.

Expectation
To fix this issue, the size attributes should disappear and be replaced by CSS properties in a CSS file.
Reproduction steps
No response
Context
No response

Thanks for all these issues @access42.
But please fill one only with all the subtasks in it.

Hello @LeoColomb,
Would you like an issue by page (there's only two of them) with subtasks with all of the details in only one issue ?
We were worried it would create an heavy issue.

@access42 Thanks for your answer. Yes, that would be better.
You can even use sub-tasks/checkboxes to clarify the different points.


Kustomize does not pull in new chart when changing the version number

Hi! Your repository is a great inspiration for my own setup, thank you!
I have encountered a problem with updating the helm chart version in the kustomize file.
As stated here kustomize only pulls the repo once and ignores the version. So when I update the version number of the chart and push it to git/argo, it does not deploy a new version because it has already pulled the old one...
Did you encounter the same problem? Did you solve it?
Thank you and all the best!

Uhm yeah it suddenly started working as intended... No idea why :/


Add RMStore by @robotmedia to Payments section

Project URL

https://github.com/robotmedia/RMStore
Description

Add RMStore by @robotmedia to Payments section
Checklist

[x] Only one project/change is in this pull request
[x] Addition in chronological order (bottom of category)
[x] Supports iOS 7 or later
[x] Has a commit from less than 2 years ago
[x] Has a clear README in English

@nschucky thx!


Issue 8 polyshortcuts arent cached

Resolves https://github.com/vaseker/tzwhere/issues/8

Wrong repo


Jbaker/refactor viewable month range

Alaska Airlines Pull Request
Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.
Resolves: #213
Summary:
This is a significant refactor of the logic controlling which and how many calendar months to render.
The new system follows theses rules:
The first calendar month that "may" be rendered is chosen in the following priority order:

The calendarStartDate is set with a valid date
The minDate is set with a valid date

The last calendar month that "may" be rendered is chosen in the following priority order:

The calendarEndDate is set with a valid date
The maxDate is set with a valid date

The following logic is used for choosing which months are currently rendered in DOM
In mobile the full range is rendered from the first month that "may" be rendered (as determined above) to the last month that "may" be rendered. If no range is determined using the earliers rules, the mobile calendar will start from the current date and include the next 11 months (12 months total).
In desktop, 1 month will be rendered by default. If the range attribute is used, this will change to 2 months. If calendarStartDate is set, the first month rendered will be this date. Otherwise, if value is set, this date will be used. Otherwise, the current date will be used.
The desktop calendar may navigate to previous and next months. The range of navigation is restricted by calendarStartDate and calendarEndDate. If one or the other is not set, minDate and maxDate are considered next. If none of these four attributes are set, the desktop calendar may be navigated forward and backward through time as far as the user wishes.
Type of change:
Please delete options that are not relevant.

[x] New capability
[ ] Revision of an existing capability
[ ] Infrastructure change (automation, etc.)
[ ] Other (please elaborate)

Checklist:

[x] My update follows the CONTRIBUTING guidelines of this project
[x] I have performed a self-review of my own update

By submitting this Pull Request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
Pull Requests will be evaluated by their quality of update and whether it is consistent with the goals and values of this project. Any submission is to be considered a conversation between the submitter and the maintainers of this project and may require changes to your submission.
Thank you for your submission!
-- Auro Design System Team

Calendar needs to auto scroll to calendarFocusDate in mobile

Error was resolved

:tada: This PR is included in version 2.5.0 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


Implemented 15 Puzzle Game

🛠 Fixes Issue (Number)
Fixes #827
👨💻 Changes proposed and Brief Description

Implemented 15 Puzzle Game using Object Oriented Concepts of Javascript.

✅ Check List (Check all the applicable boxes)

[x] My code doesn't break any part of the project
[x] This PR does not contain plagiarized content.
[x] My Addition/Changes works properly and matches the overall repo pattern.
[x] The title of my pull request is a short description of the requested changes.

📷 Screenshots

Review Requested by @swapnilsparsh
Kindly add labels: GSSoC and Level 3 . Thank you!

Kindly add labels please @swapnilsparsh

Add labels as per PR difficulty
CC: @swapnilsparsh


Doc: fix typo in README

Signed-off-by: LinHaiming<EMAIL_ADDRESS>

Codecov Report

Merging #41 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master      #41   +/-   ##
=======================================
  Coverage   33.04%   33.04%
=======================================
  Files           2        2
  Lines         115      115
  Branches       10       10
=======================================
  Hits           38       38
  Misses         77       77

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 33a921c...e5caee1. Read the comment docs.


Not updating package.json

In a recent PR I merged from Dependabot I've noticed that it has only updated my Yarn lockfile, not my package.json. Is this a bug or new behaviour?
If it is new behaviour, it would be nice to at least be able to opt into the old behaviour.

We haven't changed this for quite a while, but the logic is non-trivial, so it might just be that you're hitting a different path.
For apps (which we identify by checking they're not listed on npm) we update the requirement in the package.json unless the requirement is a range that is still satisfied. (If you're setting ranges in your package.json then we think it's unlikely you want them updating for in-range updates.)
For libraries (whose description in the package.json matches the description on npm) we only update the requirement in the package.json if the update is out of range. The assumption there is that library maintainers would want to keep their supported version ranges wide, in case they have integrators using --flat.
What's the repo you're seeing this behaviour on, and the thinking behind updating the package.json?

Thisis the repository.
The last commit from Dependabot to update package.json was severen/disposition@e950db75c3f5cd02985791c93c780727b631a125. So it seems this behavior has been going on for a while now and I've just not noticed. Either way it would be nice if there was an option for it.

Thanks for the link - looks like Dependabot is definitely picking that up as a library, hence the update behaviour.
Can you give me a bit more detail on why you'd like updates to always affect the package.json? I can look into adding a setting for this, but it would really help to know why it would be useful.


use substring instead of split to parse metafile

I've metafiles where the datum can contain "@" - symbols.
Currently parsing the StatisticReader doesn't support that, instead the program exit with an error.
In the current program the line in the metafile is split at @. So if there is a second @ in the line, the following assumptions aren't fulfilled.
-> Instead of splitting (which currently is only done for removing the @) I would use substring to remove the @ and then obtain the datum and the attribute.

@fschloesser

@fschloesser

Yeah, that previous split was weird and even a bit slow, anyway. Could you please extend the current code, however, and throw an exception if the first character on the line is not an @-character? After all, this is the required format for a meta file.
And please be careful, however, about the assumption you make : In general, one should avoid that log files and the associated files like meta, err, etc. contain strings with arbitrary bulls*** in them. Then, the format is simply illegal and cannot be parsed. Why, for example, should a data contain an @ character? This character is reserved for email addresses, the Cor@l benchmark library, and IPET meta files.

Yeah, that previous split was weird and even a bit slow, anyway. Could you please extend the current code, however, and throw an exception if the first character on the line is not an @-character? After all, this is the required format for a meta file.
And please be careful, however, about the assumption you make : In general, one should avoid that log files and the associated files like meta, err, etc. contain strings with arbitrary bulls*** in them. Then, the format is simply illegal and cannot be parsed. Why, for example, should a data contain an @ character? This character is reserved for email addresses, the Cor@l benchmark library, and IPET meta files.

I added unintentionally an @ symbol before the githash. (I removed that.)
Nevertheless I think IPET shouldn't exit with a compile error if that happens, so would this be a possible fix. (assuming there following code can handle the @)
    """
    Read lines of the form
    @Key Value
    from meta, out and err file and stores 'Value' in a Field 'Key'.
    """

Since this function is also used to parse the .err and the  .out file (see comment above), I think the exception wouldn't be correct.

I added unintentionally an @ symbol before the githash. (I removed that.)
Nevertheless I think IPET shouldn't exit with a compile error if that happens, so would this be a possible fix. (assuming there following code can handle the @)
    """
    Read lines of the form
    @Key Value
    from meta, out and err file and stores 'Value' in a Field 'Key'.
    """

Since this function is also used to parse the .err and the  .out file (see comment above), I think the exception wouldn't be correct.

I have never heard of a compile error. What exactly do you mean by that? I have problems imagining a situation where this could fail.
Note that the MetaDataReader uses a regular expression that ensures that it only parses lines starting with an @  followed by at least 3 non whitespace characters. (Thereby, it bypasses @01, @02, @03, @04 in an out file).

I have never heard of a compile error. What exactly do you mean by that? I have problems imagining a situation where this could fail.
Note that the MetaDataReader uses a regular expression that ensures that it only parses lines starting with an @  followed by at least 3 non whitespace characters. (Thereby, it bypasses @01, @02, @03, @04 in an out file).

Contemplating about what I just wrote, I don't think an exception makes any sense because the regular expression ensures that the exception cannot occur.

Contemplating about what I just wrote, I don't think an exception makes any sense because the regular expression ensures that the exception cannot occur.

Contemplating about what I just wrote, I don't think an exception makes any sense because the regular expression ensures that the exception cannot occur.

that was what I'm trying to say but failed ;-)

Contemplating about what I just wrote, I don't think an exception makes any sense because the regular expression ensures that the exception cannot occur.

that was what I'm trying to say but failed ;-)


lumina-open does not prompt when exit status is >0

Don't know if this is a real issue, but I've added in ~/Desktop a shell script.
When this one fails (exit >0) lumina-open does not report it.
I've saw in the code that the return code is well known but not used.
By doing this in lumina-open/main.cpp, I had my epxected result:
//if(retcode!=0 ){

if(p->exitStatus() == QProcess::CrashExit){

if(p->exitStatus() == QProcess::CrashExit or retcode> 0 ){
qDebug() << "[lumina-open] Application Error:" << retcode;

This is actually by design.
Lumina-open used to just compare the exit code and look for non-zero to display the crash handler, but then I discovered that tons of applications do not respect the conventions and return 0 for normal exits. So I opted to have it operate more conservatively and only show the crash handler for an application that truly crashed instead of having pop-up dialogs all over the place.


Add semi-functional search

This PR makes the global search field functional and also introduces a semi-functional search page.
When the user types on the global search field, a debounced request is made and up to four results are displayed. When the user clicks on one of the results, they are redirected to its page. When the user clicks the search icon button or the "Show all" results, they will be redirected to the search page.
Several things need to be mentioned:

the search page uses dynamic routes rather than query strings as React Router DOM's loaders cannot access query strings
the search page does not have pagination and will display all results on one page, I can potentially implement this at a later stage (ideally, we'd have pagination for that purpose)
the global search field merely redirects the user when they want all results. Because the search page itself sends a request when loaded, this means that the client effectively makes two requests. I can potentially implement some sort of caching to prevent this at a later point
The filter has not been implemented, because most (if not none) of the filter categories aren't searchable by at this point
The table does not have every single cell from the wireframes since those are not included with the cards endpoint. In addition, it is not stated how the colors for the rarity badge are determined (and since there seem to be over 20 different types of rarity, it's also impossible to derive this logically)

Note: this PR depends on features implemented in #26, I will update this whenever the need arises

The filter will be out of scope for this task
Rarity colors are out of scope, it's good enough the way it is implemented now

Looks good, works good, nice!
However, I found a small bug. When you switch between card details from the search, the listings are not changing to the new item's. We need to fix that.
How to reproduce:

Search for any card and open its details page.
Without leaving the page, search for another card and open its details page -----> observe how the new listings are not fetched.

This should be fixed (there was a similar bug in regards to the search page, which I have also fixed)
For this to be complete, I will likely need the /api/yugioh/cards_in_set/ endpoint to allow me to search cards by name (much like the standard cards endpoint), as proper pagination is not possible with the current setup and even the global search field underreports the total amount of results (as far as I have tinkered with Swagger). I will open a new issue after the holidays regarding this (as to not disturb the backend team)

This should be fixed (there was a similar bug in regards to the search page, which I have also fixed)
For this to be complete, I will likely need the /api/yugioh/cards_in_set/ endpoint to allow me to search cards by name (much like the standard cards endpoint), as proper pagination is not possible with the current setup and even the global search field underreports the total amount of results (as far as I have tinkered with Swagger). I will open a new issue after the holidays regarding this (as to not disturb the backend team)

You can open the issue and describe in detail what you need. The guys will pick it up whenever they can after the holidays.

refactored the PR with the new query (alongside a few minor design tweaks)

LGTM


Since WebSSH Pro 14.0 : No colors on terminal

Since the upgrade from 13.16 to 14.0, terminal don't show colors.
Seems that terminal type is not sent anymore.

Fixed by 14.0.4


Unable to focus on dark mode switch when tabbing through HTML report

🐛 Summary
When tabbing through the HTML report the user should expect anchors, links, and any input tags to be focusable. An element is considered focused when there is a black border around the tabbed element.
To reproduce
Steps to reproduce the behavior:

Run ScubaGear, go to either parent or individual HTML reports
Press the tab key. A black border will display around the CISA logo at the top left. Press the tab key again to navigate to the Secure Cloud Business Applications (SCuBA) link, again to the Baseline Documents link, then press it one more time.
Technically pressing the space bar will toggle dark mode correctly. However, there's no visual indication to the user they've arrived at the switch.

Expected behavior
When tabbing through the HTML report a black border should appear around the dark mode switch, similarly to what's shown below.

"Light mode"/"Dark mode" uses px size, which can't be resized. Change to em unit. (about 0.90em/1em)
https://www.w3.org/WAI/WCAG22/Techniques/general/G142.html