MsTeams : Issue in Input.Date Component for Adaptive Cards

Copied bug from: https://github.com/microsoft/AdaptiveCards/issues/6816
Details from original post:
Platform

Web (MsTeams Web http://teams.microsoft.com )
Ms Teams Desktop Client  <IP_ADDRESS>478 (Mac OS Big Sur)

Issue
I have a simple Adaptive card, with a date picker and an action button. When I select a date in date picker and then click on the button, I should be getting the postback date which was selected.
However, when I select a date, and click the action button, i am geting the postback date as (selected date - 1), that is ; just a day before the actual selected date.
Payload used:
payload.txt
My time zone: Indian Standard Time (IST)
I tried in desktop client in my MacOS , version of the app being  <IP_ADDRESS>478, issue exists there.

Even though date selected was 29th November 2021, I got the postback as:
{"date":"2021-11-28","action":"clicked"}
I tried in chrome browser , navigating to teams web (teams.microsoft.com ), and again I am able to see the same issue in Date.
Very strangely, issue in teams web client is not being seen when tested in Firefox  browser (78.13.0esr) , although the date  is coming in a different format and appearance of date picker is also different here.

Also, the problem is not being seen whe tested in Ms teams Android app (1416/<IP_ADDRESS>1183702/1117).
Please help me to know how I can fix this date picker issue, or if this is an ms teams issue .
Document Details
⚠ Do not edit this section.It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 3fb4394d-25b1-8752-3996-fe3a2934732d
Version Independent ID: 6d391381-89d0-117c-27cc-00043bd26a36
Content: Cards reference - Teams
Content Source: msteams-platform/task-modules-and-cards/cards/cards-reference.md
Product: msteams
GitHub Login: @surbhigupta12
Microsoft Alias: surbhigupta12

@devtfq - We are able to repro the issue and raised a bug for this. Engineering team is looking into it. We will inform you once we get any update.
Thanks!

@Prasad-MSFT  Thank you so much for the update.

@Prasad-MSFT , @Wajeed-msft  can we please know if there is any update on this bug ?

@devtfq -Engineering team is looking into it. We will inform you once we get any update.

We are also facing the same issue. This is happening for the past 2+ months. Issue happened incrementally started with few users and then now being faced by all the thousands of users using our chatbots. Hoping for a quick resolution.

Just want to highlight that this is not an issue with Adaptive card to my knowledge as the same scenario is working fine when used in MS Teams Mobile APP.
Issue is happening in Desktop Teams App and web browser Teams version too.

@v-chetsh  @Prasad-MSFT  it's been almost a month now, can we please kindly get this resolved or could you please help us to escalate this issue ?
Thanks.

@devtfq - We have informed engineering team again.
We will let you know once we get any update from them.

Thank you Chetan for the update..

@devtfq - We tested the scenario in Microsoft Teams Version <IP_ADDRESS>564 (64-bit). It was last updated on 07-01-2022. and Teams web also and the issue doesn't seem to be persist. Please try to update your MS Teams version and check it once.

Tested myself and checked with few other users as well, working fine now. Thanks much

Thanks a lot @Prasad-MSFT  for the update, I tested it , and it's working perfectly!
Thanks again everyone !

Glad to hear that its working fine now. We are closing this issue. Please feel free to reopen if required.


use “shap.force_plot()”, then "MemoryError"，maybe need "gc.collect()"

run shap.force_plot()
result     MemoryError:
Int64Index: 213118 entries,
Columns: 109 entries,
dtypes: float64(40), int64(33), uint8(36)
memory usage: 137.6 MB

If I understand correctly you passed 200k explanations to the force plot
method right? Since that method uses D3 to draw in the browser I would not
recommend using more than 2000 or so data points (for example from a random
subsample). There are not even 200k pixels horizontally anyway so the plot
won't gain much from larger sample sizes.
That help? Perhaps I should throw a warning into the force plot function
for large sizes.

Scott

On Fri, Mar 2, 2018 at 12:50 AM yfhewei<EMAIL_ADDRESS>wrote:

run shap.force_plot()
result MemoryError:
Int64Index: 213118 entries,
Columns: 109 entries,
dtypes: float64(40), int64(33), uint8(36)
memory usage: 137.6 MB
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/slundberg/shap/issues/39, or mute the thread
https://github.com/notifications/unsubscribe-auth/ADkTxQKNwWYWHUygrahEJQPUlCBjQtWNks5taQfqgaJpZM4SZk0v
.


text/template: bad format string for range-over-int error

Go version
go version devel go1.24-5fe3b31cf8 Fri Sep 27 16:45:09 2024 +0000 linux/amd64
Output of go env in your module/workspace:
GO111MODULE='on'
GOARCH='amd64'
GOBIN=''
GOCACHE='/usr/local/google/home/jba/.cache/go-build'
GOENV='/usr/local/google/home/jba/.config/go/env'
GOEXE=''
GOEXPERIMENT='fieldtrack,boringcrypto'
GOFLAGS=''
GOHOSTARCH='amd64'
GOHOSTOS='linux'
GOINSECURE=''
GOMODCACHE='/usr/local/google/home/jba/go/pkg/mod'
GONOPROXY=''
GONOSUMDB=''
GOOS='linux'
GOPATH='/usr/local/google/home/jba/go'
GOPRIVATE=''
GOPROXY='https://proxy.golang.org'
GOROOT='/usr/lib/google-golang'
GOSUMDB='sum.golang.org'
GOTMPDIR=''
GOTOOLCHAIN='auto'
GOTOOLDIR='/usr/lib/google-golang/pkg/tool/linux_amd64'
GOVCS=''
GOVERSION='go1.23-20240626-RC01 cl/646990413 +5a18e79687 X:fieldtrack,boringcrypto'
GODEBUG=''
GOTELEMETRY='on'
GOTELEMETRYDIR='/usr/local/google/home/jba/.config/go/telemetry'
GCCGO='gccgo'
GOAMD64='v1'
AR='ar'
CC='clang'
CXX='clang++'
CGO_ENABLED='1'
GOMOD='/usr/local/google/home/jba/repos/github.com/jba/templatecheck/go.mod'
GOWORK=''
CGO_CFLAGS='-O2 -g'
CGO_CPPFLAGS=''
CGO_CXXFLAGS='-O2 -g'
CGO_FFLAGS='-O2 -g'
CGO_LDFLAGS='-O2 -g'
PKG_CONFIG='pkg-config'
GOGCCFLAGS='-fPIC -m64 -pthread -fno-caret-diagnostics -Qunused-arguments -Wl,--no-gc-sections -fmessage-length=0 -ffile-prefix-map=/tmp/go-build2774739339=/tmp/go-build -gno-record-gcc-switches'

What did you do?
template.Must(ttmpl.New("").Parse(`{{range $x, $y := .}}{{.}}{{end}}`))

where template is text/template
What did you see happen?
template: :1:18: executing "" at <.>: can't use %!s(int=5) to iterate over more than one variable
(emphasis mine)
What did you expect to see?
maybe
template: :1:18: executing "" at <.>: can't use int=5 to iterate over more than one variable

Related Issues and Documentation

error with range can't traverse "\xd5\xbc\xbd\xbe" #25306 (closed)
text/template: Unexpected assignment #56490 (closed)
text/template: key/value assignment is reversed within range loop #60801 (closed)
cmd/compile: range over rune literal causes internal compiler error  #64471 (closed)
cmd/go: build tags do not work quite as expected using devel version of Go #66299 (closed)
x/tools/gopls: range over func without variable shows 'simplify range expression' warning #65799 (closed)
cmd/compile: out of range integer in range loop crashes the compiler #65133 (closed)
html/template: {{range}} branches end in different contexts #54999 (closed)
x/tools/gopls: issues errors for range-over-func (InvalidRangeExpr) in go1.23rc1 projects #68248 (closed)
A text template rendering fine on 1.13 causes an error on 1.14rc1 #37066 (closed)

(Emoji vote if this was helpful or unhelpful; more detailed feedback welcome in this discussion.)

Related to #66107.


Key Up Event Not Captured If System Shortcut Activated MacOS

Is there an existing issue for this?

[X] I have searched the existing issues
[X] I have read the guide to filing a bug

Steps to reproduce

Run the sample code and observe left CMD key printing up and down events
Take a Mac screenshot using CMD+SHIFT+CTRL+4
Observe that we received the meta down, but the meta up was never registered, nor does the window lose focus

Expected results
Receive key up events reliably
Actual results
Key up events can be missed
Code sample
import 'package:flutter/material.dart';
import 'package:flutter/services.dart';

void main() {
  runApp(const MyApp());
}

class MyApp extends StatelessWidget {
  const MyApp({super.key});

  @override
  Widget build(BuildContext context) {
    return MaterialApp(
      title: 'Bug Report',
      theme: ThemeData(
        colorScheme: ColorScheme.fromSeed(seedColor: Colors.deepPurple),
        useMaterial3: true,
      ),
      home: const MyHomePage(title: 'Bug'),
    );
  }
}

class MyHomePage extends StatefulWidget {
  const MyHomePage({super.key, required this.title});

  final String title;

  @override
  State<MyHomePage> createState() => _MyHomePageState();
}

class _MyHomePageState extends State<MyHomePage> {

  @override
  void initState() {
    super.initState();
    RawKeyboard.instance.addListener(_handleKeyEvent);
  }

  void _handleKeyEvent(RawKeyEvent event) {
    if (event is RawKeyDownEvent) {
      if (event.logicalKey == LogicalKeyboardKey.metaLeft ||
          event.logicalKey == LogicalKeyboardKey.metaLeft) {
        print("Meta down");
      }
    }

    if (event is RawKeyUpEvent) {
      if (event.logicalKey == LogicalKeyboardKey.metaLeft ||
          event.logicalKey == LogicalKeyboardKey.metaLeft) {
        print("Meta up");
      }
    }
  }

  @override
  void dispose() {
    RawKeyboard.instance.removeListener(_handleKeyEvent);
    super.dispose();
  }

  @override
  Widget build(BuildContext context) {
    return Scaffold(
      appBar: AppBar(
        backgroundColor: Theme.of(context).colorScheme.inversePrimary,
        title: Text(widget.title),
      ),
      body: Center(
        child: Column(

          mainAxisAlignment: MainAxisAlignment.center,
          children: <Widget>[
            const Text(
              'Keyboard Bug',
            ),
          ],
        ),
      ),
    );
  }
}

Screenshots or Video
No response
Logs
No response
Flutter Doctor output
Doctor output
❯ flutter doctor
Doctor summary (to see all details, run flutter doctor -v):
[✓] Flutter (Channel stable, 3.10.5, on macOS 13.2.1 22D68 darwin-arm64)

Thanks for the report @MousyBusiness
Although I am able to replicate the reported behavior as below:

Upon tapping cmd button, it shows both meta events:

flutter: Meta down
flutter: Meta up
flutter: Meta down
flutter: Meta up
flutter: Meta down
flutter: Meta up

Upon taking screenshot, only Meta down is reported:

Performing hot restart...
Restarted application in 722ms.
flutter: Meta down

I came across this old issue mentioning same issue as you reported: https://github.com/flutter/flutter/issues/38076 which was potentially fixed with likely root-cause as mentioned https://github.com/flutter/flutter/issues/38076#issuecomment-543840156
I also saw this related issue that you can take a look and confirm if it resembles your case or not, because it does mention about flagsChanged method as discussed in above linked issue as well, so maybe that is still causing the issue as reported here.


Fix non_autolinks warnings

bors r+

bors r-
https://github.com/crossbeam-rs/crossbeam/runs/1368610393?check_suite_focus=true

bors r+


how to convert scnn torch model to caffe model

https://github.com/facebook/fb-caffe-exts#torch2caffe @cuicuizhang1989 , hope it helps

@cuicuizhang1989 would like to know FrancisGee's solution works for you or not?

@cuicuizhang1989 @ytzhao I have provided a script for generating SCNN caffe prototxt file: https://github.com/XingangPan/SCNN-prototxt-generator.
You can use http://ethereon.github.io/netscope/#/editor to visualize the architecture.
Hope it would be helpful.


Merge my changes

removed  compile warnings
removed arrayIndex - which is not needed except in case of filter - maybe need a better solution there
removed unused code / commented out code
added writable access to it when in foreach (also in arrays)
added tests

I had a little trouble preparing this change, but really only zero_functional.nim + test.nim should be affected...

Maybe having mapInPlace and indexedMapInPlace would be a bit more clear, but still writable foreach seems reasonable


Clevis test full fails if contract folder is nested two levels deep

I'll look into this soon

Compiling and deploying single contracts work in the meantime. You just can't run the whole thing at once


Fixed typos in docs/ref/signals.txt.

ticket 30571

Hi @hramezani, thanks for the fix.
Are we sure we want to keep the actual kwargs from the model class nested inside an outer kwargs?
With reference to the usecase that I mentioned in ticket 30571, here's what one will have to do in order to get the actual kwargs -
    follower = kwargs['kwargs']['follower']
    following = kwargs['kwargs']['following']
    if follower == following:
        raise ...

Which seems little weird, as compared to simply kwargs.get('follower').

@singhpratyush kwargs contains signal for all types of signals and kwargs for pre_init. This behavior is there from the very beginning, so changing this would be backward incompatible and I'm not sure if it is doable.

@felixxm: That makes sense. Thanks for the explanation :smile:.

@hramezani Sorry, but I've just realized that everything works properly (see comment). We should only fix typos in this doc:

``__init__()``: -> ``__init__()``. and
tutorial01 -> tutorial02.

@felixxm Thank you for investigation.
I checked the tutorial02, there is no model name Poll there. I think we should change the line:
p = Poll(question="What's up?", pub_date=datetime.now())
to
q = Question(question_text="What's new?", pub_date=timezone.now())
and also
{'question': "What's up?", 'pub_date': datetime.now()}
to
{'question_text': "What's new?", 'pub_date': timezone.now()}

@hramezani Yes, good catch  :+1:

@felixxm Done.

@hramezani Thanks!

@felixxm I found a few more like this in the documentation. for example:

models signals
in the note section(second box) it is better to replace 'polls.Answer' with 'polls.Choice'.
custom management commands docs refers to tutorial01 and also closepoll.py example refer to Poll model which does not exists.

Should I create seprate ticket for each item, or just create one general ticket for all of them?

Custom management commands example imports Question as Pollso it should work, but yes we can change tutorial01 to the tutorial02 and in models signals we can use polls.Question or polls.Choice instead of polls.Answer.
Ticket is not required, you can send a PR. Thanks!


[Feature] Show output in either table/yaml/json format for timoni inspect resources command

Business Problem Being Solved For
> External tool requires YAML manifests of all resources deployed by timoni
Context:
Currently, we are using Tilt which requires the YAML manifest of all resources deployed by an external tool (in this case timoni)
Reference: k8s_custom_deploy
Excerpt:

The apply_cmd ... should output the YAML of the objects it applied to the Kubernetes cluster to stdout. Tilt will track workload status and stream pod logs based on this result.

Work Around:
Currently, we are using a script like this to get the YAML manifest of all resources deployed by timoni:
#!/bin/bash

# Run timoni apply command and pipe the output to the while loop with prefix "#" to comment it out in YAML format
# Could have also ignored the output except if there is an error
timoni apply $RELEASE ./ --namespace $NAMESPACE 2>&1 | while read line; do echo "# $line"; done

# Run timoni inspect resources and store the output
resources=$(timoni inspect resources $RELEASE --namespace $NAMESPACE)

# Skip the header line and parse each resource
echo "$resources" | tail -n +2 | while read -r line; do
    echo "---" # Separator between resources

    # Extract resource type and name
    resource_type=$(echo "$line" | awk '{print $1}' | cut -d/ -f1)
    resource_name=$(echo "$line" | awk '{print $1}' | cut -d/ -f2)
    namespace=$(echo "$line" | awk '{print $2}')

    # Generate and run kubectl get command
    kubectl get "$resource_type" "$resource_name" --namespace "$namespace" --output YAML
done

Expected Outcome:
> Add a new flag for timoni inspect resources called --output with values table, yaml or json which can be used to get the YAML manifest of all resources deployed by timoni.

This great tool saves us a lot of time by abstracting CUE for Kubernetes.
Kudos! and much appreciation! 🙏

See https://timoni.sh/cmd/timoni_inspect_resources/

timoni build does just output all the resources in YAML format

The external tool in question was very particular about requiring the complete YAML manifest from the Kubernetes API (🤦🏻 it wanted to track the .metadata.uid field from the output YAML). This made it not compatible with timoni build, which is a mainly client-side version of YAML manifests that doesn't contain the server-side field required.
I'll close this issue for now as I have moved on to a better workflow with timoni that doesn't require this server-side manifest.

My new workflow for anyone curious

Transition from Tiltfile to Taskfile with file fingerprinting to prevent rework
Use clever environment variables that tag docker images with local vs. remote registers

For docker build task

Set registry host for accompanying container registryenv:
  REGISTRY_HOST:
    sh: |
      echo "localhost:$(k3d registry get "{{.CLUSTER_NAME}}" --output=json 2>/dev/null | jq -r 'try .[0].portMappings."5000/tcp"[0].HostPort catch "5000"')"

Push docker tag {{.REGISTRY_HOST}}/app/frontend:{{.BUILD_NUMBER}}

For timoni apply task

Set registry host for in-cluster host name:env:
  REGISTRY_HOST:
    sh: |
      echo "{{.CLUSTER_NAME}}:5000"

Set image in values as {{.REGISTRY_HOST}}/app/frontend:{{.BUILD_NUMBER}}

Use task build --watch to use file watchers with file fingerprinting above

This replicates enough of my original workflow with Tilt that I can move away from it for now.


Is it possible to move slides dynamically?

So is it possible to alter the data-x, data-y, data-z, data-rotate, data-scale, etc, with JS during the course of the presentation to move the slides? Also is it possible to add and remove slides dynamically?

Closing in favor of #537.


chore: Publish package to npm and other misc

Updated REAMDE.md
Added CONTRIBUTING.md
Updated cd.yml to maual_release.yml to publish the package to npm. To publish the package, needs to run this GitHub action manually. Following other SDKs that are published to public repositories (Python and Go SDKs)
Updated package.json to rename the package name and add the repository section

https://www.npmjs.com/package/client-sdk-javascript
Closes #41

A couple of n00b questions:

Do we have to keep using Artifactory? Can we publish directly to npm?
Why don't we just automatically publish to npm, why manual release?

@danielamiao

Do we have to keep using Artifactory? Can we publish directly to npm?
This SDK package is going to be published to npm; however my understanding is that  @momento/wire-types-javascript  is still only available on Artifactory so that's why I'm doing this.

Why don't we just automatically publish to npm, why manual release?
I'm not sure what was the reason why we decided manual release for other SDKs that are public but I'm just following the same for the JS SDK as well.
I think we have no issue to make it automatically being published as a part of the CD job.
But then we want to update the Python and Go for the same as well?

Just published the JS proto generated files to npm, so let me updates some in this repo!

@kvcache - Thank you for the feedback!
As mentioned above, the reason why may parts are commented out is that we're trying to figure out why the integration tests are failing on the CI GitHub action.
I'll make sure to put them back in once everything is sorted out.
Also, I asked for the dev-eco channel to get feedback on the package name. I'll update it accordingly.


Xcode Crash on debugging

Hi, when i try do debug RLMOjbect on Xcode the loading wheel appears and after a minute Xcode crashes.
Debugger output during "loading" before xcode crash:

Looks like you're hitting issues with our LLDB plugin. As a short term "solution", I'd recommend disabling the plugin if it's causing issues for you.
If you'd like to help us identify why it's not working in your case, more information would definitely be useful (version of Realm, Xcode, RLMObject subclass declarations, etc.). Thanks!

Realm 0.95.0
Xcode 7.0
How can I disable the plugin?

Remove the rlm_lldb.py line from your ~/.lldbinit file.

Other information that may be helpful:
-This problem appears when i have RLMResults where every results is composed by RLMObject with relationship. It seems that the script take much time to get the relationship, maybe this cause an infinitive loading and Xcode crashes.
-A RMLResults with few objects it takes less times to load, and xcode not crash.

Thanks for that additional info, @andr3a88. Unfortunately the LLDB plugin hasn't seen much active development since its initial release, and we currently lack the resources to optimize its performance in cases where there are potentially a large amount of data to load in memory.
We'd certainly welcome any contributions that could improve this situation, however. If you feel up for it!
For now, I'll be closing this issue, but don't hesitate to reach out again if you have any further questions.

I had the same crash here - can you just comment out this line???

:+1:


Menu spacing

Description
Moved the “add to ballot” button of an impact vector in the selection menu slightly to the right, with the same distance to the border as the text
Moved the title of an impact vector in selection menu slightly to the left to align with the impact vector description
Replaced blue background w white
Removed tickbox next to impact vectors
Weird cutoff of edges on Impact Vector selection
#40  #39 #35 #33
_Concise description of proposed changes, We recommend using screenshots and videos for better description

Additional Information

[ ] I have read the contributing docs (if this is your first contribution)
[ ] This is not a duplicate of any existing pull request

Related Issues
Closes #{issue number}
Note: If your changes are small and straightforward, you may skip the creation of an issue beforehand and remove this section. However, for medium-to-large changes, it is recommended to have an open issue for discussion and approval prior to submitting a pull request.
Your ENS/address:

This is looking great! Just let me know what you think about my comment on #40.


I/O regulation?

Is there any obvious way to throttle I/O ?
AWS instances are not very good in I/O, and running LHM migration pretty much takes all of it)

fixed via 43271f4


Adding node view for image node.

The draft PR at this stage shows approach I am planning to take to fix this https://github.com/tinacms/tinacms/issues/567
I am creating a node view for images, this node view will highlight image when it is falling at selection. Highlight can be added to a wrapper around image or the image itself.
Selected image is not necessarily focused, thus its is required to highlight image at selection in editor.

Images now have selected state highlighted with blue outline, also image has margin around it. Designs changes are discussed with @spbyrne .
Image will be selected on back arrow, behaviour on backspace is same as before. I think that should not be changed, its standard key mapping  - to delete content on backspace.

Behaviour of gap cursor can be improved further to make editor more intuitive.

This image UI is really nice! I like the indicator for where it gets dropped when you’re dragging it around. I think it's using a green color right now which we can swap for the blue used on the image outline.
I noticed a strange bug and I’m wondering if it’s related; when I’m editing in the WYSIWYG my cursor is visible as expected, but after dragging an image into the editor and going back to edit text my cursor is no longer visible.

Great stuff @jpuri!
A note for future PRs: we use conventional commits in this project. It helps us automatically determine what the version bump and and generate CHANGELOG files.

@all-contributors please add @jpuri for code


Convert to Kotlin?

This would all be much for palatable to work with if it were using modern Kotlin, instead of all this dated Java :(
Is there a reliable way to cleanly automate such a conversion?

Most annoyingly:

Before the introduction of enum classes in Java 5, developers used final constant ints to represent a fixed set of values. For example:
public class Colors {
   public static final int RED = 0;
   public static final int GREEN = 1;
   public static final int BLUE = 2;
}

(and all of the implications that might go along with this)

This would all be much for palatable to work with if it were using modern Kotlin, instead of this dated Java.
Most annoyingly:

Before the introduction of enum classes in Java 5, developers used final constant ints to represent a fixed set of values. For example:
public class Colors {
   public static final int RED = 0;
   public static final int GREEN = 1;
   public static final int BLUE = 2;
}

Yeah because Kotlin never gets updated, only Java changes and gets new features added to it.
If you would like, you can create a fork of this project for Kotlin, but I don't see any real advantage.
Converting this entire project into a different language is a big ask that won't serve any benefit unless Android suddenly stops supporting Java. If you would like to refactor the entire project into Kotlin, and then can prove it works just as before, feel free. There's even a tool built into Android Studio to facilitate this.

Yeah because Kotlin never gets updated, only Java changes and gets new features added to it.

I appreciate sarcasm, but it comes across as unnecessary and a bit rude.
Although you do make some good points - especially after trying Java / Kotlin converters - which either don't work well at all, or outputs a direct representation of Java bytecode (which is arguably even worse).

I appreciate sarcasm, but it comes across as unnecessary and a bit rude.

This was after this snobbish comment:

Honestly the biggest thing holding me back from looking at the code I've just described in Issue #6

If you don't want to "look at the code", you don't have to; nobody asked you to.

I didn't think it was snobbish, but I have edited it to communicate more clearly my sentiment. Apologies.


Add support for threshold flag

Codecov Report

Merging #5 into master will not change coverage.
The diff coverage is 100.00%.

@@            Coverage Diff            @@
##            master        #5   +/-   ##
=========================================
  Coverage   100.00%   100.00%
=========================================
  Files           14        14
  Lines          180       182    +2
  Branches        32        33    +1
=========================================
+ Hits           180       182    +2

Impacted Files
Coverage Δ

src/output.ts
100.00% <100.00%> (ø)

src/scanner.ts
100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f6fae18...990e466. Read the comment docs.


Line buffering TQDM could use an upper bound

Might be able to estimate it (not perfectly of course...) from the file size?

Added


SSH portal bugfix

This PR updates the lagoon-ssh-portal components with the fix from https://github.com/uselagoon/lagoon-ssh-portal/pull/249.
It also updates the NATS chart dependencies to the latest minor release.

closing - merging into #598


Correct typing for filterComponent

Related Issue
Description
In #506 changeFilterValue method was revorked. From that moment, the string value of columnId , provided to onFilterChanged prop is invalid. But no one changed the types file. Fixed it.
Related PRs
List related PRs against other branches:

branch
PR

Impacted Areas in Application
List general components of the application that this PR will affect:
index.d.ts
Additional Notes
Watch the types guys  :)

Can you add this instead to both the next and experimental branches, since those are the current state which will soon become the new master branch?


Traefik 2.0 doesn't respect scheme https unless Kubernetes service port name starts with https

Do you want to request a feature or report a bug?
Bug
Did you try using a 1.7.x configuration for the version 2.0?

[ ] Yes
[x] No

What did you do?
I tried to set up an IngressRoute for kubernetes-dashboard:
apiVersion: traefik.containo.us/v1alpha1
kind: IngressRoute
metadata:
  namespace: kube-system
  name: kubernetes-dashboard
spec:
  entryPoints:
    - https
  routes:
  - match: Host(`kubernetes-dashboard.mydomain`)
    kind: Rule
    services:
    - name: kubernetes-dashboard
      port: 443
      scheme: https
  tls: {}

What did you expect to see?
I expected Traefik to use https to connect to kubernetes-dashboard.
What did you see instead?
Traefik tries to contact kubernetes-dashboard over http, gets rejected and returns an error 500.
/api/rawdata returns the following information about the service:
  "services": {
    "kube-system/kubernetes-dashboard-1ae763fd03106a337232@kubernetescrd": {
      "loadbalancer": {
        "servers": [
          {
            "url": "http://<IP_ADDRESS>:8443"
          }
        ],
        "passHostHeader": true
      },
      "usedBy": [
        "kube-system/kubernetes-dashboard-1ae763fd03106a337232@kubernetescrd"
      ],
      "serverStatus": {
        "http://<IP_ADDRESS>:8443": "UP"
      }
    }
  }

If I edit the service definition for kubernetes-dashboard to add a name for the port starting with https, it works correctly.
Output of traefik version: (What version of Traefik are you using?)

Version:      2.0.0-alpha7
Codename:     faisselle
Go version:   go1.12.6
Built:        2019-06-21T15:59:46Z
OS/Arch:      linux/amd64

What is your environment & configuration (arguments, toml, provider, platform, ...)?
spec:
  replicas: 1
  selector:
    matchLabels:
      app: traefik
  template:
    metadata:
      labels:
        app: traefik
    spec:
      serviceAccountName: traefik-ingress-controller
      containers:
        - name: traefik
          image: traefik:v2.0
          args:
            - --api
            - --accesslog
            - --entrypoints.http.Address=:80
            - --entrypoints.https.Address=:443
            - --providers.kubernetescrd
            - --serverstransport.insecureskipverify
            - --acme
            - --acme.acmelogging
            - --acme.tlschallenge
            - --acme.onhostrule
            - --acme.email=REDACTED
            - --acme.entrypoint=https
            - --acme.storage=acme.json
          ports:
            - name: http
              containerPort: 80
            - name: https
              containerPort: 443
            - name: dashboard
              containerPort: 8080

If applicable, please paste the log output in DEBUG level (--log.level=DEBUG switch)
time="2019-06-30T10:35:29Z" level=debug msg="Creating middleware" routerName=kube-system/kubernetes-dashboard-1ae763fd03106a337232@kubernetescrd serviceName=kube-system/kubernetes-dashboard-1ae763fd03106a337232 middlewareName=pipelining middlewareType=Pipelining entryPointName=https
time="2019-06-30T10:35:29Z" level=debug msg="Creating load-balancer" serviceName=kube-system/kubernetes-dashboard-1ae763fd03106a337232 entryPointName=https routerName=kube-system/kubernetes-dashboard-1ae763fd03106a337232@kubernetescrd
time="2019-06-30T10:35:29Z" level=debug msg="Creating server 0 http://<IP_ADDRESS>:8443" entryPointName=https routerName=kube-system/kubernetes-dashboard-1ae763fd03106a337232@kubernetescrd serviceName=kube-system/kubernetes-dashboard-1ae763fd03106a337232 serverName=0
time="2019-06-30T10:35:29Z" level=debug msg="Added outgoing tracing middleware kube-system/kubernetes-dashboard-1ae763fd03106a337232" middlewareType=TracingForwarder entryPointName=https routerName=kube-system/kubernetes-dashboard-1ae763fd03106a337232@kubernetescrd middlewareName=tracing

Hi @zyp, thanks for your interest in the project.
The scheme option doesn't exist on service.
If we read the rawdata content, your server use the port 8443.
To have a valid configuration, you need to use https as port name OR 443 as port.
Could you please try this and confirm if it works ?

As far as I can tell, the scheme option not only exists, but is also required. I tried multiple combinations; having a port named https but not setting the scheme option fails in the same way. Getting both the port name and the scheme option correct results in a https request.
My guess is that the original intention was to be able to both autodetect from the port name and override it with the scheme option, but then the logic got mixed up a bit and turned into an AND situation instead.

the scheme attribute doesn't exist in our CRD
https://github.com/containous/traefik/blob/06df6017dfc4464b81106e22bd7fcc61de5c3786/pkg/provider/kubernetes/crd/traefik/v1alpha1/ingressroute.go#L45-L50

Closed by #5062.


Fixed position bug

The Volume Mixer should now always appear in the bottom right corner of the main Display.
This fixes #1.

Thanks


[Feature] Support multiple display styles, JSON, YAML, ASCII Table

Seems that people like table style, https://github.com/apache/skywalking-cli/pull/6#discussion_r343972888 , https://github.com/apache/skywalking-cli/pull/6#issuecomment-551076830 , this patch abstract a display layer and provides several display style implementations, JSON, YAML and ASCII table, works like this:
skywalking-cli (feature/display-styles $) -> ./bin/swctl --display=table --debug=false service ls
+----+----------+
| ID |   NAME   |
+----+----------+
|  4 | projectA |
|  2 | projectB |
|  5 | projectD |
|  3 | projectC |
+----+----------+

skywalking-cli (feature/display-styles $) -> ./bin/swctl --display=json --debug=false service ls
[{"id":"4","name":"projectA"},{"id":"2","name":"projectB"},{"id":"5","name":"projectD"},{"id":"3","name":"projectC"}]

skywalking-cli (feature/display-styles $) -> ./bin/swctl --display=yaml --debug=false service ls
- id: "4"
  name: projectA
- id: "2"
  name: projectB
- id: "5"
  name: projectD
- id: "3"
  name: projectC

skywalking-cli (feature/display-styles $) ->

will supplement the related documentations after #8 is merged

Codecov Report

Merging #9 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master       #9   +/-   ##
=======================================
  Coverage   51.85%   51.85%
=======================================
  Files           2        2
  Lines          54       54
=======================================
  Hits           28       28
  Misses         22       22
  Partials        4        4

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6562efe...f3ce003. Read the comment docs.


Cannot detect ugrid

I'm having trouble detecting ugrid for the file attached. Here is what I'm doing:
$ meshio-convert sphere_tetra.1.ugrid sphere.exo
Traceback (most recent call last):
  File "/usr/bin/meshio-convert", line 11, in <module>
    load_entry_point('meshio==2.3.3', 'console_scripts', 'meshio-convert')()
  File "/usr/lib/python3/dist-packages/meshio/cli.py", line 22, in main
    mesh = read(args.infile, file_format=args.input_format)
  File "/usr/lib/python3/dist-packages/meshio/helpers.py", line 128, in read
    file_format = _filetype_from_filename(filename)
  File "/usr/lib/python3/dist-packages/meshio/helpers.py", line 109, in _filetype_from_filename
    ext
AssertionError: Could not deduce file format from extension '.1.ugrid'.

I also tried renaming the file to sphere_tetra.ugrid, but that produces the same problem.
meshio-convert --version
meshio-convert 2.3.3, Python 3.7.3 (default, Dec 20 2019, 18:57:59) [GCC 8.3.0]

sphere_tetra.1.ugrid.txt
Rename to sphere_tetra.1.ugrid
Please let me know what I'm doing wrong. Thanks.

Please let me know what I'm doing wrong.

You're using the same meshio version as Galileo Galilei. Just upgrade and it'll work.

Okay, I'll install a custom one and try that one. This what I pulled in from debian stable: https://packages.debian.org/search?keywords=meshio&searchon=names&suite=stable&section=all

I'd use pip install meshio.

On debian stable pip install meshio still gives me
meshio 2.3.10 [Python 2.7.16]
Copyright (c) 2015-2019 Nico Schlömer<EMAIL_ADDRESS>
which still does not detect ugrid correctly. I'm no python guru, how else should I install it?

Probably pip3 install meshio. Python 2.7 has not been supported by meshio for quite a while now.

Thanks @keurfonluu . Now I get:
$ pip3 install meshio
Collecting meshio
  Downloading https://files.pythonhosted.org/packages/12/0e/44d6af1480791676d375f3c3e8ef5d40521a2529fddb180fef401ff414d0/meshio-4.0.2-py3-none-any.whl (125kB)
    100% |████████████████████████████████| 133kB 1.1MB/s
Collecting numpy (from meshio)
  Downloading https://files.pythonhosted.org/packages/63/0c/0261693cc3ad8e2b66e66dc2d2676a2cc17d3efb1c58a70db73754320e47/numpy-1.18.1-cp37-cp37m-manylinux1_x86_64.whl (20.1MB)
    100% |████████████████████████████████| 20.1MB 97kB/s
Installing collected packages: numpy, meshio
Successfully installed meshio-4.0.2 numpy-1.18.1
$ meshio-convert
Traceback (most recent call last):
  File "/usr/local/bin/meshio-convert", line 6, in <module>
    from meshio._cli import convert
ModuleNotFoundError: No module named 'meshio._cli'

Did it not pull some dependency?

Well, my guess is that your previous Python 2 installation is messing with meshio-convert.
Try pip uninstall meshio and then reinstall with pip3.

It's also weird that it installs in /usr/local/. It should really be $HOME/.local. What's your pip version? You might want to update this to pip 20 first (pip install pip --user should do).

Okay, thanks for the help. I this is progress but not quite there yet.
$ pip3 install meshio
Collecting meshio
  Downloading https://files.pythonhosted.org/packages/12/0e/44d6af1480791676d375f3c3e8ef5d40521a2529fddb180fef401ff414d0/meshio-4.0.2-py3-none-any.whl (125kB)
    100% |████████████████████████████████| 133kB 1.2MB/s
Collecting numpy (from meshio)
  Downloading https://files.pythonhosted.org/packages/63/0c/0261693cc3ad8e2b66e66dc2d2676a2cc17d3efb1c58a70db73754320e47/numpy-1.18.1-cp37-cp37m-manylinux1_x86_64.whl (20.1MB)
    100% |████████████████████████████████| 20.1MB 94kB/s
Installing collected packages: numpy, meshio
  The scripts f2py, f2py3 and f2py3.7 are installed in '/home/jbakosi/.local/bin' which is not on PATH.
  Consider adding this directory to PATH or, if you prefer to suppress this warning, use --no-warn-script-location.
  The scripts meshio-ascii, meshio-binary, meshio-compress, meshio-convert, meshio-decompress and meshio-info are installed in '/home/jbakosi/.local/bin' which is not on PATH.
  Consider adding this directory to PATH or, if you prefer to suppress this warning, use --no-warn-script-location.
Successfully installed meshio-4.0.2 numpy-1.18.1
$ ~/.local/bin/meshio-convert sphere_tetra.1.ugrid sphere_tetra.1.exo
Traceback (most recent call last):
  File "/home/jbakosi/.local/bin/meshio-convert", line 10, in <module>
    sys.exit(convert())
  File "/home/jbakosi/.local/lib/python3.7/site-packages/meshio/_cli/_convert.py", line 35, in convert
    write(args.outfile, mesh, **kwargs)
  File "/home/jbakosi/.local/lib/python3.7/site-packages/meshio/_helpers.py", line 117, in write
    file_format = _filetype_from_path(path)
  File "/home/jbakosi/.local/lib/python3.7/site-packages/meshio/_helpers.py", line 33, in _filetype_from_path
    raise ReadError("Could not deduce file format from extension '{}'.".format(ext))
meshio._exceptions.ReadError: Could not deduce file format from extension '.1.exo'.
jbakosi@euler:~/code/etc/ugrid$ ~/.local/bin/meshio-convert sphere_tetra.1.ugrid sphere_tetra.exo
Traceback (most recent call last):
  File "/home/jbakosi/.local/bin/meshio-convert", line 10, in <module>
    sys.exit(convert())
  File "/home/jbakosi/.local/lib/python3.7/site-packages/meshio/_cli/_convert.py", line 35, in convert
    write(args.outfile, mesh, **kwargs)
  File "/home/jbakosi/.local/lib/python3.7/site-packages/meshio/_helpers.py", line 117, in write
    file_format = _filetype_from_path(path)
  File "/home/jbakosi/.local/lib/python3.7/site-packages/meshio/_helpers.py", line 33, in _filetype_from_path
    raise ReadError("Could not deduce file format from extension '{}'.".format(ext))
meshio._exceptions.ReadError: Could not deduce file format from extension '.exo'.

How do I tell meshio that I want exodus output?

Aha! Use .e, but .exo should actually work as well.

$ ~/.local/bin/meshio-convert sphere_tetra.1.ugrid sphere_tetra.e
Traceback (most recent call last):
  File "/home/jbakosi/.local/bin/meshio-convert", line 10, in <module>
    sys.exit(convert())
  File "/home/jbakosi/.local/lib/python3.7/site-packages/meshio/_cli/_convert.py", line 35, in convert
    write(args.outfile, mesh, **kwargs)
  File "/home/jbakosi/.local/lib/python3.7/site-packages/meshio/_helpers.py", line 117, in write
    file_format = _filetype_from_path(path)
  File "/home/jbakosi/.local/lib/python3.7/site-packages/meshio/_helpers.py", line 33, in _filetype_from_path
    raise ReadError("Could not deduce file format from extension '{}'.".format(ext))
meshio._exceptions.ReadError: Could not deduce file format from extension '.e'.

Ah, right. You need netCDF4 installed, otherwise meshio can't do nothing.

Cool. Should I just pull it in using apt-get or pip or some other recommended way so meshio finds it?

netCDF4 itself has more dependencies, so I usually use apt.

Uh! Success! Thanks a lot for the help. I did apt-get install python3-netcdf4 to make netcdf4 available in python3.
One minor note: The ugrid -> exodus conversion took over the node coordinates, and the triangle and tetrahedron connectivities, but did not create side sets.

Yeah, node sets aren't supported yet; I think there's an open issue for it. If not, feel free to open a new one.

Yeah, I figured. This is already very useful, though, since side sets and node sets to exo files can be added with another tool, e.g., cubit.


Incorrect results on bigger projects

Hello! I'm trying to use unimport with couple of both my-personal projects and some work related products we have in-house. (Actually, more than a couple, both day-job and customers whom I do consultancy have their own codebases).
For my personal projects it seems to work real well, but whenever I'm trying to introduce the unimport to bigger codebases than mine, it just halts the project, half of the test cases starts to fail, etc...
Not really going to ask you to investigate all of them, obviously. But can you at least put couple of big python codebases to testing pipeline so we can get a rough idea how consistent unimport works?
Couple of ideas: CPython, Twisted, Tornado, Zope, Django
Seeing these pass would make me question my codebase, but seeing that the tests that pass without unimport failing right after makes me think there could be some bugs left undiagnosed.
Now that I think of it, one of the biggest problems I assume are the __init__.py imports, no one in the wild west before added the init imports to __all__, it could come handy to make it optional for old folks like me to adapt easier.

There are currently two known Unimport cases that do not have support yet.
for example.
if True:
    import x
else:
    import x

import x

def f ():
     import x
     return x

print (x)

Unimport detects these two situations wrong because

If, elif, else statement analysis isn't done in Unimport yet.
Scope analysis isn't done in Unimport yet.

If you have these situations in your codebase, we recommend using  # unimport: skip or # unimport: skip_file comment and if you don't want __init__  files to be scanned, you can use the --exclude flag, this issue has been discussed before and we decided not to add a flag like --ignore-init.

this issue has been discussed before and we decided not to add a flag like --ignore-init.

Can you link the issue if it is somewhere public? Thanks!


Show loader and Loading the first tiles  (slow network

I have issue with slow network . Like 3-5 seconds to get tiles
How can I show a loader on the image and remove it when first tile is ready.
Also I would like to print something on the canvas . But I would like to do that only when all tiles has finished
Thanks a lot

You'll want to use the fully-loaded-change event. See https://github.com/openseadragon/openseadragon/issues/1257 for examples.
As for printing something on the canvas, there are lots of options. If you want it to move with the canvas, you can make an overlay. If you just want it to hover over the viewer, you can just make a regular HTML element. http://openseadragon.github.io/#plugins also has more advanced overlay options.


Make available for deployment on CSP sub.

Let us know the feedback or general question
Would it be possible to allow the deployment of the accelerator on Azure CSP subs please?

@MTersago thanks for your feedback we are reviewing.
@swathibhat1

@swathibhat1 the AVD LZA will need to be included as an offer on the partner center, please contact the partner/business team.
@MTersago we are working internally to make it available.

The AVD LZA is not available on MSFT Partner Center, see screenshot below.
@.***
From: Dany Contreras @.>
Sent: maandag 2 december 2024 16:06
To: Azure/avdaccelerator @.>
Cc: Tersago, Marnix @.>; Mention @.>
Subject: Re: [Azure/avdaccelerator] Make available for deployment on CSP sub. (Issue #712)
You don't often get email from<EMAIL_ADDRESS>Learn why this is importanthttps://aka.ms/LearnAboutSenderIdentification
This email originated outside of TD SYNNEX.  Please help keep our organization and partners safe. It's up to us; think before you click.
@swathibhat1https://github.com/swathibhat1 the AVD LZA will need to be included as an offer on the partner center, please contact the partner/business team.
@MTersagohttps://github.com/MTersago we are working internally to make it available.

Reply to this email directly, view it on GitHubhttps://github.com/Azure/avdaccelerator/issues/712#issuecomment-2511788104, or unsubscribehttps://github.com/notifications/unsubscribe-auth/BM4YVXUVOBLONFO6YNRNCZ32DRZN5AVCNFSM6AAAAABRWDOF2OVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDKMJRG44DQMJQGQ.
You are receiving this because you were mentioned.Message ID<EMAIL_ADDRESS>

Screenshot does show in my email reply above, adding it here: