changing max authorities for pallet_babe and pallet_grandpa

Description of proposed changes

Practical tips for PR review & merge:

[ ] All GitHub Actions report PASS
[ ] Newly added code/functions have unit tests

[ ] Coverage tools report all newly added lines as covered
[ ] The positive scenario is exercised
[ ] Negative scenarios are exercised, e.g. assert on all possible errors
[ ] Assert on events triggered if applicable
[ ] Assert on changes made to storage if applicable

[ ] Modified behavior/functions - try to make sure above test items are covered
[ ] Integration tests are added if applicable/needed

There is no real information in the documentation about what the proper values for MaxAuthorities should be for pallet_babe and pallet_grandpa. To make it match the mocks for substrate we can use 10 and 100 respectively. The warning is issued by a weakly bounded vector that has optional warning messages that are triggered when the bounds are bypassed. So the code is still working as the bounds are only weakly enforced but the warning is printed.
Getting the number wrong is low risk so I upped grandpa to 100 and doubled babe to 256.

Codecov Report

Merging #1200 (6a2bff9) into dev (f4d0188) will decrease coverage by 62.60%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##              dev   #1200       +/-   ##
==========================================
- Coverage   69.65%   7.06%   -62.60%
==========================================
  Files         100      25       -75
  Lines       11743     722    -11021
  Branches       83      83
==========================================
- Hits         8180      51     -8129
+ Misses       3563     671     -2892

see 75 files with indirect coverage changes
:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more

On runtime/src/lib.rs on line 290 the max authorities for pallet_grandpa are upped from 32 to 256. The warnings come from the grandpa pallet not babe so I just cleaned up the comments since they were related to the issue at hand.


Not able to see demo in chrome

Hi Team,
 I appreciated your work but this demo is not working in chrome.

Hi @stardev24 the demo works fine for me on secure origins. Have you checked https://sites.google.com/a/chromium.org/dev/Home/chromium-security/deprecating-powerful-features-on-insecure-origins ?

Possibly related to https://github.com/lucaslouca/video-conference-webrtc/pull/10


FIX a11y setup being undefined

Issue: a11y config when not set can cause an error
What I did
Fix it by adding a default config of {}

@shilman


chore: rm event emission after context caching

Description

NOTE: e2e tests in this pr have a dependency on this bump to SDK 0.464
closes: #2646

Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.

[ ] Targeted PR against correct branch (see CONTRIBUTING.md)
[ ] Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
[ ] Code follows the module structure standards.
[ ] Wrote unit and integration tests
[ ] Updated relevant documentation (docs/) or specification (x/<module>/spec/)
[ ] Added relevant godoc comments.
[ ] Added a relevant changelog entry to the Unreleased section in CHANGELOG.md
[ ] Re-reviewed Files changed in the Github PR explorer
[ ] Review Codecov Report in the comment section below once CI passes

As long as everyone can agree to never discard the sdk.Result value on msg execution then I'm happy enough with it, just to me it seems a little bit error prone.

can you point to an example of this? (non-discarding the sdk.Result)

As long as everyone can agree to never discard the sdk.Result value on msg execution then I'm happy enough with it, just to me it seems a little bit error prone.

can you point to an example of this? (non-discarding the sdk.Result)

Sure. Check out these PRs on the sdk to fix the events in x/gov and x/group:

https://github.com/cosmos/cosmos-sdk/pull/12888
https://github.com/cosmos/cosmos-sdk/pull/13728

In both cases the res was being discarded using the underscore _ and as a result events were being lost.

amazing thanks @damiannolan


Translation into German

For German speakers, please note that I'm not a native speaker, so if I
have made some mistake, please report it and it will be fixed.

I don't know how to make a clean pull request without references to past history. I think you should use the Squash and Merge button in order to be sure that the old commits do not appear in history.


⚠ Bofrost.fr has degraded performance

In 8680cb7, Bofrost.fr (https://www.bofrost.fr) experienced degraded performance:

HTTP code: 200
Response time: 962 ms

Resolved: Bofrost.fr performance has improved in 23fc571 after 6 minutes.


Memory leaks report by Dr.Memory Windows (OpenSSL-1.1.1c) #6

Hi,
Dr.Memory (2.1.0) report this:
Error #3: LEAK 32 direct bytes 0x024a4580-0x024a45a0 + 24 indirect bytes
# 0 replace_RtlAllocateHeap                                [d:\drmemory_package\common\alloc_replace.c:3771]
# 1 ntdll.dll!RtlDeleteCriticalSection                    +0x15b    (0x7c9114b6 <ntdll.dll+0x114b6>)
# 2 ntdll.dll!RtlInitializeCriticalSectionAndSpinCount    +0x4b     (0x7c911546 <ntdll.dll+0x11546>)
# 3 KERNEL32.dll!InitializeCriticalSectionAndSpinCount    +0x14     (0x7c80b8ce <KERNEL32.dll+0xb8ce>)
# 4 libcrypto-1_1.dll!CRYPTO_THREAD_lock_new               [c:\dll\openssl-1.1.1c\crypto\threads_win.c:29]
# 5 libcrypto-1_1.dll!RSA_new_method                       [c:\dll\openssl-1.1.1c\crypto\rsa\rsa_lib.c:60]
# 6 libcrypto-1_1.dll!RSA_new                              [c:\dll\openssl-1.1.1c\crypto\rsa\rsa_lib.c:22]
# 7 libcrypto-1_1.dll!rsa_cb                               [c:\dll\openssl-1.1.1c\crypto\rsa\rsa_asn1.c:26]
# 8 libcrypto-1_1.dll!asn1_item_embed_new                  [c:\dll\openssl-1.1.1c\crypto\asn1\tasn_new.c:109]
# 9 libcrypto-1_1.dll!ASN1_item_ex_new                     [c:\dll\openssl-1.1.1c\crypto\asn1\tasn_new.c:39]
#10 libcrypto-1_1.dll!asn1_item_embed_d2i                  [c:\dll\openssl-1.1.1c\crypto\asn1\tasn_dec.c:306]
#11 libcrypto-1_1.dll!ASN1_item_d2i                        [c:\dll\openssl-1.1.1c\crypto\asn1\tasn_dec.c:114]

Error #4: LEAK 32 direct bytes 0x024a4600-0x024a4620 + 24 indirect bytes
# 0 replace_RtlAllocateHeap                                [d:\drmemory_package\common\alloc_replace.c:3771]
# 1 ntdll.dll!RtlDeleteCriticalSection                    +0x15b    (0x7c9114b6 <ntdll.dll+0x114b6>)
# 2 ntdll.dll!RtlInitializeCriticalSectionAndSpinCount    +0x4b     (0x7c911546 <ntdll.dll+0x11546>)
# 3 KERNEL32.dll!InitializeCriticalSectionAndSpinCount    +0x14     (0x7c80b8ce <KERNEL32.dll+0xb8ce>)
# 4 libcrypto-1_1.dll!CRYPTO_THREAD_lock_new               [c:\dll\openssl-1.1.1c\crypto\threads_win.c:29]
# 5 libcrypto-1_1.dll!EVP_PKEY_new                         [c:\dll\openssl-1.1.1c\crypto\evp\p_lib.c:152]
# 6 libcrypto-1_1.dll!x509_pubkey_decode                   [c:\dll\openssl-1.1.1c\crypto\x509\x_pubkey.c:106]
# 7 libcrypto-1_1.dll!pubkey_cb                            [c:\dll\openssl-1.1.1c\crypto\x509\x_pubkey.c:46]
# 8 libcrypto-1_1.dll!asn1_item_embed_d2i                  [c:\dll\openssl-1.1.1c\crypto\asn1\tasn_dec.c:413]
# 9 libcrypto-1_1.dll!asn1_template_noexp_d2i              [c:\dll\openssl-1.1.1c\crypto\asn1\tasn_dec.c:625]
#10 libcrypto-1_1.dll!asn1_template_ex_d2i                 [c:\dll\openssl-1.1.1c\crypto\asn1\tasn_dec.c:499]

Error #6: LEAK 208 direct bytes 0x039de288-0x039de358 + 6704 indirect bytes
# 0 replace_malloc                    [d:\drmemory_package\common\alloc_replace.c:2577]
# 1 libcrypto-1_1.dll!CRYPTO_zalloc   [c:\dll\openssl-1.1.1c\crypto\mem.c:230]
# 2 libcrypto-1_1.dll!asn1_item_embed_new [c:\dll\openssl-1.1.1c\crypto\asn1\tasn_new.c:122]
# 3 libcrypto-1_1.dll!ASN1_item_ex_new [c:\dll\openssl-1.1.1c\crypto\asn1\tasn_new.c:39]
# 4 libcrypto-1_1.dll!asn1_item_embed_d2i [c:\dll\openssl-1.1.1c\crypto\asn1\tasn_dec.c:306]
# 5 libcrypto-1_1.dll!ASN1_item_d2i   [c:\dll\openssl-1.1.1c\crypto\asn1\tasn_dec.c:114]

Thanks.

Thanks for your report. To make it better readable, I added three backticks on a separate  lines before and after it.

The fact that the leaked memory was allocated by OpenSSL does not necessarily imply that it was leaked by OpenSSL. It was allocated on behalf of the application and in many cases it's the application that leaked it.
To decide who leaked the memory, we would need more information about what your application did. The optimal case would be, if you could break down the issue to a small compilable sample program which encounters the issue. If not possible, please provide at least some pseudo code of what your application was doing before it leaked.

Hi,
You can be right.
My app call some function with d2i:
p12 = d2i_PKCS12_bio(in, NULL);
BIO_free(in);
...
PKCS12_free(p12);
I believe that my app, freed all pointers, but, some mystake can occurs.
I will investigate better.
Thanks.

[SOLVED],
Wrong report. leak is in the app.
SSL_CTX_use_certificate and SSL_CTX_use_PrivateKey with local pointer reference, need
explicit freed.
SSL_CTX_use_certificate -> X509_free;
SSL_CTX_use_PrivateKey -> EVP_PKEY_free
Now Dr.Memory do not report leak.
Thank you.


Set anchors in the preview container to open in a new tab

This PR adds target blank to anchors generated in the preview container so the user doesn't loose the current page when clicking them.
Context

This looks good to me. Should we being writing some JS tests for this sort of thing?
There's a risk this will conflict with the work Ben is doing with https://trello.com/c/77pWuPzi/170-render-govspeak-server-side so might be worth checking in with him in case we'll need to fix it a different way with that.

@kevindew That's true, although we're going to have to do this somewhere, and it looks like it's easier to do in JavaScript. What do you think - Ruby v. JS?

Yeah, whichever way seems easier for this since it'll be inserted via JS.


Dockerize metagov service

Dockerize metagov to make install process easier.
Update install docs- https://docs.metagov.org/en/latest/installation.html

Related to this: https://github.com/policykit/policykit/pull/560

@thelastjosh I can do the docker integration for gateway as well. I will need more details though of it's working and I should be able to do it probably this or next week depending upon the priority of tickets.

cool, feel free to grab some time on my calendly.com/josh-tan if you want to chat about it / let's discuss later today at the meeting.

I think that creating a separate docker image for "standalone metagov" is fairly low priority. Basically everyone interacting with Gateway right now is doing so through PolicyKit, so the dockerized PolickyKit should cover all current needs.


add nodePackages vega-cli and vega-lite

Motivation for this change
Adds the vega and the vega-lite command line tools for plotting. This means the binaries:
vg2svg
vg2pdf
vg2png
vl2vg
vl2pdf
vl2svg
vl2png

Vegalite required substituting some lines that call npx to install vega on the fly. Maybe there is a better solution. I tested these tools with:
nix-shell --pure -I nixpkgs=./nixpkgs -p busybox -p nodePackages.vega-cli --command "wget -O - https://vega.github.io/vega/examples/bar-chart.vg.json | vg2png > vega-cli-test.png"

nix-shell --pure -I nixpkgs=./nixpkgs -p busybox -p nodePackages.vega-lite --command "wget -O - https://raw.githubusercontent.com/vega/vega-lite/master/examples/specs/bar.vl.json | vl2png > vega-lite-test.png"

Things done

[ ] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
Built on platform(s)

[x] NixOS
[ ] macOS
[ ] other Linux distributions

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
[x] Tested execution of all binary files (usually in ./result/bin/)
[ ] Determined the impact on package closure size (by running nix path-info -S before and after)
[ ] Ensured that relevant documentation is up to date
[ ] Fits CONTRIBUTING.md.

I tried to run nixpkgs-review pr --post-result 97908 and stopped it after 2h because I needed the CPU. It somehow seems to hang on twemoji, mojione and sagedoc. inkscape also somehow appears there. The output that I got until then is:
$ git -c fetch.prune=false fetch --force https://github.com/NixOS/nixpkgs master:refs/nixpkgs-review/0 pull/97908/head:refs/nixpkgs-review/1
$ git worktree add /home/matto/.cache/nixpkgs-review/pr-97908-1/nixpkgs 24fa210e772351f118e5f56e5acbe5eaea38a95f
Preparing worktree (detached HEAD 24fa210e772)
Updating files: 100% (22686/22686), done.
HEAD is now at 24fa210e772 rclone: 1.53.0 -> 1.53.1 (#97953)
$ nix-env -f /home/matto/.cache/nixpkgs-review/pr-97908-1/nixpkgs -qaP --xml --out-path --show-trace
$ git merge --no-commit 690fffccf47b4561013912dd37d5bda8ea8484b7
Automatic merge went well; stopped before committing as requested
$ nix-env -f /home/matto/.cache/nixpkgs-review/pr-97908-1/nixpkgs -qaP --xml --out-path --show-trace --meta
39 packages updated:
bitwarden-cli emojione etcher image_optim lumo node_castnow node_create-cycle-app node_imapnotify joplin (1.0.166 → 1.0.167) node_mirakurun netlify-cli (2.61.0 → 2.62.0) node_redoc-cli node_thelounge node_triton node__at_antora_slash_cli node__at_webassemblyjs_slash_wasm-text-gen parity-ui ripcord sage sage sage slack slack twemoji-color-font vimPlugins.coc-css (1.2.4 → 1.2.5) vimPlugins.coc-eslint (1.2.7 → 1.3.0) vimPlugins.coc-git (1.8.3 → 2.0.0) vimPlugins.coc-go (0.10.0 → 0.11.0) vimPlugins.coc-highlight (1.2.5 → 1.2.6) vimPlugins.coc-jest (1.0.3 → 1.0.4) vimPlugins.coc-json (1.2.6 → 1.3.0) vimPlugins.coc-metals (0.9.2 → 0.9.3) vimplugin-coc-prettier vimPlugins.coc-r-lsp (1.1.1 → 1.2.0) vimPlugins.coc-snippets (2.1.28 → 2.2.0) vimPlugins.coc-solargraph (1.1.6 → 1.1.7) vimplugin-coc-stylelint vimPlugins.coc-tsserver (1.5.5 → 1.5.6) vimPlugins.coc-vetur (1.1.12 → 1.1.13)

$ nix build --no-link --keep-going --option build-use-sandbox relaxed -f /home/matto/.cache/nixpkgs-review/pr-97908-1/build.nix
builder for '/nix/store/b42m79dxaz44gjb4gpg3mmlwdr4zxy4h-node_joplin-1.0.167.drv' failed with exit code 1; last 10 log lines:
  npm ERR! errno 1
  npm ERR<EMAIL_ADDRESS>install: `prebuild-install || node-gyp rebuild`
  npm ERR! Exit status 1
  npm ERR!
  npm ERR! Failed at the<EMAIL_ADDRESS>install script.
  npm ERR! This is probably not a problem with npm. There is likely additional logging output above.

  npm ERR!

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:
https://discourse.nixos.org/t/prs-ready-for-review/3032/299

@MMesch It's almost impossible to merge changes to node packages, unfortunately. Could you please fix them and ping me when you are ready? Preferably, git add all the files (don't use --patch to select only the changes relevant to you). I promise I'll merge it before there are merge conflicts.
Once that'll be done, I'd be happy to get your help on https://github.com/NixOS/nixpkgs/pull/96961 .

Hi @doronbehar

It's almost impossible to merge changes to node packages, unfortunately

What do you mean with this? Is it possible or not? I looked on your PR and saw that you suggested generating nix expressions for the packages you want to add independently. I have done that equally for vega-cli and vega-lite on my machine. Do you think it would be better to move forward like this?
Also, I already added git add everything! Are there files that you are missing?

What do you mean with this?

I mean that as a contributor, with no merge permissions, it's impossible to put out a PR, and when the time comes for a committer to merge it, the PR has no merge conflicts.

I have done that equally for vega-cli and vega-lite on my machine. Do you think it would be better to move forward like this?

It depends on you. For balena-cli, I realized at a certain point I have to do it because their releases are too frequent for node packages' generate.sh. If you'd like to have more influence upon it, I'd suggest to make it have it's own set of generated nix expressions. Plus, for sure you'd probably won't encounter merge conflicts with the generated expressions.

Are there files that you are missing?

I don't think so, but I haven't checked.

@doronbehar I have rebased and regenerated node-packages.nix for the two relevant commits. Maybe I didn't understand if you wanted to do anything else. Let me know!
In case there are conflicts again, this can be rebased from the nodePackages folder with:
git fetch
git rebase origin/master
git checkout --theirs node-packages.nix
./generate.sh
git add .
git rebase --continue
git checkout --theirs node-packages.nix
./generate.sh
git add .
git rebase --continue

(takes ~2h on my machine)

Right! Sorry. It should be deleted. Do you want me to do it again?
Doron Behar<EMAIL_ADDRESS>schrieb am Sa., 19. Sep. 2020, 13:41:

@doronbehar commented on this pull request.
In pkgs/development/node-packages/default.bak
https://github.com/NixOS/nixpkgs/pull/97908#discussion_r491398764:

@@ -0,0 +1,200 @@
+{ pkgs, nodejs, stdenv }:

This file is a Git rebase leftover right?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/NixOS/nixpkgs/pull/97908#pullrequestreview-491993335,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AAT2HK2QY5ZJI4UQYK3UGZ3SGSKGVANCNFSM4RKVLFJQ
.

You should be able to spare yourself running ./generate.sh, but you should need rewriting history a bit.

I hope it's ok now @doronbehar . I ran the vega-cli and vega-lite tests that I posted above and they work.

Sorry for the formatting issues. How about now @doronbehar ?

@MMesch after fixing once more the indentation, please apply this patch:
diff --git i/pkgs/development/node-packages/default.nix w/pkgs/development/node-packages/default.nix
index 71b9bd77411..8d8d9fc89ae 100644
--- i/pkgs/development/node-packages/default.nix
+++ w/pkgs/development/node-packages/default.nix
@@ -181,6 +181,8 @@ let
         # https://sharp.pixelplumbing.com/install
         vips

+        libsecret
+        self.node-gyp-build
         self.node-pre-gyp
       ];
     };

And commit it as: joplin: fix build by adding libsecret and node-gyp-build.
It's not related to your PR, but these are new deps that your update to all of node packages require - since you ran ./generate.sh.

Ah s... I forgot that one. Unfortunately I can't do it until tomorrow. If
you have the time to amend this and merge go ahead, otherwise it has to
wait.
Thabks for the help and sorry for all the work :( I tried to use nixfmt on
this but it changes a lot of other things.
Doron Behar<EMAIL_ADDRESS>schrieb am Sa., 19. Sep. 2020, 16:34:

@doronbehar commented on this pull request.

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/NixOS/nixpkgs/pull/97908#pullrequestreview-492002491,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AAT2HK7AGDYY33KHZW4DWL3SGS6RDANCNFSM4RKVLFJQ
.

Many thanks for you help @doronbehar . How can I help with your PR?

TBH I only want someone to approve it for the record, and verify that it works. And comments upon meta data or such would be welcome https://github.com/NixOS/nixpkgs/pull/96961 .


https://github.com/second-state/dapr-wasm/pull/42

flows summarize

Hello, I am a code review bot on flows.network.
It could take a few minutes for me to analyze this PR. Relax, grab a cup of coffee and check back later. Thanks!


Add support for nRF54H20 to nrfutil runner

Note: compliance failure doesn't provide enough context to resolve the issue (if relevant at all)
Check warning on line 1 in scripts/west_commands/tests/test_nrf.py

GitHub Actions
/ Run compliance checks on patch series (PR)
R0801
scripts/west_commands/tests/test_nrf.py:1 Similar lines in 2 files


FAB Size

I love the updates and everything is great. It would be cool if you could size the button similar to how floating action buttons are sized (e.g. mini or normal) to keep the menu consistent with FAB.

Will add it soon.

Hi @thailey01 The FAB doesn't provide an API to control the size programatically. With the current design of the library, this won't be possible.


Service page needs to be responsive

Hello @khushi-joshi-05 please assign this issue to me under gssoc 24

This issue is already solved.
Try to contribute to different issues.


Wrong execution window in logs

I am using the last version of your library (1.2.4) on API 23 in emulator.
This sample code produces wrong behavior for me:
JobRequest.Builder(TAG)
                    .setExecutionWindow(1000L, (5*60*1000).toLong())    //5 minutes from now
                    .setUpdateCurrent(true)
                    .setRequiredNetworkType(JobRequest.NetworkType.NOT_ROAMING)
                    .setRequirementsEnforced(true)
                    .build()
                    .schedule()

Library treats second argument of execution window (5 * 6 * 1000) as seconds - not ms like documentation assumes, so I can see this line in log which tells about 8 hours execution window:
Schedule one-off jobInfo success, request{id=302, tag=JobUploadAudio, transient=false}, start 00:00:01, end 08:20:00 (from now), reschedule count 0

If I replace execution window to  .setExecutionWindow(1000L, 2000L) I get start 00:00:01, end 00:03:20 which is completely wrong too.

This issue has been fixed in version 1.2.5. Thanks for reporting it!

Sorry for not answering for so long.
Maybe I don't understand how library should work, but error not only in log message.
As I wrote here in original message:

If I replace execution window to .setExecutionWindow(1000L, 2000L) I get start 00:00:01, end 00:03:20 which is completely wrong too.

And job execution will start EXACTLY AFTER 03:20 since scheduling. Not after 2 seconds as I requested. Can you explain me why if it is not a bug?
P.S. Library v1.2.5
P.P.S On other then API23 it will start in 2 seconds as expected.

Because you enforce the requirements. That means your job won't run, if the requirements aren't met. JobScheduler is smarter and will run your job when the requirements are met, that's why it allows to stretch the time window, if the requirements need to be met.


Need to check k8s-openapi features when importing

I am using EKS, which currently supports only Kubernetes 1.14. As such, I need to enable the v1_14 feature when using k8s-openapi. Unfortunately, kube imports a resource which doesn't exist in this version:
use k8s_openapi::api::admissionregistration::v1beta1::ValidatingWebhook;
    ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ no `ValidatingWebhook`
 in `api::admissionregistration::v1beta1`

Ugh, yeah, you're right. For now; I'd recommend you use 1.15 against a 1.14 cluster (whichi is almost certainly going to be fine), but we should check this properly. Thanks.


TEPHRA-53 Add HBase 1.0 compatibility

This adds two new compatibility modules to support the two new versions of HBase:

tephra-hbase-compat-1.0 - supports Apache HBase 1.0.x releases
tephra-hbase-compat-1.0-cdh - supports the modified version of HBase shipped in CDH 5.4

Since the version of HBase shipped in CDH 5.4 is neither binary nor source compatible with Apache HBase 1.0, it needs to be supported as a separate build artifact.

Could we have comment indicating where the needs to have CDH specific code as Javadoc? I am seeing the CDH compatibility module but find it hard to find in the code diff which methods or code needed to be modified from support for Apache HBase 1.0

There are no modified methods in our implementations of the two modules.
What is different between Apache HBase 1.0 and CDH HBase 1.0 is the return types of various methods in the HBase Scan, Get, Delete, HTableDescriptor, HColumnDescriptor classes.  This means that if we only had 1 hbase-compat-1.0 module, it would only run on binaries from one of Apache HBase 1.0 or CDH 5.4 (whichever it was compiled against), and fail to run on binaries from the other.
We could skirt around this by using reflection to call any methods on these classes.  But they are fairly core classes, and from past experience using reflection in similar scenarios, it becomes difficult to maintain this code.
The API compatibility report showing the changes is an attachment on TEPHRA-53: https://issues.cask.co/secure/attachment/11016/hbase_1.0.0_vs_cdh5.4.2-release_compat_report.html

Thanks for the links, I understand what you mean.

I did a pass and did not see anything glaringly wrong.
Mostly to accommodate CDH version of HBase API changes.
LGTM


An error will be triggered when using<EMAIL_ADDRESS>

In my project<EMAIL_ADDRESS>is used to transpile the code.
Its dependency chain: 【<EMAIL_ADDRESS>-><EMAIL_ADDRESS>-><EMAIL_ADDRESS>is normal. However, an error occurs because @jridgewell/gen-mapping has been upgraded to version 0.3.6：
Error: Cannot find module<EMAIL_ADDRESS>

Please refer to #14

@jridgewell Please set the latest tag to  version 0.3.5 ? Thanks~

@jridgewell Um, I couldn't find @jridgewell/gen-mapping like, at all, on NPM. Did you in fact unpublished the whole thing? I don't think that helps...

I'm not sure if published versions can be rolled back, but the latest tag still shows 0.3.6

v0.3.7 is published now.


Use a different remote server for test

The previous server had issues, so the test timed out. Hopefully
this on is more stable.

Some tests fail, but at least not the .urlAdd http with redirection one anymore.

CI failed due to this issue: https://ci.ipfs.team/blue/organizations/jenkins/IPFS%2Fjs-ipfs-api/detail/PR-705/21/tests

For comparison. With this pull request, this test didn't fail: https://ci.ipfs.team/blue/organizations/jenkins/IPFS%2Fjs-ipfs-api/detail/PR-711/4/tests


Embedded structs v3

this is an update to https://github.com/google/jsonapi/pull/78.  I found it cleaner and more convenient to just cherry-pick my changes in the latest google/jsonapi.
All comments made to the last PR should be addressed here.

I think some additional tests should be added to demonstrate what should happen when fields are overlapping. Ie both have a field w/ primary annotation or an attr with the same name has been used.

I added these additional examples:

response_test.go:1135: running scenario: Model embeds Thing, models have no annotation overlaps
response_test.go:1135: running scenario: Model embeds Thing, overlap Buzz attribute
response_test.go:1135: running scenario: Model embeds Thing, attribute, and primary annotation overlap
response_test.go:1135: running scenario: Model embeds Thing, but is annotated w/ ignore

The expected behavior is that it will behave in the "expected" composition behavior; it will handle the top-level struct fields first, then handle any embedded structs after that.  So in the scenario where there is a top-level struct that has a primary annotation, that embeds another struct also containing a primary annotation, the top-level attribute wins.  (In the below example, the expected jsonapi payload should have a data/resource type of "posts")
type Post struct {
	Blog
	ID            uint64     `jsonapi:"primary,posts"`
	BlogID        int        `jsonapi:"attr,blog_id"`
	ClientID      string     `jsonapi:"client-id"`
	Title         string     `jsonapi:"attr,title"`
	Body          string     `jsonapi:"attr,body"`
	Comments      []*Comment `jsonapi:"relation,comments"`
	LatestComment *Comment   `jsonapi:"relation,latest_comment"`
}

Lastly, I felt it was getting complex and a bit messy, so I started splitting out unmarshalNode() into smaller functions for better readability.
Happy to add something to the readme.md if you think that would be useful

Is there a reason, that this MR got merged into google:feature/embeded-structs and that the feature branch has been lying there since, without getting merged/touched for more than a year? I would like to use the jsonapi in production, but would prefer if embedded-structs were supported.


Files sometimes doen't start

Description
It happens that, when starting the PC with Windows 10, the app does not start showing a black screen. So I have to restart the pc to use it since a forced closure doesn't help either
Steps To Reproduce

Start PC
Open the app (if doesn't work, reboot the PC)

Requirements
The application should open and function normally
Files Version
<IP_ADDRESS>
Windows Version
10.0.19045.3271
Log File
debug.log

Thanks for the report. In future only upload the debug.log file not the entire directory settings directory.

How are you opening Files? Through the start menu, using the task manager startup section or some other way.
What happens if you wait a few seconds.

Directly from the application bar. If I wait nothing happen, only black screen
Sent with Spark
Il 8 ago 2023, 16:03 +0200, Josh65-2201 @.***>, ha scritto:

Thanks for the report. In future only upload the debug.log file not the entire directory settings directory.
• How are you opening Files? Through the start menu, using the task manager startup section or some other way.
• What happens if you wait a few seconds.
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you authored the thread.Message ID: @.***>

@Mattiuz93 thank you for the report, this appears to be an issue in the WinAppSdk framework. There is a new version of WinAppSdk coming out in a few months which we hope includes a fix for this issue.

Thanks!
Sent with Spark
Il 15 ago 2023, 17:05 +0200, Yair @.***>, ha scritto:

@Mattiuz93 thank you for the report, this appears to be an issue in the WinAppSdk framework. There is a new version of WinAppSdk coming out in a few months which we hope includes a fix for this issue.
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you were mentioned.Message ID: @.***>

I've tried your new app and it's more faster, smooth and - for now - it doesn't have the bug that I've wrote

Sent with Spark
Il Aug 31, 2023, 10:31 PM +0200, Yair @.***> ha scritto:

@Mattiuz93 the latest preview version is using WinAppSdk 1.4, can you check if the issue is resolved? https://files.community/download
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you were mentioned.Message ID: @.***>


Include managementGroup().name as part of role assignment GUID to avoid possible duplicates.

Overview/Summary
This PR updates the parRoleAssignmentNameGuid default value is used to avoid potential duplicates:
Current:
@description('A GUID representing the role assignment name.  Default:  guid(parRoleDefinitionId, parAssigneeObjectId)')
param parRoleAssignmentNameGuid string = guid(parRoleDefinitionId, parAssigneeObjectId)

Updated:
@description('A GUID representing the role assignment name.  Default:  guid(managementGroup().name, parRoleDefinitionId, parAssigneeObjectId)')
param parRoleAssignmentNameGuid string = guid(managementGroup().name, parRoleDefinitionId, parAssigneeObjectId)

This PR fixes/adds/changes/removes

Possible duplicate roleAssignmentIds at Management Group scope when the parRoleAssignmentNameGuid default value is used.

Breaking Changes

Existing roleAssignmentIds at Management Group scope that utilized the default parRoleAssignmentNameGuid value.

Testing Evidence

As part of this Pull Request I have

[x ] Checked for duplicate Pull Requests
[ ] Associated it with relevant ADO items
[x ] Ensured my code/branch is up-to-date with the latest changes in the main branch
[x ] Performed testing and provided evidence.
[x ] Updated relevant and associated documentation.

@jtracey93 just updated the README.md, apologies for missing it the first time.


Freeze Transformer Weight

Can we finetune the model with Transformer layers' weight freeze (only train the embeddings and softmax)?

That is not currently supported by this codebase but is easy enough to do using either the HuggingFace library or by writing a small wrapper for this codebase.


Moves evdev ioctls to the common list.

Closes #4.

[note: ignore the travis failure. I need to actually get travis working]

Thanks!


possible fix of #198

I removed the asn.ASNOrigin class and move all functions to ASNOrigin module.
I also moved the get_asn_origin_whois and get_http_raw from net.Net to ASNOrigin module. Thus we do not need the strange Net object as __init__() argument.
I created dummy entry points to make it roughly compatible to old projects based on ASNOrigin class.
Several test cases will fail due to change ASNOrigin from class to module. The timeout value stored in Net object has no effect.

See #198 for details on PR closure


Support for NeoPixel/WS2812 LEDs?

Hello,
Is there built in support for programming NeoPixels in Codal-Microbit? I saw an issue that it was added in 0.2.20 (https://github.com/lancaster-university/codal-microbit-v2/issues/19), but I was unable to find an example on how to program these using the "MicroBit.h" library, and compilation via the Docker image found in https://github.com/lancaster-university/microbit-v2-samples.

Hi @joachimhs
Yes there is, but it is a little hidden, as we enabled it for all NRF52 based devices (not just microbit). You should just be able to call either of these two function to get hardware accelerated neopixel support:
https://github.com/lancaster-university/codal-nrf52/blob/master/inc/neopixel.h#L15
The function will block your running thread until the send is complete. if you want it to run in the background, just swap the function on this line to "playAsync" instead of "play".
https://github.com/lancaster-university/codal-nrf52/blob/master/source/neopixel.cpp#L25
Hope this helps.  I'll see if I have some sample code...

Thank you for your quick reply, @finneyj !
An example would be great, if you have one!
Very Best Regards,
Joachim

No problem @joachimhs.
I couldn't find my test sample, but something like this should do.. I'm afraid I don't have a neopixel strip to hand, so couldn't test it. Let me know if this works! :)
#include "neopixel.h"

void
neopixel_test()
{
    // Length of neopixel strip
    int length = 8;

    // Colour counter variable (just used to remember what colour we last displayed)
    int c = 0;

    // Create a buffer to hold pixel data of the appropriate size
    ManagedBuffer b(length*3);

    while(1)
    {
        // Clear the buffer to zeroes. You don't need to do this, but it's often convenient.
        b.fill(0);

        // Fill the buffer with some data.
        // Neopixel typically has 3 bytes per pixel, for each primary colour
        // in GRB format (Green, then Red, then Blue).
        for (int i=0; i<length*3; i+=3)
            b[i+c] = 255;

        // Update the neopixel strip on pin P0.
        neopixel_send_buffer(uBit.io.P0, b);

        // Increment our colour counter so that we show a different colour in the next frame.
        c = (c+1) %3;

        // Wait for a second.
        uBit.sleep(1000);
    }
}

Ah, this works like a charm!
I am now able to finally provide NeoPixel support for my blocks-based software for programming micro-controllers that I have made for kids in Norway :)
I wrote two small classes to be able to simplify the code a little bit, influenced by the Adafruit NeoPixel library that I utilise for Arduino-Core MCUs.  I am attaching this at the end for anyone interested. Rudimentary so far, but working :)

class BlockuinoNeoPixelColor {     public:         int red;     int green;     int blue;     BlockuinoNeoPixelColor(int in_red, int in_green, int in_blue) {         red = in_red;         green = in_green;         blue = in_blue;     } }; class BlockuinoNeoPixel {     public: int pin;     int pixels;     int brightness = 50;     ManagedBuffer pixelBuffer;     BlockuinoNeoPixel(int in_pin, int in_pixels) {         pin = in_pin;         pixels = in_pixels;         pixelBuffer = ManagedBuffer(pixels * 3);         pixelBuffer.fill(0);     }     void setPixelColor(int in_pixel, BlockuinoNeoPixelColor color) {         if (in_pixel <pixels) {             pixelBuffer[(in_pixel * 3) + 0] = brightness_map(color.green, 0, 255, 0, brightness);             pixelBuffer[(in_pixel * 3) + 1] = brightness_map(color.red, 0, 255, 0, brightness);             pixelBuffer[(in_pixel * 3) + 2] = brightness_map(color.blue, 0, 255, 0, brightness);         }     }     void setBrightness(int in_brightness) {         brightness = in_brightness;     }     void show() {         neopixel_send_buffer(uBit.io.pin[pin], pixelBuffer);     }     void clear() {         pixelBuffer.fill(0);     }     void begin() {         pixelBuffer.fill(0);     }     int numPixels() {         return pixels;     }     long brightness_map(long x, long in_min, long in_max, long out_min, long out_max) {         return (x - in_min) * (out_max - out_min) / (in_max - in_min) + out_min;     } }; BlockuinoNeoPixel strip(1, 8);

Is there something similar for the V1 version of the micro:bit?

Thanks @finneyj for the sample code and @joachimhs for sharing!
Unfortunately, I am not able to get the neopixel.h functions and the neopixel.h function working. I use a microbit v2 and the microbit-v2-samples repo in the latest version, with build.py.
I successfully built and ran other examples. The only change I made to microbit-v2-samples is in the main.cpp:
#include "MicroBit.h"
#include "neopixel.h"
MicroBit uBit;

void neopixel_test()
{
    // Length of neopixel strip
    int length = 8;

    // Colour counter variable (just used to remember what colour we last displayed)
    int c = 0;

    // Create a buffer to hold pixel data of the appropriate size
    ManagedBuffer b(length*3);

    while(1)
    {
        // Clear the buffer to zeroes. You don't need to do this, but it's often convenient.
        b.fill(0);

        // Fill the buffer with some data.
        // Neopixel typically has 3 bytes per pixel, for each primary colour
        // in GRB format (Green, then Red, then Blue).
        for (int i=0; i<length*3; i+=3)
            b[i+c] = 255;

        // Update the neopixel strip on pin P0.
        neopixel_send_buffer(uBit.io.P0, b);

        // Increment our colour counter so that we show a different colour in the next frame.
        c = (c+1) %3;

        // Wait for a second.
        uBit.sleep(1000);
    }
}

int main()
{
    uBit.init();
    while(1){
        neopixel_test();

    }

}

I used the GDB debug interface and saw that the micro:bit always goes into a forever loop when trying to execute: neopixel_send_buffer(uBit.io.P0, b); Any ideas?
Can anyone confirm that the neopixel.h file is currently working?
Thank you,
Hugo

Thanks for the update on your issue @fabianhugo, glad you got it working in the end.
I think we can close this issue as resolved, but if there is anything that still needs looking into please feel free to open the issue 👍
Thanks everyone!


permission_required

Greetings, this app has a option for permission_required?

It supports method registration where a user permission can be checked. request is passed into the function prior to rendering.  Look for the is_user_is_paid_customer in the README file.

can i pass another parameter? because i need to know which permission need to be checked

No. you can write a very simple middleware to include the permission in the request dict.

Thank you very much.


Last video always exist when turkic publish --offline

When I usedturkic publish --offline,the last video always exist in the front part when I downloaded a new video.
How can I fix it?

Could you clarify a bit? Are you talking about merging between segments or are you talking about videos themselves? I'm a little confused on what you mean here.

@zesoft23 When I imported a new video with new extracted frame, the video in the new url is just the video I annotated in the past or sometimes it's just the mix video with the new and the past.

@zesoft23 When I imported a new video with new extracted frame, the video in the new url is just the video I annotated in the past or sometimes it's just the mix video with the new and the past.

Hi,  I also encounter this problem,  and I am wondering have you solved it?


Javascript Docs redirect on https://docs.textile.io/ leads to 404 page

Describe the bug
At https://docs.textile.io/ specifically the Javascript Docs link, redirects to a 404 site (https://textileio.github.io/js-threads/)

To Reproduce
Steps to reproduce the behavior:

Go to https://docs.textile.io/
Click on Javascript docs
See error

Expected behavior
Redirect to this repo's readme ?

oop, yep. looks like the About section on https://github.com/textileio/js-threads missed an update too

oop, yep. looks like the About section on https://github.com/textileio/js-threads missed an update too


fix(STONEINTG-1091): don't set commitStatus for PR/MR from forked repo

Don't set commitStatus if the PR/MR is from forked repo since the limitation access

Maintainers will complete the following section

[ ] Commit messages are descriptive enough (hints)
[ ] Code coverage from testing does not decrease and new code is covered (check the PR coverage on codecov)
[ ] Controllers diagrams are updated when PR changes controllers code  (if applicable)

/ok-to-test

Codecov Report
Attention: Patch coverage is 54.90196% with 23 lines in your changes missing coverage. Please review.

Please upload report for BASE (main@618b3e3). Learn more about missing BASE report.

Files with missing lines
Patch %
Lines

status/reporter_github.go
50.00%
16 Missing and 3 partials :warning:

status/reporter_gitlab.go
33.33%
3 Missing and 1 partial :warning:

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #943   +/-   ##
=======================================
  Coverage        ?   66.10%
=======================================
  Files           ?       43
  Lines           ?     5871
  Branches        ?        0
=======================================
  Hits            ?     3881
  Misses          ?     1640
  Partials        ?      350

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

🚨 Try these New Features:

Flaky Tests Detection - Detect and resolve failed and flaky tests

/retest


Add topologySpreadConstraints to helm chart

📢 Update 2023-10-23 - @wallrj - Documentation
For anyone interested in this feature please read the High Availability section of the cert-manager Best Practice guide and provide any feed back and improvements via the cert-manager website repo. Thanks!

Pull Request Motivation
Fixes #5149
Kind
feature
Release Note
NONE

Thanks @stek29
/approve
/lgtm
/ok-to-test

📢 Update 2023-10-23 - @wallrj - Documentation
For anyone interested in this feature please read the High Availability section of the cert-manager Best Practice guide and provide any feed back and improvements via the cert-manager website repo. Thanks!


Error calling "DownloadAndParseAsync" function

I tried implementing this in a project I am working on but when calling DownloadAndParseAsync function in a asynchronous task it returned a HttpRequestException with status code 403 (forbidden). Initially I thought it was a problem with my code but after testing using both FModel and Solitude which worked before I think it is a issue with the parser or with my wifi? The error is not only happening for me but for others too

This should be fixed now, can you confirm?

Yes I can confirm it works now. Thank you for your efforts!


lwk: init at 0.2.0

Description of changes
New package definition for LWK CLI https://github.com/Blockstream/lwk
Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)

[ ] sandbox = relaxed
[ ] sandbox = true

[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
24.05 Release Notes (or backporting 23.05 and 23.11 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[x] Fits CONTRIBUTING.md.

Add a :+1: reaction to pull requests you find important.

@eclairevoyant thank you for your review, I have made those changes

hi @eclairevoyant just a gentle re-request for review please

Any chance you could take a look @eclairevoyant?

@RaghavSood @mmahut any chance you can assist with review please

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:
https://discourse.nixos.org/t/prs-ready-for-review/3032/3750

(Didn't test functionality)

what does it take to get this merged?

Result of nixpkgs-review pr 292522 run on aarch64-darwin 1

1 package marked as broken and skipped:

lwk

@RaghavSood any log output or message please


hii, I ran your code and it showed me the following error message

c:\Users\nethupama\Documents\Arduino\libraries\ESP32-ENC28J60\src\ESP32-ENC28J60.h:28:4: error: #error "This version of Arduino is too old"
   #error "This version of Arduino is too old"
    ^
In file included from c:\Users\nethupama\Documents\Arduino\libraries\ESP32-ENC28J60\src\ESP32-ENC28J60.cpp:25:0:
c:\Users\nethupama\Documents\Arduino\libraries\ESP32-ENC28J60\src\extmod/esp_eth_enc28j60.h:21:25: fatal error: esp_eth_phy.h: No such file or directory
compilation terminated.

exit status 1

Compilation error: exit status 1

I'm using the latest arduino ide which is 2.1.0.What is the reason for this?

#error "This version of Arduino is too old"

sorry about the misleading error message, it's actually the es32 arduino core version that's too old


Backlinks?

Thank you for this digital garden!
Two questions that I had:

Is there a way to have backlinks similar to obsidian?
If I did not want to use Netlify and wanted to use GitHub Pages, how does that change the instructions.

Thanks in advance.

I second this, I was actually looking at the code today to see how hard it would be to make this work. Making a map of all published notes and creating a section at the bottom of each published page with the referenced published notes may work.

Yes, been thinking about adding this for a while. It shouldn't be too hard as the obsidian plugin API makes it trivial to retrieve all backlinks for a note, so I could just add it to the frontmatter before pushing it to github, and using that when generating the HTML.

People seem to want different features from the plugin, so I'm currently in the process of adding a way to add global settings which acts as a default for all note, while still allowing you to overwrite specific notes it in the frontmatter.
I think enabling backlinks should be one of these settings, so I'll add it as soon as the global settings feature is in place.

The plugin only communicates with GitHub, and has no knowledge of netlify whatsoever. The netlify integration only works because netlify automatically listens to any changes in the repo. So if you wanted to use GitHub pages instead, you could skip using the "Deploy to netlify"-button and instead fork the repository. Then make whatever changes is neccessary to configure GitHub pages. I haven't used it myself so I don't have any knowledge of how to set it up, but I imagine it's possible to configure a build step? The config you would need to copy can be seen here: https://github.com/oleeskild/digitalgarden/blob/main/netlify.toml . So basically: Run npm install && npm run build, and point visitors to the generated dist folder.

The netlify config also automatically sends any URL that does not correspond to a note to the 404 page. I guess you could do something similar in GitHub pages. Let me know if you figure it out, or if you're stuck on anything :)

hi. just dropping a message to upvote this feature request (having backlinks). i think graph (the visual) is not as important, but "Notes Linked to This" list/table is the one most useful.
btw, i was exploring the many options available for obsidian publish alternatives for my digital garden. what i like about your setup is that it can render mathjax (including inline) - important feature for me as i do lots of statistics notes.

I've just released a new version that adds a local graph and backlinks. You'll need the latest version of both the plugin and template.
The template can be updated via Obsidian by going to "Settings > Digital Garden > Site Template > Manage site template > Create PR"
Any feedback on what works and what you'd like to be improved would be super helpful 😄


How to run these scripts?

Please follow the guide below

Issues submitted without this template format will be ignored.
You will be asked some questions and requested to provide some information, please read them carefully and answer completely.
Put an x into all the boxes [ ] relevant to your issue (like so [x]).
Use the Preview tab to see how your issue will actually look like.

Before submitting an issue, make sure you have:

[x] Updated to the latest version
[x] Read the README and docs
[x] Searched the bugtracker for similar issues including closed ones

Purpose of your issue?

[ ] Bug report (encountered problems/errors)
[ ] Feature request (request for a new functionality)
[x] Question
[ ] Other

The following sections requests more details for particular types of issues, you can remove any section (the contents between the triple ---) not applicable to your issue.

For a bug report, you must include the Python version used, code that will reproduce the error, and the error log/traceback.
Paste the output of python -V here:
Code:
# Example code that will produce the error reported
from instabot import Bot

bot = Bot()
followers = bot.get_user_followers(bot.user_id)

Error/Debug Log:
Traceback (most recent call last):
  File "<stdin>", line 1, in <module>
ZeroDivisionError: integer division or modulo by zero

Describe your issue
Explanation of your issue goes here. Please make sure the description is worded well enough to be understood with as much context and examples as possible.
I am new to this. I have cloned this repository. But how to run this bot? Where to enter instagram login credentials? Please tell me.

To run a script in windows -
Go to the folder that you have the python code
Hold shift and right click - Open command prompt
type python yourfilename.py
It'll run but make sure-
If python is installed correctly at the root
pass any parameters needed for scripts
eg: python yourfilename.py hashtag


Add GitHub actions template

Codecov Report

Merging #228 (f7ce433) into master (7276b69) will decrease coverage by 0.06%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master     #228      +/-   ##
==========================================
- Coverage   85.02%   84.96%   -0.07%
==========================================
  Files          24       24
  Lines        1503     1497       -6
  Branches      339      339
==========================================
- Hits         1278     1272       -6
  Misses        130      130
  Partials       95       95

Impacted Files
Coverage Δ

torch_optimizer/sgdp.py
76.71% <0.00%> (-0.92%)
:arrow_down:

torch_optimizer/adamp.py
89.87% <0.00%> (-0.38%)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7276b69...f7ce433. Read the comment docs.


chore: Convert Create Image and Image Analysis result to c-v and c-t.

Also Removed some unnecessary comments

Summary by CodeRabbit

New Features

Enhanced validation and transformation for image commands using decorators.
Asynchronous handling introduced for command creation and image analysis.

Bug Fixes

Improved test reliability by ensuring asynchronous operations are awaited.

Documentation

Removed JSDoc comments for methods in the ImageProcessorService class.

Chores

Updated import paths for better module organization in mocks.

Review this PR again


CosmosDB support

I searched the project for "cosmos" and see no mention of it. If this connector is supported, I'm wondering how the config arguments map to the REST API.

Yes, there is no mapping for cosmos fields yes. We will add it soon.

Support for CosmosDB connector will be included in v0.7.2
PR to track changes: https://github.com/fivetran/terraform-provider-fivetran/pull/159


Problems encountered using sen2nbar

I tried it with this instruction

I installed the corresponding package, but could not run the result

Hi @zhongguolishenglin!
This bug corresponds to the same one informed at #4. Please refer to that Issue for information on the fiz advancements.
Best,
David


Fixes #3938, HTML broken into code snippet

#3938,  HTML broken into code snippet

Everything from the end of Step 7 to the end is presented in a code snippet.
I assume line 523 from the present source HTML should be preceded by

and current line 531 should close the above
.

Although the reader describes the proper HTML syntax, the problem is with the Markdown. It seems to have been caused by inconsistent spacing between the end of the three backtick code snippet and the next line of text.
I separated the code snippet into two parts, added a label for the syntax highlighting ("powershell"), and indented the rest of the subsection, ## Create a deployment share
I also made the spacing more consistent throughout the article, for the linter's sake

@nenonix @JohanFreelancer9 - kindly do the copy editor review for this PR. Thanks.

@Dansimp - Can you please assist to check, approve and merge the content of this PR based on issue #3938?
Thank you.

@AndreaBarr -Would you be able to help merge this PR? Thanks.


ion-back-button does not work correctly together with angular router navigate option "replaceUrl" (V4)

Bug Report
Ionic Info
Run ionic info from a terminal/cmd prompt and paste the output below.
Ionic:

   ionic (Ionic CLI)          : 4.0.1
   Ionic Framework            : @ionic/angular 4.0.0-beta.2
   @angular-devkit/core       : 0.7.3
   @angular-devkit/schematics : 0.7.3
   @angular/cli               : 6.1.3
   @ionic/ng-toolkit          : 1.0.6
   @ionic/schematics-angular  : 1.0.4

Cordova:

   cordova (Cordova CLI) : 7.0.1
   Cordova Platforms     : none

System:

   Android SDK Tools : 26.0.2
   NodeJS            : v8.11.3 (C:\Program Files\nodejs\node.exe)
   npm               : 6.2.0
   OS                : Windows 7

Environment:

   ANDROID_HOME : D:\Android\sdk

Describe the Bug
ion-back-button does not work correctly together with angular router replaceUrl option
Steps to Reproduce
if i navigate from "/home" to "/login" and then navigate to "/pageC" by setting:
this.router.navigate(["/pageC"], {replaceUrl:true});
the browser back button correctly take me back to "/home" instead of "/login "
but ion-back-button still take me back to "/login"
Related Code
If you are able to illustrate the bug with an example, please provide a sample application via an online code collaborator such as StackBlitz, or GitHub.
Expected Behavior
ion-back-button should take me back to "/home" instead of "/login " while the angular router option replaceUrl is set to "true"
Additional Context
List any other information that is relevant to your issue. Stack traces, related issues, suggestions on how to fix, Stack Overflow links, forum links, screenshots, OS if applicable, etc.

I am also experiencing this same issue. In doing further investigation, I believe the issue is that when doing a router.navigate with replaceUrl: true, it is not updating the url / fullPath within the StackController of the ion router outlet.
In my scenario my page has child routing, and on enter it sets a default child route programatically. So for example navigating to /home will automatically do a relative navigation to /home/child using replaceUrl: true. Now from here if I navigate to /another-page the back button takes me to /home instead of /home/child which is very similar to the op's issue.
Is there any way I can force the stack in ion router outlet to update the url of the current view?

I have had some success by migrating to the Angular router (not too hard coming from the new NavController that lightly wraps the Angular router and looking at the NavController's methods in order to know what Angular router calls to replace them with). I've also created a custom Angular back button component that just uses Angular's Location.back() when you click it. That's how I'm getting around this issue for now.
Any updates on this issue? Thanks!

This is absolutely required to be fixed. Right now I have to add custom ion-button to handle all the back navigation as a temporary workaround.

+1

I believe you can replace state manually in the callback of exit event with location.replacestate , just check this stackoverflow https://stackoverflow.com/questions/38891002/angular-2-replace-history-instead-of-pushing
But anyway, the way I deal with this is just simply do not use backbutton , it is bugged

The way I've overcome this issue:

Created a custom directive:

import {Directive, HostListener} from '@angular/core';
import {Location} from '@angular/common';

@Directive({
  selector: '[app-location-back]'
})
export class LocationBackDirective {
  constructor(private location: Location) { }

  @HostListener('click', ['$event'])
  clickEvent(event) {
    event.preventDefault();
    event.stopPropagation();
    this.location.back();
  }
}

Used the directive's selector as a property on my ion-button:

<ion-header>
  <ion-toolbar>
    <ion-buttons slot="start">
      <ion-button app-location-back fill="clear">
         <ion-icon name="arrow-back" slot="icon-only"></ion-icon>
      </ion-button>
    </ion-buttons>
    <ion-title>...</ion-title>
  </ion-toolbar>
</ion-header>

The way I've overcome this issue:

Created a custom directive:

import {Directive, HostListener} from '@angular/core';
import {Location} from '@angular/common';

@Directive({
  selector: '[app-location-back]'
})
export class LocationBackDirective {
  constructor(private location: Location) { }

  @HostListener('click', ['$event'])
  clickEvent(event) {
    event.preventDefault();
    event.stopPropagation();
    this.location.back();
  }
}

Used the directive's selector as a property on my ion-button:

<ion-header>
  <ion-toolbar>
    <ion-buttons slot="start">
      <ion-button app-location-back fill="clear">
         <ion-icon name="arrow-back" slot="icon-only"></ion-icon>
      </ion-button>
    </ion-buttons>
    <ion-title>...</ion-title>
  </ion-toolbar>
</ion-header>

Nice ! I would add this.navCtlr.setDirection('back'); to the directive in order to properly animate it also :)

I suggest another alternative
Create a new class (CustomNavController) that extends from NavController
import { Optional } from '@angular/core';
import { UrlTree, Router } from '@angular/router';
import { Location } from '@angular/common';
import { NavController, Platform } from '@ionic/angular';
import { NavigationOptions } from '@ionic/angular/dist/providers/nav-controller';

export class CustomNavController extends NavController {
  constructor(
    platform: Platform,
    private _location: Location,
    @Optional() private _router?: Router,
  ) {
    super(platform, _location, _router);
  }

  navigateBack(url: string | UrlTree | any[], options: NavigationOptions = {}): Promise<boolean> {
    this.setDirection('back', options.animated, options.animationDirection);
    return new Promise((resolve, reject) => {
      this._location.back();
      resolve();
    });
  }
}

Add the CustomNavController class as your NavController to your providers (main module)
{ provide: NavController, useClass: CustomNavController }

Example:
@NgModule({
    ...
  providers: [
    ...
    { provide: NavController, useClass: CustomNavController }
    ...
  ],
  bootstrap: [AppComponent]
})
export class AppModule {}

Should we expect a permanent fix from Ionic team anytime soon?
@manucorporat @paulstelzer I think reliable and robust routing should have higher priority.

Hi there,
This issue has been resolved by #17879. I have pushed a nightly build of Ionic, and it would be great if someone could test and provide some feedback. (npm i @ionic/core@dev @ionic/angular@dev)
We appreciate your patience as we worked to fix this issue!

the issue not fixed yet

I've tried it out for myself and replaceUrl seems to be working! 🙂
At the same time, as I mentioned in my comment above, { skipLocationChange: true } similarly doesn't work with the ion-back-button.
I thought it was similar enough of an issue that fixing replaceUrl may have also fixed skipLocationChange but that didn't end up being the case. Therefore, perhaps it should be considered a separate issue.

@KevinKelchen did u try it on a real android device?

@KevinKelchen,
Ah yes thank you for the reminder! Would you be able to create an issue for it? I think it's worth tracking that separately.
Thanks!

I think the issue has been fixed now, I have tested it on device and it works without any issue.
But now I am having another issue. In my case when user is on Dashboard, pressing device back button should exit the app, but it doesn't, it stays on the dashboard page and does't nothing, even despite of pressing the hardware back button multiple times.

Hi @naveedahmed1,
This is a known issue. You can follow the Back Button Issue Thread for more info.
Thanks!


Update and rename triage-issues.yml to opdate workflos

[ ] Have you followed the guidelines in our Contributing document?
[ ] Have you checked to ensure there aren't other open Pull Requests for the same change?
[x] Have you added an explanation of what your changes do and why you'd like us to include them?
[x] Have you written new tests for your changes? Here's an example.
[ ] Have you successfully run brew style with your changes locally?
[ ] Have you successfully run brew typecheck with your changes locally?
[ ] Have you successfully run brew tests with your changes locally?

ok

@Pedro923


Add System Management Agent (SMA) endpoint examples to documentation.

- The goal of this PR is to add System Management Agent (SMA) endpoint examples to documentation.
- To get an appreciation for SMA API calls in action, it is instructive to look at what responses the SMA provides to the caller, for the respective calls.

This PR is per Issue-1183
Thus, we consider the following calls that the SMA handles:

Metrics of a service
Configuration of a service
Start a service
Stop a service
Restart a service
Health check on a service

Recheck

@mhall119 Great feedback and comments in making this a better doc 👍 I've addressed all three comments. Once you've had a chance to do a final review, please go ahead and merge this feature branch into master, or if you wish, we can tag @jpwhitemn at that time and request him to merge into master, thanks. Either way is fine by me 💯


Remove bors

We've been running that cronjob all this while.
Let's wait for the current salt changes (csstests) to simmer before landing this though
r? @larsbergstrom

r=me when you want to land this.


Fix: when using post message internal API, await user_new_message event

Simple fix, post-merge review welcome

What’s the rationale? This is a bit touchy this can run for a log time no? Cc @lasryaric

As discussed on slack, it is a follow up of #1366
it was too rash to return OK directly, because we might miss completely an error happening before user_new was pushed (i.e. nothing pushed on redis, so the conversation would not update nor report an error)

ack


Flow return url in register confirmation

Fixes https://github.com/aspnet/AspNetCore/issues/14998

RE templates validation, yeah I was wondering about that too, but maybe we should just have a few E2E tests in the templates directory, similar to your SPA template test?


Roadmap?

re: @deckarep

I would consider this tool very early stages alpha and barely usable at this point

Are there plans to continue development into a stable production ready release?
What would it take to mature this project?
Should there be a roadmap in the wiki or something?
It would help contributors with moving this project along

Hi @theRemix,
Thanks for the good questions here:
I do plan to continue development into something that is stable...in fact the tool is almost there...I've just recently started using it regularly.  The one thing I need to do is some more refactoring and actually start adding tests.  The reason I have not yet added ample testing is because the API is highly in-flux until I've nailed down something I'm ultimately happy with.
It's very close at this point from a usability perspective.
I can easily put together a roadmap/wiki to see if there is interest, having interest on this would be super cool but with limited time I don't yet have guarantees on how much I can commit to long-term.
I'll throw something together this weekend.
Cheers!
@deckarep

ping

@mrbluecoat and @theRemix - as of now, the project is on hiatus until enough interest is there. I still think this concept is a good idea but just don’t have the time these days to make it a priority.
There’s a lot I’d like to do with it but I’ll also consider outside contributions.

AltLayer Airdrop Season One Update

🚀 Exciting Announcement! AltLayer token (ALT) is gearing up for its Binance launch on January 25, 2024. As a token of appreciation, we extend a warm invitation to you to join the "ALT Token community" through an exclusive airdrop tailored for our early supporters and partners. Here's a quick overview:

Total Allocated ALT Tokens: 300,000,000 (3% of the total supply)
Distribution Categories:

Ethereum Mainnet
Binance Mainnet

For a comprehensive breakdown of criteria and further details, refer to the complete announcement Oficial Website.
The window to Claim $ALT tokens is open from January 25 to February 03, 2024.
Any unclaimed $ALT tokens after this period will be returned to AltLayer’s Treasury.
We deeply appreciate your contribution to AltLayer's success! Stay tuned for more exciting developments in Season One.
Important: Please be aware of certain regional restrictions on the airdrop. Review the disclaimer before participating.
coatezy, @skyinchina, @koidev1, @garzon, @easyplux, @researchoor, @mvaz, @kendricktan, @chentschel, @ilittlesun, @SuperSine, @ifrit98, @nicoleluo-alpha, @lifa123, @authenticarc, @Elainex7, @AKBANK28, @fracek, @evolvegame-sc, @newer027


add return value interfaces for MUI Base hook

This PR may fix this issue #35933
I tried to add return interface to all MUI Base Hooks (Those hooks are defined in this issue  #35933) without useAutocomplete Hook.

[ ] I have followed (at least) the PR section of the contributing guide.

after adding the new interface, you will need to run yarn docs:api so that the docs can be appropriately updated too.

Thanks for looking into this. I see there are lots of different checks failing. It would be much easier if you would split this PR in multiple ones that will handle one hook at a time. We will also need to add JS Docs on the different properties inside the new interfaces.

Should I send a specific PR for each interface or a specific commit?

Should I send a specific PR for each interface or a specific commit?

PR would be better, one at a time will help with faster review.

I make a PR for the UseInput hook return value. would you please review this PR . use inputReturn value PR


Add WSL category for report

I suggest to add "WSL" (Windows Subsystem for Linux) category also (or just a tag in Linux category for easy implementation). to detect whether a Linux distribution is in WSL, just check whether the output of uname -r command or platform.uname().release ends with -WSL2:
<IP_ADDRESS>-microsoft-standard-WSL2

But I'm not sure the ending for WSL1, maybe -Microsoft (found from this file). Linux running on bare metal or in WSL use different of cuda library, and are not same environemnt (container running in Linux use Linux edition cuda).

I confirmed, the ending of release string is -Microsoft for WSL 1.


[SPARK-34894][CORE] Use 'io.connectionTimeout' as a hint instead of 'spark.network.timeout' for lost connections

What changes were proposed in this pull request?

Currently, when a connection for TransportClient is marked as idled and closed, we suggest users adjust spark.network.timeout for all transport modules. As a lot of timeout configs will fallback to the spark.network.timeout, this could be a piece of overkill advice, we should give a more targeted one with spark.${moduleName}.io.connectionTimeout
Why are the changes needed?

better advise for overloaded network traffic cases
Does this PR introduce any user-facing change?

yes, when a connection is zombied and closed by spark internally, users can use a more targeted config to tune their jobs
How was this patch tested?

Just log and doc. Passing Jenkins and GA

cc @srowen @cloud-fan @maropu, Please have a look at this PR, thanks

Test build #136639 has started for PR 31990 at commit 5092ea8.

Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/136639/

Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/41221/

cc @Ngone51 FYI

Test build #136651 has started for PR 31990 at commit 26f07e9.

Test build #136651 has finished for PR 31990 at commit 26f07e9.

This patch fails PySpark unit tests.
This patch merges cleanly.
This patch adds no public classes.

Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/136651/

retest this please

Test build #136664 has started for PR 31990 at commit 26f07e9.

Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/41233/

Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/136664/

Kubernetes integration test unable to build dist.
exiting with code: 141
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/41233/

LGTM

Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/41248/

Kubernetes integration test status failure
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/41248/

Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/41248/

thank you all, merging to master


add base chain deployment

Add base chain seaport 1.5 deployment https://basescan.org/address/0x00000000000000ADc04C56Bf30aC9d3c0aAF14dC

Codecov Report
Patch coverage has no change and project coverage change: +26.29% :tada:

Comparison is base (3e9f3df) 73.70% compared to head (56a8c1c) 100.00%.

:exclamation: Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.
Additional details and impacted files
@@             Coverage Diff              @@
##             main     #1278       +/-   ##
============================================
+ Coverage   73.70%   100.00%   +26.29%
============================================
  Files          22        21        -1
  Lines        1270      1264        -6
  Branches      195       220       +25
============================================
+ Hits          936      1264      +328
+ Misses        258         0      -258
+ Partials       76         0       -76

Flag
Coverage Δ

foundry
?

production
?

reference
100.00% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.
see 18 files with indirect coverage changes

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


Delay initializing the router until it is installed or manually started

Description
Because global hooks need to be defined on the router AFTER it is created it is problematic that the initial route is set immediately on creation. This can cause race conditions and import issues with other modules.
By replacing the initialized property of the router with a start method and then automatically calling start when the router is installed we can make sure that the user is able to define global hooks and have them run on that initial route while avoiding module errors.
Closes https://github.com/kitbagjs/router/issues/269

Also, does this close https://github.com/kitbagjs/router/issues/269?

This is great and all, but don't we want to add an option to createRouter that prevents automatic calling of start? Seems like that defeats the purpose if dev wants to control when it starts?

My thought is once it's installed it can start, we could add an option to prevent auto starting. But the main issue was starting immediately before it was even being used.

This is great and all, but don't we want to add an option to createRouter that prevents automatic calling of start? Seems like that defeats the purpose if dev wants to control when it starts?

My thought is once it's installed it can start, we could add an option to prevent auto starting. But the main issue was starting immediately before it was even being used.

Oh that makes sense. I missed the part where the start() call was inside install. I thought it was just inside of createRouter


Flow + Close dataset + Open dataset = Crash

To reproduce:

Open DUKU's VDC.  Create, and enable a Flow renderer
Close DUKU
Import the WRF file /glade/p/cisl/vast/vapor/data/Source/WRF/idealized/kalundquist/wrfout_d01_2013-01-01_09_30_00

Vapor will crash.

I think John's recent changes might have fixed this


AS7 package got renamed in latest KC release

Done for AGPUSH-1294
KC renamed the packages in 1.1.x series

I tried it on EAP 6.3 ... it is ok

@sebastienblanc mind to test this on EAP as well ?

:+1: Landed d6f0762a96982d9380d3c1d4b43303dc13f739fe


Fix syntax error for node-postgres connection docs

Our current connection docs contain a "set literal," which is not
supported in JavaScript and causes a syntax error. A solution is
to pass the connection string directly into the client without
wrapping it in a JavaScript object.

This change is


Question: Is there an alternative to this project....

...that doesn't contain bad language?

@mcarton Unfortunately, I don't feel that an alias is enough.


A person has an "Email Not Delivered" status but receives the email after several "resend emails"

I started a party and saw that some email addresses had an "Email not delivered" status. I contacted these people and they received the party invite email a few minutes later. I did press "resend email" three times in total for one person and they received one email in their inbox and 2 in spam. After a refresh and they opened the email, the status changed to an "opened email".
To reproduce:

Start a party and there might be emails that have an "Email Not Delivered" status

there can be a delay on the mails, some providers don't like the fact that we send out a lot of emails (we just have a lot of users) and will flag us as spam. There is a tracking pixel in the mail so we can inform the party admin that an mails was opened, but offcourse this is best effort.
Can you send me info about your party? I will have a closer look. Use https://www.secretsantaorganizer.com/contact and mention Tom Van Looy in your email.


on upload, we should also create a date folder and store the upload and metadata flatfile together

example:
/tmp/upload/alice/20150103-090521EST
/tmp/upload/bob/20141231-235956EST
/tmp/upload/carl/20141231-235956EST

rename the file into the above date folder:
upload_(original name, but only allow A-Za-z).extension
metadata flatfile:
metadata_(hash)
metadata contents:
util.inspect({fields: fields, files: files})


blur @Output()

Thanks for great package :)
I need an option to catch blur from ace editor in order to display some error
is it possible to add blur @Output() ?

You can add a handler function for the blur event directly:
 this.$editor.getEditor().on('blur', () => console.log('blur')


Update the game over message.


Allow webpack configurations written in any language

💡 Feature request

Overview and problem statement
I like to write my webpack configurations using TypeScript, but wrangler expects JavaScript files, so it throws errors, e.g.:
(node:2110764) UnhandledPromiseRejectionWarning: /home/user/wrangler_webpack_ts/webpack.config.ts:1
import * as path from 'path';
^^^^^^

SyntaxError: Cannot use import statement outside a module
...

I should be able to use webpack configuration files written in any language supported by webpack.
Basic example
I should be able to have webpack_config = "webpack.config.ts" in my wrangler.toml and, provided I have ts-node installed (or whatever is listed in this, which is what webpack uses for this functionality), it should just work.
Remarks
This really isn't a huge issue because, for instance, if you still have ts-node installed, you can just have your webpack.config.js file look like this:
require('ts-node/register');
module.exports = require('./webpack.config.ts').default;

Just thought I might as well ask. Feel free to close/merge into similar webpack issues - I saw a few but they seem to be larger in scope and I don't know if this request would get implemented by those.
Thanks in advance!

It's not possible right now but once https://github.com/cloudflare/wrangler/pull/1677 lands it should fix that

Closing in favor of #1677 .


Adds rate limiting to egress upload loop.

(You already review this for 1.3)

We have the DefaultMaxConcurrentStreams value defined in /src/client/client.go to be 100. It's a bit odd that this is different. We have been seeing some throttling issues from AWS as well. Maybe we'll need to start setting limits per cloud provider. Just thinking aloud. Nothing to change here really.
LGTM


Write typescript as modules, but output js without modules

Search Terms
Searched the whole internet for anything like it, only webpack and browserify related 'solutions' are proposed.
Suggestion
Split module options in tsconfig so typescript modules could be set separately from output target modules.
Use Cases
Our usecase:

We have a huge codebase, and we want to slowly move to typescript.
We have a sophisticated build system that we don't want to change - we want typescript to transpile to js and to take js and continue to use it as we were.
We don't need nor want to use modules in js. We never used modules - we have our system of imports, minification,
versioning, caching, etc.
The only reason why we need to use modules in typescript is tsc incremental watch build. With no modules, it builds complete codebase on each change. We want to build only file changed and dependent files.

So currently we have two bad options - don't use modules (unacceptably slow build time) or use modules (get the output that we don't want). Currently we 'mitigate' the issue by removing parts of js tsc has output (removing stuff we recognize as related to exports and require), but that's just terrible.
Even worse, even if we were to use modules, require / exports are inlined even in output we want to inline to index.html as critical JS...
Examples
I guess I explained it all above.
Checklist
My suggestion meets these guidelines:

[ * ] This wouldn't be a breaking change in existing TypeScript/JavaScript code
[ * ] This wouldn't change the runtime behavior of existing JavaScript code
[ * ] This could be implemented without emitting different JS based on the types of the expressions
[ * ] This isn't a runtime feature (e.g. library functionality, non-ECMAScript syntax with JavaScript output, etc.)
[ * ] This feature would agree with the rest of TypeScript's Design Goals.

typescript has outFile option, but it requires UMD/SYSTEM module resolution. nobody uses it, webpack used in most cases

TypeScript also supports incremental compilation of composite projects.  For example, the compiler itself is broken into composite projects, but does not use modules.  Maybe that would help?

typescript has outFile option, but it requires UMD/SYSTEM module resolution. nobody uses it, webpack used in most cases

We want to have js built for each ts, next to the ts, and that ts used modules while js does not.

TypeScript also supports incremental compilation of composite projects. For example, the compiler itself is broken into composite projects, but does not use modules. Maybe that would help?

Well, not sure... Each project needs to have its own config file and we need to link all the projects? Then when one project was built whole dependent project is built, even though some are not changed? Then we need to think about projects and which groups to create as projects...
It seems that it complicates our usage significantly. Our use case is fairly simple - when one ts file is changed we want to build only that file and dependent ones, creating our own dependencies through projects instead of modules adds unneeded complexity...
To be a bit more precise - this is what we do:

tsc incremental watch all the files in our huge codebase
Write ts with modules and write export {...} at the end explicitly (explained later).
Set up tsc so it creates js next to the ts files
When js is output and about to be used by the rest of the build system we remove all the exports and requires from the file content. This is very error prone process, we're not really parsing js syntax but pattern matching strings. That's the reason why we write exports at the end of the file as mentioned - it generated js that is easier to clean... Also, this messes up sourcemaps a bit.

I guess we're not the only ones with this problem... tsc incremental watch works well for modules (and it is clear why, it has dependency data), ts code is clear with modules (you know where from are the references used), and all that is good related to ts. But there's no reason to imply that someone that write modules in ts wants them in js as well, since the aforementioned goodies are not related to the transpiled js.

This is likely not happening because this actually isn't all that common of a situation, and the solution here is already implemented in things like rollup, whose configuration docs show just how complicated this process is. It's not something we'd want to re-implement unless it was absolutely critical for a large number of people.

This is my use-case, I have an OpenApi specification that we generate Typescript client code from. I would like to build this Typescript code into a single javascript file that is not a module and that can be imported into a Polymer 2 project using a simple script tag.

I would also accept this as an alternative to my existing issue: https://github.com/microsoft/TypeScript/issues/33206
The TSC compiler is just so close to being a great standalone compiler for outputting compact javascript for the web. There's just this frustrating requirement that you either use webpack/rollup or triple-slash-references.

Currently working on an Electron app and I’ve always used TypeScript’s namespace functionality together with --outFile, and it’s always worked great.
It would be amazing if I could keep this workflow but also import modules from Node.js standard library with require. const fs = require("fs"); works but seems to be of type any which is unfortunate.

Just trying to keep this alive in 2023. The use case is there. In my case, I'm working in a more niche JS runtime (ServiceNow/Rhino) which doesn't use explicit exports, and so adding this in would definitely serve my use case.


Charges in Navigation Drawer opens Home

Summary:
Clicking on the Charges in the navigation drawer opens Home Fragment.
Steps to reproduce:
How can we reproduce the issue?
Click on the Charges in the navigation drawer
Expected Behaviour
It should have opened the Charges Fragment
Observed Behaviour
Nothing happens on clicking
Device and Android version:
Redmi 7A Android-9
Screenshots:

I'll be working on it. @therajanmaurya


On managing the stability guarantee in 2.0 and later

I would like to discuss how we enforce the stability guarantee in 2.0 and later.
rustfmt must guarantee that the default formatting will not change between versions as long as their major versions remain the same.
During 1.x, we managed it by adding version-gates to code and checking the version at runtime. Unfortunately, this method was prone to bugs and code complexity. In 2.0 and later, we would like to use a different approach to guarantee stability.
Initially, I was thinking of using different versions of rustfmt-lib, depending on which version a user has specified. Unfortunately, it turns out that this method requires some serous rearchitecting of the code. Since we would like to release 2.0 as soon as possible, I am looking for another approach.
One way is to separate the development branch from the release branch. Currently, the development and release of rustfmt are done almost entirely on the master branch. I want to change this to the following way:

We will keep using the master branch as a development branch. Every PR will be based on and merged to the master branch.
We will create a new branch for release (I will call it release). PRs merged into the master branch that does not change the default formatting will be merged into the release branch; publishment to crates.io and submodule registration to the rust repository will be made only from the release branch.

This way, we can guarantee stability without adding extra code to our development codebase. The downside is that users will lose access to the latest format style unless they build rustfmt from the source. I am expecting that the branch management won't be that bad, though we may need to introduce bot for auto-merging PRs.

The downside is that users will lose access to the latest format style unless they build rustfmt from the source.

Agreed, and that could indeed be problematic for some folks. IMO there's also a benefit for rustfmt with the current feature-gate approach because it allows users to test the new gated style/features and provide feedback. I wonder if in this new model we could publish the "bleeding edge" version of rustfmt (master) as a separate crate and/or as pre-built binaries (perhaps as part of a GitHub pre-Release) to let those users get access to the latest without having to build from source?

I am expecting that the branch management won't be that bad, though we may need to introduce bot for auto-merging PRs

This one I fear could get complicated, at least conceptually, especially if there's a long cycle between major releases. Seems like we could end up needing to keep a mental map of the breaking changes that have been merged to master to be able to address required changes/bug fixes on the released version of rustfmt.
For example: if there's a breaking change that's merged to master, and subsequently a bug is discovered in the current/stable/released version where the bug fix deals with the same source code as that already-merged-to-master breaking change.
IIUC a user that wanted to fix that bug would need to do so directly against the release branch, and against master (very similar to what we are doing today for rustfmt 1.x and 2.x) as well, since we couldn't do the typical merge to master and then releases workflow without potentially introducing the breaking change?
That would probably be manageable as long as the number of breaking changes on master is relatively small, and we don't have breaking/unreleased changes on master for an extended period of time. However, I feel that could be tricky and increase the potential for unintentional breaking changes being released if we do end up going a long time with unreleased breaking changes.

Thank you for your feedback!
Publishing a bleeding-edge sounds good to me. We can think of many possible installation methods. Currently, for historical reasons, there are two versions of rustfmt on crates.io; rustfmt and rustfmt-nightly. The former is deprecated, and the latter is stable (same as the one you can get via rustup). We can reorganize them so that rustfmt will be the stable version, and rustfmt-nightly will be the bleeding-edge version. To summarize,

The stable version can be installed via

rustup
cargo install rustfmt

The bleeding-edge version can be installed via

cargo install rustfmt-nightly
From the GitHub release page

The divergence between the master and release branches is a concern for me as well. I was wondering whether breaking the development phase could mitigate it. For example, if we define the development period for 2.0 as six months, then in the first four months, we only accept PRs that won't affect the default formatting (e.g., critical bug fixes, updating syntax and issues related to configuration). After that, we will be open to PRs that will change the default formatting.

The stable version can be installed via
    rustup
    cargo install rustfmt
The bleeding-edge version can be installed via
    cargo install rustfmt-nightly
    From the GitHub release page

SGTM!

For example, if we define the development period for 2.0 as six months, then in the first four months, we only accept PRs that won't affect the default formatting (e.g., critical bug fixes, updating syntax and issues related to configuration). After that, we will be open to PRs that will change the default formatting

That sounds reasonable, and the shorter cycle should definitely help keep things manageable. I suppose we could also consider having something of a vNext branch that folks who really wanted to work on a breaking changing during that first ~4 months could base their changes on too if we find there's a lot of breaking changes being proposed/submitted.

The idea of preparing a branch for breaking changes seems reasonable to me. My first thought was to simply reject PRs during the first period, though that leaves a bad feeling to contributors who are unfamiliar with the rule. I would like to avoid it if possible.

As discussed over in #4154, another thing we'll probably need to address is how to provide documentation on available configuration options with this new model.
I've seen a few questions now in Discord and in GH related to Configuration options as described in-repo vs. what's actually available for folks using a released rustfmt version.
I.e. what configuration options are available on

bleeding edge rustfmt/rustfmt in source
rustfmt on stable channel
rustfmt on nightly channel

The following is a summary of how we manage rustfmt development after 2.0:

Make the master branch a release only  branch
Create a new develop branch; most of the rustfmt development will happen in this branch
Divide the 2.x development period into two parts; the non-breaking change period and the breaking-change period. During the former period, the develop branch will only accept Prs that do not change the default formatting style.
Create a new 3.0-rc branch; this branch will keep breaking changes from PRs sent during the non-breaking-change period. We limit the PRs merged to this branch to those with small diff. Anything involving extensive refactoring, for example, is only accepted during the breaking-change period to ease the sync cost between this and the develop branch. We merge this branch into the develop branch at the beginning of the breaking-change period.

Ah, this does not quite work...I'll have to think again.

As for the documentation, I think it would be good to enrich the GitHub Page and make it so that you can specify which version to display like the CMake documentation page.

Something else we should consider is adding some additional target repositories to use for our integration tests (perhaps even rustc and/or tokio) to get us some extra coverage and validation.
Related aside, we're currently re-building rustfmt in each integration test job, so it may also be worth seeing if we can build the binary once and then just using that rustfmt binary in each job run (seems it could help speed them up)

Currently, cargo publish to crates.io is blocked by https://github.com/rust-lang/cargo/issues/8280. We may need to find a workaround for this.

@calebcartwright I have rethought how we manage versioning and branches on rustfmt 2.0 and later. Let me hear your thought.
To conclude, I'd like to create a branch for 2.y.z releases (let's say release/2. The master branch will still be the development branch.
First of all, I've ditched the idea of the complicated branch management that I mentioned before. We don't have enough time or human resources to do anything complicated unless it's necessary. I also want to make it easier to move on to other management methods is the new management method doesn't work.
The master branch will be a development branch as before. What' s different is that we no longer release 2.y.z versions from the master branch but the relaese/2.
The release/2 branch is for 2.y.z versions release. We cherry-pick commits from the master branch to the release/2 branch. We restrict the commits to cherry-pick to bug fixes and syntax updates. Commits that introduce new features can be cherry-picked as well, but this is not a must-do.
As the difference between the master branch and the release/2 branch becomes more significant, it is more likely that we observe merge conflicts and auto-merging is not possible. In that case, depending on the severity of the fix, we'll either resolve the conflict manually or pass on the fix until 3.0.
I've come to this conclusion because I want to keep the development easy and straightforward.
The downside is that delivering new features may be delayed once the difference between the master and release/2 is significant enough that auto merging the cherry-pick becomes impossible. I am willing to take this risk to make our life easier

To conclude, I'd like to create a branch for 2.y.z releases (let's say release/2. The master branch will still be the development branch.
First of all, I've ditched the idea of the complicated branch management that I mentioned before. We don't have enough time or human resources to do anything complicated unless it's necessary. I also want to make it easier to move on to other management methods is the new management method doesn't work.

Makes sense and SGTM. I generally prefer to use feature flags over separate branches, but understand the desire to move away from version and try something different. Sounds like a key to this (or any other strategy) will be to minimize the length of time we accrue unreleased breaking changes.
Do you feel like we've settled on the repository/module layout for 2.0 and going forward? It seems like we are, but obviously additional restructuring would complicate cherry picking commits.

I think we have, and hence I am going to close this issue. I will add documentation about branch and version management in Wiki when I have time.


Autorest Regen Preview to 3.0.0-alpha.20230612.1 by Michael Nash from refs/pull/3434/head

Triggered from https://github.com/Azure/autorest.csharp/pull/3434

API change check
API changes are not detected in this pull request.