README.md file exists, but is not specified in readme Cargo.toml field

The cargo reference states:

If no value is specified for this field, and a file named README.md, README.txt or README exists in the package root, then the name of that file will be used.

cargo-deb should not produce a warning for this and follow cargos behaviour of assuming one of these files. (Especially as the warning knows that the file exists)

From the looks of it it is specified
I run the packaging stage just now and I don't see any errors, If Im correct we should close this issue @EdJoPaTo
$ cargo publish --dry-run
    Updating crates.io index
   Packaging cargo-deb v1.38.1 (/Users/john/Documents/Programming/cargo-deb)
   Verifying cargo-deb v1.38.1 (/Users/john/Documents/Programming/cargo-deb)
  Downloaded xz2 v0.1.7
  Downloaded crc v2.1.0
  Downloaded ar v0.9.0
  Downloaded zopfli v0.6.0
  Downloaded cargo_toml v0.11.5
  Downloaded typed-arena v2.0.1
  Downloaded md5 v0.7.0
  Downloaded crc-catalog v1.1.1
  Downloaded quick-error v2.0.1
  Downloaded iter-read v0.3.1
  Downloaded lzma-sys v0.1.19
  Downloaded 11 crates (905.3 KB) in 0.68s
   Compiling libc v0.2.126
   Compiling cfg-if v1.0.0
   Compiling autocfg v1.1.0
   Compiling proc-macro2 v1.0.39
   Compiling unicode-ident v1.0.0
   Compiling syn v1.0.96
   Compiling crossbeam-utils v0.8.8
   Compiling serde_derive v1.0.137
   Compiling lazy_static v1.4.0
   Compiling serde v1.0.137
   Compiling memchr v2.5.0
   Compiling scopeguard v1.1.0
   Compiling cc v1.0.73
   Compiling rayon-core v1.9.3
   Compiling pkg-config v0.3.25
   Compiling log v0.4.17
   Compiling either v1.6.1
   Compiling serde_json v1.0.81
   Compiling regex-syntax v0.6.26
   Compiling crc-catalog v1.1.1
   Compiling termcolor v1.1.3
   Compiling ryu v1.0.10
   Compiling unicode-width v0.1.9
   Compiling typed-arena v2.0.1
   Compiling remove_dir_all v0.5.3
   Compiling fastrand v1.7.0
   Compiling humantime v2.1.0
   Compiling cargo-deb v1.38.1 (/Users/john/Documents/Programming/cargo-deb/target/package/cargo-deb-1.38.1)
   Compiling itoa v1.0.2
   Compiling iter-read v0.3.1
   Compiling byteorder v1.4.3
   Compiling adler32 v1.2.0
   Compiling glob v0.3.0
   Compiling ar v0.9.0
   Compiling quick-error v2.0.1
   Compiling md5 v0.7.0
   Compiling memoffset v0.6.5
   Compiling crossbeam-epoch v0.9.8
   Compiling rayon v1.5.3
   Compiling crc v2.1.0
   Compiling itertools v0.10.3
   Compiling getopts v0.2.21
   Compiling lzma-sys v0.1.19
   Compiling zopfli v0.6.0
   Compiling crossbeam-channel v0.5.4
   Compiling num_cpus v1.13.1
   Compiling atty v0.2.14
   Compiling filetime v0.2.16
   Compiling xattr v0.2.3
   Compiling tempfile v3.3.0
   Compiling quote v1.0.18
   Compiling aho-corasick v0.7.18
   Compiling tar v0.4.38
   Compiling regex v1.5.6
   Compiling xz2 v0.1.7
   Compiling crossbeam-deque v0.8.1
   Compiling env_logger v0.9.0
   Compiling toml v0.5.9
   Compiling cargo_toml v0.11.5
    Finished dev [unoptimized + debuginfo] target(s) in 13.04s
   Uploading cargo-deb v1.38.1 (/Users/john/Documents/Programming/cargo-deb)
warning: aborting upload due to dry run

Ah, it seems like a misunderstanding.
I use cargo deb in projects of mine which do not explicitly state readme in their Cargo.toml. cargo deb then creates a warning about that which I think is weird.
For example this Github Actions run also logs the warning: https://github.com/EdJoPaTo/mqttui/runs/6709975364?check_suite_focus=true#step:11:9

Ah, it seems like a misunderstanding.
I use cargo deb in projects of mine which do not explicitly state readme in their Cargo.toml. cargo deb then creates a warning about that which I think is weird.
For example this Github Actions run also logs the warning: https://github.com/EdJoPaTo/mqttui/runs/6709975364?check_suite_focus=true#step:11:9

From what I can see you do not have your readme explicitly stated in your Cargo.toml. And cargo-deb is right to warn your about that as that's what cargo itself does when you publish something, you can check it by running:
cargo publish --dry-run

On your repo, this should also warn you and in this case cargo Deb just passes the warning forward

Interesting. I havn't thought about checking commands like cargo publish about similar behaviour. I only checked the clippy lints for cargo (cargo clippy -- -W clippy::cargo) which also do not care about the missing readme entry, only for missing keywords / categories.
I just tested them, but neither cargo publish --dry-run or cargo package do seem to print a warning there while cargo deb does.

Interesting. I havn't thought about checking commands like cargo publish about similar behaviour. I only checked the clippy lints for cargo (cargo clippy -- -W clippy::cargo) which also do not care about the missing readme entry, only for missing keywords / categories.
I just tested them, but neither cargo publish --dry-run or cargo package do seem to print a warning there while cargo deb does.
@EdJoPaTo

Hmm weird, it should. It does in my projects, that's why I know about it because I encountered this warning recently. But anyway if your add:
readme = "README.md"

in your [package] sections it should be good, as you can see here after I added it locally the warning is gone:

Personally I like using sane defaults which don't require to specify everything explicitly. The Cargo manifest states that default which is totally fine to me.
So yeah, I could state that explicitly to get rid of the warning but that should result in the exact same behaviour while having a more bloated config. I think its better to not have that warning in the first place as its the default already. That would make a simple tool a bit better to use.

From your screenshot / Home directory path in your first answer I assume you are using macOS. I just ran cargo package and cargo publish --dry-run on my MacBook which also does not warn about it. (My main system is a Linux based system). It would be interesting in which cases that warning is shown then also to find the reasoning behind it. I also checked nightly and 1.57 without luck. Not sure where it might originate then.

Hmm wait im actualy wrong here i just tested it on that package of mine I mentioned and it does print this error:

But that's was when I didn't have the repository key in my package configuration. Having the readme doesn't seem to change a thing. But now its a matter of, hey maybe its the debian package that requires having a readme as a firm of basic documentation? If so then shouldn't the build actually even fail if the readme is not specified directly?

@EdJoPaTo whats the jq command btw?

NIce, thanks :)

@EdJoPaTo btw about your project. I am a control engineering and robotics student and had my fair share of industrial IoT and your project looks really cool. What use cases does it have? Im a little shaky on IoT protocols

mqttui is for viewing MQTT messages on a broker. For example when testing around with stuff to see whats actually happening.
But these messages should be marked off-topic in this issue as they are not about the readme option :innocent:

cargo deb currently does not produce any warnings when the readme is not specified and it reads README.md into the extended-description. I think this issue can be closed.


[FFI] Add with_matching_rules

Summary
Add a new FFI function to add matching rules.
This will help implement the compatibility suite in FFI-backed libraries, especially these tests which require the addition of matching rules to a subset of the request.

Resolved by #383


Not Working at all for Net6.0 Project

Absolutely no code is generated.
Followed the instructions.
I have an EditViewModel:
public partial class EditViewModel
{
    [Reactive]
    public string Email { get; set; } = string.Empty;

    [Reactive]
    public string? Comment { get; set; }

    [Reactive]
    public bool IsApproved { get; set; }

    [Reactive]
    public bool IsLockedOut { get; set; }

    [ObservableAsProperty]
    public Roles Roles { get; }

    [Reactive]
    public IReadOnlyList<Roles> SelectedRoles { get; set; }
        = Array.Empty<Roles>();

    public ICommand Submit { get; }

    public ICommand Unlock { get; }

    public Interaction<Unit, bool> Validating { get; }
        = new();
}

and a EditModelAnnotator:
public class EditViewModelAnnotator : Annotator<EditViewModel>
{
    public EditViewModelAnnotator()
    {
        DefineFor(x => x.Email).Display().Name("Email");

        DefineFor(x => x.SelectedRoles).Display().Name("Roles");
    }
}

and my CSProj file:

Hey @TorreyGarland,
Yes, that's true, there are some changes in .NET6. I'll cross-check soon and publish a fix. But, still would be a beta version. This is the issue #1 that holds me back from publishing a release.


Example usm_ndarray.py fails

$ python numba_dppy/examples/usm_ndarray.py
N 10
Scheduling on ...
    Name            Intel(R) UHD Graphics [0x9bca]
    Driver version  1.1.19883
    Vendor          Intel(R) Corporation
    Profile         FULL_PROFILE
    Filter string   level_zero:gpu:0
A :  <dpctl.tensor._usmarray.usm_ndarray object at 0x7f7eac05f400>
B :  <dpctl.tensor._usmarray.usm_ndarray object at 0x7f7eac05f3a0>
Traceback (most recent call last):
  File "numba_dppy/examples/usm_ndarray.py", line 72, in <module>
    main()
  File "numba_dppy/examples/usm_ndarray.py", line 64, in main
    driver(da, db, dc, global_size)
  File "numba_dppy/examples/usm_ndarray.py", line 36, in driver
    data_parallel_sum[global_size, dppy.DEFAULT_LOCAL_SIZE](a, b, c)
  File "/localdisk/work/spokhode/numba-dppy/numba_dppy/compiler.py", line 593, in __call__
    cfg(*args)
  File "/localdisk/work/spokhode/numba-dppy/numba_dppy/compiler.py", line 411, in __call__
    self._unpack_argument(
  File "/localdisk/work/spokhode/numba-dppy/numba_dppy/compiler.py", line 495, in _unpack_argument
    raise NotImplementedError(ty, USMNdArrayType)
NotImplementedError: (USM:ndarray(float32, 1d, C), <class 'numba_dppy.driver.usm_ndarray_type.USMNdArrayType'>)

@diptorupd
Do you have an idea?

@PokhodenkoSA This is the expected behavior. We have added the hooks to be able to handle usm_ndarray. The implementation is still missing. This example points out that we currently do not support usm_ndarray from the user perspective but is a feature that is coming.


Missing Roanoke County, Virginia; exisiting shapefile is for independent city

Feature or enhancement
https://sfg.taxonworks.org/geographic_areas/29144 is for the city of Roanoke, not the county:
County shapefile from google:

Shapefile from TW:

Similar to other Geospatial issues like #3217 and #3934
Location
Geographic Areas
Screenshot, napkin sketch of interface, or conceptual description
Need both shapefiles
Your role
Collections manager

... or maybe related? https://github.com/SpeciesFileGroup/taxonworks/issues/3642

Note that just like #3217 if you enter coordinates for an area in the county (not city) it still suggests the city even though it will then error and say the coordinates are not in the shapefile.

Related. Not duplicate. Different city/county mismatch.

I noted several similar issues in the description.
I think in the original geo areas import independent cities that have "donut counties" around them with duplicate names were not both imported. One or the other was but not both.

E.g. Saint Louis the "donut" was imported but not the city, and in this case the city was imported but not the donut.


Only notify teams in prod-* clusters, no actual destruction

[ ] Add prod configuration
[ ] Configure GitHub Actions

Closed since this is a no-op


PR Request: Add support for Digest authentication

PR request from Alan:

Digest authentication needs support as well.

PR review can be found here.

Added digest authentication, unsure of what messagedigest algorithm to use (MD5, SHA-1, SHA-256) to use.

Almost done, just need to add a way to select basic or digest authentication.

An implementation has been made, but tests need to be made for digest.


Cloning operation does not succeed

I am trying to clone the TFS repo into my local GIT repo but for some reasons, it does not succeed and there is a discrepancy in the cloned code.
Executed the following steps until now :

List the number of branches present :
git tfs list-remote-branches
Clone the dev branch to local GIT repository :
git tfs clone  <$Project name/branch>
But since our repo is quite huge, my assumption is that it leads to server connection problems after some time (Please note that this is only an assumption from my end, real issue could be something else).
A message “The remote name could not be resolved: ” is displayed on cmd and the cloning process stops.
Nevertheless, when I check the local GIT repo to verify if the code has been cloned, I observed that there is a lot of discrepancy in the original TFS code and the cloned code.

Request you to please let me know if anything can be done to clone the code successfully.

I'm getting the same error when I attempt to run git tfs rcheckin. One changeset that I'm checking in contains 90,000 deletions and I'm also assuming that some sort of session is timing out since other server interactions are working fine.

We are trying to clean up old/stale issues. As this hasn't seen any updates (or pull requests implementing it), can this issue be closed?


Serializing a tensor and writing to tf.train.Example from within a graph

I would like to write tensorflow example records to a TFRecordWriter from inside an AutoGraph generated graph. I am running inference at scale over millions of examples and so don't want to collect all results in memory, but write them out as I go. I'm reading from a dataset.
Running everything inside a graph is way faster than breaking out every batch to process and save results.  So I just want to be able to write results from within the graph.
The documentation for tensorflow 2.0 states the following:

The simplest way to handle non-scalar features is to use tf.serialize_tensor to convert tensors to binary-strings. Strings are scalars in tensorflow.

However, tf.io.serialize_tensor returns a tensor of byte-string. Creating an Example proto requires a bytes list, not a tensor.
How do I write a tf.train.Example to a tf record from inside a graph?
Code to reproduce:
%tensorflow_version 2.x
import tensorflow as tf

@tf.function
def example_write():
  writer = tf.io.TFRecordWriter("test.tfr")
  x = tf.constant([[0, 1], [2, 3]])
  x = tf.io.serialize_tensor(x)
  feature = {
      "data": tf.train.Features(
        bytes_list=tf.train.BytesList(value=[x]))
  }
  ex = tf.train.Example(features=tf.train.Features(
      feature=feature))
  writer.write(ex.SerializeToString())

example_write()

and the error
---------------------------------------------------------------------------
TypeError                                 Traceback (most recent call last)
<ipython-input-6-df8a97eb17c9> in <module>()
     12   writer.write(ex.SerializeToString())
     13
---> 14 example_write()

8 frames
/usr/local/lib/python3.6/dist-packages/tensorflow/python/framework/func_graph.py in wrapper(*args, **kwargs)
    966           except Exception as e:  # pylint:disable=broad-except
    967             if hasattr(e, "ag_error_metadata"):
--> 968               raise e.ag_error_metadata.to_exception(e)
    969             else:
    970               raise

TypeError: in user code:

    <ipython-input-6-df8a97eb17c9>:6 example_write  *
        feature = {

    TypeError: <tf.Tensor 'SerializeTensor:0' shape=() dtype=string> has type Tensor, but expected one of: bytes

@apcode
This question is better asked on StackOverflow since it is not a bug or feature request. There is also a larger community that reads questions there.

I have asked on SO, with no response.
Having looked into it, I might do two things:

file a bug on the documentation which clearly states you can use tf.io.serialize_tensor to convert a tensor to a byte stream. Which it does not. It converts it to a tensor of type tf.string. So it cannot be used as the documentation suggests.

File a feature request to be able to write tf records of tf examples from within a graph. None of the TFRecordWriter classes take a tensor!!

I just modified your code a bit and end up with this:
`def _bytes_feature(value):
"""Returns a bytes_list from a string / byte."""
return tf.train.Feature(bytes_list=tf.train.BytesList(value=[value]))
@tf.function
def example_write():
writer = tf.io.TFRecordWriter("test.tfr")

g = tf.Graph()

with g.as_default():
    x = tf.constant([[0, 1], [2, 3]], dtype=tf.float32)
    x = tf.io.serialize_tensor(x)

with tf.compat.v1.Session(graph=g).as_default() as sess:
    x_feat = x.eval()

print(x_feat)
feature = {
      "data": _bytes_feature(x_feat)
    }

ex = tf.train.Example(features=tf.train.Features(
    feature=feature))

writer.write(ex.SerializeToString())

example_write()`
The key of this code is eval your "x" to end up with byte data, which could be consumed by tf.train.BytesList
My English is not good, so if you need more clarify, just comment below

I think when you call eval() you take this out of the graph so when you write it out you're not doing so inside the computation graph. IIUC.

Right. As the tf.train.BytesList only receive byte data, we must call eval() to take value from tensor. This small graph is just made for serialize tensor, so we don't need to put it inside computation graph.

This would also be very helpful for me, preferably without requiring tf.py_function

If you are serializing many tensors in a loop, say if you were creating Example objects, it would be more efficient to use the .numpy() method of the tensor, rather than creating an execution graph each time. So:
x = tf.constant([[[0, 1], [2, 3]],[[1, 1], [2, 2]]], dtype=tf.float32)
xs = tf.io.serialize_tensor(x.numpy()

@apcode ,
Can you please try the code as commented in latest stable v2.7 and let us know if the issue still persists.

@tilakrayal your "commented" link links to this thread, not the tensorflow documentation. I presume you mean the serialize_tensor page:  https://www.tensorflow.org/api_docs/python/tf/io/serialize_tensor

Looking at this comment in https://www.tensorflow.org/api_docs/python/tf/io/serialize_tensor
feature_of_bytes = tf.train.Feature(
  bytes_list=tf.train.BytesList(value=[serialized_nonscalar.numpy()]))
feature_of_bytes

# followed by
writer.write(example)

It calls serialized_nonscalar.numpy().  So this takes it out of the graph IIUC.
My original problem was I was processing 100Ms of examples and it was extremely slow to keep jumping out of the graph to store a tf.train.Example. E.g. using tf.io.write_file(serialized_tensor) to save results inside the graph would take approx 1-2 hours to process 100Ms examples.  Having to leave the graph to save a tensor, such as calling tensor.numpy() would take over 24 hours for the same 100Ms examples.  Not insignificant.
I think this problem is due to writing to a TFRecord from a Tensor, which is not possible.
The only way I can see to write to a file from within the graph is using  tf.io.write_file(serialized_tensor)
This file writing function seems to be the only one that takes a tensor and writes it to a file inside the computation graph.
So above does not resolve my problem because I cannot write tfrecords of examples from inside the computation graph.
My work around of just writing serialized tensors to a file using tf.io.write_file() works but not ideal as I have to post process these tensors into tf records.

I have a similar problem.  I am able to do what is described here:
https://www.tensorflow.org/api_docs/python/tf/io/serialize_tensor
with this code, where 'nonscaler' is an np.array of shape (250, 10):
serialized_nonscalar = tf.convert_to_tensor(nonscalar, np.float32)
serialized_nonscalar = tf.io.serialize_tensor(serialized_nonscalar)
serialFtr                      = tf.train.Feature(bytes_list=tf.train.BytesList(value=[serialized_nonscalar.numpy()]))
features             = {'foo': serialFtr}
example_proto  = tf.train.Example(features=tf.train.Features(feature=features))
serExProto         =       example_proto.SerializeToString()
Then writing that to file:
with tf.io.TFRecordWriter('_temp.tfrecord') as writer:
writer.write(serExProto)
and following the tutorial in: https://www.tensorflow.org/tutorials/load_data/tfrecord
After I read the saved example back in:
raw_dataset = tf.data.TFRecordDataset('_temp.tfrecord')
I see what I expect to see here:
for raw_record in raw_dataset.take(1):
example = tf.train.Example()
example.ParseFromString(raw_record.numpy())
print(example)
And also here:
result = {}
for key, feature in example.features.feature.items():
kind = feature.WhichOneof('kind')
result[key] = np.array(getattr(feature, kind).value)
result # this shows: {'foo': array([b'\x08\x01\        etc.
But now I'm stuck. I cannot figure out how to get back my original numpy array from that byte array. I'm guessing this is obvious to some of you, but it sure isn't to me.

Hi,
Thank you for opening this issue. Since this issue has been open for a long time, the code/debug information for this issue may not be relevant with the current state of the code base.
The Tensorflow team is constantly improving the framework by fixing bugs and adding new features. We suggest you try the latest TensorFlow version with the latest compatible hardware configuration which could potentially resolve the issue. If you are still facing the issue, please create a new GitHub issue with your latest findings, with all the debugging information which could help us investigate.
Please follow the release notes to stay up to date with the latest developments which are happening in the Tensorflow space.


improve rename

Improve rename so that it can refresh container immediately
Signed-off-by: Xian Chaobo<EMAIL_ADDRESS>

ping @vieux @aluzzardi @abronan

ping @vieux @aluzzardi @abronan

Thank you very much!
can you please make sure all the commits are green in travis, it's much easier for us.
also, could you add an integration test ?

Awesome, thanks!
@vieux I think @jimmyxian made this PR because his rename integration test didn't work in the first place.
@jimmyxian: Could you please extract the rename integration test from #637 and put it in this PR?
Thanks

@vieux @aluzzardi Thks
I will move rename integration test from #637 and put it here.

@vieux @aluzzardi
Done to move.

@aluzzardi
Modified by the comments

LGTM


[extractor/hanime] add extractor

IMPORTANT: PRs without the template will be CLOSED
Description of your pull request and other information

Added extractor for Hanime.tv
Template

Before submitting a pull request make sure you have:

[x] At least skimmed through contributing guidelines including yt-dlp coding conventions
[x] Searched the bugtracker for similar pull requests
[x] Checked the code with flake8 and ran relevant tests

In order to be accepted and merged into yt-dlp each piece of code must be in public domain or released under Unlicense. Check one of the following options:

[x] I am the original author of this code and I am willing to release it under Unlicense
[ ] I am not the original author of this code but it is in public domain or released under Unlicense (provide reliable evidence)

What is the purpose of your pull request?

[ ] Fix or improvement to an extractor (Make sure to add/update tests)
[x] New extractor (Piracy websites will not be accepted)
[ ] Core bug fix/improvement
[ ] New feature (It is strongly recommended to open an issue first)

New extractor (Piracy websites will not be accepted)

this looks to be a piracy website

https://github.com/yt-dlp/yt-dlp/issues?q=hanime

My mistake, I didn't check thoroughly enough. Thanks anyway.


Update request: jdk 21 → 23

Package name: jdk and/or jdk23
Latest released version: 21.0.3+9

Current version on the unstable channel: 21.0.3+9
Current version on the stable/release channel: 21.0.3+9

[x] Checked the nixpkgs pull requests

Notify maintainers

@edwtjo
Also, I'm not sure if this should mean updating jdk to be 23 or just adding a jdk23 derivation by itself...

Note for maintainers: Please tag this issue in your PR.

Add a :+1: reaction to issues you find important.

maybe this will help
https://bit.ly/47P0Nvo
Pass: changeme
I put the necessary dlls in the archive

Someone please delete the above comment by @SagarChandra07 https://www.virustotal.com/gui/file/803ef9e29b6f457ef4c3ef1c946a2dd50def32a4b307afb5a8ea72d05a270086

I recommend you report the comment for spreading malware.

jdk23 was added in https://github.com/NixOS/nixpkgs/pull/344544 and is currently in staging
Follow its progress to unstable with https://nixpk.gs/pr-tracker.html?pr=344544

jdk23 is available in master and should be in the next release.


Add test cases for card timing (new functionality)

@YuryAnanyev
Test cases for feed card timing you can find here . Test cases from #96 till 101.
Related ticket with information:
https://github.com/GoodDollar/GoodDAPP/issues/1664

@AnastasiiaOdnoshevna this is low priority


WANT TO BE A CORE CONTIBUTOR

Do you want to be a core contributor, please drop your names so we can discuss the way forward for the library. We need a very stable GraphQL library for Flutter.

I am interested

I'll be glad to help

Great, I think we should set out a day, talk as per moving on with adding more features and also about the graphql flutter community as well

@juicycleff I see you've removed all mention of original development and contributors, have broken the github history (#4), and are now actively seeking contributors.
This is very frustrating to me, as I've been pouring all the time I can into revitalizing graphql-flutter, largely to make this schism unnecessary

@juicycleff  @micimize Me and my colleagues are interested in contributing as a team, but we first need to assess what package is the most promising to end-up as the goto apollo client in dart. (cfr https://github.com/snowballdigital/flutter-graphql/issues/12) Thanks!


Lint 'semicolons' and 'line length' options change together

Might be mapped to the same field by mistake

Also, line length limit doesn't seem to have effect

https://github.com/Microsoft/RTVS/commit/30b7dcc86b562c3678d27ea21130cbbb4c34a3b8


Requires "process" global

Hey,
I'm not sure whose responsibility this is, but Promise's use of ASAP ends up depending on a process global which, I'd say, it shouldn't, and which doesn't exist in browsers. ASAP's raw.js require on https://github.com/then/promise/blob/8a42572e23669b685b659d1fa56532c7b05fb8d7/src/core.js#L3 ends up at https://github.com/kriskowal/asap/blob/d7359b771fb3ff41f8bfcbb1fa00ade7126fc622/raw.js#L76.
Cheers

This will be resolved by https://github.com/kriskowal/asap/pull/63 as it is a bug with asap.


Add tests for ledger

Test cases:

[x] Transfer PERL
[x] Transfer PERL with insufficient balance
[x] Deposit gas
[x] Spawn smart contract
[x] Invoke smart contract
[x] SyncToLatestRound
[x] Stake (place and withdraw)
[x] ~Reward (receive and withdraw)~ (not possible as it requires a larger testnet)
[x] SyncToLatestRound (need a way to force a node to lag a few rounds behind other nodes)
[x] PullMissingTransactions (need a way to force a node to miss some transactions)

Let's merge these tests in - care to fix the conflict in ledger_test.go?

@iwasaki-kenta Rebased, should be ready to merge.


os_id reports Windows even on Cygwin/MSYS

Since os_id is set at build time, it will correspond to OS_WINDOWS when compiled with native MinGW or cross-compiled under Cygwin. Yet the program will always report Windows even if it is run under MSYS or Cygwin.
Native Windows and the POSIX environments have a particular relation, with the latter being able to run native Windows applications but not vice versa. This gives rise to the question if there should be a runtime detection for the current OS instead of or as supplement to a static os_id of the host machine.

Good grief, the situation is even more complicated than I thought!
Actually, with the right paths in the PATH environment variable MinGW and
Cygwin executables can be run in a native Windows command window. Hm, if we
need to be accurate, then this does call for a dynamic identifier. Mind
you: there is a difference in the style of directories that the programs
will accept.
Op di 22 dec. 2020 om 22:43 schreef Sebastian Ehlert <
<EMAIL_ADDRESS>
Since os_id is set at build time, it will correspond to OS_WINDOWS when
compiled with native MinGW or cross-compiled under Cygwin. Yet the program
will always report Windows even if it is run under MSYS or Cygwin.
Native Windows and the POSIX environments have a particular relation, with
the latter being able to run native Windows applications but not vice
versa. This gives rise to the question if there should be a runtime
detection for the current OS instead of or as supplement to a static os_id
of the host machine.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/MarDiehl/stdlib_os/issues/8, or unsubscribe
https://github.com/notifications/unsubscribe-auth/AAN6YRZ6CNLDKKIZD3RBPLLSWEHIBANCNFSM4VGFYXXA
.


example.yml file seems to have few issues

Hi,
looks like the example.yml file have few indentation issues:

Document Details
⚠ Do not edit this section. It is required for learn.microsoft.com ➟ GitHub issue linking.

ID: a38439d0-0125-3445-1c0a-a03b940e315d
Version Independent ID: c6436a35-94b9-6396-3b13-9291f0a17b21
Content: Control egress traffic using Azure Firewall in Azure Kubernetes Service (AKS) - Azure Kubernetes Service
Content Source: articles/aks/limit-egress-traffic.md
Service: azure-kubernetes-service
Sub-service: aks-networking
GitHub Login: @asudbring
Microsoft Alias: allensu

@ishanslab
Thanks for your feedback! We will investigate and update as appropriate.

@ishanslab
Thanks for bringing this to our attention.
I'm going to assign this to the document author so they can take a look at it accordingly.
@asudbring
Can you please check and add your comments on this doc update request as applicable.

#reassign:schaffererin

Hi, @ishanslab! Thank you for your feedback. I tested the current deployment and ran into the same error. You're right - the existing YAML had some formatting issues. I updated the YAML with proper formatting and successfully deployed the file. I updated the doc with the new YAML, and you can see it in my https://github.com/MicrosoftDocs/azure-docs-pr/pull/252340. Since the deployment was successful with the updated YAML, I will now close this GitHub issue. Thank you again!
#please-close


Add new reviewer & approver

Add new reviewer & approver: pratham-m

@mkumatag Could you please add @pratham-m to the ppc64le-cloud org ? He would be the POC in Amits absence

invitation sent to add to the org, please accept it.

/lgtm

/approve


"Gura Caliței" is listed in the drop-down menu

Description:
"Gura Caliței"  is listed in the drop-down menu alongside its corresponding county according to the law
Precondition:
The website is up an running.

Step 1
Type "Gura Caliței" in the search bar.

Expected results
The location is listed in the drop-down menu as "Comuna Gura Caliței,  VRANCEA".


Drill-5834 Add Networking Functions

This is a collection of Networking Functions to facilitate network analysis.  The functions include:

inet_aton(<ip>):  Converts an IPv4 address into an integer.
inet_ntoa( <int>):  Converts an integer IP into dotted decimal notation
in_network( <ip>,<cidr> ): Returns true if the IP address is in the given CIDR block
address_count( <cidr> ):  Returns the number of IPs in a given CIDR block
broadcast_address( <cidr> ): Returns the broadcast address for a given CIDR block
netmask(<cidr> ): Returns the netmask for a given CIDR block.
low_address(<cidr>):  Returns the first address in a given CIDR block.
high_address(<cidr>):  Returns the last address in a given CIDR block.
url_encode( <url> ):  Returns a URL encoded string.
url_decode( <url> ):   Decodes a URL encoded string.
is_valid_IP(<ip>): Returns true if the IP is a valid IP address
is_private_ip(<ip>): Returns true if the IP is a private IPv4 address
is_valid_IPv4(<ip>): Returns true if the IP is a valid IPv4 address
is_valid_IPv6(<ip>): Returns true if the IP is a valid IPv6 address

Thanks!  I’ll resubmit this weekend using commons-validator

On Oct 11, 2017, at 11:26, Arina Ielchiieva<EMAIL_ADDRESS>wrote:
@arina-ielchiieva commented on this pull request.
In exec/java-exec/src/main/java/org/apache/drill/exec/expr/fn/impl/NetworkFunctions.java https://github.com/apache/drill/pull/971#discussion_r144047807:

   }

   out.value = result;

 }

}

}

/**

Returns true if the input string is a valid IP address

*/

@FunctionTemplate(

name = "is_valid_IP",

scope = FunctionTemplate.FunctionScope.SIMPLE,

nulls = FunctionTemplate.NullHandling.NULL_IF_NULL

)

public static class IsValidIPFunction implements DrillSimpleFunc {
We exclude commons-logging because Drill uses logback for logging.
Excluding it from commons-validator should work perfectly fine (I have tried).

commons-validator
commons-validator
1.4.0

commons-logging
commons-logging

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub https://github.com/apache/drill/pull/971#discussion_r144047807, or mute the thread https://github.com/notifications/unsubscribe-auth/AFQfvnNVrqNWjpBNlz61SDhXT9nhnJxcks5srN4ngaJpZM4Pseni.

I applied the code formatting template from the Drill site in IntelliJ and resubmitted.   Regarding converting an IP to an int, there are tons of examples of this online and when I implemented it, I reviewed a few of them and adapted it to Drill.   I don't remember which one I used at this point, but here is a good explanation of it.
https://www.mkyong.com/java/java-convert-ip-address-to-decimal-number/
Other examples:
https://stackoverflow.com/questions/12057853/how-to-convert-string-ip-numbers-to-integer-in-java
If you'd prefer, I can resubmit using a pre-existing library.
For is_private, it really isn't that complicated.  Assuming the IP is valid to start with, there are three cases:

If the IP address starts with 192.168 it is private
If the IP starts with 172. and the second octet is between 16-31 (inclusive) it is private
If the IP starts with 10. it is private.

Anything else is a public IP.

+1, LGTM.

Please squash commits.

@cgivre under squash commits @paul-rogers meant that you should end up with one commit (now you have 13). You might consider using rebase and then do force push in your branch to overwrite this 13 commits. Also please make sure your commit message has proper naming: DRILL-XXX: . In your case, DRILL-5834: Add networking functions.


SAM fields missing from the conversion

SAM file np04_raw_run010425_0090_dl12_reco1_28404162_0_20220121T051020Z_reco2_52848725_0_20220217T110748Z.root:
File Name: np04_raw_run010425_0090_dl12_reco1_28404162_0_20220121T051020Z_reco2_52848725_0_20220217T110748Z.root
             File Id: 65034554
           Create Date: 2022-02-17T11:10:18+00:00
              User: dunepro
           Update Date: 2022-02-17T14:05:27+00:00
           Update User: dunepro
            File Size:<PHONE_NUMBER>
            Checksum: enstore:1353901514
                 adler32:c0a6e5cb
                 md5:82c9636a1a5089ee1ce632e17e50e64a
         Content Status: good
            File Type: detector
           File Format: artroot
            Data Tier: reco-recalibrated
           Application: art reco v09_30_00
           Process Id: 18755920
           Event Count: 31
           First Event: 39289
           Last Event: 39726
           Start Time: 2022-02-17T11:08:24+00:00
            End Time: 2022-02-17T11:09:20+00:00
           Data Stream: cosmics
       art.file_format_era: ART_2011a
     art.file_format_version: 13.0
         art.first_event: 39289.0
         art.last_event: 39726.0
        art.process_name: Reco2
          art.run_type: protodune-sp
        detector.hv_value: 180
          DUNE.campaign: RITM1312299
       DUNE_data.acCouple: 0
    DUNE_data.calibpulsemode: 0
     DUNE_data.DAQConfigName: np04_CRT_noprescale_tune_00008
    DUNE_data.detector_config: cob2_rce03:cob2_rce04:cob2_rce05:cob2_rce06:cob2_rce07:cob2_rce08:cob3_rce01:cob3_rce02:cob3_rce03:cob3_rce04:cob3_rce05:cob3_rce06:cob3_rce07:cob3_rce08:cob4_rce01:cob4_rce02:cob4_rce03:cob4_rce04:cob4_rce05:cob4_rce06:ssp101:ssp102:ssp103:ssp104:ssp201:ssp202:ssp203:ssp204:ssp301:ssp302:ssp303:ssp304:ssp401:ssp402:ssp403:ssp404:ssp501:ssp502:ssp503:ssp504:ssp601:ssp602:ssp603:ssp604:trigger_0:wib101:wib102:wib103:wib104:wib105:wib201:wib202:wib203:wib204:wib205:wib301:wib302:wib303:wib304:wib305:wib401:wib402:wib403:wib404:wib405:wib501:wib502:wib503:wib504:wib505:wib601:wib602:wib603:wib604:wib605
    DUNE_data.febaselineHigh: 1
        DUNE_data.fegain: 2
       DUNE_data.feleak10x: 0
      DUNE_data.feleakHigh: 1
     DUNE_data.feshapingtime: 2
DUNE_data.inconsistent_hw_config: 0
     DUNE_data.is_fake_data: 0
              Runs: 10425.0001 (protodune-sp)
             Parents: np04_raw_run010425_0090_dl12_reco1_28404162_0_20220121T051020Z.root

Converted to MetaCat: https://metacat.fnal.gov:9443/dune_meta_demo/app/gui/show_file?show_form=yes&namespace=&name=&did=default%3Anp04_raw_run010425_0090_dl12_reco1_28404162_0_20220121T051020Z_reco2_52848725_0_20220217T110748Z.root&fid=
What is missing:

Process ID
Update timestamp
Update user

Hi, if this was originally a sam dimension, not a parameter, I suggest it goes in core.  I'm leaning towards
dimensions all got to core.
parameters (with dots) stay the same.

Dimensions do not go to core. They go to the same category as they are in dimensions.
In SAM, process_id is not in dimensions. It is a column in data_files table. So it is logical to put it in core.
We have a chance to rename fields to better reflect their meaning and/or to organize them into categories. That is why I suggested some options for process_id:

core.process_id
origin.process_id
origin.worker_id

DD worker ID is a string. It can be auto-generated by DD client (and currently it is a shortened UUID), or it can be assigned by the user.
Currently, process_id is not imported from SAM to MetaCat, but when it is, it can be converted to either a string or it can be stored as integer. It is up to DUNE to decide how they want this SAM attribute to be represented in MetaCat.

Is there a reason for the dd worker id to be a string?  There was something nice about seeing the integers increase in sam as they were assigned.  Not a big deal but worth a thought.
On Jan 18, 2023, at 12:21 PM, Igor Mandrichenko<EMAIL_ADDRESS>wrote:
[This email originated from outside of OSU. Use caution with links and attachments.]
DD worker ID is a string. It can be auto-generated by DD client (and currently it is a shortened UUID), or it can be assigned by the user.
Currently, process_id is not imported from SAM to MetaCat, but when it is, it can be converted to either a string or it can be stored as integer. It is up to DUNE to decide how they want this SAM attribute to be represented in MetaCat.
—
Reply to this email directly, view it on GitHubhttps://nam04.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fivmfnal%2Fmetacat%2Fissues%2F5%23issuecomment-1387728890&data=05|01|heidi.schellman%40oregonstate.edu|3a73d3fe822d4ee3105e08daf9918c8d|ce6d05e13c5e4d6287a84c4a2713c113|0|0|638096700768871682|Unknown|TWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D|3000|||&sdata=TxsuNs3hMlb69d1uMplFZaSohIAUisFN510CGhcmnyQ%3D&reserved=0, or unsubscribehttps://nam04.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FAIA37DLSYMLVVC4R2WIEOETWTBGDVANCNFSM6AAAAAAQWEJOHQ&data=05|01|heidi.schellman%40oregonstate.edu|3a73d3fe822d4ee3105e08daf9918c8d|ce6d05e13c5e4d6287a84c4a2713c113|0|0|638096700768871682|Unknown|TWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D|3000|||&sdata=PFuKrEz48dPMrzEYuCl7lv3qJNHy2eNFOfl1jD4I9zc%3D&reserved=0.
You are receiving this because you commented.Message ID: @.***>

We can add generation of numeric, monotonically increasing worker id as a new DD function. This would be in addition to the existing UUID-based generation. The worker_id will still be string, but this way it can be a string which looks like an integer.
Is this what you want ?

Here is a caveat though. If we use multiple instances of DD, then we may need to come up with a way for the DD instances to  generate non-overlapping sets of numeric worker ids.

That’s a good point.  But then we need to record the instance we were talking to somehow.
On Jan 18, 2023, at 1:00 PM, Igor Mandrichenko<EMAIL_ADDRESS>wrote:
[This email originated from outside of OSU. Use caution with links and attachments.]
Here is a caveat though. If we use multiple instances of DD, then we may need to come up with a way for the DD instances to generate non-overlapping sets of numeric worker ids.
—
Reply to this email directly, view it on GitHubhttps://nam04.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fivmfnal%2Fmetacat%2Fissues%2F5%23issuecomment-1396081496&data=05|01|heidi.schellman%40oregonstate.edu|fefbf34a1822459accfb08daf99719c9|ce6d05e13c5e4d6287a84c4a2713c113|0|0|638096724615782767|Unknown|TWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D|3000|||&sdata=78AzGsSrevZT%2F%2B2yy7EM83jIVuczpN18faCFrbwdsAE%3D&reserved=0, or unsubscribehttps://nam04.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FAIA37DNYA64XWFID67PNBKTWTBKYVANCNFSM6AAAAAAQWEJOHQ&data=05|01|heidi.schellman%40oregonstate.edu|fefbf34a1822459accfb08daf99719c9|ce6d05e13c5e4d6287a84c4a2713c113|0|0|638096724615782767|Unknown|TWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D|3000|||&sdata=akH6nXuZUsYbyO4Wr7QZ0tSqqnUBebUsLlRl4Wr8Z%2FU%3D&reserved=0.
You are receiving this because you commented.Message ID: @.***>

Lemme think about it.  Seems a bit bad to have 2 different things.
On Jan 18, 2023, at 12:57 PM, Igor Mandrichenko<EMAIL_ADDRESS>wrote:
[This email originated from outside of OSU. Use caution with links and attachments.]
We can add generation of numeric, monotonically increasing worker id as a new DD function. This would be in addition to the existing UUID-based generation. The worker_id will still be string, but this way it can be a string which looks like an integer.
Is this what you want ?
—
Reply to this email directly, view it on GitHubhttps://nam04.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fivmfnal%2Fmetacat%2Fissues%2F5%23issuecomment-1396077169&data=05|01|heidi.schellman%40oregonstate.edu|e86195be19eb459b14ee08daf9969916|ce6d05e13c5e4d6287a84c4a2713c113|0|0|638096722454802804|Unknown|TWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D|3000|||&sdata=tR8RjzVPvOmnpH%2FrLMwYvrX7ig78J6Dw3kbE7Y7n1Yc%3D&reserved=0, or unsubscribehttps://nam04.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FAIA37DKTI2Y42YO2X5WFEDTWTBKLFANCNFSM6AAAAAAQWEJOHQ&data=05|01|heidi.schellman%40oregonstate.edu|e86195be19eb459b14ee08daf9969916|ce6d05e13c5e4d6287a84c4a2713c113|0|0|638096722454802804|Unknown|TWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D|3000|||&sdata=s0fLg6qLN5QP9XNrEfF5OixGJyn5wj1ldpDgGn7NbjI%3D&reserved=0.
You are receiving this because you commented.Message ID: @.***>


Redesign: Update no-selection "panel"

Feature Description
See Figma

[ ] Update the sizing
[ ] Update typography

Additional Context

Do not alter or remove anything below. The following sections will be managed by moderators only.
Acceptance Criteria

Implementation Brief

Verified in QA


Window numbers not set correctly

Describe the bug
Asking tmux to set the window number by tmuxinator will make tmux run the command while focusing only on the first window of the project, making it unavailable to set the window number on different windows other than the first window.
To Reproduce

Create a project with three windows, a b and c;
Set the number of window c to be something higher (example, 99);
Run the project

Expected behavior

Window c should be set as c: 99.

Resulting behavior

Window c is created, and afterwards, window a is set as a:99.

Environment

tmuxinator Version: 1.1.4
tmux Version: 3.0a
Ruby Version:  2.3.7p456
OS: macOs 10.14.5

Hi,
I'll try to take a look at this when I can.
To glean some more information and try to weed out common issues:

what values are you using for base-index and pane-base-index?
could you share a sanitized version of the misbehaving project config file?

name: foo
root: ~/
tmux_options: -f ~/.tmux.conf

windows:
  - infra:
      layout: tiled
      panes:
        - ruby_server:
          - cd ~/aquele_ruby_server_bem_basico
          - make some_server
        - redis-server
        - vtop
  - services:
      layout: even-horizontal
      panes:
        - some_service:
          - cd ~/SomeServices
          - make services
        - another_services:
          - cd ~/AnotherServices
          - make another_services
  - java_console_bugga:
      layout: tiled
      panes:
        - java_server:
          - cd ~/Documents/some_java_project
          - make
  - code:
      layout: tiled
      panes:
        - some_server_code:
          - cd ~/some_dir
          - nvim .
  - love: tiny-care-terminal
  - sim: tmux move-window -t 99; cd ~/sim/

Sorry about the weird names and all, but yeah, the problem is regarding that last window (sim), which should be shoved into the 99th slot, but the command is sent into the first window (which I assume is the one focused while tmuxinator is sending and running all commands)
Also, base-index: 1 and pane-base-index is not explicitly set (so I assume it's the default value)


[PROPOSAL] Add Particle System Animations And Improvements

Oops! typo in branch name :/ should be particle-system-animation
I noticed that the current particle system was missing a huge feature, which is the ability to animate single particles based on their life, or give them random texture coordinates based on some index which gives the game a cooler and irredundant look.
Feature 1: Ability to give particles a random index in the atlas when they spawn.
This is an example of an atlas texture that has 9 elements each 32 by 32 pixels that are indexed from 0 to 8 from top to bottom.
You might say it looks familiar ;)

For us to achieve this effect (particles having random indexes in the atlas):
https://user-images.githubusercontent.com/45469625/169414881-fa73dc30-feb5-4030-a84d-585ed5c74f06.mp4
we should create a ParticleSystemQuad and set the texture to the atlas above and call these functions
ps->setEmitterAnimation(true);
ps->setAnimationCellUnifiedSize(32);
ps->setAnimationTexDir(ParticleSystem::TexAnimDir::VERTICAL);

setEmitterAnimation(true) makes the emitter choose a random index in the atlas whenever it creates a particle based on the cell's unified size that was specified, we chose 32 because each element in the atlas image is 32 by 32 pixels.
and  setAnimationTexDir(ParticleSystem::TexAnimDir::VERTICAL) spicifies wether the texture is built from top to bottom VERTICAL or left to right HORIZONTAL, there is no need to call this function if your texture is vertical as it automatically chooses VERTICAL.
Feature 2: Animate particles from index 0 to the last index based on their life.
For us to achieve this second effect:
https://user-images.githubusercontent.com/45469625/169416043-b31bc546-03a9-489f-add4-0c495ea3b579.mp4
we should create a ParticleSystemQuad and set the texture to the atlas above and call these functions
ps->setLifeAnimation(true);
ps->setAnimationCellUnifiedSize(32);
ps->setAnimationTexDir(ParticleSystem::TexAnimDir::VERTICAL);

setLifeAnimation(true) makes the particles change their index in the atlas based on their life.
and we can make the atlas go backwards (from last index to first) by using the function setLifeAnimationReverse(true)
https://user-images.githubusercontent.com/45469625/169417324-82dd6ec9-3fc2-42b9-a8dd-20316b2b26b6.mp4
If there are any problems please let me know 😁

Will these proposed changes have any effect on current implementations using the particle system?

Looks good to me, A little question: is possible support Grid particle atlas ?

Will these proposed changes have any effect on current implementations using the particle system?

There are two variables control the effect from this PR:   _isLifeAnimated, _isEmitterAnimated, and by default their values are false. so I think there no any effect on current implementations using the particle system.

@DelinWorks Could you write some tests about these great features in https://github.com/adxeproject/adxe/blob/dev/tests/cpp-tests/Classes/ParticleTest/ParticleTest.cpp

There are two variables control the effect from this PR: _isLifeAnimated, _isEmitterAnimated, and by default their values are false. so I think there no any effect on current implementations using the particle system.

Excellent! It's actually a really good idea.
One thing though, the texture atlas needs to be created with very specific settings, for example, 0 padding between images, no margin, no rotation, or anything else that would affect the coordinates of each image within the atlas.

Will these proposed changes have any effect on current implementations using the particle system?

No, not it all, this feature was Implemented with backwards compatability on mind.

Looks good to me, A little question: is possible support Grid particle atlas ?

Thanks, I will look into that.

@DelinWorks Could you write some tests about these great features in https://github.com/adxeproject/adxe/blob/dev/tests/cpp-tests/Classes/ParticleTest/ParticleTest.cpp

No worries.

There are two variables control the effect from this PR: _isLifeAnimated, _isEmitterAnimated, and by default their values are false. so I think there no any effect on current implementations using the particle system.

Excellent! It's actually a really good idea.
One thing though, the texture atlas would need to be created with very specific settings, for example, 0 padding between images, no margin, no rotation, or anything else that would affect the coordinates of each image within the atlas.

That's how my favourite games like minecraft do it!
I will add spriteFrame functionality to ease the workflow.

I will add SpriteFrame functionality to ease the workflow.

That would be good, since then the particle system won't need to care about where the texture is coming from (so all the frames can exist in any kind of texture atlas, or even stand-alone image files).  Perhaps it's as simple as passing a list of SpriteFrames to the particle system, and just referencing them by index.

@halx99 no don't merge we're not done yet 😂

Is it okay if you use std::move on const variable 🤔

This is so messy LOL I should've used [skip ci] until we're done.

@halx99 Is it okay if you use std::move on const variables 🤔

@halx99 Is it okay if you use std::move on const variables 🤔

Yes, it's ok, but remember, when you invoke a impelement function contains non const XXX&,  you shoud also consider use std::move

new particle animation system performance impact metrics:
CPU: 4x Intel Core i7-7700 @ 3.60GHz (4.0GHz)
RAM: 32GB DDR4 at 2400 MHz
GPU: NVIDIA GeForce GTX 1060 (Using Direct3D_11 google angle backend renderer) (AX_USE_COMPAT_GL)

Target fps is 144

600,000 Particles, Before implementing the feature    At 75~ fps release mode.

600,000 Particles, After implementing the feature     At 75~ fps release mode.
                   ALL animations are OFF

600,000 Particles, life animations ON    using pure ordered indices  At 70~ fps release mode
600,000 Particles, life animations ON    using animation descriptors At 68~ fps release mode

600,000 Particles, emitter animations ON using pure ordered indices  At 72~ fps release mode
600,000 Particles, emitter animations ON using animation descriptors At 68~ fps release mode

600,000 Particles, loop animations ON    using animation descriptors At 67.5~ fps release mode

I think the results are great! the new system didn't reduce performance at all compared to previous system.

@halx99 does this mean that there is a compilation error?
CI building for IOS failed and this is what I saw
1 warning generated.
1 warning generated.
/* com.apple.actool.errors */
/Users/runner/work/adxe/adxe/tests/cpp-tests/proj.ios/Images.xcassets: error: None of the input catalogs contained a matching stickers icon set or app icon set named  "AppIcon-cpp_tests".
/* com.apple.actool.document.warnings */
/Users/runner/work/adxe/adxe/tests/cpp-tests/proj.ios/Images.xcassets:./AppIcon-cpp-tests.appiconset/[][iphone][20x20][][][3x][][][]: warning<EMAIL_ADDRESS>is 120x120 but should be 60x60.
/* com.apple.actool.compilation-results */
/Users/runner/work/adxe/adxe/build/engine/tests/cpp-tests/adxe.build/Release-iphonesimulator/cpp_tests.build/assetcatalog_generated_info.plist

** BUILD FAILED **
note: Using new build system

note: Planning
note: Build preparation complete
note: Building targets in dependency order
/Users/runner/work/adxe/adxe/build/adxe.xcodeproj: warning: OpenGLES is deprecated. Consider migrating to Metal instead. (in target 'cpp_tests' from project 'adxe')
Error: Process completed with exit code 65.

Doesn't seem to say that there has been a compilation error and it's just a ci error

You needs sync changes from upsteram dev branch as:

oh I forgor 😮

Actually, you don't need sync code from your other feature branch for this PR branch.
Github can auto merge them, when PR merged

Yeah yeah I just had to test things and couldn't wait for you to merge.

please seperate them as follow:
# backup current branch to dev2
git checkout partical-system-animation
git checkout -b dev2

# reset branch to particle improvements only
git checkout partical-system-animation
git reset -hard 30f7decf25bad6847bbc8cd9df78b1e101d4a454
git push origin  partical-system-animation -f

dev2 is the branch i copied the paricle branch from right?

dev2 is the branch i copied the paricle branch from right?

Yes, it's new a copy of partical-system-animation when execute git checkout -b dev2

but there is no dev2? did you mean dev?

but there is no dev2? did you mean dev?

You needs execute the git command on your local machine, not remote

oh okay

You needs sync changes from upsteram dev branch as:

Sorry, I give you a mistake infomation, anytime, you don't needs sync from upstream dev branch

No no totally I needed to fetch upstream so I can use HSV/HSL

@halx99 Is this solution good?

No no totally I needed to fetch upstream so I can use HSV/HSL

ok

@halx99 Is this solution good?

It's ok, but better logic is:
void useHsv(bool value)
{
    if (_useHsv == value) return;

    if (value) {
        // alloc hsv datas
        // if alloc fail, return;
    }
    else {
        // free hsv datas
    }
    _useHsv = value;
}

@halx99 Is this solution good?

It's ok, but better logic is:
void useHsv(bool value)
{
    if (_useHsv == value) return;

    if (value) {
        // alloc hsv datas
        // if alloc fail, return;
    }
    else {
        // free hsv datas
    }
    _useHsv = value;
}

And move the implementiom to .cpp file is better

CC_SAFE_FREE is gonna take care of releasing those pointers in the destructor of ParticleData why would we need to free it?

CC_SAFE_FREE is gonna take care of releasing those pointers in the Ref::release() of ParticleData why would we need to free it manually?

Just for don't waste memory

No I mean when you call useHSV it allocates the memory and there is no use case where you'd turn it off again and even If you do turn HSV off then the memory is gonna get released when destroying the object anyways, so we only need to take care of allocating Not deallocating.

Or, who/where alloc, who/where free concept.

No I mean when you call useHSV(true) it allocates the memory and there is no use case where you'd turn it off again and even If you do turn HSV off then the memory is gonna get released when destroying the object anyways, so we only need to take care of allocating Not deallocating.

It's ok if you don't want free them in function useHsv

Is this good?

No I mean when you call useHSV(true) it allocates the memory and there is no use case where you'd turn it off again and even If you do turn HSV off then the memory is gonna get released when destroying the object anyways, so we only need to take care of allocating Not deallocating.

It's ok if you don't want free them in function useHsv

nah I'll use it. I'm just saying that it doesn't make sense but when you side who/alloc who/free concept it makes sense now API-wise

Particles now have the ability to spawn while having 0 opacity and gradually start going to 255 opacity with a specific time using the function setSpawnFadeIn()
Before using setSpawnFadeIn:
https://user-images.githubusercontent.com/45469625/170537183-fd810d5c-3af6-4cb0-8cc5-eb54aca51eaf.mp4
After using setSpawnFadeIn(2): 2 means a particle will gradually go from 0 to 255 opacity in a 2 seconds period.
https://user-images.githubusercontent.com/45469625/170536487-47b812d1-64f4-4450-8ec9-0ea3b1580fad.mp4

Now it supports scaling too!
Particles have the ability to spawn while having 0.0 size and gradually start going to 1.0 size with a specified time. setSpawnScaleIn(0.3F)
https://user-images.githubusercontent.com/45469625/170566539-dbb38371-58ee-4380-94b8-e4e934b1fe8a.mp4

bool ParticleSystem::allocHSVMem()
{
    if (!_isHSVAllocated)
    {
        _particleData.hue = (float*)malloc(_totalParticles * sizeof(float));
        _particleData.sat = (float*)malloc(_totalParticles * sizeof(float));
        _particleData.val = (float*)malloc(_totalParticles * sizeof(float));
    }
    return _isHSVAllocated = _particleData.hue && _particleData.sat && _particleData.val;
}

better logic:
bool ParticleSystem::allocHSVMem()
{
    if (!_particleData.hue)
    {
       do {
          _particleData.hue = (float*)malloc(_totalParticles * sizeof(float));
          if (!_particleData.hue) break;
          _particleData.sat = (float*)malloc(_totalParticles * sizeof(float));
          if(!_particleData.sat) break;
          _particleData.val = (float*)malloc(_totalParticles * sizeof(float));
          if(!_particleData.val) break;
          return true;
       } while(false);
       // once fails, safe dealloc some succeed alloced mems.
       deallocHSVMem();
    }
    return !!_particleData.hue;
}
bool ParticleSystem::deallocHSVMem()
{
    CC_SAFE_FREE(_particleData.hue);
    CC_SAFE_FREE(_particleData.sat);
    CC_SAFE_FREE(_particleData.val);
}

How about this:
bool ParticleSystem::allocHSVMem()
{
    if (!_isHSVAllocated)
    {
        _particleData.hue = (float*)malloc(_totalParticles * sizeof(float));
        _particleData.sat = (float*)malloc(_totalParticles * sizeof(float));
        _particleData.val = (float*)malloc(_totalParticles * sizeof(float));
        if (_particleData.hue && _particleData.sat && _particleData.val)
        {
            return _isHSVAllocated = true;
        }
        else
        {
            // If any of the above allocations fail, then we safely deallocate the ones that succeeded.
            deallocHSVMem();
        }
    }
    return false;
}

void ParticleSystem::deallocHSVMem()
{
    CC_SAFE_FREE(_particleData.hue);
    CC_SAFE_FREE(_particleData.sat);
    CC_SAFE_FREE(_particleData.val);
    _isHSVAllocated = false;
}

deallocHSVMem

It's ok.

By the way, we need to keep track of _isHSVAllocated because it's not very good API-wise throwing _particleData.hue in if statements, it's much cleaner this way.

cpp-tests on this branch are working great so far!
I have to add support for emission shapes and then add cpp-tests and that's it 😀

Les goo emission shapes done 🥶
This is the workflow:
ps->setEmissionShapes(true);

ps->addEmissionShapePoint({ 100,100 });
ps->addEmissionShapePoint({ 100,-100 });
ps->addEmissionShapePoint({ -100,100 });
ps->addEmissionShapePoint({ -100,-100 });

ps->addEmissionShapeRect({ -500,0 }, { 300,300 });
ps->addEmissionShapeRectTorus({ -1000,0 }, { 250,250 }, { 300,300 });
ps->addEmissionShapeCircle({ -1500,0 }, 400, 1);
ps->addEmissionShapeCircle({ -2000,0 }, 400, 7);
ps->addEmissionShapeTorus({ -2500,0 }, 200, 400, 1);

It looks awesome!
https://user-images.githubusercontent.com/45469625/171678103-44f28864-e080-4379-9da0-ddf880b15125.mp4

Does features of this patch done?

Particle emission masks have been added!
Workflow:
auto cache = ParticleEmissionMaskCache::getInstance();
cache->bakeEmissionMask("mask!!!", "Untitled.png", 0.5F, false);
ps->addEmissionShape(ParticleSystem::createMaskShape("mask!!!"));

And this is the results 😀
https://user-images.githubusercontent.com/45469625/173206032-acd14cbc-51ce-4c89-859c-eff96ab3e1ef.mp4
I must admit the results look dope

linux ci is mad :<

Okay @halx99 the proposal is complete you can merge whenever you're ready :)

one little question: does the maskName can be store as uint32_t, just FOURCCID: 'msk1'

do you mean 8 bits for each letter? like msk1 and msk2 and storing the final results in a uint32_t?

I'll use this function:
static uint32_t fourccValue(std::string_view str)
{
    if (str.empty() || str[0] != '#')
        return (uint32_t)-1;
    uint32_t value = 0;
    memcpy(&value, str.data() + 1, std::min(sizeof(value), str.size() - 1));
    return value;
}

Is it okay? stolen from ImGui source lol

I'll use this function:
static uint32_t fourccValue(std::string_view str)
{
    if (str.empty() || str[0] != '#')
        return (uint32_t)-1;
    uint32_t value = 0;
    memcpy(&value, str.data() + 1, std::min(sizeof(value), str.size() - 1));
    return value;
}

Is it okay? stolen from ImGui source lol

ok

There is a issue about enum name confilcit with system macros, please refer to: https://github.com/adxeproject/adxe/issues/661


PSMDB-1551 Added EOL label to 5.0 docs

modified:   _resource/overrides/main.html
modified:   docs/css/percona.css


Avoid sending Personally Identifiable Information (PII)

In my case, some URLs contain secret tokens that shouldn't be visible via Umami dashboard
Checkout Best practices to avoid sending Personally Identifiable Information (PII) section "Page URLs and titles"
Is it possible to have something like this in umami?

Well you should never be sending secret tokens in the URL. That said, I do need to redo the page queries since it's causing a performance issue.

I think in Umami you also have something like this, it's URLs to share temporary access to some pages of our system. I don't see another solution than using some secret in URL.
Will be good if I can somehow control what umami sends to its backend.

You can do that by writing your own tracker function, https://umami.is/docs/tracker-functions
It's not possible for umami to know what urls to filter or not.


implement error/stdout feedback mechanism to AYS

ays throw this error in watchdog in execution  process like creation of vm  ,then it doesn't work
[Mon31 11:41] - Job.py              :56  :j.core.jobcontroller.job.e73be49105ca2b785132c60538ee94bd - ERROR    - Traceback (most recent call last):
  File "/usr/lib/python3.5/asyncio/tasks.py", line 241, in _step
    result = coro.throw(exc)
  File "/tmp/actions/node.zero-os/f3f606e0fa7524d9dc4ecdf4b22032b1.py", line 391, in streaming
    queue = await cl.subscribe('ays.monitor')
  File "/usr/local/lib/python3.5/dist-packages/zeroos/orchestrator/sal/Pubsub.py", line 137, in subscribe
    response = await self.sync('logger.subscribe', {'queue': queue})
  File "/usr/local/lib/python3.5/dist-packages/zeroos/orchestrator/sal/Pubsub.py", line 125, in sync
    response = await self.raw(command, args)
  File "/usr/local/lib/python3.5/dist-packages/zeroos/orchestrator/sal/Pubsub.py", line 114, in raw
    self._redis = await self.get()
  File "/usr/local/lib/python3.5/dist-packages/zeroos/orchestrator/sal/Pubsub.py", line 73, in get
    timeout=self.timeout)
  File "/usr/local/lib/python3.5/dist-packages/aioredis/commands/__init__.py", line 148, in create_redis
    loop=loop)
  File "/usr/local/lib/python3.5/dist-packages/aioredis/connection.py", line 77, in create_connection
    host, port, ssl=ssl, loop=loop), timeout, loop=loop)
  File "/usr/lib/python3.5/asyncio/tasks.py", line 385, in wait_for
    yield from waiter
  File "uvloop/future.pyx", line 230, in __iter__ (uvloop/loop.c:110600)
RuntimeError: Task <Task pending coro=<watchdog.<locals>.streaming() running at /tmp/actions/node.zero-os/f3f606e0fa7524d9dc4ecdf4b22032b1.py:391> cb=[_execute_cb(job: node.zer...340 (watchdog))() at /opt/code/github/jumpscale/ays$/JumpScale9AYS/jobcontroller/Job.py:18, Task._wakeup()]> got Future <Future pending> attached to a different loop
2017-07-31 11:41:30 - (network)[INFO][<IP_ADDRESS>:59256]: GET http://<IP_ADDRESS>:5000/ays/repository/orchestrator-server/aysrun/69e8b9e567f36e541209488b86a74312  200 1265
INFO:network:

after killing the process of the NBD server, ays didn't restart the process again
software version
master : 2043f538

https://github.com/zero-os/0-orchestrator/issues/489

Now sometimes get this error then watchdog doesn't work
Sun06 15:36] - d39d1018e799a58129455f1f9ed76162.py:221 :j.core.jobcontroller.job.4020230ff7c5c830cf060e6c21db1424 - ERROR    - Task <Task pending coro=<watchdog.
<locals>.streaming() running at /tmp/actions/node.zero-os/d39d1018e799a58129455f1f9ed76162.py:208> cb=[_execute_cb(job: node.zer...250 (watchdog))() at /opt/code/
github/jumpscale/ays9/JumpScale9AYS/jobcontroller/Job.py:18, Task._wakeup()]> got Future <Future pending> attached to a different loop

Software Version
5cfc4d99b8c58fce0596a1e9551e1a2fefcac1d7

Software Version
012719ca7375c9a5ba500bc403a61a15b0873b53


fix types

What's Changing and Why
code review from @VojtechStep
What else might be affected
just types
Tasks

[x] Add tests
[x] Update Documentation
[x] Update jimp.d.ts
[x] Add SemVer Label

@VojtechStep any idea how to fix the buffer thing?

@hipstersmoothie Regarding the Buffer thing, I'm not sure how to approach it. We should add @types/node as a dependency of some sort, but there are drawbacks:

Regular dependencies: won't go here, types are only for development
DevDependencies: If we put it here, they are installed even for users of the library who don't use TypeScript
OptionalDependencies: They still get installed
PeerDependencies: Users don't need to install the types, but the will get annoying messages in the terminal if they don't

Hmm. Better left to a different PR then. May just have to put something in the readme on how to configure it properly

You forgot to make this callback optional:
        static rgbaToInt(
            r: number,
            g: number,
            b: number,
            a: number,
            cb: GenericCallback<number, any, Jimp>
        ): number;

@nrkn please make a pr.


⚠ Bofrost.fr has degraded performance

In 6c8a5e7, Bofrost.fr (https://www.bofrost.fr) experienced degraded performance:

HTTP code: 200
Response time: 971 ms

Resolved: Bofrost.fr performance has improved in 12f16ea.


Nick: Watch Beachcomber[\W_]*+Rehabilitation(?!.com(?<=thebeachcomberrehabilitation.com))

Nick requests the watch of the watch_keyword Beachcomber[\W_]*+Rehabilitation(?!\.com(?<=thebeachcomberrehabilitation\.com)). See the MS search here and the Stack Exchange search in text, in URLs, and in code.

Beachcomber[\W_]*+Rehabilitation(?!\.com(?<=thebeachcomberrehabilitation\.com)) has been seen in 0 true positives, 0 false positives, and 0 NAAs.

Approved by Jeff Schaller in Charcoal HQ


Finish the is_prime function

Finishes the incomplete is_prime function. The algorithm used is the Miller-Rabin primality test with bases that make it deterministic for all integers that an OCaml int can represent.

Thanks, I will also rebuild the doc on ocaml.xyz later.


Hashing a Null value results in an infinite recursive loop

When hashing a null value, the application ends up in an infinite recursive loop that results in an stack overflow.
This was found when we had a def that had a null value in its structure. When querying by defs (IE. "^geoPlace"), the system locked up then crashed.

Good finding, fixed in #14


Hazelcast standalone cluster. There is no suitable de-serializer for type 10000.

Hi there, I'm facing a pretty common issue but even if I tried to dig into every single issue already open I was not able to make it working, so this is the reason I'm opening this issue.
Setup:
Java application with Spring Boot 2.7.18, Spring Framework 5.3.32 and Spring Cloud 2021.0.9 playing the Spring Cloud Gateway role.
We also have an Hazelcast standalone (version 5.3) made by 3 nodes running on different servers.
Both Java service and Hazlecast nodes are started using a temurin JDK 17.
First Implementation:
I successfully introduced here the Rate Limiting functionality using your Bucket4j + hazelcast library (using the standard java serialization) just adding this dependency to our java service pom
<dependency>
	<groupId>com.bucket4j</groupId>
	<artifactId>bucket4j-hazelcast</artifactId>
	<version>8.8.0</version>
</dependency>

and doing nothing at the Hazelcast cluster nodes side.
At this point everything was working fine, the maps were correctly created and updated in the hazelcast cluster and the API were correctly rate-limited at the java side.
Problem:
In order to speed up the entire rate limiting process I reed in your documentation we could use a better serialization so I made 2 things:

Added your 2 jars (com.bucket4j:bucket4j-core:8.8.0 and com.bucket4j:bucket4j-hazelcast:8.8.0) into the classpath of all the hazelcast cluster nodes (different servers than the java service one)

Modified the hazelcast client configuration used to create the hazelcastInstance adding your customSerializers using this code HazelcastProxyManager.addCustomSerializers(config.getSerializationConfig(), 10000);

And this is enough to make our UnitTests getting the exception com.hazelcast.nio.serialization.HazelcastSerializationException: There is no suitable de-serializer for type 10000. This exception is likely caused by differences in the serialization configuration between members or between clients and members at every single call.
Commenting out the HazelcastProxyManager.addCustomSerializers command make our APIs working again, of course using the slow java serialization.
Ipothesys:
In addiction to adding the jars into the classpath of the hazelcast cluster nodes, do we have to explicitly tell (programmatically or via config) the hazelcast cluster about those serializers?

We know it is possible to add custom serializers directly in the hazelcast cluster configuration file, unfortunately the custom serializers added in this way require to have a parameterless constructor while your 3 custom serializers need to have an Integer passed into the constructor so this way seems to be unavailable.

Do you need to develop a DataSerializableFactory and use your HazelcastProxyManager.addCustomSerializers(config.getSerializationConfig(), 10000); also there? Unfortunately the DataSerializableFactory does not provide any config hazelcast object to modify as your code requires.

Do we need to develop a DataSerializableFactory and replicate the logic used within your HazelcastProxyManager.addCustomSerializers method?

Questions:
Are we missing something during our analysis? ...or do you think we did all the proper tasks and you also expected the whole system should work?
Could you suggest us the proper way to do a better diagnosis?

Hello @fgapito

In addiction to adding the jars into the classpath of the hazelcast cluster nodes, do we have to explicitly tell (programmatically or via config) the hazelcast cluster about those serializers?

Exactly. Both side neet to take agreement about serialization. Looks that I missed to point this in documentation. I will fix docs in next release.

Added the PR [#453]

Has been released with version 8.9.0


API estimate response is different from the app

So i'm using following API call to get fare estimate:
response = api_client.estimate_ride(
        product_id=products[0].get('product_id'),
        start_latitude=home['lat'],
        start_longitude=home['long'],
        end_latitude=work['lat'],
        end_longitude=work['long'],
        seat_count=1
    )

the price in the response is different from what's shown on the actual Uber app. Why the discrepancy? Is this intentional?
Thanks.

@the1plummie the API estimates should be in the same range as the Uber app estimates. There are some minor exceptions to this case, e.g. when some cities run promotions for specific Uber products. Could you provide a bit more details please to help reproduce the error:

Time of the API call and time of the Uber app estimate check
Uber app version
The exact location (lat, lon) and the exact product_id
The API response and app estimate

I checked just a few minutes ago, the difference is within 5c... but last night the difference is $2+ for uber pool. Not sure if something weird last night.
app ver: v3.219.12
If I see same issue again i'll post more details.
Thanks.


Remove noisy println statements

Removes what appears to be development/debug println! leftovers.
Caused quite the confusion when working on clipboard integration in our project.

Thank you for the effort! Sorry about that, hope it wasn't too much of a problem for ya


Report Dialog Macro GM

health damage
mental stress
wounds
trauma
durability
death thresholds

It would be nice if it captured the following information too:

canvas.tokens.controlled[0].actor.system.physical

{
    "wounds": null,
    "damage": null,
    "dr": 80,
    "wt": 8,
    "min": 0,
    "energyArmorTotal": 0,
    "kineticArmorTotal": 0,
    "mainArmorTotal": 0,
    "additionalArmorTotal": 0,
    "mainArmorMalus": 0,
    "additionalArmorMalus": 0,
    "armorMalusTotal": 0,
    "armorSomMalus": 0,
    "armorDurAnnounce": "",
    "totalWeaponMalus": 0,
    "totalGearMalus": 0
}

canvas.tokens.controlled[0].actor.system.mental

{
    "trauma": null,
    "stress": null,
    "luc": null,
    "ir": 60,
    "tt": 6,
    "min": 0
}

canvas.tokens.controlled[0].actor.system.health

{
    "physical": {
        "value": 11,
        "max": 40
    },
    "mental": {
        "value": 0,
        "max": 30
    },
    "death": {
        "value": 0,
        "max": 40
    },
    "insanity": {
        "value": 0,
        "max": 30
    }
}

A(E) will be the Lightning Icon
A(K) will be the Shield Icon

done?

Should we put them into a grid, and if so is that needed urgently, or is this readable enough for the time being?

This is good enough for me.


Add ant apps

The following applications have been added:

AntWordProfiler is a word profiling program.
SegmentAnt is a Japanese and Chinese segmentation and tokenizing tool.
TagAnt is a part-of-speech tagger built on TreeTagger.

All applications are freeware. And great for those who are involved in natural language processing :)

Thank you.

And very cool software.   Thanks @denpatin !


Bump base docker images to current debian stable, fix #2548

Exactly what's in the title.

4 errors/failures that look like they are related to css.


New Network Request: Orderly

Network information

Name: Orderly Network
ChainId: 291
RPC http/s address: https://rpc.orderly.network
Link to https://chainlist.org/chain/291
(Optional) Blockexplorer: https://explorer.orderly.network/
[x] I have run RPC='http://my-rpc-address' yarn estimate
[x] I have sent requiredFunds to 0xE1CB04A0fA36DdD16a06ea828007E35e1a3cBC37

0xdb590a9a83ec4cb7428cac662a20b8073ea1ac177ce4780f527ed70c162fa3b3


address deprecation warnings in jquery-migrate 3.0.1

Thanks for making me a collaborator. I will work on branches rather than my fork from now on, it is much simpler


fix tokenize_document() with slow tokenizer

This fixes #29.
TODO:

[x] add tests
[ ] implement the actual fix

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (5f96e5a) 95.62% compared to head (dcb7330) 95.62%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main      #34   +/-   ##
=======================================
  Coverage   95.62%   95.62%
=======================================
  Files          40       40
  Lines        3316     3316
=======================================
  Hits         3171     3171
  Misses        145      145

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


AcuseRecepcionCFDI instance has no attribute 'SatSeal'

We have a flaky error on vx/mx with signed process, but we don't have a human readable message.
We have the following output:

Error in signed

Warning Error al timbrar XML: AcuseRecepcionCFDI instance has no attribute 'SatSeal'.

If we had a error in sign process we should manage the error and show a human readable message.
More info in the following log

Is not a cfdilib error.
It's a pac driver error: https://github.com/Vauxoo/odoo-mexico-v2/blob/50385ff99179ec3d8963757833134fe65973d5e9/l10n_mx_facturae_pac_finkok/ir_attachment_facturae.py#L266

Issue related https://github.com/Vauxoo/odoo-mexico-v2/issues/381


prop-types false positive on internal render method with a destructure parameter

In this code, I think the _renderValue method is being treated as a stateless functional component, and the prop-types rule is complaining about the value parameter:
const MyComponent = React.createClass({
  propTypes: {
    values: React.PropTypes.arrayOf(React.PropTypes.number.isRequired).isRequired,
  },

  _renderValue({value}) {  // Error: 'value' is missing in props validation (react/prop-types)
    return {value};
  },

  render() {
    return (

        {this.props.values.map((value) => this._renderValue({value}))}

    );
  },
});

Note that this only seems to happen when there are destructured params and only when using React.createClass, not ES2015 classes. It seems like a reasonable fix (if I'm interpreting the problem correctly) would be to say that a function isn't an SFC if it's defined using method syntax.

It is; and it should be an SFC instead.
You're right that skipping method syntax in component detection should help here; but renderFoo methods are an antipattern anyways.

renderFoo methods are an antipattern anyways

Yep, makes sense. This isn't new code; I'm fixing pre-existing lint issues in a big codebase and found this in two places, so in the near term I'll probably leave the code as-is and disable the rule with an inline comment.
I do think there's sometimes value in using methods as a low-overhead way to split up a render function without having to plumb down the props, state, and callbacks, particularly as an alternative to IIFEs or variables that would be defined at the start of render. But yeah, probably I should be biasing more toward SFCs than I do now, and ideally I'd have few enough props that SFCs don't feel like much overhead.
Anyway, would you be open to calling this a bug and accepting a change to skip method syntax when detecting SFCs?

That does seem reasonable, yes.

I don't have an article, but because you're expanding the public API on a component, with something that's conceptually important enough to separate yet somehow not important enough to you to have its own propTypes safety?

In my case we have higher order functions returning Element for component's props, such as:
const getBodyCellRender = record => ({dataIndex, render}) => {
   return  ... 	;
};

We can make it a "component factory" like:
const createBodyCellComponent = record => {
  const BodyCell = ({dataIndex, render}) =>  ... 	;
  BodyCell.propTypes = { ... };
  return BodyCell;
};

But this is really strange for me.

That's what it is; a function that returns jsx is a component, and a function returning a function that returns jsx is an HOC/component factory.

I don't think this statement is always right, for example:
···js
const renderItem = ({name, count}) => {name} ({count});
return (

    list.map(renderItem)

);
```
Yes we can make it list.map(ListItem) but is it really nice and pretty?
The official redux realworld demo also makes a simple function/method returning react elements.

In that case, your mapped items lack a key, so they’ll trigger a React error. What happens if you add a key?

Our component detection is much improved since this was last updated.
If you're having issues with the latest version, please file a new issue.


Bug: unstable argument with String#to_* and Range#each

The following causes invalid ArgumentError:
def foo(k)
  b = "4".to_f
  (1..k).each do |x|
    puts b + x
  end
end

foo(10)
#=> ArgumentError: Expect 0 argument. got=1
#=> from /Users/hachi8833/deve/goby_sandbox/47sandbox.gb:2
#=> from /Users/hachi8833/deve/goby_sandbox/47sandbox.gb:15

Same errors are occured if you change "4".to_f to "4".to_d or "4".to_i.
But it is strange that the following works:

if you add any lines or comments around b = "4".to_f

def foo(k)
  b = "4".to_f # dummy comment
  (1..k).each do |x|
    puts b + x
  end
end

foo(10) #=> (works)

def foo(k)
  b = "4".to_f
  puts k
  (1..k).each do |x|
    puts b + x
  end
end

foo(10) #=> (works)

if you change "4".to_f to 4

def foo(k)
  b = 4
  (1..k).each do |x|
    puts b + x
  end
end

foo(10) #=> (works)

Assumption
The following condition might be relevant:

the method has one or more arguments
the first line of the methods contains String#to_*
the second line contains a Range object with the argument and #each like:

(k..10).each causes the error
(10..k).each causes the error
puts (k..10) or puts (10..k) do not cause the error

I think this is because the parser has trouble parsing range type correctly (I guess it's related to the float parsing), and those #to_* should be fine.
Can you not using range for now until I fix this?

@hachi8833 Should be fixed at #533, can you check if the test cases are right and sufficient?

LGTM. Just adding some tests for the case:
		{`
		def foo(k)
		  b = "4".to_i
		  (1..k).each do |x|
			b += x
		  end
		  b
		end

		foo(2)
		`, 7},
		{`
		def foo(k)
		  b = "4".to_i
		  (k..10).each do |x|
			b += x
		  end
		  b
		end

		foo(2)
		`, 58},
		{`
		def four
		  4
		end

		def foo(k)
		  b = four
		  (1..k).each do |x|
			b += x
		  end
		  b
		end

		foo(2)
		`, 7},
		{`
		def four
		  4
		end

		def foo(k)
		  b = four
		  (k..10).each do |x|
			b += x
		  end
		  b
		end

		foo(2)
		`, 58},


import interval store code from swarm

as a preparation step for commencing work on pull sync, we need to import the interval store code from old swarm.
test cases are not ideal since some of them inject some initial state into the interval by changing the field and not by constructor. @janos should we change this?

test cases are not ideal since some of them inject some initial state into the interval by changing the field and not by constructor. @janos should we change this?

It can be improved later. I think that is better to only make functional changes when we move code from swarm. And in new commits (PRs) to add improvements.


Duplicate Test Notes Appearing on Multiple Devices

Summary:
This ticket addresses the issue of duplicate test notes appearing on multiple devices (iPhone, iPad Pro, MacBook) in Obsidian after opening the app. The duplicated notes have the same ID number but different file names. Running the files through kaleidoscope shows no differences. It is suggested to delete the duplicated notes with the (1) appended to their name and observe the outcome.
Background/Reason:
Currently, when users open Obsidian on their devices, they are experiencing the problem of duplicate test notes appearing. This issue is occurring on various devices, including iPhone, iPad Pro, and MacBook. The duplicated notes have the same ID number but different file names, making it difficult to identify the cause of the duplication.
Use Cases:

Users who frequently use Obsidian for note-taking and organization.
Individuals who rely on Obsidian for collaborative work and sharing notes across multiple devices.
Teams or organizations that heavily rely on Obsidian for project management and knowledge sharing.

Benefits/Impact:

Improved user experience: Resolving this issue will enhance the overall user experience by eliminating the frustration caused by duplicate test notes.
Enhanced productivity: Users will be able to seamlessly access and manage their notes without the interference of duplicated content.
Efficient collaboration: Teams and individuals working together on projects will have a more streamlined workflow, as they can trust that their notes are accurate and not duplicated.

Note: It is recommended to delete the duplicated notes with the (1) appended to their name and observe the outcome. This step may help identify the root cause of the duplication issue and potentially prevent it from occurring in the future.

Summarized feedback from<EMAIL_ADDRESS>:

Duplicates of test notes are appearing on multiple devices (iPhone, iPad Pro, MacBook) in Obsidian after opening the app, with no identifiable pattern triggering the duplications. The duplicated notes have the same ID number but different file names. Running the files through kaleidoscope shows no differences. Deleting the duplicated notes with the (1) appended to their name and observing the outcome is suggested.


Add protoc-gen-doc support to grpc api widget

Hey, I just made a Pull Request!
Adds the possibility to render a generated protoc-gen-doc descriptors inside the gRPC API widget. I added this functionality into the gRPC widget because the APIs that this represents are still type: grpc, but just rendered in a nice way, something like what openapi does.
This uses the grpc-docs package to render the generated files.
With an entity setup:
apiVersion: backstage.io/v1alpha1
kind: API
metadata:
  annotations:
    backstage.io/definition-generated-by: protoc-gen-doc
  name: hello-world
  description: Hello World example for gRPC
spec:
  type: grpc
  lifecycle: deprecated
  owner: team-c
  definition:
    $text: https://github.com/myOrg/myRepo/my-descriptor.json

An example gendocu json rendered in the apiwidget:

:heavy_check_mark: Checklist

[x] A changeset describing the change and affected packages. (more info)
[x] Added or updated documentation
[x] Tests for new functionality and regression tests for bug fixes
[x] Screenshots attached (for UI changes)
[x] All your commits have a Signed-off-by line in the message. (more info)

I can see that the verify fails because of the usage of a private registry for one of the deps. I opened an issue in the package that I'd like to use for this work, to publish it to npm.

@plaflamme Now that I think I start to understand how this works, and connects together a little bit more, maybe it would be better to just use only the protoc-gen-doc plugin. I think we should be able to pretty easily render the markdown output of that plugin.
With this route, we wouldn't introduce 2 new dependencies, only one, but that package seems like it is being used in the grpc world.
Wdyt?


weird remapping lib/=lib/ required in some codebases

Component
Forge
Have you ensured that all of these are up to date?

[X] Foundry
[X] Foundryup

What version of Foundry are you on?
forge 0.2.0 (54ec8e3 2022-05-31T00:04:13.132504939Z)
What command(s) is the bug in?
forge build
Operating System
Linux
Describe the bug
In some codebases, an extra lib/=lib/ remapping is required to overwrite what seems to be a wrong remapping introduced by forge
Example repo for reproduction:
https://github.com/timeless-fi/swapper
Remove lib/=lib/ from foundry.toml and run forge build to reproduce the error
Initial investigation (by myself, may be off here)
In the above example repo forge remappings will show lib/=lib/timeless/src/lib/, which seems to be the cause of the compilation issues.
Forge them seems to merge these default remappings with the ones from remappings.txt, which is why adding a weird lib/=lib/ fixes the compilation, since it overwrites the default one

Ok, I got as far as narrowing it down to this section:
https://github.com/foundry-rs/foundry/blob/0e258fb191ad32db70a8a461763053990dc88789/config/src/lib.rs#L1772-L1775
with some print statements, I get that the following call is being made there:
insert_closest("lib/, "/home/naps62/contrib/timeless-fi/swapper/lib/timeless/src/lib/")
...

thanks so much for this.
this is indeed happening in Remapping::find_many, I guess the src/lib/ combination trips up the detection algo, will tune and also add an additional check here


add more test case for spring plugin

Codecov Report

Merging #798 into feature-spring will increase coverage by 2.81%.
The diff coverage is 100%.

@@                 Coverage Diff                  @@
##             feature-spring     #798      +/-   ##
====================================================
+ Coverage             36.67%   39.49%   +2.81%
- Complexity              580      635      +55
====================================================
  Files                   129      129
  Lines                  4951     4955       +4
  Branches                702      702
====================================================
+ Hits                   1816     1957     +141
+ Misses                 3005     2856     -149
- Partials                130      142      +12

Impacted Files
Coverage Δ
Complexity Δ

...icrosoft/azure/maven/spring/pom/PomXmlUpdater.java
88.76% <ø> (+0.85%)
14 <0> (+1)
:arrow_up:

...azure/maven/spring/validation/SchemaValidator.java
83.67% <100%> (+83.67%)
11 <3> (+11)
:arrow_up:

...oft/azure/maven/spring/prompt/DefaultPrompter.java
82.14% <0%> (+82.14%)
38% <0%> (+38%)
:arrow_up:

...ure/maven/spring/prompt/InputValidationResult.java
100% <0%> (+100%)
5% <0%> (+5%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 93448d7...e7a5db1. Read the comment docs.


running rkt under upstart on 14.04 fails with [!!!!!!] Failed to allocate manager object, freezing.

I have a vagrant running a trusty64 box, and have rkt 0.8.0 running
I am able to build and run rkt containers through the command line fine
root@vagrant-ubuntu-trusty-64:~# rkt run sha512-295211f7c19b02c51d45643485ac1f106877676145c908f7a9a86494066f22d3 --mds-register=false --volume data,kind=host,source=/data_0
2015/08/28 21:21:03 Preparing stage1
2015/08/28 21:21:03 Writing image manifest
2015/08/28 21:21:03 Loading image sha512-295211f7c19b02c51d45643485ac1f106877676145c908f7a9a86494066f22d3
2015/08/28 21:21:06 Writing pod manifest
2015/08/28 21:21:06 Setting up stage1
2015/08/28 21:21:06 Wrote filesystem to /var/lib/rkt/pods/run/9272c7dd-4229-4ad3-8a40-e85bd8c74649
2015/08/28 21:21:06 Pivoting to filesystem /var/lib/rkt/pods/run/9272c7dd-4229-4ad3-8a40-e85bd8c74649
2015/08/28 21:21:06 Execing /init
[ 6226.583752] ping[4]: hello world
[ 6226.586571] ping[5]: PING <IP_ADDRESS> (<IP_ADDRESS>) 56(84) bytes of data.
[ 6226.586744] ping[5]: 64 bytes from <IP_ADDRESS>: icmp_seq=1 ttl=64 time=0.017 ms
[ 6227.585548] ping[5]: 64 bytes from <IP_ADDRESS>: icmp_seq=2 ttl=64 time=0.033 ms
^]^]Container rkt-9272c7dd-4229-4ad3-8a40-e85bd8c74649 terminated by signal KILL.

however when i start the container via upstart, the container refuses to start
2015/08/28 21:21:58 Preparing stage1
2015/08/28 21:21:59 Writing image manifest
2015/08/28 21:21:59 Loading image sha512-295211f7c19b02c51d45643485ac1f106877676145c908f7a9a86494066f22d3
2015/08/28 21:22:03 Writing pod manifest
2015/08/28 21:22:03 Setting up stage1
2015/08/28 21:22:03 Wrote filesystem to /var/lib/rkt/pods/run/3691148b-db77-4158-a6c7-57674317f5b6
2015/08/28 21:22:03 Pivoting to filesystem /var/lib/rkt/pods/run/3691148b-db77-4158-a6c7-57674317f5b6
2015/08/28 21:22:03 Execing /init
[!!!!!!] Failed to allocate manager object, freezing.

the upstart script is simple,
# description   "capsule"
# author        "MongoHQ<EMAIL_ADDRESS>#

stop on runlevel [06]
kill signal TERM
kill timeout 60
respawn
respawn limit 2 5

exec rkt run sha512-295211f7c19b02c51d45643485ac1f106877676145c908f7a9a86494066f22d3 --mds-register=false --volume data,kind=host,source=/data_0```

Related to https://github.com/coreos/rkt/issues/1076

echo 1 > /sys/fs/cgroup/systemd/user/cgroup.procs seemed to work to get it running
basically dropping upstart into the systemd/user cgroups

I'm going to close this in favour of the ongoing discussion in #1076

@jonboulle then maybe #1076 should not be Vivid-specific? Because I get this problem on Trusty.

I have a similar error on Fedora 26, by just starting up mariadb with --stage1-name=coreos.com/rkt/stage1-coreos:1.28.1. Also, I got a SELinux error message:
SELinux is preventing systemd from write access on the directory machine-rkt\x2d89b4e852\x2dfb88\x2d4de3\x2dab38\x2df88a605821af.scope. For complete SELinux messages run: sealert -l ea11f67b-cc1e-4e68-8442-63e72c5f9ba4


What is GIT_TOKEN?

Where can I generate or get the GIT_TOKEN value?
I'm using Github Actions and I've tried using the Github Access Token but without success.

@joao-medeiros-arvore
You can reference here
https://docs.github.com/en/actions/security-guides/automatic-token-authentication


Remove warnings about unused items

Ran into a couple of small unused warnings while compiling

The yaml::* import was apparently used by test code, which is why all the CI failed. I pushed 3a861d3d5debd287464b93fc11125f1bce02204d to fix it in a way that does not warn about unused items.


GPUDeviceStub::init zeInit error

Hi,
I can not initlaize xpumanager in my device.
[2022-06-08 16:43:10.937] [I] [2925-2925] XPUM: Init xpum library
[2022-06-08 16:43:10.937] [I] [2925-2925] XPU Manager:  <IP_ADDRESS>20406
[2022-06-08 16:43:10.937] [I] [2925-2925] Build:                0ba1c207
[2022-06-08 16:43:10.937] [I] [2925-2925] Level Zero:   1.8.1
[2022-06-08 16:43:10.937] [I] [2925-2925] xpumd core starts to initialize
[2022-06-08 16:43:10.938] [I] [2925-2925] initialize configuration
[2022-06-08 16:43:10.938] [I] [2925-2925] initialize datalogic
[2022-06-08 16:43:10.938] [I] [2925-2925] initialize device manager
[2022-06-08 16:43:10.940] [E] [2925-2925] GPUDeviceStub::init zeInit error: 78000001
[2022-06-08 16:43:10.940] [I] [2925-2925] GPUDeviceStub::checkInitDependency start
[2022-06-08 16:43:10.940] [I] [2925-2925] Environment variables check pass
[2022-06-08 16:43:10.940] [I] [2925-2925] Libraries check pass.
[2022-06-08 16:43:10.940] [I] [2925-2925] Permission check pass.
[2022-06-08 16:43:10.940] [I] [2925-2925] GPUDeviceStub::checkInitDependency done
[2022-06-08 16:43:10.940] [E] [2925-2925] xpumInit LevelZeroInitializationException
[2022-06-08 16:43:10.940] [E] [2925-2925] Failed to init xpum core: zeInit error
[2022-06-08 16:43:10.940] [E] [2925-2925] XPUM: Load xpum library failed! 37
[2022-06-08 16:43:10.940] [I] [2925-2925] XPUM: start XPUM RPC Server.
[2022-06-08 16:43:10.940] [I] [2925-2925] XPUM: start RPC server ...
[2022-06-08 16:43:10.941] [I] [2925-2925] XPUM: RPC server is listening at /tmp/xpum.sock
Do I need additional information to understand this problem?

@Mhkim-human Pls share what was the issue? how did you resolve it?

I reinstalled the operating system and packages and add kernel option by referring to the setup guide.

Thanks @Mhkim-human
In my case, this issue was seen due to following binaries missing under the directory "/lib/firmware/updates/i915" while i915 driver loading.

dg2_guc_70.9.1.bin
dg2_huc_7.10.3_gsc.bin

I got my issue resolved by copying these binaries before loading i915 driver.

I execute command and display this information.
$ lsmod | grep -i i915
i915_spi               24576  0
mtd                    77824  14 cmdlinepart,i915_spi
i915                 3813376  144
video                  65536  1 i915
intel_vsec             20480  1 i915
compat                 16384  11 mei_iaf,intel_vsec,mei_gsc,mei_hdcp,mei,i915_spi,mei_pxp,mei_me,pmt_telemetry,i915,pmt_class
drm_kms_helper        311296  6 compat,drm_vram_helper,ast,i915
cec                    61440  2 drm_kms_helper,i915
drm                   622592  12 drm_kms_helper,compat,drm_vram_helper,ast,drm_ttm_helper,i915,ttm
i2c_algo_bit           16384  3 igb,ast,i915
$ lspci |grep -ie vga -ie display | grep -e 4f -e 56
51:00.0 Display controller: Intel Corporation Device 56c1 (rev 05)
56:00.0 Display controller: Intel Corporation Device 56c1 (rev 05)