modify terraform for enable_private_dns; refactor master to control-plane and worker to compute

Description
I've modified the terraform to properly create resources when the enable_private_dns option is selected. The primary difference is that the external LB (which I've renamed to api_apps) is created in the private subnet, and the CCM output is modified to point the CCM/CSI at the correct subnet and security list when enable_private_dns is chosen.
The majority of other changes to the file itself is a refactoring of the 2 load balancer names from external_lb and internal_lb to api_apps_lb and api_int_lb since both LBs are used whether the enable_private_dns option is selected or not.
I also refactored terraform.tf and the README.md to change "master" to "control-plane" and "worker" to "compute" to match documentation where "control-plane" and "compute" are referenced over "master" and "worker".
Motivation
The enable_private_dns change is necessary because when we did our infrastructure.tf modifications based on OPCT testing, we did not properly account for the enable_private_dns_option. This change is necessary to give customers the option to create their cluster without being able to access it from the open internet. I left the public subnet and routes to be created in both options to give customers the ability to easily create their own VM within it.
Testing
Ran pre-commit before committing to format and validate infrastructure.tf
I created 2 clusters with enable_private_dns set to true and false. enable_private_dns=true gave me our standard cluster setup while enable_private_dns=false was built with the api_apps LB in the private subnet. Both clusters were created successfully and I verified access to both. I was able to create a proxyVM in the public subnet of the cluster where enable_private_dns=true, copy the kubectl to the proxyVM, and view/manage the cluster. I wasn't 100% able to view the OpenShift dashboard after fiddling with my /etc/hosts file and port-forwarding 8080 -> 443 to the private IP of the api_apps LB, but I got close, getting some 401/403s for some of the responses, but it was there.

@davidfoster0127 I'm testing this now but I do have a quick comment in the meantime

enable_private_dns=true gave me our standard cluster setup while enable_private_dns=false was built with the api_apps LB in the private subnet

Is this a typo? It should be the other way around.

@davidfoster0127 just tested private cluster deployment with no issues
$ kubectl config view | grep server     server: https://api.ocimak.local.fake:6443
$ kubectl get co
NAME                                       VERSION   AVAILABLE   PROGRESSING   DEGRADED   SINCE   MESSAGE
authentication                             4.15.9    True        False         False      6m19s
baremetal                                  4.15.9    True        False         False      29m
cloud-controller-manager                   4.15.9    True        False         False      31m
cloud-credential                           4.15.9    True        False         False      33m
cluster-autoscaler                         4.15.9    True        False         False      29m
config-operator                            4.15.9    True        False         False      30m
console                                    4.15.9    True        False         False      12m
control-plane-machine-set                  4.15.9    True        False         False      29m
csi-snapshot-controller                    4.15.9    True        False         False      30m
dns                                        4.15.9    True        False         False      29m
etcd                                       4.15.9    True        False         False      28m
image-registry                             4.15.9    True        False         False      17m
ingress                                    4.15.9    True        False         False      17m
insights                                   4.15.9    True        False         False      23m
kube-apiserver                             4.15.9    True        False         False      8m38s
kube-controller-manager                    4.15.9    True        False         False      27m
kube-scheduler                             4.15.9    True        False         False      26m
kube-storage-version-migrator              4.15.9    True        False         False      30m
machine-api                                4.15.9    True        False         False      29m
machine-approver                           4.15.9    True        False         False      30m
machine-config                             4.15.9    True        False         False      28m
marketplace                                4.15.9    True        False         False      29m
monitoring                                 4.15.9    True        False         False      16m
network                                    4.15.9    True        False         False      30m
node-tuning                                4.15.9    True        False         False      17m
openshift-apiserver                        4.15.9    True        False         False      24m
openshift-controller-manager               4.15.9    True        False         False      13m
openshift-samples                          4.15.9    True        False         False      23m
operator-lifecycle-manager                 4.15.9    True        False         False      29m
operator-lifecycle-manager-catalog         4.15.9    True        False         False      29m
operator-lifecycle-manager-packageserver   4.15.9    True        False         False      24m
service-ca                                 4.15.9    True        False         False      30m
storage                                    4.15.9    True        False         False      30m
$ kubectl get nodes
NAME                                                        STATUS   ROLES                  AGE   VERSION
ocimak-compute-1.private.openshiftvcn.oraclevcn.com         Ready    worker                 23m   v1.28.7+f1b5f6c
ocimak-compute-2.private.openshiftvcn.oraclevcn.com         Ready    worker                 23m   v1.28.7+f1b5f6c
ocimak-compute-3.private.openshiftvcn.oraclevcn.com         Ready    worker                 24m   v1.28.7+f1b5f6c
ocimak-control-plane-1.private.openshiftvcn.oraclevcn.com   Ready    control-plane,master   33m   v1.28.7+f1b5f6c
ocimak-control-plane-2.private.openshiftvcn.oraclevcn.com   Ready    control-plane,master   33m   v1.28.7+f1b5f6c
ocimak-control-plane-3.private.openshiftvcn.oraclevcn.com   Ready    control-plane,master   20m   v1.28.7+f1b5f6c

LGTM

@davidfoster0127 I'm testing this now but I do have a quick comment in the meantime

enable_private_dns=true gave me our standard cluster setup while enable_private_dns=false was built with the api_apps LB in the private subnet

Is this a typo? It should be the other way around.

Yes, it's a typo


Added Privacy Policy Page

Fixes Issue #1151
It is very important to add privacy policy page to vigybag website.

Hey @codervivek5
please merge this PR

https://github.com/codervivek5/VigyBag/assets/137484958/dbca20c0-18bd-42c9-8f33-1d074bfd5432


npm: Indicate that 0.12.x is a supported engine

Since the project is node 0.12 compatible and has tests running against that engine, we can indicate support in package.json to suppress the warning npm will print out if you install running 0.12

Follow-on of #114

Coverage remained the same at 83.44% when pulling 429b940acc78050f088e7e6e284516b4b5501cd5 on mike-spainhower:update-node-engine-info into c722449c9548194f1ab41186cc70e80f5643637b on niftylettuce:master.

Coverage remained the same at 83.44% when pulling 429b940acc78050f088e7e6e284516b4b5501cd5 on mike-spainhower:update-node-engine-info into c722449c9548194f1ab41186cc70e80f5643637b on niftylettuce:master.

Thank you!


Remove G and F functions

"Unfortunately, it is not possible to define stationary processes on a linear network (in the strict sense). The network itself is not homogeneous, that is, different neighbourhoods have different geometry. This cuts off one of the main routes to developing statistical methodology. For example, there is no analogue for linear networks of the empty space function F and nearest-neighbour distance function G (Illian et al., 2008; Baddeley et al., 2015, Chap. 8)."

As @sjsrey pointed out, we should remove the Network G and Network F function from spaghetti as per page 11 from:

Baddeley, A., G. Nair, S. Rakshit, G. McSwiggan, and T. M. Davies. 2020. Analysing point patterns on networks — A review. Spatial Statistics (xxxx):100435.

[x] remove from network.py
[x] remove from analysis.py
[x] remove from network-analysis.ipynb
[x] update docs as necessary

Addressing in #468


NPM update

Prerequisites

[x] I have read the documentation.

Description
I was wondering would it be possible to update the package on NPM to include the showErrorList prop. Thank you

Released in v0.38.0.


Add preempt verb for scheduler

Ref: https://github.com/kubernetes/kubernetes/pull/58717
More configure examples should be added later.

Can you find someone from sig-scheduling to review this?
BTW We are actually trying to reduce examples in this repository. Do you have an alternative place for this to live? Such as the documentation?

@ahmetb Thanks. The reviewers of main repo will do review so this should not be a problem.
Emm, I think it can be placed in the doc repo but better with other configure files (existing and up coming) and other scheduler examples.

cc @kubernetes/sig-scheduling-pr-reviews

/lgtm
+1 to @resouer , most people will try to find the configuration in some central place after reading
the document.

btw, should we also move other scheduler config to this repo?
@ahmetb , or we have other place to do that :)

@bsalamat @k82cn Actually it is required to migrate examples here, the original folder will soon be deprecated and do not accept new contribute.
Reasons for blocking this PR:
[examples/ has moved to https://github.com/kubernetes/examples/]

examples/scheduler-policy-config-with-extender.json

@gyliu513 Could you please close the 59401 and migrate it to this repo?

Actually it is required to migrate examples here, the original folder will soon be deprecated and do not accept new contribute.

Great!
BTW, how do we control the version/release?

Version control of this repo is not clear for me.

@k82cn

BTW, how do we control the version/release?

What specifically are you interested in?

The configuration maybe different between versions e.g. 1.8 vs. 1.9, how to maintain those two version of example?

@k82cn yes, we are going to start maintaining that soon.

Actually it is required to migrate examples here, the original folder will soon be deprecated and do not accept new contribute.

@resouer I see. Could you or @gyliu513 use his PR that has the full list of priority and predicate functions?

@bsalamat I will prefer to see if @gyliu513  can move kubernetes/kubernetes#59401 to this repo first.
Because this PR is actually part of kubernetes/kubernetes#58717

ping for next step :)

/approve

@bsalamat @k82cn if you're interested in being an owner for these examples, please consider creating a directory (right now these YAMLs reside in staging/ dir which is not great at all) and adding yourself as OWNERS.

@resouer UH OH, I should not have merged this.
Now we have two duplicates:

https://github.com/kubernetes/examples/blob/master/scheduler/scheduler-policy-config-with-extender.json
https://github.com/kubernetes/examples/blob/master/staging/scheduler-policy-config-with-extender.json

Can you send a PR to move (1) to (2)?

@ahmetb Don't worry, I will fix it.


[AUCTIONEER PR REVIEW]: add support for BinPackFirstFitWeight

Welcome!
If you're here to request review of a PR submitted to a diego sub-component repo, you're in the right place.

Simply provide a URL to the PR you'd like us to review, submit this review request, and we'll take a look!
https://github.com/cloudfoundry/auctioneer/pull/8

Thanks @pommi - Since there's also a PR to diego-release which refers to all the other PR's required for this feature, I'm going to close this and manage the review through that PR: #448


Update create-ilb-ase.md

Correcting a typo in the request. The document reads appservicewebsites.net instead of appserviceenvironment.net.

@kaushalp : Thanks for your contribution! The author(s) have been notified to review your proposed change.

@ccompy can you verify that the update that @kaushalp made is accurate and if so sign off to merge the update?  Thanks!

@ccompy, can you review this PR?

@kaushalp Thank you for your contribution. Apologize in the delay in getting back to you.  This file was already changed and has the correct information in it. #please-close


Compilation error on Linux Centos7

Dear Devito programmers,
I am compiling devito on a Linux Centos 7 distribution. I am using Miniconda3 and tcsh as shell. I followed the README.md instructions up to
git clone https://github.com/opesci/devito.git
cd devito

Then, since I have tcsh shell I used:
source /home/user/activate.tcsh /path/to/miniconda3
instead of
source activate devito
in which activate.tcsh is a file taken from here
It worked fine. The problem arises when I type:
pip install -e .
I get the following error:
    /usr/bin/ld: /usr/local/lib64/libblas.a(zher2k.o): relocation R_X86_64_32 against `.rodata' can not be used when making a shared object; recompile with -fPIC
    /usr/bin/ld: /usr/local/lib64/libblas.a(scopy.o): relocation R_X86_64_PC32 against symbol `memcpy@@GLIBC_2.14' can not be used when making a shared object; recompile with -fPIC
    /usr/bin/ld: final link failed: Bad value
    collect2: error: ld returned 1 exit status
    error: Command "/usr/bin/gfortran -Wall -g -Wall -g -shared build/temp.linux-x86_64-3.7/numpy/linalg/lapack_litemodule.o build/temp.linux-x86_64-3.7/numpy/linalg/lapack_lite/python_xerbla.o -L/usr/local/lib64 -L/usr/lib/gcc/x86_64-redhat-linux/4.8.5 -L/usr/lib/gcc/x86_64-redhat-linux/4.8.5 -Lbuild/temp.linux-x86_64-3.7 -llapack -llapack -lblas -lblas -lgfortran -o build/lib.linux-x86_64-3.7/numpy/linalg/lapack_lite.cpython-37m-x86_64-linux-gnu.so" failed with exit status 1

    ----------------------------------------
Command "/home/angelo/miniconda3/bin/python -u -c "import setuptools, tokenize;__file__='/tmp/pip-install-k64g44le/numpy/setup.py';f=getattr(tokenize, 'open', open)(__file__);code=f.read().replace('\r\n', '\n');f.close();exec(compile(code, __file__, 'exec'))" install --record /tmp/pip-record-u81zfgaw/install-record.txt --single-version-externally-managed --compile" failed with error code 1 in /tmp/pip-install-k64g44le/numpy/
You are using pip version 10.0.1, however version 18.1 is available.
You should consider upgrading via the 'pip install --upgrade pip' command.

I am quite unexperienced with this kind of problems, and I have no clue on what to do. Do you have any suggestions?
Please find attached a file containing the complete terminal output with the error message. Let me know if you need further info.
Thank you in advance,
Angelo
screen_output.pdf

Hi Angelo,
what gcc collection are you using?

Hi Fabio,
The gcc version is 4.8.5 20150623 (Redhat 4.8.5 - 28)
Angelo
Il ven 12 ott 2018, 09:08 Angelo Sajeva<EMAIL_ADDRESS>ha scritto:

Hi Fabio,
Thank you for your reply, I don't remember, I will let you know as soon as
I have physical access to the hardware.
Angelo
Il ven 12 ott 2018, 17:09 Fabio Luporini<EMAIL_ADDRESS>ha
scritto:

Hi Angelo,
what gcc collection are you using?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/opesci/devito/issues/659#issuecomment-429358760, or mute
the thread
https://github.com/notifications/unsubscribe-auth/Ao8x8a_xb7HIy8E8Va-tsE7g6UroK3-Jks5ukLCQgaJpZM4XXv0u
.

yes, that's a bit old. Can you upgrade to anything more recent?

Thank you for the reply, I cannot temporarily access the cluster's node.
When I will, I will try to upgrade as you suggested.
I will keep you updated as soon as I have news.
Thank you again,
Angelo
On Fri, Oct 19, 2018 at 10:14 AM Fabio Luporini<EMAIL_ADDRESS>wrote:

yes, that's a bit old. Can you upgrade to anything more recent?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/opesci/devito/issues/659#issuecomment-431282648, or mute
the thread
https://github.com/notifications/unsubscribe-auth/Ao8x8VoTvOPbAddxGxIk4gh8mJpiCytaks5umYnpgaJpZM4XXv0u
.

I solved in the following way. I moved to bash. Followed the procedure in
README.md. It worked. Evidently there were problems caused by using tcsh. I
tested tutorials 01 in seismic modelling and 02 in RTM and they work. I
haven't installed new gcc as you suggested, but I have noticed that devito
now uses  Python 3.6.6 |Anaconda, Inc.| (default, Oct  9 2018, 12:34:16) [GCC
7.3.0]. So a new gcc was already there, it was just not linked correctly.
Thank you for the support,
Angelo
On Mon, Oct 22, 2018 at 6:06 PM Angelo Sajeva<EMAIL_ADDRESS>wrote:

Thank you for the reply, I cannot temporarily access the cluster's node.
When I will, I will try to upgrade as you suggested.
I will keep you updated as soon as I have news.
Thank you again,
Angelo
On Fri, Oct 19, 2018 at 10:14 AM Fabio Luporini<EMAIL_ADDRESS>wrote:

yes, that's a bit old. Can you upgrade to anything more recent?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/opesci/devito/issues/659#issuecomment-431282648, or mute
the thread
https://github.com/notifications/unsubscribe-auth/Ao8x8VoTvOPbAddxGxIk4gh8mJpiCytaks5umYnpgaJpZM4XXv0u
.

no problem. Glad you fixed it. I'll close this issue, but should you bump into something new, do not hesitate to report.
Thanks!


Simple working example?

const HeadlessChrome = require('simple-headless-chrome')
const browser = new HeadlessChrome({
headless: true // If you turn this off, you can actually see the browser navigate with your instructions,
chrome: {
userDataDir: '/tmp/headlessDataDir' // This can be null, so a tmp folder will be created and then destroyed
}
})
browser.goTo("http://www.google.com");
(node:31486) UnhandledPromiseRejectionWarning: Unhandled promise rejection (rejection id: 1): TypeError: browser.goTo is not a function
Throws error and it is not working as expected or  am I missing something?
As per the documentation this module compatible for node>=4., could you please share a simple working example in node 6.x, I mean without using async and await.
This will be very helpful for beginners like me.....

@prajeeshkayyur I have a minimal test setup here: https://github.com/gr2m/headless-chrome-test
I think you have to wait for  await browser.init() to resolve before using any other methods.
Try this
const HeadlessChrome = require('simple-headless-chrome')

const browser = new HeadlessChrome({
  headless: true
  chrome: { userDataDir: '/tmp/headlessDataDir' }
})

browser.init()
  .then(() => {
    return browser.goTo("http://www.google.com")
  })
  .catch(console.log)

Thank you!. But still I'm getting error.
  `  const browser = new HeadlessChrome({
        headless: true,
        launchChrome: true ,
        chrome: {
            host: 'localhost',
            port: 9222, // Chrome Docker default port
            remote: true,
        },
        browserlog: true
    });

    this.browser = browser.init().then(function (data) {

        return browser;

    }, function (err) {
        console.log(err)
    })

    console.log(this.browser.goTo); // getting as undefined`

One more question, how to use getValue?
let value = this.browser.getValue(context).then(function(value) {             console.log("hello"); // not printing this or anything             if(value){                 console.log(value);                 return value;             }         }).catch(function (err) {             if(err){                 console.log("Error fetching element", err); /// no error too...             }         }); console.log(value); /// shows promises

Hi @prajeeshkayyur !
You can't get the value like that. When the promise resolves, you get the value inside the promise but can't get it outside in the same line.
You can read a little bit more here: https://stackoverflow.com/a/29516570/3078968
I hope it helps!
Cheers!
Lucho

after wrapping the response with promise, It worked for me. Actually I was integrating headless chrome driver to codeceptJS with the help of simple-headless-chrome. It worked nicely!!!

I'm glad it was useful to you @prajeeshkayyur !
If you think that what you did may be useful for somebody else, feel free to upload it as an example inside the "/examples" directory :)
Thanks!
Lucho


Add license file

Hi, can you add license file ? So go doc site can displays docs

Added, thank you.


[BUG] Invalid Link in Readme

Describe the bug
the contributor convent link is redirecting to 404 page not found.
Steps To Reproduce
Go to Readme File and click on Contributor Convent link
Expected behavior
it should redirect to a valid Contributor Convent Page.
Screenshot
No response
Desktop
No response
Mobile
No response
Additional Context
No response

@omeraplak If the bug seems valid to you I would like to fix it!

Hey @kailashchoudhary11 ,
I couldn't find this link on README but you can create a PR


Build installation/configuration documentation

Build documentation within the repository to allow someone to download, install and configure SmartHire with their own data and models.  Enhance the main README.md file and link to other files as necessary.
For OpenNLP, you can link to the default models (http://opennlp.sourceforge.net/models-1.5/). You can also give instructions on how to train new models with our code/scripts against new data, given that the default models don't perform well against resumes.
You can edit MD files directly through the github interface which allows previewing formatting as you go. Otherwise, github atom has a markdown editor plugin.
You can test your documentation works by cloning the code locally to one of your laptops and trying to get the full stack working there without our data/models.
Good examples of documentation:
https://github.com/fchollet/keras
https://github.com/tensorflow/tensorflow
https://github.com/angular/material

Can use same Google doc in #102
https://docs.google.com/document/d/1FLOjZ0vKrbbcGpgCg5d5_WTIwtT0zrNDVndNv78Cfzc/edit#

Documentation is there now for the main README and ETL README. Only the app README left.

app readme is now complete. will ask Joe about more details for Jenkins


inline ignore ARG_TYPE_MISSING

First off, I want to thank everyone for all the hard work and I'm excited to be getting started with this, hopefully I'll be able to make some contributions to the project in the future.
I originally posted this at cfml.slack.com in the cflint channel, but haven't received a response and I'm not sure where else to ask, so, I'm bringing this over here. Original message follows.

I have a question regarding inline ignore.
This appears to be the correct syntax, yes?
public struct function validate( argA, argB, argC ) { //cflint ignore:ARG_TYPE_MISSING
    // validation logic
    return {};
}

in general I want this rule applied but want to provide inline exceptions where necessary
also  Multiline ignore annotation
https://github.com/cflint/CFLint/blob/2fa060b7ec8a6df1a521bc1fd408cf72ffdf202f/src/test/resources/com/cflint/tests/Ignores/ignoreCFMLAny2.cfc
I tried this, but it didn't seem to work either;
/*
  @CFLintIgnore ARG_TYPE_MISSING
*/
public struct function validate( argA, argB, argC ) {
// validation logic
return {};
}

I do not see test coverage in the source specifically for this syntax ( I do see a test for missing_var for comparison );
https://github.com/cflint/CFLint/search?utf8=%E2%9C%93&q=MISSING_VAR&type=
https://github.com/cflint/CFLint/search?utf8=%E2%9C%93&q=ARG_TYPE_MISSING&type=
can anyone confirm this or educate me on what I'm missing? (edited)
I've tested this in isolation running from the command prompt using versions 1.2.0 and 1.2.2
I've tested in VS Code & Sublime Text 3 as well with the same results
I attached my latest Test.cfc and result
CfLint.zip

There is a bug in pre-1.3.0 for inline ignores in mixed cftag and cfscript source code.
The following does work for me:
component {

    /*
    	@CFLintIgnore ARG_TYPE_MISSING,ARG_DEFAULT_MISSING
    */
    public struct function validate( foo ) {
        // validation logic

        if( isNull( arguments.foo ) ) {
            arguments.foo = '';
        }

        return {
            'foo' : arguments.foo,
        };
    }

}

@steveleve ,  There are two kinds of code structures in CFLint.  expressions and statements,  the inline ignores were working for messages that flag at the expression level, but not at the statement level.   This is fixed in dev and will work better in v 1.3.0.
Thanks for taking the time to accurately report the issue you were having.


Create SPEC file

These PRs include:

new spec file
deleted forgotten include
changed wording client to tool

It is not a good practice to include the .spec file in the repository, because it changes independently from the package. For example, package maintainer may decide to rebuild it, which changes the release number, and you may have even more than one spec file - for example for the new and former Fedora versions. Of course, you host the .spec file in a git repository, but not in the Github with the project.
The other changes are good, there is no problem in merging them.

@matejak  Well, I'll remove the .spec file.

Tests were failing but they work again, so merging, the versioning problem can be addressed later.


Release/1.0.1

[X] bump LiteDB dep in Snowplow.Tracker to 3.0.1
[X] bump Snowplow.Tracker version to 1.0.1
[X] bump Snowplow.Tracker.PlatformExtensions dep to Snowplow.Tracker 1.0.1
[X] bump Snowplow.Tracker.PlatformExtensions version to 1.0.1
[x] fix dotnet core demo to use 1.0.1 version of Snowplow.Tracker
[x] fix Xamarin demo to use 1.0.1 version of Snowplow.Tracker.PlatformExtensions
[ ] upload Snowplow.Tracker 1.0.1 to nuget
[ ] upload Snowplow.Tracker.PlatformExtensions 1.0.1 to nuget

Hey @jbeemster do you mind taking a look through this? I'm about ready to publish to nuget

hey @jbeemster I've checked it fixes the problem by replicating the problem & using the local package. Tests pass, lets ship!


file urls do not work on windows

Because windows has to be different...
The URI ruby library does not work as expected on windows because of the fact there is no root drive.  So files fail to download because the urls are interpreted incorrectly.
Example:
irb(main):006:0> URI('file://d:/OSS/one/two/three.zip').path
=> "/OSS/one/two/three.zip"

And adding another slash produces another issue
irb(main):007:0> URI('file:///d:/OSS/one/two/three.zip').path
=> "/d:/OSS/one/two/three.zip"

This should be d:/OSS/one/two/three.zip

I have this working on my own fork with the following:
class FILE
      def initialize(_url, _options)
      end

      def normalize_path(uri)
        # URI for windows does not work as expected and returns a path without the root drive
        # this attempts to fix that
        if /^file:\/{2}([a-z,A-Z]?)/.match(uri.to_s)   # file://c:/one/two/three.zip
          uri.to_s.gsub(/^file:\/{2}([a-z,A-Z])?/, "#{$1}:")
        else
          uri.path
        end
      end

      def download(uri, file_path)
        src_path = normalize_path(uri)
        FileUtils.copy(src_path, file_path)
      end
    end

If this is acceptable I can make a PR.

file:///d:/OSS/one/two/three.zip is technically correct, because I think file://d:/OSS/one/two/three.zip, would be host = d:, path = OSS, and this patch is implementing the wrong behavior (puppet:/// and not puppet:// because puppet://{server}/). So maybe implementing #77 is the better approach, because this is not intuitive for Windows.


notif: Add vm:entry-point pragma to _onBackgroundMessage

This fixes part of #528, following the suggestion @n-92 made here:
https://github.com/zulip/zulip-flutter/issues/342#issuecomment-1874716442
Even with this change, notifications still don't yet work on Android in release builds.  But after this change, when the app wasn't in the foreground, they get farther than before.  Specifically they get just as far as they get, with or without this change, when the app was in the foreground.  Details here:
https://github.com/zulip/zulip-flutter/issues/528#issuecomment-1960646800

Great, thanks! Merged, and looking forward to the rest of the fix for #528.


Fix commented example for DotNetCoreTest

Hi @mrahhal, I'm your friendly neighborhood .NET Foundation Pull Request Bot (You can call me DNFBOT). Thanks for your contribution!
You've already signed the contribution license agreement. Thanks!
The agreement was validated by .NET Foundation and real humans are currently evaluating your PR.
TTYL, DNFBOT;

@mrahhal thank you for taking the time to submit this change, really appreciated!


Implement unit tests for javascript functionality

Original issue name: plateViewer.js is untested
It would be good to add tests for at least the PlateViewer class, but really anything that may make sense would be good to have properly tested.

Since Javascript implements a lot of use-facing functionality, it would be really good to have at least some basic unit-testing for plate mapping at the least. We may find the source of some of our intermittent errors here.

This is an ongoing issue partially addressed with the "Establish a Javascript unit testing framework" milestone. Removing from that milestone as fully resolving this specific issue was not a requirement for completion of the milestone.

@fedarko @qiyunzhu Now that we have a framework in place to develop additional tests, we can look at adding the most obvious ones for the next release. Following that, we can close this issue and issue individual issues for subsequent tests.

@qiyunzhu As mentioned, here is the official issue for the adding unit tests and refactoring javascript code as needed to support those tests. As this issue is relatively general, if you want, we can sit down together and look through the javascript and break this issue down by file, class, etc.


netatalk: remove glibc input

Motivation for this change
netatalk failes to build
Things done

[x] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
Built on platform(s)

[x] NixOS
[ ] macOS
[ ] other Linux distributions

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
[ ] Tested execution of all binary files (usually in ./result/bin/)
[ ] Determined the impact on package closure size (by running nix path-info -S before and after)
[ ] Ensured that relevant documentation is up to date
[x] Fits CONTRIBUTING.md.

netatalk service starts, could not yet test if it also works as a timemachine.


How I can contact you by email?

@georgezhao2010: How I can contact you by email?
Can I have your email address?
You can remove this ticket after sending the reply ^^
Thanks in advance.

@georgezhao2010: How I can contact you by email?
Can I have your email address?
You can remove this ticket after sending the reply ^^
Thanks in advance.

<EMAIL_ADDRESS>

@georgezhao2010: Thanks, I will send you an email soon!
You can remove this ticket (feature at right of this issue)

@georgezhao2010: Have you received my email?
Thanks in advance.


More numerically stable gradients for division.

This PR improves the numerical stability of gradients for the division operator.
Let f = x / y such that df/dy = - x / y ** 2. But if y is of small magnitude, y ** 2 can underflow, and if y is of large magnitude, y ** 2 can overflow. It is thus better to compute the derivative as df/dy - (x / y) / y. The changes are illustrated in the figure below using 32-bit floating point representations.

The coverage of the new implementation is strictly greater than the coverage of the old implementation, where coverage is the domain in which the gradient is defined.

Can one of the admins verify this patch?

Here is a notebook to reproduce the figure above.

Jenkins, test this please.

Ignoring unrelated errors.


Add missing extern "C" to header files (closes #104)

@kilograham I didn't make any changes to the host libraries -- do you want me to do those too?

yes please


watchman permission problem

Hello,
i'm trying to build a app and when i run npm run start command to building i got the following errors which contains watchman lib, i'm sure problem is from watchman permission. how can i fix this?
P.S: There's no problem when i use npm run start command with sudo

Terminal Log:
masoud@zombies:~/Desktop/AwesomeProject$ npm run start

><EMAIL_ADDRESS>start /home/masoud/Desktop/AwesomeProject
> node node_modules/react-native/local-cli/cli.js start

Scanning 715 folders for symlinks in /home/masoud/Desktop/AwesomeProject/node_modules (5ms)
 ┌────────────────────────────────────────────────────────────────────────────┐
 │  Running packager on port 8081.                                            │
 │                                                                            │
 │  Keep this packager running while developing on any JS projects. Feel      │
 │  free to close this tab and run your own packager instance if you          │
 │  prefer.                                                                   │
 │                                                                            │
 │  https://github.com/facebook/react-native                                  │
 │                                                                            │
 └────────────────────────────────────────────────────────────────────────────┘
Looking for JS files in
   /home/masoud/Desktop/AwesomeProject

[10/20/2016, 1:09:32 PM] <START> Building Dependency Graph
[10/20/2016, 1:09:32 PM] <START> Crawling File System
[Hot Module Replacement] Server listening on /hot

React packager ready.

ERROR: Unknown option --no-pretty

Watchman:  watchman--no-pretty get-sockname returned with exit code 1 ERROR: Unknown option --no-pretty

 ERROR  watchman--no-pretty get-sockname returned with exit code 1 ERROR: Unknown option --no-pretty

Error: watchman--no-pretty get-sockname returned with exit code 1 ERROR: Unknown option --no-pretty

    at ChildProcess.<anonymous> (/home/masoud/Desktop/AwesomeProject/node_modules/fb-watchman/index.js:198:18)
    at emitTwo (events.js:106:13)
    at ChildProcess.emit (events.js:191:7)
    at maybeClose (internal/child_process.js:877:16)
    at Socket.<anonymous> (internal/child_process.js:334:11)
    at emitOne (events.js:96:13)
    at Socket.emit (events.js:188:7)
    at Pipe._handle.close [as _onclose] (net.js:493:12)

See http://facebook.github.io/react-native/docs/troubleshooting.html
for common problems and solutions.

npm ERR! Linux 4.4.0-43-generic
npm ERR! argv "/home/masoud/.nvm/versions/node/v6.5.0/bin/node" "/home/masoud/.nvm/versions/node/v6.5.0/bin/npm" "run" "start"
npm ERR! node v6.5.0
npm ERR! npm  v3.10.8
npm ERR! code ELIFECYCLE
npm ERR<EMAIL_ADDRESS>start: `node node_modules/react-native/local-cli/cli.js start`
npm ERR! Exit status 11
npm ERR!
npm ERR! Failed at the<EMAIL_ADDRESS>start script 'node node_modules/react-native/local-cli/cli.js start'.
npm ERR! Make sure you have the latest version of node.js and npm installed.
npm ERR! If you do, this is most likely a problem with the AwesomeProject package,
npm ERR! not with npm itself.
npm ERR! Tell the author that this fails on your system:
npm ERR!     node node_modules/react-native/local-cli/cli.js start
npm ERR! You can get information on how to open an issue for this project with:
npm ERR!     npm bugs AwesomeProject
npm ERR! Or if that isn't available, you can get their info via:
npm ERR!     npm owner ls AwesomeProject
npm ERR! There is likely additional logging output above.

npm ERR! Please include the following file with any support request:
npm ERR!     /home/masoud/Desktop/AwesomeProject/npm-debug.log

This appears to be a duplicate of https://github.com/facebook/react-native/issues/2941. Closing for now


Fixed #26312 -- Added information about testing databases to tutorial 2.

I added to the note about non-sqlite databases to suggest creating a
test_ database while creating the main database to avoid errors in
tutorial section 5 on tests.
I also added information on making sure that the user provided to the
settings file has privileges for the two databases.  I don't have
enough experience with PostgreSQL to know whether the privileges
section applies there too, but I don't think it does.  For now it, that
part is labeled MySQL specific.

It might be better to add this information to https://docs.djangoproject.com/en/1.9/topics/testing/overview/#the-test-database and link to it from the tutorial. I think it would be more convenient to recommend that the database user have "create database" privileges rather than recommend creating a test database manually.

merged in b388c294eb5745b3e01dedf0220636fae87ea9a2, thanks!


Package "six" is missing from dependecies

Package "six" needs to be added to requirements.txt, otherwise the generate_vocabularies.py script won't run correctly.

The Pipfile was initialised wrong, it should be fixed now


Update grammar.cpp

I'm a little confused because you closed the merge request for the sequence.cpp that implements the isLastChildIsOptional method.
Could you add a comment containing an example JSGF file that shows the bug this is trying to fix?
I do believe this was a bug but I'd like to have an example to test on.

I now understand the bug you were trying to fix with this, but I am pursuing a different fix. Thank you for your contribution though!


Issues with running chained bash commands in Tasks via Powershell+Docker

Version: 1.33.0 (user setup)
Commit: 0dd516dd412d42323fc3464531b1c715d51c4c1a
Date: 2019-04-04T15:14:28.026Z
Electron: 3.1.6
Chrome: 66.0.3359.181
Node.js: 10.2.0
V8: 6.6.346.32
OS: Windows_NT x64 10.0.17763
Steps to reproduce:

Try to pass chained bash commands in tasks using Powershell which runs docker image
Error occurs due to the && operator

I am using Docker container as my build enviroment on Windows. In VSCode, I have several tasks which run some make targets in that container. Here's an example:
        "label": "[Make][Debug]",
        "type": "shell",
        "problemMatcher": [
            "$gcc"
        ],
        "windows": {
            "command": "docker run -it -v ${PWD}:/project build_env /bin/bash -c \"make -j8 DEBUG=1\"",
        },
        "linux": {
            "command": "make -j8 DEBUG=1",
        }

This works fine. It launches my Docker image and executes make inside container. The problem occurs when my bash command is actually a chain of more commands, ie.:
        "label": "[Make] [GTest] FW update",
        "type": "shell",
        "problemMatcher": [
            "$gcc"
        ],
        "windows": {
            "command": "docker run -it -v ${PWD}:/project build_env /bin/bash -c \"cd tests && make TESTS=fw\"",
        },
        "linux": {
            "command": "cd tests && make TESTS=fw",
        }

In VSCode terminal I am getting the following error:
Executing task: docker run -it -v ${PWD}:/project build_env /bin/bash -c "cd tests && make TESTS=fw" <

At line:1 char:72
+ ... it -v ${PWD}:/project build_env /bin/bash -c cd tests && make TE ...
+                                                                ~~
The token '&&' is not a valid statement separator in this version.
    + CategoryInfo          : ParserError: (:) [], ParentContainsErrorRecordException
    + FullyQualifiedErrorId : InvalidEndOfLine

Now, I realize Powershell doesn't support && operator but:

I am not chanining multiple Powershell commands - the && part is argument for bash command
The command works fine when I run it in Powershell window directly, which is strange.

Here's the output:
PS C:\dev\EsProject> docker run -it -v ${PWD}:/project build_env /bin/bash -c "cd tests && make TESTS=fw"
Building test_FwUpdater.cpp
Building aes/aes128.cpp
Building aes/aes256.cpp
Linking.
Created executable: build/fw.out
PS C:\dev\EsProject>

We run tasks in PowerShell like this:
> powershell.exe -Command "echo hello"

I suspect you'll need some additional escaping for the && in this case.
What happens when you start cmd and run:
powershell.exe -Command "docker run -it -v ${PWD}:/project build_env /bin/bash -c \"cd tests && make TESTS=fw\""

This:
The string is missing the terminator: ".
    + CategoryInfo          : ParserError: (:) [], ParentContainsErrorRecordException
    + FullyQualifiedErrorId : TerminatorExpectedAtEndOfString

I am working around this by using cmd as default terminal which seems to work fine.

You can set cmd just for this one task if you want:
      "options": {
        "shell": {
          "executable": "cmd.exe"
        }
      }


Fix incorrect calculation of album length

The album length was not calculated correctly because it generated a concatenated string instead of the number of seconds.

Isn't song.length always a number?

No, song.length returns a string here :/ Maybe a more appropriate solution would be to add a cast to the Eloquent model?
class Song extends Model
{
    protected $casts = ['length' => 'float'];
    ...
}

works for me even i I revert the change proposed in my PR.

Yes, that's a more proper fix. Can you send a PR over?
On Sat, Dec 19, 2015 at 7:15 PM, Matthias Gutjahr<EMAIL_ADDRESS>wrote:

No, song.length returns a string here :/ Maybe a more appropriate
solution would be to add a cast to the Eloquent model?
class Song extends Model{    protected $casts = ['length' => 'float'];    ...}
works for me even i I revert the change proposed in my PR.
—
Reply to this email directly or view it on GitHub
https://github.com/phanan/koel/pull/105#issuecomment-165977129.


Require executable to be run as admin

Bug Report
The user profile folders required administrator access before files could be copied.
Expected Behavior

What behavior was supposed to happen?

Copy user files without error but not output anything.
Actual Behavior

What behavior really happened

Nothing. Pressing the button did not create a folder in the destination.
Steps to Reproduce the Problem

Build exe
Copy exe to pc to copy from
Don't log in to Active Directory
Enter name of profile folder top copy from
Enter destination
Start script

Specifications

Version: 1.3.0
Platform: Win 7
Commit: Dev - c86ec77d9766ede7eb79d4b1eb57fbfc970c5797

Commit 8da4089a95820f7d68d17641777bc6d5d26dba90 has the beginnings of the feature. Its not functional but the groundwork is there

Fixed by adding an "An"
Reference commit https://github.com/BGogurt/CopyUserFiles/commit/0fb8450da05184ea98cf0f67b9a61573fa0b6751

You're kidding


fix: include analog files in additionalPagesDirs

.analog and .agx files are not includes when they are in additional dir paths
Closes #
[optional] What gif best describes this PR or how it makes you feel?

It has been registered but shows that it missing export default, can you provide more info what can be wrong? @brandonroberts

So I've made proposed changes but there is still same error @brandonroberts

@illunix needs a fix here
https://github.com/analogjs/analog/blob/beta/packages/vite-plugin-angular/src/lib/angular-vite-plugin.ts#L493
    const globs = [
      ...pluginOptions.include.map((glob) => `${workspaceRoot}${glob}`),
      ...pluginOptions.include.map((glob) => `${workspaceRoot}${glob}`.replace(/\.ts$/, '.analog'),
    ];

@illunix needs a fix here
https://github.com/analogjs/analog/blob/beta/packages/vite-plugin-angular/src/lib/angular-vite-plugin.ts#L493
    const globs = [
      ...pluginOptions.include.map((glob) => `${workspaceRoot}${glob}`),
      ...pluginOptions.include.map((glob) => `${workspaceRoot}${glob}`.replace(/\.ts$/, '.analog'),
    ];

You mean to add this second line in array or what? Because in the og code this line does not exist

@illunix needs a fix here
https://github.com/analogjs/analog/blob/beta/packages/vite-plugin-angular/src/lib/angular-vite-plugin.ts#L493
    const globs = [
      ...pluginOptions.include.map((glob) => `${workspaceRoot}${glob}`),
      ...pluginOptions.include.map((glob) => `${workspaceRoot}${glob}`.replace(/\.ts$/, '.analog'),
    ];

You mean to add this second line in array or what? Because in the og code this line does not exist

Yes, add the second line to the array

@illunix needs a fix here
https://github.com/analogjs/analog/blob/beta/packages/vite-plugin-angular/src/lib/angular-vite-plugin.ts#L493
    const globs = [
      ...pluginOptions.include.map((glob) => `${workspaceRoot}${glob}`),
      ...pluginOptions.include.map((glob) => `${workspaceRoot}${glob}`.replace(/\.ts$/, '.analog'),
    ];

You mean to add this second line in array or what? Because in the og code this line does not exist

Yes, add the second line to the array

So I've already tried and it gives same error, about missing default export

@illunix you may to restart the dev server locally and hard refresh

@illunix you may to restart the dev server locally and hard refresh

Okey, I'll try again in a couple of minutes

I've tried, and as I said, still there is this error @brandonroberts

I've tried, and as I said, still there is this error @brandonroberts, is it working for u?

Yes, it works locally for me with all the changes

@brandonroberts Then look at the https://github.com/analogjs/analog/pull/1264/files changed files and tell me if I missed something or everything is right, because I think I've done all required changes

@brandonroberts I've tested right now after your changes and still this error occurs


Fixing «cURL error 3:  malformed»

Hi Matt, There's a prob with the signing-up, when a user try to sign-up The following error appeared: «cURL error 3:  malformed», it's about Guzzle requests ! how did you fix it?
Thanks.
(it's my first issue so be tolerant about my english and my ignorance)

@atefBB Not sure, I've never seen it before. Could you get any more information about the error? A stack trace or a screenshot or anything? Can you show me which page and what you entered into each field? Thanks!

Sure ‼ when I try to sign-in this error appeared.

Ah, that's an improperly configured Slack endpoint. Do you have the latest code? I thought that had been fixed recently.

In libcurl lib/url.c:
rc = sscanf(data->change.url, "%[^\n/?#]%[^\n]", conn->host.name, path);

failf(data, "<url> malformed");
          return CURLE_URL_MALFORMAT;

Most likely it doesn't like the :443, as this is implicitely the default port of https.


Dashboard Settings: Publisher Logo Dimension Check

Feature Description
When a new publisher logo is added we should check that it is the proper dimensions. If it is not at least 96px x 96px a warning should show.
Alternatives Considered

Additional Context
#2747
https://docs.google.com/document/d/1Xs4uOZ3KCNlTMdjDT6q7cvTUpA1xk-kzrnVLQALltQk/edit#heading=h.g8j12riqi2ft

Do not alter or remove anything below. The following sections will be managed by moderators only.
Acceptance Criteria
Only images that are 96px x 96px or larger should be accepted as publisher logos on the settings view
Implementation Brief

We can either check this locally or in the settings API when a new logo is added.

@o-fernandez - just confirming that this is something we want for 1.0 - stable since it's something we want to do on the backend and will require workspace time. This dimension check is not currently something that's in place in the editor either when you set publisher logos there.

@o-fernandez - just confirming that this is something we want for 1.0 - stable since it's something we want to do on the backend and will require workspace time. This dimension check is not currently something that's in place in the editor either when you set publisher logos there.

We could delay the check, but should at least tell users that we recommend 96x96px publisher logos.

Does this suffice for now?

Verified in QA


Generate form from validation schema?

Figured I would throw this in here while is fresh on the mind. Not something that has to be added to the core. But I think it would be really cool to be able to pass along a validation schema (like zod) and use that to completely generate a form. I plan on looking into it over the next couple of weeks.

I think it can work as a modular package like the different schema validators. Maybe I will look into this in the future but now I focused on polishing and focus on the type safety part, but in the meantime I will think about it.

@PizzaConsole  I looked into this and I don't think generate form from validation schema is a good way.
The main problem with this approach is these validators are strongly typed so you can't add custom attributes to their object value. To hack it around just take too much time, especially if you want to implement different validators.
I think a better approach using validators as it used now and use it for typing like the useForm. My idea looking like this:
I made a component called SchemaField which takes a schema array as prop. In the background this will generate the fields.
The schema will look like this:
type LoginRequest = {
  username: string;
  nested: {
    foo: string;
  }
}

const jsonSchema: JSONSchema<LoginRequest> = [
  {
    name: 'username',
    component: Field,
  },
  {
    name: 'nested.foo',
    component: Field,
    attrs: {
      default: 'Hello World!'
    }
  },
];

In template:
<SchemaField :schema="jsonSchema">

Beside this approach is working just fine there comes some difficulty because of the headless approach of this library. Most of the time you will have to make custom components to use it in real life scenario because you don't have that much freedom with json schema to add different elements before/above/next to the element.
I think it can work with complex use case but you have to do some work with the components the schema will use.

This already can achieved with this library, beside the named component based on the validation field. But otherwise I don't see any special step in that library which can't be done with the current setup.
You can use zod or the other supported validators infer types for type safety and autocompletion.
I'm also not a big fan of this named component by validator key thing. For a complex form it can be confusing. I like generic naming little bit more.


Migrated shows "Closed" as first state

I am trying to import our JIRA server entries to Azure Devops. The migration completed without error, but I have a strange behaviour. In the history of all imported entries the first state is "Closed" instead of "Proposed" or "Active". I have attached the history of an imported item:
History in Azure Devops:

Original history in Jira:

and the state mapping is as follows:
	    {
          "source": "Pending",
          "target": "Proposed"
        },
		{
          "source": "IN PROGRESS",
          "target": "Active"
        },
	    {
          "source": "VERIFIED",
          "target": "Closed"
        },
	    {
          "source": "Open",
          "target": "Active"
        },
		{
          "source": "RESOLVED",
          "target": "Resolved"
        },
		{
          "source": "Closed",
          "target": "Closed"
        },
		{
          "source": "Reopened",
          "target": "Active"
        },
		{
          "source": "UNDER TEST",
          "target": "Test"
        },
        {
          "source": "To Do",
          "target": "To Do"
        },
        {
          "source": "In Progress",
          "target": "Doing"
        },
        {
          "source": "Done",
          "target": "Done"
        }

Strange behavior indeed. Marking this as a bug.
Any chance you can share the migration log file as a pastebin? @gnimor

@Alexander-Hjelm: What log files do you need? wi-import or jira-export log?

Both if possible!

From: gnimor @.>
Sent: Wednesday, July 6, 2022 1:39:32 PM
To: solidify/jira-azuredevops-migrator @.>
Cc: Alexander Hjelm @.>; Mention @.>
Subject: Re: [solidify/jira-azuredevops-migrator] Migrated shows "Closed" as first state (Issue #491)
@Alexander-Hjelmhttps://eur02.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2FAlexander-Hjelm&data=05|01|alexander.hjelm%40solidify.dev|3853ec46dfb54be7d7cd08da5f4432b6|1f39fa86968941dab81ed60e10615bf0|0|0|637927043761808336|Unknown|TWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D|3000|||&sdata=3ce5dz2BV7ZZWeITqWPmiU79NvLoy5XZxm%2BUoCU38qg%3D&reserved=0: What log files do you need? wi-import or jira-export log?
—
Reply to this email directly, view it on GitHubhttps://eur02.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fsolidify%2Fjira-azuredevops-migrator%2Fissues%2F491%23issuecomment-1176116867&data=05|01|alexander.hjelm%40solidify.dev|3853ec46dfb54be7d7cd08da5f4432b6|1f39fa86968941dab81ed60e10615bf0|0|0|637927043761808336|Unknown|TWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D|3000|||&sdata=PPGoOGh5ICZt4OoQoGDNwjbO5BkYv68HRENRL5fEWUE%3D&reserved=0, or unsubscribehttps://eur02.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FACRQL6B4DLOYZC5V5GIINXTVSVV7JANCNFSM52Y36TKA&data=05|01|alexander.hjelm%40solidify.dev|3853ec46dfb54be7d7cd08da5f4432b6|1f39fa86968941dab81ed60e10615bf0|0|0|637927043761808336|Unknown|TWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D|3000|||&sdata=7rq%2FOpPcqPhSAxJYsxLpL51rUJC3qeTYWOrJtJum2b4%3D&reserved=0.
You are receiving this because you were mentioned.Message ID: @.***>

Sure..
jira-export-log-220706-082414.txt
wi-import-log-220706-082605.txt

Hi @Alexander-Hjelm , any idea if there will be a fix for this anytime soon? We are facing the same issue with the tool.

@rambaliga
No estimate unfortunately. Since we don't have any direct funding for the jira-azdo migration tool, we can only work on it as soon as time allows us to. But we always welcome community fixes :)
If you are in urgent need, or if we can help you with your migration in some other way, you are always welcome to make a business inquiry to Solidify AB, Sweden.

I have tried to reproduce this behavior, but haven't been successful. Everything seems to works fine. so I'm relabeling this as a support issue.
@gnimor , @rambaliga . Do you have any additional info that could help with reproducing this issue? Have you identified any patterns, whether this issue happens for some work items but not for others?
Have you tried both the latest Release and the latest version on the master branch?


docs: add reference to vendor-source-map flag

Superseeded by https://github.com/angular/angular-cli/pull/11732


mac code sign issue in 0.50.2

all recent releases were fully code-signed by
LBRY Inc (66QQKUW9TB)
the new release 0.50.2 is not code signed at all.
is this a legit release or has your account been hacked?

It's a known issue we are looking into (and why auto update didn't work).

This should be fixed now!


Updated the formatting of the bullets

We also need to update the screenshot so it matches the new description. Not sure how to do that.
Thanks for contributing to Wagtail! 🎉
Before submitting, please review the contributor guidelines https://docs.wagtail.io/en/latest/contributing/index.html and check the following:

Do the tests still pass? (https://docs.wagtail.io/en/latest/contributing/developing.html#testing)
Does the code comply with the style guide? (Run make lint from the Wagtail root)
For Python changes: Have you added tests to cover the new/fixed behaviour?
For front-end changes: Did you test on all of Wagtail’s supported environments?

Please list the exact browser and operating system versions you tested.
Please list which assistive technologies you tested.

For new features: Has the documentation been updated accordingly?

Thanks @phildexter!


Feature request - simple data visualizer as VS extension or standalone

Excuse me if same issue already exists but I don't find.
So this is necessary feature, definitely. Sometimes I need to check some values in my data (especially while debugging) but I should to write some stuff for that everytime. Very uncomfortable, you know :)

Sounds amazing, when will be the next version published? :-)

Hi @dengxufan, not so soon. v5 is a big new version and I need implement and test lot of code. My idea is launch on end of 2018

Hi David!
Sorry if I missed it but is it released?

The upcoming release v5 has a standalone Windows application called LiteDB.Studio which is the successor of the Lite.Shell.
Next version will be released shortly.


Refresh wrap definition for fluidsynth library

Upstream project has a lot of optional features, this version supports
only few of them so far. See list of commented-out options in
meson_options.txt

Thanks. :)


Revert "chore(deps-dev): bump the website-deps group in /website with 1 update"

Reverts aws/karpenter-provider-aws#5729

Pull Request Test Coverage Report for Build<PHONE_NUMBER>
Details

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 82.595%

Totals

Change from base Build<PHONE_NUMBER>:
0.0%

Covered Lines:
5054

Relevant Lines:
6119

💛  - Coveralls


Please consider fixing issues detected by repository checker

Notification from ioBroker Check and Service Bot
Dear adapter developer,
I'm the ioBroker Check and Service Bot. I'm an automated tool processing routine tasks for the ioBroker infrastructure. I have recently checked the repository for your adapter roadtraffic for common errors and appropiate suggestions to keep this adapter up to date.
This check is based the current head revisions (master / main  branch) of the adapter repository
Please see the result of the check below.
ioBroker.roadtraffic
   -
ERRORS:

[ ] :heavy_exclamation_mark: [E184] "common.subscribe" will be removed with js-controller >= 6. Please remove from io-package.json and adapt code if required.

WARNINGS:

[ ] :eyes: [W113] Adapter should support compact mode
[ ] :eyes: [W184] "common.main" is deprecated and ignored. Please remove from io-package.json. Use "main" at package.json instead.
[ ] :eyes: [W184] "common.materialize" is deprecated for admin >= 5 at io-package.json. Please use property "adminUI".
[ ] :eyes: [W505] setTimeout found in "main.js", but no clearTimeout detected
[ ] :eyes: [W853] .npmignore found - consider using package.json object "files" instead.

SUGGESTIONS:

[ ] :pushpin: [S522] Please consider migrating to admin 5 UI (jsonConfig).

Please review issues reported and consider fixing them as soon as appropiate.
Errors reported by repository checker should be fixed as soon as possible. Some of them require a new release to be considered as fixed. Please note that errors reported by checker might be considered as blocking point for future updates at stable repository.
Warnings reported by repository checker should be reviewed. While some warnings can be ignored due to good reasons or a dedicated decision of the developer, most warnings should be fixed as soon as appropiate.
Suggestions reported by repository checker should be reviewed. Suggestions can be ignored due to a decision of the developer but they are reported as a hint to use a configuration which might get required in future or at least is used be most adapters. Suggestions are always optional to follow.
You may start a new check or force the creation of a new issue at any time by adding the following comment to this issue:
@iobroker-bot recheck
@iobroker-bot recreate
Please note that I (and the server at GitHub) have always plenty of work to do. So it may last up to 30 minutes until you see a reaction. I will drop a comment here as soon as I start processing.
Feel free to contact me (@iobroker-bot) if you have any questions or feel that an issue is incorrectly flagged.
And THANKS A LOT for maintaining this adapter from me and all users.
Let's work together for the best user experience.
your
ioBroker Check and Service Bot
@mcm1957 for evidence
Last update at Wed, 11 Sep 2024 04:34:13 GMT

Issue outdated due to RECREATE request. Follow up issue #139 has been created.
This issue will be closed.
your
ioBroker Check and Service Bot


division by zero during training

Thanks for your great work. I am currently training EasyAnimate with the default setting in script/train.sh. During training, there are some "division by zero" printed. It does not interrupt the training, and the loss looks normal. Is it normal to see such a warning during training? I am not sure whether I should continue my current training as it takes much time and resources to train.
Thanks!

show your real log would be better

Thanks for your reply.  The log looks like this:

And the progress bar looks like this:

Note that there are about 700 lines of "division by zero" (out of 25000 iterations ) printed in the console. I am not sure where this warning comes from. It is just printed rather than leading to an error.

Check your train data path, this log means some data not found.


Page Not Found: Custom Events Overview

Link: https://www.adobe.io/apis/experienceplatform/events/docs.html#!adobedocs/adobeio-events/master/custom_events.md
Repro:

Go to https://www.adobe.io/apis/experienceplatform/project-firefly/docs.html
Click on "Guides"
Click on "Custom Events Overview"
Error in red shown: PAGE NOT FOUND: The page you tried to access seems to be missing. Please contact us if you believe this to be an error.

All the subpages under https://www.adobe.io/apis/experienceplatform/project-firefly/docs.html#!AdobeDocs/project-firefly/master/guides/exc_app/overview.md are missing on adobe.io.
on github, .../guides/exc_app/overview.md does exist and the link in adobe.io points to .../guides/exc_app/overview.md but the pages itself do not exist.
broken links on adobe.io:

https://www.adobe.io/apis/experienceplatform/project-firefly/docs.html#!AdobeDocs/project-firefly/master/guides/exc_app/modules/_index_.md
https://www.adobe.io/apis/experienceplatform/project-firefly/docs.html#!AdobeDocs/project-firefly/master/guides/exc_app/modules/page.md
https://www.adobe.io/apis/experienceplatform/project-firefly/docs.html#!AdobeDocs/project-firefly/master/guides/exc_app/modules/topbar.md
https://www.adobe.io/apis/experienceplatform/project-firefly/docs.html#!AdobeDocs/project-firefly/master/guides/exc_app/modules/user.md

@icaraps  and @sarahxxu , maybe re-publishing from github to adobe.io helps?

Redirects fine now. Closing.


chore: cleanup wasm_hook.go

Updated few comments and simplified the code.

The team just updated main to SDK v50, if you want to rebase on that I am happy to approve myself to get in the updated docs


Adding autoSwitch for diff browsers proofer

This enables the automatic switching of fonts (new vs old) every 1.25 secs.
This helps to compare the versions without clicking all the time.
If the user clicks the old/new button, then the switching stops.
Demo:

PS. I couldn't test it compiles the HTML properly, just added the snippets in the template

Love It! merged.

Seems the toggle has been broken for the other pages. I get the following traceback if I open up a page other than proofer.html
Uncaught ReferenceError: autoSwitch is not defined
    at HTMLDivElement.switchFonts (Black-Bold-ExtraBold-Medium-diffbrowsers_waterfall.html:638:25)

Since I like the feature, I don't mind fixing this but it may take me a while to get round to it.

Nice!
I can help with it. How do I build or run tests locally?

I (blindly) added a possible fix, but I cant generate the HTMLs properly
I tried using
python src/diffenator2/__main__.py diff -fb ...
but it seems that I'm getting a cached version, as the generated htmls don't show the changes I am trying


PHP Pear Packages

Support PHP Pear packages in the same way as NPM and PIP packages.

This propably needs a distinction between PHP 5 and 7 in the same way as Python 2 and 3.

It has to be checked, that the PEAR installer does not write into the system directories.

This only makes sense, if thier are PHP packages used as command line tools on the PATH. Otherwise PHP packages are used only in the project context (e.g. with Composer) and Bench does not need to know about them.


Payback Loan

Acceptance Criteria: Verify the user is able to pay back the loan.
Android:

[ ]  Loans > Vault Details > Loans section > PAYBACK LOAN > Edit Amount to pay(should be less than total amount) > Confirm Loan Payment

iOS:

[ ]  Loans > Vault Details > Loans section > PAYBACK LOAN > Edit Amount to pay(should be less than total amount) > Confirm Loan Payment


fix: make run_console_local.sh working on WSLv1

Description of the change:

Updates the if statement which check for WSL.
Quoting of variables to mitigate SC2086
Make sh compatible
Removes -it from docker run, no need to start interactive when redirecting output

Motivation for the change:
The script wasn't working for me in WSlv1 because [[ "$(< /proc/version)" == *"@(Microsoft|WSL)"* ]] never evaluated to true.
Simplified the statement by using uname -r (no need to grep for Microsoft or WSL) and by using grep
The second commit is for making the script sh compatible to support more environments. I couldn't check it on MacOS but according to the internet OSTYPE should be defined.
The for loop is needed since the script is much faster in sh and the if statement to check for running is sometimes run before the container has started.
Reviewer Checklist

[ ] Implementation matches the proposed design, or proposal is updated to match implementation
[ ] Sufficient unit test coverage
[ ] Sufficient end-to-end test coverage
[ ] Docs updated or added to /docs
[ ] Commit messages sensible and descriptive

/ok-to-test

/approve
I'd like to double check that this still works on other systems as well, since we don't have CI for this script.

/retest
/lgtm
verified that it still works on macos!


ECDSA alg Fatal error

Fatal error: Class 'phpseclib\File\ASN1' not found in /home/paceto/proj/sgapi/vendor/namshi/jose/src/Namshi/JOSE/Signer/OpenSSL/ECDSA.php on line 46
ref to old issue:
https://github.com/namshi/jose/issues/55

hi @paceto256 would you mind sending a PR?

to put "phpseclib/phpseclib": "^2.0" in "require" block ?

Not sure what you mean by PR but this is my composer row
"require": {
"namshi/jose": "^7.1"
}
Fixed the issue by adding "phpseclib/phpseclib": "^2.0" to require.
"require": {
    "namshi/jose": "^7.1",
    "phpseclib/phpseclib": "^2.0"
}

It's needed since
Namshi\JOSE\Signer\OpenSSL\ECDSA depends on phpseclib\File\ASN1

yes, I mean a pull request :) We made phpseclib an optional dependency so if you want to use ECDSA signers you should include it separately


Adding a separate page for AI book recommendation generator which would give book recommendations based on the questions asked (Issue #4688)

Related Issue
Adding a separate page for AI book recommendation generator which would give book recommendations based on the questions asked (Issue #4688)
Fixes:  #4688
Description
Adding a separate page for AI book recommendation generator which would give book recommendations based on the questions asked

Type of PR

[ ] Bug fix
[ ] Feature enhancement
[ ] Documentation update
[ ] Other (specify): _______________

Screenshots / videos (if applicable)
https://github.com/user-attachments/assets/c3571aa2-01df-4c22-8a18-c82742a67461
Checklist:

[x] I have made this change from my own.
[x] I have taken help from some online resources.
[x] My code follows the style guidelines of this project.
[x] I have performed a self-review of my own code.
[x] I have commented my code, particularly in hard-to-understand areas.
[x] I have made corresponding changes to the documentation.
[x] My changes generate no new warnings.
[x] I have tested the changes thoroughly before submitting this pull request.
[x] I have provided relevant issue numbers and screenshots after making the changes.

@shriyadindi you didn't get me
i want u to add this feature in recommend page itself and one thing why u r changing entire footer appearance? if u had doubt why don't u tag and ask me

@sailaja-adapa Okay I'll add it in the recommended section.


Accessing network in the sandbox when --sandbox_default_allow_network is set to false

rules_poetry is unable to download packages when --sandbox_default_allow_network is set to false, which is recommended by Aspect in .bazelrc flags you should enable.
INFO: Analyzed target //python/poetry:main (89 packages loaded, 5603 targets configured).
ERROR: /private/var/tmp/_bazel_xxxx/150a9454df6421199e3aca2602f48b4f/external/rules_poetry~~poetry~poetry/BUILD:3:8: Installing package absl-py for Python 3.11 aarch64-apple-darwin failed: (Exit 1): poetry_deps failed: error executing InstallWheel command (from target @@rules_poetry~~poetry~poetry//:absl-py) bazel-out/darwin_arm64-opt-exec-ST-13d3ddad9198/bin/external/rules_poetry~/python/poetry_deps install 'absl-py==2.1.0' ... (remaining 13 arguments skipped)

Use --sandbox_debug to see verbose messages from the sandbox and retain the sandbox build root for debugging
WARNING: Retrying (Retry(total=4, connect=None, read=None, redirect=None, status=None)) after connection broken by 'NewConnectionError('<pip._vendor.urllib3.connection.HTTPSConnection object at 0x10823cbd0>: Failed to establish a new connection: [Errno 1] Operation not permitted')': /pypi/web/simple/absl-py/
WARNING: Retrying (Retry(total=3, connect=None, read=None, redirect=None, status=None)) after connection broken by 'NewConnectionError('<pip._vendor.urllib3.connection.HTTPSConnection object at 0x104135c10>: Failed to establish a new connection: [Errno 1] Operation not permitted')': /pypi/web/simple/absl-py/
WARNING: Retrying (Retry(total=2, connect=None, read=None, redirect=None, status=None)) after connection broken by 'NewConnectionError('<pip._vendor.urllib3.connection.HTTPSConnection object at 0x108990890>: Failed to establish a new connection: [Errno 1] Operation not permitted')': /pypi/web/simple/absl-py/
WARNING: Retrying (Retry(total=1, connect=None, read=None, redirect=None, status=None)) after connection broken by 'NewConnectionError('<pip._vendor.urllib3.connection.HTTPSConnection object at 0x108b98390>: Failed to establish a new connection: [Errno 1] Operation not permitted')': /pypi/web/simple/absl-py/
WARNING: Retrying (Retry(total=0, connect=None, read=None, redirect=None, status=None)) after connection broken by 'NewConnectionError('<pip._vendor.urllib3.connection.HTTPSConnection object at 0x1089fd690>: Failed to establish a new connection: [Errno 1] Operation not permitted')': /pypi/web/simple/absl-py/
ERROR: Could not find a version that satisfies the requirement absl-py==2.1.0 (from versions: none)
ERROR: No matching distribution found for absl-py==2.1.0
ERROR: pip install returned 1

Should I overwrite --sandbox_default_allow_network to true or should rules_poetry avoid downloading packages in the sandbox and instead use Bazel’s builtin downloader to do the work?
@alexeagle

@luangong thanks for reporting! Fixed in v0.3.5


[SPARK-15553][SQL] Dataset.createTempView should use CreateViewCommand

What changes were proposed in this pull request?
Let Dataset.createTempView and Dataset.createOrReplaceTempView use CreateViewCommand, rather than calling SparkSession.createTempView. Besides, this patch also removes SparkSession.createTempView.
How was this patch tested?
Existing tests.

Test build #59376 has started for PR 13327 at commit c331b8f.

Test build #59376 has finished for PR 13327 at commit c331b8f.

This patch fails Spark unit tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/59376/
Test FAILed.

retest this please.

Test build #59377 has started for PR 13327 at commit c331b8f.

Test build #59377 has finished for PR 13327 at commit c331b8f.

This patch fails Spark unit tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/59377/
Test FAILed.

Test build #59385 has started for PR 13327 at commit d5c7461.

Test build #59385 has finished for PR 13327 at commit d5c7461.

This patch fails MiMa tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/59385/
Test FAILed.

Test build #59386 has started for PR 13327 at commit c331b8f.

Test build #59387 has started for PR 13327 at commit 47d11c3.

Test build #59386 has finished for PR 13327 at commit c331b8f.

This patch fails Spark unit tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/59386/
Test FAILed.

Test build #59387 has finished for PR 13327 at commit 47d11c3.

This patch fails Spark unit tests.
This patch merges cleanly.
This patch adds no public classes.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/59387/
Test FAILed.

Merged build finished. Test FAILed.

Test build #59471 has started for PR 13327 at commit e3a13ab.

Test build #59473 has started for PR 13327 at commit d6a94a4.

Test build #59473 has finished for PR 13327 at commit d6a94a4.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/59473/
Test PASSed.

Merged build finished. Test PASSed.

Test build #59471 has finished for PR 13327 at commit e3a13ab.

This patch passes all tests.
This patch does not merge cleanly.
This patch adds no public classes.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/59471/
Test PASSed.

Build finished. Test PASSed.

Given the comments are pretty minor, I'm going to merge this first. I have some minor cleanups and I will include @andrewor14's comment there.


iOS 14, no camera's available.

On iOS14 there seem to be no camera's available, also the canvas or output element seems to get an infinite (or atleast a rediculous) height.
iOS13 works fine.
Tested using your example page on an Iphone 11, 12 (iOS 14), in combination with your example page.

iOS 14 seems to have given some bizarre meaning to the commonly used aspect ratio settings 'min' 1 'max' 100, and screws things up pretty hard.
Also, still only works in Safari, I think, but getUserMedia() is being exported to app context and will be available in alternate browsers and html based iOS apps in a future update? 14.something?

Thanks for the quick response! I indeed had set aspectRatio: {min: 1, max: 100}, and the customer was using an alternative browser.

https://github.com/ericblade/quagga2/issues/283
looks like 14.3 beta contains support for Chrome / apps / alterna-browsers / etc to use getUserMedia!


[bug] startup not dealing with device that timeout?

Version
Build/Run method

[ ] Docker
[ ] PKG
[X] Manually built (git clone - npm install - npm run build )

Zwave2Mqtt version: master @ 20190805
Openzwave Version: 1.6.848
Describe the bug
While trying to trouble shoot #58 more, I noticed the following after swapping to a new controller (Aeotec ZW090):
After including a device, all currently setting seem to be read properly.
After moving the device in this case a Aeotec ZW116 switch, and restarting zwave2mqtt.
Everything worked, but the VerifyChange property did not get applied. I also tried to enable poll. Same effect. I did notice that the node timed out while queuing at the startup and it loadsd date from the cache.
After including a new one of the same type/model, because I wanted to rule out a bad device...
This device got included fine and had the default settings, and I configured the device the same way.
While restarting zwave2mqtt I also wiped the full store folder to start fresh, I then noticed both switches timed out and they did not get required for the current on device config.
I verified this by doing the configuration again and restarting, I think this time it restored the active settings from the ozwcache after the timeout. Wiping the cache confirmed this as they were showing defaults again after a restart. (But the device still had the good config.)
Another node that was in range got the config restore from the device itself again.
I’m thinking this and the not applying things like Poll or VerifyChange might be related.
Some event is probably not triggers or the commands do fire but don’t make it to the device because of the timeout.
To reproduce

configure a device
(add some override like poll/VerifyChange)
move the device where it is sometimes not responding due to our of range or interference
wipe the ozwcache
restart zwave2mqtt
device config is back to default instead of loaded from device
(poll/verifychange are not applied)

Expected behavior
Devices that timeout or are not reachable, to be required once they come back.
Additional context
I’m not a 100% sure on this after going to the logs as they were a bit of a mess, but could this make sense?
If so I will try to break it down and collect some fresh logs this weekend.
Sadly the device have really bad interference in this appartment.

If this makes sense, or seems possible we can probably close #58 until this is resolved.

@sjorge Thanks for the detailed explanation but sincerly I have no idea about this... I never changed the code about verifyChanges so if it was working and now it is not it is most probably related to underlying libs

That seems most likely yeah as only old zwave2mqtt 1.0.3 with old node-openzwave-shared against old openzwave work for enablePoll and verifyChange...

@sjorge In order to fix this you should use requestConfigParams api


Split tasks in different groups.

All the tasks to execute per version of CW are store them in a single ps1 file, to provide more scalability, split all of them in several files and store per group (schemas groups).

The files are splited noe, the structure to follow is:
Set of tasks per version

.tools/tasks//tasks.ps1

Wrapper tasks

.tools/tasks/.ps1

[CmdletBinding()]
param (
    [ValidateSet(
        "1.0.0"
    )]
    [string]
    $Version = $(throw "$($MyInvocation.MyCommand.Name) -> You need to send the version of the script block")
);
Write-VerboseMessage "Selected version[$Version] of $($MyInvocation.MyCommand.Name)";
Write-Output -InputObject @{
    "1.0.0" = {
# ScriptBlock
    };
   "x.x.x" = {};
}[$Version].ToString();


[Web] Multiline TextField selection start does not move

Steps to Reproduce

Create a TextField with multiline enabled (maxLines: null).
Run on the Web.
Try to select the text, then reselect another portion of the text.
Only the end cursor of the selection moves, the start cursor of the selection stays static (unless double-clicking a word).
Sometimes it works fine, sometimes it does not - seems to be a bit random. Running the screen video capture tool on MacOS while selecting the text seems to make it not work most of the time, for some reason.

Expected results:
Same behavior as with a single line TextField.
https://user-images.githubusercontent.com/59314108/192592913-2bf95045-e777-4765-8c90-1844d58f3f7a.mov
Actual results:
Selection is sometimes buggy: the starting point of the selection is not updating correctly.
https://user-images.githubusercontent.com/59314108/192593195-2d7f8254-ea31-4a30-a172-e275be39e6e6.mov

Code sample
import 'package:flutter/material.dart';

void main() {
  runApp(const MyApp());
}

class MyApp extends StatelessWidget {
  const MyApp({super.key});

  @override
  Widget build(BuildContext context) {
    return MaterialApp(
      home: Scaffold(
        body: Container(
          alignment: Alignment.center,
          padding: const EdgeInsets.all(16),
          child: const TextField(
               maxLines: null,
              ),
        ),
      ),
    );
  }
}

Logs
[✓] Flutter (Channel stable, 3.3.2, on macOS 12.6 21G115 darwin-arm, locale en-US)
    • Flutter version 3.3.2 on channel stable at /Users/louisdeveseleer/Development/flutter
    • Upstream repository https://github.com/flutter/flutter.git
    • Framework revision e3c29ec00c (13 days ago), 2022-09-14 08:46:55 -0500
    • Engine revision a4ff2c53d8
    • Dart version 2.18.1
    • DevTools version 2.15.0

[✓] Android toolchain - develop for Android devices (Android SDK version 33.0.0)
    • Android SDK at /Users/louisdeveseleer/Library/Android/sdk
    • Platform android-33, build-tools 33.0.0
    • Java binary at: /Applications/Android Studio.app/Contents/jre/Contents/Home/bin/java
    • Java version OpenJDK Runtime Environment (build 11.0.12+0-b1504.28-7817840)
    • All Android licenses accepted.

[✓] Xcode - develop for iOS and macOS (Xcode 14.0.1)
    • Xcode at /Applications/Xcode.app/Contents/Developer
    • Build 14A400
    • CocoaPods version 1.11.3

[✓] Chrome - develop for the web
    • Chrome at /Applications/Google Chrome.app/Contents/MacOS/Google Chrome

[✓] Android Studio (version 2021.2)
    • Android Studio at /Applications/Android Studio.app/Contents
    • Flutter plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/9212-flutter
    • Dart plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/6351-dart
    • Java version OpenJDK Runtime Environment (build 11.0.12+0-b1504.28-7817840)

[✓] VS Code (version 1.71.2)
    • VS Code at /Applications/Visual Studio Code.app/Contents
    • Flutter extension version 3.48.0

[✓] Connected device (3 available)
    • iPhone 14 Pro Max (mobile) • A96E2EDD-0CD6-404E-95E9-C2C624608DC7 • ios            • com.apple.CoreSimulator.SimRuntime.iOS-16-0 (simulator)
    • macOS (desktop)            • macos                                • darwin-arm64   • macOS 12.6 21G115 darwin-arm
    • Chrome (web)               • chrome                               • web-javascript • Google Chrome 105.0.5195.125

[✓] HTTP Host Availability
    • All required HTTP hosts are available

• No issues found!

Hi @louisdeveseleer, thanks for filing the issue. But I can not reproduce the issue on the latest stable and master channels even after trying several times.

Demo
https://user-images.githubusercontent.com/104349824/192717804-21cedd48-ecf9-4390-a667-278093197477.mov

flutter doctor -v
[✓] Flutter (Channel stable, 3.3.2, on macOS 12.6 21G115 darwin-x64, locale en-VN)
    • Flutter version 3.3.2 on channel stable at /Users/huynq/Documents/GitHub/flutter
    • Upstream repository https://github.com/flutter/flutter.git
    • Framework revision e3c29ec00c (6 days ago), 2022-09-14 08:46:55 -0500
    • Engine revision a4ff2c53d8
    • Dart version 2.18.1
    • DevTools version 2.15.0

[✓] Android toolchain - develop for Android devices (Android SDK version 31.0.0)
    • Android SDK at /Users/huynq/Library/Android/sdk
    • Platform android-33, build-tools 31.0.0
    • ANDROID_HOME = /Users/huynq/Library/Android/sdk
    • Java binary at: /Applications/Android Studio.app/Contents/jre/Contents/Home/bin/java
    • Java version OpenJDK Runtime Environment (build 11.0.12+0-b1504.28-7817840)
    • All Android licenses accepted.

[✓] Xcode - develop for iOS and macOS (Xcode 13.3)
    • Xcode at /Applications/Xcode.app/Contents/Developer
    • Build 13E113
    • CocoaPods version 1.11.3

[✓] Chrome - develop for the web
    • Chrome at /Applications/Google Chrome.app/Contents/MacOS/Google Chrome

[✓] Android Studio (version 2021.2)
    • Android Studio at /Applications/Android Studio.app/Contents
    • Flutter plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/9212-flutter
    • Dart plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/6351-dart
    • Java version OpenJDK Runtime Environment (build 11.0.12+0-b1504.28-7817840)

[✓] IntelliJ IDEA Community Edition (version 2022.1.1)
    • IntelliJ at /Users/huynq/Library/Application Support/JetBrains/Toolbox/apps/IDEA-C/ch-0/221.5591.52/IntelliJ IDEA CE.app
    • Flutter plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/9212-flutter
    • Dart plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/6351-dart

[✓] VS Code (version 1.71.2)
    • VS Code at /Applications/Visual Studio Code.app/Contents
    • Flutter extension version 3.48.0

[✓] Connected device (2 available)
    • macOS (desktop) • macos  • darwin-x64     • macOS 12.6 21G115 darwin-x64
    • Chrome (web)    • chrome • web-javascript • Google Chrome 105.0.5195.125

[✓] HTTP Host Availability
    • All required HTTP hosts are available

• No issues found!

[✓] Flutter (Channel master, 3.4.0-33.0.pre.32, on macOS 12.6 21G115 darwin-x64, locale en-VN)
    • Flutter version 3.4.0-33.0.pre.32 on channel master at /Users/huynq/Documents/GitHub/flutter_master
    • Upstream repository https://github.com/flutter/flutter.git
    • Framework revision 7ce121fed9 (89 minutes ago), 2022-09-27 21:40:12 -0400
    • Engine revision 46009cbe3d
    • Dart version 2.19.0 (build 2.19.0-247.0.dev)
    • DevTools version 2.17.0

[✓] Android toolchain - develop for Android devices (Android SDK version 31.0.0)
    • Android SDK at /Users/huynq/Library/Android/sdk
    • Platform android-33, build-tools 31.0.0
    • ANDROID_HOME = /Users/huynq/Library/Android/sdk
    • Java binary at: /Applications/Android Studio.app/Contents/jre/Contents/Home/bin/java
    • Java version OpenJDK Runtime Environment (build 11.0.12+0-b1504.28-7817840)
    • All Android licenses accepted.

[✓] Xcode - develop for iOS and macOS (Xcode 14.0)
    • Xcode at /Applications/Xcode.app/Contents/Developer
    • Build 14A309
    • CocoaPods version 1.11.3

[✓] Chrome - develop for the web
    • Chrome at /Applications/Google Chrome.app/Contents/MacOS/Google Chrome

[✓] Android Studio (version 2021.2)
    • Android Studio at /Applications/Android Studio.app/Contents
    • Flutter plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/9212-flutter
    • Dart plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/6351-dart
    • Java version OpenJDK Runtime Environment (build 11.0.12+0-b1504.28-7817840)

[✓] IntelliJ IDEA Community Edition (version 2022.1.1)
    • IntelliJ at /Users/huynq/Library/Application Support/JetBrains/Toolbox/apps/IDEA-C/ch-0/221.5591.52/IntelliJ IDEA CE.app
    • Flutter plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/9212-flutter
    • Dart plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/6351-dart

[✓] VS Code (version 1.71.2)
    • VS Code at /Applications/Visual Studio Code.app/Contents
    • Flutter extension version 3.48.0

[✓] Connected device (3 available)
    • SM T225 (mobile) • R9JT3004VRJ • android-arm64  • Android 12 (API 31)
    • macOS (desktop)  • macos       • darwin-x64     • macOS 12.6 21G115 darwin-x64
    • Chrome (web)     • chrome      • web-javascript • Google Chrome 105.0.5195.125

[✓] HTTP Host Availability
    • All required HTTP hosts are available

• No issues found!

Did you select the text by trackpad or mouse? Could retry on another website that contains a multiline TextField (maybe in this Github's comment editor)? This is to check if the peripheral device is working properly (sorry if that's incorrect).
Also, could you please retry with HTML renderer? It will be great if you can try on master channel too. Thanks!

Hey thanks for your answer.

Selection was done using a mouse. I get the same result with the trackpad. The issue was noted also by our users, which was the initial trigger for us to look into this.
No issue at all with the Github's comment editor.
I am getting exactly the same buggy behavior with flutter run -d chrome --web-renderer html as with flutter run -d chrome --web-renderer canvaskit
Same result again with the master channel as with the stable

Have you tried doing the text selection while having the MacOS native screen video capture recording? It's the best way to make it not work for me, although it also happens sometimes without it.

@louisdeveseleer

Have you tried doing the text selection while having the MacOS native screen video capture recording?

Yes, I did it with the above demo video (use QuickTime Player)
My colleagues tried to reproduce this issue and had the same behavior as you described on his Mac M1 (while I'm using a Mac Intel chip). And there is no special log from the console.

Demo (Mac M1)
https://user-images.githubusercontent.com/104349824/192994051-5810d9ab-554e-4359-9142-25cceed51428.mov

Labeling this issue for further investigation from the team! Thank you!

Yes I also have a Mac M1! Thanks for your help.

I wasn't able to reproduce this issue on my M1 Macbook Pro. Unfortunately, there isn't much I can do without a repro.
From the videos in this issue, it looks like the text field is behaving as if the Shift is key is pressed. I'm not sure why that would be the case.
For those who were able to reproduce it, could you try running the app as a macOS native app instead of web? Do you see the same issue?

@mdebbar I am away with no access to my computer until Tuesday, I'll test what you suggested then and let you know.

@mdebbar  The issue does not appear on macOS for me, only on Web.
It is indeed similar to what happens when the Shift key is pressed.
Have you tried running the mac screen recording (Shift-Command-5) while selecting the text?

While investigating further, I found that this issue is also reproducible on desktop (Mac and Linux on my side).
Steps to reproduce

Run the provided code sample.
Enter some text and select a portion of it.
Press and hold down the right shift key.
While holding the shift key, click on another window (the Flutter window will lose the focus).
Release the shift key (while being outside the Flutter window).
Click somewhere on the text: the selection will be updated as if the shift key is still pressed.

(FYI, I have updated title and main description to expose those findings).

@bleroux Thank you. I think option 2 is the best. In fact, I noted it in https://github.com/flutter/flutter/issues/99330 (which apparently hasn't been done yet.) The biggest part of this change would be to figure out how to listen to window focusing/unfocusing, which isn't a mechanism of the current flutter engine. In fact, IIRC focusing/unfocusing callback is part of the "desktop lifecycle" project. We'd very happy if you can help us with it. (cc @cbracken Do we have a issue for it?)
Option 1 is also what we eventually would like to do, but I don't think it solves this problem in a pretty way. It will require fetching that information for every pointer down.

@dkwingsmt Many thanks for your insights and especially for pointing out https://github.com/flutter/flutter/issues/99330 :+1:
While analyzing this deeper, I would like to have your opinion on solution 3 because:

Modifier keys states are directly available for mouse events on the 4 targeted platforms where this issue is reproducible (Linux, Mac, Windows, Web, see 'reference 1' links below).
There are use cases where keyboard modifier keys states are interesting without the window gaining focus. For instance, with any Chrome windows (using the mouse wheel on an unfocused Chrome window scrolls the content. If the shift key is pressed, using the mouse wheel on an unfocused window will zoom in/zoom out).
With multi-window support in work, there are probably new use cases where passing the modifier keys states with mouse events will be interesting.
Flutter PointerEvent was designed when mobile platforms were the only supported platforms. Now that desktop and web are supported it makes sense to align Flutter mouse events to what is done in many desktop and web UI toolkits (see 'reference 2' below).
Adding one (or more) optional parameter to PointerEvent won’t be a breaking change (as I feared in my previous comment).
Solution 2 (listening to window focusing/unfocusing) will be an interesting addition to the framework. But, it will probably rely on the native mouse event to get the modifiers keys state (so on the engine side, it will be solution 3 + more work to try to get it right on each platform + probably less accuracy than solution 3).

Reference 1: supported platforms mouse events field to get modifiers state:

MacOS: https://developer.apple.com/documentation/appkit/nsevent/modifierflags - https://developer.apple.com/documentation/appkit/nsevent/1532495-mouseevent
GTK: https://api.gtkd.org/gdk.c.types.GdkEventButton.state.html
Win32: https://learn.microsoft.com/fr-fr/windows/win32/inputdev/wm-lbuttondown?redirectedfrom=MSDN (MK_SHIFT, MK_CONTROL, etc).
Web: https://developer.mozilla.org/en-US/docs/Web/API/MouseEvent/shiftKey

Reference 2: mouse event modifiers state field for some UI Toolkits:

Swing/AWT: https://docs.oracle.com/javase/7/docs/api/java/awt/event/InputEvent.html#SHIFT_DOWN_MASK
SWT: https://download.eclipse.org/rt/rap/doc/2.0/guide/reference/api/org/eclipse/swt/events/MouseEvent.html#stateMask
Qt: https://doc.qt.io/qt-6/qmouseevent.html#QMouseEvent-4 - https://doc.qt.io/qt-6/qt.html#KeyboardModifier-enum

@bleroux thanks for helping with this issue!
@dkwingsmt On the web, listening to window focus/unfocus is easy. But getting keyboard state at a random point in time isn't possible. So options 1 and 2 are out for web.
Option 3 is actually how the web works. MouseEvent (and TouchEvent) contain properties (and methods) to determine the current state of modifier keys (e.g. getModifierState, ctrlKey).
@bleroux

but that sounds like a huge breaking change and it mixes different concerns

Breaking change: We can make the keyboard state information optional in pointer events.
Mixes different concerns: I don't think so. Both keyboard and mouse are input devices, they are the same concern. And they are used in combination to perform certain actions (e.g. cmd+click). So at some point, Flutter will have to support such shortcuts too.

@bleroux great analysis! Thanks for putting it together. I agree with everything you said.

@bleroux Thanks so much for you research, analysis and writeup, and @mdebbar for your insight! I think it's a good idea.
Although first, I'm very hesitant on adding keyboard states to PointerEvent because:

The extent that key states are available vary from platform to platform (e.g. Win32 only supports Ctrl and Shift).
It's confusing to have keyboard states on pointer event.
PointerEvent already have way too many properties.

That being said, I suggest synchronizing key states from pointer events on the engine side.

When the engine receives a pointer event, extract its keyboard state, and send it to the keyboard manager.
The keyboard manager synchronizes with the states, dispatch synthesized events as needed.
If this procedure is done synchronously, the synthesized key events will arrive at the framework before the pointer events, thus correctly affecting the next pointer event.

Notes:

This works the best for the hardware keyboard system.
If we really want to support the (to be deprecated) raw keyboard system, the raw keyboard manager can add the key state to the raw key data JSON payload, and process synchronization on the framework side.

@dkwingsmt Great! I will start to work on this. I will first target only one platform (Web) with a WIP PR, this way we have a foundation for further discussions. I need to dig into the code to understand the full implications (especially "The keyboard manager synchronizes with the states").
I would be happy to work on #87391 too. If it’s ok for you, I will work on it after making progress here.

Sure! Thank you so much for volunteering. Feel free to find me on discord for questions.


Added passing data from context in monolog breadcrumb handler

This simple change is very useful for breadcrumbs when using monolog. My app uses Monolog via Laravel and I think others will want this behavior too.
Before:

After:

This is a very good catch! Can you add tests for this change?

Thanks, glad you like it. I've been working with the breadcrumbs and it's a very powerful feature.
Does this test seem good? I tested on my computer and made it similar to the other one with the added context assertion.

Nope, it's good, let's merge!

@Jean85 For my info, what is the release process for new tagged releases? Then I know if I can wait or need to use my own fork on production.

I suggest you to use this fork, since it's the only difference from the last tagged version and I can't guarantee when the next tag will be done.

I see 18 changes? https://github.com/getsentry/sentry-php/compare/1.9.2...master

Oh sorry, I was mixing up with the Symfony integration that I just released. In this case I think that we can ask @stayallive that did the last 2 or 3 tags.

Thanks guys !! 💪