Replaced Soomla prefabs with CodeGeneratedSingleton

Introduced Round Robin's "UnitySingleton", thus making the different Soomla prefabs redundant

@LeshM, how is it supposed to work for developers?
Should they just skip the step: "Drag the "StoreEvents" and "CoreEvents" Prefabs from Assets/Soomla/Prefabs into your scene."?
I have the errors:
Assets/Plugins/Soomla/Core/Singletons/UnitySingleton.cs(55,47): error CS1061: Type `UnityEngine.Object' does not contain a definition for `GetComponent' and no extension method `GetComponent' of type `UnityEngine.Object' could be found (are you missing a using directive or an assembly reference?)
Assets/Plugins/Soomla/Core/Singletons/UnitySingleton.cs(59,51): error CS1061: Type `UnityEngine.Object' does not contain a definition for `AddComponent' and no extension method `AddComponent' of type `UnityEngine.Object' could be found (are you missing a using directive or an assembly reference?)

But I'm on Unity3d v4.6. Is it supported? Maybe I do something wrong?

@vedi did you import "GameObject" ?

I'll check it out again on Unity 4.6 and the new 5.2 to make sure it works on all versions.

Sorry, my bad.
All fixed and ready to pull :)


Partial actions

Note: work in progress, depends on both #353 and #356, which should be merged first.

At feature parity with outdated #341.


chore: update readme for easier running of models

Updated the README so that users don't have to constantly use cargo run -- every time they use the binary.

Hm, I think the preferable solution for this is to cargo install it so that it's available in your PATH?
We're planning on getting this into crates.io, so all you'll need to do is cargo install llama-cli and then you'll be able to do llama-cli ....

Good point, how about changing it to cargo install --path for now?


pre-defined facilities for all location models?

It looks like the functionality to stipulate pre-defined facilities never made it into the PCenter or PMedian classes. I had sworn we got that in, but it must have been my oversight.

TypeError: PMedian.from_geodataframe() got an unexpected keyword argument 'predefined_facility_col'


Add more dict benches

Adds two more benchmark programs:

dict_insert: Inserts a lot of distinct values on a dictionary
dict_snapshot: Takes a snapshot of a filled dictionary a lot of times

Refactor the benches.rs to make it easier to add new benches, by calling the compare function.

Checklist

[ ] Linked to Github Issue
[ ] Unit tests added
[ ] Integration tests added.
[ ] This change requires new documentation.

[ ] Documentation has been added/updated.

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 80.66%. Comparing base (4bd59e9) to head (8c7c107).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #977   +/-   ##
=======================================
  Coverage   80.66%   80.66%
=======================================
  Files         107      107
  Lines       29325    29325
=======================================
  Hits        23656    23656
  Misses       5669     5669

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


test(cli): add test for get-imported-auth-properties extensions

Description of changes

Increase test coverage of amplify-cli/extensions.
Description of how you validated changes
lerna --scope @aws-amplify/cli run test
Checklist

[x] PR description included
[x] yarn test passes
[x] Tests are changed or added
[x] Relevant documentation is changed or added (and PR referenced)

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Codecov Report

Merging #7187 (f8cc894) into master (70a980f) will increase coverage by 0.03%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #7187      +/-   ##
==========================================
+ Coverage   51.78%   51.82%   +0.03%
==========================================
  Files         486      487       +1
  Lines       25060    25077      +17
  Branches     4916     4921       +5
==========================================
+ Hits        12978    12995      +17
  Misses      11131    11131
  Partials      951      951

Impacted Files
Coverage Δ

...ns/amplify-helpers/get-imported-auth-properties.ts
100.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 70a980f...f8cc894. Read the comment docs.


Added coverage annotation files

Coverage creates annotation files by appending ",cover" (with a comma, not a period) to the filename. These should be ignored.

Thanks, is there some documentation or at least examples?

Running on OS X 10.10, Python 3.4.2, coverage 3.7.1, in a fresh virtualenv:
(.env)$ ls
hello.py
(.env)$ cat hello.py
print("Hello, World!")
(.env)$ coverage run hello.py
Hello, World!
(.env)$ coverage annotate
(.env)$ ls
hello.py       hello.py,cover
(.env)$ cat hello.py,cover
> print("Hello, World!")

Thanks for the example. In this case, shouldn't the rule be *,cover?

Right you are. Fixed.

Thanks!


Upgrade hive-service-rpc 3.1.3

Code of Conduct

[X] I agree to follow this project's Code of Conduct

Search before asking

[X] I have searched in the issues and found no similar issues.

What would you like to be improved?
Upgrade hive-service-rpc 3.1.3
How should we improve?
No response
Are you willing to submit PR?

[ ] Yes I am willing to submit a PR!

I would like to take it, please assign this to me.


Chrome for Android is up to version 57

Caniuse.com shows 56 as the current version.

+1, Android browser/WebView most likely as well (see https://play.google.com/store/apps/details?id=com.google.android.webview in the actual play store app to view the version number).

Done! Looks like the WebView is at 56 now, will get to it shortly.


close-thick not implemented

hello,
I don't know how do you work for updates but I was looking for close-thick icon and I couldn't find it in the package.
Cheers,

This icon is not yet released in the mdi/svg package and will be included in the next release.


PHP Developer Experience Survey

differences from upstream spec:

discrepancies - why?
extra convenience

most requested features

API
SDK
Instrumentations/semantic conventions

things to consider from other telemetry projects

@brettmc brought up a couple of interesting points in the extra convenience that we currently have for PHP:

"local root span" access (not in spec, but concept borrowed from Java)
invented some env vars to control a few core things: batch/simple processor, select resource detectors
we generate metrics from our batch span/log processors. I believe Java does also, but I don't think we are consistent in the metric names
we implement a Transport concept, which abstracts the sending of telemetry data from the exporters (and the same transport, eg "http", can be used by multiple exporters (eg otlp and zipkin)

Also, for the most requested features, he pointed the following:

SDK

async exporting
a way to auto-close "dangling spans"

Instrumentations/semantic conventions

the moratorium on SemConv is really painful. A lot of our -contrib CI is red because packages are using since-deprecated semconvs, and we have a few user issues complaining about this

Adding more context from Brett:

Local root span: yes that's right. It's something like global access to the root-most span in the current context. We'd use it for things like updating the name of the root span after creation, or adding extra attributes. Related: https://github.com/open-telemetry/opentelemetry-specification/issues/2109

Transport: in otel PHP, Transport is an interface that exporters (zipkin and otlp) require. We have a couple of implementations: GrpcTransport, HttpTransport, StreamTransport. By abstracting the exporter from the transport, we can:

use the same transport for traces/metrics/logs
switch transports for an exporter to, for example, export otlp via grpc, http or to file.
Async export: this is just a PHP-specific issue. Since our batch processors are not async, they only export the next time a span ends after the configured delay has passed. In a quiet system, that could be some time.

After discussing during Wed, 23 Oct SIG EU meeting, we agreed that only the local root span would make sense to be discussed in this SIG.
The Transport and Async export cases are more like implementation choices


Removed additional ctor for Fields extendingUtcDateOnlyField, added a…

This is to address https://github.com/quickfix-j/quickfixj-orchestra/issues/5

@chrjohn This is to address the issue with Fields extending UTCDateOnly, if you can release this change and publish to mvn central then I can release corresponding change in the QFJ branch, thanks Dave

Closing and reopening to trigger workflows (they were disabled due to inactivity for 60 days :-/)


feat: adding edit this page buttons

Type of feature
🍕 Feature
Current behavior
There’s no editing buttons.
Suggested solution
I think we should add one. To stay consistent with the other repos.

Additional context
No response
Code of Conduct

[X] I agree to follow this project's Code of Conduct

Contributing Docs

[X] I agree to follow this project's Contribution Docs

@open-sauced/triage, what do you think?

@CBID2 what do you mean? I can see the edit button in the docs :thinking:

@CBID2 what do you mean? I can see the edit button in the docs :thinking:

Ooh that was meant for the intro course repo 🤦🏾♀

@CBID2 what do you mean? I can see the edit button in the docs :thinking:

Is there a way you can transfer this issue to that repo @takanome-dev?

Is there a way you can transfer this issue to that repo @takanome-dev?

Nope, maybe @bdougie or @BekahHW can do it

@CBID2 the docs repo has it because we're using docsify. Because the intro course is just markdown, we'd have to hack it together as a link.

@CBID2 the docs repo has it because we're using docsify. Because the intro course is just markdown, we'd have to hack it together as a link.

Ooh ok @BekahHW.

Hi @BekahHW! :) I was going to do a PR for this.

@CBID2 can you recreate the issue on the intro repository?

@CBID2 can you recreate the issue on the intro repository?

Hey @BekahHW. I think you can transfer it to that repository by clicking on Transfer issue

I can't from the mobile app, so it'll have to wait until I have my computer on.


OAK-11085: Constant MAX_SEGMENT_SIZE is duplicated in Segment/SegmentDataUtils

Closes OAK-11085

Is there an OAK Jira ticket for this change?

Is there an OAK Jira ticket for this change?

Yes, see link in description of this PR.


Update to listpeerchannels

Renamed the type Channels to ChannelsDomain since it has extra fields added.  ChannelsDto is the response from the network.  This was done so it is clear what comes from the network and what is calculated, and to map fields from listpeerchannels into the previous Channel domain model.  Removed some fields that are not used and not available in listpeerchannels: direction, max_htlc_value_in_flight_msat, htlc_minimum_msat, last_tx_fee_msat.  Other fields were duplicates such as spendable_msatoshi and deleted since spendable_msat exists in listpeerchannels as well as in the original Channels object.
use-http sendRequestToStore is now able to handle multiple rpc methods and it bundles the responses together.  This allows for sending 2+ rpc calls to 1 state, such as for the new channels AppContextType.
Removed the controllers/lightning.ts behavior of checking if listpeers was called and adding node.alias to the response.  This was so that the domain layer would handle setting domain data.
channels was added as an AppContextType.  It combines listpeerchannels and listnodes so that the node aliases can be set to the channels.
Added comment to isCompatibleVersion to explain what it does.
Added Channels component tests.  Update mock store to use channels instead of listChannels.

Note: channel opening doesn't work, I think it is beyond the scope of this pr so i'll add an issue for it.

@evansmj Thank you for finding the bug, creating the PR and writing testcases :)
Please note that I added some more commits after reviewing the PR. I left your commit as is, in case you would prefer to compare the changes. Also, the code is working for all CLN versions from 0.12.0 (starting of builtin commando plugin) till 24.02.
Most of the changes are just due to following our naming convention. We are using list prefix for all other data arrays , like listPeers, listTransactions, etc., so I decided to change channels to listChannels too.

Renamed the type Channels to ChannelsDomain since it has extra fields added. ChannelsDto is the response from the network. This was done so it is clear what comes from the network and what is calculated, and to map fields from listpeerchannels into the previous Channel domain model. Removed some fields that are not used and not available in listpeerchannels: direction, max_htlc_value_in_flight_msat, htlc_minimum_msat, last_tx_fee_msat. Other fields were duplicates such as spendable_msatoshi and deleted since spendable_msat exists in listpeerchannels as well as in the original Channels object.

There were only two useful fields in the older versions, id and connected. So I only mapped them with peer_id (for node_alias) and peer_connected (for current_state) fields from the current Channel type and ignored all other fields. It will be helpful in future once we decide to remove the older versions support.
Also removed the check for peerChannel.channel_id == null || peerChannel.short_channel_id == null in aggregation function. Pending channels were always empty due to this check as pending channels do not have short_channel_id.

use-http sendRequestToStore is now able to handle multiple rpc methods and it bundles the responses together. This allows for sending 2+ rpc calls to 1 state, such as for the new channels AppContextType.
channels was added as an AppContextType. It combines listpeerchannels and listnodes so that the node aliases can be set to the channels.

Good optimisation idea. Thanks.

Added comment to isCompatibleVersion to explain what it does.

Thanks, that makes it easier to use :)

Added Channels component tests. Update mock store to use channels instead of listChannels.

Thanks for testcases, just changed channels to listChannels.

Note: channel opening doesn't work, I think it is beyond the scope of this pr so i'll add an issue for it.

I tested channels opening and it is working as expected for me with older versions too.
Finally, fixed some tiny annoying bugs, I found while testing:

Transaction amount was always zero for bitcoin transactions list in v22.11 and older versions.
Timeout error for channel open and other requests was not showing correctly in the UI.
Active channels on Overview component were not updated without page refresh. Now they are also updating as soon as the listChannels updates.

@ShahanaFarooqui Your changes make sense to me, thanks


What happened to the include paths?

I can't see the include path in the installed library listing - what happened to it?
https://godbolt.org/admin/libraries.html
... oh, it seems now we don't need to manually add the include path, just use the "Libraries" button. But - the Wiki should be updated to explain this, I think.

 We should improve the documentation, and also how we express the fact that the include paths are handled automatically.

Sorry that we dropped the ball here and went silent for so long. I have now improved the wording a bit on the wiki. I'll close the issue even though we currently don't show where the libraries are currently hosted to be able to manually include them, but this is less of an issue as time goes on and the new dropdown catches on
Thanks again for the report and for your patience :)


Not seeing TOMORROW's data ?!

Any idea what could go wrong, as I'm not seeing tomorrow's data. I'm pretty sure it once was available. Can't really say what changed.
Data source is smartenergy.at

And this is the apex card's code (basically from the docs with some slight changes):
type: custom:apexcharts-card
experimental:
  color_threshold: true
header:
  show: true
  title: ct/kWh
graph_span: 32h
apex_config:
  legend:
    show: false
span:
  start: day
now:
  show: true
  label: Now
yaxis:
  - min: -15
    max: 40
    decimals: 0
    apex_config:
      tickAmount: 4
series:
  - entity: sensor.epex_spot_data_net_price
    name: Strompreis ct/kWh
    type: line
    show:
      extremas: true
    unit: ct/kWh
    data_generator: >
      return entity.attributes.data.map((entry, index) => { return [new
      Date(entry.start_time).getTime(), entry.price_ct_per_kwh]; });
    color_threshold:
      - value: 40
        color: '#ff0000'
      - value: 30
        color: '#facb23'
      - value: 20
        color: '#ffff00'
      - value: 0
        color: '#00ff00'
  - entity: sensor.epex_spot_data_price
    name: Strompreis ct/kWh
    type: column
    extend_to: end
    show:
      extremas: true
    unit: ct/kWh
    data_generator: >
      return entity.attributes.data.map((entry, index) => { return [new
      Date(entry.start_time).getTime(), entry.price_ct_per_kwh]; });
    color_threshold:
      - value: 20
        color: '#ff0000'
      - value: 15
        color: '#facb23'
      - value: 8
        color: '#ffff00'
      - value: 0
        color: '#00ff00'

The GB feed also not working, I suspect it's to do with EPEX recent downtime and they came back up with a slightly different URL

After deactivation EPXSpot integration (DE) cannot be reactivated. Eroor message says:

Same 403 for NL market.

Did you already update to the latest release 2.3.8?

Thanks. I just updated from 2.3.2 -> 2.3.8, and everything works again. Sorry for the confusion.

I use release 2.3.8 and can confirm that next day data from smartenergy.at is not available, but Awattar (at) is.

(Second chart is smartenergy, third is Awattar)

Yep. Still the same here. No data with smartenergy for tomorrow. :(

The Tibber source also doesn't show tomorrow's values.

I've been using the Austrian data for some time now; Awattar seems to be the most reliable. SmartEnergy API has had outages several times now. From my point of view, it's clearly a problem with the data source, so this plugin cannot do anything about it.

This issue contains reports from multiple sources now. Typically problems with missing data are caused by outages in the service provider APIs. Therefore I will close this issue.
If there are new problems, please open a provider specific issue.


Redo shortcut not working

When writing code in the Eve editor, the undo shortcut (Cmd + Z) works as expected but the redo shortcut (Cmd + Shift + Z) does not. Tested on MacOS in Chrome and Safari.
On more than one occasion I've lost bits of code by accidentally undoing too much.

I was able to reproduce on Chrome and Safari on MacOS X.


Can I generate deep links to website tabs? (in MSTeams)

If I use graph api I can add a website tab to a team: https://docs.microsoft.com/en-us/graph/teams-configuring-builtin-tabs
Can I create deep links and send them in the channel in a card for the user to navigate to a website tab? (not a custom tab type)

Hi @liangchr,  yes, you can create deeplink to a tab and can navigate to it on click of button posted in a channel. Please refer to the docs.

Hi @liangchr,  yes, you can create deeplink to a tab and can navigate to it on click of button posted in a channel. Please refer to the docs.

@Mallipriya-MSFT I need to clarify something. Do website tabs even have entityId's to add to the deep link url to begin with? Not referring to custom tabs, but website tab types.

@Mallipriya-MSFT I need to clarify something. Do website tabs even have entityId's to add to the deep link url to begin with? Not referring to custom tabs, but website tab types.

@liangchr, Can you help me to understand what does a website tab mean? If it is an content Url of an website, then it should be an IFrame-able one to integrate it as a tab and have to make sure that website url domain has to added in the valid domains array of the manifest. While adding a tab, it is mandatory to provide Entity ID, using which you can deeplink.

@liangchr, Can you help me to understand what does a website tab mean? If it is an content Url of an website, then it should be an IFrame-able one to integrate it as a tab and have to make sure that website url domain has to added in the valid domains array of the manifest. While adding a tab, it is mandatory to provide Entity ID, using which you can deeplink.

@Mallipriya-MSFT
Website tab is explained here: https://docs.microsoft.com/en-us/graph/teams-configuring-builtin-tabs#website-tabs
In other words, it is this thing:

I want to be able to deep link to this

@Mallipriya-MSFT
Website tab is explained here: https://docs.microsoft.com/en-us/graph/teams-configuring-builtin-tabs#website-tabs
In other words, it is this thing:

I want to be able to deep link to this

Hi @liangchr,
Yes, you can create the deeplink to website using the content URL and website URL. Could you please check these docs.

@liangchr , Please feel free to reopen this issue if you have further query on this.


NIM storage size field update

https://issues.redhat.com/browse/RHOAIENG-14037
Description

Added another line of helper text and removed 'Mi' option.
How Has This Been Tested?

Tested locally.
Test Impact

Tested to make sure 'Mi' does not show up as an option for NIM.
Request review criteria:

Self checklist (all need to be checked):

[x] The developer has manually tested the changes and verified that the changes work
[x] Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
[x] The developer has added tests or explained why testing cannot be added (unit or cypress tests for related changes)

If you have UI changes:

[ ] Included any necessary screenshots or gifs if it was a UI change.
[ ] Included tags to the UX team if it was a UI/UX change.

After the PR is posted & before it merges:

[ ] The developer has tested their solution on a cluster by using the image produced by the PR to main

/ok-to-test


[SMALLFIX] Clean up the remaining pom code about ufs contract test

the ufs contract test is moved from test scope to ./bin/alluxio runUfsTests. The UfsContractTest profile is not needed any more

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Alluxio-Pull-Request-Builder/4074/
Test PASSed.

alluxio-bot, merge this please.

alluxio-bot, cherry-pick this to branch-2.0 please.


Not sure how to translate data given

Was able to successfully pull info into csv file and open in excel. My issue is I really am not sure how to read the data values given. I've looked everywhere and it all just looks like random decimals and huge numbers. Thanks!

Hi @WavySealWaterGod, thanks for getting in touch! Apologies for the delay, and that my first response is less informative than what you might be looking for. I'm unsure what exactly you're asking about, so could you help me understand that?
Is the problem that you don't know what the various columns are in your spreadsheet? If so, then the list of parameters also contains a short description of what each is. The description is largely similar to that of the format specification, but doesn't include what type of number it is (integer or floating point). It also doesn't always describe what the range of values is, in many cases that'll depend on the car.
Or maybe there's a different problem you're having? Let me know and I'll see what I can do about helping you out.


Add etsy support

I added in this PR the support to login in etsy and user there api for creating etsy app with oauth2

I think you messed up the merge?

I did the changes for 1.9.2 and in the mean time you punished V2 :-).
I adjusted the code and create a new PR

Thanks!


Error on containerd startup

I'm not sure if the error is a serious problem or not. I was able to launch an nginx pod. The error certainly reads fairly serious.
All I did was run  sudo /home/james/bin/k3s server on Ubuntu 18.10
james@growth:~$ k3s -v
k3s version dev (HEAD)

INFO[2019-02-27T14:13:26.181414671-08:00] Running containerd -c /var/lib/rancher/k3s/agent/etc/containerd/config.toml -a /run/k3s/containerd/containerd.sock --state /run/k3s/containerd --root /var/lib/rancher/k3s/agent/containerd
INFO[2019-02-27T14:13:26.181503121-08:00] Waiting for containerd startup: rpc error: code = Unavailable desc = all SubConns are in TransientFailure, latest connection error: connection error: desc = "transport: Error while dialing dial unix /run/k3s/containerd/containerd.sock: connect: no such file or directory"

I have the same problem with the installer:
curl -sfL https://get.k3s.io | sh -

This is the duplicate of #60.

Same problem here except containerd.sock is missing

This is the duplicate of #60.

And https://github.com/rancher/k3s/issues/138, https://github.com/rancher/k3s/issues/210, https://github.com/rancher/k3s/issues/271

tested with other versions (v4.4.0 and v3.4.0), same problem happened. It always stopped at second server node.


Possibility of adding Rspamd option

Could be useful to include an option that would install Rspamd rather than the original spamassassin and postgrey combo.
Rspamd could be of interest to some as it also provides a web interface for statistics and configuring and claims to be lighter.

I think it has been discussed in the mail-in-a-box forums before, however I don't think the discussion went anywhere.
I've tried it before using the original mail-in-a-box software and I would say it worked flawlessly, just by changing the postfix config and stopping postgrey and spamassassin.
But I have to agree with you, it would cause ugly merge conflicts.


repo: add jboss EAP repos for RHEL 7, 8, and 9

Adding new repos for building EAP images for all major RHEL versions.
See this comment on the relevant ticket for the source of the URLs.

Since you are syncing the 7.4 directory, should this be jbeap7.4? Or maybe let's sync the 7 directory and name it jbeap7?
Just so we don't have any conflicts in the future...

Good call.  The linked ticket calls for 7.4.x, but all the linked CLOUDX tickets say 7.x.  I went for switching the URL to syncing plain 7 (latest) and renamed the snaphot ID (and files) to jbeap7.


[4.2.x] Fixed #35022 -- RenameIndex crashed when index and unique together existed on the same fields.

ticket-35022
4.2.x port of https://github.com/django/django/pull/17632

@David-Wobrock Thanks for patches, however Django 4.2 is in extended support so this no longer qualify for a backport. Please open PR only against the main branch.

Thanks for the info! @felixxm  :)
The problem is that there is nothing to fix on main, since index_together was deprecated there.
I guess the patch only qualifies for 5.0 then.


Deleting order before addons then cannot delete addons

If I create an order which has addons and I delete the order before deleting the addons first, the order gets deleted but the addons remain and the dashboard still shows the addons as orders and they cannot be accessed to delete them.

Update committed to demo version.
Now when you remove order which has addons, addons gets detached from order and becomes single orders. Which you can control as usual - delete, suspend ...

Is this fix in the 2.2.6 release or do I wait for next release?

Follow us on Facebook. We will let you know when new version is released. We will also include change log for the release.


Fixed missing callings of fclose() in the unit tests

I've noticed that the test with Valgrind emits warnings about possible memory leaks.
Although it's turned out missing callings of the std::fclose() function in the unit tests for encode detector is the cause and that doesn't affect the fkYAML library itself, it should be better to fix them.
No other fixes are included in this PR.

Pull Request Checklist
Read the CONTRIBUTING.md file for detailed information.

[x] Changes are described in the pull request or in a referenced issue.
[x] The test suite compiles and runs without any error.
[x] The code coverage on your branch is 100%.
[x] The documentation is updated if you added/changed a feature.

Please don't

The C++11 support varies between different compilers and versions. Please note the list of supported compilers. Some compilers like GCC 4.7 (and earlier), Clang 3.3 (and earlier), or Microsoft Visual Studio 13.0 and earlier are known not to work due to missing or incomplete C++11 support. Please refrain from proposing changes that work around these compiler's limitations with #ifdefs or other means.
Please refrain from proposing changes that would break YAML specifications. If you propose a conformant extension of YAML to be supported by the library, please motivate this extension.
Please do not open pull requests that address multiple issues.

coverage: 100.0%. remained the same
when pulling 719a553d4d4f2a773336a3c24a8599c1a76ffbcd on bugfix/fix_valgrind_memory_leaks_warnings
into e98d1d0fee114c76a998f5f1191bd9f6997bfc95 on develop.


Switch CHANGELOG to markdown

We have now switched our README to markdown, so we might as well do the same for the CHANGELOG. It will be easier to work with and will be the same format as the release notes.

As far as I can tell this has been done. Closing.


JSON Decode error while service was unavailable

Bit of an edge case and realise this is probably only temporary package but while the SOAR was down for maintenance got a json decode error -
result = Fido.search(Time('2021-01-01', '2021-01-15') & Instrument('EUI'))
---------------------------------------------------------------------------
JSONDecodeError                           Traceback (most recent call last)
<ipython-input-8-1b961ccfb6a9> in <module>
----> 1 result = Fido.search(Time('2021-01-01', '2021-01-15') & Instrument('EUI'))

~/.virtualenvs/radiospectra/lib/python3.7/site-packages/sunpy/net/fido_factory.py in search(self, *query)
    346         """
    347         query = attr.and_(*query)
--> 348         results = query_walker.create(query, self)
    349
    350         # If we have searched the VSO but no results were returned, but another

~/.virtualenvs/radiospectra/lib/python3.7/site-packages/sunpy/net/attr.py in create(self, *args, **kwargs)
    563         Call the create function(s) matching the arguments to this method.
    564         """
--> 565         return self.createmm(self, *args, **kwargs)
    566
    567     def apply(self, *args, **kwargs):

~/.virtualenvs/radiospectra/lib/python3.7/site-packages/sunpy/util/functools.py in wrapper(*args, **kwargs)
     16
     17     def wrapper(*args, **kwargs):
---> 18         return dispatcher.dispatch(args[1].__class__)(*args, **kwargs)
     19
     20     wrapper.dispatch = dispatcher.dispatch

~/.virtualenvs/radiospectra/lib/python3.7/site-packages/sunpy/net/fido_factory.py in _create_and(walker, query, factory)
    275 @query_walker.add_creator(attr.AttrAnd)
    276 def _create_and(walker, query, factory):
--> 277     return factory._make_query_to_client(*query.attrs)
    278
    279

~/.virtualenvs/radiospectra/lib/python3.7/site-packages/sunpy/net/fido_factory.py in _make_query_to_client(self, *query)
    511             if isinstance(tmpclient, vso.VSOClient):
    512                 kwargs = dict(response_format="table")
--> 513             results.append(tmpclient.search(*query, **kwargs))
    514
    515         # This method is called by `search` and the results are fed into a

~/.virtualenvs/radiospectra/lib/python3.7/site-packages/sunpy_soar/client.py in search(self, *query, **kwargs)
     25         results = []
     26         for query_parameters in queries:
---> 27             results.append(self._do_search(query_parameters))
     28         table = astropy.table.vstack(results)
     29         qrt = QueryResponseTable(table, client=self)

~/.virtualenvs/radiospectra/lib/python3.7/site-packages/sunpy_soar/client.py in _do_search(query)
     63
     64         # Do some list/dict wrangling
---> 65         names = [m['name'] for m in r.json()['metadata']]
     66         info = {name: [] for name in names}
     67         for entry in r.json()['data']:

~/.virtualenvs/radiospectra/lib/python3.7/site-packages/requests/models.py in json(self, **kwargs)
    898                     # used.
    899                     pass
--> 900         return complexjson.loads(self.text, **kwargs)
    901
    902     @property

~/.pyenv/versions/3.7.0/Python.framework/Versions/3.7/lib/python3.7/json/__init__.py in loads(s, encoding, cls, object_hook, parse_float, parse_int, parse_constant, object_pairs_hook, **kw)
    346             parse_int is None and parse_float is None and
    347             parse_constant is None and object_pairs_hook is None and not kw):
--> 348         return _default_decoder.decode(s)
    349     if cls is None:
    350         cls = JSONDecoder

~/.pyenv/versions/3.7.0/Python.framework/Versions/3.7/lib/python3.7/json/decoder.py in decode(self, s, _w)
    335
    336         """
--> 337         obj, end = self.raw_decode(s, idx=_w(s, 0).end())
    338         end = _w(s, end).end()
    339         if end != len(s):

~/.pyenv/versions/3.7.0/Python.framework/Versions/3.7/lib/python3.7/json/decoder.py in raw_decode(self, s, idx)
    353             obj, end = self.scan_once(s, idx)
    354         except StopIteration as err:
--> 355             raise JSONDecodeError("Expecting value", s, err.value) from None
    356         return obj, end

JSONDecodeError: Expecting value: line 1 column 1 (char 0)

Would you expect the client to raise a better error, or return zero results and not error?

Hum I guess raise an error, but maybe that's not very user friendly? I assume it go a 200 response but there was just no json in it hence the json decode. It's probably going to be rare occurrence so maybe it doesn't need to be "fixed"?

👍 - definitely worth fixing I think. Having thought about this a bit more, it should probably just return zero results so other clients have a chance to return results too. I've opened https://github.com/sunpy/sunpy/issues/5661 though, to try and get sunpy to have a way of communicating to the user that there's zero results because a server is down.


Initial support for optogenetic stimulation

This pull request adds support for optogenetic stimulation, based on PyRHO code.

Looks all good to me


Update omniauth and bump omniauth-gumroad's patch version

This is a second attempt at https://github.com/DripEmail/omniauth-gumroad/pull/2
I included the same change to the .gitignore file.
I bumped bundler to 2.4.6 with $ gem update bundler and $ bundle update --bundler, I update the gemspec to depend on omniauth 2.0, and then I ran $ bundle update omniauth-oauth2 --conservative to update the Gemfile.lock

Technically, gems shouldn't commit the Gemfile.lock. But it isn't very important…

I've removed the Gemfile.lock and I've made the omniauth allowed versions more broad; I confirmed the syntax by checking against this gem: https://github.com/lostisland/sawyer/blob/f5f080d5c5260e094069139ffc7c13d0acba4ab5/sawyer.gemspec#L20

👍


[DOC] Deprecated queryResult Used Instead of query in Tutorial

Documentation issue
In tutorial, starting from Routing/Inferring Parameters page queryResult is used instead of query while using useShow(). And it keeps going like that in the right section to the end of the tutorial.
https://refine.dev/tutorial/routing/inferring-parameters/react-router/

After that same thing happens with useSelect() in UI Libraries/Refactoring and UI Libraries/CRUD Components.
https://refine.dev/tutorial/ui-libraries/refactoring/material-ui/react-router/
https://refine.dev/tutorial/ui-libraries/crud-components/material-ui/react-router/

Describe the thing to improve
Updating the queryResult in docs with query.
Also I would like to be assigned to this issue if it's possible.
Describe the solution (optional)
No response

Hey @emrecancorapci thanks for the issue. Would you like to work on this?

Assigned to you, looking forward to your PR 🚀


Strange python highlighting and cosmetics

Hello. Active medium reader here who is enjoying my time exploring your content. I'm hoping you might help me understand what I'm seeing when I work with some python code using a fresh install of this disto.
import requests

DEFAULT_URL = "https://xkcd.com/1906"

def get_url(url=DEFAULT_URL):
    return requests.get(url).status_code

When I place my cursor on the 'def' or 'return' key word, I see this odd highlight activity which I do not understand?

I can reproduce this with any color scheme so I tend to think this may be a feature I don't grok rather than a mere cosmetic.
Also, what's going on with the light bulb that we see to the left? I recall using nvim-lightbulb in a previous life but that plugin isn't installed here. The bulb follows my cursor from line to line so I'm guessing it behaves like the plugin I've mentioned which means it would be trying to tell me 1 or more code actions is available. Entertaining this idea, I do see ruff is offering 2 code actions:
[1] Ruff: Organize Imports
[2] Ruff: Fix all
However, neither option is actually doing anything and I'm sure you'd agree, there's nothing to "organize" to begin with. I'm guessing ruff is generating a false-positive which in turn spawns the bulb?

The highlight feature is from vim-matchup
The lightbulb comes from Lspsaga
The ruff lsp issue is fixed

Thank you. Looks like the ruff no-op situation is being discussed here.


Add MoveMulPastMaxPool transformation to streamlining

Adds a reordering transformation to move (non-negative) scalar or channelwise multiplications past 2D MaxPool nodes.
This improves the model compatibility of streamlining, e.g. in the case of a bnn_pynq/cnv_w4a4 network (issue #279).

Thank you Felix, looks good!


Face off: Virtual DOM vs Glimmer vs Incremental DOM article

Draft. RFC. Missing: benchmarks.

Implemented latest comments. Still missing: benchmarks.

Sold. ETA for the diagrams? Could we merge it tomorrow?

Should be done today (thursday). All benchmarks are running. We still need to analyze the data and make cute charts.

Full article. Missing: icon (need help!), SEO checklist.


Deb.sury.org deployed package key is expiring, prevent trouble for DDEV users

Is there an existing issue for this?

[X] I have searched the existing issues

Is your feature request related to a problem?

https://github.com/oerdnj/deb.sury.org/issues/2074

The key for the deb.sury.org repo expires on 16 Feb 2024. This is unfortunate. It has now been refreshed with a 2026 expiration date, but people with DDEV v1.22.6 and before will suddenly have failures on Feb 16 when the key expires and their ddev start tries to do an apt-get update and fails.
Describe your solution
I think we can figure out how to push a new version of ddev/ddev-webserver:v1.22.6 which solves this problem. Normally we don't replace existing images because it causes unexplained behavior differences.
This can be done two different ways:

Rebuild ddev-php-base and then also rebuild ddev-webserver:v1.22.6. This will give the new key. It has side-effects, some good, some unexpected. One is that all packages will be updated to current, including php*-xdebug, fixing https://github.com/ddev/ddev/issues/5633 - which could be good, but involves some behavior change.
Just rebuild ddev-webserver:v1.22.6 (still based on the original ddev-php-base) but add a layer that updates the deb.sury.org key. This is the least intrusive approach, but still may update a package or two.

@stasadev leans toward the first option because we fix the xdebug problem, #5633
I believe people will still have to do a docker pull ddev/ddev-webserver:v1.22.6 in order to solve the problem when the key expires. I'm not sure how to test this.
I imagine we should deploy a warning to ddev/remote-config to tell people about this.
Describe alternatives
No response
Additional context
No response

Oh, good news, perhaps we don't have to worry about v1.22.6 users. We have gradually made the apt update more resilient, so I see

https://github.com/ddev/ddev/blob/64e995843155244b9c2dc331993f74e51d1dbc48/pkg/ddevapp/config.go#L987
https://github.com/ddev/ddev/blob/64e995843155244b9c2dc331993f74e51d1dbc48/pkg/ddevapp/config.go#L999

So those should work out OK. The problem will be people who have Dockerfiles that do apt update without the || true, or who actually need to add something from deb.sury.org.

I tested with a changing image (same label), and the image was not automatically updated.
This behavior is controlled by pull-policy and build in docker-compose.
In our situation, where we have a build stage and no pull-policy specified, the behavior I think is specified by https://docs.docker.com/compose/compose-file/build/#using-build-and-image:

When Compose is confronted with both a build subsection for a service and an image attribute, it follows the rules defined by the pull_policy attribute.

If pull_policy is missing from the service definition, Compose attempts to pull the image first and then builds from source if the image isn't found in the registry or platform cache.

However, that does not seem to be the behavior we are seeing. I don't mind the behavior we have, because it's tuned to allow offline work with DDEV.

I suspect this will directly affect only a few people, and all of them can solve it by upgrading to v1.22.7, which may be just as easy as docker pull ddev/ddev-webserver:v1.22.6

This is all fixed in DDEV v1.22.7
I did go ahead and push a new ddev/ddev-webserver:v1.22.6 for folks that want to continue using v1.22.6 but need this fix. They have to manually docker pull ddev/ddev-webserver:v1.22.6 but then will have php 8.3.2 AND xdebug 3.3.1, fixing https://github.com/ddev/ddev/issues/5633 for them

For findability: You might see
GPG error: https://packages.sury.org/php bullseye InRelease: The following signatures were invalid EXPKEYSIG B188E2B695BD4743 DEB.SURY.ORG Automatic Signing Key<EMAIL_ADDRESS>
The repository 'https://packages.sury.org/php bullseye InRelease' is not signed.

People may still run across this, as many versions of DDEV are out there. All the info is here though, so closing.


Finish implementing remaster alchemist archetype including quick alchemy

Looking over the changes, this does not appear to fix Infused Reagents for Advanced Alchemy on the Crafting Tab. Setting the crafting to one per reagent instead of two (without feat progression) and changing the value from INT + LVL to 4 + INT. Is that planned for a different PR?

Infused reagents are no longer a mechanic in remastered advanced alchemy.

Infused reagents are no longer a mechanic in remastered advanced alchemy.
Sorry, I am speaking to the rules that replaced Infused Reagents by having you create 4 + INT number of items with the infused trait. I do not see these new rules accounted for, in this PR or in previous PRs. So I was wondering if I was misreading the system, as I am just now starting to look through this code base, or if it has not been accounted for as of yet.
I can see that Versatile Vials is accounted for, though I also do not see where the 2 + INT value is being applied for those, which is why I am leaning toward that I am just not reading the implementation correctly.
I am a C#/Swift engineer, so TypeScript/JavaScript is a little rusty for me.

Sorry, I am speaking to the rules that replaced Infused Reagents by having you create 4 + INT number of items with the infused trait.

The Alchemist archetype is initially limited to four versatile vials:

You gain the Quick Alchemy benefits (page 174), creating up to 4 versatile vials during your daily preparations.

Sorry, I am speaking to the rules that replaced Infused Reagents by having you create 4 + INT number of items with the infused trait.

The Alchemist archetype is initially limited to four versatile vials:

You gain the Quick Alchemy benefits (page 174), creating up to 4 versatile vials during your daily preparations.

Yes, but my original question is about "Advanced Alchemy on the Crafting Tab". Seeing as in the current version, if you are an alchemist, your stats all read correctly, but the crafting page still behaves as if you are using the legacy alchemist. I understand the SRD. I am inquiring about the code and where values are implemented, if they are being implemented.
I also do not see it being implemented in this PR: https://github.com/foundryvtt/pf2e/pull/17039/files
So my question of " Is that planned for a different PR?" still stands.

Your question isn't very well stated if that's at all the intent, given you were asking about infused reagents and advanced alchemy, which this is neither.
This only touches the alchemist archetype as a proof of concept. The job of the alchemist class is better served to our data entry guys, as that's a more involved process and I trust them with it.

Your question isn't very well stated if that's at all the intent, given you were asking about infused reagents and advanced alchemy, which this is neither.
This only touches the alchemist archetype as a proof of concept. The job of the alchemist class is better served to our data entry guys (and won't require code changes), as that's a more involved process and I trust them with it.

Apologies for the question not being clear. Allow me to restate.
The Crafting Tab in the Character Sheet uses different rules for the new Alchemist. As the amount crafted per formula is different and the source of this is different. The Class information appears to be filled in quite well, but the Crafting Tab itself does not respect Advanced Alchemy properly. Would this not be a system level change and not just data entry? If so, is there currently a system change planned to support this?
I understand this is a volunteer project, and in no way am pressing or rushing. Was curious about the fact that this change is including the Alchemist Architype and Quick Alchemy, but is not updating the crafting page, as it seems like an extremely useful feature to focus on for the Alchemist class.

Except for known formulas, the crafting tab's contents are generated by rule elements. The code here are changes to make those rule elements capable of new features that will be necessary for the new alchemist. You're asking about advanced alchemy which has nothing to do with this PR, but the Advanced Alchemy feat in the alchemist archetype has already been updated to the new rules (though not the class yet).
isAlchemical is the property in the existing alchemist class that enables the old style infused reagents behavior.

Also, note that this doesn't close any issues.

Thanks for all your hard work, I watched some demo gifs and this looks great!
One thing bugs me though -- from what I saw, the newly created items are Worn/Carried rather than Held in 1 Hand, which means that there's always an extra button click needed to draw them into your hand.  This is a little annoyance that seems easily solvable (if you haven't solved it already in a newer branch).


Use Zalenium to run the integration tests for tailor on multiple environments

From docs:

Zalenium
This is a Selenium Grid extension to scale your local grid dynamically with docker containers. It uses docker-selenium to run your tests in Firefox and Chrome locally, and when you need a different browser, your tests can get redirected to a cloud testing provider (Sauce Labs, BrowserStack, TestingBot).

https://github.com/zalando/zalenium

Not sure we need this functionality for tailor, we already have saucelabs integration which works without any issues. But if you have experience using Zalenium and want to contribute, Feel free to send PR.

Closing this since its not a priority and current solution works for most cases.

You could try out Continuous Delivery Platform + Zalenium --- @diemol is probably willing to help :smile:

@hjacobs Thanks! Totally in if someone is willing to help move from the current setup.

I was checking around, I see you already have a Sauce Labs account, I guess an open source one, right?
If that's correct, I am not sure if it makes sense to integrate Zalenium. Nevertheless, I was checking the project and I couldn't figure out quickly where to make changes. Perhaps it would be helpful to add this to the contributing guidelines?

@diemol Yes its a open source one. The integration test reside here https://github.com/zalando/tailor/blob/master/examples/multiple-fragments-with-custom-amd/test.js

I'll assign this to me, I'll get back to you in case I have questions. Thanks.

Hi @vigneshshanmugam,
I checked this again, and as much as I'd like for this project to use Zalenium, I don't think it makes sense. I am more an advocate of using the right tool than anything else.
If tailor uses Zalenium, then the tests running with Chrome would use Zalenium directly in the Travis job, video gets recorded but this would be lost since there is not at straightforward way to store test results. When you run with IE, those ones would go to SauceLabs and the videos will be stored there.
If tailor keeps only using SauceLabs, then all the videos are already stored there. Which fits well in this case.
In short, adding Zalenium would put one layer more into the flow without bringing a lot of value.
In my opinion, this could be closed.

@diemol Thanks for your detailed insights. Closing it as per your suggestion.


pumba wildcard not working properly

Hello,
I am running ubuntu 16.04 in AWS.

SOS please help a sinking ship

I am getting the same behavior when trying to use the regex.  Though your command would kill all containers with that wildcard while I think you would want to pass the random flag as well as regex to filter down what it is looking at.

Probably, related to shell you are using. Use proper re2 regexp syntax and enclose expression in quotes.


implement previousValue, port nextValue and previousValue to buffer p…

…ackage

Coverage increased (+0.2%) to 91.908% when pulling af40b04b34dc0440482338b62f263ae79c3e71a8 on richardstartin:previous-value into 897807e79e15878c58d155365557a14efafdde0e on RoaringBitmap:master.

Looks like we have a flaky test:
  BitmapAnalyserTest.analyseRandomBitmap:39 expected:<0.2> but was:<0.0>```

When I put the test in an infinite loop it breaks within 10 seconds, because it depends on the RNG producing a number < 0.2 within 80 invocations which is probable but not guaranteed.

There are a few things going on in the flaky test, which aren’t really the test’s fault.

Random choice of container type within randomBitmap
data created within randomBitmap ends up as unexpected container type. Bitmaps get run compressed, some runs get turned into arrays and vice versa.
randomBitmap’s output wasn’t ever expected to be tested but is usually reasonably close to the supplied parameters

It would be interesting to fuzz test whether statistics are preserved during bitmap -> int[] -> bitmap conversions.

@richardstartin
I have created a branch with deterministic tests. I think we should move to deterministic tests.
I won't merge this branch now because I fear how it might interact with your work. Can you have a look?
https://github.com/RoaringBitmap/RoaringBitmap/tree/makingtestsdeterministics

I agree but think it could be made deterministic with a lighter touch. I will add a commit here, let me know what you think.

@richardstartin  That's fine. I am not in love with my version.
I think that having non-deterministic tests is a super bad idea. I feel a bit of shame that I did not catch that when it was committed. :-(

I introduced them with the fuzz tests, and I think they make sense when the nondeterminism is independent of the assertions made. They can help verify statements like "property X should hold for all possible inputs" avoiding the (impossible) construction of all inputs. Each build being an independent event makes the probability of the existence of a bug given N sequential passed builds tend to zero quickly. It was in this spirit that the changes were introduced, If you make assertions about the randomness itself (such as "within 1000 trials the RNG converges to a uniform distribution") you are in a lot of trouble.
Please take a look at the latest commit which makes the tests deterministic.

Looks good to me. Let us see what travis thinks.

Of course, it passes, because the seed was chosen to accommodate the failing test. But all the tests making assertions independent of the statistics of the random number generator are now a lot weaker because they run exactly the same way each time, and if there are undiscovered bugs they will not find them, because the seed has been fixed to make them pass.

@richardstartin
I think that the Go version of roaring go fuzzy tests first. The way it works over there is that we have standard, deterministic tests... then we have a separate fuzzy engine that you can run for extended periods of time (indefinitely in fact). I think that's a good design.
Once the fuzzy tests detect a problem, this problem can then become a deterministic test to avoid regression.
It is quite fun. Take an idle machine, then start the tests... let it run for days... (I did that!)... see if it finds something!
In any case, do you recommend merging your code?

I would like to find a way to keep the randomness of the property based tests, since if you have a test for a condition which should hold regardless of its input, you don't need to fix the input and can only gain from the ability to generate random test cases. It's important to distinguish between this style of testing and tests which have constraints on inputs with nondeterministic input. So I'm not keen to hastily neuter the fuzz tests, so I'm not in a rush to merge this or have it merged at all for that matter.
Is there a way to address your concerns about nondeterminism while keeping the tests? What about running them in a different module or in a different stage of the build?

Ok. Let us discuss the objectives.
What I'd like is for the CI tests to be deterministic. Either they always fail or they always pass. If I restart a test, it should come out the same, no matter what. You should be able, on your machine, to reproduce exactly (up to memory failures and timeouts) the CI results.
This should also be true during release. Whether the tests pass during a release should be pre-determined. E.g., you don't want me to try to release, get an error, have me try again, and get the release to pass.
This does not preclude non-determinism... but that should be an option.
Do we agree?

Ok. Let us delay this.

@lemire I've moved the fuzz tests into a dedicated module which will only run in the fuzz-test profile. This will likely decrease code coverage noticeably, but makes the CI build deterministic. I'm happy for you to merge this PR if you are.

Let us go then. Merging.


fix: Respecting -k parameter in "kconnect to"

What this PR does / why we need it:
This makes the to sub command respect the -k flag. It also makes to - respect the config file path stored in the history entry.
It will leave the history entry untouched, meaning the next call to to will revert back to the config file passed when creating the entry.
I had to prevent the history entries from comparing on the config file field, as doing so leads to the duplication of entries when using -k, which then in turn breaks the alias until the file is edited by hand.
With the below change the config file is not considered during history entry comparisons.
Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #352
Replaces PR #409 - The comment made in that PR is also addressed here

Hi @Ulrar, I don't think kconnect to - will use the previous config.
% ./kconnect to <alias> --password <password> -k ~/test.config
info	kconnect - the Kubernetes Connection Manager CLI	{"version": ""}
info	authenticating user	{"app": "kconnect", "provider": "saml"}
info	requesting AWS credentials using SAML	{"provider": "saml", "sp": "aws"}
info	getting cluster details	{"app": "kconnect", "id": "<id>", "provider": "eks"}
info	getting EKS cluster	{"app": "kconnect", "provider": "eks", "id": "<id>"}
info	setting current context	{"context": "<context>"}
info	kubeconfig updated	{"path": "~/test.config"}

Looks like it reverts to the default location:
% ./kconnect to - --password <password>
info	kconnect - the Kubernetes Connection Manager CLI	{"version": ""}
info	authenticating user	{"app": "kconnect", "provider": "saml"}
info	requesting AWS credentials using SAML	{"provider": "saml", "sp": "aws"}
info	getting cluster details	{"app": "kconnect", "id": "<id>", "provider": "eks"}
info	getting EKS cluster	{"app": "kconnect", "provider": "eks", "id": "<id>"}
info	setting current context	{"context": "<context>"}
info	kubeconfig updated	{"path": "~/KUBECONFIG"}

Unless the goal is to pass the -k flag each time, in which case this works:
% ./kconnect to - --password <password>
info	kconnect - the Kubernetes Connection Manager CLI	{"version": ""}
info	authenticating user	{"app": "kconnect", "provider": "saml"}
info	requesting AWS credentials using SAML	{"provider": "saml", "sp": "aws"}
info	getting cluster details	{"app": "kconnect", "id": "<id>", "provider": "eks"}
info	getting EKS cluster	{"app": "kconnect", "provider": "eks", "id": "<id>"}
info	setting current context	{"context": "<context>"}
info	kubeconfig updated	{"path": "~/test.config"}

Hi @Ulrar, I just want to clarify something. We still need to specific the -k flag with each command in order for kconnect to save the information to the non-default location of the kubeconfig, correct?
Meaning kconnect does not store the non-default location of the kubeconfig from the previous command.

That's correct, with this PR kconnect to -k is a one time override over the stored entry.
But if the entry has a non default config (created using kconnect use eks -k for example) then to will respect that without needing the flag.
Hopefully that makes sense, I treat use as a way to create the config and to as a way to recall it as is, admittedly this might be a debatable interpretation

That's correct, with this PR kconnect to -k is a one time override over the stored entry. But if the entry has a non default config (created using kconnect use eks -k for example) then to will respect that without needing the flag.
Hopefully that makes sense, I treat use as a way to create the config and to as a way to recall it as is, admittedly this might be a debatable interpretation

Ok perfect. Yeah makes sense, just wanted to double check my understanding. I was testing the feature branch, and thought there might have been issue for a second. Thank you for the explanation. 😄


Chat commands adding together

When any command is sent to the chat, it is not clearing the previously commands, leaving them as part of a whispered name, so when I open my chat box the whispered name is something like @KoreanZombie/whois/hideou/hideou/hideout@Romonomicon This of course breaks every functionality of the application, as new commands are just added to this "character" to be whispered to.
I tried deleting and reinstalling my installation of the program, but it persisted.
Related note, where does it store the settings preferences? Because all my quick replies and settings were the same after deleting the program folder and reinstalling, and maybe deleting the preference file will help.

i have the same problem. if i click 2 or 3 times on a response button, the chat code is adding. same with other buttons like the leave team of go to hideout.
example(response button): @Example4@Example1
next time i click the same button: @Example4@Example1@Example1
and so on
does anyone have a solution for this problem?


Correctly replace "Boot from USB" keyword

Some attempt has been made here: https://github.com/Dasharo/open-source-firmware-validation/pull/92/files

Another of the USB related issues to be fixed together. Adding a label.

@PLangowski let's try to get back to this issue and work opened in this PR: https://github.com/Dasharo/open-source-firmware-validation/pull/92


Update the dependency on Istio API repo

Update the dependency on Istio API repo

[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by: lei-tang
To fully approve this pull request, please assign additional approvers.
We suggest the following additional approver: myidpt
If they are not already assigned, you can assign the PR to them by writing /assign @myidpt in a comment when ready.
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

/cc @rkpagadala

Why is this needed? The changes look a lot more than updating the dependency on Istio API repo

This PR is per the request from @rkpagadala since the last update on the api dependency was 6 days ago. The changes in the PR are the result of running: dep ensure --update istio.io/api.
The go version is go1.10.3 linux/amd64; the dep has been updated to the latest version by running: go get -u github.com/golang/dep/cmd/dep

Close this PR because there is another PR (https://github.com/istio/istio/pull/7372) with smaller diff pending that does the same update.


[Event Parameter Change] Codeunit 6620 - Copy Document Mgt. - procedure CopyArchSalesLine - Event OnCopyArchSalesLineOnAfterIncrementNextLineNo

We would like the parameter ToSalesHeader added to the following event.
Codeunit 6620 - Copy Document Mgt. - procedure CopyArchSalesLine - Event OnCopyArchSalesLineOnAfterIncrementNextLineNo
Original:
OnCopyArchSalesLineOnAfterIncrementNextLineNo(ToSalesLine, FromSalesLineArchive, NextLineNo);

[IntegrationEvent(false, false)]
local procedure OnCopyArchSalesLineOnAfterIncrementNextLineNo(var ToSalesLine: Record "Sales Line"; var FromSalesLineArchive: Record "Sales Line Archive"; var NextLineNo: Integer)
begin
end;

Change:
OnCopyArchSalesLineOnAfterIncrementNextLineNo(ToSalesLine, FromSalesLineArchive, NextLineNo, ToSalesHeader);

[IntegrationEvent(false, false)]
local procedure OnCopyArchSalesLineOnAfterIncrementNextLineNo(var ToSalesLine: Record "Sales Line"; var FromSalesLineArchive: Record "Sales Line Archive"; var NextLineNo: Integer; ToSalesHeader: Record "Sales Header") // <-- ADDED
begin
end;

Thanks for reporting this. We agree, and we’ll publish a fix asap, either in an update for the current version or in the next major release. Please do not reply to this, as we do not monitor closed issues. If you have follow-up questions or requests, please create a new issue where you reference this one.
Build ID: 42843.


How to resume a download?

Hello everyone!
I don't have the most stable network connection, and I was wondering if it was possible to resume a data download for a large dataset if the connection is interrupted.
If not, do you have any tips to minimise losses (like downloading in stages or creating some sort of checkpoint system?)
Thanks!

Hi @Thomas-Frew,
The Toolkit class gives you the ability to provide a "custom" dataset for both historical as well as fundamental data. So as an example you can do the following:
from financetoolkit import Toolkit
import pandas as pd

ticker_list = ['AMZN', 'AAPL', 'TSLA', 'MU', 'GOOG', 'TSM']

# Only picking the first three as an example
companies = Toolkit(tickers=ticker_list[:2], api_key="API_KEY")

# Load historical data and save to a variable
historical_data = companies.get_historical_data()

# Write to Pickle
historical_data.to_pickle("saved_stocks.pickle")

# Load the Pickle (in the case your current instance is erased)
loaded_data = pd.read_pickle('saved_stocks.pickle')

# Reinitialise the Toolkit with the historical data
companies_2 = Toolkit(tickers=ticker_list[:2], api_key="API_KEY", historical=loaded_data)

# Show bollinger bands as an illustration of the capability
companies_2.technicals.get_bollinger_bands()

This gets you the following without the requirement to download any of the data again:

Therefore, if you create a loop over your tickers, write to pickle and when you got everything combine the pickles, you get what you are looking for. As an example:

Working with custom datasets is a little bit experimental however. I believe it works in pretty much every area but feel free to let me know if you run into issues.

Hi @Thomas-Frew, did this fix your problem?

Thanks for your help! This was very useful.


"pizza-shack-api" folder has gone missing

The <APIM_HOME>/samples/PizzaShack/pizza-shack-api folder has gone missing since API Manager 2.0.0. Looks like the folder has gone missing in the master branch, but still exists in the 1.10.x branch. Please merge it back into master.

It has moved to component repostiory carbon-apimgt


Pages "Direct Upload" Source Type

Current Terraform and Cloudflare provider version

Terraform: v1.3.7
Cloudflare Provider: v3.34.0

Description
It appears that the only source.type valid in source_config is GitHub.  At least that is all that is documented.  Is there any way to support Direct Upload from a build output directory with Terraform?
If directory is not possible, maybe it makes sense to point towards a zip generated with hashicorp/archive.
Use cases

Not everyone uses GitHub
Some organizations may not want to link their GitHub
Direct Upload is simple
Yes, it is easy to do this via Wrangler.  But if an organization already is standardized on Terraform, would be nice to not have to install another tool.

Potential Terraform configuration
resource "cloudflare_pages_project" "source_config" {
  account_id        = "f037e56e89293a057740de681ac9abbe"
  name              = "this-is-my-project-01"
  production_branch = "main"
  source {
    type = "direct"
    config {
      source_dir = "../client/dist"
    }
  }
}

References

https://github.com/cloudflare/terraform-provider-cloudflare/issues/2084

I think this feature is useful, hope it will be added in the future.


hey i appreciate what you did here , any way to implement this with angular monaco compenent?

Hi @mnmajd , There is a recent update on the restricted editor implementation which purely relies on the ranges, And I am planning to release this as an npm package soon. Once released, you can follow the documentation on how to use it in any javascript application.
If you have any urgent requirement, feel free to look into my code and recreate your own implementation using my source files as a base
PS: I don't know much about angular, I can help you with JS but you have to take care of the data binding and event handling layer in the angular implementation

Hi @Pranomvignesh  , thank you for reply , can you put the old version in another please? its suits with my case
i will try to adapt it with what im really want to implement in my project

can you put the old version in another please - I have created a tag named old version from the commit id c27a2db60d5f50e22d60ec6f1b7e82a521dce4b5 , you can use that for your case


test: remove nonce manager from create_account_tx_for_validate_test

This change is

[!WARNING]
This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more

#1814  👈
#1813
#1812
#1811
main

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @ArniStarkware and the rest of your teammates on  Graphite

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 75.63%. Comparing base (2a5a332) to head (23b41d2).

Additional details and impacted files
@@                              Coverage Diff                              @@
##           arni/validate_mode/tests/remove_salt_manager    #1814   +/-   ##
=============================================================================
  Coverage                                         75.63%   75.63%
=============================================================================
  Files                                                60       60
  Lines                                              8536     8536
  Branches                                           8536     8536
=============================================================================
  Hits                                               6456     6456
  Misses                                             1655     1655
  Partials                                            425      425

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


fix comments to reduce golint issues

Signed-off-by: DiptoChakrabarty<EMAIL_ADDRESS>
Pull Request Motivation
This is continuation based on the feedback received in PR #4801

Kind

/kind cleanup
Release Note

NONE

/ok-to-test
/lgtm
/approve
Thanks very much! :heart:  I'll close #4801 in favour of this one!


[Suggestion]: Minor UX Issues

Issue Checklist:

[X] There are no matching Open Feature Requests
[X] There are no matching Closed Feature Requests
[X] I've read the Contributing Guide
[X] I'm following the Code of Conduct

Suggestion / Feature Request
Some minor UX suggestions:

Might want to clarify that it's for the Script/Pipelet/Jobstep APIs. Only because (right now) it doesn't include the SCAPI, OCAPI, Guides, etc. And maybe a small section on the index for links to the (various) official ones. Would be helpful for SEO too. (actually now I see you have a button to the github.io docs, that's good. Other links to docs not covered might still be good though)
Left navigation groups looks alphabetical but script API first might be slightly better since that's 90% of the queries (and because it's below the fold). (also does the search sort this way? that might be more important to put script API first).
Is there a way to input a search query from URL? For instance on devdocs.io you can search arbitrarily with this form: https://devdocs.io/#q=head. Thinking folks can set up a custom search shortcut in chrome for the site, type sfccdocs[TAB]order and land on a search for order. Might be a cool selling point for searching right in your browser bar.
I think the site looks best at 110% scaled in terms of fonts, etc (but this is probably my bad eyesight and I think I sunburned my eyeballs today).
Version switcher z-index is behind the main content
Search and filter boxes could use a slight debounce. When typing fast it seems to execute the search but a debounce on the filtering would allow for lots of keystrokes without lag.
nit: the right nav on script APIs could probably use types or something in the methods. When there is a method overload you get a lot of repitition in the names (like on the Mac class you see digest, diest, digest. Obviously there's limited space here.

@clavery Responses for the reported issues:

Would there be interest in having those missing docs here? I have them, I honestly just did not use them so thought maybe others might not need them either.  But happy to put them back in.
I agree, and have reversed the order for this first parent listing ( new order will be Script, Pipelet & Job Step
This is a really good idea.  I will look into getting this added.  Since there is no traditional search results page, who would you envision this working? e.g. would we just reload the search tool on page load if a query exists in the hash?
If it's still an issue, let me know.  Could be a cool option to allow that to be configured like themes.  People will want different sizes more than likely,  This is just Tailwind CSS default sizing.
I've fixed the z-index issues and will have that out in the next release.
I had a debounce on here, and because of react's state management, it actually felt more laggy with the debounce, but I can give it a go again.
That right nav is auto generated from headings, but I can take a look at trying to do things more dynamically

@clavery 2 & 5 in your list above were deployed in v0.2.0 release that went out today.  Your number 4 also got a slight fix in the menu, as I went ahead and bumped that up as it was pretty small.

Good question and yes I think that solution makes sense. For other SPA type apps this is kinda how it works. For instance swagger-UI will load and if an endpoint exists in the hash it opens and scrolls to it. Maybe the search can be handled via next URL state or maybe it's just a special case to look for it on load and open the search? (or maybe even an option to have a traditional search results page in addition to the popover search.
I can zoom. It looks fine.
.
Yeah feels laggy at high typing speed but it's a minor issue overall.
It's a pretty minor thing.

@clavery
Item 3
in your list I have added support for /?q=<keyword>
You this will load the search engine, do a search and go to the first result.
Future versions I may hide the search panel and just keep the page blurred with like a loading page as it feels a bit weird.  But it works.  I like this idea as now anyone can just send a link to these docs with a keyword attached via https://sfccdocs.com/?q=<keyword>
https://sfccdocs.com/?q=normalize
Item 6
I've added a 150ms debounce to typing.  I also fixed a bug with non-alphanumeric inputs ( like control characters ) that were incorrectly hiding results until you typed again )

Closing this out since everything in here is fixed that was a bug or UX/UI issue


Link to the dataset is broken.

Hi, Thanks a lot for your sharing. Could you check the link to the dataset? I want  to take a look at the dataset but find the link is broken.

Hi, thanks for your interest. Have you tried to access using different networks or computers? I can still access the link normally.

I tried to access under another networks and it is OK. Thanks !


Got too many pings from the client, closing the connection in TiDB server log files

Bug Report
Please answer these questions before submitting your issue. Thanks!
See https://github.com/pingcap/tidb/issues/36861 for more details.
1. Minimal reproduce step (Required)

2. What did you expect to see? (Required)
3. What did you see instead (Required)
4. What is your TiFlash version? (Required)

I'm not sure if the Got too many pings from the client error comes from the connection between TiDB and TiFlash, because according to the related document:

Why is my client not sending keepalive pings even after configuring GRPC_ARG_KEEPALIVE_TIME_MS and GRPC_ARG_KEEPALIVE_TIMEOUT_MS?

This can happen in the following cases -

There are no RPCs in flight and GRPC_ARG_KEEPALIVE_PERMIT_WITHOUT_CALLS has not been set to 1(defaults to 0). If we require the endpoint to be able to send pings even when there are no ongoing RPCs, GRPC_ARG_KEEPALIVE_PERMIT_WITHOUT_CALLS should be set to 1 as documented above.
When there isn't any data/header being sent on the transport, gRPC clients restrict the number of pings to 2 by default. Setting GRPC_ARG_HTTP2_MAX_PINGS_WITHOUT_DATA to 0 will remove this limit.

It looks like according to the explain above, too many pings usually happens when client set GRPC_ARG_KEEPALIVE_PERMIT_WITHOUT_CALLS to true and server set GRPC_ARG_KEEPALIVE_PERMIT_WITHOUT_CALLS to false, but  TiFlash already set GRPC_ARG_KEEPALIVE_PERMIT_WITHOUT_CALLS to true.

I think TiDB set it to false.

At least in current master codebase, TiDB still set it to true:
https://github.com/tikv/client-go/blob/master/internal/client/client.go#L194-L197
And since TiDB is just the client side, even if it set to false, it should not causing the too many pings error.

Yes, TiDB is the client side in clint-go. I mean is it possible that TiFlash is the client side and trying to get some info, maybe table schemas, from TiDB server?

Yes, TiDB is the client side in client-go. I mean is it possible that TiFlash is the client side and trying to get some info, maybe table schemas, from TiDB server?

AFAIK, TiFlash does not communicate with TiDB as a grpc client, for table schema, TiFlash get it from TiKV. Even if TiFlash communicate with TiDB as a grpc client, TiFlash use client-c as its' client and in client-c, GRPC_ARG_KEEPALIVE_PERMIT_WITHOUT_CALLS is not set exlicitly, and the default value I think is false.
https://github.com/tikv/client-c/blob/master/include/pingcap/kv/internal/conn.h#L21-L24

Do you mean TiFlash uses client-c of TiKV to communicate with TiDB?!
Well, I think I shouldn't guess at some of the modules I'm not too familiar with. I'm going to just keep the issue in the tidb repo and close this one.


Add clubstep (geezer remix) by Gyzer

Song Name
clubstep (geezer remix)
Artist Name
Gyzer
Source
Youtube
Youtube Link
mKcNIJ-BIFDcdFdR
Direct File Link
No response
Song ID
13
Start Offset [ms]
0
Extra
Created from Auto Nong.
Created for level: 4125776

reject
invalid YouTube link


Improve types

Makes types more strict, via removing { [any]: any }s and replacing them with actual types

At the moment changing self: any to self: Profile<T> breaks Roblox studio auto-completion. Were you aware of this and could you propose any workarounds?

At the moment changing self: any to self: Profile<T> breaks Roblox studio auto-completion. Were you aware of this and could you propose any workarounds?

Thats weird, although could be the solver breaking down from a large file? As I've never had an issue like this before, I'll try out separating stuff like signal into their own files and make a new pr if it works.

Closing this PR for now - the JSONAcceptable type has been implemented, but the class types are incompatible with Roblox studio as it is.


🛠 Tooling: Use the create engine for shell commands

Bug Report Checklist

[X] I have tried restarting my IDE and the issue persists.
[X] I have pulled the latest main branch of the repository.
[X] I have searched for related issues and found none that matched my issue.

Overview
Splitting out of #1181: I'm onboarding this project to the new "create" engine in https://github.com/JoshuaKGoldberg/create. #1670 added usage of file creations. Another step will be having shell commands such as pnpm format --write and pnpm lint --fix provided by blocks.
Additional Info
Linked issue on create: https://github.com/JoshuaKGoldberg/create/issues/22
💖

For reference, here are the shell commands executed in CTA today as part of >=1 mode runtime...

pnpm install: in the finalizeDependencies step, which is in create and migrate modes
pnpm dedupe --offline: in the finalizeDependencies step for create and migrate modes; as a final cleanup command in initialize mode
pnpm build: in createCleanupCommands after other steps in all three modes, if bin is enabled
pnpm lint --fix: in createCleanupCommands after other steps in all three modes, after pnpm build if was included
pnpm format --write: in createCleanupCommands after other steps in all three modes, after pnpm format --write
pnpm remove <...packages...>: in removeDependencies:

To remove all-contributors-cli and all-contributors-for-repository in finalizeDependencies, which appears to be an old form of a migration
In uninstallPackages, called towards the end of initialize mode and before pnpm dedupe --offline

pnpm add <...devDependencies...>: in `finalizeDependencies
pnpm add prettier -D: at the end of uninstallPackages, as a part of initialize mode
pnpm run lint:spelling: in getStdout <- populateCSpellDictionary, in migrate mode
git tag -l and git tag -d <...tags...>: in `clearLocalGitTags, as part of create mode
git tag -l and git tag -d <...tags...>: in `resetGitTags, as part of initialize mode
git init -b main: in createAndEnterGitDirectory, as part of create mode
git status and git init: in ensureGitRepository, as part of initialize and migrate modes
git restore .: in runOrRestore for all modes if executing catches an error
git remote, and if an origin remote doesn't yet exist, git remote add origin <origin>, and git fetch: in initializeGitRemote <- initializeGitHubRepository
npx -y<EMAIL_ADDRESS>add <user> <...contributions...>: in `getGitHubUserAsAllContributor, called by:

addOwnerAsAllContributor: in initialize mode
addToolAllContributors: in create mode

npx all-contributors-cli generate: near the end of finalizeDependencies
npx-y all-contributors-cli add JoshuaKGoldberg tool: by addToolAllContributors in create mode
npx -y all-contributors-cli add <contributor> <...types...>: in detectExistingContributors for each contributor, in migrate mode
chmod ug+x .husky/pre-commit: in writeStructure because of #718

Resolved by #1766.


Error: incorrect input when using custom completer

Hi !
I've been trying to use the function shell.CustomCompleter to have an enhanced completer and it works well except that after completion, I hit Enter and get the message:
Error: incorrect input, try 'help' .
My code is based on your iCompleter with minor changes, I've read in your code that you're giving the shell's root command to your completer to make it work:
func (s *Shell) initCompleters() { 	s.setCompleter(iCompleter{cmd: s.rootCmd, disabled: func() bool { return s.multiChoiceActive }}) }
I figured out I'd need to use the shell's rootCmd to create my custom completer or I'd need to set a new rootCmd to the shell. Otherwise when I create a new command for my completer, it will complete based on that command, but will try to call the command from the shell's own root command and fails.
Could you add a GetRootCmd() function to the ishell.Shell struct so I can re-use the root command in my custom completer or add a SetRootCmd(cmd *Cmd) so I can use mine and the shell can find my commands ?

Thank you !


Expose raw data in serial editor

(1) Graph data like "x:123" now goes to the console too
(2) Export data button now provides dropdown so user can select raw or csv

I'd like to review this at the design meeting. I was thinking about a button where the default interaction is CSV - with a side dropdown for text.

Export is an advanced feature. Are we ok with this kind of drop down menu?

@abchatra @samelhusseini see new button on top of the console to allow downloading the raw output. We should really have a way to drag up and down the console but that can be for another PR.

Lets take this to design review today. Is this bumped in beta to visualize?

Yes


split socket.pyx into pyx/py

Only the basic methods of the socket need to be Cython:

init
close
send
recv
getsockopt
setsockopt

All the derivative and sugar methods (multipart, json, sockopts as attrs, etc.) do not need to be Cython, and do not benefit from being compiled.  I would like to split the Socket file into two: a minimal base class in Cython, and the extended methods on a subclass in Python.
This would reduce compile time, and significantly reduce the need to recompile when working on new features, as the core methods haven't been touched in quite some time.

weird, Issue opened twice.  Closing duplicate.


netlify dev fails to start on parcel framework

Describe the bug
Using https://github.com/clawfire/covid19-passbook-generator/ , I launch a netlify dev command, and ... it crashes with an error while proxying request: socket hang up even when the page isn't loaded in the browser. Meanwhile, the started server from parcel works just well.
The command executed is npx parcel serve src/index.html --https && cp node_modules/qr-scanner/qr-scanner-worker.min.js dist/qr-scanner-worker.min.js
To Reproduce
Steps to reproduce the behavior:

Clone https://github.com/clawfire/covid19-passbook-generator/
Navigate to the cloned repository
Run netlify dev
See that the CLI exits with an error

Configuration
# example netlify.toml
[build]
  command = "yarn run build"
  functions = "netlify/functions"
  publish = "/dist"

  ## Uncomment to use this redirect for Single Page Applications like create-react-app.
  ## Not needed for static site generators.
  #[[redirects]]
  #  from = "/*"
  #  to = "/index.html"
  #  status = 200

[context.production]
    command = "yarn run build"
    NODE_ENV = "production"
[content.branch-deploy]
    command = "yarn run deploy-preview"
    NODE_ENV = "production"

[dev]
port = 3000 # Port that the dev server will be listening on
publish = "dist" # Folder with the static content for _redirect file
command = "yarn start" # Command to start your dev server
targetPort = 1234

And the system infos
  System:
    OS: macOS 11.4
    CPU: (4) x64 Intel(R) Core(TM) i7-7567U CPU @ 3.50GHz
    Memory: 185.53 MB / 16.00 GB
    Shell: 5.1.8 - /usr/local/bin/bash
  Binaries:
    Node: 16.5.0 - /usr/local/bin/node
    Yarn: 1.22.10 - /usr/local/bin/yarn
    npm: 7.19.1 - /usr/local/bin/npm
  npmGlobalPackages:
    netlify-cli: 4.4.2

Expected behavior
Serve the page
CLI Output
error while proxying request: socket hang up
Additional context
Originally post on #404

For what it's worth, I used parcel regularly and don't have any issue with a package.json that reads
...
"scripts": {
    "build": "parcel build src/index.html",
    "start": "parcel src/index.html"
},
...

and setting command = "yarn start" or command = "yarn build" in my netlify.toml both parcel and netlify dev run properly (currently using "parcel": "2.0.0-beta.2".)

Yep, the issue was indeed with the --https I was using when only using parcel for local dev and not netlify dev 😃
Removing the --https of my yarn/npm script invocation make it works like a charm.


Add @types/node to dev deps in package.json for TS projects

If the user picks TypeScript, there is a 99% chance they are going to want at least the Node types as well. For instance, they can't use process without throwing an error if they don't have the types. I think it's safe to assume they need it and include by default.

Talked with @fiveisprime. We decided it's easiest to just let people manage their own types for this. It's a bit annoying, but there's too many complications around the version. I'm open to changing this decision if we find a popular project generator we can model after or if more users file feedback