Polymer.dom().querySelectorAll() should return an Array

Polymer.dom().querySelectorAll() should return an Array instance in order to be compatible with 1.x. Currently, 2.x returns a NodeList instance when used with native shadow dom

This is a documented breaking change:

Hybrid elements need to keep using the Polymer.dom API. However, note that in 2.0, for native methods and properties that return a NodeList, Polymer.dom APIs also return NodeList, not Array. If you're using any native Array methods on the returned object, you need to update your code.

https://www.polymer-project.org/2.0/docs/upgrade#polymer-dom-apis


Fix V3022 warnings from PVS-Studio Static Analyzer

I'm a member of the Pinguem.ru competition on finding errors in open source projects. A bug found using PVS-Studio. Warnings:
V3022 Expression 'chatMessage.Message.Replace(chatMessage.Message.Split(' ')?[0] + " ", "")' is always not null. The operator '??' is excessive. ChatCommand.cs 28
V3022 Expression 'whisperMessage.Message.Replace(whisperMessage.Message.Split(' ')?[0] + " ", "")' is always not null. The operator '??' is excessive. TwitchClient.cs 901

Good catch, thanks :)


Error sliding from first to last and last to first

Hi @devmark
If you check your example (index.html) and go from the first slide to the last slide you can see how to the last slide not appears correctly.
One trick is execute unFilter after initialize the slick, but is not very elegant...
I checked the jquery version, slick version and a lot of options but i don't have the correct solution.
Thanks!

Could you  make a plunkr to me. Thanks
you can fork from this: http://plnkr.co/edit/9goFW6?p=preview

Sorry @devmark but i can't open plunkr, you can provide another?

it seems plunkr server down.
maybe have a look jsbin, this is create by other ppl.
http://jsbin.com/vufeda/edit?html,js,output

You can see the error in your own code in this screencast of your demo example: https://www.dropbox.com/s/rte1569yb7z167t/angular-slick.mov?dl=0

get your problem.
what browser , angular-slick-carousel you using?

Safari, Chrome, Firefox and IE under Mac and Windows.
Sorry for my poor english.

Hey first of all thank you for this directive but I also have come across this same issue. Its when the infinite is set to true. Can you please try with it on ?

+1 Having the same issue. Navigate through all slides then click next which takes back to the first slide and there comes the issue. You can find the issue even after going back and forth the slides.

will take a look soon.
Thanks for report

I don't know if its the same issue but I see a strange jerk when the the centerMode is set to true. Initially the width of my slick-slide is 201 but after switching to next slide it turns 221 and a slide just comes down which is undesirable.
By the way, thank you for the directive and staying alert to issue reports.

@rana3012 could you make a demo?

Hi.. Sorry for the delay.. I couldn't get a working fiddle but i'm sharing my use case. Please check this fiddle.

https://github.com/kenwheeler/slick/issues/234


Update usebackq info in for.md

Update strings in 'usebackq' alternative forms and remarks about usage to improve accuracy and comprehension

Thanks for your contribution!


Upgrade all the deps

Coverage remained the same when pulling 62ebdf7a0912a662ce4beb9b02592663c7691d84 on requirement-upgrade into a63dbac55741affe7a0514791320ba3dccfd780a on master.


Add Notification

Ex. Email

Thanks for the feedback. You can set up Healthchecks and put the ping URL into HEALTHCHECKS. This way, you will receive emails when there's an error. If you are looking for something else, please let me know. 🙂

@alipay404 Thanks for the feedback. You can set up Healthchecks and put the ping URL into HEALTHCHECKS. This way, you can receive emails (or SMS messages, etc.) when there's an error. If you are looking for something else, please let me know. 🙂

Thanks

@alipay404 Thanks for the feedback. You can set up Healthchecks and put the ping URL into HEALTHCHECKS. This way, you can receive emails (or SMS messages, etc.) when there's an error. If you are looking for something else, please let me know. 🙂

How do I get an IP change

@alipay404 The current design does not notify you of IP changes because that's not an error. Let me re-open this issue because you seem to be requesting a new feature.

@alipay404 Hi, because you are asking for a new feature, I wonder if you could possibly provide more details. In particular, when do you want to receive notifications and what should be the messages? If you have seen this feature in another product, I can take a look. tl;dr: I need more details.

@alipay404 I checked GoDNS and they only mentioned "IP changes". Do you also want to get notifications when something's wrong (e.g., when the updater fails to get the public IP)? Also, do you have a preference between webhooks (you specify the URL and the content) and something like shoutrrr (which might increase the image size)? It is not difficult to implement any of these but I want to implement it in a way that addresses your need (if I choose to implement it after checking the technical detail). 😀
@bartclone if you are willing, any input will be helpful to move this issue forward. Thanks!

@bartclone if you are willing, any input will be helpful to move this issue forward. Thanks!

Sure. A IP change could have effects, that an user wants to be notified of.
So, yes, an interface to a [notification API service] like shoutrr, or Apprise / its API would be nice.

A IP change could have effects, that an user wants to be notified of.

Do you want to get notifications when something went wrong (e.g., not being able to get the IP)?
PS: I would like to check how large the images would be after linking shoutrrr.

A IP change could have effects, that an user wants to be notified of.

@bartclone Thanks for the feedback. Do you want to get notifications when something went wrong (e.g., not being able to get the IP)?
PS: I would like to check how large the images would be after linking shoutrrr.

Maybe introduce a debug level 1-6, to control which messages are sent out?
Like

not getting an IP : level Fatal
which IP is used: Info

@bartclone All logs already have levels. However, the logs are only optimized for the terminal view and imperfect for notifications. (E.g., some messages are intentionally split into multiple lines.) To have the best UI/UX, I believe one would have to manually adjust messages for different targets. I also want a clean configuration interface where every option should ideally have a reasonable meaning independent of other options. I'm worried that it is not immediately clear whether the log level should also affect the messages sent to Healthchecks and the terminal (and maybe replace the option QUIET). I'm hoping to avoid non-trivial interactions between options.
Anyways, to confirm, I believe you don't expect to receive notifications other than (1) IP changes and (2) all kinds of "errors". Is that correct? It might take me a while to go through all the errors the updater is reporting right now, but technically I don't think supporting this is difficult other than the size bloat due to the shoutrrr library.

@bartclone Sorry for the slow progress. Do you think you will ever need to notify multiple targets?

@alipay404 @bartclone I played with shoutrrr a bit and it seems to be a bit large (with respect to the current tiny updater). I'd love to keep the updater tiny but could be convinced otherwise. I wonder if you are already using a popular notification system, for example, gotify, or online services that support notification redirection, such as novu, courier, magicbell, or something like that?

Sorry for the late reply, holidays kicked in ;).
I myself use PushOver, but then again: so many choices, therefor I proposed the broader solution (lots of services to choose).
These days harddiskspace is cheap - although 4Mb is ofcourse large when for example used in IoT/edge.

@bartclone I admit that it's more like an intellectual exercise for me to create the smallest but maintainable DDNS updater with all the features I like. This project was my way of learning Go. I'd like to think through the alternatives---last time I managed to save some bits and improve usability by handcrafting my own parser.
I suppose you don't need the updater to notify multiple places. Is that correct?

@bartclone I think I'm about to give up finding alternative designs. There are two things to decide and one major difficulty to worry about. The two things are:

The environment variable should be SHOUTRRR, right?
The exact messages to send out---in particular, should the tool send out IP changed to X from Y instead of just IP changed to X? Is the additional information useful? The tricky part of implementing this is that the original DNS records could be a mess and I'd like to know whether it's worthwhile to come up with a good description for each case.

The major difficulty is that this feature would take me a while (if I want to add all the test cases and whatnot).

Or maybe just use the ability to a use the API of Apprise.
I took a quick look but Shoutrrr does not seem to provide that?
Apprise also provides a built-in Configuration Manager ...
Using an external service like Apprise (or maybe Shoutrrr?) would limit your codebase.
Ofcourse still needed to define how to call the service, for example running in a another container. That would require URL, API (key for the service), etc etc
On loglevels, see https://sematext.com/blog/logging-levels/
It's always a question what severity/level (and to what extend) a specific event has :). Let's find out.

An IP-change itself could be regarded as: info
An IP-update fails: error
Services cannot be reached: fatal

@bartclone Thank you!

I feel running another server instead of including a library might be a bit too much for the end user. :sweat_smile:
No, I'm not talking about logging levels. I am talking about the actual messages to be sent. There's already a logging system for outputting messages in Docker. However, it is not optimal to recycle logging (recording what the updater is doing) for notifications (telling users about something they may have to act on soon). There are important things that should not be notifications (e.g., whether QUIET mode is used). Logging and notification serve different purposes and messages should be tailored. The question here is whether the old IP should be mentioned.

Unfortunately it is difficult for me to spend enough time on this issue. PRs are welcome. It is not inherently hard to integrate shoutrrr, just lots of testing and checking. I will leave this open for now.

Current plan: These will be notified:

Starting of the program
Configuration errors
Use of deprecated settings
IP detection error (every time!)
IP changes
Successful detection of the same IP after failures
Failures to update DNS records
Exiting of the program

These will not be notified:

Failure to ping monitors

@bartclone In case you are still interested, I wonder if you want the updater to set the title of a Pushover message or you to specify the title by yourself? I'm asking this because it seems the title set by the updater will overwrite what's set by the user (not completely sure).

@bartclone Progress report: I have implemented experimental support of shoutrrr but right now it has bugs: strangely, messages cannot be sent to pushover. If you feel adventurous, you could use SHOUTRRR=<shoutrrr url> with the Docker tag edge. I am still debugging it.

Update: the bug was fixed! However, only the failure to detect IP addresses or update DNS records is currently notified. I'm working on other errors.

This is done now, pending updates on documentation.

:tada: The new feature was released with 1.12.0. Please try it out!


Problem with npm install

so I just download this project and tried to run npm install... Here is the output:
npm ERR! code ERESOLVE
npm ERR! ERESOLVE unable to resolve dependency tree
npm ERR!
npm ERR! While resolving<EMAIL_ADDRESS>npm ERR! Found<EMAIL_ADDRESS>npm ERR! node_modules/vue
npm ERR<EMAIL_ADDRESS>from the root project
npm ERR!
npm ERR! Could not resolve dependency:
npm ERR! peer<EMAIL_ADDRESS>from<EMAIL_ADDRESS>npm ERR! node_modules/@vue/compiler-sfc
npm ERR!   peerOptional<EMAIL_ADDRESS>from<EMAIL_ADDRESS>npm ERR!   node_modules/@vue/cli-service
npm ERR!     peer<EMAIL_ADDRESS>|| ^4.0.0-0" from<EMAIL_ADDRESS>npm ERR!     node_modules/@vue/cli-plugin-babel
npm ERR!
npm ERR! Fix the upstream dependency conflict, or retry
npm ERR! this command with --force, or --legacy-peer-deps
npm ERR! to accept an incorrect (and potentially broken) dependency resolution.
npm ERR!
npm ERR! See /Users/someone/.npm/eresolve-report.txt for a full report.

npm ERR!      /Users/someone/.npm/_logs/2021-02-10T14_31_05_573Z-debug.log

Additional Info:
OS: macOS Big Sur 11.2.1
node: v15.8.0
npm: 7.5.0
I've search around and found this: https://stackoverflow.com/a/64872578/413026
Hopefully this will help.

I have the same issue, npm install --legacy-peer-deps seems to solve it for me.
see https://github.com/team-innovation/vue-sfc-rollup/issues/70 and https://github.com/vuejs/vue-cli/issues/6270

More problems with npm install - same as original question: download, npm install, break
npm ERR! code ERESOLVE
npm ERR! ERESOLVE unable to resolve dependency tree
npm ERR!
npm ERR! While resolving<EMAIL_ADDRESS>npm ERR! Found<EMAIL_ADDRESS>npm ERR! node_modules/eslint
npm ERR!   dev<EMAIL_ADDRESS>from the root project
npm ERR!
npm ERR! Could not resolve dependency:
npm ERR! peer eslint@">= 1.6.0 < 7.0.0" from<EMAIL_ADDRESS>npm ERR! node_modules/@vue/cli-plugin-eslint
npm ERR!   dev<EMAIL_ADDRESS>from the root project
npm ERR!
npm ERR! Fix the upstream dependency conflict, or retry
npm ERR! this command with --force, or --legacy-peer-deps
npm ERR! to accept an incorrect (and potentially broken) dependency resolution.
npm ERR!
npm ERR! See C:\Users\darko\AppData\Local\npm-cache\eresolve-report.txt for a full report.
npm ERR!      C:\Users\me\AppData\Local\npm-cache_logs\2021-11-21T20_55_22_932Z-debug.log


useQuery() hook vulnerable to type errors

Describe the bug
There is a problem with hidden typescript type errors in the useQuery() hook when select is not defined.
Your minimal, reproducible example
Simple 1-line example provided inline
Steps to reproduce
Try compiling the following:
  const queryResult: UseQueryResult<number> = useQuery({
    queryKey: ['key'],
    queryFn: async () => 'not a number',
  });

Expected behavior
This should produce a type error, since queryResult.data will contain a string, contrary to the declared type of number.
But it compiles cleanly with no type errors detected.
A type error will, however, be detected if a no-op selectFn is provided:
  const queryResult: UseQueryResult<number> = useQuery({
    queryKey: ['key'],
    queryFn: async () => 'not a number',
    select: (s) => s,
  });

How often does this bug happen?
Every time
Screenshots or Videos
No response
Platform
N/A
Tanstack Query adapter
react-query
TanStack Query version
v5.40.1
TypeScript version
v5.2.2
Additional context
One possible avenue of attack might be to switch the template arguments to take the type of the select function instead, and try to infer TData from that. For example (where I've simplified to focus just on the types of interest):
interface MyQueryOptions<TQueryFnData = unknown, TSelect = unknown> {
  queryFn: () => Promise<TQueryFnData>;
  selectFn?: TSelect;
}

interface MyUseQueryResult<TData = unknown> {
  data: TData;
}

declare function useMyQuery<TQueryFnData = unknown, TSelect = unknown>(
  options: MyQueryOptions<TQueryFnData, TSelect>,
): MyUseQueryResult<TSelect extends (data: TQueryFnData) => infer TData ? TData : TQueryFnData>;

function thisHasATypeError(): MyUseQueryResult<number> {
  return useMyQuery({ queryFn: async () => 'not a number' });
}

function thisIsTypeCorrect(): MyUseQueryResult<number> {
  return useMyQuery({ queryFn: async () => 'not a number', selectFn: (s) => Number.parseInt(s) });
}

if you know a good way to fix this, please make a PR including type tests. My general recommendation is to use type inference and not slap the UseQueryResult type on your custom hooks. It will also take away some optimizations we do with overloads.


Add support for alloc hint

What was changed in this PR:

Move MemorySegmentManager to VirtualMachine
Wrap MemorySegmentManager & Memory in Arc Mutex
Add method execute_hint, which executes a block of was code (by calling the exported function hint defined within it) (only fully supports alloc for now)
Add tests for execute_hint with alloc

Checklist

[ ] Linked to Github Issue
[ ] Unit tests added
[ ] Integration tests added.
[ ] This change requires new documentation.

[ ] Documentation has been added/updated.

Codecov Report

Merging #174 (1010676) into main (7e1cc36) will increase coverage by 0.02%.
The diff coverage is 93.82%.

@@            Coverage Diff             @@
##             main     #174      +/-   ##
==========================================
+ Coverage   95.03%   95.06%   +0.02%
==========================================
  Files          26       27       +1
  Lines        4657     4724      +67
==========================================
+ Hits         4426     4491      +65
- Misses        231      233       +2

Impacted Files
Coverage Δ

src/vm/errors/runner_errors.rs
0.00% <0.00%> (ø)

src/vm/vm_memory/memory.rs
93.78% <ø> (ø)

src/vm/runners/cairo_runner.rs
98.83% <90.47%> (-0.22%)
:arrow_down:

src/vm/vm_core.rs
97.27% <95.77%> (+0.01%)
:arrow_up:

src/hints/execute_hint.rs
100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7e1cc36...1010676. Read the comment docs.


[Question] Tear Down won't cause test case to fail

Hi, I would like to ask, do it possible to ignore tear down failure? currently if tear down fail and it will mark my test as fail. I would like to have run some steps on tear down stage, but it wouldn't affect the test status no matter the tear down is pass or fail.
I have tried quick google and robot framework doc. But I didn't get something from it. So sorry for asking a lazy question here.

This has also been discussed before in issue tracker. For example #2135. Although that is about suite teardowns, the same logic applies to all teardowns. Questions in general should be asked in the users group.


Drop C++17 support

This PR just uses std::remove_cvref to check which compilers can compile mitama-cpp-result. Removing MITAMA_ERROR and other C++20 migrations will be made in later PRs.

@LoliGothick, we need to remove all required CIs from the branch protection setting.


Overlays

Why
The current Overlay implementation is made for tools, and does not work for more complex overlay content, including popups with Surfaces in it.
What
This PR replaces the former Overlay implementation with a generalized OverlayCanvas implementation. All former 'prompt' tools are replaced with components that acquire the OverlayCanvas when necessary.

There is no test triggering usage of kit/ui/Input which is only used by AddSupplementaryFileWorkflow atm, which seems to be untested.
As this is not the focus of this PR, I will ignore this and add a TODO to Manuscript.test


Modified Moses commit tag in requirements

This PR contains changes related to moses commit tag that was modified and pointing to an older version of moses now which is compatible with Guacamol Baselines.

Closing this pull request as we have to fork moses now to handle version mismatch, I will raising a new pull request with all the changes related to it soon, thank you!!


BugFix: Enterprise edition module activation

Activation in the enterprise edition fails. Only second activation is successful, but duplicate template blocks were registered.
The fcpohelper class exists after first activation and modifies the metadata.php, so that the OXID eShop EE can not fully activate the module because the metadata.php was changed.

Thanks for your contribution! We don't have an Enterprise Edition to test this, so I suppose this is why it slipped through.
I'll let Dev do a quick review and then we'll merge your solution.


Help with flag for switching to another language

Hi @eddiesigner ,
I try to replace the search icon with a flag to switch to another language.
i.e:
On website example.de:

What code do I need to use to replace the search logo one by one and keep the location n desktop and mobile version?
Thanks for your help.
Best
buarle

Hi,
I'm not sure if I understand fully what you mean, if you want to replace the search button with that link you can do the following:

Unzip the theme file

Open the file partials/header.hbs with a code editor

Replace the following code (line 22 - 24):

<button class="m-icon-button in-mobile-topbar js-open-search" aria-label="{{t "Open search"}}">

</button>

with your link:

You also need to replace the following code (line 121 - 123):
<button class="m-icon-button in-menu-main js-open-search" aria-label="{{t "Open search"}}">

 </button>

with your link:

Save your changes

Zip the theme folder and upload it again

You will probably also need to inject some custom styles for your link so the flag image looks better, I can't provide those styles since that depends of your liking, you can use the classes lang-link-mobile and lang-link-desktop for that purpose. You can inject your styles in the Ghost Admin (Settings --> Code injection --> Site Header), for example:

I can't help you with keeping the location after you click that link, that's not that easy to implement, sorry. You can try to find help on StackOverflow or Google.

Hi @eddiesigner ,
thanks already a lot for that.
One more cosmetical thing. When doing this on mobile the flag has kind of a lot positioning within the menu.
You can see that on https://www.praxis-aigner-stadler.de/home/

Is there a way to change that down next to the dark mode switch?
Thanks an best,
Markus

Hi @buarle, sorry for the late response 😅
You can inject the following code in the Ghost Admin:


Taking into account users permissions for editing entries

Feature request
Is it possible to have the "edit entry" button hidden if the user doesn't have permission to edit that entry?
At the moment all users see the button always, even though they don't have permission to edit the entry and clicking on that button leads to error page with following error:
HTTP 403 – Forbidden – yii\web\ForbiddenHttpException
User is not permitted to perform this action
Thanks!

@Djive Thanks for the suggestion! I can't believe I hadn't thought of that in the entire time Admin Bar's been around 😂
I'm a little swamped with client work and other things, but I'll add this check and your other suggestions (thanks for those on Content Stats, too) when I have a chance.

@Djive This is all set in 3.1.7. Thanks again for the idea!


Extraneous guards and checks within taraxa capability should be cleaned up

Is your feature request related to a problem? Please describe.
See comments on PR #941  for example:
 if ((!peer) || (dag_mgr_ && !peer->received_initial_status_ && packet_type != StatusPacket))
In general we have a lot of checks in code just because of tests, which should not be there or at least it should be somehow checked only if we are running tests through some #ifdef TESTS or something like that.

Merged into the https://github.com/Taraxa-project/taraxa-node/issues/854 as it is related to the same topic


Suppress duplicate addresses

If the physical address and correspondence address is the same, can we suppress one of them and the title? Meaning, we'd only surface the address, no disclaimer on whether its for correspondence or physical.

Updated on staging. I removed the "Correspondence/physical address" markers.

Looks good, thanks! Please push to production.


Activate dependabot

Does dependabot works with docker compose? If so, and if it works well with our version numbering scheme, active it on this project.

it seems it does not work ATM: https://github.com/dependabot/dependabot-core/issues/390


Documentation/Changeling: Add ban of getState in reducers to the points

*Changelog, gotta love autocorrect.
Bug
Something so essential should not just be included in the short text, but the supposedly more exhaustive list - preferably close to the top!
Also the ability to disable this ban would be great.
I completely understand why you would ban it, I was very annoyed when I saw the usage of this in the code of my project, but one does not choose the ... legacy code one gets by the people previously on the task, and to be honest while it's a bad behavior there's far worse elsewhere which I'd like to solve first before getting to this.
What is the current behavior?
That information is just in the summary in text form.
What is the expected behavior?
It's in the list.
Which versions of Redux, and which browser and OS are affected by this issue? Did this work in previous versions of Redux?
4.0+

If you want to submit a PR to add this, you can. But using getState isn't very likely when state is provided as the first argument to your reducer function.

Well, that doesn't help if the state you're referencing is outside of the state of the reducer. You could of course merge the reducers, but when you have such a gigantic network of reducers like my project (some madmen moved almost everything into redux, including lots of procedural variables) then merging reducers gets pretty complicated when they're not both in the same superreducer, additionally to leading to gigant reducers (there's already a number of 600er reducers, I don't need even longer reducers).
On the whole there's a lot of problems with the way some (or a lot of) legacy code is build, like also a complete lack of understanding of TypeScript, but I have to say some of the limitations of redux aren't making it easier.
Vuex has computed properties, making having a single source of truth much easier, it has method-style-getters making the modelling and embracing of state-dependant functions which can be reused elsewhere an ease - without bloating the HTML and JSX with a shitton of HOC - , with mutations (=redux actions) and it's - vue - actions it has a built-in principle to model the composition of potentially asynchronous 'actions' that makes at least redux-thunk, which my project uses, look old, you DONT have the problem of how to access outer state without breaking your pattern because their modules are more sensible, the documentation embraces helpful modern syntax thats easy to polyfill, like the spread syntax, and it DOES NOT facilitate a complete fragmentation of management of the same piece of state over multiple files, like lots of redux documentation does.
Do you have any idea how many files you have to touch sometimes to do anything in that mess I have to work with? Between redux, redux-thunk, TypeScript being an afterthought that they sometimes even implemented using freaking d.ts files with interfaces, that are meant for freaking libraries and completely break any interlinking from the IDE because they are redeclared at every corner and type inference is never used, redux-reacts 'container' adding some more bloat... Honestly if you look at all of that, and all the 'good ideas' people throw around that add some more fragmentation, I can't completely fault them for the mess that is the legacy code.
But I can tell you, it certainly doesn't help me getting that stuff straight if everyone wants to play good dictator and cuts one off of the modern versions of the packages because they arbitrarily add bans that are NOT listed in the checklist and instead hidden in the text. Tell you it feels great if after you spend a lot of time getting rid of all the compilation errors you realize upon testing that someone added a ban to a 'feature' frequently used in the code of your project.
I guess I should have read the text too, but not listing that ban in the list is actually pretty comparable to the thing you banned, you're hiding a sideeffect in the text that you'd expect in the list of everything, just like you'd expect all dependencies to be listed in the parameters of a function and not be recieved by store.getState() in the inside.

@9SMTM6 : uh.... that was a long rant, and I'm not quite sure what the point is.
I get that you're frustrated, and I'm sorry to hear that.
That said, calling getState() in a reducer has always been wrong.  You should never have been doing that.  Reducers have always been supposed to be pure functions - just parameters in, result out.

It's not listed in "Changes"
In fact the flow goes like this:
There's a paragraph comparing the changes to react 15 to 16, than there's another longer paragraph I sort of skipped over mostly (as I learnt later that was a mistake), mostly just reading the last sentence that "the full changes are listed below". Than there's a list.
What's not mentioned in that "[list of] full changes" is that you throw if calling getState from the reducer. The ONLY place I found that mentioned is in the 2nd paragraph of the "summary". Where I found it AFTER I upgraded the huge project I'm working on, which wasn't all that easy actually as i.e. something broke the extension of the 'Dispatch' type by redux-thunk, leading to type errors and thus me needing to create a custom type and using that everywhere I used to just use 'Dispatch' as type.
So I put in all the work, the app compiles, then I try to test the app and realize that there's a ban on the usage of getState in reducers. Which btw throws nicely NOT while compiling but in the runtime, making said bans easy to slip past you if you only make some tests.
And yeah, I completely understand that you want to get rid of usage of getState in reducers but

That's not my crap codebase I have to work with, and there's worse issues that both should be addressed first and are easier to fix

If you allowed something in in the past, and replacing usage of that antipattern with something following the official pattern is a pain, then IMAO a ban on that 'feature' - if not essential for further development of the package - should be opt-out.

Even if you HAD a opt out, not listing that change in the "full changes" is a no go, and essentially a worse antipattern than the very thing you just banned.

Honestly there isn't really a good way in your pattern to do A LOT of stuff, including accessing the state of other reducers, when there would be an easy way to do that, just by adding an optional 3rd parameter to the reducers with the global state. If you don't use the 3rd parameter it's a classical reducer, but at the same times it allows you more freedom without having to revert to painful methods like duplicating state or merging reducers (said reducers sometimes being at completely different places in the reducer-tree). You should really take a look at some of the stuff Vuex (flux type state management for Vue) does, it's far superior to redux IMAO, maybe you could include at least SOME of their tricks in your pattern.

I guess I'll add a PR later when I'm not on mobile, at work or sleeping, but I honestly wonder how that slipped past.
It's especially annoying too that when you search the issue nearly all the discussions are referencing the 'redux-devtools-extension' as cause which apparently had the same ban (and got rid of it again?).

I dont think I can make a pull request to edit releases on github.
Recommended change:
Exchange:
* Throw if getState, subscribe, or unsubscribe called while dispatching

for
* Throw if getState or subscribe are called in the reducer or while dispatching

Alternative:
* Throw when using getState, subscribe or unsubscribe
    * in the reducer
    * while dispatching an action

It literally says that at the top of the release message

The major changes (#1342) are around our TypeScript definitions, bundled CommonJS and ES builds, throwing if you subscribe or getState from a reducer, and a bunch of other smaller things. The full changes are listed below.


chore(deps): bump https://github.com/jenkins-x/jx-cli to 3.0.134

Update jenkins-x/jx-cli to 3.0.134
Command run was ./promote/main

[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by:
To complete the pull request process, please assign pmuir
You can assign the PR to them by writing /assign @pmuir in a comment when ready.
The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment


add extract_kraken_reads.py and 3rd party license fix #4

Need to add version in the script or commit for tracibility


Add DataFrame#method_missing to get column vector by method

This is a solution for #74 .

#68
df.assign(:key) { %w[v a l u e s] }


Use multiple reporters?

Hi.
We would like to use both the junit reporter (for info in jenkins) and the livehtmlreporter (for screenshots and a better overview when debugging.
Is it possible to add several reporters easily? I'm not very fluent in F# so apologies if this is trivial.

For this you would have to make your own reporter (implement IReporter) and inside of it have 1 instance of jUnit reporter and 1 instance of livehtmlreporter and for each calls just make the same call for both of your other reporters.
Just a wrapper.
You can see how reporters are done here:
https://github.com/lefthandedgoat/canopy/blob/master/src/canopy/reporters.fs

That was my assumption. I was hoping for something easier, but i guess that'll do.
Thanks for the quick reply.


Connect nextflow pieces.

The last step for running a pipeline is to connect the following pieces:

[ ] pipeline.nf with pipeline_blast.nf
[ ] pipeline.nf with bam_to_coverage.nf
[ ] pipeline.nf with overview.nf

@bosterholz I found a way to connect pipeline.nf with pipeline_blast.nf by using channels:
...
uniq_lines = Channel.create()
fastaFiles.flatMap{ file -> file.readLines() }.into(uniq_lines)
...

But there are still errors but think they are results from the test data set.
Could you check this in branch:
https://github.com/metagenomics/bioPipeline/tree/feature/connect-hmm-folder-scan-and-blast

Example log:
N E X T F L O W  ~  version 0.15.3
Launching pipeline.nf
[warm up] executor > sge
[5c/cff6ff] Submitted process > hmmFolderScan (1)
[0a/f9b0a3] Submitted process > uniqer (1)
[0f/29b77d] Submitted process > getFastaHeader (1)
Error executing process > 'getContigSeq (1)'

Caused by:
  No such property: db_file for class: Script55FDA6060FDC66F81296D1D9CEB6D228

Source block:
  '''
  #!/bin/sh
  buffer=$(cat uniq_header | cut -c 2-)
  contig=$(echo $buffer | cut -d" " -f1)
  awk -v p="$buffer" 'BEGIN{ ORS=""; RS=">"; FS="\\n" } $1 == p { print ">" $0 }' "!{db_file}" > !{baseDir}/$contig.faa
  awk -v p="$buffer" 'BEGIN{ ORS=""; RS=">"; FS="\\n" } $1 == p { print ">" $0 }' "!{db_file}" > uniq_seq
  awk -v p="$buffer" 'BEGIN{ ORS=""; RS=">"; FS="\\n" } $1 == p { print ">" $0 }' "!{db_file}" > uniq_seqHtml
  '''

Ok I fixed and pushed it to the mentioned branch. But the last process seems not to end:
N E X T F L O W  ~  version 0.15.3
Launching pipeline.nf
[warm up] executor > sge
[ab/a4fdd5] Submitted process > hmmFolderScan (1)
[c0/1b08c7] Submitted process > uniqer (1)
[8f/9fda2f] Submitted process > getFastaHeader (1)
[df/436c2d] Submitted process > getContigSeq (1)
[59/dd23f7] Submitted process > blastSeqTxt (1)
[04/9d93c5] Submitted process > blastSeqHtml (1)


Update onboarding for 2021-08-04 release

Docs Build status updates of commit 67b2caf:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

package.json
:white_check_mark:Succeeded

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching the docs.microsoft.com contributor guidesPost your question in the Docs support channel


About evaluation metric

Is there any implementation code for the Content Feature Structural Distance (CFSD) mentioned in this paper？

Yes, you can implement CFSD using the eval_artfid.py file. The specific implementation code for CFSD mentioned in the paper can be found at the following link:
https://github.com/jiwoogit/StyleID/blob/3c2995f467c3cb7ea029a858ef5a79651488e373/evaluation/eval_artfid.py#L420

Thanks！


cli: server logging improvements

https://github.com/cockroachdb/cockroach/pull/70388 --- Release note (cli change): The default logging configuration now redirects the HEALTH logging channel to a distinct log file (cockroach-health.log).  NB: This choice was informed by a preference of users for separate log files in the default configuration. As a result, the decision to deprecate the default configuration into separate log files is hereby reversed.

handled in #11717


Frustrum culling

Don't draw objects when not in the view frustrum. Somewhat related to #81.
Notes:

Note that shadows can still be cast inside the frustrum.
Multiple frustrums can be combined and vectorized using the new linalg.

When rendering, the rendering camera frustrum and all shadow camera frustrums should be evaluated together (first test which shadow camera frustrums intersect the rendering frustrum) against all bounding volumes in the scene, so that the set of objects can be computed that affects the visual end result.

There will be objects that don't need culling (e.g. backgrounds), and objects for which we cannot know the bounding volume; these should be excluded from the test and always be selected for rendering.

Some relevant discussion was had here: https://github.com/pygfx/pygfx/pull/498#issuecomment-1500008594

Found this WGSL compute shader based visibility culling implementation: https://github.com/khudiiash/webgpu-renderer/blob/main/src/renderer/shaders/chunks/compute/culling.wgsl


Open Project Links in New Tab on AOSSIE Website

Description:
Currently, when clicking on the project cards in the Projects section of the AOSSIE website, the links open in the same tab. For a better user experience, these links should open in a new tab instead.
Steps to Reproduce:

Navigate to the AOSSIE website.
Scroll down to the Projects section.
Click on any of the project cards.

Expected Behavior:
The project links should open in a new tab.
Actual Behavior:
The project links open in the same tab, taking the user away from the AOSSIE website.
Proposed Solution:
Update the anchor tags associated with the project cards to include the target="_blank" attribute, which ensures that the links open in a new tab.
Additional Information:
This change will enhance user experience by allowing users to explore the project details without losing their place on the AOSSIE website.

@ceilican i would like to work on this issue

I would like to work on this issue

@ceilican i would like to work on this issue. Please assign this to me

Is this issue still open?


Request: To be able to choose the lang

Hello,
I'm using ur docker since long time, since I use unraid.
I'd like to ask: would it be possible to change de default language used to rename ?
To set it with en ENV variable like the others parameters, for example.
Same in this one
FILEBOT_LANG | Set your language | optional | fr
Thank you

This is now implemented in latest Docker image (v1.13.0), vi at the AMC_LANG variable.
The unRAID template also has a dedicated setting.


Kudo All stopped working

Clicking the button "Kudo All" will change the button description to "Everything Kudoed", but nothing else will happen.
Win 11, last Chrome. I think it hasn't worked since the last Chrome update.

Not working for me either on MacOS on Chrome or Safari.

Firefox on Windows 11 also not working. Maybe Strava changed something?

Same here.  Brave.  Uninstalled and re-installed Sauce.  Had a windows update, ran that, rebooted, still no go.  I bet Strava did something!

Firefox extension just updated to v 8.2.0 and all is working now :-)

Firefox extension just updated to v 8.2.0 and all is working now :-)

Good to know.  Brave is still on 8.1.3.  I'm sure it will come out soon enough.  Thanks!

Today updated to 8.2.0, working. Thanks!

Yes. :-(

Looks like with 8.2.1. it's working again :)

v8.2.3 on Chrome/Mac and it does not work

Not working for me too with extension version 8.2.3 on Mac (13.5), Chrome version 115.0.5790.114.

Broke on Linux with Firefox as well. Reckon Strava changed something again.

Mac OS and iPhone IOS not working.  Almost a week.  Sent an email and got no response.

Fixed via #167

Does this mean it’s fixed?  Net working here. Sent from my iPhoneOn Aug 7, 2023, at 6:07 PM, Justin Mayfield @.***> wrote:
Closed #152 as completed.
—Reply to this email directly, view it on GitHub, or unsubscribe.You are receiving this because you commented.Message ID: @.***>

And Safari?Sent from my iPhoneOn Aug 8, 2023, at 4:29 AM, Dominik Rappaport @.***> wrote:
@Coachbur So far, just the source code was patched but the plugin in Chrome's repo has not yet been updated.
—Reply to this email directly, view it on GitHub, or unsubscribe.You are receiving this because you were mentioned.Message ID: @.***>


App crashes if logged in but refresh token revoked on the server side

Hi there,
I might have found a bug or "missbehaviour" on the Android App.
I was cleaning up the "Refresh Tokens" list and doing that I also removed the one for the Android App.
What I noticed from that is that my Chrome Home linked site was banned right after and once the ban was removed I was able to login again.
On the Android App it doesn't open anymore, or to better say, it does open but it crash right after.
I am about to send the feedback via phone and I will add in the description this GitHub ticket number to give some background information.
I am running HA in Python Env on the latest stable version 0.102.2 on an Intel NUC with CentOS 7
Hope it helps :)
Cheers
Andrea

If we refresh the token and we get a 400 status back, we should check the response in JSON. It is in the format { "error": "<error_code>"}. If <error_code> is invalid_grant, we should log the user out.

Not sure the fact this issue was closed meant it was part of yesterday's release, if so, it isn't working.
To have the problem fixed I literally had to uninstall and reinstall the App, so that the initialization started again.


chore: update Kubernetes Windows packages

What type of PR is this?
/kind feature

What this PR does / why we need it:
update Kubernetes Windows packages
Which issue(s) this PR fixes:

Fixes #
Requirements:

[x] uses conventional commit messages

[ ] includes documentation
[ ] adds unit tests
[ ] tested upgrade from previous version

Special notes for your reviewer:
Release note:
none

Pull Request Test Coverage Report for Build<PHONE_NUMBER>9
Details

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 71.005%

Totals

Change from base Build<PHONE_NUMBER>5:
0.0%

Covered Lines:
2564

Relevant Lines:
3611

💛  - Coveralls


serve multiple artifacts?

I made a version which can serve multiple artifacts from a new src\artifacts folder https://github.com/IntranetFactory/claude-artifacts-runner/tree/routes/src/artifacts
Please let me know if I should create a PR for that.

Hi @IntranetFactory, thanks for your proposal.
I installed your version and tested your demo components. I think it's a good idea, as it gives the developer more flexibility and can even create a simple multipage app just by linking from one page to another. Each page could be generated independently by Claude on its website and dropped into the artifacts folder. I like it 😃
If you would like to submit a PR, please include instructions in the Readme on how to view the artifacts in the browser, as the user will probably have no idea what the predefined routes are.
Better yet, how about replacing the default component with a page that has links to the other demo components?
The Readme instructions on how to include a new artifact should be changed too.
If you don't have the time to make these changes, you can submit what you have, and I'll take it from there.

Hi @IntranetFactory,
It's been over a month, so I assume you either forgot about this or haven't had the time to create the pull request.
I recently found some free time to dive into this project, so I decided to proceed and merge it myself. I used your routing code but opted for a simpler two-page demo instead of your demo components. The goal is to demonstrate functionality and navigation between components, and the provided code will ultimately be replaced by the developer, so it's not necessary to add many demo components.
Thank you for proposing this enhancement; it saved me time. I've added an acknowledgment for your contribution in the Acknowledgements section.
Best regards,
Cláudio

I'm sorry, I forgot to create the PR. I also continued - and added options to user other LLMs (like OpenAI) to generate artifacts and to edit the generated React  https://claude-artifacts-runner.pages.dev/ https://github.com/IntranetFactory/claude-artifacts-runner

I'm glad to hear that this project was useful for your component generator. It's a great idea, but since it falls outside the scope of this project, which focuses on Claude Artifacts, it makes sense to develop it as a separate project.
I'm also working on some similar ideas and will be publishing them as separate projects.
Good luck with your work!


Immediatlely crashes, no report as to why.

Ive installed all prerequisites. Restarted my pc, and on initial launch it says "setting up xbox 360 controller". then it crashed and does so every time i try to run it.

Try the troubleshooting steps listed at https://github.com/fqlx/XboxKeyboardMouse/issues/76 and let us know if that resolves

Try out the new installer via the home page readme, and report back if you still have issues.  Closing issue for now.


Feature/update dev build

Description
This commit adds the use of .env file for docker-compose up so that developer's own environment variables would not be accidentally pushed to the repository. Also makes it easy to handle your own development environment.
Type of change

[ ] Bug fix (non-breaking change which fixes an issue)
[x] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[ ] This change requires a documentation update (this needs a follow up PR)

Changes Made
Docker-compose file changed to use variables from .env file.
Adds .env.example file to copy it to user's local .env file.
Updates README with instructions.
Updates .gitignore to ignore .env file
Additional changes:
Update README with instructions on Python requirements.
Update pre-commit script to execute tests even if .tox folder does not exist.
Testing

[ ] Unit Tests
[ ] Integration Tests
[x] Tests do not apply
[ ] Needs testing (start an issue or do a follow up PR about it)

this might also imply changes in the https://github.com/CSCfi/metadata-submitter-frontend/blob/master/.github/workflows/e2etests.yml#L38 line so before we merge this we need to update that as well


Specify Coin Flip Player If Needed

One small concern, I'd probably put this as third parameter before the closures.

I think it'll be better to put the player parameter as third for all coinFlip functions.

Yeah, I suppose that should be fine. Groovy is better about handling optional parameters than I thought.

The problem is I merged https://github.com/axpendix/tcgone/pull/23 so the implementation changes need to change again 😬 sorry

Force-pushed because I committed a dumb while trying to fix another dumb. Sorry.


mac-14 lost external connection from phone device.

Type of Request
bug
Infrastructure Environment
LUCI, Github, Cocoon scheduler, Autosubmit, etc...
What is happening?
mac-14 lost external connection from phone device.

Steps to reproduce
Step 1:
Step 2:
..
Step n:
Expected results
I expect to see X when Y is finished.

Rebooting both machine and phone device to restore connection.


Bug: Unable to use otto with abc

Unable to use the otto transform when using ABC to sync data from MongoDB to Elasticsearch.
Relevant info:
ABC Version: 0.6.6
How it's being used:
var source = mongodb({"uri":"mongodb://URI:27017,URI-2:27017/collection?authSource=admin","timeout":"","ssl":true,"cacerts":null,"tail":true,"wc":0,"fsync":false,"bulk":false,"collection_filters":""})

var sink = elasticsearch({"uri":"https://URI/index","timeout":"","aws_access_key":"","aws_access_secret":"","tail":true,"request_size":1048576,"bulk_requests":1})

otto({"filename":"./transform.js"})

where the transform file looks like
module.exports=function(doc) {
    doc["data"]["tid"] = doc["data"]["_id"]["$oid"]
    return doc
}

Error stack trace:
panic: runtime error: invalid memory address or nil pointer dereference
[signal SIGSEGV: segmentation violation code=0x1 addr=0xd0 pc=0x74ba1c]

goroutine 1 [running]:
github.com/appbaseio/abc/private/pipeline.NewPipeline(0x12bfa92, 0x5, 0x0, 0x12ff678, 0x12a05f200, 0xc420013780, 0x16, 0x0)
    /Users/siddharthlatest/.gvm/pkgsets/go1.9/global/src/github.com/appbaseio/abc/private/pipeline/pipeline.go:90 +0xbc
main.(*Transporter).run(0xc4203f6520, 0x16, 0x0)
    /Users/siddharthlatest/.gvm/pkgsets/go1.9/global/src/github.com/appbaseio/abc/cmd/abc/goja_builder.go:115 +0x9d
main.execBuilder(0xc420013780, 0x16, 0xc420145e00, 0x1, 0x1)
    /Users/siddharthlatest/.gvm/pkgsets/go1.9/global/src/github.com/appbaseio/abc/cmd/abc/appbase_import.go:143 +0xa8
main.runImport(0xc42000e0b0, 0x7, 0x7, 0x6, 0xf9c03b)
    /Users/siddharthlatest/.gvm/pkgsets/go1.9/global/src/github.com/appbaseio/abc/cmd/abc/appbase_import.go:123 +0xeee
main.main()
    /Users/siddharthlatest/.gvm/pkgsets/go1.9/global/src/github.com/appbaseio/abc/cmd/abc/main.go:46 +0xe6

This was a config issue. The transform works.


readme: add github status badges for tests

docs: https://docs.github.com/en/actions/monitoring-and-troubleshooting-workflows/adding-a-workflow-status-badge

Motivation for this was https://github.com/GoogleChromeLabs/chromium-bidi/pull/344. The CI says one of the tests has failed, however upon inspecting the diff the formatting seems to be a no-op. It should be easier to identify committed failures in the future if they are explicitly listed in the README.md


slide dynamic height

height of every slide is not set dynamic
this take longest height from slides and applied to all slide

Feel free to do a PR about this


Automated cherry pick of #6119

Cherry pick of #6119 on release-5.27.
/cc  @mkraft

Will try to auto merge this PR once all tests and checks are passing. This might take up to an hour.

Trying to auto merge this PR.

Pull Request successfully merged
SHA: ba456131b516502715a106b4359c76d352098f48


Improve tests by using TestContainers

Testcontainers-go should be used to clean the tests and avoid having to start the supporting services (LocalStack and Redis) manually.

Under review: https://github.com/massenz/go-statemachine/pull/63

Merged #63 and released in 0.7.1


Feature: Playlist note

Would it be possible to extend the project to include playlists either as m3u files or all media on the same note.

supported in v3.1.0


Workload allowed to be created with invalid name

Bug description:
Cartographer allow to create workloads with names that does not complain with all possible components in the supply chain, being able to create a workload with name with dot(.) in it, but failing when try to create a knative service using it as CNR.
Steps to reproduce:
Having a TAP 1.0.0 cluster configured with full profile  and using tanzu apps plugin to create resources in the supply chain:

Create a yaml file (tanzu-java-web-app-2.6.yaml) with name containing dots (.)

apiVersion: carto.run/v1alpha1
kind: Workload
metadata:
  name: tanzu-java-web-app-2.6
  labels:
    app.kubernetes.io/part-of: tanzu-java-web-app
    apps.tanzu.vmware.com/workload-type:  web
spec:
  source:
    git:
      url: https://github.com/odinnordico/tanzu-java-web-app
      ref:
        branch: spring-boot-2.6

Create the workload without setting the name in the cli: tanzu apps workload create -y --tail --wait --tail-timestamp -f tanzu-java-web-app-2.6.yaml
Wait for some minutes while the workload is processed, then inspect the corresponding app created: kubectl get apps.kappctrl.k14s.io

NAME                                   DESCRIPTION                                                                                SINCE-DEPLOY   AGE
tanzu-java-web-app-2.6   Reconcile failed: Deploying: Error (see .status.usefulErrorMessage for details)   3s
  25m

Check the Useful Error Message:  kubectl describe apps.kappctrl.k14s.io tanzu-java-web-app-2.6

Useful Error Message:  kapp: Error: Applying create service/tanzu-java-web-app-2.6 (serving.knative.dev/v1) namespace: default:
  Creating resource service/tanzu-java-web-app-2.6 (serving.knative.dev/v1) namespace: default: admission webhook "validation.webhook.serving.knative.dev" denied the request: validation failed: not a DNS 1035 label:
  - a DNS-1035 label must consist of lower case alphanumeric characters or '-'
  - start with an alphabetic character
  - and end with an alphanumeric character (e.g. 'my-name',  or 'abc-123', regex used for validation is '[a-z]([-a-z0-9]*[a-z0-9])?')

List the available workloads:  tanzu apps workload list

NAME                                  APP                              READY   AGE
tanzu-java-web-app-2.6   tanzu-java-web-app   Ready   26m

Expected behavior:
Cartographer should not allow to create resource with names which are not aligned with itself, this creation intent must be rejected with an useful error
Actual behavior:
Resource with not aligned name is created but fails in following supply chain steps
Logs, k8s object dumps:
Versions:

Infrastructure: GKE
cartographer version: 0.1.0
k8s version: 1.21
cnrs version: 1.1.0
knative version 1.0.1

Deployment info:
Check Steps
Additional context:

Considering two options:

Become more strict in accepting the name (alphanumeric and dashes?)
Throw a warning in status

Hey @odinnordico , thanks for reporting!
I was trying to gather some more context here, and end up looking at what knative is making use of for that check - https://github.com/knative/serving/blob/d5d489c0babd5c9ae9a37d707c06df92d70711f5/vendor/knative.dev/pkg/apis/metadata_validation.go#L37-L47 seems quite relevant.
Given that the name of the Workload/Deliverable/etc is made part of the children labelset
https://github.com/vmware-tanzu/cartographer/blob/ba558d67e10073a926205e0d0f86f201cf34a981/pkg/realizer/workload/component.go#L87-L94
it might be worth at least performing such validation in the name to prevent further problems w/ setting them in labelsets (although +1 on having a bigger discussion on to what degree we should be strict about it)

PR sent out months ago. Was held for possible breaking changes. Need to review at next pre/IPM.

Block on upgrade documentation to describe potential breaking change.

We should be following - https://kubernetes.io/docs/concepts/overview/working-with-objects/names/#dns-label-names

Acceptance Criteria:
[ ] Check behviour is only on 'Edit' for workload/template
[ ] Document in OSS docs for template/workload
[ ] Check code for pre/post upgrade awareness
[ ] Document what happens on upgrade, and how to deal with it if you upgrade without patching first


UI out of screen

Description: When you open the game the UI is out of the screen until you maximize the game.

Build: v<IP_ADDRESS>

Type: UI

Steps to reproduce: Open the game

Frequency: Always

Fixed by @cumus


storage: avoid storing a reversed epoch for full key

Is your feature request related to a problem? Please describe.
Currently, we store u64::MAX - epoch in the full key encoding. Initially, we do this to ensure that if we sort the key by dictionary order, the full key with a newer(greater) epoch comes first. However, such feature only works when the length of the keys are fixed. But currently, our keys are in variant length, and we can no longer simply compare the keys by dictionary order. We have to extract the epoch out, and then compare the epoch. Reversing the epoch seems unnecessary.
Describe the solution you'd like
We can store the epoch directly in the full key as the last 8 bytes instead of u64::MAX - epoch.
Describe alternatives you've considered
No response
Additional context
No response

Do you mean to do this after #5960?


Enable FilePropertyFactory to be used with configuration cache

This also allows reverting a workaround in PropertyHost as it used to be
serialized when running JavaToolchainUpToDateIntegrationTest

@bot-gradle test RFM

OK, I've already triggered ReadyForMerge build for you.


STAR-1904: Take into account primary key size for batch size guardrail

The size of a mutation does not consider the primary key size. In the context of BATCHed mutations, this means that INSERTs, DELETEs, and UPDATEs for tables with a simple PRIMARY KEY and no clustering columns would be equal to zero. Consequently, the batch_size_fail_threshold_in_kb has no effect for such tables, and it cannot protect the cluster from being overloaded.
This patch modifies the batch size calculation formula to consider the primary key size.
The issue was originally fixed in DSE 5.1/6.8 under https://datastax.jira.com/browse/DSP-23913.

Tests are in progress: https://jenkins-stargazer.aws.dsinternal.org/job/ds-cassandra-pr-gate/view/change-requests/job/PR-958/1/.

It seems butler is finally happy https://github.com/datastax/cassandra/commit/553fbb36fcfeb9e440a668bbcac4577baad80a6b#commitcomment-138115776

Thinking about this some more, I am worried some about this immediately breaking a bunch of users workloads without any warning.  I wonder if we should track the primary key size in a separate counter and then based on a -D decide to use it for the failure decision.  If it is not used in the failure calculation, but it would put over threshold, then a warning could be emitted.  That way anyone who has tuned their workload to be just under the threshold using the current calculation would not start failing immediately on upgrade...  But could see the WARN and either lower their batch size or raise their threshold based on the new calculation.

Thank you that's a good point and yes, that's the disadvantage of this patch, it lacks backward compatibility. Workloads that executed fine without warning or errors now might be emitting warnings or even be rejected at all.
As you suggest we could add a flag that by default would be false meaning that in case the new formula yields value over the error threshold it will gracefully tell us about it in an additional log message. Changing the flag value to true would be equivalent to the current behaviour of this patch.
The downside of this approach would be that:

The guardrail will not work correctly by default.
We introduce a flag that's going to be difficult to remove in the future.
Alternatively, we might consider documenting (in release notes or upgrade guidelines) that if it's a non-backward compatible change the value of the batch guardrail should be adjusted accordingly.

Alternatively, we might consider documenting (in release notes or upgrade guidelines) that if it's a non-backward compatible change the value of the batch guardrail should be adjusted accordingly.

Nobody knows how big to set it to.  So release notes don’t really help.  We should never make a change in a patch release that can knowingly break an existing working workload.
another option would be to make a brand new guardrail “batch size with key” or something which defaults to -1 and then someone who cares can turn that on knowing they may need to tune their apps after doing so.


Added cli team and admin creation

When setting up a new test machine, the database contains test accounts
after make test was run.
Due to that, Mattermost will not display the team creation screen on
make run, but rather the login screen.
In order for the developers to log in, they need to create a team and
an admin account first.
This change documents the steps on how to do that using the platform
cli.

As per chat with @coreyhulen in https://pre-release.mattermost.com/core/channels/developers on April 23rd


Properly configure OSWASP Zap

Currently OSWASP Zap will stuff forms with three hundred different submissions which will flood some unprotected forms. We should either remove form submissions, or flag the CSS selectors for those forms.
There is a https://github.com/cds-snc/automatic-website-scanning/blob/main/oswasp_zap_rules.tsv here, also we could configure the options file per run, by just creating another action.

https://github.com/cds-snc/automatic-website-scanning/commit/e51bc5a7df37157b128d0ded79cee73fa252cb69

Added urls exclusions for:

support
contactus
contact
careers
carrieres


additional informaition for audit acl's

Would like more information/example for audit ACL
U:F:user1@contoso.com:rwatTnNcCy

Document Details
⚠ Do not edit this section. It is required for learn.microsoft.com ➟ GitHub issue linking.

ID: 02fd9645-364a-aecf-672b-6d8e4c2f7bf0
Version Independent ID: 4541b502-b979-fa28-5946-37c68058c55d
Content: Understand NFSv4.x access control lists in Azure NetApp Files
Content Source: articles/azure-netapp-files/nfs-access-control-lists.md
Service: azure-netapp-files
GitHub Login: @b-ahibbard
Microsoft Alias: anfdocs

@cccsss01
Thanks for your feedback! We will investigate and update as appropriate.

@b-ahibbard
Can you please check and add your comments on this doc update request as applicable.

@cccsss01
I'm going to assign this to the document author so they can take a look at it accordingly

Thanks for opening this ticket. We've revised the section to emphasize that administrative flags have no function in Azure NetApp Files.
#please-close


Fix handling of &r in the legacy component deserializer

Fixes this issue https://i.imgur.com/OjGTwa6.png

Thanks, @lucko.


Replaces SBCL specific code with UIOP calls

This PR makes it so that other compilers like CCL can dump an image of Lurk

@mariari Did you test this? I don't think UIOP:QUIT is supposed to take the keyword argument.

@mariari Did you test this? I don't think UIOP:QUIT is supposed to take the keyword argument.

Sorry, I misread the argument list SLY gave me, it should be tested now
./sbcl-compressed.image
Lurk REPL [API].
:help for help.

API> :quit


Requests verify kwarg must be True or False.

This is the first step to addressing issue https://github.com/StackStorm/st2/issues/2242 (InsecurePlatformWarning).
This patch along with putting the following into ~/.st2/config will allow for a successfully verified request in the CLI.
# The FQDN must match the Common Name in the cacert
url = https://st2.mydomain.com:9101
[auth]
# The FQDN must match the Common Name in the cacert
url = https://st2.mydomain.com:9100
[general]
cacert  = /etc/ssl/st2/st2_ca.crt

Note, even if you configure the chatops user's .st2/config the requests fail to verify via action_alias, chatops request.

Thanks for submitting! You'll need to update the tests as well, please take a look at the Travis log: https://travis-ci.org/StackStorm/st2/builds/96229500.
I have some reservations about passing True instead of CA path, but since we push the CA into the cert store anyway, it should be good.

I have some reservations about passing True instead of CA path

I think you may be right actually.  Setting to True makes the configuring the cacert path mute.
For my GeoTrust signed cert, though I have to set cacert = /usr/share/ca-certificates/mozilla/GeoTrust_Global_CA.crt for the verification to work otherwise.  If no cacert is specified, the verify kwarg reverts to False.
But because the requests module doesn't actually use the local ca-cert store, self-signers need a way to specify a cacert. So you need to pass a path.
Furthermore, I have a separate hubot server, and when I have all my configs in order for my chatops user, they don't seem to work anyway.  My action_aliases still return the InsecurePlatformWarning warning in chat.  I think it may be better to move these configs to a global config.


rocminfo can't find libhsa-runtime64.so.1

$rocminfo

rocminfo: error while loading shared libraries: libhsa-runtime64.so.1: cannot open shared object file: No such file or directory

$/opt/rocm/opencl/bin/clinfo
dlerror: libhsa-runtime64.so.1: cannot open shared object file: No such file or directory
dlerror: libhsa-runtime64.so.1: cannot open shared object file: No such file or directory
ERROR: clGetPlatformIDs(-1001)
$/opt/rocm/bin/rocminfo
/opt/rocm/bin/rocminfo: error while loading shared libraries: libhsa-runtime64.so.1: cannot open shared object file: No such file or directory
lib-hsa-runtime64.so.1 is already exist /opt/rocm/hsa-amd-aqlprofile/ but can't use.

This is probably a duplicate of this issue:
https://github.com/RadeonOpenCompute/ROCm/issues/1129
Please provide info about your distro, distro version, kernel version, which ROCm version you installed, what is your GPU, and do you use upstream kernel amdgpu, or the one from ROCm (rock-dkms rocm-dkms).

Kernel and distro is 5.4.0-54-generic Ubuntu-18.04.1
and CPU:Ryzen5 1400
GPU:RX580 and RX470(2GPUs)
ROCmVer is <IP_ADDRESS>900-17
and I installed rocm from rocm-dkms,rocm-dev
~$ dpkg -l | egrep -i "roc[mkr]|hip|clinfo|opencl"
ii  clinfo                                                      <IP_ADDRESS>.26-1                                   amd64        Query OpenCL system information
ii  comgr                                                       <IP_ADDRESS>-rocm-rel-3.9-17-0fa438b                amd64        Library to provide support functions
ii  hip-base                                                    3.9.20412-6d111f85                               amd64        HIP: Heterogenous-computing Interface for Portability [BASE]
ii  hip-doc                                                     3.9.20412-6d111f85                               amd64        HIP: Heterogenous-computing Interface for Portability [DOCUMENTATION]
ii  hip-rocclr                                                  3.9.20412-6d111f85                               amd64        HIP: Heterogenous-computing Interface for Portability [ROCClr]
ii  hip-samples                                                 3.9.20412-6d111f85                               amd64        HIP: Heterogenous-computing Interface for Portability [SAMPLES]
ii  hsa-rocr-dev                                                1.2.30900.0-rocm-rel-3.9-17-75f9b74a             amd64        AMD Heterogeneous System Architecture HSA - Linux HSA Runtime for Boltzmann (ROCm) platforms
ii  libresid-builder0c2a                                        2.1.1-15ubuntu1                                  amd64        SID chip emulation class based on resid
ii  miopengemm                                                  <IP_ADDRESS>7-rocm-rel-3.8-30-b51a125                amd64        A tool for generating OpenCL matrix multiplication (GEMM) kernels
ii  ocl-icd-libopencl1:amd64                                    2.2.11-1ubuntu1                                  amd64        Generic OpenCL ICD Loader
ii  ocl-icd-libopencl1:i386                                     2.2.11-1ubuntu1                                  i386         Generic OpenCL ICD Loader
ii  ocl-icd-opencl-dev:amd64                                    2.2.11-1ubuntu1                                  amd64        OpenCL development files
ii  opencl-c-headers                                            2.2~2018.02.21-gb5c3680-1                        all          OpenCL (Open Computing Language) C header files
ii  rccl                                                        2.10.0-112-g250d820-rocm-rel-3.5-30              amd64        Optimized primitives for collective multi-GPU communication
ii  rock-dkms                                                   1:3.9-17                                         all          amdgpu driver in DKMS format.
ii  rock-dkms-firmware                                          1:3.9-17                                         all          firmware blobs used by amdgpu driver in DKMS format
ii  rocm-clang-ocl                                              <IP_ADDRESS>-rocm-rel-3.9-17-50fb51a                 amd64        OpenCL compilation with clang compiler.
ii  rocm-cmake                                                  <IP_ADDRESS>-rocm-rel-3.9-17-1d1caa5                amd64        rocm-cmake built using CMake
ii  rocm-dbgapi                                                 0.36.0-rocm-rel-3.9-17                           amd64        Library to provide AMD GPU debugger API
ii  rocm-dev                                                    <IP_ADDRESS>900-17                                   amd64        Radeon Open Compute (ROCm) Runtime software stack
ii  rocm-device-libs                                            <IP_ADDRESS>7-rocm-rel-3.9-17-db8c0c3                amd64        Radeon Open Compute - device libraries
ii  rocm-dkms                                                   <IP_ADDRESS>900-17                                   amd64        Radeon Open Compute (ROCm) Runtime software stack
ii  rocm-gdb                                                    9.2-rocm-rel-3.9-17                              amd64        ROCgdb
ii  rocm-opencl                                                 3.6Beta-14-g0c40e05-rocm-rel-3.9-17              amd64        OpenCL: Open Computing Language on ROCclr
ii  rocm-opencl-dev                                             3.6Beta-14-g0c40e05-rocm-rel-3.9-17              amd64        OpenCL: Open Computing Language on ROCclr
ii  rocm-smi                                                    1.0.0-206-rocm-rel-3.9-17-ge39c0e2               amd64        System Management Interface for ROCm
ii  rocm-smi-lib64                                              <IP_ADDRESS>-rocm-rel-3.9-17-8f9f943                  amd64        AMD System Management libraries
ii  rocm-utils                                                  <IP_ADDRESS>900-17                                   amd64        Radeon Open Compute (ROCm) Runtime software stack
ii  rocminfo                                                    1.30900.0                                        amd64        Radeon Open Compute (ROCm) Runtime rocminfo tool
ii  whiptail                                                    0.52.20-1ubuntu1                                 amd64        Displays user-friendly dialog boxes from shell scripts
libhsa-runtime64.so.1 is already exist in /opt/rocm/hsa-amd-aqlprofile/lib
but rocminfo say it is missing.

I don't know how this error reproduce.but when  i updated  rocm 3.8 to 3.9,this error has happened.
and Tensorflow-rocm had error too with this message here is out put.
pip3 install tensorflow-rocm==2.2.0
Python 3.6.9 (default, Oct  8 2020, 12:12:24)
[GCC 8.4.0] on linux
Type "help", "copyright", "credits" or "license" for more information.

import tensorflow

ImportError: libhipsparse.so.0: cannot open shared object file: No such file or directory

Hi @AveNoF
Looks like un-installation of 3.8 did not go well in your machine.
As ROCm upgrade is NOT supported, recommend to do clean un-installation of old ROCm and install new ROCm.
Can you please try uninstall ROCm completely once again and make sure that all packages are removed before you install 3.9.
Recommend to check sudo dpkg -l | grep hsa . Replace hsa with hip, llvm, rocm, rock and make sure that all packages are removed. Recommend to do the same for all other additional packages also if you installed anything explicitly.
Once you make sure that its clean, now try to install ROCm 3.9.
I hope this helps.

Hi @AveNoF
Looks like un-installation of 3.8 did not go well in your machine.
As ROCm upgrade is NOT supported, recommend to do clean un-installation of old ROCm and install new ROCm.
Can you please try uninstall ROCm completely once again and make sure that all packages are removed before you install 3.9.
Recommend to check sudo dpkg -l | grep hsa . Replace hsa with hip, llvm, rocm, rock and make sure that all packages are removed. Recommend to do the same for all other additional packages also if you installed anything explicitly.
Once you make sure that its clean, now try to install ROCm 3.9.
I hope this helps.

TF error is due to missing hipsparse library which is a different issue, we can handle it separately.
Meanwhile recommend to install rocm 3.9 well and then we can see all rest of issues later.

for uninstall all old rocm software i typed  sudo apt-get purge hsa* hip* llvm* rocm*
when my ubuntu-desktop had broken and I reinstalled ubuntu.
How should i have uninstall all old packages?
and now another problem has happen.
that errors was same as https://github.com/RadeonOpenCompute/ROCm/issues/1161
and  https://github.com/RadeonOpenCompute/ROCm/issues/1164
and now there is a error of hip that similer to https://github.com/ROCmSoftwarePlatform/tensorflow-upstream/issues/1106
but little different from mine.
tensorflow-rocm
&python3
Python 3.6.9 (default, Oct  8 2020, 12:12:24)
[GCC 8.4.0] on linux
Type "help", "copyright", "credits" or "license" for more information.

import tensorflow as tf
hello = tf.constant('Hello World!')
2020-11-25 00:30:46.848606: I tensorflow/stream_executor/platform/default/dso_loader.cc:48] Successfully opened dynamic library libamdhip64.so
/src/external/hip-on-vdi/rocclr/hip_code_object.cpp:120: guarantee(false && "hipErrorNoBinaryForGpu: Coudn't find binary for current devices!")
中止 (コアダンプ)

I wonder why such a core dump has happen.
$ pip3 list
DEPRECATION: The default format will switch to columns in the future. You can use --format=(legacy|columns) (or define a format=(legacy|columns) in your pip.conf under the [list] section) to disable this warning.
absl-py (0.11.0)
apturl (0.5.2)
asn1crypto (0.24.0)
astunparse (1.6.3)
Brlapi (0.6.6)
cachetools (4.1.1)
certifi (2020.11.8)
chardet (3.0.4)
command-not-found (0.3)
cryptography (2.1.4)
cupshelpers (1.0)
defer (1.0.6)
distro-info (0.18ubuntu<IP_ADDRESS>)
gast (0.3.3)
google-auth (1.23.0)
google-auth-oauthlib (0.4.2)
google-pasta (0.2.0)
grpcio (1.33.2)
Guake (3.0.5)
h5py (2.10.0)
httplib2 (0.9.2)
idna (2.10)
importlib-metadata (3.1.0)
Keras-Preprocessing (1.1.2)
keyring (10.6.0)
keyrings.alt (3.0)
language-selector (0.1)
launchpadlib (1.10.6)
lazr.restfulclient (0.13.5)
lazr.uri (1.0.3)
louis (3.5.0)
macaroonbakery (1.1.3)
Mako (1.0.7)
Markdown (3.3.3)
MarkupSafe (1.0)
netifaces (0.10.4)
numpy (1.18.5)
oauth (1.0.1)
oauthlib (3.1.0)
olefile (0.45.1)
opt-einsum (3.3.0)
pbr (3.1.1)
pexpect (4.2.1)
Pillow (5.1.0)
pip (9.0.1)
protobuf (3.14.0)
pyasn1 (0.4.8)
pyasn1-modules (0.2.8)
pycairo (1.16.2)
pycrypto (2.6.1)
pycups (1.9.73)
pygobject (3.26.1)
pymacaroons (0.13.0)
PyNaCl (1.1.2)
pyRFC3339 (1.0)
python-apt (1.6.5+ubuntu0.3)
python-dateutil (2.6.1)
python-debian (0.1.32)
pytz (2018.3)
pyxdg (0.25)
PyYAML (3.12)
reportlab (3.4.0)
requests (2.25.0)
requests-oauthlib (1.3.0)
requests-unixsocket (0.1.5)
rsa (4.6)
scipy (1.4.1)
SecretStorage (2.3.1)
setuptools (50.3.2)
simplejson (3.13.2)
six (1.15.0)
system-service (0.3)
systemd-python (234)
tensorboard (2.4.0)
tensorboard-plugin-wit (1.7.0)
tensorflow-estimator (2.3.0)
tensorflow-rocm (2.3.2)
termcolor (1.1.0)
ubuntu-drivers-common (0.0.0)
ufw (0.36)
unattended-upgrades (0.1)
urllib3 (1.26.2)
usb-creator (0.3.3)
wadllib (1.3.2)
Werkzeug (1.0.1)
wheel (0.35.1)
wrapt (1.12.1)
xkit (0.0.0)
zipp (3.4.0)
zope.interface (4.3.2)

@AveNoF

for uninstall all old rocm software i typed sudo apt-get purge hsa* hip* llvm* rocm*
when my ubuntu-desktop had broken and I reinstalled ubuntu.

doing sudo purge with llvm* was a bad idea. llvm is probably required by your standard graphics drivers and other important system components. Don't do such things blindly. Is sometimes might or might not work.
My recommendation would be to remove it using sudo apt purge -V comgr*. Then once that is done (it will remove the majority of rocm stuff probably), see for the remaining packages in the output of: dpkg -l | gawk '$2 ~ /\yroc[mkrt]|\yhip^Cyhsa\y/ { print $2; }'

Hi @AveNoF
Recommend to uninstall ROCm as per below steps.

sudo apt autoremove rocm-opencl
Now check sudo dpkg -l | grep hsa. Replace hsa with hip, llvm, rocm, rock.
Remove all visible ROCm packages as sudo apt pugre  and make sure that all packages are removed.
Recommend to do the same for all other additional packages also if you installed anything explicitly.

Once you make sure that its clean, now try to install ROCm 3.9.
I hope this helps.

Thanks @AveNoF for closing this. Hope this issue is resolved for you.
Thank you.

For future reference, I had the same problem after several dirty up/downgrades. Managed to fix it with
sudo apt remove comgr hsa-rocr-dev rocm-opencl
sudo apt install rocm-opencl


Release 58

Coverage increased (+0.07%) to 32.022% when pulling ed142f85747b4f266e909ac437d3ef1f29e8d224 on current into a3ee8f935534db056c21c1e8b4dcf063356b842c on master.


Variables Interface in SAT and Set Covering [Need to be discussed]

variables functions in  Satisfiability.jl[@SciCodePhy #37 ] and SetCovering.jl[@c-allergic #39 ] are not consistent with #38 , which are required to generate from 1 to num_variables by #38 .

Decision: variables can be any vector like object.


Upgrades exp to 49 for the newest version of expo(25)

Expo 25 doesn't seem to build with the current version of exp on appr. We need to upgrade to 49.

@jayeszee we've just released<EMAIL_ADDRESS>that moves exp to a peerDependency, so you can now set your own preferred version (>= 48) as a devDependency:
https://github.com/FormidableLabs/appr/releases/tag/v2.0.0
Thanks for the PR, closing this as superseded.


Homebrew must be run under Ruby 2.3! You're running 2.0.0

Any brew command I run (no matter brew update, brew -v), it gives me this error.
/Library/Ruby/Site/2.0.0/rubygems/version.rb:191:in `strip!': can't modify frozen String (RuntimeError)
	from /Library/Ruby/Site/2.0.0/rubygems/version.rb:191:in `initialize'
	from -e:1:in `new'
	from -e:1:in `<main>'
/usr/local/Homebrew/Library/Homebrew/brew.rb:12:in `<main>': Homebrew must be run under Ruby 2.3! You're running 2.0.0. (RuntimeError)

I know that there are some related issues with this, but after checking all of them, I still cannot find any solution to it.
Anyone can help with it?
Thank you.

try brew update-reset

@ilovezfs This command can run well. But after resetting it, it still has the same error.

OK, what is the output of
git --no-pager -C /usr/local/Homebrew tag -l

@ilovezfs

And how about
git -C /usr/local/Homebrew status

On branch master
Your branch is up-to-date with 'origin/master'.
nothing to commit, working tree clean

And can you run brew doctor now?

No, I can't
➜  brew doctor
/Library/Ruby/Site/2.0.0/rubygems/version.rb:191:in `strip!': can't modify frozen String (RuntimeError)
	from /Library/Ruby/Site/2.0.0/rubygems/version.rb:191:in `initialize'
	from -e:1:in `new'
	from -e:1:in `<main>'
/usr/local/Homebrew/Library/Homebrew/brew.rb:12:in `<main>': Homebrew must be run under Ruby 2.3! You're running 2.0.0. (RuntimeError)

OK. Try this please
mkdir ~/rubygems-20171031
sudo mv /Library/Ruby/Site/2.0.0/rubygems ~/rubygems-20171031/

And then try brew doctor and brew config

It seems that it cannot find needed things.
➜  mkdir ~/rubygems-20171031
➜  sudo mv /Library/Ruby/Site/2.0.0/rubygems ~/rubygems-20171031/
Password:
➜ brew doctor
/Library/Ruby/Site/2.0.0/rubygems.rb:1259:in `require': cannot load such file -- rubygems/custom_require (LoadError)
	from /Library/Ruby/Site/2.0.0/rubygems.rb:1259:in `<top (required)>'
	from <internal:gem_prelude>:1:in `require'
	from <internal:gem_prelude>:1:in `<compiled>'
/Library/Ruby/Site/2.0.0/rubygems.rb:1259:in `require': cannot load such file -- rubygems/custom_require (LoadError)
	from /Library/Ruby/Site/2.0.0/rubygems.rb:1259:in `<top (required)>'
	from <internal:gem_prelude>:1:in `require'
	from <internal:gem_prelude>:1:in `<compiled>'

Try to uninstall and install Homebrew again using the instructions on https://github.com/Homebrew/install

@weimingwill also try moving
sudo mv /Library/Ruby/Site/2.0.0/rubygems.rb ~/rubygems-20171031/

@MikeMcQuaid I have tried that previously. Thanks.
@ilovezfs It works now!!!
May I know why it happens?
What is the ruby it refers to if it cannot find it at /Library/Ruby/Site/2.0.0/?
Can I put the ruby back to its location?
Thank you!

@weimingwill I'm really not sure where your /Library/Ruby/Site/2.0.0/rubygems directory and /Library/Ruby/Site/2.0.0/rubygems.rb came from. They're not part of a pristine macOS installation so they came from ... somewhere. Maybe you know. I wouldn't put them back, as I would expect the same bug will return if you do.

@ilovezfs It may be installed 1+ years ago, which I don't remember alr. I thought it is part from macOS and didn't dare to remove it.

when I install cmake, I found this problem too.
I repeat install, and question solved.


Regex injection in enable(namespaces)

Coverity static analysis is complaining that enable(namespaces) uses an unescaped user input as the basis for a regular expression.
It follows the path from the user-defined window.localStorage.debug value through the load() function in browser.js into the enable(namespaces) function in common.js.
I understand that this debug input is used to control what is logged or not -- but it leaves the library (and any dependent ones) open to receiving crafted input that could cause a denial of service attack on the user's browser (ReDoS attack). I don't believe this is an issue for a server-side DoS attack -- as the input on the server comes from an environment variable rather than the less-protected browser context.
One solution might be to look at something like https://github.com/davisjam/safe-regex to defend against some types of problematic regexes -- there are other suggestions in that repo's readme as well.

Which version, and can you please show the report?

The coverity report was for version 2.6.9 but I believe I can trace the same path in the current master branch.
I'm not sure how to include the report here -- it marks up the code with hyperlinks and comments...
Extracts from debug.js v.2.6.9 (but similar path in latest master browser.js and common.js):
browser.js#L13 picks up the browser local storage:
exports.storage = 'undefined' != typeof chrome
               && 'undefined' != typeof chrome.storage
                  ? chrome.storage.local
                  : localstorage();

browser.js#L150 returns the local storage from the load() function:
function load() {
  var r;
  try {
    r = exports.storage.debug;
  } catch(e) {}
  ...
  return r;
}

browser.js#L168 sends the local storage to enable():
exports.enable(load());

debug.js#L151 and L153 create a regex using the user defined input:
function enable(namespaces) {
  ...
  var split = (typeof namespaces === 'string' ? namespaces : '').split(/[\s,]+/);
  var len = split.length;

  for (var i = 0; i < len; i++) {
    if (!split[i]) continue; // ignore empty strings
    namespaces = split[i].replace(/\*/g, '.*?');
    if (namespaces[0] === '-') {
      exports.skips.push(new RegExp('^' + namespaces.substr(1) + '$'));    // <-- HERE
    } else {
      exports.names.push(new RegExp('^' + namespaces + '$'));    // <-- AND HERE
    }
  }
}

Ah yeah okay. I've always felt awkward about how this was handled. This should be factored into the .enable() overhaul. I'll add it to the 5.x list :)
Thanks for the details!

This is still being flagged by scanners such as Checkmarx when using debug 4.3.6 - see https://devhub.checkmarx.com/cve-details/Cx8bc4df28-fcf5/

Released as 4.4.0.


(WIP) Improve mbtile deployment for samples

Two of our samples make use of an mbtiles file which needs to be deployed for it to work. The previous setup did this deployment for each platform which caused more platform specific code and made it possible to forget it. With the new setup the mbtile files are deployed in the static constructor of the samples themselves.
Some notes.

I tested this with Maui on Windows and Xamarin.Forms on Android. Nothing else.
I use this folder: Environment.SpecialFolder.LocalApplicationData. I don't know where that is exactly on each platform and I am not sure it exists on all platforms, or if you need access rights.

Good idea. Some more MBTilesLocation Code has to be removed.

I fixed the Eto Sample so that it can start on windows (on other platforms I didn't test)

Found this:
https://platform.uno/docs/articles/features/file-management.html

The build failure will be fixed by this pullrequest
https://github.com/Mapsui/Mapsui/pull/1735
I checked wasm didn't work before with mbtiles. I guess that the reading of the embedded resources does not work and that is why it isn't working so no regression.

I did some more research. And it seems that for wasm special nugets need to be used.
https://platform.uno/blog/uno-platform-sqlite-for-webassembly-support-on-net-5-and-net-6/
Tried it and it didn't work, so waiting for .NET 7


Image to video issue

Hello team,
Could you please give me a tip about image-to-video and what might be wrong? I can generate a text-to-video or video-to-video, but not image-to-video.

Traceback (most recent call last):
File "/home/bixbit/.local/lib/python3.10/site-packages/gradio/queueing.py", line 536, in process_events
response = await route_utils.call_process_api(
File "/home/bixbit/.local/lib/python3.10/site-packages/gradio/route_utils.py", line 322, in call_process_api
output = await app.get_blocks().process_api(
File "/home/bixbit/.local/lib/python3.10/site-packages/gradio/blocks.py", line 1935, in process_api
result = await self.call_function(
File "/home/bixbit/.local/lib/python3.10/site-packages/gradio/blocks.py", line 1520, in call_function
prediction = await anyio.to_thread.run_sync(  # type: ignore
File "/home/bixbit/.local/lib/python3.10/site-packages/anyio/to_thread.py", line 56, in run_sync
return await get_async_backend().run_sync_in_worker_thread(
File "/home/bixbit/.local/lib/python3.10/site-packages/anyio/_backends/_asyncio.py", line 2441, in run_sync_in_worker_thread
return await future
File "/home/bixbit/.local/lib/python3.10/site-packages/anyio/_backends/_asyncio.py", line 943, in run
result = context.run(func, *args)
File "/home/bixbit/.local/lib/python3.10/site-packages/gradio/utils.py", line 826, in wrapper
response = f(*args, **kwargs)
File "/home/bixbit/EasyAnimate/easyanimate/ui/ui.py", line 430, in generate
raise gr.Error(f"Please select an image to video pretrained model while using image to video.")
gradio.exceptions.Error: 'Please select an image to video pretrained model while using image to video.'

Try to refresh Model checkpoints Dropdown and reload model checkpoint.


cannot clear value date-two

Hi,
could I programmatically clear date-two value, I've been try set date-two to empty string manually but its seems not working.
if I try to look at dev tools, it seems selectedDate2 not immediately updated

Something like this should work:
<template>

          <input
            type="text"
            id="datepicker-input-trigger"
            :value="formatDates(inputDateOne, inputDateTwo)"
            placeholder="Select dates"
          >

          <airbnb-style-datepicker
            :trigger-element-id="'datepicker-input-trigger'"
            :date-one="inputDateOne"
            :date-two="inputDateTwo"
            @date-one-selected="val => { inputDateOne = val }"
            @date-two-selected="val => { inputDateTwo = val }"
          />

</template>

in my case I'm using props to binding date-two value, I try to emit empty string to set date-two value but its not updated.
my solution I adding watcher as below

sorry for bad english..

The issue can be reproduced when you set the 'date-one' to empty string within 'date-one-selected' handler. The datePropsCompound property watcher's handler does not take into account dateTwo
...     datePropsCompound(newValue) {       if (this.dateOne !== this.selectedDate1) { ...
Here is the link to the fiddle to reproduce https://jsfiddle.net/grhv6o3f/3/


Blog tile

Related Issue
No response
Description
Title: Overhauling the Dashboard 2.0 Build Pipeline
Tagline: A month or so ago, we released the Third-Party widget support for Dashboard 2.0, but having heard feedback, we missed the beat, so we've built it again!
First line of article: As a developer, sometimes you have to hold up your hands and realise something you've spent two weeks building needs to be thrown away and restarted.

@joepavitt Here it is! Hope you like it 😉


Number of connections being miscounted

The seed nodes stopped accepting new connection, and reports TOO_MANY_PEERS error even though there are less than 1024 connections. I suspect active connection set is not properly managed.

Think this can be closed with the fix made to fix config?


Watch mode doesn't use specified title

If I pass a title on the command-line, it works for single runs, but appears to be ignored in watch mode.

Thanks for the great tool!

Sorry for the delay :-s
I can't reproduce the problem, it works with this command line:
markdown-to-slides file.md -o file.html -w -t "My customized title"

file.html contains this HTML:
<!DOCTYPE html>
<html>
	<head>
		<meta charset="utf-8" />
		<title>My customized title</title>

Do you remember the command line you used?
The result is the same with the watch mode enabled.


Add a warning about use of type aliases

Add a note to the documentation warning users to not use type
aliases to distinguish between effect types.

Let me know what you think, I'm not aware of your intended tone or style of documentation.

Upon further thought. I wonder if this might be better cleaned up just by turning on -Wall, which should warn about the redundant Member (Input B) r constraint.

Huh, I didn't even know that would happen, that sounds best. I'll give it a go tomorrow.

I don't think -Wall implies -fwarn-redundant-constraints
On Tue, 4 Jun 2019, 11:37 am Samuel Evans-Powell<EMAIL_ADDRESS>wrote:

Huh, I didn't even know that would happen, that sounds best. I'll give it
a go tomorrow.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/isovector/polysemy/pull/82?email_source=notifications&email_token=AAAFDDQSYADHJWLUBFXK4MDPYZAV5A5CNFSM4HSXTKN2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODW4E4PY#issuecomment-498617919,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAAFDDRGDTU7FTE5VKZURVDPYZAV5ANCNFSM4HSXTKNQ
.

@sevanspowell does -fwarn-redundant-constraints solve your problem?

Sorry, -fwarn-redundant-constraints does resolve the problem. It warns about:


nixos/make-iso9660: fix zstd input

Motivation for this change
hydra fails on nixos iso
Things done
fix nixos iso

[x] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
Built on platform(s)

[x] NixOS
[ ] macOS
[ ] other Linux distributions

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
[ ] Tested execution of all binary files (usually in ./result/bin/)
[ ] Determined the impact on package closure size (by running nix path-info -S before and after)
[ ] Ensured that relevant documentation is up to date
[x] Fits CONTRIBUTING.md.

Looks like this is the same as #89883?

Looks like this is the same as #89883?

Oh, yes. But I think putting it next to the option compressImage helps to see for what it is

Closed my PR https://github.com/NixOS/nixpkgs/pull/89883 in favor of this one


Updated atlas version

@abrin Something not quite right.
https://deploy-preview-263--iiif-canvas-panel-demos.netlify.app/
It doesn't look like its hitting the ready state at all.

@abrin Something not quite right. https://deploy-preview-263--iiif-canvas-panel-demos.netlify.app/
It doesn't look like its hitting the ready state at all.

I see what the issue is here in Atlas, I forgot to push a commit 😞 . https://github.com/atlas-viewer/atlas/pull/51

@abrin that's working now 🎉
Do you want me to merge this and #262 and get a release?

@stephenwf just this, I think. We were talking at standup and it seems like the a11yTitle isn't updating after the initial value is passed, Jason's looking at that.  thanks!

@abrin you can set the aria-label="" on the <canvas-panel> or <sequence-panel> directly, if that helps at all.

+<EMAIL_ADDRESS>
🎉


The card will not be displayed in foundry with other player

I'm a player and i dont't know why but i can't share the cards I've draw with other player only the GM.
Please help me.
I have this code on the macro:
`
let deckName = 'Cards Sharp Deck';
let discardPile = 'Pila di Scarto';
let share = true;
OrcnogFancyCardDealer({
deckName: deckName ,
discardPileName: discardPile
}).draw(share);`

Hi @ChiaraKira, I'm low on free time lately but I have seen your comment and I will try to replicate this issue.... but just like at an auto mechanic's shop, if I can't reproduce the problem I'm not sure I can fix it.   Any other steps to reproduce that you can add will help, thanks!
But just upon looking at your pasted code, I might see a syntax error.  Try making the 3rd-to-last line in your snippet deckName: deckName,.  I.e. removing the extra space before the comma.  Lmk if that fixes the issue.

I tested with the following macro code (only changing the deckName to the name of a deck in my own game):
let deckName = 'Deck of Many More Things';
let discardPile = 'Pila di Scarto';
let share = true;

OrcnogFancyCardDealer({
deckName: deckName ,
discardPileName: discardPile
}).draw(share);

...and this worked just fine for me.
Please try again.  Maybe it was inadvertently fixed in one of the 2 updates that have been released since you originally logged this issue.  It's working for me!  Marking this closed.  (feel free to log another issue if it is indeed still broken for you)


kubernetes cluster networking types based on IP address assignment

Kubernetes has a concept of cluster IP family, as it can be IPv4 only, IPv6 only or dual stack depending on the IP famliies configured for their Pod , Services and Node objects.

/sig network
/assign @thockin @danwinship @khenidak @sftim

@sftim I synced with @danwinship offline, and we thought it is better/easier to understand to make the distinction of the IP families based on the configuration of the components.
Added a new section first to explain the different components and the IP address ranges configured each of them
PTAL and add suggestions if you feel. there are parts that are still not clear or may be misleading

/approve