module.exports.cloneCssStyles() in combination with Angularjs breaks display in Chrome and IE

Hi Knut,
Thanks for this great library! It is really easy and intuitive to use.
I am using mermaid together with Angularjs, what works fine by and large.
When testing in different browsers, I noticed one issue that breaks display of Flowcharts in Chrome (latest version) and IE 10. In both browsers, all chart items appear completely black.
Uncommenting the lines below fixed the issue.
module.exports.cloneCssStyles = function(svg, classes){
  ...
  if (typeof(rule.style) !== 'undefined') {
    var elems = svg.querySelectorAll(rule.selectorText);
      if (elems.length > 0) {
        usedStyles += rule.selectorText + " { " + rule.style.cssText + " }\n";
      }
  }
  ...
}

The Javascript error is
Uncaught SyntaxError: Failed to execute 'querySelectorAll' on 'Element': '[ng:cloak], [ng-cloak], [data-ng-cloak], [x-ng-cloak], .ng-cloak, .x-ng-cloak, .ng-hide:not(.ng-hide-animate)' is not a valid
selector.

Searching for the problem, I found one link to a similar issue on github. The developer says that handling of invalid selector errors fixed the issue here. ( https://github.com/exupero/saveSvgAsPng/issues/11 )
Uncommenting the code did not have any negative impact on display, so this is a workaround for me.
Maybe you can provide a fix in one of the next versions?
Thanks,
Wolfram

Thanks for pointing this out. I will look into it!
Skickat från min iPad

5 mar 2015 kl. 13:10 skrev wolframst<EMAIL_ADDRESS>Hi Knut,
Thanks for this great library! It is really easy and intuitive to use.
I am using mermaid together with Angularjs, what works fine by and large.
When testing in different browsers, I noticed one issue that breaks display of Flowcharts in Chrome (latest version) and IE 10. In both browsers, all chart items appear completely black.
Uncommenting the lines below fixed the issue.
module.exports.cloneCssStyles = function(svg, classes){
...
if (typeof(rule.style) !== 'undefined') {
var elems = svg.querySelectorAll(rule.selectorText);
if (elems.length > 0) {
usedStyles += rule.selectorText + " { " + rule.style.cssText + " }\n";
}
}
...
}
The Javascript error is
Uncaught SyntaxError: Failed to execute 'querySelectorAll' on 'Element': '[ng:cloak], [ng-cloak], [data-ng-cloak], [x-ng-cloak], .ng-cloak, .x-ng-cloak, .ng-hide:not(.ng-hide-animate)' is not a valid
selector.
Searching for the problem, I found one link to a similar issue on github. The developer says that handling of invalid selector errors fixed the issue here. ( exupero/saveSvgAsPng#11 )
Uncommenting the code did not have any negative impact on display, so this is a workaround for me.
Maybe you can provide a fix in one of the next versions?
Thanks,
Wolfram
—
Reply to this email directly or view it on GitHub.

The similar issue you sent was very useful. I have wrapped the css copying in a try/catch statement in a similar way. This is committed but not yet released. It also handles the case when the css file is on an external site, then firefox blocks the css copying.
@wolframst, it would be very useful if you could test and see if this solves your issue.

Hi Knut,
Thats what I call a fast response. Thanks so much!
The fix resolved the issue partially. The graph now renders, but all edges are missing. Looks like the invalid selectors error gets thrown while rendering the edges.
In order to reproduce the issue it should be sufficient to incude the angular.js file.
Best,
Wolfram

That sounds like a styling issue. Check if the styles for edgePaths are in place.
.edgePath .path {
   stroke: #333333;
}

Also is the same for firefox/chrome?
A tmp addition of the style inline can also give some clues to what the problem is.

A fix for this has been released in version 0.5.0

I updated Mermaid to 0.5.0. But error still appears. :(
Using AngularJS v1.3.15.

This is an error message occurring when styles are being copied from the surround context, (web page), into the svg code.
The css rules that fails are, (at least in my test page), related to angular and not to the svg. In the catch clause for the exception there error is written but the copying continues.
Does the svg appear for you?
/Knut
Knut Sveidqvist
Sent with Sparrow (http://www.sparrowmailapp.com/?sig)
On Monday 8 June 2015 at 08:16, ma-zal wrote:

I updated Mermaid to 0.5.0. But error still appears. :(
Using AngularJS v1.3.15.
—
Reply to this email directly or view it on GitHub (https://github.com/knsv/mermaid/issues/126#issuecomment-109876292).

To knsv: You are right, final SVG is OK. So, if i understand, this "error" is "warning" only, because all works. And my imagination is: Error causes some part of Angular, that tries to manipulate with DOM, and it is not possible to solve it.


Keyboard intercepting

Video of me using this API get intercept the keyboard events like up and down arrow
https://twitter.com/joehink95/status/1382482305814392833
example code

func keyCommands(selector: Selector) -> [UIKeyCommand] {
  return [
    UIKeyCommand(action: selector, input: UIKeyCommand.inputUpArrow),
  ]
}
func receiver(sender: UIKeyCommand) {
 print(sender) // i.e. up arrow
}

// in your view
FireflySyntaxEditor(
  text: $text,
  implementUIKeyCommands: (keyCommands, receiver),
  language: "swift",
  theme: "Xcode Light",
  fontName: "system",
  didChangeText: { _ in},
  didChangeSelectedRange: {_,_ in},
  textViewDidBeginEditing: {_ in}
)

This has been merged into https://github.com/ActuallyZach/Firefly/tree/MacOS


Fix variance checks between generic instances for Proc#call and abstract defs

Follow-up to #10507. This simply adds the newly discovered specs in https://github.com/crystal-lang/crystal/pull/10507#issuecomment-875666816.

It seems the formatter complains. After that we can merge this.


Support breaking changes of HA v2012.12.0

@maorcc, new version below contains 3 changes,
I ran it on my testing environment, no issues found,
In addition, once merged - should be created a release (v1.0.2) with the content below
v1.0.2

Support breaking changes of HA v2012.12.0
Fixed division by zero errors #22
Added support for Long-term Statistics #21

Looks good.  Thanks, @elad-bar!


Expose (Issuer) EntityID and AuthnContext from recieved SAML 2 assertion as attributes

Add mechanism to return the issuer EntityID and AuthnContext via the UserProfile so they can be used by downstream authentication and/or authorization processes.
Doing this unconditionally is a fairly straightforward change (I think) to saml/sso/impl/SAML2DeafultResponseValidator; making it optional might take a bit of thought.

I don't want to do that by default, but this should be extensible really easily. Waiting for your proposal...

I would like to understand the reluctance to simply add these attribute values as opposed to adding configuration to make it optional.  To me, adding configuration to do this would be a more invasive patch, both to pac4j and for the consumer (CAS).

Sure. By design, the UserProfile stores the profile of the user: an identifier and attributes (and some other things). It's not generally meant to store authentication attributes (here I mean the issuer and the AuthnContext).

Would it be better to have them be part of the SAML2Profile class?  There are already authentication-related attributes available via getters there (e.g. NotBefore/NotOnOrAfter).

You're right. There is a gap between the intended design and what we practically implemented.
I think we need to store separately the authentication attributes. I just opened: https://github.com/pac4j/pac4j/issues/948 for that. It should be fairly straightforward as the authenticationAttributes should work exactly like the attributes map.
So regarding this issue, either you do #948 first or directly work on this one.


(#506) Add docs about not using private variables

Description Of Changes
This pull request adds some basic documentation for the new rule that will be included in the next / future version of the package validator to give some information about why the rule flagged the package, what can be done to unflag the package and why it was flagged.
Motivation and Context
Need to document any new rules that gets added to the validator.
Testing

[x] I have previewed these changes using the Docker Container or another method before submitting this pull request.

Change Types Made

[ ] Minor documentation fix (typos etc.).
[ ] Major documentation change (refactoring, reformatting or adding documentation to existing page).
[x] New documentation page added.

Change Checklist

[ ] Requires a change to menu structure (top or left hand side)/
[ ] Menu structure has been updated

Related Issue

Fixes #506

@AdmiringWorm this looks good to me, we can get this merged in once we are ready to ship the next round of Package Moderation Services.


Update window icon on Windows

As far as I know, this is currently no possibility to change the default icon on a .NET Core console app.
However, on the documentation of zserge/webview, this seems to be possible through a resource file. I believe this could work as well on this wrapper then.
This would be nice to add support to this, or to just give some more information if this is already available.

This is a .NET Standard library so you can still use it from a .NET Framework app and set the icon in the project properties as normal. Not sure how you accive the same thing in .NET Core.


⬆ update @kodadot1/sub-api package

⏳ 🧪
PR type

[x] Bugfix

What's new?

[ ] PR closes #<issue_number>
[ ] Requires deployment <rubick/magick_issue>
[ ] <brief_description_of_what_I've_added>

Before submitting Pull Request, please make sure:

[ ] My contribution builds clean without any errors or warnings
[ ] I've merged recent default branch -- main and I've no conflicts
[ ] I've tried to respect high code quality standards
[ ] I've didn't break any original functionality
[ ] I've posted a screenshot of demonstrated change in this PR

I could not see the change of package.json 👀

@roiLeo please also upgrade package json

@roiLeo please also upgrade package json

package is not publish, I'll update kodadot/packages to include publish workflow
pnpm view @kodadot1/sub-api versions
[
  '0.0.1-rc.0',
  '0.0.1-rc.1',
  '0.0.1-rc.2',
  '0.0.1-rc.3',
  '0.0.1-rc.4',
  '0.1.0-alpha.1',
  '0.1.0-alpha.2',
  '0.1.0-alpha.3',
  '0.1.1-alpha.1'
]

publish workflow

❤

ping kodadot/packages#49

I am gonna load npm žetón (token in slovenian lang)

should go out?

should go out?

Not yet, after installing new sub-api package I've got multiple @polkadot/ errors in console:
@polkadot/** has multiple versions, ensure that there is only one installed.

Yup I had the same issue yesterday 🥺. Spent like 30 min with that

Closing this for now  ERROR  Cannot find module 'nuxt'


Fix path issue in scripts/eval_mlp.py

Modified the path to load the JSON file to use a relative path instead of an absolute path.
Before changing(line 83):
params = lib.load_json(f"/home/rototo/tab-diffusion/tuned_models/mlp/{Path(real_data_path).name}_cv.json")

After changing(line 83):
params = lib.load_json(f"tuned_models/mlp/{Path(real_data_path).name}_cv.json")

There is also an issue in the scripts/eval_seeds.py
Before changing(line 17):
'ctabgan-plus': 'CTAB-GAN-Plus/pipeline_ctabgan.py',

After changing(line 17):
'ctabgan-plus': 'CTAB-GAN-Plus/pipeline_ctabganp.py',


can not match on Name

Hello, I'm using 0.19.4 on my project.
When I do insert [code 1], the compiler says:

to use a constant of type mediatype::Name in a pattern, mediatype::Name must be annotated with #[derive(PartialEq, Eq)]

Would you like to apply the suggestion? Thank you.
[code 1]
        use mediatype::names;
        match (mediatype.ty, mediatype.subty) {
            (names::TEXT, names::MARKDOWN) => {
                Ok(SupportedContentType::Markdown)
            }
            (names::TEXT, names::PLAIN) => {
                Ok(SupportedContentType::PlainText)
            }
            (names::TEXT, names::HTML) => {
                Ok(SupportedContentType::Html)
            }
            (names::APPLICATION, names::OCTET_STREAM) => {
                Ok(SupportedContentType::GpgEncrypted)
            }
            _ => bail!("unsupported content type")
        }

Unfortunately, it is impossible to use name constants in that way due to Rust's limitation. The Name struct implements custom PartialEq and Eq for the case-insensitive comparison but Rust does not allow such types in pattern matches.
This restriction is explained in RFC 1445.


SRS Ready for Review

SRS PDF
Two important caveats:

I haven't been able to figure out a general "calculate the reactions at the supports" algorithm yet.
I need to plaster citations everywhere (it's mostly the textbook that I borrowed from @smiths and various online resources).

(also note that I can't assign Mina until she's accepted the invitation to collaborate on this repo, which I've just sent!)

Done my review (at least for now 😅)!

Thanks @samm82!

I'm done my review too @balacij.  My comments are in 236b62efd.  Just like the review for @samm82, I really enjoyed reviewing your SRS.  It has made me think about some things that I previously took for granted.  Great to see another perspective.

Thank you very much @smiths :smile:


Test PR for performance acknowledgment job - do not integrate

As @mgencur probably already told you, we're working on a automatic way how to trigger performance tests from PR using comment. I'm approaching setting it up using this PR as a test endpoint.
Do not integrate this PR, I will remove it when setup done.

run the performance tests please

run the performance tests please

run the performance tests please

run the performance tests please

run the performance tests please

run performance tests please

run performance tests please

run performance tests please

run performance tests please

run performance tests please

run performance tests please

run performance tests please

run performance tests please

run performance tests please

run performance tests please

run performance tests please

run performance tests please

run performance tests please

run performance tests please

run performance tests please

run performance tests please

run performance tests please

run performance tests please

@tristantarrant Could we please leave just for a little more time? I should have parametrization ready soon and I will want to test it :)

run the performance tests please
library dist reads
library repl writes

run the performance tests please
library dist reads
library repl writes

run the performance tests please
library dist reads
library repl writes

run the performance tests please

run performance tests please

run performance tests please

run performance tests please
library dist reads
library repl writes

run performance tests please
library dist reads
library repl writes

run performance tests please
library dist reads
library repl writes

run performance tests please
library dist reads
library repl writes

run performance tests please
library dist reads
library repl writes

run performance tests please
library dist reads
library repl writes

run performance tests please

PerfAck job seems to be running smoothly, closing.h


Odd behaviour with overwrite then append in command block

Running the following hush script multiple times results in unexpected behaviour.
test.hsh
#!/usr/bin/env hush

let now = ${ date "+%s" }.stdout
let stripped_now = std.split(now, "\n")[0]
let arr = [ "1", "2" ]
{
	echo $stripped_now > test_file;
	echo $arr >> test_file
}

Run once

$ ./test.hsh; cat test_file
1652491810
1 2

Run twice
$ rm test_file; ./test.hsh; cat test_file; sleep 2; echo "************"; ./test.hsh; cat test_file
1652491824
1 2
************
1652491827
1 2
1 2

Huh? Notice the time has changed, but now there are two copies of the array at the end of the file...?
Run three times
$ rm test_file; ./test.hsh; cat test_file; sleep 2; echo "************"; ./test.hsh; cat test_file; sleep 2; echo "************"; ./test.hsh; cat test_file
1652491843
1 2
************
1652491845
1 2
1 2
************
1652491847
1 2
1 2
1 2

Again the time is changing in subsequent runs, but now there are three copies of the array appended after the third run.
Run three times with an extra append before the third
% rm test_file; ./test.hsh; cat test_file; sleep 2; echo "************"; ./test.hsh; cat test_file; sleep 2; echo "************"; echo "hi there" >> test_file; ./test.hsh; cat test_file
1652491862
1 2
************
1652491864
1 2
1 2
************
1652491866
1 2
1 2
hi there
1 2

How did the "hi there" end up in the file? The file test_file should be completely overwritten each time test.hsh is run by the first line in the command block of the script.
I'm really confused....

Thanks for the great bug report! I missed the truncate flag when opening the file for the > redirection, so it was actually overwriting just the first bytes instead of the whole file. I'll publish the fix asap.


Re-enable/repair two skipped tests in circuits.js - rollup_wasm_wrapper.test.ts

The two tests are currently skipped:

'calls base_rollup__sim'
'calls root_rollup__sim'

They fail once we try to re-enable them.

Closed as the tests have been moved to noir-protocol-circuits.


[WFLY-19585][WFLY-19586] Upgrade SmallRye Reactive Messaging (4.24.0) and SmallRye Config (3.9.0)

Doing these together since they might as well come in at the same time.
Just routine upgrades to the latest.
https://issues.redhat.com/browse/WFLY-19585
https://issues.redhat.com/browse/WFLY-19586

Thanks @kabir


[DeadPublic] Idea for a package

Looks for unused public elements in the code

unused function
unused public class constant
unused public class property
unused public class method

Resources

https://stackoverflow.com/questions/11532/how-can-i-find-unused-functions-in-a-php-project
https://github.com/sebastianbergmann/phpdcd
https://github.com/rectorphp/rector/pull/5958 - Rector rules inspiration

Idea

use simple PHPStan scope resolver for types
collect public methods, collect their callers
compare it and show the diff

Not priority ATM


[Feature Request]: Hope to add rerank models to the project

Is there an existing issue for the same feature request?

[X] I have checked the existing issues.

Is your feature request related to a problem?
No response
Describe the feature you'd like
I think RAG+re-rank is a great combination that can improve recall accuracy.
Describe implementation you've considered
No response
Documentation, adoption, use case
No response
Additional information
No response

I see that there is a rerank module in the project architecture diagram. Does the module they provide fail to meet the requirements? Or some other problem?

I see that there is a rerank module in the project architecture diagram. Does the module they provide fail to meet the requirements? Or some other problem?

I asked the developers, and they haven't added the rerank model yet.

What you mean is that the rerank here is only based on some strategies to achieve the effect of rerank, and does not involve reranking LLM, right?

There should be a rearranging strategy, but the rerank model was not used.

So I have a question, what rerank models are available here? Have you ever compared the results?

Weighted keywords and embedding similarity is RAGFlow's reranking model right now.
And we're working on replacing the embedding similarity with other so called rerank models like BGE reranker and others.

I think the accuracy of the recall is already very accurate now, and I hope it can be further improved. It shouldn't be worse after adding it.


Training Time

May I ask how long does it take for one experimental setup to run an experiment with 8*v100 sheets?

In our experiments, it takes about 21hours for the semi-supervised training with DINO detectors with 8*A100 cards with the single card batch size of 5, and the ratio of labeled and unlabeled images is 1:4. It probably takes a little longer time with V100 cards.


Syntax Error

Under "Default Key Mapping" section, "configuraiton" instead of "configuration".

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 2639218d-5e54-aba0-ca0a-e53025b06d15
Version Independent ID: fec67d60-26a4-ba4c-45cf-f53c74281659
Content: Service communication with the ASP.NET Core
Content Source: articles/service-fabric/service-fabric-reliable-services-communication-aspnetcore.md
Service: service-fabric
GitHub Login: @vturecek
Microsoft Alias: vturecek

Thanks for the feedback. I have created a PR and changes will be live shortly.


Guard against nil return object

Coverage remained the same at 97.802% when pulling 6effd404979e0fade0c1a8533400c40a1fd8294a on bug/destroydeplyjson into 1c01122f447fbed9d3b6936cc1ad8328b20a98a9 on master.


Many to Many relationship not working

Laravel Version: 5.3
Voyager Version: 10.5
PHP Version: 5.6
Database Driver & Version: MySQL

Description:
I have a table avaliacaos and a table servicos and in avaliacaos I want to reffer to multiple services. I've followed the docs and created a Many to Many relationship and used the Multiple Select for selecting the services(servicos) I want to evaluate(avaliacaos). I've used the following code on my Avaliacaos Model:
public function servico(){
        return $this->belongsToMany(Servicos::class,'avaliacaos_servicos');
}

I've created the pivot table avaliacaos_servicos on my database:

But when I add the avaliacao trhough the BREAD, It returns this:

Here's the structure of my avaliacaos table:

I want to add a avaliacao item and select Multiple Servicos. Therefore, the pivot table should associate the servico with the avaliacao.
What did I do wrong? How can I fix this? Am I supposed to do anything else I haven't done in order to achieve the result I need?
I've seen a similar issue, https://github.com/the-control-group/voyager/issues/354 . Not fixed still... Anybody has any idea of what's going on? Anybody did created a Many to Many relationship following only the steps of the docs, just like me but got the expected result? What did you do different? Thank you very much.

This is not an issue with Voyager.  Please refer to

Ok, but if I don't put servico on my BREAD table, how will this field appear in my view?

Apologies, I misunderstood.
Voyager does not currently support Many-to-Many relations in it's views, though I believe someone is currently working on that.  My instructions above were for using Laravel functionality to build the relation.
As a workaround, you could add BREAD to the pivot table, and configure fields using one-to-many relations there.

Hi, did you find any approach that could fulfill this functionality, I'm now going through the same situation.
Best regards,

Has anyone come up with a solution to this problem as yet?

SQLSTATE[42S22]: Column not found: 1054 Unknown column 'track_cd.teck_list_id' in 'field list' (SQL: select id, name, track_cd.teck_list_id as pivot_teck_list_id, track_cd.cd_id as pivot_cd_id from cds inner join track_cd on cds.id = track_cd.cd_id where track_cd.teck_list_id in (7, 6, 5, 4, 3, 2, 1))


[WIP] Add version to web api and change web api route

:white_check_mark: Build AElf <IP_ADDRESS>7 completed (commit https://github.com/AElfProject/AElf/commit/3361d8a472 by @jason-hoopox)


Add configurable root path for maven tarball trailing

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

8 of 9 (88.89%)  changed or added relevant lines in 2 files are covered.
1 unchanged line in 1 file lost coverage.
Overall coverage decreased (-0.07%) to 84.11%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

mrrc/cmd/command.py
2
3
66.67%

Files with Coverage Reduction
New Missed Lines
%

mrrc/pkgs/maven.py
1
93.68%

Totals

Change from base Build<PHONE_NUMBER>:
-0.07%

Covered Lines:
614

Relevant Lines:
730

💛  - Coveralls


Add missing dependencies to gemspec

Please double check that I haven't missed any.

This was fixed in https://github.com/vicariousinc/setup-oob/commit/7dfc3186a38cfa80993251b11e2d207ac1bb1c94


feat: enable CI for pull request

Related https://github.com/risc0/zeth/pull/77
+r @Wollac

Could you provide more context with what this change is for? I think we should avoid the whitespace changes and use a common formatter/lint tool to ensure different users don't introduce different whitespace.

Could you provide more context with what this change is for? I think we should avoid the whitespace changes and use a common formatter/lint tool to ensure different users don't introduce different whitespace.

Related to this pr https://github.com/risc0/zeth/pull/75#issuecomment-1896273565

I think we should avoid the whitespace changes and use a common formatter/lint tool to ensure different users don't introduce different whitespace.

Yeah, I agree. This file was formatted by vscode github action official extension marketplace.visualstudio.com/items?itemName=GitHub.vscode-github-actions

Yeah, I agree. This file was formatted by the suggestion of this issue in official vscode github action extension marketplace.visualstudio.com/items?itemName=GitHub.vscode-github-actions.

FYI, https://marketplace.visualstudio.com/items?itemName=redhat.vscode-yaml

If we want to start enforcing a style on these files, then we need to have a CI check to ensure that the file can't be landed in a bad style.

good idea, using CI lints CI file, haha

good idea, using CI lints CI file, haha

@flaub I added yamllint for CI files and tested it locally. It worked as expected.

@dyxushuai @flaub @intoverflow @Wollac
Closing this stale PR


legion: assertion failure in debug mode

When running on a single node with debug mode, I see this assertion failure:
mttkrp-cuda: /home/rohany/taco-ctrl-rep-bug/legion/legion/runtime/legion/runtime.cc:2548: Legion::Internal::FutureInstance::FutureInstance(const void*, size_t, Legion::Memory, Legion::Internal::ApEvent, Legion::Internal::Runtime*, bool, bool, bool, Legion::Internal::PhysicalInstance, void (*)(void*, size_t), Legion::Processor, Legion::Internal::RtEvent): Assertion `size > 0' failed.
Signal 6 received by node 0, process 3943112 (thread 7fd73403a000) - obtaining backtrace
Signal 6 received by process 3943112 (thread 7fd73403a000) at: stack trace: 21 frames
  [0] = /lib/x86_64-linux-gnu/libpthread.so.0(+0x153c0) [0x7fd747cd63c0]
  [1] = /lib/x86_64-linux-gnu/libc.so.6(gsignal+0xcb) [0x7fd745f6418b]
  [2] = /lib/x86_64-linux-gnu/libc.so.6(abort+0x12b) [0x7fd745f43859]
  [3] = /lib/x86_64-linux-gnu/libc.so.6(+0x25729) [0x7fd745f43729]
  [4] = /lib/x86_64-linux-gnu/libc.so.6(+0x36f36) [0x7fd745f54f36]
  [5] = bin/mttkrp-cuda(Legion::Internal::FutureInstance::FutureInstance(void const*, unsigned long, Realm::Memory, Legion::Internal::ApEvent, Legion::Internal::Runtime*, bool, bool, bool, Realm::RegionInstance, void (*)(void*, unsigned long), Realm::Processor, Legion::Internal::RtEvent)+0x148) [0x56168c98ca90]
  [6] = bin/mttkrp-cuda(Legion::Internal::MemoryManager::create_future_instance(Legion::Internal::Operation*, unsigned long long, Legion::Internal::ApEvent, unsigned long, bool)+0x5a7) [0x56168c9b0b43]
  [7] = bin/mttkrp-cuda(Legion::Internal::FutureImpl::request_application_instance(Realm::Memory, Legion::Internal::SingleTask*, unsigned long long, unsigned int, Legion::Internal::ApUserEvent, unsigned long)+0x579) [0x56168c98677f]
  [8] = bin/mttkrp-cuda(Legion::Internal::SingleTask::finalize_map_task_output(Legion::Mapping::Mapper::MapTaskInput&, Legion::Mapping::Mapper::MapTaskOutput&, Legion::Internal::MustEpochOp*, std::vector<Legion::Internal::InstanceSet, std::allocator<Legion::Internal::InstanceSet> >&)+0x949) [0x56168c77e979]
  [9] = bin/mttkrp-cuda(Legion::Internal::SingleTask::invoke_mapper(Legion::Internal::MustEpochOp*)+0x184) [0x56168c7831e8]
  [10] = bin/mttkrp-cuda(Legion::Internal::SingleTask::map_all_regions(Legion::Internal::MustEpochOp*, Legion::Internal::TaskOp::DeferMappingArgs const*)+0x367) [0x56168c784d5f]
  [11] = bin/mttkrp-cuda(Legion::Internal::IndividualTask::perform_mapping(Legion::Internal::MustEpochOp*, Legion::Internal::TaskOp::DeferMappingArgs const*)+0x3f) [0x56168c790431]
  [12] = bin/mttkrp-cuda(Legion::Internal::SingleTask::trigger_mapping()+0x2d5) [0x56168c77d2ff]
  [13] = bin/mttkrp-cuda(Legion::Internal::Runtime::legion_runtime_task(void const*, unsigned long, void const*, unsigned long, Realm::Processor)+0x45a) [0x56168ca020e0]
  [14] = bin/mttkrp-cuda(+0x217ce4a) [0x56168d4a7e4a]
  [15] = bin/mttkrp-cuda(+0x21e3ae1) [0x56168d50eae1]
  [16] = bin/mttkrp-cuda(+0x21e8c64) [0x56168d513c64]
  [17] = bin/mttkrp-cuda(+0x21e6bf5) [0x56168d511bf5]
  [18] = bin/mttkrp-cuda(+0x21ee98e) [0x56168d51998e]
  [19] = bin/mttkrp-cuda(+0x21fcc6a) [0x56168d527c6a]
  [20] = /lib/x86_64-linux-gnu/libc.so.6(+0x5e660) [0x7fd745f7c660]

To reproduce the error, go to /home/rohany/taco-ctrl-rep-bug/build/ and run ./runner.sh. It the binary is compiled against a debug build of legion.
In my code, there is a loop like this:
Future f;
for (...) {
  TaskLauncher launcher(...);
  if (f.valid()) {
    launcher.add_future(f);
  }
  f = runtime->execute_task(ctx, launcher);
}

when I remove this tracking of the future (i.e. the loop just launches the tasks), the code succeeds. However, I don't think that this is incorrect, as I've done the same in a testing application with no errors, so I think that there is some interaction with this and other parts of the system that I don't understand.

Pull and try again

Now the program hangs (on a single node). It completes when I remove the future tracking loop. Adding -ll:defalloc 0 (i tried it anyway) doesn't seem to change anything. It is in the same location on sapling.

Try again

This has fixed the hang on a single node, but my multi-node runs are still hanging. Here is a command line to reproduce the hang:
mpirun -H g0001:4,g0002:4,g0003:4,g0004:4 --bind-to none -npernode 4 ./runner.sh bin/mttkrp-cuda -n 512 -gx 4 -gy 4 -gz 4 -lg:eager_alloc_percentage 50 -ll:ocpu 1 -ll:othr 2 -ll:csize 20000 -ll:util 1 -dm:replicate 1 -ll:gpu 1 -ll:fsize 15000 -gex:bindcuda 0 -gex:batch 0 -tm:validate_cpu -ll:defalloc 0

within the /home/rohany/taco/build/ directory.

Still waiting for sapling to have all the GPU nodes available...

It seems to hang on 3 nodes as well with this command line:
mpirun -H g0002:4,g0003:4,g0004:4 --bind-to none -npernode 4 ./runner.sh bin/mttkrp-cuda -n 512 -gx 4 -gy 4 -gz 4 -lg:eager_alloc_percentage 50 -ll:ocpu 1 -ll:othr 2 -ll:csize 20000 -ll:util 1 -dm:replicate 1 -ll:gpu 1 -ll:fsize 15000 -gex:bindcuda 0 -gex:batch 0 -tm:validate_cpu -ll:defalloc 0

Which GASNet conduit are you using? GASNet is dropping inter-process communication when the processes are on the same node, which has been observed before with MPI on sapling. There's something wrong with sapling's configuration of shared-memory inter process communication: https://github.com/StanfordLegion/legion/issues/605#issuecomment-602815721 Run with one process per node and see if it still reproduces.

Nevermind,  you can ignore the previous comment, I see what is going wrong.

Hey mike, did you get a chance to fix this?

I started work on the fix tonight. It's unclear when I'll be able to get it done.

I was looking into this a little bit today, and I think that there has been a regression / bug somewhere in the some of the changes you made. I had done this future-tracking loop described above so that the tasks being launched in a loop would be serialized (as they allocate a lot of memory, so they need to be serialized to avoid ooms). However, on 8989cac96bcbb39ecb5148a50a72bfeb119e4ac2, adding the future to the task launcher does not appear to serialize the tasks anymore -- a legion prof with spy shows that legion doesn't think that there are any dependencies between the individual launches of task_5 (http://sapling.stanford.edu/~rohany/lassen-mttkrp/mttkrp-space-4/?start=7311444.180602007&end=7964719.882849198&collapseAll=false&resolution=10). When I go back to 60091fd5b59b9befaef055cbf8077c9556ccca00, the tasks are serialized again.
I'm not able to effectively bisect this, because your changes fixed different hangs in this code. However, some commits that could cause this are f9ddd84bdbad8780fe4182baab4000790169eeee and 8989cac96bcbb39ecb5148a50a72bfeb119e4ac2.
I'm not sure what's the best way to give you a repro for this (if you want one). It shows up either via manual inspection of profiles, or OOMs at large problem sizes. I can prepare one of these as a repro for you.

That's not a regression, it was actually a bug fix and the runtime is working by design now. Adding data dependences in the machine-independent application code shouldn't be able to effect or slow down the process of mapping tasks or other operations; mappers should always be able to continue mapping into the future as long as possible in order to hide latencies. If you want to rate limit how far you are mapping into the future to manage memory consumption then the way to do that is with the select_tasks_to_map mapper call. If you feel like that is inadequate for your purposes, then you might talk to @manopapad and @streichler who have been working on some ideas for extensions to the mapper interface to make it easier to do that. Adding data dependences though in the application is not the right way to do it because it's not machine-indepdent (you might want to slow things down on one machine, but not on another one with more memory), and that goes against Legion's philosophy and therefore the runtime doesn't even allow you to get away with it.

That's not a regression, it was actually a bug fix and the runtime is working by design now. Adding data dependences in the machine-independent application code shouldn't be able to effect or slow down the process of mapping tasks or other operations; mappers should always be able to continue mapping into the future as long as possible in order to hide latencies.

Data dependencies should affect when tasks start to execute though! If i add the result of a task t1 a future dependence to task t2, how can t2 start executing before t1 is done? Does t2 need to explicitly wait on the future?
The problem I'm having is not that the regions being mapped are too large etc -- I want the mapper to run ahead and map all of these tasks. The problem is that each task allocates a large DeferredBuffer that each one reuses the space for instead of all running concurrently and allocating their own. Having a data dependence to stop all of them from executing at the same was a way of doing this.

If you want to rate limit how far you are mapping into the future to manage memory consumption then the way to do that is with the select_tasks_to_map mapper call. If you feel like that is inadequate for your purposes, then you might talk to @manopapad and @streichler who have been working on some ideas for extensions to the mapper interface to make it easier to do that.

I fell back to this data dependence strategy because I've tried using the mapper for this in the past and found it quite difficult. You have to manage queues for the tasks in question within the mapper, and then trigger those tasks to start executing when prior tasks finish -- all of which are things the runtime is already doing. It felt very error prone and potentially inefficient to try and reimplement things that Legion/Realm already know how to do.

Data dependencies should affect when tasks start to execute though! If i add the result of a task t1 a future dependence to task t2, how can t2 start executing before t1 is done?

If you think there is a bug in future dependence tracking then you should be able to make a trivial reproducer. That code is dirt simple and has been working for years at this point.

It felt very error prone and potentially inefficient to try and reimplement things that Legion/Realm already know how to do.

I strongly disagree with this point. It's not in any way obvious what the right rate to map tasks is because it should be tightly coupled to the machine on which the program is running, specifically the speeds of different processors on that machine and the amount of memory and other resources available to those processors. Realm and Legion only provide mechanisms for carrying out execution and have not the first clue what the right rate is to map tasks. If you think there is a universal algorithm that Legion and Realm could implement that would do exactly the right thing for mapping and scheduling tasks for every possible application on every possible machine ever devised both now and in the future then write it down so we can implement it.

If you think there is a bug in future dependence tracking then you should be able to make a trivial reproducer. That code is dirt simple and has been working for years at this point.

To do this, I need to know what to expect.  Or does t1 need to just call f.wait() if it wants to have a dependence on f? If it's the latter then I was just using the system wrong. If it's the former then I can try to make a reproducer for you. After looking around the Legion repository I suspect it's the latter.

I strongly disagree with this point. It's not in any way obvious what the right rate to map tasks is because it should be tightly coupled to the machine on which the program is running, specifically the speeds of different processors on that machine and the amount of memory and other resources available to those processors. Realm and Legion only provide mechanisms for carrying out execution and have not the first clue what the right rate is to map tasks. If you think there is a universal algorithm that Legion and Realm could implement that would do exactly the right thing for mapping and scheduling tasks for every possible application on every possible machine ever devised both now and in the future then write it down so we can implement it.

Let me clarify. I agree that Realm/Legion don't know how the best way map / schedule things for you. What I meant by "things that Legion/Realm already know how to do" was the implementations of all the concurrency and dependence tracking that go around scheduling these tasks so that they execute one after another (as well as the side point that they implement these things efficiently!). Having my mapper (at least the with current interface) try to do this involves making queues for these tasks to wait in in the mapper, communicating through reportProfiling when they finish, and then rescheduling the queued tasks as soon as one finishes. This was pretty difficult and felt like a breeding ground for errors -- not to mention the brittleness of it. Getting it right in the presence of multiple mappers (one per processor) and larger application feels challenging. If there's an easier way to do this, then let me know! I agree that the application code is not the right place for this synchronization to occur, but it feels like the simplest and most bulletproof way of getting the behavior I want.

To do this, I need to know what to expect.  Or does t1 need to just call f.wait() if it wants to have a dependence on f?

Depends. If the chosen task variant is marked as in inner task then then it is the later, but if the chosen task variant is not inner then it is the former.

If it's the former then I can try to make a reproducer for you.

You should definitely try to do this. I very much doubt that there is a bug with this code. If there was, all sorts of tests in the CI would be failing.

was the implementations of all the concurrency and dependence tracking that go around scheduling these tasks so that they execute one after another

Which they do, no exceptions. There's no way you can get incorrect results from your program by anything you do in the mapper.

Having my mapper (at least the with current interface) try to do this involves making queues for these tasks to wait in in the mapper, communicating through reportProfiling when they finish, and then rescheduling the queued tasks as soon as one finishes

You should only be needing to do this if you're trying to rate limit resource utilization, never for program correctness. Resource utilization is very machine- and schedule-dependent and therefore is definitely within the purview of the mapper's responsibilities.

If there's an easier way to do this, then let me know

Talk to @manopapad and @streichler

You should definitely try to do this. I very much doubt that there is a bug with this code. If there was, all sorts of tests in the CI would be failing.

Will do. I'll post an issue if I get something working.
The correctness I'm referring to here is lower level than the ordering of tasks etc -- mainly deadlocks / races / memory errors within the implementation of this scheduling in the mapper itself.

The correctness I'm referring to here is lower level than the ordering of tasks etc -- mainly deadlocks / races / memory errors within the implementation of this scheduling in the mapper itself.

You buy into that with your choice of the mapper synchronization model. If you want atomicity from the runtime on mapper calls then you can get that and also choose whether preemption is allowed or not. Once you make that choice, then it's up to you to implement the mapper in a consistent way.

Hey mike, sorry to bug you, but I wanted to know what your timeline is on this bug -- I'm hoping to run the experiment that is blocked by this soon.

If you're referring to the deadlock that was occurring, then you can go ahead and try again.

The deadlock looks like it's gone (on 8 nodes at least). However, I get a segfault when I go up to 16 nodes. Here's a backtrace:
[3] Thread 9 (Thread 0x20002ecdf8b0 (LWP 108089)):
[3] #0  0x00002000065de4e8 in waitpid () at ../sysdeps/unix/syscall-template.S:81
[3] #1  0x000020000654fd3c in do_system (line=0x13d559d0 <cmd.8118> "/usr/bin/gdb -nx -batch -x /var/tmp/gasnet_2hPDEW '/g/g15/yadav2/taco/build/bin/mttkrp-cuda' 107851") at ../sysdeps/posix/system.c:148
[3] #2  0x0000200006550424 in __libc_system (line=0x13d559d0 <cmd.8118> "/usr/bin/gdb -nx -batch -x /var/tmp/gasnet_2hPDEW '/g/g15/yadav2/taco/build/bin/mttkrp-cuda' 107851") at ../sysdeps/posix/system.c:189
[3] #3  0x0000200000105348 in system (line=<optimized out>) at pt-system.c:28
[3] #4  0x000000001303ca40 in gasneti_system_redirected ()
[3] #5  0x000000001303d218 in gasneti_bt_gdb ()
[3] #6  0x00000000130433f8 in gasneti_print_backtrace ()
[3] #7  0x0000000011112fb4 in gasneti_defaultSignalHandler ()
[3] #8  <signal handler called>
[3] #9  0x00002034d00006f8 in ?? ()
[3] #10 0x0000000011f2ba50 in Legion::Internal::EquivalenceSet::invalidate_trackers (this=0x2034d03b2550, mask=..., applied_events=std::set with 0 elements, origin_space=15, invalidate_mapping=0x0, filter_context=0x2034d09ab9c0) at /g/g15/yadav2/taco/legion/legion/runtime/legion/legion_analysis.cc:16447
[3] #11 0x0000000011f2c398 in Legion::Internal::EquivalenceSet::handle_invalidate_trackers (derez=..., runtime=0x16b25f80) at /g/g15/yadav2/taco/legion/legion/runtime/legion/legion_analysis.cc:16516
[3] #12 0x000000001181e1cc in Legion::Internal::Runtime::handle_equivalence_set_invalidate_trackers (this=0x16b25f80, derez=...) at /g/g15/yadav2/taco/legion/legion/runtime/legion/runtime.cc:24510
[3] #13 0x00000000117e1fc4 in Legion::Internal::VirtualChannel::handle_messages (this=0x2034d01ec3d0, num_messages=1, runtime=0x16b25f80, remote_address_space=15, args=0x2034b0198510 "", arglen=116) at /g/g15/yadav2/taco/legion/legion/runtime/legion/runtime.cc:12631
[3] #14 0x00000000117e04f0 in Legion::Internal::VirtualChannel::process_message (this=0x2034d01ec3d0, args=0x2034b01984f4, arglen=136, runtime=0x16b25f80, remote_address_space=15) at /g/g15/yadav2/taco/legion/legion/runtime/legion/runtime.cc:11703
[3] #15 0x00000000117e2f58 in Legion::Internal::MessageManager::receive_message (this=0x2034d0173db0, args=0x2034b01984f0, arglen=144) at /g/g15/yadav2/taco/legion/legion/runtime/legion/runtime.cc:13133
[3] #16 0x0000000011822da0 in Legion::Internal::Runtime::process_message_task (this=0x16b25f80, args=0x2034b01984ec, arglen=148) at /g/g15/yadav2/taco/legion/legion/runtime/legion/runtime.cc:25578
[3] #17 0x000000001183dc44 in Legion::Internal::Runtime::legion_runtime_task (args=0x2034b01984e0, arglen=152, userdata=0x194dd7a0, userlen=8, p=...) at /g/g15/yadav2/taco/legion/legion/runtime/legion/runtime.cc:31003
[3] #18 0x00000000126d67e0 in Realm::LocalTaskProcessor::execute_task (this=0x16c37370, func_id=4, task_args=...) at /g/g15/yadav2/taco/legion/legion/runtime/realm/proc_impl.cc:1131
[3] #19 0x0000000012766bac in Realm::Task::execute_on_processor (this=0x2034b01987d0, p=...) at /g/g15/yadav2/taco/legion/legion/runtime/realm/tasks.cc:306
[3] #20 0x000000001276cf9c in Realm::UserThreadTaskScheduler::execute_task (this=0x19497750, task=0x2034b01987d0) at /g/g15/yadav2/taco/legion/legion/runtime/realm/tasks.cc:1646
[3] #21 0x000000001276a7dc in Realm::ThreadedTaskScheduler::scheduler_loop (this=0x19497750) at /g/g15/yadav2/taco/legion/legion/runtime/realm/tasks.cc:1127
[3] #22 0x00000000127761cc in Realm::Thread::thread_entry_wrapper<Realm::ThreadedTaskScheduler, &Realm::ThreadedTaskScheduler::scheduler_loop> (obj=0x19497750) at /g/g15/yadav2/taco/legion/legion/runtime/realm/threads.inl:97
[3] #23 0x000000001278b394 in Realm::UserThread::uthread_entry () at /g/g15/yadav2/taco/legion/legion/runtime/realm/threads.cc:1337
[3] #24 0x000020000655388c in makecontext () at ../sysdeps/unix/sysv/linux/powerpc/powerpc64/makecontext.S:137
[3] #25 0x0000000000000000 in ?? ()

Can you make a frozen process on sapling?

I'm not having any luck reproducing the crash on Sapling. I can attach to the crashed process with GDB and print out things that you are interested in seeing though. Let me know if that works / what you want to see.

Pull and try again.

It looks like its working for me now, thanks! I'll open a separate issue if anything else comes up.


New feature for Compiler Class?

Example:
var compiler = new MySqlCompiler();

Query q1 = new Query("people");
q1.Insert(new Dictionary<string, object>
{
	["name"] = "Peter",
	["created"] = DateTime.Now.AddDays(-2)
});

SqlResult r1 = compiler.Compile(q1);

var q2 = q1.NewQuery()
	.From("people")
	.Select("*");

SqlResult r2 = compiler.Compile(q2);

System.Console.WriteLine(r1);
System.Console.WriteLine(r2);

Result Correct:

I would like to create a code in the Compiler class where it would leave the same class as if it were a new instance without doing the NewQuery Command?
Example
var compiler = new MySqlCompiler();

Query q1 = new Query("people");
q1.Insert(new Dictionary<string, object>
{
	["name"] = "Peter",
	["created"] = DateTime.Now.AddDays(-2)
});

SqlResult r1 = compiler
  .Compile(q1);  //After this line q1 is at its default and initial value without new instance

var q2 = q1
	.From("people")
	.Select("*");

Having a single instance generating SQL that from compiling the same class could generate new SQL without the intervention of the NewQuery() method!

First thanks for your suggestion :), the best appropriate approach to your case is to use the Clone method
var baseQuery = new Query("People");

var q1 = baseQuery.Clone();
// some code here

var q2 = baseQuery.Clone();
// some code here

I don't see this would be really helpful since 1) the compiler should not change/modify the query in any way, 2) such implicit way would really confuse developers
for example, what if I want to compile the same query against multiple compilers ?

Good as I had already reported, I am making a package by joining with your package (which is fantastic), it is already in the nuget as beta:

https://www.nuget.org/packages/Canducci.SqlKata.Dapper/1.0.0-beta-1
https://www.nuget.org/packages/Canducci.SqlKata.Dapper.MySql/1.0.0-Beta-2

I saw this need at the time of calling with Dapper, maybe solve this differently, if not every time we have to do it like this:
string cns = "Server=localhost;Database=testdb;Uid=root;Pwd=senha;SslMode=none";
MySqlConnection connection = new MySqlConnection(cns);

var log = connection.Build()
	.From("people")
	.Insert(new Dictionary<string, object>
	{
		["name"] = "Pedro c",
		["created"] = DateTime.Now.AddDays(-2)
	})
       .Execute();

var result = connection.Build()
	.NewQuery()
	.Select("*")
	.From("people")
	.Query();

The connection.Build() always creates a new instance, I wish it did not happen.
That is, this gives problem in the second execution
build
	.From("people")
	.Insert(new Dictionary<string, object>
	{
		["name"] = "Pedro c",
		["created"] = DateTime.Now.AddDays(-2)
	})
	.Execute(); // ok

build
	.Select("*")
	.From("people")
	.Query(); // problem ...

I accept suggestions. !!!

Has the project stopped?

@fulviocanducci no sir, @ahmad-moussawi has been making regular commits and merges but the updates are on the myget feed. I have been tied up with work for a while but catching back up.
I'm sure we will work out a push to nuget soon

@ceastwood and @ahmad-moussawi
What would be the command to restart the class Query?
That?
public override Query NewQuery()
{
            return new Query().SetEngineScope(EngineScope);
}

For some time this issue has been open, but has not yet been solved, and versions and versions have been released, I ask:

Do you think this should not be done?

Do you think that putting a method to leave the class at a default value for the generation of a new SQL would not be valid?

I would like to have an answer on the issue, so I can make decisions about a package I develop on top of that!

Thank you

I'm waiting for this is a pull request about recovering the inserted record!

@fulviocanducci, I've already suggested that you can use the Clone method for such cases.
Could you please elaborate more why this approach does not help in your case ?


Add support to disable over provisioning on cStor Pools

Description
It was observed in some cases that even though the application only effectively writes about 5GB of data, the underlying pool shows more than 50GB used. Sometimes the pool can be 100% full after which the pool stops serving IO causing the applications to fail.
Context
Over provisioning is enabled by default on cStor volumes. Example, users will be able to create a volume of 200GB on cStor Pool with disk capacity of 100G. This allows for cases where user can save cost on the underlying storage spend and increase the capacity of the pools by adding more disks or expanding the disks, as volume starts consuming the space.
The usage can be monitored by looking at the volume and pool metrics.
While the above is applicable for the write-intensive workloads like Elastic, the workloads like postgresql that will potentially modify the existing blocks can end up quickly consuming more space from the pool.
In case of postgres, that typically installs Ext4 on top of the cstor volumes will result in the following:

Ext4 is mounted without unmap support
As data is written and modified, Ext4 tends to use new blocks of storage - without sending any delete (unmap) requests back to the underlying block storage - like cStor.
As the volumes are over provisioned, cStor keeps allocating new blocks from the pool.

This will result in a case where the application would have effectively used only 3GB of data on ext4, but about 100GB of data is already utilized in the pool because volume (ext4) quota is set at 200GB.
Workaround
Enable storage class based resource quota to set a limit on the sum of capacity allocated to all the PVCs to be within the available capacity of the underlying cStor Pools. https://kubernetes.io/docs/concepts/policy/resource-quotas/#enabling-resource-quota
Possible solution

Provide an option at the cStor Storage Class to disable over provisioning

disabling thin provisioning may sound like solves this issue, but, user faces errors during provisioning time.. it should be part of best practices for user to look at pool usage and take necessary actions.
unmap is worth to have but this will be useful in the cases when user anticipated volume size wrongly with workloads that does writes and deletes (like above)

When pool becomes full, cstor-pool container crashes continuously. This ends up in OS disk space consumption to store cores.
This PR https://github.com/openebs/cstor/pull/282 disables dumping core by default.

request made in this issue https://github.com/openebs/openebs/issues/2673 is to disable thin provisioning, which is same as this issue

The overprovisioning feature has not yet made into the CSPC based pools. Reopening the issue to track that.

Groom and take a call on this issue.

The initial idea on this was to have a delayed binding for CVR by a new cvr controller that is basically a constraint-based storage scheduler :
We need to have a separate controller(let us say this as cvr-scheduler as of now) that watches for CVR. Once the CVR is created, it is unassigned, meaning it does not belong to any CSPI. Now, this cvr-scheduler enforces policies and requirements e.g. overprovisioning etc and picks up appropriate or most suitable CSPI for the particular CVR and assigns this CVR to a CSPI by patching the CVR. This patching will basically put the selected CSPI name and UUID on the CVR.
Now, the actual cvr-operator ( replica controller ) -- also watches for the CVRs. It ignores the CVR that has not been assigned any CSPI. Once the CVR is assigned to a CSPI, the replica controller processes the CVR to carry out the volume provisioning.
The advantages of this approach are as follows :

Volume replica distribution is achieved easily and users can specify a variety of policies or enforcements to have the CVRs assigned to the most suitable CSPI. ( e.g. overprovisioning is just a policy that can be optionally enforced )
Incremental policies can just be added to the cvr-scheduler and this new controller as this sole responsibility of just scheduling the CVR to a CSPI. [Sepration of concerns] This can drastically improve the development time as a developer will not need to worry about the hidden complexities involved in the replica controller.
There will be an option to bypass the cvr-scheduler in case there is a requirement for quick scheduling for use cases where software need to create volumes on demand. For example, software that launches workspace for users ( e.g. gitpod, hackerrank, etc ). The volume provisioning should be quick in this case so that the user has instantly an IDE/workspace ready.
If the scheduler is bypassed, the CVR will be bind to the CSPI by the current way it is binding.


Add cli flag to enable root volume encryption

What this PR does / why we need it:
Enables setting KMS encryption key for nodepool root volume encryption.
Which issue(s) this PR fixes (optional, use fixes #<issue_number>(, fixes #<issue_number>, ...) format, where issue_number might be a GitHub issue, or a Jira story:
Fixes #
Checklist

[ ] Subject and description added to both, commit and PR.
[ ] Relevant issues have been referenced.
[ ] This change includes docs.
[ ] This change includes unit tests.

thanks!
/approve
PTAL @bryan-cox

Looks good to me. Just had one really minor nit.
Does this have a corresponding Jira ticket? If so, we should probably reference that in the PR description.

/lgtm

/lgtm


Cash Only incorrectly returned as true

http://dgri-mantle.herokuapp.com/location/facebook/garagebargr

[Fixed by #36]


[Bug report] Error on Chrome

Version
8.1.0
Platforms
Web
Device Model
Chrome
flutter info
Doctor summary (to see all details, run flutter doctor -v):
[!] Flutter (Channel [user-branch], 3.14.0-9.0.pre.48, on macOS 13.4 22F66 darwin-arm64, locale zh-Hans-CN)
! Flutter version 3.14.0-9.0.pre.48 on channel [user-branch] at /Users/tyzl/flutter
Currently on an unknown channel. Run flutter channel to switch to an official channel.
If that doesn't fix the issue, reinstall Flutter by following instructions at
https://flutter.dev/docs/get-started/install.
[✓] Android toolchain - develop for Android devices (Android SDK version 30.0.3)
[✓] Xcode - develop for iOS and macOS (Xcode 14.3.1)
[✓] Chrome - develop for the web
[✓] Android Studio (version 2021.2)
[✓] IntelliJ IDEA Ultimate Edition (version 2023.1.3)
[✓] VS Code (version 1.80.1)
[✓] Connected device (4 available)
[✓] Network resources

How to reproduce?
Launching lib/main.dart on Chrome in debug mode...
Waiting for connection from debug service on Chrome...
../../../../.pub-cache/hosted/pub.flutter-io.cn/extended_image_library-3.6.0/lib/src/network/network_image_web.dart:14:8: Error: Error when reading '../../../../flutter/packages/flutter/lib/src/services/dom.dart': No such file or directory
import 'package:flutter/src/services/dom.dart';
^
../../../../.pub-cache/hosted/pub.flutter-io.cn/extended_image_library-3.6.0/lib/src/network/network_image_web.dart:20:30: Error: Type 'DomXMLHttpRequest' not found.
typedef HttpRequestFactory = DomXMLHttpRequest Function();
^^^^^^^^^^^^^^^^^
../../../../.pub-cache/hosted/pub.flutter-io.cn/extended_image_library-3.6.0/lib/src/network/network_image_web.dart:23:1: Error: Type 'DomXMLHttpRequest' not found.
DomXMLHttpRequest _httpClient() {
^^^^^^^^^^^^^^^^^
../../../../.pub-cache/hosted/pub.flutter-io.cn/extended_image_library-3.6.0/lib/src/network/network_image_web.dart:24:10: Error: Method not found: 'DomXMLHttpRequest'.
return DomXMLHttpRequest();
^^^^^^^^^^^^^^^^^
../../../../.pub-cache/hosted/pub.flutter-io.cn/extended_image_library-3.6.0/lib/src/network/network_image_web.dart:153:23: Error: 'DomXMLHttpRequest' isn't a type.
final Completer completer =
^^^^^^^^^^^^^^^^^
../../../../.pub-cache/hosted/pub.flutter-io.cn/extended_image_library-3.6.0/lib/src/network/network_image_web.dart:154:21: Error: 'DomXMLHttpRequest' isn't a type.
Completer();
^^^^^^^^^^^^^^^^^
../../../../.pub-cache/hosted/pub.flutter-io.cn/extended_image_library-3.6.0/lib/src/network/network_image_web.dart:155:13: Error: 'DomXMLHttpRequest' isn't a type.
final DomXMLHttpRequest request = httpRequestFactory();
^^^^^^^^^^^^^^^^^
../../../../.pub-cache/hosted/pub.flutter-io.cn/extended_image_library-3.6.0/lib/src/network/network_image_web.dart:165:64: Error: 'DomEvent' isn't a type.
request.addEventListener('load', createDomEventListener((DomEvent e) {
^^^^^^^^
../../../../.pub-cache/hosted/pub.flutter-io.cn/extended_image_library-3.6.0/lib/src/network/network_image_web.dart:165:40: Error: The method 'createDomEventListener' isn't defined for the class 'ExtendedNetworkImageProvider'.
'ExtendedNetworkImageProvider' is from 'package:extended_image_library/src/network/network_image_web.dart' ('../../../../.pub-cache/hosted/pub.flutter-io.cn/extended_image_library-3.6.0/lib/src/network/network_image_web.dart').
Try correcting the name to the name of an existing method, or defining a method named 'createDomEventListener'.
request.addEventListener('load', createDomEventListener((DomEvent e) {
^^^^^^^^^^^^^^^^^^^^^^
../../../../.pub-cache/hosted/pub.flutter-io.cn/extended_image_library-3.6.0/lib/src/network/network_image_web.dart:184:20: Error: The method 'createDomEventListener' isn't defined for the class 'ExtendedNetworkImageProvider'.
'ExtendedNetworkImageProvider' is from 'package:extended_image_library/src/network/network_image_web.dart' ('../../../../.pub-cache/hosted/pub.flutter-io.cn/extended_image_library-3.6.0/lib/src/network/network_image_web.dart').
Try correcting the name to the name of an existing method, or defining a method named 'createDomEventListener'.
'error', createDomEventListener(completer.completeError));
^^^^^^^^^^^^^^^^^^^^^^
Failed to compile application.
Logs
No response
Example code (optional)
No response
Contact
No response

Hello
I've the same issue
[✓] Flutter (Channel stable, 3.13.0, on macOS 13.3.1 22E772610a darwin-arm64, locale fr-FR)
[✓] Android toolchain - develop for Android devices (Android SDK version 32.0.0)
[✓] Xcode - develop for iOS and macOS (Xcode 14.3.1)
[✓] Chrome - develop for the web
[✓] Android Studio (version 2022.3)
[✓] IntelliJ IDEA Ultimate Edition (version 2022.3.3)
[✓] VS Code (version 1.81.1)
[✓] Connected device (2 available)
[✓] Network resources

Hello I've the same issue
[✓] Flutter (Channel stable, 3.13.0, on macOS 13.3.1 22E772610a darwin-arm64, locale fr-FR)
[✓] Android toolchain - develop for Android devices (Android SDK version 32.0.0)
[✓] Xcode - develop for iOS and macOS (Xcode 14.3.1)
[✓] Chrome - develop for the web
[✓] Android Studio (version 2022.3)
[✓] IntelliJ IDEA Ultimate Edition (version 2022.3.3)
[✓] VS Code (version 1.81.1)
[✓] Connected device (2 available)
[✓] Network resources

i can't reproduce it at 3.13.0

3.16.0 is already

i have a sample problem
`
extended_image: ^8.1.0
[✓] Flutter (Channel stable, 3.16.3, on macOS 14.1 23B74 darwin-arm64, locale zh-Hans-CN)
• Flutter version 3.16.3 on channel stable at /Users/a1/Downloads/flutter
• Upstream repository https://github.com/flutter/flutter.git
• Framework revision b0366e0a3f (7 天前), 2023-12-05 19:46:39 -0800
• Engine revision 54a7145303
• Dart version 3.2.3
• DevTools version 2.28.4
⢿
[✓] Android toolchain - develop for Android devices (Android SDK version 34.0.0)
• Android SDK at /Users/a1/Library/Android/sdk
• Platform android-34, build-tools 34.0.0
• Java binary at: /Applications/Android Studio.app/Contents/jbr/Contents/Home/bin/java
• Java version OpenJDK Runtime Environment (build 17.0.6+0-17.0.6b829.9-10027231)
• All Android licenses accepted.
[✓] Xcode - develop for iOS and macOS (Xcode 15.0.1)
• Xcode at /Applications/Xcode.app/Contents/Developer
• Build 15A507
• CocoaPods version 1.14.3
[✓] Chrome - develop for the web
• Chrome at /Applications/Google Chrome.app/Contents/MacOS/Google Chrome
[✓] Android Studio (version 2022.3)
• Android Studio at /Applications/Android Studio.app/Contents
• Flutter plugin can be installed from:
🔨 https://plugins.jetbrains.com/plugin/9212-flutter
• Dart plugin can be installed from:
🔨 https://plugins.jetbrains.com/plugin/6351-dart
• Java version OpenJDK Runtime Environment (build 17.0.6+0-17.0.6b829.9-10027231)
[✓] VS Code (version 1.84.2)
• VS Code at /Applications/Visual Studio Code.app/Contents
• Flutter extension version 3.78.0
[✓] Connected device (3 available)
• iPhone13 (mobile) • 00008110-000470CA2E2A801E • ios            • iOS 17.1 21B74
• macOS (desktop)   • macos                     • darwin-arm64   • macOS 14.1 23B74
darwin-arm64
• Chrome (web)      • chrome                    • web-javascript • Google Chrome
116.0.5845.96
`

any update?

could you please check the changelog? pick the version which fit your flutter sdk


[terra-date-input-field] error message and focus indicator updates

Summary

Added focus to the first input field when the toggle button has been clicked. Now the screen reader reads the error message immediately when the button has been clicked.
Added black dashed border for input field when it has focus.

What was changed:
Why it was changed:
Testing

This change was tested using:

[ ] WDIO
[ ] Jest
[ ] Visual testing (please attach a screenshot or recording)
[ ] Other (please describe below)
[ ] No tests are needed

Reviews
In addition to engineering reviews, this PR needs:

[ ] UX review
[ ] Accessibility review
[ ] Functional review

Additional Details

This PR resolves:
UXPLATFORM-10106 & UXPLATFORM-10107

Thank you for contributing to Terra.
@cerner/terra

Regarding this PR, the points they have mentioned:

Provided a black border for the input field that has focus.
When the toggle button is triggered, then the focus moves to the first input field.
are now fixed, expect the error message that appears is not exposed by screen reader when the focus moves to the first input field when the toggle button is triggered.

The screen does read out "Invalid data/entry" when the focus is on the first input field, this is because of the aria-invalid="true" added to it and the error message is not associated with the input field using "aria-describedby" attribute.

Regarding this PR, the points they have mentioned:

Provided a black border for the input field that has focus.
When the toggle button is triggered, then the focus moves to the first input field.
are now fixed, except the error message that appears is not exposed by the screen reader when the focus moves to the first input field when the toggle button is triggered.

The screen does read out "Invalid data/entry" when the focus is on the first input field, this is because of the aria-invalid="true" added to it and the error message is not associated with the input field using the "aria-describedby" attribute.

Updated.

@KV106606Viswanath Can we add a wdio test for the error message display ?

+1
As, the issues mentioned in my previous comments are fixed now, the error message that appears when toggle button is triggered is exposed by screen reader when focused.

@KV106606Viswanath Can we add a wdio test for the error message display ?

Added


:Prettier fills the default register with “x”

On Neovim, formatting a file replaces the default register by x.
The issue gets fixed by commenting these three lines: https://github.com/prettier/vim-prettier/blob/master/autoload/prettier/utils/buffer.vim#L11-L15
The cursor stays in place even after having commented these lines − is it really needed on Neovim?

:PrettierVersion => 1.0.0-alpha
:PrettierCliVersion => 2.0.5
Did this work before? => I am not sure, I was using a custom function to call the prettier CLI before, and I don’t remember if the move to the Vim plugin corresponds to my default register getting “randomly” replaced by x.

👏  i was going crazy today over this! couldnt figure out what i was doing that was causing this.

Oh my god, thank you for this. I had no idea which plugin was doing this.

Horrible bug ! Really annoying.


Made correction to fix TINKERPOP3-855.

This fixes the issue with Json submitted sasl arguments not being in byte[] format.
It is not BC breaking. Tests seem to pass though I wouldn't mind confirmation here.
I also added changes to the documentation to reflect the new functionality.

It's worth going through the issue as I've made an arbitrary decision on the JSON input type and this needs to be reviewed.


Implement Cloud Trails

What

Created TF module to enable the AWS CloudTrail service

Why

We need a tool that provide us to enable or disable the AWS CloudTrail service

[ ] Fix LICENSE copyright.


Create dependabot.yaml

Since npm is only used for development, monthly checks should be sufficient.

Thanks for the pull request. This library is more or less complete and so I don't think I need to update dev dependencies. If you feel strongly about this, could you add a GitHub action file to at least run the builds? Otherwise I would be worried to introduce regressions.

Thank you for the fast reaction. I think it's desirable to use the latest versions of the dependencies in the build process. And I thought this approach made sense, but if you see it differently, I'm not disappointed :slightly_smiling_face:
Do you see a better approach to ensure every build process is using the latest dependency versions? Maybe put npm-check-updates at the beginning of the build process?

I honestly don't see the need to update the Dev dependencies. They work so I would rather just keep them as is and update manually.

Okay, for me it's okay that it stays the way it is :slightly_smiling_face:


Superscript/subscript immediately following italics/bold text is incorrectly italics/bold

When writing formatted text immediately followed by unformatted superscript/subscript text, the superscript/subscript incorrectly has the formatting of the preceding text.
Ex:
BOLDsuperscript
becomes
BOLDsuperscript
ITALICSsuperscript
becomes
ITALICSsuperscript

Yes, I can see this -- thanks for reporting. I am making some larger changes to Docs to Markdown, but I'll try to get to this bug soon.

Thanks. I appreciate the development time. I forked the project and I'm going to see if I can figure out some other tweaks/issues I've had.


Add dynamic density mask to 'ecco' package

Incorporate the changes to the 'ecco' package following the modifications in the 'code' directory here:
https://github.com/so-wise/verification_other/tree/density_mask_dj/global_oce_cs32/code
This works in the verification_other case.

 Establish dynamic objective function MITgcm feature


What is the correct way to tag versions/releases?

We have been trying to get version/release tagging to work however we are not clear on the way you are meant to do it on the PHP side.
Could you please let me know how to do this and also update the docs to reflect this.
Thanks.

Nevermind ID 10 T error.


Merge v1

Fixes #N/A
Description
How was this change tested?
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Pull Request Test Coverage Report for Build<PHONE_NUMBER>
Details

704 of 783 (89.91%)  changed or added relevant lines in 69 files are covered.
251 unchanged lines in 10 files lost coverage.
Overall coverage decreased (-0.6%) to 77.68%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

pkg/controllers/node/termination/controller.go
9
10
90.0%

pkg/controllers/nodeclaim/lifecycle/controller.go
2
3
66.67%

pkg/controllers/nodeclaim/lifecycle/launch.go
14
15
93.33%

pkg/controllers/nodeclaim/lifecycle/registration.go
17
18
94.44%

pkg/controllers/nodepool/hash/controller.go
11
12
91.67%

pkg/controllers/nodepool/readiness/controller.go
8
9
88.89%

pkg/controllers/nodepool/validation/controller.go
3
4
75.0%

pkg/controllers/state/informer/nodeclaim.go
1
2
50.0%

pkg/controllers/state/informer/nodepool.go
1
2
50.0%

pkg/utils/disruption/disruption.go
4
5
80.0%

Files with Coverage Reduction
New Missed Lines
%

pkg/controllers/metrics/pod/controller.go
1
77.42%

pkg/controllers/state/statenode.go
1
84.62%

pkg/operator/operator.go
1
4.03%

pkg/apis/v1beta1/labels.go
2
92.59%

pkg/apis/v1beta1/nodeclaim_validation.go
2
89.41%

pkg/apis/v1beta1/taints.go
3
0.0%

pkg/apis/v1beta1/nodepool_status.go
12
0.0%

pkg/apis/v1beta1/nodeclaim_status.go
13
0.0%

pkg/apis/v1beta1/nodepool.go
23
67.86%

pkg/apis/v1beta1/zz_generated.deepcopy.go
193
19.51%

Totals

Change from base Build<PHONE_NUMBER>:
-0.6%

Covered Lines:
8885

Relevant Lines:
11438

💛  - Coveralls


Implement communications failure alarm in controller

What has to be done
If the controller does not receive data from the GUI for a certain defined amount of time, then the buzzer should sound.
Outstanding questions:

[ ] how long of a delay before alarming?
[ ] can alarm be silenced or reset? Discussed in #750
[ ] how loud must it be?

How do you know it has to be done
Because this is the main failure mode for our communications protocol.
TODO: Reference requirement or architecture document
Code pointers

Buzzer is implemented under software/controller/lib/hal/buzzer.cpp
Some sample code for how to make it work is under software/controller/integration_tests/buzzer_test.h
TODO: how about the communications aspect?

Other
Some draft how this should work has been outlined here: https://respiraworks.slack.com/archives/C0100SF3N5T/p1595426399016900

TODO: create a ticket for the converse of this -- GUI alarms on comms breakdown with controller.


Update README.md

Description
I've completed a content review and made edits to the instances README.md file text as part of AHA Epic DAF-299.
This review is related to the following issues:
https://github.ibm.com/GoldenEye/issues/issues/7808
https://github.ibm.com/Bluemix/docs/issues/10671
Run the pipeline
If the CI pipeline doesn't run when you create the PR, the PR requires a user with GitHub collaborators access to run the pipeline.
Run the CI pipeline when the PR is ready for review and you expect tests to pass. Add a comment to the PR with the following text:
/run pipeline

Checklist for reviewers

[ ] If relevant, a test for the change is included or updated with this PR.
[ ] If relevant, documentation for the change is included or updated with this PR.

For mergers

Use a conventional commit message to set the release level. Follow the guidelines.
Include information that users need to know about the PR in the commit message. The commit message becomes part of the GitHub release notes.
Use the Squash and merge option.

@maheshwarishikha Can you do a final review on this PR?

@maheshwarishikha I think I've captured the intent in the readme. Can you review again? Thanks.

@maheshwarishikha I think I've captured the intent in the readme. Can you review again? Thanks.

LGTM, approved. Thanks

/run pipeline

:tada: This PR is included in version 1.8.2 :tada:
The release is available on:

GitHub release
v1.8.2

Your semantic-release bot :package::rocket:


Add support for extracting features related to IM tests

Currently the IM tests do not have extractors for them, as in the measurement is ingested, but no test specific metadata (ex. WhatsApp is blocked by this means) is currently populating any metadb tables.
I think this should go together with https://github.com/ooni/pipeline/issues/133 so that we also improve the docs for this process.

[ ] Add feature extractor for Telegram (https://github.com/ooni/spec/blob/master/nettests/ts-020-telegram.md)
[ ] Add feature extractor for WhatsApp (https://github.com/ooni/spec/blob/master/nettests/ts-018-whatsapp.md)
[ ] Add feature extractor for Facebook Messenger (https://github.com/ooni/spec/blob/master/nettests/ts-019-facebook-messenger.md)

This has been done.


added domain files for DELTA high school computer science and economics

Hello,
I would like to ask you to add domains for DELTA - high school of informatics and economics. There are two domains in my pull request. One domain is delta-skola.cz. This domain is used by teachers. The second domain is delta-studenti.cz. This domain is used by students. Graduates do not have email addresses.
School website: https://www.delta-skola.cz/
Address with information on the field of information technology: https://www.delta-skola.cz/obor-informacni-technologie-18-20-m-01/
You can verify that the domain delta-skola.cz belongs to the teachers at this address: https://www.delta-skola.cz/kontakty and information about second domain (delta-studenti.cz) you can find on this address: https://www.delta-skola.cz/kontakty/#Studenti
Thank you very much.

Hello @philipto
Is there a problem with my pull request? I'm a little nervous that the newer PRs are after the first round of verification, but mine still isn't. Anything I can add.
Thank you very much.

@pesektomas Thank you for your patience while waiting for a review and processing your request. Pull request merged.


⚠ Bofrost.fr has degraded performance

In 67969ac, Bofrost.fr (https://www.bofrost.fr) experienced degraded performance:

HTTP code: 200
Response time: 1137 ms

Resolved: Bofrost.fr performance has improved in 441b06b after 310 days, 14 hours, 14 minutes.


FIX: Reenable parallel port triggering

@mfreilly can you try this branch on the experimental computer that will run the auditory paradigm? Once it appears to work, we should probably verify that the timing accuracy (jitter and delay) with an oscilloscope.

@rkmaddox you might also be interested in testing this to move toward TDT independence

Noted. Though our SPDIF solution is already in the works.

Yes this would be more for if you wanted triggering during the sound stimulus (or without sound playing), e.g. to give times of visual stim flips or response windows, etc.

Ahhh gotcha. So I could potentially use just channel 0 for sound stimulus, and then do the others with parallel port. Not a bad idea.

If you want to spend $20 on a parallel port card and do some testing, feel free :)


[Bug Report]: IMessageSerializer interface doesn't exist in KafkaFlow.Abstractions

Prerequisites

[X] I have searched issues to ensure it has not already been reported

Description
I've been following the docs while implementing serializers.
On the website it says:
services.AddKafka(kafka => kafka
    .AddCluster(cluster => cluster
        .WithBrokers(new[] { "localhost:9092" })
        .AddProducer<ProductEventsProducer>(producer => producer
            ...
            .AddMiddlewares(middlewares => middleware
                ...
                .AddSerializer<JsonMessageSerializer>() // Using the DefaultMessageTypeResolver (**I'M USING THIS ONE**)
                // or
                .AddSerializer<JsonMessageSerializer, YourTypeResolver>()
                // or
                .AddSerializer(
                    resolver => new JsonMessageSerializer(...),
                    resolver => new YourTypeResolver(...))
                // or
                .AddSingleTypeSerializer<JsonMessageSerializer, YourMessageType>()
                // or
                .AddSingleTypeSerializer<YourMessageType>(resolver => new JsonMessageSerializer(...))
                ...
            )
        )
    )
);

But, for some reason I get an error that says:
Reference to type 'IMessageSerializer' claims it is defined in 'KafkaFlow.Abstractions', but it could not be found
I checked in this repository in the nuget KafkaFlow.Abstractions and I see that the IMessageSerializer interface just doesn't exist there...
What should I do?
Steps to reproduce

In the AddMiddlewares section try to add AddSerializer
Add JsonMessageSerializer that implements IMessageSerializer

Expected behavior
The IMessageSerializer should be present in the KafkaFlow.Abstractions nuget package.
Actual behavior
IMessageSerializer doesn't exist in the KafkaFlow.Abstractions nuget.
KafkaFlow version
2.2.16

Hi, @bornahrastovec,
We suggest you update to version 3, where IMessageSerializer was replaced by ISerializer/IDeserializer  and is part of KafkaFlow.Abstractions. You shouldn't experience that issue then, but let us know if that happens.


Using real calculated risk scores for each department to be displayed on the map

Hi guys,
This PR adds real risk scores data to the web app.
At this point, the data is retrieved in a 'static' way from here 'https://github.com/pyronear/pyro-risks/releases/download/v0.1.0-data/pyrorisk_20200901.json'
Note that 3 departments do not have risk scores, though it won't be a problem for the presentation as they're all located in the Ile de France region.
When I'll have time I'll look for a better way to store the data in a dcc.Store() object while launching the app, then using it to 'populate' the risk map.
Tell me if you have any remark, and thanks @frgfm for the help!
@frgfm @Akilditu

@nrslt also I'm a tiny bit suspicious of that failed test. Could you try to run:
gunicorn --workers 1 -b <IP_ADDRESS>:8050 --chdir ./app main:server

on your branch please? If this fails, we need to fix it

Thanks @frgfm @Akilditu I added a gif of how the app renders.
@frgfm the gunicorn command works on my side, though there is still this docker-gunicorn failed test.. We can discuss it quickly today if you want.


prepare_ml stuck on PV

Describe the bug
Get stuck ladoing solar PV data
To Reproduce
Steps to reproduce the behavior:
run the preapre_ml_data script
error:
Loading Solar PV Data from /mnt/storage_b/data/ocf/solar_pv_nowcasting/nowcasting_dataset_pipeline/PV/PVOutput.org/UK_PV_timeseries_batch.nc from None to None. at /home/peter/Github/nowcasting_dataset/nowcasting_dataset/data_sources/pv/pv_data_source.py#L337

Expected behavior
Perhaps it takes a few minutes to load
Additional context
the error might actually be the next thing not loading

THis may also be due to Sat files being processed, so maybe try again after this process if finished


Column name

Add a way to define the database column name, the same as the table name
#[sea_orm(table_name = "User")] // set the table name (currently exists)
pub struct Model {
    #[sea_orm(primary_key)]
    pub id: u64,
    #[sea_orm(unique)]
    pub name: String,
    pub password: String,
    pub salt: String,
    #[sea_orm(colunm_name = "createAt")] // set column name (does not currently exist)
    pub create_at: DateTime,
    #[sea_orm(colunm_name = "updateAt")] // set column name (does not currently exist)
    pub update_at: Option<DateTime>,
}

Hey @Gabriel-Paulucci, I think you can.
https://github.com/SeaQL/sea-orm/blob/acf8eac4419ddef90028d8ae839388986940b08d/src/entity/column.rs#L550


Rename chapter: devon4net -> .net

Rename chapters in docs
devon4net -> .net

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.dolvie seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.You have signed the CLA already but the status is still pending? Let us recheck it.


Implementing configuration file

As per issue #94 & #53 , we need to implement a configuration file to tune the behavior of ceph-nano regarding the expectations of users.
This PR will implement all the needed to get a configuration mecanism to override or define some tuning parameters.
As the exisiting cn is not supporting any config file, not having one must not be fatal.

@leseb This PR is over for me.


bngblaster: 0.8.51 -> 0.9.2

Automatic update generated by nixpkgs-update tools. This update was made based on information from https://github.com/rtbrick/bngblaster/releases.
meta.description for bngblaster is: Network tester for access and routing protocols
meta.homepage for bngblaster is: https://github.com/rtbrick/bngblaster/
meta.changelog for bngblaster is: https://github.com/rtbrick/bngblaster/releases/tag/0.9.1
Updates performed

Version update

To inspect upstream changes

Release on GitHub

Compare changes on GitHub

Impact
Checks done

built on NixOS
The tests defined in passthru.tests, if any, passed
found 0.9.1 with grep in /nix/store/bkajxv2qn2xr28lcqbgqkdgl8lhdkxfj-bngblaster-0.9.1
found 0.9.1 in filename of file in /nix/store/bkajxv2qn2xr28lcqbgqkdgl8lhdkxfj-bngblaster-0.9.1

Rebuild report (if merged into master) (click to expand)

2 total rebuild path(s)

2 package rebuild(s)

First fifty rebuilds by attrpath

bngblaster

Instructions to test this update (click to expand)

Either download from Cachix:
nix-store -r /nix/store/bkajxv2qn2xr28lcqbgqkdgl8lhdkxfj-bngblaster-0.9.1 \
  --option binary-caches 'https://cache.nixos.org/ https://nix-community.cachix.org/' \
  --option trusted-public-keys '
  nix-community.cachix.org-1:mB9FSh9qf2dCimDSUo8Zy7bkq5CX+/rkCWyvRCYg3Fs=
  cache.nixos.org-1:6NCHdD59X431o0gWypbMrAURkbJ16ZPMQFGspcDShjY=
  '

(The Cachix cache is only trusted for this store-path realization.)
For the Cachix download to work, your user must be in the trusted-users list or you can use sudo since root is effectively trusted.
Or, build yourself:
nix-build -A bngblaster https://github.com/r-ryantm/nixpkgs/archive/01ecc91c9bd6a5bc568701ffd1b497416647b821.tar.gz

Or:
nix build github:r-ryantm/nixpkgs/01ecc91c9bd6a5bc568701ffd1b497416647b821#bngblaster

After you've downloaded or built it, look at the files and if there are any, run the binaries:
ls -la /nix/store/bkajxv2qn2xr28lcqbgqkdgl8lhdkxfj-bngblaster-0.9.1
ls -la /nix/store/bkajxv2qn2xr28lcqbgqkdgl8lhdkxfj-bngblaster-0.9.1/bin

Pre-merge build results
We have automatically built all packages that will get rebuilt due to
this change.
This gives evidence on whether the upgrade will break dependent packages.
Note sometimes packages show up as failed to build independent of the
change, simply because they are already broken on the target branch.
Result of nixpkgs-review --extra-nixpkgs-config '{ allowInsecurePredicate = x: true; }' run on x86_64-linux 1

1 package built:

bngblaster

Maintainer pings
cc @n0emis @vidister @johannwagner @yu-re-ka for testing.

Automatic update generated by nixpkgs-update tools. This update was made based on information from https://github.com/rtbrick/bngblaster/releases.
meta.description for bngblaster is: Network tester for access and routing protocols
meta.homepage for bngblaster is: https://github.com/rtbrick/bngblaster/
meta.changelog for bngblaster is: https://github.com/rtbrick/bngblaster/releases/tag/0.9.2
Updates performed

Version update

To inspect upstream changes

Release on GitHub

Compare changes on GitHub

Impact
Checks done

built on NixOS
The tests defined in passthru.tests, if any, passed
found 0.9.2 with grep in /nix/store/gy2zc9vidkip0jfvqb33kipxs9064r42-bngblaster-0.9.2
found 0.9.2 in filename of file in /nix/store/gy2zc9vidkip0jfvqb33kipxs9064r42-bngblaster-0.9.2

Rebuild report (if merged into master) (click to expand)

2 total rebuild path(s)

2 package rebuild(s)

First fifty rebuilds by attrpath

bngblaster

Instructions to test this update (click to expand)

Either download from Cachix:
nix-store -r /nix/store/gy2zc9vidkip0jfvqb33kipxs9064r42-bngblaster-0.9.2 \
  --option binary-caches 'https://cache.nixos.org/ https://nix-community.cachix.org/' \
  --option trusted-public-keys '
  nix-community.cachix.org-1:mB9FSh9qf2dCimDSUo8Zy7bkq5CX+/rkCWyvRCYg3Fs=
  cache.nixos.org-1:6NCHdD59X431o0gWypbMrAURkbJ16ZPMQFGspcDShjY=
  '

(The Cachix cache is only trusted for this store-path realization.)
For the Cachix download to work, your user must be in the trusted-users list or you can use sudo since root is effectively trusted.
Or, build yourself:
nix-build -A bngblaster https://github.com/r-ryantm/nixpkgs/archive/9217c58b79be1077e2cd2c1f263bc2d79103c1b4.tar.gz

Or:
nix build github:r-ryantm/nixpkgs/9217c58b79be1077e2cd2c1f263bc2d79103c1b4#bngblaster

After you've downloaded or built it, look at the files and if there are any, run the binaries:
ls -la /nix/store/gy2zc9vidkip0jfvqb33kipxs9064r42-bngblaster-0.9.2
ls -la /nix/store/gy2zc9vidkip0jfvqb33kipxs9064r42-bngblaster-0.9.2/bin

Pre-merge build results
We have automatically built all packages that will get rebuilt due to
this change.
This gives evidence on whether the upgrade will break dependent packages.
Note sometimes packages show up as failed to build independent of the
change, simply because they are already broken on the target branch.
Result of nixpkgs-review --extra-nixpkgs-config '{ allowInsecurePredicate = x: true; }' run on x86_64-linux 1

1 package built:

bngblaster

Maintainer pings
cc @n0emis @vidister @johannwagner @yu-re-ka for testing.


[sec:8] Missing good analysis practice

This is more of a general questions. We discuss how to analyse the data and check if the simulations make sense quite thoroughly. I feel there should also be a small subsection on best practices of how to show the results. I was thinking something along these lines here:
http://practicalcheminformatics.blogspot.com/2019/02/some-thoughts-on-evaluating-predictive.html
And maybe other topics such as, how to compare to experimental results, what should I look at DG , DDG, what kind of errors, what kind of plots make sense. Should this be included, or would you say this kind of discussion is out of scope?

Seems in scope.  Display of results is not my forte.

Agree it seems in scope.
People also often reference Scott Brown's work on the maximum R^2 that can be expected even out of a perfect model given experimental error. This may also be worth mentioning in such a discussion.

There is a small section on this now. I am not sure if we mention Scott Brown's work. I'll double check and add if necessary.


[bug]: Docker Timeout

Prerequisites

[X] I have searched for existing issues that already report this problem, without success.

EmbassyOS Version
<IP_ADDRESS>
Device
Laptop/Desktop
Device OS
Linux
Device OS Version
5.18
Browser
Firefox
Browser Version
100
Current Behavior
Docker Timeout seems to be the cause of the Photoview service mysteriously entering the "Stopping" state after no action by the user, and then getting stuck in that state.
Expected Behavior
Services run continuously when no action is taken
Steps to Reproduce

On services page
Find a service has gone into "Stopping" state, and become stuck there

Anything else?
No response

Matt thinks this is related to uninstalling

However I have definitely seen this in many places where uninstalls were not involved

I hit this on the latest Proxy update

035


Account for offset overlaps in RemoteLog deletion by size

Resolves https://github.com/satishd/kafka/issues/27
This fixes a bug in calculation of size when retention by size is enabled for a topic with remote storage enabled.

@kamalcph @satishd @wyuka please review.

@satishd @kamalcph this is ready for your review. New tests have been added and some more fixes have been added which are associated with the same context of calculation of log size.

Thanks for fixing this issue! LGTM.


Fixed typed_config and wrong pointer to envoy yaml config file

The typed_config changed from type.googleapis.com/envoy.extensions.filters.http.oauth2.v3alpha.OAuth2 -> type.googleapis.com/envoy.extensions.filters.http.oauth2.v3.OAuth2.
The instructions in readme has the start command ./envoy --base-id 0 -c envoy.yaml however no envoy.yaml exists in the project. Should be proxy.yaml.

LGTM.  Thanks for catching this.
ref, the v3 is in atleast
./envoy  version: 73b77ab4cb7c5fb6189769470780ba78bbc232fc/1.22.0-dev/Clean/RELEASE/BoringSSL


Use constant blocks to define constants instead of discrete definitions.

Signed-off-by: xichengliudui<EMAIL_ADDRESS>
Ⅰ. Describe what this PR did
Use constant blocks to define constants instead of discrete definitions.
Ⅱ. Does this pull request fix one issue?

NONE
Ⅲ. Why don't you add test cases (unit test/integration test)? (你真的觉得不需要加测试吗？)
/integration test
Ⅳ. Describe how to verify it
Ⅴ. Special notes for reviews

LGTM


Dead code elimination in flatten

Component
Forge
Describe the feature you would like
When using some libraries, the --flatten output will be gigantic as flatten will inline all imports. It would be neat if flatten would detect & remove unused imports.
When using re-export index files like here https://github.com/bgd-labs/aave-address-book/blob/main/src/AaveAddressBook.sol that makes it essentially impossible to use in foundry as the generated code will be unusable long.
Additional context
In addition to what i mentioned above i guess it might make sense to even eliminate unused code in the actually imported files. Not sure sure about this though.

Good catch.

@gakonst just realized the same is true for non flattened files.
When you have a file like:
// index.sol
import {A} from "a.sol";
import {B} from "b.sol";
import {C} from "c.sol";

// contract.sol
import {A, B} from "index.sol";

contract Contract {
  function test() public {
    A.noop();
  }
}

When I verify this contract it will include A, B and C although only A is used.

We'd need to do deeper parsing of the dependency graph for this kind of flattening I think?

0x6a67421e77Ef3FB718d2e6d01570Fe96CDf7B520

It's probably worth an additional flag as the automatic removal of unused imports may confuse some developers.
I believe this would be a valuable feature as we'll see more utility in index files, as shown by protocols in addition to aave.
The dependency graph only grows as protocols build across many chains, requiring index files.


[cdc] fix mysql cdc test char to string type mapping

Purpose

Linked issue: close #xxx

Tests

API and Format

Documentation

flink cdc ci normal.
https://github.com/apache/incubator-paimon/actions/runs/6293329017/job/17083713780?pr=2066


pressing escape on responsive dropdown error

even on official examples website pressing escape on "full screen responsive dropdown" gives this error

Uncaught TypeError: Cannot read property '1' of null
at Object.obj.closeEditor (jexcel.js:1605)
at HTMLDocument.jexcel.keyDownControls (jexcel.js:6259)

regards

This has been fixed v3.6.0+


Test Analyzer optional new/const on large code bases

dartfmt with Leaf’s extra hacks here: https://github.com/dart-lang/dart_style/tree/no-new-const-context
Result of running that on DDC, sdk libraries, and dart2js here: https://dart-review.googlesource.com/c/sdk/+/50100
Result of running that on flutter/examples here: https://github.com/leafpetersen/flutter/tree/optional_new_const
(this is part of the work for finishing optional new/const)

Brian and I between us ran his CL on all of the flutter examples, as well as dart2js, DDC, and the analyzer itself, all with new/const removed using dartfmt.  There are no issues with the flutter examples, but the others turned up this bug:  https://github.com/dart-lang/sdk/issues/32823 .
This also seems to be present in dev.43 .

As of https://dart.googlesource.com/sdk/+/2471888d4a3ce101ae7a642dc027c338a0114667 I have verified that:

Flutter examples all analyze correctly with and without new and const
pkg/compiler/lib analyzes correctly without new and const
pkg/dev_compiler/lib analyzes correctly without new and const
pkg/analyzer/lib analyzes correctly without new and const

@leafpetersen Thanks! Both for running all of the tests and for all your recent help getting analyzer updated to the new optional new and const feature. I suspect that we can close this issue now; what do you think?

I think so.  Thanks for getting this done quickly.  @dgrove feel free to reopen if you have additional tests in mind.


[Feature Request]: Add code completion shortcut key settings.

Problem Description
代码块放在两个```符号中可以保留格式，使聊天记录看起来更加规整。但是手动输入两次符号不够方便。
Code blocks enclosed in two ``` symbols can preserve formatting, making the chat log look more organized. However, manually typing the symbols twice is not very convenient.
Solution Description
是否可以考虑在文本输入区增加快捷键，快速输入两个```符号并使光标处于两个符号之间？
Could you consider adding a shortcut in the text input area to quickly input two ```symbols and place the cursor between them?
Alternatives Considered
No response
Additional Context
No response

Thank you for your feedback, we will adopt the suggestion

Thank you for your feedback, we will consider the proposal


In No Way can I access my custom schema

Describe the bug
I can see suggestions for supabase.schema("new_schema").table....
To Reproduce
See above
Expected behavior
Expected to call <schema_name>.<table_name>
Errors
File "xxx", line 18, in
supabase.schema()
TypeError: 'str' object is not callable
Other Info
Even if I change table name to supabase.table(f"<schema_name>.<table_name>") it only gives public.<schema_name>.<table_name>
Cant call ClientOptions() anymore (I think its no longer supported) as i have multiple tables and multiple schemas and cant fix to 1 schema.
Additional context
Please look into the issue, or suggest an alternative way. I know functions are a way but using python seems more easier than writing SQL functions.

ran into same issue which really reduces useful of this library when trying to use vecs schema. Would be great to support different schema at earliest

You can change the schema that's queried by passing it as part of the options argument to create_client:
from supabase import create_client
from supabase.lib.client_options import ClientOptions

opts = ClientOptions().replace(schema="new_schema")
client = create_client(url, key, options=opts)
# now all queries will be run in the `new_schema` schema

Let me know if you have any other questions!

That's nice but isn't there an option where i see that we can do supabase.schema("private").table("some_table")... i can see Schema suggestion on VS Code (may i know where it might be used)

The vscode suggestion is probably coming from here ; it's probably just picking up the attribute named schema.
Also I had forgotten earlier: We can switch the schema later, but that method is on the postgrest client
From supabase py you'd use this like so
from supabase import create_client
from supabase.lib.client_options import ClientOptions

opts = ClientOptions().replace(schema="new_schema")
client = create_client(url, key, options=opts)
# now all queries will be run in the `new_schema` schema

client.postgrest.schema("newest_schema")
# now all queries will be run in the `newest_schema` schema


Fix "method_complexity" issue in src/Commands/SmsSwitchConnectionCommand.php

Function putEnvToFile has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
https://codeclimate.com/github/zingimmick/laravel-sms/src/Commands/SmsSwitchConnectionCommand.php#issue_5ef2ec142caa4a0001000029

#55


Rework IAO import

Description of the issue
The procedure of the RO module has been worked over in #1154 and #1473. The process should now be transferred to the IAO module.
There is #1474 which is related to it, but which is poorly documented.
Ideas of solution
Copy the process of RO extraction for IAO extraction.
Workflow checklist

[ ] I am aware of the workflow for this repository

This is fixed by #1556