Keep one network label in each token card.

Currently there are 2 network labels on each token card. It is a bit of wasting and confusing.

We should keep only one.

@zhangzhongnan928 Finally have an allowance to do that! I can't wait to work on these cards.

@zhangzhongnan928 @jzaki  This is a bold change, so I would like to hear the feedback from anyone in the team. I simplified the first tab.

First tab is called "Assets" now
I moved "Add Token" below
No more heavy colors and backgrounds
I added Coin Symbols

@tomekalphawallet Thanks! Much more efficient use of space in the Assets tab. Some thoughts and comments:
Assets tab

Why do we call it Assets instead of Wallet? (because we use Wallet numerous times in the Settings tab)
What is the difference between All and Currencies? (we currently have All, Currency and Assets)
Do we show a placeholder icon when we don't have a logo for a row? Will it be likely that most of them don't have an icon? Where do we get icons?
For tokens that aren't native crypto currency, e.g. FIFA, do we no longer show which network they are on? Some cases where it might be confusing: CryptoKitties are on both Ethereum mainnet and Rinkeby. In the current design, the pill-shaped labels with filled background were supposed to invoke user-familiarity through the colors the users are supposedly (already?) familiar with.
What happens when the user scroll to reveal the rows at the bottom. Do the header (showing the total value) scroll off the top? Would be good if it does
We no longer show value appreciated. I don't know if it is useful to have
What is the "Jun 13th" for the FIFA ticket row? (If it is the date of the match, the token can represent one or more tickets from one or matches, so that wouldn't work, and it's specific to FIFA tickets, so we'll need to handle when it's not available, i.e. 99% of the tokens)
Most if not all tokens that are not native crypto currency, e.g FIFA, will not have a fiat value
The thin border around the token icons looks a bit unfinished

Send/Receive screen

Assuming this is for native crypto currency and ERC20s
How are TokenScript action buttons shown?
Is it showing 3 transaction records or as many as we can?
What happens when the user scroll to reveal the rows at the bottom. Do the header (showing the total value) scroll off the top? Would be good if it does
Maybe it's intentional (dynamics?) the oval in the Receive and Send buttons aren't symmetrical. Have you experimented with a version that is more circular? Wonder how it would look like? (and maybe we can remove the gray circular background in transactions if the symbols are already circular?)
I know most wallets have some form of receive and send buttons and often use arrows as symbols. But here's one thought, how about using a QR code icon as the receive button. That's what it does, right?
Why do we switch the positions of Send and Receive buttons (left/right)?
Shall we show the full address in the transactions history and only truncating if we can't fit them in small screens? (maybe we still need to truncate for the biggest screen, but we can show more)
Similar to the Assets tab, we probably still need to show the network name
In the current iOS version (when we tap on "Ethereum Blockchain" it opens Etherscan/blockscout. Would still be good to have that for power users (and developers like us).
How is TokenScript signature verification status and express of trust shown?
Since we already used the same icons for Send and Receive buttons above, I wonder if we can remove the text "Sent" and "Received" from the transaction history? But maybe it'll be inconsistent with the Transaction tab?
We used to have green numbers for amount received and red to denote amount sent. That seemed to be rather good for scanning. Alternatively considering making the Sent icon in the transaction list red?

Assets tab

Why do we call it Assets instead of Wallet? (because we use Wallet numerous times in the Settings tab)

This is realated to @jzaki comment about the Wallet tab. https://docs.google.com/drawings/d/1zVEYOD-ukvUote5k1Uo-jC6aASXz3IvQTA_qRfaudz4/edit
This is the context for a wallet app, not one quarter of it

What is the difference between All and Currencies? (we currently have All, Currency and Assets)

We can adapt these tabs to anything we want. I am open to suggestions.

Do we show a placeholder icon when we don't have a logo for a row? Will it be likely that most of them don't have an icon? Where do we get icons?

I can provide icons. We can create own base.

For tokens that aren't native crypto currency, e.g. FIFA, do we no longer show which network they are on? Some cases where it might be confusing: CryptoKitties are on both Ethereum mainnet and Rinkeby. In the current design, the pill-shaped labels with filled background were supposed to invoke user-familiarity through the colors the users are supposedly (already?) familiar with.

We have a second row (light grey color) to display secondary informations. The goal is to declutter cards. Is it possible to have a kitty that look exactly the same (the thumbnail) but is on different networks?

What happens when the user scroll to reveal the rows at the bottom. Do the header (showing the total value) scroll off the top? Would be good if it does

Yes, you are correct. Only tabs are sticked to the top.

We no longer show value appreciated. I don't know if it is useful to have

I believe it's not. As long as we do not offer trading.

What is the "Jun 13th" for the FIFA ticket row? (If it is the date of the match, the token can represent one or more tickets from one or matches, so that wouldn't work, and it's specific to FIFA tickets, so we'll need to handle when it's not available, i.e. 99% of the tokens

I asked in the group if someone can send me screenshots. I received the wallet address to watch, that was ... empty. So I used what previous designer did. If you could send me examples of other tokens, it would be great!

Most if not all tokens that are not native crypto currency, e.g FIFA, will not have a fiat value

Then, instead of saying $19.223 USD we can say 19.223 ETH. If you tap on it, you can switch to USD (according to current market price). I believe this is an excited information to all speculators.

The thin border around the token icons looks a bit unfinished

Not sure why you think so?

Send/Receive screen

Assuming this is for native crypto currency and ERC20s

Yes

How are TokenScript action buttons shown?

What do you mean by Tokenscript action buttons? If you would like to display more than just 2 (Send, Receive) buttons on the screen, you can easily do that. 3 buttons can easily fit, if you want more, swipe left to see more (you will a half of button no.4 to indicates there are more after swipe)

Is it showing 3 transaction records or as many as we can?

These 2 screens are just 2 out of 30+ screens are made. The reason why I asked for a feedback is that they are really important for the whole flow (and for the entire app) If I won't get this approved, then I have to tweak the rest too (to look like the same app).
I am still working on this part, but you can see what I have already came up with here:
https://www.dropbox.com/s/1n6wazkfcb9tr3b/Ethereum_Coin.png?dl=0

What happens when the user scroll to reveal the rows at the bottom. Do the header (showing the total value) scroll off the top? Would be good if it does

Yep.

Maybe it's intentional (dynamics?) the oval in the Receive and Send buttons aren't symmetrical. Have you experimented with a version that is more circular? Wonder how it would look like? (and maybe we can remove the gray circular background in transactions if the symbols are already circular?)

This is still pending. I am working on it.

I know most wallets have some form of receive and send buttons and often use arrows as symbols. But here's one thought, how about using a QR code icon as the receive button. That's what it does, right?

Then the symbol of "Received" should be a QR code too. Which is not ideal. As mentioned, would be happy to get a feedback on icons too. Keep in mind that we would need a.Sent b. Received c. Rejected d. Failed e. Purchased and probably many more.

Why do we switch the positions of Send and Receive buttons (left/right)?

Otherwise it would looked like these two arrows have a beef. Makes more sense to me to be honest.

Shall we show the full address in the transactions history and only truncating if we can't fit them in small screens? (maybe we still need to truncate for the biggest screen, but we can show more)
Similar to the Assets tab, we probably still need to show the network name

No need for a full address. I believe these addresses are scary. Do you recognize which one is yours by looking at the middle numbers? Most of the time last 4-5 or the first 4-5.

In the current iOS version (when we tap on "Ethereum Blockchain" it opens Etherscan/blockscout. Would still be good to have that for power users (and developers like us).

Do you know if any of our users do use this option? I would track this first, then decide if it's worth keeping it or not.  Is this important for you as a developer? How important?

How is TokenScript signature verification status and express of trust shown?

Not sure what do you refer to.

Since we already used the same icons for Send and Receive buttons above, I wonder if we can remove the text "Sent" and "Received" from the transaction history? But maybe it'll be inconsistent with the Transaction tab?

I believe that one day you could use just a ENS of the sender/recipient. But this is still melody of the future.

We used to have green numbers for amount received and red to denote amount sent. That seemed to be rather good for scanning. Alternatively considering making the Sent icon in the transaction list red?

This is tricky. We had that at the beginning. But the red color is associated with a failure/error. And receiving any funds is always a good emotion (as long this is not a reimbursement for a funeral costs etc.)

Assets tab

Why do we call it Assets instead of Wallet? (because we use Wallet numerous times in the Settings tab)

This is the context for a wallet app, not one quarter of it

Ok. Assets is certainly more correct, but Wallet is more common. Anyway, not a big deal.

Do we show a placeholder icon when we don't have a logo for a row? Will it be likely that most of them don't have an icon? Where do we get icons?

I can provide icons. We can create own base.

We can create our own icons for the native crypto currency rows. There are 11 of them for now. But almost every other token will not have an icon, because while there are popular ones like CryptoKitties, tokens are really like user-generated-content here — there can be an infinite number of them created by someone, somewhere. Do we use a single placeholder icon for them? i.e when we scroll a list of 100 tokens, other than the 11 native crypto currency icons which are unique, the other 89 of them are the same placeholder icon (if that's what we are thinking of doing).

For tokens that aren't native crypto currency, e.g. FIFA, do we no longer show which network they are on? Some cases where it might be confusing: CryptoKitties are on both Ethereum mainnet and Rinkeby. In the current design, the pill-shaped labels with filled background were supposed to invoke user-familiarity through the colors the users are supposedly (already?) familiar with.

We have a second row (light grey color) to display secondary informations. The goal is to declutter cards. Is it possible to have a kitty that look exactly the same (the thumbnail) but is on different networks?

Related to the point above about placeholder icons. Also, a row here represents a token (so "CryptoKitties" not "CryptoKitties #1 whose name is Kitty"), so the icon will probably be quite generic. Or it could be a generic CryptoKitties icon with a badge like "Ethereum" over it, but then that's back to displaying it.

I asked in the group if someone can send me screenshots. I received the wallet address to watch, that was ... empty. So I used what previous designer did. If you could send me examples of other tokens, it would be great!

I think the wallet was James'. Maybe you have to enable the Rinkeby network.

Most if not all tokens that are not native crypto currency, e.g FIFA, will not have a fiat value

Then, instead of saying $19.223 USD we can say 19.223 ETH. If you tap on it, you can switch to USD (according to current market price). I believe this is an excited information to all speculators.

Those tokens wouldn't have an ETH value too (sorry, should have noticed that earlier)

The thin border around the token icons looks a bit unfinished

Not sure why you think so?

Just an impression

Send/Receive screen

Assuming this is for native crypto currency and ERC20s

Yes

How are TokenScript action buttons shown?

What do you mean by Tokenscript action buttons? If you would like to display more than just 2 (Send, Receive) buttons on the screen, you can easily do that. 3 buttons can easily fit, if you want more, swipe left to see more (you will a half of button no.4 to indicates there are more after swipe)

The 3 buttons (Enable, etc) to the left of the Send button are added via TokenScript. We don't have a limit for the number of buttons that can be added (yet). But shrinking the button label font size to fit them as we do now is just a stop-gap measure. One way I suppose is to set a maximum of 2 additional buttons and if there are more, hide it become some kind of "..."/more construct.

Is it showing 3 transaction records or as many as we can?

These 2 screens are just 2 out of 30+ screens are made. The reason why I asked for a feedback is that they are really important for the whole flow (and for the entire app) If I won't get this approved, then I have to tweak the rest too (to look like the same app).

I don't understand. The current design for this screen shows exactly 3 (or fewer if the wallet has fewer transactions), whereas there is a separate Transaction tab which shows as many transactions are we can.
I am asking if in this new design, is it still showing 3 transactions or is the entire list scrollable in this screen? This is relevant also because in the current design, the transaction date is shown for each record, but in the new design, it's shown as a header which hints that there are more (all?) records that can be revealed when you scroll. This is also relevant because if this screen shows all the transactions, then maybe we don't need the Transactions tab anymore.
Did I misunderstand your request for comment? I can limit my comments to just the visual design and exclude the architecture and UX, if you'd prefer to look at them separately.

I know most wallets have some form of receive and send buttons and often use arrows as symbols. But here's one thought, how about using a QR code icon as the receive button. That's what it does, right?

Then the symbol of "Received" should be a QR code too. Which is not ideal.

Not necessarily. We can look at the Receive button (as part of Send and Receive) as a way to get the address, and not actually to receive a transaction. Seen that way, they don't have to have the same representation. In fact, the "Receive" button could well be accessible from the Assets tab, at the top left or right corner as a QR code icon or "Receive" button. It's all the same Ethereum address for every native crypto currency and native token until we support chains other than Ethereum. Users might have been used to finding Send and Receive buttons together though, but moving it out makes it much more convenient.

Shall we show the full address in the transactions history and only truncating if we can't fit them in small screens? (maybe we still need to truncate for the biggest screen, but we can show more)
Similar to the Assets tab, we probably still need to show the network name

No need for a full address. I believe these addresses are scary. Do you recognize which one is yours by looking at the middle numbers? Most of the time last 4-5 or the first 4-5.

I'm referring to the address at the other side of the transaction though. It's often not my wallet address. If I send from my wallet A to B, B is the address shown here. So I don't have to remember them. If I want to look up a transaction, it could be useful.

In the current iOS version (when we tap on "Ethereum Blockchain" it opens Etherscan/blockscout. Would still be good to have that for power users (and developers like us).

Do you know if any of our users do use this option? I would track this first, then decide if it's worth keeping it or not. Is this important for you as a developer? How important?

It's very important as a developer, because it lets you verify the transaction yourself. I know Victor uses it too. I have no idea if other use it too. But we can just let the icon take its place though.

How is TokenScript signature verification status and express of trust shown?

Not sure what do you refer to.

In the screenshot above, there's a green tick and green text "Verified by aw.app". That's the signature verification status. We might have display express of trust too.

Since we already used the same icons for Send and Receive buttons above, I wonder if we can remove the text "Sent" and "Received" from the transaction history? But maybe it'll be inconsistent with the Transaction tab?

I believe that one day you could use just a ENS of the sender/recipient. But this is still melody of the future.

I meant, since the user is trained to recognise the send and receive icons, the icons and the words "Sent" and "Receive" repeats itself for each row representing a transaction.

We used to have green numbers for amount received and red to denote amount sent. That seemed to be rather good for scanning. Alternatively considering making the Sent icon in the transaction list red?

This is tricky. We had that at the beginning. But the red color is associated with a failure/error. And receiving any funds is always a good emotion (as long this is not a reimbursement for a funeral costs etc.)

Yes, hence:
Received (good!) = Green
Sent (no good) = Red

But the red color is associated with a failure/error.

Are you saying that users are complaining this is misleading?

I wont add too much to this since I've already given a wave of feedback earlier, but one thing I'd like to note is that it will become exceedingly difficult to be both a tool for developers as well as an intuitive/simple mobile wallet for users.
QR code for receive implies prior knowledge, if we are sure our users will know/remember this, then we might go that path, but alternately, QR codes are going to be used in other areas (eg idea around QR code to read passphrase?)
I think I had pointed out the red tx colour concern (#ParkinsonsLawOfTriviality) but I defer to Tomek's experience on this domain, in combination with outcomes from user research towards product requirements (eg feeling confident with use), and also comparable product features (eg bank statements).

And the multiple assets across multiple networks should be considered an edge case as it is not recommended (see related ticket and validation). But how to address this might have to be addressed at another stage so as to not add to this initial UI upgrade.

@hboon You are more than welcome to join our design-sync meetups. I prefer to talk, writing here slows me down a lot. And keep me away from what I am working on.
Do you see any positives from the new look? Can you please point them out too? So far, only constraints.

@hboon You are more than welcome to join our design-sync meetups. I prefer to talk, writing here slows me down a lot. And keep me away from what I am working on.

@tomekalphawallet yes, I have been thinking of joining a couple of times, but can't make it daily. Asynchronous communication works much better for me, but I sent feedback here because you requested here.. Would you buzz me when there's a suitable session and send a meetup link when you like feedback like this?

Do you see any positives from the new look? Can you please point them out too? So far, only constraints.

Sorry. I took it for granted that no comment means they are good :) My bad.
But first of all, I don't mean the feedback as just constraints or complaints :) Most of it are meant to be taken as "have you considered..." or "how about..", though maybe I can phrase all of them differently.
Anyway, here's what is good:

Much more efficient use of space for content in rows
Better use of colors. "Buttons" are tinted with a single color which is no longer used for background
More obvious "Add token" button (I wonder if it's better to just be a + icon, removing the circle). Another way is to integrate "Add Token" into search. We have a search bar at the top
Removing the duplicate network names are good (but like I pointed out earlier, not sure if some kind of indicator should remain)

On the whole, there are improvements in terms of visual design and representation, but interactions remain the same (and maybe that's the point?)
Another suggestion responding to James' comment about tabs. What if we change the All, Currencies and Collectibles from the current form into the use of segmented control (for iOS), which is more familiar for iOS users. The original design seemed to take inspiration from Android's tabs which isn't native in iOS.
Responding to a comment (somewhere) about removing the tab bar: I don't think there's a good idea. Because phones tend to be longer nowadays, tab bars at the bottom is (A) efficient use of vertical space (B) within reach with single hand use (C) and very familiar for users. I feel tabs are ugly, but it's what works and where other apps are going..

Another suggestion: Show the address or whichever name/icon indicates which wallet is currently active in the Assets tab?

Do we show a placeholder icon when we don't have a logo for a row? Will it be likely that most of them don't have an icon? Where do we get icons?
I can provide icons. We can create own base.
We can create our own icons for the native crypto currency rows. There are 11 of them for now. But almost every other token will not have an icon, because while there are popular ones like CryptoKitties, tokens are really like user-generated-content here — there can be an infinite number of them created by someone, somewhere. Do we use a single placeholder icon for them? i.e when we scroll a list of 100 tokens, other than the 11 native crypto currency icons which are unique, the other 89 of them are the same placeholder icon (if that's what we are thinking of doing).

We can make up 10 placeholders at the beginning. But then, we would need to follow numbers. To explain, if from the analytical tool (which we don’t have now) we will learn that they use one “category” more than other, then we can make an icon. Worst scenario is if we make 100 icons from scratch. Because we might never use them. So I suggest to start with 11 currencies + 10 placeholders (ticket, retail, sport, etc.) Kind of like categories.

The 3 buttons (Enable, etc) to the left of the Send button are added via TokenScript. We don't have a limit for the number of buttons that can be added (yet). But shrinking the button label font size to fit them as we do now is just a stop-gap measure. One way I suppose is to set a maximum of 2 additional buttons and if there are more, hide it become some kind of "..."/more construct.

What about something like this?

Is it showing 3 transaction records or as many as we can?
These 2 screens are just 2 out of 30+ screens are made. The reason why I asked for a feedback is that they are really important for the whole flow (and for the entire app) If I won't get this approved, then I have to tweak the rest too (to look like the same app).
I don't understand. The current design for this screen shows exactly 3 (or fewer if the wallet has fewer transactions), whereas there is a separate Transaction tab which shows as many transactions are we can.
I am asking if in this new design, is it still showing 3 transactions or is the entire list scrollable in this screen? This is relevant also because in the current design, the transaction date is shown for each record, but in the new design, it's shown as a header which hints that there are more (all?) records that can be revealed when you scroll. This is also relevant because if this screen shows all the transactions, then maybe we don't need the Transactions tab anymore.
Did I misunderstand your request for comment? I can limit my comments to just the visual design and exclude the architecture and UX, if you'd prefer to look at them separately.

Transaction tab is needed. You can see all Transactions on Ethereum if you open Ethereum, then all transactions from all coins within Transaction tab. If we would have deleted the Transaction tab, it could be problematic to search for a specific transaction. For example... 2 months ago you bought a ticket (you are not sure which chain it was or anything). How would you go and find it out?
Also, if the transaction has failed and you won't see a notification (local or push), we can also have a small red circle with "1" inside to indicate there is something to check out. Without the tab, you would be able to do this. Also, we can keep "send" and "receive" buttons at the top of Transaction tab. Then, next step you have to select the coin. Coinbase Wallet does the same.

I know most wallets have some form of receive and send buttons and often use arrows as symbols. But here's one thought, how about using a QR code icon as the receive button. That's what it does, right?
Then the symbol of "Received" should be a QR code too. Which is not ideal.
Not necessarily. We can look at the Receive button (as part of Send and Receive) as a way to get the address, and not actually to receive a transaction. Seen that way, they don't have to have the same representation. In fact, the "Receive" button could well be accessible from the Assets tab, at the top left or right corner as a QR code icon or "Receive" button. It's all the same Ethereum address for every native crypto currency and native token until we support chains other than Ethereum. Users might have been used to finding Send and Receive buttons together though, but moving it out makes it much more convenient.

FYI, I have updated the look (icons). Arrow up = send, arrow down = receive. Green = success, red = failure, gray = pending
https://www.dropbox.com/s/zk9242ipbsb69a2/Ethereum_Coin.png?dl=0

In the current iOS version (when we tap on "Ethereum Blockchain" it opens Etherscan/blockscout. Would still be good to have that for power users (and developers like us).
Do you know if any of our users do use this option? I would track this first, then decide if it's worth keeping it or not. Is this important for you as a developer? How important?
It's very important as a developer, because it lets you verify the transaction yourself. I know Victor uses it too. I have no idea if other use it too. But we can just let the icon take its place though.

I can find a room for that in the Transaction Details screen.

Do you see any positives from the new look? Can you please point them out too? So far, only constraints.
Sorry. I took it for granted that no comment means they are good :) My bad.
But first of all, I don't mean the feedback as just constraints or complaints :) Most of it are meant to be taken as "have you considered..." or "how about..", though maybe I can phrase all of them differently.

Ok, cool. If you really want to do something, you’ll find a way. If you don’t, you’ll find a constraint (excuse). So let's try to find a way.
If you want to help, please provide me screenshots of any token you have (could be a kitty, Fifa ticket, land on the Moon). Anything that has an interface and I don't have an access too.
Thanks!

Watch my wallet address, I basically have all type of tokens.
0xbc8dAfeacA658Ae0857C80D8Aa6dE4D487577c63
Do you think customised tab is a good idea,

maybe allow users to customise these tabs (name, position, what tokens are included, add new tab)
provide some default tabs for different personas

Victor Zhang
CEO, AlphaWallet
Not only display information, @Alpha_Wallet let you preform the functions: DEPOSIT, WITHDRAW, PAYBACK, GENERATE, MO… https://t.co/6dJfdvnM3i

On 19 Sep 2019, at 00:26, Tomek Nowak<EMAIL_ADDRESS>wrote:
Do we show a placeholder icon when we don't have a logo for a row? Will it be likely that most of them don't have an icon? Where do we get icons?
I can provide icons. We can create own base.
We can create our own icons for the native crypto currency rows. There are 11 of them for now. But almost every other token will not have an icon, because while there are popular ones like CryptoKitties, tokens are really like user-generated-content here — there can be an infinite number of them created by someone, somewhere. Do we use a single placeholder icon for them? i.e when we scroll a list of 100 tokens, other than the 11 native crypto currency icons which are unique, the other 89 of them are the same placeholder icon (if that's what we are thinking of doing).
We can make up 10 placeholders at the beginning. But then, we would need to follow numbers. To explain, if from the analytical tool (which we don’t have now) we will learn that they use one “category” more than other, then we can make an icon. Worst scenario is if we make 100 icons from scratch. Because we might never use them. So I suggest to start with 11 currencies + 10 placeholders (ticket, retail, sport, etc.) Kind of like categories.
The 3 buttons (Enable, etc) to the left of the Send button are added via TokenScript. We don't have a limit for the number of buttons that can be added (yet). But shrinking the button label font size to fit them as we do now is just a stop-gap measure. One way I suppose is to set a maximum of 2 additional buttons and if there are more, hide it become some kind of "..."/more construct.
What about something like this?
Is it showing 3 transaction records or as many as we can?
These 2 screens are just 2 out of 30+ screens are made. The reason why I asked for a feedback is that they are really important for the whole flow (and for the entire app) If I won't get this approved, then I have to tweak the rest too (to look like the same app).
I don't understand. The current design for this screen shows exactly 3 (or fewer if the wallet has fewer transactions), whereas there is a separate Transaction tab which shows as many transactions are we can.
I am asking if in this new design, is it still showing 3 transactions or is the entire list scrollable in this screen? This is relevant also because in the current design, the transaction date is shown for each record, but in the new design, it's shown as a header which hints that there are more (all?) records that can be revealed when you scroll. This is also relevant because if this screen shows all the transactions, then maybe we don't need the Transactions tab anymore.
Did I misunderstand your request for comment? I can limit my comments to just the visual design and exclude the architecture and UX, if you'd prefer to look at them separately.
Transaction tab is needed. You can see all Transactions on Ethereum if you open Ethereum, then all transactions from all coins within Transaction tab. If we would have deleted the Transaction tab, it could be problematic to search for a specific transaction. For example... 2 months ago you bought a ticket (you are not sure which chain it was or anything). How would you go and find it out?
Also, if the transaction has failed and you won't see a notification (local or push), we can also have a small red circle with "1" inside to indicate there is something to check out. Without the tab, you would be able to do this. Also, we can keep "send" and "receive" buttons at the top of Transaction tab. Then, next step you have to select the coin. Coinbase Wallet does the same.
I know most wallets have some form of receive and send buttons and often use arrows as symbols. But here's one thought, how about using a QR code icon as the receive button. That's what it does, right?
Then the symbol of "Received" should be a QR code too. Which is not ideal.
Not necessarily. We can look at the Receive button (as part of Send and Receive) as a way to get the address, and not actually to receive a transaction. Seen that way, they don't have to have the same representation. In fact, the "Receive" button could well be accessible from the Assets tab, at the top left or right corner as a QR code icon or "Receive" button. It's all the same Ethereum address for every native crypto currency and native token until we support chains other than Ethereum. Users might have been used to finding Send and Receive buttons together though, but moving it out makes it much more convenient.
FYI, I have updated the look (icons). Arrow up = send, arrow down = receive. Green = success, red = failure, gray = pending
https://www.dropbox.com/s/zk9242ipbsb69a2/Ethereum_Coin.png?dl=0
In the current iOS version (when we tap on "Ethereum Blockchain" it opens Etherscan/blockscout. Would still be good to have that for power users (and developers like us).
Do you know if any of our users do use this option? I would track this first, then decide if it's worth keeping it or not. Is this important for you as a developer? How important?
It's very important as a developer, because it lets you verify the transaction yourself. I know Victor uses it too. I have no idea if other use it too. But we can just let the icon take its place though.
I can find a room for that in the Transaction Details screen.
Do you see any positives from the new look? Can you please point them out too? So far, only constraints.
Sorry. I took it for granted that no comment means they are good :) My bad.
But first of all, I don't mean the feedback as just constraints or complaints :) Most of it are meant to be taken as "have you considered..." or "how about..", though maybe I can phrase all of them differently.
Ok, cool. If you really want to do something, you’ll find a way. If you don’t, you’ll find a constraint (excuse). So let's try to find a way.
If you want to help, please provide me screenshots of any token you have (could be a kitty, Fifa ticket, land on the Moon). Anything that has an interface and I don't have an access too.
Thanks!
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or mute the thread.

Closing this issue because it's no longer executable.


Functionality list view call

CloudantClient (java-cloudant) version(s) that are affected by this issue - 2.12.0 (and earlier)
Java version (including vendor and platform) - java 8 - IBM J9 VM
If you're using the optional okhttp dependency - yes
A small code sample that demonstrates the issue - below

Didn't found anything that looks like this in the library:
database.getDBUri() + "/_design/" + designDocName + "/_list/" + listName + "/" + viewName

Is this functionality supported? Planned?

@al-tr You can use executeRequest to make a request against _list and we currently have no plans to add it.  The list function performance is poor on the server side and it's better to write and call the function in Java from the client side.


merge in refactor for cloud architecture for #218

closes #218
this merges user jobs and results with new results storage libs and queue runner.   It still has obsolete folders and libs that need to be deleted.  Should these be cleaned prior to merging?

The results don't get saved when you run a job logged in. Steps to reproduce:

Login
Select positive genes
Run model
Go to "My Results" in the top right menu
There are no results tied to the account
Tested in dev branch and it still works

@jacobnewsted  I've only tested to run jobs using the azure queue functions, which can be run locally but requires setup of cloud storage since I don't know a way to simulate Azure Queue storage locally (there is probably a way, but doesn't seem like any less work than just creating a queue).    I have documentation on getting it started https://github.com/krishnanlab/geneplexus_app/blob/218-cloudarch/mljob/README.md
but I should have mentioned that when I opened this PR above!   After seeing this I think I need to get it onto Azure for you to test unless you want to follow the readme to create a new virtualenv and run the functions locally.   I can send you the storage connection string to use so you don't have to build the azure storage again.

I recant my previous statement : I did not incorporate JN's callbacks properly in the new queue function.   I Will add commits to this PR.

@jacobnewsted  : the results records are working, and tests are passing.   You may have to create or install new python envs for testing if you keep them separate.  You should be able to run locally without using queue functions and RUN_LOCAL=True  Thank you for reviewing again


Added dataset appendix that is used in I2ML + SL

The following dataset appendix is included in this PR:

[x] boston
[x] circle
[x] credit
[x] glass
[x] ionosphere
[x] iris
[x] mnist
[x] sonar
[x] spam
[x] spirals
[x] titanic
[x] waveform

 Generate dataset appendix

Thank you @ludwigbothmann for your comments, I will address them later.
Is it okay if I add our course name to the header of the appendix?
And if it is, what will be the text that you want to show up in the header?

Hello @ludwigbothmann,
I addressed your comments in my latest commit + added headers for the appendix.
Please take a look to see if it is good now.
Thank you very much!


Cannot change content of multiline TextInput in iOS

I'm running the 0.15 rc and neither methods I tried (clearInputViaNativeProps/clearTextInputViaState) worked when attempting to reset the TextInput

clearInputViaNativeProps() {
      // this.refs.messageInput.refs.input.setNativeProps({
      //  text: ''
      // });
      this.refs.messageInput.setNativeProps({
        text: ''
      });
}

clearTextInputViaState() {
    this.setState({
        messageText: ''
    });
}

render() {
   return <TextInput
          multiline={true}
          onKeyPress={this.handleTextInputKeyPress.bind(this)}
          ref='messageInput'
          value={this.state.messageText}/>;
}

#4290 could be the same issue

I just delved into this a bit further - the culprit is this method in RCTTextView.m:
- (void)setText:(NSString *)text
{
  NSInteger eventLag = _nativeEventCount - _mostRecentEventCount;
  if (eventLag == 0 && ![text isEqualToString:_textView.text]) {
    UITextRange *selection = _textView.selectedTextRange;
    _textView.text = text;
    [self _setPlaceholderVisibility];
    [self updateTextViewFrame];
    _textView.selectedTextRange = selection; // maintain cursor position/selection - this is robust to out of bounds
  } else if (eventLag > RCTTextUpdateLagWarningThreshold) {
    RCTLogWarn(@"Native TextInput(%@) is %zd events ahead of JS - try to make your JS faster.", self.text, eventLag);
  }
}

eventLag is always 1 and so nothing ever happens... I'm not familiar with the concept of event lag so not sure what's going on here, but if I remove the eventLag == 0 check everything works as expected.

I still have to do this though:
this.refs.messageInput.setNativeProps({
    text: ''
});

Should RCTTextView not be controlled?

:+1:

Hi there! This issue is being closed because it has been inactive for a while.
But don't worry, it will live on with ProductPains! Check out its new home: https://productpains.com/post/react-native/cannot-change-content-of-multiline-textinput-in-ios
ProductPains helps the community prioritize the most important issues thanks to its voting feature.
It is easy to use - just login with GitHub.
Also, if this issue is a bug, please consider sending a PR with a fix.
We're a small team and rely on the community for bug fixes of issues that don't affect fb apps.


[SPARK-25771][PYSPARK]Fix improper synchronization in PythonWorkerFactory

What changes were proposed in this pull request?
Fix the following issues in PythonWorkerFactory

MonitorThread.run uses a wrong lock.
createSimpleWorker misses synchronized when updating simpleWorkers.

Other changes are just to improve the code style to make the thread-safe contract clear.
How was this patch tested?
(Please explain how this patch was tested. E.g. unit tests, integration tests, manual tests)
(If this patch involves UI changes, please attach a screenshot; otherwise, remove this)
Please review http://spark.apache.org/contributing.html before opening a pull request.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution-unified/4102/
Test PASSed.

Test build #97559 has started for PR 22770 at commit 0369de2.

Test build #97559 has finished for PR 22770 at commit 0369de2.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/97559/
Test PASSed.

Please feel How was this patch tested? as well in the PR description.

Please fill How was this patch tested? as well in the PR description.

Thanks for reviewing this. Merging to master.


Allow falsy values in request body

Hi,
Can you explain what issue/context it fixes?

It fixes the case where the body is a boolean false. Earlier, because the way Javascript treats that, the actual data being sent in the request ended up being null instead of false.

Ok, I didn't know sending false as data could be a valid use case.

I'll merge that in the day and bump a new version.


Check for roles being allowed to be assumed by anyone

I don't think I check this at all.  Both audit and wot should be checking for this.

Duplicates #182


MINOR: Fix misleading log in streams restoration

This line seems to indicate that stand-by tasks have caught up to the end of the changelog, as they are logged as part of allTasks.  But in fact, only active tasks have caught up to the end of the changelog here, so we should not include the stand-by tasks in the list.
Committer Checklist (excluded from commit message)

[ ] Verify design and implementation
[ ] Verify test coverage and CI build status
[ ] Verify documentation (including upgrade notes)

Thanks for the fix!
Merged to trunk and cherry-picked to 3.6 and 3.5 branches.


Making Templates

Does anyone know how to break up the index.html into templates so we can use it in other pages?

I made an attempt at the tempting, however I do not know if I done it correctly


Open redirect vulnerability on 2FA

Gitea version (or commit ref): 1.4.1
Git version: 2.17.1
Operating system: Ubuntu 16
Database (use [x]):

[X] PostgreSQL
[ ] MySQL
[ ] MSSQL
[ ] SQLite

Can you reproduce the bug at https://try.gitea.io:

[X] Yes (provide example URL)
[ ] No
[ ] Not relevant

Log gist: N/A

Description
This bug was submitted via a Bug Bounty program my company has, and I'd love to hear your thoughts on it
During the login process when the victim has entered his/her password and is then redirected to the page where he/she is told to enter his 2FA Code at this point the attacker will send a crafted link "https://try.gitea.io/user/login?redirect_to=//google.com/"
This crafted link will send this to same page he/she was viewing before and he/she will think it is a legitimate page is being loaded from "try.gitea.io"
Now they will enter there 2FA code there and will then be redirected on google.com or any other web page the attacker wants.
More info about open redirect vulnerabilities and why they're a problem:

http://cwe.mitre.org/data/definitions/601.html
https://www.owasp.org/index.php/Unvalidated_Redirects_and_Forwards_Cheat_Sheet

Reproduction
You must have 2FA enabled on your account.

Login at https://try.gitea.io/
You will be redirected to "https://try.gitea.io/user/two_factor"
Open this link "https://try.gitea.io/user/login?redirect_to=//google.com/"
Enter the 2FA Code
You will be redirected to google.com

Wow that was fast, thanks all!

Thanks for submitting a PR @glitch003  @JonasFranzDEV.
I reported this too some months ago but don't know golang for a fix... So I apologize to the Gitea Team, I know I send ( a lot? ) of emails about this because of it's impact.

Thanks @cezar97

Hi, again.
I've just did some more test and I can say that this issue is not mitigated, I'm still able to redirect logins on external sites @JonasFranzDEV . An email to Gitea Team is coming in the next minutes ( Or maybe a public disclosure here on Github? See PS2. ). Hopefully this time I'll get a response and there will be a quick fix from the team...
PS: BTW It was nicer if I had a notification on Github ( mention? ) or an email saying that the issue is fixed and asking if I'm still able to reproduce it after the fix. I thought that's the usual workflow.
PS2: @go-gitea I'm disappointed of the security team beacuse there isn't a response and more important a fix from them...
It's also really sad that Gitea had always an Open Redirect and after more than two months I've reported this there wasn't an answer or a fix. Gitea users had to wait @glitch003 PR's to fix this.
What's the point of reporting vulnerabilities on mail if there isn't an answer or fix? Reporting them on Github seems to be a better solution because the users are aware of them and also get developers attention.
I'm waiting for an answer, after that I'll do my report accordingly.
( I don't know if mentioning @go-gitea notifies all members, anyway I hope all of them are going to know about my above thoughts)
EDIT: @lunny I appreciate the thanks but what's really the point of them after what I said above?

I've just started open source contributions and this isn't the first time I get a bad impression, unfortunately.
BTW, I didn't want to be unkind / unfriendly, but there are more than 8000 users that trust you and your software ( There are also some backers ). The trust come also from the project README:

If you have found a vulnerability in the project, please write privately to<EMAIL_ADDRESS>Thanks!

So it seems that Gitea is expected to be secure and security issues are welcome. But it isn't like that.
 Thanks.

The check introduce in #4312 should be introduce globaly in https://github.com/go-gitea/gitea/blob/7b2b900e13612f565051c64374b788b0c8a82751/modules/context/context.go#L80


A11y_VisualStudioCodeClient_ Customizations and Adding Extensions _ Adding Extension_Name Role Value: No Name is defined for settings button.

[Check out Accessibility Insights!]- Identify accessibility bugs before check-in and make bug fixing faster and easier.
GitHubTags:
#A11yWCAG2.1; #A11yTCS; #A11ySev2; #Visual Studio Code Client; #BM-VisualStudioCodeClient-MAC-Aug2023; #Voiceover; #MAC; #WCAG4.1.2; #Name Role Value.
Environment and OS details:
Visual Studio Code insider for MAC version 1.82.0
Mac Version: 13.5
Screen reader: Voice Over
Repro Steps:

Open Visual Studio Code Insiders editor
Using "Ctrl+Shift+X" key navigate to the extension side view bar option.
Using Tab key navigate to the "More" option and select different options(“Show installed Extension, Show outdated extension, Show popular Extension,Etc")
Select an extension and using "Tab" and "Arrow" keys navigate through the extension details window on the RHS
Using tab key navigate to different extension for "Installation/Uninstallation".
Turn on Voice over and observe that No Name is defined for settings button.

Actual Result:
No Name is defined for settings button.
Expected Result:
No Name should be defined as settings button.
User Impact:
Screen reader users will face difficulty if No Name is defined for settings button.
Attachment:
https://github.com/microsoft/vscode/assets/98728920/db13893f-0407-41f7-b061-58f494788fff

Much simpler repro steps:
Focus an extension in the extensions view, tab to the settings button. 🐛 there's no aria label such as "settings"

This is fixed


existing L2 dataset push fail due to size; csv is 2.3gb+

Existing sample historical BTCUSD tick data from http://api.bitcoincharts.com/v1/csv/ failure to load + commit, even exceeding Git LFS file limit size.
File will not load under excel - use Text Editor/IDE:

vscode:

There we go:

git lfs hooks temporarily removed + csv split into four chunks:
commit in development-restructure: dada3936d89141346834ba75cca654f42916b6e5


C++ Chrono / Thread doesnt work properly

Hi I'm currently coding c++ code adding a delay using  and  but it just wont work inside the app. I have tested the same exact code elsewhere and it worked just fine.

hi how exactly does the remote thing work?

it still doesnt work properly (in the video)https://github.com/user-attachments/assets/4f9f4f9e-73a0-49f2-959e-cf813c457385


added alt as modifier key

Hey, can you resync your changes? Also, can you make the same changes for mtdev?
Thanks :)

ok

i have created a new pr: https://github.com/kivy/kivy/pull/3124


SetCupRule with pointers

[ ] Tests added for any new code
[x] Ran make fmt-fix (or had formatting run automatically on all files edited)
[ ] Documentation added for any new functionality
[ ] Entries added to ./unreleased/ for any new functionality

closes #2366

Codecov Report

Merging #2367 (1a90aae) into main (a249bbf) will increase coverage by 0.04%.
The diff coverage is 92.59%.

@@            Coverage Diff             @@
##             main    #2367      +/-   ##
==========================================
+ Coverage   78.41%   78.45%   +0.04%
==========================================
  Files         440      440
  Lines       15050    15052       +2
  Branches     2075     2059      -16
==========================================
+ Hits        11801    11809       +8
+ Misses       3249     3243       -6

Impacted Files
Coverage Δ

.../at/forsyte/apalache/tla/bmcmt/arena/ElemPtr.scala
40.00% <33.33%> (+20.00%)
:arrow_up:

.../forsyte/apalache/tla/bmcmt/rules/SetCupRule.scala
93.87% <100.00%> (+0.26%)
:arrow_up:

...forsyte/apalache/tla/bmcmt/rules/FunCtorRule.scala
81.57% <0.00%> (ø)

...forsyte/apalache/tla/bmcmt/rules/aux/MapBase.scala
97.50% <0.00%> (ø)

...yte/apalache/tla/bmcmt/rules/aux/ProtoSeqOps.scala
92.85% <0.00%> (ø)

...rsyte/apalache/tla/bmcmt/smt/Z3SolverContext.scala
82.97% <0.00%> (+0.85%)
:arrow_up:

...he/io/annotations/parser/CommentPreprocessor.scala
97.80% <0.00%> (+1.09%)
:arrow_up:

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more


Using old version of Docker Compose

I'm curious as to why in e.g. https://github.com/ufal/clarin-dspace/wiki/NewInstallation you are using the deprecated and unsupported version of Docker Compose that is initiated via docker-compose rather than the current version which is initiated via docker compose?
I think it is reasonable to assume that people will be using docker compose in 2024, not the older version. Maybe the Wiki  and other resources should reflect this fact?

https://docs.docker.com/compose/migrate/


Abstract the implementation

Would it be possible to abstract the implementation? From what I see this currently relies on ast module, but if we were to provide a similar python interface, could it work to extend to non-python source as well?

Hi! That's an interesting idea for sure. I think it'd be quite a lot of work, because not only do we rely on AST, but also largely the project being importable to extract type hints. Not sure about Sphinx internals there, maybe there's something we could use if other languages report types too. What would you use it for?

but also largely the project being importable to extract type hints

I could use a reference for this to understand. I thought this is still left to the predefined domain role and rely on whatever autoapi was used to extract them.

Not sure about Sphinx internals there, maybe there's something we could use if other languages report types too

For this would the language specific domains be useful, e.g. C++ (also definition). In the sense that you can assume there is a dict between an ast type and one of a sphinx domain role?

What would you use it for?

Given that there is already upstream domain and ast implementation for C/C++ I would start there, without autosphinx support if it makes sense.

This whole module, starting from the top does the resolving! It's more than just linking AST to Sphinx inventories. When we use a method of a class in code, we need to determine what comes out. And maybe what you described is exactly it, I'll have to have a look later on!


put command discovery before scripts for Unix

Also cleaned up the NativeLinuxCommands.Tests.ps1 script on skipping tests
Fix https://github.com/PowerShell/PowerShell/issues/2095

@anmenaga I was thinking that would be a good way for command discovery to find the "native command" and the powershell script to validate the command was executed over the script without polluting the current working directory.

@mirichmo can you merge?

Is this change only for Unix? The title seems so but the change is not guarded by #if UNIX.

@daxian-dbw The code is guarded  by a runtime Platform check.


Examples of how to register a reply function

          @xmi1an you can hook in function that is called whenever an agent receives a message.

Assuming you have two agents user_proxy and assistant, you can register a function with these agents that gets called with some parameters.

def print_messages(recipient, messages, sender, config):
    if "callback" in config and  config["callback"] is not None:
        callback = config["callback"]
        callback(sender, recipient, messages[-1])
    print(f"Messages sent to: {recipient.name} | num messages: {len(messages)}")
    return False, None  # required to ensure the agent communication flow continues

user_proxy.register_reply(
    [autogen.Agent, None],
    reply_func=print_messages,
    config={"callback": None},
)

assistant.register_reply(
    [autogen.Agent, None],
    reply_func=print_messages,
    config={"callback": None},
)

In the above, we register a print_messages message that is called each time the agent receive a message.
Originally posted by @victordibia in https://github.com/microsoft/autogen/issues/478#issuecomment-1785922097
It's a good example to add to FAQ.

Hi, can you please elaborate as to why returning False, None is required to continue the conversation flow? From the register_reply() Args documentation the following line is present under the trigger argument:

- If a callable is provided, the reply function will be called when the callable returns True.

However as noted above the reply_func must return False, None and the trigger in this case is the autogen.Agent class.

Hi, can you please elaborate as to why returning False, None is required to continue the conversation flow? From the register_reply() Args documentation the following line is present under the trigger argument:

If a callable is provided, the reply function will be called when the callable returns True.

However as noted above the reply_func must return False, None and the trigger in this case is the autogen.Agent class.

The triggers decides whether to enter the registered reply function. In this case the trigger basically says any message from any agent is accepted and will enter the reply function.
Autogen uses a pipeline of register reply functions to handle incoming messages. If one reply function gets triggered, it will process the message, and returns a boolean signal. If the signal is True, then the rest of the pipeline gets short-circuited and the message generated from the triggered reply funciton will be returned. If the signal is False, then the message continue to the next reply function in the pipeline.
In this example, the message gets passed on to the next reply function, because the signal is False. However the message was processed (i.e., printed). It is just that the control gets handed back to the pipeline.

Thank you :)


FEATURE: new endpoint for directly accessing a persona

The new /admin/plugins/discourse-ai/ai-personas/stream-reply.json was added.
This endpoint streams data direct from a persona and can be used
to access a persona from remote systems leaving a paper trail in
PMs about the conversation that happened
This endpoint is only accessible to admins.


Adapted for JDK17

This PR adapts the H2 benchmark for JDK17. With these changes the H2 benchmark can be built with JDK17.
Changes

Updated many out of date URLs to Maven repositories
Changed derby build config, so it is built using JDK8
Added a jdk8home property to default.properties which is now needed

How to build
The build instructions remain unchanged but now the jdk8home property must be set and JDK8 also installed.
About the new jdk8home property
Derby is still built with source=1.8 which requires JDK8 classes on the classpath.

Thanks for this!
Have you checked out the chopin branch?   That is where the upcoming release is.

Sadly, no. I didn't notice it :( Are there any changes related to this PR?

The suite is fully updated, so every benchmark is substantially changed (the underlying workload moves from a 2009 version to a 2021 version)   It will be a new major release.

Can you please tell me if the current version of the H2 benchmark on dev-chopin is buildable and runnable?

Sorry to have left this languishing.  We're now at 2.2.220.


docker push and pull should batch HTTP requests for speed

Currently, the docker push and docker pull commands are slow.  One reason for this is that even a trivial layer (e.g. a ENV PATH /my/bin) creates a small (< 1KB) layer.  Each layer is pulled serially.  Over a high latency and high bandwidth link, this causes the entire process to take orders of magnitude longer than it would if all tags / layers were batched together.

closing as dup of https://github.com/docker/docker/issues/8188


Add missing definitions in monorail 2.0 yaml file

@RackHD/corecommitters @brianparry @srinia6 @BillyAbildgaard @dalebremner @geoff-reid

*** BUILD #2317 ***
Test Name: test_node_create
Error Details: (400)
Reason: Bad Request
HTTP response headers: HTTPHeaderDict({'Content-Length': '92', 'X-Powered-By': 'Express', 'Connection': 'keep-alive', 'ETag': 'W/"5c-HXe0N9YuKffpsR9jfh2K2w"', 'Date': 'Wed, 24 Aug 2016 17:22:31 GMT', 'Access-Control-Allow-Origin': '*', 'Content-Type': 'application/json; charset=utf-8'})
HTTP response body: {"message":"Validation errors","status":"400","UUID":"e192f875-9375-458d-9d9d-55ec60df5716"}

-------------------- >> begin captured logging << --------------------
tests.api.v2_0.nodes_tests: INFO: Creating node (name=test_switch_node)
--------------------- >> end captured logging << ---------------------
Stack Trace:   File "/usr/lib/python2.7/unittest/case.py", line 331, in run
    testMethod()
  File "/usr/lib/python2.7/unittest/case.py", line 1043, in runTest
    self._testFunc()
  File "/tmp/.venv/local/lib/python2.7/site-packages/proboscis/case.py", line 296, in testng_method_mistake_capture_func
    compatability.capture_type_error(s_func)
  File "/tmp/.venv/local/lib/python2.7/site-packages/proboscis/compatability/exceptions_2_6.py", line 27, in capture_type_error
    func()
  File "/tmp/.venv/local/lib/python2.7/site-packages/proboscis/case.py", line 350, in func
    func(test_case.state.get_state())
  File "/home/jenkins/workspace/on-http/RackHD/test/tests/api/v2_0/nodes_tests.py", line 185, in test_node_create
    Api().nodes_post(identifiers=n)
  File "/tmp/.venv/local/lib/python2.7/site-packages/on_http_api2_0/apis/api_api.py", line 1601, in nodes_post
    callback=params.get('callback'))
  File "/tmp/.venv/local/lib/python2.7/site-packages/on_http_api2_0/api_client.py", line 322, in call_api
    response_type, auth_settings, callback)
  File "/tmp/.venv/local/lib/python2.7/site-packages/on_http_api2_0/api_client.py", line 149, in __call_api
    post_params=post_params, body=body)
  File "/tmp/.venv/local/lib/python2.7/site-packages/on_http_api2_0/api_client.py", line 358, in request
    body=body)
  File "/tmp/.venv/local/lib/python2.7/site-packages/on_http_api2_0/rest.py", line 208, in POST
    body=body)
  File "/tmp/.venv/local/lib/python2.7/site-packages/on_http_api2_0/rest.py", line 177, in request
    raise ApiException(http_resp=r)
'(400)\nReason: Bad Request\nHTTP response headers: HTTPHeaderDict({\'Content-Length\': \'92\', \'X-Powered-By\': \'Express\', \'Connection\': \'keep-alive\', \'ETag\': \'W/"5c-HXe0N9YuKffpsR9jfh2K2w"\', \'Date\': \'Wed, 24 Aug 2016 17:22:31 GMT\', \'Access-Control-Allow-Origin\': \'*\', \'Content-Type\': \'application/json; charset=utf-8\'})\nHTTP response body: {"message":"Validation errors","status":"400","UUID":"e192f875-9375-458d-9d9d-55ec60df5716"}\n\n-------------------- >> begin captured logging << --------------------\ntests.api.v2_0.nodes_tests: INFO: Creating node (name=test_switch_node)\n--------------------- >> end captured logging << ---------------------'

Test Name: test_node_patch
Error Details: Failed to find compute node Ids
Stack Trace: Traceback (most recent call last):
  File "/usr/lib/python2.7/unittest/case.py", line 331, in run
    testMethod()
  File "/usr/lib/python2.7/unittest/case.py", line 1043, in runTest
    self._testFunc()
  File "/tmp/.venv/local/lib/python2.7/site-packages/proboscis/case.py", line 296, in testng_method_mistake_capture_func
    compatability.capture_type_error(s_func)
  File "/tmp/.venv/local/lib/python2.7/site-packages/proboscis/compatability/exceptions_2_6.py", line 27, in capture_type_error
    func()
  File "/tmp/.venv/local/lib/python2.7/site-packages/proboscis/case.py", line 350, in func
    func(test_case.state.get_state())
  File "/home/jenkins/workspace/on-http/RackHD/test/tests/api/v2_0/nodes_tests.py", line 211, in test_node_patch
    assert_not_equal(0, len(codes), message='Failed to find compute node Ids')
  File "/tmp/.venv/local/lib/python2.7/site-packages/proboscis/asserts.py", line 151, in assert_not_equal
    raise ASSERTION_ERROR(message)
AssertionError: Failed to find compute node Ids

Test Name: skus_patch
Error Details: (400)
Reason: Bad Request
HTTP response headers: HTTPHeaderDict({'Content-Length': '92', 'X-Powered-By': 'Express', 'Connection': 'keep-alive', 'ETag': 'W/"5c-0GFdaJAPIe2XfVZIQZXKzg"', 'Date': 'Wed, 24 Aug 2016 17:22:44 GMT', 'Access-Control-Allow-Origin': '*', 'Content-Type': 'application/json; charset=utf-8'})
HTTP response body: {"message":"Validation errors","status":"400","UUID":"0ac44c32-853b-4897-892b-4b9243b8e984"}

Stack Trace: Traceback (most recent call last):
  File "/usr/lib/python2.7/unittest/case.py", line 331, in run
    testMethod()
  File "/usr/lib/python2.7/unittest/case.py", line 1043, in runTest
    self._testFunc()
  File "/tmp/.venv/local/lib/python2.7/site-packages/proboscis/case.py", line 296, in testng_method_mistake_capture_func
    compatability.capture_type_error(s_func)
  File "/tmp/.venv/local/lib/python2.7/site-packages/proboscis/compatability/exceptions_2_6.py", line 27, in capture_type_error
    func()
  File "/tmp/.venv/local/lib/python2.7/site-packages/proboscis/case.py", line 350, in func
    func(test_case.state.get_state())
  File "/home/jenkins/workspace/on-http/RackHD/test/tests/api/v2_0/skupack_tests.py", line 98, in skus_patch
    Api().skus_patch(self.__sku_id, patch_data)
  File "/tmp/.venv/local/lib/python2.7/site-packages/on_http_api2_0/apis/api_api.py", line 5505, in skus_patch
    callback=params.get('callback'))
  File "/tmp/.venv/local/lib/python2.7/site-packages/on_http_api2_0/api_client.py", line 322, in call_api
    response_type, auth_settings, callback)
  File "/tmp/.venv/local/lib/python2.7/site-packages/on_http_api2_0/api_client.py", line 149, in __call_api
    post_params=post_params, body=body)
  File "/tmp/.venv/local/lib/python2.7/site-packages/on_http_api2_0/api_client.py", line 370, in request
    body=body)
  File "/tmp/.venv/local/lib/python2.7/site-packages/on_http_api2_0/rest.py", line 222, in PATCH
    body=body)
  File "/tmp/.venv/local/lib/python2.7/site-packages/on_http_api2_0/rest.py", line 177, in request
    raise ApiException(http_resp=r)
ApiException: (400)
Reason: Bad Request
HTTP response headers: HTTPHeaderDict({'Content-Length': '92', 'X-Powered-By': 'Express', 'Connection': 'keep-alive', 'ETag': 'W/"5c-0GFdaJAPIe2XfVZIQZXKzg"', 'Date': 'Wed, 24 Aug 2016 17:22:44 GMT', 'Access-Control-Allow-Origin': '*', 'Content-Type': 'application/json; charset=utf-8'})
HTTP response body: {"message":"Validation errors","status":"400","UUID":"0ac44c32-853b-4897-892b-4b9243b8e984"}

:+1:

@anhou thanks for your review. I updated the files mode

Looks good @keedya :+1:


New release which includes the distinctGroup option in order

I saw that the distinctGroup option has been added to order in commit 998655b1438c9718403ae876163b739c57f658ca. I was wondering when a new release that includes this commit might be released, as it's critical to what I'm trying to achieve.
I set up a number of custom pathGroups for different external dependencies so that they stay in this custom order despite using alphabetical sorting, but with "newlines-between": "always" empty lines are being added between the different external dependencies not just between different categories (e.g. external and internal), which I believe is something distinctGroup: false is supposed to address.
My config:
    "import/order": [
      "warn",
      {
        pathGroups: [
          { pattern: "react", group: "external", position: "before" },
          {
            pattern: "*next/**",
            group: "external",
            position: "before",
            patternOptions: { partial: true },
          },
          { pattern: "prop-types", group: "external", position: "before" },
          { pattern: "@mui/**", group: "external", position: "before" },
        ],
        pathGroupsExcludedImportTypes: ["react"],
        groups: [
          "builtin",
          "external",
          "internal",
          "parent",
          "sibling",
          "index",
          "object",
          "type",
        ],
        "newlines-between": "always",
        alphabetize: { order: "asc" },
      },
    ]

Current result:
import { useState } from "react";

import PropTypes from "prop-types";

import Box from "@mui/material/Box";
import Typography from "@mui/material/Typography";

Desired result:
import { useState } from "react";
import PropTypes from "prop-types";
import Box from "@mui/material/Box";
import Typography from "@mui/material/Typography";

Ideally it would be possible to specify whether a given pathGroup has an empty line after it or not, but I'm not sure how difficult something like this would be to achieve.

I think distinctGroup would handle that, without having to cover both "new line before" and "new line after".
Releases aren't done on any particular schedule.

@kamil-basebuild Can you share the rest of your config and version number for this plugin? For my use case, I'm actually trying to separate out the groups exactly like that but it's no longer enforcing the rule

@kamil-basebuild Can you share the rest of your config and version number for this plugin? For my use case, I'm actually trying to separate out the groups exactly like that but it's no longer enforcing the rule

Hi @lewxdev, sorry for the late reply. The included my whole config in my original post. I'm using version ^2.26.0. Hope it works for you!

Any estimates on when will this be available? Any workaround config in the meantime?

No estimates or workaround.

The readme file is misleading, because this functionality hasn't been released.

@inker that's only if your expectations are flawed. Every single repo on github works this way - master/main is for unreleased changes, and you have to check the tag for the latest version if you want to see the released repo contents.

@ljharb as @inker mentioned, readme is very misleading on main. Not sure where you bring the claim Every single... from, but from what I've seen, main/master readme has always (at least mostly) been the latest usable (public/released/...) version
This misleading caused some time to figure out and was really unexpected to see you claim it's like this on Every single repo!

@ErAz7 that’s how everything works. Perhaps the projects your familiar with release frequently enough that you haven’t run into it, but your anecdotal experience doesn’t match how github actually works, and has always worked.


Add info about fMRI pre-processing and QA

We need to populate the page relative to fMRI prep-processing and Quality Assessment.
This includes fMRIprep and MRIQC workflows, and how to interpret the results.

closing as duplicate of #103  . Please refer to that issue.


Roman numerals get screwed up when transliterating from latin to cyrilic

When converting text like "Stefan Uroš II Milutin", you get "Стефан Урош ИИ Милутин".

That's because II are literally two latin letters "I". To avoid that, you can 1) enter II in the ignore list 2) wrap text in the css ignore class. More info can be found on readme page, or in the article here https://ivebe.com/blog/cyrillic-to-latin-and-latin-to-cyrillic-javascript-library.html

@ivebe explained how this can be solved.


[Proposal] Flutter Installer with GUI

Dear Flutter Dev Team, I have spent the last three months writing a Flutter tutorial for my high school students. During the setup it became apparent that many of my students are not very familiar with file systems and the command line and had difficulties setting the environment variable. Are there any plans to develop a Flutter Installer with a GUI? Something like an .exe or .pkg file which installs the SDK directly into a directory and sets the environment variable automatically. I guess that would make the installation a lot easier for beginners.

deduping this with https://github.com/flutter/flutter/issues/39939


Add support for review apps

This commit adds a new case to support pr-* environments.

 Apply: Review apps on paas


Keybase CLI Powershell Coloring

Keybase cli when producing an -ERROR- break the coloring scheme of Powershell. I am wondering if it was possible for Keybase to check the style properties and use them instead of defaulting to red on black text then back to white on black text. Especially with Powershell being the new "defacto" command shell on of Windows for quite some time. https://blogs.windows.com/windowsexperience/2016/11/17/announcing-windows-10-insider-preview-build-14971-for-pc/ --link worked 2018-01-27
I understand not everyone will change to using Powershell and cmd.exe usage will persist for the far future but it would be nice to not have to reset Powershell when I encounter an error. The same change would apply to anything that changes/recolors the text
log id: 0f87b2275e6e8271ea4e811c

Verified this regression and have a fix for an upcoming release. Note this is an issue for any nonstandard color scheme, not just Powershell.
Tracking internally with CORE-7128
Thanks for the report.


adding FIPS specific note

Adding FIPS related language to address paid customers easier.
More details here

LGTM, approved

thank you @chirauki  @ogarrett !


Concurrency documentation consistency: Fixed first steps folder

Hello,
I saw that the documentation is not consistent according to the docs in the sync/async documentation page.
So I am sending a series of PRs to fix that little issue as my first contribution.
I looked at doc_src directory and there is the main issue, but I'll check tests folder later too.
The first folder to be fixed is the first_steps one and every PR will fix a folder.
Thank you for this library.

Thanks for the interest, I would think this is actually as it's intended. If you read the docs for these files, it mentions that you can use async def or regular def, and it uses the different versions correspondingly. Check it here: https://fastapi.tiangolo.com/tutorial/first-steps/
Given that, I'll close this one. But if you think something's still wrong, please let me know. Maybe it would be better in a GitHub Discussion to share more information about why you think the current code is incorrect.
Thanks! :coffee:


TRG 4.01 multiple container tags

https://github.com/eclipse-tractusx/portal-assets/blob/ab166a31bb965c2591d715aa6eb63f114ea8ed96/.github/workflows/release.yml#L88-L95
release.yaml workflow doesn't create expected multiple container tags, like

x
x.y
x.y.z

Instead, only x.y.z + latest tags will be created: https://hub.docker.com/r/tractusx/portal-assets/tags?page=1&name=v1

Multiple container tags will be implemented for next release (24.03).


How can i get the access token as trigger?

I mean,
Lets say, the user change has password and now the token on my app is not valid anymore.
So, how can i check this issue and generate new token?

any update?

not sure what you mean but this should be a good read for you
https://developers.facebook.com/blog/post/2011/05/13/how-to--handle-expired-access-tokens/


Add file existence check for remove values

If remote file isn't present in repo we will add it anyway to the files list and check if len(files) == 0 { never will be true. That leads to missing section with MissingFileHandler.
That fix check that cloned file actually exists. In that case if we add a link to non-existing remote file MissingFileHandler will be called as expected.

@kuzaxak Please fix DCO issue.

Related to PR where this functionality was introduced.
cc @dol may affect your use case as well

@kuzaxak Please fix DCO issue.

Fixed. Thank for mention

@kuzaxak Can you add some test for this. then it will be better. Thanks very much.

@kuzaxak Can you add some test for this. then it will be better. Thanks very much.

@yxxhero I added tests for possible scenarios including error handling.

@kuzaxak please fix lint error.

@kuzaxak Please fix lint error. Then code is LGTM. Thanks very much.

@kuzaxak Please fix lint error. Then code is LGTM. Thanks very much.

@yxxhero
Fixed, but that strange because github.com/helmfile/helmfile should be treated as a local package, not third-party.

@kuzaxak maybe because the prefix github.com. I will try to see this.


Fix: Ignore github-actions bot as well

bors merge

This should work after #38 is merged.
bors merge


Fix git clone link

That's right, but  cloning with https:// urls is recommended, because "The https:// clone URLs are available on all repositories, public and private. These URLs work everywhere.": https://help.github.com/articles/which-remote-url-should-i-use/


chore: merge beta into master

:tada: This PR is included in version 1.0.0 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


Update README

Feedback will be from from @ajcwebdev 🤣

For what it's worth, this looks solid so far. Instructions on getting the site running locally are solid.
Some suggestions:

[ ] Contribution guidelines
[ ] A description of what this repo is (your website, etc)
[ ] A link to the live vercel/deployed URL

Updated contribution guidelines to coming soon and the rest were updated


Difference between rtracklayer?

Hi, @jeremymcrae
I am glad to see your pythonic liftover tools,  but when  I try to liftover chr7:61657308  from  hg19 to hg38, the tools give different results. Can you check the difference here?
Python version
>>> converter = get_lifter('hg19', 'hg38')
>>> converter.query("chr7", 61657308)
[('chr7', 62029292, '-')]

>>> converter = ChainFile('~/hg19ToHg38.over.chain', 'hg19', 'hg38')
>>> converter.query("chr7", 61657308)

# it returns chr7:62029292 (hg38version)

R version
library(GenomicRanges)
library(rtracklayer)
chr<-7;
start<-61657308
chain.file.path<-'~/hg19ToHg38.over.chain'
## convert to Genomic Ranges
example.37.gr<-GRanges(
        seqname=Rle(paste("chr",chr,sep="")),
        ranges=IRanges(start=start,end=start))
example.37.gr

c <- import.chain(chain.file.path) ## e.g. hg19ToHg18.over.chain
example.38.gr<-unlist(liftOver(example.37.gr,c))
example.38.gr

# it returns chr7:62029294 (hg38version)

Best,
xiucz

This tool uses 0-based coordinates, I assume GRanges use 1-based coords. As a result, the two tools can differ in regions where the orientation swaps between builds. See issue #1 as another example with diagram explaining the difference.
The way to fix this is shift your position to 0-based before conversion (i.e. converter.query("chr7", 61657308-1)). That gives a 0-based result (e.g. [('chr7', 62029293, '-')]) which then can be shifted to 1-based (i.e. 62029293+1).


[Bug]: [Notebook]Train a pytorch model failed with a module error

Is there an existing issue for this?

[X] I have searched the existing issues

Current Behavior
Train a pytorch model failed with a module error.
https://github.com/towhee-io/examples/blob/main/fine_tune/0_towhee_trainer_overview.ipynb

Expected Behavior
succeed
Steps To Reproduce
No response
Environment
- Towhee version(e.g. v0.1.3 or 8b23a93):0.9.1.dev55
- OS(Ubuntu or CentOS):
- CPU/Memory:
- GPU:
- Others:

Anything else?
No response

My torchmetrics version: 0.11.0
Is there something wrong with my version? @zc277584121

I think we can add the needed package like this.


Native crash on Android

We're trying to integrate Flutter into our existing app and run into a native crash. The same code works fine all sample apps, but in our app a native crash occurs and it's really hard for us to figure out what's wrong. Unfortunately, I cannot share our product app. It doesn't matter whether I use the terminal or Android Studio to build the app. The crash happens in the emulator and on real devices.
I'm using Flutter beta 2. I've tried to remove all other native libraries we, but the issue remains. I have no idea anymore what could be different to other sample apps with the same code and same project setup.
This is a backtrace from an API 23 emulator:
04-10 18:42:15.066 1712-1712/? A/DEBUG: *** *** *** *** *** *** *** *** *** *** *** *** *** *** *** ***
    Build fingerprint: 'Android/sdk_google_phone_x86_64/generic_x86_64:6.0/MASTER/4660549:userdebug/test-keys'
    Revision: '0'
    ABI: 'x86'
    pid: 4192, tid: 4339, name: ui_thread  >>> com.evernote <<<
    signal 11 (SIGSEGV), code 1 (SEGV_MAPERR), fault addr 0x0
04-10 18:42:15.071 1712-1712/? A/DEBUG:     eax 00000000  ebx d3c54a90  ecx 00000000  edx 00000000
        esi cf1753ec  edi cf1753f0
        xcs 00000023  xds 0000002b  xes 0000002b  xfs 00000007  xss 0000002b
        eip d2f6e495  ebp d23d01f8  esp d23d01d0  flags 00010282
04-10 18:42:15.073 1712-1712/? A/DEBUG: backtrace:
        #00 pc 005a1495  /data/app/com.evernote-1/lib/x86/libflutter.so
        #01 pc 0059f0af  /data/app/com.evernote-1/lib/x86/libflutter.so
        #02 pc 005a5c2d  /data/app/com.evernote-1/lib/x86/libflutter.so
        #03 pc 005a6bcc  /data/app/com.evernote-1/lib/x86/libflutter.so
        #04 pc 000af117  /data/app/com.evernote-1/lib/x86/libflutter.so
        #05 pc 000aab0c  /data/app/com.evernote-1/lib/x86/libflutter.so
        #06 pc 000aae1c  /data/app/com.evernote-1/lib/x86/libflutter.so
        #07 pc 000aa6a3  /data/app/com.evernote-1/lib/x86/libflutter.so
        #08 pc 006aeca2  /data/app/com.evernote-1/lib/x86/libflutter.so
        #09 pc 006aeb03  /data/app/com.evernote-1/lib/x86/libflutter.so
        #10 pc 00000556  <unknown>
        #11 pc 00036833  <unknown>
        #12 pc 000366a8  <unknown>
        #13 pc 0002d0c9  <unknown>
        #14 pc 0002c3c6  <unknown>
        #15 pc 0002be7c  <unknown>
        #16 pc 0002ada0  <unknown>
        #17 pc 00011ecf  <unknown>
        #18 pc 00023f57  <unknown>
        #19 pc 00029c5e  <unknown>
        #20 pc 00020a57  <unknown>
        #21 pc 0001f848  <unknown>
        #22 pc 00011ecf  <unknown>
        #23 pc 00026447  <unknown>
        #24 pc 00011ecf  <unknown>
        #25 pc 00027ca8  <unknown>
        #26 pc 00011ecf  <unknown>
        #27 pc 00012bcb  <unknown>
        #28 pc 0001f65e  <unknown>
        #29 pc 00011ecf  <unknown>
        #30 pc 00026447  <unknown>
        #31 pc 00011ecf  <unknown>
        #32 pc 0002584b  <unknown>
        #33 pc 00011ecf  <unknown>
        #34 pc 00012bcb  <unknown>
        #35 pc 00011ecf  <unknown>
        #36 pc 00012bcb  <unknown>
        #37 pc 0001f65e  <unknown>
        #38 pc 00011ecf  <unknown>
        #39 pc 00017c70  <unknown>
        #40 pc 00011ecf  <unknown>
        #41 pc 00023f57  <unknown>
        #42 pc 00021c8b  <unknown>
        #43 pc 00020a57  <unknown>
        #44 pc 0001f848  <unknown>
        #45 pc 00011ecf  <unknown>
        #46 pc 00012bcb  <unknown>
        #47 pc 00011ecf  <unknown>
        #48 pc 00012bcb  <unknown>
        #49 pc 0001f65e  <unknown>
        #50 pc 00011ecf  <unknown>
        #51 pc 00012bcb  <unknown>
        #52 pc 00011ecf  <unknown>
        #53 pc 00012bcb  <unknown>
        #54 pc 00011ecf  <unknown>
        #55 pc 00012bcb  <unknown>
        #56 pc 00011ecf  <unknown>
04-10 18:42:15.074 1712-1712/? A/DEBUG:     #57 pc 00012bcb  <unknown>
        #58 pc 00011ecf  <unknown>
        #59 pc 00012bcb  <unknown>
        #60 pc 00011ecf  <unknown>
        #61 pc 00012bcb  <unknown>
        #62 pc 00011ecf  <unknown>
        #63 pc 00012bcb  <unknown>
04-10 18:42:15.259 1712-1712/? A/DEBUG: Tombstone written to: /data/tombstones/tombstone_00

The backtrace from an API 26 emulator
2018-04-10 18:39:35.140 7612-7612/?  A/DEBUG: Build fingerprint: 'google/sdk_gphone_x86/generic_x86:8.0.0/OSR1.180220.006/4662038:userdebug/dev-keys'
    Revision: '0'
    ABI: 'x86'
    pid: 7383, tid: 7596, name: ui_thread  >>> com.evernote <<<
    signal 31 (SIGSYS), code 1 (SYS_SECCOMP), fault addr --------
    Cause: seccomp prevented call to disallowed x86 system call 7
        eax 00000007  ebx 00001db8  ecx a47f99fc  edx 40000000
        esi 00001db8  edi a47f99fc
2018-04-10 18:39:35.142 7612-7612/? A/DEBUG:     xcs 00000073  xds 0000007b  xes 0000007b  xfs 0000003b  xss 0000007b
        eip 9a350b4e  ebp a5f7a000  esp a47f99dc  flags 00000282
    backtrace:
        #00 pc 03848b4e  /system/app/Chrome/Chrome.apk (offset 0x1053000)
        #01 pc 00000003  <unknown>
2018-04-10 18:39:35.146 7614-7614/? I/crash_dump32: obtaining output fd from tombstoned
2018-04-10 18:39:35.146 1553-1553/? I//system/bin/tombstoned: received crash request for pid 7608
    enqueueing crash request for pid 7608
2018-04-10 18:39:36.092 1553-1553/? E//system/bin/tombstoned: Tombstone written to: /data/tombstones//tombstone_06
2018-04-10 18:39:36.093 7614-7614/? I/crash_dump32: performing dump of process 7608 (target tid = 7608)
2018-04-10 18:39:36.093 7614-7614/?  A/DEBUG: backtrace:
        #00 pc 0384c6d2  /system/app/Chrome/Chrome.apk (offset 0x1053000)

Please let me know information else I could provide. Thanks

Quick update: when I launch the same activity in a different process, then it's working fine. So the question is what could trigger a native crash inside of Flutter from our app?

Thanks, we're taking a look. Can you share the results of flutter doctor -v, just to make sure we're all on the same page?

We can symbolicate that crash:
https://github.com/flutter/engine/wiki/Symbolicating-production-crash-stacks
and should have a better idea from that.  @jason-simmons might be able to take a look.

Here's the output:
[✓] Flutter (Channel beta, v0.2.8, on Mac OS X 10.12.6 16G1314, locale en-US)
    • Flutter version 0.2.8 at /Users/rwondratschek/dev/projects/flutter/flutter
    • Framework revision b397406561 (9 days ago), 2018-04-02 13:53:20 -0700
    • Engine revision c903c217a1
    • Dart version 2.0.0-dev.43.0.flutter-52afcba357

[✓] Android toolchain - develop for Android devices (Android SDK 27.0.3)
    • Android SDK at /Users/rwondratschek/dev/android/sdk
    • Android NDK location not configured (optional; useful for native profiling support)
    • Platform android-P, build-tools 27.0.3
    • ANDROID_HOME = /Users/rwondratschek/dev/android/sdk
    • Java binary at: /Applications/Android Studio.app/Contents/jre/jdk/Contents/Home/bin/java
    • Java version OpenJDK Runtime Environment (build 1.8.0_152-release-915-b08)
    • All Android licenses accepted.

[!] iOS toolchain - develop for iOS devices
    ✗ Xcode installation is incomplete; a full installation is necessary for iOS development.
      Download at: https://developer.apple.com/xcode/download/
      Or install Xcode via the App Store.
      Once installed, run:
        sudo xcode-select --switch /Applications/Xcode.app/Contents/Developer
    ✗ Brew not installed; use this to install tools for iOS device development.
      Download brew at https://brew.sh/.

[✓] Android Studio
    • Android Studio at /Applications/Android Studio 3.1 Preview.app/Contents
    • Java version OpenJDK Runtime Environment (build 1.8.0_152-release-1024-b01)

[✓] Android Studio
    • Android Studio at /Applications/Android Studio 3.2 Preview.app/Contents
    • Java version OpenJDK Runtime Environment (build 1.8.0_152-release-1136-b02)

[✓] Android Studio (version 3.0)
    • Android Studio at /Applications/Android Studio.app/Contents
    • Java version OpenJDK Runtime Environment (build 1.8.0_152-release-915-b08)

[✓] Connected devices (1 available)
    • Android SDK built for x86 • emulator-5554 • android-x86 • Android 8.0.0 (API 26) (emulator)

! Doctor found issues in 1 category.

@vRallev, if you are able to share more detail using email, please write me at<EMAIL_ADDRESS>

Symbolized stack trace:
005a1495
flutter/third_party/txt/src/minikin/WordBreaker.cpp:55
0059f0af
flutter/third_party/txt/src/minikin/LineBreaker.cpp:74
005a5c2d
flutter/third_party/txt/src/txt/paragraph.cc:235
005a6bcc
flutter/third_party/txt/src/txt/paragraph.cc:378
000af117
flutter/lib/ui/text/paragraph_impl_txt.cc:54
000aab0c
flutter/lib/ui/text/paragraph.cc:96
000aae1c
topaz/lib/tonic/dart_args.h:150
000aa6a3
flutter/lib/ui/text/paragraph.cc:44

It's a null pointer dereference during text layout.
The line at the top is:
https://github.com/flutter/engine/blob/c903c217a1a8206cdebdab1703b52ec6180edf37/third_party/txt/src/minikin/WordBreaker.cpp#L55
accessing mBreakIterator, which is set here:
https://github.com/flutter/engine/blob/c903c217a1a8206cdebdab1703b52ec6180edf37/third_party/txt/src/minikin/WordBreaker.cpp#L36
The implication is that the call to icu::BreakIterator::createLineInstance(locale, status) failed.
Is there anything noteworthy about the ICU/i18n/locale configuration in the environment where this crashes?
If you can build the engine locally, try logging the status code after the call to createLineInstance.

Do you have an idea what the cause for the failed call could be? I don't know what should be special about our project. The same Dart code + Android Activity code works fine in a separate project.
But for some reason without making any changes (just cleans and rebuilds) it's not crashing anymore. That happened to me this morning already, but after some time the issue appeared again.

ICU requires a data file (the icudtl.dat file embedded into your app's APK by the Flutter build tools).  Flutter will extract this file at startup, copy it to local storage, and then use it to initialize the ICU library.
Possibly something is going wrong with how this file is being embedded into the APK and loaded at runtime?
(Although if icudtl.dat was missing or corrupt then I would expect the Flutter engine to report an assertion failure during startup.)
How is the project that crashes initializing Flutter and calling the FlutterMain APIs?
(see https://docs.flutter.io/javadoc/io/flutter/view/FlutterMain.html)
The extraction of icudtl.dat should happen between FlutterMain.startInitialization and FlutterMain.ensureInitializationComplete
createLineInstance also depends on the locale used for the line breaker.  Currently we ask ICU to use the default locale.  If the default locale is always the same but the engine crashes in the main project but not the test project, then the crash probably isn't due to the locale.

I can reproduce the crash now again.
For testing purposes I used the "flutter_view" sample. The setup in the Activity looks like this
  @Override
  protected void onCreate(Bundle savedInstanceState) {
    FlutterMain.startInitialization(getApplicationContext());

    super.onCreate(savedInstanceState);

    String[] args = getArgsFromIntent(getIntent());
    FlutterMain.ensureInitializationComplete(getApplicationContext(), args);
    setContentView(R.layout.flutter_view_layout);
    ActionBar supportActionBar = getSupportActionBar();
    if (supportActionBar != null) {
      supportActionBar.hide();
    }

    flutterView = findViewById(R.id.flutter_view);
    flutterView.runFromBundle(FlutterMain.findAppBundlePath(getApplicationContext()), null);
    ...
}

It crashed in runFromBundle the first time the activity was launched. We also have a custom application class and there I'm calling FlutterMain.startInitialization(this);, too.
If I remove the call from the application class and only have the startInitialization call inside of the Activity, then the app is crashing. If I add the startInitialization call in the application class, then it's working although startInitialization is called twice.

Calling FlutterMain.startInitialization twice is almost certainly wrong. I'd call it from the application class only, and not the activity.

Yes, but why is it crashing when I'm calling it in the activity only once? That's causing the crash for us.

Something is wrong with the build in our project and I have no clue what. I've managed to integrate a Flutter view now:

When I change the code it suddenly fails. I only run ./gradlew :app:installDebug after the change.
// old
      floatingActionButton: new FloatingActionButton(
        onPressed: _incrementCounter,
        tooltip: 'Increment',
        child: new Icon(Icons.add),
      ), // This trailing comma makes auto-formatting nicer for build methods.

// new code
      floatingActionButton: new Container(
        padding: EdgeInsets.only(right: 32.0, bottom: 32.0),
        child: new FloatingActionButton(
          onPressed: _incrementCounter,
          tooltip: 'Increment',
          child: new Icon(Icons.add),
        ),
      ), // This trailing comma makes auto-formatting nicer for build methods.

The code is fine, but the UI looks like this.

To me the problem is not clear. I'd still appreciate any help. Notice that I'm using Gradle to build the app all the time. When I use flutter run, then I'm back to the native crash when launching the app.

Flutter is midway through a transition from Dart 1 to Dart 2.  Calling a constructor like EdgeInsets.only without the new or const operator is a new feature in Dart 2.
Set the preview-dart-2 property to enable Dart 2 in the Gradle build:
./gradlew -Ppreview-dart-2=true :app:installDebug

(These are either/or approaches to the issue, by the way.)

const worked, thanks for the hint. I also tried the dart 2 build property and ran into the same native crash again
    Exception, signal SEGV (11)
    0   /data/app/com.evernote-2/lib/x86/libNativeCrashHandler.so 0xee5e8c27 0xee5e7000 + 1c27 : CrashHandlerDumpStack
    1   /data/app/com.evernote-2/lib/x86/libNativeCrashHandler.so 0xee5e9bce 0xee5e7000 + 2bce
    2   /system/bin/app_process32      0xf771c79d 0xf771a000 + 279d : InvokeUserSignalHandler
    3   /system/lib/libart.so          0xf3da6106 0xf382d000 + 579106 : _ZN3art12FaultManager11HandleFaultEiP7siginfoPv
    4   /system/lib/libart.so          0xf3da6cea 0xf382d000 + 579cea
    5   /system/lib/libc.so            0xf72740f0 0xf725d000 + 170f0
    6   /data/app/com.evernote-2/lib/x86/libflutter.so 0xda49f495 0xd9efe000 + 5a1495
    7   /data/app/com.evernote-2/lib/x86/libflutter.so 0xda49d0b0 0xd9efe000 + 59f0b0
    8   /data/app/com.evernote-2/lib/x86/libflutter.so 0xda4a3c2e 0xd9efe000 + 5a5c2e
    9   /data/app/com.evernote-2/lib/x86/libflutter.so 0xda4a4bcd 0xd9efe000 + 5a6bcd
    10  /data/app/com.evernote-2/lib/x86/libflutter.so 0xd9fad118 0xd9efe000 + af118
    11  /data/app/com.evernote-2/lib/x86/libflutter.so 0xd9fa8b0d 0xd9efe000 + aab0d
    12  /data/app/com.evernote-2/lib/x86/libflutter.so 0xd9fa8e1d 0xd9efe000 + aae1d
    13  /data/app/com.evernote-2/lib/x86/libflutter.so 0xd9fa86a4 0xd9efe000 + aa6a4
    14  /data/app/com.evernote-2/lib/x86/libflutter.so 0xda5acca3 0xd9efe000 + 6aeca3
    15  /data/app/com.evernote-2/lib/x86/libflutter.so 0xda5acb04 0xd9efe000 + 6aeb04

I'll try going back to beta 1 again. Maybe I have more luck with that.

@vRallev Are you able to send us a tarball of a test project that fails? We haven't been able to reproduce the problem.

@Hixie Unfortunately, it's only reproducible in our product app. The sample app is working fine. I'm not allowed to share our app code, but our team is at Google IO, maybe we can debug the issue there together. Is this an option?

We believe customer:gold may have hit this as well: https://github.com/flutter/flutter/issues/16748

We noticed that if we remove the app_flutter directory. It will work fine. Currently, we're using multiple process in one application. i.e., multiple FlutterApplication.onCreate() will be called, the icudtl.dat may be broken. We've refactored this logic.

@vRallev  We're not sure how to proceed on this but if you are interested in following up further we would be happy to work with you. Can you contact Tim or Matt directly to set that up? Thanks.

Sounds good to me. Thanks


HBASE-26026 HBase Write may be stuck forever when using CompactingMem…

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
0m 28s
Docker mode activated.

Seems the failed test org.apache.hadoop.hbase.client.TestFromClientSide5 for jdk8 uncorrelated to this PR, jdk11 is ok and TestFromClientSide5 is passed in my local machine with jdk8

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
0m 28s
Docker mode activated.

No failed tests，some flake tests org.apache.hadoop.hbase.io.hfile.TestLruBlockCache.testBackgroundEvictionThread and org.apache.hadoop.hbase.wal.TestFSHLogProvider.testLogCleaning，seems uncorrelated to this PR

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
1m  2s
Docker mode activated.

@Apache9 , please continue help me have a view at your convenience.

I need sometime to understand the code better...
A bit busy recently, sorry...

@Apache9 ,never mind, just  at your convenience

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
0m 50s
Docker mode activated.