axum example question

Hi @juhaku
https://github.com/juhaku/utoipa/commit/e22a5c025eceeb436993ec04c2640b7f9ddce792
I was going to work on this. Can I add your example code to axum repo?
Best regards,
Michal

@eventhorizonpl  Sure thing its free and opensource ;) :D

It's still better to ask first :) Maybe you planed to do it on your own? Ok, I'll send a PR for axum.
I planed to work on this example code as part of my #CrateOfTheWeek contribution. Maybe instead of this I'll check code coverage in tests and improve things where I'll be able?

Yeah. Its good to ask :) You can send a PR to axum. Oh snap. I just wrote the example because it was quick to get out of the way :D
Well yeah.. I haven't yet checked the coverage over the test that is indeed someting to do though there are tests for different feature flags so getting full report might not be simple or possible?
Most of the tests there indeed tests the doc generation with macros using integration tests. And less of raw unit tests. So unit test side might be lacking from utoipa side which merely has only Rust types of OpenAPI schema. But sure if that's something you'd like to do go for it :) any contributions are welcome haven't yet though written any contribution "guidelines" but Im pretty easy going with the project. And of course you can further tune the example as well if you like :)


Multiple guidelines

Let's start with saying, it is good to have some guidelines and best practices at all.
But the value decreases if you need to choose between multiple guidelines and best practices:
There is (at least) this DSC Resource Style Guidelines & Best Practices and The PowerShell Best Practices and Style Guide. Both guidelines slightly differ.
With all respect, for me, The PowerShell Best Practices and Style Guide is leading, mainly because I am more concerned with the PowerShell in general than DSC. Nevertheless, I want you to know that I created an Unquoted Strings best practice issue at their project site with might concen you because my ConvertTo-Expression cmdlet is used by your DSC project.
From my view, it would make more sense if there is just one style guide and best practices with possibly a subset of DSC guidelines and best practices that highlights the differences and explains why it deviates from the general PowerShell style guide and best practices.

Hi @iRon7
Thanks for the feedback, and we agree that the clarification is needed.
It's even more confusing because a lot of the guidelines and practices have been taken over by the DSC community and we'll be removing the DSC resource Style Guidelines you pointed to very soon, and link to the DSC Community one instead.
The reason for divergence between PowerShell and DSC is historic, and the main reason we keep some of those rules is that we have the PSSA rules to enforce some of them, and we want consistency across DSC resources rather than uncoordinated changes and discrepancies (most maintainers look after several resource modules).
Yes, we'd like to align with those Guidelines, but we want to have the tools to enforce them before we make the switch.
There's also more to it than it looks, we also want our tooling and documentation to support class based DSC resources before we can generalize its adoption.
By the way, we're always looking for contributors :)


Add error for aggregates in group_by

This query currently runs:
query:  order_items_base -> {
    group_by: user_id
    group_by: brand_count is count(distinct ii.product_brand)
  }

and produces this SQL
SELECT
   order_items_base.user_id as user_id,
   count(distinct ii_0.product_brand) as brand_count
FROM `malloy-data.ecomm.order_items` as order_items_base
LEFT JOIN `malloy-data.ecomm.inventory_items` AS ii_0
  ON order_items_base.inventory_item_id = ii_0.id
GROUP BY 1
ORDER BY 2 desc

We should probably not allow this and throw a reasonable error about disallowed aggregates in a group_by, rather than quietly not putting the field in the SQL's GROUP BY.

yeah and probably the inverse as well, i wrote code for this but never tested it


ERC1155: subtraction overflow issue resolved

This resolves issue #765.
Signed-off-by: Rajat Sharma<EMAIL_ADDRESS>

@denyeart, could you please look into this PR and let me know if any further changes are needed on this.

Thanks @rajat-dlt . Could you also fix the same problem at https://github.com/hyperledger/fabric-samples/blob/main/token-erc-20/chaincode-go/chaincode/token_contract.go#L724 in this PR?
These issues that you are finding all got introduced in https://github.com/hyperledger/fabric-samples/pull/731.  I think that PR tried to do too much in a single commit and therefore these problems were not caught. This is a good reminder that we should do smaller PRs with a single change and re-test each of the chaincodes (Ideally these chaincodes should have CI tests similar to the asset-transfer CI tests).
@fraVlaca I believe you are re-visiting the samples as well... please double check each of them and re-test to make sure they are working per the readmes.

@denyeart, the fix is added for ERC20.

Thanks Rajat!


Export attribute in a belongs_to association?

If I have a model like this one:
class Comment < ActiveRecord::Base
  belongs_to :article
end

Can i add the article name ( or another attribute ) somehow in the generated CSV?

Hi Fernando!
You have to use "add_methods" method that give you this gem. For example, I want to get all roles from my users. Looks like I made it:
controller:
render csv: @results, only: [:name, :surname, :email, :phone], add_methods: [:rol]
user class:
def rol
roles = self.roles.map(&:name)
arr = []
roles.each {|r| arr.push(I18n.t "rol.#{r}") }
arr.join(", ")
end

@fernandomm sorry for the delay on this. You can use delegate in your Comment model:
class Comment
  belongs_to :article
  delegate :name, to: :article, prefix: true
end

Then in the controller, add article_name to the list of columns you want. You'll want to eager load the articles to avoid n+1 queries.
render csv: @comments, add_methods: [:article_name]

I looked into this a bit and have decided not to continue maintaining this project. I have not used it in production for a few years, and do not recommend that others do so. See https://github.com/beerlington/render_csv/commit/8356d727acefb4d8ba6efa28b725192bc9eafd91

Closing this since I am no longer maintaining it and won't be adding new features.


Error when using %sqlplot in snowflake

The issue relates to this slack question
I try to use sqlplot to create a histogram
First, I create the table using %%sql and it works fine
%%sql --save date_count
select
    _INCREMENTAL_LOAD_DATE,
    count(*)
from DEV_LAKE.LAKE_OPTOMATE_2000_060.LAKE_OPTOMATE_2000_060_PATIENT
GROUP BY 1 ORDER BY 1

Then, when I try to create a histogram with date_count table:
%sqlplot histogram --table date_count --column _INCREMENTAL_LOAD_DATE --with date_count

I got this error:
ProgrammingError: (snowflake.connector.errors.ProgrammingError) 002003 (42S02): SQL compilation error: Object '"date_count"' does not exist or not authorized. [SQL: WITH date_count AS (SELECT _INCREMENTAL_LOAD_DATE, COUNT(*) FROM DEV_LAKE.LAKE_OPTOMATE_2000_060.LAKE_OPTOMATE_2000_060_PATIENT GROUP BY 1 ORDER BY 1 NULLS FIRST) SELECT MIN("_INCREMENTAL_LOAD_DATE"), MAX("_INCREMENTAL_LOAD_DATE") FROM "date_count"]
For some reason, the histogram query using "date_count" instead of date_count (without Quotation marks)
The data warehouse I'm using is Snowflake.

Following up on this, the problem is a mismatch between sqlalchemy and snowflake when handling identifiers. We need to modify the internal SQL query we execute so it works.
We'll fix this soon!

@tonykploomber: did you start working on this? I can assign it to somebody else if not

I am checking on this, this is an interesting issue
Seems the issue was the double quote " that surrounds the table name
Problematic query in snowflake: SELECT MIN('x'), MAX('x') FROM "PLOT_SOMETHING_02d39f"
And this query seems work: SELECT MIN('x'), MAX('x') FROM PLOT_SOMETHING_02d39f

Possible Ad-hoc solution:
We may just remove the double quote " in all queries for snowflake case, but this method might affect the query statement provided by user, I need to see if this will effect other use-cases.

Some research on double quote identifier in snowflake
The double quote is used for case-sensitive case
Suppose we have a table created as something
Working statements:
A. select * from something
B. select * from SOMETHING
C. select * from "something"
Not working statements:
A. select * from "SOMETHING"

The root cause:

Our plot query will generate the internal query like: WITH plot_something_subset AS (SELECT * FROM PLOT_SOMETHING_524D8E LIMIT 3) SELECT MIN("x"), MAX("x") FROM "plot_something_subset"

However, seems the above CTE is not working in snowflake database, it's the known issue we listed in compability, although we marked Plotting with boxplot and histogram as ❓
We need to make sure above CTE working in snowflake

@edublancas
Yes, I did work on a portion of this task, we can see if this analysis make sense
Root cause
Actually we shall support snowflake for the sqlplot.
The root cause is existing in our internal graphing queries.
For example, in one of query:
SELECT MIN('x'), MAX('x') FROM "PLOT_SOMETHING_02d39f"

We will use " quote symbol to wrap the table name.
However, in the snowflake, the " (double quote identifier) in snowflake is for case-sensitive purpose
Approach

Maybe for the snowflake dialect, we can remove the " directly (using replace) while generating the internal graphing queries?

We might also see if SQLglot has option for this case

@tonykploomber any updates here? have you determined which is the best approach?

Yeah I think I pass the snowflake %sqlplot histogram issue in my PR, but that's suffering from other test cases failure.
Need to check more

@juliusngcmc we just fixed this! histograms will work on snowflake in the next release (0.10.0), which will be out in the next few days!


[REQ] Advanced on-screen controls

Hi there, this app is really interesting.
We do strongly suggest you to "grab" (or, even better, collaborate with) Open Camera controls that are extremely useful for "advanced" shootings
For example:

artificial horizon
customizable EXIF photo tags (author, license)
optional stamps on photos
etc.

Hope that inspires !

In the future please split up your suggestions into separate issues. We can't track everything under one issue.
We can't use ANYTHING from Open Camera because they use a non-free/restrictive licence and we don't want to include GPLv3 or any variant of GPLv3 code into our project. Open Camera is not an objectively good camera and does not make use of the hardware fully. It's poor quality compared to our app. It's also fairly legacy and dinosaur and doesn't use CameraX.

artificial horizon

We have a gyroscope suggestions toggle in More Settings.

customizable EXIF photo tags (author, license)

These should be added yourself with a proper gallery app.


Assessment/pull form info from db

Hi  Mike,
This request adds the ability to pull the services and parts data from the database and display on the form as checkbox options.
Done Checklist

[x] Subscribe to db collections serviceItems and services
[x] Display serviceItems and services on the form as checkbox options

Thanks Mike, I am closing this pull request as Chris will incorporate these changes into the code he is working on today and he will submit it in a pull request later today.


[SPARK-27667][SQL] support display of current Database in the spark-sql CLI

What changes were proposed in this pull request?
Get the current database from the spark catalog instead of CliSessionState.Spark does not set the current database to CliSessionState.So it will always return empty.
How was this patch tested?
Manually
Before Fix

After Fix

cc @HyukjinKwon

Can one of the admins verify this patch?

Can one of the admins verify this patch?

Can one of the admins verify this patch?

I tested thrift server and also checked Hive code for  hive.cli.print.current.db usage , this paramater is not used in case of beeline. code snapshot is below

I cross checked the hive behaviour, current database will be shown only in case of hive cli but not in beeline

cc @wangyum

Since HIVE-14123, beeline support show database in the prompt. SPARK-23710 could support it:

I have raised new issue SPARK-27688 to support beeline, I will raise PR for this soon

@wangyum is this PR ok to test or did I miss to capture some more points ?

@sandeep-katta I'm not sure could we add a test case for this change?

I have added the testcase

@wangyum @HyukjinKwon , I have added the FT

@HyukjinKwon @dongjoon-hyun

cc @wangyum

Retest this please.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution-unified/11789/
Test PASSed.

Test build #106548 has started for PR 24566 at commit f007bbe.

Test build #106548 has finished for PR 24566 at commit f007bbe.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/106548/
Test PASSed.

@wangyum please let me know if I need to add some more change for this PR

In general, we prefer to using/adding Spark own conf instead of relying on Hive's conf.

Please add a Spark SQL conf.

In general, we prefer to using/adding Spark own conf instead of relying on Hive's conf.

Please add a Spark SQL conf.

I haved added the spark conf and pushed the code, please review

@wangyum  please let me know or suggest If I need to do any other changes

retest this please

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution-unified/14072/
Test PASSed.

Test build #109005 has started for PR 24566 at commit 2b0c987.

Test build #109005 has finished for PR 24566 at commit 2b0c987.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/109005/
Test PASSed.

@wangyum can you please review this, I have added the SQLConf

Can one of the admins verify this patch?

ok to test

Test build #110684 has started for PR 24566 at commit 4b408ba.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/15846/
Test PASSed.

Test build #110684 has finished for PR 24566 at commit 4b408ba.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/110684/
Test PASSed.

Can one of the admins verify this patch?

@HyukjinKwon @wangyum please check , is this change required or not. I added this to make consistent with beeline behaviour

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/19518/
Test PASSed.

ok to test

Test build #114937 has started for PR 24566 at commit 43c4a5e.

Test build #114937 has finished for PR 24566 at commit 43c4a5e.

This patch fails Scala style tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Merged build finished. Test PASSed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/114937/
Test FAILed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/19759/
Test PASSed.

Test build #114938 has started for PR 24566 at commit 54f8e33.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/19760/
Test PASSed.

Test build #114938 has finished for PR 24566 at commit 54f8e33.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/114938/
Test PASSed.

Test build #114976 has started for PR 24566 at commit 79ddad1.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/19797/
Test PASSed.

Test build #114976 has finished for PR 24566 at commit 79ddad1.

This patch fails due to an unknown error code, -9.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/114976/
Test FAILed.

retest this please


[Bugfix] Add proper error message when user does not have access to a page

If the user does not have privilege to access a page they are asked to log in again, even though they are already logged in.
To reproduce:

Log in with a lim_web user on one window
Open a private window and log in with another user on that window. This user must have a role with added privileges, i.e. admissions
Go to an admission page on the private window
With the lim_web user, remove the role with the privileges of the other user.
Refresh the private window.You are asked to log in again

Seems good. I was just wondering if the error message should include something along the lines of "If you think you should have access, contact your gjengsjef or MG-web". If it seems unncecessary to add(most people would probably contact us anyways), I can just approve the PR.

Should be the group leader, so they can verify their access

Seems good. I was just wondering if the error message should include something along the lines of "If you think you should have access, contact your gjengsjef or MG-web". If it seems unncecessary to add(most people would probably contact us anyways), I can just approve the PR.

I changed it so it shows an error message to those with roles (making the assumption that they are all internals of Samfundet)


Add overview of the GaFLONA pipeline

It's not ETL, it's GaFLONA!

Basically +1 tho I have slight reservations about documenting things we haven't fully done yet without noting that.

Good point. I've updated to add status @odscjames


Make alert email notification async

The function _notifyUnknownTransaction and _notifySafeSetup now return immediately. This removes the requirement to await for the email provider when the POST /alerts is triggered.

Pull Request Test Coverage Report for Build<PHONE_NUMBER>
Details

-6 of 12 (50.0%)  changed or added relevant lines in 1 file are covered.
1 unchanged line in 1 file lost coverage.
Overall coverage decreased (-0.02%) to 93.687%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

src/domain/alerts/alerts.repository.ts
6
12
50.0%

Files with Coverage Reduction
New Missed Lines
%

src/routes/transactions/entities/tests/human-description.builder.ts
1
80.0%

Totals

Change from base Build<PHONE_NUMBER>:
-0.02%

Covered Lines:
6120

Relevant Lines:
6321

💛  - Coveralls


[Feature Request] introduce "Message Written" callback for Websocket

Problem
Pending messages queue is capped, and connection gets closed if new message hits queue limit.
I have 2 issues there:

Its hard to efficiently send big payloads (e.g. big file sliced into chunks) without resorting to polling WebSocket.queueSize
If new message exceeds queue size (16 MiB currently, not exposed ), I would like to signal that to client  without closing connection.

Possible solution

Enhance WebsocketListener with onMessageWritten(WebSocket)
Enhance Websocket with maxQueueSize (it has queueSize already)

If your application is approaching a full queue it's quite likely that websockets are an awkward fit for your data.
Websockets work best for small, latency-sensitive messages like chat. When your queue is full, you aren't low-latency.
In such cases, consider just using HTTP. It's better suited for big payloads.
That said, exposing the max queue size isn't unreasonable. In the interim you can assume it's 16 MiB.

OkHttp Websockets is used as transport for RSocket-android protocol implementation, which makes no distinction regarding use-cases (everything in Publisher<Payload>). Proposed WebsocketListener changes would allow updating said transport in a way that upstream Publisher does not overwhelm OkHttp on low quality connection or network hiccup.
Http is not an option as It is request-response only and is wasteful for binary protocol.
Can you explain your concerns regarding onMessageWritten? (except breaking change one)

Got it. This explanation is helpful.
The biggest challenge to doing onMessageWritten is we’d need to invoke it on a different thread from the one doing the writing.
The other giant problem is that onMessageWritten doesn't confirm anything about whether the message has been received. That needs to happen at the application layer.
I think the right solution for RSocket is to do something similar to the flow control in HTTP/2. Add back pressure to the application protocol and manage it there.

@swankjesse Ah, with onMessageWritten I meant something similar to Netty OutboundHandler.write(), which signals when message is removed from outbound buffer. But I see Okhttp is designed in a way that written callback is redundant - thanks for explanation.
Also, for valuable insights into http2 flow control - will do!


Devolve the bottle-name predicate field into an object?

The predicate currently looks like this:
  "predicate": {
    "bottle-name": "formula-foo--1.4.3.sometag.bottle.tar.gz",
    "bottle-digest": { "sha256": "64eeece96..." }
  }

...where bottle-name is essentially the result of calling Bottle::Filename#to_s. However, this format is an implementation detail within Homebrew, and is subject to changes. Instead of storing the stringified version, it may instead make sense to store each separate field, e.g.:
"bottle": {
  "name": "formula-foo",
  "version": "1.4.3",
  "tag": "sometag",
  "rebuild": 0
}

...which could then be compared against piecewise.

Thinking about this more, I'm increasingly convinced this should be an object rather than a semi-opaque string (i.e., stringified bottle name) -- the bottle name is entirely an implementation detail that probably shouldn't be ossified in an attestation format, and doing so will only result in unnecessary pain should the format ever need to be changed.


Cannot unselect option element when preserveSelected is true

Hi @truckingsim,
I am unable to unselect an option element in a multiple select when the preserveSelected option is true. It only works after I do an ajax search.
The issue is reproducible: https://jsfiddle.net/a3ybhne4/5/
I have found the problem to be line 630
It works when I replace line 630
that.replaceOptions(that.cacheGet(that.plugin.query));
by
that.replaceOptions(that.selected);
I am not sure why that.plugin.query is there in the first place and I am wondering if this change has any side effects...
Thanks for taking a look.
EDIT: updated jsfiddle

The that.cacheGet(that.plugin.query) is our caching mechanism. It's always used even if you have caching off. What cache off does is it loads the cached data and does an ajax request anyways.  With caching on, if you've already done a search for that query (whatever the query is), it will grab the cached data this time won't do an ajax request.
What's happening is we aren't updating the cache on change.  We set the cache value for no query on line 605 but after updating that.selected we never update the cache.  So then it just keeps using the cached value.
So the fix is to update the cache.  I think if we just add a that.setCache it will break preserveSelected so it will take some testing to make sure we don't break that fixing this.
If you feel you can make a PR with a fix for the cache I can test it to make sure it doesn't break anything else.  Otherwise it will probably be this weekend before I can get to this.

Also @markcarver I believe you wrote this caching and preserveSelected code as well if I got any of that information wrong let me know.  I'm going off of memory with it.

Yes, but it's been ages since I've actually looked at any of this code TBH. I really cannot say one way or the other, however it sounds right.

@markcarver yeah I haven't looked at it much either in a long time. Thanks for confirming though!

I have fixed this issue by clean the cache object with code
$('.select-picker').selectpicker().ajaxSelectPicker() // Clear the cache object $('.select-picker').data('AjaxBootstrapSelect').list.cache = {}


setting file

Hello. From the last version, the subghz-brutforcer.setting file is saved in the root without the dot in front, so it is visible. It would be better to hide it and move it in the .config directory ins't it?
Thank u for the huge and continue work!!

Fixed in dev branch, now config stored properly in app folder in apps_data
Thanks for info


Adjust chat input for mobile responsiveness

Made changes to the Chat component features upon the ChatInput component onFocus or onBlur.

Issue #502


Update Pages “about”

Automatically generated by Netlify CMS

👷 Deploy Preview for kidskingdom processing.

Name
Link

🔨 Latest commit
f0fc0d90bcaece4d6890d282477d090af259c549

🔍 Latest deploy log
https://app.netlify.com/sites/kidskingdom/deploys/63b7e7bf847eb4000859fedd


Transaction snippets from omaray

The snippets for the methods commit(), rollback(), and active() from the Transaction interface.

Coverage remained the same at 84.883% when pulling 96adb6be911d768230042ecf0521fbc5df0aab8c on omaray:transaction-snippets-omaray into b0f734e07dcdb94d843915dd42c41de1762a6876 on GoogleCloudPlatform:master.

Closing this in favor of #1248


Adding overwrite parameter to move in PinotFS

Currently the callers of the PinotFS interface do not have the option to choose whether to overwrite the file at the final destination
This PR adds a boolean parameter to the PinotFS interface to allow this.
Swallow URI creation exceptions in LocalPinotFS so that other apis in LocalPinotFS don't need to unnecessarily throw IOExceptions
Added test in LocalPinotFSTest

Codecov Report

Merging #3386 into master will increase coverage by 10.14%.
The diff coverage is 50%.

@@              Coverage Diff              @@
##             master    #3386       +/-   ##
=============================================
+ Coverage     60.26%   70.41%   +10.14%
  Complexity        4        4
=============================================
  Files           990      990
  Lines         45487    45503       +16
  Branches       6099     6100        +1
=============================================
+ Hits          27415    32043     +4628
+ Misses        16073    11352     -4721
- Partials       1999     2108      +109

Impacted Files
Coverage Δ
Complexity Δ

...in/java/com/linkedin/pinot/filesystem/PinotFS.java
100% <ø> (ø)
0 <0> (ø)
:arrow_down:

...a/com/linkedin/pinot/filesystem/HadoopPinotFS.java
0% <0%> (ø)
0 <0> (ø)
:arrow_down:

...va/com/linkedin/pinot/filesystem/AzurePinotFS.java
14.86% <0%> (-0.42%)
4 <0> (ø)

.../controller/helix/core/SegmentDeletionManager.java
78.57% <100%> (+4.46%)
0 <0> (ø)
:arrow_down:

...va/com/linkedin/pinot/filesystem/LocalPinotFS.java
76.78% <60%> (-7.31%)
0 <0> (ø)

...kedin/pinot/core/util/SortedRangeIntersection.java
83.82% <0%> (-7.36%)
0% <0%> (ø)

...nsport/netty/PooledNettyClientResourceManager.java
85.41% <0%> (-4.17%)
0% <0%> (ø)

...not/transport/scattergather/ScatterGatherImpl.java
55.06% <0%> (-0.64%)
0% <0%> (ø)

.../pinot/core/segment/index/SegmentMetadataImpl.java
81.56% <0%> (+0.34%)
0% <0%> (ø)
:arrow_down:

...ator/transform/function/BaseTransformFunction.java
29.95% <0%> (+0.42%)
0% <0%> (ø)
:arrow_down:

... and 312 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fcab1ba...ad4c9d1. Read the comment docs.


adding BitClave's BCL token

website: https://www.bitclave.com

Can you link to a page where their website references the contract address you've provided?

@danfinlay , I changed token address and name to 0x1234567461d3f8db7496581774bd869c83d51c93 CAT and here is the link to official BitClave page: https://medium.com/@BitClave/adding-cat-tokens-to-your-wallet-a1771fbe513d


Adjust Listing Card Styles

This addresses some layout issues noticed in #1246

Looks good 👍

@jjeffryes can you make sure to link the learn more links to http://ob1.io/verified-moderators.html

@morebrownies the links are actually up to Tyler, they're sent from the search provider.
Attn: @tyler-smith can you update the link to http://ob1.io/verified-moderators.html ?

@jjeffryes Clicking on Learn More in the verified mod tip on a listing card not only opens up the link in the browser, it also registers a click of the listing card and opens up the listing detail. Can you fix it so the latter doesn't happen?

Aside from comment above, this one LGTM.

We have styling issue in the verified mods box on the mod detail view:

I'm not seeing that on rc2.

@hoffmabc It happens for an unverified mod. You're looking at a verified one.

We have styling issue in the verified mods box on the mod detail view:

That was fixed in a different PR that has been merged.


Speech-To-Text- / Audio-Module-Demo

Area Select
Website/Documentation
Description
Hey I'm trying to use PyTorch live for a Speech-To-Text feature. It would be great if there were a tutorial for this use case.
I read the documentation for the audio module. but I thing the documentation isn't up to date. the module provides only a record function in version "react-native-pytorch-core": "0.1.3", not start and stop-recording as described in the article.
I tried a small playground but the following code leads to an error:
const audio = await AudioUtil.record(2)
console.log('audio', audio)
const {result} = await MobileModel.execute(model_wav2vec, { audio })
console.log('result', result)

there is also a great tutorial for android but none for PyTorch live (react native)

Thanks for your kind note on the Android demo tutorial - glad you found it helpful :)
After you run:
cd live/react-native-pytorch-core/example
npx torchlive-cli run-android

Do you not see the Wav2Vec2 example?

You can also launch this from iOS:
···
cd live/react-native-pytorch-core/example/ios
pod install
open PyTorchCoreExample.xcworkspace
···
The code that handles recording is here.


[common] (Requirement Sets) Removing instruction to revert requirement set version to a number

Current guidance is to always use a string when referring to requirement set versions in isSetSupported.
This addresses issue #1394.

Docs Build status updates of commit cc6891f:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

docs/develop/convert-javascript-to-typescript.md
:white_check_mark:Succeeded

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.


ansistrano.deploy was NOT installed successfully: missing required 'current_version' from server response (https://galaxy.ansible.com/api/)

When running:
ansible-galaxy install ansistrano.deploy -c -vvvvv
I get the following output:
No config file found; using defaults
Opened /root/.ansible_galaxy
Installing role ansistrano.deploy
Opened /root/.ansible_galaxy
Initial connection to galaxy_server: https://galaxy.ansible.com
[WARNING]: - ansistrano.deploy was NOT installed successfully: missing required 'current_version' from server response (https://galaxy.ansible.com/api/)
ERROR! - you can use --ignore-errors to skip failed roles and finish processing the list.
My setup:
ansible --version : ansible <IP_ADDRESS>
Any idea what is causing this? the error seems to suggest its out of my control.
Thanks in advance

Ansible 2.3 is 6,5 years old and this is between your installation and Ansible Galaxy, nothing to do with Ansistrano


combine tool doesn't update big block at top

I found a restaurant on the map, but it was only a point.
So I drew an area around it and used the combine tool "c", to convert the point into an area.

Well, if one wants "area" at the top there to become "restaurant", one need to save the edit.
After saving click the area again.

Not only has the big block at top finally updated to "restaurant", but we can now also comfortably edit the address, etc. in full detail.
Yes it would be better if we didn't need to wastefully save just to get all that to refresh, but alas the combine tool just currently lacks that step in the things it remembers to do.
changes.osc.txt

@jidanni You opened this issue in #7450 and we'd already fixed it for the next release. I understand this release is taking awhile, but I ask for your patience. You can try out the new version at https://ideditor.netlify.app.


Feat/middletier an

Get employer info file and changed env.local to .env.local prevent leakage in the future.

Changes have already been merged. Branch is now stale

Changes have already been merged. Branch is now stale


[Feat] cloze support within mermaid diagram

I'm not sure if this would even be possible. But it would be great to have close tags within a mermaid diagram.
like
This is a question and the answer is a mermaid chart ideally with cloze support.
?
```mermaid
graph TD
    ==Start== --> ==Stop==

This looks like the image occlusion feature request #34 only on mermaid charts.

 ==Start== --> ==Stop==

After a cursory look on the mermaid API, I don't think this would be achieved this way. Maybe have a class & some styling to do the occlusions (https://mermaid-js.github.io/mermaid/#/flowchart?id=styling-and-classes, https://mermaid-js.github.io/mermaid/#/theming).
Although this would be very hacky.

So you mean defining a class and putting the chart with hidden fields in the question and the chart without that class into the answer, right? That should work I guess yes.

Yeah, but a little more automated.
You'd define one mermaid chart as usual, then do something like:
class nodeId1,nodeId2,...,nodeIdN hidden;

Then the plugin would prompt using those in turn like the usual image occlusions/cloze deletions.

Ok, so we wouldn't need to change anything in here and the issue could be closed?

Don't close it yet since the plugin doesn't yet have this part of the functionality:

Then the plugin would prompt using those in turn like the usual image occlusions/cloze deletions.

would still be nice I think :)

I don't think it would help much, but something that occurred to me is that every time a diagram is created, two more of the same could be generated, but when viewing them, the clue or answer would be shown.
Within the diagram that is created, it is added with quotation marks (to take it only as text)
What the user would create would be something like this:
graph TD
    A{"{{a;;question cloze 00;;hint}}"} --> B[question cloze 01→ hint]
    A --> C[question cloze 02→ hint]

and in the background, two variants would be created, which are the ones that would be seen when reviewing.
Cloze hidden
graph TD
    A{question cloze 00→ hint} --> B[question cloze 01→ hint]
    A --> C[question cloze 02→ hint]

hint showed
graph TD
    A{answer cloze 00→ hint showed} --> B[answer cloze 01→ hint showed]
    A --> C[answer cloze 02→ hint showed]

Cloze and hint showed
graph TD
    A{answer cloze 00 showed→ hint showed} --> B[answer cloze 01 showed→ hint showed]
    A --> C[answer cloze 02 showed→ hint showed]


Refactor db to a single module, folder, conf value

The better to override in tests, and DRY up a bunch of duplicated code.
It feels like lib/db.js should be some kind of dedicated "manage
multiple levelDBs in a single folder" module or something, but there's a
lot of BBS-specific stuff in there.  I'm not level-savvy enough to
confidently predict what other users might want in such a module, so I'm
tempted to just leave it as-is for the next brave soul to figure out.
Configuring the location of the db root folder is super important,
though.  Now, you could very easily start the server with something like
node index.js --db /var/db/bbs (or env or local.json) and it'll put
all the levels in there.  For tests, this makes it easy to wipe the db's
out and not accidentally the non-test databases.
Fixes #67

Looks like it needs a rebase?

Looks like it needs a rebase?

Yep, I'll rebase tonight.

Yep, I'll rebase tonight.

Rebased, happy to land if another committer can bless it.

Travis-CI failure is only due to requiring Twilio creds.

I have not yet had time to do a sanity check out the code changes, but the test suite passes on my box

@spinda Hey, do you mind looking this over?  You'd had a PR a while ago that did a somewhat similar cleanup.

This all looks good but my tests keep failing on this IO Error I've been seeing in various places, intermittently:
$ npm test

><EMAIL_ADDRESS>test /Users/jrhodes/personal/bigboringsystem
> lab

events.js:72
        throw er; // Unhandled 'error' event
              ^
OpenError: IO error: ./test/db/profile/LOCK: No such file or directory
    at /Users/jrhodes/personal/bigboringsystem/node_modules/level/node_modules/level-packager/node_modules/levelup/lib/levelup.js:114:34
npm ERR! Test failed.  See above for more details.
npm ERR! not ok code 0

@jasonrhodes Yeah, I just saw that, and fixed with a force-push to my db-factor branch.  Mind re-trying?
The issue is that the resetDB function needs to not be called while the app is doing stuff, or after it's been loaded, or else level has a fit.

First ever green from Travis-CI, btw :100: ^

^5 on that sweet sweet Travis green...
Re-ran tests with those changes and all tests pass, LGTM!


Implement FromStr and TryFrom traits for UriBuf and UriRefBuf

Closes #22
I also fixed a broken doc link :)

@googlebot I signed it!

Not sure why travis isn't running. Looking into it.

Commit 257cd4e looks useful, but would likely be better suited in a separate pull request.

The first 5 commits look good. I will merge them in manually today. I'll have a closer look at 257cd4e after I review your other PRs.

Note that merge commit 99a61ee does not include 257cd4e. Please file a new PR for that.


Added check if database from $Database array is accessible or not before getting roles membership

Type of Change

[ ] Bug fix (non-breaking change, fixes #)
[x] New feature (non-breaking change, adds functionality)
[ ] Breaking change (effects multiple commands or functionality)
[ ] Ran manual Pester test and has passed (`.\tests\manual.pester.ps1)
[ ] Adding code coverage to existing functionality
[ ] Pester test is included
[ ] If new file reference added for test, has is been added to github.com/sqlcollaborative/appveyor-lab ?
[ ] Nunit test is included
[ ] Documentation
[ ] Build system

Purpose

Now if user doesn't have permission on database (non-sysadmin role), user doesn't receive any warnings about it, but just empty list of roles membership.
Approach

User will be notified that the database is not accessible to user.
Commands to test

Screenshots

Learning

It's strange. Previous tests finished without errors.

hey @uncletimmy3 ! thanks so much for the PR. Those failures are not on your part, my apologies. Sometimes appveyor trips. I'll do a quick lil merge then take a closer look at your PR.

tests pass now 👍  appveyor was just having a bad day.
let me do a quick review

excellent! looks fab; thanks so much 💯


issue with the bot answering

ive done all the 10 steps provided i.e entering api_key, user_id and bot_token in appsettings.json.
i would appreciate help as soon as possible.
Thanks

Hello, make sure the appsettings data is correct, and give a screenshot of the console logger.


Improve planning repeatability

Use the longest A* path weighted by cost, since we don't plan all of the way to the goal.
Before, the path chosen could have been any of the green cells, right up to the point of finding the red cell.

(play around with it here)
Now, it will find roughly the longest path until it actually reaches the end.
Happy for comments on what exactly we can do for a quick win here to improve the choice mechanism for the A* when it only plans partially.

SITL test before:
https://logs.px4.io/plot_app?log=323a24ef-8827-4e5e-b6e7-ed24836f3316
After:
https://logs.px4.io/plot_app?log=497302be-9c69-407c-b7e1-dd64dae3eb58
There's definitely an improvement, especially in the occasional odd big 'jump' that doesn't happen anymore.

Is this something that helps short-time?

IMO yes, it needs real-vehicle testing and some more time in SITL though, since it changes the core A* path choice.

I flight tested today, no regression found. Also this PR seems to improve roll and pitch rate
master

PR


Add mypy export of jax.numpy namespace

Another option to fix #7570

I prefer the approach in  #7570, because in that version you can immediately tell that the two lists match.


[FrontDoor Management Client] Update WAF and NetworkExperiment SDKs

Add exclusions to Web Application Firewall managed rule sets, groups, and rules.
Add create, update, and get operations for Network Experiment profiles and experiments.

FYI. @jessicl-ms, @Diego-Perez-Botero, @digavino

Hi @eschwabe , could you

Add a link to the swagger spec review PR(s) in the description
Include the .txt file generated when you run generate.ps1(details)
Use version 2.0.0 since there are breaking changes
Update AssemblyInfo.cs as well

Thanks

@eschwabe - Swagger spec review PR for NetworkExperiment is: https://github.com/Azure/azure-rest-api-specs/pull/7370

@isra-fel Addressed your comments. Could you please review the latest iteration? Thanks!

@isra-fel Addressed your comments. Could you please review the latest iteration? Thanks!

The metadata txt was not in the right place, should be eng/mgmt/mgmtmetadata/.
Please follow this guide to update your build tools then regenreate.
Other changes are good to me. Thanks.

@isra-fel Addressed your comments. Could you please review the latest iteration? Thanks!

The metadata txt was not in the right place, should be eng/mgmt/mgmtmetadata/.
Please follow this guide to update your build tools then regenreate.
Other changes are good to me. Thanks.

@isra-fel I had an old version of the powershell module installed. The generate code should be fixed now. Thanks!


false negative ExplicitImplicitTypes on implicit class parameter

I get the error 'implicit definitions must have an explicit type ascription' when I add an implicit parameter to a class, which by definition must have a type ascription.

Duplicate of #188


Existing link url not shown when editing via top menu

If I select an existing link with the mouse so that it's highlighted and then click the edit link icon in either the top menu or the popup mini menu, the edit box open and the url is not populated. However it IS populated if I click the link, instead of selecting with the mouse, and then click the edit link in the tootip style message that appears below with black background.

Seems to be fixed in 1.2.1 (dev).

Seems to be fixed in 1.2.1 (dev).


Update plugins.rst

Minor punctuation, expanding on "Plugin Marketplace" where appropriate.

@aaronrothschild, PLMK whether I've added "Plugin" to mentions of "Marketplace" correctly. It's a bit unclear as to whether Marketplace is "Plugin Marketplace" or another marketplace so would be good to define this going forward. :)

Gentle ping on this, @aaronrothschild. :)


feat: bulk CIDs import

Introduces bulk import of CIDs using a text file, as requested in #2173
Users can upload a text file with a list of CIDs (and an optional name right after), as shown below:
bafkreibm6jg3ux5qumhcn2b3flc3tyu6dmlb4xa7u5bf44yegnrjhc4yeq
QmawceGscqN4o8Y8Fv26UUmB454kn2bnkXV5tEQYc4jBd6 barrel.png
QmbvrHYWXAU1BuxMPNRtfeF4DS2oPmo5hat7ocqAkNPr74 pi equals.png

Click Bulk import from Import dropdown and a modal to select a text file will pop up
Frontend validation is done on each line of the text file using isIPFS.cid(), if any line fails then user won't be able to import it. Otherwise the name of the selected file will be shown
Added new function doFilesBulkCidImport in actions.js responsible for going through text file and adding each CID
Added stories.js file
Didn't include a CLI tutor mode command since it seemed more complex than the other ones already present, but happy to revisit if needed!

Testing

Manually tested to ensure it works in both the root folder and subfolders
Tried using a text file with improper formatting, which didn't let me import
NOTE: the most number of CIDs I tested with in a file was 91, at which there was a slight lag before all the files were imported

Demo
https://github.com/user-attachments/assets/0eaee9ca-6791-40a9-8eda-80768c5e52fb

Hey @SgtPooki, I've updated the PR description and added a video, this is good to go for review!

this is great, thanks so much! Only change I can see that is needed is the removal of prop-types, and having the new BulkImportModal be a functional typescript component.
Also, we should use kebab-case-filenames instead of CamelCase. This repo hasn't been fully updated, but that's where we're going

Thanks @SgtPooki, just finished addressing all the comments!


email and url regular expressions fail to match

Hello Rick
Great library. I am actually building my own little library based on validate.js. I noticed that two regular expression do not match when they should:
emailRegex does not match ‘email@com’,
urlRegex does not match ‘http://homepagecom’
I have cloned the repository and created a branch with a fix, thought I could just send you a pull request. But my GitHub client tells me that the authentication failed. So is it not that easy?

Perhaps try opening the PR on github.com


Sequence and Flow chart

Created both a sequence chart and flow chart

nice going please submit to Google Classroom


Updated the Progress of downloading files.

Fixed issue in: #1452
In this PR I updated the progress updating of downloading files both in Sync Client and Async Client.
I did not update the Upload Files, since I think that updating progress in there will be the same, and when you download files, there is a case where you have some files and you simply want to skip them.
Problem of current progress is that, when you are downloading, it did not showed progress on "skipped" file, it just ignore it, and didn't fire any progress update.
Now with this PR, it increases the count of files checked / need to download.
Reason behind of this modification was, that when you want to show download progress to user, user can think that program doesn't do anything, when on background it does things. It is just a nice little thing to keep user notified in progress that something is happening with file.
Current progress with PR: https://youtu.be/V-f3sCHDpjU
Video of previous bug without PR: https://youtu.be/1JpgldcjjEA

I will merge this right away. I can see that calling ReportProgress will update the filecount information - this was being skipped in those "skip" cases :-))
This is a first step to a more comprehensive "progress reporting".
In the end, one will need to add more information to the progress object beyond what it contains today.

Thanks for bringing this topic up and for this quick fix.


func not aligned to T1w in space-T1w for AFNI

Hi all,
maybe I'm confused, but I would expect the EPIs in space-T1w to be aligned to the T1w_preproc.nii.gz. However, according to AFNI this is not the case, because the T1w is oblique (and has Template Space equal to ORIG) , while the EPIs are de-obliqued (Template Space = TLRC). Am I missing something obvious here? Thanks!
The preprocessing was run with fmriprep 1.0.3, with time-slicing correction and fieldmap correction.
This is the output of 3dinfo for the preprocessed anatomical:
$ 3dinfo ../../../derivatives/fmriprep/sub-sid000005/ses-famfirst/anat/sub-sid000005_ses-famfirst_acq-MPRAGE_T1w_preproc.nii.gz
++ 3dinfo: AFNI version=AFNI_17.0.18 (Mar 29 2017) [64-bit]

Dataset File:    ../../../derivatives/fmriprep/sub-sid000005/ses-famfirst/anat/sub-sid000005_ses-famfirst_acq-MPRAGE_T1w_preproc.nii.gz
Identifier Code: NII_DAj2nsNyWS6EEMIeUcLgSw  Creation Date: Tue Jan 30 13:42:42 2018
Template Space:  ORIG
Dataset Type:    Anat Bucket (-abuc)
Byte Order:      LSB_FIRST {assumed} [this CPU native = LSB_FIRST]
Storage Mode:    NIFTI
Storage Space:   50,331,648 (50 million [mega]) bytes
Geometry String: "MATRIX(-0.89991,-0.002785,-0.01328,85.69025,0.00732,-0.867079,-0.356401,126.7146,-0.010775,-0.356471,0.867011,-95.06398):192,256,256"
Data Axes Tilt:  Oblique (22.360 deg. from plumb)
Data Axes Approximate Orientation:
  first  (x) = Left-to-Right
  second (y) = Posterior-to-Anterior
  third  (z) = Inferior-to-Superior   [-orient LPI]
R-to-L extent:   -86.211 [R] -to-    85.690 [L] -step-     0.900 mm [192 voxels]
A-to-P extent:  -112.348 [A] -to-   126.715 [P] -step-     0.938 mm [256 voxels]
I-to-S extent:   -95.064 [I] -to-   143.999 [S] -step-     0.938 mm [256 voxels]
Number of values stored at each pixel = 1
  -- At sub-brick #0 '?' datum type is float

And this for one of the functionals:
3dinfo ../../../derivatives/fmriprep/sub-sid000005/ses-famfirst/func/sub-sid000005_ses-famfirst_task-fam1back_run-01_bold_space-T1w_preproc.nii.gz
++ 3dinfo: AFNI version=AFNI_17.0.18 (Mar 29 2017) [64-bit]
** AFNI converts NIFTI_datatype=4 (INT16) in file ../../../derivatives/fmriprep/sub-sid000005/ses-famfirst/func/sub-sid000005_ses-famfirst_task-fam1back_run-01_bold_space-T1w_preproc.nii.gz to FLOAT32
     Warnings of this type will be muted for this session.
     Set AFNI_NIFTI_TYPE_WARN to YES to see them all, NO to see none.

Dataset File:    ../../../derivatives/fmriprep/sub-sid000005/ses-famfirst/func/sub-sid000005_ses-famfirst_task-fam1back_run-01_bold_space-T1w_preproc.nii.gz
Identifier Code: NII_rweNOwytG0xdyvva2h0cbw  Creation Date: Tue Jan 30 13:43:09 2018
Template Space:  TLRC
Dataset Type:    Echo Planar (-epan)
Byte Order:      LSB_FIRST {assumed} [this CPU native = LSB_FIRST]
Storage Mode:    NIFTI
Storage Space:   290,111,360 (290 million [mega]) bytes
Geometry String: "MATRIX(-2.5,0,0,70.69025,0,-2.5,0,78.11269,0,0,2.5,-75.52227):58,77,58"
Data Axes Tilt:  Plumb
Data Axes Orientation:
  first  (x) = Left-to-Right
  second (y) = Posterior-to-Anterior
  third  (z) = Inferior-to-Superior   [-orient LPI]
R-to-L extent:   -71.810 [R] -to-    70.690 [L] -step-     2.500 mm [ 58 voxels]
A-to-P extent:  -111.887 [A] -to-    78.113 [P] -step-     2.500 mm [ 77 voxels]
I-to-S extent:   -75.522 [I] -to-    66.978 [S] -step-     2.500 mm [ 58 voxels]
Number of time steps = 280  Time step = 1.25000s  Origin = 0.00000s
  -- At sub-brick #0 '?' datum type is float
  -- At sub-brick #1 '?' datum type is float
  -- At sub-brick #2 '?' datum type is float
** For info on all 280 sub-bricks, use '3dinfo -verb' **

This is the output of 3dinfo on the original files
anatomical:
$ 3dinfo anat/sub-sid000005_ses-famfirst_acq-MPRAGE_T1w.nii.gz
++ 3dinfo: AFNI version=AFNI_17.0.18 (Mar 29 2017) [64-bit]

Dataset File:    anat/sub-sid000005_ses-famfirst_acq-MPRAGE_T1w.nii.gz
Identifier Code: NII_OYQWWTbPz9JZWuTghQngmw  Creation Date: Tue Jan 30 13:41:23 2018
Template Space:  ORIG
Dataset Type:    Anat Bucket (-abuc)
Byte Order:      LSB_FIRST {assumed} [this CPU native = LSB_FIRST]
Storage Mode:    NIFTI
Storage Space:   25,165,824 (25 million [mega]) bytes
Geometry String: "MATRIX(-0.89991,-0.002785,-0.01328,85.69025,0.00732,-0.867079,-0.356401,126.7146,-0.010775,-0.356471,0.867011,-95.06398):192,256,256"
Data Axes Tilt:  Oblique (22.360 deg. from plumb)
Data Axes Approximate Orientation:
  first  (x) = Left-to-Right
  second (y) = Posterior-to-Anterior
  third  (z) = Inferior-to-Superior   [-orient LPI]
R-to-L extent:   -86.211 [R] -to-    85.690 [L] -step-     0.900 mm [192 voxels]
A-to-P extent:  -112.348 [A] -to-   126.715 [P] -step-     0.938 mm [256 voxels]
I-to-S extent:   -95.064 [I] -to-   143.999 [S] -step-     0.938 mm [256 voxels]
Number of values stored at each pixel = 1
  -- At sub-brick #0 '?' datum type is short

functional:
$ 3dinfo func/sub-sid000005_ses-famfirst_task-fam1back_run-01_bold.nii.gz
++ 3dinfo: AFNI version=AFNI_17.0.18 (Mar 29 2017) [64-bit]

Dataset File:    func/sub-sid000005_ses-famfirst_task-fam1back_run-01_bold.nii.gz
Identifier Code: NII__b-iLgduU1F1pHHublcI8g  Creation Date: Tue Jan 30 13:41:38 2018
Template Space:  ORIG
Dataset Type:    Echo Planar (-epan)
Byte Order:      LSB_FIRST {assumed} [this CPU native = LSB_FIRST]
Storage Mode:    NIFTI
Storage Space:   289,013,760 (289 million [mega]) bytes
Geometry String: "MATRIX(2.499738,-0.013961,-0.033383,-122.5418,-0.020335,-2.449777,-0.498176,101.9774,0.029931,-0.498395,2.449634,-47.96387):96,96,56"
Data Axes Tilt:  Oblique (11.520 deg. from plumb)
Data Axes Approximate Orientation:
  first  (x) = Right-to-Left
  second (y) = Posterior-to-Anterior
  third  (z) = Inferior-to-Superior   [-orient RPI]
R-to-L extent:  -122.542 [R] -to-   114.958 [L] -step-     2.500 mm [ 96 voxels]
A-to-P extent:  -135.523 [A] -to-   101.977 [P] -step-     2.500 mm [ 96 voxels]
I-to-S extent:   -47.964 [I] -to-    89.536 [S] -step-     2.500 mm [ 56 voxels]
Number of time steps = 280  Time step = 1.25000s  Origin = 0.00000s
  -- At sub-brick #0 '?' datum type is short
  -- At sub-brick #1 '?' datum type is short
  -- At sub-brick #2 '?' datum type is short
** For info on all 280 sub-bricks, use '3dinfo -verb' **

So after some tests and reasoning, I think it's an AFNI issue (or feature?). Here's my reasoning, please correct me if I'm wrong.
For AFNI, an oblique dataset is a dataset that has a rotation with respect to the cardinal axes (scanner coordinates). By looking at the AFNI source code, it computes obliquity based on the affine. The s/qform_code are only used to figure out what the template space is (ORIG/TRLC).
My anatomical scans have a rotation right off the scanner because of how the scanner is placing the box. FMRIPREP of course doesn't touch the orientation of the anatomical, but aligns the EPI to the anatomical. The resulting aligned EPI is "plumb" in AFNI terminology (i.e. the affine is not a rotation).
The AFNI viewer seems to load the volume without applying the affine first, thus it assumes that whatever is loaded must be already aligned to cardinal axes (scanner coordinates). If it detects a mismatch between the sform_code of the underlay and overlay (thus inferring different template spaces), it won't let overlay them.
Loading the images both with FSLEyes and nibabel shows that the anat and func are indeed aligned in ijk space without further reslicing.
At this point, I'm not sure if this is on you guys. Solving the problem for AFNI would mean that the anatomical needs to be "de-obliqued" at the beginning of the pipeline (with 3dWarp -deoblique), but as @chrisfilo pointed out this implies reslicing the anatomical. For me, this issue can be closed, as in my mind it mostly depends on AFNI's behavior.

I agree this sounds like an AFNI problem, though if it's something they won't fix, we may still want to consider it.
De-obliquing the anatomical might not be too big a deal, at least in theory. Assuming we want to give FreeSurfer the un-de-obliqued image, there could be some trickiness, since we also feed in the skull-stripped image after autorecon1. (Might actually already be solved since we register the T1.mgz and T1w_preproc.nii.gz.)

Related poldracklab/niworkflows#221

UPDATE: I figured out a pipeline to make AFNI see the anatomical and the EPIs aligned. It requires deobliquing the anatomical, that is reslicing. But at least now I can visualize everything in AFNI :-)

Deoblique the anatomical 3dWarp -deoblique -prefix anat_deoblique.nii anat.nii.gz
Change the view for the deobliqued file 3drefit -view tlrc anat_deoblique.nii( --> for some reason AFNI still thinks this is orig, so step 3. is necessary)
Change the nifti header for the anatomical and set qform and sform to 2 nifti_tool -mod_hdr -mod_field qform_code 2 -mod_field sform_code 2 -infile anat_deoblique.nii -prefix anat_deoblique_tlrc.nii

Maybe we can fake this - I wonder what changes to the header steps 1 and 2 make.

Thanks for the question @chrisfilo :-) it made me realize that step 2 didn't really do anything, so all is needed is a) deobliquing (i.e., reslicing to cardinal coordinates, no rotation) and b) setting qform and sform to 2 in the anatomical after deobliquing.

It would be interesting to see the pre/post deobliquing diff of headers.

$ diff anat_hdr.txt anat_deoblique_hdr.txt
2c2
< N-1 header file '../../fmriprep/sub-sid000005/ses-famfirst/anat/sub-sid000005_ses-famfirst_acq-MPRAGE_T1w_preproc.nii.gz', num_fields = 43
---
> N-1 header file 'anat_deoblique.nii', num_fields = 43
14c14
<   dim                   40      8    3 192 256 256 1 1 1 1
---
>   dim                   40      8    3 197 350 351 1 1 1 1
22,24c22,24
<   pixdim                76      8    1.0 0.900004 0.9375 0.9375 0.0 0.0 0.0 0.0
<   vox_offset           108      1    352.0
<   scl_slope            112      1    1.0
---
>   pixdim                76      8    1.0 0.900004 0.900004 0.900004 0.0 0.0 0.0 0.0
>   vox_offset           108      1    3360.0
>   scl_slope            112      1    0.0
37c37
<   qform_code           252      1    2
---
>   qform_code           252      1    1
39,47c39,47
<   quatern_b            256      1    -0.193777
<   quatern_c            260      1    0.006661
<   quatern_d            264      1    -0.00283
<   qoffset_x            268      1    -85.690247
<   qoffset_y            272      1    -126.7146
<   qoffset_z            276      1    -95.06398
<   srow_x               280      4    0.89991 0.002785 0.01328 -85.690247
<   srow_y               296      4    -0.00732 0.867079 0.356401 -126.7146
<   srow_z               312      4    -0.010775 -0.356471 0.867011 -95.06398
---
>   quatern_b            256      1    0.0
>   quatern_c            260      1    0.0
>   quatern_d            264      1    1.0
>   qoffset_x            268      1    90.49987
>   qoffset_y            272      1    185.630844
>   qoffset_z            276      1    -188.499954
>   srow_x               280      4    -0.900004 -0.0 -0.0 90.49987
>   srow_y               296      4    -0.0 -0.900004 -0.0 185.630844
>   srow_z               312      4    0.0 0.0 0.900004 -188.499954

Ok - one thing I can think of trying is to zero non diagonal elements of the affine matrix of the T1w image prior to coregistration with the BOLD image (and save that as T1w_preproc). This should 'fake' deobliquing without the need for interpolation.
I wonder what @afni-rwcox thinks would be the best way to do this.

Was any further progress ever made on this? What is the current recommendation for those of us who want to view fmriprep output in AFNI?

Hi @pjkohler, we have not modified the way that T1w images are produced. I don't believe we have a current recommendation, but if AFNI is not displaying your images correctly, I would probably recommend using another tool like freeview or FSLeyes.

Just to ping that @afni-rickr might have thoughts here on the best way to go about this !

Hi @mvdoc and @emdupre, Yes, this is a long-term aspect of the afni GUI that never been dealt with.  The GUI does not resample the data (to apply an obliquity transformation) live.  We should do that (suma does, afni does not).  So in this case, since the anat is oblique, the obliquity transformation should actually be applied.  For example:
3dWarp -deoblique -prefix dset_card.nii.gz dset_oblique.nii.gz
The result will cardinal, but with the data where it belongs.  Sorry for the confusion.

@afni-rickr To be clear, 3dWarp -deoblique will reslice the data to ensure the same RAS coordinates refer to the same values (modulo interpolation), but with RAS now aligned with (some permutation of) IJK?
I ask because I feel like I've seen some cases where "deoblique" is used to mean diagonalizing the affine matrix without modifying the data, which would be changing the space.

@effigies That is right, 3dWarp -deoblique actually moves the data around (according to the oblique transformation) and resamples it on the (originallly approximated) cardinal grid.  The notion of deobliquing where the data is not modified is what 3drefit -deoblique would do, just truncating any oblique angles to the nearest cardinal grid (which is what the GUI was doing).

In the afni GUI,  oblique data is shown with an ijk->xyz transformation using the closest cardinal transformation. The data will appear "untilted".  As Rick said, there are few operations available:

Replace the oblique transformation in the header with the closest cardinal matrix
3drefit -deoblique mydset
There is no difference in the view inside the afni GUI, but there would be a difference in suma's display.

Transform the data so that the cardinal data is accurate, i.e. cardinalize the data. The data will appear tilted with zeros around the original volumes.
3dWarp -deoblique -prefix mycarddset mydset

Transform oblique or cardinal data to match another dataset's cardinal grid where each dataset may be differently oblique. The visual result depends on the target dataset's obliquity.
3dWarp -card2oblique target_oblique_dset -prefix myobldset mydset

You can see this webpage for some examples:
https://sscc.nimh.nih.gov/sscc/dglen/Obliquity
In general, I compare anatomical and EPI datasets using the third method. This is, in fact, what the align_epi_anat.py script uses as to compute transformations before fine tuning alignment.

I think I understand now that only option 3 really makes sense if I want to modify the functional file (in cardinal space, TLRC), apologies for not getting that before.
If I use option 3 to convert my functional file to test3+tlrc, and then run 3drefit -view orig test3+tlrc., the result test3+orig can be viewed with the surface volume in the AFNI viewer, and looks aligned. However, 'Template Space' in the header of test3+orig is still TLRC, and if I convert to .nii.gz with 3dAFNItoNIFTI, the resulting file reverts to TLRC and cannot be viewed with the surface volume.

@mvdoc, pretty sure 3drefit used as described above will resolve your original issue as well.

Does this mean we could achieve compatibility with AFNI viewers without adding extra interpolation to T1w outputs by adding additional affine to the combine transformation applied to space-T1w preprocessed bold outputs?

header info before:

fslhd sub-00XX_blah_bold_space-T1w_preproc.nii.gz | grep form
qform_name     Aligned Anat
qform_code     2
qform_xorient  Left-to-Right
qform_yorient  Posterior-to-Anterior
qform_zorient  Inferior-to-Superior
sform_name     Aligned Anat
sform_code     2
sform_xorient  Left-to-Right
sform_yorient  Posterior-to-Anterior
sform_zorient  Inferior-to-Superior
descrip        xform matrices modified by FixHeaderApplyTransforms (niworkflows v0.3.4).

and after 3drefit:

fslhd test4.nii.gz | grep form
qform_name     Scanner Anat
qform_code     1
qform_xorient  Left-to-Right
qform_yorient  Posterior-to-Anterior
qform_zorient  Inferior-to-Superior
sform_name     Scanner Anat
sform_code     1
sform_xorient  Left-to-Right
sform_yorient  Posterior-to-Anterior
sform_zorient  Inferior-to-Superior

and after 3dWarp+3drefit+3dAFNItoNIFTI:

fslhd test3.nii.gz | grep form
qform_name     Scanner Anat
qform_code     1
qform_xorient  Right-to-Left
qform_yorient  Anterior-to-Posterior
qform_zorient  Inferior-to-Superior
sform_name     Scanner Anat
sform_code     1
sform_xorient  Right-to-Left
sform_yorient  Anterior-to-Posterior
sform_zorient  Inferior-to-Superior

The 3 files are aligned and appear identical in fsleyes.

In the afni_proc.py and align_epi_anat.py, we concatenate the transformations including this obliquity transformation. Note that in some cases, the obliquity info is sometimes wrong, and alignment between EPI and anatomical can be computed without considering obliquity at all. We almost always consider the outputs of the processing pipelines to be cardinal, and the datasets are marked as cardinal with the equivalent C function to "3drefit -deoblique"

Hi @pjkohler.  In this case, the data seems to start out as cardinal, and so running 3dWarp should really have no effect.  The need to match the spaces is due to the original intention of the afni GUI being to provide the mechanism to go from orig to standard space.  That ability is really obsolete or mostly unnecessary now, so we will have been planning to relax the restriction.  But it currently stands.
On the flip side, if 2 datasets are aligned, why are they listed as being in different spaces?  Ah, the confusion is due to sform_code 2 changing to 1.  For that you can set AFNI_NIFTI_VIEW to orig.

@pjkohler The issue with @mvdoc, which I have not had the chance to read the updates to, was about obliquity, at least last I knew.  It is possible this could apply as a secondary issue.  I'll look it over tomorrow.  Thanks.


[WFCORE-580][WFCORE-635] Don't pretend non-existent runtime resources exist

Linux Build 1502 is now running using a merge of 747e277369a862a16efdaafdd49b70094635e4a2

Core - Full Integration Build 758 is now running using a merge of 747e277369a862a16efdaafdd49b70094635e4a2

Windows Build 1157 is now running using a merge of 747e277369a862a16efdaafdd49b70094635e4a2

Windows Build 1157 outcome was FAILURE using a merge of 747e277369a862a16efdaafdd49b70094635e4a2
Summary: Tests failed: 1 (1 new), passed: 3078, ignored: 67 Build time: 0:20:03
Build problems:
Failed tests detected
Failed tests
org.jboss.as.test.integration.domain.SSLMasterSlaveTwoWayTestCase.testReadSlaveStatusFromMaster: <no details avaliable>

Linux Build 1502 outcome was SUCCESS using a merge of 747e277369a862a16efdaafdd49b70094635e4a2
Summary: Tests passed: 3079, ignored: 67 Build time: 0:22:50

Core - Full Integration Build 758 outcome was SUCCESS using a merge of 747e277369a862a16efdaafdd49b70094635e4a2
Summary: Tests passed: 2842, ignored: 416 Build time: 0:53:15

Core - Full Integration Build 774 is now running using a merge of 59352f0a55901607cd020ab1845d5a770005c39b

Linux Build 1520 is now running using a merge of 59352f0a55901607cd020ab1845d5a770005c39b

Windows Build 1174 is now running using a merge of 59352f0a55901607cd020ab1845d5a770005c39b

Linux Build 1520 outcome was SUCCESS using a merge of 59352f0a55901607cd020ab1845d5a770005c39b
Summary: Tests passed: 3092, ignored: 66 Build time: 0:19:13

Windows Build 1174 outcome was SUCCESS using a merge of 59352f0a55901607cd020ab1845d5a770005c39b
Summary: Tests passed: 3092, ignored: 66 Build time: 0:21:09

Core - Full Integration Build 774 outcome was SUCCESS using a merge of 59352f0a55901607cd020ab1845d5a770005c39b
Summary: Tests passed: 2841, ignored: 416, muted: 1 Build time: 0:52:08


Browser support

What is the browser support?

From the README:
Sprint relies on newer APIs supported by modern browsers (read: IE10+)

I saw the IE10+ note, but it also mentions mobile. It would be nice to at least see some of the features (listing querySelectorAll, classList, setAttribute, etc). Then if someone is curious they can look it up on caniuse

IE10+ is an indicator of browser support... but it would be better to get some sort of table indicating supported versions of Chrome, FF, etc

+1 for a decent support table.

Here is a quick list of features I found when browsing the source code:
http://caniuse.com/#feat=classlist
http://caniuse.com/#feat=matchesselector
http://caniuse.com/#feat=queryselector
http://caniuse.com/#feat=getcomputedstyle
http://kangax.github.io/compat-table/es5/#Object.keys

:+1: need this

I'm slightly reluctant to specify an "official" browser support list as it'll never be 100% comprehensive and thus somehow inaccurate but, basically, any vaguely recent browser will be fine (Safari 7.1+, FF 34+, Chrome 38+, …).

I'm all for a browser support table. You should absolutely add a note regarding its specificity, but its usefulness lies in answering, "does this support IE9?" and questions like that. A comprehensive list of features it needs would be great as well, and would be much more maintainable. Just include a list of links to caniuse.com, done.


Track 1102 - Add drag/drop sorting to the fixtable

This is a really rudimentary way to add drag/drop sorting to the fixtable rows.  This is implemented only on rows now and its not intended to receive random drops and stuff.

Can you squash your commits into a single one with a sanitary comment? This is public after all.
Otherwise looks great.

Looks great, I just have a couple quibbles...
Firstly, I'd recommend changing cursor when hovering over draggable rows to provide an affordance that user can drag. I guess move is the conventional cursor here?
Second, I don't love the UX when dropping. Since only the row is highlighted, it's not obvious whether the row you're dragging is going to go above or below the row you're dropping on (until you learn the heuristic that it depends on which direction you've dragged from starting point). I know there's no straightforward way to do this, but maybe there's some way to be clever with using top or bottom border on hovered row to indicate where it will be dropped, or something else like that?
I have no problem approving as-is, but I'd definitely prefer something more usable in terms of it being clear where the row will be dropped without having to learn the rules of the system.

I agree Mike - ill play with it and give a better drop behavior to the user to better control before and after the drop target.  And i'll rebase the changes to be one clean commit as well.

Squashed into one branch and added visual cues to indicate into which location the drop will occur

Looks great 👍


Updated volume size helper text in volume creation drawer

Coverage remained the same at 30.548% when pulling d2f71e051b61d7e1a9990634f3eb5c9c6179d01f on nwisnewski:M3-1849 into 866bd0f1dcdaad99ea559a89c6c3a2b0ab38340e on linode:release-0.39.0.


cyclical reference causes loss of project

Godot version:
v3.2.alpha.custom_build.24e1039eb
OS/device including version:
Fedora 30
Issue description:
This may seem like a no brainer, but I did it by accident, and once I saved it hangs indefinitely on load even with removing the offending script.
Steps to reproduce:
Have these two scripts (I had to rename them from .gd to .txt to upload) attached to two animation sprite objects as they are, then save and try and run the scene. From then on it will freeze when you try to load the scene.
Archangel attack.txt
ArchangelIdle.txt
Minimal reproduction project:
as above.

Could you include a complete minimal reproduction project as a ZIP file? This way, we can test the project in the same way you created it.

Sure thing, I'll upload that later today.
On Fri, Sep 13, 2019, 5:25 AM Hugo Locurcio<EMAIL_ADDRESS>wrote:

Could you include a complete minimal reproduction project as a ZIP file?
This way, we can test the project in the same way you created it.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/godotengine/godot/issues/32113?email_source=notifications&email_token=AM6RRQ644NANDCGXEVBKTLDQJOBDLA5CNFSM4IWLOYC2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD6U3R2Q#issuecomment-531216618,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AM6RRQ3BN7H4W73YBGOMAI3QJOBDLANCNFSM4IWLOYCQ
.

noodles.zip
Here ya go!

Also, I realise my code is wrong here, I'm more of a golang programmer than anything at this point. However the result totally broke the program, so yeah.

I guess, the issue is about making the editor warn and resolve such problems?

Yeah, or catching the error and not compiling it into a saved state that
cannot be undone without the fix above.
On Sat, Sep 14, 2019, 12:20 AM Yuri Roubinsky<EMAIL_ADDRESS>wrote:

I guess, the issue is about making the editor warn and resolve such
problems?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/godotengine/godot/issues/32113?email_source=notifications&email_token=AM6RRQ4JFS3734UIY3OJI4DQJSGFJA5CNFSM4IWLOYC2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD6WWIPI#issuecomment-531457085,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AM6RRQ2BWFO35UUVKPJWDKDQJSGFJANCNFSM4IWLOYCQ
.

Fixed by #32643.


Authentication in CMD doesn't work

I cant authenticate myself with the cmd, when I fill in my sess i have to confirm it but it doesnt seem to do anything. When I use the submit buttons like end+enter or esc nothing happens. The only thing that keeps working in the CMD is the enter(which is return).
Do you guys have any idea how to fix this? I tried the cookie helper aswell but it does the same thing.
I'm running the latest version of OFSCRAPER with windows 10. I also added an image here below:

If adding the auth information into the scraper is not working enter the information into the auth.json file directly. Also DO NOT use the cookie helper browser extension. I've seen many have issues using it for whatever reason.

Oh fair enough, I also just saw that there isn't a auth.json file yet. Is there a command that does that for me or should I make one myself in notepad?
Thanks so far!

the scraper should automatically create one for you. But if you are on the latest 3.7.1 I haven't tested that version personally so not sure if it creates one for you like the previous version did or if you have to somehow get information for the auth into the scraper for it to create it. I don't know if you create your own auth.json file it that would work though.

I made my own file and it seems to work, thanks for your help.
Closed this issue


⚠ ClamAV has degraded performance

In 9985fa0, ClamAV (https://spamassassin.apache.org/) experienced degraded performance:

HTTP code: 200
Response time: 96 ms

Resolved: ClamAV performance has improved in 7a5796f.


Blackscreen on iPad Pro 11" (3rd Gen) with biggest display zoom, setting "more surface" and GlobalMetal=true

Hi,
I reinstalled an iPad Pro 11" (3rd Gen) and uses the biggest display zoom in the installation.

Then I go in the iOS settings to "Display & Brightness" -> "Display Zoom" and choose "More Surface".

If the attached project uses

SKIA
and GlobalMetal:=true
the screen is only black.
If
I remove SKIA
or GlobalMetal:=true
or choose "Standard" instead of "More Space"
the form is displayed properly.

Can you have a look for this. Else the GlobalMetal:=true setting should not be used in combination with iOS.
iOSMoreSurface.zip

Confirmed the issue. It also occurs on iPhone if you go to the iOS settings to "Display & Brightness" -> "Display Zoom" and choose "Larger Text". This is a regression because I remember it working 1 year ago.

This issue had been fixed in commits a44ae38 and d101e8c. Sometime later there was a regression about it.

I have a device producing the error for another 2 week in my office (rented iPad Pro).
So if you add a new fix I can test it also on our side.

I was simulating this issue on iPhone 12 iOS 16. But I now I’m with an iPhone 15 iOS 17 and I can’t simulate. If anyone could share more information about the issue, such as the exact version of iOS, it would help.

In my case, it's reproducable with iOS 17 on iPad Pro 11".

On my Iphone Xr 17.4.1 also reproduce this problem. I use code from https://en.delphipraxis.net/topic/4299-ios-metal-api-form-doesnt-fit-on-screen/?do=findComment&comment=37491 for detect scale and disable GlobalUseMetal

On my Iphone Xr 17.4.1 also reproduce this problem. I use code from https://en.delphipraxis.net/topic/4299-ios-metal-api-form-doesnt-fit-on-screen/?do=findComment&comment=37491 for detect scale and disable GlobalUseMetal

Perfect, This solves it in an alternative way, until the official fix.
  GlobalUseSkia := True;
  {$IF Defined(IOS)}
  if TiOSHelper.MainScreen.nativeScale = TiOSHelper.MainScreen.Scale then
  begin
    GlobalUseMetal := True;
    GlobalEventDrivenDisplayUpdates := False;
    GlobalPreferredFramesPerSecond := 60;
  end;
  {$ENDIF}

Does anyone know if this issue is reproduced in iOS Simulator, choosing the iPad Pro 11" 3rd Gen for example?


Cannot add the versioning task to VSTS -

VSTS Extension you are using
Versioin### Where are you running it?
VSTS
Version of Extension/Task
The currently public version
###Expected behavior and actual behavior :
Try to install the task through the marketplace . During the install we receive the following error
A task definition with id 'FD2EF332-9676-4E8F-8E95-B22BE61EC9DD', name '' has already been uploaded. To replace the existing definition, provide a task version which is greater than '1.18.3'.
The task was not previously installed and not showed in the extensions page
Steps to reproduce the problem

Add the package "Manifest Versioning Build Tasks" through the marketplace
Click confirm to install the package

result - the following error is displayed
Try to install the task through the marketplace . During the install we receive the following error
A task definition with id 'FD2EF332-9676-4E8F-8E95-B22BE61EC9DD', name '' has already been uploaded. To replace the existing definition, provide a task version which is greater than '1.18.3'.

I have just created a brand new VSTS account and installed this extension without any problems. So i think it is a local issue with your instance of VSTS
I have seen issues like this before, and it was caused by caching issues. As I remember the person fixed with one or more of the following

Logout of VSTS, login again (in a new browser session) and retry
Make sure you don't have an old version of the extension (or any of the tasks already installed). If you do remove them via the UI or the TFX command line tool
If all this fails log a support call with MS they can check for catalogue issues on your instance. I had one of these in the past due to installing an extension at the same moment a VSTS update was rolling out which caused some dupications

Closing as no further comments in a few months.


removing spotbug issues

This PR was merged a little too eagerly, as discussion still appears to be ongoing (although perhaps more discussion occurred offline). In any case, what I said offline is that I wanted to see a regex that matched all *JavaDocCodeSnippet files, and didn't list any Bug patterns, so that it would match against all JavaDocCodeSnippet files and not report any issues with them. The exclusion above is too specific in two different ways, so I would like to see it made more general in a follow-up PR. Also, there should be an XML comment that explains why the suppression is added.


trim whitespace from sign in code

I tried copying from the sign in email, but it copies a leading space 🙁
could probably do it for emails too

fixed in v2.15.0


settigns reset

when i change some setting (e.g. language to english), leave the settings page and enter it again, all settings are resetted to the default values.

I can't seem to reproduce that, are you sure you clicked on save? I think I should wait to apply language changes until you actually click save, because it gives the idea that settings are saved upon change.

Ok, i dont saw the save button :D.
But also when i dont press save, the settings are applied until i click on the setting tab again. In view of usabiltiy this behavior isnt very clear (it looks like its saved but actually isnt).
Maybe its possible to save the settings instantly when any value has been modified?
I would appreciate that.

Apart from the language, none of the settings get applied directly (not sure when or why I did that, should probably git blame myself here).
I'm gonna change it so the language doesn't directly change for the time being, but automatically saving changes might be the way to go.


autocomplete Too many parameters: the query defines 1 parameters and you bound 2

while submitting a form having an autocomplete that's ajax-powered based on documentation in Symfony an error is being returned at $form->handleRequest($request);    and the error is  Too many parameters: the query defines 1 parameters and you bound 2.
after going through the files in autocomplete package found out that in file: https://github.com/symfony/ux-autocomplete/blob/2.x/src/Form/AutocompleteEntityTypeSubscriber.php at lines 87 and 80 the where() clause is used so it caused the error after changing to andWhere() it worked.
Is this could be the solution or there is some other issue?

Hmm. There could be a bug here, but I want to make sure. Have you overridden your createQueryBuilder() inside your repository class to add a where clause already?

@weaverryan  whether you overridden createQueryBuilder () it still cause the error

@weaverryan I wanted to create a pull request but I couldn't, didn't have access.


Add support for the proxies section of maven.settings file

Maven allows for proxies to be configured in the maven.settings files. OpenRewrite's maven resolution should respect those settings.

See https://github.com/spring-projects-experimental/spring-boot-migrator/issues/573

Continued in https://github.com/openrewrite/rewrite-maven-plugin/issues/543


Test query term expansion ahead of call to get context query

Test the quality impact of query term expansion
Per discussion in Enterprise Cody Context RFC
@chwarwick says that query term expansion by LLM is not necessarily required since CodyContext search can handle the full search term.

Adding some more details here:
The user types messages in a chat box.
Other context sources don't handle that input "as is." symf does an LLM turn to expand it to a set of keywords which it stems before doing a keyword search. cody-engine/local embeddings does an embedding.
Question is, how well does getCodyContext perform, given the user message as-is? And how well does 5.2 perform with embeddings disabled? If it is not good enough then we need to do something before Feb GA. (For example, we could crib from the symf design and do the LLM turn to expand queries to keywords.)

Closing this off to evaluate and benchmark the default behaviour of the Search API vs embeddings first.
term expansion can come after we get a sense of how it currently performs


Simle web scraper

Awesome!
I will review your code and merge it after that.

Try removing that git folder from within that 17-web-scrape folder.

Sorry for late response! I created pull request after the removing git folder. So could you please check the code again.

Yeah sure!


Add 'uk' and 'ru_RU' translations of the level bar tabs

Now it's possible to locale "Main" and "Remote" tabs.

Thanks a ton for adding this -- big oversight from me. :tada:


Mac_arm64_staging native_ui_tests_macos fails with PhaseScriptExecution error

Part of https://github.com/flutter/flutter/issues/87508
Mac_arm64_staging native_ui_tests_macos
[native_ui_tests_macos] [STDOUT] stderr: ** TEST FAILED **
[native_ui_tests_macos] [STDOUT] stderr:
[native_ui_tests_macos] [STDOUT] stderr:
[native_ui_tests_macos] [STDOUT] stderr: The following build commands failed:
[native_ui_tests_macos] [STDOUT] stderr: 	PhaseScriptExecution Run\ Script /Users/chrome-bot/Library/Developer/Xcode/DerivedData/Runner-dshsfrcplzatzpawtbtixpfiwrjv/Build/Intermediates.noindex/Runner.build/Release/Flutter\ Assemble.build/Script-33CC111E2044C6BF0003C045.sh (in target 'Flutter Assemble' from project 'Runner')
[native_ui_tests_macos] [STDOUT] stderr: (1 failure)

/ @cbracken could you please help take a lool?

@keyonghan per https://github.com/flutter/flutter/issues/101721 it looks like this test stopped failing on build and was failing further along due to the Xcode harness crash.  Can this be closed?

SGTM. Closing.


fix this bug

how to set a width and height for big images ? this doesn't work

I'm having the same issue as well. Is the size of the container supposed to be set by the style of the container or by a parameter passed into ICropper(


txt records for atordvairn.js.cool

Thanks for this amazing service
Can you please add the below txt record for atordvairn.js.cool
google-site-verification=osdbHnH4vU-pBcbLFUbQFjgtcD-URHHAyLQZhP-l9YM

done

Thanks!!!


Multiple versions docs not working

Similarly to issue https://github.com/domaindrivendev/Swashbuckle/issues/197 I am not seeing docs for all of the versions of my API.
This is what I have:
			c.MultipleApiVersions(
				(apiDesc, targetApiVersion) => ResolveApiVersionsByAttributeRouting(apiDesc, targetApiVersion),
				(vc) =>
				{
					vc.Version("v2", "API v2");
					vc.Version("v1", "API v1");
				});

public static bool ResolveApiVersionsByAttributeRouting(ApiDescription apiDesc, string targetApiVersion)
{
  return apiDesc.Route.RouteTemplate.Contains(targetApiVersion);
}

My routes are attribute routes containing v1 and v2 as plain text (within RoutePrefix).
The ResolveApiVersionsByAttributeRouting never gets called with targetApiVersion set to v1, that is why I only see v2 API docs generated.

Also the
.EnableSwaggerUi(c =>
{
c.EnableDiscoveryUrlSelector();
});
does not render the version selector dropdown (readme states it should).

Can't repro any of this in the dummy app.
The lambda not getting called for specific targetApiVersion values sounds like very strange behavior because it's really not reflective of the way the code works. Could you show me your full SwaggerConfig.cs as that may provide some more clues, or at least help me repro.
Thanks

Closing for now as I can't repro. Feel free to re-open if you have more details to share.

I could reproduce that. @brgrz, you probably customized swagger frontend and modified Index.html or removed some js files. I see from sourcecode that EnableDiscoveryUrlSelector() injects custom js resourse, but I'm not sure where it takes it from. @domaindrivendev, could you advise?


migrate realtimeitlplanning to realtimeitlplanning3

Now realtimeitlplanning is removed from planningcommon/__init__.py and we need to migrate it to realtimeitlplanning3. As it is tedious to update customers, we should do it automatically.

@rdiankov we cannot ship tw_master software if the customer uses controllerclientcpp. I believe it is problematic.

@rdiankov We are shipping soon~

thanks~


Make Router.handle() fallback handling not reliant on router handlers calling next()

Description
Kitura Router.handle() has some fallback handling in case none of the handlers call response.end or send any data. Invoking this fallback handling is dependent on the route handlers calling next(), which it should not be.
Motivation and Context
#1009
How Has This Been Tested?

Checklist:

[ ] I have submitted a CLA form
[ ] If applicable, I have updated the documentation accordingly.
[ ] If applicable, I have added tests to cover my changes.

Codecov Report

Merging #1010 into master will increase coverage by 0.48%.
The diff coverage is 77.77%.

@@            Coverage Diff             @@
##           master    #1010      +/-   ##
==========================================
+ Coverage   90.33%   90.81%   +0.48%
==========================================
  Files          34       34
  Lines        1655     1644      -11
==========================================
- Hits         1495     1493       -2
+ Misses        160      151       -9

Impacted Files
Coverage Δ

Sources/Kitura/RouterElementWalker.swift
100% <100%> (ø)
:white_check_mark:

Sources/Kitura/Router.swift
86.95% <75%> (+5.44%)
:white_check_mark:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 30c8360...eaa2bcc. Read the comment docs.

This can be merged once the build runs.


nushellPlugins.hcl: init at 0.100.0

Added package for nu_plugin_hcl.
Things done

Built on platform(s)

[ ] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)

[ ] sandbox = relaxed
[ ] sandbox = true

[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[ ] Fits CONTRIBUTING.md.

Add a :+1: reaction to pull requests you find important.

@Kamillaova sorry to tag you again, I'm still unable to request review via GitHub UI. I reopened the PR because it was easier than struggling with amending commits after rebase.

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:
https://discourse.nixos.org/t/prs-ready-for-review/3032/4946


Yet more tests

Added a number of tests.
In particular found one test which would crash the entire test runner (seems to be due to an access violation exception):
[Fact]
public void ItFailsWithInvalidMutability()
{
    var act = () => new Global(Store, ValueKind.Int64, 0, (Mutability)13);
    act.Should().Throw<InvalidOperationException>();
}

This was caused by two things:

Immediate problem was a missing check if the returned value is IntPtr.zero in this one particular case (added that check).
Casting numbers into Mutability should not be possible. Replaced Mutability with a struct which has two predefined values (Mutable and Immutable). This should be almost source compatible with the old enum - the only thing it does not allow is casting numbers into Mutability.

Thanks for the review, I hope you had a good holiday :)


Adding Core Team Section By Introducing It By Glassmorphism UI Trend

Live Demo Of Changes💻

@KunalUpadhyay02
Please remove the background and the outer box
Just add the person floating boxes and also fix the dimensions

Live Demo of Changes

Great work!
Thanks for contributing


feat(tab): enable cycle tab selection

closes #258

I took a stab myself for this feature, while I also have relatively high confidence PR is not feasible to be accepted.
This PR exposes one more settings values to allow cycle tab selection, either next / previous tab hotkey will select to last / first tab if user specifies to.
point of consideration

may possible to control this behavior via plugin instead of core?
: I couldn't find relative interface support, but maybe I am lack of knowledge simply.

Is it feasible to expose under application settings, under appearance?
: It isn't actually appearance but more about behavior, while current settings doesn't have specific category. Hotkey provider is managing assigned key combination, so picked current one instead.

Would it be better to have checkbox instead of radio?
: this may not be big deal (and could reuse all styles), but still this could be checkbox for boolean flag.

Thanks for your contribution! 🍺
A fine addition, but I think that it should actually be the default behaviour! Please set it to true in the config defaults.
This is a very minor setting that doesn't need GUI, I'll just add it to the config docs.

@Eugeny cool! updated PR as suggested.


Implement "odo list"

What type of PR is this:
/kind feature
What does this PR do / why we need it:
Which issue(s) this PR fixes:
Fixes #5991
PR acceptance criteria:

[x] Unit test

[x] Integration test

[x] Documentation

How to test changes / Special notes to the reviewer:

LGTM feature-wise.
/approve
Added a few comments related to documentation.

Thanks for your review @rm3l
I approved the docs changes and rebased on master to fix the conflicts.

/override ci/prow/v4.10-integration-e2e
Tests pass on IBM Cloud
/override SonarCloud Code Analysis


The cell's vMerge attribute may be incorrect

When I attempt to process the table through the vMerge attribute of cells, I've noticed that the vMerge value for some cells should be 'continue', yet it actually appears as 'restart'.
When I use the code below, I noticed that the vMerge attribute value obtained for the same cell is different in two ways. Is this due to some design intention or is it an error?
    for table in doc.tables:
        for row in table.rows:
            tr = row._tr
            row_cell_tc = [tc for tc in tr.tc_lst]
            cell_tc = [cell._tc for cell in row.cells]

This has to do with the way row.cells works.
Check out this page in the docs and then if you still have questions let me know:
https://python-docx.readthedocs.io/en/latest/user/tables.html
Basically, [tc for tc in tr.tc_lst] with give you the actual value in the w:tc element. cell in row.cells gives you the "root" (top-left) cell for a spanned cell so vMerge for that will always be "restart" (when it exists).
Feel free to reopen if you end up with more questions after reading.


⚠ Bofrost.lu has degraded performance

In 5d06005, Bofrost.lu (https://www.bofrost.lu) experienced degraded performance:

HTTP code: 200
Response time: 1516 ms

Resolved: Bofrost.lu performance has improved in 21b50cd after 6 minutes.


Triggering an Error inside QueuedClosure fails

Laravel Version: 8.26.1
PHP Version: 7.4.3
Database Driver & Version:

Description:
CallQueuedHandler::failed $e can be of type Throwable while CallQueuedClosure::failed $e only accept Exception. Native PHP Errors are not exceptions.
Steps To Reproduce:
$dummy = new Dummy(); dispatch(function () use ($dummy ) {     $dummy ->shouldFail(); });
class Dummy {     public function shouldFail(int $v) {} }
Expected: Should display a Too few arguments to function shouldFail.
Current Behavior: Displays Argument 1 passed to Illuminate\Queue\CallQueuedClosure::failed() must be instance of Exception, instance of ArgumentCountError given
Proposed solution:
Replace "Exception" in CallQueuedClosure with "Throwable"

This was recently fixed.


Login Token Duration is assumed milliseconds instead of seconds

Per https://www.vaultproject.io/docs/concepts/lease.html#lease-durations-and-renewal:

The lease duration is a Time To Live value: the time in seconds for which the lease is valid. A consumer of this secret must renew the lease within that time.

However it looks like LifecycleAwareSessionManager assumes lease durations are in milliseconds
To verify, run a simple client app with -Dorg.apache.http.wire=debug and watch your login token get renewed every second.

Any ETA for 1.0.2 release? Thanks!

I updated the schedule for 1.0.2 to June 16th.


Quiz exercises: Adjust user interface of quiz header and footer

Checklist
General

[x] I tested all changes and their related features with all corresponding user types on a test server.
[x] I chose a title conforming to the naming conventions for pull requests.

Client

[x] Important: I implemented the changes with a very good performance, prevented too many (unnecessary) REST calls and made sure the UI is responsive, even with large data (e.g. using paging).
[x] I strictly followed the client coding and design guidelines.
[x] Following the theming guidelines, I specified colors only in the theming variable files and checked that the changes look consistent in both the light and the dark theme.
[x] I added multiple screenshots/screencasts of my UI changes.
[x] I translated all newly inserted strings into English and German.

Motivation and Context

The previous footer had issues, especially on smaller screens.
Description

Rearranged some information and buttons. Removed duplicated information (e.g. practice or preview). Stick footer to the bottom. Align the design in general and refactored some code.
Steps for Testing

Prerequisites:

1 Instructor
2 Students
Multiple Quiz Exercises (Synchrinised, Barched, Individual)

Log in to Artemis
Navigate to Course Overview --> Exercises
Start different Quiz Exercises in different Modes (Preview, Pracitce, Live, View Results)
Verify that everything works as expected

Testserver States

[!NOTE]
These badges show the state of the test servers.
Green = Currently available, Red = Currently locked
Click on the badges to get to the test servers.

Review Progress

Code Review

[ ] Code Review 1
[ ] Code Review 2

Manual Tests

[x] Test 1
[x] Test 2

Screenshots

Before:
Live:

Practice:

After:
Live:
<img width="1727" alt="Screenshot 2024-11-12 at 15 00 37" src="https://github.com/user-attachments/

assets/717221e5-35f9-4e5a-baef-47c9bd3faaf6">
Practice:

Summary by CodeRabbit
Release Notes

New Features

Enhanced layout and structure for the quiz participation interface.
Improved modularity for mode indicators and consolidated display logic for quiz instructions and results.
Added routing capabilities to differentiate between management and standard views.

Bug Fixes

Streamlined connection status display logic for clarity.

Style

Updated styling for quiz elements, including time warnings and footer sections, focusing on a more streamlined approach.
Introduced new CSS classes for improved layout flexibility and sticky positioning.

Localization

Simplified phrasing for auto-save messages in both German and English localization files.

also is there a reason why the footer in the edit view has that much padding?

Thanks for the introduction of the templates and re-structuring which makes the template easier to read
I left some minor comments where I do not have a strong opinion, I see more work for this component but not within the scope of this PR:

I think that it might be good to divide the quiz-participation.component.html into further smaller components (e.g. another on vor the Overlay section and one for the Step Wizard)
The complexity of the template could also additionally be reduced by adding computed signals, which would also require the introduction of signals 😅

I totally agree, I just wanted to approach it in smaller steps.