How to skip the pre-training of static images and BK30L and go directly to VOS training?

How to skip the pre-training of static images and BK30L and go directly to VOS training? What changes need to be made in the code and command line?

Yes. Just start stage 2 without loading a pretrained model.


Col padding causes issues.

Because of the fixed padding for the Columns (10px default) there are styling issues when it comes to specifying your widths. Columns should be padding and margin free.

Row and Col both accept the property gutter, which is defaulted to 20px. It'd be nice if this could be defined once in the consumer app and possibly passed down through context.
@Tackyshot you can use the prop to set your gutter right now
@JedWatson thoughts on defaulting through context?

is there any documentation? because for the life of me I can't seem to find it.

Sorry @Tackyshot! Just realised that it's undocumented atm.
For handling the grid col:
basis:
	number, // pixels
	string  // percentage
gutter: number
lg: string // width as a percentage or fraction
md: string // width as a percentage or fraction
sm: string // width as a percentage or fraction
xs: string // width as a percentage or fraction

With row only gutter is important


Update travis config file

This PR should fix the build on travis as it was failing on #28 (it notably switches the version of ubuntu to xenial and now also runs tests on python 3.6 and 3.7) .
There is also some minor changes in the readme.md file (to fix the formatting) and in the setup.py file (python 2.7 was complaining without the explicit coding part).

Thanks for fixing this!


make log4j version range compatible with pax-logging

make log4j version range compatible with pax-logging

 Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.


Can't set title to empty string

I've tried title="",title=" ",title=" "
Am I missing something shouldn't it be possible to set the title to empty ?

because the empty string equal to false.
you can try title-tpl="". Sorry for unclear document

Awesome that works.


about DINO+MS-DETR

I tried to add MS-DETR to DINO and found that the performance dropped a lot compared to before I added it, it seems to be due to o2m supervision affecting o2o, does the author have any idea what might be causing this?

Yes, we find on the original DINO repo, o2m seems not compatible. We incorporate the contrastive denoising queries (CDN) from DINO into the Deformable-DETR code and it works with o2m supervision. I think the reason may lie in the loss weights and the way to average the loss, which is different in DINO and Deformable-DETR. But we did not further explore it.


Add deprecation warnings on import of geometry code moved to polliwog

As discussed in #12, this is a legacy library destined for deprecation.
Two pieces of functionality have already been broken out into new libraries in the lace org, and more will be added in the future.
One of these is polliwog which replaces several parts of blmath.geometry.
Importing one of the replaced modules should emit a deprecation warning which refers developers to the new package.

Going to deprecate the whole library instead.


i want only phone number authentication

how to change only phone number authentication please give me source code

You can use below snippet to sign in only with phone number and it will directly open phone number activity instead of default activity of this library which shows all the different options to log in.
startActivityForResult(
    AuthUI.getInstance()
        .createSignInIntentBuilder()
        .setAvailableProviders(
                Arrays.asList(new AuthUI.IdpConfig.Builder(AuthUI.PHONE_VERIFICATION_PROVIDER).build()))
        .build(),
    RC_SIGN_IN);

It means if you have enabled only one way to sign in, this library will not show custom activity with one option. If you enable more than one way to sign in, then only it will show custom activity with all sign in options. I am using the same code in my app.


Check if file has changed before generating favicons

Looks like this plugin is generating every favicon every time it runs, regardless of whether the source icon has changed. Given how long image generation takes, this is a bit of a deal breaker.
Please perform a check to see if the source image has changed and if not, skip favicon generation.

hmm.. https://github.com/jantimon/favicons-webpack-plugin/blob/master/README.md persistentCache defaults to true, so this plugin alsways also creates a .cache file, which contains hash for logo.png and options.
Just tried it and it seems to work, the webpack plugin does not regenerate icons, if logo.png or options do not change.
// Generate a cache file with control hashes and
// don't rebuild the favicons until those hashes change
persistentCache: true,

Can you supply a way to reproduce the issue?

Sure: If you pull this: https://github.com/Undistraction/gatsby-skeleton

yarn
yarn run dev
You'll see the build hang during the favicon image processing.
Cancel out and run again and you'll see the same hang, despite the fact the favicons have been generated already.
Remove the plugin and rerun and you won't see that hang.

I'm on OSX 0.11.6 btw.

Can confirm, build times are 10 times higher, with this plugin activated. Not sure, if this is an issue with https://github.com/jantimon/favicons-webpack-plugin and where the fix is needed.

It should be fixed by #6, thank you @mperkh and @Undistraction for the report!

Nicely done. I'll give it a good check tomorrow.

This is working nicely now. Thanks.
You should add this plugin to Gatsby's list of community plugins: https://www.gatsbyjs.org/docs/plugins/


Add sql queries statements

As per this PR, I managed the following:

[x] Create a database named vet_clinic.

[x] Create a table named animals with the following columns:

id: integer

name: string

date_of_birth: date

escape_attempts: integer

neutered: boolean

weight_kg: decimal

[x]  Add my sql scripts to the .sql files.

That is good looking now 👍


bridge: bogus log message

I got this when starting the bridge:
2019-09-19 12:18:31,430 INFO     [main] bridge.service: Starting wait_for_start_block service
2019-09-19 12:18:31,448 INFO     [wait_for_start_block] bridge.main: home node is fully synced until head number 0, but chain hasn't reached event fetch start block number 4153205 yet. Waiting...
2019-09-19 12:18:36,482 INFO     [wait_for_start_block] bridge.main: home node is fully synced until head number 0, but chain hasn't reached event fetch start block number 4153205 yet. Waiting...
2019-09-19 12:18:41,490 INFO     [wait_for_start_block] bridge.main: home node is synced until block number 4153846 of 0 and has passed the event fetch start block number 4153205
2019-09-19 12:18:41,506 INFO     [wait_for_start_block] bridge.main: foreign node is synced until block number 31415 of 1325134, but hasn't reached event fetch start block number 1321331 yet. Waiting...

The one that's wrong is this one:

2019-09-19 12:18:41,490 INFO     [wait_for_start_block] bridge.main: home node is synced until block number 4153846 of 0 and has passed the event fetch start block number 4153205

It's produced by this statement: https://github.com/trustlines-protocol/blockchain/blob/master/tools/bridge/bridge/main.py#L105-L112
Apparently highest_block_number is 0 which is taken directly from the result of the eth_syncing RPC call. So my guess is  that this is a Parity bug?

If it's only the log statement, I don't care much. But doesn't this also affect waiting for the start block?
(I didn't look at the code)

The problem here was warp-mode
https://github.com/trustlines-protocol/blockchain/pull/487 will handle the warp-mode case. If it's merged, this issue can be closed.


no attribute 'XJSONField'

I have suddenly got a new error that wasn't a problem before, have tried to retrace my steps but cannot find the issue.
I'm running with Django 4.0.6 and Django-salesforce 4.1
File "/Users/brendonstead/Desktop/Kinnelhead/SEO/seo-usa-portal/usaportal/accounts/urls.py", line 4, in
from accounts import views
File "/Users/brendonstead/Desktop/Kinnelhead/SEO/seo-usa-portal/usaportal/accounts/views.py", line 3, in
from core.salesforce_models import Account
File "/Users/brendonstead/Desktop/Kinnelhead/SEO/seo-usa-portal/usaportal/core/salesforce_models.py", line 11912, in
class EntityDefinition(models.Model):
File "/Users/brendonstead/Desktop/Kinnelhead/SEO/seo-usa-portal/usaportal/core/salesforce_models.py", line 11952, in EntityDefinition
recordtypessupported = models.XJSONField(db_column='RecordTypesSupported', blank=True, null=True)  # Field name made lowercase.
^^^^^^^^^^^^^^^^^
AttributeError: module 'django.db.models' has no attribute 'XJSONField'. Did you mean: 'JSONField'?
I have a separate version which works and has no issue with the XJSON field?

Your problem is that you probably mix Salesforce models created from an existing Salesforce database by manage.py inspectdb --database=salesforce with a normal Django model for standard databases. An exported file models.py for Salesforce starts with a line from salesforce import models and it should not be replaced by a line from django.db import models.
I recommend you to delete Models that you do not need or to select only explicit names that you use by manage.py inspectdb --database=salesforce SomeModel CustomModel__c OtherModel....
The field salesforce.models.XJSONField is a counterpart of an Salesforce internal "complexvalue" field type that is used only by User Interface API or by Tooling API for work with metadata. EntityDefinition and FieldDefinition are accessible also by a standard API in recent Salesforce versions, but you probably do not need them.
My docs string forXJSONField:
Salesforce internal "complexvalue" field similar to JSON, used by SFDC for metadata,

this field should not be used for normal data or with other database backends.

(Have you ever thought about sponsoring this project? It is easy with "Sponsor" button on the project home page.)


Provision the client community with access to CSPM CloudGuard

Describe the issue
We wish teams to be able to consume and benefit from the CSPM tool.
Additional context

Cloud Security Posture Management is default configured to consume for authorization AWS Organizational Units, GCP Folders and Azure Management Groups.
In our SEA models, we use the above grouping structures for security policy logical grouping, so we can't use organizational units in the "normal" vanilla way
might be possible to automate via a TF module to automate OU's within CloudGuard but PO would prefer if it could consume tags instead.

Definition of done

Talk to Mark L on the Parks team and use them as a guinea pig for trying this out
Mark should be able to log in via SSO, and only see workload environments that pertain to the scope of his team's work

@bruce-wh-li can you please update this issue or close it if it is complete/relevant.

We had onboarded HLTH and Forest Client API Team of WLRS to CSPM already.


fix no-duplicate-super validates with ternary operator

PR checklist

[x ] Addresses an existing issue: #3275
[x ] New feature, bugfix, or enhancement

[x ] Includes tests

[ ] Documentation update

Overview of change:
Added case for ternary operator in no-duplicate-super rule.
CHANGELOG.md entry:
[bugfix] using ternary operator for calling super() now passes no-duplicate-super rule.

Thanks @mateuszwitkowski


⚠ SceneTime has degraded performance

In 0246326, SceneTime ($ST) experienced degraded performance:

HTTP code: 200
Response time: 1966 ms

Resolved: SceneTime performance has improved in ea1cbcc after 6 minutes.


Suggest feature branch

In react, we need to do some refactor. when "suggested password" button clicked, response password should saved to clipboard. but it saved previous value of "suggestedPassword".

In react, we need to do some refactor. when "suggested password" button clicked, response password should saved to clipboard. but it saved previous value of "suggestedPassword".

I'll look into it!


Setting not working

Hello I was hoping that you might be able to help me configure the extention
I am able to connect to alfresco using cmis workbench but I cant with the plugin
I am running erpnext 7.22 and alfreco 5.1
If your willing to help I can give you anymore information you need

Hi, i have not tested the plugin against erpnext 7.X and alfresco 5.1. I will do that in the next days.

Hello do you happen to have an update. I have someone that might be able to
work on updating it but he just doesn't know where to start.
On Thu, Sep 15, 2016 at 3:36 AM, bedynamic<EMAIL_ADDRESS>wrote:

Hi, i have not tested the plugin against erpnext 7.X and alfresco 5.1. I
will do that in the next days.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/arizem/ERPNext2Alfresco/issues/3#issuecomment-247258118,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AFG2BEd6Q691yWYRB0K6zU169jSxRkQLks5qqPWRgaJpZM4JrK7q
.

Hi,
i am sorry I am busy with other projects right now. I haven't found the time.
Do you have any error logs ?
Does it install right ?
Can you manage the doc types ?
When and where does the error happen ?
Most important would be the error logs (see in erpnext  logs/bench.log)
May I can help you
Kind regards
Tobias
Am 10.11.2016 um 22:32 schrieb woakes070048<EMAIL_ADDRESS>
Hello do you happen to have an update. I have someone that might be able to
work on updating it but he just doesn't know where to start.
On Thu, Sep 15, 2016 at 3:36 AM, bedynamic<EMAIL_ADDRESS>wrote:

Hi, i have not tested the plugin against erpnext 7.X and alfresco 5.1. I
will do that in the next days.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/arizem/ERPNext2Alfresco/issues/3#issuecomment-247258118,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AFG2BEd6Q691yWYRB0K6zU169jSxRkQLks5qqPWRgaJpZM4JrK7q
.

—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub, or mute the thread.

I will get you some log files. The issue that we were having is connecting
to the alfresco repository. I was able to access alfresco repositories
using CMIS workbench.
On Thu, Nov 10, 2016 at 5:28 PM, bedynamic<EMAIL_ADDRESS>wrote:

Hi,
i am sorry I am busy with other projects right now. I haven't found the
time.
Do you have any error logs ?
Does it install right ?
Can you manage the doc types ?
When and where does the error happen ?
Most important would be the error logs (see in erpnext logs/bench.log)
May I can help you
Kind regards
Tobias
Am 10.11.2016 um 22:32 schrieb woakes070048<EMAIL_ADDRESS>
Hello do you happen to have an update. I have someone that might be able
to
work on updating it but he just doesn't know where to start.
On Thu, Sep 15, 2016 at 3:36 AM, bedynamic<EMAIL_ADDRESS>wrote:

Hi, i have not tested the plugin against erpnext 7.X and alfresco 5.1.
I
will do that in the next days.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<https://github.com/arizem/ERPNext2Alfresco/issues/3#
issuecomment-247258118>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/
AFG2BEd6Q691yWYRB0K6zU169jSxRkQLks5qqPWRgaJpZM4JrK7q>
.

—
You are receiving this because you commented.

Reply to this email directly, view it on GitHub, or mute the thread.

—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/arizem/ERPNext2Alfresco/issues/3#issuecomment-259826683,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AFG2BG2kEsJhxgX_8sD8Qc8MbgIhhplIks5q85qagaJpZM4JrK7q
.


pin npm to latest version

Looks like we weren't specifying a version of npm before. I checked locally that npm install -g<EMAIL_ADDRESS>works.
@benrudolph

does that work? that's essentially saying npm install npm -g. we've traditionally used this to upgrade node: https://github.com/dimagi/commcarehq-ansible/blob/pin-npm/ansible/roles/common_installs/tasks/main.yml#L69

@benrudolph I saw that but I'm trying to upgrade npm not node. The assumption of course is that upgrading npm and upgrading node isn't the same thing. Is that wrong?

ah interesting. i think you're right as is. sorry about the confusion

@dannyroberts I assume your change is correct, but I remember running into a multitude of issues with npm containing a specific version of node, or the opposite, and one of those versions being very out of date. Don't remember the exact issues that came up, but just a note if you see something similar crop up.

OK, good to know. So far I've run this on staging and prod with no apparent problems. It might be that once you install npm indirectly through apt-get node, you can then self-upgrade it npm update<EMAIL_ADDRESS>just fine.


Could this work with Klaviyo?

Hey there! first of all thank you for this script! so far for mailchimp it works great!I managed to work on the issue i had previously! but i do want to use klaviyo if possible and using this one by changing the url format to klaviyos "https://a.klaviyo.com/api/v2/list/{LIST_ID}/subscribe" i get an error for wrong format in api key.

Hello,
Sorry for a long reply. Yes, this script needs a Text component on the GameObject it is attached to if calling Subscribe(). You could use Subscribe( string email ) method instead.
Best regards,
Mikhail Shagin

7 марта 2021 г., в 01:16, Stratos @.***> написал(а):
Hey there! first of all thank you for this script!! so i tried it with my own mailchimp account and i have an input field thay works as a leaderboard, gets send to a database , so i though i could use this one to get my users emails. so i tried calling subscribe from my button that sends the info to the database but no! this error comes up. so i though it might be needed to be placed on the input field that has text but neither does that work. am i doing something wrong?
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub https://github.com/fiftytwo/MailChimpSubscriber/issues/2, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABS6SVNC3YSQO2HTHM7QCJ3TCKSULANCNFSM4YXFENEA.


How to install expressjs

I am trying to use expressjs in my app.
After install it using typings install express --ambient --save, I run tsc, but I get two errors:
typings/main/ambient/express/index.d.ts(17,34): error TS2307: Cannot find module
 'serve-static'.
typings/main/ambient/express/index.d.ts(18,27): error TS2307: Cannot find module
 'express-serve-static-core'.

so, I tried to install both:
typings install serve-static --ambient --save
typings install express-serve-static --ambient --save

and then I run tsc again, but get one more error:
typings/main/ambient/serve-static/index.d.ts(79,24): error TS2307: Cannot find m
odule 'mime'.

how can I solve these problems? how can I install all dependencies of express automatically?

how can I install all dependencies of express automatically?

Write it for Typings, not as an ambient module from DefinitelyTyped. Duplicate of a few issues such as https://github.com/typings/typings/issues/292.

@blakeembrey So I have to install all these dependencies manually yet because the express d.ts file is not written for typings?

Yes. References are always stripped.

To be clear, it's a shitty situation, but references don't mean anything. Because a reference can be to any file, both ambient or another module. It doesn't clearly mean a dependency. Some I've seen are even circular. We can't really do anything with it, because you don't know what to do with it. Even TypeScript recommends you don't use references when typing modules.


Removing arbitrary width of dropdown menu name

💬 Description
This fix is best explained in picture form.
BEFORE:

AFTER:

🚪 Start Points
Where is a good place to start the review? If there are multiple changes it may be worth listing multiple files.
👫 Related PRs (optional)
Any PRs that relate to the changes.
✅ Checklist

[ ] Tests written
[ ] Browser tested
[ ] Added to documentation
[ ] Added to storybook

 Selected template in the template dropdown breaks layout

 Selected template in the template dropdown breaks layout

 Position of template dropdown is borked

 Selected template in the template dropdown breaks layout


Filter search result by photos

the loklak_server already provides  a filter option to produce only search results containing images: just add a " /image" to the user's query.

Done with https://github.com/loklak/loklak_webclient/pull/164 , commits on 12/4

I cannot see this function any more, the twitter search result view is broken

It's fixed. The cause was from an unsolved conflict in some merge, in which break the css syntax, so style wasn't included at all!


Elements inside SVG don’t scale

Thank you for your work in bel and yo-yo 👍
Consider this SVG:
<svg width="140" height="140" viewbox="0 0 70 70">
  <circle cx="35" cy="35" r="30" stroke-width="3" fill="red" />
</svg>

The circle should scale up to fill SVG’s, according to its viewbox, but when the element is created with bel, circle doesn’t scale.
Live example: http://requirebin.com/?gist=32979ca8d3231e3a86ac872260fa3322 — the second element is created manually and scales like it should. In DOM they look identical, must be some SVG behind-the-scenes magic?

Oh weird, so if you do viewbox="0 0 70 70" in the innerHTML the browser corrects the attribute to viewBox.
But since bel will do element.setAttribute('viewbox', '0 0 70 70') it will not correct the attribute.
The technical answer is use viewBox as that attribute is named with a capital B but I'm curious as to when/why the browser will correct attributes and when it will not, heh.

Oh, thanks! Was not aware it’s actually viewBox. Do you think a warning should be added in docs or console?

Added to the docs thanks!


Add Missing Methods for Messages

Some endpoints of the following section can't be hit from this SDK.
We would like to ensure that all endpoints can be hit. For this issue, we would like to build out the Messages
Missing methods:
Get Messages - https://docs.novu.co/api-reference/messages/get-messages
Delete Message - https://docs.novu.co/api-reference/messages/delete-message

Assigning this to you right now @sccalabr

Assigned ⭐


Convert message.mp3 to message.caf (IMA4) for UNNotificationSound.

Hi
This is untested due to provisioning issues, but in theory could fix https://github.com/vector-im/riot-ios/issues/2264 🤞🏻
If someone can test this internally, I'll update CHANGES.rst and sign off the request if it works 👍🏻
Pull Request Checklist

[ ] UI change has been tested on both light and dark themes
[ ] Pull request is based on the develop branch
[ ] Pull request updates CHANGES.rst
[ ] Pull request includes screenshots or videos of UI changes
[ ] Pull request includes a sign off

Update: unlikely to fix #2264, but probably worth testing and merging anyway.

Thank you for your contribution. You just forgot to add the message.caf file to the Riot target in the project and remove the message.mp3 reference. Otherwise it works. Thanks!

Derp! Fixed 👍🏻


release erroranalysis 0.3.7

Description
Includes the new changes:
Refactor categorical statistics computation in separate module
Make generic class interface for cohort based filtering
erroranalysis: Bug fix in classification outcome cohort filter
Checklist

[ ] I have added screenshots above for all UI changes.
[ ] I have added e2e tests for all UI changes.
[ ] Documentation was updated if it was needed.

Codecov Report

Merging #1606 (9a2ca4e) into main (371e669) will decrease coverage by 13.33%.
The diff coverage is n/a.

@@             Coverage Diff             @@
##             main    #1606       +/-   ##
===========================================
- Coverage   88.91%   75.58%   -13.34%
===========================================
  Files         110       10      -100
  Lines        5415      258     -5157
===========================================
- Hits         4815      195     -4620
+ Misses        600       63      -537

Flag
Coverage Δ

unittests
75.58% <ø> (-13.34%)
:arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files
Coverage Δ

erroranalysis/erroranalysis/version.py

raiwidgets/raiwidgets/responsibleai_dashboard.py

...tools/error_analysis/dashboard_schemas/__init__.py

raiutils/raiutils/data_processing/__init__.py

.../databalanceanalysis/aggregate_balance_measures.py

responsibleai/responsibleai/_internal/__init__.py

raiutils/raiutils/dataset/dataset.py

...eai/responsibleai/databalanceanalysis/constants.py

...sponsibleai/responsibleai/rai_insights/__init__.py

responsibleai/responsibleai/__init__.py

... and 90 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.


rightElement in Input requires 2 clicks to trigger onClick action

Description
When IconButton with onClick action is in Input rightElement section, it requires 2 clicks to trigger onClick action for this component
CodeSandbox/Snack link
https://docs.nativebase.io/input#h3-password-input
Steps to reproduce

go to 'https://docs.nativebase.io/input#h3-password-input'
Click on InputText area
Click on 'Show' button (nothing happens)
Click on 'Show' button - it changes to 'Hide' and handler for onClick is triggered

Expected:
Step 3 should change text to 'Hide' and trigger action
NativeBase Version
3.3.x
Platform
(did not check others, only confirmed with Expo)

[ ] Android
[ ] CRA
[X] Expo
[ ] iOS
[ ] Next

Other Platform
No response
Additional Information
When you click twice on Icon then clicking again requires just 1 click, it looks like when you are focused on input area then first click is to just get focus to IconButton and then clicking again fires proper action.

Hello @kpbochenek, Thanks for reporting this issue, we'll fix it soon.

I tried to solve it, but I can't, in next some things that I can see with my try:

The problem is only in web
The problem occurs when the 'isFocused' state of 'Input' changes
The 'InputRightElement' is returned of a function 'usePropsResolution' and this component is returning a while times, I guess that problem can stay here, the component return when onBlur is called clicking in 'InputRightElement' and it is rendering again, causing the error of onClick

I hope I could have helped :D

I’m running into the same issue on web. I have tried a few different kinds of “buttons” and none of them is working 100% as expected. Some of them is even never responding to clicks at all. However, focusing the button using the tab key and pressing the enter key always fire onPress. Also, for all NativeBase components that support isPressed and isFocused props for render props or _pressed and _focus pseudo props, these props are being updated/applied as expected on the second and subsequent clicks (assuming onPress did not fire on the first click), and isHovered and _hover is always working 100% as expected. Some slight differences below:

onPress of NativeBase Pressable is never fired no matter how many times I click it. Clicking it 2+ times in a roll has no effect. Even if the Input did not have the focus before the first click, clicks are never registered.

NativeBase IconButtoncan have different behaviors depending on whether the _pressed, _hover, and _focus pseudo prop have a nested _icon pseudo prop set:

If the _focus prop is set with a nested _icon pseudo prop, then (regardless of whether _pressed or _hover is set  with a nested _icon pseudo prop), the IconButton fires onPress on the third click if the Input had the focus before the first click, and onPress is fired on the second click if the Input did not have the focus before the first click.
If the _focus and the _hover pseudo props are not set with a nested _icon pseudo prop, but the _pressed pseudo prop is set with a nested _icon pseudo prop, the IconButton never fires onPress regardless of whether Input had the focus before the first click. Similar to situation 1 with Pressable.
If the _focus pseudo prop is not set with a nested _icon pseudo prop, but the _hover pseudo prop is set with a nested _icon pseudo prop, then (regardless of whether the _pressed pseudo prop is set with a nested _icon pseudo prop), the onPress fires on the second click if Input had the focus before the first click and onPress fires on the first click if Input did not have focus.

NativeBase Button and TouchableOpacity from react-native is behaving the same way as 2.iii.

Hey @zhumingcheng697, Thanks for your investigation. This issue is fixed in 3.4.15.

@ankit-tailor is 3.4.15 already in docs?
https://docs.nativebase.io/input#h3-password-input
checked 3.4.x or next and they both still have this issue but it might be that docs were not rerendered yet for new version?

It appears that the issue still persists in the latest build.
The issue seems to be related to how focus was being managed by <Input>. Specifically, if the onBlur listener was removed from the internal implementation of the <Input> component, the click would be registered correctly. If the callback in the listener is fired with a delay, the click would also be registered correctly.
However, neither delaying nor disabling the onBlur callback seems to be good solutions to the problem.
What I found out instead was that onMouseUp would work perfectly fine on the web.
<Input
  {...props}
  rightElement={
    <IconButton
      icon={icon}
      onPress={() => {
        callback();
      }}
      _web={{
        // @ts-ignore
        onMouseUp: (e: MouseEvent) => {
          if (!e.button) {
            callback();
          }
        },
      }}
    />
  }
/>;

I added the onMouseUp listener only on the web, and I also check for e.button to make sure that the callback is not fired when the user right clicks for context menu. For whatever reason, after adding the onMouseUp listener, onPress does not seem to be firing on the web, but you can just add another platform check to be extra safe if the callback is not idempotent (i.e. it has “superimposing” effects when being called multiple times).


Binary sensor: Color is different

Hi!
The binary sensor shines in a really bright red instead of the dark red color. Where can this be changed?
Best, vrs01

Hey @vrs01 ,
thanks for your input. I think it should be fixed in 9e7b5c8b3127b34db0bd5b4160f502312746b10c. Can you confirm it?
Best, Julian


Entries in README.md should be alphabetically ordered

The README.md file should be reorganised that all entries are on an alphabetical basis.

Done


Methods within normal and BDD Asertions

Summary
This is more like a question then a problem. I was having a look at the BDDAssertions and Assertions, also the soft types. Is the general idea that all of the assertThat from the Assertions exist as then method in BDDAssertions?
If yes then I would propose some way of guaranteeing this, by either always generating the BDDAssertions from the Assertions, or by creating a test that would test all the methods from the Assertions.
Additionally about the methods between the soft assertions and the assertions are not consistent.
Example
I did a small analysis on the (2.x branch) and there are some difference between the methods:

Assertions
BDDAssertions

public static <K, V> MapAssert<K, V> assertThat
public static <K, V> AbstractMapAssert<K, V> then

public static  T assertThat(final AssertProvider component)
missing

public static  T assertThat(T assertion)
missing

public static AbstractPathAssert<?> assertThat(Path actual)
missing

Java 8 specific ?
NO

That would be great indeed.
Thanks for the analysis, I'll fix that right away.

I also noticed that the soft assertions use the implemented classes of the assertions, is there some reason for this?
I am asking since I can also make a test which checks if the BDDAssertions have the same methods as the AbstractBDDSoftAssertions. If you say yes, then we need to decide how to fix it. Should we always return our own implementations of the Abstract*Assert or the abstract ones. If we return the abstract we would introduce breaking changes. This same thing applies for the difference in the MapAssert vs the AbstractMapAssert, and the methods in the Assertions vs the AbstractSoftAssertions

Soft assertions could actually return AbstractXXXAssert classes but need to proxy the concrete class (CGLIB needs a concrete class to instantiate to be able to create a proxy).

If it is ok to return the AbstractXXXAssert then I will do that. Shortly I would create a pull request with the test I have in mind and also the "fixes" for the test

@joel-costigliola Do you think that we could somehow use something from the assertj-assertions-generator to generate the different Assertions classes.
Maybe if we add Annotations to the different Assert classes we can generate the Assertions. I am thinking in this direction, since with something like this one would only need to write a new asserter add the appropriate information in the Annotation and everything will be synced

It's ok as long as we don't add any compile/runtime dependencies to assertj-core, another option to consider is JavaPoet to generate java source.

I guess this can be closed, as the missing methods (and tests to prevent this in the future) were added in 2.5.0/3.5.0.

@joel-costigliola Please close this issue. Thanks!

Closed, thanks.


Update msal-net-web-browsers.md to mention web browser behaviour on .NET 5.0+

Update page to mention web browser behaviour on .NET 5.0+

@dsun1 : Thanks for your contribution! The author(s) have been notified to review your proposed change.

@dsun1 : Thanks for your contribution! The author(s) have been notified to review your proposed change.

#label:"aq-pr-triaged"

@dsun1 : Thanks for your contribution! The author(s) have been notified to review your proposed change.

#sign-off


Display Messages From ESLint

Is there a way to display messages from eslint?

It should already do that.
Do you have ESLint extension installed? I don't see the squiggly lines under the warning range. Is the warning generated in the PROBLEMS panel or is only shown in terminal?

You right, I need to install ESLint extension. Now It's work. Thank you.


Opsgenie Sink Close support. More details

Added close support and additional details to the alert.
Cleaned up formatting.
This resolves issue #525

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

Thanks, we will review soon! Sorry about the delay.


Upgrade to spring boot 2.2.1

see https://spring.io/blog/category/releases

SpringBoot 2.2.5 came out with fixes for two CVEs: https://spring.io/blog/2020/02/27/spring-boot-2-2-5-released

Tried to upgrade to 2.2.6, but there are some issues:
...core/src/main/java/com/daimler/sechub/server/core/SecHubExceptionHandler.java:6: error: cannot find symbol
import org.apache.tomcat.util.http.fileupload.FileUploadBase.SizeLimitExceededException;
                                                            ^
  symbol:   class SizeLimitExceededException
  location: class FileUploadBase
...-core/src/main/java/com/daimler/sechub/server/core/SecHubExceptionHandler.java:18: error: cannot find symbol
    public Exception handleFileUploadSizeExceeded(SizeLimitExceededException ex, HttpServletResponse response) {
                                                  ^
  symbol:   class SizeLimitExceededException
  location: class SecHubExceptionHandler

...core/src/main/java/com/daimler/sechub/server/core/SecHubExceptionHandler.java:16: error: cannot find symbol
    @ExceptionHandler(SizeLimitExceededException.class)
                      ^
  symbol:   class SizeLimitExceededException
  location: class SecHubExceptionHandler
3 errors


math plugin issues

Hi @JiHong88
I am using the katex plugin for math but it seems to be repeating the keystrokes. Is there anything i am doing wrong.

You can use this demo link
https://codepen.io/mkhstar/pen/wvMpXMZ

@mkhstar To use "katex" you need to attach "katex" css.
<html>
  <link rel="stylesheet"<EMAIL_ADDRESS>  <textarea id="sample"></textarea>
</html>


Add blog post for 1.18 release interview

Following on from #22716, an interview post with Jorge Alarcón.

/assign @castrojo

Page preview:
https://deploy-preview-22882--kubernetes-io-master-staging.netlify.app/blog/2020/08/03/physics-politics-and-pull-requests-the-kubernetes-1.18-release-interview/

/lgtm

/approve


Fullscreen layout

Is there a way to create a more full screen layout, like this?

I ended up just setting fit to cover, and placing the AppBar in the stack

This actually won't work as intended when using ScanWindow: https://github.com/juliansteenbakker/mobile_scanner/issues/448

Actually, the ScanWindow works. It's when the window is changed dynamically (e.g. via state), that we get issues.

I think it's related to this: https://github.com/juliansteenbakker/mobile_scanner/issues/975


[Issue]: ROCdbgapi-rocm-6.1.1 fails to build with Clang-19: no member named 'n_next' in 'doubly_linked_entry_t

Problem Description
Hi,
Clang 19 is now smart enough to find issues in template code, even if this template was never instantiated.
Issue is here: https://github.com/ROCm/ROCdbgapi/blob/rocm-6.1.1/src/utils.h#L497-L505
Build fails with:
/var/tmp/portage/dev-libs/rocdbgapi-6.1.1/work/ROCdbgapi-rocm-6.1.1/src/utils.h:497:13: error: no member named 'n_next' in 'doubly_linked_entry_t<T, Tag>'; did you mean 'm_next'?
  497 |     m_prev->n_next = this;
      |             ^~~~~~
      |             m_next
/var/tmp/portage/dev-libs/rocdbgapi-6.1.1/work/ROCdbgapi-rocm-6.1.1/src/utils.h:490:34: note: 'm_next' declared here
  490 |   doubly_linked_entry_t<T, Tag> *m_next{ nullptr };
      |                                  ^
/var/tmp/portage/dev-libs/rocdbgapi-6.1.1/work/ROCdbgapi-rocm-6.1.1/src/utils.h:505:13: error: no member named 'n_next' in 'doubly_linked_entry_t<T, Tag>'; did you mean 'm_next'?
  505 |     m_prev->n_next = this;
      |             ^~~~~~
      |             m_next
/var/tmp/portage/dev-libs/rocdbgapi-6.1.1/work/ROCdbgapi-rocm-6.1.1/src/utils.h:490:34: note: 'm_next' declared here
  490 |   doubly_linked_entry_t<T, Tag> *m_next{ nullptr };
      |                                  ^
2 errors generated.

Looks like it is just a typo and n_next should be replaced with m_next.
Operating System
Gentoo
CPU

GPU
AMD Instinct MI300X
ROCm Version
ROCm 6.1.0
ROCm Component
No response
Steps to Reproduce
No response
(Optional for Linux users) Output of /opt/rocm/bin/rocminfo --support
No response
Additional Information
No response

Hi, thanks for the catch and the report.
I am preparing a patch against our internal repo to remove the unused doubly_linked_list_t type.  I am not sure yet when it will reach github (we are working towards reducing this time).  In the meantime, do you need a patch you can use locally to fix that issue (replacing n_next with m_next should work as a minimal patch)?

@lancesix , thank you for quick response!
No, patch is not needed, sed -e "s/->n_next/->m_next/g" -i src/utils.h fixed the issue. I just want to remove this fix in some future version.

Fixed in 0f41e80b7c0d4d0ad41bff43e07baf2fa2c1e6e9.


Product images

Add Example images of the Editor to the readme.
Will make more people use it if they see what they are installing

Thanks for your suggestion. I don't really want people to use this anymore since the open source version of CKEditor 4 is end-of-life.


Test that "require => FOO" will (perhaps indirectly) require BAR

It's a neat "feature" of puppet that if a class is inside another class, then requiring the outer class won't require the inner class. The solution to this is pretty simple: in 3.4 we have contain(), and prior to that, anchor. However, expressing the problem that these solutions solve in a test assertion is difficult.
It looks like we can currently assert that there are anchor resources exist, and they have require => this and before => that, but that isn't directly expressing the requirement, which is that require => Class['ntp'] will also effectively require => Service['ntp'] (but you, as a user of the ntp class, wouldn't do that, because that would be breaking encapsulation.) The NTP module might like to have a test like this:
describe 'ntp' do
  it { should contain_service('ntp').that_is_contained_by("Class[ntp]") }
end

A test such as this would pass even if Service[ntp] happens to be in ntp::service (an implementation detail) or if the requirement was solved with contain() or anchor. Thus, it allows us to refactor our manifests while simultaneously asserting that the specified functionality (that I can do require => Class['ntp'] and expect something reasonable) is maintained.

This should be addressed by #261


subscribeCrosshairMove got IllegalStateException

when i use subscribeCrosshairMove to get the crosshair's data, I got the IllegalStateException as shown in the picture below

Hi!
I found the problem in serialisation module.
I will push the fix in the next beta release

There is a new beta version of lightweight library with fixes for crosshair mode
https://github.com/tradingview/lightweight-charts-android/releases/tag/v1.0.0-beta02


refactor: replace goto with for

Replace goto with for as requested https://github.com/newrelic/infrastructure-publish-action/pull/83#discussion_r607671794
I still think this is one of the few legit usages of goto, making the code more readable in this case.
wdyt?

I'm personally not a huge fan of goto, I also prefer the for loop. I do think there's a return or break statement missing at the end of the lock tho, when the if branch is no taken.


When go to previous screen not refresh data

Hi @slovnicki, I have an implementation problem, please help me :) to solve these problems, when I go to the screen (context.beamToNamed ('/ transaction / add') and change the information (for example, add records), and then return to the previous screen with context.beamToNamed ('/ transactions'), the initState method its not called the behavior its similar like the go back button, and the information and my screen have inconsistent.
How to force to rebuild again the previous screen ?

Hi @javierbm7
Thanks for creating an issue.
You need to use some kind of InheritedWidget (via provider, flutter_bloc or any state management of your choice) to store your transactions and notify when some has changed. Then in your screen Widget you can watch for those changes, meaning everything will work as you expect.
See this for more details: https://stackoverflow.com/questions/49804891/force-flutter-navigator-to-reload-state-when-popping


Fix event

Jira: CT-XXX
KBC: XXX
Before asking for review make sure that:
Checklist

[ ] New client method(s) has tests
[ ] Apiary file is updated

Release

[ ] I gave the PR a proper label:

major (BC break)
minor (new feature)
patch (backwards compatible fix)
no release (just test changes)

viz https://github.com/keboola/connection/pull/4507#discussion_r1265110137


Wildcard SSL certificates

PR to fix #18

@sephii even if I already merged this, could you have a look on the PR to see if I did a blunder ?
Thanks !


new rule, interface has references to classes

Interfaces should refer to itself or other interfaces, if a method definition refers to something in a class, then something is broken in the architecture IMHO

soon?

I'm starting this now


OWNERS: Add myself, and move former team members to emeritus

OWNERS: Add myself, and move former team members to emeritus
Signed-off-by: Juan Rodriguez Hortala<EMAIL_ADDRESS>

@simonpasquier

/lgtm

/approve


Can't add abilities to the action bar

screenshots
https://imgur.com/5sjWtjd
Please take note of how the "Coup de grace" icon is "hanging" to the left of the ability list, while the cursor is hovering over the same ability in the ability list. The information pop-up and the highlight of the ability confirm the cursor is hovering over the ability.

Here's a gif of the issue (sorry about the watermark and quality I'm a noob at this)
https://imgur.com/a/1LC9ocu

combat log
N/A

game log here: "%appdata%..\LocalLow\Owlcat Games\Pathfinder Wrath Of The Righteous"
GameLog.txt

Description:
When using DarkCodex new abilities/spells/items cannot be added to the action bar.
I first click and drag an icon of an ability to the action bar, then release while hovering over the desired slot. However, the game doesn't seem to register the "release" part. The icon of that ability will hover in whatever place the mouse cursor was when the button was released and will "hang" there until I click and drag a new ability or click and drag in the action bar.
If I click and drag in the action bar, the mouse will again grab the "hanging" icon.
Due to this issue it isn't possible to use the action bars, either the horizontal or the vertical ones. The issue isn't present when the mod isn't installed, this is how I got a few abilities already assigned in first screenshot.
The gif is showing the issue on a new game.
Both the screenshot and the gif were taken with only the DarkCodex mod installed and none of its options selected.

There was a large update, which broke multiple patches/features. That will take some time to fix.

There was a large update, which broke multiple patches/features. That will take some time to fix.

Waiting eagerly for your update, your mod is one of the best out there!

Disabling mods usually renders the save unusable. You need to wait.

I pushed an update fixing the biggest issues. I suspect there is more to do.

Thank you @Truinto!
The issue was resolved in the latest version of DarkCodex.


[ZEPPELIN-1644] Add rewrite rule for #1615

What is this PR for?
https://github.com/apache/zeppelin/pull/1615 requires additional rewrite rule on website
What type of PR is it?
Improvement
Todos

[x] - Add rewrite rule

What is the Jira issue?
https://issues.apache.org/jira/browse/ZEPPELIN-1644
How should this be tested?
Screenshots (if appropriate)
Questions:

Does the licenses files need update? no
Is there breaking changes for older versions? no
Does this needs documentation? no

LGTM


az keyvault role assignment create documentation mismatch

Describe the bug
The documentation for param --assignee-principal-type states that:
accepted values: Application, DirectoryObjectOrGroup, DirectoryRoleTemplate, Everyone, ForeignGroup, Group, MSI, ServicePrincipal, Unknown, User

However, running with --assignee-principal-type MSI yields:
ERROR: az role assignment create: 'MSI' is not a valid value for '--assignee-principal-type'. Allowed values: User, Group, ServicePrincipal, ForeignGroup. during pipeline run.
Running with:
az role assignment create --assignee-object-id $CLUSTER_MSI_PRINCIPAL_ID \
 --role "Key Vault Crypto Service Encryption User" \
 --assignee-principal-type ServicePrincipal \
 --scope $CLUSTER_KV_ID

Where the $CLUSTER_MSI_PRINCIPAL_ID is fetched through:
CLUSTER_MSI_PRINCIPAL_ID=$(az identity show --name $CLUSTER_MSI \
  --resource-group $CLUSTER_RG \
  --query 'principalId' \
  --output tsv)

I went with the recommendation in https://github.com/Azure/azure-cli/issues/11594#issuecomment-1047918766 which worked.
Related command
az role assignment create
Errors
ERROR: az role assignment create: 'MSI' is not a valid value for '--assignee-principal-type'. Allowed values: User, Group, ServicePrincipal, ForeignGroup.
Issue script & Debug output
CLUSTER_MSI_PRINCIPAL_ID=$(az identity show --name $CLUSTER_MSI
--resource-group $CLUSTER_RG
--query 'principalId'
--output tsv)
az role assignment create --assignee-object-id $CLUSTER_MSI_PRINCIPAL_ID
--role "Key Vault Crypto Service Encryption User"
--assignee-principal-type ServicePrincipal
--scope $CLUSTER_KV_ID
Expected behavior
Consistency between CLI and documentation
Environment Summary
/usr/bin/az --version
azure-cli                         2.53.0
core                              2.53.0
telemetry                          1.1.0
Extensions:
azure-devops                      0.26.0
Dependencies:
msal                            1.24.0b2
azure-mgmt-resource             23.1.0b2
Additional context
No response

Thank you for opening this issue, we will look into it.

This issue doesn't seem to be related to keyvault. Just want to double check, the command is az role assignment create, right?
The help message of --assignee-principal-type has been fixed long ago by https://github.com/Azure/azure-cli/pull/16056:
> az role assignment create -h
...
    --assignee-principal-type     : Use with --assignee-object-id to avoid errors caused by
                                    propagation latency in AAD Graph.  Allowed values: ForeignGroup,
                                    Group, ServicePrincipal, User.

The documentation for param --assignee-principal-type states that:
accepted values: Application, DirectoryObjectOrGroup, DirectoryRoleTemplate, Everyone, ForeignGroup, Group, MSI, ServicePrincipal, Unknown, User

Could you share where you see this information? Thanks.

Hi @jiasli,
No, not related to key vault. This is merely a discrepancy between the accepted parameters of --assignee-principal-type on the CLI and what is documented.
The -h option seem to give the correct output which should be reflected in the docs found here:

Cheers,
Casper

Related to #15994 #21020

I see what you mean. az role assignment create and az keyvault role assignment create have different help messages for --assignee-principal-type
> az role assignment create -h
...
    --assignee-principal-type     : Use with --assignee-object-id to avoid errors caused by
                                    propagation latency in AAD Graph.  Allowed values: ForeignGroup,
                                    Group, ServicePrincipal, User.

> az keyvault role assignment create -h
...
    --assignee-principal-type -t : The principal type of assignee.  Allowed values: Application,
                                   DirectoryObjectOrGroup, DirectoryRoleTemplate, Everyone,
                                   ForeignGroup, Group, MSI, ServicePrincipal, Unknown, User.

--assignee-principal-type from az keyvault role assignment create is defined at
https://github.com/Azure/azure-cli/blob/dfee0e19225f78d0bd2b57c441074c5c81f39f32/src/azure-cli/azure/cli/command_modules/keyvault/_params.py#L833-L847
These lines were introduced by https://github.com/Azure/azure-cli/pull/12181.
az keyvault role assignment create should make the same change as https://github.com/Azure/azure-cli/pull/16056.
BTW, the doc of Role Assignments - Create REST API https://learn.microsoft.com/en-us/rest/api/keyvault/managedhsm-rbac/role-assignments/create is under the Managed HSM - RBAC category, but the reference doc of
az keyvault role assignment create https://learn.microsoft.com/en-us/cli/azure/keyvault/role/assignment#az-keyvault-role-assignment-create doesn't mention it only applies to managed HSM:
> az keyvault role assignment create -h

Command
    az keyvault role assignment create : Create a new role assignment for a user, group, or service
    principal.

(The conceptual doc https://learn.microsoft.com/en-us/azure/key-vault/managed-hsm/role-management does have detailed explanation on az keyvault role assignment create.)

@Frankkkkk, these 2 issues #15994 #21020 are not related to this one.


Managed Components not part of project in separate directory? (PACMAN-744)

Related area
component directory
Is your feature request related to a problem?
This is similar to https://github.com/espressif/idf-component-manager/issues/13 and https://github.com/espressif/idf-component-manager/issues/40 but I would like to be able to manage components in a shared project directory.
Describe the solution you'd like
I'd like to be able to idf.py add-dependency or perhaps have new idf.py install-component into a directory that is not part of a project, but is otherwise shared by possibly multiple projects or examples.
I didn't see anything mentioned in the IDF Component Manager Documentation.
Note I was able to use add-dependency, but needed to create a hacky main directory:
gojimmypi:/mnt/c/homekit/esp32-homekit-demo
$ idf.py add-dependency "wolfssl/wolfssl^5.6.0-stable"
/mnt/c/SysGCC/esp32/esp-idf/v5.1/tools/check_python_dependencies.py:12: DeprecationWarning: pkg_resources is deprecated as an API. See https://setuptools.pypa.io/en/latest/pkg_resources.html
  import pkg_resources
Executing action: add-dependency
ERROR: Directory "/mnt/c/homekit/esp32-homekit-demo/main" does not exist! Please specify a valid component under /mnt/c/homekit/esp32-homekit-demo or try to use --path
gojimmypi:/mnt/c/homekit/esp32-homekit-demo
$ mkdir main
gojimmypi:/mnt/c/homekit/esp32-homekit-demo
$ idf.py add-dependency "wolfssl/wolfssl^5.6.0-stable"
/mnt/c/SysGCC/esp32/esp-idf/v5.1/tools/check_python_dependencies.py:12: DeprecationWarning: pkg_resources is deprecated as an API. See https://setuptools.pypa.io/en/latest/pkg_resources.html
  import pkg_resources
Executing action: add-dependency
Created "/mnt/c/homekit/esp32-homekit-demo/main/idf_component.yml"
Successfully added dependency "wolfssl/wolfssl^5.6.0-stable" to component "main"
Done

Any guidance as to Best Practices would also be appreciated.
Describe alternatives you've considered
Install the component to each example.
Install the component to the HomeKit submodule. (see below)
Additional context
This is specifically in reference to @AchimPieters using wolfSSL as a managed component in the esp32-homekit project.
In particular, note there's a shared solution components directory that's used by the examples.
I have somewhat of a workaround as described in https://github.com/wolfSSL/wolfssl/issues/5909#issuecomment-1758318130. However it's not a very graceful solution in that I copied the managed component source into a new, non-managed component directory.
I have checked existing list of Feature requests and I have provided enough information.

[X] I confirm I have checked existing list of Feature requests and I have provided enough information.

Hello @gojimmypi
Thank you for raising the topic,
The proposal of install-component sounds sensible, but it's very hard to implement because components are not simply downloaded and unpacked. As the very first step the full tree of dependencies is built. For this the context of the project (IDF version, current target) is required to choose the right versions of all dependencies. Even if you add only one dependency it may have intricate web of sub-dependencies.
At the same, what is stopping you from adding the dependency from the component registry to all the examples?

Hi @kumekay -
Thanks for your feedback!

it's very hard to implement because components are not simply downloaded and unpacked

hm, yes, I suspected as much.

what is stopping you from adding the dependency from the component registry to all the examples

Ah, a good question! What I neglected to explain in enough detail here (but explained more in the long thread of https://github.com/wolfSSL/wolfssl/issues/5909), is that in the case of the esp32-homekit example, there's some intricacy of where the wolfSSL settings are defined (i.e. the CMakeLists.txt for the esp32-homekit  vs the managed component user_settings.h in the example code).
I'm thinking in the end, the best place to add the managed component in this example is the esp32-homekit submodule, as that's where the crypto.c uses wolfssl. Do you agree? Those examples don't even use wolfSSL directly.
Somewhat related to this topic is the desire / ability to not only use a managed component, but also be able to configure it. For example, today if the wolfSSL component is used as a managed component, I believe the user_settings.h is then locked in place with regards to the .component_hash file. Once the user_settings.h is changed, the hash no longer matches, and there's a resulting idf.py warning / suggestion to move the code to a non-managed component directory. What are your thoughts on this topic? Do you see managed components as only a getting started capability?

Regarding user_settings.h: in IDF we generally follow the approach that users should not need to modify source or header files. Where compile-time configuration is necessary, it is achieved using Kconfig.
It is also possible to let the wolfssl component find user_settings.h in another location — for example, in the build directory. The user's project can then use CMake configure_file command to generate the user_settings.h file at build time.
However, I would generally suggest creating a Kconfig file for configuration options. Here's an example how this is done with MbedTLS:

https://github.com/espressif/esp-idf/blob/master/components/mbedtls/port/include/mbedtls/esp_config.h — the equivalent of user_settings.h, part of the component, not intended to be modified.

Kconfig options are defined here: https://github.com/espressif/esp-idf/blob/master/components/mbedtls/Kconfig

We were able to resolve the ESP32 HomeKit issues (it's really quite cool, and I created a little blog on the topic).
Given the comment from @kumekay regarding the complexity of implementing install-component, I'll close this issue.
I plan to follow @igrr 's suggestion and use the kconfig for wolfSSL user_settings.h configuration. I'll look into if I can use the file from another directory outside of the component structure.
Thank you.


KMS key policy and encrypted node groups - circular dependency

Is your request related to a new offering from AWS?

Is your request related to a problem? Please describe.
I am trying to create a custom KMS key (CMK) and use that for both encrypting the EKS secrets, as well as the node EBS blocks. In order to do this, the AWSServiceRoleForAutoScaling service-linked role needs to have permissions to use the key. However, this role does not exist until you create your first ASG. Now what happens is a circular dependency between the key policy and the service-linked role which will be created when the EKS module creates the node groups (and therefore ASGs). Something like this:
data "aws_caller_identity" "current" {}

data "aws_iam_policy_document" "kms_main" {
  statement {
    sid    = "Allow service-linked role use of the CMK"
    effect = "Allow"
    principals {
      type        = "AWS"
      identifiers = ["arn:aws:iam::${data.aws_caller_identity.current.account_id}:role/aws-service-role/autoscaling.amazonaws.com/AWSServiceRoleForAutoScaling"]
    }
    # ...
  }
  # ...
}

resource "aws_kms_key" "main" {
  key_usage                = "ENCRYPT_DECRYPT"
  customer_master_key_spec = "SYMMETRIC_DEFAULT"
  policy                   = data.aws_iam_policy_document.kms_main.json
}

module "eks" {
  source  = "terraform-aws-modules/eks/aws"
  version = "17.20.0"

  # ...
  cluster_encryption_config = [
    {
      provider_key_arn = aws_kms_key.main.arn
      resources        = ["secrets"]
    }
  ]

  node_groups_defaults = {
    # ...
    disk_kms_key_id = aws_kms_key.main.arn
    # ...
  }
}

It is apparent that the EKS module depends on the key ARN, but the key resource also depends on AWSServiceRoleForAutoScaling service-linked role to exist, else I get MalformedPolicyDocument: Invalid principal in policy.
If I create/manage this service-linked role through Terraform, then I cannot easily apply all this multiple times (for example in different regions), as it will complain about the role already existing. Also, I tried creating the service-linked role with the custom_suffix argument set, but the node groups / ASGs are still created using the default role which doesn't have the suffix. I found the service_linked_role_arn argument in this module, but that is only for worker groups, not node groups.
Am I missing something here, or will I have to manage the service-linked role through Terraform as well?
Describe the solution you'd like.

Describe alternatives you've considered.

Additional context

Hello @mj3c ,
I am facing exactly the same issue, have you ever found a solution for the problem?
I haven't tried to run apply again after their first execution, does it work the 2nd time?

Since this is still a problem, can we ask for this  issue to be reopened?

Hi @nmofonseca . I don't think I have resolved it, it doesn't seem possible to work around with terraform only. If I remember correctly, I opted for creating the service-linked role manually in the AWS console, removing it from terraform code, and then running terraform apply.

@mj3c , thanks for coming back at me, I tried to create the role manually using aws cli, like this:
aws iam create-service-linked-role --aws-service-name autoscaling.amazonaws.com --custom-suffix myenv and changed the

Then I changed the policy to use that role on the ebs policy:
data "aws_iam_policy_document" "ebs" {
  # Copy of default KMS policy that lets you manage it
  statement {
    sid       = "Enable IAM User Permissions"
    actions   = ["kms:*"]
    resources = ["*"]

    principals {
      type        = "AWS"
      identifiers = ["arn:aws:iam::${data.aws_caller_identity.current.account_id}:root"]
    }
  }

  # Required for EKS
  statement {
    sid = "Allow service-linked role use of the CMK"
    actions = [
      "kms:Encrypt",
      "kms:Decrypt",
      "kms:ReEncrypt*",
      "kms:GenerateDataKey*",
      "kms:DescribeKey"
    ]
    resources = ["*"]

    principals {
      type = "AWS"
      identifiers = [
        "arn:aws:iam::${data.aws_caller_identity.current.account_id}:role/aws-service-role/autoscaling.amazonaws.com/AWSServiceRoleForAutoScaling_myenv", # required for the ASG to manage encrypted volumes for nodes
        module.eks.cluster_iam_role_arn,                                                                                # required for the cluster / persistentvolume-controller to create encrypted PVCs
      ]
    }
  }

  statement {
    sid       = "Allow attachment of persistent resources"
    actions   = ["kms:CreateGrant"]
    resources = ["*"]

    principals {
      type = "AWS"
      identifiers = [
        "arn:aws:iam::${data.aws_caller_identity.current.account_id}:role/aws-service-role/autoscaling.amazonaws.com/AWSServiceRoleForAutoScaling_myenv", # required for the ASG to manage encrypted volumes for nodes
        module.eks.cluster_iam_role_arn,                                                                                # required for the cluster / persistentvolume-controller to create encrypted PVCs
      ]
    }

    condition {
      test     = "Bool"
      variable = "kms:GrantIsForAWSResource"
      values   = ["true"]
    }
  }
}

Which made the code move from the ebs key and created it, however when I looked at IAM I had both roles:
AWSServiceRoleForAutoScaling_npinfra and AWSServiceRoleForAutoScaling so it seems the module still tries to create the role, do you mean removed the code from a fork of the module or something else?
However, the apply now moves forward, the eks managed node group is failing, I was seeing a bunch of ec2 instances that were spun up but terminated and it took like 21 minutes until it failed:
Error: error waiting for EKS Node Group (wtw-mdp-npinfra-eks-cluster:eks-mycluster-nodes-20220302095107997600000008) to create: unexpected state 'CREATE_FAILED', wanted target 'ACTIVE'. last error: 2 errors occurred:

[2022-03-02T10:14:50.512Z] │ 	* eks-eks-mycluster-nodes-20220302095107997600000008-78bfa505-2f87-0b52-0ebc-d234bc416cf8: AsgInstanceLaunchFailures: Instance became unhealthy while waiting for instance to be in InService state. Termination Reason: Client.InternalError: Client error on launch

[2022-03-02T10:14:50.512Z] │ 	* i-007e452f1ac93f121, i-00f092689e4ceb6c9, i-01585c3d6882737ba, i-0270db681d2768120, i-02f0dbf02610ce368, i-05d816fa9b69bcbc0, i-0696c927eacd02903, i-06dac83a15ebc51bd, i-07285a2af85dba771, i-07d2b456d17d5a61b, i-091e2519263f85285, i-0d0e6eb7b6de95a31, i-0d8ecb4c9c7df3cb8, i-0f023298f2e513a47, i-0f55b41b692938ef7: NodeCreationFailure: Instances failed to join the kubernetes cluster

Which sounds similar to another github issues #1910
Maybe I will need to raise my own issue.

@nmofonseca You created your custom service-linked role (by specifying the suffix), but if you are using EKS-managed nodes (called "node groups" in terraform), there is no way to make them use your own custom role, they always use the role called AWSServiceRoleForAutoScaling. At least that was my experience some months back.
If you want to use your own role AWSServiceRoleForAutoScaling_myenc, you can do that by using custom node groups (called "worker groups" in terraform), because the worker group resource has an attribute where you can set your custom role.
It's a bit confusing because of the terminology but that's as best as I can explain the conclusions I reached. You can check my previous comments again, maybe it helps.

@mj3c  and does it work if I create the role AWSServiceRoleForAutoScaling manually, or using terraform before ruing the eks modules and kms code?
I will give it a try anyway :)
Thanks for taking your time and replying to me, much appreciated

@mj3c , yep if I create without the custom suffix the role first then everything seems to be working, thanks for pointing me in the right direction

@mj3c  and for everyone benefit I managed to create the role using terraform, just make sure It is created before the cluster and key.
Code snippet:
resource "aws_iam_service_linked_role" "autoscalingrole" {
  aws_service_name = "autoscaling.amazonaws.com"

  tags = merge(
    local.tags,
    {
      Name = "npinfra-eks-autoscaling-role"
    }
  )
}

This will create the service-linked role.
Cheers.

Just to be clear, this is not a module related issue and an issue due to the way AWS handles this role. If you have never created an ASG in your account, this default role will not exist - it only comes into existence if either:

You create it
You deploy an ASG which creates it

The problem then becomes an issue because some accounts may have the role, others do not, and its a mess. You can create this role in Terraform but if it already exists in an account, you'll have to skip it or import it.
The problem is further compounded by the EKS managed node group service because that service's API does not expose the ability to specify which service linked role to use.

Hello @bryantbiggs ,  once again thank you so much for clarifying and explaining and most of all taking time to do it.
I totally understand this is not related with the module itself and I should have made it clear on my previous comment.
For my use case, I will make it part of the account bootstrap to make sure it's there, but yes the strategy for ensuring the role is there is nothing the creators and maintainers of this module can do, I just wanted to share what I did for the next person that faces the issue like me.
I also understand is not really a solution more an workaround but hopefully will avoid others wasting a couple of hours 👍

no worries at all - when I see lots of activity on closed issues I try to put a summary since it means others are encountering the same issue and are coming back to these issues looking for potential solutions


Sensless default spec pattern

The default spec pattern is set to cypress/integration/**/*.spec.js (see MR).
This doesn't make any sense, since it will work neither with Luma nor with Hyvä.
The default value should be more useful.
Expected behavior
Ideally the matching integration tests are executed automatically, maybe by running a preflight check in cypress.config.js against the baseUrl and determining the theme.

I'm curious as to how you use this package then. Your test suite should contain either Hyvä tests or Luma tests, not both. When I start implementing this, I copy over the whole suite and then remove the tests I don't need, so in that case the pattern is correct.

We run the tests on a stock Hyvä theme, so we don't need to modify the tests at all.
I basically clone the repo, set the target URL in a variable, and run the tests.

The nice thing about the preflight check is it will enable the use of the unmodified testsuite against demo stores.

Ok I guess your situation is the odd one out since you're basically the only one that doesn't modify the store it runs against ;)
But there's no harm in adding the preflight check


Merges Master to Live. See commits for details.

Docs Build status updates of commit 245809f:
:clock10: Full build: the average full build time is 11 min(s) 47 sec(s), this is based on the last 1000 build(s) for this repository.

Docs Build status updates of commit 245809f:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

skype/skype-ps/skype/Get-CsAdPrincipal.md
:white_check_mark:Succeeded
View (skype-ps)

skype/skype-ps/skype/Get-CsVoicePolicy.md
:white_check_mark:Succeeded
View (skype-ps)

skype/skype-ps/skype/Install-CsDatabase.md
:white_check_mark:Succeeded
View (skype-ps)

skype/skype-ps/skype/Remove-CsOnlinePSTNGateway.md
:white_check_mark:Succeeded
View (skype-ps)

teams/teams-ps/teams/Add-TeamChannelUser.md
:white_check_mark:Succeeded
View (teams-ps)

teams/teams-ps/teams/Get-TeamChannel.md
:white_check_mark:Succeeded
View (teams-ps)

teams/teams-ps/teams/Get-TeamChannelUser.md
:white_check_mark:Succeeded
View (teams-ps)

teams/teams-ps/teams/New-TeamChannel.md
:white_check_mark:Succeeded
View (teams-ps)

teams/teams-ps/teams/Remove-TeamChannel.md
:white_check_mark:Succeeded
View (teams-ps)

teams/teams-ps/teams/Remove-TeamChannelUser.md
:white_check_mark:Succeeded
View (teams-ps)

teams/teams-ps/teams/Set-TeamChannel.md
:white_check_mark:Succeeded
View (teams-ps)

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.

Docs Build status updates of commit 39995c7:
:clock10: Full build: the average full build time is 11 min(s) 47 sec(s), this is based on the last 1000 build(s) for this repository.

Docs Build status updates of commit 39995c7:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

skype/skype-ps/skype/Get-CsAdPrincipal.md
:white_check_mark:Succeeded
View (skype-ps)

skype/skype-ps/skype/Get-CsVoicePolicy.md
:white_check_mark:Succeeded
View (skype-ps)

skype/skype-ps/skype/Install-CsDatabase.md
:white_check_mark:Succeeded
View (skype-ps)

skype/skype-ps/skype/Remove-CsOnlinePSTNGateway.md
:white_check_mark:Succeeded
View (skype-ps)

teams/teams-ps/teams/Add-TeamChannelUser.md
:white_check_mark:Succeeded
View (teams-ps)

teams/teams-ps/teams/Get-TeamChannel.md
:white_check_mark:Succeeded
View (teams-ps)

teams/teams-ps/teams/Get-TeamChannelUser.md
:white_check_mark:Succeeded
View (teams-ps)

teams/teams-ps/teams/New-TeamChannel.md
:white_check_mark:Succeeded
View (teams-ps)

teams/teams-ps/teams/Remove-TeamChannel.md
:white_check_mark:Succeeded
View (teams-ps)

teams/teams-ps/teams/Remove-TeamChannelUser.md
:white_check_mark:Succeeded
View (teams-ps)

teams/teams-ps/teams/Set-TeamChannel.md
:white_check_mark:Succeeded
View (teams-ps)

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.

Docs Build status updates of commit c555ef0:
:clock10: Full build: the average full build time is 11 min(s) 47 sec(s), this is based on the last 1000 build(s) for this repository.

Docs Build status updates of commit c555ef0:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

exchange/exchange-ps/exchange/organization/Set-OrganizationConfig.md
:white_check_mark:Succeeded
View (exchange-ps)

skype/skype-ps/skype/Get-CsAdPrincipal.md
:white_check_mark:Succeeded
View (skype-ps)

skype/skype-ps/skype/Get-CsVoicePolicy.md
:white_check_mark:Succeeded
View (skype-ps)

skype/skype-ps/skype/Install-CsDatabase.md
:white_check_mark:Succeeded
View (skype-ps)

skype/skype-ps/skype/Remove-CsOnlinePSTNGateway.md
:white_check_mark:Succeeded
View (skype-ps)

teams/teams-ps/teams/Add-TeamChannelUser.md
:white_check_mark:Succeeded
View (teams-ps)

teams/teams-ps/teams/Get-TeamChannel.md
:white_check_mark:Succeeded
View (teams-ps)

teams/teams-ps/teams/Get-TeamChannelUser.md
:white_check_mark:Succeeded
View (teams-ps)

teams/teams-ps/teams/New-TeamChannel.md
:white_check_mark:Succeeded
View (teams-ps)

teams/teams-ps/teams/Remove-TeamChannel.md
:white_check_mark:Succeeded
View (teams-ps)

teams/teams-ps/teams/Remove-TeamChannelUser.md
:white_check_mark:Succeeded
View (teams-ps)

teams/teams-ps/teams/Set-TeamChannel.md
:white_check_mark:Succeeded
View (teams-ps)

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.

Docs Build status updates of commit 8f50463:
:clock10: Full build: the average full build time is 11 min(s) 47 sec(s), this is based on the last 1000 build(s) for this repository.

Docs Build status updates of commit 8f50463:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

exchange/docs-conceptual/exchange-online/exchange-online-powershell-v2/exchange-online-powershell-v2.md
:white_check_mark:Succeeded
View (exchange-ps)

exchange/exchange-ps/exchange/organization/Set-OrganizationConfig.md
:white_check_mark:Succeeded
View (exchange-ps)

skype/skype-ps/skype/Get-CsAdPrincipal.md
:white_check_mark:Succeeded
View (skype-ps)

skype/skype-ps/skype/Get-CsVoicePolicy.md
:white_check_mark:Succeeded
View (skype-ps)

skype/skype-ps/skype/Install-CsDatabase.md
:white_check_mark:Succeeded
View (skype-ps)

skype/skype-ps/skype/Remove-CsOnlinePSTNGateway.md
:white_check_mark:Succeeded
View (skype-ps)

teams/teams-ps/teams/Add-TeamChannelUser.md
:white_check_mark:Succeeded
View (teams-ps)

teams/teams-ps/teams/Get-TeamChannel.md
:white_check_mark:Succeeded
View (teams-ps)

teams/teams-ps/teams/Get-TeamChannelUser.md
:white_check_mark:Succeeded
View (teams-ps)

teams/teams-ps/teams/New-TeamChannel.md
:white_check_mark:Succeeded
View (teams-ps)

teams/teams-ps/teams/Remove-TeamChannel.md
:white_check_mark:Succeeded
View (teams-ps)

teams/teams-ps/teams/Remove-TeamChannelUser.md
:white_check_mark:Succeeded
View (teams-ps)

teams/teams-ps/teams/Set-TeamChannel.md
:white_check_mark:Succeeded
View (teams-ps)

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.


Using Self with enum shows {unknown} type even in the simplest case.

vs

Yeah, seems like we don't handle Self properly. For patterns, I think the problem is here:
https://github.com/rust-analyzer/rust-analyzer/blob/62730ae30db453f53eb0c37647b5c76058eafca0/crates/ra_hir_ty/src/infer.rs#L441
Here, we want to resolve Self::This fully, without using type information.
For similar cases in expression context (let _ = Self(92) where Self is a tuple struct), the problem is similar:
https://github.com/rust-analyzer/rust-analyzer/blob/62730ae30db453f53eb0c37647b5c76058eafca0/crates/ra_hir_ty/src/infer/path.rs#L51
Here, resolve_path_in_value_ns does not understand that Self can be a value


⚠ PrivateHD has degraded performance

In a0644bf, PrivateHD ($PHD) experienced degraded performance:

HTTP code: 200
Response time: 1858 ms

Resolved: PrivateHD performance has improved in 2e09a71.


Two Bugs in VS Code 1.48.1  "Unable to open Extensions" AND "Can't install Extensions"

VSCode Version: 1.48.1
OS Version: Windows 10 Pro 2019

Steps to Reproduce:

Unable to open the documentation of any Extension
Can not install any Extension automatically and I must download it manually

Does this issue occur when all extensions are disabled?: Yes

Search here for "XHR failed" to find similar reports where the problems were caused by DNS issues.

Please follow these steps

Help -> Toggle Developer Tools -> Network
Then check for any network failed requests while browsing and installing the extensions if found all requests fails then its probably a proxy or DNS issue at your end.
To confirm its a DNS issue check if you can access this page https://ms-python.gallerycdn.vsassets.io/extensions/ms-python/python/2019.8.29288/1565127378610/Microsoft.VisualStudio.Services.Icons.Default, if you cannot please try configuring your DNS like pointing to <IP_ADDRESS> as suggested here? https://<IP_ADDRESS>/dns/. Otherwise please contact your network administrator.
If it is not a network issue, please share the logs from the following locations

Help -> Toggle Developer Tools -> Console
View -> Command Pallette... -> Toggle Shared Process -> Console
View -> Open View… -> Log (Shared)
View -> Open View… -> Log (Window)


Is it possible to pass query parameters? (:param or ?)

Hey, I'm trying to port a query from duckdb to datafusion using the Python connector, the issue I'm facing, is adding query parameters.
Is there currently a way that I can pass query parameters ?
import datafusion
import pyarrow.dataset as ds

dataset = ds.dataset(...)

ctx = datafusion.SessionContext()
ctx.register_dataset('dataset', dataset)
table = ctx.sql("SELECT * FROM dataset WHERE col BETWEEN ? AND ?", parameters=[1, 10]).to_arrow_table()
## TypeError: SessionContext.sql() got an unexpected keyword argument 'parameters'

Yea, parameterized queries would be awesome, especially syntax like this:
ctx.sql(
    "select country, count(*) as num_ppl from {person_df} group by country",
    person_df=person_df,
).show()

I don't fully understand what is needed here. Can you not just do
ctx.sql(
    f"select country, count(*) as num_ppl from {person_df} group by country"
).show()

@timsaucer - In this example, person_df is a DataFrame object, not a table name.  This saves the user from having to register the table (the engine just does this under the hood).  It was recently added to Spark and is a surprisingly nice dev quality of life improvement!

Oh, interesting. As a pure dataframe user, I hadn't understood the request. I appreciate the clarification!

Parametrized queries are even more important for when you want to do: WHERE col IN big_list_of_values.
A year later, I again need to choose a library for reading parquet files, but I had to settle with ducks because data fusion doesn't support this

I just tried a quick proof of concept. To get this to work, I did need a name for the table. Would the following be an acceptable solution?
from datafusion import SessionContext
ctx = SessionContext()
ctx.register_parquet("customers", "examples/tpch/data/customer.parquet")
ctx.sql("select c_custkey, c_name from {df}", df=df_customer)

I think that if we change all of the read_x like read_parquet over to call register_x and auto generate a table name, then we can support removing the register line and make this work. I tested with parquet with success.


ENH: Add Travis CI for Building and Deployment (TESTING)

This PR will add Travis CI compilation and deployment.
This is a TESTING branch with TRAVIS at this stage. Given the length of time it takes to build - we are testing if _build can be cached and restored for each PR to sync changes only.

[x] get make jupyter compiling
[ ] see if make website will complete (or timeout)
[ ] add cached results of _build for make website and see if can restore before make website is run to get changed files only building
[ ] get s3 deployment setup with encrypted AWS keys

[ ] see if this is useful: https://github.com/Syntaf/travis-sphinx

[ ] requested further advice from travis on the issue. The initial run to generate a cache of files is timing out beyond the max limit for travis and there is no mechanism to upload a cache so have requested advice from travis.

Update
the cache didn't seem to preserve the sphinx-cache so it is running all files. Will do some more local testing before trying again to preserve the state of sphinx repo between travis builds.

Update: The cache is still not working on sphinx as all 117 lectures keep wanting to compile for every run despite the doctrees being populated.

This is hard to debug. Another strategy would be to:

track changed files and trigger a sphinx-build on the specific rst files that have changed
sync those results to preview site using encrypted s3 credentials.

Update: this setup works for compiling changed rst files.

[ ] need to update preview-lectures s3 bucket to support master and pr# folders
[ ] setup encyrpted deploy credentials

Perhaps the best approach is to use aws cli to:

create new bucket: aws s3 mb s3://pr524-lecture-source-py/
set the bucket to serve a website: aws s3 website s3://pr524-lecture-source-py/ --index-document index.html --error-document error.html
deploy to bucket: aws s3 sync . s3://pr524-lecture-source-py/

This is a useful reference: https://rubyplus.com/articles/5271-Deploying-Frontend-App-to-Amazon-S3-using-AWS-CLI

This might be useful for writing a comment on the PR (after successful run on travis) with link to s3 bucket to preview resulting html

[ ] @arnavs to provide some info re: writing from travis to pr comments.

[ ] Setup a PR for adding coverage tests as a preliminary travis tool to verify code in each submission.


feat: allow running without spotify

Closes #835
This PR allows muse to run without a Spotify client ID and secret.
The command will responde with 🚫 ope: spotify not enabled if a user tries to query a song with a Spotify URL.
Logic changes
To allow for cases where Spotify isn't available two methods required changes.
addToQueue(): The logic for determining which source to fetch songs from has been moved to the getSongs service class in get-songs.ts.  Songs are fetched through a single method named getSongs() which include the old logic from addToQueue(), all other methods in the class has been made private.
getYouTubeAndSpotifySuggestionsFor(): Has been refactored, all Spotify logic has been moved to the end of the method (fetching still happens asynchrony at the beginning).
PR also updates YoutubeAPI.search() method to return an empty array if no match is found for the search query. This allows for better error handling other places in the code.

[ ] I updated the changelog

:package: :robot: A new release has been made for this pull request.
To play around with this PR, pull ghcr.io/museofficial/muse:pr-1092.
Images are available for x86_64 and ARM64.

Latest commit: dff5d56085dd1eca59d189af13f9b22b57c8a165

@sofushn Thanks for the PR, it currently lgtm. But to confirm something, this does still display the spotify query in the search function. Even if spotify is disabled?

Thanks for the PR, it currently lgtm. But to confirm something, this does still display the spotify query in the search function. Even if spotify is disabled?

It's quite a long time since I wrote this PR, if I remember correctly I just show an error to the user if they try to search with a Spotify URL otherwise the whole Spotify part is ignored.

No worries @sofushn, I was just given access to this repo. I am going through everything to check what has been updated. What still needs to be done and so on and so forth.

For reference this is how the query result looks (fixed the Spotify URL prompt)

Ah thanks, that's what I had to know. Will test this later today.

🚀 Released in Release v2.10.0.


Use .net LTS for C# and only use .net 8 for python builds

The .net 8 preview is causing some issues due to level of support when onboarding developers that only work with C# codebase. Given we only use .net 8 features (Native AOT) for python, this should not be an issue.
Suggestion is to use LTS for C#, and only use .net 8 for the N-AOT builds for now.

This will be done in 0.6.0. The branch where this can be looked at is https://github.com/quixio/quix-streams/tree/feature/refactor-unabstract

We moved C# to https://github.com/quixio/quix-streams-dotnet


How to request result data

hey,
I have now already tried a few things but somehow I do not get the results of result combinations or load case combinations or loadcase.
Could you ggfs give me some help?
the autocompletion to "Result" or something like that was not helpful until now.
greetings

Hey @talSas,
we do not yet have a possibility to get results directly via WebService. We can export them to xml or csv files with following methods in model interface:
// export of detailed results
public void export_result_tables_with_detailed_members_results_to_csv(string target_directory_path);
public void export_result_tables_with_detailed_members_results_to_xml(string target_file_path);
// export of results
public void export_result_tables_to_xml(string target_file_path);
public void export_result_tables_to_csv(string target_directory_path);

The results is in amount of date exported. With these functions, all results for all load cases, combinations, addons are exported.
An example how to use these functions is in application is in Cantilever example
  model.export_result_tables_with_detailed_members_results_to_xml(CurrentDirectory + @"\Test.xml");

                string XMLFile = File.ReadAllText(CurrentDirectory + @"\Test.xml");
                XDocument doc = XDocument.Parse(XMLFile);

                foreach (XElement loadcase in doc.Descendants("load_case"))
                {

                    if (loadcase.Element("no").Value == "1")
                    {
                        Console.WriteLine("My internal forces from LC 1");
                        var internalForces = loadcase.Descendants("E_MODEL_MEMBERS_INTERNAL_FORCES");
                        var internalForcesItems = internalForces.Descendants("item");
                        foreach (var item in internalForcesItems)
                        {
                            string My = item.Element("internal_force_my").Value.ToString();
                            Console.WriteLine(My);
                        }

                    }
                }

We have access to results via direct WebService operations in our backlog.

hey @jarabroz,
thanks for your detailed explanation,
do you already have a plan for when the receipt of the results directly via the web service is possible?
But with this workaround you can work for now.
regards

Okay as I see and understand it now it is just possible to get all or no results via export. Is it ggfs. these before the export already to sort and select.
If I need e.g. only the results of rc1001 it is inefficient to export everything.

+1 from my point of view, could you please add reading results directly via web service

Hey @ZTThomasOberthanner,
I have some similar problems as You with getting results.
I prepared the .dll witch provided Dictionary with objects of internal forces, maybe you will find there samthing for you.
Link: https://github.com/LakuszJ/JoCalc_Dlubal_Concrete_Column
This .dll  create, Dictionary<int, Dictionary<int, List<InternalForcesMemberSingleItem>>>
Whre first <TKey> is number of the member at RFEM current model, second <TKey> is number of the combination. After that you will get List<InternalForcesMemberSingleItem>.
Examble:
CSVEditorAndForceGenerator fg = new CSVEditorAndForceGenerator(openAndReadModel.gIARM);
Dictionary<int, Dictionary<int, List<InternalForcesMemberSingleItem>>> dicMCF = fg.GenereteDicOfForcesForAllMembers();
List<InternalForcesMemberSingleItem> listOfForces_3_2 = dicMCF[3][2];

as above you will get  'List' for member no 3 and combination no 2.
Finally you will get InternalFocesMemberSinlgeItem with all necesery forces and .json file as on screen bellow.
PS. Problem with different UI language is solved by provide ResourceManager with translations by `Strings.de-DE.resx' and another.
PS2. "speccyficcationJC" it is value from comment box for member at RFEM, I will use it as some substitute of selection to filter members.
PS3. This library getting only Combination do You have to create it before use, i don't need single load results.

Thanks for your work! I will have a look at it :-)

@LakuszJ Thank you for your work. Do you think that it would be useful for other to add your tool into our project? We could put it to the separated namespace and class. We give you full credits in our List of Contributors.
We are also working on the WebService operations for getting results directly without necessity to export it to files. It is based on the result tables which you know from application. We are close to release it for analysis results. Our desire is to continue with results for Design Addons

#27 WS operations for results are released

Thank You @jarabroz , very nice improvement !
My code need some rebuild but I'm really glad.


cookies

is there anyway we can disable cookie preservation on locust file?

Yes, the client uses requests by default. Have a look at: http://stackoverflow.com/questions/17037668/how-to-disable-cookie-handling-with-the-python-requests-library


.github/workflows: pin renovate version

To avoid unwanted breakages from renovate, we should also pin renovate version and let it be updated on a weekly basis like the other dependencies.
Tested in https://github.com/aanm/cilium/pull/662

/test


Fix swagger redirect #177

Redirect requests to /swagger-ui to /q/swagger-ui
Checklist

[ ] You added tests to cover the change
[ ] mvn clean install build and test completes
[ ] You changed or added to the documentation

Codecov Report

Merging #178 (670e40f) into main (a00ff86) will decrease coverage by 0.10%.
The diff coverage is 0.00%.

@@             Coverage Diff              @@
##               main     #178      +/-   ##
============================================
- Coverage     64.79%   64.68%   -0.11%
  Complexity      199      199
============================================
  Files           113      114       +1
  Lines          3042     3047       +5
  Branches        446      446
============================================
  Hits           1971     1971
- Misses          851      856       +5
  Partials        220      220

Impacted Files
Coverage Δ

...n/net/adoptopenjdk/api/v3/routes/SwaggerUiRoute.kt
0.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a00ff86...670e40f. Read the comment docs.