Add specialized JS-interop method calls

In Flutter we see quite a bit of overhead in JS-interop method calls when using JsObject.callMethod. Currently on our CanvasKit rendering backend the call overhead can reach up to 80% of the total time it takes to do all the rendering work in our paint phase.
Here's a sample profile (notice the blue gaps of activity in between the yellow/green of useful work):

Here's a zoom in into a sequence of value conversions that are happening:

As you can see there are a lot of conversions happening, particularly around wrapping and unwrapping argument lists, and unwrapping return values.
In most cases we know exactly the method we call and the number of arguments we pass, so there's no need to wrap arguments in a list. In many cases there is no return value (void) and so there is no need to wrap it.
Proposal
Add specialized callMethodX and callVoidX methods to JsObject with the following signatures:
dynamic callMethod0(method);
dynamic callMethod1(method, arg1);
dynamic callMethod2(method, arg1, arg2);
dynamic callMethod3(method, arg1, arg2, arg3);
dynamic callMethod4(method, arg1, arg2, arg3, arg4);
...
dynamic callMethod20(method, arg1, arg2, arg3, arg4);

void callVoid0(method);
void callVoid1(method, arg1);
void callVoid2(method, arg1, arg2);
void callVoid3(method, arg1, arg2, arg3);
void callVoid4(method, arg1, arg2, arg3, arg4);
...
void callVoid20(method, arg1, arg2, arg3, arg4);

These methods should all be efficient and inlineable.
Examples of Flutter engine code that does a lot of JS interop:

https://github.com/flutter/engine/blob/master/lib/web_ui/lib/src/engine/compositor/path.dart
https://github.com/flutter/engine/blob/master/lib/web_ui/lib/src/engine/compositor/canvas.dart

/cc @sigmundch @rakudrama @jakemac53 @natebosch @jonahwilliams

I wonder if we could use a type parameter to combine callMethodX and callVoidX for example:
T callMethodX<T>(String name, dynamic arg1, ..., dynamic argX);

On an offline discussion @jakemac53 was suggesting to do a kernel transformer to make this more transparent. We'd add all the methods above, but a transformer would convert
callMethod(name, [1, 2, 3]);
var y = callMethod(name, [1, 2])

into
callVoid3(name, 1, 2, 3);
var y = callMethod2(name, 1, 2);

Because at the kernel level we can generate code accessing private members, we could in fact add all these methods as private members instead. This would mean that our changes would not be visible and it would be possible to change it again in the future without a breaking change if we are not satisfied with it.

I wonder if we could use a type parameter to combine callMethodX and callVoidX

I'm not sure. The effect I'm looking for is that we do not call _convertToDart. Can a type parameter do that?

I'm not sure. The effect I'm looking for is that we do not call _convertToDart. Can a type parameter do that?

I'm am not saying I like this, but one could do:
  return T == Null ? r :  _convertToDart(r);

The decision is made at runtime at that point.

At that point we might as well add a named parameter to indicate whether you want the return value converted :)

Adding a <T> could be helpful in terms of more eager casting into the expected type, and it allows void to express no return value.

Adding a  could be helpful in terms of more eager casting into the expected type, and it allows void to express no return value.

unfortunately, I believe we can't use void in an expression (e.g.  T == void)

ya it would require some compiler magic

Adding callMethod2 and friends would be a reasonable way to avoid processing the arguments via a List. It would not avoid calls to _convertToJs to convert the arguments.
I would be careful relying on Type.==. The latest nnbd spec requires some form of type canonicalization before comparison (to avoid unusable behaviour across opt-in/legacy). We can make it faster than walking the type tree, but it is not a simple operation.
Do we need all the features of JsObject? It is a wrapper, along with JsFunction and JsArray. There is support for 'proxy' wrappers to insulate JavaScript from 'seeing' the Dart representation of objects. If this is unnecessary, I think we can do much better via the more declarative @JS() annotation, where the methods may be declared with types, and would avoid wrapping the JavaScript objects, avoid wrapping the Dart pass-through objects, and have no calls to _convertToJs and _convertToDart.

I too would prefer we go down the route of making it possible to use @JS from dart:ui.
The minimum change here would be to move  @JS to a dart:* package so it can be used from within dart:ui, and reexport it in package:js. Separately, we'd like to do a better job inlining the js-interop calls in dart2js, but that's not required (what we have today would be already a lot better than what you have via the JsObject APIs.)
@yjbanov - do @JS annotations work in your case? If for example the APIs you called via JsObject also exposed from the dart:html (e.g. CanvasElement/RenderContext2D), then @JS might not work out of the box and we'd need some compiler changes to support it.

@hterkelsen just checked, and @JS seems to produce the best output we could hope for, better than my original proposal in this issue (e.g. it bypasses Function.prototype.apply entirely and just calls the method). We can verify how well this works as soon as it lands.

We can verify how well this works as soon as it lands.

Can it actually land in our current state of affairs? That is, @JS cannot be used within the SDK today, so if there are scripts that convert package:web_ui to dart:ui, you will run into trouble at this time.

I think the proposal was to create a dart:_js which defined the annotation and re-exported it for package:js? Or something similar.
Then we could rewrite the package:js usage when creating the SDK.

Yes - I just misunderstood @yjbanov message and thought he was implying that you were planning on landing it before we do the work to move things into the dart:_package_js library.

Sorry for the confusion. What I meant was we're poised to adopt this new feature as soon as it's available. Currently JS interop is the single biggest performance killer for our WASM backend.
We're basically just sitting and refreshing this page waiting for the status of this issue to go from open to fixed :smiley:

BTW, the more I look at our profiles the more I'm convinced that moving @JS under dart:* is the right solution. I just discovered that JsObject.jsify can be outrageously slow too. For example, calling the following seemingly primitive makeSkRRect function can take >1ms on a Xeon workstation:
js.JsObject makeSkRect(ui.Rect rect) {
  return js.JsObject(canvasKit['LTRBRect'],
      <double>[rect.left, rect.top, rect.right, rect.bottom]);
}

js.JsObject makeSkRRect(ui.RRect rrect) {
  return js.JsObject.jsify({
    'rect': makeSkRect(rrect.outerRect),
    'rx1': rrect.tlRadiusX,
    'ry1': rrect.tlRadiusY,
    'rx2': rrect.trRadiusX,
    'ry2': rrect.trRadiusY,
    'rx3': rrect.brRadiusX,
    'ry3': rrect.brRadiusY,
    'rx4': rrect.blRadiusX,
    'ry4': rrect.blRadiusY,
  });
}

Profile:

@sigmundch @rakudrama @natebosch -
(1) Would moving package:js to dart:_js and re-exporting in package:js work?  Any problems you can think of?
(2) We'd need to modify DDC and Dart2JS to special case dart:_js.  I don't think this would be hard in the DDC case.  Dart2JS?

Any problems you can think of?

If we decide to not break existing JS interop, and we we decide that the future of JS interop looks slightly different then moving it now will add technical debt that we need to live with until Dart 3. In any place we need to understand  the presence of an @JS annotation we will need to consider whether it is either the one from package:js or dart:_js.
If the exported version of the annotation becomes our golden path, we risk breaking old usages if we forget to check for both sources somewhere. We won't have test coverage of the old package:js versions in google3.

(1) Would moving package:js to dart:_js and re-exporting in package:js work?

Yes, I don't see any reason we couldn't make it work.
As long as we keep the dart:_package_js*1 private, we can move it back to package:js in the future without ever exposing it as a breaking change.
@natebosch is correct that we'll have some tax to lookup either annotation to preserve the backward compatibility with the old package:js, but I feel that's a small price to pay.
*1 note: there is a different dart:_js today, so we would have to decide whether to use that or a different name :)

If the exported version of the annotation becomes our golden path, we risk breaking old usages if we forget to check for both sources somewhere. We won't have test coverage of the old package:js versions in google3.

True, we could invest in adding a way to test in the sdk some code with the old package:js (using an old pinned copy)
I imagine the new package:js could be a patch release with an sdk constraint, so that users can easily move to the new version.

(2) We'd need to modify DDC and Dart2JS to special case dart:_js. I don't think this would be hard in the DDC case. Dart2JS?

Same - I don't expect this to be a hard change.

(1) Would moving package:js to dart:_js and re-exporting in package:js work?
*1 note: there is a different dart:_js today, so we would have to decide whether to use that or a different name :)

I've always been bad with names.  :-)

(2) We'd need to modify DDC and Dart2JS to special case dart:_js. I don't think this would be hard in the DDC case. Dart2JS?

Same - I don't expect this to be a hard change.

For DDC, it may suffice to just add an additional test for dart:_package_js here:
https://github.com/dart-lang/sdk/blob/master/pkg/dev_compiler/lib/src/kernel/js_interop.dart#L14

quick follow up - in a design discussion today we made a determination:  rather than reexporting them from package:js, we prefer to start by duplicating the package:js annotations inside a dart:_js_annotations library.
The compiler work to support both annotations is needed regardless to be backwards compatible, but creating a second copy makes it easier to be future compatible and avoid a breaking change until we decide what the future of package:js will be.

Thanks for the follow-up. Will the duplicate annotations' API surface and semantics be identical to that of package:js? Because we currently exist both as a package:ui and dart:ui what we plan to do is use package:js in package:ui and dart:_js_annotations in dart:ui. Will that work?

Yes, that's would be the goal - Since the library is private, for a long time you'll be the only user of those annotations (from dart:ui), so we'll make sure it works for you :)

@sigmundch @natebosch @rakudrama - can we list the breaking changes we are considering?  E.g., support for dynamic dispatch, extending JS, implementing JS, etc.

Thanks for the reminder @vsmenon
We are planning changes for js-interop in the next few months. We still have to iron out the design, so we don't plan to enforce any new checks at this time. However, it would be great if any uses you have in dart:ui/package:web_ui follows this guideline:

no is: don't use is checks on JS-interop types, it is ok to use as casts though.
all anonymous: consider always using @anonymous for any js-interop class. This is a bit safer because today DDC supports is checks on non-annonymous classes, but dart2js doesn't. In the future we may drop all support for is checks in DDC as well.
no dynamic invocation: avoid dynamic calls of js-interop members. To do so, ensure the receiver of those calls is typed properly. In the future we may require all js-interop calls to be known statically.
no subtypes: Do not implement a js-interop type with a Dart class (e.g. no mocks) and only extend js-interop types with other js-interop types. In the future we may seal js-interop types and not allow extending or implementing them from Dart.

Those restrictions look fine to me.
What's the difference between the "no is" and "all anonymous" restrictions?

Almost no practical difference, but we may be removing bits that affect each one separately.
non-anonymous js-interop classes expose a constructor name to dart, both dart2js and ddc use it to construct the instances, and only ddc uses it for is checks. Avoiding them will make it easier to ensure that you are under the same semantics in ddc and dart2js today. We haven't decided whether we intend to keep the constructor capability in the future.
For is checks, anonymous js-interop classes have a funny property that they will say true if you ask is Foo for any other anonymous type (and this is also the case for non-anonymous classes in dart2js). I'm guessing in the future we'll try to statically detect those is checks and possibly require that you don't use them (use is JavaScriptObject instead or something general that includes all js-interop types).

Closing this as @JS has been implemented. However, I filed https://github.com/dart-lang/sdk/issues/42522 to improve the performance of @JS annotation (it is 7x slower than it could be).


Update example configuration snippet in kafka.rb

The example configuration snippet is wrong according to the documentation below it.
If topic is the only required setting, it should be contained in the configuration example.

Jenkins standing by to test this. If you aren't a maintainer, you can ignore this comment. Someone with commit access, please review this and clear it for Jenkins to run; then  say 'jenkins, test it'.

Can you update the example in https://github.com/logstash-plugins/logstash-output-kafka/blob/master/DEVELOPER.md?
Also you need to sign the CLA for the PR to be accepted. https://www.elastic.co/contributor-agreement/

Hey,
thanks for the heads-up.
I signed the agreement and i updated DEVELOPER.md
On Thu, Feb 4, 2016 at 2:21 PM, Joseph Lawson<EMAIL_ADDRESS>wrote:

Can you update the example in
https://github.com/logstash-plugins/logstash-output-kafka/blob/master/DEVELOPER.md
?
Also you need to sign the CLA for the PR to be accepted.
https://www.elastic.co/contributor-agreement/
—
Reply to this email directly or view it on GitHub
https://github.com/logstash-plugins/logstash-output-kafka/pull/39#issuecomment-179829578
.


Remove obsolete defer-plugin-errors flag

This flag is obsolete and replaced by the defer-errors flag

As this is a user-facing change I'd expect it to be reflected in the changelog.


Feat/hash devaluation to division

Description
Changed the hash devaluation factor from a multiplication to be division, because that felt more intuitive.
Fixed to18Decimals bug where it didn't work for numbers with more than 3 decimals. The function now takes a string!!!
Type of change
Please delete options that are not relevant.

[x] Bug fix (non-breaking change which fixes an issue)
[x] New feature (non-breaking change which adds functionality)

How Has This Been Tested?
to18Decimals has been tested by my eyes.
But for real, I don't know a proper way to test this without manual checking. There might be a way to actually verify it?
hash devaluation factor has been tested through Test_SearchSECORewarding

lol


SelfHost error

Just added swagger to my self hosted owin webapi.
Docs endpoint works, I've this issue with swagger-ui.

Technically, this looks to be an issue with the swagger-ui as opposed to Swashbuckle. Although, it could be something wrong with the SB generated Swagger that's causing it.
If you have access to the raw docs, could you provide the Swagger description for the schema above so I can try repro?

gist here: https://gist.github.com/andreabalducci/921c3eb1a8d450049acd

Ehhhh - that's a lot of data. Any chance you could narrow it down to the culprit Schema by inspecting in your JS console?

Closing due to inactivity.
Feel free to re-open. If you can narrow it down to the culprit schema via your JS console, then I'd be happy to investigate further.

we are working on opensourcing all the stuff, investigation on this issue has been posponed by few weeks.


KAFKA-2063: Bound fetch response size (KIP-74)

@nepal, can you please take a look and merge to your branch if you're happy? A summary of what I have done:

Refactor constructors for a.k.c.r.FetchRequest and introduce factory methods
Add missing cases in FetchRequest.getErrorResponse and fix equality bug
Implement round-robin for Fetcher and *FetcherThread classes
Flesh out tests in RequestResponseTest
Various compatibility and ordering changes to fetch request/response classes
Use Seq instead of Map in ReplicaManager and improve handling of large messages

Not sure why GitHub seems to think that there are merge conflicts as I only added commits to your branch. Let me know if you have issues merging or if you won't have time to do it. I will create a separate PR in that case.

Maybe this happened after I did ‘git pull —rebase’ from kafka trunk.
Can you please do the same from my branch?

@nepal done

@nepal I added a few more clean-ups based on review comments. I will now work on adding tests, fixing TODOs/FIXMEs and any other clean-ups. I'll do a separate PR for those. It would be great to get this merged so that Jun and Jason can review it once they come online (they're in the west coast of the US).

@nepal Fixed a compilation issue in what was the second last commit and fixed the batching/grouping in FetchResponse. I noticed that you approved the PR, but didn't merge it. Was that intentional?


Minor corrections

Fixed the application type and added code for TableOperation Create, Retrieve and Delete

@arramac - Please review the proposed changes.  Thanks

Emailed @arramac again.

#sign-off

thanks @philpursglove !


Code release

Hello. Your paper is absolutely amazing! When should we expect the code release to have a go?
Thank you :)

Hello,
Thanks for your interest in our work. Due to regulations of Tencent, I cannot release the code at this stage.
I will release the code as soon as possible.
xiaoxiao


RFM - https://chocolatey.org/packages/wget

Needs a new maintainer. The software vendor does want the software embedded and the GPL license allows for that.
https://www.reddit.com/r/sysadmin/comments/5g5npg/fosshub_message_for_chocolatey_please_stop_with/dapou3d/

I'll take this on. I'll submit a package shortly.

w00t

This issue can be closed. Package with embedded zips has been approved. https://chocolatey.org/packages/Wget


[WIP] Add quickstart for Configuration API

Signed-off-by: Sarthak Sharma<EMAIL_ADDRESS>Description
Adding a quickstart section for configuration building block.
Issue reference
We strive to have all PRs being opened based on an issue, where the problem or feature have been discussed prior to implementation.
Please reference the issue this PR will close: #_[issue number]_https://github.com/dapr/quickstarts/issues/554
Checklist
Please make sure you've completed the relevant tasks for this PR, out of the following list:

[ ] The quickstart code compiles correctly
[ ] You've tested new builds of the quickstart if you changed quickstart code
[ ] You've updated the quickstart's README if necessary
[ ] If you have changed the steps for a quickstart be sure that you have updated the automated validation accordingly. All of our quickstarts have annotations that allow them to be executed automatically as code. For more information see mechanical-markdown. For user guide with examples see Examples.

Please add changes to the github workflows as well.

Can we also maintain the consistency of having order-processor service in config API as well. We have order-processor and checkout service defined in all our examples. And we store orderId in all our samples. You can refer to state management examples. You can follow the similar samples for this as well.
https://github.com/dapr/quickstarts/blob/master/state_management/go/http/order-processor/app.go
https://github.com/dapr/quickstarts/blob/master/state_management/go/sdk/order-processor/app.go

Should the order-processor be renamed as config-processor and order-updater be renamed as config-updater?

@mukundansundar
I had earlier kept it as config-updater and config-subscriber, but the folder names was changed to maintain consistency across all quickstarts. See the comment at the beginning by @amulyavarote

Hi! The PR looks great. Thanks for making the examples consistent. We have java examples missing in this PR. Do we have a separate PR for Java examples?

I approved the existing examples for now.

Hi! The PR looks great. Thanks for making the examples consistent. We have java examples missing in this PR. Do we have a separate PR for Java examples?

Hi @amulyavarote, I was waiting for a new release of Java SDK, I have added examples for Java now.

Let's wait for the workflows to succeed.

Overall, the PR looks good! Thanks for the contribution here.

Let's wait for the workflows to succeed.

@amulyavarote Validation passed on Ubuntu but is failing on MacOS, Looks like mechanical-markdown is having issues on MacOS 11 image, I am reverting MacOS runner image version for now, will open a new issue for this.

@paulyuk Can you review this PR?

Changes look good to me. Just the workflows need to pass.

Some workflows are timing out due to the unreliable nature of installing Docker on MacOS through the github action docker-practice/actions-setup-docker@v1. However, the tests themselves are valid since they are passing whenever the docker setup is successful over multiple runs. I have created an issue for this https://github.com/dapr/quickstarts/issues/755

Some workflows are timing out due to the unreliable nature of installing Docker on MacOS through the github action docker-practice/actions-setup-docker@v1. This action is being used for all workflows. The tests themselves are valid since they are passing whenever the docker setup is successful over multiple runs. I have created an issue for this #755
Successful run for configuration api workflow https://github.com/dapr/quickstarts/actions/runs/3538439711

I think here also we can move to Podman in case of macos. See how it is done in dapr/cli today.

Do we know as to why this is failing? https://github.com/dapr/quickstarts/actions/runs/3538439693/jobs/6107538083 @sarsharma ?

Do we know as to why this is failing? https://github.com/dapr/quickstarts/actions/runs/3538439693/jobs/6107538083 @sarsharma ?

Looks like hello-kubernetes tutorial stdout is not matching in sequential order.
Created an issue https://github.com/dapr/components-contrib/issues/2357, will take a look

Validate Tutorials has been bad for a month and is likely from #737 and not this.  I'll merge.


snapshots/aufs: plugin not reporting correct platform

AUFS is limited to linux and is not being reported correctly via the plugins command:
~/g/s/g/c/containerd ❯❯❯ sudo ctr plugins type~=snapshot                                                                                master ✭ ✱ ◼
TYPE                            ID           PLATFORMS      STATUS
io.containerd.snapshotter.v1    btrfs        linux/amd64    error
io.containerd.snapshotter.v1    aufs         -              ok
io.containerd.snapshotter.v1    naive        linux/amd64    ok
io.containerd.snapshotter.v1    overlayfs    linux/amd64    ok
io.containerd.snapshotter.v1    zfs          -              error

Note that zfs is also affected. #2253 addresses this.


Update 01-setting-up-prisma-existing-database-a003.mdx

Remove speech marks ' around __YOUR_POSTGRES_PORT__ because it suggests that the port value should be enclosed in single quotes.

 Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.


Redhat RSA FIPS patches

This PR brings a set of Red Hat RSA-specific FIPS-related patches upstream.
Original patches were implemented mostly by @neverpanic and @beldmit
Checklist

[ ] documentation is added or updated
[ ] tests are added or updated

OTC: which patches of this subset are desired?
I am going to fix the tests after we agree on which is acceptable.

Current state of review:

Check allowed lengths, forbid RSA KEX in TLS in FIPS mode

The length check is not accepted (@paulidale, @slontis), the TLS part is not reviewed.

Forbid some RSA padding modes in FIPS provider

Looks like the length check for decrypt is for 1024 bits.
The padding checks are absent upstream.

Remove X9.31 support from FIPS provider

No review yet

Forbid SHAKE with RSA in FIPS mode

Presumably acceptable after moving the check to a separate function

Check allowed lengths of RSA keys in RSA KEM implementation

The check in encapsulation is redundant, in decapsulation 1024 bits (as with decryption).

Length checks (thanks @neverpanic )
The 1024 signature verification is explicitly permitted by SP 800-131Ar2 section 3, table 2. Key Agreement is handled in section 6, where table 5 disallows everything < 2048 bits. This also makes sense because Key Agreement is synchronous, while you may be verifying signatures made years ago.
So it's not just our understanding, it's explicitly specified in SP 800-131Ar2, which is the "Transition" document. That one is always a good source for specific key length limitations.
There's also this sentence which confirms there are no different limits for encryption and decryption: "In the case of key-transport keys (i.e., the keys used to encrypt other keys for transport), this document (SP 800-131A) applies to both the encryption and decryption of the transported keys."

For a lot of these, we would have to guard the implementation using a flag as we've done for other FIPS restrictions that had to be introduced (EMS, DRBG non-truncated digests).
X9.31 would definitely fall into this category.  One could argue the SHAKE change could be done without since it's highly unlikely to be used anywhere (however the same was true of truncated digests with DRBGs).

Quoting the OTC discussion:

Updates to include various length checks and other misc updates.
Needs some updates for style and to remove things which are unacceptable.

We would like all of the fixes eventually.

This PR is in a state where it requires action by @openssl/otc but the last update was 30 days ago

This PR is in a state where it requires action by @openssl/otc but the last update was 61 days ago

This PR is in a state where it requires action by @openssl/otc but the last update was 30 days ago

This PR is in a state where it requires action by @openssl/otc but the last update was 61 days ago

This PR is in a state where it requires action by @openssl/otc but the last update was 92 days ago

This PR is in a state where it requires action by @openssl/otc but the last update was 123 days ago

This PR is in a state where it requires action by @openssl/otc but the last update was 154 days ago

This PR is in a state where it requires action by @openssl/otc but the last update was 185 days ago

This PR is in a state where it requires action by @openssl/otc but the last update was 216 days ago

No reason to keep it open, upstream is implementing changes their own way


update box log template

Purpose
Fix the problem that box addon log are not displaying. Close https://github.com/CenterForOpenScience/osf.io/issues/3233.
Changes
Before:

After:

First pass complete - no changes requested. :)
:fish_cake:

@chennan47 I was not able to reproduce this locally--can you describe how to reproduce this and why this patch fixes it?

This is a bug happening on production right now. You can check out the log on https://osf.io/vtpwx/. I believe there is a change on waterbulter side on the metadata form return for box addon to make it consistent with the other addon. However this needs an update on OSF log template to make it work.


adds additional patterns request_header and mobile_header to tracking…

… field regular expression. extracts tracking field pattern check to utils

Coverage remained the same at 0.0% when pulling 4b75031bdfb59fe843ab59db2f89e61fe5e7ab41 on theseyi:tracking-header into 244628f09dd1653d1d45f764e6eb771f82d95de6 on linkedin:linkedin.


Which components/scripts are strictly necessary?

Hi, I recently discovered this project and it looks amazing.
I am looking to design a website from scratch and use this project in my implementation of it.
I was wondering if someone could quickly give me a "shortcut" and tell me which of the files (components and scripts) are strictly necessary for the editor and site to function, and which are safe to delete. I am already familiar with SvelteKit so I know I can delete most of the directories in src/routes/ if necessary (assuming not api and assets).
I think the technique of using an example project as documentation is unique and useful, seeing as you can see the code in-use and make changes to it, however it can make it harder to get started quickly.

Hey, the answer is, it depends. :) If you don't use images for instance you could drop all the assets related parts.
I'd recommend you to start with a fresh SvelteKit project and just migrate over the code you need. This way it will stay the most minimal for your usecase and you'll learn a lot. :)

Yep thanks :D
I was going through the code manually and figured out what I need, but I kept this issue up for future reference.

It's a valid question. Let's keep the issue open, until we have a solid answer for it and include it in the README. :)

If you like/it would be helpful, I could start writing some preliminary docs or put together some type of init command to scaffold a barebones project? Of course nothing official, unless you approved it.
Unless you wanted to keep the philosophy of having people learn for themselves, which is also fine :D


Does hasDrawable method work for AppCompatImageView?

Hello, guys!
I try to check AppCompatImageView with method hasDrawable().
    val appCompatImageView = KImageView { withId(R.id.favorite) }

    appCompatImageView {
        hasDrawable(R.drawable.favorite_border)
    }

However i get next error:
junit.framework.AssertionFailedError: 'with drawable id<PHONE_NUMBER> or provided instance' doesn't match the selected view.
Expected: with drawable id<PHONE_NUMBER> or provided instance
Got: "AppCompatImageView{id=2131427857, res-name=favorite, visibility=VISIBLE, width=105, height=105, has-focus=false, has-focusable=true, has-window-focus=true, is-clickable=true, is-enabled=true, is-focused=false, is-focusable=true, is-layout-requested=false, is-selected=false, layout-params=androidx.constraintlayout.widget.ConstraintLayout$LayoutParams@77e0b02, tag=null, root-is-layout-requested=false, has-input-connection=false, x=242.0, y=105.0}"

Can you tell me please what's wrong with it?

@StanlyT could u send the .xml configuration and API of emulator please?
We have similar issue if android:scaleType= has been set. Does it is your case?

Closing this issue due to no activity. You can reopen it if the issue is not solved.


[5.7][Diagnostics] Diagnose a mismatch between result builder result and return type

Cherry-pick of https://github.com/apple/swift/pull/59415

Add a tailored diagnostic for cases where result builder
result type disagrees with expected contextual return type.
Resolves: https://github.com/apple/swift/issues/59390
(cherry picked from commit 63fcd670fb820cfc0a87b028cf1b410d68b905da)

@swift-ci please test


adding decompress middleware

Adding decompress middleware to echo guide. that was recently added to echo framework, ref # https://github.com/labstack/echo/pull/1687

Add the hint on consuming memory for the decompressed body.
Thanks @arun0009 . Merged.


Use napolean extension in docs to handle numpy docstrings too

🚀 Pull Request
Description

This PR enables adoption (but does not force) of numpy docstrings.  This solves  https://github.com/SciTools/iris/issues/3841
Enabling napolean  sphinx extension to allow for google style docstrings and now also numpy style docstrings.
Just by enabling this extension causes build warnings due to existing incorrectly formatted docstrings.  A couple of files needed to be updated to allow for a clean build.

lib/iris/io/__init__.py - Correct formatting is now applied when rendered.

Live: https://scitools-iris.readthedocs.io/en/latest/generated/api/iris/io.html#iris.io.save
This PR: https://iris-test-doc.readthedocs.io/en/latest/generated/api/iris/io.html#iris.io.save

lib/iris/analysis/maths.py - Fix build warning

The requirements/ci/py37.yml and py36.yml have been updated to include the new dependency for this extension.
Note that the documentation now will also include all dunders, you can search for dunders via:

Live: https://scitools-iris.readthedocs.io/en/latest/search.html?q=__&check_keywords=yes&area=default (none in search)
This PR: https://iris-test-doc.readthedocs.io/en/latest/search.html?q=__&check_keywords=yes&area=default (lots in search)

The setting named napoleon_include_special_with_doc can change this (currently set to True) in conf.py.
Note that the links to the This PR is only valid for the lifetime of this PR.

Consult Iris pull request check list

closes #3841


Add more info (CONTRIBUTING.md, MAINTAINERS)

Adds CONTRIBUTING.md and MAINTAINERS files including more information to the README.md.

Coverage remained the same at 67.123% when pulling 5f8cf96908248ad5b7598bf8b2f75f91fd459b3d on add-info into d8d13c228db0b4fe5ac8601c58fdf96d2f56e492 on master.

:+1:


Object3D not shown in ViroViewScene

Hello, I have a ViroViewScene on top on another view and I want to show a Object3D with some animation. However, the Object3D is not rendered on the UI. I can show Box, Text on the UI by attach them to the rootNode, but if I attach object3D to the rootNode, it does not show. Any suggestions is appreciated. Thank you!

Hi @LiamLuUW,
Have you seen the Model Not Appearing? callout on our Viro3DObject documentation page here: https://docs.viromedia.com/docs/viro3dobject
Most likely you haven't added a light to your scene and as a result, your object isn't lit up.
Thanks,


Minerva Permits should have a paragraph elevator pitch when first opened

This should give some context before thrusting the user into the deep end of geospatial data analysis. The user can then dismiss it and start doing things.

+1 @manthey could you add something like what I have below? We also need the controls to be more self-documenting, and turn a few into drop-down menus.
Overview text:
Minerva Permits lets you explore permit, crime, and code violation data in Boston using data from the City of Boston. Use the controls on the left to display points or a dynamically generated binned heatmap on the data, and to filter down your search to specific types of permits, crimes, or violations. The animation controls let you cycle through the queried data to view weekly or daily patterns.
This application is open source and was built with Kitware's Resonant platform, including Girder for data management and GeoJS for scalable visualization.
Large button "Explore"
Or start with one of these preconfigured visualizations:
Predicting new construction - From the raw city data, this view attempts to reconstruct the U.S. Census new residential construction estimates by restricting the permits displayed on the map. The monthly correlation between the true and reconstructed data can be viewed on the left both as a timeline and scatterplot. Can you verify using the satellite view that these are indeed new residential construction sites? Can you adjust the query parameters to obtain a closer match?
Correlating demolition with unsafe structures - In this view, red represents demolition permits, and blue represents unsafe structure code violations. A mixture (purple) shows areas where both demolition and unsafe structures are abundant, while strong red or blue designates areas where only demolition or unsafe structures are predominant. What areas are seeing reconstruction of aging buildings (predominantly purple)? What areas are seeing unsafe structures that are not being revitalized (predominately blue)? Can you find any specific locations where a site is cited as an unsafe structure and is later issued a permit for demolition?

One more starting point:
Residential trash violations - This view animates the residential code violations for misplacement of trash using a weekly cycle. Can you determine the likely trash pickup dates for various Boston neighborhoods?

Added in PR #224.


Multiple synthesis scores

Base on this change we have support multiple scores for synthesis method.

I guess, I'll leave autoformattings that do not trigger hlint warnings since they seem to make the use of braces more consistent throughout the project (sometimes they were already there on neighboring definitions). Not really important in light of #242, tbh.


Expo Support

Hey man!
In the past we talked about this project, and how good it is =)
Currently we are running a development expo project, and we tried to use burnt, but it was missing stuff ur library has, such as globaly config and ability to change colors etc..
Is this something u are willing to look into? To add expo support?

Hey man!
In the past we talked about this project, and how good it is =) Currently we are running a development expo project, and we tried to use burnt, but it was missing stuff ur library has, such as globaly config and ability to change colors etc..
Is this something u are willing to look into? To add expo support?

Maybe I should reconsider this soon!! I'm seeing the growth of Expo. Wait for me. You can also develop it based on your knowledge through PR.

Actually, it just works on Expo lol (not in Expo Go ofcourse) but a Development Build works fine 💪🏻
Reproduction Repo
https://github.com/Acetyld/ting-expo

Actually, it just works on Expo lol (not in Expo Go ofcourse) but a Development Build works fine 💪🏻
Reproduction Repo https://github.com/Acetyld/ting-expo

ahhaa. awesome!!!
I've never used expo so I don't know exactly what the mechanism is. But it was amazing.

Alright, i take above back lol
  1 | #import "Ting.h"
  2 |
> 3 | #import <ting-Swift.h>
    |         ^ 'ting-Swift.h' file not found
  4 |
  5 | @implementation Ting
  6 |

In a real project its not auto linking the swift file ;p

I also encountered the same problem when migrating to new arch in other projects (multiple picker ...)

Alright, i take above back lol
  1 | #import "Ting.h"
  2 |
> 3 | #import <ting-Swift.h>
    |         ^ 'ting-Swift.h' file not found
  4 |
  5 | @implementation Ting
  6 |

In a real project its not auto linking the swift file ;p

I also encountered the same problem when migrating to new arch in other projects (multiple picker ...)

See above updated comment

I would really like this to work on Expo dev build.

I would really like this to work on Expo dev build.

I would say, go for it =) I think burnt already has a good base, but it is missing features that Ting has. I would suggest creating the module with: https://docs.expo.dev/modules/native-module-tutorial/ , but thats up to u =)

I would say, go for it =) I think burnt already has a good base, but it is missing features that Ting has. I would suggest creating the module with: https://docs.expo.dev/modules/native-module-tutorial/ , but thats up to u =)

Unfortunately I do not have a MacOS device and have no experience with Swift making this very difficult to accomplish. :(

the package seem to be working with expo just fine, you have to build your own development client to use it. as it won't work in expo go.

Does anyone here have experience building plugins for expo? It would be helpful if you guys had a PR for that.

@baronha the package doesn't need a plugin, it works out of the box with expo.

@a-eid problem is the "useFramework! > static"

@Acetyld thank you for the clarification, you can use expo-build-properties to do that. it's also required by react-native-firebase packages.

[
        "expo-build-properties",
        {
          "ios": {
            "useFrameworks": "static"
          }
        }
 ]

Correct, but this causes ting package to not build
On 4 Apr 2024 at 16:01 +0200, Ahmed Eid @.***>, wrote:
@Acetyldhttps://github.com/Acetyld thank you for the clarification, you can use expo-build-properties to do that. it's also required by react-native-firebase packages.
[
"expo-build-properties",
{
"ios": {
"useFrameworks": "static"
}
}
]
—
Reply to this email directly, view it on GitHubhttps://github.com/baronha/ting/issues/19#issuecomment-2037301265, or unsubscribehttps://github.com/notifications/unsubscribe-auth/ANEJI4RKYMGGP5ZISBNHLX3Y3VMMDAVCNFSM6AAAAABD4LJVNKVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDAMZXGMYDCMRWGU.
You are receiving this because you were mentioned.Message ID: @.***>

@Acetyld sorry I am not quit following adding
[
        "expo-build-properties",
        {
          "ios": {
            "useFrameworks": "static"
          }
        }
 ]

to plugins would resolve that, it did for me.

this solved the issue for me.
diff --git<EMAIL_ADDRESS><EMAIL_ADDRESS>index 2ae7778..22389c0 100644
---<EMAIL_ADDRESS>+++<EMAIL_ADDRESS>@@ -1,6 +1,7 @@
 #import "Ting.h"

-#import <ting-Swift.h>
+#import <Ting/Ting-Swift.h>
+

 @implementation Ting

this solved the issue for me.
diff --git<EMAIL_ADDRESS><EMAIL_ADDRESS>index 2ae7778..22389c0 100644
---<EMAIL_ADDRESS>+++<EMAIL_ADDRESS>@@ -1,6 +1,7 @@
 #import "Ting.h"

-#import <ting-Swift.h>
+#import <Ting/Ting-Swift.h>
+

 @implementation Ting

@baronha could you look into this, if it is possible to fix this without breaking rn cli projects?

Has anyone managed to get this working on Expo yet?

Just found this today, as I couldn't customise colours with Burnt package, and the default styling was pretty hard to see on white bg apps.
It works fine for me with
"ios": {
"useFrameworks": "static"
}
Is this something I need to enable if not using firebase @Acetyld ?
(I have the google-services.json purely for android/expo push but I dont use firebase at all other than that)


az bicep publish behind proxy and private endpoints

Is your feature request related to a problem? Please describe.
When behind a network proxy and using private endpoint on a bicep module registry (ACR), publishing modules to the registry is not possible as az bicep publish ignores the proxy bypass list configured for the client.
Describe the solution you'd like
Ability to configure a proxy bypass list to be used by az bicep publish

The ACR client that Bicep uses supports several environment variables to configure proxy server settings. There are listed at the top of this link: https://azure.github.io/azure-sdk/general_azurecore.html#environment-variables
Can you try the NO_PROXY variable to configure the bypass?

Completely missed the NO_PROXY configuration which seams to work. Getting a 401 (Unauthorized) now, but I see other's have struggled with that one when using Private Endpoints

After some more digging, we found that your default policy set had the built-in policy Container registries should have ARM audience token authentication disabled set to Deny and nobody thought of that being an issue when we first deployed the registry according to policy.
After changing policies.azureADAuthenticationAsArmPolicy.status to enabled, we were able to publish modules to the registry as well. Has nothing to do with the proxy case initially mentioned here, but thought it would be worth mentioning since we're probably not the last ones who will experience this...

Thanks for sharing the solution!


Apache Camel and hawt.io debugging: Body/Header not visible at breakpoint

I'm currently working with Apache Camel and hawt.io for monitoring and debugging my Camel routes. This works wonderfully, even if some important information is somewhat hidden in the documentation. For example, it took me a bit to turn on debugging.
However, if I set a breakpoint where the message processing stops at that point in the route, I can't see any "body" or "headers" of my Camel exchange at that point. I've tried all sorts of settings:
Here is some information:
Apache Camel: 3.22.1
Spring boot: 2.7.18
Jolokai Core: 1.7.2
hawt.io: 2.16.0
Camel DSL: XML
I got one workaround for java DSL: getContext().setDebugging(true); in one of the page but I don't know where to add this line in camel XML Route Template file.
Here are the properties of my spring boot application.properties:
management.endpoints.web.exposure.include=hawtio,jolokia
management.endpoints.web.base-path=/
camel.springboot.backlog-tracing=true
spring.jmx.enabled=true
Please suggest any workaround for this issue.

Hawtio v2 / hawtio-integration is no longer maintained. Please use Hawtio v3 or v4.
For Spring Boot 2.x & Camel 3.x, you can refer to this example:
https://github.com/hawtio/hawtio/tree/3.x/examples/springboot
For XML DSL, you should be able to set debugging like this:
<camelContext debug="true" xmlns="http://camel.apache.org/schema/spring">

We are not using camelContext in our route files. Instead we are defining routes in RouteTemplate and configuring/invoking  those routes via route-builder.xml file.
we tried with  , but it is not working.
Content of route file:

{{greeting}} ${body}

Content of route-builde.xmlr:

templatedRoute

Could you please provide workaround for this route files to enable debugging.
One more information we require is that "which version of hawtio-core is compatible with below dependency"

io.hawt
hawtio-springboot
3.0.1

Thanks in advance

We are not using camelContext in our route files. Instead we are defining routes in RouteTemplate and configuring/invoking  those routes via route-builder.xml file.
we tried with  , but it is not working.
Content of route file:

{{greeting}} ${body}

Content of route-builde.xmlr:

templatedRoute

Could you please provide workaround for this route files to enable debugging.
One more information we require is that "which version of hawtio-core is compatible with below dependency"

io.hawt
hawtio-springboot
3.0.1

Thanks in advance

We are not using camelContext in our route files. Instead we are defining routes in RouteTemplate and configuring/invoking  those routes via route-builder.xml file.
we tried with  , but it is not working.
Content of route file:
`
<routeTemplates xmlns="http://camel.apache.org/schema/spring">
    <routeTemplate id="myTemplate">
        <templateParameter name="name"/>
        <templateParameter name="greeting"/>
        <templateParameter name="myPeriod" defaultValue="3s"/>
        <route>
            <from uri="timer:{{name}}?period={{myPeriod}}"/>
            <setBody><simple>{{greeting}} ${body}</simple></setBody>
            <log message="${body}"/>
        </route>
    </routeTemplate>
</routeTemplates>
```

Content of route-builde.xmlr:
```
<?xml version="1.0" encoding="UTF-8"?>
<templatedRoutes id="myTemplateRoute"
	backlogTrace="true" debug="true" trace="true">
	<templatedRoute routeId="myTemplate"
			routeTemplateRef="myRouteTemplatee">templatedRoute
	</templatedRoute>
</templatedRoutes>
```

**Could you please provide workaround for this route files to enable debugging.**

One more information we require is that "which version of hawtio-core is compatible with below dependency"
<dependency>
			<groupId>io.hawt</groupId>
			<artifactId>hawtio-springboot</artifactId>
			<version>3.0.1</version>
		</dependency>

Thanks in advance

Hawtio v2 / hawtio-integration is no longer maintained. Please use Hawtio v3 or v4.
For Spring Boot 2.x & Camel 3.x, you can refer to this example: https://github.com/hawtio/hawtio/tree/3.x/examples/springboot
For XML DSL, you should be able to set debugging like this:
<camelContext debug="true" xmlns="http://camel.apache.org/schema/spring">

We are not using camelContext in our route files. Instead we are defining routes in RouteTemplate and configuring/invoking  those routes via route-builder.xml file.
we tried with  <routeTemplates debug="true" xmlns="http://camel.apache.org/schema/spring">, but it is not working.
Content of route file:
<routeTemplates xmlns="http://camel.apache.org/schema/spring">
    <routeTemplate id="myTemplate">
        <templateParameter name="name"/>
        <templateParameter name="greeting"/>
        <templateParameter name="myPeriod" defaultValue="3s"/>
        <route>
            <from uri="timer:{{name}}?period={{myPeriod}}"/>
            <setBody><simple>{{greeting}} ${body}</simple></setBody>
            <log message="${body}"/>
        </route>
    </routeTemplate>
</routeTemplates>

Content of route-builde.xml:
<?xml version="1.0" encoding="UTF-8"?>
<templatedRoutes id="myTemplateRoute"
	backlogTrace="true" debug="true" trace="true">
	<templatedRoute routeId="myTemplate"
			routeTemplateRef="myRouteTemplatee">templatedRoute
	</templatedRoute>
</templatedRoutes>

Could you please provide workaround for this route files to enable debugging.
One more information we require is that "which version of hawtio-core is compatible with below dependency"
<dependency>
	<groupId>io.hawt</groupId>
	<artifactId>hawtio-springboot</artifactId>
	<version>3.0.1</version>
</dependency>

Thanks in advance

One more information we require is that "which version of hawtio-core is compatible with below dependency"

It's Hawtio v3, and v3 (and v4) don't use hawtio-core / hawtio-integration any longer. They use @hawtio/react.

Could you please provide workaround for this route files to enable debugging.

For the detailed question on Camel, please ask the Camel users mailing list as here is not the place to help Camel issues. Camel experts should answer you better.


Add primary key to DB table accessory and fix duplicates

Questions
Answers

Description?
Related to PR #54530 (https://github.com/PrestaShop/PrestaShop/pull/34530). Problem is, there is missing PRIMARY key, so, from older PrestaShop version there can be duplicate rows, so we must "repair" this duplicate rows and set PRIMARY key then.

Type?
bug fix

BC breaks?
no

Deprecations?
no

Fixed ticket?
Fixes #30022 (https://github.com/PrestaShop/PrestaShop/issues/30022)

Sponsor company
https://www.openservis.cz/

How to test?

@Hlavtox it's a valid solution

@Hlavtox can you suggest php way of this? I am not familiar with this.

@ShaiMagal 9.0.0.sql please ;-)

Closed in favor of https://github.com/PrestaShop/autoupgrade/pull/689


Disable WSMan tests on Debian 9

PR Summary
Disable WSMan tests on Debian 9
PR Context
Debian 9 is failing in CI
PR Checklist

[x] PR has a meaningful title

Use the present tense and imperative mood when describing your changes

[x] Summarized changes
[x] Make sure all .h, .cpp, .cs, .ps1 and .psm1 files have the correct copyright header
[x] This PR is ready to merge and is not Work in Progress.

If the PR is work in progress, please add the prefix WIP: or [ WIP ] to the beginning of the title (the WIP bot will keep its status check at Pending while the prefix is present) and remove the prefix when the PR is ready.

Breaking changes

[x] None
OR
[ ] Experimental feature(s) needed

[ ] Experimental feature name(s):

User-facing changes

[x] Not Applicable
OR
[ ] Documentation needed

[ ] Issue filed:

Testing - New and feature

[x] N/A or can only be tested interactively
OR
[ ] Make sure you've added a new test if existing tests do not effectively test the code changed

Tooling

[x] I have considered the user experience from a tooling perspective and don't believe tooling will be impacted.
OR
[ ] I have considered the user experience from a tooling perspective and opened an issue in the relevant tool repository. This may include:

[ ] Impact on PowerShell Editor Services which is used in the PowerShell extension for VSCode
(which runs in a different PS Host).

[ ] Issue filed:

[ ] Impact on Completions (both in the console and in editors) - one of PowerShell's most powerful features.

[ ] Issue filed:

[ ] Impact on PSScriptAnalyzer (which provides linting & formatting in the editor extensions).

[ ] Issue filed:

[ ] Impact on EditorSyntax (which provides syntax highlighting with in VSCode, GitHub, and many other editors).

[ ] Issue filed:

Removing Debian 9 from CI as it is not supported for .NET 7
https://github.com/PowerShell/PowerShell-Docker/pull/646/files


ShouldInterceptAjaxRequest method is never triggered

I am a fresher with Flutter, this plugin is great, but I am having some problems that have been bothering me for many days, I don't know what went wrong. ShouldInterceptAjaxRequest method is never triggered.please check out my code.please help me.
https://gitee.com/xingfudeshi/my_test

I just tested it and this example works(https://github.com/pichillilorenzo/flutter_inappwebview/blob/master/example/test_driver/in_app_webview_ajax_test.dart), but when I change the version to 4.0.0+4, I can't trigger ajax-related methods.
dependencies:
  json_annotation: ^3.0.0
  flutter:
    sdk: flutter

  # The following adds the Cupertino Icons font to your application.
  # Use with the CupertinoIcons class for iOS style icons.
  cupertino_icons: ^0.1.2
  flutter_downloader: ^1.4.4
  path_provider: ^1.6.9
  permission_handler: ^5.0.0+hotfix.6
  url_launcher: ^5.4.11
  # connectivity: ^0.4.5+6
  flutter_inappwebview: 4.0.0+4
    #path: ../


Search kinda broken, automatically selecting current line when text is highlighted

VSCode Version: 1.28.0 (1.28.0)
OS Version: macOs Sierra 10.12.6

After the update to Version 1.28.0 (1.28.0) when text is selected and using Find, the line is automatically highlighted and the search doesn't work as expected since it's only searching in the line where the cursor is. This is getting really tedious, since I usually select text->copy->find->paste the text. I could not reproduce this on a Windows installation.
Example: https://i.imgur.com/0zG0cEa.mp4
Steps to Reproduce:

select text
Find CMD+F

Does this issue occur when all extensions are disabled?: Yes

@markainick can you please check if setting editor.find.autoFindInSelection is set to true somehow?

Yes it is, I set it to false and it works just like before the update. So basically the line is automatically highlighted if editor.find.autoFindInSelection is set to true

yup, that's the expected behavior of editor.find.autoFindInSelection which will use your selection as the search scope.

Before the September patch (1.28) it behaved differently. It only searched inside the selection (with editor.find.autoFindInSelection enabled) when more than one line was selected. Now every time you find something, you can't search anything new without first deselecting the found text:

you search a text.
It's found.
You search a new text.
It only searches it inside the last result.

Not sure if intended, but it's quite annoying most of the time. And it's definitely not the way it behaved before the patch.

the find-in-selection checkout should be disabled when the selection is single-line even when autoFindInSelection is checked.

@egamma @rebornix shouldn't this be reopened?

yeah, ctrl-f3 is broken now

enable autoFindInSelection
open a text document
select a single word
ctrl-f3

recently it started enabling the 'find in selection' checkbox in this case (it didn't before, correctly) which breaks this use case. the find in selection checkbox should only be automatically enabled if the selection is multi-line.

/duplicate of https://github.com/microsoft/vscode/issues/64513 and let's track it there, we may need a richer autoFindInSelection option.


fix: remove duplicate entries in database.json

this removes the two duplicate entries in the database.json file

Duplicate of #428

Landed in #428


Revert "Add handling for WordPress.com files"

Reverts Automattic/photon.js#10
This was giving us CORS issues in Calypso, so we had to revert the PR that bumped the photon.js version there (https://github.com/Automattic/wp-calypso/pull/30075). I'm assuming we should also revert here.

No need to revert, this is OK in the Calypso monorepo where the source now lives.


Fix Defense section in first two articles.

This PR adds the overview table to the first pushed articles
I left a ❓ in the Navigations article (Framing Protections) as I am not sure we can apply some tricks in iframes to get access to the history object of contentWindow (because of the origins). I would like to discuss this

I have been thinking about the history issue. I would say it's not possible. Otherwise it would be required to bypass the sop and that would certainly be a browser bug.


Fix Automated Travis Release

Automated release through travis seems not to work anymore (See: Travis Build).
We get:
npm ERR! publish Failed PUT 401
npm ERR! code E401
npm ERR! You must be logged in to publish packages. : apikana

Fixed: Npm token wasn't valid and had to be refreshed.


Swarm project status?

The last update to swarm was in 2019; since then it looks like several issues and PRs have stalled.
There are a few companies that have forked swarm for their own use, all of which are only ahead by several commits: https://useful-forks.github.io/?repo=bitwalker/swarm
Has development paused in favor of some other successor library or project? (EDIT: Maybe horde?) Were there any wider ecosystem changes that have led to swarm development being put on hiatus indefinitely?
I noticed that Paul's website is also down/broken (EDIT: adding /index.html made the page work, though his last blog post was in 2018) and he hasn't posted on Twitter in a few years, though he's got pretty recent GH contributions on his profile. Paul, I hope you're okay and doing well! Unrelated, but if you set up GitHub sponsors I'd love to sponsor you. 😄
Note: I fully understand how difficult maintaining an open-source project is and that priorities change and life happens. I mean no ill will with my question. I just wanted to check in and see how the project was doing and if there's anything I can do to help I'd love to assist!

HI @Nezteb
I'm in the process of building an app in Elixir/Phenix and needs distributed supervisor to globalize genserver across a cluster of nodes in AWS ECS.
Horde library looked promising but it seems really low maintained now, bugs are not getting fixed, and I read some people got issues with it.
I've heard of pogo but not sure whether it's production ready.
Could you tell me what you have used in the end ?


Add only the rxjs operators needed by the lib

This PR fixes an issue that I encountered using the angular2-infinite-scroll in my project.
I've configured my project to use only a subset of the RXJS operators to avoid to fetch all the big RXJS library. But, even after this configuration, my project was still fetching all the RXJS library. After debugging I found out that angular2-infinite-scroll was importing all the RXJS library and using only a few operators.
So, this PR replaces the big import with specific import for each operator. This reduces a lot the required amount of data fetched by the application.
Regarding,
Bernardo Pacheco

@bernardopacheco
Thanks - looks good. will integrate in the next release soon.

@orizens When do you plan to release v0.1.9?

hi @bernardopacheco
it's scheduled to July 15th  - you can view milestones at https://github.com/orizens/angular2-infinite-scroll/milestones

Awesome @orizens, thank you!

hi @bernardopacheco
v0.1.9 has just been released!

That's cool! Thanks @orizens!


Remove annotations that belong to a removed range of an editor

When text is removed from an editor the annotations that belong to the
removed range need to be removed too because they are no longer valid.
This is especially useful functionality when the user fixes an error. In
such a case, the builder did already create an annotation previously
that needs to be removed. With this change, it can happen that errors
are removed which were not yet fixed. In most cases, the PC will find
them once again and show them to users. In rare cases, the builder needs
to be run to find all problems. This is not optimal behavior but
probably the best what we can get in Scala because we can't run the
builder on every source change, it is simly to slow.
Fix #1002726

generally LGTM

Alright, I think all comments are addressed and the new incremental reconciliation now works as it should.


Add recovery support for ConfigMaps.

This change also extracts and fixes up ConfigMaps.
It does not support the per-config-map mode bits that
ConfigMapVolumeSource supports.

Note: I can't do a diffbase across my two branches, so this includes everything for now. Probably best to hold off reviewing until the upstream PR is merged.


Fix file/define/class name referenced in glview

File, define, and class names have been changed.
Fix them referenced in examples/glview/glview.cc

Thanks!


Always use yarn version specified in package.json

While I was investigating the FB login issue I realized that heroku uses a nightly version of yarn (find 0.28.1). I installed the same nightly version by following the steps here and was able to reproduce the same issue locally. It's possible that the nightly yarn solves or loads dependencies differently than the current stable version.
This PR adds engines.yarn with the latest stable version as suggested by a heroku employee.

Wow, good detective work! What an unfortunate issue, but glad you found it!

LGTM, feel free to merge when 💚

💚 so merging...

Nice, find Yuki!!!


Just upgraded to Catalina

Are there any plans to update this to work with Apple Music and the new database?

This is not a priority.  After fiddling around with the new Apple Music app, I found that under File > Library > Export Library I can export an XML file, and this still works with libpytunes.  Apple Music is not storing the local music in any kind of database.  I do not purchase my music through Apple, therefore I do not know if this would be an issue with purchased music or a subscription.


[autograph List comprehension issue] OperatorNotAllowedInGraphError error in Tensorflow 2.0

System information

OS Platform and Distribution
Mac os (10.14.6)
TensorFlow installed from (source or binary):
binary
TensorFlow version (use command below):
2.0.0rc1
Python version:
Python 3.6.4

I'm learn tensorflow2.0 from official tutorials.I can understand the result from below code.
def square_if_positive(x):
  return [i ** 2 if i > 0 else i for i in x]
square_if_positive(range(-5, 5))

# result
[-5, -4, -3, -2, -1, 0, 1, 4, 9, 16]

But if I change the inputs with tensor not python code, just like this, I got a error
@tf.function
def square_if_positive(x):
  return [i ** 2 if i > 0 else i for i in x]
square_if_positive(tf.range(-5, 5))

~/tf2_workspace/tf2.0/lib/python3.6/site-packages/tensorflow_core/python/eager/function.py in _create_graph_function(self, args, kwargs, override_flat_arg_shapes)
   1984             arg_names=arg_names,
   1985             override_flat_arg_shapes=override_flat_arg_shapes,
-> 1986             capture_by_value=self._capture_by_value),
   1987         self._function_attributes,
   1988         # Tell the ConcreteFunction to clean up its graph once it goes out of

~/tf2_workspace/tf2.0/lib/python3.6/site-packages/tensorflow_core/python/framework/func_graph.py in func_graph_from_py_func(name, python_func, args, kwargs, signature, func_graph, autograph, autograph_options, add_control_dependencies, arg_names, op_return_value, collections, capture_by_value, override_flat_arg_shapes)
    851                                           converted_func)
    852
--> 853       func_outputs = python_func(*func_args, **func_kwargs)
    854
    855       # invariant: `func_outputs` contains only Tensors, CompositeTensors,

~/tf2_workspace/tf2.0/lib/python3.6/site-packages/tensorflow_core/python/eager/def_function.py in wrapped_fn(*args, **kwds)
    323         # __wrapped__ allows AutoGraph to swap in a converted function. We give
    324         # the function a weak reference to itself to avoid a reference cycle.
--> 325         return weak_wrapped_fn().__wrapped__(*args, **kwds)
    326     weak_wrapped_fn = weakref.ref(wrapped_fn)
    327

~/tf2_workspace/tf2.0/lib/python3.6/site-packages/tensorflow_core/python/framework/func_graph.py in wrapper(*args, **kwargs)
    841           except Exception as e:  # pylint:disable=broad-except
    842             if hasattr(e, "ag_error_metadata"):
--> 843               raise e.ag_error_metadata.to_exception(type(e))
    844             else:
    845               raise

OperatorNotAllowedInGraphError: in converted code:

    <ipython-input-37-6c17f29a3443>:3 square_if_positive  *
        return [i**2 if i > 0 else i for i in x]
    /Users/zhangpan/tf2_workspace/tf2.0/lib/python3.6/site-packages/tensorflow_core/python/framework/ops.py:547 __iter__
        self._disallow_iteration()
    /Users/zhangpan/tf2_workspace/tf2.0/lib/python3.6/site-packages/tensorflow_core/python/framework/ops.py:540 _disallow_iteration
        self._disallow_when_autograph_enabled("iterating over `tf.Tensor`")
    /Users/zhangpan/tf2_workspace/tf2.0/lib/python3.6/site-packages/tensorflow_core/python/framework/ops.py:518 _disallow_when_autograph_enabled
        " decorating it directly with @tf.function.".format(task))

    OperatorNotAllowedInGraphError: iterating over `tf.Tensor` is not allowed: AutoGraph did not convert this function. Try decorating it directly with @tf.function.

I can't find any specifications about this error. I think the real reason is not "iterating over tf.Tensor is not allowed" . Becase I can write like this.
@tf.function
def square_if_positive(x):
    for i in x:
        if i>0:
            tf.print(i**2)
        else:
            tf.print(i)

square_if_positive(tf.range(10))

iterate over tensor just like above code.
So my question is what's the real reason about this error? Any suggestions will help me. I really can't understand this error through I read a lot of materials.

@payne4handsome ,
When tried executing the code for TF-2.0rc1 output is received as follows(no error is faced),
def square_if_positive(x):
  return [i ** 2 if i > 0 else i for i in x]
square_if_positive(tf.range(-5, 5)
##prints
[<tf.Tensor: id=169, shape=(), dtype=int32, numpy=-5>,
 <tf.Tensor: id=175, shape=(), dtype=int32, numpy=-4>,
 <tf.Tensor: id=181, shape=(), dtype=int32, numpy=-3>,
 <tf.Tensor: id=187, shape=(), dtype=int32, numpy=-2>,
 <tf.Tensor: id=193, shape=(), dtype=int32, numpy=-1>,
 <tf.Tensor: id=199, shape=(), dtype=int32, numpy=0>,
 <tf.Tensor: id=209, shape=(), dtype=int32, numpy=1>,
 <tf.Tensor: id=217, shape=(), dtype=int32, numpy=4>,
 <tf.Tensor: id=225, shape=(), dtype=int32, numpy=9>,
 <tf.Tensor: id=233, shape=(), dtype=int32, numpy=16>]

if you want a clearer output please try using the below code-
def square_if_positive(x):
  return tf.where(x>0,x**2,x)
square_if_positive(tf.range(-5, 5))
##prints
<tf.Tensor: id=263, shape=(10,), dtype=int32, numpy=array([-5, -4, -3, -2, -1,  0,  1,  4,  9, 16], dtype=int32)>

Thanks!

@oanush  sorry, I made a mistake. I got errors from below code. I annotate a function with @tf.function that will be compiled into a graph.
@tf.function
def square_if_positive(x):
  return [i ** 2 if i > 0 else i for i in x]
square_if_positive(tf.range(-5, 5))

I got errors like I explained above

Issue replicating for TF-2.0rc1,please find the gist of colab.Thanks!

The issues exists with tf-nightly version '2.1.0-dev20191004'

@kkimdev FYI
The root cause is that autograph doesn't yet support list comprehensions (primarily because it's difficult to determine the dtype of the result in all cases).
As a workaround, you can use tf.map_fn for the comprehension:
return tf.map_fn(lambda i: i ** 2 if i > 0 else i, x)

Or an explicit loop (which is a bit more verbose):
r = tf.TensorArray(x.dtype, 0, dynamic_size=True)
for i in x:
  r = r.write(r.size(), i ** 2 if i > 0 else i)
return r.stack()

We also need to raise a better error message about this and either update the documentation, until this is resolved.

I am interested to look into it deeper and to see if we can support this list comprehensions. Will send a PR if possible.

@mdanatg Thanks for your explains. Looking forward to your better solution

Hello Everyone I am getting this error
OperatorNotAllowedInGraphError: using a tf.Tensor as a Python bool is not allowed in Graph execution. Use Eager execution or decorate this function with<EMAIL_ADDRESS>I am trying to implement Neural style transfer. Please help me with this. Here is the collab link Please take a look into it. I tried everything still It does not resolved.

@nikhilrana015 please use the updated tutorial at https://www.tensorflow.org/tutorials/generative/style_transfer. The notebook you linked uses a method of extracting intermediate layers that's unsupported in eager execution (model.get_layer(i).get_output_at(1)).
cc @omalleyt12

@mdanatg  I tried to replace model.get_layer(i).get_output_at(1) with model.get_layer(i).output but it gives me an error Attribute Error: Layer block4_conv2 has multiple inbound nodes, hence the notion of "layer output" is ill-defined. Use get_output_at(node_index) instead.
I figured out the error but I don't know how to resolve it. In my code Total loss is tensor but when I extract the value by using .numpy() it gives me an error that there is no attribute.
The if statement In the last cell before Checking the Code Markdown gives me an error of operation Not allowed in Graph error. Please Help me in this.

Sorry for the delay. @omalleyt12, any thoughts on that error?

Was able to reproduce the issue with TF v2.2 and TF-nightly (i.e. v2.3.0-dev20200625). Please find the gist of it here. Thanks!

same issue, here.

This is not a particularly meaningful issue thread at this point because it's got a few different user requests for help at this point.

The original issue (& the gist above) are for this reason that @mdanatg mentioned (@mdanatg I know we track this issue internally, should we make a separate github issue that's clearer to users?)

The root cause is that autograph doesn't yet support list comprehensions (primarily because it's difficult to determine the dtype of the result in all cases).

As a workaround, you can use tf.map_fn for the comprehension:

return tf.map_fn(lambda i: i ** 2 if i > 0 else i, x)
Or an explicit loop (which is a bit more verbose):

r = tf.TensorArray(x.dtype, 0, dynamic_size=True)
for i in x:
r = r.write(r.size(), i ** 2 if i > 0 else i)
return r.stack()
We also need to raise a better error message about this and either update the documentation, until this is resolved.

@nikhilrana015 I don't run into the issue you mentioned when I try running your colab. If you're still running problems please make a separate github issue so that we can triage more effectively. My guess is the issue you were running into probably had something to do with using a layer multiple times to construct different functional models, and probably trying to grab the wrong symbolic outputs.

For anyone else seeing this thread: please make a different github issue unless you're specifically having problems w/ the list comprehension issue @mdanatg mentioned.

Hi,
I have a similar problem where I'm trying to iterate over a tensor in eager mode but I can't.
Naturally, you would do something like:
probs = tf.convert_to_tensor(np.array([[1,2,3], [4,5,6], [7,8,9]]))
indexs = tf.convert_to_tensor(np.array([1, 2, 3]))

@tf.function
def iterate_tensor(probs, indexs):
    return [output[label] for output, label in zip(probs, indexs)]
iterate_tensor(probs, indexs)

But this gives the error OperatorNotAllowedInGraphError: iterating over `tf.Tensor` is not allowed:
Another thing that I tried was:
probs = tf.convert_to_tensor(np.array([[1,2,3], [4,5,6], [7,8,9]]))
indexs = tf.convert_to_tensor(np.array([1, 2, 3]))

@tf.function
def iterate_tensor(probs, indexs):
    return tf.map_fn(lambda i: i[0][i[1]], (probs, indexs), dtype=(tf.int64, tf.int64))

iterate_tensor(probs, indexs)

Gives the error ValueError: The two structures don't have the same nested structure.

Was able to reproduce the issue with TF v2.7. Please find the gist of it here. Thanks!

Hi @payne4handsome ! I was able to resolve this issue by replacing tf.range() with range(). Attaching Gist for reference.


Add documents to comply with community profile standards

Add the documents missing here: https://github.com/lucone83/metal-parser/community

 Add documents to comply with community profile standards


refactor(store-indexer): move sentry init

moved Sentry.init to avoid initializing sentry on import

closing in favor of https://github.com/latticexyz/mud/pull/2163


Styling and server live extension

The project is already approved and is working so well

But l think you had the style import commented, so you should uncomment.
Also you test with go-live of VS studio extension what you should be testing is with server --watch of the webpack.

👍
Happy coding! and a good job.

Issue was corrected thank you.


Error: command face_recognition not find

face_recognition version:
Python version:
Operating System:

Description
Describe what you were trying to get done.
Tell us what happened, what went wrong, and what you expected to happen.
What I Did
Paste the command(s) you ran and the output.
If there was a crash, please include the traceback here.

command face_recognition not find  means face_recognition install failure？


Manifest in the jar published to maven does not contain Main-Class Attribute

This issue was imported from Closure Compiler's previous home at http://closure-compiler.googlecode.com
The original discussion is archived at:
http://blickly.github.io/closure-compiler-issues/#986

This was fixed.  Can an owner close this?


[W5.4b][W13-A2]Gan Wei Liang

@william6364
Some comments added. Please ack & close the PR after reading comments.


Change logo to an actual Kedge not an anchor

I've been informed that the current logo isn't actually a "Kedge", but just a normal anchor.
Tweet: https://twitter.com/fuzzychef/status/959212529875673088
Let's change it to a "Kedge"!

Waiting to see our new logo :)


lm2637

The Readme file is currently lengthy and complex, making it challenging for newcomers to comprehend how to contribute effectively to the project.
To enhance accessibility and clarity, I propose relocating the Contributing section to the beginning of the Readme file and streamlining its content where feasible.
I kindly request assistance from anyone willing to dedicate time to address this issue and improve the project's accessibility for all contributors. Thank you!

29

I'm thrilled to contribute to this project and make it simpler for everyone to get engaged. My name is Leela Mukesh Mutyalapalli, and I enjoy the concept of introducing new users to open-source projects by making them easier to use and understood. I was really hoping that the contributing section in the Readme file would be moved and made simpler. I believe that if we clearly arrange the material, it will be much easier for newcomers to understand how they can contribute to the project. I'm eager to get to work on this and collaborate with each of you to implement these changes. Please share any ideas or thoughts you may have with me about how we can approach this task.
Thankyou.

Hi @caiton1,
I truly appreciate your knowledge and insights, which is why I wanted to get in touch with you. Your contributions to the project have been incredible, and I believe your viewpoint could significantly enhance the Readme file's accessibility.  We would greatly appreciate your advice as we work to improve the project's accessibility for novice users.
I sincerely appreciate your consideration of my request and the fantastic work you've been doing on the project!
Thank You.

I just opened the issue and solved the issue. After the updated and I just closing the issue.

I just opened the issue and solved the issue. After the updated and I just closing the issue.
Thank You.


Need fixes for composition modes

I tested fcitx5-mozc on the Plasma desktop. Fcitx5-mozc shows composition modes,
but some of them are unnecessary/broken.

There are six entries.

Full width alphabet icon + Half width alphabet: It's unnecessary and doesn't work.
Hiragana icon + Hiragana: OK
Full width Katakana icon + Full width Katakana: OK
Full width alphabet icon + Full width alphabet: OK
Half width alphabet icon + Half width alphabet: OK
Full width Katakana icon + Half width Katakana: It should be "Half width Katakana icon + Half width Katakana" (ui-katakana_half.png + ｱ). It doesn't work. This mode need to convert "aiueo" to "ｱｲｳｴｵ" (In mode 2, type "aiueo" and press F8).

Yeah, I agree. looks like the direct mode is only useful when it is kana mode instead of romaji.

Also the label is only one character is also kinda because of an old limitation in fcitx 4, which should probably be updated to a more meaningful string.

Direct and half katakana mode should be fixed by now.


Refactor operator memory tracking to support blocking

Currently we don't do any blocking, but this is necessary to support the
new memory management system

I like the idea, but I'd like to try modify the Driver instead of all the operators.

Updated it. Have another look :)

Looks good


Updated Ktor Version to 2.1.2

Please, set high priority for this PR. We use newer version of ktor and can't use this SDK cause of this issue

Hi @way2jatin, thank you for preparing PR.
We reviewed your changes and found that Tests starting to fail after that changes. Are you going to fix that or we may go ahead and help?
FYI: This change leads to FeatureURLBuilderTest failure.

@vazarkevych Thanks for fixing the test. I was a bit occupied elsewhere. Glad that the PR is now merged. 👍


on page load all items load regardless of offset..

I've added a callback function to test and upon load, all components wrapped seem to load..
I have tested various offsets with consideration of hero height but it would seem they load regardless..
example code:
import TitleText from '../components/TitleText'
import HomeTitleCopyScene from '../components/HomeTitleCopyScene/index.js'
import CaseStudyCards from '../components/CaseStudyCards'
import LazyLoad from 'react-lazy-load';
import TechUsed from '../components/TechUsed'

function Home() {
  return (
    <div className="container">
      <Banner
        title="Front-end Development and Design"
        copy="With half a decade experience I've worked across a broad spectrum of clients, industries and technologies."
        imageD="white-ipad"
        imageN="black-ipad"
       />
       <LazyLoad offsetVertical={1500} onContentVisible={console.log('loaded1')}>
      <HomeTitleCopyScene />
      </LazyLoad>
      <LazyLoad offsetVertical={1750} onContentVisible={console.log('loaded2')}>
      <CaseStudyCards />
      </LazyLoad>
      <LazyLoad offsetVertical={2000} onContentVisible={console.log('loaded3   ')}>
      <TechUsed displayAll title="The Whole is Greater than the Sum of its Parts" text="A list of all technologies, tools, software and services utilised and skilled in over the last 5 years." all  />
      </LazyLoad>
    </div>
  );
}

export default Home;

had this previously working so not sure if recent pushes have affected this library for anyone else?

for me too, all components loading by default.

hello @jimmynames @krishna-mastree , if you could solve the problem?

@Alexanderwags hey man sorry im super late - I never found a solution - I intend on trying to find another library time permitting as this one doesn't seem to work

@Alexanderwags hey man sorry im super late - I never found a solution - I intend on trying to find another library time permitting as this one doesn't seem to work

Same

Old issue but getting around to updating/fixing, what browser was this happening in? I recently update the example in https://github.com/loktar00/react-lazy-load/tree/feature/update-to-18 which is a WIP and it seems to be working fine.

Should now be fixed in 4.0 with #155


proposal: spec: add Class by transpiling to current Go syntax

Lack of classes in #golang seems unnecessary. I should be able to group methods with same receiver argument type, and name that argument in a consistent way. And, even better, “this” could be the default name. So,
class Vertex {
    X, Y float64

    Abs() float64 {
        return math.Sqrt(this.X * this.X + this.Y * this.Y)
    }
    Sum() float64 {
        return math.Sqrt(this.X + this.Y)
    }
}

can be transpiled to
type Vertex struct {
    X, Y float64
}
func (this *Vertex) Abs() float64 {
    return math.Sqrt(this.X * this.X + this.Y * this.Y)
}
func (this *Vertex) Sum() float64 {
    return math.Sqrt(this.X + this.Y)
}

without any loss of expressive power. This syntactic sugar would actually help all of us already used to that very common syntax, which involves less typing in many cases. It is also more convenient if you change the name of the class, and only have to change that in one place. I know that there is a new type aliasing functionality, but that seems too much for just the common case of changing a class name before it is used in other modules.
And, speaking of syntactic sugar, adding basic inheritance by transpiling to struct embedding should also be straight forward.
I feel that being so against the notion of classes will limit the adoption of Go for no good reason. Go is arguably the best programming language out there, but the lack of such a common programming pattern makes me feel twice about forcing myself and my team to write more verbose code and gain nothing from it.

The syntax for methods in Go has been defined in one of the first days of Go's design, and the choices made were deliberate. Being able to easily convert a function into a method and vice versa, being able to make the receiver explicit and giving it a telling name, are some of the reasons. More importantly, in Go, methods can be attached to any type including slices, functions, etc. That is not easily done with the class concept which (implicitly) assumes some struct-like data type for the method receivers. Go doesn't have those limitations.
Finally, this proposal doesn't solve any real issue; as you mentioned, this is essentially syntactic sugar, and in fact it would limit what you can do now with Go. Finally, there's zero evidence that the lack of classes has impacted Go adoption.
I recommend that this proposal be declined.

I understand what you are saying, but I'm not sure if you understand what I propsed. My proposal is not about changing how the language operates, or reducing its expressive power in any way. For example, the implementation of classes in JavaScript is pure syntactic sugar that didn't disrupt its prototype-based programming. I'm not proposing implementing classes in the usual way. I'm proposing some keyword (e.g., "class") to group methods that have the same receiver type. It doesn't need to cover all kinds of receiver types, or complicated edge cases. Just group methods whose receiver is the same struct type.
As for whether there is proof that lack of classes limits Go's adoption... it limits my team's adoption, so that is one case that I can prove. Speaking more generally, we can take the case of JavaScript and see what happened in that community when the "class" syntactic sugar was added. It is a common pattern that saves programmers from typing redundant code, and also helps them keep the code organized in semantical groups. What's not to like about that?

One of Go's principles is not to provide multiple ways of doing the same thing. This is another way of doing something and there's no convincing evidence that this solves any pressing issue. Also, adding a new keyword (class) is a non-starter: it would likely invalidate a lot of existing programs.

I'm proposing some keyword (e.g., "class") to group methods that have the same receiver type.

If it's just this, it has been proposed -and rejected- in the past: see for example #16114 and #16547.

I supposed that it'd be fine if the keyword is something else. But if in the next decade, if I see any new keyword added to the language, I'd feel lied to :)
Technically this can be implemented on the struct keyword itself. Just replace the word "class" in my example with "type struct". I just think that if you use "class", then build on the understanding of millions of people and couple of decades of programming about the intent. I remember myself back in the day before C++ simulating classes with struct in C, so it'd be a full circle.
I don't see how you can argue that in Go there is an aversion have two different ways to do the same thing when when Go has two different ways of declaring a variable: var and :=. And I can find more examples. So, I don't buy that part of the argument.

Regarding #16114 and #16547, that is really strange because #16114 does not benefit from the common knowledge in the community about the grouping of methods into classes given that it doesn't proposed to add "class". It's semantically similar, but we are talking about  a community of humans that have learned certain semantical patterns. As for #16547, that is indeed closed to my proposal but it was dismissed on the grounds that #16114 had being closed. So, from a logical point of view, the closing of #16547 was improperly justified, and closing my proposal based on #16547 would just add one cell to the illogical argument chain.
To sum up. The merit of the proposal is gaining an accepted pattern in the computer science community without loosing anything. A good argument against the proposal would focus on some aspect that it is indeed lost, or on that the gain is not real. So far, in my humble opinion, the arguments on those two topics are not convincing.

I understand that you'd like to see syntactic sugar that would allow you (or your team) write code more in line with class-based languages, and that you feel that providing such a feature might increase adoption of Go (in your team, and perhaps elsewhere).
There are lot of features that lots of people would like Go to have and Go doesn't have them, usually deliberately so. As I have said above, if there is any feature where the Go team had made a very conscious design decision early on, it is about how Go expresses its methods. Go is not a class-based language, and introducing syntactic sugar to pretend otherwise, and with more limited functionality, would be fundamentally against its design philosophy.
Go has been growing acceptance world-wide even though it doesn't have classes in the traditional sense. Not only are classes traditionally more limited than what you can express in Go's type system, they also come with concepts such as subclassing, inheritance, and so on, all of which Go addresses with different and more flexible mechanisms.
I am going to close this as I can say with certainty that this proposal has zero chances of being accepted.

It's interesting that your argument is probably identical to Brendan Eich's argument for not including classes in JS. That was 1995. Of course, 20 years later, the JS community added "classes". Prototypes are indeed more powerful than classes in some context, so adding classes caused no problems.
You could call classes MethodSet if you liked that better.
In any case, I tried. I guess that I shouldn't have doubted Node.js. For all its faults, at least it has both prototypes and classes. They seem to have evolved into a more inclusive community in which different groups can maintain different belief systems. I guess Go tries to be more "pure", which to me sounds more dogmatic.

Javascript is a dynamically typed language. Under the hood, a fast implementation may try to dynamically construct classes so that the runtime can be more efficient. Thus, it can make sense to expose classes directly in the language. There are many ways how that could have been done.
Go is not a statically typed language. The compiler already has all the relevant information. The proposal as posted doesn't point to an actual wide-spread problem or solve a real issue; it is tantamount to saying that you want Go to look different. Just to be clear, it's a fine wish to have, but it's just not meeting the bar for a proposal.
Some languages have a history or even philosophy of accumulating features (C++, D, others); Go is trying to stem the tide in this respect. Maybe that attempt is futile, but only history will tell. But Implying that Go's community is less "inclusive" because it doesn't readily agree with each and every community member's personal syntax preferences is a completely unnecessary accusation.

Let me just point out that there is a different between "agreeing with each and every community member's personal syntax" and agreeing with one the most common programming patterns in the history of the human race. But sure, it must be just me.

This issue is closed and the proposal declined. I am closing this issue for further debate.
If you wish to continue to discuss this please  see https://golang.org/wiki/Questions for good places.
Thank you.

@macrini

I guess Go tries to be more "pure"

I think Go tries to be practical. Nothing in life is free.
You proposed language change will have its pros and cons. Have you considered all cons? New Go users would have to learn this new aspect of the language. Go code readers would have to deal with this new syntax. Go programs that use your "class" syntax will not compile with current "go command". There are probably many other cons that I have not considered (which is a cons in itself - we might discover some big problem after your proposal is implemented). Are pros worth all this trouble?
Alex
PS: Sorry for commenting on closed issue


Extension makes all files save to Downloads

For example, if my last file was saved to Pictures, and I right click -> save as a picture, it will offer to save it to Downloads.
As soon as I turn off the extension it will offer to save to Pictures again, so I know it's specifically the extension at fault.
Experienced on Windows 10 with latest Chrome.

Unfortunately this is a limitation of the Chrome API.
Adding a button to the extension that will allow you to toggle it on or off is planned.
I know this isn't as convenient but it's better than having to disable/enable the extension.

Will revisit this later if the Chrome API changes. Closing for now.

Hey, any updates on this issue?


Reinforcement learning examples

Could please anybody commit to post reinforcement learning models such as DNQ and A3C? I need some hint and guide how to build reinforcement learning RNN modlez

You can use Mxnet and MinPY for reinforcement learning.

@gusdoe Hi, if you still need some references, my repository might be helpful.
https://github.com/takuseno/nnabla-drl-collections

Thank you!
On Wed, 3 Jul 2019 at 10:25, Takuma Seno<EMAIL_ADDRESS>wrote:

@gusdoe https://github.com/gusdoe Hi, if you still need some
references, my repository might be helpful.
https://github.com/takuseno/nnabla-drl-collections
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/sony/nnabla/issues/13?email_source=notifications&email_token=AD72M3I5XK4SDTQVSNK2C7LP5QE2TA5CNFSM4DRNJVZ2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODZDCCWQ#issuecomment-507912538,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AD72M3IXMWTJGKDKKSXKAHLP5QE2TANCNFSM4DRNJVZQ
.

You can also check out our DQN example! https://github.com/sony/nnabla-examples/tree/master/reinforcement_learning/dqn

I think we have already shared the information you need, so please let me close.


Fuse.py: "np.AxisError: axis 2 out of bounds for array of dim 2"

I adapted linemod dataset to have my own objects.
I generated renderes data and am now trying to generate fused data.
However, when I try to run the fuse.py with following execution command: python3 fuse.py --cls ape --fuse_num 5
The following error occurs:

0%|                                                                                | 0/5 [00:00<?, ?it/s]
concurrent.futures.process._RemoteTraceback:
"""
Traceback (most recent call last):
File "/usr/lib/python3.8/concurrent/futures/process.py", line 239, in _process_worker
r = call_item.fn(*call_item.args, **call_item.kwargs)
File "fuse.py", line 288, in prepare_dataset_single
rgb, mask, depth, begin, pose = randomly_sample_foreground(
File "fuse.py", line 226, in randomly_sample_foreground
mask = np.sum(mask,2)>0
File "<array_function internals>", line 180, in sum
File "/home/miriam/.local/lib/python3.8/site-packages/numpy/core/fromnumeric.py", line 2296, in sum
return _wrapreduction(a, np.add, 'sum', axis, dtype, out, keepdims=keepdims,
File "/home/miriam/.local/lib/python3.8/site-packages/numpy/core/fromnumeric.py", line 86, in _wrapreduction
return ufunc.reduce(obj, axis, dtype, out, **passkwargs)
numpy.AxisError: axis 2 is out of bounds for array of dimension 2
"""
The above exception was the direct cause of the following exception:
Traceback (most recent call last):
File "fuse.py", line 353, in
prepare_dataset_parallel(
File "fuse.py", line 335, in prepare_dataset_parallel
res = f.result()
File "/usr/lib/python3.8/concurrent/futures/_base.py", line 444, in result
return self.__get_result()
File "/usr/lib/python3.8/concurrent/futures/_base.py", line 389, in __get_result
raise self._exception
numpy.AxisError: axis 2 is out of bounds for array of dimension 2

I thought it was just my own objects, but this output is from trying to execute the script with "ape", which is a linemod original.
Is there something wrong with tqdm? I really can't figure out what causes the error.

I finally figured it out. I needed to make sure my mask images are converted to RGB. So in fuse.py  Line 223 i added:

with Image.open(msk_pth).convert('RGB') as li:

Now It has the same shape and works as expected.


prevent navigating twice when clicking a button quickly

i using<EMAIL_ADDRESS>and this bug still the same.

When I returned, I immediately entered the component again and the component was mounted twice.

@iherem Could you check my comment above?

I think this is not a bug.. if this is a bug, react-navigation will fix this first
debounce is user's job, see the example code
import React, { Component } from 'react';
import { TouchableOpacity } from 'react-native';
import _ from 'lodash';

export default class DebouncedTouchable extends Component {
  static defaultProps = {
    onPress: () => {}
  };

  constructor(props) {
    super(props);
    this.debouncedOnPress = _.debounce(
      () => {
        this.props.onPress();
      },
      300,
      { leading: true, trailing: false }
    );
  }

  render() {
    return (
      <TouchableOpacity {...this.props} onPress={this.debouncedOnPress}>
        {this.props.children}
      </TouchableOpacity>
    );
  }
}


Compression-based solving

This switches to performing a per-condition pre-compression step, then uses vanilla Pf2 from TensorLy. This is ultimately better because it is much faster, simpler, and will allow for datasets of virtually unlimited size. Some of the code here will ultimately be merged into TensorLy, and so disappear from here, but I don't see our solving changing much from here.
Note that the factors do solve with higher accuracy now. I'm not seeing the biology change, but they do shift around a bit.
Let me know as you encounter any issues using this. I'll merge as soon as you've both taken a look in case you have feedback.

@aarmey no issues running this new version with the thomson dataset, but the reconstruction error is fairly highly now, this reconstruction is regarding the decomposition of the "cell state" tensor correct?

@andrewram4287 you can ignore the reconstruction error printed out by TensorLy—it's actually wrong and needs to be fixed within the package.


Hide download button if empty

Codecov Report

Merging #5487 (6681ff2) into 1.5 (523fa3c) will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##                1.5    #5487   +/-   ##
=========================================
  Coverage     63.50%   63.50%
  Complexity     1401     1401
=========================================
  Files           195      195
  Lines          4137     4137
=========================================
  Hits           2627     2627
  Misses         1510     1510

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 523fa3c...6681ff2. Read the comment docs.


jwt.Claims  does not support indexing

Jwt released an update that makes lines like "idInterface := token.Claims["id"]" invalid.  It looks like the workaround is:
claims := token.Claims.(jwt.MapClaims)
idInterface := claims["id"]
But doing this breaks my authorization (the authorization my boss wrote months ago).  I'm brand new to go, so I'm wondering if my workaround is flawed.  If not, the authorization is just broken and I can go down that troubleshooting path.  Thanks for your help!

Hi @kjordan88 ,
Yes, I am aware of the update. Now that the update is out I will start porting to v3 and at the same time make some breaking changes.
You currently shouldn't be affected by simply using Go vendoring. If you are on an older version, you can manually vendor by checking out the version that I have vendored.

Perfect - thanks so much!


Command Line unknown ARGS

When running from ReSharper in an integration test (nUnit).
[Failure] Command Line An unknown command-line option was found: ARGUMENT: "a774f2fd-f3a2-
4b4f-8e42-43ee5c5a5184"
It appears that the unit test framework is passing a random guid.  If I look at the current process there are no args, so I don't understand where this is coming from.  I'll try and debug but thought I would check if you know the cause offhand.

Thank you for your answer scobrown.
I am trying to run TopShelf in a class library for unit test purpose... but I found out that topshelf host is running just in a console application project.

This isn't a particularly great solution as it prevents regular command-line parsing (for example, service installation).