#86 Show overlay to everyone if the game is being hard synced.

Also replaced most of EventHandlers since their are redundant.

Could you please make separate changes in separate commits in the future? Pretty hard to follow the mixed state of refactored events and the implementation.

Could you please make separate changes in separate commits in the future? Pretty hard to follow the mixed state of refactored events and the implementation.

Reshufled changes between PRs. Now this should be better


Add support for parameterized linked translations

Currently, only linked translations are supported which do not accept any parameters.
This is how it should look like, when parameters are supported:
{
    "myName": "my name is $name",
    "myAge": "I am $age years old",
    "introduce": "Hello, @:myName and @:myAge"
}

Combine the parameters.
String s = t.introduce(name: 'Tom', age: 27); // Hello, my name is Tom and I am 27 years old.

Hello, when this functionality will be supported? This is very useful for me right now. :-)


Implement modern designs and practices in the UI

Description
The current UI of beckn-onix is minimal, but we need to update it to integrate more features now and in the future.
Goals

[ ] Redesign the UI to provide a modern and intuitive user experience
[ ] Incorporate new features and functionality into the updated UI
[ ] Ensure scalability and extensibility to accommodate future feature additions
[ ] Improve overall usability and accessibility for different user groups

Expected Outcome
Objective Outcomes:

An updated and visually appealing UI for beckn-onix
Seamless integration of new features and functionality
Improved user experience and productivity
A scalable and extensible UI architecture for future growth

Acceptance Criteria

[ ] The redesigned UI adheres to modern design principles and best practices
[ ] All required features and functionality are seamlessly integrated into the UI
[ ] The UI is responsive and accessible across different devices and platforms
[ ] Performance and usability testing is conducted, and necessary optimizations are made
[ ] User feedback is gathered, and necessary improvements are incorporated

Implementation Details

Conduct user research and gather requirements for the updated UI
Design wireframes and mockups for the new UI
Develop the UI using appropriate front-end technologies (e.g., React)
Integrate the new UI with the existing beckn-onix backend
Conduct thorough testing and gather user feedback for iterative improvements

Mockups / Wireframes
(Placeholder for any mockups or wireframes, if available)
Product Name
Beckn
Project Name
beckn-onix-ui-redesign
Organization Name:
Beckn Open Collective
Domain
Trade and Commerce
Tech Skills Needed:
React, UI/UX Design, Front-end Development
Mentors
@venkatramanm @raviprakash
Category
Enhancement
Sub Category
User Interface, User Experience

@dhirajshettyyy , need designs for this.

Hi @harshcrop - can you please check on this?

Hello @mayurvir @Mishalabdullah,
Could you provide some brief details on the type of design you're envisioning? If you have any wireframes or concepts in mind, I can reach out to the community to help us create a more polished design.


Issues with seeking and writing to outputStream

I've been trying to use this package today (in combination with the AudioRecorder) but having issues with the invocation of the speech to text API.
For example WriteWaveHeader tries to Seek to the beginning of the stream but the stream provided does not support. Similar problems with other stream writing further down the code.
Any ideas on what might be wrong? Authentication to Bing Speech is working fine but the stream doesn't appear to be working as expected?
{System.NotSupportedException: Specified method is not supported.
at System.Net.WebConnectionStream.Seek (System.Int64 a, System.IO.SeekOrigin b) [0x00000] in :0
at System.Net.Http.DelegatingStream.Seek (System.Int64 offset, System.IO.SeekOrigin origin) [0x00001] in C:\Users\darrenj\Documents\DarrenDemo\IPATestHarness\Xamarin.Cognitive.BingSpeech\Api\PushStreamContent.cs:252
at System.IO.BinaryWriter.Seek (System.Int32 offset, System.IO.SeekOrigin origin) [0x00000] in <7771c78b64d7486dacaffa197e02a1ea>:0
at Xamarin.Cognitive.BingSpeech.Extensions.WriteWaveHeader (System.IO.Stream stream, System.Int32 channelCount, System.Int32 sampleRate, System.Int32 bitsPerSample) [0x0000e] in C:\Users\darrenj\Documents\DarrenDemo\IPATestHarness\Xamarin.Cognitive.BingSpeech\Extensions.cs:14
at Xamarin.Cognitive.BingSpeech.BingSpeechApiClient+<>c__DisplayClass34_0+<b__0>d.MoveNext () [0x00135] in C:\Users\darrenj\Documents\DarrenDemo\IPATestHarness\Xamarin.Cognitive.BingSpeech\BingSpeechApiClient.cs:275 }

I have the same issue

Any news about this issue? I am having the same problem...
System.NotSupportedException: Specified method is not supported.
at System.Net.WebConnectionStream.Seek (System.Int64 a, System.IO.SeekOrigin b) [0x00000] in <9624f2cab6ac4ffc9c31e9469d40591a>:0
at System.Net.Http.DelegatingStream.Seek (System.Int64 offset, System.IO.SeekOrigin origin) [0x00000] in :0
at System.IO.BinaryWriter.Seek (System.Int32 offset, System.IO.SeekOrigin origin) [0x00000] in <657aa8fea4454dc898a9e5f379c58734>:0
at Xamarin.Cognitive.BingSpeech.Extensions.WriteWaveHeader (System.IO.Stream stream, System.Int32 channelCount, System.Int32 sampleRate, System.Int32 bitsPerSample) [0x0000c] in :0
at Xamarin.Cognitive.BingSpeech.BingSpeechApiClient+<>c__DisplayClass34_0+<b__0>d.MoveNext () [0x00359] in :0
--- End of stack trace from previous location where exception was thrown ---
at System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw () [0x0000c] in <657aa8fea4454dc898a9e5f379c58734>:0
at System.Runtime.CompilerServices.TaskAwaiter.ThrowForNonSuccess (System.Threading.Tasks.Task task) [0x0003e] in <657aa8fea4454dc898a9e5f379c58734>:0
at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification (System.Threading.Tasks.Task task) [0x00028] in <657aa8fea4454dc898a9e5f379c58734>:0
at System.Runtime.CompilerServices.TaskAwaiter.ValidateEnd (System.Threading.Tasks.Task task) [0x00008] in <657aa8fea4454dc898a9e5f379c58734>:0
at System.Runtime.CompilerServices.TaskAwaiter.GetResult () [0x00000] in <657aa8fea4454dc898a9e5f379c58734>:0
at System.Net.Http.PushStreamContent+d__9.MoveNext () [0x00096] in :0
--- End of stack trace from previous location where exception was thrown ---
at System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw () [0x0000c] in <657aa8fea4454dc898a9e5f379c58734>:0
at System.Runtime.CompilerServices.TaskAwaiter.ThrowForNonSuccess (System.Threading.Tasks.Task task) [0x0003e] in <657aa8fea4454dc898a9e5f379c58734>:0
at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification (System.Threading.Tasks.Task task) [0x00028] in <657aa8fea4454dc898a9e5f379c58734>:0
at System.Runtime.CompilerServices.TaskAwaiter.ValidateEnd (System.Threading.Tasks.Task task) [0x00008] in <657aa8fea4454dc898a9e5f379c58734>:0
at System.Runtime.CompilerServices.ConfiguredTaskAwaitable+ConfiguredTaskAwaiter.GetResult () [0x00000] in <657aa8fea4454dc898a9e5f379c58734>:0
at System.Net.Http.HttpClientHandler+d__63.MoveNext () [0x0036e] in <35658e59c86d40bdbb2ef0bb34b4f0c7>:0
--- End of stack trace from previous location where exception was thrown ---
at System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw () [0x0000c] in <657aa8fea4454dc898a9e5f379c58734>:0
at System.Runtime.CompilerServices.TaskAwaiter.ThrowForNonSuccess (System.Threading.Tasks.Task task) [0x0003e] in <657aa8fea4454dc898a9e5f379c58734>:0
at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification (System.Threading.Tasks.Task task) [0x00028] in <657aa8fea4454dc898a9e5f379c58734>:0
at System.Runtime.CompilerServices.TaskAwaiter.ValidateEnd (System.Threading.Tasks.Task task) [0x00008] in <657aa8fea4454dc898a9e5f379c58734>:0
at System.Runtime.CompilerServices.ConfiguredTaskAwaitable1+ConfiguredTaskAwaiter[TResult].GetResult () [0x00000] in <657aa8fea4454dc898a9e5f379c58734>:0    at System.Net.Http.HttpClient+<SendAsyncWorker>d__49.MoveNext () [0x000ca] in <35658e59c86d40bdbb2ef0bb34b4f0c7>:0  --- End of stack trace from previous location where exception was thrown ---   at System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw () [0x0000c] in <657aa8fea4454dc898a9e5f379c58734>:0    at System.Runtime.CompilerServices.TaskAwaiter.ThrowForNonSuccess (System.Threading.Tasks.Task task) [0x0003e] in <657aa8fea4454dc898a9e5f379c58734>:0    at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification (System.Threading.Tasks.Task task) [0x00028] in <657aa8fea4454dc898a9e5f379c58734>:0    at System.Runtime.CompilerServices.TaskAwaiter.ValidateEnd (System.Threading.Tasks.Task task) [0x00008] in <657aa8fea4454dc898a9e5f379c58734>:0    at System.Runtime.CompilerServices.ConfiguredTaskAwaitable1+ConfiguredTaskAwaiter[TResult].GetResult () [0x00000] in <657aa8fea4454dc898a9e5f379c58734>:0
at Xamarin.Cognitive.BingSpeech.BingSpeechApiClient+d__31.MoveNext () [0x002e4] in :0
--- End of stack trace from previous location where exception was thrown ---
at System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw () [0x0000c] in <657aa8fea4454dc898a9e5f379c58734>:0
at System.Runtime.CompilerServices.TaskAwaiter.ThrowForNonSuccess (System.Threading.Tasks.Task task) [0x0003e] in <657aa8fea4454dc898a9e5f379c58734>:0
at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification (System.Threading.Tasks.Task task) [0x00028] in <657aa8fea4454dc898a9e5f379c58734>:0
at System.Runtime.CompilerServices.TaskAwaiter.ValidateEnd (System.Threading.Tasks.Task task) [0x00008] in <657aa8fea4454dc898a9e5f379c58734>:0
at System.Runtime.CompilerServices.TaskAwaiter1[TResult].GetResult () [0x00000] in <657aa8fea4454dc898a9e5f379c58734>:0    at Xamarin.Cognitive.BingSpeech.BingSpeechApiClient+<SpeechToTextSimple>d__37.MoveNext () [0x00177] in <c38437eedcab403095b1dc4f878a2b54>:0  --- End of stack trace from previous location where exception was thrown ---   at System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw () [0x0000c] in <657aa8fea4454dc898a9e5f379c58734>:0    at System.Runtime.CompilerServices.TaskAwaiter.ThrowForNonSuccess (System.Threading.Tasks.Task task) [0x0003e] in <657aa8fea4454dc898a9e5f379c58734>:0    at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification (System.Threading.Tasks.Task task) [0x00028] in <657aa8fea4454dc898a9e5f379c58734>:0    at System.Runtime.CompilerServices.TaskAwaiter.ValidateEnd (System.Threading.Tasks.Task task) [0x00008] in <657aa8fea4454dc898a9e5f379c58734>:0    at System.Runtime.CompilerServices.TaskAwaiter1[TResult].GetResult () [0x00000] in <657aa8fea4454dc898a9e5f379c58734>:0
at LexiBotMobile.Implementations.RecorderClient+d__9.MoveNext () [0x0006e] in C:\InvectorIq\MainProject\LexiBotMobile\LexiBotMobile\LexiBotMobile\Implementations\RecorderClient.cs:85

Same problem here, is this project still maniteined @NateRickard ?

@All - there was an issue when using the streaming API in combination with certain network stacks (e.g. the updated managed HttpClient stack seemed to trigger this vs the native stack).  I've updated the code and it should work around this now in v2.0.0.  Note that this library now works with .NET Standard 2.0 rather than PCLs.

Cool, I'll try it as soon as possible. Thanks.


Auth::user() - Trying to get property of non-object

Hi, I am having problems trying to login because it shows the error message "ErrorException (E_ERROR) Trying to get property of non-object" as in the image.
Do you know what it could be?

Note that this is a PHP-specific problem that hasn't got anything to do with this package. Please consult other boards like StackOverflow for stuff like this.

Thanks for the feedback.


[BUG] Module boundaries not working correctly for dependant projects

Current Behavior
When using tags to enfore module boundaries, my project is failing to build because they aren't passing the boundry checks. This is my current setup.
    "projectType": "application",
    "name": "proj1",
    "tags": [
        "scope:proj1",
        "type:app"
    ]

    "projectType": "lib",
    "name": "proj1-lib",
    "tags": [
        "scope:proj1",
        "type:feature"
    ]

nx.json
        "moduleBoundaries": [
          {
            "sourceTag": "type:app",
            "onlyDependOnLibsWithTags": [
              "/scope:$1/"
            ]
          }
]

I get the following error
proj1 cannot depend on proj1-lib. Project tag {"sourceTag":"type:app","onlyDependOnLibsWithTags":["/scope:$1/"]} is not satisfied.
Expected Behavior
I would expect this to pass as it is a regex to allow any tag with scope at the begining. (I know i can do this with scope*, however, just want to show how this simple regex doesn't work).
Github Repo
No response
Steps to Reproduce

Create a new nx repo with a project and libray
add tags provided in Current Behavior
Add moduleBoundaries provided from Current Behavior to nx.json in the nx-dotnet options

Nx Report
Node   : 20.10.0
OS     : win32-x64
npm    : 10.2.3

nx (global)        : 19.3.0
nx                 : 19.3.0
@nx/js             : 19.3.0
@nx/jest           : 19.3.0
@nx/linter         : 19.3.0
@nx/eslint         : 19.3.0
@nx/workspace      : 19.3.0
@nx/devkit         : 19.3.0
@nx/eslint-plugin  : 19.3.0
@nx/plugin         : 19.3.0
@nrwl/tao          : 19.3.0
typescript         : 5.4.5
---------------------------------------
Registered Plugins:
@nx-dotnet/core
docker-plugin
azuredevops-plugin
---------------------------------------
Community plugins:
@nx-dotnet/core        : 2.2.0
@nx-tools/nx-container : 6.0.1

nx.json
{
  "$schema": "./node_modules/nx/schemas/nx-schema.json",
  "defaultBase": "main",
  "plugins": [
    {
      "plugin": "@nx-dotnet/core",
      "options": {
        "moduleBoundaries": [
          {
            "sourceTag": "type:app",
            "onlyDependOnLibsWithTags": [
              "/scope:$1/"
            ]
          }
        ]
      }
    }
  ]
}

Failure Logs
No response
Additional Information
No response

Does this syntax work for the nx provided eslint rule?

I would hope so as its something they provide on their docs https://nx.dev/features/enforce-module-boundaries#tag-formats
however, i can't say i have tried as I do not have a js project to try it with.

Ah, I wasn't familiar with the regex matching support, I knew we had glob like.
Prs for this would be welcome, it may be a bit before I can get to it as there is a simple workaround.


refactor(Workflow): add url builder functions

Credo (Elixir code analysis tool) gave me a warning that my pipeline functions are "supposed" to start with a value, rather than the string concatenation I was doing before.
This gave me the idea to create mini functions to build the different parts of the URL and just pipe into those with the workflow_id as the initial url_str that I would build off of.

I think I talked myself out of this one after messing with a bunch of alternatives and url-building functions.
Ultimately a fun exercise but actually makes it harder to understand for no real benefit.


DocsArchive-<IP_ADDRESS>Auto archive content

Please don't merge this PR until target archive repo PR https://github.com/OPS-E2E-PPE/docs-archive-test-target_214166d9-cade-4132-8691-5af95f77db8c/pull/1 is merged into live branch.
Auto archive content to https://github.com/OPS-E2E-PPE/docs-archive-test-target_214166d9-cade-4132-8691-5af95f77db8c.git

Docs Build status updates of commit a30e2aa:
:x: Validation status: errors
Please follow instructions here which may help to resolve issue.

File
Status
Preview URL
Details

:x:Error

Details

[Error]

Cannot sync git repo to specified commit because branch Archive_master_2019-09-25-10-50-58 has been deleted or has been force pushed: fatal: Couldn't find remote ref Archive_master_2019-09-25-10-50-58

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.


Create content style guide for xmtp.org

Provide content style guide for xmtp.org, including voice and tone.

There hasn't been a demand for this. Closing for now. We can open a new issue if the demand presents itself.


Using both quotes in a query makes it nearly impossible to script upload

Can upload -q be redesigned so as to only use ' or "  but not both?

You just need to escape one or the other.

What?

Can't you escape one type of quotes?
https://stackoverflow.com/questions/3834839/how-to-escape-a-double-quote-inside-double-quotes


Update users.json

Added my profile

Added my profile

It cooks ok. But brother you have written too low 'about' field. It will break the UI of the card. If you don't mind, can you add a little bit of text to the 'about' field. Like maximum 3 goes

Check the preview. https://xprofile-git-fork-farfa7886-main-hellofaizan.vercel.app/

Cool 😎
⭐ The repo also


[Bug] ray service example will have worker that name is unexpectedly trimmed

Search before asking

[X] I searched the issues and found no similar issues.

KubeRay Component
Others
What happened + What you expected to happen
in the example:
https://github.com/ray-project/kuberay/blob/9bb690ec910d13068216a14e1c4aed378a36392d/ray-operator/config/samples/ray_v1alpha1_rayservice.yaml#L4
this may lead to a too-long name problem for worker so in operator therefore it would be trimmed.
NAME                                                      READY   STATUS    RESTARTS         AGE
ervice-sample-raycluster-fs6fl-worker-small-group-25lpg   1/1     Running   0                48m
rayservice-sample-raycluster-fs6fl-head-vmqmz             1/1     Running   0                48m

it would be wired for the names and we expect it to be the correct name prefix just like head pod
Reproduction script
just apply the example in ray-operator/config/sample/ray_v1alpha1_rayservice.yaml
Anything else
No response
Are you willing to submit a PR?

[X] Yes I am willing to submit a PR!

I ran into the same issue.
btw, are we able to make the name deterministic?
Now

Head node name is <cluster_name>-raycluster-<random_string>-head-<random_string>
Worker name is <cluster_name>-raycluster-<random_string>-worker-small-group-<random_string>

Could we remove the random strings from the name? IIUC, <cluster_name> is already unique, so we don't need to add random strings to it, right?
I think the name could be

Head Node: <cluster_name>-raycluster-head.
Worker Node: <cluster_name>-raycluster-worker-small-group-<0/1/2>

In Flyte, we use the RayJob name to construct a Kubernetes dashboard URL (http://flyte:30082/#/log/{{ .namespace }}/{{ .RayJobName+"-head" }}/pod?namespace={{ .namespace }}). If the pod name is non-deterministic, we should send another request to the API server to get the pod name.
If we have to keep the name non-deterministic, could we add the name of the head node to Raycluster.status?
cc @Jeffwan

Per @scarlet25151's question, the major reason name changed is because of logic here
https://github.com/ray-project/kuberay/blob/0c98cf2797e6e0e96fbc9889509f622373f7d89f/ray-operator/controllers/ray/utils/util.go#L49-L72
DNS-1123 subdomain allows up to 253 char. @akanso Do you know why it's controlled under 64?
For the enhancement @pingsutw suggests, I think

If the non-deterministic cause any failures now, then we should definitely fix that.  The underneath reason is we don't want to manage worker in stateful way, stateless makes more sense we don't need to care about the sequence no. if we use exact same name for head, then the new one has to be created after the old one is totally removed. There would be cases in the future to support HA (multi-heads), so that's why it uses random strings for both head and worker now.
Add head pod name to RayCluster.status is reasonable for such cases, we can make it. If you have time, feel free to cut a PR.

BTW, how do you get application logs from RayJob now? http://flyte:30082/#/log/{{ .namespace }}/{{ .RayJobName+"-head" }}/pod?namespace={{ .namespace }} what's the underneath logic?

As mentioned by @Jeffwan, this is not a bug. Close this issue.


Battery Charger & Wardrobe Locations

With enough suits, it becomes impossible to use the battery charger without getting stuck inside the wardrobe and dying.
I can't also seem to move the wardrobe by pressing B

I'll rely on others to implement their preferred method of fixing this, like this: https://thunderstore.io/c/lethal-company/p/Verity/TooManySuits/


Create a language file for RS

#The corresponding version of this language file is mc1.10-0.8.20.

Thank you. You may add yourself to CREDITS.md before I merge.


Merge upstream changes

Description: Update main with commits from https://github.com/open-telemetry/opentelemetry-collector-contrib/commit/70d830354ccf8b03c72c651748ef84ec9d0008e9

Would that make sense to squash our commits?

Is merge approach valid for maintaining forked repo?

I think I might have missed that PR and I guess it is no longer relevant as I rebased main already with upstream changes from 0.21.0.  BTW, due to our custom extensions to filter processor in core, we need to maintain and update our custom fork there as well (at least as of now)

Would that make sense to squash our commits?

I think we should avoid making too many commits at once (especially affecting things that change during releases, like go.mod's, etc.) but otherwise we've been good as long as the changes were rebased rather than merged. I am thinking about several alternatives to make life easier:

keeping an up-to-date branch with upstream changes
using a totally different approach and instead of having a fork, start a new project that just takes dependencies from the core and contrib (similarly as AWS does) - I find this the cleanest solution
...

What do you think @pmalek-sumo @sumo-drosiek @perk-sumo @pmatyjasek-sumo @dmolenda-sumo  ?

... and I guess it is no longer relevant

Yup

BTW, due to our custom extensions to filter processor in core, we need to maintain and update our custom fork there as well (at least as of now)

Where's that exactly :) ?

@pmm-sumo Fresh project with otc contrib as dependency seems to fit the golang world and should be much easier to maintain, unless we have to change something in internal structures :sweat_smile:

Would that make sense to squash our commits?

I think we should avoid making too many commits at once (especially affecting things that change during releases, like go.mod's, etc.) but otherwise we've been good as long as the changes were rebased rather than merged. I am thinking about several alternatives to make life easier:

keeping an up-to-date branch with upstream changes
using a totally different approach and instead of having a fork, start a new project that just takes dependencies from the core and contrib (similarly as AWS does) - I find this the cleanest solution
...

I believe that issuing PRs straight from upstream's main branch makes most sense.
This is trivial with Github's UI, you can see the merge commit and inspect what came from upstream and what is our own work.
Rebasing is nice but IMHO not for a long running project like this one where with each "update from upstream" the rebase is more complicated and takes longer and longer.
The only concern with merge strat is that finding commits only on our fork (i.e. not upstreamable) might be slightly more difficult (but does it matter?)

But maybe it's just me not being acquainted with https://github.com/aws-observability/aws-otel-collector

BTW, due to our custom extensions to filter processor in core, we need to maintain and update our custom fork there as well (at least as of now)

Where's that exactly :) ?

This thing: https://github.com/SumoLogic/opentelemetry-collector - we have two small changes there

I believe that issuing PRs straight from upstream's main branch makes most sense.
This is trivial with Github's UI, you can see the merge commit and inspect what came from upstream and what is our own work.
Rebasing is nice but IMHO not for a long running project like this one where with each "update from upstream" the rebase is more complicated and takes longer and longer.
The only concern with merge strat is that finding commits only on our fork (i.e. not upstreamable) might be slightly more difficult (but does it matter?)

I think I fail to understand how that would suppose to work. In general we have two "lines" - the vanilla one (opentelemetry/main) and our distro (SumoLogic/main). Every now and then changes happen on each one of them. Our experience so far was following:

when new OpenTelemetry Collector gets released, we rebase SumoLogic/main with changes from the recent release (so not strictly main but e.g. releases/v0.21.x), then apply any necessary changes and release it as e.g. v0.21.0-sumo
when changes on our side happen, we merge it to SumoLogic/main and release it as a new minor version (e.g. v0.21.1-sumo)

Now, this is not perfect, but it seems it was working just fine. I would love to improve it and I think modularization (i.e. something akin to aws-otel-collector) would be ideal solution (maybe the only caveat being that changes to existing modules would need to be duplicated)

I believe that issuing PRs straight from upstream's main branch makes most sense.
This is trivial with Github's UI, you can see the merge commit and inspect what came from upstream and what is our own work.

I think I fail to understand how that would suppose to work. In general we have two "lines" - the vanilla one (opentelemetry/main) and our distro (SumoLogic/main). Every now and then changes happen on each one of them. Our experience so far was following:

Whenever one wants to take in the changes from upstream the following PR would need to be created: https://github.com/SumoLogic/opentelemetry-collector-contrib/compare/main...open-telemetry:main ( if conflicts arise then merge locally from upstream to branchX, resolve conflicts, then issue PR with this branch)
And that's it.
If linux can work with this model https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/log/  (with 1 upstream to pull from) I think we could to.
But as I said

The only concern with merge strat is that finding commits only on our fork (i.e. not upstreamable) might be slightly more difficult (but does it matter?)

I'll have to take a look at the AWS otel model though.

@pmm-sumo Fresh project with otc contrib as dependency seems to fit the golang world and should be much easier to maintain, unless we have to change something in internal structures 😅

I agree, it seems to be a good solution and much easier to maintain upstream changes


EN-25528: update solo configs

[ ] styleCheck passes
[ ] unit tests pass
[ ] integration tests pass
[ ] manual tests pass
[ ] API docs updated

This build looks good.


Optionally remove parent folder(s) if empty after file deletion

Usefull to avoid file system cluttering when you save FileFields in different folders, for example using upload_to to assign a path which contains the id of the model instance - like you should  always do ;)

This is best handled in individual implementations. Not all storages use the local file system, they can be cloud based.
Have you tried using the signals?
https://github.com/un1t/django-cleanup#signals
from django_cleanup.signals import cleanup_pre_delete, cleanup_post_delete

def pre_directory_cleanup(**kwargs):
    file = kwargs['file']
    file._path = path

def directory_cleanup(**kwargs):
    file_path = kwargs['file']._path
    for i in range(0, PARENT_FOLDER_CLEANUP_LEVELS):
         folder = os.path.dirname(file_path)
         # remove folder iif empty
         if os.path.isdir(folder) and len(os.listdir(folder)) <= 0:
             os.rmdir(folder)
         else:
             break
         file_path = folder

cleanup_pre_delete.connect(pre_directory_cleanup)
cleanup_post_delete.connect(directory_cleanup)

Great suggestion, thank you @vinnyrose 👏
I'll re-post the full snippet here, and a little fix (file._path = file.path instead of file._path = path)
for future reference and mainly in case someone should need it
from django_cleanup.signals import cleanup_pre_delete, cleanup_post_delete

PARENT_FOLDER_CLEANUP_LEVELS = getattr(settings, 'DJANGO_CLEANUP_PARENT_FOLDER_CLEANUP_LEVELS', 1)

def pre_directory_cleanup(**kwargs):
    file = kwargs['file']
    file._path = file.path

def directory_cleanup(**kwargs):
    file_path = kwargs['file']._path
    for i in range(0, PARENT_FOLDER_CLEANUP_LEVELS):
         folder = os.path.dirname(file_path)
         # remove folder iif empty
         if os.path.isdir(folder) and len(os.listdir(folder)) <= 0:
             os.rmdir(folder)
         else:
             break
         file_path = folder

cleanup_pre_delete.connect(pre_directory_cleanup)
cleanup_post_delete.connect(directory_cleanup)


semantic-ui.com top bar appears twice at certain window sizes

The size of the <body> here is 603x436.
Update: reproducible in Chrome 58 and Firefox 53.

This is an easy fix.
In the page's home.css, lines 626 and 680 have media queries that hide the menus at different widths (600px and 650px, respectively). Just setting them to, say, 600px and 601px respectively, it makes the menus show and hide without conflict.

Fixed in PR, thanks for waiting...


API clean-up in develop branch

The current develop branch API combines Bill similarity and Titles, as we wanted. However, there is redundancy and we want to clean it up.
The current API:

Here, there are two duplicates:

The 'titles' routes inside the Bills section. These can be removed entirely.

The list of titles API with names at the bottom. For these, we do want these names (e.g.  'bill-titles-by-bill'), but we want them inside the Titles section


feat: add vsa e2e

followup to https://github.com/slsa-framework/slsa-verifier/pull/777
adds e2e tests for VSAs
Testing

I temporarily modified this workflow to also trigger and auto-open and close issues in PRs.
edited the script to be able to test failure cases
after creating the a new issue laebl "area:vsa" in slsa-framework/slsa-verifier, the workflow did auto-open and aut-close an issue.

https://github.com/slsa-framework/slsa-verifier/issues/792

@haydentherapper

Just wondering, about how long does this take to run, given it's verifying ~3000 VSAs?

About 38s to run slsa-verifier against all the VSAs, and about 2m for the whole workflow.


Build on master is broken on jenkins because VS is missining

Master doesn't build right now.
See https://github.com/Microsoft/visualfsharp/pull/1164 and https://github.com/Microsoft/visualfsharp/pull/1149
same failure:
00:47:44 D:\j\workspace\debug_windows---2f360ea4>if '' == '' echo Error: Could not find an installation of Visual Studio   && goto :failure
00:47:44 Error: Could not find an installation of Visual Studio

Both PR build locally on my machine (apart from expected unit test issues that I'm still trying to fix)

After looking at my build history I think someone changed something on the build agents. This morning I tried to build a commit that worked yesterday (apart from test errors), but it didn't work today.

The appveyor build is green, so it's really something with jenkins

@otawfik-ms, @kevinransom any ideas?

@forki yes. I'm merging the changes in #1065 which should bring it back up to green. Pending a small test fix now.

is it ready?

No. Still fixing the failed tests. Unfortunately, Jenkins machine changes cannot be done in the same PR that is using these changes. I'll link the issue to the opened PR.

Fixed.


Livebook Desktop for Mac app crashes on startup when hostname contains whitespace

Environment

Elixir & Erlang/OTP versions (elixir --version):

Erlang/OTP 25 [erts-13.2] [source] [64-bit] [smp:10:10] [ds:10:10:10] [async-threads:1] [jit]
Elixir 1.14.3 (compiled with Erlang/OTP 25)

Operating system: macOS Ventura 13.3
How have you started Livebook: Livebook Desktop standalone macOS application
Livebook version: 0.9.0
Browsers that reproduce this bug (the more the merrier): irrelevant - bug happens at startup of standalone macOS application
Include what is logged in the browser console: -
Include what is logged to the server console: in ~/Library/Logs/Livebook.log:

[LivebookLauncher] release pid: 72884
=INFO REPORT==== 25-Aug-2022::09:39:38.734689 ===
Can't set short node name!
Please check your configuration

=SUPERVISOR REPORT==== 25-Aug-2022::09:39:38.734712 ===
    supervisor: {local,net_sup}
    errorContext: start_error
    reason: {'EXIT',nodistribution}
    offender: [{pid,undefined},
               {id,net_kernel},
               {mfargs,{net_kernel,start_link,
                                   [#{clean_halt => true,name => livebook_app,
                                      name_domain => shortnames,
                                      supervisor => net_sup}]}},
               {restart_type,permanent},
               {significant,false},
               {shutdown,2000},
               {child_type,worker}]

{"Kernel pid terminated",application_controller,"{application_start_failure,kernel,{{shutdown,{failed_to_start_child,net_sup,{shutdown,{failed_to_start_child,net_kernel,{'EXIT',nodistribution}}}}},{kernel,start,[normal,[]]}}}"}
Kernel pid terminated (application_controller) ({application_start_failure,kernel,{{shutdown,{failed_to_start_child,net_sup,{shutdown,{failed_to_start_child,net_kernel,{'EXIT',nodistribution}}}}},{kernel,start,[normal,[]]}}})

Crash dump is being written to: erl_crash.dump...done

Current behavior
My company macbook was set up in a way that the hostname is something like Christoph Grothauss Mac, i.e. the hostname contains whitespace. This leads to a crash when starting up livebook, stating that the short node name cannot be set.
Temporary Workaround
Configure the hostname to not contain whitespace.
Expected behavior
The livebook macOS application can cope with hostnames that contain whitespaces and starts up successfully.

Thank you for the report @cgrothaus.
Honestly, I am a bit puzzled to why Apple allows a space in the hostname, as that is not allowed in the specification: https://datatracker.ietf.org/doc/html/rfc952
The error itself is coming from Erlang, and we could try to request them to allow such names, but I am also skeptical about changing Erlang to support a hostname that goes against the RFC.

Thanks for the clarification @josevalim.
You're right, Apple is doing something fishy here. I should have come to that conclusion myself.
Perhaps checking the launcher script (I assume there is one that kicks of the beam) for this illegal situation and displaying a warning is an option? Or do you think this is too much special case handling for a rare bug?

We will see how we can improve the desktop app in this case to make sure it is logged. If it helps anyone, I can reproduce the issue with sudo scutil --set HostName "best mac".

On my macOS I got the following issue, I thought it would be localhost by default but it picked up something from configuration which I don't know about and is not /etc/hosts, had to set hostname manually and restart my laptop for livebook to come back and run.
[Livebook] Application running at http://localhost:64481/?token=lbnkbxj5cz4ehnluxdeqkbfzsufnc72m
[os_mon] memory supervisor port (memsup): Erlang has closed
[os_mon] cpu supervisor port (cpu_sup): Erlang has closed
[Livebook] Application running at http://localhost:63243/?token=2xhhsrf4imqge7fichb4uktu6nnoi2ke
[os_mon] memory supervisor port (memsup): Erlang has closed
[os_mon] cpu supervisor port (cpu_sup): Erlang has closed
Protocol 'inet_tcp': the name livebook_app@Sultans-MBP seems to be in use by another Erlang node
Protocol 'inet_tcp': the name livebook_app@Sultans-MBP seems to be in use by another Erlang node
[os_mon] memory supervisor port (memsup): Erlang has closed
[os_mon] cpu supervisor port (cpu_sup): Erlang has closed

ERROR!!! [Livebook] Your hostname "Sultans-MBP" does not resolve to a loopback address (<IP_ADDRESS>/8), which indicates something wrong in your OS configuration, or EPMD is not running.

To address this issue, you might:

  * Consult our Installation FAQ:
    https://github.com/livebook-dev/livebook/wiki/Installation-FAQ

  * If you are using Livebook's CLI or from source, consider using longnames:

        livebook server --name<EMAIL_ADDRESS>        elixir --name<EMAIL_ADDRESS>-S mix phx.server

  * If the issue persists, please file a bug report

[os_mon] memory supervisor port (memsup): Erlang has closed
[os_mon] cpu supervisor port (cpu_sup): Erlang has closed

If it helps anyone, I can reproduce the issue with sudo scutil --set HostName "best Mac".

@josevalim yeah I was able to reproduce the issue and I got the error dialog and the following was logged:
=INFO REPORT==== 4-May-2023::13:25:48.736848 ===
Can't set short node name!
Please check your configuration

=SUPERVISOR REPORT==== 4-May-2023::13:25:48.736863 ===
    supervisor: {local,net_sup}
    errorContext: start_error
    reason: {'EXIT',nodistribution}
    offender: [{pid,undefined},
               {id,net_kernel},
               {mfargs,{net_kernel,start_link,
                                   [#{clean_halt => true,name => livebook_app,
                                      name_domain => shortnames,
                                      supervisor => net_sup}]}},
               {restart_type,permanent},
               {significant,false},
               {shutdown,2000},
               {child_type,worker}]

{"Kernel pid terminated",application_controller,"{application_start_failure,kernel,{{shutdown,{failed_to_start_child,net_sup,{shutdown,{failed_to_start_child,net_kernel,{'EXIT',nodistribution}}}}},{kernel,start,[normal,[]]}}}"}
Kernel pid terminated (application_controller) ({application_start_failure,kernel,{{shutdown,{failed_to_start_child,net_sup,{shutdown,{failed_to_start_child,net_kernel,{'EXIT',nodistribution}}}}},{kernel,start,[normal,[]]}}})

so yeah, not super helpful. Any pointers how we could go about improving the experience?

@wojtekmach could we check something either in the .sh.eex file or in the Swift script for empty spaces in host names?

Yeah, a .sh.eex check is the easiest way to go about this. Thanks!


Adds "track_errors = On" which is deprecated with PHP 7.2

Hi,
we are using PHP 7.2.7 with IIS/Windows Server 2016.
When using PHP Manager to switch PHP from debug into development mode, it adds the following line to php.ini:
track_errors = On

With php 7.2 this now generates a deprecation warning:
Deprecated: Directive 'track_errors' is deprecated in Unknown on line 0

See also http://php.net/manual/en/migration72.deprecated.php
PHP Manager should stop adding/setting track_errors when PHP 7.2 or newer is used.

Potentially resolved testing in new branch

I've tested the Installer from https://github.com/RonaldCarter/PHPManager/blob/9b6411cf633920b795f8aeaeb8f0ae1d6c171d80/bin/Release/PHPManagerForIIS.msi and it fixes the issue for me

I am glad it has been fixed, well merge into master later in the week


ci: Update GHC versions

Also just let the haskell GHA pick a cabal version

Seems silly having to specify the patch version


Allow only to upload dSYM to HockeyApp

PR for issue #613
With the simple option 'upload_dsym_only' set to 'true',
users can make the hockey action only upload the dSYM file.
The option is defaulted to 'false'.

Looks good. Did you test it locally and uploaded something with it?

Yes.
I installed the version of fastlane with these changes and tried two
Supplied a specific path to the dSYM and tried two cases.
One where flag was set to true and another one where the flag was not supplied.
In the former case only the dSYM was uploaded. In the latter both the ipa and dSYM where uploaded.
For the second test I signed and built the app with the sigh and gym actions before calling the improved hockey action.
First the flag was set to true which caused only the dSYM to be uploaded. Then I set the flag to false and both the ipa and dSYM where uploaded.

Looks good, thanks for your contribution @alliannas :+1:

Your welcome, thanks for the help in it :)

The new version is already live :rocket:

:tada:


Changes struct and enum declarations to contain a call path.

With these changes TyStructDeclaration and TyEnumDeclaration now have a call path instead of a name.
This is required before changing the JSON ABI to use enum and struct types with call paths instead of only names which can be duplicate.
ref: https://github.com/FuelLabs/fuel-specs/issues/450

Is there any way we can add a test for this change? Or not just yet?

Is there any way we can add a test for this change? Or not just yet?

No way of testing it yet. I am making this PR before any changes on the JSON ABI output because I would like to merge these changes first as soon as possible.

No way of testing it yet.

Why can we not test it yet @esdrubal? I'd prefer to merge this with tests.

I am making this PR before any changes on the JSON ABI output

One approach is to go ahead and expose structs and enums with call paths to users in this PR so that we can write e2e tests, but then output an "unimplemented" compile error when call paths are used in this position. This compile error would be removed when a PR goes in to make changes to the JSON ABI output.

This PR does a refactoring that renames TyStructDeclaration.name and TyEnumDeclaration.name to TyStructDeclaration.call_path and TyEnumDeclaration.call_path and that changes their types from Ident to CallPath.

One approach is to go ahead and expose structs and enums with call paths to end-users so that we can write e2e tests

@emilyaherbert I did not understand what you mean by "expose structs and enums with call paths to end-users"
The way I see to test this is to output the call paths and update the respective json_abi_oracle.json. I just thought we could merge this refactoring first and avoid rebasing these changes in the future.
Should I include the changes of the JSON ABI output already in this PR?

@esdrubal  is  #1644 related to this PR?

I'm not seeing the reason as to why we cannot add tests to this PR, can you elaborate @esdrubal?

@esdrubal is #1644 related to this PR?

This PR is not related to #1644 this did not add CallPath to TypeInfo::Custom
The reason this PR has no tests is because in terms of behavior nothing changed.
We could change for instance:
https://github.com/FuelLabs/sway/blob/f7153cb7b65114a0600ddb9b636dbf80b300f96b/sway-core/src/language/ty/declaration/enum.rs#L104-L108
To display the call path instead of the suffix only.

The reason this PR has no tests is because in terms of behavior nothing changed.

Adding tests to this PR would demonstrate this to PR reviewers. Right now I don't have as much validation for this as I would like.
How about this---I propose a multistep approach to implementing this feature:

The first step will be to expose the changes to the language to Sway users by editing the parser. A good place to start is to target the language proposed in the sample source code in https://github.com/FuelLabs/fuel-specs/issues/450. The compiler should emit an "unimplemented" compile error for any of these new language features though. No need to add any logic past parse time yet.
The second step will be to revisit this PR and to visit #1644. In order to implement https://github.com/FuelLabs/fuel-specs/issues/450 you will need to include #1644 as well. At this point, do add end-to-end tests to check to see that the new logic is sound. However, I recommend holding off on any ABI changes and instead having the compiler emit an "unimplemented" compile error at ABI gen time if these features are detected. As such, the tests that you write at this stage will live in the "should_fail" test directory---the will fail to compile with that "unimplemented" error but that should be the only error present.
The third step will be to make necessary changes to ABI gen.

What are your thoughts @esdrubal?

As a side note, @emilyaherbert and @esdrubal can you confirm whether this PR fixes https://github.com/FuelLabs/sway/issues/418? Maybe that's one way of verifying this change.

As a side note, @emilyaherbert and @esdrubal can you confirm whether this PR fixes #418? Maybe that's one way of verifying this change. If so, @esdrubal feel free to assign #418 to yourself.

Yes, #418 is fixed by this if we change the unify algorithm to use CallPath instead of Ident.
I will update this pull to test this.

What are your thoughts @esdrubal?

@emilyaherbert I like your approach and its true that we will also need to allow TypeInfo::Custom with CallPath to fix https://github.com/FuelLabs/fuel-specs/issues/450.
The only thing I would change is that instead of leaving this PR hanging I purpose it to be merged with #418 verifying it. This way we will already have CallPath's for struct and enums. Then I will open a new PR for the addition of CallPath's to TypeInfo::Custom.

The only thing I would change is that instead of leaving this PR hanging I purpose it to be merged with https://github.com/FuelLabs/sway/issues/418 verifying it. This way we will already have CallPath's for struct and enums. Then I will open a new PR for the addition of CallPath's to TypeInfo::Custom along with the fix for https://github.com/FuelLabs/sway/issues/1644.

Awesome idea @esdrubal!

can you confirm whether this PR fixes https://github.com/FuelLabs/sway/issues/418? Maybe that's one way of verifying this change. If so, @esdrubal feel free to assign https://github.com/FuelLabs/sway/issues/418 to yourself.

Great find and suggestion @mohammadfawaz.


Latest commit (56a0fe5c4) breaks path completion after second /

Hi - first, great plugin!
I noticed today that completion would start to break after the second /. The first / opens completion for paths. If I select the first path and then type the next / it shows me only snippets that match / like if/else. Reverting to d83839ae resolves this issue and the source works as before.
Thanks

Can confirm both the bug and the suggested fix.

Please excuse my ignorance, but I cannot find a way to revert to the commit, since I just installed the plugin so the first revision I have locally seems to be the latest commit.

Depends on how you install your plugins. I use packer, and this works:
        use {
            'hrsh7th/cmp-path',
            commit = 'd83839ae'
        }

I have the same problem, but after reverting to that said commit, no completion is triggered for path at all

@marcushwz is fixed this. Thank you.


Groups of arguments binded with chained Callable.bind calls are appended in reversed call order

Godot version
4.0.alpha11
System information
N/A
Issue description
Currently callable.bind(a1, a2).bind(b1, b2) is equivalent to callable.bind(b1, b2, a1, a2). I think it should be equivalent to callable.bind(a1, a2, b1, b2).
Steps to reproduce
Run this script:
@tool
extends EditorScript

func _run():
	f.bind(1, 2, 3).call(0)
	f.bind(1, 2).bind(3).call(0)
	f.bind(1).bind(2, 3).call(0)
	f.bind(1).bind(2).bind(3).call(0)

func f(a, b, c, d) -> void:
	prints(a, b, c, d)

Output:
0 1 2 3
0 3 1 2
0 2 3 1
0 3 2 1

Expected output:
0 1 2 3
0 1 2 3
0 1 2 3
0 1 2 3

Minimal reproduction project
No response

Technically, this is documented behavior.
But I agree that it's not intuitive (especially when following Python terminology).

So, this is not really a bug, it's just the way bind() works. That is, it always bind the last arguments. Taking that into account it is really expected behavior. A Callable for a function with 2 parameters is the same as a Callable for a function with 4 parameters that has 2 bound arguments, so it shouldn't reorder the already bound ones.

Closed by #76158 clarifying the order

Yeah, I agree.

While this is documented behaviour, it doesn't seem to be "right" behaviour. I want my bind to act in the "first argument bound comes first" way, but it seems there isn't any way to extend Callable to add an "alt_bind()" or something like that.
I suppose this isn't that big of a deal but I would still greatly prefer to having to think backwards about my arguments. I will try to inverse this by creating a singleton and seeing how that goes, but it would be preferable to have a built-in alternative bind that works as one would expect.
If there is any other solution to this I'm unaware of, please let me know.


Update autorest version to prerelease 3.0.0-alpha.20240428.6.x

Triggered from pull request: https://github.com/Azure/autorest.csharp/pull/4185

API change check
API changes are not detected in this pull request.

API change check
API changes are not detected in this pull request.

Close in favor of #43872


Add files via upload

In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:

[x] Filename in the lowercase format
[x] Image format: png
[x] Image size: 256 by 256 px

https://img1.wsimg.com/blobby/go/38a4168b-1815-4318-92d9-e23c88497307/downloads/LOGO%20GF.png?ver=1552343973656

Also, you can use these graphics to say that your ERC20 token fully compatible with Trust Wallet (https://trustwallet.com/logo-assets). Tokens will show up automatically once the user receives them.
Feel free to share this on social media and tag Trust Wallet:

Twitter: @trustwalletapp

Facebook: @trustwalletapp


Copy Change from azure-rest-api-specs-pr/RPSaaSMaster

This is just the sync PR for copying private change to public.
All change from https://github.com/Azure/azure-rest-api-specs-pr/tree/RPSaaSMaster/specification/servicelinker/resource-manager/Microsoft.ServiceLinker/preview/2021-11-01-preview

Breaking change policy is out of scope as service is not GAed.


watir 6.8 removed select_text as a separate file

JavaScript things were reworked for Watir 6.8 and this was removed as an extension and is now always available.

I saw this earlier today.  I will add this plus a few additional changes I want to make and will hopefully get a new release out tonight.
Sent from my iPad

On Aug 30, 2017, at 10:46 AM, Titus<EMAIL_ADDRESS>wrote:
JavaScript things were reworked for Watir 6.8 and this was removed as an extension and is now always available.
You can view, comment on, or merge this pull request online at:
https://github.com/cheezy/page-object/pull/445
Commit Summary
watir 6.8 removed select_text as a separate file
File Changes
M lib/page-object/elements/element.rb (1)
M page-object.gemspec (2)
Patch Links:
https://github.com/cheezy/page-object/pull/445.patch
https://github.com/cheezy/page-object/pull/445.diff
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub, or mute the thread.


Autoformatting Options Going Forward?

I've removed all my formatting configurations, and reset the formatting options in Rider. And then reformatted 2 files:

StevesGameSubsystem.h an older file that looks like it still has spaces for indentation
StevesPooledActorSystem.h a newer file. These changes are small, but there are still some discrepancies.

I think we have two options here:

Accept the small discrepancies in the newer file. (I expect the older one will be messed up no matter what we do)
Export your current Rider Options as a .clang-format file and put it into the repo.

I think the second option is easier for contributors, so we don't have to rely on "default rider settings". Just enable clang-format support in Rider.
I'm happy to export my own Rider Options into a .clang-format and put it into the repo if that is easier, but it might not match your local settings.
If we do add a .clang-format into the repo, I think making a Reformat commit to standardize formatting across all the files, which would make my future PRs easier to review.
This is not a PR to accept, just to show our options.
Let me know what you think!

Ah yeah, this repo is about 4 years old so there's probably a few inconsistent bits from when I was using VS.
I totally didn't see that .clang-format option, I think I missed the General tab 🤦♂ I've added a .clang-format now for the future.
Generally speaking I don't like "reformat" commits, because if there are people with local changes / forks or PRs in progress it can really mess up the chances for merging, and for people trying to keep custom forks up to date. In the case of a style change I prefer format fixing only the areas that are changing anyway. Otherwise you're increasing the chance of breaking someone else's work, and while it's nice to have standard formatting, it's not game-changing. For that reason I don't subscribe to bulk re-formatting on save, unless it's built into the language (like Go) and so guaranteed that everyone is using it. For languages that don't have it, even if you fix it up once, it only takes one PR from someone who isn't using those tools to slightly deviate and cause the same issue again (unless you force reformat after merge, but then you're breaking the contributor's fork). You could require that all contributors run the same formatting tools but when people are giving their time for free it just increases the overhead and chances that people won't bother. I can live with a little inconsistency in the interests of a smoother ride for everyone.
So please avoid doing wholesale formatting changes in PRs - if something is changing anyway it's fine to fix it, but areas that don't need to change shouldn't be altered, as annoying as they are ;)

Okay! That makes a lot of sense, I'll adjust my rider settings to not reformat the entire file on save. Thanks for explaining your reasoning. Closing this, as it was just an discussion and I'll be submitting some changes shortly!


add cmake support

@joostrijneveld

I'm not sure what the advantage of this is, compared to the current Makefile, while it does add an extra dependency.

in fact, I add feature in each pull request. More support is better. And the most important feature is
seed support.

I'm not sure what the advantage of this is, compared to the current Makefile, while it does add an extra dependency.

This would make the project compile under any OS / compiler.


variable SAME_AS_SRC and subfolders

hi
I have multiple watchfolders and would like to control the output folder.
Using "SAME_AS_SRC" works but puts all output in 1 folder.
Using /other/SAME_AS_SRC puts output in /other but then creates a folder named "SAME_AS_SRC" instead of the actual  source folder name.
how can I fix this?

Sneaky.. I could add AUTOMATED_CONVERSION_OUTPUT_DIR_2 and point it to another root folder :-)
Issue resolved.


feat(SpringGen): adding extra annotations at the SpringComposer step for all Spring classes generated

this pr:

adds a @BetaApi annotation for each class composed in SpringComposer
also moves the @Generated("by gapic-generator-java") annotation to SpringComposer for consistency. (this annotation was missing for the properties class composer.)

Updating annotations in SpringComposer  level for the ones that applies to all classes makes it easier for future changes when needed.

Yes, that's a good idea. I'll add a context string to say this is experimental.
This can be open for discussions, and can be done both ways. but I think it be reasonable to start out with stable ones.


ci: re-build dockers with each commit to main

Before submitting

[x] Was this discussed/approved via a Github issue? (no need for typos and docs improvements)
[x] Did you read the contributor guideline, Pull Request section?
[x] Did you make sure to update the docs?
[x] Did you write any new necessary tests?

What does this PR do?
this would enable some quick updates
PR review
Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.
Did you have fun?
Make sure you had fun coding 🙃

Uh, OK, what does that mean for the CI load?

Uh, OK, what does that mean for the CI load?

with #36 we are going back to update only two images, but yes each commit to main would be followed by 1h compilation/install time split into two machines

To resolve the actual blocker we need to:

land https://github.com/Lightning-AI/pytorch-lightning/pull/19688 and https://github.com/Lightning-AI/pytorch-lightning/pull/19687
make new nightly releases of lightning
update litGPT
update pin here

a 1-hour job after each commit sounds like it would put quite a strain on the CI.

a 1-hour job after each commit sounds like it would put quite a strain on the CI.

I think it is fine, regarding you will gain a way to rebuild dockers out of 4h cycle


[DDC] How to recover from HA degraded mode

Both UCP and DTR present a warning message when the cluster is running in "degraded mode", i.e. one or more nodes in unhealthy.
We need to provide more guidance on what to do in these cases.

The DTR part is done

I think this has mostly been fixed


remove extra snapshot null value check in DeltaLog

Remove extra snapshot null value check in DeltaLog. It seems the snapshot never be null. Let me know if I missed anything, thx.

 Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.huangtengfei02 seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.You have signed the CLA already but the status is still pending? Let us recheck it.


Script to merge ChangeLog automatically

If you set up git to use this script, git merges will do the right
thing for ChangeLog files in simple cases. Simple cases are those
where one side only adds one or more entries to the latest version, or
only adds a new version.
This script has not been extensively tested, so you should always
review its output.
Note that you need an entry to your git configuration to make use of
this feature. Run the script with --help for instructions.
This script is mostly of interest to Mbed TLS team members, but I see no reason to keep it out of the repository.

Note: I'm using it now and it seems to be working well so far. Thanks!

This script mismerges the ChangeLog when merging development into a long-lived PR if there has been a release in development since the PR was forked (the entries for the new release in development will be put under the header for the upcoming unnamed release).
Steps to reproduce
From a repo that has https://github.com/ARMmbed/mbedtls-restricted/pull/390 as a remote branch (and the script enabled obviously):

git checkout -b tmp 558da9c3feee
git merge 8266acacc8d6
head -n15 ChangeLog
git merge --abort

Expected result
mbed TLS ChangeLog (Sorted per branch, date)

= mbed TLS x.x.x branch released xxxx-xx-xx

Features
   * Add support for restartable ECC operations, enabled by
     MBEDTLS_ECP_RESTARTABLE (disabled by default) at compile time and
     mbedtls_ecp_set_max_ops() at runtime, using new xxx_restartable functions
     in ECP, ECDSA, PK and X509 (CRL not supported yet), and using existing
     functions in ECDH and SSL (currently only implemented client-side, for
     ECDHE-ECDSA ciphersuites with TLS 1.2, including client authentication).

= mbed TLS 2.11.0 branch released 2018-06-18

Features

Actual result
mbed TLS ChangeLog (Sorted per branch, date)

= mbed TLS x.x.x branch released xxxx-xx-xx

Features
   * Add support for restartable ECC operations, enabled by
     MBEDTLS_ECP_RESTARTABLE (disabled by default) at compile time and
     mbedtls_ecp_set_max_ops() at runtime, using new xxx_restartable functions
     in ECP, ECDSA, PK and X509 (CRL not supported yet), and using existing
     functions in ECDH and SSL (currently only implemented client-side, for
     ECDHE-ECDSA ciphersuites with TLS 1.2, including client authentication).
   * Add additional block mode, OFB (Output Feedback), to the AES module and
     cipher abstraction module.
   * Implement the HMAC-based extract-and-expand key derivation function
     (HKDF) per RFC 5869. Contributed by Thomas Fossati.


The command AzADDomainServiceReplicaSetObject is not recognized

The provided scripts in the page references an AzADDomainServiceReplicaSetObject  command wich is oboslete, I used AzADDomainServiceReplicaSet instead.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 1c701f84-d6a8-b5aa-dad7-4c38b7749670
Version Independent ID: 207343c0-a46d-d277-c900-879d1065f25e
Content: Enable Azure DS Domain Services using PowerShell
Content Source: articles/active-directory-domain-services/powershell-create-instance.md
Service: active-directory
Sub-service: domain-services
GitHub Login: @Justinha
Microsoft Alias: justinha

@fvenezia
Thanks for your feedback! We will investigate and update as appropriate.

@fvenezia
Thank you for pointing this out! I've created a PR to update the documentation and it's currently waiting for the author to review and sign off.
I will now close out this issue. Please allow some time for the author to review and the changes to reflect.
Thank you for your time and patience!


Use lower-priority router if all health checks fail

We are using Traefik 2.6.2 in Docker Swarm. We have the following configuration for the application running behind Traefik reverse proxy:
version: "3.7"
services:
  web:
    image: blog:0.0.1
    networks:
      - traefik-net
    deploy:
      replicas: 1
      labels:
        # enable Traefik for this service
        - "traefik.enable=false"
        - "traefik.docker.network=traefik-net"

        # router
        - "traefik.http.routers.blog.rule=Host(`blog.company.com`)"
        - "traefik.http.routers.blog.entrypoints=web-secure"
        - "traefik.http.routers.blog.tls=true"
        - "traefik.http.routers.blog.service=blog"

        # service
        - "traefik.http.services.blog.loadbalancer.server.port=443"
        - "traefik.http.services.blog.loadbalancer.server.scheme=https"
        - "traefik.http.services.blog.loadbalancer.healthCheck.path=/health"
        - "traefik.http.services.blog.loadbalancer.healthCheck.interval=30s"
        - "traefik.http.services.blog.loadbalancer.healthCheck.timeout=3s"

networks:
  traefik-net:
    external: true
    name: traefik-net

We also have another low-priority router which listens on the same URL and entrypoint as the original blog service. It catches the request only if application is not deployed, kind of a fallback to static error page:
http:
  routers:
    blog-fallback:
      rule: "Host(`blog.company.com`)"
      priority: 1
      middlewares:
        - "redirect-to-generic-error-page"
      tls: {}
      service: "noop@internal"
  middlewares:
    redirect-to-generic-error-page:
      redirectRegex:
        regex: "(.*)"
        replacement: "https://www.company.com/under-maintenance.html?returnURL=${1}"
        permanent: false

Is it possible that the low-priority blog-fallback router takes precedence over blog router in case all of the backends are failing Traefik health checks in blog service?

Hello @aleksvujic,
Thanks for your interest in Traefik,
Have you considered using the Errors middleware?
By doing that, you should be able to catch the 503 (Service Unavailable) error raised when no replicas are available. Then, the error service could be able to redirect the user to the right page or serve a custom error page.

Thank you for this idea. Is it possible to redirect the user to static error page hosted on the external server in errors middleware?

Yes, this issue seems very much related to mine.
For my use case, it would be much cleaner (architecture-wise) if it was possible to redirect the request to external URL in error middleware (and pass the request URL in query parameter) without having to redirect the request to Traefik service first (which would then perform the redirection).
Are there any plans to support that?

Are there any plans to support that?

Currently, we have no plan to support that.


Error when Using sourcekite implement

I got the error when i using sourcekite(default) way to implement SDE.
$ make install PREFIX=/usr/local
swift build -c release
Updating https://github.com/Carthage/Commandant.git
Updating https://github.com/mattgallagher/CwlPreconditionTesting.git
Updating https://github.com/mattgallagher/CwlCatchException.git
Updating https://github.com/jpsim/SourceKitten
Updating https://github.com/Quick/Nimble.git
Updating https://github.com/drmohundro/SWXMLHash.git
Updating https://github.com/Quick/Quick.git
Updating https://github.com/jpsim/Yams.git
error: terminated(1): git -C /Users/WWW/CodeCenter/Swift/sourcekite/.build/repositories/SourceKitten-064560d7 remote update -p output:
    Fetching origin
    fatal: unable to access 'https://github.com/jpsim/SourceKitten/': Failed to connect to github.com port 443: Operation timed out
    error: Could not fetch origin

make: *** [release] Error 1

Hi @huangzhenwen, thanks for your feedback!
It seems like you lost the internet connection while SwiftPM was still fetching all dependencies.


New patch release?

With the changes to the dependencies, the conda-forge package can officially start supporting Windows users. All this needs is a new patch release.

@eugenetriguba @illBeRoy
The configuration for the release workflow requires the tag to be published. One last step needed!


Implement Message Counter Synchronization Protocol part

Problem
Peer message counter synchronization is an essential part of enabling secure CHIP messaging between members of an application group.

Summary of Changes
Implement the protocol used to synchronize message counters between peers when using the same symmetric group key.
This PR does not handle the Initiating Message Counter Synchronization part which is depending on the following issues:
#4628
#4571

Fixes #4626

@pan-apple ?

@yufengwangca , the file name SecureChannelMgr seems to specifically implement MessageCounterSync protocol. The current file name is confusing, given we already have SecureSessionMgr class in the code base. How do you feel about renaming  SecureChannelMgr.cpp/.h to MessageCounterSync.cpp/.h?

@yufengwangca , the file name SecureChannelMgr seems to specifically implement MessageCounterSync protocol. The current file name is confusing, given we already have SecureSessionMgr class in the code base. How do you feel about renaming SecureChannelMgr.cpp/.h to MessageCounterSync.cpp/.h?

Acked, SecureChannelMgr was originally designed to run MCSP and CASE protocols, since we have figured out how to implement multiple CASE sessions using ephemeral TCP ports within Transport layer, we can rename SecureChannelMgr to MessageCounterSyncMgr

@pan-apple @woody-apple ?


bug: default network ACL not being associated with subnet causes recurring drift in Terraform plan

Describe the bug
It looks like this change
https://github.com/lacework/terraform-aws-agentless-scanning/pull/101
released yesterday
https://github.com/lacework/terraform-aws-agentless-scanning/releases/tag/v0.14.0
might have introduced a bug that causes a reoccurring drift in the Terraform plan.
The new aws_default_network_acl resource added in https://github.com/lacework/terraform-aws-agentless-scanning/pull/101 adopts the default network ACL, which is expected.
However, the new resource configuration does not include an explicit association with the agentless_scan_public_subnet created here - https://github.com/lacework/terraform-aws-agentless-scanning/blob/2ba767d27d01e493f1a6433bce206644a15b2d52/main.tf#L937-L948
If you refer to the AWS provider documentation - https://registry.terraform.io/providers/hashicorp/aws/latest/docs/resources/default_network_acl#managing-subnets-in-a-default-network-acl

Because Subnets are by default associated with the Default Network ACL, any non-explicit association will show up as a plan to remove the Subnet

Since the agentless_scan_public_subnet is not explicitly associated with the new default network ACL, it is resulting in a permanent drift in the Terraform state where the implicit association of the subnet is removed on every plan
Steps to reproduce
Update Lacework module to v0.14.0 and run terraform plan. The plan will show a change to remove the subnet id association from the default network ACL resource. When applied, the subnet gets immediately re-associated with the default network  ACL by AWS since within a VPC, all subnets must be associated with a network ACL. The subsequent plan then shows the change to remove the subnet id association from the default network ACL resource. Rinse and repeat.
Expected behavior
The plan should not show a change to disassociate the subnet from the default network ACL.
Screenshots

Version Information

Terraform Version: v1.5.7
Module Version v0.14.0

Additional context
This should be fixed by adding the agentless_scan_public_subnet id to the subnet_ids argument in the default network ACL resource
E.G. something like
resource "aws_default_network_acl" "default" {
  count                  = var.regional && !var.use_existing_vpc ? 1 : 0
  default_network_acl_id = aws_vpc.agentless_scan_vpc[0].default_network_acl_id

  subnet_ids = [aws_subnet.agentless_scan_public_subnet.id]

  egress {
    protocol   = -1
    rule_no    = 100
    action     = "allow"
    cidr_block = "<IP_ADDRESS>/0"
    from_port  = 0
    to_port    = 0
  }

  ingress {
    protocol   = 6
    rule_no    = 101
    action     = "allow"
    cidr_block = "<IP_ADDRESS>/0"
    from_port  = 1024
    to_port    = 65535
  }
}

Thanks for the wonderfully detailed bug report, working on this right now.

Thanks @theopolis! Can we expect this to be patched in v0.14.1 and is there a rough timeline on when it will be released?

Thanks for your patience, I know this bug is frustrating, I will schedule a release soon.


false positive in propNameCasing rule

Describe the bug
Its reporting an error when it shouldnt
To Reproduce
Run the analyzer on this code
const props = defineProps({
    // isDynamic: { default: false, required: false, type: Boolean },
    items: { required: true, type: Array as PropType<{ data: Record<string, boolean | string | number | Date>; height?: number }[]> },
    rowHeight: { default: 35, required: false, type: Number }
});

What is the exact code you are analyzing?
The code from above ⬆

What is the output you are getting?

src/components/ListScroller.vue
vue-strong ~ prop names are not camelCased👉 Rename the props to camelCase. See: https://vue-mess-detector.webmania.cc/rules/vue-strong/prop-name-casing.html
prop names are not camelCased

Expected behavior
It shoudnt report an error
Screenshots
N/A
Used version number of vue-mess-detector: latest
Used version number of node & yarn: -
Additional context
Details in Discord Server Help Channel

Added failed test in https://github.com/rrd108/vue-mess-detector/commit/32f988656b4b2e4c9038eb6d0b6b4234a8922107

Its fixed in latest main commit
Try it out thanks to pkg.pr.new npm i https://pkg.pr.new/rrd108/vue-mess-detector@dde6707


Product and Settings tabs aren't respecting fragment identifier (page anchor)

Normally when you have tabs on interfaces you can jump to a tab on page load by specifying an anchor value, e.g.:
/dashboard/store/settings#settings-shipping
should jump to the shipping tab, but it doesn't.
The address should also change when you are changing tabs.
The Shipping Methods page for example links back to the settings page for global shipping options, but it currently doesn't jump to the correct tab.

Hi Ryan
Just sent you a pull request for this.

@mnakalay You da man!

@Mesuva Thank you, Sir! You're da man as well! :)


When adding a new tombstone record, delete all the older ones

Noticed that these are never cleaned up currently. There may be a performance hit when the first new tombstone record is added and thousands of old ones are destroyed but it shouldn't be terrible.

cool finding! 👍

This PR seems to be causing consistent Deadlock errors in the MySQL integration specs.
Reformatted output from CI job above
bosh  --tty -n -e https://<IP_ADDRESS>:61702 -d simple \
--config /tmp/build/04d13fd0/bosh-src/src/tmp/integration-tests-workspace/pid-16878/client-sandbox/bosh_config.yml \
--ca-cert /tmp/build/04d13fd0/bosh-src/src/bosh-dev/assets/sandbox/ca/certs/rootCA.pem delete-deployment

Using environment 'https://<IP_ADDRESS>:61702' as client 'production_team'

Using deployment 'simple'

Task 4

Task 4 | 03:19:29 | Deleting instances: fake-name1/a977324b-4e5a-4cbb-97ee-cc76fcd736f7 (0)
Task 4 | 03:19:29 | Deleting instances: fake-name1/479efb85-a860-4d4a-855a-db0f7fa40c40 (2)
Task 4 | 03:19:29 | Deleting instances: fake-name1/6ad77256-ae09-4650-8297-4516716d4a2a (1)
Task 4 | 03:19:31 | Deleting instances: fake-name1/479efb85-a860-4d4a-855a-db0f7fa40c40 (2) (00:00:02)
Task 4 | 03:19:31 | Deleting instances: fake-name1/6ad77256-ae09-4650-8297-4516716d4a2a (1) (00:00:02)
                  L Error: Mysql2::Error: Deadlock found when trying to get lock; try restarting transaction
Task 4 | 03:19:31 | Deleting instances: fake-name1/a977324b-4e5a-4cbb-97ee-cc76fcd736f7 (0) (00:00:02)
Task 4 | 03:19:31 | Error: Mysql2::Error: Deadlock found when trying to get lock; try restarting transaction

Task 4 Started  Sun Jun 30 03:19:29 UTC 2024
Task 4 Finished Sun Jun 30 03:19:31 UTC 2024
Task 4 Duration 00:00:02
Task 4 error

Deleting deployment 'simple':
  Expected task '4' to succeed but state is 'error'

Exit code 1

@aramprice @jpalermo should we open an issue for the above mentioned deadlocks or it is addressed already?

New PR to move it to a scheduled job

Thanks! @jpalermo this was faster than the light :-)

Convenient timing 😀


Followup #1 for #5244. Always add 'chip.ble' modules even if ble is n…

…atively disabled
Problem
Based on https://github.com/project-chip/connectedhomeip/pull/5244#discussion_r592067190, this PR keeps adding chip.ble and chip.ble.commisioning as python modules even if ble has been disabled inside the CHIP stack.
I have also added some changes to the #ifdef since I mistype it. Sorry about that.

Thank you!


MPI Fortran constants

This is missing MPI_COMM_NULL_COPY_FN and similar, as well as the API definition.  If we do the API, then I hope @hzhou can generate it from MPICH.

But MPICH is probably going to ignore them and always generate them in scripts (on our TODOs).

Even the mpi.h in this repository should be generated! I understand that Jeff is trying to get things out for this thing moving forward, but this approach of dumping files here is definitely not amenable to future evolution and maintenance.

generation is fine but the whole point of an ABI standard is that mpi.h should not change very often.  if we are in a position to need to change any of this stuff regularly, we have screwed up royally.
adding new functions is the only exception here, but is it really that hard to do those manually?
i have https://github.com/mpiwg-abi/specification-text-draft/blob/main/print-handle-constants.py, which isn't a complete solution, but works for me.  if somebody wants a better generator, they need to write it, because i have to work on the text right now.

The Fortran interface needs to be consistent with the C ABI, so I am not sure maintaining a separate set of files is a good idea. How do we prevent inconsistencies from creeping in?

you can create a main header with all the constants in it, but it cannot have any comments, because that will break preprocessing into Fortran.  that's what i do in VAPAA (https://github.com/jeffhammond/vapaa/blob/main/source/vapaa_constants.h).
generation is the other solution.  however, i didn't find it too difficult to make a consistent copy, and we will only ever need to change the constants when we change the ABI.

I guess it is okay to have them in a "stub-and-headers" library so folks can readily compile. But MPICH is probably going to ignore them and always generate them in scripts (on our TODOs).

that's fine as long as the Fortran modules you generate are ABI compatible.

I'll do the binding generation in a future pull request.

After a more careful look, this PR is just a dump of contantants and prototypes in a bunch of different files for "documentation" purposes. It is far away from what I thought was the purpose of this repository, that is, being a "header and stub library". When time permits, I'll look into cleaning this thing up.

Well, we want to have both MPI.mod and MPI_F08.mod here eventually, and a subset of the ABI definitions are identical in both, so I split the ABI stuff for Fortran into different modules so they can be included as appropriate.
If you want it all in one source file, fine, we can do that, but it's a lot easier to develop it with separate files right now.


Multiple updates of variable aren't that helpful

Given
module M {

   var v: int

   action duplicate_update = all {
     v' = 1,
     v' = 0,
   }

}

The effect checker correctly raises an error due to the duplicate updates of v:
$  quint typecheck f.qnt
/quint/f.qnt:3:4 - error: [QNT202] Multiple updates of variable v
3:    var v: int
      ^^^^^^^^^^

error: typechecking failed

However this error only points the location where the variable is declared, which is not where the error is arising, and it doesn't help identifying where the duplicate updates arise. This can be very tricky in larger specs with layers of action abstractions.
Instead, the error should give a list of all conflicting update locations.
This issue is thanks to a report from @crodriguezvega. Thanks, Carlos!

I'm fine with that label change. To explain my labeling: imo this is pointing to the wrong location, which is why I viewed it as a bug.


ListTile constructor parameters not exposed as properties

This came up in a UX study. When the participant was inspecting a ListTile, the inspector won't show any of its properties (see screenshot below). The framework seemed to be not exposing them as properties. The Flutter version was 1.9.1-hotfix2.

cc @goderbauer @jacob314
We have a lint to ensure these are included. We should turn that lint on and fix all the issues. Michael was saying there's about 500 issues flagged by the lint currently.

@pq if you can get an even partly broken version of the quick fix for that lint working it will make fixing all 500 cases much faster.

A somewhat automated way of fixing this would be awesome. I started fixing it manually for a couple of instances just to see what it is like and it is tedious...

Thanks for the reporting. Please add the output of flutter doctor here.

@jacob314, @goderbauer: tracking a quick-fix in https://github.com/dart-lang/sdk/issues/38633.  Please add any implementation notes as they occur to you.  Thanks!


inconsistent docker-compose files

Hello,
thanks for the brilliant tutorials. It seems as if the docker-compose files have inconsistencies within the names of services and hostname from one section to the other (e.g. mongodb and mongo-db). It would be great if the tutorial would also allaborate the influence of containernames and hostnames on the configuration of context-providers because from my experience this can be confusing.
To the best of my knowledge "container_name" and "expose" are no longer allowed. Also extra healthchecks are not allowed when using docker stack.
Thanks,
Thomas

Hi Thomas,
Could you elaborate? As far as I can see the ownly misaligned files are within the QuantumLeap Tutorial. Are there others you have found?  Also the IoT Agents have an ENV called mongodb when it is not using memory persistence, but that can't be changed.
The yaml files (hopefully) consistently set container_name and hostname to avoid reliance on the implicit naming of the service itself. They make the naming explicit.
Regarding container_names, databases are prefixed db, FIWARE components are prefixed fiware
If this needs to be elaborated, I guess the obvious location is somewhere in  https://github.com/FIWARE/tutorials.Step-by-Step/blob/master/docs/index.md or maybe an additonal appendix after the lengthy cUrl commands. It  shouldn't really be in the main flow of the text since it is describing Docker not FIWARE, but maybe a link to another when each yaml is described would help.
Docs README
-cratedb:
+crate-db:
    image: crate:2.3
-    hostname: cratedb
+    hostname: crate-db
    ports:
        - "4200:4200"
        - "4300:4300"
@@ -221,7 +221,7 @@ quantumleap:
    depends_on:
        - cratedb
    environment:
-        - CRATE_HOST=cratedb
+        - CRATE_HOST=crate-db

QL README
-cratedb:
+crate-db:
    image: crate:2.3
-    hostname: cratedb
+    hostname: crate-db
    ports:
        - "4200:4200"
        - "4300:4300"
@@ -267,9 +267,9 @@ quantumleap:
    ports:
        - "8668:8668"
    depends_on:
-        - cratedb
+        - crate-db
    environment:
-        - CRATE_HOST=cratedb
+        - CRATE_HOST=crate-db

QL docker-compose.yml
 version: "3.5"
 services:
-  mongodb:
+  mongo-db:
     image: mongo:3.6
-    hostname: mongodb
+    hostname: mongo-db
     container_name: db-mongo
     ports:
       - "27017:27017"
@@ -10,11 +10,11 @@ services:
       - default
     command: --bind_ip_all --smallfiles
     volumes:
-      - mongodb:/data
+      - mongo-db:/data

-  cratedb:
+  crate-db:
     image: crate:2.3
-    hostname: cratedb
+    hostname: crate-db
     container_name: db-crate
     ports:
       # Admin UI
@@ -23,13 +23,13 @@ services:
       - "4300:4300"
     command: -Ccluster.name=democluster -Chttp.cors.enabled=true -Chttp.cors.allow-origin="*"
     volumes:
-      - cratedb:/data
+      - crate-db:/data

   grafana:
     image: grafana/grafana
     container_name: grafana
     depends_on:
-      - cratedb
+      - crate-db
     ports:
       - "3003:3000"
     environment:
@@ -60,9 +60,9 @@ services:
     ports:
       - "8668:8668"
     depends_on:
-      - cratedb
+      - crate-db
     environment:
-      - CRATE_HOST=cratedb
+      - CRATE_HOST=crate-db
     healthcheck:
       test: curl --fail -s http://localhost:8668/v2/version || exit 1

@@ -86,7 +86,7 @@ services:
       - IOTA_TIMESTAMP=true # Supply timestamp information with each measurement
       - IOTA_CB_NGSI_VERSION=v2 # use NGSIv2 when sending updates for active attributes
       - IOTA_AUTOCAST=true # Ensure Ultralight number values are read as numbers not strings
-      - IOTA_MONGO_HOST=mongodb # The host name of MongoDB
+      - IOTA_MONGO_HOST=mongo-db # The host name of MongoDB
       - IOTA_MONGO_PORT=27017 # The port mongoDB is listening on
       - IOTA_MONGO_DB=iotagentul # The name of the database used in mongoDB
       - IOTA_HTTP_PORT=7896 # The port used for device traffic over HTTP
@@ -137,6 +137,6 @@ networks:
         - subnet: <IP_ADDRESS>/24

 volumes:
-  mongodb: ~
-  cratedb: ~
+  mongo-db: ~
+  crate-db: ~
   grafana: ~

To the best of my knowledge "container_name" and "expose" are no longer allowed. Also extra healthchecks are not allowed when using docker stack.
Those were at least the files I checked. For me it is not really clear. If the service_name is used for mapping or the set hostname. If you change it the way you proposed it might be even more confusing ;)

Which compose version are you referring to? Docker compose 3.7 still includes container_name and expose and healthcheck

https://docs.docker.com/compose/compose-file/#container_name
https://docs.docker.com/compose/compose-file/#expose
https://docs.docker.com/compose/compose-file/#healthcheck

I'm not sure if the Docker Stack argument is relevant for the tutorials. The tutorials use docker-compose since its purpose is "for defining and running multi-container Docker applications" on a single docker engine.  The purpose within each tutorial is to keep the config as simple as possible so the student can concentrate on learning the FIWARE part.
The tutorial docker-compose files as written are not for deployment, they just lump everything onto one machine. They contain various obvious security flaws - passwords in plain text, no use of HTTPS and so on. This it to avoid the need of multiple machines, generating certificates, encrypting secrets and so on, purely so that a single docker-file can be read as an example to build on, not use directly. A proper architecture has been sacrificed to keep the narrative focused on the learning goals.
So far the Tutorials are covering Core Context, IoT Agents and Security only. There is nothing on deployment and scaling yet. You would be much better looking at the SmartSDK Recipes.
I guess there is a growing need for a bibliography directing users elsewhere when the need arises, to cover more advanced concepts.

Thanks. For the healthcheck I just know what docker-stack tells me when deploying. Same for expose, since docker does expose ports anyway when they are mapped. From the documentation I know saw that container_name is  simply ignored by docker stack. My appologizes ;)
But you are right that this would probably go beyond the scope of the tutorial. I like it anyway:)
I also like the recipes you suggest. Do you know if they will evolve any further in future?


Request support for new xiaomi devices S20&S20+

Xiaomis new vacuums(s20 and s20+) are now available and support for the would be great. The model of my s20 is xiaomi.vacuum.d106gl

nvm found out that their not build by dreame...


[release-1.1] Backport CI improvements

What type of PR is this?

What this PR does / why we need it:
This is a backport of #3330, #3325, #3329, and #3316 into the release-1.1 branch.
Which issue(s) this PR fixes:

Fixes #
Does this PR introduce a user-facing change?:

NONE

/test pull-gateway-api-verify

/approved
/lgtm

/approve


feat: thumbnail service CORS config

Description
Adding CORS config options to the thumbnail service. Don't know if this is correct and needed, maybe the config options are already being applied somewhere else? Someone who knows ™ should take a look.
Types of changes

[ ] Bug fix (non-breaking change which fixes an issue)
[x] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)
[ ] Technical debt
[ ] Tests only (no source changes)

Checklist:

[x] Code changes
[ ] Unit tests added
[ ] Acceptance tests added
[ ] Documentation ticket raised:

Wouldn't it be reasonable to add CORS to the ocis proxy? Same as with CSP .... :shrug:

We decided against that. The CORS values should be as "strict" as possible. If we do that in the proxy, we would have needed to make the settings too loose because we would just allow every method and every header.
Keeping that on the service level makes it possible to restrict it to the methods and headers which are really needed.

please rebase


Issue with dependencies

cargo add tower-sessions-sqlx-store -F postgres
Updating crates.io index
Adding tower-sessions-sqlx-store v0.13.0 to dependencies
Features:
+ postgres
- mysql
- sqlite
Updating crates.io index
error: failed to select a version for libsqlite3-sys.
... required by package sqlx-sqlite v0.8.0
... which satisfies dependency sqlx-sqlite = "=0.8.0" of package sqlx v0.8.0
... which satisfies dependency sqlx = "^0.8.0" of package tower-sessions-sqlx-store v0.13.0
... which satisfies dependency tower-sessions-sqlx-store = "^0.13.0" of package store v0.1.0 (/home/hdias/Work/Development/Gurubeet/workspace/store)
versions that meet the requirements ^0.28.0 are: 0.28.0
the package libsqlite3-sys links to the native library sqlite3, but it conflicts with a previous package which links to sqlite3 as well:
package libsqlite3-sys v0.27.0
... which satisfies dependency libsqlite3-sys = "^0.27.0" of package sqlx-sqlite v0.7.4
... which satisfies dependency sqlx-sqlite = "=0.7.4" of package sqlx v0.7.4
... which satisfies dependency sqlx = "^0.7.4" of package store v0.1.0 (/home/hdias/Work/Development/Gurubeet/workspace/store)
Only one package in the dependency graph may specify the same links value. This helps ensure that only one copy of a native library is linked in the final binary. Try to adjust your dependencies so that only one package uses the links = "sqlite3" value. For more information, see https://doc.rust-lang.org/cargo/reference/resolver.html#links.

You need to also update sqlx-sqlite if you want to use the latest version of sqlx.

The problem here is that the version of sqlx that the OP depended on mismatches what tower-sessions-sqlx-store depends on. The fix for @mrhdias is not to update sqlx-sqlite as suggested by the @maxcountryman, but to update sqlx.
I am encountering a similar issue, except that in my case there is one addional culprit involved -- the latest version of sea-orm depends on sqlx = ^0.7, which results in the same dependency resolution error. Since I can't simply update to a newer version of sea-orm, my only option is to downgrade my tower-sessions-sqlx-store version to the previous release, eg cargo add<EMAIL_ADDRESS>-F postgres.


Unifi controller fixes

Motivation for this change
I like things to work by default.
Things done

[x] Tested using sandboxing
(nix.useChroot on NixOS,
or option build-use-chroot in nix.conf
on non-NixOS)
Built on platform(s)

[x] NixOS
[ ] OS X
[ ] Linux

[x] Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
[x] Tested execution of all binary files (usually in ./result/bin/)
[x] Fits CONTRIBUTING.md.

This change is

I made some similar amendments in nixos/modules/services/networking/mfi.nix. It looks like I forgot to copy them to unifi. We should try to keep the files in lockstep as much as possible.
Notably, I had to || true the chown/chmod to prevent errors on the bind-mounted dirs, but then I was doing so recursively. I don't remember whether recursion is absolutely appropriate.

The travis failure appears to be unrelated.

Thanks!


Improve readme line wrapping

coverage: 95.827%. remained the same
when pulling 2e31694a95d9696a286a01a80ccb3b65ac9878c8 on update-readme
into 3175903d0be6a40f5dffd8196327c2c38077832c on main.


eventHandlers that defined multiple event handlers cannot work properly

e.g.
vm.opts = {
        applyClass: '...',
        locale: {
            ...
        },
       eventHandlers: {
          'show.daterangepicker': function(ev,picker){console.log(123);},
          'hide.daterangepicker': function(ev,picker){console.log(456);},
       }
    };

it is always printing out 456. The handler binded on 'show.daterangepicker' doesn't work!
Does anyone have the resolve solution?

I solved the problem by myself

I want to commit here, but 'Permission to fragaria/angular-daterangepicker.git denied'.
Here is my solution below:
change this
for (eventType in _ref) {
callbackFunction = _ref[eventType];
_results.push(el.on(eventType, function() {
return $scope.$evalAsync(callbackFunction);
}));
}
to
for (eventType in _ref) {
el.on(eventType, function(e) {
var eventName = e.type + '.' + e.namespace;
return $scope.$evalAsync(_ref[eventName]);
});
}
Hope to help others.

I just encountered the same. Any idea how to fix?

see pull request https://github.com/fragaria/angular-daterangepicker/pull/111


ioredis vs node-redis

Description
I've been working with Redis for a couple projects, more specifically with Redis Sentinel.
I had originally been using the this package, but found it was lacking support for Sentinel. As such we migrated to ioredis in search of this support.
I am wondering why both packages exist and if there is any documentation on how someone might decide between the two if they are both supported?

@chasemcdo We're actually in progress, adding Sentinel support to node-redis right now. We recommend node-redis, as it's on track for being the most full fledged client for nodejs, including support for new Redis capabilities like JSON, Search, and others. Similarly, RESP3 support is almost ready as well.

@chasemcdo We're actually in progress, adding Sentinel support to node-redis right now. We recommend node-redis, as it's on track for being the most full fledged client for nodejs, including support for new Redis capabilities like JSON, Search, and others. Similarly, RESP3 support is almost ready as well.

@chayim does that mean ioredis will be deprecated soon? My main confusion is in why they both exist and seem to be supported. The ioredis docs contain migration guides to go from node-redis to ioredis which imply that ioredis might be the way to go.
Is Sentinel Support something that’ll be coming soon or not for a while given the issue for it was opened back in 2012 #302

@chasemcdo Would be helpful if a tentative timeframe for release is shared, would help us better manage our anticipation.
Thanks for the good work!

Hello,
Choosing the correct NodeJS Redis library is not obvious as:

Redis Documentation mentions node-redis (no ioredis).
Redis Developer Documentation uses ioredis in their examples.

@chasemcdo's question about ioredis deprecation is relevant.

To answer the "why both exist" question, ioredis was created as an alternative client 9 years ago by an individual: https://github.com/luin
According to his profile page:

I created ioredis, one of the most popular clients for Redis. It was acquired by Redis Ltd. in 2023.

On Jun 15, 2023, this commit was added that changed the links to reflect the new owner: https://github.com/redis/ioredis/commit/9c175502b53b400a31bd8bddc8e9a469856bc820
So at this point, it looks weird that both are owned by https://github.com/redis and both "supported". However, since then, only one commit has been made to remove sponsor links and such from the README, so it's effectively unmaintained now.
For a long time, it had more functionality than this library (including sentinel support). However, over time there was an increasing amount of functionality with no direct support, and those had to be hand-rolled using raw commands. e.g. JSON commands. This is especially painful with TypeScript, and I've seen/worked on custom wrappers for this in multiple projects.
This project is now a monorepo that's written in TypeScript and includes direct support for more of the modern features: https://github.com/redis/node-redis/tree/master/packages
I'm not involved with either project, just a long time user, so I can only speculate as to the deprecation strategy, but once this supports sentinel (sounds like soon: https://github.com/redis/node-redis/issues/302#issuecomment-1930456228), I don't know of any other reason to continue using it.

Since redis is no longer FOSS starting with version 7.4 this
library might still be relevant in the future since I doupt that the offical redis client will address any issues
related to one of the redis forks.

Ups I totally missed that ioredis is also part of the redis org.

我是一名 Node.js 的初学者，感觉官方支持两个客户端库感觉很困惑，这个 issue 解惑了。希望官方在文档中能明确给初学者指出推荐的库。


Real-time name searchbox

As promised, here's a functioning searchbox.
Do note that the search is case-sensitive and strictly match from the start of fullname.
Known Issues

If there are no matches for the search, the PersonContactList Panel will break and turn white. This issue exist before this feature implementation
Currently another separate group of class is created to mirror the FindCommand, but as PartialFindCommand version. I have decide to brute force the implementation which closely resembles the FindCommand counterpart, but proper implementation using inheritance should streamline the code. Suggestions are most welcomed (since I couldn't find the way to go around parser)
Logging is very extensive and track every single changes in the searchbox field at the moment. Can be toned down per request
Additional unit tests have not been added since most of the implementation are done by recycling existing methods

Changes Unknown when pulling a1e209be3683a6a927a6b97020e7f391682195e0 on RSJunior37:feature-search into ** on CS2103AUG2017-T13-B1:master**.


[Op] Parallelize UnsortedSegment op.

Parallelize UnsortedSegmentSum on CPU deivce.
Under the same condition,  we can see the “parallel” way is more effective.

Op
Row
Col
S_id
T_nums

UnsortedSegmentSum
4096
1024
128
1

UnsortedSegmentSum
4096
1024
128
2

UnsortedSegmentSum
4096
1024
128
4

UnsortedSegmentSum
4096
1024
128
8

UnsortedSegmentSum
4096
1024
128
16

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

LGTM


getVisibleRange() returns invalid range when chart is scrolled to the left of the first historical bar

Lightweight Charts Version: 1.2.1
Steps/code to reproduce:
// scroll to the left of the first historical bar
const range = chart.timeScale().getVisibleRange();

Actual behavior:
Key from of variable range contains timestamp of the first historical bar.
Expected behavior:
Key from of variable range contains timestamp before timestamp of the first historical bar.

Key from of variable range contains timestamp before timestamp of the first historical bar.

Which one? The only we have here is bars you provided before, we don't approximate anything in the lightweight charts, so we can't predict the date. I guess we can return count of bars from left/right as well.

I'm going to close the issue. If you'll have any question or updates - feel free to re-open it.