Add service .new constructor

I think this is related to #58. Ernest told us that some folks may dislike the duplication of "Speech" in the following:
Google::Cloud::Speech::V1::Speech::Client.new

The current generator solves this by appending "Client: to the service:
Google::Cloud::Speech::V1::SpeechClient.new

But this change allows you to create a client object from the service module:
Google::Cloud::Speech::V1::Speech.new

The service module is where the Service class, the Stub constant, the Client class, and the Credentials class are all currently defined. I think there is some elegance to keeping them all in the service module, and using a .new method to get a client object.
In fact, I think the service module is the only place a .new method makes sense. Not at the version module (Google::Cloud::Speech::V1.new), and not at the package level (Google::Cloud::Speech.new).

Ah, I see. I agree that moving everything under the service module (i.e. Google::Cloud::Speech::V1::Speech) looks great and this change also makes the client match the fully qualified proto service path verbatim (which I also think is a big plus).
But, this doesn't remove the duplication and this doesn't make the clients backwards compatible (per #58). So, I'm in favor of this but I think we should resolve that issue first and fully commit to the service module concept. I don't see any reason to maintain backwards compatibility given the method signature changes in the new clients and I don't see any problems with the duplication since it's using the path + name without changes.
Other opinions?

I don't see any reason to maintain backwards compatibility given the method signature changes in the new clients

FWIW, I agree. We can always add backwards compatibility shims if that is really wanted.

I don't see any problems with the duplication since it's using the path + name without changes.

In the original showcase echo test that @quartzmo added, the line that created the client object was:
client = Google::Showcase::V1alpha3::Echo.new

When the showcase echo test was converted to the cloud generator I changed the line to:
client = Google::Showcase::V1alpha3::Echo::Client.new

This change allows it to go back to what it was. And it make sense IMO. A google/showcase/v1alpha3/echo.proto file that defines an Echo service currently generates the following files:

google/showcase/v1alpha3/echo_pb.rb
google/showcase/v1alpha3/echo_service_pb.rb
google/showcase/v1alpha3/echo_client.rb

I think it would be an improvement to generate this instead:

google/showcase/v1alpha3/echo_pb.rb
google/showcase/v1alpha3/echo_service_pb.rb
google/showcase/v1alpha3/echo.rb

I'm happy to drop the _client suffix, and that'll make it more consistent with this change.

k, I'll update this PR to change the filename as well.

Updated. Honestly, I like this change more than I thought I would. PTAL.

I like it. Tests are failing though so I think you missed a reference or two.

@blowmage What is the type returned by Google::Cloud::Speech::V1::Speech.new?

What is the type returned by Google::Cloud::Speech::V1::Speech.new?

It will return a Google::Cloud::Speech::V1::Speech::Client object.

Oops. Yeah, the showcase test wasn't updated to use the new client file path. Fixed now. 🤞


Cannot Add A Node

I cannot add 7th node to cluster. microk8s join command fails silently and that node stopped working.

Uploading inspection-report-20210210_054322.tar.gz…

@boraozturk thank you for reporting this one.
I can see from the apiserver logs that it is trying to connect to an etcd server at <IP_ADDRESS>:12379.
This usually happen only when one is using the non ha cluster.

Thanks for you answer @balchua
i've reinstalled microk8s multiple times and tried with different options (ha on/off, dns on/off). That log about etcd server must be one of my attempts.
Master
edevuser@meb-prod-mstr2:~$ sudo microk8s status
microk8s is running
high-availability: yes
  datastore master nodes: <IP_ADDRESS>:19001 <IP_ADDRESS>:19001 <IP_ADDRESS>:19001
  datastore standby nodes: <IP_ADDRESS>:19001 <IP_ADDRESS>:19001 <IP_ADDRESS>:19001
addons:
  enabled:
    dns                  # CoreDNS
    ha-cluster           # Configure high availability on the current node
    ingress              # Ingress controller for external access
  disabled:
    ambassador           # Ambassador API Gateway and Ingress
    cilium               # SDN, fast with full network policy
    dashboard            # The Kubernetes dashboard
    fluentd              # Elasticsearch-Fluentd-Kibana logging and monitoring
    gpu                  # Automatic enablement of Nvidia CUDA
    helm                 # Helm 2 - the package manager for Kubernetes
    helm3                # Helm 3 - Kubernetes package manager
    host-access          # Allow Pods connecting to Host services smoothly
    istio                # Core Istio service mesh services
    jaeger               # Kubernetes Jaeger operator with its simple config
    knative              # The Knative framework on Kubernetes.
    kubeflow             # Kubeflow for easy ML deployments
    linkerd              # Linkerd is a service mesh for Kubernetes and other frameworks
    metallb              # Loadbalancer for your Kubernetes cluster
    metrics-server       # K8s Metrics Server for API access to service metrics
    multus               # Multus CNI enables attaching multiple network interfaces to pods
    prometheus           # Prometheus operator for monitoring and logging
    rbac                 # Role-Based Access Control for authorisation
    registry             # Private image registry exposed on localhost:32000
    storage              # Storage class; allocates storage from host directory

Problem Node
edevuser@meb-prod-k8s-lb:~$ microk8s status
microk8s is running
high-availability: no
  datastore master nodes: <IP_ADDRESS>:19001
  datastore standby nodes: none
addons:
  enabled:
    ha-cluster           # Configure high availability on the current node
  disabled:
    ambassador           # Ambassador API Gateway and Ingress
    cilium               # SDN, fast with full network policy
    dashboard            # The Kubernetes dashboard
    dns                  # CoreDNS
    fluentd              # Elasticsearch-Fluentd-Kibana logging and monitoring
    gpu                  # Automatic enablement of Nvidia CUDA
    helm                 # Helm 2 - the package manager for Kubernetes
    helm3                # Helm 3 - Kubernetes package manager
    host-access          # Allow Pods connecting to Host services smoothly
    ingress              # Ingress controller for external access
    istio                # Core Istio service mesh services
    jaeger               # Kubernetes Jaeger operator with its simple config
    knative              # The Knative framework on Kubernetes.
    kubeflow             # Kubeflow for easy ML deployments
    linkerd              # Linkerd is a service mesh for Kubernetes and other frameworks
    metallb              # Loadbalancer for your Kubernetes cluster
    metrics-server       # K8s Metrics Server for API access to service metrics
    multus               # Multus CNI enables attaching multiple network interfaces to pods
    prometheus           # Prometheus operator for monitoring and logging
    rbac                 # Role-Based Access Control for authorisation
    registry             # Private image registry exposed on localhost:32000
    storage              # Storage class; allocates storage from host directory

edevuser@meb-prod-k8s-lb:~$   microk8s join <IP_ADDRESS>:25000/88a41b88c04a709a69fe554a64662ee4
Contacting cluster at <IP_ADDRESS>
Waiting for this node to finish joining the cluster. .. .. .. .. .. .. .. .. .. ..
edevuser@meb-prod-k8s-lb:~$ microk8s status
microk8s is not running. Use microk8s inspect for a deeper inspection.

Can you check on the node <IP_ADDRESS> the logs of cluster-agent.  journalctl -u snap.microk8s.daemon-cluster-agent. Hopefully we can find something.
Can you do microk8s inspect on the main node <IP_ADDRESS>?

<IP_ADDRESS> cluster agent logs > master.snap.microk8s.daemon-cluster-agent.log
<IP_ADDRESS> inspection >
inspection-report-20210211_171420.tar.gz

I couldn't find a clue as to why it couldn't join. 🙁 Will try to find more clues.

@boraozturk coming back to this issue, when you're trying to join the 7th node, does the cluster already have lots of workload running?
If yes, it maybe related to this issue.
https://github.com/canonical/dqlite/issues/282


goalng tools not installed on all OS's

Jack has fixed it so latest works so we can use "latest" for now until he has a tagged version.
go install github.com/jackmordaunt/icns/v2/cmd/icnsify@latest
go install github.com/jackmordaunt/icns/cmd/preview@latest

all good, so closing...


when to post('redirect-url') should call

Hi
i am trying to use this module ... i wrote get call '/make-payment ' and my question when to call redirect-url post method
Thanks in advance

hi im trying to call server
server.get('/make-payment', function(req, res) {
ccavenue.makePayment(res); // It will redirect to ccavenue payment
});
like this but i got cannot find module server in typescript

any  one  solve this   error ????


Missing bot detection for prerender.io's crawler

I'm more confident this time b/c the web demo doesn't detect the following as a bot, even though it is:
Prerender

... from prerender.io.
The web demo does detect the full user-agent because of "GitHub" and probably "HeadlessChrome":
Mozilla/5.0 (X11; Linux x86_64) AppleWebKit/537.36 (KHTML, like Gecko) HeadlessChrome/71.0.3578.98 Safari/537.36 Prerender (+https://github.com/prerender/prerender)

... but I figured it might be useful to also check for "Prerender" itself, in case the rest of the user-agent changes over time.

Fixed in #441


Upgrade Apache Commons Collections to v3.2.2

Version 3.2.1 has a CVSS 10.0 vulnerability. That's the worst kind of
vulnerability that exists. By merely existing on the classpath, this
library causes the Java serialization parser for the entire JVM process
to go from being a state machine to a turing machine. A turing machine
with an exec() function!
https://web.nvd.nist.gov/view/vuln/detail?vulnId=CVE-2015-8103
https://commons.apache.org/proper/commons-collections/security-reports.html
http://foxglovesecurity.com/2015/11/06/what-do-weblogic-websphere-jboss-jenkins-opennms-and-your-application-have-in-common-this-vulnerability/

Hi @bramp, I'm your friendly neighborhood Microsoft Pull Request Bot (You can call me MSBOT). Thanks for your contribution!

This seems like a small (but important) contribution, so no Contribution License Agreement is required at this point. Real humans will now evaluate your PR.

TTYL, MSBOT;


Custom object detection API for tensorflow 2.0 not working

The current Object detection API still has graphs and many code structures which are working only until version 1.15
Everywhere including colab it says support will only be for 2.0
Is there a timeline for the object detection API to be useful for tensorflow 2.0 for us to do custom object detection on our own datasets?

@sreeni5493 You can follow the following tutorial1 and tutorial2 to train your custom model using object detection API. If you have more questions, please post it in tensorflow/models repo as this issue is more apt there. Thanks!


set headers in Player

Hello, I wonder if there way to send headers (referrer or other) on the player.
Thank's

https://github.com/Bilibili/ijkplayer/issues/697


cannot run pip install git+https://github.com:IBM/tsfm.git

Coming here from blog: https://huggingface.co/blog/patchtsmixer
!pip install git+https://github.com:IBM/tsfm.git

in colab results in:
Collecting git+https://github.com:IBM/tsfm.git
  Cloning https://github.com:IBM/tsfm.git to /tmp/pip-req-build-ol1n83s1
  Running command git clone --filter=blob:none --quiet https://github.com:IBM/tsfm.git /tmp/pip-req-build-ol1n83s1
  fatal: unable to access 'https://github.com:IBM/tsfm.git/': URL using bad/illegal format or missing URL
  error: subprocess-exited-with-error

  × git clone --filter=blob:none --quiet https://github.com:IBM/tsfm.git /tmp/pip-req-build-ol1n83s1 did not run successfully.
  │ exit code: 128
  ╰─> See above for output.

  note: This error originates from a subprocess, and is likely not a problem with pip.
error: subprocess-exited-with-error

× git clone --filter=blob:none --quiet https://github.com:IBM/tsfm.git /tmp/pip-req-build-ol1n83s1 did not run successfully.
│ exit code: 128
╰─> See above for output.

note: This error originates from a subprocess, and is likely not a problem with pip.

Hi Thanks for alerting us about this. @vijaye12 @wgifford , there's a typo here, it should be
!pip install git+https://github.com/IBM/tsfm.git

Ah, hidden in the plain sight.


search_all_data_assets may not be working as expected

Describe the bug
Occasionally, duplicate results may return. The search_all_data_assets method uses pagination to return responses in chunks of 1000. We may need to double-check that.
To Reproduce
Hard to reproduce since it isn't consistent. Steps to reproduce the behavior:

Create a CodeOceanClient, co_client
Run response = co_client.search_all_data_assets()
Check the response
Can set log_level to info to see the exact queries being sent to the code ocean server.

Expected behavior
Each data asset in the results should be unique.
Screenshots
If applicable, add screenshots to help explain your problem.
Desktop (please complete the following information):

OS: [e.g. iOS]
Browser [e.g. chrome, safari]
Version [e.g. 22]

Smartphone (please complete the following information):

Device: [e.g. iPhone6]
OS: [e.g. iOS8.1]
Browser [e.g. stock browser, safari]
Version [e.g. 22]

Additional context
Add any other context about the problem here.

This appears to be an issue with the responses from CodeOcean. There is an open issue to fix the way the rest api handles requests to the elastic search index. Putting this in the blocked column for now.


Queries involving RateLimitTracker appear to be failing

I've had these queries running successfully for months, but they appear to have taken a turn south over the last day or so.  Queries involving RateLimitTracking throw an error of "Exception has been thrown by the target of an invocation".
I set up my Twitter service with a simple call like this:
RateLimit.RateLimitTrackerMode = RateLimitTrackerMode.TrackAndAwait;
            RateLimit.ClearRateLimitCache();

            TwitterCredentials twitterCredentials = new TwitterCredentials(TwitterConfiguration.ConsumerKey, TwitterConfiguration.ConsumerSecret,
                twitterApplicationCredential.Token, twitterApplicationCredential.TokenSecret);
            Auth.SetCredentials(twitterCredentials);

and then make a call to get user by ID.
This fails, returning an error of "Exception has been thrown by the target of an invocation." and a stack trace like this:
at System.RuntimeMethodHandle.InvokeMethod(Object target, Object[] arguments, Signature sig, Boolean constructor)
   at System.Reflection.RuntimeMethodInfo.UnsafeInvokeInternal(Object obj, Object[] parameters, Object[] arguments)
   at System.Reflection.RuntimePropertyInfo.GetValue(Object obj, Object[] index)
   at Tweetinvi.Credentials.RateLimit.RateLimitHelper.GetEndpointRateLimitFromQuery(String query, ICredentialsRateLimits rateLimits, Boolean createIfNotExist)
   at Tweetinvi.Credentials.RateLimit.RateLimitCacheManager.GetQueryRateLimit(String query, ITwitterCredentials credentials)
   at Tweetinvi.WebLogic.TwitterRequestHandler.TryPrepareRequest(IHttpRequestParameters requestParameters, RateLimitTrackerMode rateLimitTrackerMode, ITwitterCredentials credentials, Boolean raiseEvents, ITwitterQuery& twitterQuery)
   at Tweetinvi.WebLogic.TwitterRequestHandler.ExecuteQuery(String queryURL, HttpMethod httpMethod, TwitterClientHandler handler, ITwitterCredentials credentials, HttpContent httpContent)
   at Tweetinvi.Credentials.TwitterAccessor.ExecuteQuery(String query, HttpMethod method, HttpContent httpContent, Boolean forceThrow)
   at Tweetinvi.Credentials.TwitterAccessor.ExecuteGETQuery[T](String query, JsonConverter[] converters)
   at Tweetinvi.Factories.User.UserFactoryQueryExecutor.GetUserDTOFromId(Int64 userId)
   at Tweetinvi.Factories.User.UserFactory.GetUserFromId(Int64 userId)
   at CloudScope.Social.Services.Twitter.TwitterService.GetUser(Int64 accountId) in D:\src\CloudScope.Social\CloudScope.Social.Services\Twitter\TwitterService.cs:line 146
   at CloudScope.Social.Agent.Tasks.AccountTask.<RunTaskAsync>d__3.MoveNext() in D:\src\CloudScope.Social\CloudScope.Social.Agent\Tasks\AccountTask.cs:line 111

when I switch the RateLimitTrackerMode to RateLimitTrackerMode.None, the call completes successfully.

Same here, i am using tweetinvi from last three months, My code was working fine but now it is throwing exception when my code is going to track Rate Limit on following line.
RateLimit.RateLimitTrackerMode = RateLimitTrackerMode.TrackOnly;
var rateLimits = RateLimit.GetCurrentCredentialsRateLimits();

ERROR:
Exception has been thrown by the target of an invocation
@linvi please look into this.
Kind Regards

I duplicated this by modifying the Examplinvi.NETStandard sample to look like this:
'''
RateLimit.RateLimitTrackerMode = RateLimitTrackerMode.TrackAndAwait;
var authenticatedUser = User.GetAuthenticatedUser();
        Console.WriteLine(authenticatedUser);

'''
In CredentialsRateLimits.cs, line 45, every property on _resources is null, including AccountRateLimits.

Thank you for reporting it. I will be having a look tonight.

same problem
i was going mad since yesterday to solve this problem :/

Hi,
The Twitter API is now returning the credentials once again.
Though, I will make Tweetinvi more robust and flexible in case this was to happen again.
As Twitter is back on, I consider that this issue does not require a "rushed" fix and I will issue it as part of Tweetinvi 6.0.
Thank you for your understanding.
If you do encounter this issue once again, I will prioritize this task.
Cheers,
Linvi
NOTES FOR FUTURE FIX :
Json received from https://api.twitter.com/1.1/application/rate_limit_status.json
{
  "rate_limit_context": {
    "access_token": "___"
  },
  "resources": {  }
}


Fix getTypedValue for booleans.

xs:boolean is either 'true' or 'false', but since bool('false') returns
True, we better check if the string equals 'true'.

Roel,
consider using https://docs.python.org/2/distutils/apiref.html?highlight=distutils.util#distutils.util.strtobool

My old comment was wrong  (as xsd forces either true or false). This should be merged - it is wrong in the old code.


How to change max detection box number in testing time

In my project,the max number of box is 150 over 100 regular number.And I have changed the max_per_image number in cfg file but there is no difference in testing showing maxDet 100.Why?

Can you provide the config of models?


How to add yasumi to laravel?

The Yasumi  class is a simple factory class that you can use anywhere in your Laravel application, e.g. the controllers, models, or other classes.
Another possibility is to register it in your Service Provider class so it is available everywhere in your application.

In case you're looking for a Laravel package, there is one created by somebody in the community: https://github.com/blood72/laravel-yasumi. Although I haven't used it myself, it may be what you're looking for.
Cheers! Sacha


Wrong order of style elements on react-fela

Type: Bug

Packages
Version

react-fela
7.x.x

Description
When you create components using createComponent or createComponentWithProxy and your renderer is enhanced with fela-monolithic the order of the style elements is wrong, this is explicitly obvious when you're using media queries:

So the style element with no media query is created after all the media queries, this results on the layout breaking.
On react-fela 6.x.x the style elements are created this way:

Giving us a fully functional layout.

Steps to reproduce
Your component
const rule = () => ({
  width: '100%',
  height: '100%',

  '@media (min-width: 768px)': {
    width: 700
  },
  '@media (min-width: 1024px)': {
    width: 1000
  }
})

const ResponsiveComponent = createComponent(rule, 'div')

Your renderer
import monolithic from 'fela-monolithic'

const config = {
  enhancers: [ monolithic() ]
}

const renderer = createRenderer(config)

This should be fixed as soon as #573 merged.
But keep in mind that fela-monolithic is not intended to be used in production. It does not guarantee that everything works perfectly in production.

Would be great to retry this now.

@rofrischmann Still the same issue after upgrading fela...
Here's my renderer:
const renderer = createRenderer({
  plugins: [embedded(), prefixer(), fallbackValue()],
  mediaQueryOrder: [
    '@media only screen and (min-width:0px)',
    '@media only screen and (min-width:320px)',
    '@media only screen and (min-width:768px)',
    '@media only screen and (min-width:1024px)',
    '@media only screen and (min-width:1200px)',
  ],
});

Here's the result:

The same happens if I remove mediaQueryOrder completely, so I'm wondering maybe it's something wrong in our implementation. 🤔
With the older fela version, I manage to figure out a work around for this, that was to declare all breakpoints in at least 1 component's rule, so the order would be right, but after the upgrade, that solution isn't working anymore...


Bump SearchGUI and PeptideShaker

depends on https://github.com/bioconda/bioconda-recipes/pull/28155

[x] I will tests this locally before merging the bioconda recipe
[ ] we could enable metamorpheus https://github.com/galaxyproteomics/tools-galaxyp/blob/d8d9887e20120bb93f49de9e3460f95d385575bb/tools/peptideshaker/searchgui.xml#L190 but I would suggest to install it via a requirement in the recipe and the remove the packaged MM

Closed in favor of https://github.com/galaxyproteomics/tools-galaxyp/pull/594


VSCode does not identify fonts with special characters in it

VSCode Version: Code 1.16.0 (787b31c0474e6165390b5a5989c9619e3e16f953, 2017-09-06T16:19:37.192Z)
OS Version: Linux x64 4.12.13-300.fc26.x86_64
Extensions:

Extension
Author (truncated)
Version

react-native-react-redux
EQu
1.4.0

vsc-material-theme
Equ
1.0.2

beautify
Hoo
1.1.1

vim
vsc
0.10.1

vscode-react-native
vsm
0.4.2

Steps to Reproduce:

Install Anka Coder Condensed Font
Try to set the Font to 'Anka/Coder Condensed Font'  - https://fontlibrary.org/en/font/anka-coder-condensed
The font does not change

Reproduces without extensions: Yes

@aswinmohanme Sometimes Chromium caches font information and we need to be restarted after installing a font.
Also, this is very sensitive to exact name matching. If the font name has spaces, you can use extra 's. i.e.
"editor.fontFamily": "'Arial Narrow'",

Adding a ' inside " seemed to fix the issue. Thanks


Change check for missing climo years

Closes #149
This will now change how the script deals with unspecified climo start and end years in the config file.
Changes
Prior to this change, the script would fail at the case_name var in the lib/adf_diag script if the climo years were not specified in the config file. This instead will check if either the start or end year are NoneType and handle them accordingly.
A warning message was also added, but can be removed if deemed unnecessary.

This is still in progress, ran into some last minute problems when trying it on the multi-case examples. Stay tuned.


Added @thewchan as maintainer

Checklist

[x] Used a personal fork of the feedstock to propose changes
[x] Bumped the build number (if the version is unchanged)
[x] Reset the build number to 0 (if the version changed)
[x] Re-rendered with the latest conda-smithy (Use the phrase @conda-forge-admin, please rerender in a comment in this PR for automated rerendering)
[x] Ensured the license file is being packaged.

I'd like to add myself as a maintainer as I needed to add a past version of titlecase to conda-forge as dependencies for another package.

Hi! This is the friendly automated conda-forge-linting service.
I wanted to let you know that I linted all conda-recipes in your PR (recipe) and found some lint.
Here's what I've got...
For recipe:

noarch: python recipes are required to have a lower bound on the python version. Typically this means putting python >=3.6 in both host and run but you should check upstream for the package's Python compatibility.

Hi! This is the friendly automated conda-forge-linting service.
I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

@conda-forge-admin, please rerender

@brocksam All checks has pass. Thanks for considering

@conda-forge/core Please help review this, thanks.


Remove calculate output shape from java side

Mostly fixes #7901.
A few ops have issues that prevent removing the method now (#8131, #8129, #8128).
"Fake" Java-only ops have a calculateOutputShape that throws a UnsupportedOperationException.  Doing this in a method needed in each op isn't ideal, if there's an easy way to detect "fake" ops that would be easier, but I'm not aware of one.

Also note there is a test for cast on an empty array that NPEs.  I think its due to not having offline shape inference rather than a cast issue, but its worth taking a look at.
https://github.com/SkymindIO/deeplearning4j/blob/703de772ee4fd3f01eafbb51c0ea20415f103360/nd4j/nd4j-backends/nd4j-tests/src/test/java/org/nd4j/autodiff/samediff/SameDiffTests.java#L3557-L3566


ci: improve parallelism, add windows for e2e tests

Description of changes
This PR accomplishes two major goals that improve our CI process:

Windows coverage is added
Multi-account AWS Organization strategy is used to enable scalable parallelization of tasks

Many windows tests are skipped for now (excluded via split-e2e-tests script), since there are issues with the test harness compatibility that will need to be addressed one by one. Still, even minimal windows coverage is a huge improvement from the zero automated coverage we have today.
Multi-account scalability is really nice. Currently, only five child accounts are being used, but that number can be scaled at will to whatever number we please (within AWS Organization resource limits for child accounts). Five accounts is enough for us to run all e2e tests simultaneously without incident (though rate limit issues can still develop if all tests are run multiple times simultaneously). Hopefully this makes shepherding releases a bit less painful.
Description of how you validated changes
See https://app.circleci.com/pipelines/github/aws-amplify/amplify-cli/2764/workflows/bc163b82-bb01-404e-826d-902bee01f129
Checklist

[x] PR description included
[x] yarn test passes
[x] Tests are changed or added

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Codecov Report

Merging #8282 (41263c5) into master (f2fa479) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #8282   +/-   ##
=======================================
  Coverage   55.66%   55.66%
=======================================
  Files         691      691
  Lines       38542    38542
  Branches     7811     7811
=======================================
  Hits        21456    21456
  Misses      16296    16296
  Partials      790      790

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f2fa479...41263c5. Read the comment docs.

Also, what's the story on resource cleanup with this change? Does the automated cleanup that runs in CCI still work? When we need to manually clean resources will we have to assume a role in each child account to clean up?

Also, what's the story on resource cleanup with this change? Does the automated cleanup that runs in CCI still work? When we need to manually clean resources will we have to assume a role in each child account to clean up?

https://github.com/aws-amplify/amplify-cli/pull/8082 can be merged independently (I hoped it would be by now)


sqlclosecheck enabled

I hereby agree to the terms of the CLA available at: https://yandex.ru/legal/cla/?lang=en

Pull request type

Please check the type of change your PR introduces:

[ ] Bugfix
[ ] Feature
[x] Code style update (formatting, renaming)
[x] Refactoring (no functional changes, no api changes)
[x] Build related changes
[ ] Documentation content changes
[ ] Other (please describe):

What is the current behavior?

Issue Number: #965
What is the new behavior?

Other information

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (0480caf) 67.63% compared to head (52cde98) 38.50%.

Additional details and impacted files
@@             Coverage Diff             @@
##           master     #979       +/-   ##
===========================================
- Coverage   67.63%   38.50%   -29.13%
===========================================
  Files         261      207       -54
  Lines       24687    21411     -3276
===========================================
- Hits        16697     8245     -8452
- Misses       7128    12818     +5690
+ Partials      862      348      -514

Flag
Coverage Δ

?

go-1.17.x
38.50% <ø> (-27.47%)
:arrow_down:

go-1.20.x
?

go-1.21.x
?

integration
?

macOS
?

ubuntu
38.50% <ø> (-0.33%)
:arrow_down:

unit
38.50% <ø> (-0.41%)
:arrow_down:

windows
?

ydb-22.5
?

ydb-23.1
?

ydb-23.2
?

ydb-23.3
?

Flags with carried forward coverage won't be shown. Click here to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


haskellPackages.ghc: 9.4.6 -> 9.4.7 (backport) [23.05]

Description of changes
Original PR: https://github.com/NixOS/nixpkgs/pull/252362
Original commit: 32c1a8c383fdff0d6647b0d9cfe3d9bb3afa3fd2
Things done

Built on platform(s)

[X] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)

[ ] sandbox = relaxed
[ ] sandbox = true

[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
23.11 Release Notes (or backporting 23.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[X] Fits CONTRIBUTING.md.

@thomasjm Could you make sure your commit titles match the format recommended in https://github.com/NixOS/nixpkgs/blob/master/CONTRIBUTING.md#commit-conventions
Or, just squash these two commits into one

Squash is done.

Let's make sure some things still build:
@ofborg build haskell.packages.ghc947.conduit

@thomasjm Okay, looks like at least conduit builds with ghc947, which is a good sign.
However, it looks like there is an ofborg eval error: https://gist.github.com/GrahamcOfBorg/90e93cab7244d458cd22b68a9bb7507e
Could you take a look at why this is occurring?  We definitely don't want to introduce new eval errors onto a release branch.

I fixed the path in 9.4.7.nix to this file: Cabal-3.6-paths-fix-cycle-aarch64-darwin.patch
@ofborg build haskell.packages.ghc947.conduit

Okay, eval passes, and it builds on linux.
LGTM, thanks for this backport!


Missing 2 Files

Everything worked perfectly until it came time to build. Here are the errors:
Build input file cannot be found: '/Users/Username/Documents/GIOVANNI/gambatte/common/videolink/vfilters/maxsthq3x.cpp'
Build input file cannot be found: '/Users/Username/Documents/GIOVANNI/gambatte/libgambatte/src/statesaver.cpp'
I didn't move any files and only followed the directions carefully. Please help!

You need to generate an SSH key and connect it to your GitHub account.
Instructions: GitHub docs
To connect your GH acc: RedmondPie
(Skip to Step 4)
Then after connecting your SSH key to GH, you need to use git to clone the repo. Start from Step 7 from the above link.
The command they use didn't work for me, so I had to run:
git clone git@github.com:gabrieloc/GIOVANNI.git --recursive
And then it pulled all the files in the repo.
Then you need to change all bundle ID's in Xcode. See the repo's readme (the "installation" section, skip the command) and this GH issue (you need to change this or the build will fail).
Then it should compile successfully.


fix(http-trigger-v4): make the parseCookie function be case sensitive

Description of change
Accords this issue on Stack Overflow, cookie keys should be case-sensitive.
In the previous code, I changed the key putting in lowercase and trim.

Pull-Request Checklist

[x] Code is up-to-date with the main branch
[x] npm run lint passes with this change
[x] npm run test passes with this change
[x] This pull request links relevant issues as Fixes #0000
[x] There are new or updated unit tests validating the change
[x] Added documentation inside www/docs/main folder.
[x] Included new files inside index.doc.ts.
[x] The new commits follow conventions outlined in the conventional commit spec

Codecov Report

Merging #33 (0092124) into main (60f8f60) will not change coverage.
The diff coverage is 100.00%.

@@            Coverage Diff            @@
##              main       #33   +/-   ##
=========================================
  Coverage   100.00%   100.00%
=========================================
  Files           38        38
  Lines          960       960
  Branches       227       227
=========================================
  Hits           960       960

Impacted Files
Coverage Δ

src/adapters/azure/http-trigger-v4.adapter.ts
100.00% <100.00%> (ø)

:mega: Codecov can now indicate which changes are the most critical in Pull Requests. Learn more


[Android] .NET 6 build/deploy performance should match Xamarin

.NET 6 build/deploy performance is already pretty close to existing Xamarin.Android.
Example of a "hello world" app:

More commentary in Teams here.
We have Github issues tracking the current gaps we have:

https://github.com/xamarin/xamarin-android/issues/5374
https://github.com/xamarin/xamarin-android/issues/5436

I have seen slightly faster build/deploy times with .NET 6 if I use --no-restore and a single $(RuntimeIdentifier). Completing the above work items would get the performance we want for default scenarios in IDEs.

I think the referenced issues are completed in .NET 6 Preview 3, going to close.


Mixing cucumber and regular expressions

It is not possible to write a step definition including both a cucumber expression and a regular expression, e.g.
  @When("^I buy a book with title ([\\w]+) and author {string}$")

Is there a reason why this isn't possible? Are there any plans on making it possible?

A Regular Expression is a language of its own, with a well-defined grammar. Regular Expressions are parsed with the programming language's Regular Expression parser, which is part of most programming languages' standard library.
A Cucumber Expression is also a language of its own, with a well-defined grammar. Cucumber Expressions are parsed with the Cucumber Expressions parser.

Is there a reason why this isn't possible?

Yes. The reason is that they are different languages, with different grammars and different parsers. A parser can only parse one language. You cannot mix Java and C# in the same file and expect a parser to parse it. You cannot mix French and Finnish in the same sentence and expect it to make sense. And you cannot mix Cucumber Expressions and Regular Expressions in the same string and expect a parser to understand it.

Are there any plans on making it possible?

No.


db/schema.rb fall back to db/structure.sql

Have a Rails app or two that's needed to switch to SQL dump.

@croaky, is this meant to say falling back from db/schema.rb to structure?

@geoffharcourt Yup, good call, updated.

Derp. We read from config/database.yml, don't need to fall back when schema structure type changes.


Add Management SDK for Microsoft.DevCenter

Adding mangement SDK Azure.ResourceManager.DevCenter for the Microsoft.DevCenter RP - this is currently in public preview.
Contributing to the Azure SDK
Please see our CONTRIBUTING.md if you are not familiar with contributing to this repository or have questions.
For specific information about pull request etiquette and best practices, see this section.

@ArthurMa1978 thanks for the feedback, I've updated as per your comments.

/azp run prepare-pipelines

/azp run net - devcenter - mgmt

API change check
APIView has identified API level changes in this PR and created following API reviews.
Azure.ResourceManager.DevCenter

Please run the eng\scripts\Update-Snippets.ps1 devcenter to generate the apiview file

/azp run net - devcenter - mgmt

@tbyfield just realized there is a new process run, please run eng/scripts/Update-Mgmt-CI.ps1 to update the ci setting for a new sdk


P100 and P115

I tried a P100 and a P115 EU models and both of them are not connecting to Companion, should they? Maybe on the US models are working?

I use the EU models P110 and P115, and its almoust always working :).

These are both upgrade to firmware version 1.3 and when info into a browser (on the same pc as companion) to the IP address of the Tapo's I get 200 OK reaction.
question in the module I only did fill the field of the IP address. Is this sufficient?

Maybe check what version firmware @MarekPro1  is running. I’ve heard newer firmware’s do not work.

I am using 1.30 firmware and the newest beta companion but I would not recomend it. (i dont know how to add the tapo plugin to the stable version😔)

I just got a Tapo  p100 with firmware 1.2.5 Build 24011Rel.143808 running Companion 3.99.0 (3.99.0+7112-develop-daad9b55) and the tplink-taposmartplug configuration hangs on connecting.
24.08.10 12:29:10 Instance/Controller: Adding connection tplink-kasasmartplug Kasa Smart Plug
24.08.10 12:29:10 Instance/ModuleHost: Starting connection: "tplink-kasasmartplug"(a50RwXXj9ZsNXFGuSg_wl)
24.08.10 12:29:10 Instance/Wrapper/tplink-kasasmartplug: Starting Update Interval.
24.08.10 12:29:24 Instance/Wrapper/tplink-kasasmartplug: Stopping Update Interval.
24.08.10 12:29:24 Instance/Wrapper/tplink-kasasmartplug: Starting Update Interval.
24.08.10 12:29:44 Instance/Wrapper/tplink-kasasmartplug: Error: TCP Timeout after 20000ms
<IP_ADDRESS>:9999 {"system":{"get_sysinfo":{}}}


Adding support for net 7.0

Since net8.0 is in preview, we have added support for net7.0 to be able to have access to some of new APIs.When Net8 is released net7.0 will be replaced with net8.0 for GA release.

@JRahnama nice to see this... Out of curiosity, which .NET 7.0 features are you specifically looking at?

@roji, the goal is to be able to completely eliminate the SqlTypeWorkarounds.cs file for Net 8 and greater versions, but since Net 8 is still in preview stage we decided to go by Net7.0 for preview releases and when net8 GA version is released replace Net7.0 with Net8.

once this is merged if you change the net8 to net7 in my PR https://github.com/dotnet/SqlClient/pull/1934 then new paths should light up and remove the unneeded workarounds.


Key inside a json value is replaced by columnName of another attribute

I have a model User defined as:
{
  ...
 phone: {
    type: 'string',
    columnName: 'ph'
  },
  prefer_ship_address: {
    type: 'json',
    columnName: 'ps'
  },
...
}

When I try to update prefer_ship_address, I find the key name 'phone' inside the value of the prefer_ship_address is replaced by 'ph'. For example, if I update prefer_ship_address with value
{
  name: 'foo',
  address: 'bar',
  phone: '11111111111'
}

, then I print input values of update function in the adapter
{
  updatedAt: Mon Feb 22 2016 14:25:32 GMT-0600 (CST),
  ps:
    {
      name: 'foo',
      address: 'bar',
      ph: '1111111111'
    }
}

@wulfsolter @Bangsheng @athieriot @particlebanana Hey everyone, we're currently moving all the Waterline cases to Sails for Github issues.  I see this one was potentially resolved with a patch to Waterline at the time. I appreciate the efforts! Feel free to update us if anything remains of the issues. Thanks!

This has been published.


How to process the third-party data?

I think the tagged_reference.txt is the math reference data from https://people.cs.umass.edu/~mccallum/data/cora-refs.tar.gz, i am wondering whether the data need process or the script can run with raw data?

I have provided a version of the data already. It is probably identical to the one you linked to but I haven't checked. You could diff the two files.
All of the processing is in the training script.

Thank you, i havnot notice the data path, they looks like identical

And one more question, is there some blog or material about the CRF implementation from scrath?

I have a blog post on CRFs which may have some useful references for you.

Appreciate your work, thanks


Nested requred properties

Here's an attempt to solve this issue.  I added specs for various scenarios and used my fork to generate our docs.
I made some assumptions that may not be kosher, such as requiring a parent attribute requires all the nested attributes.
Regardless, this should get the dialogue going. :smile:

taps mic Is this thing on? :wink:

:+1:

Sorry for the delay, I was on vacation (and subsequently struggling to play catch up).

Overall looking good, but could you maybe take out the whitespace changes in lib/prmd/templates/schemata/helper.erb? It would make the spacing inconsistent (and makes the patch noisier/harder to see what is actually changing). I think beyond that I'll probably need to test a little, but then we should be able to bring this in. Thanks!

Hey @geemus, no worries on the delay, I get it. :)  I put that helper file back where I found it, so should be good to go now.

Thanks!


Not getting the example for persistant schedules.

Sorry, but I'm thick.
If I have more than 1 schedule (say 2 to keep it simple) and the machine is rebooted/reset/what ever.
The file saved has both schedules and I select which one is active.
Does this recent update (1.16.2) allow you to select which of the 2 schedules is activated?
I saw the news and that it has the ability to reload the schedule after a restart, thinking it meant it also selected the desired schedule also.

Ok, here is a bigger picture of the problem as I see it:
[{"id":"e7b39ace.a09d2","type":"link in","z":"6dd5ca4d.d1958c","name":"Boot signal","links":["6448f189.7ce318"],"x":610,"y":4680,"wires":[["d54212c1.226718"]],"l":true},{"id":"d54212c1.226718","type":"delay","z":"6dd5ca4d.d1958c","name":"","pauseType":"delay","timeout":"1","timeoutUnits":"minutes","rate":"1","nbRateUnits":"1","rateUnits":"second","randomFirst":"1","randomLast":"5","randomUnits":"seconds","drop":false,"outputs":1,"x":725,"y":4680,"wires":[["b5a97d4f.84ed58"]],"l":false},{"id":"b5a97d4f.84ed58","type":"function","z":"6dd5ca4d.d1958c","name":"build message","func":"var path = global.get(\"event_paths\");\nmsg.filename = path + \"plants.txt\";\nreturn msg;","outputs":1,"noerr":0,"initialize":"","finalize":"","x":880,"y":4680,"wires":[["82e4dfc5.1ba768"]]},{"id":"82e4dfc5.1ba768","type":"file in","z":"6dd5ca4d.d1958c","name":"Plants","filename":"","format":"utf8","chunk":false,"sendError":false,"encoding":"none","x":850,"y":4730,"wires":[["46e58700.dc6b38"]]},{"id":"46e58700.dc6b38","type":"ui_time_scheduler","z":"6dd5ca4d.d1958c","group":"c0eea23d.14fd5","name":"Plants","refresh":"60","devices":["Daily","Away"],"customPayload":false,"eventMode":false,"outputs":3,"order":11,"width":"6","height":"1","x":1040,"y":4730,"wires":[["39958344.67685c"],["4e17f8ac.78c5c8","8a49b79e.e2e9d"],["4e17f8ac.78c5c8","c133b660.f9987"]]},{"id":"c0eea23d.14fd5","type":"ui_group","name":"Automatic plant watering","tab":"e92ac76d.c24e7","order":12,"disp":true,"width":"6","collapse":false},{"id":"e92ac76d.c24e7","type":"ui_tab","name":"Real_World_Control","icon":"dashboard","order":14,"disabled":false,"hidden":false}]

and this is the file:
{"timers":[{"starttime":1606528500000,"days":[1,1,1,1,1,1,1],"output":"0","endtime":1606529100000},{"starttime":1616723700000,"days":[0,0,1,0,1,0,1],"output":"1","endtime":1616724300000}]}

I want 'Daily' selected on reboot.
Otherwise nothing is active.


Fixed terminal copying bug

I added logging to see why only the SyntaxError: invalid syntax was being printed
getTerminalContents called with commands: 1 extensionHostProcess.js:63105 Initial clipboard contents saved. extensionHostProcess.js:63105 Selecting the last 1 commands from the terminal. extensionHostProcess.js:63105 Copying selected text from terminal. extensionHostProcess.js:63105 Terminal contents copied: nathanan@Nathans-MacBook-Air  ~/Documents/working-dir/pearai-app/extensions/pearai-submodule/extensions/vscode   main ±  cd ..  nathanan@Nathans-MacBook-Air  ~/Documents/working-dir/pearai-app/extensions/pearai-submodule  nathanan@Nathans-MacBook-Air  ~/Documents/working-dir/pearai-app/extensions/pearai-submodule   main ±  python3 extensions/vscode/pearai_tutorial.py   File "/Users/nathanan/Documents/working-dir/pearai-app/extensions/pearai-submodule/extensions/vscode/pearai_tutorial.py", line 63     print_list(["a", "b", "c"])``                                ^ SyntaxError: invalid syntax  ✘ nathanan@Nathans-MacBook-Air  ~/Documents/working-dir/pearai-app/extensions/pearai-submodule   main ±  extensionHostProcess.js:63105 Restored clipboard contents. extensionHostProcess.js:63105 Splitting terminal contents into lines: (8) ['nathanan@Nathans-MacBook-Air  ~/Documents/workin…i-submodule/extensions/vscode   main ±  cd ..', ' nathanan@Nathans-MacBook-Air  ~/Documents/working-dir/pearai-app/extensions/pearai-submodule', ' nathanan@Nathans-MacBook-Air  ~/Documents/worki…±  python3 extensions/vscode/pearai_tutorial.py', '  File "/Users/nathanan/Documents/working-dir/pea…e/extensions/vscode/pearai_tutorial.py", line 63', '    print_list(["a", "b", "c"])``', '                               ^', 'SyntaxError: invalid syntax', ' ✘ nathanan@Nathans-MacBook-Air  ~/Documents/wor…rai-app/extensions/pearai-submodule   main ± '] extensionHostProcess.js:63105 Last line extracted: ✘ nathanan@Nathans-MacBook-Air  ~/Documents/working-dir/pearai-app/extensions/pearai-submodule   main ±  extensionHostProcess.js:63105 Manually adjusted terminal contents: SyntaxError: invalid syntax
So there's a bug in continue's code
there's 2 issues when running in PearAI:

sometimes theres special charaters, like an x indicating error at the start of a line
if i == -1, we take the last element of the array , which is unintended - what is intended is that we take the entire array if we get to i==-1

this commit fixes both. why does this work in continue? no clue :O but logically it doesnt work in pearai and it's being observed. this fixes it 🎆

confirmed working


Fix a UTC Time conversion bug

The UTC time offset is currently converted straight to a DateTime in the computer's local timezone. It is then passed into the CognitoUserSession constructor, where it is converted to a universal time.
If you're in a timezone +'ve of UTC this means that IsValid on the CognitoUserSession will always return false, which breaks a number of other methods in the User Manager (anything that checks for authentication).
Issue #, if available:
On Line 168 of CognitoUserManager this line of code exists:
user.SessionTokens = new CognitoUserSession(idToken, accessToken, refreshToken, result.Properties.IssuedUtc.Value.DateTime, result.Properties.ExpiresUtc.Value.DateTime);
This writes the UTC time into a local time, and then the CognitoUserSession constructer makes that local time a UTC time. This means that the time written to the CognitoUserSession for token expiry is incorrect, and if you're in a positive timezone, it means IsValid won't return true.
Description of changes:
Fixed this time conversion bug by changing .Value.DateTime to .Value.UtcDateTime.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

PR has been released as part of version 3.0.1. Thanks for the PR!


issue with client connection order in gribigo_compliance_test.go

I see some times the test "TestParamsDifferFromOtherClients" in election.go fails due to client connection order. I see some times client B sends requests modify request first and clientA modify request fails so better to add the client A validation before sending Client B modify request that would avoid random failures due to timing issues .
moving  below code from line 164 to 157 will help to fix the timing issue
'''
clientAErr := awaitTimeout(context.Background(), clientA, t, time.Minute)
if err := clientAErr; err != nil {
t.Fatalf("did not expect error from server in client A, got: %v", err)
}
'''

@bstoll  , i believe you are looking into  gribigo_compliance_test.go , could you please help to push this change?

created PR for gribigo https://github.com/openconfig/gribigo/pull/155


Add xms-ids for RecoveryServices

MSFT employees can try out our new experience at OpenAPI Hub  - one location for using our validation tools and finding your workflow.

Changelog
Add a changelog entry for this PR by answering the following questions:

What's the purpose of the update?

[ ] new service onboarding
[ ] new API version
[ ] update existing version for new feature
[ ] update existing version to fix swagger quality issue in s360
[x] Other, please clarify

About this Change
APIs will need to start indicating item uniqueness in arrays. By default, uniqueness is the string property called "id" of items in an array. When that property does not exist, the x-ms-identifiers extension property must be used to specify the identifying property(s) or lack thereof. This pull request is my best guess effort to ease resource providers into the new requirement before it becomes enforced. Compliance and accuracy will need to be owned and maintained by the resource provider going forward.
See https://github.com/Azure/autorest/tree/main/docs/extensions#x-ms-identifiers.
You can also make changes after this PR is checked in. At this point, this annotation is only used by Change Analysis for change computation, so making changes afterwards shouldn’t be a breaking change.

When are you targeting to deploy the new service/feature to public regions? Please provide the date or, if the date is not yet available, the month.
When do you expect to publish the swagger? Please provide date or, the the date is not yet available, the month.
If updating an existing version, please select the specific language SDKs and CLIs that must be refreshed after the swagger is published.

[ ] SDK of .NET (need service team to ensure code readiness)
[ ] SDK of Python
[ ] SDK of Java
[ ] SDK of Js
[ ] SDK of Go
[ ] PowerShell
[ ] CLI
[ ] Terraform
[x] No refresh required for updates in this PR

Contribution checklist:

[x] I commit to follow the Breaking Change Policy of "no breaking changes"
[x] I have reviewed the documentation for the workflow.
[x] Validation tools were run on swagger spec(s) and errors have all been fixed in this PR. How to fix?

If any further question about AME onboarding or validation tools, please view the FAQ.
ARM API Review Checklist

Applicability: :warning:
If your changes encompass only the following scenarios, you should SKIP this section, as these scenarios do not require ARM review.

Change to data plane APIs
Adding new properties
All removals

Otherwise your PR may be subject to ARM review requirements. Complete the following:

[ ] Check this box if any of the following apply to the PR so that label "WaitForARMFeedback" will be added automatically to begin ARM API Review. Failure to comply may result in delays to the manifest.

Adding a new service
Adding new API(s)
Adding a new API version
-[ ] To review changes efficiently, ensure you are using OpenAPIHub to initialize the PR for adding a new version. More details, refer to the wiki.

[ ] Ensure you've reviewed following guidelines including ARM resource provider contract and REST guidelines. Estimated time (4 hours). This is required before you can request review from ARM API Review board.

[ ] If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.

Breaking Change Review Checklist
If any of the following scenarios apply to the PR, request approval from the Breaking Change Review Board as defined in the Breaking Change Policy.

[ ] Removing API(s) in a stable version
[ ] Removing properties in a stable version
[ ] Removing API version(s) in a stable version
[ ] Updating API in a stable or public preview version with Breaking Change Validation errors
[ ] Updating API(s) in public preview over 1 year (refer to Retirement of Previews)

Action: to initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Addition details on the process and office hours are on the Breaking change Wiki.
Please follow the link to find more details on PR review process.

Hi @amchandn, I see you have contributed to RecoveryServices earlier. If you are on the RP team, could you please help me with a code review? Thanks!

@changlong-liu there are only a few lines of change in this PR and all the xms-ids look intuitive. I wonder if you could help with a code review and merging the PR. Thanks!

Hi @ArcturusZhang , would you help review the reported GoLang breaking change?

Hi @amchandn, I see you have contributed to RecoveryServices earlier. If you are on the RP team, could you please help me with a code review? Thanks!

Hi @LinglingTong , sorry for the delayed response. Can you please tell why this change is needed?
Adding @asmaskar and<EMAIL_ADDRESS>as they're from the RP team.

https://github.com/Azure/autorest/tree/main/docs/extensions#x-ms-identifiers.

Thanks for Looking at it @amchandn. The x-ms-identifiers is a new annotation introduced end of last year, and is currently used by change analysis team to identify the unique identifiers of an object type array. See  https://github.com/Azure/autorest/tree/main/docs/extensions#x-ms-identifiers. Our team is currently initializing this annotation for all the RPs and would like the owner team to help us with reviewing the change. You can also make changes after this PR is checked in and it shouldn't be a breaking change.

@LinglingTong , asmaskar from RP team has approved the changes. Can we merge this PR now?

@LinglingTong , asmaskar from RP team has approved the changes. Can we merge this PR now?

Yes please. Thanks!

@changlong-liu , can you please merge this PR?

@changlong-liu , requesting you to please merge this PR


Implement where for aggregates

Implements where for both scalar and categorical aggregates. Syntax:
# `agg` where cond is True, NA everywhere else
agg.where(cond)
# `agg` where cond is True, 2 everywhere else
agg.where(cond, 2)
# `agg` where cond is True, other_agg everywhere else
agg.where(cond, other_agg)

Allows for filtering based on elementwise conditionals in aggregates.

Seems very useful.  There's a lot of duplication between the two where() implementations; can that be avoided?  And it's a shame that something boiling down to np.where would take so much sanitizing code to work, but that's presumably unavoidable.

Reduced code duplication. In general, a lot of the ugliness of all this is due to dynd lack of features/stability. I may nuke it from the codebase soon in favor of some carefully managed numpy buffers. That's really all dynd is used for at this point - a buffer of bytes that sometimes crashes if you try to do stuff with it.

That helps, thanks!  One copy of ugly code is better than two! :-)


rkt docs diff view

to get the diff view for https://github.com/projectcalico/calico/pull/330

opened here by mistake


sklearn requirement breaks openai[embeddings] install

when installing the openai[embeddings] requirement, both sklearn and scikit-learn are listed as requirements source.
However, sklearn is deprecated, and is causing pip install openai[embeddings] to fail. See the following output from my CI build:
Collecting sklearn
  Downloading sklearn-0.0.post1.tar.gz (3.6 kB)
  Preparing metadata (setup.py): started
  Preparing metadata (setup.py): finished with status 'error'
  error: subprocess-exited-with-error

  × python setup.py egg_info did not run successfully.
  │ exit code: 1
  ╰─> [18 lines of output]
      The 'sklearn' PyPI package is deprecated, use 'scikit-learn'
      rather than 'sklearn' for pip commands.

      Here is how to fix this error in the main use cases:
      - use 'pip install scikit-learn' rather than 'pip install sklearn'
      - replace 'sklearn' by 'scikit-learn' in your pip requirements files
        (requirements.txt, setup.py, setup.cfg, Pipfile, etc ...)
      - if the 'sklearn' package is used by one of your dependencies,
        it would be great if you take some time to track which package uses
        'sklearn' instead of 'scikit-learn' and report it to their issue tracker
      - as a last resort, set the environment variable
        SKLEARN_ALLOW_DEPRECATED_SKLEARN_PACKAGE_INSTALL=True to avoid this error

      More information is available at
      https://github.com/scikit-learn/sklearn-pypi-package

      If the previous advice does not cover your use case, feel free to report it at
      https://github.com/scikit-learn/sklearn-pypi-package/issues/new
      [end of output]

  note: This error originates from a subprocess, and is likely not a problem with pip.
error: metadata-generation-failed

× Encountered error while generating package metadata.
╰─> See above for output.

A simple fix would be to simply remove sklearn from the list of dependencies of openai[embeddings].
I can open a PR for this if necessary.

+1 To this, sklearn shouldnt be a requirement

Please, this pull request needs to be accepted.


wallet: fix task for build & run on windows

We are fixing task command for build and run on windows.

Codecov Report
Patch and project coverage have no change.

Comparison is base (ee8c24a) 42.01% compared to head (0b00d37) 42.01%.

:exclamation: Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.
Additional details and impacted files
@@           Coverage Diff           @@
##             main     #518   +/-   ##
=======================================
  Coverage   42.01%   42.01%
=======================================
  Files          15       15
  Lines        1071     1071
=======================================
  Hits          450      450
  Misses        575      575
  Partials       46       46

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.


FileResponse should not dispose injected HttpClient

swagger2csclient generates FileResponse class which disposes HttpClient even if it is injected. I think it should not do this.

I dont see where the HttpClient is disposed:
https://github.com/RicoSuter/NSwag/blob/master/src/NSwag.CodeGeneration.CSharp/Templates/File.liquid#L97
You should enable the InjectHttpClient and then it is not disposed.

Sorry, used wrong arguments for client generation


[MINOR] docs: fix formatting

What changes were proposed in this pull request?

fix formatting

Why are the changes needed?
Improve the table cell formatting
Does this PR introduce any user-facing change?
no
How was this patch tested?
Local test

@zhoukangcn
Can you also align the table? I notice that this pr still can't make the table work well.

@yuqi1129 done. Thank you for your correction.

@zhoukangcn Welcome to join the Gravitino community! Enjoy your trip!

@zhoukangcn Could you raise a pr for branch 0.4?

@qqqttt123  #2224 is for branch-0.4, please review


Run more linters with golangci-lint

Currently we run only golint and gofmt. We should at least enable linters which are enabled by default in golangci-lint:
$ golangci-lint help linters
Enabled by default linters:
deadcode: Finds unused code [fast: true, auto-fix: false]
errcheck: Errcheck is a program for checking for unchecked errors in go programs. These unchecked errors can be critical bugs in some cases [fast: true, auto-fix: false]
gosimple (megacheck): Linter for Go source code that specializes in simplifying a code [fast: true, auto-fix: false]
govet (vet, vetshadow): Vet examines Go source code and reports suspicious constructs, such as Printf calls whose arguments do not align with the format string [fast: true, auto-fix: false]
ineffassign: Detects when assignments to existing variables are not used [fast: true, auto-fix: false]
staticcheck (megacheck): Staticcheck is a go vet on steroids, applying a ton of static analysis checks [fast: true, auto-fix: false]
structcheck: Finds unused struct fields [fast: true, auto-fix: false]
typecheck: Like the front-end of a Go compiler, parses and type-checks Go code [fast: true, auto-fix: false]
unused (megacheck): Checks Go code for unused constants, variables, functions and types [fast: false, auto-fix: false]
varcheck: Finds unused global variables and constants [fast: true, auto-fix: false]

Enabling some of them (I've checked errcheck and deadcode) would require fixing outstanding issues.
Work here should be done incrementally, one-by-one.
/good-first-issue
/help-wanted

@oxddr I'd like to work on it

@bitcodr that's great to hear. I think the best way to proceed is to pick up one of the linters from above (e.g. deadcode of errcheck), enable it and fix all reported issue and send me a PR for a review.

Hey @bitcodr Are you perhaps still working on this? If so feel free to /assign this issue. Thanks.

/assign

/assign

Adding gofmt would be especially useful.

@oxddr  Cleared errors for few of the modules, need some help on "clusterloader2" on few errors,
ERRO Running error: deadcode: analysis skipped: errors in package: [.../perf-tests/clusterloader2/pkg/chaos/nodes.go:109:52: cannot use k.client (variable of type kubernetes.Interface) as kubernetes.Interface value in argument to util.GetSchedulableUntainedNodes: wrong type for method AdmissionregistrationV1 .../perf-tests/clusterloader2/pkg/chaos/nodes.go:114:52

@satishbellapu - this looks strange.
But let's work iteratively on it. Feel free to send a PR that is fixing just some of the errors.
And then the pattern should be:

extend the presubmit to check gofmt, but make it not fail the test (just informative)
we will be working on fixing it while having it running
once we fix everything, we will make it blocking

Hey @wojtek-t, I would like to take a dig at it!

I didn't see any actions from @satishbellapu for last month, so it seems fine.

/assign

Errcheck has been added, Deadcode linter on the way!

Hi @wojtek-t with https://github.com/kubernetes/perf-tests/pull/1448, we will have six outstanding linters running with golangci-lint. Apart from them I would like to suggest staticcheck & goimport to be enabled, what do you suggest do we need them or we are fine without them?

I think we're fine without them (at least now). We can add them later...

/remove-lifecycle stale

/remove-lifecycle stale

/remove-lifecycle stale
/lifecycle frozen


[Good First Issue] MonitoringEKS example is using outdated k8s version 1.14

Problem: The MonitoringEKS example is using k8s version 1.14 which is no longer supported by Amazon EKS.
❯ eksctl create cluster --name my-cluster2 --version 1.14
2021-05-05 00:29:51 [ℹ]  eksctl version 0.47.0
2021-05-05 00:29:51 [ℹ]  using region us-west-2
Error: invalid version, 1.14 is no longer supported, supported values: 1.15, 1.16, 1.17, 1.18, 1.19
see also: https://docs.aws.amazon.com/eks/latest/userguide/kubernetes-versions.html

Suggested Fix: Use k8s version 1.19 (since it's the latest available version on Amazon EKS). This will require

Fixing the README.md
Fixing the beats/*.yaml files to support new k8s version

I agree with @rl-abdulkarim the EKS example needs updated. I was following the tutorial by Elastic here but had errors such as:
resource mapping not found for name: "metricbeat" namespace: "kube-system" from "examples/MonitoringEKS/beats/metricbeat-kubernetes.yaml": no matches for kind "DaemonSet" in version "extensions/v1beta1"
ensure CRDs are installed first
error validating data: ValidationError(DaemonSet.spec): missing required field "selector" in io.k8s.api.apps.v1.DaemonSetSpec

I had to amend the metricbeat-kubernetes.yaml file changing outdated api versions:
apiVersion: extensions/v1beta1
apiVersion: apps/v1beta1
apiVersion: rbac.authorization.k8s.io/v1beta1

to
apiVersion: apps/v1
apiVersion: rbac.authorization.k8s.io/v1

Next I had to add spec sections (as below) to the Daemonset and Deployment sections:
    spec:
      selector:
        matchLabels:
          k8s-app: metricbeat

Also in the generated secrets.yaml file I had to amend the name:
    apiVersion: v1
    kind: Secret
    metadata:
      name: beats-secrets

The generation script creates the name as: metricbeat-secrets rather than beats-secrets

I agree with @rl-abdulkarim the EKS example needs updated. I was following the tutorial by Elastic here but had errors such as:
resource mapping not found for name: "metricbeat" namespace: "kube-system" from "examples/MonitoringEKS/beats/metricbeat-kubernetes.yaml": no matches for kind "DaemonSet" in version "extensions/v1beta1"
ensure CRDs are installed first
error validating data: ValidationError(DaemonSet.spec): missing required field "selector" in io.k8s.api.apps.v1.DaemonSetSpec

I had to amend the metricbeat-kubernetes.yaml file changing outdated api versions:
apiVersion: extensions/v1beta1
apiVersion: apps/v1beta1
apiVersion: rbac.authorization.k8s.io/v1beta1

to
apiVersion: apps/v1
apiVersion: rbac.authorization.k8s.io/v1

Next I had to add spec sections (as below) to the Daemonset and Deployment sections:
    spec:
      selector:
        matchLabels:
          k8s-app: metricbeat

Also in the generated secrets.yaml file I had to amend the name:
    apiVersion: v1
    kind: Secret
    metadata:
      name: beats-secrets

The generation script creates the name as: metricbeat-secrets rather than beats-secrets

Hello @jonnymccullagh,
May you tell me where exactly this should be placed, because i am bit lost.
    spec:
      selector:
        matchLabels:
          k8s-app: metricbeat

This is how my Deamonset section looks like:
apiVersion: apps/v1
kind: DaemonSet
metadata:
  name: metricbeat
  namespace: kube-system
  labels:
    k8s-app: metricbeat
spec:
  template:
    metadata:
      labels:
        k8s-app: metricbeat
    spec:
      serviceAccountName: metricbeat
      terminationGracePeriodSeconds: 30
      hostNetwork: true
      dnsPolicy: ClusterFirstWithHostNet
      containers:
      - name: metricbeat
        image: docker.elastic.co/beats/metricbeat:7.6.2
        args: [
          "-c", "/etc/metricbeat.yml",
          "-e",
          "-system.hostfs=/hostfs",
        ]

This is the Deployment section:
apiVersion: apps/v1
kind: Deployment
metadata:
  name: metricbeat
  namespace: kube-system
  labels:
    k8s-app: metricbeat
spec:
  template:
    metadata:
      labels:
        k8s-app: metricbeat
    spec:
      serviceAccountName: metricbeat
      hostNetwork: true
      dnsPolicy: ClusterFirstWithHostNet
      containers:
      - name: metricbeat
        image: docker.elastic.co/beats/metricbeat:7.6.2
        args: [
          "-c", "/etc/metricbeat.yml",
          "-e",
        ]

Thank you in advance!


FastViT bug fix for returning intermediate output

The Timm implementation of FastViT uses a slightly different set of stages for the internal network where it has only 4 stages while the original FastViT has 8 stages. This causes an issue when you want to return the intermediate feature outputs because the indices are [0, 2, 4, 6] but for the Timm model they should be [0, 1, 2, 3]. I've added some images of each repo's network stages to show that stages are the same.
Here's FastViT stage 0

Which is the same as Timm's stage 0

And then FastViT's stages 1 and 2 (where 1 is the PatchEmbed)

Is the same as Timm's 1 (which contains the PatchEmbed in the stage)

@dillonalaird thanks, yeah didn't catch that one, made the stage changes so that behaviour with timm's features_only is consistent, but broke their fork_feat

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint.


Purifying Channel Angel Fire Apostle v1.5.4

Purifying Channel is still targeting multiple enemies within the radius. I am unsure if this is unique to angelfire apostle channel or consistent behaviour for other classes with the channel feature as well.

fixed for real

You are amazing 🙏


[youtube] Extra subtitles being overwritten

Checklist

[x] I'm reporting a broken site support
[x] I've verified that I'm running youtube-dl version 2019.05.11
[x] I've checked that all provided URLs are alive and playable in a browser
[x] I've checked that all URLs and arguments with special characters are properly quoted or escaped
[x] I've searched the bugtracker for similar issues including closed ones

Verbose log

youtube-dl.exe --all-subs --skip-download --verbose -f303+251,299+140 https://www.youtube.com/watch?v=jc5DlOkOcU4
[debug] System config: []
[debug] User config: []
[debug] Custom config: []
[debug] Command-line args: ['--all-subs', '--skip-download', '--verbose', '-f303+251,299+140', 'https://www.youtube.com/watch?v=jc5DlOkOcU4']
[debug] Encodings: locale cp1252, fs mbcs, out cp437, pref cp1252
[debug] youtube-dl version 2019.05.11
[debug] Python version 3.4.4 (CPython) - Windows-10-10.0.18362
[debug] exe versions: ffmpeg N-92573-gc047901012, ffprobe N-92573-gc047901012, rtmpdump 2.4-20151223-gfa8646d-LibreSSL_2.5.4-x86_64-static
[debug] Proxy map: {}
[youtube] jc5DlOkOcU4: Downloading webpage
[youtube] jc5DlOkOcU4: Downloading video info webpage
[info] jc5DlOkOcU4: downloading video in 2 formats
[info] Writing video subtitles to: M2 - Complete Works _ MY LIFE IN GAMING-jc5DlOkOcU4.en.vtt
[info] Writing video subtitles to: M2 - Complete Works _ MY LIFE IN GAMING-jc5DlOkOcU4.ja.vtt
[info] Writing video subtitles to: M2 - Complete Works _ MY LIFE IN GAMING-jc5DlOkOcU4.es.vtt
[info] Writing video subtitles to: M2 - Complete Works _ MY LIFE IN GAMING-jc5DlOkOcU4.en.vtt
[info] Writing video subtitles to: M2 - Complete Works _ MY LIFE IN GAMING-jc5DlOkOcU4.ja.vtt

Description

https://www.youtube.com/watch?v=jc5DlOkOcU4 contains two sets of English subtitles (not auto-generated). One is a full subtitle, the other is a translation of the Japanese parts of the video. Unfortunately one overwrites the other as they are named the same by youtube-dl.

You must provide unique output template if downloading multiple formats, e.g. by including format_id.

@dstftw what do you mean? Subtitles aren't mentioned in https://github.com/ytdl-org/youtube-dl/blob/master/README.md#output-template
Please reopen this. I found the correct timed text at a URL like
https://www.youtube.com/api/timedtext?xorp=True&expire=1558381630&key=yttt1&v=jc5DlOkOcU4&asr_langs=fr%2Cnl%2Cja%2Cpt%2Cen%2Cko%2Cit%2Cde%2Cru%2Ces&hl=en-GB&xoaf=1&caps=asr&sparams=asr_langs%2Ccaps%2Cv%2Cxoaf%2Cxorp%2Cexpire&signature=4A33A9BD71E63A0C8AEB8AEFB3FD5BF429994596.8348805079402DFDFC4F26D26AB0B646AD843185&lang=en&name=Japanese Translation&fmt=srv3
timedtext.xml.txt

English -> https://www.youtube.com/api/timedtext?lang=en&v=jc5DlOkOcU4&fmt=srv3
English - Japanese Translation -> https://www.youtube.com/api/timedtext?lang=en&v=jc5DlOkOcU4&fmt=srv3&name=Japanese Translation
only the first one can be downloaded with youtube-dl.

Thank you, @remitamine


Figure out seekable download url

Right now the URLs that are returned as part of FileVO seem to point to a https://localcdn.permanent.org server (e.g. here is a random file of mine)
For the SFTP service we're going to need URLs that can be seeked -- e.g. "I want bytes 5000 to 10035 of this URL".  We know that S3's API has that kind of functionality.
What we don't know is whether the localcdn urls can be seeked directly OR converted into an S3 API call that is seekable.
This issue captures the need to figure that out.  If the answer is "it's supported" then excellent!
If the answer is "it isn't supported by that URL" then we have to figure out how to extend the back end FileVO to provide a seekable version of the file URL.

The S3 API provides this: https://docs.aws.amazon.com/AmazonS3/latest/API/API_GetObject.html#ExampleGetRangeRequestHeaders
So one answer here could be that we convert the cdn url into an S3 url that we can use.

Another answer is that maybe the server already supports https://developer.mozilla.org/en-US/docs/Web/HTTP/Range_requests
If that is the case, we're fine.

(I think this is not an issue then, we have the functionality we need)

I wonder how one figures out if there's any MORE of a file!  That's probably in the protocol somewhere.


Make namespace accessible from other package

We have a micro-service using helm-v3 package.
Recently we upgraded the pkg from dev-v3 branch to v<IP_ADDRESS>-rc.2, then we found that "Namespace" of env setting changed to a function and the attribute is not accessible any more other than AddFlags function. But we are not a cli tool, we don't want to construct a flagset when we serving requests.
Is it possible to add a SetNamespace function for integration purpose, after all, not everyone is capable of using helm cli, they need web pages with one click deploy experience. Not able to set "Namespace" other than a cli flag is very inconvenience.
code of pkg/cli/environment.go changed from
type EnvSettings struct { 	Namespace string ... }
to
type EnvSettings struct { 	namespace string ... }

Feel free to submit a PR to expose that field and add tests around how to interact with that field!

I had modified the code on my own fork, but our own project is under intensive development, I'll submit the PR as soon as I get my work at hand done.


cannot load github.com/bep/golibsass/internal/libsass: no Go source files

building/installing hugo from source fails (after using https://gohugo.io/getting-started/installing/)

export VER=0.65.3
git clone --branch v$VER --single-branch --depth 1  $URL hugo-$VER
cd hugo-$VER
go version
go version go1.13.7 linux/amd64
go build --tags extended
...
build github.com/bep/golibsass/internal/libsass: cannot load github.com/bep/golibsass/internal/libsass: no Go source files

Not sure how to fix this issue.
Does this issue reproduce with the latest release?
Yes, the latest clone of the git repository reproduces the error: Latest commit
b66d38c
Additional information

lsb_release -a
Distributor ID:	Debian
Description:	Debian GNU/Linux 10 (buster)
Release:	10
Codename:	buster

go environment

GO111MODULE=""
GOARCH="amd64"
GOBIN=""
GOCACHE="/home/$USER/.cache/go-build"
GOENV="/home/$USER/.config/go/env"
GOEXE=""
GOFLAGS=""
GOHOSTARCH="amd64"
GOHOSTOS="linux"
GONOPROXY=""
GONOSUMDB=""
GOOS="linux"
GOPATH="/srv/go"
GOPRIVATE=""
GOPROXY="https://proxy.golang.org,direct"
GOROOT="/home/$USER/g/github.com/golang/go1.13.7"
GOSUMDB="sum.golang.org"
GOTMPDIR=""
GOTOOLDIR="/home/$USER/g/github.com/golang/go1.13.7/pkg/tool/linux_amd64"
GCCGO="gccgo"
AR="ar"
CC="gcc"
CXX="g++"
CGO_ENABLED="0"
GOMOD="/tmp/hugo/go.mod"
CGO_CFLAGS="-g -O2"
CGO_CPPFLAGS=""
CGO_CXXFLAGS="-g -O2"
CGO_FFLAGS="-g -O2"
CGO_LDFLAGS="-g -O2"
PKG_CONFIG="pkg-config"
GOGCCFLAGS="-fPIC -m64 -fmessage-length=0 -fdebug-prefix-map=/tmp/go-build184159906=/tmp/go-build -gno-record-gcc-switches"

Try installing using the steps from CONTRIBUTING.md#building-hugo

Following now https://github.com/gohugoio/hugo/blob/master/CONTRIBUTING.md#building-hugo-with-your-changes
Building the non extended version of hugo 0.64.1 and 0.66.0-DEV works just fine on my system
with and without mage.

 cd /tmp
 git clone https://github.com/gohugoio/hugo.git hugo-0.66.0-dev
 cd hugo-0.66.0-dev
 mage hugo
 ./hugo version
 Hugo Static Site Generator v0.66.0-DEV-B66D38C4 linux/amd64 BuildDate: 2020-02-28T09:42:31+0100

However also with mage hugo do not build/install the extended version and the error is very similar.
HUGO_BUILD_TAGS=extended mage install
build github.com/bep/golibsass/internal/libsass: cannot load github.com/bep/golibsass/internal/libsass: no Go source files
Error: running "go install -ldflags -X github.com/gohugoio/hugo/common/hugo.commitHash=b66d38c4 -X github.com/gohugoio/hugo/common/hugo.buildDate=2020-02-28T09:47:18+0100 -tags extended github.com/gohugoio/hugo" failed with exit code 1


Allow label overriding in all Chrome web store badges

Out of the supported 5 Chrome web store related badges, overriding the default label fails with chrome-web-store/d, chrome-web-store/rating and chrome-web-store/reating-count type badge.
Example:
https://img.shields.io/chrome-web-store/d/nimelepbpejjlbmoobocpfnjhihnpked.svg?label=testing

The above badge's label should show testing instead of downloads

Thanks a lot! That was a dumb oversight, sorry — I pushed your change live.


chore: bdd-spring-1576835297 to 0.0.1

chore: Promote bdd-spring-1576835297 to version 0.0.1

[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by:
To fully approve this pull request, please assign additional approvers.
We suggest the following additional approvers:
If they are not already assigned, you can assign the PR to them by writing /assign  in a comment when ready.
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment


Improve backend design

Improve and update the backend design, especially for the orders under October CMS v3.

Make such pieces of information less omnipresent + improved colours.
After

Before


Scrolling messes up zoom lens positioning

If I scroll while hovering an image the zoom lens position gets stuck. It should perhaps reset on scroll?
I've uploaded a video to show the behaviour.
https://user-images.githubusercontent.com/21367039/104570354-b7bab500-5649-11eb-9752-5bacb854830f.mov

Any news on this issue? It's blocking us from using this feature in production

I had the same problem with multiple zoomed images on one page.
I resolved it by "reinitiating" the zoom:
const initZoom = () => { return ImageZoom() };
let zoom = initZoom();
zoom.kill();
zoom = initZoom();


Title

xin code

bạn ơi cho mình xin 1 cái code của tk gmail<EMAIL_ADDRESS>

Hi @herombe301 , I'd like to provide any help I can do for you, however, I can not understand your language, could you please describe your question in English or Chinese? Thanks.
Hi @herombe301 ，我愿意为你提供任何我可以提供的帮助，但我无法读懂你所使用的语言，你可以使用英语或者中文描述一下你的问题吗？谢谢。

bạn ơi chát với mình được không làm ơn giúp lấy lại cái gmail đi tui xài thử mà khó xài quá giờ vô hoài không được

My friends can not access their gmail accounts again it asked to confirm your web-party code it but his new wealth now lost just before trial

Hi @herombe301 , I'm sorry I still really understand your question. If your Gmail is locked and you can not get 2FA code with this extension as you forget your security password, you may seek help from Google(we can not help to recover your password as we never collect it). If you mean you'd like to check the code to make sure this extension is safe to use, you can download it as ZIP or clone it via Git, to clone it via Git, you need install a Git client or GitHub client. For windows, you may get it from windows.github.com, or mac from mac.github.com.

This issue has been closed as we didn't receive further feedback over a month.


Add Missing Methods for Blueprints

Some endpoints of the following section can't be hit from this SDK.
We would like to ensure that all endpoints can be hit. For this issue, we would like to build out the Blueprints
Some of these methods may already exist.
If so no need to change/update them, just point out that they already exist and we will close the issue.

This is just to bring every SDK we have on par with all the methods available.
Check all the endpoints here and add the missing ones.

@Bezaeel  Assigned feel free to start working on this

@Cliftonz thank you, gone ahead to raise a PR

@Bezaeel Can you link the PR?

@Cliftonz done

@Cliftonz still waiting for your review, in mean time, can I pick up others?

@Bezaeel Just at me on any other issue that does not have all of the endpoints done and we can go from there.


ease of dynamically adding content

Submit an Issue
Hi,
This component works great for the most part thanks!
This is less of an issue and more of a suggestion/question.
Expected behavior and actual behavior:
If i have a px-accordion component like this:
<px-accordion
   id="mm-freq-tag-accordion"
   header-value="Most Frequently Occurring Tags">
</px-accordion>

And I want to use javascript to dynamically populate it with content I would try this:
document.getElementById("mm-freq-tag-accordion").innerHTML = "
ex 1

ex 2

ex 3
";

This is what you get with the above code:

Instead I had to do this:
document.getElementById("mm-freq-tag-accordion").getElementsByClassName("accordion__body")[0].innerHTML = "
ex 1

ex 2

ex 3
";

This works and yields the following behavior:

Steps to reproduce the problem:
Shown above
Suggestion/Question
I'm not sure if this should either be included in the documentation or if there should be some type of method to add content easily? Alternatively I may be missing some other way to do this more simply.
Environment (component version number, Browser (including version), operating system, hardware, etc):
component version: 1.07
browser: Google Chrome: Version 61.0.3163.100 (Official Build) (64-bit)
OS: Windows 7, Professional x64
Screenshots (optional, but very helpful):
Included above
Code examples help us better understand the issue - follow the appropriate codepen for the component by going to https://predix-ui.com, finding the component in question, and clicking on the pencil icon under the demo.
Once you've created your code example, you can save it under a new url.
Please note that you should NOT use the same methods for production as the ones used in codepen - these methods are not production ready.
https://codepen.io/anon/pen/oGMQWV?editors=1011

I think you'll want to use the "Polymer way" of doing this, as your workaround violates shadow DOM encapsulation so it may stop working at some point, or may not work in all browsers. Try this:
var acc = document.getElementById("mm-freq-tag-accordion");
Polymer.dom(acc).innerHTML = "
ex 1

ex 2

ex 3
";

Note: Polymer.dom() will be going away when we migrate to Polymer 2 - I'm not sure if your initial attempt will be the new "right way" or if there is a different syntax.


Delete pint.json

Since pint v1.1.3, the build folder is ignored by default. Since this project requires v1.1.3, pint.json can be safely removed

Thank you!


For discussion: Rethinking OV search results layout

During NCAM's accessibility review of AAPB website, It was recommended that thumbnails be hidden from screenreader on search results. If we remove images from search results on Open Vault, all the information that is left is the title.
For discussion: is this enough information to convey on search results? Should we rethink having a list view with more descriptive information on search results such as date, online availability status and media type, instead of the grid view?

Done When we use 100 characters of asset level descriptions in hidden text for screenreaders. If no description is available, do not use any description. Just leave title.

While this worked great for search results, not so much for the Exhibits grid. Need to refactor.


Idea: setup SMTP email server editing config/emails.js

This is an outcome of the yesterday outcome of when I was working on the Dockerfile.
I was trying to setup my current email server on Winds, when I found that the application is not able to setup any kind of other server, because of the way the source code is being written up.
Actually you can change the configuration on this file although, the reality is that you need ( as an example of the smtp ) is to totally override the provider obvject inside the Mail Service, changing only Backend, Username and Password is not enough.
My proposal is to make the configuration more flexible, in order to pass the full provider object in the config file. Therefore it will be possible to use any other methodology without the need to rewrite the Service.
Thanks in advance,
Julian

Jup, good point, thanks for providing all the details in this ticket.


Homematic IP Support

Hi,
do you know if the homematic-ip support is fully working?
I don't have any device yet, but i am planning to buy some.
Regards,
marbon87

Using Homematic IP requires running an special kernel module to drive the communication with the antenna. Since a Docker container uses the kernel of the host we would have to add the module there. Since I do not have any Homematic IP device I have no way to test that.
If you use the Homematic LAN adapter then it would likely work but again: I cannot test.
If anyone has a Homematic IP device and it is willing to test, please let me know.

I found more info (German) here

Ok, good to know. Then i will wait until you tried one :)

I was taking a look today morning and it is not so simple: it needs a special raw serial port device driver that is different for each Hardware. The post I refered before include instructions for the Raspberry. I use an orangepi 2 plus so I would need a diferent device driver.
So for the Raspberry should be easy but for other HW no so easy. Since I do not see any Homematic IP device with unique functionality I do not feel like doing the work.
If anyone feels like trying I would be happy to take pull requests.

Hi i'm looking forward to test an hmIP device with your docker image on an RP3 today and i just wanna know if I have to follow the instruction and it would work or do i need to map something into the docker container to bring it to work?

hmIP will not work at least that you have the special serial device in your board.
The kernel driver is here: https://github.com/eq-3/occu/tree/master/KernelDrivers
The sources provides by eq-3 should work for Raspberries but since I have another board (oragenpi 2 plus) and no hmIP device I will not be able to add this support myself.

hmIP will not work at least that you have the special serial device in your board.
The kernel driver is here: https://github.com/eq-3/occu/tree/master/KernelDrivers
The sources provides by eq-3 should work for Raspberries but since I have another board (oragenpi 2 plus) and no hmIP device I will not be able to add this support myself.

is there any news on the hmIP topic ?
I could support, but like others, I need some guidance.

Not from my side sry - switched to raspberryMatic on an own PI 1 Model B cause i din't get rfd to run inside docker

I started porting the special CCU2 device driver for the Raspberry serial port to work my OrangePI. It will still take several weekends. I uploaded the sources to an extra repo since I think I am the first one adapting it to other HW on the open so maybe other people want to join and add support for their own HW.
For Raspi users they can use the working device driver from the RaspberryMatic. Steps (in theory):

Write a DTS overlay to avoid that the default driver is used for the UART. You can see how I did this for the Orange PI on my repo.
build and load the bcm2835_raw_uart and eq3_char_loop on your Raspi
change the config for rfd to use the new devices
start the docker container in priviledge mode so it has access to the new /dev modules
HM IP devices should work

hm, did not try yet, but this makes me frown: "start the docker container in priviledge mode so it has access to the new /dev modules"
I did this previously, it made my raspi stop working, I had to poweroff/on.

You can also share only the serial devices. It has been a while since I do not run with privilege since I use docker swarm so maybe something in the CCU tries to do something it should not which is prevented by docker.

In the ELV magazine they show that in the new issue they will add an Homematic IP adapter as USB stick. This will remove the dependency on the special kernel module. ELV explicitly mention this adapter as a way to support docker :-)
As soon as it becomes available I will get one and add support for it in my docker image.

product is available now:
https://www.elv.de/elv-homematic-ip-rf-usb-stick-hmip-rfusb-fuer-alternative-steuerungsplattformen-arr-bausatz.html?refid=SEM_30003&gclid=CjwKCAiAxJPVBRB4EiwAsCA4aU0gHqSAEM6XmtlxtF7R0xAjCPVgF_EbJZ8tV-qBaNit73Z1MsZAgRoCyfEQAvD_BwE
But functionality seams to be not as expected.
Moreover I saw an interesting conversation at https://github.com/eq-3/occu/issues/33. They succeeded in creating the kernel module. Tough stuff ...

@omo2002 - yes, I was disappointed to find out that the USB stick only support Homematic IP but not the old Homematic :-(
Since I have no Homematic IP devices (beyond one I bought to try it) I have not a huge interest on it.
I have also switched to more powerful ARM devices (http://www.hardkernel.com/main/products/prdt_info.php?g_code=G150229074080) so I have no GPIO anymore. For the time being I use a Homematic LAN gateway. I intended to switch to the USB stick. Since this does not work I am thinking about attaching the HM-MOD-RPI-PCB to an USB-Serial converter so it is platform independent. It is this or reversing engeniering the Homemtic USB stick...
A project for the next vacations...
Thanks for the link!

I just added Homematic IP support based on Alex´s pivccu


No compilation error on later declared variable reference

🔎 Search Terms
variable reference foreach before declaration
🕗 Version & Regression Information

This is the behavior in every version available on Playground

⏯ Playground Link
https://www.typescriptlang.org/play?ts=5.4.2#code/MYewdgzgLgBADjAXDaAnAlmA5gbQLowC8MOA5AKYAeAhgLZwA25peA3AFBwB0AZiKgFFqwABYAKSkQB8MAN7sYMdDxgTC6ygEo5CxTACeXOAFcI42QF9NHRRfZWOoSLH1ESbIA
💻 Code
const p = [];
p.forEach(x => {
  if (x===x) {
    y.push({});
  }
});
const y = [];

🙁 Actual behavior
Usage of y in foreeach doesn't lead to compilation error. But it produces a runtime error.
🙂 Expected behavior
Compilation error on line y.push({});
Additional information about the issue
No response

Duplicate of #56827 / #11498.


templateProvider not returning template

I have the following templateProvider:
templateProvider: function($timeout, $stateParams, templateService)
{
	return $timeout(function () {
		return templateService.getTemplate($stateParams, '/introduction/vision-for-health-and-wellbeing.html');
	}, 100);
}

and the service that gets the template:
.factory('templateService', ['$templateRequest', '$translate', function($templateRequest, $translate) {
	return {
		getTemplate: function(stateParams, url) {
			return $templateRequest( 'partials/' + ( $translate.use() ? $translate.use() : $translate.preferredLanguage ) + url);
		}
	}
}]);

However the state never loads and I don't get any errors. What's wrong?
Also any links that reference this state don't do anything... so it's like the module is just bombing out but not reporting what the issue is.

i also have the same problem with angular permission

Can you post a plunker?
http://bit.ly/UIR-Plunk

@christopherthielen Think this should show the issue: http://plnkr.co/edit/tgTddy6Y3xeJO2hgOACR?p=preview (I've removed the $translate from this example as I don't believe it's relevant to the issue and it looks to be still breaking.)

Okies, I have managed to fix this by upgrading to the latest versions of all scripts.


Unexpected behaviour of pure with or_else and failable parser

I was going to make an issue about positional's restriction being too strict, but then I ran into this problem and they both kind of cancelled each other out.
Here is example of expected bahaviour:
fn main() {
    let left = bpaf::pure(-10);
    let right = bpaf::pure(10);
    let parser = (construct!([left, right]))
        .to_options()
        .descr("test");
    let r = parser.run();
    println!("{:?}", r);
}

Here the left parser is selected, as expected, since the docs say that construct picks the leftmost succeeding.
Here's unexpected behaviour:
fn main() {
    use bpaf::{construct, Parser};

    let fails = bpaf::pure(10)
        .to_options()
        .command("cmd");
    let succeeds = bpaf::pure(-10);

    let parser = (construct!([ succeeds, fails ]))
        .to_options()
        .descr("Example");

    let r = parser.run();
    println!("{:?}", r);
}

Here if you run this with ./example cmd, it will print 10, even though the -10 parser should have succeeded before it.
This behaviour doesn't change if you swap parsers' places in construct.

The reason it worked out favourably for me is that in my case the fails parser contained a positional argument, and succeeds parser contained an optional keyword argument. So I couldn't put the unfailable parser last since it would violate the positional arguments restrictions.
While trying to construct a minimal example, I found it to be very brittle.
This works and is not restricted:
fn main() {
    use bpaf::{construct, Parser};

    let positional = bpaf::positional("TEXT")
        .to_options()
        .command("cmd")
        .map(Result::Err);
    let keyword = bpaf::long("kw")
        .argument("TEXT")
        .optional()
        .map(Result::Ok);

    let parser = (construct!([ positional, keyword ]))
        .to_options()
        .descr("Example");

    let r = parser.run();
    println!("{:?}", r);
}

This produces restriction error:
fn main() {
    use bpaf::{construct, Parser};

    let positional = bpaf::positional("TEXT")
        .to_options()
        .command("cmd")
        .map(Result::Err);
    let keyword = bpaf::long("kw")
        .argument("TEXT")
        .optional();
    let keyword = construct!(Result::Ok(keyword)); // <-- construct instead of map

    let parser = (construct!([ positional, keyword ]))
        .to_options()
        .descr("Example");

    let r = parser.run();
    println!("{:?}", r);
}

And if you switch places of keyword and positional, restriction does not apply, and instead the bug in the title takes place.

Here's unexpected behaviour:

I guess docs are a bit more confusing that I imagined. There's two different left-most positions: according to position inside construct!([]) macro and according to position of the earliest consumed element and the consumed position takes priority, pure means lowest possible priority in that respect. I'll look into updating the docs, but it works as expected other than that.
You usually use pure to put some value into a struct created with construct!, for fallback values there's https://docs.rs/bpaf/0.5.7/bpaf/trait.Parser.html#method.fallback that runs when inner parser doesn't consume anything.
Do you have any examples of what exactly you are trying to parse? Maybe I can suggest a better approach?

Ok, thanks for the explaination. The consumes and priorities are not present in the docs, so it might be good to add them there.
pure is just an example. I was under the impression that the parsers act as an algebra, again like optparse-applicative. But the example was simplified from a real usage here: https://github.com/d86leader/wzmach/blob/2210d9dfb82e5419cdd48f3268464aea2d5a2ed7/src/main.rs#L17-L46 (which you have updated a month ago, and I updated again today). Here I want to parse several commands, and use a default command when others don't match.

Ok, thanks for the explaination. The consumes and priorities are not present in the docs, so it might be good to add them there.

Yea, will do.
It is an algebra, but a badly documented one :)

Here I want to parse several commands, and use a default command when others don't match.

This should do the trick I think.
-construct!([debug_gestures, debug_events, debug_config, run])
+construct!([debug_gestures, debug_events, debug_config, run]).fallback(Opts::DefaultCommand)

pure at the end should probably work as well, but making it more explicit is better and also gives an indication that command is optional on usage line.


Python not book does not show where to set the API key

The python notebook says to replace YOUR_KEY with your actual API key. It doesnt say anywhere where to specify the key.

@rayschippers Do you mean where to find the key?. That would be https://otx.alienvault.com/settings/

I mean, in the documentation it says otx = OTXv2("") in the code snippet
and below that it states replace YOUR_KEY with your API Key found at ......
The code snippet should read otx = OTXv2("YOUR_KEY")
On Sat, Oct 3, 2015 at 1:02 AM, jaimeblasco<EMAIL_ADDRESS>wrote:

@rayschippers https://github.com/rayschippers Do you mean where to find
the key?. That would be https://otx.alienvault.com/settings/
—
Reply to this email directly or view it on GitHub
https://github.com/AlienVault-Labs/OTX-Python-SDK/issues/7#issuecomment-145086895
.

I can confirm this is still an issue in 2017 and Alien Vault hasn't fixed this or seems to indicate or record any other documentation on their Python API anywhere on the web. Their site is going well but did they abandon this whole project? If you make an SDK you would expect the documentation to be longer than one page and incomplete at that...

@lillypad are you unable to use OTX-Python-SDK?  This is a documentation issue and the fix is noted above:
otx = OTXv2("YOUR_KEY")
I submitted a PR to fix the documentation.

I know, just seems odd they haven't merged it yet in literally 2 years...

With @bsmartt13 pull hopefully this is clarified.  In addition I added a link to the live API documentation hosted in the site for more clarity on the contents of the API calls.


Add BIN, entrypoint field for kubectl 1.12

This CL adds a bin field.
Bin specifies the entry point for a kubectl plugin after the 1.12 release.

/cc @ahmetb

Do you mind rolling up the docs/* changes to the same PR? We probably shouldn't forget those.

please rebase so the "go test" works now.

/cc @ahmetb

Thanks! What should we check off in #33?

The tracking file currently looks good to me 👍