Unit tests for HelperMappingBuilder.convertSourceValues

Test all branches in HelperMappingBuilder.convertSourceValues and private callees as requested by @kevin-m-knight-gs.

Tests created with the help of Diffblue Cover.

Having reviewed our contributor list, we require a CLA for the following people : (@peterschrammel).

Diffblue has got an active CLA. @finos-admin

CLA is approved
Added tests pass fine: https://github.com/finos/legend-engine/pull/175/checks?check_run_id=2354329400#step:7:4638
WhiteSource Security Check failure seems unrelated to this PR.

This PR is stale because it has been open for 30 days with no activity. Please remove stale label or add any comment to keep this open. Otherwise this will be closed in 5 days.

This PR was closed because it has been inactive for 35 days. Please re-open if this PR is still relevant.


Add Vue app to the vue:mount event

Q
A

Bug fix?
no

New feature?
yes

Tickets
N/A

License
MIT

Add the Vue app to the vue:mount event, so that users can have access to it when hooking into the event in order to use Vue Plugins with components. Without access to the app instance, it's not possible to use plugins.

I thought about doing it in the intial PR but it requires special attention.
My fear was that people would use things like Vue router and that could get messy.
Maybe a simple notice in the docs would be enough ?

Actually I think this patch won't work, because plugins needs to be added before mounting the app. So there would need to be another event between createApp and mount. Something like vue:app, or vue:beforeMount?

My fear was that people would use things like Vue router and that could get messy.

Vue router will work fine, as long as the hash history is used. For HTML5 history mode, the router might become a problem.

Thanks Pierre!


More style updates

Adresses https://waffle.io/jayroh/thredded/cards/5549692729673903005d1b20 among others.

@jayroh I don't know what's going on with this error to fix it :|

Also this: https://waffle.io/jayroh/thredded/cards/55636b98f82b9bdf01a08775

@kylefiedler re:

I don't know what's going on with this error to fix it :|

If you mean why travis is failing then I'm on the case :)
I think it's a version mismatch between rubocop's

HAHAHA

On Mon, May 25, 2015 at 2:56 PM, Kyle Fiedler<EMAIL_ADDRESS>wrote:

Also this:
https://waffle.io/jayroh/thredded/cards/55636b98f82b9bdf01a08775
[image: screenshot 2015-05-25 14 56 16]
https://cloud.githubusercontent.com/assets/223180/7801170/49728c94-02ee-11e5-9ee1-56d962463894.png
—
Reply to this email directly or view it on GitHub
https://github.com/jayroh/thredded/pull/92#issuecomment-105289123.

hey @kylefiedler! So, I'm wondering if there's a particular version of sass that will work with the style of OOCSS/BEM magic you're authoring. Reason being, I'm seeing Sass really dislike this sort of scss:
.currently-online {
  @include position(fixed, null 0 0 null);
  background-color: $base-border-color;
  padding: $base-spacing * 1.5;
  width: rem(320);

  &--title {
    margin-bottom: $base-spacing;
  }
}

The part it dislikes is &--title ... from the looks of it Sass is trying to interpret that as a mathematical operation.

Changing it to the following is a-ok:
.currently-online {
  @include position(fixed, null 0 0 null);
  background-color: $base-border-color;
  padding: $base-spacing * 1.5;
  width: rem(320);
}

.currently-online--title {
  margin-bottom: $base-spacing;
}

@jayroh I'm using Sass 3.4.13 (Selective Steve) but I've been told that the style you've written is easier to read / parse through / search for. I'm going to switch all the styles to not use the & for class names.

@jayroh Is this ready to be merged?


⚠ Groups API Endpoint has degraded performance

In 6a398af, Groups API Endpoint (https://groups.roblox.com/v1/groups/5680533) experienced degraded performance:

HTTP code: 500
Response time: 2262 ms

Resolved: Groups API Endpoint performance has improved in 50b60f4 after 18 minutes.


popovers: Add dynamic width, structural changes and other small improvements to stream and topic action popovers.

Changes:
Topics Action Popover

Set popover width based the longest menu item. (min-content sizing)
Allow topic name to wrap across multiple lines.
Left align the topic name.
Remove the '>' icon.
Change <p> tag to <div> and replace <b> tag with font-weight property.

Streams Action Popover

Set popover width based the longest menu item. (min-content sizing)
Allow stream name to wrap across multiple lines.
Left align the stream name.
Change <p> tag to <div> and replace <b> tag with font-weight property.

Common

Restructured popover-related CSS and sensible renaming, to avoid CSS overlapping.

Fixes: #27562.
CZO Discussions: #design and #frontend

Screenshots and screen captures:
Topic Actions Popover

Description
Before
After

Light Mode

Dark Mode

Long Menu Options (Russian)

Topic Name that wraps across multiple lines (Japanese)

Streams Actions Popover

Description
Before
After

Light Mode

Dark Mode

Long Menu Options (Russian)

Stream Name that wraps across multiple lines

Self-review checklist

[ ] Self-reviewed the changes for clarity and maintainability
(variable names, code reuse, readability, etc.).

Communicate decisions, questions, and potential concerns.

[x] Explains differences from previous plans (e.g., issue description).
[x] Highlights technical choices and bugs encountered.
[ ] Calls out remaining decisions and concerns.
[ ] Automated tests verify logic where appropriate.

Individual commits are ready for review (see commit discipline).

[x] Each commit is a coherent idea.
[x] Commit message(s) explain reasoning and motivation for changes.

Completed manual review and testing of the following:

[x] Visual appearance of the changes.
[x] Responsiveness and internationalization.
[x] Strings and tooltips.
[x] End-to-end functionality of buttons, interactions and flows.
[x] Corner cases, error conditions, and easily imagined bugs.

Did this reduce the amount of vertical space allocated to the topic name? It feels a bit cramped to me.

Did this reduce the amount of vertical space allocated to the topic name? It feels a bit cramped to me.

This was due to the following reason https://github.com/zulip/zulip/pull/28092#discussion_r1421691816, due to which additional padding was also being added to the topic name previously. I have included that additional padding via the change from margin 5px to 6px.

I'm also thinking for consistency, we should left-align the stream name in the stream menu popover as well.

I have now included the same set of changes for the stream menu popovers as well.

Rebased on top of #27815, to account for the --popover-menu-min-width CSS variable.

The stream menu seems unnecessarily wide now. Can we make it fit the options, like it did previously?

Looks good to me otherwise!

Removed the min-width property to now make stream popovers fit the options

Works for me!

Test-deploying this updated version to chat.zulip.org.

Looks good to me, marked to merge once CI passes after rebasing following the merge of #27815. Thanks @sayamsamal and @karlstolley!


enable analytics on prod

@skavish merge this when you think it's time :)
@shamansir should 'base' be 'develop' or 'master'?

@RobertoUa develop <=> test, master <=> prod, so base is develop, like the nightly build.

I know what develop and master is.
What I don't know is when develop will be merged into master.

@RobertoUa You may checkout master and cherry-pick this commit there or repeat what you've done. Then just do a Pull Request to master instead of develop, we merge it, it deploys automatically, everyone's (I hope) happy. Master is very different from development version for the moment, unfortunately.


Copy sources from Versions.props to NuGet.config

TL;DR
We need that all restore sources are located in NuGet.config since internal feeds can only be restored from there. More details including next steps here

@dougbu @JunTaoLuo PTAL

Won't we need to update all Arcade AspNetcore repos (not just the main four)?
That is, at least AspNetCore-Tooling, Blazor, EntityFramework6, EntityFrameworkCore, Extensions, and maybe (??) AspLabs will also need to change. Correct?

I'll include these in the doc and work on them

@aspnet-hello triage https://dev.azure.com/dnceng/public/_build/results?buildId=259258

@jcagme I'll get this in once builds complete successfully (though I don't promise to check repeatedly tonight)

This comment was made automatically. If there is a problem contact<EMAIL_ADDRESS>I've triaged the above build. I've created/commented on the following issue(s)
https://github.com/aspnet/AspNetCore-Internal/issues/2771
https://github.com/aspnet/AspNetCore-Internal/issues/2711
https://github.com/aspnet/AspNetCore-Internal/issues/2741


Some questions about images and genotypes

Hi：
I have read your article. Your work is not only innovative but also meaningful. I am currently conducting research on human fundus images and have some questions to ask you.

I downloaded images with IDs 21015 (left eye) and 21016 (right eye) from UKB. I have some uncertainties about the naming of each image. For example, for individual 1030816, there are two images in the left eye: 1030816_21015_0_0.png and 1030816_21015_1_0.png. For individual 1031077, there are 1031077_21015_0_0.png and 1031077_21015_0_1.png. In the names of these two individuals' images, "_1" appears in different positions. Do you know what each position represents? When conducting GWAS analysis, which image did you specifically use?

In the appendix of your article, it is mentioned that "Imputed genotype data was filtered according to minor allele frequency (MAF ≥ 0.1%), Hardy-Weinberg equilibrium (significance level: 10−12), imputation quality (information score ≥ 0.4), as well as SNP and sample missingness of maximal 10%." However, in the preprocessing_imp.sh script, I only see MAF and Hardy-Weinberg equilibrium. Could you please explain how you proceeded with the latter two filtering criteria?

Hi, thanks for your interest!
Regarding the image filenames: the last _0, _1 etc denote the first or second image taken in direct succession. We did some manual and automated QC filtering here, but it might be sufficient to just use the last one. Since publishing the paper, there have been some other works for better QC of retinal fundus images, I think, maybe check them out if it's a big issue. The first _1_, _0_ etc should denote the visit, if I remember correctly. Unfortunately, the IIDs are randomized between applications, so I can't share the images we have used.
The imputation quality scoring was done at the end before plotting & reporting results - we still ran the GWAS for all SNPs. The SNP & indiv missingness was done using BOLT, as specified here: https://github.com/mkirchler/transferGWAS/blob/8382d4389f02ed904693ee28a694d18f0e611626/lmm/run_lmm.py#L80-L81

Hi, thanks for your interest! Regarding the image filenames: the last _0, _1 etc denote the first or second image taken in direct succession. We did some manual and automated QC filtering here, but it might be sufficient to just use the last one. Since publishing the paper, there have been some other works for better QC of retinal fundus images, I think, maybe check them out if it's a big issue. The first _1_, _0_ etc should denote the visit, if I remember correctly. Unfortunately, the IIDs are randomized between applications, so I can't share the images we have used. The imputation quality scoring was done at the end before plotting & reporting results - we still ran the GWAS for all SNPs. The SNP & indiv missingness was done using BOLT, as specified here:
https://github.com/mkirchler/transferGWAS/blob/8382d4389f02ed904693ee28a694d18f0e611626/lmm/run_lmm.py#L80-L81
Thank you for your patience! Thank you very much


NXPhlite issues.

@davids5  Has issues maintaining altitude  in position, altitude and Auto. The accuracy of the GPS is very poor. in POS it maintain the position  but in mission it doesn't.
commit 5b0ad4e1.
https://review.px4.io/plot_app?log=ff6f685c-eb1a-412a-93e3-80354cbf602c
https://review.px4.io/plot_app?log=a5824a2a-e8ff-4f00-b7c4-b1018c694652
https://review.px4.io/plot_app?log=1c2da437-5699-4ddc-bf01-1d5ab0814187
https://review.px4.io/plot_app?log=aa719c97-71c4-4d05-aea6-ef6f8a36ce01
https://review.px4.io/plot_app?log=ff6f685c-eb1a-412a-93e3-80354cbf602c
https://review.px4.io/plot_app?log=b0db2ecc-a6c9-42a1-8a49-f8afea1ffa2e
commit 9e4e19d4.
https://review.px4.io/plot_app?log=910de492-f7b7-4fe4-8983-837c3f130218
https://review.px4.io/plot_app?log=42c37087-c863-4423-9f11-c8bb517da99f

@davids5, please update the issue when you get a chance.

@Tony3dr , @dagar and I are looking in to the root cause. I will add to the PR https://github.com/PX4/Firmware/pull/10280  a commit with the filtering lowered for testing. But dagar suspects the issue is relates to the input rate to the EKF.

Please do a cautious flight test @PX4/testflights on master.
Please fly NXPHlite-v3  to test if this issue still is present.
If there are any comms issues* we will need to troubleshoot in real time on slack.
*(There is still  a hadfault when QGC is connected via USB - WIP)
Use real safety switch on all HW and cross test FMUv4, FMUv2  (2mb)

flight running master,(commit 5847ab4).
https://review.px4.io/plot_app?log=177abd89-3e18-44d0-9cd1-9376f2a28246
The thelemetry connection is already working, but has the same issue. the copter doesn't maintain altitud in alt mode with the throttle in 0 the copter it rose to 80 meters. Also the doesn't working the position mode and auto.

@dagar would you please have a look at the logs and give me some advice

@Avysuarez your GPS was never very good in that flight. Which external unit are you using?
The vehicle never attained a valid local position, global position, or home position.

@Avysuarez you could try changing COM_ARM_WO_GPS to require valid global position because it lets you arm.
I would try a different GPS unit if you have one available.

@dagar Ok, i'll try again

@dagar I tested again and the same issue, I waiting 5 minutes before take-off and the gps don't locked. I was change the GPS for one of cuav (ublox m8n).  I flew in stabilized and did respond to the radio and crashed!
https://review.px4.io/plot_app?log=0677d8ff-bb7f-4e68-925e-ed18c62ee2f8

(at the moment we do not have a vehicle to test nxphlite!)

@avysuarez replacement units sent

@igalloway can you please share the tracking info? Thanks.

@Tony3dr please test current maste on new hw when available.

@davids5 the hardware will be received tomorrow afternoon in our office. We will resume NXPhlite testing on Monday. We will let you know how it goes.

@davids5 @Tony3dr
I flew the nxp with the master and flew well in stabilized mode and altitude, but i had issues with the GPS, i was waiting more than 10 minutes and do not lock the position, rejected the position mode.
The GPS is a ready tosky ublox M8N.
https://review.px4.io/plot_app?log=dd59e88f-559a-4091-bdfd-5aeec11e840d
https://review.px4.io/plot_app?log=9a90fbf9-ddcb-41ef-a4af-f2a39028e230

@Avysuarez - Thank you! There is a issue with the board jamming the GPS. Work is being done to determine the cause.  Will let you know when we have something to test. FYI @igalloway @bkueng

The jamming indicator is not particularily high in these logs (around 20), but the reported accuracy is not good enough, which can also be due to the board.
Additional issue: the vibration levels on the vehicle are extremely high (especially in x-y), can you please fix the setup?

@bkueng
Working on the jamming issue: There is a build with a rounded the clock on the SD here https://github.com/PX4/Firmware/pull/10626


Provide initial functionality

🗣 Description
This PR implements the initial functionality for this repository, namely Terraform to do the following:

Deploy a Lambda function, specifically cisagov/publish-egress-ip-lambda, and it's execution role/policy
Create the CloudWatch log group used by the Lambda
Schedule the Lambda to run every X minutes using a CloudWatch event
Create an S3 bucket to host the published files (objects) containing egress IP information
Deploy a CloudFront distribution to enable HTTPS access to the egress IP info in the S3 bucket
Create DNS records that point to the CloudFront distribution

💭 Motivation and context
We need a mechanism to publish egress IP info from a subset of our AWS accounts and this Terraform will allow us to deploy the infrastructure to do that.
This is part of the work for:

https://github.com/cisagov/cool-system/issues/208
https://github.com/cisagov/cyhy_amis/issues/284

This PR is related to the following:

https://github.com/cisagov/cool-accounts/pull/126
https://github.com/cisagov/cool-accounts/pull/127

🧪 Testing
I successfully applied all of this Terraform and confirmed that the Lambda was deployed, scheduled, and worked as expected.  I also confirmed that I could cleanly destroy all of this Terraform.

✅ Pre-approval checklist

[x] This PR has an informative and human-readable title.
[x] Changes are limited to a single goal - eschew scope creep!
[x] All future TODOs are captured in issues, which are referenced
in code comments.
[x] All relevant type-of-change labels have been added.
[x] I have read the CONTRIBUTING document.
[x] These code changes follow cisagov code standards.
[x] All relevant repo and/or project documentation has been updated
to reflect the changes in this PR.
[x] All new and existing tests pass.

✅ Post-merge checklist

[ ] Confirm that all internal stakeholders are ready for this deployment
[ ] Deploy to Production

I just added the blocked label on this PR so that I don't merge it until after https://github.com/cisagov/publish-egress-ip-lambda/pull/4 has been approved and merged.  I also added a Pre-merge checklist checkbox to the PR description above.

Quick reminder to enable these ignore directives

Thanks @mcdonnnj for the reminder!  Done in https://github.com/cisagov/publish-egress-ip-terraform/pull/6/commits/3d83004aaf2e0796645bc64a8e4605548acefa1e.


Fix incorrect parameter maximum

The specs says 2047 in page 728 but this is incorrect.
The discriminator is an unsigned 12-bit so the max is 4095 and iOS sends discriminators above 2047.

fixled it as docs bug https://github.com/project-chip/connectedhomeip/issues/24301


corrections espaces_bis2

:tada: This PR is included in version 1.0.0 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


[WIP] Remove DeclContext walk from resolveTypeInContext()

Unqualified name lookup starts from an innermost context and walks up through parent contexts until it finds a declaration with the given name. For example, consider something like this:
class Base<T> {
  typealias A = [T]
}

class Derived : Base<Int> {
  class Nested {
    func foo() -> A { ... }
  }
}

The lookup of 'A' inside 'Nested' finds the typealias 'A' inside 'Base'. Since the lookup is done from a nested type of 'Derived', we have to use 'Base' as the base type to get the substitution T := Int.
Previously, we would find the base type by performing a walk over all parent contexts, checking their superclasses and adopted protocols until we found the nested type in question. This duplicates work already done by name lookup, and has the potential to go out of sync with the name lookup implementation.
The new implementation instead saves the DeclContext resulting from the name lookup, avoiding the walk altogether.

@swift-ci Please smoke test

@swift-ci Please smoke test

@swift-ci Please test source compatibility

https://github.com/apple/swift-lldb/pull/240
@swift-ci Please smoke test Linux

Source compat suite UPASS'd, not related to my changes:
UPasses:
  UPASS: https://bugs.swift.org/browse/SR-5500, AMScrollingNavbar, 3.0, AMScrollingNavbar, generic/platform=iOS
  UPASS: https://bugs.swift.org/browse/SR-5500, Chatto, 3.1, ChattoApp, generic/platform=iOS


[Draft] Allow optional segments

This PR tries to address issue: https://github.com/apache/pinot/issues/11965, basically by extending the NewSegment concept added for instanceSelector early on. The NewSegment concept was added to handle the case when new consuming segments are added in IdealState but not online in ExternalView yet, as servers may take time to load new consuming segments and report the status back to Helix. Instead of reporting such new segments as unavailable segments, broker simply skips them.
But simply skipping them at broker side could cause the wrong query results as detailed in the new issue. e.g. for upsert table, the server could start to ingest new records into the new segments and invalidate the records in existing segments, even before the broker could mark those new consuming segments as online, thus queries could not see the new records in new consuming segments during a short window. This issue could cause inconsistent query results, particularly for upsert table.
So in this PR, we track those new segments that not online in ExternalView, and pass them to servers, instead of skipping them at broker side. The servers can skip them if they are not available, otherwise, process they for correct query results, particular for upsert table.
TODO: only support for SingleConnectionBrokerRequestHandler in this PR. Probably add support for GrpcServerRequest (based on protobuf) and multi-stage engine in a separate PR.

Codecov Report

Merging #11978 (3af5143) into master (972b555) will decrease coverage by 61.45%.
The diff coverage is 0.00%.

:exclamation: Current head 3af5143 differs from pull request most recent head 508cd71. Consider uploading reports for the commit 508cd71 to get more accurate results

@@              Coverage Diff              @@
##             master   #11978       +/-   ##
=============================================
- Coverage     61.44%    0.00%   -61.45%
+ Complexity     1141        6     -1135
=============================================
  Files          2385     2309       -76
  Lines        129189   125481     -3708
  Branches      19998    19444      -554
=============================================
- Hits          79381        6    -79375
- Misses        44061   125475    +81414
+ Partials       5747        0     -5747

Flag
Coverage Δ

custom-integration1
<0.01% <0.00%> (ø)

integration
<0.01% <0.00%> (ø)

integration1
<0.01% <0.00%> (ø)

integration2
?

java-11
?

java-21
<0.01% <0.00%> (-61.31%)
:arrow_down:

skip-bytebuffers-false
<0.01% <0.00%> (-61.43%)
:arrow_down:

skip-bytebuffers-true
<0.01% <0.00%> (-61.27%)
:arrow_down:

temurin
<0.01% <0.00%> (-61.45%)
:arrow_down:

unittests
?

unittests1
?

unittests2
?

Flags with carried forward coverage won't be shown. Click here to find out more.

Files
Coverage Δ

...requesthandler/MultiStageBrokerRequestHandler.java
0.00% <ø> (-17.69%)
:arrow_down:

...thandler/SingleConnectionBrokerRequestHandler.java
0.00% <ø> (-17.73%)
:arrow_down:

...t/ConcurrentMapPartitionUpsertMetadataManager.java
0.00% <ø> (-85.42%)
:arrow_down:

...roker/requesthandler/GrpcBrokerRequestHandler.java
0.00% <0.00%> (ø)

...roker/requesthandler/BaseBrokerRequestHandler.java
0.00% <0.00%> (-45.78%)
:arrow_down:

...ceselector/StrictReplicaGroupInstanceSelector.java
0.00% <0.00%> (-98.42%)
:arrow_down:

...e/pinot/core/query/request/ServerQueryRequest.java
0.00% <0.00%> (-51.07%)
:arrow_down:

...stanceselector/MultiStageReplicaGroupSelector.java
0.00% <0.00%> (-66.67%)
:arrow_down:

...core/query/executor/ServerQueryExecutorV1Impl.java
0.00% <0.00%> (-63.44%)
:arrow_down:

...va/org/apache/pinot/core/routing/RoutingTable.java
0.00% <0.00%> (-87.50%)
:arrow_down:

... and 6 more

... and 1975 files with indirect coverage changes
:mega: Codecov offers a browser extension for seamless coverage viewing on GitHub. Try it in Chrome or Firefox today!


gha: use ccache and cache action

In #145 we started using the cache action to speed up builds by caching the python virtual environments in .nox.
Even though the CPU build is quite fast, we could speed this up even further by installing ccache and caching /root/.cache/ccache before actually building/installing vllm.

This was (partially) implemented in #147.
The issue with this implementation (and in #145 's) as well, is that all three workflows use the same cache key, meaning there is contention between the three jobs for the cache key.


Add doc notes about using quote marks on Mac when installing optional et al

[ ] Closes #xxxx
[ ] I am familiar with the contributing guidelines
[ ] Tests added
[ ] Updates entries in docs/sphinx/source/reference for API changes.
[ ] Adds description and name entries in the appropriate "what's new" file in docs/sphinx/source/whatsnew for all changes. Includes link to the GitHub Issue with :issue:`num` or this Pull Request with :pull:`num`. Includes contributor name and/or GitHub username (link with :ghuser:`user`).
[ ] New code is fully documented. Includes numpydoc compliant docstrings, examples, and comments where necessary.
[x] Pull request is nearly complete and ready for detailed review.
[x] Maintainer: Appropriate GitHub Labels (including remote-data) and Milestone are assigned to the Pull Request and linked Issue.

pvlib defines a few sets of optional dependencies that can be installed with pip install pvlib[optional], pip install pvlib[test], etc.  On zsh, the default shell on Mac, the brackets syntax is interpreted by the shell instead of being passed through to pip, so they must be escaped or wrapped in quotation marks like pip install "pvlib[optional]".
In #1167 we decided against documenting this since it's not specific to pvlib, but since it has come up again in the JOSS review (https://github.com/openjournals/joss-reviews/issues/5994#issuecomment-1820067837) I think it's worth a small note in our docs.
This PR edits the installation and contributing docs pages to mention the correct command for Mac users.

@phoebe-p, do you think this PR will help new users not get confused?

This looks good to me!

I don't think these changes will be controversial, so I'll go ahead and merge this PR.  Thanks @phoebe-p for raising the issue!


A few questions

Hey @eschlenz,
I discovered this plugin through your article while actually trying fix a problem with another plugin (lol) by getting away from said plugin, since I was trying to fix my own AOP Sample Application bc new views on one of my older articles would probably expect it to be working properly.
First off, this is very cool and switching plugins was super easy from my end, and worked without any issues. Great work!
My questions are as follows:

What's stopping this library itself from becoming unmaintained? I think you may be the only contributor for now, which may not necessarily be a bad thing but what if you leave Ibotta or something? Would someone there still actively maintain it? I'm sure if AOP is a big part of your process, they would be forced to but you know.
Does the AGP version matter at all for this plugin? You mentioned the bytecode pipeline, so I was curious. For example, in my previous experience, Gradle and AGP updates frequently broke the other plugin as APIs changed. Do you think it will be an issue for this plugin? If not, that's actually a huge benefit over existing solutions.

Thanks again for the cool plugin! Please feel free to close this issue as you see fit as it's not actually a bug or anything.

Or also before I forget, the plugin directive:
com.ibotta:plugin
is a little vague and may cause issues if you want more ibotta plugins later. I'm not too familiar with plugins but you may want to consider renaming it at some point
com.ibotta:aspectj-plugin

Or also before I forget, the plugin directive:
com.ibotta:plugin
is a little vague and may cause issues if you want more ibotta plugins later. I'm not too familiar with plugins but you may want to consider renaming it at some point
com.ibotta:aspectj-plugin

Hey there @jdvp,
Happy to hear you were able to use our plugin successfully! In response to your questions:

At this time, I personally am the one who did the majority of this work on this plugin, and pushed to open source it. That being said, we have a pretty good sized Android team who could help maintain this in the future. Would that happen if I left? I'd hope so, but I honestly can't promise anything. FWIW, I've been at Ibotta for over 8 years, and don't have plans to leave any time soon. :) We are also open to ideas on how to promote the maintainability of this plugin moving forward.
I think the AGP updates could potentially break things, but I'm not particularly concerned about the bytecode pipeline mechanisms changing much. Again, I can't promise anything. It looks like the mechanism was introduced about three years ago, and the function's contract hasn't changed since then. That doesn't mean the implementation hasn't changed, but based on what I know, it doesn't seem like a feature that is under heavy modification.

Or also before I forget, the plugin directive:
com.ibotta:plugin is a little vague and may cause issues if you want more ibotta plugins later. I'm not too familiar with plugins but you may want to consider renaming it at some point
com.ibotta:aspectj-plugin

Guhh, I couldn't agree more. I'll try to explain what happened here.
We have our plugin being distributed to the "Gradle Plugin Portal", which seems appropriate. In order to do so, you use another Gradle plugin to publish it.
The variables you specify, and what happens with them, was not obvious nor was the documentation particularly helpful. We thought we had it configured with sane values, but had no way to really confirm that without actually releasing the plugin. So we tried that. Then we found out that there are huge delays in getting through the Gradle Plugin Portal approval process (could be weeks). Once we finally got approved after tapping a contact we have at Gradle, we came to find out the plugin identifier was less than desirable.
Honestly, the huge delay in approvals, and the need to figure out the right way to configure the plugin's group identifier, are what made us leave it as is for now. We (Ibotta) need to devote some time to this, unless someone from the community can help out sooner. Wink wink, nudge nudge. If for some reason it causes huge headaches, other than just being unsightly and ambiguous, I could try to push internally for some dedicated time to fix it. As with any open source project though, we are hoping to get some help from the community whenever possible.

Hey there @jdvp,
Happy to hear you were able to use our plugin successfully! In response to your questions:

At this time, I personally am the one who did the majority of this work on this plugin, and pushed to open source it. That being said, we have a pretty good sized Android team who could help maintain this in the future. Would that happen if I left? I'd hope so, but I honestly can't promise anything. FWIW, I've been at Ibotta for over 8 years, and don't have plans to leave any time soon. :) We are also open to ideas on how to promote the maintainability of this plugin moving forward.
I think the AGP updates could potentially break things, but I'm not particularly concerned about the bytecode pipeline mechanisms changing much. Again, I can't promise anything. It looks like the mechanism was introduced about three years ago, and the function's contract hasn't changed since then. That doesn't mean the implementation hasn't changed, but based on what I know, it doesn't seem like a feature that is under heavy modification.

Or also before I forget, the plugin directive:
com.ibotta:plugin is a little vague and may cause issues if you want more ibotta plugins later. I'm not too familiar with plugins but you may want to consider renaming it at some point
com.ibotta:aspectj-plugin

Guhh, I couldn't agree more. I'll try to explain what happened here.
We have our plugin being distributed to the "Gradle Plugin Portal", which seems appropriate. In order to do so, you use another Gradle plugin to publish it.
The variables you specify, and what happens with them, was not obvious nor was the documentation particularly helpful. We thought we had it configured with sane values, but had no way to really confirm that without actually releasing the plugin. So we tried that. Then we found out that there are huge delays in getting through the Gradle Plugin Portal approval process (could be weeks). Once we finally got approved after tapping a contact we have at Gradle, we came to find out the plugin identifier was less than desirable.
Honestly, the huge delay in approvals, and the need to figure out the right way to configure the plugin's group identifier, are what made us leave it as is for now. We (Ibotta) need to devote some time to this, unless someone from the community can help out sooner. Wink wink, nudge nudge. If for some reason it causes huge headaches, other than just being unsightly and ambiguous, I could try to push internally for some dedicated time to fix it. As with any open source project though, we are hoping to get some help from the community whenever possible.

@eschlenz Thanks for the quick reply. This all makes a lot of sense to me, so I'm going to update my article's example and project with the Ibotta plugin as a replacement for what I had before.
The bytecode pipeline is pretty interesting so I'll also take a look into it, I never even knew it existed. But I guess that's true for a lot of things that are hidden away in gradle and android builds!
I'm not very familiar with working on plugins themselves but I'll definitely play with this one and maybe one day I'll be able to contribute!

If for some reason it causes huge headaches, other than just being unsightly and ambiguous, I could try to push internally for some dedicated time to fix it.

I don't think this a serious issue, unless it's causing problems for you guys. It is ambiguous but I don't think it will cause any major issues for anyone.
Thanks again and have a nice holiday!

@eschlenz Thanks for the quick reply. This all makes a lot of sense to me, so I'm going to update my article's example and project with the Ibotta plugin as a replacement for what I had before.
The bytecode pipeline is pretty interesting so I'll also take a look into it, I never even knew it existed. But I guess that's true for a lot of things that are hidden away in gradle and android builds!
I'm not very familiar with working on plugins themselves but I'll definitely play with this one and maybe one day I'll be able to contribute!

If for some reason it causes huge headaches, other than just being unsightly and ambiguous, I could try to push internally for some dedicated time to fix it.

I don't think this a serious issue, unless it's causing problems for you guys. It is ambiguous but I don't think it will cause any major issues for anyone.
Thanks again and have a nice holiday!

The bytecode pipeline is pretty interesting so I'll also take a look into it, I never even knew it existed. But I guess that's true for a lot of things that are hidden away in gradle and android builds!

It is! We hadn't heard of it either until our Gradle reps pointed us in that direction. In hindsight, it makes sense that such a feature exists.

The bytecode pipeline is pretty interesting so I'll also take a look into it, I never even knew it existed. But I guess that's true for a lot of things that are hidden away in gradle and android builds!

It is! We hadn't heard of it either until our Gradle reps pointed us in that direction. In hindsight, it makes sense that such a feature exists.


Fix a small typo in the doc

Title says it all :smile:
This looks like a simple copypasta mistake, so I just thought I would fix it quickly. I didn't believe it was necessary to follow the whole contribution pattern outlined in the repository guidelines given how trivial the change is. Please correct me if I'm wrong.

Build failure is due to an intermittent we have sometimes with phantomjs 2.0.1. Merging, thank you!

Build failure is due to an intermittent we have sometimes with phantomjs 2.0.1.

Aha, I see. This is not intermittent, but a change that was dropped from my PR (because I could not recall why the fix I made was there: https://github.com/n1k0/casperjs/pull/1352#discussion-diff-45838428).
I will re-add these changes in a separate PR that make things work for 2.0.1 again.


Nissenbaum - long .dot strings are now supported

Long .dot strings were causing multiple internal callbacks to the 'stdout' hander for the multiprocess communication, but the code assumed all output would occur in a single call to the 'stdout' handler. This caused a crash on long .dot strings because the final line in the first call to the stdout handler is typically cropped in the middle, causing a syntax error when that line is evaluated. The solution is to support multiple calls to the callback and append the data for all calls to a single variable, and only execute the command on the exit handler.
Additionally this commit adds some safety by waiting for the write handler to complete before calling the file-close function.


Use of direct-lvm instead of loop-lvm within containers ?

Hi,
First, thanks to build cloudbreak as it allowed us to create our first hadoop clusters in a few clicks.
However, now that we dive more into the sublayers, I noticed that:

Docker use devicemapper with loop-lvm mode
Docker itself does not recommend loop-lvm mode for production but direct-lvm instead.

Is there a way to use direct-lvm in a cloudbreak context ?
Otherwise, I saw you had issues with "overlayfs" and fall back to devicemapper. Any progress on this even if on our side, it would mean to drop CentOS/RHEL for Debian/Ubuntu.
Thanks,
Nicolas

Hi @nsteinmetz ,
We still use CentOS/RHEL and the loop-lvm and do not experience production issues with that. We have investigated the direct-lvm and it worked fine for us, but not too easy to integrate it in our stack.
I think you have to create your own image to use direct-lvm, so there is no easy way that configures it through Cloudbreak.
Br,
Tamas

Ok thanks ; and for the overlayfs, is it available for ex with Debian/Ubuntu or do you use only devicemapper for all linux distributions so far ?

Hi,
We only use and support CentOS/RHEL distributions. Definitely the overlayfs would work on Debian/Ubuntu.

Oh indeed, I mixed the OS supported by cloudbreak and the one by HDP.


Link data from final JSON format to results page for search

Link data from server>VulnerabilityData data to results page for search on VulnerabilityResultsForm.js. Pass this data to Vulnerability Stats Table for use.

Used/passed finalized JSON format for final front end displays


fix(uri): fix parse for empty path and '/' or '?' in fragment

Fixes #1176.

[x] The commit messages match the guidelines in https://github.com/hyperium/hyper/blob/master/CONTRIBUTING.md#git-commit-guidelines

All tests are passing so hopefully this didn't break anything!

Thanks!


URL Change: docs.airy.co -> airy.co/docs

Let's switch to the industry standard for easier tracking & extensibility.
Should later be extended in an easy fashion to airy.co/docs/enterprise etc

For the menu to work properly we should have the structure
airy.co/docs/airycore
airy.co/docs/airyenterprise
Could also be done easily with url fwds, as long both of them have a base url (so airy.co/docs for the core one, airy.co/docs/airyenterprise for the enterprise one)

For the menu to work properly we should have the structure
airy.co/docs/airycore
airy.co/docs/airyenterprise
Could also be done easily with url fwds, as long both of them have a base url (so airy.co/docs for the core one, airy.co/docs/airyenterprise for the enterprise one)

Issue resolved, the following URLs are active now:

https://airy.co/docs
https://airy.co/docs/core
https://airy.co/docs/enterprise
https://docs.airy.co (with redirect to https://airy.co/docs/core/)
https://enterprise.airy.co (with redirect to https://airy.co/docs/enterprise/)


[html5]DisplayObject::scrollRect doesn't work

In recent OpenFL versions (https://github.com/openfl/openfl/commit/be31d8825f35356f08910ff0d71b307c854b6bbd) DisplayObject::scrollRect doesn't clip the viewable area of the display object.
Code to reproduce:
class Main extends Sprite {
	public function new() {
		super();
		var sp: Shape = new Shape();
		sp.graphics.beginFill(0x6080a0, 1);
		sp.graphics.drawCircle(100, 100, 100);
		sp.graphics.endFill();
		addChild(sp);
		sp.scrollRect = new Rectangle(0, 20, 60, 40);
	}
}

Result:

Expected result:

@Klug76 should be working after this commit

fixed, thanks.


Classify cell with scGPT

Hi,
wonderful work, I was wondering if could be used to classify cells in inference without the need for finetuning.
second, could be possible to identify the most important genes involved in the classification?
Thank you very much

Thanks for the great questions.

Currently, in the preprint, we trained a new MLP classifier appended to scGPT in the fine-tuning stage. This is the "technical" reason why it is difficult to have "zero-shot" classifier since there are no such classifier layers in the pretraining stage. On the other hand, I think if you are doing something like KNN-based classification, the model can be used without fine-tuning. By KNN, I mean you used some cell embeddings of the pre-trained models with reference annotations. For a new cell, search for the nearest neighbors and assign the cell type labels by majority voting. We actually plan to set up a notebook to do something like this.

I think that's an interesting question! An immediate idea I have is to look at the attention weights.


Display general Distribution for dataset

Display general Distribution for dataset
Hi, it would be nice with the little square indicatng the whole country as distributin when such data in fact are provided in the distribution extension, the old portal does that :-)

fbitem-dataset4deebf95-61a0-4fd4-8a29-0c63f69617e8
Reported by: @DanBIF
System: Chrome 56.0.2924 / Windows 7 0.0.0
Referer: https://demo.gbif.org/dataset/4deebf95-61a0-4fd4-8a29-0c63f69617e8
Window size: width 2276 - height 1138
API log
Site log

This is now added. Next step is to get a better resolution basemap and perhaps show the distribution text in a better way. The map is now also a different projection - that means that it is now possible to have a distribution that covers the poles.
Thanks for reporting.  Let me know if you still see issues in the presentation of this.


Update TortoiseHg to version 3.7.2

Update TortoiseHg to version 3.7.2

Thank you for the contribution. It was merged directly as a04cef0aa4d2ed8913f3edecd5eb1c003d89eef3 to keep commit history cleaner. Your contribution is still credited to you.


Autocomplete optionSelections is not working

ngAfterViewInit() {
this.sub = Observable.merge(...this.trigger.optionSelections).subscribe(option => {
console.log(option);
});
}
I cannot see the console.log ()
"@angular/common": "^2.4.8",
"@angular/compiler": "^2.4.8",
"@angular/core": "^2.4.8",
"@angular/flex-layout": "^2.0.0-beta.5",
"@angular/forms": "^2.4.8",
"@angular/http": "^2.4.8",
"@angular/material": "2.0.0-beta.2",
"@angular/platform-browser": "^2.4.8",
"@angular/platform-browser-dynamic": "^2.4.8",
"@angular/router": "^3.4.8",

Closing this issue as it does not follow the issue template.  Here's a plunker example of how to use with beta.2: https://plnkr.co/edit/AaBESvqvT40htQPlAp0b?p=preview
If you are still seeing issues, please file a new issue that follows the template, which gives the team the information needed to investigate.


CICD Include PR number from build in the terraform workspace name to avoid deployment collisions during PR branch CI/CD processes

Description
As a developer, I'd like to have the CI/CD process perform any test deployments for my PR in a way that ensures no conflict with other PRs (or with master), in order to avoid any workspace or naming conflicts.
It was determined that a good way to achieve this would be to modify our YAML pipeline to incorporate the PR number (if triggered via PR) into the workspace name. The workspace name is currently assembled by combining the workspacePrefix in the top-level YAML with the build environment (ie "devint"/etc).
Acceptance Criteria
Reference: [Done-Done Checklist] (https://github.com/Microsoft/code-with-engineering-playbook/blob/master/Engineering/BestPractices/DoneDone.md)

[ ] CI/CD deployments from master branch should continue to operate the same as they do prior to this change (no change to workspace and resource naming)
[ ] CI/CD deployments from Pull Request branches should insert the PR number into the workspace name (which then should cascade into the resource names)

Resources
Tasks
Stories are intended to be completed in a single sprint; if task breakdown creates addition work then team should discuss promoting the Story to an Epic.
Reference: [Minimal Valuable Slices] (https://github.com/Microsoft/code-with-engineering-playbook/blob/master/Engineering/BestPractices/MinimalSlices.md)
Reference: [How to Write Better Tasks] (http://agilebutpragmatic.blogspot.com/2012/04/splitting-story-into-tasks-how-to-write.html)
Assignee should break down work into tasks here

It might be important that someone/something clean-up AZ resources, once a PR is merged/closed (or else the resources will keep billing).

I love the idea of including the PR id within the workspace prefix.


Call twisted with carbon-cache

Unlike in upstram code, we cannot use sys.arg[0]

This change is

Previously, unbrice (Brice Arnould) wrote…
> #### Call twisted with carbon\-cache
>
> Unlike in upstram code, we cannot use sys.arg[0]
>
>
>

Reviewed 1 of 1 files at r1.
Review status: all files reviewed at latest revision, all discussions resolved.

Comments from Reviewable

Coverage remained the same at 77.866% when pulling 09c44bb2486bbe403148b71e0216093011e29188 on unbrice:master into 6e12c0d38fa6f185c3273e789a9f7b5b4fda56b6 on criteo:master.


Add Golang SAST and SCA checks

This PR adds security checks for the Golang components

What's the advantage of these CI tools vs. the CodeQL setup we already have? Also curious if you've taken a look at this repo? https://github.com/securego/gosec

golangci-lint is a lint of linters (one of them being gosec).
It checks for many different things, not only security related, but also performance etc. Checks more stuff than CodeQL.
govulncheck is SCA like Dependabot, but also works with the runtime itself.
They can both be integrated with GitHub security alerts.

Let's try to merge https://github.com/wavetermdev/waveterm/pull/734 first or else golangci-lint will complain a lot.

@kamushadenes sorry I tried to change the base branch for this to our new main branch and it automatically closed the PR. Can you reopen this PR targeting our new main branch?


attempt at cross-browser build

This is a huge change, basically a refactor of the whole plugin, but without any functional changes.
The intention is to port the project so it works both in Chrome and Firefox.
Chrome has a WebExtensions standard for writing browser extensions. Firefox will eventually adopt that standard fully, and then we can use more or less the same codebase across all browsers. Until then, we need to abstract away implementation differences between the browsers.

tested the chrome side, works fine!

For sure I've done sth wrong... I've cloned the repo, checked out feature/cross-browser. Installed npm.
marcin@marcin-N56JR:~/r/z/zipkin-chrome-extension(feature/cross-browser|…) $ npm --version
3.5.2

marcin@marcin-N56JR:~/r/z/zipkin-chrome-extension(feature/cross-browser|✔) $ npm run dev-firefox                                                         17:10

><EMAIL_ADDRESS>dev-firefox /home/marcin/repo/zipkin-stuff/zipkin-chrome-extension
> node node_modules/gulp/bin/gulp.js firefox

[17:12:45] Using gulpfile ~/

repo/zipkin-stuff/zipkin-chrome-extension/gulpfile.js
[17:12:45] Starting 'firefox:webpack'...
[17:12:45] Starting 'firefox:mustache'...
[17:12:45] Starting 'firefox:data'...
[17:12:45] Finished 'firefox:mustache' after 470 ms
[17:12:46] Finished 'firefox:data' after 895 ms

stream.js:74
      throw er; // Unhandled stream error in pipe.
      ^
Error: ./js/ZipkinPanel.js
Module not found: Error: Cannot resolve 'file' or 'directory' ./ZipkinUI in /home/marcin/repo/zipkin-stuff/zipkin-chrome-extension/js
resolve file
  /home/marcin/repo/zipkin-stuff/zipkin-chrome-extension/js/ZipkinUI doesn't exist
  /home/marcin/repo/zipkin-stuff/zipkin-chrome-extension/js/ZipkinUI.webpack.js doesn't exist
  /home/marcin/repo/zipkin-stuff/zipkin-chrome-extension/js/ZipkinUI.web.js doesn't exist
  /home/marcin/repo/zipkin-stuff/zipkin-chrome-extension/js/ZipkinUI.js doesn't exist
  /home/marcin/repo/zipkin-stuff/zipkin-chrome-extension/js/ZipkinUI.json doesn't exist
resolve directory
  /home/marcin/repo/zipkin-stuff/zipkin-chrome-extension/js/ZipkinUI doesn't exist (directory default file)
  /home/marcin/repo/zipkin-stuff/zipkin-chrome-extension/js/ZipkinUI/package.json doesn't exist (directory description file)
[/home/marcin/repo/zipkin-stuff/zipkin-chrome-extension/js/ZipkinUI]
[/home/marcin/repo/zipkin-stuff/zipkin-chrome-extension/js/ZipkinUI.webpack.js]
[/home/marcin/repo/zipkin-stuff/zipkin-chrome-extension/js/ZipkinUI.web.js]
[/home/marcin/repo/zipkin-stuff/zipkin-chrome-extension/js/ZipkinUI.js]
[/home/marcin/repo/zipkin-stuff/zipkin-chrome-extension/js/ZipkinUI.json]
 @ ./js/ZipkinPanel.js 19:16-37

npm ERR! Linux 4.4.0-21-generic
npm ERR! argv "/usr/bin/nodejs" "/usr/bin/npm" "run" "dev-firefox"
npm ERR! node v4.2.6
npm ERR! npm  v3.5.2
npm ERR! code ELIFECYCLE
npm ERR<EMAIL_ADDRESS>dev-firefox: `node node_modules/gulp/bin/gulp.js firefox`
npm ERR! Exit status 1
npm ERR!
npm ERR! Failed at the<EMAIL_ADDRESS>dev-firefox script 'node node_modules/gulp/bin/gulp.js firefox'.
npm ERR! Make sure you have the latest version of node.js and npm installed.
npm ERR! If you do, this is most likely a problem with the zipkin-browser-extension package,
npm ERR! not with npm itself.
npm ERR! Tell the author that this fails on your system:
npm ERR!     node node_modules/gulp/bin/gulp.js firefox
npm ERR! You can get information on how to open an issue for this project with:
npm ERR!     npm bugs zipkin-browser-extension
npm ERR! Or if that isn't available, you can get their info via:
npm ERR!     npm owner ls zipkin-browser-extension
npm ERR! There is likely additional logging output above.

npm ERR! Please include the following file with any support request:
npm ERR!     /home/marcin/repo/zipkin-stuff/zipkin-chrome-extension/npm-debug.log

Here is the log file:
npm-debug.txt

I found the issue!

fixed it

I think I got it working for Firefox too :) Great job!

lovely! should we rename the repo now? :)

Yes, something like zipkin-browser-extension?

going twice...

sold!


Recursive union failes at startup

union Dynamic {
  1: bool boolean;
  2: i64 integer;
  3: double doubl;
  4: string str;
  5: list<Dynamic> arr;
  6: map<string, Dynamic> object;
}

thriftpy.parser.exc.ThriftParserError: No type found: 'Dynamic', at line 6

taken from: https://github.com/facebook/fbthrift/blob/master/thrift/lib/thrift/dynamic.thrift

Confirmed.

@nikitinsm Fixed in https://github.com/eleme/thriftpy/pull/158


MacOS empty output folder created

The script finishes without any errors and creates the output folder without any files in it.

On rebuild I get this error:
error: /Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/install_name_tool: no LC_RPATH load command with path: /opt/homebrew/Cellar/capstone/5.0.1/lib found in: /Users/user/Development/Github/blutter/blutter/../bin/blutter_dartvm3.2.6_android_arm64 (for architecture arm64), required for specified option "-delete_rpath /opt/homebrew/Cellar/capstone/5.0.1


PP-12681 Update paths for degatewayed credential endpoints

WHAT YOU DID

Update paths for degatewayed credential endpoints to /v1/api/service/{serviceId}/account/{accountType}/...
Add Paths class to tests for easier path management

How to test

Run tests

Closing as this is covered in #5333


Update links and icons in footer component

To prepare for a full production release of the new version of the Platform, we should update the footer component.
Can we please update the footer component to look like the specification below? Please pay particular attention to the layout and responsiveness of the component to prevent overlapping content and content overflow issues.

About

Label
Link
Note

Platform version: 1.0.0
https://github.com/opentargets/platform-app/releases/tag/ + releaseVersion
Display version number based on GitHub release number

Data release: 21.04
Link TBC

Community forum
https://community.opentargets.org

Privacy notice
https://www.ebi.ac.uk/data-protection/privacy-notice/open-targets

Terms of use
https://docs.targetvalidation.org/terms-of-use

Help

Label
FontAwesome icon
Link

Documentation
fas fa-question-circle
https://docs.targetvalidation.org

<EMAIL_ADDRESS>fas fa-envelope
<EMAIL_ADDRESS>

Follow us

FontAwesome icon
Link

fab fa-discourse
https://community.opentargets.org

fab fa-twitter
https://twitter.com/opentargets

fab fa-linkedin-in
https://www.linkedin.com/company/open-targets

fab fa-github
https://github.com/opentargets

fab fa-youtube
https://www.youtube.com/opentargets

Partners

Label
Link

Bristol Myers Squibb
https://www.bms.com

EMBL-EBI
http://www.ebi.ac.uk

GSK
http://www.gsk.com

Sanofi
https://www.sanofi.com

Wellcome Sanger Institute
http://www.sanger.ac.uk

Open Targets

Label
Link

Science
https://www.opentargets.org/science

Publications
https://www.opentargets.org/publications

Genetics Portal
https://genetics.opentargets.org

Jobs
https://www.opentargets.org/jobs

Blog
https://blog.opentargets.org

Closed by https://github.com/opentargets/platform-app/pull/317


:sync="true" doesn't work?

I've set :sync="true" but when I update the text on editor, the content doesn't get synchronized to the original variable.
I am using  inside another component, and I wonder if that is the cause of this issue..
<el-form>
    <el-form-item>
        <editor :content="form._config" :sync="true" :lang="'json'"></editor>
    </el-form-item>
</el-form>

Sorry for the late reply, but did you include the following code into your application?
mounted () {
  var vm = this;
  vm.$on('editor-update', vm.function);
}

Sync currently only tells the application that as soon as the original variable gets updated, it should also update the text in the editor. It does not update the origin variable.
To update the origin variable you need to include the code above and use vm.function (that should be a function in your app) to update the variable. Something like this would be possible:
methods: {
  update (value) {
    var vm = this;
    vm.myOriginVariable = value;
  }
},

mounted () {
  var vm = this;
  vm.$on('editor-update', vm.function);
}

Let me know if it worked or if I can help any further.
I'm currently working on an easier way to auto update the variable.


[ID] If the Recent Activities or Upcoming Closing dates feeds on the dashboard have less than three rows, don't show the link for the full page.

If the feed on the dashboard is already showing all the information, the user doesn't need to see the full page.

if the Recent Activities dates feed on the dashboard has less than four rows, don't show the link "See All Activity".
if the Upcoming dates feed on the dashboard has less than three rows, don't show the link "See All Upcoming".

@mhuang-usdr Is there a UX reason for having "Upcoming Closing Dates" three rows and "Recent Activity" four?

@chrisxkeith I don't have context on any of these decisions only similar questions. There are 15 options under "Agency Status" drop down when viewing a grant and it's not obvious where those options map to elsewhere in the UI. (Relatedly, I was curious why "My Grants and Dashboard" are two different tabs and the use cases for each!)

@caitlinwinner No problem! I'm trying to get the context myself. :)

@chrisxkeith

Is there a UX reason for having "Upcoming Closing Dates" three rows and "Recent Activity" four? "Upcoming Closing Date" rows are 'deeper'.

Nope, feel free to make them 3 each.

As far as I can tell, it looks like “Upcoming Closing Dates” only includes grants that have been “Interested” (from my testing and reading of the code). Is this the expected behavior, or should it also include grants marked “Assigned”? Oops, had it backwards. Fixed this comment.

It should include both Assigned and Interested grants
@caitlinwinner

was curious why "My Grants" and "Dashboard" are two different tabs and the use cases for each!
No real good reason, it is legacy from eng-driven design :)

My Grants is intended to be a todo-list/project management page for the average user. The recent activities and closing dates feeds might belong there better!
Dashboard is meant to show metrics and analytics for admins/super-users - for example, how much grant money an agency or an organization as a whole has applied for vs. been rejected for. There hasn't been a ton of functionality fleshed out around this particular use case yet.


Snow Icon not Showing in Currently Section

Did the threshold to show the precipitation icon on the currently block change? When I look at the API currently I see a precipIntensity of 0.36 so it should be showing snow as it's over the 0.25 threshold to show the snow icon. When I look in the hourly section it works like normal. My guess is that when you added the fallback to hourly data something messed up with the icon calculation in the HRRR domain?
Data from the API is below:
  "currently": {
    "time":<PHONE_NUMBER>,
    "summary": "Cloudy",
    "icon": "cloudy",
    "nearestStormDistance": 0,
    "nearestStormBearing": 0,
    "precipIntensity": 0.36,
    "precipProbability": 0.25,
    "precipIntensityError": 0.0974,
    "precipType": "snow",
    "temperature": -0.03,
    "apparentTemperature": -1.95,
    "dewPoint": -1.09,
    "humidity": 0.93,
    "pressure": 998.9,
    "windSpeed": 5.736,
    "windGust": 12.15,
    "windBearing": 25.56,
    "cloudCover": 1.0,
    "uvIndex": 1.82,
    "visibility": 3.5,
    "ozone": 346.37
  },
...
    "hourly": {
    "summary": "Cloudy",
    "icon": "cloudy",
    "data": [
      {
        "time":<PHONE_NUMBER>,
        "icon": "snow",
        "summary": "Snow",
        "precipIntensity": 0.2857,
        "precipProbability": 0.47,
        "precipIntensityError": 0.1053,
        "precipAccumulation": 0.2857,
        "precipType": "snow",
        "temperature": -0.02,
        "apparentTemperature": -1.95,
        "dewPoint": -1.09,
        "humidity": 0.93,
        "pressure": 998.9,
        "windSpeed": 5.74,
        "windGust": 12.15,
        "windBearing": 25.56,
        "cloudCover": 1.0,
        "uvIndex": 1.82,
        "visibility": 3.5,
        "ozone": 346.37
      },

Great catch, and sorry I didn't get to it sooner. It turned out to be a rounding problem, which spiraled into the icon selection logic. Fixed in v1.4.1, and changelog is updated!

@alexander0042 Thanks for the update but it doesn't appear to be fixed. I see the following when I query the API and it is still showing cloudy.
  "currently": {
    "time":<PHONE_NUMBER>,
    "summary": "Cloudy",
    "icon": "cloudy",
    "precipIntensity": 0.4395,
    "precipProbability": 0.94,
    "precipIntensityError": 0.033,
    "precipType": "snow",
  },

Shoot! It was literally just working, but evidently not! Let me check on this

@alexander0042 It appears that the currently section is pulling in the precipIntensity from the minutely section? I bet the current precipIntensity is 0 which is why the cloudy icon is being shown instead of snow?

Great catch! That's the idea- it doesn't pull directly from the minutely section because I'm working on optimizing the code so I can avoid processing things when they're not needed. In this case it was an issue of me hitting the wrong deploy button, so at least an easy fix.
I think I have it all working now- snow in Ottawa is set to start in about 30 minutes, so I'll check then to verify.

Had to go looking for snow somewhere, but this seems to work: 47.43,-74.93,1678732140. You'll notice that it varies slightly from the minutely values, and I should add this to the docs I guess. Minutely is based on the interpolated values, while the currently is just the closest time. Theoretically I suppose interpolated values might be more accurate; however, I like the simplicity of using the raw model result, since it provides a really nice check that everything is working

Was just about to post that I found a place which is showing the precipitation icon. I used 45.512230,-122.658722 which is showing the rain icon.
I noticed that precipitationIntensity is no longer rounded to two decimal points anymore on the currently block like it was before. The issue about fixing rounding is still open so it might be worth just fixing all of them at once?

Big fan of "all at once", and it's set to 2 decimal places now!

Thanks! I also double checked a location outside of the HRRR domain to make sure that it was being rounded there and it is.
Since everything is fixed I'm going to close this issue now.

@alexander0042 I haven't confirmed this for myself but it seems like precipIntensities below 0.44 don't show up in the currently block when I've seen precipIntensity above 0 in the minutely block (I know you said its interpolated).
Outside of the HRRR domain all precipItensity values show no matter if it's enough to trigger the icon or not so is it just a bug in the HRRR domain? If so can you set it to be like GFS where all values show no matter ifs above the threshold to show the icon.

@alexander0042 Has this been looked into at all? I think this was around the time you were either working on the text summaries or Kong so it might have been missed.

@alexander0042 I noticed an oddity when looking at my HA install. I noticed that Thursday the icon is showing rain but Saturday is showing cloudy. Looking at the daily blocks I see the following:
Thursday:
      {
        "time":<PHONE_NUMBER>,
        "icon": "rain",
        "summary": "Rain",
        "sunriseTime":<PHONE_NUMBER>,
        "sunsetTime":<PHONE_NUMBER>,
        "moonPhase": 0.6153030844349172,
        "precipIntensity": 0.0256,
        "precipIntensityMax": 0.1831,
        "precipIntensityMaxTime":<PHONE_NUMBER>,
        "precipProbability": 0.123,
        "precipAccumulation": 0.0588,
        "precipType": "rain",
        "temperatureHigh": 32.79,
        "temperatureHighTime":<PHONE_NUMBER>,
        "temperatureLow": 21.29,
        "temperatureLowTime":<PHONE_NUMBER>,
        "apparentTemperatureHigh": 37.85,
        "apparentTemperatureHighTime":<PHONE_NUMBER>,
        "apparentTemperatureLow": 27.02,
        "apparentTemperatureLowTime":<PHONE_NUMBER>,
        "dewPoint": 18.08,
        "humidity": 0.611,
        "pressure": 1001.67,
        "windSpeed": 10.3,
        "windGust": 20.4,
        "windGustTime":<PHONE_NUMBER>,
        "windBearing": 201.7,
        "cloudCover": 0.639,
        "uvIndex": 7.71,
        "uvIndexTime":<PHONE_NUMBER>,
        "visibility": 16.09,
        "temperatureMin": 20.23,
        "temperatureMinTime":<PHONE_NUMBER>,
        "temperatureMax": 33.16,
        "temperatureMaxTime":<PHONE_NUMBER>,
        "apparentTemperatureMin": 27.02,
        "apparentTemperatureMinTime":<PHONE_NUMBER>,
        "apparentTemperatureMax": 37.85,
        "apparentTemperatureMaxTime":<PHONE_NUMBER>
      },

Saturday:
      {
        "time":<PHONE_NUMBER>,
        "icon": "cloudy",
        "summary": "Cloudy",
        "sunriseTime":<PHONE_NUMBER>,
        "sunsetTime":<PHONE_NUMBER>,
        "moonPhase": 0.6931086499146522,
        "precipIntensity": 0.0368,
        "precipIntensityMax": 0.1066,
        "precipIntensityMaxTime":<PHONE_NUMBER>,
        "precipProbability": 0.181,
        "precipAccumulation": 0.0847,
        "precipType": "rain",
        "temperatureHigh": 25.18,
        "temperatureHighTime":<PHONE_NUMBER>,
        "temperatureLow": 16.12,
        "temperatureLowTime":<PHONE_NUMBER>,
        "apparentTemperatureHigh": 30.44,
        "apparentTemperatureHighTime":<PHONE_NUMBER>,
        "apparentTemperatureLow": 22.12,
        "apparentTemperatureLowTime":<PHONE_NUMBER>,
        "dewPoint": 16.46,
        "humidity": 0.76,
        "pressure": 999.25,
        "windSpeed": 8.34,
        "windGust": 12.88,
        "windGustTime":<PHONE_NUMBER>,
        "windBearing": 188.88,
        "cloudCover": 0.911,
        "uvIndex": 5.83,
        "uvIndexTime":<PHONE_NUMBER>,
        "visibility": 16.09,
        "temperatureMin": 17.36,
        "temperatureMinTime":<PHONE_NUMBER>,
        "temperatureMax": 25.18,
        "temperatureMaxTime":<PHONE_NUMBER>,
        "apparentTemperatureMin": 22.12,
        "apparentTemperatureMinTime":<PHONE_NUMBER>,
        "apparentTemperatureMax": 30.44,
        "apparentTemperatureMaxTime":<PHONE_NUMBER>
      },

Looking at the documentation it says that in order for the rain icon to show it needs to have an accumulation of 1mm or more with a probability of 30% or higher in any hour. Thursday has an accumulation of 0.588mm and Saturday is 0.847mm. As neither of them reach the 1mm accumulation threshold neither of them should show the rain icon but Thursday is and Saturday isn't for some reason.

The bug I posted about last March seems to be fixed? It could just be a case of the model rarely reporting intensities lower than 0.44 mm/h

Thanks for closing! This one is fixed (or at least should be), but I forgot to ping back here


Proposal: Move CII Best Practices Badge to this "Identifying Security Threats" WG

I propose that the "CII Best Practices badge" project be moved into this "Identifying Security Threats" WG as a sub-project, because this WG has a strong focus on metrics. I would continue to maintain the badge project on behalf of this WG. I also propose that changes to the criteria be coordinated between this WG and the best practices WG. Finally, I propose that the next WG meeting vote on this.
As many of you know, the CII Best Practices badge (website, repo) identifies a set of best practices for open source software (focusing on security) and provides badges to projects meeting various criteria. There are over 3,300 particiapting projects and over 400 projects with a badge.
The badging project was created as part of CII, but CII had a 3-year term that has since expired. The LF has continued to fund some work, such as the Best Practices badge work, because it seemed desirable to keep them going. Now that the OpenSSF exists, it seems reasonable to move such projects into the OpenSSF if the OpenSSF wants them. The OpenSSF TAC (which met today) seemed to think it was reasonable, but wanted to make sure that the "receiving" WG was okay with it. I know of nothing that prevents the LF from transferring it to some OpenSSF WG, but that WG must be okay with it!
One complication is that there are really two WGs that would be sensible OpenSSF homes for the CII Best Practices badge: The Best Practices (including education) WG and the Identifying Security Threats (including metrics) WG. I think it's important that it have a single home, and this issue proposes moving it to the "Security Threats" WG because of its metrics focus. However, it's very important that both WGs coordinate. Therefore, I recommend that proposed criteria changes be voted on by both groups (combined), to ensure that everyone's viewpoints are considered. (An alternative would be to move the CII Best Practices Badge into the Best Practices WG, and then both groups vote together. But no matter what, I think it's important to ensure both WGs work together on this, no matter what form it takes.)
I don't believe this directly affect the OpenSSF budget. It takes some money to keep the website running and do occasional maintenance (updating vulnerable libraries, responding to GDPR requests, etc.). But it's relatively small, so I believe the LF will just continue to fund it at that level. If there's a significant increase in effort (e.g., a huge new scope for the project), then that would need a separate discussion.
Alternative approaches welcome!
@kaywilliams @rhaning - I believe this issue, along with others I'm filing, meets the assignment to me at the TAC meeting today 2020-09-22.
Note that this issue partially supports Strategy committee #8 and TAC issue #26, and is consistent with the proposal to the GB that I developed on how to integrate CII work into the OpenSSF should the OpenSSF choose to do so.

Yes, thank you, David.


Vs code android

Hello, I am an Android developer and I want to publish the vs code program for Android. Do you grant the necessary permissions?

I think an official android version of vscode on the play store would be awesome, especially with tablets and Samsung  Dex becoming more powerful and popular.

dupe of #126147

Yes, I created a version but it is not very powerful. I am updating this program. I update about 5 times a month.


[perf] consider making the call to _topChanged async

This should allow better performances & skip expensive walkings of the tree in situations like:
document.$blockingElements.push(el1);
document.$blockingElements.push(el2);
document.$blockingElements.remove(el1);
document.$blockingElements.push(el3);
document.$blockingElements.remove(el2);

If paired with a new flush() method, it should allow the end user to synchronously update the the document inertness.

Closing this, as we need to do operations synchronously especially after https://github.com/PolymerLabs/blockingElements/pull/6 was merged. In particular, we need to know if the new top element is contained in the main document. If this is done asynchronously, it becomes harder to reset the old top element.
For now, we expect this optimization to be done by the user.


Add support for bridge-network-status files

For rdsys we are looking for a way to parse bridge-network-status and bridge-server-descriptor files. I think zoossh will be a good base for it.
I'm opening this pull-req as a start to check if you'll be ok with the idea before I implement everything. Here I add support for bridge-network-status. As we will not parse the CollecTor curated files, but the raw ones coming from the directory authority I added an Unsafe version to the parser functions to read files that doesn't contain the @type annotations.
What do you think about it? Can we design it better to fit into zoossh?

What do you think about it? Can we design it better to fit into zoossh?

I haven't looked at zoossh's code in years and won't be of much help when it comes to design questions.
Other than that, I'm fine with merging whatever code you consider useful as long as it doesn't break backwards compatibility. Another option would be for me to archive this repository, and for you to fork it and continue development in your fork. I'm fine with either option. It's up to you.

Great, then I'll continue working on it and sen you a pull-req with the whole changes we need.
Thanks.


Errors with AoT Github Action

I'm having an intermittent error with the GitHub action for AoT build. The build works locally, but the Github action throws SQL errors sometimes:
Download<EMAIL_ADDRESS>Download<EMAIL_ADDRESS>Download<EMAIL_ADDRESS>Download<EMAIL_ADDRESS>Download<EMAIL_ADDRESS>error: Uncaught (in promise) Error: table data_version already exists in
create table data_version (
  k integer primary key,
  version integer not null
);
insert into data_version (k, version) values (0, 0);
create table kv (
  k blob primary key,
  v blob not null,
  v_encoding integer not null,
  version integer not null
) without rowid;
 at offset 14: Error code 1: SQL error or missing database at ext:deno_kv/01_db.ts:8:17
  const manifest = (await import(toFileUrl(manifestPath).href))
                    ^
    at async build (https://deno.land/x/fresh@1.4.2/src/dev/build.ts:10:21)
    at async dev (https://deno.land/x/fresh@1.4.2/src/dev/dev_command.ts:38:5)

or
Download<EMAIL_ADDRESS>Download<EMAIL_ADDRESS>Download<EMAIL_ADDRESS>Download<EMAIL_ADDRESS>Download<EMAIL_ADDRESS>error: Uncaught (in promise) Error: table data_version already exists: Error code 1: SQL error or missing database at ext:deno_kv/01_db.ts:8:17
  const manifest = (await import(toFileUrl(manifestPath).href))
                    ^
    at async build (https://deno.land/x/fresh@1.4.1/src/dev/build.ts:10:21)
    at async dev (https://deno.land/x/fresh@1.4.1/src/dev/dev_command.ts:38:5)

In the successful run, the above section produced the following output:
Download<EMAIL_ADDRESS>Download<EMAIL_ADDRESS>Download<EMAIL_ADDRESS>Download<EMAIL_ADDRESS>Download<EMAIL_ADDRESS>Download<EMAIL_ADDRESS>Download<EMAIL_ADDRESS>Download<EMAIL_ADDRESS>
The project is using Deno KV, with the --unstable flag in the build command.

Thanks for reporting! This sounds like an issue with Deno KV and not with Fresh. Here is the issue for this in the deno tracker https://github.com/denoland/deno/issues/20196 .


🐛 Validate All Frontmatter Workflow Is Not Working

Cc: @JackDevAU @adamcogan @bradystroud

Hi Team,
Describe the Bug

The workflow "validate-all-frontmatter" has been throwing errors recently.
See: https://github.com/SSWConsulting/SSW.Rules.Content/actions/runs/8444401937/job/23129866293

Figure: The error seems to be related to the schema validator
Expected Behavior

Tasks

[x] Investigate
[x] Fix

More Information

Environment

Device: [e.g. iPhone 12]
Browser: [e.g. chrome, safari]
OS: [e.g. iOS]

Screenshots

Thanks!

Cc: @fenix2222 @tiagov8
Based on my investigation, the rule-1.md added in https://github.com/SSWConsulting/SSW.Rules.Content/pull/8161 caused this issue because no validator schema matches this file.
As per my conversation with @JackDevAU , we agree that this file could be deleted since it's not rendering on Rules and causing the error.
Fixed via https://github.com/SSWConsulting/SSW.Rules.Content/pull/8271 🙂


Add giacintocarlucci.it to webring

giacintocarlucci.it is a personal knowledge base where I like to share projects, blog posts and notes 2 about mostly everything new I can learn as a developer (with some extra arguments pages about my hobbies)3
I've added the webring icon on the right side of the footer.

Cool site!

Thank you @EdwinWenink! I've explored every link on the webring and I remember yours, the dark-mode GIF on the home page made me laugh so much that I added your website in my 'cool websites' list 😂

I didn't even see that! Such an honor :-D Glad you liked it.

Nice website, I can't find where you share your projects tho, but it has a couple of nice pages.
It looks a bit broken for me? Is this what it's supposed to like:

Well you're right, I don't have a 'projects' page as my blog posts are most of the time about some projects or tutorials, do you think I should have a 'projects' page?
Here's what is supposed to look like, tested in firefox and chrome, what browser are you using? (very clean one btw)

Ah! that looks much better :)
I use netsurf, but while it's a bit messy, it's still totally navigable.
Welcome to the webring!


Unrestrict subscribe?

As it currently seems to be the case, only Fragments have been implemented as MvRxView. It certainly does make sense for apps that have minimal number of Activitys and large number of Fragments. I'm working on an app, it has a lot of Activitys, some of them do not even include any Fragment. To be able to use the Activitys as MvRxViews, with little effort, I managed to implement MvRxView for them. I followed the exact same way it was for Fragments. I haven't done extensive testing but it works.
However, the problem in this is that I'm using a function that is restricted to the library package. Would it be ok if it was made public?

This is what I did:
abstract class BaseActivity : BaseMvRxActivity(), MvRxView {
    override val mvrxViewModelStore by lazy { MvRxViewModelStore(viewModelStore) }

    override fun onCreate(savedInstanceState: Bundle?) {
        super.onCreate(savedInstanceState)
        mvrxViewModelStore.restoreViewModels(this, savedInstanceState)
    }

    override fun onSaveInstanceState(outState: Bundle) {
        super.onSaveInstanceState(outState)
        mvrxViewModelStore.saveViewModels(outState)
    }

    override fun onStart() {
        super.onStart()
        // This ensures that invalidate() is called for static screens that don't
        // subscribe to a ViewModel.
        postInvalidate()
    }
}

inline fun <T, reified VM : BaseMvRxViewModel<S>, reified S : MvRxState> T.activityViewModel(
        viewModelClass: KClass<VM> = VM::class,
        noinline keyFactory: () -> String = { viewModelClass.java.name }
) where T : AppCompatActivity, T : MvRxView = lifecycleAwareLazy(this) {
    val stateFactory: () -> S = { _activityViewModelInitialStateProvider(keyFactory) }
    if (this !is MvRxViewModelStoreOwner) throw IllegalArgumentException("Your Activity must be a MvRxViewModelStoreOwner!")
    MvRxViewModelProvider.get(viewModelClass.java, this, keyFactory(), stateFactory)
            .apply { subscribe(this@activityViewModel, subscriber = { postInvalidate() }) } //red line here
}

@Suppress("FunctionName")
inline fun <reified S : MvRxState, T : AppCompatActivity> T._activityViewModelInitialStateProvider(keyFactory: () -> String): S {
    val args: Any? = intent.getBundleExtra(MvRx.KEY_ARG)
    if (this is MvRxViewModelStoreOwner) {
        this.mvrxViewModelStore._saveActivityViewModelArgs(keyFactory(), args)
    } else {
        throw IllegalArgumentException("Your Activity must be a MvRxViewModelStoreOwner!")
    }
    return _initialStateProvider(S::class.java, args)
}

@aneophyte You can use the subscribe methods exposed in MvRxView, so just delete this@activityViewModel.
However -- we haven't been consistent on this -- but all the methods named starting with _ are also not meant to be publicly used.
I feel like a solution here is to change MvRxExtensions.viewModel to apply a subscribe call if the receiver is a MvRxView.
However, I would be hesitant to make this change without first understanding a bit more about what your refactoring to MvRx looks like. One of MvRx opinion's is that activities are just shells for fragments. It makes sense that this is different than may exist in applications which want to switch to MvRx. However I would imagine you will already need to refactor your activity to confirm to the invalidate model, and am curious how much extra work it would be to pull it into a fragment?

I haven't used any subscribe method outside the extension function. The subscribe method in question came because it was part of the activityViewModel method. This is the method, I believe, that is used to create view model under the activity scope. It leads me to another question that if that subscribe method were to be removed, would persistence and lifecycle related stuff work?
MvRxExtensions.viewModel is definitely the better option, though the restriction is still there. I tried to make an extension function around it.
This is how I'm using activityViewModel currently.
class SimpleActivity : BaseActivity() {
    val viewModel by activityViewModel(ActivitySplashViewModel::class)

    override fun invalidate() {
        withState(viewModel) {
        }
    }

    override fun onCreate(savedInstanceState: Bundle?) {
        super.onCreate(savedInstanceState)
        setContentView(R.layout.activity_simple)
    }
}

kotlin
The problem with refactoring to Fragments, here in my case, is a lot has been written already and would require quite a lot of changing. And moving from Activity based flow to Fragment one, I suppose would require using the Navigation library from the AndroidX family. I'm a bit hesitant with that because it's currently in experimental state, also I did not have pleasant experience in using Fragments as a prominent thing in previous projects.
Having said all this, maybe applying your solution would allow Activitys to be used as Views, would make the library more open for developers opting to use Activity, but to be honest, I don't really want my requirements to affect the conventions that MvRx has opted for.
Thanks for the input! I apologize for responding late.

@aneophyte I'm going to close this for now because we don't plan on adding support for Activities out of the box but you can also make your base activity implement MvRxView.
Fragments are also not tied in any way to jetpack navigation.


Improvement on collecting/updating Secondary Storage total size/capacity

Improvement request:

the capacity of the Secondary Storage seem updated/obtained from time to time, by SSVMs and the value (capacity) is held in the memory of the mgmt server.

In certain cases, this becomes a very... useless... design, where the values can not be altered in case of edge cases where the Secondary Storage capacity needs to be expanded, but SSVMs are not running/existing, for whatever reason.
Proposal:

store the capacity of the SS in the DB (perhaps op_host_capacity table, like for the Primary data, and other resource values)
Enable a global setting that will control the interval of the capacity collection from the NFS Secondary Storage
Consider offloading the work to the mgmt server, as per architecture design, all mgmt servers MUST be able to mount the secondary storage NFS shares (for various other tasks)
Consider implementing an explicit API call that will trigger updating the SS NFS capacities (in cases where the backend capacity has been expanded)

@anddrijapanicsb, so far I implemented a API/UI change to update the value in the DB, but the value returned is still coming from the StatsCollector. When a manual change has been done that disagrees with the actual/discovered size, which do we consider when/on what grounds?

As discussed, consider the value from the DB during the boot of the mgmt server (instead of having null or zero value, whatever is the case currently), but when the stats collectors runs for the next time (when SSVM returns the size of the SS), then update in-memory capacity as well as the capacity inside the DB (that was set manually/via API/UI).

Fixed by https://github.com/apache/cloudstack/pull/8941 tested by @kiranchavala
@andrijapanicsb pl review and discuss if this is enough, re-open the issue if more work in needed.


seeclick-aitw checkpoint publish?

有计划发布seeclick在aitw微调后的模型权重嘛？🙏

我正在上传AITW微调的ckpt到Huggingface，应该今晚可以上传完成，你可以试一试~
I'm uploading the AITW fine-tuned LoRA checkpoint (maybe completed tonight). You can have a try~

太棒了！谢谢!
That's awesome! Thank you!


Fix typo from 'customer' to 'consumer'

Change other occurrences of 'customer' to 'consumer'.
Note: There's a merge and another commit, because I used tilda (`) in the commit message the first time and it turned into a space.

@thanakritlee Please sign the Contributor License Agreement!
Click here to manually synchronize the status of this Pull Request.
See the FAQ for frequently asked questions.


Little typo in the documentation

Little typo of using yup instead of zod in an example ;)
https://saas-ui.dev/docs/components/forms/step-form#with-zod-schemas

Thanks for the heads up!


Flickering when the taskbar style is set to acrylic.

It's so strange. If my taskbar is set to acrylic every time I open start menu or switch window my taskbar flickers. No problem on all other modes. Right now I'm on blur with 10% alpha  and it's pretty close to acrylic in looks, but i like the original acrylic style more. If I can be helpful with something I can send screenrecording of the bug.

Yep, this can't be fixed as this is kind of a feature when using the acrylic style.


comment-on-draft-pr-indicator broken on pull request files

Description
On PR conversations it works fine.
How to replicate the issue

Open https://github.com//refined-github/refined-github/pull/5807/files
Click any line to bring up comment popup
Notice comment button texts aren't changed

Extension version
22.7.11
Browser(s) used
Chrome

Honestly I think this feature is biased. Reading #3857 I feel it is solving a very specific need. Why doesn't it also tell you are commenting on a closed PR? Or merged PRs? Or ancient (say, > 1000 days) PRs?

Regarding ancient PRs: we could add a banner near the comment box on issues that says “this issue was closed 2 years ago”
Alternatively, yes, I wouldn’t mind adding a warning icon right next to the button:

⚠ Draft [Comment]
⚠ Old [Comment]

With tooltip on the ⚠ or ℹ that explains the warning better.


Circle selected back

Hi, how i made circle back with selected view?
Like:

@Maxim-Zakopaylov Please provide details about what you want to achieve. So far it doesn't look like a question related to this library, but I may be wrong


Individual Field Error Handling for Field Array

❓Question
I created minimal example code in https://codesandbox.io/s/affectionate-keller-izkkb and needs to show errors in Material UI components for individual fields.
But initially errors.chequePayments goes empty object.
Anyway to handle this?

Have a look at this: https://codesandbox.io/s/keen-sun-g7kcd?fontsize=14
It should give you the basic idea of what's happening. Make sure you optimize the code before you use it 🙂

Closing due to long inactivity


Last update 8d11bb0...29870c6


JsonpTemplatePlugin should create script tag with 'module' attribute for lazy es2015 chunks

Feature request
Note: I am using Angular 9 CLI with es2015 bundles and HTTP/2 server push.
What is the expected behavior?
When the script tags for initial chunks are written to index.html they use module and nomodule to allow the browser to determine the appropriate one.
eg.
<script src="/main-es2015.24ec32575701ca957fc1.js" type="module"></script>
<script src="/main-es5.24ec32575701ca957fc1.js" nomodule defer>

When deferred chunks are loaded (eg. for an Angular feature module) the following script tag is added by JsonpTemplatePlugin:
<script charset="utf-8" src="/3-es2015.8251cd5df78bdf8f7377.js"></script>

This does not contain the type="module" attribute. As a result the browser's ability to efficiently parse the file is not fully realized.
What is motivation or use case for adding/changing the behavior?

es2015 modules are not just regular scripts and they shouldn't be loaded with just a plain script tag.

V8 (Chrome's JavaScript engine) parses and compiles modules differently from other JavaScript.  doesn't provide any way of indicating that the file being loaded is a module, so all the browser can do is load the file and put it in the cache. Once the script is loaded using a

output.jsonpScriptType: "module"
see https://webpack.js.org/configuration/output/#outputjsonpscripttype

@sokra thanks. this was an easy fix for me - I don't need to support IE11 :-)
Out of curiousity have you ever considered an optional lambda that would allow the chunk filename to determine the script type? eg.
output.jsonpScriptType = (filename) => filename.includes('es2015') ? 'module' : 'text/javascript';

Angular CLI is set up by default to create both '-es2015 and '-es5 files so for anyone that needs to support IE11 I think setting type="module" won't work.


usb: logs: Use original logger functions

When CONFIG_LOG_FUNCTION_NAME is defined to not add name again.
Signed-off-by: Andrei Emeltchenko<EMAIL_ADDRESS>

Codecov Report

Merging #11001 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master   #11001   +/-   ##
=======================================
  Coverage   53.21%   53.21%
=======================================
  Files         217      217
  Lines       26667    26667
  Branches     5913     5913
=======================================
  Hits        14192    14192
  Misses      10059    10059
  Partials     2416     2416

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0f1b6ff...d0d5598. Read the comment docs.

usb: logs: Use original logger functions

This sounds confusing to me. Do you switch from new CONFIG_LOG to the original CONFIG_SYS_LOG?

usb: logs: Use original logger functions

This sounds confusing to me. Do you switch from new CONFIG_LOG to the original CONFIG_SYS_LOG?

No

I was trying to make every commit buildable and logically complete.

the whole thing could have been done in  1 single commit :-)


Sync macOS VMs to time server

Description
Force the newly-created VM to sync to Apple's time server.
01:26 +30: test/commands.shard/permeable/create_test.dart: (setUpAll)                                                                                Expected: ''
  Actual: 'Warning: File "/private/tmp/flutter sdk/dev/automated_tests/pubspec.yaml" was created in the future. Optimizations that rely on comparing time stamps will be unreliable. Check your system clock for accuracy.\n'
            'The timestamp was: 2020-04-27 07:23:07.000\n'
            'The time now is: 2020-04-20 07:30:13.981602\n'
            'Warning: File "/private/tmp/flutter sdk/dev/automated_tests/pubspec.yaml" was created in the future. Optimizations that rely on comparing time stamps will be unreliable. Check your system clock for accuracy.\n'
            'The timestamp was: 2020-04-27 07:23:07.000\n'
            'The time now is: 2020-04-20 07:30:14.449133\n'
            ''

Still unclear how Dart's filesystem could have the right date if the system clock is wrong...
Checklist

[x] I read the [Contributor Guide] and followed the process outlined there for submitting PRs.
[x] I signed the [CLA].
[x] I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement].
[x] I read the [Tree Hygiene] wiki page, which explains my responsibilities.
[x] I updated/added relevant documentation (doc comments with ///).
[x] All existing and new tests are passing.
[x] The analyzer (flutter analyze --flutter-repo) does not report any problems on my PR.
[x] I am willing to follow-up on review comments in a timely manner.

Breaking Change

[x] No, no existing tests failed, so this is not a breaking change.
[ ] Yes, this is a breaking change. If not, delete the remainder of this section.

This is a failure in a comparison of the times reported between a file stat call and gettimeofday:
https://github.com/dart-lang/sdk/blob/14ff2110ce74944cc6ff9f922f55e940bc4285ad/runtime/vm/os_macos.cc#L74

This is a failure in a comparison of the times reported between a file stat call and gettimeofday:
https://github.com/dart-lang/sdk/blob/14ff2110ce74944cc6ff9f922f55e940bc4285ad/runtime/vm/os_macos.cc#L74

Yeah this is useless, @fkorotkov says this is already done, and I now see the filesystem is right:
https://cirrus-ci.com/task/6009414016565248?command=setup#L1
date
Mon Apr 27 07:23:10 PDT 2020

Expected: ''
  Actual: 'Warning: File "/private/tmp/flutter sdk/dev/automated_tests/pubspec.yaml" was created in the future. Optimizations that rely on comparing time stamps will be unreliable. Check your system clock for accuracy.\n'
            'The timestamp was: 2020-04-27 07:23:07.000\n'
            'The time now is: 2020-04-20 07:30:13.981602\n'
            'Warning: File "/private/tmp/flutter sdk/dev/automated_tests/pubspec.yaml" was created in the future. Optimizations that rely on comparing time stamps will be unreliable. Check your system clock for accuracy.\n'
            'The timestamp was: 2020-04-27 07:23:07.000\n'
            'The time now is: 2020-04-20 07:30:14.449133\n'


The link to "Publishing Analytics Events to External Systems" is broken

Location : https://apim.docs.wso2.com/en/latest/api-analytics/viewing/view-overview-of-api-analytics/
The link to "Publishing Analytics Events to External Systems" is broken. It appears to repeatedly redirect to itself.

Fixed in https://github.com/wso2/docs-apim/pull/4404


Chapter 3 not supporting Python 3.11.2 Flask

Line 12 (from flask import Flask, request, render_template) gives the error: "ImportError: cannot import name 'Mapping' from 'collections'" in flask_api_server.py

I will no longer use the requirements.txt to set up the environment as it is outdated...

Hi, the code in this repo and its dependencies are frozen at the date of the book's publication so that the examples in the book match the code in this repo. Hence, you will need to use the library versions in requirements.txt to follow along with the book.


Clean up Enable secret storage

dotnet user-secrets init is missing and the VS version is hidden in a TIP

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 9c99993c-c983-6fda-6c3a-ce4ec8c1d5db
Version Independent ID: ba688ac2-e90e-fce5-f60d-40c2553c3efd
Content: Safe storage of app secrets in development in ASP.NET Core
Content Source: aspnetcore/security/app-secrets.md
Product: aspnet-core
Technology: aspnetcore-security
GitHub Login: @Rick-Anderson
Microsoft Alias: scaddie

The dotnet user-secrets init command becomes visible when selecting 3.0 or later. The command was added in the 3.0 SDK. See https://docs.microsoft.com/aspnet/core/security/app-secrets?view=aspnetcore-3.0&tabs=windows#enable-secret-storage.

The entire doc is ::: moniker  train wreck. In the next update we need to make 3 version and get rid of all the 1.0 stuff.
It shouldn't say
The Secret Manager tool includes an init command in .NET Core SDK 3.0.100 or later.
The 3.x version should just show the init command.