add ibc types in default interfaces

Codecov Report

Merging #6 (c6a6a3e) into master (ba4d0f3) will increase coverage by 0.41%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master       #6      +/-   ##
==========================================
+ Coverage   77.35%   77.77%   +0.41%
==========================================
  Files           4        4
  Lines          53       54       +1
==========================================
+ Hits           41       42       +1
  Misses          6        6
  Partials        6        6

Impacted Files
Coverage Δ

types.go
100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ba4d0f3...c6a6a3e. Read the comment docs.


Can't anymore use nuxt as devDependencies, because nuxt-start is missing vue-client-only

Version
v2.9.1
Reproduction link
http://none
Steps to reproduce
add nuxt  to the  devDependencies npm i -D nuxt
add nuxt-start to the dependencies npm i nuxt-start
build the app npx nuxt build
run  npm ci --production for production dependencies
run nuxt: npx nuxt-start
What is expected ?
Nuxt to run normally
What is actually happening?
ERROR  Cannot find module 'vue-client-only'

  at Function.module.exports [as sync] (node_modules/resolve/lib/sync.js:74:15)
  at node_modules/vue-server-renderer/build.prod.js:1:77711
  at Object.<anonymous> (server.js:1:0)
  at r (server.js:1:0)
  at Module.<anonymous> (server.js:1:0)
  at r (server.js:1:0)
  at Object.<anonymous> (server.js:1:0)
  at r (server.js:1:0)
  at server.js:1:1432
  at Object.<anonymous> (server.js:1:0)

Additional comments?
Before Nuxt 2.9 this was  possible to do this without any problems

This bug report is available on Nuxt community (#c9667)

Unfortunately I cannot reproduce this with the hello world example, have you tried removing your node_modules dir and package lock?

@pimlie I think you need to use <no-ssr> or the new <client-only>  in one of your components
I try to build a example in the mean time

@victor-perez Ah right, never mind. The dep seems to be missing indeed

Thanks for the report!


[$500] iOS - BA - Confirm button on double check pages is closer to the bottom than other pages

If you haven’t already, check out our contributing guidelines for onboarding and email<EMAIL_ADDRESS>to request to join our Slack channel!

Version Number: v1.4.44-4
Reproducible in staging?: y
Reproducible in production?: y
Issue reported by: Applause - Internal Team
Issue found when executing PR: https://github.com/Expensify/App/pull/37025
Action Performed:
Pre-requisite: the user must be logged in and have created a workspace.

Go to Workspace > Bank account.
Initiate the add bank account flow until you reach a double check page (for account selection, personal information, company information)
Verify the Confirm button is displayed closer to the button than the other pages.

Expected Result:
The Confirm button should be displayed on the same place as the other pages.
Actual Result:
The Confirm button is displayed closer to the button than the other pages.
Workaround:
Unknown
Platforms:

Which of our officially supported platforms is this issue occurring on?

[ ] Android: Native
[ ] Android: mWeb Chrome
[x] iOS: Native
[ ] iOS: mWeb Safari
[ ] MacOS: Chrome / Safari
[ ] MacOS: Desktop

Screenshots/Videos
Add any screenshot/video evidence

View all open jobs on GitHub
Upwork Automation - Do Not Edit

Upwork Job URL: https://www.upwork.com/jobs/~01a9093a007c21da81
Upwork Job ID:<PHONE_NUMBER>160367616
Last Price Increase: 2024-03-04

@bfitzexpensify I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors.

Proposal
Please re-state the problem that we are trying to solve in this issue.
The bank info confirmation button is too close at the button compared to other page.
What is the root cause of that problem?
The bank info page is wrapped with a screen wrapper that disables includeSafeAreaPaddingBottom because it contains a form which already has it,
https://github.com/Expensify/App/blob/22cb01c968a53407f7a9d864bfba30f41366f6a0/src/pages/ReimbursementAccount/BankInfo/BankInfo.tsx#L134-L137
except for confirmation sub step because it just uses a plain scroll view.
https://github.com/Expensify/App/blob/22cb01c968a53407f7a9d864bfba30f41366f6a0/src/pages/ReimbursementAccount/BankInfo/substeps/Confirmation.tsx#L49-L51
This also happens to other bank account confirmation sub step (personal info confirmation, business info confirmation, etc.).
What changes do you think we should make in order to solve the problem?

We should enable includeSafeAreaPaddingBottom when the page requires it, that is the confirmation page. There are many ways to do it, but some examples are:

wrap each page with SafeAreaConsumer to get the safeAreaPaddingBottomStyle and apply it to the root view.

<SafeAreaConsumer>
    {({safeAreaPaddingBottomStyle}) => (
        <ScrollView ... contentContainerStyle={[..., safeAreaPaddingBottomStyle]}>

in the parent step component, enable includeSafeAreaPaddingBottom if the sub step is the confirmation step

includeSafeAreaPaddingBottom={SubStep === Confirmation}

assuming the confirmation page is always at the last page, we can enable includeSafeAreaPaddingBottom if the sub step index is the last item

includeSafeAreaPaddingBottom={screenIndex === manualSubsteps.length - 1}

enrich the sub step component array by adding includeSafeAreaPaddingBottom property to it.

const manualSubsteps = [{component: Manual}, {component: Confirmation, includeSafeAreaPaddingBottom: true}];
...
includeSafeAreaPaddingBottom={!!SubStep.includeSafeAreaPaddingBottom}
...
<SubStep.Component

Yes, definitely something we want to fix. @Ollyws, looks like we have a couple of proposals already ready for review

Proposal
Problem:
The "Confirm" button at the bottom of the screen  is not at the same height as other buttons for other sub steps
Cause of the problem:
The issue is that this confirmation page is missing the SafeAreaConsumer that provides the proper padding for the bottom. Since the other steps are forms the SafeAreaConsumer is included in that making the other screens behave correctly.
Solution:
Add the SafeAreaConsumer to this screen to make it behave the same as other screens. There may be other screens that also don't have a form and display the bottom button in the wrong place. The solution should be applied to those screens as well.

Contributor details
Your Expensify account email<EMAIL_ADDRESS>Upwork Profile Link: https://www.upwork.com/freelancers/~01c16575c840ed0ce7

I think it's best we go with the SafeAreaConsumer solution.

This sounds good to me too

Weird those failed. You know anything about it @bfitzexpensify? Maybe ask in #bug-zero?

PR is ready
cc: @Ollyws

@Ollyws & @bernhardoj - in Upwork, I'm seeing that the offer for this job has been sent to both of you and is awaiting acceptance, but given this comment, I suspect that that might not be correct.
Job name is [$500] iOS - BA - Confirm button on double check pages is closer to the bottom than other pages #37339 - do you both have an Upwork offer tied to that?

We received the offer but can't accept it.

Gotcha. I've re-sent the offers, let me know if they're working or not. I might need to recreate the job fully if they aren't.

It works, accepted

Cool, payments complete, regression steps proposed in https://github.com/Expensify/Expensify/issues/381507, closing this out - thanks everyone.


Frends.SFTP.UploadFiles error message has wrong source path.

Destination server address is added to the source path in the error message.

Fixed in PR #74


removed redundant chest type assertion

bumping this rq because I kinda need this atm, I want to implement hoppers externally.
I could still do it with very hacky stuff, but I'd rather just get this merged instead

it would also allow me to remove this hacky feature from my inv menu library

instead of removing the whole check, maybe replace it with this?
		return s.armour.Inventory(), true
	case protocol.ContainerLevelEntity:
		if s.containerOpened.Load() {
			b := s.c.World().Block(s.openedPos.Load())
-			if _, chest := b.(block.Chest); chest {
+			if _, container := b.(block.Container); container {
				return s.openedWindow.Load(), true
			} else if _, enderChest := b.(block.EnderChest); enderChest {
				return s.openedWindow.Load(), true
			}
		}
	case protocol.ContainerBarrel:
		if s.containerOpened.Load() {

Do hoppers not have a different ID entirely like barrels?

Do hoppers not have a different ID entirely like barrels?

yeah but I can change that quite easily with just a simple block check with a packet handler

Do hoppers not have a different ID entirely like barrels?

nope, as you can see here, this is what I did for my hopper PR, and it works just fine

Do hoppers not have a different ID entirely like barrels?

nope, as you can see here, this is what I did for my hopper PR, and it works just fine

it is true that the containertype is different, but I could fix this myself on my side, anyway, this is about the redundant assert checks, I don't think it matters if hoppers have a different ID or not


FR: batched mapping for named_axes.nmap

Sometimes nmap'ed computations don't all fit in memory at once and there are not enough devices to shard the computation over (this is limitation is particularly salient when using penzai because adding an arbitrary number of named axes is so darn convenient :) )
Jax now supports symantics for batched vmapping with jax.lax.map. This would be awesome to add to Penzai!

Hm, interesting idea!
One question is what the API for this should be. Some ideas:

Add a keyword argument to nmap: Something like nmap(fn, batch_sizes={"foo":2, "bar":4}). This would be easy to implement, but a disadvantage is that you'd need to plumb through the batch sizes for each axis into each computation. For instance, if you wanted to add a new batch axis but map over it, you'd need to modify all of the calls to nmap inside the function you are calling, which would be fairly annoying.
Bind it to the named array: Named arrays could store a batch size for each of their axes, similar to how JAX arrays store shardings. Then any nmap call could automatically pick up and use the batch size. I think this would be pretty complex to implement, though. It also doesn't compose well with tag/untag, although I guess the rule could just be that untagging an axis resets its batching size?
Use a context manager: We could have a context manager that determines how batch sizes for each axis name are determined, and then all nmap calls inside the context manager would read from it. That would make it easier to specify batch sizes on a per-name level. However, it might not work well with JAX tracing, since tracers would have to be aware of the context manager somehow.

It occurs to me that adding batched mapping directly to nmap may not be the right thing to do here.
I'm thinking about this feature in the context of batching model evaluations on a grid of data inputs.
This is important when serving models with many requests coming in or performing a grid search over hyperparameters, just to give two examples. In this context, I only ever want to batch over the outermost code.
You might imagine that an arbitrary neural network in Penzai looks something like this under the hood:
def eval_nn(x):
    x = nmap(custom_layer_1)(x)
    x = nmap(custom_layer_2)(x)
    x = nmap(custom_layer_3)(x)
    return x

When we batch-nmap this over a grid, the batching will be pushed inside each nmap if we use any global configuration applied to the nmap operator (as in the binding or context manager proposal).
e.g:
def eval_nn(x):
    x = nmap(custom_layer_1)(x)
    x = nmap(custom_layer_2)(x)
    x = nmap(custom_layer_3)(x)
    return x

inputs = pz.nx.ones({"batch": 1_000, "x": 50, "y": 50})

with pz.nx.batch_nmap(batch_sizes={"batch": 10}):
    eval_nn(x)

will evaluate to:
def eval_nn(x):
    x = nmap(custom_layer_1, batch=10)(x)
    x = nmap(custom_layer_2, batch=10)(x)
    x = nmap(custom_layer_3, batch=10)(x)
    return x

I made a little micro-benchmark and piping the map ~40% slower than batch-mapping the outside on Jax 0.4.31 with an Nvidia GeForce 4090, likely due to the transfer overheads between the host and device after each scan.

#%%
import jax
import jax.numpy as jnp
import jax.random as random

def layer(arr):
    return jnp.matmul(arr, arr - jnp.mean(arr))

BATCH_SIZE = 20

def map_each_layer(batch_of_arrs):
    batch_of_arrs = jax.lax.map(layer, batch_of_arrs, batch_size=BATCH_SIZE)
    batch_of_arrs = jax.lax.map(layer, batch_of_arrs, batch_size=BATCH_SIZE)
    batch_of_arrs = jax.lax.map(layer, batch_of_arrs, batch_size=BATCH_SIZE)
    batch_of_arrs = jax.lax.map(layer, batch_of_arrs, batch_size=BATCH_SIZE)
    batch_of_arrs = jax.lax.map(layer, batch_of_arrs, batch_size=BATCH_SIZE)

    return batch_of_arrs

def all_layers(arr):
    arr = layer(arr)
    arr = layer(arr)
    arr = layer(arr)
    arr = layer(arr)
    arr = layer(arr)
    return arr

def map_all_layers(batch_of_arrs):
    return jax.lax.map(all_layers, batch_of_arrs, batch_size=BATCH_SIZE)

map_each_layer_jit = jax.jit(map_each_layer)
map_all_layers_jit = jax.jit(map_all_layers)

batch_of_arrs = random.normal(random.PRNGKey(0), (500, 100, 100))
#%%
%time map_each_layer_jit(batch_of_arrs).block_until_ready()
%time map_all_layers_jit(batch_of_arrs).block_until_ready()
#%%
%timeit map_each_layer_jit(batch_of_arrs).block_until_ready()
%timeit map_all_layers_jit(batch_of_arrs).block_until_ready()
# %%

143 ms ± 72.2 µs per loop (mean ± std. dev. of 7 runs, 10 loops each) # internal piping of scan
105 ms ± 68.4 µs per loop (mean ± std. dev. of 7 runs, 10 loops each) # one map on the outside

Instead, maybe we should have some function pz.nx.batch (this could also be a decorator) that batch-nmaps only over the specified axes and does not pipe in the mapping to the internal functions.
Like lax.map, this would just be syntactic sugar over lax.scan. Here's some rough pseudo-code:
def batch(fn, xs, batch_sizes=None):
    if batch_sizes is None:
        batch_sizes = {}
    batch_axes, axis_sizes = tuple(batch_sizes.keys()), tuple(batch_sizes.items())
    xs = xs.untag(*batch_axes).reshape((-1,) + axis_sizes)

    return pz.nx.stack(pz.nx.scan(fn, axes=batch_axes), axes=batch_axes)

# usage:
inputs = pz.nx.ones({"batch": 1_000, "x": 50, "y": 50})
pz.nx.batch(eval_nn, batch_sizes={"batch": 10})(inputs)

What do you think?

I wrote up a prototype of this functionality described above ^ here:  https://gist.github.com/amifalk/e21059da7f0c0ecb3db8240604413998
I realized there's no benefit to allowing different batch sizes for different axes given that they're all evaluated independently. In the worst case, the remainder named array won't have the same shape as the batch array, so it will not be possible to broadcast them back together.

I agree that having a single scan at the outside seems better than having a number of smaller scans in the inside for this use case. Thanks for running the benchmark, and for taking a stab at the implementation!
I wonder if the best solution here would be to aim to match the semantics of jax.lax.map with a named-axis version, similar to the relationship between jax.lax.scan and pz.nx.scan. If so, this would suggest that:

the mapped-over axis should be a single axis (to keep it simple, similar to the APIs for jax.lax.map and pz.nx.scan)
however, unlike jax.lax.map, the mapped-over axis should be a named axis (like pz.nx.scan)
the batch_size option should be optional (similar to jax.lax.map), and default to 1
the axis being mapped over should be removed from the inputs, and added back to the outputs, instead of still appearing inside with a smaller size and requiring f to keep it as-is
ideally, it should be OK to have positional axes, and they should just be passed through transparently

One question is what the name of this should be:

pz.nx.map would fit with pz.nx.scan, but might get confused with pz.nx.nmap?
pz.nx.serial_map is more explicit but more verbose.

What do you think?
(This makes me think of a related question: would it be useful to provide pz.nx.vmap which is like jax.vmap but maps over a single named axis in parallel, keeping all the other named axes? This would pull the batching out instead of pushing it inward to the inner functions. I'm not sure if there's much of a reason to have this, though. Perhaps avoiding name conflicts?)

Agreed w.r.t. all points emulating jax.lax.map. My gut says the name pz.nx.map is fine given that it will have a different function signature then nmap, but I don't have a strong feeling between that and serial_map.
On pz.nx.vmap, I would guess the XLA wouldn't change and it strikes me as a bit of an anti-pattern that would make functions more brittle and might confuse new users (once you nmap, you never go back!).


Get_img Failed! warning

I've been getting this warning every time I tried using X-Plane 11 with auto ortho. The game does load and doesn't crash, but many scenery tiles are just one color or just pixels. Any idea what is causing this and how to fix it?

I've set it to 1.0 and it helped a bit and now I set it to 2.0 and it works much better. I still get the same warning, but much less now and almost all of the scenery tiles look good and only a few small ones that are pixelated.


Support Visual Studio 2019.

I think this is correct according to the documentation for CMake 3.10 and newer.
It'd depend on alexcrichton/cc-rs#386 or equivalent to work with the Vs16 symbol.
Fixes #70.

Thanks for the PR!
I think bumping the required cmake version is pretty reasonable as well, as it's at least a year old and shouldn't be too hard to update!
Want to update this PR with an updated dependency on cc and I can merge?

Sure. I'm very new to working with Rust stuff, so if I get something wrong, feel free to poke me to fix it.
I tried shoving a local copy of harfbuzz-sys at the local version of cmake-rs, so I'm hoping it's working right now. :)


Doesn't work in 2.10

It simply doesnt work in 2.10. I tried to set up a minimal toggle button in a new project but nothing happens to the button when i click. It does not toggle.

Thanks, will investigate.

@sibijohn72, could you provide some code? It would be nice to see on using of the component and your config for it at environment.js if it exists.

Btw, for me, it works well on 2.10.

I can reproduce in 2.11. The problem seems to be that this component incorrectly call the onToggle function on init, causing the dread"Assertion Failed: You modified "v1" twice on <dummy@controller:application::ember294> in a single render.
I'm investigating a fix.

@cibernox, could you provide the code as well? Let us know how do you actually use the x-toggle  component, please :)

@lancedikson No need. The very test suite is a good example of the bug: https://travis-ci.org/knownasilya/ember-cli-toggle/jobs/196596235

What's the status of this issue? I've tried using it with ember-cli 2.11.1, and I so no widget when I use the component (no errors in console though).

Did you try version 3.0?

@knownasilya yes, the latest one available on npm

@knownasilya the default theme works
{{x-toggle
  value=newUsersOnlyToggle
  showLabels=true
  onLabel='Enabled::true'
  offLabel='Disabled::false'
  onToggle=(mut newUsersOnlyToggle)
}}

but then, as soon as I specify the theme attribute, the widget renders only labels, without the control.

@knownasilya yes, the latest one available on npm.
It turned out, that the default theme works fine
{{x-toggle
  value=myValue
  showLabels=true
  onLabel='Enabled::true'
  offLabel='Disabled::false'
  onToggle=(mut myValue)
}}

but then, as soon as I specify a non-default theme attribute, the widget renders only labels, without the control.

You must opt into other themes, see the configuration section in the readme.


Ctrl+A in TextEditor should select all text

Is there an existing issue for this?

[X] I have searched the existing issues.

Is this issue related to iced?

[X] My hardware is compatible and my graphics drivers are up-to-date.

What happened?
Here's an SSCCE. Try typing in the text field and pressing Ctrl + A.
use iced::{Settings, Sandbox, window};
use iced::widget::{text_editor, container};

fn main() -> iced::Result {
    App::run(Settings {
        window: window::Settings {
            size: (640, 480),
            ..Default::default()
        },
        ..Default::default()
    })?;

    Ok(())
}

struct App {
    content: text_editor::Content,
}

#[derive(Debug, Clone)]
enum AppMessage {
    Edit(text_editor::Action)
}

impl Sandbox for App {
    type Message = AppMessage;

    fn new() -> Self {
        Self {
            content: text_editor::Content::new()
        }
    }

    fn title(&self) -> String {
        String::from("example")
    }

    fn update(&mut self, message: Self::Message) {
        match message {
            AppMessage::Edit(action) => {
                self.content.perform(action);
            },
        }
    }

    fn view(&self) -> iced::Element<'_, Self::Message> {
        let edit_box = text_editor(&self.content).on_action(AppMessage::Edit);

        container(edit_box).padding(10).into()
    }
}

What is the expected behavior?
It should select all the text in the text editor.
Version
master
Operating System
Linux
Do you have any log output?
Below is log output.  Moving the cursor from the start of a file to the end of a file is seriously really slow. The bottle neck can be found in the TextEditor's layout and draw functions. I only looked into the layout function because the problem seems to lie within cosmic_text. Specifically, the TextEditor layout function calls the iced graphics text editor update function which then calls cosmic_text editor shape_as_needed function.
The problem with shape_as_needed is that it calculates and caches the layout of all the lines which haven't been cached. Of course, this is an issue because if we jump from the start of a 1000 line file to the end, we only really see the last 30 or so lines depending on the size of the editor. Yet, the layout of more than 900 unseen lines are being computed.
Also, as previously mentioned the draw function is also really slow during this process. I haven't looked into it too much, but I'm pretty sure it has to do with the internal.editor.highlight() call.
Currently a select all feature could be implemented but it'd be unusable unless there's a way to get around the unnecessary processing.

Note: this should be Cmd+A on macOS. On macOS Ctrl+A is emacs-style "move cursor to start of line" (and Ctrl+E is "move cursor to end of line").


Regression: Can't install 1.1.3 Package in GitHub actions for MSTest projects (1.0.3 is fine)

Describe the bug
We're trying to update our Windows App SDK version in our project here: https://github.com/CommunityToolkit/Labs-Windows/pull/183
This is still failing to install in our GitHub action CI when trying to run our tests with MSTest with the following message:
Installing missing frameworks...
DEP0800: The required framework "C:\Users\runneradmin\.nuget\packages\microsoft.windowsappsdk\1.1.3\buildTransitive\..\tools\MSIX\win10-x64\Microsoft.WindowsAppRuntime.1.1.msix" failed to install. [0x80073CF9] Deployment Add operation with target volume C: on Package Microsoft.WindowsAppRuntime.1.1_1003.565.600.0_x64__8wekyb3d8bbwe from:  (Microsoft.WindowsAppRuntime.1.1.msix)  failed with error 0x8000000B. See http://go.microsoft.com/fwlink/?LinkId=235160 for help diagnosing app deployment issues.
	DeploymentSucceeded = False
	DeploymentError = Err_Deploy_SDKInstall
	DeploymentUserError = False
	DeploymentHRESULT =<PHONE_NUMBER>
	HasSharedCode = False
	SDKFileName =
Deleting file "vs.appxrecipe" from layout...

This seems like it's still a problem related to changes which broke 1.0.3 in #2631.
Our CI (and VS) have no issues when running with 1.0.3.
This is blocking us from updating to 1.1.x still which we need for other fixes (though still trying to identify if there are other blocking issues related to MSTest but can't validate what's working in our CI first because of these deployment issues since 1.1.1).
Steps to reproduce the bug
See https://github.com/CommunityToolkit/Labs-Windows/runs/7460607269?check_suite_focus=true

Create MSTest project for Windows App SDK
Create GitHub workflow to run windows-latest with a step to execute tests after building them in release mode:

  - name: Run experiment tests against WinAppSDK
    run:  vstest.console.exe ./tests/**/ProjectName.Tests.WinAppSdk.build.appxrecipe /Framework:FrameworkUap10 /logger:"trx;LogFileName=WinAppSdk.trx"

See failure to install package.
Expected behavior
Package installs and tests run.
Screenshots

NuGet package version
1.1.3
Packaging type
Packaged (MSIX)
Windows version
Windows 10 version 21H2 (19044, November 2021 Update)
IDE
Visual Studio 2022
Additional context
Related to Regression #2631 (fixed for main build, but still failing for mstest - raising this new issue to track specifically as haven't gotten traction replying to closed issue there)
Also see #2706

Installing missing frameworks...
DEP0800: The required framework "C:\Users\runneradmin.nuget\packages\microsoft.windowsappsdk\1.1.3\buildTransitive..\tools\MSIX\win10-x64\Microsoft.WindowsAppRuntime.1.1.msix" failed to install. [0x80073CF9] Deployment Add operation with target volume C: on Package Microsoft.WindowsAppRuntime.1.1_1003.565.600.0_x64__8wekyb3d8bbwe from:  (Microsoft.WindowsAppRuntime.1.1.msix)  failed with error 0x8000000B

I suspect this is a dupe of DEP0800 error when trying to deploy MAUI app on windows platform #2741

Error DEP0800: The required framework "C:\Users\ltemimi.nuget\packages\microsoft.windowsappsdk\1.1.1\buildTransitive..\tools\MSIX\win10-x64\Microsoft.WindowsAppRuntime.1.1.msix" failed to install. [0x80073CF9] Deployment Add operation with target volume C: on Package Microsoft.WindowsAppRuntime.1.1_1001.524.1918.0_x64__8wekyb3d8bbwe from: (Microsoft.WindowsAppRuntime.1.1.msix) failed with error 0x8000000B

0x8000000B = E_BOUNDS ?
@sachintaMSFT ?
@michael-hawker Does this repro with 1.1.3?

@DrusTheAxe sorry missed this notification before (I was out for a week); it did repo on 1.1.3, and I just tried with 1.1.4 as well, same issue 😥:
Copying file "D:\a\Labs-Windows\Labs-Windows\labs\CiTestExp\tests\CiTestExp.Tests.WinAppSdk\bin\x64\Release\net6.0-windows10.0.19041.0\AppxManifest.xml" to layout "AppxManifest.xml"...
Checking whether required frameworks are installed...
Framework: Microsoft.WindowsAppRuntime.1.1/X86. Skipping installation because framework package architecture does not match target architecture X64 and app package architecture X64.
Framework: Microsoft.WindowsAppRuntime.1.1/X86. Skipping installation because framework package architecture does not match target architecture X64 and app package architecture X64.
Framework: Microsoft.WindowsAppRuntime.1.1/X64, app package version 1004.584.2120.0 is not currently installed.
Framework: Microsoft.WindowsAppRuntime.1.1/ARM64. Skipping installation because framework package architecture does not match target architecture X64 and app package architecture X64.
Installing missing frameworks...
DEP0800: The required framework "C:\Users\runneradmin\.nuget\packages\microsoft.windowsappsdk\1.1.4\buildTransitive\..\tools\MSIX\win10-x64\Microsoft.WindowsAppRuntime.1.1.msix" failed to install. [0x80073CF9] Deployment Add operation with target volume C: on Package Microsoft.WindowsAppRuntime.1.1_1004.584.2120.0_x64__8wekyb3d8bbwe from:  (Microsoft.WindowsAppRuntime.1.1.msix)  failed with error 0x8000000B. See http://go.microsoft.com/fwlink/?LinkId=235160 for help diagnosing app deployment issues.

See our CI run here: https://github.com/CommunityToolkit/Labs-Windows/runs/7963041945?check_suite_focus=true (works fine with 1.0.3, but not 1.1.x.) Our PR is here: https://github.com/CommunityToolkit/Labs-Windows/pull/183

It is a duplicate of the issue# https://github.com/microsoft/WindowsAppSDK/issues/2829. Latest status of the root cause and the fix is being shared there.


greaterThanOrEqual and lessThanOrEqual give incorrect values and have no tests

Just stumbled upon this when writing tests for my own project.
greaterThanOrEqual() and lessThanOrEqual() give the inverse results to what you would expect.
Given compare():
    public function compare(Money $other)
    {
        $this->assertSameCurrency($other);
        if ($this->amount < $other->amount) {
            return -1;
        } elseif ($this->amount == $other->amount) {
            return 0;
        } else {
            return 1;
        }
    }

Then we'd expect gtoe:
    public function greaterThanOrEqual(Money $other)
    {
        return 0 <= $this->compare($other);
    }

and ltoe:
    public function lessThanOrEqual(Money $other)
    {
        return 0 >= $this->compare($other);
    }

Instead, actual gtoe:
    /**
     * @param \Money\Money $other
     * @return bool
     */
    public function greaterThanOrEqual(Money $other)
    {
        return 0 >= $this->compare($other);
    }

actual ltoe:
    /**
     * @param \Money\Money $other
     * @return bool
     */
    public function lessThanOrEqual(Money $other)
    {
        return 0 <= $this->compare($other);
    }

Additionally, there are no tests for this behaviour, which is likely the only reason this was allowed to happen at all:
    public function testComparison()
    {
        $euro1 = new Money(1, new Currency('EUR'));
        $euro2 = new Money(2, new Currency('EUR'));
        $usd = new Money(1, new Currency('USD'));

        $this->assertTrue($euro2->greaterThan($euro1));
        $this->assertFalse($euro1->greaterThan($euro2));
        $this->assertTrue($euro1->lessThan($euro2));
        $this->assertFalse($euro2->lessThan($euro1));

        $this->assertEquals(-1, $euro1->compare($euro2));
        $this->assertEquals(1, $euro2->compare($euro1));
        $this->assertEquals(0, $euro1->compare($euro1));
    }

https://github.com/mathiasverraes/money/pull/100

Fixed in #100 and #130


Replace deprecated "AmazonEC2RoleforSSM" policy

This policy (AmazonEC2RoleforSSM) will soon be deprecated. Please use AmazonSSMManagedInstanceCore policy to enable AWS Systems Manager service core functionality on EC2 instances.
https://github.com/pepperize/cdk-autoscaling-gitlab-runner/blob/f6a65130f8225e6459200c3f437f6675dcdd810c/src/runner/job-runner.ts#L89

If you like, I will create a PR for it.

@danielbayerlein that would be a great help!
actually for the manager/coordinator it's actually fixed:
https://github.com/pepperize/cdk-autoscaling-gitlab-runner/blob/7d7271bc3e169922e48ba04d27fe936ac80035fe/src/runner/manager.ts#L110


Add support for cumulus linux & vtysh

Add support for Cumulus Linux and Cumulus VTYSH operation.
Configs are tested to work using clab with cvx-4.3 containers.

I got it working by adding check for r.Failed in sendcommand.go:

Cool, I'll take a peak at this tomorrow or at latest over the weekend to see if I had something borked somewhere else or if we need this or what!
is there a cumulus image that is public for this? I know I saw @hellt talking about this somewhere saying ya tested this in clab? If there's a public image could be cool to use that in actions tests for some extra coverage/checking?
lastly for now -- if you're up for it it may be cool to have some basic tests for covering prompt patterns -- we have this in scrapli/scrapli-community -- and its just a nice way to try to prevent regressions on prompt pattern stuff. feeling up to maybe adding some basic tests for at least the cumulus stuff for that?
thanks for the work on this! 🥳

Hi, the cumulus images should be publicly available.
For example in clabs-example-cvx01 they use the same image I tested on: networkop/cx:4.3.0
I pieced together an expected failure check using the pre-existing dummy driver via driver/generic/driver_test: prepareDriver.
There probably could be ways to construct the prepareDriver so that one could pipe in the values from the actual .yaml files but I lack the knowledge on how this would be done in a sane manner.

ok, finally taking a peak here :D
so wrt to "failed when contains" -- this is sorta confusing, but here is the logic: it should not return an error if scrapli is able to properly send the command and return an output -- even if there is some "failed when contains" output in the response. in this case (there is failed when contains output) we mark the response object as failed.
the idea here is that actual errors mean an error that we could not recover from -- like connection closed or couldn't find a prompt or couldn't escalate etc., and the response object .Failed attribute indicates if the "higher level" (like as in us as operators, not go sending bytes on a wire) failure happened.
so I just checked this out and made some minor changes taking that into account. if this looks all good to you let me know and we'll get it merged!
thanks again for the work and sorry for the delay!

Hi,
Yeah, when explained like that it does make sense.
Keep the 'errors' for when some actual transport error is met.
I added lines to examples for how to check & handle the .Failed.
Now obviously it works only if using the "conveniently wrapped" methods, instead of straight poking for example the Channel.SendInput  as the wrapper for .Record is missing from there. But once you know that it is clear.

nice, thanks for adding that! LGTM, thanks again!


Not being able to sync to an existing repo

Describe the bug

I'm not being able to sync my leetcode submission to an existing repos (which was initially created for leethub from another browser)

To Reproduce

After installing leethub
Create a new private repo from leethub itself
At this point it works perfectly fine
Go to another browser(useful in cases of dual boot and some other scenarios too) and try to sync to an existing repo after installing leethub

Expected behavior
Code should be pushed from any no. installed instances if they're synced
Screenshots

Desipite the repo is linked. My code is not being pushed  as shown in screenshot

Same here.


Ads before playing a video are in Chinese

Hey, you are doing a great work. I noticed that when I play a video the ad comes while loading the player is in Chinese. Make it as like when we choose language English so the ad is changed to English. You know what I mean.

No ads.

I am talking about this pre video, can you change it to buffering icon or else ? It would be great.

I think this is the feature of the video api, not ads (It not sell anythings😂)
You can change it yourself to another video api.

I think this is the feature of the video api, not ads (It not sell anythings😂)
You can change it yourself to another video api.

How ?


docs: link issue templates to docs repo

What:

Because people keep filing bug reports for the docs here 😅
Why:

How:

Checklist:

[ ] Documentation added to the docs site
[ ] Tests
[ ] Typescript definitions updated
[ ] Ready to be merged

[ ] Added myself to contributors table

:tada: This PR is included in version 6.1.0 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


Validation set.

I'm interested in your work and trying to run the code.
It seems that the MIMIC-III open-source dataset only provides a training set and a test set, no test set is provided.
How do I select the validation set? For example, the size of the validation set and the way to select it?
Thanks!

Hi,
As described in the Data Gathering section of the README, we use MIMIC-III benchmark. It's a specific benchmark derived from the original data which provides a validation split. You can find all the pre-processing steps in the README

Hi, as I checked the MIMIC-III benchmark repo, there wasn't validation split produced by the procedures. Is it because they've updated the repo after your work? Also, the 'train_listfile.csv' is no longer available and now replaced by 'train/listfile.csv'.

I think I've figure out how to fix the problem above -- simply add python -m mimic3models.split_train_val {dataset-directory} would do the work.

I just updated the README accordingly. Thank you !


Changes to support swift3

Add support to Swift3 and xcode 8

I changed MKTextField.swift line 147  from borderStyle = .none to borderStyle = self.borderStyle
It will cause textField has a square background when setting borderStyle to UITextBorderStyleRoundedRect in xib on iOS 10.0.2


Draconic Vision outline is always white no matter the ore

Issue: The outline around ores using Draconic Vision is always white no matter the circumstance, which makes it impossible to know what kind of ore is being highlighted without actually seeing it.
Loader: Quilt 0.18.1-beta.18
Mods:
amethyst_imbuement-1.18.2-38.jar
architectury-4.10.86-fabric.jar
cloth-config-6.3.81-fabric.jar
fabric-language-kotlin-1.8.6+kotlin.1.7.21.jar
qfapi-1.0.0-beta.28_qsl-1.1.0-beta.26_fapi-0.67.0_mc-1.18.2.jar
RoughlyEnoughItems-8.3.573.jar

This is unfortunately expected behavior at the moment. I had to take out the library that was coloring the ores due to issues it was creating on servers. I hope to have the colors back at some point in the future!

Ah that's too bad but also good to know. I don't know if this'll help but the Spelunker mod does a very similar thing (I don't know if they use entities though) and has coloured outlines around the ores.


Cogent parser and integration tests

Cogent parser based on Planned Network Maintenance notifications only
Integration tests included for :

Planned Network Maintenance
Planned Network Maintenance Correction

I've included cogent3.html as a reference. It did not work with the parser. The bs4 library could only parse the html head section. The html body was not available for processing.


List scsi IDs on startup

It would be useful if rascsi listed all the attached scsi devices on startup.
This would make configuration easier especially for users who are new to scsi.
And give an extra level of confirmation that everything is working.

@ewanuno Can this issue be closed? At least in the development branch rascsi reports the attached devices on startup:
+----+----+------+-------------------------------------
| ID | UN | TYPE | DEVICE STATUS
+----+----+------+-------------------------------------
|  0 |  0 | SCHD | /home/us/hatari/test.hds
|  2 |  0 | SCMO | /home/us/hatari/test.mos
|  5 |  0 | SCCD | /home/us/hatari/test.iso (WRITEPROTECT)
+----+----+------+-------------------------------------


Math.NET equivalent of pandas cut ?

I'd like to find an equivalent to the pandas cut method to convert a continuous variable to a categorical one. Is there an equivalent in Math.NET?
In python, I can do it with the code below.  Any suggestions appreciated.
import pandas as pd
import numpy as np

df_nums = pd.DataFrame({'num': np.random.randint(1, 100, 10)})

all_bins = [1, 25, 50, 75, 100]
df_nums['which_bin'] = pd.cut(x=df_nums['num'], bins=len(all_bins), labels=all_bins)
print(df_nums)

num which_bin
0   17         1
1   77       100
2   70       100
3   39        50
4   37        50
5   78       100
6   56        75
7    8         1
8   18         1
9    5         1

Resolved using math.net.


Impolite and resource intensive

Whenever I change branch on a large project I can see at least 50 processes called gocode and then the same number of processes called compile. I can't really investigate further though because at 100% CPU, my computer is completely crippled. I have to cold kill and restart. Why does go code need 100% CPU?

You're using an experimental feature called "autobuild". Disable it with gocode set autobuild false. Some editors may set this option for you, if so, switch to a different editor or an editor plugin.

That's a best guess though. Hard to tell what's going on from your description.


Implement kpod --rm code

Signed-off-by: Daniel J Walsh<EMAIL_ADDRESS>

Probably should merge after stop/remove PR is ready

lgtm

@rh-atomic-bot r=baude


Active Project?

Has the project died out?

Yes!
:shipit:

I have someone who might be interested in the ruins of this project..

I'm still working towards it however, I'm mostly just learning to do data scraping with Python, and I am only able to work on it in free time in between work and school.
I may eventually take it up myself and contact Owoki about it, but if that does happen it will be on a 6 month to 1 year timeframe.

Updated readme today because it was horribly busted.  I've mostly been trading/HODLing crypto manually and that's been going well.  If folks are interested in building momentum (needed: funding, coding, hosting, etc)  for this project once again, please feel free to comment on this thread.

I find this project interesting but lack the technical knowledge of django and sklearn/pybrain to help much. Owocki, do you have any suggestions for good resources that helped you get your head around sklearn and pybrain?

I find this project interesting but lack the technical knowledge of django and sklearn/pybrain to help much. Owocki, do you have any suggestions for good resources that helped you get your head around sklearn and pybrain?

If I were to re-engage on this project today, I would build it with Tensorflow.  There are very good tutorials on their website.

I find trading bots with artificial intelligence amazing. Money-making machines. Why this project died? Did it really die or transformed?

On 17-04-04 16:23:54, Joseph Anglada wrote:

I find trading bots with artificial intelligence amazing. Money-making machines. Why this project died? Did it really die or transformed?

The real question to ask is this one : Did this project ever make some
profit with trading ?

It did make money if you look at the documents; unfortunately the fees
of poloniex exceeded the gain that was it.
owicki started with 1 bitcoin and ended with 0.9 but without the fees..
łł-ĸkĸĸxĸxĸ

Krister Lilleland
<EMAIL_ADDRESS>On Sat, Apr 15, 2017, at 08:27 PM, Netmonk wrote:

On 17-04-04 16:23:54, Joseph Anglada wrote:

I find trading bots with artificial intelligence amazing. Money-
making machines. Why this project died? Did it really die or
transformed?

The real question to ask is this one : Did this project ever
make some
profit with trading ?

— You are receiving this because you commented. Reply to this email
directly, view it on GitHub[1], or mute the thread[2].

Links:

https://github.com/owocki/pytrader/issues/80#issuecomment-294310136
https://github.com/notifications/unsubscribe-auth/AQ5mtOIKiM97tTK37axdW47p9nW0Uw9Sks5rwQwmgaJpZM4JwZhR

I have a Kraken account that has 0% maker fees, so this may be profitable for me if it could be reworked to use Kraken API.

Poloniex's fee schedule isn't good, it uses a 30 day window rather than cumulative trade volume for your fee schedule.

How much could it generate per day trading USD/BTC

Fees are whole part of profit calculation. If you end up with a -0.1 btc it means your strategy is not profitable (not talking about infrastructure cost, energy cost, data connexion cost... which are all part of the equation).
How come for trader such excuse can even be accepted ?

So, has someone revived the project or not?

some body grab the code from this repo - and do a PR https://github.com/llens/CryptoCurrencyTrader

Cool, good to see that someone cares about this code :D

glad to see someone building a similar project from first principles.  i get 50 inquiries from people who want to revive this project for every 1 who wants to build something similar from first principles.  @llens, @johndpope good luck to you!

so at face value - throwing machine learning + bitcoin seems like a neat idea.
not to bust anyone's bubble - but the underlying data besides price / trades/ market orders is the crypto difficulty. when this goes down - you're going to see the price go down.
This is unlikely to stay down for long / we may see this drop back with BCC in coming week https://bitcoinwisdom.com/bitcoin/difficulty
so let me spare you the data training / time and machine learning.
just buy bitcoin + hold it.  For every sell order (up to the finish line of mining) that preceded the last one will have been sold for not enough. In 20 years time from now, you'll be able to buy your kids a house with it.

Hello, I want to see the code hidden, thank you

Hi, Can someone able to run the code?

I paid someone to fix it. It runs I think now for me.
łł-ĸkĸĸxĸxĸ
Krister Lilleland
<EMAIL_ADDRESS>On Thu, Sep 21, 2017, at 12:30 PM, maithanhtan wrote:

Hi, Can someone able to run the code?

— You are receiving this because you commented. Reply to this email
directly, view it on GitHub[1], or mute the thread[2].>

Links:

https://github.com/owocki/pytrader/issues/80#issuecomment-331117786
https://github.com/notifications/unsubscribe-auth/AQ5mtMDv6xt1en416hSkrrO7R3XruXa-ks5skjq1gaJpZM4JwZhR

I'd like to see a revival!

I'd like to see a revival!

if someone wants to scope a revival, i'd happily help with funding and finding smart people to work on it

I've been giving it some thought again.  In a month or two, my FT job will be in dealing with CryptoCurrencies once more, so I've got the bug once more to get back into it.

@Snipa22 hey man, long time no talk.  lets catch up ! whats a good way to get in touch with you!  email me: kevin at gitcoin dot co

Software developer here who also has the crypto bug. Would gladly help out if there was anyone to take lead.

Was anything decided with restarting development? I would be interested.

i think that if i was going to recommend anyone for taking the helm for a v2, it'd be @Snipa22 .. if someone wants to get organized, i'm happy to help move the interest from this repo (and slack group) to the new project

Sorry, I've been massively busy trying to get caught up on personal stuff and finishing out one of my jobs, down to one FT now!  Yay.  That being said, I've got a bunch of 1080 ti's, 1050 ti's and other gear together to start picking this project up (Including a massive local DB server, and infiniband for everything Drools)
I'll likely be starting a new repo in a couple of weeks when I polish off the last of my current projects, including some updates to the pool software I write.  The overall goal will be to split up the monolith a bit that was this project, shift ML techniques (Tensor Flow, lets not lie) to a specialized daemon that can grab work, work on it, then insert a result into the database as expected on it's own.  Dedicated frontend API, rather than a kind of hybrid system, a front-end project, likely Vue.js or Angular.JS.  Likely still backed by PGSQL, but moving up to PGSQL 10.  Most likely, we'll utilize Redis as a backend queue of "work that needs to be done."
The idea is that breaking this up should make it easier for us to farm out work to people who are interested in parts of it.  Web-devs can rely on a standardized API, API devs can worry about the DB, and the ML techniques can be implemented as modules within the main ML parser.  By splitting this up, people can stick to their specialties.  I'm not a ML expert, but I've got enough scratched up in my head that I think I can at least get that and the API projects started.  Front-end, I am most certianly not an expert in.

@Snipa22 Hi,  how is going? Interested in this project and want to know how to join in. Looking forward to your reply. Thanks!

Hey Mark!
First, I'd like to apologize for the last response. JUST saw this.
Are you still interested in getting pytrader up and running?
Shoot me an email when you get a chance. We've been working on it for a
bit, but need an extra hand. ;)
Kind Regards,
Chris Magistrado
On Wed, Jan 24, 2018 at 1:48 PM, Mark Uretsky<EMAIL_ADDRESS>wrote:

@CMagistrado https://github.com/cmagistrado how is your progress so
far? I'm also interested in getting into this
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/owocki/pytrader/issues/80#issuecomment-360284898, or mute
the thread
https://github.com/notifications/unsubscribe-auth/ARxQ4CdWNci23k_7_qLKOXBMt3qmrWycks5tN6UpgaJpZM4JwZhR
.

@Snipa22 happy to help with the DB and API 2 DB side of things.

@Snipa22 @CMagistrado
Hey!
I'm confident in RL and DL. But happy to help wherever is needed. Is your fork public?

Issue Status: 1. Open 2. Started 3. Submitted 4. Done

This issue now has a funding of 0.1 ETH (69.21 USD @ $692.1/ETH) attached to it.

If you would like to work on this issue you can 'start work' on the Gitcoin Issue Details page.
Questions? Checkout Gitcoin Help or the Gitcoin Slack
$0 more funded OSS Work available on the Gitcoin Issue Explorer

Hey everyone, we’ve created a very profitable trading bot at http://atntrading.co. We are working with high net worth crypto individuals and crypto funds. If you’re looking for a solution similar to this project, you should check ours out.

It'd be great to see this project alive again :)

ok

If there was ever a moment the world needed an open source automated crypto trader, it is now.

Hello,
A friend fwd'd me a message you sent on Github.  We have been running an
automated trading engine quite successfully for over 3 years.  I realize
you mentioned "open source".  Unfortunately we are not open source, but we
have a simple premise that executes extremely well.  We simply trade on the
volatility according to your parameters.
We take no custody, all funds stay on the exchange.  I'm happy to answer
any questions or you can check it out here.
https://test.atntrading.co/?ref=5b4d17ddbcdce
Cheers!
--
Brian Groot
Managing Partner
ATN Trading Co

my apologies for the confusion.
I have not been in the loop with the cryptocurrecy community since 2009, and am trying to make up for lost time.
out of curiosity does ATN utilize quantum computing? I ask because its an area of deep personal interest, and would enjoy discussing.
thank you again for your time.
soderpop

On Nov 16, 2020, at 5:27 PM, neboscott<EMAIL_ADDRESS>wrote:

Hello,
A friend fwd'd me a message you sent on Github. We have been running an
automated trading engine quite successfully for over 3 years. I realize
you mentioned "open source". Unfortunately we are not open source, but we
have a simple premise that executes extremely well. We simply trade on the
volatility according to your parameters.
We take no custody, all funds stay on the exchange. I'm happy to answer
any questions or you can check it out here.
https://test.atntrading.co/?ref=5b4d17ddbcdce
Cheers!
--
Brian Groot
Managing Partner
ATN Trading Co
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub, or unsubscribe.

also is there a way to trade for very little initial money? Im intrigued but I want to first test the waters.
soderpop

On Nov 16, 2020, at 5:36 PM<EMAIL_ADDRESS>wrote:
my apologies for the confusion.
I have not been in the loop with the cryptocurrecy community since 2009, and am trying to make up for lost time.
out of curiosity does ATN utilize quantum computing? I ask because its an area of deep personal interest, and would enjoy discussing.
thank you again for your time.
soderpop

On Nov 16, 2020, at 5:27 PM, neboscott<EMAIL_ADDRESS>wrote:

Hello,
A friend fwd'd me a message you sent on Github. We have been running an
automated trading engine quite successfully for over 3 years. I realize
you mentioned "open source". Unfortunately we are not open source, but we
have a simple premise that executes extremely well. We simply trade on the
volatility according to your parameters.
We take no custody, all funds stay on the exchange. I'm happy to answer
any questions or you can check it out here.
https://test.atntrading.co/?ref=5b4d17ddbcdce
Cheers!
--
Brian Groot
Managing Partner
ATN Trading Co
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub, or unsubscribe.


edger: ControllerFunction for OS commands

Implement ControllerFunction, SP and PV that should run OS commands
key is like "cmd1", "cmd2". SP and PV is content of stdout and stderr

Move Stdout, Stderr etc to PV


Tunnel and .ssh/config ?

Hi! I noticed that when in --tunnel mode, fleetctl would connect to the specified hostname directly, other than honoring the .ssh/config. Since fleetctl uses golang.org/x/crypto/ssh, which doesn't use ssh command or its libraries in any way, connecting directly seems to be a natural behavior. That said, providing a way to read host configs from .ssh/config can be useful sometimes, for example, when one needs to use ProxyCommand, or to specify a different IdentityFile.
What do you think? Would this be a useful feature or are there any reasons that this shouldn't be implemented?
Thanks!

oops. I just realized that this is a duplicate. I'm closing this in favor of https://github.com/coreos/fleet/issues/860


Issue in pagination 'showTotal' - react-bootstrap-table2

@AllenFang: I have used react-bootstrap-table2 in my data grids & there is an issue in pagination 'showTotal' with 'from, 'to' & 'size' values. It seems only 'to' value is incorrectly showed in the pagination.
ex: when page size is 10 & total records are 15, it shows as below.
Showing rows 1 to 11 of 15
Showing rows 11 to 16 of 15
And also when no data, it shows as:
Showing rows 0 to 1 of 0
It should show as 1 to 10 & 11 to 15.
I guess this is due to the header row or filtering text boxes row (not sure).
I changed 'to' value to 'to - 1' just to check if it will change. But no difference.
Is there a way to fix this issue? Appreciate your help on this.
Thank you.

Same issue here!

@dilushi  and @JaviVargas  what version u used? and did you enable the remote mode?  thanks


(768) Create project form object

Changes
The motivation for this work is a bug we have where a user enters an invalid value into the three part date field, e.g. a month value as 31 or letters instead of numbers.

This is a pattern from the GOV.UK design system so it's surprising to have to deal with it ourselves rahter than being handled by the GOV.UK formbuilder that we use
It is also pretty hard to fix as the 3 param dates is handled by Rails magic™ the three params are cast into a Date object, but as we have learnt, if the params cannot be cast, the application crashes.
We think this is because in generic Rails a Date object exposed in a form is made up of select boxes which the user cannot submit incorrect params - but we are not 100% on this, it feels pretty brittle...
Whilst we had a previous fix, this led us to crashes in development and whilst we are not clear on the issue, we have to assume this was the  cause as reverting the change fixed the problem.
Here we are introducing a form object, a design pattern that places a 'form object' between the form being submitted and the models being updated. This gives us a number of good things:

a context to validate a new project in
a place to deal with the multiparameters from dates in the form
a different option to handle creating multiple objects from one form, a Project and Note in this case
a place to trigger any notifications
a way to thin out the controller

At the cost of duplication.
I prefer this approach as it seperates the model, which should accept a date object for attributes representing dates from the form submission with has the three parameters - it seperates the concerns.
This work is proving to be large, so I want to open this PR now which introduces the form object, validation and multiparameter handling, but does not use it to save anything.
We can follow up with more changes to actually use the new form object.
https://trello.com/c/GAI7lOH0
Checklist

[x] Attach this pull request to the appropriate card in Trello.
[ ] Update the CHANGELOG.md if needed.

I am in two minds about this, we still need to deal with the multiparameter dates, but this will need to be updated for the new Conversion::Project work.
@lozette comment on the complexity also worries me - there may be a simpler way to handle this, but we have sunk a great deal of time into the issue already!
I'll leave this here until #344 goes in and then we can make a decision.

Sorry, just got round to taking a proper look at this.
The way the form builder deals with dates is exactly the same as Rails itself does. You shouldn't have to do any extra work to pull a date out of params, you shouldn't even need to be aware they're passed in using the 1i/2i/3i format.
Doing a params.require(:some_record).permit(:subscribed_on) should give you a valid date. As I mentioned on Slack, the date might not always be what you expect (as Time.new(2022, 9, 31) => 2022-10-01) but it mimics Rails' own implementation but with <input> elements rather than <select>.

@peteryates no problem at all - thanks for having a look!
Yep, the form builder does produce what Rails would, our problem is because users can add a string instead of an integer, or a incorrect value, e.g. 31 for a month because the fields are text input rather than selects, this raises an ActiveRecord::MultiparameterAssignmentErrors rather than an invalid form submission - which is not ideal for our users.
The only way we've found to rectify this is overriding the setters as here.
The issue seems to be that conversion from the hash we get to the Date object happens when Rails is mass assigning and so it is difficult to actually get at in the context of the object rather than the controller, so making the object invalid is hard.
As you pointed out, the default Rails behaviour is a set of three <select> which gets around the problem, albeit not brilliantly! Another option would be to reach for a client side JS solution, which is something we generally tried to avoid or even using <input type="number"> none of which feel right in our context.
The best write up I have found is here:
https://thoughtbot.com/blog/ruby-on-fails
Long term I wonder if there is a different approach to the markup in the form to make this a bit more approachable to get to during validation, but we don't have the time in our delivery plan right now!

We are closing this PR for now as we now have other work to introduce a form object for creating new conversion projects.
Once we have the basic form object working, we will come back and fix the multiparameter date submission.


Scientific Papers Suggestion Thread

Messing around and trying random stuff can only get so far. If we want a more reliable network we should try surveying existing literature.
I think this paper(https://arxiv.org/abs/1608.02192) is a good start. Here is a video about it. (https://www.youtube.com/watch?v=QkqNzrsaxYc)

I totally agree with @Ghost---Shadow , we need some studies about the literature and pick or invent a low computational cost method to achieve it. The paper I refer is http://deepdriving.cs.princeton.edu/paper.pdf

While I think it's pointless to not read up to date research on the best methods, I also think it's unwise to assume you cannot possibly make progress without someone else showing you how to progress. Most of what we're doing here is still totally in the trial and error stage, no one really has the answer. If you get the answer to this project, you've got yourself a billion dollar business.

Done, you should link this to the readme.md

Added a link in the readme here. Thanks!
Segmentation: https://arxiv.org/abs/1611.08323 github: https://github.com/TobyPDE/FRRN

Since many people were running out of GPU memory. I would recommend the SqueezeNet. My finals are going on so if nobody implements it by the end of the Month, I will.

Learning how to play Atari games from pixels:
https://www.nature.com/nature/journal/v518/n7540/full/nature14236.html

Some interesting info about what separate buffers GTA V renders, depth and stencil being of particular interest I think http://www.adriancourreges.com/blog/2015/11/02/gta-v-graphics-study/. Direct "snooping" of the individual buffers could I think be achieved with something like https://www.opengl.org/sdk/tools/GLIntercept/, dunno if it could be fast enough though.

NVIDIA's self-driving car model:
https://arxiv.org/pdf/1604.07316v1.pdf
https://devblogs.nvidia.com/parallelforall/deep-learning-self-driving-cars/#disqus_thread

Reinforcement Learning: An Introduction, Sutton and Barto, book available online:
http://incompleteideas.net/sutton/book/ebook/the-book.html
A good introduction to policy gradient methods:
http://www.scholarpedia.org/article/Policy_gradient_methods
A very good survey of actor-critic reinforcement learning
http://ieeexplore.ieee.org/document/6392457/

@skotone  recomended policy gradient methods. The problem with them is that they are mostly "on-policy" which means that the training data should be sampled under fixed NN weights and then they may be updated (though you can use training size of several frames easily). On-policy methods are very inefficient in terms of the amount of simulation which needs to happen in order to train network, and it should be your biggest concern because running gta5 is very costly by itself.
I would stick to off-policy methods, which may learn optimal policy on ANY game records (even on human ones). With them you could make a big boofer of frames which comes from your gta5 agent and then use only it to make everything happen. Your primary interest should be Q-learning and TD (kinda more advanced q-learning) algorithms

here's a simple double q-learning implementation: https://github.com/npetrenko/oligopolyrl/blob/master/oligopolyrl.ipynb

Here is a very nice survey on Deep Reinforcement Learning (from 2017 by Li). Section 5 has a Robotics example that may be useful.
https://arxiv.org/pdf/1701.07274.pdf

Inverse Cooperative Reinforcement Learning. I think this form of RL would best suited for this particular case.
https://www.youtube.com/watch?v=9nktr1MgS-A
https://arxiv.org/abs/1606.03137

Using semantically segmented data from GTA V, here they trained classifier only using GTA V data to train classifier which outperforms classifier trained on KITTI dataset in task of classifying real-world cars in photos:
https://arxiv.org/abs/1610.01983
https://github.com/umautobots/driving-in-the-matrix

This paper form NVIDIA team could help, https://arxiv.org/pdf/1604.07316v1.pdf


Fix for aggregate queries

Fix for aggregate queries where queryXtra:false will prevent adding limit clause to SOQL. This previously led to a malformed query error.

@Minerva18 - Thanks for the change suggestions. Can you make a few minor changes:

Code: You have if (params.queryXtra == '', shouldn't it be if (params.queryXtra != false? Otherwise you prevent the limit 100 guard to be applied for other queries.
Documentation: For the parameter so that others calling it will know how to use what you did. Preferably use the JSDoc notation, you can see an example here: https://github.com/salesforce/violet-conversations/blob/master/lib/violetStoreSF.js#L166
Unit tests: To make sure that your use case keeps working in the future. See here for an example: https://github.com/salesforce/violet-conversations/blob/master/test/test_violetStoreSF.js

@vineet-sinha Sure! Thank you for the inputs.
You are correct regarding the if condition in the code. I have changed it to if (params.queryXtra !== false.
I have also added the documentation similar to the example JSDoc notion and written the unit tests.
Also, there was a typo here - https://github.com/salesforce/violet-conversations/blob/master/lib/violetStoreSF.js#L354. I guess it should be delete instead of update, so I have changes that one too.
Please let me know if there is anything else I can help with.
Thanks!


RedisClient runtime error with latest .40 NServiceKit.Common

Hi guys, if you upgrade to the latest common package you have the following problem in runtime execution.
Unhandled Exception: System.TypeLoadException: Method 'AddRangeToSortedSetWithScores' in type 'NServiceKit.Redis.RedisClient' from assembly 'NServiceKit.Redis, Version=<IP_ADDRESS>, Culture=neutral, PublicKeyToken=null' does not have an implementation.
at POC.Redis.Program.Main(String[] args)
Regards.

Hi, this is a known issue (see #10 ) , I forgot to add some commit in the last release. @mirthy must generate new package.

1.0.20 built and deployed

Method 'AddRangeToSortedSetWithScores' in type 'NServiceKit.Redis.RedisClient' from assembly 'NServiceKit.Redis, Version=<IP_ADDRESS>, Culture=neutral, PublicKeyToken=null' does not have an implementation.  Exception throwing

Method 'ZUnionStoreWithWeights' in type 'NServiceKit.Redis.RedisNativeClient' from assembly 'NServiceKit.Redis, Version=<IP_ADDRESS>, Culture=neutral, PublicKeyToken=null' does not have an implementation.

This issue is coming from NServiceKit.Common Dll

there is some solution for this problem?


Swagger for Account API.

Changes in this pull request:

Add swagger dependencies
Refactor:
- moved Produces annotation(MediaType.APPLICATION_JSON)
and Since annotation(CommonParams.VERSION_1)
to class level annotations instead of method annotation. (required modifying Since annotation from commons)
Add swagger annotations for Account API resources.
Add swagger-maven-plugin to generate swagger.json for Swagger UI.
Removed resources and yaml files with previous swagger docs.

For testing it is already deployed on my node.

This change is

Codecov Report

:exclamation: No coverage uploaded for pull request head (task/swagger-account-api@70418d6). Click here to learn what that means.
The diff coverage is n/a.

This pull request shall go into the swagger branch.


analyze redirect workflow

closing this because the callback handlers implementation is left out of the scope of this library. we will consider in future if also release some serverless implementation.


Feature 1108 custom templates folder

Adresses/Fixes #1108.
Implements

#1110

@devonfw/cobigen

Could you please adapt as part of this pr the documentation to document what needs to be done to set a custom template set? Please update parameter documentation properly as well.


Psd2 vat ntr

implementation of a lint to check the form for PSD2 certificates with OI

:wave: Activity on this pull request has trailed off and it is currently out of sync with the main branch. In the interest of keeping our review queue easy to manage I'm going to close this PR out. Please feel free to re-open once you've rebased on master and are ready for fresh reviews. Thanks!

:wave: Activity on this pull request has trailed off and it is currently out of sync with the main branch. In the interest of keeping our review queue easy to manage I'm going to close this PR out. Please feel free to re-open once you've rebased on master and are ready for fresh reviews. Thanks!


TypeError: slidebars is not a constructor

Hello,
i wanted to install slidebars with npm but i get the error:

TypeError: slidebars is not a constructor

what i did:

run npm install slidebars
put this code into my main.js

var slidebars = require("slidebars");

( function ( $ ) {
    var controller = new slidebars();
    controller.init();
}) ( jQuery );

having the same issue! whats the latest on this?

Bump


New Design Page

Login interface changed to new interface. About to correct conflicts on setEmail and email. Names are conflicting


Generalize the possibility of putting struct or enum in the input or output argument

In current implement, we can only put Struct or Enum output in impl but not fn (except we also use extendr to export the impl of the same Struct or Enum).
Hope to add something like this, in this way, we can just put [derive(Sexp)] followed by the creation of Struct or Enum, we can then put the object in function input or output. Following code is copied directly from extendr, it would be better to allow users control which object (struct or enum) can be put in the input argument or output argument (Current implement only allow output or input struct or enum whose impl has been exported by extendr).
use proc_macro::TokenStream;
use quote::{quote, ToTokens};
use syn::{Data, Fields};

#[proc_macro_derive(Sexp)]
pub fn sexp(input: TokenStream) -> TokenStream {
    // Construct a representation of Rust code as a syntax tree
    // that we can manipulate
    let ast = syn::parse(input).unwrap();

    // Build the trait implementation
    impl_sexp_macro(&ast)
}

fn impl_sexp_macro(ast: &syn::DeriveInput) -> TokenStream {
    let ident = &ast.ident; // the struct name
    let class = ident.to_string();
    let finalizer_name = quote::format_ident!("__finalize__{}", class);
    let expanded = quote! {
        // https://github.com/extendr/extendr/blob/master/extendr-macros/src/extendr_impl.rs#L223
        // Function to free memory for this type.
        extern "C" fn #finalizer_name (sexp: extendr_api::SEXP) {
            unsafe {
                let robj = extendr_api::robj::Robj::from_sexp(sexp);
                if robj.check_external_ptr_type::<#ident>() {
                    //eprintln!("finalize {}", #class);
                    let ptr = robj.external_ptr_addr::<#ident>();
                    drop(Box::from_raw(ptr));
                }
            }
        }

        use extendr_api::robj::Attributes; // used by set_attrib

        // Input conversion function for this type.
        impl<'a> extendr_api::FromRobj<'a> for &#ident {
            fn from_robj(robj: &'a Robj) -> std::result::Result<Self, &'static str> {
                if robj.check_external_ptr_type::<#ident>() {
                    #[allow(clippy::transmute_ptr_to_ref)]
                    Ok(unsafe { std::mem::transmute(robj.external_ptr_addr::<#ident>()) })
                } else {
                    Err(concat!("expected ", #class))
                }
            }
        }

        // Input conversion function for a reference to this type.
        impl<'a> extendr_api::FromRobj<'a> for &mut #ident {
            fn from_robj(robj: &'a Robj) -> std::result::Result<Self, &'static str> {
                if robj.check_external_ptr_type::<#ident>() {
                    #[allow(clippy::transmute_ptr_to_ref)]
                    Ok(unsafe { std::mem::transmute(robj.external_ptr_addr::<#ident>()) })
                } else {
                    Err(concat!("expected ", #class))
                }
            }
        }

        // Output conversion function for this type.
        impl std::convert::From<#ident> for extendr_api::Robj {
            fn from(value: #ident) -> Self {
                unsafe {
                    let ptr = Box::into_raw(Box::new(value));
                    let mut res = extendr_api::Robj::make_external_ptr(ptr, extendr_api::Robj::from(()));
                    res.set_attrib(extendr_api::prelude::class_symbol(), #class).unwrap();
                    res.register_c_finalizer(Some(#finalizer_name));
                    res
                }
            }
        }

        // Output conversion function for this type.
        impl<'a> std::convert::From<&'a #ident> for extendr_api::Robj {
            fn from(value: &'a #ident) -> Self {
                unsafe {
                    let ptr = Box::into_raw(Box::new(value));
                    let mut res = extendr_api::Robj::make_external_ptr(ptr, extendr_api::Robj::from(()));
                    res.set_attrib(extendr_api::prelude::class_symbol(), #class).unwrap();
                    res.register_c_finalizer(Some(#finalizer_name));
                    res
                }
            }
        }
    };
    TokenStream::from(expanded)
}

Thanks for your details, I think I have mis-understand the usage of #[extendr] and extendr_module.
After several days of using extendr and your explanations, maybe extendr works in this way (Please correct me if I'm wrong):

Struct or Enum: won't do anything. (I mis-understood extendr will register methods to transform them into Robj, but extendr don't so I'm here to request).
fn: transform this function directly into C function, it means we must manually transform the input or ouput argument into a extendr_api::Robj (or define the traits: extendr_api::FromRobj and std::convert::From for extendr_api::Robj ).
impl: transform all methods into the C function for R usage, and also automatically define the traits: extendr_api::FromRobj and std::convert::From for extendr_api::Robj for Self(which should be the Struct or Enum). This means we can also directly export rust function involved in these Struct or Enum without manually transforming between extendr_api::Robj (since these methods have been implemented when we export impl for these Struct or Enum).

The different implement details for fn and impl confused me (since I thought impl will just iterate with fn method) when I first got touch with extendr. Maybe it's better to split impl implement (take the traits: extendr_api::FromRobj and std::convert::From for extendr_api::Robj into Struct and Enum),
It seems savvy get these well.
https://yutannihilation.github.io/savvy/guide/savvy_macro.html

Yeah, I ended up requiring always putting #[savvy] macro both on struct and on impl. The reasons are

I feel it's simpler not only as a user interface but also as the internal implementation.
An expert user might want to implement the conversion trait (in my framework's case, TryFrom) by themselves.

That said, for enum output, it's not a big deal to wrap an enum with a struct. So, I think it's also reasonable not to support enum output. For this reason, savvy doesn't support an enum with fields.
cf. https://yutannihilation.github.io/savvy/guide/enum.html#limitation

I find requiring #[extendr] on impl-block and struct to be an okay idea, but right now, I don't see an immediate use for it. I believe @JosiahParry is also in favour of splitting this purpose. So that's two votes already!
If you want structs to be embeddable in R via ExternalPtr<T> you may use an empty impl-block:
#[extendr]
impl Model {}

On the other hand, there are multiple ways one can embed structs to R. One may embed it as a List, if
all fields implements Robj: From<T>. And viceversa. We have derive-macros for that already.
One may also view plain enums as R factor. I've got a prototype implementation of that here https://github.com/cgmossa/extendr, see https://github.com/CGMossa/extendr/blob/master/extendr-macros/src/extendr_enum.rs for a little preview.
As I said before, we have things in the works for this area; One particular thing I've investigated is how we return &T/&mut T (without cloning) to R, from an #[extendr]-block. I hold the opinion that one cannot create an ExternalPtr from &T/&mut T, instead I think we should employ a pass-through strategy, which is implemented in a PR that's "open" right now.

Thanks, this is a good way to do the same work now.
#[extendr]
impl Model {}


ParameterSet to ArgumentSet housekeeping

Working towards consistency in our terminology, variable names, file names, etc with the ParameterSet to ArgumentSet rename.
Just FYI for you @andyk; no functional changes here, so I'll merge once the build is green.
See also #263

Build is green!  Merging!


Overview documentation for people lacking a .NET background

So this is more of plead for more docs than an actual issue.
I'm coming to F# from a lifetime of programming but virtually no .NET or Windows experience.
In ProjectScaffold I'd really appreciate an explanation of all the infrastructure basics around a .NET code project.
Here's some stuff I think should be included
What's a project in .NET parlance?
What's a solution in .NET parlance?
After cloning ProjectScaffold I have bunch of files in a folder. After running build.sh I have a bunch more.
The docs should go through each of these files and tell me what the purpose of it is. Also I want to know what should get put into source control and what's dynamically regenerated.
Do I need to add every source file to some sort of project config file? Do files need to be ordered in this project file? Are these project files only meant to be edited via tools are do people edit them manually.
How I'm willing to help
If you just point me to the relevant reading material on these topics I can put in the time to read it and try to summarize it to something that can go into your docs to help out other .NET/mono newcomers.

http://bfy.tw/CFfb
This will help you!
Serious, the question you asked could not be answered here. Thats basic knowledge about .net.

@firehirsch I do think the documentation for ProjectScaffold could include some links to the very top material for these topics.

It's not my project, but I don't see any reason for that.
If you argue like that every project here on GitHub should include such links.
I think we can expect that people who want to code have learned about the basic concepts and features of the languages and frameworks they want to use.
And I also think that ProjectScaffold should not be used by a beginner. First learn how to create all that basic stuff by your self and don't start using things like ProjectScaffold not before you understood what has to happen to create a new project.

@firehirsch > And I also think that ProjectScaffold should not be used by a beginner.
I can't tell you how much that makes me chuckle. ProjectScaffold started life as a learning tool... for beginners.
;-D
Admittedly, the community has moved it in a different direction. But that's part of what's great about FOSS, right? Ultimately, I agree with @dsyme. One or two very high-level links out to introductory content would make a good addition to the README.


WordCount — method required by test is sentence-cased.

Instead of
actualWordCount = wordCount.Phrase("word");

it should be
actualWordCount = wordCount.phrase("word");

In Java, method names are always camelCased (i.e. the first letter is never capitalized).

Closed by #76


[ci] Simplify check-generated.sh; allow it to catch multiple errors

Force-push rebases over the MUBI support that just landed (I should have waited!)

Merging now that we passed quick lint (since that's the only thing that the PR touches).


docs(firebase_auth): Add notice about iOS setup

About to copy REVERSED_CLIENT_ID to URL Schemes.
Description
I can't find about that in https://firebase.flutter.dev/docs/auth/overview or somewhere.
It is difficult to find the solution for newbie.
Related Issues
😺
Checklist
Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes ([x]).
This will ensure a smooth and quick review process. Updating the pubspec.yaml and changelogs is not required.

[x] I read the Contributor Guide and followed the process outlined there for submitting PRs.
~- [ ] My PR includes unit or integration tests for all changed/updated/fixed behaviors (See Contributor Guide).~
~- [ ] All existing and new tests are passing.~
~- [ ] I updated/added relevant documentation (doc comments with ///).~
~- [ ] The analyzer (flutter analyze) does not report any problems on my PR.~
~- [ ] I read and followed the Flutter Style Guide.~
[x] I signed the CLA.
[x] I am willing to follow-up on review comments in a timely manner.

Breaking Change
Does your PR require plugin users to manually update their apps to accommodate your change?

[ ] Yes, this is a breaking change (please indicate a breaking change in CHANGELOG.md and increment major revision).
[x] No, this is not a breaking change.

@googlebot I signed it!

Thanks for this PR but this shouldn't be required?
Once you enable Google Auth on the Firebase Console you should re-download the GoogleServices plist file and this should already be there by default. I'm not really in favour of asking a user to modify a generated file that will get replaced the next time they re-download credentials.

@Salakar
It is not "EDIT GoogleService-Info.plist".
It is "EDIT ios/Runner/Info.plist"
Copy value ...

FROM in GoogleService-Info.plist named "REVERSED_CLIENT_ID"
TO ios/Runner/Info.plist named "CFBundleURLSchemes"

--- a/test_apps/test_app_takeru_001/ios/Runner/Info.plist
+++ b/test_apps/test_app_takeru_001/ios/Runner/Info.plist
@@ -18,6 +18,17 @@
        <string>$(FLUTTER_BUILD_NAME)</string>
        <key>CFBundleSignature</key>
        <string>????</string>
+       <key>CFBundleURLTypes</key>
+       <array>
+               <dict>
+                       <key>CFBundleTypeRole</key>
+                       <string>Editor</string>
+                       <key>CFBundleURLSchemes</key>
+                       <array>
+                               <string>com.googleusercontent.apps.xxxxxxxx-xxxxxxxxx</string>
+                       </array>
+               </dict>
+       </array>
        <key>CFBundleVersion</key>
        <string>$(FLUTTER_BUILD_NUMBER)</string>
        <key>LSRequiresIPhoneOS</key>

I could not use Google Auth before copy the value.
I can't found about it in FlutterFire documents.
But found in "FireBase" https://firebase.google.com/docs/auth/ios/google-signin#2_implement_google_sign-in
Same edit steps here:
https://medium.com/@droid_aj/flutter-google-sign-in-authentication-using-firebase-c4305ad1a198
I thought it would be kind to mention it here.


Support real-time monitoring for highscore changes

While it is still not possible to monitor every score update of a table (maybe one day, the DMD team is working on that), it makes sense to monitor the highscore files of a started table:

the text file for EM tables
the nvram for SS tables
and the VPReg.stg file

This way, one doesn't have to exit the table and wait 6 seconds.

Is this gonna be an update? Cause this would be great

Started today and seems to be less effort than expected. I estimate the release for this next week.

Your thr best. Appreciate the hard work. This app is great. Love remote
updating my cabinet
On Mon, Feb 5, 2024, 12:36 PM syd711 @.***> wrote:

Started today and seems to be less effort than expected. I estimate the
release for this next week.
—
Reply to this email directly, view it on GitHub
https://github.com/syd711/vpin-studio/issues/125#issuecomment-1927552995,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/ANIYI6AJFUINNC3FAIYBNC3YSEKCTAVCNFSM6AAAAABCRIBFRCVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTSMRXGU2TEOJZGU
.
You are receiving this because you commented.Message ID:
@.***>

Too bad. I tested this and remembered that I did the same test three years back. The highscores are only written on VPX exit, not even after a game has been finished. So currently, there is no better option than the existing one available here.


Function arguments inferring as any

Bug Report

🔎 Search Terms
function arguments inferring any

🕗 Version & Regression Information
Tested version: Version 4.5.5

I didn't test this on prior versions because I think this is not related to a version-specific behavior

⏯ Playground Link

Playground link with relevant code
💻 Code

function  locate(x: number, y: number) {
  const ax = arguments[0] // ax is any, expected number
  const ay = arguments[1] // ay is any, expected number
}

🙁 Actual behavior

Function arguments is any[] type.
🙂 Expected behavior

The typescript should infer the type of arguments from function implementation.

Is there any good reason to use arguments in this way? That parameter predates the tuple functionality, and changing this would be breaking change.

This starts to get pretty weird with overloads and there's not really much usage of arguments compared to other things like rest args available today.


Easing with multiple stops

Have you considered adding support for multiple stops + respecting the starting positions of the stops? If I have a gradient with multiple color stops, right now the plugin only takes the first and last colors into account, and also places them at 0% and 100%, respectively.

This results in angular gradients having this harsh transition point at 0%

Hej @gsajith ,
great point, allowing multiple color stops is definitely something that should make its way to the plugin. I will see when I have time to tackle this ✌
About the color stop placement: What would be the expected plugin behavior here? Would the plugin honor the user's 'original' color stop position and just interpolate the stops in between?
Or would there be a feature to space the color stops evenly (ex. instead of defaulting two color stops to 0% and 100%, the plugin would position them at 33% and 66%)?
Would love to hear your thoughts on that.
/Alex

Hi @alexwidua!
Awesome, look forward to multiple color stops! It may be fairly complex - I can't visualize in my mind how one easing curve can control multiple color stops but maybe you have something in mind!
Yes, re: color stop placement my expectation is that it would honor the user's original color stop position and interpolate between them - this should be fairly easy for just two stops.
I took the liberty of cloning and trying it out myself 👇

I'm not as familiar with Vue so still trying to figure out how to update the plugin preview to reflect the new color stops 😅 But maybe I can send you a PR once I figure that out?

Yeah, I also believe that it will be a little bit more complex – but could be fun to poke around in it!
Awesome that you already managed to implement it, but I think there is one gotcha: you lose the easing 'outside' of the color stops and get the sharp line back which you try to ease out in the first place.

One solution just from the top of my head could be to also interpolate 'outside' of the color stops, I'm not sure if there would be any implications with this 🤔

And yes, I'd be more than happy to take a PR for this. Already thank you for opening up this issue and pondering with it for a bit, it's always fun to think about that stuff :)
/A

Issue got partially fixed with #2
Leaving the issue open until respecting multiple color stops is being tackled/solved.
Thank you @gsajith for opening up the issue and putting out a PR! :)


ARTEMIS-3932 Deprecate and replace addAddressSettings with json version

As I worked through implementing a more generic JSON marshaller, I tried using reflection through BeanUtils and other ways however the endresult was always worse as there were a few caveats that were not as easy to accomplish.
For that reason I went to a declarative appraoch where I define a meta-data object on AddressSettings and AddressSettingsInfo and reuse the metadata in a few other places.

Notice: I created this PR with the current status of my work before a week break on American Thanksgiving.
I won't be able to do extensive work on this PR on the week between Nov-19th and Nov-25th. but I will certainly respond to small inquiries.

also: as I commented on the commit, the amount of work to use BeanUtils would be a lot larger and not satisfactory.
I still have my branch saved from when I was trying to use BeanUtils, but I would have a much larger set of changes for a small gain over what I'm doing here.
For instance: the getters would always go through the default values instead of getting the attributes directly. and it wouldn't be possible to generate the same object back from a "marshaller".
(well: wouldn't be possible is a strong word here, lets just say, I could do it with a lot more work involved. Hence I will use the declarative approach as I mentioned here).

I am marking this as draft as I will refactor the journal record where I'm using a JSON object to be reused for other cases.

hmmm... actually I will not do that..
but I will still change the Address and Queue records to use the JSON object format.

I gave up on the idea. I was going to write a meta-record..which would simplify usage, but it would probably increase memory of the broker if those settings are over-used. so I'm giving up the idea.


Add jglick to reverse-proxy-auth-plugin

Description
After @Wadeck left in #1733, only @oleg-nenashev and @wilderrodrigues have access here, but https://github.com/jenkinsci/reverse-proxy-auth-plugin/pull/40 is going to be critical after JEP-227, so I would like to cut an emergency release. I do not intend to maintain the plugin in other respects.
Reviewer checklist (not for requesters!)

[ ] Check this if newly added person also needs to be given merge permission to the GitHub repo (please @ the people/person with their GitHub username in this issue as well). If needed, it can be done using an IRC Bot command
[ ] Check that the $pluginId Developers team has Admin permissions while granting the access.
[ ] In the case of plugin adoption, ensure that the Jenkins Jira default assignee is either removed or changed to the new maintainer.
[ ] If security contacts are changed (this includes add/remove), ping the security officer (currently @daniel-beck) in this pull request. If an email contact is changed, wait for approval from the security officer.

There are IRC Bot commands for it

I also need write permissions to the repository; do I need to file a separateINFRA ticket for that?

Permission added on GitHub.


Whisper Version

Your current library is great. Can you please provide a whisper-live version of your codebase?

That's a good idea. If someone would like to look into this - a PR would be welcome!


Validate Host header for HTTP/1.1 requests as per RFC

HTTP/1.1 requests MUST include a valid host header (host and optional port) as per RFC: https://tools.ietf.org/html/rfc7230#section-5.4
Builds on top of #124
Refs #125

Rebased now that #125 is in :shipit:


🐛 [BUG] - Margin removed when using a className with Hero.Label

Describe the bug
When adding a className to a Hero.Label, it removes the bottom margin.
Reproduction steps

Go to https://primer.style/brand/components/Hero/react
In the editor, add className="someClass" to the Hero.Label of the first example.
Notice how the bottom margin is gone.

I think the Hero-module--Hero-label--C\+rTh class (that adds the bottom margin) gets removed from the DOM once a custom class is added?
Expected behavior
The bottom margin should stay.
Screenshots

Browsers
Chrome
OS
Mac

Good spot, thanks @simurai.
I've got a PR here which resolves the issue
https://github.com/primer/brand/pull/760

Closing as the fix has shipped in v0.41.0


Night Ambiance

Recording of night time ambiance for when day/night cycle is turned on.
I don't know if this is a wanted sound effect, which is why I split it off the previous push.

This sounds very noisey and also very short.

There is a small percussion half way I am hearing, it loops quite perfectly though, since it's a form of white noise it loops quite easily similar to rain. I think I am hearing an AC in the background (355.64 Hz), which I can easily filter out if necessary. I could also see if I can make a longer looping file for ya if you'd prefer that.

I guess I was expecting something more like this:
https://www.youtube.com/watch?v=_foCbHydSlk
So more obvious cricket noise and also occasional owls. It would need to play this contary to the crowd ambience I think.

that's fair, I know there's a place near me that has quite some owls so I could see if I can go out there and record some


Update user guide, docstrings, and readme

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 100.00%. Comparing base (d862de6) to head (9dfd143).
Report is 27 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff            @@
##              main       #77   +/-   ##
=========================================
  Coverage   100.00%   100.00%
=========================================
  Files           12        12
  Lines          869       869
=========================================
  Hits           869       869

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


AUTH-4232 add saas app remove bookmark specific app resource

Depends on: https://github.com/cloudflare/cloudflare-go/pull/900 before merge

thanks for this @AkemiDavisson! as this is removing a resource causing a breaking change, we need to leave the cleanup until the next major release and support this until we get there. in the meantime, we can deprecate the resource by updating the method calls to emit a diag.Warn about the deprecation and include a callout in the documentation to make sure people don't keep using this resource.
i've added this to track via #1646.


Export undecorated components as named exports

Thanks for making this great library! I have a use case where I want to compose a UI out of the controls in this library, but I don't want to use the Media component. The way the components are written, the this.props.media can easily be used without the media context.
@souporserious I'm not sure if you agree with the style of named exports and default exports in the same file, but this approach shouldn't break anything. I think allowing this can make the library much more powerful.

@souporserious Do you have an opinion on this proposal?

@souporserious Really hoping you'll consider this. There shouldn't be any backwards compatibility issues, and fits nicely with the encapsulation of the inner components. Please take a quick a look if you get the chance.


Cannot get javascript code completion to work with lsp.

I am trying to setup javascript support with lsp. I followed all the necessary steps which is:

Add (javascript +lsp) on my init.el and do the doom sync/reload.
Install typescript (https://github.com/theia-ide/typescript-language-server)
However, when I open up a js file, I see this message and code completion does not work. I was expecting the ts lsp server to be connected. The one I installed. Major mode is js2-mode.

I am seeing that the lsp server is eslint and not the typescript language server I installed. I do not get any code completion because of this. Have I done something wrong? How can I change the association of an LSP server with a project and remove the eslint association?
Sorry, I am a total emacs and doom newbie so I might be missing something basic.

I was able to disable eslint lsp server using this.
(setq lsp-disabled-clients '(eslint))


Initial config for standalone tempo project

To-do items:

[x] Update to use subset dimensions once https://github.com/dsgrid/dsgrid/pull/253 is merged in
[x] Consider publishing full-resolution subsector/bin information and providing supplemental dimensions per those listed under tempo_project/dataset/dimensions/supplemental

@daniel-thom, should I revise the subset dimension display names to be more human-readable? I was following another example, but then realized maybe I should just be reusing the strings I have for "name" for "display name".

@daniel-thom @elainethale Main things appear to be adding to year_to_year (or model_year_to_model_year) mapping, and fixing the bin.csv. I've noted in my comments what I think needs to happen. Let me know if I can help further.

@ahcyip or @daniel-thom, would you please approve this PR if you're okay with it?


Support realm in the OAuth1 header

Support realm as part of Auth header

@rossabaker please take a look when you have time

Cherry-picked to #2992.  Proposed fixes in 579f7c752f.


heroku app.json should contain test script config

and we need to flake ignore some heroku stuff

resolved in f73fe93e494d063927b4838c2970aee7afdb41fb


Removal of old Api::Json::MapsController

This closes #12039.
This is the bare minimum acceptance, but this should probably be improved.
Editor

[x] Create new map.
[x] Edit map (pan / zoom). Embed should work.
[x] Reload map. Editor should load with the updated version of the map.
[x] Change map options. Refresh and check editor + embed

Builder (should not be affected)

[x] Create new map.
[x] Edit map (pan / zoom). Embed should work.
[x] Reload map. Editor should load with the updated version of the map.
[x] Change map options. Refresh and check editor + embed

I went through the requests logs and replicated everything I could see there (in editor, builder and their embeds). Everything works like a charm, so moving to deploy (but better, after the weekend).

👍 for deploy


[HTML5] Fix Mono builds (old emcc?)

Promise chaining the emscripten module then function breaks it badly, causing an infinite loop.
I'm unsure about the source of the issue, but most likely at this point is due to the old emscripten version (I remember very old html5 builds having issue with promise chaining too).
With this commit, we no longer use the module as a promise, and instantiate it using Promise objects directly for compatibility.
Fixes #47048

Thanks!

Cherry-picked for 3.3.


New App Submission

App Logo (Required)
blob:file:///d3c3a011-6ab4-4307-81dd-93da1febf4ee
App Details (Required)
Type: Wallet or Dapp
Name: Trustwallet
Homepage Url: www.trustwallet.com
App Url (Required - at least one)
Browser Url: https://trustwallet.com/
iOS Url:
Android Url:
Mac Url:
Windows Url:
Linux Url:
Mobile Linking (Optional)
Deep Link:
Universal Link:
Desktop Linking (Optional)
Deep Link:
Universal Link:
Metadata (Optional)
Short Name:
Primary Color:
Secondary Col

Trust Wallet is already featured in the registry.


Add api_key in public node constructor

Usually for some calls to the node, we need an api key, which we currently cannot provide when creating Public Node. You can check how I add it in the http_requests.py file in the e2e tests.

Could you provide an example? if there is the end point I will add the API

This endpoint /transactions/sign requires API key for example. It's not about adding an endpoint but auth key.

When we sign we do have all the necessary information, I don't see your point

https://swagger.io/docs/specification/authentication/api-keys/


access to call's audio codecs

I would like to get access to call's audio codecs.  API call call_audio() returns struct audio of the call.  It has rx and tx fields, both of which include a struct aucodec field, that is exposed in the API.  So would it be appropriate if I implement
struct aucodec *audio_tx_codec(const struct audio *au)
struct aucodec *audio_rx_codec(const struct audio *au)

API functions for that purpose or is there a better alternative?

yes should be fine to expose this in the api.
alternative api:
struct aucodec *audio_codec(const struct audio *au, bool tx);

this will return the audio codec in use.

OK, I'll work on it.


Memory leak when dropping items

To reproduce this bug, in Debugging Mode, pick up an item then drop it on the floor and exit the game.
A stack trace will show that the dropSelection procedure caused memory not to be freed,

Fixed by a member of the Lazarus Forum.
https://forum.lazarus.freepascal.org/index.php?topic=54821.msg407402#msg407402


Added new tested climate devices: Haier Flexis Plus 2.5kW & 3.5kW

AS35S2SF1FA-WH works also in 1x1 configuration. I had to log out from application and change password to connect integration in home assistant to hon, otherwise I got an error stating that id token couldn't be obtained. Not sure if this could be added somewhere?

I've had no such problem with account. Any chance you used social account login eg. Google? From many other integrations i know that type of account often wouldn't work and either you need reset password (if it's possible) to convert external account to normal or register completely new account with classic login&password combination.

Nope, internal hon account - no 3rd party provider.