Javadoc errors in IGC Client library

looks like Javadoc confused by the angle brackets
/Users/mandy-chessell/CloudStation/Drive/Code/ODPi/egeria-governance/egeria/open-metadata-implementation/adapters/open-connectors/repository-services-connectors/open-metadata-collection-store-connectors/igc-rest-client-library/src/main/java/org/odpi/openmetadata/adapters/repositoryservices/igc/clientlibrary/model/common/Reference.java:545: error: unknown tag: String
* @return List
^
/Users/mandy-chessell/CloudStation/Drive/Code/ODPi/egeria-governance/egeria/open-metadata-implementation/adapters/open-connectors/repository-services-connectors/open-metadata-collection-store-connectors/igc-rest-client-library/src/main/java/org/odpi/openmetadata/adapters/repositoryservices/igc/clientlibrary/model/common/Reference.java:562: error: unknown tag: String
* @return List
^
/Users/mandy-chessell/CloudStation/Drive/Code/ODPi/egeria-governance/egeria/open-metadata-implementation/adapters/open-connectors/repository-services-connectors/open-metadata-collection-store-connectors/igc-rest-client-library/src/main/java/org/odpi/openmetadata/adapters/repositoryservices/igc/clientlibrary/model/common/Reference.java:579: error: unknown tag: String
* @return List
^
/Users/mandy-chessell/CloudStation/Drive/Code/ODPi/egeria-governance/egeria/open-metadata-implementation/adapters/open-connectors/repository-services-connectors/open-metadata-collection-store-connectors/igc-rest-client-library/src/main/java/org/odpi/openmetadata/adapters/repositoryservices/igc/clientlibrary/model/common/Reference.java:596: error: unknown tag: String
* @return List
^

A couple more ...
/Users/mandy-chessell/CloudStation/Drive/Code/ODPi/egeria-governance/egeria/open-metadata-implementation/adapters/open-connectors/repository-services-connectors/open-metadata-collection-store-connectors/igc-rest-client-library/src/main/java/org/odpi/openmetadata/adapters/repositoryservices/igc/clientlibrary/model/generated/v11502sp3/AnalysisProject.java:27: error: bad HTML entity
* The 'short_&long_description' property, displayed as 'Short & Long Description' in the IGC UI.
^
/Users/mandy-chessell/CloudStation/Drive/Code/ODPi/egeria-governance/egeria/open-metadata-implementation/adapters/open-connectors/repository-services-connectors/open-metadata-collection-store-connectors/igc-rest-client-library/src/main/java/org/odpi/openmetadata/adapters/repositoryservices/igc/clientlibrary/model/generated/v11502sp3/AnalysisProject.java:27: error: bad HTML entity
* The 'short&_long_description' property, displayed as 'Short & Long Description' in the IGC UI.
^

/Users/mandy-chessell/CloudStation/Drive/Code/ODPi/egeria-governance/egeria/open-metadata-implementation/adapters/open-connectors/repository-services-connectors/open-metadata-collection-store-connectors/igc-rest-client-library/src/main/java/org/odpi/openmetadata/adapters/repositoryservices/igc/clientlibrary/model/generated/v11502sp3/ColumnAnalysisSummary.java:27: error: bad HTML entity
* The 'short_&long_description' property, displayed as 'Short & Long Description' in the IGC UI.
^
/Users/mandy-chessell/CloudStation/Drive/Code/ODPi/egeria-governance/egeria/open-metadata-implementation/adapters/open-connectors/repository-services-connectors/open-metadata-collection-store-connectors/igc-rest-client-library/src/main/java/org/odpi/openmetadata/adapters/repositoryservices/igc/clientlibrary/model/generated/v11502sp3/ColumnAnalysisSummary.java:27: error: bad HTML entity
* The 'short&_long_description' property, displayed as 'Short & Long Description' in the IGC UI.
^

Don't worry about finding all of them, I'm sure there are lots -- I'll do an in-depth scan on my side to correct!

Just seems to be a couple of issues that repeat ... :)

To save me digging around for how to generate them to re-test on my side: any pointer on a quick command to run the Javadoc generation? 🙏

From IntelliJ - Tools menu -> Generate Javadoc

Thanks, found it!  Surprised it didn't show up from the "Help" menu 😕
I've noticed a few problems elsewhere as well -- shall I just go ahead and do a cleanup of the JavaDocs wherever I'm able?


boxes format in calculation of huber_loss

Hi @rwightman, I'm trying to implement a custom iou loss function. But I'd like to confirm with you about the boxes format consumed by huber_loss function. Could you help me verify the format of inputs & targets args?
def huber_loss(input, target, delta: float = 1., weights: Optional[torch.Tensor] = None, size_average: bool = True):
    """
    """
    err = input - target
    abs_err = err.abs()
    quadratic = torch.clamp(abs_err, max=delta)
    linear = abs_err - quadratic
    loss = 0.5 * quadratic.pow(2) + delta * linear
    if weights is not None:
        loss *= weights
    return loss.mean() if size_average else loss.sum()

I print both of them out and found they are in the shape of [batch, height_l, width_l, 9*4], the last dim of which I think coords for bounding boxes. In other threads, you mentioned that you implementation consumes targets in YXYX format, outputs pred boxes in XYWH format. Does such theory hold here as well?
Thank you for your confirmation!

Yes, they should be relative (to anchors) regression coordinates in yxyx, they are not converted into absolute xyxy until decode_box_outputs(boxes, anchors, output_xyxy=True) is called
https://github.com/rwightman/efficientdet-pytorch/blob/20cd5f3b9744a5939534ac1c556689ff4a2edd12/effdet/anchors.py#L48-L82)
... which is usually only done for predictions via the generate_detections() call
Note there is a PR for IOU loss at https://github.com/rwightman/efficientdet-pytorch/pull/52 ... I haven't dug in yet but am hoping to take a closer look this week, maybe possible to optimize a bit

Hi @rwightman Great thanks for your quick reply. I implemented a version yesterday but messed up the boxes format, which led to NaN value of loss. Now I can try to fix it. Thanks!

@rwightman While I still have you here, let me ask another question. I'm also trying to modify the default anchors but have no idea of the right way to set it up. Maybe I misunderstood the parameters relevant to anchors in the model_config.py file.
    # feature + anchor config
    h.min_level = 3
    h.max_level = 7
    h.num_levels = h.max_level - h.min_level + 1
    h.num_scales = 3
    h.aspect_ratios = [(1.0, 1.0), (1.4, 0.7), (0.7, 1.4)]
    h.anchor_scale = 4.0

As you indicated in your code, your implementation employed 3 aspect ratios x 3 octave_scale, 9 anchors per location on each feature map. I'm following the thread and try to set, for example, h.aspect_ratios = [(1.0, 1.0), (1.0, 1.5), (1.5, 1.0), (1.0, 2.0), (2.0, 1.0)] .

To change the anchor sizes anchor_scale is the main factor, it can be defined as a list so it can change per feature level, it's multiplied by the feat stride at different levels, but also multiplied by the aspects (so a 2,1 vs 1.4, .07 * the scale would result in different size anchors)... as for more detail than that you'll have to dig in, the code is adapted from the Google TF models retinanet and other anchor based models, I have not explored the space of options.

Hi Ross, thanks for your explanation. I'll dig into it further. Thank you for your help!


Register

@JuliaRegistrator register()

@JuliaRegistrator register()

Registration pull request created: JuliaRegistries/General/20744
After the above pull request is merged, it is recommended that a tag is created on this repository for the registered package version.
This will be done automatically if the Julia TagBot GitHub Action is installed, or can be done manually through the github interface, or via:
git tag -a v1.0.36 -m "<description of version>" 47c816ca32639b4daf2ce7505d8884c83dc51472
git push origin v1.0.36

@JuliaRegistrator register()

Registration pull request created: JuliaRegistries/General/20753
After the above pull request is merged, it is recommended that a tag is created on this repository for the registered package version.
This will be done automatically if the Julia TagBot GitHub Action is installed, or can be done manually through the github interface, or via:
git tag -a v1.0.37 -m "<description of version>" df59c3c4dd36b78b6460c550348d2ff9e42bfe3c
git push origin v1.0.37

@JuliaRegistrator register()

Registration pull request created: JuliaRegistries/General/20814
After the above pull request is merged, it is recommended that a tag is created on this repository for the registered package version.
This will be done automatically if the Julia TagBot GitHub Action is installed, or can be done manually through the github interface, or via:
git tag -a v1.0.38 -m "<description of version>" fbdd38dc57b44c94e47afa8a3f6c8288416cbe4e
git push origin v1.0.38

@JuliaRegistrator register()

Registration pull request created: JuliaRegistries/General/21094
After the above pull request is merged, it is recommended that a tag is created on this repository for the registered package version.
This will be done automatically if the Julia TagBot GitHub Action is installed, or can be done manually through the github interface, or via:
git tag -a v1.0.39 -m "<description of version>" 4eedcf88e8c02e51df54dbbc502426e2a456042d
git push origin v1.0.39

@JuliaRegistrator register()

Registration pull request created: JuliaRegistries/General/21245
After the above pull request is merged, it is recommended that a tag is created on this repository for the registered package version.
This will be done automatically if the Julia TagBot GitHub Action is installed, or can be done manually through the github interface, or via:
git tag -a v1.0.40 -m "<description of version>" becbb29626073ae5aaa58b02ca9999fb8f27983d
git push origin v1.0.40

@JuliaRegistrator register()

Registration pull request created: JuliaRegistries/General/21956
After the above pull request is merged, it is recommended that a tag is created on this repository for the registered package version.
This will be done automatically if the Julia TagBot GitHub Action is installed, or can be done manually through the github interface, or via:
git tag -a v1.0.41 -m "<description of version>" 5219f08dfaf0a805f91b642f578cc35fa18a0680
git push origin v1.0.41

Also, note the warning: Version 1.0.41 skips over 1.0.40
This can be safely ignored. However, if you want to fix this you can do so. Call register() again after making the fix. This will update the Pull request.

@JuliaRegistrator register()

Registration pull request updated: JuliaRegistries/General/21245
After the above pull request is merged, it is recommended that a tag is created on this repository for the registered package version.
This will be done automatically if the Julia TagBot GitHub Action is installed, or can be done manually through the github interface, or via:
git tag -a v1.0.40 -m "<description of version>" 4d36e3914c1dbd59742a36c91e5354b744a5b5b7
git push origin v1.0.40

@JuliaRegistrator register()

Registration pull request created: JuliaRegistries/General/21958
After the above pull request is merged, it is recommended that a tag is created on this repository for the registered package version.
This will be done automatically if the Julia TagBot GitHub Action is installed, or can be done manually through the github interface, or via:
git tag -a v1.1.1 -m "<description of version>" 34cfb5fda7c7b2b16efff328b51e22e504fe9de6
git push origin v1.1.1

Also, note the warning: Version 1.1.1 skips over 1.1.0
This can be safely ignored. However, if you want to fix this you can do so. Call register() again after making the fix. This will update the Pull request.


split evidence.dev sql queries into separate files

now that evidence can support decoupled sql queries, we should decouple the sql queries from the markdown files.

scoping into NFL only for now - will address NBA holistically.


Auth of data

Context & versions
https://dev-sanchonet.govtool.byron.network/proposal_pillar/proposal_discussion/304
Actual behavior
Authorisation data is requested before doing any action on PDF
Expected behavior
Data authorization should be requested only once, and it should cover submitting/editing proposals, adding comments, and creating polls.
Therefore if a user have already submitted a proposal shouldn't be requested to auth the data AGAIN if he wants to add a comment.

@ValMBO  I wanted to ask about this, the situation regarding the editing and deletion of the proposal. That would mean that we have to show these options to everyone at every moment, which I don't know how good it is.

Because it can be a situation, you click edit proposal, the user logs in and nothing happens, but everything disappears because that proposal is not from that user.

And at the same time it must always be visible. Perhaps we should analyze in more detail what is the best thing to do here. Because I had moments when I wanted to edit a proposal, and in order to log in, I had to do some action, for example to post a comment, and only then can I see the edit for my proposal

Okay, but I believe the main issue is that the Edit and Delete options should only be visible to authors of proposals. Is there a way to address this?

The only way we know someone is the author is if the user is logged in. It's a dependency that I don't know how we can solve here. That's why I had the idea that there should be a button that directly says log me in, rather than triggering everything through actions.

Ohh I understand, okey so let me ask Lorenzo.

@ValMBO @bosko-m I think this task is no longer valid because we solved these problems by adding an additional screen for wallet verification

True @teske00 , closing.


Feature prefetch attribute

I was getting an error trying to set the Rabbitmq prefetch attribute in the ::sensu class.
Added the Rabbitmq prefetch attribute, following the same format as the other attributes (such as rabbitmq_port), and got it to update the /etc/sensu/conf.d/rabbitmq.json with prefetch successfully when running on this branch.
Set the default to 1 since that's what it is in the Sensu docs.
Added rspec tests and verified they're passing.

Thanks!


Support of asynchronous DynamoDB LoadTable()

Is there an asynchronous load table API that honors a cancellation token? Something like BatchWrite.ExecuteAsync() that returns a task that I can wait on with a token.
I have a task that needs to be cancelled when the app goes to background But it is getting caught in the LoadTable() call.

For clarity, would you show me your code example and what behavior you desire.
Sent from my Windows Phone

From: Henry<EMAIL_ADDRESS>Sent: 2/20/2015 1:42 PM
To<EMAIL_ADDRESS>Subject: [aws-sdk-xamarin] Support of asynchronous DynamoDB LoadTable() (#17)
Is there an asynchronous load table API that honors a cancellation token? Something like BatchWrite.ExecuteAsync() that returns a task that I can wait on with a token.
I have a task that needs to be cancelled when the app goes to background But it is getting caught in the LoadTable() call.

Reply to this email directly or view it on GitHub:
https://github.com/awslabs/aws-sdk-xamarin/issues/17

Suppose I have a background Task that does this:
public void UploadData (CancellationToken token)
{
Client = new AmazonDynamoDBClient (credentials, config);
myDataTable = Table.LoadTable (Client, "MyData");  <<<<<
while (true) {
// Read data from db and format it into Document
var task = myDataTable.PutItemAsync (data);
task.Wait (token);
}
}
If I am at a location where I have problem reaching the network (but I may have LAN connectivity), this task will be stuck in LoadTable() and if the iOS app goes to background and I need to cancel the task, it may not get out in time. (The network timeout is often longer than iOS background fetch run time.)
My request is that LoadTable() or an async version of LoadTable accepts a cancellation token like:
myDataTable = Table.LoadlTableAsync (Client, "MyData", token);
or create a Task like PutItemAsync:
var tableTask = Table.LoadTableAsync (Client, "MyData");
tableTask.Wait (token);
myDataTable = tableTask.Result;
Then, I can use my token to cancel this task in a timely manner.

Thanks for the explanation.  Let me investigate this, give me a little time to see what I can come up with.  I want to consider some architectural decision points around this for async to be inline with iOS and also consider usage from AWS Unity to see if BFTask support is there.
If I can create an interim solution for you, in the meantime I definitely will.  I will follow-up with a response by EOW even if I don’t have a concrete solution to give you a heads up.
Thanks,
TEW
Sent from Windows Mail
From: Henry Kwok
Sent: Saturday, February 21, 2015 7:18 PM
To: 'awslabs/aws-sdk-xamarin'
Cc: Tara Walker
Suppose I have a background Task that does this:
public void UploadData (CancellationToken token)
{
Client = new AmazonDynamoDBClient (credentials, config);
myDataTable = Table.LoadTable (Client, "MyData"); <<<<<
while (true) {
// Read data from db and format it into Document
var task = myDataTable.PutItemAsync (data);
task.Wait (token);
}
}
If I am at a location where I have problem reaching the network (but I may have LAN connectivity), this task will be stuck in LoadTable() and if the iOS app goes to background and I need to cancel the task, it may not get out in time. (The network timeout is often longer than iOS background fetch run time.)
My request is that LoadTable() or an async version of LoadTable accepts a cancellation token like:
myDataTable = Table.LoadlTableAsync (Client, "MyData", token);
or create a Task
like PutItemAsync:
var tableTask = Table.LoadTableAsync (Client, "MyData");
tableTask.Wait (token);
myDataTable = tableTask.Result;
Then, I can use my token to cancel this task in a timely manner.
—
Reply to this email directly or view it on GitHub.

Hi:
This Beta SDK should now be migrated to use the AWS SDK for .NET with  Xamarin has been released.  As noted, this release is under AWS SDK for .NET and is in Developer Preview.  The Xamarin SDK repo has the latest links for this update, as well as, the updates for the updated NuGet packages.
This should resolve you issue as this has the updated services and codebase desired.  See links below:
https://github.com/aws/aws-sdk-net
https://github.com/aws/aws-sdk-net#nuget-packages


Use LLaMA.cpp through library instead of standalone exectuable

The standalone exectuable brings permission problems with it and also the http server and slot management adds unnecessary overhead. The Project will migrate to using llama through a library in the future.

Apple Silicon is migrated, windows support is currently therefore broken until also migrated

Windows has also bin migrated but needs some more testing as it affects the MacOS implementation aswell


[Storage] az storage blob/container/file/share/table/queue generate-sas: make --expiry and --permissions required

Description

Fix #10935

Testing Guide

History Notes

[Component Name 1] BREAKING CHANGE: az command a: Make some customer-facing breaking change.
[Component Name 2] az command b: Add some customer-facing feature.

This checklist is used to make sure that common guidelines for a pull request are followed.

[ ] The PR title and description has followed the guideline in Submitting Pull Requests.

[ ] I adhere to the Command Guidelines.

add to S171


Fix re-render error with profile image

What's this PR do?

Fixes error with profile image re-render
Adds UPDATE_USER action and case to reducer file

Where should the reviewer start?

The bulk of this work happens in user/api/actions & user/api/state; check out the new action and reducer here. Then head to the ProfilePicture component to see this method getting called in saveChanges

How should this be manually tested?

Open app in the browser, visit a user's profile page. Ensure that you can upload an image, that it re-renders, and persists over a page reload/switching pages.

Any background context you want to provide?

After getting the initial profile photo upload setup, we needed a way to update store automatically and re-render the image.

What are the relevant tickets?

#32

Great job, Jake. I will rebase this.


after review - html preview

I already cleaned it up. I think you reverted most of the changes with this PR.

I just put there 'a' and 'the' articles mainly, added some grammar changes
in sentences (to make them clearer) and made clickable pictures. And I
think that in places where you cleaned the text your changes are retained.
Anyway thanks for your merge and if something is wrong it wasn't my
intention.
2015-05-13 0:24 GMT+02:00 Simon Schäfer<EMAIL_ADDRESS>
I already cleaned it up. I think you reverted most of the changes with
this PR.
—
Reply to this email directly or view it on GitHub
https://github.com/scala-ide/docs/pull/125#issuecomment-101441024.

There are a few articles that improve the text, but most changes are unwanted. They seem to come from some merge errors you had. Please have another look.

ok
2015-05-18 9:56 GMT+02:00 Simon Schäfer<EMAIL_ADDRESS>
There are a few articles that improve the text, but most changes are
unwanted. They seem to come from some merge errors you had. Please have
another look.
—
Reply to this email directly or view it on GitHub
https://github.com/scala-ide/docs/pull/125#issuecomment-102955009.

outdated work


Typo that prevents correct rendering of table

https://github.com/MicrosoftDocs/office-docs-powershell/issues/4129

Docs Build status updates of commit 0852b01:
:clock10: Full build: the average full build time is 11 min(s) 47 sec(s), this is based on the last 1000 build(s) for this repository.

Docs Build status updates of commit 0852b01:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

sharepoint/docs-conceptual/sharepoint-pnp/sharepoint-pnp-cmdlets.md
:white_check_mark:Succeeded
View (sharepoint-ps)

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.


attribute the clojure logo to its owner

The attribution should be here, otherwise it will be very hard to find.
I don't use Emacs and from reading online, I understand absolutely nothing about Org-mode Markdown, so I just added it a different way.
a step in fixing https://github.com/exercism/exercism.io/issues/3112.

Thanks for the PR! I've made a few comments inline.

*** third level heading

Cool. I'm happy to merge once you reformat however you decided.

I'm not really sure how the Reviews feature works but I pushed the changes I rebased.
I'm not really sure why the link renders the way it does, but I'd like to fix that before you merge this.

The link syntax is backwards.
http://orgmode.org/manual/External-links.html

Much better! :)

LGTM, thanks!


Multiple checks for one service

Hi,
Sorry if this is obvious and I have missed it. Is there a way to add a service with multiple checks, rather than just one?
If so, what is the syntax?
Thanks!

I was actually wondering about this as well.

Looks like this is the pull request where the feature was added to consul:
https://github.com/hashicorp/consul/pull/591

@johnbellone Would you like some help implementing this on general road to 1.0.0 stuff?  I have a need for this feature and don't mind doing some of the lifting.  We have been getting a ton of mileage from all your leg work already and I don't mind helping out where I can.
Not sure what sort of timeline you are looking for but I can probably manage the time over the next couple weeks to knock it out.

@zarry Yes that'd be great. Take a look at the develop branch. I need to test the HWRP thoroughly and document them.

@johnbellone Are you changing some of the terminology from the current version/state to what is in the develop branch?  Looks like consul_service is now used to actually define a consul instance and not represent a service in consul?  Would consul_definition be where we define services?  Looks not fully implemented(or just lacking documentation)?
What is the current state of the develop branch?

Never mind, thats what I get for quickly skimming it.  I see what is going on.  I should have some time in the next day or two to start playing around with the development branch.  If you could make sure anything you have locally is pushed that would be great.
Thanks!

Right now I need to thoroughly test that branch, but otherwise I am waiting to get some time this week or next to document the definition HWRP. It would be a huge help to do that!
There are no commits locally. Once the README is written I am going to cut a patch release with remaining changes for 0.10 and merge in 1.0.

Actually, as I dive in I still think consul_definition may have been missing some attributes. for_keeps is empty and we have no way of supplying a service or check definition json to the file system.
Regardless, I will get some documentation around it and make any changes I think should be there to make it work as I would expect.  We can hash out any of the details or your idea of how it should look when I submit the PR.  (To be fair I don't have a ton of experience with HWRP so I may be missing a common pattern)

@zarry I'll tackle this during my train ride home tonight.

@johnbellone Thanks, I spent a little time with it and I think I got a little lost with the HWRP.  I don't think I fully groked your vision and I wasn't able to pick it up and finish it from there.  If you can get a little more documentation I can do some testing for you.

@zarry No worries. I really need to write up a lengthy blog post and more documentation here.


[Event Request] Codeunit 7313 - Create Put-away - OnAfterAssignPlaceBinZone

Dear ALAppExtensions team,
Through this issue we would like to request event publisher OnAfterAssignPlaceBinZone to be added to Codeunit 7313 Create Put-away with the following signature:
LOCAL [IntegrationEvent] OnAfterAssignPlaceBinZone(VAR WarehouseActivityLine : Record "Warehouse Activity Line")

with VAR parameter WarehouseActivityLine.
which would be called as follows from AssignPlaceBinZone:
    local procedure AssignPlaceBinZone(var WhseActivLine: Record "Warehouse Activity Line")
    var
        Bin2: Record Bin;
    begin
        with WhseActivLine do begin
            "Bin Code" := Bin.Code;
            "Zone Code" := Bin."Zone Code";
            if Location.IsBWReceive and
               (CrossDockInfo <> "Cross-Dock Information"::"Cross-Dock Items") and
               ((Bin.Code = PostedWhseRcptLine."Bin Code") or Location.IsBinBWReceiveOrShip(Bin.Code))
            then begin
                Bin2.SetRange("Location Code", Location.Code);
                Bin2.SetFilter(Code, '<>%1&<>%2&<>%3', Location."Receipt Bin Code", Location."Shipment Bin Code",
                  PostedWhseRcptLine."Bin Code");
                if Bin2.FindFirst then begin
                    "Bin Code" := Bin2.Code;
                    "Zone Code" := Bin2."Zone Code";
                end else begin
                    "Bin Code" := '';
                    "Zone Code" := '';
                end;
            end;
        end;
        OnAfterAssignPlaceBinZone(WhseActivLine); // << NEW
    end;

Thanks for reporting this. We agree, and we’ll publish a fix asap, either in an update for the current version or in the next major release. We will update this issue with information about availability.

Thanks for reporting this. We agree, and we’ll publish a fix asap, either in an update for the current version or in the next major release. We will update this issue with information about availability.


Ludwig not producing hyperparameters.json file in results folder

Describe the bug
Ludwig Kills itself on training and doesn't produce hyperparameters file in results folder to use for predictions

To Reproduce
Steps to reproduce the behavior:

cd into ludwig folder
run train command with ludwig train --data_csv path/to/file.csv --model_definition "{input_features: [{name: doc_text, type: text}], output_features: [{name: class, type: category}]}"
inevitably you'll see a returned command similar to the one in the picture above
if you check your results/experiment_run_#/model folder there will be no hyperparameters.json file present

Please provide code, yaml definition file and a sample of data in order to entirely reproduce the issue.
Issues that are not reproducible will be ignored.
yaml definiton:
    -
        name: image_path
        type: image
        encoder: stacked_cnn

output_features:
    -
        name: title
        type: text
        level: word
        decoder: generator
        cell_type: lstm

output_features:
    -
        name: author
        type: text
        level: word
        decoder: generator
        cell_type: lstm

output_features:
    -
        name: subtitle
        type: text
        level: word
        decoder: generator
        cell_type: lstm

data sample:
./images/snow.jpeg,,,,,,

Expected behavior
Expected the model to train and hyperparameters.json file to be generated
Screenshots

-- no hyperparameters.json file produced either

Environment (please complete the following information):

OS: [e.g. iOS] Mojave
Version [e.g. 22]
Python version 3
Ludwig version (most up to date version using ludwig install)

Additional context
Add any other context about the problem here.

I believe there are several issues at play here.
The first and most obvious it the yaml file: output features is a list, bu you are actually defining it several times with only one element. Moreover, I cant see any input feature definition in your YAML.
Please use some that looks like this:
input_features:
  -
    <my input feature 1>
  -
    <my input feature 2>
output_features:
  -
    <my output feature 1>
  -
    <my output feature 2>

Also, use the latest version for master to be sure you are not encountering a problem that has already been solved.

👍 thank you for the help @w4nderlust, I’ll give those ideas a shot.

Closing in the meantime, let me know if you are still experiencing the issue, in that case I'll reopen.


fix: Do a shallow follow_bindings before unification

Description
Problem*
Resolves https://github.com/noir-lang/noir/issues/6457
Summary*
Finishes monomorphization in the program above in ~1.3s on my machine compared to master which stack overflows after 1min 12s.
Fixes the issue by performing a shallow follow bindings call before each unification. This follows immediate type variable links but stops once a non-type variable is reached. This prevents the issue in the program above because previously in unification we'd unify as soon as possible. If self is unbound but other is a bound type variable, we could be continuously adding another link to the chain. E.g. tv3 -> tv2 -> tv1 -> Field unified with tv4 may become tv4 -> tv3 -> tv2 -> tv1 -> Field.
With this change we follow bindings beforehand so we'd unify tv4 to Field and would never build up the large chain to begin with.
Additional Context
Documentation*
Check one:

[x] No documentation needed.
[ ] Documentation included in this PR.
[ ] [For Experimental Features] Documentation to be submitted in a separate PR.

PR Checklist*

[x] I have tested the changes locally.
[x] I have formatted the changes with Prettier and/or cargo fmt on default settings.

Nice!


Annotations errors

Hi !
Thank you for your great work. However am I the only one to experiment annotation errors?
For example in FASS cloud:

I think those lights are missclassified as nature. But I'm not sure if I'm the one to make the mistake when merging the labels onto the point cloud in the same file, or if this is an annotation error. This is in the FASS point clouds.
Thank you for any feedback,
Regards,
Camille

Hi Camille,
Indeed, this is the missing annotation. Due to your observation, we recently inspected all annotations and discovered that a tiny number of items were annotated mistakenly (lights, pathway, and others.)
We are actively correcting these issues and will update the dataset on the official website.


Hidden select is displayed when select2ing

Concerning select2 4.0.0:
If a select is initially hidden (e.g. style="display:none"), it will show up when select2 is applied.
See http://jsfiddle.net/su014pea/ for an example.
In select2 3.5.2 the select box stayed invisible. I like the idea of select2 being a drop-in replacement for plain old select boxes, so essential css properties should get copied to the created select2 root element (like the width does).

Can't reproduce this in Chrome 43 (latest) on Windows 8.

Can you expand upon the issue you are facing by adding a few more pieces of information to your bug report?

What steps can be used to reproduce the issue?
What is the bug and what is the expected outcome?
What browser(s) and Operating System have you tested with?
Does the bug happen consistently across all tested browsers?
What version of jQuery are you using? And what version of Select2?
Are you using Select2 with other plugins?

The contributing guide contains a useful section with a few questions which can help us track down the bug and speed up the process of finding a fix for it.  The creation of an isolated test case would also be useful.

Ok, thougt the fiddle would do the best, but in detail:

What steps can be used to reproduce the issue?

Create a <select> Element with an style or css class, which makes the select invisible (e.g. style="display:none")
Apply $.select2 without options

What is the bug and what is the expected outcome?

The originally hidden select box gets visible after applying $.select2, which breaks the ability to hide select boxes by css

What browser(s) and Operating System have you tested with?

Tested with Chrome 43 and Firefox 38 ond Windows 7

Does the bug happen consistently across all tested browsers?

Yes.

What version of jQuery are you using? And what version of Select2?

The affected version of select2 is 4.0.0.
The JQuery version makes no difference; 1.10.0, 1.11.0, 2.1.3 is all the same
When switching to select2 3.5.2 the select box stays hidden (as expected)

Are you using Select2 with other plugins?

No, see the fiddle.

Sorry for not testing the master branch, but my time is limited and the essential js Files hasn't changed for a month so I didn't expect a fix there. I updated the fiddle for clarification: http://jsfiddle.net/su014pea/1/

I think I completely misunderstood what the issue was here. The issue isn't that the <select> is displaying after calling .select2(), the issue is that Select2 is displaying even though the original select was hidden.
As Select2 no longer synchronizes CSS classes and the inline style attribute, you are going to have to use the full builds and the old containerCss option.
$('#select2').select2({
    containerCss: function (element) {
        var style = $(element)[0].style;
        return {
            display: style.display
        };
    }
});

https://jsfiddle.net/su014pea/2/

Well, then there seems to be a bug in the compat module.
The style attribute gets applied not to the container (as the option says), but to the inner selection, which makes the container getting empty, but still claiming the width (cause the container is still visible).
see https://jsfiddle.net/su014pea/3/ where text after the select is not displayed as expected.

I've got the same problem.  It's working for me [4.0.3]
select[style*="display: none"] + .select2 { display: none; }

I selectively initialized "select" tags like $("select").not("[style*='display:none']").select2({
tags: true,
tokenSeparators: [',', ' '],
});
to solve the problem. Indeed, prevented the problem.

thanks @santaclaus21 it works!!!


isFindPending states per pagination object

Feature?
I think it would be good to have isFindPending and other "loading" states within the pagination objects.
This way you can load something in the default pagination, and when you load data into another pagination object, if you are using the isFindPending to show a loading state and the secondary pagination object loads data you will see loading state.
Would be nice to be able to show loading state on a per-pagination basis.
We could leave the default loading states top-level for default pagination object as to not break anything and also then include a per pagination object loading states.
Thoughts?

Good idea.  Yep!

I've implemented a similar feature as part of the feathers-vuex-data component in<EMAIL_ADDRESS> Each component now has its own pagination tracking that's kept in the service store.


JavaScript optional catch binding causes UncaughtException: TypeError: Cannot read property 'type' of null

Prerequisites

[x] Put an X between the brackets on this line if you have done all of the following:

Reproduced the problem in Safe Mode: https://flight-manual.atom.io/hacking-atom/sections/debugging/#using-safe-mode
Followed all applicable steps in the debugging guide: https://flight-manual.atom.io/hacking-atom/sections/debugging/
Checked the FAQs on the message board for common solutions: https://discuss.atom.io/c/faq
Checked that your issue isn't already filed: https://github.com/issues?utf8=✓&q=is%3Aissue+user%3Aatom
Checked that there is not already an Atom package that provides the described functionality: https://atom.io/packages

Description
In a .js file, if there is a catch block using optional catch binding (i.e. write a catch block without binding the error, see https://github.com/tc39/proposal-optional-catch-binding ), the editor will continuously give the error "UncaughtException: TypeError: Cannot read property 'type' of null. Restarting server..." when you continue typing anywhere in the file.
Steps to Reproduce

Create a .js-file and write a try catch block with optional catch binding. For example:

try {
//Some js code here
} catch {
//Maybe some more code here
}

Type anywhere in the same file. The error will now appear.

Expected behavior:
Support for optional catch binding should be implemented so the error doesn't appear (these errors also make the editor lag).
Actual behavior:
The error appears when a try catch-block with optional catch binding is present.
Reproduces how often:
This error is 100% reproducible.
Versions
Atom    : 1.40.1
Electron: 3.1.10
Chrome  : 66.0.3359.181
Node    : 10.2.0
apm  2.4.3
npm  6.2.0
node 10.2.1 x64
atom 1.40.1
python
git
visual studio 2015
Microsoft Windows 10 Pro
10.0.17763 Build 17763

I'm unable to reproduce this on Atom v1.42.0-nightly8.

UncaughtException: TypeError: Cannot read property 'type' of null. Restarting server...

This sounds like something coming from a package, are you able to reproduce this in Safe Mode?

I'm sorry, I thought I checked this in safe mode but you're right, it doesn't occur in safe mode.
I found that the problem is in the atom-ternjs package. Apparently it doesn't support ECMAScript 2019 yet.
My apologies for not checking the packages thoroughly first.


GRAPHICS-19: Football and simplified storybook setup (Graphics workflow demo)

Har har I stole your branch

@thekingofjibs how do you feel about merging this now in the state that it's in, so we have something for training?

@thekingofjibs how do you feel about merging this now in the state that it's in, so we have something for training?

I mean hopefully I can merge in my changes before training still but sure why not, go for it👍👍

@thekingofjibs how do you feel about merging this now in the state that it's in, so we have something for training?

I mean hopefully I can merge in my changes before training still but sure why not, go for it👍👍

If you think you can get them in early-mid afternoon go for it and promote it to prod yourself, then it's on you if you break it :p


Removes IBM Z references to architecture-specific images doc.

Closes https://github.com/docker/docs-private/issues/906

@ry4nz does this address https://github.com/docker/docs-private/issues/906?

Deploy preview for docsdocker ready!
Built with commit fe1858d964fc0eb87e125b31afaa48650614379d
https://deploy-preview-8124--docsdocker.netlify.com


HDFS-16859. RBF:move LOG.debug into if condition for method acquirePe…

…rmit.

Description of PR
The invoke frequency of method AbstractRouterRpcFairnessPolicyController#acquirePermit is high.  before getting the permit of a nameservice, there is always a LOG.debug statement.
It is better to move the statement into if condition statement.
How was this patch tested?
no need to test.
For code changes:

[ ] Does the title or this PR starts with the corresponding JIRA issue id (e.g. 'HADOOP-17799. Your PR title ...')?
[ ] Object storage: have the integration tests been executed and the endpoint declared according to the connector-specific documentation?
[ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under ASF 2.0?
[ ] If applicable, have you updated the LICENSE, LICENSE-binary, NOTICE-binary files?

@tomscut @ZanderXu , hi,  could you help me to review it. the modification is very simple.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Logfile
Comment

+0 :ok:
reexec
0m 52s

Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s

No case conflicting files found.

+0 :ok:
codespell
0m  0s

codespell was not available.

+0 :ok:
detsecrets
0m  0s

detect-secrets was not available.

+1 :green_heart:
@author
0m  0s

The patch does not contain any @author tags.

-1 :x:
test4tests
0m  0s

The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.

_ trunk Compile Tests _

+1 :green_heart:
mvninstall
41m 36s

trunk passed

+1 :green_heart:
compile
0m 56s

trunk passed with JDK Ubuntu-11.0.16+8-post-Ubuntu-0ubuntu120.04

+1 :green_heart:
compile
0m 48s

trunk passed with JDK Private Build-1.8.0_342-8u342-b07-0ubuntu1~20.04-b07

+1 :green_heart:
checkstyle
0m 41s

trunk passed

+1 :green_heart:
mvnsite
0m 54s

trunk passed

+1 :green_heart:
javadoc
0m 59s

trunk passed with JDK Ubuntu-11.0.16+8-post-Ubuntu-0ubuntu120.04

+1 :green_heart:
javadoc
1m  8s

trunk passed with JDK Private Build-1.8.0_342-8u342-b07-0ubuntu1~20.04-b07

+1 :green_heart:
spotbugs
1m 42s

trunk passed

+1 :green_heart:
shadedclient
27m  8s

branch has no errors when building and testing our client artifacts.

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
0m 45s

the patch passed

+1 :green_heart:
compile
0m 43s

the patch passed with JDK Ubuntu-11.0.16+8-post-Ubuntu-0ubuntu120.04

+1 :green_heart:
javac
0m 43s

the patch passed

+1 :green_heart:
compile
0m 37s

the patch passed with JDK Private Build-1.8.0_342-8u342-b07-0ubuntu1~20.04-b07

+1 :green_heart:
javac
0m 37s

the patch passed

+1 :green_heart:
blanks
0m  0s

The patch has no blanks issues.

+1 :green_heart:
checkstyle
0m 25s

the patch passed

+1 :green_heart:
mvnsite
0m 48s

the patch passed

+1 :green_heart:
javadoc
0m 38s

the patch passed with JDK Ubuntu-11.0.16+8-post-Ubuntu-0ubuntu120.04

+1 :green_heart:
javadoc
0m 54s

the patch passed with JDK Private Build-1.8.0_342-8u342-b07-0ubuntu1~20.04-b07

+1 :green_heart:
spotbugs
1m 35s

the patch passed

+1 :green_heart:
shadedclient
24m 17s

patch has no errors when building and testing our client artifacts.

_ Other Tests _

+1 :green_heart:
unit
37m 44s

hadoop-hdfs-rbf in the patch passed.

+1 :green_heart:
asflicense
0m 44s

The patch does not generate ASF License warnings.

147m 32s

Subsystem
Report/Notes

Docker
ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5181/1/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/5181

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell detsecrets

uname
Linux 10f306694c38 4.15.0-191-generic #202-Ubuntu SMP Thu Aug 4 01:49:29 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/bin/hadoop.sh

git revision
trunk / f7b32830465c5d10bc4453b62921e209f2435c9a

Default Java
Private Build-1.8.0_342-8u342-b07-0ubuntu1~20.04-b07

Multi-JDK versions
/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.16+8-post-Ubuntu-0ubuntu120.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_342-8u342-b07-0ubuntu1~20.04-b07

Test Results
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5181/1/testReport/

Max. process+thread count
2423 (vs. ulimit of 5500)

modules
C: hadoop-hdfs-project/hadoop-hdfs-rbf U: hadoop-hdfs-project/hadoop-hdfs-rbf

Console output
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5181/1/console

versions
git=2.25.1 maven=3.6.3 spotbugs=4.2.2

Powered by
Apache Yetus 0.14.0 https://yetus.apache.org

This message was automatically generated.


git tag for views_1 is missing

The "Views I" chapter in Mastering Plone Development tells you to git checkout views_1, but there is no tag with that name in https://github.com/collective/ploneconf.site.git

fixed a while ago :-) - cfr. https://github.com/collective/ploneconf.site/tree/views_1


Update about-teams.md

Why:
Proposing this based on a community question: https://github.com/orgs/community/discussions/78092
When a community member asked in the link above I expected to find this information in the docs, this change disseminates the information more widely than just a post in the community.
Closes:

What's being changed (if available, include any code snippets, screenshots, or gifs):
Added Teams can only be made up of members of your organization, outside collaborators are unable to be on a team.
Check off the following:

[x] I have reviewed my changes in staging, available via the View deployment link in this PR's timeline.

For content changes, you will also see an automatically generated comment with links directly to pages you've modified. The comment won't appear if your PR only edits files in the data directory.

[x] For content changes, I have completed the self-review checklist.

@queenofcorgis Thank you for opening this PR and contributing to GitHub Docs 🎉 I've triaged this for review by our team.


Replay Subject for edge cases

This is more of a feature enhancement request wherein in the configuration object we should be able to request a replaySubject instead of the default behavior Subject.
This is mostly required for edge cases , but so is why replaySubject was designed.
Scenario : I have a search form and based on the result I want to display a two different components . Those components do subscribe to the store to get the data in state. Now these two components are not present in the DOM initially, so they do not form the subscription. However when the main component gets the results one of them gets rendered (by virtue of an *ngIf condition) and thus subscribe to the state, but by then the behaviour subject is complete and hence even if they subscribe they won't get the last fetched data.
This case can be solved if the the subject is a replaySubject where even thought the subject is completed , when freshly subscribed it would get the last fetched data.

Thanks for the suggestion!
With BehaviorSubject late subscribers such as in your scenario will still get the last state sent out. However, they won't get any of the state before that last state value of course since BehaviorSubject is really a ReplaySubject(1). Are you looking for the component to get everything that went into the store over time (replay all state changes) or just the latest change? Currently the store will send the latest state so I wanted to check on that part of your scenario there.

I will prepare a stackblitz so that I can explain what is wrong.

Sounds good. Thanks.

I think I was wrong, the issue was the component subscribing to the store was not running the subscription code until it was getting initialized inside ngInit , once I changed the subscription to the constructor things worked fine.
Closing this issue.


Go get does not get versions after v6.0.14

I'm using minio-go v6.0.13 and I need to update to v6.0.24 but go get -u github.com/minio/minio-go only updates to v6.0.14.
If I create new project  go mod init my-project with following main.go:
package main

import _ "github.com/minio/minio-go"

func main() {}

and then run go get, I end up with following go.mod file:
module my-project

go 1.12

require (
	github.com/go-ini/ini v1.42.0 // indirect
	github.com/minio/minio-go v6.0.14+incompatible
	github.com/mitchellh/go-homedir v1.1.0 // indirect
	golang.org/x/crypto v0.0.0-20190513172903-22d7a77e9e5f // indirect
	golang.org/x/net v0.0.0-20190520210107-018c4d40a106 // indirect
)

I have not encountered this with other libraries so why go get is not fetching latest minio-go version?

 Please feel free to reach out to us on slack at https://slack.min.io for such questions.

 And what you said about never using -u, that is the way how you should update your dependencies and it is described in multiple places in go modules docs. https://github.com/golang/go/wiki/Modules#how-to-upgrade-and-downgrade-dependencies

Yes but -u is meant to update all dependencies recursively, that is not a good idea in general because that may make your current dep incompatible.  Our latest release is latest master we make releases every week. So you can be sure that sticking to a commit will work fine.
There is another issue that we will address related to go mod behavior which will be addressed in a separate issue.

Yes but -u is meant to update all dependencies recursively, that is not a good idea in general because that may make your current dep incompatible.  Our latest release is latest master we make releases every week. So you can be sure that sticking to a commit will work fine.
There is another issue that we will address related to go mod behavior which will be addressed in a separate issue.


web: missing settings change events from FileUserDataProvider

This PR fixes #103949
The onDidChangeCapabilities event was received, but the old capabilities used

Great catch. Thanks for the fix


Use the hosted Linux (and Windows?) arm64 runners when available

Based on this blog post, by the end of the year GH will start providing Linux and Windows arm64 runners to open source projects:

https://github.blog/2024-06-03-arm64-on-github-actions-powering-faster-more-efficient-build-systems/

Once those are released we can move from using a self-hosted Linux arm64 runner to these hosted runners.

Originally only available for GitHub Team and Enterprise Cloud plans.
In September they were "generally available" (https://github.blog/changelog/2024-09-03-github-actions-arm64-linux-and-windows-runners-are-now-generally-available/) but it looks like these are still paid runners, not yet offered to open source projects.
Windows nor Linux Arm runners are not present in the docs either:

https://docs.github.com/en/actions/using-github-hosted-runners/using-github-hosted-runners/about-github-hosted-runners#supported-runners-and-hardware-resources
https://github.com/actions/runner-images?tab=readme-ov-file#available-images


Bump Quarkus from 2.3 to 2.6

Let's try to bump Quarkus from 2.3 to 2.6
@pjgg / @mjurc Dependabot is not handling Quarkus updates in this repo?

Is very interesting because, if you have a look at the dependencies managed by "dependantbot" you will see Quarkus.io:
Ref: https://github.com/quarkus-qe/quarkus-test-framework/network/dependencies
Well look at "dependantbot" logs:
https://github.com/quarkus-qe/quarkus-test-framework/network/updates/246714434
Changes to Dependabot Pull Requests                                                 |
updater | +---------+--------------------------------------------------------------------------------------------------------------------------+
updater | | created | io.quarkus:quarkus-bom ( from 2.3.0.Final to 2.6.0.Final ), io.quarkus:quarkus-ide-config ( from 2.3.0.Final to 2.6.0... |


Add nordic locales to KK Pro 🇩🇰🇳🇴🇫🇮🇮🇸

Sweden is an amazing country, but so are Norway, Denmark, Finland and Iceland. Let's show our love for these countries by adding them to KK Pro ♥

These locales are now part of KeyboardKit as:

KeyboardLocale
Localized content
Input set
Secondary Actions


ImageError with NextJS 13.5.3

After updating to NextJS 13.5.3, I'm getting the following errors on the Azure webapp:
2023-09-28T00:48:19.741635131Z upstream image response failed for /ai-icon.png TypeError: fetch failed
2023-09-28T00:48:19.741797035Z     at Object.fetch (node:internal/deps/undici/undici:11457:11)
2023-09-28T00:48:19.742358847Z     at process.processTicksAndRejections (node:internal/process/task_queues:95:5)
2023-09-28T00:48:19.742378547Z     at async globalThis.fetch (/node_modules/next/dist/compiled/next-server/app-page-experimental.runtime.prod.js:135:62935)
2023-09-28T00:48:19.742385348Z     at async invokeRequest (/node_modules/next/dist/server/lib/server-ipc/invoke-request.js:17:12)
2023-09-28T00:48:19.742391048Z     at async /node_modules/next/dist/server/next-server.js:362:39
2023-09-28T00:48:19.742395648Z     at async imageOptimizer (/node_modules/next/dist/server/image-optimizer.js:537:13)
2023-09-28T00:48:19.742407448Z     at async cacheEntry.imageResponseCache.get.incrementalCache (/node_modules/next/dist/server/next-server.js:519:61)
2023-09-28T00:48:19.742412648Z     at async /node_modules/next/dist/server/response-cache/index.js:102:36 {
2023-09-28T00:48:19.742417148Z   cause: [Error: C0A7E36448710000:error:0A00010B:SSL routines:ssl3_get_record:wrong version number:../deps/openssl/openssl/ssl/record/ssl3_record.c:355:
2023-09-28T00:48:19.742421548Z   ] {
2023-09-28T00:48:19.742425648Z     library: 'SSL routines',
2023-09-28T00:48:19.742429448Z     reason: 'wrong version number',
2023-09-28T00:48:19.742432949Z     code: 'ERR_SSL_WRONG_VERSION_NUMBER'
2023-09-28T00:48:19.742436749Z   }
2023-09-28T00:48:19.742440149Z }
2023-09-28T00:48:19.774519436Z ImageError: "url" parameter is valid but upstream response is invalid
2023-09-28T00:48:19.774589738Z     at imageOptimizer (/node_modules/next/dist/server/image-optimizer.js:549:19)
2023-09-28T00:48:19.774596038Z     at process.processTicksAndRejections (node:internal/process/task_queues:95:5)
2023-09-28T00:48:19.774601838Z     at async cacheEntry.imageResponseCache.get.incrementalCache (/node_modules/next/dist/server/next-server.js:519:61)
2023-09-28T00:48:19.774607338Z     at async /node_modules/next/dist/server/response-cache/index.js:102:36 {
2023-09-28T00:48:19.774625038Z   statusCode: 500
2023-09-28T00:48:19.774628939Z }

The webapp freshly deployed with azd shows the following screen.   /ai-icon.png seems broken due to this error.

Reverting to NextJS 13.4.12 resolves the problem.

It needs the following two changes:
img tag instead of Image in src/features/chat/chat-ui/start-new-chat.tsx
and
  images: {
    remotePatterns: [
        {
           protocol: 'https',
            hostname: '**',
             port: '',
             pathname: '**',
         },
     ],
  },

in src/next.config.js

this is now resolved

Fix confirmed, thanks!


this java code print Hello world.

What does the program do ?

In what programming language it is written?

This pull request do not contains files in specific folders. Please fix it and reopen for help see https://help.github.com/articles/moving-a-file-to-a-new-location/


Countries in warehouse create and permission groups not showing

When running the latest:
"name": "saleor-dashboard",
"version": "3.0.0-b.11",
"name": "saleor",
"version": "3.1.0-a.0",
I cannot see permission groups or countries in the warehouse create page without doing a page reload.

It looks like the issue is related to the dashboard, but it's also about quite an old version. I would check if it works as expected in the newest version. Also, please use the saleor-dashboard repo for any issues related to the dashboard.


Use std::os::raw types instead of libc crate

It seems that the libc crate is only really useful in #[no_std] environments. https://stackoverflow.com/questions/44436515/should-i-use-libcc-char-or-stdosrawc-char
We should see if we can replace all uses of libc with std::os::raw.

I found libc crate use of the following items within this project.

c_void

It is used in *mut c_void, in which case both libc and std::os::raw are equivalent to C's void*.

c_char(Both libc and std are used.)

Exist in std::os::raw.

c_ushort

Exist in std::os::raw.

uintptr_t

Not implemented in std::os::raw, but may be replaced by usize.

realloc

Not implemented in std::os::raw. Compatibility with C is not specified, but std::alloc::realloc is the implementation in Rust.

memcpy

Not implemented in std::os::raw, but copy_nonoverlapping is semantically equivalent to C memcopy.

size_t

Not implemented in std::os::raw. However, since --size_t_is_usize is enabled in bindgen, it can be replaced by usize.(ref)

https://github.com/ros2-rust/ros2_rust/blob/0c262973b5abe0b8b66bca0285fae3ec59c0176f/rclrs/build.rs#L37
I consider c_void, c_char, c_ushort, uintptr_t to be fine, what about realloc, memcpy, size_t?

I agree about replacing the integer aliases like you say. We could also use std::ffi instead of std::os::raw, I actually think that's a bit nicer.
For the allocation functions, they are currently only used in one place iirc: In sequence.rs, as a workaround for some functions that were missing in older distros. I had already backported them in https://github.com/ros2/rosidl/pull/667 but they hadn't landed in a Foxy release yet when I wrote sequence.rs. However, I just checked and they've now been released, so there is no need for the workaround anymore, and therefore for realloc and memcpy.

Thank you for the background on realloc and memcpy.
I will create a draft with the replacement with std::ffi and the elimination of realloc and memcpy.

Closed in #284


[BUG] Lifetime production not correct

Describe the bug
The Lifetime production is not the same as found in the enphase app or the enlighten manager. I don't have the CT's installed and they are also not configured. I checked the production.json and there it also is showing the wrong data?

What i do know is that my enphase is updated from version 2.someting.someting a few months ago by the enphase team itself. I don't remember what the reading was before that because i called them to update the gateway to install this integration. (Could not manually install this update)
Account type

[X] Installer
[ ] DIY / DHZ
[ ] Home Owner (This integration is not (fully) functional with a home owner account!)

Envoy

[ ] Metered with CTs installed

[X] Metered without CTs

[ ] Standard

FW version: D8.2.4264

Amount of micro inverters connected: 14

Home Assistant

Version: 2024.9.1

Additional context
Relevant snippet of Home Assistant error log.

This is unfortunately a know issue with Envoys. Local counters might reset in certain situations. Enphase keeps a separate database for readings in their cloud platform so these readings are correct. But since we only read locally from the Envoy, if the data is wrong there, nothing much we can do.
I might consider adding an option to correct the lifetime data via the integration configuration if you are interested.

That would be great! So when you configure the integration that you can give it a offset, or tell the integration what the starting values are? Something like that?

Thanks @catsmanac. @Vincentb19 can you check if https://ENVOY_IP/api/v1/production reports the correct value?

This is what i see when using that endpoint with the installer login.
I am not able to login into the gateway with the homeowner account so i don't know what that is giving me as a value.

:-(  too bad.

Checked again and and I was wrong in trying to use the /api/v1/production, should have said /production. Apologize for the confusion. @vincentwolsink is right in his remark that "Local counters might reset in certain situations". The values in /production inverters section are reportedly resetting to zero every now and then.
In HA, the energy dashboard can handle the resets, as well as utility meters I think. So you could use these to handle the resets. But getting the same numbers for lifetime as enphase website may need some template logic or what @vincentwolsink has in mind.

@Vincentb19 Please try 0.5.0-beta1, correct the lifetime production value in the configuration options and reload the integration.
P.S. Beware that this will cause a huge spike in your energy dashboard that you might want to correct after.

Installed the update yesterday, and it works great. The values increased when the sun was up today. So i am happy with this feature. Thanks for the fast update!


Add context to table manager interface

Move instrumentation to the dynamo table manager client.
This came up in #357.

Once nit, otherwise LGTM


Add Mixmax.

This is a modified version of the Contributing Guidelines.
This pull request adheres to the repository's Code of Conduct

[ ] This PR contains housekeeping (URL edits, copy changes etc)
[x] You know your alphabet - company is listed in alphabetical order in the README
[x] A company profile is included - Not essential but it really helps!
[x] The company directly hires employees - This may sounds odd but while awesome, this list is not for coding bootcamps, "teaching" positions a network (Teacher positions employed directly, such as Treehouse, are allowed), or networking sites for listing a CV looking for gigs
[x] The company added hires remote employees, or positions are available to remote workers and are clearly illustrated as such
[x] A company-profile has been included for each addition to the list
[x] I am an employee of the company mentioned and confirm all details are correct
[x] Remote status has details regarding how the culture includes remote employees, how the company integrated remote workers, etc
[x] Region details any restrictions to applicants based on geography
[x] How to apply details the best approach for new applications, link to open positions, and any other help available for job hunters
[ ] Any missing parts from the profile, please use <Unknown> to allow for future completion

Ping @dougaitken. Let me know if you need anything else!

Ping @dougaitken :)

Hey @bradvogel! Apologies for the delay, had this on the back burner for the past month or so. This is perfect, appreciate the contribution!


Add numpy docstrings

Two methods of the class here are overrides
The __init__.py override dynamically passes all args and kwargs so that can (and should) inherit whatever docstring the parent has (no further action required on your part)
The update override does introduce an additional argument (always_callback), so something to think on here...

is this argument actually required? What is its effect? Is there any alternative way to handle this?
otherwise, will have to think on best way to handle this. The inherited docstring won't include the detail of this new parameter, and a manually defined docstring won't necessarily match up with a particular version of tqdm... This might be a case where dynamic docstring injection is actually appropriate

The other two new methods are missing docstrings and should really receive some that quickly and concisely describe how the methods should be called - tqdm appears to use NumPy docstring format, so be sure to follow that pattern

Got it, thanks for the feedback!
Looks like always_callback isn't really necessary. I'd found it on https://github.com/tqdm/tqdm/issues/845#issuecomment-671048817 where it looked like it was used—though I don't believe that this argument is ever actually passed.

Oh, OK then - if that can be removed then the docstring for update can just be purely inherited, EZPZ


[AIRFLOW-1062] Fix DagRun#find to return correct result

Dear Airflow maintainers,
Please accept this PR. I understand that it will not be reviewed until I have checked off all the steps below!
JIRA

[x] My PR addresses the following Airflow JIRA issues and references them in the PR title.

https://issues.apache.org/jira/browse/AIRFLOW-1062

Description

[x] Here are some details about my PR, including screenshots of any UI changes:
DagRun#find returns wrong result if external_trigger=False is specified,
because adding filter is skipped on that condition. This PR fixes it.

Tests

[x] My PR adds the following unit test:
test_dagrun_find

Commits

[x] My commits all reference JIRA issues in their subject lines, and I have squashed multiple commits if they address the same issue. In addition, my commits follow the guidelines from "How to write a good git commit message":

Subject is separated from body by a blank line
Subject is limited to 50 characters
Subject does not end with a period
Subject uses the imperative mood ("add", not "adding")
Body wraps at 72 characters
Body explains "what" and "why", not "how"

Codecov Report

Merging #2210 into master will increase coverage by <.01%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master    #2210      +/-   ##
==========================================
+ Coverage    67.5%   67.51%   +<.01%
==========================================
  Files         142      142
  Lines       10845    10845
==========================================
+ Hits         7321     7322       +1
+ Misses       3524     3523       -1

Impacted Files
Coverage Δ

airflow/models.py
86.97% <100%> (+0.05%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b55f41f...08045ba. Read the comment docs.

Good catch! LGTM


Change gcloud to gcloud-ruby in docs

From: GoogleCloudPlatform/gcloud-common#142
Change gcloud (and also Gcloud?) to gcloud-ruby when referring to the Ruby library.

@blowmage I'm proposing that all "Gcloud" usages be changed to "gcloud-ruby". This is a bit tricky however in the many cases in which "Gcloud" begins a sentence:

Gcloud uses Service Account credentials to connect to Google Cloud services.


Are comments permitted in appsettings.json?

I'm aware that comments are not part of a valid JSON file, but am wondering if the FileConfigurationProvider checks for them, either accepting or rejecting the configuration file -- it's not clear to me from this documentation.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 0eb4d762-3910-2c57-8741-3306c15537b6
Version Independent ID: ba2254a0-ea8e-9b28-e94b-edd0fc58c043
Content: Configuration in ASP.NET Core
Content Source: aspnetcore/fundamentals/configuration/index.md
Product: aspnet-core
GitHub Login: @guardrex
Microsoft Alias: riande

JsonConfigurationProvider, which inherits from FileConfigurationProvider, uses Newtonsoft.Json to parse .json files. It supports both both single- and multi-line comments, which means you can include comments in appsettings.json and the parser will just ignore them without issue.

Follow-up with the engineers on the announcement ...
https://github.com/dotnet/corefx/issues/33115#issuecomment-434113532
... seems like it will be an opt-in opportunity.


Documentation doesn't match code snippet and image

What type of issue is this?
Documentation issue / typo
What SharePoint development model, framework, SDK or API is this about?
💥 SharePoint Framework
Target SharePoint environment
SharePoint Online
What browser(s) / client(s) have you tested

[X] 💥 Internet Explorer
[X] 💥 Microsoft Edge
[X] 💥 Google Chrome
[X] 💥 FireFox
[X] 💥 Safari
[ ] mobile (iOS/iPadOS)
[ ] mobile (Android)
[ ] not applicable
[ ] other (enter in the "Additional environment details" area below)

Additional environment details

browser version: n/a
SPFx version: 1.14.0
Node.js version: 14.17.1
etc

Issue description
Two seperate issues:
1. Wrong file extension type referenced in code snippet. Showing tsx code snippet instead of ts.

2. Sample image doesn't match html in the code snippet content.  For instance, there is no class styles.button, title and all other elements don't match up with the image.

(https://user-images.githubusercontent.com/8564035/160734255-15848d38-3b75-40a4-8df0-510f647edde5.PNG)
One general question:   Can we get sample source code that are demonstrated from 'Getting started' as it will be helpfu?

I was just working through the getting started series as well and seeing the same discrepancies. It looks to me like there's some kind of style sheet missing maybe or something like that? Is that part of this repo so we can download and continue?

If you have installed @microsoft/generator-sharepoint 1.14.0 version, then you have this problem. With version 1.13.1 you do not have this problem.

The Material is not up to date.

@Teka67  is there a process to update the content so that it matches? Would I do that through a pull request?

Until the docs are updated (or if they need to be completely redone with 1.15), you can paste this CSS inside the .[webpartname] declaration in the SCSS file (generated from a 1.13.1 project):
.container {
    max-width: 700px;
    margin: 0px auto;
    box-shadow: 0 2px 4px 0 rgba(0, 0, 0, 0.2), 0 25px 50px 0 rgba(0, 0, 0, 0.1);
  }

  .row {
    @include ms-Grid-row;
    @include ms-fontColor-white;
    background-color: $ms-color-themeDark;
    padding: 20px;
  }

  .column {
    @include ms-Grid-col;
    @include ms-lg10;
    @include ms-xl8;
    @include ms-xlPush2;
    @include ms-lgPush1;
  }

  .title {
    @include ms-font-xl;
    @include ms-fontColor-white;
  }

  .subTitle {
    @include ms-font-l;
    @include ms-fontColor-white;
  }

  .description {
    @include ms-font-l;
    @include ms-fontColor-white;
  }

  .button {
    // Our button
    text-decoration: none;
    height: 32px;

    // Primary Button
    min-width: 80px;
    background-color: $ms-color-themePrimary;
    border-color: $ms-color-themePrimary;
    color: $ms-color-white;

    // Basic Button
    outline: transparent;
    position: relative;
    font-family: "Segoe UI WestEuropean","Segoe UI",-apple-system,BlinkMacSystemFont,Roboto,"Helvetica Neue",sans-serif;
    -webkit-font-smoothing: antialiased;
    font-size: $ms-font-size-m;
    font-weight: $ms-font-weight-regular;
    border-width: 0;
    text-align: center;
    cursor: pointer;
    display: inline-block;
    padding: 0 16px;

    .label {
      font-weight: $ms-font-weight-semibold;
      font-size: $ms-font-size-m;
      height: 32px;
      line-height: 32px;
      margin: 0 4px;
      vertical-align: top;
      display: inline-block;
    }
  }

@gretchunkim which doc was this in reference to? there's a LOT of tutorials, so would help if you can include a link to the actual doc in question

@andrewconnell here's the exact link:
https://docs.microsoft.com/en-us/sharepoint/dev/spfx/web-parts/get-started/build-a-hello-world-web-part
That's the problem with issue template as well as in the MS documentation page in which it says to submit a view feedback for "This page", hence we assume that link is already included (but it's not).

@gretchunkim said:

That's the problem with issue template as well as in the MS documentation page in which it says to submit a view feedback for "This page", hence we assume that link is already included (but it's not).

Actually, it is... when you click that link it adds a bunch of stuff to the issue template that states "don't delete it". Here's what you get when you click that link for the page you linked to... if you left that stuff there, the link and the actual file would be included.

There are a lot of tutorials outside of Microsoft documentation, but what's the whole point of having an official documentation at all?

I don't follow... this is the official MSFT SPFx docs and the official tutorials. What you reference is a simple typo that can be fixed...
Thanks for the link... I'll get this fixed.

Actually, appears the doc was already update since this issue was initially opened, so there's nothing to fix as it was already fixed in 1ca88faa298ee0d8a29a32d81888314c9b1b1dbb


Add speedLimit attribute to Geofence

Added known attribute to Geofence in continue https://github.com/traccar/traccar/pull/3870

Merged, thanks.


refactor: Migrate Ray blueprint to Data-on-EKS

:bangbang: PLEASE READ THIS FIRST :bangbang:
The direction for EKS Blueprints will soon shift from providing an all-encompassing, monolithic "framework" and instead focus more on how users can organize a set of modular components to create the desired solution on Amazon EKS. We have updated the examples to show how we use the https://github.com/terraform-aws-modules/terraform-aws-eks for EKS cluster and node group creation. We will not be accepting any PRs that apply to EKS cluster or node group creation process. Any such PR may be closed by the maintainers.
We are hitting also the pause button on new add-on creations at this time until a future roadmap for add-ons is finalized. Please do not submit new add-on PRs. Any such PR may be closed by the maintainers.
Please track progress, learn what's new and how the migration path would look like to upgrade your current Terraform deployments. We welcome the EKS Blueprints community to continue the discussion in issue https://github.com/aws-ia/terraform-aws-eks-blueprints/issues/1421
What does this PR do?
The PR removes the kuberay experimental add-on from the eks-blueprints repo. The Ray blueprint has been moved to the Data-on-EKS repo  and new PR was created to move the kuberay-operator helm chart deployment in the blueprint. Further enhancements to the Ray blueprint will be made in the data-on-eks repo.

Motivation

Related to #1421
Resolves #887

More

[ ] Yes, I have tested the PR using my local account setup (Provide any test evidence report under Additional Notes)
[ ] Yes, I have updated the docs for this feature
[ ] Yes, I ran pre-commit run -a with this PR

For Moderators

[ ] E2E Test successfully complete before merge?

Additional Notes

No longer needed.


Add parens to force the order of operations in an expression trying

Add parens to force the order of operations in an expression trying
to do "databuffer + offset" so that we don't overflow the uint64_t's
we're using for addresses when working with high addresses.
Found with clang's ubsan while doing darwin kernel debugging.
rdar://problem/48728940
git-svn-id: https://llvm.org/svn/llvm-project/lldb/trunk@355761 91177308-0d34-0410-b5e6-96231b3b80d8
(cherry picked from commit 9da7138a76c370a3cf534ff0ed12375df061d280)

@swift-ci test and merge


Wilderness Stuff

Quite a large pull request, with changes across the whole of the wilderness, texturing many objects that were missing them such as trees, roots, walls, and rocks.
The bosses Callisto, Vet'ion and Vennantis (and their weaker counterparts) arenas have also been textured with Vet'ion getting the most love due to how their arena was built by Jagex.
I also tried to tame the unrelenting disco that is the Ferox Enclave, reducing the speed and range at which lights pulse or flicker.
Teleport obelisks:

Venenatis/Spindel:

Subtle but better than nothing, Callisto is about the same as this, bland due to how Jagex created it with complex models
Vet'ion/Calvar'ion:

The changes to the area are an attempt to stop the environment from switching back and fourth too often.
Failing the entrance obstacle and clicking on the door to try again no longer causes the environment to swap to wilderness then back to frozen waste plateau rapidly, same for the portion after the log balance.
Video of above, before and after swaps at the midway mark:
https://github.com/user-attachments/assets/329b3f50-70e5-4b56-9e6c-3b1d368d8163
Daimon's Crater/Bounty Hunter:

Ferox:
https://github.com/user-attachments/assets/b999226f-2302-4aa1-bae6-88bad4acc99a
https://github.com/user-attachments/assets/ed28abb9-b01b-455e-8927-cd7cff73133b
Chaos Temple:

Zombie Pirate boat:

Agility Course:

Agility shortcut log fix:

This is ready for review and merging.

Solid PR!


[docs] Create more hooks demos

Base UI hooks are not described well in the docs. Most of the demos showcase components.
We need to demonstrate how hooks' parameters affect their functionality.
We need to figure out the best way to display them - either show both component and hook demos one above the other or add a toggle that would allow readers to switch between component and hook demos. @danilo-leal, @samuelsycamore, what do you think?

Now that hooks are more of an escape hatch, I think we don't need separate demos for them. Perhaps one page explaining the concept and showing a few examples would be enough?
cc @colmtuite


mount batch table

The hot keys now work and show the batch view. Needs some work so that they turn each other on/off... at the moment, In order to see the batch you need to first turn traffic off.
Regarding the batch view, I am not sure how to make a progress bar with rich. In my first implementation, I just put a with statement around the server. It appears that it needs a context manager (progress in rich). I guess I could do the same around the console client but it doesn't seem elegant ahah.

Yeah, I think it might work differently in textual. Something to explore I guess :)


Feature/Add CI

This should now permit CI flows to run on this repo.
Basic pipeline that will build the image then run the default rake-task

 bundle exec rake
bundler: failed to load command: rake (/app/vendor/ruby/2.7.0/bin/rake)
Bundler::GitError: The git source https://github.com/citizensadvice/citizens-advice-style-ruby.git is not yet checked out. Please run `bundle install` before trying to start your application

https://jenkins.devops.citizensadvice.org.uk/job/ca_testing/view/change-requests/job/PR-7/3/console

Rightio @zhelyan Not quite sure why that's happening as I run bundle install inside my Dockerfile. I'll take a look later today / tomorrow.

I've re-pushed, re-based and then made some tweaks to the Dockerfile as nokogiri was missing some stuff to compile.
Now getting a new issue where it says it can't run rake. I've ran identical commands (IN docker), on my local machine - At a loss why this isn't working.
Also spun up my docker container in interactive mode and ran that, all seems fine.... Bit confused what the issue is here?

$ whoami
whoami: unknown uid 1000
/home/ec2-user/workspace/ca_testing_PR-7 $ bundle exec rake
The git source https://github.com/citizensadvice/citizens-advice-style-ruby.git is not yet checked out. Please run `bundle install` before trying to start your application

no user with id 1000 in the container

@zhelyan Does this auto-build on each commit. Or have I broken something? It isn't building on the latest one currently.

Re-ping @mrdaniellewis / @zhelyan - Is this GTM?


Add dnsTrailingDotDisabled options like in operator

In the redpanda operator you can use dnsTrailingDotDisabled to disable the trailing dot in the advertised address to Kafka clients.
Please port this option to the helm chart to allow java kafka client connections over https (as it prevents https certificate validation).

That seems like a security risk. Wouldn't it be better to add the trailing dot to the SAN?
The better flag, imho, would be one to remove the ambiguous SANs.
mycluster-0.mynamespace.svc.cluster.local also matches `mycluster-0.mynamespace.svc.cluster.local.stealyourdata.com. but mycluster-0.mynamespace.svc.cluster.local. is fully qualified and cannot be spoofed.
WDYT?


updated and added styling to tree explorer

There are validations that require attention: null is typeof object and undefined values.
http://stackoverflow.com/questions/18808226/why-is-typeof-null-object

Do we have folding/ collapsing functionality?
https://seecode.run/#-KNG3y4JI_Iia4wOy605
There is an offset when an object is the last child of another object


Missing documentation for head_ref_force_pushed issue event

Code of Conduct

[X] I have read and agree to the GitHub Docs project's Code of Conduct

What article on docs.github.com is affected?
https://docs.github.com/en/developers/webhooks-and-events/events/issue-event-types
What part(s) of the article would you like to see updated?
In the responses returned by the Timeline events and Issue events APIs for PRs that have been force-pushed, events of type head_ref_force_pushed can be found. However, this kind of event is not documented in the Issue event types page.
Additional information

edited  by maintainer:
Here is the writer's review for this issue.

Code of Conduct

[x]  I have read and agree to the GitHub Docs project's Code of Conduct

What article on docs.github.com is affected?
https://docs.github.com/en/developers/webhooks-and-events/events/issue-event-types
What part(s) of the article would you like to see updated?
In the responses returned by the Timeline events and Issue events APIs for PRs that have been force-pushed, events of type head_ref_force_pushed can be found. However, this kind of event is not documented in the Issue event types page.
Additional information
No response

https://github.com/github/docs/issues/11129#issue-1023999560

Servicio.linode.com

Es algo nuebo e inobador

Thank you for opening this issue! You or anyone else is welcome to open a PR to add the head_ref_force_pushed to https://docs.github.com/en/developers/webhooks-and-events/events/issue-event-types.

I have made PR #14910. Please check and suggest changes.


Added names of open source organisations to the website.

Issue #25 Added Project Jupyter , Clear Foundation, Open Source Hardware Association ,Open Source Security Foundation to the website open source organization list.

@AdityaDhavale Resolve conflict

@iriteshmishra I've opened a new PR with no conflicts . Kindly check into it.


Virtual Participant meeting won't open in UI if meeting name has &, /, or + symbols

Important: Bug reports submitted here should relate specifically to the open source sample amazon-transcribe-live-meeting-assistant project. Do not submit bugs related directly to any AWS service.
If your issue relates to Amazon Transcribe, Amazon Bedrock or Amazon Bedrock Knowledge Base - setup, user provisioning, document ingestion, accuracy, or other aspects of the service, then first check the service documentation, and then reproduce the problem using the relevant AWS service console before engaging AWS support directly. Thank you.
Describe the bug
Virtual Participant meeting won't open in UI if meeting name has &, /, or + symbols

fixed in v0.2.4


[Fix][api]Fix multiple threads creating folders will result in multiple identical folders

Fixed this bug "multiple threads creating folders will result in multiple identical folders" #3487
If use a solution that adds unique constraints to your database, you will need to make changes in both Mysql and PostgresQL, and your reliance on database features may make certain versions of your database incompatible.
( I submitted PR for the first time. I'm not very familiar with it...)

Hi,
I am sorry that issue #3487  has been fix in pr #3519 [3], if you are interested, you can pick up some issue below [1] to implement. And the code-submit specifications refers to [2].
[1] #3556 #3557 #3558
[2] https://dolphinscheduler.apache.org/zh-cn/docs/development/submit-code.html
[3]


Adding MidiEvent.Clone()

There's a couple of things in the inheritance hierarchy that could optionally be optimized that I'll comment on in the source.
Closes #114.

thanks for this, looks good. Your ideas about UnknownMetaEvent sound good. I need to think about whether making MidiEvent abstract might end up being a breaking change and if so it should be saved for a new major version (1.8) which we are long overdue anyway. Let me know if you want to make those extra changes first, or I can merge as is.

Everybody points me to https://github.com/dotnet/corefx/blob/master/Documentation/coding-guidelines/breaking-change-rules.md which says it would be a breaking change because of the public and protected constructors.
I don't really have a strong opinion, but let's not miss making MidiEvent abstract in 1.8 if that's something you want to do.

OK, I think we should say that next version of NAudio will be 1.8. Its been long enough. So make the abstract change and I'll accept the PR.

Once thing that I really wish I could change is that there are constructors that don't take all the parameters needed to fully initialize. For example, the SMPTEOffsetMetaMidiEvent constructor. In order to fully initialize it you have to set properties afterwards.
I'd like to remove the parameterless MidiEvent constructor and convert the constructors that take BinaryReader into static functions named Import for symmetry with the Export methods. Then the absolute time and channel would always be passed into Import which would do the reading call the constructor which would call the base MidiEvent constructor with the absolute time and channel.
I feel like I could tighten up the API consistency. Are you comfortable with that kind of change?

hi @jnm2. These are all good suggestions. I tend to take a fairly conservative approach to breaking changes. If possible I introduce new methods and put the Obsolete attribute on the old ones, as a warning that it will go away in vNext, and add a comment saying what should be used instead. Would that work for you if you made a new SMPTEOffsetMetaMidiEvent ctor and marked the old one Obsolete? Same with the BinaryReader constructors - obsolete them and add the new ones. Finally the parameterless MidiEvent is protected and looks like it could be removed without likely causing any issues for consumers of the library.
The MIDI part of NAudio is some of the oldest code in the library so certainly will benefit from some cleanup. I do actually have a number of open source projects that build on it (e.g. MIDI File Mapper and MIDI File Splitter) as well as some closed source apps too. So the obsoleting approach will help for a smoother migration of those projects.

Sure, that's a good idea. Also EditorBrowsable.Never for intellisense?

that's not one I was aware of, but sure, would make sense.

We have a bit of a clash. If I leave the obsoleted ChannelAfterTouchEvent(BinaryReader) constructor, I will also have to leave and obsolete the MidiEvent() constructor. Since ChannelAfterTouchEvent ctor calls an obsolete ctor, it generates a compiler warning. You have warnings as errors turned on which is good but will also require use of pragmas every piece of code that touches an obsoleted base ctor.
I think we're going the right direction as far as guaranteeing that the event's invariants are satisfied at construction. I really want to kill that MidiEvent() constructor. Another option would be to have ChannelAfterTouchEvent(BinaryReader) call base(default(long), default(int), default(MidiCommandCode)) since that simulates the effect of the parameterless base constructor.
Thoughts?

Also, to avoid duplicating code, I'll have to introduce a helper static method just for the sake of keeping the obsoleted ChannelAfterTouchEvent(BinaryReader) constructor:
public ChannelAfterTouchEvent(BinaryReader br)
    : this(default(long), default(int), ReadAftertouchPressure(br))
{
}

private static int ReadAftertouchPressure(BinaryReader br)
{
    var afterTouchPressure = br.ReadByte();
    if ((afterTouchPressure & 0x80) != 0)
    {
        // TODO: might be a follow-on
        throw new FormatException("Invalid afterTouchPressure");
    }
    return afterTouchPressure;
}

public static ChannelAfterTouchEvent Import(long absoluteTime, int channel, BinaryReader br)
{
    return new ChannelAfterTouchEvent(absoluteTime, channel, ReadAftertouchPressure(br));
}

How likely do you think it is that it that the BinaryReader constructors are being used from the outside?

yeah, thinking about it a bit more and checking through my own library of MIDI projects, I think its actually quite unlikely that anyone is using this since the main way in is through the MidiFile class. So let's boot the BinaryReader constructors out, and make a clean break with them for 1.8 which I'll probably release soon after we've done this change.

just wondering if you're planning to do make any more changes to this PR? I'd like to release NAudio 1.8 fairly soon and for it to include this change

Oh yes, I will try to wrap that up tonight.

My sister's hard drive failed the day before her paper was due and I spent this evening trying to recover it. I'll shoot for tomorrow.

no problem - hope you recovered her paper! wasn't meaning to rush you anyway. do it when you have time.

I feel like MidiEvent is the wrong abstraction level to be using NoteLength and OffEvent, but I have to keep the scope from creeping here.

Almost finished, pushed a temporary commit in case you want to critique current progress.

only had time for a quick look, but seems good to me. will be nice to get this code cleaned up a bit. If possible can you run the build.bat to make sure all projects are still building.

Yes, it won't build till I'm done with the MetaEvent refactoring which is in progress.

Had a question about "auto sensing"- the MIDI spec says "active sensing." I added an AutoSensingEvent and wondered if it should have been an ActiveSensingEvent. MidiEventType.AutoSensing would have to change or be aliased.

hmm, looks like a long-standing typo. Add ActiveSensingEvent in there but leave the old one aliased and [Obsolete] just in case for backwards compatibility if possible

Another question along the same lines. The spec always has "aftertouch" as a single word but it was pascal-cased as AfterTouch in NAudio which implies two words. What do you think about changing it? There is an existing class name ChannelAfterTouchEvent and two enum elements.

that one's a bit more painful as it will be another breaking change, but we might as well do it and I'll just need to make sure to mention it in the 1.8 release notes.

I figure getting all the pain in at once is best.

I figure getting all the pain in at once is best. These things are however negotiable if you want some and not others.

Noticed we have MetaEventType.SetTempo paired with TempoEvent, might be fine.

TempoEvent.Tempo could be BeatsPerMinute

probably leave Tempo as is. more people likely to be using that. Hopefully the XML docs mention BPM so should be in the intellisense

It passes tests, the only thing left is for me to figure out which obsolete method signatures should be added. Things like new MetaEvent will never be able to work of course since that's now abstract and you're forced to give every event the most derived type.
Maybe you could use this against your projects and paste your error list so I can see what that's going to look like?

I'm sorry this is so much to look through. I rushed to get it all in last night. After we make sure the changes will be compatible, I'll rebase on the latest from master.
Besides the ActiveSensing and Aftertouch renames, I also removed MidiEvent.DeltaTime because that's purely a serialization concern and it wasn't needed, and there's no sensible way to use it when changing the containing list. I also changed deserialization so that the native MIDI command code is preserved such that events coded NoteOn with velocity 0 now come through as NoteOnEvents instead of NoteOffEvents. Do you see a problem with those things?

OK thanks for this. I will need to take a good look and think about whether the NoteOnEvent change will be a breaking change for my apps which do a lot of manipulation of note offs. Also need to check MidiFile is not broken by the changes to Absolute time - can't see how it works for type 1 files and if previous event is null. Hopefully will get a chance to try it properly later this week

Good point about MidiFile. I should write a basic test for it.

I just got back from vacation. I think this takes care of type 1 files now. Is there anything else outstanding?

thanks, will take another look when I can get some time. My concern with type 1 files was to do with whether AbsoluteTime was getting set back to 0 correctly when we start on the events from a subsequent track. Original PR looked like it had lost that behaviour.

You're right, and I have made an edit to that effect and added tests to confirm that is no longer a problem.

just a quick update. I am testing this, but there are a lot of breaking changes in my existing MIDI applications especially with things like the parameters for TempoEvent swapping round which means the code compiles but has the wrong meaning. Will probably take me a bit longer to test this.
With hindsight would have been better to do this in smaller steps, getting clone in first and a few of the safer refactorings, before bringing in breaking changes as well

@markheath I agree about the smaller steps. The tradeoff was that it made it a lot easier for me and I had been in a hurry to finish it before vacation. I've been worrying about this all along. For the sake of clarity, maybe I should redo the work in steps. It won't be hard because it's still recent in my mind and I have the beginning and end.
I have a suggestion. I should remove the refactoring commits from this PR so clone can go through, and I'll break up the refactor commit into a few focused PRs.

I should also document every individual API change, such as TempoEvent's constructor, so that 1) you can vet and discuss and 2) we have a nice changelog for the release.
I need to find a good API tool.

What I've done is put the monolithic refactor in a new branch (https://github.com/jnm2/NAudio/tree/midi-refactor-wip) so we can make this PR just about Clone.
Then, I'll start a new issue for discussion of moving to abstract MidiEvent and the other items, and what they entail. I intend to document every individual API change, such as TempoEvent's constructor, so that 1) you can vet and discuss and 2) we have a nice changelog for the release.

that's great. Would allow us to fast-track all the non-breaking changes in very quickly, and tackle the tricky ones individually

@markheath Let's merge this PR if that's okay so that this is out of the way.
I went through the breaking changes and converted them into an issue for discussion

thanks, have made a couple of comments, am happy to bring this straight in though. Thanks for the thorough writeup of other issues, will try to get round to responding to them all soon

I adapted RawMetaEvent which was on the list to add later.
Also, I seem to have a number of commits from your master branch that no longer exist on GitHub. Did you force push or something?

that's strange. what are they? I tend to push with Visual Studio GitHub plug-in, and sometimes use the Merge pull request button in GitHub, but I wouldn't expect them to be doing a force.

This is what I got when I fetched upstream/master: https://github.com/jnm2/NAudio/tree/master-missing-commits
Maybe a GitHub glitch?

This is what I got when I fetched upstream/master: https://github.com/jnm2/NAudio/tree/master-missing-commits
Probably somehow I goofed with Visual Studio's rebase onto?

I'll bet I messed something up and you can ignore it.

yeah looks like a rebase - same commits, different hashes. This PR merges cleanly so I'll do it now.


Bandwidth display component

Figure out a way to display the bandwidth in a nice way

closed with https://github.com/r2binx/heimboard/pull/13


Saving raw object converts highpass and lowpass from None to nan, and filter cannot handle it afterwards

Hi,
It seems you can do this:
>> raw = mne.io.read_raw_egi('file-with-no-highpass-and-lowpass-information')
>> raw.info['highpass'] is None
True
>> raw.save('temp.fif')
>> raw = mne.io.Raw('temp.fif')
>> raw.info['highpass']
nan
>> raw.filter(l_freq=1, h_freq=40)
>> raw.info['highpass']
nan

So saving a raw object load from egi with highpass and lowpass set to zero has highpass and lowpass converted to nan, and after reread for example filtering assumes that "no information" is coded as None, and is not willing to update highpass and lowpass information, if otherwise. Data changes ok, though. As a workaround I am at the moment converting None's to 0 and sfreq/2 before saving, but it might not should be necessary.

see https://github.com/mne-tools/mne-python/pull/2655

Yes, that does the trick. Thanks.


Added imagePullSecrets to admission-controller and proxy-scanner. Version increased to 0.24.0

This PR adds optional support for imagePullSecrets to the admission-controller and proxy-scanner helm charts. This is required for prospects and customers using their own container registries.
In addition the version numbers have been increase from 0.23.0 to 0.24.0 for the helm-charts and images used. It needs to be clarified if this works as part of the release process of the container images for admission-controller and proxy-scanner.

Closing PR as changes happen outside of this repo.


updated xtorrent (2.1(v171))

Thank you for the contribution. It was merged directly as d8afa37be06656270977e216f49a99586aa68002 to keep commit history cleaner. Your contribution is still credited to you.


NSFS | NC | Test issue - Ignore

Environment info

NooBaa Version: VERSION
Platform: Kubernetes 1.14.1 | minikube 1.1.1 | OpenShift 4.1 | other: specify

Actual behavior

This is a test issue, please ignore

Expected behavior

Ignore it

Steps to reproduce

None, always works

More information - Screenshots / Logs / Other output
Test, no info

test

test

test

test

can close?

no, test

t

nope