Nix-related fixes for fractional branch

Targets fractional. Applies the Nix-related commits from main (done via cherry pick).
Deletes HEAD commit adding flake.nix so can't use GitHub to perform merge -- if this is OK, I'll force push to fractional.

fractional is being edited by >1 person actively, so I'll do a revert commit instead of force pushing. Changes made directly on fractional. Closing.


Camera demo rgb stereo align

Resolve RGB alignment issue by using stereo.setDepthAlign(dai.CameraBoardSocket.RGB)
Note that we need the python libs as per https://github.com/luxonis/depthai-python/pull/147/commits/0a27ebcf5301ba9166d014bbbb543e431b5af212 for this to work.
We get some warnings, and the disparity frames seem to flick back to front a bit.
If we run without -pcl, to test if it's a performance issue on host side,
the left/right flickering is quite fast.
python main.py -ext 1 -sub 0 -pcl -rgb -lr 0
[14442C1091EB8FD000] [8.681] [StereoDepth(5)] [warning] Median filter usage with LR-check/Extended/Subpixel is not yet implemented. The filter will be disabled
[14442C1091EB8FD000] [8.681] [StereoDepth(5)] [warning] DepthAlign option ignored, as it requires LR-check mode to be enabled

Awesome, thanks!  CC: @saching13

Thanks alot for the PR.

Closing due to inactivity.


Office not available

I am trying to publish my first Outlook Addin, following this https://docs.microsoft.com/en-us/office/dev/add-ins/quickstarts/project-quickstart
it worked just fine on local setup.
However, when I tried to place it somewhere live, I created a build using

npm run build

it created a build inside the dist directory. I placed it on hosting but when I installed the addin the addin didn't appear. In chrome console, it says "Office is not defined".
My index.js code is here, it's simple,
import { views } from './views.js'; import { vlink } from './vlink.js'; 'use strict'; (document).ready(function () {     Office.onReady(function () {             views.init();                 vlink.init();     });     Office.initialize = function(reason){     }; })();
The index.html head tag has,
`

vlink-addin
<!-- Office JavaScript API -->
<script type="text/javascript" src="https://appsforoffice.microsoft.com/lib/1.1/hosted/office.js"></script>

<!-- LOCAL -->
<!-- <link rel="stylesheet" href="node_modules/office-ui-fabric-js/dist/css/fabric.min.css" />
<link rel="stylesheet" href="node_modules/office-ui-fabric-js/dist/css/fabric.components.css" /> -->

<!-- CDN -->
<!-- For the Office UI Fabric, go to http://aka.ms/office-ui-fabric to learn more. -->
<link rel="stylesheet" href="https://static2.sharepointonline.com/files/fabric/office-ui-fabric-js/1.2.0/css/fabric.min.css" />
<link rel="stylesheet" href="https://static2.sharepointonline.com/files/fabric/office-ui-fabric-js/1.2.0/css/fabric.components.min.css" />
<!-- JQUERY -->
<script src="https://ajax.googleapis.com/ajax/libs/jquery/3.3.1/jquery.min.js"></script>
<script src="https://code.jquery.com/ui/1.12.1/jquery-ui.min.js" integrity="sha256-VazP97ZCwtekAsvgPBSUwPFKdrwD3unUfSGVYrahUqU=" crossorigin="anonymous"></script>
<!-- Template styles -->
<link href="app.css" rel="stylesheet" type="text/css" />

`

@shahroon Sorry that you're hitting this issue. Depending on your setup, perhaps one of these can help:

Test and debug Office Add-ins
Tips for testing Outlook add-ins
Deploy and publish add-ins

By the way, you don't need to use both Office.onReady and Office.initialize; we recommend Office.onReady (see section about how to initialize your add-in).
Just curious but could you share why you used the Project quick start?

Sorry, wrong link. The one I was following is https://docs.microsoft.com/en-us/outlook/add-ins/addin-tutorial?context=office/dev/add-ins/context
Is there any other tutorial that I should be following?

I have gone through the links you provided, I couldn't find anything helpful there.
Let me explain to you the problem in detail,
I have added office.js in my index.html
<!-- Office JavaScript API -->
<script type="text/javascript" src="https://appsforoffice.microsoft.com/lib/1.1/hosted/office.js"></script>

So, logically I should have Office object available in my index.js, but it seems like after the build it somehow couldn't find it.
Here is the index.html after the build,
<!-- Copyright (c) Microsoft Corporation. All rights reserved. Licensed under the MIT license. -->
<!-- See LICENSE in the project root for license information -->

<!DOCTYPE html>
<html>

<head>
    <meta charset="UTF-8" />
    <meta http-equiv="X-UA-Compatible" content="IE=Edge" />
    <meta name="viewport" content="width=device-width, initial-scale=1">
    <title>vlink-addin</title>

    <!-- Office JavaScript API -->
    <script type="text/javascript" src="https://appsforoffice.microsoft.com/lib/1.1/hosted/office.js"></script>

    <!-- LOCAL -->
    <!-- <link rel="stylesheet" href="node_modules/office-ui-fabric-js/dist/css/fabric.min.css" />
    <link rel="stylesheet" href="node_modules/office-ui-fabric-js/dist/css/fabric.components.css" /> -->

    <!-- CDN -->
    <!-- For the Office UI Fabric, go to http://aka.ms/office-ui-fabric to learn more. -->
    <link rel="stylesheet" href="https://static2.sharepointonline.com/files/fabric/office-ui-fabric-js/1.2.0/css/fabric.min.css" />
    <link rel="stylesheet" href="https://static2.sharepointonline.com/files/fabric/office-ui-fabric-js/1.2.0/css/fabric.components.min.css" />
    <!-- JQUERY -->
    <script src="https://ajax.googleapis.com/ajax/libs/jquery/3.3.1/jquery.min.js"></script>
    <script src="https://code.jquery.com/ui/1.12.1/jquery-ui.min.js" integrity="sha256-VazP97ZCwtekAsvgPBSUwPFKdrwD3unUfSGVYrahUqU=" crossorigin="anonymous"></script>
    <!-- Template styles -->
    <link href="app.css" rel="stylesheet" type="text/css" />
</head>

<body class="ms-font-m ms-welcome">

<script type="text/javascript" src="polyfill.js"></script><script type="text/javascript" src="app.js"></script></body>

</html>

Your help is needed as it is taking too long to finish.

Thanks for your help it appears that it was an issue on JS end. Figured it out and fixed.


Enable ImageBitmap again for external images in Model

ImageBitmap was added in https://github.com/CesiumGS/cesium/pull/7579 to reduce frame rate hitches when loading models and a follow up PR was added to fix a regression for images that were being flipped incorrectly https://github.com/CesiumGS/cesium/pull/7701. The PR added a flag called preferImageBitmap and each system now had to opt-in to using ImageBitmap. While reviewing https://github.com/CesiumGS/cesium/pull/9624 I noticed a pretty big omission where calls to fetchImage in Model.js were not setting this flag to true and were not taking advantage of ImageBitmap. Note that this was only happening for external images; embedded images were fine because they go through a different code path, loadImageFromTypedArray, which defaults to using ImageBitmap if available. Thankfully embedded images are much more common in 3D Tiles so the regression wasn't super serious.
This wasn't mentioned in the PR at all so I think it was a mistake rather than intentional. I looked at all the sample models and everything still looks correct after the change. I also tested the bike model in https://github.com/CesiumGS/cesium/pull/7579 and saw the expected improvement.
I fixed this in GltfImageLoader too which will be used as part of the model rewrite.

Thanks for the pull request @lilleyse!

:heavy_check_mark: Signed CLA found.
:grey_question: Unit tests were not updated.

Make sure you've updated tests to reflect your changes, added tests for any new code, and ran the code coverage tool.

Reviewers, don't forget to make sure that:

[ ] Cesium Viewer works.
[ ] Works in 2D/CV.
[ ] Works (or fails gracefully) in IE11.

I was able to confirm the reduction in frame rate hitches, all model loading Sandcastles look good and all tests pass. Thanks @lilleyse!


[Technical Question] Cannot find azure.iot.hub.models

I am trying to use the sample from microsoft(link below) to get device twin data
https://docs.microsoft.com/en-us/azure/iot-hub/iot-hub-python-twin-getstarted#feedback
I have installed azure-iot-hub as shown in the instruction.
I have tried pip3 install as well. Yet, still got the below error
"ModuleNotFoundError: No module named 'azure.iot.hub.models'"
Any ideas?
AB#7724107

@leolauleolau ,
Could you please provide the steps what you followed to get this error? I want to see how will it repro.
Zoltan

hi @leolauleolau , is this still an issue for you? We will close this issue if you confirm it has been resolved. Thanks!

@leolauleolau ,
Could you please provide the steps what you followed to get this error? I want to see how will it repro.
Zoltan

Sorry for the late reply. The issue is still here.
I am using a raspberry pi 4 2GB RAM to run the example script.
I have a Python 3.7.3 IDLE.
After running the command pip install azure-iot-hub and pip3 install azure-iot-hub
It gives out an error message as follow

Command "/usr/bin/python3 -u -c "import setuptools, tokenize;file='/tmp/pip-install-yc3l8gz0/uamqp/setup.py';f=getattr(tokenize, 'open', open)(file);code=f.read().replace('\r\n', '\n');f.close();exec(compile(code, file, 'exec'))" install --record /tmp/pip-record-d_iugsya/install-record.txt --single-version-externally-managed --compile" failed with error code 1 in /tmp/pip-install-yc3l8gz0/uamqp/

I ignore this and continue to run the code (which is the same as the document)
import sys
from time import sleep
from azure.iot.hub import IoTHubRegistryManager
from azure.iot.hub.models import Twin, TwinProperties, QuerySpecification, QueryResult
IOTHUB_CONNECTION_STRING = "[IoTHub Connection String]"

DEVICE_ID = "[Device Id]"
def iothub_service_sample_run():
    try:
        iothub_registry_manager = IoTHubRegistryManager(IOTHUB_CONNECTION_STRING)
        new_tags = {
                'location' : {
                    'region' : 'US',
                    'plant' : 'Redmond43'
                }
            }
        twin = iothub_registry_manager.get_twin(DEVICE_ID)
        twin_patch = Twin(tags=new_tags, properties= TwinProperties(desired={'power_level' : 1}))
        twin = iothub_registry_manager.update_twin(DEVICE_ID, twin_patch, twin.etag)
        # Add a delay to account for any latency before executing the query
        sleep(1)
        query_spec = QuerySpecification(query="SELECT * FROM devices WHERE tags.location.plant = 'Redmond43'")
        query_result = iothub_registry_manager.query_iot_hub(query_spec, None, 100)
        print("Devices in Redmond43 plant: {}".format(', '.join([twin.device_id for twin in query_result.items])))
        print()
        query_spec = QuerySpecification(query="SELECT * FROM devices WHERE tags.location.plant = 'Redmond43' AND properties.reported.connectivity = 'cellular'")
        query_result = iothub_registry_manager.query_iot_hub(query_spec, None, 100)
        print("Devices in Redmond43 plant using cellular network: {}".format(', '.join([twin.device_id for twin in query_result.items])))
    except Exception as ex:
        print("Unexpected error {0}".format(ex))
        return
    except KeyboardInterrupt:
        print("IoT Hub Device Twin service sample stopped")
if __name__ == '__main__':
    print("Starting the Python IoT Hub Device Twin service sample...")
    print()
    iothub_service_sample_run()

And the error is it cannot find the module even I have restart the pi.

Traceback (most recent call last):
File "/home/pi/device twin.py", line 3, in
from azure.iot.hub import IoTHubRegistryManager
ModuleNotFoundError: No module named 'azure.iot.hub'

So, is it my command problem or the script? Thanks

@leolauleolau,
In the original issue the error was:
"ModuleNotFoundError: No module named 'azure.iot.hub.models'"
In the second one it is:
'ModuleNotFoundError: No module named 'azure.iot.hub'
I cannot repro the problem and I think your Python installation is not working correctly. It looks like doesn't find modules in general. Is any other Python script working on your setup?

@zolvarga
Both errors happened at different time. I have try the same script on vs code of my own computer. It works.
Yet, this error came out when i executed on raspberry pi. The second error came out when I tried again one month later.
I have been sending messages to the cloud through pi using python with the module  "azure.iot.device" and it works fine.
This script was disabled before I ran the sample code.

hi @leolauleolau , has this issue been resolved? it appears that it's outside the control of the Python SDK and rather related to the python runtime on the Pi-- let us know if you're still having issues. Otherwise we'll go ahead and close this issue. Thanks!

Seems like pi's python problem. Thanks for the help

@zolvarga, @leolauleolau, thank you for your contribution to our open-sourced project! Please help us improve by filling out this 2-minute customer satisfaction survey

Seems like pi's python problem. Thanks for the help

I am getting exactly the same issue, how did you solve it @leolauleolau ? I am using a Le Potato (Debian)

Same issues with you on RPi4 running fresh installed Bullseye. Was not able to import azure.iot.hub modules both from python script and cmdline interrupter. While all other azure modules i.e. azure.core / azure.iot.device work find and was installed the same way as azure.iot.hub in same dir.
I tried installing the module via all different method, with/wihtout sudo, pip, pip3, python -m pip , python3 -m pip... all to make sure the its installed properly.
In my case, i end up finding the module was not actually installed in the path. And have to manually copy the source file over to fix the issues.(/usr/local/lib/python3.9/dist-packages/azure/iot/hub is missing)
Install module via pip python3 -m pip install azure_iot_hub
Check the installation path for the module pip3 list -v, in my case, i have the module located at /usr/local/lib/python3.9/dist-packages/
Download the Built Distributions from pypl : https://pypi.org/project/azure-iot-hub/#files
Copy the source file form ../azure/iot/hub in the zip file, to the installation path, i.e./usr/local/lib/python3.9/dist-packages/azure/iot/hub
That should fix the problem
https://stackoverflow.com/questions/76992247/linux-no-module-named-azure-iot-hub/77018828#77018828

I had the same: No /usr/local/lib/python3.9/dist-packages/azure/iot/hub folder
Did a pip .... --force-reinstall - that helped


Changed UI for translator

🚀 Pull Request
Description
Changed the UI for the translator

Related Issue
If this pull request addresses an issue, link to it here (e.g., Closes #123).

Type of Change
What kind of change does this pull request introduce?

[x] 🐛 Bug fix
[x] 🚀 New feature
[ ] 📄 Documentation update
[x] 🛠 Code improvement/refactor
[x] 🖼 UI/UX update
[ ] Other (please specify)

Screenshots (if applicable)
Before:

After:

Checklist
Please ensure the following tasks are complete before submitting the pull request:

[x] I have tested my changes and ensured they work as expected.
[x] I have added any necessary documentation or comments.
[x] I have checked the existing issues and pull requests to avoid duplicates.
[x] I have starred this repository.
[x] I have reviewed my code for best practices and readability.
[x] I have included any relevant tests (if applicable).

Additional Context
Add any other relevant information or context about the pull request here.

@gauravsingh1281 please merge this pr and give feedback.

Ok

@gauravsingh1281 please help me what i have to do to solve this conflict.

@gauravsingh1281 I have resolved the conflict

@Antima2004 not resolved please fix this.

Ok


Calibration needed?

Required Info

Camera Model
D455

Firmware Version
latest

Operating System & Version
Windows 10

SDK Version
latest

Language
C#

I have observed that the depth data has an evenly-spaced linear pattern of zero depth pixels when depth is found for a flat surface.  It is not pronounced in this example so I drew some lines on 3 of the patterns.  The image is straight from the camera - applying the colorizer to the get_depth_frame.  My question: does this pattern of missing depth indicate that my camera calibration is not correct?  I have only 1 D455 camera so I cannot compare it.  The linear pattern is found on any flat surface and will vary in the angle.

Hi @bobdavies2000   I have not seen an effect exactly like this before and was unable to recreate it.  It does not look obviously like a calibration related issue to me.
If the above image is rendered by your C# application, do you see the same lines on a 2D depth view in the RealSense Viewer program, please?

The lines do not appear in the imgui interface in the realsense-viewer so thanks for the tip.


Introduce a feature flag for initial release to allow seamless upgrade experience

Description
Targeted for initial release, this task aims at introducing a feature flag for resource-permission evaluation. This feature flag plugins.security.resource_permissions.enabled should be assumed to be false for this initial version release, and will allow a smoother upgrade experience.

@DarshitChanpura I think instead of this being a binary flag, should this support different modes-

Disabled - do not evaluate resource permissions
Monitor/Permissive - log evaluation results but do not fail requests if resource permissions are lacking
Enabled/enforced - fail requests if resource permission evaluation fails

Monitor/Permissive mode should allow for smoother migration modes for users. Thoughts?

[Triage] Hi @DarshitChanpura, thanks for filing this issue. This looks like it is a subtask for the linked meta so I will mark as triaged.

Closing this in favor of new design which will be released under experimental flag.


KAFKA-16368: Update default linger.ms to 5 for KIP-1030

KAFKA-16368: As part of KIP-1030 we are increasing the default linger.ms to 5ms. System tests updated and behaviour validated manually.

Similar comment as https://github.com/apache/kafka/pull/18106#issuecomment-2529514526. We need to be very explicit about the impact customers can expect on upgrade for this particular config.

@divijvaidya done

These tests are passing locally so I'm not sure whats going on. Will try another rebase to trunk


Consensus fuzzing

Description of the Change
Fuzzing for consensus (SendState endpoint).

Benefits
One more fuzzing-covered endpoint.

Possible Drawbacks
Need CI integration.

Usage Examples or Tests
cmake -DCMAKE_C_COMPILER=/usr/local/opt/llvm/bin/clang -DCMAKE_CXX_COMPILER=/usr/local/opt/llvm/bin/clang++  -DFUZZING=ON ..
make consensus_fuzz

Fix the build please


CI Migrations & vector extension

Describe the bug
Getting an error trying to run migrations the recommended way through Github actions. I recently enabled the vector extension, and seeing the migration fail.
Applying migration<PHONE_NUMBER>1317_embeddings.sql...
Error: ERROR: extension "vector" is not available (SQLSTATE 0A000)
At statement 0: create extension if not exists "vector" with schema "public" version '0.4.0'

To Reproduce

Follow steps here to setup CI based migrations.
Enable the vector extension (or add to your initial migration file the line: create extension if not exists "vector" with schema "public" version '0.4.0';).
Push to github

Expected behavior
It should work, instead the GitHub action fails with the error message posted above
System information

OS: [e.g. macOS, Windows]
Browser (if applies) [e.g. chrome, safari]
Version of supabase-js: [e.g. 6.0.2]
Version of Node.js: [e.g. 10.10.0]

Hi @mosnicholas, the default CLI version installed by this action does not have the latest features. Could you try specifying the latest version instead?
- uses: supabase/setup-cli@v1
  with:
    version: latest


Add Ubuntu SSH remoting tests CI

PR Summary
This PR adds CI for SSH remoting tests for Ubuntu platforms
PR Context
This PR includes basic CI for installing PowerShell and setting up SSH remoting on a Ubuntu platform, then running SSHRemoting tests.
PR Checklist

[x] PR has a meaningful title

Use the present tense and imperative mood when describing your changes

[x] Summarized changes
[x] Make sure all .h, .cpp, .cs, .ps1 and .psm1 files have the correct copyright header
[x] This PR is ready to merge and is not Work in Progress.

If the PR is work in progress, please add the prefix WIP: or [ WIP ] to the beginning of the title (the WIP bot will keep its status check at Pending while the prefix is present) and remove the prefix when the PR is ready.

Breaking changes

[x] None
OR
[ ] Experimental feature(s) needed

[ ] Experimental feature name(s):

User-facing changes

[x] Not Applicable
OR
[ ] Documentation needed

[ ] Issue filed:

Testing - New and feature

[x] N/A or can only be tested interactively
OR
[ ] Make sure you've added a new test if existing tests do not effectively test the code changed

Tooling

[x] I have considered the user experience from a tooling perspective and don't believe tooling will be impacted.
OR
[ ] I have considered the user experience from a tooling perspective and enumerated concerns in the summary. This may include:

Impact on PowerShell Editor Services which is used in the PowerShell extension for VSCode (which runs in a different PS Host).
Impact on Completions (both in the console and in editors) - one of PowerShell's most powerful features.
Impact on PSScriptAnalyzer (which provides linting & formatting in the editor extensions).
Impact on EditorSyntax (which provides syntax highlighting with in VSCode, GitHub, and many other editors).

Removed WIP, as tests are running and passing.

@TravisEz13   Can this PR be merged?

@PoshChan Please remind me in 1 hour

@TravisEz13, this is the reminder you requested 1 hour ago

I setup the new CI build
https://dev.azure.com/powershell/PowerShell/_build?definitionId=85&_a=summary


ViewAnimatorProxy?

Where is ViewAnimatorProxy defined?
Compilation is failing because it can't be found

https://github.com/ryanmcgrath/cacao/blob/d417289f92b5ec13db1608c6e43485f8894b966c/src/view/mod.rs#L65
causes iOS compilation to fail as ViewAnimatorProxy is referred to elsewhere without the corresponding #[cfg(all(feature = "appkit", target_os = "macos"))]
Literally first hour of rust learning so I have no clue whether what I said is right or wrong - nonetheless, compilation for ios fails

Nevermind, the compilation still fails.
For some reason Cargo is trying to link AppKit for iOS?


Template Inheritance

Template inheritance should be there or at least templates should allow embedding other templates within them, this would save a lot of copy paste between similar themes.

Resolved in Logiks 4.0. New template engine not only solves the inheritance and other minor objectives, but also brings together many great features like

Tighter Logiks Integration , now you can use components, contents, widgets, modules right from inside the templates.
Multiple Template Engine includes Smarty. Blade and twig to be introduced really soon. Only one engine can be used per app.
-Better and cleaner integration.


Attaching lora at runtime

Feature request
So suppose for the same base model like Qwen i want to attach multiple lora layers for different tasks.
Number of tasks can be as large as 10 +.
Now if want to perform all these tasks via single A100 GPU, i dont want to load multiple models.
I want to load single base model and attach Lora weights on the fly during runtime to save memory.
I know it will increase latency but that is something i am ok with.
How to achieve this such that GPU memory is taken mostly by base model?
Any help will be appreciated.
Motivation
Low memory environment PEFT.
 It should have one LoRA adapter now. On the PeftModel instance, you can now call add_adapter to add more adapters to the same base model. With set_adapter, you can switch between the different adapters.

@BenjaminBossan  Could you please provide information on the latency of the set_adapter operation after loading multiple adapters compared to loading only one adapter?

Load your first PeftModel as usual. It should have one LoRA adapter now. On the PeftModel instance, you can now call add_adapter to add more adapters to the same base model. With set_adapter, you can switch between the different adapters.

Could you please provide information on the latency of the set_adapter operation after loading multiple adapters compared to loading only one adapter?

Could you elaborate on what you mean? Do you mean how long it takes to call set_adapter? It will depend on the model, but shouldn't be too much (let us know if it is very slow for you). However, if you want to call it very frequently, e.g. because you want to change the adapter for each incoming inference call, this overhead could add up.

Thank you for your insight earlier. I'd like to expand on a specific scenario I'm dealing with. In my setup, a large language model operates with multiple adapters to offer API services, and the selection of the adapter is determined by the incoming request's parameters. My question revolves around the potential latency impact: Is there a significant delay in API response times when switching between adapters in this setup compared to running each adapter on a dedicated language model instance?
From my understanding, set_adapter essentially activates the chosen adapter and iterates through all active adapters during the inference process. In some preliminary tests with a dual-adapter setup, I didn't notice any substantial latency when switching between them. So, I'm leaning towards the conclusion that adapter switching per request doesn't notably impact performance. Would you agree with this assessment? Also, could you clarify what you meant by 'overhead could add up' in this scenario? Thanks again!

Thanks for explaining your use case, this is roughly what I imagined.
I cannot answer for you the question if the switching of adapters will create a significant slowdown or not. It depends on several factors, e.g. how often the adapters are being switched or how large the model is (the larger the model, the more time spent on inference, the less the switching should be noticeable). At the end of the day, you have to measure the performance and decide if it's worth it for you to serve each adapter on a separate instance or use the same instance and switch.
One thing to keep in mind is that if you only serve a single adapter per instance, you can merge_and_unload the model, which should make it slightly smaller and slightly faster. This doesn't work if you want to dynamically switch adapters.
We are currently also working on a solution that would allow to serve multiple adapters at the same time within the same batch: #903. So if batching is a factor to you, keep an eye on that PR (it has been stalled for some time unfortunately).
Otherwise, if you are serving a large number of different adapters at the same time, solutions such as https://github.com/S-LoRA/S-LoRA could be interesting (I haven't tested it personally though).

We are currently also working on a solution that would allow to serve multiple adapters at the same time within the same batch: #903. So if batching is a factor to you, keep an eye on that PR (it has been stalled for some time unfortunately).

We merged #1558, a follow up to https://github.com/huggingface/peft/pull/903. Maybe you can take a look if it could be interesting for your use case.

Hi @BenjaminBossan,
Thank you very much for your detailed explanation. I have a small question regarding the difference between set_adapter and merge_and_unload when loading adapters.
I've noticed that when I load multiple adapters using set_adapter, the GPU memory usage increases only for the LoRA parameters, rather than for the base model + LoRA adapter, however, when I use merge_and_unload to load multiple adapters, the memory usage increases for both the base model and the LoRA adapters.
From this observation, I assume that using set_adapter simply changes the inference method without merging the LoRA parameters into the base model. Is that correct?
Thank you for your clarification!


Version 2.0 API Migration Guide

See #402

I guess some of this will be covered in the changes log, but we might want to mention these here as they are behaviour changes:
Entire paths being created as per https://github.com/cloudant/sync-android/issues/294
No more replication limit as per https://github.com/cloudant/sync-android/issues/462

@brynh @ricellis 5a0f09d should address all of these

@brynh thanks for spotting all those silly typos. 045b700 should address these.


sitemap in 0.4.0  does not work 🤷🏻♂

not sure if i am doing something wrong but, the sitemap does not work in the current 0.4.0 release. inside "config" the whole folder 'options' is missing, meaning the sitemap.php is also missing. the release candidates have the folder and hence everything works fine here.
minor detail which does not bother that much...
the release candidate sitemap does not work on a local environment though, i keep getting syntax errors. i use mamp on mac and codekit. nor the direct localhost url nor codekits autorefresh url work. but again, at least it works live so no biggie.

The sitemap is part of 1.0 so it makes sense that it doesn't work in 0.4.0.


spec canister metadata for dfx interface

The compiler uses --public-metadata <name> to specify accessibility. Inside the canister, we can call the management canister to access the interface, see dfinity-lab/ic-ref#380.

Yeah, I get that, but my question is whether that should apply to all the canisters (actor classes) embedded in the binary or whether we want to be more fine-grained and select different options for different classes.
I guess we could start with the blunt approach and refine in future if needed.


Add better debug for BLE chunking.

Ran into a possible bug with an Android device when using BLE and mdoc
central client mode. The mDL is sending around 16 KiB of response with
a negotiated MTU of 517 meaning that data needs to be chunked into
sizes of MTU - 3 = 514 as per 18013-5.
This change adds debug to make it evident that somehow two bytes of
each write to the Client2Server characteristic are lost
somewhere. On the mDL side we get the following output:
I/GattClient: TRANSPORT: drainWritingQueue false
I/GattClient: TRANSPORT_VERBOSE: Sending chunk with 514 bytes (last=false)
I/GattClient: TRANSPORT: onCharacteristicWrite 0 00000006-a123-48ce-896b-4c76973373e6
[...]
I/GattClient: TRANSPORT_VERBOSE: Sending chunk with 164 bytes (last=true)
I/GattClient: TRANSPORT: onCharacteristicWrite 0 00000006-a123-48ce-896b-4c76973373e6
I/GattClient: TRANSPORT: drainWritingQueue false
however on the mDL reader side we get the following
I/GattServer: TRANSPORT_VERBOSE: Received chunk with 512 bytes (last=false), incomingMessage.length=1022
I/VerificationHelper: INFO: reportError: error: java.lang.Error: Invalid size 512 of data written Client2Server characteristic, expected size 514
indicating that only 512 bytes are received. On other Android devices,
514 bytes are received as is expected. This only happens on this
particular Android device with a specific version of the OS. Next step
is to investigate if this is an OS or lower-level bug.
Also add code to report an error if a non-final chunk isn't the MTU
size less 3, as required by 18013-5.
Bug: None
Tests: Manually tested that presentations work.
Fixes #<issue_number_goes_here>

It's a good idea to open an issue first for discussion.

[ ] Tests pass
[ ] Appropriate changes to README are included in PR

See PR #110 for the MTU size change and what I had here.


Integration testing

This change is

.github/workflows/ci.yml line 35 at r4 (raw file):

        run: sudo mkdir -p /var/lib/serval && sudo chmod 777 /var/lib/serval
      - name: Test
        run: dotnet test --no-build --verbosity normal --filter "TestCategory=Integration" -c Release

I am assuming that we should run all tests - including unit tests - and E2E tests with docker-compose.  How is this done here?

.github/workflows/missing-services-e2e-tests.yml line 3 at r4 (raw file):

name: "Missing services E2E tests"

on:

This file looks like it was for debugging and can be deleted now.  Is that correct?

.github/workflows/ci.yml line 35 at r4 (raw file):

        run: sudo mkdir -p /var/lib/serval && sudo chmod 777 /var/lib/serval
      - name: Test
        run: dotnet test --no-build --verbosity normal --filter "TestCategory=Integration" -c Release

I am assuming that we should run all tests - including unit tests - and E2E tests with docker-compose. How is this done here?

The E2E tests are run in a separate workflow - ci-e2e.yml - but yes, I do need to change the filters so the unit tests will run. I changed it to accommodate the missing services E2E tests which are also E2E tests.

src/Serval.Shared/Controllers/ServiceUnavailableExceptionFilter.cs line 20 at r4 (raw file):

            _logger.Log(
                LogLevel.Error,
                "A user tried to accesss an unavailable service. See health-check logs for more details."

access - not accesss

src/Serval.Shared/Controllers/ServiceUnavailableExceptionFilter.cs line 16 at r4 (raw file):

    public override void OnException(ExceptionContext context)
    {
        if (context.Exception is System.TimeoutException or Grpc.Core.RpcException)

Why these two exceptions?  Instead, could there be a try/catch around connecting to grpc and then throw a custom exception?  I am concerned that other things that are not ServiceUnavailable could actually trigger this, such as a locked process, etc.

src/Serval.Shared/Controllers/ServiceUnavailableExceptionFilter.cs line 16 at r4 (raw file):

    public override void OnException(ExceptionContext context)
    {
        if (context.Exception is System.TimeoutException or Grpc.Core.RpcException)

Why these two exceptions? Instead, could there be a try/catch around connecting to grpc and then throw a custom exception? I am concerned that other things that are not ServiceUnavailable could actually trigger this, such as a locked process, etc.

I added some logic (mimicking what we have elsewhere in the NotSupportedExceptionFilter) to verify that it is the 'Unavailable' gRPC error specifically. As for the System.Timeout, I can't say precisely if another service might cause an issue. Partly, I chose this strategy because there were many places (as I recall) that the service could could disappear and cause a function to throw this error - and honestly, I'm not sure how you'd even identify all of those possible places because of the extremely accurate timing that would be needed to test a failure throughout the pipeline across the entire service. On the flip side, as you say, it's difficult to know what other functions might throw this same exception under some circumstances. I am comforted that all tests are passing which means that, minimally, under normal conditions, this filter does not unintentionally intercept any exceptions that would cause a malfunction in the code. But I may be misremembering the amount of effort that would be required to address this properly, and I'm happy to re-devote time to a deeper dive here if you'd like! It would certainly be cleaner if a custom exception were thrown.

src/Serval.Shared/Controllers/ServiceUnavailableExceptionFilter.cs line 16 at r4 (raw file):
Previously, Enkidu93 wrote…
I added some logic (mimicking what we have elsewhere in the NotSupportedExceptionFilter) to verify that it is the 'Unavailable' gRPC error specifically. As for the System.Timeout, I can't say precisely if another service might cause an issue. Partly, I chose this strategy because there were many places (as I recall) that the service could could disappear and cause a function to throw this error - and honestly, I'm not sure how you'd even identify all of those possible places because of the extremely accurate timing that would be needed to test a failure throughout the pipeline across the entire service. On the flip side, as you say, it's difficult to know what other functions might throw this same exception under some circumstances. I am comforted that all tests are passing which means that, minimally, under normal conditions, this filter does not unintentionally intercept any exceptions that would cause a malfunction in the code. But I may be misremembering the amount of effort that would be required to address this properly, and I'm happy to re-devote time to a deeper dive here if you'd like! It would certainly be cleaner if a custom exception were thrown.

Let's at least log the exception too.  That would help us debug the logs better.

src/Serval.Shared/Controllers/ServiceUnavailableExceptionFilter.cs line 20 at r4 (raw file):
Previously, johnml1135 (John Lambert) wrote…
access - not accesss

Done.

.github/workflows/ci.yml line 35 at r4 (raw file):
Previously, johnml1135 (John Lambert) wrote…
I'll make a "Unit" test category.

Your change is better.

src/Serval.Translation/Controllers/TranslationEnginesController.cs line 143 at r6 (raw file):
Previously, johnml1135 (John Lambert) wrote…
Added documentation around this.

Done.

src/Serval.Shared/Controllers/ServiceUnavailableExceptionFilter.cs line 16 at r4 (raw file):
Previously, Enkidu93 wrote…
Let's at least log the exception too. That would help us debug the logs better.

Would you still like me to make this change? Just directly to main?

I really wanted to review this PR, since it makes major changes to the design of many components. Please do not merge any more major changes without my review.

I really wanted to review this PR, since it makes major changes to the design of many components. Please do not merge any more major changes without my review.

I'm so sorry, Damien. I didn't mean to step on any toes if I did. Hope you've settled in well! Please do criticize retrospectively.

src/Serval.Shared/Utils/AutoToString.cs line 3 at r7 (raw file):

namespace Serval.Shared.Utils;

public static class AutoToString

Is this class used anywhere?

Yes, it is - only a couple times in the tests though in error messages. As in Machine, I was mainly using it for debugging because none of the classes had ToString() methods. I can remove it if you'd prefer and do something more tailored in those particular error messages. I'm sure I'll use it again, but I can always reinject it as needed or just tell git to ignore it.
I think the other questions you mentioned regard John's code.

src/Serval.Client/ServalClientHelper.cs line 108 at r7 (raw file):
Previously, ddaspit (Damien Daspit) wrote…
This method name should be more readable and not include implementation details, such as the HTTP method used.

AddTextCorpusToEngine.

src/Serval.Client/ServalClientHelper.cs line 160 at r7 (raw file):
Previously, ddaspit (Damien Daspit) wrote…
This method name should be more readable and not include implementation details, such as the HTTP method used.

UploadFiles.

src/Serval.DataFiles/Models/DataFile.cs line 5 at r7 (raw file):
Previously, ddaspit (Damien Daspit) wrote…
This is a leaky encapsulation and ties the entities to a particular implementation. These attributes should be applied using a convention.

https://github.com/sillsdev/serval/issues/42 - and https://stackoverflow.com/questions/38871416/difference-between-decorating-a-property-in-c-sharp-with-bsonrepresentationbson.
These were to address specific issues in the casting of different string comparisons to not work correctly.  Specifically the filtering by ID was working incorrectly.  This also was addressed by using LinqProvider.V2.

src/SIL.DataAccess/IRepository.cs line 15 at r7 (raw file):
Previously, ddaspit (Damien Daspit) wrote…
Why did you remove the ability to upsert?

It was causing numerous errors - related to: https://github.com/sillsdev/serval/issues/36

src/SIL.DataAccess/IServiceCollectionExtensions.cs line 35 at r7 (raw file):
Previously, ddaspit (Damien Daspit) wrote…
Why was this necessary?

Because of this: https://github.com/sillsdev/serval/issues/41.  It was the only solution that worked after a lot of debugging.

src/SIL.DataAccess/MemoryRepository.cs line 120 at r7 (raw file):
Previously, ddaspit (Damien Daspit) wrote…
Why was this behavior removed? This diverges the behavior from the MongoRepository implementation.

All Id's are created at the controller level now.  That makes it more consistent and cleaner.  It is related to the upsert issue.


[Bug] Terminal Colors not reset after application exists

Bug reports
Please file a bug report here.
Expected Behavior
When go-prompt application is terminated (ctrl^D), terminal color's need to be reset.
Current Behavior and Steps to Reproduce
After exiting go-prompt application (ex: simple-echo), the terminal & shell (mac terminal, iterm2, ubuntu bash) are in a state where you cannot see any characters being typed. Restarting the shell resolved the issue, until the next time you run the go-prompt application:
`vagrant@dev:~/host_user_homedir/go-workspace/src/go-prompt/_example/simple-echo$ go run main.go

users
Your input: users
vagrant@dev:~/host_user_homedir/go-workspace/src/go-prompt/_example/simple-echo$ ddddddd: command not found
`

https://user-images.githubusercontent.com/577870/196228129-16339375-7b4f-4499-8cd7-e152257ad35d.mov
Context
Mac 11.7 with iTerm2 and terminal
Ubuntu 20.04 with default bash shell

This looks like a dup of https://github.com/c-bata/go-prompt/issues/228

或者在程序执行os.Exit()前执行
cmd := exec.Command("reset")
err := cmd.Run()


COM-28 introduce new biggive-main-menu to replace biggive-header

Currently biggive-header has a few issues:

No real support for sub-sub-menus, i.e. sub-menus two levels deep
Mobile menu doesn't scroll properly
The whole website scrolls down when you try to scroll down the menu
Big blue call-to-action buttons in mobile version of the header cover much of the menu, especially when sub-menus are expanded
No caret icons to show the certain menu items are expandable
Clicking on a sub-menu item opens the sub-menu, but re-clicking the same sub-menu item does not close the sub-menu - you have to click elsewhere.

This will all be fixed as part of a new biggive-main-menu component.

@alihejazi I've looked through and added comments anywhere I could see possible room for improvement, I can't claim to have understood every line in detail. Maybe we can discuss briefly tomorrow.


Include license in strings

One of the nice things about tini is it is so nice to install. Merely download the executable and one is good to go.
However, there is a fair point that the license file should be included to. In order to keep things simple, would it be possible (or even reasonable) to have the license reproduced as a string in the final binary (e.g. visible via strings). This should be pretty easy to do. Just wondering if this would be ok.

@jakirkham I think this makes a lot of sense. Thanks for bringing this to my attention. I hadn't realized my license was asking users to redistribute it while my instructions were inviting them not to..!
Can you check https://github.com/krallin/tini/pull/47 (and specifically the one commit in there that adds the license) and let me know whether you feel that would work for you?

For the sake of clarity; the output's going to look like this:
root@784c7c2ea28e:/# tini
tini (version 0.9.0 - git.203835d-dirty)
Usage: tini [OPTIONS] PROGRAM -- [ARGS]

Execute a program under the supervision of a valid init process (tini)

  -h: Show this help message and exit.
  -s: Register as a process subreaper (requires Linux >= 3.4).
  -v: Generate more verbose output. Repeat up to 3 times.
  -g: Send signals to the child's process group.
  -l: Show license and exit.

root@784c7c2ea28e:/# tini -l
The MIT License (MIT)

Copyright (c) 2015 Thomas Orozco<EMAIL_ADDRESS>
Permission is hereby granted, free of charge, to any person obtaining a copy
of this software and associated documentation files (the "Software"), to deal
in the Software without restriction, including without limitation the rights
to use, copy, modify, merge, publish, distribute, sublicense, and/or sell
copies of the Software, and to permit persons to whom the Software is
furnished to do so, subject to the following conditions:

The above copyright notice and this permission notice shall be included in
all copies or substantial portions of the Software.

 IN NO EVENT SHALL THE
AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM,
OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN
THE SOFTWARE.

This is a nicer proposal then even the one I had in mind. Though this definitely seems like the right way to go. Thanks for coming up with this @krallin.

Closed in #47


Correctly configuring vue-router for use with ream

There should be in the documentation a mention of how to configure vue-router correctly.
@jnv found out that you have to use the history mode. See https://github.com/cvut/fittable-next/commit/8444947b510d9bf67997b697abaeaf14478ab9b7#diff-15ee858ae5d5aa9b3e2846cfd1c4c466
Without the fix it's not possible to match server-rendered content on client.

Ah yes, I should mention this in the docs, and it's recommend to always use () => import('./path/to/view.vue') for code-split

Doc has been updated for this. https://ream.github.io/ream/#/?id=router-instance


RuntimeError: Unable to create link (name already exists) during model saving with ModelCheckpoint

System information

Have I written custom code (as opposed to using a stock example script provided in TensorFlow): Yes
OS Platform and Distribution (e.g., Linux Ubuntu 16.04): Arch Linux
Mobile device (e.g. iPhone 8, Pixel 2, Samsung Galaxy) if the issue happens on mobile device: No
TensorFlow installed from (source or binary): TF 2.0 downloaded from repo
TensorFlow version (use command below):
tf-nightly-gpu-2.0-preview --> 2.0.0.dev20190314
tensorflow-hub  --> 0.4.0
Python version: 3.6
CUDA/cuDNN version: CUDA Version 10.0.130/ cuDNN 7.5.0
GPU model and memory: Nvidia RTX 2080 Ti 11GB (and GTX 1060 6GB)

Describe the current behavior
I've downloaded an inception model from TF-Hub (specifically this one: https://tfhub.dev/google/tf2-preview/inception_v3/feature_vector/2), I have added to it two Keras layers (a Dropout layer and a Dense layer) and during the training, I'm trying to save the model using the ModelCheckpoint Keras callback. Unfortunately, after one epoch and during the model saving I receive the following error:
Traceback (most recent call last):
  File "/run/media/federico/XData/virtualenvs/python36_tf2preview/lib/python3.6/site-packages/IPython/core/interactiveshell.py", line 3291, in run_code
    exec(code_obj, self.user_global_ns, self.user_ns)
  File "<ipython-input-2-3945e7fb8367>", line 1, in <module>
    runfile('/run/media/federico/XData/PycharmProjectsXData/ash/ash/prova_gan_plain_test.py', wdir='/run/media/federico/XData/PycharmProjectsXData/ash/ash')
  File "/opt/pycharm-professional/helpers/pydev/_pydev_bundle/pydev_umd.py", line 197, in runfile
    pydev_imports.execfile(filename, global_vars, local_vars)  # execute the script
  File "/opt/pycharm-professional/helpers/pydev/_pydev_imps/_pydev_execfile.py", line 18, in execfile
    exec(compile(contents+"\n", file, 'exec'), glob, loc)
  File "/run/media/federico/XData/PycharmProjectsXData/ash/ash/prova_gan_plain_test.py", line 98, in <module>
    main()
  File "/run/media/federico/XData/PycharmProjectsXData/ash/ash/prova_gan_plain_test.py", line 90, in main
    logdir,
  File "/run/media/federico/XData/PycharmProjectsXData/ash/ash/testers/gan_plain.py", line 85, in __init__
    self._model = self._download_and_train_model()
  File "/run/media/federico/XData/PycharmProjectsXData/ash/ash/testers/gan_plain.py", line 255, in _download_and_train_model
    callbacks=[cback_checkpoint],
  File "/run/media/federico/XData/virtualenvs/python36_tf2preview/lib/python3.6/site-packages/tensorflow/python/keras/engine/training.py", line 1508, in fit_generator
    steps_name='steps_per_epoch')
  File "/run/media/federico/XData/virtualenvs/python36_tf2preview/lib/python3.6/site-packages/tensorflow/python/keras/engine/training_generator.py", line 324, in model_iteration
    callbacks.on_epoch_end(epoch, epoch_logs)
  File "/run/media/federico/XData/virtualenvs/python36_tf2preview/lib/python3.6/site-packages/tensorflow/python/keras/callbacks.py", line 290, in on_epoch_end
    callback.on_epoch_end(epoch, logs)
  File "/run/media/federico/XData/virtualenvs/python36_tf2preview/lib/python3.6/site-packages/tensorflow/python/keras/callbacks.py", line 892, in on_epoch_end
    self.model.save_weights(filepath, overwrite=True)
  File "/run/media/federico/XData/virtualenvs/python36_tf2preview/lib/python3.6/site-packages/tensorflow/python/keras/engine/network.py", line 1395, in save_weights
    hdf5_format.save_weights_to_hdf5_group(f, self.layers)
  File "/run/media/federico/XData/virtualenvs/python36_tf2preview/lib/python3.6/site-packages/tensorflow/python/keras/saving/hdf5_format.py", line 693, in save_weights_to_hdf5_group
    param_dset = g.create_dataset(name, val.shape, dtype=val.dtype)
  File "/run/media/federico/XData/virtualenvs/python36_tf2preview/lib/python3.6/site-packages/h5py/_hl/group.py", line 139, in create_dataset
    self[name] = dset
  File "/run/media/federico/XData/virtualenvs/python36_tf2preview/lib/python3.6/site-packages/h5py/_hl/group.py", line 371, in __setitem__
    h5o.link(obj.id, self.id, name, lcpl=lcpl, lapl=self._lapl)
  File "h5py/_objects.pyx", line 54, in h5py._objects.with_phil.wrapper
  File "h5py/_objects.pyx", line 55, in h5py._objects.with_phil.wrapper
  File "h5py/h5o.pyx", line 202, in h5py.h5o.link
RuntimeError: Unable to create link (name already exists)

Highlighting the error: RuntimeError: Unable to create link (name already exists)
Describe the expected behavior
I'm expecting to be able to use the ModelCheckpoint callback to save the (best) model.
Alternatively, I'm also expecting to be able to save the model with the model.save(filepath) function.
Code to reproduce the issue
You could reproduce the error on the following TF-Hub Colab page: https://colab.research.google.com/github/tensorflow/hub/blob/master/examples/colab/tf2_image_retraining.ipynb#scrollTo=CCpdfXPsh47Q
adding a cell with the ModelCheckpoint code
cback_checkpoint = tf.keras.callbacks.ModelCheckpoint(
            filepath="best.h5",
            verbose=1,
            save_best_only=True,
        )

and then adding the callback to the fit_generator function of the model:
steps_per_epoch = train_generator.samples // train_generator.batch_size
validation_steps = valid_generator.samples // valid_generator.batch_size
hist = model.fit_generator(
    train_generator,
    epochs=5, steps_per_epoch=steps_per_epoch,
    validation_data=valid_generator,
    validation_steps=validation_steps,
    callbacks=[cback_checkpoint]).history

Other info / logs
I've found some issues online regarding a similar problem like this and issues: #5280, #6844 and the more recent #26811. Many of them speak about some problem regarding the naming of the layers (or weights) or about creating the ModelCheckpoint with save_best_only=True or save_weights_only=True. I have tried all the proposed approaches but without success.
Even with model.save(filepath) Keras function I face the same problem.
EDIT: Please follow this Colab link to have all the code set up to be reproduced.

@iLeW When I try to run the google colab that you have provided, unfortunately I did not get any error. Thanks!

@gadagashwini I have just tried again, and it gives me the same error:
h5py/_objects.pyx in h5py._objects.with_phil.wrapper()

h5py/_objects.pyx in h5py._objects.with_phil.wrapper()

h5py/h5o.pyx in h5py.h5o.link()

RuntimeError: Unable to create link (name already exists)

Have you added, before running it, the line of code as indicated in my post? For your convenience, I filled out the Colab for you. You can find it at this link with the necessary changes (i.e.: the callback added to the model). Please try to run this configuration. It should give you the same RuntimeError error.

I am having the same problem at #27909. I suspect this is a problem related to h5py/hdf5 because internally the traceback suggests the error happened when trying to save the model using the library. Also to note the keras already set overwrite=True, so the error should not happen.
I am using hdf5==1.10.4 and h5py=2.9.0. I suspect there is problem with the library.

The same problem happened to me, Tensorflow2.0, Cuda:10.0, Python3.6.8.

I also encountered the same problem.
Tensorflow:2.0.0a0
Cuda:10.0
Python:3.6.8
IDE:Jupyter  NoteBook

I also encountered the same problem.
Tensorflow:2.0.0a0
Cuda:10.0
Python:3.6.8
IDE:Jupyter  NoteBook

Thanks for the report. Confirming I can repro. Feel free to add more information while we're looking into it.

The crash of Model.save() when using hub.KerasLayer likely needs to be fixed in tensorflow-hub, not tensorflow. I've filed issue tensorflow/hub#287 for that.
Can this issue here be closed then?

The crash of Model.save() when using hub.KerasLayer likely needs to be fixed in tensorflow-hub, not tensorflow. I've filed issue tensorflow/hub#287 for that.
Can this issue here be closed then?

Sounds good - thanks arnoegw@! Let's follow up in tensorflow/hub#287 for this issue.

FYI - issue https://github.com/tensorflow/hub/issues/287 has been solved (upgrade Hub module version to /3).

FYI - issue tensorflow/hub#287 has been solved (upgrade Hub module version to /3).

Thanks for the updates!

I also encountered the same problem. Note it only occurs with eager execution enabled.
Tensorflow:1.13.1
Python:3.6.8 Anaconda Inc.
IDE:Jupyter NoteBook

For the error with eager execution, make sure you're using OptimizerV2 from here: https://github.com/tensorflow/tensorflow/tree/master/tensorflow/python/keras/optimizer_v2. The optimizers in https://github.com/tensorflow/tensorflow/blob/master/tensorflow/python/keras/optimizers.py don't inherit from Trackable so the variables aren't named correctly.

@ppham27 I can save keras model in tensorflow-gpu-1.13 fine until I trigger tf.enable_eager_execution() that is when I cannot save the model. When I call model.save(path) the Unable to create link error immediately occurs if eager execution is enabled. If I set include_optimizer to False then it will let me save.
I see that it's related to the optimizer somehow like you mentioned in your comment. So I tried importing the Adam optimizer from tensorflow.python.keras.optimizer_v2.adam.Adam and it works like a charm! So thank you for the advice.

Hi @off99555,
Sorry, can't seem to figure out why that would be occurring without more code.
We have at least one test in the test suite that saves the model with an optimizer: https://github.com/tensorflow/tensorflow/blob/3cb03d093610e51cf2d36bfbf43c446a5de52941/tensorflow/python/keras/saving/hdf5_format_test.py#L810-L811
I changed the line SGD to Adam and the test still passes. Maybe try upgrading to a later version of Tensorflow?

It seems to be a version issue. I tested with tensorflow2.0 and there is no problem (because there is no tf.enable_eager_execution()). I cannot upgrade the version easily considering that I followed this installation guide that only has version 1.13 as the latest from conda: https://www.pugetsystems.com/labs/hpc/The-Best-Way-to-Install-TensorFlow-with-GPU-Support-on-Windows-10-Without-Installing-CUDA-1187/
Here is the exact code I used to reproduce the error
import tensorflow as tf   # only work from tensorflow==1.9.0-rc1 and after
tf.enable_eager_execution()
from tensorflow.python.keras.optimizer_v2.adam import Adam

def keras_model():
    from tensorflow.keras.layers import Conv2D, MaxPool2D, Flatten, Dense, Dropout, Input

    inputs = Input(shape=(28, 28, 1))
    x = Conv2D(32, (3, 3),activation='relu', padding='valid')(inputs)
    x = MaxPool2D(pool_size=(2, 2))(x)
    x = Conv2D(64, (3, 3), activation='relu')(x)
    x = MaxPool2D(pool_size=(2, 2))(x)
    x = Flatten()(x)
    x = Dense(512, activation='relu')(x)
    x = Dropout(0.5)(x)
    outputs = Dense(10, activation='softmax')(x)

    return tf.keras.Model(inputs, outputs)

model = keras_model()
model.compile(Adam(), 'categorical_crossentropy', metrics=['acc'])
model.save('mnist.h5')
model2 = tf.keras.models.load_model('mnist.h5') # it will raise TypeError: Unexpected keyword argument passed to optimizer: name

Hmm, there appears to be a mismatch in the optimizer being loaded. Really, my advice would be to upgrade to at least TF1.14, but it might work passing in custom_objects={'adam': Adam} as a keyword argument into tf.keras.models.load_model.
Or putting this at the top of your program:
import os

os.environ['TF2_BEHAVIOR'] = '1'

That trick about custom_objects seem to work!
I changed the loading code to model2 = tf.keras.models.load_model('mnist.h5', custom_objects=dict(adam=Adam)) and it is able to load using Adam v2 optimizer.

I was using a TF.Hub model based on this tutorial https://www.tensorflow.org/tutorials/images/hub_with_keras  and change the TF hub model from version 2 to 4.
and now works for me:
https://tfhub.dev/google/tf2-preview/mobilenet_v2/feature_vector/4

WORKING SOLUTION:

Go to: Miniconda3\Lib\site-packages or wherever h5py is installed.
Delete h5py Folder
Delete h5py-2.10.0.dist-info Folder (This might be different if you have a different 4. version).
Install h5py again.

It worked for me after a long search. Finally, I tried to delete it manually and reinstall it. IT WORKED!!!!!
By uninstalling them using cmd, pip, anaconda Some files might be stuck and will cause errors even after installing a different version.

I got the same error in Tensorflow 2.1 when calling save_weigths("model.h5", overwrite=True).
None of the above mentioned fixes worked for me (I am not using hub and optimizer is passed as SGD(...)).
Are there any other solutions to this?

The reason why it didn't work was because I had the same namestrings for all the weights in my custom keras layers.
Lesson: If you make keras layers, give them different name strings!

I get the same problem when I enable eager execution, without it everything works fine

I also encountered the same problem. Note it only occurs with eager execution enabled.
Tensorflow:1.13.1
Python:3.6.8 Anaconda Inc.
IDE:Jupyter NoteBook
I was able to solve the .save error with the following snippet. Is this a good idea?
from tensorflow.python.keras import backend as K

with K.name_scope(model.optimizer.__class__.__name__):
    for i, var in enumerate(model.optimizer.weights):
        name = 'variable{}'.format(i)
        model.optimizer.weights[i] = tf.Variable(var, name=name)

I've been trying to resolve this issue since past few hours. Thank you for saving me!

You can also face this problem in case of no-unique 'group' part of name in case of using multi-input models with transfer learning (for example - several MobileNet at input).
Wrote this code, it helped (summary, with changing other meta, such as model name and layer names):
import uuid
def unique_name():
    return uuid.uuid4().hex.upper()[0:10]

def postprocess_weight_name(name):
    group, name = name.split('/')
    return f'{group}{unique_name()}/{name}'
    print((group, name))

model._name = model._name + unique_name()

for layer in model.layers:
    layer._name = layer._name + unique_name()

for i in range(len(model.weights)):
    model.weights[i]._handle_name = postprocess_weight_name(model.weights[i].name)

如果使用具有迁移学习的多输入模型（例如 - 输入中的多个 MobileNet），_在权重_中没有唯一的“组”部分名称的情况下，您也可能会遇到此问题。
编写此代码，它有所帮助（总结，更改其他元，例如模型名称和层名称）：
import uuid
def unique_name():
    return uuid.uuid4().hex.upper()[0:10]

def postprocess_weight_name(name):
    group, name = name.split('/')
    return f'{group}{unique_name()}/{name}'
    print((group, name))

model._name = model._name + unique_name()

for layer in model.layers:
    layer._name = layer._name + unique_name()

for i in range(len(model.weights)):
    model.weights[i]._handle_name = postprocess_weight_name(model.weights[i].name)

It works in my code. Thanks a lot!


Could not find a declaration file for module 'circletype'

In README.md you wrote:
import CircleType from `circletype`;

But there are no types for this module.
error TS7016: Could not find a declaration file for module 'circletype'
Try `npm install @types/circletype` if it exists or add a new declaration (.d.ts) file containing `declare module 'circletype';`

So its not as easy as install & use.

This is a JavaScript library. I’m not sure what’s needed to make it work with TypeScript. Good luck.

This may be helpful.
declare module 'circletype' {
    export interface CircleTypeOptions {
        radius?: number;
        dir?: number;
        forceWidth?: boolean;
        forceHeight?: boolean;
    }

    export default class CircleType {
        constructor(element: HTMLElement, options?: CircleTypeOptions);
        radius(radius: number): this;
        dir(dir: number): this;
        forceWidth(force: boolean): this;
        forceHeight(force: boolean): this;
        refresh(): void;
        destroy(): void;
    }
}


respect multiple remarks

Multiple remarks have been concatenated without even a space. To fix this, this PR changes the XSLT to handle each paragraph in the remarks separately.
Before

After

@music-encoding/core-contributors One more review and then merge.

You can also merge, @kepper

Thank you!


Delete files from blob storage

Fixes https://github.com/Azure-Samples/chat-with-your-data-solution-accelerator/issues/448

I think I'm going to hold off on this for now. Quite a few moving parts and more involved then anticipated for a quick win!


add token auth  [do not merge]

Check that user and token cannot be specified in same time does not work in our scripts (genestack-application-manager), will fix it in separate PR.

So i checked only common logic.

Thank you, I have fixed/commented all your comments, and will remove review request.

And one more question: do we need to describe this changes in ChangeLog?

And one more question: do we need to describe this changes in ChangeLog?

Yes, done.

Do we want to add API token support to __interactive_login?

I have made inception_master branch and squash all commits into it.    Will close this PR after create new to fix  comment about __interactive_login


A suddenly error!

Hi there!
recently I has found a error with run protractor.
the files in dir-specs run test ok one by one ,but if it works like below will wrong.
protractor-config.js
exports.config={
specs:[
'e2e/testjs/*.js'
]
}
in the case,when the file which name start with 'T' will stop and page does not close utill I rename the filename does not inclue 'T' letter.

Node Version: 4.2.6
Protractor Version: 1.0.0
Browser(s): Chrome
Operating System and Version Windows_NT 6.1.7601
Your protractor configuration file
A relevant example test
Output from running the test
Steps to reproduce the bug
The URL you are running your tests against (if relevant)

Feature Request
for replay

[chrome #2] PID: 34348
[chrome #2] (node) util.puts is deprecated. Use console.log instead.
[chrome #2] Starting selenium standalone server...
[chrome #2] Selenium standalone server started at http://<IP_ADDRESS>:4467/wd/hub
[chrome #2] .........F.F.........TypeError: first._onTimeout is not a function
[chrome #2]     at Timer.listOnTimeout (timers.js:92:15)

[chrome #2] PID: 34348
[chrome #2] (node) util.puts is deprecated. Use console.log instead.
[chrome #2] Starting selenium standalone server...
[chrome #2] Selenium standalone server started at http://<IP_ADDRESS>:4467/wd/hub
[chrome #2] .........F.F.........TypeError: first._onTimeout is not a function
[chrome #2]     at Timer.listOnTimeout (timers.js:92:15)

Please direct general support questions like this one to an appropriate support channel, see https://github.com/angular/protractor/blob/master/CONTRIBUTING.md#questions
Thank you!


Add --with-registry-auth for stack deploy

- What I did
Add the option “--with-registry-auth”  for stack deploy
- How I did it
- How to verify it
- Description for the changelog
Signed-off-by: yuexiao-wang<EMAIL_ADDRESS>

LGTM


Make motions live

Make motions live
Fix #418
Fix #419
Fix #465
Fix #507
Fix #508
Fix #539
Update #5
Update #6
Update #303
In this PR, I have:

[X] Manually tested to ensure my PR is working
[X] Ensured issues that this PR closes will be automatically closed
[X] Requested review from Mia or Quinten
[X] Ensured automated tests are passing
[ ] Updated automated tests so they are now passing
[ ] There were no automated tests on this repo so I filled out this interview and there is now an "it runs" test

Thank you @tobyfey. I really appreciate your thorough review.


python311Packages.pyvlx: 0.2.20 -> 0.2.21

Diff: https://github.com/Julius2342/pyvlx/compare/pyvlx...0.2.21
Changelog: https://github.com/Julius2342/pyvlx/releases/tag/0.2.21
Description of changes

Things done

Built on platform(s)

[ ] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)

[ ] sandbox = relaxed
[ ] sandbox = true

[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
24.05 Release Notes (or backporting 23.05 and 23.11 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[ ] Fits CONTRIBUTING.md.

Add a :+1: reaction to pull requests you find important.

Result of nixpkgs-review pr 274700 run on x86_64-linux 1

4 packages built:

python310Packages.pyvlx
python310Packages.pyvlx.dist
python311Packages.pyvlx
python311Packages.pyvlx.dist


Download gb by taxid

New Features
Add capability for Genbank downloads

Not clear to me how to associate the files with the DD though.

Right, let’s reject both (all) of these PRs, my understanding of what the code is supposed to do is better now.

On Apr 20, 2020, at 1:44 PM, Andrew Prokhorenkov<EMAIL_ADDRESS>wrote:
@m0nhawk commented on this pull request.
In covid19-etl/etl/download_gb_by_taxid.yaml https://github.com/uc-cdis/covid19-tools/pull/11#discussion_r411569765:

@@ -0,0 +1,11 @@
+---
+taxid: 694009
+email<EMAIL_ADDRESS>I saw another PR from the fork repository, but now it looks like removed (the fork), so I closed that PR. But it has the same changes. #12 https://github.com/uc-cdis/covid19-tools/pull/12
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub https://github.com/uc-cdis/covid19-tools/pull/11#discussion_r411569765, or unsubscribe https://github.com/notifications/unsubscribe-auth/AACD35GKXHKZERORGXEFTL3RNSCY7ANCNFSM4MDSWSYQ.


Request for self contained executable of the app for including in the container image for debugging

Thanks for the wonderful tool , it would great if self contained executable is available that can be included in container image for debugging. This is especially useful in debugging apps deployed in Kubernetes .
I can also create self contained app by forking the your repo, but I though it would be useful to be available in the main repo.

Thank you for the nice words and the suggestion. I will update the deployment very soon.

It is possible to add custom event source names from the command line so that we can see logs emitted by these sources .
For example we are using .NET Open Telemetry SDK, that emits logs with follow event source, it would be good we can pass this from command line for debugging.

"OpenTelemetry-Sdk",
"OpenTelemetry-Api",
"OpenTelemetry-Extensions-Hosting",
"OpenTelemetry-Instrumentation-Grpc",
"OpenTelemetry-Instrumentation-Http",
"OpenTelemetry.Extensions.Propagators"

Here is the Source code that emits https://github.com/search?q=repo%3Aopen-telemetry%2Fopentelemetry-dotnet+EventSource&type=code

It is possible, but would require a significant amount of work. Dotnet-wtrace supports only a limited number of events and adds rules to nicely print them.  That required a predefined event models. The providers that you listed use their own schemas and their own event format. To support them, you either need to add generic events support to dotnet-wtrace (but that could make the output less readable) or add handlers for all those specific events (a lot of work).

I updated the latest release with the new binaries. The zip files contain only executables and symbol files (not needed for running). For the second request, unfortunately, I don't have much time to work on it. But it is an interesting request and I will give it some thought in the future. Thanks.

It is possible, but would require a significant amount of work. Dotnet-wtrace supports only a limited number of events and adds rules to nicely print them.  That required a predefined event models. The providers that you listed use their own schemas and their own event format. To support them, you either need to add generic events support to dotnet-wtrace (but that could make the output less readable) or add handlers for all those specific events (a lot of work).

I understand  predefined events with their  color scheme is really nice and easy to decipher source of the events. For all others types as you suggested generic model might help.


Enforcing standards, eg repo standards

Approach:

Define list of standards to be applied to repos (some of this stuff we already know).

https://ministryofjustice.github.io/technical-guidance/documentation/standards/licencing-software-or-code.html#licensing-software-or-code
Default should be called "Main"
Branch Protection for Main
Code Formatter Github action applied
If there are releases, does the README.md have a release badge?

Ensure that these standards are in the MoJ Technical Guidance

Automate checks and report on variations from the the standards

Display results in the OpsEng Reports app.

Questions:

Can we build checks using just Github actions? (to limit the need to run any infrastructure to do this)

Assumptions:

We will only apply this to Public repos

Definition of Done:

Standards are documented for users
Monitoring in place to detect variation from standards
Communication to users
Agreed process for how to alert teams to changes required to comply with standard.

Added a "definition of done". Approved for backlog

There's an initial stab at this here, with the code that generates the report in this repo
There's a lot I'd change if I had more time, but it's a start.


Mark c0-authorized loads and stores as extensible

Say explicitly that c0-authorized load/store instructions, which are guaranteed to trap regardless of other operands' values, are available for use by future extensions.

Why? They’re not for the base ISA.

They stand a chance of working in the base ISA, if there's memory near 0.

@nwf is pointing out that if the auth cap is c0 you definitely get a tag violation, allowing future extensions to redefine that case, as oppose to it having to be a tag violation for all time.
Do we need to cal this out explicitly? I suppose we do to prevent it always being a tag violation.

@arichardson Yeah, I agree that in some sense "illegal instruction" is "better" than "CHERI tag violation" if the intent is to allow the instruction to be repurposed (and yes, indeed), but I don't think we need to mandate that complexity in the decoder.  It's perfectly fine, IMHO, for a Zcheripurecap core to really try operating on the NULL cap here while also allowing extensions to operate on something else (by way of concrete examples, perhaps, DDC like we did back in CHERI-RISC-V or the Zstid *tidc registers).
@tariqkurd-repo I do not know how RISC-V in general feels about extensions replacing instructions without permission of the specifications they extend, but that seems kind of rude.  It seemed more polite, if nothing else, to explicitly grant permission to do so. :)

I'll note that there is more redundancy in the encodings as the load/store addresses must be 16-byte aligned and so the 4 LSBs (1/3) of the immediate are wasted, as well as c0 being useless.
It would be better to make all of those cases reserved.
I personally think these things will come out of ARC review when we get to that stage, and they allocate encodings.

I'll note that there is more redundancy in the encodings as the load/store addresses must be 16-byte aligned and so the 4 LSBs (1/3) of the immediate are wasted, as well as c0 being useless.

This is not wasted space.  The alignment of the address + immediate needs to be 16-byte aligned, but there's no guarantee that the address is already 16-byte aligned.
In particular, it is very common in managed languages to have tagged pointers where the low 3 bits store type information.  This can then be reset to zero in the load / store instructions with a -1 to -7 displacement added to the field offset.

Just to make sure it isn't missed... In addition to the clever trick David's pointing out, this marking as extensible is intended to apply to more than just high-alignment-requiring LC/SC instructions (including LB/SB, which impose no alignment requirements).

thanks @davidchisnall I didn't know those bits would be used that way, so if they don't offer those bits when we finally get allocated encodings, we should point to that use case
@nwf I guess you're saying that load/stores via c0 can be replaced by anything you like

thanks @davidchisnall I didn't know those bits would be used that way, so if they don't offer those bits when we finally get allocated encodings, we should point to that use case

There should be some rationale in the base RISC-V spec.  We had this discussion 10 years ago there as well.


Make sure the GPG key is imported before Yum repositories are created

I believe this addresses #81 (fixes resource ordering within the context of the module)

@hlaf Thanks!

@alexjfisher Don't mention it, I'm glad to be of service!


Can't select rows when using setState with an array value

This issue is very similar to https://github.com/react-bootstrap-table/react-bootstrap-table2/issues/297, which has been fixed (and works!), but if you try to setState with an array, the issue returns.
Partial example:
constructor(props) {
  super(props);
  this.state = { results: [] };
}

select(row) {
  this.setState({
    results: []
  });
}

const selectRow = {
  mode: 'radio',
  clickToSelect: true,
  onSelect: this.select
};

If you change results: [] to results: '', it works fine.
"react-bootstrap-table-next": "2.0.1",
"react-bootstrap-table2-filter": "1.1.2",
"react-bootstrap-table2-paginator": "2.0.1"

EDIT:
This issue title is a bit lacking, since I just discovered that using an object ({}) in the setState also prevents the selection from showing.

@pineconesundae I will check this out again, thanks,  I just test it again and I found that call setState will break the selection procecss

Having same issue
Demo: https://stackblitz.com/edit/react-yeuhjg

Okay so, I tried it with different package versions and feature was working smoothly on initial releases but gone broke on 0.1.4(error) and stopped reflecting checkbox changes after patched in 0.1.5 works perfectly in 0.1.3

Fixed: https://react-bootstrap-table.github.io/react-bootstrap-table2/blog/2019/02/24/version-bump.html


Update install_all.sh

There are Ubuntus more recent than those ones and there is going to be more.

this script is super flaky as is, I dont know if this is a good idea.


Example how to run command in running container

has anyone been able to run a mkdir in a running container successfully using the dotnet api?
I cant seem to see the directory being created in the container. this is the code i have tried: -
var created =  await Docker.Containers.ExecCreateContainerAsync("3375e8971d875972dd0d5bb324c43270335a5266fa51946731b1d52192709f23", new ContainerExecCreateParameters()
{
AttachStdin = true,
AttachStdout = true,
Cmd = new List()
{
"mkdir",
"test"
},
Tty = true,
AttachStderr = true,
        });

        await Docker.Containers.StartContainerExecAsync(created.ID);

end result no folder in the container.
any ideas would be great.

Here is a working example, i use it to make exec possible trough websocket to be able to use it from xtermjs (exec does not provide ws endpoint like attach)
Its probably badly written and lacks proper cancellation etc, but you get the idea
var execCreateResp = await client.Containers.ExecCreateContainerAsync(id, new Docker.DotNet.Models.ContainerExecCreateParameters()
{
    AttachStderr = true,
    AttachStdin = true,
    AttachStdout = true,
    Cmd = new string[] { "powershell" },
    Detach = false,
    Tty = true,
    Privileged = true
}
    );

using (var stream = await client.Containers.StartAndAttachContainerExecAsync(execCreateResp.ID, false, default(CancellationToken)))
{
    // Get Info of Exec Instance
    var execInspectResp = await client.Containers.InspectContainerExecAsync(execCreateResp.ID, default(CancellationToken));
    var pid = execInspectResp.Pid;
    _logger.LogInformation($"Started Container Console (env-id: {environment.Id}, pid: {pid}");

    // Read from Docker to WS
    var tRead = Task.Run(async () =>
    {
        var dockerBuffer = System.Buffers.ArrayPool<byte>.Shared.Rent(81920);
        try
        {
            while (true)
            {
                // Clear buffer
                Array.Clear(dockerBuffer, 0, dockerBuffer.Length);
                var dockerReadResult = await stream.ReadOutputAsync(dockerBuffer, 0, dockerBuffer.Length, default(CancellationToken));

                if (dockerReadResult.EOF)
                    break;

                if (dockerReadResult.Count > 0)
                {
                    bool endOfMessage = true;
                        await _webSocket.SendAsync(new ArraySegment<byte>(dockerBuffer, 0, dockerReadResult.Count), WebSocketMessageType.Text, endOfMessage, CancellationToken.None);
                }
                else
                    break;
            }
        }
        catch (Exception ex)
        {
            _logger.LogError(ex, "Failure during Read from Docker Exec to WebSocket");
        }
        System.Buffers.ArrayPool<byte>.Shared.Return(dockerBuffer);
    });

    // Write WS to Docker
    var tWrite = Task.Run(async () =>
    {
        WebSocketReceiveResult wsReadResult = null;
        // Read only small amount of chars at once (performance)!
        var wsBuffer = System.Buffers.ArrayPool<byte>.Shared.Rent(10);
        try
        {
            while (true)
            {
                // Clear buffer
                Array.Clear(wsBuffer, 0, wsBuffer.Length);
                wsReadResult = await _webSocket.ReceiveAsync(new ArraySegment<byte>(wsBuffer), CancellationToken.None);
                await stream.WriteAsync(wsBuffer, 0, wsBuffer.Length, default(CancellationToken));
                if (wsReadResult.CloseStatus.HasValue)
                {
                    _logger.LogInformation($"Stop Container Console (env-id: {environment.Id}, pid: {pid}");
                    var killSequence = Encoding.ASCII.GetBytes($"Stop-Process -Id {pid}{Environment.NewLine}");
                    await stream.WriteAsync(killSequence, 0, killSequence.Length,
                        default(CancellationToken));
                    break;
                }
            }
        }
        catch (Exception ex)
        {
            _logger.LogError(ex, "Failure during Write to Docker Exec from WebSocket");
        }
        System.Buffers.ArrayPool<byte>.Shared.Return(wsBuffer);
    });

    await tRead;
    await tWrite;
}

Maybe this can help you... at least you should be able to read stdout/stderr

This does not seem to work as i get a response declaring the exec instance is not running after starting the exec instance:- this is the code i have tried :-
[TestMethod]
public async System.Threading.Tasks.Task TestMethod1Async()
{
IDockerClient _Client = new DockerClientConfiguration(new Uri("npipe://./pipe/docker_engine")).CreateClient();
        DockerContainerResponse _containerResponse = new DockerContainerResponse();

        try
        {
            List<string> commands = new List<string>();
            commands.Add("mkdir test_instance");

            ContainerExecCreateParameters inParameters = new ContainerExecCreateParameters();
            inParameters.AttachStdin = true;
            inParameters.AttachStdout = true;
            inParameters.AttachStderr = true;
            inParameters.Cmd = commands;
            inParameters.Tty = false;
            inParameters.Detach = false;
            inParameters.User = "";
            inParameters.Privileged = true;

            var execID = await _Client.Containers.ExecCreateContainerAsync("sad_mestorf", inParameters);

            await _Client.Containers.StartAndAttachContainerExecAsync(execID.ID,false);

            var response = await _Client.Containers.InspectContainerExecAsync(execID.ID);

            var temp = response.Running;

        }
        catch (Exception oException)
        {

        }

@marknitek Would you mind sharing your full code (in private)? I think I saw you around the NAV community, am I right? I am currently working on a tool for easier container administration for NAV / BC (https://github.com/tfenster/BCinaB) and am somewhat struggling to implement a browser-based terminal for the containers, which you already seem to have in place, if I read your post correctly?
I would of course include full credits to you but maybe could spend my time on other improvements if I could include your code

@tfenster Yes NAV is my background and i used the mentioned code in a very similar project to BCinaB.
Sure i can share you the code, i will contact you by mail.
I think it would be great to share some ideas since our projects are very similar!
Yes i managed to integrate a terminal (to the running docker container) in the browser by using Docker.DotNet/ASP.NET Core/Websockets /xtermjs

@akash3456 I'am sorry to hear that it does not work.
Does inspect tell you its not running? Could it be that it is because mkdir is already executed/exited at that time?
Maybe you should try executing a shell and writing to it like in my example, then you are sure the process is not exited?

@akash3456 your code is working for me. Take a look if you have privileges to create directory in root, because your command will create the directory in root. If not try to create the directory in /tmp.
...
Cmd = new List<string>()
{
   "mkdir",
   "/tmp/test"
},
...

@marknitek I'd be really interested to see a working setup for using Docker.DotNet, xterm.js, and websockets. Do you have anything you could share?

The naming of this is very confusing - how is Exec a "Create" operation?  It is executing a process in an existing container

ExecCreateContainerAsync is missing in the newest version. Has it any new equivalent to emulate running "docker exec" command?

ExecCreateContainerAsync is missing in the newest version. Has it any new equivalent to emulate running "docker exec" command?

What makes you think that?
https://github.com/dotnet/Docker.DotNet/blob/30181cc146076ee8dc7ab839535ae89128672531/src/Docker.DotNet/Endpoints/IExecOperations.cs#L24

@HofmeisterAn oh ok it was moved from "Containers" to "Exec" so it can be reached via client.Exec.ExecCreateContainerAsync instead of client.Containers.ExecCreateContainerAsync.

I'm trying to run the following commands inside a rabbitmq container:
docker exec rabbitmq rabbitmqadmin declare exchange name=test-exchange type=direct
docker exec rabbitmq rabbitmqadmin declare queue name=test-queue durable=false
docker exec rabbitmq rabbitmqadmin declare binding source=test-exchange destination_type=queue destination=test-queue routing_key=test-key

My latest try looks like this:
        var queueParameters = new CreateContainerParameters
        {
            Name = "incoming.queue",
            Image = "rabbitmq:3.11-management",
            ExposedPorts = new Dictionary<string, EmptyStruct>
            {
                {"15672", default}
            },
            HostConfig = new HostConfig
            {
                //AutoRemove = true,
                PortBindings = new Dictionary<string, IList<PortBinding>>
                {
                    {"15672", new List<PortBinding> { new() { HostPort = "15673" } }}
                }
            },
            Labels = new Dictionary<string, string>
            {
                {"purpose", "queue"},
                {"case", "queue"},
                {"apptype", "consoleapp"}
            }
        };

        var queueContainer = await client.Containers.CreateContainerAsync(queueParameters);
        await client.Containers.StartContainerAsync(queueContainer.ID, new ContainerStartParameters());
        Console.WriteLine($"Started queue container with id: {queueContainer.ID}");

        var execDeclareExchangeParameters = new ContainerExecCreateParameters
        {
            Cmd = new List<string> { "rabbitmqadmin", "declare", "exchange", "name=test-exchange","type=direct" }
        };
        var execDeclareExchange = await client.Exec.ExecCreateContainerAsync(queueContainer.ID, execDeclareExchangeParameters);
        await client.Exec.StartAndAttachContainerExecAsync(execDeclareExchange.ID, false);
        Console.WriteLine($"Declared exchange inside queue container with id: {queueContainer.ID}");

        var execDeclareQueueParameters = new ContainerExecCreateParameters
        {
            Cmd = new List<string> { "rabbitmqadmin" ,"declare" ,"queue" ,"name=test-queue" ,"durable=false" }
        };
        var execDeclareQueue = await client.Exec.ExecCreateContainerAsync(queueContainer.ID, execDeclareQueueParameters);
        await client.Exec.StartAndAttachContainerExecAsync(execDeclareQueue.ID, false);
        Console.WriteLine($"Declared queue inside queue container with id: {queueContainer.ID}");

        var execDeclareBindingParameters = new ContainerExecCreateParameters
        {
            Cmd = new List<string> { "rabbitmqadmin" ,"declare" ,"binding" ,"source=test-exchange" ,"destination_type=queue" ,"destination=test-queue" ,"routing_key=test-key" }
        };
        var execDeclareBinding = await client.Exec.ExecCreateContainerAsync(queueContainer.ID, execDeclareBindingParameters);
        await client.Exec.StartAndAttachContainerExecAsync(execDeclareBinding.ID, false);
        Console.WriteLine($"Declared binding inside queue container with id: {queueContainer.ID}");

What's funny, it works with "mkdir" (e.g. creating 3 directories with 3 execs) but does not work with rabbitmq. I'm not getting any logs nor error messages from the container exept those that are generated during rabbitmq startup.
Any ideas on what's missing?

@HofmeisterAn  I'm sorry but I was wrong. The rabbitmq is started while the commands are executed.
E.g. changing:
        var execDeclareExchangeParameters = new ContainerExecCreateParameters
        {
            Cmd = new List<string> { "rabbitmqadmin", "declare", "exchange", "name=test-exchange","type=direct" }
        };

to:
        var execDeclareExchangeParameters = new ContainerExecCreateParameters
        {
            Cmd = new List<string> { "rabbitmqadmin" }
        };

gave me the following error:
ERROR: Action not specified
rabbitmqadmin --help for help

I'm not sure if that's a RabbitMQ or Docker.DotNet issue, but running docker exec from cmd on host works fine so I'm leaning towards accusing Docker.DotNet.
Please see for yourself here if you are still interested in helping out resolving this strange issue:
https://github.com/Stadzior/DotNetContenerization/tree/main/ElToroRojo

@HofmeisterAn you were right, It took RabbitMQ several more seconds to be ready to use.
Thanks once again.


Signals cannot be added, via Node dock,  one by one

Godot version:
3.1 2d87703
OS/device including version:
WIndows 10
Issue description:
When I try more than one signal from node, each time when I add signal, editor change focus from node to script and that's why Node dock is completely clear and I must again select Node to add another signal
Steps to reproduce:
https://streamable.com/tp3z9

Related to #21950

Duplicate of #21950.


[HOLD for payment 2024-03-29] [$500] [Simplified Collect][Distance Rates] Implement PolicyDistanceRateSettingsPage

Implement PolicyDistanceRateSettingsPage following the specifications in the design doc
cc @MrMuzyk
Upwork Automation - Do Not Edit

Upwork Job URL: https://www.upwork.com/jobs/~010902f2b08cb0564b
Upwork Job ID:<PHONE_NUMBER>466571776
Last Price Increase: 2024-02-29

I am Michał from Callstack - expert contributor group. I’d like to work on this job.

I am a freelancer from Upwork, I would like to work on this issue

Contributor details
Your Expensify account email<EMAIL_ADDRESS>Upwork Profile Link: https://www.upwork.com/freelancers/~01d2e2282d627e9a4b

I am ready to start work right now

@hereistopdev thanks for the interest. However, we already assigned someone to work on this issue.

ok
You are welcome

We’re still working on the main page. We’ll get to this once we’re done with that

We have a draft pr

@parasharrajat to fix https://github.com/Expensify/App/issues/38662? I think @MrMuzyk is assigned and will work on a fix.

Just pending payment

Sorry for the delay, I'll handle payment now. Just to confirm, there was a regression on this issue's PR, correct? So the payment would be $250?

I don't think that was a regression since the feature didn't exist yet. I think the full l$500 still applies in this case.

Got it, thanks for confirming!
@ishpaul777 I've sent you an offer via Upwork: https://www.upwork.com/nx/wm/offer/101802947


how to resolve this？

how to resolve this？Authentication failed.

Our group had the same issue: login gives bad request 400 error (and registration internal server error 500). In our case it was caused by module 'meanio' updating from 0.8.82 to 0.8.83. Returning to 0.8.82 fixed it again.

are you reslove?

@xiaoyang2022 Can you give some more information?  What route are you attempting to hit when you get Authenication failed.  Where are you seeing the error (on the page, in the browser console, in the server std output?)


warning: "@charset" must be the first rule in the file   config配置css: { preprocessorOptions: { scss: { charset: false } } }  无效

Describe the bug
build打包时 报错
warning: "@charset" must be the first rule in the file
config配置
css: { preprocessorOptions: { scss: { charset: false } } }
还是报错
Reproduction
export default defineConfig({
plugins: [
vue(),
styleImport({
libs: [
{
libraryName: 'vxe-table',
esModule: true,
resolveComponent: (name) => vxe-table/es/${name},
resolveStyle: (name) => vxe-table/es/${name}/style.css
}
]
})
],
server:{
host:'<IP_ADDRESS>',
port:9000
},
css: { preprocessorOptions: { scss: { charset: false } } },
build:{
assetsDir:'application',
write:false,
},
resolve: {
// 导入文件夹别名
alias: {
'@': resolve(__dirname, './src'),
},
},
})
System Info
System:
    OS: Windows 10 10.0.19042
    CPU: (8) x64 Intel(R) Core(TM) i5-8265U CPU @ 1.60GHz
    Memory: 2.73 GB / 7.85 GB
  Binaries:
    Node: 12.16.3 - C:\Program Files\nodejs\node.EXE
    Yarn: 1.22.4 - C:\Program Files (x86)\Yarn\bin\yarn.CMD
    npm: 6.14.4 - C:\Program Files\nodejs\npm.CMD
  Browsers:
    Chrome: 95.0.4638.69
    Edge: Spartan (44.19041.1266.0), Chromium (95.0.1020.44)
    Internet Explorer: 11.0.19041.1202
  npmPackages:
    @vitejs/plugin-vue: ^1.9.3 => 1.9.4
    vite: ^2.6.14 => 2.6.14

Used Package Manager
yarn
Logs
> <stdin>:7775:0: warning: "@charset" must be the first rule in the file
    7775 │ @charset "UTF-8";
         ╵ ~~~~~~~~
   <stdin>:7741:0: note: This rule cannot come before a "@charset" rule
    7741 │ @-webkit-keyframes nprogress-spinner {
         ╵ ^

 > <stdin>:7775:0: warning: "@charset" must be the first rule in the file
    7775 │ @charset "UTF-8";
         ╵ ~~~~~~~~
   <stdin>:7745:0: note: This rule cannot come before a "@charset" rule
    7745 │ @keyframes nprogress-spinner {

Validations

[X] Follow our Code of Conduct
[X] Read the Contributing Guidelines.
[X] Read the docs.
[X] Check that there isn't already an issue that reports the same bug to avoid creating a duplicate.
[X] Make sure this is a Vite issue and not a framework-specific issue. For example, if it's a Vue SFC related bug, it should likely be reported to https://github.com/vuejs/vue-next instead.
[X] Check that this is a concrete bug. For Q&A open a GitHub Discussion or join our Discord Chat Server.
[X] The provided reproduction is a minimal reproducible example of the bug.

最简单的方法 : 在 /node_models/vite/dist/node/chunks/*
下面搜minifyCSS
加一行这个
css = css.replace(/@charset "UTF-8";/ig,'')
看了下原因其实就是postcss给含有中文的scss 加了个@charset "UTF-8"; 但是这个是放在头部的 多个合并的时候放在了这个放在了中间 esbuild就提示了个waring 或者你把含有中文的scss都去掉就行了

thanks

i have same problem.

css: { preprocessorOptions: { css: { charset: false } } } don't working


Generate metric_sender.yaml from template

A commit from https://github.com/openshift/openshift-tools/pull/1747. Already merged to stg.
cc @joelddiaz

👍 #1747 in stg


GEODE-8949: Fix broken build inconsistent-missing-override

Was failing to build on Mac
Authored-by: M. Oleske<EMAIL_ADDRESS>PR https://github.com/apache/geode-native/pull/746 caused a failure on Mac only it seems due to SetUp function from gTest not using override correctly.  Since the body was commented out and scrubTestLogFiles is used in TearDown, I just deleted the function to solve the problem

Looks like PR pipeline has issues. Although this PR had 2 approvals, shouldn't have been able to merge due to failing Travis (clang-analyzer problem with ACE). Investigating.


Adds blog post "Strategies for Classification Layer Initialization in Model-Agnostic Meta-Learning"

Awesome, thanks for the submission!


Add a table for data in Graph component

Create table on graph page for the selected data, and use a snippet or pagination

choose react-table component (a npm package) to implement this task

the react-table package has this built-in feature already


Invisible Mobs and Crashing

Describe the bug
I recently updated Fabulously Optimized from a 1.19 version (I can't launch the game, so IDK the exact version number) to version 4.3.3 on 1.19.2. Before updating, my game ran great. I used a few extra mods and ComplementaryShaders, and the game ran without any issues. I took a break from playing for a while, and when I returned, I realized that I was still running on 1.19 and wanted to update to 1.19.2. I followed the usual installation instructions and installed Fabulously Optimized version 4.3.3 (auto update) in MultiMC.
I moved my additional mods and their configuration files over and updated ComplementaryShaders to the latest version. Once again, everything worked great, except for the fact that when shaders were enabled (and only when shaders were enabled), all mobs would go invisible after a few seconds. I moved to a non-auto-update version of Fabulously Optimized with no additional mods in a new and separate instance, and the issue still occurred. I thought that this was just a problem with ComplementaryShaders, so I asked for support on their Discord server. They asked me to test if the problem occurred with other shader packs, so I tested running BSL shaders (again in the "vanilla" FO instance). After enabling BSL shaders, the game crashed whenever I tried to create a new world. I tried launching with BSL shaders disabled and had the same problem. I now cannot launch any instance of an FO mod pack that I have on MultiMC (even the 1.19 version that worked perfectly before). Other instances in MultiMC launch fine.
Modpack version
4.3.3
Launcher
MultiMC
Other things

[X] I updated FO to a newer version (mention, what version to what version)
[X] I added/removed some mods or resource packs (mention, which ones)

Additional context
Log (ComplementaryShaders, pre BSL test, no crash just invisible mobs): https://mclo.gs/zuwfkz4
Log (BSL Shaders): https://mclo.gs/G5hGi7T
Crash report (BSL Shaders): https://mclo.gs/CJIG9oB
Log (1.19 MultiMC instance, post BSL test): https://mclo.gs/2x1i1ku
Crash report (1.19 MultiMC instance, post BSL test): https://mclo.gs/eNbOnYJ

same

lol my mobs an

d cape are transparent when I updated fabulously (WHYY??)

For me, the mobs weren't transparent, they were completely invisible. I could only see their shadows and death particles.

Try disabling the mod Entity Texture Features.

the crashes both have something to do with biome multi noise with the same issue IllegalArgumentException: SubTree needs at least one child, so the crashes are not an ETF issue, the invisible entities may be ETF related but I havent replicated it myself yet

Wait a minute... why are you using 1.19 instead of 1.19.2, @Jack1424? Please update to the latest 1.19.2 version and if you need 1.19, read this.

I tried to create a new instance on 1.19.2 and these issues began.

If it's a separate issue, then it needs a separate bug report...
In any case I don't care about 1.19 bugs because I've made it very clear that it is no longer supported. So just move your mods and worlds over and use 1.19.2.
Did you try disabling ETF on 1.19? Does the issue occur without shaders?

I just imported a new instance of 1.19.2 auto-update FO in MultiMC. The game launches but then crashes when I click on Singleplayer.
Log: https://mclo.gs/N1PNXSY
Crash Log: https://mclo.gs/6bkh4qs


Feature Request: Night Mode By Time

Please add settings to have night mode enabled by time instead of location. The ability to set night mode to start at anytime and end at anytime.

I will think about that....

https://github.com/raphaelquintao/QRedshift/issues/14


Get wrong image when uploading multiple images asynchronously

This library works for me when I only upload one image at a time.
But when I upload multiple images at asynchronously the image is wrong. So this library works for single image only or it works for uploading multiple images at once.

Q
A

This Package Version
1.5.1

Laravel Framework Version
5.4.3

PHP version
7.4.3

Operating system
Ubuntu 20.04.4

Check used JS library that should create more unique file name. The package depends on it.


Name of the Station

Is there a possibility, the name of the Station (for example avanti - Purkersdorf Tullnerbachstraße 77-79) only the company Name (avanti) in a object?

The API provides the whole string as one name. As I cannot know in which position the "real" name ends I have no idea how to do this.