⚠ Bofrost.at has degraded performance

In b1a9ef0, Bofrost.at (https://www.bofrost.at) experienced degraded performance:

HTTP code: 200
Response time: 1401 ms

Resolved: Bofrost.at performance has improved in 87621c3 after 6 minutes.


[ENG-1887] Server Settings

Ticket
ENG-1887
Purpose
Update server settings (and other configs if any) to support staging deployment.
Changes

Disable SSL

Tomcat CAS does not need SSL since Apache Shibboleth handles it
SSL is disabled via spring-boot server properties, which applies further to the embedded Tomcat server
Updated the port to use 8080 instead of the default 8443
Commented out the additional HTTP server configuration, which was enabled previously when SSL is enabled
Removed the keystore file

Server cas.properties and local cas-local.properties

The server one has been updated with the following changes

Use 80 instead of 8080 for HTTP
Use system env for server specific settings
Bumped security settings
Updated database name and port

Other minor changes on cas.properties

Increased CAS DB JPA leak threshold from 3000 to 6000
Increased CAS DB JPA batch size to 1 to 5
Increased long-term authentication expiration time from 14 to 28 days
Moved fakeCAS to the last of delegated authentication
Improved readability

Changes on JSON service registries

Updated JSON registries to disable CAS client delegations
Added OSF Registries to JSON service registries with assets

UI / UX

Improved branded service UI for Preprints and Registries

Moved all local settings (services and properties) to respective local folder so that they do not conflict with server ones. Added Dockerfile-local for local development
Updated message.properties to target staging3 temporarily while we continue to work on server-specific settings

Dev Notes
N / A
QA Notes
N / A
Dev-Ops Notes

Basic Login - DevOps Tasks

Charts PR

This PR has been replaced by https://github.com/CenterForOpenScience/osf-cas/pull/1


override sw-extension-card-base template not working

PHP Version
7.4
Shopware Version
<IP_ADDRESS>
Expected behaviour
Block is overriten by custom template
Actual behaviour
Block is not rendered in browser properly
How to reproduce
Test files
Create simple plugin that extends sw-extension-card-base with simple template. Main files:
sw-extension-card-base/index.js
import template from './template.html.twig';

Shopware.Component.override('sw-extension-card-base', {
    template
});

sw-extension-card-base/template.html.twig
{% block sw_extension_card_base %}
    Override
{% endblock %}

main.js
import './extension/sw-extension-card-base';

Debugging
When debug the new plugin in:
vendor/shopware/administration/Resources/app/administration/src/core/factory/component.factory.js:309
    /**
     * Get the final template result including all overrides or extensions.
     */
    config.template = getComponentTemplate(componentName);

    if (componentName === 'sw-extension-card-base') {
        console.log('final template', config.template);
    }

effect of console.log in developer tools is:
final template     Override

but in browser html is not ovverriden.
so something is not refreshed internally? Please verify this behaviour.
Guess
I see that component sw-extension-card-base is marked private - maybe thats the case?
/**
 * @private
 */
Component.register('sw-extension-card-base', {
    template,

    inheritAttrs: false,

I also ran into this today doing a clean install, {% sw_extends '...' %} inside a theme are overruled by the templates from the platform. Checked out release <IP_ADDRESS> and it doesn't have this issue.

<IP_ADDRESS> - problem still exists

We don't explicitly want that nobody extends the extension manager / extension store. That's the reason why it's set to private


Gif become an unanimated image with fit function

all is in the title, please help !

Intervention Image does not support animated GIF format currently.

But ，In the document，Intervention Image support animated GIF format!


[WIP] torchtune usecase

Issue #, if available:
Description of changes:
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Please include a README file

Of course, I marked it as "work in progress"


Fixing a few bugs and creating quicklogin file

Changing "en" to settings.get("LANG") to actually get LANG settings from settings.toml for trending.py bot/init.py
Changing settings_test.toml to settings.toml
Changing like_selector
Creating a login file(quicklogin.py) because people new to coding can't figure it out.
Adding quicklogin.py to README

@sudoguy

Hi @muhammedaksam! Thank you! ❤


Speed up dependencies indexing

addresses #209

For some reason github don't allow me to see changes if I login. I'll put review in comments.
append_to_layout.m:
l31: Should we put a warning here? To tell user that some files are skipped?
l74: Just in case bids will add more formats that are folders, it will be more generic to test if path is directory.
copy_to_derivatives.m:
l3: Misleading description, in implementation function returns nothing. Bu it will be good to return the path to created derivative folder (e.g. derivatives/bids-matlab)
l24: To my taste, the pipeline name argument must be mandatory.
l94: From my understanding of (bids)[https://bids-specification.readthedocs.io/en/stable/02-common-principles.html#storage-of-derived-datasets], by default derivatives should be within dataset folder, so out_path = fullfile(BIDS.pth, 'derivatives');. Also you provide default value to out_path -- it will be never empty so if will never trigger.
l258: This will be slow. You first copy data, then extract it, and then remove zipped files. You can extract files directly to destination. For ex. in copy_with_symlink add if ends_with('.gz') && unzip; unzip_data(...). Obviously in this case you need to drop of removal of original zipped files.
layout.m:
It takes ~4s per subject (each containing ~800 files), so performance is improved.
However it treats json files as data, the search patterns must be adapted, for ex. like in #185
Overwise, it looks good for me

layout.m:
It takes ~4s per subject (each containing ~800 files), so performance is improved.

:smile:

However it treats json files as data, the search patterns must be adapted, for ex. like in #185

Yup I am working on it on a different PR in large swath inspired by #185.

append_to_layout.m:
l31: Should we put a warning here? To tell user that some files are skipped?
l74: Just in case bids will add more formats that are folders, it will be more generic to test if path is directory.

Done

Tell me when I can retest

l24: To my taste, the pipeline name argument must be mandatory.

Agreed. Done. Mind you this change the order of input arguments.

l94: From my understanding of (bids)[https://bids-specification.readthedocs.io/en/stable/02-common-principles.html#storage-of-derived-datasets], by default derivatives should be within dataset folder, so out_path = fullfile(BIDS.pth, 'derivatives');. Also you provide default value to out_path -- it will be never empty so if will never trigger.

Good point. Actually the whole thing about folder organizations of derivatives and raw are mostly suggestions, but I agree that we can make the default to nest the derivatives in the raw.

l258: This will be slow. You first copy data, then extract it, and then remove zipped files. You can extract files directly to destination. For ex. in copy_with_symlink add if ends_with('.gz') && unzip; unzip_data(...). Obviously in this case you need to drop of removal of original zipped files.

Yup I know but I am pretty sure (as far as I can recall) I had to do things that way because the behavior of Octave and Matlab is slightly different with gunzip. Need to double check.

Yup I know but I am pretty sure (as far as I can recall) I had to do things that way because the behavior of Octave and Matlab is slightly different with gunzip. Need to double check.

From quick look into docs, the only difference I could spot is that matlab automatically creates folder if it not exists. But in any way, this has no relations with  dependencies calculations.

latest commits implements #185 but relaxes constraints to have more than one instance of the string sub- in the filename: we'll just assume that the prefix is what comes before the first one.

So the difference in gunzip behavior (and not unzip as the name of function implies) between Octave and Matlab is that Octave deletes the source file.
Here is MWE below.
Will try to add a work around with an if is_octave to keep the speed up with matlab.
Not sure how if gunzip plays nice with symbolic links when working with datalad datasets. Will try it out.
Script
src_folder = fullfile(pwd, 'input');
tgt_folder = fullfile(pwd, 'output');

% set up
copyfile('sub-01_T1w.nii.gz', src_folder);

%do
gunzip(fullfile(src_folder, 'sub-01_T1w.nii.gz'), tgt_folder)

Starting point
├── gunzip_cmp_matlab_octave.m
├── input
├── output
└── sub-01_T1w.nii.gz

Results
With Matlab
├── gunzip_cmp_matlab_octave.m
├── input
│   └── sub-01_T1w.nii.gz
├── output
│   └── sub-01_T1w.nii
└── sub-01_T1w.nii.gz

With octave
├── gunzip_cmp_matlab_octave.m
├── input
├── output
│   └── sub-01_T1w.nii
└── sub-01_T1w.nii.gz

Tell me when I can retest

@nbeliy
It should be good for another cross check.
Added a test for copy derivatives and unzip to try to make sure Octave and Matlab behave the same way on Linux.
Will quickly run things on Windows.

P.S. How is the advances on regexp for file selection? I can't find the corresponding merge request

P.S. How is the advances on regexp for file selection? I can't find the corresponding merge request

Sorry.
Was done on local branch that I merged here:
https://github.com/bids-standard/bids-matlab/pull/243/commits/e43f2e374bbd5a9aec236f91756e944eb7fa72d7

Was done on local branch that I merged here:

Ok thet's why I still have json -- you exclude them only for datasets following the schema.
Is there reason why shemaless datasets should have json files as data?

Is there reason why shemaless datasets should have json files as data?

It was suggested by @arnodelorme in here
https://github.com/bids-standard/bids-matlab/issues/97#issue-742782287

It was suggested by @arnodelorme in here

Then will it be possible to get json files only if they are not metadada for data?
A json file will be created for each file in derivative, then to do query I will need to add 'extention', '.nii' each time.
Also, if he want to get metadata json, they can be retrived with query('metafiles')

It was suggested by @arnodelorme in here

Then will it be possible to get json files only if they are not metadada for data?
A json file will be created for each file in derivative, then to do query I will need to add 'extention', '.nii' each time.
Also, if he want to get metadata json, they can be retrived with query('metafiles')

Would you be ok if I opened a separate issue for this: I feel that otherwise we are ending up changing behavior on this PR that was supposed to be only about optimization and has already devolved into way more than this.
Tempted to have an issue + meeting where several of the interested people on this can come together an agree on what we would like the API and the behavior to look like for a first version.

Tempted to have an issue + meeting where several of the interested people on this can come together an agree on what we would like the API and the behavior to look like for a first version.

It could be a good idea, if I will be invited)

Tempted to have an issue + meeting where several of the interested people on this can come together an agree on what we would like the API and the behavior to look like for a first version.

It could be a good idea, if I will be invited)

most definitely


Clean up Development v9

Clean up Development v9

This PR:
1.    Cleaned up Development branch in preparation for merger to Master based on feedback from PR #397

The files this PR effects:
Components

src/components/Contacts/ContactListTable.jsx
src/components/Messages/MessagePreview.jsx
src/components/NavBar/NavbarDesktop.jsx
src/components/NavBar/NavbarLoggedOut.jsx
src/components/NavBar/NavbarMobile.jsx

Other Files

src/theme.js

Additional Context (optional):
Will leave the correction for the images in production build in PR #407, this PR will simply clean up the Links and other associated feedback from PR #397

ugh, seems tests are failing due to changing MUI link to React-Router link.

Got the unit tests fixed.


⚠ Samsung has degraded performance

In 808adda, Samsung (https://samsung.com) experienced degraded performance:

HTTP code: 200
Response time: 6076 ms

Resolved: Samsung performance has improved in 81c9005.


Ignore ide files

Hi Cedric,
Excellent work with the vue-gapi plugin! I have made a few improvements that I hope you will merge into your version. I have also created an example application, see https://github.com/nidkil/vue-gapi-example, that demonstrates all vue-gapi functionality including the changes I have made.
This pull request excludes the IDE files from the repository.
Regards, nidkil

Does this pull request really require a confirmation test? All it does is exclude IDE files from Git.


Is there a way to change the "Number of Images" setting to generate 1 image at a time instead of all at the same time?

On the gradio ui version both options exist, and being able to tell it to generate multiple images sequentially instead of concurrently consumes a lot less vram, so that would be a nice option to have.

This is an excellent suggestion. I'll explore an implementation


Get-DbaWaitStat - Good command to add?

Feature Request
Get-DbaWaitStats - Good command to add?

@PowerDBAKlaas - you opinion?

What would the command output @js0505 ?

Talking just general output from sys.dm_os_wait_stats or something like Paul Randal's query?

I'd like to see some more description too first.

I was thinking something along the lines of Paul Randal's stuff here https://www.sqlskills.com/blogs/paul/capturing-wait-statistics-period-time/

Well, although I'm using PowerShell as much as I can, I don't think I'm gonna uninstall SSMS any time soon. So, the question is: "Why would I want to do this with PowerShell instead of SSMS?". What are we going to add that makes this better?
And also, for wait stats alone we can find a dozen different versions. Even Paul Randall himself wrote multiple versions. Some exclude a list of 'normal' waits that can change dependent on the specific configuration. And there's more on DMV's,missing indexes, unused indexes, index fragmentation, data profiling, blocking, plan cache, ...
We should consider a general strategy first on how to deliver those existing wealth of useful t-sql scripts.
We don't want to end up with Get-DbaWaitStatsPaulR7 Get-DbaWaitstatsKevinEK2.
Would we want Get-DbaWaitstats -flavor PaulR7?
Or rather decide to have only one Get-DbaWaitstats and adapt the t-sql to the majority's wishes?
Often the needed flavor is dependent on the situation; I have 19 t-sql scripts on gathering wait stats, and pick one I think would be the most useful at that moment. Or run 2 or 3 consecutively. And it's easier to comment and uncomment some types in SSMS than  typing a list of Include or -Exclude in a console.
I'm not saying we shouldn't have it, but I need to be convinced with some flashy feature.
In that case we would probably need a very specific name too, like Get-DbaWaitstatsForCaseabc or something.

Done! Get-DbaWaitStatistic

and based off of Paul's famous post.


FIX Allow custom SELECT to be used for sorting in DataQuery::column()

If a custom select clause (using special features such as CASE) is used, and it was added using SQLSelect::selectField, the custom select clause should be retained when calling DataQuery::column().
I know that using SQLSelect::addOrderBy to add the select clause is handled correctly, but that's because it uses a special alias. If I want to use a specific alias, I can't rely on that.

Thanks for the PR, @GuySartorelli. Is there any chance you could add a test for this fix?

@michalkleiner Test added.

Thanks @GuySartorelli, wonderful!
Could you please squash the commits into one saying "FIX Allow custom SELECT to be used for sorting in DataQuery::column()" and then we're good to merge.


Set GOMAXPROCS automatically

This is required in containerised environments to properly set
GOMAXPROCS to actual container limits set and not the whole underlying node's CPUs.
In our environment this fixed the CPUThrottling alerts we were getting previously.
See for more details:
https://github.com/uber-go/automaxprocs

/cc @weeco

Curious why this was closed without any note @weeco


project: establish a Code of Conduct

The proposal is submitted: https://golang.org/design/13073-code-of-conduct
Please send all comments or questions directly to<EMAIL_ADDRESS>(This is a departure from the typical proposal process, since discussions Around Codes of Conduct tend to devolve quickly. By restricting the discussion Of this proposal to 1:1 conversations between myself and members of the Community, I hope to better hear everyone’s specific concerns without generating unnecessary noise.)

A second revision of the proposal is now available: https://golang.org/design/13073-code-of-conduct

LGTM

LGTM

LGTM

LGTM, and thanks to you and everyone else for all the effort that went into making this a reality.

LGTM

LGTM

LGTM

LGTM

LGTM

Fixed by 90ffb7c806c049ececeb2c6ce7fa0dbb056ae4ca


test

@henry2004y Sorry, the target repo is wrong. I originally wanted to test on my own fork. This PR will be closed.


Unexpected \ esacpe in json

Step to reproduce:

Enter agent edit page
Click on Toggle View, enter raw json edit mode
Edit some field so it contains \

Click on Toggle View (Enter visual edit mode), then Click on Toggle View again (enter raw json edit mode)

Expected: message is still a\nb
Actual: message becomes a\\nb

Or even worse:

Create a new agent, enter raw json edit mode, edit, carefully not to click on "Toggle View"
Save the agent
Edit the agent, do nothing, save the agent again

Expected: message is still a\nb
Actual: message becomes a\\nb

The same behavior can be observed on https://andrewcantino.com/examples/jsoneditor/example.html
I'm not sure if it's a bug or feature, but if it's a feature, it's better to have an option to disable it.

Ohboi, escaping is always fun! 😄
I am not sure if this really is a bug. I am testing it with a TriggerAgent:
{
  "expected_receive_period_in_days": "2",
  "keep_event": "false",
  "rules": [
    {
      "type": "regex",
      "value": "\\d+\\n",
      "path": "message"
    }
  ],
  "message": "Looks like your pattern matched in '{{value}}'!"
}

Editing the configuration with the "GUI" editor works as expected, I put in  \d+\n` as my regular expression.
Sending this Event to the Agent properly triggers:
{
  "message": "31213\\n"
}

My use case is that I'm trying to create some twitter publish automation in huginn.
What I want is (text showed in Twitter)
title
content

In Twitter Publish Agent, If I set to
{
  "expected_update_period_in_days": "30",
  "message": "{{title}}\n{{content}}"
}

It would work as I expected. But the escape "feature" often makes my config
{
  "expected_update_period_in_days": "30",
-  "message": "{{title}}\n{{content}}"
+  "message": "{{title}}\\n{{content}}"
}

So the output would become (text showed in Twitter)
title\ncontent

As you can see, the escape problem really bugs me.

Editing the configuration with the "GUI" editor works as expected, I put in \d+\n` as my regular expression.

The current escape feature is helpful when dealing with regexp, but not ideal if you want to deal with control characters, which in my case, line feeds.(\n)

I see, to be honest I am surprised that "{{title}}\n{{content}}" works, as far as I know it should be invalid JSON. If you want to insert an actual line break character you can use the {% line_break %} Liquid tag.

as far as I know it should be invalid JSON

It's a valid JSON. You can't put the actual line feed character ( the character you input by pressing the Enter button ) inside JSON strings, instead, you have to put \n.
So,
{
"message": "{{title}}
{{content}}"
}

is invalid, and
{
"message": "{{title}}\n{{content}}"
}

is valid.

If you want to insert an actual line break character you can use the {% line_break %} Liquid tag.

Thanks for the tip! It sounds like a variable workaround, but I think the current escape behavior still needs some polish.

@dsander If it's not a bug, you can see bug-dom from there.  It can break saving agents sometimes, more often it messes up output because you see lots of \n's in the text you get.

@virtadpt Sorry, I don't follow.
@whtsky

```json
"message": "{{title}}
{{content}}"
}

is invalid, and

Exactly my point if we would "convert" \n (the string) into a line break before parsing the JSON in the backend it would be invalid JSON.
The JSON editor always returns string, so \n is never converted to a line break. I think it converts \n to \\n when switching from the GUI to the raw JSON because a string like "{\"test\": \"one\ntwo\"}" would be invalid JSON.

I'm not proposing huginn to convert \n(\x5c\x6e) into the real line break (\x0a), but saying the current GUI always convert \n(\x5c\x6e) into \\n(\x5c\x5c\x6e), which is a bug IMO.

Click Toggle View

Click Toggle View again, I WOULD EXPECT message still be a\nb, but instead:

I still think it's doing what it is supposed to do, what I don't understand is why it does not complain about invalid JSON when you enter
{
"message": "{{title}}\n{{content}}"
}

as the RAW json because the same string isn't valid when passed to JSON.parse in JavaScript:
JSON.parse("{\"message\": \"{{title}}\n{{content}}\"}")

VM513:1 Uncaught SyntaxError: Unexpected token
 in JSON at position 22
    at JSON.parse (<anonymous>)
    at <anonymous>:1:6

So I am assuming it converts \n to \\n before parsing the JSON.
What is interesting is that JavaScript and Ruby parses JSON differently:
JSON.parse("{\"message\": \"{{title}}\\n{{content}}\"}")
{message: "{{title}}↵{{content}}"}

irb(main):003:0> JSON.parse("{\"message\": \"{{title}}\\n{{content}}\"}")
=> {"message"=>"{{title}}\n{{content}}"}

I see.
"{\"message\": \"{{title}}\n{{content}}\"}" is
{"message": "{{title}}
{{content}}"}

, which is invalid json.

(I'm not familier with Ruby, sorry. Ruby should has the same output.)

The correct string represent should be "{\"message\": \"{{title}}\\n{{content}}\"}"

"{\"message\": \"{{title}}\n{{content}}\"}" is
{"message": "{{title}}
{{content}}"}

, which is invalid json.

Yes, so I think the JSON editor works around that error by injecting the additional \. But the way I see it the outcome doesn't really change because when the JSON is parsed in ruby the result is \n (the string) again.

{
  "message": "a\nb"
}

is a VALID json.
{
  "message": "a
b"
}

is a INVALID json.

When I create a agent with options
{
"expected_update_period_in_days": "10",
"message": "a\nb"
}

Huginn stores it as
"{\n\"expected_update_period_in_days\": \"10\",\n\"message\": \"a\\nb\"\n}"

Which can be parsed into a valid JSON.

What the JSON editor doing now, is change
{
  "message": "a\nb"
}

Into
{
  "message": "a\\nb"
}

You can try to create a RSS Agent and set the url to https://www.douban.com/feed/people/whtsky/interests
Full options:
{
  "expected_update_period_in_days": "30",
  "clean": "false",
  "url": "https://www.douban.com/feed/people/whtsky/interests"
}

then run it. See the events it created.

As you can see, there are a lot of \n (TEXT) inside the payload(which is a JSON). And it's a valid JSON. That's what I'm talk about.

https://gist.github.com/whtsky/0e0a1c1f20850953356678ffe627eff1#file-a-really-valid-json You can try to download this file and parse it in Ruby. Ruby should parse it without any complains.

Sorry I totally ignored the fact the saving the JSON in the plain text field actually saves it as \n in the database, for some reason I was under the impression that it also gets converted before the data is submitted.
https://github.com/cantino/jsoneditor/commit/2be5d5bb9e146b4c21ddfea78602addfeb6e81c8 this seems to be the commit that introduced the escaping. My suspicion is that the escaping is done because of the way JSON.parse works in JavaScript:
{
  "message": "a\nb"
}

> JSON.parse($("#agent_options").val())
{message: "a↵b"}

If the contents of message would then be put into the GUI editor it would contain an actual line break (which isn't possible because the fields only support a single line).
At some point the contents of the fields are encoded again which results in the double \.
In short, I am now convinced that you are right and it is a bug, but I don't know if we can fix it. If we would change the behavior editing an Agent would change the configuration without the user doing anything. With the bug fixed having a\nb in the GUI editor would actually be saved as a\nb and not as a\\nb how it's currently done.

If the contents of message would then be put into the GUI editor it would contain an actual line break (which isn't possible because the fields only support a single line).

I understand it's hard to fix this without doing break change to the current escape behavior.
The most feasible way I can think of is to use textarea instead: https://jsfiddle.net/Lr70fq94/1/ .
https://github.com/cantino/jsoneditor looks like a javascript project but the Gemfile part looks scary to me :(

I don't think we have to use a text area, we would need to change the escape logic here. The main issue I have with it is that I have no clue why it was added in the first place :/.
I think the project uses ruby to run the tests and compile coffescript to javascript.


Fix directory path to clean modules before installation

After restart driver-container or host system, the container fails to install driver because old module exists.
log:
ERROR: The file '/lib/modules/5.19.0-32-generic/kernel/drivers/video/nvidia.ko' already exists as part of this driver installation.

So I fix directory path to clean modules before driver installation.

Hi @khakimosaic GitHub is a mirror, you are welcome to contribute at https://gitlab.com/nvidia/container-images/driver

GitHub is a mirror, please contribute via GitLab
/close


Detect the managed instance group that created a VM

In preparation for new resource attributes for the MIG.

Code changes LGTM.  Please document the steps you took to manually test this PR in the description before merging.


Fixed and working russian localization

I fixed the encoding and now the translation runs properly. Hope this would go

I'm sorry, had no time earlier
All changes done

Merged, thank you for your work. If all works well, it'll be part of the next update. Would you like to be credited as Kelzon212?

Thank you! Just Kelzon please
If there be any bugs or changes, please let me know


Missing port number before /api in URLs

Default management port is 15672 which should be included in the URLs as in MariuszWojcik's implementation.

Hi there!
This was intentional and one of reasons for the fork (you can see a list of initial changes here).  Hard coding the port makes it tough for folks who use a different port, for example.
Cheers!

Hi, thanks for the clarification.
How should one be using this then for the default case when you do have it on port 15672?

Never mind, I'll go with the original implementation from Mariusz.

No problem!
You just include it in the BaseUri parameter:
-BaseUri "https://rabbitmq.contoso.com:15671" or `-BaseUri "http://rabbitmq.contoso.com:15672", for example.
The SSL bit was important for us, hence the change
Cheers!


Terminal: ctrl + A in find widget should select all text in find widget not terminal

Open terminal, open find widget
Ctrl / Cmd + A = all text in terminal gets selected
I would expect only the text in the find widget gets selected, same as in the find widget in the editor

/cc @rebornix @cleidigh

Should be fixed by this commit.

Fixed in https://github.com/Microsoft/vscode/pull/33935, thanks @ihalip 😄


TableViz raise Unexpected error when table include null value

Make sure these boxes are checked before submitting your issue - thank you!

[x] I have checked the superset logs for python stacktraces and included it here as text if any
[x] I have reproduced the issue with at least the latest released version of superset
[x] I have checked the issue tracker for the same issue and I haven't found one similar

when table include number type columns and the value is null , The TableViz cannot display this table when these columns be selected in NOT GROUPED BY
Superset version
0.26.3 On centos7  + Python 3.6.5
Expected results
Actual results
Unexpected error.
Steps to reproduce
Table DDL:
 CREATE TABLE testt (   id int(11) NOT NULL AUTO_INCREMENT,   name varchar(255) DEFAULT NULL,   value int(255) DEFAULT NULL,   PRIMARY KEY (id) ) ENGINE=InnoDB AUTO_INCREMENT=5 DEFAULT CHARSET=utf8;
Data:

id
name
value

1
aaa
1

2
bbb

3
ccc
3

4
ddd

And choose these three columns in TableViz's NOT GROUPED BY selector.

This is a duplicate of #5353

@Wujiao233 This was reported on 0.26.3 but the PR is against master, can you verify that you are able to get the same error on master also?

the master is ok...but i think it's not a good idea to fill number type null to 0 .In some case null is not mean 0 .

@Wujiao233 this issue has been resolved and can be closed


[import] AWS autoscaling group import and subsequent up tries to fix defaults to actual default values

What happened?
I imported an autoscaling group with pulumi import, added the generated code to the pulumi program, and issued pulumi preview.
Expected: no changes.
Actual: pulumi insists on fixing some properties that are set to "Default" in the cloud reality to their respective actual default values. This is undesirable.
      + forceDelete                  : false
      + forceDeleteWarmPool          : false
      + ignoreFailedScalingActivities: false
      + waitForCapacityTimeout       : "10m"

I inspected the state using pulumi stack export, and all these properties are null in the state after import, and they are not specified in code either. If the state says null and the cloud reality says "Default" (as an option selected in a select widget in the AWS Console), and the program says nothing, then where does false or "10m" even come from?
Example
Import command:
pulumi import --generate-code 'aws:autoscaling/group:Group' platform Infra-ECS-Cluster-zaffre-37cd4e5b-ECSAutoScalingGroup-982zexeihkOe

Generated code:
import * as pulumi from "@pulumi/pulumi";
import * as aws from "@pulumi/aws";

const platform = new aws.autoscaling.Group("platform", {
    availabilityZones: ["eu-central-1a"],
    defaultCooldown: 300,
    healthCheckGracePeriod: 0,
    healthCheckType: "EC2",
    launchTemplate: {
        id: "lt-0789d9b35b0a9d959",
        version: "$Latest",
    },
    maxSize: 2,
    minSize: 0,
    name: "Infra-ECS-Cluster-zaffre-37cd4e5b-ECSAutoScalingGroup-982zexeihkOe",
    serviceLinkedRoleArn: "arn:aws:iam::164629628951:role/aws-service-role/autoscaling.amazonaws.com/AWSServiceRoleForAutoScaling",
    tags: [
        {
            key: "AmazonECSManaged",
            propagateAtLaunch: true,
            value: "",
        },
        {
            key: "Name",
            propagateAtLaunch: true,
            value: "ECS Instance - zaffre",
        },
    ],
}, {
    protect: true,
});

Output of pulumi about
CLI
Version      3.131.0
Go Version   go1.23.0
Go Compiler  gc

Plugins
KIND      NAME    VERSION
resource  aws     6.51.0
resource  aws     6.51.0
resource  awsx    2.14.0
resource  awsx    2.14.0
resource  docker  4.5.5
resource  docker  4.5.5
resource  docker  3.6.1
resource  docker  3.6.1
language  nodejs  unknown

Host
OS       arch
Version  "rolling"
Arch     x86_64

This project is written in nodejs: executable='/home/rulatir/projects/zaffre/internment/nave/store/installed/node-modern/bin/node' version='v22.2.0'

Current Stack: organization/zuu-iac/permanent

TYPE                                   URN
[REDACTED]

Found no pending operations associated with permanent

Backend
Name           berbelek
URL            s3://zuu-iac/attempts/PPM
User           rulatir
Organizations
Token type     personal

Pulumi locates its logs in /tmp by default
warning: Failed to get information about the Pulumi program's dependencies: could not find either /home/rulatir/projects/zaffre/cloud/attempts/PPM/yarn.lock or /home/rulatir/projects/zaffre/cloud/attempts/PPM/package-lock.json

Note about the last warning: I chose pnpm during pulumi new; it seems pulumi about can't handle that yet.
Additional context
No response
Contributing
Vote on this issue by adding a 👍 reaction.
To contribute a fix for this issue, leave a comment (and link to your pull request, if you've opened one already).

Can this be worked around somehow? I must emphasize that by "work around" I don't mean "give up", i.e. "just let pulumi fix those defaults".

Hey @rulatir sorry you're running into this! This seems to be a regression caused by a recent change that was rolled out in v6.51.0.
It is tracked here: https://github.com/pulumi/pulumi-terraform-bridge/issues/2372.
As a workaround you could roll back to v6.50.1 of the provider.
Alternatively, running pulumi up should align the state without modifying the cloud resource. None of those parameters are part of the cloud state of that resource:

forceDelete and forceDeleteWarmPool are inputs for the DeleteAutoScalingGroup and DeleteWarmPool API calls.
ignoreFailedScalingActivities and waitForCapacityTimeout  are provider level settings for how to handle updates to the Auto Scaling Groups

I upgraded to 6.54.0 and tried to run pulumi preview on the code/state/cloud reality combo that hasn't been touched since I ran into this issue and got stuck. I expected to get unstuck. I did not: I got the exact same update plan as previously, with pulumi declaring that it WOULD, as opposed to ABSOLUTELY WOULDN'T, attempt to immediately modify ASGs that were just imported and the generated code was added to the program. Therefore the issue is not fixed. Please reopen.
(Perhaps the problem is that an already imported resource is tied to the provider version in the state, and you can't upgrade the provider first and only then use the new provider to do the actual work - these steps cann't be decoupled. That would be a huge architectural issue with Pulumi if true, because it would effectively mean that it is simply impossible to "fix" state by upgrading to a provider version that that fixes the issue.)
  pulumi:pulumi:Stack: (same)
    [urn=urn:pulumi:permanent::zuu-iac::pulumi:pulumi:Stack::zuu-iac-permanent]
    ~ aws:autoscaling/group:Group: (update)
        [id=Infra-ECS-Cluster-zaffre-37cd4e5b-ECSAutoScalingGroup-982zexeihkOe]
        [urn=urn:pulumi:permanent::zuu-iac::aws:autoscaling/group:Group::platform]
        [provider: urn:pulumi:permanent::zuu-iac::pulumi:providers:aws::default_6_51_0::3a397c39-393f-49e9-8fee-b34c39d39065 => urn:pulumi:permanent::zuu-iac::pulumi:providers:aws::default_6_54_0::output<string>]
      + forceDelete                  : false
      + forceDeleteWarmPool          : false
      + ignoreFailedScalingActivities: false
      + waitForCapacityTimeout       : "10m"
    ~ aws:autoscaling/group:Group: (update)
        [id=Infra-ECS-Cluster-zaffre-mongodb-682cc63e-ECSAutoScalingGroup-tznhtknUgPkL]
        [urn=urn:pulumi:permanent::zuu-iac::aws:autoscaling/group:Group::mongodb]
        [provider: urn:pulumi:permanent::zuu-iac::pulumi:providers:aws::default_6_51_0::3a397c39-393f-49e9-8fee-b34c39d39065 => urn:pulumi:permanent::zuu-iac::pulumi:providers:aws::default_6_54_0::output<string>]
      + forceDelete                  : false
      + forceDeleteWarmPool          : false
      + ignoreFailedScalingActivities: false
      + waitForCapacityTimeout       : "10m"

[provider: urn:pulumi:permanent::zuu-iac::pulumi:providers:aws::default_6_51_0

Pulumi's using a provider version 5.61.0 here that doesn't have the fix yet. Would it be possible to upgrade to 6.54.0 before proceeding?

I assumed that's just recorded reference to the version the resource's representation in the state was created with.
I updated the provider with pnpm and @pulumi/aws is now at 5.64 in package.json. Additionally, when I first ran pulumi preview after doing that, it further installed something with 5.64 in it. I honestly thought I'd done due dilligence upgrading the provider at that point. What else does it take? Does Pulumi keep all previous versions of the provider, and a resource's state entry is forever tied to the version that created it, until I delete the resource from the state and re-import it?

IN some cases Pulumi uses the provider version that's written into your state to manage the said resource. Do you have references to 6.51.0 in pulumi stack export? You can edit that manually, or is possible just do pulumi up on the new version accepting the diff above and that should move that forward.

"The diff above" tries to fix properties that are either not even shown in the AWS console for this resource, or set to "Default". "Default" is semantically distinct from any concrete value. It must be assumed to mean "Auto", unless it is thoroughly and bindingly documented that the meaning of "Default" for that particular property of that particular resource type is in fact some specific value that does not depend on unknown other properties of this or related resources, or on unknown logic that computes the effective value from those inputs.

For this particular resource, and these particular values, there will be no difference to your cloud in accepting the diff as TF code will populate these values anyway before doing Create/Update calls. I'm starting to think that the evidence points to the bug is indeed fixed in the latest version of the provider, but since stack editing is not working for you I'd recommend accepting the diff with pulumi up --yes.
   + forceDelete                  : false
      + forceDeleteWarmPool          : false
      + ignoreFailedScalingActivities: false
      + waitForCapacityTimeout       : "10m"

There is also https://github.com/pulumi/pulumi/issues/9878 that can be helpful to up-vote to prioritize making upgrades easier.  I think there isn't much else we can do for this case in pulumi-aws at the moment unfortunately.


Add a footer to a survey page

The footer will be populated using the contents of the survey:footer translatable key

TODO: Make it so that the footer sticks to the bottom of the page. My CSS skills are not good enough for this and I will focus on more pressing issues instead


using react-router-redux?

https://github.com/rackt/react-router-redux

https://github.com/rackt/react-router-redux/issues/257


Added link to documentation

Codecov Report

Merging #50 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master      #50   +/-   ##
=======================================
  Coverage   91.75%   91.75%
=======================================
  Files          22       22
  Lines        1553     1553
  Branches       93       93
=======================================
  Hits         1425     1425
  Misses        124      124
  Partials        4        4

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ea0f563...1b9a7ed. Read the comment docs.

Thank you!


Improve usage examples in README

Connects to #10

Looks good, and I'll approve, however I wonder if we should be auto-generating this from JSDoc annotations instead.

however I wonder if we should be auto-generating this from JSDoc annotations instead.

That would of course be preferable, but would make it more complicated to show off things like verification (as it's not a method that would have docs), and also splitting the quite noisy API docs from these examples. Or is there a beautifully easy way of doing this?

I believe you can include module-scope examples, while also provide some docs for the methods/properties, but definitely not high priority for now. We can experiment with it after v1.

Aye, sounds good.


Shorten the distance between Oy axis values

Documentation Is:

[X] Missing or needed?
[ ] Confusing
[ ] Not sure?

Please Explain in Detail...

Can you help me with some solutions to shorten the Oy axis when the values are too far apart?
Your Proposal for Changes

Can you help me shorten the Oy axis distance when my value has not reached 5000, to show the chart more clearly and have the 5000 line right above not too far away. Thanks !
My code:
[     {               borderColor: dataCrack?.data?.find(                 (el) => el.key === "colorChart"               )?.value,               data: generateDataChart(),               cubicInterpolationMode: "monotone",               lineTension: 3,               borderWidth: 2.5,               segment: segment,               spanGaps: true,               tension: 0.5,             },             {               label: Ngưỡng cao ${dataChart?.station?.split("/")[1]},               data: Array.from({ length: generateDataChart()?.length }, () =>                 Number(                   dataChart?.dataLow_High &&                     dataChart?.dataLow_High[0]?.value?.split(",")[4]                 )               ),               borderColor: colorHighLow.value,               lineTension: 0,               borderWidth: 1.5,               borderDash: [5, 5],               order: 0,             },]
Example
No response

For these kind of questions please head over to Stack overflow.
Chart.js automatically adjusts the scale to your data. Unless you give it a max yourself. Since you have this behavior it seems you are setting a max somewhere in your application.

Closing as per my above comment


CI: Remove building from Unit Test-Jobs

At the moment the compile-stages are kept pretty generic while language-specific builds are being executed during the Unit Test-Stage. In order to improve future scalability these two steps should be two separate jobs. This can be done in two ways:

Add an second build-stage which executes language-specific actions. Disadvantage: This increases the total duration as all jobs have to finish until the next stage can be started.
Nested jobs: If a Unit Test requires previous actions, split it into two jobs which are getting executed in sequence. This will allow in future to execute CPU-heavy tasks on a CPU-instance and GPU-tests on a GPU-instance.

Execution in separate jobs allows reusing the created artifacts if multiple jobs exist for the same language.
For examples consider looking in the Jenkinsfile at R: CPU/GPU, Scala: CPU and Perl: CPU/GPU (perl-package.test.sh).

Also consider splitting up tests like tests/python/unittest and tests/python/train in order to allow parallel execution.

@KellenSunderland

@marcoabreu I believe our existing Jenkins setup does this separation of unit test jobs for different language bindings.
Can this issue be closed then ?

This is still valid. Languages like scala, clojure, R and probably a few more compile their native counterparts and dependencies during unit test stage instead of compile stage.

Aah. I see. Thanks!


ImportError

hoymiles_modbus version:hoymiles_modbus-0.1.0
Python version: 3,9
Operating System: Armbian Bullseye

Description
python3 client.py
Traceback (most recent call last):
File "/hoymiles_modbus/hoymiles_modbus/client.py", line 8, in
from .datatypes import MicroinverterData, PlantData, _serial_number_t
ImportError: attempted relative import with no known parent package

Thank you for trying to use the code. However, it seems that you are trying to use it incorrectly. It is not a stand alone script but a library which can be used in some other project. Please check documentation to see how to install it and use  https://wasilukm.github.io/hoymiles_modbus/


Mathcomp 1.9.0 compatibility

This fixes compilation with Coq 8.10 and MathComp 1.9.0, while maintaining backwards compatibility. I also did some corresponding small quality-of-life updates to the OPAM files and Travis script.

Thanks!


Add jQuery 3 in package.json

Please add jquery || ^3.0 as a dependency in packages.json.

npm ERR! peer invalid<EMAIL_ADDRESS>|| ^2.0, required by<EMAIL_ADDRESS>👍

Please ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

npm shrinkwrap doesn't work without due to: npm ERR! peer invalid<EMAIL_ADDRESS>|| ^2.0, required by<EMAIL_ADDRESS> Please do add jQuery || ^3.0 as a dependency in packages.json.

+1

/cc @Eonasdan

ping

@Eonasdan
It seems like jQuery 3 is already in package.json but it was not published on npm,
npm install<EMAIL_ADDRESS>
Gives this warning message
+--<EMAIL_ADDRESS>`-- UNMET PEER DEPENDENCY<EMAIL_ADDRESS>
npm WARN<EMAIL_ADDRESS>requires a peer of<EMAIL_ADDRESS>|| ^2.0 but none was installed.

When i look into my project node_modules/eonasdan-bootstrap-datetimepicker/package.json i found this -
"dependencies": {
    "bootstrap": "^3.3",
    "jquery": "^1.8.3 || ^2.0",
    "moment": "^2.10",
    "moment-timezone": "^0.4.0"
  },

I don't know your how release on npm works. But only you (owner of this repo) can fix it.

We ended up cloning the repo and changing it in our branch until it's fixed.  Doesn't seem to be any errors using jQuery 3.0.

there

Great! Thank you so much for closing this issue and keeping the package alive.


edge case of getting address string from account address model

There is a bug when getting the address from the account address model.
Assume the address is 0x0111111111111111111111111111111111111111111111111111111111111111
The returned string would be 0x111111111111111111111111111111111111111111111111111111111111111
It is less than 1 character than the normal address because those 0 bytes after 0x prefix are trimmed.

Trim 0 is for normalization which follows Aptos official implementation.
If developers want to get 64 character length address, just do hex encoding to the address bytes to string


[MM-33900] Take into account  menu permissions

Summary
Menus weren't taking into a account if they could be shown individually
Ticket Link
MM-33900

/update-branch

/update-branch

/update-branch

Will try to auto merge this PR once all tests and checks are passing. This might take up to an hour.

Trying to auto merge this PR.

Pull Request successfully merged
SHA: 5a9f4cc08c7dd3710fd7f04e3ec04f1e7f43d863


Fix script exit on unrecognized date parsing

parse_date() did not work as intended because set -e pipefail caused
the script to exit immediately upon error. Since PARSED_DATE is verified
to exist after each attempt at parsing the date, it's safe to ignore the
error code.
coreutils is listed as a requirement for this script in the README.
Support gdate when coreutils is installed on BSD.

@rlf23240 - Would you like to review?

Sorry for late reply. I will be glad to help. Since you have merged the code, I will just open new issue if I find other bugs. Thank you again for your help.


Add deinit function

deinit is needed to allow soft reset when gc is enabled. In such case, need to clear roots upon soft reset otherwise lvgl would hold pointers to invalid addresses. See #1316

I think lv_deinit should ideally work without memory leaks outside of MicroPython. Currently, I don't see where heap memory is explicitly freed (this is important if LV_MEM_CUSTOM == 1). What do you think?

I think lv_deinit should ideally work without memory leaks outside of MicroPython. Currently, I don't see where heap memory is explicitly freed (this is important if LV_MEM_CUSTOM == 1). What do you think?

I was also thinking about similar things. lv_mem can be easily reset by a memset but with LV_MEM_CUSTOM all allocated needs to be freed one by one. It includes:

delete all objects
delete drivers
delete tasks
delete animations
free linked lists (task, animations, drivers)
etc

As Micropython also uses LV_MEM_CUSTOM won't it be a problem?

As Micropython also uses LV_MEM_CUSTOM won't it be a problem?

My guess is that MicroPython resets its heap on a soft reset, but we can't rely on everyone having that ability.

@embeddedt @kisvegabor,
On soft reset all gc RAM is freed, and as a result all lvgl root pointers are invalid.
If we don't clear them, lvgl crashes.
This is not specific to Micropython, but to any case lvgl is used with garbage collection.
If you want, we can put the memset in #if LV_ENABLE_GC.
This PR is not a full support for lvgl deallocation, but is is good enough for gc because all objects/drivers/... would be deallocated by gc automatically on soft reset.
If we want we can always extend this to support other custom memory allocators, but this PR is only a solution for #1316, not for the general case.

Fair enough.
We can merge it if @embeddedt also agrees.

This PR is not a full support for lvgl deallocation, but it is good enough for gc

In that case, we should add a note above lv_deinit explaining this. Otherwise, someone will use it, and wonder why not everything is actually being reset.

In that case, we should add a note above lv_deinit explaining this. Otherwise, someone will use it, and wonder why not everything is actually being reset.

If you want, we can put lv_deinit itself in #if LV_ENABLE_GC such that it would be available only when using gc.

That should work.

Actually, withLV_MEM_CUSTOM == 0 (probably the most common case) we can do a "real" deinit if lv_mem is also cleared, isn't it? See my commit above.
If so only a note should be added like:
"If LV_MEM_CUSTOM 1 you need to clean the heap manually."
What do you think?

Actually, withLV_MEM_CUSTOM == 0 (probably the most common case) we can do a "real" deinit if lv_mem is also cleared, isn't it? See my commit above.

Good idea.

If so, only a note should be added like:
"If LV_MEM_CUSTOM 1 you need to clean the heap manually."

Maybe worth adding an assert if someone tries to call deinit with LV_MEM_CUSTOM == 1 and LV_ENABLE_GC == 0.
btw what are all the other commits that you added other than cb8bf4740636abab12b582ebfd32f51ff4878fbd? seem unrelated?

Maybe worth adding an assert if someone tries to call deinit with LV_MEM_CUSTOM == 1 and LV_ENABLE_GC == 0.

And/or a warning?

btw what are all the other commits that you added other than cb8bf47? seem unrelated?

Accidentally I've pushed some dev-7.0 commits to master and things messed up...
I've reset master and added the commits from another branch (c64-test).
 Probably once I pulled dev-7.0 to master, fixed something and pushed it.

Maybe worth adding an assert if someone tries to call deinit with LV_MEM_CUSTOM == 1 and LV_ENABLE_GC == 0.

And/or a warning?

I think it should be either an error that stops execution, or simply put deinit inside #if such it wouldn't be available for someone who uses LV_MEM_CUSTOM == 1 and LV_ENABLE_GC == 0

Accidentally I've pushed some dev-7.0 commits to master and things messed up...

:laughing: that must happen from time to time.

or simply put deinit inside #if such it wouldn't be available for someone who uses LV_MEM_CUSTOM == 1 and LV_ENABLE_GC == 0

It seems the most error-proof solution to me.

It seems the most error-proof solution to me.

66c100770338e5972f9677dc1487480829ae1b2b

It's ok from my side.
@embeddedt ?

Thanks for fixing this. I really appreciate the effort. However, when I try to check out a fresh copy:
$ git clone --recurse-submodules https://github.com/littlevgl/lv_micropython.git
Cloning into 'lv_micropython'...
remote: Enumerating objects: 76715, done.
remote: Total 76715 (delta 0), reused 0 (delta 0), pack-reused 76715
Receiving objects: 100% (76715/76715), 53.05 MiB | 4.06 MiB/s, done.
Resolving deltas: 100% (55417/55417), done.
Submodule 'lib/asf4' (https://github.com/adafruit/asf4) registered for path 'lib/asf4'
Submodule 'lib/axtls' (https://github.com/pfalcon/axtls) registered for path 'lib/axtls'
Submodule 'lib/berkeley-db-1.xx' (https://github.com/pfalcon/berkeley-db-1.xx) registered for path 'lib/berkeley-db-1.xx'
Submodule 'lib/libffi' (https://github.com/atgreen/libffi) registered for path 'lib/libffi'
Submodule 'lib/lv_bindings' (https://github.com/littlevgl/lv_bindings.git) registered for path 'lib/lv_bindings'
Submodule 'lib/lwip' (https://git.savannah.gnu.org/r/lwip.git) registered for path 'lib/lwip'
Submodule 'lib/mbedtls' (https://github.com/ARMmbed/mbedtls.git) registered for path 'lib/mbedtls'
Submodule 'lib/mynewt-nimble' (https://github.com/apache/mynewt-nimble.git) registered for path 'lib/mynewt-nimble'
Submodule 'lib/nrfx' (https://github.com/NordicSemiconductor/nrfx.git) registered for path 'lib/nrfx'
Submodule 'lib/stm32lib' (https://github.com/micropython/stm32lib) registered for path 'lib/stm32lib'
Submodule 'lib/tinyusb' (https://github.com/hathach/tinyusb) registered for path 'lib/tinyusb'
Cloning into '/home/build/lv_micropython/lib/asf4'...
remote: Enumerating objects: 1520, done.
remote: Total 1520 (delta 0), reused 0 (delta 0), pack-reused 1520
Receiving objects: 100% (1520/1520), 1.75 MiB | 3.18 MiB/s, done.
Resolving deltas: 100% (928/928), done.
Cloning into '/home/build/lv_micropython/lib/axtls'...
remote: Enumerating objects: 1, done.
remote: Counting objects: 100% (1/1), done.
remote: Total 3191 (delta 0), reused 1 (delta 0), pack-reused 3190
Receiving objects: 100% (3191/3191), 3.81 MiB | 3.69 MiB/s, done.
Resolving deltas: 100% (2342/2342), done.
Cloning into '/home/build/lv_micropython/lib/berkeley-db-1.xx'...
remote: Enumerating objects: 270, done.
remote: Total 270 (delta 0), reused 0 (delta 0), pack-reused 270
Receiving objects: 100% (270/270), 332.23 KiB | 2.09 MiB/s, done.
Resolving deltas: 100% (127/127), done.
Cloning into '/home/build/lv_micropython/lib/libffi'...
remote: Enumerating objects: 12491, done.
remote: Total 12491 (delta 0), reused 0 (delta 0), pack-reused 12491
Receiving objects: 100% (12491/12491), 7.37 MiB | 4.55 MiB/s, done.
Resolving deltas: 100% (7833/7833), done.
Cloning into '/home/build/lv_micropython/lib/lv_bindings'...
remote: Enumerating objects: 41, done.
remote: Counting objects: 100% (41/41), done.
remote: Compressing objects: 100% (31/31), done.
remote: Total 1100 (delta 19), reused 26 (delta 10), pack-reused 1059
Receiving objects: 100% (1100/1100), 1.14 MiB | 3.45 MiB/s, done.
Resolving deltas: 100% (649/649), done.
Cloning into '/home/build/lv_micropython/lib/lwip'...
remote: Counting objects: 53114, done.
remote: Compressing objects: 100% (12606/12606), done.
remote: Total 53114 (delta 40017), reused 52862 (delta 39850)
Receiving objects: 100% (53114/53114), 10.17 MiB | 3.61 MiB/s, done.
Resolving deltas: 100% (40017/40017), done.
Cloning into '/home/build/lv_micropython/lib/mbedtls'...
remote: Enumerating objects: 11, done.
remote: Counting objects: 100% (11/11), done.
remote: Compressing objects: 100% (11/11), done.
remote: Total 95218 (delta 2), reused 3 (delta 0), pack-reused 95207
Receiving objects: 100% (95218/95218), 41.93 MiB | 3.91 MiB/s, done.
Resolving deltas: 100% (73629/73629), done.
Cloning into '/home/build/lv_micropython/lib/mynewt-nimble'...
remote: Enumerating objects: 124, done.
remote: Counting objects: 100% (124/124), done.
remote: Compressing objects: 100% (111/111), done.
remote: Total 37081 (delta 70), reused 17 (delta 5), pack-reused 36957
Receiving objects: 100% (37081/37081), 10.80 MiB | 3.56 MiB/s, done.
Resolving deltas: 100% (22269/22269), done.
Cloning into '/home/build/lv_micropython/lib/nrfx'...
remote: Enumerating objects: 1882, done.
remote: Total 1882 (delta 0), reused 0 (delta 0), pack-reused 1882
Receiving objects: 100% (1882/1882), 3.16 MiB | 4.00 MiB/s, done.
Resolving deltas: 100% (1478/1478), done.
Cloning into '/home/build/lv_micropython/lib/stm32lib'...
remote: Enumerating objects: 3191, done.
remote: Total 3191 (delta 0), reused 0 (delta 0), pack-reused 3191
Receiving objects: 100% (3191/3191), 10.42 MiB | 3.98 MiB/s, done.
Resolving deltas: 100% (2449/2449), done.
Cloning into '/home/build/lv_micropython/lib/tinyusb'...
remote: Enumerating objects: 385, done.
remote: Counting objects: 100% (385/385), done.
remote: Compressing objects: 100% (214/214), done.
remote: Total 39260 (delta 208), reused 265 (delta 142), pack-reused 38875
Receiving objects: 100% (39260/39260), 27.33 MiB | 3.91 MiB/s, done.
Resolving deltas: 100% (27312/27312), done.
Submodule path 'lib/asf4': checked out 'd270f79aa16dd8fd4ae3b6c14544283dcb992e9c'
Submodule path 'lib/axtls': checked out '43a6e6bd3bbc03dc501e16b89fba0ef042ed3ea0'
Submodule path 'lib/berkeley-db-1.xx': checked out '35aaec4418ad78628a3b935885dd189d41ce779b'
Submodule path 'lib/libffi': checked out 'e9de7e35f2339598b16cbb375f9992643ed81209'
Submodule path 'lib/lv_bindings': checked out 'edf14fde6986a3cf943d25beeb06f211e94ed32e'
Submodule 'driver/png/lodepng' (https://github.com/lvandeve/lodepng.git) registered for path 'lib/lv_bindings/driver/png/lodepng'
Submodule 'lvgl' (https://github.com/littlevgl/lvgl.git) registered for path 'lib/lv_bindings/lvgl'
Submodule 'micropython/pycparser' (https://github.com/eliben/pycparser.git) registered for path 'lib/lv_bindings/pycparser'
Cloning into '/home/build/lv_micropython/lib/lv_bindings/driver/png/lodepng'...
remote: Enumerating objects: 85, done.
remote: Counting objects: 100% (85/85), done.
remote: Compressing objects: 100% (58/58), done.
remote: Total 722 (delta 50), reused 49 (delta 27), pack-reused 637
Receiving objects: 100% (722/722), 1.04 MiB | 4.02 MiB/s, done.
Resolving deltas: 100% (479/479), done.
Cloning into '/home/build/lv_micropython/lib/lv_bindings/lvgl'...
remote: Enumerating objects: 28, done.
remote: Counting objects: 100% (28/28), done.
remote: Compressing objects: 100% (28/28), done.
remote: Total 24676 (delta 8), reused 2 (delta 0), pack-reused 24648
Receiving objects: 100% (24676/24676), 16.97 MiB | 3.96 MiB/s, done.
Resolving deltas: 100% (19701/19701), done.
Cloning into '/home/build/lv_micropython/lib/lv_bindings/pycparser'...
remote: Enumerating objects: 5, done.
remote: Counting objects: 100% (5/5), done.
remote: Compressing objects: 100% (5/5), done.
remote: Total 2412 (delta 0), reused 1 (delta 0), pack-reused 2407
Receiving objects: 100% (2412/2412), 1.07 MiB | 3.23 MiB/s, done.
Resolving deltas: 100% (1623/1623), done.
Submodule path 'lib/lv_bindings/driver/png/lodepng': checked out '2e541f53ebedf6ebae375a381ca2fd6d82b460bc'
error: Server does not allow request for unadvertised object bac66172ea89e3ed101548f893277b987afe58f5
Fetched in submodule path 'lib/lv_bindings/lvgl', but it did not contain bac66172ea89e3ed101548f893277b987afe58f5. Direct fetching of that commit failed.
Submodule path 'lib/lwip': checked out '159e31b689577dbf69cf0683bbaffbd71fa5ee10'
Submodule path 'lib/mbedtls': checked out '3f8d78411a26e833db18d9fbde0e2f0baeda87f0'
Submodule 'crypto' (https://github.com/ARMmbed/mbed-crypto) registered for path 'lib/mbedtls/crypto'
Cloning into '/home/build/lv_micropython/lib/mbedtls/crypto'...
remote: Enumerating objects: 10, done.
remote: Counting objects: 100% (10/10), done.
remote: Compressing objects: 100% (10/10), done.
remote: Total 80514 (delta 3), reused 2 (delta 0), pack-reused 80504
Receiving objects: 100% (80514/80514), 22.99 MiB | 4.06 MiB/s, done.
Resolving deltas: 100% (65106/65106), done.
Submodule path 'lib/mbedtls/crypto': checked out 'a78c958b17d75ddf63d8dd17255b6379dcbf259f'
Submodule path 'lib/mynewt-nimble': checked out '223714cb16c255cfa701929c0de6d7579bfd2cdd'
Submodule path 'lib/nrfx': checked out '7513fc9d5c10dc28b25bf2bb6ff0ba66cb2a3c3d'
Submodule path 'lib/stm32lib': checked out '668d7a9e54aea98f8fe8a858eac1d3daa80fa824'
Submodule path 'lib/tinyusb': checked out '393492823ce037a2e46d367d61fad1235859af2e'
Submodule 'hw/mcu/microchip/samd/asf4' (https://github.com/adafruit/asf4.git) registered for path 'lib/tinyusb/hw/mcu/microchip/samd/asf4'
Submodule 'hw/mcu/nordic/nrfx' (https://github.com/NordicSemiconductor/nrfx.git) registered for path 'lib/tinyusb/hw/mcu/nordic/nrfx'
Submodule 'hw/mcu/nxp/lpcopen' (https://github.com/hathach/lpcopen.git) registered for path 'lib/tinyusb/hw/mcu/nxp/lpcopen'
Submodule 'hw/mcu/st/stm32lib' (https://github.com/hathach/stm32lib.git) registered for path 'lib/tinyusb/hw/mcu/st/stm32lib'
Submodule 'tools/uf2' (https://github.com/microsoft/uf2.git) registered for path 'lib/tinyusb/tools/uf2'
Cloning into '/home/build/lv_micropython/lib/tinyusb/hw/mcu/microchip/samd/asf4'...
remote: Enumerating objects: 1520, done.
remote: Total 1520 (delta 0), reused 0 (delta 0), pack-reused 1520
Receiving objects: 100% (1520/1520), 1.75 MiB | 3.62 MiB/s, done.
Resolving deltas: 100% (928/928), done.
Cloning into '/home/build/lv_micropython/lib/tinyusb/hw/mcu/nordic/nrfx'...
remote: Enumerating objects: 1882, done.
remote: Total 1882 (delta 0), reused 0 (delta 0), pack-reused 1882
Receiving objects: 100% (1882/1882), 3.16 MiB | 4.34 MiB/s, done.
Resolving deltas: 100% (1478/1478), done.
Cloning into '/home/build/lv_micropython/lib/tinyusb/hw/mcu/nxp/lpcopen'...
remote: Enumerating objects: 1286, done.
remote: Total 1286 (delta 0), reused 0 (delta 0), pack-reused 1286
Receiving objects: 100% (1286/1286), 5.35 MiB | 3.84 MiB/s, done.
Resolving deltas: 100% (724/724), done.
Cloning into '/home/build/lv_micropython/lib/tinyusb/hw/mcu/st/stm32lib'...
remote: Enumerating objects: 2362, done.
remote: Total 2362 (delta 0), reused 0 (delta 0), pack-reused 2362
Receiving objects: 100% (2362/2362), 8.53 MiB | 3.89 MiB/s, done.
Resolving deltas: 100% (1853/1853), done.
Cloning into '/home/build/lv_micropython/lib/tinyusb/tools/uf2'...
remote: Enumerating objects: 12, done.
remote: Counting objects: 100% (12/12), done.
remote: Compressing objects: 100% (12/12), done.
remote: Total 380 (delta 2), reused 9 (delta 0), pack-reused 368
Receiving objects: 100% (380/380), 110.91 KiB | 1.44 MiB/s, done.
Resolving deltas: 100% (193/193), done.
Submodule path 'lib/tinyusb/hw/mcu/microchip/samd/asf4': checked out '82fe3aa05bc3b9f4956ee775c748a3885443f66b'
Submodule path 'lib/tinyusb/hw/mcu/nordic/nrfx': checked out '9d68726e41c321f1772c187bd12d82f5b13104f1'
Submodule path 'lib/tinyusb/hw/mcu/nxp/lpcopen': checked out '06b4c2e509147924b66ace90f6be5ebe599af45c'
Submodule path 'lib/tinyusb/hw/mcu/st/stm32lib': checked out '1dabc2df8ed1acaf0c483b58d757ba72e8b42090'
Submodule path 'lib/tinyusb/tools/uf2': checked out '19615407727073e36d81bf239c52108ba92e7660'
Submodule 'hidapi' (https://github.com/signal11/hidapi) registered for path 'lib/tinyusb/tools/uf2/hidapi'
Cloning into '/home/build/lv_micropython/lib/tinyusb/tools/uf2/hidapi'...
remote: Enumerating objects: 2006, done.
remote: Total 2006 (delta 0), reused 0 (delta 0), pack-reused 2006
Receiving objects: 100% (2006/2006), 2.73 MiB | 4.03 MiB/s, done.
Resolving deltas: 100% (1172/1172), done.
Submodule path 'lib/tinyusb/tools/uf2/hidapi': checked out 'a6a622ffb680c55da0de787ff93b80280498330f'
Failed to recurse into submodule path 'lib/lv_bindings'

The dangers of git submodules I guess. :/

@amirgon on dev-7.0 I got this error:
/lv_misc/lv_gc.c:10:
In function ‘memset’,
    inlined from ‘lv_gc_clear_roots’ at /home/kisvegabor/projects/littlevgl/eclipse-workspace/pc_simulator_sdl_eclipse/lvgl/tests/../src/lv_misc/lv_gc.c:49:5:
/usr/include/x86_64-linux-gnu/bits/string_fortified.h:71:10: error: ‘__builtin___memset_chk’ writing 16 bytes into a region of size 0 overflows the destination [-Werror=stringop-overflow=]
   return __builtin___memset_chk (__dest, __ch, __len, __bos0 (__dest));
          ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

I've traced that it's because of f(lv_mem_buf_t, _lv_mem_buf[LV_MEM_BUF_MAX_NUM]). In LV_CLEAR_ROOT it's expanded to
memset(&_lv_mem_buf[LV_MEM_BUF_MAX_NUM], 0, sizeof(_lv_mem_buf[LV_MEM_BUF_MAX_NUM])) which is not correct.
Should we add another list for arrays?

Should we add another list for arrays?

@kisvegabor I think this can be handled in the same list of root pointers with some preprocessor tricks.
I'll look into it in the evening.

@kisvegabor I think this can be handled in the same list of root pointers with some preprocessor tricks.
I'll look into it in the evening.

@kisvegabor Another option is to use typedef. Could be nicer than preprocessor tricks.

Merged, thank you!


make DBMS_CRYPTO optional

Resolves #5
Add a sqlplus define to install.sql and use sqlplus syntax to conditionally compile xutl_offcrypto with a plsql_ccflags setting to remove references to encryption from ExcelGen package.
The added complexity of install.sql may not suit. If not, I would be happy to create "install_nocrypto.sql" instead. That would eliminate dependence on sqlplus tricks for conditional compilation. The plsql_ccflags conditional compilation would remain.

Sorry, late reply.
Indeed I would prefer a dedicated install_nocrypto script. Thanks.

As you asked, reverted install.sql and added install_nocrypto.sql. Updated README.md with reference to it and added an entry in ChangeLog section.
I ran both install.sql and install_nocrypto.sql. Both compile fine. I've been ExcelGen without DBMS_CRYPTO in a production environment for serveral months with no issues.
PS
I wish there was a less convoluted way to do conditional compilation in sqlplus, but that trick with sqlplus COLUMN variable is how Oracle does it in release code. I agree it is too weird to throw around lightly and concur this is a less confusing way to do it.


Analytics SDK breaks with latest Core SDK via Carthage

Coverage remained the same at 82.278% when pulling 7c9c19e6f0cebc436d217ff6c3304be6098e360a on mohlogan_carthge into 7257aff0f30381c96f4ee043f6644240411e36a8 on development.


Hi! When I configured an ssl it shows me an error. In logs it shows failed connection handshake. Is there any workaround ?

Hi @webslayer! Thanks for reporting this issue. Please send your error log.


build_stubbed vs build performance and preference in usage

FactoryBot are used with option FactoryBot.use_parent_strategy = true
Which one build_stubbed or build is it preferable to use and why?
Are there any proofs build_stubbed is faster than build or vise versa?

build will initialize your object, but will not save it. build_stubbed is similar but does some extra work to ensure that you don't call any methods that hit the database.
build_stubbed is going to be a tiny bit slower because of the extra work it has to do, but you can be more confident you wont accidentally hit the database (which is really slow).


Allow custom footer

Fixed in https://github.com/zhe/hugo-theme-slim/pull/4/commits/e9f43e50204ffa3811b27066167d956f6dce5ee7

Commit e9f43e5 breaks the theme. For my configuration where baseurl = "http://nosubstance.me" the site got broken with urls like <link rel="stylesheet" href="http://nosubstance.mecss/slim.css"> etc. I don't understand what this commit fixes.

Also, there are places now where { $.Site.BaseURL } is used, and others where {{ .Site.BaseURL }} is, not sure whether there's any difference, if not, I guess it's better be consistent.

Hi @oblitum, sorry for the inconvenient, but I couldn't reproduce your situation, my site is working well under the latest commit 8780f8e82275fd708d684377f9de6c37f2192ab0. Probably the url in the baseurl in your configuration should be end with / as shown in Hugo's documentation. Hopefully it will work for you.
And you're right that it's better to be consistent about {{ $.Site.BaseURL }} and {{ .Site.BaseURL }}, I think their output has no difference.

Hi @zhe, no problem. Thanks for the info. When I saw the behaviour I thought whether it was better to have or not to have an ending / at the configuration, but then, instead of checking docs I've checked other configuration samples online and saw that people were not in general adding that, so I assumed it was better to revert this commit locally instead of fixing the hugo configuration.


Run hmc5883 info will get nothing

Connect the pixhawk with USB and then open the terminal, run hmc5883 info will get nothing.
I am going to debug it.
Is there anyone have the same issue?

The internal mag is lsm303d not hmc5883.
run lsm303d info will get the info of the mag.


Revert cast of defaultdict to dict before return

Description
What is this PR

[x] Bug fix
[ ] Addition of a new feature
[ ] Other

Why is this PR needed?
defaultdict and dict behave slightly differently when new keys are created implicitly. Casting to a dict appears to disregard this behaviour, which is implicitly assumed in cellfinder's units.
What does this PR do?
Reverts the output of cells.cells.group_cells_by_z to be a defaultdict rather than a dict.
References

This will close cellfinder#235

How has this PR been tested?
See the debug branch https://github.com/brainglobe/cellfinder/pull/236.
According to the docs, defaultdict is a subclass of dict too so there is no reason for us to "cast" and loose the functionality of the subclass. If we really need to do this, it is better to set the default_factory member to be None rather than perform an explicit cast.
Is this a breaking change?
No.
Does this PR require an update to the documentation?
Nope.
Checklist:

[x] The code has been tested locally
[x] Tests have been added to cover all new functionality (unit & integration)
[x] The documentation has been updated to reflect any changes
[x] The code has been formatted with pre-commit

@willGraham01 you should be able to now.


Feature Request: Add Queue Listener for specific Message Session

Is it possible to add a queue listener for a specific message session?
Or more specific: Is it currently possible to register a message handler for specific sessions or as a fallback register a session handler together with respective handlers?
We use session enabled queues for handling semi synchronous request/response calls for some legacy applications and have currently some problems in production and would like to peek some messages that belong to only one of the running message sessions.
My workaround for that right now is to use a custom C# project for that but it would be really nice to have this functionality inside the Service Bus Explorer.
If I am not alone with this feature request I would try to take the time to prepare a PR for this as a base for further discussion.

Do you have the bandwidth to implement this feature and submit a PR? Thanks!

Do you have the bandwidth to implement this feature and submit a PR? Thanks!

I will give this a go!

I tried a minimalistic approach on implementing this feature and opened a PR for this (#470).
As I am a little bit rusty in writing code for WinForms please don't be gentle in your review.

Take your time @jcoeltjen no rush, and thanks for the contribution :)

Fixed in #470


mv: cleanup the code

The unimplemented option of mv is -Z/--context which is a Linux-specific option and I guess it can be ignored for the time being.

Looks good, can I suggest we not mark it as completed if we aren't sure it is completed?

Em... but we have precedent, e.g. mkdir. The Linux-specific options are not taken into consideration.

I did not know that, thanks for informing me. I guess that makes it more of a policy question, which for now can be regarded as outside the scope of/non-blocking for this PR.


Feature: Add error dialog and success dialog to DialogManager (Including localization) and use them instead of a normal dialog

Fixed by 4c46d80 commit

Fixed by 4c46d80 commit


Cool project!

Hi!
I'm currently brainstorming a little app for my Fadecandy and found this repo through Github search.
I'm excited to give this a go and see what kind of effects I can run on this thing!
I was wondering if you needed help with anything UI related, product related or need any graphic assets for the UI / any screens. Might be able to help out a little there!
Also, if you need some custom Bootstrap theme, I'm pretty good at Bootstrap!

Hello, thanks for checking out the project! Just saw this now, definitely let me know how setting up goes. Nobody except me has tried to run the setup yet, but I tried to make it easy, so I definitely want to know if it works and would love feedback for how to improve it.
I have a couple of open issues I could use some help with. If you know how to do UI stuff, you could take a look at #15, it's something I've had a vision for how it should work but not so much what it should actually look like.
Also, if you know how to make graphics I've been thinking that this needs a logo for a while now. It's not a huge priority or anything, but if you have any ideas I would love to check them out!
Let me know if you have any questions, comments, or suggestions :)

Also, if you want to just try using Webcandy without setting up your own dev environment first, I have a version running on AWS currently. You can use it by running the client and pointing it to the EC2 instance.
python client.py testuser1 Webcandy1 testclient1 --host <IP> --port 6543 --app-port 8080
If this is something you'd want to do, I can email you the elastic IP, just to not have it on public GitHub.

Hi!
I was able to whip up a logo real quick, following a very non-scientific process of trying out different fonts and keeping a theme of LED lights. See options 1-3 below:

For a more methodical approach for the logo and overall website style guide, we'd need to put together a Pinterest board containing some visual inspiration. For an example, see my board that I put together to inspire the visual look of https://drawingbots.net/ : https://pin.it/6fzm6kg3kx2fxv
If you let me know the overall direction / style, I might be able to narrow down a bit better on the concrete design.
Unfortunately I don't have time right now to set everything up locally, but if you could email me the EC2 IP and the command necessary to hook up the client, I can try this project soon. My email is same as my username + gmail.

I really like that second logo! Honestly, right now I don't have that much direction/style, but I've been using Bootstrap for as much of the (currently, minimal) UI, so there is a general color/style theme. Here is an image of what the site currently looks like:

I'd like to keep using the general Bootstrap theme, mainly for consistency and simplicity, so anything that can fit into that would work well. I've never done any formal UI design work, but I'd be happy to work with you fleshing out ideas via Pinterest.
I'll email you the EC2 details and connection instructions shortly. Thanks for your help!


ChocolateyGUI Icon

Hello,
ChocolateyGUI icon can't be loaded because of the icon file removed:
https://cdn.rawgit.com/chocolatey/choco/8b6217061a4efe6543622e903996bb8eac012db2/docs/images/Choco_Icon.png

@xmha97 thank you for raising this issue.  This has actually been addressed here:
https://github.com/chocolatey/ChocolateyGUI/issues/558
And it will ship in the next release of Chocolatey GUI.


Update and.js

[ ] Running yarn lint does not trigger any linter warnings
[ ] The test of the method you have fixed is passing
[ ] You have written a new skeleton method for someone else to work on!

Hey @HarrySystems  ! Thanks for your contribution.- we are stoked to have you on board. Unfortunately your pull request does not meet all of the criteria of our Contributing Guide. We will be closing out the pull request for the time being. Please follow the guidelines set out in CONTRIBUTING.md and reopen the pull request! Thanks


mailutils on 17.03 broken since 359c8c9d9a97307c5bc3f7ee53449424fe0cd5a1

Issue description
make[3]: Entering directory '/tmp/nix-build-mailutils-2.2.drv-0/mailutils-2.2/maidag'
for i in maidag; do
chown root:mail /nix/store/4xb7p9vd3h9p34a4hkllnjvxbvdlh3di-mailutils-2.2/sbin/$i;
chmod 4755 /nix/store/4xb7p9vd3h9p34a4hkllnjvxbvdlh3di-mailutils-2.2/sbin/$i;
done
chown: invalid group: 'root:mail'
chmod: changing permissions of '/nix/store/4xb7p9vd3h9p34a4hkllnjvxbvdlh3di-mailutils-2.2/sbin/maidag': Operation not permitted
make[3]: *** [Makefile:1284: install-exec-hook] Error 1
make[3]: Leaving directory '/tmp/nix-build-mailutils-2.2.drv-0/mailutils-2.2/maidag'
make[2]: *** [Makefile:1224: install-exec-am] Error 2
make[2]: Leaving directory '/tmp/nix-build-mailutils-2.2.drv-0/mailutils-2.2/maidag'
make[1]: *** [Makefile:1174: install-am] Error 2
make[1]: Leaving directory '/tmp/nix-build-mailutils-2.2.drv-0/mailutils-2.2/maidag'
make: *** [Makefile:1036: install-recursive] Error 1
builder for ‘/nix/store/w3ya6i3q1ld9qnby469ai09dx7g3cnxf-mailutils-2.2.drv’ failed with exit code 2
error: build of ‘/nix/store/w3ya6i3q1ld9qnby469ai09dx7g3cnxf-mailutils-2.2.drv’ failed
359c8c9d9a97307c5bc3f7ee53449424fe0cd5a1 is the first bad commit
commit 359c8c9d9a97307c5bc3f7ee53449424fe0cd5a1
Author: Robert Helgesson<EMAIL_ADDRESS>Date:   Tue Jul 18 00:58:20 2017 +0200
expat: 2.2.1 -> 2.2.2

(cherry picked from commit cc8e2aec299a002ede108dea1c33b1161f1aa180)

:040000<PHONE_NUMBER>a9a5b0909fd279e4dce2bf7af901857cf312 2ae14049aa91ce021e0db35a369fc7209a11e0b9 M  pkgs
bisect run success
Steps to reproduce
nix-build -A mailutils -I nixpkgs=https://nixos.org/channels/nixos-17.03/nixexprs.tar.xz
Technical details

System: NixOS: nixos-version 17.03.1584.48ecdcf598 (works on e.g. 2e983f1)
Nix version: (run nix-env --version) nix-env (Nix) 1.11.11
Nixpkgs version: (run nix-instantiate --eval '<nixpkgs>' -A lib.nixpkgsVersion) 17.09pre109180.0d4431cfe9
Sandboxing enabled: (run grep build-use-sandbox /etc/nix/nix.conf)
build-use-sandbox = false
(strange, I though I had sandbox enabled)
ok now tried with sandbox enabled
build-use-sandbox = true
still the same problem

strange, that commit doesn't seem somehow related
does git bisect work well with merges/pull-requests?

@globin Can we backport your mailutils bump & fixes?

Cherry-picked d339dc762c73564cfbd20ab6c9be803e9c12e1e0 into release-17.03. The mailutils project should build fine with that. I don't know why I showed up in the bisect but I think the expat bump was unrelated to this issue.


Profile page

The page must display the user the following data, and allow it to change the following data:
 CREATE TABLE userdata (
                                uid UUID PRIMARY KEY,
                                fname VARCHAR(10),
                                lname VARCHAR(10),
                                age INT,
                                profilepic VARCHAR(10),
                                FOREIGN KEY (uid) REFERENCES users(id)

Please give me the database structure for the user data


Allow download documents from document stores, or link to original source

Describe the feature you'd like
Flowise RAG allow provide the source of reference which is good, if possible I would like to provide the link to the source. Either from local file or remote source
My use case:

I uploaded many pdf (user guides) to document store
I feed the document store into RAG chatbot
When the chatbot provide answer and reference, it also indicate it come from which file and which page (which is implemented in flowise default prompt)
I wish to allow chatbot share the pdf to user, use can click the link to open the pdf

Additional context

this features implemented in ragflow, i think it is possible to do in flowise?

this is doable, will add to item to work on!

Related to that it would be great if file upload to the document store could be enabled without having to have a connected vector store that indexes the documents.
Our use-case is one where we want to upload files, and then forward URLs to access them to an external service via a custom tool call.

It would be great if it's possible to link to the source. We already have the source in the VectorStoreRetriever, but it seem like there is no way to pass the source to the context for the LLM to understand where it got the context from.

Any updates on this feature?


Informations of Pow-index.gem

Hi, Pow is really useful products for all Rack-app developer.
Recently, I created rubygem to make all Pow user more happy.
It provides index page of local projects accessible via Pow (and viewing index page is also dependent on Pow).
Moreover, easily cleanup invalid symbolic link in ~/.pow/ from browser.
Added informations and links about that gems to MANUAL.md

I'd suggest adding this to the Wiki.


PDCL-6598 Improved UX for editing item attributes within XDM Object data element.

Description
To demonstrate the UX issue, here are reproduction steps:
Here are the reproduction steps:

In the XDM Object data element view, click on an array field in the schema tree.
Click on "Add item" on the right hand side.
You should see "Item 1" now. Click "Item 1".

The right side of the view changes to show two radio buttons: "Provide individual attributes" and " Provide entire object". "Provide individual attributes" is selected, but it's not clear what the user is supposed to do at that point to actually provide the individual attributes. What we're expecting them to do is to click the attributes in the tree on the left and edit them that way, but that's just not clear to the user.
The solution provided in this PR consists of:

When select an array item in the array edit form OR select an item within the breadcrumb we display at the top of the form, we now automatically expand the corresponding node within the schema tree, and expand all its ancestor nodes, and scroll to the node so that it and all its child attributes are visible to the user.
On the object edit view, we now show a message that indicates the user can modify individual attributes by using the schema tree.
Whenever an item is selected by clicking a node in the schema tree, we expand the node to show its child fields. This part wasn't really necessary, but it did help make things consistent (that is, whenever an item gets selected through any means, the node in the tree gets expanded).

Related Issue
https://jira.corp.adobe.com/browse/PDCL-6598

Motivation and Context
I put this in the description because it gave proper context.

Screenshots (if appropriate):
Types of changes

[ ] Bug fix (non-breaking change which fixes an issue)
[x] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

[ ] My change requires a change to the documentation.
[ ] I have updated the documentation accordingly.
[x] All tests pass and I've made any necessary test changes.
[x] I've updated the schema in extension.json or no changes are necessary.

Thanks @jonsnyder. I've made the changes based on your feedback.

Thanks @jonsnyder. I've made the changes based on your feedback.

Thanks. Looks good.


RC2 and RTM sometimes not reading Azure App Service Custom Connection String

I'm facing very strange bug. It appears on production server and doesn't appear on dev server (it's totally 2 separate servers, not staging). Servers' settings are mostly same (except connection strings, Id+Secrets for socials and service plans).
I'm using VS 2015 Community and default studio publish tool.
My appsettings.json:
{
  "ApplicationInsights": {
    "InstrumentationKey": "my-app-insights-key"
  },
  "ConnectionStrings": {
    "DefaultConnection": "Server=(localdb)\\mssqllocaldb;Database=aspnet5-Profitcar-e722e405-069f-4355-b824-a3d3830748f6;Trusted_Connection=True;MultipleActiveResultSets=true",
    "StorageClient": "UseDevelopmentStorage=true"
  },
  "Logging": {
    "IncludeScopes": false,
    "LogLevel": {
      "Default": "Debug",
      "System": "Information",
      "Microsoft": "Information"
    }
  }
}

Affected parts of Startup.cs:
        public Startup(IHostingEnvironment env)
        {
            // Set up configuration sources.
            var builder = new ConfigurationBuilder()
                .SetBasePath(env.ContentRootPath)
                .AddJsonFile("appsettings.json", optional: true, reloadOnChange: true)
                .AddJsonFile($"appsettings.{env.EnvironmentName}.json", optional: true);

            if (env.IsDevelopment())
            {
                builder.AddUserSecrets();
                builder.AddApplicationInsightsSettings(developerMode: true);
            }

            builder.AddEnvironmentVariables();

            Configuration = builder.Build();
        }

        public void ConfigureServices(IServiceCollection services)
        {
            services.AddOptions();
            services.Configure<StorageClientOptions>(options =>
            {
                options.ConnectionString = Configuration.GetConnectionString("StorageClient");
            });
            services.AddApplicationInsightsTelemetry(Configuration);

            services.AddDbContext<ApplicationDbContext>(options =>
                options.UseSqlServer(Configuration.GetConnectionString("DefaultConnection")));
            // Some other configs.
        }

Part of project.json that may affect it:
  "publishOptions": {
    "include": [
      "wwwroot",
      "appsettings.json",
      "web.config"
    ]
  },

I've set StorageClient connection string as custom on Azure portal for both web apps. It works perfectly on dev server but on production server it correctly uses only SQL connection string and app settings for socials (Environment Variables), but ignores Azure custom connection string for StorageClient and uses it from appsetting.json and this of course leads to errors, because there is no storage emulator. If I manually change appsetting.json with correct value for StorageClient on prod. server and restart azure web app, then it works.
I've checked both
https://{my-prod-server}.scm.azurewebsites.net/Env.cshtml
https://{my-dev-server}.scm.azurewebsites.net/Env.cshtml
and on both there are correct values in Connection Strings section for StorageCilent ConnectionString and in Environment variables section for CUSTOMCONNSTR_StorageClient
So it looks very similar to #344 but in my case none of answers from that topic helped (I actually want to keep Azure Storage Connection String in Connection Strings without moving them totally to Environment Variables and using UserSecrets while development) and bug appears unpredictably.

Need some clarification: are you saying that your Env.cshtml shows the value you expect for StorageClient, but your app code that uses it is seeing a different value?
Have you tried reading StorageClient in your app without using the GetConnectionString extension method?

Need some clarification: are you saying that your Env.cshtml shows the value you expect for StorageClient, but your app code that uses it is seeing a different value?

Yes, Env.cshtml shows correct value, but app uses value from appsettings.json (UseDevelopmentStorage=true).

Have you tried reading StorageClient in your app without using the GetConnectionString extension method?

Not yet. I'll try and tell result tomorrow.

I've changed this code:
            services.Configure<StorageClientOptions>(options =>
            {
                options.ConnectionString = Configuration.GetConnectionString("StorageClient");
            });

to this:
            services.Configure<StorageClientOptions>(options =>
            {
                options.ConnectionString = Configuration.GetSection("ConnectionStrings")["StorageClient"];
            });

And nothing changed.
It works on dev server, but doesn't work on production server until I manually change content of appsettings.json with real connection string.

How exactly are you setting StorageClient on Azure for the production server? Did you add it to the Connection strings section in Settings > Application settings?

Also, what do you mean by CUSTOMCONNSTR_StorageClient in your first post? Where are you using that identifier?

This is screenshot from prod:

And this from dev:

I'm not actually using CUSTOMCONNSTR_StorageClient directly. I've mentioned it because as far as I understand the way in which Configuration should work on Azure, there have to be environment variables with special prefix which stores connection string on server. And Configuration then acces it using this code: EnvironmentVariablesConfigurationProvider.cs
I've not set CUSTOMCONNSTR_StorageClient directly. I just checked that it has proper value here:
https://{my-prod-server}.scm.azurewebsites.net/Env.cshtml
https://{my-dev-server}.scm.azurewebsites.net/Env.cshtml,
to be sure that this isn't azure bug.

Interesting, thanks for clarifying.
In which region is your app deployed?

What happens if you remove StorageClient from appsettings.json completely i.e. only set it via environment variables? Does the prod server read the right value then?

Ok, I've removed StorageClient from appsettings.json on prod server using Cloud Explorer from VS and restarted server. Also I've checked changing appsettings.json in source code and deploying via standard VS publish tool.
In both cases I get error: ArgumentNullException: Value cannot be null. from CloudStorageAccount when  trying to use actions in project that depends on Azure Storage. So this code:
services.Configure<StorageClientOptions>(options =>
{
    options.ConnectionString = Configuration.GetSection("ConnectionStrings")["StorageClient"];
});

doesn't throw any errors but returns null value.
Should I check what will happen on dev server?

In which region is your app deployed?

Both dev and prod deployed in West Europe.

Yes, please check the same in dev. If removing StorageClient from appsettings.json doesn't affect it, it's clear that for whatever reason your connection string set via the Azure portal is not being read by the prod server.
For your prod server, have you tried creating a new web app and deploying to it? I've tried reproing your scenario with no success, both on West US and West Europe. I wonder if this could be an issue with the specific instance where your prod server is deployed. How long has it been since your first created it?

Ok, I've checked dev. It works when I'm removing StorageClient from appsettings.json.
Dev was deployed 5/6/2016 (it was rc1). Prod was deployed 6/20/2016 (already rc2).

For your prod server, have you tried creating a new web app and deploying to it?

Do you mean to create totally new app. Add only code around StorageClient and deploy it to prod server?

Looks like a problem with the prod instance then.
What I mean is, just create a new web app in the portal and deploy prod to it, instead of deploying to the existing one.

I've created new web app instance via VS publish tool. In the same resource group and with same service plan as production server. The only settings I've set via portal are socials App Id's/Secrets (in App settings section) and DefaultConnection, StorageCilent (in Connection strings section). And their values are same as that used in production server.
And surprisingly I have same problem with StorageCilent on this newly created server, so it's not instance problem.

I've created new web app instance via VS publish tool. In the same resource group and with same service plan as production server. The only settings I've set via portal are socials App Id's/Secrets (in App settings section) and DefaultConnection, StorageCilent (in Connection strings section). And their values are same as that used in production server.
And surprisingly I have same problem with StorageCilent on this newly created server.
Then I realized that this new server actually uses same machine as my production server, so I've deleted it and repeated all actions above except that I've used new service plan(with free pricing tier) and not existing one. I've checked https://{my-new-server}.scm.azurewebsites.net/Env.cshtml for machine name, instance id and environment variables/connection strings. It is certainly new instance and all variables are correct.
And... It doesn't work again. Works everything (connection to existing DB, auth using socials, etc.), except StorageCilent connection.
It doesn't seems real, that I've got on bad instances two times in row.

I really appreciate your help and understand that this problem is hard to reproduce. May be you can advice some way to debug startup process on server or some another solution for finding what exactly goes wrong on server. So I'll be able to introduce you with more relative info.

Ok, I guess I find something related to this problem. I've added this code in my project:
namespace Profitcar.Controllers
{
    [Route("api/test")]
    public class TestController : Controller
    {
        public IConfigurationRoot Configuration { get; set; }

        public TestController(IHostingEnvironment env)
        {
            // Set up configuration sources.
            var builder = new ConfigurationBuilder()
                .SetBasePath(env.ContentRootPath)
                .AddJsonFile("appsettings.json", optional: true, reloadOnChange: true)
                .AddJsonFile($"appsettings.{env.EnvironmentName}.json", optional: true);
            builder.AddEnvironmentVariables();
            Configuration = builder.Build();
        }

        [HttpGet]
        [AllowAnonymous]
        public async Task<IActionResult> Check()
        {
            return Json(new
            {
                Configuration = Configuration.AsEnumerable()
            });
        }
    }
}

And deployed it to my dev server and to my new server. And result has very important difference:
Dev server:
    {
      "Key": "ConnectionStrings:StorageClient",
      "Value": "{correct-value}"
    }

New server:
    {
      "Key": "ConnectionStrings:StorageClient",
      "Value": "UseDevelopmentStorage=true"
    },
    {
      "Key": "ConnectionStrings:StorageCilent",
      "Value": "{correct-value}"
    }

Oh my god. I'm very very sorry for wasting your time. It's just misprint in azure portal settings. I've checked it thousands times and was sure that it is correct. My bad. Sorry again.

Haha, no worries :smile: I did watch for typos in your screenshots but everything looked right. What was it that was wrong? Was there a space character in the key or something like that?

No, but I noticed that only when started looking for invincible characters :-D . In code it was ClientStorage but in portal it was CilentStorage.

Wow, I totally missed that too. Now I see it!


[2.11] Replaces confusing log in install_demo_configuration script with a better error message

Description
This changes remove the confusing log statement from 2.11 to unblock the build.
Issues Resolved

Related to https://github.com/opensearch-project/security/issues/3489

Testing

Manual testing:
➜  opensearch-security ./tools/install_demo_configuration.sh -y -i -s
**************************************************************************
** This tool will be deprecated in the next major release of OpenSearch **
** https://github.com/opensearch-project/security/issues/1755           **
**************************************************************************
OpenSearch Security Demo Installer
 ** Warning: Do not use on production or public reachable systems **
Basedir: /Users/dchanp/Documents/amazon/testing-playground/test/binaries/opensearch-3.0.0-SNAPSHOT
OpenSearch install type: .tar.gz on
OpenSearch config dir: /Users/dchanp/Documents/amazon/testing-playground/test/binaries/opensearch-3.0.0-SNAPSHOT/config
OpenSearch config file: /Users/dchanp/Documents/amazon/testing-playground/test/binaries/opensearch-3.0.0-SNAPSHOT/config/opensearch.yml
OpenSearch bin dir: /Users/dchanp/Documents/amazon/testing-playground/test/binaries/opensearch-3.0.0-SNAPSHOT/bin
OpenSearch plugins dir: /Users/dchanp/Documents/amazon/testing-playground/test/binaries/opensearch-3.0.0-SNAPSHOT/plugins
OpenSearch lib dir: /Users/dchanp/Documents/amazon/testing-playground/test/binaries/opensearch-3.0.0-SNAPSHOT/lib
Detected OpenSearch Version: x-content-3.0.0-SNAPSHOT
Detected OpenSearch Security Version: <IP_ADDRESS>-SNAPSHOT

Unable to find custom admin password. Continuing with the default password for admin.
   ***************************************************
   ***   ADMIN PASSWORD SET TO: admin    ***
   ***************************************************
**************************************************************************
** This tool will be deprecated in the next major release of OpenSearch **
** https://github.com/opensearch-project/security/issues/1755           **
**************************************************************************
### Success
### Execute this script now on all your nodes and then start all nodes
### OpenSearch Security will be automatically initialized.
### If you like to change the runtime configuration
### change the files in ../../../config/opensearch-security and execute:
"/Users/dchanp/Documents/amazon/testing-playground/test/binaries/opensearch-3.0.0-SNAPSHOT/plugins/opensearch-security/tools/securityadmin.sh" -cd "/Users/dchanp/Documents/amazon/testing-playground/test/binaries/opensearch-3.0.0-SNAPSHOT/config/opensearch-security" -icl -key "/Users/dchanp/Documents/amazon/testing-playground/test/binaries/opensearch-3.0.0-SNAPSHOT/config/kirk-key.pem" -cert "/Users/dchanp/Documents/amazon/testing-playground/test/binaries/opensearch-3.0.0-SNAPSHOT/config/kirk.pem" -cacert "/Users/dchanp/Documents/amazon/testing-playground/test/binaries/opensearch-3.0.0-SNAPSHOT/config/root-ca.pem" -nhnv
### or run ./securityadmin_demo.sh
### To use the Security Plugin ConfigurationGUI
### To access your secured cluster open https://<hostname>:<HTTP port> and log in with admin/admin.
### (Ignore the SSL certificate warning because we installed self-signed demo certificates)

Check List
~- [ ] New functionality includes testing~
~- [ ] New functionality has been documented~

[x] Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@peternied The old message was confusing in the sense that if I spin up a docker instance and run it without passing initialAdminPassword the script would exit and not finish execution, however the docker cluster will continue to spin up and create an admin user with admin password as it picks that up from internal_users.yml file.
This PR avoids the confusion by letting users know that the password will be defaulted to admin which is what is eventually happening.
I have updated the log messages to be more detailed.


changed local train and remote train descriptions

local and remote train sometimes cause bugs if set to false. The default is already false, so an extra note is added to remind users to only use this flag when passing true

I think the description should be more like "Set this flag to enable [...]".
Good PR, though! Definitely needed.

Also, make sure to merge PRs into nobunaga instead of master

@quac88 I just noticed this is effectively trying to merge your repository to this repository :D
We can't merge this since this is your personal repository. You need to do a git checkout on the opentensor foundation's repo, and then make a new branch with these change and push it up.

imo this should be merged into nobunaga first so it doesn't mess with our branching