[WIP] Experimentally implement some functions in AssemblyScript

Currently, it is much slower than JS version 🤔
The benchmark script I am using (benchmark/string.ts):
import { encode, decode } from "../src";

const data = "Hello, 🌏\n".repeat(1000);

// warm up
const encoded = encode(data);
decode(encoded);

// run

console.time("encode");
for (let i = 0; i < 10000; i++) {
  encode(data);
}
console.timeEnd("encode");

console.time("decode");
for (let i = 0; i < 10000; i++) {
  decode(encoded);
}
console.timeEnd("decode");

You could try speedup this a little use -O3 flag instead --optimize (which -O2s actually). But I guess main reason why wasm version slower is interop overhead which could significant if your wasm function called quite frequently.

@MaxGraey Thanks for your advice!
As I attached my benchmark script to the description, I am using a large target string like "Hello, 🌏\n".repeat(1000). Even though such a situation, AssemblyScript version much slower than JS:
$  npm run asbuild && USE_WASM=true npx ts-node benchmark/string.ts

><EMAIL_ADDRESS>asbuild /Users/gfx/.ghq/github.com/msgpack/msgpack-javascript
> npm run asbuild:untouched && npm run asbuild:optimized

><EMAIL_ADDRESS>asbuild:untouched /Users/gfx/.ghq/github.com/msgpack/msgpack-javascript
> asc assembly/index.ts -b build/wasm/untouched.wasm -t build/wasm/untouched.wat --sourceMap --validate --debug

><EMAIL_ADDRESS>asbuild:optimized /Users/gfx/.ghq/github.com/msgpack/msgpack-javascript
> asc assembly/index.ts -b build/wasm/optimized.wasm -t build/wasm/optimized.wat --sourceMap --validate -O3

encode: 1666.293ms
decode: 4684.249ms

$ npx ts-node benchmark/string.ts
encode: 1622.107ms
decode: 1234.643ms

(only decode() uses AssemblyScript ver.)
My environment: NodeJS v12.2.0 on macOS 10.14.4 (Mojave)

Try to decrease iteration count form 1000 to 10-20 and increase input string size from 1000 to 5000 and see will it change something

Tried:
diff --git a/benchmark/string.ts b/benchmark/string.ts
index ebf0314..b47613d 100644
--- a/benchmark/string.ts
+++ b/benchmark/string.ts
@@ -1,6 +1,6 @@
 import { encode, decode } from "../src";

-const data = "Hello, 🌏\n".repeat(1000);
+const data = "Hello, 🌏\n".repeat(10_000);

 // warm up
 const encoded = encode(data);
@@ -9,13 +9,13 @@ decode(encoded);
 // run

 console.time("encode");
-for (let i = 0; i < 10000; i++) {
+for (let i = 0; i < 1000; i++) {
   encode(data);
 }
 console.timeEnd("encode");

 console.time("decode");
-for (let i = 0; i < 10000; i++) {
+for (let i = 0; i < 1000; i++) {
   decode(encoded);
 }
 console.timeEnd("decode");

But little changes:
$ USE_WASM=true npx ts-node benchmark/string.ts
encode: 1557.384ms
decode: 6345.717ms

$ npx ts-node benchmark/string.ts
encode: 1565.238ms
decode: 2784.192ms

Note: repeat(100_000) causes Maximum call stack size exceeded error.

Note: repeat(100_000) causes Maximum call stack size exceeded error.

Try to avoid using String.fromCharCode(...utf16array) it slow and cause to SO when size of array >= 64k.
I think if you decrease 1000 -> 10. AS should be the same speed as JS or faster. As I mentioned before you have JS <-> WASM interop overhead, which is good know performance issue for WebAssembly especially for v8 vm

Hmm?  As far as I know, String.fromCharCode(...utf16array) is the only way to create strings from ArrayBuffer or an array of codepoints. I'd like to know some other faster way if exists.

Right, but better use String.prototype.apply with fixed chunk size like in here

Interesting! I thought there's no difference on String.fromCharCode(...arrayLike) and String.fromCharCode.apply(String, arrayLike)  and it is true if the arrayLike is the actual Array, whereas #apply is much faster if the arrayLike is a typed array.
Now WASM ver. is a little bit faster than JS ver. for a large sring! dfe06c3
encode: 1547.967ms
decode: 1625.489ms

$ USE_WASM=false npx ts-node benchmark/string.ts
encode: 1526.350ms
decode: 2743.125ms

Now WASM ver. is a little bit faster than JS ver.
now wasm faster on ~70%. It's pretty good result. In comparison with JS 1.5-3x speedup usually achieved

Yep! not "a little bit", but 1.5x faster. Sounds great enough to proceed this PR for merging.

Codecov Report

Merging #26 into master will decrease coverage by 3.55%.
The diff coverage is 70.73%.

@@            Coverage Diff             @@
##           master      #26      +/-   ##
==========================================
- Coverage   95.01%   91.46%   -3.56%
==========================================
  Files          13       14       +1
  Lines         662      691      +29
  Branches      143      150       +7
==========================================
+ Hits          629      632       +3
- Misses         13       39      +26
  Partials       20       20

Impacted Files
Coverage Δ

src/utils/utf8.ts
53.16% <11.11%> (-27.85%)
:arrow_down:

src/Decoder.ts
98.44% <81.81%> (-0.76%)
:arrow_down:

src/wasmFunctions.ts
90.47% <90.47%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9170fd6...9cdac6f. Read the comment docs.

@MaxGraey
I've implemented utf8EncodeWasm() in AssemblyScript, but its performance is almost the same as pure JS ver. (NodeJS/v12.3.1 on macOS):
$ WASM=never npx ts-node benchmark/string.ts && echo && WASM=force  npx ts-node benchmark/string.ts
WASM_AVAILABLE=false
encode / decode ascii data.length=40000 encoded.byteLength=40003
encode ascii: 537.408ms
decode ascii: 1052.837ms
encode / decode emoji data.length=40000 encoded.byteLength=80005
encode emoji: 781.656ms
decode emoji: 1101.367ms

WASM_AVAILABLE=true
encode / decode ascii data.length=40000 encoded.byteLength=40003
encode ascii: 529.698ms
decode ascii: 541.502ms
encode / decode emoji data.length=40000 encoded.byteLength=80005
encode emoji: 581.234ms
decode emoji: 632.423ms

I think the overhead of preparation that converts string to an array of utf16 units (i.e. setMemoryStr() in wasmFunctions.ts) is too heavy, but I have no idea to get it better.
Do you have any idea about it?

Definitely you have interop overhead. Hard to tell how this improve. Try eliminate calls between JS and wasm. For example: use one shared buffer for input and output and use inplace process if this possible

Hmm! Will give it a try to reduce some js<->wasm calls.
Thank you for your advice, anyway! I'll merge this PR in a few days and will send feedbacks to AssemblyScript.

@gfx Sure! It will be great


int GuiGrid(...)  - return value never modified

Hi,
Here the result var have no purpose right ? What was the intention ?
https://github.com/raysan5/raygui/blob/2c8dc854d4e585761c2d4c77b4abbc46d298d5be/src/raygui.h#L3887

@n67094 Since raygui 4.0 all controls funtions return an integer value, reserved for some kind of internal state return when needed, several controls use them but not all. This part still requires some work to determine the possible return values common to all controls (i.e mouse hover control, mouse down, control focused...) or specific control internal state values... It's a work-in-progress.


Add skeleton implementation of HAPI service

Resolves #1.

I realized I was considering /hapi a proper endpoint (instead of as the landing page) and forgot about the /capabilities endpoint. I've fixed that.


Python 3

Coverage remained the same at 51.703% when pulling 09de95f47e171810c17c16507f99fc9ca3fc64d0 on python3 into e747ef8ddcba707153bb2564146cda0e762d0a32 on master.

Current coverage is 45.28% (diff: 100%)

Merging #222 into master will not change coverage

@@             master       #222   diff @@
==========================================
  Files            34         34
  Lines          1367       1367
  Methods         182        182
  Messages          0          0
  Branches        153        153
==========================================
  Hits            619        619
  Misses          748        748
  Partials          0          0

Powered by Codecov. Last update e747ef8...616424b

Coverage remained the same at 51.703% when pulling 8704cb6520cb73ebb0ed48527d85a3d445e6c49a on python3 into e747ef8ddcba707153bb2564146cda0e762d0a32 on master.

Coverage increased (+0.5%) to 52.163% when pulling 76af12150ff14d6cfd6f4dd272e27adae1d97346 on python3 into 247c17cc338353c2ad9f6aa94c4ff46a570a9210 on master.

Coverage increased (+0.5%) to 52.163% when pulling 5fc887ed87fb8b31a7ef0de98bf671008c85d244 on python3 into 247c17cc338353c2ad9f6aa94c4ff46a570a9210 on master.


Add main form positioning.

Closes #54 .
Todo, manual test MacOS and Linux.

MacOS manual test ✔

Linux, first test gave mixed results, then started working. Add delay if fails in the future. ❔

Linux manual test via #57. ✔


Qiskit wrapper

Issue:
https://github.com/pyRiemann/pyRiemann/issues/141
Blocker:
https://github.com/pyRiemann/pyRiemann-qiskit/pull/1
This PR is a "fresh one" but a similar PR with commit history was raised in https://github.com/pyRiemann/pyRiemann-qiskit/pull/3

@qbarthelemy Thank you for your time reviewing this PR.
I have addressed your comment by improving compliance with scikit architecture (removing of set and params methods and better naming of the variables) and in general code readability as suggested.
One test was also added in order to confirm the behavior of the cloning functionality.
I have opened a draft at https://github.com/gcattan/pyRiemann-qiskit/pull/1, so you can better visualize the difference between this branch and the base branch (#1).

No, my point is that qiskit-machine-learning could be a good community to share, review and maintain your quantic classifiers, because, they are a scikit-learn wrapper more than a pyRiemann one.

No, my point is that qiskit-machine-learning could be a good community to share, review and maintain your quantic classifiers, because, they are a scikit-learn wrapper more than a pyRiemann one.

As I see it, it could be a good starting point to develop some of the idea presented in issue #7 . But this is definitely a very pertinent suggestion and I will ask there too.
If during this review, you feel that this work is not suitable anymore for pyRiemann repository, please let me know, I will understand :)

As I see it, it could be a good starting point to develop some of the idea presented in issue #7 . But this is definitely a very pertinent suggestion and I will ask there too. If during this review, you feel that this work is not suitable anymore for pyRiemann repository, please let me know, I will understand :)

Ok for me to keep your work in this repo!

Hello,
Thank you for your useful comments. I removed the run method and instead used directly the predict, train and test methods - and therefore doing the training in the fit method and removed the test_per parameter.
I am still working on the example to find appropriate filtering (and not too much time-consuming) for the ERP example, and running once again the toys_dataset (as I changed the predict_proba method).
I will then post the pictures in the slack as you mentioned.
I got also a response from the qiskit-ml mainteners. They said that as compared to qiskit, qiskit-ml was recently refactored to support SKlearn (but admittedly not tested it with sklearn pipeline). I guess a follow-up issue to the current review would be to replace qiskit.aqua by qiskit-ml, doing the appropriate testing, which in sum is a good news, as it will allow to focus on more pyRiemann work :)

Thanks @gcattan, we could merge this PR. Thanks a lot @qbarthelemy for your careful reading!
I'll take care of putting the docs on RTD.


Similar Emulator

At gbafun.com, there is is a similar emulator that looks like nesbox? Do you know the name of that emulator?

No, I don't.


Don't encourage quoting mistakes and security holes

I think envoy.run is something of a massive foot-gun right now if the canonical way to manage arguments is with %s or new-style format strings.  Although you have set shell=False and eschewed the system-dependent shell language for the cross-platform shlex, the following is just as vulnerable as bash or the system function in C (implemented in Perl and Ruby via backtick characters) to quoting problems and injection attacks:
envoy.run('ls %s' % directory)

Where directory could have spaces, then passed to shlex and then take the form of additional arguments.
If you feel you must use an embedded languages for .run (which is a lot more terse than using vanilla lists or tuples in Python, such as ['ls', directory]) please consider doing something akin to what database drivers do, which is supporting parameters that are interpreted by that driver rather than using the string substitution mechanisms.

I'm certainty not going to stop someone from placing a security hole in their Naïve code.
I'm definitely not against adding more proper argument support though. Nick Coghlan has been doing some great work recently with his "shell-command" module that prevents shell injection. I've been considering adding that functionality into envoy.

Only supporting lists (or unpacking a sequence-of-strings in general) would, in fact, stop people from making tiny mechanical errors that result in subtle problems.  Subprocess used this fairly brutal (but definitely correct) way of preventing the problem: you have to opt-in to interpolations that could make yourself unsafe with shell=True with subprocess.  Getting what you expect all the time (rather than some of the time) with a naïve program is a positive property.  Rather, one cannot prevent someone from going out of their way to cause a problem.
Notably, just like the database drivers, this work by Nick Coghlan  has to interpolate his own strings, thus matching every expansion to exactly one argv.
It would take more work, but what about using the new-style format-string parser?  Then one could write
envoy.run('ls -l {directory}', directory='./place')

or
envoy.run('ls -l {0}', './place')

The downside is that str.format exists only to format strings, and you have many additional operators (some of which may credibly named 'directory') that clutter the namespace.  One bizarre way one could get around this might be having a subclass of string (or something that's just structurally typed similarly) with a very, very special format operator.  I'm not sold on the idea, but it's something to think about:
>>> cmd = Command('ls -l {place}')
>>> cmd.format(place='./')
BoundCommand('ls -l "./")
envoy.run(cmd)

The whole point of the project is to make lists and creating such instances unnecessary. I don't mind supporting safer behaviors, but any simple command that works on the command line should work here as a regular string.

That recipe has evolved into a more formal project here: http://pypi.python.org/pypi/shell_command

Maybe adopt that, then?  I also like the treatment of globs, whereby one is intended to get exactly one argv per match in the file system.
I suppose one useful embellishment might be to support dictionary replacement to look even more like str.format.
As-is, though, I saw someone using envoy for the first time today and in the very first program I see has a quoting hazard.
shell_command seems to use the same general style as psycopg2.  The latter only has the disadvantage of using the long-standing but now allegedly obsolete string formatting language, the former uses a POSIX-Python hybrid-inspired notation...but nonetheless, it is a new notation.  psycopg2 also leaves a nice warning liberally sprinkled via cross-reference in the docs.
Ease of use is important -- and could very well lead to fewer programs being written in bash, which just makes it nearly impossible to solve this problem -- but the main problem with bash, in my mind, is this defect of handling argv.  The authors of the Plan9 shell took an opportunity address this error, but do not have a verbose syntax to convey the literals, perhaps it can also provide input?
http://cm.bell-labs.com/sys/doc/rc.html


Task 2.

 I need to ask something

Can you write your confusion? So that we can be enlightened?

In group 1, tirth is doing it. You can also ask him @uarif

Yes, I am talking about the cutoff frequency, I took a maximum frequency to be 1, and the filtered the higher frequencies from 0.07 I guess, higher than that, I ignored. Does it make sense to you? @Mosaddeq107


Bluesky: various unthemed elements

Is there an existing issue outlining your problem?

[X] I am using the latest version of the provided userstyle.
[X] I have searched the existing issues and they do not solve my problem.

What userstyles are you seeing the problem on?
lbl:bsky
Describe your problem.
Multiple sections of the Bluesky Catppuccin theme are not correctly themed. They're showing the default Bluesky colors instead of the Catppuccin colors. The screenshots bellow only show a selection of instances of elements not being correctly colored but they litter the entire theme currently.
Attach screenshots.

What browser(s) are you seeing the problem on?
Vivaldi: 6.6.3271.53 (Stable channel) (64-bit)
Any additional comments?
No response

Hello!
If you switch the Dark Theme setting from "Dim" to "Dark", it fixes almost everything.

Hello!
If you switch the Dark Theme setting from "Dim" to "Dark", it fixes almost everything.

Changing the Dark Theme setting to dark worked. Though I should note that maybe this should be noted on the GitHub page for the BlueSky Catppuccin theme in a "usage" section? Will close the issue though since that's more a request then an issue.


DOC: more pd.to_datetime examples

xref #12996

@jorisvandenbossche

also added #12974 fix here.

@jreback Can you please try to not change the commit too much during the merge? This makes reviewing PRs / seeing what has been merged a lot more difficult using github (as it seems the 'Files changed' is quite different from the actual merged commit).
(of course, small fixup changes are not a problem, certainly for PRs of other contributors to not have them endlessly adapt minor things)

@jorisvandenbossche I normally don't. but ended up going on a tangent with some other things (somewhat unrelated).

That's OK! (I just noticed it for this one)


[20370] Branch-out for fastdds v3.0.0

This pr includes:

Create branch-out
Update dependencies from fastdds in CMakeList files, colcon files etc..
Update code DDSCodeTester.cpp
Remove FASTRTPS_API_TESTS and GTEST_INDIVIDUAL
Rename FASTDDS_DEFAULT_PROFILES_FILE and DEFAULT_FASTDDS_PROFILES

The job fastdds_docs_manual is failing because the parameters of the job must be changed.

@richiprosima please test docs

@richiprosima please test docs


Update expiration block height computation

[!WARNING]
This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more

Current dependencies on/for this PR:

main

PR #27

PR #28

PR #29

PR #30

PR #31

PR #32   👈

This stack of pull requests is managed by Graphite.


fix(types): allow null value for AppEventsLogger.setUserID

AppEventsLogger.clearUserID is deprecated and suggests using "setUserID(null)"
However, setUserID is currently not typed to allow null values.
Test Plan:
no test plan

@mikehardy Thanks for merging it so quickly. Although I just noticed that calling setUserID(null) now breaks Android. On the android side it doesn't like null but wants clearUserID. Its a shame that iOS and Android are out of sync like that.

@danilobuerger are you 100% on that? Because I thought they both made that change
In the current version they internally delegate clearUserId to setUserId(null):
https://github.com/facebook/facebook-android-sdk/blob/ec96d8a0d3fffa3176ef985819650a68e1ba84bb/facebook-core/src/main/java/com/facebook/appevents/AppEventsLogger.kt#L504-L506
and the internal implementation of setUserId explicitly has the id string arg set as nullable
https://github.com/facebook/facebook-android-sdk/blob/ec96d8a0d3fffa3176ef985819650a68e1ba84bb/facebook-core/src/main/java/com/facebook/appevents/AnalyticsUserIDStore.kt#L46
So at least with the current release I expect it will work. However, "the current release" is v13 and we're still pulling in facebook-android-sdk v12 until #208
on their v12.2 branch it appears to work as well though? https://github.com/facebook/facebook-android-sdk/blob/a6e982175b258fbd99ec8313bbe052f1efd90185/facebook-core/src/main/java/com/facebook/appevents/AppEventsLogger.kt#L498-L500
Except one thing I do see is that setUserId() method is marked with not-null in the Kotlin! So perhaps that's the problem? What exact problem did you see?
We could maybe log an issue for them to true up their types and deprecate clearUserId similar to facebook-ios-sdk
In the meantime if this is breaking things or requiring platform-specific code that's a bug in my way of thinking. For Android we could make setUserId(null) at the javascript layer call native clearUserId() - a quick PR and I'd merge it if you liked the idea and posted it up

Except one thing I do see is that setUserId() method is marked with not-null in the Kotlin! So perhaps that's the problem? What exact problem did you see?

Yeah, that seems to be the problem. I get an error exactly there that a null value is passed to a non null parameter in kotlin.

In the meantime if this is breaking things or requiring platform-specific code that's a bug in my way of thinking. For Android we could make setUserId(null) at the javascript layer call native clearUserId() - a quick PR and I'd merge it if you liked the idea and posted it up

Yup, will submit a PR later today

Awesome! Thanks in advance. I'll chase down facebook-android-sdk in parallel with an issue over there

Upstream already merged the fix sweet! It'll be in whatever is after 13.0.0 whenever that is, and whenever we can access it via forward-porting here :-)


docs: adjust the unhandled routes to use userId

The router example above the traversed unhandled routes, uses :userId as a variable instead of :id.
PR Checklist
Please check if your PR fulfills the following requirements:

[x ] The commit message follows our guidelines: https://github.com/scullyio/scully/blob/main/CONTRIBUTING.md#commit
[ ] Tests for the changes have been added (for bug fixes / features)
[ ] Docs have been added / updated (for bug fixes / features)

PR Type
What kind of change does this PR introduce?

[ ] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[x ] Refactoring (no functional changes, no api changes)
[ ] Other... Please describe:

Does this PR introduce a breaking change?

[ ] Yes
[ x] No

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.


Specify Enumeration Initialisation Behaviour

I wanted to get clarification on the following point. Reading Section 7.2.1 (Enumeration Types), It is very clear that an identifier can only be specified once (quite rightly), however I can't see how initialisers are specified in terms of whether it is legal to have the same initialiser repeated. A real world example of this would involve ICMP type codes, where the message type determines how the code is used:
enum bit<16> ICMPCode {
    DEST_NET_UNREACHABLE = 0,
    // ...
    REDIRECT_DATAGRAM_NET = 0, // Is this legal?
}

The wording implies that it is:

... the mapping of symbolic to numeric values defined by the enum are effectively constants defined as a part of this type

I ask because in C/C++, this would be a perfectly legal thing to do (see cppreference) however it appears as though languages such as Rust (although i'm not terribly familiar with that language) do not permit this -- but in any case the behaviour is explicitly specified.
P.S. I noticed a small spelling mistake in the card suite example, "Hearts" is spelt "Hearths". Might be difficult playing a game of cards with that.

Section 8.3 answers this question in the positive:
https://p4.org/p4-spec/docs/P4-16-v1.2.0.html#sec-enum-exprs

Ok, thankyou.


Hide top-floor up button and bottom-floor down button

The floor call indicator arrows currently look like this (on challenge 1):

But it doesn’t make sense for floor 0 to have a down button, or the topmost floor to have an up button. You can’t go any farther, and thankfully the simulated users never press that button.
Thus, I suggest that those two impossible arrows be hidden:

Hopefully, hiding those arrows will guide programmers into handling the floor call button presses better, because they will instantly realize that no users will ever press those two hidden buttons.
You can hide the icons with the CSS visibility: hidden; so that the top floor’s down indicator is still aligned with other down indicators. The other part of the implementation is changing the floor-template in index.html so that just those two indicators get the appropriate class added to them, and possibly also changing the data that is passed to the template.

Yeah, agree.

https://github.com/magwo/elevatorsaga/commit/6b429399a4e1de797a61a639fdbc6d219b768e3e


added PactumJS under Testing

PactumJS is a REST API Testing Tool for all levels in a Test Pyramid.

🎈 Lightweight
🚀 Simple & Powerful
📚 Clear & Comprehensive Testing Style
🔗 Component, Contract & E2E testing of APIs

By submitting this pull request, I promise I have read the contribution guidelines twice and ensured my submission follows it. I realize not doing so wastes the maintainers' time that they could have spent making the world better. 🖖
⬆⬆⬆⬆⬆⬆⬆⬆⬆⬆

Thanks for the suggestion, but I'm going to pass on this. This is a curation, so I unfortunately can't include everything. That means making the hard decision of leaving out some cool projects for various reasons.

@sindresorhus I wanted to follow up about including PactumJS in this list. Since it's been a few years, I wanted to check if you’d be open to reconsidering it for inclusion.
PactumJS has seen significant growth since I initially raised this PR. Its weekly downloads have increased from 500 to over 150,000. Additionally, it’s now being adopted by a number of organizations and engineers in the testing community.
I completely understand the curation process and the need to make tough decisions, but I believe it could now be a good fit for the list. Of course, I respect your decision either way and appreciate the work you do in maintaining the repository!
Thanks in advance.


App shows all steps together, instead of showing them step by step

I have added 3 steps, I thought that they will display one by one, however, they all displayed together at the same time. Why is that?
import { copilot,walkthroughable, CopilotStep } from '@okgrow/react-native-copilot';
const CopilotText = walkthroughable(Text);

class Home extends Component {

render() {
return (
  <View>
    <CopilotStep text="step 1" order={1} name="openApp">
       <CopilotText>Step 1 !</CopilotText>
    </CopilotStep>
    </View>
    <View>
      <CopilotStep text="Step 2" order={2} name="openApp2">
       <CopilotText>Step 2!</CopilotText>
    </CopilotStep>
    </View>
    <View>
    <CopilotStep text="Step 3!" order={3} name="openApp3">
       <CopilotText>Step 3</CopilotText>
    </CopilotStep>
    </View>
)}
}

export default copilot()(Home);

I see all the steps are named openApp. Try giving different names to them.

@mohebifar I have already tried that, it didn't help! I saw that in example used this.props.start(), to invoke the  steps, but in example in the GitHub CopilotSteps inside the render method, so I'm not sure how should I invoke start of the work of the CopilotSteps.

@RichardLitt @mohebifar Please take a look at my code, what else should be in that component to make it work correctly? how to trigger starts of steps?

@Luckygirlllll Could you please give it another try with version 2?

Closing this for now. Feel free to re-open it if you are still seeing the issue.


Longest AP first addition

Please star this repository to show your support, in the meantime I am reviewing your code.

@amritansh22 hello, is there any issue in this PR. If so please let me know. Otherwise could you merge it?

Please star this repository to show your support, in the meantime I am reviewing your code. The volume of incoming PR's is huge, so it is taking a bit of time.

Sure ✌

Excellent work @therk32 Thanks a lot for making this PR.


Shopping-cart assignment

Application is implemented using Angular 11.
Changes includes,

Routing for login, register, home-page ,product-listing page (lazy loading)
Fetch-products service - all API requests
Home page - carousel & categories
Login & Register page
Product-listing page - Mat-sidenav & products listed
Auth service - handle token and authentication
Shared module with header and footer components.

Besides the review comments

Lint the codebase to identify/fix any JS standard related issues and attach the report
Run lighthouse and fix any performance and accessibility related issues. Share the light house scores once that's done. You can also use aXe chrome extension to find accessibility related issues
Share the UI screenshots for desktop and other supported viewports

Many of my review comments are given on files but are meant for the entire codebase. Please check for the additional notes in the comments.


Misc. Updates

The purpose of this PR is to bring the plugin closer to getting eaten by jingle and becoming default plugin

Delete meta.json because no auto updating
Upgradle to newer Jingle commit
Remove restriction on instance paths since you can set an instance folder anywhere on your computer

Remove some random version stuff that wasn't serving any purpose
Some random formatting things

After merging and bumping version I'd say prolly good enough

Thanks Mr. Runs


Make backgroundThreadRealm as lazy #4859

Closes #4859

Can you help add a comment in the code near the property to explain? Like the explanation you added in the issue :)


upmcenterprises/elasticsearch-cron:0.0.4 snapshot crashloopbackup

snapshot crashloopbackup  in gke with gs storage
severity: "ERROR"
textPayload: "time="yyyy-mm-ddT13:00:19Z" level=error msg="Error attempting to create snapshot:
Put https://my_es_url.my_es_namespace.svc.cluster.local:9200/_snapshot/elasticsnapshots/snapshot_yyyy-mm-dd-13-00-19?wait_for_completion=true: http: server gave HTTP response to HTTPS client"
Config:
snapshot:
enabled: true
type: gcs
bucketName: elasticsnapshots
schedule: "@every 2m"
image: upmcenterprises/elasticsearch-cron:0.0.4
authentication:
enabled: false

Seems this is related to the snapshots not working in gke note in the README
".... By swapping out the storage types, this can be used in GKE, but snapshots won't work at the
moment."
Is there a work around recommendation?


Unable to run demo test_attr_predictor

Hello everyone. With great difficulty, I was able to figure out (thanks to the issues section) the structure of this library.
I want to run demo. This is my command:
python3 demo/test_attr_predictor.py --input demo/imgs/attr_pred_demo1.jpg --checkpoint checkpoint/landmark_pooling/latest.pth --config configs/attribute_predict/global_predictor_vgg_attr.py

I get this error:
warnings.warn(
load checkpoint from local path: checkpoint/landmark_pooling/latest.pth
[ Top3 Attribute Prediction ]
Traceback (most recent call last):
  File "/Users/mulunur/Documents/универ/диплом/mmfashion/demo/test_attr_predictor.py", line 62, in <module>
    main()
  File "/Users/mulunur/Documents/универ/диплом/mmfashion/demo/test_attr_predictor.py", line 58, in main
    attr_predictor.show_prediction(attr_prob)
  File "/Library/Python/3.9/site-packages/mmfashion-0.4.0-py3.9.egg/mmfashion/core/evaluation/attr_predict_demo.py", line 40, in show_prediction
    self.print_attr_name(idxes)
  File "/Library/Python/3.9/site-packages/mmfashion-0.4.0-py3.9.egg/mmfashion/core/evaluation/attr_predict_demo.py", line 25, in print_attr_name
    print(self.attr_idx2name[idx])
KeyError: 730

If in previous command I try to change checkpoint from landmark pooling to global, then I get another error:
warnings.warn(
load checkpoint from local path: checkpoint/latest.pth
The model and loaded state dict do not match exactly

unexpected key in source state_dict: roi_pool.linear.0.weight, roi_pool.linear.0.bias, concat.fc_fusion.weight, concat.fc_fusion.bias

[ Top3 Attribute Prediction ]
Traceback (most recent call last):
  File "/Users/mulunur/Documents/универ/диплом/mmfashion/demo/test_attr_predictor.py", line 62, in <module>
    main()
  File "/Users/mulunur/Documents/универ/диплом/mmfashion/demo/test_attr_predictor.py", line 58, in main
    attr_predictor.show_prediction(attr_prob)
  File "/Library/Python/3.9/site-packages/mmfashion-0.4.0-py3.9.egg/mmfashion/core/evaluation/attr_predict_demo.py", line 40, in show_prediction
    self.print_attr_name(idxes)
  File "/Library/Python/3.9/site-packages/mmfashion-0.4.0-py3.9.egg/mmfashion/core/evaluation/attr_predict_demo.py", line 25, in print_attr_name
    print(self.attr_idx2name[idx])
KeyError: 836

I tried to prepare the data, downloaded Attr_Predict and used Anno_fine folder, but renamed it to Anno, because data/prepare_attr_pred.py file had code like PREFIX = 'Attr_Predict/Anno' . In #146 question it was said that if you use the Anno_fine, then you do not need to run the prepare script.
Anyway, I tried to run prepare_attr_pred.py, get this error:
 File "/Users/mulunur/Documents/универ/диплом/mmfashion/data/prepare_attr_pred.py", line 172, in <module>
    split_img()
  File "/Users/mulunur/Documents/универ/диплом/mmfashion/data/prepare_attr_pred.py", line 8, in split_img
    wf1 = open(os.path.join(PREFIX, 'train.txt'), 'w')
FileNotFoundError: [Errno 2] No such file or directory: 'Attr_Predict/Anno/train.txt'
mulunur@192 data % python3 prepare_attr_pred.py
Traceback (most recent call last):
  File "/Users/mulunur/Documents/универ/диплом/mmfashion/data/prepare_attr_pred.py", line 177, in <module>
    split_attribute(train_img, test_img, val_img)
  File "/Users/mulunur/Documents/универ/диплом/mmfashion/data/prepare_attr_pred.py", line 58, in split_attribute
    write_attr(train_img, wf1)
  File "/Users/mulunur/Documents/универ/диплом/mmfashion/data/prepare_attr_pred.py", line 52, in write_attr
    attr = attributes[imgname]
KeyError: 'img/Sheer_Pleated-Front_Blouse/img_00000001.jpg'

Can you please help me, what am I doing wrong? 🥺

I tried with Anno_coarse folder, it works fine. As in #146 mentioned, Anno_fine contains only 26 label, I guess it's why you got a KeyError when index is a larger number


There are some code smells in presto module

There are some code smells in presto module
For example
1.Didn't add @OverRide for override method
2.magic number
3.variable Should Use LowerCamelCase

pull request merged.


Be able to start grunt server without starting up the browser window.

The default behavior is the same as always (browser starts up with "grunt server")
but if you pass in --nobrowser, it won't start the browser.

Lovely.


Add UI tests for parse errors

For historical reasons, Maud doesn't have good test coverage for its diagnostics. In fact, at the moment there is only one such test :pensive:  The lack of tests will block further changes (e.g. #251) so we should address this.
For a list of things to test, go to parse.rs and search for abort! and abort_call_site!.

[ ] unexpected end of input
[ ] @let only works inside a block
[ ] unknown keyword @{}
[ ] expected keyword after @
[x] found keyword {}
[ ] invalid syntax
[ ] expected string
[ ] expected body for this @if
[ ] expected body for this @else
[ ] expected body for this @while
[ ] missing in in @for loop
[ ] expected body for this @for
[ ] expected body for this @match
[ ] unexpected end of @match pattern
[ ] unexpected end of @match arm
[ ] unexpected end of @let expression
[ ] unexpected end of @let expression (are you missing a semicolon?)
[ ] unexpected element
[ ] element body must be wrapped in braces
[ ] duplicate attribute {}


XNLI 2.0 subset added

I added extension of XNLI dataset, XNLI 2.0, described in this paper: https://arxiv.org/pdf/2301.06527 for Indian languages.
I collated them into one multilingual set added to: mteb/xnli2.0-multi-pair

Checklist for adding MMTEB dataset

Reason for dataset addition:

[x] I have tested that the dataset runs with the mteb package.
[x] I have run the following models on the task (adding the results to the pr). These can be run using the mteb run -m {model_name} -t {task_name} command.

[x] sentence-transformers/paraphrase-multilingual-MiniLM-L12-v2
[x] intfloat/multilingual-e5-small

[x] I have checked that the performance is neither trivial (both models gain close to perfect scores) nor random (both models gain close to random scores).
[x] If the dataset is too big (e.g. >2048 examples), considering using self.stratified_subsampling() under dataset_transform()
[x] I have filled out the metadata object in the dataset file (find documentation on it here).
[x] Run tests locally to make sure nothing is broken using make test.
[x] Run the formatter to format the code using make lint.
[ ] I have added points for my submission to the points folder using the PR number as the filename (e.g. 438.jsonl).

Thanks @isaac-chung! Fixed and added points according to:
> tasks = get_tasks(task_types=['PairClassification'])
> len(set(XNLI2().metadata.languages).intersection(tasks.languages))
0

which means that none of the languages are yet in this task, so 2+4*10.


Navigate reference throws DBException on DB2 database

When connected to a DB2 11.1 database, using Navigate References (Ctrl+1 or right clicking on a key) then selecting a Table Reference shows an exception dialog.

Problem Occured
'Navigate reference' has encountered a problem.
Can't obtain association 'TABLE2_TABLE1_FK' target constraint (table TABLE2)
OK    Details >>

the .metadata/.log contains
!ENTRY org.jkiss.dbeaver.model 4 0 2019-05-16 14:00:22.031
!MESSAGE Can't obtain association 'TABLE2_TABLE1_FK' target constraint (table TABLE2)
!STACK 0
org.jkiss.dbeaver.DBException: Can't obtain association 'TABLE2_TABLE1_FK' target constraint (table TABLE2)
                at org.jkiss.dbeaver.ui.controls.resultset.ResultSetViewer.navigateReference(ResultSetViewer.java:2681)
                at org.jkiss.dbeaver.ui.controls.resultset.ResultSetReferenceMenu$2$1.run(ResultSetReferenceMenu.java:185)
                at org.jkiss.dbeaver.model.runtime.AbstractJob.run(AbstractJob.java:102)
                at org.eclipse.core.internal.jobs.Worker.run(Worker.java:63)

Selecting from the Table Foreign Keys works fine, as does Navigate link (Alt+Space).
Tested in DBeaver 6.0.4 using latest db2jcc4.jar driver.
Reproduce with the following schema:
CREATE SCHEMA TEST;

CREATE TABLE "TEST"."TABLE1" (
    "TABLE1_ID" BIGINT NOT NULL GENERATED BY DEFAULT AS IDENTITY,
    "SOMETEXT" VARCHAR(50));

ALTER TABLE  "TEST"."TABLE1"
    ADD CONSTRAINT "TABLE1_PK"
    PRIMARY KEY ("TABLE1_ID") ;

CREATE TABLE "TEST"."TABLE2" (
    "TABLE2_ID" BIGINT NOT NULL GENERATED BY DEFAULT AS IDENTITY,
    "TABLE1_ID" BIGINT NOT NULL);

ALTER TABLE "TEST"."TABLE2"
    ADD CONSTRAINT "TABLE2_PK"
    PRIMARY KEY ("TABLE2_ID") ;

ALTER TABLE "TEST"."TABLE2"
    ADD CONSTRAINT "TABLE2_TABLE1_FK"
    FOREIGN KEY ("TABLE1_ID")
    REFERENCES "TEST"."TABLE1" ("TABLE1_ID");

and data:
INSERT INTO TEST.TABLE1 (SOMETEXT)
       VALUES('test1'), ('test2'),  ('test3'), ('test4'),  ('test5');

INSERT INTO TEST.TABLE2 (TABLE1_ID)
       VALUES(1), (2), (3), (4), (5);

Session Data:

eclipse.buildId=unknown
java.version=1.8.0_77
java.vendor=Oracle Corporation
BootLoader constants: OS=win32, ARCH=x86_64, WS=win32, NL=en
Command-line arguments:  -os win32 -ws win32 -arch x86_64

cannot reproduce an issue.
Ticket closed.
If the issue still actual for you feel free to reopen the ticket.


pcnt quadrature question (IDFGH-10870)

Answers checklist.

[X] I have read the documentation ESP-IDF Programming Guide and the issue is not addressed there.
[X] I have updated my IDF branch (master or release) to the latest version and checked that the issue is present there.
[X] I have searched the issue tracker for a similar issue and not found a similar issue.

General issue report
Hello I have an encoder which has A B Z and /A /B /Z outputs. I want to detect the direction and tick count using pcnt but I did not find any solution. I alredy looked the pcnt example, in pcnt example, it detect pulses very good but I also need direction like left or right. Thanks for your helps

@onurdof you can define the direction by either

the sign of the count value
the change of the value (getting bigger or smaller)

The PCNT peripheral doesn't have a hardware feature to tell the direction, you have to calculate it by software.

BTW, for such application questions, the ESP32 forum is absolutely a better place for you to refer to.

BTW, for such application questions, the ESP32 forum is absolutely a better place for you to refer to.

Thank you so much.


Add Anxin Insurance to powered-by.md

Please answer these questions before submitting pull request

Why submit this pull request?
[ ] add companies to the User Wall

Coverage increased (+0.004%) to 16.004% when pulling 4ae14879f20f7d1a6bb8f3dcd036a1100dbd87d8 on zaygrzx:patch-2 into 800a5353def28b37b7580f0c32de87534ae56f22 on apache:master.


Fix consistency of ParallelGateOperation

Fixes #1659.

Good catch. What is the reason for removing the phase_by method? Is that related to the unitary problem?

phase_by is a per-qubit thing. You phased every gate instead of just the one gate.


iOS runtime Marshalling returns NSObject - Objective-C iOS-onfido-sdk

Environment
$ tns info
✔ Getting NativeScript components versions information...
⚠ Update available for component nativescript. Your current version is 6.3.1 and the latest available version is 6.3.3.
✔ Component tns-core-modules has 6.3.2 version and is up to date.
✔ Component tns-android has 6.3.1 version and is up to date.
✔ Component tns-ios has 6.3.0 version and is up to date.
$ ng --version
Angular CLI: 8.3.22
Node: 10.18.0
OS: darwin x64
Angular: 8.2.14
... animations, common, compiler, compiler-cli, core, forms
... platform-browser, platform-browser-dynamic, router
Package                      Version
@angular-devkit/architect    0.803.22 (cli-only)
@angular-devkit/core         8.2.2
@angular-devkit/schematics   8.3.22 (cli-only)
@ngtools/webpack             8.2.2
@schematics/angular          8.3.22 (cli-only)
@schematics/update           0.803.22 (cli-only)
rxjs                         6.5.4
typescript                   3.4.5
webpack                      4.27.1
Describe the bug

I'm trying to implement onfido-ios-sdk for mu nativescript-angular app. Here is the repo - hello-onfido
As per ios-sdk guide,
objective-c code
NSError *variantConfigError = NULL;
Builder *variantBuilder = [ONFaceStepVariantConfig builder];
[variantBuilder withPhotoCaptureWithConfig: NULL];
[configBuilder withFaceStepOfVariant: [variantBuilder buildAndReturnError: &variantConfigError]];

Nativesctipt code
this._faceVariantBuilder = ONFaceStepVariantConfig.builder();
 // console.log(this._faceVariantBuilder instanceof Builder);
this._faceVariantBuilder.withPhotoCaptureWithConfig(null);
this._configBuilder.withFaceStepOfVariant(this._faceVariantBuilder.buildAndReturnError(this._faceVariantError));

But _faceVariantBuilder created is NSObject, so I can not found withPhotoCaptureWithConfig method.
To Reproduce

Clone hello-onfido
add ios platform, and run this app.
It says,

file:///src/app/onfido/onfido.ts:80:28: [nativescript-onfido]: ERROR: TypeError: _this._faceVariantBuilder.withPhotoCaptureWithConfig is not a function. (In '_this._faceVariantBuilder.withPhotoCaptureWithConfig(null)', '_this._faceVariantBuilder.withPhotoCaptureWithConfig' is undefined)

Expected behavior
It should generate Builder type of object, instead of NSObject.
Sample project

hello-onfido

Hi @heena-1993, thank you for the excellent report! We've made a fix for the issue and it will be released with version 6.4.1 of tns-ios.

The RC has been published in NPM and you can now try it with tns platform add ios@rc


KEP-78: Dynamically reclaiming resources

What type of PR is this?
/kind documentation
/kind api-change

What this PR does / why we need it:
One-line PR description: This KEP proposes an approach to reclaim unused resources of an unfinished job of cluster-queue in an incremental manner, so that all the resources of the cluster-queue can used efficiently.
Which issue(s) this PR fixes:

Relates to: #78
Special notes for your reviewer:
This is the continuation of #331, with an adaptation to the current state of Kueue.
Does this PR introduce a user-facing change?

NONE

/retest

/retest


cleanup: remove requirements.txt file

What type of PR is this?
/kind cleanup
Any specific area of the project related to this PR?
/area build
Proposed rule maturity level
None
What this PR does / why we need it:
This PR removes the requirements.txt file using explicit dependencies in the deploy-pages job
Which issue(s) this PR fixes:
Special notes for your reviewer:

[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: Andreagit97
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

OWNERS [Andreagit97]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: Andreagit97, leogr
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

OWNERS [Andreagit97,leogr]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment


Expose public API for HTTP parser

So I found this module by complete mistake while reading through your [admittedly excellent] async-await blog article. It was a serendipity find because I wasn't looking for it, but h11 is exactly what I need.
We have a [very big] cluster of PyPy servers that has a complex connection pool written in-house to maintain its backend connections. TL;DR: requests is great but its connection pooling does not do the kind of pooling we need.
To cut a long story short, the connection pool implementation suffers from the synchronous request behavior of every Python HTTP client on the planet. The two options to solve this are:

HTTP/1.1 pipelining
HTTP/2

Our backend doesn't support HTTP/2 so strike that option.
So we've experimented with pipelining using http-parser, and well, it kind of works.
Then I found h11, and I was overjoyed! Welp, that didn't last....

HTTP/1.1 also allows for a more aggressive form of connection re-use, in which a client sends multiple requests in quick succession, and then waits for the responses to stream back in order (“pipelining”). This is generally considered to have been a bad idea, because it makes things like error recovery very complicated.

But I'm not deterred. It's either pipelining or maintaining several hundred thousand open connections on the backends. And the latter is really horrifying.
For the short term, I'll be experimenting with the h11 parsers by using their private references, and hopefully not running into anything unexpected. For the medium and long term, I'd like to see the parsers publicly exposed and documented for insane use cases like mine. :)

h11 doesn't really... have a standalone parser? The state machine for the parser is the state machine for connection, and that's unlikely to change. I'm not entirely sure what you're planning here, but I guess I'll be interested to see what you come up with :-). It's unlikely that h11 will ever support pipelining, though.
It does occur to me that if you're looking for a gross solution, you might be able to get some distance by creating multiple h11.Connection objects, one per pipelined request. Use send on the first object to get the bytes for your first request and send those, then send on the second object to get the bytes for your next request, etc. Then when you get bytes back, feed them into the first object until you reach the end of the request, then use Connection.trailing_data to retrieve the unprocessed data and start feeding that into the next object...
The most challenging part of all this would be the error handling, e.g. if a connection object's state becomes MUST_CLOSE then you have to stop instead of continuing to the next object. But error handling is what makes pipelining super-challenging in general, so I guess you know what you're getting yourself into :-)

Yeah, I'm going to have to bend the laws of physics on this one a bit to get it working, but looking through h11._readers and h11._writers, all the piece are there for a decent parser. If I can go one level of abstraction away from these low-level routines, that would be even better.
No worries on error handling. We have a greenlet responsible for brokering requests and responses. It has the smarts for retries and timeouts. It's just built on a simple asynchronous queue with some extra back pressure/high watermark stuff. The nice thing is all of this is working within a closed environment; this client only talks to one kind of server, and we have full control over the protocol on each side. The worst case we have to defend against is transient errors. Concretely, client and server are both speaking HTTP/1.1, and neither are allowed to send Connection: close headers. Keep-Alive is good, but we need to go deeper. :)
Thanks for the tip with multiple h11.Connection objects. If all else fails, this is another avenue that I can explore. And a list of objects would be roughly equivalent to the size-limited worker queue that we have now. So it's not all that gross, by comparison!

Revisiting this old ticket, since the optimization with HTTP/1.1 pipelining has come up again recently. I did some manual testing on uWSGI (which is now extremely outdated, and development is moving at a snail's pace) ... unfortunately, it closes the connection after delivering the second response (regardless how many requests are waiting on the socket), so pipelining is not possible with uWSGI.
In other words, I can't even use this library for pipelining anyway. So I am going to close this, and switch focus to replacing uWSGI with something modern that supports HTTP/2.


alert (level: fatal description internal error) in Client Hello

Hello All,
I am seeing an alert with Internal Error when accessing https://erwebdev.dnb.com/memberpages/erwebservice.asmx through  app when the site is going through a CDN. As of now, the site has been taken off the CDN. Please find the screenshot of the error below:

When accessed through a browser, it works fine. Please find the snippet below:

SessionID is not found when I check the app traffic however I see the same in browser trace.

Please provide an example application and steps to repeat..

If you example application and steps to repeat are provided, this issue will be closed...


Snow model RHS functions

Purpose
Add in the v1 snow model right hand side functions, docs, unit tests.
part of SDI #146
To-do
Content
Review checklist
I have:

followed the codebase contribution guide: https://clima.github.io/ClimateMachine.jl/latest/Contributing/
followed the style guide: https://clima.github.io/ClimateMachine.jl/latest/DevDocs/CodeStyle/
followed the documentation policy: https://github.com/CliMA/policies/wiki/Documentation-Policy
checked that this PR does not duplicate an open PR.

In the Content, I have included

relevant unit tests, and integration tests,
appropriate docstrings on all functions, structs, and modules, and included relevant documentation.

[ ] I have read and checked the items on the review checklist.

It mostly seems OK, but there are questions regarding

energy required to freeze rain, energy of falling snow. This site gets big rain events, with snow on the ground, and the resulting increase of SWE is not realistic. if there was a corresponding energy increase (due to positive energy of rain, relative reference), we might see melting?
I included a heaviside on all fluxes except P_snow, so if there is no snow on the ground, there wont be radiative heating of the snowpack, sublimation of snowpack, etc.
When S becomes too small relative to U, the resulting temperature can become unphysically low. In other models, if the snowpack is too small, the snowpack is incorporated into the first soil layer, or the first layer of the soil is incorporated into the energy of the snowpack. We could do something similar - if snow depth z < z_crit, return the ground surface temp as T_snow, T_sfc_snow. But Im not sure what value to make that. Right now the sim uses 4 inches (density is something like 300 kg/m^3), and still runs into an issue around 700 days.

It mostly seems OK, but there are questions regarding
* energy required to freeze rain, energy of falling snow. This site gets big rain events, with snow on the ground, and the resulting increase of SWE is not realistic. if there was a corresponding energy increase (due to positive energy of rain, relative reference), we might see melting? Eqn 33 here has how UEB models these terms...https://citeseerx.ist.psu.edu/document?repid=rep1&type=pdf&doi=0b0bad227ad5f056609775be9d856ebc0a92c58e

It seems consistent to approximate the energy of falling snow by rho_liqLH_f0P_snow (P_snow is in units of volume flux of liquid water), and ignore the sensible heat part, as well as the internal energy of rain.

Main change is the energy of falling snow, I believe.

I think P_rain is causing the issue with SWE

We should also add this snowmodel to the README.md?
## Models

Component Models:
RichardsModel <: AbstractSoilModel <: AbstractImExModel <: AbstractModel [runnable w/o LandModel wrapper as well]

EnergyHydrologyModel <: AbstractSoilModel <: AbstractImExModel <: AbstractModel [runnable w/o LandModel wrapper as well]

CanopyModel <: AbstractVegetationModel <: AbstractExpModel <: AbstractModel  [runnable w/o LandModel wrapper as well]

SnowModel <: AbstractSnowModel <: AbstractModel [runnable w/o LandModel wrapper as well]

Combined Models:

SoilCanopyModel <: AbstractLandModel <: AbstractModel (constructs the individual ComponentModels based on arguments)

(not sure if this is correct)


API Enable config files to be loaded for behat tests

At request of @flamerohr

I'd to investigate the breaking tests before merging

I've rebased, but some of the behat tests need fixing with https://github.com/silverstripe/silverstripe-cms/pull/1923 (not related to this PR). This broke due to the tinymce upgrade.

Ok, fixed and ready to merge.


Collection chooser does not store value

Hi Jonas,
the wagtail admin does not store the collection value. I can select a collection but when i press "save draft" of the page the collection value is empty
Wagtail 2.15.1
Any ideas...thx
Andre

Hi Andre,
thank you for your report :)
Its quite hard to tell what actually causes the fault but I'll try to give you some background information:
The ImageGalleryMixin enables the usage of blocks.GalleryBlock in wagtail pages.
The GalleryBlock hooks in instances of Album class into the page iff GalleryBlock.collection matches Album.collection.
The Album class is realized using django-modelcluster (it inherits from ClusterableModel).
From my experience, even though it is super useful, django-modelcluster can lead to pretty strange errors if the database is not as it should be. E.g. if you did not do all migrations etc.
So to come back to your problem:
There are not so many possible causes (as the collection attribute just occurs twice), as the collection does not occur that often.
Before you are digging into it further I would suggest that you check if the migrations were applied correctly

Thx for your quick answer!
I tried it again with a fresh wagtail installation...described here: https://docs.wagtail.io/en/stable/getting_started/tutorial.html (until the admin is accessible) and your instructions in the README. Migrations were successfully done.
HomePage Model
class HomePage(ImageGalleryMixin, Page):
    content = StreamField([
        #...
        ("gallery", GalleryBlock()),
        #...
    ], blank=True)

    # content panel for the CMS (same as always)
    content_panels = Page.content_panels + [
        StreamFieldPanel("content"),
    ]

Django 3.2.10
Wagtail 2.15.1
Unfortunatly same result see screenshot

Hi again,
I was able track down the error and it is actually related to wagtail>=2.13.
The last version I've tested was wagtail 2.12, sorry for that.
I just started a fresh wagtail demo like you did to reproduce the mistake. It turned out that the collection attribute is stored correctly and is read out correctly, but the attribute is not available to the AdminChooser.render_html().
After quite some research I found out that wagtail started to use some javascript rendering called telepath.
The problem was that for wagtail > 2.12 every class inheriting from  ChooserBlock (from the extention wagtail-generic-chooser needs to implement a get_form_state() function. The GalleryBlock is StructBlock that contains such an affected block CollectionChooserBlock.
To fix the problem CollectionChooserBlock (in blocks.py) needs to be extended by the following code:
    def get_form_state(self, value):
        return self.widget.get_value_data(value)

I will update this package to fix this bug.

I've updated the pypi package by upgrading wagtail-photo-gallery the error should be resolved.
pip install wagtail-photo-gallery -U

Many thanks for this quick fix Jonas! I gonna close this issue.
Merry Christmas!


On larger grids, header displayed incorrectly

On larger grid when sorting and filtering is enabled the header is displayed incorrectly.
For example I have something like this:

I'm not a css expert, but it seems to be caused by .mvc-grid-sort > display: inline-block. When disabling display: inline-block, it displays correctly:

Ye, I kind of knew about this, but didn't knew how to solve it.
So I always overrode it depending on the project.
I will give it a try again.

What exactly is the problem after removing inline-block?

I wanted to keep the space taken by the sort arrow in place, because removing it results in grid columns changing their width after sorting (because header needs more space for added sort arrow). Of course it would change it's width one way or another on tables with long data, but it works on shorter tables.

I actually found a solution, but it requires a breaking change in grid header declaration so I'm moving this together with all the other breaking changes to the v3.0.0 milestone. For now you should override mvc grid styling as it is necessary for you.

Thanks, looking forward to v3.0


Add support for GitHub token via API

This adds support for setting a GitHub authentication token via the API. Doing so increases API rate limits substantially.

Will support instead via environment variable - closing


glTF file size after Draco compression

When I'm compressing the model using Draco:
model.obj (8,000 KB) -> model.drc (204 KB)
Using glTF Pipeline:
model.gltf (304 KB) + model.bin (8,000 KB) -> modelDraco.gltf (200 KB) + modelDraco.bin (865 KB)
So .gltf file is x5 bigger than .drc. Am I doing something wrong or just completely misunderstanding the purpose of the glTF file format?
I know it's a silly question, but it can probably help beginners like me. Thanks!

@lilleyse  Does gltf w/ draco keep the model hierarchy? We work with models with multiple parts and parent/child relationships. Does your pipeline keep that structure?
Thanks!

Yes, both gltf-pipeline and Draco preserve the model hierarchy.

really? We have troubles preserving the model hierarchy by just using Draco, because it seems to merge all sub-objects into one mesh? Do you mean the sub-object ids stored within Draco and the remapping afterwards using an external hierarchy-definition file or do you store each sub-object as separate Draco file?

Make sure you are on the 2.0 branch when testing Draco.
But yes, the Draco glTF extension applies compression on a per-primitive basis and does not alter the hierarchy or combine primitives.


docs: replace gif in readme with svg

📑 Description
SVG looks much nicer than GIF
Preview: https://github.com/glasskube/glasskube/blob/kosmoz/readme-svg/README.md
✅ Checks

[ ] My code requires changes to the documentation
[ ] I have updated the documentation as required

ℹ Additional Information
I used this tool: https://github.com/marionebl/svg-term-cli

How did they merge commit passed our commit lint action? We should not merge this with this merge commit

Good question, I don't have an answer to that…

Ok LGTM


Add plotly server

I am done building and testing a plot and I encountered a problem trying to serve it outside the context of a Jupyter notebook. See the screenshot I posted here:
https://imgur.com/a/x6DLIRB
I couldn't find any documentation on this so i figured i would try to see if I could get it started as an issue.
The library i used to generate the plot is holoviews with the plotly extension. I am working with plotly because of it's 3D paths and scatter capabilities. I'm using it as a 3D model basically.

I can't spot the problem, but you might have more luck with Panel, which is set up to serve lots of different types of plots already.

Yes, the suggested workflow for this is definitely using Panel. I believe this might be sufficient for your usecase:
...
import panel as pn
pn.panel(plot_obj).show()

but you can also look at the panel deployment documentation if you need other functionality.


Please bring back working components for each code example

I like the new fully styled examples in the hero for each component. But it would be nice to still have a working component demonstrating each code example in the Examples section, e.g. https://www.radix-ui.com/docs/primitives/components/dropdown-menu#examples
As a possible alternative, is the storybook for each radix component available somewhere to try out?

We plan on having fully copy-pastable code blocks for each example in the future, but right now its more maintenance than we can afford.
The main examples have been designed in a way that showcases almost all the features that the previous examples were demoing.
For example, previously, the DropdownMenu had the following working examples
-With submenus
-With disabled items
-With separators
-With labels
-With checkbox items
-With radio items
-With complex items
-Origin-aware animations
-Collision-aware animations
Now, the hero demo contains an example of all of them in a single place.
Is there any example in particular you're missing?
About making the storybook public: let me chat with the team and get back to you.

It is unlikely that I'll use all of the features that are showcased in the main example (for any component). The previous examples that showcased each feature separately, and with minimal styling, provided a better match for how I could see using the component, and were an easier starting place for creating a PoC in code sandbox to do cross browser/device testing.
I do understand the maintenance issue given limited resources, and hopefully you'll have more resources soon.
Let me know about making the storybook public, I think that could be very useful!

I feel you. I also really liked the examples. I'm sure that we'll be able to add them again, but yeah, right now it's not possible.
Also, we don't want to keep all examples limited to Stitches. We also wanna show usage with Vanilla CSS, Styled Components, etc.
As the team grows we'll have more hands on this.
Thanks for the feedback!

+1 for making the storybook public. Hosting a static build under a subdomain would be useful.
I would like to take advantage of the composition feature offered by Storybook.
Here's a few example of frameworks that provide a static export.
Chakra
daisyUI
They can be linked into a local Storybook instance via adding this to the module.exports in main.js
  refs: {
   'Chakra': {
     title: "Chakra",
     url: "https://storybook.chakra-ui.com/",
     expanded: false // optional, true by default
   }
  }


If max inflight messages set to 1, will the sending of messages slow down?

Environment

VerneMQ Version: 1.10.1
OS: Amazon Linux 2
VerneMQ configuration (vernemq.conf) or the changes from the default:

modify this:  max_inflight_messages = 1

Expected behaviour

Publish 1000 messages in 2 seoncds to one topic, subscriber can receive the messages in time

Actual behaviour

One minute has passed since the last message was received

@FitzLu This should not happen, but yes, max_inflight_messages affects performance. Broker will send a message and wait for the PUBACK.
Check on the wire what happens if possible (Wireshark).
Also note that depending on settings as max_online_messages the broker might throw away messages to protect slow consumers.


All builds on Cuda 11.2.0 fail because Cog references a non-existing Docker image

Hey! Since yesterday I'm unable to build any image using Cog and therefore deploy any models to Replicate.
As far as I understand, an external Nvidia Docker image which is referenced here got removed from Docker Hub and causes builds on certain CUDA versions to fail.
If so, this prevents all Lambda Labs users, and probably more people, from using Cog and deploying to Replicate.
I am not entirely confident in my explanation but maybe we can figure out together.
The Error:

@mattt

facing the same issue today. can not push any model to the replicate due to this issue.

i add this version of cuda to build and it seems fixed it, at least temporary.
build:
  cuda: "11.2.2"

I was dealing with this too. It was weird because everything was working fine and then it randomly started happening. Upon further inspection, I think Nvidia have edited/removed this image.
It's strange because it even fails on the Cog Hello World example:
$ mkdir hello-world-cog
$ cd hello-world-cog/

$ cog init

Setting up the current directory for use with Cog...

✅ Created /home/sakib/hello-world-cog/cog.yaml
✅ Created /home/sakib/hello-world-cog/predict.py

Done! For next steps, check out the docs at https://cog.run/docs/getting-started

$ sed -i 's/gpu: false/gpu: true/g' cog.yaml

$ cat cog.yaml
# Configuration for Cog ⚙
# Reference: https://github.com/replicate/cog/blob/main/docs/yaml.md

build:
  # set to true if your model requires a GPU
  gpu: true

  # a list of ubuntu apt packages to install
  # system_packages:
    # - "libgl1-mesa-glx"
    # - "libglib2.0-0"

  # python version in the form '3.8' or '3.8.12'
  python_version: "3.8"

  # a list of packages in the format <package-name>==<version>
  # python_packages:
    # - "numpy==1.19.4"
    # - "torch==1.8.0"
    # - "torchvision==0.9.0"

  # commands run after the environment is setup
  # run:
    # - "echo env is ready!"
    # - "echo another command if needed"

# predict.py defines how predictions are run on your model
predict: "predict.py:Predictor"

$ sudo cog build --no-cache --debug
Setting CUDA to version 11.2
Setting CuDNN to version 11.2
Building Docker image from environment in cog.yaml as cog-hello-world-cog...
$ docker build --no-cache --file - --build-arg BUILDKIT_INLINE_CACHE=1 --tag cog-hello-world-cog --progress auto .
[+] Building 0.8s (7/7) FINISHED
 => [internal] load build definition from Dockerfile                                                    0.1s
 => => transferring dockerfile: 1.74kB                                                                  0.0s
 => [internal] load .dockerignore                                                                       0.1s
 => => transferring context: 2B                                                                         0.0s
 => resolve image config for docker.io/docker/dockerfile:1.2                                            0.2s
 => CACHED docker-image://docker.io/docker/dockerfile:1.2@sha256:e2a8561e419ab1ba6b2fe6cbdf49fd92b9591  0.0s
 => [internal] load .dockerignore                                                                       0.0s
 => [internal] load build definition from Dockerfile                                                    0.0s
 => ERROR [internal] load metadata for docker.io/nvidia/cuda:11.2.0-cudnn8-devel-ubuntu20.04            0.1s
------
 > [internal] load metadata for docker.io/nvidia/cuda:11.2.0-cudnn8-devel-ubuntu20.04:
------
Dockerfile:1
--------------------
   1 | >>> # syntax = docker/dockerfile:1.2
   2 |     FROM nvidia/cuda:11.2.0-cudnn8-devel-ubuntu20.04
   3 |     ENV DEBIAN_FRONTEND=noninteractive
--------------------
ERROR: failed to solve: docker.io/nvidia/cuda:11.2.0-cudnn8-devel-ubuntu20.04: not found
ⅹ Failed to build Docker image: exit status 1

$ sudo docker pull docker.io/nvidia/cuda:11.2.0-cudnn8-devel-ubuntu20.04
Error response from daemon: manifest for nvidia/cuda:11.2.0-cudnn8-devel-ubuntu20.04 not found: manifest unknown: manifest unknown

I agree w/ @zba adding a specific cuda version fixed the problem for me, I used...
build:
  gpu: true
  cuda: "11.1.1"
...
  python_version: "3.7"
...

Hi @andreemic. Thanks for reporting this. I'm working on a fix now with #1163, and hope to get that shipped later today. In the meantime, I recommend using the workaround suggested by @zba and @zsxkib.

@andreemic @zba @zsxkib @jabedbd @garfieldnate I just released Cog v0.8.0-beta9, which should resolve the problems caused by these missing CUDA images.
I tested with a fresh cog init project with gpu: true and was able to build successfully. Please give this release a try and let me know how it's working for you. Thanks! 🙇

I was also getting the CUDA error, I tried the Cog v0.8.0-beta9 with the "getting started" example but that's the output:
/usr/local/bin/cog: line 8: syntax error near unexpected token `newline'
/usr/local/bin/cog: line 8: `<!DOCTYPE html>'


Remove react from the monorepo

Summary
cucumber react has moved here: https://github.com/cucumber/cucumber-react
This PR is an attempt to remove it from the monorepo

Some changes on cucumber-react was not released.
That PR should be able to merge with a new release of cucumber-react


[#2941] Add function of checking if deadlock occurred in agent

deadlock information to the local log.

Codecov Report

Merging #2950 into master will decrease coverage by 0.03%.
The diff coverage is 27.77%.

@@            Coverage Diff             @@
##           master    #2950      +/-   ##
==========================================
- Coverage   37.12%   37.09%   -0.04%
==========================================
  Files        1811     1818       +7
  Lines       61472    61616     +144
  Branches     8608     8623      +15
==========================================
+ Hits        22823    22854      +31
- Misses      36263    36373     +110
- Partials     2386     2389       +3

Impacted Files
Coverage Δ

...oint/profiler/monitor/DisabledDeadlockMonitor.java
0% <0%> (ø)

...point/profiler/monitor/DeadlockThreadRegistry.java
0% <0%> (ø)

...filer/context/module/ApplicationContextModule.java
97.67% <100%> (+0.05%)
:arrow_up:

...ntext/provider/DeadlockThreadRegistryProvider.java
100% <100%> (ø)

...ercorp/pinpoint/common/util/ThreadMXBeanUtils.java
65.3% <100%> (+1.47%)
:arrow_up:

...npoint/bootstrap/config/DefaultProfilerConfig.java
55.41% <60%> (+0.14%)
:arrow_up:

...point/profiler/monitor/DefaultDeadlockMonitor.java
62.5% <62.5%> (ø)

...iler/context/module/DefaultApplicationContext.java
80% <66.66%> (-0.49%)
:arrow_down:

...iler/context/provider/DeadlockMonitorProvider.java
71.42% <71.42%> (ø)

...npoint/profiler/monitor/DeadlockMonitorThread.java
77.77% <77.77%> (ø)

... and 16 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 786c914...7099f7d. Read the comment docs.


Include arm64 arch for linux builds

@dragonwocky what do you think?
Increases a bit the build time but might be worth it, already tested it locally, and it works.

I have looked at the state of Windows for Arm64, and it doesn't seem too exciting yet, we can easily enable it in the future if we deem it necessary. Merging this and releasing rev 5


Menu Card Layout

The ratio of these pictures aren't fitting well, i would like to change the dimensions and implement round cornering along with changing the hover effects to make it more smoother.
I would request @khushi-joshi-05 and @sunny0625 to assign me this issue

@aggrhythm go ahead


Doesn't support AGP 8

Getting the error:

* What went wrong:
A problem occurred configuring project ':google_mlkit_commons'.
> Could not create an instance of type com.android.build.api.variant.impl.LibraryVariantBuilderImpl.
   > Namespace not specified. Specify a namespace in the module's build file. See https://d.android.com/r/tools/upgrade-assistant/set-namespace for information about setting the namespace.

     If you've specified the package attribute in the source AndroidManifest.xml, you can use the AGP Upgrade Assistant to migrate to the namespace value in the build file. Refer to https://d.android.com/r/tools/upgrade-assistant/agp-upgrade-assistant for general information about using the AGP Upgrade Assistant.

Pretty sure we just need to add a
    if (project.android.hasProperty("namespace")) {
        namespace 'com.google_mlkit_commons'
    }

@DanMossa : how do you reproduce this error?
How did you test the fix?

I updated my gradle to the latest version and clicked sync after I made changes

Hi, do we have an ETA of when this is going to be released?

working on it, this week


[BUG] [0.0.26] How is preventdefault:* supposed to behave?

As I'm looking into component-based routing (#543) that behaves as SPA (Component would be used as page content and it would replace portion of the current view) and MPA (Accessing the page through a route should also work), I found the following snippet in the served source:
element.hasAttribute("preventdefault:" + eventName) && ev.preventDefault();

First, I couldn't find any reference to this in the docs. Second, using it on a link (anchor element) actually worked and made the link stale and doesn't navigate to the page in href. However, adding preventdefault:click to link seems to disable onClick$ as well:
 {alert(123);}}> {/* clicking on linking causing page to navigate to /about, but shows alert as well */}
 {alert(123);}}> {/* clicking on linking doesn't do anything at all */}

So, is this the expected behaviour of preventdefault:*? And, if so, what is a situation where using it actually serves a purpose (documentation request), and if not, is this supposed to be changed into a bug issue?

seems like a bug! i will fix and update the docs to reflect this! thanks a lot for pointing this out.
because of how qwik works, user code might not be there when a click happens, to an API to preventDefault is necessary.

Thanks, @manucorporat, I'll also try to give it sometime and maybe I can figure out something about it.

Added this new docs: https://qwik.builder.io/docs/components/events#prevent-default
and new end to end tests about this feature


fix: create a method to get direct access to authorize response params

this help to manage the form_post response_mode
fixes AM-763
gravitee-io/issues#9179

Tests are OK on other PSQL version and both Mongo version. Merge the PR


Fixes assembly load failure when building Stride based project on clean machine

Related Issue
#2232
Types of changes

[ ] Docs change / refactoring / dependency upgrade
[x] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)

Checklist

[ ] My change requires a change to the documentation.
[ ] I have added tests to cover my changes.
[ ] All new and existing tests passed.
[x] I have built and run the editor to try this change out.

Thanks !

Had to revert it, see https://github.com/stride3d/stride/pull/2317


KeyError: "MaskRCNN: 'RefineRoIHead is not in the models registry'"

Hello,
I'm new to mmdetection. I installed mmcv and mmdetection successfully on my windows. But When I train refine mask I'm getting this particular key error (which is mentioned in title). Please help me to solve this error and run successfully refine mask.
https://github.com/zhanggang001/RefineMask
Traceback (most recent call last):
File "tools/train.py", line 153, in
main()
File "tools/train.py", line 126, in main
cfg.model, train_cfg=cfg.train_cfg, test_cfg=cfg.test_cfg)
File "C:\AI\RefineMask\venv\lib\site-packages\mmdet\models\builder.py", line 58, in build_detector
cfg, default_args=dict(train_cfg=train_cfg, test_cfg=test_cfg))
File "C:\AI\RefineMask\venv\lib\site-packages\mmcv\utils\registry.py", line 212, in build
return self.build_func(*args, **kwargs, registry=self)
File "C:\AI\RefineMask\venv\lib\site-packages\mmcv\cnn\builder.py", line 27, in build_model_from_cfg
return build_from_cfg(cfg, registry, default_args)
File "C:\AI\RefineMask\venv\lib\site-packages\mmcv\utils\registry.py", line 55, in build_from_cfg
raise type(e)(f'{obj_cls.name}: {e}')
KeyError: "MaskRCNN: 'RefineRoIHead is not in the models registry'"

Hi, maybe you should check your environment.
Maybe you have installed the mmdet in another folder. You can try to install mmdet under your folder,( use pip install -v -e . to install mmdet in your folder)

Hey, I have installed properly in the same folder.  Basically I'm adding custom refine_mask_head.py in models/maskheads and also refine_roi_head.py in roi_heads. I made changes accordingly. Also using '@HEADS.register_module()' as discussed in mmdet documentation under customized models.  Still do not know what is the issue of registry I'm facing. Can you tell me if you know more about this? Thank you in advance.

Because the file is not imported. You need to update the corresponding init.py or use custom_imports in your config. See examples in https://mmdetection.readthedocs.io/en/latest/tutorials/customize_models.html#import-the-module

Thank you for your response. I have sucessfully resolved the issue.

Thank you for your response. I have sucessfully resolved the issue.

i have the same issue, could you show me the solution?

run: “pip install -v -e . " in your terminal, then solved

因为文件没有导入。您需要更新相应的__init__.py或在配置中使用 custom_imports 。请参阅https://mmdetection.readthedocs.io/en/latest/tutorials/customize_models.html#import-the-module中的示例

Because the file is not imported. You need to update the corresponding __init__.py or use custom_imports in your config. See examples in https://mmdetection.readthedocs.io/en/latest/tutorials/customize_models.html#import-the-module

Hello, this link is invalid, can you send it again?

因为文件没有导入。您需要更新相应的__init__.py或在配置中使用 custom_imports 。请参阅https://mmdetection.readthedocs.io/en/latest/tutorials/customize_models.html#import-the-module中的示例

Because the file is not imported. You need to update the corresponding init.py or use custom_imports in your config. See examples in https://mmdetection.readthedocs.io/en/latest/tutorials/customize_models.html#import-the-module

Hello, this link is invalid, can you send it again?

Hi, I think this is the update link, but someone from the team could confirm. Thanks https://mmengine.readthedocs.io/en/latest/advanced_tutorials/config.html#import-the-custom-module


Basic website setup

Create the skeleton of the website and push it to the repository

Resolved as first version of website from the website brach merged to main.


Custom documentation "items"

I have a custom handler that handles a set of "formats".
I'd like to document them.
In bot.clj I found about register-extension-docs!, which seems to be for this exact purpose, but... How do one actually use it?
I tried a primitive code with typings as (register-extension-docs! "" "") (with actual values), but I get a HTTP 400 error, with the following body:
:body "{\"embed\": [\"fields\"]}"

The current use register-extension-docs! is inside of the defextension macro. It takes the keyword of the extension name as the argument and a string for documentation as the second argument.
If you're trying to add documentation to one of your extensions, that is something that is supported by the defextension macro and you could add the documentation for the formats there. See the admin extension as an example where both the extension and the subcommands within the extension are documented.

I'm building a raw message handler, and not an extension, is that still applicable?

Ahhhh I see. Raw message handlers aren't integrated into the documentation system in the same way that extensions and commands are. Changes could be made to include those in the documentation, but since they aren't invoked in the same way that extensions/commands are, it might be prudent do separate them from the standard documentation in the output.

Having a way to add some content to embed to the help embed would be nice, especially if it's a custom "command" filter, which would just add some "commands" or keywords.


Add AutoFirma Latest

If there’s a checkbox you can’t complete for any reason, that's okay, just explain in detail why you weren’t able to do so.
After making all changes to the cask:

[x] brew cask audit --download {{cask_file}} is error-free.
[x] brew cask style --fix {{cask_file}} reports no offenses.
[x] The commit message includes the cask’s name and version.

Additionally, if updating a cask:

[ ] If the sha256 changed but the version didn’t,
provide public confirmation by the developer: {{link}}

Additionally, if adding a new cask:

[x] Named the cask according to the token reference.
[x] brew cask install {{cask_file}} worked successfully.
[x] brew cask uninstall {{cask_file}} worked successfully.
[x] Checked there are no open pull requests for the same cask.
[x] Checked the cask was not already refused in closed issues.
[x] Checked the cask is submitted to the correct repo.

Hello,
This is my first attempt to make a new cask, please be gentle :)
The URL has no version, so I have used "version: latest". But the zip that is downloaded has a pkg with version number in the filename. I think that this would break when a new version is updated. Is there a better way to handle this?
Thank you all for the Homebrew project!
Regards

But the zip that is downloaded has a pkg with version number in the filename. I think that this would break when a new version is updated. Is there a better way to handle this?

Make the cask versioned and add a sha256. It’ll break anyway without it, so no point in not having it.

Thanks to @commitay for the fixes! I have spent more than an hour to figure out that I have to use double quotes instead of single quotes if I want to use the #{version} variable.

I have spent more than an hour to figure out that I have to use double quotes instead of single quotes if I want to use the #{version} variable.

That is common in languages where you use interpolation (bash also works like that): single quotes are literal, double quotes expand interpolation.

Thank you for your first contribution!


New methods

Implemented two new methods decodeToLatLng and encodeFromLatLng.
These methods works with LatLng objects instead of array. Also added support for AMD, CommonJS and Global.
cheers

Hm, I'm not sure if we want to accept this:

AMD/UMD wrapping is done by browserify if we really want to support this in this repo.
Adding a LatLng object here, which tries to mirror some-but-not-all functionality of the Google Maps one, seems like an odd way to enhance compatibility given that it's as simple as LatLng(pt[1], pt[0]) to convert back & forth

Hey @vash15, thanks for the contribution. However, being minimal and type-agnostic here is intentional. It keeps this module small and not preferential to any specific data representation other than what built-in types provide.


Need obj-c friendly constants header for cluster/attribute/command/event IDs

Problem
The existing constants are defined in C++. For darwin platform there should be an obj-c friendly header file.
Proposed Solution
Add a zap template to generate the necessary constants by themselves.

Fixed by #18172.


Use has_extension rather than deprecated validate_has_extension

With pystac 1.9 there validate_has_extension is deprecated, so there was a warning cropping up. This seemed like a simpler solution anyways.

Thanks for the PR, do you know when has_extension was added, do we need to update lower bound on pystac library for this change?

Thanks for the PR, do you know when has_extension was added, do we need to update lower bound on pystac library for this change?

Yeah it seems like has_extension has been in pystac since 1.0.0, but I take your point about pystac<1.9.0 being less flexible about how it checks for extensions.
Would it make sense to just bump up the floor for min pystac supported by this library?


Patch issue causing template visibility to get set to organizationally visible

When an admin saves changes to their template on the template details page, the visibility os getting automatically set to 'organizationally_visible' this patch carries forward whatever the current value is.

ok. I'm going to see if I can fix the failing Github action. Looks like node might be out of date on the CI builds

GitHub actions have been patched thanks to @pengyin-shan recommendation on PR #3288 to lock node at v16.6 (for now anyway)


About mask ratio in frame decoder

Thank you for sharing your work. Sincerely want a clarification about mask radio. I refer the closed issue "About 'compute_trick_metric'", adjusting seed to 42 and mask ratio to 0.5 for msrvtt, but R1 still can't not reach to  48.2 metioned in the paper.

btw，it will degrade to 44.5 when seed is 42 and mask ratio is 0.5. But when ratio is 0.5 and seed is 0 it could reach to 45.9.


Google Analytics Libraries in Demo App

You should not link the demo app to the Google Analytics libraries. You also should not distributed it with your code.
I hade to remove it to get it to build anyway.

Please issue a pull request for it
—
Sent from Mailbox
On Tue, Mar 31, 2015 at 2:58 PM, Dave Batton<EMAIL_ADDRESS>wrote:

You should not link the demo app to the Google Analytics libraries. You also should not distributed it with your code.
I hade to remove it to get it to build anyway.
Reply to this email directly or view it on GitHub:
https://github.com/EddyBorja/MLPAutoCompleteTextField/issues/77


ui things i'm doing so far

http bug (sanitizing db inputs)
margins on orgs page
making pagination look good
change background photos for login / reg (some duplicates)
fix footer
whatever else I find!!

look at some of the new images I added to the src/images folder for a possible banner! found them on some free/royalty-free site


Cannot serve .webp image in mdx

I'm using hybrid mode with mdx to render the blog content.
With @astrojs/node, the production build serves the image with .webp normally.
But with astro-bun, it is always 404 not found for images in webp format.
I checked with the png version of the same image, it serves normally.
I also ensured the webp version of the image was not broken.
[//]: # Sample mdx file in the content folder
import { Image } from 'astro:assets';

import ImageCAT6Cable from './cat6-cable.png';

some markdown content here

<figure>
  <Image
    loading={'lazy'}
    src={ImageCAT6Cable}
    alt="cat6 cable" />
  <figcaption>some caption</figcaption>
</figure>

some markdown content here

In the dev environment, it works fine.
But once I build the project and run the entry server with bun /dist/server/entry.mjs, the webp images won't be able to be served as described in the ticket.

Same result here with plain .astro files and an imported png that is converted to webp. Attempts to load it here:

404 http://localhost:4321/_astro/coffee-art.DJfGxfQ-_Z8gfae.webp


Create parser for https://www.nh.gov/covid19/

Create a web scraper for url:
https://www.nh.gov/covid19/
This Issue is to create a parser to run daily via Prefect.

Country
Organization
data_type
nid

New Hampshire
DoH

Preliminary data available

age data extracted?
hospital/ICU vs deaths extracted?
cases
cases subnational?
deaths
hospitalizations
tests

I would like to develop the scraper and additional scripts for this URL


GRL - resolution added

resolution was removed and aspect was introduced to save one divide operation in the shader, however when GREASED_LINE_SIZE_ATTENUATION is true, the vec2 resolution is needed. float aspect, vec2 resolution and float width are now packed into one vec4 attribute.

Please make sure to label your PR with "bug", "new feature" or "breaking change" label(s).
To prevent this PR from going to the changelog marked it with the "skip changelog" label.

Snapshot stored with reference name:
refs/pull/14031/merge
Test environment:
https://babylonsnapshots.z22.web.core.windows.net/refs/pull/14031/merge/index.html
To test a playground add it to the URL, for example:
https://babylonsnapshots.z22.web.core.windows.net/refs/pull/14031/merge/index.html#WGZLGJ#4600
Links to test babylon tools with this snapshot:
https://playground.babylonjs.com/?snapshot=refs/pull/14031/merge
https://sandbox.babylonjs.com/?snapshot=refs/pull/14031/merge
https://gui.babylonjs.com/?snapshot=refs/pull/14031/merge
https://nme.babylonjs.com/?snapshot=refs/pull/14031/merge
To test the snapshot in the playground with a playground ID add it after the snapshot query string:
https://playground.babylonjs.com/?snapshot=refs/pull/14031/merge#BCU1XR#0


Integrate with ark-sponge

Summary
Currently, opening challenges are univariate, such that challenges={x, x^2, x^3, ...} where x is random. Now ark-sponge is stable, so we want to use the sponge API instead. Specifically, opening challenges will have two strategies:

Univariate: Squeeze a field element x from sponge, and challenges[i] = x^{i+1}
Multivariate: For each opening challenge, we squeeze a field element

Challenge Generator and Challenge Strategy
We define the strategy as an enum, and define a challenge generator to replace opening_challenges: dyn Fn(u64)-> F.
#[derive(Copy, Clone)]
pub struct ChallengeGenerator<'a, S: 'a + CryptographicSponge> {
    sponge_state: &'a mut S,
    strategy: ChallengeStrategy
}

pub enum ChallengeStrategy {
    Multivariate,
    Univariate
}

ChallengeGenerator will have method next() to get the next random challenge.
New Interface for PolyCommit

pub trait PolynomialCommitment<F: Field, P: Polynomial<F>: Sized, S: CryptographicSponge> {
    fn setup<R: RngCore>(
        max_degree: usize,
        num_vars: Option<usize>,
        rng: &mut R,
    ) -> Result<Self::UniversalParams, Self::Error>;

    fn trim(
        pp: &Self::UniversalParams,
        supported_degree: usize,
        supported_hiding_bound: usize,
        enforced_degree_bounds: Option<&[usize]>,
    ) -> Result<(Self::CommitterKey, Self::VerifierKey), Self::Error>;

    fn commit<'a>(
        ck: &Self::CommitterKey,
        polynomials: impl IntoIterator<Item = &'a LabeledPolynomial<F, P>>,
        rng: Option<&mut dyn RngCore>,
    ) -> Result<
        (
            Vec<LabeledCommitment<Self::Commitment>>,
            Vec<Self::Randomness>,
        ),
        Self::Error,
    >
    where
        P: 'a;

    fn open<'a>(
        ck: &Self::CommitterKey,
        labeled_polynomials: impl IntoIterator<Item = &'a LabeledPolynomial<F, P>>,
        commitments: impl IntoIterator<Item = &'a LabeledCommitment<Self::Commitment>>,
        point: &'a P::Point,
        opening_challenges: ChallengeGenerator<_, S>,
        rands: impl IntoIterator<Item = &'a Self::Randomness>,
        rng: Option<&mut dyn RngCore>,
    ) -> Result<Self::Proof, Self::Error>;

    fn batch_open<'a>(
        ck: &Self::CommitterKey,
        labeled_polynomials: impl IntoIterator<Item = &'a LabeledPolynomial<F, P>>,
        commitments: impl IntoIterator<Item = &'a LabeledCommitment<Self::Commitment>>,
        query_set: &QuerySet<P::Point>,
        opening_challenges: ChallengeGenerator<_, S>,
        rands: impl IntoIterator<Item = &'a Self::Randomness>,
        rng: Option<&mut dyn RngCore>,
    ) -> Result<Self::BatchProof, Self::Error>;

    fn check<'a>(
        vk: &Self::VerifierKey,
        commitments: impl IntoIterator<Item = &'a LabeledCommitment<Self::Commitment>>,
        point: &'a P::Point,
        values: impl IntoIterator<Item = F>,
        proof: &Self::Proof,
        opening_challenge: ChallengeGenerator<_, S>,
    ) -> Result<bool, Self::Error>
    where
        Self::Commitment: 'a;

    fn batch_check<'a, R: RngCore>(
        vk: &Self::VerifierKey,
        commitments: impl IntoIterator<Item = &'a LabeledCommitment<Self::Commitment>>,
        query_set: &QuerySet<P::Point>,
        evaluations: &Evaluations<P::Point, F>,
        proof: &Self::BatchProof,
        opening_challenge: ChallengeGenerator<_, S>,
    ) -> Result<bool, Self::Error>
    where
        Self::Commitment: 'a;

     fn open_combinations<'a>(
        ck: &Self::CommitterKey,
        linear_combinations: impl IntoIterator<Item = &'a LinearCombination<F>>,
        polynomials: impl IntoIterator<Item = &'a LabeledPolynomial<F, P>>,
        commitments: impl IntoIterator<Item = &'a LabeledCommitment<Self::Commitment>>,
        query_set: &QuerySet<P::Point>,
        opening_challenge: ChallengeGenerator<_, S>,
        rands: impl IntoIterator<Item = &'a Self::Randomness>,
        rng: Option<&mut dyn RngCore>,
    ) -> Result<BatchLCProof<F, P, Self>, Self::Error>
    where
        P: 'a,
        Self::Randomness: 'a,
        Self::Commitment: 'a;

     fn check_combinations<'a, R: RngCore>(
        vk: &Self::VerifierKey,
        linear_combinations: impl IntoIterator<Item = &'a LinearCombination<F>>,
        commitments: impl IntoIterator<Item = &'a LabeledCommitment<Self::Commitment>>,
        eqn_query_set: &QuerySet<P::Point>,
        eqn_evaluations: &Evaluations<P::Point, F>,
        proof: &BatchLCProof<F, P, Self>,
        opening_challenge: ChallengeGenerator<_, S>,
    ) -> Result<bool, Self::Error>
    where
        Self::Commitment: 'a;
}

For Admin Use

[ ] Not duplicate issue
[ ] Appropriate labels applied
[ ] Appropriate contributors tagged
[ ] Contributor assigned/self-assigned

Just found out one possible way to simplify ChallengeGenerator, by merging the struct and the enum.
pub enum ChallengeGenerator<'a, S: 'a + CryptographicSponge> {
MultivariateFromSponge(&'a mut S),
UnivariateFromSponge(&'a mut S),
}
(untested)

Just found out one possible way to simplify ChallengeGenerator, by merging the struct and the enum.
pub enum ChallengeGenerator<'a, S: 'a + CryptographicSponge> {
    MultivariateFromSponge(&'a mut S),
    UnivariateFromSponge(&'a mut S),
}

(untested)

Let me try this