Nessesary steps to update actual NCA client projects from version 2.2 to 2.4

Sulu Update
Nessesary steps to update actual NCA client projects from version 2.2 to 2.4
Composer file
require
-   "doctrine/dbal": "^2.10",
-   "sulu/sulu": "~2.2.4",
+   "sulu/sulu": "^2.4",

config
+"allow-plugins": {
+    "symfony/flex": true,
+    "symfony/thanks": true
+}

Bundles
+Sulu\Bundle\ActivityBundle\SuluActivityBundle::class => ['all' => true],
+Sulu\Bundle\TrashBundle\SuluTrashBundle::class => ['all' => true],

Config files
config/packages/security_admin.yaml
+    access_control:
+       - { path: ^/admin/p/, roles: IS_AUTHENTICATED_ANONYMOUSLY }

// I could not do this in security yaml because it was empty and could not do format well
config/routes_admin.yaml
+sulu_activity_api:
+    resource<EMAIL_ADDRESS>+    type: rest
+    prefix: /admin/api
+
+sulu_trash_api:
+    resource<EMAIL_ADDRESS>+    type: rest
+    prefix: /admin/api
+
+sulu_preview_api:
+    type: rest
+    resource<EMAIL_ADDRESS>+    prefix: /admin/api
+
+sulu_preview_public:
+    resource<EMAIL_ADDRESS>+    prefix: /admin/p

Javascript and CSS asset files for admin area
Rebuild
bin/console sulu:admin:update-build

DB migrations
bin/console doctrine:migrations:diff
bin/console doctrine:migrations:migrate

Update to PHP 8
composer.json require
-"php": "^7.4",
+"php": "^8.1",

Dockerfile
-FROM php:7.4-apache AS webserver
+FROM php:8.1-apache AS webserver

Add docker-compose.override.yml
version: '3'

services:
+###> symfony/mailer ###
+  mailer:
+     image: schickling/mailcatcher
+     ports: [1025, 1080]
+###< symfony/mailer ###

// Do not know if this is needed

Composer plugins will not be handled by Sulu Rector. It alwas project choice which plugins they want to use. And when upgrading they are already asked. So the allowed-plugins is fine.
The step in the composer.json which they want to ugprade will also not be handled by Sulu Rector it always the choice of the project to which version they want to update.
PS: We recommend using ~2.4.6 not ^2.4 as we recommend doing minor upgrades of Sulu actively and not accidently.
The docker-compose should be updated by symfony/flex itself so we don't need to handle that one. Also composer.json as above need always done by the project as they need to decide which version the server is using.
So what could be automated would be SuluActivityBundle and SuluTrashBundle registration. I think we could add a rule to rector-symfony package for adding and removing a Bundle.
The yaml routes update would also be awesome. Currently we have here the same issue as in #13. Rector does not support out of the box something else then PHP files And we would need to implement a custom rector processor for yaml files like I think you did find in typo3 rector?

@rogoit did you update the Sulu Admin Build like documented: https://docs.sulu.io/en/2.5/upgrades/upgrade-2.x.html#update-the-admin-javascript-build

Fix it with best practice from here - thx for your passion
https://raw.githubusercontent.com/sulu/sulu-demo/master/config/routes/sulu_admin.yaml


[LAYOUTS] Enable ReduceOp lowering with LinearEncodingAttr

ReduceOp's lowering does not support linear layouts yet, so propagation of linear layouts across tt.reduce ops will cause codegen to crash. The codegen routine is generic enough to support linear layouts, so just enable it and add a few tests.

I'm looking into whether it's actually possible to just add LinearEncodingAttr as a supported encoding in ReduceOpHelper and do nothing else. The lowering seems generic

@ThomasRaoux it turns out just enabling linear layouts also works. I added a few tests. Please take another look if you have time

@ThomasRaoux it turns out just enabling linear layouts also works. I added a few tests. Please take another look if you have time

it makes sense that it works in general, the implementation is quite generic indeed.
I do believe that there are some implicit assumptions on layouts in case there are some duplicated values and those would break for some layouts. We assume that the first lanes will
have unique values and we have some special cases for sliced layout for this reason:
https://github.com/triton-lang/triton/blob/755d4164081b92a909df2e1ad4c56174c8ce5529/lib/Conversion/TritonGPUToLLVM/ReduceOpToLLVM.cpp#L226
I believe the linear layout version of some sliced layout would fail for instance.
That's a bit of the challenge of enabling linesr layout since we don't test all the potential weird layout generated.
I think this PR is fine but I wonder if we could find a way to test more exotic linear layouts at some point in order to have confidence that the lowering to llvm is robust.

I think this PR is fine but I wonder if we could find a way to test more exotic linear layouts at some point in order to have confidence that the lowering to llvm is robust.

Fuzzer....!

yes most likely we will need something like that. One thing that would most likely expose those special cases in the meantime would be to run a pass that convert legacy layouts to linear layout for testing. I would expect this tests to expose some of the problems:
https://github.com/triton-lang/triton/blob/755d4164081b92a909df2e1ad4c56174c8ce5529/python/test/unit/language/test_core.py#L6316

A good layout to start with here would be to test DotOperandEncoding(NvidiaMma) with warps = [8, 4] for example. This have a funny broadcasting on the warps along K that will break quite a few of the assumptions. Now, I don't expect fixing it to be terribly difficult, we'll just need to extend a few of these functions to implement them on LLs


Update smithy4s-aws-http4s, ... to 0.18.25

About this PR
📦 Updates

com.disneystreaming.smithy4s:smithy4s-aws-http4s
com.disneystreaming.smithy4s:smithy4s-sbt-codegen

from 0.18.16 to 0.18.25
📜 GitHub Release Notes - Version Diff
Usage
✅ Please merge!
I'll automatically update this PR to resolve conflicts as long as you don't change it yourself.
If you'd like to skip this version, you can just close this PR. If you have any feedback, just mention me in the comments below.
Configure Scala Steward for your repository with a .scala-steward.conf file.
Have a fantastic day writing Scala!

⚙ Adjust future updates
Add this to your .scala-steward.conf file to ignore future updates of this dependency:
updates.ignore = [ { groupId = "com.disneystreaming.smithy4s" } ]

Or, add this to slow down future updates of this dependency:
dependencyOverrides = [{
  pullRequests = { frequency = "30 days" },
  dependency = { groupId = "com.disneystreaming.smithy4s" }
}]

labels: library-update, early-semver-minor, semver-spec-patch, version-scheme:early-semver, commit-count:1

Superseded by #178.


FIX Handle modules that are checked out as tags

Issue https://github.com/silverstripe/cow/issues/234
colymba/gridfield-bulk-editing-tools checks out as a tag 3.0.2 when installing recipe-kitchen-sink 4.x-dev - This PR will attempt to switch its branch to 3.0 so that it can proceed as normal.
colymba/gridfield-bulk-editing-tools is a caret in recipe-blog 4.x-dev - https://github.com/silverstripe/recipe-blog/blob/1/composer.json#L17 hence why the tag is installed

Have fixed regex, changed code a little and added unit test


lib/utils: add literalLua & nestedLiteralLua option docs

Creates a literalExpression equivalent to using lib.nixvim.mkRaw.
This can be used in place of { __raw = "foo"; } in option docs and provides us with a central place where we would be able to switch to documenting lib.generators.mkLuaInline instead.
Design considerations:

The name: I went with literalLua instead of literalMkRaw because it seems likely we'll want to transition away from mkRaw in the future.
I am a little concerned that end-users will stumble upon literalLua and not realize it is intended for documentation though...
I've used the full lib.nixvim.mkRaw path for clarity. But this has its own issues since non-standalone users will have a different path.
Perhaps just mkRaw would be better? Either way, we're relying on users understanding other parts of our docs to interpret the context.

If we switch to lib.generators.mkLuaInline then the above problem goes away, but there's more prep work to do before we can do that.
See #1935

The function returns a literalExpression. This can be used directly with pluginDefault, defaultText, and example, but cannot be nested within a non-larger value.

If we need that, we'll need another function that produces a __pretty printer, as supported by lib.generators.toPretty.
Such a function could wrap this one, and could be called something like nestedLiteralLua.
EDIT: Done in a follow up commit, included in this PR

@mergify queue

@mergify queue


feat(prettier) print for in statements

Current dependencies on/for this PR:

main

PR #1384

PR #1385

PR #1386   👈

PR #1387

This stack of pull requests is managed by Graphite.

Merge activity

Nov 17, 12:36 PM: @Boshen started a stack merge that includes this pull request via Graphite.


Artifact name using expressions or variables

I want to be able to create an artifact with a dynamic name, like: artifact-{dd.MM.yyyy} will become artifact artifact-01.01.2017 or something like that.  Is that possible or will be supported in a near future?

Will post a more detailed escenario once as soon as possible

More detailed scenario.
I am using VSTS online in: https://*.visualstudio.com//_build and one of my build definitions, I want to set the following pattern:

So this: drop-{dd.MM.yyyy} will become in: drop-08.24.2017 I dont know if there is such functionality, however I really dont know how to set it up correctly.
I was able to do that on Team City relatively easy: https://confluence.jetbrains.com/display/TCD9/Configuring+General+Settings
Hope this helps a little.
Thanks

This is related to process parameters.

Closing outdated issue. @zaiboot if you require this support, please re-activate it with the following details.

How are using "Artifact Name" to really associate an artifact. Are you using ##vso command OR rest API.
Share sample build for repro.


.CF/ Config.json file access denied when login in, please help

Command

What occurred
Microsoft Windows [Version 6.1.7601]
Copyright (c) 2009 Microsoft Corporation.  All rights reserved.
C:\Users\IBM_ADMIN>
C:\Users\IBM_ADMIN>cf login
FAILED
Config error: open C:\Users\IBM_ADMIN.cf\config.json: Access is denied.
API endpoint: https://api.ng.bluemix.net
FAILED
Config error: open C:\Users\IBM_ADMIN.cf\config.json: Access is denied.
FAILED
Config error: open C:\Users\IBM_ADMIN.cf\config.json: Access is denied.
FAILED
Config error: open C:\Users\IBM_ADMIN.cf\config.json: Access is denied.
FAILED
Config error: open C:\Users\IBM_ADMIN.cf\config.json: Access is denied.
FAILED
Config error: open C:\Users\IBM_ADMIN.cf\config.json: Access is denied.
FAILED
Config error: open C:\Users\IBM_ADMIN.cf\config.json: Access is denied.
FAILED
Config error: open C:\Users\IBM_ADMIN.cf\config.json: Access is denied.
FAILED
Config error: open C:\Users\IBM_ADMIN.cf\config.json: Access is denied.
FAILED
Config error: open C:\Users\IBM_ADMIN.cf\config.json: Access is denied.
FAILED
Config error: open C:\Users\IBM_ADMIN.cf\config.json: Access is denied.
Email>
What you expected to occur
To be able to login in CF in a normal way, I have tried everything but for whatever reason now system does not allow to check config.json file
CLI Version
cf-cli-installer_6.34.1_winx64
CC API Endpoint Version
<Request error: Get https://output/v2/info: dial tcp: lookup output: no such host
TIP: If you are behind a firewall and require an HTTP proxy, verify the https_pr
oxy environment variable is correctly set. Else, check your network connection.
FAILED
Error writing config: rename C:\Users\IBM_ADMIN.cf\temp-config214146711 C:\User
s\IBM_ADMIN.cf\config.json: Access is denied. -->
CF Trace
<C:\Users\IBM_ADMIN>cf -v
cf version 6.34.1+bbdf81482.2018-01-17
Error writing config: rename C:\Users\IBM_ADMIN.cf\temp-config550775619 C:\User
s\IBM_ADMIN.cf\config.json: Access is denied.>
Platform & Shell Details
<Windows 7 64bit->
Any other relevant information

Solved by including the CF_HOME path to .cf in the environment variables
Thanks anyway


Error: SBM requires a Maven build file. Please provide a minimal pom.xml.

Describe the bug
Spring Boot migrator fails to scan source directory
SBM Version
0.13.0
SBM Application
spring-boot-migrator
To Reproduce
Steps to reproduce the behavior:

We ran the migrator outside of the source folder and then type "scan c:\sources\". Here's the output:

scanning 'C:\sources\'

Checked preconditions for 'C:\sources\'
 [X] SBM requires a Maven build file. Please provide a minimal pom.xml.
[ok] 'sbm.gitSupportEnabled' is 'true', changes will be committed to branch [master] after each recipe.
 [!] Java 11 or 17 is required. Check found Java 20.
 [X] PreconditionCheck check could not find a 'src/main/java' dir. This dir is required.

If we put migrator tool in the source folder, run it and type "scan ." then scan process is working as expected.
Expected behavior
Spring Boot Migrator should scan the source folder.
Desktop (please complete the following information):

OS: Windows
Version 10

Hi @sergey-morenets
In my understanding, scan will work inside migrator. Because, we'll run the migrator jar and then we will execute scan <path-of-the-application>
https://github.com/spring-projects-experimental/spring-boot-migrator#spring-boot-30-migrator---java-cli
I am happy to assist you further.
Thanks,
Mahi

Hi @bsmahi
Let me clarify my steps. Can I do the following?

Put migrator jar into c:\Temp folder
Run migrator and type "scan c:\sources''

Source project is in the c:\sources folder.

Hi @sergey-morenets
Does your path of the application contains any Pom.xml?
If not, we should have pom.xml in the source application for further scanning.
I hope that helps, am happy to assist you further.
Thanks,
Mahi

@bsmahi
Yes, it contains pom.xml. I wrote in the original post that if I put migrator jar into the source folder and type "scan ." then scanning works correctly.

@sergey-morenets
Is it possible to zip it sources which you're checking. Will verify it.
Have followed the same steps as yours by taking out simple-jms(which was in side/spring-boot-migrator-main/testcode) and placed it in C:/

Ran spring Boot migrator
Executed scan C:\simple-jms

Thanks,
Mahi

Hi @bsmahi thank you very much for assisting during my leave!
If I understood correct than the problem ghas been solved?
@sergey-morenets I will close the issue now. If the problem persists feel free to reopen again.


Support for ?

The current v<IP_ADDRESS> does support RowLimit tag? If not, it's possible to extend Query class in any way to render  tag? Please see: https://docs.microsoft.com/en-us/previous-versions/office/developer/sharepoint-team-services/dd588460(v=office.11)
I did not find a way to "naturally" extend the Query class, which seems to implement Builder pattern and It's ok. So in the .NET solution I'm working on I've created my own CamlQueryBuilder only to extend behavior of Query class. In my CamlQueryBuilder I've a method that does the following as a workaround:
    protected override CamlQuery InternalBuild()
    {
      this.BuiltInstance.ViewXml = this.GetViewXml();
      return base.InternalBuild();
    }

    private string GetViewXml()
    {
      return string
        .Concat(
          "<View>",
          Query
            .Build(this.WhereBuilder.Build())
            .OrderBy(this.OrderByFieldRefs)
            .GetCaml()
            .RemoveNewLine()
            .RemoveWhitespaceBetweenXmlTags(),
          this.GetRowLimitCaml(),
          "</View>");
    }

    private string GetRowLimitCaml()
    {
      return this.RowLimit > 0 ? string.Format("<RowLimit>{0}</RowLimit>", this.RowLimit) : string.Empty;
    }

Finally, a nuget package which works with .NET Core. Looks like this is the only thing missing for me that I currently use.

This package was originally meant to generate CAML against the Query schema while RowLimit seems to be part of the List schema and by adding it I would have to add support for pretty much all elements missing from the List schema.
Does it really work with Query schema? I might consider to add it if it does and it's blocking people from using the library.

Thanks for your reply. I'm not a SharePoint expert, only a beginner. It looks like if you just put View tags around it, it works without any problems for the Lists I used it for. I must say I only tested a single Equal operator 😁. Except for #14 that I encountered, which I think it would also be a problem for the one you designed it for.


Users/kmkumaran/release visibility m83

Fixing the Visibility of Tasks for Sprint 83 Release Management Update

Wrongly done PR. Closing it.


Determine DC/OS version from leader's endpoint

@gabrielhartmann Is this to determine whether cluster is DCOS 1.9 or 1.10?

@mbdcos: yes

retest this please

retest this please


Feature Request: Move config files to separate config folder

Hi,
I'm running EMHASS on unRAID, unfortunately docker on unRAID only supports path mapping, no individual files.
Currently I map the whole app folder. EMHASS works but I need to update the app folder manually after every update.
Do you see the option to move all config related files to a separate config folder?
This will allow proper path mapping on unRAID.
Regards,
Tim

Hi,
I indeed use the docker method. However the docker implementation in unRaid only allows me to map a complete folder of the filesystem to a folder in the docker container. I cannot map an individual file as whats proposed in the documentation.
I need to map a complete folder to the docker container that should contain the config files as well as all the files needed to run EMHASS. This is because EMHASS expects the config.yaml and secrets.yaml be in the root of EMHASS.
If EMHASS is adapted so that the config and secrets file in a config folder as how you manage the data folder I can map only that container folder to a folder on the filesystem.
EMHASS scripts stay within the container, "user" files can be mapped outside the container by mapping the /config and /data folders to the filesystem of the docker host.
Regards,
Tim

Ok, I get it now. I'll take a look at this and possibly add an additional flag to be used to provide a folder where you can put your configuration files.

Ok so the code is just expecting that config_emhass.yaml and secrets_emhass.yaml are located in the app/ folder inside the docker container.
So first solution will be to set the volume to map your local folder.
Something like this:
docker run -it --restart always -p 5000:5000 -e "LOCAL_COSTFUN=profit" -v $(pwd):/app --name DockerEMHASS <REPOSITORY:TAG>

But I'm not sure if this will copy the configuration files inside your local folder.
Otherwise a second solution will to mount and copy the files like this:
docker run -it --restart always -p 5000:5000 -e "LOCAL_COSTFUN=profit" --mount type=bind, source="$(pwd)"/emhass_config_files, target=/app cp <files> /app --name DockerEMHASS <REPOSITORY:TAG>

You will need to change the cp part to test if it works for copying your files.

Hi,
This is how I map the config and secrets file now.
The only issue with that is that I now have to maintain the whole app folder outside the docker container because its mapped to a local folder. This means that I manually have to copy the git repo to this local folder to update EMHASS as well as updating the container itself. This beats the purpose of using a docker container.
If config and secrets would move to for example /app/config I would be able to only map /app/config to a local folder.
The files that makeup EMHASS are untouched since they stay part of the docker container.
Regards,
Tim

With the new version you can map the configuration an secrets file using the CONFIG_PATH and SECRETS_PATH environment variables respectively when using the docker run command.
I will be closing this as completed now but feel free to re-open if needed.


Add Node and EndpointSlice handlers to metaProxier

Signed-off-by: Hongliang Liu<EMAIL_ADDRESS>

/test-all

e2e failed on known flaky test https://github.com/antrea-io/antrea/issues/4477

Do you know why "Check tidy, code generation and manifest" is failing?

Do you know why "Check tidy, code generation and manifest" is failing?

Do you know why "Check tidy, code generation and manifest" is failing?

I run this test based this patch, and it passed. I'll add a -x option to the corresponding script hack/add-license.sh to see the output on github action to see the output.

Do you know why "Check tidy, code generation and manifest" is failing?

Resovled @tnqn

/test-all

/test-ipv6-all
/test-ipv6-only-all

/skip-e2e which failed on known flaky test

/skip-e2e


(from PUP-6127) clientnoop agent fact not more working starting from Puppet 4.4.1

https://tickets.puppetlabs.com/browse/PUP-6127
Hi,
Starting from Puppet 4.4.1, the clientnoop agent fact makes the catalog compilation failing.
I didn't find any trace of deprecation in the Puppet 4.4, 4.3 or even 4.2 changelogs.
The exact message I get from my TravisCI unit tests is:
Evaluation Error: Unknown variable: '::clientnoop'
Rudy

rspec-puppet does not emulate a full execution environment to provide developers with full control to exercise their code.
If you need prefabbed facts, have a look at https://github.com/mcanevet/rspec-puppet-facts , which provides canned full-system facts for easy use in tests.
cc @ryayon

A simple example to add just the clientnoop noop flag, put let(:facts) { { :clientnoop => "true" } } into your test suite.


Move --squash from experimental to released

Tell us about your request
docker build --squash has been around since 2017. Completing this feature would allow much more readable Dockerfiles, and would remove a learning step for Docker beginners.
Which service(s) is this request for?
Docker engine and CLI.
Are you currently working around the issue?
Through lots of ampersands. Chaining commands so they do not add individual layers makes things hard to read, but achieves the same effect.

Are there any plans to remove the experimental status from --squash?

Hi @robertlagrant and @tobiasstadler, thanks for posting this proposal!
I have two quick questions that would help me better understand your use cases:

Why are you currently using --squash? (Phrased another way, what goal are you achieving using this flag)
Have you tried multistage builds and/or heredoc support?

Hi @robertlagrant
I am copying some (large) files to populate a PostgreSQL DB. As these file aren't used after populating the DB I want to get rid of them.
As you sad, I could created the DB in a "builder" container and only copy the PostgreSQL data files to to actually container, but using --squash feels little bit nicer/easier.
I am not sure if I could use heredoc.


Use title and abstract as query in Open Research corpus

Similarly to Bhagavatula et. al (2018), use the concatenation of title and abstract as a query and use Whoosh's key_terms_from_text method to shorten the query.
Also, it would be interesting to experiment with raw title+abstract as a query.

The output of using title + abstract
map                   	all	0.0626
recip_rank            	all	0.3512
P_20                  	all	0.0811
recall_20             	all	0.1132
recall_1000           	all	0.3628
F1_20					0.0945

WOW!!!
This is filtering terms with key_terms_from_text or the simple concatenation of raw title and abstract?

This is the simple concatenation :)

The output of using key terms in both title and abstract
map                   	all	0.0412
recip_rank            	all	0.2521
P_20                  	all	0.0546
recall_20             	all	0.0790
recall_1000           	all	0.2818

F1_20					0.0646

Interesting. So Bhagavatula et. al (2018) used a technique that experiments demonstrate not to help?


Translation home page

We'd love someone to help us to the translation piece on the website. You'll see that there is currently just all the translations available as a text. We want people to be able to use a text box to translate and get their translation back.
Let us know if you want to help out here.

@mishmanners I'd like to give this a shot

Yes please go ahead @alt-shreya

@mishmanners while trying to setup the website locally, I encountered some vulnerabilities.
Might want to take a look: 7 vulnerabilities (1 low, 2 moderate, 3 high, 1 critical)
The way I worked around this was to run npm audit fix


Add UMD bundle for @xstate/react.

The pull request is based on #1108.
The pull request should close the following issue: https://github.com/davidkpiano/xstate/issues/1736

Thanks @dimitardanailov! Can you also add a changeset?

yarn changeset
Enter a changeset to make a minor change for @xstate/react, describing that you're adding UMD bundles.

@davidkpiano
Please review my commit: https://github.com/davidkpiano/xstate/pull/1738/commits/b4f8dd4232b0567f218d8f53b438ffdd03d293f4

@Andarist
Thank you very much for the additional advices. I've created three new commits. Please review my improvements.

Thanks!

@Andarist and @davidkpiano
Thank you very much for the collaboration. I'd like to share: What I found. Before that: I'd like to give you access to my playground area:
branch: xstate-react-umd -> https://github.com/dimitardanailov/react-components/tree/xstate-react-umd
Component:
https://github.com/dimitardanailov/react-components/blob/xstate-react-umd/packages/d3-tree-collapsible/app/components/D3Tree.js
The component throws an error if the import is:
const { useMachine } = XStateReact

The error is: react-hot-loader.development.js:297 ReferenceError: process is not defined

My recommendation is: https://www.npmjs.com/package/@rollup/plugin-replace
The package is able to replace string sections in the particular file.
What do you think ?

Ah - yes. This is the appropriate approach. I've missed that this will be required during the code review. Are you willing to prepare a PR with the fix?

@Andarist
Please review my pull request:
https://github.com/davidkpiano/xstate/pull/1756


does not work with material ui

Seems does not work with atom-material-ui
Can you confirm?

Atom 1.0.7
OSX 10.10.5

Sorry my mistake. Theme has an option to set. Also without this package, icons are still on tab bar thanks to theme.


Update fused moe kernels

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.


Specified cmake project type CXX (#152)

This fixes "error: unrecognized command line option
‘-Wno-gnu-zero-variadic-macro-arguments’ [-Werror]" when using
gcc>=7.2.1

Can you explain why this is the case? The default values for project() include CXX already.

I've hit that too.
Cmake defaults to both C and CXX:

Optionally you can specify which languages your project supports. [...] By default C and CXX are enabled if no language options are given.

Also the cause of this problem may be the fact that check_cxx_compiler_flag() macro only checks compiler's output based on regex so -Werror flag will make it fail:

Since the try_compile() command forwards flags from variables like CMAKE_CXX_FLAGS, unknown flags in such variables may cause a false negative for this check.

Honestly I have no idea why specifying the language explicitly fixes that. Maybe the excessive C in default adds some flags that cause it to fail?
Also as g++ never had such a flag (there's -Wno-variadic-macros) it should fail with gcc<7 too...

Hmm, I'd like to understand why that fixes it. So, I'll leave this open for now as a workaround for people and look into it again as soon as I have time.
Specifically I'd like to know why this check passes:
https://github.com/ros2/rviz/blob/b5ab260c28e7bcad345f17431e8d45d7066669d6/rviz_common/CMakeLists.txt#L23
As you guessed it might be a bug in the CMake macro...

I have another guess: this can also happen if gcc >= 7 applies the -Werror directive to its flags. So even with it specified the older versions would only complain on the output while the newer one exits with exit code != 0. This is just a guess, though I'll try to verify it.
However I've tried something different: Without specifying the language of the project, I moved the add_compile_options(-Wall -Wextra -Wpedantic -Werror) below the check_cxx_compiler_flag().
Result:
...
-- Performing Test HAS_W_FLAG
-- Performing Test HAS_W_FLAG - Success
...

I think that's a better solution.

I agree.


Using kafkajs on nodejs cluster consumes all inodes

We are using kafkajs with nodejs cluster. Forking multiple workers, one for each partition. Service consumes inodes each minute and never releases. What could be the cause of it?

@vasmanas can you post some example code? I've tested the cluster code running one consumer per worker. In my example, I have a topic with 6 partitions, and I run 6 workers, each consuming from one partition. This example worked fine, but I haven't checked the inodes.
Or perhaps you are talking about consuming the messages and passing to workers for processing?
My example, based on the consumer example in the repo: https://gist.github.com/tulios/1605365a6c136c9726172a364bdcfc64

@tulios here is a simplified code example that we use:

@tulios here is a simplified code example that we use:

@tulios here is a simplified code example that we use:
const cluster = require('cluster');
const { Kafka } = require('kafkajs');

const clusterMap = {};
const numWorkers = 10;

const createWorker = (env) => {
  const worker = cluster.fork(env);
  clusterMap[worker.id] = env;
};

const onExit = (worker) => {
  try {
    const workerEnv = clusterMap[worker.id];

    // delete the process from the cluster map
    delete clusterMap[worker.id];

    // WORKER AUTO-RESTART
    setTimeout(() => {
      console.info('restarting...');
      createWorker(workerEnv);
    }, 3000);
  } catch (e) {
    console.log(e);
  }
};

const masterRunner = async () => {
  cluster.on('exit', onExit);

  for (let i = 0; i < numWorkers; i + 1) {
    createWorker({ index: i });
  }
};

const workerRunner = async () => {
  const kafka = new Kafka({
    clientId: 'myClientId',
    brokers: ['<IP_ADDRESS>:9092'],
    heartbeatInterval: 10000,
    sessionTimeout: 120000,
    maxBytes: 524288,
    maxWaitTimeInMs: 30000,
  });

  const consumer = kafka.consumer({ groupId: `${process.env.group}` });

  try {
    await consumer.connect();
    await consumer.subscribe({ topic: process.env.topic });
    await consumer.run({
      autoCommitThreshold: 10,
      eachMessage: async ({ topic, partition, message }) => {
        const prefix = `${topic}[${partition} | ${message.offset}] / ${message.timestamp}`;
        console.log(`- ${prefix} ${message.key}#${message.value}`);
      },
    });

    const awaitStop = new Promise((resolve, reject) => {
      const { STOP } = consumer.events;

      consumer.on(STOP, (e) => {
        try {
          console.log(`stop at ${e.timestamp} - ${JSON.stringify(e)}`);
        } catch (error) {
          reject();
        } finally {
          resolve();
        }
      });
    });

    await awaitStop;
    await consumer.disconnect();
  } catch (e) {
    console.log(e);
    await consumer.disconnect();

    throw e;
  }
};

const run = async () => {
  try {
    if (cluster.isMaster) {
      await masterRunner();
    } else {
      await workerRunner();
    }
  } catch (e) {
    console.log(e);
  }

  if (cluster.isWorker) {
    process.exit();
  }
};

run();

You are creating infinite workers. I logged the clusterMap every time createWorker was being invoked. This is the output after about half a second:

It's because you are not re-assigning the value of i in your for-loop.
This is an infinite loop: for (let i = 0; i < 10; i + 1) {}. To make it actually terminate, you need to reassign i: for (let i = 0; i < 10; i++) {} or for (let i = 0; i < 10; i = i + 1) {}.


Which certificate file types?

First of all, thank you for this amazing project!
I have created server certificate files using Let's Encrypt and Certbot. Now I wonder which files I need to copy into the server.key and server.crt files?
The Certbot has created the following files: cert.pem, chain.pem, fullchain.pem and privkey.pem.

So the answer is:

Copy privkey.pem to server.key
Copy fullchain.pem to server.crt

HOWEVER...
There is a bug in the manifests. When doing make deploy a secret named ingress-secret is created with the contents of the aforementioned files in the namespace monitoring.
However, the manifest file for the grafana etc spells the secretName to be ingress-TLS-secret which doesn't match. The result is a 404 page on the ingress URL.

I've created a pull request with a fix.

Actually found the error. Was in the utils.libsonnet where the secret name was hardcoded. Fixed in https://github.com/carlosedp/cluster-monitoring/commit/b617576d64b1f5da5215facdf872dfc6cd260e3c
Thanks for finding this out.

Hello again,
unfortunately, the latest patch does not work:
$ make deploy
[...]
servicemonitor.monitoring.coreos.com/traefik created
The Secret "ingress-TLS-secret" is invalid: metadata.name: Invalid value: "ingress-TLS-secret": a DNS-1123 subdomain must consist of lower case alphanumeric characters, '-' or '.', and must start and end with an alphanumeric character (e.g. 'example.com', regex used for validation is '[a-z0-9]([-a-z0-9]*[a-z0-9])?(\.[a-z0-9]([-a-z0-9]*[a-z0-9])?)*')
make: *** [deploy] Error 1

Fixed in https://github.com/carlosedp/cluster-monitoring/commit/b617576d64b1f5da5215facdf872dfc6cd260e3c.
Please check.

It works - thanks!


CloudException when creating Shared Access Key for queues

The following results in CloudException 400. I tried every possible way to send in the parameters with no luck:
                var existingAuthRule = new ServiceBusSharedAccessAuthorizationRule();
                existingAuthRule.KeyName = "RootSharedPolicy";
                existingAuthRule.ClaimType = "SharedAccessKey";
                existingAuthRule.ClaimValue = "None";
                existingAuthRule.PrimaryKey = "Hk2z8drWINmeqtF03QxJrX2WMAI31liWHjPkVg/uRKk=";
                existingAuthRule.SecondaryKey = "DPLZoUthvQQH8qSiB3DmosVzMIoD61WQMUKWni2vwrs=";
                existingAuthRule.Rights.Add(AccessRight.Send);
                existingAuthRule.CreatedTime = DateTime.Now;
                existingAuthRule.ModifiedTime = DateTime.Now;
                existingQueue.AuthorizationRules.Add(existingAuthRule);
                var resp = s.Queues.Update(serviceBusNamespaceName, existingQueue);

Closing this issue.
@kurtng Please fee free to reopen this issue if you still are getting an exception. By the way, please do not include actual keys on any code snippets. Those are your credentials and should not be shared.


Generic OpenMPI support

Description of changes:

generic OpenMPI support

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@mvsusp
To clarify: we talked offline, but I wouldn't ship this if it were up to me.

Codecov Report

Merging #157 into master will decrease coverage by 0.42%.
The diff coverage is 91.36%.

@@            Coverage Diff             @@
##           master     #157      +/-   ##
==========================================
- Coverage   93.34%   92.91%   -0.43%
==========================================
  Files          21       25       +4
  Lines         976     1157     +181
  Branches       96      116      +20
==========================================
+ Hits          911     1075     +164
- Misses         43       54      +11
- Partials       22       28       +6

Impacted Files
Coverage Δ

src/sagemaker_containers/_entry_point_type.py
100% <100%> (ø)

...rc/sagemaker_containers/beta/framework/__init__.py
100% <100%> (ø)
:arrow_up:

src/sagemaker_containers/_trainer.py
93.61% <100%> (+0.28%)
:arrow_up:

src/sagemaker_containers/entry_point.py
100% <100%> (+4.65%)
:arrow_up:

src/sagemaker_containers/_env.py
97.5% <100%> (+0.05%)
:arrow_up:

src/sagemaker_containers/_process.py
100% <100%> (ø)
:arrow_up:

src/sagemaker_containers/_timeout.py
100% <100%> (ø)

src/sagemaker_containers/_runner.py
100% <100%> (ø)

src/sagemaker_containers/_params.py
100% <100%> (ø)
:arrow_up:

src/sagemaker_containers/_mpi.py
82.72% <82.72%> (ø)

... and 4 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update faa3b3a...bdad2bb. Read the comment docs.


Update README.md

typo on needed

Thanks Iain =)
Maybe, it would be interesting for you to help me with documentation
https://github.com/AndreiMisiukevich/CardView/issues/13
=)


[Fix] Proposed resolution of issue #230: remove PICS from timesync tests

Possible fix for issue 230: remove PICS from timesync tests:

Removed if statement checks with PICS from timesync tests 2_1 and 2_2
Added self.wait_for_user_input() to allow user input for timesync test 2_1 if using TSC, NTPC, NTPS, or TZ features on DUT.

Updated method for this fix after being provided some further information from Cecille on Tuesday:

Removed using the self.wait_for_user_input() to reusing established code from TestCommisioningTimeSync.py to gather supported features from DUT to use in place of if statements in timesync 2_1 test module.


Release

Hi there,
Wondering if you were planning a new official and stable release soon? That would just make production setups way safer with more warranties of stability versus using the latest master. Lots of libraries are also relying on luasocket and nothing has changed for 2 years now.
Best,
Thanks

I agree we should release a version. But things are changing every now and then. Sometimes in a significant way.

Would it be possible to create a new branch (called v3.0-rc1.x?) from v3.0-rc1 tag, cherry pick only fixes from master and tag a new release on that branch?

For sure. We can all rely on the semantic versioning for that reason and use major versions when you're in that position.
Also I know this is out of subject here but in case you know somebody has ever used this library with HAProxy, I'd be interested in the revision or version (rc1?) he/she used.
Have this error when loading socket.http (LUA 5.3.1, HAProxy 1.6.3, latest master from this repo):
[ALERT] 040/151350 (790) : parsing [haproxy_ksa.cfg:4] : lua runtime error: error loading module 'socket.core' from file '/usr/local/lib/lua/5.3/socket/core.so':
	/usr/local/lib/lua/5.3/socket/core.so: undefined symbol: lua_gettop

Thanks again :+1:

@florrain: I suspect that HAProxy doesn't re-export the Lua symbols from its executable. Lua modules on Unixes expect that. If HAProxy links to liblua.so, one alternative would be to link your socket.core to liblua.so as well, but that would make the module incompatible with the normal Lua interpreter (and I think LuaRocks doesn't support this mode of operation anyway). You could also try to re-export the symbols from the shared library using some FFI interface like in this stackoverflow answer.

Thanks @siffiejoe that's helpful. I'm not sure how to actually do these steps but I'll look into it.

@florrain: The developers of HAProxy should fix this by using the -Wl,-E flag when Lua is statically linked to the main executable, or by loading the Lua API from the shared Lua library with RTLD_GLOBAL otherwise. However, I've just released a small module which tries to fix the Lua API export issues. I've tested it on Linux, but it should work on other Unixes as well (BSDs for instance). It's also on LuaRocks, but only in the DEV manifest for now. You'd have to require it before any other C based module.

Linked to https://github.com/diegonehab/luasocket/issues/93

I'm going to close this because I don't see anything very relevant that needs to be reviewed specifically for the next release cycle. I'm going to push through a release sooner rather than later (100% done or not) to get the Lua 5.4.3+ fixes into something with a tag on them, but I don't think having a bunch of tracking issues asking "when release" is helping.
The only thing here I think we need to consider is what version (semantically speaking) to call a new release at this point. But I think that will belong in its own issue anyway.


Cryptic error when using .bsts with arches

See original issue on GitLab
In GitLab by [Gitlab user @aevri] on Oct 19, 2017, 10:15
When trying to load a pipeline with an element specifying the old 'arches' statements, a cryptic error is emitted:
KeyError: "Key not found in the first mapping: 'kind'"

I'd expect something more along the lines of:
Error loading pipeline: [arches.bst [line 3 column 1]]: Unexpected key: arches

Repro'd using empty project and single arches.bst:
kind: import
description: Import tar
arches:
  x86_64:
    sources:
    - kind: tar
      url: https://server.example/tar.tar.gz
      base-dir: ""

Tested at a243a3335b7c113a49b1d5f0daa2c11efe2299bd, '.gitlab-ci.yml: Issue #100 - Avoid installing setup.py test_requires'.
Broken since 4488ddf55034c4b00c9ce221f303f205e13c85a9, '_yaml.py: Implement array composition directives'.

In GitLab by [Gitlab user @tristanvb] on Oct 19, 2017, 10:20
Yep, fixing this right now; it's a very strange thing.
The reason is that we use ChainMap to do a copy-on-write recursive copy of loaded yaml, saving us a lot of time over a real recursive copy.
The problem is that ChainMap only operates on the first mapping in it's "chain", and also fails to preserve the state of something which was explicitly deleted.

In GitLab by [Gitlab user @tristanvb] on Oct 19, 2017, 10:25
closed via commit 6f820111052a85b1051bb7bf3aed5475a0470e21

In GitLab by [Gitlab user @aevri] on Oct 19, 2017, 10:31
Whoosh, such a fast fix! Thanks :)

In GitLab by [Gitlab user @tristanvb] on Oct 19, 2017, 10:47
Happen to be on it's trail for a couple hours :)
Side note: while 'arches' have not yet been removed, dont use them !
They will be disappearing shortly :)

In GitLab by [Gitlab user @tlater] on Oct 19, 2017, 14:04
mentioned in commit 6f820111052a85b1051bb7bf3aed5475a0470e21


2048 Example doesn't link

Apparently a reference to /Users/sahrens/src/fbobjc-hg/Libraries/FBReactKit/js/react-native-github

Thanks for reporting. This was fixed by https://github.com/facebook/react-native/commit/cf617640f3f216a236e3a96d0a5d6146cb3bcf9d.


quiche: patch for macOS build

Similar to https://github.com/envoyproxy/envoy/pull/19360, this unblocks Envoy Mobile macOS builds.

Any update on the upstream fix https://github.com/envoyproxy/envoy/pull/19360#issuecomment-1002247908 @birenroy @RyanTheOptimist ?

I'm happy to make a PR with this patch over at https://github.com/google/quiche as well but I'm not a googler so I don't know if that would be accepted given it won't come from the google-internal version of the repo.

Opened a PR with the patch in case it's helpful: https://github.com/google/quiche/pull/12

Always good to remove patches. Thanks
/lgtm deps

@jpsim, shall I go ahead and merge this?

My pleasure. Can someone with merge access please merge this PR?


How can I train on my own dataset to detect new classes?

I want to use CornerNet-Lite to detect new classes (not involved in COCO classes) on my own dataset, how can I do this? Or you can write it on you Readme file.

youcan see https://github.com/huangzicheng/CornerNet-Lite

I want to use CornerNet-Lite to detect new classes (not involved in COCO classes) on my own dataset, how can I do this? Or you can write it on you Readme file.

youcan see https://github.com/huangzicheng/CornerNet-Lite


Compiler Errors After Upgrade to v<IP_ADDRESS>

Hello Michael,
thanks for your continuous efforts on this project!
As I was curious to try your fixes for my reported issues #54 and #55, I've just updated from v<IP_ADDRESS> to v<IP_ADDRESS>, but looks like this is making things much worse for me unfortunately...
Even following very simple test model generates broken code for me now:
ConfigModel-Test.zip

This was working without problems in v<IP_ADDRESS>.

Not sure where you got the ConfigModel.tt file from, but it wasn't the one added to your project when you added the model. The .efmodel file has some differences that look suspicious as well.
Is this a copy of an old model and .tt that was edited? The model should work fine, but the T4 won't.

Can I reset the .tt file to default while keeping the model in the designer intact?
Yes. Create a new .tt file and change its name. Do a slight edit to change the name of the model file to the one you're using.
 Normally you wouldn't need to do this, but the change you made was only meant to be a temporary change to get you over the problem you were experiencing earlier.

It sounds like there's a mismatch between the entity framework core version you're compiling with and the one you've told the model you're using. Can you check that?

Closing due to lack of activity.


Update README.md - link to your website via https

Your website works fine using HTTPS - why link to it via HTTP? Let's make the web a safer place!

[Cannot approve my own PR - editing master branch directly]


hikey: add Trusted Board Boot feature

If user wants to build firmware with Trusted Board Boot feature,
he only need to enable TBB in build_uefi.sh script file.
And user should also clone mbedtls code in BUILD_PATH.
(http://github.com/ARMmbed/mbedtls)
When TBB is included in ARM Trusted Firmware, it needs more room
on BL1 size. So update the memory layout of BL1 RO region.
Signed-off-by: Teddy Reed<EMAIL_ADDRESS>Signed-off-by: Victor Chong<EMAIL_ADDRESS>Signed-off-by: Haojian Zhuang<EMAIL_ADDRESS>

Looks great!


🎁: Garden column width option

Expected outcome
Apps should be able to provide their own "garden column width"
Business Value / Developer Experience
Today all apps have the same "default" column width. Looks quite ugly in certain cases
Acceptance Criteria
Garden items in different apps, for different contexts, should be visible and look nice :) No clipping, show entire number etc.

@espenkalle Can this be closed? You forgot to link PR


Unable to update the password

Hi Team,
Unable to update password of user after passing oid after passing correct client ID and client secret

@yoelhor @mmacy
The sample is based on Oauth2 client credential flow and it uses graph client to update the user's password using the passwordProfile attribute of a user.
Observations
As per the graph documentation - https://docs.microsoft.com/en-us/graph/api/user-update?view=graph-rest-1.0&tabs=http
A user needs Directory.AccessAsUser.All permission to update the PasswordProfile property and this permission is not available for application-context scenario (client credential flow) hence we are curious to know how exactly the password change will work with this sample.
        var user = new User
        {
            PasswordPolicies = "DisablePasswordExpiration,DisableStrongPassword",
            PasswordProfile = new PasswordProfile
            {
                ForceChangePasswordNextSignIn = false,
                Password = password,
            }
        };

        try
        {
            // Update user by object ID
            await graphClient.Users[userId]
               .Request()
               .UpdateAsync(user);

            Console.WriteLine($"User with object ID '{userId}' successfully updated.");

@RJK23 @Naakhta Have you added the User administrator role to your application as specified in Enable user delete and password update?

Enable user delete and password update
The Read and write directory data permission does NOT include the ability delete users or update user account passwords.
If your application or script needs to delete users or update their passwords, assign the User administrator role to your application:

Sign in to the Azure portal and use the Directory + Subscription filter to switch to your Azure AD B2C tenant.
Search for and select Azure AD B2C.
Under Manage, select Roles and administrators.
Select the User administrator role.
Select Add assignments.
In the Select text box, enter the name of the application you registered earlier, for example, managementapp1. Select your application when it appears in the search results.
Select Add. It might take a few minutes to for the permissions to fully propagate.

@mmacy Thanks a lot its working

@RJK23 Excellent! OK to close this issue, then?

Sure @mmacy


 I don't know why this started happening because before this i would be able to reach finding recipes before it crashed

Load up Terraria
Get to finding mods
Crash with no crash log left behind

Every time i load it up this happens, I have tried deleting and reinstalling Terraria multiple times to no avail.
tModLoader version <IP_ADDRESS> I have also tried <IP_ADDRESS> and <IP_ADDRESS>
Mods:Thorium
MaxStackPlus
Furniture, Food and Fun
Calamity
Project_Logic
Fargo's Mutant Mod
Fargo's Souls Mod
Wing Slot
Shadows of Abaddon (SacredTools) - Closed Beta
Which Mod Is This From?
More Accessories+
Spirit Mod
Elemental Unleash
Boss Checklist
Yet Another Boss Health Bar
Joost Mod
Magic Storage
Chad's Furniture & More
Recipe Browser
Luiafk Mod
Auto Trash
WeaponOut
Vipix' Toolbox
BuilderPlus
Solutions
Friendly NPCs Don't Die
Ultraconyx
Mechtransfer
Builder's Toolbox
Silk Touch
Critter Craze
Better Paint
ModHelpers
Legendaries+
Extensible Inventory
Spectral Aves' Calamity Chiptune Boxes
Invisible Blocks & Platforms
Invisible Dye
Veinminer
World Expansion
Better Night Sky
Music Maker
Prefixes for Enemies
Boss Highlights
The Unchained Terrarian
Enigma
Ammobox+
Split
Antiaris
Thaumaturgy
Pinkymod
Beyond the Forgotten Ages
Gambler NPC
Expeditions
Expeditions Content Pack
Expeditions Addon: Interactions
The Luggage
Peculiarity
More Dialogue
The Bird Mod
Arrival of the Blind Forest
Universal Crafter
Apotheosis and Friends
AFK's Pets and More
Touhou mod
Terraria3D + Terrariahooks (off and on)
Qwerty's Bosses and Items
Mod of Redemption
AlchemistNPC Lite
Chromakey Wall
Gadget Galore
Various Weathers
Imk sushi's mod
Imk sushi's old recipes enabler
the issue might be to do with amount of mods but i cant disable them because i can only enter my mod list once i get past loading all my mods. I also looked at someone else who had the same issue but holding left shift gave me no results

When you go into the logs folder there is no client.log file ?
(Or any other kind of log file, even .txt files?)
There is no error popup?
Then I'll put my standard text: Have you tried verifying integrity of game files (steam) and reinstalling tmodloader? Have you tried removing the enabled.json file from the mods folder and reloading mods following these steps?

Also try the beta on our discord, it gives better logs
On Thu., 4 Apr. 2019, 2:03 am Jofairden<EMAIL_ADDRESS>wrote:

When you go into the logs folder there is no client.log file ?
(Or any other kind of log file, even .txt files?)
There is no error popup?
Then I'll put my standard text: Have you tried verifying integrity of game
files (steam) and reinstalling tmodloader? Have you tried removing the
enabled.json file from the mods folder and reloading mods following these
https://cdn.discordapp.com/attachments/466247288331829249/481464717043564554/Untitled_Diagram1.png
steps?
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/blushiemagic/tModLoader/issues/504#issuecomment-479553418,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAXsiRIqvs7vihh3WRH-AwvntYjx5yuKks5vdNC9gaJpZM4cav6r
.

I used to get a crash log when i crashed on finding recipes but now it crashes on finding mods and verifying integrity doesnt help. Also I just want to make sure i download the right beta, do you mean the newest one or just any of them?

Come ping either jopojelly or I on Discord, we can give you more interactive help there

If you still need an invite link to the discord, this should work: https://tmodloader.net/discord

Sounds like a mod issue to me. Closing because of no follow up.
To anyone having the same problem, following these steps can usually have you figure out the root cause of your load issue. Remember that you can hold LSHIFT during boot to skip loading mods.


Update configure-relevance-search-organization.md

Added some relevance search deployment notes

@ericregnier
Taking to live via my working branch.


pngtoy.js:8 Uncaught (in promise) TypeError: Cannot read property 'byteLength' of undefined

I get the error when opening this image http://i.imgur.com/95TIbv9.png using the following code:
var png = new PngToy();

png.fetch("http://i.imgur.com/95TIbv9.png").then(
  function() {png.decode().then(show)}
);

function show(bmp) {
  var data = bmp.bitmap;
  console.log(data);
}

Thanks for the report @clowerweb. There is a tEXt chunk before the IEND chunk in the PNG file itself which seem to throw of the parser. The assumption is that no chunks are allowed between the IDAT and IEND chunks except other IDAT chunks, but it seem to be a false assumption as tEXt chunks seem to have no particular order restriction.
As a workaround you can disable strict checking by using the allowInvalid option:
var png = new PngToy({ allowInvalid: true });

In the mean time I will go through the code to reduce the strictness when it comes to textual chunks. I will triple-check the specs and if all OK an update can be expected during the next few days.

There was a tEXt chunk between IDAT and IEND in the PNG file, which is allowed, but threw the parser off. Fixed it to ignore other chunks when compiling IDAT chunks.

Excellent, great work and thank you!

No problem, and thanks for reporting!

It works perfectly now! I needed it because I'm building an online IDE tool for PICO-8, which stores game ROMs inside PNG "cartridges", and I was using canvas with context.getImageData, which multiplies the R, G, and B by the alpha, so program code was not decoding properly around the transparent corners of the images. I tried a host of unsuccessful attempts to resolve this for weeks, including using PHP to decode the PNGs on the server, but PHP returns the alpha as a 7-bit (0-127) value, which can't be accurately converted to an 8-bit value. Lastly, I tried placing the image into a WebGL texture buffer and decoding from there, but wasn't able to get that working successfully for my purposes either.
When I was getting the error with this script and having a difficult time finding a similar one that would work, I was going to resort to the most hacky solution ever: reading the image data from canvas, building an array of pixels with 0 alpha, AJAXing the x,y coords over to PHP, then having it build and return a JSON string of RGB values for those pixels (alpha not needed since we'd know they are 0 already). Having this working has saved me a lot of time and effort, so thanks VERY much!


Codespace stuck in sign in loop for extension

When I open the code space with the latest update to dotnet 8 and python version, it asks me to sign in to activate plugin.
When I do it cycles between two variants of the popup. Pressing cancel does not help, the modal keeps coming back.

This is the web version of VS Code. haven't tried the desktop client.

If someone sees this in the future. My mistake was that I made a Codespace in this microsoft owned repo and not in my own fork. Fork and work in your own repo and everything works as intended.


ConnectX4-LX vendor id added

In order for sr-iov to work with ConnectX4-LX on Fuel, I added the vendor id to the supported pci vendor devices

Thank you for contributing to openstack/fuel-plugin-mellanox!
openstack/fuel-plugin-mellanox uses Gerrit for code review.
If you have never contributed to OpenStack before make sure you have read the
getting started documentation:
http://docs.openstack.org/infra/manual/developers.html#getting-started
Otherwise please visit
http://docs.openstack.org/infra/manual/developers.html#development-workflow
and follow the instructions there to upload your change to Gerrit.


Verify Quebec official testing dataset

All official QC testing numbers have recently been added as an experimental dataset (22a3fc30feeded1a27457853f02f9acea8245d7): https://github.com/ccodwg/Covid19Canada/blob/master/official_datasets/qc/qc_testing_datasets_prov.csv
These reflect reflect the data underlying figures 4.1, 4.2, 4.3 on the INSPQ data page: https://www.inspq.qc.ca/covid-19/donnees
However, it is odd that 4.1 and 4.2 end on different dates (t -1 and t-2, respectively), despite apparently reporting the same metric. This should be investigated and variable names tweaked if necessary. The methodology page could help, especially the sources section: https://www.inspq.qc.ca/covid-19/donnees/methodologie#sources
This is part of the larger initiative of making official datasets available and compatible (#53).

Thanks for adding this QC data in! It is definitely odd that the latest reporting date in figure 4.1 is more recent (by a day) than figure 4.2 on the INSPQ page. At least the # of confirmed cases on a particular day in 4.1 matches the # of confirmed cases for that same day in 4.2.
I think you need to rename your columns representing figure 4.2:
"unique_people_tested" should be "admissible_tests"
"unique_people_tested_positive" should be "admissible_tests_positive"
"unique_people_tested_negative" should be "admissible_tests_negative"
"unique_people_tested_positivity_percent" should be "admissible_tests_positivity_percent"
I believe "unique people tested" daily is the day-over-day difference in the "cumulative_unique_people_tested" column, which for some reason that totally confounds me, is DRASTICALLY lower than the number of admissible tests or samples analyzed on the same day.
Unfortunately, their testing data is not reported on the most recent day they report confirmed cases, so my charts will only show the daily new cases for the current reporting day (today -1), while testing data will only be displayed for the previous day (today -2) and earlier.
They calculate and publish their % positivity based on confirmed cases as a fraction of "admissible tests". Personally, I think it should be calculated based on "samples analyzed", but I'm no expert and I guess they have their rationale for that detailed out in their Methodology page.


Update AutoRest C# version to 3.0.0-beta.20230828.1

Update AutoRest C# version to 3.0.0-beta.20230828.1
This completes the work started in https://github.com/Azure/azure-sdk-for-net/pull/38286.

API change check
API changes are not detected in this pull request.


GitHub Issue #4886

Adds "Environment" (--env) to stats output.

What kind of change does this PR introduce?
feature
Did you add tests for your changes?
Added an --env option stats test.
If relevant, link to documentation update:
N/A
Summary
Implements #4886
Does this PR introduce a breaking change?
N/A
Other information

@sokra – I've added, and updated a few test to better cover the  various --env argument stats.env permutations.
In doing so it also seemed reasonable to alter how the actual --env argument was being passed to lib/Stats. Rather than adding the value to the compilations (like hash), I'm now assigning it to the Stats instance directly, similar to the timings implementation. This change allows the stats.env option fallback to be true which seems to better align with the desired use case.
If this approach is approved I'll be sure to open a corresponding PR to the documentation for stats.env.

@jbottigliero let me know if I can help you ;)

I've updated the base branch to webpack-2 as this is what the original change-set was developed against. However, the changes in this PR are a bit problematic. The change in bin/webpack.js was setting the outputOptions.env using the --env arguments directly. That means the lib/Stats.js component would output the Environment section even when you explicitly set stats: { env: false } but passed a truth-y env argument.  I don't think this is expected, or intended behavior.
I've cleaned up the implementation in a new branch. Here is that diff: https://github.com/webpack/webpack/compare/webpack-2...jbottigliero:issue-4886-2.4.1
Now, although the issue is tagged as webpack-2, I've taken a look at the latest master (currently 3.6.0) and it looks like a similar solution would be viable (looks like the argv.env handling was just abstracted a bit, so it's not a clean-merge). ...but, I'm not exactly sure how the webpack team would like me to propose those changes (assuming this is desired for 3+). Get this merged and cherry-pick it on to the latest as a new PR? Create an entirely new branch and set of commits?


Unable to change GPS_TYPE from 3D Fix to RTK Float

So i have my pi5 running as a base station so to inject rtk data i am using this python code,
import serial
import json
import requests
import time

serial_port = '/dev/ttyAMA0'  # Specify your serial port
baud_rate = 9600  # Specify the baud rate
mavlink_api_url = 'http://<IP_ADDRESS>:8088/v1/mavlink'  # MAVLink2REST API URL
headers = {"Content-Type": "application/json"}

ser = serial.Serial(serial_port, baudrate=baud_rate)

rtcm_buffer = []  # Buffer to hold reconstructed RTCM data

try:
    while True:
        rtcm_data = ser.read(180)  # Adjust the number of bytes to read as needed

        rtcm_data_list = list(rtcm_data)

        data_length = len(rtcm_data_list)

        payload = {
            "header": {
                "system_id": 255,
                "component_id": 1,
                "sequence": 0
            },
            "message": {
                "type": "GPS_RTCM_DATA",
                "flags": 1,
                "len": data_length,
                "data": rtcm_data_list
            }
        }

        json_payload = json.dumps(payload)

        response = requests.post(
            mavlink_api_url,
            headers=headers,
            data=json_payload
        )

        print(f"Response status code: {response.status_code}")
        print(f"Response text: {response.text}")

        time.sleep(0.1)

except KeyboardInterrupt:
    print("Stopping...")
    ser.close()

i am using neo8m gps it's receiving upto 10 satellites,
i can see the GPS_RTCM_DATA mentioned in the api, but the GPS_TYPE is still 3D Fix only

For arming and disarming i used system id as 255 and component id as 1

Pls help, thx in advance

Sorry, i am new to this i don't know whether it's converting to rtcm or not


Use it with Vue-axios

Hello,
Please can you give me an example of vue-axios and axios!-cache-adapter integration ?!
My current implementation which not works:
const axiosCache = setupCache({   maxAge: 15 * 60 * 1000 }) Vue.use(VueAxios, axios) Vue.axios.defaults.baseURL = 'hhtps://api.net' Vue.axios.defaults.headers.common['Authorization'] = "Token xxxxx" Vue.axios.defaults.adapter = axiosCache.adapter
Merci

Hi @moas !
I've never used Vue but I'll try to look into it 😄
I'll get back to you.
Cheers

Here is how to use it with Vue:
import VueAxios from 'vue-axios'
import axios from 'axios'
import { setupCache } from 'axios-cache-adapter'

const cache = setupCache({
  maxAge: 15 * 60 * 1000
})
Vue.use(VueAxios, axios)
Vue.axios.defaults.adapter = cache.adapter

What 's the difference  between your code and my example paste in first issue message ?

That's a good point, I didn't notice that it's the same.
But it does work for me, I checked again and it's caching.
Is it throwing any errors or it just doesn't work?
Are you then using axios for get requests like this this.axios.get() ?

Thanks @sloba88 for helping out. As said earlier I've never used Vue but it seems to me that overriding the axios default adapter works but is not the best practice.
I would see it more like this:
import VueAxios from 'vue-axios'
import { setup } from 'axios-cache-adapter'

// Use `setup` method which gives an axios instance with cache pre-configured
const axiosInstance = setup({
  cache: {
    maxAge: 15 * 60 * 1000
  }
})

Vue.use(VueAxios, axiosInstance)

This should be equivalent to your example but does not modify the base axios instance.
Anyway, this is not helping as to knowing why it does not work for @moas 😅

Hi
My request code snippet
      let a = Vue.axios.get('/a/')
      let b = Vue.axios.get('b/')
      try {
        Vue.axios.all([a, b]).then(
          Vue.axios.spread((aRet, bRet) => {
          })
        ).catch((e) => {
          console.log(e)
        })
      } catch (error) {
        console.log(error)
      }

Error logged in console:
TypeError: vue__WEBPACK_IMPORTED_MODULE_1__.default.axios.all is not a function
    at Store.initApp (index.js?99cf:51)
    at Array.wrappedActionHandler (vuex.esm.js?2f62:721)
    at Store.dispatch (vuex.esm.js?2f62:428)
    at Store.boundDispatch [as dispatch] (vuex.esm.js?2f62:322)
    at VueComponent.mounted (initApp.vue?9cab:42)
    at invokeWithErrorHandling (vue.runtime.esm.js?2b0e:1854)
    at callHook (vue.runtime.esm.js?2b0e:4194)
    at Object.insert (vue.runtime.esm.js?2b0e:3132)
    at invokeInsertHook (vue.runtime.esm.js?2b0e:6311)
    at Vue.patch [as __patch__] (vue.runtime.esm.js?2b0e:6530)

Hey @moas I think I understand why your request snippet does not work.
The axios.all() method only exists on the core axios object.
See this REPL test I did
~/www/axios-cache-adapter
❯ node
> const axios = require('axios')
undefined
> axios.all
[Function: all]
> const api = axios.create()
undefined
> api.all
undefined

So if you use the axios-cache-adapter setup() method like I suggested (which uses axios.create()) you won't have access to the axios.all() method.
If that is the only issue you have then you should consider using Promise.all() instead like:
Promise.all([
  Vue.axios.get('/a'),
  Vue.axios.get('/b')
]).then(([responseA, responseB]) => {
  // Do something with responses
})

You don't need axios.spread() just destructure the array like I did in the example above.
If you do have other issues can you please detail them a bit more?
Cheers 😄

Closing this. Feel free to re-open if needed.


support for Double

It would be great to have support for Double values instead of just Integer values as the backing type for the number picker.
Thanks for your work, very nicely done and useful library. The platform pickers are very behind, this is a breath of fresh air. 👍

Ya, I need to have step size 0.5 and I cannot use this lib I guess :(


settings

Is your feature request related to a problem? Please describe.
Make more setting features available
Describe the solution you'd like
settings like Bluetooth and personalization and system thanks
Describe alternatives you've considered
A clear and concise description of any alternative solutions or features you've considered.
Additional context
Add any other context or screenshots about the feature request here.

Duplicate of #374

please don't create duplicate issues

oh sorry I didn't know there was already one my bad

You created it (#374) how could you not know


create a professional-experience page

create a page called
professional-experience.html under src/cea-experience/
with headers and footers from
src/contact.html
and include that in webpack.js accordingly.
Make sure you change the title in html page to Professional Experience | CEA

@cneryx Are you gonna do as you said?

ya sorry im having some trouble with github.

@cneryx Yeah make a pull request.

Fixed #141


Custom character bug

When I compile a test build with my custom character and go into a song and try to make dad my character it crashes saying "ERROR there is no TEXT asset with an ID of 'shared:assets/shared/images/characters/charOffsets.txt'", but there is, and I have no idea why it isn't registering.

'assets/shared/images/characters/character nameOffsets.txt'

Turns out I just misspelt something in the .xml


⚠ GitLab Server has degraded performance

In c8a2886, GitLab Server (https://gitlab01.its-telekom.eu) experienced degraded performance:

HTTP code: 200
Response time: 11517 ms

Resolved: GitLab Server performance has improved in cb40429.


Enable merge group checks for our workflows.

About the PR
Merge queue requires some tweaks.

what better way to test the change than by merge queuing it.


Clear store upon new finalized check point

Do you guys see a value in spec to clear dicts blocks, block_states, and checkpoint_states when there's a new finalized check point?
Not sure if it is an implementation detail that got left out, I do see value of clearing those caches/dbs when we write out fork choice yaml tests

clearing those caches/dbs when we write out fork choice yaml tests

Labelling as "CI/tests". I'm guessing @protolambda may be best informed :)

Well, there are certain extremely reare edge-cases where you can argue about going farther back than that. (wrong eth1 head being tracked, and future super-rare phase 1+ things). So I am hesitant in declaring a hard fork-choice requirement that ignores these cases. I think @djrtwo may have a stronger opinion on whether or not to just trust the finalized checkpoint and never looking back. Maybe it can be translated into code otherwise, and then we can have the pruning on finalization.

@terencechain Can you clarify what the question is about? Are you suggesting that we clear the store so that tests run faster (i.e. a cosmetic issue), or is this a more substantive issue such as the one Proto is talking about?

The one is proto is talking about. Some recommendations on when we think it's "safe" to clear out storages. Right now we clear everything upon a new finalized epoch

There's a bit of guidance in the fork choice document:

The large ETH1_FOLLOW_DISTANCE specified in the honest validator document should ensure that state.latest_eth1_data of the canonical Ethereum 2.0 chain remains consistent with the canonical Ethereum 1.0 chain. If not, emergency manual intervention will be required.

My suggestion would be to clear data (blocks, attestations, etc.) that is a certain age (e.g. 3 days) relative to the latest finalised checkpoint. We don't expect the latest finalised checkpoint to get reverted but keeping a bit of data around for emergency manual intervention may be worthwhile.

The expectation of clients to start is to serve beacon blocks within the weak subjectivity period (~8M in the normal case) to allow for offline clients to sync to the head. Actively clearing out the store in your active fork choice alg after finality is certainly advisable, but pruning your blocks/state should be done in a much more conservative manner

great, thanks for the guidance on this one. I think we can close it for now : )


Show thumbnails at the bottom of the preview mode

Hi! Thank you for this awesome library!
One thing would make it really perfect which is the ability to show the thumbnails also in the preview mode.
Can you consider supporting this feature or can someone please guide me how to achieve that?
Something like this:

@yanivps unfortunately this is not possible right now, maybe I will add it but for sure not soon, I'm closing it because there already is a ticket with that https://github.com/lukasz-galka/ngx-gallery/issues/43


Are there any additional options/attributes required in order to get the equalize filter to work?

Discussed in https://github.com/aws-solutions/serverless-image-handler/discussions/359

Originally posted by T4VincentF April  5, 2022
Hi,
I'm testing out some of the thumbor filters in v6 of the serverless image handler at the moment and it appears that equalize isn't working for me.
I used the original image referenced in the equalize filter docs here but the image appears to remain the same when /filters:equalize() is added to the URL. - see image url below
https://d1lptcrn2ongl3.cloudfront.net/filters:equalize()/vf-rdqa-4888/pxl-filters-channel/t4_preview/test-case-id---c381418/t4_749877E84C78E413933E023629F2178142B968129B11A6622AC113988DEB47D2-9245.jpg
I'm wondering if this filter requires some additional parameters in order to work or if this is a bug?
Cheers!
Edit: Included version of serverless image handler

After more investigation into this, it is not a bug. The Serverless Image Handler includes a thumbor style interface in the api but maps those to comparable sharp library calls. For the thumbor equalize filter that is the sharp normalize function.
It may not produce exactly the same result but is the closest match in sharp.
We added a story to our backlog to update the documentation to clarify how this works.


StreamBridge send to bindingName & binderName ignores binding property's content type

Describe the issue
When using StreamBridge's send(String bindingName, @Nullable String binderName, Object data) API, it ignores the binding's configured content type and instead forces application/json.
https://github.com/spring-cloud/spring-cloud-stream/blob/0c256343c7b063d9ef44b7b96df95a0f8b1f357c/core/spring-cloud-stream/src/main/java/org/springframework/cloud/stream/function/StreamBridge.java#L150
To Reproduce

Configure binding to use something other than application/json content type
Call StreamBridge's send(String bindingName, @Nullable String binderName, Object data) API

Version of the framework
Latest 4.0.4
Expected behavior
If content type is not provided in the API, then it should first try to use the binding's configured content type (if binding exists and content type is configured). If binding does not exist or content type is not configured, then it should default to application/json. This is the behavior seen in the other send API which does not have content type as a parameter: https://github.com/spring-cloud/spring-cloud-stream/blob/0c256343c7b063d9ef44b7b96df95a0f8b1f357c/core/spring-cloud-stream/src/main/java/org/springframework/cloud/stream/function/StreamBridge.java#L138-L142
Screenshots
None
Additional context
None

I'm willing to raise a PR if we agree on the expected behavior!

@sobychacko @olegz Thoughts?

@KevinLiLu We will get back to you soon on this. Thanks!

@KevinLiLu This was a bug, and thanks for pointing it out. The fix was straightforward and already merged upstream. Please take it for a spin and see if it works for your use case.

@KevinLiLu My sincere apologies. I saw that earlier, but while investigating the issue, I realized that the fix is so simple that I decided to issue a PR directly from my triaging. We highly encourage you to contribute PRs if you see issues like these. Just ping on the issue and let us know that you are working on it so that we are aware of it. Sorry again for the miscommunication on this matter. Your willingness to help is greatly appreciated and looking forward to your contributions.


Ok.

@SolarisFox, while reducing the number of merge commits is a good idea, squashing clearly separate changes like these into one commit is generally undesirable.


[BUG] The JSON endpoint for tweets containing GIFs returns a HTTP 500 error

Describe the bug
Tweets containing GIFs cause the JSON endpoint to return an internal server error (HTTP 500).
To Reproduce

Find a tweet containing a GIF (for example, https://twitter.com/The_PinkPirate/status/1537915696822177793)
Change the host to Twxtter, and add .json to the end so it hits the JSON endpoint (https://twxtter.com/The_PinkPirate/status/1537915696822177793.json)

Expected behavior
A JSON payload to be returned containing the tweet information.
Additional notes
Given as GIF tweets embed correctly within Discord, my initial guess would be that this is purely an issue with the JSON endpoint. Additionally, other forms of tweets, like image posts, work as expected.

Tracked down the issue, "UnboundLocalError: local variable 'url' referenced before assignment" around line 614, when I have a moment I'll see what I can do, unless someone else gets to it first

Fixed


Restrict download menu item to relevant screens

All the various menu items were being defined in BaseFragmentActivity, and set invisible by default unless needed by some particular child. This pull request unbundles the menus to their appropriate activities, and in the process restricts the download progress wheel menu item to it's appropriate scope. BaseTabActivity has been deleted because it caused inconvenience for the new inheritance scheme, and because it was an unneeded abstraction layer that didn't provide much benefit. The test suite hierarchy has been updated to reflect these changes. The base classes are also defined as abstract now.
Previously, the offline menu item display handling was left to each subclass implementation of BaseFragmentActivity. This repetitive logic has now been moved inside the base class. It also fixes an issue with the state not being updated on Activity resumption, by having NetworkConnectivityReceiver post sticky events. Also, the unsafe global static flag for indicating offline state is now removed, and references are replaced with queries to the NetworkUtil#isConnected() utility method.  The test suites are also updated to reflect this.
https://openedx.atlassian.net/browse/MA-1665

@miankhalid, @bguertin, please review

some nits otherwise LGTM :+1:

LGTM. Happy to see code being removed from those monolithic base activities.

Whoops, I just realized those nit-picks weren't fixed. I'm not really worried about white-space and variable names but feel free to clean it up.

Most of the formatting nitpicks here were intentionally left alone, because I resolved to not make any additional changes when replacing the AppConstants.offline_flag usages, as there were so many of them. It would have taken too long to actually format them manually, and if I used auto-formatting then the diff would have been humongous.

I just realized that this comment is no longer valid in the commit message in fc5532d3ca7d6147eecbf220d56f13ad4efd2522:

BaseTabActivity has been deleted because it caused inconvenience for the new inheritance scheme, and because it was an unneeded abstraction layer that didn't provide much benefit.

... as I reverted this part because Mubashar told me that the download progress menu item was not to be displayed in the main screen. I have removed it from the pull request summary.


No recent linux builds

It looks like the Linux builds failed in the last PR to master. Can someone retrigger them?

Builds are running, thanks!

Linux package are available now.


Add support for omitting session token in canonical requests

Motivation and Context
Some services require the session token to be omitted from the canonical request when calculating the signature. For additional context, see https://github.com/awslabs/aws-sdk-rust/issues/477
Description
This PR extends the signing settings with omit_session_token such that the security token only gets added after a signature has been calculated as is required by some services: https://docs.aws.amazon.com/general/latest/gr/create-signed-request.html#add-signature-to-request
The security token is now added after the signature is calculated, if the new setting states so.
Testing
Two new tests have been added to cover:

SessionTokenMode::Exclude is synonomous to a session token that is None
If a session token is provided and SessionTokenMode::Exclude is set, the token is excluded in the signing process, but kept as a header in the mutated request
SessionTokenMode::Include is the default and is the behavior as it was prior to this PR.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

this is great! have you had a chance to make sure that these requests are actually accepted by the upstream services?

this is great! have you had a chance to make sure that these requests are actually accepted by the upstream services?

I sure have :) I tested it against IoT Core (code from the linked issue by Mathias) in order to subscribe to an IoT topic using temporary credentials. That was with query params - not sure about services using just headers, but seeing that they are passed into the function that builds the params, I presume it works for them as well.

LGTM! Looks like there's one clippy lint that needs to be fixed prior to merge

@rcoh - just noticed it needed a rustfmt run as well. Feel free to cancel the previous workflow.

sorry one last thing! will you add a changelog entry? That will also ensure you get credit in the release notes :-)

sorry one last thing! will you add a changelog entry? That will also ensure you get credit in the release notes :-)

Done :)


Incompatibles withsii Mirage (?)

Ah havvi friend whos tries to havva Mirage (https://thunderstore.io/c/lethal-company/p/qwbarch/Mirage/) anda LobbyControl and theyya saids it doesnts work when hostin-
Ah dont haves any logs or anythin- since we justs figured thissa out-

i've worked with the mirage dev for a while to make sure my mods are compatible with his, and i can assure you that there is no problem woth just LobbyContol and Mirage
on the other hand the load command is not guaranteed to work as intended in more havely modded lobbies as many mods use different injection points to detect a fresh save and i'm not able to support all of them.
save command instead cannot have issues as all it does is litterally trigger the vanilla save code


New operators NotZero, Empty & NotEmpty

Pull Request Test Coverage Report for Build 57

122 of 122 (100.0%)  changed or added relevant lines in 4 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage increased (+0.04%) to 98.956%

Totals

Change from base Build 55:
0.04%

Covered Lines:
3319

Relevant Lines:
3354

💛  - Coveralls


For a cluster member, rke template id/revision id is displayed instead of the name

Version: master-head
Steps:

Create a RKE template/revision T1/R1
Create users, user1, user2
Create a cluster using T1/R1 and add user1 as a member to the cluster
Login as user1 who is a member
In the cluster dashboard page, the rke template/revision ids ( RKE Template: ct-cmj5g/ctr-4ttzn ) are displayed instead of T1/R1

This is expected behavior. I had a conversation with @westlywright about what we do when the user doesn't have access to the cluster template and he told me that we typically display the id.
@westlywright would you mind confirming/denying my understanding of the conversation?

Based on the way the issue is worded I agree with what @codyrancher said. Currently just because the user is a member of the cluster doesn't give them access to the cluster template afaik.

I agree that for a cluster member does not have access to the template.
Displaying the ID can have security concerns. We can possible not show a template for this case or just say RKE template in use.

@soumyalj I don't understand why this would be a security concern? If simply having access to the id's is cause for concern we have a bigger issue. Obfuscating it from the UI doesn't solve that problem, the data is still sent over the wire and someone who wants the id can get it fairly easily. This is also a pattern we use when you repeat this exact scenario but remove rke templates and replace them with a node template. A member of the cluster can not see the node templates they do not have access to; If a cluster member edits the cluster they would see the node template id in the selector drop down because they don't have access to view that template.


ENH: Allow leveraged etf as param to security list

To enable reading the leveraged etf data before creation of an algorithm
instance, add a parameter to SecurityListSet which passes in the
leveraged_etf_data.
(SecurityListSet in its current design requires to be created post
algorithm init since the current_date_func is the get_datetime
method of an algorithm instance.)

Coverage decreased (-0.003%) to 81.503% when pulling f3fc1390f5bf631dd49a8ece1d9a731f042be34d on security-list-data-as-param into b0d688a454d623ce1fd1149d679b9cd4c8db308b on master.

@ehebert Noticed this PR hasn't been touched in a while - what do we want to do with it?

Let's close it for now. The end goal of this work was to allow changing the ordering of how various resources are setup internally, but that ended up not being required for using fixtures throughout the internal codebase.


[Feature Request] Some examples that use the different fromFactory API's please ?

Sorry for the late reply.
thank you.
I will try to prepare sample code soon.

Hi @Smurf-IV .
Thank you for waiting.
fromFactory method has 2 overload functions .
auto fromFactory(const Factory<T>& factory) const;
auto fromFactory(const std::function<std::shared_ptr<T>()>& factory) const;

also, Factory<T> is an type alias for  std::function<std::shared_ptr<T>(Container*)>.
now, there is not difference in the behavior of these overloads.
if you want to use a Container* argument, you can use the former method.
but if not, you can use the latter.

by the way,
If you omit the to() method when binding, toSelf() is used.
auto factory = []()->std::shared_ptr<IFoo> {
    return std::make_shared<Foo>();
};
c->bind<IFoo>()
    // Use .toSelf() => .to<IFoo>()
    .fromFactory(factory)
    .asCached();

SampleCode:
https://github.com/tyanmahou/Emaject/blob/main/Emaject/tests/from_factory.cpp

Great - thanks


Refactor class-components to functional components

Fixes #2579

May be good to remove dependency on autobind-decorator as it is no longer required


Add compatibility with core-js

According to RegExp documentation in ECMAScript 6, the pattern argument is mandatory.
How to reproduce:
$ npm install core-js sugar
$ node
> require('core-js');
> require('sugar');

TypeError: Cannot read property 'flags' of undefined
    at RegExp
(/private/tmp/node_modules/core-js/modules/es6.regexp.js:21:38)
    at Object.<anonymous>
(/private/tmp/node_modules/sugar/release/sugar-full.development.js:35:32)
    at Object.<anonymous>
(/private/tmp/node_modules/sugar/release/sugar-full.development.js:9245:4)
    at Module._compile (module.js:460:26)
    at Object.Module._extensions..js (module.js:478:10)
    at Module.load (module.js:355:32)
    at Function.Module._load (module.js:310:12)
    at Module.require (module.js:365:17)
    at require (module.js:384:17)
    at repl:1:1

After the change of this commit, it works.

@andrewplummer Could you please take a look at this?

@rafaelsales looks like it's core-js bug after this https://github.com/zloirock/core-js/pull/55 PR. I will fix it.

@zloirock Thank you!


actually apply manpage stylesheet

Our man-pages.scss file looks for a .man-page class, but we do not actually generate any html with that class. It's unclear to me if something changed in asciidoc, or perhaps in our rendering code.
At any rate, none of these styles were being applied. Let's look for #documentation #main instead, which seems to match the generated html.
Here are before and after shots of the git-prune page. Before:

After:

It looks like an improvement to me, though since these have been disabled for who knows how long, I'm a little nervous that there may be some corner case where it makes things worse. Probably worth clicking around and eyeballing a few pages on the test deploy.

That's an improvement and it's safe. Let's merge it.

Ah, I was too quick to merge this. Look at the code blocks there:
https://git-scm.com/docs/git-commit#_examples

Thanks for pointing that out. The conservative thing would be to just revert this PR, but I think it's making things better overall, so we can just fix this one problem (and be on the lookout for other ones). I've opened #1365 to deal with it.


plutus-tx: tracing support

Add a trace :: Builtins.String -> () function to the plugin builtins, mapped to the builtin trace.
Add some TH trace functions more like those in Debug.Trace to plutus-tx to help with getting evaluation order right.
Add some evaluation functions to plutus-tx that hide supplying the dynamic builtins (and also, sigh, more unsafePerformIO that I think we need).
Use the evaluation functions in wallet-api and include the log output in validation failure errors. AFAICT there's currently nothing that tests the log events, so we should add such a tests and check that it includes trace output for failed transactions.

Okay, let me see if I can write a trace that has an invalid script.

Working on getting an test working using wallet-api, which has thrown up that I'm not typechecking properly (which I hadn't noticed because I have to turn off typechecking for more-or-less everything that uses this, since it involves lists).

Okay, I've fixed the typechecking (could do with a look from @effectfully, it's a bit awkward because we don't have the definition of trace at typechecking time), and added a test that has a failing script validation with a log, and verifies that it appears in the log events (could do with a look from @j-mueller ).

(I was closer to done than I thought)

"I always fail everything"

Sorry to hear that 😉

Okay, let's get this in.


Fixes for youtube audio support

YouTube streaming via LavaLink was broken back in January of 2024. The Lavalink developers have since come out with a plugin specifically for the new workaround.
This PR adds the plugin to the application.yml to allow for youtube audio to be streamed properly again.

I forgot to mention this in the PR, but lavasrc was updated from 4.0.0 to 4.0.1 to allow the new youtube plugin to work. That is also included in the PR.


Spelling fix in the readme

Just a little spelling fix in the README.
Love this library! Great work @DominicTobias

Thanks 👍


Interpolated String Delimiters

Added context information to CodeLine class to keep track of whether the code line leaves open a string, an interpolated string, and interpolated argument, or a string in an interpolated argument. Throws an error if an interpolated argument contains a nested interpolated string.
Future work for this feature branch will be to create proper error handling for nested interpolated strings, as they will be disallowed moving forward.

A merge in from the main branch has polluted this PR. Please wait to review until it can be resolved.


kriging improvements

[x] check math
[ ] improve figures with new code
[x] add overview of kriging types

A further improvement: in figure 6.2b the sill is 140, according to the text on the same page it is 160. The latter is the usual definition, the value between 20 and 160 in the figure is often denoted as "partial sill" (the sill of the, in this case, linear model component). It would further be nice to not plot a linear-with-sill model in 6.2b ,but for instance a spherical model (as that reaches the sill, in contrast to Gaussian and exponential) because the linear-with-sill model is not positive definite in 2 or more dimensions.

thanks! fixed in 83d79b0


Add a Jupyter widget for interactive BLS

@christinahedges has proto-typed a fabulous Jupyter widget which enables the new AstroPy BLS to be used in an interactive fashion.
We should consider adding this feature to Lightkurve ahead of the upcoming Baltimore workshop, where we will present a BLS+Lightkurve tutorial.  (Also see #398.)

This has been implemented and merged as part of #401. :tada:


[Feature] LastFM

Could you add support for the LastFM platform?
I tried using pyanderson/gather-scrobble, but it doesn't work anymore.

xd


crash because of "unfortunate" spread operator in collection.modify (fix is to replace the spread by array passing)

Large collections crash because of spread operator used in Collection.modify
Replacing the spread operator ... by some array reference would fix this and probably be a good idea anyway, since large spreads always end-up causing crashes for people.
@B4nan I know that you would recommend agains using identity maps for such large collections, but it makes sense on our end :)
Stack trace
    err: {
      "type": "RangeError",
      "message": "Maximum call stack size exceeded",
      "stack":
          RangeError: Maximum call stack size exceeded
              at Collection.modify (/Users/loco/dev/monoloco/node_modules/@mikro-orm/core/entity/Collection.js:286:22)
              at Collection.add (/Users/loco/dev/monoloco/node_modules/@mikro-orm/core/entity/Collection.js:96:14)
              at Collection.hydrate (/Users/loco/dev/monoloco/node_modules/@mikro-orm/core/entity/ArrayCollection.js:77:14)
              at Collection.hydrate (/Users/loco/dev/monoloco/node_modules/@mikro-orm/core/entity/Collection.js:111:15)
              at EntityLoader.initializeOneToMany (/Users/loco/dev/monoloco/node_modules/@mikro-orm/core/entity/EntityLoader.js:175:27)
              at EntityLoader.initializeCollections (/Users/loco/dev/monoloco/node_modules/@mikro-orm/core/entity/EntityLoader.js:161:18)
              at EntityLoader.populateMany (/Users/loco/dev/monoloco/node_modules/@mikro-orm/core/entity/EntityLoader.js:156:14)
              at processTicksAndRejections (node:internal/process/task_queues:96:5)
              at async EntityLoader.populateField (/Users/loco/dev/monoloco/node_modules/@mikro-orm/core/entity/EntityLoader.js:226:25)
              at async EntityLoader.populate (/Users/loco/dev/monoloco/node_modules/@mikro-orm/core/entity/EntityLoader.js:42:13)
    }

Expected behavior
does not crash
Additional context
Add any other context about the problem here.
Versions

Dependency
Version

node
v16.14.2

typescript
Version 4.8.3

mikro-orm
5.4.2

your-driver
Postgres

offending code is here: https://github.com/mikro-orm/mikro-orm/blob/f2957fb14141294cfdffebf6cce6eaa937538cfb/packages/core/src/entity/Collection.ts#L351

What you suggest is a breaking change, we would have to change the signature. Or have multiple signatures. Its not destructing the value, its destructing parameters.

I guess it wont hurt to have multiple signatures, historically there were people misunderstanding it and trying to pass array to the first param, this would solve it too.

@B4nan  yes, I know.
I also noticed it would be a breaking change unless extra signatures are added.
I think having an extra function not-crashing would anyway be a good compromise

@B4nan I tried looking if some Function.apply could solve the problem without changing the API, but no. Function.apply() also cause stack overflow https://stackoverflow.com/a/39719431
let xs = new Array(500000), ys = [], zs;
xs.fill("foo");

ys.push.apply(ys, xs); // 🔴 crash despide no visible `...` spread operator
ys.push(...xs); // 🔴 crash
ys.concat(xs); // 🟢 does not crash

an other argument in favor of adding extra non-spread methods: slightly faster runtime and lower memory usage

I think I will go with a required first parameter that can be array, and spread for the second+ params, as I also didnt like the current signature allowed calls without any arguments.
e.g. remove(item: T | Reference<T> | ((item: T) => boolean), ...items: (T | Reference<T>)[]): void {, that way we have only one signature and we can support both ways easily

@B4nan I can submit a PR when I'm back at home if you want, I have a fix locally, not exactly as you suggested though, but I also did fix a few other spread usage, and made add and remove to also accept Set to fix more spread operators

Feel free to send a PR if you see more room for improvement, but I guess this should do it.


Dark Mode

Please consider adding a dark mode.

Cuppa supports dark mode on both Android and iOS. The app follows your system settings; when dark mode is enabled at the OS level, Cuppa will follow suit and use its dark mode.
Can you clarify the issue? Are you asking to add a preference that forces Cuppa to always use dark more?

Yes, please add a preference that forces Cuppa to always use dark mode.

Yes, please add a preference that forces Cuppa to always use dark mode.

That would be great.

in my opinion, it would be best if Cuppa would, by default follow a system theme setting, and also have manual light/dark force settings. This way, it would automatically be set per user preference of a general system theme.

Especially for older devices with no OS level dark mode setting.


read_econdata(wide=TRUE) doesn't include period

@byrongibby I'm helping @Hendrivanz now. The standard code when exporting on www.econdata.co.za doesn't specify wide=FALSE, but then we don't see the period (date information) when pulling the data. Can you please check that the period data is supplied when wide=TRUE?
We were both using version 2.2.0.

period has been renamed time_period to be more consistent with the description of the data in the data registry.

Please open this issue again, and show where the time_period is in
library(econdatar)

data_raw <- read_econdata(id = "NATL_ACC",
                          wide = TRUE)
str(data_raw)

Please try
library(econdatar)

data_raw <- read_econdata(id = "NATL_ACC",
                                             tidy = TRUE,
                                             wide = TRUE)
str(data_raw)

The wide argument has no meaning without tidy=TRUE.


Consider not committing in the vendor folder

Hi.
I'm trying to start contributing to this project and committing the vendor folder isn't a great way to start things off because they collide most of the time.
That's why the dep Lock file is there. When you start developing, you basically check out the project and go dep ensure. The lock file will make sure that all the right versions of the packages are used.
I can understand the committing vendor seems like a good idea because then you'll have the right code always with you, but makes for a poor developer experience.
Feel free to ignore this if you think otherwise, it's fine. :)

Welcome @Skarlso! Really happy that you decided to contribute. This means a lot to me. 😇
You are right and I'm still unsure if committing the vendor folder was the right decision.
I looked up several other big projects (for example kubernetes and docker) and they all committed the vendor folder. That is the reason why I did it.
I'm not sure if they also have the same problems?

eh /shrug. It depends. That's why I'm saying feel free to ignore it. I guess it doesn't matter that much..
Dep has this to say about it:
https://github.com/golang/dep/blob/master/docs/FAQ.md#should-i-commit-my-vendor-directory

It's up to you:

Pros

It's the only way to get truly reproducible builds, as it guards against upstream renames, deletes and > commit history overwrites.
You don't need an extra dep ensure step to sync vendor/ with Gopkg.lock after most operations, > such as go get, cloning, getting latest, merging, etc.

Cons

Your repo will be bigger, potentially a lot bigger, though prune can help minimize this problem.
PR diffs will include changes for files under vendor/ when Gopkg.lock is modified, however files in >vendor/ are hidden by default on GitHub.

So, it's really up to you. :)
Also, Hi! :)


Proposals file not found

Hi, when I run ./scripts/get_proposals.sh I get an Error 404: Not found. It looks like the link https://people.eecs.berkeley.edu/~rbg/fast-rcnn-data/selective_search_data.tgz
is dead. Is there any other source?

Hi,
I uploaded the file and updated the link. You should be able to download it now.

Thanks, but I still cannot download it. Is the above link working for you?

Sure, did you pull the latest commit? I updated the link in scripts/get_proposals.sh (commit 8a6f1c3). The data should be accessible here: http://www.umiacs.umd.edu/~najibi/data/selective_search_data.tar.gz

Thank you, somehow I still had the old version... Now I pulled the new one and the problem is solved.