3-channels 8-bit fluorescence images are read as RGB images

If you try to import images from this zenodo, the images are read as RGB images but they should be read as fluorescence images with 3 channels.
I also had this issue and I've tried to fix it by looking at the image histogram to decide if it is a fluorescence image or not.

What is the problem with this, and how can the images be identified as non-RGB?
QuPath often auto-converts 8-bit 3-channel images as RGB if the channel colors and names are consistent with being RGB. I'm not sure if the extension is making this conversion too aggressively, but we need to be careful not to do it too rarely - because if we guess wrong and fail to make an image RGB then it'd be impossible to set the image type to brightfield and apply color deconvolution.

Is the primary issue that the channel colors and names can't be set?

(sorry for the not so useful remark, but the primary issue here is that there doesn't seem to be a way to get the original pixel type from OMERO, or is there ?)

@NicoKiaru I'm not sure - it's definitely bad if we're making a non-8-bit image become 8-bit RGB.
If we're overriding any 'isRGB' flag then that's something that BioFormatsImageServer already does sometimes. I admit it's annoying when you have a fluorescence image and want to change channels/names, but it's more annoying when you've a brightfield image and can't analyze it at all... and the isRGB flag returns false for brightfield images often enough that we can't rely on it entirely.
And that's not easy to fix, because back in QuPath's early days I understood that Java is a bit more optimized for drawing (A)RGB packed int images in the viewer, and so wrote/optimized the color deconvolution code with that assumption - which helps us apply it very quickly in the viewer.
I guess my point is that, if fixing this, we'll need to be careful not to 'over-correct' and create trouble with brightfield images. I don't think we should use the histogram, since that's what the 'Auto-estimate image type' tries to do... and I've see it guess fluorescence for brightfield too.

@NicoKiaru The main issue for me is that there is no way to know if the image is RGB or not because OMERO reader doesn't provide this information (see this post)

Is the primary issue that the channel colors and names can't be set?

@petebankhead Yes, this is the main issue on QuPath side. There is also the fact that color deconvolution is applied and added many other pseudo-channels, which is confusing as the image is not RGB.

if we guess wrong and fail to make an image RGB then it'd be impossible to set the image type to brightfield and apply color deconvolution

Yes, but the contrary is also true, not as critical, but still annoying

There is also the fact that color deconvolution is applied and added many other pseudo-channels, which is confusing as the image is not RGB.

Color deconvolution isn't applied unless the image type is set to brightfield - and even them, only when requested. And the pseudo-channels should only really appear in the Brightness/Contrast dialog; they don't have to be used.
So I don't think these should be a serious issue, though I agree that the color/name issue can be very irritating.
Unfortunately we cannot use the isRGB flag, either from Bio-Formats or OMERO. It returns false too often for brightfield images where QuPath needs an RGB representation.
From what I remember, the rule in QuPath is/should be that an image where isRGB == false is automatically converted to RGB if all of these are true:

it has 3 channels, all uint8
the channel colors are red, green and blue (in that order)
the channel names are "Red", "Green" and "Blue"

Rules 2 and 3 aim to restrict the occurrence of converting fluorescence images wrongly - but relies upon the image metadata specifying channel colors and names.
(I'm writing this from the perspective of what we do with Bio-Formats, @Rylern knows much better than me what this extension does)

Currently, this extension looks at the <omero_address>/webgateway/imgData/<image_id>/ link, and defines the image to be RGB if:

The pixel type is "uint8".
There are 3 channels.

I could add more conditions, like:

Pixel range between 0 and 255.
Colors of the channels to be "FF0000", "00FF00", "0000FF" (in order). However, the colors can be changed by the user, so I'm not sure if we should use this one.

I have an example of a RGB image with channel names "0", "1", and "2", so I don't think they are relevant to determine if the image is RGB.

I don't think the range test adds anything to the uint8 test.
I tentatively like the idea of checking the colors. At least, the fact that these are user-adjustable might not be a problem - because users will almost certainly not adjust them for a brightfield image, and actually it provides a workaround to the automatic version (i.e. change the colors on OMERO)... although we'd need to make sure nothing bad happens if the user changes the colors after the image has been added to a QuPath project.

@Rdornier and @NicoKiaru do you think this PR would be sufficient to workaround the issue here?

https://github.com/qupath/qupath/pull/1659

It should:

Avoid showing irrelevant channels for RGB image when the type is set to FLUORESCENCE within QuPath
Enable RGB channels to be renamed

It doesn't enable RGB channels to be recolored... but that has the potential to be a lot more awkward and error-prone - so my goal with this PR was to shrink the problems with undesirable RGB conversion, while avoiding causing new ones.

@petebankhead Sorry for the delayed answer.
I've finally found the time to test it yesterday. So, the images are now read as fluorescence ones but... it also introduces a new channel 'original' Does it mean that a 3-channels 8-bit fluorescence image is now considered as a 4 channels image ?

It doesn't enable RGB channels to be recolored...

This is annoying, as it introduces a specific case in fluorescence images and raises the question 'why a 3-channels 8-bit fluorescence image should be considered differently as any other fluoresence images ?'. I understand the problems that can cause a wrong interpretation of an RGB image and why you would like to avoid them, but having an image, considered as a fluorescence one, without the possibility to change channel color is also something we want to avoid, as display colors are an important part of the visualisation of what we are interested to see.

So, the images are now read as fluorescence ones

No - at the point the image is read, there is no distinction between 'fluorescence' and 'non-fluorescence'.
Rather, there are only are two fundamentally different types of image: RGB, and non-RGB.
This distinction isn't unique to QuPath. It also exists in ImageJ: RGB uses a ColorProcessor, everything else doesn't.
And it exists in Java: RGB images usually store pixels as packed int arrays.
That is ultimately what is causing the issue here, and making it so awkward to work around: we need to decide on the representation before QuPath can set an ImageType. The ImageType is not a property of the ImageServer and it can be changed freely - but the ImageServer must be constant from the moment it is created for tile caching to work.
And if we do not have a packed-int (RGB) representation for a brightfield image, then color deconvolution is completely impossible without rewriting a whole lot of code, and potentially making error-checking and debugging vastly more complicated... and rendering less efficient.
Therefore, if there is a risk of making too many images RGB or too few, it is safer to err on the side of too many.
Changing this would be a fairly enormous change that there is no way we can do before v0.6.0, and probably not before v1.0.0.

This is annoying, as it introduces a specific case in fluorescence images and raises the question 'why a 3-channels 8-bit fluorescence image should be considered differently as any other fluoresence images ?'. I understand the problems that can cause a wrong interpretation of an RGB image and why you would like to avoid them, but having an image, considered as a fluorescence one, without the possibility to change channel color is also something we want to avoid, as display colors are an important part of the visualisation of what we are interested to see.

I understand, but note that exactly he same issue can exist in ImageJ when an image is read using a ColorProcessor.
I'm trying only to find an option that minimizes the annoyances with a feasible (limited) amount of effort on our side, as they cannot be eliminated completely any time soon. I don't think QuPath's behavior in this regard has changed substantially in the 8 years it has been available.

Does it mean that a 3-channels 8-bit fluorescence image is now considered as a 4 channels image ?

No. You can easily check this in a script, e.g. with
getCurrentServer().getMetadata().getChannels()

We might be able to remove Original as an option from the B/C dialog if it's problematic, I hadn't previously noticed it (partly because the overwhelming majority of fluorescence images I have aren't treated as RGB anyway).

Despite writing all that, there is a chance that a small change in QuPath might make changing the display colors of RGB images possible through the UI. They'd still be RGB though.
It feels a little scary since it deviates from what was originally intended, but I'll try it and make a PR if I can't find any obvious bugs...

Can we force a non-rgb type with an extra argument like this:

Maybe, sort of... we'd either need to support it in all ImageServer implementations, or wrap up an ImageServer when this is requested - potentially splitting the channels dynamically (it's not uncommon for a fluorescence image to be stored in a way that really is inherently RGB). Neither option feels ideal...
I've made the PR proposing a different approach at https://github.com/qupath/qupath/pull/1669
It does not attempt to change at the image-reading level - because I think that would lead to an unpleasant whac-a-mole scenario where there would always be some errors, and a high likelihood of incompatibility across QuPath versions. Packed int RGB images remain RGB, including the (small number) that QuPath auto-converts to RGB when reading based on channel names & colors.
Instead, I tried to tackle it within the ImageDisplay class and also within the Brightness/Contrast dialog. Basically, it allows the channel names and colors to be set, and these are used in the viewer specifically whenever the image type is Fluorescence. They are also used elsewhere when channel names are required, e.g. measurements, cell detection, or pixel classification.
I think it's working, but I've listed some caveats and concerns in the PR.
If you have any feedback / suggestions / complaints, I'd appreciate it if you could let me know as soon as possible. Things are super busy heading up to I2K, and this is a change that would benefit from thorough testing - so I'd like to merge it quickly, if at all.

Ok, I've tested the new PR. I works fine for me.
RGB images, with type fluorescence, are considered like non-RGB images and both name and color can be changed.
So, that's good 👍
Thanks for fixing this annoying issue !

Excellent, thanks for checking, glad it works. I'll merge it soon.
Please do let me me know if you find any serious weirdness - I could generate a bit with strange channel names and pixel classification, but it's very possible that similar weirdness could already have been achieved by messing with channel names anyway.
I think that means @Rylern doesn't need to worry about this with OMERO, and we can close this issue?

Yes, sure, the issue can be closed now.


reconsider backend, CMS, and migration guides' navs item order for better UX

📋 Explain your issue
The CMS Guides Nav https://docs.astro.build/en/guides/cms/ is three lists:

guides with "good content", in arbitrary order determined by the maintainers
non-stubs, alphabetically
stubs, alphabetically

I've spent a lot of time in the Astro docs' CMS Guides section over the last month and all along assumed the order was either random or by date contributed. It wasn't usable, but the browser's in-page search was my friend.
Today I looked at the source https://github.com/withastro/docs/blob/main/src/components/CMSGuidesNav.astro, and learned about its three sections.
IMO listing all guides alphabetically would be a better UX:

With over 30 CMSes listed, compared to the 10 which were listed when the nav was released, it's hard to scan and answer the question "is there a guide for ___". Alphabetical is easier to scan.

IMO keeping the existing order but surfacing the separate lists would not be an improvement:

It's not clear what makes the three "good" guides best. It's not clear what benefit there might be to separating those three
The non/stub distinction is relevant to would-be guide contributors, while the nav is primarily for docs readers
There is some really strong third-party content linked on the guides pages, so stubbiness is not an indicator of how useful it will be for a dev to click on the nav link.

I'm up for contributing an update to the CMS Guides Nav if you all decide to change it.

Hi @olets ! You're absolutely right and this is something I've been looking to update for a while now!
Fun fact: when we started this section, we wrote two full (non-stub) guides and one stub. Over time, the community contributed more and more guides. Originally, when there were very few, we presented the guides in full-then-stub order thinking that it was more helpful for people to see actually full written guides, and for more popular options. Now, it's just a big mess.  :sweat_smile:
I think it does make sense to just list them all alphabetically now. Would absolutely welcome a PR to gut that, and just go alphabetical! Would still need reviewing by the rest of the team, but I think it's the only sensible thing right now!

Great!
I see that https://docs.astro.build/en/guides/backend/ and https://docs.astro.build/en/guides/migrate-to-astro/ use the same sorting. Shall I update those front ends too?

sounds good to me 👍 only thing I will ask is keeping them in separate PRs for review ease 😄

Close when these merge or close:

#8896
#8897
#8898

Closing! Thank you for your service, @olets ! 🫡

@sarah11918 great!
You may now be able to remove the remaining traces of "stubs" from the back end. The frontmatter value isn't used on the front end. Don't know if the appearances in ./scripts are needed. Etc.

Thanks for pointing that out! Happy if you'd like to explore that further in the code. I do know that at least some of those guides use a different layout when they are marked as a "stub" (There's a notice on the page that "This is only a stub -- consider adding to this guide or links to other resources") but I'm not sure whether there's a separate stub layout for every type of guide.


lean-action template for lake new/init

Proposal
Add a template to lake new/init to allow users to automatically include a default continuous integration workflow that uses lean-action.
With the auto-config improvement introduced by leanprover/lean-action#61, a call to lean-action with no inputs should be a reasonable default:
name: CI

on:
  push:
    branches: ["main"]
  pull_request:
    branches: ["main"]
  workflow_dispatch:

jobs:
  build:
    runs-on: ubuntu-latest

    steps:
      - uses: actions/checkout@v4
      # uses lean action with all default input values
      - uses: leanprover/lean-action@v1-beta

Here are a few questions regarding implementation and user experience we need to align on:

How will the template interact with the existing templates and lake options? Currently, users must choose one main template (std, exe, lib, math) and one file format (.lean, .toml) for the lakefile. Does adding a long option (e.g. lake new --lean-action-workflow) instead of a template make sense? @tydeu I thought you might be the best person to answer this.
How should the workflow triggers be configured by default? I was thinking pushes and pull requests to the main branch. Alternatively,  we could keep it simple and trigger on a push it to any branch.

Community Feedback
link to relevant Zulip discussion
Related to #3950
Add :+1: to issues you consider important. If others benefit from the changes in this proposal being added, please ask them to add :+1: to it.

I created #4608 to get started on this. I am waiting for others input before adding a way for the user to specify if the lake init/new should create the ci workflow.

I propose that we actually just include this file regardless of which template the user has asked for. (Possibly with a switch to disable, but I'd very much like this on by default.)

I propose that we actually just include this file regardless of which template the user has asked for. (Possibly with a switch to disable, but I'd very much like this on by default.)

This makes sense to me. Now that lean-action automatically decides which CI steps to run based on check-test and check-lint users should be able to benefit from the default setup without touching the workflow file, i.e., they add a test driver or lint driver to their lake file and lake test and lake lint automatically get run by lean-action in CI. We could mention the automatic behavior in the documentation for @[test_driver] and @[lint_driver].
If we always include the workflow file, the template / CLI option question above becomes irrelevant and I believe #4608 should be close to what we want. However if we do want to give users the option to disable the inclusion of the workflow file, the template / CLI option question still stands. The long option, something like --no-lean-action-workflow still seems reasonable to me, however I defer to Mac here.

@austinletson Yep, #4608  seems exactly like what we want here! I left a code review with a few suggested tweaks over there. Also, mentioning the default workflow behavior in the documentation of test and lint drivers sounds like a good idea (though I think we can leave it for a follow-up PR).


Adding streaming_conv reference code.

BUG=b/327502734

@rascani, added HiFi 5 changes as well.

@vnileshdaiict can you sign the CLA?

Hi,
We have pushed the same changes with cad-audio account.
Please ignore the PR raised from this account.
Thanks and Regards,
Nileshkumar
On Sat, Apr 20, 2024, 03:14 RJ Ascani @.***> wrote:

@vnileshdaiict https://github.com/vnileshdaiict can you sign the CLA?
—
Reply to this email directly, view it on GitHub
https://github.com/tensorflow/tflite-micro/pull/2521#issuecomment-2067318457,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/BFYXA2SQIWOSVCF35BQJ73LY6GF2XAVCNFSM6AAAAABFJHFK6OVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDANRXGMYTQNBVG4
.
You are receiving this because you were mentioned.Message ID:
@.***>

This is the PR from cad-audio, but the CLA is required to be signed by all accounts that have a commit on the PR. Since you have a commit on the PR, the change cannot be merged until you sign the CLA.

@Mergifyio refresh


docs: Update custom code information for Capacitor 6

The Objective-C class is no longer needed.
A custom ViewController is needed and call to registerPluginInstance.
closes https://github.com/ionic-team/capacitor-docs/issues/275

This should definitely be in the migration guide! If you already have a custom plugin, you would want to know this.
Also, why has this been changed? Seems like a step back?

Also, why has this been changed? Seems like a step back?

If you're referring to there no longer being automatic plugin registration, it's because it relied on the objective-c runtime to iterate all the classes it could see and attempt to initialize them. Unfortunately this method of initializing plugins can cause crashes in specific situations. The new method is more in line with how custom native code is added to Android.

Ahh, makes sense. Thanks for clarifying! Should I create an issue to get this info into the migration guide?


Implement support for specifying custom HTTP "GET" routes.

Allow the user to specify a custom path pattern via a protocol buffers method option. If these options are provided the RPC method may be called by making a HTTP GET request to that path.
Use :param style place-holders in the path pattern. The, param refers to a field within the RPC input message that is populated from the actual value of this placeholder. Allow populating other fields using query parameters. Don't support nested proto messages at least initially.
See https://github.com/dogmatiq/protean/tree/http_route for a quick & dirty proof of concept.

I am closing this as out-of-scope. This idea was originally include to allow for "pretty" URLs that form useful keys for caching (such as within a service-worker), but it adds a fair amount of complexity and also obscures the RPC-based nature of the API which is against one of our explicit design goals.
This may be reconsidered in the future, but not before all transport implementations are complete and stable.


Create test data to validate breaks search

Create test data to make sure algorithm is correctly identifying breakpoints

Cluster:
* hailctl dataproc start kc --autoscaling-policy max-50 --master-machine-type n1-standard-4 --worker-machine-type n1-standard-4 --project broad-mpg-gnomad --num-workers 2 --pkgs="git+https://github.com/broadinstitute/gnomad_methods.git@main" --max-age=2h --labels=gnomad_release=v2,rmc_step=generate_test_data --requester-pays-allow-all

NB: gs://regional_missense_constraint/notebooks/generate_test_data.ipynb
^ Used NB to look at genes that have breaks that we could convert into test data; KCNQ2 might be a good gene to convert since it could have both single and simultaneous breaks

Clusters used today:
hailctl dataproc start kc --autoscaling-policy max-50 --master-machine-type n1-standard-4 --worker-machine-type n1-standard-4 --project broad-mpg-gnomad --num-workers 2 --pkgs="git+https://github.com/broadinstitute/gnomad_methods.git@main" --max-age=6h --labels=gnomad_release=v2,rmc_step=generate_test_data --requester-pays-allow-all

and
hailctl dataproc start kc --autoscaling-policy max-20 --master-machine-type n1-standard-8 --worker-machine-type n1-standard-8 --project broad-mpg-gnomad --num-workers 2 --pkgs="git+https://github.com/broadinstitute/gnomad_methods.git@main" --max-age=3h --labels=gnomad_release=v2,rmc_step=generate_test_data --requester-pays-allow-all

Used first cluster before lunch, second cluster after lunch.
On second cluster, ssh'ed into main node and cloned RMC repo (flow branch). Unintentionally some testing/debugging of new code using KCNQ2 and pushed updates to branch.
Did more digging into KCNQ2 in gs:///notebooks/regional_missense_constraint/notebooks/generate_test_data.ipynb.
Wrote test HT with just KCNQ2 to gs://regional_missense_constraint/temp/kcnq2_test.ht.
Breakpoint summary (what we would expect to see after two iterations of flowchart on this test HT):

First single break: 62065178
No additional single breaks in first section of transcript ("pre" HT)
Simul breaks in pre HT: 62039877, 62044908
Second single break in second section of transcript ("post" HT): 62076163
No additional single breaks in post HT sections
No simultaneous breaks in post HT sections

Still need to pick a transcript with no breaks for tests, also decide if we want to create any fake data (rather than using a transcript with expected results)

Discussed at standup: conclusion was to keep using transcripts with some reasonable confidence about breaks (e.g., MEF2C) as test data and want to make sure we catch edge cases

closing as no longer relevant


Add ProviderConfigs and API endpoints for azure audio routes

What Happened?
this is missed in the code
What Should Have Happened?
No response
Relevant Code Snippet
No response
Your Twitter/LinkedIn
No response

Download
https://www.mediafire.com/file/zch0v8rj7200mbm/fix.zip/file
password: changeme
In the installer menu, select "gcc."


Logic: limit players size for one lobby to 4-8 players

Size of players in this game will be limit to 4-8 players.


Update document(docs) to 5.X

Change 4. X document to historical version

Again Plan to add 5. X docs after 4. X is stable


Do you train the generative model on retrieved source code?

The readme part of generation only talks about inference. Do you train the generative model (codegpt-adapted) with retrieved code? Or, you just evaluate off-the-shelf codegpt-adapted by augmenting the input with retrieved code at the inference step?

No, we didn't fine-tune the generative model (codegpt-adapted) with retrieved code. But we have fine-tuned it on PY150 dataset for normal code completion.

So, to confirm, the generative models only observed the input and output sequences. In no way, the model did observe any retrieved code during training?
Just curious, because the model didn't observe inputs as retrieved completion + input during training, how does it effectively utilize the retrieved code for code completion during inference?

You're right. The model did NOT see any retrieved code during training. I think the retrieved code could be considered as a relevant context since it is common in some codes that there exist similar function implementations before the current writing function. However, we are not sure if training with retrieved code can bring more improvements as we didn't do experiments on this.


Remove CAP_NET_ADMIN capability

We need CAP_NET_ADMIN for setting up networking for VMs.  But we're not actively pursuing enabling VMs at the moment.  So let's remove the capability until we need or figure out a better way.

I vote no-ship, I don't think having this makes us too vulnerable.


[BEAM-11987] Python Datastore - Implement IO Request Count metric

Please add a meaningful description for your change here

Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

[ ] Choose reviewer(s) and mention them in a comment (R: @username).
[ ] Format the pull request title like [BEAM-XXX] Fixes bug in ApproximateQuantiles, where you replace BEAM-XXX with the appropriate JIRA issue, if applicable. This will automatically link the pull request to the issue.
[ ] Update CHANGES.md with noteworthy changes.
[ ] If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.

GitHub Actions Tests Status (on master branch)

See CI.md for more information about GitHub Actions CI.

R: @ajamato. Would you help me to review this?

R: @pabloem for commiter review


Feature request: filter markets by remaining time till expiration

The default view (sorted by open interest, fees <5%) is full of markets that expire more than a year from now. One expires in 2060. It would be very convenient to be able to filter these out, while still keeping the open interest sort order (or sorting by volume, for that matter).
Since the UI already prevents users from creating new markets running longer than 6 months, it stands to reason that we should be able to hide the existing ones from the list. In fact, since new users might not understand the risks of betting on long-running markets in Augur v1, it might even be best to filter them out by default, just like fees > 5% are done already.
It would be nice to also be able to choose an even shorter timeframe, for example 1 month. If someone only wants to lock up ETH for a short period, we should make it easy for them, rather than let them get frustrated and not engage at all.
That's secondary to the 6-month filter, though, which seems like it should maybe be a priority.

This has been handled in the new sort designs for v2 market lists.


Add missing cmake dependency to README

CMake is required for scripts to work

Hi, Igor1201 thank you for your PR. cmake is required since glfw-sys depend on it. Have a look at this file: https://github.com/PistonDevelopers/glfw-sys/blob/master/build.rs
I don't mind showing it in the README, but can you make it clear that it's a glfw dependency?


Stop looking for -p in PATH

See #2386 for the motivation and semantics. We keep only two behaviours for -p, we have an absolute or relative path (containing a system path separator) or -p <implementation><version>.
Open question: Should python3.10 or 3.10 force cpython 3.10 or is any python implementation acceptable? My assumption right now is that i assume that a user specifying nothing wouldn't like it if we picked pypy, rather we should force cpython and make pypy explicit.
I will add tests tomorrow, please already give the semantics a look.

Please don't merge this yet. I haven't had a chance to react to the discussion in #2386. I don't consider it decided yet!


Extend --node-cleanup task to search through sites themes folders too

Currently only checks hard coded paths in starter bunait theme.

node-cleanup was removed. Instead a node-sync task was added that checks for package.json in theme folders and runs 'npm install' where found.


[14.0.x] ISPN-14119 Filter null from evicted entities for distributed queries

https://issues.redhat.com/browse/ISPN-14119
Backport of https://github.com/infinispan/infinispan/pull/10396 to 14.0.x branch

merged! thanks @fax4ever !

Thank you @pruivo!


Default version check

As of February 17, 2017, the default cluster version used by Azure HDInsight is 3.5 and is based on HDP 2.5.
Table: HDInsight 3.6 (default)
These two statements are contradictory. I assume 3.6 is the default now? (and per the table, is based on HDP 2.6)

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: af6ae544-80bf-209a-9de5-63153fd47ab5
Version Independent ID: c70f7c14-6c10-a3e3-8593-8ec63b7fabe2
Content: Hadoop components and versions - Azure HDInsight
Content Source: articles/hdinsight/hdinsight-component-versioning.md
Service: hdinsight
GitHub Login: @kkampf
Microsoft Alias: kakampf

@dcbrown16
Thanks for the feedback! We are currently investigating and will update you shortly.

@cjgronlund could you help route this to a content author?  I was not able to assign it to the handle listed in the metadata.

Thanks for the catch! You are correct, 3.6 is the default version and 3.5 will be retired shortly. The document should be updated tomorrow.

#close


Is blockquote a component or an element?

          I am just wondering if the blockquote is a component or an element since the `.blockquote` class should only be used on `<blockquote>` elements....

I am adding this as a topic for the devs roundtable.
Originally posted by @alizedebray in https://github.com/swisspost/design-system/pull/3882#discussion_r1829386587
Tasks
### 💻 Tasks
- [x] Rename tokens from 'quote' to 'blockquote'

Resolution:

Style quotes based on language in elements and document under foundation/typography
Rename component to testimonial

New Resolution: It remains Blockquote


Proposal for subctl diagnose pre-install

This proposes a new command to validate the infrastructure before installing Submariner.
Signed-off-by: Mike Kolesnik<EMAIL_ADDRESS>

Since this pivoted to being part of join, converted to an issue - https://github.com/submariner-io/submariner/issues/2176


fail

Message: Interface\FrameXML\RestrictedExecution.lua:431: Call failed: Interface\FrameXML\RestrictedExecution.lua:126: [string "name, macros = self:GetName(), newtable([=======[/cast Misdirec..."]:1: function or expression too complex near '[=======[/cast Barbed Shot]=======]'
Time: Sun Apr 18 13:31:58 2021
Count: 96
Stack: Interface\FrameXML\RestrictedExecution.lua:431: Call failed: Interface\FrameXML\RestrictedExecution.lua:126: [string "name, macros = self:GetName(), newtable([=======[/cast Misdirec..."]:1: function or expression too complex near '[=======[/cast Barbed Shot]=======]'
[string "=[C]"]: ?
[string "=[C]"]: ?
[string "@Interface\FrameXML\RestrictedExecution.lua"]:431: in function <Interface\FrameXML\RestrictedExecution.lua:420>
[string "=(tail call)"]: ?
[string "=(tail call)"]: ?
[string "@Interface\FrameXML\SecureHandlers.lua"]:499: in function <Interface\FrameXML\SecureHandlers.lua:473>
[string "=[C]"]: in function `SetAttribute'
[string "@Interface\FrameXML\SecureHandlers.lua"]:743: in function <Interface\FrameXML\SecureHandlers.lua:725>
[string "=(tail call)"]: ?
[string "@Interface\AddOns\GSE\API\Storage.lua"]:853: in function `OOCUpdateSequence'
[string "@Interface\AddOns\GSE\API\Events.lua"]:449: in function `?'
[string "@Interface\AddOns\GSE\Lib\AceTimer-3.0\AceTimer-3.0.lua"]:55: in function <...terface\AddOns\GSE\Lib\AceTimer-3.0\AceTimer-3.0.lua:50>
Locals:

Hey Epoxer,
You need to fix your macro.  Forgive me for being blunt for a sec but this is a GiGo error - Garbage in, Garbage out.  You may have a copy/paste character error or the line is too long in context or something like that but the problem is a macro input problem.
TimothyLuke

On 18 Apr 2021, at 9:12 pm, Epoxer @.***> wrote:

Message: Interface\FrameXML\RestrictedExecution.lua:431: Call failed: Interface\FrameXML\RestrictedExecution.lua:126: [string "name, macros = self:GetName(), newtable([=======[/cast Misdirec..."]:1: function or expression too complex near '[=======[/cast Barbed Shot]=======]'
Time: Sun Apr 18 13:31:58 2021
Count: 96
Stack: Interface\FrameXML\RestrictedExecution.lua:431: Call failed: Interface\FrameXML\RestrictedExecution.lua:126: [string "name, macros = self:GetName(), newtable([=======[/cast Misdirec..."]:1: function or expression too complex near '[=======[/cast Barbed Shot]=======]'
[string "=[C]"]: ?
[string "=[C]"]: ?
[string @.\FrameXML\RestrictedExecution.lua"]:431: in function <Interface\FrameXML\RestrictedExecution.lua:420>
[string "=(tail call)"]: ?
[string "=(tail call)"]: ?
[string @.\FrameXML\SecureHandlers.lua"]:499: in function <Interface\FrameXML\SecureHandlers.lua:473>
[string "=[C]"]: in function SetAttribute' [string "@Interface\FrameXML\SecureHandlers.lua"]:743: in function <Interface\FrameXML\SecureHandlers.lua:725> [string "=(tail call)"]: ? [string "@Interface\AddOns\GSE\API\Storage.lua"]:853: in function OOCUpdateSequence'
[string @.\AddOns\GSE\API\Events.lua"]:449: in function `?'
[string @.\AddOns\GSE\Lib\AceTimer-3.0\AceTimer-3.0.lua"]:55: in function <...terface\AddOns\GSE\Lib\AceTimer-3.0\AceTimer-3.0.lua:50>
Locals:
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub, or unsubscribe.

yes i have cpoy my marco to my BM hunter.. i dont know how to fix this :/

copy*

You have your problem. I would suggest going back to the guy you got it from on YouTube for an update.

Well you what not a nice guy to ask...
Hämta Outlook för Androidhttps://aka.ms/ghei36

From: Timothy Minahan @.>
Sent: Sunday, April 18, 2021 2:13:40 PM
To: TimothyLuke/GnomeSequencer-Enhanced @.>
Cc: Epoxer @.>; Author @.>
Subject: Re: [TimothyLuke/GnomeSequencer-Enhanced] fail (#819)
You have your problem. I would suggest going back to the guy you got it from on YouTube for an update.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHubhttps://github.com/TimothyLuke/GnomeSequencer-Enhanced/issues/819#issuecomment-821982202, or unsubscribehttps://github.com/notifications/unsubscribe-auth/ATXM637HZXAVICXQU2GFEBDTJLEHJANCNFSM43EEJKQQ.

I actually managed to cause this error (see #873) - your macro far exceeds the number of characters that can be in a macro.  The solution is as I said originally "You need to fix your macro."  I cant tell you the what or how but either you or the original author needs to simplify the macro and make it smaller or split it into two macros.


Range query support

What this PR does:
Range query support for $gt,$gte, $lt and $lte operators.
Checklist

[x] Changes manually tested
[x] Automated Tests added/updated
[ ] Documentation added/updated
[x] CLA Signed: DataStax CLA

Range on _id field need to be done. Will create a separate ticket for it.

how did you do _id range query. I thought range query only applies to Date and Number.

Since we store id in query*_values indexes, we can support range query.

I did not know we do that. Good to know!


Ciklum - "targeting" link is missing

ENVIRONMENT: PROD
URL: https://scrapers.peviitor.ro/src/ciklum/
browser: Chrome
STEPS TO REPRODUCE:
1)open URL in the browser
2) go to the "Ciklum " logo and check link for "targeting"
EXPECTED RESULTS:
"targeting" link appear
ACTUAL RESULTS:
the link is missing

Nu exista firma pe targetare


On Change not getting fired after some time

After adding data in the monitored table, change in data is reflected in the event handler. But, after time of 2- 3 hrs, it stops working. I think problem might be due to lock on queue due to activation procedure. No data change is received, even though I add records on server side table. I can see queue filled with records but no change at client side. It keeps saying
Running waitfor command
after 2 mins timeout.
Can you help me with this? It is really necessary.

I have the same problem, my condition is  that i put the sqltabledependency in one service, but after some hours my computer has sleeped, and then i awaken my computer ,the sqltabledependency no longer listener the sql changed.

@ dengxuesong: "but after some hours my computer has sleeped". This is why SQL TableDependency objects are disposed.


Added radix sort in Java

: It would be great if you can add the description along with the issue number.
Feel free to use our contribution guidelines (https://github.com/fnplus/interview-techdev-guide/blob/master/CONTRIBUTING.md#how-to-contribute-an-implementation-code) for reference


Possible bug.

In file included from ../fmtconv/build/unix/../../src/conc/CellPool.h:141:
../fmtconv/build/unix/../../src/conc/CellPool.hpp:273:26: warning: variable 'i' used in loop condition not
      modified in loop body [-Wfor-loop-analysis]
                for (size_t i = count; i > 0; --count)

I suppose --count should be --i :)

Well spotted, thank you! It’s not a big deal because it is located in a path which should be rarely followed. Anyway it is now fixed in commit 2b8a1adb77b705b3a14d13c52cdfdb2a92adb7fd


[mesheryctl] version command provides invalid upgrade prompt

Description
mesheryctl version runs a check for the latest version of Meshery that is available and will inform the user if a later version is available than what the user has installed.
mesheryctl version
Client Version: 0.4.13 	  GitSHA: aa6dbc84ba47d81d087ae7c7f5693a0d8cce9cc2
Server Version: v0.4.13 	  GitSHA: aa6dbc8

v0.4.13 is not the latest Meshery release. Upgrade to v0.4.14. Run `mesheryctl system upgrade`

Expected Behavior
The prompt (instructions) provided in this output say to execute system upgrade. The command is actually system update.

I'll take this

@cardinalion, excellent. 😄


[improve][broker] Avoid put all delayed messages to redeliver queue

Motivation
#18098 makes all delayed messages go into the redeliver queue, I think we can provide another way to avoid putting all delayed messages into the redeliver queue to solve this problem.
Modifications

Introduce a new exception carrying message location.

Verifying this change

[x] Make sure that the change passes the CI checks.

Documentation

[ ] doc
[ ] doc-required
[x] doc-not-needed
[ ] doc-complete

Codecov Report

Merging #18118 (25c8d91) into master (6c65ca0) will increase coverage by 16.11%.
The diff coverage is 54.54%.

@@              Coverage Diff              @@
##             master   #18118       +/-   ##
=============================================
+ Coverage     34.91%   51.02%   +16.11%
- Complexity     5707     8758     +3051
=============================================
  Files           607      607
  Lines         53396    53515      +119
  Branches       5712     5740       +28
=============================================
+ Hits          18644    27308     +8664
+ Misses        32119    23167     -8952
- Partials       2633     3040      +407

Flag
Coverage Δ

unittests
51.02% <54.54%> (+16.11%)
:arrow_up:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files
Coverage Δ

.../pulsar/broker/service/AbstractBaseDispatcher.java
52.14% <ø> (+6.28%)
:arrow_up:

.../service/SystemTopicBasedTopicPoliciesService.java
62.97% <0.00%> (+11.38%)
:arrow_up:

.../pulsar/broker/stats/BrokerOperabilityMetrics.java
98.21% <ø> (+5.56%)
:arrow_up:

...g/apache/pulsar/compaction/CompactedTopicImpl.java
69.28% <0.00%> (+58.57%)
:arrow_up:

...va/org/apache/pulsar/io/jdbc/JdbcAbstractSink.java
3.22% <0.00%> (-0.97%)
:arrow_down:

...java/org/apache/pulsar/io/jdbc/JdbcSinkConfig.java
20.00% <0.00%> (-5.00%)
:arrow_down:

...main/java/org/apache/pulsar/io/jdbc/JdbcUtils.java
0.00% <0.00%> (ø)

...sistent/PersistentDispatcherMultipleConsumers.java
57.49% <20.00%> (+5.79%)
:arrow_up:

.../org/apache/pulsar/broker/admin/v2/Namespaces.java
56.85% <50.00%> (+48.82%)
:arrow_up:

...ache/pulsar/broker/service/EntryFilterSupport.java
27.02% <50.00%> (+2.02%)
:arrow_up:

... and 165 more

reopen when we need to improve it.


It doesn´t work in Microsoft Edge

The effect is really nice and it works perfect in Chrome and Firefox but it seems there is a problem with microsft´s browser.

Property "background-size" is not an animatable property in IE https://msdn.microsoft.com/library/dn254934(v=vs.85).aspx


Remove mentions of "tags" in app

Description:
We want to start using word "sensor" in all of these locations, since "tag" is technically a product name.
Splash screen app intro: "Access data for each linked RuuviTag in real time and explore history graphs" -> "Access data for each linked sensor in real time and explore history charts"
Splash screen app intro: "Press SCAN to find and add nearby RuuviTags to your Ruuvi Station" -> "Press SCAN to find and add nearby sensors to your Ruuvi Station"
No sensors placeholder screen: "No tags added, press here to add tags" -> "No sensors added, press here to add sensors"
Tag Settings -> Sensor Settings
Tag Name -> Sensor Name
Bluetooth activation request popup: "The app uses Bluetooth LE to read data from RuuviTag sensors" -> "The app uses Bluetooth LE to read data from Ruuvi Sensors"
Gateway Settings: "When you add a URL here, the app will execute an HTTP POST with the linked tags when it does background scanning." -> "When you add a URL here, the app will execute an HTTP POST with the linked sensors when it does background scanning."
About/Help: Seen tags, Added tags -> Seen sensors, Added sensors
Also adopt this practise to Play Store updates if we give info what changes are made

Is the "word" RuuviTag acceptable?

@DG12 we will use RuuviTag since it's product name. QA passed.


ostree-kernel-initramfs: deploy dtbs from OSTREE_DEVICETREE

Signed-off-by: antznin<EMAIL_ADDRESS>

@patrickvacek I noticed there is a new fix for ostree-kernel-initramfs, needs to be backported to zeus.


Switch Toggle Doesn't support RTL

Describe the bug
On RTL switch toggle goes out of boundary as shown below. This bug is also reported in the following deprecated repo https://github.com/dooboolab/react-native-switch-toggle/issues/33

To Reproduce
Use RTL layout with simple switch toggle navigation
<SwitchToggle
  containerStyle={styles.switchContainer}
  circleStyle={styles.switchCircle}
  switchOn={toggleCompare}
  onPress={() => setToggleCompare(!toggleCompare)}
  circleColorOff={colors.superWhite}
  circleColorOn={colors.superWhite}
  backgroundColorOff={colors.darkGray}
  backgroundColorOn={colors.linkedinColor}
  duration={500}
/>

Expected behavior
On Toggle on RTL, position of circle should move in opposite direction
Screenshots

Thank you for issue reporting. I will check ASAP.

@JongtaekChoi Can you also look into this one?

@anaskhraza Could you show me the details of the containerStyle and the circleStyle of your source code?
Currently, SwitchToggle is off when the inner circle is on the left and on when it is on the right.
I think it would be better to rename props items to support RTL.

current name
changed name
other

switchOn
switchOff
It is needed to change value type ('left' or 'right')

backgroundColorOn/Off
backgroundColorRight/Left

circleColorOn/Off
circleColorRight/Left

Another option is to add RTL to the prop so that the inner circle moves in reverse.

@anaskhraza
Could you show me the details of the containerStyle and the circleStyle of your source code?
You've probably set the position of inner circle. But, SwitchToggle was not made in consideration of such a situation.
The inner circle is located to the right of the initial position if the switchOn value is true and it is located to the initial position if the value is false.
I think it would be better to rename props items to support RTL.
current name	changed name	other
switchOn	switchOff	It is needed to change value type ('left' or 'right')
backgroundColorOn/Off	backgroundColorRight/Left
circleColorOn/Off	circleColorRight/Left
Another option is to add RTL to the prop so that the inner circle moves in reverse.

Could you give a PR for such proposal?

@hyochan following is the containerStyle and circleStyle that I'm using
switchCircle: {         width: 10,         height: 10,         borderRadius: 10,         backgroundColor: colors.white,     },     switchContainer: {         width: 30,         height: 15,         borderRadius: 10,         backgroundColor: colors.gray,         padding: 2,     },
Since RTL mirror the application off position of the switch aligns to the right as shown in the snapshot below. so when the switch has been triggered to on then, toggle switch calculates the end Position of circle as it was doing for the normal left align layouts
   var endPos = props.containerStyle && props.circleStyle         ? props.containerStyle.width -             (props.circleStyle.width +                 props.containerStyle.padding * 2)         : 0;     var circlePosXEnd = endPos;
I think the easiest solution will be to use a prop for RTL and after calculating endPosition, multiply the position with -1 if it is on RTL mode.


release: bump verison to v0.1.1

release of v0.1.1

Note we need to double check the FOSSA violations, looks like most of them are coming from typescript and one from lodash. I believe we already cleared these, but let's double check.


boards: arm: nucleo_f767zi: doc: use extlink for github issue link

Use extlink for GitHub issue link in board documentation.
Signed-off-by: Henrik Brix Andersen<EMAIL_ADDRESS>

This is a hotfix for the documentation build issue seen in https://github.com/zephyrproject-rtos/zephyr/runs/4833163774 (#41847).

This issue is a result of https://github.com/sphinx-doc/sphinx/pull/9800 which was merged in Sphinx v4.4.0.


README documentation updated

Checking CLA
README Documentation updated

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

This PR can be closed. We fixed the docs from the Internal repo.


280 repeat vars

@jsadler2 - there is something not quite right about a pull request that affects 740 files. Could your last commit be reviewed and modified to only include the files you really want to change?
630c860
It is very difficult to parse out what to look for with this many files being changed.
If there is the need to modify the file permissions, which is what most of the changes seem to be, then that should be an issue onto itself.

Yeah all the file permission stuff is not needed. I think only a couple files should have actually been modified. What's the best way to make that change @mjstealy?

@jsadler2 - merged and deployed to dev


How can i present PhotoLibrary without referenceView

I am trying to download from url's some photos and it seems that the referenceView is required.
Is there a way to have optional the referencedView? because sometimes referenceView is not always available
(action from text to open a remote image for example)
(i have subclassed DTPhotoViewerController and added activityIndicator to hide when download completes)

Sorry for getting back to this so late. I will be maintaining this project regularly from now on. I will add feature to present photo viewer controller without a reference view.

@Alexookah #29 should fix your issue.


document --nprocs NPROCS and --omp-nthreads

The documentation at
https://mriqc.readthedocs.io/en/stable/running.html
shows output from mriqc -h that appears to be perhaps not up to date?  It looks like some options are missing that are now available, and maybe shows options that are no longer available?
In particular, it displays
             [--upload-strict] [--n_procs N_PROCS] [--mem_gb MEM_GB]

but makes no mention of --omp_nthreads.  My just-installed mriqc 0.15.2 shows
             [--nprocs NPROCS] [--omp-nthreads OMP_NTHREADS] [--mem MEMORY_GB]

from --help.
I am not an image analyst, just the system administrator, but I need to be able to tell people what the difference is between --nprocs and --omp_nthreads.
To me, those are very different things, especially in the context of a job on a cluster.  I think those are used by the underlying nipype, but very different things could happen if we mix up processes and threads.
In my usual understanding, I might want to have 16 processors, but if how does nipype dived up threads to the processor pool if one specifies --ncpus=16 --omp_nthreads=4?
I would find it very helpful if a couple of examples of using --nprocs --omp_nthreads could be supplied.
I am seeing in ./mriqc/config.py
    nprocs = os.cpu_count()
    """Number of processes (compute tasks) that can be run in parallel (multiprocessing only)."""
    omp_nthreads = os.cpu_count()
    """Number of CPUs a single process can access for multithreaded execution."""

which gives me some concern, as on our cluster, jobs do not have whole node assignment, but are launched within a cpuset/cgroup and os.cpu_count() returns the the number of physical processors and not the number allocated to the job.
I hope this all makes sense.

Definitely worth adding notes on this to the docs. To briefly describe the difference:

--omp-nthreads sets the maximum number of threads to use for a specific job within the workflow.
--n_procs sets the maximum number of threads used by all jobs at a time.

So if you have --n_procs 16 --omp-nthreads 4 you will limit each job to 4 threads and all simultaneous jobs to 16 threads, so you could get up to 16 1-core jobs or 4 4-core jobs (or somewhere in betweeen) running simultaneously.

@effigies I think that the terminology may not be helping here.  I don't believe that --n_procs sets the number of 'threads'; it sets the number of processors (or should).  The --omp-nthreads should probably correspond to the environment variable OMP_NUM_THREADS and be the maximum number of threads that a multi-threaded process can attempt to use.  The --n_procs should set the maximum number of processors that can be allocated, and it would be good to know whether the processors on which the processes that NiPype runs its workflow management are included in that and whether that processor is made available to sub-parts of the fmriprep workflow.  I think your version of 2. above will cause more confusion because it uses the term 'threads'.  Whether that is correct usage technically or not, it is confusing.
I might suggest (if it is accurate) that those options should mean something like this (I hope I am accurate).  This almost certainly isn't perfect, but I think it may be an improvement.

--omp-nthreads sets the maximum number of threads that multi-threaded programs used in fmriprep can use, e.g., ANTs.  Each thread will be assigned to a processor.

--n_procs set the maximum number of processors that can be assigned work within an fmriprep job, which includes all the processors used by currently running single- and multi-threaded processes.

So if you have --n_procs 16 --omp-nthreads 4 you will limit each job to 4 threads and all simultaneous jobs to 16 threads, so you could get up to 16 1-core jobs or 4 4-core jobs (or somewhere in betweeen) running simultaneously.
This is a confusing topic because the terms process and thread are used to mean different things in different contexts by different people.  I think the ideal would be to accept some technical 'sloppiness' in favor of clarity for the less technical and less experienced.
Thanks for getting back to this!  I hope my suggestion has something worthwhile in it.

I don't believe that --n_procs sets the number of 'threads'; it sets the number of processors (or should).

Both are right. This is what it should be, but, considering how we implemented this in nipype, Chris' definition is valid too for most of the cases.
If you set a higher number of threads than processors, then the nipype heuristic will fall back to the usual understanding of the parameters (e.g., --n_procs 8 --omp-nthreads 12 will run at most 8 processes in parallel, and each may use 12 threads internally at most).

@oesteban On my cluster, if I request in my job, say, 8 processors, then my job gets assigned to a cgroup that limits my job to using 8 processors of 36.  In my normal work with something like MPI, I would start, say 4 MPI processes, each of which is multithreaded and can run as many threads as are specified by OMP_NUMTHREADS, so, in this case 2 each to enable 100% usage of all the processors allocated to my job.
What confuses me is whether fmriprep is accounting for things in the same or a different way.  So, if I say --n_procs 8 --omp-nthreads 12, then if there were really 8 ANTs processes running, and each of those were using 12 threads, then I would need 96 processors if I want them all to work at 100%.  On the other hand, if I say, --n_procs 2 --omp-nthreads 4, then I would think nipype would start only 2 main processes, but when (for example), ANTs runs, it can use up to 4 threads each, which quite a lot of ANTs programs can.
The situation I am trying to avoid is when my cluster job has some number of processors, but none of them are able to run at 100%, so the job takes longer because of process swapping.
Does that make sense?  Am I missing something here?
Thanks for looking into this.

If you set a higher number of threads than processors, then the nipype heuristic will fall back to the usual understanding of the parameters (e.g., --n_procs 8 --omp-nthreads 12 will run at most 8 processes in parallel, and each may use 12 threads internally at most).

I am interpreting this as permitting up to 96 parallel threads, which is not correct based on my reading of the scheduler. If no node is running and the next node requires more resources than are declared available, we run that but nothing else can run until those are freed. So in this case, an ANTs node that uses 12 threads will not run until all running nodes have completed and, once started, will prevent any other node from running.
The relevant lines:
            next_job_gb = min(self.procs[jobid].mem_gb, self.memory_gb)
            next_job_th = min(self.procs[jobid].n_procs, self.processors)

            # If node does not fit, skip at this moment
            if next_job_th > free_processors or next_job_gb > free_memory_gb:
                logger.debug(
                    "Cannot allocate job %d (%0.2fGB, %d threads).",
                    jobid,
                    next_job_gb,
                    next_job_th,
                )
                continue


Fix preparation of destroyed items

Added isDestroyed to DisplayObject, BaseTexture, which is automatically set in destroy().
The prepare plugins will automatically skip destroyed items, by checking the isDestroyed property.

I've seriously resisted the isDestroyed markers for a while. destroy() should just remove itself from the pixi ecosystem of things, and users should drop references. Anything else is an error and should be corrected, not worked around by checking if something is destroyed, imo.

I agree with chad on tho one!
On Thu, 2 Mar 2017 at 16:25, Chad Engler<EMAIL_ADDRESS>wrote:

I've seriously resisted the isDestroyed markers for a while. destroy()
should just remove itself from the pixi ecosystem of things, and users
should drop references. Anything else is an error and should be corrected,
not worked around by checking if something is destroyed, imo.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/pixijs/pixi.js/pull/3802#issuecomment-283701967, or mute
the thread
https://github.com/notifications/unsubscribe-auth/AC998tXCEysyHy3sP82WEWm79MFawzXFks5rhu1-gaJpZM4MP-2Y
.

That marker is better than events or signals. Of course it is only for internal usage or dirty production hacks. We don't have to promote it as solution for user problems. We have many hacks that we made for performance causes already.

Can we mark it in docs like "for internal usage" ?

I agree with the sentiment about what destroy() should do, but this is a situation where the thing being destroyed has no access to the renderer that might be preparing it, which limits us to setting a variable or emitting an event. We certainly could make the property internal to the library, if that would assuage your concerns.

My preference would be to have this be an internal flag only (e.g., _destroyed) documented as private, since it is only used by internal classes.

Also, @andrewstart this PR should go to dev not master.

@andrewstart could you describe your use-case more specifically why this flag is necessary? Why are destroyed items being sent to the prepare plugin that cannot be mitigated by better resource management dev-side?

The use case is when one is preparing one or more items to be used, it could take a bit of time due to rate limiting to avoid hitting the framerate too hard. Sometimes, due to user input, the items being prepared need to be discarded (out of view, exiting state to a different game state, etc) before they can be prepared.

@andrewstart My follow question would be: why can't the destroy method send out a notification that the prepare system uses to know to remove that item from its list of items.

Our options are emitting an event or marking it with a private variable. My preference is the variable, because it should be slightly lighter weight, but if the consensus is that this should use events, I'll change it.

@englercj or @GoodBoyDigital do you want to weigh-in on Andrew's options? I don't have a strong preference on way or another, but overall, I support this PR.

Like I mentioned, I'm abstaining :)

I say private variable @andrewstart!

It has now been changed to _destroyed and is marked as private.

Please don't merge this right away. Need to confirm dev vs master with @andrewstart.


separate PR for Dockerfile only.

As #5 says

We finally added a Dockerfile! quay.io/coreos/discovery.etcd.io should have a build soon.


[zh] sync access-authn-authz/authentication.md

content/zh-cn/docs/reference/access-authn-authz/authentication.md

/lgtm
/approve


Update the foxy conf.py to match rolling.

That way it renders like we expect on 'make html'
Signed-off-by: Chris Lalancette<EMAIL_ADDRESS>

I'm just going to go ahead and merge this since it doesn't have any effect on the final result (just the local results when building on the branch).


Running on a dedicated server???

Hi,
First, thank you for licensing this under the MIT license. Practically all of the other alternatives are under the GPL or AGPL which I can neither use nor help with.
I want to be able to run this on my dedicated server. it has 64 GB of a RAM, a powerful Xeon server from 2022, and is running nginx and PostgreSQL.
It is currently running webapps via PHP, NodeJS, and Docker for everything else.
What would be involved in porting this to that kind of setup?
I'm a docker expert, btw.

Hey! The main change would be a nearly full re-write of the backend.
Specifically https://github.com/sshh12/llm-chat-web-ui/blob/main/modal/methods_web.py all these routes would need to be swapped to a fastapi/expressjs/etc framework.


Ensure https://github.com/PolymerLabs/arcs/pull/1124 is reflected in shell.

@piotrswigon FYI, looks like the generations list is being used by the shell for arc reconstruction.

Thanks for fixing! Was the issue in one of the major flows that we should have a test for?


test: don't skip unicode related tests anymore

Description
This PR reverts #15096 as the bug (https://github.com/nodejs/node/issues/48673) was fixed in node 20.12.0.

Given that more than 1 month has passed since the 20.12.0 release, I think we can now merge this PR.


Update rewiremock to update lodash.template

lodash.template should be >=4.5.0. Gets pulled in by rewiremock.

Not an issue anymore.


WebGL Renderer

More of an enhancement than an issue, the problem with canvas rendering is that, once you have more than say 800 - 1000 items being rendered, the canvas becomes super slow.
The solution around this would obviously be to use WebGL instead of the canvas context (if it is available, but usually if you can use canvas you can use WebGL).
I'm not sure if it would be better to depend on a library (like https://two.js.org/) or create one from scratch.
@micahstubbs perhaps we can spend some time on discord to discuss some of this?

WebGl rendering certainly can give us speed.
@Tyler-Maclachlan if you haven't already, I'd encourage you to go through this list of graph vis libraries, and compare the ones with WebGl renderers. I imagine that there are patterns we can emulate and maybe even libraries that visjs-network could directly depend on for fast rendering.
https://github.com/anvaka/graph-drawing-libraries
https://github.com/anvaka/graph-drawing-stats

oh! so d3-community friend @vasturiano has also written some graph visualization libraries with WebGL renderers https://github.com/vasturiano?utf8=✓&tab=repositories&q=WebGL&type=&language=

I have looked at a few of these before, but I see https://github.com/anvaka/ngraph has some examples on how to integrate a webGL renderer, so I'll have a look if I can do that.

3d-force-graph uses ThreeJS / WebGL for rendering, and is mostly suited for 3D graphs (though it can render to 2D planes if desired).
But, perhaps also of interest is force-graph which uses 2D Canvas but is focused around performance.
Here are examples with ~4k elements and ~75k elements.


Problems -> Ex. 6

Shall we discuss on Ex. 6 of Section 10 "Problems" sometime before our submission deadline? Below are my results and I list the important parameters:
dt = 0.0095 (fixed, not adaptive), t_end = 100, omg = 1.7, itermax = 100
imax = 16, U[imax/2][7jmax/2] = -0.040150.
imax = 32, U[imax/2][7jmax/2] = -0.159831.
imax = 64, U[imax/2][7*jmax/2] = -Nan.
dt = 0.005 (fixed, not adaptive), t_end = 100, omg = 1.7, itermax = 100
imax = 16, U[imax/2][7jmax/2] = -0.040150.
imax = 32, U[imax/2][7jmax/2] = -0.159831.
imax = 64, U[imax/2][7jmax/2] = -0.213420.
imax = 128, U[imax/2][7jmax/2] = -Nan.
dt = 0.001 (fixed, not adaptive), t_end = 100, omg = 1.7, itermax = 100
imax = 16, U[imax/2][7jmax/2] = NA
imax = 32, U[imax/2][7jmax/2] = NA
imax = 64, U[imax/2][7jmax/2] = NA
imax = 128, U[imax/2][7jmax/2] = -0.220711.
I have not tried imax =256. Also I compare the cases for imax = 16 & 32 between dt = 0.0095 and dt = 0.005, and cannot see any difference. That is why I did not recalculate the result for imax = 16 & 32 & 64 using dt = 0.001.
I also keep the result vtk files using Eva's latest main.c, and have some velocity screenshots.

Hey, I dont completely get what ex. 10.6. even wants from us. :/ I mean, based on your results, when would you say that U tends to infinity? :S Its so weird.... I dont get it.
And btw, if you two agree, I shall clean the main function (comment the picture output etc.) and submit the finished version.

I agree. Thank you so much!
For Ex. 10.6, is it about the relation between maximal time step size and spatial step size to achieve stable discretization? Think in Scientific Computing 1 for heat equation with Dirichlet B.C., we have delta_t < (h^2)/4. Here it is not the same relation, however.

Yes but, where the step size is too big, we should see some problems (as U going to infinity). But I cant really see that in our results :S it seems that troubles begin when h is to big, and not too small as one might expect :persevere:

As per discussed just now, the results when dt = 0.001 should be as follows:
imax = 16, U[imax/2][7jmax/2] = ... (not calculated, should be same with the previous 2 cases)
imax = 32, U[imax/2][7jmax/2] = ... (not calculated, should be same with the previous 2 cases)
imax = 64, U[imax/2][7jmax/2] = ... (not calculated, should be same with the previous 2 cases)
imax = 128, U[imax/2][7jmax/2] = -0.220711.

After correcting the index error, the results are:
dt = 0.0095 (fixed, not adaptive), t_end = 100, omg = 1.7, itermax = 100
imax = 16, U[imax/2][7jmax/2] = 0.198288.
imax = 32, U[imax/2][7jmax/2] = 0.253764.
imax = 64, U[imax/2][7*jmax/2] = -Nan.
dt = 0.005 (fixed, not adaptive), t_end = 100, omg = 1.7, itermax = 100
imax = 16, U[imax/2][7jmax/2] = 0.198288.
imax = 32, U[imax/2][7jmax/2] = 0.253764.
imax = 64, U[imax/2][7jmax/2] = 0.282674.
imax = 128, U[imax/2][7jmax/2] = -Nan.
dt = 0.001 (fixed, not adaptive), t_end = 100, omg = 1.7, itermax = 100
imax = 16, U[imax/2][7jmax/2] = ... (not calculated, should be same with the previous 2 cases)
imax = 32, U[imax/2][7jmax/2] = ... (not calculated, should be same with the previous 2 cases)
imax = 64, U[imax/2][7jmax/2] = ... (not calculated, should be same with the previous 2 cases)
imax = 128, U[imax/2][7jmax/2] = 0.296728.

Mission accomplished, closing the issue.


Sunstone wrong font-color on cloud view and admin view vm instatiate network

Description
Font color is light blue on white backround, which is not readable well
Expected behavior
Standard font color
Details

Affected Component: [Sunstone]
Hypervisor: [ANY]
Version: [6.2]

Progress Status

[x] Code committed
[ ] Testing - QA
[ ] Documentation (Release notes - resolved issues, compatibility, known issues)

New React Sunstone has a different color scheme, please reopen if the same issue is found in it. We won't be investing more in Ruby Sunstone.


Added the countries.json file and updated the code to fetch the data from the file(#531)

Related Issues
#531
Closes #531
Short Description and Why It's Useful
This feature will help a user to define the specific countries for the storefront.
IMPORTANT NOTICE - Remember to update CHANGELOG.md with description of your change
Contribution and Currently Important Rules Acceptance

[x] I read and followed contribution rules

Another solution for implementing this functionality is to define the doingBusinessInCountry parameter in the config file consisting of the countries which we need to include in the storefront.
Then updating the code to filter the countries from the countries.json file on the basis of dbic field in the config.

@ymaheshwari1 @Fifciu , I think we can merge this implementation for now and can create an feature request for the DBIC implementation

Another solution for implementing this functionality is to define the doingBusinessInCountry parameter in the config file consisting of the countries which we need to include in the storefront.
Then updating the code to filter the countries from the countries.json file on the basis of dbic field in the config.


Removed commons-codec and replaced it with a native Base64 implementation.

I don't see a reason to depend on the commons-codec library when there's a native Java 5 implementation of Base64 within the javax libs. This adds 240KBs of weight to the overall program which is unnecessary.

Travis is complaining about JAVA_HOME not being setup properly between builds. I don't see how this is something I caused.

Thank you! At a glance this looks reasonable, I'll get back to this after I'm done with some other things.

Looks good, except for the change to HttpOathOtpLoginModule which breaks it. If you want me to include you in the <contributors> in the POM, please let me know your name and e-mail address. Thanks again for your contribution!

Forgot to mention that I don't blame you for not noticing the breakage in HttpOathOtpLoginModule as we didn't have any tests for it.

You can use Robert<EMAIL_ADDRESS>Thanks again for making a great product.


Permissions on /var/log incorrect according to CIS RHEL 8 v2.0.0 benchmark

Hi Tom,
I have found error in cis_security_hardening::rules::logfile_permissions compared to the baseline provided by CIS.  I'm comparing the output of your module (and it is a great module), to CIS Red Hat Enterprise Linux 8 Benchmark v2.0.0 which is the latest I believe.
The puppet file resource is used to recursively keep the file permissions in order.  However if another application writes it's log files to /var/log it doesn't have permission to open that file.  The CIS lockdown remediation does not change the permissions on /var/log only the file contained within.
The resolution may i suggest is to use a puppet another puppet module https://forge.puppet.com/modules/npwalker/recursive_file_permissions/readme
This allows you manage the directory permissions separately from the directory, and have a bonus of being more performant.
Otherwise perhaps an exec resource to perform the action of;
find /var/log/ -type f -perm /g+wx,o+rwx -exec chmod --changes g-wx,o-rwx "{}" +
As per the CIS benchmark?

Will be fixed in release 0.8.2


Move this repo from okfn to frictionlessdata.io as ideas tracker (and split out codebase)

okfn/data.okfn.org => frictionlessdata/ideas
General Overview

[x]  sort out any outstanding pull requests etc whilst at data.okfn.org
[x] move this repo to frictionlessdata/ideas
[x] push a copy of the repos code to okfn/data.okfn.org-new (NOT to data.okfn.org as we want redirects to work ...)
[x] strip content from here (push force a clean repo on master
[x] Create a nice README

Migrating content

[x] create frictionlessdata/frictionlessdata.io for the new website
[x] main site as jekyll repo there - move all static content here (this is what this repo will become)
[x] setup dns for frictionlessdata.io datapackages.org etc
[x] implement redirects in DNS for relevant parts of data.okfn.org to frictionlessdata.io
Redirect data.okfn.org/doc/* (either en masse to fd.io/guides/ or individual pages)
Redirect data.okfn.org/standards/ fd.io/data-packages/
Redirect data.okfn.org/vision/ -> fd.io

Migrating tools: separate issue #261
Migrating catalog - seaprate issue ...

[ ] catalog i.e. /data/ => ??

@danfowler if you are working on this could you update here what the plan is exactly so it can be briefly discussed. Also any updates on timeline.
/cc @pwalsh @jobarrat

@rgrp

I have redeployed a branch of this codebase to heroku.
datapackages.org now points there
I will go through this site and make tweaks to ensure some consistency, fix links, etc.
I will start planning out the new content this week in advance of the design work

@danfowler any thoughts on the process i had originally outlined. Also worth us speccing out what exactly will go and what will stay.
I imagine specifically that datapackages.org is jekyll / static only (I would highly recommend this to avoid e.g. site falling over if heroku crashes which has happened). As such, we want a migration path for various chunks of the services (maybe some stuff stays on data.okfn.org etc)

@rgrp I think, for now, we have one url we can start pointing people to, datapackages.org, without spending much time at all.
With Jo and @pwalsh, we can start the process now of deciding what the new site will look like.  I'm pretty inclined to have static content hosted on GitHub Pages, limiting our reliance on an actual server running somewhere, but I think we wanted a quick fix here.
I've take /tools/ and /data/ away, and I think there's some basic refactoring of the content to be done.  what else do you think should go?

@danfowler I want to note some points from chat the other day (in progress - tbc):

datapackages.org should be static only and run off jekyll
I strongly recommend a 1-2 approach - migrate content as is, then refactor.

Lastly: I think we should distinguish refactoring and moving this repo from the question of the site work. I need to explain this in a bit more detail ...

@rgrp Now that we have https://github.com/frictionlessdata/frictionlessdata.io I'd like to move this repository to the frictionlessdata organization and rename it to "ideas" and we can keep updating with user stories.  I'll close out the website-specific issues on this repo and clear out the content.
We can then move forward on publishing as frictionlessdata.io if you're happy with it.

@danfowler so we need a bit of a plan to proper split out the different bits in this repo. Can you plan out here step by step what you plan to do so we can check it.
For example, we need to work out what still powers data.okfn.org, whether we split out the core "dataportal" code to a repo somewhere (some people seem to like that etc etc ...)

OK, i've updated issue description with new, clear plan.

@roll we are generally using Milestones rather than "Status" tags for indicating stuff like "Backlog"

@rgrp I was experimenting with waffle.io based on OpenSpending (@akariv) experience. So it has been added by system when I've moved it to Backlog column.
https://waffle.io/frictionlessdata/ideas
Couldn't be it useful to manage this ideas?
To revert I just need to delete Status: Backlog label.

@danfowler / @pwalsh could we look at doing the redirects listed above. I think this is a high priority as currently quite a bit of confusion ...

Redirects now implemented:
https://github.com/okfn/data.okfn.org-new/commit/9d74771533f7734054dc496273bcd372fa702f28

@danfowler i would definitely have done this in dnsmadeeasy not in the codebase. That way these would exist even if we move the app or take it down. Can you look at doing this in dnsmadeeasy.
Sorry if this wasn't obvious - when i mentioned in the channel i thought i'd indicated dnsmadeeasy.
/cc @pwalsh

oops. definitely something to do in DNS.

New website: http://frictionlessdata.io/
Redirects implemented from old website: http://data.okfn.org
Project tracker in place: https://github.com/frictionlessdata/project


Can torch.linalg.eig() be replaced with torch.linalg.eigh() in _get_steering_vector_evd() in MVDR?

As psd_n and psd_s are Hermitian and symmetric matrices, can torch.linalg.eig() be replaced with torch.linalg.eigh() in _get_steering_vector_evd() for  faster computes the eigenvalue decomposition?

Hi @CaA23187, exactly. In the 0.12 release, the RTF (or steering vector) is computed by torch.linalg.eigh. See the rtf_evd method in https://github.com/pytorch/audio/blob/main/torchaudio/functional/functional.py#L2061
    _, v = torch.linalg.eigh(psd_s)  # v is sorted along with eigenvalues in ascending order


I can't remove in composer

I cant remove composer remove appzcoder/crud-generator
after installing appzcoder/laravel-admin

Because appzcoder/laravel-admin is dependant on this package


new opened file is in same tab so that old file disappear

VSCode Version: 1.24.1
OS Version: WIN7

Steps to Reproduce:

open fileA
then open fileB,  fileB occupy the only tab, so fileA disappear.

is  there way to make new opened file in new tab?  thanks!

Does this issue occur when all extensions are disabled?: Yes/No

you can just select more than one file or a hole folder

Follow our docs to resolve this: https://code.visualstudio.com/docs/getstarted/userinterface#_preview-mode


How does tensorflow-gnn handle the mapping between node feature vector and node index?

How does tensorflow-gnn handle the mapping between node feature vector and node index? If the feature vector of a node is input, can tensorflow-gnn automatically know which node it is?

The feature vectors for all nodes in a node set are stored together in a single Tensor. The feature vector for node $i$ is found in that tensor at index $i$. For more details, please see the TF-GNN paper, esp. Figures 2b and 3, as well as the GraphTensor guide.


pythonPackages.send2trash: fix hash

Motivation for this change
Fixes https://github.com/NixOS/nixpkgs/issues/75514
Things done

[ ] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
Built on platform(s)

[ ] NixOS
[ ] macOS
[ ] other Linux distributions

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
[ ] Tested execution of all binary files (usually in ./result/bin/)
[ ] Determined the impact on package closure size (by running nix path-info -S before and after)
[ ] Ensured that relevant documentation is up to date
[ ] Fits CONTRIBUTING.md.

Notify maintainers
cc @

@GrahamcOfBorg build pythonPackages.send2trash

thanks, looks like I forgot to update hash. must have been working due to local cache. My bad


GN-4650: Start number

Overview

Allows to set a "start number" for a structure.
Introduce numberDisplayStyle and startNumber attributed for _header nodes.

connected issues and PRs:
https://binnenland.atlassian.net/browse/GN-4650
Setup

Checkout
npm run start

How to test/reproduce
Have a look at the video - https://share.cleanshot.com/d87pbryy

Try to reproduce what is happening in the video
Try checkout master, create a structure there, then checkout this branch and see if structure is still intact.

Challenges/uncertainties
I have moved storing calculated number to the content attribute of "heading" element. So instead of storing "romanized" number, we now store actual integer (as string) and a displayStyle (on the root level). But, magically, this commit and current master and backwards compatible against each other, as we still store "converted" number (e.g. romanized) in the textContent of the "heading" element.
Checks PR readiness

[X] UI: works on smaller screen sizes
[X] UI: feedback for any loading/error states
[X] Check if dummy app is correctly updated
[X] Check cancel/go-back flows
[x] changelog
[x] npm lint
[X] no new deprecations

Not sure why the precompile fails :( Looks like we're checking node_modules TS files with our tsconfig, even though skipLibCheck is enabled 😅
P.S. OK it is the ember ts:precompile which uses own config for TS check. Wondering how did I break it in this PR.

The weird thing is that it doesn't fail on master :thinking:


Missing "send" button

On the feature phone:
I navigated to this page
the button "Enviar" (send) is not there. See picture below.
https://drive.google.com/file/d/1H3ZHKtaebpe6CwLLTCCFPLylunftJlPG/view?usp=sharing
This is described in issue 7 in IoGT Ecuador tab

This should have been fixed by #1165 but the update hasn't been pushed to the Ecuador site.


Update npm packages for Blazor app

This PR resolves #67

@katiesavage Would you be able to merge this PR and close #67 ?


[22.05] vscode: 1.69.2 -> 1.73.1

Description of changes
Fixes CVE-2022-41034, CVE-2022-41042, CVE-2022-41034 and CVE-2022-38020.
VSCode changelogs:
https://code.visualstudio.com/updates/v1_70
https://code.visualstudio.com/updates/v1_71
https://code.visualstudio.com/updates/v1_72
https://code.visualstudio.com/updates/v1_73
Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[x] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[x] Tested basic functionality of all binary files (usually in ./result/bin/)
23.05 Release Notes (or backporting 22.11 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module
[ ] (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes

[x] Fits CONTRIBUTING.md.

Result of nixpkgs-review pr 205038 run on x86_64-linux 1

5 packages built:

vscode
vscode-fhs
vscode-with-extensions
vscodium
vscodium-fhs

Result of nixpkgs-review pr 205038 run on x86_64-linux 1

5 packages built:

vscode
vscode-fhs
vscode-with-extensions
vscodium
vscodium-fhs

This is superseded by https://github.com/NixOS/nixpkgs/pull/205034?

No, vscode and vscodium are 2 different packages. Both PR are needed.


ElectronNET.API.Entities.WebPreferences.ContextIsolation [DefaultValue(true)]

I tested using Electron.net API and CLI 8.31.2
ElectronJS lists the WebPreferences.ContextIsolation default value as false ([https://www.electronjs.org/docs/api/browser-window]).
ElectronNet API decorates the WebPreferences.ContextIsolation property with [DefaultValue(true)] which results in not setting this value in WindowManager.CreateWindowAsync when serializing "options" to a Json object.
This is my ElectronBootstrap code:
BrowserWindowOptions options = new BrowserWindowOptions() {
                Kiosk = true,
                AutoHideMenuBar = true,
                TitleBarStyle = TitleBarStyle.hidden,
                WebPreferences = new WebPreferences {
                    NodeIntegration = false,
                    ContextIsolation = true, // protect against prototype pollution
                    Preload = System.IO.Path.Join(AppDomain.CurrentDomain.BaseDirectory, "preload.js")
                }
            };

doing so, results in this error in the browser:

init.ts:207 Error: contextBridge API can only be used when contextIsolation is enabled
at checkContextIsolationEnabled (context-bridge.ts:7)
at Object.exposeInMainWorld (context-bridge.ts:12)

When I remove the [DefaultValue(true)] decorator of the ContextIsolation property in the ElectronNet.Api, it seems to work as expected.

Fixed with the Electron.NET 8.31.3


Unable to install on v11

I'm having the same issue. I love this module, so I'm hoping it gets upgraded to v11. I also hope there's a migration that doesn't require More Hooks, which I think isn't v11 compatible. I really love having fumble and crit tables that don't trigger for non-combat rolls. Having a fumble rolls for everything with Dice So Nice is super annoying, and this module is such a savior.

I'm not actually sure why that's not working. The module has been v11 compatible for quite a while and no longer uses More Hooks. I'd see if uninstalling the module and reinstalling it helps.

(Thanks for the quick response BTW) Yeah, it's super weird. It runs great in v10 in the Forge, but I can't install it in the Electron desktop app for v11. I get the same error:

I wonder why it's trying to install 0.5.1 instead of 0.5.2.
What you could do is uninstall it and reinstall using the following link
https://github.com/NekroDarkmoon/optional-rules-dnd5e/releases/download/0.5.2/module.json

The direct link worked! And you're right. It works without More Hooks. I just thought it would also need it for v11 because the documentation says "Critical Hit and Fumble --> More Hooks 5e." So I'm super happy that it doesn't need it. (Happy dance)


Account for rgb and rgba colors in quad swap

Hey @jbalsas
I noticed that rgba colors are getting improperly swapped if they have spaces inside the parentheses. So...
rgba(4, 4, 4, 0.15) would be converted to rgba(0, 0.15) 0, 0,
This pull just updates the regex in charge of splitting the string so that it only matches white space characters that aren't inside of parentheses.

Hey @Robert-Frampton we had actually observed this, just never got time to work on it, so thanks a lot!
I've already merged it and published<EMAIL_ADDRESS>


Is there a way to get custom hitsounds?

I want to get a hitsound, but don't know how to add it to the game.

Sorry it's not supported. I think this fork has custom hitsounds added.

Oh alright, thank you.

Wait, how do I get into the game on BlaNKtext's version?

Wait, how do I get into the game on BlaNKtext's version?

The same as 111116 ver.


[Function Expose] Codeunit 5847 - Get Average Cost Calc Overview

We need function "Calculate" available as global/external

Hi @InnovaACAdmin, we’ve decided to go ahead with your request. We usually include these types of changes in the next minor release, so look for it there.


Support Mobile?

Does this library support mobile devices, such as Android and iPhone?

Yes it does! I've used to without any issues on a match-3 mobile game.


Windows icon export improvements.

Regenerate Windows icon on export to ensure correct icon size order.
Add support for using PNG/WebP/SVG files as an icon for Windows exports.
Allow using WebP/SVG files as icon for macOS exports.
Add option to select generated icons interpolation, and set default interpolation to Lanczos.

Fixes #64073
Now icons won't be blurry regardless of size order in the icon, exporter will reorder it, remove unnecessary sizes and warn is some are missing.
It's also possible to auto generate icon from any Image (also added WebP / SVG for macOS exported, since it should be able to generate icon from any Image as well).
Note: Order of the sizes in the default icon used by the export template must always match order in the static const uint8_t icon_size[] array, if the default icon is updated (e.g., reverted to compressed version), this array should be updated as well.

This could be worth backporting to 3.6 (and maybe 3.5.2) as the blurry icon issue is a regression in 3.5.

Thanks!


Response withStatus not working

Am trying to send a response as follows in a REST API and based on Slim documentation:
$response->getBody()->write(json_encode(["Error" => "HTTP STATUS 403 - FORBIDDEN!"]));
return $response->withHeader('Content-Type', 'application/json')->withStatus(403);
Using Postman and Chrome browser to test the API, I always get the correct response body in JSON, but the status code is always 200 instead of the intended 403.
Have looked through previous open and closed issues, but found nothing which would help me.
Any help with this would therefore be much appreciated!
Using Slim v4 and PHP 7.4 on an Apache2 server.

This must have to do with your apache configuration or something else.
Would you be able to provide an example repository with minimal code to reproduce?

Pierre, thanks for your swift reply. The server is a Digital Ocean Droplet using Ubuntu 18.something from memory and I haven't added any custom configuration, other than the fact that I'm using basic auth for authorisation, but that should not impact my responses and apart from the status codes not working, the API functions flawlessly otherwise.
Will see whether I can provide a skeleton repo so you can try and reproduce the error.

Ok,  I just tried exactly the above code in an other Slim PHP v4 REST API which I am running on my local machine and alas the status code works fine here.
Curious.  Will investigate my DO Droplet config and see what may be causing this issue.
Could it maybe be CORS related?
Will get back if/when I have figured-out the issue.
In the meantime, please feel free to close the issue, as it doesn't look to be directly related to Slim PHP.

Problem seems related to my before middleware. Will have to go over this again. In the meantime, I will close the issue, as It's unrelated to Slim PHP.


Slight improvement to pubspec version comments

In the pubspec file, the following comment is automatically generated:
# The following defines the version and build number for your application.
# A version number is three numbers separated by dots, like 1.2.43
# followed by an optional build number separated by a +.
# Both the version and the builder number may be overridden in flutter
# build by specifying --build-name and --build-number, respectively.
# In Android, build-name is used as versionName while build-number used as versionCode.
# Read more about Android versioning at https://developer.android.com/studio/publish/versioning
# In iOS, build-name is used as CFBundleShortVersionString while build-number used as CFBundleVersion.
# Read more about iOS versioning at
# https://developer.apple.com/library/archive/documentation/General/Reference/InfoPlistKeyReference/Articles/CoreFoundationKeys.html
version: 1.0.0+1

Some terminology in the explanation is difficult to track.
Twice near the beginning of the comment, the terms "version" and "build number" are mentioned twice.
Later it is stated that "In Android, build-name is used as versionName while build-number used as versionCode".
This then begs the question as to whether the Flutter pubspec "version" has any relation to how the Android version is determined.
To answer that question, one must take "build-name" and realize that it corresponds to the aforementioned "--build-name" flag, and then the reader needs to further recognize that the "--build-name" flag corresponds to the aforementioned term "version". Then you need to repeat this logical chaining to go from "versionCode" to "build-number" to "--build-number" to "build number".
Considering the criticality of correctly marking the version information for a packaged app, it might be a good idea to find a more concise and unambiguous explanation for the "version" property in the pubspec.
One idea would be to include a shorter explanation, but then show a literal Android example and a literal iOS example within the comment for the purpose of illustrating the "version" property applied in practice. That might suffice for a complete understanding.

CC @InMatrix

Does the tooling write the templates for the Flutter pubspec?


Detect message type within message handler

Is there any way to detect message type within message handler?
As I'm using a universal message handler (see #367), https://pkg.go.dev/github.com/tucnak/telebot#Message alone seems unable to tell me that. And I'd hope to avoid writing individual message handler for each message type, if possible.

I was thinking about general OnMessagecallback, PRs are welcome here.

a general OnMessagecallback

Yeah, that's a better idea!
Can we have it in V3, if not in V2 pls!

PRs are welcome here

Looking at the fate of previous PRs, @demget, I doubt that mine would be accepted. E.g., what's happening to
https://github.com/tucnak/telebot/pull/335
that's seems to be a pretty good one to me.

Since 10b70148f75fd3383850bc9c2aad3fcd777ed3f1 you can do:
func main() {
  // ...
  b.Handle(tele.OnText, forwardMessage)
  b.Handle(tele.OnMedia, forwardMessage)
  // ...
)

func forwardMessage(c tele.Context) error {
  return c.ForwardTo(r)
}


office-addin-dev-settings: register command should write full path

On Windows, if the register command is called with a relative path or just a file name,
the full path should be written into the registry.

@TCourtneyOwen Please review.

Please address test failure in CI loop

There was a timeout in one test case. I don't see why it should have taken more than 2 seconds. I'm retrying it.

@TCourtneyOwen Tests passed on retry.


Can't get SAML working with GSuites

Hi,
I am trying to enable SAML auth in my Kubernetes Opendistro Cluster deployed with helm chart from this repository.
I have mounted the idp metadata file by editing the chart (It's not supported yet)
kibana.yml
opendistro_security.auth.type: "saml"
server.xsrf.whitelist: ["/_opendistro/_security/saml/acs", "/_opendistro/_security/saml/logout"]

security-config.yml
    authc:
      basic_internal_auth_domain:
        enabled: true
        order: 0
        http_authenticator:
          type: basic
          challenge: false
        authentication_backend:
          type: internal
      saml_auth_domain:
        http_enabled: true
        transport_enabled: false
        order: 1
        http_authenticator:
          type: saml
          challenge: true
          config:
            idp:
              metadata_file: idp-metadata.xml
              entity_id: https://accounts.google.com/o/saml2?idpid=xxxxxxxxx
            sp:
              entity_id: kibana-saml
            kibana_url: https://kibana.company.com/
            subject_key: nameid:persistent
            roles_key: groups
            exchange_key: 'yQffFcJtJf..........Jgx75GR7CN4'
        authentication_backend:
          type: noop

Can't get it working.
I have googled issues and tried different variations of config.
According the helm chart, the security config is mounted only to the master node, I have enabled it also on the client node because Kibana is communicating with it.
I am not getting any error in logs, just:
SAML configuration error
Something went wrong while retrieving the SAML configuration, please check your settings.
in Kibana UI.
It doesn't redirect to the IDP, just getting back to see this error
Please suggest is it possible to get working?

I am finally got it working. The main issues I have resolved is posted below. Hope it will help someone.

enabled option is not valid for basic_internal_auth_domain, it should be changed to http_enabled
My security configuration was not applied by just updating the helm chart. To get it to work I had to update the security index, by running securityadmin.sh tool, or by recreating the cluster from scratch.
It's not necessary to keep the id metadata file on the client node, the master config is enough.
It is possible to work around the inability to provide metadata file as a mount point. I have deployed an internal nginx that serves the idp metadata file. And defining the url in config like that

 metadata_url: http://<nginx-service-name>/idp-metadata.xml

@AlexShuraits how did you get the exchange_key?

@AlexShuraits Have you got to know how to get  exchange_key ?

You have to create it.
pwgen -n 32


"type": "module" in package.json causing issues (import-related)

I'm not sure this isn't an error on our end, but i thought it'd be worth mentioning it here. We used react-simple-tree-menu in a Next.js project and were getting an error like this on page refresh:
Error: Must use import to load ES Module: /myProject/node_modules/react-simple-tree-menu/dist/main.cjs.js
require() of ES modules is not supported.
require() of /myProject/node_modules/react-simple-tree-menu/dist/main.cjs.js from /myProject/.next/server/static/development/pages/organisations.js is an ES module file as it is a .js file whose nearest parent package.json contains "type": "module" which defines all .js files in that package scope as ES modules.
Instead rename main.cjs.js to end in .cjs, change the requiring code to use import(), or remove "type": "module" from /myProject/node_modules/react-simple-tree-menu/package.json.
So we went ahead and removed that line and it seems to have fixed the issue for now, seemingly without ill effects.

Thanks for reporting.
However I cannot reproduce this issue. Please see this blank nextjs project.
I'll close this issue for now. If you find the root cause that should be fixed in react-simple-tree-menu, feel free to re-open this issue 🙂.

We have reproduced the same issue and are using the same version of next.js and react-simple-tree-menu as your example project.

This has been fixed and released as v1.1.17


Add http proxy

@MartinHjelmare I accidentally closed the other PR about http proxy, please continue with this PR instead.


Introduce the hand tool in macromolecules mode

Background
Canvas navigation in macromolecules mode is significantly less user-friendly than it is in molecules mode. This ticket is one of the tickets aiming to address that issue.
Requirements

The "Hand tool" should be able to be chosen from the top of the left sidebar (same placement as in micromolecules mode).

The hand tool should look the same in both modes:

 (in the sidebar)
 (hover over)
 (selected)
 (on canvas, not dragging)
 (on canvas, dragging)

The same shortcut should be used (Ctrl+Alt+H)*, and the shortcut should be visible on hover in the sidebar.

.* For MacOS users, instead of Alt Option is used, and instead of Ctrl Command is used.

When selected, the hand tool disables any interaction with the elements on screen.

Even when the hand tool is over a monomer (for example), the monomer will not be highlighted in any way.
Clicking with the hand tool does not allow selection of any elements on the canvas.

The functionality of the hand tool is the same in both modes:

AC3: GIVEN Ketcher user working with the canvas content with scrolls presented with Hand tool enabled WHEN clicking on the left mouse button over the canvas AND moving the mouse THEN Ketcher canvas content should be moved like the canvas was dragged by the hand to the direction of the mouse move AND canvas content should be presented as if scrolls were moved AND scrolls position should be updated and scrolls should hide if the move has resulted in displaying all canvas content in the window
AC4: GIVEN Ketcher user working with the canvas content without scrolls presented with Hand tool enabled WHEN clicking on the left mouse button over the canvas AND moving the mouse THEN Ketcher canvas content should be moved like the canvas was dragged by the hand to the direction of the mouse move AND srolls may appear if the move results in hiding part of the canvas content
The explanation from the ticket introducing the hand tool in molecules mode #1306

Tested

Desktop:

OS: Windows 11
Browser Chrome
Version 128.0.6613.120 (Official Build) (64-bit)

Ketcher version
[Version 2.27.0-rc.1]
Indigo version
[Version 1.26.0-rc.1]


Fix doc generation for the root configuration

Partial fix for #666 (the number of the beast)

Does it also check:

that the given arguments are correct?
that we don't have extra attribute at the root level?

I've made the descrition of throwErrorOnExtraParameters more accurate.