VerifyMessageECv2 return false

Dear
please I need help, I have issue in test file SignatureVerificationTest.cs
I have this payload token and we tried it with our merchant ID
but it returns false
please can you help where is issue in my method
this is the method
[Fact]
        public void TestVerifyMessageECv2New()
        {
            var keyProvider = new GoogleKeyProvider(true);

            var payload = new PaymentData()
            {
                Signature = "MEQCIHO0tKvzdtAlW97QodVUHFiAyYLwUkeflDxDjQEbaNNAAiBl4POFTtAAMVBJLfUlkoljhUJpLg2qk2MTfG2O5EARAg\u003d\u003d",
                IntermediateSigningKey = new SigningKey()
                {
                    SignedKey = "{\"keyValue\":\"MFkwEwYHKoZIzj0CAQYIKoZIzj0DAQcDQgAE5Wq0wHGCfnmRs4I+biemX8PxXWXszbkYbk+VOK7p3vp5b7TvXun5AFu1IVwKlEke2Lie4xyCpfdjuNsrOnLNUw\\u003d\\u003d\",\"keyExpiration\":\"1674781891312\"}",
                    Signatures = new string[] { "MEQCIDwVjfQwdtH0hglpOS8G56+/Zn+zvqEWyFtMMMr+i9hDAiAKoHTNM8tiWxQBTJGHXSw983lGPLmfKUUmvkaYWGAAFg\u003d\u003d" }
                },
                ProtocolVersion = "ECv2",
                SignedMessage = "{\"encryptedMessage\":\"WcNkDyuJzpbQJTOJFlHVoeghSCyjWupqAOjcWNZVWH7xOt5Guj5S2yA3jndChQq3oTWYmqAvrIMWT/GJ+0ql7aejJOIEKBUuRJEBPlgI5De9mHlt4MagmrKoNHbSlidQM56g4mHpxwMgPrbpyzRxFzdhu+l0psHJRkJsrx//LYId53KD7YRY/zunIQvBd6AOgSTrZ148oAB1nPL26PEJaiAcGmsnOP0IACFx51ciNkvDIUuog7g+bVH6x7qAdX2v0WFbfA+KSGH4besDOXxNyUkvlboq7eoUks1t6D7d3pBJvntvKvLWBZVslccoFmyLvbtFObAuCIY3DYLxOYTMqp4FAuZXGd/FaBPAQwHVV3cTQhzIA1V7+zLuvpzAjNATPgOpIgHSLb7EsC7mIGyWibdU0Sa0R124V/Yj2hDMKUdzdXyQniltdTRpcJsn/YfhtHmZ+ogQK4/5xvoDwTiLbdurvPl3zHSF187zqhnYxEqE5WQKaxNDboswE8qEVqrP989M8i/Q4+WctzPmQt5TvDccESMKkrdEQDWsfbA7vAhU3eR3lhj3X+W4c0zrQykJCzB12gI56dFp\",\"ephemeralPublicKey\":\"BHt4yaMDJ3zOj95ZF3pNrxXKSeoG0Bp6azeot8sOwFkUuYtLyMBH1SuUkwmI7d8OLxbEIJyngEkuL31rb1G4J3s\\u003d\",\"tag\":\"cyF1Hgvx+HKoCIWYK7UcF6ssuRxneJM7NfKS2XQk/2k\\u003d\"}",
            };
            var signatureVerification = new SignatureVerification();
            Assert.True(signatureVerification.VerifyMessage(payload, "Google", "merchant:1234", keyProvider));
        }

it only fails in this check but if I comment it, decryption is works and I can see the result

please advise me where is the issue in this part I tried to follow the code with no result

issue now is in this part
ECPublicKeyParameters signingKey = KeyParser.ParsePublicKeyDer(signedKey.KeyValue);
            return VerifySignature(signingKey, signedString, signature);

in method VerifyMessageECv2 in class SignatureVerification.cs

Hello, where you able to resolve this i am having the same bug

Hey, were you guys able to reslove this issue?

Hey, were you guys able to reslove this issue?

Yes

What is error message you got

@olufemitomilola004
When I set the IsTest parametr to true, VerifyMessage simply returns false exactly as this issue descibe. When I set IsTest to false, I'm getting No valid signing keys found in payload.

@olufemitomilola004 When I set the IsTest parametr to true, VerifyMessage simply returns false exactly as this issue descibe. When I set IsTest to false, I'm getting No valid signing keys found in payload.

Then kindly confirm with Google to know if your payload is still valid because they do expire after 5days I guess. Also be certain that you are inputting the right gatewayId

@olufemitomilola004  How did you fix your issue https://github.com/google-pay/payment-data-cryptography-dotnet/issues/16 ?


Slow graph_from_dot_data

I've installed pydot 1.4.1 from pip. I have a small code snippet
timer = timeit.default_timer
start = timer()
graphs = pydot.graph_from_dot_data(task_tree)
end = timer()
print(end - start)

that prints 1.875810980796814 (seconds) on a pretty small data (see attachment
task_tree.txt
). It's pretty huge time.

There is a 3 to 4% reduction for this example with pydot/pydot#242, commit pydot/pydot@b6758685. Not much, but that is probably because most time is spent parsing. I did not look at that yet.


error "Notebook does not appear to be JSON...."

Describe the bug
When loading a jupyter notebook, this error occurs:
Unreadable Notebook: /path/FILENAME.ipynb NotJSONError("Notebook does not appear to be JSON: ''...",)
To Reproduce
Steps to reproduce the behavior:

Go to the repo
set up env
run jupyter notebook
open notebook
See error

Expected behavior
Jupyter notebook runs notebook
Screenshots
If applicable, add screenshots to help explain your problem.

Desktop (please complete the following information):
Edge Browser
Additional context
Add any other context about the problem here.

Update: the "fix" is to copy the file to xxx.json, edit with vscode, note malformed json, fix malformed json, then copy back to original ipynb file.  The issue is that a tool apparently caused the malformed json.

Update: lines that are extremely long, are not malformed but cause a failure. The fix is to break long lines into several smaller lines.

Closing as it is currently fixed, but may occur in the future.


We aren't testing all of islandora's submodules

We're only running tests for breadcrumbs.  We need to run them for all the derivative submodules as well.  I bumped into this making a test for islandora_video and turns out they're failing (at least for that submodule), so there'll have to be some cleanup on those tests too once we turn them on.

Resolved with https://github.com/Islandora/islandora/commit/20477e814af6dcb6da78f3cd986b0132f1735ad2


cwlVersion: v1.0 is good enough

Inspiration https://github.com/luispedro/ngless/pull/27/files#diff-aec88ba47a6ee3832737a29ab7988e02R6

@anton-khodak Why did you merge when the tests failed?

@mr-c You are right, I should have updated tests before merging


"Ciurila", "Filea de Jos", "Filea de Sus", "Pădureni", "Pruniș", "Sălicea", "Săliște", "Șutu" are listed in the drop-down

Description:
When user writes "Ciurila", "Filea de Jos", "Filea de Sus", "Pădureni", "Pruniș", "Sălicea", "Săliște" and "Șutu" the locations appear in the drop-down menu next to the comune and the county which is a part according to the law
Precondition:
The website is up an running.

Step 1
Write in the search bar "Ciurila"
Expected results
The location appears in the drop-down menu as "Sat Ciurila, CLUJ (Ciurila)"

Step 2
Press "x" button.
Expected results
The location was deleted from the search bar.

Step 6
Write in the search bar "Filea de Sus"
Expected results
The location appears in the drop-down menu as "Sat Filea de Sus, CLUJ (Ciurila)"

Step 9
Write in the search bar "Pruniș"
Expected results
The location appears in the drop-down menu as "Sat Pruniș, CLUJ (Ciurila)"

Step 10
Press "x" button.
Expected results
The location was deleted from the search bar.

Step 15
Write in the search bar "Șutu"
Expected results
The location appears in the drop-down menu as "Sat Șutu, CLUJ (Ciurila)"


#184752248 Profile Page Settings

What does this PR do?
Enables a user to edit his/her profile only.


Angular: Could not find a declaration file for module 'name-spell-checker'

I am working with Angular 12.  I added the package as folows:
npm --save-dev install name-spell-checker nspell
I added a class as follows:
ng g class katas/wonderland-doublets/Doublets
I changed the class as follows:
import { NameSpellChecker } from 'name-spell-checker';
//
export class Doublets {
    spellChecker = new NameSpellChecker( );
}

Error message with 'name-spell-checker' highlighed in the import statement:
Could not find a declaration file for module 'name-spell-checker'. 'c:/Dat/Nsg/L/Web/Ng/katas/node_modules/name-spell-checker/dist/index.js' implicitly has an 'any' type.
  Try `npm i --save-dev @types/name-spell-checker` if it exists or add a new declaration (.d.ts) file containing `declare module 'name-spell-checker';`ts(7016)

I tried the suggestion in the message but no change.

Thank you. I fix this in v0.0.3. 4638592cfc073b5f958819abe4439239326d529c


Required parameter passes schema validation, but fails at runtime

Hi, I've found some unexpected behaviour when using this library. This example illustrates the problem:
package main

import (
	"log"
	"net/http"

	graphql "github.com/graph-gophers/graphql-go"
	"github.com/graph-gophers/graphql-go/relay"
)

type query struct{}

func (_ *query) Hello(args struct{ ID *graphql.ID }) string { return "Hello, world!" }

func main() {
	s := `
                type Query {
                        hello(id: ID!): String!
                }
        `
	schema := graphql.MustParseSchema(s, &query{})
	http.Handle("/query", &relay.Handler{Schema: schema})
	log.Fatal(http.ListenAndServe(":8080", nil))
}

Note that ID! in the schema means that the parameter is required, but in the resolver args it is a pointer.
Running this query against the server:
body='{
	"operationName": "Test",
	"query": "query Test {\n  hello(id: \"abc\")\n }\n",
	"variables": {}
}'

curl localhost:8080/query -d "$body"

we get an error in the response:
{"errors":[{"message":"could not unmarshal \"abc\" (string) into *graphql.ID: incompatible type"}],"data":{}}

I would expect the error to be when parsing the schema, not when making the request.

@fenech thank you for reporting this issue. I agree with you that this should happen at schema parsing time and not during query validation. PRs are welcome.


Migrate Lambda transformation runtime

Description
Part of https://coralogix.atlassian.net/browse/ES-123
Reflects the changes needed for migrating the runtime (for details see https://aws.amazon.com/blogs/compute/migrating-aws-lambda-functions-from-the-go1-x-runtime-to-the-custom-runtime-on-amazon-linux-2/).
This also has been reflected already in the transformation Lambda, see related change: https://github.com/coralogix/cloudwatch-metric-streams-lambda-transformation/pull/32
How Has This Been Tested?
N/A
Checklist:

[X] I have updated the relevant example in the examples directory for the module.
[ ] I have updated the relevant test file for the module.
[ ] This change does not affect module (e.g. it's readme file change)

@ryantanjunming When you get a chance please, I'd like this to get reviewed by CDO as well, thank you 🙇

@ryantanjunming When you get a chance please, I'd like this to get reviewed by CDO as well, thank you 🙇

okay

same issue in cloudformation also

I pushed another commit to fix (define architecture for Lambda), doing the same for CloudFormation


ci: Add GitHub action to upload S3 website configuration

Add a GitHub action to upload the S3 website configuration from a JSON file in this repo.
With that PR it's possible to maintain the redirections directly from this repo by making pull requests to

_website-config-docs-stage.json for https://docs-stage.docker.com
_website-config-docs.json for https://docs.docker.com

An example for the docs-stage.docker.com site with a redirect of all v17.03/ to /
Important keys are

KeyPrefixEquals is set to v17.03/
ReplaceKeyPrefixWith is set to empty string "" which means /
HostName and Protocol must be set for each redirect rule, otherwise AWS redirects to the internal name. That's why we need two different JSON files.

  {
   "Condition": {
    "HttpErrorCodeReturnedEquals": null,
    "KeyPrefixEquals": "v17.03/"
   },
   "Redirect": {
    "HostName": "docs-stage.docker.com",
    "HttpRedirectCode": null,
    "Protocol": "https",
    "ReplaceKeyPrefixWith": "",
    "ReplaceKeyWith": null
   }
  },

A temporary build that also ran in this PR branch was green: https://github.com/docker/docker.github.io/pull/10612/checks?check_run_id=573354449 and it successfully uploaded the website config for docs-stage.

Ping @thaJeztah this is the replacement for the nginx redirect rules we had in the past. Now a similar config for S3 website is back in the repo to maintain it through PRs.

Thanks! I just recalled we also need to take redirect_from entries in the /ee and /datacenter into account before we remove the content; here's a quick 'n dirty way to get which pages have redirects from outside of /(ee|datacenter|compliance);
echo "{" > extra-redirects.json
grep -E ': "/(compliance|datacenter|ee)/' <(curl -fsSL https://docs.docker.com/redirects.json | jq .) >> extra-redirects.json
echo '  "/dummy/": "/"' >> extra-redirects.json
echo "}" >> extra-redirects.json

extra-redirects.json.txt

For those pages, I think we'd need dummy pages in /ee, /datacenter and /compliance

This PR only adds automation to  the current status. I've uploaded the website configs manually with a similar Go tool, there's no aws cli command for that.
For the three EE related folders I plan to do this in a new PR after the merge. We can simply remove the three folders and add three redirection rules to the new website*.json files. We will test this PR in docs-stage to see if everything gets a new URL prefix with the target domain name.

We can simply remove the three folders and add three redirection rules to the new

Right, so that's the tricky bit; there's redirects that are currently in place that redirect to the /ee or /datacenter directory, but due to how Jekyll constructs redirects, those redirects are configured in the target page.
For example, https://docs.docker.com/reference/ucp/3.0/cli/support/ redirects to https://docs.docker.com/datacenter/ucp/3.0/reference/cli/support/
That redirect is defined in https://github.com/docker/docker.github.io/blame/663ea14a3ca321d8f4a257d3b5ca8648ba5aec2d/datacenter/ucp/3.0/reference/cli/support.md#L6
Which means that once that page is removed, the redirect is no longer in place. So for pages that define a redirect, we should either replace them with a "dummy" page that only has the redirect_from page set (so that Jekyll generates the redirect page), or commit the generated redirect HTML's to git

Updated, with redirect "from" /ee/ and /datacenter/ removed
extra-redirects.json.txt

I don't know how much effort we want to put into the forwarding to Mirantis. Do we have an "SLA" of how many of the old links should work/redirect to them? 😅


Comments widget obscures horizontal scrollbar in diff editor

Open a PR with comments
Scroll to a comment such that a comment widget renders close to the top of the terminal panel
:bug: can't grab the horizontal scrollbar
https://user-images.githubusercontent.com/30305945/215854561-b88688c5-d6b0-4fa6-a11a-15ed18c794fc.mp4

This is particularly annoying if you have multiple comments that are relatively close to each other vertically, such that the horizontal scrollbar is obscured most of the time in the diff editor

This occurs in a non-diff editor too and in other peek views (like the problem peek view).


[qt5-base] no absolute paths

For #20469

@Neumann-A Are you OK with this?

@Neumann-A Are you OK with this?

yeah but I don't guarantee that the pc files will be useable with that. Especially for static builds the pc files might be wrong or missing stuff.

also there are probably still absolute paths to the winsdk in the qt files.

yeah but I don't guarantee that the pc files will be useable with that. Especially for static builds the pc files might be wrong or missing stuff.

Do you think it's worth a shot anyway?

also there are probably still absolute paths to the winsdk in the qt files.

Probably :(

Do you think it's worth a shot anyway?

You can try but I there is currently nothing testing qt pc files. qmake uses the prl stuff and cmake uses the cmake configs. Only meson/autotools would possibly use pc files for qt.

You can try but I there is currently nothing testing qt pc files. qmake uses the prl stuff and cmake uses the cmake configs. Only meson/autotools would possibly use pc files for qt.

I assume the https://github.com/microsoft/vcpkg/issues/14225 issue still stands, so they will most likely be unusable anyway.

I assume the #14225 issue still stands, so they will remain unusable anyway.

unless you use a single configuration triplet on osx?

unless you use a single configuration triplet on osx?

Well, the only Qt .pc files being installed are those with _debug suffix; there aren't any release copies of them.

Well, the only Qt .pc files being installed are those with _debug suffix; there aren't any release copies of them.

filelist for osx disagrees lib/pkgconfig has qt stuff.

EDIT: also, is this specific to macOS only?

windows: no pkgconfig files
linux: normal pkgconfig installation no _debug suffixes.
qt6 doesn't seem to install pkgconfig files at all

Well, the only Qt .pc files being installed are those with _debug suffix; there aren't any release copies of them.

filelist for osx disagrees lib/pkgconfig has qt stuff.

That's what I have here:
Qt5Concurrent_debug.pc
Qt5Core_debug.pc
Qt5DBus_debug.pc
Qt5Designer_debug.pc
Qt5Gui_debug.pc
Qt5Help_debug.pc
Qt5MacExtras_debug.pc
Qt5Network_debug.pc
Qt5OpenGLExtensions_debug.pc
Qt5OpenGL_debug.pc
Qt5PrintSupport_debug.pc
Qt5QmlModels_debug.pc
Qt5QmlWorkerScript_debug.pc
Qt5Qml_debug.pc
Qt5QuickTest_debug.pc
Qt5QuickWidgets_debug.pc
Qt5Quick_debug.pc
Qt5Sql_debug.pc
Qt5Svg_debug.pc
Qt5Test_debug.pc
Qt5UiPlugin_debug.pc
Qt5UiTools_debug.pc
Qt5Widgets_debug.pc
Qt5XmlPatterns_debug.pc
Qt5Xml_debug.pc

@wrobelda: CI filelist here: https://dev.azure.com/vcpkg/public/_build/results?buildId=63427&view=artifacts&pathAsName=false&type=publishedArtifacts

@wrobelda: CI filelist here: https://dev.azure.com/vcpkg/public/_build/results?buildId=63427&view=artifacts&pathAsName=false&type=publishedArtifacts

Ah, my bad, was looking into /debug 🤦🏻♂
Yeah, so in this case, single configuration triplet would work, but that's still suboptimal. Not to mention the fact that Windows build doesn't install any .pc at all,  so enabling Qt in non-CMake ports would be platform-dependent.

I did this mainly so that https://github.com/microsoft/vcpkg-tool/pull/172 can be merged.  My intention was not to fix all pkgconfig issues of Qt

I did this mainly so that microsoft/vcpkg-tool#172 can be merged.  My intention was not to fix all pkgconfig issues of Qt

Yes, that's fair. We stole your thunder here a bit, our discussion belongs to #14225, sorry for that!

@Neumann-A @wrobelda I was mainly making sure that this wouldn't cause things to break horribly, not necessarily to make sure all pkgconfig ills of qt are fixed. :P From the feedback above this seems safe to merge.

@autoantwort Thanks for the fix!
@Neumann-A @wrobelda Thanks for the review feedback!


compiler: mmap per module, instead of per function

currently, the machine code is compiled and memory-mapped as executables per-function basis and that is the current bottleneck on compilation performance; The below is the CPU profiling of without extern cache benchmark and it indicates that 63.7/73.6% = ~80% of engine.CompileModule is spent on mmap (for a TinyGo binary).

It should be possible to memory-map per module, which should improve the compilation performance better (Actually that is what I am actually doing in the new backend).

unassigning as this doesn't have priority

hmm, I've done some POC, but maybe this won't help that much. seems like in any way this results in the same amount of allocations

Would it help reduce the compute footprint still? syscalls tend to be expensive operations, if we can do a single mmap per module it amortizes the cost of context switch back and forth between kernel user space?


[nngpp] version to v1.2.4

pull request to update the referenced version of ngpp to the latest tag.

 Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.:x: ggessner sign nowYou have signed the CLA already but the status is still pending? Let us recheck it.


Using this library with ROS2

I am not sure if this is a bug or just not supported.
But as the timestamp msg has changed from "sec" to "secs" I can only use the ROS1 bridge and not the ROS2 version -> ros2-web-bridge
Is this something known, or in the pipeline?

Hi @maxlein,
As far as I know, ROS# is not tested with ros2-web-bridge. If only problem is the naming of the message fields, then you can change the field names in the message classes manually on your local fork. For the timestamps in the header, Timer.cs is the corresponding script where you can see the "sec" field. You just need to make the necessary changes, then rebuild the library and replace the dll's on the plugins folder.
I hope that the difference in the naming convention is the only problem. Could you please right down your experiences regarding the use of ROS# with ros2-web-bridge? There is a plan to implement ROS2 support for ROS# soon, your experience could help us.

I only looked at some messages till now and they work with these small fixes:
diff --git a/Libraries/RosBridgeClient/BaseMessages/Std/msg/Duration.cs b/Libraries/RosBridgeClient/BaseMessages/Std/msg/Duration.cs
index e7851bb..0db29d5 100644
--- a/Libraries/RosBridgeClient/BaseMessages/Std/msg/Duration.cs
+++ b/Libraries/RosBridgeClient/BaseMessages/Std/msg/Duration.cs
@@ -19,19 +19,19 @@ namespace RosSharp.RosBridgeClient.MessageTypes.Std
 	{
         public const string RosMessageName = "std_msgs/Duration";

-        public uint secs { get; set; }
-        public uint nsecs { get; set; }
+        public uint sec { get; set; }
+        public uint nanosec { get; set; }

         public Duration()
         {
-            secs = 0;
-            nsecs = 0;
+            sec = 0;
+            nanosec = 0;
         }

-        public Duration(uint secs, uint nsecs)
+        public Duration(uint sec, uint nanosec)
         {
-        	this.secs = secs;
-        	this.nsecs = nsecs;
+        	this.sec = sec;
+        	this.nanosec = nanosec;
         }
 	}
 }
\ No newline at end of file
diff --git a/Libraries/RosBridgeClient/BaseMessages/Std/msg/Time.cs b/Libraries/RosBridgeClient/BaseMessages/Std/msg/Time.cs
index 5ae121c..525a476 100644
--- a/Libraries/RosBridgeClient/BaseMessages/Std/msg/Time.cs
+++ b/Libraries/RosBridgeClient/BaseMessages/Std/msg/Time.cs
@@ -18,19 +18,19 @@ namespace RosSharp.RosBridgeClient.MessageTypes.Std
     public class Time : Message
     {
         public const string RosMessageName = "std_msgs/Time";
-        public uint secs { get; set; }
-        public uint nsecs { get; set; }
+        public uint sec { get; set; }
+        public uint nanosec { get; set; }

         public Time()
         {
-            secs = 0;
-            nsecs = 0;
+            sec = 0;
+            nanosec = 0;
         }

-        public Time(uint secs, uint nsecs)
+        public Time(uint sec, uint nanosec)
         {
-            this.secs = secs;
-            this.nsecs = nsecs;
+            this.sec = sec;
+            this.nanosec = nanosec;
         }

     }

Hello!
My team and I are quite new to ROS and are just starting a project to connect it to Unity which is to be used as a simulator. Initially, our choice was to use ROS2 and make use of the fact that it provides some new functionality and will possibly be a bit more long-term solution. However, upon realising that ROS#, an important tool for connecting the two, does not fully support ROS 2, I am left puzzled on which version of ROS to use.
Knowing this, and taking our unfamiliarity with the tools into consideration, would you say that it is better to use ROS1 until ROS# fully supports ROS2 and is tested sufficiently, or to use ROS2 anyways and adapt it as @maxlein suggested?
Additionally, @maxlein, did you encounter any additional issues upon implementing this fix, or was that the only problem?
Any advice would be immensely appreciated! Thank you in advance!

No, I had no other issues. Works fine and the fix is easy to implement.
I may write a tutorial on ROS2 and Unity in the coming days.

Thank you for the update, really appreciate it!

No, I had no other issues. Works fine and the fix is easy to implement.
I may write a tutorial on ROS2 and Unity in the coming days.

Did you end up writing a guide on this subject? where can I find it?

Hi @maxlein,
As far as I know, ROS# is not tested with ros2-web-bridge. If only problem is the naming of the message fields, then you can change the field names in the message classes manually on your local fork. For the timestamps in the header, Timer.cs is the corresponding script where you can see the "sec" field. You just need to make the necessary changes, then rebuild the library and replace the dll's on the plugins folder.
I hope that the difference in the naming convention is the only problem. Could you please right down your experiences regarding the use of ROS# with ros2-web-bridge? There is a plan to implement ROS2 support for ROS# soon, your experience could help us.

Hello everyone,
Thanks for this library and the effort!
I just wanted to check in on the plans of implementing ROS2 support. Is this still planned in the near future, so that thechanges stated here are not required to be made whenever we use the library together with ROS2.
Thank you for an update on this topic.

Hi,
I have now compiled a version of the Visual Studio project that makes it ROS2 compatible. So far I have only looked at the communication itself, so changes to the RosBridgeClient.dll. The MessageGenerator.dll and the URDF.dll might already work for ROS2, but i have not checked that yet.
I have created a fork of this repository with a branch called ros2: https://github.com/Skoven/ros-sharp/tree/ros2
Here is both the edited C# code, but also updated RosSharp folder for placing in the Unity project Asset folder:
com.siemens.ros-sharp/Assets/RosSharp
The issues fixed where:

Fixing the timing labels. So going form secs to sec and nsecs to nanosec
Removed .seq from header as this is not a part of ROS2
Found that ROS2 puts "null" in unused parts of JointState msgs. The Json deserialiser of the ros-sharp library cannot handle this. I have just solved this by searching through the string an replacing "null" with 0.0

I hope that this will be of some help to poor souls like me, that struggle with getting ros-sharp to work with ROS2.

Hi,
I recently discovered this library and really like it so far, the documentation is great, and I've found it very easy to use so far!
However, I just noticed that actions are not supported for ros2. Are there any plans to make it up to date with the advances in rosbridge_suite, for action support in ros2 (see https://github.com/RobotWebTools/rosbridge_suite/pull/886)?
Thanks!
David

Hi @Dabuss,
Thank you for your interest. It's good to hear that you like it and find it easy to use. Yes, we are planning to add support for ROS2 actions. We didn't include it in the update because the way actions are handled has changed considerably from ROS1 to ROS2 and we want to take our time to implement it as properly as possible. I can't give you an estimated date for action support at the moment, but it's in our todo list.

Hi @memrecakal,
I've started working on it yesterday, and made good advances on a forked repo (action goal, feedback and result on the client side). I'm willing to contribute but I'd be happy to discuss this with someone, because I don't know how this can be done with my work constraints.
I just sent an email to<EMAIL_ADDRESS>to discuss about it. Are you also in the loop?
David

#460


Problem with resource which switching profiles

While switching to tabular profile it adds extra empty item into .resource.

Tabular profile, resource section have minItems: 1 attribute
https://www.dropbox.com/s/u6erorgryh2g20w/Скриншот 2015-07-17 09.19.01.png?dl=0
but datapackage have minItems: 0.
https://www.dropbox.com/s/1u7leomgddzfuej/Скриншот 2015-07-17 09.19.37.png?dl=0


Added support for Collections

Info
This Pull Request is related to issue no. #15
Guys, please take a look at my code and read it carefully. Honestly, I'm no happy with the duplication in each Validate() method (I mean all this strategy checks). If you have any idea how to make it better, please help :D All hates are very welcome in this particular ;)
Changes

Added CollectionValitRuleRule class
Added NestedObjectCollectionValitRule class
Added EnsureFor() method for primitive type collection
Added EnsureFor() method for nested object collection
Added missing null checks in each Validate() method
Added unit tests
Moved unit tests to dedicated catalogs

BTW, does anyone know why the hell this code is formatted so badly? It's very hard to read it...

Could you get your "Provider" out of pre-existing validator? Like having one next to each other and just pass a reference with adapter of sort into Ensure?
I don't get the point of this getter as well. Provider wants you to return IEnumerable of IValitRule while that getter asks you for single one. I don't get it. But I might be tired or something. ;)

@GooRiOn

BTW, does anyone know why the hell this code is formatted so badly? It's very hard to read it...

I think its because both spaces and tabs are being used.
#126 should fix this 😄

@tdeschryver I gave you write access, so u can now do the code reviews. If you could please verify my waiting PRs  :)


Migrating Pelican Website to Hugo

@antoniagaete can you please move everything under the website folder into the root of this repository? Also when I try to run hugo serve and try to access the site, it's just a blank page. How are you deploying this?

@antoniagaete can you please move everything under the website folder into the root of this repository? Also when I try to run hugo serve and try to access the site, it's just a blank page. How are you deploying this?

Since it's in development, I'm running it with hugo server -D. The -D will populate all of the pages because they are currently marked as drafts. I can go through and remove the draft: true if you would like (since it will get removed eventually I assume), so you can run it with hugo server.

@antoniagaete any reason why to set them as drafts? I don't see why we'd just go ahead and remove them.

Also, I'm still getting a blank page. I do see the following:
WARN 2023/04/06 11:28:28 found no layout file for "HTML" for kind "page": You should create a template file which matches Hugo Layouts Lookup Rules for this combination.

Am I missing something else?

Also, I'm still getting a blank page. I do see the following:
WARN 2023/04/06 11:28:28 found no layout file for "HTML" for kind "page": You should create a template file which matches Hugo Layouts Lookup Rules for this combination.

Am I missing something else?

Hm, I don't see why you would be getting a blank page, everything should already be setup so you should be able to just run it with hugo server -D. Are you connecting to localhost:1313?

@ramereth actually, I'm wondering if it might be an issue with the template being pulled as a submodule, which might not exist on your machine.

@antoniagaete that seems to be what's going on. .gitmodules is empty in the repo.

@antoniagaete getting the following error now:
Error: module "hugo-flex" not found; either add it as a Hugo Module or store it in "/home/lance/git/osl/website/themes".: module does not exist

@ramereth I believe I found/removed where hugo-flex was being referenced, it was the first theme I had chosen but switched to one more similar to OSU's theme. Let me know if it still doesn't work

I was finally able to view the site!

I've started fixing up the theme to look more OSU-like, and have most - if not all - of the website functionality working. All that's left is to add the rest of the content and finalize the theme.


Adding github whitelist

This PR is meant to add ConcurrencyPractitioner to the Jenkins whitelist so that this user can trigger tests.

@junrao So then we can merge this, right?


update ZemoMQ download location

Because http://download.zeromq.org/zeromq-4.1.4.tar.gz is not working anymore

Thanks


Provice Docker image within ECR or Github registry

In order to avoid this kind of error message when pulling your Docker image too many times within the CI

Server message: toomanyrequests: You have reached your pull rate limit. You may increase the limit by authenticating and upgrading

Can you please also push your docker image within https://gallery.ecr.aws or https://github.com/orgs/phrase/packages?ecosystem=docker ?

Hi @tetienne-zenchef, we're looking into it to also push the image to GitHub packages. Depending on your usage maybe using the CLI directly is also an option? https://github.com/phrase/phrase-cli It's a statically linked binary and should quite easily run in most environments


bin/brew: repair style

[x] Have you followed the guidelines in our Contributing document?
[x] Have you checked to ensure there aren't other open Pull Requests for the same change?
[ ] Have you added an explanation of what your changes do and why you'd like us to include them?
[ ] Have you written new tests for your changes? Here's an example.

[x] Have you successfully run brew typecheck with your changes locally?
[x] Have you successfully run brew tests with your changes locally?

repair bin/brew style for brew style with --enable=all
https://github.com/Homebrew/brew/blob/fa3af8d24d0335641e58a4355fa9de6d42ae4982/Library/Homebrew/style.rb#L188
related https://github.com/Homebrew/brew/issues/11086

Thanks again @hyuraku!


Allow cassette folders/nesting

Background
To better group and isolate cassettes, it would be useful to be able to organize them into nested folders.
Sample code
Am thinking along these lines:
describe Client do
  describe "get_foo" do
    it "should work" do
      HI8.use_cassette("get_foo/should_work") do
        // ...

Expected behavior
Should record to test_dir/cassettes/get_foo/should_work.yml.
Actual behavior
HI8 fails to write the cassette to the filesystem.

I agree.  I'll look into this and fix it up sometime this week.

This should work now.  If you want to give it a try and let me know if there are any problems

It works! Brilliant!


maintainers/scripts/update.nix for maintainers fails

Issue description
$ nix-shell maintainers/scripts/update.nix --argstr maintainer garbas --show-trace
error: while evaluating the attribute ‘shellHook’ of the derivation ‘nixpkgs-update-script’ at /media/OldRoot/home/jtojnar/projects/nixpkgs/pkgs/stdenv/generic/make-derivation.nix:85:11:
while evaluating anonymous function at /media/OldRoot/home/jtojnar/projects/nixpkgs/maintainers/scripts/update.nix:116:50, called from undefined position:
while evaluating the attribute ‘name’ at /media/OldRoot/home/jtojnar/projects/nixpkgs/pkgs/stdenv/generic/make-derivation.nix:85:11:
while evaluating the attribute ‘grsecurity_testing’ at /media/OldRoot/home/jtojnar/projects/nixpkgs/pkgs/os-specific/linux/kernel/patches.nix:54:3:
Upstream has ceased free support for grsecurity/PaX.

See https://grsecurity.net/passing_the_baton.php
and https://grsecurity.net/passing_the_baton_faq.php
for more information.

When trying to update a single package, it fails for a different reason: #28875
When I remove the grsec packages, it fails yet for another one: #28878
Technical details

System: NixOS 18.03.git.7913ba8
Nix version: 1.11.14
Nixpkgs version: 86e6e8016d0f9280167745c19d394311be0f9002
Sandboxing enabled: yes

Hi, I've removed grsec so at least that part of the problem should be resolved. I think these three issues should be consolidated into a single issue.

Closing since I cannot reproduce the issue even with adding  broken kernel module.


Problem with NLP

tokenizer_name is not defined in tokenize.
AttributeError                          Traceback (most recent call last)
 in ()
----> 1 tokenizedX = nlp.tokenize(cleanX.values)
/usr/local/lib/python3.6/dist-packages/GML/NLP.py in tokenize(self, text)
580     Return: Tokenized
581     """
--> 582     tokenizer = AutoTokenizer.from_pretrained(self.tokenizer_name)
583     encoded = tokenizer.batch_encode_plus(
584       text,
AttributeError: 'AutoNLP' object has no attribute 'tokenizer_name'

Please make sure you called the set_params() function before tokenizing or modeling.
Just like in this notebook: https://github.com/Muhammad4hmed/GML/blob/master/DEMO/AutoTextClassification.ipynb

Closing this issue assuming it's solved. if not, feel free to reopen.


 After clicking "play", the following output appears in the console:

To Reproduce
Steps to reproduce the behavior:

Go to live.rgb.tum.de using Firefox
select a VoD (in my Case the ERA Zentralübung (ID 6278 or 6308), some other VoD work just fine
error will show in console, stream will not load (loading circle will spin for ever)

Expected behavior
The VoD should start playing, just like it does when using chromium.
Desktop (please complete the following information):

OS: GNU/Linux Ubuntu 21.04
Browser firefox
Version Mozilla Firefox 93.0

Thanks for looking into it! :smiley:

Thanks for reporting this @PSandro!
I noticed this as well, I probably need to tweak my encoding params a little more to cope with uncertain inputs (e.g. whatever zoom decides to throw at us)
I opened another issue at https://github.com/joschahenningsen/TUM-Live-Worker-v2/issues/3 to track any technical finds on this.


Make data source FirstNameNodes also mutable

A previous change to tag nodes for mutability didn't take account of connected data source nodes. This updates it.

✅ No public API change.


Permission request not triggered after adding peer

You can find code in "dev-bibash" branch
https://github.com/bibash28/beacon-ios-sdk/tree/dev-bibash

https://github.com/bibash28/beacon-ios-sdk/commit/a0713466275608c9c65b7e2a5b3239a70a4ac93f

I'm closing this issue since I received a message from the OP on Slack saying that the issue was no more and most probably it was caused by something in the OP's code.


Event hubs cluster should support passing parameters with “sku” and “location”

Per the example of rest apis spec, seems passing “parameters” with “sku” and “location” is supported by “Clusters_Put" API. However, after I also checked rest api, seems event hubs cluster actually doesn’t support passing parameters with “sku” and “location” as request body. So I am confused. If it doesn’t support to send request body, then I cannot specify “sku” and “location” while creating event hub cluster. So I suppose passing request body should be supported.

It seems the sample should use  a different name for SKU as below.
            "sku": {                 "name": "Dedicated",                 "capacity": 1             }

@serkantkaraca , and seems Clusters_Put doesn't support to pass parameters as request body.

@neil-yechenwei I don't understand what you mean by not supporting request body. Entire JSON object is the body and you provide those in the JSON object.

OK, just informed the API is being fixed right now. Sorry for misunderstanding.

@serkantkaraca , I think [parameters](https://github.com/Azure/azure-rest-api-specs/blob/91294a48037aab7aec079d96f9b91e3140033000/specification/eventhub/resource-manager/Microsoft.EventHub/preview/2018-01-01-preview/Clusters-preview.json#L194) (I called it request body) is missing in [Cluster_PUT](https://github.com/Azure/azure-rest-api-specs/blob/91294a48037aab7aec079d96f9b91e3140033000/specification/eventhub/resource-manager/Microsoft.EventHub/preview/2018-01-01-preview/Clusters-preview.json#L143), right? After checked latest code,  seems this bug still hasn't been fixed. Could you help to fix it asap since we're blocked now? Thanks.

Here is the PR for fix - https://github.com/Azure/azure-rest-api-specs/pull/9596

Seems the issue has been fixed. So closed it. THanks so much.


Executing which swiftlint exited with non-zero status.

This is the error when I encountered in Xcode 7.3.1

Please ensure swiftlint binary is installed on your PATH..!

Hey I'm having the same issue. How do I do this? I installed SwiftLint with HomeBrew...

Is your homebrew is placed on /usr/local..?
symlink should be placed on /usr/local/bin/swiftlint if you installed anywhere else.

Hey, found out that the version of swiftlint was an old one without the 'autocorrect' command. brew update and then brew upgrade swiftlint solved the issue. Thanks!


Add release note about pyscf on Windows

0b4558de79f5 drops the pyscf requirement on Windows because it fails to install there.  I pushed that to main hastily and accidentally, when I intended to make a pull request.  This follows that up with a release note, which we should also backport to the stable/0.8 branch because this change is included in the 0.8.1 release.

Before we merge this, I should add that Windows remains an unsupported platform.


Feature Request: ability to maintain multiple managers within one vault

Would love for there to be an ability to manage multiple campaigns within one vault. As far as I see it, so far you can only manage one campaign overall, as you cannot assign unique tags that only call the notes that belong to each campaign.

Hi @roleforgaming
I am working on the feature right now. The challenge I had was that every outline (Adventures, Sessions and Scenes) and every element (Player Characters, Non Player Characters, Factions, Locations, Events and Clues) must identify their campaign.
So far the most elegant way has been to require two tags. The first to identify outline and elements and the second one to identify the parent campaign.
The outline tags require the creation of an id and the specification of the id of the parent.

Campaigns: `rpgm/outline/campaign/{campaignId}
Adventures: rpgm/outline/adventure/{campaignId}/{adventureId}
Sessions: rpgm/outline/session/{adventureId}/{sessionId}
Scenes: rpgm/outline/scene/{sessionId}/{sceneId}

The elements require a specific tag to identify their types (but don't require an id):

Player characters: rpgm/element/character/pc
Non-player characters: rpgm/element/character/npc
Factions: rpgm/element/faction
Locations: rpgm/element/location
Event: rpgm/element/event
Clue: rpgm/element/clue

Every outline or element (excluding the campaign) MUST contain the tag rpgm/campaign/{campaignId}
I think there is a bit of added complexity, but I am considering placing the frontmeta templates in the code, so to be able to create it dynamically.
If you pull the dev branch you can look into it. Any feedback is more than welcome.
An example working with the updated version can be found here.

There is a bug in my logic in regards to the navigation... The navigators won't work at the moment and I will be looking for a solution.
TL;DR: with the current tag setup, I can't uniquely get the adventure from a scene.

The outline tags require the creation of an id and the specification of the id of the parent.

Campaigns: `rpgm/outline/campaign/{campaignId}
Adventures: rpgm/outline/adventure/{adventureId}
Sessions: rpgm/outline/session/{adventureId}/{sessionId}
Scenes: rpgm/outline/scene/{adventureId}/{sessionId}/{sceneId}

The elements require a specific tag to identify their types (but don't require an id):

Player characters: rpgm/element/character/pc
Non-player characters: rpgm/element/character/npc
Factions: rpgm/element/faction
Locations: rpgm/element/location
Event: rpgm/element/event
Clue: rpgm/element/clue

Every outline or element (excluding the campaign) MUST contain the tag rpgm/campaign/{campaignId}


chore(duplicates-cards): removed duplicate cards

Removed duplicate cards

@iamrahulmahato  I am resolved the conflict. Please merge the PR: )

@iamrahulmahato  Please go with the merge else we are going to have lots of conflict.
Thanks.

taking a long time.

Okay, I am doing it.

Hey @iamrahulmahato, can you please merge it? Since there are too many changes, we will get lots of conflict if you not merge it before any other pr.
Thank you.

Build is getting failed because there is one submodule but there is no reference for sub-modules. There might be some PR that got merged with sub-modules. Please check.

Please merge it . I removed all duplicate cards.

@iamrahulmahato
removed duplicate cards #1043

@iamrahulmahato
chore(duplicates-cards): removed duplicate cards #1043

@iamrahulmahato Please merge this PR.

mention the issue no, where i assigned you the task

This is the issue number: :#1043
chore(duplicates-cards): removed duplicate cards #1043

closing this issue its been 2 week please make a new pr


Run without Docker?

Hi, I am having trouble running Docker on Windows, would it be possible to provide instructions for using this code without Docker?
Thanks!

Hello, did you solve this problem?
Thanks

I also want to know the solution @RaduAlexandru

I am also waiting for any suggestions


Add chain stores in Brazil

I've prioritized adding banks, fast-food chains and supermarkets.

Thanks. Make sure columns where " appear are quoted at start and end with ", and each " appearing in it should be doubled "", for example :
blabla,"abc @ ""xyz"" + 123",blabla

You can use spreadsheet software like LibreOffice to help editing.

Fixed. Using a linter to check if the CSV helps a lot!

For sure :smile: thanks !


Add test cases to cover expected errorneous situations

And update Error text to be as relevant as possible.

duplicate of #30


New quantizer seems to ignore TFLITE_BUILTINS_INT8

1. System information

OS Platform and Distribution (e.g., Linux Ubuntu 16.04): Ubuntu 20.04
TensorFlow installation (pip package or built from source): pip
TensorFlow library (version, if pip package or github SHA, if built from source): 2.7.1 and 2.9.1

2. Code
The following script can be run directly to show the issue. A SavedModel is saved before the conversion and a TFLite file afterwards.
import tensorflow as tf
import numpy as np

def create_not_fully_quantizable_model():
    """Set up the model"""
    model = tf.keras.Sequential(
        [
            tf.keras.Input(shape=(5), batch_size=1),
            tf.keras.layers.Dense(5, input_shape=(1, 5)),
            tf.keras.layers.Dense(5),
            tf.keras.layers.Lambda(lambda x: tf.math.floormod(x, 3)),
        ]
    )

    return model

def dataset_generator(shape):
    """Set up the training data"""
    x_train = np.array(
        [
            [0.0, 1.0, 2.0, 3.0, 4.0],
            [2.0, 0.0, 2.0, 3.0, 4.0],
            [0.0, 3.0, 2.0, 3.0, 4.0],
            [4.0, 1.0, 2.0, 3.0, 4.0],
            [5.0, 1.0, 2.0, 3.0, 4.0],
        ],
        dtype="float32",
    )

    def generator():
        """Dataset generator for post-training calibration."""
        for x in x_train:
            yield [np.reshape([x], shape)]

    return generator

def main():
    filename = "test_partial_quant"

    model = create_not_fully_quantizable_model()
    model.save(filename)

    # Post-training conversion.
    converter = tf.lite.TFLiteConverter.from_keras_model(model)
    # converter.experimental_new_quantizer = False
    converter.optimizations = [tf.lite.Optimize.DEFAULT]
    converter.representative_dataset = dataset_generator(model.input_shape)
    converter.target_spec.supported_ops = [tf.lite.OpsSet.TFLITE_BUILTINS_INT8]
    converter.target_spec.supported_types = [tf.int8]
    converter.inference_input_type = tf.int8
    converter.inference_output_type = tf.int8
    tflite_quant_model = converter.convert()

    # Save result
    tflite_file = filename + ".tflite"
    open(tflite_file, "wb").write(tflite_quant_model)
    print(f"TFLite file saved to '{tflite_file}'.")

if __name__ == "__main__":
    main()

3. Failure after conversion
I would expect (and want) the above script to fail, because the model intentionally contains ops that can not be quantized and I am using the following options:

converter.target_spec.supported_ops = [tf.lite.OpsSet.TFLITE_BUILTINS_INT8]
converter.target_spec.supported_types = [tf.int8]

From the TensorFlow docs:
  # Convert model using only TensorFlow Lite quantized int8 operations.
  # Specifying this will throw an error for operations that do not yet have
  # quantized implementations.
  TFLITE_BUILTINS_INT8 = "TFLITE_BUILTINS_INT8"

Instead there are dequant/quant nodes inserted around the unsupported operator and the model is converted without any complaints. In other words: The used options seem to have no effect.
4. Tests and observations

When I use the old quantizer (converter.experimental_new_quantizer = False) I am getting the expected error.
After a quick look into the code there seems to be an option fully_quantize for mlir_quantize() here, but it seems to be not used here.
Might be related to this TODO in the cpp code.

Hi @sachinprasadhs ! Could you please look at this issue . Attached gist in 2.8, 2.9 and nightly for reference. Thank you!

Hi, @abattery  It seems you are already assigned to this issue.
Could you take a look at this issue? - This is a blocker of ARM side.

This behavior just does not throw an exception in the newer version. I wonder how the ARM side can be blocking because of this one.

Hi @abattery.
Thanks for looking into this. The issue here is that there is no "strict mode". We can not rely on the converter to produce a TFLite graph that only contains int8 operations (which might be required by the hardware).

Hi. I just tested this with TensorFlow 2.10 and the issue seems to be still present. Are there any updates on this?

Hi. This is still an issue in TensorFlow 2.11. Any updates?

Hi @benkli01
Th int8 support for floormod op has been added with commit https://github.com/tensorflow/tensorflow/commit/2ba376283d387b63d6c24bd48bea4dace386b017. It will be reflected in 2.13 version.
Thanks.

Hi @pjpratik, thanks for the heads-up. I just tried the latest pre-release version which should have support for int8 in floor_mod, but I can still see the error:

And if I switch to the old quantizer, I get the usual error:
RuntimeError: Quantization not yet supported for op: 'FLOOR_MOD'.

I just tested this with TensorFlow 2.13.0 and it is the same result as above, i.e. the error is still there (strangely enough, now that FLOOR_MOD should be supported for int8), @pjpratik .

Hi,
Thank you for opening this issue. Since this issue has been open for a long time, the code/debug information for this issue may not be relevant with the current state of the code base.
The TFLite team is constantly improving the framework by fixing bugs and adding new features. We suggest you try the latest TensorFlow version with the latest compatible hardware configuration which could potentially resolve the issue. If you are still facing the issue, please create a new GitHub issue with your latest findings, with all the debugging information which could help us investigate.
Please follow the release notes to stay up to date with the latest developments which are happening in the TFLite space.


No DMX cables

I am playing a modpack with 100 mods and i have theatrical installed version is 1.20.1 and i can´t find the dmx cables.
I don´t know if there wheren´t added yet or if it is because i´m using many mods.

DMX cables do not exist in the 1.20.x versions since they are complex to implement in the desired way. The ArtNet interface and lights all use "Wireless DMX" to connect.


Can we create an python app in azure app service(not linux)?

Can we create an python app in azure app service(not Azure App Service on Linux)?

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 53dd65b1-6f9d-9431-5850-9cee636aeabd
Version Independent ID: 0012e819-bb2b-2955-d87b-d6f145fb6af7
Content: App Service overview - Azure
Content Source: articles/app-service/overview.md
Service: app-service-web
GitHub Login: @cephalin
Microsoft Alias: cephalin

Hi @imeya, thanks for the feedback! We are currently investigating and will update you shortly.

@imeya no, you can only create python apps in Azure App Service on Linux. In the past, you could set up python environment on Azure App Service Windows but that has been deprecated.
We will now proceed to close this thread. If there are further questions regarding this matter, please tag me in your reply. We will gladly continue the discussion and we will reopen the issue.


optimize: optimize get select for update recognizer

Ⅰ. Describe what this PR did
When I use PG Sql in the feature branch, I found could not use one way to determine the SQL is for update or not. So, we have to use different way for different database.
Ⅱ. Does this pull request fix one issue?
Ⅲ. Why don't you add test cases (unit test/integration test)?
Ⅳ. Describe how to verify it
Ⅴ. Special notes for reviews

Codecov Report

Merging #1979 into develop will increase coverage by <.01%.
The diff coverage is 100%.

@@              Coverage Diff              @@
##             develop    #1979      +/-   ##
=============================================
+ Coverage      55.28%   55.29%   +<.01%
- Complexity      2430     2431       +1
=============================================
  Files            432      432
  Lines          14440    14443       +3
  Branches        1707     1706       -1
=============================================
+ Hits            7983     7986       +3
  Misses          5733     5733
  Partials         724      724

Impacted Files
Coverage Δ
Complexity Δ

...source/sql/druid/MySqlOperateRecognizerHolder.java
100% <100%> (ø)
7 <2> (+1)
:arrow_up:

...ql/druid/oracle/OracleOperateRecognizerHolder.java
100% <100%> (ø)
7 <2> (+1)
:arrow_up:

.../io/seata/rm/datasource/sql/SQLVisitorFactory.java
82.35% <100%> (-0.99%)
5 <0> (-1)


.gitignore accounted for or not?

Hey,
quick question, does this take .gitignore into account or does it see the file change and tries to commit it even tho the file/folder is ignored?

Hi,
Looks like .gitignore is not handled correctly. It will create empty commits when .gitignore is present and there are some ignored files. Thanks for mentioning that. I'll fix it once I have some free time.

@ZerGo0 The bug has been fixed in v0.2. Files from .gitignore should be correctly ignored now.


Pass data/state to callback

How can I pass data (a json object or stringified object) back to the callback url

Hi, @greggmojica  is this issue still open? and could you please give me more context if it is so...
I am newbie to this project and would like to contribute to it.


[!] Cannot update languages - could not find an editable info - when trying to upload metadata

New Issue Checklist

[x] Updated fastlane to the latest version
[x] I read the Contribution Guidelines
[x] I read docs.fastlane.tools
[x] I searched for existing GitHub issues

Issue Description

I'm trying to upload metadata (what's new texts) for my iOS app. Previously it worked fine, but now it throws the following error: "[!] Cannot update languages - could not find an editable info".
Probably it may be related to macOS app I have:

Command executed

fastlane deliver --force -u *** -a *** --skip_binary_upload true -i xxx.ipa -j ios -m /xxx/metadata --skip_screenshots true --phased_release
Complete output when running fastlane, including the stack trace and command used

2020-09-25T13:13:10.1736880Z [command]fastlane deliver --force -u xxx -a xxx --skip_binary_upload true -i xxx.ipa -j ios -m /Users/jenkins/TFS/deployment_agent/_work/r13/a/metadata --skip_screenshots true --phased_release
2020-09-25T13:13:13.4232470Z [16:13:13]: Get started using a Gemfile for fastlane https://docs.fastlane.tools/getting-started/ios/setup/#use-a-gemfile
2020-09-25T13:13:15.0449350Z [16:13:15]: Login to App Store Connect (***)
2020-09-25T13:13:17.8127640Z [16:13:17]: Login successful
2020-09-25T13:13:22.6996440Z
2020-09-25T13:13:22.7070940Z +--------------------------------------+---------------------------------------------------------------------------------------------------------------------------------------------------------------------+
2020-09-25T13:13:22.7088420Z |                                                                                deliver 2.160.0 Summary                                                                                |
2020-09-25T13:13:22.7105130Z +--------------------------------------+---------------------------------------------------------------------------------------------------------------------------------------------------------------------+
2020-09-25T13:13:22.7121640Z | force                                | true                                                                                |
2020-09-25T13:13:22.7135530Z | username                             | ***                                                                                |
2020-09-25T13:13:22.7152160Z | app_identifier                       | ***                                                                                |
2020-09-25T13:13:22.7168670Z | skip_binary_upload                   | true                                                                                |
2020-09-25T13:13:22.7187270Z | ipa                                  | ***.ipa |
2020-09-25T13:13:22.7208880Z | platform                             | ios                                                                                |
2020-09-25T13:13:22.7229620Z | metadata_path                        | /Users/jenkins/TFS/deployment_agent/_work/r13/a/metadata                                                                                |
2020-09-25T13:13:22.7247480Z | skip_screenshots                     | true                                                                                |
2020-09-25T13:13:22.7264490Z | phased_release                       | true                                                                                |
2020-09-25T13:13:22.7279200Z | screenshots_path                     | ./screenshots                                                                                |
2020-09-25T13:13:22.7293890Z | app_version                          | 2.35.0                                                                                |
2020-09-25T13:13:22.7309000Z | edit_live                            | false                                                                                |
2020-09-25T13:13:22.7323700Z | use_live_version                     | false                                                                                |
2020-09-25T13:13:22.7336400Z | skip_metadata                        | false                                                                                |
2020-09-25T13:13:22.7349020Z | skip_app_version_update              | false                                                                                |
2020-09-25T13:13:22.7361610Z | overwrite_screenshots                | false                                                                                |
2020-09-25T13:13:22.7374210Z | submit_for_review                    | false                                                                                |
2020-09-25T13:13:22.7386820Z | reject_if_possible                   | false                                                                                |
2020-09-25T13:13:22.7405230Z | automatic_release                    | false                                                                                |
2020-09-25T13:13:22.7430450Z | reset_ratings                        | false                                                                                |
2020-09-25T13:13:22.7450790Z | run_precheck_before_submit           | true                                                                                |
2020-09-25T13:13:22.7468380Z | precheck_default_rule_level          | warn                                                                                |
2020-09-25T13:13:22.7484640Z | ignore_language_directory_validation | false                                                                                |
2020-09-25T13:13:22.7499430Z | precheck_include_in_app_purchases    | true                                                                                |
2020-09-25T13:13:22.7518310Z +--------------------------------------+---------------------------------------------------------------------------------------------------------------------------------------------------------------------+
2020-09-25T13:13:22.7529740Z
2020-09-25T13:13:22.7545490Z [16:13:22]: Making sure the latest version on App Store Connect matches '2.35.0'...
2020-09-25T13:13:23.3209700Z [16:13:23]: '2.35.0' is the latest version on App Store Connect
2020-09-25T13:13:23.3236320Z [16:13:23]: Loading '/Users/jenkins/TFS/deployment_agent/_work/r13/a/metadata/ar-SA/release_notes.txt'...
2020-09-25T13:13:23.3259980Z [16:13:23]: Loading '/Users/jenkins/TFS/deployment_agent/_work/r13/a/metadata/de-DE/release_notes.txt'...
2020-09-25T13:13:23.3282050Z [16:13:23]: Loading '/Users/jenkins/TFS/deployment_agent/_work/r13/a/metadata/en-AU/release_notes.txt'...
2020-09-25T13:13:23.3302820Z [16:13:23]: Loading '/Users/jenkins/TFS/deployment_agent/_work/r13/a/metadata/en-GB/release_notes.txt'...
2020-09-25T13:13:23.3322940Z [16:13:23]: Loading '/Users/jenkins/TFS/deployment_agent/_work/r13/a/metadata/en-US/release_notes.txt'...
2020-09-25T13:13:23.3342830Z [16:13:23]: Loading '/Users/jenkins/TFS/deployment_agent/_work/r13/a/metadata/es-ES/release_notes.txt'...
2020-09-25T13:13:23.3361980Z [16:13:23]: Loading '/Users/jenkins/TFS/deployment_agent/_work/r13/a/metadata/es-MX/release_notes.txt'...
2020-09-25T13:13:23.3380960Z [16:13:23]: Loading '/Users/jenkins/TFS/deployment_agent/_work/r13/a/metadata/fr-FR/release_notes.txt'...
2020-09-25T13:13:23.3399070Z [16:13:23]: Loading '/Users/jenkins/TFS/deployment_agent/_work/r13/a/metadata/id/release_notes.txt'...
2020-09-25T13:13:23.3417070Z [16:13:23]: Loading '/Users/jenkins/TFS/deployment_agent/_work/r13/a/metadata/it/release_notes.txt'...
2020-09-25T13:13:23.3435150Z [16:13:23]: Loading '/Users/jenkins/TFS/deployment_agent/_work/r13/a/metadata/ja/release_notes.txt'...
2020-09-25T13:13:23.3453160Z [16:13:23]: Loading '/Users/jenkins/TFS/deployment_agent/_work/r13/a/metadata/ko/release_notes.txt'...
2020-09-25T13:13:23.3471470Z [16:13:23]: Loading '/Users/jenkins/TFS/deployment_agent/_work/r13/a/metadata/pt-BR/release_notes.txt'...
2020-09-25T13:13:23.3489620Z [16:13:23]: Loading '/Users/jenkins/TFS/deployment_agent/_work/r13/a/metadata/ru/release_notes.txt'...
2020-09-25T13:13:23.3507660Z [16:13:23]: Loading '/Users/jenkins/TFS/deployment_agent/_work/r13/a/metadata/tr/release_notes.txt'...
2020-09-25T13:13:23.3525700Z [16:13:23]: Loading '/Users/jenkins/TFS/deployment_agent/_work/r13/a/metadata/uk/release_notes.txt'...
2020-09-25T13:13:25.4524020Z [16:13:25]: Cannot find edit app info... Retrying after 10 seconds (remaining: 4)
2020-09-25T13:13:36.3000560Z [16:13:36]: Cannot find edit app info... Retrying after 10 seconds (remaining: 3)
2020-09-25T13:13:47.3957290Z [16:13:47]: Cannot find edit app info... Retrying after 10 seconds (remaining: 2)
2020-09-25T13:13:58.5352910Z [16:13:58]: Cannot find edit app info... Retrying after 10 seconds (remaining: 1)
2020-09-25T13:14:09.3336970Z [16:14:09]: Cannot find edit app info... Retrying after 10 seconds (remaining: 0)
2020-09-25T13:14:19.3433860Z
2020-09-25T13:14:19.3461320Z [!] Cannot update languages - could not find an editable info

Environment

🚫 fastlane environment 🚫
Stack

Key
Value

OS
10.15.6

Ruby
2.5.3

Bundler?
false

Git
git version 2.21.1 (Apple Git-122.3)

Installation Source
~/.rvm/gems/ruby-2.5.3/bin/fastlane

Host
Mac OS X 10.15.6 (19G2021)

Ruby Lib Dir
~/.rvm/rubies/ruby-2.5.3/lib

OpenSSL Version
OpenSSL 1.1.1d  10 Sep 2019

Is contained
false

Is homebrew
false

Is installed via Fabric.app
false

Xcode Path
/Applications/Xcode-11.3.1.app/Contents/Developer/

Xcode Version
11.3.1

System Locale

Error

No Locale with UTF8 found 🚫

fastlane files:
No Fastfile found
No Appfile found
fastlane gems

Gem
Version
Update-Status

fastlane
2.160.0
✅ Up-To-Date

Loaded fastlane plugins:
No plugins Loaded
Loaded gems

Gem
Version

did_you_mean
1.2.0

executable-hooks
1.6.0

bundler-unload
1.0.2

rubygems-bundler
1.4.5

bundler
1.16.6

slack-notifier
2.3.2

rouge
2.0.7

xcpretty
0.3.0

terminal-notifier
2.0.0

terminal-table
1.8.0

plist
3.5.0

addressable
2.7.0

multipart-post
2.0.0

word_wrap
1.0.0

babosa
1.0.3

colored
1.2

highline
1.7.10

commander-fastlane
4.4.6

excon
0.75.0

unf
0.1.4

domain_name
0.5.20190701

http-cookie
1.0.3

faraday-cookie_jar
0.0.6

faraday
1.0.1

faraday_middleware
1.0.0

fastimage
2.1.7

gh_inspector
1.1.3

json
2.1.0

rubyzip
2.3.0

security
0.1.3

xcpretty-travis-formatter
1.0.0

uber
0.1.0

declarative-option
0.1.0

representable
3.0.4

retriable
3.1.2

mini_mime
1.0.2

signet
0.14.0

httpclient
2.8.3

google-api-client
0.38.0

nanaimo
0.3.0

colored2
3.1.2

claide
1.0.3

CFPropertyList
3.0.2

atomos
0.1.3

xcodeproj
1.17.1

unicode-display_width
1.7.0

public_suffix
4.0.5

tty-screen
0.8.1

tty-cursor
0.7.1

tty-spinner
0.9.3

unf_ext
<IP_ADDRESS>

mini_magick
4.10.1

dotenv
2.7.6

naturally
2.2.0

simctl
1.6.8

jwt
2.2.1

declarative
0.0.20

multi_json
1.15.0

os
1.1.0

memoist
0.16.2

googleauth
0.13.0

rake
13.0.1

digest-crc
0.6.1

google-cloud-errors
1.0.1

google-cloud-env
1.3.3

google-cloud-core
1.5.0

google-cloud-storage
1.26.2

emoji_regex
3.0.0

aws-eventstream
1.1.0

aws-sigv4
1.2.1

aws-partitions
1.345.0

jmespath
1.4.0

aws-sdk-core
3.104.3

aws-sdk-kms
1.36.0

aws-sdk-s3
1.75.0

openssl
2.1.2

date
1.0.0

fileutils
1.0.2

ipaddr
1.2.0

psych
3.0.2

webrick
1.4.2

generated on: 2020-09-25

I investigated the issue a bit and found out that tunes.get_app_infos() returns two objects:
@app_store_state="READY_FOR_SALE", @app_store_age_rating="FOUR_PLUS", @brazil_age_rating="L", @kids_age_band=nil, @primary_category=#<Spaceship::ConnectAPI::AppCategory:0x00007fa0454ceb30 @id="PRODUCTIVITY", @platforms=["IOS", "MAC_OS", "TV_OS"]>, @secondary_category=#<Spaceship::ConnectAPI::AppCategory:0x00007fa0454ce978 @id="UTILITIES", @platforms=["IOS", "MAC_OS", "TV_OS"]>>

@app_store_state="PENDING_DEVELOPER_RELEASE", @app_store_age_rating="FOUR_PLUS", @brazil_age_rating="L", @kids_age_band=nil, @primary_category=#<Spaceship::ConnectAPI::AppCategory:0x00007fa0454ce6d0 @id="PRODUCTIVITY", @platforms=["IOS", "MAC_OS", "TV_OS"]>, @secondary_category=#<Spaceship::ConnectAPI::AppCategory:0x00007fa0454ce540 @id="UTILITIES", @platforms=["IOS", "MAC_OS", "TV_OS"]>>

Please note it doesn't contain actual new iOS version which is currently PREPARE_FOR_SUBMISSION. So, that's the reason why fetch_edit_app_info() is empty. However, I didn't get why we need fetch_edit_app_info instead of fetch_live_app_info. I replaced app.fetch_edit_app_info to app.fetch_live_app_info || app.fetch_edit_app_info and it seems to work...

@joshdholtz Could you please take a look on this? If my assumption is correct I can make a PR with this change. Thanks!

@sergeykochanov Ahhhhhh, that is a weird issue! If you want to make a PR that would be great 😊 I’d be happy to test it out!


Improve documentation for index files

i'm not sure if i should move this issue to https://github.com/lumeland/lume, but i guess it belong here since it's related to documentations.
Summary
improve documentation for index files by  adding section to describe

how lume finds and uses index files
which file extension will be accepted as valid index file (index.templ.ts, index.tsx, etc)
how could user load custom index file to lume() (like lume.data())

Motivation
sometimes how lume works feels automagical, and documentation often does not fully address lume's internals.

today i was trying to use index.tsx file, and somehow it failed to load. i searched through the docs yet the only example was using with 'index.md'. only after reading deno blog post i could be certain that other index files were supported.

I'm not sure to understand.
What do you mean with "index files"? Files that indexes content (like pagination) or files named index?
Index page files are like any other page file. I mean you can create a page using Markdown, Nunjucks, JSX, TypeScript, etc. The only difference is it's named index, so it's saved as index.html.

i mean the files that gets converted to index.html, such as index.md or index.tsx or index.tmpl.ts. currently lumeland lack docs for these.

Okay. It's not explicitly mentioned but you can see an example of index.md compared with other file names here: https://lume.land/docs/creating-pages/page-files/
Basically, in prettyUrls mode, all pages are converted to index.hml (about.njk => about/index.html).
And if prettyUrls is disabled, the pages keep the original name adding the .html extension (about.njk => about.html).
Is this the information you're missing?

yes, now i get it. thanks for clarifying.


[Feature Request] Adding bind to <IP_ADDRESS> by default

Tell us about your feature request
I just ran into an issue where, when running the application in a docker container, the webserver was not responding to requests since it was listening on localhost:8080. Inside a docker container it can only receive traffic when the webserver is listening on <IP_ADDRESS>:8080.
I think with how common it is for applications to run inside containers, this should be the default.
TODO:
check if the following frameworks automatically bind to localhost

[x] chi (it does)
[x] fiber (it does not)
[ ] gin,
[ ] gorilla/mux
[ ] httprouter
[ ] standard-library
[ ] echo

Disclaimer

[X] I agree

Tell us about your feature request
I just ran into an issue where, when running the application in a docker container, the webserver was not responding to requests since it was listening on localhost:8080. Inside a docker container it can only receive traffic when the webserver is listening on <IP_ADDRESS>:8080.
I think with how common it is for applications to run inside containers, this should be the default.
Disclaimer

[x]  I agree

I think something wrong in your dockerFile, try like this:
# Use the official Golang image to create a build artifact.
# This is a multi-stage build. This stage is named 'builder'.
FROM golang:1.22.1 as builder

# Set the working directory outside $GOPATH to enable the support for modules.
WORKDIR /app

# Copy the go.mod and go.sum to download all dependencies.
COPY go.mod go.sum ./

# Download all dependencies. Dependencies will be cached if the go.mod and go.sum files are not changed.
RUN go mod download

# Copy the source code.
COPY cmd/ cmd/
COPY internal/ internal/

# Build the application.
RUN CGO_ENABLED=0 GOOS=linux go build -a -installsuffix cgo -o /my-project ./cmd/api/main.go

# Use a Docker multi-stage build to create a lean production image.
# https://docs.docker.com/develop/develop-images/multistage-build/
FROM alpine:latest

# Install ca-certificates in case you need to make calls to HTTPS endpoints.
# The scratch image is the most minimal image in Docker. This image is only 5mb and has no shell.
# If you need to debug within the container, you might want to use a different base image.
RUN apk --no-cache add ca-certificates

WORKDIR /root/

# Copy the pre-built binary file from the previous stage.
COPY --from=builder /my-project .

# Expose port 8080 to the outside world.
EXPOSE 8080

# Command to run the executable.
CMD ["./my-project"]

# Remove the source code after the build is complete
RUN rm -rf /app

[!NOTE]
Also, note that the Dockerfile is only used for production-ready environments because it removes the source code after build is complete.

@H0llyW00dzZ I think your Dockerfile suffers from the same issue. It's mostly about consistency in behavior when setting or not setting the PORT environment variable. If I run the server with a simple go run cmd/api/main.go the application automatically binds to localhost:8080.
If you run the docker image you build the same way (so without -e"port=8080") the server is limited to localhost within the docker network it's running in. This is inconsistent with the way it runs outside a container.
You can try this with the following docker-compose.yml by running it once with the port commented out and with the port set after to see the difference.
version: '3.8'

services:
  backend:
    build: .
    # environment:
    #   PORT: 8080
    ports:
      - "8080:8080"
  psql:
    image: postgres:latest
    environment:
      POSTGRES_DB: test
      POSTGRES_USER: test
      POSTGRES_PASSWORD: test
    ports:
      - "5432:5432"
    volumes:
      - psql_volume:/var/lib/postgresql/data

volumes:
  psql_volume:

PS. I don't think you have to delete files from the 1st stage of a build explicitly. This is my Dockerfile for clarity:
FROM golang:1.22.1-bookworm AS builder

WORKDIR /app

# Copy go.mod and go.sum files to the workspace
COPY go.mod go.sum ./

# Download dependencies
RUN go mod download

# Copy the source code into the container
COPY . .

# Build the Go application
RUN GOOS=linux go build -o frontend-data cmd/api/main.go

# Stage 2: Final Stage
FROM gcr.io/distroless/base-debian12

# Copy the executable from the builder stage
COPY --from=builder /app/frontend-data /

EXPOSE 8080

# Command to run the executable
CMD ["/frontend-data"]

@H0llyW00dzZ I think your Dockerfile suffers from the same issue. It's mostly about consistency in behavior when setting or not setting the PORT environment variable. If I run the server with a simple go run cmd/api/main.go the application automatically binds to localhost:8080.
If you run the docker image you build the same way (so without -e"port=8080") the server is limited to localhost within the docker network it's running in. This is inconsistent with the way it runs outside a container.
You can try this with the following docker-compose.yml by running it once with the port commented out and with the port set after to see the difference.
version: '3.8'

services:
  backend:
    build: .
    # environment:
    #   PORT: 8080
    ports:
      - "8080:8080"
  psql:
    image: postgres:latest
    environment:
      POSTGRES_DB: test
      POSTGRES_USER: test
      POSTGRES_PASSWORD: test
    ports:
      - "5432:5432"
    volumes:
      - psql_volume:/var/lib/postgresql/data

volumes:
  psql_volume:

PS. I don't think you have to delete files from the 1st stage of a build explicitly. This is my Dockerfile for clarity:
FROM golang:1.22.1-bookworm AS builder

WORKDIR /app

# Copy go.mod and go.sum files to the workspace
COPY go.mod go.sum ./

# Download dependencies
RUN go mod download

# Copy the source code into the container
COPY . .

# Build the Go application
RUN GOOS=linux go build -o frontend-data cmd/api/main.go

# Stage 2: Final Stage
FROM gcr.io/distroless/base-debian12

# Copy the executable from the builder stage
COPY --from=builder /app/frontend-data /

EXPOSE 8080

# Command to run the executable
CMD ["/frontend-data"]

it works fine on my machine, till I got blocked

logs:
Attaching to backend-1
backend-1  | 2024/04/01 17:38:37 [H0llyW00dzZ Firewall] [INFO] Connected to database: *********
backend-1  | 2024/04/01 17:38:40 [H0llyW00dzZ] [INFO] Starting server on :8080
backend-1  |
backend-1  |  ┌───────────────────────────────────────────────────┐
backend-1  |  │                    H0llyW00dzZ                    │
backend-1  |  │                   Fiber v2.52.4                   │
backend-1  |  │               http://<IP_ADDRESS>:8080               │
backend-1  |  │       (bound on host <IP_ADDRESS> and port 8080)       │
backend-1  |  │                                                   │
backend-1  |  │ Handlers ............ 534 Processes ........... 1 │
backend-1  |  │ Prefork ....... Disabled  PID ................. 1 │
backend-1  |  └───────────────────────────────────────────────────┘
backend-1  |

Ah there it is, I have only tried this with chi, but I will check the other frameworks in the morning. Maybe this change should only affect the frameworks that automatically bind to localhost. Thanks for your input @H0llyW00dzZ.

Ah there it is, I have only tried this with chi, but I will check the other frameworks in the morning. Maybe this change should only affect the frameworks that automatically bind to localhost. Thanks for your input @H0llyW00dzZ.

No problem. Because I don't have any issues with binding, even on Kubernetes (k8s) with custom advanced configurations for the cluster.

For reference, are you only using fiber on these deployments?

For reference, are you only using fiber on these deployments?

I don't know about others, but for my deployments, I am using Fiber and HTMX.

Closing this since the default behavior of a standard generated application pulls the port from the .env file. This means the PORT environment variable is required in the subsequent docker-compose.yml.
If you come across this issue, make sure you check if that variable is set.


Create graph format for ownership-timeline analysis

Problem being solved
Currently we show numbers and tables for ownership-timeline results, but a graph would give more insights easily
Proposal
Create --format=graph for a graph version of the results

See https://github.com/guptarohit/asciigraph for a graph lib


Roadmap: 0.2

We're currently discussing the roadmap for 0.2.0
So far we're thinking about:

OPML import
Expand the number of topics
Suggestions for feeds to follow
Listen to changes to feeds in realtime
Share buttons

What else should be part of 0.2.0?

Would feedback on each feed item, after you return to the app, be a useful input to the personalization engine? Like "More of this", "Less of this" buttons?

Yes right now we only track impressions, click and selecting a specific feed (indicates you like to read the feed you've selected). An up or down vote is more explicit.

Explicit feedback would be great. That would be especially important if the app includes a full-content view because then you might not actually leave the app to read the article.

Closing this discussion since 0.2 launch is coming soon, will open a new topic about 0.3


change Environemnt cards visuals on settings page

Fixes

https://issues.redhat.com/browse/HAC-1968
Description

Visual changes for Environment cards
Type of change

[ ] Feature
[x] Bugfix
[ ] Code style update (formatting, renaming)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] Documentation content changes
[ ] Other (please describe):

Screen shots / Gifs for design review

How to test or reproduce?

Browser conformance:

[ ] Chrome
[ ] Firefox
[ ] Safari
[ ] Edge

/cc @serenamarie125

/hold cancel

/retest


Update OWNERS file to reflect team changes.

/override ci/prow/gpu-operator-e2e
something changed with the Required tests (maybe I modified it in the repo settings?), merge was passing in the past when the test was never triggered...


Gradle sync fails when older Kotlin version used

Expected Behavior
I can successfully apply detekt plugin to an existing project that is using a recent Kotlin version.
Observed Behavior
Applying detekt 1.19.0-RC1 to a project using Kotlin 1.5.21 fails.
Steps to Reproduce

Clone https://github.com/3flex/detekt-mismatch-kotlin
Run gradlew tasks
See failure:

FAILURE: Build failed with an exception.

* What went wrong:
Could not create task ':compileKotlin'.
> Could not create task of type 'KotlinCompile'.
   > Could not create an instance of type org.jetbrains.kotlin.gradle.tasks.KotlinJavaToolchainProvider.
      > Could not generate a decorated class for type KotlinJavaToolchainProvider.
         > Cannot have abstract method KotlinJavaToolchain.getJdk().

Context
With this dependency view from the Gradle scan it can be seen that the Kotlin Gradle plugin version dependencies of kotlin-gradle-plugin-api and others are changed from 1.5.21 to 1.5.31 to match the detekt Kotlin dependency version used on detekt Gradle plugin's runtime classpath: https://scans.gradle.com/s/3ohyjhgsh3xig/build-dependencies?dependencies=1.5.21&expandAll&focusedDependencyView=versions&resolutionFilter=WzFd
Your Environment

Version of detekt used: 1.19.0-RC1
Version of Gradle used (if applicable): 7.3
Gradle scan link (add --scan option when running the gradle task): https://gradle.com/s/3ohyjhgsh3xig
Operating System and version: Windows 10
Link to your project (if it's a public repository): https://github.com/3flex/detekt-mismatch-kotlin

I think we would recommend the latest Kotlin version when we release detekt. So I believe the correct way to address such an issue is to print warnings if the client project's Kotlin is below the recommended version.
https://detekt.github.io/detekt/compatibility.html#tool-versions

I disagree, that conflicts with this:

When shipping the Detekt Gradle Plugin, we depend on both the Kotlin Gradle Plugin and the Android Gradle Plugin.

Those dependencies are applied as compileOnly (see here) to allow our users to pick the version of the Gradle plugin they prefer and don’t impose the one we use inside detekt.

Also, Compose requires specific Kotlin versions to be used, so if detekt does the same, it can make it more difficult to find a combination that works. Compose 1.0.1 requires Kotlin 1.5.21 only, so can't be used with detekt 1.19.0 as the Kotlin Gradle plugin API version dependency in our plugin is 1.5.31 which conflicts and breaks the build.

     > Cannot have abstract method KotlinJavaToolchain.getJdk().

So is this happening on a Compose project?
Could you verify if this happens also on a plain JVM project?

I believe the repro project does not depend on Compose. (It does not even have code)
It is unfortunate that Compose requires pinning the Kotlin version. This shouldn't be an issue once the compiler plugin API is stable, but given the existing prevalence of Compose, now I do agree with you that we should try to make Detekt more flexible.

Could you verify if this happens also on a plain JVM project?

The repro contains only these lines in the build file:
plugins {
    id("org.jetbrains.kotlin.jvm") version "1.5.21"
    id("io.gitlab.arturbosch.detekt") version "1.19.0-RC1"
}

repositories {
    mavenCentral()
}

It is unfortunate that Compose requires pinning the Kotlin version.

That's true, but there may be other reasons a project is using one version of Kotlin instead of another - detekt needs to stay out of the user's way where we can. Increasing KSP usage might also force our hand... I think that's part of the reason the Compose Kotlin dependency is fixed. Of course there's a risk that relying on the runtime dependency of Kotlin Gradle plugin API will cause exceptions, but it should improve compatibility overall.

The repro contains only these lines in the build file:

Yup I missed that there was a repro attached, my bad.


1.17.1

please do 1 17 1
my friends and I are playing on 1 17 1 and we can't move the world to 1 18 because of the lags
we really need this mod because if I turn on cheats, whoever comes in and gamemode 1 turns on

done!


Fix 58

closes #58
hydrotools.metrics now requires numpy 1.20.0 or greater.
Changes

hydrotools.metrics now requires numpy 1.20.0 or greater.

Checklist

[x] PR has an informative and human-readable title
[x] PR is well outlined and documented. See #12 for an example
[x] Changes are limited to a single goal (no scope creep)
[x] Code can be automatically merged (no conflicts)
[x] Code follows project standards (see CONTRIBUTING.md)
[x] Passes all existing automated tests
[x] Any change in functionality is tested
[x] New functions are documented (with a description, list of inputs, and expected output) using numpy docstring formatting
[x] Placeholder code is flagged / future todos are captured in comments
[ ] Reviewers requested with the Reviewers tool :arrow_right:

Given the passing tests and the minor changes here, I am going to rebase and merge. Tagging you here, @jarq6c just as a heads up.


⚠ Feedaty widget has degraded performance

In e30f11b, Feedaty widget (https://widget.feedaty.com/public/js/feedaty.js?merchant=10213975&style_ver=2021&data-sku=36263) experienced degraded performance:

HTTP code: 200
Response time: 3236 ms

Resolved: Feedaty widget performance has improved in 21faf86 after 2 minutes.


Update installation guide for linux and mac os

Fix issue #87: Remove Statement about node_modules in Linux Installation Guide


AUTH_ORIGIN overrides

Environment

Operating System: Darwin
Node Version:     v18.14.0
Nuxt Version:     3.3.2
Nitro Version:    2.3.2
Package Manager<EMAIL_ADDRESS>Builder:          vite
User Config:      runtimeConfig, experimental, app, modules, css, postcss, auth
Runtime Modules<EMAIL_ADDRESS><EMAIL_ADDRESS>Build Modules:    -

Reproduction
git clone git@github.com:sidebase/nuxt-auth-example.git
cd nuxt-auth-example
echo 'shamefully-hoist=true' > .npmrc
echo 'auto-install-peers=true' >> .npmrc
pnpm install
# edit nuxt.config.ts to point origin to https://a-website.com
pnpm run build
NUXT_SECRET=a-secret AUTH_ORIGIN=https://b-website.com PORT=3003 node .output/server/index.mjs

in another terminal run
curl -I localhost:3003/protected/globally

In the server console you should see
Listening http://[::]:3003
[nuxt] [request error] [unhandled] [500] request to https://a-website.com/api/auth/session?callbackUrl=http://localhost:3003/protected/globally failed, reason: getaddrinfo ENOTFOUND a-website.com (https://a-website.com/api/auth/session?callbackUrl=http://localhost:3003/protected/globally)

Note that the request to https://a-website.com
Describe the bug
It looks like the AUTH_ORIGIN env var is not overriding the nuxt.config.ts value.
Additional context
No response
Logs
No response

Hey @drusellers!
I just tried this and it didn't reproduce - could you provide a repro repo?
Checkout my logs (or lack thereof):

closing this now as no more information arose and no working reproduction exists.
Do comment with a reproduction to re-open it or open a new issue in the future!

Sorry for the delay, I was out on leave.
Here is a loom video (English) - https://www.loom.com/share/c7775352f3c34789b779f834d2d77f2e
And here is the github reproduction repository.
https://github.com/drusellers/nuxt-auth-example


hello

what its that exactly ? thanks

Redirects Fortnite's requests (that use cURL) to wherever you want.


[Spectrum] Update byoip.md

Remove repeated phrase 'which allows you to do just that'.

Thanks for the suggestion @brettwilcox


Adding the --no-production option to preact build produces a Server-Side-Render error.

Do you want to request a feature or report a bug?
Report a bug
What is the current behaviour?
preact build --no-production causes a server-side exception. ReferenceError: window is not defined.
Full Error Message
Unable to read sourcemap: /Users/johnhaitas/src/johnhaitas/preact-cli-no-production-ssr/build/ssr-build/ssr-bundle.js.map

ReferenceError: window is not defined
method: null
[object Object]
This is most likely caused by using DOM or Web APIs.
Pre-render runs in node and has no access to globals available in browsers.

Consider wrapping code producing error in: 'if (typeof window !== "undefined") { ... }'

Alternatively use 'preact build --no-prerender' to disable prerendering.

See https://github.com/developit/preact-cli#pre-rendering for further information.npm ERR! code ELIFECYCLE
npm ERR! errno 1
npm ERR<EMAIL_ADDRESS>build-dev: `preact build --no-production`
npm ERR! Exit status 1
npm ERR!
npm ERR! Failed at the<EMAIL_ADDRESS>build-dev script.
npm ERR! This is probably not a problem with npm. There is likely additional logging output above.

npm ERR!      /Users/johnhaitas/.npm/_logs/2018-10-03T18_50_35_625Z-debug.log

2018-10-03T18_50_35_625Z-debug.log
The offending line comes from style-loader https://github.com/webpack-contrib/style-loader/blob/v0.18.2/lib/addStyles.js#L23.
If the current behaviour is a bug, please provide the steps to reproduce.
I have created a repo which adds a build-dev npm run script
https://github.com/johnhaitas/preact-cli-no-production-ssr
Reproduce the bug by running npm run build-dev
What is the expected behaviour?
The server-side pre-render should be successful.
Please mention other relevant information.

Node version - v8.12.0
npm version - 6.4.1
Operating system - MacOS High Sierra
CLI version - 2.2.1

Please not that in /src/lib/webpack/webpack-base-config.js the is isProd variable is never evaluated using isProd === true.
https://github.com/developit/preact-cli/blob/v2.2.1/src/lib/webpack/webpack-base-config.js#L149
The only way to get the isProd to evaluate to false (boolean) is by setting --no-production. If someone were to try --production false then isProd is set to 'false' (string) that will evaluate as true in /src/lib/webpack/webpack-base-config.js (because 'false' ? true : false evaluates to true)

@lukeed there-in lies the problem if --production false results in isProd to be false (boolean) then this problem will emerge

Right right, the next branch accounts for that too simply because in that version, env.production is directly equal to the argv.production value – which, for that branch, is always a boolean.

@lukeed I installed preact-cli next branch to test and the problem still occurs, now also for --production false.
This is expected as suggested in my previous comment - https://github.com/developit/preact-cli/issues/651#issuecomment-426767444

@lukeed there-in lies the problem if --production false results in isProd to be false (boolean) then this problem will emerge

The fix that you describe in your previous comment results in the same error now occurring with --production false (since it is now correctly evaluating isProd to false (boolean)
https://github.com/developit/preact-cli/issues/651#issuecomment-426766703

Getting --production false to be false (boolean) is fixed in the next version, but we might as well fix it here too since it's simple 👍

https://github.com/developit/preact-cli/issues/651#issuecomment-426767913

Right right, the next branch accounts for that too simply because in that version, env.production is directly equal to the argv.production value – which, for that branch, is always a boolean.

The problem is with style-loader
Changing isProd ? MiniCssExtractPlugin.loader : 'style-loader' to simply MiniCssExtractPlugin.loader fixes the problem in the next branch
Here are the two lines that would
https://github.com/developit/preact-cli/blob/next/packages/cli/lib/lib/webpack/webpack-base-config.js#L139
https://github.com/developit/preact-cli/blob/next/packages/cli/lib/lib/webpack/webpack-base-config.js#L166
I'm not sure if this is a valid fix though as it might not produce the results we're looking for - @lukeed thoughts?

The miniextract loader should not be included in watch mode, because that would break hmr.

The funny thing is that mini-css-extract-plugin recommends doing the isProd ? MiniCssExtractPlugin.loader : 'style-loader' line
perhaps the style-loader could only be introduced for client builds only - might that work?

Right. What @marvinhagemeister mentioned is correct.
The issue here is that there's a discrepancy in what Preact CLI uses for "is this production?" logic. Basically everywhere, there's a reference to the original argv.production value, as you'd expect.
But then here we are basing a prodBuild based off the watch parameter, which is a direct correlation to preact watch vs preact build.
So, because prerendering is tied to production mode (only), this fails.

Further, both issues (the watch reliance & the argv.production parsing) are still present on next.

@johnhaitas If you want to check out & verify the changes to either branch that'd be great. I tested both branches with simple apps, but hoping you have something more substantial handy.
Thanks!

@lukeed changes worked for me on both branches


fix #62 - bug preventing updates on records not already present

@NullVoxPopuli, are you able to try this locally and see if it fixes your issue?
You should be able to enter this in package.json to make it work:
"redux-crud-store": "devvmh/redux-crud-store#allow-update-on-non-present-record",

If it's not working try
rm -rf node_modules/redux-crud-store
npm install

TODO add tests

added tests. Tagging @NullVoxPopuli  as reviewer - I'd love to get this validated before merging and publishing as part of 5.4.1 along with #66

LGTM so far. will do a code test in a bit.

@NullVoxPopuli ping

@devvmh haven't run in to any issues :+1:


[5.1] Migrations: set size of integer fields

Laravel Version: 5.1.45 (LTS)
PHP Version: 5.5.9
Database Driver & Version: mysql 5.5.46

Description:
Ao criar uma migração com campo integer não tenho como definir com um determinado tamanho (11, por exemplo). Onde ao adicionar uma chave estrangeira a mesma falha.
Code example:
<?php

use Illuminate\Database\Schema\Blueprint;
use Illuminate\Database\Migrations\Migration;

class VendasLaravelCreateVendaTable extends Migration
{
    protected $table = 'venda';

    /**
     * Run the migrations.
     *
     * @return void
     */
    public function up()
    {
        Schema::table($this->table, function (Blueprint $tb) {
            $tb->integer('nfe_id', false, true)->after('indicador_id');
            $tb->foreign('nfe_id')
                ->references('id')
                ->on('nota_fiscal_eletronica')
                ->onDelete('no action')
                ->onUpdate('no action');
        });
    }

    /**
     * Reverse the migrations.
     *
     * @return void
     */
    public function down()
    {
        Schema::table($this->table, function (Blueprint $tb) {
            $tb->dropForeign('venda_nfe_id_foreign');
            $tb->dropColumn('nfe_id');
        });
    }
}

Where the nota_fiscal_electronic table has a primary key with the structure
`id` UNSIGNED INT(11) NOT NULL AUTO_INCREMENT;

causing the error below:
Erro Log:

[Illuminate\Database\QueryException]
SQLSTATE[23000]: Integrity constraint violation: 1452 Cannot add or update a child row: a foreign key constraint fails (#sql-427_344, CONSTRAINT venda_nfe_id_foreign FOREIGN KEY (nfe_id) REFERENCES nota_fiscal_eletronica (id) ON DELETE NO ACTION ON UPDATE NO ACTION) (SQL: alter table venda add constraint venda_nfe_id_foreign foreign key (nfe_id) references nota_fiscal_eletronica (id) on delete no action on update no action)

Because the field id has a size of 11 (INT(11)) and the foreign key field created in the venda table is INT(10), it is not possible to create the relationship.
Steps To Reproduce:
php artisan migrate

half your post is in Portuguese.

the (#) following INT should not affect your relationship in anyway, It only refers to display width in the case of using zerofill. Sounds like the nota_fiscal_eletronica id column isn't available when this migration runs, or there is some other error in your migration.

It's not the length issue, MySQL is not aware on this when building references on integer columns.
Try to do the following:

The table should be empty when you are adding non-nullable column with reference
Try to split column and foreign key creation in standalone Schema::table calls, like this:

        Schema::table($this->table, function (Blueprint $tb) {
            $tb->integer('nfe_id', false, true)->after('indicador_id');
        });
        // Maybe, DB::table($this->table)->update(['nfe_id' => DEFAULT_NFE_ID])
        Schema::table($this->table, function (Blueprint $tb) {
            $tb->foreign('nfe_id')
                ->references('id')
                ->on('nota_fiscal_eletronica')
                ->onDelete('no action')
                ->onUpdate('no action');
        });

Columns created during transaction are not visible to MySQL until transaction complete.

Actually, I was able to set up the relationship even the column being with the field INT (10). I also noticed that when using the same UNSIGNED property using 'size' the INT field is the size INT (10).
However you can add the field with the relationship with the code below:
<?php

use Illuminate\Database\Schema\Blueprint;
use Illuminate\Database\Migrations\Migration;

class VendasLaravelCreateVendaTable extends Migration
{
    protected $table = 'venda';

    /**
     * Run the migrations.
     *
     * @return void
     */
    public function up()
    {
        Schema::table($this->table, function (Blueprint $tb) {
            $tb->addColumn('integer', 'nfe_id', ['unsigned' => true, 'length' => 11])->after('indicador_id')->nullable();
            $tb->index('nfe_id');
            $tb->foreign('nfe_id')
                ->references('id')
                ->on('nota_fiscal_eletronica')
                ->onDelete('no action')
                ->onUpdate('no action');
        });
    }

    /**
     * Reverse the migrations.
     *
     * @return void
     */
    public function down()
    {
        Schema::table($this->table, function (Blueprint $tb) {
            $tb->dropForeign('venda_nfe_id_foreign');
            $tb->dropColumn('nfe_id');
        });
    }
}

However it may be interesting to be able to set the size of the int field even using the UNSIGNED property (#18516 - Migrations: set size of integer fields).
Thank you for your attention!


[app-configuration] Typings file is incorrectly referenced in package.json

The typings file was included in the package but not referenced properly in the package.json, leading to users not getting type information.
Simple fix, but will need to republish the package.

Fixed with preview.3


Read my project folder to create the script.

Issue
Is there a way to add / review the project folder to create a script ? The "Claude Dev" VSCode does that which is missing in aider... e.g, If I ask for create something, the plugin will review the project folder and provide necessary scripts.
Attached image for reference is the feature I'm looking for in Aider.

Version and model info
No response

Thanks for trying aider and filing this issue. This doc may be helpful:
https://aider.chat/docs/repomap.html

I'm going to close this issue for now, but feel free to add a comment here and I will re-open or file a new issue any time.


Not let the "Format on enter" feature delete the indentation of the current line

Fixes #6700

:+1:


Message poll flag issue

Message poll flag is used to  check if it is necessary to do the message process which delete useless message with a "TASK_NO_TASK" for destination task field.

So  now, I seprate the receiving and forwarding functions, however, another issue(not a problem) arises: When a message is received, the destination task will be set as TASK_NO_TASK, and the message poll flag will be set as "Need poll". If the task needs to forward such message, forwarding function will set the destination task as the desired next task, that means, it is unnecessary to do the message process poll......
Think about it.....

I use a 16-bit counting flag to record how many messages should be de deteled, that means I can mark up to 65535 messages(huge memory for MCU) at the same time.
When a message is received, the counting flag will increase, and if such message is forwarded, flag will decrease, in this case, it is unncessary to poll message process after message forwarding.


[PE-D][Tester A] Editing applications, organisations and recruiters and passing in an invalid parameter related to that type, is allowed as long as one valid field is also edited``

Edited job application: {title=20203,  stage=resume,  status=pending,  deadline=15-12-2023,  description=None} outputted when editing job application:
edit --application 1 --title bugsquasher --tag NOThelpful

Labels: type.FeatureFlaw severity.Medium
original: Jweewee/ped#3

A better summary of #125

Could be considered both a bug and a flaw - non-applicable flags are validated already but not all of them are per subcategory of a command.