Typo in a variable name

There was a typo in the db#init function preventing passing the connection string as a parameter. The only value used was the one defined by the DATABASE_URL env

\o/ thanks.


[BUG] User without login can change language

Unknown user can change language by visiting my server ip and pressing this icon https://i.imgur.com/n4PKY6o.png, a bit un-secure, so maybe make unique cookie id, so every new visitor can set own language, but only that which was logged in?

Now you can edit appsettings.json and set UseCookie to true in the Culture section.


Synology NFS Mount Fails

I mounted my Synlogy as NFS in Home Assistant as /Share/paperless it seems the Docker doesnt have permission and the Addon Stops.
It works if i unmount it and then mount it back while paperless is running.
Hopefully someone can help.
I tried almost everything. Here is the Homeassistant Protocol output:
s6-rc: info: service s6rc-oneshot-runner: starting
s6-rc: info: service s6rc-oneshot-runner successfully started
s6-rc: info: service base-addon-banner: starting

-----------------------------------------------------------
 Add-on: Paperless-ngx
 Paperless is an application that manages your personal documents. With the help of a document scanner, paperless transforms your wieldy physical document binders into a searchable archive and provides many utilities for finding and managing your documents.
-----------------------------------------------------------
 Add-on version: 1.2.8
 You are running the latest version of this add-on.
 System: Home Assistant OS 12.0  (aarch64 / raspberrypi4-64)
 Home Assistant Core: 2024.2.2
 Home Assistant Supervisor: 2024.02.1
-----------------------------------------------------------
 Please, share the above information when looking for help
 or support in, e.g., GitHub, forums or the Discord chat.
-----------------------------------------------------------
s6-rc: info: service base-addon-banner successfully started
s6-rc: info: service fix-attrs: starting
s6-rc: info: service base-addon-timezone: starting
s6-rc: info: service base-addon-log-level: starting
s6-rc: info: service fix-attrs successfully started
[21:29:55] INFO: Configuring timezone (Europe/Berlin)...
s6-rc: info: service base-addon-log-level successfully started
s6-rc: info: service base-addon-timezone successfully started
s6-rc: info: service legacy-cont-init: starting
s6-rc: info: service legacy-cont-init successfully started
s6-rc: info: service init-paperless: starting
s6-rc: info: service init-nginx: starting
s6-rc: info: service redis: starting
s6-rc: info: service redis successfully started
chown: changing ownership of '/share/paperless/consume': Invalid argument
chown: changing ownership of '/share/paperless/media/media.lock': Invalid argument
chown: changing ownership of '/share/paperless/media/documents/thumbnails/0000004.webp': Invalid argument
chown: changing ownership of '/share/paperless/media/documents/thumbnails/0000003.webp': Invalid argument
chown: changing ownership of '/share/paperless/media/documents/thumbnails': Invalid argument
Ingress is enabled
chown: changing ownership of '/share/paperless/media/documents/archive/2024/none/ELSTER - Versandbestätigung.pdf': Invalid argument
chown: changing ownership of '/share/paperless/media/documents/archive/2024/none': Invalid argument
chown: changing ownership of '/share/paperless/media/documents/archive/2024': Invalid argument
chown: changing ownership of '/share/paperless/media/documents/archive/2021/none/Grundriss_Haus.pdf': Invalid argument
chown: changing ownership of '/share/paperless/media/documents/archive/2021/none': Invalid argument
chown: changing ownership of '/share/paperless/media/documents/archive/2021': Invalid argument
chown: changing ownership of '/share/paperless/media/documents/archive': Invalid argument
chown: changing ownership of '/share/paperless/media/documents/originals/2024/none/ELSTER - Versandbestätigung.pdf': Invalid argument
chown: changing ownership of '/share/paperless/media/documents/originals/2024/none': Invalid argument
chown: changing ownership of '/share/paperless/media/documents/originals/2024': Invalid argument
chown: changing ownership of '/share/paperless/media/documents/originals/2021/none/Grundriss_Haus.pdf': Invalid argument
chown: changing ownership of '/share/paperless/media/documents/originals/2021/none': Invalid argument
chown: changing ownership of '/share/paperless/media/documents/originals/2021': Invalid argument
chown: changing ownership of '/share/paperless/media/documents/originals': Invalid argument
chown: changing ownership of '/share/paperless/media/documents': Invalid argument
chown: changing ownership of '/share/paperless/media': Invalid argument
chown: changing ownership of '/share/paperless': Invalid argument
s6-rc: warning: unable to start service init-paperless: command exited 1
s6-rc: info: service init-nginx successfully started
/run/s6/basedir/scripts/rc.init: warning: s6-rc failed to properly bring all the services up! Check your logs (in /run/uncaught-logs/current if you have in-container logging) for more information.
/run/s6/basedir/scripts/rc.init: fatal: stopping the container.
s6-rc: info: service init-nginx: stopping
s6-rc: info: service redis: stopping
s6-rc: info: service redis successfully stopped
s6-rc: info: service init-nginx successfully stopped
s6-rc: info: service legacy-cont-init: stopping
s6-rc: info: service legacy-cont-init successfully stopped
s6-rc: info: service fix-attrs: stopping
s6-rc: info: service base-addon-timezone: stopping
s6-rc: info: service base-addon-log-level: stopping
s6-rc: info: service fix-attrs successfully stopped
s6-rc: info: service base-addon-timezone successfully stopped
s6-rc: info: service base-addon-log-level successfully stopped
s6-rc: info: service base-addon-banner: stopping
s6-rc: info: service base-addon-banner successfully stopped
s6-rc: info: service s6rc-oneshot-runner: stopping
s6-rc: info: service s6rc-oneshot-runner successfully stopped

It seems to be a NFS4 issue, I can eventually make chown optional but you have to fix ALC on your network share

I have the same Problem here. What do you mean by fix ALC?
I don't know what has changed because everything was working fine.

Same Problem here. What do you mean when you say fix ALC.
It was working perfect till some point. Something must changed?!
Best Regards

What do you mean when you say fix ALC.

It was a miswrite, I meant access-control list.
You will need to make those folders writable by paperless on your Sonology.
The error above seem linked to NFS, you can check if it persist with SMB share.
If nothing works I'll allow to skip chown commands.
Since I don't have a synology it would be kinda hard for me to debug

It seems to work now.
It was running with the squash option make every user to admin. This seems not to work anymore.
I had to gave the guest user spezial permissions. Now it is working again.
Thx BenotAnastay!

It seems to work now.
It was running with the squash option make every user to admin. This seems not to work anymore.
I had to gave the guest user spezial permissions. Now it is working again.
But now the guest user must have all permissions for that folder. Not the best solution I guess.
Thx BenotAnastay!

@Exotron is it working on your side?

Seems stale to me


File Input FormKit element resetting bug

Reproduction
https://formkit.com/playground?fkv=latest&fileTab=Playground.vue&css-framework=genesis&files=jc[('name!'Playground.vue'~edMN!'<scrip9setup0impN9(+5%2C+I9)+fromJ%408kM%2FvuO--cons94+%3D+{}+%3D>+(-*It{181}-)-3script0-<EHA*HAU5+idLtypeL%3Aactions7false102H5SchemaGT%3Aschema7[V(V*%248kM6%2CV*label6V)GT]1G*%2F02350UbD+%40cQ74102*ItG3bD0T3A*3A3E-'~added!true)]*++-\n0>-1\'2T*3<%2F4handleRestBDCQ5FNmKM6%3AJfilO7%3D18fNm9t+Adiv0DuttonEtemplate0G-2H*<IreseJ+"L781+MitNorOe"QlickT**U2<VG2VUTQONMLJIHGEDA9876543210-*_
Describe the bug
Hello!
This bug is not reproducible if FormKit playground, but if you copy it in your IDE and start it in browser you will see.

Use FormKit File Input element in FormKitSchema
Create a button that reset the form on click (I use reset function from @formkit)
Try to load some file in input
Click resetting button
You will see that, file were deleted from form, and its value properties are clear, but FileName label didn`t reset and its contain the last loaded file name.

Hope you did understand me:)
Thanks for library its very usefull and interesting!
screenshots:
start view

loaded some file

clicked reset button

Environment
• OS: [e.g. iOS]
• Browser [e.g. chrome, safari]
• Version [e.g. 22]
OS: MacOS Sonoma 14.2.1 and Linux Ubuntu (cant recall the version), and Windows 11 (cant recall version too)
Browsers: Safari, Google, Mozilla, cant recall versions too :(

Facing a similar sort of bug in my recent project. Trying to use reset to clear a form but the file inputs don't seem to reset completely. Visually, they looked reset but if I try to select the same file - it doesn't work. I have added an additional manual file input clear to remedy this for the time being.


Update FastDEC after ACSet updates

This is meant to replace views in the FastDEC module with regular ACSet accessing. I've also taken the liberty of cleaning up some strange logic.

A few benchmarks of note. Overall performance otherwise is preserved.
Old:
Operator: Geometric Hodge
Variant: New Form-1, [0.935041 ms, 2.212816 MB]
Variant: Old Form-1, [53.808375 ms, 54.740096 MB]
Operator: Wedge Product
Variant: New Form-0, Form-1, [0.052583 ms, 0.308864 MB]
Variant: New Form-0, Form-2, [0.339291 ms, 0.415056 MB]
Variant: New Form-1, Form-1, [0.1625 ms, 0.35056 MB]
Variant: Old Form-0, Form-1, [8.164167 ms, 8.05008 MB]
Variant: Old Form-0, Form-2, [46.512188 ms, 83.6008 MB]
Variant: Old Form-1, Form-1, [50.183625 ms, 56.1576 MB]
New:
Operator: Geometric Hodge
Variant: New Form-1, [0.9962295 ms, 1.8428 MB]
Operator: Wedge Product
Variant: New Form-0, Form-1, [0.053959 ms, 0.308864 MB]
Variant: New Form-0, Form-2, [0.257666 ms, 0.409744 MB]
Variant: New Form-1, Form-1, [0.154208 ms, 0.35056 MB]

Test Summary: | Pass  Total   Time
CUDA          |  139    139  41.7s
     Testing CombinatorialSpaces tests passed

shell> git log -1
commit 67ad092ad6615e66994ce3956d7a65657fdf3684 (HEAD -> gr/clean-fast-dec, origin/gr/clean-fast-dec)
Author: GeorgeR227<EMAIL_ADDRESS>Date:   Tue Jun 4 15:32:09 2024 -0400

    Added some doc strings.

Can you edit your comment to use the commit at which you ran those benchmarks


High Priority - Verify Block

We have the  transaction/block processor built, but it's not doing any kind of validation.
The block should be verified before being processed.

I am working on this issue


Render Shields and Energy

Simple text element representing both shields and energy underneath each unit. Referenced in #44 .

I merged #113 instead.


godot: 3.0.2 -> 3.0.3

Semi-automatic update generated by https://github.com/ryantm/nixpkgs-update tools.
This update was made based on information from https://repology.org/metapackage/godot/versions.
These checks were done:

built on NixOS
Warning: no invocation of /nix/store/4hkbcbl0sgbd9npxsdf1qyn46k7npxgg-godot-3.0.3/bin/godot had a zero exit code or showed the expected version
0 of 1 passed binary check by having a zero exit code.
0 of 1 passed binary check by having the new version present in output.
found 3.0.3 with grep in /nix/store/4hkbcbl0sgbd9npxsdf1qyn46k7npxgg-godot-3.0.3
directory tree listing: https://gist.github.com/ed73ee8e6d32a2bca8e7187447417b7e
du listing: https://gist.github.com/25aba4f04e5002d49d3e5b12c3eed088

meta.description for godot is: '"Free and Open Source 2D and 3D game engine"'.
cc @twey for testing.
Experimental: this build is cached with Cachix. To use the cache follow these experimental instructions:
One time setup in nixpkgs Git checkout:
cachix use r-ryantm
git remote add r-ryantm https://github.com/r-ryantm/nixpkgs.git

Test this build:
git fetch r-ryantm && git checkout 013c414e648a69a30be03961bc784778d094fffa && nix-shell --pure -I nixpkgs=. -p godot

No attempt on x86_64-darwin (full log)
The following builds were skipped because they don't evaluate on x86_64-darwin: godot
Partial log (click to expand)

a) For `nixos-rebuild` you can set
  { nixpkgs.config.allowUnsupportedSystem = true; }
in configuration.nix to override this.

b) For `nix-env`, `nix-build`, `nix-shell` or any other Nix command you can add
  { allowUnsupportedSystem = true; }
to ~/.config/nixpkgs/config.nix.

No attempt on aarch64-linux (full log)
The following builds were skipped because they don't evaluate on aarch64-linux: godot
Partial log (click to expand)

a) For `nixos-rebuild` you can set
  { nixpkgs.config.allowUnsupportedSystem = true; }
in configuration.nix to override this.

b) For `nix-env`, `nix-build`, `nix-shell` or any other Nix command you can add
  { allowUnsupportedSystem = true; }
to ~/.config/nixpkgs/config.nix.

Success on x86_64-linux (full log)
Attempted: godot
Partial log (click to expand)
shrinking RPATHs of ELF executables and libraries in /nix/store/vbm5hm5h09kc2b5aws2jslrsc3dzvzi3-godot-3.0.3-dev
strip is /nix/store/4mf2xm9p32lzrim927yk92xhx35yaz62-binutils-2.30/bin/strip
patching script interpreter paths in /nix/store/vbm5hm5h09kc2b5aws2jslrsc3dzvzi3-godot-3.0.3-dev
checking for references to /build in /nix/store/vbm5hm5h09kc2b5aws2jslrsc3dzvzi3-godot-3.0.3-dev...
shrinking RPATHs of ELF executables and libraries in /nix/store/8pzlnj586h371xqklddq6nvrs6vxpzhv-godot-3.0.3-man
gzipping man pages under /nix/store/8pzlnj586h371xqklddq6nvrs6vxpzhv-godot-3.0.3-man/share/man/
strip is /nix/store/4mf2xm9p32lzrim927yk92xhx35yaz62-binutils-2.30/bin/strip
patching script interpreter paths in /nix/store/8pzlnj586h371xqklddq6nvrs6vxpzhv-godot-3.0.3-man
checking for references to /build in /nix/store/8pzlnj586h371xqklddq6nvrs6vxpzhv-godot-3.0.3-man...
/nix/store/4hkbcbl0sgbd9npxsdf1qyn46k7npxgg-godot-3.0.3


fix: release workflow

Not sure if it will work this time. But I don't see a way to test it somewhere else than on the live system.

@gfellerph I'm not able to test this from my post computer, because of a timeout.
Can you try it from your machine?

This is not needed, because changeset publish should setting the tag specified in the pre.json file within the .changeset folder.
Currently defined tag: next


Receive ack from giganto

receive and print to console ack timestamp
Resolve: #128

Codecov Report
Base: 6.98% // Head: 6.97% // Decreases project coverage by -0.01% :warning:

Coverage data is based on head (34afb15) compared to base (bbdd007).
Patch coverage: 0.00% of modified lines in pull request are covered.

:exclamation: Current head 34afb15 differs from pull request most recent head 6ed42a1. Consider uploading reports for the commit 6ed42a1 to get more accurate results

Additional details and impacted files
@@           Coverage Diff            @@
##            main    #132      +/-   ##
========================================
- Coverage   6.98%   6.97%   -0.02%
========================================
  Files          9       9
  Lines       2605    2609       +4
========================================
  Hits         182     182
- Misses      2423    2427       +4

Impacted Files
Coverage Δ

src/producer.rs
3.77% <0.00%> (-0.08%)
:arrow_down:

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.


Content Enhancement Indonesian - 12-04-2022

Hi, Jack. @PardusEidolon
So, there are 2 additional files that I just created, 'Pengetahuan Umum' & 'Seputar Cardano'.
I plan to have more articles nested below each of them.
For example:
Pengetahuan Umum

Apa itu cryptocurrencies?
Apa itu crypto wallet?

Seputar Cardano

Cara staking Cardano
Berapa APY staking Cardano

Should I create a folder instead of a file?
And then, what is the weight & how do you put a specific number for it?

title: "Cara Ikut Serta di Project Catalyst"
linkTitle: "Cara Ikut Serta di Project Catalyst"
hide_feedback: true
"weight: 4"
description: "Bagaimana cara menjadi Proposer, Voter, atau Community Advisor?"

hello there @andrecahyadi
I would recommend creating a folder heirachy for future articles you plan to put into the website make sure to have an _index.md in the root of each folder look at exisitng index files for example.
The weight is an abitrary number that is used to define what goes on top vs what goes underneath. _index.md files that have a higher weight are going to be shown at the top of a side bar for example than those with a lower one

@PardusEidolon Hi, Jack, thanks for merging my commits & thanks for your explanation previously =D
I've create a pull request to release into the website


[FR] Add "nitro php" as command

Description
It would be nice to be able to run the php command through the nitro command as you would with "nitro craft".
Why?
As an example. I had this Craft site with a Laravel independent "module". In Laravel you have this "artisan" CLI as you do with Yii/Crafts "craft" CLI. I had to locally install PHP in my distro to run it. It would be nice to have this native inside Nitro from the start - since the php library is there existing.

Thank you for the suggestion, I think this makes a lot of sense to add. You can still run the artistan command by adding another step:

nitro ssh
php artisan

Ideally this would work exactly the same as the craft and queue commands by being "site aware" and defaulting to a help style output (e.g. nitro php would run php -v).
We will take a look at setting this up and testing locally!


Pull Failed: No such device or address

Hi there,
I'm getting this error in my console when launching Obsidian, and when toggling the plugin on and off.
Uncaught (in promise) Error: bash: /dev/tty: No such device or address
error: failed to execute prompt script (exit code 1)
fatal: could not read Username for 'https://github.com': No such file or directory

    at GitExecutorChain.onFatalException (eval at <anonymous> (app.js:1), <anonymous>:2536:85)
    at GitExecutorChain.eval (eval at <anonymous> (app.js:1), <anonymous>:2527:28)
    at Generator.throw (<anonymous>)
    at rejected (eval at <anonymous> (app.js:1), <anonymous>:2482:65)

I am unable to access the configuration options for the plugin with this issue occurring.
No actual pull occurs.
No other functionality works (automatic push)

Did you set your email and username for git? See https://docs.github.com/en/github/setting-up-and-managing-your-github-user-account/setting-your-commit-email-address#setting-your-commit-email-address-in-git  and https://docs.github.com/en/github/using-git/setting-your-username-in-git#setting-your-git-username-for-every-repository-on-your-computer

I seem to be getting the same problem.

On startup, I get the following error:

In the console this is confirmed:

Although this may be related to https://github.com/kemayo/sublime-text-git/issues/176, my suspicion is that it's a Flatpak issue. I have Obsidian installed on Pop_OS via the Pop Store, which uses Flatpak. As I understand it, Flatpak runs in some kind of sandbox, and perhaps this is preventing it from having access to the normal Git credentials? If I simply run git pull on a terminal in my vault directory, it works fine. I was using Bryan Jenks' git setup (bash script + cron job) before trying this plugin, but I'd like to be able to integrate git with Obsidian more directly, as it means technical setup to have to remember.

I am using it with Flatpak on KDE neon and it works fine. Flathub changed some configs, why I suggest running the following:
$ flatpak update md.obsidian.Obsidian
$ flatpak override --reset md.obsidian.Obsidian
$ flatpak run md.obsidian.Obsidian

https://github.com/flathub/md.obsidian.Obsidian/issues/5#issuecomment-736974662
And if you run git push in the console, do you have to enter username, password or similar?

Ah, perfect, thank you. Running Obsidian through flatpak presented me a login prompt for Github, and after entering my credentials there it is working correctly.
I think it would be a good idea to have some kind of message somewhere prominent with these instructions for other folks in my situation? Would save you some bug reports :)

I already added some instructions, but maybe it's a good idea to add this solution for users, who already installed Obsidian with Flatpak a while ago.

flatpak run md.obsidian.Obsidian

Hey there. Thank you for this solution. I did have the latest flatpak version, but running with flatpak run md.obsidian.Obsidian allowed me to pull the repo by typing my credential in the terminal.
However, looks like I have to do so for every pull/push, which is really unpractical, specially considering I've set it to backup every 30 minutes. Is there any fix to this? I'm not looking at the terminal while I write my notes.
By the way, I'm on the latest stable elementaryOS, with Obsidian installed from flatpak (as mentioned above)

I guess you are using https to authenticate. The only way would be to cache the credentials from the terminal. Or you use ssh and add it to the ssh-agent

Closing because of no response of @Bejasc .

if you are arch user than download pacman version  (not AUR version)


Use go1.19 for go interop tests and for future interop_matrix tests

Attempting to recreate #26124, but for 1.19 so that Go tests will be green again.
I ran LOCAL_ONLY_MODE=true tools/dockerfile/push_testing_images.sh (it seems inappropriate to push these since they haven't been reviewed), as described in the README, but it looks like it was actually trying to upload the image it built at the end(?!):
The push refers to repository [us-docker.pkg.dev/grpc-testing/testing-images-public/grpc_interop_go1.19]
c158f0568ed9: Preparing
42bde5dd8372: Preparing
a440f7febf21: Preparing
ad53d709b97c: Preparing
99e8acd709fa: Preparing
6201ebf6567d: Waiting
de3f6c83fe06: Waiting
6a7921805df0: Waiting
89c3244a87b2: Waiting
80231db1194c: Waiting
f1c1f2298584: Waiting
ccba29d69370: Waiting
denied: Permission "artifactregistry.repositories.uploadArtifacts" denied on resource "projects/grpc-testing/locations/us/repositories/testing-images-public" (or it may not exist)

From push_testing_images.sh this seems backwards?:
  if [ "${SKIP_UPLOAD}" == "" ] && [ "${LOCAL_ONLY_MODE}" != "" ]
  then
    docker push ${ARTIFACT_REGISTRY_PREFIX}/${DOCKER_IMAGE_NAME}:${DOCKER_IMAGE_TAG}
  fi

it seems inappropriate to push these since they haven't been reviewed

Uploading is actually mostly fine, because they are tagged with the hash of their contents (essentially content-addressable storage). So nothing will use it unless it is the right thing to use it. It would "just" waste storage.

Eric Anderson @.***>于2022年11月23日 周三03:31写道：

@.**** approved this pull request.
This looks good, but we need to publish the images first (and should be
able to see the tests pass? Dunno if those are still run per-PR now; I
think they might not.).
—
Reply to this email directly, view it on GitHub
https://github.com/grpc/grpc/pull/31732#pullrequestreview-1190666480,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/A4I3M6BS4T6RGP4W54HY5MTWJUNSDANCNFSM6AAAAAASHFNYJA
.
You are receiving this because you are subscribed to this thread.Message
ID: @.***>

Attempting to recreate #26124, but for 1.19 so that Go tests will be green again.
I ran LOCAL_ONLY_MODE=true tools/dockerfile/push_testing_images.sh (it seems inappropriate to push these since they haven't been reviewed), as described in the README, but it looks like it was actually trying to upload the image it built at the end(?!):
The push refers to repository [us-docker.pkg.dev/grpc-testing/testing-images-public/grpc_interop_go1.19]
c158f0568ed9: Preparing
42bde5dd8372: Preparing
a440f7febf21: Preparing
ad53d709b97c: Preparing
99e8acd709fa: Preparing
6201ebf6567d: Waiting
de3f6c83fe06: Waiting
6a7921805df0: Waiting
89c3244a87b2: Waiting
80231db1194c: Waiting
f1c1f2298584: Waiting
ccba29d69370: Waiting
denied: Permission "artifactregistry.repositories.uploadArtifacts" denied on resource "projects/grpc-testing/locations/us/repositories/testing-images-public" (or it may not exist)

From push_testing_images.sh this seems backwards?:
  if [ "${SKIP_UPLOAD}" == "" ] && [ "${LOCAL_ONLY_MODE}" != "" ]
  then
    docker push ${ARTIFACT_REGISTRY_PREFIX}/${DOCKER_IMAGE_NAME}:${DOCKER_IMAGE_TAG}
  fi

You're absolutely right, I already had a PR to fix this, but it hasn't been merged yet: https://github.com/grpc/grpc/pull/31689

Sanity tests are failing with grep: tools/dockerfile/interoptest/grpc_interop_go1.19.current_version: No such file or directory. I have no clue what is up with that.
@jtattermusch, @drfloob, @sergiitk, what is this newfangled stuff?

See the description of https://github.com/grpc/grpc/pull/31591 for context.


Can't import a library that doesn't have a class definition

I can't import a library that doesn't have a class definition. All import ends with:
ERROR: get_instance_base_type: Parameter "ecma_class" is null.
   At: modules/ECMAScript/ecmascript.cpp:29

Library i tried:
https://csv.js.org/
https://www.papaparse.com/

Here is a working example.
I use TS here and compile all npm_modules I use to a script which will be built by esbuild. Besides this, you could use<EMAIL_ADDRESS>which should be the same like the esbuild file.

Added this question to gotchas


Enable more clang tidy warnings; fix fallout.

Signed-off-by: Henner Zeller<EMAIL_ADDRESS>

Codecov Report

Merging #961 (cbc0532) into master (0bf7e75) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##           master     #961   +/-   ##
=======================================
  Coverage   92.71%   92.71%
=======================================
  Files         316      316
  Lines       20737    20738    +1
=======================================
+ Hits        19226    19227    +1
  Misses       1511     1511

Impacted Files
Coverage Δ

common/analysis/file_analyzer.h
100.00% <100.00%> (ø)

common/util/vector_tree.h
99.71% <100.00%> (+<0.01%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0bf7e75...cbc0532. Read the comment docs.


amenawat

When using either ordered and unordered list as the last block, the closing nesting tag is missing

one

two

Thanks for the bug report, will have a look at this tomorrow

Fixed in v1.0.10


Service List UI in Weave Cloud

[x] Brief @foot on how this should be

Bumping to (presumably) next milestone.

Can this be closed? We have gone through several iterations of the service list ui already, all without referencing this issue. Which suggests to me that this is done and any extra work should be tracked by fresh issues.

Service list was implemented in https://github.com/weaveworks/service-ui/pull/60


inspect reports incorrect size reported for 2D arrays

For example:
/call_genotype                int8     520 bytes   6.38 GiB       1.3e+07        432  15.13 MiB     1 byte              (1070401, 3202, 2)  (10000, 1000, 2)  Blosc(cname='zstd', clevel=7, shuffle=BITSHUFFLE, blocksize=0)  None

This appears to be due to https://github.com/zarr-developers/zarr-python/issues/253

Right - this probably changed when I went to using the "/" dimension separator.

https://github.com/zarr-developers/zarr-python/pull/1815


fix: remove unneeded allOf usages

Both example and description can be added on the same level as $ref. Some components were already leveraging that.
Align all such uses to this syntax to remove unneeded allOf usages. Also removed others incorrect usages of allOf.

Note that although validators are fine with thus syntax, strictly speaking description can be overridden in a Reference Object only starting OpenAPI 3.1.
Similarly example is not part of the Reference Object. So we are left with 2 options:

switch all usages of example associated with the Reference Object to the previous allOf hack
have example be part of the referenced component definition and get rid of per $ref examples
My preference would go to the second option, as it's unclear to me if such usages of allOf is sound.

I fixed the example by:

pulling example one level up in Responses (the right location, some existing Responses were already doing that)
removing some irrelevant ones (duplicates, dummy values, random enum)

leverage changes from https://github.com/ethereum/beacon-APIs/pull/408

Everything should be good now.

@nflaig @dapplion This PR now depends on https://github.com/ethereum/beacon-APIs/pull/409 for the openapi upgrade.
I removed all irrelevant example usages.
So we are left with what is required to remove the incorrect allOf usages:

rely on the new description override feature
pull up example in Responses

Note that some allOf were already useless.

This runs ok, are we ok to merge?

@rolfyone fine with me!


Broken tutorial - WhatsApp Clone with Ionic 2 and Meteor CLI help

Tried countless times to follow all sort of tutorials and installing all the boilerplate projects I found. It seem to be a problem with new 1.6 version and the integration with Angular....
https://forums.meteor.com/t/broken-tutorial-whatsapp-clone-with-ionic-2-and-meteor-cli/42087

try this:
meteor remove angular2-compilers
meteor update --release <IP_ADDRESS>
meteor add angular-compilers
https://github.com/Urigo/angular-meteor/tree/master/atmosphere-packages/angular-compilers

If you get this working, could you please share your project config (.meteor/packages, package.json, and tsconfig.json). I have been working on a similar issue for some hours now, but without success.
I will also post my solution if I manage to make it compile and run properly...

Sure
This is from my project w\o ionic:
.meteor/packages
# Meteor packages used by this project, one per line.
# Check this file (and the other files in this directory) into your repository.
#
# 'meteor add' and 'meteor remove' will edit this file for you,
# but you can also edit it by hand.

<EMAIL_ADDRESS>           # Packages every Meteor app needs to have
<EMAIL_ADDRESS>     # Packages for a great mobile UX
<EMAIL_ADDRESS>                 # The database Meteor supports right now
<EMAIL_ADDRESS>          # Reactive variable for tracker
<EMAIL_ADDRESS>               # Meteor's client-side reactive programming library

<EMAIL_ADDRESS> # CSS minifier run for production mode
<EMAIL_ADDRESS>  # JS minifier run for production mode
<EMAIL_ADDRESS>              # ECMAScript 5 compatibility for older browsers
<EMAIL_ADDRESS>            # Enable ECMAScript2015+ syntax in app code
<EMAIL_ADDRESS>          # Server-side component of the `meteor shell` command
angular-compilers
accounts-password
alanning:roles
reywood:publish-composite

package.json
{
 "name": "***",
 "private": true,
 "scripts": {
   "start": "meteor run"
 },
 "dependencies": {
   "@angular/animations": "^5.2.5",
   "@angular/cdk": "^5.2.1",
   "@angular/common": "^5.2.5",
   "@angular/compiler": "^5.2.5",
   "@angular/core": "^5.2.5",
   "@angular/forms": "^5.2.5",
   "@angular/http": "^5.2.5",
   "@angular/material": "^5.2.1",
   "@angular/platform-browser": "^5.2.5",
   "@angular/platform-browser-dynamic": "^5.2.5",
   "@angular/router": "^5.2.5",
   "@babel/runtime": "^7.0.0-beta.40",
   "@covalent/core": "^1.0.0",
   "@covalent/dynamic-forms": "^1.0.0",
   "babel-runtime": "^6.26.0",
   "bcrypt": "^1.0.3",
   "hammerjs": "^2.0.8",
   "meteor-node-stubs": "^0.3.2",
   "meteor-rxjs": "^0.4.8",
   "rxjs": "^5.5.0",
   "zone.js": "^0.8.20"
 },
 "devDependencies": {
   "@angular/compiler-cli": "^5.2.5",
   "@types/hammerjs": "^2.0.35",
   "@types/meteor": "^1.4.13",
   "@types/meteor-publish-composite": "0.0.33",
   "@types/meteor-roles": "^1.2.29",
   "@types/node": "^9.4.6",
   "typescript": "2.6.2"
 }
}

tsconfig.json
{
 "compilerOptions": {
   "allowSyntheticDefaultImports": true,
   "baseUrl": ".",
   "declaration": false,
   "emitDecoratorMetadata": true,
   "importHelpers": true,
   "experimentalDecorators": true,
   "lib": [
     "dom",
     "es2015"
   ],
   "module": "commonjs",
   "moduleResolution": "node",
   "sourceMap": true,
   "target": "es2015",
   "skipLibCheck": true,
   "stripInternal": true,
   "noImplicitAny": false
 },
 "include": [
   "imports/**/*.ts",
   "client/**/*.ts",
   "server/**/*.ts"
 ],
 "exclude": [
   "node_modules"
 ],
 "types": [
   "typings.d",
   "@types/node",
   "@types/meteor",
   "@types/meteor-roles",
   "@types/meteor-publish-composite",
   "@types/hammerjs"
 ],
 "compileOnSave": false,
 "atom": {
   "rewriteTsconfig": false
 }
}

And i've build an example Ionic project https://github.com/Urigo/Ionic2-MeteorCLI-WhatsApp
It compiles, but not work, needs configuration for webpack (maybe? i think so)
.meteor/packages
# Meteor packages used by this project, one per line.
# Check this file (and the other files in this directory) into your repository.
#
# 'meteor add' and 'meteor remove' will edit this file for you,
# but you can also edit it by hand.

<EMAIL_ADDRESS>           # Packages every Meteor app needs to have
<EMAIL_ADDRESS>                 # The database Meteor supports right now
<EMAIL_ADDRESS>          # Reactive variable for tracker
<EMAIL_ADDRESS>                # Helpful client-side library
<EMAIL_ADDRESS>               # Meteor's client-side reactive programming library

<EMAIL_ADDRESS> # CSS minifier run for production mode
<EMAIL_ADDRESS>  # JS minifier run for production mode
<EMAIL_ADDRESS>              # ECMAScript 5 compatibility for older browsers.
<EMAIL_ADDRESS>            # Enable ECMAScript2015+ syntax in app code
<EMAIL_ADDRESS>          # Server-side component of the `meteor shell` command

mys:fonts
<EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS>mys:accounts-phone
reywood:publish-composite
jalik:ufs
jalik:ufs-gridfs
angular-compilers
dynamic-import

package.json
{
  "name": "Ionic2-MeteorCLI-WhatsApp",
  "private": true,
  "scripts": {
    "start": "meteor run --settings private/settings.json"
  },
  "dependencies": {
    "@agm/core": "^1.0.0-beta.2",
    "@angular/animations": "^5.2.5",
    "@angular/common": "^5.2.5",
    "@angular/compiler": "^5.2.5",
    "@angular/compiler-cli": "^5.2.5",
    "@angular/core": "^5.2.5",
    "@angular/forms": "^5.2.5",
    "@angular/http": "^5.2.5",
    "@angular/platform-browser": "^5.2.5",
    "@angular/platform-browser-dynamic": "^5.2.5",
    "@angular/platform-server": "^5.2.5",
    "@ionic/storage": "^2.1.3",
    "angular2-google-maps": "^0.17.0",
    "angular2-moment": "^1.1.0",
    "babel-runtime": "6.18.0",
    "bcrypt": "^1.0.3",
    "ionic-angular": "^3.9.2",
    "ionic-native": "^2.9.0",
    "ionicons": "3.0.0",
    "meteor-node-stubs": "~0.2.0",
    "meteor-rxjs": "^0.4.7",
    "moment": "^2.17.1",
    "reflect-metadata": "^0.1.9",
    "rxjs": "^5.5.6",
    "sharp": "^0.19.0",
    "zone.js": "^0.8.20"
  },
  "devDependencies": {
    "@types/meteor": "^1.3.31",
    "@types/meteor-accounts-phone": "0.0.5",
    "@types/meteor-collection-hooks": "^0.8.0",
    "@types/meteor-publish-composite": "0.0.32",
    "@types/underscore": "^1.7.36",
    "meteor-typings": "^1.3.1",
    "typescript": "^2.6.2"
  }
}

tsconfig.json
{
  "compilerOptions": {
    "allowSyntheticDefaultImports": true,
    "baseUrl": ".",
    "declaration": false,
    "emitDecoratorMetadata": true,
    "experimentalDecorators": true,
    "lib": [
      "dom",
      "es2015"
    ],
    "module": "commonjs",
    "moduleResolution": "node",
    "sourceMap": true,
    "target": "es5",
    "skipLibCheck": true,
    "stripInternal": true,
    "noImplicitAny": false,
    "types": [
      "meteor-typings",
      "@types/underscore",
      "@types/meteor-accounts-phone",
      "@types/meteor-publish-composite",
      "@types/meteor-collection-hooks"
    ]
  },
  "include": [
    "client/**/*.ts",
    "server/**/*.ts",
    "imports/**/*.ts"
  ],
  "exclude": [
    "node_modules"
  ],
  "compileOnSave": false,
  "atom": {
    "rewriteTsconfig": false
  }
}

If you are using angular-compiles (not angular2-compilers) you need rewrite styles import from {}node_modules to ../../node_modules
And in Ionic project with updated packages you cannot use old version of angular2-google-maps, it need to be replaced with '@agm/core'
https://github.com/SebastianM/angular-google-maps

@impcyber  thx for the reply, but could you clarify 😕
You mean style import in component templates? At the moment we use statements like:
import template from "./app.component.html";
import style from "./app.component.scss";

@Component({
  selector: "app",
  template,
  styles: [ style ]
})

Is this what you meant?

@pbureau Unfortunately, if I correctly understood the angular-compiler are oriented to work like AngularCLI and the import templates\styles like modules there does not work, only templateUrl and styleUrls work or inline declartion available.
Here is an example: https://github.com/Urigo/angular-meteor-base
Here is an Urigo comment about: Goldstehttps://forums.meteor.com/t/meteor-1-5-dynamic-imports-with-angular-2-typescript/35232/13

@impcyber the imports for templates\styles seems to be my problem 😕
The point I don't understand is this mechanism was working with angular2-compilers. Could it be broken by the switch to angular-compilers ?
In the thread you pointed, Urigo is not saying anything about the import mechanism isn't he?

@pbureau Yes, there is nothing about import mechanism. But looking at modern examples, no matter what you use MeteorCLI or angular-cli, they use templateUrl and styleUrls both.
And i was a bit discouraged, that repo angular2-compilers forward to angular-compilers:
https://github.com/Urigo/angular2-meteor/
But, as i understood this is a new rule for angular compilers:
https://github.com/Urigo/angular-meteor/issues/1599#issue-228558817

But templateUrl and styleUrls is the recomended by angular team way to import html/css.

@impcyber thx, I think you are right, this is the new way to declare templates and styles, and it changed with the angular-compilers switch.
As far as I understand the import template from "./app.component.html"; support was provided by the angular2-meteor package but it is deprecated, and it does not work with the new compiler anyways.

@pbureau Yes, looks so

Tried again a lot of combinations.
The only one I managed to work good is:
angular-meteor/examples/MeteorCLI/bare/ in this rapository

I finally managed to get my app working upgrading to angular-compilers from angular2-compilers, and with Meteor <IP_ADDRESS>
The switch to Meteor 1.6.1 seems impossible at the moment (not with my current knowledge of the stack anyways).
The critical part for me was to understand that if you just add  angular-compilers to your project, Meteor will automatically install the version 0.2.9_2, which is broken
You need to make sure you are using the following versions (in .meteor./versions):

<EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS>

I'm using with <IP_ADDRESS>:
<EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS>
And all works fine.
How do you determine that 0.2.9_2 is broken?

@impcyber well when I use the same versions as you are, my project does not compile at all, I get an endless stream of errors when the app is building. I will give it another try... can you share your complete .meteor/versions file?

@pbureau paste the first error message here
full versions list:
<EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS>

@impcyber  here is the first errors I get when compiling with version 0.2.9_2:

client/imports/app/kyo-buyer/aisles/grid/aisle/aisle.component.ts (17, 1): Argument of type '{ selector: string; templateUrl: string; host: { 'class': string; }; styleUrl: string; }' is not assignable to parameter of type 'Component'.
Object literal may only specify known properties, and 'styleUrl' does not exist in type 'Component'.
client/imports/app/kimayo-admin-panel/admin-section-buyer-info/admin-buyer-aisles/admin-buyer-aisles.component.ts (13, 1): Argument of type '{ selector: string; templateUrl: string; styleUrl: string; }' is not assignable to parameter of type 'Component'.
Object literal may only specify known properties, and 'styleUrl' does not exist in type 'Component'.
client/imports/app/kimayo-admin-panel/admin-section-buyer-info/admin-dialog-aisle/admin-dialog-aisle.component.ts (11, 1): Argument of type '{ selector: string; templateUrl: string; styleUrl: string; }' is not assignable to parameter of type 'Component'.
Object literal may only specify known properties, and 'styleUrl' does not exist in type 'Component'.

One strange thing in you versions file, it is missing the<EMAIL_ADDRESS>module, is it something you have removed on purpose?

@pbureau as yout can see here https://angular.io/api/core/Component there is not 'styleUrl: string' argument, there is a 'styleUrls: string[]' and it must be an array of strings.
I don't have es5-shim, because i don't need compatibility with legacy browsers

@impcyber damn it... you are right :astonished:
I have been too quick when I changed the styles imports (I will never understand why js is so permissive, this should have broken my code). Actually the new config is a lot less permissive (which is good), but now it is like the compiler will not recognize the meteor typings and I get a bunch of:
server/accounts/auth.ts (2, 26): Cannot find module 'meteor/accounts-base'.
server/accounts/auth.ts (48, 5): Cannot find name 'process'.
server/accounts/emails.ts (2, 26): Cannot find module 'meteor/accounts-base'.
server/accounts/emails.ts (4, 24): Cannot find module 'meteor/base64'.
server/accounts/emails.ts (19, 61): Cannot find name 'Assets'.
server/accounts/emails.ts (20, 65): Cannot find name 'Assets'.
server/accounts/users.ts (36, 21): Cannot find name 'Mongo'.
server/accounts/users.ts (58, 12): Cannot find name 'Accounts'.
server/fake-data/fake-products.ts (53, 10): Cannot find name 'Accounts'.
server/imports/server-main/main.ts (13, 10): Cannot find name 'Accounts'.
server/imports/server-main/main.ts (26, 7): Cannot find name 'Accounts'

@pbureau did you installed @types/*  for packages and include it to tsconfig.json in compilerOptions.types: [ ... ]?

@impcyber in my package.json I have:
    "@angular/compiler-cli": "5.1.3",
    "@types/chai": "4.0.8",
    "@types/meteor": "1.4.12",
    "@types/mocha": "2.2.44",
    "@types/sinon": "4.0.0",

In tsconfig.json:
 "types": [
    "typings.d",
    "@types/node",
    "@types/meteor",
    "@types/hammerjs"
  ],

But actually, it is like none of the @types modules are loaded by the compiler. I also get a:
both/collections/images.collection.ts (9, 22): Cannot find module 'path'

But path is declared in @types/node

@pbureau
add to package.json:
@types/node
@types/hammerjs

then run npm install

@impcyber sry I edited my comment, I actually have @types/node installed :-(

@pbureau Anyway, update @types/node to version ^9.4.6and @types/meteor to version ^1.4.13
And if not help, remove node_modules and run npm install

@impcyber thx for the tip, upgrading is not solving the issue. It must be something with my imports, or the declaration file, because: import { Meteor } from 'meteor/meteor'; will work, but import { Accounts } from 'meteor/accounts-base'; will generate the error...

@pbureau the account-base typing is built-in meteor https://github.com/DefinitelyTyped/DefinitelyTyped/blob/master/types/meteor/accounts.d.ts#L131
it's too strange, maybe something wrong with imports.
for test, try to add temporary this code in typings.d.ts (will this change the error message?):
declare module "meteor/accounts-base" {
    module Accounts {}
}

@impcyber I tried to add the declaration in typings.d.ts, and it does not change the error. It is almost as if the account-base package was completely ignored. I checked the<EMAIL_ADDRESS>is present and correct.

@pbureau did you restart your IDE and run meteor again after this changes?

regarding this issue and #1884, i confirm angular-compilers is working with:
<EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS>
I had to rebuild a project using the angular-meteor example bare/ project as a starting point, I believe my problems were related with the directory structure we have been using so far, even though the exact cause of the problem is still unclear to me.
@impcyber thx for the support, it seems there is not much activity going on at the moment....

I had exactly the same problems but got it working.
Maybe it helps someone else: https://gitlab.fechner.net/mfechner/angularcli-meteor


Missing trailing slash

Hello, I like using this package as a simple server inside my projects folder and as such I always use the server's filetree to navigate to the project I like to load in the browser. However, I recently updated and now there is always a missing slash at the end.
For example when I click on "project1" folder, it loads "localhost:8000/project1" instead of "localhost:8000/project1/". This results in 404 errors for all javascript and css files.

i've come across this issue before, it's an issue in the underlying module supplying the directory-browsing feature.. will look into it, thanks.

Oops, I forgot about this issue. Either way, thanks for this useful tool. I hope you figure out this issue.

this is resolved in v2 which is in progress and available for preview.. any feedback welcome.

Hm, annoyingly enough, one of the node modules is giving me an error, requiring node v7.6+
--> https://github.com/koajs/bodyparser/issues/66
I'll have to check this later

yeah, sorry about that - koa is node v7.6 at the minimum these days (for async/await support).

Alright, I installed the latest node. Seems to work!
Forcing the new node version on other users could be problematic though, but that's up to you...

glad it works! I didn't choose to force the latest node on users - this constraint was forced upon by the Koa project unfortunately. I don't agree with it but don't have much choice.

fixed and released in v2.0.0

I'd like to report that this issue reappeared on the version 3.0 (reproduced on Win 10, 3.0.4). 2.0 works fine for me.
Fragment of listing html that I see:

<a href="http://<IP_ADDRESS>:8000/">~ /

<a href="http://<IP_ADDRESS>:8000/node_modules" class="icon icon-directory" title="node_modules">node_modules2019-7-15 2:59:38 PM

<a href="http://<IP_ADDRESS>:8000/test" class="icon icon-directory" title="test">test2019-7-15 3:00:32 PM

<a href="http://<IP_ADDRESS>:8000/package-lock.json" class="icon icon icon-json icon-application-json" title="package-lock.json">package-lock.json568022019-7-15 2:59:38 PM

Hmm, i can't reproduce this on macOS and in it theory it should not behave any differently on Windows.. I will try and reproduce it on Windows later.

I can't reproduce on Windows either. I installed local-web-server v3.0.4 on Windows 10 (version 1809), created a folder, a sub-folder and some files and could navigate the sub-folders without issue.
Could you post a specific, failing reproduction case please which I can use to see and debug the issue.

and could navigate the sub-folders without issue

Let me note that basic navigation indeed works. The problem is that it opens the folder "localhost:8000/project1" instead of "localhost:8000/project1/" as stated in the original issue. It breaks relative urls for assets referenced by index.html in localhost:8000/project1.
If you still cannot reproduce it, I guess I can indeed commit the repo, but the only thing I did was to:

mkdir repro
cd repro
npm install local-web-server
mkdir test
node_modules.bin\ws.cmd

Open <IP_ADDRESS>:8000 and observe no trailing slash for the projects.

It breaks relative urls for assets referenced by index.html in localhost:8000/project1.

I can't reproduce this, relative links work fine for me. I'm sorry to keep asking but I need a specific reproduction case which i can run and see failing. Please post your index.html code which contains a relative URL link which fails.
Locally, I created an index.html which displays images loaded via relative URLs and everything loads correctly.

Sure:

https://github.com/sergebat/lws-reproduce-56
npm install
run.cmd

Opened localhost:8000 in chrome and saved resulting listing as:
https://github.com/sergebat/lws-reproduce-56/blob/06c5a0cd919201855f71e695afbeaf2901dd7e17/listing directory _.html#L347
Let me try the same on osx/ubuntu a bit later.

Great, thanks for that. Yes, now I see what you mean. It's an issue on mac too.
It looks like I will need to fork and patch serve-index again (which was how I solved this back in 2017).
Will fix ASAP.

Fixed and released in lws-index v1.0.5. Please reinstall local-web-server to pick up the change.
If you find any more issues, please let me know. 👍


Plugin template

Issue #9
This still need some work, especially in adding tests and fixing path delimiteres to use system ones, not the "/", but please, take a look, if you have any suggestions/remarks

Thanks!

:+1:


Error reconstructing vector - Does the column factory string end with IDMap2

I am using Python.
I create a vss0 table as follows:
con.execute("""
create virtual table vss_snippets using vss0(
  dragon_embedding(768) factory="Flat,IDMap2" metrict_type=INNER_PRODUCT
);
""")

I then populate it with embeddings (I unit normalize my vectors like so: faiss.normalize_L2(ctx_emb)):
con.execute("insert into vss_snippets(rowid, dragon_embedding) values (?, ?)", [row_id, ctx_emb[idx].astype(np.float32).tobytes()])

But when I try to pull anything out doing the following:
con.execute("""
select dragon_embedding from vss_snippets where rowid==1
""").fetchone()

I get an error:
---------------------------------------------------------------------------
OperationalError                          Traceback (most recent call last)
Cell In[47], line 1
----> 1 a = con.execute("""
      2 select dragon_embedding from vss_snippets where rowid==1
      3 """).fetchone()

OperationalError: Error reconstructing vector - Does the column factory string end with IDMap2? Full error: Error in void faiss::IndexIDMap2Template<IndexT>::reconstruct(faiss::idx_t, typename IndexT::component_t*) const [with IndexT = faiss::Index; faiss::idx_t = long int; typename IndexT::component_t = float] at /home/runner/work/sqlite-vss/sqlite-vss/vendor/faiss/faiss/IndexIDMap.cpp:236: key 1 not found

Thank you so much for your help 🙏
Ultimately, I would like to be able to query for closest vectors like so:
con.execute("""
select rowid, distance
from vss_snippets
where vss_search(
  embedding,
  ?
)
limit 100;
""", [embedding.astype(np.float32).tobytes()])

After your insert into statement, try running con.commit(). The vss0 tables do some non-standard things with transactions, and requires a commit in order to save inserted data correctly.
That being said, the Does the column factory string end with IDMap2 suggestion is not necessary and confusing, I'll work to change that. You don't need the explicit factory="Flat,IDMap2" argument in your case, you can remove it to make it a bit easier to understand

Thank you so much for your help! 🙂🙏 Really appreciate it!


[Question]when openyurt can support 1.19+?

we use k8s 1.19 and above, but in docs, openyurt only support less then 1.14, when openyurt can support 1.19+?

Hi @yudar1024, we won't support 1.19 for the next release.
We have not run OpenYurt with Kubernetes 1.19 in production environments yet, but I have used OpenYurt with Kubernetes 1.19 locally for a while and everything looks just fine. If you don't mind, you can try out running OpenYurt with 1.19.

@yudar1024 ，Thank you for filing issue.
We have verified that we have supported version 1.20.I can help you modify the local code to achieve.


feat(Storage):  AWSS3StoragePlugin custom prefix resolver

Issue #, if available:
Description of changes:
Check points:

[ ] Added new tests to cover change, if needed
[ ] All unit tests pass
[ ] All integration tests pass
[ ] Documentation update for the change if required
[ ] PR title conforms to conventional commit style

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Codecov Report

Merging #1306 (afdbcda) into main (9c3fcf9) will increase coverage by 0.00%.
The diff coverage is 81.81%.

:exclamation: Current head afdbcda differs from pull request most recent head f0715ca. Consider uploading reports for the commit f0715ca to get more accurate results

@@           Coverage Diff           @@
##             main    #1306   +/-   ##
=======================================
  Coverage   60.14%   60.15%
=======================================
  Files         653      655    +2
  Lines       19472    19481    +9
=======================================
+ Hits        11711    11718    +7
- Misses       7761     7763    +2

Flag
Coverage Δ

API_plugin_unit_test
63.60% <ø> (+0.20%)
:arrow_up:

AWSPluginsCore
76.22% <ø> (ø)

Amplify
48.42% <ø> (+0.04%)
:arrow_up:

Analytics_plugin_unit_test
73.41% <ø> (ø)

Auth_plugin_unit_test
82.31% <ø> (ø)

DataStore_plugin_unit_test
74.75% <ø> (ø)

Predictions_plugin_unit_test
33.51% <ø> (ø)

Storage_plugin_unit_test
57.38% <81.81%> (-0.35%)
:arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files
Coverage Δ

...uest/StorageRequestOptions+CustomKeyResolver.swift
0.00% <0.00%> (ø)

...oragePlugin/Support/Utils/StorageErrorHelper.swift
3.12% <0.00%> (+0.03%)
:arrow_up:

...gin/Support/Utils/StorageRequestUtils+Getter.swift
93.54% <ø> (-0.74%)
:arrow_down:

...WSS3StoragePlugin/Request/AWSS3PluginOptions.swift
88.88% <88.88%> (ø)

.../Operation/AWSS3StorageDownloadDataOperation.swift
72.05% <100.00%> (+1.22%)
:arrow_up:

.../Operation/AWSS3StorageDownloadFileOperation.swift
75.00% <100.00%> (+1.47%)
:arrow_up:

...Plugin/Operation/AWSS3StorageGetURLOperation.swift
88.88% <100.00%> (+3.47%)
:arrow_up:

...gePlugin/Operation/AWSS3StorageListOperation.swift
88.37% <100.00%> (+2.95%)
:arrow_up:

...Plugin/Operation/AWSS3StorageRemoveOperation.swift
88.63% <100.00%> (+3.52%)
:arrow_up:

...in/Operation/AWSS3StorageUploadDataOperation.swift
78.66% <100.00%> (+1.74%)
:arrow_up:

... and 7 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9c3fcf9...f0715ca. Read the comment docs.


Role-based access control

Thanks for wanting to add a feature to Kubernetes!  You will be responsible for guiding
your feature through completion, and asking the right people for approvals.
Large features typically go through three stages: Alpha, Beta, and Stable
Each stage requires various approvals from various teams.
You can use the checkboxes below to
track your progress.  You can delete the text above once you have read it.  Please keep the checklist.

[ ] Before Alpha

[ ] Design Approval

[ ] < 1 page PR description of the design. [advice for design description]  PR-NUMBER
[ ] Design doc under docs/proposals.  PR-NUMBER
[ ] Initial API review (if API).  Maybe same PR as design doc. PR-NUMBER

Any code that changes an API (/pkg/apis/...)
cc @kubernetes/api

[ ] Write (code + tests + docs) then get them merged.  ALL-PR-NUMBERS

[ ] Code needs to be disabled by default.   Verified by code OWNERS
[x] Minimal testing (kubernetes/kubernetes#26753)
[x] Minimal docs (kubernetes/kubernetes.github.io#643)

cc @kubernetes/docs on docs PR
cc @kubernetes/feature-reviewers on this issue to get approval before checking this off
New apis: Glossary Section Item in the docs repo: kubernetes/kubernetes.github.io

[ ] Update release notes

[ ] Before Beta

[ ] Testing is sufficient for beta
[ ] User docs with tutorials
- Updated walkthrough / tutorial in the docs repo: kubernetes/kubernetes.github.io
- cc @kubernetes/docs on docs PR
- cc @kubernetes/feature-reviewers on this issue to get approval before checking this off
[ ] Thorough API review

cc @kubernetes/api

[ ] Before Stable

[ ] docs/proposals/foo.md moved to docs/design/foo.md
- cc @kubernetes/feature-reviewers on this issue to get approval before checking this off
[ ] Soak, load testing
[ ] detailed user docs and examples

cc @kubernetes/docs
cc @kubernetes/feature-reviewers on this issue to get approval before checking this off

FEATURE_STATUS is used for feature tracking and to be updated by @kubernetes/feature-reviewers.
FEATURE_STATUS: IN_DEVELOPMENT
More advice:
Design

Once you get LGTM from a @kubernetes/feature-reviewers member, you can check this checkbox, and the reviewer will apply the "design-complete" label.

Coding

Use as many PRs as you need.  Write tests in the same or different PRs, as is convenient for you.
As each PR is merged, add a comment to this issue referencing the PRs.  Code goes in the http://github.com/kubernetes/kubernetes repository,
and sometimes http://github.com/kubernetes/contrib, or other repos.
When you are done with the code, apply the "code-complete" label.
When the feature has user docs, please add a comment mentioning @kubernetes/feature-reviewers and they will
check that the code matches the proposed feature and design, and that everything is done, and that there is adequate
testing.  They won't do detailed code review: that already happened when your PRs were reviewed.
When that is done, you can check this box and the reviewer will apply the "code-complete" label.

Docs

[ ] Write user docs and get them merged in.
User docs go into http://github.com/kubernetes/kubernetes.github.io.
When the feature has user docs, please add a comment mentioning @kubernetes/docs.
When you get LGTM, you can check this checkbox, and the reviewer will apply the "docs-complete" label.

it’s astonishing how much checklists on github make me want to do whatever it takes to complete them

An update on this issue for alpha.

Most of the design was directly lifted directly from the openshift documentation. We skipped over a formal proposal.
The initial API was reviewed and added in kubernetes/kubernetes#24900
The API group, an authorizer, and a small amount of unit tests where added in kubernetes/kubernetes#25634

TODO before alpha release

Complete testing by adding integration tests
Add minimal documentation to kubernetes/kubernetes.github.io
Write release notes

@erictune As we can't update this issue I think you have to check the boxes based on @ericchiang's comment https://github.com/kubernetes/features/issues/2#issuecomment-222202448

Ping @erictune cc @ericchiang

Integration tests here: https://github.com/kubernetes/kubernetes/pull/26753
Docs here: https://github.com/kubernetes/kubernetes.github.io/pull/631
Also there were a couple small fixes that need lgtms:

https://github.com/kubernetes/kubernetes/pull/26984
https://github.com/kubernetes/kubernetes/pull/26975
https://github.com/kubernetes/kubernetes/pull/26924

The API group name "rbac.authorization.k8s.io/v1alpha1" is really long.  Perhaps for Beta or GA we can shorten it somehow.

For beta, we need to:

[ ] have a default set of roles, and docs about those roles.
[ ] examples of updating a role to add a user to it, remove a user from it, using kubectl.
[ ] we need to decide what a service-account's default role is, which will be a breaking change, since it is not going to be the current effectively root role it has.
[ ] Rename RBAC 'subject' to 'subjects'. (#26924)
[ ] on by default for kube-up, and all GCE e2e tests work with RBAC enabled.
[ ] get feedback on whether it works well from large on-prem customers.

A couple other notes (not necessarily for beta)

Add some basic caching mechanisms to the authorizer implementation. It's currently using a naive implementation that just queries the API group each time.
Get feedback on the bootstrapping procedure (--authorizer-rbac-super-user)
Get feedback on the privilege escalation checks. Do these make sense, should an admin be able to turn them off or get around them some other way, etc.)

Not sure I'd consider choosing a default role for service accounts in rbac a breaking change. Authorizer settings have always been able to limit service account permissions.

Hi @erictune will RBAC in 1.3 have the ability to make policy decisions based on the attributes in the requested API object? Such as specifying what secrets can a pod mount as a volume? Looking over the code seems the answer is no, but I'd like to confirm. Thanks!

@guoshimin no. For alpha RBAC will only deal with top level objects. No field level authorization.
@olegshaldybin has a large proposal in kubernetes/kubernetes#27330. You may want to take a look at the discussion there.

no, RBAC is object-level, not field-level.

Also realized that we don't have garbage collection (cleaning up role bindings to deleted roles). This would probably be something good to add to the beta release.

I'd like to see an intent-based, idempotent API for binding roles to subjects.  Something where I can post: "bind role/foo to user/bar" or "delete role/foo from group/bar" and not have to worry about the details of exactly which named binding needs to be mutated.
I think we should also consider a way to select which roles and subjects a given subject is allowed to bind.  Right now, Jane in namespace J can forcibly add David to her namespace and there's nothing he can do about it.  In addition, a permission granting role has value since the person handing out permissions may not want to have all the powers he's granting.

An intent-based API for managing policy sounds great. Just out of curiosity - Are there existing intent-based APIs in K8s?

Request for a non-flag way to turn off bootstrapping mode (https://github.com/kubernetes/kubernetes/pull/25634#issuecomment-231486319) @jimmycuadra

I'm a little confused by that comment.
@jimmycuadra why do you need to turn this off the bootstrapping flag in the first place? I don't actually see anything in that post which explained that.

In our setup, the systemd unit file that starts apiserver is immutable, so we don't necessarily want the user specified by --authorization-rbac-super-user to have unlimited access for the foreseeable future. We want a way to bootstrap RBAC roles and bindings and then disable the initial user's unlimited access without having to change the set of arguments that the apiserver is started with.

@jimmycuadra And you couldn't use systemd's EnvironmentFile pointing to a file that is mutable to change the flags? That achieves the immutable systemd unit file with the flags without changing the scope of this feature. Could that work?

There are workarounds, but ultimately we'd like a way to do it without having to mutate files on the host system. Moving the flags to an environment file doesn't make it any better for us, we still have to modify files on the host which otherwise would've been provisioned when the system was first launched and then not changed again. The one exception we have right now is for updating TLS certs/keys, and we have a special mechanism for that, but we'd rather not make that more complicated by adding more exceptions to the rule if possible.
(We should continue this discussion on an issue on the kubernetes repo so as not to add more noise to this thread.)

@erictune @ericchiang as this feature's marked with Milestone 1.5, should we change the "alpha-in-1.3" label to another one?

@idvoretskyi it was alpha in 1.3, this is currently tracking targets for beta.

@ericchiang just to confirm - does this feature target beta for 1.5?

@ericchiang just to confirm - does this feature target beta for 1.5?

It's going to be close.  I'm actively working on it, but here's the list:

Evaluate performance impact.  I think the last pull needed before a check is https://github.com/kubernetes/kubernetes/pull/34047.  @ericchiang/CoreOS signed up for the testing.
Make the user experience for it reasonable.  Default roles and bindings, admin level access for bootstrapping.  This is moving forward and will be helped by 3.
Use RBAC for at least some controllers to prove the principle.  This will be relying on some authentication privileged bootstrap identities based on certificates.  @dims is helping with this as part of the "shut off the insecure port" work.
Turn RBAC on an e2e run in CI.  This can't realistically be done until 3 is complete.

@kubernetes/sig-auth Anyone want to add/remove from the list?

I'd adjust 3:
Kube-controller-manager can be root, which is the case today for ABAC.
We would need to do something to tweak the perms for the default service
account in kube-system so that addons have the permissions
they need.  Read-all-namespace perms would be fine as a start.
I'd like 4 to cover most GCE e2e tests.
We should have an idea of how to announce that RBAC is the default for
kube-up and ask the minikube people to consider having an option for it.
On Thu, Oct 13, 2016 at 7:47 AM, David Eads<EMAIL_ADDRESS>wrote:

@ericchiang https://github.com/ericchiang just to confirm - does this
feature target beta for 1.5?
It's going to be close. I'm actively working on it, but here's the list:

Evaluate performance impact. I think the last pull needed before a
check is kubernetes/kubernetes#34047
https://github.com/kubernetes/kubernetes/pull/34047.
@ericchiang/CoreOS signed up for the testing.
Make the user experience for it reasonable. Default roles and
bindings, admin level access for bootstrapping. This is moving forward and
will be helped by 3.
Use RBAC for at least some controllers to prove the principle. This
will be relying on some authentication privileged bootstrap identities
based on certificates. @dims https://github.com/dims is helping with
this as part of the "shut off the insecure port" work.
Turn RBAC on an e2e run in CI. This can't realistically be done
until 3 is complete.

@kubernetes/sig-auth https://github.com/orgs/kubernetes/teams/sig-auth
Anyone want to add/remove from the list?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/kubernetes/features/issues/2#issuecomment-253535360,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AHuudpXq9QAvUhl-9lqGza1Nm7Tygy5iks5qzkSZgaJpZM4IWkom
.

@deads2k @erictune thank you.

We at eBay have set up a RBAC Policy list for the complete cluster controllers.
https://github.com/uruddarraju/kubernetes-rbac-policies/tree/master

And also, from my experience after coming up with all the policies needed, I think there is a need for explicitDeny on a particular set of Resources with in an APIGroup.
This way as an admin, I will be able to give access to all resources with in a namespace except for resourceQuotas to a user deploying their applications within the namespace. This gives me enough control over the cluster utilization.
Otherwise, my policy would be very tough to express, and I have to explicitly list down all resources except resourceQuotas, similar to what i did here: https://github.com/uruddarraju/kubernetes-rbac-policies/blob/master/roles/reader-all.yaml

I wanted the resourceQuotas to be at the Cluster level for this reason.
On Thu, Oct 13, 2016 at 12:03 PM, Uday Ruddarraju<EMAIL_ADDRESS>wrote:

And also, from my experience after coming up with all the policies needed,
I think there is a need for explicitDeny on a particular set of Resources
with in an APIGroup.
This way as an admin, I will be able to give access to all resources with
in a namespace except for resourceQuotas to a user deploying their
applications within the namespace. This gives me enough control over the
cluster utilization.
Otherwise, my policy would be very tough to express, and I have to
explicitly list down all resources except resourceQuotas, similar to what i
did here: https://github.com/uruddarraju/kubernetes-rbac-
policies/blob/master/roles/reader-all.yaml
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/kubernetes/features/issues/2#issuecomment-253607573,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AHuudjoCfcevq7Acmqj8p5N_SpY4dpBHks5qzoCCgaJpZM4IWkom
.

I think enumerated policy is almost always the right way to go. The meaning of * - foo changes as new resources are added, without any decision on the policy maker's part. The fact that a resource is being omitted means the role isn't intended to grant unlimited access, but a "everything except foo" rule does just that for every future resource, no matter how powerful.

If we want to allow user-installed thirdpartyresources then some kind of
wildcard is needed?
On Oct 13, 2016 3:52 PM, "Jordan Liggitt"<EMAIL_ADDRESS>wrote:
I think enumerated policy is almost always the right way to go. The meaning
of * - foo changes as new resources are added, without any decision on the
policy maker's part. The fact that a resource is being omitted means the
role isn't intended to grant unlimited access, but a "everything except
foo" rule does just that for every future resource, no matter how powerful.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/kubernetes/features/issues/2#issuecomment-253661686,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AHuudppANx75POGVm_1e2MBLAsYlUY_Vks5qzrYjgaJpZM4IWkom
.

If we want to allow user-installed thirdpartyresources then some kind of
wildcard is needed?

ThirdPartyResources are cluster-scoped objects which change the discovery doc and affect every API client of the cluster.  Any user with the power to create a thirdpartyresource ought to have the power to create ClusterRoles to go with them.  That allows a TPR provider to give a yaml file will which create both so that we can have strict enumerations.
Also, you have no way of knowing ahead of time which TPRs are privileged and which are not.

But there were discussions about a namespaced version of TPR.  I think we
will need one.  We will need an authz story for it.
On Oct 20, 2016 8:21 AM, "David Eads"<EMAIL_ADDRESS>wrote:

If we want to allow user-installed thirdpartyresources then some kind of
wildcard is needed?
ThirdPartyResources are cluster-scoped objects which change the discovery
doc and affect every API client of the cluster. Any user with the power to
create a thirdpartyresource ought to have the power to create ClusterRoles
to go with them. That allows a TPR provider to give a yaml file will which
create both so that we can have strict enumerations.
Also, you have no way of knowing ahead of time which TPRs are privileged
and which are not.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/kubernetes/features/issues/2#issuecomment-255137977,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AHuudk4udgzgWmBEa_5zAWojBrEb4t9Mks5q14cLgaJpZM4IWkom
.

types that only exist within one namespace? that's... concerning. TPR defines a type cluster-wide, the instances of which are already namespaced.

But there were discussions about a namespaced version of TPR.  I think we
will need one.  We will need an authz story for it.

I think that would actually be implemented as a separate API server running inside of the namespace.  Project admins shouldn't be able to mutate discovery docs and having different discovery docs per namespace is weird.

what is the story as a client for what you described, @deads2k - is this api server federated with the main api?

what is the story as a client for what you described, @deads2k - is this api server federated with the main api?

A project-admin cannot be allowed to modify the main API server.  They would need to create a route which pointed to their new API server and selectively choose which one they wanted to talk to.  We can talk about trying to make a smarter client that can do this, but a project-admin should never have the power to get the main API server to proxy requests or discovery information to a pet project.

Do users on openshift write custom controllers that use TPR for storage and
are accessible via Kubectl?
On Thu, Oct 20, 2016 at 8:28 AM, David Eads<EMAIL_ADDRESS>wrote:

But there were discussions about a namespaced version of TPR. I think we
will need one. We will need an authz story for it.
I think that would actually be implemented as a separate API server
running inside of the namespace. Project admins shouldn't be able to mutate
discovery docs and having different discovery docs per namespace is weird.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/kubernetes/features/issues/2#issuecomment-255140123,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AHuuds1iecFnuCswHHcq8WeKnMj0oUjgks5q14i2gaJpZM4IWkom
.

Do users on openshift write custom controllers that use TPR for storage and
are accessible via Kubectl?

Custom controllers, yes.  We have a couple "add-ons" related to our online offering that don't live in-tree with origin and so they have to define their own roles and the like.
TPRs, no.  Knowing how fragile they are, we've avoided using them they work well.  See https://github.com/kubernetes/features/issues/95 for a consolidated list.

Types are still alpha for 1.5

Ping. Is there a docs PR for this?

Another ping. Docs?

docs for the current state already exist at http://kubernetes.io/docs/admin/authorization/

I don't see the new default roles in the documentation. Default roles were mentioned in the 1.5 release notes.

@ericchiang @deads2k which stage does this feature target for 1.6 (alpha/beta/stable)?

@ericchiang @deads2k which stage does this feature target for 1.6 (alpha/beta/stable)?

beta

@jimmycuadra docs for 1.6 in progress at https://github.com/kubernetes/kubernetes.github.io/pull/2618 (preview at https://deploy-preview-2618--kubernetes-io-master-staging.netlify.com/docs/admin/authorization/rbac/)

@liggitt @ericchiang @deads2k please, provide us with the release notes and documentation PR or link at the features spreadsheet.

@erictune will RBAC be default in 1.8 clusters onwards as it moves to stable?

@cjcullen

@apsinha when we tried to turn on RBAC in kube-up, that change was reverted due to concerns around backward compatibility. Turning on RBAC means no API access by default, and that breaks any tutorials or instructions that target old clusters which historically haven't turned on API authorization.
We're working with groups like SIG apps to get more apps to ship with RBAC profiles, and many install tools, such as kubeadm, already deploy RBAC enabled clusters, but I image there will still be the same concerns about making it the default.

@ericchiang that means - RBAC won't be enabled by default in 1.8, right?

@ericchiang What about enabling RBAC by default but disabling it in the cases where you have to?
There is a pain threshold when enabling it, but I think it's worse to not enable this in the future.
There are easy commands to effectively turn it off but still have it enabled on cluster-level.
That is the approach I would prefer; default on, document how to make a permissive binding for workloads running in-cluster (the primary error source) and still let folks opt-out if they want.
TL;DR; This is IMO the best time to switch generally. kubeadm did this in v1.6 and it has worked pretty well.

It's on by default in some deployments (gke/gce, kubeadm). It should continue to be up to individual deployments to enable.

Supposed we made RBAC on by default.  What would the instructions look that
we would give users who wanted to simulate the old behavior for backwards
compatibility reasons.
Is it really just as simple as this?:
#!/bin/bash
Grants cluster-admin permissions to all current service accounts, to
simulate old pre-RBAC behavior.

nses=$(kubectl get namespaces -o name | cut -f 2 -d "/")
for ns in $nses
do
sas=$(kubectl get sa -o name | cut -f 2 -d "/")
for sa in $sas
do
kubectl create clusterrolebinding backcompat-$RANDOM
--clusterrole=cluster-admin --serviceaccount=$ns:$sa
done
done
On Mon, Aug 14, 2017 at 7:09 AM, Jordan Liggitt<EMAIL_ADDRESS>wrote:

It's on by default in some deployments (gke/gce, kubeadm). It should
continue to be up to individual deployments to enable.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/kubernetes/features/issues/2#issuecomment-322200101,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AHuuduJStX7or18To3iT5Qrva2llFJ7Cks5sYFUGgaJpZM4IWkom
.

@ericchiang @deads2k @liggitt @kubernetes/sig-auth-feature-requests so, is this feature delivered as Beta or Stable for 1.8?
If it's not enabled by default, it can't be "stable" - we have to update the stage/* label.

If it's not enabled by default, it can't be "stable" - we have to update the stage/* label.

"enabled by default" by which deployment mechanisms?  The API is on by default, but the choice of what particular authorizer to use is a decision left up to the deployment mechanisms themselves.
In this case, its on in kubeadm and kube-up (https://github.com/kubernetes/kubernetes/pull/51367), so it is on, but moving forward you'll probably want to consider how to handle per-deployment choices with respect to stable.

If it's not enabled by default, it can't be "stable"

That is incorrect. Optional != unstable. The RBAC API is at v1, and the RBAC authorizer has been tested for correctness and at scale for performance, so the feature can accurately be described as stable.

hat is incorrect. Optional != unstable. The RBAC API is at v1, and the RBAC authorizer has been tested for correctness and at scale for performance, so the feature can accurately be described as stable.

@liggitt sorry about the wording confusion. I'm speaking about "stable" status as the feature definition, not about code stability.
We can't declare the feature as "stable" or "GA" if it's not available by default.

We can't declare the feature as "stable" or "GA" if it's not available by default.

It is available by default. It is not enabled by default.

I don't think "enabled by default" has anything to do with stability.

@smarterclayton again, it's not about the "code stability". Let's read " a stable feature" as "a GA feature".

This is an optional, GA and stable feature :)
(Thanks to @liggitt & the rest of sig-auth's great work!)

On 20 Sep 2017, at 15:41, Ihor Dvoretskyi<EMAIL_ADDRESS>wrote:
@smarterclayton again, it's not about the "code stability". Let's read " a stable feature" as "a GA feature".
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub, or mute the thread.

@luxas good, let's do it so.

There are multiple valid authorization options:
https://kubernetes.io/docs/admin/authorization/#authorization-modules

released as v1 and stable in 1.8, closing


Question: How to run a command at plugin installation?

Hi! I've got a simple question and hope you can help me.
I want to install F# plugins into vim. Unfortunately the documentation covers only vim-plug and not Vundle (which I'm using).
The installation with vim-plug looks like this:
Plug 'autozimu/LanguageClient-neovim', {
    \ 'branch': 'next',
    \ 'do': 'bash install.sh',
    \ }
Plug 'ionide/Ionide-vim', {
      \ 'do':  'make fsautocomplete',
      \}

How would a corresponding Vundle installation look like? I could not figure out how to do the branch and do parts of the installation.
Thx in advance!

Vundle doesn't have functionality for either specifying non-default branches or for running commands on installation. The closest functionality vundle provides is the ability to "pin"  a directory that you would be expected to manually clone. All the pin does is indicate to vundle that the runtimepath should include that directory.


curl: 7.54.1 -> 7.55.0

Motivation for this change
Update
Things done
Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers.

[X] Tested using sandboxing
(nix.useSandbox on NixOS,
or option build-use-sandbox in nix.conf
on non-NixOS)
Built on platform(s)

[X] NixOS
[ ] macOS
[ ] Linux

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
[X] Tested execution of all binary files (usually in ./result/bin/)
[X] Fits CONTRIBUTING.md.

This fixes three security holes so should have security label.
https://curl.haxx.se/docs/adv_20170809A.html (CVE-2017-1000101)
https://curl.haxx.se/docs/adv_20170809B.html (CVE-2017-1000100)
https://curl.haxx.se/docs/adv_20170809C.html (CVE-2017-1000099)
Should also have mass-rebuild label.

Maybe @globin or @fpletz want to cherry-pick this through staging first? I'll let you guys deal with it. If you rather have a staging PR, I can do that, too.

Please don't merge yet. I will test and merge to master because staging will probably not be merged into master soon.

Sounds good!

@fpletz staging is looking good right now, at least for x86_64-linux. https://hydra.nixos.org/jobset/nixpkgs/staging

Ok, pushed to staging.
@NeQuissimus Curl didn't build with your commit here because the devdoc output wasn't created. Fixed. ;)

@fpletz Ah, my bad! Thx for fixing it


Changed package name

Accidently overwrote andre_feature on main when i tried to merge through git.¨
I did:
git checkout main
git merge andre_feature main
I understand now that you do merging over GitHub + its git merge andre_feature not git merge andre_feature main
Lets see if this merge now works!

Seems to work....


Update Time Series Insights spec with GA features, including Operations.

Highlighted changes:

Add a GA spec
Fix the inheritance problems with EventSourceResource and its properties and parameters. This was based on the changes @mcardosos recently made, but in a way that kept the discriminator on the EventSourceCreateOrUpdateParameters.
Add new GA features, including operations, to both spec.
Changes have been tested by generating a CSharp client using the latest version of autorest.

There are no autorest linter errors.
This checklist is used to make sure that common issues in a pull request are addressed. This will expedite the process of getting your pull request merged and avoid extra work on your part to fix issues discovered during the review process.
PR information

[ ] The title of the PR is clear and informative.
[ ] There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For information on cleaning up the commits in your pull request, see this page.
[ ] Except for special cases involving multiple contributors, the PR is started from a fork of the main repository, not a branch.
[ ] If applicable, the PR references the bug/issue that it fixes.
[ ] Swagger files are correctly named (e.g. the api-version in the path should match the api-version in the spec).

Quality of Swagger

[ ] I have read the contribution guidelines.
[ ] My spec meets the review criteria:

[ ] The spec conforms to the Swagger 2.0 specification.
[ ] The spec follows the guidelines described in the Swagger checklist document.
[ ] Validation tools were run on swagger spec(s) and have all been fixed in this PR.

@ravbhatnagar new features

Sweet, thanks for the changes! The linter has some remaining errors (but as the bot shows, you've gotten rid of one, awesome!). Since you didn't introduce them with this PR, that's fine, just as always, raising awareness 😉

Looks good! signing off

No modification for AutorestCI/azure-sdk-for-node


Open to a more permissive license?

The MIT license is a lot more permissive. Would that be ok to use instead of GPL?

What benefits would both you and I gain from MIT over GPL?
I'd really like to see bugfixes and changes up-streamed into the project as much as possible, which is part of the reason I leaned towards GPL.

Would LGPL be a good compromise? I'm moving towards dynamic linking anyways

I know that at my company at least we only use MIT and Apache. In my experience, people are more likely to use your code if they are sure it won't cause legal problems, and as a result you are more likely to get PRs and contributions that way

Seems fair, I'll update my license branch and merge it into master

Project is now licensed under the MIT license


cmd/dist, remotes: break out docker resolver

Allow usage of the experimental docker resolver as a package. There are
very few changes to the consuming code, demonstrating the effectiveness
of the abstraction. This move will allow future contributions to a more
featured resolver implementation.
Signed-off-by: Stephen J Day<EMAIL_ADDRESS>cc @ijc25

LGTM


Installing Correlation package

Hi,
I wanted to install the correlation package using Cuda 9 and Pytorch 0.4 but I found this error:
"119 | #error -- unsupported GNU version! gcc versions later than 6 are not supported!"
So I tried installing older version of gcc but I couldent (The OS didnt allow installing old version)
My ubuntu is version 20 (Kubuntu).
Regards,
Ali

According to my experience, provided correlation package only supports PyTorch 0.4.1. I install it under Ubuntu 16.04, and my gcc version is 5.4.0. I think you can try to search for other implementation of the correlation layer to replace it.

Thanks for your response. From ubuntu 18, gcc version 5.4 is not supported anymore (I have managed to run gcc version 5 before but that was very challenging). If the correlation package support newer version of gcc, that would widen the reproducibility of the work.

Please refer to Pytorch Correlation module. This module supports newer versions of PyTorch, such as 1.2 and so on.

Looking at the link below I was able to successfully run the following command: pip install spatial-correlation-sampler
How do I get your program to work?
https://github.com/ClementPinard/Pytorch-Correlation-extension

import torch
from spatial_correlation_sampler import SpatialCorrelationSampler

# define a correlation module
correlation_sampler = SpatialCorrelationSampler(1, 9, 1, 0, 1)

out = correlation_sampler(input1, input2)

# reshape output to be a standard 2D tensor
b, c, h, w = input1.shape
out = out.view(b, -1, h, w) / c

import torch
from spatial_correlation_sampler import SpatialCorrelationSampler

# define a correlation module
correlation_sampler = SpatialCorrelationSampler(1, 9, 1, 0, 1)

output = correlation_sampler(input1, input2)

# reshape output to be a 3D cost volume
b, c, h, w = input1.shape
output = output.view(b, -1, h, w) / c

Hi. I replace the self.corr in the original code with this initialization of correlation_sampler. But the error occurs, which is RuntimeError: input1 must be contiguous. Could you tell me how to replace the origin corr code to get your code to work?

import torch
from spatial_correlation_sampler import SpatialCorrelationSampler

input1 = torch.randn(2, 32, 48, 64).cuda()
input2 = torch.randn(2, 32, 48, 64).cuda()

# define a correlation module
correlation_sampler = SpatialCorrelationSampler(1, 9, 1, 0, 1)

output = correlation_sampler(input1, input2)

# reshape output to be a 3D cost volume
b, c, h, w = input1.shape
output = output.view(b, -1, h, w) / c

print(output.shape)

I run above code and it's okay. So please check whether your input tensors are contiguous, or you can call $ .contiguous() to make them contiguous.

I suggest that you can set fixed input tensors and compare outputs from different implementations to check it.