Custom target issue (STM32L451CEU6) fail to compile, HAL includes not recognized

Hello,
I already ported various custom targets with succes in the past (STM32F103CBT6, STM32F303CCT6, STM32L151C8T6, STM32L462CEU6), i now have to port our latest target STM32L451CEU6, unfortunately it fails completely, despite few hours of search i cannot get it to compile.
Here is what has been done:

target folder has been created (TARGET_L4680_L451), under targets/TARGET_STM/TARGET_STM32L451xE/
It contains the mandatory files, extracted from an STM32CubeMx project. The folder is attached.

TARGET_STM32L451xE.zip

custom target has been added in targets.json

    "L4680_L451": {
        "inherits": ["FAMILY_STM32"],
        "supported_form_factors": ["ARDUINO"],
        "core": "Cortex-M4F",
        "extra_labels_add": ["STM32L4", "STM32L451xE", "STM32L451CE", "STM32L451xx"],
        "config": {
            "clock_source": {
                "help": "Mask value : USE_PLL_HSE_EXTC (need HW patch) | USE_PLL_HSE_XTAL (need HW patch) | USE_PLL_HSI | USE_PLL_MSI",
                "value": "USE_PLL_MSI",
                "macro_name": "CLOCK_SOURCE"
            },
            "lpticker_lptim": {
                "help": "This target supports LPTIM. Set value 1 to use LPTIM for LPTICKER, or 0 to use RTC wakeup timer",
                "value": 1
            }
        },
        "detect_code": ["7017"],
        "supported_toolchains": ["GCC_ARM"],
        "device_has_add": ["ANALOGOUT", "FLASH"],
        "release_versions": ["2", "5"],
        "device_name": "STM32L451CE",
        "bootloader_supported": true
    },

targets.json.zip

target MCU has been added in mbed_rtx.h

mbed_rtx.h.zip

target has been added in tools/export/sw4stm32  init.py dictionnary (not relevant for compilation).

Unfortunately it refuses to compile past 0.4%, there is apparently something wrong with the includes system since the compiler doesnt see base HAL peripherals (SPI, I2C, ADC, DAC) handles:
sudo mbed compile -m L4680_L451 -t GCC_ARM
Password:
[mbed] Auto-installing missing Python modules...
[Warning] @,: Compiler version mismatch: Have 4.8.4; expected version >= 6.0.0 and < 7.0.0
Building project mbed-os-example-blinky (L4680_L451, GCC_ARM)
Scan: mbed-os-example-blinky
Scan: env
Compile [  0.1%]: mbed_tz_context.c
Compile [  0.3%]: MCR20Drv.c
Compile [  0.4%]: AnalogIn.cpp
[Error] objects.h@58,5: 'RNG_HandleTypeDef' does not name a type
[Error] common_objects.h@53,5: 'SPI_HandleTypeDef' does not name a type
[Error] common_objects.h@92,5: 'I2C_HandleTypeDef' does not name a type
[Error] common_objects.h@120,5: 'ADC_HandleTypeDef' does not name a type
[Error] common_objects.h@131,5: 'DAC_HandleTypeDef' does not name a type
[ERROR] In file included from ./mbed-os/targets/TARGET_STM/TARGET_STM32L4/device.h:39:0,
                 from ./mbed-os/platform/platform.h:29,
                 from ./mbed-os/drivers/AnalogIn.h:19,
                 from ./mbed-os/drivers/AnalogIn.cpp:17:
./mbed-os/targets/TARGET_STM/TARGET_STM32L4/TARGET_STM32L451xE/objects.h:58:5: error: 'RNG_HandleTypeDef' does not name a type
     RNG_HandleTypeDef handle;
     ^
In file included from ./mbed-os/targets/TARGET_STM/TARGET_STM32L4/TARGET_STM32L451xE/objects.h:61:0,
                 from ./mbed-os/targets/TARGET_STM/TARGET_STM32L4/device.h:39,
                 from ./mbed-os/platform/platform.h:29,
                 from ./mbed-os/drivers/AnalogIn.h:19,
                 from ./mbed-os/drivers/AnalogIn.cpp:17:
./mbed-os/targets/TARGET_STM/TARGET_STM32L4/common_objects.h:53:5: error: 'SPI_HandleTypeDef' does not name a type
     SPI_HandleTypeDef handle;
     ^
./mbed-os/targets/TARGET_STM/TARGET_STM32L4/common_objects.h:92:5: error: 'I2C_HandleTypeDef' does not name a type
     I2C_HandleTypeDef handle;
     ^
./mbed-os/targets/TARGET_STM/TARGET_STM32L4/common_objects.h:120:5: error: 'ADC_HandleTypeDef' does not name a type
     ADC_HandleTypeDef handle;
     ^
In file included from ./mbed-os/targets/TARGET_STM/TARGET_STM32L4/TARGET_STM32L451xE/objects.h:61:0,
                 from ./mbed-os/targets/TARGET_STM/TARGET_STM32L4/device.h:39,
                 from ./mbed-os/platform/platform.h:29,
                 from ./mbed-os/drivers/AnalogIn.h:19,
                 from ./mbed-os/drivers/AnalogIn.cpp:17:
./mbed-os/targets/TARGET_STM/TARGET_STM32L4/common_objects.h:131:5: error: 'DAC_HandleTypeDef' does not name a type
     DAC_HandleTypeDef handle;
     ^

[mbed] ERROR<EMAIL_ADDRESS>returned error.
       Code: 1
       Path: "/Volumes/HD/XXXXX/XXXXXXX/FIRMWARE/L4680_L451CE_MBED_SRC/mbed-os-example-blinky"
       Command<EMAIL_ADDRESS>-u /Volumes/HD/XXXXX/XXXXXXX/FIRMWARE/L4680_L451CE_MBED_SRC/mbed-os-example-blinky/mbed-os/tools/make.py -t GCC_ARM -m L4680_L451 --source . --build ./BUILD/L4680_L451/GCC_ARM"
       Tip: You could retry the last command with "-v" flag for verbose output
---

Is there another dictionary somewhere i should add my target to get includes system working? I have no idea what the problem is, the other custom targets have no problem.
If ST team could have a check and help to make this custom target work, it would be much appreaciated, at this point i have no idea what to try next.

I decided to add the HAL includes directly in device.h
#ifndef MBED_DEVICE_H
#define MBED_DEVICE_H

//=======================================
#define DEVICE_ID_LENGTH       24

#include "stm32l4xx_hal_rng.h"
#include "stm32l4xx_hal_dma.h"
#include "stm32l4xx_hal_adc.h"
#include "stm32l4xx_hal_dac.h"
#include "stm32l4xx_hal_spi.h"
#include "stm32l4xx_hal_i2c.h"

#include "objects.h"
/*  WORKAROUND waiting for mbed-os issue 4408 to be addressed */

#include "stm32l4xx_ll_usart.h"

#endif

It now compiles up to 83%
$ sudo mbed compile -m L4680_L451 -t GCC_ARM
[mbed] Auto-installing missing Python modules...
[Warning] @,: Compiler version mismatch: Have 4.8.4; expected version >= 6.0.0 and < 7.0.0
Building project mbed-os-example-blinky (L4680_L451, GCC_ARM)
Scan: mbed-os-example-blinky
Scan: env
Compile [  0.7%]: AnalogIn.cpp
....
Compile [ 83.0%]: PeripheralPins.c
[Error] PeripheralPins.c@51,54: 'GPIO_NOPULL' undeclared here (not in a function)
[Error] PinNamesTypes.h@98,33: invalid operands to binary & (have 'const struct PinMap *' and 'int')

then few thousand lines of errors are thrown, full log is include below
built_log.txt

Compile [ 96.2%]: mbed_wait_api_rtos.cpp
[Warning] MbedCRC.h@36,32: unknown option after '#pragma GCC diagnostic' kind [-Wpragmas]
[Warning] mbed_wait_api_rtos.cpp@45,41: 'static osStatus rtos::Thread::wait(uint32_t)' is deprecated (declared at ./mbed-os/rtos/Thread.h:442): Static methods only affecting current thread cause confusion. Replaced by ThisThread::sleep_for. [since mbed-os-5.10] [-Wdeprecated-declarations]
Compile [ 96.3%]: stm32l4xx_hal_uart_ex.c
[Error] stm32l4xx_hal_uart_ex.c@490,27: 'USART_CR3_UCESM' undeclared (first use in this function)
[Error] stm32l4xx_hal_uart_ex.c@539,29: 'USART_CR3_UCESM' undeclared (first use in this function)
[ERROR] ./mbed-os/targets/TARGET_STM/TARGET_STM32L4/device/stm32l4xx_hal_uart_ex.c: In function 'HAL_UARTEx_EnableClockStopMode':
./mbed-os/targets/TARGET_STM/TARGET_STM32L4/device/stm32l4xx_hal_uart_ex.c:490:27: error: 'USART_CR3_UCESM' undeclared (first use in this function)
   huart->Instance->CR3 |= USART_CR3_UCESM;
                           ^
./mbed-os/targets/TARGET_STM/TARGET_STM32L4/device/stm32l4xx_hal_uart_ex.c:490:27: note: each undeclared identifier is reported only once for each function it appears in
./mbed-os/targets/TARGET_STM/TARGET_STM32L4/device/stm32l4xx_hal_uart_ex.c: In function 'HAL_UARTEx_DisableClockStopMode':
./mbed-os/targets/TARGET_STM/TARGET_STM32L4/device/stm32l4xx_hal_uart_ex.c:539:29: error: 'USART_CR3_UCESM' undeclared (first use in this function)
   huart->Instance->CR3 &= ~(USART_CR3_UCESM);

Hopefully the last error, related to USART_CR3_UCESM, however this is internal HAL files and by experience it is preferable not to mess with HAL files because when an error occurs here it is the sign of a more major issue.
@bcostm ST team, please check my custom target folder and help with this issue.

you are not using the HAL drinvers, they are not enabled in stm32l4xx.h:
#if !defined  (USE_HAL_DRIVER)
/**
 * @brief Comment the line below if you will not use the peripherals drivers.
   In this case, these drivers will not be included and the application code will
   be based on direct access to peripherals registers
   */
  #define USE_HAL_DRIVER
#endif /* USE_HAL_DRIVER */

then it will compile until system_clock.c, it looks like there are some modifications neccessary.

Internal Jira reference: https://jira.arm.com/browse/MBOCUSTRIA-132

remaining:

.\mbed-os\targets\TARGET_STM\TARGET_STM32L4\TARGET_STM32L451xE\device\us_ticker_data.h is missing
PeripheralNames.h contains a double definition for UART4, try

typedef enum {
    UART_1 = (int)USART1_BASE,
    UART_2 = (int)USART2_BASE,
    UART_3 = (int)USART3_BASE,
    UART_4 = (int)UART4_BASE,
    LPUART_1 = (int)LPUART1_BASE
} UARTName;

Happy testing :)

So i should define USE_HAL_DRIVER?

I just compared to the other targets, all other have this #define uncommented in the stm32f4xx.h, like my code snippet.

Ohh, i didnt even realized the define in the conditional statement was actaully commented in my STM32L4xx.h
that should explain why i had to includes all these HAL stuffs everywhere. Looks like i am close to successful compilation now. Thanks a lot for spotting this.

i removed my includes from device.h, now it compiles again but stall to the same point as before (USART_CR3_UCESM), i initally overlooked the second part of your answer, now trying to add the fix mentioned.

/* MBED */
#define USART_CR3_UCESM_Pos           (23U)
#define USART_CR3_UCESM_Msk           (0x1U << USART_CR3_UCESM_Pos)            /*!< 0x00800000 */
#define USART_CR3_UCESM               USART_CR3_UCESM_Msk                      /*!< Clock Enable in Stop mode */
/* MBED */

Compile [ 95.3%]: stm32l4xx_hal_uart_ex.c
[Error] stm32l4xx_hal_uart_ex.c@490,27: 'USART_CR3_UCESM' undeclared (first use in this function)
[Error] stm32l4xx_hal_uart_ex.c@539,29: 'USART_CR3_UCESM' undeclared (first use in this function)
[ERROR] ./mbed-os/targets/TARGET_STM/TARGET_STM32L4/device/stm32l4xx_hal_uart_ex.c: In function 'HAL_UARTEx_EnableClockStopMode':
./mbed-os/targets/TARGET_STM/TARGET_STM32L4/device/stm32l4xx_hal_uart_ex.c:490:27: error: 'USART_CR3_UCESM' undeclared (first use in this function)
   huart->Instance->CR3 |= USART_CR3_UCESM;
                           ^
./mbed-os/targets/TARGET_STM/TARGET_STM32L4/device/stm32l4xx_hal_uart_ex.c:490:27: note: each undeclared identifier is reported only once for each function it appears in
./mbed-os/targets/TARGET_STM/TARGET_STM32L4/device/stm32l4xx_hal_uart_ex.c: In function 'HAL_UARTEx_DisableClockStopMode':
./mbed-os/targets/TARGET_STM/TARGET_STM32L4/device/stm32l4xx_hal_uart_ex.c:539:29: error: 'USART_CR3_UCESM' undeclared (first use in this function)
   huart->Instance->CR3 &= ~(USART_CR3_UCESM);

right, adding the register definition to STM32L4xx.h did the trick for UART_CR3_UCESM, now i have a last error on TIM5 in us_ticker_data.h since there is no TIM5 on this target (i scavanged the file from another nucleo target) hopefully it is just a matter of changing the TIM number

Compile [ 99.9%]: us_ticker.c
[Error] us_ticker_data.h@27,22: 'TIM5' undeclared (first use in this function)
[Warning] us_ticker.c@157,5: implicit declaration of function '__HAL_RCC_TIM5_CLK_ENABLE' [-Wimplicit-function-declaration]
[Warning] us_ticker.c@160,5: implicit declaration of function '__HAL_RCC_TIM5_FORCE_RESET' [-Wimplicit-function-declaration]
[Warning] us_ticker.c@161,5: implicit declaration of function '__HAL_RCC_TIM5_RELEASE_RESET' [-Wimplicit-function-declaration]
[Error] us_ticker_data.h@27,22: 'TIM5' undeclared (first use in this function)
[Error] us_ticker_data.h@28,22: 'TIM5_IRQn' undeclared (first use in this function)
[Error] us_ticker_data.h@27,22: 'TIM5' undeclared (first use in this function)
[Error] us_ticker_data.h@27,22: 'TIM5' undeclared (first use in this function)
[Error] us_ticker_data.h@27,22: 'TIM5' undeclared (first use in this function)
[Warning] us_ticker.c@215,1: control reaches end of non-void function [-Wreturn-type]
[ERROR] In file included from ./mbed-os/targets/TARGET_STM/us_ticker.c:19:0:
./mbed-os/targets/TARGET_STM/us_ticker.c: In function 'timer_irq_handler':
./mbed-os/targets/TARGET_STM/TARGET_STM32L4/TARGET_STM32L451xE/device/us_ticker_data.h:27:22: error: 'TIM5' undeclared (first use in this function)
 #define TIM_MST      TIM5

After fixing us_ticker_dat, it finally compiles, now time to mess with the SW4STM32 project export / generation.
$ sudo mbed compile -m L4680_L451 -t GCC_ARM
Password:
[mbed] Auto-installing missing Python modules...
[Warning] @,: Compiler version mismatch: Have 4.8.4; expected version >= 6.0.0 and < 7.0.0
Building project mbed-os-example-blinky (L4680_L451, GCC_ARM)
Scan: mbed-os-example-blinky
Scan: env
Compile [100.0%]: us_ticker.c
Link: mbed-os-example-blinky
Elf2Bin: mbed-os-example-blinky
| Module           |         .text |       .data |        .bss |
|------------------|---------------|-------------|-------------|
| [fill]           |       53(+53) |       4(+4) |       7(+7) |
| [lib]/c.a        | 24524(+24524) | 2204(+2204) |     56(+56) |
| [lib]/gcc.a      |   3792(+3792) |       0(+0) |       0(+0) |
| [lib]/m.a        |       80(+80) |       0(+0) |       0(+0) |
| [lib]/misc       |     112(+112) |     16(+16) |     28(+28) |
| main.o           |       68(+68) |       4(+4) |     28(+28) |
| mbed-os/drivers  |     216(+216) |       4(+4) |   100(+100) |
| mbed-os/hal      |   1807(+1807) |       4(+4) |     68(+68) |
| mbed-os/platform |   3184(+3184) |   260(+260) |   197(+197) |
| mbed-os/rtos     |   3485(+3485) |   164(+164) | 4336(+4336) |
| mbed-os/targets  |   8115(+8115) |       4(+4) |   832(+832) |
| Subtotals        | 45436(+45436) | 2664(+2664) | 5652(+5652) |
Total Static RAM memory (data + bss): 8316(+8316) bytes
Total Flash memory (text + data): 48100(+48100) bytes

Image: ./BUILD/L4680_L451/GCC_ARM/mbed-os-example-blinky.bin


use prometheus name label as point measurement name

Duplicate the Prometheus __name__ label to the InfluxDB measurement name. Fixes #9244
The __name__ label will still be present, as it was indicated this was originally by design.
No tests (there were none existing). Can add them if I have time later or if they're required.
Required for all non-trivial PRs

[/] Sign CLA (if not already signed)

@roganartu has signed the CLA.

Will it be possible to migrate the data? Or can they still be accessed?

@roganartu As i wrote here https://github.com/prometheus/prometheus/issues/3975 i'm using a prometheus with remote storage write and a prometheus with remote storage read on a other location.
So for your change it looks like that the read endpoint also need such change or?

This would break other queries because of how InfluxQL matches queries when going across measurements and tags. I've put up a possible solution which I talk about here: https://github.com/influxdata/influxdb/issues/9244#issuecomment-383422534
I'll keep this open for now until we have a resolution.

This was resolved via: https://github.com/influxdata/influxdb/pull/9967. __name__ will be included as an InfluxDB tag on the series, and the measurement name will be __name__'s value, if __name__ is set.

This was resolved via: #9967. name will be included as an InfluxDB tag on the series, and the measurement name will be name's value, if name is set.


refactor: Color.color is a tuple

I have not tested this, but looking at https://github.com/flatpak/xdg-desktop-portal/blob/04fdd3579abef01248997608e2abd919be94c1b1/data/org.freedesktop.impl.portal.Screenshot.xml#L90 the definition of Color might have the same issue  as for the accent-color when used in the screenshot portal.

The current code works perfectly fine. It is tested in ashod demo already

Thanks for your contributions


Refactor stylesheets to not use the !important rule

Some of the styles in Homepage.css are utilising the !important rule. While this does not induce any errors, it is generally possible to write a stylesheet without using this directive. This will ensure the css is easier to debug and enhance in the future.
Refactor the css to remove the use of !important while ensuring the UI design is not affected. This includes keeping the responsiveness of the page intact.

I would like to work on this, can you please assign it to me? @aaryak-shah

@mounicasruthi sure, go ahead!


Metadata Push must be for the connection (stream id 0)

Frame Header Format says stream id must be present, but the spec also says Metadata for a request or response should be in the existing Frame.  So this should be a must.

I think it can be something other than zero so you can push metadata for a particular stream.
@benjchristensen @stevegury

I thought I was going off the spec

The following are features of Data and Metadata.
Metadata can be encoded differently than Data.
Metadata can be "attached" (i.e. correlated) with the following entities:
Connection via Metadata Push and Stream ID of 0
Individual Request or Response

Metadata Push Frame
A Metadata Push frame can be used to send asynchronous metadata notifications from a Requester or Responder to its peer. Metadata MUST be scoped to the connection by setting Stream ID to 0.
Metadata tied to a particular Request, Response, etc. uses the individual frames Metadata flag.

I suggest either removing/rewording the "MUST", or saying that Metadata can be for 3 things instead of 2.  The connection, a stream, or an individual request/response.

👍
In the early design, metadata was potentially associated with any stream, but later we decided to only allow it at the scope of the session/connection.
(It possible that you'll find area of the spec where it's ambiguous.)

Merging since we got two 👍


Move context augmentation to Page enrichment

Part of https://segment.atlassian.net/browse/LIBWEB-1426
Since Page Enrichment is no longer just enriching "page" events, with page information, I wanted to rename this to something generic like "Context Enrichment", but wasn't certain if this is safe. Open to discussion.
The original implementation suggests something about falling back to "options" if "context" is not there. Not sure what that means, so please help me identify what's the intended outcome of that design so I can double-check that behaviour is not impacted.

@zikaari Definitely an improvement architecturally!

I wanted to rename this to something generic like "Context Enrichment", but wasn't certain if this is safe. Open to discussion.

Cool! Yeah, I see this plugin is about augmenting the event with information from the user's environment-- so maybe EnvironmentAugmentation plugin would be a good candidate -- but "page" can also be interpreted as a kind of word for environment :-)
I mainly don't like the word 'enrichment' because this plugin isn't a type:enrichment plugin -- so it's  v confusing.

@pooyaj Do you know any dangers of renaming a plugin on top of your head? Not just the symbol name, but also Plugin.name property.
If you don't feel confident, we can leave renaming it to some other time.

@zikaari change to core package (interface) should have a another changeset


Screen capture to non existing directory hangs forever

When using the CLI tool to capture a screenshot and the directory is not exists, the command hang forever instead of returning an error.
vncdo capture non-exists/test.png
When using the API it is throwing an exception:
client = api.connect('<IP_ADDRESS>', password=None)
client.captureScreen('non-exists/screenshot.png')

The error is:
Traceback (most recent call last):
  File "/Users/arossert/tests/vnc_test/vnc_test.py", line 5, in <module>
    client.captureScreen('1/screenshot.png')
  File "/Users/arossert/tests/venv2/lib/python2.7/site-packages/vncdotool/api.py", line 111, in proxy_call
    raise VNCDoException(result)
vncdotool.api.VNCDoException: [Failure instance: Traceback: <type 'exceptions.IOError'>: [Errno 2] No such file or directory: '1/screenshot.png'
/Users/arossert/tests/venv2/lib/python2.7/site-packages/vncdotool/rfb.py:245:_doConnection
/Users/arossert/tests/venv2/lib/python2.7/site-packages/vncdotool/client.py:393:commitUpdate
/Users/arossert/tests/venv2/lib/python2.7/site-packages/twisted/internet/defer.py:460:callback
/Users/arossert/tests/venv2/lib/python2.7/site-packages/twisted/internet/defer.py:568:_startRunCallbacks
--- <exception caught here> ---
/Users/arossert/tests/venv2/lib/python2.7/site-packages/twisted/internet/defer.py:654:_runCallbacks
/Users/arossert/tests/venv2/lib/python2.7/site-packages/vncdotool/client.py:249:_captureSave
/Users/arossert/tests/venv2/lib/python2.7/site-packages/PIL/Image.py:1991:save

The CLI is probably catching the exception and ignoring it somewhere.

Probably missing exception handling similar to https://github.com/sibson/vncdotool/issues/127#issuecomment-374045854


response: improve the response sentences

Signed-off-by: Andy Lok<EMAIL_ADDRESS>Some improvement in response texts.

/ok-to-test

@andylokandy  The CI broken.

@hi-rustin PTAL

Codecov Report

Merging #194 (a016693) into master (5b97cfd) will decrease coverage by 0.02%.
The diff coverage is 89.13%.

@@            Coverage Diff             @@
##           master     #194      +/-   ##
==========================================
- Coverage   86.10%   86.07%   -0.03%
==========================================
  Files          11       11
  Lines         986      984       -2
==========================================
- Hits          849      847       -2
  Misses         77       77
  Partials       60       60

Flag
Coverage Δ

unittests
86.07% <89.13%> (-0.03%)
:arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files
Coverage Δ

internal/pkg/externalplugins/owners/owners.go
83.16% <33.33%> (ø)

internal/pkg/externalplugins/merge/merge.go
82.60% <94.44%> (-0.10%)
:arrow_down:

...pkg/externalplugins/autoresponder/autoresponder.go
87.75% <100.00%> (ø)

...nal/pkg/externalplugins/blunderbuss/blunderbuss.go
92.78% <100.00%> (ø)

internal/pkg/externalplugins/label/label.go
86.95% <100.00%> (ø)

internal/pkg/externalplugins/lgtm/lgtm.go
88.81% <100.00%> (-0.08%)
:arrow_down:

internal/pkg/externalplugins/tars/tars.go
79.05% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5b97cfd...a016693. Read the comment docs.

@AndreMouche Any updates? 😆

@hi-rustin PTAL

/merge


modify the url of fluentbit logfmt

/check-pr-porting-labels
/needs-backport
the error url is https://docs.fluentbit.io/manual/parser/logfmt
the right url is https://docs.fluentbit.io/manual/pipeline/parsers/logfmt

https://github.com/kata-containers/documentation/issues/740

Hi @timyinshi. Thanks for raising. Please can you rework the commit message to use the format we require here:

https://github.com/kata-containers/community/blob/master/CONTRIBUTING.md#patch-format

Also, I would actually update all the broken URLs you list on #740 on this PR (on a single commit is fine too).
Note that we do validate URLs, but only when documentation changes (we should consider running these checks weekly maybe). See:

https://github.com/kata-containers/tests/blob/master/.ci/static-checks.sh#L707..L744

Finally, please could you also raise a PR for the 2.0 repository documentation?:

https://github.com/kata-containers/kata-containers/tree/2.0-dev/docs

@jodh-intel ok,thanks.

https://github.com/kata-containers/documentation/pull/742
i have a new pr for error url of logfmt


samples(spanner): use explicit transaction ...

when inserting data using the mutations API so that the mutations are batched together and not executed one at a time.

I get a test failure when I use an explicit transaction which was a bit surprising. Somehow the test logs are empty in the failed Kokoro build above. But I'm pasting the stack trace from my local run:
  X DeleteDataAsyncTest.TestDeleteDataAsync [1ms]
  Error Message:
   System.Transactions.TransactionAbortedException : The transaction has aborted.
---- Google.Cloud.Spanner.Data.SpannerException : Object not found.
-------- Grpc.Core.RpcException : Status(StatusCode="NotFound", Detail="Parent row for row [1,1] in table Albums is missing. Row cannot be written.", DebugException="Grpc.Core.Internal.CoreErrorDetailException: {"created":"@1623302645.713128270","description":"Error received from peer ipv6:[2404:6800:4006:80e::200a]:443","file":"/var/local/git/grpc/src/core/lib/surface/call.cc","file_line":1062,"grpc_message":"Parent row for row [1,1] in table Albums is missing. Row cannot be written.","grpc_status":5}")
  Stack Trace:
     at System.Transactions.TransactionStateAborted.EndCommit(InternalTransaction tx)
   at System.Transactions.CommittableTransaction.Commit()
   at System.Transactions.TransactionScope.InternalDispose()
   at System.Transactions.TransactionScope.Dispose()
   at InsertDataAsyncSample.InsertDataAsync(String projectId, String instanceId, String databaseId) in /google-cloud-dotnet/spanner/api/Spanner.Samples/InsertDataAsync.cs:line 92
   at SpannerFixture.InitializeDatabaseAsync() in /google-cloud-dotnet/spanner/api/Spanner.Samples.Tests/SpannerFixture.cs:line 183
   at SpannerFixture.InitializeAsync() in /google-cloud-dotnet/spanner/api/Spanner.Samples.Tests/SpannerFixture.cs:line 75
----- Inner Stack Trace -----
   at Google.Cloud.Spanner.Data.ExecuteHelper.WithErrorTranslationAndProfiling[T](Func`1 t, String name, Logger logger)
   at Google.Api.Gax.TaskExtensions.WaitWithUnwrappedExceptions(Task task)
   at Google.Api.Gax.TaskExtensions.ResultWithUnwrappedExceptions[T](Task`1 task)
   at Google.Cloud.Spanner.Data.SpannerTransaction.Commit(DateTime& timestamp)
   at Google.Cloud.Spanner.Data.SpannerTransaction.Commit()
   at Google.Cloud.Spanner.Data.VolatileResourceManager.<CommitToSpanner>b__13_0()
   at Google.Cloud.Spanner.Data.ExecuteHelper.WithErrorTranslationAndProfiling(Action t, String name, Logger logger)
   at Google.Cloud.Spanner.Data.VolatileResourceManager.CommitToSpanner()
   at Google.Cloud.Spanner.Data.VolatileResourceManager.SinglePhaseCommit(SinglePhaseEnlistment singlePhaseEnlistment)
----- Inner Stack Trace -----
   at Grpc.Gcp.GcpCallInvoker.<>c__DisplayClass27_0`2.<<AsyncUnaryCall>g__PostProcessPropagateResult|3>d.MoveNext()
--- End of stack trace from previous location where exception was thrown ---
   at Google.Api.Gax.Grpc.ApiCallRetryExtensions.<>c__DisplayClass0_0`2.<<WithRetry>b__0>d.MoveNext()
--- End of stack trace from previous location where exception was thrown ---
   at Google.Cloud.Spanner.V1.Internal.ExecuteHelper.WithSessionExpiryChecking[T](Task`1 task, Session session)
   at Google.Cloud.Spanner.V1.PooledSession.RecordSuccessAndExpiredSessions[T](Task`1 task)
   at Google.Cloud.Spanner.V1.PooledSession.CommitAsync(CommitRequest request, CallSettings callSettings)
   at Google.Cloud.Spanner.Data.SpannerTransaction.<>c__DisplayClass44_0.<<CommitAsync>b__0>d.MoveNext()
--- End of stack trace from previous location where exception was thrown ---
   at Google.Cloud.Spanner.Data.ExecuteHelper.WithErrorTranslationAndProfiling[T](Func`1 t, String name, Logger logger)

My code doesn't seem to be doing what I think it's doing but I'm not sure why.

I've added the do not merge label until we decide what to do on our internal thread.

Phew, I can confirm that the tests now pass after using a RetriableTransaction. The failures in CI are unrelated to Spanner.

@jskeet if you're comfortable with approving and merging this in, please go ahead. Otherwise, I'm more than happy to wait till @amanda-tarafa is back.


Node.js Foundation Outreach Strategic Initiative Meeting 2019-04-16

Time
UTC Tues 15-Apr-2019 16:00 (04:00 PM):

Timezone
Date/Time

US / Pacific
Tues 16-Apr-2019 09:00 (09:00 AM)

US / Mountain
Tues 16-Apr-2019 10:00 (10:00 AM)

US / Central
Tues 16-Apr-2019 11:00 (11:00 AM)

US / Eastern
Tues 16-Apr-2019 12:00 (12:00 PM)

London
Tues 16-Apr-2019 17:00 (05:00 PM)

Amsterdam
Tues 16-Apr-2019 18:00 (06:00 PM)

Moscow
Tues 16-Apr-2019 19:00 (07:00 PM)

Chennai
Tues 16-Apr-2019 21:30 (09:30 PM)

Hangzhou
Wed 17-Apr-2019 00:00 (12:00 AM)

Tokyo
Wed 17-Apr-2019 01:00 (01:00 AM)

Sydney
Wed 17-Apr-2019 02:00 (02:00 AM)

Or in your local time:

http://www.timeanddate.com/worldclock/fixedtime.html?msg=Node.js+Foundation+Website Redesign Strategic Initiative+Meeting+2019-04-16&iso=20190416T16
or http://www.wolframalpha.com/input/?i=04PM+UTC%2C+Apr+16%2C+2019+in+local+time

Links

Minutes Google Doc:

Agenda
Extracted from outreach-agenda labelled issues and pull requests from the nodejs org prior to the meeting.
nodejs/outreach

🚧 (WIP) Community Contributions #9
🚧 (WIP) Community Content #8
🚧 (WIP) Community Events #7

Invited

Website Redesign Strategic Initiative Team: @nodejs/website-redesign

Observers/Guests
Notes
The agenda comes from issues labelled with outreach-agenda across all of the repositories in the nodejs org. Please label any additional issues that should be on the agenda before the meeting starts.
Joining the meeting

link for participants: https://zoom.us/j/526318636
For those who just want to watch:
youtube admin page: https://www.youtube.com/my_live_events?filter=scheduled

Is this on the 16th? The note says 15th.

😬

Getting the automated meeting generator up right now – last manual meeting 🙂

Awesome! 💯

The first link for viewing your local time and date is not working correctly. It displays data for 11th April with event status as ‘passed’.

This is why we have automatic issue generation 😏 Fixed!

The meeting's minutes Google Doc link is missing. Do we have it currently?

Updated :)


Workflow per pass. [Feature request]

Would like to be able to specify a different workflow for each pass.
Unless specified the main workflow listed in "Workflow =" will be default
If specified "SwitchWorkflow =" the next renderpass will use the alt workflow.
The idea is to use the ImageEffectsAdjustment node on all EB processed frames to correct the color there rather than as the new frames are generated in comfy.
Currently I use the ImageEffectsAdjustment node to try and match the new processed frames to the slightly less contrast/saturation but that is backwards. What I really want to do is just correct the side affect of EB and process the new frames with normal color values.
I am sure I can come up with other use cases later... =]
IE:
workflow set
comfy pass
eb pass
workflow switch  (workflow with only ImageEffectsAdjustment node)
comfy pass <-- switched workflow to color correct all frames
comfy pass <-- default workflow w/ skip frames
...

This is already supported. You can just overwrite the Workflow = parameter per pass. It will default to global value if none is given per pass.

Not working for me. repo up to date.
This is what I have in config and the last render still uses the workflow listed at the top. It uses face detailer so its clear its not using the color workflow...
[RenderPass.comfyui]
StartFrame = 2
SkipFrames = 35
comfyuiparam.sampler.denoise = 0.6

[RenderPass.copy_files]
From = ${OutputDir}
To = abc/pass-01/
#----------------------------------------------------------------------p1

[RenderPass.ebsynth_blend]
StartFrame = 2
SkipFrames = 35
Alpha = 0.35

[RenderPass.copy_files]
From = ${OutputDir}
To = abc/eb/pass-02/

Workflow = workflows/color-001_api.json
[RenderPass.comfyui]

If it works on your end...
Could you show an example how you are able to switch the workflow...??

I can't reproduce your issue.
Try adding this into comfyui.py line 91: print("workflow: " + workflow) to see if it's reading the correct workflow file.
print("workflow: " + workflow) # added line```

Also double check you've exported the correct api.json

It would not let me add the print line, complained about indentation.
Made me realize what was wrong though.
I was setting the workflow before the pass
Workflow = workflows/color-001_api.json
[RenderPass.comfyui]

It can not get the workflow if it has not started the pass.
Should be :
Workflow = workflows/color-001_api.json
[RenderPass.comfyui]

User error... =\


new visualstudio runner for xunit

Added packages to allow the built in visual studio test runner to run the tests.

👍


Fix the Maven build.

Maven doesn't support multiple source directories, so we'll compile everything with Ant and use Maven to build the jar.

Hmm, "mvn package" now doesn't work anymore: the compilation says that generics are not supported in Java 1.3 ! Somehow, maven falls back to 1.3, can you change that ?

OK, I set the source to 1.6 in pom.xml, mvn package now works

I was just going to say hold on with the integration, it doesn't really work :)


Assets path wrong when importing from nested routes

Describe the bug
My project structure is as follows:
routes
│   login.svelte
└───wizard
│   │   email.svelte

When adding an img tag that uses an image from the static folder

This works correctly for the login route but not for /wizard/email route.
A fix I found for this was to prefix /static/ to all images used,
for example:
Just wondering why its not working with just logo.svg
Note: I am in dev enviroment

Where is your static folder? Depending on where it is, and what config you have in your project, you might be able to change the file path.
In the meantime, use "/static/" when using images.

You shouldn't use /static/ as a prefix, you should just just /. It's a bug that the /static/ prefix works (to do with how Vite handles requests — fixed in #4535).
This is expected behaviour — relative URLs are relative to the current page. You need to use absolute or root-relative URLs, either like /logo.svg or ${assets}/logo.svg (using https://kit.svelte.dev/docs/modules#$app-paths-assets)


Fixes monaco editor dependencies

Fixes dependency issues by using overrides as described in https://github.com/atularen/ngx-monaco-editor/issues/259

Codecov Report

Merging #1434 (850fdcd) into master (21e0fc0) will decrease coverage by 0.24%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #1434      +/-   ##
==========================================
- Coverage   43.12%   42.87%   -0.25%
==========================================
  Files          58       58
  Lines         807      807
  Branches       55       55
==========================================
- Hits          348      346       -2
- Misses        451      453       +2
  Partials        8        8

Impacted Files
Coverage Δ

src/environments/environment.ts
100.00% <ø> (ø)

...s/team-member-modal/team-member-modal.component.ts
36.11% <0.00%> (-5.56%)
:arrow_down:

:mega: Codecov can now indicate which changes are the most critical in Pull Requests. Learn more


Use m1 runner to speed up deploy

The new runner executes Actions workflows with a 3 vCPU, 7 GB RAM, and 14 GB of storage VM, which provides the latest Mac hardware Actions has to offer.
https://github.blog/changelog/2024-01-30-github-actions-introducing-the-new-m1-macos-runner-available-to-open-source/

Screenshots
Typecheck 6s -> 4s

Vitest 7s -> 4s

Playwright Install 25s -> 5s

Playwright Test 26s -> 21s

Honestly, the vanilla stack isn't big enough for it to make a notable difference, but it might for more built out apps? Are there any production builds we can check against?
(note: this deploy is a tad slower because of blank npm cache)

I agree that building on M1 would speed up the process. However, Epic Stack deploys to Fly using Docker on bookwork-slim, a Debian distro. The Ubuntu image used in the build is also Debian-based.
For CI, I think it's best if the build and testing use the same environment (or as close as possible) to production.

@kiliman said exactly what I would 👍
Thanks anyway @xHomu!


fix documentation and links

Description
Fix documentation and links
Type of change
Please add a line in the relevant section of CHANGELOG.md to document the change (include PR #) - note reverse order of PR #s. If necessary, also add to the list of breaking changes.

[ ] New feature (non-breaking change which adds functionality)
[ ] Optimization (back-end change that speeds up the code)
[ ] Bug fix (non-breaking change which fixes an issue)

Key checklist:

[ ] No style issues: $ flake8
[ ] All tests pass: $ python run-tests.py --unit
[ ] The documentation builds: $ cd docs and then $ make clean; make html

You can run all three at once, using $ python run-tests.py --quick.
Further checks:

[ ] Code is commented, particularly in hard-to-understand areas
[ ] Tests added that prove fix is effective or that feature works

@tinosulzer Yes, I have also fixed those broken links mentioned in that issue.


ESA-306: Search layouts

@marklise it would also help if you could...

rebase your branch with main,
force:source:push to your scratch org,
re-add your search component on the HIBC community's search page
publish and test
force:source:pull and commit the new SSHIBC_Service_Support_HIBC1.site


renewed certificate tls.crt not in right directory

certificate is renewed and its status is Certificate is up to date and has not expired
new tls.crt is under ..data -> /etc/istio/ingressgateway-certs/..2020_07_29_08_49_45.605999237/
it does not replace old tls.crt  /etc/istio/ingressgateway-certs/
when I curl my endpoints it still looking for the  old tls.crt and saying it is expired
upgraded cert-manager 1.16 from 1.14
/etc/istio/ingressgateway-certs# ll
total 0
drwxrwxrwt 3 root root 120 Jul 29 08:49 ./
drwxr-xr-x 1 root root  89 Apr 20 09:36 ../
drwxr-xr-x 2 root root  80 Jul 29 08:49 ..2020_07_29_08_49_45.605999237/
lrwxrwxrwx 1 root root  31 Jul 29 08:49 ..data -> ..2020_07_29_08_49_45.605999237/
lrwxrwxrwx 1 root root  14 Apr 20 09:53 tls.crt -> ..data/tls.crt
lrwxrwxrwx 1 root root  14 Apr 20 09:53 tls.key -> ..data/tls.key

cert-manager will update the secret in Kubernetes and has no involvement with the Istio filesystem. Seems like this is an istio issue.
/triage support


Define command line arguments

Command Line Arguments
The exe/project_templates should be configurable via command line arguments. These arguments should change properties on the App instance that the executable instantiates. This allows configuration to be specified in the console or test without needing to parse arguments. The implementation of command line argument parsing is yet to be defined; perhaps a CLIApp which wraps App, parses arguments and sets flags is appropriate. Perhaps App should be able to parse arguments automatically.
The expected invocation should look something like
$ project_templates [template] [target] --verbose

Proposed command line arguments
The exact names and flags are to be determined. This list exists to specify the features of a desired interface.

[template] the name, or 'path fragment' of the template directory structure to use. This should be a positional argument.
[target] the name of the directory to create. This should be a positional argument. The target will be relative to the current directory
--version, -v prints the current version of the application
--help, -h prints help on available command line arguments. Should not replace a man() page.
--dry-run, -d perform all operations except for writing the new files to disk. The target location should be checked to make sure it can be written to.  Exit with failure if not.
--verbose print debugging information including details about parsed dictionaries, file names, template content before/after rendering, etc.
--config, -c the path to a file which contains user configuration. Should override the defaults specified at any "higher" level.
--user-config, -u override the user config file with one specified by this flag. Should override the user defaults but be still be replaced by template level defaults
--template-config, -t override the template level configuration (and in turn user level configuration) but not instantiation level configuration specified by -c.
--list, -l list all available templates in the project templates template path.
--template-path, -p specify a specific template path to use instead of the default template path.
--working-directory, -w specify a directory to use for the target instead of the current working directory.

Configuration Arguments
It should also be possible to specify a set of key/value pairs at the command line in order to override any values set at a higher level. Some investigation should be performed. Possible options would be:

Simple key value pairs after end of arguments

$ project_templates [template] [target] - foo: bar, bing: bong

JSON after end of arguments

$ project_templates [template] [target] - "{'foo': 'bar', 'bing': 'bong'}"

JSON flag

$ project_templates [template] [target] --arguments="{'foo': 'bar', 'bing': 'bong'}"

Parse STDIN for JSON

$ project_templates [template] [target] < echo "{'foo': 'bar', 'bing': 'bong'}"

handle unexpected arguments:

$ project_templates [template] [target] --foo=bar --bing=bong

Prefixed arguments:

$ project_templates [template] [target] --key-foo=bar --key-bing=bong

All the DictionaryLoader stuff has hit master. At this point we're ready to refactor the Config class to be a little less wordy:
It should have dictionaries, paths, and action. These will be meta objects to group together related kinds of config.
Then we'll write up a Config initializer that loads global config from the expected locations:

the environment variable ENV[:PROJECT_TEMPLATES_CONFIG]
the file pointed at by ENV[:PROJECT_TEMPLATES_CONFIG_FILE]
the file $XDG_CONFIG_DIR/project_templates/config.yaml
the file $HOME/.config/project_templates/config.yaml
String from json that defines 'default values' for everything.

Action can be --dry-run for now, but then we're going to need to sort out parsing command line args to make more progress.

All of the major stuff around dictionary loading and config classes is finally settled. Now it's time to load dictionaries and configure things with command line args.  Maybe this spells the need for a "config loader" class but in the short term the build out can happen in exe/project_templates.


ZEPPELIN-3336. Remove sending spark web url to interpreter setting page

What is this PR for?
This PR  is to remove the spark web url of interpreter setting page. As it doesn't make sense to do that. There would many spark interpreter processes associated with one interpreter setting when it is in isolated mode.
What type of PR is it?
[Bug Fix ]
Todos

[ ] - Task

What is the Jira issue?

https://issues.apache.org/jira/browse/ZEPPELIN-3336

How should this be tested?

CI pass

Screenshots (if appropriate)
Questions:

Does the licenses files need update? No
Is there breaking changes for older versions? No
Does this needs documentation? No

@felixcheung Mind to review it ? Thanks

I guess?
How do the user find the Spark UI url though?

This is just removing send web ui to interpreter setting, but we still send job web ui to paragraph. So that user can still see the ui in paragraph.

ok


[FLINK-14372][tests] Add category AlsoRunWithSchedulerNG to KeyedStateCheckpointingITCase

What is the purpose of the change
See title
Brief change log

See title

Verifying this change
This change is already covered by existing tests, such as KeyedStateCheckpointingITCase.
Does this pull request potentially affect one of the following parts:

Dependencies (does it add or upgrade a dependency): (yes / no)
The public API, i.e., is any changed class annotated with @Public(Evolving): (yes / no)
The serializers: (yes / no / don't know)
The runtime per-record code paths (performance sensitive): (yes / no / don't know)
Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Yarn/Mesos, ZooKeeper: (yes / no / don't know)
The S3 file system connector: (yes / no / don't know)

Documentation

Does this pull request introduce a new feature? (yes / no)
If yes, how is the feature documented? (not applicable / docs / JavaDocs / not documented)

looks good to me.
+1 to merge


Strange behavior of newlines

>>> import mistune
>>> markdown = mistune.create_markdown()
>>> markdown('foo\n  bar')
'
foo\n  bar
\n'
>>> markdown('foo \n  bar')
'
foo \n  bar
\n'
>>> markdown('foo  \n  bar')
'
foo
\n  bar
\n'

I believe this is incorrect. The output should have a  between those two lines always, it shouldn't depend on two spaces before newline.

I'm using version 2.0.0a4 btw.

This is correct.
line break

When you do want to insert a  break tag using Markdown, you end a line with two or more spaces, then type return.

Oh. Ugh. https://stackedit.io/ doesn't follow that, nor https://dillinger.io/, or https://markdown-editor.github.io/, and not github either:
foo
bar
baz
Maybe a plugin/option for this might make sense I guess. Depends on usage. I want to use mistune for a forum/wiki, and then it is very confusing and bad doing what the markdown spec says. Just pasting some python code into a comment field would mangle it badly.

@boxed I guess it depends on your usage. Because for me this is the opposite. I'm using this feature on my own system. The GFM (GitHub Flavored Markdown) behavior seems also to mandate that.

For stackedit, this is configurable.
for dillinger I filed an issue
for markdown-editor, the issue was closed, because it was saying it was behaving the right way.

This can be done with a custom InlineParser right now. But I think it would be good to make an option for it.

I've added hard_wrap back into the master code.


How to use to send beautiful "useraccounts"-emails?

Hi guys,
is there anyone using this package to send "useraccounts"-related emails? Just like https://github.com/yogiben/meteor-pretty-email does, but keeping it consistent?
If yes: Do you mind sharing some code on how you did it?
@johanbrook : How are you doing it? Do you use this package or yogiben?  :-)

The built in Meteor email hooks for the Accounts package can accept HTML and plain text (can't find the docs at the moment though), so you can use this package to render the HTML from an email template, and let Meteor send it.

yeah man! http://docs.meteor.com/api/passwords.html#Accounts-emailTemplates
👍

Hi guys,
this is simple stuff, but it might safe you some time if you want to do this yourself.
So this is something for the WIKI of this package:
import { htmlToText } from 'meteor/lookback:html-to-text'

// Enrollment
Accounts.emailTemplates.enrollAccount.from = function () {
  return 'Webmaster<EMAIL_ADDRESS>}
Accounts.emailTemplates.enrollAccount.subject = function () {
  return 'Your subject'
}
Accounts.emailTemplates.enrollAccount.text = function (user, url) {
  const html = Mailer.render('useraccountsEnrollment', {  // email template using `lookback:emails`
    user,
    url,
  })
  return htmlToText.fromString(html)  // CONVERT to text
}
Accounts.emailTemplates.enrollAccount.html = function (user, url) {
  return Mailer.render('useraccountsEnrollment', {  // email template using `lookback:emails`
    user,
    url,
  })
}

// do the same thing with the other email-types (verifyEmail, resetPassword)
//  you find in the Meteor-docs at http://docs.meteor.com/api/passwords.html#Accounts-emailTemplates


Dependency as dataclass attribute fails on 3.11+

This code fails in 3.11+:
@dataclass
class Bar:
    value = 'bar'

@dataclass
class Foo:
    bar: Bar = dependency()

Here's a gist with a tox+pytest setup:
https://gist.github.com/eykd/0ddbc8ea7080c1702d95838c0d6e1f02
Test passes in 3.10, but fails 3.11 and 3.12.
Tail end of Tox output:
E           ValueError: mutable default <class 'test_bevy.test_it_should_instantiate_foo.<locals>.Bar'> for field bar is not allowed: use default_factory

/opt/homebrew/Cellar/python@3.12/3.12.0/Frameworks/Python.framework/Versions/3.12/lib/python3.12/dataclasses.py:852: ValueError
============================================================================= short test summary info ==============================================================================
FAILED test_bevy.py::test_it_should_instantiate_foo - ValueError: mutable default <class 'test_bevy.test_it_should_instantiate_foo.<locals>.Bar'> for field bar is not allowed: use default_factory
================================================================================ 1 failed in 0.04s =================================================================================
py312: exit 1 (0.20 seconds) ~/tmp/bevy> pytest pid=2302
  py310: OK (0.22=setup[0.06]+cmd[0.15] seconds)
  py311: FAIL code 1 (0.22=setup[0.00]+cmd[0.21] seconds)
  py312: FAIL code 1 (0.20=setup[0.01]+cmd[0.20] seconds)
  evaluation failed :( (0.70 seconds)

I don't know if my solution for #9 will resolve this. I'll have to dig into it later.

The solution for #9 would resolve this issue. It's the premature injection that's causing the value error.

be9566395b1466bd36828bda4b07ce1ffa8d57b2 resolves this issue and #9


Error: Function called outside component initialization when calling setContext

Description
setContext throws an error Error: Function called outside component initialization
Reproduction

Initialize svite app (with any template)

Add the following lines to App.svelte

import { setContext } from 'svelte';
setContext({},{})

Additional Information

operating system Mac OS
versions for

"vite": "2.0.5",
"svelte": "3.35.0",
"@svitejs/vite-plugin-svelte": "0.11.0",

Update:
Same is true for any component initialization function. For example, the following will generate same error:
import { createEventDispatcher } from 'svelte'
const dispatch = createEventDispatcher()

I can not reproduce the issue on linux. I'll try to add more tests, they are run on mac aswell. But please try again with latest versions, there have been sevaral important fixes in vite 2.1
npx svite create
cd svite-minimal
npm install
# edit App.svelte
npm run dev  #devserver starts, page opens, no errors
# edit App.svelte again to test hmr, still no errors, hmr works

dependency versions used:
@svitejs/vite-plugin-svelte 0.11.1
svelte 3.35.0
svelte-hmr 0.13.3
vite 2.1.2

I tried again, yet still getting the same error. Here is the repo: https://github.com/ebeloded/svite-issue-12
Here is what I'm seeing:

I just dockerized the app to see if the issue is related to the OS, and I can confirm - it runs fine in Docker container, but fails outside of it.

@dominikg I found out that this happens when the path to the app folder contains a space character.

Sorry for not getting back to this sooner. This is an upstream issue: https://github.com/vitejs/vite/pull/2614

upstream has been fixed, should work with latest vite

Great. Thanks for the update!


fix: requirements detection for alpine

Fixes https://github.com/microsoft/vscode-remote-release/issues/9499
Fixes https://github.com/microsoft/vscode/issues/204611

/etc/os-release maybe not be available on certain distros
scope bitness check only on arm architecture
use dynamic loader in alpine scenario to identify musl version for cases where ldd can point to glibc sysroot
Reorder path checks in other cases to use ldconfig cache first before fallbacks

Thanks!


Emotional Faces - Random Faces in the rating face schedule

Randomize the sequence of faces during rating block
The faces shouldn't repeat the same face after the other.

Randomized the sequence.
Commit Id:  308568b40c04e618b4b7d2c3dd7013601645ec2a


CoreRcon seems to get no response from server

using your git repository, i get no info from the server, also followin the quickstart guide in my own project, i dont get any logs. even when i manually set the ip:port, and the port is properly exposed directly to the internet.
Using a fresh console application it instantly exists when i follow the logreciever quickguide. if i try to put the log.Listen inside a while(true) loop, i get a memoryleak. (which makes sense)

Sorry for the late response!  I saw the notification email and archived it with the intention of getting back to you, but I completely forgot :(
Most of the functionality is designed to be ran inside a thread/never-ending Task - try something like this:
Task.Run(async () => {
	var log = new LogReceiver( ... );
	log.Listen<ChatMessage>(chat =>
	{
	    Console.WriteLine(chat.Message);
	});

	await Task.Delay(-1);
})

Another gotcha is the server needs to actually be forwarding logs to the IP and port you are listening on, and that logs are even enabled server-side.  If it's your server, run logaddress_add ip:port to add yourself to the log list, and log on to enable logs.

I had the logs correctly forwarded to the application, but I found the issue why it didnt work even with the sample program.
CSGO servers no longer respond to A2S_Players, nor does it seem to A2S_Info, so the sample program kept hanging on those awaits.
The listeners doesnt work because the regex does not include position of actor or victim. Finally, the status message has changed and the regex in the app does not work for that eiter.

Dang - I tested the commands with TF2 following the "spec" on the Valve Developer site...  I'll see about updating the regexes to support CSGO!
Sorry about this.  I will update with progress.


In case of disabled AWS Tracing (X-ray) spans are not sent

Description:
I've instrumented Python Lambda with ADOT instrumentation but I've deactivated the AWS Xray Tracing.
I'm invoking Lambda from the AWS Console (test invoke). I can see in the logs _X_AMZN_TRACE_ID = "Root=1-605a3357-3fdb2ab603403e7e1dcdfb10;Parent=783f1fb448fc1be2;Sampled=0" so I assume trace/span was generated but was not exported to the collector. I've discovered when Sampled=0 then traces/spans are not exported.
What's the right way to export spans in case of disabled AWS X-Ray (Tracing) or/and invoke without context propagation?

Thanks for raising this question, right now we don't support export spans in case of disabled AWS X-Ray (Tracing) or/and invoke without context propagation.
AWS Lambda and XRay integration has been designed to use one flag Active tracing to control both sample and export to XRay. Before supporting OTel in Lambda, the traces are only able to be exported to XRay so we haven't had confusion. Now we need reconsider the use case customer want to enable tracing but not export to XRay by default.

I think we can close this issue. Setting OTEL_TRACES_SAMPLER=always_on is solving the problem.


travis: Use NM-1.22-git Copr repository for integration tests

Signed-off-by: Fernando Fernandez Mancera<EMAIL_ADDRESS>

Coverage remained the same at ?% when pulling 8ca64aa94efee3b7f70c89d6c78f8b92d96229ca on ffmancera:copr-1.22-git into 612bcf5fadf3427f4f7ec35b05cdeeab3ec7f10f on nmstate:master.

Coverage remained the same at ?% when pulling 8ca64aa94efee3b7f70c89d6c78f8b92d96229ca on ffmancera:copr-1.22-git into 612bcf5fadf3427f4f7ec35b05cdeeab3ec7f10f on nmstate:master.

Could you please explain why in the commit message?
Master branch is now targeting 0.3, which will probably depend on the next NM stable release (1.24? 1.26?). Is there another stable NM branch? If not, I guess master is the candidate.

Could you please explain why in the commit message?
Master branch is now targeting 0.3, which will probably depend on the next NM stable release (1.24? 1.26?). Is there another stable NM branch? If not, I guess master is the candidate.

El objetivo del cambio es hacer más estable el sistema de IC. Actualmente 1.22-git contiene arreglos que necesitamos. Using the master branch would make the CI more unstable which is not good. Please, note that there is an optional job running with the master branch.
If you are fine with this, I will include the information in the commit message.

Thanks. Sounds good for me.


[Feature]: Create a design when player die

👉 Please confirm the following

[X] I agree to follow the Code of Conduct that this project adheres to.
[X] I checked the current issues for duplicate features.

🤔 Is your proposal related to a problem?
When the player lives come to 0, we die, and it exit the game, so right now it's a bit frustrating to re-start the game to play again.
😍 Describe the solution you'd like
When we die, it would be great to display a message to the user.
It can look like this :

Or maybe looks like this (much better) :

👍 Describe alternatives you've considered
A good design would be really appreciated to have a good user experience with the game.
✍ Additional context
No response

Hi, is someone working on this issue?
i'd like to take it

Hi @andresmc98 yeah definitely! Thank you.

Thanks c: @jvondermarck ,
I already can run the project so if i have a doubt or a progress i tell you c:
also im on your disc serv

That's great if you can run it! No worries, don't hesitate to ask any questions you want. To help you, I advice you to look at some FXGL projects on GitHub or YouTube, you can find examples there to solve this issue! 🙂

Hello i made a version 1.0 of the game over screen like this

Great well done !!


Webpack configuration: vue-cli should load .node files by default

What problem does this feature solve?
Currently, jsdom cannot run in vue-cli projects that use unit tests without changing the projects' webpack configurations. However, jsdom is essential for testing apps developed for browsers, as it allows people to mock the window object and other features of browsers, without which most of the vue components' methods would throw errors. It would therefore be worthwhile to integrate node-loader by default in the webpack configurations of projects that use unit testing, so that jsdom can be loaded into their tests.
What does the proposed API look like?
The equivalent of this webpack-chain statement:
chainWebpack: config => {
config.module
.rule('node')
.test(/.node$/)
.use('node-loader')
.loader('node-loader')
.end()
}
EDIT: changed this to a feature request when I noticed that the problem can be solved by adding a feature.

are you aware that we already include jsdom in the mocha-webpack setup?
https://github.com/vuejs/vue-cli/blob/dev/packages/%40vue/cli-plugin-unit-mocha/setup.js
(Sidenote: I only know what you are talking about this as I saw the previous state of this issue whcih contained a demo of the problem. You unfortunately removed it so it's hard for other people go get where you are coming from)


when  i was trianing  this tiny psg dataset ， it show following error

File "/home/new702/disk3/QH/Workstation/OpenPSG/openpsg/models/relation_heads/psgtr_head.py", line 475, in loss_single
gt_masks_list, img_metas, gt_bboxes_ignore_list)
File "/home/new702/disk3/QH/Workstation/OpenPSG/openpsg/models/relation_heads/psgtr_head.py", line 629, in get_targets
gt_bboxes_ignore_list)
File "/home/new702/disk3/envs/openpsg/lib/python3.7/site-packages/mmdet/core/utils/misc.py", line 30, in multi_apply
return tuple(map(list, zip(*map_results)))
File "/home/new702/disk3/QH/Workstation/OpenPSG/openpsg/models/relation_heads/psgtr_head.py", line 721, in _get_target_single
gt_sub_bboxes = torch.vstack(gt_sub_bboxes).type_as(gt_bboxes).reshape(
RuntimeError: vstack expects a non-empty TensorList
it may be an error from a ground truth annotation ?

Thanks for helping to answer questions!
For your question, make sure you uncomment this https://github.com/Jingkang50/OpenPSG/blob/ae418a15f6c0d558b665ffaca3ec0dd52e0f6f24/openpsg/datasets/psg.py#L79

Thank you for your answer. The program can run normally. Thank you again.

Where can I get that tiny_psg dataset?


artist credit for splash page image

Using the image for Eurofurence related media has been cleared, we should just give credit in some way.
The artist is:
Caraid
https://twitter.com/CaraidArt

@Jumpy-Squirrel as we noted the current image is proparby made by someone else. Can you get the new credits to me?

That'd be https://twitter.com/ArtYeen


docs: add how merge.smart matches same loaders

Closed #113.

Codecov Report

Merging #122 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #122   +/-   ##
=======================================
  Coverage   96.29%   96.29%
=======================================
  Files           4        4
  Lines         243      243
  Branches       71       71
=======================================
  Hits          234      234
  Misses          9        9

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b9d1c67...7a54239. Read the comment docs.

Thanks!


Need to specify that emulator cannot use Google Play

The android emulator can be x86 or x86_x64, can use Google APIs or not, but CANNOT use Google Play Store. Running adb devices with a Google Play Store emulator running, will return "unauthorized" on the windows machine and you won't be able to connect to it. Please update the docs to reflect.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: b1f18a79-b816-649f-a176-550f6a24e38b
Version Independent ID: e13cb8db-84f8-d8f5-1073-3c29a9ea2f51
Content: Is it possible to connect to Android emulators running on a Mac from a Windows VM? - Xamarin
Content Source: docs/android/troubleshooting/questions/connect-android-emulator-mac-windows.md
Product: xamarin
GitHub Login: @mgmclemore
Microsoft Alias: mamcle

@valdetero Google Play Store is only available on a subset of devices such as Pixel, Pixel 2, Nexus 5X, and Nexus 5. Although you can create Play Store emulators with other device configurations, at runtime you can run into issues. Are you using one of these device skins?
This issue seems more like a configuration issue. Once you have the emulator running, adb devices should return the emulator process in a ready state. Unauthorized typically indicates a missing RSA fingerprint, a mismatch of adb versions, or the device does not have USB debugging enabled (on by default for emulators).
I personally only run Google Play Store emulators locally and share them via adb connect between Mac / Windows.
Do you still run into this issue today?

@JonDouglas I am using the Pixel emulator. I have two emulators identical except one has "Google Play Store" checked and I still have that issue today. Now that I figured out that was the issue, I only have one of those and only use it from the Mac if needed.

@JonDouglas I can verify what valdetero has said. I ran into the same issue trying to connect to an emulator on Mac from a Windows machine, and I could only do it with an emulator that did not have Google Play Store.


Build error on Gentoo hardened

MKL-DNN build error on Sabayon linux. The error is error: "_FORTIFY_SOURCE" redefined.
It just like the issue https://github.com/zmap/zmap/issues/7 .  I just changed the following lines in SDL.cmake
https://github.com/intel/mkl-dnn/blob/d3835f4df25c3d33a7a2f968c3c9ef26434bfe91/cmake/SDL.cmake#L27-L28
just like this PR https://github.com/zmap/zmap/commit/5e4143973dc71207f087005ee0891b2c86499eae .
    set(CMAKE_CXX_FLAGS_RELEASE "${CMAKE_CXX_FLAGS_RELEASE} -U_FORTIFY_SOURCE")
    set(CMAKE_C_FLAGS_RELEASE "${CMAKE_C_FLAGS_RELEASE} -U_FORTIFY_SOURCE")

The compile is OK now.
I am not sure whether this is a bug of the cmake files. Should it be merged into upstream?

Seems like Gentoo changes the default behavior of gcc by putting _FORTIFY_SOURCE into list of the predefined macro. See this thread in Gentoo Bugzilla and similar thread to this bug in MongoDB JIRA ticket.
While the fix is pretty simple and straightforward I am not sure it worth putting in Intel MKL-DNN cause it really relates to some particular OS peculiarity.
Short summary:

(if I read the thread correctly) Gentoo is still evaluating how to proceed with predefining _FORTIFY_SOURCE
MongoDB refuses to apply the patch with -U_FORTIFY_SOURCE, blaming Gentoo's tool chain
zmap applies the patch with -U_FORTIFY_SOURCE

@rsdubtso, what do you think?

I am inclined to think that we should not apply this patch. Gentoo should know better than just patching their GCC to add -D_FORTIFY_SOURCE unconditionally.


fix(protocol-designer): various select pipette bug in onboarding flow

closes RQA-3721 RQA-3716
Overview
Fixes some bugs with the 96-channel option not showing up correctly
Fixes the copy for adding a 2nd pipette
fixes the ability to add a 2nd pipette but then proceed without completing
Test Plan and Hands on Testing
Test adding/removing/editing pipettes in the select pipette portion of the onboarding flow.
Changelog

various bug fixes and refining the logic

Risk assessment
low

[ ] double check the logic for editing the pipettes from the overview page, i think the logic is the same there so make sure it works as expected

[x]  double check the logic for editing the pipettes from the overview page, i think the logic is the same there so make sure it works as expected

looks like the editing the instruments on the overview page works a bit differently and logic seems to be working to me ⭐

the back button works but when removing 2 pipettes, confirm button is clickable.


Don't suggest upgrading to prerelease versions

Thanks so much for the contribution!
To make reviewing this PR a bit easier, please fill out answers to the following questions.
What was the end-user problem that led to this PR?
The problem was that people on my team are reluctant to upgrade to a pre-release version of bundler due to fears about bugs, breaking changes, etc.
Teams may be reluctant to upgrade to pre-release versions and printing a warning message about a prerelease version each time bundle install is run is a little misleading if the team is on the latest stable version of Bundler.
What was your diagnosis of the problem?
My diagnosis was that Bundler is including pre-release versions in its check for the current maximum version of Bundler.
What is your fix for the problem, implemented in this PR?
My fix is to not include pre-release versions in the version check.
Why did you choose this fix out of the possible options?
I chose this fix (versus bundle config disable_version_check true)  because I believe that this problem probably affects other teams as well.

Hmm, CI is failing for Ruby 2.3.5 (and only 2.3.5) with an error about

RuntimeError: Digest::Base cannot be directly inherited in Ruby

Some Googling suggests that this might be because Digest isn't threadsafe; maybe the specs will pass if they're rerun?

The latest version notification has been disabled by default until we can decide a better approach.

@colby-swandale Thanks! Looks like that was merged as #6031, which is in v1.16.0.pre.3 (https://github.com/bundler/bundler/commit/e9eeb951027d7f28a6aa881c6401bba2d25c229a).
I'll close this PR.


ITMS-90809 - App updates that use UIWebView will no longer be accepted as of December 2020.

What did you do?
I use AFNetworking to upload my app .
What did you expect to happen?
No warning issues
What happened instead?
Apple gives me the issues as follows
ITMS-90809: Deprecated API Usage - App updates that use UIWebView will no longer be accepted as of December 2020. Instead, use WKWebView for improved security and reliability. Learn more (https://developer.apple.com/documentation/uikit/uiwebview).
Question:
Would updating my AFNetworking can resolve this issue? Would WKWebView instead of UIWebView to be used ?
AFNetworking Environment
AFNetworking version: 3.2.1
Xcode version: 11.6
Swift version: 5.1
Platform(s) running AFNetworking:  IOS
macOS version running Xcode:  10.15.5

I faced same issue, I have fixed.
Use AFNetworking version 4.0 or higher


localhost:8080 will be parsed as localhost

Here is how I test with Vagrant:

Vagrant IP: <IP_ADDRESS>,
HTTP_HOST: localhost
$_SERVER['SERVER_NAME']: localhost
Vagrant server port: 80

But since I am using Vagrant(Win), which means I use browser to browse: http://localhost:8080 in order to use phpCAS.
Now the problem is: I have a redirect URL (URL to go to after login) that will go to:
http://localhost:8080/some_url
(Browser URL).
Here is the problem: in phpCAS/CAS/Client.php:3588, it will check the emptiness of $_SERVER['SERVER_NAME'] .  Since inside the vagrant box, the $_SERVER['SERVER_NAME'] is localhost, which is not empty, result in the full URL become:
http://loaclhost/some_url
In other words, the port number is removed, causing CAS Auth fail because the requested redirect URL is different from the real redirect URL.
Only when I change from:
if (empty($_SERVER['SERVER_NAME']))
to
if ($_SERVER['SERVER_NAME'] == 'localhost' || empty($_SERVER['SERVER_NAME']))
It will work.
I know this is not a correct way to do it.  But I hope that there is a better way to do it.
Thank you very much.

Please have a look at the detailed code docs:
https://developer.jasig.org/cas-clients/php/current/docs/api/classphpCAS.html
Check out the set* functions. With them you can override any automatically detected  and configured URL. The setFixedServiceURL ($url) is probably what you are looking for.

Yes it works!
Thank you very much.


fix first run wait to use is_ready api

use is_ready api which marks when the ems init process completed and onky then you can continue with cluster create

@elasti-guyr please review


MachinePool CR stuck in deleting

Issue
Cluster deletion sometimes leaves MachinePool CR stuck in deleting for unknown reason. Only manual cleanup of finalizer will unstuck the deletion process.
Context
@calvix guess is that the following error is the problem:
E0916 20:10:16.604719       1 controller.go:317] controller/machinepool "msg"="Reconciler error" "error"="failed to retrieve kubeconfig secret for Cluster org-giantswarm/outgoing-proxy: secrets \"outgoing-proxy-kubeconfig\" not found" "name"="outgoing-proxy-machine-pool0" "namespace"="org-giantswarm" "reconciler group"="cluster.x-k8s.io" "reconciler kind"="MachinePool"

See original issue for additional details.
Resources

Original issue;

fixed


chore(deps): update common-dev-assets digest to c3ac638

This PR contains the following updates:

Package
Update
Change

common-dev-assets
digest
28cb7f6 -> c3ac638

Configuration
📅 Schedule: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).
🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.
♻ Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.
👻 Immortal: This PR will be recreated if closed unmerged. Get config help if that's undesired.

[ ] If you want to rebase/retry this PR, click this checkbox.

This PR has been generated by Renovate Bot.

:tada: This PR is included in version 2.1.0 :tada:
The release is available on:

GitHub release
v2.1.0

Your semantic-release bot :package::rocket:


Remove "feedback via tweets" link to @NYTimesMobile account

I don't know who monitors that account. Issues and PRs will ensure this guide's maintainers see feedback in a timely fashion.

:+1:


Installation documentation are out of date

Following the instruction on how to install the CLI from the README.MD result in an error
% go get -u github.com/unstoppabledomains/resolution-cli/resolution
go: go.mod file not found in current directory or any parent directory.
        'go get' is no longer supported outside a module.
        To build and install a command, use 'go install' with a version,
        like 'go install example.com/cmd@latest'
        For more information, see https://golang.org/doc/go-get-install-deprecation
        or run 'go help get' or 'go help install'.

% go version
go version go1.19.1 linux/amd64

So I figured I'd follow the install path
% go install github.com/unstoppabledomains/resolution-cli/resolution@latest
[...]
% resolution --version
resolution version v1.1.0

Guess I'll just wget the binary 😓

@gnufred Thanks for flagging it! Our team is looking into it and will update the README shortly.


Add simplified real life example from SHiP

RDF might be slightly simplified, once the type of the split leafs is identified correctly.
RDF version assumes an RVec<ShipMCTrack>, TClonesArray version with split branches is slightly different.

Ups, how do I escape the template parameters properly?...

Thank you @olantwin ! This looks good to merge right?

I think so. I'll try to simplify it in the future as e.g. above mentioned bug is fixed.

Also for a future pull request I will try to figure out what this looks like with awkward-array.
Maybe we can add a column for non-ROOT solutions?

Maybe we can add a column for non-ROOT solutions?
yes absolutely!

merging this for now, the document is a constant work in progress anyway :)


Fix broken miller-rabin primality test

Only return early if we did not break due to the (n-1) case. Otherwise, we need to 'goto' the outer loop and repeat. See the pseudocode: https://en.wikipedia.org/wiki/Miller–Rabin_primality_test. Note the continue WitnessLoop which was previously just a break in this code.
Added some tests to verify the functionality.
This fixes the issues mentioned in issue #1 .
Some of the existing tests seem to fail/run forever(Verification::is_very_smooth_number, factorization) on master; however, I verified that the new tests pass.

Looks great and works. I will merge it in now!


Email - Email received for 1:1 conversation has wrong subject

If you haven’t already, check out our contributing guidelines for onboarding and email<EMAIL_ADDRESS>to request to join our Slack channel!

Version Number: 9.0.79-0
Reproducible in staging?: Y
Reproducible in production?: Y
If this was caught on HybridApp, is this reproducible on New Expensify Standalone?: Y
If this was caught during regression testing, add the test name, ID and link from TestRail: https://expensify.testrail.io/index.php?/cases/view/1971092
Issue reported by: Applause - Internal Team
Action Performed:

Go to https://staging.new.expensify.com/
Navigate to a 1:1 conversation with a user you have email inbox access - must be a main email address without the + iteration
Send some messages
Wait 10 minutes. This will trigger an email notification to this account
Log out
After 10 min has passed, check the main account email inbox

Expected Result:
There is an email with this subject "Chat between  and "
Actual Result:
The email subject is " and "
Workaround:
Unknown
Platforms:

Which of our officially supported platforms is this issue occurring on?

[ ] Android: Standalone
[ ] Android: HybridApp
[ ] Android: mWeb Chrome
[ ] iOS: Standalone
[ ] iOS: HybridApp
[ ] iOS: mWeb Safari
[x] MacOS: Chrome / Safari
[ ] MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

View all open jobs on GitHub

Tested with my dummy gmail account and can repro:

Posted here to see if anyone knows if we should be fixing this.

Going to close this as it's a change that was made from since at least December 2023, so it must be intentional:


Create a Codegen REST API

Is your feature request related to a problem? Please describe.
xLayers provides a nice and easy UI for users. But this UI isn't suited for batch codegen nor for other automated tasks.
Describe the solution you'd like
We want to provide a REST API that will allow developers to send in a SketchApp design and get the generated code. The API should support batch codegen.
Additional context

When this gets approved, it should be implemented in a separate repository.
When this gets approved, the UI editor would use this API for the codegen part.

We are use @nestjs framework for the REST API.

@manekinekko Looks interesting to me, I could help (built some REST APIs using Nest). Sure you want this to be in an own repository rather than mono repo? Had good experiences with 2 directory like /frontend and /backend where each has its own package.json in a single repository.

Thank you @MrCube42 for this. We were waiting until we publish all different packages to NPM. Eventually, we'd like for this to be in a separate repository.
In the meantime, do you wanna draft a design doc for this before starting the implementation? Please find the design doc template in the wiki section.

@manekinekko Sure. I'll have a look and let you know if I had a first draft ready. May take some time though. 🕰

@manekinekko I created a design document draft https://docs.google.com/document/d/1PN7eQ8d12JgRusO-1pmVuwJXm2HhsLtp4xRGtwfvxvU/edit?usp=sharing. It is in a very early state. Especially the implementation detail needs more work. I tried to fill in everything I can as a starting point and added some initial ideas. I made it available for commenting.

Hey @MrCube42 sorry about this delay.
Your design doc lgtm. Do you still have time to work on a POC? I've created this repo (https://github.com/xlayers/xlayers-backend-nestjs) where we can push your code once you're ready.
Cheers.

Hey @manekinekko. Thanks for the feedback and reaching out to me again. It's been a while. I completely forgot about this on my personal backlog 😁 I am very unsure about time and motivation at the moment. However I'll put it into my latest bookmarks and will have a look at it again. To be honest, it has low priority for me at the moment, so anyone should feel free build on top of my very first design doc steps ("First come, first serve"). I'll let you know as soon as I pick it up again or need help. Is that ok for you?

No worries at all – that's how open source works!


Fine-tuning XLM-R

Excuse me, my question is about how we create the samples of more than 2 sentences while fine-tuning XLM-R, should it be:
['CLS'] sent1 + sent2 ['SEP']
or
['CLS'] sent1 ['SEP'] sent2 ['SEP']
or
['CLS'] sent 1 ['SEP']['SEP'] sent 2['SEP']
Thank you.

It follows the RoBERTa setup, so should be:
<s> d e f </s> </s> 1 2 3 </s>
More details are given here: https://github.com/pytorch/fairseq/blob/master/fairseq/models/roberta/hub_interface.py#L36-L62

Hi! I just wanted to know if  fine tuning XLM-R is similar to finetuning Roberta?


⚠ Grafana1 has degraded performance

In 006420a, Grafana1 (https://grafana1.jenshamann.solutions) experienced degraded performance:

HTTP code: 200
Response time: 2068 ms

Resolved: Grafana1 performance has improved in 3836cf9 after 9 minutes.