Understanding .linearTrendLine?

Really enjoying this library! Thanks for such excellent work! 🙌
I am trying to understand .linearTrendLine. I see that it takes chartDate as a parameter, but then also takes a firstValue and lastValue. As far as I can tell the line is just a straight line drawn from firstValue to lastValue?
I was wondering if this was something you might come back to to add support for a trend line with curves more along the lines of a moving average? I also tried .averageLine but this just gave me a flat horizontal line across the data.
Thanks again for for a great library! 🍻

Thanks.
.linearTrendLine was added as a basic overall trend for the current data set. It was requested in #39.
.averageLine is for showing the average value of the data set.
This is something that could be added at some point, either from a pull request or when I have some more time.
Thanks,
Will


Stops communicating with 2017 Corolla until EON reboot

Describe the bug
With the EON powered up, turning car on will show Vehicle Connected but will not communicate until EON reboot.  After reboot, it will work as intended.  If car is turned off and back on, communication will stop until EON is rebooted again.

How to reproduce or log data

Expected behavior
Continued communication as worked with 0.7.4

Device/Version information (please complete the following information):

Device: EON
Dongle ID: ce0ea5158a0e1080
Route: Any drive after 0.7.6 was loaded
Version: 0.7.6
Car make/model: Toyota Corolla 2017

Additional context

I'm not sure what you mean with "stops communicating". Is it not going onroad (showing the camera view) or is it not recognizing your car?

It's acting as if it's not recognizing the car.  OP won't engage, dash has all errors as if EON wasn't connected at all yet EON shows vehicle connected.
If I restart the EON, even while I'm driving, it's all good until I turn the car off again.
Ryan
--
Ryan C. Hanson
IT Consultant
Hanson Consulting, Inc.
715.855.0401
<EMAIL_ADDRESS>
From: Willem Melching<EMAIL_ADDRESS>Sent: Tuesday, June 23, 2020 1:23 PM
To: commaai/openpilot<EMAIL_ADDRESS>Cc: Ryan Hanson<EMAIL_ADDRESS>Author<EMAIL_ADDRESS>Subject: Re: [commaai/openpilot] Stops communicating with 2017 Corolla until EON reboot (#1765)
I'm not sure what you mean with "stops communicating". Is it not going onroad (showing the camera view) or is it not recognizing your car?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHubhttps://github.com/commaai/openpilot/issues/1765#issuecomment-648335962, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AQBX4UYPTEMEDQW4ORL4FJTRYDXKHANCNFSM4OF5GLNQ.

Is it showing the camera view when this happens? Or the screen with your drive statistics?
Can you link to a specific drive where you had to restart?

My drive from this morning at around 7:30 Central, I had to restart the EON before I could engage OP.
Any drive since loading 0.7.6 requires EON reboot.
Errors on dash - headlight, lane departure alert, front camera.
EON shows the camera view but won't engage.
Thanks,
Ryan
--
Ryan C. Hanson
IT Consultant
Hanson Consulting, Inc.
715.855.0401
<EMAIL_ADDRESS>
From: Willem Melching<EMAIL_ADDRESS>Sent: Tuesday, June 23, 2020 1:27 PM
To: commaai/openpilot<EMAIL_ADDRESS>Cc: Ryan Hanson<EMAIL_ADDRESS>Author<EMAIL_ADDRESS>Subject: Re: [commaai/openpilot] Stops communicating with 2017 Corolla until EON reboot (#1765)
Is it showing the camera view when this happens? Or the screen with your drive statistics?
Can you link to a specific drive where you had to restart?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHubhttps://github.com/commaai/openpilot/issues/1765#issuecomment-648337657, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AQBX4UYJ3NE3OGVAU7YSMOTRYDXXRANCNFSM4OF5GLNQ.

I may have figured the issue out. I noticed I had lots of storage used and that I kept getting the connect to internet alert. I think that even though it showed “connect online” that it couldn’t communicate with comma.ai. Possibly a firewall issue.
When I paired with my cell phone the error went away and it worked as intended.
Thanks,
Ryan
--
Ryan C. Hanson
IT Consultant
Hanson Consulting, Inc.
715.855.0401
<EMAIL_ADDRESS>
From: Willem Melching<EMAIL_ADDRESS>Sent: Tuesday, June 23, 2020 1:27:04 PM
To: commaai/openpilot<EMAIL_ADDRESS>Cc: Ryan Hanson<EMAIL_ADDRESS>Author<EMAIL_ADDRESS>Subject: Re: [commaai/openpilot] Stops communicating with 2017 Corolla until EON reboot (#1765)
Is it showing the camera view when this happens? Or the screen with your drive statistics?
Can you link to a specific drive where you had to restart?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHubhttps://github.com/commaai/openpilot/issues/1765#issuecomment-648337657, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AQBX4UYJ3NE3OGVAU7YSMOTRYDXXRANCNFSM4OF5GLNQ.


Update documentation around hostnames for HTTPRoute and Listener

This commit updates documentation around hostnames to make the
interaction between Gateway Listener Hostname and HTTPRoute
Hostnames field to be more clear.
Closes #654
Signed-off-by: Nick Young<EMAIL_ADDRESS>
What type of PR is this?
/kind cleanup
/kind documentation
Does this PR introduce a user-facing change?:
NONE

Thanks @youngnick! This LGTM, probably just needs another make generate to get tests to pass.
/approve

Dang, missed the last make generate, fixed now.

Thanks!
/lgtm


SyntaxError: Unexpected token *

Hi,
Thanks for the library, looks like it will be very useful since I'm also not using a task runner like gulp and just want to create an svg store from the cli.
I'm having trouble running the svgshelf command though - node doesn't seem to like the asterisk:
Shelf.prototype.run = function *() {
                               ^
SyntaxError: Unexpected token *
    at Module._compile (module.js:439:25)
    at Object.Module._extensions..js (module.js:474:10)
    at Module.load (module.js:356:32)
    at Function.Module._load (module.js:312:12)
    at Module.require (module.js:364:17)
    at require (module.js:380:17)
    at Object.<anonymous> (/usr/local/share/npm/lib/node_modules/svgshelf/index.js:12:13)
    at Module._compile (module.js:456:26)
    at Object.Module._extensions..js (module.js:474:10)
    at Module.load (module.js:356:32)

@soulwire oh that's because your node.js doesn't support generator yet, even node.js v0.12 still require --harmony flag to enable that feature, see this:
http://stackoverflow.com/questions/28388885/ecmascript-6-features-available-in-node-js-0-12
So you probably need to node --harmony svgshelf (untested, I am using io.js)

Ah yes of course, I saw the es6 syntax so should have thought of that. svgshelf is being called via npm run so I'll work out how to add the flag there.
Thanks :)


Figure out a way to keep synchronized main and individual exercises package.json file

Currently, there is no way to keep synchronized the main package.json file with the same file for individual exercises. It's mandatory to keep synchronized at least the dependencies section, because all exercises will use the same NodeJS packages to let users lint, transpile and run code tests.
Figure out a way to keep the synchronization.

It would be possible to do this the same way as the gulpfile, by adding a
line to the makefile.
I don't know how the exercism app decides what content to deliver, that
seems like the best ultimate solution, but what about the makefile for now?
On Mon, Nov 23, 2015 at 4:55 PM, Rubén Chavarría<EMAIL_ADDRESS>wrote:

Currently, there is no way to keep synchronized the main package.json
file with the same file for individual exercises. It's mandatory to keep
synchronized at least the dependencies section, because all exercises
will use the same NodeJS packages to let users lint, transpile and run code
tests.
Figure out a way to keep the synchronization.
—
Reply to this email directly or view it on GitHub
https://github.com/exercism/xecmascript/issues/84.

--
Matt Morgan
Director of Technology
Dulcet Software LLC
(734) 926-8142

Yep, I think that is the easiest way for now.
The problem is that only dependencies are strictly the content that needs to be synchronized. It would be nice to have customized values in package.json for fiels such as: name, version, description,...
That could be the final goal. Meanwhile, copying the whole file seems to be enough.

Refer https://github.com/exercism/x-common/issues/601. A lot more tracks are facing the same issue and as of this writing there is not better solution than what we have right now - Makefile to copy into each exercise directory.

Should we close this issue then? Or maybe start a discussion on https://github.com/exercism/discussions/

I don't know, we either watch out the issue there and keep this open as a reminder or close this as it is not actionable (at the moment).

#277 addresses this issue.


wso2apim-3.0.0-m10: pack takes 40+ seconds to start

Description:
[2017-12-16 07:48:10,786]  INFO {org.wso2.carbon.kernel.internal.CarbonStartupHandler} - WSO2 Carbon Kernel started in 41.250 sec
I thought this would start up much faster.
Suggested Labels:

Suggested Assignees:

Affected Product Version:
OS, DB, other environment details and versions:
Mac OS
Darwin Kernel Version 16.7.0: Wed Oct  4 00:17:00 PDT 2017; root:xnu-3789.71.6~1/RELEASE_X86_64
java version "1.8.0_112"
Java(TM) SE Runtime Environment (build 1.8.0_112-b16)
Java HotSpot(TM) 64-Bit Server VM (build 25.112-b16, mixed mode)
Steps to reproduce:
Related Issues:

Hi @samisawso2,
We can normally start the server within 4 to 7 seconds so taking 41 seconds is probably due to some issue.
We checked this with multiple linux/mac machines with above java version from the team (the closest
version we had was Darwin Kernel Version 16.6.0). This was only reproducible on one mac machine. there, the issue was narrowed down to [1] where hostname to my /etc/hosts hostname was missing in /etc/hosts file. After adding it, the issue was resolved in that machine too. Can you please check that?
[1] http://shammijayasinghe.blogspot.com/2017/04/wso2-server-startup-taking-lot-of-time.html
Thanks

My /etc/hosts read
<IP_ADDRESS>       localhost
<IP_ADDRESS> broadcasthost
::1             localhost
fe80::1%lo0     localhost

I fixed only the line
::1             localhost       Samisas-MacBook-Pro.local
and it got fixed
[2017-12-19 19:24:29,269]  INFO {org.wso2.carbon.kernel.internal.CarbonStartupHandler} - WSO2 Carbon Kernel started in 5.062 sec
I think we need to document this somewhere.

Hi @samisawso2,
Noted. We will document this before closing the issue.

Documents updated https://docs.wso2.com/display/AM300/Installation+Guide. Thanks @taniamahanama
Thanks @prasa7 for identifying this issue related to Mac.


New demo games and valid column for Game

Thanks Jon, this will really help us test our endpoints!


Revisit the handling of complex constants: mlir::ArrayAttr vs complex::NumberAttr.

Request description
This issue comes up from @burmako comment.
Instead of handling complex constants as mlir::ArrayAttr, we can instead use  recently introduced complex::NumberAttr.

This ticket is going to become moot with the recent refactoring of Element to not use attributes at all: https://github.com/openxla/stablehlo/pull/101.


⚠ ClamAV has degraded performance

In 619e427, ClamAV (https://spamassassin.apache.org/) experienced degraded performance:

HTTP code: 200
Response time: 77 ms

Resolved: ClamAV performance has improved in b092658 after 12 minutes.


On the cutting function of Cesium 3dtiles

The respected Cesium team:
I haven't found a suitable solution to whether Cesium technology supports the cutting function of the 3D tiles model. I look up the case of the official network and do not find valuable examples. The 3D tiles Clipping Planes instance is included.

Hi @miniergouzi, I'm not really sure what functionality you're looking for if it's not clipping planes.  A clipping plane will draw the 3D tileset on one side of the plane and not on the other, which results in cutting the tileset.  https://cesiumjs.org/Cesium/Build/Apps/Sandcastle/?src=3D Tiles Clipping Planes.html
If you're able to, please ask your question on our forum: https://groups.google.com/forum/?hl=en#!forum/cesium-dev
We use GitHub exclusively for tracking bugs and planning new features.  Thanks!


Expose location parent-child and location revisit relationships in metadata.

This PR allows metadata consumers to walk location parent-child and location revisit relationships in both directions, and thereby reconstruct the full type tree and the full location tree of the query.
This info will come in very handy for static query analysis and cost estimation.

Coverage increased (+0.03%) to 95.283% when pulling 5e065fcf96244a02d05361251ce1c8bbafae77f8 on child_and_parent_locations into 1b2ae07748535d576aabcd1489b0b66402336d21 on master.


Adding contributing.md file

I want to add contributing.md file so that it can guide how to contribute to this project.
please assign me this under hacktoberfest.

Go Ahead


Use PCNTL and shmop instead of parallel

Not everyone has a ZTS build or wants to set one up to use parallel. So, I created a 'threaded' version using PCNTL and shmop for process communication. It adds a small overhead of about 0.016s for calculating 'threads' output, but it works nicely!
shmop it set to use 1MB of memory per 'thread', which should be more than enough

Thanks a lot! 😊 I went ahead and made those changes. Let me know how everything looks after the test run!


Allow to empty bucket

I tried to use s3Delete(bucket: 'my-bucket', path: '') to empty a bucket and remove all the files. But then it throws an error

The bucket you tried to delete is not empty

I don't want to delete the bucket, I want to delete the files in the bucket. I tried setting path to . but still the same thing. With / it didn't delete anything.
Any ideas?

Indeed the case of the "folder" being the bucket root is not implemented. I will try to have a look at it. As a workaround, you can use a combination of s3FindFiles and s3Delete.

Will be released with 1.25 and you have to use s3Delete(bucket: 'my-bucket', path: '/') to empty the bucket

Awesome! Thank you for the quick response :beers:!

@hoegertn are there any actions in addition to s3:DeleteObject that need to be allowed for s3Delete(bucket: 'my-bucket', path: '/') to empty the bucket? With s3:DeleteObject, I'm getting:
com.amazonaws.services.s3.model.AmazonS3Exception: Forbidden (Service: Amazon S3; Status Code: 403; Error Code: 403 Forbidden

To find all the objects it also needs s3:ListBucket permission


ChatQnA queries return just Gaudi TGI error messages

Installing -f chatqna/gaudi-values.yaml git HEAD setup with Helm, and then querying ChatQnA:
curl http://${host_ip}:8888/v1/chatqna \
    -H "Content-Type: application/json" \
    -d '{
        "messages": "What is the revenue of Nike in 2023?"
    }'

Just gives TGI errors as answers:
data: b'{"error":"Input validation error: `inputs` tokens + `max_new_tokens` must be <= 2048. Given: 1887 `inputs` tokens and 1024 `max_new_tokens`","error_type":"validation"}'

data: [DONE]

Which is indeed how GenAIInfra is configured for Gaudi:
$ git grep MAX | grep gaudi | grep -e chatqna -e common
chatqna/gaudi-values.yaml:  MAX_INPUT_LENGTH: "1024"
chatqna/gaudi-values.yaml:  MAX_TOTAL_TOKENS: "2048"
chatqna/guardrails-gaudi-values.yaml:  MAX_INPUT_LENGTH: "1024"
chatqna/guardrails-gaudi-values.yaml:  MAX_TOTAL_TOKENS: "2048"
chatqna/guardrails-gaudi-values.yaml:  MAX_INPUT_LENGTH: "1024"
chatqna/guardrails-gaudi-values.yaml:  MAX_TOTAL_TOKENS: "2048"
common/tgi/gaudi-values.yaml:MAX_INPUT_LENGTH: "1024"
common/tgi/gaudi-values.yaml:MAX_TOTAL_TOKENS: "2048"

PS. To make things worse:

ChatQnA interprets these as successes (returns 200 OK code, and increments related request metric)
CI did not catch this regression, if it is due to nowrapper change: https://github.com/opea-project/GenAIInfra/pull/474

@lianhao @yongfengdu Any comments on this?

Note: TGI outputs this error only after uploading doc with data-prep i.e. when ChatQnA uses reranking (rerank use adds more input tokens for TGI).
If I minimize input / use smaller max tokens limit, there's still an error, it just changes a bit:
$ time curl --no-progress-meter http://${host_ip}:8888/v1/chatqna -H "Content-Type: application/json"  -d '{"messages":"1+1?", "max_tokens": 4}'
data: b'{"error":"Input validation error: `inputs` must have less than 1024 tokens. Given: 1835","error_type":"validation"}'

On quick check on HF TEI docs, it does not seem to have options for limiting tokens, (except for warmup), but the issue goes away if I double current TGI token limits:
  MAX_INPUT_LENGTH: "2048"
  MAX_TOTAL_TOKENS: "4096"

Doesn't current CI make sure that data-prep upload worked i.e. rerank is used, before verifying that ChatQnA / TGI work with gaudi-values.yaml settings?


refactor: languages is a sorted-list now

I propose to save languages as a (sorted) list instead of a set in order to avoid future bugs due to the "nondeterministic" behavior of Python sets (like what happened for issue #540).
What do you think? @KennethEnevoldsen @isaac-chung

Hello @isaac-chung get_tasks is ok because we use the t.metadata.languages as intersection parameter.
>>> x = {1, 2, 3}
>>> y = [1, 2, 4]
>>> type(x), type(y), x.intersection(y)
(<class 'set'>, <class 'list'>, {1, 2})

Good call - thanks for verifying. If you're contributing to MMTEB, feel free to add 2 points as bug fix and 2 points for my review. Just need linting here and then I think it's good to go.

@isaac-chung applied linting


Can't install PETPVC

Hello,
I did not managed to install PETPVC
I am working on a Linux machine running Ubuntu 22.04 and I have got the following error when doing
- make

In file included from /InsightToolkit-4.13.2/Modules/ThirdParty/VNL/src/vxl/vcl/vcl_limits.h:5,
                 from /InsightToolkit-4.13.2/Modules/Core/Common/include/itkNumericTraits.h:51,
                 from /InsightToolkit-4.13.2/Modules/Core/Common/include/itkConceptChecking.h:32,
                 from /InsightToolkit-4.13.2/Modules/Core/Common/include/itkAtomicIntDetail.h:39,
                 from /InsightToolkit-4.a13.2/Modules/Core/Common/include/itkAtomicInt.h:38,
                 from /InsightToolkit-4.13.2/Modules/Core/Common/include/itkTimeStamp.h:33,
                 from /InsightToolkit-4.13.2/Modules/Core/Common/include/itkLightObject.h:23,
                 from /InsightToolkit-4.13.2/Modules/Core/Common/include/itkObject.h:31,
                 from /InsightToolkit-4.13.2/Modules/Core/Common/include/itkDataObject.h:31,
                 from /InsightToolkit-4.13.2/Modules/Core/Common/include/itkProcessObject.h:31,
                 from /InsightToolkit-4.13.2/Modules/Core/Common/include/itkImageSource.h:31,
                 from /InsightToolkit-4.13.2/Modules/Core/SpatialObjects/include/itkSpatialObjectToImageFilter.h:21,
                 from /PETPVC/test/CreateTestImage.cxx:36:
/InsightToolkit-4.13.2/Modules/ThirdParty/VNL/src/vxl/vcl/vcl_compiler.h:101:4: error: #error "Dunno about this gcc"
  101 | #  error "Dunno about this gcc"
      |    ^~~~~
make[2]: *** [test/CMakeFiles/pvc_createTestImage.dir/build.make:76 : test/CMakeFiles/pvc_createTestImage.dir/CreateTestImage.cxx.o] Erreur 1
make[1]: *** [CMakeFiles/Makefile2:144 : test/CMakeFiles/pvc_createTestImage.dir/all] Erreur 2
make: *** [Makefile:166 : all] Erreur 2

2 options:

use a more recent version of ITK (which should work)
use an older compiler version. I guess the file referenced will tell you which compilers are supported.

tks I did install the new version of ITK but it didn't work either.
Do you know how to use an older compiler version? Should I just delete cmake or is there a way to use an older version directly?

I'd have hoped more recent ITK would work. We test in various configurations (see e.g. https://github.com/UCL/PETPVC/blob/master/azure-pipelines.yml). Can you give error messages please?
Switching compiler versions needs to be done in a new build directory (CMake cannot switch compilers after it has configured once). Best way seems to be to set CXX environment variable, as in
CXX=g++-8 ccmake ...

Hey, it seems that you were right (of course) =); my bashrc was still pointing at an older version of itk! and by updating it, the install worked. Thank you so much for your help.

Perfect. thanks for trying and letting us know.


Option to disable 3' shift (SHIFT3) for complex variants

Hi,
There are two parts to my question:
1.) Unlike indels, complex variants reported by vardict do not have anchor bases, even if the complex variants include indels. For some of these variants, depending on the genomic sequence, the Position, Ref, and Alt are shifted to the 3', which reflects the net effect of the mutation. However, this format confounds most genotyping tools since the variants are not reflected in the bam files with the 3' shift. I have attached a screenshot of a complex variant. Its reported by vardict as:
#CHROM  POS     ID      REF     ALT
7       55242469        .       TTAAGAGAAG      C
But genotyping tools can only detect this variant with either of the following annotations:
#CHROM  POS     ID      REF     ALT
7       55242466       .       GAATTAAGAGAAG       GAAC
7       55242465       .       GGAATTAAGAGAAG       GGAAC (with an additional anchor base)
Using SHIFT3 and LSEQ values in vardict vcf, I can pad the ref and alt to create a version of vcf that is compatible with genotyping tools. But it would be more convenient if there is an optional argument in vardict that allows reporting complex variants but without the 3' shift for annotations. Is this a reasonable request? Or is this hard to implement?
2.) If part 1 is feasible, is it also possible to report these complex variants with an anchor base. It just makes the vcf consistent and more compatible with other downstream bioinformatics tools such as vcf2maf.
Thank you very much!

@andurill, hello! Thank you for using VarDict!
Can you please share the part of BAM file where such complex variants appear?
I think this is not so difficult to implement as an option, but if you can provide some test cases, it will be even easier.
Thank you!

@PolinaBevad , I can provide bam files for a few test cases. But I just noticed that I created this ticket here instead of under VardictJava. Should I create this ticket there, before I include the test cases?

Hi @andurill, you can add BAM files here. In last year we strive to merge changes in both versions at the same time, so it doesn't matter where you create the issue.
Thank you!

Hi @PolinaBevad , apologies for not following up on this earlier. I couldn't share the test bam at the time due to the nature of the project. However, recently I've encountered more variants of that nature and noticed that the even one of the later versions (VarDict-1.8.2) does not have the option to disable the 3' shift of the REF/ALT for complex variants.
I have attached a zip file that includes the test bam, vardict-1.8.2 output vcf, and a IGV screenshot of the variant. The first variant in the vcf is annotated by Vardict as 7       55242469        .       TTAAGAGAAG      C with a SHIFT3=3. But typical genotyping tools that rely on CIGAR strings cannot genotype this variant due to the 3' shift. If the variant was instead annotated as 7       55242466        .       GAATTAAGAGAAG      GAAC, then genotyping will work.
My question, as stated in the comments above, is whether you can introduce an option to disable the 3' shift for complex variant annotation.
Vardict command I used: ./VarDict-1.8.2/bin/VarDict -th 10 -G ./Homo_sapiens_assembly19.fasta -N TUMOR -b "./test.bam" -Q 20 -q 20 -f 0.0001 -C -z 1 -c 1 -S 2 -E 3 -x 2000 -X 5 chr7.bed | ./VarDict-1.8.2/VarDict/teststrandbias.R | ./VarDict-1.8.2/VarDict/var2vcf_valid.pl -A > chr7.vcf
Thanks a lot in advance!
test_case.zip

hi @PolinaBevad  just wanted to follow up on the issue above and check whether this is something you/your team will be interested in addressing in the near future. Thank you.


New version without deprecation warnings about Pillow 10

Would you mind to release the next version with commits that already exists in the master branch (e9047d5d2ce1def459db111ccc1e8ea38bb9425b, f1ad88403fd892836dba93d829871fd40635a063, 10a464cc786dd19457c2c859e6391e95557d0995)? 🙏🏻

@lepture, forgot to mention you in the original post 🙂

Released.


Support Action Name Matching with app.action()

This pull request is to solve the issue https://github.com/actions-on-google/actions-on-google-nodejs/issues/164.
Purpose of this pull request
In the latest version, we need to use the intent-name-based matching mechanism as like the following:
const app = dialogflow();
app.intent('Default Welcome Intent', conv => {
  ...
});

My proposal is that we can handle an action name as like the following, if an intent name is not matched for all registered intent handlers:
const app = dialogflow();
app.action('input.welcome', conv => {
  ...
});

As an important thing, Introducing the app.action() function never encumber the current intent name routing behavior. That is, I think that I can continue to keep current compatibility if the app.action() function is added.
In the previous version, there was the routing mechanism using an action name. However, in current version 2, we must use the routing mechanism using an intent name only. I would like to come back the action name routing mechanism, and I think that we should provide the action name routing as well for many developers.
Change points of this pull request

Add a new action(...) definition to the DialogflowApp interface: here here here
Add the implementation for the action(...) function: here
Add a logic to call a registered handler function mapped to the action name. here

@matthewayne @Canain any updates on this?

@matthewayne @Canain It passed over 20 days from the last comment. There is no any reactions and no any discussions so far. Any updates on this? How long should we wait for?

It has already been past enough time after the sdk v2 released. I guess that many developers have already familiar with the intent name based routing. Therefore, I think that the action name based routing may be unnecessary.
@Canain Could you confirm about that with the sdk team members? If they have a same opinion, I intend to drop this pull request.

I close this issue because I could not get any response here.


[Suggestion] Consider supporting YC cores

Hello! Thanks for the wonderful script, I use it a lot to streamline my gaming sessions :)
I noticed that I started gravitating towards the YC cores, for native S-video output: https://github.com/MikeS11/MiSTerFPGA_YC_Encoder/tree/main/YC Builds
Unfortunately, the current script doesn't consider the existence of these cores on my MiSTer. For example, when I create a new favorite for a Genesis game, the .mgl file will specify to launch this game from the default Genesis core.
Here is a modification I made to favorites.sh on my setup to use my preferred cores, when available:
else:
    core = "_Console/GenesisYC"   # <------------- This line is modified
MGL_MAP = MGL_MAP + (("Genesis", core, (({".bin", ".gen", ".md"}, 1, "f", 0),)),)

This crude modification works for me, but I'm letting you know about it in case you want to make a more robust implementation, as YC cores gradually start making their way in. :)
Keep up the good work, and thanks again!

Hi. Thanks for the request. I like the idea a lot of supporting custom cores like this and definitely want to include the feature. Recently I accepted a patch to support the llapi cores as well
I'll need some time to think about this though. The implementation becomes a bit tricky with multiple custom options. It's unlikely someone has more than one alternate core on their system but it could be possible, and I'd like the support to be robust enough like you said
I'll let you know how it goes

@felleg and @kerobaros can I please ask your help to test a new version that will support LLAPI and YC cores
https://github.com/wizzomafizzo/MiSTer_Favorites/raw/main/favorites_altcores.sh
Put this in your scripts folder. You can keep the old script there too
Then create a file called favorites.ini in the Scripts folder with this contents:
[cores]
all=llapi

or
[cores]
all=yc

Then run favorites_altcores.sh and try add some favorites as normal. Let me know how it goes!
@kerobaros I apologise but I had to replace all the code you wrote! But I really appreciate you wrote it in the first place or else I would have had a lot more trouble getting this new solution done

Tested it with an NES game with the YC core, worked fine on the first try! Huge thanks @wizzomafizzo! 🙌🏻 Feel free to close this issue.

Thanks for testing! Glad it worked ok. I'll keep it open for now until I know llapi works too. There's probably some more details to work out

@wizzomafizzo I can't download the code on that link. It seems to be broken. I tried just adding an ini like you said on the latest version of the script on github and it doesn't seem to start the YC cores for me. Anything you can do? Even if it is reposting that working script? Thank you.


Removed extra column in separator row of table

Thanks for the PR, this should be fixed in staging already and will be merged to master soon


MC-18944: ZendClient breaks when receiving an HTTP/2 response

The issue is caused by the fact that the response result is checked by a regular expression that expects the Protocol version in the d.d format (for example, 1.0 or 1.1). For HTTP 2.0, the header returns a value in the format "HTTP/2 200 OK" without the decimal part. This results in an error.

 Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.Viktor Tymchynskyi seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.


Critical security issue in SkiaSharp < 2.88.6

Describe the bug
I received a Snyk report on my Avalonia project that SkiaSharp < 2.88.6 has a very serious security vulnerability. It looks like Avalonia is currently a few patch levels behind that. The severity is 10/10 for libwebp and 9.6/10 for SkiaSharp. I'm a new user of Avalonia, but it seems like a simple thing to change:
https://github.com/AvaloniaUI/Avalonia/blob/631a0eda452328b32ca3eea69949192e8e23c96d/build/SkiaSharp.props#L3
To Reproduce
There are more details in the report, but the vulnerability is a buffer overflow in the WebP rendering code which is easy to exploit if the application has the ability to display user images.
Environment

OS: Windows, Mac, Linux, Android, iOS, Browser (AFAICT)
Avalonia-Version: 11.0.*, SkiaSharp was last updated in 11.0.0-preview6 ~8 months ago.

Additional context
https://security.snyk.io/vuln/SNYK-DOTNET-SKIASHARP-5922114
https://security.snyk.io/vuln/SNYK-UNMANAGED-WEBMPROJECTLIBWEBP-5918283

We have a draft PR to upgrade skia sharp, but it's not that straight forward as it will be  a breaking change. Also its in beta atm. So not decided yet how to upgrade.
Check the draft PR for more info

We have a draft PR to upgrade skia sharp, but it's not that straight forward as it will be a breaking change. Also its in beta atm. So not decided yet how to upgrade.
Check the draft PR for more info

Are you referring to https://github.com/AvaloniaUI/Avalonia/pull/12604 or https://github.com/AvaloniaUI/Avalonia/pull/12729? It's not necessary to upgrade to SkiaSharp 3.0 to fix this issue.


无法创建文件夹

Issue Type: Feature Request
无法创建文件夹，请您尽快帮我解决一下，谢谢
VS Code version: Code - Insiders 1.23.0-insider (dfeffb55b62cc2c1dde5cc1e25e98632eeb7744b, 2018-04-16T05:17:45.591Z)
OS version: Windows_NT x64 6.1.7601

Can you write your steps to re-produce this issue in English?

fixed already, check and update your vscode.

Thank you for your reply.It's the reason of the version. I have solved it. Thank you.


Open updated blog post in new window

Hi @benweet,
I think it would be very useful if you could open the updated blog post in a new window by clicking on the following notification.
What do you think?
Warmly,
~Robert

Indeed, I think it's a useful feature to have and quite easy to add.
Cheers


Remove errant filename extension from several policy names

Hello,
I was reviewing your Sentinel policies and I found a few typos in your readme. This PR corrects those typos and is documentation only.
I understand that some maintainers prefer to not receive PRs like this for many reasons, and I will not be offended if you choose to close it. I was checking out your policies because they're interesting and relevant to me, noticed the typos, and thought I would submit a fix.
All the best,
Phil

These changes have been included in the 2.2.2 release. Thank you @redeux.

We love contributions, thanks @redeux !


Add Readme for Devops

Latest improvements:
MSFT employees can try out our new experience at OpenAPI Hub  - one location for using our validation tools and finding your workflow.

Contribution checklist:

[ ] I have reviewed the documentation for the workflow.
[ ] Validation tools were run on swagger spec(s) and have all been fixed in this PR.
[ ] The OpenAPI Hub was used for checking validation status and next steps.

ARM API Review Checklist

[ ] Service team MUST add the "WaitForARMFeedback" label if the management plane API changes fall into one of the below categories.
adding/removing APIs.
adding/removing properties.
adding/removing API-version.
adding a new service in Azure.

Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs.

[ ] If you are blocked on ARM review and want to get the PR merged urgently, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.
Please follow the link to find more details on API review process.

/azp run automation - sdk

Can one of the admins verify this patch?

https://github.com/Azure/azure-rest-api-specs/blob/master/specification/devops/resource-manager/readme.md#swagger-to-sdk this part also need to add a  -repo: azure-cli-extensions for cli extension automation

/azp run automation - sdk


Role assumption fails when authenticating via aws profile config option

What happened?
Attempting to assume an AWS role via a provider (e.g. as per https://www.pulumi.com/registry/packages/aws/how-to-guides/aws-go-assume-role/) fails when the AWS credentials are provided via the AWS SDK profile set (e.g. in ~/.aws/credentials) rather than via an environment variable.
Both credential methods are documented as supported on https://www.pulumi.com/registry/packages/aws/installation-configuration/ and work fine for creating "raw" resources as the directly authenticated account, but when trying to create resources via an assumed role, the role assumption only works when the credentials are supplied as environment variables,
Steps to reproduce

Follow Part 1 of https://www.pulumi.com/registry/packages/aws/how-to-guides/aws-go-assume-role/
In part 2, instead of exporting the account credentials to environment variables as shown in the first step, configure the account credentials as an AWS profile as described at https://www.pulumi.com/registry/packages/aws/installation-configuration/#set-up-multiple-profiles, e.g:

[assume-role-test]
aws_access_key_id = <ACCESS_KEY_ID_FROM_CREATE_STACK_OUTPUT>
aws_secret_access_key = <SECRET_ACCESS_KEY_FROM_CREATE_STACK_OUTPUT>

Continue with the remainder of the how-to as documented (e.g. pulumi stack init; pulumi config set ...)
Configure Pulumi to authenticate via the profile:  pulumi config set aws:profile assume-role-test
Bring up the stack with pulumi up

Expected Behaviour
The privileged role should be assumed, and the S3 bucket should be created, as happens when following the how-to directly and exporting the ACCESS_KEY and SECRET_ACCESS_KEY into the environment.
Actual Behaviour
Pulumi fails to assume the role successfully, returning an error about invalid AWS permisions:
matt@argon:~/pexamples/aws-go-assume-role/assume-role$ pulumi up
Previewing update (assume-role-assume)

View in Browser (Ctrl+O): [REDACTED]

     Type                     Name                                   Plan       Info
 +   pulumi:pulumi:Stack      aws-go-assume-role-assume-role-assume  create
 +   ├─ pulumi:providers:aws  privileged                             create
     └─ aws:s3:Bucket         my-bucket                                         1 error

Diagnostics:
  aws:s3:Bucket (my-bucket):
    error: unable to discover AWS AccessKeyID and/or SecretAccessKey - see https://pulumi.io/install/aws.html for details on configuration

However, the AWS CLI can also be used to demonstrate that the configured profile is working:
matt@argon:~/pexamples/aws-go-assume-role/assume-role$ aws --profile assume-role-test sts get-caller-identity
{
    "UserId": "AIDAZXXXXPR6",
    "Account": "6785XXX7549",
    "Arn"<EMAIL_ADDRESS>}

@mattbnz Thanks for reporting this issue and apologies for the delayed response on this!
Unfortunately I was not able to reproduce this issue. I could use pulumi config set aws:profile my-role without any ENV vars for authentication. Could you see if manually specifying the location of your credentials file helps? This can be done with: pulumi config set aws:sharedCredentialsFile <PATH_TO_AWS_CREDENTIALS_FILE
To help us dig deeper, could you also provide the output of pulumi about from the project's directory? This way, we can see which versions of our CLI and providers you are using.
Thanks!

Hi Ramon,
There's no issue using pulumi config set aws:profile my-role in general - I can definitely use that fine for "normal" activities (e.g. anything that doesn't require assuming a different role via a provider), it's only when I try and assume another role via a provider, that things start to fail.
My credentials file is in the standard location ~/.aws/credentials, so manually setting aws:sharedCredentialsFile made no difference as expected, I received the same error:
matt@argon:~/pexamples/aws-go-assume-role/assume-role$ tail -n 3 /home/matt/.aws/credentials
[pulumi-test]
aws_access_key_id = [redacted]
aws_secret_access_key = [redacted]
matt@argon:~/pexamples/aws-go-assume-role/assume-role$ pulumi config set aws:profile pulumi-test
matt@argon:~/pexamples/aws-go-assume-role/assume-role$ pulumi config set aws:sharedCredentialsFile "/home/matt/.aws/credentials"
matt@argon:~/pexamples/aws-go-assume-role/assume-role$ pulumi up
Previewing update (assume-role-assume)

View in Browser (Ctrl+O): https://app.pulumi.com/mattbnz/aws-go-assume-role/assume-role-assume/previews/9ed04ab1-4937-4846-a7b4-3cdb03e5583b

     Type                     Name                                   Plan       Info
 +   pulumi:pulumi:Stack      aws-go-assume-role-assume-role-assume  create
 +   ├─ pulumi:providers:aws  privileged                             create
     └─ aws:s3:Bucket         my-bucket                                         1 error

Diagnostics:
  aws:s3:Bucket (my-bucket):
    error: unable to discover AWS AccessKeyID and/or SecretAccessKey - see https://pulumi.io/install/aws.html for details on configuration

My output from pulumi about is:
matt@argon:~/pexamples/aws-go-assume-role/assume-role$ pulumi about
CLI
Version      3.65.1
Go Version   go1.20.3
Go Compiler  gc

Plugins
NAME  VERSION
aws   5.0.0
go    unknown

Host
OS       ubuntu
Version  22.10
Arch     x86_64

This project is written in go: executable='/usr/bin/go' version='go version go1.19.2 linux/amd64'

Current Stack: mattbnz/aws-go-assume-role/assume-role-assume

Found no resources associated with assume-role-assume

Found no pending operations associated with assume-role-assume

Backend
Name           pulumi.com
URL            https://app.pulumi.com/mattbnz
User           mattbnz
Organizations  mattbnz

Dependencies:
NAME                                 VERSION
github.com/pulumi/pulumi-aws/sdk/v5  5.0.0
github.com/pulumi/pulumi/sdk/v3      3.25.0

Pulumi locates its logs in /tmp by default

Anything further I can do to help move this along?

I've reproduced this exactly as Matt said. I've also managed to get it working by skipping this bit:
 pulumi config set aws:profile assume-role-test

And instead using
export AWS_PROFILE=assume-role-test

It looks like the call to NewProvider is skipping the check for aws:profile?

Confirmed that using AWS_PROFILE rather than pulumi config set works around the issue for me.

This design implies that the "I want to use pulumi config solution would be to have a self-implemented project- or stack-level config option for this, rather than a provider-level config option. This makes sense, since if you have more than one provider being created and all use different profiles, how would Pulumi know which provider objects use aws:profile and which don't?

I believe that this is by design

Is there a link to that design and the underlying rationale somewhere I could learn from?
The concept that an "explicit provider" must be defined from scratch and doesn't benefit from the project config seems opposite to the inuitive default behaviour to me - and opposite to what the examples (e.g. https://github.com/pulumi/examples/blob/master/aws-go-assume-role/assume-role/main.go#L18) seem to expect as well - given there is no explicit credentials being passed to the provider, the example code is clearly expecting them to come in implicitly and both the environment and project config are documented as the correct way to do this at https://www.pulumi.com/registry/packages/aws/installation-configuration/#set-up-multiple-profiles
So the current design seems a bit broken to my current level of understanding - at the very least if this is intended behaviour as currently working, then the "Set up multiple profiles" documentation should carry a big warning on the second method letting users know that if you actually follow those docs and set the profile in your Pulumi.yaml, you will end up in trouble if you try and use explicit providers (which are basicaly unavoidable).

I'm not aware of an explicit design doc for this decision. Explicit providers don't benefit from project config, but they do benefit from environmental variables. That is why https://github.com/pulumi/examples/blob/master/aws-go-assume-role/assume-role/main.go#L18 works. set-up-multiple-profiles discusses how to set up multiple aws profiles in ~/.aws/credentials, and then access a single profile per pulumi stack.
One workaround is to consume the config values you set in your code.

import (
	"github.com/pulumi/pulumi/sdk/v3/go/pulumi"
	"github.com/pulumi/pulumi/sdk/v3/go/pulumi/config"
)

func defaultProvider(ctx *pulumi.Context) *aws.ProviderArgs {
    config := config.Net(ctx, "aws")
    return &aws.ProviderArgs {
        Region: config.Get("region"),
        ...
    }
}


[devops:bot] update deps in nix/sources.json (from: rhino-core@b7c78d5

update nix refernces for rhino-core and|or nixpkgs to match https://github.com/rhinofi/rhino-core/blob/b7c78d58697a7e8048ecc13b16fdf5a8e91edafe/nix/sources.json (branch: dev)

superseded by #59


Declutter navbar

Fixes issue #832

The navbar seems to be completely gone? https://lingonsaft-hacktober-panxfqlpuf.now.sh/
A little to clean don't you think? :P

Whoops! Looks like I messed up while resolving merge conflicts. Sorry!

This is great thanks :)


[apis/Google.Cloud.Asset.V1] fix!: remove AnalyzeIamPolicy and ExportIamPolicyAnalysis RPCs

This PR was generated using Autosynth. :rainbow:
Synth log will be available here:
https://source.cloud.google.com/results/invocations/d43ceec6-5326-451e-a256-398d97b52452/targets

[ ] To automatically regenerate this PR, check this box.

PiperOrigin-RevId: 330786980
Source-Link: https://github.com/googleapis/googleapis/commit/ef03f63f2f2d3b2dd936e46595c0f746cb10c43c

We're deciding internally what to do with this, in terms of handling the breaking change.


Test Certificate

curl -k -X PATCH -H "Content-Type: application/json" -H "X-Auth-Token: $token" -d '{"DateTime": "2024-06-05 14:07:08.695"}' https://xxx.xxx.xxx.xxx/redfish/v1/Managers/bmc
<EMAIL_ADDRESS>[
    {
<EMAIL_ADDRESS>"#Message.v1_1_1.Message",
      "Message": "The value '\"2024-06-05 14:07:08.695\"' for the property DateTime is of a different format than the property can accept.",
      "MessageArgs": [
        "\"2024-06-05 14:07:08.695\"",
        "DateTime"
      ],
      "MessageId": "Base.1.16.0.PropertyValueFormatError",
      "MessageSeverity": "Warning",
      "Resolution": "Correct the value for the property in the request body and resubmit the request if the operation failed."
    }
  ]

Should it be modified to
curl -k -X PATCH -H "Content-Type: application/json" -H "X-Auth-Token: $token" -d '{"DateTime": "2024-06-05T14:01:59.809Z"}' https://xxx.xxx.xxx.xxx/redfish/v1/Managers/bmc
  "DateTime": "2024-06-05T14:01:59.809Z"

It seems that this command can be successfully tested manually, but auto-test still returns 400
curl -k -X PATCH -H "Content-Type: application/json" -H "X-Auth-Token: $token" -d '{"DateTime": "2024-06-05 14:07:08.695"}' https://xxx.xxx.xxx.xxx/redfish/v1/Managers/bmc


Encoder usage question

I now understand how the decoder works, but how can I encode [0] CONTEXT-SPECIFIC (0X80), [2] CONTEXT-SPECIFIC (0XA2), [2] CONTEXT-SPECIFIC (0XA2) things from the results of the following gist?
https://gist.github.com/korusdipl/7b145d2c67a4a03c8873
Not having the profound knowledge on ASN.1, I am having quite difficulties in encoding those stuffs back. A live snippet would be a great help.
The first result was from the binary of the OCSP output in https://gist.github.com/korusdipl/f0c3075cd61cc8d0616c
Thanks.

I noticed already in #43 that the data you are providing in the gists does not seem to correspond with the OCSP response definition of RFC6960 so I am not quite sure we talk about the same thing.
In general you can parse any object as I have already shown you then you can modify it and when you think you are done you can encode it again by calling the public getBinary function on it.
P.S. for the future: can you put the relevant data like the used input directly in the guthub issue instead of linking to a gist?

Thanks for the comment, I will study more on this.
Furthermore, I thought if I paste everything here it would be somehow messy,
but from now on, I will copy the related stuffs directly here.


stm32-metapac-gen: Use serde_json to parse json files

This makes stm32-metapac-gen over twice as fast. A full run on my desktop goes from about six and a half seconds to about three seconds. Suprisingly, it also reduces the fresh compile time by almost a second.

How much does cold build time increase due to having to build both serde_yaml and serde_json?

Build time methodology:
cargo clean && cargo build --release in the stm32-metapac-gen directory, using the compile time reported by cargo.
Run time methodology:
time ./target/release/stm32-metapac-gen in the stm32-metapac-gen directory, using the "real" time reported by time.
I measure the build time a few more times, and it is actually more than a second faster on average:

Before:

16.02
16.15
15.87
15.86
16.27

After:

14.64
14.67
14.85
14.78
14.85

I meant, for example, what about cargo clean && cargo build --release --bin usart in examples/stm32f4?

Basically no change:

Before

16.63
16.66
16.70

After

16.75
16.60
16.44


Question: Should ZABAPGIT_TEST_SSL be in package $ABAPGIT

I installed ZABAPGIT and ZABAPGIT_TEST_SSL into package $ABAPGIT  by saving the contents of https://raw.githubusercontent.com/abapGit/build/master/zabapgit.abap and http://docs.abapgit.org/other-test-ssl.html and uploading the code via SE38
I then used ZABAPGIT to make the package online, and I ended up with the following:

Should ZABAPGIT_TEST_SSL be in the master package, or should I change the package it is using on my system ?
thanks,

it should not
its a test program, just put it in $TMP

thanks for the quick response

I've updated the documentation, https://github.com/larshp/abapGit/commit/11ab0190c15868376add639f8e99dc63197b9cdd


[Question] How to Run-Al-Pipeline with a complex App Dependency Structure?

PLEASE DO NOT INCLUDE ANY PASSWORDS OR TOKENS IN YOUR ISSUE!!!
Describe the issue
We have a project with the following dependency structure:

AppDependency A: Various pre-compiled Apps
CompiledApp A: A few Apps that should be compiled with the pipeline

Dependency: AppDependency A

AppDependency B: Various pre-compiled Apps

Dependency: Compiled App A + AppDependencyA

CompiledApp B: A App that should be compiled by the pipeline.

Dependency: AppDependency A, AppDependency B, Compiled Apps A

Now according to my knowledge, only the Steps AppDependency A + CompiledApp A are possible.
Is there a way how to do the next steps, if not, is it intended that all four steps will be possible in the future?
Scripts used to create container and cause the issue
None

Full output of scripts
None

Screenshots
If applicable, add screenshots to help explain your problem.
Additional context

Hi, are you on DevOps or GitHub?
There is a Command Resolve-DependenciesFromAzureFeed if you use that you can handle any dependency forest, even very nested ones.
There are only two distinctions. .app files that are stored in the feed or a multi app repo so App A and B compiled together.
I've been using that for a year or so, with almost 100 apps  and a max depth of around 10.

The example above isn't supported in one run with Run-AlPipeline (unless appdependenciesB and compiledappsB is test apps (then you can use TestAppDependencies and testApps)
If you want to use Run-AlPipeline, it sounds like you would have to run it twice, with the output of the first run as dependencies for the second run,

Ahh yes I miss understood the question. But this should work in one compilation if you put A and B in the same Repo.
Run-Pipeline should execute boths builds sequentially and you could provide the pre compiled apps ether using Resolve-DependenciesFromAzureFeed or just as a ZIP in the installApps property.

@jonaswre - you are 100% right in what you say, but as I understand the problem - F-H has a dependency on A as well.
Currently the logic in Run-AlPipeline will install all apps in InstallApps before all compiled apps.
I guess this logic could be changed to support the scenario at hand, but currently I don't believe you can.

Ahhhh okay...
True thats not possible and I'm not sure how useful this case really is because A will need to be compiled alone so that F-H can be compiled.  This would sort of create a circular dependency not between the apps but between the pipelines.
I think I would just split A and B into diffrent Repos. The "Fix Ready" Tag ist deserved here.

Yeah, today A would have to be build first and then all output from that used in B.
I guess it would be possible to compile all apps (because the installapps are just places in a symbols folder)
But today, I install installapps in dependency order and then I install compiled apps in dependency order - these two would have to be merged for this scenario to work.

I still think this would still create a circular dependency between the pipelines
AB needs F
F needs A
A will only be compiled with B which needs F
So even if technically possible I dont think this is really useful in the real world.
But maybe @matthias-planzer can elaborate a bit why this would be useful.

circular references cannot be done in AL.
A needs C,D,E
F,G,H needs A
B needs A,F,G,H
I think
at this time, 2 pipelines

I meant it its a circular reference between the pipelines not the apps.
Pipeline 1 has to build A and B (AB)
Pipeline 2 has to build F (F)
If we start empty, Pipeline 2 cant run because its missing A and Pipeline 1 cant run because B is missing F. The Pipelines depend  on each other but not the apps. This will need to be jump stared somewhere.
Solution 1: Pipeline 1 compiles B, Pipeline 2 compiles A and F (rearanged)
Solution 2: Pipeline 1 compiles B, Pipeline 2 compiles A, Pipeline 3 compiles (seperated)

I would have
Pipeline 1: build A (and use C,D,E from other source)
Pipeline 2; build B and use F,G,H (and A,C,D,E)

The splitted approach is always what I recommend. Only add apps in multi repo if they are very very tightly coupled. (Change in almost certainly mean changes in the other.)
But maybe the author has a good reason to request this. I'm curious.
Until the have a great vacation!


500 Internal Server Error: ActiveRecord Connection Timeout (block in wait pool) since adding

I've recently added spree_static_content gem for use with spree. However I'm noticing 500 errors happening every few hours which are requiring a server restart. AWS shows me my number of database connections went from a constant and static 2 over the last few weeks, to jumping to my pool max of 5 immediently after adding and commiting spree_static_content.
I'm guessing there's open conenctions that aren't being closed.
Front-end is failing with.
500 Internal Server Error
If you are the administrator of this website, then please read this web application's log file and/or the web server's log file to find out what went wrong.

With the following partial stack in the logs.
FATAL – :
ActiveRecord::ConnectionTimeoutError (could not obtain a database connection within 5.000 seconds (waited 5.000 seconds)):
activerecord (4.1.4) lib/active_record/connection_adapters/abstract/connection_pool.rb:190:in `block in wait_poll'
activerecord (4.1.4) lib/active_record/connection_adapters/abstract/connection_pool.rb:181:in `loop'
activerecord (4.1.4) lib/active_record/connection_adapters/abstract/connection_pool.rb:181:in `wait_poll'
activerecord (4.1.4) lib/active_record/connection_adapters/abstract/connection_pool.rb:136:in `block in poll'

I'm not sure if it's related but it also looks suspicious that I get the following message when I start my server.
Instance method "open" is already defined in Object, use generic helper instead or set StateMachine::Machine.ignore_method_conflicts = true.

I've been using the Spree 2.4.0 Beta, with no problems for the last few weeks running ruby '2.1.2' and rails '4.1.4'.
The only change in my commit prior to the problems was adding in spree_static_content, some CSS for the header and footer navigation, and adding a reference in my footer template.
ul.nav
	= render :partial => "spree/static_content/static_content_list", :collection => Spree::Page.visible.footer_links, :as => :page

Can someone please help resolve this problem.

What did you add Passenger and Nginx to? I'm having this same issue with a non-spree project and i'm stumped.


Introducing: 2D Shape Editor

2D Shape Editor
Important: May have gaps while "Optimize Geometry" is enabled!
Draw any 2D shape and turn it into a 3D brush with a single click!

Come up with your own awesome designs using bezier curves for the fancy bits.

Design unique CSG levels like never before.

The 2D Shape Editor comes equipped with popup windows and keyboard shortcuts for an efficient workflow.

Inspired by the original 2D Shape Editor from Unreal Editor 1&2 (1998).
@sabresaurus
Additional pull request coming in the future to add in all the fancy features that go beyond simple extruding and planes. I would like to see this merged first to get some feedback. See if I missed anything. This also comes with some UI updates in the toolbar where I reordered some of the CSG primitives in a way that makes more sense. Also added the missing icosphere with a simple icon.

There's a meta file for an empty folder that should be removed:
Scripts/Brushes/CompoundBrushes/ShapeEditor/Triangulator/NewFolder1.meta

I was 2 seconds too late! It has been removed and pushed.
With kind regards.
Henry de Jongh
Software Developer
http://00laboratories.com/
http://00laboratories.com

Von: Sabresaurus<EMAIL_ADDRESS>Gesendet: Samstag, 17. Februar 2018 22:48
An: sabresaurus/SabreCSG
Cc: Henry de Jongh; Author
Betreff: Re: [sabresaurus/SabreCSG] Introducing: 2D Shape Editor (#37)
There's a meta file for an empty folder that should be removed:
Scripts/Brushes/CompoundBrushes/ShapeEditor/Triangulator/NewFolder1.meta
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHubhttps://github.com/sabresaurus/SabreCSG/pull/37#issuecomment-366473965, or mute the threadhttps://github.com/notifications/unsubscribe-auth/AHihvopBhNoKlJciSB0lOVhyB8xKMoPUks5tV0kygaJpZM4SF5JQ.


CAMEL-11231 add the JsonAPI Data Format

Updated from earlier PR
https://github.com/apache/camel/pull/2844
Moved JsonApiDataFormat to Camel component
Will add additional Data Format integration w/ a little guidance :)

Let me know if going to merge this, or if I should keep adding the other stuff here

Can you take as example other dataformat to align also the camel-core for this? For adding the component to the kit I'll take care of it

That would essentially be adding the DataFormat definition to the model
I'll "copy" the changes made for the Thrift format

I know there is a bit more to do on the org.apache.camel.model.dataformat.JsonApiDataFormat but wanted to get the rest out there and see if I was missing anything else

There were generated files, wasn't sure if I should add those?
Anything else that needs to be done?

There were generated files, wasn't sure if I should add those?
Anything else that needs to be done?

is it the component starter stuff? It must be added.

Let me try to merge this week.

Merged on master. Thanks

We need a karaf feature and integration tests.

Can you please add more docs on src/main/docs/jsonApi-dataformat.adoc? @CodeSmell

I'll take a look at this

I added the karaf feature and integration tests meanwhile
thanks for the contribution @CodeSmell !

Thanks for the help. Not sure I fully understand how the data format plugs into camel though
Do you want me to look at the docs? Anything else?

yes, in the docs you may add more examples :-) Thanks!


CDH | Add gRPC implementation

Close #430
Also, this PR comments out a unit test for grpc+encryption feature in image-rs's async. This code is hard to align with for code changes upon time. Could you share some ideas upon this? @arronwy
cc @ChengyuZhu6

Ready to be reviewed now.

@fitzthum Thanks for the suggestions. Fixed.


Send message contents in DMs for messages deleted by auto mod

When an automatic deletion happens for example with a token or an attachment, the user's message is currently lost.
Assuming the DMs are open, in cases like the 2 above where the deletion was not for something like spam, sending the deleted contents would make it a bit more friendly towards the user

I'm not sure if users would find DMs annoying. I'm OK with this idea. Perhaps the informational message ("you're message has been deleted cause xyz") could also be moved to DMs to reduce clutter (assuming they have DMs enabled).

I quite like the idea. Like Mark said as well, having it only sends DMs of possible would be a nice addition. The only real issue I can see with that is the user not realising that the message was deleted and sending it again. Maybe we could reduce the server message to something simple that mentions the main cause of the deletion and asks the user to check their DMs for more info. If they don’t have DMs enabled, it would simply be like today.

Which filters would we want to include here? Looking through it the token and webhooks removers, and antimalware are the ones that will benefit the most, but the everyone ping filter and invite filters also feel like they could be triggered accidentally without knowledge of the removals from the bot.
The current process I was thinking of is to delete the user message then check if the user has open DMs:

If they are open, send the current in channel notification and their original message through the DMs

If they aren't open, send the current notif message in the channel with something like To retrieve your deleted message open DMs and run the !foo command added to the end. Then keep the message around through redis, until the user requests it or some cleanup of stale messages is done.

With the current filtering layout it doesn't look like there'd be a very nice way of doing this so I'll look into a rewrite if it's viable and the feature would benefit from it

Let's consider adding a word or character count threshold. Really short messages aren't worth relaying. This may alleviate concerns of DMs being annoying.

webhooks removers, and antimalware are the ones that will benefit the most

I agree, though in the case of antimalware, attachments without any message written should be ignored.

everyone ping filter and invite filters

Maybe for the ping but I don't think it's necessary for invites.

Then keep the message around through redis, until the user requests it or some cleanup of stale messages is done.

I don't agree with this. It should be simpler: if they have DMs enabled, send them their message. If not, too bad. Writing a command and caching messages seems overcomplicated for the amount of use I foresee the feature receiving.

I'll look into a rewrite if it's viable

Some of the filtering code is quite old and would benefit from a rewrite regardless of this feature, so you're welcome to tackle that if you wish.

Then keep the message around through redis, until the user requests it or some cleanup of stale messages is done.

I don't agree with this. It should be simpler: if they have DMs enabled, send them their message. If not, too bad. Writing a command and caching messages seems overcomplicated for the amount of use I foresee the feature receiving.

The implementation for that shouldn't have much complexity, just setting/getting and some background to delete the stale data, and could possibly save some headache for some users; would like to hear some other opinions on this.
Although I'm not sure if there are any considerations wrt the privacy policy, maybe @jb3 could shine some light on that.
I'll slowly start working on this.

Then keep the message around through redis, until the user requests it or some cleanup of stale messages is done.

I don't agree with this. It should be simpler: if they have DMs enabled, send them their message. If not, too bad. Writing a command and caching messages seems overcomplicated for the amount of use I foresee the feature receiving.

The implementation for that shouldn't have much complexity, just setting/getting and some background to delete the stale data, and could possibly save some headache for some users; would like to hear some other opinions on this.
Although I'm not sure if there are any considerations wrt the privacy policy, maybe @jb3 could shine some light on that.
I'll slowly start working on this.

Superseded by #1530


Missing .md files

Hi @yoshall
Thank you for your work.
I have noticed that a few .md files in the repo have broken links (at the time of writing of this issue)  e.g. install.md, data_preparation.md and  supported_datasets.md
Could you please fix these links?

Hi Asif, you can find the md files at
https://github.com/open-mmlab/mmaction2/blob/master/docs/data_preparation.md
https://github.com/open-mmlab/mmaction2/tree/master/docs/supported_datasets.md


Fix antigen installation instructions

Description
Antigen, by default, tries to fetch master, consequently, it fails with this bundle since the default branch is main.

Thanks for contributing!


Drizzle MySQL Asset Store

There is a start of an implementation on the mysql branch.

Details?

Details?

To implement an asset store for MySQL using Drizzle one can use https://github.com/TimMikeladze/next-upload/tree/master/src/store/drizzle/pg as a starting point for implementation.
The logic will remain quite similar, with the major differences being in the column types for MySQL as opposed to Pg.
Note: this MySQL implementation should work out of the box with planetscale according to the drizzle docs .


Consider addressing lingering Spearbit Issues

We weren't able to address all of the Spearbit issues during the two week fix period. We should consider addressing some of them before the next review as I don't think they are bad suggestions. @jrhea Should chat about this to align on which ones make sense and which don't.

[ ] #85
[ ] #73: We could consider rounding the time remaining differently.
[ ] #20: Consolidate on a style for returning variables.

Closing this since we're not going to address this.


Make Material component messages lossy

When standing over ORG:-3,-33 a lot of CPU time is lost processing continuous Material messages. As Material messages are used for visual purposes, and the use case of animating a Material is kind of common, we can make them lossy to save cycles.

Needs reevaluation and how many use cases its solving. Check benchmark.


png/svg download to include legend?

I don't know if this is a Plot question or an observablehq.com question, but I thought I'd start here.
On any of the charts with legends here: https://observablehq.com/@observablehq/plot-legends, if I click "Download PNG" or "Download SVG", I get an image of the chart that does not include the legend. I imagine this follows from the legend being an add-on to the chart.
Could there be a convenient way to get them both in an image download?
Thanks!

It's mostly an observablehq question, but it's also a Plot question, since Plot returns an HTML figure. Either way we'll need to find a good solution!
For PNG downloads, I've started experimenting with the image-to-html library here: https://observablehq.com/@fil/hello-html-to-image
One could also try with html2canvas https://observablehq.com/@fil/hello-html2canvas
For SVG, I haven't found how to generically convert HTML to SVG, but I have a heap of code that 99% works charts. https://observablehq.com/@fil/plot-figure-to-svg

Please file this in the Observable feedback repository:
https://github.com/observablehq/feedback
I would transfer it but for some reason GitHub isn’t letting me.


Support for Motherboard RGB Ecosystems

I was looking through the project's homepage, and I found it great that I could finally unify lighting for different peripheral brands. However, I saw that RGB Ecosystems, like Asus' Aura Sync, MSI Mystic Light, Gigabyte RGB Fusion, among a few others weren't listed. I'd like it if support was added for these RGB Ecosystems, as they already have a wide range of internal components supported, like RAM Sticks and Cases, but not so much for external peripherals. I think that it would be a good idea, as it would make syncing lighting effects in and outside of a custom built PC much less of a hassle. The three that I've mentioned have SDK's available on their respective microsites if that would make implementation less of a hassle. Thanks!

I believe there is a very work-in-progress build at the moment https://drive.google.com/file/d/1BtQ9sBzrmSNEM0uCUpR4FuvNT0MzQ651/view. There has not been any progress on it recently however afaik.
I think generally support for SDKs such as Mystic Light are on hold until the device rework which will see us being able to add an arbitrary number of devices to the canvas each with their own customisable lights, instead of being limited to a keyboard and a peripheral with a limit on the number of lights each can have.

I think generally support for SDKs such as Mystic Light are on hold until the device rework which will see us being able to add an arbitrary number of devices to the canvas each with their own customisable lights, instead of being limited to a keyboard and a peripheral with a limit on the number of lights each can have.

I don't understand what you mean. Could you please elaborate?

Currently we have a set number of possible lights that can be assigned to. This includes all the standard keyboard keys, a logo light and a few extra peripheral keys.
While this worked fine originally, as more and more devices started coming out with more and more controllable LEDs, people have been using a larger number of LED peripherals. It's not impossible that someone would have a full RGB keyboard, a mouse with several LEDs, a headset, RAM, mousepad and fans. With this system of having a limited set of lights, it means that devices are having to share light entries on Aurora. So for example, many mice use the defined peripheral logo entry, but if we were to add something other device which has a logo, this would also use the peripheral logo entry and so would appear the same colour as the mouse. While we could add additional light entries specifically for each device, this would become an absolute nightmare to manage going forwards.
You may have noticed that UI only supports being able to add one keyboard and one mouse. This is also not ideal as many people now have more RGB devices than just a keyboard and mouse.
This is what the device rework aims to solve. I'm not the one working on this, but I think it works by the user being able to "add" whatever devices they have to the canvas (the display at the top of Aurora). These devices then each have their own internal light entries that can be controlled, instead of using the global light entries. You will also be able to move the devices around on the canvas, so if you have something like a moving gradient layer, it can pass over multiple devices in the order you specify.
While on the surface it may not seem like a lot needs to change for this, the current system is deeply ingrained with how the layers are programmed and so by changing the way it works we have to re-write a huge amount of the codebase. This is made slower by the fact that the developer of the rewrite is currently at University and is so only able to work on it in his freetime around his studies.


vault-github: user is not part of required org

Module: vault-github
Coder Version: 2.4.0
Vault Version: 1.15.3
Issue: Error with ghu_ prefixed GitHub App token during workspace startup; ghp_ personal access tokens work fine.
Error Message on Workspace Startup:
Error authenticating: Error making API request.
URL: PUT http://<IP_ADDRESS>:8200/v1/auth/github/login
Code: 500. Errors:
* user is not part of required org

Configuration:

Installed and configured the vault-github module in a Coder template.
Engaged GitHub authentication and established GitHub organization in Vault settings.

Discovery:

Authentication with GitHub App tokens (ghu_ prefix) fails upon workspace initialization.
Authentication using personal access tokens (ghp_ prefix) performs correctly.

Steps to Reproduce:

Set up the vault-github module in Coder template.module "vault" {
  source     = "https://registry.coder.com/modules/vault-github"
  agent_id   = coder_agent.dev.id
  vault_addr = "http://<IP_ADDRESS>:8200"
  coder_github_auth_id   = "primary-github"
}

Activated GitHub authentication and set the GitHub organization in Vault.vault auth enable github
vault write auth/github/config organization=photonq-org

Encountered an error when starting the workspace using a GitHub App token.vault login -method=github token=ghu_MyGitHubAppAccessToken

Successfully logged in with a personal access token.vault login -method=github token=ghp_MyPersonalAccessToken

Question:
Is additional configuration required within HashiCorp Vault to enable authentication using GitHub App tokens (ghu_ prefix) as they produce an error stating the user is not part of the required organization?

cc @matifali

Closing in favour of #175


Add helper function inertia()

When using the Laravel framework I personally find it cleaner to use the view(), so I'd also really like to be able to use the same approach with Intertia.
This pull request simply adds a helper function inertia().
For example:
return Intertia::render('Welcome', ['name' => 'George']);

becomes
return inertia('Welcome', ['name' => 'George']);

I have made a further change so that if you don't pass any parameters to the inertia() function, it returns an instance of the ResponseFactory, similar to how view() works in Laravel.
This allows you to do things such as:
intertia()->share();

@reinink any chance of reviewing this? Thanks :)

@georgehanson Sorry, I've been super busy and behind on my open source stuff. Curious, why did you close this?

@reinink no problem :)
I closed it be because of two main reasons. Firstly I want to just do it in one commit and secondly because when using it locally I noticed a couple of issues with my implementation. So I want to just iron out a few things. I'll probably be creating a new PR tomorrow

PR resubmitted as #36.


Save draft of new transaction

Description:
Develop the functionality to save a draft of a new transaction:
Save Draft button

Requires the three transaction inputs (transaction type, select organization, compliance units) to not be blank / be filled out / selected
If effective date is not entered, effective date defaults to the date of director approval.
Clicking the 'Save' button creates the transaction and sets the status to 'Draft'.
Creating the transaction assigns an ID number to the transaction (i.e., a transaction ID number, similar to TFRS functionality where every transaction is given a unique ID number, sequential order).
Replaces 'New transaction' title on page to chosen transaction type and assigned ID number.
A success alert appears (Material UI examples)
A transaction history record is saved to the database and visible in the UI when viewing the transaction: Saved on [Month DD, YYYY] by [User] of [Organization]. This record is based on the IDIR user with the government analyst role that clicked the 'Save' button.
The transaction history record is only visible to IDIR users
The user remains on the transaction page with fields still editable.
Grey text box with explanation of effective date persists.

(Justin, am I missing any validation messages here?)
Wireframe:
https://preview.uxpin.com/59145260c7d8cc48969ac79401cc03d84843c3d9#/pages/165300444/simulate/sitemap
Purpose and benefit to user:
Allows the IDIR government analyst user to save a draft of the transfer to be processed later and/or by a different user
Acceptance Criteria:

[ ] Given I am a , When I am , then
[ ] Given I am a , When I am , then

Development Checklist:

[ ] A
[ ] B
[ ] C

Notes:

@Grulin Looks good. A few additions/tweaks I made:

as you correctly pointed out, we needed some information about data validation messaging. Here we are trying to capture what happens when you don't fill out a required field or input an incorrect value (e.g., negative compliance unit value for initiative agreement transaction type). We need to give the developers the specific language to use; plain language is best and we should be consistent in how we communicate these types of errors / issues. As always, Al and Kailee can help us with this type of messaging if needed.

I expanded the bullet below to clarify that the assigning of an effective date when the field is left blank will be handled in a different card. Due to the business logic here, we won't know this date until the director clicks on the approve button; thus, it makes sense to incorporate that functionality within the director approval card.

If effective date is not entered, effective date defaults to the date of director approval (this functionality will be handled in the director approval card)

I changed the bullet below to say that the created transaction is only visible to IDIR users. This includes the transaction history record, but we want hide the entire transaction from external organizations until it has been approved; at that time, it will become visible to the organization involved in the transaction.

The transaction history record is only visible to IDIR users

Careful with copy/pasting from previous cards. You referenced transfers in the Purpose and benefit to user: section when it should reference transaction: Allows the IDIR government analyst user to save a draft of the transaction to be processed later and/or by a different user

Note to run this past the devs
Do we want to prefix the transaction types for filtering id#? Because transfer, admin adjustments and IA transactions are in separate tables, there is the potential for them to have the same numerical id#. We could differentiate between the transaction types in the id by prefixing them with AA#,IA# and CUT#.

recived this error trying to save a negative value as admin adjustment

This issue will be fixed once ticket #382 is merged.


chore(release): v0.11.11 🎉

:robot: I have created a release beep boop
0.11.11 (2023-09-24)
Bug Fixes

deps: bump simple-jwt-auth to eliminate buffer missing error (3541ef6)

This PR was generated with Release Please. See documentation.

:robot: Release is at https://github.com/whodisio/whodis-client/releases/tag/v0.11.11 :sunflower:


Console throws a warning when using styled-components

A warning will appear in the console when I use the process

next.js  v12.2.3
styled-components v5.3.5
@module-federation/nextjs-mf v6.1.2

next.config.js
....
webpack: (config, { isServer }) => {
  config.plugins.push(
    new NextFederationPlugin({
            name: 'app',
            remotes: {
              common: `common@http://localhost:3000/_next/static/${isServer ? 'ssr' : 'chunks'}/remoteEntry.js`
            },
            filename: 'static/chunks/remoteEntry.js',
            shared: {
              'styled-components/': {
                singleton: true,
                requiredVersion: deps['styled-components']
              }
            }
          })
   )
}
....

However the browser console warns
It looks like there are several instances of 'styled-components' initialized in this application. This may cause dynamic styles to not render properly, errors during the rehydration process, a missing theme prop, and makes your application bigger without good reason.

create a reproducible repo

创建一个可重现的回购协议

example: https://github.com/w1687021088/w1687021088-nextjs-styled-components-mf-example

did you try to share styled-components in your /common/next.config.js?

您是否尝试在/common/next.config.js中共享styled-components？

did you try to share styled-components in your /common/next.config.js?
Thank you for your reply, I tried to share the "styled-components" of the common module, but this warning still exists

They the @ next tag on npm. It's the v7 prerelease


Propose to provide live playground in killercoda

What would you like to be added?
on https://killercoda.com/
Why is this needed?
live demo

This is a very useful proposal, Thanks!

@calvin0327 has built the clusterpedia playground
https://killercoda.com/clusterpedia
repo: https://github.com/clusterpedia-io/killercoda


fix: change MultiHandler back to Handlers

This PR reverts #1360 . The deprecation of the Handlers type caused a bit of churn in our docs. After a bit of back and forth internally we felt that keeping it Handlers and throwing an error instead, when a handlers export detected is a better approach.
An additional benefit is that the object notation is more widely used and it makes sense to make that as ergonomic as possible.
Fixes #1350

What about using a handlers variable name instead of handler? That makes the most sense to me.

@iuioiua that in itself would be a breaking change if we just changed that.

True. How much would it complicate things if we supported both during a deprecation period, if we were to do so? To elaborate, I'd assume that having a handlers variable name match its type name Handlers would be most apparent to a newcomer.


fix(ONYX-969): add lotsForYouRail, topAuctionLotsRail to AuthContextModule

The type of this PR is: Fix

This PR resolves ONYX-969
Description
Add lotsForYouRail and topAuctionLotsRail to AuthContextModule.

PR Checklist (tick all before merging)

[ ] If I've added a new file to the tree I've exported it from the common index.ts
[ ] I've added comments with examples for any new interfaces and ensured that they're in the docs
[ ] No platform-specific terminology has been used outside of click and tap (platform is inferred by the DB storing events)

:rocket: PR was released in v4.184.0 :rocket:


Add support for Node.js version 0.10

Hi there,
A project I maintain relies on this package transitively through the phantomjs-prebuilt package. Recently, we started seeing failures on our Windows build for Node.js 0.10 because of this project's relatively new reliance on path.isAbsolute (a built-in method that introduced in Node 0.11).
Node 0.10 is very old, but this seems like a very minor detail for me to drop support. I can see from this project's history that it never explicitly supported that version of Node, but I figured that because the fix is so trivial, it would be worth at least asking if you folks wouldn't mind taking on the maintenance burden.
Thanks for your consideration!

@maxogden @malept Any thoughts on this?

Personally, I do not want to commit to supporting EOL'd Node versions. If it were up to me, I would actually go the other way and drop support for 0.12 and iojs, because the test matrix is way too big for the number of maintainers (given the number of projects that depend on this).


Register instruction in fetch stage before using in decoder

This PR proposes to register the fetched instruction in fetch stage before using it in decoder.
This allows us to use bigger memories without timing violations, as the net delay between the memory and the decoder is considerable.
The initial implementation drops support for compressed instructions.
Preliminary results:

Baseline
Registered

Setup
-0.079
0.015

LUTs
3118
3133

FFs
1353
1453

CoreMark
202
184

A small toll to pay for a little bit more headroom in timing.
Maybe with this change we can re-add the branch prediction and gain performance?

This PR now includes the new compressed aligner at fetch stage
Without BP the Coremark score built with C is 179.
If compressed is enabled in RS5 but not the application is compiled without it, the same coremark score (184.2) is achieved.
Therefore, the only penalty for using C is due to jumps unaligned to 4-byte boundaries.
@cominixo Will post LUT/FF/Timing results with and without C (BP=off) tomorrow and compare them to master branch.

I have also merged a change from @cominixo  that registers the multiplier hold signal, improving timing.

Baseline (rv32imc)
Reg. (rv32imc) w/o BP
Reg. (rv32im) w/o BP

Setup
0.162
0.002
0.121

LUTs
3658
3829
3631

FFs
1877
1571
1670

CoreMark
178.8
178.9
184.1

This PR is ready for review.
Registering the incoming instruction at fetch stage allowed to include branch prediction (#5 #7) and remove the align stage (#21).
The BP is implemented in decode and changes the next instruction address. In case of a mispredict, it is corrected at the next cycle and current instructions are not discarded (+1 cycle penalty only, or "rollback").
Without align stage, the only downside of using Compressed instructions is the performance penalty in case jumps to unaligned addresses. Therefore, it is possible to enable C support and compile applications without compressed instructions to have full performance.
@Willian-Nunes what do you think of reimplementing #4?
Also, please add your review.

@cominixo will post the updated results tomorrow

Compressed is passing Memphis-V regression.
BP is still broken.

Almost all Memphis-V tests passing. Only DTW still broken.

The PR now includes:

Instructions are killed in decoder, decreasing the number of hazards due to zeroing earlier the locked register (~4% perf. gain)
With bubbles inserted directly by the decoder, the tag is no longer needed and therefore removed

Passing all Memphis-V tests!

Baseline (rv32im)
Baseline (rv32imc)
Reg. (rv32im) w/o BP
Reg. (rv32im) w/ BP
Reg. (rv32imc) w/o BP
Reg. (rv32imc) w/ BP

CoreMark
204
178.8
187.5
198.3
179.6
189.5

Almost 6% perf. gain with BP, resulting in only 3% perf. loss registering BP without C and 6% perf. gain with C w.r.t master branch.


[Feature Request] theming like spicetify ?

Hey there,
Would theming like "spicetify" for spotify be possible ?
Have a nice day

Hi, I think it would be possible. I'm yet unsure about the correct way to implement this as interfering with Deezer UI directly is usually bad for maintainability. There are a few questions we need to consider, support for CSS is no-brainer and easy to implement. Support for injecting JS to enable greater changes to the UI? Does custom theming make sense without community behind it? Where should the themes be downloadable? I don't know Spicetify, but they do seem to use a repo with themes or a marketplace. It might be a good idea to consider all of this stuff into a separate app that just communicates with this one.


Add URI Handlers

(Will need localisations for other languages when merged)

you literally have to run one command

counterargument: no

Requires https://github.com/R2Northstar/NorthstarMods/pull/213

Seems like this broke somewhere along the way. Give me some time to fix before merging ^^

Pushing this back to 1.7.0, will rebase on 1.6.0 once it comes out.


Webpack error when running preview:android after adding this plugin to an existing Laravel / Vue.js web app

I have an existing Laravel (6.x) / Vue.js (2.x) project into which I'd like to add nativescript-vue.  I installed nativescript and ran tns doctor successfully.  I installed the [vue-cli-plugin-nativescript-vue plugin][1], then copied the files from ns-example to the root directory of my project (including the src/ folder, .env.* files, babel.config.js, and nsconfig.json).
Now, when I try running npm run preview:android and scan the QR code on my android phone, I get the following messages and Webpack error:
Preparing project...
starting nativeConfig
Bundling application for entryPath .\main.native...
 WARN  A new version of sass-loader is available. Please upgrade for best experience.
Invalid configuration object. Webpack has been initialised using a configuration object that does not match the API schema.
 - configuration.plugins[2] misses the property 'apply'.
   function
   -> The run point of the plugin, required method.

Any suggestions on what I did wrong?

I am also facing with same issue. @mreall did it fix you?

@arpit2438735 I ended up running separate projects for my Vue and NativeScript apps.  Ultimately I'm glad I did as there's enough customization required for each that trying to keep them together would have been extremely challenging or would have impacted the UX.

@mreall ok.Thanks for the info 👍


CI: cache dependencies for check-format GH action

I'm not 100% sure that this is properly setup, but it does reduced the action execution time by more than 50%.
The action does contain the following warning, so I'm not sure that npm install is actually being called or not:

npm WARN exec The following package was not found and will be installed<EMAIL_ADDRESS>
/cc @trask

@trask - does the change in this PR seem reasonable to you?

Works for me. Merging.


Use consistent terminology for the Kubernetes general CA

https://kubernetes.io/docs/setup/best-practices/certificates/ calls this the "Kubernetes general CA". Make the two documents consistent in their terminology.

/wg naming
/sig auth
/approve


Implement global settings for Python SDK

Settings instances among models and classes are not consistent which means current settings is not global.
We need to reimplement settings to make it global

The current model is effectively passing configuration data from class instance to class instance by throwing it into a single file in the file system. It'd be great to instead be able to instantiate a proper client class and remove the filesystem entirely. The downsides of the current approach are that my Resin creds (token) get dropped into the filesystem whether I want to or not, and the single user-global file means that authenticating as different users at the same time (be it in one or multiple processes) is impossible.


refactor: move is, deepEqual and shallowEqual predicates to @makeswift/controls

No semantic changes, prep for https://github.com/makeswift/makeswift/pull/814

It seems that what we probably want is a shared library of utilities.

@migueloller For sure, and I think it should actually be a published package, since we have a number of these copied and pasted into our private monorepo as well. I'm just keeping things simple for now to stay on track.


Add support for selecting process's subtree by middle clicking it

This should fix the feature request #938

I just realized that this doesn't work like one might except, right now it simply toggles subtrees that you middle click on. But it should probably deselect already selected items and select just current subtree. CTRL+middle click should add subtree to already selected processes, this way it will be consistent with left clicking, what do you think?

should probably deselect already selected items

Actions will apply to those items unless they're deselected.

👍


Search Bar to Contributors (vaibhav-xt)

Description
The search bar is working correctly.
Please provide a brief description of the changes introduced in this pull request. Explain the problem you are solving or the feature you are adding.
Pull Request Checklist
Please make sure that your PR meets the following requirements:

[X] The app is working correctly after applying the changes.
[X] The app is responsive and displays properly on different screen sizes and devices.
[X] The changes are thoroughly documented in the appropriate files or documentation sections.
[X] The coding conventions and style guidelines are followed consistently.

Checklist
Please check all applicable boxes and provide any additional information if needed.

[X] I have tested the changes locally and ensured that the app is functioning as expected.
[X] I have verified that the app is responsive and looks good on various screen sizes and devices.
[X] I have reviewed the documentation and ensured that it accurately reflects the changes made.
[X] I have followed the coding conventions and style guidelines defined in the project.
[X] I have run the automated tests and all of them pass.
[X] I have considered the performance implications of the changes made.
[X] I have considered the security implications of the changes made.
[X] I have checked for any potential regressions or side effects caused by the changes.
[X] I have performed a self-review of my code.
[X] Starred the repository.
[X] Added My Name to the Contributor's List.
[X] Followed the repository's Contributing Guidelines.
[X] I ran the app and tested it locally to verify that it works as expected.

Screenshots - If Any (Optional)

Please provide any additional information or context that may be helpful for reviewing the pull request.
Related Issues
issue #468
Please list any related issues or pull requests that are associated with this pull request.
Reviewers
Please tag the relevant team members or reviewers who should review this pull request.

@vaibhav-xt Thanks a lot for this PR. But currently what happens is that you can search a user only on a single page. For Example, If user is on 2nd page then you cannot return it from the first page. We would want this to be searched across all the pages.

Right, but the I have to give per_page= 100 so that I can fetch all users.

@vaibhav-xt I am afraid that being a good solution. I would suggest that you create another function where there is no per page attribute and it returns all the list of contributors. Then store them in state variable just like contributors so maybe call it allContributors. Now for your filtering if someone searches then apply the filter on allContributors and make it conditional call if the input field is empty it calls what we have right now with per page i.e contributors array state variable. And if it is not empty which basically means a user is calling a query, Then return it from allContributors.
Let me know your thoughts on this.

Oh, I was working on this idea and now it's fixed and working great.

@vaibhav-xt  Pretty Awesome. Thanks a lot for this feature. 💯


[Windows] Some files are not removed when the pack is removed

Steps to reproduce:

Run the installer - ballerina-runtime-windows-installer-x64-0.970.0-beta0
Run ballerina init command
Build a sample. The some hidden files will be created
Run the installer again and remove the pack

Issue
Some files will not get removed when the pack is removed

Affected Versions:
beta-0
OS, DB, other environment details and versions:
Windows 7

@dilinisg, this is the expected behaviour of windows uninstall process. Because when you are uninstalling a program, it is not supposed to delete the user created files.

Closing based on the previous comment


Failed to reload config file: Unreloadable plugin plugin: splunk_hec

What happened:
fluent-plugin-splunk-hec doesn't seem to be compatible with the fluentd v1 plugin API (as per https://docs.fluentd.org/plugin-development/api-plugin-output), so it is considered unreloadable by fluentd. This issue prevents fluentd from reloading its configuration during fluentd reload if any part of the config is using fluent-plugin-splunk-hec.
What you expected to happen:
fluent-plugin-splunk-hec should be compatible with the fluentd v1 plugin API, so that fluentd reloads can happen successfully.
How to reproduce it (as minimally and precisely as possible):

Start fluentd with any config using fluent-plugin-splunk-hec.
Issue SIGUSR2 signal to the fluentd process to reload it (https://docs.fluentd.org/deployment/signals#sigusr2).
fluentd will not be able to reload its configuration and will error like below:

2021-10-13 02:38:54 +0000 [error]: Failed to reload config file: Unreloadable plugin plugin: splunk_hec, plugin_id: object:cae4, class_name: Fluent::Plugin: SplunkHecOutput)

Anything else we need to know?:
Environment:

Kubernetes version (use kubectl version): 1.19.9
Ruby version (use ruby --version): 2.7.0
OS (e.g: cat /etc/os-release): VMware Photon OS 4.0
Splunk version: N/A
Others: fluentd version 1.14.1 and fluent-plugin-splunk-hec version 1.2.7

Thanks for reporting this issue. Will look at it and provide an update. Thanks!

Thanks for reporting this issue. Will look at it and provide an update. Thanks!

@luckyj5 Do you have any updates on this? Thanks in advance.

@alex-vmw Could you summarize what needs to be done?
and if we could get PR from experts in community, that would be awesome.

@alex-vmw Could you summarize what needs to be done?

@rockb1017 Someone needs to re-write the plugin to follow the fluentd v1 plugin API (as per https://docs.fluentd.org/plugin-development/api-plugin-output). Instead of using the initialize, configure and start methods the plugin needs to implement the write method for the Buffered Plugin (see the documentation link I provided). I am sure you can re-use all of the existing code, just put it under the expected method for fluentd v1 plugin API. Here is an example of a change where I updated a fluentd plugin to be v1 plugin API compatible:
https://github.com/vmware/fluent-plugin-vmware-loginsight/commit/9257a19437042e85664d81cb6b8b66b55d976099#diff-85f44c2558f574957f698edc28ef94c2d05a31dc08a883b63b32f20ee2e81786

and if we could get PR from experts in community, that would be awesome.

As the owners of the spunk-hec plugin you would be those experts that I would expect to make the changes and if you have any questions, I am sure there are avenues (issues, forums, chat, etc.) for you to ask them from fluentd maintainers.


[New game]: Test your brain

🎮 Game Request
test your brain while learning the picture and match them.
Point down the features

Select program in which you are contributing
GSSoC23
Code of Conduct

[X] I follow CONTRIBUTING GUIDELINE of this project.

Hey @Sushilverma002 !
Thank you for raising an issue 💗
You can self assign the issue by commenting /assign in comment 😀
Make sure you follow CODE OF CONDUCT and CONTRIBUTING GUIDELINES 🚀
Don’t Forget to ⭐ our GameZone🎮
Make sure you join our Discord🕹

/assign

Hey @Sushilverma002 ! Thank you so much for your raising the issue💗
It’s all yours, you can come anytime again and make some contributions! 🚀
Alone, we can do little, but together we can do so much! 😇


Exception Armrest::Error: #Net::HTTPUnauthorized:0x0000561554b473e0 when executing terraspace up demo -y

Checklist

[ x ] Upgrade Terraspace: Are you using the latest version of Terraspace? This allows Terraspace to fix issues fast. There's an Upgrading Guide: https://terraspace.cloud/docs/misc/upgrading/
[ x ] Reproducibility: Are you reporting a bug others will be able to reproduce and not asking a question. If you're unsure or want to ask a question, do so on https://community.boltops.com
[  ] Code sample: Have you put together a code sample to reproduce the issue and make it available?  Code samples help speed up fixes dramatically. If it's an easily reproducible issue, then code samples are not needed. If you're unsure, please include a code sample.

My Environment

Software
Version

Operating System
Linux  <IP_ADDRESS>-microsoft-standard-WSL2  (Debian 11 Bullseye)

Terraform
v1.4.2

Terraspace
2.2.3

Ruby
ruby 3.0.3p157 (2021-11-24 revision 3fb7d2cadc) [x86_64-linux]

After executing terraspace up demo -y for the terraform code to be deployed in the azure subscription

Building .terraspace-cache/eastus/dev/stacks/demo
Current directory: .terraspace-cache/eastus/dev/stacks/demo
Creating Resource Group dev-eastus...
Exception Armrest::Error: #Net::HTTPUnauthorized:0x0000561554b473e0

download and install terraspace on debian
run terraspace new project infra --plugin azurerm --examples
followed by  terraspace up demo -y
According to bundle exec ruby azure_check.rb:
Successfully connected to Azure with your ARM_CLIENT_ID and ARM_CLIENT_SECRET
terraspace setup check:
Detected Terraspace version: 2.2.3
Detected Terraform bin: /usr/bin/terraform
Detected Terraform v1.4.2
Terraspace requires Terraform v0.12.x and above
You're all set!

Code Sample

Solution Suggestion

With the help of  "export ARMREST_LOG_LEVEL=debug" (from the post about similar issue #220 ) I can glean additional information and it seems related to authorization. I'll revisit the documentation and videos on the site to see if I can get past that error:
D, [2023-03-30T14:59:05.430528 #19537] DEBUG -- : resp #Net::HTTPUnauthorized:0x0000564c41b0f1b0
D, [2023-03-30T14:59:05.430654 #19537] DEBUG -- : resp.code 401
D, [2023-03-30T14:59:05.430688 #19537] DEBUG -- : resp.body {"error":{"code":"AuthenticationFailed","message":"Authentication failed. The 'Authorization' header is missing."}}

After exporting again the azure environment variables (ARM_SUBSCRIPTION_ID and the rest) I was able to successfully run terraspace! Nothing wrong with terraspace itself but a newbie user error :)
PS. After I resolved the initial error I ran into a second roadblock but thanks to the output from "export ARMREST_LOG_LEVEL=debug" I was able to determine that it was due to a policy I had applied to the subscription - "Public network access should be disabled for PaaS services".