Is this term a  required? GO:0009814   defense response, incompatible interaction

GO:0009814   defense response, incompatible interaction
Definition
A response of a plant to a pathogenic agent that prevents the occurrence or spread of disease.
How does this  term differ from its parent "innate immune response"
(other than being plant specific?)
if this term is required, it should probably be renamed plant innate immune response?
Or defined more precisely.
However note that a LOT of plant  immune terms which would fit this definitions are not under "GO:0009814   defense response, incompatible interaction"
@tberardini

Refers to the outcome of the process (i.e whether disease is observed).
If disease is not observed the interaction is "incompatible"
This isn't about the process per se. A particular interac tion can be "incompatible" for a particular pathogen gene.
Is an outcome of a process i.e  whether a disease can be caused
Example processes could be:
Hypersensitive response,
Lignification,
Activation of PTI or ETI signalling
but it does not include these processes
Can we merge?

@tberardini  any thoughts on this?

@lreiser and @ebakker2 Can you please have a look at this issue and comment?

So I think Val is right and we should revisit this part of the ontology apparently the last time it was really given a look was when Suparna Mundodi was at TAIR and the whole plant-pathogen issue was reviewed.
So I like the idea of having a 'plant type' innate immune response term

Innate immune response

[is a] (plant type) innate immune response

[is a] (plant type) pattern triggered immunity [PTI]
[is a] (plant type) effector triggered immunity [ETI]
[is a] systemic acquired resistance

But then we also have a lot of terms that are children of this
GO:0009814 defense response, incompatible interaction
that mostly are addressing the type of pathogen (fungal, bacterial, protozoan) which also includes specificity that probably doesn't belong in the GO term.

But then we also have a lot of terms that are children of this
GO:0009814 defense response, incompatible interaction
that mostly are addressing the type of pathogen (fungal, bacterial, protozoan) which also includes specificity that probably doesn't belong in the GO term.

@lreiser You are. right, I have been moaning about these too ;)
There are too many ways to describe the same process, so we have confusion and inconsistency.
it is getting clearer though !

defense response, incompatible interaction
merge into parent -> innate immune response
systemic acquired resistance + regulation terms
->make a direct child of innate immune response
(currently grandchild) Q check is this all innate?
jasmonic acid and ethylene-dependent systemic resistance ->make a direct child of innate immune response
jasmonic acid and ethylene-dependent systemic resistance, ethylene mediated signaling pathway->make a direct child of innate immune response
systemic acquired resistance, salicylic acid mediated signaling pathway ->make a direct child of innate immune response
response to jasmonic acid stimulus involved in jasmonic acid and ethylene-dependent systemic resistance ->make a direct child of innate immune response

This leaves the following

(67)
defense response to fungus, incompatible interaction

| − | (55) | defense response to bacterium, incompatible interaction
| − | (7) | regulation of defense response to bacterium, incompatible interaction
| − | (5) | positive regulation of defense response to bacterium, incompatible interaction
| − | (3) | negative regulation of defense response to bacterium, incompatible interaction
| − | (3) | regulation of defense response to fungus, incompatible interaction
| − | (3) | response to jasmonic acid stimulus involved in jasmonic acid and ethylene-dependent systemic resistance
| − | (1) | defense response to protozoan, incompatible interaction

These have 2 parents one to "defense response to blah and one to incompatible interaction"
If we merge we will lose one of these axis.
Alternatively, we could create terms "innate immune response to blah", but personally this would mean expanding every term under these branches to include all of the different organism classes. This doesn't seem practical.
We could merge with "innate immune response" and inform the providers that if they still want "in response to organism x " they will need to annotate concurrently?

If we go with option 2.
Contributors of the ones which would need reviewing to add "defense response to fungus" etc
@lreiser most are TAIR, would this be OK with you?

+
−
(101)
TAIR

| − | (27) | UniProt
| − | (5) | AgBase
| − | (1) | CACAO
| − | (1) | RGD
| − | (1) | TIGR

@ValWood just 101? Sure- I can handle it

@lreiser  would you prefer the existing term to merge into
"defense response to fungus" or "innate immune response"
or @pgaudet  should we create the "innate immune response to fungus" terms?
The the "innate immune response to fungus" approach  worries me because it would need to be replicated through the whole branch for every term for  virus, bacteria, fungi, oomycete etc.... it doesn't seem scalable.
Extensions would seem to be a much better option here (terms could even have a comment, consider extending this term with "defense response to blah)
Personally, I don't see why the "response to species"  is required if people routinely follow best practice capture the taxon in the dual taxon field. Maybe this should be enforced for this branch? That way, the annotation would become more consistent and the data could be mined more precisely.  Also, usually  a specific 'molecule' or pattern that is recognised (i.e lipid, carbohydrate) , not a 'species'.
Could you ask @thomaspd  about this next week? I could chat about  it if you like.
@lreiser do you want to wait until we chatted about the "response to species" terms before you do anything?

This ticket is a duplicate of
https://github.com/geneontology/go-ontology/issues/18739
I suggest we go ahead and merge
GO:0009814 defense response, incompatible interaction
into "defense response"
There is a whole other argument about the "defense response to" terms  but that won't be adressed in this ticket.
I will raise "defense response to" as a GO meeting item.

I'll close this one as duplicate so please refer to
#18739

This ticket here has more information. I closed the other one.


Recreate and Update Maven artifacts

Since the last few months, a lot of changes have been implemented in the main branch (e.g. multi collection support).
As consequence of that Maven artifacts on our repo need to be recreated and re-uploaded.

Done. Maven Artifacts have been updated in the mvn-repo branch.


Add array subscript operators for all types

Got sick of using .Elements even when I was using C++. Unfortunately using the subscript operator is a little bit slower in an unoptimized build because the operator[] function doesn't get inlined, but it is still convenient and gets optimized away immediately even at -O1. (See this godbolt test.)
Would appreciate thoughts on whether this is a good idea or if we should just make people continue using .Elements.

Gonna take a look at this now. I have some ideas, will report back in a bit

Im sort of interested on why this can't be inlined, besides that i think this is a good idea.

I hate stack overflow but this is interesting:
https://stackoverflow.com/questions/10670560/inline-member-operators-vs-inline-operators-c

Not sure about the inlining, but I can't get gcc to inline anything in an unoptimized build.


Fix bug in common dims

@pfultz2  should this get backported?

should this get backported?

I dont think so.


PICNIC-586: Increase minimum electron window width to 740

LGTM, I'd like to note the window needs to be between 740px and 800px to get the collapsed tab bar after this, maybe we can consider increasing the width that kicks in at. cc @cecileboucheron

Yeah I thought about it too. Let's see how this change feels first and tweak if needed.


ionic resources command problems

Short description of the problem:
ionic resources does not generate ios and android icons & splash screens in any way
ionic resources --icons generates icons for ios but NOT android. They are generated into the resources/android folder, BUT not copied and propertly renamed to platform/android/res, which means that when you compile the app, you get the cordova robot.
ionic resources --splash generates splash for ios but NOT android They are generated into the resources/android/splash folder, BUT not copied and propertly renamed to platform/android/res, which means that when you compile the app, you get the cordova robot.
What behavior are you expecting?
That it works correctly.
Steps to reproduce:

place icon.png and splash.png in the resources folder
Execute ionic resources
They are not created propertly.
Execute ionic resources --icons
Android icons in platform/res, are not propertly updated
Execute ionic resources --splash
Android splash in platform/res, are not propertly updated

Which @ionic/app-scripts version are you using?
Your system information:
Cordova CLI: 6.4.0
Gulp version:  CLI version 3.9.1
Gulp local:
Ionic Framework Version: 2.0.0-rc.1
Ionic CLI Version: 2.1.4
Ionic App Lib Version: 2.1.2
Ionic App Scripts Version: 0.0.39
OS:
Node Version: v6.4.0

I found a res folder at the ROOT of my project containing android resources. It might be that it creates it in the ROOT folder of the project, instead of placing it inside the platforms/android folder. If this helps you narrow it down more.

@mflmartin Me too. I think this happens after the new cordova-android version: 6.X.X. If you downgrade to 5.2.2 the icon is displayed but the splash screen don't.

This issue was moved to driftyco/ionic-cli#1638


[Server] Intermittent Repair Armor Test Failure hints at possible bug

General information:
Project issue is for:
Server
Expected result:
Running tests many times in a row should result in passes each time
Actual result:
Found some of the tests in RepairHelper.test.ts will fail ~8% of the time. The test  BotHelper › updateItemDurability() faceshield broken use repairkit with max dura degredation fails more often (5-14%) with a lower value than expected. Less often the thest BotHelper › updateItemDurability() repairkit with g36 with max dura degredation - Full repair fails (<1%) for receiving a value higher than expected.
Ran a battery of 1000 tests which confirmed the ~8% fail rate for Faceshield repair and ~.01% fail rate for the g36 repair.  Note tests fails only for tests that use the repair kit. test updateItemDurability() repairkit with slick armor with max dura degredation always passes since it's assert statements do not look for exact equality. Based on the pattern of tests failing I belive there is a potential rounding error bug within src/helpers/RepairHelper.getRandomisedArmorRepairDegradationValue
How to reproduce:
Run the following command to run a battery of tests:

COUNT=0; for i in {1..100}; do npx jest RepairHelper.test.ts --silent || COUNT=$(($COUNT+1)) && echo "Count: $COUNT" && echo "Loop#: $i" && echo "Percent: $((100 * $COUNT/$i))"; done

Screenshots:
BotHelper › updateItemDurability() faceshield broken use repairkit with max dura degredation

BotHelper › updateItemDurability() repairkit with g36 with max dura degredation - Full repair

Attachments

image.png (31 KiB)
image.png (31 KiB)
image.png (30 KiB)
image.png (35 KiB)
image.png (31 KiB)

Originally written by snekcode

Additional findings:
After about 10 debug runs I caught a fail condition. The tests will fail if the value returned from getRandomisedArmorRepairDegradationValue is, in the case of the faceshield, less than 10. On line 87 the if block only checks for Durability greater than Max and will equate the two.  In the failing test case max is higher than the durability amount. The test expects the durability to equal max.
The bug does exist in the random float generation inside getRandomisedArmorRepairDegradationValue however I'm unsure if this is a bug or just a poorly written test.  Should the purpose of this function always return the durability and maxdurability as equal? I'm to unsure on the desired implementation.  @chomp if you are able to weigh in with a direction to take I can fix.
Debug Screenshot:

Attachments

image.png (114 KiB)

Originally written by snekcode


Please add support for Bangla (bn)

India and Bangladesh have different Bangla
But you can add only one Bangla support

Can I work on this will be my first contribution and I am very confident I will complete. Bangla is my native language therefore I will be able to understand the language as well

Hi I have enabled Bengali,India as well so you can add the translations for both now
Bengali - https://crowdin.com/project/excalidraw/bn
Bengali, India - https://crowdin.com/project/excalidraw/bn-IN


Flip X and Y coordinates for WKT and array formats in XYPoint

Signed-off-by: Naveen Tatikonda<EMAIL_ADDRESS>Description
Change the order(flip) of X and Y coordinates for WKT and array formats used to index xy_point field type documents.
Issues Resolved
https://github.com/opensearch-project/geospatial/issues/155
Check List

[x] Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Codecov Report

Merging #156 (5ecc050) into main (7cdaf8d) will not change coverage.
The diff coverage is 66.66%.

@@            Coverage Diff            @@
##               main     #156   +/-   ##
=========================================
  Coverage     85.13%   85.13%
  Complexity      320      320
=========================================
  Files            44       44
  Lines          1063     1063
  Branches         86       86
=========================================
  Hits            905      905
  Misses          124      124
  Partials         34       34

Impacted Files
Coverage Δ

...geospatial/index/mapper/xypoint/XYPointParser.java
70.76% <50.00%> (ø)

...earch/geospatial/index/mapper/xypoint/XYPoint.java
74.13% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.


Elastic.Transport phase 2

This is a follow up to #5049
It renames Elasticsearch.Net.VirtualizedCluster to Elastic.Transport.VirtualizedCluster.
This also introduces Elastic.Transport.Tests a lot of tests from `Tests could potentially be ported over but they serve a dual purpose as documentation. Moving them would break our docs on elastic.co.
It further improves on making Elastic.Transport product agnostic:
Node now has no knowledge of Elasticsearchisms such as master eligable and the likes. Instead a tranport is loaded with an IProductRegistration that informs the transport whether the product supports pinging and sniffing, and if they do the implementations for the those. A product's sniff routine can add features to a node which is simply a HashSet<string> (exposed behind a IReadOnlyCollection<string>).
This IProductRegistration also steers the default user agent Transport sends.
In the previous PR, the settings was simply copied from Elasticsearch.Net. In order to be more future proof the transport now has its own TransportConfiguration.
Transport => TransportConfiguration
Elasticsearch.Net => ConnectionConfiguration
Nest => ConnectionSettings

All of these extend each other.
ConnectionSettings => ConnectionConfiguration => TransportConfiguration

Ideally the clients configuration would  be named NestConfiguration and ElasticsearchConfiguration but that ship has sailed and would be a massive breaking change, I am not yet comfortable doing.

Windows failure unrelated and most likely fixed by #5021


feat: Add HttpRequest::timeout_ms and Manifest::http_timeout_ms

Closes #151

Adds ability to configure timeout for extism_http_request
Sets default timeout to 30s, but this can be overridden still
Updates SDKs to support the new fields

Testing this out now, all is working great - just curious about a couple things:

for a host that wants to override the default to effectively disable a timeout, letting a plugin wait for a response indefinitely, I believe the only way to do that would be to use Duration::MAX? I think that's reasonable.. and we can document that. Let me know if that's untrue though!
it seems as though there is no way for a plugin to recover from a host-imposed timeout. I can see how this would be useful as a control mechanism from the host, but think that we should instead lift that responsibility to a more general plugin timeout, and not cause an HTTP timeout to bail the whole plugin.

re: 2, I'm looking at the implementation though and it seems like the http_request PDK function should just return the error to the caller within the plugin, but from my host, I can't get anything back except an err:
host:
use extism::*;

fn main() -> Result<(), Error> {
    let context = Context::new();
    let manifest = Manifest::new([std::path::PathBuf::from("code.wasm")])
        .with_http_timeout(std::time::Duration::from_millis(1000));

    let mut plugin = PluginBuilder::new(manifest).build(&context)?;

    match plugin.call("test", &[]) {
        Err(e) => println!("err: {:?}", e),
        Ok(s) => println!("output: {}", String::from_utf8(s.to_vec()).unwrap()),
    }

    return Ok(());
}

plugin:
use extism_pdk::*;

#[plugin_fn]
pub fn test(_input: ()) -> FnResult<String> {
    let req = HttpRequest::new("https://httpstat.us/200?sleep=2000");
    match http::request::<()>(&req, None) {
        Err(_) => Ok(format!("error!! but sending Result::Ok")),
        Ok(res) => Ok(format!("status: {}", res.status_code())),
    }
}

Note: both match arms in the plugin return Ok, so the runtime is propagating the error up before the plugin can do anything about it.

I think setting timeout to 0 will also wait indefinitely, I thought I saw that in the docs but can’t find it right now.
I can test that out and look into the error propagation issue tomorrow - I have a pretty good idea of how to fix that and I will update this PR.

Ok sounds good! Thanks. I'll also take a look to see about the 0 timeout setting in the http client.

update: setting the timeout to 0 bails immediately with the timeout error

Okay, thanks for checking! Looks like Duration::MAX is the best option then.

We're closing this now that we have a top level function timeout. If anyone does feel we need to support this, we can re-open.


RuntimeWarning: coroutine 'BaseEventLoop._create_server_getaddrinfo' was never awaited

Problem Description
I get this error when i run the mitmproxy command

Traceback (most recent call last):
  File "mitmproxy\master.py", line 54, in run_loop
  File "urwid\main_loop.py", line 287, in run
  File "urwid\main_loop.py", line 377, in _run
  File "urwid\main_loop.py", line 338, in start
  File "urwid\display_common.py", line 813, in start
  File "mitmproxy\contrib\urwid\raw_display.py", line 263, in _start
AssertionError

mitmproxy has crashed!
Please lodge a bug report at:
        https://github.com/mitmproxy/mitmproxy/issues
7sys:1: RuntimeWarning: coroutine 'BaseEventLoop._create_server_getaddrinfo' was never awaited
RuntimeWarning: Enable tracemalloc to get the object allocation traceback

Steps to reproduce the behavior:

Open CMD on windows and run mitmproxy

System Information
Mitmproxy: 7.0.4 binary
Python:    3.9.7
OpenSSL:   OpenSSL 1.1.1l  24 Aug 2021
Platform:  Windows-10-10.0.10240-SP0

How do you run the mitmproxy command? In other words, which console are you using? cmd, powershell, something else?

How do you run the mitmproxy command? In other words, which console are you using? cmd, powershell, something else?

I am using CMD. I can't install windows terminal (my windows version is lower)

Which Windows version are you on? :)

Windows-10 build 1024

Thanks for confirming. mitmproxy's console interface won't work before build 10586, which I think is the first build that includes ENABLE_VIRTUAL_TERMINAL_PROCESSING. mitmweb and mitmdump should be fine. I'll make sure that we have a better error message here.


Cleanup openshift configuration since it is not supported

It looks like it's possible for OpenShift v3 to support Rails 5, and thus Huginn, but our current .openshift setup isn't going to work. I'm removing it. If someone wants to get OpenShift v3 working with Huginn, that'd be great. Ideally it'd be a separate repo or simple wiki steps.
See also #246.

Thanks


Implemented columnMostCommonValueInSetConstraint

Description
Implemented columnMostCommonValueInSetConstraint
General Checklist

[ ] Tests added for this feature/bug
if it was a bug, test must cover it.
[ ] Conform by the style guides, by using formatter
[ ] Documentation updated
[ ] (optional) Please add a label to your PR

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

87 of 104 (83.65%)  changed or added relevant lines in 2 files are covered.
2 unchanged lines in 2 files lost coverage.
Overall coverage increased (+0.1%) to 81.469%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

src/whylogs/core/statistics/constraints.py
84
101
83.17%

Files with Coverage Reduction
New Missed Lines
%

src/whylogs/core/statistics/constraints.py
1
83.16%

src/whylogs/proto/constraints_pb2.py
1
67.07%

Totals

Change from base Build<PHONE_NUMBER>:
0.1%

Covered Lines:
4057

Relevant Lines:
4852

💛  - Coveralls


Customize Layout/Features

Is there any easy way to customize the layout or add functionality to the guide that I'm missing (other than just forking the whole project and modifying it).
For example: I want to move the nav to the right and add a scroll spy capability as well as change the order in which documentation appears (i.e. Props, Description, Render, Code to Description, Render, Code, Props.)
EDIT: Nevermind, I didn't dig far enough in.

You can override the styleguide components as described in the FAQ.

Well... I thought I had a handle on this, but it seems like I'm missing something important.
I have added an alias in the config.
I have copied over and customized the Layout.js and css.
That works.
Likewise, I did the same with ReactComponent.js
That works.
Tried the same process with Preview.
Didn't work. Still renders default Preview view.
Tried the same process with Playground.
Didn't work. Still renders default Playground view.
What am I missing?

I don’t know ;-) But if you post an example project somewhere I could take a look.

I forked the project and modified customised with a bare-bones example. It should render the preview section with just a paragraph of text and nothing else. Instead, it continues to render the normal Preview of the component unhindered.
https://github.com/nhavar/react-styleguidist/tree/master/examples/customised

There’s no rsg-components/Preview/Renderer component, only rsg-components/Preview. What do you want to customize there? There’s not much HTML ;-)
Same for Playground but I can extract HTML to Playground/Renderer.

In general, I need to understand the mechanism of what can/cannot be customized. Are only rsg-components with Renderers customizable? Or can any rsg-component be customized but the mechanism is different (different alias, different js/content structure).

Any .js file in rsg-components.

Okay, so I just have the alias setup wrong. Got it. Thank you.


Update agoric-axelar metadata

The existing light clients between Agoric and Axelar were misconfigured so the channels ended up being closed.
This is the updated information.

I was able to transfer from Axelar to Agoric using this channel. FWIW.


Error getting credentials on m1 mbp

Output from when trying to run it on an m1 mbp, with docker-compose installed with brew and the command run from inside the root directory after cloning it. Docker Desktop is running, but I'm not signed in. Does that matter? Thank you for your time.
docker-compose up -d
Building llama-gpt-api
[+] Building 0.2s (3/3) FINISHED                                                                                docker:desktop-linux
=> [internal] load build definition from Dockerfile                                                                                0.0s
=> => transferring dockerfile: 689B                                                                                0.0s
=> [internal] load .dockerignore                                                                                0.0s
=> => transferring context: 2B                                                                                0.0s
=> ERROR [internal] load metadata for ghcr.io/abetlen/llama-cpp-python:latest                                                                                0.2s

[internal] load metadata for ghcr.io/abetlen/llama-cpp-python:latest:

Dockerfile:8
6 |     ARG MODEL_DOWNLOAD_URL=https://huggingface.co/TheBloke/Nous-Hermes-Llama-2-7B-GGML/resolve/main/nous-hermes-llama-2-7b.ggmlv3.q4_0.bin
7 |
8 | >>> FROM ${IMAGE}
9 |
10 |     ARG MODEL_FILE
ERROR: failed to solve: ghcr.io/abetlen/llama-cpp-python:latest: error getting credentials - err: exec: "docker-credential-desktop": executable file not found in $PATH, out: ``
ERROR: Service 'llama-gpt-api' failed to build : Build failed

Interesting. You shouldn't need credentials to access it. In that case, the issue might be related to the Docker configuration. I'd recommend checking your Docker configuration file (usually located at ~/.docker/config.json). If there's an entry for "credsStore" or "credentialHelpers", try removing it temporarily and then restart Docker. This will prevent Docker from trying to use a credential helper when it's not necessary for public images.

That fixed it on an Intel Mac, but only if you DON'T restart Docker. It will add the line back in on restart.


Improve explicitness of help doc of --command on rez-env

Felt like this explicit mention of non-interactivity is helpful for users new to Rez.

Thanks for your recommendation! I agree it could be better worded. A few things I think could be improved:

"read" is a poor verb choice; all arguments are read. "execute" would be a better verb.
denoting it as a "string" is redundant, all commands are strings.
"command arguments" is misleading; it's actually a full command and command arguments.

Something like "Execute command within rez environment and exit..." would be better, plus your other additions (also, replace "command arguments" with just "command")
Would you mind updating?

Also, something I just realized, the command and arguments passed to -c must be passed in as a single shell argument, whereas the command and arguments after -- are all passed in as separate shell arguments.
That should probably be noted somehow in the help text.


Docker build refactoring.

Related to #30
Split the build scripts in pieces so that we can leverage the cache locally. It allows us to develop quicker.

lgtm

:+1:

@cedricziel Yeah you feel the pain right?
Maybe we should combine them again when we complete the feature and want to go GA to minimize the image size.

Actually I'm pretty happy right now - the image serves me very well :)
What bugs me is the deployment-time. Changing layers means rebuilding everytime from scratch and increased transfers volume to GCS. But I'm happy we're getting there! - Thanks a bunch.

@cedricziel Great :)
Alright, I'm going to merge this


[0.56] WebView source={html: "test"} return error

[ ] Review the documentation: https://facebook.github.io/react-native
[ ] Search for existing issues: https://github.com/facebook/react-native/issues
[ ] Use the latest React Native release: https://github.com/facebook/react-native/releases

Environment
React Native Environment Info:
System:
OS: macOS 10.14
CPU: x64 Intel(R) Core(TM) i7-4870HQ CPU @ 2.50GHz
Memory: 97.80 MB / 16.00 GB
Shell: 5.3 - /bin/zsh
Binaries:
Node: 8.9.4 - /usr/local/bin/node
Yarn: 1.7.0 - /usr/local/bin/yarn
npm: 6.1.0 - /usr/local/bin/npm
Watchman: 4.7.0 - /usr/local/bin/watchman
SDKs:
iOS SDK:
Platforms: iOS 11.4, macOS 10.13, tvOS 11.4, watchOS 4.3
IDEs:
Android Studio: 3.1 AI-173.4819257
Xcode: 9.4.1/9F2000 - /usr/bin/xcodebuild
npmPackages:
react: ^16.4.1 => 16.4.1
react-native: 0.56.0-rc.4 => 0.56.0-rc.4
npmGlobalPackages:
create-react-native-app: 1.0.0
react-native-cli: 2.0.1
react-native-communications: 2.2.1
react-native-debugger-open: 0.3.11
react-native-fetch-blob: 0.10.5
react-native-git-upgrade: 0.2.7
Description
WebView source={html:
test
} return error:
YellowBox.js:67 Possible Unhandled Promise Rejection (id: 0):
Error: Unable to open URL: about:blank
Error: Unable to open URL: about:blank
at createErrorFromErrorData (blob:http://localhost:8081/dba704fb-6fe0-4995-81aa-6f0f037a217c:2270:17)
at blob:http://localhost:8081/dba704fb-6fe0-4995-81aa-6f0f037a217c:2222:27
at MessageQueue.__invokeCallback (blob:http://localhost:8081/dba704fb-6fe0-4995-81aa-6f0f037a217c:2658:18)
at blob:http://localhost:8081/dba704fb-6fe0-4995-81aa-6f0f037a217c:2409:18
at MessageQueue.__guard (blob:http://localhost:8081/dba704fb-6fe0-4995-81aa-6f0f037a217c:2561:13)
at MessageQueue.invokeCallbackAndReturnFlushedQueue (blob:http://localhost:8081/dba704fb-6fe0-4995-81aa-6f0f037a217c:2408:14)
at http://localhost:8081/debugger-ui/debuggerWorker.js:72:58
console.warn @ YellowBox.js:67
onUnhandled @ Promise.js:43
onUnhandled @ rejection-tracking.js:71
(anonymous) @ JSTimers.js:255
_callTimer @ JSTimers.js:151
callTimers @ JSTimers.js:404
__callFunction @ MessageQueue.js:344
(anonymous) @ MessageQueue.js:107
__guard @ MessageQueue.js:291
callFunctionReturnFlushedQueue @ MessageQueue.js:106
(anonymous) @ debuggerWorker.js:72
Reproducible Demo
<WebView source={{html: "
test
"}}/>

Can you test this line?
<WebView  originWhitelist={['*']} source={{ html: "
test
", baseUrl: '' }} />

Working perfect after adding originWhitelist={['*']}
Thanks! 👍

Thank you @francisco-sanchez-molina !
This made react-native-signature-pad working with RN 0.56.
I'm sorry for posting in a closed issue. But if you have answers to my below questions I fell that they belong in this thread for clarification.

why do we need to whitelist * now and not before?
what is the webView trying to open when failing the whitelist test? "about:blank" is kind of hard to debug.

WebView documentation is very lacking. I spent endless hours figuring this out.


Adds PropertyUtils class

Description
Promoted PropertyUtils from gradle-commons-test since its methods can be used by the other classes in the library.
Changes

 PropertyUtils

Can you please add in the description the reason why it was taken from commons-test?
Also could you please not add changes for a totally different class? I see both additions and tests for PropertyLookup class which where not mentioned in the PR description.

Sure.
One of the reasons I added the CTOR there was to provide a direct use case for the class being added, as well because I would like to use it in atlas-unity:

@Azurelol the overall direction of changes should not span over multiple repos into a single patch. If the patch says it adds A and does also B and C just for convinience. That should either be directly reflected in the patch description or be added as yet another patch. Also, this is a common library. There is no need to add usecases for classes. It should be assumed that classes added to a libary have a reason to be added :).

I will open another PR for the new method for PropertyLookup.


Verilog Parser Failure

Yosys Version:<PHONE_NUMBER>6972de01d0360df63a32cafcdf2ec5
Steps to reproduce the issue
Run the following command: yosys -f "verilog -sv " -p "synth_ice40 -top Task_Test_Top -json Task_Test_Top.json" Task_Test_Top.v
with the below code:
Task_Test_Top.v
module Task_Test_Top
(
);

    task SomeTaskName(a)
    endtask

endmodule

Expected behavior
Some sort of syntax error message.
Actual behavior
Yosys parser fails with the below error message:
ERROR: Internal error - should not happen - no AST_WIRE node.

A more meaningful error is now output by #2045 -- which is that Yosys does not support non-ANSI task/function ports yet.


perf: Upgrade to Linux v6.4

I have an existing PR to upgrade for v6.3. Since then, v6.4 was released, so we can use it.
Use branch https://github.com/Granulate/linux/tree/granulate-perf-v6.3 and merge the latest kernel release into it, then test gProfiler with it.

perf was upgraded to v6.7 in #888


BUG: Uncaught TypeError: IntersectionObserver.observe: Argument 1 is not an object.

Is there an existing issue for this?

[X] I have searched the existing issues

What happened?
The error message "Uncaught TypeError: IntersectionObserver.observe: Argument 1 is not an object" typically occurs when the argument passed to the observe method of the IntersectionObserver is not a valid DOM element or is not an object that the IntersectionObserver can observe.
Record

[X] I agree to follow this project's Code of Conduct
[X] I'm a GSSOC'24 contributor
[X] I want to work on this issue

@Suchitra-Sahoo can you assign me this?

issue is resolved


[T2A2] [T14-A1] Yeo Kai Yan

Ready for review

@kaiyanyeo you have made a good attempt, do consider the reasons why inline method may not be good always.
going forward,

pay more attention to coding standards violation.
some useful ones include checking how conditional statements are written, naming conventions etc.,


[DataPipe] Add RandomSplitter (without buffer)

Stack from ghstack:

-> #724

This PR adds RandomSplitter without a buffer. The upside is that this uses less memory (good for memory-bound cases) but the downside are 1) only one group can be iterated through at a time and 2) it skips over all the groups that do not match the target (which is potentially wasteful).
Implementation note:

I decided against reusing _ChildDataPipe since its features are overly complicated for this use case.
I also decided against having an option to change seed automatically after each iteration, because there are situations where the first iteration is for test and the second iteration is for valid. Changing seed will be confusing and causes inconsistency.

See #712 for related discussion.
See #723 for the version with buffer.
Differential Revision: D38675266

Offline: Discussion:

This buffer-less version is likely better but we need more clear error message.
Let's support both syntax - if "target" is provided, then return only one DataPipe. Otherwise, returns a list of DataPipes. Look at the first commit.
We definitely want set_seed to allow changing of seed.
The default behavior should be same seed every epoch. We can have an argument to allow automatically changing of seed between epochs.

@nivekt has imported this pull request.  If you are a Facebook employee, you can view this diff on Phabricator.

@nivekt has imported this pull request.  If you are a Facebook employee, you can view this diff on Phabricator.

@nivekt has imported this pull request.  If you are a Facebook employee, you can view this diff on Phabricator.

Can we derive total_length from source Datapipe if possible?

@nivekt has imported this pull request.  If you are a Facebook employee, you can view this diff on Phabricator.

@nivekt has imported this pull request.  If you are a Facebook employee, you can view this diff on Phabricator.

Can we derive total_length from source Datapipe if possible?

Updated the implementation to do that with an exception when it cannot infer length from the source.

@nivekt has imported this pull request.  If you are a Facebook employee, you can view this diff on Phabricator.

@nivekt has imported this pull request.  If you are a Facebook employee, you can view this diff on Phabricator.

Thanks for the helpful comments. It is simpler than before now!

@nivekt has imported this pull request.  If you are a Facebook employee, you can view this diff on Phabricator.

@nivekt has imported this pull request.  If you are a Facebook employee, you can view this diff on Phabricator.

@nivekt has imported this pull request.  If you are a Facebook employee, you can view this diff on Phabricator.


Upgrade all intro-to-julia notebooks to 1.0

I've run through all notebooks, changed their kernel version to 1.0.0, and then cleared all output. A few minor changes to text/prose/code where appropriate.

cc @avik — this is ready when JuliaBox is.

Yes, there is, and I discovered it does work on many installations, but it's broken on Arctic3. I haven't checked on JuliaBox yet.

@vdayanand @abhijithch please add autograder bits (front end only) to some of these notebooks here.

Cool, thanks guys.  Matt, so we should use this for next week  training.
One thing: on Juliabox, the notebook should add all packages that are required. Is that done here (for Interact specifically)

Ah, I have a number of # using Pkg; Pkg.add("Interact"), etc. comments just above the using as I needed to add them myself.  I hadn't realized that JuliaBox1.0 would require them to add them, but if that's indeed the case we should probably un-comment them.


chore: reduce imports in 6 files under GroupTheory

Removes 17 imports in 6 files in Mathlib/GroupTheory.

Again, these are all transitive imports, but why not?
maintainer merge

bors r+

bors merge


Test: Fix regression when a failing test canceled the module hooks

Closes #870
This fixes a regression bug that was preventing the module hooks from
being assigned on the following tests of the same module.
To make it work without reverting the changes on fdf00a4, it improves
the reordered queue for tests that previously failed in the same
browser session.

This little bug took me 3 hours to fix, at least the queue is a little bit faster now.

I'll release 1.20.0 after merging this one.


[Docker] Possibility to have this run in a Docker

Is there any possibility to have this to run as a Docker ?

sure, but at the moment there is no pre-made docker config - thats a good request for enhancement, i'll add it next week.

i've though about what value can be added by creating custom docker configuration, but at the end its just a default one - pigallery works fine in a docker and how to do it is how you dockerize any nodejs application, nothing really specific


Unable to build from subdirectory

I've run into a problem using packer-plugin when the json I'm trying to use is in a subdirectory.
For example, my Jenkins job is cloning a git repo containing various packer configurations (e.g. centos-6.5, rhel-6.5, etc.). Each one is in a separate folder and has a template.json and a scripts directory.
Under the Packer post-build actions I specify Packer Template File "centos-6.5/template.json".
When I run the job I get the following error:
[workspace] $ /var/lib/jenkins/tools/biz.neustar.jenkins.plugins.packer.PackerInstallation/packer-0.7.5/packer build -only=virtualbox-iso -debug "/var/lib/jenkins/jobs/Packer build/workspace/centos-6.5/template.json"

4 error(s) occurred:

* Bad script 'scripts/base.sh': stat scripts/base.sh: no such file or directory
* Bad script 'scripts/vagrant.sh': stat scripts/vagrant.sh: no such file or directory
* Bad script 'scripts/virtualbox.sh': stat scripts/virtualbox.sh: no such file or directory
* Bad script 'scripts/cleanup.sh': stat scripts/cleanup.sh: no such file or directory

It appears that the relative paths (such as scripts/base.sh) in template.json are expected to be in the current directory (which is workspace/) although I'm calling workspace/centos-6.5/template.json.
So when I changed the script paths in the json to be "centos-6.5/scripts/base.sh" it ran successfully, however, I don't want to do that as it breaks the script if I then try to run it from within centos-6.5 (which is the recommended way).
It would be great to have a "Change directory" parameter for packer-plugin to change the working directory before calling packer.

Please open this on issues.jenkins-ci.org under the packer-plugin component.
On Sun, Feb 15, 2015, 5:34 PM Tenyo Grozev<EMAIL_ADDRESS>wrote:

I've run into a problem using packer-plugin when the json I'm trying to
use is in a subdirectory.
For example, my Jenkins job is cloning a git repo containing various
packer configurations (e.g. centos-6.5, rhel-6.5, etc.). Each one is in a
separate folder and has a template.json and a scripts directory.
Under the Packer post-build actions I specify Packer Template File
"centos-6.5/template.json".
When I run the job I get the following error:
[workspace] $ /var/lib/jenkins/tools/biz.neustar.jenkins.plugins.packer.PackerInstallation/packer-0.7.5/packer build -only=virtualbox-iso -debug "/var/lib/jenkins/jobs/Packer build/workspace/centos-6.5/template.json"
4 error(s) occurred:

Bad script 'scripts/base.sh': stat scripts/base.sh: no such file or directory
Bad script 'scripts/vagrant.sh': stat scripts/vagrant.sh: no such file or directory
Bad script 'scripts/virtualbox.sh': stat scripts/virtualbox.sh: no such file or directory
Bad script 'scripts/cleanup.sh': stat scripts/cleanup.sh: no such file or directory

It appears that the relative paths (such as scripts/base.sh) in
template.json are expected to be in the current directory (which is
workspace/) although I'm calling workspace/centos-6.5/template.json.
So when I changed the script paths in the json to be
"centos-6.5/scripts/base.sh" it ran successfully, however, I don't want to
do that as it breaks the script if I then try to run it from within
centos-6.5 (which is the recommended way).
It would be great to have a "Change directory" parameter for packer-plugin
to change the working directory before calling packer.
—
Reply to this email directly or view it on GitHub
https://github.com/jenkinsci/packer-plugin/issues/5.

Thanks, I just opened https://issues.jenkins-ci.org/browse/JENKINS-26966


[WIP] Sorter rules

What is this PR trying to achieve?
Adding the rules to the sorter for the miro preprocessor pipeline
Who is this change for?
💻
Have the following been considered/are they needed?

[ ] Deployed new versions

So, I think rules are implemented. What remains to be done is changing miro_image_sorter to expect a list of Decision from sort_image and to make it deal with 5 possible types of Decision instead of 3. Unfortunately, as it stands the lambda is broken so we cannot merge yet


Update UI, revert #2952 and fix JVM CPU usage again

I prefer to wait for @TinyAllen to fix other p99 graph bugs.


Would you make a keyword searching to search a property in the custom profile definition?

As you know, too many properties, I cant find a property I want to add quickly.

That's a good idea, I'll add it to my to-do list. I would also like to display the text that appears for the property in Explorer, as the official name can be confusing, e.g. Keywords displays as Tags, and you should be able to search on either.
Dijji

@Dijji
That's great, look forward to it.

Do you konw which property displayed as  ?

It turns out to be "System.IsRead". I had to start work on the coding for this to find out! I will update this issue when I have something for you to try.

I've just posted a release containing a preview of an updated Association Manager with search functionality. Give it a go and let me know what you think (good or bad).
Dijji

@Dijji I've just tried the newest release, it really makes it easy to find a property I want. It's awesome, Thank you very much. By the way, share the displayed items in the folder to treat my documents.

Glad you like it. I like it too - thank you again for the idea.
Dijji


Unable to host onepanel in domain

Hello,
I'm setting up the one panel on azure kubernetes using azure virtual instances. In editing params.yaml file I'm not getting what should be the  domain and fqdn.I tried with VM DNS name and then setting up the DNS zone and record for the same. But It's not working. Getting error as this site can not be reached. Please help me what should be the domain and FQDN.
Thank you

Hi @akshatamk, if your domain for Onepanel is sub.domain.com, then the FQDN to access Onepanel UI could be app.sub.domain.com. Note that currently, you would need a real domain name for this to work.

Thankyou @rushtehrani for your response.
Yes I do have  real domain name for  ex-eastus.cloudapp.azure.com
The domain for onepanel is - eastus.cloudapp.azure.com
FQDN-app."server_name".eastus.cloudapp.azure.com
still not working

@akshatamk following up from the Slack conversation, were you able to address this?


Add support for pymodbus 3.x.x

This is an implementation of the changes mentioned in #35, plus the removal of the from pymodbus.compat import iteritems line, as pymodbus.compat doesn't exist in version 3, and the line was unused anyways.
Summary of changes for classic_mqtt.py:

Catch import error if pymodbus 3 doesn't load, and try pymodbus 2

Summary of changes for support/classic_modbusdecoder.py:

Catch import error if pymodbus 3 doesn't load, and try pymodbus 2
Flag what pymodbus version we're using
use slave= for version 3 and unit= for version 2.

I could also just drop support for pymodbus 2, but it seems pretty easy and straightforward to keep it.

Thanks.


Fix dependency

What this PR does / why we need it:
Fix for https://prow.ci.kubevirt.io/view/gs/kubevirt-prow/pr-logs/pull/kubevirt_kubevirt/8878/pull-kubevirt-build/1601145621404717056
 Use --sandbox_debug to see verbose messages from the sandbox and retain the sandbox build root for debugging
compilepkg: missing strict dependencies:
	/tmp/cache/bazel/6f347497f91c9a385dcd9294645b76e0/sandbox/processwrapper-sandbox/289/execroot/kubevirt/external/com_github_sassoftware_go_rpmutils/uncompress.go: import of "github.com/xi2/xz"
No dependencies were provided.

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #
Special notes for your reviewer:
Release note:
NONE

/cc @dhiller @brianmcarey

@dhiller Should be good now

/retest
This PR should not cause any failures


Improve article 2208.00044

Exact location of issue
Inline undefined \color:
https://ar5iv.labs.arxiv.org/html/2208.00044#S2.p1.26.1
Problem details
It looks like one of the packages loaded by this article has had a dependency on color.sty or xcolor.sty, which is currently missing in latexml support. Could be a very easy fix, after it is clear which one.

Resolved.


croaring 2.0 yanked?

Hi,
It seems like the officially tagged release is 2.0 while this is the situation on crates.io:

Can someone from the project provide a clarification of the state of 2.0, is it brandishing a croaring 3.0 / 4.0 and what is exactly the release status.
Also, I personally think it would greatly add / improve clarity of the versioning would follow croraring major versioning at the least so that users clearly understand what they are getting...

Sorry for the misunderstanding @damageboy , there's a critical issue in CRoaring that made us yank the 2.0 release. Since there's a fix pr, I expect it will get merged soon and we can release 2.x version of croaring-rs with a fix.
In terms of versioning - new major version is released whenever there is a breaking change.

Version 2.0.2 is on crates.io now as the first non-yanked 2.x croaring-rs release.
I've hopefully clarified in the README to both include the version of CRoaring we build with, and to explain why we don't match the major version (because breaking changes in CRoaring have often not required breaking changes in the idiomatic rust bindings).
However, we are now mirroring the CRoaring version in the croaring-sys crate.


python version?

thanks for your sharing~~will there be a python implement version?

That's not in our plans right now...maybe sometime in future.


Moonstream infrastructure setup

[x] moonstream.to, www.moonstream.to S3 website + CloudFront distribution + A records
[x] api.moonstream.to - VM image, launch template, autoscaling group, A records (use Bugout load balancer)
[ ] Frontend CI/CD - deploy to S3, invalidate CloudFront cache
[ ] Backend CI/CD - deploy to API servers via SSH

@zomglings : Remove new load balancer from AWS, add moonstream.to certificates to existing load balancer, and create api.moonstream.to listener.

Load balancer fixed.

All code is in the private deployments repo.


Does the bot require a "owner?"

I know it does at the moment, but would it be possible to create a bot that's "free" and roams around the map at its own willpower?
You don't need to focus on this now, or even do it, but here is my brainstorming code.
NewBot.IsTRizzleBot			=	args[ 16 ] or true (Not sure I modified this right)
NewBot.Owner				=	args[ 16 ] or ply
Argument 16 would not be required when the bots are created, and only server admins could edit the bot after it's created. The bot would "follow" anything but could just be programed to go to random points.

I know it does at the moment, but would it be possible to create a bot that's "free" and roams around the map at its own willpower?
You don't need to focus on this now, or even do it, but here is my brainstorming code. NewBot.IsTRizzleBot = args[ 16 ] or true (Not sure I modified this right) NewBot.Owner = args[ 16 ] or ply
Argument 16 would not be required when the bots are created, and only server admins could edit the bot after it's created. The bot would "follow" anything but could just be programed to go to random points.

IMPORTANT: Never set IsTRizzleBot to anything other than true!!!
IsTRizzleBot is used to check if this is a bot that should be controlled by my addon. If you change this to anything else, the bot will do absolutely nothing, “unless you have another addon that controls all bots in general.”
As for the bot Owner, currently the bot will fail to work without one as most functions require it. I have considered bots without an owner, but I don’t see a point for the bot not to have an owner in the first place. Even then it would take a decent amount of time for me to program a decent AI that can make its own decisions.
Note - I’m not saying this is a horrible suggestion, just not in the scope of this addon. I have planned to make tactical combat AI as well as making a way to command the bot.

Figured, mostly just asking if a modified "base" of this addon would work. Although not that I'm gonna make my own, ill be way over my head. Thank you again!

@strubium
When I release #30, the bot will no longer require a owner to function as I have added some fail safes and changed the scope of this addon. This addon will now be a bot base for me to use to make versions of the bot to play other game modes.

@strubium
When I release #30, the bot will no longer require a owner to function as I have added some fail safes and changed the scope of this addon. This addon will now be a bot base for me to use to make versions of the bot to play other game modes.

Wow! That's really cool! What happens when a bot is created without an owner?

@strubium
When I release #30, the bot will no longer require a owner to function as I have added some fail safes and changed the scope of this addon. This addon will now be a bot base for me to use to make versions of the bot to play other game modes.

Wow! That's really cool! What happens when a bot is created without an owner?

For now the bot will pick a random sniper spot and hide there while looking for possible enemies. After a while the bot will pick another spot and do the same thing again. Its not much for now, but I gives me the base I need when programing the bot for other game modes.


Missing setupFormErrors causes fatal error on template

Cannot view the MailChimp Signup Form page that I've set up.
[Emergency] Uncaught BadMethodCallException: Object->__call(): the method 'setupFormErrors' does not exist on 'SilverStripe\Forms\Form'
The SilverStripe 4.0.0 change log describes: setupFormErrors renamed to restoreFormState.
Which is why replacing $form->setupFormErrors(); with $form->restoreFormState(); in src/Pages/SignupPageController.php seems to solve this issue.
Are you sure this add-on is compatible with SS4?

Using PHP 7.2. Excerpt from my composer.json:
"silverstripe/recipe-cms": "4.2.2@stable",
"innoweb/silverstripe-mailchimp-signup": "dev-master"

Sorry for this, merged that in from the SS3 branch without checking...


ReadTheDocs documentation build is failing

Currently we use Sphinx, but let's port them to MkDocs since we typically write in Markdown. Here are some links...
https://www.mkdocs.org
https://mkdocs-alabaster.ale.sh

Replaced by MkDocs
Fixed by #59, #60, #61


Fixes #51613.Fixed Executing TextEdit.new().set_draw_control_chars(true)

Bug was because of uninitialized popup menu. So I put popup menu initialization in constructor itself.

This was removed from the constructor to increase performance. Instead, It should skip the menu update in set_draw_control_chars if it has not been created yet.

Okay I will do that.

Remember to squash your commits: https://docs.godotengine.org/en/stable/community/contributing/pr_workflow.html#the-interactive-rebase

Remember to squash your commits: https://docs.godotengine.org/en/stable/community/contributing/pr_workflow.html#the-interactive-rebase

Is right what I have done? Bit inexperienced in git

Is right what I have done?

Not yet, as you can see there are 5 commits in this PR, when there should be only one.
You have to rebase to squash the commits into one (not merge), and force push to update the PR (again, without merging first, otherwise you're re-adding everything you just squashed).
I'll do it this time as in the current state it's not trivial to fix when not familiar with Git rebases.

Is right what I have done?

Not yet, as you can see there are 5 commits in this PR, when there should be only one.
You have to rebase to squash the commits into one (not merge), and force push to update the PR (again, without merging first, otherwise you're re-adding everything you just squashed).
I'll do it this time as in the current state it's not trivial to fix when not familiar with Git rebases.

Thank you so much! Time to watch git tutorials :)

Thanks!


downgrade client-go to v0.17.9, upgrade capi to v0.3.10 and capv to v…

What this PR does / why we need it:
This PR makes version changes to match the capi release 0.3.10

downgrades client-go to v0.17.9
upgrades capi to v0.3.10 and capv to v0.7.1

Which issue(s) this PR fixes:
Fixes #17

[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: abhinavnagaraj
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

OWNERS [abhinavnagaraj]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

/lgtm


Only one proxy used out of the whole list?

We find that only 1 LAST proxy is used from the array of proxies.
This is confirmed by running "netstat -anp | grep PROXY_PORT".
Is this a bug or known behavior that pokeminer would use only 1 proxy until it gets banned/goes down?

you misunderstand the proxy list. Request (the module used) only supports 1 proxy and also the structure to save the data for proxy only has 1 field "http" that you overwrite if you define it new.
However: I programmed myself some way to use different proxy for different accounts. Will add a PR once the next release is out.

What about proxy jump? Create a proxy dictionary just like the account, then detect each worker that get banned and set banned workers connection to other proxy.
I'm already create a banned detection, by checking forts lenght on each scan. Once it's counting reach 5 times for example, banned worker thread will be shutdown, not just killed and restart. If using proxy then it could modified to reroute the connection instead of getting shutdown.
On my scanning, I found out that at some moment not all workers are getting banned, that's what make me create banned detection.
I'm still waiting for next release, then will try to add a PR about banned detection if it's not exist yet.

you are not a python dev?
dictionary={}
list=[]
tuple=()
so accounts is a list of tuples, not adictionary like the proxies (you are mixing up words)
I think your request is very special, but if you wanna create a PR we will see if it gets accepted

Yes I'm new to python. What I mean is create a list of proxy dictionary, then when a worker gets banned we just need to grab another proxy address from the list and start a new connection.

okay then we have 2 usecases proxys are for:

people who need proxys to access internet (I recomment using the proxy variable as default)
people who want to route through different proxys to balance requests per IP.

When designing this I recommend not using the same variable for both since those are different usecases.

What @gunawanputra says makes sense. Though I'm not that much inclined to do it, since my accounts are still working without need for proxy :wink:
If anyone wants to give it a try, here's a hint: worker.pyL87. Instead of just using config.PROXY, write something that will keep state of all proxies and provide the best one to freshly-created slaves.

However: I programmed myself some way to use different proxy for different accounts. Will add a PR once the next release is out.
@Aiyubi , could you please share your code to use multiple proxies?

I wanted to run pokeminer on AWS, but AWS's IPs are banned by Niantic.


ImmutableDB: check checksum when reading blocks

Note that if this is merged, #1177 cannot yet be closed because of:

Blocks in the volatile DB have not been checked for validity, but we have checked that the body hash in the header actually matches the body, so if that check fails later, it must point to a disk failure and we should trigger recovery.

bors r+


add  a  program  for sorting   queue without  extra  space

Add your program to the repository it will be counted as your hacktober fest 2021 pull request.

write the code and update in  the  repository

Add all the DSA code of any topic in a particular folder as mention in the readme in any language all valid pull requests will be accepted. Don't forget to read the rules in the readme file as long as u did it correctly all pull requests will be merge.

No need to ask to assignation anyone can contribute do as many contribution u could

Try to write these program in java and python also

Added code for sorting queue without extra space please checkout #46


xgbod is failing when passing less than 202 rows

The Bellow code is working when I am giving no_of_rows = 202; but if I reduce the no_of_rows = 201.  The code is failing at predict(). and giving the error mentioned below the code.
@yzhao062 Is XGBOD needs to be trained with a minimum number of rows i.e 202
Following is the code snippet
no_of_rows = 202
outliers_fraction = 0.1
clf_obj = XGBOD(contamination=outliers_fraction)
new_df_train_data = pd.DataFrame(np.random.randint(0,no_of_rows,size=(no_of_rows, 2)), \
                                columns=list('AB'))

X_train = new_df_train_data.values
y_train =  pd.DataFrame(np.random.randint(0,2,size=(no_of_rows, 1)), \
                        columns=list('y')).values

# fit the model with training data
print(len(X_train), len(y_train))
y_train = y_train.reshape(y_train.size, 1)
clf_obj.fit(X_train, y_train)

test_data = pd.DataFrame(np.random.randint(0,50,size=(50, 2)), columns=list('AB'))
X_test = test_data.values
print(clf_obj.predict(X_test))

Error snippet
AttributeError                            Traceback (most recent call last)
<ipython-input-194-fee4e0bcf9ca> in <module>
     16 test_data = pd.DataFrame(np.random.randint(0,50,size=(50, 2)), columns=list('AB'))
     17 X_test = test_data.values
---> 18 print(clf_obj.predict(X_test))

~/anaconda3/envs/tensorflow/lib/python3.7/site-packages/pyod/models/xgbod.py in predict(self, X)
    379
    380         # construct the new feature space
--> 381         X_add = self._generate_new_features(X)
    382         X_new = np.concatenate((X, X_add), axis=1)
    383

~/anaconda3/envs/tensorflow/lib/python3.7/site-packages/pyod/models/xgbod.py in _generate_new_features(self, X)
    266         for ind, estimator in enumerate(self.estimator_list):
    267             if self.standardization_flag_list[ind]:
--> 268                 X_add[:, ind] = estimator.decision_function(X_norm)
    269
    270             else:

~/anaconda3/envs/tensorflow/lib/python3.7/site-packages/pyod/models/knn.py in decision_function(self, X)
    246
    247             # get the distance of the current point
--> 248             dist_arr, _ = self.tree_.query(x_i, k=self.n_neighbors)
    249             dist = self._get_dist_by_method(dist_arr)
    250             pred_score_i = dist[-1]

AttributeError: 'NoneType' object has no attribute 'query'

Any workaround?
Your help would be appreciated?
Thanks,
Abhijeet

Thanks @yzhao062

Hello
I am in the process of trying to pass a precomputed matrix to KNN and have it calculate with brute force. According to your documentation it should not be possible, but I have determined that it works. It would just require some adjustment to the code changed in this fix
pyod/models/knn.py#L201
else:
would have to be changed to
elif self.neigh_.algorithm in ["ball_tree", "kd_tree"]:
After the change, KNN can be passed a precomputed distance matrix with the parameters (algorithm="brute", metric="precomputed") using the fit function


certbot: Modify nginx configuration to support automated renewal.

This should work; I've partially tested it on chat.zulip.org.
Before we merge this, I think we should think a bit more about the paths involved and make sure we're happy being stuck with them for a long time:

/var/www/certbot
/root/certbot-auto

@gnprice @rht FYI.

https://travis-ci.org/zulip/zulip/jobs/297000527#L2140

Fixed.

So, the remaining problem here is that this runs unconditionally; we should only run it if the user is actually using certbot.  Two changes are needed;

I think it probably makes sense to extract a small script that can check if the the Zulip cert is a symlink to something under /etc/letsencrypt/live, and if so, run the renewal.
We should download certbot if it isn't already there, and maybe change its path.

It's also possible we should have a setting in /etc/zulip/zulip.conf to control whether certbot is being used...
@gnprice thoughts on that last question?

Another way to put it: move all the flags and setup to puppet?

I'd rather not stick things in /root -- I think of that space as scratch space for a human sysadmin, not a place for software to install things into and depend on. Which also makes it a brittle place to put things, as a human may clear things out of that scratch space when they don't recognize them. Either /usr/local or /opt would be reasonable areas, I think.
It looks like this is just one file, a script, downloaded from certbot upstream? Perhaps /usr/local/bin/certbot-auto.

It's also possible we should have a setting in /etc/zulip/zulip.conf to control whether certbot is being used...

Yeah, I think it would be a little too magical if pointing the Zulip cert to a certain directory tree caused auto-renew to be activated. Not because I'm particularly worried that that will ever give the wrong behavior in the wild -- but because it doesn't feel like something predictable.

/root

I think we've also gotten occasional feedback from server admins, particularly on first trying a Zulip install, that our use of /root (for things like /root/zulip -- which I think was the last case of that left) felt off to them, and made them less confident in Zulip's packaging.

Maybe /usr/local/sbin/cerbot-auto?

Added a commit moving the path.

For the other path question, I found this SE discussion where the top couple of answers are informative:
https://unix.stackexchange.com/questions/47436/why-is-the-root-directory-on-a-web-server-put-by-default-in-var-www
If we were making an old-fashioned webroot where hand-written static HTML files went, somewhere under /srv would be most appropriate. Thinking again about this case, though, what we have is really more of an implementation detail of the certbot set up by the Zulip installer/packaging, containing transient state. So someplace under /var is appropriate, probably under /var/lib/zulip in order to namespace it. Perhaps /var/lib/zulip/certbot-webroot/?

Yeah, I like that better as well.  Want to take over this PR and make that change and test it out on a new prod machine?  I need to focus on other things for the next couple days, and this is the kind of thing that deserves careful testing.
(The other thought I'm having is that we may want to think about having install-certbot  use apt-get install letsencrypt on Xenial to use the system package, though that is sorta annoying because then the commands are different on the two platforms... but I think we were going to need a wrapper script in the cron job anyway).

Sure -- can do that.

(The other thought I'm having is that we may want to think about having install-certbot use apt-get install letsencrypt on Xenial to use the system package, though that is sorta annoying because then the commands are different on the two platforms... but I think we were going to need a wrapper script in the cron job anyway).

Is there any advantage to using system package in Xenial? If there isn't I'd wait until when Travis has Xenial for build support, and when Zulip no longer supports Trusty.

I'm inclined not to try to use the system package, just because certbot seems to be under pretty active development and so the version in Xenial is kind of old. (Which is also why it's called letsencrypt there.)

Pushed a version with the webroot name change (and tweaking the other name change to remove a comment mentioning /root.)
Still to do is to add a setting to /etc/zulip/zulip.conf like "certbot_autorenew", and have the cron job check that before proceeding. And then to thoroughly test.

We should download certbot if it isn't already there, and maybe change its path.

@timabbott , you mentioned this above, but I'm not sure I follow; doesn't scripts/setup/setup-certbot do this now?

@timabbott , you mentioned this above, but I'm not sure I follow; doesn't scripts/setup/setup-certbot do this now?

We only do that in the installer.  So if you have an existing Zulip server and want to switch to using certbot for managing your certs, there isn't a way to do that.  Could be part of the switchover instructions, but I think setup-certbot won't work directly.

I'm inclined not to try to use the system package, just because certbot seems to be under pretty active development and so the version in Xenial is kind of old. (Which is also why it's called letsencrypt there.)

I guess the main reason I was thinking we might want to use the system package is that it adds another network dependency on another repository to the installer.  But maybe this OK, in that if you're not on the real Internet, you also probably have your own CA.

OK so I think the next thing we need to do is somehow make puppet/zulip/files/cron.d/certbot-renew not run unconditionally.  Maybe the right answer is to make it call a Zulip wrapper script (/usr/local/bin/zulip-certbot-renew?) that can do some check for whether the machine actually has certbot, and do nothing if it isn't?  That would avoid adding an every-minute-failing cron job to existing Zulip servers.

if you're not on the real Internet, you also probably have your own CA.

Yeah, I think this logic is sound. Or at least: if you're not on the real Internet, a generic automated certbot workflow isn't going to work for you.

For making the renewal attempt not happen unconditionally, my plan is what I said last night, in keeping with our discussion upthread:

Still to do is to add a setting to /etc/zulip/zulip.conf like "certbot_autorenew", and have the cron job check that before proceeding.

I might fit this into a command like crudini --get ... && /usr/local/bin/zulip-certbot-renew ...; if the logic gets any more complicated than that I'll pull it out into a tiny wrapper script.

if the logic gets any more complicated than that

Urgh, it does because crudini has no mode to gracefully return a default value if the setting is missing (like Python's two-argument dict.get.) If we used it more widely, I'd be tempted to either fix that, or make a trivial wrapper script to fix it.
Instead I'll just pull this cron job into a trivial script.

Just pushed a few additional commits (and all rebased), which I think should address all existing concerns. Entirely untested, though, so that's my next order of business. Also needs docs.
In particular I think with this version the docs can say to just run scripts/setup/setup-certbot if you want to adopt our certbot-management in an existing install.

Just pushed a version with several fixes, workflow improvements, and expanded usage messages. This one is tested to work both for new installs (with --certbot to the install script) and existing ones (running scripts/lib/setup-certbot), on Trusty and Xenial.
Next up is docs.

OK, and pushed a docs commit too.
Might be best not to actually merge the docs commit just yet; mostly we get away with our docs being from master and most server admins being on the latest release, but this could be a case where the discrepancy would actually confuse people.

For the docs, I think we can just move the link on zulipchat.com to point to the /1.7/ rather than /latest/ version of the docs, and then merge the changes.

Everything other than the docs looks great; so I merged all but the last commit.  I'm pretty excited about this!  BTW on the front of doing docs updates related to this, https://github.com/zulip/zulip/pull/7200 is something we should pick up once we've resolved the issue of breaking the existing docs...

For the docs, I think we can just move the link on zulipchat.com to point to the /1.7/ rather than /latest/ version of the docs, and then merge the changes.

Reasonable. I think we should do a little more fixing-up than that -- grepping for en/latest/prod, there's also a mention in the README, and even some internal links in docs/index.rst that are absolute.
I think the absolute doc-internal links may just be a bug; they were introduced yesterday. So it's just those two places where we want to link to "latest release" rather than "master". Two is enough that we'll forget to update one of them some release if we rely on remembering... I might document them (or a grep command) next to ZULIP_VERSION in version.py, but would be glad to hear a better idea.

I think the absolute doc-internal links may just be a bug; they were introduced yesterday.

Some absolute doc-internal links are required.  Anything that we want to render properly in GitHub markdown needs to use absolute links.  So CONTRIBUTING.md, README.md, etc. have to use that.
We can add a lint rule to require relative links for docs/ and ban relative links in those GitHub-renderable markdown files.  I'll play with that idea.

Oh, I see, you're referring to index.rst.  Fixed in 6973f1d1ef5efd0270fa65dc710956bc95e7c7ad

New version pushed.

The test failure is a linter bug that got into master; can you rebase?
The second commit (pointing at the 1.7 release docs) should probably be the first commit (i.e. we should merge and deploy that before merging the first commit).
I think my main concern with that second commit is whether we want to add some sort of notice in our ReadTheDocs for production that you're getting the previous release's version (I guess it isn't easy to do that for 1.7, but...).

The second commit (pointing at the 1.7 release docs) should probably be the first commit (i.e. we should merge and deploy that before merging the first commit).

I think you're being fooled by GitHub. :-) That commit is first in the branch.

I think my main concern with that second commit is whether we want to add some sort of notice in our ReadTheDocs for production that you're getting the previous release's version (I guess it isn't easy to do that for 1.7, but...).

Hmm, yeah, the real solution to this should be to have a 1.7 branch and use that for the 1.7 docs. Then we have the flexibility to go back and make the docs better after the release is out.
The docs are thin (ironic!) and there doesn't seem to be much configuration, but it seems like they just take the names of the tags and branches in your source control, and that's that, other than two special names of their own ("latest" and "stable"). Ideally the branch would be like "1.7.0-docs" and it would show up as "/en/1.7.0/", but no dice. So it just comes down to picking a name that's not too confusing in source control, and also not too cumbersome in the URL...
Zooming back in to this specific issue, though: there's no notice like that on e.g. the Django docs, or PostgreSQL. It's just there in the URL, and in the overall nav for the docs. So I think relying on those is fine.

Also, pushed a rebased version.


when a task started using visual studio code tasks , environment variables aren't working

VSCode Version:1.2.0
OS Version: ubuntu 15.10

Steps to Reproduce:

create gulp tasks
user exec in a task and set env option to exec as process.env
run the task by issuing gulp command from terminal (it works)
run task from visual studio interface by using shortcut key (environment variables are not set !!!)

Dups #6110


ETA German version?

I would love to give this a try ...

Thank you very much for your interest! We still have the plan to release the German version. But it's just that I am recently working on my dissertation, which leaves me very little time to work on the German model. A conservative estimate is that it will be ready in June or July. Sorry that it is taking so long.


Someting when wrong when adding SPFX to group site

Category

[ ] Question
[ ] Typo
[X] Bug
[ ] Additional article idea

Expected or Desired Behavior
SPFX solution should install after adding app from site contents on group site
Observed Behavior
After adding the app I get "Something went wrong" message after about 30 seconds. I've tried reinstalling the app both on the site, and also removing the app from the app catalog. Bumping the version number doesnt help either.
The app have previously been installed on other tenants without problems.

Steps to Reproduce
Add app from site contents.

I just verified with old package that has been installed succesfully previously, and this now fails on multiple tenants. May be some issues with the platform..?
I've also created new packages which also fails.

Issue seems to be related to registration type «DocumentLibrary». Shouldnt this be valid? Registration ID is 101

For anyone else facing this issue:
RegistrationType should be List even when you only want extension to trigger Ok document libraries. Registration ID should be 101.


Add special case for 'mt-changelog' package

such that if it used within mt-changelog it should use ./bin/changelog command,
because we cannot just npm install -D mt-changelog for mt-changelog itself.

Closed by #13


fix MSF scan result parsing (fixes issue #192 )

Fixes regex used to match msf scans output.

@mattoufoutu This is broken with a fresh install of Kali 2017.2 with apt update and apt upgrade done.  I have created a new pull request about this with an updated regex that should hopefully work.


fix deface warning

I face some warning about spree_static_content when run rake deface:precompile
See https://github.com/spree/deface/issues/76
Thanks

Thanks @odk211, this has been applied to 3-0-stable and master branch.


Puppeteer Getting Redirected from Targeted Pages

Some of the sites I am trying to scrape have a feature that redirects Puppeteer from the targeted pages to different pages. How do I stop that redirect and scrape the target pages?
I tried this, but it just terminates the thing if a redirection is detected. That is not good enough. I need to stop the redirect and scrape the targeted page:
await page.setRequestInterception(true);
page.on('request', request => {
if (request.isNavigationRequest() && request.redirectChain().length !== 0) {
request.abort();
} else {
request.continue();
}
});

Same here, running with node --trace-warnings shows UnhandledPromiseRejectionWarning: Error: net::ERR_FAILED at ... errors.


We already have an EditText, can only have one Error

Showing Me error when i call mAwesomeValidator.validate() method 2nd Time

From my side, calling validate() more than one time doesn't have any problem.
Could you please be more specific about the details (some code, stacktrace and steps).
Thank you.

its work fine when i used ValidationStyle.BASIC  but when i used  ValidationStyle.UNDERLABEL  its Crashed My App with Error
We already have an EditText, can only have one Error
even i put   EditText in  TextInputLayout

Sorry, but I just tried with the demo app, it worked fine.
The demo app contains many EditText fields, what I've tried just now is:

Fill some of them with valid input;
Leave some of them blank (invalid);
Fill some with invalid input;
Choose UNDERLABEL style;
Click SUBMIT button many times (which calls mAwesomeValidation.validate();), and corresponding error messages show up;
Click CLEAR button to reset all error messages;
Try again to click the SUBMIT button many times, and the proper error messages show again.

No problem, no crash.
If you could not show even some pseudo code or exact steps to reproduce, or any logs, then I have to say sorry that I really can't help.
Actually I suspect there is something else wrong which cause your crash, not necessarily from this library (which I tried totally fine).
Thanks.


Subset datagrid ux tasks  2022 02

closes #656

When a variable has units, the units should be displayed in the column header for that variable (ex: "Hemoglobin (g/dL)" in LLINEUP)
Always show all relevant ID columns (Participant ID, Household ID, etc) even when no variables have been added to the table
When just ID columns are in the table (ie, when no variables have been added), please display the text: To configure this table, click on the "Add columns" button. above the table (Note that the "Select variables" button is being changed to "Add columns" in this https://github.com/VEuPathDB/web-eda/issues/839)
Never pre-populate the table with any variables (including featured and starred variables). Default view of the subsetting results table should just show columns for the relevant IDs
In https://github.com/VEuPathDB/web-eda/issues/839, we indicate that the "Select variables" button will be moved to the left of the entity name. The variable selector tree should open below this button. Please position the variable selector tree so that we can see the table behind it (We should see the table on top of the variable selector box and also to the left and right of it)
If I am in a new analysis and I star one of the featured variables from the browse/subset variable tree, I get an error message when I click "View and download"
All featured variables appear in the featured variables box in the variable selector for every entity, even when they do not belong to a given entity. There is a check box next to each of the featured variables, making it seem as though I can add these variables to my results table. Please grey out and remove the check box from featured variables that do not belong to the entity the user has selected.

I just discovered that we're making two requests when the modal is open, and the user has selected variables. I will try to address this before merging.

I think this latest commit will do it.

@eikonomega just want to alert you to this PR, since it likely overlaps with your related work on the Downloads tab. Feel free to review, but I will likely go for a merge sooner rather than later :slightly_smiling_face:.

@eikonomega I'm planning to merge this shortly. I'm happy to work out any merge conflicts that you might run into on https://github.com/VEuPathDB/web-eda/tree/shifu__758__downloads_tab


buildCSPHeaders Error

After the installation, I tried to customize the config, and then I ran the next project. So, I got the following error:

next: 11.1.2,
react: 17.0.2
Please let me know if you need more information.
Many thanks,

I've tested, and if you change the '??' to '||', it works fine!

Thanks for fixing this, @JLucasCAmorim! Reopening this issue until I can fix the release.


Add ulx cleanropes to clean ropes only connected to world

Fixes: https://github.com/TAServers/gmod-utils/issues/11

Ugh gotta install the GLuaLinter as well ;f

Btw you can branch directly within this repo (and any others) now that I've added you to the org. You can also see private repos owned and co-owned by the GMod team.

Looks good. I'm torn between whether it should cleanup all world ropes always, or all ropes owned by a target player (or players) though

I don't think there's many uses for placing ropes on world itself, normal players generally just spawn a plate and put ropes on that to make signs and whatnot. But your regular minge is just gonna grab the rope tool, start spinning around and left clicking.

Btw you can branch directly within this repo (and any others) now that I've added you to the org. You can also see private repos owned and co-owned by the GMod team.

Good to know, maybe I will try it later.

Looks good. I'm torn between whether it should cleanup all world ropes always, or all ropes owned by a target player (or players) though

That said, NADMOD correctly sets owner of the rope, so I can make it require a player argument. Up to you.

I think it's fine as-is given we currently have no command. Can always change it if needed


@conda-forge-admin,please add bot automerge

[x] I read the conda-forge documentation and could not find the solution for my problem there.

Issue:

Environment (conda list):

$ conda list

Details about  conda and system ( conda info ):

$ conda info

Hi! This is the friendly automated conda-forge-webservice.
I just wanted to let you know that I added bot automerge in conda-forge/cppbktree-feedstock#5.

Hi! This is the friendly automated conda-forge-webservice.
I just wanted to let you know that I added bot automerge in conda-forge/cppbktree-feedstock#5.


Incorrect inspection of object

While working on should-be-unexpected I stumbled on this:
 should-be-unexpected on master* $ node
> var expect = require('unexpected');
undefined
> expect({ length: 12 }, 'not to have own property', 'length');
Error:
expected [  ] not to have own property 'length'
    at repl:1:1
    at REPLServer.self.eval (repl.js:110:21)
    at repl.js:249:20
    at REPLServer.self.eval (repl.js:122:7)
    at Interface.<anonymous> (repl.js:239:12)
    at Interface.emit (events.js:95:17)
    at Interface._onLine (readline.js:202:10)
    at Interface._line (readline.js:531:8)
    at Interface._ttyWrite (readline.js:760:14)
    at ReadStream.onkeypress (readline.js:99:10)
>

It is an edge case, and it's probably only ever going to show up in test cases in assertion frameworks, but it looks silly...

Mhh. maybe arrayLike is a bit too open

This is already fixed as the arrayLike type is now abstract.


Work out how to have multiple instances of the deliberation-empirica service running simultaneously, re: terraform

When we have multiple collaborators with their own experiments, we'll need to spool up multiple instances of the service and back them up in a way that means they don't overwrite each other

I am not very familiar (yet) with how instances are spun up and managed, but it seems like a good use case for containers running on a cluster, where every experiment  (version of the service i think) runs in a separate container, with their own backups.


DBZ-6226 Treat REAL as DOUBLE consistently

https://issues.redhat.com/browse/DBZ-6226
The snapshot phase uses the JDBC driver metadata to resolve the column mappings; however during streaming if a CREATE TABLE ddl statement is used, the column mapping is based on that of the DDL, which was not treating a REAL column as DOUBLE; instead it treated the column as FLOAT32 data type, which is technically incorrect.

@Naros Unfortunately there is also https://dev.mysql.com/doc/refman/8.0/en/sql-mode.html#sqlmode_real_as_float
We need to decide how to incorporate it correctly.


Fix 99 (and allow qualified static linking)

This fixes our oldest "Urgency-Soon" issue here: https://github.com/Microsoft/visualfsharp/issues/99
It also includes some work I did a while back so to extend the static linking support to allow static linking of compoennts ike System.Collections.Immutable.  The addition is that the staticlink option now allows
--staticlink:AssembyName,Prefix

where Prefix is used to disambiguate between various types in statically components that have the same name.  This is becoming a particular problem since all Microsoft components tend to have a private "version" type with the same name. We don't use this in the code base but I'm including it since I also happened to fix  https://github.com/Microsoft/visualfsharp/issues/99 while looking at this problem, and it seems we may as well include the extended support as well.

Closing as I'll resubmit without the new feature (the tests have not been updated)

Perhaps an additional to the help text noting prefix?

Yeah, one of the reasons I closed was because I lost all the commits that had that sort of thing implemented.  I don't know what happened to them, will try to find them.


Improve setting locality

Background: https://airtable.com/tblD3oZPLJgGhCmch/viwchkdQkRUw6hZ3z/rec5VGO7Lbcu06Knb?blocks=hide
PM: @awoods187
Eng: @andy-kimball

@awoods187 (or @johnrk since this is Core) looking at the Github issues linked from AirTable, it doesn't look like there is any engineering work ongoing on this (status: "Investigation", and all linked issues still open), and thus nothing to document at this time.
Do you agree with that assessment?  If so I'd like to close this.

@knz , was there anything merged or being actively worked on here?

No there hasn't
Sent from my Android device with K-9 Mail. Please excuse my brevity.


Move the experimental 'category edition' button into the Edit mode

What

[ ] Move the experimental 'category edition' button currently in the product page into the Edit mode

Mockup

Part of

#1161

Does the category edit mode work ok if we have no category at all ?

Does the category edit mode work ok if we have no category at all ?

No, the button "Edit" is deactivated, since nothing happens when the "Additional Button" is clicked in this case.
If we have no category as all, the button "Add missing product category" is shown, but no action has been applied yet.

@teolemon @cli1005 Actually the current implementation is more or less OK when you want to slightly fix an existing category.
It does not work when you're starting from scratch, the reason being that we don't really have access to root categories:

the "root" categories (https://world.openfoodfacts.org/api/v2/taxonomy?tagtype=categories&include_root_entries=1&include_children=0&lc=en%2Cfr&cc=fr) are full of crap, like 'en:ayrshire-new-potatoes', 'en:batches-withdrawn-from-retail-stores' or 'en:caviar-substitutes'. We cannot do anything with them.
in addition to that there are categories without parents, like 'en:plant-based-foods-and-beverages', so we cannot go up to real root categories like a possible 'en:foods-and-beverages' (https://world.openfoodfacts.org/api/v2/taxonomy?tagtype=categories&tags=en%3Aplant-based-foods-and-beverages&include_children=0&lc=en%2Cfr&cc=fr)

Besides, as a user I'm not sure I would bother to climb the category tree step by step, where on the website I can just type "sardines à l'huile" instead of a painful exploration of Conserves, Produits de la mer, Poissons, Poissons en conserve, Poissons et viandes et oeufs, Sardines, Sardines en conserve, Filets de poissons, Sardines à l'huile, Filets de sardines, Sardines à l'huile d'olive, Sardine à l'huile d'olive appertisée

@teolemon @cli1005 Actually the current implementation is more or less OK when you want to slightly fix an existing category.
It does not work when you're starting from scratch, the reason being that we don't really have access to root categories:

the "root" categories (https://world.openfoodfacts.org/api/v2/taxonomy?tagtype=categories&include_root_entries=1&include_children=0&lc=en%2Cfr&cc=fr) are full of crap, like 'en:ayrshire-new-potatoes', 'en:batches-withdrawn-from-retail-stores' or 'en:caviar-substitutes'. We cannot do anything with them.
in addition to that there are categories without parents, like 'en:plant-based-foods-and-beverages', so we cannot go up to real root categories like a possible 'en:foods-and-beverages' (https://world.openfoodfacts.org/api/v2/taxonomy?tagtype=categories&tags=en%3Aplant-based-foods-and-beverages&include_children=0&lc=en%2Cfr&cc=fr)

Besides, as a user I'm not sure I would bother to climb the category tree step by step, where on the website I can just type "sardines à l'huile" instead of a painful exploration of Conserves, Produits de la mer, Poissons, Poissons en conserve, Poissons et viandes et oeufs, Sardines, Sardines en conserve, Filets de poissons, Sardines à l'huile, Filets de sardines, Sardines à l'huile d'olive, Sardine à l'huile d'olive appertisée

We just add a button in the Product Edition page which works the same way as the "Additional Button", no change has been made to the Category Edition :)

@teolemon Not sure I follow you: are we supposed to show this to an end-user that clicks on the "No category so far: please select one" button?

We just add a button in the Product Edition page which works the same way as the "Additional Button", no change has been made to the Category Edition :)

@cli1005 It's just that in Category Edition there were cases that were not handled (cf. the TODOs).

We just add a button in the Product Edition page which works the same way as the "Additional Button", no change has been made to the Category Edition :)

@cli1005 It's just that in Category Edition there were cases that were not handled (cf. the TODOs).

Yes, we might need or have already another issue concerning TODOs of Category Edition? the objective of this issue is just to move the button, in my opinion

@teolemon Could also be fixed if 'en:plant-based-foods-and-beverages' had parents (probably the root).

So... I create a PR juste for the new button or we wait for all the points to reach?

I've updated my comment with links to the blocking issues. Let's put this one on hold, at least until we clean up server side ?

Started the clean-up server side @cli1005 @monsieurtanuki @stephanegigandet
https://github.com/openfoodfacts/openfoodfacts-server/pull/6765

@teolemon I can start working on the "No category: we start from root" feature, can't I?
Or would we better off (haha) with a "type in/search category" feature?

Two are equally valid and complementary options.
Search might be slightly more useful in the short term given the wealth of categories

@teolemon Have you got some starting point suggestions for the "type in/search category" feature?

We have the autosuggest API in the Dart package already, and then on click, you could load the partial taxo API matching the selected tag (thus no UI change needed for final validation)

@teolemon I know that's not what the mocks said but my brain does not understand the concept of multiple categories on the same tree, UI/UX-wise.
I suggest something similar to the website: the list of the current product categories, and the possibility to add a category with autocomplete.
Something like that:

I'm not sure I understand how I'm supposed to interact with this new mockup.
Here's for reference my last version, along with search:

At this point of complexity, the solution we have in V1 (field with existing categories as chips, plus the ability to add more thanks to autocomplete) looks more intuitive.

@monsieurtanuki I've made variants with Radio buttons

Also, in the case of single category selection, I'm not sure how we're supposed to handle the thousands of products who do have multiple categories.

@teolemon Would you prefer something like this?

According to https://openfoodfacts.github.io/api-documentation/#7Metadata

Important! The categories hierarchy is not a tree but a lattice: each node can have several children, but also several parents.

@teolemon That would tend to plead for "type in keywords/search" rather than "tree search", wouldn't it?

Probably.


Error when creating a release with draft: false

Hi everyone
When I try to create a release with draft: false I get the following error:
[1](https://redacted/redacted/redacted/actions/runs/65#jobstep-9-1)
ApiError: Internal Server Error
[2](https://redacted/redacted/redacted/actions/runs/65#jobstep-9-2)
    at catchErrorCodes (file:///run/act/actions/akkuman-gitea-release-action@v1/dist/index.js:9809:15)
[3](https://redacted/redacted/redacted/actions/runs/65#jobstep-9-3)
    at file:///run/act/actions/akkuman-gitea-release-action@v1/dist/index.js:98[4](https://redacted/redacted/redacted/actions/runs/65#jobstep-9-4)0:17
4
    at Generator.next (<anonymous>)
[5](https://redacted/redacted/redacted/actions/runs/65#jobstep-9-5)
    at fulfilled (file:///run/act/actions/akkuman-gitea-release-action@v1/dist/index.js:9593:58)
[6](https://redacted/redacted/redacted/actions/runs/65#jobstep-9-6)
    at process.processTicksAndRejections (node:internal/process/task_queues:95:5) {
[7](https://redacted/redacted/redacted/actions/runs/65#jobstep-9-7)
  url: 'https://redacted/api/v1/repos/redacted/redacted/releases/1776',
[8](https://redacted/redacted/redacted/actions/runs/65#jobstep-9-8)
  status: 500,
[9](https://redacted/redacted/redacted/actions/runs/65#jobstep-9-9)
  statusText: 'Internal Server Error',
[10](https://redacted/redacted/redacted/actions/runs/65#jobstep-9-10)
  body: { message: '', url: 'https://redacted/api/swagger' },
[11](https://redacted/redacted/redacted/actions/runs/65#jobstep-9-11)
  request: {
[12](https://redacted/redacted/redacted/actions/runs/65#jobstep-9-12)
    method: 'PATCH',
[13](https://redacted/redacted/redacted/actions/runs/65#jobstep-9-13)
    url: '/repos/{owner}/{repo}/releases/{id}',
[14](https://redacted/redacted/redacted/actions/runs/65#jobstep-9-14)
    path: { owner: 'redacted', repo: 'redacted', id: 1776 },
[15](https://redacted/redacted/redacted/actions/runs/65#jobstep-9-15)
    body: {
[16](https://redacted/redacted/redacted/actions/runs/65#jobstep-9-16)
      body: '',
[17](https://redacted/redacted/redacted/actions/runs/65#jobstep-9-17)
      draft: false,
[18](https://redacted/redacted/redacted/actions/runs/65#jobstep-9-18)
      name: 'e3m-dev-beta',
[19](https://redacted/redacted/redacted/actions/runs/65#jobstep-9-19)
      prerelease: false,
[20](https://redacted/redacted/redacted/actions/runs/65#jobstep-9-20)
      tag_name: '1.0.0',
[21](https://redacted/redacted/redacted/actions/runs/65#jobstep-9-21)
      target_commitish: ''
[22](https://redacted/redacted/redacted/actions/runs/65#jobstep-9-22)
    },
[23](https://redacted/redacted/redacted/actions/runs/65#jobstep-9-23)
    errors: { '404': 'APINotFound is a not found empty response' }
[24](https://redacted/redacted/redacted/actions/runs/65#jobstep-9-24)
  }
[25](https://redacted/redacted/redacted/actions/runs/65#jobstep-9-25)
}
[26](https://redacted/redacted/redacted/actions/runs/65#jobstep-9-26)
::error::Internal Server Error

Same action workfs fine with draft: true
Is this a bug or am I doing something wrong? On the GUI I can create a release without issue.

@tovoro Can you provide a repository or yaml sample？

name: e3MobileN Release

on:
  issue_comment:
    types: [created]
  push:
    branches:
      - 'xxx*'

jobs:
  release:
    name: xx Release
    runs-on: ubuntu-latest
    strategy:
      matrix:
        node-version: [18.x]
    steps:

###default build
      - name: Checkout the source code
        uses: actions/checkout@v3
        with:
          ref: 'e3m-release-beta'

      - name: Setup Node.js $
        uses: actions/setup-node@v3
        with:
          node-version: 18.x
          cache: 'npm'
          cache-dependency-path: package-lock.json

      - name: Install dependencies
        run: npm ci

      - name: Build Default
        run: ng build

      - name: Parse ./src/assets/config/config_json to get version
        run: echo "CONFIG_JSON=$(jq -c . < ./src/assets/config/config.json)" >> $GITHUB_ENV

      - name: Create default Release Archive
        uses: thedoctor0/zip-release@master
        with:
          directory: /tmp
          filename: 'e3MobileN-default-${{ fromJson(env.CONFIG_JSON).version }}.zip'
          path: '${{ GITEA.WORKSPACE }}/dist/e3mobile'

      - name: Create Release
        uses: akkuman/gitea-release-action@v1
        with:
          draft: true
          prerelease: false
          release_name: 'xxx-${{ fromJson(env.CONFIG_JSON).version }}'
          tag_name: '${{ fromJson(env.CONFIG_JSON).version }}'
          target_commitish: 6cfb7dc4cf424f4d7d0b3380b36d060495de4b93 #git rev-parse origin/xxx-release-beta
          files: |-
            /tmp/xxx-*.zip

@tovoro I can't seem to find the problem. Can you provide a complete log?


Event handler: OrderInvalidation

With the contract upgrades in place we are now able to listen for and handle the OrderInvalidation event whose logic was already implemented. This PR just connects the listener to the handler.
Test Plan
Existing CI.

Since this PR is based on the upgraded contracts, I think the manual e2e test will have to wait until all the components are working together.

@fleupold - Unfortunately it is going to be a challenge for us to simulate this locally because I would have to run the orderbook with event sync. Also, My local front is is not able to communicate with my local backend at the moment (failing to send orders). I may not get back to this until next week.
Logging this here for now.
Order Not accepted by the operator

Error handling a 400 error. Likely a problem deserialising the JSON response


In upgrade screen, titles are misaligned

version - master jan 07
Steps:

Go to catalog and add Elasticsearch with older version
Wait for it to complete and click on Upgrade Avaiable button

Results: the title catalog and name of catalog are misaligned

Expected:  Aligned properly

version - master 1/19
Verified fixed


Marathon air alarm issues.

Screenshots

Security checkpoint lacks any kind of air alarm.

CMO rooms and western surgery likewise lack any air alarms.

Hi, i might be able to jump on it this evening.


What do I need to do for face photos before testing?

What are the requirements for input photos?
e.g. size, rendering, illumination, file size and so on........

The test.py script will automatically perform any required resizing and face alignment.
More specifically, face alignment is performed at this line and resizing at this line.
The model should be relatively tolerant to most common white-balanced illuminations that are dominated by ambient or uniform lighting (i.e., no strong cast shadow or visible lighting patterns on the face).
There is no requirement on file size. Any RGB file that can be open by PIL/pillow should work fine.


Not possible to "get" with a default of None

What if someone wants to get and have a default of None? Since it is checked to be not None for it to be used, that is currently not possible.

This is done but in the dev branch. It now uses a custom Default object as the default value. That way we can pass in None as our default.