HHH-15002 H2 supports 'true' and 'false' boolean literals

Cherry picked from 1706141ffc154c1b61e304445a603ebf9a3e0a2e

Thanks!


Always a Chance save succeeding where it should fail

47 < 56

Aside from Always a Chance, this is what is enabled.

As far as additional mods, I have ToyBox & Buffs

Quote from the main page
Mythic.PatchAlwaysAChance: 'Always A Chance' succeeds on a natural one
and applies to most d20 rolls
Works as intended. You can disable the patch via the ingame menu.

Side note; there is at least one Paizo feature that allows you to turn 1's on damage rolls to max damage instead. So this buff to the otherwise abysmal 'Always A Chance' seems fair in my eyes.


Added solution to a hackerearth problem

@hanshulll, I have already added commits in this merge request. Please review it

@prackode
Thank you so much for your contribution and do provide a detailed description of what type of contribution you've done and put your GitHub username either at the top or end of the code


FileSystemCollector is Stalling

Experiencing this on both Windows and Mac.

Any idea what versions are impacted? Been waiting a while on a run using release 2.1.80 (let it run for a bit over an hour, on a freshly installed VM). Not sure if this is normal or if the stable 2.1 release builds are also impacted by this stall?

This should be a 2.2 only issue.
Are you seeing ASA have a near 0% CPU utilization while it appears to be stalled?
You can also add --verbose to see every filename as it's parsed. If you're seeing this bug that output will freeze.
Let me know if you're still having issues.
-------- Original Message --------
On May 5, 2020, 9:59 AM, Reid Wightman wrote:

Any idea what versions are impacted? Been waiting a while on a run using release 2.1.80 (let it run for a bit over an hour, on a freshly installed VM). Not sure if this is normal or if the stable 2.1 release builds are also impacted by this stall?
—
You are receiving this because you were assigned.
Reply to this email directly, view it on GitHub, or unsubscribe.

Just saw you mentioned it's been running for an hour. That shouldn't be the case on a fresh VM. If you could run it with verbose to nail down the directory it's stalling on that may help me.

Yeah I noticed with 2.2 it was using 0% CPU. 2.1 it is using some cpu time. Anyway, ASA is not at fault here. I think I get to blame the windows 10 update team =). I updated the VM the other day, and didn't notice that it left me with a > 30GB C:\Windows.old. As an added bonus, even local administrator has no access to the files here (so, ASA is giving a lot of file permission errors trying to read these files, I guess it wants to record a hash of each file? Lots of 'Couldn't chomp 4 bytes of  (System.UnauthorizedAccessException)' and inability find group from SID errors).

(I should note that in between troubleshooting I had attempted to run 2.1 without the filesystemcollector, and it resulted in spending forever collecting registry key data....I suspect that I'll find a similar monstrosity from the recent windows os update involving registry keys. Sad that ASA doesn't spit out what registry keys it is inspecting with the --verbose flag though, will have to watch it with procmon I guess. A feature request might be to honor --verbose option under '-r' and even 'gui' options ;-)).

Thanks for the extra context.
We try to chomp 4 bytes off every file to check if it's an executable. And then we check if it's signed if it's a windows binary. There's currently no setting to disable that. If you'd like one please file an issue.
The can't map Sid errors can be safely ignored that's just trying to turn windows permissions into human readvle strings.
I believe verbose in gui is included in 2.2.
If you could open an issue for registry collector and I'll definitely handle it soon.
-------- Original Message --------
On May 5, 2020, 11:16 AM, Reid Wightman <<EMAIL_ADDRESS>wrote:
(I should note that in between troubleshooting I had attempted to run 2.1 without the filesystemcollector, and it resulted in spending forever collecting registry key data....I suspect that I'll find a similar monstrosity from the recent windows os update involving registry keys. Sad that ASA doesn't spit out what registry keys it is inspecting with the --verbose flag though, will have to watch it with procmon I guess. A feature request might be to honor --verbose option under '-r' and even 'gui' options ;-)).
—
You are receiving this because you were assigned.
Reply to this email directly, view it on GitHub, or unsubscribe.￼
[ { "@context": "http://schema.org", "@type": "EmailMessage", "potentialAction": { "@type": "ViewAction", "target": "[https://github.com](https://github.com/microsoft/AttackSurfaceAnalyzer/issues/417#issuecomment-624222209", "url": "[https://github.com](https://github.com/microsoft/AttackSurfaceAnalyzer/issues/417#issuecomment-624222209", "name": "View Issue" }, "description": "View this Issue on GitHub", "publisher": { "@type": "Organization", "name": "GitHub", "url": "https://github.com" } } ]

On 2.2 this is being caused by a hang in X509Certificate2.Import. https://github.com/dotnet/core/issues/4649
I'm disabling our functionality that uses it in both 2.1 and 2.2 in new releases later today until that bug is addressed.
-------- Original Message --------
On May 5, 2020, 11:16 AM, Reid Wightman wrote:

(I should note that in between troubleshooting I had attempted to run 2.1 without the filesystemcollector, and it resulted in spending forever collecting registry key data....I suspect that I'll find a similar monstrosity from the recent windows os update involving registry keys. Sad that ASA doesn't spit out what registry keys it is inspecting with the --verbose flag though, will have to watch it with procmon I guess. A feature request might be to honor --verbose option under '-r' and even 'gui' options ;-)).
—
You are receiving this because you were assigned.
Reply to this email directly, view it on GitHub, or unsubscribe.

One cause of stalls should be fixed in #418

Try out 2.1.83 or 2.2.19.

@reidmefirst #419 is done and adds verbose tracing to registry collector on 2.2 and 2.1. Builds are in the pipeline now. Should be ~2.1.84 and ~2.2.21 will have Fixes for this bug, Verbose on Registry and Verbose on GUI.

@reidmefirst Have reproduced a registry collector stall #424
For reproducing issues on the newest builds use --verbose --singlethread it will run slower (no parallelization) but it runs the same algorithm, and the log output makes more sense.


the test phase,there are a file lost,"vid_test_samples_list.npy",can you release it?

the test phase,there are a file lost,"vid_test_samples_list.npy",can you release it?

Thanks for your question.
It is a randomly generated test set of an arbitrary number of the starting frames.
You can generate it yourself or try a list I generated by replacing line 152 in the rdpd_code/data.py file with the following:
first_frame_list=[15, 39, 93, 127, 116, 23, 94, 163, 178, 104]


Feat/minor updates for paii

no need to merge; just to show what has been changed for us

sorry for accidentally sending this to the upstream.


Upgrade to ruby 2.5.1

Signed-off-by: David A. Wheeler<EMAIL_ADDRESS>

Thanks!
I'm prioritizing this update, because it includes a number of security vulnerability fixes.
I believe that none of the vulnerabilities are exploitable in the BadgeApp.  Instead, many of them involve corner cases of data handling that we would never want to allow in the first place.  In particular, we try to be picky about data (like URLs) that use directly in processing later, and we don't create filenames with names that are easily controlled by untrusted users.
That said, there are many clever attackers, and I'd rather have several defensive layers.  That way, if something slips through, the underlying platform will counter it.


pictures in the readme!

Feature request for pictures :p

Hi @bashleigh !
I just write the post in which is based this repo!
If you have any dude, you can write me!
C u!


Other protocols config.json templates

Thanks for this, i was able to run client using Sagernet (Trojan) But would appreciate if you can expand more on grpc and websocket config.json templates.
thanks

Does SagerNet support Trojan + GRPC? I don't see such an option. I know it supports Vless + GRPC, but I don't have plans to implement Vless, even though they are pretty much the same thing.

Thank you for the reply, am not saying Sagernet supports Trojan-gRPC, what am saying is I was able to run Trojan Rust very well on Sagernet. And am asking if you can provide better or comprehensive config.json for TrojanRust supported gRPC, websocket etc rather than just the Trojan which you gave it’s template. Provide templates for gRPC, websocket etc too.
thank you

GRPC for TrojanRust at this moment is still experimental as I have discovered a few issues with it. Plus the existing GRPC implementation is only compatible with TrojanRust itself which makes it pretty useless for mobile devices. I am currently working on supporting GRPC feature for Xray client since plenty of existing proxy software on Android integrates Xray client(V2rayNG, for example), and so far I am able to make it work for TCP traffic. Once I have fully completed the integration and tested the functionality on my VPS, I will update the templates and instructions to set things up. But for now, GRPC is not very usable.
For Websocket, I have no intention of implementing it, because the only reason anyone would still consider adding this extra layer is to enable CF proxy, and nowadays there are better alternatives like GRPC and QUIC, which are both on the roadmap of this project. So I don't find it necessary to have Websocket.


Both v-if and v-else true (Vue + .NET)

Version
2.4.2
Reproduction link
https://jsfiddle.net/chrisvfritz/50wL7mdz/
Steps to reproduce
I created a project using this tutorial:   https://new-issue.vuejs.org/
What is expected?
Or condition is true and the DOM shows the content inside v-if, Or condition if false and the DOM shows the content inside v-else.
What is actually happening?
The DOM shows both content.

Your repro link doesn't contain v-if or v-else

Hi, thanks for your interest but Github issues are for bug reports and feature requests only. You can ask questions on the forum, the Discord server, gitter or StackOverflow.


项目无法运行

您好，按照您的步骤起了一下项目，无法运行，想请教下您这是什么问题，以下是我的控制台报错
Cloning failed using an ssh key for authentication, enter your GitHub credentials to access private repos
When working with public GitHub repositories only, head to https://github.com/settings/tokens/new?scopes=&description=Composer+on+DESKTOP-O49OUNT+2023-03-13+1616 to retrieve a token.
This token will have read-only permission for public information only.
When you need to access private GitHub repositories as well, go to https://github.com/settings/tokens/new?scopes=repo&description=Composer+on+DESKTOP-O49OUNT+2023-03-13+1616
Note that such tokens have broad read/write permissions on your behalf, even if not needed by Composer.
Tokens will be stored in plain text in "C:/Users/dark/AppData/Roaming/Composer/auth.json" for future use by Composer.
For additional information, check https://getcomposer.org/doc/articles/authentication-for-private-packages.md#github-oauth
Token (hidden):

您好，按照您的步骤起了一下项目，无法运行，想请教下您这是什么问题，以下是我的控制台报错
Cloning failed using an ssh key for authentication, enter your GitHub credentials to access private repos When working with public GitHub repositories only, head to https://github.com/settings/tokens/new?scopes=&description=Composer+on+DESKTOP-O49OUNT+2023-03-13+1616 to retrieve a token. This token will have read-only permission for public information only. When you need to access private GitHub repositories as well, go to https://github.com/settings/tokens/new?scopes=repo&description=Composer+on+DESKTOP-O49OUNT+2023-03-13+1616 Note that such tokens have broad read/write permissions on your behalf, even if not needed by Composer. Tokens will be stored in plain text in "C:/Users/dark/AppData/Roaming/Composer/auth.json" for future use by Composer. For additional information, check https://getcomposer.org/doc/articles/authentication-for-private-packages.md#github-oauth Token (hidden):

看样子是你无法克隆项目到本地，可以尝试下载zip， https://github.com/Chef5/PopRun-b/archive/refs/heads/master.zip


Cannot create a custom rectangular domain

Hello,
I am trying to setup a rectangular domain where y in (-4,4) and I run into some difficulties. After going through DomainTutorial notebook I believe that the following should work:
#kinetic.py
import proteus.default_p as p
...
# p.nd = 2
# p.L = (2 * np.pi, 8)
# p.x = (0, -4)  # This doesn't seem to affect NumericalSolution
# Now trying to be more explcit about domain
p.domain = Domain.RectangularDomain(L=(2 * np.pi, 8), x=(0, -4), name=p.name)
...
ns = NumericalSolution.NS_base(so, [p], [n], so.sList, opts)
ns.calculateSolution("kinetic")

I looked up a couple of files so I understand that default_p.domain = None and I noticed that NumericalSolution.py has
            if p.domain == None:
                if p.nd == 1:
                    p.domain = Domain.RectangularDomain(L=p.L[:1],name=p.name)
                elif p.nd == 2:
                    if p.polyfile != None:
                        p.domain = Domain.PlanarStraightLineGraphDomain(fileprefix=p.polyfile,name=p.polyfile)
                    else:
                        p.domain = Domain.RectangularDomain(L=p.L[:2],name=p.name)
                elif p.nd == 3:
                    if p.polyfile != None:
                        p.domain = Domain.PiecewiseLinearComplexDomain(fileprefix=p.polyfile,name=p.polyfile)
                    elif p.meshfile != None:
                        p.domain = Domain.Mesh3DMDomain(p.meshfile)
                    else:
                        p.domain = Domain.RectangularDomain(L=p.L[:3],name=p.name)
                else:
                    raise RuntimeError("No support for domains in more than three dimensions")

The file contains also the numerical and physics setup. I just run it with python2 kinetic.py. In the current form I get
[       0] *** Global ***
Number of triangles  : 800
Number of edges : 1240
Number of nodes : 441

*** Local ***
Number of triangles  : 800
Number of edges : 1240
Number of nodes : 441

[       0] Setting up MultilevelTransport for kinetic
[       0] Building Transport for each mesh
[       0] Generating Trial Space
[0]PETSC ERROR: ------------------------------------------------------------------------
[0]PETSC ERROR: Caught signal number 11 SEGV: Segmentation Violation, probably memory access out of range
[0]PETSC ERROR: Try option -start_in_debugger or -on_error_attach_debugger
[0]PETSC ERROR: or see http://www.mcs.anl.gov/petsc/documentation/faq.html#valgrind[0]PETSC ERROR: or try http://valgrind.org on GNU/linux and Apple Mac OS X to find memory corruption errors
[0]PETSC ERROR: configure using --with-debugging=yes, recompile, link, and run
[0]PETSC ERROR: to get more information on the crash.
application called MPI_Abort(MPI_COMM_WORLD, 59) - process 0

If I uncomment p.nd and p.L lines the code will run, even though i believe I am doing exactly the same! Clearly there's something I am missing. Please let me know.

I'm not sure what is going on here.  When you leave  domain=None proteus  is actually just using L (not the offset  x), so the  two domain's aren't equivalent.  I suspect when you switch to your offset domain that it's hitting a problem in your boundary condition setter functions that aren't being triggered by the domain with lower left corner (0,0).

To be clear, the code path where you just set L and x looks like a bug in proteus or at  least something that  should be made consistent with the behavior of RectangularDomain. It seems like a bad idea  for proteus to ignore the offset x.

So let's leave this open, but I'd suggest that you try debugging your new version with RectangularDomain.  You could put a print statement in your boundary condition setters to try to track the values of  x they are being called  on and see if the segv is generated there.

Ok. Thanks. I'll do that for now. I was aware that p.x = (0.0, -4.0) will not do anything, but I left it out to show an alternative way that it could be made consistent with RectangularDomain. I thought about BC but the BC code I've got only accounts for the direction that was not shifted so I dropped that. I'll do some debugging now and see how it goes.

I corrected my BC code. I didn't change anything to the periodic part as I want to have periodicity in x and 0 value for y direction. The problem went away.
def dirichletZeroBC(x, flag):
    a = x[1]
    print "zeroBC: ", x
    if np.abs(a) == 4:
        return 0

p.dirichletConditions = dict((i, dirichletZeroBC) for i in range(2))
p.advectiveFluxBoundaryConditions = dict((i, emptyBC) for i in range(2))
p.diffusiveFluxBoundaryConditions = dict((i, {}) for i in range(2))

def getPBC(x, flag):
    eps = 1.0e-8
    print "periodicBC", x
    if x[0] < eps or x[0] >= p.L[0] - eps:
        return np.array([0.0, 0.0, 0.0])

p.periodicDirichletConditions = dict((i, getPBC) for i in range(2))

This is still not quite correct for my case as the first variable is probably not fixed value, but I need to go back to the theory to verify this. It's irrelevant to this issue. The problem is closed for me. Before my BC code was empty for p.dirichletConditions so perhaps there was something default that was crashing the shifted rectangle.


[FEATURE] Alphabetic sorting of tags in resources filter

Describe your suggested improvement
Alphabetic sorting of tags in resources filter (for easier grouping). Tags with emojis should be at the top of the list.
Describe the benefit
Better navigation and finding of tags.
Would you be capable/willing to implement the improvement?
No, I have other priorities. Happy for someone to give this a stab.
Additional comments
Currently the tags list is determined in the following code:
https://github.com/ClimateTown/knowledge-hub/blob/36f3a98c6255554789733262a83281285fcb7ec2/src/routes/resources/+page.server.ts#L11-L18
Which has no sorting whatsover. Simply implementing a sort function here (adhering to the requirements) would make this work.
Suggested in https://github.com/ClimateTown/knowledge-hub/issues/75#issuecomment-1537774362 (thanks @JarrodBaniqued!)

I can do this one. And I'm guessing within the emojis it should also be sorted alphabetically @VeckoTheGecko?


Join forces

Hello,
I have recently created an Astro integration for PocketBase that also includes a simple loader.  Maybe, it would be interesting to combine our libraries  as it will be easier for users to have one complete solution for PocketBase and Astro. What do you think?

Hi there,
Thanks for reaching out! I actually came across your integration after publishing the loader. I really like the idea of having a full integration and breaking some of the limitations imposed by the Content Collections API.
I'm definitely open to the idea of collaboration, though I’ve been working on a similar integration with a slightly different approach. My idea is to split it into two separate packages: astro-loader-pocketbase and astro-integration-pocketbase, allowing users to choose the one that best fits their needs or use them together.
Here are a few key points I’m focusing on with my implementation:

A toolbar that not only refreshes the content but also includes entity information. That's my current prototype:

Support for server-side rendering, where PocketBase requests happen at runtime rather than during the build process (which differs from the approach of astro-loader-pocketbase). This is a feature I likely need for my own website, not wanting to rebuild for every content change
No build step for the library — just shipping pure TypeScript code like this package.
Keeping external dependencies to a minimum — ideally, the only dependencies will be astro itself and typescript.

I think combining efforts could be a great way to provide a complete solution for PocketBase and Astro users, and I’d love to discuss how we could make this work. Looking forward to hearing your thoughts!

A first alpha of the integration is now available.
You can checkout the repo at https://github.com/pawcoding/astro-integration-pocketbase or try it out using
npm install -D astro-integration-pocketbase

Hi there,
Thanks for reaching out! I actually came across your integration after publishing the loader. I really like the idea of having a full integration and breaking some of the limitations imposed by the Content Collections API.
I'm definitely open to the idea of collaboration, though I’ve been working on a similar integration with a slightly different approach. My idea is to split it into two separate packages: astro-loader-pocketbase and astro-integration-pocketbase, allowing users to choose the one that best fits their needs or use them together.
Here are a few key points I’m focusing on with my implementation:

A toolbar that not only refreshes the content but also includes entity information. That's my current prototype:

Support for server-side rendering, where PocketBase requests happen at runtime rather than during the build process (which differs from the approach of astro-loader-pocketbase). This is a feature I likely need for my own website, not wanting to rebuild for every content change
No build step for the library — just shipping pure TypeScript code like this package.
Keeping external dependencies to a minimum — ideally, the only dependencies will be astro itself and typescript.

I think combining efforts could be a great way to provide a complete solution for PocketBase and Astro users, and I’d love to discuss how we could make this work. Looking forward to hearing your thoughts!

Sorry for the late answer, I didn't have much time lately. Maybe we could talk privately on some platform?

Sure. You can reach out to me on my Discord or just via email.


Parse-server 2.1.7 - request.user returns null/undefined

I have a cloud afterSave/ ... function that is being called by the user from the App, inside the function I call
var currentUser = request.user;
but it returns undefined
On Parse.com I used Parse.User.currrent() which worked perfectly

We have lots of passing test cases that cover these features. Can you post some code that reliably reproduces your issue? Ideally as a test case we can add to our test suite.

in AfterSave
a User comment or like, the record is saved in the collection, afterSaving it, afterSave will read the record and send push notification ... etc, inside the afterSave I call request.user which returns null. the record contains a column called "fromUser" so right now i'm using currentUser = request.object.get("fromUser");

maybe request.user works only on the _User class ?

request.user will only point to a _User object when the function is triggered by an authenticated user.
Can you post some code that demonstrates the issue?
Please refer to this issue for an example of a great bug report.

Hi @hramos please take a look to #775. I wrote the whole code I'm using and still there's an issue


Implement color presentation

Implements two requests - Document Color and Color Presentation, which give you little colored square and color picker for #colorLiterals, similar to the ones in Xcode. Watch out when splitting the color literal into multiple lines, because there's a bug in vscode that will eat your code https://github.com/microsoft/vscode/issues/74622

@swift-ci please test


[Cli tools] Add command line option for configuring the memory limit

Is your enhancement request related to a problem? Please describe.
Cli tools such as pulsar-perf don't contain a way to configure the Pulsar client memory limit.
Describe the solution you'd like
Cli tools should have a way to configure the Pulsar client memory limit.
Additional context
See https://github.com/apache/pulsar/pull/15748#issuecomment-1145013379

Cross-post -
I notice that we do have some utils to implement this future. See https://github.com/apache/pulsar/pull/20646#pullrequestreview-1497799011.
Closing as stale...
But anyone can take over this work as it's clear to follow now.
Originally posted by @tisonkun in https://github.com/apache/pulsar/issues/19434#issuecomment-1606839264

@JooHyukKim Sure. Go ahead :D


Feature/automated claim

Tidy up the environment choice
Add automated claim creation method

Codecov Report

Merging #12 (7ea0cab) into main (67fd5c4) will increase coverage by 1.72%.
The diff coverage is 80.00%.

@@            Coverage Diff             @@
##             main      #12      +/-   ##
==========================================
+ Coverage   86.55%   88.28%   +1.72%
==========================================
  Files           4        4
  Lines         119      128       +9
  Branches       23       25       +2
==========================================
+ Hits          103      113      +10
+ Misses         16       14       -2
- Partials        0        1       +1

Impacted Files
Coverage Δ

src/stkbnb-web-sdk.ts
82.75% <63.63%> (-3.50%)
:arrow_down:

src/eip712-utils.ts
100.00% <100.00%> (+100.00%)
:arrow_up:

src/networkConfig.ts
100.00% <100.00%> (ø)

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more


Float value in point is sent localized

This results in an exception like:
HTTP Code 400 {"error":"unable to parse points"} (Class: InfluxDB\Exception)
Fix in InfluxDB\Point:
`/**
* @param array $fields
*/
public function setFields($fields)
{
foreach ($fields as &$field) {
if (is_integer($field)) {
$field = sprintf('%di', $field);
} elseif (is_string($field)) {
$field = $this->escapeFieldValue($field);
} elseif (is_float($field) || is_double($field)) {
$field = sprintf('%F', $field);
} elseif (is_bool($field)) {
$field = ($field ? "true" : "false");
}
}
    $this->fields = $fields;
}`

can you provide a PR and a test for this fix please?
Thanks as lot

Sorry. I am too busy atm and I am not familiar with your test suites. But should be easy to reproduce (and test) by setting a locale that uses "," as decimal separator.


Update joint architecture and quantization policy search with DyNAS-T example notebook

There were two issues with the example notebook for joint architecture and quantization policy search with DyNAS-T.

Missing csv file with sample results.
CSV filename mismatch between cell that runs the search and the cell that plots results.

Both issues are resolved with this change.

pre-commit CI complains examples/notebook/dynas/ResNet50_Quantiation_Search_Supernet_NAS.ipynb:235: fo ==> of, for, to, do, go. Problem is that line 235 is an encoded PNG image and there is not much that can be done about a typo within the encoding block.

pre-commit CI complains examples/notebook/dynas/ResNet50_Quantiation_Search_Supernet_NAS.ipynb:235: fo ==> of, for, to, do, go. Problem is that line 235 is an encoded PNG image and there is not much that can be done about a typo within the encoding block.

Ok, I will handle it.


single view: markdownify summary

Hi,
The summary is not markdownified, and thus we see the md content on the summary. This fixes that
Thanks!

Nice, thank you for the PR, but you need to update this everywhere, for instance here: layouts/partials/post-entry.html
Please check if this summary is also used elsewhere, and if this modifies in any way the appearance of the pages.

Hi,
For some reason that I can't explain, it works well on this partial...?
Cheres


coqPackages.multinomials: fix

Motivation for this change
New script breaks the current package with a #!/usr/bin/env, moreover
dune should also be used for dev versions.
Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
[ ] Tested execution of all binary files (usually in ./result/bin/)
21.11 Release Notes (or backporting 21.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[x] Fits CONTRIBUTING.md.

@vbgl


Add support of serving HTTP via TLS (a.k.a HTTPs support)

This is a draft version of adding support for serving HTTP traffic via TLS (i.e. HTTPS). If you conceptually agree with this approach, I'll add docs/tests/other necessary things.

@ikruglov LGTM. What we still might want to add is supporting .env instead of config using EVCC_NETWORK_CERTIFICATE_PUBLIC/PRIVATE. This does work if we read the data using Viper. I don't think there's a way to have Viper populate the json.

@andig, I'm not sure I 100% follow you. Do you have an example of what you'd like to see?

E.g.
// setup sponsorship (allow env override)
if token := viper.GetString("sponsortoken"); err == nil && token != "" {
	err = sponsor.ConfigureSponsorship(token)
}

will look into the yaml plus env. Inside the codebase, using conf.xyz only looks at the yaml afaikt. Meaning: if you want to env support for certain properties you need use viper.Get instead of conf.xyz

@andig, I've pushed https://github.com/evcc-io/evcc/pull/5631/commits/bb71352764d54d1a34db753dcd5a4b0b64172722 to implement .env. Please have a look. Is this what you want to see?

Its not quite what I meant. Didn't have time for testing yet. Either merge without env or give me more time.

Hi guys, I just opened another PR https://github.com/evcc-io/evcc/pull/5985 with a similar goal. The main difference is how things are passed and the extra option for mTLS (also know as UserAuth). If this here is going to be merged, I wonder if the mTLS feature could also be added here.

@andig, I still would like to merge this one way or another

See https://github.com/evcc-io/evcc/pull/5985#issuecomment-1430428253


Install APCu stable version

APCu is now shipped on two channels, beta and stable.
The beta version is for PHP 7, the stable version PHP 5.3+.

thanks!


Incorrect config v4

Hello,
Just installed this and was having an issue getting the environment variables for defaultFrom and defaultReplyTo and realized that the config here is wrong. The props need to be under email.config, not email. As such:
module.exports = ({ env }) => ({
  email: {
    config: {
      provider: 'strapi-provider-email-smtp',
      providerOptions: {
        host: 'smtp.gmail.com', //SMTP Host
        port: 465   , //SMTP Port
        secure: true,
        username<EMAIL_ADDRESS>        password: 'my.password',
        rejectUnauthorized: true,
        requireTLS: true,
        connectionTimeout: 1,
      },
      settings: {
        defaultFrom<EMAIL_ADDRESS>        defaultReplyTo<EMAIL_ADDRESS>      },
    },
  },
});

Please add @jiblett1000 's observation to the main docs. I wasted way too much time until I found this
Thanks man :tada::tada::tada:

Thank you!


Appstudio update test-component-pac-nowb

Pipelines as Code configuration proposal

Pipelines as Code CI/test-component-pac-nowb-on-pull-request has successfully validated your commit.

StatusDurationName

✅ Succeeded
9 seconds
init

✅ Succeeded
19 seconds
clone-repository

✅ Succeeded
1 minute
build-container

✅ Succeeded
25 seconds
deprecated-base-image-check

✅ Succeeded
24 seconds
sanity-inspect-image

✅ Succeeded
3 minutes
clair-scan

✅ Succeeded
15 seconds
sbom-json-check

✅ Succeeded
44 seconds
clamav-scan

✅ Succeeded
12 seconds
sanity-optional-label-check

✅ Succeeded
12 seconds
sanity-label-check

✅ Succeeded
10 seconds
show-summary

Pipelines as Code CI/test-component-pac-nowb-on-pull-request has successfully validated your commit.

StatusDurationName

✅ Succeeded
6 seconds
init

✅ Succeeded
15 seconds
clone-repository

✅ Succeeded
23 seconds
build-container

✅ Succeeded
17 seconds
deprecated-base-image-check

✅ Succeeded
15 seconds
sanity-inspect-image

✅ Succeeded
10 seconds
clair-scan

✅ Succeeded
40 seconds
clamav-scan

✅ Succeeded
14 seconds
sbom-json-check

✅ Succeeded
8 seconds
sanity-label-check

✅ Succeeded
7 seconds
sanity-optional-label-check

✅ Succeeded
6 seconds
show-summary

Pipelines as Code CI/test-component-pac-nowb-on-pull-request has successfully validated your commit.

StatusDurationName

✅ Succeeded
6 seconds
init

✅ Succeeded
15 seconds
clone-repository

✅ Succeeded
23 seconds
build-container

✅ Succeeded
17 seconds
deprecated-base-image-check

✅ Succeeded
15 seconds
sanity-inspect-image

✅ Succeeded
40 seconds
clamav-scan

✅ Succeeded
10 seconds
clair-scan

✅ Succeeded
14 seconds
sbom-json-check

✅ Succeeded
7 seconds
sanity-optional-label-check

✅ Succeeded
8 seconds
sanity-label-check

✅ Succeeded
6 seconds
show-summary


Add museum config for Yale Babylonian Collection

 Adapt Fragmentarium to tablets from the Yale Babylonian Collection

 Adapt Fragmentarium to tablets from the Yale Babylonian Collection


[BUG] [Slurm role] munge key

Hi,
The slurm role needs to be launched twice to:

Ansible role: install the munge package,
Generate the key manually,
Ansible role: configure slurm.

It would be more helpful if the ansible role generates the key itself through the command or shell module, allowing to launch the Slurm role only once.
Best regards
EDIT: to avoid an idempotent break on the controller, when should be used to check if the munge key already exists or not.

Dear @remyd1
Yes, you are right about this issue. Natively, munge keys were generated with a dd command, and so didn't need the munge package. I will investigate this, best solution would be to have munge key inside inventory.


System.NotSupportedException encountered on Aspect.Weave in WCF service

I'm not sure if this is an NConcern or CNeptune issue. Since I encounter it when implementing the code from the NConcern ReadMe, I'm opting to post it here.
Based on the readme.md I've created a WCF project with the Tracer and Logging classes exactly as written. I've modified the Calculator service to include implicit joinpoints as shown below:
using NConcern;
using System.ServiceModel;

namespace NConcern_WCF
{
    [ServiceContract]
    public class Calculator
    {
        [OperationContract]
        public int Add(int a, int b)
        {
            int answer = 0;
            Aspect.Weave<Logging>(typeof(OperationContractAttribute));
            answer = a + b;
            Aspect.Release<Logging>(typeof(OperationContractAttribute));
            return answer;
        }
    }
}

I'm hosting the service in Local IIS and testing it using SoapUI. If I disable the joinpoints the service runs correctly. However, when I enable the joinpoints I recieve the following exception on the Aspect.Weave call.
System.NotSupportedException occurred
  HResult=0x80131515
  Message=type 'System.Web.ApplicationServices.AuthenticationService, System.Web.Extensions, Version=<IP_ADDRESS>, Culture=neutral, PublicKeyToken=31bf3856ad364e35' is not managed by CNeptune and cannot be supervised.
  Source=<Cannot evaluate the exception source>
  StackTrace:
<Cannot evaluate the exception stack trace>

Output from SoapUI is
<s:Envelope xmlns:s="http://schemas.xmlsoap.org/soap/envelope/">
   <s:Body>
      <s:Fault>
         <faultcode xmlns:a="http://schemas.microsoft.com/net/2005/12/windowscommunicationfoundation/dispatcher">a:InternalServiceFault</faultcode>
         <faultstring xml:lang="en-US">type 'System.Web.ApplicationServices.AuthenticationService, System.Web.Extensions, Version=<IP_ADDRESS>, Culture=neutral, PublicKeyToken=31bf3856ad364e35' is not managed by CNeptune and cannot be supervised.</faultstring>
         <detail>
            <ExceptionDetail xmlns="http://schemas.datacontract.org/2004/07/System.ServiceModel" xmlns:i="http://www.w3.org/2001/XMLSchema-instance">
               <HelpLink i:nil="true"/>
               <InnerException i:nil="true"/>
               <Message>type 'System.Web.ApplicationServices.AuthenticationService, System.Web.Extensions, Version=<IP_ADDRESS>, Culture=neutral, PublicKeyToken=31bf3856ad364e35' is not managed by CNeptune and cannot be supervised.</Message>
               <StackTrace><![CDATA[at NConcern.Aspect.Directory.Entry.Pointer(MethodBase method)
   at NConcern.Aspect.Directory.Entry..ctor(Type type, MethodBase method, Activity activity)
   at NConcern.Aspect.Directory.Obtain(MethodBase method)
   at NConcern.Aspect.Directory.Add[T](MethodBase method)
   at NConcern.Aspect.Weave[T](Func`2 pattern)
   at NConcern_WCF.Calculator.<Neptune>.<Authentic>.Add(Calculator this, Int32 a, Int32 b) in C:\git\NConcern WCF\NConcern WCF\Calculator.svc.cs:line 13
   at NConcern_WCF.Calculator.Add(Int32 a, Int32 b)
   at SyncInvokeAdd(Object , Object[] , Object[] )
   at System.ServiceModel.Dispatcher.SyncMethodInvoker.Invoke(Object instance, Object[] inputs, Object[]& outputs)
   at System.ServiceModel.Dispatcher.DispatchOperationRuntime.InvokeBegin(MessageRpc& rpc)
   at System.ServiceModel.Dispatcher.ImmutableDispatchRuntime.ProcessMessage5(MessageRpc& rpc)
   at System.ServiceModel.Dispatcher.ImmutableDispatchRuntime.ProcessMessage11(MessageRpc& rpc)
   at System.ServiceModel.Dispatcher.MessageRpc.Process(Boolean isOperationContextSet)]]></StackTrace>
               <Type>System.NotSupportedException</Type>
            </ExceptionDetail>
         </detail>
      </s:Fault>
   </s:Body>
</s:Envelope>

I'm far from as experienced as I want to be in diagnosing and fixing situations like this. I appreciate the help. Thanks!

hi, thank you for sharing, can you try to define manual joinpoint like this and tell me if it change something for you?
Aspect.Weave<Logging>(method => method is MethodInfo && method.DeclaringType == typeof(Calculator));

I implemented the first suggestion you made:
Aspect.Weave<Logging>(method => method is MethodInfo && method.DeclaringType == typeof(Calculator));

and with CNeptune still referenced in the project I get the following error when building:
The command ""C:\git\NConcern WCF\packages\CNeptune.1.1.0\build\CNeptune.exe" "C:\git\NConcern WCF\NConcern WCF\NConcern WCF.csproj" "Debug"" exited with code -532462766.

If I remove CNeptune from the project it builds successfully. However, I receive a very similar exception:
System.NotSupportedException: 'type 'NConcern_WCF.Calculator, NConcern WCF, Version=<IP_ADDRESS>, Culture=neutral, PublicKeyToken=null' is not managed by CNeptune and cannot be supervised.'

I can eliminate exceptions by using code from the example in the solution file from the project:
var _operationContractJoinpoint = new Func<MethodBase, bool>(_Method => _Method.IsDefined(typeof(Calculator), true));
Aspect.Weave<Logging>(_operationContractJoinpoint);
...
Aspect.Release<Logging>(_operationContractJoinpoint);

Unfortunately, weaving never occurs. No breakpoints in the Tracer or Logging classes are reached and no logging output is seen. Adding or removing CNeptune as a project reference doesn't change behavior.

Hi, you got the good scenario when CNeptune failed to rewrite IL when building. Indeed, there is a bug in CNeptune that I fixed but not release. Please refer to this post for more details :
https://github.com/Virtuoze/CNeptune/issues/9#

CNeptune has been patched : the bug is now fixed in version 1.2.0
https://www.nuget.org/packages/CNeptune
Unfortunately during test, I found a performance issue on startup because NConcern try to locate pointcut in all framework that take long time... I have to patch NConcern to ignore Framework Assemblies.

Experiencing the same error. Is not yet fixed ?

Do you use NConcern 4.1.0 & CNeptune 1.2.1 ? (latest versions)

I use NConcern 4.1.0. Do I also need to install/reference CNeptune ?

CNeptune must be installed on assembly you want to inject. NConcern is an API to control how to inject. In some can Injector and injected are not the same project, but sometimes it is the case.

With CNeptune, it works.  Thanks.

System.NotSupportedException:
NConcern:4.1.0&&CNeptune:1.2.1; Aspect.Weave(TranCtrl.Condition);
gitUrl:https://github.com/songle321/WCFTest.git


test: use node 18 test runner for integration tests

Codecov Report

Merging #9 (815220d) into main (4d2a70d) will decrease coverage by 10.09%.
The diff coverage is 38.88%.

@@             Coverage Diff              @@
##              main       #9       +/-   ##
============================================
- Coverage   100.00%   89.90%   -10.10%
============================================
  Files            7        6        -1
  Lines          108      109        +1
  Branches        29       30        +1
============================================
- Hits           108       98       -10
- Misses           0       11       +11

Flag
Coverage Δ

unittests
89.90% <38.88%> (-10.10%)
:arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files
Coverage Δ

src/index.ts
31.25% <26.66%> (-68.75%)
:arrow_down:

src/help.ts
100.00% <100.00%> (ø)

:mega: Codecov can now indicate which changes are the most critical in Pull Requests. Learn more


CI: Add unit tests for loss validator

I'm not sure whether it's doable through Github Action since we need to test with GPU.
But it's good to at least of some tests that core team can run locally to verify whether it works or not.
If you want to take this issue, please comment below to get assigned.

Github did recently start supporting GPU hosted runners.


Add proper indentation to extra CoreDNS config

When using more than one line of extra config, the indentation was not right and generated YAML was not valid
This should fix this issue

Codecov Report

Merging #1815 into v0.15.x will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff            @@
##           v0.15.x    #1815   +/-   ##
========================================
  Coverage    24.53%   24.53%
========================================
  Files           98       98
  Lines         5083     5083
========================================
  Hits          1247     1247
  Misses        3696     3696
  Partials       140      140

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7508322...06577dc. Read the comment docs.


Precede changefeed tutorials and examples with changefeed privilege note

Fixes DOC-10247
Added a short sentence before examples and tutorials begin to remind users to check they have the CHANGEFEED privilege before running through the steps.

TFTRs!


Proposal: support idempotency token for create silence api

Problem
We can not retry on Post silence api from client side because every put silence will generate an UUID. Ideally we should allow an idempotency token in create silence api so that an retry with the same idempotency token can be ignored
Proposed solution
API
We will accept an optional parameter for idempotency token, the behavior will remain unchanged if no idempotency token is provided
Supporting of idempotency token
Instead generating a unique uuid for every new request with a  idempotency token here: https://github.com/prometheus/alertmanager/blob/f59460bfd4bf883ca66f4391e7094c0c1794d158/silence/silence.go#L579
We could generate an UUID based on the silence payload+idempotency token so that we make sure that same silence ID will be generated for the same idempotency+payload request.
idempotency token bahavior

If client called with an called idempotency token with the same payload
-> The silence will be created with the exact same silence id and return to client

If client called with an called idempotency token with the different payload
-> The silence will be created with different silence id and return to client

i think so


Add an optimization to remove no-op queries

Add a feature to the translator to remove no-op queries from the output ELM. For example:
define "Current Diagnosis Atrial FibrillationFlutter":
  "Encounter with Principle Diagnosis of Ischemic Stroke" NonElectiveEncounter
    where NonElectiveEncounter.diagnosis in "Atrial Fibrillation/Flutter" CurrentAtrialFibrillationFlutter

Note the trailing alias CurrentAtrialFibrillationFlutter. Since the query has no additional clauses, the result of the query is the same as the result of the primary source "Atrial Fibrillation/Flutter". Although this is conceptually valid, there are downstream consequences in this case in that the ELM outputs with an In instead of an InValueSet because the translator doesn't detect that the right operand to the in is a reference to a value set.
This optimization would correct that issue, but would also be a general enhancement to the resulting ELM, simplifying where possible.
Note that when the optimization is not performed, the translator should issue a warning that a no-op query was encountered and that could result in potential implementation difficulty.

We should investigate the impact on annotations, in that there would be a more significant mismatch between the source CQL and the ELM.  For example, would it make sense to still tie the annotation for the now-optimized element to the full original source in the CQL?

Agreed, my thinking here was that when an optimization removes a node, it replaces the source references in the remaining node with the source references in the removed node. This should result in the rewrite referencing the full source CQL.


Update Root Readme Status Badge

Central public build no longer exists, I'm just basing this off the core pipeline.

Can one of the admins verify this patch?


System packages leak into build environment

PEP 517 recommends that the build environment should only contain the standard library and packages from build-system.requires.  However, system packages are exposed to the build environment using pep517.  This behaviour has been implicated in https://github.com/jaraco/skeleton/pull/12.
For an MRE:
$ python -m pip list
Package Version
------- -------
pep517  0.8.1
pip     20.0.1
toml    0.10.0
$ cat pyproject.toml
[build-system]
requires = ["setuptools"]
build-backend = "setuptools.build_meta"
$ cat setup.py
import toml   # Does not raise

from setuptools import setup

setup(name='test')
$ python -m pep517.build --source .
running egg_info
creating test.egg-info
writing test.egg-info/PKG-INFO
writing dependency_links to test.egg-info/dependency_links.txt
writing top-level names to test.egg-info/top_level.txt
writing manifest file 'test.egg-info/SOURCES.txt'
reading manifest file 'test.egg-info/SOURCES.txt'
writing manifest file 'test.egg-info/SOURCES.txt'
running sdist
running egg_info
writing test.egg-info/PKG-INFO
writing dependency_links to test.egg-info/dependency_links.txt
writing top-level names to test.egg-info/top_level.txt
reading manifest file 'test.egg-info/SOURCES.txt'
writing manifest file 'test.egg-info/SOURCES.txt'
warning: sdist: standard file not found: should have one of README, README.rst, README.txt, README.md

running check
warning: check: missing required meta-data: url

warning: check: missing meta-data: either (author and author_email) or (maintainer and maintainer_email) must be supplied

creating test-0.0.0
creating test-0.0.0/test.egg-info
copying files to test-0.0.0...
copying pyproject.toml -> test-0.0.0
copying setup.py -> test-0.0.0
copying test.egg-info/PKG-INFO -> test-0.0.0/test.egg-info
copying test.egg-info/SOURCES.txt -> test-0.0.0/test.egg-info
copying test.egg-info/dependency_links.txt -> test-0.0.0/test.egg-info
copying test.egg-info/top_level.txt -> test-0.0.0/test.egg-info
Writing test-0.0.0/setup.cfg
Creating tar archive
removing 'test-0.0.0' (and everything under it)

IMHO: isolation is unneeded. IMHO the mindset "let's use old rotten versions of everything in order to make sure nothing has been broken by changes in dependencies" is inherently harmful. It bloats the system, wastes memory and traffic, postpones the solution of the real issues, wasting time, and prevents latest fixes and features from being used. If you cannot fix your code, once the behavior breaking your project is standardized and documented and people rely on it, the only choices you have is to say "we require all users of our software to stay on old versions for ever or use our fork", which, of course, is usually inacceptible, when maintainers of the dependency are not mad or evil, or we stop our project, it is makes no sense to continue its development since the dependencies got incompatible.
The better mindset is "let's use bleeding edge stuff, and if something we need breaks, we will immediately know about it and have some time to react".
At least there must be a pref in a config disab

This issue is about pep517 exposing libraries which are not available when building from an sdist with pip using build isolation which can become the source of latent bugs downstream.  This is the wrong place to appeal against build isolation.

We've come to an agreement that the functionality to create isolated build environments and install build dependencies will live in the PyPA build project. The pep517 library will continue to exist as the lower-level piece to work with the interfaces defined by PEP 517, but the pep517.envbuild module and the little command-line interfaces which use it (pep517.build, pep517.check and pep517.meta) will gradually be deprecated and eventually removed as build becomes more stable. See #91 for more on that process.
So I'm closing this, as there won't be any further significant work here on isolating the build environment. Hopefully build already meets your needs better.


Error Statistic

Hello,
I joined Puzzle 69 pool, running 4 hours straight but my account statistic still 0 scanned.
Also theres showing 0 active worker.
My btcpuzzle account is henzcorp.
How to fix it? Can you check it, please?
Thanks!

Hello, please send your "username" and "settings file". You can use Telegram or<EMAIL_ADDRESS>I will check it. Thanks.


(maint) Change spec test to use simplest assertion

Changes to minitest 5.9 broke a single test that used assert_equal to
generate a minitest assertion; this change uses the simplest assertion
possible, so changes to minitest are less likely to break a spec test.

Refer to this link for build results (access rights to CI server needed):
http://jenkins-beaker.delivery.puppetlabs.net//job/qe_beaker_btc-intn/2501/

I'm confident the update shouldn't effect the CI results, so I'm down with this. 👍

Refer to this link for build results (access rights to CI server needed):
http://jenkins-beaker.delivery.puppetlabs.net//job/qe_beaker_btc-intn/2502/


Added "Little Fears Nightmare Edition" character sheet

Your sheet needs a CSS file, a sheet.json file, and a preview image to be a valid sheet. Please update your submission and open new Pull Request.


fix: reuse method to get driver options

Coverage: 84.821% (+3.8%) from 81.066% when pulling 21080cc23e0d17b23b6493974cd77e2f6775dc3f on fix/reuse_driver_options_method into d958e91b1f2f98e4f795515f88aa41606aa3b81a on master.


Doesnt work

Hi, the script gave me error proxies.txt file doesnt exist. So i made it and put the proxy in it.
Now, it doesnt do anything at all.
Error:
ValueError: Unknown scheme for proxy URL URL('geo.iproyal.com:REDACTED:CENSORED:CENSORED')

i’ve just updated the git. Redownload the latest version of the repository and put your iproyal proxy in config.json

i’ve just updated the git. Redownload the latest version of the repository and put your iproyal proxy in config.json

Hello, same error :(

contact me on discord @ Acier#8770 and I can further assist you

okay, please accept that request


go vet error message

code.google.com/p/go-uuid/uuid/uuid.go:116: unreachable code
code.google.com/p/go-uuid/uuid/uuid_test.go:319: no formatting directive in
Errorf call
code.google.com/p/go-uuid/uuid/uuid_test.go:328: no formatting directive in
Errorf call
code.google.com/p/go-uuid/uuid/uuid_test.go:331: no formatting directive in
Errorf call

What is the expected output? What do you see instead?

What version of the product are you using? On what operating system?

Please provide any additional information below.

Original issue reported on code.google.com by tailinchu on 27 Dec 2014 at 2:01

this is fixed in https://github.com/pborman/uuid/pull/14
Let's merge!

Thanks!
As part of improving the tests for node.go I incorporated your changes.  go vet no longer complains.


Crash after adding this mod in my 1.20.1 modpack

Basically, i'm having this crash after trying to add SeasonHUD (and ForgeConfigApiPort 8.0.0) to my modpack.
MC: 1.20.1
Fabric Loader: 0.15.6
Fabric API: 0.91.0

Update to the latest version of MapAtlases and it should fix it. It looks like it's only available on CurseForge, and not Modrinth.

I think the person who handles the Forge port took over the project and is updating it going forward. If you want to still use the 2.6.0, then version 1.7.6 of my mod should work, as I updated to supporting the new MapAtlases changes in 1.7.7


Centralize Onyx subscriptions in ReportScreen

Details
This PR should improve report switching time a bit since withOnyx() HOCs are fairly expensive to initialize and we can reduce the number of keys we subscribe to by passing some props to the ReportScreen children instead of creating duplicate subscriptions.
Fixed Issues
Not really related to any particular issue - we are trying to improve chat switch metrics and there's a tracking issue here:
https://github.com/Expensify/App/issues/4022
Tests

QA Steps

Tested On

[x] Web
[ ] Mobile Web
[ ] Desktop
[ ] iOS
[x] Android

Screenshots

Web

Mobile Web

Desktop

iOS

Android

:hand: This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

🚀 Deployed to staging by @marcaaron in version: 1.0.85-10 🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
success ✅

🕸 web 🕸
success ✅


feat: replace report view tests

Summary of changes

replace report view int by E2E tests

Context and reason for change
Closes #2256
How can the changes be tested
Run locally and see CI/CD.

looks good. However, the tests are a bit flaky regarding execution time and sometimes exceed a time out of 30 seconds (if I run all of them with "yarn test:e2e")

that's not good. i've seen very little (almost no) flakiness in the pipeline up to this point. could it be because of your own hardware? definitely something to keep an eye on. perhaps next time this happens you can send me the trace.


Suggestion for an offset function

In order to speed up the pagination of query results, it would be helpful to have a function which offsets the cursors start position by a defined value.
Proposed function signature:
Cursor::setOffset(size_t offset)
Let's look at an example like the table below, if one uses find() without filters the complete table gets returned.
Table: Test:
ID 	Name
1 	Max
2 	Marc
3 	Michi
But if the offset is set to 1 the results will look like this.
cursor.setOffset(1)
ID 	Name
2 	Marc
3 	Michi
Are there better solutions to this Problem lets discuss it in the comments.

Hi Falcon,
This will only be of benefit if you are searching with an empty query. Generally, it is best practice to query the data by an indexed field. In this case, you have an ID column that could be indexed and searched. Functionally & performance wise, this will give you a similar result. Something like
find('{ID: {$gt: 1}}');

Cheers, Sam

I tried the same approach you have described but with the _id, and I always got the error “Unknown exception caught during find query”. Please have a look at my code below:
cursor = db.getCollection(tableName).find('{_id: {$gt:' + startIndex + '}}')

Hmm, that shouldn't throw that error. It must be a bug. I'll look into it.

I found & fixed the bug that caused this error. However I also realised you cannot use the _id field with a $gt query because $gt/$lt only work with numeric values and the _id field is actually a string. You should use another field for this.
One approach might be to keep a numeric value in the key store that represents an index and increment it every time a document is added to the collection.


Flink Delta Source PR_6 - Package Refactoring

Extract Table Processors, Table Monitor and Snapshot Suppliers to their own packages under enumerator package.
PR Plan:
PR 5 - Option support in Bounded Mode
PR 6 - Continuous mode without monitoring for changes
PR 6.1 - Package Refactoring
PR 7 - Monitoring for changes in Continuous mode
PR 8 - Partition Support
PR 9 - Builder
TODOs and other improvements planed as next:
Use index for keeping track of already processed paths in SnapshotProcessor - needs new Delta API.
Do do not create snapshot when streaming only changes (startingVersion or startingTimestamp option used). - needs new Delta API since for startingTimestamp we still need to create a snapshot. There is no API like deltaLog.getChangesFromTimestamp(....)
Refactor Test util classes to make them common for sink and source.

Moved to delta.io


Support parallel builds

When log4j-changelog-maven-plugin is used with a concurrency >1, Maven displays the following warning:
[WARNING] *****************************************************************
[WARNING] * Your build is requesting parallel execution, but this         *
[WARNING] * project contains the following plugin(s) that have goals not  *
[WARNING] * marked as thread-safe to support parallel execution.          *
[WARNING] * While this /may/ work fine, please look for plugin updates    *
[WARNING] * and/or request plugins be made thread-safe.                   *
[WARNING] * If reporting an issue, report it against the plugin in        *
[WARNING] * question, not against Apache Maven.                           *
[WARNING] *****************************************************************
[WARNING] The following plugins are not marked as thread-safe in Apache Log4j Kotlin API Parent:
[WARNING]   org.apache.logging.log4j:log4j-changelog-maven-plugin:0.4.0
[WARNING]
[WARNING] Enable debug to see precisely which goals are not marked as thread-safe.
[WARNING] *****************************************************************

Fixed in 7c8ec0d6747465a82ce1d286cdb3e57f3f50d977.


⚠ Bofrost.lu has degraded performance

In 6ddbfb4, Bofrost.lu (https://www.bofrost.lu) experienced degraded performance:

HTTP code: 200
Response time: 1221 ms

Resolved: Bofrost.lu performance has improved in 08b4222 after 1 hour, 34 minutes.


increased font size

Headings and text of the banners should be left aligned.
Vertical space between heading and text should be same as between text and button.
Entire content of banner should be vertically centered.

Todo:

[ ] Restyle banners to be in the form of three columns (on desktop), which is more readable than horizontal banners.
[ ] Headings and text of the banners should be left aligned.
[ ] Vertical space between heading and text should be same as between text and button.
[ ] Entire content of banner should be vertically centered.
[ ] Reduce vertical space between banners

New PR: #308

Will close this since theres a new PR for it


Na_1stOrder_splineContinuum

Traceback (most recent call last):
File "C:\Users\user\edibles\examples\Na_1stOrder_SplineContinuum.py", line 36, in
cont.add_to_csv(
File "C:\Users\user\edibles\edibles\continuum.py", line 263, in add_to_csv
csv_file = self.Spectrum.filename.replace(".fits", ".csv").replace(
TypeError: Path.replace() takes 2 positional arguments but 3 were given

Description

Expected behavior

Actual behavior

Steps to Reproduce

[First Step]
[Second Step]
[and so on...]

# Put your Python code snippet here.

System Details

replace method was used on pathlib.Path
Fixed it


Tokenize uml_escape tests are failing

Tests for tokenize.util.xml_escape are currently failing, see Jenkins CI test.

@alvations – would you please look into this?

@alvations – looks like we still have this error on the CI server

Thanks @alvations


How do I subscribe to only changes

I am trying to subscribe to changes only and not when initially subscribed.  How can I not have the stage changed triggered when initially subscribed?
Thanks for your help!

store.stateChanged.pipe(skip(1)).subscribe(...)

That looks like a viable option. Have you tried the stateWithPropertyChanges option? Not sure if it'd help in your case but it scopes the changes more.
https://github.com/DanWahlin/Observable-Store#store-api
If what you mention above gets the job done for you we'll close out the issue though.

Thanks guys!


CHSC6X driver

Added a driver for the CHSC6X chip used on the Seeed Studio Round Display for Xiao

Hi, I opened this PR in order to add the driver for the touch controller on the Seeed Studio Round display ( https://wiki.seeedstudio.com/get_start_round_display/ ), but my final goal is to add the display as a shield in Zephyr.
Should I wait for this PR to be merged and then open another one where I add the shield, or can I add the shield in this one ?

Hi, I opened this PR in order to add the driver for the touch controller on the Seeed Studio Round display ( https://wiki.seeedstudio.com/get_start_round_display/ ), but my final goal is to add the display as a shield in Zephyr. Should I wait for this PR to be merged and then open another one where I add the shield, or can I add the shield in this one ? Thanks!

Separate PR is ideal, you can either wait or open the shield one already and just point out that this has to go in first.

@nicogou you have few compliance errors and a missing copyright line, you can also run compliance locally with ./scripts/ci/check_compliance.py

@nicogou you have few compliance errors and a missing copyright line, you can also run compliance locally with ./scripts/ci/check_compliance.py

I made some changes that should resolve these.
I'll open a separate PR for the shield when I'm ready.

@fabiobaltieri Changes made, tested and pushed

Made the requested changes

You might not have pushed them, though :)

Made the requested changes

You might not have pushed them correctly, though :)

Indeed, just redid it, sorry


Reverting to specific version of google cordova maps

Before asking your question, problem or request , please read this page
https://github.com/mapsplugin/cordova-plugin-googlemaps-doc/blob/master/articles/before_post_your_issue/README.md
(Optional) If you are Japanese, you can make an issue written in Japanese. Otherwise, in English please.

What is your question, problem or request?
How can we revert to earlier version 2 commit? I have noticed app is hanging and ionic is not working with latest plugin. I wanted to make sure that is the root cause hence wanted to revert back the version.

What version of this plugin do you use? Please including miner version ($> cordova plugin list)
The one released 5-10 mins back :)

Screen capture or video record?
(you can upload your files with drag & drop)

Code, Data or Error log (please format your code or data)

(here)

I am using multiple_branch of version 2 beta plugin.

Sorry, the wrong code was mixed in to the 2.0.0-beta2-20170720-1741.
I fixed the pluginMarker.m so you can use it.
The ionic wrapper code will be released tonight.
https://github.com/ionic-team/ionic-native/pull/1815#issuecomment-316874855
If you want to revert the plugin code, you can install from git commit id.
Find the version you want to use, from the commit history.
https://github.com/mapsplugin/cordova-plugin-googlemaps/commits/multiple_maps
Then install it.
For example, 2.0.0-beta2-20170720-1431 is
https://github.com/mapsplugin/cordova-plugin-googlemaps/commit/16502e15159fa506d37c9c426a54f4bd977e9873
$> cordova plugin add https://github.com/mapsplugin/cordova-plugin-googlemaps#16502e15159fa506d37c9c426a54f4bd977e9873

There seems to be some issue with the latest plugin. I will try again with the ionic latest release but if I revert to somewhere version around 2.0.0-beta2-20170717-xxx it works.
If I switch to latest version app becomes unresponsive to clicks and ionic stops working

I fixed the click issue yesterday. The plugin should comply the DOM hierarchy completely.
So please double check the DOM hierarchy of your app.
If the hierarchy is correct, please share your project (full) files on github or bitbucket.
I will try to reproduce your issue, and fix it.
(As I said before, you can create a free private repository at BitBucket)
Even though if you can not share the files, please create a project that reproduce the issue 100%.

I can share the private repository with you. Please let me know on which I need to provide access.

Please create a private repo at BitBucket (https://bitbucket.org/).
Github is not free.
Then please invite me to the repository, and let me know the repository name.

I already have my repo at bitbucket. shall I send invite on username: wf9a5m75?

yep

Let me just confirm. Did you send me the invitation? Or will you send it tomorrow?

I am just confirming this on both versions again as you said about HTML part. Once done I will share the repo so you can cross check tomorrow. Apologies for not informing earlier.

I am closing this in favor of latest ionic google maps and latest Cordova google maps version 2 as things seems they are working fine.


Adding memory usage

This builds on #16, so once that's reviewed and merged I'll rebase this so it's easier to review.
We can now show memory usage statistics as well as run time statistics
in our CSV reports!

Coverage remained the same at 100.0% when pulling fd93adabf27211f6d230270ebd7825145ff9c04f on adding-memory-usage into 9ed03e86ac2183be65b4a06c6eb84c651e15db16 on master.


Constraint issue with alert actionsheet.

Error
Make a symbolic breakpoint at UIViewAlertForUnsatisfiableConstraints to catch this in the debugger.
The methods in the UIConstraintBasedLayoutDebugging category on UIView listed in <UIKitCore/UIView.h> may also be helpful.
2020-04-23 15:21:48.556790-0600 Banky[71185:1795813] [LayoutConstraints] Unable to simultaneously satisfy constraints.
	Probably at least one of the constraints in the following list is one you don't want.
	Try this:
		(1) look at each constraint and try to figure out which you don't expect;
		(2) find the code that added the unwanted constraint or constraints and fix it.
(
    "<NSLayoutConstraint:0x6000032b6080 UIView:0x7fb0ba45f9e0.width == - 16   (active)>"
)

Will attempt to recover by breaking constraint
<NSLayoutConstraint:0x6000032b6080 UIView:0x7fb0ba45f9e0.width == - 16   (active)>

This is what I'm calling and the above warning occurs.
        ALRT.create(.actionSheet)
            .addAction("Terms of Use") { _, _ in
                self.performSegue(withIdentifier: "termsToWebView", sender: nil)
            }
        .addAction("Privacy Policy") { _, _ in
            self.performSegue(withIdentifier: "privacyToWebView", sender: nil)
        }
        .addCancel()
        .show()

I believe this is an iOS bug. It occurs when you construct UIAlertController in a standard manner.
https://stackoverflow.com/questions/55372093/uialertcontrollers-actionsheet-gives-constraint-error-on-ios-12-2-12-3

Closing


Add tech stack to requirements page

If your client is flexible, you must indicate a clear rationale of the choice made. This means an extra page with a table of at least 3 options and document all pros and cons for each before letting your client make a choice.
List tech stack technologies relating to:

Server
Libraries
Programming Languages
Plugins

I've transposed the readme dependencies to the requirements tech stack. As can be seen here:
https://github.com/BCCF-UBCO-AD/Orthanc-TMI/blob/9d989ebb0a05cd60a3dfbdd98e361c5d7d95d80b/docs/requirements.md?plain=1#L25-L44


prefix function

Fixes #751
Since SvelteKit 1.0.0-next.573, we are not allowed to export non-Kit functions from +page.js, or it has to start with "_".
To help everyone out, please make sure your PR does the following:

[x] Update the first line to point to the ticket that this PR fixes
[x] Add a message that clearly describes the fix
[x] If applicable, add a test that would fail without this fix
[x] Make sure the unit and integration tests pass locally with pnpm run tests and cd integration && pnpm run tests
[x] Includes a changeset if your fix affects the user with pnpm changeset

Just a quick comment. Wouldn't this effect #597?
Having the type without the _ prefix prevents the collision.

Just a quick comment. Wouldn't this effect/fix #597?
Having the type without the _ prefix prevents the collision.

Yes, you are right. We will have no more collisions with this fix.
You will be able to do:
import { FooVariables } from '$houdini'

export const _FooVariables: FooVariables = () => { ...}

Just FYI, I will probably continue to use:
import { FooVariables as V } from '$houdini'

export const _FooVariables: V = () => { ...}

To have as less "FooVariables" as possible, but I guess that it's only a preference


Cleanup and fixes for Publisher module

Avoid hardcoding the govuk_management_access security group ID; fetch it by name in the root module and pass it down.
Move a security group rule for the Publisher ALB from the publisher module into modules/govuk along with all the other security group rules (missed from #27).
Some minor cleanup of the ALB config for Publisher (details in the commit message) and factor out the domain name.

This introduces a new top-level var public_lb_domain_name which looks a bit like a duplicate of govuk_app_domain_external as it's currently set to the same thing (test.govuk.digital) but I think we'll soon need the ability to vary them separately - see the 0f6951d commit message for more details.
Trello card
Tested: terraform apply works and produces expected output.
Tips for reviewing
This is probably best reviewed commit-by-commit rather than looking at the overall diff, because the mandatory terraform fmt makes it hard to see what's going on otherwise.
Please check that my var descriptions are accurate and sufficiently clear.

Thanks for the review.

1. `terraform fmt` should have been applied on the separate commits.

I agree in general that each commit should pass lint checks in its own right. There's an overriding practical problem in the case of Terraform though, in that terraform fmt makes all the = signs line up, which makes it very hard to see what's actually changing and what's just being reformatted because there happens to be a new arg which is longer than the others. This PR is a particularly severe example of that, so I intentionally left the autoformatting as a separate commit - as a kindness to the reviewer!
In some previous PRs where the problem hasn't been so severe I've squashed the terraform fmt.

I would have started by saying that in normal circumstances, the app needs to know about *.publishing.service.gov.uk but this is managed by another repo govuk-dns-config. This repo manages *test.govuk.digital and are allocated to resources in this repo. Hence why the 2 variables/domains.

I think the key thing is that they're semantically different, regardless of whether they're defined in this repo or a different one. Thanks for the feedback about it being unclear though - I've reworded the explanation to be a bit more specific.

The description in the PR provides more detail than in commit no.3.

Fair point - fixed!


Implement loading spinner, improve UX for slow internet connection

Description of changes:
For testing, I've been using Chrome's network throttler. I tested these changes in all modern browsers.

Implement srcset preloading.
Implement loading spinner, use react-spinners BounceLoader by default.
Implement new properties: spinner, spinnerColor, spinnerSize for spinner customization.
Improve UX for slow internet connection: show spinner, fade-in animation for loaded image.
Refactor code of Lightbox by moving rendering code to renderers.
Update examples with new spinner properties customizations.
Add documentation about new spinner properties to README.md.

Related issues (if any):
https://github.com/jossmac/react-images/issues/93
Checks:

[x] Please confirm npm run lint ran successfully
[x] Please confirm that only /src and /examples/src are committed
[x] [if new feature] Please confirm that documentation was added to the README.md

Screenshots:

I'm still working on improving UX. Currently there is a blink of spinner when the connection is fast. Very annoying. After fixing it, I think this PR is good to go, unless you find any other issues with it.

Now this is a lot better. It's ready for review and QA.

This is awesome! Thanks @mkalygin 🎉


exclude_lines block exclude does not work correctly with new line def

Describe the bug
I want to exclude complete functions with the exclude_lines config parameter. The documentation says this works if i just add "def xyz". This only works if the def definition ends in the same line.
To Reproduce
Have "def asyncio" in your [report] exclude_lines
This will work:
async def asyncio(*,client: Client,) -> Optional[Union[Any, List[GltfFile]]]:
    return (
        await asyncio_detailed(
            client=client,
        )
    ).parsed

This will not work:
async def asyncio(
    *,
    client: Client,
) -> Optional[Union[Any, List[GltfFile]]]:
    return (
        await asyncio_detailed(
            client=client,
        )
    ).parsed

Expected behavior
Both versions will exclude the complete function.

This is a duplicate of #684.


fix: adapt to ruamel.yaml new yaml_set_ctag API

ruamel.yaml has changed its yaml_set_tag method to yaml_set_ctag which expects a Tag object.
With this patch, hyperpyyaml should be compatible with ruamel.yaml versions > 0.17.29.
Fixes #22

LGTM!


Adding tags changed wrong record

Tom Ventimiglia reported a problem edting records in DPUL:
There is one Bib record with two Figgy objects.  The Bib record has two ARKs, and the Figgy objects each have the correct ARK in their local identifier property.  In DPUL, the records were in different collections (one including fulltext items, the other including tables of contents).  Editing one record wound up making the other record show up in the other DPUL collection.
Maybe DPUL is not respecting the local identifier property, and so is using the wrong ARK for one of the records?

Bib record: https://catalog.princeton.edu/catalog/7078205
Figgy:

Fulltext object: https://figgy.princeton.edu/catalog/1a768d6d-4b82-45fb-85cd-50cba358b4d9
TOC object: https://figgy.princeton.edu/catalog/0f282e1e-58ce-47f0-b647-edca822ac532

DPUL:

Fulltext object: https://dpul.princeton.edu/catalog/np193b460
TOC object: https://dpul.princeton.edu/catalog/8623j234x


Feature decollinearizer

FYI: branch is not ready for review yet, turning this into a draft PR in order to allow commenting on code.

Checklist

[ ] Added a CHANGELOG.rst entry

Check if a mode appears superior to the other (likely gram for k << n) and focus on perfecting this one. For this, benchmarks on artificial or real data would be very helpful.

Agreed, I'll create some benchmarks. My hunch is that there might be a time-memory trade-off here. For data that is already one-hot encoded, the direct method might be faster, while for datasets with many categorical columns, the gram-matrix-based method avoids blowing up the size of the data. I agree that the numpy-gram combination probably does not make much sense and probably should be removed (let's wait for benchmarks, though).

Current state as of b25fc72:

Everything is based on the X'X matrix, even in the dense input case. It turns out that doing it is both faster and more memory-efficient than calculating the QR decomposition of X directly.
The intercept is never dropped. This is consistent with the behavior of other statistical packages I've used.

Still a lot to do:

Major decisions

Should it be a transformer?
Should it be in glum?
Should we have a convenience function that combines decollinearization (probably the first use of this word ever) and estimation?
See if the choice of dropped columns has some pattern, and if it is similar to other packaegs.

Additional checks and stuff

Check things about pd.DataFrame before converting to tabmat matrix (like in _glm.py)
More checks in general? (finite values, non-zero rows/columns, etc.)
Fix some type signatures (e.g. ArrayLike is too general)
is _safe_sandwich_dot a private function in _utils?

Testing

Unit test on real data (french auto insurance)
Refactor unit tests as there is a huge amount of duplicated code
Unit tests on larger matrices
Unit tests on csc matrices
Unit test for same results with use_tabmat=True and use_tabmat=True

Quick performance update. On the French auto insurance dataset (678k observations, 1939 columns when one-hot-encoded) the current implementation finds fits the decollinearizer in under a second. transform is even quicker. Correctness is yet to be tested, though.

I'll close it as per our discussion: it does not really belong in glum


Consider allowing template literals as a default

Ref: https://ponyfoo.com/articles/template-literals-strictly-better-strings
Right now, if you use a template literal without interpolation, it's an error.

Thanks for the suggestion. That's an interesting blog post.
Whenever there are multiple ways of doing something in JS, standard usually enforces only one way to prevent style arguments. Allowing either backtick (`) or single quote (') for strings would be a step back.
So, what about making backticks (`) the default over single quotes (')? That's hugely disruptive and don't see it ever happening. But before that could even be considered, ES6 would need to be so widely adopted that there's no need for a transpiler in 95% of browsers. Because we can't add a rule that effectively mandates that people use babel in their codebases.
Hope this makes sense! I'm going to close this, but feel free to continue discussion.

I love the idea,  but you're right,  its just not practical.   Maybe standard@15


CC 2017

Hi Davide,
for Photoshop CC 2017 I added  the line "18": ["HTML_PANEL", "SCRIPT", "MAC_PLUGIN", "WIN_PLUGIN", "EXTRA"]
I'm getting the following error:
Unable to create folder /Applications/Adobe%20Photoshop%20CC%202017/Presets/Scripts/pixelsucht.net (I/O-Fehler)
After creating the folder manually I receive the next error:
Unable to create folder /Applications/Adobe%20Photoshop%20CC%202017/Plug-Ins/pixelsucht.net (I/O-Fehler)
It works if I also create this folder manually. But for end users this is not very comfortable. It would be great if you can take a look on it.
Thomas

Hi Thomas,
From time to time I receive permission errors – some people seems to have them, some don't, it's really puzzling. On Windows, this is usually solved running PS as Admin, but there isn't such a thing on Mac (sudo open??)

Btw: I'm on a Mac (OSX El Capitan 10.11.4). On CC 2015.5 everything works fine.

It will work if I change the permissions for "admin" to "Read and write" for the parent folders.

Thanks @tomzag, your fix worked for me. I didn't have any issues with file permissions.


[Task] Fix playground router to be able to start without Default PG Examples

What needs to happen
When PG datastore has ToB examples but not PG default examples, the router component fails to start with panic "no examples" error. Need to fix this.
###Priority
P3

This got added to the 2.44 milestone via close/reopen and is not a real release blocker


"color" ? doesnt change color

hi dabbling in vcs maker again. what does setting color do to player 0? Also is there a way to go to another level/screen? Thanks!

It should be working, but, for some reason, it isn't...

ah no problem###  my game doesnt really need color just wondering... to get different levels i download/generate a rom per "scene" change the background and generate a "level2" rom etc is how i make multiple levels! thanks

Yes, there are blocks planned for that, but they aren't implemented, yet:

#21 would add blocks for resetting, increasing and decreasing the score;
#16 would modify the background editor to allow having multiple backgrounds and add a block to select the background to use.

It also looks like #11 also mentions the current bug.


Trigger Flow requires a Premium Flow license

It would be good to note in the Trigger Flow section that the Flow will require a premium license since it is required to use the HTTP trigger.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 68267476-ee8d-7b95-446b-711ddb683da2
Version Independent ID: aa099b9d-48db-5513-11c7-32c49a27e5be
Content: Site design JSON schema
Content Source: docs/declarative-customization/site-design-json-schema.md
Product: sharepoint
GitHub Login: @spdevdocs
Microsoft Alias: spdevdocs

Would there be any scope for the creation of a new non-premium trigger, isolated to site designs?
'When a site design is applied' for example?

@Toonshorty Yes. Or just a Flow Trigger for 'When a site is created' would also suffice.
I've ended up not using Flow, and instead using Logic Apps. It's far cheaper to use Logic Apps and they can be used in the "TriggerFlow" site script action.

While I appreciate the comment, IMHO licensing isn't a dev issue that should be pointed out. In other places in the docs, it refers to using Azure Functions, but it doesn't go into the licensing / costs on it.


[ENG-6015] Add User Preprint List Endpoint to Mirage Server

Ticket: [https://openscience.atlassian.net/browse/ENG-6015]
Feature flag: n/a

Purpose
Added a new endpoint to Mirage to handle requests for fetching a list of preprints associated with a specific user.
Summary of Changes

Added userPreprintList function to mirage/views/user.ts to fetch and filter preprints associated with a user's contributors.
Configured the new /users/:id/preprints endpoint in mirage/config.ts to use the userPreprintList function for retrieving preprint data.

Pull Request Test Coverage Report for Build<PHONE_NUMBER>0
Details

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage increased (+0.007%) to 63.07%

Totals

Change from base Build<PHONE_NUMBER>7:
0.007%

Covered Lines:
6188

Relevant Lines:
9497

💛  - Coveralls


(BKR-1022) bump windows memory

Refer to this link for build results (access rights to CI server needed):
http://jenkins-beaker.delivery.puppetlabs.net//job/qe_beaker_btc-intn/3330/


Migrate Kenya holidays to holiday groups

Proposed change

Migrate Kenya holidays to holiday_groups standard.
Type of change

[ ] New country/market holidays support (thank you!)
[ ] Supported country/market holidays update (calendar discrepancy fix, localization)
[x] Existing code/documentation/test/process quality improvement (best practice, cleanup, refactoring, optimization)
[ ] Dependency upgrade (version update)
[ ] Bugfix (non-breaking change which fixes an issue)
[ ] Breaking change (a code change causing existing functionality to break)
[ ] New feature (new python-holidays functionality in general)

Checklist

[x] I've followed the contributing guidelines
[x] This PR is filed against beta branch of the repository
[x] This PR doesn't contain any merge conflicts and has clean commit history
[x] The code style looks good: make pre-commit
[x] All tests pass locally: make test, make tox (we strongly encourage adding tests to your code)
[x] The related documentation has been added/updated (check off the box for free if no updates is required)

Coverage: 99.926% (+0.0001%) from 99.926% when pulling e576578cc241901a3c3034cb8a91638b104f73dc on PPsyrius:kenya_holiday_groups into 06924e95e52f0fa8881467e11bcb9615a5fe2868 on dr-prodigy:beta.

Thanks for helping standardize the PH codebase @PPsyrius 👍


Logging textcat breaks on score name cats_score_desc in base_logger.py

For textcat the dictionary other_scores  contains cats_score_desc which has a description, e.g. "F1 macro", rather than a loss value. When passed on to AIM through the call aim_run.track(loss_value, name=loss_name, context={'type':f'other_scores_{score_name}'}, epoch=epoch, step=step) the normalization of the loss value results in an error.
Solution: add a test for the score name ending in '_desc' in base_logger.py in the method aim_log_step.
if isinstance(other_scores, dict):
    for score_name, loss_value in other_scores.items():
        if not isinstance(loss_value, dict) and not score_name.endswith('_desc'):  # <-- extra condition for _desc
            aim_run.track(loss_value, name=loss_name, context={'type':f'other_scores_{score_name}'},
                                     epoch=epoch, step=step)

@osoblanco any chance you could take a look at this and help solve it?


terraform destroy fails

I have issues
with running terraform destroy to completion without errors.
I'm submitting a...

[/] bug report
[ ] feature request
[ ] support request
[ ] kudos, thank you, warm fuzzy

What is the current behavior?
terraform destroy completes with errors.
If this is a bug, how to reproduce? Please include a code sample if relevant.
`terraform destroy -auto-approve
data.template_file.map_accounts: Refreshing state...
data.template_file.map_roles: Refreshing state...
data.template_file.map_users: Refreshing state...
data.aws_availability_zones.available: Refreshing state...
data.aws_region.current: Refreshing state...
data.aws_caller_identity.current: Refreshing state...
data.aws_iam_policy_document.workers_assume_role_policy: Refreshing state...
data.aws_ami.eks_worker: Refreshing state...
data.aws_iam_policy_document.cluster_assume_role_policy: Refreshing state...
Error: Error applying plan:
4 error(s) occurred:

local.cluster_name: local.cluster_name: Resource 'random_string.suffix' does not have attribute 'result' for variable 'random_string.suffix.result'
module.eks.output.config_map_aws_auth: Resource 'data.template_file.config_map_aws_auth' does not have attribute 'rendered' for variable 'data.template_file.config_map_aws_auth.rendered'
module.eks.output.cluster_endpoint: Resource 'aws_eks_cluster.this' does not have attribute 'endpoint' for variable 'aws_eks_cluster.this.endpoint'
module.eks.output.kubeconfig: Resource 'data.template_file.kubeconfig' does not have attribute 'rendered' for variable 'data.template_file.kubeconfig.rendered'`

Environment details

Affected module version: 1.7.0
OS: 10.14.1
Terraform version: 0.11.10

Any other relevant info

If you are blocked, this is a known issue with terraform and described here: https://github.com/hashicorp/terraform/blob/master/CHANGELOG.md#0111-november-30-2017
and you can use TF_WARN_OUTPUT_ERRORS=1 to get passed it with 0.11.* terraform runtimes.
There are some other known workarounds using the
value       = "${element(concat(RESOURCE.*.NAME, list("")), 0)}" pattern, but that may not work for all the above types when using 0.11.*
Some of this can possibly be revisited when 0.12 is officially released, as its stated they plan to remove that env variable support.

Some of this can possibly be revisited when 0.12 is officially released

Says everyone about every Terraform issue nowadays 🤣

Ok, thanks for the tip.
Much appreciated!


nice work, but one issue

Traceback (most recent call last):
File "./scripts/DUTStabilizer.py", line 111, in
generateStable(model, inPath, outPath, outPrefix, maxlength, args)
File "./scripts/DUTStabilizer.py", line 57, in generateStable
origin_motion, smoothPath = model.inference(x.cuda(), x_RGB.cuda(), repeat=args.Repeat)
File "/home/gary/vs/deeplearn/DUTCode/models/DUT/DUT.py", line 273, in inference
for i in range(len(kpts) - 1)]
File "/home/gary/vs/deeplearn/DUTCode/models/DUT/DUT.py", line 273, in
for i in range(len(kpts) - 1)]
File "/home/gary/vs/deeplearn/DUTCode/models/DUT/MotionPro.py", line 105, in inference
motion, gridsMotion, _ = self.homoEstimate(concat_motion, kp)
File "/home/gary/vs/deeplearn/DUTCode/utils/ProjectionUtils.py", line 170, in multiHomoEstimate
pred_Y = KMeans(n_clusters=2, random_state=2).fit_predict(motion_numpy)
File "/home/gary/anaconda3/envs/DUTCode/lib/python3.6/site-packages/sklearn/cluster/kmeans.py", line 1122, in fit_predict
return self.fit(X, sample_weight=sample_weight).labels
File "/home/gary/anaconda3/envs/DUTCode/lib/python3.6/site-packages/sklearn/cluster/_kmeans.py", line 1033, in fit
accept_large_sparse=False)
File "/home/gary/anaconda3/envs/DUTCode/lib/python3.6/site-packages/sklearn/base.py", line 420, in _validate_data
X = check_array(X, **check_params)
File "/home/gary/anaconda3/envs/DUTCode/lib/python3.6/site-packages/sklearn/utils/validation.py", line 72, in inner_f
return f(**kwargs)
File "/home/gary/anaconda3/envs/DUTCode/lib/python3.6/site-packages/sklearn/utils/validation.py", line 645, in check_array
allow_nan=force_all_finite == 'allow-nan')
File "/home/gary/anaconda3/envs/DUTCode/lib/python3.6/site-packages/sklearn/utils/validation.py", line 99, in _assert_all_finite
msg_dtype if msg_dtype is not None else X.dtype)
ValueError: Input contains NaN, infinity or a value too large for dtype('float32').
I use default dataset in folder images, thanks~

Hi could you please tell me how to solve this problem? I also encountered a similar problem.Thanks！


Level0_Send to Ether

Description of  the change
I'd like to make the changes to UI of this project .
Domain of Docs

[] Readme
[] Solidity , Html, Css , JavaScript , Web3.js / Ether.js
[] Solidity , ReactJs /NextJs , Web3.js /Ether.js
[] Solidity , Python3 , Web3.py
[] Other , feel free to mention below

Are you contributing under any open-source program ?

@shubhisingh184 Could you assign me this?

@Saloni020 please give proper details of the changes that you want to do in that project.


Add file functions for FileSetting

Add file utility to FileSetting because just having the path to a file isn't useful for plugin developers

filetype() return mime type
read() return contents of files
readBuffer() return contents of files in a buffer

Re-opening a clean PR 'cause I'm dumb


Problem with request package

I am trying to connect to a RETS server, and when I initialize the client I get this error from the request package.

Here is the code used.

request package is also deprecated.

Fixed. The response body didn't have the extra property, and content is a buffer, so I made it into a string. May have to do with the RETS or request version? I'm using RETS V1.8 and request ^2.88.2.


Autorest Regen Preview to 3.0.0-alpha.20231030.2 by Alexander Sher from refs/pull/3726/head

Triggered from https://github.com/Azure/autorest.csharp/pull/3726

API change check
API changes are not detected in this pull request.


Maximum pool size?

Hi @rueian. Just starting to experiment with this lib.
How are maximum number of connection per client to a node determined and managed? BlockingPoolSize indicates that it's for specific commands like BPLOP. Does it actually dictate the total number of connections that a client will make to a node? The equivalent in go-redis would be PoolSize and MaxActiveConns.

Hi @knadh,
BlockingPoolSize is used by blocking commands like BPLOP and is also used by client.Dedicate() and client.Dedicated(). They all share the same pool to a node. The maximum size of the pool is 1000 by default. If you don't use the above functions then no connection will be in the pool.
All other commands such as GET and SET share another pool. When rueidis connects to a cluster, it uses 1 connection to a node by default. When rueidis connects to a standalone redis, it uses at most 4 connections to a node by default depending on your CPU cores. This can be changed by setting the PipelineMultiplex option.

Thank you @rueian. Trying to understand the conceptual difference between how rueidis handles connection pooling compared to libs.
redigo and goredis both have maxIdle / maxActive constraints to control the pool size. Based on the amount of activity (and latency of responses) over a connection, new connections are spawned and messages spread across the pool until it hits max conns. It's easy to observe the jump in pool size on systems with heavy traffic. This is similar to DB drives, HTTP clients etc. Similarly, when there are many app instances that connect to one Redis instance, these params can be used to predictably control the max connections Redis will receive.
In that context:

All other commands such as GET and SET share another pool. This pool, when rueidis connects to a cluster, uses 1 connection to a node by default. When rueidis connects to a standalone redis, it uses at most 4 connections by default depending on your CPU cores. This behavior can be changed by setting the PipelineMultiplex option.

If say PipelineMultiplex = 100.

Does it keep 100 connections open to every node in a cluster (or a standalone instance?)
How does it interact with keep-alive? Do these connections die off when hitting the keep-alive limit and immediately get re-connected? Or is the re-connection based on activity?
What is the biggest conceptual difference between PipelineMultiplex and the min/max idle/active concept in other libs?

Apologies for firing off too many questions. Trying to understand the subtleties as there are no explicit control params. We're evaluating the lib for workloads in a critical financial environment. Thank you!

Hi @knadh,
With the latest v1.0.26, the maximum PipelineMultiplex is 8 which results in 256 connections to a node because 1 << 8 == 256. I don't recommend setting it to larger than 2 which is more than 4 connections to a node. The Redis documentation also suggests that "Using more than 8 threads is unlikely to help much".
Say if PipelineMultiplex = 1 then

rueidis keeps 2 connections open to every node in a cluster, because 1<<1 == 2. If you have 3 nodes then there will be 6 connections opened by rueidis.
These connections will die only in two cases: 1) there is an IO error, including a TCP keep-alive error and 2) client.Close() is called. In the former case, the dead connection will be reconnected based on activity.
The min/max idle/active concept is much more suitable for blocking use cases. For pipelining use cases, we tend to share connections and keep them open.

That explains it. Thank you!


Build buildSrc after applying the settings file

This allows the build cache settings to implicitly apply to buildSrc,
whereas before the configuration had to be duplicated there.
Fixes https://github.com/gradle/gradle/issues/9094 and https://github.com/gradle/gradle/issues/5333
https://builds.gradle.org/project.html?projectId=Gradle&branch_Gradle=ldaley%2Fsettings-before-buildsrc

Docs will follow tomorrow.

@eskatos I spotted this: https://github.com/gradle/gradle/blob/89d4dd396f592022ce2deb9f2f187a7c5cf4b4af/subprojects/kotlin-dsl-tooling-builders/src/crossVersionTest/groovy/org/gradle/kotlin/dsl/tooling/builders/r54/KotlinSettingsScriptModelCrossVersionSpec.groovy#L117
That doesn't seem right IIUC.
AFAICT, we don't have any way of influencing the result here currently for just settings scripts. If I'm right in that, I'll need your help in adding it.

@big-guy ping

https://github.com/gradle/gradle/blob/89d4dd396f592022ce2deb9f2f187a7c5cf4b4af/subprojects/kotlin-dsl-tooling-builders/src/crossVersionTest/groovy/org/gradle/kotlin/dsl/tooling/builders/r54/KotlinSettingsScriptModelCrossVersionSpec.groovy#L117

That doesn't seem right IIUC.

@ldaley right, this test and the one above are now wrong, they should NOT include buildSrc sources. This won't be user visible in the editor because the classpath is correct. Fixing this would make the response for settings scripts smaller. This shouldn't block merging this PR, I opened https://github.com/gradle/gradle/issues/10417 to follow up on this

@eskatos Great, thanks. Are you now 👍 on the PR?


Can I provide my .cljstyle configuration?

Hi there, thanks for this GH action!
Is there a convenient way to provide a custom .cljstyle file? Currently cljstyle seems to get invoked with a default configuration.
My custom .cljstyle file provided below just in case:
{:rules {:indentation {:indents {#"rum\/defc" [[:inner 0]]}}
         :namespaces {:break-libs? false}}}

If this isn't currently supported, and you can point me roughly to what needs to be done to enable this behavior, I'd be interested in contributing. Thanks!

Thank you for suggesting this new feature.
After careful consideration, I decided not to provide the ability to specify configuration files in this action, because cljstyle doesn't have the ability to specify paths of configuration files to load directly on the command line.
If you want to apply custom configurations, it is recommended that you add .cljstyle file to the root (or sub) directory of your clojure project and manage it with Git.