Iteration Plan for May 2023

This plan captures our work in May. This is a 5-week iteration. We will ship in early June.
Update: We extended the May iteration by one week and now begin our endgame end-of-day of May 29. Since VS Code Insiders is used in several keynotes and sessions during the Build conference, we will freeze Insiders May 20 - 25 to give the presenters a breather.
Endgame

May 29, 2023: Endgame begins
June 2, 2023: Endgame done

The endgame details for this iteration are tracked here.
Plan Items
Below is a summary of the top level plan items.
Legend of annotations:

Mark
Description

:runner:
work in progress

:hand:
blocked task

:muscle:
stretch goal for this iteration

:red_circle:
missing issue reference

:large_blue_circle:
more investigation required to remove uncertainty

:black_circle:
under discussion within the team

:black_large_square:
a large work item, larger than one iteration

Accessibility

[ ] :runner: Notebook output accessibility vscode#178630 @amunger
[ ] :runner: Explore merge editor accessibility improvements vscode#180729 @meganrogge @hediet
[ ] :runner: Add more accessibility.verbosity settings / hints vscode#180470 @meganrogge
[x] Present content first in References tree view vscode#180653 @meganrogge
[ ] Settings Editor value descriptions are not read by screen readers vscode#180115 @rzhao271
[ ] :runner: Accessibility issues, see query @meganrogge team

UX

None.

Workbench

[x] Support Dev Containers and WSL in new Connect to... experience on Welcome Page vscode-remote-release#8251 @bhavyaus @aeschli @chrmarti
[x] Show 'Connect To Tunnel' on Welcome page in vscode.dev vscode#179687 @bhavyaus @aeschli @bhavyaus
[ ] Support experimental contextual non-modal dialogs to educate users on web experiences vscode#179401 @bhavyaus @joyceerhl @daviddossett
[ ] :runner: Improve the keybinding recording widget vscode#178042 vscode#179015 vscode#179018 @ulugbekna
[ ] :runner: Explore support for multiple GitHub accounts vscode#127967 @tylerleonhardt
[ ] :runner: UX to alert users of a slow remote connection vscode#178553 @bpasero
[ ] :runner: Support roaming workspace state via StorageScope.WORKSPACE and StorageTarget.USER in IStorageService vscode#179898 @joyceerhl @bpasero
[x] Support deduplicating SSH and HTTP remotes when computing edit session identities vscode#180582 @joyceerhl
[x] Add read-only mode vscode#4873 @bpasero
[ ] Exploration: Allow Default profile to be a fallback for settings, extensions and keyboard shortcuts vscode#156144 @sandy081
[ ] :runner: Adopt new extension host restart lifecycle vscode#180514 @bpasero @sandy081 @lszomoru @rebornix @mjbvz
[ ] Drop support for windows 8 and 8.1 vscode#177676 @deepak1556

Code Editor

[ ] :runner: :muscle: Collapse unchanged regions in diff vscode#3562 @hediet
[ ] :runner: Explore detecting moves in the diff editor vscode#181902 @hediet
[x] Monaco Editor Release 0.38.0 @hediet

Notebook Editor

[ ] :runner: Support scrollable outputs for streaming text vscode#177721 @amunger @rebornix @mjbvz
[ ] Align closing behavior of the Interactive Window with Untitled Files vscode#172974 @amunger
[x] Allow scrapbook untitled working copies vscode#174485 @amunger @bpasero
[ ] :runner: Support notebook.codeActionsOnSave vscode#179213 @yoyokrazy
[ ] :runner: Explore "Format Cell on Run" vscode-jupyter#7058 @Yoyokrazy
[ ] Explore Sticky Scroll showing markdown headers in notebooks vscode#182444 @Yoyokrazy
[ ] :runner: Polish global search options for open notebooks vscode#164926 @andreamah
[ ] Explore smart global search for notebooks in the workspace vscode#173726 @andreamah
[x] Static resources fail to load in Notebook renderer with 401 error vscode#175033 @mjbvz

Jupyter Notebooks

[ ] :runner: Contributions to the vscode-jupyter extension vscode-jupyter#13471 team

WebAssembly Runtime Support

[ ] :runner: Support tree house team on the new WASM-WASI-Core extension @dbaeumer
[ ] :runner: Provide an extensible web-shell vscode-wasm#63@dbaeumer

Languages
Python

[ ] :runner: Contributions to the python extension vscode-python#21196 @brettcannon team

JavaScript

[x] Bundle TS 5.1 vscode#182931 @mjbvz

Python WebAssembly Runtime Support

None.

JavaScript/TypeScript

[ ] Automatic type acquisition on the web vscode#172887 @mjbvz

[ ] :runner: Merge in initial prototype from TS vscode#182801

[x] Project-wide IntelliSense on the web vscode#170920 @mjbvz

Language Server Protocol

[ ] :runner: Investigate to extract a base protocol definition out of the LS protocol 1707 @dbaeumer

Source Control

[x] Allow customizing initial branch when initializing a Git repository vscode#179658 @lszomoru
[ ] :runner: Handle GitHub's Secret Scanning Push Protection vscode#169355 @lszomoru
[x] Support GitHub Repository Rules as branch protections vscode#182488 @lszomoru

Terminal

[ ] :runner: Make fixes to environment workspace collection and finalize proposed APIs vscode#182069 vscode#181755 @karrtikr
[x] Allow EnvironmentVariableCollection API to apply changes via shell integration vscode#179476 @tyriar @karrtikr

Testing

[ ] :muscle: Support for ANSI colors in test output vscode#151964 @connor4312
[ ] :muscle: Start drafting a retired test item API vscode#134970 @connor4312

vscode.dev

[ ] Opening vscode.dev should not require a browser reload to update web extensions vscode#174682 @sandy081

API

[ ] :muscle: :runner: Explore ShareableDataProvider API vscode#176316 @joyceerhl
[ ] :runner: Stabilize DocumentPasteEditProvider API to support pasting images vscode#30066 @mjbvz
[ ] :runner: Explore static status bar contributions vscode#167874 @jrieken
[ ] :runner: Finalize tree checkboxes API vscode#116141 @alexr00
[ ] :runner: Finalize port attributes API vscode#115616 @alexr00
[ ] :runner: API proposals: query @jrieken @mjbvz
[ ] :runner: API finalization: query @jrieken @mjbvz

Extensions

[x] Adopt using platform specifier in path for web extensions vscode#180525 @sandy081

Extension Contributions

[ ] :runner: Improvements to the Remote extensions vscode-remote-release#8455 @eleanorjboyd @chrmarti @aeschli @joyceerhl @connor4312
[ ] :runner: Nudge users towards sign-in vscode-pull-request-github#4756 @alexr00
[ ] Allow checked-ed out PRs to show diffs only against PR head vscode-pull-request-github#4720 @alexr00

Engineering

[ ] :red_circle: Roll out sandboxing to all users @digitarald
[x] Adopt utility process in terminal/pty host vscode#175335 @tyriar @bpasero
[ ] :muscle: :runner: Improving the developer experience for the CLI within the vscode repo vscode#171515 @aeschli @connor4312

Electron

[ ] :runner: Orca can't be stopped in native dialogs vscode#121811 @deepak1556
[ ] Right Click acting abnormal vscode#113175 @deepak1556
[x] Code - OSS doesn't launch when using Dev Container locally or in codespaces vscode#168655 @deepak1556

Deferred

[ ] Support that servers can read from remote file systems 1264 @rchiodo / @dbaeumer
[ ] Explore prompting to enable Cloud Changes on save in web vscode#179014 @joyceerhl
[ ] Explore alternative wording for "Continue On" explanations vscode#180106 @hbons
[ ] :hand: Add elided text (editor core subset of vscode#170447) @hediet @alexdima
[ ] :hand: :black_large_square: PGO for VSCode Desktop vscode#170931 @deepak1556
[ ] Walkthrough images load slowly vscode#166890 @bhavyaus
[ ] :runner: Explore support for extensions to provide additional data to the issue reporter vscode#46726 @TylerLeonhardt
[ ] :runner: Make editor hovers resizable vscode#14165 @aiday-mar
[ ] :runner: Exploration: Re-think PR creation flow vscode-pull-request-github#4403 @alexr00 @hbons
[ ] Exploration: Cross-profile settings and extensions vscode#176813 vscode#157492@sandy081
[ ] :black_large_square: vscode#179000 Exploration: Changes editor @lszomoru
[ ] :muscle: Surface Dependabot alerts in workbench vscode#178991 @lszomoru

@MrJithil generally items on the iteration plan are being done by the core team in the month it's called out. If you're looking to contribute, check out this query: https://github.com/microsoft/vscode/issues?q=is%3Aopen+is%3Aissue+label%3A"help+wanted"

Sure thanks.

Any Eta on when Multiple Github accounts will be supported in VS Code? I get more and more questions about this from clients with multiple github orgs with diffrent samlsso integrations.

@jantorep https://github.com/microsoft/vscode/issues/127967 is a better place to ask about that

hey @sandy081 any work on #156144 ? I'm really looking forward to seeing some improvements here!

@


While using sign_apk.rb I am facing /.rvm/rubies/ruby-2.3.3/lib/ruby/2.3.0/open3.rb:199:in `spawn': [!] wrong first argument

New Issue Checklist

[x] Updated fastlane to the latest version
[x] I read the Contribution Guidelines
[x] I read docs.fastlane.tools
[x] I searched for existing GitHub issues

While using sign_apk.rb I am facing /.rvm/rubies/ruby-2.3.3/lib/ruby/2.3.0/open3.rb:199:in `spawn': [!] wrong first argument (ArgumentError)
     sign_apk(
        apk_path: options[:apk_path],
        keystore_path: options[:keystore_path],
        alias: options[:alias],
        storepass: options[:storepass],
        tsa: "http://timestamp.comodoca.com/rfc316",
      )

Complete output when running fastlane, including the stack trace and command used

.rvm/rubies/ruby-2.3.3/lib/ruby/2.3.0/open3.rb:199:in spawn': [!] wrong first argument (ArgumentError) 	from /Users/macmini/.rvm/rubies/ruby-2.3.3/lib/ruby/2.3.0/open3.rb:199:in popen_run'
from /Users/macmini/.rvm/rubies/ruby-2.3.3/lib/ruby/2.3.0/open3.rb:190:in popen2e' 	from /Users/macmini/.rvm/gems/ruby-2.3.3@global/gems/fastlane-2.70.3/fastlane/lib/fastlane/helper/sh_helper.rb:49:in sh_control_output'
from /Users/macmini/.rvm/gems/ruby-2.3.3@global/gems/fastlane-2.70.3/fastlane/lib/fastlane/helper/sh_helper.rb:12:in sh' 	from /Users/macmini/fastlane/android/AndroidAppCMS/fastlane/actions/sign_apk.rb:30:in run'
from /Users/macmini/.rvm/gems/ruby-2.3.3@global/gems/fastlane-2.70.3/fastlane/lib/fastlane/runner.rb:253:in block (2 levels) in execute_action' 	from /Users/macmini/.rvm/gems/ruby-2.3.3@global/gems/fastlane-2.70.3/fastlane/lib/fastlane/actions/actions_helper.rb:50:in execute_action'
from /Users/macmini/.rvm/gems/ruby-2.3.3@global/gems/fastlane-2.70.3/fastlane/lib/fastlane/runner.rb:231:in block in execute_action' 	from /Users/macmini/.rvm/gems/ruby-2.3.3@global/gems/fastlane-2.70.3/fastlane/lib/fastlane/runner.rb:227:in chdir'
from /Users/macmini/.rvm/gems/ruby-2.3.3@global/gems/fastlane-2.70.3/fastlane/lib/fastlane/runner.rb:227:in execute_action' 	from /Users/macmini/.rvm/gems/ruby-2.3.3@global/gems/fastlane-2.70.3/fastlane/lib/fastlane/runner.rb:148:in trigger_action_by_name'
from /Users/macmini/.rvm/gems/ruby-2.3.3@global/gems/fastlane-2.70.3/fastlane/lib/fastlane/fast_file.rb:148:in method_missing' 	from Fastfile:50:in block (2 levels) in parsing_binding'
from /Users/macmini/.rvm/gems/ruby-2.3.3@global/gems/fastlane-2.70.3/fastlane/lib/fastlane/lane.rb:33:in call' 	from /Users/macmini/.rvm/gems/ruby-2.3.3@global/gems/fastlane-2.70.3/fastlane/lib/fastlane/runner.rb:49:in block in execute'
from /Users/macmini/.rvm/gems/ruby-2.3.3@global/gems/fastlane-2.70.3/fastlane/lib/fastlane/runner.rb:45:in chdir' 	from /Users/macmini/.rvm/gems/ruby-2.3.3@global/gems/fastlane-2.70.3/fastlane/lib/fastlane/runner.rb:45:in execute'
from /Users/macmini/.rvm/gems/ruby-2.3.3@global/gems/fastlane-2.70.3/fastlane/lib/fastlane/lane_manager.rb:56:in cruise_lane' 	from /Users/macmini/.rvm/gems/ruby-2.3.3@global/gems/fastlane-2.70.3/fastlane/lib/fastlane/command_line_handler.rb:34:in handle'
from /Users/macmini/.rvm/gems/ruby-2.3.3@global/gems/fastlane-2.70.3/fastlane/lib/fastlane/commands_generator.rb:104:in block (2 levels) in run' 	from /Users/macmini/.rvm/gems/ruby-2.3.3/gems/commander-fastlane-4.4.5/lib/commander/command.rb:178:in call'
from /Users/macmini/.rvm/gems/ruby-2.3.3/gems/commander-fastlane-4.4.5/lib/commander/command.rb:153:in run' 	from /Users/macmini/.rvm/gems/ruby-2.3.3/gems/commander-fastlane-4.4.5/lib/commander/runner.rb:476:in run_active_command'
from /Users/macmini/.rvm/gems/ruby-2.3.3@global/gems/fastlane-2.70.3/fastlane_core/lib/fastlane_core/ui/fastlane_runner.rb:66:in run!' 	from /Users/macmini/.rvm/gems/ruby-2.3.3/gems/commander-fastlane-4.4.5/lib/commander/delegates.rb:15:in run!'
from /Users/macmini/.rvm/gems/ruby-2.3.3@global/gems/fastlane-2.70.3/fastlane/lib/fastlane/commands_generator.rb:343:in run' 	from /Users/macmini/.rvm/gems/ruby-2.3.3@global/gems/fastlane-2.70.3/fastlane/lib/fastlane/commands_generator.rb:42:in start'
from /Users/macmini/.rvm/gems/ruby-2.3.3@global/gems/fastlane-2.70.3/fastlane/lib/fastlane/cli_tools_distributor.rb:75:in take_off' 	from /Users/macmini/.rvm/gems/ruby-2.3.3@global/gems/fastlane-2.70.3/bin/fastlane:20:in <top (required)>'
from /Users/macmini/.rvm/gems/ruby-2.3.3/bin/fastlane:23:in load' 	from /Users/macmini/.rvm/gems/ruby-2.3.3/bin/fastlane:23:in '
from /Users/macmini/.rvm/gems/ruby-2.3.3/bin/ruby_executable_hooks:15:in eval' 	from /Users/macmini/.rvm/gems/ruby-2.3.3/bin/ruby_executable_hooks:15:in '
Environment

✅ fastlane environment ✅
Stack

Key
Value

OS
10.13.2

Ruby
2.3.3

Bundler?
false

Git
git version 2.14.3 (Apple Git-98)

Installation Source
~/.rvm/gems/ruby-2.3.3/bin/fastlane

Host
Mac OS X 10.13.2 (17C88)

Ruby Lib Dir
~/.rvm/rubies/ruby-2.3.3/lib

OpenSSL Version
OpenSSL 1.0.2l  25 May 2017

Is contained
false

Is homebrew
false

Is installed via Fabric.app
false

Xcode Path
/Applications/Xcode.app/Contents/Developer/

Xcode Version
9.2

System Locale

Variable
Value

LANG
en_US.UTF-8
✅

LC_ALL
en_US.UTF-8
✅

LANGUAGE
en_US.UTF-8
✅

fastlane gems

Gem
Version
Update-Status

fastlane
2.70.3
✅ Up-To-Date

Loaded fastlane plugins:
No plugins Loaded
Loaded gems

Gem
Version

did_you_mean
1.0.0

executable-hooks
1.3.2

bundler-unload
1.0.2

rubygems-bundler
1.4.4

bundler
1.15.4

io-console
0.4.5

slack-notifier
1.5.1

CFPropertyList
2.3.5

claide
1.0.2

colored2
3.1.2

nanaimo
0.2.3

xcodeproj
1.5.2

rouge
2.0.7

xcpretty
0.2.8

terminal-notifier
1.8.0

unicode-display_width
1.3.0

terminal-table
1.8.0

plist
3.3.0

public_suffix
2.0.5

addressable
2.5.2

multipart-post
2.0.0

word_wrap
1.0.0

tty-screen
0.6.3

babosa
1.0.2

colored
1.2

highline
1.7.8

commander-fastlane
4.4.5

excon
0.59.0

faraday
0.13.1

unf_ext
<IP_ADDRESS>

unf
0.1.4

domain_name
0.5.20170404

http-cookie
1.0.3

faraday-cookie_jar
0.0.6

fastimage
2.1.0

gh_inspector
1.0.3

json
1.8.3

mini_magick
4.5.1

multi_json
1.12.2

multi_xml
0.6.0

rubyzip
1.2.1

security
0.1.3

xcpretty-travis-formatter
0.0.4

dotenv
2.2.1

faraday_middleware
0.12.2

uber
0.1.0

declarative
0.0.10

declarative-option
0.1.0

representable
3.0.4

retriable
3.1.1

mime-types-data
3.2016.0521

mime-types
3.1

little-plugger
1.1.4

logging
2.2.2

jwt
1.5.6

memoist
0.16.0

os
0.9.6

signet
0.7.3

googleauth
0.5.3

httpclient
2.8.3

google-api-client
0.13.6

generated on: 2017-12-26

@KrauseFx Please give your input on this issue.

Mh, seems like sign_apk isn't a fastlane action, but a third party action or plugin? If so, make sure to reach out to the original author


feat(plonky2): converted the remaining parts of the PLONKY2 code generator to use the AsmWriter

After these changes, all plonky2 calls should (in theory) be printed to the screen by the '--show-plonky2' command line option.

Have you tested this in any way, at least locally? (I'm not asking for an automated test.)
I tried running --show-plonky2 before and after on zk_dungeon and there is no change.

Have you tested this in any way, at least locally? (I'm not asking for an automated test.)
I tried running --show-plonky2 before and after on zk_dungeon and there is no change.

Strange! There's a difference on my machine. At least in the beginning there is a sequence of add_virtual_bool_target_safe and add_virtual_target calls/instructions, that weren't there before. I checked whether I had forgotten to 'git add' something, but I didn't find any such thing. I don't know, maybe try 'cargo clean && cargo build'?

Other than that, the code looks good.


Fix distorted speaker image.

Use centerInside() for non-square speaker images.

Before
After

:+1:

:+1: :+1: :+1: :+1:

:+1:

Thanks!! LGTM


feat(config): update Zooz ZEN20 with additional parameters 28 - 36

Per https://www.support.getzooz.com/kb/article/1024-zen20-power-strip-advanced-settings/
Resolve https://github.com/zwave-js/node-zwave-js/issues/4806 and believe with commit, can close
I looked at https://github.com/zwave-js/node-zwave-js/issues/4808 but was not sure if this helps or not.  I do have one of the new 3.0 devices so can provide some investigation around it, but do not have a ver 2.0 to supply firmware or differentiation.

I did a few minor changes for consistency.

Ah, I see, thanks! I also am a stickler for consistent style as well, so appreciate those changes.  Also appreciate that you grouped the (A) and (V) together with the (W) and (kWH).  Makes sense.


Error: Cannot find module '../build/Release/bson'] code: 'MODULE_NOT_FOUND'

At first I want to thank you for your package.
I'm having these errors every time I run my meteor app on Windows 8.1 and I'm using the following packages:
netanelgilad:excel
netanelgilad:mkdirp
netanelgilad:node-uuid
vsivsi:file-collection
I20150617-11:36:36.972(-5)? { [Error: Cannot find module '../build/Release/bson'] code: 'MODULE_NOT_FOUND' }
W20150617-11:36:36.974(-5)? (STDERR) js-bson: Failed to load c++ bson extension, using pure JS version
I20150617-11:36:37.273(-5)? { [Error: Cannot find module '../build/Release/bson'] code: 'MODULE_NOT_FOUND' }
W20150617-11:36:37.273(-5)? (STDERR) js-bson: Failed to load c++ bson extension, using pure JS version
I20150617-11:36:37.276(-5)? { [Error: Cannot find module '../build/Release/bson'] code: 'MODULE_NOT_FOUND' }
I20150617-11:36:37.276(-5)? { [Error: Cannot find module '../build/Release/bson'] code: 'MODULE_NOT_FOUND' }
W20150617-11:36:37.276(-5)? (STDERR) js-bson: Failed to load c++ bson extension, using pure JS version
W20150617-11:36:37.276(-5)? (STDERR) js-bson: Failed to load c++ bson extension, using pure JS version

Can you try to pin down the exact package causing the issue by removing some of the packages?

Reported for vsivsi:file-collection
https://github.com/vsivsi/meteor-file-collection/issues/58#event-333461240


Update k8s deployment document.

A large portion of this content came from the bpfd-operator README.md file, which will need to get trimmed down after this change is merged.
Signed-off-by: Andre Fredette<EMAIL_ADDRESS>

@Billy99, I think I've addressed all of your comments.  Thanks for the thorough review!


Issue with findObjectById (in path)

I have a problem with the url like GET /objects/{id} which now return always null.
The GET /objects work well as before, and returns all my objects.
It was working with the last version 0.3.x, and I thinks  it's maybe because I have an id of type string and not number.
protected findById<T extends { id: any }>(collection: T[], id: any): T {
    return collection.find((item: T) => item.id === id);
}
the problem seems to be the === in my case.
protected parseId(id: string): any {
const idNum = parseFloat(id);
return isNaN(idNum) ? id : idNum;
}
For my test, I used id: '1', id: '2'.... but my id is string. Due to the method parseId(), my id is cast as a number, and then the === of findById failed.

That's my fault. During my refactor (in 0.4.0, 0.4.1 or 0.4.2) I couldn't remember why I tested the id type of an element in the collection so I got rid of that ... and broke you. I need to see if the id is a string type and, if it is, not even attempt to parse it as a number.
I will fix that in v.0.4.4.

No problem, It's seems that I soon find all your bugs ;)

I hope soon.  There were many hidden in there. Testing found some of them. Refactoring for HttpClient inadvertently added more.
Note that the fix is itself a breaking change. Previous versions of the library would generate a numeric id for new items POSTed to a collection that was supposed to have string ids.
For example, if your heroes collection had string ids like 100 and you added a new hero without specifying the id, the library would generate an id for you ... and that id would be 1.
That was never right. What it will now do is throw a 422 - Unprocessable Entity, on the grounds that you tried to add a new entity without supplying the id.
The presumption of 422 is that it is the requestor's fault, not a system fault.

Released 0.4.4 with fix described above

For id generator with string id, you, maybe, can make a random string by default ?
I use chancejs.hash({length: 10}); by exemple.


Insiders: search-in-panel support gone without warning

Issue Type: Bug

Update to 1.4.6
Search is not an option in panel

Maybe there's a setting that I'm overlooking? Having Search in the panel rather than the sidebar is my reason for using the Insiders track.
VS Code version: Code - Insiders 1.46.0-insider (da3bf754c3c0eabda1dc80ed9d627679ee560697, 2020-05-19T10:04:14.981Z)
OS version: Darwin x64 18.7.0
Edit: this issue persists when I disable all plugins.

Had same issue but I thought that it was lost due to changes in settings and possible sync with other PR.
Is it possible that deprecated "search.location": "panel" is ignored, but position not set to panel (same as drag&drop)

You can just drag Search (icon) from action bar to panel.

Thanks, drag and drop worked! Had no idea that was supported.

Is it possible that deprecated "search.location": "panel" is ignored, but position not set to panel (same as drag&drop)

There's no "search.location" in my user settings 🤷♂

I'll close this, the drag and drop is such an easy fix it probably doesn't matter if some setting was lost


How does one turn off the themes

If someone doesn't want to use a theme. how can you turn them off?

love the extension though it is so helpful i just found it

Duplicate issue
If you want to continue this discussion, use the issue above.


Added German International School Sydney. Website: http://giss.nsw.ed…

German International School Sydney
Official website: http://giss.nsw.edu.au or http://germanschoolsydney.com
Course: https://www.germanschoolsydney.com/en/curriculum/senior-secondary-ibdp (see 'Information technology in a global society' in the curriculum section)

Domain recognition proof: https://www.germanschoolsydney.com/en/contact-us (see email in contact details)

@Erberum First stage of verification passed, official domain is germanschoolsydney.com as far as I verified. This is just an informational note. Pull request is still in the review. I appreciate your patience while waiting for the final decision. Proof of domain ownership: https://www.germanschoolsydney.com/en/enrolments/online-application-1

@Erberum Thank you for your patience while waiting for a review and processing your request. Pull request merged.


Find and implement a new (better) audio library

Jsfx is passable as an audio library but there are probably better ones available. After some research I found two that might meet our needs.

Tone.js
timbre.js.

Already supported with Jsfx:

Play a large range of sounds
Allow for audio playback to be stopped
Adjustable speed

Additional goals for a new library:

Better sound quality
Support multiple sounds at once
More types of sound (instruments, wave shapes)

Timbre.js has now been fully implemented and is currently replacing jsfx. We now support waveforms on all browsers and midi instruments on all browsers except safari.


Make hover integration test pass

The hover integration test is failing because of a possible race condition between the omnisharp process and the vscode process to access the file that has been added. Hence, if we restart the server before we ask vscode to open it, omnisharp will have read the file and no problem should occur.
PS: I am not sure whether this is the best approach to solve this, because we will have to restart the server whenever we add a file for testing.

@akshita31 The solution we discussed was to just always include the "hover" file in the test solution. However, if this works, I'm happy to take it :). I restarted your PR build to see if it's flaky.

@rchande I was trying to add a test for signature help for this PR : https://github.com/OmniSharp/omnisharp-vscode/pull/1958 , following the same approach as above, but it doesn't seem to work :(

This approach doesn't work. Closing this in favor of https://github.com/OmniSharp/omnisharp-vscode/pull/2058


Update turbine 1.0.0

Changelog: https://github.com/cashapp/turbine/releases/tag/1.0.0

This PR needs to be applied on top of the KotlinX coroutines update (org.jetbrains.kotlinx:kotlinx-coroutines-core:1.7.x)

#857

https://github.com/android/nowinandroid/blob/main/gradle/libs.versions.toml
Turbine is already updated to the latest version (1.0.0) now.


fetch failed: https://poe.com/_next/data/t55y8LR_LPR9oghrT_Zdj/undefined.json, 404, Not Found

Error: Failed to fetch https://poe.com/_next/data/t55y8LR_LPR9oghrT_Zdj/undefined.json after 5 retries
at file:///C:/Users/rowan/Documents/bypassed/node_modules/poe-node-api/dist/PoeClient.js:93:24
at process.processTicksAndRejections (node:internal/process/task_queues:95:5)
Node.js v18.15.0

Did you add a custom bot?

Error: Failed to fetch https://poe.com/_next/data/t55y8LR_LPR9oghrT_Zdj/undefined.json after 5 retries at file:///C:/Users/rowan/Documents/bypassed/node_modules/poe-node-api/dist/PoeClient.js:93:24 at process.processTicksAndRejections (node:internal/process/task_queues:95:5)
Node.js v18.15.0

Try dev branch, I changed the logic of getBot :)


Change the location of Links

Consider the below record,
# Represents location
public type Location record {|
    # Name of the location
    string name;
    # Unique identification
    string id;
    # Address of the location
    string address;
    *http:Links;
|};

Following is a part generated OAS.
Location:
  allOf:
  - $ref: '#/components/schemas/Links'
  - required:
    - address
    - id
    - name
    type: object
    properties:
      name:
        type: string
        description: Name of the location
      id:
        type: string
        description: Unique identification
      address:
        type: string
        description: Address of the location

Which results in the below rendering in swagger-editor.
{
  "locations": [
    {
      "links": [
        {
          "rel": "string",
          "href": "string",
          "types": [
            "string"
          ],
          "methods": [
            "OPTIONS"
          ]
        }
      ],
      "name": "string",
      "id": "string",
      "address": "string"
    }
  ]
}

Instead is there a way to add the Links section as the last part of content. E.g.
{
  "locations": [
    {
      "name": "string",
      "id": "string",
      "address": "string",
      "links": [
        {
          "rel": "string",
          "href": "string",
          "types": [
            "string"
          ],
          "methods": [
            "OPTIONS"
          ]
        }
      ]
    }
  ]
}

We will be closing this issue since the code generation includes the details. Feel free to reopen this issue if face any issues.


Improve iOS permission handling in Herald demo app

[Who] As a Herald based app developer
[What] If I choose to use iOS Location, I would like a full fledged example of request Location Permissions from the user
[Value] In order to make my steps as an application developer easier
This is due to a usability issue around Location permission with 'always allow' not being an option in the initial permission UI on iOS.
For an example of checking status and request exact permission see this discussion: https://developer.apple.com/forums/thread/117256
Note: Location permission on iOS IS NOT REQUIRED by Herald and is not enabled as part of our routine efficacy tests. The AwakeSensor is optional.

@marcuspridham This is the permission improvement I was talking about today.

@marcuspridham This is the permission improvement I was talking about today.


icon files

i created some images that might work as icons for you. there's a json and a json pretty in 16*16, a transparent version and black bg version of each.
json.zip

These look fantastic! Let me get to work on this


Fix test_code_eT_zhz.py speed

See issue #77

Hmmm it seems we don't have full coverage after decreasing the projector and eT down to 4th order from 6th order?

Another thing to consider is adding left hand side testing for latex_eT_zhz.py specifically around lines:

1500
1515
1565
1586
1628
2071
2107
2234

After my last push d154b784b57268cdd4b20b07037d87f20d5d00d1 the code coverage is back up to 99.33.
Unfortunately I don't know if there is a way to get the codecov bot to make a new comment.


Width to wide

Probably caused by the annotation/POI icon the width is wider than the screen causing an unnecessary scrollbar.

fixed. may need to properly check sometime in the future for different browsers/res.


Enforcing FTPS only or disabling FTP is not possible through the portal for Function Apps

This advice is used by Microsoft Defender for Cloud (see screenshot), but the "General settings" tab is not available in function apps. Outside of using IaC (ARM, Bicep or Terraform) you can only set this option in Function Apps using Azure CLI: az functionapp config set ...  --ftps-state FtpsOnly

Suggested documentation: provide Azure CLI or Powershell Azure module workaround for Function App.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: d0017c1a-b2d8-9fc2-1fcc-411282772be1

Version Independent ID: b1fba8cf-6ce6-4148-fb06-47a072c06e60

Content: Security recommendations - Azure App Service

Content Source: articles/app-service/security-recommendations.md

Service: app-service

GitHub Login: @msmbaldwin

Microsoft Alias: *mbaldwin

@booyaa, Thanks for the feedback! We are taking a look into this and will get back to you soon.

@AjayKumar-MSFT I don't have that dialogue on my function app.

booyaa, Apologies for the delay.  'General setting' tab is not available in Linux Consumption Function App. (screenshot below). See-  'Not all App Service features are available when a function app runs on the Consumption hosting plan.'
You may try to configure FTPs setting via Azure CLI/ PowerShell and for additional info on Functions app-settings.  Thanks again for your feedback on this.

booya, Hope the above answer helps clarify. Since it's not doc specific feedback, we will close this thread for now.


Only first hook triggers

Description
Seems like new hook system disallows to have multiple hooks attached to same event. Current implementation fires only first assigned hook.
To Reproduce
Add two hooks for the same event. Fire the event. Only first one would actually triggered.
Expected behavior
All defined hooks should trigger.
Details

Affected Component: Hooks Manager
Hypervisor: LXD
Version: 5.10.3

Seems like Hooks manager was implemented without such behavior in mind.
First of all, hook to trigger is got by get_hook
    # Returns a hook by key
    def get_hook(type, key)
        @hooks[type.downcase.to_sym][key]
    end

Ok, let's find out what would we get here
        hook_pool.each do |hook|
            hook.extend(HEMHook)

            if !hook.valid?
                @logger.error("Error loading hooks. Invalid type: #{hook.type}")
                next
            end

            key = hook.key

            @hooks[hook.type][key] = hook
            @hooks_id[hook.id]     = hook
            @filters[hook.id]      = hook.filter(key)
        end

Simple, if key already exists, the value would be rewritten by latter iteration. So ok, maybe key is somewhat unique?
    # Generates a key for a given hook
    def key
        begin
            case type
            when :api
                self['TEMPLATE/CALL']
            when :state
                "#{self['TEMPLATE/RESOURCE']}/"\
                "#{self['TEMPLATE/STATE']}/"\
                "#{self['TEMPLATE/LCM_STATE']}"
            else
                ''
            end
        rescue StandardError
            ''
        end
    end

So, the packaged implementation of the hooks manager is simply broken.

Fix is kind of straightforward
--- onehem-server.rb    2020-03-30 22:53:12.759085714 +0000
+++ /usr/lib/one/onehem/onehem-server.rb        2020-03-30 22:32:08.000000000 +0000
@@ -276,7 +276,8 @@

             key = hook.key

-            @hooks[hook.type][key] = hook
+            @hooks[hook.type][key] = []          unless @hooks[hook.type].key?(key)
+            @hooks[hook.type][key].push(hook.id) unless @hooks[hook.type][key].include?(hook.id)
             @hooks_id[hook.id]     = hook
             @filters[hook.id]      = hook.filter(key)
         end
@@ -300,7 +301,8 @@
         key    = hook.key
         filter = hook.filter(key)

-        @hooks[hook.type][key] = hook
+        @hooks[hook.type][key] = []          unless @hooks[hook.type].key?(key)
+        @hooks[hook.type][key].push(hook_id) unless @hooks[hook.type][key].include?(hook_id)
         @hooks_id[hook_id] = hook
         @filters[hook_id]  = filter

@@ -312,7 +314,8 @@
     def delete(hook_id)
         hook = @hooks_id[hook_id]

-        @hooks[hook.type].delete(hook.key)
+        @hooks[hook.type][hook.key].delete(hook_id)
+        @hooks[hook_type].delete(hook.key) if @hooks[hook_type][hook.key].empty?
         @filters.delete(hook_id)
         @hooks_id.delete(hook_id)
     end
@@ -323,7 +326,7 @@
     end

     # Returns a hook by key
-    def get_hook(type, key)
+    def get_hooks(type, key)
         @hooks[type.downcase.to_sym][key]
     end

@@ -537,11 +540,14 @@
                 end

                 content   = Base64.decode64(content)
-                hook      = @hooks.get_hook(type, key)
+                hooks     = @hooks.get_hooks(type, key) || []

                 body = Nokogiri::XML(content)

-                @am.trigger_action(ACTIONS[0], 0, hook, body) unless hook.nil?
+                hooks.each do |hook_id|
+                    hook = @hooks.get_hook_by_id(hook_id)
+                    @am.trigger_action(ACTIONS[0], 0, hook, body) unless hook.nil?
+                end

                 reload_hooks(key, body) if UPDATE_CALLS.include? key
             when :RETRY
@@ -576,7 +582,7 @@
         params = hook.arguments(event)
         host   = hook.remote_host(event)

-        @logger.info("Executing hook for #{hook.key}")
+        @logger.info("Executing hook #{hook.id} for #{hook.key}")

         rc = nil

@@ -592,9 +598,9 @@
         end

         if rc.code.zero?
-            @logger.info("Hook successfully executed for #{hook.key}")
+            @logger.info("Hook #{hook.id} successfully executed for #{hook.key}")
         else
-            @logger.error("Failure executing hook for #{hook.key}")
+            @logger.error("Failure executing hook #{hook.id} for #{hook.key}")
         end

         xml_out = build_response_body(params, rc, host, hook.remote?, false)

duplicated: https://github.com/OpenNebula/one/issues/4128
@divanikus wouldn't you like to prepare PR?

Hello @divanikus,
As @kvaps said this issue is duplicated (https://github.com/OpenNebula/one/issues/4128). If you are interested in submit a PR with your changes we'll be very glad to review it.

@kvaps @christian7007 Submitted the PR.

Nice! I'll take a look at it.


Upgrade to LLVM 10

(Forgot to mention the reasoning, Rust 1.45 is using LLVM 10 now which is the merge commit from this PR)
The code change should be trivial.
I think we might want to clean up the README a bit, for Ubuntu dependencies:

Don't think we need curl wget or gnupg2 at all?
Don't think we need ca-certificates-java either?
It seems libelf is enough (I just realized I didn't have libelf-dev - though installing it doesn't solve the load issue I have, and it certainly didn't affect cargo bpf build)
zlib1g is needed (forgot about the error message but it's the first error I hit when running cargo bpf build)
linux-headers need to pick an explicit version, otherwise apt (apt-get too) complains E: Package 'linux-headers' has no installation candidate

It might also be related to Ubuntu releases, I'm running on 20.04 (Desktop).

Thanks! I'll take a look soon, I'll rebase my related changes on top of this.

This is great, thank you!
I'm wondering if it's worth making this change backwards compatible, or should we enforce a hard dependency on LLVM10. It looks like Bionic and newer Ubuntu versions have a proper llvm-10 in the repo, and Arch already packages LLVM9 as llvm-9, so if we adjust the CI, there should be little impact in moving forward, and we don't want to support older Fedora anyway.

I've tested this PR together with https://github.com/redsift/redbpf/pull/67 and things do work again with stable rust.
Keeping backwards compatibility isn't worth it since we operate on LLVM bitcode which isn't stable, so for things to work we must use the same LLVM version used by rustc which at the moment is 10.
The only thing that's missing to merge this is changing the CI images to install llvm-10 instead of llvm-9.

Can confirm adding #67 works :)

changing the CI images to install llvm-10 instead of llvm-9

While you're at it, can you also take a look at other dependencies? I'll follow up in this PR to further cleanup the dependencies list if you let me know the minimum set required.

We have some CI issues at the moment I'll need to take a look at. Thanks both for the contribution, I'll merge #67 along with this.


DSERV-164 load DepMap gene-term links

Adapter for loading gene-term edges from DepMap collection

Apart from the possible duplication, the code looks good. One thing to make it better: for the mapping files, you can save them as pickle files then you can load and use them directly, you don't have to make a dict before using them in this way. Also you can include the script for making gene symbol to gene id mapping in the scripts folder so we have a reference how the mapping is generated.

Thanks for the suggestion! I'll make the gene mapping file as pkl then. The model file was downloaded directly from their portal, so I won't change that. Will also include the mapping script.


Including Layout as an option

I am working on a small app that is utilizing this Meteorite package. The one problem I am running into is the ability to set the Layout file that should be used by the sign-in route. I am using the {{> yield }} functionality that iron-router offers and so when a user hits the sign-in path, some elements from my main layout show up.

+1


Add programme for Day 1 of the 2018 Users Meeting

To test

[ ] Times/Affiliations
[x] Initial description should be removed in favor of the schedule

Outside this PR

[ ] create placeholders on downloads.oo.org for Lightning Talks & Posters

Looks good, thanks


Some issues

fixed issue with inability to find test video in tests
error handling on audio_extraction.py

@hcm444 don't see the update that you done on speech_recognition.py file

oops


Sharing is Caring Power App Sample

[x] New sample?
What's in this Pull Request?
Power Apps Calendar Component

woot woot @zollingerc !  Great work!

woot woot @zollingerc ! Great work!

 I appreciate all the time and effort you put in to these!


learner cannot be exported after calling get_preds unless reorder is set to false

Hi there, forgive me if this is not actually undesired behaviour.
I have a dataloader and a learner object defined like so:
dls_cl = TextDataLoaders.from_df(
    df_train,
    text_col='text',
    label_col='topic',
    valid_pct=0.1
)

learn = text_classifier_learner(
    dls_cl,
    AWD_LSTM,
    opt_func=ranger,
    metrics=[accuracy]
)

If I run learn.export('my_model.pkl') at this point it works perfectly. However, if I run
test_dl = dls_cl.test_dl(df_test)
preds, _ = learn.get_preds(dl=test_dl)

before exporting I get this error:
---------------------------------------------------------------------------
AttributeError                            Traceback (most recent call last)
<ipython-input-79-7ebf74a309c8> in <module>
----> 1 learn.export('my_model.pkl')

~/Documents/fastai2/fastai2/learner.py in export(self, fname, pickle_protocol)
    502         #To avoid the warning that come from PyTorch about model not being checked
    503         warnings.simplefilter("ignore")
--> 504         torch.save(self, self.path/fname, pickle_protocol=pickle_protocol)
    505     self.create_opt()
    506     if state is not None: self.opt.load_state_dict(state)

~/.pyenv/versions/py374/lib/python3.7/site-packages/torch/serialization.py in save(obj, f, pickle_module, pickle_protocol, _use_new_zipfile_serialization)
    326
    327     with _open_file_like(f, 'wb') as opened_file:
--> 328         _legacy_save(obj, opened_file, pickle_module, pickle_protocol)
    329
    330

~/.pyenv/versions/py374/lib/python3.7/site-packages/torch/serialization.py in _legacy_save(obj, f, pickle_module, pickle_protocol)
    399     pickler = pickle_module.Pickler(f, protocol=pickle_protocol)
    400     pickler.persistent_id = persistent_id
--> 401     pickler.dump(obj)
    402
    403     serialized_storage_keys = sorted(serialized_storages.keys())

AttributeError: Can't pickle local object 'Learner.get_preds.<locals>.<lambda>'

I know that that pickle cannot work with lambda functions and looking around similar issues I believe this may be related to the sampling method used by get_preds. Furthermore, I can avoid the problem by passing reorder=False to get_preds.
This may be normal and expected given pickle's restrictions but I thought I would flag it up just in case!

Ah thanks for flagging this. Don't know why the Learner was retaining a reference to that lambda function but removed the lambda function which solves the issue.

No problem!


Warning when loading driver using thread context ClassLoader

Environment
HikariCP version: 3.3.1
JDK version     : 1.8.0_201
Database        : Any database

When a driver class is not available to the DriverManager the thread context class loader is used, and that is great!
However an annoying warning is logged.
Registered driver with driverClassName=whatever.driver.class.name.here was not found, trying direct instantiation. [com.zaxxer.hikari.util.DriverDataSource]
It seems the warning was left in the code for com.zaxxer.hikari.util.DriverDataSource when implementing support for using the thread context class loader in https://github.com/brettwooldridge/HikariCP/issues/878 and https://github.com/brettwooldridge/HikariCP/issues/982

Agree the code is following
LOGGER.warn("Registered driver with driverClassName={} was not found, trying direct instantiation.", driverClassName);             Class<?> driverClass = null;             try {                driverClass = this.getClass().getClassLoader().loadClass(driverClassName);                LOGGER.debug("Driver class found in the HikariConfig class classloader {}", this.getClass().getClassLoader());             }
which meens we have a warning while things are working as expecte id the driver is found with direct instanciation, the message should be logged as debug similarly to "Driver class found in ...."


a template to create an or_lang semi ring

Review, but DO NOT MERGE This requires https://github.com/awalterschulze/regex-reexamined-coq/pull/156 to merge this. Let me worry about doing it in the right order.
This creates a template for an or_lang semi ring.
It is not as powerful as a orb semi ring, probably because I can't think how we would be able to prove decidable
forall b1 b2:lang, lang_eq b1 b2 = true -> b1 = b2.
But otherwise it helps for some proofs.
When everything is uncommented and the proofs are admitted, the semi ring does help to prove the proofs that have tactics that are commented.

Discussed offline: merging now and will post review

Discussed offline: merging now and will post review


tdesktop-beta: init at 3.6.0 & tdesktop: fix executable path for shortcuts

Description of changes
tdesktop: fix executable path for shortcuts
Which allows autogenerated .desktop files for mime defaults keeping right path
Also in tdesktop fixed some small things
tdesktop-beta: init at 3.6.0

Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[x] Tested basic functionality of all binary files (usually in ./result/bin/)
22.05 Release Notes (or backporting 21.11 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module
[ ] (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes

[x] Fits CONTRIBUTING.md.

This says init at 3.6.1, but 4.3.1 (non-beta) is already in unstable. Can this be closed?


Mongo Shell extension repeatedly dowloads installer

Type: Bug
I've updated to the newest version of ADS . I just connected to a Mongo cluster by using the provided Mongo settings window . When I click on Open Mongo Shell the download process is looping, repeatedly Downloading the MongoShell see the log (truncated)
Installing MongoShell to .azuredatastudio\extensions\microsoft.azure-cosmosdb-ads-extension-0.3.3\local-resources\v0.3.0\mongoshell\Windows
Downloading https://github.com/Azure/azure-cosmosdb-ads-extension/releases/download/v0.3.0/mongoshell-1.6.0-win32-x64.zip
(34,679 KB)Downloading https://github.com/Azure/azure-cosmosdb-ads-extension/releases/download/v0.3.0/mongoshell-1.6.0-win32-x64.zip
(34,679 KB)Done installing MongoShell
Installing MongoShell to .azuredatastudio\extensions\microsoft.azure-cosmosdb-ads-extension-0.3.3\local-resources\v0.3.0\mongoshell\Windows
Done installing MongoShell
Installing MongoShell to .azuredatastudio\extensions\microsoft.azure-cosmosdb-ads-extension-0.3.3\local-resources\v0.3.0\mongoshell\Windows
Downloading https://github.com/Azure/azure-cosmosdb-ads-extension/releases/download/v0.3.0/mongoshell-1.6.0-win32-x64.zip
(34,679 KB)Downloading https://github.com/Azure/azure-cosmosdb-ads-extension/releases/download/v0.3.0/mongoshell-1.6.0-win32-x64.zip
(34,679 KB)Done installing MongoShell
Azure Data Studio version: azuredatastudio 1.44.1 (https://github.com/microsoft/azuredatastudio/commit/8f53a316fa00a98264f1ab119641cd540b5af25c, 2023-06-01T02:12:48.765Z)
OS version: Windows_NT x64 10.0.22621
Restricted Mode: No
Preview Features: Enabled
Modes:
System Info
Item	Value
CPUs	Intel(R) Core(TM) i7-1065G7 CPU @ 1.30GHz (8 x 1498)
GPU Status	2d_canvas: enabled
canvas_oop_rasterization: disabled_off
direct_rendering_display_compositor: disabled_off_ok
gpu_compositing: enabled
multiple_raster_threads: enabled_on
opengl: enabled_on
rasterization: enabled
raw_draw: disabled_off_ok
skia_renderer: enabled_on
video_decode: enabled
video_encode: enabled
vulkan: disabled_off
webgl: enabled
webgl2: enabled
webgpu: disabled_off
Load (avg)	undefined
Memory (System)	31.60GB (13.75GB free)
Process Argv
Screen Reader	no
VM	0%
Extensions (15)
Extension	Author (truncated)	Version
admin-pack	Mic	0.0.2
agent	Mic	0.49.0
arc	Mic	1.8.0
azcli	Mic	1.8.0
azure-cosmosdb-ads-extension	Mic	0.3.3
azuredatastudio-dma-oracle	Mic	4.1.2
azuredatastudio-oracle	Mic	0.1.3
azuredatastudio-postgresql	Mic	0.3.1
dacpac	Mic	1.13.0
import	Mic	1.5.5
net-6-runtime	Mic	1.1.0
profiler	Mic	0.12.2
schema-compare	Mic	1.19.0
sql-assessment	Mic	0.6.4
sql-database-projects	Mic	1.1.1

Hi @languy This log was produced in the  command output from VS Code, just as soon as I click the "Open Mongo Shell" botton. I've only clicked it once ,so there's no possibility that I've incurred in multi execution. I've only removed the full path from the log. It continues forevever and it effectively donwloads the installer and decompres it,  proceeding with the installation. When the command outpout is closed no more lines are generated. I will try with the new version and I agree it can be a permission issue . Have you tested it on Windows_NT x64 10.0.22621 ? Thanks

On the logs: you can open the developer console log and see if there is any error (in red). Hit Ctrl-Shift-P and type "Toggle developer tools". Then click on the "Console" tab.
Yes, I have tested on the same version Windows build (10.0.22621) and ADS version as well (1.44.1).


Custom language settings do not save correctly (D&D 5e 2.3.1, Foundry v11)

Describe the bug
Language Settings do not show up correctly.
To Reproduce
Steps to reproduce the behavior:

Open up Language Settings on Polyglot
Expected behavior
The languages should be appearing in the 'languages' column.

Screenshots

D&D 5e 2.3.1, Foundry v11
Polyglot Version 2.1.6
Are you using Babele? No

Scroll to the bottom of the Language Settings, click on "Reset Defaults" and it should fix this.

So that seemed to work initially, but now it's not saving my fonts for the various custom languages I have after reloading foundry.

I've imported custom fonts made in base foundry.

Setting up languages and hitting save:

After reloading, the fonts are jumbled about and still don't show up in chat:

I've tried reloading, I've tried restarting the ForgeVTT server I use, nothing seems to work.

I am also experiencing this defect in the same manner.

Thanks for the detailed info. Version 2.1.7 should have fixed this issue for Custom Languages. Try it out and let me know if anything is still wrong.

I still seem to be getting similar issues. Though there is one thing I've noticed here.
Before reloading:

After Reloading:

I'm noticing that it almost seems like certain blocks of fonts are being "shifted up" a couple of notches. They're in sync with Aquan, Auran, and Blacktongue, but it's like it's missed Deep-speech in the fonts, and carries on with an offset of 1. Demonic, Djoran, Draconic, etc, right up until it gets to Under-tongue, which is once again missing from the fonts.
Here's what I have for my custom fonts:
Aquan,Auran,Black-tongue,Deep-speech,Demonic,Djoran,Draconic,Druidic,Dwarven,Giant,Goblin,Halfling,Ignan,Infernal,Nidean,Nioban,Orcish,Panji,Rat-tongue,Serpentongue,Sylvan,Tahosian,Terran,Thieves-Cant,Trade-tongue,Under-tongue,Vaskarran

Trade-tongue has been set as my default language.

That desync is really weird. I couldn't get to reproduce it.
I need some info:

How many modules are you using? I've troubleshot issues with desyncs before that were caused by using a lot of modules (100+)
Can you open your browser's console (F12 -> Console tab), input game.settings.get("polyglot", "Languages") and send the object it returns? It'll look like {aquan: { font: ..., rng, label }, etc

Might be better if you save it as a text file and upload it here

I am currently running 150 active modules
Languages.txt

Can you test this with fewer active modules or even a brand new world? I think it's a desync issue.
Also, try it on Polyglot 2.1.9, it should load faster and might fix this issue.

I've attempted to activate the 2.1.9 version of this module on a fresh testing world with only it and libWrapper active, and I'm still getting similar issues. Custom languages don't seem to register with different fonts.

Can you try it on <IP_ADDRESS> now? I finally got to reproduce the issue and I think I found a fix.

I'm not sure what you did, but that seems to have fixed a lot of my issues! Thank you so much!
One more issue I seem to be having is that it's not registering the default language.

Or maybe it is and I'm not sure if displaying the translation for the default language is intentional or not.
Would it be possible to have an option to block the translation for the default language?

You were right, it wasn't working correctly. It should be fine on the latest release.

That's fixed it!
Thank you for being so dilligent with the fixes. Polyglot now works like a charm for me!


[DRAFT]: Define Pipelines and Components with simple syntax for common use case of PrimeQA library

Pull Request
What does this PR do?
Closes #331
Notes:

Replace (issue) above ↑↑↑ with the issue this PR closes to automatically link the two.
This must be done when the PR is created.
Add multiple Closes #(issue) as needed.
If this PR is work towards but does not close an issue, simply tag the issue without mentioning Closes.

Description
Describe the changes proposed by this PR below to give the reviewer context below ↓↓↓

Define Component classes for different type of functionalities.
Components are combined to form a pipeline based on use case.

Request Review
Be sure to request a review from one or more reviewers (unless the PR is to an unprotected branch).
Versioning
When opening a PR to make changes to PrimeQA (i.e. primeqa/) master, be sure to increment the version following
semantic versioning.  The VERSION is stored here
and is incremented using bump2version {patch,minor,major} as described in the (development guide documentation)[development.html].

[ ] Have you updated the VERSION?
[ ] Or does this PR not change the primeqa package or was not into master?

After pulling in changes from master to an existing PR, ensure the VERSION is updated appropriately.
This may require bumping the version again if it has been previously bumped.
If you're not quite ready yet to post a PR for review, feel free to open a draft PR.
Releases
After Merging
If merging into master and VERSION was updated, after this PR is merged:

[ ] Create a release from the master with version equal to VERSION
[ ] Not merging to master or VERSION not updated

Checklist
Review the following and mark as completed:

[ ] Tag an issue or issues this PR addresses.
[ ] Added description of changes proposed.
[ ] Review requested as appropriate.
[ ] Version bumped as appropriate.
[ ] New classes, methods, and functions documented.
[ ] Documentation for modified code is updated.
[ ] Built documentation to confirm it renders as expected (see here).
[ ] Code cleaned up and commented out code removed.
[ ] Tests added to ensure all functionalities tested at >= 60% unit test coverage (see here).
[ ] Code cleaned up and commented out code removed.
[ ] Release created as needed after merging.

@bhavani105 We can track and comment on the work related issue #331 in this PR.
@franzmpub We will need to add DPR component to complete dense retriever components list.


Method Override support

Would it be possible to add method override support?  E.g., POST /foo with _method=DELETE?  I can try adding the feature if you think it's a good idea.  Or if there's some other existing solution I've overlooked, please let me know.
Thanks,
Bryan

Thanks Mike.  The problem with that approach is that it's usually a POST that has the _method=DELETE/PUT as a body param.  But it doesn't seem possible to access the POST body in a pre call.  Maybe I'm wrong though and am just seeing where.

Oh you want it from the body?  Well, you could parse the body in the pre chain as well, but that seems ugly.
I guess I'd flip this a little bit and ask if you really need to do it that way?  I.e., passing it as a query param is easy.
If neither of those work, then no there's not really a way to do it (and I'm not sure I would want to flip everything around to support that - it's a design choice that restify "errors out" quickly when a user sends a request that doesn't have a corresponding route - here we'd have to always do all possible work to enable that).

Yeah, I headed down the path of parsing the body in a pre, which led me to refactor the body parsing logic into its own module, so it's shared by the json parser and the form parser modules.  See: https://github.com/BryanDonovan/node-restify/commit/6991379cd757b51445eb1874c07b654eeac89510 .. might be something to pull in anyway to remove some of that duplicate logic (I'm not sure about some of my method names, and I used a different style than you.. sorry.. I can change that if you want :)).
But when I tried setting up a methodOverride pre chain, I realized what you're saying.. restify checks the route before it hits the methodOverride pre chain.
However, what about supporting a X-HTTP-Method-Override header?
I hate these override hacks myself, but we have clients that use them (something we could potentially change).  I'm just trying to port over code from Express, where we had used methodOverride.  We probably could use a query param named "_method" as well.  I think the X-HTTP-Method-Override would be better though.

Nevermind.. I finally get it.  I've been trying to make (and assuming) plugins act like 'pre' functions.  It's easy enough to implement a pre function for the X-HTTP-Override header.

Ok awesome :)
Yeah, if you're fine with a query parameter or a header this is a a
lot easier.  It was specifically the body that's going to be tough if
you needed to do that.   Sounds like you're good to go then?
On Sat, Mar 3, 2012 at 1:00 PM, Bryan Donovan
<EMAIL_ADDRESS>wrote:

Nevermind.. I finally get it.  I've been trying to make (and assuming) plugins act like 'pre' functions.  It's easy enough to implement a pre function for the X-HTTP-Override header.

Reply to this email directly or view it on GitHub:
https://github.com/mcavage/node-restify/issues/90#issuecomment-4304565

Yep, think I'm good to go, at least for now.  Thanks for the help!


Remove queue system

Since the service is running on Miarka now we don't need to run jobs one at a time anymore and can let Slurm handle the job queue for us instead. This PR removes the queue system from the service and let jobs run asynchronously.

Getting the tests to work was trickier than I expected. And running them on GitHub is not entirely deterministic (run some twice, failed once, succeeded once :shrug: ) But it seems to work now. In the end I decided on running the test profile of seqreport instead of mocking it, it doesn't take that long and I think it will offer better bug detection.


[#1798] Membership name, default organisation

This addresses feedback from @maneesha on how consortium memberships are handled. See #1798 for reference.
Fixes #1798.

Since it's Sunday, I expect to not receive Code Review., so I will probably have to push this code to a branch in carpentries/amy repo so that I can deploy TEST AMY later today.

@lauryndbrown please re-review this one, I provided changes you requested and some explanations.


Fix PHPDoc

@use is used in psalm/phpstan for generic traits: https://psalm.dev/docs/annotating_code/templated_annotations/#template-inheritance

Pull Request Test Coverage Report for Build 654635401

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 100.0%

Totals

Change from base Build 652726001:
0.0%

Covered Lines:
2809

Relevant Lines:
2809

💛  - Coveralls

Hey @b1rdex, thank you for the PR; but i want to understand the reason behind it, we use @use in multiple places, not just here, so if we are replacing it, we should replace it everywhere.
does phpstan complain about this? as psalm doesn't seem to do that currently.

I think this is a bug introduced during refactoring. Check out the full commit diff that brought the @use.
Also, there is no point in replacing @see with @use as it isn’t supported by phpstorm or any other phpdoc reader.
Отправлено с iPhone

16 марта 2021 г., в 12:53, Saif Eddin Gmati @.***> написал(а):

Hey @b1rdex, thank you for the PR; but i want to understand the reason behind it, we use @use in multiple places, not just here, so if we are replacing it, we should replace it everywhere.
does phpstan complain about this? as psalm doesn't seem to do that currently.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or unsubscribe.

@b1rdex can you please rebase this on 1.6.x and replace all other use cases of @use by @see?

@azjezz I don't see any other @use usages. Could you please verify?

correct, i think we are already using @see everywhere else.
thank you 👍


Load balancer issue: helm.elastic.co is missing 7.13.0 charts?

Chart version: 7.13.0
Helm Version: v3.6.0
Describe the bug:
All 7.13.0 charts are missing from index:  https://helm.elastic.co/index.yaml "sometimes". It looks an issue with HTTP load balancer:
curl -sL https://helm.elastic.co/index.yaml -I > /dev/null | grep "content-length"     ## OK !
x-goog-stored-content-length: 141600
content-length: 141600

curl -sL https://helm.elastic.co/index.yaml -I > /dev/null | grep "content-length"    ## Missing 7.13.0 charts
x-goog-stored-content-length: 138044
content-length: 138044

Steps to reproduce:
Try with curl.
Expected behavior:
Helm should get always all elastic charts.

Sorry for the trouble!
I cannot reproduce it right now (or any more) and 2 other colleagues couldn't either. Is it still an issue for you?
Reproducing and disappearing caching or toggling LBs are always a "joy" to debug...

Yeah!
I can confirm this is working fine now. Took me a few hours to figure out "helm dep build" errors was due to this!
As a workaround, I have edited manualy the index.yaml file and store it on google cloud.


Implement write the one page token to the google sheet and specify columns.

Need to be refactored.


Cannot install elvis

I read instruction and expected that after git clone and rebar3 compile elvis is added to bin and can be used with elvis rock in any place in system. Am I wrong?
After git clone -> cd elvis -> rebar3 compile elvis is not available to use in system.
It can be used only if I call rebar3 escriptize and add generated escript to PATH manually.
System: Ubuntu 22.04.

Yeah, the README is probably misleading. To use the application, you have to git clone it, rebar escriptize it, and put the generated binary in your system PATH. (this is also mentioned, but below section "Installation")

I'm gonna pull request to tweak the README so stuff's made clearer. For the time being I'm closing this issue as you've found the solution yourself and I just confirmed it 😄


Failing tests in webkit browser

Description
This is in relation to this failing action caused by #93 from @EspiraMarvin
Going through the logs this is not caused as a result of webkit timeout due to waiting for scrolling event, the scrolling event succeeds. what is timing out is the locator.click event
Digging into it and running the tests locally in debug mode I found out the discrepancy.
This part of the log: selector resolved to hidden See More
Not sure why webkit is marking it as hidden. This doesn't happen on local either so hard to catch it
Playwright will throw a TimeoutError when element is not visible. More here
Screenshots
No response
Additional information
No response

Interestingly, the test went through when I merged the PR (run) even though Marvin had raised the fact that it didn't work on safari.
I opened a PR where I made an adjustment to get the page from the context. That alone did not fix it though. I ended up updating playwright and giving the test a larger timeout on webkit to prevent it from timing out.
Node.js 12 actions are deprecated, I updated actions/checkout, actions/setup-node, actions/upload-artifact to v3.
@nyandika Kindly have a look at the PR.


IGNITE-22349 .NET: Add compute task session support

Add compute task session support to .NET. This allows the user to change the priority of a compute job via grid.task.priority attribute (see docs).
The new injectable .NET IComputeTaskSession has existing Java counterpart ComputeTaskSession and supports only the SetAttributes method. It does not support the rest of the Java API since only
the SetAttributes is required to address IGNITE-22349. The GetAttribute method was added to allow creating
automated tests.
Changes:

The new IComputeTaskSession interface supports the SetAttributes and GetAttribute operations with the same
signature as their Java ComputeTaskSession counterparts.

The ComputeTaskSession implementation delegates operations to the Java side via PlatformJniTarget, which
receives the unmanaged session pointer in the JNI ComputeTaskMap and ComputeJobExecute callbacks.
On the Java side the new PlatformComputeTaskSession class receives the JNI calls and delegates operations to
wrapped ComputeTaskSession.
The ComputeTaskSession on the Java side in injected into PlatformFullJob or PlatformFullTask. At first glance
the injection might seem slow. However injectors are cached so subsequent injections would be as fast as setting the
field directly. The alternative approach to pass ComputeTaskSession directly to the PlatformFullJob and
PlatformFullTask constructors seems to required lots of code changes.

The new .NET ComputeTaskSessionFullSupportAttribute explicitly enables the compute session attributes API in the
same way the Java's ComputeTaskSessionFullSupport annotation does. This flag is passed to Java as the Execute JNI operation parameter and stored in the PlatformFullTask.
The new .NET TaskSessionResourceAttribute injects the IComputeTaskSession into implementations of IComputeTask and IComputeJob.
Added automated tests for distributing session attributes on the same and different nodes.
Documentation: added new "C#/.NET" tab in the MyUrgentTask code snippet in the Priority Ordering section.

@ptupitsyn , @shishkovilja , I addressed your code review comments and also fixed some C++ code that I forgot to initially change and that caused some C++ test failures. Could you please take another look and approve the PR if you have no other comments. Thank you!

@ptupitsyn , thank you for the veview. Would you be willing to merge the changes please?

@kukushal , @ptupitsyn , guys, it seems, that build was broken by this PR. I have failed a ticket in order to fix poblem: https://issues.apache.org/jira/browse/IGNITE-22586


ok this is the second time I've made this request the docs do not seem correct.

Ok according to docs about comparing mfa cloud vs mfa server it states that mfa cloud supports custom greetings but its not working for us, is the doc correct in that it should work and that something else is going wrong or what? thanks

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 56319b59-e0f6-f0a7-c853-99cebcb5711a
Version Independent ID: d9e50b54-3eee-d0cf-5fcf-706e06b94fab
Content: Configure Azure Multi-Factor Authentication
Content Source: articles/multi-factor-authentication/multi-factor-authentication-whats-next.md
Service: multi-factor-authentication
GitHub Login: @MicrosoftGuyJFlo
Microsoft Alias: joflore

@rothtony Thanks for your feedback! We will investigate and update as appropriate.

@rothtony as an FYI you can reopen an issue that was closed if you do not feel the answer provided as sufficient. I will close this out as a duplicate and lets continue to discuss on the original as it has more context :)
Duplicate of #5362


improve NavbarTab font color

before:

after:

@naiba Hi, thank you for the PR. Please allow edits from maintainers for this PR/fork. I want to make additional changes and improve the overall dark theme support for split mode, and then we can merge it. 🙂

@naiba Hi, thank you for the PR. Please allow edits from maintainers for this PR/fork. I want to make additional changes and improve the overall dark theme support for split mode, and then we can merge it. 🙂

I'll reopen this PR


Handle sourcemaps when publicUrl is used

I recently introduced a change in broccoli-uglify-sourcemap that allows specifying a publicUrl in sourcemaps. However, since the regex used only checks for sourceMappingUrl= followed by the name of the sourcemap itself, it will not get fingerprinted.

why do you not use the prefix thing from the asset rewriter directly instead of the publicUrl option of uglify?

I hope you are talking about the prepend option. We cannot use it because it will add the URL to every single asset which is not what we want. publicUrl adds it only to sourcemaps.

A gentle reminder @Turbo87...


feature: add Dockerfile of dfclient

Signed-off-by: Starnop<EMAIL_ADDRESS>
Ⅰ. Describe what this PR did
As title described.
Ⅱ. Does this pull request fix one issue?

fixes part of #206
Ⅲ. Why don't you add test cases (unit test/integration test)? (你真的觉得不需要加测试吗？)
I have tested on my VM.
Ⅳ. Describe how to verify it

enter the root directory of project
docker build image

# docker build -t dfclient .
Sending build context to Docker daemon  2.048kB
Step 1/7 : FROM golang:1.10
 ---> 3c65b5659316
Step 2/7 : WORKDIR /go/src/github.com/alibaba
 ---> Running in 7de52b261ba8
Removing intermediate container 7de52b261ba8
 ---> 3923ed8d67b9
Step 3/7 : RUN git clone https://github.com/alibaba/Dragonfly.git     && cd Dragonfly && ./build/build.sh client
 ---> Running in 0643415dbad9
Cloning into 'Dragonfly'...
=====================================================================
BUILD(dfdaemon&dfget): compiling dfdaemon and dfget...
install home: /root/.dragonfly
link /tmp/dragonfly/build/src/github.com/alibaba/Dragonfly -> /go/src/github.com/alibaba/Dragonfly
PRE: clean and create /tmp/dragonfly/build/bin
CHECK: gofmt, check code formats
CHECK: install golint
CHECK: golint, check code style
CHECK: go vet, check code syntax
BUILD: dfdaemon
BUILD: dfget-go
INSTALL: /root/.dragonfly/df-client
delete /tmp/dragonfly/build
BUILD(dfdaemon&dfget): SUCCESS
Removing intermediate container 0643415dbad9
 ---> 526bf59bf34b
Step 4/7 : ENV PATH=$GOPATH/bin:/root/.dragonfly/df-client:$PATH
 ---> Running in 7499cd087a47
Removing intermediate container 7499cd087a47
 ---> be6b436adad6
Step 5/7 : WORKDIR /root/.dragonfly/df-client
 ---> Running in 1d12b531d3d2
Removing intermediate container 1d12b531d3d2
 ---> 691ffdeba5e7
Step 6/7 : EXPOSE 65001
 ---> Running in 626233e3b072
Removing intermediate container 626233e3b072
 ---> 812686367d5d
Step 7/7 : ENTRYPOINT ["./dfdaemon", "--dfpath=./dfget-go"]
 ---> Running in 33d77cdfd69e
Removing intermediate container 33d77cdfd69e
 ---> 3591b13498cf
Successfully built 3591b13498cf
Successfully tagged dfclient:latest

docker images

# docker images
REPOSITORY          TAG                 IMAGE ID            CREATED              SIZE
dfclient            latest              3591b13498cf        About a minute ago   785MB

docker run

# docker run -d -p 65001:65001 dfclient
1a3a29b3e2b5c3a27435c27dda37a01355523c1c0f694550626ea93e2a7a81fe

curl

# curl <IP_ADDRESS>:65001/args
--dfpath=./dfget-go

Ⅴ. Special notes for reviews
dfclient will including dfget and dfdaemon
How to use it?

Download an image with Dragonfly.

Downloading General Files

Pull the docker image we provided.

docker pull dragonflyoss/dfclient:v0.3.0_dev

Run dfclient

# docker run -d  -p 65001:65001 dragonflyoss/dfclient:v0.3.0_dev
f03211da795a7d92487f2348a24668afffed8b7d031ee96b4701ae153d9a5444

Download general files with Dragonfly.

docker exec f03211da795a dfget -u "http://www.taobao.com" -o /tmp/test.html --node nodeIp1,nodeIp2

@allencloud @lowzj  PTAL. THX:)

LGTM


Not able to access the pre-trained model

Hi all,
I am not able to untar the pre-trained model. Is the file corrupted? If not, please let me know how to use it?

Hi Zack,
The checkpoint_ssd300.pth.tar is not actually a tar archive. Just remove the .tar extension from the file name and you will be able to load it using torch.load('checkpoint_ssd300.pth').

Thanks !!


Fetch callLogs for platform specific app

hello i am trying to build a app, that will have features to make phone call. I try to find two flutter plugin use full " call_log:" and "pit_sms_call_log:" which i tried to use in my app. there are issues with call_log Plugin it is taking 2 3 min to just to fetch call logs. I need help to resolve this problem, pit_sms_call_log only get phone number not the names stored in phone. is there any other possible solution i can right native code in java or kotlin.

Hi @hssn-hassnain
This platform is not meant for assistance on personal code. Please see https://flutter.dev/community for resources and asking questions like this, you may also get some help if you post it on Stack Overflow. Closing, as this isn't an issue with Flutter itself,
if you disagree please write in the comments and I will reopen it
Thank you


removed cffi-libffi dependency

This fixes ARM compatibility for me; see issue #16. But, I need approval on the solution.
Before:
(defcfun ("glfwSetGammaRamp" set-gamma-ramp) :void
  (monitor monitor) (ramp (:struct gamma-ramp)))

After:
(defcfun ("glfwSetGammaRamp" set-gamma-ramp) :void
  (monitor monitor) (ramp gamma-ramp))

By not passing gamma-ramp struct by value, we remove the cffi-libffi dependency. However, it may be possible to pass by value without using the cffi-libffi syntax. Thoughts?

Hi @tjklemz! Thanks for the PR. I'm actually pretty far removed from this project these days, and CL in general, so I'm afraid I'm unsure of the implications of your changes. I'm all for removing an unneeded dependency, though, particularly one that's causing trouble.
Can you show me what setting a gamma ramp looks like after these changes, and verify that it works for you? As long as this remains possible, I see no reason not to merge.

It looks like it works fine. (Essentially, the change means that you have to pass a pointer to set-gamma-ramp instead of passing by value.) I'll test some more tomorrow (it's really late here), but here's my REPL results:
(ql:quickload :cl-glfw3) ; note this is my local-projects version a.k.a. the PR version

(cffi:defcstruct gamma-ramp
  (red :pointer)
  (green :pointer)
  (blue :pointer)
  (size :unsigned-int))

(defparameter m (glfw:get-primary-monitor))
(defparameter r (glfw:get-gamma-ramp m))

(defparameter myred (getf r '%glfw::red))
(defparameter mygreen (getf r '%glfw::green))
(defparameter myblue (getf r '%glfw::blue))
(defparameter mysize (getf r '%glfw::size))

(cffi:with-foreign-object (ramp '(:struct gamma-ramp))
    (setf (cffi:foreign-slot-value ramp '(:struct gamma-ramp) 'red) myred
          (cffi:foreign-slot-value ramp '(:struct gamma-ramp) 'green) mygreen
          (cffi:foreign-slot-value ramp '(:struct gamma-ramp) 'blue) myblue
          (cffi:foreign-slot-value ramp '(:struct gamma-ramp) 'size) mysize)
    (glfw:set-gamma-ramp m ramp))

Again, I'll write a better test tomorrow, but you can see the values like so:
(defparameter m (glfw:get-primary-monitor))
(defparameter r (glfw:get-gamma-ramp m))
(defparameter g (getf r '%glfw::green))
(%glfw::c-array->list g 10 :unsigned-short) ; where 10 can be anything from 0 to (getf r '%glfw::size)

I'm still learning CL-CFFI, so there might be an easier or different way to create a pointer to a struct. I might play around with trying to pass by value; if anything, it will make me more familiar with all of this.

@AlexCharlton I did a more thorough test, and everything is working great. I'm able to change the gamma ramp of the monitor. (IOW, you can test it visually.) I've tested in Clozure CL and SBCL. I've also tested with the GLFW3 C example (from their website docs) in order to compare.
Here's my Lisp test code:
(ql:quickload :cl-glfw3) ; again, this is the PR version in my quicklisp/local-projects folder

(glfw:initialize)

(defun change-gamma ()
    (cffi:with-foreign-objects ((ramp '(:struct %glfw::gamma-ramp)) (r :unsigned-short 256) (g :unsigned-short 256) (b :unsigned-short 256))
        (loop for i below 256
            do (setf (cffi:mem-aref r :unsigned-short i) (* i 64)
                     (cffi:mem-aref g :unsigned-short i) (* i 128)
                     (cffi:mem-aref b :unsigned-short i) (* i 256)))
        (setf (cffi:foreign-slot-value ramp '(:struct %glfw::gamma-ramp) '%glfw::red) r
              (cffi:foreign-slot-value ramp '(:struct %glfw::gamma-ramp) '%glfw::green) g
              (cffi:foreign-slot-value ramp '(:struct %glfw::gamma-ramp) '%glfw::blue) b
              (cffi:foreign-slot-value ramp '(:struct %glfw::gamma-ramp) '%glfw::size) 256)
        (glfw:set-gamma-ramp (glfw:get-primary-monitor) ramp)))

(defun reset-gamma ()
    (glfw:set-gamma (glfw:get-primary-monitor) 1.0))

If you run (change-gamma) your screen will turn bluish. Running (reset-gamma) will change it back to normal. The change-gamma function is just setting a linear ramp of size 256. Obviously, the function could be generalized to take a gamma generator function, etc.
To compare, here is the C version:
#include <GLFW/glfw3.h>
#include <stdio.h>
#include <stdlib.h>

int main (int argc, char *argv[]) {
	char s[100];

	if (!glfwInit()) {
		exit(-1);
	}

	GLFWmonitor* monitor = glfwGetPrimaryMonitor();

	GLFWgammaramp ramp;
	unsigned short red[256], green[256], blue[256];
	ramp.size = 256;
	ramp.red = red;
	ramp.green = green;
	ramp.blue = blue;
	for (int i = 0;  i < ramp.size;  i++) {
		ramp.red[i] = i*64;
		ramp.green[i] = i*128;
		ramp.blue[i] = i*256;
	}
	glfwSetGammaRamp(monitor, &ramp);

	fgets(s, sizeof(s), stdin); // blocks until you press return

	glfwSetGamma(monitor, 1.0); // resets the gamma

	glfwTerminate();
	return 0;
}

Compile and run this like so (adjusting paths for your machine if necessary):
gcc -o main main.c -lglfw -I/usr/local/include -L/usr/local/lib
chmod u+x main
./main

The program will change the gamma to the bluish hue and wait for you to press enter/return (which will reset the gamma to normal). It should look the same as the Common Lisp version.

Let me know if you have any questions. If this all seems reasonable to you, I think the PR is ready to be merged.

Sweet! Thanks for the thorough follow up!


Setup .travis.yml

it fails because travis CI's go is trying to get math/bits for klauspost/compress package?

https://travis-ci.org/FlowingSPDG/get5-web-go Done.  The reason Travis CI was failing build is that travis was using gov1.7 which doesnt support math/bits and sql.NullInt32/sql.NullTime


Link 2 blogs to this article please

Mas Libman (PG) has asked me to link the 2 blogs we wrote late last year as a reference to this article. Similar to what we have here (https://learn.microsoft.com/en-us/microsoft-365/compliance/sensitivity-labels-office-apps?view=o365-worldwide#auditing-labeling-activities). those two blogs became very popular, and they are being referenced by PG in many conversations. I didn't want to place the reference awkwardly, so I think you are the best team to decide where in the doc to place it

Learn Build status updates of commit b17aa3c:
:warning: Validation status: warnings

File
Status
Preview URL
Details

office-365-management-api/office-365-management-activity-api-reference.md
:warning:Warning
View
Details

office-365-management-api/office-365-management-activity-api-reference.md

Line 2, Column 1: [Warning: ms-prod-and-service - See documentation] Only one of the following attributes can exist: 'ms.prod', 'ms.service'. Use ms.prod for on-premise products, or ms.service for cloud services.

For more details, please refer to the build report.
If you see build warnings/errors with permission issues, it might be due to single sign-on (SSO) enabled on Microsoft's GitHub organizations. Please follow instructions here to re-authorize your GitHub account to Learn Build.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
Note: Your PR may contain errors or warnings or suggestions unrelated to the files you changed. This happens when external dependencies like GitHub alias, Microsoft alias, cross repo links are updated. Please use these instructions to resolve them.
For any questions, please:Try searching the learn.microsoft.com contributor guidesPost your question in the Learn support channel

@walidelmorsy I'm not sure what you want me to do here or what blogs you're referring to.

@lindalu-MSFT could we please reference both of these blogs (https://techcommunity.microsoft.com/t5/security-compliance-and-identity/microsoft-365-compliance-audit-log-activities-via-o365/ba-p/2957171) and (https://techcommunity.microsoft.com/t5/security-compliance-and-identity/microsoft-365-compliance-audit-log-activities-via-o365/ba-p/2957297) in this article please similar to what was done in (https://learn.microsoft.com/en-us/microsoft-365/compliance/sensitivity-labels-office-apps?view=o365-worldwide#auditing-labeling-activities)?

RIght, you want me to add the Tip to another article, right? Which article?

This one please (https://learn.microsoft.com/en-au/office/office-365-management-api/office-365-management-activity-api-reference)

Hi, fixed in a different PR. See https://github.com/MicrosoftDocs/office-365-management-api/pull/321.


in searchChatMembers how to get more than 200 memebers

How to specify offset, like in getSupergroupMembers?

API limit: https://github.com/tdlib/td/issues/507#issuecomment-471886163


Namespaced models and deprecation warnings by class lookup

I have models which are namespaced such as this:
class Vehicle < ActiveRecord::Base; end

class Vehicle::Car < Vehicle; end
class Vehicle::Train < Vehicle; end
class Vehicle::Jet < Vehicle; end

When creating factories for these models, they were set up in the following way:
factory :vehicle_car, class: Vehicle::Car do; end
factory :vehicle_train, class: Vehicle::Train do; end
factory :vehicle_jet, class: Vehicle::Jet do; end

This produces the following deprecation warning:

DEPRECATION WARNING: Looking up factories by class is deprecated and will be removed in 5.0. Use symbols instead and set FactoryBot.allow_class_lookup = false.

Is there a format for writing a symbol to name these factories such that I do not need to use the class name to comply with the deprecation warning?

@michaelfich Thanks!

Thanks for the help. I am going to leave this issue open because there is definitely room for documentation improvements here.

I added some documentation for using strings instead of classes in https://github.com/thoughtbot/factory_bot/commit/ef5c4ba49a182d051e39fe8ea3ef33591fff53ce


[Question] Help me to set DNSCrypt-proxy correctly !

Hi. I'm sorry to post this here but I did not find better place for it.
I'm on Fedora 30 X64 bit Cinnamon edition.
My Internet service provider enforce to use it's DNS even if I set different one using GUI of network manager !
I installed your dnscrypt-proxy from official Fedora repositories as following:
sudo dnf install dnscrypt-proxy
then
sudo systemctl start dnscrypt-proxy
then
sudo systemctl enable dnscrypt-proxy
then reboot my laptop
After that - from GUI of my DE for my network manager - I change my network connection as following:

"Advanced Network Configuration" > select "IP4 setting > Automatic (DHCP) address only" > then set DNS to <IP_ADDRESS>
then switched to "IPV6" & select "ignore"
then saved & close this window
then reboot my laptop

It was working very very very well !
But then I did additional step:
sudo vi /etc/NetworkManager/NetworkManager.conf
& then add the following line to section [main]:
dns=default
this line "dns=default" was not existing by default. I added it according to the following link (when I conclude that it will provide better security though page does not talking about DNSCrypt-proxy):
https://www.azirevpn.com/support/guides/computer/linux/change-dns
then reboot. After reboot I visited https://ipleak.net & every thing was okay. Then I went to sleep & today I opened my laptop & rechecked at https://ipleak.net when I confronted when I saw among many DNS servers DNS POINTED TO MY COUNTRY & CITY !!!
I rebbot & recheck but at this current session no such DNS leak !!!
Please help me:

is adding "dns=default" responsible for this DNS leak ?

what is the best value for "/etc/NetworkManager/NetworkManager.conf" ? Is it:
dns=default
or
dns=none
or it is better to delete this line & return as it was not found ?

if dns-default line that I added not responsible, so what it was this DNS leak & how can I block & prevent it in future ?

Thank you very much for your great tool.

DNSCrypt is not a VPN, it changes/secures your DNS.
On ipleak
Your IP addresses, will be the same
DNS Addresses, will be different than usual if DNSCrypt is working.
Try to force quit DNSCrypt, I have this bug from time to time.
As it will restart automatically, the problem is solved.
Perhaps a smartdns or vpn would be easier for you.

Don't add dns=default. The guide you read is unrelated to dnscrypt-proxy.
The dnscrypt-proxy documentation is here: https://github.com/jedisct1/dnscrypt-proxy/wiki

@jedisct1
I did what you asked me to do. I delete "dns=default" & save then reboot. I did not confronted with the issue on 2 reboot till now.
But - before close this issue - can you inform me, what "dns=default" & "dns=none" mean ?
When I was on Fedora 28, I tried dnscrypt-proxy but not worked at all due to packaging error from Fedora side that resolved for Fedpra 29+, so I delayed my use till upgrading for Fedora 30.
When I was on Fedora 28, I read in Internet an older post said that we should use "dns=none" & I tried it (at time when dnscrypt-proxy not work at all) & it result in block all Internet traffic except Tor browser which was the only part of my system that can connect to Internet. But on Fedora 30 - & after install dnscrypt-proxy & enable it - I tried also "dns=none" & my Internet connection was not affected though I did not set DNS at "<IP_ADDRESS>" but to COMODO DNS server.
I asked about these because I did not find answers on Internet .....
@TraderStf
Dear I'm already using VPN by terminal & configuration files & I was treat DNS leak by manual setting of DNS to specific server like COMODO DNS or OpenDNS ..... & it was okay. But several months ago, ISPs changed their policy & became not responding to manual setting even from within WiFi routers !! For that I got interest in dnscrypt-proxy ......
By the way, in the issue of this thread the DNS address that shown on https://ipleak.net is the same IP address of my country that I have when VPN switched OFF. While before install dnscrypt-proxy & enable it & change my connection to <IP_ADDRESS> DNS address was differ from my IP address though they belong to same country but different cities ......

The only thing you need on Fedora is to set dns=none like you did and set up resolv.conf:
https://github.com/jedisct1/dnscrypt-proxy/wiki/Installation-linux#step-4-change-the-system-dns-settings
Now, make a backup of the /etc/resolv.conf file:
cp /etc/resolv.conf /etc/resolv.conf.backup
Then delete the /etc/resolv.conf file (important, since this can be a dangling link instead of an actual file):
rm -f /etc/resolv.conf
And create a new /etc/resolv.conf file with the following content:
nameserver <IP_ADDRESS>
options edns0
Let's check that everything works by sending a first query using dnscrypt-proxy:
./dnscrypt-proxy -resolve example.com

@eclipseo

currently I deleted "dns=default" & DOES NOT SET "dns=none". Please see the following:

# Configuration file for NetworkManager.
#
# See "man 5 NetworkManager.conf" for details.
#
# The directories /usr/lib/NetworkManager/conf.d/ and /var/run/NetworkManager/conf.d/
# can contain additional configuration snippets installed by packages. These files are
# read before NetworkManager.conf and have thus lowest priority.
# The directory /etc/NetworkManager/conf.d/ can contain additional configuration
# snippets. Those snippets are merged last and overwrite the settings from this main
# file.
#
# The files within one conf.d/ directory are read in asciibetical order.
#
# If /etc/NetworkManager/conf.d/ contains a file with the same name as
# /usr/lib/NetworkManager/conf.d/, the latter file is shadowed and thus ignored.
# Hence, to disable loading a file from /usr/lib/NetworkManager/conf.d/ you can
# put an empty file to /etc with the same name. The same applies with respect
# to the directory /var/run/NetworkManager/conf.d where files in /var/run shadow
# /usr/lib and are themselves shadowed by files under /etc.
#
# If two files define the same key, the one that is read afterwards will overwrite
# the previous one.

[main]
#plugins=ifcfg-rh,ibft

[logging]
# When debugging NetworkManager, enabling debug logging is of great help.
#
# Logfiles contain no passwords and little sensitive information. But please
# check before posting the file online. You can also personally hand over the
# logfile to a NM developer to treat it confidential. Meet us on #nm on freenode.
# Please post full logfiles except minimal modifications of private data.
#
# You can also change the log-level at runtime via
#   $ nmcli general logging level TRACE domains ALL
# However, usually it's cleaner to enable debug logging
# in the configuration and restart NetworkManager so that
# debug logging is enabled from the start.
#
# You will find the logfiles in syslog, for example via
#   $ journalctl -u NetworkManager
#
# Note that debug logging of NetworkManager can be quite verbose. Some messages
# might be rate-limited by the logging daemon (see RateLimitIntervalSec, RateLimitBurst
# in man journald.conf).
#
#level=TRACE
#domains=ALL
                                                                                50,1          Bot

resolv.conf file on my system - after managed DNS from within GUI (advanced network configuration) is as bellow:

# Generated by NetworkManager
nameserver <IP_ADDRESS>
~
~
~
~
~
~
~
~
~
~
~
~
~
~
~
~
~
~
~
~
~
~
~
~
~
~
~
~
~
~
~
~
~
~
~
~
                                                                                2,1           All

Is there need to do any further tweak ? I think no since both https://ipleak.net & https://dnsleaktest.com/ are okay (show DNS servers not related to my country = No DNS leak)

Looks good.

@jedisct1
Okay but since you delayed in replay me, I reached to conclusion that it is okay but regullarly it miss "dns=none" but although it missed but it is working okay !
For that I searched Internet about what mean "dns=none" but I found nothing ! So, I concluded by my imagination that "dns=none" will PREVENT usual (non-dnscrypt-proxy) DNS whither this usual DNS being the default of ISP or customized DNS that set by user via Network manager GUI, isn't it ?
And for all that I re-edited my file by re-adding line "dns=none" to achieve the maximum possible security & prevent any possible DNS leak, so is this okay ? Please, kindly, confirm this.
Now the output is as following:

vi /etc/NetworkManager/NetworkManager.conf

# Configuration file for NetworkManager.
#
# See "man 5 NetworkManager.conf" for details.
#
# The directories /usr/lib/NetworkManager/conf.d/ and /var/run/NetworkManager/conf.d/
# can contain additional configuration snippets installed by packages. These files are
# read before NetworkManager.conf and have thus lowest priority.
# The directory /etc/NetworkManager/conf.d/ can contain additional configuration
# snippets. Those snippets are merged last and overwrite the settings from this main
# file.
#
# The files within one conf.d/ directory are read in asciibetical order.
#
# If /etc/NetworkManager/conf.d/ contains a file with the same name as
# /usr/lib/NetworkManager/conf.d/, the latter file is shadowed and thus ignored.
# Hence, to disable loading a file from /usr/lib/NetworkManager/conf.d/ you can
# put an empty file to /etc with the same name. The same applies with respect
# to the directory /var/run/NetworkManager/conf.d where files in /var/run shadow
# /usr/lib and are themselves shadowed by files under /etc.
#
# If two files define the same key, the one that is read afterwards will overwrite
# the previous one.

[main]
#plugins=ifcfg-rh,ibft
dns=none

[logging]
# When debugging NetworkManager, enabling debug logging is of great help.
#
# Logfiles contain no passwords and little sensitive information. But please
# check before posting the file online. You can also personally hand over the
# logfile to a NM developer to treat it confidential. Meet us on #nm on freenode.
# Please post full logfiles except minimal modifications of private data.
#
# You can also change the log-level at runtime via
#   $ nmcli general logging level TRACE domains ALL
# However, usually it's cleaner to enable debug logging
# in the configuration and restart NetworkManager so that
# debug logging is enabled from the start.
#
# You will find the logfiles in syslog, for example via
#   $ journalctl -u NetworkManager
#
# Note that debug logging of NetworkManager can be quite verbose. Some messages
# might be rate-limited by the logging daemon (see RateLimitIntervalSec, RateLimitBurst
# in man journald.conf).
#
#level=TRACE
#domains=ALL
                                                                                50,1          Bot

vi /etc/resolv.conf

# Generated by NetworkManager
nameserver <IP_ADDRESS>
~
~
~
~
~
~
~
~
~
~
~
~
~
~
~
~
~
~
~
~
~
~
~
~
~
~
~
~
~
~
~
~
~
~
~
~
"/etc/resolv.conf" [readonly] 2L, 51C                                                                                2,14          All

Please just confirm, kindly, that "dns=none" is more secure !
By the way, I feel that your data about Fedora somewhat out of date because no any package for Fedora called "resolvconf" !! Your guide asking for "sudo apt-get remove resolvconf" which = "sudo dnf remove resolvconf" but no such package in Fedora/RPMFusion repositories & not existing on my system !

@Nokia808 Like you, I use fedora and as a 7-year old programmer and budding network admin I can assure you that you do not need to concern yourself so heavily about the "dns=none" or "dns=default" BECAUSE it does not really "add" to security. The main goal of using DNSCrypt is to secure DNS queries from MITM attacks or attacks involving manipulation of your DNS queries. I don't know how NetworkManager works as a whole but for starters it pays off to know what this NetworkManager is. It's that software being used to manage your network settings in linux and is being utilized when you modify your settings through the UI i.e. setting your IPv6 to ignore and etc.
My best guess on what happens with "dns=default" is NetworkManager does away with the defaults of picking up the DNS settings provided by your router/modem while "dns=none" means no DNS server is set in resolv.conf? I'm not really about "dns=none" but in any case it doesn't matter, what matters is to get that DNSCrypt being utilized properly by your system.
Since you've already removed "dns=default" on your NetworkManager.conf, the only thing left to do is to set the following lines to your /etc/resolv.conf
nameserver <IP_ADDRESS>
options edns0

I'm not really sure what options edns0 does but that's what the instructions say and I'm pretty sure jedisct1 knows what he is doing so there is no need to worry about that.

@MystesofEternity
Thank you for your response.
But there is something: I tried to edit /etc/resolv.conf file by
sudo vi /etc/resolv.conf
then add:
options edns0
I noticed after save & exit by :qw the edns0 became RED in colour !
Then I restart my PC. After that, I inspect /etc/resolv.conf by "vi /etc/resolv.conf" & I confronted when I saw that my edit (line: options edns0) disappeared at all & file return as it was before my edition !
I think that what @eclipseo said is needed. He said:
Now, make a backup of the /etc/resolv.conf file:
cp /etc/resolv.conf /etc/resolv.conf.backup
Then delete the /etc/resolv.conf file (important, since this can be a dangling link instead of an actual file):
rm -f /etc/resolv.conf

But is there real need to do this ?? DNSCrypt seem to do well on my system: every time I visit any site to examine DNS, it never reveal my ISP DNS ... So, does really we need to add "options edns0" ??

The behavior of "options edns0" disappearing is because NetworkManager's automated behavior whenever a network connection has been established. This happens because it enforces whatever you have indicated in the GUI as your DNS servers and this is normal behavior that I have observed through almost a year of using Fedora.
I did some research about EDNS0. Take a look at this:

It seems setting "options edns0" is essential for making use of DNSSEC in your system. Since you are highly concerned about security, I believe you have DNSSEC set as true in your dnscrypt-proxy.toml file.
In this case it is essential for you to add "options edns0" to your resolv.conf file. I know the pain of having to do this every single time and what I did is to actually have a startup script copy the "correct" version of resolv.conf to /etc/resolv.conf
Do you know how to do scripting in linux?

@MystesofEternity
I have limited experience in writing scripts. In fact It was about 2 & 1/2 hrs since I write last script. However, I never know how to make autostart script at all. It will be very helpful if you post your script here & explain what are the line that needed to make it autostart script.
But why you did not inform me from 1st time that adding options edns0 by usual method will overrided on next boot/restart ?

Huh? I'm not sure why you're asking about why I informed you on the fact that it will be overridden on reboot. No need to delve on the details because I don't really bother to read much code on opensource software specifically the common day-to-day ones like NetworkManager.
As for autorun script I'll assume you have your resolv.conf.backup on your desktop and i'll assume your username in your linux installation is "Nokia808".
#!/bin/bash
sudo cp resolv.conf.backup /etc/resolv.conf

name the file fixResolvconf.sh and place it on your home directory or desktop
I assume you know how to use the cd command to traverse directories? If not just put it in your home directory(the directory where you can see folders like Desktop, Downloads, Documents, and etc.)
NOTE: Make sure your resolv.conf.backup file is in the home directory TOO!
Open a command line and type the command chmod +x fixResolvconf.sh
After that you just execute your new script through ./fixResolvconf.sh
As for automating it to become your startup script, I'm afraid I can't help you out with that just yet as I haven't spent much time understanding how to use cron to make cron jobs. I actually just run the script on my own instead of having it automatically execute. Since the command has to run as root user you will be prompted to type your password and unfortunately the only way to have a better life out of that is through making a cron job.
Best of luck!


Incorrect screen position set when exiting fullscreen mode

When session_persistence is enabled and someone exits the program while in fullscreen mode, their window's screen position is not restored upon the next time launching the program.  Instead, when you launch the program, you're in fullscreen, you exit and it puts the window at the center of the screen no matter what.
Reference..
There are ways to work around this, just none of them are clean.

Made a work around, but I wish I didnt need to.


Update library and samples to ActionBarCompat. Remove sample_sherlock

Update the library and samples to use AppCompat so users can use the new Toolbar. Remove the sample_sherlock project since actionbar sherlock has been deprecated for a while now.
manifest install script has been commented out, if PR is merged, be sure to uncomment for mavenCentral().

thx