[feature] [BIT 578] speed up metagraph storage query

This PR speeds up the storage call made bysubtensor.neurons in the subtensor.use_neurons_fast function.
This feature works by bundling a nodejs binary with the polkadotjs API.
This binary is a CLI that implements the sync_and_save --filename <default:~/.bittensor/metagraph.json> --block_hash <default:latest> command.
This syncs the metagraph at the blockhash and saves it to a json file.
The speed-up is quite significant, below is a test run of the manual without the fix, with the ipfs cache, and with the fix.

And below is the IPFS cache sync versus the manual sync (with fix)

A pro of this is that it removes the need for a centralized IPFS cache of the metagraph.
A downside of this fix is that the binaries with nodejs bundled use ~50MB each (one linux, one macos).
There is currently no binary for windows, but I'm not certain this should be included anyway, as we only support linux/macos.
Another pro of this fix is it works on both nobunaga and nakamoto, and can be adapted to any network.
This also leaves room for adding other large substrate queries and working further with the polkadot js api.

Very nice results @camfairchild  !
where do binaries come from? It would be nice to have information about that and visibility about the code that originate that bins, What do you think about that?

The binaries are from https://github.com/opentensor/subtensor-node-api
Not sure where to write docs about this though

The binaries are from https://github.com/opentensor/subtensor-node-api Not sure where to write docs about this though

If we are getting binaries from there I would suggest to comment it somewhere so we can wire the components and generate the knowledge
@camfairchild very nice job!!

The binaries are from https://github.com/opentensor/subtensor-node-api Not sure where to write docs about this though

If we are getting binaries from there I would suggest to comment it somewhere so we can wire the components and generate the knowledge
@camfairchild very nice job!!

Good idea. I'll add it in the setup.py file. Perhaps though we should maintain a docs website in future.

Perhaps I misunderstood your graphs, but looks like the ifs cache is still a little faster despite being centralized, is that right?
Also, you have conflicts ;)

Perhaps I misunderstood your graphs, but looks like the ifs cache is still a little faster despite being centralized, is that right?
Also, you have conflicts ;)

Nope, you're right. The IPFS is faster, but only when it's up ;)

Perhaps I misunderstood your graphs, but looks like the ifs cache is still a little faster despite being centralized, is that right?
Also, you have conflicts ;)

Nope, you're right. The IPFS is faster, but only when it's up ;)

ouch. 🗡

@camfairchild why is this still marked do not merge? any blockers?

Going to refactor into an external pypi package so the binary can be distributed easier


Is it possible to use system calls?

Hi, Is it possible to use system calls using Proton-native? For example log key events when window is not focused.

Please don't make a keylogger @JafarAkhondali 😂

@albinekb LOL 😅 Who would create a keyloggger in 2018 using react? 😺
I've developed a client for an device using tcp sockets() and electron, But sometimes we need to minimize the window of our application and have the same functionality

I was thinking the same... maybe we need to use a nodejs server for system calls?
for example file system could be exposed through a graphql request?

That wouldn't be part of this package, but another. I'm not familiar with doing this in node so I wouldn't know.

Hi @kusti8, I'm libui-node author. I gave a look at how you implemented the event loop here: https://github.com/kusti8/proton-native/blob/master/src/eventLoop.js
It's similar to how the event loop of libui-node works in early release. As far as I can say, node calls should work just fine (but I didn't try yet).
And system calls like logging keys should work too... You could try to use my https://github.com/parro-it/screen-info and see if it work.
Anyway these event loop implementation is highly CPU intensive, because it is based on polling (~4% CPU on an inactive, simple window).
In later libui-node versions, I implemented a background thread version of some part of the loop that is way more performant, but is actually not working on macOS.
And I was not able to find a way to make the same trick work on Windows, that is still using the poor performance polling.

Yeah I implemented it after I released it because of the macOS error. On my
laptop, I saw only around .4% CPU utilization but I don't know how it is
for others. But that's the best that currently can be done. Node callbacks
should work since it's just an event loop, and it calls refresh on the same
thread.
On Mon, Feb 19, 2018, 4:53 PM Andrea Parodi<EMAIL_ADDRESS>wrote:

Hi @kusti8 https://github.com/kusti8, I'm libui-node author. I gave a
look at how you implemented the event loop here:
https://github.com/kusti8/proton-native/blob/master/src/eventLoop.js
It's similar to how the event loop of libui-node works in early release.
As far as I can say, node calls should work just fine (but I didn't try
yet).
And system calls like logging keys should work too... You could try to use
my https://github.com/parro-it/screen-info and see if it work.
Anyway these event loop implementation is highly CPU intensive, because it
is based on polling (~4% CPU on an inactive, simple window).
In later libui-node versions, I implemented a background thread version of
some part of the loop that is way more performant, but is actually not
working on macOS.
And I was not able to find a way to make the same trick work on Windows,
that is still using the poor performance polling.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/kusti8/proton-native/issues/20#issuecomment-366811622,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AJW73HGy5_cbHgfZeWgsGFpoUsSRmn2Sks5tWe12gaJpZM4SJrrS
.

Yeah I implemented it after I released it because of the macOS error.

I'm thinking of restoring an old version for macOS that should work on last os versions, but involve the use of the an internal, undocumented  call _dispatch_get_main_queue_port_4CF.
I have no solution for Windows yet... but we discussed on libui repos in 2016 and it seems there could be a possible solution.

Node callbacks should work since it's just an event loop, and it calls refresh on the same
thread.

I agree.

I saw only around .4% CPU utilization but I don't know how it is
for others.

I think libui, libui-node and proton-native are attractive because they are lite-weight alternative to electron, and so they probably they will be used more often on low-range CPU, where, sadly, the polling-penalty is more heavy.

I'm closing it as it seems that the OP question has been answered. @parro-it feel free to create a separate issue to track this closer.


Show version number in splash screen on Phone and Drawer Menu

It should get version from package.json

We show it in about so I guess it's good enough for now


Fix usage of MLJModelInterface

The current usage of MLJModelInterface in the affected functions requires a global MLJModelInterface to be available, e.g. only importing @mlj_model would fail when MLJModelInterface is not available.
Using $MLJModelInterface fixes the problem by referring to the local MLJModelInterface.

@ablaom OutlierDetectionInterface.jl depends on @mlj_model, but cannot guarantee that MLJModelInterface is always available globally.


How to auto accept new device without press accept request dialog

can we do that?
its really annoying when replug the device

I don't think you can skip the dialog. It's how Android works for non-root users. Security feature...

why termux not remember the previous usb plugged?

https://github.com/kai-morich/SimpleUsbTerminal
this app just support an usb serial but when replug its still working
this app have an remember button

Well, in that case, this is a potential termux improvement. I can't do anything about it directly though...


feat: Format asyncapi.json with 2 spaces

Json output uses 2 space indentation as discussed in discord. As a side effect, there is a space after the colon seperator now - see the json to review.
Add methods to customize objectmapper and printer (to allow easier configuration kotlin, i.e. JavaTimeModule)
Use TreeMap to created sorted map structures in json output
test: Update asyncapi.json (using test output. Better diffs for future fields added, since it is sorted)

Good addition, thanks


[DatePicker] Inconsistent event implementation

DatePicker doesn't behave like similar input fields.
TextField:

DatePicker:

It should present a consistent behavior. DatePicker onChange should fire a change event targeting the DatePicker object.
Versions
Material-UI: 0.17.0

That issue reminds me #2957. Any idea who we could implement what you are suggesting?

i need to create 2 onChange function  to cover up my two datepicker in a form. because i can't got the event targeting object. i think event parameter shouldn't be null.

Closing for #4787


Adding Egua Language

I've added egua in language.yml and in sample directories, as the contributing.md.
Checklist:

[x] I am adding a new language.

[x] The extension of the new language is used in hundreds of repositories on GitHub.com.

Search results for each extension:

https://github.com/search?q=extension%3Aegua+NOT+nothack&type=Code

[x] I have included a real-world usage sample for all extensions added in this PR:

Sample license(s):
https://github.com/eguatech/exemplos

[x] The extension of the new language is used in hundreds of repositories on GitHub.com.

There are only 5 .egua files, from 1 repository...
Please read our guidelines and criteria for adding a new language to Linguist.


Familiarize with Pitest

User Story

As a software development team
We want to familiarize ourselves with the Pitest Tool
Create a guide for other developers so they can easily start using the tool

Acceptance Criteria

Install and familiarize with Pitest.
Gather information to get the tool started and start an easy example.
Write a guide for other developers.
Upload the guide to the wiki.

Definition of done (DoD)

Acceptance criteria are met.
Be able to demo the software in the Sprint review

DoD General Criteria

All design and documentation tasks are finalized.
All criteria are satisfied.
The team lead or product owner approves the guide and the planning document is updated if needed.

Pitest with Gradle sample: https://github.com/e-solutions-GmbH/pitest-gradle-sample

Pitest Gradle plug-in installation guide: https://gradle-pitest-plugin.solidsoft.info/

Hi. As promised, here is another example for Pitest: As promised, here is another more recent example: https://github.com/Pfoerd/pitest-gradle-example


Allow coroutines to be used in dask.bag operations

Would be nice if dask allowed to pass coroutines directly to dask bag operations, such as map, filter, foldby, etc.
Seems like https://github.com/dask/distributed/pull/5151 added the ability to submit coroutines on the client object.
I've submitted this request here first: https://dask.discourse.group/t/is-it-possible-to-map-coroutines-in-a-dask-bag/174

Thanks @ianliu for opening this issue! Would you mind expanding a little bit on your use case for this? @jrbourbeau or @jsignell do you know if this has come up before?

Yeah I think this has come up before but I can't find a reference.

I think I was thinking about an issue where the user wanted to pass iterables of futures to from_delayed so I am no longer sure if there has been a request to pass coroutines


itorch hydrogen does not work after update

Trying to run hydrogen after update results in this:
Atom Version: 1.5.3
System: Mac OS X 10.11.3
Thrown From: Hydrogen package, v0.7.0
Stack Trace
Failed to activate the Hydrogen package
At Cannot read property 'toString' of null

TypeError: Cannot read property 'toString' of null
  at Object.<anonymous> (/Users/szagoruyko/.atom/packages/Hydrogen/lib/kernel-manager.coffee:10:88)
  at Object.memoized [as getAvailableKernels] (/opt/homebrew-cask/Caskroom/atom/1.3.2/Atom.app/Contents/Resources/app.asar/node_modules/babel-core/node_modules/lodash/index.js:7912:27)
  at /Users/szagoruyko/.atom/packages/Hydrogen/lib/autocomplete-provider.coffee:6:37
  at Object.<anonymous> (/Users/szagoruyko/.atom/packages/Hydrogen/lib/autocomplete-provider.coffee:5:41)
  at Object.<anonymous> (/Users/szagoruyko/.atom/packages/Hydrogen/lib/autocomplete-provider.coffee:1:1)
  at Module._compile (/opt/homebrew-cask/Caskroom/atom/1.3.2/Atom.app/Contents/Resources/app.asar/src/native-compile-cache.js:103:30)
  at Object.defineProperty.value [as .coffee] (/opt/homebrew-cask/Caskroom/atom/1.3.2/Atom.app/Contents/Resources/app.asar/src/compile-cache.js:208:21)
  at Module.load (module.js:355:32)
  at Function.Module._load (module.js:310:12)
  at Module.require (module.js:365:17)
  at require (/opt/homebrew-cask/Caskroom/atom/1.3.2/Atom.app/Contents/Resources/app.asar/src/native-compile-cache.js:50:27)
  at Object.<anonymous> (/Users/szagoruyko/.atom/packages/Hydrogen/lib/main.coffee:13:24)
  at Object.<anonymous> (/Users/szagoruyko/.atom/packages/Hydrogen/lib/main.coffee:1:1)
  at Module._compile (/opt/homebrew-cask/Caskroom/atom/1.3.2/Atom.app/Contents/Resources/app.asar/src/native-compile-cache.js:103:30)
  at Object.defineProperty.value [as .coffee] (/opt/homebrew-cask/Caskroom/atom/1.3.2/Atom.app/Contents/Resources/app.asar/src/compile-cache.js:208:21)
  at Module.load (module.js:355:32)
  at Function.Module._load (module.js:310:12)
  at Module.require (module.js:365:17)
  at require (/opt/homebrew-cask/Caskroom/atom/1.3.2/Atom.app/Contents/Resources/app.asar/src/native-compile-cache.js:50:27)
  at Package.module.exports.Package.requireMainModule (/opt/homebrew-cask/Caskroom/atom/1.3.2/Atom.app/Contents/Resources/app.asar/src/package.js:720:27)
  at Package.module.exports.Package.activateNow (/opt/homebrew-cask/Caskroom/atom/1.3.2/Atom.app/Contents/Resources/app.asar/src/package.js:172:16)
  at /opt/homebrew-cask/Caskroom/atom/1.3.2/Atom.app/Contents/Resources/app.asar/src/package.js:800:25
  at Function.module.exports.Emitter.simpleDispatch (/opt/homebrew-cask/Caskroom/atom/1.3.2/Atom.app/Contents/Resources/app.asar/node_modules/event-kit/lib/emitter.js:25:14)
  at Emitter.module.exports.Emitter.emit (/opt/homebrew-cask/Caskroom/atom/1.3.2/Atom.app/Contents/Resources/app.asar/node_modules/event-kit/lib/emitter.js:125:28)
  at CommandRegistry.module.exports.CommandRegistry.handleCommandEvent (/opt/homebrew-cask/Caskroom/atom/1.3.2/Atom.app/Contents/Resources/app.asar/src/command-registry.js:241:20)
  at CommandRegistry.handleCommandEvent (/opt/homebrew-cask/Caskroom/atom/1.3.2/Atom.app/Contents/Resources/app.asar/src/command-registry.js:3:61)
  at CommandRegistry.module.exports.CommandRegistry.dispatch (/opt/homebrew-cask/Caskroom/atom/1.3.2/Atom.app/Contents/Resources/app.asar/src/command-registry.js:160:19)
  at AtomEnvironment.module.exports.AtomEnvironment.dispatchApplicationMenuCommand (/opt/homebrew-cask/Caskroom/atom/1.3.2/Atom.app/Contents/Resources/app.asar/src/atom-environment.js:1013:28)
  at emitOne (events.js:77:13)
  at EventEmitter.emit (events.js:169:7)

Commands
     -0:01.1.0 hydrogen:run (atom-text-editor.editor.is-focused.vim-mode.normal-mode)

Config
{
  "core": {
    "disabledPackages": [
      "nuclide-remote-projects",
      "tree-view"
    ]
  },
  "Hydrogen": {}
}

Installed Packages
# User
Hydrogen, v0.7.0
autocomplete-bibtex, v0.6.2
language-lua, v0.9.4
language-matlab, v0.2.0
latex, v0.29.0
latexer, v0.2.9
markdown-preview, v0.157.3
minimap, v4.19.0
nuclide, v0.114.0
vim-mode, v0.64.0

# Dev
No dev packages

This bug is "almost" fixed in this commit.
It still throws if jupyter and ipython aren't installed.
CC @lgeiger

@szagoruyko do you have ipython in your PATH?
$ ipython --version

@slavaGanzin @n-riesco thanks, adding anaconda/bin to PATH solves the issue.

This should be fixed when dependecies.js would be released.
@szagoruyko Thanks for your patience


get videoInfo from url link

Is your feature request related to a problem? Please describe.
This package is fast in searching youtube videos, and should state in the documentation the limit it search. As I wanted to get video info from the link, sometime the title return undefined, thus forcing me to make it Unknown Track.
Describe the solution you'd like
Get video info at least title from the provided link parameter
Describe alternatives you've considered
No idea
Additional context
image

Could you give a small example of your code? I don't seem to understand the issue at hand.
In the image it shows a list of found track titles but then when you select a track the title is undefined?

That quite fast response, here is the line https://github.com/Ayeven/generic-bot/blob/c87589523aefc7b87c0a95959b51239285b89698/base/track.js#L86 which I can't extract info from url link. I console log it, return empty array. The music is correctly playing the right track, but title become undefined since empty array. This is the full repo link : https://github.com/Ayeven/generic-bot

		if ((url.startsWith('https://www.youtube.com/')) 		|| (url.startsWith('https://youtu.be')) 		|| (url.startsWith('https://m.youtube.com'))) { 			const yt = await ytsr.search(url); 			console.log(yt); 			info = yt.videos[0].title ?? 'Unknown Track'; 		} Yeah, found the issue now, sorry to bug you, must've been rushing reading the #readme.

Sometime it able to capture the title

This inconsistency comes down to YouTube themselves.
I'm unable to reproduce your issue, seems to do what it is supposed to...
https://runkit.com/embed/o1fw9ymgai9g

		let info = ''; 		if ((url.startsWith('https://www.youtube.com/')) 		|| (url.startsWith('https://youtu.be')) 		|| (url.startsWith('https://m.youtube.com'))) { 			const yt = new Scraper(); 			const ytsr = await yt.search(id || url); 			info = ytsr.videos[0]?.title ?? 'Unknown Track'; 		} 		else if (url.startsWith('https://soundcloud.com/')) { 			const sc = await scdl.getInfo(url || id); 			info = sc.title; 		} 		else { 			info = 'Unknown Track'; 		} Lmao, some solution for that inconsistency, so far it can capture it, well it is from the video id. I'll see if the issue persist


Create student.txt

Retry for Grand Rapids South Christian
Domain URL:
https://www.schs.org/
https://sites.google.com/schs.org/schsrobotics/home
Use: Programming for First Robotics Competition team 7054 to develop ROS for our competition robot.

@mattwalstra Pull request merged. Thank you!


Spelling is not triggering

I am using the new Neovim 0.5 stable on Linux with the appimage, and all other feature of this plugin are working.
I enable spelling, go to the word, press z= and it does not trigger, it goes to the old selection. The config related to my spelling is:
lua << EOF
require("which-key").setup {
  spelling = {
    enabled = true, -- enabling this will show WhichKey when pressing z= to select spelling suggestions
    suggestions = 20, -- how many suggestions should be shown in the list?
  },
}
EOF

let g:compe.source = {'path': v:true, 'buffer': v:true, 'nvim_lsp': v:true, 'spell': v:true }

set nospell spelllang=en_us

" toggle spell checking
nnoremap <silent><leader>s :set invspell<cr>

I saw https://github.com/folke/which-key.nvim/issues/84, and If I type :nmap z= I get:
z           * <Cmd>lua require("which-key").show("z", {mode = "n", auto = true})<CR>

spelling should be a key in plugins table.
plugins = {
  spelling = {
    enabled = true,
    suggestions = 20,
  },
},

Thanks, sorry, I should have read the instructions more carefully!


Deployment is frozen on canceling while WAIT stage

What happened:
Config pipeline sync with WAIT stage then click Cancel while sync pipeline at stage WAIT causes unexpected state (deployment got freeze).

Currently, I have to restart the piped agent to enable to rerun the deployment. The deployment will failure respectively but from the logs of piped a command CancelDeployment is still not handled errors log still exist.
What you expected to happen:
Enable to cancel pipeline sync on WAIT stage.
How to reproduce it:
Environment:

piped version: 0.9.8
control-plane version: 0.9.7
Others:

Could be being unable to propagate the signal. But from skimming the code around the WAIT stage, apparently looks like it's handled well. I wonder why 🤔
https://github.com/pipe-cd/pipe/blob/f5cdc8166025aa77a8a111245b9a65cc5ec495c6/pkg/app/piped/executor/wait/wait.go#L95-L104

It works normally if I increase the waiting time of WAIT stage 🤔 (30s in the below image)

Looks like the problem has occurred when the cancel command is passed to the  control-plane but the handling side (piped) does not handle it well 👀

Piped log when bug is occurred
there are 1 planned/running deployments for scheduling	{"count": 1}
a command CancelDeployment was forwarded to its scheduler	{"app-id": "be769118-530d-405b-b1b3-f5fb6d59fff4", "deployment-id": "d1869b48-732e-4470-b80f-945e755d2410"}
stop scheduler because of temination signal	{"deployment-id": "d1869b48-732e-4470-b80f-945e755d2410", "app-id": "be769118-530d-405b-b1b3-f5fb6d59fff4", "env-id": "02e5c530-5100-4ae4-9913-fc98d351da45", "project-id": "pipecd", "app-kind": "LAMBDA", "working-dir": "/var/folders/0n/r_1ykvdj5vq092hj8qzt79d42q187t/T/workspace069945842/d1869b48-732e-4470-b80f-945e755d2410-scheduler-594506344", "stage-id": "stage-3"}
cleaning up working directory for scheduler	{"deployment-id": "d1869b48-732e-4470-b80f-945e755d2410", "app-id": "be769118-530d-405b-b1b3-f5fb6d59fff4", "working-dir": "/var/folders/0n/r_1ykvdj5vq092hj8qzt79d42q187t/T/workspace069945842/d1869b48-732e-4470-b80f-945e755d2410-scheduler-594506344"}
STAGE ERROR LOG: Failed to load lambda function manifest (open /var/folders/0n/r_1ykvdj5vq092hj8qzt79d42q187t/T/workspace069945842/d1869b48-732e-4470-b80f-945e755d2410-scheduler-594506344/target-deploysource/deploysource398462938/repo/lambda/canary/function.yaml: no such file or directory)	{"deployment-id": "d1869b48-732e-4470-b80f-945e755d2410", "stage-id": "stage-3"}

deleted done scheduler	{"deployment-id": "d1869b48-732e-4470-b80f-945e755d2410", "app-id": "be769118-530d-405b-b1b3-f5fb6d59fff4", "count": 1}
there are 1 planned/running deployments for scheduling	{"count": 0}
a command CancelDeployment is still not handled	{"app-id": "be769118-530d-405b-b1b3-f5fb6d59fff4", "deployment-id": "d1869b48-732e-4470-b80f-945e755d2410"}


Add segment integration to landing page

I'm aware that this can't be merged into master as is because it's based on the current production codebase. @xetorthio :bell:
If approved we need to deploy from thins branch and I'll open a new PR against master with the new playground configuration that can be merged.

Closed in favor of efaa37e0ad6c2f84ebdd27faa44684333b7e714a


feat: display verifiable credentials in wallet with request flow for adding credentials (#493)

Explanation
This change displays Verifiable Credentials within the Cryptkeeper browser extension. The display is similar to the how identities are shown, with the ability to rename and delete credentials. In addition, the flow to add a Verifiable Credential is augmented to include an approvals process, whereby the user must approve the request to add the credential. Finally, this is all integrated into the demo where a user can add a Verifiable Credential into their wallet.

[x] Frontend component for displaying a list of Verifiable Credentials
[x] Include Verifiable Credentials display in home page
[x] Implement functionality to rename credentials
[x] Implement functionality to delete credentials
[x] Create Popup page to handle request for user to add a Verifiable Credential
[x] Include Add Verifiable Credential Request endpoint in sdk
[x] Integrate credential adding and display into demo

More Information
This change defines the data types used for Verifiable Credentials and here we create RPC endpoints for adding, retrieving, and deleting credentials.

Closes #493

Screenshots
Users can approve or reject a request to add a credential:

Users can view credentials within their wallet:

Users can rename a credential:

Manual Testing Steps

[ ] Run the cryptkeeper demo
[ ] Add a verifiable credential to your wallet
[ ] Either reject/accept the request
[ ] Attempt to add the same verifiable credential again. It will fail if you have already done so and you will receive a notification
[ ] View the verifiable credential in your Cryptkeeper wallet
[ ] Rename and/or delete the credential

Pre-Merge Checklist

[x] PR template is filled out
[ ] IF this PR fixes a bug, a test that would have caught the bug has been added
[x] PR is linked to the appropriate GitHub issue
[x] PR has been added to the appropriate release Milestone

PR template source from github.com/MetaMask

Thanks @AndrewCLu, I left some comments.
Also please lets have this feature on the enabled features list to be able to enable and disable it until it would be fully functional for production.
Regarding the PR description, thanks for writing detailed explanation. Just my feedback on this is that it would be much better if you could fill the other required headers, like More Information connecting to related issues, Screenshots because you already have UI changes, and Manual testing steps so we know what you want us really to manually test.

Makes sense. I've updated the PR description accordingly.

@AndrewCLu I created one PR with extended view option and when it merged can you support create verifiable credential view to work in a separate tab without creating new popup window?

@AndrewCLu I created one PR with extended view option and when it merged can you support create verifiable credential view to work in a separate tab without creating new popup window? #692

So do you mean when someone adds a verifiable credential, it just opens up the browser extension normally and directs them to a separate screen there? And say, when they add the credential it just redirects back to home?

@AndrewCLu I created one PR with extended view option and when it merged can you support create verifiable credential view to work in a separate tab without creating new popup window? #692

So do you mean when someone adds a verifiable credential, it just opens up the browser extension normally and directs them to a separate screen there? And say, when they add the credential it just redirects back to home?

If extension is opened in a separate browser tab yes, everything is happened on one window without opening extension popups.
You can see this behaviour for create identity or backup upload when PR #692 is merged

@AndrewCLu thanks! Please, check if it works with enabled and disabled feature flag properly, so users won't see this feature until it's done (demo and extension).

Yup, I tested on Chrome and Firefox with and without the VERIFIABLE_CREDENTIALS feature on.


Dynamic  from React (React-Helmet)

Would be nice if the example, showed how to use https://github.com/nfl/react-helmet with the server side rendering.
This would allow users to see how to update meta tags, microdata (JSON-LD) ect.
Should be similar to the way CSS-In-JS works, with a ViewBag that's rendered out. But maybe a default helper would be nice, as it's used by a lot of people.

@Saturate +1 for such issue. I have been using both react-helmet and React.NET for a year but didn't manage to find to use it on SSR. I have also opened an issue on react-helmet repo but no answer.

There is a PR opened on this repo to add support for this.
On Sat, Oct 27, 2018 at 04:32, Pavel Poberezhnyi<EMAIL_ADDRESS>wrote:

@Saturate https://github.com/Saturate +1 for such issue. I have been
using both react-helmet and React.NET for a year but didn't manage to
find to use it on SSR. I have also opened an issue on react-helmet repo
but no answer.
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/reactjs/React.NET/issues/605#issuecomment-433612765,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AA5hFh72TTwI1HE5WiQr-P39nBgFKomjks5upEQ6gaJpZM4XZJtD
.

To make it easy, I'll add a link: #615
It dosen't build yet, I see.

This is shipped in 4.0.0-beta5.


Add transaction to containerd

Why we need transaction in containerd:
When docker send grpc messages to containerd, it always forward to exec runc to do something.
And then send back a event to docker.
But if the containerd was killed or crashed after receving grpc message, before sending back the events.
These is no way to recover it. This may cause the data of container not the same between docker and containerd.
How to implement:
We add a transaction mechanism:

Open a transaction:
This will return a Transaction interface and write a transaction data to disk. if containerd is crash or killed or OOMed, it will handle this transacion while next bootup.

 transaction,err := transactionFactory.OpenTransaction(containerID, transactionType, otherMetada)

Close the transaction:
Finishing a transacion, remove the transaction from disk and memory. When the event is handled, we should close it.

 transaction.Close()

Signed-off-by: Wentao Zhang<EMAIL_ADDRESS>

ping @milindchawre I have submit the transaction code which mentioned in https://github.com/moby/moby/issues/32134#issuecomment-312175743

@moypray thanks!

CI failed, I will fix it.

I'm not a huge fan of this. It can potentially add many writes to the disk and wear it down (take for instance healthchecks that execute every few seconds)
I'd rather update the restore mechanism to send an event matching the current state of the container as reported by runc.
wdyt @crosbymichael ?

@mlaventure  Actually,  if the message is lost during sending across goroutine just in memory (not recored in event.log), It can not be recovered at all.( for example, process exit, we delete the container metadata, and generate the event, sent to goroutine to send back to docker, but containerd crashed).
And more, I think restore event is necessary too. Once the event was sent to go routine to send to docker, but not sent done, containerd crashed, and transaction was closed,  We should recover it too.
PS:
I just add processExit Pause and Resume event transaction, I think these events are important.

@moypray in that instance, docker would get a "no such container" error or similar on its the next request and so should act accordingly.

Actually, if containerd lost events，it is not that simple:
Take pause/unpause event example: if docker pause a container, but it lost paused event:

pause process will stuck in waiting for event
this container is running with unpaused in docker, but paused running in runc.
we could not restart/stop/unpause/pause it from docker API.

If we lost process exit event, we could see the process running from docker ps, but actually the container died.

@moypray and I'm still of the mind that it's docker behavior that should be changed.
With the new containerd, I made docker not wait on the event, but directly mark the container paused after it gets a success from the rpc.
The same can actually be done with the current version. The event still need to be monitored in case someone pause the container from outside docker though.
If docker try to do something to a container which state has gotten out of sync, docker should properly handle it, usually the error message includes the reason. Or worse case scenario docker can request the info of the container to resync its status.

Closing this for now. As I said, I think containerd's clients should deal with this on their side, the API provides what they need to do so.


Add neo4j support

This prepares for the upcoming neo4j  support. I hope all changes are correct. But importing a jdl into an application with neo4j support worked very well.
Please make sure the below checklist is followed for Pull Requests.

[ ] Checks are green
[ ] Tests are added where necessary
[ ] Documentation is added/updated where necessary
[ ] Coding Rules & Commit Guidelines as per our CONTRIBUTING.md document are followed

@MathieuAA When the part in the main generator is merged, can jhipster-core be released or is there a problem with the breaking change for JDL application class?

There is a small breaking change in the API, but the generator isn't impacted.
Just tell me when you plan to merge the PR so that I can release

@atomfrede I'd love to have that for the next release, do you know when this can one be merged?

I need to fix the pr in the main generator first I would say. Otherwise the options won't work yet.

Okay then! I'm ready to make a release, just tell me when you're comfortable merging this and I'll follow.


whether it's possible to provide or release a lyric-to-rhythm of checkpoint?

is it possible to release a checkpoint of lyric-to-rhythm model? This doesn't seem to have copyright issues

Sure. I will provide it in some days.

Hi. The checkpoints of EN and ZH lyric-to-rhythm models in Telemelody are now available. We also provide their dictionary in training/lyric2rhythm/dict for your reference.

Thanks for lyric2rhythm model. However, I meet some problems while I infer with this. Could you help?
cmd: python infer_zh.py zh t2m test zh_save
file structure:

Hi! I run the same command in the terminal with the same file structure, but I can't reproduce the issue.  The issue seems to be associated with the file path and perhaps you can double-check it.

Hi! I run the same command in the terminal with the same file structure, but I can't reproduce the issue. The issue seems to be associated with the file path and perhaps you can double-check it.

may I ask the fairseq version you used? I still find errors when load lyric2rhythm model as follows:

output of logging as follows:

it seems that when variable "state" loads from checkpoint missing the value of "args", which results in the default value of "args" make it None and unable to use function "setattr(args, arg_name, arg_val)"
Could you please check it ？ And my fairseq version is fairseq==0.10.0 as requirement.txt.

Hi! I run the same command in the terminal with the same file structure, but I can't reproduce the issue. The issue seems to be associated with the file path and perhaps you can double-check it.

Thanks! I find that it's due to problem of fairseq rather than checkpoint issue.
if others have the same problem, following cmd may help:
pip install soundfile git+git://github.com/pytorch/fairseq.git@b8ea8a9b72c82192da07e3377adf4ebbde16716d

@DrWelles Hi, can you share the t2m/checkpoint_best.pt as well? Thanks in advance.

How? Though it's easy to train this model with released code if you have a GPU

Yes, can you share a link on google drive or Baidu Wangpan? Currently, my machine only supports CPU and it seems tough work...

链接：https://pan.baidu.com/s/1mUE8qFbmT7Mfo3CyfaK-IA
提取码：78lq

How? Though it's easy to train this model with released code if you have a GPU

Yes, can you share a link on google drive or Baidu Wangpan? Currently, my machine only supports CPU and it seems tough work...

链接：https://pan.baidu.com/s/1mUE8qFbmT7Mfo3CyfaK-IA 提取码：78lq

Thanks a lot!

Hi! I run the same command in the terminal with the same file structure, but I can't reproduce the issue. The issue seems to be associated with the file path and perhaps you can double-check it.

Thanks! I find that it's due to problem of fairseq rather than checkpoint issue.
if others have the same problem, following cmd may help: pip install soundfile git+git://github.com/pytorch/fairseq.git@b8ea8a9b72c82192da07e3377adf4ebbde16716d

hi, I try to run the command you provided here, but it seems to have the problem shown below. Since I'm also in China, I wonder if you have encountered the same problem and how you fixed it. Big thanks in advance!

Hi! I run the same command in the terminal with the same file structure, but I can't reproduce the issue. The issue seems to be associated with the file path and perhaps you can double-check it.

Thanks! I find that it's due to problem of fairseq rather than checkpoint issue.
if others have the same problem, following cmd may help: pip install soundfile git+git://github.com/pytorch/fairseq.git@b8ea8a9b72c82192da07e3377adf4ebbde16716d

hi, I try to run the command you provided here, but it seems to have the problem shown below. Since I'm also in China, I wonder if you have encountered the same problem and how you fixed it. Big thanks in advance!

I solved it by following the instructions here ,
git config --global --unset http.proxy git config --global --unset https.proxy git config --global http.https://github.com.proxy socks5://<IP_ADDRESS>:1086 git config --global https.https://github.com.proxy socks5://<IP_ADDRESS>:1086

Hi! I run the same command in the terminal with the same file structure, but I can't reproduce the issue. The issue seems to be associated with the file path and perhaps you can double-check it.

Thanks! I find that it's due to problem of fairseq rather than checkpoint issue.
if others have the same problem, following cmd may help: pip install soundfile git+git://github.com/pytorch/fairseq.git@b8ea8a9b72c82192da07e3377adf4ebbde16716d

Can you provide specific code branches? I need to download that branch and install it myself

For anyone who can't download via the link:
pip install soundfile git+git://github.com/pytorch/fairseq.git@b8ea8a9b72c82192da07e3377adf4ebbde16716d
You may consider this one:
pip install soundfile git+https://github.com/facebookresearch/fairseq.git@b8ea8a9b72c82192da07e3377adf4ebbde16716d

Hi! I run the same command in the terminal with the same file structure, but I can't reproduce the issue. The issue seems to be associated with the file path and perhaps you can double-check it.

Thanks! I find that it's due to problem of fairseq rather than checkpoint issue.
if others have the same problem, following cmd may help: pip install soundfile git+git://github.com/pytorch/fairseq.git@b8ea8a9b72c82192da07e3377adf4ebbde16716d

hi, I try to run the command you provided here, but it seems to have the problem shown below. Since I'm also in China, I wonder if you have encountered the same problem and how you fixed it. Big thanks in advance!

I solved it by following the instructions here , git config --global --unset http.proxy git config --global --unset https.proxy git config --global http.https://github.com.proxy socks5://<IP_ADDRESS>:1086 git config --global https.https://github.com.proxy socks5://<IP_ADDRESS>:1086

for anyone who have same issue

access the following address with web browser
https://github.com/facebookresearch/fairseq/commit/b8ea8a9b72c82192da07e3377adf4ebbde16716d

clik the Browse files

click the Code and then download ZIP

unzip the downloaded zip file

Go to the unzip directory

pip install .


A maths library for Silk.NET

Yet another Maths PR part 3

For future reference: once these comments are addressed, please review Matrix4x4/Matrix3x3 individually, as they provide a lot more stuff not present in the others.


Exclude undefined on property detail page

Proposed Changes
#871
While loading data, the display will look like this:

Implementation

use Skeleton

Tip: Use Fixes #871 instead of #871, so the issue is closed when this PR is merged.


Fix sed commands to work on OS X

Fix sed command as suggested here https://stackoverflow.com/a/19457213/9713409.
Also fix sed regexp patter to match version after golint changes
Signed-off-by: Tomek Urbaszek<EMAIL_ADDRESS>Checklist

[x] Commits are signed with Developer Certificate of Origin (DCO)
[ ] Tests have been added
[ ] A PR is opened to update the documentation on https://github.com/kedacore/keda-docs
[ ] Changelog has been updated

@zroubalik you were right that #1060 may have impacted sed commands 😄 The problem was fixed number of white spaces.


About submit and call sqe from any thread

Previously discussed topic #109, but I couldn’t see a clear answer. Is it possible to use get_sqe and submit from any thread? Are you considering such a development?

It's not possible unless you provide your own mutual exclusion for that, and it'll also exclude you from current and future optimizations that limit a submitter to a single thread/task. We've continually pushed for single thread usage of a ring, and we'll continue to do that. Unless there are very strong reasons for sharing, you should reconsider.


Auth with JWT in Convex Svelte

I am running into some issues with auth using Convex Svelte. I was directed here from the Convex Discord. I feel like I am so close, so thank you for checking this out. This works:

Convex connection to the backend works
Clerk integration (giving me a valid JWT in te below code), I am not married to Clerk, I just want something to work
The line containing INSIDE setAuth is called, and shown in the log in Chrome

...however...:

I cannot see the JWT in the network payload (not quite sure where to look, have looked at the WS-connection)
Identity on the server is null

My "main" file looks like this:
<script lang="ts">
	import { PUBLIC_CONVEX_URL } from '$env/static/public';
	import { setupConvex, useConvexClient } from 'convex-svelte';
	import { SignIn, useClerkContext } from 'svelte-clerk';
	import * as Sidebar from '$lib/components/ui/sidebar/index.js';
	import AppSidebar from '$lib/components/app-sidebar.svelte';
	import '../app.css';

	let { children } = $props();

	const ctx = useClerkContext();
	const isLoaded = $derived(ctx.isLoaded);
	const user = $derived(ctx.user);

	setupConvex(PUBLIC_CONVEX_URL);

	$effect.pre(() => {
		const client = useConvexClient();
		client.setAuth(async () => {
			const token = await ctx.session?.getToken();
			console.log('INSIDE setAuth', token);
			return token;
		});
	});
</script>

This code is created from a discussion on Discord #general. As I mentioned above the console.log-line outputs a valid JWT.
Thanks!

What is the normal response time on these kind of issues?
This is related: https://github.com/get-convex/convex-svelte/issues/11
@thomasballinger

Check for multiple websocket connections, when I tried something similar but different

I got two websocket connections, the second was the one that sent the authenticate message

Same thing with your code, it's creating another convex client for some reason.

Ah nevermind, that's just because my auth token is invalid. This seems to work fine? What's the Authenticate message on your websocket look like?

Sorry about not answering earlier.
{"type":"Authenticate","baseVersion":0,"tokenType":"User","value":"eyJhbGci[SNIPPED]"}
{"type":"AuthError","error":"No auth provider found matching the given token","baseVersion":0}

This is good, I guess, as the token is indeed sent on the wire. Sorry, I am new to Convex and Clerk.
My auth.config.ts-file looks like this:
export default {
  providers: [
    {
      domain: "https://bold-sloth-53.clerk.accounts.dev",
      applicationID: "convex",
    },
  ],
};

I can also see this in the Convex dashboard. In the Clerk-dashboard, I have created a JWT-template called "convex", and the domain in the Clerk-dashboard matches the one in the config file.
Thanks so much for your time and attention, @thomasballinger

This was resolve and was not Svelte-related.


Remove tf.keras.set_learning_phase before it's deprecated

This addresses the following tf.keras warning:
`tf.keras.backend.set_learning_phase` is deprecated and will be
removed after 2020-10-11. To update it, simply pass a True/False
value to the `training` argument of the `__call__` method of your
layer or model.

Since this isn't tested by the CI I tested this locally on my OSS machine via bazel test integrations/tensorflow/e2e/keras:vision_external_tests


[EventHubs & Service Bus] pyamqp fix all typing/docstring

need to fix all typing and docstring
How do we deal with typing Union[uamqp, pyamqp] when uamqp is removed as a dependency in the future? Currently will show up as Union[None, pyamqp] = Optional[pyamqp]. Not sure if this is reasonable.

related issue: #25794

fixed by: #26548


overlays: Add method to check if the correct modal is open.

This will be used to avoid this code syntax:
if (overlays.is_modal_open()) {
   overlays.close_modal("send_later_modal");
}

discussion: https://chat.zulip.org/#narrow/stream/6-frontend/topic/overlays.2Eclose_modal_if_open

Merged, thanks @amanagr!


Fisheye code is missing?

Hi Sean, I was wondering if the https://sbcode.net/react-three-fiber/fisheye/ code is missing or is somewhere I can't find. The code example is incomplete, as the Fisheye and Panorama components do not exist, and there is no code here on the repo. Is this still WIP? Thank you very much for this sort of resources, very much needed, considered the little amount of documentation on the fiber and drei examples ;)

I didnt add it, the repo alrady has too many branches to manage.
The code is here https://sbedit.net/286a29be1a4cb0708b08ba8eccf975b3562a0393
On Fri, Oct 25, 2024 at 6:41 PM Fabio @.***> wrote:

Hi Sean, I was wondering if the
https://sbcode.net/react-three-fiber/fisheye/ code is missing or is
somewhere I can't find. The code example is incomplete, as the Fisheye and
Panorama components do not exist, and there is no code here on the repo. Is
this still WIP? Thank you very much for this sort of resources, very much
needed, considered the little amount of documentation on the fiber and drei
examples ;)
—
Reply to this email directly, view it on GitHub
https://github.com/Sean-Bradley/React-Three-Fiber-Boilerplate/issues/3,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/ABQCUNGV7KG23OX7XEHCBR3Z5J7C3AVCNFSM6AAAAABQTXSJA6VHI2DSMVQWIX3LMV43ASLTON2WKOZSGYYTINZUGE2DEMQ
.
You are receiving this because you are subscribed to this thread.Message
ID: @.***>

Oh, thank you, I missed that button on the pictures :)

Here, I added it to the repo for you.
fisheye branch.
git clone https://github.com/Sean-Bradley/React-Three-Fiber-Boilerplate.git
cd React-Three-Fiber-Boilerplate
git checkout fisheye
npm install
npm start


Set implementation

Implement the ability to pick from sets and set of sets possibly as built.

Functionality added in last merge pull request


Using categorical coloring for separate aggregates

If we have a dataframe with points in it that each have a category assigned in some other column, we can generate a single image from it where each pixel's color is an average of the category colors, weighted by the counts for each category:

However, weighted-color-average plots are also useful in cases where no category field is available.  Right now, if you wanted to use the category coloring to show NYC taxi pickups vs. dropoffs, you could create a new data frame twice as long as the old one, with each row representing a pickup or dropoff only (instead of a pickup,dropoff pair as it is now), and synthesize a new column indicating whether each point was a pickup or a dropoff.  It seems helpful if we provide at least an example, if not a utility, of how to avoid having to doctor the original dataset in this way, because we should be able to make the same calculation simply from the separate aggregates by packing them into the appropriate xarray data structure expected by shade() when given categorical data.

This issue is basically about working with wide rather than tall or tidy data. One suggestion I'd have is accepting lists for the Glyph x and y column references. Then you could express your dropoff/pickup example as:
canvas.points(df, ['pickup_x', 'dropoff_x'], ['dropoff_x', 'dropoff_y'])

and express the kind of problem described in https://github.com/bokeh/datashader/pull/512 as:
canvas.line(df, 'x', ['col1', 'col2', 'col3', ...])

This would make it quite easy to work with wide data with a lot of column you want to aggregate on. I'm sure internally this could also be made efficient.

Right, the example above was about wide data, and I agree that your proposed syntax would make such an example more convenient to do.
In general, though, we should be able to use weighted-color-average plots for any suitable data, including separate aggregate arrays from arbitrary sources (e.g. different dataframes altogether) or from the same source but with arbitrary custom xarray operations on each one before rendering.  So we'd still need a standalone example or utility showing how to combine the separate aggregates into the data structure expected by shade().

Not that such an example should be difficult; I expect it's a one-liner; I just don't have time today to create it, hence the issue. :-)


Refactoring the way formatters are loaded to make easy to include custom formatter

Context
I was talking with a friend once about how pronto can create a huge noise adding too many comments on github, when a PR is big.
By the time, we're discussing how other tool was nice posting the comments as github annotation leaving the comments just for developers.
So, I've thought how it would be nice if pronto could do the same thing.
Workaround
Investigating the code, I noticed that the json formatter wouldn't be enough. I ended up creating this (not yet released) gem pronto-annotations_formatter, which produces a json to be consumed by pronto-annotate-action.
I wasn't happy because I had to do some Monkeypatch stuff to modify the Pronto::Formatter::FORMATTERS, which I think it's really dangerous, but it was the only way I could think.
One could argue "you could've just used a rake task". Well, yeah but I want to shared this solution because more people could benefit from it, and I think nothing is better than a Gem to share this.
Refactoring
After analysing the code again, I thought on how Devise loads its strategies. The same pattern could be applied to formatter.
I branched out the repo and implemented the pattern.
Please check the PR https://github.com/prontolabs/pronto/pull/450.
Now, with this solution I don't need to use Monkeypatch in my Gem, I just need to do:
module Pronto
  module Formatter
    class MyCustomFormatter < Pronto::Formatter::Base
      def format(messages, _repo, _patches)
        # Do stuff
      end
    end
  end
end

Pronto::Formatter.add('mycustom', Pronto::Formatter::MyCustomFormatter)

@emilio2hd please let me know if you want me to make a release for the above tools to depend on -- I'd be eager to try it at $WORK as well :grin:

Hey @ashkulz yahoo! Let's do it!
Thank you!

@emilio2hd pronto 0.11.2 released to RubyGems :tada:

@ashkulz Done! released latest version removing the monkey patch :tada:


I tried to share a pinned note and it threw an error message

When I unpinned it worked.

Thanks for the bug report. I have replicated the issue and fixed in 0.8.4.
Can you please update and test?


README updates for Docker

Information on getting Visual Code + PHP Debug extension working with PHP running in Docker.  It may be worth including in your docs.   Thanks for the great extension!

Not on purpose, but very possibly.  Let me see if I can de-fubar it...

@jasonterando Thanks for the updates here. Even though the PR hasn't been accepted your steps for Windows XDEBUG configuration worked perfectly for me.

@sgwatgit - awesome, glad to help!

This also needs to be updated to reflect the changes for the new pathmappings setting.

I didn't realize anybody was still looking at this.  I've updated to include pathMappings and the built-in Docker localhost aliases.

@jasonterando I think you committed a bad merge

Did a re-merge with master and the CI/CD checks seem to be happier

@jasonterando please look at the file on your branch. It was messed up: https://github.com/jasonterando/vscode-php-debug/blob/c65725e1bd5fcea4034c12776f967af2ccb312e3/README.md

Too bad this isn't merged yet, very helpful additional info! 👍


Fix RuboCop offences

RuboCop 0.40 includes new cops.
https://github.com/bbatsov/rubocop/releases/tag/v0.40.0

We should be locking down the version of Rubocop used, so not to have side effects like this. Would you mind making that change please, I am happy with a Rubocop upgrade.

I went ahead and fixed this up in https://github.com/ruby-grape/grape-swagger/commit/76025377bdde28c61120dda08b5d0edd7ad42e1d. Thank you!

👍 Thanks!


nixos/mysql: run postStart as an unprivileged user

Motivation for this change

general module cleanup
remove the need to run any part of this module as root
keep consistent with upstream
keep consistent with NixOS best practices

My intention is to squash e3c210dfd19f60587a98c055266570d0f950edec (nixos/mysql: run ExecStartPost as an unprivileged user) and a0539fbe8635205ce3e5d0bf4daba316a92651ba (nixos/mysql: move ExecStartPost into postStart) before merge.
Things done

[x] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
Built on platform(s)

[x] NixOS
[ ] macOS
[ ] other Linux distributions

[x] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
[x] Tested execution of all binary files (usually in ./result/bin/)
[ ] Determined the impact on package closure size (by running nix path-info -S before and after)
[ ] Ensured that relevant documentation is up to date
[x] Fits CONTRIBUTING.md.

ping @thorstenweber83

@GrahamcOfBorg test mysql

Merging based on review and feedback. Thanks all :tada:

@GrahamcOfBorg test mysql

The aarch64-linux variant of the test has been failing for a while... so not this PR :man_shrugging:


command decoration hover should not show when the context menu is open

the hover is a little annoying and obscures the terminal a bit too much IMO when the menu is open. @tyriar thoughts?

Let's hide the hover/cancel the timer when opening the context menu


Describe expected response times for responses

I can describe expected return codes, response types and even expected responses via the spec: https://swagger.io/docs/specification/describing-responses/
What I feel is missing right now is the ability to document expected response times. As a developer, I know my endpoint should return in <100ms with a 201.
Is there a way to achieve this today (perhaps via some custom annotation?) or would this require a spec update. If so, how do I formally submit that as a request?

That's an interesting idea.
I guess it would make sense to put it under either operation or server, you could use description or add a custom attribute e.g. x-timeout-ms.
The only problem is, there can always be a delay on the way, so if the operation, including the network transmission, takes 101ms, and client developer imposes that 100ms as a timeout, they lose the response.
The typical default timeout is 30sec for the reason that the internet doesn't guarantee response times.

My intention isn't to fail the response but more use it as a hint. Ie. when the request hits the API to the backend and back - that's the time I'm interested in hinting at.
Other actors can then infer expected behaviour. It would eliminate false callouts as I can see that actually, the dev intended it to take 5 seconds so no point in moaning that it is taking 3.

@rafalkrupinski how do I progress this? Can this be achieved now and if so, how? If not possible today, I'm more than happy to jump on calls / present this proposal. Just let me know where and when and I'll turn up.
Looking forward to PoCing htis if it is possible (I'm an OpenAPI newbie so a noob guide would be great for me :) )

@agardnerIT
OAS allows arbitrary extension fields so I don't think you need to start a long process to change it for your particular needs.
How you support timeouts depends on your tooling.
If you use a code generator to create the client code, you can add an extension field and handle it in the generator (You say you don't want to fail the request, but I guess you'd add a warning).
If the client is coded by hand, you can either use an extension or simply the description field and let the client developer handle it in their code.
It's also a matter of how you create the schema. If it's generated from the server code, it also needs to support adding extension fields.

I would start by suggesting some x- extensions and let's see whether there is interest from a broader group of people.  If it becomes popular we can considering incorporating the values into a future spec update.

Thanks. x-expected-response-time-ms

Does any of the open-source tools you've mentioned support timeout via a x- property so far?

I still have to dig
The first I can mention is the timeoutInMillis property of the x-amazon-apigateway-integration vendor specific object property from tha AWS API Gateway

https://docs.aws.amazon.com/apigateway/latest/developerguide/api-gateway-swagger-extensions-integration.html
https://docs.aws.amazon.com/apigateway/latest/developerguide/api-gateway-swagger-extensions-any-method.html

Costs Codes
Suggestions: x-cost and related x-cost-code
x-cost: "0.03"
x-cost-code: "USD"

Examples
Endpoint Evaluation
I have a system which calls a third party API. I am evaluating between these two APIs. All the usual SLOs apply (response time etc.) but cost is also a major factor. If endpointA costs 30 "whatevers" per call and endpointB costs 3 "whatevers" per call - that's a major plus point for endpointB.
Direct cost tracking
If I have the above, my tooling can aggregate the header data and show:
You have spent 123.45USD over the last 24hrs with endpointA. This is x% of your budget.
Different Definitions of Cost
Cost of course can be monetary, but a "cost" could also indicate other quantities (like a carbon emissions costs).

Doesn't this fall apart once proxy/reverse-proxy servers enter into the picture? They can add to a response time which can't be tracked by the application returning the header, and the client will not be able to tell apart a proxy/app response of 2/5 from 5/2.


Vip 388 add authentication

Bulk add of the middleware.  This commit was easy to make but it's hard to test, and I'm worried I was overzealous.

Oh dear I branched off of main.  hmm.

I'm going to try and fix this weird PR.  I'm pretty sure I followed the same process as for the VIP 387 PR...


Fix to use the latest Islet SDK

Thanks for pulling this forward, @bitboom !
I see that CI tests ran clean with your 1st commit, but then when you tried to re-enable the failing (previously commented) ISLET build-and-test tests, they failed in this build.
I took a quick look and the failiure is here:
 /home/runner/work/certifier-framework-for-confidential-computing/certifier-framework-for-confidential-computing/sample_apps/simple_app_under_islet/islet_example_app.exe --data_dir=./app2_data/ --operation=get-certified --measurement_file=example_app.measurement --policy_store_file=policy_store '' '' --print_all=true
Simulated attestation operation on x86_64.
certify_domain():1735: enclave_type_ = 'islet-enclave', purpose_ = 'authentication'
islet_Attest(): rv=0
certify_domain() error, line: 2024, Certification failed, status='failed'

Response:
Status                 :  failed
++ cleanup
Requesting enclave     :  requesting-enclave
++ set +x
Providing  enclave     :  providing-enclave
certify_primary_domain() error, line 1477, can't certify primary domain
main() error, line 447, certification failed
run_example.sh: Failed command, "$@", at line 626 ./run_example.sh while executing function run_app_by_name_as_server_talk_to_Cert_Service
cleanup.sh: Cleanup stale processes (parent_pid=17455) ...

It was not immediately obvious to me if this is a failure due to (a) Islet-APIs changing or (b) if it's an error with driver run_example.sh script.
If it is (b), let me know. I can look at it later.
I was hoping to get the previous PR #243 integrated first, where failing tests are commented out. Then, you can layer your fix on top of that. Am waiting for Ye & you to sign-off on my PR which basically comments out failing tests.

It was not immediately obvious to me if this is a failure due to (a) Islet-APIs changing or (b) if it's an error with driver run_example.sh script.

It is assumed that there might be a problem with the openssl certificate depending on the environment.
Because Islet API was successful on CI and my environment too.

islet_Attest(): rv=0

The certificate error did not occur in my environment but occurred in the CI as you said.
run_example.sh: simple_app_under_islet: Running run_app_by_name_as_client_make_trusted_request

Running App as client
Client peer id is Measured-6190eb90b293886c172ec644dafb7e33ee2cea6541abe15300d96380df525bf9
SSL client read: Hi from your secret server
`

Hi, @bitboom,
Re: It is assumed that there might be a problem with the openssl certificate depending on the environment.
... The CI build.yml is doing standard install of openssl libraries:
 17     - name: dependencies
 18       run: |
 19         sudo apt update -y
 20         sudo apt install -y clang-format-11 libgtest-dev libgflags-dev openssl libssl-dev protobuf-compiler proto    c-gen-go golang-go cmake

We will need to debug this in CI's env and on your machine, to compare the OpenSSL library versions.
That is a bit of painful effort.
What you will need to do is to edit out all the test-methods (after install) in .github/workflows/build.yml and just keep this these test-methods active.
Check-in this to your dev-branch so that the CI-roundtrip is shortened to just this set of ISLET related failing test-methods.
155     #! -------------------------------------------------------------------------
156     - name: test-ISLET-SDK-shim_test
157       run: |
158         ./CI/scripts/test.sh test-ISLET-SDK-shim_test
159
160     #! -------------------------------------------------------------------------
161     - name: test-run_example-simple_app_under_islet-using-shim

And add some commands in the name: dependencies step to report the openssl version.
I don't know what / how to report the OpenSSL version string. But if you can add that, we can compare the version string that CI installs v/s what's on your dev-box.
Once we find out what the differences are ... we can tweak the sudo apt install openssl command to specify a particular version string.
I think this troubleshooting / debugging will be a slow exercise.
I'll leave it up to you to figure out if this is the best way to troubleshoot, or you have any better ideas to figure out what the OpenSSL version issue is (or might be).

@bitboom -- I just merged the PR #243 which comments out failing test-cases.
You should now be able to integrate your work to re-enable ISLET-related failing tests. FYI.

Nice work, @bitboom !


1.20.5+ update

Hi, I don't what the intent is with this project as far as updating goes but I've had a look at reimplementing the advancements in the new component based system (1.20.5+ and datapack format 33+). I've hit a wall in progress, the issues is documented on reddit. Long story short the nbt tag has been removed and replaced with components the following:
"items": ["minecraft:tropical_fish_bucket"],
"components": {
  "minecraft:bucket_entity_data":{
    "BucketVariantTag": 67502593
  }
}

Naturally caught fish will also have a health tag inside minecraft:bucket_entity_data. Unfortunately in the current state there needs to be an exact match so something like this should work:
"items": "minecraft:tropical_fish_bucket",
"components": {
  "minecraft:bucket_entity_data": {
    "Health": 3.0,
    "BucketVariantTag": 67502593
  }
}

However health is implicitly converted to an int, which breaks the advancement. I don't know that there is a workaround for this at the current moment, I'm told this is a bug. Whether this will be fix or when, no idea. But I thought I would leave this here if anyone else is interested in trying to upgrade the datapack, or looking for an updated one

Hi, I have no more ideas than you. I found your bug ticket, I'm posting it here to keep track: https://bugs.mojang.com/browse/MC-272531

I've added another bug, much simpler this one as it just restores previous functionality so there is some hope it would get fixed sooner MC-272893

Been trying to update this pack myself for 1.21.0
Running into the same problem with the new Item Component matching.
Did however find this works which could (in theory) be done via a function...
execute if items entity @s hotbar.* tropical_fish_bucket[minecraft:bucket_entity_data={BucketVariantTag:67699456,Health:3.0f}] run advancement grant @s only tropicalfish:dasher/cyan/pattern_yellow
execute if items entity @s inventory.* tropical_fish_bucket[minecraft:bucket_entity_data={BucketVariantTag:67699456,Health:3.0f}] run advancement grant @s only tropicalfish:dasher/cyan/pattern_yellow
That would obviously need that generated out for each variant to be checked against.

MC-272893 was resolved as "working as intended", so that route is closed, quite disappointing as that was the most promising resolution

Been trying to update this pack myself for 1.21.0
Running into the same problem with the new Item Component matching.
Did however find this works which could (in theory) be done via a function...
execute if items entity @s hotbar.* tropical_fish_bucket[minecraft:bucket_entity_data={BucketVariantTag:67699456,Health:3.0f}] run advancement grant @s only tropicalfish:dasher/cyan/pattern_yellow execute if items entity @s inventory.* tropical_fish_bucket[minecraft:bucket_entity_data={BucketVariantTag:67699456,Health:3.0f}] run advancement grant @s only tropicalfish:dasher/cyan/pattern_yellow
That would obviously need that generated out for each variant to be checked against.

how would that work in terms of performance? does it need to be checked each game tick or can it be done once and set? cuz its one thing to check everygame tick for one or two but when dealing with 3k of them I would expect some serious lag issues

Even with the old method, the game has to be evaluating all those advancements anyway.

Fair enough, seems like it will end up being the only viable solution

how would you set up the advancement in that? you're handling the trigger in the command, are you leaving the advancement trigger just empty?

The only other idea I had, but couldn't figure out the command to do it, would be to check the players inventory for any tropical_fish_bucket and remove the Health value from them.

The only other idea I had, but couldn't figure out the command to do it, would be to check the players inventory for any tropical_fish_bucket and remove the Health value from them.

I wanna avoid messing with the vanilla item data, there was also the possibility to use the custom data tag to inject the BucketVarientTag when they get picked up but I wanna keep them as vanilla as possible

Yeah I can appreciate that. I even tried putting "Health": 3.0f in the json but that didn't work either.

Yh no tried the same and a bunch of other iteration to see if I can get to convert to a float, I did come up with a workaround of if you use some value that cannot be converted to an int like 2.5 and somehow managed to do 0.5 damage to a fish before catching it would work, but again quite dangerous and silly

@EclairDeFeu360 told me he may have found a solution, he will check this week end if he has some time

WIP https://github.com/AntoninHuaut/TropicalFish/pull/8 (currently broken), @EclairDeFeu360 will recheck it later

Merge request merged, here are the packs, I will leave the issue open if you find problems
TropicalFish-resource.zip
TropicalFish-data.zip

Would it be possible to remove the "custom_data" after the checking for advancements or is that kinda timing not possible? it feels like its kinda soiled the items to leave that data in, after spending countless hours catching these only for them to be technically non vanilla, the custom_data sticks around even when you release the fish and re-catch it

I don't think the advancement would have the time to trigger between the two change of the item, but yes it is possible to remove back de custom_data et re-giving the item. The custom_data has to be on the item for every player that gets the fish, so I don't see the interest in removing it.
I don't understand what you mean by "technically non vanilla", vanilla means you use the version.jar given by Mojang without any modification, data pack are vanilla and this data pack use only vanilla mechanism.

Thats okay, just wanted to keep the items "clean"

I understand, but I don't think I'll touch the method until Minecraft makes it easier.

Feel free to send a merge request if you find a better way to do it @zer0p1us

When the player gets a tropical fish bucket, the BucketVariantTag is copied into custom data components that can be easily detected by advancement.

Yeah we already tried that (see thread above) but the problem is getting it to also either match or ignore the Health attribute that was alongside it. Can't currently be done in a predicate as there is no item sub-predicate for the bucket data.

With the new solution, we didn't copy Health, so no problem.

Got an answer for MC-272531, using "minecraft:bucket_entity_data": "{Health:3f,BucketVariantTag:67502593}" will do the trick, still will need the health but at least now it works correctly, then you can have one for each level of health, like 0.1, 0.2, ... 3.0

Fair enough, seems like it will end up being the only viable solution

Just a quick update. Been running my "execute if items" method on a community server since 29th June with great results and no noticeable performance impact.
Wrote a new script to generate all the datapack files, which can be found at...
https://github.com/davepusey/TropicalFish/tree/davepusey


Feedback for collated code A0144915A

Your team doesn't have test and docs contributions collated. Note that they are graded too.
Unmodified address book code cannot be claimed. Check for your Command class claims.
No javadoc comment for a really important class. There are other more instances of this in the code.
public abstract class AbstractCommand implements Command {
Revise method name (this seems to be true for everyone in the team)
private boolean validCommand(String command) {
private CommandResult makeAliasUsed(String alias) {
Needs comments for private methods too if their functionality is not obvious from their signature
Code in this class needs to be refactored. public class ResultBoxController { It is ugly, unreadable and difficult to test.

@cmkumar87 Thanks for your feedback. I wish to clarify some of the feedback you gave:

Your team doesn't have test and docs contributions collated. Note that they are graded too.

Yep, the tests are now collated. Will work on docs next. Thanks for the reminder.

Unmodified address book code cannot be claimed. Check for your Command class claims.

We do not have a Command class, but we do have a Command interface. Our Command interface was not taken from address book. Please compare that with address book's Command. The only thing that is similar is the execute method.

Code in this class needs to be refactored. public class ResultBoxController { It is ugly, unreadable and difficult to test.

This is a temporary class. It will be removed soon.


AssertionError: all(param .>= lower_bound)

jregier@edison04~/Celeste/bin $ ~/julia/bin/julia ./celeste.jl --logging=debug infer-field 4263 5 119 .
2016-07-13T19:15:58 - info: Running with 1 threads
2016-07-13T19:15:59 - info: reading photoobj catalogs for 1 fields
2016-07-13T19:15:59 - info: field (4263,5,119): reading /scratch1/scratchdirs/jregier/celeste/4263/5/119/photoObj-004263-5-0119.fits
2016-07-13T19:16:00 - info: field (4263,5,119): 1164 entries
2016-07-13T19:16:00 - info: field (4263,5,119): 1070 filtered entries
2016-07-13T19:16:00 - info: 1070 primary sources
2016-07-13T19:16:00 - info: 585 primary sources after MIN_FLUX cut
[1] processing 585 sources in -1000.0, 1000.0, -1000.0, 1000.0
2016-07-13T19:16:00 - info: reading field (4263,5,119)
2016-07-13T19:16:10 - debug: Converged.
2016-07-13T19:16:11 - debug: Image names:
2016-07-13T19:16:11 - debug: ASCIIString["1 run=4263 camcol=5 119=field b=1","2 run=4263 camcol=5 119=field b=2","3 run=4263 camcol=5 119=field b=3","4 run=4263 camcol=5 119=field b=4","5 run=4263 camcol=5 119=field b=5"]
2016-07-13T19:16:11 - info: finding neighbors
2016-07-13T19:16:13 - info: neighbors found in 2.045215298 seconds
[1] processing source 1: objid =<PHONE_NUMBER>734490632
2016-07-13T19:16:14 - debug: Fitting PSFS for band 1
2016-07-13T19:16:15 - debug: Converged.
2016-07-13T19:16:15 - debug: Converged.
2016-07-13T19:16:15 - debug: Fitting PSFS for band 2
2016-07-13T19:16:16 - debug: Converged.
2016-07-13T19:16:16 - debug: Converged.
2016-07-13T19:16:16 - debug: Fitting PSFS for band 3
2016-07-13T19:16:17 - debug: Converged.
2016-07-13T19:16:17 - debug: Converged.
2016-07-13T19:16:17 - debug: Fitting PSFS for band 4
2016-07-13T19:16:18 - debug: Converged.
2016-07-13T19:16:18 - debug: Converged.
2016-07-13T19:16:18 - debug: Fitting PSFS for band 5
2016-07-13T19:16:18 - debug: Converged.
2016-07-13T19:16:18 - debug: Converged.
2016-07-13T19:16:18 - debug: Converged.
2016-07-13T19:16:37 - info: f_evals: 10 value: -4563.256375512825
2016-07-13T19:16:38 - info: f_evals: 20 value: -4450.676682122572
2016-07-13T19:16:38 - debug: Converged.
2016-07-13T19:16:38 - info: got -4450.672965894216 at [0.03787045978041723,0.024332296017840146,0.9708355610601683,0.525899845302785,0.1640988531313554,-1.6449415920025874,-1.5174074072450432,-0.5828966128574988,-5.223804607761549,-5.9842482605787515,0.49630898748007013,0.2753768919058647,0.14707845807218184,0.08581222749138939,0.32884625121176153,0.19617185582133934,0.1644093898760099,0.06362001693911477,-3.228492958418526,-5.668886684706955,-7.380007555562356,-6.565198740937389,-1.7918574553626188,-5.625573713209564,-7.729045076698093,-5.581097293120845,-12.544477501102651,-5.154497745550497,4.047713156199306] after 21 function evaluations (21 Newton steps)

[1] processing source 2: objid =<PHONE_NUMBER>734490633
2016-07-13T19:16:38 - debug: Fitting PSFS for band 1
2016-07-13T19:16:39 - debug: Converged.
2016-07-13T19:16:39 - debug: Converged.
2016-07-13T19:16:39 - debug: Fitting PSFS for band 2
2016-07-13T19:16:40 - debug: Converged.
2016-07-13T19:16:40 - debug: Converged.
2016-07-13T19:16:40 - debug: Fitting PSFS for band 3
2016-07-13T19:16:41 - debug: Converged.
2016-07-13T19:16:41 - debug: Converged.
2016-07-13T19:16:41 - debug: Fitting PSFS for band 4
2016-07-13T19:16:42 - debug: Converged.
2016-07-13T19:16:42 - debug: Converged.
2016-07-13T19:16:42 - debug: Fitting PSFS for band 5
2016-07-13T19:16:42 - debug: Converged.
2016-07-13T19:16:42 - debug: Converged.
2016-07-13T19:16:42 - debug: Converged.
2016-07-13T19:16:43 - info: f_evals: 10 value: -4580.415051653092
2016-07-13T19:16:45 - info: f_evals: 20 value: -4531.60397881423
2016-07-13T19:16:45 - debug: Converged.
2016-07-13T19:16:45 - info: got -4531.601729420286 at [-0.019238949311993936,0.043868302700383575,0.9022031855639222,1.76578699226045,0.9945903568306385,-1.8647196477314087,-1.573785296257084,-0.640591670762025,-4.790495778851658,-5.362545841147815,0.2874301589204561,0.1469416395028496,0.08041406079035218,0.0447009187551439,0.17217800838975392,0.1523987346703135,0.10373656870891604,0.04815029298337316,-3.3281635375742193,-6.098491804456352,-6.800825774372866,-6.310903230612395,-3.1414570383069345,-5.927230648098809,-6.9341046722064155,-4.958351110771209,-12.47170657520326,-5.640399424701623,-4.311928269193841] after 21 function evaluations (21 Newton steps)

[1] processing source 3: objid =<PHONE_NUMBER>734490643
2016-07-13T19:16:45 - debug: Fitting PSFS for band 1
2016-07-13T19:16:46 - debug: Converged.
2016-07-13T19:16:46 - debug: Fitting PSFS for band 2
2016-07-13T19:16:47 - debug: Fitting PSFS for band 3
2016-07-13T19:16:48 - debug: Converged.
2016-07-13T19:16:48 - debug: Fitting PSFS for band 4
2016-07-13T19:16:49 - debug: Converged.
2016-07-13T19:16:49 - debug: Fitting PSFS for band 5
2016-07-13T19:16:49 - debug: Converged.
2016-07-13T19:16:49 - debug: Converged.
2016-07-13T19:16:50 - info: f_evals: 10 value: -603928.9038970873
2016-07-13T19:16:51 - info: f_evals: 20 value: -298841.08572333166
2016-07-13T19:16:52 - info: f_evals: 30 value: -226367.9745917162
2016-07-13T19:16:52 - debug: Converged.
2016-07-13T19:16:52 - info: got -226363.7593383573 at [0.0021379224805298967,0.009879328022192858,4.488918359538113,1.666218542192551,-0.35509586732944143,-4.427262581271157,3.4415740456989923,2.0993653091565734,-14.231590402103327,-18.205814539516048,0.39683827324524523,0.03127387861738382,-0.03971620927040686,-0.013633876195840519,0.17748459096352362,0.04850482546761417,0.007850664908469416,0.1435483190169801,-14.19852934722203,-14.267494384697612,-14.77997299474101,-14.692017215344869,-18.161334196106313,-18.313875502724855,-18.904098041480584,-18.790520352098355,-14.180135787908613,10.054872963313473,4.402596246113861] after 34 function evaluations (34 Newton steps)

[1] processing source 4: objid =<PHONE_NUMBER>734490644
2016-07-13T19:16:53 - debug: Fitting PSFS for band 1
2016-07-13T19:16:53 - debug: Converged.
2016-07-13T19:16:53 - debug: Fitting PSFS for band 2
2016-07-13T19:16:54 - debug: Fitting PSFS for band 3
2016-07-13T19:16:55 - debug: Converged.
2016-07-13T19:16:55 - debug: Fitting PSFS for band 4
2016-07-13T19:16:56 - debug: Converged.
2016-07-13T19:16:56 - debug: Fitting PSFS for band 5
2016-07-13T19:16:56 - debug: Converged.
2016-07-13T19:16:56 - debug: Converged.
2016-07-13T19:16:58 - info: f_evals: 10 value: -4339.859780143187
2016-07-13T19:16:58 - debug: Converged.
2016-07-13T19:16:58 - info: got -4338.373225555978 at [0.021865249606559018,0.010599753061147344,-5.5004459739677545,-2.298992409682072,0.28297059887229353,-6.4222903308032,-0.7693002018620713,-0.7659519269308221,-13.644119003006496,-9.759860774611878,0.5041594357171094,0.25016245968275835,0.16480174932283898,0.09234555141556999,0.4775907070364475,0.2503941137048574,0.16417348145134894,0.09252378274247916,-2.17420304766751,-7.135029987049332,-13.739364410971945,-8.101809849395414,-2.2905820044796834,-7.145145320146457,-10.119559985856986,-8.092477181268006,7.826923218689212,13.118585526792096,1.395574648604652] after 17 function evaluations (17 Newton steps)

[1] processing source 5: objid =<PHONE_NUMBER>734490645
2016-07-13T19:16:59 - debug: Fitting PSFS for band 1
2016-07-13T19:16:59 - debug: Converged.
2016-07-13T19:16:59 - debug: Converged.
2016-07-13T19:16:59 - debug: Converged.
2016-07-13T19:16:59 - debug: Fitting PSFS for band 2
2016-07-13T19:17:02 - debug: Fitting PSFS for band 3
2016-07-13T19:17:03 - debug: Converged.
2016-07-13T19:17:03 - debug: Converged.
2016-07-13T19:17:04 - debug: Converged.
2016-07-13T19:17:04 - debug: Fitting PSFS for band 4
2016-07-13T19:17:04 - debug: Converged.
2016-07-13T19:17:04 - debug: Converged.
2016-07-13T19:17:05 - debug: Converged.
2016-07-13T19:17:05 - debug: Fitting PSFS for band 5
2016-07-13T19:17:05 - debug: Converged.
2016-07-13T19:17:05 - debug: Converged.
2016-07-13T19:17:05 - debug: Converged.
2016-07-13T19:17:05 - debug: Converged.
2016-07-13T19:17:07 - info: f_evals: 10 value: NaN
ERROR: LoadError: AssertionError: all(param .>= lower_bound)
 in unsimplexify_parameter at /global/homes/j/jregier/.julia/v0.4/Celeste/src/Transform.jl:189
 in perform_transform! at /global/homes/j/jregier/.julia/v0.4/Celeste/src/Transform.jl:484
 in from_vp! at /global/homes/j/jregier/.julia/v0.4/Celeste/src/Transform.jl:629
 in from_vp at /global/homes/j/jregier/.julia/v0.4/Celeste/src/Transform.jl:636
 in array_to_vp! at /global/homes/j/jregier/.julia/v0.4/Celeste/src/Transform.jl:670
 in f_objective at /global/homes/j/jregier/.julia/v0.4/Celeste/src/OptimizeElbo.jl:103
 in f_value_grad at /global/homes/j/jregier/.julia/v0.4/Celeste/src/OptimizeElbo.jl:121
 in f_grad at /global/homes/j/jregier/.julia/v0.4/Celeste/src/OptimizeElbo.jl:145
 in f_grad! at /global/homes/j/jregier/.julia/v0.4/Celeste/src/OptimizeElbo.jl:149
 in fg! at /global/homes/j/jregier/.julia/v0.4/Optim/src/types.jl:229
 in __newton_tr#40__ at /global/homes/j/jregier/.julia/v0.4/Celeste/src/newton_trust_region.jl:301
 in maximize_f at /global/homes/j/jregier/.julia/v0.4/Celeste/src/OptimizeElbo.jl:225
 in maximize_f at /global/homes/j/jregier/.julia/v0.4/Celeste/src/OptimizeElbo.jl:263
 in infer_source at /global/homes/j/jregier/.julia/v0.4/Celeste/src/Infer.jl:94
 in infer at /global/homes/j/jregier/.julia/v0.4/Celeste/src/api.jl:374
 in infer_field_nersc at /global/homes/j/jregier/.julia/v0.4/Celeste/src/nersc_io.jl:403
 in main at /global/u2/j/jregier/Celeste/bin/celeste.jl:63
 in include at ./boot.jl:261
 in include_from_node1 at ./loading.jl:320
 in process_options at ./client.jl:280
 in _start at ./client.jl:378
while loading /global/u2/j/jregier/Celeste/bin/celeste.jl, in expression starting on line 82

Hi @rgiordan -- Do you have any time to look into this error? It might have been triggered by my change to the trust region method, but the error comes from the Transform module, and I'm not too familiar with that code.

Sure, but could you do me a favor and send a more minimal example?
On Wed, Jul 13, 2016 at 10:29 PM, Jeffrey Regier<EMAIL_ADDRESS>wrote:

Hi @rgiordan https://github.com/rgiordan -- Do you have any time to
look into this error? It might have been triggered by my change to the
trust region method, but the error comes from the Transform module, and I'm
not too familiar with that code.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/jeff-regier/Celeste.jl/issues/236#issuecomment-232540437,
or mute the thread
https://github.com/notifications/unsubscribe/AESWPs4eu644jRmlesY2Q-32vV2b3TH2ks5qVZ7ugaJpZM4JMBaw
.

A more minimal example to reproduce, I mean.  It is pretty unlikely that a
change to the optimization code could cause this.  Just because it is an
error coming from the Transform module doesn't mean it's a problem with the
Transform module -- this happens when you request a transform from an
illegal value of an unconstrained parameter, which is likely caused by
something you were doing outside.
On Thu, Jul 14, 2016 at 11:51 AM, Ryan Giordano<EMAIL_ADDRESS>wrote:

Sure, but could you do me a favor and send a more minimal example?
On Wed, Jul 13, 2016 at 10:29 PM, Jeffrey Regier<EMAIL_ADDRESS>
wrote:

Hi @rgiordan https://github.com/rgiordan -- Do you have any time to
look into this error? It might have been triggered by my change to the
trust region method, but the error comes from the Transform module, and I'm
not too familiar with that code.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/jeff-regier/Celeste.jl/issues/236#issuecomment-232540437,
or mute the thread
https://github.com/notifications/unsubscribe/AESWPs4eu644jRmlesY2Q-32vV2b3TH2ks5qVZ7ugaJpZM4JMBaw
.

This issue seems to have worked itself out, or at least I can't recreate it any more.


Add a --check flag

I don't like github workflows that generate code and push, which go-codegen can be used to create. Instead, I like workflows that check validity.
Therefore, I want to add a --check flag where go-codegen checks whether or not the output file provided (with -o flag) matches the output of the program.

Unfortunately, it seems the code generation is not deterministic, so a naive implementation doesn't work.


Don't warn for import of optional dependencies

Based on @sokra's suggestion, this PR silences warnings like the below of import statements of optional dependencies.

It's really annoying to see these warnings.

Would it be possible to resolve this warning? It's not critical, but it does clutter the build process with warning messages.
In my case I get the following warning:
<w> [webpack.cache.PackFileCacheStrategy/webpack.FileSystemInfo] Parsing of /Users/.../node_modules/velite/dist/velite-B_2ACfq8.js for build dependencies failed at 'import(configUrl.href)'. <w> Build dependencies behind this expression are ignored and might cause incorrect cache invalidation.


Support for comments on Epics

Epics were not yet supported to have their notes manipulated. With this
change, notes can be listed, created, updated, and deleted. The
conventions are followed that are set by Snippets, Merge Reqeuests, and
Issues.

Thanks @ZJvandeWeg! I made a few tiny comment updates, the rest looks great 👍

@svanharmelen Thanks for the commit, and for the rapid turn around in general!


Sapper Typescript Pug Example

I'am trying to get sapper with rollup to work with typescript and pug, but I just can't wrap my head around the build process.
Is there any change to get a example with the above mentioned tech?
Thank you

Regarding Pug, you have to use mixins. Maybe answer can help you: https://stackoverflow.com/a/51809972/2675387

maybe need to clarify. You don't even get the start sapper project to compile with pug and ts. I don't use and svelte html control structures at this point.

might also be helpful to have the example rollup.config.js close to the one generated by sapper rollup.config.js

@burner to preprocess pug and typescript you should just install typescript, pug, import preprocess from 'svelte-preprocess' and pass it to the svelte preprocess option:
preprocess: preprocess()

For typescript, you should also config your tsconfig.json.
Once I get some spare time I'll provide a sapper example in the examples directory 👍

@kaisermann thank you for coming back to me.
I created a PR that shows where I want to go with this.

@burner Sapper example was added 🎉

@kaisermann thank you very much. I still got a problem though.
/blog gives me
preprocess/examples/sapper_ts_pug_scss/src/routes/blog/index.svelte
'posts' is not defined

The page shows a 500 with
ReferenceError: posts is not defined


[core] Mouse buttons middle-right exchanged in web

It seems that MOUSE_MIDDLE_BUTTON and MOUSE_RIGHT_BUTTON are exchanged in PLATFORM_WEB. This issue probably depends on GLFW3 version used by emscipten vs desktop one.
Needs some review...

Reviewed, it seems it works ok now... corrected on commit https://github.com/raysan5/raylib/commit/3396743aba163545eb186beb47667d55d38528e9
Testing environment:
Google Chrome 53.0.2785.143 m
Surface Pro 3 with standard Mouse
Compiled with emscripten 1.35.0


List what changes in CAPA

### Tasks
- [ ] https://github.com/giantswarm/roadmap/issues/2518

Closed in favour of https://github.com/giantswarm/giantswarm/issues/29613


Can't drag items multiple times?

Hi, I'm using Angular and Sortable. Everything works great, except that once I "place" a dragged element, I can no longer "pick up" or "place" any more elements, including the original one that was moved and dropped. I am not using an ng-repeat loop, I'm using a pre-defined group of divs within a container.
I can't find any "off events" that would prevent dragging after initial action, has anyone encountered this before?

I was able to solve this by moving some functions to "offUpEvents(); so basically, in the event that "this" object is moved, set ghost + chosen class to false.
			if (moved) {
				evt.preventDefault();
				!options.dropBubble && evt.stopPropagation();
				_toggleClass(dragEl, this.options.ghostClass, false);
				_toggleClass(dragEl, this.options.chosenClass, false);
			}

--
is there a better way than removing all the logic that follows (i.e. I'm not using cloning so I don't know if this approach breaks anything)

Certainly you have chosen a wrong path, but if you is suitable why not.


Blog app - creating a data model

In this PR I was able to:

Install Ruby on Rails framework.
Use Ruby Gems as a software packages system.
Understand what ORM is.
Use database migration files to maintain database schema.

Hi @haliljon,
While you made a great effort in this project, unfortunately, I cannot proceed to review your code.
Invalid Code Review Request
You do not have a descriptive readme file. Kindly use the template
Your Code Review Request will be marked as invalid in your Dashboard, so please submit a new one once you are ready 🙏
Cheers and Happy coding!👏👏👏
Feel free to leave any questions or comments in the PR thread if something is not 100% clear.
Please, do not open a new Pull Request for re-reviews. You should use the same Pull Request submitted for the first review, either valid or invalid unless it is requested otherwise.

Invalid Code Review Request does not count into the code reviews limit.


InternshipEngagementListItemCard

Closes #210
Added the following data per Seth's instructions:

Intern Name
Country of Origin
Status
Position
ESAD/MOU End Date

@CarsonF changes made 👍


Invite Rewards Screen loads incorrectly

Description
When I open Rewards,

social logos render incorrectly
invite link disappears by itself after a few moments
opening the information module breaks page

Which network did you use?
celo
Supporting data

fixed here: https://github.com/GoodDollar/GoodDAPP/pull/3904/commits/45e0328f8318602f6d11a105f0f144c4fa422f77
@johnsmith-gooddollar https://github.com/GoodDollar/GoodDAPP/issues/3939 open pr here with at least a partial fix for copying not working always. But that the link sometimes does not load. no clue, and I don't have a way to debug it properly.

Only on IOS. Seems to be only on IOS < 12. When navigate to rewards, back to homepage, back to rewards it does show up?

@patpedrosa cannot replicate, in what way does it break?

Verified on prod


CI: run style checks on CI

Run black&isort&pyupgrde on the CI.
There is no need to run it for all python versions/platforms: only running on 3.8@linux for now.

@Dr-Irv Would you prefer using pre-commit for black/isort/pyupgrade? Using pre-commit would also make it easier to add more linters in the future (maybe flake8-pyi).

@Dr-Irv Would you prefer using pre-commit for black/isort/pyupgrade? Using pre-commit would also make it easier to add more linters in the future (maybe flake8-pyi).

Yes, that would be preferred. Can you set that up?


storage plugins have inconsistent signatures for doTransfer()

from https://hypernews.cern.ch/HyperNews/CMS/get/comp-ops/2363/2/2/1/4/1/3.html
On 06/18/2015 12:09 PM, Andrea Sciaba' wrote:>

*** Discussion title: Computing Operations
Hi Justas,
there is a problem with the newest WMCore, the various storage plugins
have inconsistent signatures for the doTransfer() method.
I wanted to use the new interface for SAM but I cannot without hacking
the WMCore code.
Cheers,
     Andrea

On 17-Jun-15 10:51, Justas wrote:

*** Discussion title: Computing Operations
Hi All,
For SAM tests to use gfal2, they have to update to newest WMCore version
but newest WMCore does not have tag created yet with this fix and
without it it will not work:
https://github.com/dmwm/WMCore/commit/b9626711bc154ed20d40729429244e641b2cbf87
Out of topic:
For David`s case, this is the line which says to use srmv2-lcg plugin
from WMCore and which uses lcg-cp
https://github.com/dmwm/CRABServer/blob/master/scripts/cmscp.py#L1519
Direct stageout in CRAB3 does not read site-local-config.xml and uses
lcg-cp. So if this transition is starting now, we also have to change
CRAB3 code to use gfal2 and have fallback to lcg-cp.
Cheers,
Justas

Visit this CMS message (to reply or unsubscribe) at:
https://hypernews.cern.ch/HyperNews/CMS/get/comp-ops/2363/2/2/1/4/1.html

Visit this CMS message (to reply or unsubscribe) at:
https://hypernews.cern.ch/HyperNews/CMS/get/comp-ops/2363/2/2/1/4/1/3.html

All the changed plugins are in the Plugins directory, which AFAIK no one is using anywhere. All sites use the Backends directory implementations.


Add batch endpoint to environments

Hello @annatisch!  @mcardosos tells me that you can help us find the complete list of Azure endpoints for batch management?  Right now I have https://batch.core.windows.net/, are there separate endpoints for the sovereign clouds?

@annatisch perfect thanks!

Fixed in https://github.com/Azure/go-autorest/releases/tag/v10.2.0.


Exception thrown when firstQuartile and thirdQuartile are equal in @vx/stats/computeStats

In a way, it's a very uncommon case. On the other hand it can happen more often than not if your dashboard lets users filter data freely.
My data array turned out as follows: [10000, 2400, 10000, 10000]
If I feed it into computeStats, the function will compute:
firstQuartile: 10000
thirdQuartile: 10000
IQR: 0 (firstQuartile - thirdQuartile)
Now, IQR is used as a multiplier and as a divisor in several places, turning up 0's and NaN's that eventually just crash the program.
Should computeStats "exit gracefully", for example returning an empty { boxPlot, binData } object and a readable console error stating that the stats provided do not allow to compute a boxPlot?
I guess I can easily wrap the function call in a try/catch block for now, but I wouldn't rely on the fact that every developer out there will test their app with such a strange array. But their apps will crush in production once fed with real world data...

Yes computeStats should handle error states such as above gracefully. Might take me a bit to get around to fixing this, but will tag it with a help wanted label in the mean time. Happy to review PRs that come in.

I'd be happy to send a PR. Do you have any recommendation or guideline on
how to treat it though? Or even an example of how such cases are handled in
other libraries?
Il giorno mar 26 feb 2019 alle ore 15:48 Harrison Shoff <
<EMAIL_ADDRESS>ha scritto:

Yes computeStats should handle error states such as above gracefully.
Might take me a bit to get around to fixing this, but will tag it with a help
wanted label in the mean time. Happy to review PRs that come in.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/hshoff/vx/issues/427#issuecomment-467466667, or mute
the thread
https://github.com/notifications/unsubscribe-auth/AAs8PI2eM7CAzcMmplC0lUnD0veM_9PNks5vRUlXgaJpZM4bQV6m
.

We would want it to end up something like this:

I also think that the median, firstQuartile and thirdQuartile are not computed correctly in computeStats.
For example, the median of the array [1, 2, 3, 4] would be the average (mean) of the numbers 2 and 3, hence 2.5. While the median of the array [1, 2, 3, 4, 5] is 3.
computeStats instead would, in the first case, select 3 as the median. A similar thing goes on with firstQuartile and thirdQuartile.
Unless there is a specific reason for this, I'd correct it as well.

@conglei ^any thoughts on this computation?

I also think that the median, firstQuartile and thirdQuartile are not computed correctly in computeStats.
For example, the median of the array [1, 2, 3, 4] would be the average (mean) of the numbers 2 and 3, hence 2.5. While the median of the array [1, 2, 3, 4, 5] is 3.
computeStats instead would, in the first case, select 3 as the median. A similar thing goes on with firstQuartile and thirdQuartile.
Unless there is a specific reason for this, I'd correct it as well.

Thanks @mjsarfatti  for pointing it out. Yes, it is a bug.  And in terms of the corner case you mentioned,   I agree that we should handle that case more carefully.

We would want it to end up something like this:

Yes, the result should be like this, and I remembered it should be the case. Will double check. @mjsarfatti if you haven't start working on the fix PR,  I'm happy to fix this issue next week if it is not too late for you.

I haven't really really started on it, so if you are tackling this anyway I'll leave it to you.
I did implement a fix on a locally downloaded version of computeStats that I heavily customized, but in case it can save you some work:
export default function computeStats(numericalArray) {
  const points = [...numericalArray].sort((a, b) => a - b);
  const sampleSize = points.length;

  const getMedian = dataSet => {
    if (dataSet.length % 2 === 1) {
      return dataSet[(dataSet.length - 1) / 2];
    }
    return (dataSet[dataSet.length / 2 - 1] + dataSet[dataSet.length / 2]) / 2;
  };

  const median = getMedian(points);

  const lowerHalfLength = Math.floor(sampleSize / 2);
  const lowerHalf = points.slice(0, lowerHalfLength);
  const firstQuartile = getMedian(lowerHalf);

  const upperHalfLength = Math.ceil(sampleSize / 2);
  const upperHalf = points.slice(upperHalfLength);
  const thirdQuartile = getMedian(upperHalf);

  const IQR = thirdQuartile - firstQuartile;

  [...]


Pass Git SHA/hash as a private cookiecutter variable

cruft already stores the commit SHA/hash whenever in the .cruft.json file.
Whilst not a direct feature enhancement for cruft itself, it might be useful for users to be able to access to the commit hash in their downstream projects.
It should be straightforward to pass this as a private cookiecutter variable, since this is already done for the template variable (stored as the private variable _template).
This would solve a related ask in the cookiecutter project.

I'm already working on this!

Done with PR #292.


Images fixes

Purpose
Miscellaneous fixes for Images

Attempt to fix events polling bug
Add RenderGuard to LinodeSelect and DiskSelect
Refactor helper method in images.ts
Fix typos found while making the above changes

Coverage increased (+0.006%) to 26.717% when pulling cee7c8ea50137ef8f37e548d9a33a6ccb48b3d0c on Jskobos:images-fixes into b863aa2abafa970254818b8b600c78d18f53be4f on linode:develop.

@rjstires removed the init(). It was in there as an attempt to debug the repeated toasts issue, but that can wait until later. I think there's a ticket in the sprint for centralizing toasts; if it's ok I might want to pair program with you or Andrew on that one so I can figure out exactly what's going on in the events system.


Discussion: Removal of MemoryCache's GC compaction trigger

Discussion for https://github.com/aspnet/Announcements/issues/228

Question - why the requirement to downcast, instead of defining the Compact method on IMemoryCache?

We did try this in a previous iteration when removing the compaction trigger. However, this functionality is specific to our implementation in MemoryCache and it's unclear whether we should require every IMemoryCache to support Compact. cc @davidfowl @Tratcher ?

The Compaction needs a better design before it's exposed on the interface.

It's unlikely that Compact will remain once we revisit the design of MemoryCache in #289.

We are closing this issue because no further action is planned for this issue. If you still have any issues or questions, please log a new issue with any additional details that you have.