build: update dependencies

Pull Request Test Coverage Report for Build 310

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 88.116%

Totals

Change from base Build 300:
0.0%

Covered Lines:
261

Relevant Lines:
289

💛  - Coveralls


Fix Pattern Configurator

Description
This PR fixes pattern configurator. The PR, although fixes the configurator but at the moment the UI looks hideous (thanks to my creative self).
Relevant Video
https://user-images.githubusercontent.com/45818886/136474716-916a7346-a015-4797-84a8-fc28d0ade155.mp4
Notes for Reviewers
The isn't as clean as it should be so @Abhishek-kumar09 please sprinkle your magic here.
Signed commits

[x] Yes, I signed my commits.

This is much better than crashing. You're right that 1st) grouping by mesh version is needed and 2nd) when a user is editing a given component, the accordion should open much taller than it does now (it should nearly take up the whole height of the screen).

Codecov Report

Merging #4360 (7dc2aab) into master (86ae506) will decrease coverage by 6.54%.
The diff coverage is 36.36%.

@@            Coverage Diff             @@
##           master    #4360      +/-   ##
==========================================
- Coverage   27.89%   21.34%   -6.55%
==========================================
  Files          59       59
  Lines        5037     5054      +17
==========================================
- Hits         1405     1079     -326
- Misses       3215     3660     +445
+ Partials      417      315     -102

Flag
Coverage Δ

gointegrationtests
?

unittests
21.34% <36.36%> (+1.19%)
:arrow_up:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files
Coverage Δ

mesheryctl/pkg/utils/platform.go
13.92% <0.00%> (+10.07%)
:arrow_up:

internal/store/store.go
67.50% <37.50%> (-8.98%)
:arrow_down:

internal/store/thread_safe_store.go
100.00% <100.00%> (ø)

mesheryctl/internal/cli/root/system/status.go
0.00% <0.00%> (-62.83%)
:arrow_down:

mesheryctl/internal/cli/root/system/start.go
0.99% <0.00%> (-53.98%)
:arrow_down:

mesheryctl/internal/cli/root/system/restart.go
2.50% <0.00%> (-47.50%)
:arrow_down:

mesheryctl/internal/cli/root/system/stop.go
0.85% <0.00%> (-36.76%)
:arrow_down:

mesheryctl/internal/cli/root/system/update.go
1.05% <0.00%> (-34.74%)
:arrow_down:

mesheryctl/internal/cli/root/system/check.go
1.39% <0.00%> (-22.38%)
:arrow_down:

mesheryctl/internal/cli/root/system/logs.go
3.29% <0.00%> (-18.30%)
:arrow_down:

... and 2 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b22a005...7dc2aab. Read the comment docs.

Couldn't see the video, showing corrupted. Meanwhile magician is asking their disciple to review :smile:


Installation and get started  is very confusing for Window ?

Please improve your installation process, it's very confusing for biggners. You should provide a content available to everyone and all the levels.
How to install and use this project in a simple steps in Windows?
It says on my computer, it's successfully install by pip install atm , however, I can't run your example of getting started as it's very confusing and no clear starting point there.
I'm using featuretools and it's very easy to install and understand the get started procedure?
Please help with that!

I'm closing this issue as it is not actionable for us, however be assured that if we are able to reproduce the problems you report in #159 then we will investigate and fix.


Bug when using Bootstrap 4 sass - scss file integration with the switch

Hello,
I've tried using the bootstrap switch scss file "src/sass/bootstrap4/bootstrap-switch.scss"
The 2 lines of @import at the beginning of the file can't be fetched.
It works when I comment them, the switch appears correctly.
I don't see where those imports are necessary and being used. Could we release them commented?
Line  14 and 15
@import "../bootstrap-4.2.1/functions";
@import "../bootstrap-4.2.1/variables";
Maybe I didn't import correctly bootstrap, do I need a specific config?
Thanks a lot
Nicolas

or change the path to
@import "../../../../bootstrap/scss/functions";
@import "../../../../bootstrap/scss/variables";
it's the only way on my config in node_modules to fetch the correct files :)

still broke

same here ...

@nicolasmartin86
i got the same error when using vite to compile my assets, see #737  for a patch proposal


builder-base: add al2022 build

Issue #, if available:
Description of changes:
This introduces an al2022 based builder-base image.  It also changes the base image from al2/2022 directly to the minimal kind image, which has most of the same stuff this image needs.
Much like the eks-distro-base build, this adds an AL_TAG which is meant to be used to determine the underlying base image.  The al2 build continues to be tagged latest, as well as latest.2, and the 2022 build will be tagged with latest.2022.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

/override prow-deck-tooling-presubmit


Create value to become first item- showNewOptionAtTop prop

Hi,
Great work on this.
I would like to make it so "Create" is not the first/auto highlighted option when a user starts typing.
According the the main (non-plus of react-select) it was put in this commit (here). How can I integrate this feature myself?
I created a screenshot to help explain.

That commit is part of a PR that hasn't been merged yet: https://github.com/JedWatson/react-select/pull/1436 If it's merged, it'll become part of react-select-plus, so keep an eye on that ticket.


The extension totally not working with projects created with "dotnet new angular"

Angular code debugging should be straight forward according to the documentation for "Debugger for Chrome" VSCode extension.
However I cannot make it work.
I created a simple default app using dotnet new angular -o Homepage, which is an Web API + Angular ASP.NET Core project.
I installed the extension and configured launch.json to trigger the debug:
"configurations": [
{
   "name": "Launch Chrome",
   "request": "launch",
   "type": "chrome",
   "url": "http://localhost:5001",
   "webRoot": "${workspaceFolder}"
},
{
    "name": "Attach to Chrome",
    "port": 9222,
    "request": "attach",
    "type": "chrome",
    "webRoot": "${workspaceFolder}"
}

When executed with dotnet run command, browser opens and runs the application on port 5001.
Then in VSCode I selected Debug, then selected "Launch Chrome" option and clicked the debug button (the green arrow button), a new browser window opened, but breakpoints that I set in the angular app which is ClientApp don't get hit in VSCode.
Also I tried to use the "attach" option for debugging, previously I added "chrome.exe --remote-debugging-port=9222" for Chrome shortcut. Ran the app as before, then selected "Attach to Chrome" option for debugging and clicked the debug button. This also didn't work, no breakpoints get hit.
What am I doing wrong or what's the trick here, why isn't it working?
It is exactly as the documentation for "Debugger for Chrome" extension instructs to do.
Thanks.

/jsDebugLogs

Bot seems to be having issues --
Please collect trace logs using the following instructions:

If you're able to, add "trace": true to your launch.json and reproduce the issue. The location of the log file on your disk will be written to the Debug Console. Share that with us.
⚠ This log file will not contain source code, but will contain file paths. You can drop it into https://microsoft.github.io/vscode-pwa-analyzer/index.html to see what it contains. If you'd rather not share the log publicly, you can email it to<EMAIL_ADDRESS>

Hi connor4321.
I addded "trace": true to your launch.json
Here is the output in Debug console.
I dont know if there is a debug file.
What I get in Debug console is this:

Your launch.json should now have an object like
{
   "name": "Launch Chrome",
   "request": "launch",
   "type": "chrome",
   "url": "http://localhost:5001",
   "webRoot": "${workspaceFolder}",
   "trace": true, // <- added this
},

With this, there will be a log file path printed at the top of your Debug Console (you may need to scroll up from what I see in your screenshot)

Yes, my launch.json is exactly like this.
Ok, the file is like this c:\Users\Username\AppData\Roaming\Code\logs\20201104T114453\exthost1\ms-vscode.js-debug\vscode-debugadapter-0.json.gz
But I cannot upload it here, I get a message "Somthing went really wrong, and we cannot process that file".
I could upload it to " https://microsoft.github.io/vscode-pwa-analyzer/index.html", it whows bunch of info.
I dont know how to read it, I can email it to you.
Is that ok?
It doesnt upload here.

Thanks for the logs. It looks like you want to set "webRoot": "${workspaceFolder}/ClientApp",
(next month the debugger is shipping with a tool to self-serve fixes for these kinds of issues :) )

Thank you, you are right. That was that issue. Sometimes it is difficult to find out to where this should point.
Thank you, works now.

Good to hear, let us know if you run into any more issues

Perfect resolution, thank you, Connor!


[DNM]Nutrition compartments cleanup

This PR addresses the following issues in the nutrition-compartments branch:

[x] Fix some tslint failures.

[x] Add a new map function for the nutrition module.

[x] show 'vietnam' in stead of no header breadcrumb when the user is at country level.

[x]  Fixe a typo in the side menu by replacying Logface with Log face.

[x] Replace the header prop in the LogFace and Analysis components with module

[ ] Increase test coverage

[ ] Improve styling on the HirerarchichalDataTable component, specifically how it is displayed on the nutrition module.

@KipSigei, comments made on https://github.com/OpenSRP/opensrp-web/pull/118 should really be addressed there instead of here, since these 2 PRs address different concerns they should not be mixed up. This prevents the danger of PRs getting overly large; when this happens they become difficult to review and some people in the team shy away from giving their opinions on them.


[IP] Refactor backend from alks-node to ALKS.js

This PR refactors the backend to no longer use alks-node library which was specifically used for ALKS CLI. There's been a few changes, but overall the behavior of ALKS CLI is unchanged. So no one should notice anything other than better errors especially when using the -v flag. I've made sure every call to ALKS has errors logging so there's no surprises anymore.

bin/ all CLI calls updated.
lib/ all internal library calls updated.
getConsoleURL moved from alks-node to a proper utils file. This works just like before, but it was one of those things in alks-node that alks.js doesn't support.

Good luck reviewer! 👍

Closing this and working on getting errors fixed instead of switching to ALKS.js backend for the following reasons:

Logic is all handled by alks-node, otherwise we're going to make alks-cli extremely clunky and redundant.
Some special use-case functions exist in alks-node that alks-cli doesn't have.
Refresh/Access token exchange handled more gracefully in alks-node.
For some odd reason certain calls return 0 errors from ALKS.js, but return in alks-node (could be my fault though).
Level of effort is greater than an IP sprint worthy story. I'd rather this be a full refactor than just switching backends so this can get proper attention. Otherwise we're left with some very redundant code and I know my PR will need far more revisions than necessary.


Pull to refresh view doesn't always hide cleanly

I'm running into an issue where the pull to refresh view doesn't always hide cleanly after calling stopAnimating. I haven't been able to nail down exactly what conditions it occurs under, aside that it appears somewhat "random" in my use.
I did however nail it down to this commit that is causing the issue: b88f78db6073aa3bba06ddbd50148e8270f4824e (from #99)
If I revert this commit then the pull to refresh view always hides cleanly, but I'm not sure how best to solve it so that @pilot34's use case also works.
Any ideas?

same here.

I was also affected by this issue when using with a very fast internet connection, leading to a very short time period between calls to startAnimating() and stopAnimating().
Since the podspec hasn't been updated in 3 years, the fix referenced that has been committed to master hasn't made it through to the default pod yet.
You can workaround this for now by replacing
pod 'SVPullToRefresh'

with
pod 'SVPullToRefresh', :git => 'https://github.com/samvermette/SVPullToRefresh.git', :branch => 'master'

Thanks @mattmcneeney!  Spent 2 hours debugging this before I saw your comment.


Line breaks in markdown

Context
Currently linebreaks are only happening if you have a double linebreak in the markdown (which is annoying for controlling formatting)
Expected Behavior
I would expect a single line break to be acknowledged and visible in the preview and published posts as a single line break (without a large gap).

Fixed with #194


Update Pull Request Template

I feel like the PR template is outdated and that we should update it with a common structure to standardize pull requests.
Depending on the nature of the PR, for example fixes, the structure could be different or not require most of the sections.
I propose the following structure:

Description: summary of the PR
Look & Feel: example picture for UI, example Input/Output example for CLI, example Request / Response for API endpoint.
How to test: steps to test it or name of the tests
Further Improvements: potential improvements to be done in the same PR or follow up Issues/Discussions/PRs

Feel free to add your thoughts on this :smiley:

This sounds good. Just want to note we should also keep the present content in the template. So expand rather than replace.

Maybe encouraging the use of flexmeasures-client :)


Lines appear black (Forward+) or not at all (Mobile) in screen_texture (such as BaseMaterial3D refraction)

Related to https://github.com/godotengine/godot/issues/82637.

Tested versions

Reproducible in: 4.0.stable, 4.2.stable

System information
Godot v4.2.stable - Fedora Linux 39 (KDE Plasma) - X11 - Vulkan (Mobile) - dedicated NVIDIA GeForce RTX 4090 (nvidia; 545.29.06) - 13th Gen Intel(R) Core(TM) i9-13900K (32 Threads)
Issue description

Lines normally
Lines behind refractive material

This mainly affects the editor as lines seen through a refractive material will appear black. It can also affect projects that use line drawing (e.g. when using Visible Collision Shapes or Visible Navigation).
A more minimal example where the issue may be more obvious:

The refractive material is the box in the middle.
In 3.x, lines don't appear at all behind refractive materials, regardless of whether GLES3 or GLES2 is used.
This appears to be related to the depth prepass: disabling it in the Project Settings while using Forward+ hides the black lines behind refractive materials.
Steps to reproduce

Create a mesh with a BaseMaterial3D attached.
Decrease albedo color's alpha to 0, decrease roughness to 0.0 and enable refraction on the BaseMaterial3D. Set refraction scale to 0.0.
Move the camera around so the origin and grid lines appear behind the refractive material.

Minimal reproduction project (MRP)
test_refraction.zip

I think this is caused by the lines using depth_draw_alpha_prepass. I'm not sure why they do though. At any rate, this will be fixed by https://github.com/godotengine/godot/pull/83895


Fix total_pod_count check

Description
The check
if [[ ${total_pod_count} -le 0 ]]; then

Must be run after calculating total_pod_count
Fixes

/rerun all

Results for e2e-benchmarking CI Tests

Workload
Test
Result
Runtime

router-perf-v2
./ingress-performance.sh
PASS
00:06:30

etcd-perf
./run_etcd_tests_fromgit.sh
PASS
00:00:56

scale-perf
./run_scale_fromgit.sh
PASS
00:12:37

network-perf
GEN_CSV=false ./run.sh
PASS
00:04:43

kube-burner
WORKLOAD=cluster-density ./run.sh
FAIL
00:00:06

kube-burner
WORKLOAD=node-density ./run.sh
FAIL
00:00:06

kube-burner
WORKLOAD=node-density-heavy ./run.sh
FAIL
00:00:06

kube-burner
WORKLOAD=pod-density-heavy ./run.sh
FAIL
00:00:06

kube-burner
WORKLOAD=max-services ./run.sh
FAIL
00:00:05

kube-burner
WORKLOAD=max-namespaces ./run.sh
FAIL
00:00:04

upgrade-perf
./run_upgrade_fromgit.sh
PASS
00:01:08

Mistakenly dupe of #543


Add service version and remove public ctors for output only types

Fixes https://github.com/Azure/azure-sdk-for-net/issues/14501 and https://github.com/Azure/azure-sdk-for-net/issues/14492
Misc doc cleanup

/azp run net - servicebus - tests

/azp run net - servicebus - tests


Rear-facing Camera compatibility

Good app so far, however, I'm missing the rear-facing camera for the case of Mobile Devices.
It only has the front-camera mode.
Kindly check it out

This library delegates the operation of the webcam to react-webcam by the prop videoConstraints.
https://github.com/ysuzuki19/react-qrcode-reader/blob/d7903dc0d986d1e304aa5874a0a26846290a48ed/package/lib/index.tsx#L59
Therefore, the approach to rear-facing should be achievable using a method equivalent to that in react-webcam.
Please search the method.
If you want to add pass other props, just let me know :)

Kindly add pass other props so that it's achievable

Could you tell me the prop name of react-webcam for your achieve the purpose

Instead of using facingMode:"user"
I wish to use facingMode: { exact: "environment" }
like below
class WebcamCapture extends React.Component {
render() {
const videoConstraints = {
facingMode: { exact: "environment" }
};
return <Webcam videoConstraints={videoConstraints} />;

}
}

Can resolve the purpose with below code?
<QrCodeReader
  delay={100}
  width={500}
  height={500}
  onRead={handleRead}
  videoConstraints={{
    facingMode: { exact: "environment" }
  }}
/>

Thanks very much, it's working perfectly.
A lot of libraries have failed, but this has succeded to me.


Unable to copy paste text along with image in Pnp Richtextbox

Thank you for reporting an issue, suggesting an enhancement, or asking a question. We appreciate your feedback - to help the team understand your
needs please complete the below template to ensure we have the details to help. Thanks!
Please check out the documentation to see if your question is already addressed there. This will help us ensure our documentation is up to date.
Category
[ ] Enhancement
[ ] Bug
[x] Question
Version
Please specify what version of the library you are using: [pnp v1.20.0 ]
If you are not using the latest release, please update and see if the issue is resolved before submitting an issue.
Expected / Desired Behavior / Question
User should able to copy paste text along with image in Pnp Richtextbox
Observed Behavior
Unable to copy paste text along with image in Pnp Richtextbox.
We have used a Pnp rich textbox control in one of SPFx webpart. We are able to copy and paste text and images separately. But when we copy text along with image, the image not getting pasted in Richtextbox.

Hi @RahiniRadha,
I've tested this with latest version (3.15.0) and it works:

Can you confirm on your side?


Cleanup unused npm modules.

I'm looking into on doing some changes on videogular. After I forked the project and did an npm install the following message appeared on the terminal:
npm WARN package.json<EMAIL_ADDRESS>No repository field.
npm WARN deprecated<EMAIL_ADDRESS>use grunt-ng-annotate instead
npm WARN deprecated<EMAIL_ADDRESS>use ng-annotate instead
npm WARN optional dep failed, continuing<EMAIL_ADDRESS>
Since ngmin is, as far as I could see, unused I decided to look for more unused packages.
On the current project depcheck gives the following output:
Unused devDependencies
* grunt
* grunt-contrib-concat
* grunt-contrib-coffee
* grunt-contrib-compass
* grunt-contrib-jshint
* grunt-contrib-connect
* grunt-contrib-htmlmin
* grunt-contrib-imagemin
* grunt-autoprefixer
* grunt-usemin
* grunt-svgmin
* grunt-rev
* grunt-concurrent
* grunt-google-cdn
* grunt-ngmin
* load-grunt-tasks
* connect-livereload
* time-grunt
* karma-ng-html2js-preprocessor
* karma-ng-scenario
* karma-jasmine
* karma-junit-reporter
* karma-coverage
* karma-phantomjs-launcher
* karma-chrome-launcher
* karma-firefox-launcher
* karma-script-launcher

That's quite a lot of unused packages that do not have to be installed / updated. grunt is a false positive and since I have no experience with testing with karma I am not sure which karma-packages are used and which are not.
In this PR a lot of unused packages are removed (except the karma-packages). The package still grunts fine (only default task tested).

Thank you! This project was built with Yeoman and there's a lot of stuff that I'm not using now.
I will add you to the hall of fame :)


Added Astar SS58 address type

Description
Added support for Astar Network
https://astar.network
Testing instructions

Types of changes

Checklist

[ ] Prefix PR title with [WIP] if necessary.
[ ] Add tests to cover changes as needed.
[ ] Update documentation as needed.
[ ] I have read the guidelines for adding a new blockchain
[ ] If there is a related Issue, mention it in the description (e.g. Fixes #<issue_number> ).

Does it really work? please add some real world tx tests

Does it really work? please add some real world tx tests

https://astar.subscan.io/extrinsic/0x7d20bd691f5943a98aa05ebada7b45f156edfef53d5a911194d5cb2a1694d979

@FitzLu Please add that tx to test and reuse Polkadot/Entry

@hewigovens sample tx added into registry, unfortunately Entry returns custom coin type and can't be reused.

Please check Cosmos/Entry.h or Ethereum/Entry.h to see how to reuse entry classed
I meant swift test case like https://github.com/trustwallet/wallet-core/blob/master/swift/Tests/Blockchains/KusamaTests.swift#L35 and cpp test like https://github.com/trustwallet/wallet-core/blob/master/tests/Polkadot/SignerTests.cpp#L30

@akru could you please fix the iOS / Android CI? need to update address test CoinAddressDerivationTests.kt/swift

@hewigovens Sure, let me check it

@hewigovens Im sorry for delay, I’ll resolve it during this week


Add option for a cron based schedule

Run the service updates specified by a cron schedule.
An environment variable SLEEP_SCHEDULE is introduced, which has to be a valid unix cron schedule of five fields. Example 0 8,16 * * * --> every day at 08:00 and 16:00
If SLEEP_SCHEDULE is set, any value in SLEEP_TIME is ignored.
Because I have not found the Korn Shell ksh93 in an alpine repository it is compiled and copied to the final image during the docker multi-stage build.

On my local machine the arm64 build is successful.  Maybe an issue on the CI machine?

Made the script more robust against miscalculations of the next scheduled run.
Use the currently latest version (v1.0.4) of ksh93 instead of the dev branch.
Optimized git clone to only load used tag and no history
Additionally I tried to use Bash to avoid the arm64 CI build fail, but as you can see not successful.


Issue44

Fixed the file name issue of all activity classes

A lot of refactoring has been done now. If you decide to work on it later, feel free to open another PR!


look into house of orange (HITCON 2016)

We didn't have a chance at the CTF, but we should figure out what House of Orange needs, and if we should add a technique to how2heap for it.

Concentrating discussion in #20


Fix Dumpster when facing East

🤔 What type of PR is this? (check all applicable)

[ ] 🍕 Addition
[ ] ⌨ Productivity
[x] 🐛 Bug Fix
[ ] 🔥 Optimization
[ ] ⚙ Configuration
[ ] 🌟 Quality Of Life
[ ] ✨ Enhancement
[ ] 📝 Documentation

📝 Description
The dumpster's hitbox was offset by one when facing east
🧐 The Rationale
Broken hitbox
🎯 Key Objectives
Fix the hitbox
🚦 Testing

Fixed hitbox
⏮ Backwards Compatibility
1.12.2
📚 Related Issues & Documents
#229
🖼 Screenshots/Recordings
See "Testing"
📖 Added to documentation?

[ ] 📜 README.md
[ ] 📓 Javadoc
[ ] 🍕 Comments
[x] 🙅 no documentation needed

I made a mistake, This will conflict with 256

I made a mistake, This will conflict with 256

Give me one sec and I'll make a new PR to fix

See #272


Error on line 60:

INFO:  Fetching secure wget
ERROR: Unexpected error on line bootstrap:96 in function wget-bootstrap
ERROR: This script failed to install. If you can't solve the above
issue yourself, please report it at:
       <https://github.com/toltec-dev/toltec/issues>

   (Please also include these error logs to help solving the
   problem faster. Thank you!)

bootstrap: line 60: clean-path: command not found
Can anyone help me plese?

What is the command you are running?

The second One:
echo "9195122984700c76ccdc58e25d09d0fca486324e8fc55ba781f6e1b812cc186c  bootstrap" | sha256sum -c && bash bootstrap

And what is the first command you ran?

Duplicate of #422.


Invalid options error.

Using the command i3lock-next, regardless of what arguments are given, throws the following messages:
i3lock: invalid option -- 'k'
i3lock: Syntax: i3lock [-v] [-n] [-b] [-d] [-c color] [-u] [-p win|default] [-i image.png] [-t] [-e] [-I timeout] [-f]
This occurs regardless of what arguments are passed or if the command is passed without any arguments.
Example:
eel52@xxxxxx:~$ i3lock-next
i3lock: invalid option -- 'k'
i3lock: Syntax: i3lock [-v] [-n] [-b] [-d] [-c color] [-u] [-p win|default] [-i image.png] [-t] [-e] [-I timeout] [-f]
As seen in the example the option 'k' is not passed at all.

Is this using i3lock-next from the master branch? What version of i3lock-color do you have installed?

I have i3lock-color installed from source from this github: https://github.com/PandorasFox/i3lock-color
I got the i3lock-next code from here: https://github.com/owenthewizard/i3lock-next

As stated this issue is not occurring on a legacy version of the software in question, or any of its dependencies. I would like the tag to be removed, or I am going to have to close the issue.

@Eel52 The legacy tag does not mean a legacy version of the master branch, the current master branch is due to be replaced by the rewrite branch. There is no ETA for this. To clarify: "legacy" refers to the master branch of i3lock-next.
Please post the output of i3lock --version.

@owenthewizard Sorry for misunderstanding. Here's the output of i3lock --version:
$ i3lock --version
i3lock: version 2.10 (2017-11-25) © 2010 Michael Stapelberg

i3lock-color refactored various options a while ago, try with the latest version. You may need to compile from source if your distro does not provide a recent version.
Detection of older/newer versions of i3lock-color may be added in the future.

I have just built a new version of i3lock-color from PandorasFox Github. I am not familiar with how to install it to /usr/bin/ (although I think I have gotten it to work) however the command "i3lock-next" still yields the original problem.

sudo make install


Invalid regular expression in isValidAttributeString

The method isValidAttributeString in search-request.js returns false when called with a valid one letter attribute such as 'o'.

Duplicate of https://github.com/ldapjs/messages/issues/2


Certificate meta-information file

There will be a point where it is necessary to store informations about a certificate that do not belong to the configuration. For example, this may be necessary to implement STAR certificates (RFC 8739). I have not read the full specification, but from the few I read it seems necessary to keep track of some state on the client side, at least in order to know if it's a "traditional" certificate or a STAR.
Where to store this file?
There is multiple possibilities, the one I find the more promising being:

one file per certificate stored along with the private key and the certificate
one file per certificate stored in a dedicated directory
one unique file stored I don't know where which contains the entries for all the certificates

I would prefer the one file per certificate approche since it would be coherent with what has already be done for the accounts and is easier for people to manage.
Using this approche, the file_name_format will be used with:

file_type set to something like meta
ext set to bin (if bincode is chosen)

Which file format?
The file format itself should be the same one as the account's. Currently that is the binary format provided by the bincode crate, however it might evolve if necessary.
Because the file's content may evolve in the future, this should be taken into consideration from the beginning. I don't remember how bincode allows this, but I think the following method should work: try to load the latest structure, if it fails try the previous ones until it matches and upgrade to the latest.
When?
I would like to limit new features before the async rewrite, however it doesn't prevent discussing this future improvement.

I think it makes sense to consider prior art here, to see how other ACME clients tackle this, if at all. I'll start by listing the ones I know of the top of my head:

acmetool is the only one that has it documented in every single detail, see https://github.com/hlandau/acmetool/blob/master/_doc/SCHEMA.md
lego uses a json file that's sitting in the same directory as the certificate and private key

Regarding the format: bincode itself doesn't handle schema differences at all, and from what I can tell, it might accidentally parse data even if the structs did change, so automatically falling back if it doesn't parse is dangerous.
It would be possible to split this into a wrapper instead, that contains a version number and a byte vec. After parsing the version number, the byte vec could be parsed again, this time through the correct struct. A fancy version of this, which would allow us to skip all the replication of the fields for the different versions is provided by https://lib.rs/crates/obake.

Possibly related way of breaking things:

create a cert with LE staging
change endpoint from LE staging to LE production
restart

no new certificate is craeted because a cert with this file name already exists, even if technically invalid at this point

Over time, I completely changed my mind on how to handle this. Currently, I'm planning to have a RDBMS which holds at least informations related to the accounts and certificates. Using sqlite3 would allow to fix the current issue using the single file model. It would also support changes to the schema and possibility to detect a change in the configuration, which solves the issues already mentioned (by the way, thank you both for your inputs).

Using a rdbms sounds like a good path forward.
Would you consider also supporting postgresql in addition to (or instead of) sqlite? My experience with sqlite is not great, and while postgres surely also has some complexity, I feel it's easier to run something in a production ready way on top of postgres compared to sqlite.

Would you consider also supporting postgresql in addition to (or instead of) sqlite?

Yes. Since I plan to use SQLx that would be quite easy.

My experience with sqlite is not great

I'm surprised, I always had very good experiences and feedbacks from sqlite.

I feel it's easier to run something in a production ready way on top of postgres compared to sqlite.

Quite the opposite. The sqlite storage file would be created on the fly if it doesn't already exists and therefore there is nothing to do, whereas PostgreSQL requires you to deploy and configure the server before starting ACMEd.

I'm surprised, I always had very good experiences and feedbacks from sqlite.

There's two major data consistency footguns:

Types aren't enforced by default, which they think is good: https://www.sqlite.org/flextypegood.html
Foreign keys aren't enforced by default, for backwards compat: https://www.sqlite.org/foreignkeys.html#fk_enable

The rest is probably personal gripes with how the sqlite project is run.

Quite the opposite

Yes, getting started with sqlite is easier, but that's why I specifically said "production ready".
Both for inspecting an sqlite database and for taking atomic snapshots for backup purposes, you need to stop the service accessing the sqlite database. With postgres, you can do both of these while the service is online. Both are important for production setups IMO, because insight into what is happening and backups for durability are important.
You can build the inspection features into the service, and you can build the snapshot features into the service as well, but both of those are harder than just using a RDBMS that already has those capabilities.


Added support for new ISAPI urls

get_device_status
get_device_time
get_get_upnp_ports_status

I have tested these changes with two Hikvision DVRs I have with, cameras of Hikvision, CP Plus, Dahua.,

I'm on board with the new endpoints, but things need streamlined a bit.  The current intent of the library is that initialize is always called first which should define some of the items you are repeating in each function (digest check in particular).  I also don't see the need to add the beautiful soup dependency when everything can be done with the existing XML tree functions.

@mezz64 Okay we can streamline the library. I used beautiful soup because of its flexibility and ease of use.


New version: TechSmith.Snagit.2024 version 24.1.0

[ ] Have you signed the Contributor License Agreement?
[ ] Have you checked that there aren't other open pull requests for the same manifest update/change?
[ ] This PR only modifies one (1) manifest
[ ] Have you validated your manifest locally with winget validate --manifest <path>?
[ ] Have you tested your manifest locally with winget install --manifest <path>?
[ ] Does your manifest conform to the 1.6 schema?

Note: <path> is the name of the directory containing the manifest you're submitting.

Microsoft Reviewers: Open in CodeFlow

Hi @PckgrBot,

This PR's version number 24.1.0 has 3 parameters (sets of numbers between dots - major, minor, etc), which is less than the current manifest's version <IP_ADDRESS>8, which has 4 parameters.

Does this PR's version number exactly match the version reported in the Apps & features Settings page? (Feel free to attach a screenshot.)
(Automated response - build 867)


Error when creating an issue with a too long description

Issue
I tried to create an issue with a 3 lines description, and it failed:

Test data
I tested with the following description:

Most of the time, the users have different roles (user, admin...). To have a good start, it's better to set them up, and to ensure they are retrieved and usable in the frontend.
To do so, just implement a simple change in the navbar for instance, depending on the role

This was a production only issue, this is now fixed. The schema on the main branch was out of sync with the code and was not using text but varchar(192).


Authentication and dynamic imports

Hello
Chrome has already rolled out dynamic ES6 imports. I have been wanting to try it out with a system where part of the UI data is fetched from a remote server / other localhosted server. Problem is that this data is, naturally, hidden behind an authentication layer and, as far as I understand, there is currently no way to send credentials with the dynamic import.
I readily admit myself to be woefully ignorant of the deeper implications of credentials inclusion in dynamic imports, but it does nevertheless seem to me like this feature will be of utmost importance to many use cases. Is there any road map with regards to authentication with dynamic imports?

You can use them within a <script> whose crossorigin="" attribute is set appropriately to give credentials. This applies to all imports, not just dynamic ones.

Ah, thank you for enlightening me!


Great work，will you release some high resolution config exps?

Thanks for your concern. We will release high resolution config exps after the paper is published.


Microphone mode support in iOS

I wonder, Is there any functions to make user able to change microphone modes in iOS?

It's sorry that there's no API to change the Mic Mode from agora_rtc_engine.


Fall-back to libmagick or libgraphicsmagick for GIFs

Is it possible to add support for GIFs (including animated GIFs) with a simple fall-back to libmagick or libgraphicsmagick? As mentioned in here jcupitt/ruby-vips#38 libvips does not support GIFs directly.

Link is broken now. Do you still have an example for that?

@muratcorlu This is an old issue. GIF input is now supported (via giflib) since v0.15.0. Please open a new issue if you're still having problems.


Cannot Define Secret Environment Variables

The helm chart allows environment to be configured, but env: does not  complete env: section.
https://kubernetes.io/docs/concepts/configuration/secret/#using-secrets-as-environment-variables
env: section should work the same as you define envFrom:  The range logic assumes the end user only ever wants to use value: but Kubernetes allows more things than value:  Please update the helm chart to replace the range with  with.Values.env with an nindent. Then the user can define the environment according to what Kubernetes allows.
            {{- range $key, $value := .Values.env }}
            - name: {{ $key }}
              value: {{ $value | quote }}
            {{- end }}
          {{- with .Values.envFrom }}
          envFrom:
            {{- toYaml . | nindent 12 }}
          {{- end }}

This came up in a different case here: https://github.com/sagikazarmark/helm-charts/pull/92
Unfortunately, env is already used. Would the above solution work for you?

@sagikazarmark Would you allow me to do a PR for this? Solution yon pointed out here sagikazarmark/helm-charts#92 would work for me.

@jeanlouhallee yes, feel free to submit a PR. FYI we have a new contributing guide that should help you make all the necessary changes. Thanks!


[cgo client] Shared subscribe type error

Describe the bug
go test:
func TestConsumerShared(t *testing.T) {
	client, err := NewClient(ClientOptions{
		URL: "pulsar://localhost:6650",
	})
	assert.Nil(t, err)
	defer client.Close()

	topic := "persistent://public/default/multi-topic-1"

	consumer1, err := client.Subscribe(ConsumerOptions{
		Topic:            topic,
		SubscriptionName: "key-sub3",
		Type:             Shared,
	})
	assert.Nil(t, err)
	defer consumer1.Close()

	consumer2, err := client.Subscribe(ConsumerOptions{
		Topic:            topic,
		SubscriptionName: "key-sub3",
		Type:             Shared,
	})
	assert.Nil(t, err)
	defer consumer2.Close()

	// create producer
	producer, err := client.CreateProducerWithSchema(ProducerOptions{
		Topic:    topic,
		Batching: false,
	}, NewBytesSchema(nil))
	assert.Nil(t, err)
	defer producer.Close()

	ctx := context.Background()
	for i := 0; i < 20; i++ {
		producer.SendAsync(ctx, ProducerMessage{
			Key:   fmt.Sprintf("key-%d", i%3),
			Value: []byte(fmt.Sprintf("value-%d", i)),
		}, func(producerMessage ProducerMessage, e error) {
			fmt.Printf("send complete. err = %v \n", e)
		})
	}

	for i := 0; i < 10; i++ {
		msg, err := consumer1.Receive(ctx)
		fmt.Printf("consumer1 key is: %s, value is: %s\n", msg.Key(), string(msg.Payload()))
		assert.Nil(t, err)
		err = consumer1.Ack(msg)
		assert.Nil(t, err)
	}

	for i := 0; i < 10; i++ {
		msg2, err := consumer2.Receive(ctx)
		assert.Nil(t, err)
		fmt.Printf("consumer2 key is:%s, value is: %s\n", msg2.Key(), string(msg2.Payload()))
		err = consumer2.Ack(msg2)
		assert.Nil(t, err)
	}
}

cpp test:
TEST(ConsumerConfigurationTest, testSubscribePersistentMultiConsumerKeyShared) {
    std::string lookupUrl = "pulsar://localhost:6650";
    std::string topicName = "persist-key-shared-topic-1";
    std::string subName = "test-persist-key-shared";

    ClientConfiguration clientConfig;
    Client client(lookupUrl, clientConfig);

    Result result;

    LOG_INFO("create 1 producer...");
    Producer producer;
    ProducerConfiguration conf;
    result = client.createProducer(topicName, conf, producer);
    ASSERT_EQ(ResultOk, result);

    std::string content1 = "msg-1-content-1";
    Message msg = MessageBuilder().setContent(content1).build();
    result = producer.send(msg);
    ASSERT_EQ(ResultOk, result);

    std::string content2 = "msg-2-content-2";
    msg = MessageBuilder().setContent(content2).build();
    result = producer.send(msg);
    ASSERT_EQ(ResultOk, result);

    ConsumerConfiguration config;
    config.setReadCompacted(false);
    config.setConsumerType(ConsumerShared);
    config.setSubscriptionInitialPosition(InitialPosition::InitialPositionEarliest);

    Consumer consumer;
    result = client.subscribe(topicName, subName, config, consumer);
    ASSERT_EQ(ResultOk, result);
    Consumer consumer1;
    result = client.subscribe(topicName, subName, config, consumer1);
    ASSERT_EQ(ResultOk, result);

    Message receivedMsg;

    result = consumer.receive(receivedMsg, 2000);
    ASSERT_EQ(ResultOk, result);
    ASSERT_EQ(content1, receivedMsg.getDataAsString());

    result = consumer1.receive(receivedMsg, 2000);
    ASSERT_EQ(ResultOk, result);
    ASSERT_EQ(content2, receivedMsg.getDataAsString());

    consumer.close();
    consumer1.close();
}

result output timeout, as follows:
2019-06-03 09:54:21.142 INFO  ConsumerImpl:170 | [persistent://public/default/persist-key-shared-topic-1, test-persist-key-shared, 1] Created consumer on broker [<IP_ADDRESS>:50264 -> <IP_ADDRESS>:6650]
/pulsar/pulsar-client-cpp/tests/ConsumerConfigurationTest.cc:138: Failure
Value of: result
  Actual: TimeOut
Expected: ResultOk
Which is: Ok
2019-06-03 09:54:23.171 WARN  ConsumerImpl:98 | [persistent://public/default/persist-key-shared-topic-1, test-persist-key-shared, 1] Destroyed consumer which was not properly closed
2019-06-03 09:54:23.171 INFO  ConsumerImpl:839 | [persistent://public/default/persist-key-shared-topic-1, test-persist-key-shared, 1] Closing consumer for topic persistent://public/default/persist-key-shared-topic-1
2019-06-03 09:54:23.172 WARN  ConsumerImpl:98 | [persistent://public/default/persist-key-shared-topic-1, test-persist-key-shared, 0] Destroyed consumer which was not properly closed
2019-06-03 09:54:23.172 INFO  ConsumerImpl:839 | [persistent://public/default/persist-key-shared-topic-1, test-persist-key-shared, 0] Closing consumer for topic persistent://public/default/persist-key-shared-topic-1
[  FAILED  ] ConsumerConfigurationTest.testSubscribePersistentMultiConsumerKeyShared (3899 ms)
[----------] 1 test from ConsumerConfigurationTest (3899 ms total)

[----------] Global test environment tear-down
[==========] 1 test from 1 test case ran. (3900 ms total)
[  PASSED  ] 0 tests.
[  FAILED  ] 1 test, listed below:
[  FAILED  ] ConsumerConfigurationTest.testSubscribePersistentMultiConsumerKeyShared

 1 FAILED TEST
[1/1] ConsumerConfigurationTest.testSubscribePersistentMultiConsumerKeyShared returned/aborted with exit code 1 (3946 ms)
FAILED TESTS (1/1):
    3946 ms: ./main ConsumerConfigurationTest.testSubscribePersistentMultiConsumerKeyShared

To Reproduce
copy the code above, and run it.
Expected behavior
In go test code, consumer1 and consumer2 each receive 10 messages. In fact, only consumer1 receives 10 messages, and then remains blocked, and consumer2 does not receive any messages.
In cpp test code, consumer and consumer1 each receive 1 messages. In fact, only consumer receives 1 message, and then consumer1 receives timeout.
In my test scenario, cpp and go behave in the same way, so I guess this may be a bug in cpp. For the same topic, start multiple consumers to share with the shared subscription type, only one consumer can receive To data.
$ ./bin/pulsar-admin topics stats [topic-name]

Using the stats command, you can see that all messages are sent to the same consumer under the shared subscription type.
Desktop (please complete the following information):

OS: Mac ios
go version: 1.11.4
pulsar version: latest

Additional context
Add any other context about the problem here.

@sijie @merlimat @jiazhai I am not an expert in cpp, I am not sure how to use gdb or dlv in cpp to locate this problem very well, but as far as the results of the current test are concerned, cpp-client  and cgo-client have some problems in the shared subscription mode.


Initial density profile

Using a density profile based off what we did with the cabbeling experiments in some earlier work produced a bulge at the interface. Need to check the density profile of initial conditions. This could even have something to do with cabbeling and/or what reference pressure is used.

This initial condition needs to be set as a stable density profile to show anything about cabbeling. So we only need a stable initial condition, then what we change is the salinity perturbation. If the initial density profile is unstable, even to cabbeling, we are just simulating diffusive convection not cabbeling.

Add random noise to velocity field as the initial condition at the salinity perturbation. Need to check the add_velocity_random_noise! function because I am not sure if it is working properly.

Now have the ability to set stable density profiles with salinity perturbations in the upper layer and random noise in the salinity field as of DirectNumericalCabbelingShenangians.jl v0.3.4. This has triggered convection in some initial experiments I have run so I will close this.


Add/Save Pagination locally

closes #308
Saves the paging_token of a transaction as a "cursor". The cursor is a url_tag to page through a list of transactions in horizon.
Things left to do:

[ ] the limit is 200, but I mistakenly set it to 500.
[ ] retrieving all transactions, and not just 200.

[ ] when is this called? when executing open requests?
[ ] incorporate the "_links" field of HorizonResponse. right now it only contains the "_embedded" portion.

How to begin the review:

Look inside cache.rs:

 /// Contains the path where the transaction envelope and the cursor/paging token will be saved.
#[derive(Debug, Clone)]
pub struct WalletStateStorage {
  path: String,
  inner_path: String,
}

Previously TxEnvelopeStorage,  which now has additional methods to save/retrieve the last cursor.
the additional methods are  get_last_cursor and save_cursor.
renamed methods dedicated for TxEnvelope: save_tx_envelope, remove_all_tx_envelopes, etc.
added 1 test case: fn test_cursors()

Look inside stellar_wallet.rs:

inside fn submit_transaction(...): before returning a value, the paging_token of the transaction is saved by calling the save_cursor(...) method:// use the paging token to save the latest cursor
if let Err(e) = self.cache.save_cursor(resp.paging_token) {
    // don't throw an error for failure to save the cursor.
    tracing::warn!(
        "failed to save paging token {} as the latest cursor: {e:?}",
        resp.paging_token
    );
}

make the get_last_cursor and save_cursor accessible through the wallet

 pub async fn get_latest_transactions(
       &self,
       - cursor: PagingToken,
       - limit: i64,
       order_ascending: bool,
   ) -> Result<Vec<TransactionResponse>, Error> {

The cursor and the limit is removed. The cursor value will be derived from accessing wallet's get_last_cursor method, and the limit stays 200 (and this is a constant value)

@b-yap does my comment answer your question on how to fetch all transactions or should I be more specific? If something is unclear don't hesitate to ask

@ebma
I actually have started last night. I cannot return a vec of transactions because the size is too big. The best would be something like an  iterator.
pub struct TransactionsResponse<'a> {
  pub(crate) records:Vec<TransactionResponse>,
  pub(crate) order_ascending: bool,
  pub(crate) wallet: &'a StellarWallet
}

impl <'a> TransactionsResponse<'a> {
  pub async fn next(&mut self) -> Option<TransactionResponse> {
    match self.records.pop() {
	Some(x) => {
          if let Err(e) = self.wallet.save_cursor(x.paging_token) {
	          tracing::warn!("failed to save paging token {} as cursor: {e:?}", x.paging_token);
          }
          println!("------------- XXXXXXXXXXXXXX -------- THERE IS STILL DATA, SO RETURN X. NEW CURSOR:{}", x.paging_token);
          Some(x)
	}
	None => {
          println!("------------- XXXXXXXXXXXXXX -------- NO MORE DATA, SO LET'S GET SOME!");
          if let Ok(result) = self.wallet.get_latest_transactions(self.order_ascending).await {
	          self.records = result;
	          return self.records.pop();
          }
          None
	}
    }
  }
}

This is the initial structure, returned by a different method get_latest_transactions_iter(...) called inside async fn execute_open_requests:
let wallet = wallet.read().await;
let transactions_result: Result<TransactionsResponse,Error> = wallet.get_latest_transactions_iter(false).await;
//drop(wallet);

// Check if some of the requests that are open already have a corresponding payment on Stellar
// and are just waiting to be executed on the parachain
match transactions_result {
  Ok(mut transactions) => {
    while let Some(transaction) =  transactions.next().await {
        if rate_limiter.check().is_ok() {
	        // give the outer `select` a chance to check the shutdown signal
	        tokio::task::yield_now().await;
        }
...

PRINT THE URL: https://horizon-testnet.stellar.org/accounts/GA6ZDMRVBTHIISPVD7ZRCVX6TWDXBOH2TE5FAADJXZ52YL4GCFI4HOHU/transactions?limit=200&cursor=1984081617240064&order=desc
Apr 12 19:59:07.467  INFO substrate: 💤 Idle (0 peers), best: #11 (0x7f3c…551e), finalized #11 (0x7f3c…551e), ⬇ 0 ⬆ 0
thread 'test_execute_open_requests_succeeds' panicked at 'could not find event: Redeem::ExecuteRedeem', /spacewalk/clients/runtime/src/integration/mod.rs:165:25
note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace
Apr 12 19:59:08.091  WARN parity-db: Shutdown error: Io(Os { code: 2, kind: NotFound, message: "No such file or directory" })
test test_execute_open_requests_succeeds ... FAILED

failures:

failures:
    test_execute_open_requests_succeeds

test result: FAILED. 0 passed; 1 failed; 0 ignored; 0 measured; 11 filtered out; finished in 91.28s

Seems like a never-ending loop, because i don't think I should rely on the transaction's paging token; but instead the href links. Hence my todo to update the HorizonTransactionsResponse.
I'll let you know if I got something that's somehow working.

About saving the pagination, you're right, it's best on a separate ticket (at least the methods are already there for use). I'll rename this draft once it's actually ready for review.

@ebma yep, you have a point about the cursor. I adjusted the function listen_for_new_transactions(), removing the last_cursor param.
I only removed the extra fields from the fetcher, and left the wallet as is. We can decide on what to do in the next issue tackling the saving/adding pagination.


Something doesn't work properly with advance node (smooth curves in simple)

Could you add smooth regulation for the simple node (this is the only thing I lack for now). The settings of the advanced node are somehow strange, I can not achieve the same result with them as with the simple one.

here's what I don't like in advanced node. At 1 there is no smooth transition from one entity to another (there is a jump when the weight changes by 1)

Advanced and Simple node are identical. The settings for Simple are:

center crop (square)
weight 1.0
and then depending on your strength:
strongest: downsampling 1, area
stronger: downsampling 2, bicubic
medium: downsampling 3, area
lower: downsampling 4, bicubic
lowest: downsampling 5, bicubic

There is no smooth slider because the downsampling itself is very non-smooth.
You can use the weight option additionally to downsampling to decrease the strength of the Redux. It's an orthogonal approach and in contrast to downsampling it is relatively smooth.
You can also try "nearest exact" instead of "area" for downsampling mode. It sometimes works better.

I understand that you have other tasks. I would just like a slider in a simple node (or new node with a slider). So that I could do fine tuning...


Tap problem

I changed the click settings in the .env file to [10.50] but still it clicks more than 1000 clicks how is that
I want to control the number of clicks. Is there any other place other than the env file that can control the clicks?

The new balance message from the log doesn't separate passive income from earned taps, it just shows the difference between the old balance and the new one. If you add the number of taps to the log, you'll see that the number of taps is OK.


[QUESTION] How to handle missing fields in model the same as the absence of the whole model

I want to handle missing fields in requests uniformly. If i don't specify some fields from model in request I get the list of errors with unfilled fields. However, when I don't send any fields at all I get different type of error which is that I didn't specify the model itself.
I've tried to override default exception handlers, but as far as I can see there is no way to override this behaviour. Is it possible to do? If not, can you elaborate on the alternative ways of doing this?
Sample code
from fastapi import FastAPI
from pydantic import BaseModel, ValidationError
from starlette.requests import Request
from starlette.testclient import TestClient

async def validation_exception_handler(request: Request, exc: ValidationError):
    print(exc.errors())

app = FastAPI()
app.add_exception_handler(ValidationError, validation_exception_handler)

class Item(BaseModel):
    uid: int
    name: str

@app.post("/pydantic/exception/model/")
async def pydantic_exception_model(item: Item):
    return {"item": item.dict()}

def test_exception_handler_pydantic_validationerror_model():
    with TestClient(app) as client:
        client.post("/pydantic/exception/model/")

        # If no fields are in the request, exception handler would print:
        #
        # [{'loc': ('body', 'item'), 'msg': 'field required', 'type': 'value_error.missing'}]
        #
        # Not able to get the fields and their required errors info from the `exc`

        client.post("/pydantic/exception/model/", json={"id": "str", "name": []})
        # But with some fields are missing and some are of the wrong type,
        # exception handler would print:
        #
        # [
        #  {'loc': ('body', 'item', 'uid'), 'msg': 'field required', 'type': 'value_error.missing'},
        #  {'loc': ('body', 'item', 'name'), 'msg': 'str type expected', 'type': 'type_error.str'}
        # ]
        #
        # I can get the fields and errors info from the `exc`

Thanks for the help here @Slyfoxy ! :clap: :bow:
@levchik does that solve your problem? May we close this issue?

@tiangolo yeah, sure, this issue is so old and not relevant now


Add the missing badges in the project README

There are well-known badges for the projects such as maintainability, and test passing percentage. It will enhance the project's credibility

Closing this as this is already addressed through this ticket.


I am also using Ethernet IP for Windows 10 on WSL now. Virtual Ethernet itself is not installed at all, and is being used normally, such as the Internet.

I am currently using Windows 10's Ethernet fixed IP in WSL.
Virtual Ethernet itself is not installed at all and is in normal use, such as the Internet.
Wsl shares Windows' Ethernet IP.
I don't know why it's like this.

What is the output of:
$ cat /proc/version
$ cmd.exe /c ver

Please collect WSL logs and post the backlink to the feedback item here. Also please identify any third-party networking software that has been installed on Windows.

What is the output of:
$ cat /proc/version
$ cmd.exe /c ver

Please collect WSL logs and post the backlink to the feedback item here. Also please identify any third-party networking software that has been installed on Windows.

wsl's ip and Windows' ip are shared, and vEthernet is not installed.   There is no vEthernet adapter.

Linux version 4.4.0-19041-Microsoft<EMAIL_ADDRESS>(gcc version 5.4.0 (GCC) )

You are on WSL 1. There is no vEthernet adapter.

Thank you so much for your reply.
But I was using wsl2.
and I installed everything again and it's working fine.
============================

wsl -l -v
NAME      STATE           VERSION

Ubuntu    Running         2
============================

Thank you so much for your reply.
But I was using wsl2.
and I installed everything again and it's working fine.
============================

wsl -l -v
NAME      STATE           VERSION

Ubuntu    Running         2
============================


Error install plugin : LibreNMS\ComposerHelper::preUpdate

Hello,
When I try to install the plugin with the command: ./lnms plugin:add dmbokhan/vlans-compare
I get the error message :

LibreNMS\ComposerHelper::preUpdate
Loading composer repositories with package information
Updating dependencies
Your requirements could not be resolved to an installable set of packages.
Problem 1
-Root composer.json requires dmbokhan/vlans-compare * -> satisfiable by dmbokhan/vlans-compare[1.0.0, 1.0.1, 1.0.2, 1.0.3].
-dmbokhan/vlans-compare[1.0.0, ..., 1.0.3] require librenms/librenms ^23.9.1 -> satisfiable by librenms/librenms[23.9.1, 23.10.0, 23.11.0] from composer repo (https://repo.packagist.org) but librenms/librenms is the root package and cannot be modified. See https://getcomposer.org/dep-on-root for details and assistance.
Running update with --no-dev does not mean require-dev is ignored, it just means the packages will not be installed. If dev requirements are blocking the update you have to resolve those problems.
You can also try re-running composer require with an explicit version constraint, e.g. "composer require dmbokhan/vlans-compare:*" to figure out if any version is installable, or "composer require dmbokhan/vlans-compare:^2.1" if you know which you need.
Installation failed, reverting ./composer.json and ./composer.lock to their original _content.

I can't find a solution, I think I'm missing a package dependency?
Thanks for your help

Hi!
There was librenms/librenms requirement in composer.json, so it couldn't be installed on LibreNMS with daily updates. I didn't see that error because I tested the plugin only on latest stable release (monthly updates). Try to install the plugin again please.

Hello,
Thank you, the installation was successful with your help :)
I have access to "Overview - Plugins - Vlans Compare" but when I select 2 devices + click on Compare, I have nothing displayed on the right in Result ? Could you help me ?
Thanks again
Sincerely

The reason of the plugin is to show the difference between created vlans on devices or allowed vlans between ports, so if there no difference between devices vlans lists you should see rows with hostname of chosen devices on green background in Result. Just make sure that LibreNMS collects vlans data and show it on the device's vlan page.
Can you share a screenshot how does it look after you click on Compare button please?

I do have Vlan and Port Librenms data on the 2 switches. Here's a screenshot of my display. I've added a screenshot Overview->Plungins->Plugin admin-> Vlans-compare (Settings)

Settings page is correct, cuz there is no settings in the plugin.
But something wrong with Result. Can you please open developer tools in your browser and check POST request-response when you click on Compare button and share it with me.


Update to version 1.7.2

Checklist

[x] Used a personal fork of the feedstock to propose changes
[ ] Bumped the build number (if the version is unchanged)
[x] Reset the build number to 0 (if the version changed)
[x] Re-rendered with the latest conda-smithy (Use the phrase @conda-forge-admin, please rerender in a comment in this PR for automated rerendering)
[x] Ensured the license file is being packaged.

Fixes #22

@conda-forge-admin, please rerender


missing some important things

the sdk is missing some important things mainly for ragebots: get abs velocity, bone cache, invalidate bone cache, bone array for write

easy to add it yourself. closed


Collabode launcher

Launch server against an existing Eclipse workspace, with reasonable defaults and security sandboxing.
(Imported from Bitbucket #48 reported by maxg on 2011-06-02)

Will be handled by a separate plugin. Initial support in 70e59d699cb37db587796ee9400ba95d78c4f5d1.
(maxg on 2011-09-19)


If we do not use neural network, how many logloss can we achieve?

and how many dim of features for the machine learning model without neural network?
Thank you.
@YuriyGuts

You can see the number of features in each feature list in the output of the final model notebook. So that would be around 190.


issue-2230941451 by manu1dcb on 8 April 2024 resolved

issue-2230941451 (TypeError: DRLEnsembleAgent.run_ensemble_strategy() missing 1 required positional argument: 'timesteps_dict') in file examples/FinRL_Ensemble_StockTrading_ICAIF_2020.ipynb  created by manu1dcb resolved

thanks for your work.


"Service not found" after upgrade

Hi there,
I get a "Service not found" error in some cases (and deployment was performed successfully)
I think it's related to this PR https://github.com/sudo-bmitch/docker-stack-wait/pull/18/files

I think it could be a race condition with get_service_ids function

Are you running docker stack deploy in the foreground? The services should exist after that command exits since there's no other place in docker where that's tracked (stacks don't exist in docker, it's just a label on a service).
If you can provide a reproducible example, that would help to debug.

Are you running docker stack deploy in the foreground? The services should exist after that command exits since there's no other place in docker where that's tracked (stacks don't exist in docker, it's just a label on a service).
If you can provide a reproducible example, that would help to debug.

Hey, sorry for the delayed response.
I'm running docker stack deploy -c <file> <stack_name> and then the docker wait command. I think it's a race condition because the services eventually appear.


AudioStreamPlaybackPolyphonic: streams with id > 1 cannot be stopped or changed

Tested versions
Reproducible in: 4.2.rc
System information
Godot v4.2.rc (1ba920fad) - Windows 10.0.22621 - Vulkan (Forward+) - dedicated GeForce RTX 2070 SUPER () - Intel(R) Core(TM) i9-9900K CPU @ 3.60GHz (16 Threads)
Issue description
AudioStreamPlaybackPolyphonic can play more than one stream, but all streams after the first one cannot be stopped or modulated. The is_stream_playing method returns false even when streams are audible.
Steps to reproduce

invoke play() on an AudioStreamPlayer node that has an AudioStreamPolyphonic
invoke get_stream_playback() and use play_stream() to play multiple audio streams
invoke is_stream_playing on the IDs returned from play_stream()

Minimal reproduction project (MRP)
polyphonic_test.zip

I did a pull request to fix this bug:
https://github.com/godotengine/godot/pull/92852
Tested with my own game and the polyphonic_test.zip provided


Feature Request: Inject navigation in tree

As i was trying out the library, i noticed that there's no way to have to inject the navigation anywhere within the react tree. I love the fact that each screen is atomic currently, but this would enable integration with flux libraries like (redux) and would allow to have persistent state across views (reinitialize redux every view isn't ideal).
A sub solution for this would be to be able to set an object that gets passed as props to each route, but i'd like much more a declarative api like
<Provider>
  <App>
     {(props) => <NativeNavigator {...props} />}
  </App>
</Provider>

This could possibly also indirectly fix the dependency on React mentioned here https://github.com/airbnb/native-navigation/issues/54#issuecomment-287887198

This could possibly also indirectly fix the dependency on React mentioned here #54 (comment)

I think there is a bit of misunderstanding here: React dependency mentioned in #54 is a native dependency. Current implementation assumes that React is a framework that Swift can import using import React. I think these issues are not related.

Indeed this issues are not related.
@dzannotti have you seen the Integrating with Redux guide?
I have never felt any pain with adding redux or context-based top level elements to my app using native navigation's approach, so i'm not convinced that this being a real issue.
In your example, what component is rendering <Provider> here? Where is that component being mounted and rendered? What is it being rendered into?
Native navigation renders each screen into their own RCTRootView, and this may fundamentally go at odds with what you are proposing.
I hope that makes sense. Let me know if I'm not being clear.


TCL/TK SHA256 mismatch

Hello,
when I try to install TCL/TK package i have this error :
Error: SHA256 mismatch Expected: 95c676130ce2fdb00e8a6f79c4fea9e79d071063783a61db9274647920d97a03 Actual: dfbe4388d161680dded6ea83ec3638afb056c76913e48d4b44165e2f5cc1a298 Archive: /Users/Johan/Library/Caches/Homebrew/tcl-tk--tcllib-1.17.tar.gz To retry an incomplete download, remove the file above.
i'm on OSX 10.12

You have an outdated formula. Please run brew update and try again.


Web Chat App made using React.js

Description
This project enables users to have a realtime chat with each other. Made using React.js.
Checklist

[ ] I've been assigned an issue related to this PR.
[ ^] I've used beautifiers.
[ ^] I've added my Project's name and description to Index.md
[ ^] I've made a README.md file for my Project.
[^ ] The README.md file of my projrct contains Project title, Description, Use of project, Set up, Stack used and Output (Screenshots).

Related Issues or Pull Requests number
(Write your answer here.)

This branch has conflicts that must be resolved
Use the web editor or the  to resolve conflicts.
Conflicting files
Index.md


BesuCommand.isRevertReasonEnabled belongs in EVMConfiguration

While doing some refactoring I had to provide isRevertReasonEnabled from BesuCommand through the BesuController, and it struck me that this is more obviously an EVM configuration option. This should be refactored and folded into EVMConfiguration.

Isn't this a data storage question?  Revert Reason is in the output of the root message frame, wether or not it is recorded.  No code in the EVM module uses it, the flag is part of TransactionReceiptFactory, switching between these two functions - https://github.com/hyperledger/besu/blob/8eee5698878af80a543362d136a01c51099d48d6/ethereum/core/src/main/java/org/hyperledger/besu/ethereum/mainnet/MainnetProtocolSpecs.java#L940-L958.
When writing it to trie you already have the flag https://github.com/hyperledger/besu/blob/15d54afdf9324ed66d6c6cbad493b18fcb318714/ethereum/core/src/main/java/org/hyperledger/besu/ethereum/core/TransactionReceipt.java#L191, so we could simply drop it from the protocol spec factory instead.

@jflo is this blocking anything else? Should we prioritise on a team's board or happy to leave for anyone to pick up?

Anyone can pick this up, and should consider @shemnon 's suggestions above. I'm not married to any particular approach, as long as this option ends up being grouped in somewhere more specific and relevant.

Hello @jflo  & @shemnon ,
I've reviewed this issue and would like to confirm my understanding of the steps required to address it:

Move isRevertReasonEnabled to EVMConfiguration:

Add a new field isRevertReasonEnabled in the EVMConfiguration class
Implement getter and setter methods for this field

Update BesuCommand and BesuController:

Remove direct handling of isRevertReasonEnabled in BesuCommand
Modify BesuController to initialize and manage this flag using EVMConfiguration

Modify TransactionReceiptFactory:

Update methods to use EVMConfiguration for checking the isRevertReasonEnabled flag
Combine the two factory methods into one, where the revert reason is included or excluded based on EVMConfiguration

Update MainnetProtocolSpecs:

Change logic to pass EVMConfiguration to the TransactionReceiptFactory when creating transaction receipts

If these steps accurately reflect the requirements, I would like to request assignment to this issue. Thank you for your consideration.

@bomanaps Do not, under any condition, add it to EVMConfiguration.  Do some more studying of where and how the flag is used.  EVMConfiguration should only be for options used by the :evm module, and it isn't used there.  In fact, you will discover that the flag is only ever used in the ProtocolSpec
Adding it to DataStorageConfiguration would be a better place.  Then MainnetProtocolSpecs and ClassicProtocolSpecs can replace the two fields enableRevertReason and isParallelTxProcessingEnabled parameters being passed around with the single DataStorageConfiguration Object.
We could move chainId into EVMConfiguration, that refactoring would make sense.  Probably in a different PR as we would also want to update ChainIdOperation as well as any other place ChainId and EVMConfiguration are passed along together.  But that seems like a separate PR

Sorry for the misunderstanding. I will move isRevertReasonEnabled to DataStorageConfiguration, include this flag (along with isParallelTxProcessingEnabled), and remove it from BesuCommand and BesuController. I'll also update MainnetProtocolSpecs and ClassicProtocolSpecs accordingly.


wslpath fails when pointed to the current directory with the -u option.

Version
Microsoft Windows [Version 10.0.19045.2486]
WSL Version

[ ] WSL 2
[X] WSL 1

Kernel Version
Linux version 4.4.0-19041-Microsoft<EMAIL_ADDRESS>(gcc version 5.4.0 (GCC) ) #2311-Microsoft Tue Nov 08 17:09:00 PST 2022
Distro Version
Ubuntu 18.04
Other Software
No response
Repro Steps
After a clean install of Ubuntu 18.04 run: wslpath -u .
Same thing for "wslpath -u ../this_dir", where this_dir is the directory you're currently in.
Expected Behavior
The result should be: "." on stdout.
Actual Behavior
The result is: "wslpath: .", output to stderr
Diagnostic Logs
andrewp@vanadium:~/foo$ mkdir foo bar
andrewp@vanadium:~/foo$ cd foo
andrewp@vanadium:~/foo$ wslpath -u .
wslpath: .
andrewp@vanadium:~/foo$ wslpath -u ..
/home/andrewp/
andrewp@vanadium:~/foo$ wslpath -u ../foo
wslpath: ../foo
andrewp@vanadium:~/foo$ wslpath -u ../bar
/home/andrewp/bar
For reference on another PC:
Microsoft Windows [Version 10.0.19044.2486] // note: this is slightly different
Linux version 4.4.0-19041-Microsoft<EMAIL_ADDRESS>(gcc version 5.4.0 (GCC) ) #2311-Microsoft Tue Nov 08 17:09:00 PST 2022
This works fine:
andrewp@DESKTOP-8GH03GT:~$ mkdir foo bar
andrewp@DESKTOP-8GH03GT:~$ cd foo
andrewp@DESKTOP-8GH03GT:~/foo$ wslpath -u .
.
andrewp@DESKTOP-8GH03GT:~/foo$ wslpath -u ..
/home/andrewp/
andrewp@DESKTOP-8GH03GT:~/foo$ wslpath -u ../foo
.
andrewp@DESKTOP-8GH03GT:~/foo$ wslpath -u ../bar
/home/andrewp/bar
Another difference is that "wsl -v" is a (powershell) command that works on the PC with the broken behaviour, but is not recognised on the PC with wslpath working correctly. This suggests that this issue is due to a newer version of WSL. I tried installing v0.70.4 but the issue remains. I'm not sure how to find out what version of wsl I have installed on my other PC since the wsl -v option is not available. Windows "Apps & Features" lists "Windows Subsystem For Linux Update" as v5.10.16 if that helps.
This bug is a bit annoying because the Intel Quartus tools require WSL 1, and make heavy use of wslpath.

I believe this issue is resolved with newer versions of WSL? (The store version)

I can reproduce the issue on latest Store WSL. I'll work on a fix.

🆔‼✅👍⚠

Fixed with https://github.com/microsoft/WSL/releases/tag/1.1.3.

confirmed as fixed. Thanks a lot for the quick turnaround.


Quality Gate Checklist EDC 24.05

name: Quality Gate Checklist EDC
about: 'product check for a upcoming Release'
title: 'QG X checks (Release 24.05)'
labels: documentation
assignees: ''

QG checks
Please keep this issue open until QG is concluded and will be managed by the Issue Creator!
We will inform you about finding and proposals in separated issues, this issue here is for the Overview of the Checks!
Please keep this issue open until QG is concluded!
Product Owner:
Dev SPOC:
Helm Chart Version:
App Version:
Release Managemnet Reference Issue:
Check of Tractus-X Release Guidelines

Currently implemented automatic checks can be found under your product on our Release Guidelines Checks Board
This QG Check is depending on the mandatory information from our current Release Guidelines

TRG 1 Documentation

[x] TRG 1.01 appropriate README.md
[x] TRG 1.02 appropriate install instructions either INSTALL.md or in README.md
[x] TRG 1.03 appropriate CHANGELOG.md
[x] TRG 1.04 editable static files

TRG 2 Git

[x] TRG 2.01 default branch is named main
[x] TRG 2.03 repository structure
[x] TRG 2.04 leading product repository
[x] TRG 2.05 .tractusx metafile in a proper format

TRG 3 Kubernetes

[x] TRG 3.02 persistent volume and persistent volume claim is used when needed

TRG 4 Container

[x] TRG 4.01 semantic versioning and tagging
[x] TRG 4.02 base image is agreed
[x] TRG 4.03 image has USER command and Non Root Container
[x] TRG 4.05 released image must be placed in DockerHub, remove GHCR references
[x] TRG 4.06 separate notice file for DockerHub has all necessary information

TRG 5 Helm

[x] TRG 5.01 Helm chart requirements
[x] TRG 5.02 Helm chart location in /charts directory and correct structure
[x] TRG 5.03 proper version strategy
[x] TRG 5.04 CPU / MEM resource requests and limits and are properly set
[x] TRG 5.06 Application must be configurable through the Helm chart
[x] TRG 5.07 Dependencies are present and properly configured in the Chart.yaml
[x] TRG 5.08 Product has a single deployable helm chart that contains all components
[x] TRG 5.09 Helm Test running properly
[ ] TRG 5.10 Products need to support 3 versions at a time
[x] TRG 5.11 Upgradeability

TRG 6 Released Helm Chart

[x] TRG 6.01 Released Helm Chart

TRG 7 Open Source Governance

[x] TRG 7.01 Legal Documentation
[x] TRG 7.02 License and copyright header
[x] TRG 7.03 IP checks for project content
[x] TRG 7.04 IP checks for 3rd party content
[ ] TRG 7.05 Legal information for distributions
[x] TRG 7.06 Legal information for end user content
[x] TRG 7.07 Legal notice for documentation
[x] TRG 7.08 Legal notice for KIT documentation

TRG 8 Security

[x] TRG 8.01 Mitigate high and above findings in CodeQL
[x] TRG 8.02 Mitigate high and above findings in KICS
[x] TRG 8.03 Mitigate high and above findings in GitGuardian
[x] TRG 8.04 Mitigate high and above findings in Trivy

Hints
Information Sharing

For TRG 7.05 there's an open PR: https://github.com/eclipse-tractusx/tractusx-edc/pull/1314


Support for parsing relocation from objdump

Basic support for parsing relocation informations as displayed by objdump. It simply keeps lines that starts by an address, followed by R (instead of opcodes).
Things like:
  fc:       e8 00 00 00 00  call   101 <gcc_qsort(...*))+0xd7>
       fd: R_X86_64_PLT32      xmalloc-0x4

The only transformations done are to replace tabs between the reloc name (R_XXX) and the data (anything after the tabs) and to prefix the R_XXX by 4 spaces (matches the behavior of asm-parser.ts).
refs https://github.com/compiler-explorer/compiler-explorer/issues/3222
Signed-off-by: Marc Poulhiès<EMAIL_ADDRESS>

Erm, not sure why it can't find my new test. Of course worksformelocally®

Have you tested parser.outputJson()? That's the one used by CE

Have you also tested parser.outputJson()? That's the one used by CE

No, will do that tomorrow then :)

Awesome! We're close then. Thanks both!

This is using the asm-parser, so should be in good shape. Will see for adding json test

I see only 1 test doing Json test. Were you asking for an extra test using outputJson or simply if it was working when doing my own local tests? I can add a new test, but as I've not changed the data struct, not sure it's really useful. Your call @partouf :)

I see only 1 test doing Json test. Were you asking for an extra test using outputJson or simply if it was working when doing my own local tests? I can add a new test, but as I've not changed the data struct, not sure it's really useful. Your call @partouf :)

doesn't have to be unittested, if you say the JSON is correct, I trust you

On January 11, 2023 10:55:56 AM UTC, Patrick Quist @.***> wrote:

I see only 1 test doing Json test. Were you asking for an extra test using outputJson or simply if it was working when doing my own local tests? I can add a new test, but as I've not changed the data struct, not sure it's really useful. Your call @partouf :)

doesn't have to be unittested, if you say the JSON is correct, I trust you

Haven't looked at JSON specifically, simply plugged it in CE. But will read json around reloc lines to be sure :)

Sample screenshot using C (with asm-parser), Ada (TS parser) and Rust (TS parser).


Rename Money.zero to ambiguous_currencyless_zero

This is to make very clear that this is a sharp tool, since the warnings mentioned in the documentation have happened. The naming is borrowed from core's multi-currency code. Ideally people would not use this at all and explicitly build Money objects with a currency.

Not sure about this one. Can you explain in your view how this is a sharp tool?
There are two different concepts at play here: absence of money vs amount of money. In that sense the naming .zero doesn't seem ambiguous and already indicates that there's no currency.
When used in computation with another currency, Money.zero gives way to the currency of the money it is computed with. Since this is consistent with the concept of absence of money, no error or warnings are displayed.
Money.new(1, 'USD') + Money.zero #=> Money.new(1, 'USD')
Money.new(1, 'USD') > Money.zero #=> true

Moreover Money.zero is not something that can't be received as an external input. It needs to be explicitly coded by the developer. In other words Money.new(amount) where amount is provided by an external input always has a chance of being 0 or nil or ''. That is a representation of some amount and therefore needs to have a currency. Money.zero on the other hand,  is explicitly used when the developer always know this value must be zero.

Can you explain in your view how this is a sharp tool?

I had hoped the accompanying YARD documentation would've explained that 😃 those are real mistakes I've seen happening in production because folks default to Money.zero when they didn't need to on code close to an API edge. Since calculation did not happen 'XXX' ends up being the currency code which then fails validation. Taking a bit more effort to have typed something like Money.new(0, currency) would have prevented such cases.

There are two different concepts at play here: absence of money vs amount of money.

Not sure I follow this one, can you elaborate? In my view they are both "money", one with clear semantics around handling mixed currencies and one with a special case where it "turns into" the other currency. The amount doesn't matter.
If the end result of my code ends up being zero in different currencies and I try to sum those (i.e. Money.new(0, 'USD') + Money.new(0, 'CAD')) I want it to blow up because I missed some currency conversion step, even if the net result would still be zero. Because the next time, it'll be with positive amounts and then I absolutely want to know.

In that sense the naming .zero doesn't seem ambiguous and already indicates that there's no currency.

Is that as clear for developers who haven't spent a non-trivial amount of time working on this gem as we did? 😉 My perception is more that they are not familiar with the difference and see it just as a quicker way of writing Money.new(0). The fact we still don't have mandatory currency argument plays into this as well.

Money.zero on the other hand, is explicitly used when the developer always know this value must be zero.

I don't understand this one. If it must be zero, that can also be achieved with Money.new(0, currency) with the added benefit of currency explicitness? There is no benefit for Money.zero that I can see.
I believe the affordance for errors is too high with our currently loose handling of currency. Money.zero to me is a too easy shortcut and I want to reduce that by giving it a name that properly conveys the tradeoff the developer is making. I really can't imagine situations where I prefer Money.zero over Money.new(0, currency) if currency is known at the time. For the rare cases you don't this sharp tool is still available, but it should never be the default one to reach for.

When used in computation with another currency, Money.zero gives way to the currency of the money it is computed with.

I think a name like Money.ambiguous_currencyless_zero makes that behaviour very clear? I believe the other huge benefit to this change is the ability to make Money.zero require a currency. This allows for intent to be expressed much more explicitly for readers of old code?

I don't understand this one. If it must be zero, that can also be achieved with Money.new(0, currency) with the added benefit of currency explicitness?

Here's an example: say you're accepting an amount/currency from an external source. You don't know what this currency will be but you'd like to verify that the amount is more than zero. Ideally you could do
money = Money.new(params[:amount], params[:currency])
money > Money.zero

Of course there are a number of ways to get around this, but all of them are somewhat hacks
money > Money.new(0, params[:currency])
money > 0
money.value > 0

I've seen happening in production because folks default to Money.zero

🤔 Did they have a legitimate default currency they could use? I guess it does make it tempting to use Money.zero instead of a nil value.
How about Money.currencyless_zero  with aliases until we're sure it's no longer used in core? (hehe, compromise :D )

How about Money.currencyless_zero with aliases until we're sure the old syntax is no longer used in core? (hehe, compromise :D )

What's challenge do you see with ambiguous being in the method name (i.e. what makes .currencyless_zero preferable to .amibiguous_currencyless_zero)?
Aliases I've got no opinions on, do whatever makes sense ❤

Of course there are a number of ways to get around this, but all of them are somewhat hacks
money > Money.new(0, params[:currency])
money > 0
money.value > 0

Interesting! I never considered these hacks. Looking at the code, Money#coerce allows any Numeric to be used, and we also explicitly delegate positive?/negative?/zero?/non_zero? to the underlying BigDecimal. That seems quite explicit to me?
Comparing Money with Money is also the slowest of the options:
require 'benchmark/ips'
require_relative 'lib/money'

MONEY = Money.new("7", "CAD")

Benchmark.ips do |x|
  x.report("> 0") { MONEY > 0 }
  x.report("positive?") { MONEY.positive? }
  x.report("Money.zero") { MONEY > Money.zero }

  x.compare!
end

Warming up --------------------------------------
                 > 0    87.926k i/100ms
           positive?   121.843k i/100ms
          Money.zero    52.714k i/100ms
Calculating -------------------------------------
                 > 0      1.094M (± 2.8%) i/s -      5.539M in   5.067224s
           positive?      1.592M (± 5.3%) i/s -      8.042M in   5.067871s
          Money.zero    606.064k (± 3.7%) i/s -      3.057M in   5.052252s

Comparison:
           positive?:  1591778.7 i/s
                 > 0:  1094097.4 i/s - 1.45x  slower
          Money.zero:   606064.5 i/s - 2.63x  slower

Kinda moot though, a single invocation is fast enough, this only becomes and issue in a loop.

How about Money.currencyless_zero with aliases until we're sure the old syntax is no longer used in core? (hehe, compromise :D )

currencyless_zero works for me too with the YARD doc. People read docs right? 😅 It's one of the changes I'd like to introduce, along with enforcing the Rubocop rule for example.
I'm willing to bet we can refactor this in core with Rubocop. If not, I'd prefer the aliases in core and not in the gem. IMO we've had bad defaults in the gem for too long, they carry over into greenfield apps only because we kept accommodating the slower pace of change in the monolith. It creates more work to clean up those new apps after the fact.

@elfassy I'd still really like to understand better what challenges you see with ambiguous being in the method name (i.e. what makes .currencyless_zero preferable to .amibiguous_currencyless_zero)?
We adopted that name in MoneyBag as it conveys what's "risky" about having a currencyless_zero (namely, that you're introducing a level of ambiguity)

@elsom25 IMO there's nothing ambiguous, it's currencyless and it's value is zero. If something is ambiguous then we should remove it. If we do we'd need an explicit Money.new(0, Money::NULL_CURRENCY) representation.

EDIT: to be explicit, I'd rather remove Money.zero in favor of Money.new(0, Money::NULL_CURRENCY).

I have mixed feelings. I think there are genuine use-cases for currencyless_Zero, but they're fairly infrequent.
I'd be okay with it going away altogether and only existing in our monolith

EDIT: to be explicit, I'd rather remove Money.zero in favor of Money.new(0, Money::NULL_CURRENCY). Like Bart was saying above there's not much use for this since we can always do the positive?/negative?/zero?/non_zero? methods. It also makes it trivial that the currency is wrong in some cases.

🔥 I like that. We'll never really get rid of NullCurrency (think old serialized data) but that's super explicit and autocorrectable with the MissingCurrency cop by changing the default ReplacementCurrency setting to Money::NULL_CURRENCY.


metrics: Define how to deal with errors from deeply nested libs

We have some handlers that use libraries but are expected to provide detailed error information in the result label. This can be very hard to achieve and is probably brittle when the code changes.
For example #3106 requires a result label for path requests. But the path request handler uses segfetcher, which uses segverifier (which uses truststore), pathdb, etc. to define clearly distinguishable errors we would need to wrap all errors that are emited by the used libraries, and in a huge switch we would need to translate the error into a metric label.
Another issue is that sometimes there is not a strict 1 to 1 mapping, e.g. as a result of a path request there could be 10 segments received, but 5 fail to verify, in which case it isn't clear what the result label should state.
IMO it would make more sense to use a single ok/nok result label and for each lib have different error counters, e.g. verification_failures, db_failures, etc.

We're moving away from detailed error labels in metrics, and more towards having different error counters altogether. Closing this.

We're moving away from detailed error labels in metrics, and more towards having different error counters altogether. Closing this.


rattler-build removes manually added rpaths on macOS

# yaml-language-server: $schema=https://raw.githubusercontent.com/prefix-dev/recipe-format/main/schema.json

context:
  name: mssql-tools
  version: '<IP_ADDRESS>'

package:
  name: ${{ name }}
  version: ${{ version }}

source:
  - if: target_platform == 'osx-64'
    then:
      - url: https://download.microsoft.com/download/0/9/7/0976a30f-1710-4754-9445-bead058dd0c8/mssql-tools18-${{ version }}-amd64.tar.gz
        sha256: 1a2917ae45366e028eb4f5ca7d2a2396cfc06d659ae7b1ddc1d0bbee45a0d5fb
  - if: target_platform == 'osx-arm64'
    then:
      - url: https://download.microsoft.com/download/0/9/7/0976a30f-1710-4754-9445-bead058dd0c8/mssql-tools18-${{ version }}-arm64.tar.gz
        sha256: 964113d5fab28bd13bdc658be9c8a6fcbcde04882a1f09c0e8f135ec70dc8f5c

build:
  number: 0
  script:
    - install_name_tool -add_rpath<EMAIL_ADDRESS>bin/sqlcmd
    - mkdir -p $PREFIX/bin
    - cp bin/sqlcmd $PREFIX/bin

requirements:
  build:
    - ${{ compiler('c') }}
    - ${{ compiler('cxx') }}
  host:
    - unixodbc 2.3.10

tests:
  - script:
    - otool -l `which sqlcmd` | grep -A 3 LC_RPATH | grep @loader_path/../lib

Running this on macOS arm or macOS intel, we will get an error. The rattler-build logs show the following:
2024-02-06T20:29:48.105801Z  WARN rattler_build::macos::link: Rpath not in prefix: @loader_path/../lib/ – removing it
2024-02-06T20:29:48.105826Z  WARN rattler_build::macos::link:

builtin relink failed for /var/folders/rz/q1r4tv0n6ll38q18fbk419mc0000gn/T/mssql-toolssrYsLc/bin/sqlcmd: failed to relink dylib with builtin relink (new path is longer than old path). Please file an issue on Github!

The corresponding conda-build recipe works.

Thanks! I am working on it: #605

Works now, thanks!


ReactRouter.browserHistory  coming undefined

react router giving error of Uncaught TypeError: Cannot read property 'location' of undefined

I am also getting this. How did you resolve it?

BrowserHistory doesn't exist in 4.0. Please read the docs.

where is the docs for 4.0 ?

BrowserHistory now placed in history module here is solution
https://stackoverflow.com/questions/43822589/react-router-v4-browserhistory-is-undefined


Blocking?

Does adding a column to a table block other transactions against it?

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: a7f1c141-dea3-1a2c-ba2f-86163be24aa6
Version Independent ID: 5d4a7221-2821-feb8-c74d-509c0c6e3889
Content: Add Columns to a Table (Database Engine) - SQL Server
Content Source: docs/relational-databases/tables/add-columns-to-a-table-database-engine.md
Product: sql
Technology: table-view-index
GitHub Login: @stevestein
Microsoft Alias: sstein

@propellor - Thanks for the feedback!
Hi Sam, can you be more specific?
I think the answer really depends on a few different things such as the details of the new column (is it nullable, is it a computed column, etc.),  the details of the transaction running against the table (is it adding values that the new column uses in any way), isolation level, etc.
At some point the table needs to update the schema and add the new column to existing rows so there will be locking at some point which will cause any transaction to have to wait.
Are you running into a real-world issue and having transactions fail, or ?
Thanks!

@propellor Given that we have not heard back from you for over 2 months, I am going to close this issue for now. Please feel free to reopen it at any time with the specific information requested and we will try to answer your specific questions.
Thanks,
Carl


There are no C64 platform symbols

Not sure if they don't yet exist, or if I just don't know how to use the tool... but I'm not sure how to get common C64 platform symbols to be recognized in the disassembly.

I definitely see the value to separating symbols into multiple files, since each project will use existing platform definitions to varying degrees...  Some may use only the Kernal, some will interoperate with BASIC, and others will use neither.
I'll see if I can find the time to contribute some symbols files.  I can at least contribute some sparse tables that would be deemed worthwhile...  until such time as someone provides something more complete?

It seems that it would be nearly impossible to correctly deduce non-address symbols...  It's neat that the format allows for these but I'm guessing that it just isn't going to be useful at the platform level, and that the intended use for non-address values was for symbols specified interactively.
Let me know if I'm missing any significant uses at the platform level...

Correct, constants exist for things like LDA #$41 where it's unlikely that just grabbing a constant with the same value will be what you actually want.
If you look at the Apple II stuff you'll notice an automated usage.  The ProDOS 8 script is looking up symbols with the ProDOS8-MLI-Functions tag.  This is defined in the ProDOS 8 sym file.  The tag mechanism allows extension scripts to apply constant symbols from a specific set to things.
Similar things are used for GS/OS inline calls and Apple IIgs toolbox calls (which replace a LDX #$nnnn that comes before the JSL with LDX #symbol).
Even if it doesn't make sense to apply them automatically they could still come in handy, but the person doing the disassembly would have to know that they were there.  The Symbols window can be configured to show only platform constants, so it's not a total guessing game, but it's not especially convenient.
At the end of the day these files are loaded at runtime, so they can be updated and distributed outside the normal release cycle, and anybody who doesn't like them can easily hand-edit their own copy.  So if you don't see an obvious need for something, skip it, and we can always throw it in later.

There's not a lot, but there's no longer none.


Produce new version of homepage with key visualisations and headline stats

This is dependent on confirmation of the key viz and headlines #71

See also #78


Unable to use this plugin from custom extensions (like .vue)

Seems that it is impossible to allow inclusions from specific file extensions (e.g. .vue) with the tsconfig's included parameter due to the following line here as it converts any custom extension glob into a one that will always match directories only, e.g. ./src/**/*.vue will convert to ./src/**/*.vue/**
Version: 3.3.10 (previously tested 3.2.1 where it worked as intended)
The plugin is initialized like this:
tsconfigPaths({
    extensions: ['.ts', '.tsx', '.js', '.jsx', '.json', '.vue'],
})

Thanks for investigating.
Here's my proposed solution:
-  if (!glob.endsWith('*') && !/\.[tj]sx?/.test(glob)) {
+  if (!glob.split('/').pop().includes('*')) {

Basically, if the last path component is not a glob, append /**.
Can you open a PR with that change? ^^


Remove FinalHandler, ErrorMiddlewareInterface, and Dispatch

This pull request is issued against the dev-2.0.0 branch, and builds directly on the changes in #66, with the following additional changes:

Removes the FinalHandler class.
Removes the ErrorMiddlewareInterface.
Removes the Dispatch class; since all middleware is assumed to have the same signature now, and error handling can be done in middleware such as the ErrorHandler, it's redundant.
Updates the MiddlewareInterface to make the third argument required, and rename it to $next.

Updates all implementations to follow suit.

Updates Next:

Removes the $done constructor argument and property.
Removes the $dispatch property.
Inlines the code to dispatch middleware, as only one signature is now supported.
Returns the result of invoking middleware directly; it no longer verifies a response was returned. (This is no longer necessary, as it can be performed by classes such as the ErrorHandler.)
Returns the response provided at invocation directly if no more middleware is queued.

Updates MiddlewarePipe:

Passes the result of invoking the next layer of the queue to the provided $next argument.
If the next layer of the queue does not return a response, the original response is passed to the $next argument.

All tests were audited to check for features no longer supported, and documentation has been updated.

I've merged #66 to develop, and rebased dev-2.0.0 and this branch from there, as it is a continuation of the features started on that PR.
Ready for review! Pinging @zendframework/community-review-team @michaelmoussa and @xtreamwayz !

👍 LGTM now @weierophinney. Sad to see getArity(...) go, though. Such a cool name! :)

Sad to see getArity(...) go

Me too, but as it's not used anymore, no need to keep it!


VS Code Ubuntu 16.04. After connecting ftp files open empty

After updating VS Code An incomprehensible error has occurred. When connecting to the sftp server, VS Code files adequately open, however, when opening files after connecting to the ftp server, the files open empty. Rolled back VS Code to version 1.33.1 works correctly. Someone in the know how to fix this problem on new versions of Ubuntu 16.04

An incomprehensible error has occurred

What error? Do you have a screenshot?

/needsMoreInfo

I connect to the server through PCmanFM / FileZilla on VS Code 1.36.1 https://prnt.sc/ondz7j and on VS Code 1.33.1 https://prnt.sc/ondzv8 with a similar connection to the sftp server, both versions open the file correctly

Climbing over the network, this problem arose not only I also came across a similar problem for a user with the linux mint operating system

@CardinaLiv to clarify: you open an entire folder in VSCode that is backed by FTP? And files open empty? If that is true can you somwhow give me a detailed explanation how to set this up on my Ubuntu to reproduce? Thanks!

Miogu suggest teamviewer to demonstrate the problem

@bpasero and on the settings of Ubuntu 16.04 PCmanFM / FileZilla as a ftp connection manager. VS Code version 1.33.1 as it works. To check on new versions, I just update VS Code through the Ubuntu update manager, if it doesn’t work, I roll back to version 1.33.1

@CardinaLiv

and on the settings of Ubuntu 16.04 PCmanFM / FileZilla

Any further information how that setup works, I would really like to set this up myself to debug this issue.

Duplicate of https://github.com/microsoft/vscode/issues/73884


Apply spotless plugin

Apply the spotless plugin to improve code quality and refactor code according to java code style guideline.
Would you like to work on the issue?

[x] Yes
[ ] No
Other:

Work on it after most of PRs will merge due to conflicts.

In Java, there is no standard formatter unlike ktlint. Google formatter conflicts with IntelliJ's default formatter, which will lead to a lot of conflicts. So, will take up later

I would like to work on this issue.

@iamareebjamal Now we should go for it?

Try it out

@iamareebjamal should I try it out?

Sure


Error - serverClient.UpdateUserRole undefined

Based on the provided methods
	Authenticate(userID string) AuthenticationResponse

	// Chatkit Roles and Permissions methods
	GetRoles() ([]Role, error)
	CreateRole(Role) error
	DeleteRole(roleName string, scopeType string) error

	GetUserRoles(userID string) ([]Role, error)
	SetUserRole(userID string, userRole UserRole) error
	DeleteUserRole(userID string, roomID *string) error

	GetRolePermissions(roleName string, scopeName string) (*RolePermissions, error)
	UpdateRolePermissions(roleName string, scopeName string, params UpdateRolePermissionsParams) error

	// Chatkit User methods
	CreateUser(user User) error
	DeleteUser(userID string) error
	GetUsers() ([]User, error)

I don't think UpdateUserRole is defined as per the example.

Perhaps it should be SetUserRole instead?

That appears to be correct. I can't find an example that uses UpdateUserRole. Please re-open with more details if this is still an issue on the latest version.

Dude that was 2 years ago... 😅

My sincere apologies! We're making a concerted effort to look after our SDKs and our community a bit more. #notabot