SPFx List View Command Set with custom dialog boxes not rendering

What type of issue is this?
Question
What SharePoint development model, framework, SDK or API is this about?
💥 SharePoint Framework
Target SharePoint environment
SharePoint Online
What browser(s) / client(s) have you tested

[ ] 💥 Internet Explorer
[X] 💥 Microsoft Edge
[X] 💥 Google Chrome
[ ] 💥 FireFox
[ ] 💥 Safari
[ ] mobile (iOS/iPadOS)
[ ] mobile (Android)
[ ] not applicable
[ ] other (enter in the "Additional environment details" area below)

Additional environment details

browser version: Edge 126.0.2592.68
SPFx version: 1.19.0
Node.js version: v18.20.3
etc

Issue description
I have the same issue as described at https://github.com/SharePoint/sp-dev-docs/issues/8968, but with the new version.
The command set works, but after adding and using(!) the custom dialog based on BaseDialog the command the button disappears. If I remove the initialization of the custom dialog and replace this part with a Dialog.alert the button is back again.
For testing I followed the guide: https://learn.microsoft.com/en-us/sharepoint/dev/spfx/extensions/guidance/using-custom-dialogs-with-spfx.
The dependencies I modified similar to the advice in the old post (but with the current versions):
"dependencies": {     "@fluentui/react": "^7.204.0",     "@microsoft/decorators": "1.19.0",     "@microsoft/sp-core-library": "1.19.0",     "@microsoft/sp-dialog": "1.19.0",     "@microsoft/sp-listview-extensibility": "1.19.0",     "office-ui-fabric-react": "^7.204.0",     "tslib": "2.3.1",     "react": "17.0.2",     "react-dom": "17.0.2"   },   "devDependencies": {     "@microsoft/eslint-config-spfx": "1.20.1",     "@microsoft/eslint-plugin-spfx": "1.20.1"<EMAIL_ADDRESS>"0.1.0",     "@microsoft/sp-build-web": "1.20.1",     "@microsoft/sp-module-interfaces": "1.20.1",     "@rushstack/eslint-config": "2.5.1",     "@types/webpack-env": "~1.15.2",     "ajv": "^6.12.5",     "eslint": "8.7.0",     "gulp": "4.0.2",     "typescript": "4.7.4",     "@types/react": "17.0.80",     "@types/react-dom": "17.0.25"   }
Any advice would be nice.

I am also having the same issue

same issues

Does anyone have a solution for this problem?

Same issue here - is there any solution?

I found a solution für this problem.

Using react 17.0.2 is not a good idea, because not supported. So I downgraded with:
npm install<EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS>--save-exact

Using office-ui-fabric-react as used in the Microsoft tutorial is deprecated. So I changed my code to use fluentui/react instead.

I found a solution for this problem.

Using react 17.0.2 is not a good idea, because not supported. So I downgraded with:
npm install<EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS>--save-exact
Using office-ui-fabric-react as used in the Microsoft tutorial is deprecated. So I changed my code to use fluentui/react instead.

Now the buttons are visible and my custom dialog opens.

Works :)


Add int16 support for tf.math.minimum and tf.math.maximum

I was working on lossless audio data which is primary int16 PCM data,
when trying to do a simple minimum to my surprise I noticed that in16
is not supported:
>>> x = tf.constant(1, tf.int16)
>>> y = tf.constant(2, tf.int16)
>>> tf.math.minimum(x, y)
Traceback (most recent call last):
  File "<stdin>", line 1, in <module>
  File "/Library/Python/3.7/site-packages/tensorflow/python/ops/gen_math_ops.py", line 5961, in minimum
    _ops.raise_from_not_ok_status(e, name)
  File "/Library/Python/3.7/site-packages/tensorflow/python/framework/ops.py", line 6653, in raise_from_not_ok_status
    six.raise_from(core._status_to_exception(e.code, message), None)
  File "<string>", line 3, in raise_from
tensorflow.python.framework.errors_impl.NotFoundError: Could not find valid device for node.
Node:{{node Minimum}}
All kernels registered for op Minimum :
  device='XLA_CPU_JIT'; T in [DT_FLOAT, DT_DOUBLE, DT_INT32, DT_INT64, DT_BFLOAT16, DT_HALF]
  device='CPU'; T in [DT_FLOAT]
  device='CPU'; T in [DT_HALF]
  device='CPU'; T in [DT_BFLOAT16]
  device='CPU'; T in [DT_DOUBLE]
  device='CPU'; T in [DT_INT32]
  device='CPU'; T in [DT_INT64]
  device='XLA_CPU'; T in [DT_FLOAT, DT_DOUBLE, DT_INT32, DT_INT64, DT_BFLOAT16, DT_HALF]
 [Op:Minimum]

As such I used a workardound which looks quite awkward:
>>> x = tf.constant(1, tf.int16)
>>> y = tf.constant(2, tf.int16)
>>> z = tf.stack([x, y])
>>> tf.math.reduce_min(z)
<tf.Tensor: shape=(), dtype=int16, numpy=1>
>>>

This PR adds int16 support for tf.math.minimum and tf.math.maximum.
Signed-off-by: Yong Tang<EMAIL_ADDRESS>

Thanks @bixia1 for the review. I have updated the PR with documentation in tensorflow/tensorflow/core/ops/ops.pbtxt. Please take a look and let me know if there are any other issues.


Link git outputs between tasks

In this PR I have implemented outputs using PVC within lifetime of pipelinerun. Closed old PR #255 in favor of this. Discussion for design is in previous PR so please refer to that for more details.
Note:

[x]  Replaces current e2e test for multiple tasks pipelinerun test with fan-in and fan-out pipeline. (More complex than existing e2e test and covers all use cases previous e2e test as well)
[x] Added another example under examples to demonstrate git resource dependency
[x] Support for targetPath is in pipeline task resource. e2e test includes this use case as well.

What will not be included?
Support for images
This PR only includes support for git resource dependency. Support for images includes some design of metadata and I would like to follow up with another PR for that.
/assign @ImJasonH
/assign @bobcatfish
/assign @pivotal-nader-ziada

@pivotal-nader-ziada @bobcatfish @vdemeester
I updated the design in recent change. Please take a look at it and leave comments. Thanks to @bobcatfish for slack brainstorming.

Updated e2e test to assert contents
No more use of steps(post, pre). Using taskrun.resource.paths to accomplish passing information to taskrun.
Updated docs.
Updated commit msg to include issue number and more details.

/lgtm
In case you want to make some tweaks to the docs - altho it's unlikely a user would want to use the paths directly, I think it would be nice to try to show how they could do that:
/hold
And also I'm still wondering about fan-out and fan-in, seems like we can end up with tasks running in parallel changing the same data?

In case you want to make some tweaks to the docs - altho it's unlikely a user would want to use the paths directly, I think it would be nice to try to show how they could do that:

I will take another shot at docs tomorrow. 👍

@bobcatfish : I have updated the docs to include examples. Please review that and let me know if you have any feedback.

/lgtm
/meow space

@bobcatfish : I need /approve label too.

whoops, just took it for granted that @shashwathi had approver rights already, she's one of the top contributors!!
/approve

/hold cancel


parse CWT wavelet names for parameters

This PR implements wavelet name parsing for cmor, shan, and fbsp wavelets in the same manner as Matlab.  This was discussed in #308
shan and cmor have two float parameters (center_frequency and bandwidth_frequency) while fbsp also has an fbsp_order parameter.  Currently, these are silently assigned default values upon wavelet creation and the user can modify them via assigning to the wavelet attributes.
This PR supports specifying these attributes within the wavelet name as in the Matlab toolbox.  e.g.
cmorB-C or shanB-C where B is the bandwidth and C is the center frequency.
fbspM-B-C where M is the spline order, B is the bandwidth and C is the center frequency.
I added a deprecation warning if no parameters are specified.

Codecov Report

Merging #310 into master will decrease coverage by 0.07%.
The diff coverage is 91.66%.

@@            Coverage Diff             @@
##           master     #310      +/-   ##
==========================================
- Coverage   86.22%   86.14%   -0.08%
==========================================
  Files          21       21
  Lines        3092     3125      +33
  Branches      535      535
==========================================
+ Hits         2666     2692      +26
- Misses        373      380       +7
  Partials       53       53

Impacted Files
Coverage Δ

pywt/_extensions/_pywt.pyx
70.94% <91.66%> (+0.36%)
:arrow_up:

pywt/_extensions/c/wt.template.c
87.38% <0%> (+0.45%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update dd7b793...adc01d6. Read the comment docs.

This PR now has a merge conflict, can you rebase?

Code changes look fine to me


prepare adhs python packaging

This is a bit more heavyweight that #2, so I just leave this here for discussion.
I really like the idea of adhs. I'd like to be able to install it anywhere with a simple pip install adhs.
This PR sets up python packaging ceremony. Locally, you can already use pip to install it. A still open last step would be to upload it to pypi.
That's how it looks like: https://asciinema.org/a/7rtozqwg1ej1pqxbsl0kez9j6

Very nice, I will definitely have a closer look soon. Thanks for the suggestion!


Coloring, tagging, naming, describing

I'd like to be able to put text on connection lines in between nodes (hosts, containers, or apps, doesn't matter) in Scope.  That way, 9/10ths of the explaining can be done visually.  This said I wouldn't want this to be a fully-auto option because:

The automation might not do it well enough
the automation is missing that "human contextualization"
I often have info the machine doesn't

As for the nodes themselves, I'd like to be able to assign colors myself, and tell Scope the meaning of the color so that it can build a key for quick reference.
Here's another good-to-have:

Hardware spec is an area where the host has just as much info as I do.  Visually exposing that information can help in countless ways.

Thanks for the ideas! The colors themselves are incidental, but the idea of a key is interesting. We've also had some internal discussion about visualizing hardware specs, e.g. resource availability & utilization, we'll definitely put more weight to that now.
Regarding user customization, at the moment, the Scope UI is read-only, for a number of reasons, not least because the product is largely stateless. We also resist customization in the way you describe; we want the UI to be almost functional, taking your containers/application/infrastructure as input, and yielding a useful, deterministic UX as output.
Thanks for the ideas!


Delete column names after spherizing

@FloHu noticed that the original names of the features are carried through after spherizing.
We might want to not do that since it can confuse people actually using the consensus data later on then. I think they should just be named feature_1 .. x

@gwaygenomics ? You ok with this?

the feature names for spherized data still hold meaning though, right?

I dont think so
They are a transformed space where dim 1 is that Principal component with the highest variation.
@shntnu ?

There’s some version of it where you do rotate it back got the original space

ok hm, so we keep the column names then? Or we differentiate depending on if we rotate back ?

Indeed column the feature name should represent the space in which they are in.


Drop Rstudio from DSVM  section

Hi All,
I think the section on the Data Science Virtual Machine is out of date. As far as I can tell RStudio Desktop and RStudio Server are no longer included with this virtual machine. It would be great if this was updated or alternatives to use these tools added.

Document Details
⚠ Do not edit this section. It is required for learn.microsoft.com ➟ GitHub issue linking.

ID: 2808e74b-c325-7b50-093a-b777473864b5
Version Independent ID: e1f632cb-92ef-958e-5bf4-d250108e1c8d
Content: R developer's guide - R programming - Azure Architecture Center
Content Source: docs/data-guide/technology-choices/r-developers-guide.md
Service: architecture-center
Sub-service: cloud-fundamentals
GitHub Login: @AnalyticJeremy
Microsoft Alias: jepeach

@jsearcy1
Thanks for your feedback! We will investigate and update as appropriate.

This article was so significantly out of date, that we are removing it from azure architecture center and have added an item to the backlog for the future to revisit what R content belongs in the architecture center.  The article will be removed by EOB on Monday.
I don't know when the larger refresh is landing but removing the "wrong" content is the highest priority now to remove direct contraction with product truth.
#please-close


slow sends on Windows (USB)

Hello Cristian,
Your serial package is getting better and better all the time - first off, a huge thanks for creating this, covering all the platforms, and doing so in pure Go. As you may remember, I ran into an issue (#9) on macOS a while back, and am happy to report that it has been working charmingly ever since.
On Windows, there's still an issue we can't quite figure out - some details here, but that won't be very helpful yet, I'm afraid.
The behaviour is that communication is really slow - one line of text is sent, and then I need to wait for its echo and prompt coming back. This cycle repeats until an entire file is sent - it works quickly on Linux and Mac, but not on Windows.
Someone mentioned seeing this behaviour elsewhere, and that it might be related to hardware handshaking (this is USB, so all virtual). The USB device on the other end is custom-coded (not C), and completely ignores RTS/CTS etc, so I'm not really sure where to look next.
Anyway, just wanted to flag this here as placeholder, until we can figure out a bit more. The problem has been reported by at least two people, both Win10 AFAIK.
Cheers,
Jean-Claude
PS. Saw your new work on a new USB API - no rush, but I'm looking forward to seeing that in the main branch eventually. It means I could provide device info in the port selection menu I'm currently presenting in Folie. Fantastic work, all of it. Many thanks for taking it further and sharing it all.

To follow up - we're seeing a 1-second slowdown after every line, but it happens only on Windows.
Could it be related to this logic? What is the purpose of the timeout?
Another aspect which might be related is that incoming text lines end in LF, not in CR+LF in our setup.

Hi @jcw
the purpose of that timeout is to make the following check working:
https://github.com/bugst/go-serial/blob/v1/serial_windows.go#L76-L84
basically, it seems that the only realiable way, on Windows, to check for a "disappearing port" (for example when you unplug a USB cable) is to do a setCommState on the port and see if it fails. Any other system call to the already-opened file handle will be successfull without any error, in particular the Read call, without a timeout will block forever.
So the current code do something like this:

Setup the timeout to 1 sec
While reading, if no data is received within 1 second test if the port is still alive and retry the read.

Hope this clarify a bit.
Going back to the original issue: I would expect the Read call to return immediately, with the new incoming data and not timeout after 1 sec. So in some way it seems that the first call to Read "miss" the incoming data that get caught on the second call (after testing if the port is still alive).
Can you write a small example that demonstrates the problem? At this point it's very important to produce a small test case to reproduce the error, this will allow to narrow and identify if the problem is in the library, in the hardware or in the OS.

Hi,
I am looking together with @jcw into the slow-serial on windows we have. What I now see is that a call to Write() is actually only returning after 1 second. My guess is that there is a previous Read() call in progress. As no data flows in, it hits a timeout of one second. Then the Write() can be executed.
It would be nice if Read() and Write() could be concurrent, but it does not seem to be so.
What we are doing is having a main program sending commands and checking replies. We have two goroutines.
One forever Read() the serial port and if data available it is pushed into a channel (read by the main)
Second: forever monitoring a channel, for data to be send and if available Write().
If my theory is right, then I am looking for a non-blocking Read(). Is that available in the package?

So in some way it seems that the first call to Read "miss" the incoming data that get caught on the second call (after testing if the port is still alive).

This could be programmed more tidy I am sure. The chosen approach of reading forever helps flushing unwanted data, that may come for whatever reason. So another option would be to have a Flush() or other means to discard unwanted data.
So what happens if the timeout on the Read() is really short? Like 10ms?

Proposal:
ReadTotalTimeoutConstant:    10, // 10 msec

and fire the getCommState setCommState combo every hundred iteration of the for-loop, to maintain a once every second pace for alive check.

I am looking together with @jcw into the slow-serial on windows we have. What I now see is that a call to Write() is actually only returning after 1 second. My guess is that there is a previous Read() call in progress. As no data flows in, it hits a timeout of one second. Then the Write() can be executed.

Ah, so it's the Write that is unexpectedly blocking, do you think that a test like:
port := serial.Open(....)
go func() {
    time.Sleep(10)
    port.Write([]bytes(0x70))
    time.Sleep(10)
    port.Write([]bytes(0x70))
    time.Sleep(10)
    port.Write([]bytes(0x70))
    time.Sleep(10)
    port.Write([]bytes(0x70))
    time.Sleep(10)
    port.Write([]bytes(0x70))
    fmt.Println("Done writing!")
}()
buff := make([]bytes, 1024)
port.Read(buff)

is enough to trigger the bug? (Done writing! should appear almost immediately, but if the bug is triggered it should appear after 5 seconds). I can't try this right now, I could make the test above tomorrow.
It could be that my library must use overlapped I/O to allow concurrent read and write.
https://msdn.microsoft.com/en-us/library/ff802693.aspx
it's a bit more convoluted code for read and write but if this is necessary to use concurrent I/O I'll do it during this weekend.

Proposal: ReadTotalTimeoutConstant:    10, // 10 msec and fire the getCommState setCommState combo every hundred iteration of the for-loop, to maintain a once every second pace for alive check.

This will make a CPU intensive spin-loop, even when the serial port is idle (100 calls to getCommState/setCommState per second). BTW you can use this as a temporary workaround until the bug is properly fixed.

If my theory is right, then I am looking for a non-blocking Read(). Is that available in the package?

it's not available.
This is by design: your current approach (two concurrent goroutines, one for reading and one for writing) is the suggested way to handle streams without timeouts, IMHO this is the go-way to do it. :+1:
I'm resisting the temptation to add non-blocking read/write (also because implementing timeouts in a consistent way across the various OS is a bit complicated :stuck_out_tongue:)

This will make a CPU intensive spin-loop, even when the serial port is idle (100 calls to getCommState/setCommState per second). BTW you can use this as a temporary workaround until the bug is properly fixed.

No, that is not the way I intended it. I already feel that the is a lot of USB-control messages flying over the line.
I tested the following code in the Read() function, and it works like a charm (although I did not look at CPU load).
func (port *windowsPort) Read(p []byte) (int, error) {
	var readed uint32
	var n uint8
	n = 0
	params := &dcb{}
	for {
		if err := syscall.ReadFile(port.handle, p, &readed, nil); err != nil {
			return int(readed), err
		}
		if readed > 0 {
			return int(readed), nil
		}

		// At the moment it seems that the only reliable way to check if
		// a serial port is alive in Windows is to check if the SetCommState
		// function fails.
		if n >= 100 {
			getCommState(port.handle, params)
			if err := setCommState(port.handle, params); err != nil {
				port.Close()
				return 0, err
			}
			n = 0
		}
		n++
	}
}

and
	// Set timeouts to 10 millisecond
	timeouts := &commTimeouts{
		ReadIntervalTimeout:         0xFFFFFFFF,
		ReadTotalTimeoutMultiplier:  0xFFFFFFFF,
		ReadTotalTimeoutConstant:    10, // 10 msec
		WriteTotalTimeoutConstant:   0,
		WriteTotalTimeoutMultiplier: 0,
	}

Bottomline: getCommState is called once a second as before, and a Write() has to wait at most 10ms before a pending readline returns.
The problem is sending a write when a read is waiting for charters to arrive. Only after the timeout to write seems to get executed. I had some trace logging around Read() and Write() calls that showed up like this:
read
 <--- actual call to Read() here
write
 <--- actual call to Write() here
 <--- one second delay here!
writed (=return from Write())
readed (=return from Read())

I did some performance measurements with different timeouts, and in soem tests commented out the getCommState/setCommState
The baseline is running the same go program on raspberry pi 2.
raspberry pi                                 19s
win10 timeout 1000ms                       1477s
win10 timeout   10ms                        153s
win10 timeout    1ms - no CommState          86s
win10 no timeout     - no CommState          26s

As you can see the timeout of one second is really bad for performance, but reasonable performance only is achieved without the timeout mechanism.

Oh sorry just noticed that you suggest to call get/setCommState every 100 iterations, anyway you can't avoid to call Read, if another way to fix this exists I'd like to avoid the need for tight polling-loops.
Can you check if the snippet I posted above (https://github.com/bugst/go-serial/issues/15#issuecomment-273600960) triggers the bug?

Can you check if the snippet I posted above (#15 (comment)) triggers the bug?
Yes it does.

Yes it does.

Thanks!
I've made this patch #16, it solves the problem on the test, may you try if it works for your app?

Issue Solved! I am really happy with the result. It is on par with linux now:
raspberry pi                                 19.5s
win10 overlapped-io                          21.4s

Thanks!

Great news!
I'd like to point out how important is to have a small test program to reproduce the error:

it shows the wrong behaviour much better than any exaplanation written in a spoken language
it provides something to work on, I can immediately test if a patch solve the problem
it can be re-used as a unit-test to check for regression (I'm working on a test suite for this library more to come in the future...)

Finally, thank you for the detailed bug report and testing :-)


Form Error is always: "An error occurred on the server. Please try again later."

I always get "An error occurred on the server. Please try again later.".
I think the right way would be to say something like: The email field is missing.
It prints it in the server logs, but wouldn't that be a message the user wants to see?
Hope you get what I mean.

If your form is missing a value, then it will say a field is missing in the popup error message.
An example is in the Register form: https://github.com/blue-jay/blueprint/blob/master/controller/register/register.go#L36
You can see the FormValid method in Flight: https://github.com/blue-jay/blueprint/blob/master/lib/flight/flight.go#L103
If you get "an error occurred on the server" message, it means that something went wrong on the back end of the application like the database is unavailable. Do you have a specific example you'd like to go over?

I did encounter similar issue. I guess it is because c.FlashError on https://github.com/blue-jay/blueprint/blob/master/controller/register/register.go#L37 passing correct error but https://github.com/blue-jay/blueprint/blob/master/lib/flight/flight.go#L139 is not using passed error.  I replaced the "An error occurred on the server. Please try again later." with err string.

I'm glad you replaced it with your error to fit your needs. Blueprint is supposed to be just a template that you can use in your projects. The Core library is pretty solid, but Blueprint is designed to be modified to fit your use case. You don't even have to use the libraries in Core, I find myself replacing libraries in Core as our projects mature, but it's definitely a solid jumping off point.
I'm going to leave my code the way it is so the user doesn't receive any confusing information on the front end. The actual error is logged for the admin to look at and debug:
https://github.com/blue-jay/blueprint/blob/master/lib/flight/flight.go#L138

@josephspurrier When I installed blueprint and let a field empty, there was no error message like 'Field missing: ...', it was 'An error occured on the server...'.

Which field on which screen?

When clicking on 'Create Account':

When clicking on 'Login':

What is the error in your CLI? The reason it failed should show there. Send the whole log from your console.

Console output:
2017-02-08 03:31:03 PM [::1]:42660 POST /login
flight.go:138: Field missing: email

When I add a note without content, I get the following error, that seems right:

In my opinion the error from the console should be shown in the frontend for the user to see what he has done wrong.

Thanks for bringing this to my attention. There were two issues. Login and Register should have been using the Flight.FormValid function. Also, I created a new FlashErrorGeneric for errors off MySQL and other things that are not useful to the user.
https://github.com/blue-jay/blueprint/commit/46c382431f4e2a9fdaa552ccd63c8a93921de4a2


Having a grandparent directory named 'src' causes bug

When using the docker standard image for node, projects are put into /usr/src/app.  This means that the second babel module (not sure what it is for, actually) covers all of the 3ree directory.  This caused me errors typical of forgetting to exclude /node_modules/.  In my case it seems to be fine to just add /node_modules/ exclusion to the second module, as below.  Since i'm still pretty fuzzy on how this whole stack works(thanks for helping me learn), maybe this isn't a good solution overall, but one way or another the name of the directory grandparents probably shouldn't break it.
The fix for me in webpack.config.js:
  module: {
    loaders: [{
      test: /\.js$/,
      loaders: ['react-hot', 'babel'],
      exclude: /node_modules/,
      include: __dirname
    }, {
      test: /\.js$/,
      loaders: ['babel'],
      exclude: /node_modules/,
      include: path.join(__dirname, '..', '..', 'src')
    }, {
      test: /\.css?$/,
      loaders: ['style', 'raw'],
      include: __dirname
    }]
  }

The 2nd (and redundant) loader config entry has now been removed. Can you update  your local repo and let me know if the issue is resolved?

Yep that fixed it.  Thanks!


Provide systemd file with enviroment file

Hey together,
Thanks for working on this.
I would like to ship this as package in CachyOS, since many user request such ability.
I think it would be cool to make:

a default provided system service
Make a configuration file (e.g /etc/nvidia-oc or whatever) which is loaded as environment file.

Aditonally, in the future we could even think about a simple GUI or equal

Hi,
First of all, thank you for your incredible work with CachyOS! It has been my go-to distro for a long time, and I still recommend it to those who don't want to invest time in learning NixOS, which is now my preferred distro.
Regarding the configuration file, I've just released version 0.1.15. This update allows the program to read from a default configuration file if no additional arguments are specified. By default, it searches for the configuration file at /etc/nvidia_oc.json, but this can be changed using the --file [path to your config file] option. You can find a sample configuration file here.


The definition of sector is not clear

I'm not sure anymore if a sector is really an object aggregate. Maybe rather a generically dependent continuant? Is a sector more than the sum of its parts? What are its parts?

Related to #89-

A sector may be composed of subsectors, and these also (but not necessarily so).

I'll close this to concentrate the discussion in #30


Don't swallow server-side exceptions

https://github.com/Ananto30/zero/issues/23

@powellnorma tests are still failing :thinking:
And please fix the conflict issues :pray:

Thanks again for the PR @powellnorma :raised_hands:
The Codacy is crying for not using assigned variables, but it's fine, I will fix them in my PR.


DB replication to cluster gives session_request_failed

Description
Hello CouchDB Masters :)
It used to work before, but it looks after the latest update gives that session_request_failed error.
The weird thing is that if I replicate to single node rather than to cluster it does work. I mean if the node to which I am replicating to (the localhost) is configured as single node it works. But I have cluster.
I read that there is some changes with session authorization plugins so I wonder if that might be the problem. I changed the auth_plugin of the source IP to couch_replicator_auth_noop but still same issue. Source and the localhost are both running 2.3.1.
Increasing of replicator connection_timeout does not help.
The cluster to which I am trying to replicate is on 4 nodes with n=3 and z=2.
I am fighting with this issue over a 2 days and no luck. Please help.
Steps to Reproduce
 curl -s -X POST http://admin:xxxxxx@localhost:5984/_replicate -d '{"source":"http://admin:xxxxxx@remote_ip:5984/account%2F09%2F4d%2F1247ef79204af1b68484686808e1", "target":"http://admin:xxxxx@localhost:5984/account%2F09%2F4d%2F1247ef79204af1b68484686808e1"}' -H "Content-Type: application/json"
{"error":"replication_auth_error","reason":"{session_request_failed,\"http://<IP_ADDRESS>:5984/_session\",\"admin\",\n                        req_timedout}"}
NOTE: # ( Include commands to reproduce, if possible. curl is preferred. )
Expected Behaviour
Your Environment
{"couchdb":"Welcome","version":"2.3.1","git_sha":"c298091a4","uuid":"b03848974d6bc7d697b22199cb9f0db0","features":["pluggable-storage-engines","scheduler"],"vendor":{"name":"The Apache Software Foundation"}}

this is how a DB usually look
curl http://admin:xxxxxx@<IP_ADDRESS>:5984/account%2F09%2F4d%2F1247ef79204af1b68484686808e1-201905 {"db_name":"account/09/4d/1247ef79204af1b68484686808e1-201905","purge_seq":"0-g1AAAAFTeJzLYWBg4MhgTmEQTM4vTc5ISXIwNDLXMwBCwxygFFOSA5BMiv___39WIgMedXksQJLhAJACKr1PjNoGiNr5-NUmKYDstyfS_gcQM4lSuwCidj8B-xNA9tcTNDORIUkeoigLAOjtXo4","update_seq":"28-g1AAAAFTeJzLYWBg4MhgTmEQTM4vTc5ISXIwNDLXMwBCwxygFFMiQ5L8____sxKZ8ChKUgCSSfZgdfgMS3IAqYsnbF4CSF09WB0bHnV5LECSoQFIAZXOx28mRO0CiNr9WYmMBNUegKi9n5XIQlDtA4haoHuZswBw6l6q","sizes":{"file":226840,"external":50887,"active":34167},"other":{"data_size":50887},"doc_del_count":0,"doc_count":28,"disk_size":226840,"disk_format_version":7,"data_size":34167,"compact_running":false,"cluster":{"q":8,"n":1,"w":1,"r":1},"instance_start_time":"0"}

CouchDB version used:
Browser name and version:
Operating system and version:

Additional Context
The only thing in localhost log is:
[debug] 2020-01-08T20:19:40.414467Z<EMAIL_ADDRESS><0.3476.0> 58075f119d no record of user admin
[notice] 2020-01-08T20:20:13.897351Z<EMAIL_ADDRESS><0.3476.0> 58075f119d localhost:5984 <IP_ADDRESS> admin POST /_replicate 500 ok 33486
But admin is configured:
 curl http://admin:xxxxxxx@localhost:5984/_node/_local/_config/admins/admin
"-pbkdf2-92eb0df2xxxxxxxxxxxxxx,81c547fdde17b1df6391f41ebec039a3,10"
Also:
curl  http://admin:xxxxx@localhost:5984/_session
{"ok":true,"userCtx":{"name":"admin","roles":["_admin"]},"info":{"authentication_db":"_users","authentication_handlers":["cookie","default"],"authenticated":"default"}}

As just noted on #2386 z param is not anymore supported in Couch. I am closing this an will try to replicate using placement param


Read the new Dataset

I suggest we start working with the new data of the project, and to do this we must begin by reading them. I can take of that.

Great @AntonisZks , We can implement similar functions as the ones in the previous part of the project. Since I looked into those functions let me know if I can help


Module not found: Error: Can't resolve 'pure-react-carousel' with version v1.21.0

Issue with recent version v1.21.0 on upgrading from v1.19.0

@express-crowbot

@SwapnilGatha where are you seeing that happen? In your project in general? When you start your application?

I very jankily was doing this:
@import "./node_modules/pure-react-carousel/dist/react-carousel.es.css";

Which is now gone from 1.21.0, causing:
Module build failed: ModuleNotFoundError: Module not found: Error: Can't resolve './node_modules/pure-react-carousel/dist/react-carousel.es.css'

For an immediate fix, I am going to hard code 1.21.0 as the version

I can confirm that 1.21.0 is having the issue. Here's my terminal input on install and after gatsby develop:

@sethomas @mhigley Can you please try 1.21.1?

@tim-steele
<EMAIL_ADDRESS>did the trick! Thanks!! <3

@sethomas @SwapnilGatha did 1.21.1 it fix your issues as well?

@tim-steele what a delightfully fast response, good to go on 1.21.1, I see the /dist folder and files so I can continue to jankily import the css, thanks!

Marking this as resolved.

yes<EMAIL_ADDRESS>works ! thanks @tim-steele


[hi] Localize and Created Owners-dependents.md

Created and localized owners-dependents.md for hi

Hey @divya-mohan0209, Can you review this PR!!!

Some suggestions PTAL! : )

Yes I will do it!

@kumarankit999  do you have some time to work on comments ?

/remove-lifecycle stale

@kundan2707 : Gentle reminder on this one.

@divya-mohan0209  perhapes this reminder is for @kumarankit999

Sorry @kundan2707 , my bad!
@kumarankit999 : Gentle reminder on this one.

Hi @kumarankit999 , thank you for your contribution! Since there has been no activity from your side on the PR, I'll be closing it. If you wish to resume work on it, please feel free to issue a /reopen command.
/close


improve readability of queries in web UI's query view

Scope & Purpose
Fixes a bit of web UI layout for the currently running and slow queries.
Previously, the query string was not properly left-aligned, due to usage of an HTML <pre> element inside a template that had lots of whitespace around the to-be-inserted query string. This effectly left-padding the query string, because a <pre> is supposed to keep and render all surrounding whitepace.

[x] Bug-Fix for devel-branch (i.e. no need for backports?)
[x] Strictly new functionality (i.e. a new feature / new option, no need for porting)

Testing & Verification
This change is a trivial rework / code cleanup without any test coverage.
http://<IP_ADDRESS>:8080/view/PR/job/arangodb-matrix-pr/10836/

Tests blue


Improve left side nav

Ideas:

Collapse side nav when clicking outside of the component
Close button (somewhere on the top of the pane maybe?)
Collapse side nav after dragging a component onto the editor
etc...

Closed in https://github.com/IBM/carbon-components-builder/commit/17c6401f95517ad9e4503e78a66e807b590dc61e


dapr init -k , doesn't works in China / restricted network

In general, when I execute dapr init -k  The default docker image from docker.io/daprio/dapr:1.4.3 cannot get response.
I used socks5 proxy. Again the same error. But I can get the image from commandlinedocker pull directly. Where can I reset image source with Dapr simply?
Detail:

Events:
Type     Reason                 Age                From               Message
Normal   Scheduled              72s                default-scheduler  Successfully assigned dapr-system/dapr-placement-server-0 to <IP_ADDRESS>
Normal   SuccessfulMountVolume  72s                kubelet            Successfully mounted volumes for pod "dapr-placement-server-0_dapr-system(eebdd764-8ed6-470b-bbf2-1e77dfa5ef31)"
Warning  FailedPullImage        25s                kubelet            Failed to pull image "docker.io/daprio/dapr:1.4.3": rpc error: code = Unknown desc = Error response from daemon: Get https://registry-1.docker.io/v2/: net/http: request canceled while waiting for connection (Client.Timeout exceeded while awaiting headers)
Warning  FailedCreate           25s                kubelet            Error: ErrImagePull
Warning  BackOffPullImage       24s                kubelet            Back-off pulling image "docker.io/daprio/dapr:1.4.3"
Warning  FailedCreate           24s                kubelet            Error: ImagePullBackOff
Normal   Pulling                11s (x2 over 71s)  kubelet            Pulling image "docker.io/daprio/dapr:1.4.3"

Curl could get responsed(means docker with proxy is ok .):
root@soop-dev2:~# curl https://registry-1.docker.io/v2/
{"errors":[{"code":"UNAUTHORIZED","message":"authentication required","detail":null}]}

@geekgao  - Is this consistent, in that it fails every time you use the dapr init command? I ask since there was a docker.io site availability incident yesterday.


fix: 's/astometry/astrometry/g'

Follow-up to https://github.com/Three-Buddy-Problem/exoplanet-quest-web/issues/1

Thank you so much for the PR! Before merging, if you don’t mind us asking—are we allowed to make changes like fixing typos or editing the README after the final submission? We weren’t sure, but we’d love to make these improvements if permitted.

Thank you so much for the PR! Before merging, if you don’t mind us asking—are we allowed to make changes like fixing typos or editing the README after the final submission? We weren’t sure, but we’d love to make these improvements if permitted.

Fair point!
I do not know either - also because I have only read through the rules of the local NASA Space Apps Challenge which happened yesterday at I3P, and whose awards have already been distributed, therefore I see no problems there.
For what concerns the global 2024 NASA Space Apps Challenge, as far as I know this is also closed now:

@kaandesu I am afraid you were faster than me 😄
I had prepared a new PR in https://github.com/Three-Buddy-Problem/exoplanet-quest-web/pull/5
Please notice that this original PR was against the main branch which I understand you did not want to modify...

I misclicked on this one instead and then had to revert the changes immediately. 😢


Revision

Revision of the contract upgrade example with a more clear and understandable scenario.
Compatible with the latest rust and casper versions.
Added important to know details.

Thanks @deuszex!


Make api_compatibility_test pass in Python 3

I was (perhaps masochistically) curious what it would take.
  I leave it up to others whether it's worth ignoring, cleaning up, or adopting with minimal changes.  Main plus: nearly everyone outside Google uses Python 3, and this would make it easier for people to contribute.

To clarify: this doesn't remotely pass pylint, so it shouldn't be approved without some modifications.  Happy to make those modifications if we think syntax issues are the only problem, but I'd want explicit acknowledge that this sort of hackery is okay. :)

@girving I left some comments including lint issues caught by "Ubuntu Sanity" build.
In addition to these comments, can you also remove import unittest in api_compatibility_test.py? It is no longer used with @unittest.skipUnless decorators removed.
Otherwise, this change is ok. Indeed having these manually-specified replacements doesn't look very nice. But I don't see a better way to have this test work with both Python 2 and Python 3.

Thanks for the comments!  Should be all resolved.  I agree that taking the hit once of updating the goldens once to get code simplicity (and symmetry) is good.

Thank you for fixing the test to work with python 3!

There's a couple of failures. I haven't look too deeply, is this just a concurrent change or is this a difference to Py2 (maybe preferring more local classes in superclass lists?):
  path: "tensorflow.train.MonitoredSession.StepContext"
  tf_class {
-   is_instance: "<class \'google3.third_party.tensorflow.python.training.monitored_session.StepContext\'>"
+   is_instance: "<class \'google3.third_party.tensorflow.python.training.monitored_session._MonitoredSession.StepContext\'>"

and
  path: "tensorflow.train.SingularMonitoredSession.StepContext"
  tf_class {
-   is_instance: "<class \'google3.third_party.tensorflow.python.training.monitored_session.StepContext\'>"
+   is_instance: "<class \'google3.third_party.tensorflow.python.training.monitored_session._MonitoredSession.StepContext\'>"

and
  path: "tensorflow.Variable.SaveSliceInfo"
  tf_class {
-   is_instance: "<class \'google3.third_party.tensorflow.python.ops.variables.SaveSliceInfo\'>"
+   is_instance: "<class \'google3.third_party.tensorflow.python.ops.variables.Variable.SaveSliceInfo\'>"

@martinwicke There's specific logic to fix those differences, which is why the tests pass in both Python 2 and Python 3: https://github.com/tensorflow/tensorflow/pull/23006/files#diff-66076c6ed184cb1cc7997df09d0b1c6fR50.  I'm not sure why the copybara test introduces new failures.


Add tooltip to give context to a column

Hi there Fabien !
First of all, thank you for all the amazing effort you put into Enhanced Table. You are one of the main reasons we use Kibana to show our data.
I have been using your plugin for a while and I think it would be of great value if we could add a tooltip in the column names of an Enhanced Table. Through this tooltip, we could add information about how a column was calculated, maybe show some warning message or make the user alert of a common pitfall when interpreting the value. Just as a suggestion, it could be simply a textbox when adding metrics or computed columns.
Thank you in advance and hope you keep up with the great work !

+1, this feature would be very useful to me too!

+1, this feature would be very useful to me too!

Hi,
This is a nice enhancement.
I will try to add it in next release :)

Hi,
This is a nice enhancement.
I will try to add it in next release :)

And happy to see that you appreciate my work on this plugin 👍

And happy to see that you appreciate my work on this plugin 👍


No interface method anyMatch(Lj$/util/function/Predicate;)Z in class Lj$/util/stream/Stream

Steps to reproduce
Just run app.
Expected results
Don't occur error.
Actual results
Occur error.
Code sample
Code sample
[Paste your code here]

Screenshots or Video

Screenshots / Video demonstration

Logs
Fatal Exception: java.lang.NoSuchMethodError: No interface method anyMatch(Lj$/util/function/Predicate;)Z in class Lj$/util/stream/Stream; or its super classes (declaration of 'j$.util.stream.Stream' appears in /data/app/~~i0GoKASwlDXSx_godYytgA==/androidx.test.tools.crawler-kndEwteQh3hZ2moVnBwEEQ==/base.apk!classes2.dex)
       at io.flutter.embedding.android.j.B(:48)
       at io.flutter.embedding.android.j.n(:263)
       at io.flutter.embedding.android.d.s(:130)
       at io.flutter.embedding.android.c.D(:20)
       at io.flutter.embedding.android.c.onCreate(:31)
       at android.app.Activity.performCreate(Activity.java:8342)
       at android.app.Activity.performCreate(Activity.java:8321)
       at android.app.Instrumentation.callActivityOnCreate(Instrumentation.java:1417)
       at androidx.test.runner.MonitoringInstrumentation.callActivityOnCreate(MonitoringInstrumentation.java:2)
       at android.app.ActivityThread.performLaunchActivity(ActivityThread.java:3625)
       at android.app.ActivityThread.handleLaunchActivity(ActivityThread.java:3781)
       at android.app.servertransaction.LaunchActivityItem.execute(LaunchActivityItem.java:101)
       at android.app.servertransaction.TransactionExecutor.executeCallbacks(TransactionExecutor.java:138)
       at android.app.servertransaction.TransactionExecutor.execute(TransactionExecutor.java:95)
       at android.app.ActivityThread$H.handleMessage(ActivityThread.java:2306)
       at android.os.Handler.dispatchMessage(Handler.java:106)
       at android.os.Looper.loopOnce(Looper.java:201)
       at android.os.Looper.loop(Looper.java:288)
       at android.app.ActivityThread.main(ActivityThread.java:7918)
       at java.lang.reflect.Method.invoke(Method.java)
       at com.android.internal.os.RuntimeInit$MethodAndArgsCaller.run(RuntimeInit.java:548)
       at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:936)

Flutter Doctor output
Doctor output
Doctor summary (to see all details, run flutter doctor -v):
[✓] Flutter (Channel stable, 3.16.5, on macOS 14.0 23A344 darwin-arm64, locale en-VN)
[✓] Android toolchain - develop for Android devices (Android SDK version 34.0.0)
[✓] Xcode - develop for iOS and macOS (Xcode 15.0)
[✓] Android Studio (version 2023.1)
[✓] VS Code (version 1.85.1)
[✓] Connected device (5 available)
    ! Error: Browsing on the local area network for iPhone. Ensure the device is unlocked and attached with a cable or associated with the same local area network as this Mac.
      The device must be opted into Developer Mode to connect wirelessly. (code -27)
[✓] Network resources

• No issues found!

@dam-ease Sorry for mention. Please help!

Hello @ntaworking.
Thanks for filing this.
Does this happen running the default counter app, if not, Please can you provide a minimal complete reproducible code sample that doesn’t include 3rd party plugins or complex production code?

Closing as a duplicate https://github.com/flutter/flutter/issues/141949; will post future updates there!


style of footer need to be updated

I would like to update the css and responsiveness of the footer as its user experience is not up to the mark.

@aditya-bhaumik I can able to redesign the footer and make the responsiveness of the page more suitable. Please assign me this work.

the footer is not responsive, can you assign me this issue so that I can make it in better way.

this issue has been solved, so we are closing this issue.


highlight modules

:wave: hello!
This grammar is awesome, great work! :heart_eyes:
I think it's possible to highlight modules. There's this query which is pretty straight-forward:
(module) @module

which captures things like
import gleam/io

But as you mention in the readme, it's a bit ambiguous what to do in this case:
fn pipe_case() {
  string
  |> iodata.new
  |> iodata.reverse
}

Because you might have a record with function that looks syntactically the same.
type Foo {
  Foo(bar: fn() -> Int)
}

pub fn main() {
  let f = Foo(bar: fn() { 5 })
  let _ = f.bar() // 'f' is a module? or a variable?
}

So to get around that, I believe we can use local.scm queries, which define scopes and capture variable definitions and usages ("references"). We can be pretty confident that if we have a function call or pipe and a record access, it's variable if that variable has been defined in the current scope, and otherwise we can say that it's a module. I think I have all the cases of variable definitions correct here, but it's always complicated in languages that have destructuring :sweat_smile:, let me know if I missed some!
What do you think?

OK, after doing my research I can confirm that this rocks! :guitar: Thanks!


[Improvement] Styling issue for new site theme install modal

Description
Styling issue for new site theme install modal:

You can get this modal by hitting the /admin/sites/{site_id}/themes/pick page and clicking on a theme tile
Design
How it should be looking:

Additional Information
Issue came up via https://github.com/Kajabi/kajabi-products/pull/20535 and was instructed to file this follow up

Hey @FuturaExtraBold @anechol ! Any idea when this could one be resolved?

@ForrestHolt did we ever resolve this? 😳

@philschanely Yes we did, Jamell took care of it. I will close this one 😎


Set immersive mode to true by default on Android

Immersive mode is nowadays enabled on most games and should be default. Backwards compatibility wise should not be a big deal (for those who don't read CHANGES) as the difference is obvious.

Immersive mode is needed to suppress gesture navigation so it is indeed a good idea.


any tests for "async_write_header", i get an error when use it

i am using beast to implement http chunk demand, in the code, when i use http::wirte_header, the program can work well, but if i replace it with http::async_write_header, the program will crash. next is my code

This issue is lacking the requested information. Please edit the issue to include the information listed above (and delete the text from the template).

This issue is lacking the requested information. Please edit the issue to include the information listed above (and delete the text from the template).

sorry about that, i have post issues above, the code by comments works well, but the async_write_header can cause program crash, thank you for answering my question !

This issue is lacking the requested information. Please edit the issue to include the information listed above (and delete the text from the template).

sorry about that, i have post issues above, the code by comments works well, but the async_write_header can cause program crash, thank you for answering my question !

an error occurs in field.ipp, next is the problem

This issue is lacking the requested information. Please edit the issue to include the information listed above (and delete the text from the template).

another question, when i send header with chunk setting, can i use a http::responsehttp::string_body ? in my case, when i use http::responsehttp::string_body, client can not receive the response body string

the async_write_header can cause program crash
Do the examples work for you?

the async_write_header can cause program crash

Do the examples work for you?

i have not find enough examples for http::async_write_header，https://www.boost.org/doc/libs/develop/libs/beast/doc/html/beast/using_http/chunked_encoding.html，this link just show the http::write_header

Hi wangjiangw, I use Boost too.
http::async_write_header does work as advertised. Example passing test here:
https://github.com/LeonineKing1199/foxy/blob/develop/test/session_test.cpp#L150-L185

Hi wangjiangw, I use Beast too.
http::async_write_header does work as advertised. Example passing test here:
https://github.com/LeonineKing1199/foxy/blob/develop/test/session_test.cpp#L150-L185
That code does a lot but here is the Beast call the session uses:
https://github.com/LeonineKing1199/foxy/blob/develop/include/foxy/impl/session/async_write_header.impl.hpp#L45-L57

thx, i will read it today to check if helpful for me, thank you!


Fix EXIT_SUCCESS on Android

Fixes: #89886

MacOS fixed yesterday. Web, Windows, iOS looks ok.

Thanks!


InflaterInputStream Length property is not set before fill()

InflaterInputStream.Length is 0 before executing read from it.
https://github.com/icsharpcode/SharpZipLib/blob/master/src/Zip/Compression/Streams/InflaterInputStream.cs#L552
This will cause following sample code fail,
using (Stream strm = zipfile.GetInputStream(item))
{
          using (BinaryReader s = new BinaryReader(strm))
          {
                 Data = s.ReadBytes((int)s.BaseStream.Length);
           }
}

If CompressionMethod is Deflated, the data will be always empty as s.BaseStream.Length is 0.
probably use zipentry.size as the length.

I did this in a slightly different way. I added a new constructor to the InflaterInputStream that passes the size as the second parameter and stores it in a new variable called size_, which is initialized to -1L. The Length property then checks if size_ is >= 0, and returns it if it is, otherwise it proceeds as in the original code. In the ZipFile class, I simply changed the construction of the stream to pass entries_[entryIndex].Size as the second parameter. This avoids an exception (and the possible breaking of other applications).

Fixed with pull request #84
-Neil


Convert calculate-married-couples-allowance to ERB

NOTE. This branch has been taken from use-single-erb-template-per-outcome. I'm intending to get that branch merged to master first as it makes adding support for next_steps (required for this SmartAnswer) easier than if we were still using multiple templates per outcome.

I think it would be better to DRY up the calls to number_to_currency(x, precision: ((x.to_f == x.to_f.round) ? 0 : 2)) into a helper method, e.g. #format_money. This code appears in these two commits:

4a71ca1d72e2ce1e6d8262be51512647c69bfbde
e32566be1361a79716ab5328de7c56998b16f759

Other than my small comments, this LGTM :+1:

I think it would be better to DRY up the calls to number_to_currency(x, precision: ((x.to_f == x.to_f.round) ? 0 : 2)) into a helper method, e.g. #format_money.

I certainly thought about DRYing it up but was put off because of uncertainty about where/how to add such a helper method: I think I'm right in saying that we haven't done that elsewhere yet.
I'll take a look in the morning to see what I can come up with.

I've added fixup commits to address your comments about indenting <%= render partial: ... %>.

I think it would be fine to merge this PR and DRY these methods up later, but I'd want to ensure that happens soon. I don't think we have done it elsewhere yet.

@floehopper: I've added the format_money helper method you suggested. Can you take a look at the approach and let me know if you think it's OK.

Manually merged in 0c7b68b95ac6579e0ba8c1c8d0d884768f0ebcd4.


don't 'make install' the ipr.h header

Why not?

Maybe I'm wrong, but I thought it's not useful (nobody builds against ipr.h), or?

Extensions that define data types should install sufficient header files to make it possible to build transform modules for them independently. (And likewise, extensions that are PLs should do the same.) This is the primary reason why I put so much effort into allowing extensions to install header files in the first place.

What do you mean by "transform module" and where is it documented?
Background story is that I'd have to create postgresql-ip4r-devel package having only this header file.  So I'd like to know what package/software would be built against that installed devel package.

development moved to https://pagure.io/copr/copr/pull-requests, I keep mirror in https://github.com/praiskup/copr.

Uh, wrong PR, sorry.

Transform modules specify how a particular data type is to be handled in a particular PL language. For example, for the contrib/hstore module there are transforms for plperl and plpython that map the hstore value to native perl hashes / python dicts rather than leaving it as a string requiring parsing. See https://www.postgresql.org/docs/current/sql-createtransform.html (there's another thing called "transform" documented in the Extending SQL chapter, but that's unrelated), and contrib/hstore_plperl etc.
A transform module might be provided by the author of the type, the author of the PL, or a third party. To the best of my knowledge nobody is building anything against ip4r (not even me in my own external PL), but the whole point of installing header files is to make it possible for people to do that (now or in the future) without me having to know about it.
As for having a -devel package to install one .h file that may well never be used, I agree that is overkill. But that's your packaging policy, not mine; making an exception to put the .h file in the same package seems reasonable to me (and I've seen that done elsewhere).

Ok, I haven't seen header files in third party module so far, thanks for explanation.
FTR, I've removed the file downstream, and I'll install it to *-devel once anybody really needs that.
https://src.fedoraproject.org/rpms/postgresql-ip4r/blob/4d9164b64340f91d530be88f4362c24fc281172b/f/postgresql-ip4r.spec#_37


fix: Version test

Types of changes

[ ] Hot fix (emergency fix and release)
[x] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Documentation (change which affects the documentation site)
[ ] Breaking change (fix or feature that would cause existing functionality to change)
[ ] Release (develop -> main)

Quality assurance (all should be covered).

[x] My code follows the code style of this project.
[x] Documentation for my change is up to date?
[x] My PR meets testing requirements.
[x] All new and existing tests passed.
[x] All commits are signed-off.

Summary
Fixed version test string to track latest version automatically.
Key links:

Sonar coverage

Before you merge

Ensure it is a 'squash commit' if not a release.
Ensure CI is currently passing
Check sonar. If you are working for a fork a maintainer will reach out, if required.

@fsuits , that would be a slightly more involved change as we have a validation/generation depending on version being in X.X.X format since 2021. We might need to support both cases: with v or without for backward compatibility if we decide to go this way otherwise it would be a breaking change


Replace boilerplate README.md

Replace the boilerplate README.md with something more descriptive for the project including what it is, how to run it locally and how to deploy and manage it. Also put who is the author, license and maybe other contributors.

https://github.com/Jason-Doze/crown_apparel_typescript/pull/14


Refactor, remove use of commons-io and optimize

@IgorBelyayev what do you think? Could this be merged?
It would also get rid of the gradle warning
WARNING: Configuration 'provided' is obsolete and has been replaced with 'compileOnly'.
It will be removed in version 5.0 of the Android Gradle plugin.
For more information, see http://d.android.com/r/tools/update-dependency-configurations.html.
WARNING: Configuration 'compile' is obsolete and has been replaced with 'implementation' and 'api'.
It will be removed in version 5.0 of the Android Gradle plugin.


Support fixed-width unicode strings

HSDS currently does not support these (see hdf5dtype.py:617)

Yes, string encoding and how many bytes are reserved for its storage are decoupled.

Are they supported in the library?

Yep, see here for an example of fixed-length unicode strings being used in datasets/attributes - the native VOL passes both of these tests.

The question may be more related to how h5py treats HDF5 strings where this combo is not really supported. Any fixed-length string is treated as bytes object, not Unicode string.

A fixed width unicode would be utf-32, but like @ajelenak says, it's not explicitly supported by the library. (or HSDS).

A fixed width unicode would be utf-32, but like @ajelenak says, it's not explicitly supported by the library. (or HSDS).

I think there's a confusion in terminology here. What I'm requesting is not support for a unicode character encoding where each particular character has a fixed width in bytes (e.g. UTF-32), but support for string datatypes that have a fixed total length in bytes (fixed length strings) AND have the character set/encoding UTF-8 (where a particular character does not have a fixed number of bytes associated with it).
I've updated the title of this issue to be more clear. The library does support fixed-length strings in UTF-8 (See the tests I linked above).

Implemented in #278


Add new register request history when updating un-approved service templates

Fixed https://github.com/eclipse-xpanse/xpanse/issues/2196
Testing.....
Register a service template without approved:

LGTM

LGTM

LGTM

LGTM


Recording depth and colour frames

| Camera Model D435i/D455
| Firmware Version
| Operating System & Version Ubuntu 17)
| Kernel Version (Linux Only)
| Platform Raspberry Pi
| SDK Version 2.0
| Language python
| Segment others
Hi, I want to record bag files and I was doing it at 6fps with a lower resolution using Realsense-viewer app.
I want to do it without the application now. Is there a possibility of achieving this through command line?
The reason is I'm using a raspberry PI to which I'm not connecting a monitor/screen , so I have to remotely start the recording and change the parameters.
I'm currently using rs-record -f ./test1.bag -t 60
But how to set fps to 6 and resolution rate here?
Thanks in advance!

Hi @Susheelabhat  At the empty line 33 of the rs-record program, you could insert additional 'cfg' configurations line to set the minimum FPS speed for the depth and color streams.
https://github.com/IntelRealSense/librealsense/blob/master/tools/recorder/rs-record.cpp#L33
cfg.enable_stream(RS2_STREAM_COLOR, 848,480, RS2_FORMAT_Z16, 6);
cfg.enable_stream(RS2_STREAM_COLOR,1280,720, RS2_FORMAT_RGB8, 6);
For the D455 camera model, the FPS should be set to 5 instead of 6 as D455 does not support 6 FPS.
If you wish to use a different resolution then also edit the resolution in the cfg lines.  For example, to set both streams to 640x480:
cfg.enable_stream(RS2_STREAM_COLOR, 640,480, RS2_FORMAT_Z16, 6);
cfg.enable_stream(RS2_STREAM_COLOR, 640,480, RS2_FORMAT_RGB8, 6);

Thanks for the info @MartyG-RealSense. Wanted to check one more thing,
In the ubuntu system, what is the default location of these librealsense tools/files where I can make changes?

Rather than looking in the 'build' folder, the appropriate location in the source code folder is likely to be librealsense > tools > recorder so that you can edit the contents of the rs-record.cpp file and then build librealsense from that modified source code.

I'll try this @MartyG-RealSense . Another follow up question, with the recorded .bag file, is it possible to extract depth frames outside ubuntu(realsense sdk) (where pyrealsense exists)?
I was using this code to extract frames. But how can I do it without pyrealsense support?
https://github.com/IntelRealSense/librealsense/tree/master/wrappers/python/examples/read_example_bag.py

You can run a tool provided by the RealSense SDK called rs-convert to extract depth frames from a bag file recorded in the SDK.  Though it is made from C++ code, it is available pre-built so that you can launch the tool without having to compile the code.
If you included the examples and tools with the flag -DBUILD_GRAPHICAL_EXAMPLES=TRUE when building librealsense with CMake then rs-convert should be in the usr/local/bin folder of Ubuntu.
https://github.com/IntelRealSense/librealsense/tree/master/tools/convert

I tried building librealsense  again with the code added in rs-recorder.cpp. But when I now run the command  rs-record -f ./test1.bag -t 60  , I'm getting segmentation fault error.
pi@pi2:~/Documents$ rs-record -f /home/pi/Documents/test.bag -t 60
Segmentation fault (core dumped)

Was the added code the cfg lines to set 6 FPS?

Hi @Susheelabhat  Do you require further assistance with this case, please?  Thanks!

Case closed due to no further comments received.


Enabling ustat minio metrics by default

Tested and validated on vm cluster to generate "nkv_need_path_stat": 1, in nkv config


Add testing with Broadway to Req.Test

cc @wojtekmach

Looks great to me but I'd like to manually test it before merging. Still learning the nimble ownership ropes. Thanks!

Thank you!


_posts/0000-01-02-bruce-fair-RES.md.

First slide
created a branch, created a file and made a commit, and opened a pull request

d


Failed on release migration

Description
I use last version gitea v1.16.5 via PostgreSQL 14.2
When migrating repositories from the github, I encountered a problem: pq: value does not fit into character type varying(40)
2022/04/19 11:42:20 [625e75ec] router: completed GET /user/task/5?_csrf=6mkrOo9wzGEBk-_Z6kUI6Sx2DOY6MTY1MDM1NzYyNDMwOTM1OTMwMA for [::1]:55411, 200 OK in 2.4ms @ user/task.go:17(user.TaskStatus)
5[REALEASE migrate.go] COMMIT SIZE 45 a-string-that-is-longer-than-forty-characters
2022/04/19 11:42:22 ...ervices/task/task.go:56:handle() [E] Run task failed: pq: value does not fit into character type varying(40)
        C:/Projects/gitea/services/task/task.go:56 (0x1f64005)
        C:/Projects/gitea/modules/queue/queue_disk_channel.go:60 (0x166f721)
        C:/Projects/gitea/modules/queue/queue_channel.go:65 (0x166d41d)
        C:/Projects/gitea/modules/queue/workerpool.go:561 (0x1680a0e)
        C:/Projects/gitea/modules/queue/workerpool.go:309 (0x167f2a4)
        C:/Program Files/Go/src/runtime/asm_amd64.s:1571 (0x46cc20)

The error occurred only when the Releases checkbox was checked
In the "Releases" table, only the Sha1 field has the data type charaсter varying(40)
I was surprised that sha1 has more than 40 characters and made logs
https://github.com/go-gitea/gitea/blob/b74322dfce8d15e9204900913bb815a7b0ba073f/models/migrate.go#L158-L183
I inserted the following code between lines 166 and 167 in the above file
fmt.Println("5[REALEASE migrate.go] COMMIT SIZE", len(rel.Sha1), rel.Sha1)
I saw the following in the logs: 5[REALEASE migrate.go] COMMIT SIZE 45 a-string-that-is-longer-than-forty-characters
a-string-that-is-longer-than-forty-characters - the name of the branch from which the release was made
IIf you change the type of field in the database to text, the error disappears
It's strange, but the database eventually writes hashes of commits
I create repo for reproduce this bug
Gitea Version
v1.16.5
Can you reproduce the bug on the Gitea demo site?
No
Log Gist
No response
Screenshots

Git Version
git version 2.35.1.windows.2
Operating System
Windows 10
How are you running Gitea?
use gitea-1.16.5-windows-4.0-amd64.exe
For the logs I made a build for win10 according to the instructions from README.MD
Database
PostgreSQL

Look at the result of https://api.github.com/repos/mopinon/gitea-import-release/releases , github didn't return a commit hash but a branch name. But gitea expects a commit hash.

It's strange, but the database eventually writes hashes of commits

if gitea expects a commit hash, then how sha1 gets into the database? github returns the branch name.
The github documentation states that target_commitish is the branch name
commit-ish is not necessarily a commit hash https://stackoverflow.com/questions/23303549/what-are-commit-ish-and-tree-ish-in-git

OK. I think the bug is we need to get tag commit hash but not from target_commitish


Adding new Institution

https://www.faculdadesiriolibanes.org.br/fsl/

@Gui-DataNCode I have to close this request without merging, because you requested to add a non-existent domain to this repository: Host faculdadesiriolibanes.org.br.domains.lib.FaculdadeSirioLibanes not found: 3(NXDOMAIN) Please ensure that you are familiar with this repository rules located at the bottom of this page and submit a new request with the correct information. Thank you for your understanding!


spring board crashes

Spring board crashes randomly.. and as I unlock phone there is no restart springboard pop up to ..

Duplicate of #134


New feature: Uploader strategies and GoogleDriveUploader

The current FileIO uploader only stores an image until it is downloaded. There is a need for permanent storage. A new Uploader class must be constructed and a GoogleDriveUploader must be written.

Not needed due to new feature implementation of Telegram servicer. As of now, the intruder images are sent to Telegram channel, which has persistent storage.


Extract built-in plugins

The conduit repository currently contains built-in plugins. We should rather move them to separate repositories and make sure they are included in Conduit when it's compiled. This way we can easily add more built-in plugins in the future, even ones that are not built and maintained in-house. The easiest way to include them at compile time is to just import them and add them to a global variable containing built-in plugins. The drawback of this approach is that we can only include plugins written in Go (probably not even a problem in the short term).
Depends on #37.
Once a plugin is extracted, we need to adjust the code so it references the extracted SDK instead of Conduit.

[x] S3 plugin
[x] Kafka plugin
[x] Postgres plugin
[x] File plugin
[x] Generator plugin

Closing issue! It's done :-)


BaseLogger callback seems broke in v2 - KeyError and wrong seen sample compute

System information.

Have I written custom code (as opposed to using a stock example script provided in Keras): TF 2.4.1
OS Platform and Distribution (e.g., Linux Ubuntu 16.04): Ubuntu 18.04
TensorFlow installed from (source or binary): binary
TensorFlow version (use command below):
Python version: 3.8.3
Bazel version (if compiling from source):
GPU model and memory:
Exact command to reproduce:

Describe the problem.
Describe the problem clearly here. Be sure to convey here why it's a bug in Keras or why the requested feature is needed.
It looks like BaseLogger in keras has broken somewhere in-migration from v1 -> v2?
import tensorflow as tf
import numpy as np

model = tf.keras.Sequential()
model.add(tf.keras.layers.Dense(8, input_shape=(5,)))
model.add(tf.keras.layers.Dense(1))
model.compile(optimizer="Adam", loss="binary_crossentropy")
x = np.random.rand(4,5)
y = np.random.randint(0, 2, (4,))
model.fit(x, y, epochs=10, callbacks=[tf.keras.callbacks.BaseLogger()])

I end up getting KeyError: 'metrics'.
I have been hit by this and trying to understand what the Tensorflow/Keras team's vision is with BaseLogger.
Looks like BaseLogger was applied by default on all keras model but this is only true for TensorFlow V1 models as indicated here https://github.com/tensorflow/tensorflow/blob/e104b6a9e87ea5956451ab56c1f5ca486c511bc4/tensorflow/python/keras/callbacks.py#L73-L112.
I have been debugging into this code flow and it appears that BaseLogger is no longer applied by default to V2 models.
Also, it appears that BaseLogger is severely broken for use in v2 graphs as no such metrics exists in param https://github.com/tensorflow/tensorflow/blob/e104b6a9e87ea5956451ab56c1f5ca486c511bc4/tensorflow/python/keras/callbacks.py#L944. I think the right fix here is to change self.params['metrics']  to logs.keys(). However, looking at how averaging is done, that part also seems broken as self.seem is always zero for generator, dataset-based training as batch value is always 0 for those cases. Also, then here https://github.com/tensorflow/tensorflow/blob/e104b6a9e87ea5956451ab56c1f5ca486c511bc4/tensorflow/python/keras/callbacks.py#L927-L930
no such thing as size or num_steps exists on log anymore on v2 graphs, so the default of 0/1 is picked that makes seen ==0 leading to ZeroDivisionError: float division by zero.
Is there another alternative approach recommended for BaseLogger for v2 then? Documentation seems to suggest https://www.tensorflow.org/api_docs/python/tf/keras/callbacks/BaseLogger?hl=en BaseLogger continues to be applied on by default to all keras model v2 or v1 but I disagree with this, this is not true anymore with v2, I never break into this flow unless I have custom callback-based of BaseLogger.
This was raised earlier in TF codebase here https://github.com/tensorflow/tensorflow/issues/46344 but I am confused looking at inactivity on this issue, surely this should be a very critical bug that should be fixed ASAP if BaseLogger is the the way to add to customize log stream, if not what is the alternate method.
If I was to ignore BaseLogger completely, what is the recommended approach to write custom Callback so I can compute seen sample counts if I use generator/dataset based train where model.fit is not called with batch size?
Describe the current behavior.
BaseLogger to work as documented..
Describe the expected behavior.
KeyError and also wrong logic for seen samples or averaging I think.
Contributing.

Do you want to contribute a PR? (yes/no):  yes if I get better understanding of vision with BaseLogger

Standalone code to reproduce the issue.
Please see above
Source code / logs.
Please see above

Hello, Thank you for reporting an issue.
We're currently in the process of migrating the new Keras 3 code base from keras-team/keras-core to keras-team/keras.
Consequently, This issue may not be relevant to the Keras 3 code base . After the migration is successfully completed, feel free to reopen this Issue at keras-team/keras if you believe it remains relevant to the Keras 3 code base. If instead this Issue is a bug or security issue in legacy tf.keras, you can instead report a new issue at keras-team/tf-keras, which hosts the TensorFlow-only, legacy version of Keras.
To know more about Keras 3, please read https://keras.io/keras_core/announcement/


Driver validation on Kubernetes v1.20

FIXES #853

Now it's a clean, minimal solution. Looks good.

I pushed a new commit that drops enabling of Beta/GA CSI features, just to avoid unnecessary warnings. Can you pleases check if it's ok.

Now it's a clean, minimal solution. Looks good.

I pushed a new commit that drops enabling of Beta/GA CSI features, just to avoid unnecessary warnings. Can you pleases check if it's ok.

Something is still broken with Kubernetes 1.17 (https://cloudnative-k8sci.southcentralus.cloudapp.azure.com/blue/organizations/jenkins/pmem-csi/detail/PR-860/5/pipeline):
[2021-01-22T17:35:23.610Z] 17:35:21 pmem-csi-govm-master: [kubelet-start] Writing kubelet environment file with flags to file "/var/lib/kubelet/kubeadm-flags.env"
[2021-01-22T17:35:23.610Z] 17:35:21 pmem-csi-govm-master: [kubelet-start] Writing kubelet configuration to file "/var/lib/kubelet/config.yaml"
...
[2021-01-22T17:36:06.239Z] 17:36:04 pmem-csi-govm-master: [kubelet-check] Initial timeout of 40s passed.
[2021-01-22T17:36:06.239Z] 17:36:04 pmem-csi-govm-master: [kubelet-check] It seems like the kubelet isn't running or healthy.
[2021-01-22T17:36:06.239Z] 17:36:04 pmem-csi-govm-master: [kubelet-check] The HTTP call equal to 'curl -sSL http://localhost:10248/healthz' failed with error: Get http://localhost:10248/healthz: dial tcp [::1]:10248: connect: connection refused.
...
[2021-01-22T17:37:21.223Z] 17:37:19 pmem-csi-govm-master: Process: 1133 ExecStart=/usr/bin/kubelet $KUBELET_KUBECONFIG_ARGS $KUBELET_CONFIG_ARGS $KUBELET_KUBEADM_ARGS $KUBELET_EXTRA_ARGS (code=exited, status=255/EXCEPTWarning: The unit file, source configuration file or drop-ins of kubelet.service changed on disk. Run 'systemctl daemon-reload' to reload units.
[2021-01-22T17:37:21.223Z] 17:37:19 pmem-csi-govm-master: ION)
[2021-01-22T17:37:21.223Z] 17:37:19 pmem-csi-govm-master:
[2021-01-22T17:37:21.223Z] 17:37:19 pmem-csi-govm-master: Jan 22 17:37:14 pmem-csi-govm-master systemd[1]: kubelet.service: Main process exited, code=exited, status=255/EXCEPTION
[2021-01-22T17:37:21.223Z] 17:37:19 pmem-csi-govm-master: Jan 22 17:37:14 pmem-csi-govm-master systemd[1]: kubelet.service: Failed with result 'exit-code'.
...
[2021-01-22T17:37:21.225Z] 17:37:20 pmem-csi-govm-master: Jan 22 17:34:44 pmem-csi-govm-master kubelet[606]: F0122 17:34:44.169675     606 server.go:198] failed to load Kubelet config file /var/lib/kubelet/config.yaml, error failed to read kubelet config file "/var/lib/kubelet/config.yaml", error: open /var/lib/kubelet/config.yaml: no such file or directory

This also happened in https://cloudnative-k8sci.southcentralus.cloudapp.azure.com/blue/organizations/jenkins/pmem-csi/detail/PR-860/4/pipeline

Something is still broken with Kubernetes 1.17 (https://cloudnative-k8sci.southcentralus.cloudapp.azure.com/blue/organizations/jenkins/pmem-csi/detail/PR-860/5/pipeline):
[2021-01-22T17:35:23.610Z] 17:35:21 pmem-csi-govm-master: [kubelet-start] Writing kubelet environment file with flags to file "/var/lib/kubelet/kubeadm-flags.env"
[2021-01-22T17:35:23.610Z] 17:35:21 pmem-csi-govm-master: [kubelet-start] Writing kubelet configuration to file "/var/lib/kubelet/config.yaml"
...
[2021-01-22T17:36:06.239Z] 17:36:04 pmem-csi-govm-master: [kubelet-check] Initial timeout of 40s passed.
[2021-01-22T17:36:06.239Z] 17:36:04 pmem-csi-govm-master: [kubelet-check] It seems like the kubelet isn't running or healthy.
[2021-01-22T17:36:06.239Z] 17:36:04 pmem-csi-govm-master: [kubelet-check] The HTTP call equal to 'curl -sSL http://localhost:10248/healthz' failed with error: Get http://localhost:10248/healthz: dial tcp [::1]:10248: connect: connection refused.
...
[2021-01-22T17:37:21.223Z] 17:37:19 pmem-csi-govm-master: Process: 1133 ExecStart=/usr/bin/kubelet $KUBELET_KUBECONFIG_ARGS $KUBELET_CONFIG_ARGS $KUBELET_KUBEADM_ARGS $KUBELET_EXTRA_ARGS (code=exited, status=255/EXCEPTWarning: The unit file, source configuration file or drop-ins of kubelet.service changed on disk. Run 'systemctl daemon-reload' to reload units.
[2021-01-22T17:37:21.223Z] 17:37:19 pmem-csi-govm-master: ION)
[2021-01-22T17:37:21.223Z] 17:37:19 pmem-csi-govm-master:
[2021-01-22T17:37:21.223Z] 17:37:19 pmem-csi-govm-master: Jan 22 17:37:14 pmem-csi-govm-master systemd[1]: kubelet.service: Main process exited, code=exited, status=255/EXCEPTION
[2021-01-22T17:37:21.223Z] 17:37:19 pmem-csi-govm-master: Jan 22 17:37:14 pmem-csi-govm-master systemd[1]: kubelet.service: Failed with result 'exit-code'.
...
[2021-01-22T17:37:21.225Z] 17:37:20 pmem-csi-govm-master: Jan 22 17:34:44 pmem-csi-govm-master kubelet[606]: F0122 17:34:44.169675     606 server.go:198] failed to load Kubelet config file /var/lib/kubelet/config.yaml, error failed to read kubelet config file "/var/lib/kubelet/config.yaml", error: open /var/lib/kubelet/config.yaml: no such file or directory

This also happened in https://cloudnative-k8sci.southcentralus.cloudapp.azure.com/blue/organizations/jenkins/pmem-csi/detail/PR-860/4/pipeline

I pushed a new commit that drops enabling of Beta/GA CSI features, just to avoid unnecessary warnings.

What are those warnings? Please quote them literally in that commit's message for future reference.

I pushed a new commit that drops enabling of Beta/GA CSI features, just to avoid unnecessary warnings.

What are those warnings? Please quote them literally in that commit's message for future reference.

What are those warnings? Please quote them literally in that commit's message for future reference.

Done.

What are those warnings? Please quote them literally in that commit's message for future reference.

Done.


Ability to write to file format of my choice other than csv while ingestion

While writing the data to Kusto, I guess the SPARK Connector is writing to blob storage account in csv format. The problem I have with this is that my data can contain new lines or any such format that can break csv. I need an ability to specify the format (Ex: json.gz or tsv.gz or avro.gz) here.

Hi,
After discussing your suggesting we decided not to support altering the file format as this is an intermediate file created just for the ingestion and is saved in the most efficient format for Kusto ingestions. New lines will work well in our next version as we discarded the CsvWriter that was used and replaced it with our own implementation where now all strings will be closed between two quotation marks - "". Sorry for the inconvenience.


put video api in seperate file, remove moviepy dependency and some bu…

…gfix

Travis CI build failed, please fix it.

Good job @mghayour ! Thanks!


Feature: start using the refresh token

The reuse of the access token is implemented which already reduces the amount of calls drastically. So no need for the use of the refresh token on the short term


Logger

Hi,
I have written small access logger. It prints Request Method, RequestURI and Access Time. We can print more information like status code which is in ToDo list.
Thanks
Regards

it is a good idea, but I prefer not to impose logger with the router. But it could be interesting as middleware.


apt-get update retry

wrap apt-get update in a retry, also have it clean each time it retries
cc @kvick @coryb

aminator-pull-requests #203 SUCCESS
This pull request looks good

aminator-pull-requests #204 SUCCESS
This pull request looks good


Added another workflow in reviewpad.yml with the name mark-PR-blocked-if-not-status-ready-for-dev

changes to mark PR as blocked if the issue doesn't have label status: ready for dev
Fixes Issue
[FEATURE] Mark PR as blocked if issue does not have label status: ready for dev
Closes #5511
Added another workflow in reviewpad.yml with the name mark-PR-blocked-if-not-status-ready-for-dev

[ X] My code follows the code style of this project.
[ ] My change requires changes to the documentation.
[ ] I have updated the documentation accordingly.
[ ] All new and existing tests passed.
[ X] This PR does not contain plagiarized content.
[ X] The title of my pull request is a short description of the requested changes.

Yep, this check pull request labels and not issue labels There is no option to check the linked issue label at opening the pull request in reviewpad Reviewpad only allows checking whether opened pull request is linked to any issue

Thank you for your contribution, but as the issue is for checking the issue label (not PR label), I will close this pull request
https://github.com/EddieHubCommunity/LinkFree/pull/5947#discussion_r1161682284


Bug Remove blocklistItems from a blocklist

Type of issue
Typo
Feedback
Hi,
in the doc is mentioning make a delete request while the endpoint works with a post request instead to delete a blocklists, i guess this is a bug in the endpoint and not in the doc.
I loss time figuring out this, so maybe it can help someone else.
link is :
https://learn.microsoft.com/en-us/azure/ai-services/content-safety/how-to/use-blocklist?tabs=windows%2Crest#remove-blocklistitems-from-a-blocklist
to Remove blocklistItems from a blocklist.
Page URL
https://learn.microsoft.com/en-us/azure/ai-services/content-safety/how-to/use-blocklist?tabs=windows%2Crest#remove-blocklistitems-from-a-blocklist
Content source URL
https://learn.microsoft.com/en-us/azure/ai-services/content-safety/how-to/use-blocklist?tabs=windows%2Crest#remove-blocklistitems-from-a-blocklist
Author
Azure
Document Id
https://learn.microsoft.com/en-us/azure/ai-services/content-safety/how-to/use-blocklist?tabs=windows%2Crest#remove-blocklistitems-from-a-blocklist

@tawfikyassine
Thanks for your feedback! We will investigate and update as appropriate.


Warning: overloaded virtual function

fem/bilininteg.cpp(3679): warning: overloaded virtual function "mfem::VectorCoefficient::Eval" is only partially overridden in class "VCrossVShapeCoefficient"

This should be resolved by adding
using VectorCoefficient::Eval;

as done in a few other places in the code. We have not seen that warning in our tests... can you provide more details on your platform, compiler, etc?

This should be resolved by adding
using VectorCoefficient::Eval;

as done in a few other places in the code. We have not seen that warning in our tests... can you provide more details on your platform, compiler, etc?

Thank you @adam-sim-dev.
Can you check if https://github.com/mfem/mfem/tree/2003-fix fixes the issue for you?

Thank you @adam-sim-dev.
Can you check if https://github.com/mfem/mfem/tree/2003-fix fixes the issue for you?

@tzanio , 2003-fix branch fixes the warning. The other two warnings are:
fem/bilininteg_diffusion_pa.cpp(1554): warning #125: expected a "("
#pragma unroll MD1
^
fem/bilininteg_mass_pa.cpp(942): warning #125: expected a "("
#pragma unroll MD1
^

@tzanio , 2003-fix branch fixes the warning. The other two warnings are:
fem/bilininteg_diffusion_pa.cpp(1554): warning #125: expected a "("
#pragma unroll MD1
^
fem/bilininteg_mass_pa.cpp(942): warning #125: expected a "("
#pragma unroll MD1
^

@camierjs, have you seen this error?

@camierjs, have you seen this error?

Hi @adam-sim-dev,
I pushed a change in 2003-fix can you try it again>
Tzanio

Hi @adam-sim-dev,
I pushed a change in 2003-fix can you try it again>
Tzanio

Hi @tzanio , I can confirm that the new commit silences the warnings.
Adam

Hi @tzanio , I can confirm that the new commit silences the warnings.
Adam

Thanks, see https://github.com/mfem/mfem/pull/2012

Thanks, see https://github.com/mfem/mfem/pull/2012


Django update

Updated to min supported django version.

@sramirezgroveco Could you pls take a look ?

@sramirezgroveco It won't affect our site, since we have the requirements pinned to specific version. And it will not affect us since we're already on django 2.2


Infer operator returning container type instead of applied generic

Bug Report
🔎 Search Terms
infer, conditional type, generic, alias
🕗 Version & Regression Information

This changed between versions v4.1.5 and v4.2.3

⏯ Playground Link
Playground link with relevant code
💻 Code
type BaseContext<TConfig> = {
  foo: number;
  config: TConfig;
};

type FullContext<TConfig, TContext> = TContext & BaseContext<TConfig>;

type ExtractAdditionalContext<TContext extends FullContext<any, any>> =
  TContext extends FullContext<any, infer TAdditionalContext>
    ? TAdditionalContext
    : never;

type Config = Record<string, string>;
type AdditionalContext = { customValue: string };

type Context = FullContext<Config, AdditionalContext>;
type ExtractedAdditionalContext = ExtractAdditionalContext<Context>;

declare const additionalContext: AdditionalContext;
const test1: ExtractedAdditionalContext = additionalContext;

🙁 Actual behavior
I expected ExtractedAdditionalContext to be  AdditionalContext or { customValue: string }, and for test1 to compile without error.
🙂 Expected behavior
ExtractedAdditionalContext is AdditionalContext & BaseContext<Config> which is the same type as Context. test1 results in a compiler error of:
Type 'AdditionalContext' is not assignable to type 'AdditionalContext & BaseContext<Config>'.
 Type 'AdditionalContext' is missing the following properties from type 'BaseContext<Config>': foo, config

Additional notes
When I remove the config property from BaseContext the issue is resolved.

Bisected to #42284

If you keep substituting in the expansions of each type and see the operation being performed, this is a correct inference -- as in many cases, there are multiple equally correct inferences that can be made, and as a result of the linked PR we switched from a certain correct inference to a different correct inference. In general it's not safe to assume that inferring onto a T & U will reliably "break apart" a source type which was also constructed through a T & U - this can happen, but is not guaranteed to.

Thanks for the quick reply! I can appreciate how this is a correct inference, but it's certainly surprising. I'm sure a case exists, but I'm having a hard time imaging a time where I'd want the current result.
I guess it's partially surprising because I wrote FullContext<any, infer TAdditionalContext>, not infer TContext & BaseContext<any>. The syntax suggests that I'm asking the compiler to tell me what was provided to the second generic of the type. Clearly that's not how the infer keyword works, but that begs the question -- can we have that feature? :)

The syntax suggests that I'm asking the compiler to tell me what was provided to the second generic of the type.

Yeah, inference is structural, not nominal, so generally the type system has to work backwards from the output of the generic to figure out what should go in the infer position.  It's a bit like solving for x in f(x, y) = z given fixed y and z - the solution isn't guaranteed to be unique.

Clearly that's not how the infer keyword works, but that begs the question -- can we have that feature? :)

I'm not a TypeScript developer, but from what I do know about how the type system works I'm going to say probably not - in many cases the compiler doesn't even know which type alias a type came from, so infer always has to be done structurally.

Nothing's impossible but in general we're not keen to spend time tweaking things in the grey areas of inference - there are always going to be cases where there's a structural inference going on here, so making 6 out of 10 cases work as opposed to 4 out of 10 cases doesn't really change the situation much.

Yeah, inference is structural, not nominal, so the type system is always working backwards from the output of the generic to figure out what should go in the infer position. It's a bit like solving for x in f(x, y) = z given fixed y and z - the solution isn't guaranteed to be unique, depending on what f does with its arguments.

Thanks, I was missing this context and it explains why this is so difficult.

Nothing's impossible but in general we're not keen to spend time tweaking things in the grey areas of inference

That's reasonable and I understand why the team takes that position. I'll close this issue, thanks for you time.

@dpchamps came up with a good solution to my problem that I'll post here for others. Instead of inferring the generic, we can omit the keys in BaseContext from FullContext. This can omit too much if AdditionalContext contains keys that are also in BaseContext, but that's not a problem in my case. Here's a working example.


Readme file upadte

I request to to please accept my request I made some changes in my readme file

Kindly make the updates in your branch directly.


After generating wrong page is loaded

Version
v6.2.0
Reproduction link
https://github.com/nuxt-community/lunr-module/tree/master/example
Steps to reproduce
Clone the lunr-module, upgrade nuxt-i18n to ^6.2.0 and run the test.
What is expected ?
Test succeeds
What is actually happening?
Test fails as the page /af/ returns title for /en/
Additional comments?
Running yarn dev works fine, the issue is with generating. Probably related to #378

This bug report is available on Nuxt community (#c300)

It seems expected since on first opening of the URL nuxt-i18n detects browser language and redirects to matching locale. So if the first URL opened is one that doesn't match browser locale, nuxt-i18n will redirect to it (en in this case).
Manual repro for this fixture is to start up a local server, open incognito/private window and go directly to http://<IP_ADDRESS>:8080/af/.
Probably for your tests, it would make sense to disable detectBrowserLanguage option.
(And while I find the behavior a bit weird too, it's not that obvious how to improve that so that it works in all possible cases (differing browser languages vs. URL that we navigate to initially vs. different prefix strategies). So even if one could argue it's not ideal, it's more a missing feature than a bug.)

Can confirm that detectBrowserLanguage fixes the test. Strangly I cannot reproduce this error when I load the static generated files in my browser, then I just get the /af/ page.
But I dont think that detectBrowserLanguage should do anything if I browse to a specific locale page, that should only work when its unknown which locale the user needs. If I specifically browser to /af/ then you already know which locale I want to see

For nuxt-i18n, locale is unknown until the i18n_redirected cookie is set. That's the simple logic right now. Anything more complex needs should be treated as a feature request IMO as it needs to be properly thought out, implemented and tested.
For example, since with prefix_and_default strategy all locales have prefix, how to decide if navigating to /en/ should redirect? There are a couple of cases to consider:

browser locale is af, default locale is en
browser locale is en, default locale is af
browser locale is xx, default locale is yy

I think it's not that obvious how to handle all the cases.

But you know the locale from the route, why would anyone care about browser settings or redirecting if I already tell you I want to see the af page? Especially for the prefix_and_default setting, there you should only care about automatically setting the locale for the default and not for any prefixed routes.
Feature or not, something in 6.2 introduces this breaking change ;)

#378 is the change that introduced this behavior change but I would argue it's still a bug fix as it has aligned browser language detection behavior for universal and generated cases. And while that redirection logic is a bit stupid, it's now consistent at least.
It might be a good enough logic to only trigger redirection when the initial request is to non-default locale route but I can't tell for sure now without testing more. And it would be a breaking change for sure.
Previously detection code didn't run at all for generated page as it was triggered from middleware which doesn't run for initial request in generated page.

Created #455


After uninstalling dokku, service still runs

Description of problem
I uninstalled dokku.
I expected it to be gone.
I was seeing the service logging to syslog (failing to run), and I didn't think it should run.
After running sudo systemctl stop dokku-event-listener.service it stopped logging.
Steps to reproduce
Install dokku on ubuntu
(not sure if this is necessary for reproduction) deploy an app using Postgres and Regis
delete all apps
uninstall dokku
tail -f /var/log/syslog
observe the service still running.
dokku-event-listener version
dunno.  It was uninstalled, but still being called every 10 seconds.
Output of failing command
Apr  9 00:00:51 hostname systemd[432964]: dokku-event-listener.service: Failed to locate executable /usr/bin/dokku-event-listener: No such file or directory
Apr  9 00:00:51 hostname systemd[432964]: dokku-event-listener.service: Failed at step EXEC spawning /usr/bin/dokku-event-listener: No such file or directory
Apr  9 00:00:51 hostname systemd[1]: dokku-event-listener.service: Main process exited, code=exited, status=203/EXEC
Apr  9 00:00:51 hostname systemd[1]: dokku-event-listener.service: Failed with result 'exit-code'.
Apr  9 00:01:01 hostname systemd[1]: dokku-event-listener.service: Scheduled restart job, restart counter is at 261998.
Apr  9 00:01:01 hostname systemd[1]: Stopped dokku-event-listener process.
Apr  9 00:01:01 hostname systemd[1]: Started dokku-event-listener process.

Thanks for the bug report!

Same here.
My workaround:
sudo systemctl daemon-reload
sudo systemctl stop dokku-retire.service
sudo systemctl mask dokku-retire.service
sudo systemctl stop dokku-retire.timer
sudo systemctl mask dokku-retire.timer


Fix race condition on websocket handshake lead to skipping the first frame

The inial idea here was pretty simple: to extend websocket tests to check raw-server? set to true. Which undercovered a sneaky race condition that failed tests from time to time. Now the build is in green (I've already re-tested it dozens of times).
There's quite a lot here. A quick summary of notable changes:

Use processHandshake instead of finishHandshake. Hard to imagine this is the problem, but still safer.

Cleaning up the connection is updated both for the server and the client. The approach is to check if a channel is not closed yet (might happen). Server connection does not perform channel.close (as it's already covered in Netty). Not sure why Netty implementation is not consistent here, will probably open Issue for this.

raw-stream? server skips empty buffers.

raw-stream? websocket server to retain ButyBuf from a message before putting onto the stream.

Websocket connection pipeline is reogranized before handshake. Note, that pipeline-transform is still applied after to make sure we do not break no one's existing transformations.

@ztellman WDYT?

Regarding connection close: it's actually implemented this way intentionally in Netty. Still, not compliant with RFC though. RFC requires both sides to wait for the echoed closing frame which is not handled in any way right now. Fully compliant implementation is not trivial. So, I think it makes sense to leave things "as is", but I'll keep this on my radar.


Add Remember me checkbox to login page

Add a 'Remember me' checkbox to login screen so UserSession is remembered across sessions

Coverage remained the same at 52.482% when pulling 54fb2075dd028272d00532afacdf0b5111336215 on mdecuir/login-remember-me into 9ab2c26f9e433e4c23825fb5a5219a5e9ca59506 on master.

@caseyhelbling yeah, I wanted to test that it actually remembers your login after closing and re-opening the window, but I wasn't sure exactly how to do that within the current test structure of the app.
It seemed weird me to that there wasn't a user_sessions_controller_spec.rb, but I didn't want to create a new one with the limited time I had last night.
If you have ideas about how to better test that this functionality works as expected, I'd love to hear them!

Merging... There's no downside here, I guess 🤷♂


The app closes when tapping the "Scenario" button

I updated the apk this morning through Google Play and when I tried to see the Scenario enhancements... Oh oh! I cannot see the scenarios anymore, the apk shuts down immediately.

I took this screenshot of the error, I hope it helps

I'm aware of this issue. I received many reports on this. An update is on it's way and should be available until tomorrow.

Fixed