Research feasibility of using CMR to search NASA data

NASA has a common meta data repository (CMR) where they store the metadata for nearly all of their datasets.
The first step implementing the ability to search across the CMR is to understand how they do it and what it would look like for us to do it in Raster Foundry.
NASA earth explorer uses the cmr. and their methodology is available on github.

One idea would be able to change our filter/add scenes view to allow it to switch over to viewing CMR data. It is unclear what that would look like, the limitations of it, etc. so it would be good to figure out how that might look here.

@lossyrob reminded me of the interest by one of the most active outside-azavea GeoTrellis contributors (metasim) in looking into the CMR for GeoTrellis cataloguing. Not sure if any of this is relevant, but may be some extra context:
(copy and pasted convo from a gitter feed is a little messy...but I think sense can be made from it..)
hjaekel	@pomadchin We upgraded the scala-landsat-util to the new sat-api. Are there any plans to transform the scala-landsat-util to scala-sat-util? We need the same functionality for Sentinel (thats why we are also working on geotrellis-gdal) and we are currently discussing how to proceed.	1/24/17
echeipesh	@hjaekel we didn_„Žt really have plans, but that makes a lot of sense. We_„Žd have to figure out how to deliver it, a mini library for each supported catalog probably (?). If you want to spike out that code we_„Žll definatly find a home for it in that project.	1/24/17
pomadchin	@hjaekel yes, noticed; great prs ^^„Ž	1/24/17
echeipesh	^ Ah, I see the PR.	1/24/17
metasim	"@hjaekel To be super general, we should consider what it would take to interface via NASA's Central Metadata Repository (CMR), which intends to be the centralized point of search and access (either via download links or data product ordering). The catalog is quite extensive.
https://cmr.earthdata.nasa.gov/search/site/search_api_docs.html
It won't handle the cases where the data is mirrored by AWS or Google Earth Engine, etc."	1/24/17
metasim	"You can manually see what's available here:
https://search.earthdata.nasa.gov"	1/24/17
metasim	Not trying to encourage scope creep, but having a Scala API over that system would be significant. I've considered implementing it several times myself, but keep getting pulled off to other more pressing things.	1/24/17
metasim	We've talked to some folks at NASA about it, and it appears that NASA & USGS (maybe NOAA) are actually committed to getting a centralized system be the go-to place for discovering data assets.	1/24/17
echeipesh	That NASA query API doesn„Žt look too intense at first glance, not sure how many return types are there. Also knowing the AWS/Google mirror is pretty useful because to get the bytes cheap.	1/24/17
hjaekel	@metasim I will look at it	1/24/17
pomadchin	I tried to do smth like that but for landsat api to get tiles directly from usgs (as amazon and google have not complete sets of lc scenes); but it was ugly (i needed to auth and to download scene :D)	1/24/17
metasim	I did the same with USGS, even generating SOAP classes via XSD. Indeed messy. CMR is much cleaner.	1/24/17
metasim	At least from looking at the docs.	1/24/17
metasim	Also generated bindings for MODIS/MODAPS; cleaner, but very limited.	1/24/17
hjaekel	I think an abstract search api with the possibility to add custom catalogs as suggested by @echeipesh would be the most flexible approach. Downloading is also an issue, especially when different platforms offer the same data in different formats.	1/24/17
metasim	Fortunately, if architected properly, the separation between "what's available" and "how do I get it" allows for multiple "fetch" backends. Once you know the granule or scene ID from a CMR search, you can use that to poke AWS/Google/Azure to see if they have it available, and fall back to the authoratative source if necessary.	1/24/17
metasim	In our case, the multi-spectral products hosted by AWS, etc. aren't really useful because they haven't been calibrated to the quality degree we need, so our use cases lean toward getting from the official sources anyway.	1/24/17
hjaekel	@metasim maybe downloading should be separated from the search	1/24/17
hjaekel	It seems to bring its own complexity	1/24/17
metasim	Yeh, that's what I'm trying to say.	1/24/17
metasim	The results you get from CMR are of two forms (generally): URI of where to download the data, or URI and other metadata on how to order what you want (e.g. you want some higher-level data product that hasn't been computted yet).	1/24/17
metasim	In the latter case you have to either poll the system for completion, which then gives you the download URI, or you have to have an email handler to receive the compute status messages.	1/24/17
metasim	IMO, getting the searching API right is the critical part.	1/24/17
metasim	The download API is probably a moving target as this industry evolves	1/24/17
hjaekel	Yes, it's a moving target. Here in Europe there are several initiatives for building up new distribution services	1/24/17
metasim	Here in the USA, our government likes to reinvent the wheel at least 4 time before acknowledging any commonality in mission ;-) So CMR is actually some measureable progress!	1/24/17
lossyrob	@metasim great comments. Is there code out in the wild around reading from the CMR a la scala-landsat-util? I_„Žd be interested in contributing if there is.	1/24/17
lossyrob	and if not, collaborating on building it :)	1/24/17
metasim	Short answer: no. Where I left off with it was trying to figure out which of the multiple output schema specifications it supports would be most amenable to Scala boilerplate generation. I was starting to think that just hand writing would be the right approach... it's not even clear to me if the request side has a schema. USGS EarthExplorer had a SOAP 1.0 API which, while ugly, allowed generation of a scalaxb API.	1/24/17
metasim	I'm not an expert at theses REST-y JavaScript-y things, so I never know if something doesn't exist because I don't know where to look, or if it just doesn't exist.	1/24/17
metasim	So I got stalled by analysis paralysis :/	1/24/17
lossyrob	Gotcha. We have some work that a lib like that would be great for, so I think we_„Žll end up building it one way or the other. When that starts up I_„Žll make sure to loop you in (and anyone else here who is interested)	1/24/17
metasim	If someone has a strong opinion or guidance on how to approach writing an API against a public REST API such as this, I'd like to hear it, and would be willing to do the leg work of getting a prototype running.	1/24/17
lossyrob	for more broad open imagery sources, we_„Žre working on an API to catalog more generally, which will end up having a scala-landsat-util-like library in front of it, so hopefully that will be helpful	1/24/17
metasim	IOW, if someone says "write the search calls from scratch, and rely on the KML output spec" or whatever, I'd go from there.	1/24/17
lossyrob	awesome, good to know. We should put our heads together on a prototype, I think you_„Žll find some strong opinions here :)	1/24/17

I played around with the NASA Earthdata Search UI and inspected its API requests, read the CMR API documentation, interacted with the API using a REST client, and attempted to do a quick-and-dirty rewrite of RF's frontend Scenes Service to use the CMR API instead of ours. My goal was to evaluate how feasible it would be to interact with the CMR API directly from the RF interface.
Summary
CMR publishes earth-observation metadata via an API, and there is enough overlap with the functionality that we expect from our API that it should be possible to offer useful interaction with CMR from the RF UI by writing a fairly simple translation layer. However, there are some significant differences in functionality and available data that may make it difficult or impossible to offer a completely seamless user experience.
Similarities
Many API parameters are quite similar. For example, CMR queries can be made with the following parameters (among others) that correspond well with parameters available in the RF API:

cloud_cover=min,max
page_size
offset
revision_date=min,max
bounding_box

Concepts
There are similarities here, too:

CMR "Collection" -> RF "Datasource"
CMR "Granule" -> RF "Scene"

CMR provides responses in plenty of different formats for both Collections and Granules.

Differences
Despite the similarities, there are several significant differences between the CMR API and ours which could require significant effort to translate and/or might impact user experience:

CMR, in general, does not provide thumbnails of Granules. Some Granules have tiles available via the GIBS API, but not all. This will prevent us from displaying thumbnails in the Scene list view and Scene detail maps (although we will be able to display a tile layer on the detail map for those Granules which are available through GIBS). GIBS primarily provides 1) Pre-selected false-color composites and 2) Calculated indexes. It does not provide multi-band reflectance data.
CMR does not allow spatial queries for Granules without also specifying one or more Collections. CMR allows spatial queries for Collections, but it isn't very useful since many Collections have global coverage. It is possible, however, to annotate each Collection with a count of how many of its Granules intersect a spatial query. This should allow us to mostly replicate our grid-select functionality but it's not clear how well the CMR API will perform for that use-case, and it will always require selecting one or more Collections first.
CMR makes footprints available, but they are not in GeoJSON format: they're just lists of coordinate pairs as far as I can tell. This will require some translation.
CMR has thousands of Collections available, but many of them are derived data such as global mosaics or vegetative indices that may not be especially useful to our early users. At first, we should probably curate a set of Collections that will provide the most value to our users without overwhelming them. If we eventually want to support all the Collections that are available through CMR, we should consider designing and creating an interface for browsing Collections (Datasources), because our existing filter pane wouldn't be able to accommodate thousands of datasources. GIBS has an interface that is based around thematic areas which might work well (but it's unfortunately not API-driven).

Other considerations

Some resources (notably downloading data) require authentication. There is support for API tokens but my attempts to create an account were entirely unsuccessful (I've opened a support ticket but haven't heard back), so I haven't been able to test out how this works.
I tried to do a quick-and-dirty rewrite of the UI's Scenes Service to interact with CMR. Translating the query parameters was straightforward but I ultimately got hung up on what seemed to be a CORS issue. CMR supports CORS so it's likely that I was just doing something wrong, but it's possible this may require some effort to figure out.

cc @designmatty

This is great @ddohler.
Pending level of effort required: Sounds to me like the next step would be picking 1 or 2 collections that seem most promising. Presumably one of the few from GIBS that has thumbnails and would be the easiest to integrate with the current UI.  You mention:

CMR does not allow spatial queries for Granules without also specifying one or more Collections. CMR allows spatial queries for Collections, but it isn't very useful since many Collections have global coverage.
Did it seem like there are 1 or 2 data sets that could be integrated into the current spatial query method? i.e. one of the non-global datasets.

Yeah -- I agree that picking some limited number of data sets that seem useful and are available from GIBS is probably the best next step. One thing to note is that there are no datasets available with thumbnails, even the datasets that GIBS provides. The best we can manage is to show a tile layer on the Scene detail page. We could potentially construct "thumbnails" by selecting a really zoomed-out tile from GIBS but that's hacky at best.
The spatial queries shouldn't be that much of an issue at this stage since the API does allow spatial queries as long as you're performing the query across a limited number of Collections. So if we pick one or two data sets ("Collections") then I think we should be good to perform spatial queries after that (with the caveat that it's not clear whether we can replicate our scene grid functionality due to the number of queries it requires).

I picked two datasets that seem potentially useful and are from GIBS

Rainfall from the AIRS instrument (AIRS_Precipitation_Day)
Daily max temperature from Daymet (Daymet_Maximum_Air_Temp_Daily)

Seem reasonable @ddohler and/or @notthatbreezy ?
Seem like something we could reasonably get into a sprint or two? Or is this a bigger endeavor?

@notthatbreezy Curious what's the final resolution/analysis on this was, leading to closing it?

Ah oops - that was an oversight on our part -- there isn't one yet.
We have been testing out a system waffle.io to track our sprints and velocity. Inside waffle's UI it's easy to inadvertently close an issue when moving it across columns. I'm going to reopen it.

I think a few of us at Azavea had this discussion offline -- and I want to surface it here.
It seems to me that the CMR data and some of these derived maps are going to have the most use inside of the "lab" as opposed to the browseable UI that fits better for datasets that do not have a continental or worldwide footprint.
One way I could see the integration working is by incorporating some way for a user, when building a tool to import CMR data for the extent of the area they are analyzing with the tool. It's tough to say if that would be useful though given we don't have a good sense of the breadth of use-cases for tools -- though we have some so far.
Another option is to forego displaying this data in the UI in the same way we do with imagery.
I think this is veering off more to a design/ux task at this point that we'll have to come back to it given we have a rough sense of what the technical limitations/opportunities are with CMR thanks to research by @ddohler.


[QUESTION] mPDF config in Laravel-Excel

How I can config the default mPDF font in laravel-excel
for example
default mPDF I config the constructor
$pdf = new \mPDF('th');
And In laravel-excel, excel.php config file I change pdf.driver to  mPDF but how I can put the constructor parameter.
Please help. THX.

I don't think there's a way to do that. We just call \PHPExcel_Settings::setPdfRenderer($driver, $path) which only allows a string, not an instance.
Best to ask at PHPExcel about this, I think.


Apexmalhar 2017

@tweise @PramodSSImmaneni please review. Originally submitted by pramod. Multiple tests were failing with latest, so fixed tests.

Please remove all changes from the PR that are unrelated to the checkpoint listener (formatting, arranging imports etc.). That can be done in a separate PR, in fact it would be great if you could take up fixing the checkstyle in the contrib module: https://issues.apache.org/jira/browse/APEXMALHAR-1909

@tweise sorry I pushed wrong branch. I will close this & create a new pull request shortly.


Time Series: Modernize notebooks to use recent versions of pandas and SQLAlchemy

Problem
Even if only just conceived, the new notebooks are immediately outdated already, using legacy technologies like pandas 1.x and SQLAlchemy 1.x.

https://github.com/crate/cratedb-examples/pull/379
https://github.com/crate/cratedb-examples/pull/383

Solution
Provide updates to use more recent / modern versions of both pandas and SQLAlchemy.

@wierdvanderhaar reported that we dearly need this update.

GH-430

Does anyone have any capacity to fix this? /cc @surister, @wierdvanderhaar, @ckurze, @hammerhead


teacher tool: add address bar

Implements the address bar control.
TODO (in a future PR):

Swap arrow icon for a carriage return
Make the icon clickable

Still a little skeptical about the tailwind-like classes, but we don't need to block on it.

I'll remove them!


Support "W3C HTML JSON form submission"

As title, can we parse complex path-name like w3c suggested? http://www.w3.org/TR/2014/WD-html-json-forms-20140529/

Reference: formic validator

This W3C spec seems to have been downgraded from a 'working draft' to a 'note' some time in the last month:
W3C HTML JSON form submission Working Draft (retrieved 5th September 2015)
W3C HTML JSON form submission Note (current)
Which now reads "Beware. This specification is no longer in active maintenance and the HTML Working Group does not intend to maintain it further.".
 I wonder what sort of trouble they ran into.
Thanks for sharing.

W3C HTML JSON form submission no longer maintained :disappointed:


Python file scrolling

In a python file, if there is gitlens stuff showing and I type in the file, the page scrolls up a little each time I press a key.  When at the top it bounces a little.  I'm currently using
VS Code Version 1.8.0-insider
Commit 043310affe454f94c665494b77818c1425cbe8db
Date 2016-11-17T12:27:28.054Z
Shell 1.4.6
Renderer 53.0.2785.143
Node 6.5.0
GitLens 1.0.2
This looks like if may be along the same line as closed issue #9 .

This isn't only with python, having the same problem with VS Code 1.7.1, Gitlens 1.0.2 and Typescript files.

@namzat @depl0y is this only reproducible for you if the first line in the file is blank? I can't reproduce it otherwise.
If so, this is a vscode bug see: https://github.com/eamodio/vscode-gitlens/issues/19

I'm assuming this is the same as #19 -- closing. Please let me know if it isn't.


Remove pagination from aws cli outputs

This should fix https://github.com/buildkite-plugins/ecs-deploy-buildkite-plugin/issues/107

In addition to the tests this does not disable pagination on the client side, but on the server side ensuring that only a single request is sent to AWS API. The equivalent to the cli_pager option referenced in #107 would be --no-cli-pager... but it is specific to V2 so we would be forcing people to upgrade if they - for whatever reason - are still using v1.
I have opened #112 to implement a fix for this another way that I would be happy if you tested to ensure it is indeed solving the issue


Incompatible with Thunderbird v60.0

Hello,
As the title says, the extension is not compatible with the newest version of Thunderbird.

Options -> Advanced -> Config Editor...
if you set extensions.strictCompatibility false you can install it.
The only bug I have personally found is the Add-on Options re-direct dialogue is invisible and I've submitted a Pull request to fix that #513

Using @dugite-code workaround makes the extension work, but all the syntax highlighters are gone in my case.
Can you confirm this?
Thanks

BTW, this seems to be a dupe of #495.

@StuntsPT I never used syntax highlighting myself so never noticed it was broken. But yes looks like there is an issue with it.

Thunderbird 60.0 (64-bit) on MacOSX
@dugite-code workaround applied
$ shasum -a 256 markdown_here-2.13.2-fx.xpi
70e312fd35d6f531ba064298d135c920975570134f4327e66fe5e1aad614537b  markdown_here-2.13.2-fx.xpi
Thunderbird reports "This add-on could not be installed because it appears to be corrupt."

@evazquez00 see https://github.com/adam-p/markdown-here/issues/495#issuecomment-413433869

@dugite-code Modified the .rdf file as suggested in $495, it now installs, but it is unusable.  No "icon" in the composer, no options, etc.

Yeah there looks to be a number of issues that need work. I've gotten basic functionality on my system but my mods mught not be enough on another
On August 20, 2018 10:57:47 PM GMT+08:00, evazquez00<EMAIL_ADDRESS>wrote:

@dugite-code Modified the .rdf file as suggested in $495, it now
installs, but it is unusable.  No "icon" in the composer, no options,
etc.
--
You are receiving this because you were mentioned.
Reply to this email directly or view it on GitHub:
https://github.com/adam-p/markdown-here/issues/515#issuecomment-414346277

Closing as duplicate of #495.


pretrained models

At first, thank you for your effort in this work. I would like to ask about the nature of these models, are those pretrained like 2D pretrained models that trained on imageNet or what, in other words, when  I want to use them can i write this by freeze layers or what:
for params in self.model.parameters():
params.requires_grad=False

@ZFTurbo

No, weights just converted from 2D variant. You can train without freezing I guess.

@ZFTurbo Yes, you right. I tried with two options,
and I found I have to unfreeze. Thank you for your reply.

thank-you in advance, I have a question related to this: When loading models, do I need to specify particular input shape values for each model to get ImageNet weights? If so, could you please list the required input image shapes for each model?
For example:
Model1 ->image shape 1 [x,y,z,3]
while doing:
model3d, preprocess_input = Classifiers.get('efficientnetv2-b0')
model = model3d(input_shape=(x, y, z, 3), include_top=False, weights='imagenet', pooling='max')
like in your paper you have used dense model with [96,128,128,3]

If you don't include top, you can use any shape on input (with some limitations like divisible by 32 etc).

Yes, I understand that, but I just want to confirm whether the ImageNet weights are being loaded correctly for my customized input shape.

Weights are not dependent on input shape. And they were just converted from 2D variant. Mostly from 224x224 version. So I suppose something like 224x224xN will be the best - but it's usually too much for 3D variant. So I'd propose to use something like 128x128x128 - not more.

Thank you so much! That's exactly what I wanted to know. Thanks again!


Image not center when zooming

Image going beyond bounds of scroll view visible frame vertically.

While zooming the image inside the scrollView, image gets scrolled vertically and the scrollview height is much more greater than the height of image. Black space appearing.

I'm sorry, because I was very busy recently and could not solve the problem. If you can solve this problem, I will welcome PR.

Sorry, I have ignored this question for too long. If necessary, can reopen.


Explicit type management for conversion/sampling methods

add templates for get_apr* methods and sample_image based on input array data type
disable conversion of input arrays for these methods (previously the array would be cast to the type of the converter/particledata object, which may lead to unwanted effects that can be difficult to track down)
update get_apr* python functions for increased flexibility
add copy constructors for python particledata classes, allowing one-line conversion between types
update demos to improve readability

This is super cool and super useful! I will also try to go through and have a play with all the examples later, likely not till tomorrow.

closing this as it's included in #57


DynamicNodeEncoding doesn't work on root element

Thanks for the amazing open source project.
While using it I noticed that implementing DynamicNodeEncoding in order to encode a property as an attribute works great for sub elements, but always encodes as an element for the root element.
struct SplitsData: Codable, DynamicNodeEncoding {
    var version: String

    enum CodingKeys: String, CodingKey {
        case version = "version"
    }

    static func nodeEncoding(for key: CodingKey) -> XMLEncoder.NodeEncoding {
        switch key {
        case CodingKeys.version:
            return .attribute
        default:
            return .both
        }
    }
}

let encoder = XMLEncoder()
let encodedRun = try encoder.encode(self.run, withRootKey: "Run", header: XMLHeader(version: 1.0,
    encoding: "UTF-8"))
try encodedRun.write(to: url)

output is something like
<?xml version="1.0" encoding="UTF-8"?>
<Run>
	<version>1.8.0</version>
</Run>

Thanks for creating the issue, I'll have a look.

@JamesVanBoxtel are you sure you're using the latest version of XMLCoder? I've tried to reproduce the issue in a test, but the version attribute is correctly encoded as an attribute. Could you have a look at that test to verify that I'm not missing anything? Maybe there's something else in your code that could have an impact?

With no updates from the OP and no similar reports I'm closing this as stale

With no updates from the OP and no similar reports I'm closing this as stale


How to use Programmatically

Hello
this is really cool to used , thanks and Really appreciated
it is easy to use in IBInspector
but how can i used it programmtically ?

I am not aware of method to use segue without storyboard
But I think you can use the NSViewControllerPresentationAnimator to present a view
There is TransitionAnimator class for instance
parentController.presentViewController(viewController, animator: animator)

or with my extensions if you have already set the parent controller
viewController.present(.animator(animator: animator))

I am not aware of method to use segue without storyboard

same here , looking for here and there but no answer till now
for instance i used

self.presentViewController(sourceViewController, animator: TransitionAnimator() as NSViewControllerPresentationAnimator)

it doing sheetway but  i need slidefromleft how i can get this ?

Customize TransitionAnimator
let animator = TransitionAnimator()
animator .transition = [.slideLeft, .crossfade]

yeah , meanwhile i customized it
i use only slideleft
Thank you very much :)


"def _get_redfish_jobid(self, headers):" defined twice

https://github.com/dell/omsdk/blob/756d7ab1b4938dafac6da3be73df91a0f575b560/omsdk/http/sdkwsmanbase.py#L400
_get_redfish_jobid is already defined on line 244

Thanks @huornlmj we will fix it soon

Hi @huornlmj
Fixed with latest, https://github.com/dell/omsdk/tree/v.1.2.434
Kindly check


Add a new project for external-dns to push to helm charts S3

What would you like to be added:
Instead of using a third-party hosted HelmChart repository for external-dns, we should create a new project here for external-dns and have logic to push charts to our Helm charts S3 bucket.
Why is this needed:
It would be better to use an AWS hosted service to store & retrieve our resources

Thanks @taneyland,
Do you have any more context for this issue, like the impetus and what the urgency is?


replace image_not_loaded.png with smaller image

If c:geo cannot load an online image, it will show drawable/image_not_loaded.png instead. I suggest to use a smaller image instead, because if I have a cache with several images which all cannot be loaded, there is no use in showing multiple large "empty" images instead. I just want to scroll over them, because they have no value for me.
And the other thing is: Users may have gotten used to this image representing "could not load image", but the image itself absolutely does not reflect this status. Something like the good old browsers "red cross in empty image" may be suited better to transport the message, even if it is not as nice. Something like
http://www.iconarchive.com/show/oxygen-icons-by-oxygen-icons.org/Status-image-missing-icon.html
http://findicons.com/icon/185419/image_missing?id=362146
Comments? Other opinions? Suggestions for better images/icons?

Good idea! I would prefer the second.


Allow defining custom jinja2 filters in templates

Allow defining custom jinja2 filters in templates
We now have more jinja2 filters (thanks to @adrianchifor work on #234). However I'd like support for providing a custom python file with more filters, e.g.:
$ kapitan compile --jinja2-filters=lib/jinja2_filters.py

The default behaviour should be for Kapitan not to error should the default jinja2 filters file not exist.
Should it exist, Kapitan will first import those filters into jinja2's internal env settings.
(A better default file name other than one in the example should be discussed)

Hey @ramaro , I am planning to work on this issue. The execution plan can be to use importlib to dynamically import the custom filter module specified by user and then define one more function "load_jinja2_filters_from_file" to import the functions and suppy them in env. We can extract the name for function but then the exposed name of filter will be same as the original name.


Core Typography - cds-text="truncate" is cutting letter descenders.

Describe the bug
The "truncate" transform cut too much. It should only cut horizontal overflow and add ellipsis.
How to reproduce
Steps to reproduce the behavior:

Go to https://clarity.design/storybook/core/iframe.html?id=foundation-typography--page&viewMode=story#transforms
Observe "Text Truncation (truncate): The quick brown fox jumps over the lazy dog."
Verify that letters that have descenders (like these: qjpyg) get cut, as in this screenshot:

Expected behavior
Letter descenders are intact
Versions
Clarity project:

[x] Clarity Core
[ ] Clarity Angular/UI

Clarity version:

[ ] v3.x
[ ] v4.x
[x] v5.x

Research notes:

Trying to set overflow only to X axis won't work, because due to browser implementations of the W3C specs, when one of the axis has overflow different from "visible", the other evaluates to overflow: auto, no matter what is actually written in the CSS. So we can't have hidden on one axis and visible on the other.
The line gets line-height: 20px from the [cds-text*='body'] definition, from this property:

  --cds-global-typography-body-line-height: 1.2rem;

CC @mathisscott, I'd appreciate some comment in which direction we should look for a solution. The body line-height looks a bit suspicious to me, but I have no knowledge about the reasoning behind it.

@Jinnie
You should look into disabling the line height erasers when cds-text is set to truncate


inf = 0

When the subtitle to an application has the phrase 'inf' or any word containing 'inf' will be replaced with a zero.

Expectation: 'information'
Reality: '0ormation'

repost oops


Line number is 0 in dict returned from getbufinfo()

Describe the bug
getbufinfo() returns buffer information as dict and it includes lnum key which indicates current line number. getbufinfo() incorrectly returns 0 for lnum when current buffer is not the buffer.
To Reproduce
Detailed steps to reproduce the behavior:

Run vim --clean
:new (it opens 2 buffers: bufnr=1, bufnr=2)
:new again (it opens 1 buffer: bufnr=3)
:echo getbufnr(2)[0].lnum

Expected behavior
It echoes 1
Screenshots

It echoes 0
Environment (please complete the following information):

Vim version: 8.2.2646
OS: macOS 10.15
Terminal: iTerm2

Additional context
lnum is still 0 even if the buffer (bufnr=2) contains text of multiple lines in the case.
When moving cursor to the window which opens the buffer (bufnr=2), echo getbufinfo(2)[0].lnum echoes 1 as intended.

Duplicate of https://github.com/vim/vim/issues/6612.

See :h getbufinfo():

lnum          Line number used for the buffer when
opened in the current window.

Notice the "when opened in the current window" part.

closing then

Oh, thank you for the point. I didn't notice that. So the value is useless when it is not opened in the window...

@rhysd If your Vim includes the patch 8.2.1727, and if your buffer is currently displayed in a window, you can get the address of the line where the cursor was the last time that window was active, by passing its window number or window ID as an argument to getcurpos():
:echo getcurpos(2)[1]

And if your Vim includes the patch 8.1.1967, you can get the same information with line():
:echo line('.', win_getid(2))

I think this is a common mistake.  Maybe we should improve the documentation:
diff --git a/runtime/doc/eval.txt b/runtime/doc/eval.txt
index 86df7b570..6d3aac7e9 100644
--- a/runtime/doc/eval.txt
+++ b/runtime/doc/eval.txt
@@ -5097,8 +5097,16 @@ getbufinfo([{dict}])
 					last used.
 					{only with the |+viminfo| feature}
 			listed		TRUE if the buffer is listed.
+
 			lnum		Line number used for the buffer when
 					opened in the current window.
+					NOTE: Only useful if the buffer has
+					been displayed in the window in the
+					past.  If you want the line number
+					of the last known cursor position in
+					a given window, use |line()|: >
+						:echo line('.', {winid})
+<
 			linecount	Number of lines in the buffer (only
 					valid when loaded)
 			loaded		TRUE if the buffer is loaded.

Yes, I could use line() instead. One trouble for me was that I needed to use different functions for supporting both Vim and Neovim since Neovim does not support the second parameter of line(). But it is not an issue of Vim.


Build: Centralises binary naming convensions (build changes part 2)

Delivers binary name, paths and download URL
from lib/extensions.js.
Allows user to set binary name as environment
variable with SASS_BINARY_NAME.

This name will be used to construct the:

Binary path.
Binary download URL.
Upload URL.

Note: this will supersede default name.

Allows user to set binary name as parameter to
invoke any node-sass script with
--binary-name flag.

This name will be used to construct the:

Binary path.
Binary download URL.
Upload URL.

Note: this will supersede both default name
as well as the SASS_BINARY_NAME environment
variable.

Allows user to set binary path as environment
variable with SASS_BINARY_PATH.

This name will be used when:

Requiring node-sass package.
Downloading binary.
Uploading binary.

Note: this will supersede default path.

Allows user to set binary path as parameter to
invoke any node-sass script with
--binary-path flag.

This name will be used when:

Requiring node-sass package.
Downloading binary.
Uploading binary.

Note: this will supersede both default path
as well as the SASS_BINARY_PATH environment
variable.

Wraps all extensions in process.sass
namespace.

Issue URL: #712.
//cc @nschonni, @xzyfer

@am11 what do you think about using a nodeSassConfig config element inside the package.json instead of the environment variables? EX: http://jshint.com/docs/

@nschonni, I think it is a neat idea. Environment variables are bit over for this kind of a thing. But should we keep them anyway?
Precedence order (example):

Process arguments --binary-path ...
"nodeSassConfig": { "binary-path": ".." }.
Environment variable SASS_BINARY_NAME.

This way we will still not be the only (crazy) ones giving so many options, because we have node-jscs package for that! :wink:  (they have like 50 ways to provide settings)

@nschonni, I have added the support for nodeSassConfig.binaryName and nodeSassConfig.binaryPath.
PTAL.


GH-157: Move ContainerTestUtils to s-k-test

Resolves #157
cherry-pick to 1.0.x

Merged as https://github.com/spring-projects/spring-kafka/commit/ad62b09732891797e02447e057bf6de7099b5d66
and cherry-picked.


extending pins in caps

After @srini229 fixed the system dependent issues for the P&R, there are a few opens for SCF test case.
@Lastdayends  Could you please help to debug the issues?

@arvuce22
Will look into it.

@arvuce22
Sorry for the late reply.
It seems there is no open in my end.

@Yaguang Li @.***> It seems the open issues are resolved now.
However, there are min length DRCs for the M1 and M3 layers (the nets drawn
by router) for the SCF. Could you please check these?
Thanks!
On Tue, Nov 23, 2021 at 10:12 PM Yaguang Li @.***>
wrote:

@arvuce22 https://github.com/arvuce22
Sorry for the late reply.
It seems there is no open in my end.
[image: image]
https://user-images.githubusercontent.com/43042278/143173651-ecfbde83-ce85-4dbb-9b74-a8556bf56840.png
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/ALIGN-analoglayout/ALIGN-public/pull/830#issuecomment-977517252,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AKTUJYPHTQJOFQ3NURXSXUTUNRQ2RANCNFSM5GS75GQA
.
Triage notifications on the go with GitHub Mobile for iOS
https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675
or Android
https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.

@arvuce22
Sure. Will look into those errors.

@arvuce22
Did you change the format of unit cap (for common centroid capacitor placement & routing) as well?
In the common centroid capacitor placement & routing, the unit cap should follows such format:

The router will always connect the lower left point of the unit cap, and put an m1 via here. Since you extend the pin, there is no M1 metal at lower left point of the unit cap.
Could you revert the change for unit cap? Or adding a m1 under the lower left point of the unit cap?

@Lastdayends It seems fine now. Can you check "adder" and "switch cap" test cases using this branch on your local machine? Please let me know if they work for you. Once verified I will merge this branch.

@arvuce22
Sure. Will do.

@arvuce22
There are still opens.

@Lastdayends I have changed the blockages as we discussed. Please let me know if anything needs to be modified.

@arvuce22
From my view, the blockage is ok. Looking into why failing to find some pathes.

@arvuce22
I find the problem. To connect the pins, a via is needed. However, push a via at the pins is not allow due to the end-to-end space. Can we shrink one more track for the blockage?

@Lastdayends I tried shrinking one more track for the blockage, however, it was resulting in shorts.
you can also change the blockages in the following file (line number 119 to 122) and try running these test cases:
https://github.com/ALIGN-analoglayout/ALIGN-public/blob/bug/cap_pin/align/primitive/default/cap.py
Currently (x=0 and y= 1) in this file as shown below (line number 119 to 122)
self.addRegion( self.Cboundary, 'Cboundary',
x, y,
last_x1_track-x,
last_y1_track-y)
To reduce the size of blockage, replace x and y with higher values (for example, x=1 and y=2 or x=4 and y=4, etc.).
Please let me know if you have any questions.

@arvuce22
Now the problem is gone. I made changes as below:

change back the blockage.
extend the cap pin.
extend the coverage metal of via inside common centroid capacitor.

@arvuce22
I have check the adder and switched capacitor filter cases. They are good now.

@Lastdayends That's great! Could you please review/approve this branch and merge in master?
Thanks!


implement doc comments for enum value

Added DocComments to EnumValue. Read through this issue https://github.com/NeVeSpl/NTypewriter/issues/83 and realized that extending symbol base was not desired. But did not see a immediate reason that DocComments couldn't be added.

Not sure what caused the deploy action to fail. Ill try to research it.

Do not worry about that, it is about deploying Blazor version to the server, which should not be done for PRs anyway.
I will review this PR in the next week.


Updating build to https://jenkins.mono-project.com/job/test-mono-mainline-wasm/4749

@anurse whenever you have a bit, could you look at why the auto-merge bot isn't working in this repo?


Better (I guess)

hello, i saw this repo and liked it so i kinda made it better by adding an intro and other cool stuff... go cheak it out here >> https://github.com/CPScript/Video-Downloader

yeah... i took it down bc i dont wanna have copyright law enforcers attack me... i also gave up on editing it, would take to long


No support for python3? I am getting: invalid syntax: raise ValueError, "No frame marked with %s." % fname

File "/home/user/hosting/cookiecutter/lib/python3.6/site-packages/environ.py", line 114
raise ValueError, "No frame marked with %s." % fname
^
SyntaxError: invalid syntax
Edited by maintainer:
A possible solution is:
https://github.com/cookiecutter/cookiecutter-django/issues/2106#issuecomment-553089821

Anyone solve this?  Same error for me

@travelspun if your error is the same, please, open a new issue in the django-environ ( https://github.com/joke2k/django-environ )describe how to reproduce the error.

For me the issue was that I installed the environ package instead of the django-environ package.

Same here @tiborsimon

any update for this error ?

same, year 2020

For me the issue was that I installed the environ package instead of the django-environ package.

solved

django-environ

This worked for me.

For me the issue was that I installed the environ package instead of the django-environ package.

Thank you! This solved my issue :)

For me the issue was that I installed the environ package instead of the django-environ package.

This worked for me as well! I was looking at my django project as a template but actually needed
from dotenv import load_dotenv
load_dotenv()

Instead of
import env

For me the issue was that I installed the environ package instead of the django-environ package.

thanks, I also solve my error through this term

i got same error please give me correct reply. thanks in advance

For me the issue was that I installed the environ package instead of the django-environ package.

Thaks, solved for me...

same, year  2021

@kilicheva the same what? Same error? Same solution? Commenting with no information on a closed issue is not gone help anyone.

Same error when use it with Python 3.8.5

@mathpadam and the solution posted in https://github.com/cookiecutter/cookiecutter-django/issues/2106#issuecomment-553089821 did not resolve it?

@foarsitter people just install your dependencies one at a time in their environment. So if they typo any of the dependencies in their requirements.txt or environment.yml or whatever they have this problem. It's a know issue with pip. Hackers use it to get ususpecting users to install malicious packages.  Only think you can do about it is have a very unique and easy to spell/remember package name and contact any other package maintainers that squat near your name.

For me the issue was that I installed the environ package instead of the django-environ package.

Worked for me perfectly.  Sometimes youre just in a groove throwing elbows with pip installs and you forget

Same here 2022

Solved: issue was that I installed the environ package instead of the django-environ package. (Ubuntu 20.04)

Installed django-environ instead of environ and still get the same error...

@GoudekettingRM I get the same. Did you find why?

Installed django-environ instead of environ and still get the same error...

same here


feat: add Validating/Mutating webhook analyzer

Closes #533
📑 Description
Changes made:

Added an analyzer for Validating Webhook that checks if the pod that webhook points to is not active.
Added an analyzer for Mutating Webhook that checks if the pod that webhook points to is not active.

✅ Checks

[x] My pull request adheres to the code style of this project
[x] My code requires changes to the documentation
[ ] I have updated the documentation as required
[ ] All the tests have passed

Additional Information

@rakshitgondwal would be nice to share what openai's response is as well based on the error messages you feed it

@rakshitgondwal would be nice to share what openai's response is as well based on the error messages you feed it

I also left a few comments, thanks for your contribution !

Sorry, but I can't see your comments, can you please re check?

Thank you for the merge!

As per here, use the service-name the webhook is bound too and check if the service has pods that are active ( at least 1 )
that should be the real logic

I was trying out this logic, but it is not working. I added a LabelSelector while getting the pods to be service.name, then looped on the pods and check if they are running. Can you help me out with this? @AlexsJones
svc := webhook.ClientConfig.Service
pods, err := a.Client.GetClient().CoreV1().Pods(a.Namespace).List(context.Background(), v1.ListOptions{LabelSelector: svc.Name})
	if err != nil {
		return nil, err
	}
	activePods := 0
	for _, pod := range pods.Items {
		if pod.Status.Phase == "Running" {
			activePods++
		}
	}
	if activePods == 0 {
		doc := apiDoc.GetApiDocV2("spec.webhook")
		failures = append(failures, common.Failure{

I can take a look at implementing it a version of this and seeing whats wrong later today


[CELEBORN-1473] TransportClientFactory should register netty memory metric with source for shared pooled ByteBuf allocator

What changes were proposed in this pull request?
TransportClientFactory registers netty memory metric with source of TransportContext for shared pooled ByteBuf allocator.
Follow up #2585.
Why are the changes needed?
The default value of celeborn.network.memory.allocator.share is true, which means that enables shared memory allocator at default. Therefore, TransportClientFactory should register NettyMemoryMetric with source of TransportContext for netty memory metrics of shared pooled memory.

Does this PR introduce any user-facing change?
No.
How was this patch tested?
No.

Ping @zwangsheng.

@zwangsheng, I have updated description of pull request with netty memory metrics. PTAL.

Ping @RexXiong, @FMX.

when celeborn.network.memory.allocator.share is true. The sharedPooledByteBufAllocator is already register workerSource, so we don't need re-register? Correct me if I am wrong.

@RexXiong, the sharedPooledByteBufAllocator only registers workerSource for TransportServerand does not register any source for TransportClientFactory.


Add support for creating cred-defs that contain a subset of a schema's attributes

It is possible, with the indy-sdk at least, to create a cred-def with a subset of a referenced schema's attributes, example below.  This makes the use of shared schemas cleaner for use cases when a schema contains additional attributes that are of no interest to one jurisdiction but are of interest to another.  It also allows for additional use cases where different use case specific cred-defs can be generated from a single schema.
This (indy-sdk) api makes it possible:

https://github.com/hyperledger/indy-sdk/blob/main/wrappers/python/indy/anoncreds.py#L78

aca-py, currently, makes the assumption the attributes of a cred-def must be the same as the referenced schema both during cred-def generation and credential issuance:

https://github.com/hyperledger/aries-cloudagent-python/blob/main/aries_cloudagent/ledger/base.py#L490
https://github.com/hyperledger/aries-cloudagent-python/blob/main/aries_cloudagent/indy/sdk/issuer.py#L184

Example cred-def containing a sub-set of a schema's attributes.  Note parent_1_full_name and parent_2_full_name are not included in the cred-def.

... to create a cred-def with a subset of a referenced schema's attributes

@swcurran  does the new anoncreds spec take this into account?

While it may be possible, I don't believe the indy-sdk referenced feature is intended to be used to do what is described in the issue description. Technically, you can do it -- change the schema_json item after retrieving the schema and before creating the CredDef. However, it is not expected by anyone in the ecosystem and it is not clear how later interactions would work.
We have talked about this in some Aries Working Group and AnonCreds Specification calls in another similar context. Notably, if we were to switch to using BBS+ Signatures in AnonCreds (replacing CL-Signatures), there is no technical need for either a Schema or a CredDef as there is only one key involved -- a simple DID would suffice. The issuer could just sign some number of claims, perhaps even different on every credential. The problem with that (and to lesser extent with what is proposed in this issue) is that by making the credentials more dynamic, it is harder to write code to handle all possible scenarios and it is harder to drive "standards" for credentials.  We have had general agreement on those calls that keeping both the Schema and the CredDef is a good idea.  An example of this added complexity is the following.  If this feature were implemented, and a proof request came in asking for 4 claims from the Schema, but the holder has been issued a credential rooted on a CredDef that has only 3 of those claims, would the wallet be able to find the credential to construct the proof? Is the proof satisfied if the holder supplies only the 3 values, and (presumably) sends an "unrevealed" for the 4th item?
If we do want to support this, it must be done across all Aries Frameworks -- not just ACA-Py.  An Aries Framework created to assume (as I think most do) that a Schema and CredDef will have the same claims may blow up if an ACA-Py issuer issues a credential with a different CredDef/Schema.
While this may be a good approach, IMHO we need to think carefully about the ramifications.

2 questions for Aca-py then:

Do we want to allow Cred Defs to be created with a sub-set of Schema attributes?  Sounds like we're leaning towards No?
Do we need to build in support for or checks against Cred Defs/Credentials that are created with a sub-set of Schema attributes?  If it's "possible" then someone might do it ...

My leaning is no, but I don't represent the whole community.  It should be raised at the community level if people want to do this.
This is the first time I've heard of someone contemplating this so don't know if it is urgent to block in ACA-Py.  I suspect things just wouldn't work for the participants-- e.g. holders/verifiers would get unexpected errors. But that is only a guess and either code analysis or experimentation would be need to know for sure.

Is there a controller Admin API endpoint for creating a CredDef that allows the user to alter the Schema JSON?

This is also the first I've heard of this capability, and I don't know if anyone has ever tried to do this or what the implications would be.  There's no aca-py support for this, we only allow a cred def that fully implements a schema.
I think the new anoncreds spec should either embrace this capability or explicitly forbid it.  Otherwise some other clever individual will figure out that it's possible and then run with it ...  If the anoncreds spec includes this capability then we need to ensure that all the aries frameworks support it.

I will raise it at the AnonCreds Specification call and see what the response is. My guess the group will be against this, but we'll see.

Per the discussion within the AnonCreds Specification Working Group, this is a loop hole and we strongly recommend not using it, as it will greatly complicate the challenges faced by Holders and Verifiers in creating and verifying presentations.
See this comment for a timestamp in the recording of the discussion held by AnonCreds Spec Working Group meeting.


iFrame doesn't resize if the source page is on HTTPS

Hello,
I'm loading an iFrame from an HTTPS server and the iFrame resizer is not working.
I'm activating it like this:
$(document).ready(function () {
    $("#externalIFrame").iFrameResize({ log: true, checkOrigin: false });
});

and the iFrame is defined like this:

On the console, I found this two messages, that I think are relevant:
[iFrameSizer][Host page][iFrame.onload] Sending msg to iframe (externalIFrame:8:false:true:32:false:true:null:offset:null:null:0:false:parent)
Uncaught SecurityError: Blocked a frame with origin "https://bemmaisseguro.com" from accessing a frame with origin "https://www.tacerto.com". Protocols, domains, and ports must match.
Any thoughts?
Thanks!

If you send me a link, I'll have a quick look at it.

Hello David,
Thanks for your reply.
Here's a link for the site: http://dev.tacerto.com/celular
The frame is located in https://qa.bemmaisseguro.com/partner/tacerto/cotacao
.
We have another page that's working perfectly:
http://dev.tacerto.com/telecom.
Thanks a lot for your help.
Regards,
Pedro Maximiano
On Tue, May 19, 2015 at 6:37 PM, David J. Bradshaw<EMAIL_ADDRESS>
wrote:

If you send me a link, I'll have a quick look at it.
—
Reply to this email directly or view it on GitHub
https://github.com/davidjbradshaw/iframe-resizer/issues/204#issuecomment-103609198
.

Had a quick look, that error is with your code before iframe-resizer even runs. (app.min.js).
I don't think this is a bug, in iFrame-resizer. Check you have the second JS page loaded into you search results page. If you do then something else is crashing JS on your page and stopping out scripts running.
If you think it is still a bug, then you'll need to make a simple test case, that doesn't have any other JS in it.

Thanks for your reply, David.
I'll try to talk to the other party.
Regards,
Pedro
On Wed, May 20, 2015 at 11:06 AM, David J. Bradshaw <
<EMAIL_ADDRESS>wrote:

Had a quick look, that error is with your code before iframe-resizer even
runs. (app.min.js).
I don't think this is a bug, in iFrame-resizer. Check you have the second
JS page loaded into you search results page. If you do then something else
is crashing JS on your page and stopping out scripts running.
If you think it is still a bug, then you'll need to make a simple test
case, that doesn't have any other JS in it.
—
Reply to this email directly or view it on GitHub
https://github.com/davidjbradshaw/iframe-resizer/issues/204#issuecomment-103833533
.

Sorry for my pushing this again, but if you look at the console, you'll
clearly see that the iFrameResizer on the iFrame is running and that
there's a security error.
http://puu.sh/hU1eD/cd46163c3f.png
Can you please advise on the log messages, so I can ma sense of it?
Thanks!
On Wed, May 20, 2015 at 11:32 AM, Pedro Maximiano<EMAIL_ADDRESS>
wrote:

Thanks for your reply, David.
I'll try to talk to the other party.
Regards,
Pedro
On Wed, May 20, 2015 at 11:06 AM, David J. Bradshaw <
<EMAIL_ADDRESS>wrote:

Had a quick look, that error is with your code before iframe-resizer even
runs. (app.min.js).
I don't think this is a bug, in iFrame-resizer. Check you have the second
JS page loaded into you search results page. If you do then something else
is crashing JS on your page and stopping out scripts running.
If you think it is still a bug, then you'll need to make a simple test
case, that doesn't have any other JS in it.
—
Reply to this email directly or view it on GitHub
https://github.com/davidjbradshaw/iframe-resizer/issues/204#issuecomment-103833533
.

The error is in app.min.js, I only see iframe-resizer running in the parent
page, not the iframe. You have to include the second JS file into every
page that you load into the iframe, not just the first one.
On Wed, May 20, 2015 at 11:36 AM, Pedro Maximiano<EMAIL_ADDRESS>wrote:

Sorry for my pushing this again, but if you look at the console, you'll
clearly see that the iFrameResizer on the iFrame is running and that
there's a security error.
http://puu.sh/hU1eD/cd46163c3f.png
Can you please advise on the log messages, so I can ma sense of it?
Thanks!
On Wed, May 20, 2015 at 11:32 AM, Pedro Maximiano <
<EMAIL_ADDRESS>
wrote:

Thanks for your reply, David.
I'll try to talk to the other party.
Regards,
Pedro
On Wed, May 20, 2015 at 11:06 AM, David J. Bradshaw <
<EMAIL_ADDRESS>wrote:

Had a quick look, that error is with your code before iframe-resizer
even
runs. (app.min.js).
I don't think this is a bug, in iFrame-resizer. Check you have the
second
JS page loaded into you search results page. If you do then something
else
is crashing JS on your page and stopping out scripts running.
If you think it is still a bug, then you'll need to make a simple test
case, that doesn't have any other JS in it.
—
Reply to this email directly or view it on GitHub
<
https://github.com/davidjbradshaw/iframe-resizer/issues/204#issuecomment-103833533

.

—
Reply to this email directly or view it on GitHub
https://github.com/davidjbradshaw/iframe-resizer/issues/204#issuecomment-103838921
.

--
David J. Bradshaw )'<EMAIL_ADDRESS>

OK, I'll try talk to the other team.
Thanks again.
On Wed, May 20, 2015 at 11:40 AM, David J. Bradshaw <
<EMAIL_ADDRESS>wrote:

The error is in app.min.js, I only see iframe-resizer running in the parent
page, not the iframe. You have to include the second JS file into every
page that you load into the iframe, not just the first one.
On Wed, May 20, 2015 at 11:36 AM, Pedro Maximiano <
<EMAIL_ADDRESS>wrote:

Sorry for my pushing this again, but if you look at the console, you'll
clearly see that the iFrameResizer on the iFrame is running and that
there's a security error.
http://puu.sh/hU1eD/cd46163c3f.png
Can you please advise on the log messages, so I can ma sense of it?
Thanks!
On Wed, May 20, 2015 at 11:32 AM, Pedro Maximiano <
<EMAIL_ADDRESS>
wrote:

Thanks for your reply, David.
I'll try to talk to the other party.
Regards,
Pedro
On Wed, May 20, 2015 at 11:06 AM, David J. Bradshaw <
<EMAIL_ADDRESS>wrote:

Had a quick look, that error is with your code before iframe-resizer
even
runs. (app.min.js).
I don't think this is a bug, in iFrame-resizer. Check you have the
second
JS page loaded into you search results page. If you do then something
else
is crashing JS on your page and stopping out scripts running.
If you think it is still a bug, then you'll need to make a simple test
case, that doesn't have any other JS in it.
—
Reply to this email directly or view it on GitHub
<

https://github.com/davidjbradshaw/iframe-resizer/issues/204#issuecomment-103833533

.

—
Reply to this email directly or view it on GitHub
<
https://github.com/davidjbradshaw/iframe-resizer/issues/204#issuecomment-103838921
.

--
David J. Bradshaw )'<EMAIL_ADDRESS>—
Reply to this email directly or view it on GitHub
https://github.com/davidjbradshaw/iframe-resizer/issues/204#issuecomment-103839523
.


Repeating events rendering problem

Hi, I have this calendar:
BEGIN:VCALENDAR
PRODID:-//Google Inc//Google Calendar 70.9054//EN
VERSION:2.0
CALSCALE:GREGORIAN
METHOD:PUBLISH
X-WR-CALNAME:Calendar 2
X-WR-TIMEZONE:Europe/Bucharest
BEGIN:VTIMEZONE
TZID:Europe/Bucharest
X-LIC-LOCATION:Europe/Bucharest
BEGIN:DAYLIGHT
TZOFFSETFROM:+0200
TZOFFSETTO:+0300
TZNAME:EEST
DTSTART:19700329T030000
RRULE:FREQ=YEARLY;BYMONTH=3;BYDAY=-1SU
END:DAYLIGHT
BEGIN:STANDARD
TZOFFSETFROM:+0300
TZOFFSETTO:+0200
TZNAME:EET
DTSTART:19701025T040000
RRULE:FREQ=YEARLY;BYMONTH=10;BYDAY=-1SU
END:STANDARD
END:VTIMEZONE
BEGIN:VEVENT
DTSTART;TZID=Europe/Bucharest:20160620T063000
DTEND;TZID=Europe/Bucharest:20160620T113000
RRULE:FREQ=DAILY;UNTIL=20160621T205959Z
EXDATE;TZID=Europe/Bucharest:20160620T063000
EXDATE;TZID=Europe/Bucharest:20160621T063000
DTSTAMP:20160901T104339Z
<EMAIL_ADDRESS>CREATED:20160622T153613Z
DESCRIPTION:
LAST-MODIFIED:20160622T154217Z
LOCATION:
SEQUENCE:0
STATUS:CONFIRMED
SUMMARY:
TRANSP:OPAQUE
END:VEVENT
BEGIN:VEVENT
DTSTART;TZID=Europe/Bucharest:20160829T110000
DTEND;TZID=Europe/Bucharest:20160829T163000
RRULE:FREQ=DAILY
DTSTAMP:20160901T104339Z
<EMAIL_ADDRESS>CREATED:20160901T104300Z
DESCRIPTION:
LAST-MODIFIED:20160901T104311Z
LOCATION:
SEQUENCE:1
STATUS:CONFIRMED
SUMMARY:testRScuAD
TRANSP:OPAQUE
END:VEVENT
BEGIN:VEVENT
DTSTART;TZID=Europe/Bucharest:20160901T163000
DTEND;TZID=Europe/Bucharest:20160901T220000
DTSTAMP:20160901T104339Z
<EMAIL_ADDRESS>RECURRENCE-ID;TZID=Europe/Bucharest:20160901T110000
CREATED:20160901T104300Z
DESCRIPTION:
LAST-MODIFIED:20160901T104314Z
LOCATION:
SEQUENCE:2
STATUS:CONFIRMED
SUMMARY:testRScuAD
TRANSP:OPAQUE
END:VEVENT
BEGIN:VEVENT
DTSTART;TZID=Europe/Bucharest:20160903T070000
DTEND;TZID=Europe/Bucharest:20160903T123000
DTSTAMP:20160901T104339Z
<EMAIL_ADDRESS>RECURRENCE-ID;TZID=Europe/Bucharest:20160903T110000
CREATED:20160901T104300Z
DESCRIPTION:
LAST-MODIFIED:20160901T104315Z
LOCATION:
SEQUENCE:2
STATUS:CONFIRMED
SUMMARY:testRScuAD
TRANSP:OPAQUE
END:VEVENT
END:VCALENDAR
GetOccurrences gives two extra occurrences (for the 1st of September and 3rd of September) unlike Google and Outlook that correctly gets the occurrences. So it does not know to EXCEPT the normal occurrences for these two days (mentioned above). It must take into consideration the Recurrence ID and deduce that those two days are exceptions from the recurrence rule. I hope I'm clear enough :)

Are you using the latest version I published 8 hours ago? It fixed a bunch of recurrence bugs.

Yup. The same problem. You imported the calendar I mentioned above? Don't you see the problem? I can also send you a screenshot with the problem if it helps.

No, I'm on mobile at the moment.

Ok, please let me know if you want more details on this. Also, can we have the Remove method for PeriodList? It's useful when removing exceptions, recurrent dates, etc.

Also, can we have the Remove method for PeriodList? It's useful when removing exceptions, recurrent dates, etc.

Oh, hmm. Can you open a separate issue for that? I like keeping my commits/pull requests focused on single issues.

Your ical paste has 4 VEVENTs in it. Reading and understanding each one takes 3-5 minutes. So that means it takes me 20 minutes to read your bug report. That's a low-value use of time when I have many other tickets I could look at.
Could you narrow it down a bit? Which VEVENT instances are misbehaving?

OK, I think I see what's happening.

You have an event that specifies a start (Aug 29 @ 11:00) and an end (16:30) and recurrence rule (Daily). Its UID is<EMAIL_ADDRESS>Sequence = 1
This event is modified (Sequence = 2), specifying a start time of 16:30 and an end of 22:00 for Sept 1. Same UID.
The event is modified again (still Sequence = 2), specifying a start time of 07:00 and end time of 12:30 for Sept 3.

When computing the recurrence set, Outlook and Google Calendar effectively interpret this as excluding the Sept 1 and 3 dates from the initial recurrence set (treating them like EXDATEs) and evaluating the Sept 1 and 3 overrides, almost like they're RDATEs. The way this is done is by combining all the same UIDs together, and pretending they're a single event when computing the recurrence set.
ical.net considers recurrences as being associated with a single VEVENT. Having a Calendar-level function that squashes all component Uids together to consider as an ordered bundle when computing recurrences doesn't exist in the current data model. So that's problem with the data model itself. sigh
There isn't going to be an easy or quick fix, but it should get easier when the type interdependencies are reduced, and the service provider pattern is retired. I'm going to tag this as v3, since it's such a significant undertaking.

I've added a unit test that should be turned on for v3.
I think the API should look something like this:
var calendar = Calendar.LoadFromStream(new StringReader(ical)).First();

var startSearch = DateTime.Parse("2016-08-01T00:00:00");
var endSearch = startSearch.AddDays(45);

var occurrences = calendar.GetOccurrences(string componentUid, DateTime startSearch, DateTime endSearch);

Yes, Rian, you've got the point, thank you!

Eh, the fix is fairly straightforward, actually. Maybe.
public HashSet<Occurrence> GetOccurrences(string uid, DateTime searchStart, DateTime searchEnd)
{
    var events = calendar.Events
        .Where(e => e.Uid.Equals(someId, StringComparison.Ordinal))
        .OrderBy(e => e.Sequence)
        .ThenBy(e => e.DtStamp)
        .ThenBy(e => e.Start);

    var occurrences = events.First().GetOccurrences(startTime, endTime);
    foreach (var e in events.Skip(1))
    {
        var subset = e.GetOccurrences(startTime, endTime);
        //Figure out the dates that overlap
        //Subtract the Occurrences from the initial set where there's overlap, if any
        occurrences.UnionWith(subset);
    }
    return occurrences;
}

I'm sure the devil is in the details.


Automated cherry pick of #6580: hostman: deprecate k8s_cluster_cidr

Cherry pick of #6580 on release/3.2.
#6580: hostman: deprecate k8s_cluster_cidr

Codecov Report

Merging #6581 into release/3.2 will decrease coverage by 0.00%.
The diff coverage is n/a.

@@               Coverage Diff               @@
##           release/3.2    #6581      +/-   ##
===============================================
- Coverage         7.03%    7.03%   -0.01%
===============================================
  Files              650      650
  Lines           111812   111812
===============================================
- Hits              7869     7867       -2
- Misses          103334   103335       +1
- Partials           609      610       +1

Flag
Coverage Δ

#aFlag
7.03% <ø> (-0.01%)
:arrow_down:

Impacted Files
Coverage Δ

pkg/appsrv/response.go
66.17% <0.00%> (-2.95%)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 383ead3...033e855. Read the comment docs.


Documentation update and cleanup

updated documentation
POM cleanup
added integration test build to travis
removed obsolete launch configurations
integration test cleanup
minor refactoring
updated snapshot version number

Type of request

[ ] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)
[x] Refactoring
[x] Documentation or documentation changes

Related Issue(s)

Concept

Description of the change

Description of current state
Description of target state
Estimated investment / approximate investment

Initiator
Matthias Pfisterer
Technical information
Platform / target area

known side-effects
other
DB Changes (if so: incl. scripts with definitions and testdata)
How has this Tested?

Screenshots, Uploads, other documents (if appropriate):

Checklist:

[x] All the commits are signed.
[x] My code follows the code style of this project.
[x] I agree with die CLA.
[x] I have read the CONTRIBUTING docs.
[x] I have added/updated necessary documentation (if appropriate).

Once this PR is merged, also #10 can finally be closed, since now integration tests are also executed in the travis build.


Update to Angular 6

Hi
This is a great template.
I tried updating it to use Angular 6 with no success. Is this something that you can provide for us?
Thanks
Damien

@damogallagher @lgadola I am reworking this template (sorry with fulltime jobs it's hard to devote time here). But I have simplified this template significantly and should make versioning on both SPFx side and Angular side a lot easier. Stay tuned, it's coming soon!


💡[FEATURE] Adding favicon

Description
I want to add favicon to this website.
I am GSSOC'24 Contributor
I want to work on this issue.
Please assign me this task.
Screenshots
No response
Checklist

[X] I have checked the existing issues.
[X] I have read the Contributing Guidelines
[X] I have read the Code Of Conduct
[X] The changes don't break the code

@harinisayani its already have that feature


[BUG] Page Migrate from Express.js - /getting-started/migrate-from-express

Related page: https://tsed.io/getting-started/migrate-from-express.html
Related source doc: https://github.com/tsedio/tsed/edit/production/docs/getting-started/migrate-from-express.md
Looks like there's a small mistake in the initial yarn installation commands.
The second line including express and all the @tsed dependencies has the -D flag set for dev dependencies
currently it's
yarn add -D express@4 @tsed/core @tsed/di @tsed/common @tsed/schema @tsed/json-mapper @tsed/exceptions @tsed/platform-express

but should probably be
yarn add express@4 @tsed/core @tsed/di @tsed/common @tsed/schema @tsed/json-mapper @tsed/exceptions @tsed/platform-express

The npm tabs look like they are using --save and --save-dev correctly.

@Romakita Can you please assign me?


Security: Encrypt responses or delete responses after certain time.

We no longer storing the form responses anymore and database cleanup in under-process to clean old responses.

Invalid user accounts and all form responses removed.


Add command to easily run refmt in place on all files

Convenient, don't you think?
Maybe there is a quicker way that I am not aware of?
After this PR, I could do another one to actually run this command (minor changes expected, just some newlines at EOF and 2 or 3 files actually with diff). Maybe we could even run this as a precommit hook?

As this PR doesn't break anything I will go ahead and merge it. I think this should be run every time we update bs-platform version.


About Code

hi,As the title , i have read your paper, it's so impressive and i wonder when will the code be published? Thanks for your work again!

uploaded


simplify supporting macros in scala.meta

Let's try to minimize the amount of tricky macros that we have in our codebase. Liftable generators have proven to be especially confusing, so we should probably limit them to just ASTs.

@olafurpg Do you have other suggestions on what would be better to replace with non-macro equivalents without a significant loss of conciseness?

What benefits does the @data macro have over case classes? I don't mind it so much really, but intellij disagrees.

I wonder how much better things would get if we ported the macros to meta macros where possible. As meta macro support far surpasses the old. However intellij still doesn't add new Ref's to its index IIRC

@olafurpg https://github.com/xeno-by/scalameta/blob/master/scalameta/common/src/main/scala/org/scalameta/data/data.scala#L9

I'm totally fine with @data in trees. I've seen @data used for example with
exceptions where it seems a case class would work the same.
On Sat, 11 Feb 2017 at 00:19, Eugene Burmako<EMAIL_ADDRESS>wrote:

@olafurpg https://github.com/olafurpg
https://github.com/xeno-by/scalameta/blob/master/scalameta/common/src/main/scala/org/scalameta/data/data.scala#L9
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/scalameta/scalameta/issues/672#issuecomment-279093163,
or mute the thread
https://github.com/notifications/unsubscribe-auth/ABV8XR2D1Y6fKOjZafpUtLy_LsGlWtMqks5rbPCLgaJpZM4L9cTN
.

Wow, look what I found: https://github.com/scalameta/scalameta/blob/master/notes/macros.md.

I've inlined the aforementioned markdown file into the issue description.

We're on the verge of releasing 2.0, and afterwards we plan to start being really conservative about breaking changes. The matter discussed in the ticket can probably be improved, but there's not enough interest to justify potential breakages.


[BUG] No runnable example for MoE / PR-MoE GPT inference

Hi, currently with several releases on the DeepSpeed branch and the Megatron-DeepSpeed branch, I find it very hard to run those examples provided in the repo due to compatibility issues. And I am also not sure at this moment, what are the compatible branches of DeepSpeed and Megatron-DeepSpeed that come with runnable examples of MoE GPT train/inference.
For example, currently under Megatron-DeepSpeed/examples_deepspeed/MoE, those MoE training scripts actually do not use MoE at all, instead, they just leave the num_experts=1 unchanged.
Also, I am also wondering if there will be any runnable example of the PR-MoE GPT as described in the paper https://arxiv.org/abs/2201.05596.

@YJHMITWEB First of all, as I explained in other issues your created&closed, what you claimed is not true. Under https://github.com/microsoft/Megatron-DeepSpeed/tree/main/examples_deepspeed/MoE, any script with "MoE" in their file names are MoE examples, any script with "PR-MoE" in their file names are PR-MoE examples, any script with "dense" in their file names are non-MoE dense model examples for comparison.
Second, about the separate "No runnable example for MoE / PR-MoE GPT inference" issue mentioned in issue title, I believe your are talking about the issue https://github.com/microsoft/Megatron-DeepSpeed/issues/179 you created before, but in both these two issues you didn't provide any information about what error you hit (after adding back the p2p_communication.py) and how to reproduce it. We need those information in order to debug this.

Hi @conglongli , thanks for the clarification.
In current Megatron-DeepSpeed branch, I took some experiments with ds_pretrain_125M_MoE64.sh without modifying any settings. And I simply hack into /Megatron-DeepSpeed/megatron/model/transformer.py by adding one line print(self.num_experts) at:
        # MLP
        self.num_experts = num_experts
        print(self.num_experts)
        if args.num_experts_switch is not None:
            self.mlp = SwitchMLP(config) # Megatron-LM's MoE
        else:
            if self.num_experts <= 1: # dense, not MoE
                self.mlp = ParallelMLP(config)
            else: # DeepSpeed's MoE
                enable_expert_tensor_parallelism = args.enable_expert_tensor_parallelism
                self.mlp = MoE(args.hidden_size,
                                ParallelMLP(config,
                                    moe=True,
                                    enable_expert_tensor_parallelism=enable_expert_tensor_parallelism),
                                num_experts=self.num_experts,
                                ep_size=args.moe_expert_parallel_size,
                                k=args.topk,
                                use_residual=(args.mlp_type == 'residual'),
                                capacity_factor=args.moe_train_capacity_factor,
                                eval_capacity_factor=args.moe_eval_capacity_factor,
                                min_capacity=args.moe_min_capacity,
                                drop_tokens=args.moe_token_dropping, use_tutel=args.use_tutel,
                                enable_expert_tensor_parallelism=enable_expert_tensor_parallelism)

And I found out the num_experts it actually running with is always 1 as the related parameters are never passed into it.

Did you print all layers' num_experts? Because we only convert every other layer to MoE so there will be half of layers with num_experts = 1 regardless of what you config is set https://github.com/microsoft/Megatron-DeepSpeed/blob/main/megatron/model/transformer.py#L1620-L1627

Yes, I did print all the layers and I do believe that no MoE layers have been really initiated as the num_experts is not passed into the model initialization.

I need to do some investigation but currently I'm busy with other urgent tasks. Will hopefully get back to you early next week.

@YJHMITWEB I just merged a PR https://github.com/microsoft/Megatron-DeepSpeed/pull/192 which fixes this issue (plus other issues related to DeepSpeed MoE training).

Thanks for the effort! @conglongli


Bad input does not cause an error when it should

I have a test coming for this, but for example:
$ go test . -run RandomInput
--- FAIL: Test_RandomInput_Bytes (0.00s)
	unmarshal_input_test.go:69: Expected error unmarshaling as struct:
		as string: "6\x8d\x1e"
		as bytes: [54 141 30]
--- FAIL: Test_RandomInput_String (0.00s)
	unmarshal_input_test.go:69: Expected error unmarshaling as struct:
		as string: "6遆逜x<ɪ+鑴eƹ)嫳钫j蒶X"
		as bytes: [54 233 129 134 233 128 156 120 60 201 170 43 233 145 180 101 198 185 41 229 171 179 233 146 171 106 232 146 182 88]
FAIL

Has fixed the easy cases. The more difficult one is to skip {abc}. Currently, skip does not validate anything between { and }. Will need to write a new implementation of Skip() to do the validation. The old implementation will be enabled by build tags.

I am seeing things like:
--- FAIL: Test_RandomInput_Bytes (0.03s)
	unmarshal_input_test.go:71: Expected error unmarshaling as struct:
		as string: "{K\xf7\xd8\x17Z\x03}"
		as bytes: [123 75 247 216 23 90 3 125]

...which (naively) should fail trying to extract the key name - not skip?  I don't know the internals very well - why is it trying to skip this?

Also, does that mean I should add a case for list parsing?  [ ... ] ?  Any other interesting cases that the parser might distinguish that this test doesn't exercise?

Also, I coded 10K loops, but honestly, being random, we should make that number as large as we think we can tolerate in a go test.

Yes, {abc} or [abc] is a problem. I am working on that.

should be fixed


Can't launch chroot after moving debian to sd card

sudo edit-chroot -m /media/removable/sdcard debian
sudo sh ~/Downloads/crouton -b -p "/media/removable/sdcard/"
sudo enter-chroot
Please paste the output of the following command here: sudo edit-chroot -all
No chroots found in /mnt/stateful_partition/crouton/chroots
Please describe your issue:
I moved my debian to my sd card with the first command, then tried to sudo enter-chroot but it couldn't find the chroot. So I used the second command hoping to rebuild it, it did create a bin folder under my sdcard, but it still couldn't find chroot.
Before moving debian I tried to install a new chroot and changing the sym link of /usr/local/chroots to /media/removable/sdcard/chroots/chroots with sudo ln -s -f /media/removable/sdcard/chroots/chroots, which resulted in the symlinks in /mnt/stateful_partition/crouton/chroots to change to the sdcard destinations as well, chroots to chroots/chroots, bin to chroots/bin. I didn't realize this before moving debian...
If known, describe the steps to reproduce the issue:
T___T what do I do to get my chroots folder back cause it's not anywhere now,,,

@Taylormsz,
Can you show us the output of: ls -l /media/removable/sdcard
I think most likely your entire chroot is now under /media/removable/sdcard/debian/.
If so, since crouton needs both a /chroots/ & /bin/ folder hieracrchy, I would suggest doing the following to move it:
sudo mkdir -p /media/removable/sdcard/chroots/
sudo mv /media/removable/sdcard/debian/ /media/removable/sdcard/chroots/
sudo cp -a /usr/local/bin /media/removable/sdcard/

Hope this helps,
-DennisLfromGA

@DennisLfromGA
Hi Dennis! Thank you so much for the reply!
here's what's in the sdcard directory:
chronos@localhost ~/Downloads/crouton-master $ ls -l /media/removable/sdcard/
total 24
drwxr-xr-x  2 root root  4096 Dec  9 16:39 bin
drwxr-xr-x 21 root root  4096 Oct  2 23:35 debian
drwx------  2 root root 16384 Dec  9 14:21 lost+found
I think I deleted chroots directory from the sdcard after the attempted installation/deletion of the new chroot because I wanted to clear the card for moving my debian over...
Hence this is what's in the debian folder now:
chronos@localhost ~/Downloads/crouton-master $ ls -l /media/removable/sdcard/debian/
total 76
drwxr-xr-x  2 root root 4096 Nov 11 05:59 bin
drwxr-xr-x  2 root root 4096 Jun 26 05:03 boot
drwxr-xr-x  2 root root 4096 Jun 26 05:03 dev
drwxr-xr-x 75 root root 4096 Dec  9 15:56 etc
drwxr-xr-x  3 root root 4096 Jul 21 18:16 home
drwxr-xr-x 12 root root 4096 Jul 21 18:52 lib
drwxr-xr-x  2 root root 4096 Jul 21 18:12 lib64
drwxr-xr-x  2 root root 4096 Dec  9 15:56 media
drwxr-xr-x  2 root root 4096 Jul 21 18:12 mnt
drwxr-xr-x  3 root root 4096 Sep 21 18:33 opt
drwxr-xr-x  2 root root 4096 Jun 26 05:03 proc
drwx------  5 root root 4096 Nov 27 13:11 root
drwxr-xr-x  2 root root 4096 Jul 21 18:15 run
drwxr-xr-x  2 root root 4096 Dec  5 20:08 sbin
drwxr-xr-x  2 root root 4096 Jul 21 18:12 srv
drwxr-xr-x  2 root root 4096 Jun 26 05:03 sys
drwxrwxrwt  2 root root 4096 Jun 26 05:03 tmp
drwxr-xr-x 10 root root 4096 Jul 21 18:12 usr
drwxr-xr-x 12 root root 4096 Jul 21 18:12 var
I tried installing a new chroot on another sd card but I kept running into keyring issues, I did wipe the installation cache and download another copy of crouton but I still don't have the kering folder, all I have is key-debug but I don't know how to fix it...
chronos@localhost ~/Downloads/crouton-master $ ls /usr/share/key
request-key-debug.sh
chronos@localhost ~/Downloads/crouton-master $ ls /usr/share/keyutils/
request-key-debug.sh
If I messed up too bad I am more than willing and happy to start over. I am sorry about the trouble...
T___T

@Taylormsz,
Your external sdcard crouton directories are almost correct. The /bin folder is in the right place but the /chroots folder is missing it seems. To get your debian chroot setup correctly try the following:
sudo mkdir /media/removable/sdcard/chroots
sudo mv /media/removable/sdcard/debian  /media/removable/sdcard/chroots

If that succeeded you should have the following on the sdcard:
/media/removable/sdcard/bin
/media/removable/sdcard/chroots/debian

Of course, the debian folder will have several sub-folders as you show above.
At this point you may be able to do a crouton update to fix your keyring issues, do that with:
sudo sh ~/Downloads/crouton -n debian -p /media/removable/sdcard -u
Hope this helps,
-DennisLfromGA

@DennisLfromGA
OMG it worked like a charm! Thank you so much!! ^___^
Entered chroot with:
sudo sh /media/removable/sdcard/bin/enter-chroot -n debian
Everything runs smoothly now!! Thank you again!!

You're very welcome, glad it's all ironed out.
(closing this issue since it seems to be resolved)


Issue #9

Description
Replace usage of ext.postBuildExtras with usage of cdvPluginPostBuildExtras.
Related Issue
Issue #9
Motivation and Context
This improves inter-compatibility with other Cordova plugins.

Please merge. It solved my issue regarding dependency errors

Google recommends to apply this plugin in the bottom of grade file. That’s why I use postBuildExtras property.
Hopefully the project will be integrated into Cordova-android and this project become deprecated. Read https://github.com/apache/cordova-android/pull/438#discussion_r216195917

@chemerisuk, both ext.postBuildExtras and cdvPluginPostBuildExtras are run at the bottom of the gradle file. See https://github.com/apache/cordova-android/blob/e9750b5cabe70b1fc9abfad28fd1239d9b9415c2/bin/templates/project/app/build.gradle#L316-L324.
As cdvPluginPostBuildExtras is an array, it can be used by many plugins. Each plugin simply adds its gradle code to this array. ext.postBuildExtras is only defined once, so it can only be used by one plugin. For example, if you have a Cordova project with this plugin and
https://github.com/blakgeek/cordova-plugin-flurryanalytics, they both use ext.postBuildExtras (you can see its usage here: https://github.com/blakgeek/cordova-plugin-flurryanalytics/blob/master/src/android/plugin.gradle). Only the last plugin to be added will have its gradle code run in ext.postBuildExtras, so either this plugin or cordova-plugin-flurryanalytics would not work properly.

It seems like https://github.com/apache/cordova-android/pull/438 was not merged into the next cordova-android release. Therefore we have to continue to use this plugin.
Let's merge this PR and include changes into the next minor release.


isWeekend support

now.isWeekend()

How would it work?
Different countries has different weekends. For example in Israel our weekend in Friday (half working day) and Saturday.

oh ic. I have no plan. Any recommend?


osrm-backend: support for mac

Description of changes

Things done

Built on platform(s)

[ ] x86_64-linux
[ ] aarch64-linux
[x] x86_64-darwin
[x] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
23.05 Release Notes (or backporting 22.11 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[ ] Fits CONTRIBUTING.md.

Fixes #224535

@GrahamcOfBorg build soi icesl

@erictapen @SuperSandro2000 Looks like all the checks passed. Is there anything else that we should do before merging this PR to master?

Yes, as you already mentioned the commit messages should be up to the guidelines. Also one commit for the whole thing would be preferable.


fix: Fix of Contexts and Cleanups of pages when using Router

I think this change will break useRouter when the outlet isn't nested within the router.

Ah, I think I get it
Passing the owner to the nested route custom element means we inherit whatever context it had. createRoot uses that owner. It requires manual cleanup, which is also taken care of.
Its interesting that the owner argument isn't officially documented :thinking:  https://docs.solidjs.com/reference/reactive-utilities/create-root

I think this change will break useRouter when the outlet isn't nested within the router. But I see we already have such an example and it seems to work - is it because of createRoot that we preserve the router context too?

IonRoute captures the Owner which is the IonRoute context. Outlet renders the ComponentRef component which restores the IonRoute context so it's like inside Router. But that means I broke this:
export function App() {
  return <IonApp>
    <IonRouter>
      <IonRoute />
    </IonRouter>

    <SomeContext.Provider value={xyz}>
      <IonRouterOutlet />
    </SomeContext.Provider>
  </IonApp>;
}

Well,.. I didn't break it because it never worked 😆, but it still won't work. And I think we cannot fix this. 😞 Maybe we can just mention this in documentation; I don't think it's a big deal.

Its interesting that the owner argument isn't officially documented 🤔

Hmm 🤔, you are right. I didn't see the docs. Interesting. I hope it's a new not yet documented feature rather than deprecated. 🥲

I don't think it's a big deal.

I agree. We do have a working context passing mechanism now, which is good enough.


Fix PotionEffect retrieval error from DataContainer

Fix https://github.com/SpongePowered/SpongeCommon/issues/1276

@gabizou you should do something with this. This is second time i seen that type of errors.

@gabizou you should do something with this. This is second time i seen that type of errors.

I'll give you another chance at rephrasing that statement.

~qa


How can I disable to collapse of root node?

Thanks for your great library.
I need your help.
I want to disable to collapse of the root node.
It means that the root node should be expanded forever.
Is there any way?
Thanks

@dingyi222666
Could you help me?

I don’t have time to develop TreeView recently. I may have to wait a few weeks before I can continue developing.1

Ok. This is a simple question. First, let's expand the root node list when initializing the tree.
treeview.expandUntil(1,true)
// or expandAll
binding.treeview.expandAll(true)

Then you need to implement the TreeViewBinder and override the onToggle method.
The onToggle method run after the default action (like expanding or collapsing a node), so you just need to check if the node is the root node in this method, and then set it to force expand.
override fun onToggle(
            node: TreeNode<DataSource<String>>,
            isExpand: Boolean,
            holder: TreeView.ViewHolder
        ) {
    if (node.depth < 1) {
        node.expand = true
    }
}

Hi, @dingyi222666
It works well, thanks so much.


[Feature Request] Add ./gradlew :plugins:xyz:run

Is your feature request related to a problem? Please describe
Developers want an easy way to run a plugin during development.
Describe the solution you'd like
I'd like to be able to do ./gradlew :plugins:xyz:run when developing an xyz plugin in the plugins folder.
Related component
Build
Describe alternatives you've considered
Currently you can modify gradle/run.gradle as follows.
testClusters {
  runTask {
    testDistribution = 'archive'
    if (numZones > 1) numberOfZones = numZones
    if (numNodes > 1) numberOfNodes = numNodes
    // add plugin(s) to load in ./gradlew run
    plugin(':plugins:xyz') // <-------- add this to load xyz plugin
  }
}

Additional context
Some people might want to load more than one plugin via command line.

@dblock do you think this is related? https://github.com/opensearch-project/OpenSearch/issues/6285

It's the same intent but a different syntax.


Integrate Wrapper for Telemetry Client

The Application Insights telemetry client provides various exception handling and metric tracking abilities.
It would be great to directly integrate them into FuncTown (thereby allowing to track return types, exceptions and various metrics through App Insights)
Design for this has yet to be done

Looks like the Python APIs moved to OpenCensus: https://learn.microsoft.com/en-us/azure/azure-monitor/app/opencensus-python

Basic design: Idea would be to integrate an additional handler
@handle_errors(debug=True, log_all_errors=DEBUG, return_errors=DEBUG)
@metrics(instrumation_key="key", send_basics=True)
def main(req: http.HttpRequest, logger: logging.Logger, **kwargs):
  # ...

  # execute metric
  logger.metric("foobar")

In the case of send_basics the wrapper should automatically send basic logging information around response codes, failures, etc.
Note that the logger object should also be picked up by handle_errors in #9.
Note: There should be a convention from now on to only pass named parameters from decorators (apart from req), so that the main function can be modified to main(req, **kwargs) without ever breaking compatibility


undefined method to_query

Please find the stacktrace
~/.rvm/gems/ruby-2.1.6/bundler/gems/ssllabs.rb-51c13d38d913/lib/ssllabs/api.rb:21:in `request': undefined method `to_query' for {}:Hash (NoMethodError)
~/.rvm/gems/ruby-2.1.6/bundler/gems/ssllabs.rb-51c13d38d913/lib/ssllabs/api.rb:50:in `info'

One possible solution is the params.collect as mentioned in the comments here
http://stackoverflow.com/questions/4014180/exception-with-method-to-query-missing

1.16.x field addition fixes this issue

I'm running into this same issue while attempting to run the example on the README. I'm running Ruby 2.0.0-p598.


Redesign UI to avoid undecorated Godot UI

The UI currently uses Godot's default grey buttons.

We should come up with a more fun, colorful theme.

Ideally something colorful with big thick fun borders and little icons.

[ ] #2438
[ ] #2439
[ ] #2440
[ ] #2441
[ ] #2442
[ ] #2443
[ ] #2444
[ ] #2445

Kenney's UI pack: https://kenney.nl/assets/ui-pack
Instant better UI with Godot 4's Theme Editor: https://www.youtube.com/watch?v=jIk-OG5hG3k (Godot 4)

After exploring different options for the UI, I think rounded rectangles using "StyleBoxFlat" is the best approach.
I tried implementing textured buttons with "StyleBoxTexture". However, Godot 3.x does not support upscaled textures (having a 512x512 px image for a 120x30 px button). Since the game's resolution is currently 1024x600, this means anybody playing the game at fullscreen would see pixellated/blurry textures. This may still work OK if we end up wanting simple gradients, but it doesn't look good for the kinds of textures in the Puyo Puyo screenshot above.
We could also work around any kind of shortcomings in Godot's UI (such as the "upscaled texture" problem) by implementing our own UI nodes, but this is too much work for now and I'd rather use Godot's built in UI nodes.

The built-in "StyleBoxFlat" approach is OK but still does not work if we want icons alongside text, which feels like something pretty basic we'd want. While Godot buttons do support icons and text, sort of, the icon size is arbitrary, and the amount of space between the icon and text is arbitrary too. Getting things to align or look good will require a tremendous effort and possibly involve weird kludges like padding our text or images with whitespace.
A better approach seems to be to implement our own customized Button node which will have child panels, labels and texturerects which can draw however we like. This should also allow us to work around the issues mentioned in the previous comment, as far as not being able to use background textures because there is no way to upscale textures.

The UI now uses colorful buttons throughout the game.


Add support for Debian package build

Fixes https://github.com/MrS0m30n3/youtube-dl-gui/issues/21
Add a desktop launcher (youtube-dl-gui.desktop)
Add Debian package build instructions to README, small wording changes (of -> for)
Resulting .deb package was successfully installed and tested on Debian 9 Stretch (stable)
Building the package requires debhelper and dpkg-dev packages

The resulting package can be found at https://github.com/nodiscc/dropbin/blob/master/youtube-dl-gui_0.4.0_all.deb - testers welcome
The signed .dsc file can be found at https://github.com/nodiscc/dropbin/blob/master/youtube-dl-gui_0.4.0.dsc, signed with GPG key 99883828CD9019B8
The Debian package changelog can be updated with dch -a (see man dch). The email address used in debian/control and debian/changelog must match an email address for which you have a valid GPG private key to correctly sign the package.

@MrS0m30n3 you might want to tag the latest commit as 0.4.0 and then create a new release, attaching the .deb package to the release.
https://github.com/MrS0m30n3/youtube-dl-gui#downloads could also be updated to point to that package. The package should work with any Debian derivative, including Ubuntu (so you'd no longer need to link to the PPA). Again, testers welcome.

I just ran lintian on the Debian package, it reports the following (minor) warnings:
W: youtube-dl-gui: description-synopsis-starts-with-article
W: youtube-dl-gui: binary-without-manpage usr/bin/youtube-dl-gui
W: youtube-dl-gui: desktop-entry-invalid-category Multimedia usr/share/applications/youtube-dl-gui.desktop

I also noticed the absence of wxpython in the package dependencies. As I already had wxpython installed this caused no problem, but it might - I could not test. I should check the previous PPA package to know how they handle it.
Ping @hotice, I think you are the youtube-dl-gui PPA maintainer, would you be interested in centralizing the packaging effort here? If we could make it work on all Debian derivatives this would be great. I could not test the package on Ubuntu but maybe you'd like to help with that?

Just a quick summary:

[ ] Move debian/ -> packaging/
[ ] Perform the changes mentioned in the review
[ ] Add the *.deb under the README.md #downloads section

Thanks for the thorough review :+1: I will take some time to address it in the coming days/weeks

Yeah, sure take your time.
Also this rule could come in handy when you move the debian directory.
override_dh_auto_install:
    cd ../ && python2 setup.py install --root=$(CURDIR)/debian/youtube-dl-gui/ --no-compile -O0 --force

(there are probably better ways to archieve this)

Hi, I addressed most of the review and packaged twodict see https://github.com/MrS0m30n3/twodict/pull/1). About

Move debian/ -> packaging/

I have proposed a solution in https://github.com/MrS0m30n3/twodict/pull/1 (using a separate branch to store debian packaging work - this is the recommended method), let me know if you agree to use the same method here.

I have no problem with keeping the debian directory in the main dir as long as we use a different branch.


Feature/edges bid interface

Update bid webfield template to use edges.

Why do you have all these changes here? You should have a single commit that is the merge of master....

I don't know why! I think it must be because I branched off of feature/edges. Have any suggestions on how to fix it?

feature/edges is up to date with master: https://github.com/iesl/openreview-py/compare/feature/edges?expand=1
I tried to update this branch with feature/edges but it didn't change anything

Doing a comparison between these 2 branches doesn't show all the commits:  https://github.com/iesl/openreview-py/compare/feature/edges...feature/edges-bid-interface
may be you need to close the PR and create it again?

Oh I didn't realize you were updating feature/edges. I did the same for my branch thinking that David wanted to keep that as-is.

I updated feature/edges a few minutes ago.
Why would David want to keep it as it is? It should be always up-to-date with master.

He told me that his openreview-matcher tests all used an old version of the builder and they would break if he updated feature/edges with the latest code from master. @marshall62 correct me if I'm wrong.


docs: create API reference section

We need to move the api reference docs from "Architecture" to a new section API Reference. When I tried to do that it didn't work. @ccamel can you take care of it?
Things to be moved:

The issue has been addressed by PR #582, so I believe we can close it.
@AnjaMis, please confirm.

yes!


Version calculator page

Would be nice to support something similar to http://semver.npmjs.com/
@DamianEdwards cool suggestion

I like the idea, and I think it would be really cool to be able to click
the versions that I want to include and get the semver notation for that
collection.
Jeff
On Thu, Apr 2, 2015 at 2:38 PM, Yishai Galatzer<EMAIL_ADDRESS>wrote:

Would be nice to support something similar to http://semver.npmjs.com/
@DamianEdwards https://github.com/DamianEdwards cool suggestion
—
Reply to this email directly or view it on GitHub
https://github.com/NuGet/NuGetGallery/issues/2393.

Also http://semver.mwl.be/#?package=madewithlove%2Felasticsearcher&version=^0.1.1

there was no interest from users over the last 3 years. Closing.


cast call jsonrpc request with params.length=3 rejected by Nethermind

Component
Cast
Have you ensured that all of these are up to date?

[X] Foundry
[X] Foundryup

What version of Foundry are you on?
forge 0.2.0 (467aff3 2024-05-17T00:18:15.145320552Z)
What command(s) is the bug in?
cast call
Operating System
Linux
Describe the bug
cast call generates a JSON-RPC request with params array of 3 elements (the 3rd is an empty state-override set). Nethermind expects only 2 elements and rejects the request.
For example:
WETH=0xC02aaA39b223FE8D0A0e5C4F27eAD9083C756Cc2
AAVE_WETH=0x4d5F47FA6A74757f35C14fD3a6Ef8E3C9BC514E8
cast call $WETH "balanceOf(address)(uint256)" $AAVE_WETH

Some Ethereum node implementations (such as Alchemy) handle this request correctly.
Nethermind logs an error:
Error when handling Id:1, eth_call([{"from":"0x0000000000000000000000000000000000000000","to":"0xc02aaa39b223fe8d0a0e5c4f27ead9083c756cc2","value":"0x0","input":"0x70a082310000000000000000000000004d5f47fa6a74757f35c14fd3a6ef8e3c9bc514e8"},"latest",{}]) | {
  "jsonrpc": "2.0",
  "error": {
    "code": -32602,
    "message": "Invalid params",
    "data": "Incorrect parameters count, expected: 2, actual: 3"
  },
  "id": 1
}

The request params includes a 3rd parameter {} that some Ethereum clients accept as a "state override set".
One possibility is to omit the 3rd parameter when the state override set is empty, to retain compatibility with the reference Ethereum JSON-RPC Spec in the common case of no overrides.
Observed with:

cast 0.2.0 (467aff3 2024-05-17T00:18:15.145580559Z)
Nethermind 1.26.0

Fixed in the next nightly


chore: make (x : M) implicit in extChartAt_image_nhd_mem_nhds_of_boundaryless

Fixes an oversight in #10001: x is already included in the hypothesis hx, so should be implicit.
A follow-up PR will address this issue more systematically.

Thanks!
bors merge