No  Arm64 images Docker

Description
When installing docker install the entry for Arm64 is removed.
Steps to Reproduce the Bug
Run docker compose --profile streamlit up
will show
no matching manifest for linux/arm64/v8 in the manifest list entries
Expected Behavior
Supposed to install from pull arm64 build on docker
Actual Behavior
no matching manifest for linux/arm64/v8 in the manifest list entries

Additional Context / Screenshots

Operating System

[ ] Microsoft Windows
[ ] Apple MacOS
[X] Linux
[ ] Android
[ ] iOS
[ ] Other

Python Version

[ ] Python <= 3.9
[X] Python 3.10
[ ] Python 3.11

Environment Type - Connection

[ ] Local
[X] Remote

Environment Type - Container

[X] Using Docker
[ ] Not Using Docker

Acknowledgements

[X] My issue title is concise, descriptive, and in title casing.
[X] I have searched the existing issues to make sure this bug has not been reported yet.
[X] I am using the latest version of AGiXT.
[X] I have provided enough information for the maintainers to reproduce and diagnose the issue.

All you gotta do is just uncomment this line

@Josh-XT @localagi

@greengeckowizard yes, we experienced further issues. Currently, also on local install, it installs due to our declared version for pytorch is not available on arm.
So the Q is at @Josh-XT - which torch version should we use? 1.13.1 seems avail on arm64. Non-cpu 2.0.1 probably also - will it work? is it worth a try?

https://github.com/Josh-XT/AGiXT/blob/707afda53bf618d0fa9cb5335ba08e0eaf9f4817/pyproject.toml#L93
https://github.com/Josh-XT/AGiXT/blob/707afda53bf618d0fa9cb5335ba08e0eaf9f4817/pyproject.toml#L77

Dendencies using it
https://github.com/Josh-XT/AGiXT/blob/707afda53bf618d0fa9cb5335ba08e0eaf9f4817/poetry.lock#LL5108C1-L5108C1
https://github.com/Josh-XT/AGiXT/blob/707afda53bf618d0fa9cb5335ba08e0eaf9f4817/poetry.lock#L4546
https://github.com/Josh-XT/AGiXT/blob/707afda53bf618d0fa9cb5335ba08e0eaf9f4817/poetry.lock#L19

@greengeckowizard yes, we experienced further issues. Currently, also on local install, it installs due to our declared version for pytorch is not available on arm.
So the Q is at @Josh-XT - which torch version should we use? 1.13.1 seems avail on arm64. Non-cpu 2.0.1 probably also - will it work? is it worth a try?

I'm not sure, I don't directly use torch.  It is used by sentence-transformers which is used by ChromaDB for our default embedding models.

@greengeckowizard Please check the latest builds if they work for you

@greengeckowizard Please check the latest builds if they work for you

Sure I can give it a quick test but rn I see the docker status is failing idk if that will do anything.

@greengeckowizard Please check the latest builds if they work for you

Awesome just tested and it works although the docker failing we'll have to look into in the github page thanks for your work!! I can now close this issue.  @localagi


acceleration and deceleration

Hi,
I would love to slowly accelerate and deceleration the motor to a precise angle.
I get it to to accelerate, but I cant figure out how to slow down the motor at the end of the command. I can only call another degree command and the motor will transition from one to the other speed.
I can find the following in your documentation* but its unlcear what the meaning is:
0x0000000? | Acc.- profile
0x000000?0 | Decc.- profile
*3.27.9. Output Sub Command - StartSpeedForDegrees(Degrees, Speed, MaxPower, EndState, UseProfile) [0x0B]
Here is the command I send:
0x0D, 0x00, 0x81, port, 0x11, 0x0B, motorbytes[0],motorbytes[1],motorbytes[2],motorbytes[3], speed, 100, 127, 0x00000021]);
I was playing around with the last byte wondering if I can figure out what the meaning of the two question marks are.

Here is the command I send:
0x0D, 0x00, 0x81, port, 0x11, 0x0B, motorbytes[0],motorbytes[1],motorbytes[2],motorbytes[3], speed, 100, 127, 0x00000021]);

I believe the profile is a byte where bit flags are used for profiles.
As such, the following would apply:

0b00000000 No profile
0b00000001 Accelerate
0b00000010 Decelerate
0b00000011 Both

Also, make sure you have configured the profiles for:

Acceleration: https://lego.github.io/lego-ble-wireless-protocol-docs/index.html#output-sub-command-setacctime-time-profileno-0x05
Deceleration: https://lego.github.io/lego-ble-wireless-protocol-docs/index.html#output-sub-command-setdectime-time-profileno-0x06

I have set both profiles and I also applied the flags. One thing thats confusing there is
ProfileNo [Int8]: [0..MAX_PROFILES]
If I change profile to anything else than 0x01 for acceleration. The motor behaves unexpected.
The deceleration profile seems to have absolutely no impact.

anymore hints? Acceleration is working, deceleration is not working. I there anyone else who got this working?

Have you tried 0b00000010 for the Profile # when setting Deceleration?
I suspect the internal function being used is the same for both
acceleration and deceleration. More of a generic, set time for profile
where profile # is the flag of the profile to configure.
Best,
John
On Mon, Apr 27, 2020, 09:59 valentinptc<EMAIL_ADDRESS>wrote:

anymore hints? Acceleration is working, deceleration is not working. I
there anyone else who got this working?
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/LEGO/lego-ble-wireless-protocol-docs/issues/23#issuecomment-620004624,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/ABKLBOTF23M7AJNTDSI44D3ROWFUVANCNFSM4MPUR2RQ
.

I did, yes. Actually I tried every possible combination. The documentation could win a lot if there could be one or two more paragraphs to explain the exact relationship between the bitmask and the profiles. At this point however I believe there is a bug in the firmware.

When I have more time I will set up a motor on my C# SDK and experiment
with the profiles myself. I suspect there is something missing from the
docs but will let you know if I uncover anything.
On Mon, Apr 27, 2020, 10:10 valentinptc<EMAIL_ADDRESS>wrote:

I did, yes. Actually I tried every possible combination. The documentation
could win a lot if there could be one or two more paragraphs to explain the
exact relationship between the bitmask and the profiles. At this point
however I believe there is a bug in the firmware.
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/LEGO/lego-ble-wireless-protocol-docs/issues/23#issuecomment-620012180,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/ABKLBORZFAZV2RVOPU3ZDITROWG6PANCNFSM4MPUR2RQ
.

Thank you!

For me it worked:
I called SetAccTime and SetDecTime for profile 0, note that the millis is a 16 bit value where the first byte is the low byte (little-endian), then I called StartSpeedForTime with profile = 3 (0b0011).
I used accTime = 1000, decTime = 1000 and  a time > 2000 for StartSpeedForTime.


Button state doesn't change on change in v-model programatically

example :
<template>
    <toggle-button
       v-model="state"
       :labels="{checked: 'High', unchecked: 'Low'}"
     />
     <v-btn v-on:click="reset()">Reset</v-btn>
</template>
<script>
  export default {
    data () {
        return {
            state: false
        }
    },
    methods: {
        reset () {
            this.state = false
        }
    }
  }
</script>

When I toggle the button, state is set to true.
When I click on reset button the value of state changes to false but the Toggle Button doesn't show the change.

Hey @ahmedfouzan, Try setting:sync="true". Thanks.

That worked. Thanks @euvl

I just spent three hours trying to figure this out. This so needs to be in the docs. I'll send a pull request.


Can not select option when load data by using ajax

I want to select a Book -> book_id to a Chapter. I don"t want to use below solution because there are many books up to thousand books in my system and this combo box always choose an option as default, I don't want it, look below:
$form->select("book_id", "Choose a book")->options(BookInfo::all()->pluck("title", "book_id"));
So, I choose to load data by using ajax. Following with document, my code show after:
ChapterInfoController
protected function form() {
        return Admin::form(ChapterInfo::class, function (Form $form) {
            ......

            $form->select("book_id", "Choose a book")->options(function ($book_id) {
                $book = BookInfo::find($book_id);

                if ($book) {
                    return [$book->book_id => $book->title];
                }
            })->ajax("/admin/api/books");

            ......
        });
    }

routes.php
$router->get("api/books", "BooksApiController@books");
BooksApiController
class BooksApiController extends Controller{
    public function books(Request $request){
        $q = $request->get("q");
        return BookInfo::where("title", "like", "%".$q."%")->paginate(null, ["book_id", "title as text"]);
    }
}

Every thing looks fine, when I type any character, server response a list of Books below the input text
BUT, I CAN NOT SELECT AN OPTION --> please help me.
++++++++++++++++++++++++++++++++++++++++++++++++
In the other hand, I can using the solution below and HOW TO SET BLANK VALUE FOR DEFAULT WITH RULES METHOD
$form->select('book_id', 'Choose a book')->rules('required')->options(BookInfo::all()->pluck('title', 'book_id'));

That's weird,  any errors in browser console?

There is no error on browser console

Can you show me the response contents of /admin/api/books?

Here you are, thanks

Try:
return BookInfo::where("title", "like", "%".$q."%")->paginate(null, ["book_id as id", "title as text"]);
The option format of response should be like {id: xxx, text : xxx}.

It's worked, thanks z-song so much


/#code becomes anchor after redirect

Library

[ ]<EMAIL_ADDRESS>or<EMAIL_ADDRESS>[x]<EMAIL_ADDRESS>[ ]<EMAIL_ADDRESS>[ ]<EMAIL_ADDRESS>[ ]<EMAIL_ADDRESS>[ ]<EMAIL_ADDRESS>[x]<EMAIL_ADDRESS>[ ]<EMAIL_ADDRESS>
Description

I have a SPA with msal guards on all routes.
After successfully login the user gets redirected to the app, but the 'code' stays visible on the url.

In the routing root i have:
useHash: false
How can i make sure that '#code=abc...' gets removed after the redirect?
Most example are using hash, so i couldn't find anything in the samples or docs.
Source

[ ] Internal (Microsoft)
[x] Customer request

@Marcel0024 Is the MsalGuard set on the home route too? Do you have the MsalRedirectComponent bootstrapped?
If your home page has the MsalGuard, when redirecting back to your home page after signing in, unless you explicitly call handleRedirectObservable, the returning redirect is not being handled. We recommend having the MsalRedirectComponent bootstrapped in your app to handle these redirects, even if your routes are protected by the MsalGuard. Please see our redirect doc for more details.
I will also link a PR we have up that updates one of our samples to not use the HashLocationStrategy, with updated documentation, which you can refer to also.

@jo-arroyo Thanks for the reply!
I added this for further debugging:
msalBroadcast.msalSubject$.subscribe((log) => console.log(log));
the redirect does seem to get hit:

I added the MsalRedirectComponent and the problem still persists.
So MsalGuard is definitely set on home, i get logged in and able to get the user data.
Other things i do differently to your sample, is everything from Msal has it's own module and feature module's has their own routing module with msal guard.
I'll try to reproduce it tomorrow on a clean project.

@Marcel0024 We have just released a new version of @azure/msal-angular with changes that may help. Please upgrade with npm install @azure/msal-angular@latest and @azure/msal-browser@latest, and let me know if you are still experiencing issues.

Managed to reproduce this on a new project:
https://github.com/Marcel0024/MsalTest
Change the client id and url on https://github.com/Marcel0024/MsalTest/blob/master/src/core/user/user.module.ts#L12
And add the proper callback url on Azure AD
after starting the project you get immediately redirect to MS -> log in -> redirect back to app ->  Successfully logged in -> /#code=123... in the url

Same problem @Marcel0024 , /#code=123... in the url after login. @azure/msal-angular

Hi @jo-arroyo,
Any news on this?
Was the sample sufficient?
Were you able to reproduce?
Did i do something wrong?
Do you require more detailed steps to reproduce?

@Marcel0024 Apologies for the delayed response. I can reproduce the behavior you describe. While I investigate, please follow our recommended best practice using a dedicated redirect route that is not protected by the MSAL Guard, which should mitigate the issue: https://github.com/AzureAD/microsoft-authentication-library-for-js/blob/dev/lib/msal-angular/docs/FAQ.md#pathlocationstrategy

Thanks @jasonnutter i must have missed that in the docs. It does mitigate it! Is this the correct way of using it or is this a workaround?

@Marcel0024 Yes, this is our recommended best practice.

We have root caused this issued, and should have a fix in the next version of MSAL Angular v2.

Hi @jasonnutter , I got to test the new version, in fact the url is now clean after the redirect, but only if you have the Guard canActivate. My route for example is canLoad and the problem still exists. Thank you!

Hi @jasonnutter , I got to test the new version, in fact the url is now clean after the redirect, but only if you have the Guard canActivate. My route for example is canLoad and the problem still exists. Thank you!

This is a known limitation (path routing, redirect uri set to page using MSAL Guard via canLoad) that is not supported at this time. Please use a dedicated redirect URI that either does not use the MSAL Guard or uses canActivite.


Remove the no recreate option to let the vhosts be updated if needed

The option "--no-recreate" doesn't allow to let the vhosts be updated if needed

Thanks for the suggestion, but as you are referring to a previous tag, the pull request should not be on the master branch. I've updated the v2.3 tag with a new commit (1e54625fe98232502fbcd1ed9efd28031a40bd32). 😉


Issue with Byte Deserializer

Description
I tried to connect to kafka servers(Consumer) by using SSL protocol. Successfully connected to servers but not receiving any messages.
Here, Producers are pushing data in byte format.
PLease find the below logs and code for reference :-
7|2018-08-17 15:41:07.550|Test1#consumer-1|CONNECTED| [thrd:ssl://myserver1:9093/bootstrap]: ssl://myserver1:9093/1: Connected (#1)
7|2018-08-17 15:41:07.544|Test1#consumer-1|SSLVERIFY| [thrd:ssl://myserver1:9093/bootstrap]: ssl://myserver1:9093/1: Broker SSL certificate verified
7|2018-08-17 15:41:07.508|Test1#consumer-1|CONNECTED| [thrd:ssl://myserver2:9093/bootstrap]: ssl://myserver2:9093/bootstrap: Connected (#1)
7|2018-08-17 15:41:07.544|Test1#consumer-1|SSLVERIFY| [thrd:ssl://myserver2:9093/bootstrap]: ssl://myserver2:9093/1: Broker SSL certificate verified
Messages :-
7|2018-08-17 16:43:55.896|Test1#consumer-1|SEND| [thrd:ssl://myserver1:9093/bootstrap]: ssl://myserver1:9093/2: Sent MetadataRequest (v2, 23 bytes @ 0, CorrId 2)
7|2018-08-17 16:43:55.908|Test1#consumer-1|RECV| [thrd:ssl://myserver1:9093/bootstrap]: ssl://myserver1:9093/2: Received MetadataResponse (v2, 414 bytes, CorrId 2, rtt 11.94ms)
Consumer Code :-
Consumer<string, byte[]> consumer consumer = new Consumer<string, byte[]>(config,new StringDeserializer(Encoding.UTF8), new ByteArrayDeserializer());
Message<string, byte[]> msg;
if (!consumer.Consume(out msg, TimeSpan.FromMilliseconds(100)))
{
continue;
}
Here, Always getting msg as null.
Can you please help me why "msg" is always null even though we had messages against our topic?
Based on the logs, assuming successfully connected to the servers and getting messages. Is my understanding correct ?
How to reproduce
Checklist
Please provide the following information:

[ ] Confluent.Kafka nuget version: 0.11.5

[ ] Apache Kafka version:

[ ] Client configuration:
ssl.certificate.location - client.pem
ssl.ca.location - rootcertificate.pem
ssl.key.location - client.key

[ ] Operating system: Windows 7

[ ] Provide logs (with "debug" : "..." as necessary in configuration)

[ ] Provide broker log excerpts

[ ] Critical issue

you could try adding a handler to OnConsumeError. Note that in the 1.0 api there is no OnConsumeError and you'll get an exception instead - i'd recommend using the 1.0 api at this stage.
also, are you producing at the same time you are consuming and if not, did you set auto.offset.reset to earliest.

(OnConsumeError would occur if the string deserialization failed).
Otherwise, feel free to paste more comprehensive 'debug': 'all' logs.

Maybe have a look at what Consumer.Metadata gives you, or see if AdminClient.DescribeConfigsAsync in the new API works. Maybe try creating a new topic with AdminClient.CreateTopicsAsync and see if you can consume from that. I don't have any good ideas as to what the problem might be atm if it's not that the topic doesn't exist.

Hi,
I looked into the metadata(Consumer.Metadata), it's not returning this topic.
I was confused and checking with the Producer team on this.
In between, Currently Producer team producing the messages by using Java and authenticating by using JKS. There are some consumers for this and they are able to consume by using Java.
We are trying to connect by using .NET.
Do you have any pointers on what could be the reason ?
Thanks in advance.

are they restricting access to the topic using ACLs? if you are not authorized, i suspect the result would be that you simply cannot view the topic (i'm not very familiar with Kafka ACLs though).
We need to write a cookbook like tutorial for converting java security configs to ones compatible with librdkaka. we haven't done this yet. I did start writing down how to set things up from scratch though here: https://github.com/mhowlett/confluent-kafka-dotnet/tree/security/examples/Security

Is this still an issue?


Update SDK packages for new getting started card component

... Also includes changes to support plugin dependency resolution

/lgtm


Fix timezone of run timestamps

See: https://github.com/European-XFEL/DAMNIT/pull/24#discussion_r1270729829
Obligatory timezone video: https://www.youtube.com/watch?v=-5wpm-gesOY

Progress update: #24 and #105 are now merged and deployed to the stable module and I'm going through all the databases to reprocess their runs and update the timestamps.

Thanks James :smiley:


Elastic-line animation added

Title and Issue number

I have added the project .Can it be merged now?
Close #4195

Checklist:

[X] I have mentioned the issue number in my Pull Request.
[] I have commented my code, particularly in hard-to-understand areas
[] I have created a helpful and easy to understand README.md

@MohitGupta121 ,@TusharKesarwani Please review my PR and assign a level2 tag to it as i have changed multiple files and added a new project


[Bug]: Filepicker widget does not validate size when modified

Is there an existing issue for this?

[X] I have searched the existing issues

Current Behavior
Filepicker widget does not validate number of files and file size when it's been updated to a lower value and continues without throwing an error

Steps To Reproduce

Drag and drop a filepicker widget and upload files and sizes equal to the one mentioned on the property pane
Reduce the size and retry file upload with the same files as before
Observe that the number of files and size are not validated with new values

Environment
Production
Version
Cloud

@ramsaptami we have a fixed agenda for the epic property pane improvements, this does not fall under the scope. Also the issue does not effect the end-user and is an edge case which is really not causing any breakage, deprioritizing this

@somangshu can this be related to https://app.intercom.com/a/apps/y10e7138/conversations/164629100057109?redirectTo=feed if yes then I think we should increase the priority to high or even critical as user had really bad experience with video upload

For more context from the user as per @abhvsn
User is facing the below error:

"File content is not base64 encoded. File content needs to be base64 encoded when the 'File Data Type: Base64/Text' field is selected 'Yes'. "

The user is trying to add a MP4 video file above 5 MB. They are trying to upload with the base64 format
The user has also tried changing the max file size property to 25Mb.
We need to figure if this is possible today. If not what should be the resolution here.
cc @SatishGandham

Marked critical until we arrive a solution.

I tried a 33MB mp4 file with base64 format. It is working fine on my dev (which is 6 days old), but is failing on release even before making the execute call. could be a regression?
Did something change in between?
From what the user is describing, looks like he did not select the correct data type in file picker widget.
@abhvsn , can you confirm that?

@SatishGandham are you able to see a change in the release environment that could be causing this ?

@vivekverma2312 this is a regression, Can you test and confirm the above?

@somangshu Tested and issue is reproducible, marking it as release blocker.

I'm not sure if this is a regression that we saw recently. Seen this happen for quite sometime now

@ramsaptami Satish mentioned that this is working in the local dev.
Ill try and allocate some bandwidth to understand more.

@ashit-rath if you have some bandwidth, can you try to find the root cause.

The problem I was able to reproduce -
When you upload files in a filepicker and then change the no.of files or file size.
The existing files uploaded are not revalidated.
Real scenario where this is a problem -
If the max files and file size is controlled using another widget in the app. Like if you are allowing users to control how many images they upload and size of images, then this flow is confusing for the app viewers. Very rare flow in itself.
I don't have the right solution but possible idea for this is
Whenever the max files or max file size changes - Discard all existing files and reset the widget
@somangshu @techbhavin - I don't think we should work on this now. If agreed, I'll move this to icebox.

I like the solution you are proposing. Not a burning problem according to me right now because the app viewer cant be directly affected by this since these are not really JS convertible to have dynamic values.
Another point with resetting the data on these attribute updates is that in case in the future we allow this value to be dynamic, To the app viewer / end user the behaviour might be unpredictable as there is no way for them to understand where there uploaded files go when there is an update in the max file / max size property
the implementation is easy but the consequences need to be thought through. In favour of that I suggest we move this to the ice box

Another point with resetting the data on these attribute updates is that in case in the future we allow this value to be dynamic, To the app viewer / end user the behaviour might be unpredictable as there is no way for them to understand where there uploaded files go when there is an update in the max file / max size property

Would it make sense to add a message of some sort after re-evaluation to let the user know the reason why uploaded files have been cleared?


Create greetings.yaml

Added for issue #919

Great work @sanmarg  !!
Do not forget to

Share your contribution on socials and tag Clueless 🫂
Give this repository a star ✨
Follow Clueless Community on GitHub ✅

Please assign this PR to me.


Reuse storage buffers

This reduces memory pressure since we don't throw away and recreate buffers all the time.
This should've been merged before #384, since it depends on the copy-on-store this change adds.

This also somewhat drops memory usage, although this could be further reduced by preallocating all the chunks, but that will be added in an upcoming feature that uses MMap for the cache storage with both persisent and non-persistent modes.


Command fails to start kubelet

https://github.com/gavinzhou/ci-minikube/blob/39f775bcced1495e5244738cf1f7b948ac739abb/.circleci/config.yml#L35
While working on a CI workflow using Minikube myself I was unable to get my equivalent of this command to run successfully. It errors out with:
E0204 10:50:46.985278     134 start.go:302] Error updating cluster:  starting kubelet: running command:

sudo systemctl daemon-reload &&

sudo systemctl enable kubelet &&

sudo systemctl start kubelet

: exit status 1

After debugging the job over SSH I believe it is because I cannot seem to access systemctl in CircleCI, even as the root user. Are you seeing this behavior as well?

you probably missed image: circleci/classic:201808-01 in your config

Closing this as it's old.


Required fields asterisks are small and not easily noticeable

Describe the bug
Feedback from Arkansas: when admin creates new question it's easy to miss required fields. They are marked with asterisks but they are small. Suggestions were to increase size of asterisks or mark then in different color (e.g. red).

Repro link: https://staging-aws.civiform.dev/admin/questions/new?type=address&redirectUrl=%2Fadmin%2Fquestions

Cassandra to connect with Miriam

Here's my thoughts on the issue: (1) add a space before the asterisk symbol to separate it from the character before it and (2) change color to red to help differentiate it visually,  it should be a consistent experience for both admins and residents. (3) Also, include aria label for required fields to easily be read by screen readers: https://www.w3.org/WAI/WCAG21/Techniques/aria/ARIA2


silx script to execute main() function in module

As discussed in our meeting, I'm working on a silx command line interface to be able to execute a main function in any module. Any criticism is welcome !
I tried two different ways for finding all available modules, and the most likely option is to browse through the silx package with os.walk. I have a heavily commented prototype to explain how it works: https://github.com/PiRK/silx/blob/silx_cli/scripts/runmodule_oswalk.py
All .py and .so files in a subfolder with a __init__.py file are considered to be modules.
A modules can be called by its short name (e.g. PlotWindow) or it's long name (e.g. silx.gui.plot.PlotWindow). The long name is mandatory in case of ambiguity.
The -h option used together with a module name causes the docstring of the main() function to be printed.
A -l option can be used to print a complete alphabetically sorted list of long module names. This list is already very long, so this option might soon become hard to use.
A -s option can be used to search a module by providing part of its name. All modules whose long name contain the provided search string are listed. Maybe I should change the search to do it on short names?  This would help restrict the number of matches, but the downside would be that we could not search all sub-modules of a given module (e.g python runmodule_oswalk.py -s math to find all silx.math.* modules)
So far, the main function should have following signature:
int main(*args)

The return value is used as the exit code (sys.exit(main(*args))).
args is the list of all arguments specified on the command line after the module name. For the moment I pass them as raw strings to the main() function. Do you think it would be a good idea to try to guess the type of the arguments, or should we just let the main() function handle all typecasting?

My comments:

I would aim to the following to not imposing anything on the main function. If we decide to impose something to it, then I would be more in favor of defining a silx_main.

I would only look for .py files and not for .pyd or .so or .dyld files (there is life beyond linux).

Can I close this issue?
I believe the general consensus is now that applications should go into to the silx.app module and demos to the examples directory.


Feature request: macro recorder

One thing I really like about most macro-enabled editors is the ability to "record" my action into a temporary macros, and then play it back multiple times.
This would be a great feature for you macros extension.

agreed! I'd be open to this as a community contribution, don't have time at the moment to add it myself.

I think this will become possible as soon as the vscode.commands.onDidExecuteCommand API is added to the stable release.
Then as soon as the user activates recording (for instance via a command) the extension can listen to this event and create the corresponding macros command.
A drawback could be that this API will require the latest vscode version (probably ^1.38.0)

Nevermind. Unfortunately the vscode.commands.onDidExecuteCommand API got rejected.


Merge upstream

Also preserve some Basho-specific patches to keep the logic the same as 1.1p6

+1


OCID needs a yaml config file

I don't want OCID to make the same mistake that docker did, although even docker finally has a config file.
All commands on the CLI should be specified in a config file.  The CLI options should override this.  One problem I foresee is the Option handling for OCID does not support default boolean settings.
I would figure the OCID would read in the config file first, and then setup the CLI Options with the values defaulted to the config file, but if the boolean options can not take a default, then we won't be able to tell the difference between whether the option was set in the config or overridden by the CLI Option.

I completely agree. However, I think we should make it a TOML config file. My reasons:

YAML is an incredibly complicated specification, and contains lots of features (ahem turing completeness) that are not helpful to anyone who just wants to set up cri-o.
YAML is not good for describing the configuration of a tool, as it doesn't semantically make sections of options easy to convey. TOML is essentially what git uses, and that works fairly well IMO.

+1 on this, either yaml or toml works for me

I'm working on toml at the moment, so consider this assigned to me.

My main concern is that it is easy for the Administrator to understand and edit.  So if TOML works for this situation, I am all for it.  I am still concerned about the boolean default values.

We can set this up by having a "default config" structure and then we just modify it. i'm currently working on a PR so hang tight for that. :wink:

closed by #115 I guess


CONFIG_DEFAULT_SECURITY_APPARMOR=n not working for Nitrogen8MM unless CONFIG_SECURITY_APPARMOR=n

The default security is still set to apparmor unless apparmor is completely disabled. The OS sets CONFIG_DEFAULT_SECURITY_APPARMOR=n but this is not the final result during a build, we need to look into why this happens.
Internal thread https://balena.zulipchat.com/#narrow/stream/345889-balena-io.2Fos/topic/multicontainer.20sample.20app.20fails.20to.20start.20in.20v2.2E113.2E35/near/348391746
Connects to https://github.com/balena-os/meta-balena/pull/3099

The generic-x86-64 is on kirkstone, has kernel 5.15 and also has DEFAULT_SECURITY_APPARMOR=y in the defconfig but it does get disabled by the setting in meta-balena.
For the Nitrogen this is still not disabled, neither with kernel 5.15 (not yet published by BSP) and kirkstone.
Needs further investigation


Add root-cause to the e2e tests

Hey 👋
We wrote an open source tool called “Root Cause” that gives a better debugging experience for puppeteer/playwright tests. You can think of it as “cypress like debugging for puppeteer and playwright”.
When integrated, Root Cause will trace calls (or “test steps”) to the test automation library (puppeteer/playwright) and capture screenshot, console and network logs and other debug info, and make it all viewable in an intuitive viewer.

I was looking for open-source libraries with nice puppeteer/playwright e2e tests to integrate with so we can gather product feedback.
This PR adds root cause to this project. Note none of this is automatic and I actually went through the code to integrate.
After tests run with Root Cause integrated, you can see the results using the cli:
npx root-cause ls / npx root-cause show or yarn’s counterpart yarn root-cause ls/show
https://help.testim.io/docs/viewing-local-results-root-cause-cli
Cloud Viewer
Testim.io also has a cloud offering of root-cause (like circleci for open source). It’s still very early on but we’d like to offer you “root cause cloud” for free. It basically makes it much easier to collaborate on e2e test results and debug why e2e tests failed.
I didn’t want to go ahead and register for you because that felt pushy to me and I’m trying to be helpful and gather feedback for this thing we’ve built.
To upload results to the cloud viewer, you will need to register to testim at https://app.testim.io/#/signup?fromRootCause=true and add your access token as an environment variable as described in the getting started page. Once you do that please let me know and I’ll be happy to enable it or your account.
Cheers,
Bnaya

The format action failure is due to github permissions issue,
Not sure exactly how to over come it.
anyhow, I ran yarn format locally


Which version of RF can support JMSLibrary?

Hello,
I have Robot Framework 2.7.6 (Jython 2.5.3 on java1.7.0_45, and Python 2.6.6) on CentOS and have problem with Init Provider KW. It complains about number of arguments and it seems that third parameter in initProvider method of JMSLibrary.java is not correctly used/filled by the framework.
So, no matter if I put 2, 3 or 4 and more params it complains:
2 params: Keyword 'JMSLibrary.Init Provider' expected 3 arguments, got 2.
3 params (3rd is connect=true): TypeError: initProvider(): 3rd arg can't be coerced to java.util.Map
4 params (4th is start=true): Keyword 'JMSLibrary.Init Provider' expected 3 arguments, got 4.
Can you please check this?
Thanks
Matko

Hi,
Could you please try RF 2.8.3? I would say it is because the "**kwargs support for static Java test libraries" [1] included in the version.
[1] https://code.google.com/p/robotframework/wiki/ReleaseNotes28#Robot_Framework_2.8.3
Best regards,
Ilkka

Thank you for your reply. I can only confirm that this problem is not happening with:
Robot Framework 2.8.7 (Jython 2.7rc1 on java1.7.0_79)
Best regards
Matko

Great that you got it working! I'll mark down this RF version precondition for the library.
Best regards,
Ilkka


Scenes over water fail with Failed to compute statistics, no valid pixels found in sampling when apply_water_mask=True

INSAR_ISCE_BURST jobs fail with errors such as RuntimeError: S1_320206_IW1_20200901_20200913_VV_INT80_77F1/S1_320206_IW1_20200901_20200913_VV_INT80_77F1_unw_phase.tif, band 1: Failed to compute statistics, no valid pixels found in sampling. during the geocoding step when a user processes a pair of scenes entirely over water and applies water masking.
For example, this pair is off the Florida coast:
S1_320206_IW1_20200901T232050_VV_8BB7-BURST
S1_320206_IW1_20200913T232051_VV_DD3A-BURST

An INSAR_ISCE_BURST jobs succeeds when apply_water_mask=False: https://hyp3-api.asf.alaska.edu/jobs/17ce7f24-ba52-4c44-abde-6a339fab7a87
But fails when apply_water_mask=True: https://hyp3-api.asf.alaska.edu/jobs/f3c721ee-827e-434b-a71a-50d1fe6d6c8d

Complete log file for reference: f3c721ee-827e-434b-a71a-50d1fe6d6c8d.log

I think this is the same bug as https://github.com/ASFHyP3/hyp3-isce2/issues/247
The lonlat coordinates are wrong, so that pixels in the water mask cannot be correctly transformed  from wgs84 to radar coordinates.


Forwarding incoming call to an external phone number

It's posible to forwarding any incoming call to an external phone number?
I have 3 telephone lines and I need to resend any incoming call to 2 differents external telephones.
The idea is to resend the incoming call to an external telephone "1" if the incoming call arrives from the first line and to an external telephone "2" if the incoming call arrives from the second line.
Is it possible?
How?
Thanks!

This sounds more like an Asterisk question than an AsterNET question.
Why are you asking here? Do you know what AMI commands to use? If not you might want to start on an Asterisk help forum instead.

Sorry, I will.


querying keys from useParams is sometimes undefined

"react-router": "^5.2.0",
"react-router-dom": "^5.2.0",

Please replace this sentence with the React Router version that you are using.
Test Case
https://codesandbox.io/s/react-router-gh6n7
N/A
Steps to reproduce
Expected Behavior
So we have a certain route, nothing crazy defined with a parameter like this
<Route exact path="/person/:personId" component={SuperComponent} />

And you know references like this all over the place....
const {personId} = useParams()

About half the time, we notice the personId is undefined? Is this expected? We can still grab the parameter off the window.location object directly
We have a modal container and it's presented with a series of cloneElement calls, seems to be compounding the problem as only this avenue of code is affected.
Actual Behavior

Something else must be going on here outside of the library. There isn't a way for that code to produce different outputs. You would need to be removing the parent Route from the tree for it not to have those values.
Can you provide a reproduction of the issue on Codesandbox?


MS4 Feedback

Feedback for Group 31

Notes from [Islam] on Feedback on the analysis:

Analysis 1:

Good job.
[x] #3

Analysis 2:

Good job.
[x] #4
[x] #5
[x] #6
[x] #7

Analysis 2:

Good job.
[x] #8

Contracted Grade

What is your contracted grade?

A

Are you on track to satisfy all the requirements of your contracted grade?

Yes, work isn't done but you're on the right track.

Answered milestone 4 feedback


Empty Regions

https://github.com/HydrologicEngineeringCenter/HEC-FDA/blob/3ff04fd7f509d3507ab115c8a809631003587347/ViewModel/WaterSurfaceElevation/PathAndProbability.cs#L10
This isn't a big deal, and I'd reconsider if you felt strongly the other direction, but I always find myself opening up every empty region while I'm reviewing code, and being frustrated there's nothing there.
I also find it frustrating when someone enforces a strict file structure on their computer, but then has a bunch of empty directories because the didn't apply to that project.
I'm not gung ho about going in and doing a sweep of these, but if you have no objections, lets not create regions unless we have something to put in them. That's not part of our contributing guide, and I don't really think it ought to be.

RMA totally agrees with you. I have not been creating regions in new classes unless i thought they would be helpful. Ryan usually calls them out when doing code review if he sees a region with nothing in it. I have been trying to remove them when i see them.

sweet. resolved


Scroll friction does not match other Android apps

I'm sure the same is true on iOS too, I can get a video for that.  I would expect users to notice this, subconsciously if nothing else.
https://youtu.be/_fdln_D1kM8

This was reported on gitter just now.  I think @HansMuller mentioned he was looking at improving this for android last week.  @chinmaygarde also landed https://github.com/flutter/scroll_overlay for iOS, we could add the Android side now too.

Hans measured this and got as close as reasonably possible. If it's still not good then we should get a new bug with more specific actionable ways to determine the difference.


XDR side of the contract deployment changes specified in CAP-46-02.

This introduces the ledger entries to store the wasm code and also changes the host functions to support creating/installing the contracts.
See https://github.com/stellar/stellar-protocol/pull/1315 for the general overview of the changes.

Since we seem to have agreed to keep the naming for now and do the renaming separately, is there anything else that needs to be addressed before merge?


accessing pagination @object inside views?

<%= paginate @products %>
I used rails g kaminari:views default, and added this code (per issue #29) to the _paginator.html.erb partial
<%= @products.offset_value + 1 %> - <%= @products.offset_value + @products.length %> of <%= @products.total_count %>

I get undefined method `offset_value' for nil:NilClass
How do i pass, or access the paginated object inside the views?

I guess what you really want is probably page_entries_info:
<%= page_entries_info @users %>

Ok, <%= page_entries_info @products %> works, but is there a way to place this inside my index view

			<%= page_entries_info @products %>
			<%= paginate @products %>

But isn't there a way to use that helper method in the kaminari views, for example in the _paginator view to keep things cleaner?

There isn't a way to do that. But you can just create a partial template and use it from another template.
By the way, we only bug reports and pull requests no GitHub issues.  Questions like this should be asked on StackOverflow so you can get more help. Thanks!

If not @object then why can't we pass the total_count as one of the options? I have a case where having the total_count inside = paginator.render do block is a must. For some reason this one value is missing.

Correct me if I'm wrong but it looks like currently to get the 'total_count' inside the paginator helper I'd need to do something like:
= paginate @some_scope, total_count: @some_scope.total_count
and inside block = paginator.render do
instance_variable_get(:@options)[:total_count]

@januszm we could make it possible to get the total count with a total_count call in the = paginator.render do block, but it seems more like a feature request.


Added simple go programs

Fixes#143
Added Simple go programs.

Thanks for your contribution!

PR has been merged under Hacktoberfest!

Happy contribution!


Items can be deleted even with no cheats enabled

EMI: 1.1.8-1.20.1-Forge
Even without cheats enabled items say they can be deleted. If you click to delete them they will become invisible but won’t actually disappear. Upon reopening the inventory UI they become visible again. In case you inventory is full the item will drop immediately.
Ultimately the issue is visual and can be misleading as the UI lies about deleting the items
Expected:    The legend should not appear without cheat mode and drop the items instead of causing them to become invisible

I can't reproduce this with just EMI, the delete stack tooltip doesn't appear unless cheat mode is on, and stacks don't get deleted when clicking. Can you reproduce this in a minimal environment and provide more info, like a video or log of the behavior you're describing?

I’ll try to later as i’m unable to now. Thanks


[Bug Report] el-select keyboard for iOS devices doesn't show up when filterable is true but mutliple is false

Element UI version
2.4.6
OS/Browsers version
iOS Safari
Vue version
2.5.17
Reproduction Link
https://jsfiddle.net/45kvjg6u/13/
Steps to reproduce
When using the iOS simulator, use an iPad Pro device to open the reproduction link

Click the first select and try typing with the keyboard and text won't be inputted
Click the second select and try typing with the keyboard and text is inputted

When using an actual device

Clicking the first select will not render the iOS keyboard
Clicking the second select will render the iOS keyboard

What is Expected?
Users should be able to input text for el-select components when filterable is true for iOS devices
What is actually happening?
Users are only able to input text for el-select components when filterable is true when mutliple is also true for iOS devices

Element is designed for desktop. It's not compatible with mobile devices.  You can use other libraries like vant. FYI: https://github.com/vuejs/awesome-vue#mobile-1

This is a terrible answer. For the most part, ElementUI works (and looks!) great on mobiles with a few tweaks to the css.
Has anyone managed to get round this?

I had same issue with el-select.
Could not solve it and started to use el-autocomplete. In my case everything is ok on IOS.

It's a shame because it works fine on desktop, even in mobiles based on Android OS.
It doesn't make sense that it won't work only in IOS based web browsers

Element is designed for desktop. It's not compatible with mobile devices. You can use other libraries like vant. FYI: https://github.com/vuejs/awesome-vue#mobile-1

@ziyoung ElementIO works perfectly in Android browsers (it's mobile too).
Maybe instead of saying "you can use other libraries", you could point this bug with less priority, to see it later.
Regards

a good workaround is to set multiple and :multiple-limit="1"

una buena solución es establecer y multiple``:multiple-limit="1"

The best solution so far

Hey guys, thankfully "Dongdong notes" an alternate fix for this that seems to work for my use case here: https://cdmana.com/2021/01/20210119003837456j.html
(I couldn't use @mattharley solution above)
Here's the solution directly from "Dongdongs notes", check out the above link for a more in depth explanation:
<template>
    <el-select
        ref="select"
        @hook:mounted="cancalReadOnly"
        @visible-change="cancalReadOnly"
    >

    </el-select>
</template>

<script>
    export default {
        methods: {
            cancalReadOnly(onOff) {
                this.$nextTick(() => {
                    if (!onOff) {
                        const {select} = this.$refs;
                        const input = select.$el.querySelector('.el-input__inner');
                        input.removeAttribute('readonly');
                    }
                });
            }
        }
    }
</script>

Hey guys, thankfully "Dongdong notes" has an alternate fix for this that seems to work for my use case here: https://cdmana.com/2021/01/20210119003837456j.html
(I couldn't use @mattharley solution above)
Here's the solution directly from "Dongdongs notes", check out the above link for a more in depth explanation:
<template>
    <el-select
        ref="select"
        @hook:mounted="cancalReadOnly"
        @visible-change="cancalReadOnly"
    >

    </el-select>
</template>

<script>
    export default {
        methods: {
            cancalReadOnly(onOff) {
                this.$nextTick(() => {
                    if (!onOff) {
                        const {select} = this.$refs;
                        const input = select.$el.querySelector('.el-input__inner');
                        input.removeAttribute('readonly');
                    }
                });
            }
        }
    }
</script>

could add  input.blur()

//fix let fixElSelect = function () { 	document.querySelectorAll('.el-select[data-is-search="true"]:hover').forEach((v) => { 		let a = document.querySelector('.el-select[data-is-search="true"]:hover input[readonly]'); 		if (a) { 			console.log(a); 			a.readOnly = false; 			a.blur(); 			a.focus(); 		} 	}); }; document.addEventListener("focusin", fixElSelect); document.addEventListener("click", fixElSelect); document.addEventListener("touchstart", fixElSelect);

The most stable solution with the directive v-cancel-read-only
Template:
<el-select v-cancel-read-only>...</el-select>
Script:
directives: {
  cancelReadOnly (el) {
    const input = el.querySelector('.el-input__inner');
    input.removeAttribute('readonly');
  }
}

Add the following code to main.js, and add data-is-search="true" to each el-select
//fix el-select
let fixElSelect = function () {
	document.querySelectorAll('.el-select[data-is-search="true"]:hover').forEach((v) => {
		let elInput = document.querySelector('.el-select[data-is-search="true"]:hover input[readonly]');
		if (elInput) {
			elInput.readOnly = false;
			elInput.blur();
			elInput.focus();
		}
	});
};
document.addEventListener("focusin", fixElSelect);
document.addEventListener("click", fixElSelect);
document.addEventListener("touchstart", fixElSelect);

thank you so much. it seems work to me


Need help text to indicate that sorting a schedule needs saving

Not saving and hitting print pdf means it is out of order.  Maybe a 'there are unsaved changes that wont be reflected on the pdf' would be helpful.

@micheal-w-wells I think a better solution would be to automatically save the plan before showing the PDF dialog.

@calebissharp SGTM


Example for using FileReader onload callback

Sorry if this is obvious and I'm just missing something. New to rust here.
I'm trying to figure out how to use FileReader in stdweb.
The API inherited from JS is designed to be used like:
reader.addEventListener('loadend', () => {
   doAThing(reader.result)
});

But in rust I can't pull the reader's result out in the callback.

if I move the reader into the callback, I can no longer bind the event listener
if I don't move the reader into the callback, it won't compile because the reader won't be on the stack anymore by the time the callback is called.

What's the solve here? Is cloning the reader object safe? (e.g. will it still refer to the same reader as far as the browser is concerned)?

What's the solve here? Is cloning the reader object safe? (e.g. will it still refer to the same reader as far as the browser is concerned)?

Yes, that's exactly what you're supposed to do. The vast majority of the types in stdweb have reference semantics, that is - you can .clone() them and they will still reference the same object.

Sorry if this is obvious and I'm just missing something. New to rust here.

It's no problem. Feel free to ask away if you have any problems and I'll be happy to help. (:

Thanks for the help!


tests: enable datalink/defrag tests for 6.0.x

Ticket
If your pull request is related to a Suricata ticket, please provide
the full URL to the ticket here so this pull request can monitor
changes to the ticket status:
Redmine ticket:

These should pass now that Suricata backport was merged, could you rebase it to rerun CI ?

Merged in #1779, thanks!


Error rendering solid-js application (laravel 9.x, solid-js 1.7.5)

Good morning!
I'm attempting to SSR render a site I'm writing using laravel and solid-js, but when I access the page and the following response when I attempt to access the SSR server directly,
implode(): Argument #2 ($array) must be of type ?array, string given
status:    "NOT_FOUND"
timestamp:<PHONE_NUMBER>353

I've followed the directions for setting the adapter up to a tee, and the result is the error I receive as a result.
Any suggestions what I could be doing wrong? Thank you!

Hello, this seems to be a PHP error, nothing to do with this adapter.
Which PHP framework are you using?

laravel 9, and according to some folks on the solidjs discord, the adapter isn't 100% following the SSR protocol.

I can somewhat confirm this, as I had to patch their HTTP proxy code to make sure that if $response["header"] isn't an array, that it's just supposed to return it verbatim, rather than trying to join it.
If you have time, I'm on the solidjs discord (robert_), you can ping me there- or I can go gather debug logs if you'd prefer 😅😅

Kindly point me to the discussion to have better context on this as, to me, it seems that the problem is not related to this adapter but to inertia itself

Found the discussion thread: https://discord.com/channels/592327939920494592/758259460920573992/1161998154481274981
It is indeed as you mention, this adapter does not return an array of headers, but a string as it is rendered directly using solid-meta package.
If you have any suggestions, please let me know, I'm a little bit busy atm so it may take me a few days

@lighth7015 please let me know if this recent release fixes your issues 🙌


Add Chinese translate.

I noticed that some sections have Chinese translation, but some of them are out of date.
Such as (Get Start: Configuration)[https://docs.microsoft.com/zh-cn/windows/terminal/get-started#configuration]). Compare with English version, it is obviously that the English version has a tip, which is not exist in Chinese version.
And there are several sections have no Chinese translation. Such as (Customize Settings: Starup)[https://docs.microsoft.com/zh-cn/windows/terminal/customize-settings/startup]
I would like to help fix those problems and try to translate some documents into Chinese.
p.s. I cannot find the location of Chinese translation version in this repo.
Thanks!

Unfortunately we don't currently have a way to support translation contributions. :(  Our localization team has been looking into options for this for a long time, but keeps running into obstacles, so we are currently stuck with machine translations. These machine translations also seem to take up to a week between when we make an update to the English version of the content to when the update appears across all of the translation pages. It's been listed as an issue and the localize team is actively working on finding ways to improve.


Bad Layout Speakers page on Mobiles

By some previous PR's , Speaker page layout is disturbed on Small screens.

[ ] Shift popover exactly below the image.
[ ] Remove X-axis scrollbar

In the current implementation, on small screen the pop-up box is displayed from the centre of the image. So we have added a class which adds a necessary left margin to make the pop-up box shift to the left to make it coincide with the image.  The problem with that is that the different small screen sizes will require different left margin for perfect overlap. So we have to add various more screen sizes and the corresponding left margin for making the pop up come directly under the screen. The previous pull request left out some cases so it was working on devices with width size 320-360px but looked a bit abrupt on 500px wide screens.There might be better solutions but we will have to think for those. I am willing to work on this. Just need some guidance.

@aayusharora Not exactly the same thing as asked, but please do check out this page I made after doing some changes . Run it on different screen sizes and it should not look bad in general.
https://princu7.github.io/websiteTest/speakers.html
There are some cases where we don't want to shift the popovers exactly below the image. Suppose the width of the screen is 700px then only one picture of width 300px will come in a single row. If we shift popovers exactly below the image, then a lot of the white space will be wasted(400px to be precise). A better alternative than that would be just to display the picture in the middle and let the pop-over have the full size of the screen. It does look neat and clean.
For example-
Intended version

Alternative version

The second looks a tiny bit better. Views and suggestions?

@Princu7 The second view is destroyed badly. To improve
Follow the first view.

@aayusharora Ah. My bad. No problem. I will implement keeping the first view in mind. Will Ping you as soon as I am done with it. Thanks for the feedback.

@aayusharora I am sorry but I got confused after your edit. We are supposed to go with the first view or second view?

@Princu7 I am convinced for this on Tablets or only for some CSS breakpoint range. Thanks

@aayusharora Thanks. I will send a request soon.


Update ChangeLog

Add  major updates to 4.0.0alpha by Ray since Nov, 2016.
@zdenop, @stweil, @egorpugin @amitdo Please update with other major changes. Thanks!

+ Remove support for VS2010.

Remove support for VS2010.

@egorpugin
Does Tesseract 4.0 built with CMake supports VS2010 or not?

No. Not out of the box.
One needs fixing some bugs in tiff library that comes from cppan.
Or there's always manual way of including dependencies. In this case VS2010 might work.
With cppan VS2015 and VS2017 are only supported.

Add Support for VS2015 and VS2017 with cppan
Implement invisible text only for PDF
Add AVX / SSE support for Windows
Require leptonica 1.74 or higher

VS2010 has limited support for C++11, so there should be more problems . I would expect that situation with VS2010 Express (free version of VS2010) is even worse.

Thanks, I have combined the updates for date range from Nov 2016 to March 2017. Suggest that any major commits also add to the changelog on regular basis.
Does semantic versioning requiring more frequent tagging?
@zdenop Please approve merge. Thanks!

@amitdo  I thought that you had made a similar list adding to release notes... Can't seem to find it now.

Shree, here it is:
https://github.com/tesseract-ocr/tesseract/wiki/ReleaseNotes#in-development

Thanks.

excuse the brevity, sent from mobile

On 24-Mar-2017 5:22 PM, "Amit D."<EMAIL_ADDRESS>wrote:

Shree, here it is:
https://github.com/tesseract-ocr/tesseract/wiki/
ReleaseNotes#in-development
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/tesseract-ocr/tesseract/pull/783#issuecomment-289003475,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AE2_o53dpBF51d4gZOIcYaf3F9O1R6cZks5ro66JgaJpZM4MmauK
.


Add .devcontainer config

Description
In order to unify the development environment for anyone who wants to contribute to D2.0, I was thinking it could be helpful to include a .devcontainer configuration for those of us using VS Code. That would ensure that everyone who touches the repo does so with a consistent environment. If there's any interest in this LMK...happy to take in feedback and submit a PR.
Epic/Story
No response
Have you provided an initial effort estimate for this issue?
I have provided an initial effort estimate

What kind of thing are you thinking of including for this?

Also, important to note here that for my plugin I include @flowfuse/node-red-dashboard in my package.json as a dependency...which is why it doesn't show up in the files above.


Fix for [SR-1946] swift test fails to recognize --build-path argument

https://bugs.swift.org/browse/SR-1946
The flag was not accounted for in TestToolFlag so I added the cases and set opts.path.build the same way it is in a normal swift build invocation.
After this change I was successfully able to swift build to an explicitly specified build directory and run swift test with the same.

LGTM

@swift-ci please test

OS X test failure is this:
********************
Testing: 0 .. 10.. 20.. 30.. 40.. 50.. 60.. 70.. 80.. 90..
Testing Time: 260.98s
********************
Failing Tests (1):
    Swift :: stdlib/Prototypes/PersistentVector.swift.gyb

which looks unrelated (@gribozavr?)


Support api-key authentication to agent admin interface

Signed-off-by: Emiliano Suñé<EMAIL_ADDRESS>

Related PR in indy-catalyst-issuer-controller to support running with protected api endpoints.


Cannot change the logo

I have followed the steps described on this page to change the logo of my application. In the Azure Portal, my new logo is displayed correctly but when I go to https://myapps.microsoft.com, the default logo is still displayed. I have tried several images and get the same problem. The logo in "My Apps" is always the default one.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: da891088-c80a-49da-8dcd-e016d9e75baf
Version Independent ID: 5049445c-f076-67b3-2b06-7dfd43cfc534
Content: Change the name or logo of an enterprise application in Azure Active Directory
Content Source: articles/active-directory/manage-apps/change-name-or-logo-portal.md
Service: active-directory
Sub-service: app-mgmt
GitHub Login: @msmimart
Microsoft Alias: mimart

@gsimardnet Thanks for your feedback! We will investigate and update as appropriate.

Hi @gsimardnet ,
I just tested in my own tenant and was able to get it working. (See campuscoolthings app.)

Have you tried using an entirely different browser and making sure the session isn't caching your old settings? I was having the same problem but made the change in Chrome and then tested in Edge and could see it right away.

After severals attempts I finally was able to change the logo. The first time it work when I changed both the Logo and Name at the same time. Now it seems to works every time so maybe it was just a weird coincidence.
Thanks for the quick answer.

No problem. I'm glad you were able to get it to work! I had the same problem in mine for a bit so it might store the old settings initially.


CNF-14463: Up-version Makefile tools

This PR up-versions the controller-gen and kustomize tool versions in the Makefile.

/cherry-pick release-2.12


Add-to-app - unable to install iOS app having embedded flutter framework

Is there an existing issue for this?

[X] I have searched the existing issues
[X] I have read the guide to filing a bug

Steps to reproduce
run flutter create --template module my_flutter
add code in /lib folder
run flutter build ios-framework --output=/Users/ihi/Desktop/my_flutter_module_framework/
4 .xcframework are generated - App, Flutter, FlutterPlugin & shared_prefs_foundation.xcframework
integrate generated .xcframework 's into existing Xcode project. Select Embed and Sign for all.
archive app to distribute via firebase distribution
when I try to install this, I get this alert

Actual results
Followed - https://docs.flutter.dev/development/add-to-app
First when i added the frameworks generated in Debug folder, I was able to debug the app fine on my phone. But for release on Firebase I replaced the same with frameworks generated in release folder. I was able to archive fine but the build is not installing.
Mac OS - 12.6 Monterey
Xcode - 14.0
Flutter - 3.7.6

Logs

Logs

<!-- Paste your logs here -->

Flutter Doctor output

Doctor output

<!-- calender % flutter doctor -v
[✓] Flutter (Channel stable, 3.7.6, on macOS 12.6 21G115 darwin-x64, locale
    en-IN)
    • Flutter version 3.7.6 on channel stable at
      /Users/ichi14/Documents/everythingFlutter/flutter
    • Upstream repository https://github.com/flutter/flutter.git
    • Framework revision 12cb4eb7a0 (7 days ago), 2023-03-01 10:29:26 -0800
    • Engine revision ada363ee93
    • Dart version 2.19.3
    • DevTools version 2.20.1

[✗] Android toolchain - develop for Android devices
    ✗ Unable to locate Android SDK.
      Install Android Studio from:
      https://developer.android.com/studio/index.html
      On first launch it will assist you in installing the Android SDK
      components.
      (or visit https://flutter.dev/docs/get-started/install/macos#android-setup
      for detailed instructions).
      If the Android SDK has been installed to a custom location, please use
      `flutter config --android-sdk` to update to that location.

[✓] Xcode - develop for iOS and macOS (Xcode 14.0)
    • Xcode at /Applications/Xcode.app/Contents/Developer
    • Build 14A309
    • CocoaPods version 1.11.3

[✗] Chrome - develop for the web (Cannot find Chrome executable at
    /Applications/Google Chrome.app/Contents/MacOS/Google Chrome)
    ! Cannot find Chrome. Try setting CHROME_EXECUTABLE to a Chrome executable.

[!] Android Studio (not installed)
    • Android Studio not found; download from
      https://developer.android.com/studio/index.html
      (or visit https://flutter.dev/docs/get-started/install/macos#android-setup
      for detailed instructions).

[✓] VS Code (version 1.76.0)
    • VS Code at /Applications/Visual Studio Code.app/Contents
    • Flutter extension version 3.60.0

[✓] Connected device (1 available)
    • macOS (desktop) • macos • darwin-x64 • macOS 12.6 21G115 darwin-x64

[✓] HTTP Host Availability
    • All required HTTP hosts are available -->

It seems something goes wrong in XCode configurations. You can try this SO answer and also other answers there if it works for you.
Also, what are your minimum deployments and the current iOS device version?

minimum deployment - 15.0, device version - 15.5
I removed the flutter frameworks, commented the flutter code, archived and shared on firebase - Now build is installing fine on the same device.
Re-checked all the steps mentioned in using-the-latest-code-signature-format  and everything seems ok on provisioning/signature end.
Also the above link says -

Also confirm that you have correctly signed any nested code, for example, an app extension, a framework, or a bundled watchOS app

I think maybe Xcode configuration/code signing that is generated by flutter build ios-framework might be causing the issue.
How can I debug this? or disallow code-signing?

I check this with my sample code but got another error when running on my physical device (The code signature version is no longer supported.) but it works on the emulator. I'm adding webview_flutter and flutter_inappwebview in my sample code. And I added all frameworks from Release folder instead of Debug as you did. Could it be the cause of my error?
Can you please copy the error when you validate the archive here? (It starts with `Invalid bundle structure....)
And please share your completed and minimal reproducible code sample if possible, then I will retry your sample code.
Also, FYI, it seems the original issue will not appear when building with XCode 13 (see https://developer.apple.com/forums/thread/682067).

App will not run directly on connected device from Xcode, when we have added frameworks from release folder, as they are marked for release and not available for debug.
I will try to create a sample for this to share.
Validation Archive error -

Invalid bundle structure. The "Trial.app/Frameworks/
FlutterPluginRegistrant.framework/FlutterPluginRegistrant"binary file is not permitted. Your app
cannot contain standalone executables or libraries, other than a valid CFBundleExecutable of
supported bundles. For details, visit: https://developer.apple.com/documentation/bundleresources/
placing_content in a bundle (ID: 8c3b9558-98f8-4e4d-6548-4b90aef04d45)

I am using Xcode 14.0(released in September 22)

I see this issue now with my sample code on the latest Flutter stable and master channels.
Steps to reproduce

Follow flutter guideline at https://docs.flutter.dev/development/add-to-app/ios/project-setup#option-b---embed-frameworks-in-xcode (Option B)
From XCode, select Product > Archive. Select the archive you want to distribute > Ad Hoc > App Thinning (select All compatible device variants.
Check the Review ***.ipa content, there is missing FlutterPluginRegistrant.xcframework:

Install .ipa file on your device via Apple Configurator or Firebase Distribution as OP (I haven't tried Firebase Distribution yet), then can see the issue:

Issue analysis
Adding more information about output files:

Release directory tree - level 1
➜  Release git:(main) ✗ tree -L 1
.
├── App.xcframework
├── Flutter.xcframework
├── FlutterPluginRegistrant.xcframework
├── OrderedSet.xcframework
├── flutter_inappwebview.xcframework
└── webview_flutter_wkwebview.xcframework

7 directories, 0 files

Release directory tree - level 4
➜  Release git:(main) ✗ tree -L 4
.
├── App.xcframework
│   ├── Info.plist
│   ├── ios-arm64
│   │   └── App.framework
│   │       ├── App
│   │       ├── Info.plist
│   │       ├── _CodeSignature
│   │       └── flutter_assets
│   └── ios-arm64_x86_64-simulator
│       └── App.framework
│           ├── App
│           ├── Info.plist
│           ├── _CodeSignature
│           └── flutter_assets
├── Flutter.xcframework
│   ├── Info.plist
│   ├── ios-arm64
│   │   └── Flutter.framework
│   │       ├── Flutter
│   │       ├── Headers
│   │       ├── Info.plist
│   │       ├── Modules
│   │       ├── _CodeSignature
│   │       └── icudtl.dat
│   └── ios-arm64_x86_64-simulator
│       └── Flutter.framework
│           ├── Flutter
│           ├── Headers
│           ├── Info.plist
│           ├── Modules
│           ├── _CodeSignature
│           └── icudtl.dat
├── FlutterPluginRegistrant.xcframework
│   ├── Info.plist
│   ├── ios-arm64
│   │   └── FlutterPluginRegistrant.framework
│   │       ├── FlutterPluginRegistrant
│   │       ├── Headers
│   │       ├── Info.plist
│   │       └── Modules
│   └── ios-arm64_x86_64-simulator
│       └── FlutterPluginRegistrant.framework
│           ├── FlutterPluginRegistrant
│           ├── Headers
│           ├── Info.plist
│           ├── Modules
│           └── _CodeSignature
├── OrderedSet.xcframework
│   ├── Info.plist
│   ├── ios-arm64
│   │   ├── OrderedSet.framework
│   │   │   ├── Headers
│   │   │   ├── Info.plist
│   │   │   ├── Modules
│   │   │   └── OrderedSet
│   │   └── dSYMs
│   │       └── OrderedSet.framework.dSYM
│   └── ios-arm64_x86_64-simulator
│       └── OrderedSet.framework
│           ├── Headers
│           ├── Info.plist
│           ├── Modules
│           ├── OrderedSet
│           └── _CodeSignature
├── flutter_inappwebview.xcframework
│   ├── Info.plist
│   ├── ios-arm64
│   │   ├── dSYMs
│   │   │   └── flutter_inappwebview.framework.dSYM
│   │   └── flutter_inappwebview.framework
│   │       ├── Headers
│   │       ├── Info.plist
│   │       ├── Modules
│   │       ├── WebView.storyboardc
│   │       └── flutter_inappwebview
│   └── ios-arm64_x86_64-simulator
│       └── flutter_inappwebview.framework
│           ├── Headers
│           ├── Info.plist
│           ├── Modules
│           ├── WebView.storyboardc
│           ├── _CodeSignature
│           └── flutter_inappwebview
└── webview_flutter_wkwebview.xcframework
    ├── Info.plist
    ├── ios-arm64
    │   ├── dSYMs
    │   │   └── webview_flutter_wkwebview.framework.dSYM
    │   └── webview_flutter_wkwebview.framework
    │       ├── Headers
    │       ├── Info.plist
    │       ├── Modules
    │       └── webview_flutter_wkwebview
    └── ios-arm64_x86_64-simulator
        └── webview_flutter_wkwebview.framework
            ├── Headers
            ├── Info.plist
            ├── Modules
            ├── _CodeSignature
            └── webview_flutter_wkwebview

69 directories, 32 files

➜  FlutterPluginRegistrant.framework git:(main) ✗ file FlutterPluginRegistrant
FlutterPluginRegistrant: current ar archive random library

➜  Flutter.framework git:(main) ✗ file Flutter
Flutter: Mach-O 64-bit dynamically linked shared library arm64

➜  App.framework git:(main) ✗ file App
App: Mach-O universal binary with 1 architecture: [arm64:Mach-O 64-bit dynamically linked shared library arm64]
App (for architecture arm64):	Mach-O 64-bit dynamically linked shared library arm64

➜  flutter_inappwebview.framework git:(main) ✗ file flutter_inappwebview
flutter_inappwebview: Mach-O 64-bit dynamically linked shared library arm64

➜  OrderedSet.framework git:(main) ✗ file OrderedSet
OrderedSet: Mach-O 64-bit dynamically linked shared library arm64

➜  webview_flutter_wkwebview.framework git:(main) ✗ file webview_flutter_wkwebview
webview_flutter_wkwebview: Mach-O 64-bit dynamically linked shared library arm64

Notice this, we can see FlutterPluginRegistrant is a static framework and others are dynamic. Taking a look at Embed the frameworks, it looks like this feature hasn't been supported yet (see https://github.com/flutter/flutter/issues/52217).
Labeling the issue for further insights.

flutter doctor -v (stable and master)
[✓] Flutter (Channel stable, 3.7.7, on macOS 13.0.1 22A400 darwin-x64, locale en-EE)
    • Flutter version 3.7.7 on channel stable at /Users/huynq/Documents/GitHub/flutter
    • Upstream repository https://github.com/flutter/flutter.git
    • Framework revision 2ad6cd72c0 (10 hours ago), 2023-03-08 09:41:59 -0800
    • Engine revision 1837b5be5f
    • Dart version 2.19.4
    • DevTools version 2.20.1

[✓] Android toolchain - develop for Android devices (Android SDK version 31.0.0)
    • Android SDK at /Users/huynq/Library/Android/sdk
    • Platform android-33, build-tools 31.0.0
    • ANDROID_HOME = /Users/huynq/Library/Android/sdk
    • Java binary at: /Applications/Android Studio.app/Contents/jbr/Contents/Home/bin/java
    • Java version OpenJDK Runtime Environment (build 11.0.15+0-b2043.56-8887301)
    • All Android licenses accepted.

[✓] Xcode - develop for iOS and macOS (Xcode 14.1)
    • Xcode at /Applications/Xcode.app/Contents/Developer
    • Build 14B47b
    • CocoaPods version 1.11.3

[✓] Chrome - develop for the web
    • Chrome at /Applications/Google Chrome.app/Contents/MacOS/Google Chrome

[!] Android Studio
    • Android Studio at /Applications/Android Studio Preview.app/Contents
    • Flutter plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/9212-flutter
    • Dart plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/6351-dart
    ✗ Unable to find bundled Java version.
    • Try updating or re-installing Android Studio.

[✓] Android Studio (version 2022.1)
    • Android Studio at /Applications/Android Studio.app/Contents
    • Flutter plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/9212-flutter
    • Dart plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/6351-dart
    • Java version OpenJDK Runtime Environment (build 11.0.15+0-b2043.56-8887301)

[✓] IntelliJ IDEA Community Edition (version 2022.1.1)
    • IntelliJ at /Users/huynq/Library/Application Support/JetBrains/Toolbox/apps/IDEA-C/ch-0/221.5591.52/IntelliJ IDEA CE.app
    • Flutter plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/9212-flutter
    • Dart plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/6351-dart

[✓] VS Code (version 1.76.0)
    • VS Code at /Applications/Visual Studio Code.app/Contents
    • Flutter extension version 3.60.0

[✓] Connected device (2 available)
    • macOS (desktop) • macos  • darwin-x64     • macOS 13.0.1 22A400 darwin-x64
    • Chrome (web)    • chrome • web-javascript • Google Chrome 110.0.5481.177

[✓] HTTP Host Availability
    • All required HTTP hosts are available

! Doctor found issues in 1 category.

[!] Flutter (Channel master, 3.9.0-1.0.pre.144, on macOS 13.0.1 22A400 darwin-x64, locale en-EE)
    • Flutter version 3.9.0-1.0.pre.144 on channel master at /Users/huynq/Documents/GitHub/flutter_master
    ! Warning: `flutter` on your path resolves to /Users/huynq/Documents/GitHub/flutter/bin/flutter, which is not inside your current Flutter SDK checkout at /Users/huynq/Documents/GitHub/flutter_master. Consider adding /Users/huynq/Documents/GitHub/flutter_master/bin to the front of your path.
    ! Warning: `dart` on your path resolves to /Users/huynq/Documents/GitHub/flutter/bin/dart, which is not inside your current Flutter SDK checkout at /Users/huynq/Documents/GitHub/flutter_master. Consider adding /Users/huynq/Documents/GitHub/flutter_master/bin to the front of your path.
    • Upstream repository https://github.com/flutter/flutter.git
    • Framework revision ac550c6356 (39 minutes ago), 2023-03-09 21:59:21 -0500
    • Engine revision e9ca7b2c45
    • Dart version 3.0.0 (build 3.0.0-313.0.dev)
    • DevTools version 2.22.2
    • If those were intentional, you can disregard the above warnings; however it is recommended to use "git" directly to perform update checks and upgrades.

[✓] Android toolchain - develop for Android devices (Android SDK version 31.0.0)
    • Android SDK at /Users/huynq/Library/Android/sdk
    • Platform android-33, build-tools 31.0.0
    • ANDROID_HOME = /Users/huynq/Library/Android/sdk
    • Java binary at: /Applications/Android Studio.app/Contents/jbr/Contents/Home/bin/java
    • Java version OpenJDK Runtime Environment (build 11.0.15+0-b2043.56-8887301)
    • All Android licenses accepted.

[✓] Xcode - develop for iOS and macOS (Xcode 14.1)
    • Xcode at /Applications/Xcode.app/Contents/Developer
    • Build 14B47b
    • CocoaPods version 1.11.3

[✓] Chrome - develop for the web
    • Chrome at /Applications/Google Chrome.app/Contents/MacOS/Google Chrome

[!] Android Studio
    • Android Studio at /Applications/Android Studio Preview.app/Contents
    • Flutter plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/9212-flutter
    • Dart plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/6351-dart
    ✗ Unable to find bundled Java version.
    • Try updating or re-installing Android Studio.

[✓] Android Studio (version 2022.1)
    • Android Studio at /Applications/Android Studio.app/Contents
    • Flutter plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/9212-flutter
    • Dart plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/6351-dart
    • Java version OpenJDK Runtime Environment (build 11.0.15+0-b2043.56-8887301)

[✓] IntelliJ IDEA Community Edition (version 2022.1.1)
    • IntelliJ at /Users/huynq/Library/Application Support/JetBrains/Toolbox/apps/IDEA-C/ch-0/221.5591.52/IntelliJ IDEA CE.app
    • Flutter plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/9212-flutter
    • Dart plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/6351-dart

[✓] VS Code (version 1.76.1)
    • VS Code at /Applications/Visual Studio Code.app/Contents
    • Flutter extension version 3.60.0

[✓] Connected device (2 available)
    • macOS (desktop) • macos  • darwin-x64     • macOS 13.0.1 22A400 darwin-x64
    • Chrome (web)    • chrome • web-javascript • Google Chrome 110.0.5481.177

[✓] Network resources
    • All expected network resources are available.

! Doctor found issues in 2 categories.

/cc @jmagman: to help to correct this if any of the above steps/information are incorrect (as I see your comment at https://github.com/flutter/flutter/issues/110562#issuecomment-1233274648). Thank you!

Yes right. I was able to resolve this issue after selecting Do not Embed for FlutterPluginRegistrant.xcframework, as it is a static framework.
Thanks for your support.

Ah yeah, it works, I forgot to try that case :). I just tested it and see it works now. I will close this issue in favor of https://github.com/flutter/flutter/issues/52217. Please follow up on that issue for further updates.

Thanks for helping debug @huycozy.  However this isn't a duplicate of https://github.com/flutter/flutter/issues/52217, FlutterPluginRegistrant.xcframework is a static framework on purpose, and there's no plans to make it dynamic.  See https://github.com/flutter/flutter/pull/40401

Thanks for clarifying this :)


Module refactors (WFLY-17684, WFLY-17918)

This is a combination of #16786 and #16833. Meant to test the combination and it resolves the merge conflict between the two.

#16833 was merged independently so I'm going to close this. #16786 is the for the other part.


ThrowOnWarnings = true should make esbuild return non-zero exit code

https://github.com/robinloeffel/esbuild-plugin-eslint/blob/main/source/index.ts#L49
In this line you need to return the 'errros' attribute so that esbuild will throw an exception. Additionally the throwOnErrors should be 'true' by default I feel.

oh shoot, you are absolutely correct about the throwOnWarning && !throwOnError! that is now fixed.
however, i disagree with you, that throwOnError should be true as per default. that seems too opinionated to me, and may confuse new or existing users. "my build worked before adding this plugin, but without it, it doesn't? guess i'll remove the plugin again!"

@glensc why? there hasn't been new functionality since v0.3.0, only a strictly internal rewrite and big fixes

@robinloeffel by semver every bump in 0.x series of the "minor" position is allowed to make breaking changes.
I don't care about the change itself at all, I'm still trying to figure out the purpose of this plugin.

oh shoot, you are absolutely correct about the throwOnWarning && !throwOnError! that is now fixed. thank you once more!
however, i disagree with you, that throwOnError should be true as per default. that seems too opinionated to me, and may confuse new or existing users. "my build worked before adding this plugin, but with it, it doesn't? guess i'll remove the plugin again!"

My take on this, is that someone who wants to use esbuild wants also to enforce the errors at least. Otherwise they just depend on the developers being nice to take a look at the output and fix the issues. But up to you, since it's configurable I think it does not matter.

@robinloeffel hey I just tested the latest release and unfortunately this is not fixed as I expected. THe problem is when throwOnError: true and throwOnWarning: true as well. This is the scenario when a user, wants esbuild to exit with non-zero code with either warnings or errors.
It's honestly not a normal scenario, that someone wants to throw only on warning but not on errors. So this issue needs one more go. Can you please re-open it?

Did not test it, but the code could be rewritten to something like to have the expected  behavior imo.
` `` js
return {
...warnings.length > 0 && { [throwOnWarnings ? 'errors' : 'warnings']: warnings },
...errors.length > 0 && { [throwOnErrors ? 'errors' : 'warnings']: errors },
}

So I rethought of this whole thing - and I believe we should not return the output of eslint into the errors/warnings back to esbuild.. Right now the errors are duplicated, from the console output and the esbuild failure. That's unnecessary and rather annoying especially if there many files contaning errors. It's enough to console logs the output, then the errors/warnings prop can contain only a dummy message.
Here is an example of the current output (see how much space the output duplication takes)
[kkoukiou@sequioa cockpit-podman]$ npm run build

> build
> node build.js

/home/kkoukiou/repos/cockpit-podman/src/Containers.jsx
  3:1  error  More than 1 blank line not allowed  no-multiple-empty-lines

/home/kkoukiou/repos/cockpit-podman/src/DynamicListForm.jsx
  3:1  error  More than 1 blank line not allowed  no-multiple-empty-lines

✖ 2 problems (2 errors, 0 warnings)
  2 errors and 0 warnings potentially fixable with the `--fix` option.

✘ [ERROR] More than 1 blank line not allowed. [plugin eslint]

    /home/kkoukiou/repos/cockpit-podman/src/Containers.jsx:3:0:
      3 │
        ╵ ^

✘ [ERROR] More than 1 blank line not allowed. [plugin eslint]

    /home/kkoukiou/repos/cockpit-podman/src/DynamicListForm.jsx:3:0:
      3 │
        ╵ ^

2 errors
/home/kkoukiou/repos/cockpit-podman/node_modules/esbuild/lib/main.js:1636
  let error = new Error(`${text}${summary}`);
              ^

Error: Build failed with 2 errors:
/home/kkoukiou/repos/cockpit-podman/src/Containers.jsx:3:0: ERROR: [plugin: eslint] More than 1 blank line not allowed.
/home/kkoukiou/repos/cockpit-podman/src/DynamicListForm.jsx:3:0: ERROR: [plugin: eslint] More than 1 blank line not allowed.
    at failureErrorWithLog (/home/kkoukiou/repos/cockpit-podman/node_modules/esbuild/lib/main.js:1636:15)
    at /home/kkoukiou/repos/cockpit-podman/node_modules/esbuild/lib/main.js:1048:25
    at /home/kkoukiou/repos/cockpit-podman/node_modules/esbuild/lib/main.js:1512:9
    at process.processTicksAndRejections (node:internal/process/task_queues:95:5) {
  errors: [
    {
      id: '',
      pluginName: 'eslint',
      text: 'More than 1 blank line not allowed.',
      location: {
        file: '/home/kkoukiou/repos/cockpit-podman/src/Containers.jsx',
        namespace: '',
        line: 3,
        column: 0,
        length: 0,
        lineText: '',
        suggestion: ''
      },
      notes: [],
      detail: -1
    },
    {
      id: '',
      pluginName: 'eslint',
      text: 'More than 1 blank line not allowed.',
      location: {
        file: '/home/kkoukiou/repos/cockpit-podman/src/DynamicListForm.jsx',
        namespace: '',
        line: 3,
        column: 0,
        length: 0,
        lineText: '',
        suggestion: ''
      },
      notes: [],
      detail: -1
    }
  ],
  warnings: []
}

So I propose, to never return the eslint output to esbuild - rather only print it in the console. Then the return value should looks like:
      return {
        ...warnings.length > 0 && { [throwOnWarnings ? 'errors' : 'warnings']: "Eslint warnings were found" },
        ...errors.length > 0 && { 'errors': "Eslint errors were found" },
        }

This code snippet above ignores the throwOnError property - as I believe it's redundant - and I would like to try to convince you once more about that.
eslint itself failes with non-zero exit code on errors
[kkoukiou@sequioa cockpit-podman]$ ./node_modules/eslint/bin/eslint.js src/Containers.jsx

/home/kkoukiou/repos/cockpit-podman/src/Containers.jsx
  3:1  error  More than 1 blank line not allowed  no-multiple-empty-lines

✖ 1 problem (1 error, 0 warnings)
  1 error and 0 warnings potentially fixable with the `--fix` option.

[kkoukiou@sequioa cockpit-podman]$ echo $?
1

By providing the throwOnErrors property and default it to 'false' you override that default behavior, which I believe is not correct.
Additionally eslint offers another option called max-warnings.
  --max-warnings Int              Number of warnings to trigger nonzero exit code - default: -1

That's somehow doing what 'throwOnWarning' does if you set it to 0. So I suggest to also remove throwOnWarning and introduce a maxWarnings property - in order to reflect what eslint offers.
So with my new proposal which is 100% aligned to what eslint does the code should look:
      return {
        ...warnings.length > 0 && { [maxWarnings < warnings.length ? 'errors' : 'warnings']: "Eslint warnings were found" },
        ...errors.length > 0 && { 'errors': "Eslint errors were found" },
        }

hey @KKoukiou! thanks for all your feedback! i agree with you in the sense that forwarding all messages (meaning errors and warnings) to esbuild clutters up the console. i'll change the behavior to report just a dummy message back to esbuild.
however, i have to disagree with the rest of your points. if i were to go into the direction you're suggesting, i'd mix up the cli api and the node api. they're two different pairs of shoes. the node api, which is the one this, and every other eslint integration is using, doesn't have a maxErrors option, only the cli does, for example. eslint can't be configured in that way. here's an overview of the node options.
if you go further down the path of cli vs node api, you will notice that the node implementation doesn't fail when it encounters errors in the linted source code. if it did, it would throw, and i would have to use a try/catch block. only the cli does, as you've correctly stated.
both of the throw flags are strictly for the plugin itself, eslint doesn't do anything with them. the reason i've decided to add them, is feature parity between the esbuild plugin and other integrations. if you check out the official rollup plugin, for example, you will see the api is almost identical. the official webpack plugin has a different api, but allows the same behavior via fail flags.
none of them have the throw or fail options enabled as per default. it would just be too obtrusive during everyday development. if you wish to enable it for ci/cd environments, you can, and most definitely should. but for a default, it's too aggressive, and not what people would expect.


assets  folder might be skip from the npm package

It's a quite big folder used in dev process for producing the polymer element, seems not useful in production.

Fixed by 68a01ce


Consider different figure style for different type of plots

Does this mean replicating glidertest.mplstyle?
I think this could be a good idea.  One problem at present is that some figures need a different aspect ratio in order to plot well.  E.g., plot_vertical_speeds_with_histograms() looks fine with the figsize 14,10.  But plot_ts() looks wonky.
Solution could be

to tailor as many glidertest_*.mplstyle as there are figures (which defeats the purpose)
agree a small number (4) of total styles, and massage each figure/plotting function to fit.

It may be worth thinking about this at the same time as thinking about generating a "glidertest summary" or some other standard output, and what format that would take.  Might need a separate issue.  Chiara and I chatted about this briefly--that there could be the option to run glidertest from the command line which would take as input the OG1 *.nc file, automatically run a default set of tests/checks and figures based on the data variables/sensors available in the file, and then generate an output (e.g. PDF format, readable in landscape as a slide deck).
Argument for landscape/slide deck mean that it can easily be used e.g. in meetings to discuss the data, and really sets some stringent requirements on readability (that folks are often willing to overlook in a portrait-type PDF).  And if you want a more compressed printed form, you can just put two slides to a page.
If this summary output is one of the desired outputs from glidertest, then it may help set constraints on the figures to be generated.

I think the idea of a landscape slideshow format report is a good guiding principle to how glidertest figures should look. I am also very drawn to the idea of mass producing little interactive jupyter notebook reports for each dataset.
From a technical standpoint, we should be able to take the demo notebook and convert it into slides using RISE. These interactive slides can also be exported to netcdf. I'll knock together a demo

The weird TS needs to be resolved but it looks to me like you so want it squared are forcing the size?
@eleanorfrajka
# Adjust the width of ax[1] to match the size of the frame of ax[2]
box1 = ax[1].get_position()
box2 = ax[2].get_position()
dw = box1.width-box2.width
ax[1].set_position([box1.x0+dw, box1.y0, box2.width, box1.height])
# Adjust the height of ax[2] to match the width of ax[0]
box0 = ax[0].get_position()
dh = box0.height - box2.height
ax[2].set_position([box2.x0, box2.y0 - dh, box2.width, box0.width])
# Adjust the height of ax[2] to match the width of ax[0]
box0 = ax[0].get_position()
box2 = ax[2].get_position()
fig_width, fig_height = fig.get_size_inches()
new_height = box0.width *  fig_width / fig_height
ax[2].set_position([box2.x0, box2.y0, box2.width, new_height])

Yeah, so this is an attempt to make the printed axis size the same for the two subplots.  That way, the ticks are the same distance apart and you could, in theory, cut out the plot and hold it up to a window to overlay things.
So -- the width of the TS plot (in salinity) is the same size as the width of the histogram of salinity only, and the height of the TS plot is the same length as the width of the histogram of temperature only.
I did something like this in the plot_vertical_speeds_with_histograms() plot.  The lower left axes will always be smaller than or equal to the top left axes.  So I shrunk the size of the lower left axes so that the tick marks are the same distance apart.  It's finicky, and picky, and not strictly necessary.  But this way the visual representations of the data are more similar.
It's a bit like this plot from Louis, where the 1-d histogram plots have been rotated so that the axes align:


feat: Scan cards share the same UI

Hi everyone!
This is a big PR with changes to 39 files (new code + renaming).
⚠ I haven't translated anything into English. It would be nice if you could do it.
🎥 Video: https://youtu.be/K1lqRVUxayo
What's new

All scan cards share the same UI
If a barcode was syntactically incorrect, there was simply no card, no error… (fixed ✅)
In the code, there were some classes with duplicate names  (fixed ✅)
In the code, there was an unused "Thanks" state (removed 🗑)
My PR will ease the removal of the carousel (💣)

Side quests:

The Hero animation works between the carousel / product page / gallery / details (cf video)

From the carousel, the product page shows a minimize button:

The Compare button on the scanner uses the correct icon:

Product found
The obsolete icon is visible from the carousel. Is-it useful (cc @teolemon?)

Loading
The animation is still used:

New product

Error (network)

Error (invalid barcode)

List of changes:
product_title_card.dart: Pass the heroTag to the picture + use the same layout for all cards (except in the onboarding, where the image is hidden)
smooth_product_base_card.dart: The base card for all scan cards + shared Widgets
smooth_card.dart: The Container is replaced by a Padding (faster)
product_compatibility_helper.dart: Help to format the score with at least 2 digits
strings_helper.dart: Code moved
app_navigator.dart: Provide the back button type for the product page
reinvention_page.dart: Nothing relevant - OnboardingText is moved elsewhere
edit_product_page.dart: A generic barcode Widget is now available
product_compatibility_header.dart: Not used anymore
product_image_viewer.dart: A fix for multiple Heroes animations

Codecov Report
Attention: Patch coverage is 0.80483% with 493 lines in your changes missing coverage. Please review.

Project coverage is 6.81%. Comparing base (4d9c7fc) to head (522ab94).
Report is 480 commits behind head on develop.

Files with missing lines
Patch %
Lines

.../cards/product_cards/smooth_product_base_card.dart
0.00%
112 Missing :warning:

packages/smooth_app/lib/widgets/smooth_text.dart
0.00%
68 Missing :warning:

...cards/product_cards/smooth_product_card_found.dart
0.00%
35 Missing :warning:

.../smooth_app/lib/widgets/smooth_barcode_widget.dart
0.00%
35 Missing :warning:

...ges/smooth_app/lib/pages/product/summary_card.dart
0.00%
33 Missing :warning:

...pp/lib/cards/product_cards/product_title_card.dart
0.00%
29 Missing :warning:

...cards/product_cards/smooth_product_card_error.dart
0.00%
22 Missing :warning:

...s/smooth_app/lib/pages/scan/scan_product_card.dart
0.00%
20 Missing :warning:

...s/product_cards/smooth_product_card_not_found.dart
0.00%
19 Missing :warning:

...rds/product_cards/smooth_product_card_loading.dart
0.00%
16 Missing :warning:

... and 19 more

Additional details and impacted files
@@            Coverage Diff             @@
##           develop   #5866      +/-   ##
==========================================
- Coverage     9.54%   6.81%   -2.74%
==========================================
  Files          325     428     +103
  Lines        16411   23637    +7226
==========================================
+ Hits          1567    1611      +44
- Misses       14844   22026    +7182

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

@g123k small merge conflict

@g123k small merge conflict

Fixed 👌


⚠ Processors has degraded performance

In fddfc65, Processors ($STATUS_URL) experienced degraded performance:

HTTP code: 200
Response time: 43 ms

Resolved: Processors performance has improved in 5526c66.