Asking for a collider when adding DockPosition.cs to a dock children

Hi everyone! Hoping you are all doing well wherever you are.
Describe the bug
When creating a dock from scratch, adding the DockPosition.cs to the child of the Dock.cs object is considered as an invalid operation. It is then required to add a Collider component to child object.
To reproduce

Create an empty gameObject (the Dock)
Add the Dock.cs component to it
Create an empty gameObject, child of the Dock gameObject
Add the DockPosition.cs component to it

Expected behavior
The same result as in the DockExample scene : children without any component but the DockPosition.cs
Screenshots

Your setup

Unity 2019.4.0f1 (LTS)
MRTK v2.4
Legacy XR pipeline (not on the new Unity XR pipeline)

Target platform

HoloLens 2
UWP

Additional info
The dock from the example scene is working as intended.

@robertos I'm guessing this line was added after the example scene was made:
[RequireComponent(typeof(Collider), typeof(Rigidbody))]

I think the right thing here is just to update the example scenes to have the box collider - it's righteous I think to require people to explicitly add a collider for the dock (i.e. that's how the docking happens). I guess the tradeoff here is there's an extra step (i.e. ensuring the object has a collider) but I think that in general automagic is less good than not automagic.


Question on implementation details

Hi guys! I have a somewhat strange question about the details of implementing Redux approach. Imagine, that you have a TabBar with 3 tabs. Every tab is the same UIViewController subclass. And the question is, how would you specify which view controller should subscribe to which part of state?

Hi! For example, you could define an identifier for each instance of the subclass, and then use it to query the state of your app. Depending on the shape of each substate, you can abstract more or less the way you access them.

That's pretty much way I thought it in my head 😃

Hey guys, can you show example?


Closed Alpha testing

Please leave a comment if:

you have prior experience with foundry

A few things we want tested:

dice rolling

does it make sense, does it fit the purpose?
is there usecases not fulfilled?

sheets

how does the sheets work?
should we modify something?

localization

does the system work with the supported languages?

compendiums

are the compendium items correct?

Please also comment with what you'll focus on!

I'd like to help out, but I'm not actually sure I can install the system as-is.  If I just download the code and put it in my systems dir, it doesn't show up (I assume because system.json isn't in the root.)
I'm assuming the gulp stuff "compiles" things into a working system, but I don't know how to use gulp.  I'm on Windows 10 if that matters.  Any pointers?

Hi!
I've been using Foundry since day one of public release and have run 5e, pf2e, Savage Worlds, and Alien in it, so I've seen some various solutions to sheets, die rolls, et cetera. I've done very basic coding of rule elements and active effects inside the game systems to homebrew items, but I am not a programmer.
I would love to be able to help test. I can focus on pretty much anything besides localization, but if I had to pick a single area, it would be sheets.

I have plenty of foundry experience with a wide variety of OSR and OSR-adjacent systems.
I also have a software dev background.
As far as testing, I can focus on anything other than localization.

I would love to volunteer for a closed alpha. I‘ve been using Foundry since 2021, building my own systems with sandbox system builder and custom system builder as well as using a variety of different systems. My GMing background has a strong emphasis on DnD 5e, but I also GM OSR systems. I‘ve already used the CSB to implement my own version of Shadowdark.
My  professional background is in Software Requirements Engineering for web-based applications.
Also, I could give feedback on the German localization.

OK, so I've gone through the compendia.  Should I create a ticket with my findings?

@git-steve-git   : Yes please!

I've used Foundry for several years and have used it for all my 5E D&D games - even in person using a TV as a game table.
I have a decent amount of knowledge regarding how Foundry's systems are intended to function, as well as a minor background in both language editing and UI design.

Hello! I have been using foundry for around 3 years now. Used more systems than I can count. Would like to be included in the alpha and give feedback

Hi! I’m relatively new to Foundry, but I’ve already created a basic sheet for a Champions Now game that I’m setting up and I’m very excited about Shadowdark. I’m happy to give your sheet a test drive and give you a relative newbie’s perspective, if you think that would be helpful.

I've used Foundry both as a GM and a player for 5E, DCC, and a little Lancer and Mausritter for the past 2 years or so. I don't have a software background, but I do manage product in my real life job. I would love to try out the ShadowDark Foundry. (I'm planning to use Foundry ShadowDark for a charity stream in May, if possible.)

I've been using Foundry for 5E and would love to help test Shadowdark's system. I can review compendium items if that helps.

No dev experience but have GMed a 5e game in Foundry the last 3 years and been a PC in another for 2 of those years. Sheets/rolling is what I would play with first but up for proofing compendium if that is most needed.

This is great news! Thanks so much for sharing this. Can you walk me
through the installation process?
All the best,
Aldo
On Thu, Mar 23, 2023 at 8:09 AM bakbakbakbakbak @.***>
wrote:

Looks like we have our first release to test:
https://github.com/Muttley/foundryvtt-shadowdark/releases/tag/release-0.9.0
—
Reply to this email directly, view it on GitHub
https://github.com/Muttley/foundryvtt-shadowdark/issues/29#issuecomment-1481081904,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/ACPBFA3OGNOTQCEY3QAAUHTW5Q4RLANCNFSM6AAAAAAVZAWUEA
.
You are receiving this because you commented.Message ID:
@.***>

Hmmm...
I thought I'd figured it out, but I got an error message when I entered the
manifest URL into the installer. Here's a screenshot of what I'm seeing:
[image: Shadowdark VTT Message Smaller.jpg]
Am I doing something wrong?
All the best,
Aldo
On Thu, Mar 23, 2023 at 11:18 AM Aldo Regalado @.***>
wrote:

Hey! Just a quick note to say that I figured it out. Thanks again!
On Thu, Mar 23, 2023 at 10:54 AM Aldo Regalado @.***>
wrote:

This is great news! Thanks so much for sharing this. Can you walk me
through the installation process?
All the best,
Aldo
On Thu, Mar 23, 2023 at 8:09 AM bakbakbakbakbak @.***>
wrote:

Looks like we have our first release to test:
https://github.com/Muttley/foundryvtt-shadowdark/releases/tag/release-0.9.0
—
Reply to this email directly, view it on GitHub
https://github.com/Muttley/foundryvtt-shadowdark/issues/29#issuecomment-1481081904,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/ACPBFA3OGNOTQCEY3QAAUHTW5Q4RLANCNFSM6AAAAAAVZAWUEA
.
You are receiving this because you commented.Message ID:
@.***>

Hi there,
I'm loving this character sheet!  I just rolled a BADASS 1st level Half Orc fighter!
I imagine that you already know this, but here are things I'm having issues
with:

It took me a second to figure out that I was supposed to type the
talent name in the space where it says "New Talent," but that's not a big
deal. I can type the info for the individual talents just fine in the
options provided, but I can't add the effects of talents to the rest of the
sheet. For example, Brolga (my Half Orc fighter) has Mighty (which gives
a +1 Hit and +1 Damage to Melee attacks), but I can't figure out how to get
it to express on the Melee Attacks section of the sheet.
I see that I can designate whether a talent comes from ancestry,
class, or level (which is cool), but I can't figure out what to do with the
Talent Type(s) option that sits under Talent Class. Hovering under that
gives me a box to click on, which opens up a whole host of options that I
can click on, but nothing seems to happen when I click on Save after making
my selections.
The "Level" option under talents seems redundant to me, as
technically all talents are related to a class level. Maybe I'm not
understanding what you have in mind for this?
There doesn't seem to be a way to add the Hauler bonus to gear slots
on the inventory page.

That's it for now! I'll keep playing around with it and sending feedback as
I go.
All the best,
Aldo
On Thu, Mar 23, 2023 at 1:12 PM Aldo Regalado @.***>
wrote:

Hey!
Now I really DID figure it out. I was under Add-Ons instead of Game
Systems.
Sorry about the confusion and chaos, and thanks again for sharing.
All the best,
Aldo
On Thu, Mar 23, 2023 at 1:09 PM Aldo Regalado @.***>
wrote:

Let me try to send the image as an attachment. If that doesn't work, I'll
try to describe what I'm seeing.
All the best,
Aldo
On Thu, Mar 23, 2023 at 1:00 PM Paul Maskelyne @.***>
wrote:

There's no image in your message. Are you seeing any errors in the
console?
—
Reply to this email directly, view it on GitHub
https://github.com/Muttley/foundryvtt-shadowdark/issues/29#issuecomment-1481552791,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/ACPBFA63H6P4Y7ZENAOPDM3W5R6TLANCNFSM6AAAAAAVZAWUEA
.
You are receiving this because you commented.Message ID:
@.***>

Thanks for the feedback:

It's easiest to drag the talent you want from the Talents compendium, that way all the Active Effects are set up for you.
See 1.
It's for sorting the list and so you can remember what level you took the talent at.
Drag the Hauler talent from the compendium (see 1).

We really need some system documentation, maybe that pops up first time you start a new world.
HTH.  :)

I can work on a Guide when I'm working on setting up the tests for Sheets and that level. I did put together a PoC for it for OSE already, and the biggest pain is finding all the DOM elements for it :)

Ah! All of that worked like a charm! Brolga is now complete, and all
elements are working well. I'm going to generate more characters and I'll
let you know if I come across anything else that's confusing, but this is
freaking AMAZING!
All the best,
Aldo
On Thu, Mar 23, 2023 at 2:37 PM bakbakbakbakbak @.***>
wrote:

I can work on a Guide when I'm working on setting up the tests for Sheets
and that level. I did put together a PoC for it for OSE already, and the
biggest pain is finding all the DOM elements for it :)
—
Reply to this email directly, view it on GitHub
https://github.com/Muttley/foundryvtt-shadowdark/issues/29#issuecomment-1481711136,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/ACPBFA4242AU737WPFEVWOTW5SJ7NANCNFSM6AAAAAAVZAWUEA
.
You are receiving this because you commented.Message ID:
@.***>

Actually, it seems that the Half-Orc's Mighty isn't adding the +1 damage to
melee weapons. However, it IS adding the +1 to hit with melee weapons.
All the best,
Aldo
On Thu, Mar 23, 2023 at 3:58 PM Aldo Regalado @.***>
wrote:

Ah! All of that worked like a charm! Brolga is now complete, and all
elements are working well. I'm going to generate more characters and I'll
let you know if I come across anything else that's confusing, but this is
freaking AMAZING!
All the best,
Aldo
On Thu, Mar 23, 2023 at 2:37 PM bakbakbakbakbak @.***>
wrote:

I can work on a Guide when I'm working on setting up the tests for Sheets
and that level. I did put together a PoC for it for OSE already, and the
biggest pain is finding all the DOM elements for it :)
—
Reply to this email directly, view it on GitHub
https://github.com/Muttley/foundryvtt-shadowdark/issues/29#issuecomment-1481711136,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/ACPBFA4242AU737WPFEVWOTW5SJ7NANCNFSM6AAAAAAVZAWUEA
.
You are receiving this because you commented.Message ID:
@.***>

It's either the Mighty or the Weapon Mastery (longsword). She should have
a +4 hit (which she does), but a +2 damage. She's only showing +1 damage.
On Thu, Mar 23, 2023 at 4:08 PM Aldo Regalado @.***>
wrote:

Actually, it seems that the Half-Orc's Mighty isn't adding the +1 damage
to melee weapons. However, it IS adding the +1 to hit with melee weapons.
All the best,
Aldo
On Thu, Mar 23, 2023 at 3:58 PM Aldo Regalado @.***>
wrote:

Ah! All of that worked like a charm! Brolga is now complete, and all
elements are working well. I'm going to generate more characters and I'll
let you know if I come across anything else that's confusing, but this is
freaking AMAZING!
All the best,
Aldo
On Thu, Mar 23, 2023 at 2:37 PM bakbakbakbakbak @.***>
wrote:

I can work on a Guide when I'm working on setting up the tests for
Sheets and that level. I did put together a PoC for it for OSE already, and
the biggest pain is finding all the DOM elements for it :)
—
Reply to this email directly, view it on GitHub
https://github.com/Muttley/foundryvtt-shadowdark/issues/29#issuecomment-1481711136,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/ACPBFA4242AU737WPFEVWOTW5SJ7NANCNFSM6AAAAAAVZAWUEA
.
You are receiving this because you commented.Message ID:
@.***>

Just a heads up.  I've made changes to the way the Stout effect is applied to fix the problem with manually changing the Max HP.  What this will mean is that you will need to delete the Stout talent from any characters added it to, and then re-add the updated version from the compendiums.
Once we go live this sort of thing will be handled by a proper upgrade process, but I've not written that yet, so it's manual all the way for now.  ;)

Hey there,
It's weird, but now Mighty isn't working at all. It WAS giving me a +1 to
hit (but not to damage). Now it's not giving me anything at all.
All the best,
AJR
On Fri, Mar 24, 2023 at 7:59 AM Paul Maskelyne @.***>
wrote:

Just a heads up. I've made changes to the way the Stout effect is applied
to fix the problem with manually changing the Max HP. What this will mean
is that you will need to delete the Stout talent from any characters added
it to, and then re-add the updated version from the compendiums.
Once we go live this sort of thing will be handled by a proper upgrade
process, but I've not written that yet, so it's manual all the way for now.
;)
—
Reply to this email directly, view it on GitHub
https://github.com/Muttley/foundryvtt-shadowdark/issues/29#issuecomment-1482688720,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/ACPBFA6XPSHKDRKWB3QLL2DW5WEB7ANCNFSM6AAAAAAVZAWUEA
.
You are receiving this because you commented.Message ID:
@.***>

Hey there, It's weird, but now Mighty isn't working at all. It WAS giving me a +1 to hit (but not to damage). Now it's not giving me anything at all. All the best, AJR

That is very weird, I just tried it out on a fresh character in a fresh world, and it is working. Are you using the pre-defined Mighty talent from the compendium? And have you updated to the latest version?

Hello there,
I am indeed using the predefined Mighty talent from the compendium. I'm
dragging and dropping it as you suggested. I'm doing the same with the
other talents, and they're working just fine.
I uninstalled the game, started a new one, and reentered Brolga.
Unfortunately, I'm having the same issue.
The only thing I can think is that I'm not updating to the most recent
version correctly? To update, I went to the Game Systems tab, went to the
Shadowdark RPG system, and clicked Update. Should I uninstall the system
and reinstall it? If so, is it the same manifest URL as before?
Sorry for the confusion.
All the best,
Aldo
On Fri, Mar 24, 2023 at 1:45 PM bakbakbakbakbak @.***>
wrote:

Hey there, It's weird, but now Mighty isn't working at all. It WAS giving
me a +1 to hit (but not to damage). Now it's not giving me anything at all.
All the best, AJR
That is very weird, I just tried it out on a fresh character in a fresh
world, and it is working. Are you using the pre-defined Mighty talent from
the compendium? And have you updated to the latest version?
—
Reply to this email directly, view it on GitHub
https://github.com/Muttley/foundryvtt-shadowdark/issues/29#issuecomment-1483185551,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/ACPBFA63XURUNVPUSJSAVOTW5XMTHANCNFSM6AAAAAAVZAWUEA
.
You are receiving this because you commented.Message ID:
@.***>

I just uninstalled the game system, reinstalled it using the same manifest
URL as before, opened the second game that I'd made to reenter Brolga, and
she's still having the same problem - she gets +1 hit but not +1 damage.
I then created a new character (Orko), gave him two different weapons
(Greatsword and Longsword), added Mighty - same thing.
I then created a new game entirely, created a new character with a mace,
added Mighty ... same thing.
Am I updating (or re-installing) incorrectly?
All the best,
Aldo
On Fri, Mar 24, 2023 at 3:19 PM Aldo Regalado @.***>
wrote:

Hello there,
I am indeed using the predefined Mighty talent from the compendium. I'm
dragging and dropping it as you suggested. I'm doing the same with the
other talents, and they're working just fine.
I uninstalled the game, started a new one, and reentered Brolga.
Unfortunately, I'm having the same issue.
The only thing I can think is that I'm not updating to the most recent
version correctly? To update, I went to the Game Systems tab, went to the
Shadowdark RPG system, and clicked Update. Should I uninstall the system
and reinstall it? If so, is it the same manifest URL as before?
Sorry for the confusion.
All the best,
Aldo
On Fri, Mar 24, 2023 at 1:45 PM bakbakbakbakbak @.***>
wrote:

Hey there, It's weird, but now Mighty isn't working at all. It WAS giving
me a +1 to hit (but not to damage). Now it's not giving me anything at all.
All the best, AJR
That is very weird, I just tried it out on a fresh character in a fresh
world, and it is working. Are you using the pre-defined Mighty talent from
the compendium? And have you updated to the latest version?
—
Reply to this email directly, view it on GitHub
https://github.com/Muttley/foundryvtt-shadowdark/issues/29#issuecomment-1483185551,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/ACPBFA63XURUNVPUSJSAVOTW5XMTHANCNFSM6AAAAAAVZAWUEA
.
You are receiving this because you commented.Message ID:
@.***>

Hello there, I am indeed using the predefined Mighty talent from the compendium. I'm dragging and dropping it as you suggested. I'm doing the same with the other talents, and they're working just fine. I uninstalled the game, started a new one, and reentered Brolga. Unfortunately, I'm having the same issue. The only thing I can think is that I'm not updating to the most recent version correctly? To update, I went to the Game Systems tab, went to the Shadowdark RPG system, and clicked Update. Should I uninstall the system and reinstall it? If so, is it the same manifest URL as before? Sorry for the confusion. All the best, Aldo

No it sounds like you're doing it correctly. Can you check the console if something is wrong there? I am unable to reproduce your problem as you're describing it unfortunately.

Closing as we're going to go live soon.  Any further issues can be raised as tickets and get put into the next release

Hello again,
By the console, do you mean the gears on the menu bar that take me to
configure settings, etc.? If so, I don't see any issues there.
HOWEVER, I've taken a closer look and I have some "good news" and some "bad
news".

The "bad news" is that the sheet still SHOWS a mere +1 damage for
Brolga and Orko's weapons, even though they should have +2.
The "good news" is that this seems to be a DISPLAY issue only. When I
click on the weapon, it rolls +2 hit AND damage, so it's doing its job.

That's good, but folks will be confused (and even suspicious) if it doesn't
display correctly. I know that some of my players will see that and want to
do a full audit of every roll. (That's more of a ME problem, I know.) :-)
All the best,
Aldo
On Fri, Mar 24, 2023 at 3:35 PM bakbakbakbakbak @.***>
wrote:

Hello there, I am indeed using the predefined Mighty talent from the
compendium. I'm dragging and dropping it as you suggested. I'm doing the
same with the other talents, and they're working just fine. I uninstalled
the game, started a new one, and reentered Brolga. Unfortunately, I'm
having the same issue. The only thing I can think is that I'm not updating
to the most recent version correctly? To update, I went to the Game Systems
tab, went to the Shadowdark RPG system, and clicked Update. Should I
uninstall the system and reinstall it? If so, is it the same manifest URL
as before? Sorry for the confusion. All the best, Aldo
No it sounds like you're doing it correctly. Can you check the console if
something is wrong there? I am unable to reproduce your problem as you're
describing it unfortunately.
—
Reply to this email directly, view it on GitHub
https://github.com/Muttley/foundryvtt-shadowdark/issues/29#issuecomment-1483315517,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/ACPBFA33TBGEDFIQ24UOJIDW5XZQDANCNFSM6AAAAAAVZAWUEA
.
You are receiving this because you commented.Message ID:
@.***>


Adding a router to localVue results in an error when using shallowMount

If you try to use a router with a localVue when calling shallowMount you will get the following error:
 TypeError: Cannot redefine property: $router
        at Function.defineProperty (<anonymous>)

      89 |   const { localVue, store, router } = setupLocalVue(modules);
      90 |
    > 91 |   return shallowMount(component, {
         |          ^
      92 |     store,
      93 |     router,
      94 |     localVue,

      at Function.install (node_modules/vue-router/dist/vue-router.common.js:1312:10)
      at Object.use (node_modules/@vue/compat/dist/vue.cjs.js:5908:28)
      at mount (node_modules/@vue/test-utils/dist/vue-test-utils.cjs.js:7860:25)
      at call (node_modules/@vue/test-utils/dist/vue-test-utils.cjs.js:7934:12)
      at patchedMount (node_modules/vue-test-utils-compat/src/index.js:123:35)
...

Steps to reproduce:

Create an instance of a Vue 2 router
Create localVue using createLocalVue from test-utils
Pass that instance to localVue instance as the following:

localVue.use(VueRouter)
const routerInstance = new Router(routes)
const localVue = createLocalVue()
shallowMount({
  localVue,
  router,
})

This is code is valid in Vue 2, but fails in compat mode.

Similarly, passing store to mount/shallowMount doesn't work either. I think these options only worked prior because of VTU1's option merging behavior, but they're common enough patterns (and have easy shims, since they just need to be rewritten into plugins) that I think this package should handle them.


MAINTAINERS: fix missing asterisk for STM32 driver matching

There is a missing asterisk for one of the driver matching pattern for STM32. So fix that.

I wasn't feeling I was missing incoming reviews, but thanks anyway !


fix(kinput): add show-masking-toggle prop [KHCP-13466]

Summary
Addresses: https://konghq.atlassian.net/browse/KHCP-13466
Add showMaskingToggle prop which allows toggling masking on and off when type="password"

And long text is overlapping with the button.

We may want to turn off the built-in password reveal for Edge in case its toggle button overlaps with ours. (Edge has a strategy that only shows the toggle button if you start typing from nothing.)

https://learn.microsoft.com/en-us/microsoft-edge/web-platform/password-reveal#remove-the-password-reveal-control

Fixed


HNC: cannot delete subns in 1.14

Repro at head:
$ k hns create sub -n default
$ k delete subns sub -n default

Log messages show that the webhook is failing because we can't decode the old object. We should be skipping this.
If it turns out that this is actually working in 0.5, then we can change the milestone back to 0.6.

This is due to the new object validator; the 0.5 validator didn't check deletions at all.
Why the object validator is being invoked on a namespace with no objects in it is somewhat of a mystery to me, but this definitely works on 1.16 and definitely does not work on 1.14. Since the code is obviously wrong, I'm going to go ahead and fix it.

Do you mean that the cannot decode is in the object validator but not namespace validator? We added 1.14 backward compatibility (allow deleting in 1.14) in namespace validator. To fix this issue, is it that we need to also add it to object validator?

Yeah. I don't understand it. Our namespace and anchor validators already handle a nil OldObject but the object validators didn't. This is a bug that needs to be fixed regardless, but I don't understand why the code was invoked when there were no objects at all.

Not sure if you've already noticed. Even deleting a full namespace (not subnamespace) doesn't work in 1.14 using the head before your fix #890 .


chore(lib): Use brcast instead of createBroadcast

Hi,
I've extracted the createBroadcast function into its own package.
https://www.npmjs.com/package/brcast
I use this patter a lot, so it made sense to me.
cheers

Hi @vesparny, thanks for the contribution. I wouldn't actually recommend using this pattern with React. When you broadcast stuff to circumvent sCU, you opt-out of the React paradigm and now you have to manage syncing state updates yourself. So I'm not really using or maintaining this package anymore. But thanks for the PR :)

yeah I see.
I meant that I use the createBroadcast pattern a lot outside of React apps.
:)


[WFLY-18211] Add version 3 of the elytron-oidc-client model and schema

https://issues.redhat.com/browse/WFLY-18211
Creating this as a draft PR for now since we have at least one RFE being worked on right now that needs this. This can be merged once we have an RFE that has been pre-checked.

Closing this one since this isn't needed right now.


internal/tmpl: fix static/dynamic invariants

I tried to preserve the invariants more carefully during tree construction. And fixed some assorted things that looked wrong while I poked around the code.
So far (about 10M runs), this passes the fuzz test I added in #19. I'll let it run for a while longer.
I had to "fix" a few golden tests, so maybe I busted something, though. I don't really understand the format when it comes to ranges. I'd be curious to see how it works in practice.

This is a lot of changes. But note that the core functionality change is actually net negative LOC.


fix failed docker build due to missing plugins

Description
Add conditional check when plugins are not ready.
Issues Resolved
Resolves https://github.com/opensearch-project/opensearch-build/issues/1154
Test
Downloaded a bundle 1.2.0 and removed the security and PA plugins. Verify that the same file not found error happened.
With this fix, we are able to run the docker build.
./build-image-single-arch.sh -v 1.2.0-fix-docker-build -f ./dockerfiles/opensearch.al2.dockerfile -p opensearch -a x64 -t ~/archive-without-plugins.tar.gz
This is the cmd output
Successfully built 7b583e175be1
Successfully tagged opensearchproject/opensearch:1.2.0-fix-docker-build
Attempt to rm /tmp/tmp.OC07sdoCJD
Removing /tmp/tmp.OC07sdoCJD

This is the docker ls
docker image ls

EPOSITORY                     TAG                                                            IMAGE ID       CREATED              SIZE
opensearchproject/opensearch   1.2.0-fix-docker-build                                         7b583e175be1   About a minute ago   738MB

Check List

[x] Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Codecov Report

Merging #1162 (1c0097a) into main (f6a46b1) will decrease coverage by 24.60%.
The diff coverage is n/a.

@@              Coverage Diff              @@
##               main    #1162       +/-   ##
=============================================
- Coverage     93.71%   69.11%   -24.61%
  Complexity       10       10
=============================================
  Files           100        8       -92
  Lines          2547       68     -2479
  Branches          9        9
=============================================
- Hits           2387       47     -2340
+ Misses          150       11      -139
  Partials         10       10

Impacted Files
Coverage Δ

src/manifests_workflow/component_opensearch_min.py

src/assemble_workflow/bundles.py

src/paths/script_finder.py

src/test_workflow/integ_test/service.py

src/test_workflow/test_recorder/log_recorder.py

src/build_workflow/build_artifact_checks.py

...ensearch_dashboards/build_artifact_check_plugin.py

src/test_workflow/test_component.py

src/manifests_workflow/component.py

src/assemble_workflow/assemble_args.py

... and 82 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f6a46b1...1c0097a. Read the comment docs.

@tianleh you should configure git with your email on the ubuntu machine, it shows your name as ubuntu@ - I typically use dotfiles on my hosts


Refactor/refactor sobo

replaces the if else statements to initialize various acquisition function types by get_acquisition_function from botorch

In addition, I implemented a way to add strategy specific hyperparams.


runc: 1.0.3 -> 1.1.0

Motivation for this change
Changelog is in a mix of the rc and main release.
https://github.com/opencontainers/runc/releases/tag/v1.1.0-rc.1
https://github.com/opencontainers/runc/releases/tag/v1.1.0
Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[x] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[x] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[x] Tested basic functionality of all binary files (usually in ./result/bin/)
22.05 Release Notes (or backporting 21.11 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module
[ ] (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes

[x] Fits CONTRIBUTING.md.

Duplicate of https://github.com/NixOS/nixpkgs/pull/155435

Result of nixpkgs-review pr 155441 run on x86_64-linux 1

10 packages built:

buildah
cri-o
hci
hercules-ci-agent
ignite
img
k3s
nvidia-podman
podman
runc

oops - sorry, missed that 😓


Added fallback-to-deploy flag in Update action

Addressing this issue https://github.com/ing-bank/flink-deployer/issues/34

Codecov Report

Merging #41 into master will decrease coverage by 0.12%.
The diff coverage is 73.33%.

@@            Coverage Diff             @@
##           master      #41      +/-   ##
==========================================
- Coverage   52.91%   52.78%   -0.13%
==========================================
  Files          13       13
  Lines         567      574       +7
==========================================
+ Hits          300      303       +3
- Misses        218      222       +4
  Partials       49       49

Impacted Files
Coverage Δ

cmd/cli/operations/update_job.go
85.36% <100%> (+0.36%)
:arrow_up:

cmd/cli/main.go
27.6% <20%> (-0.16%)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1b74114...97ef45c. Read the comment docs.

Hi, is there any reason this has not yet been merged? Regards /Johan

@jrask thanks for the nudge!


Dockstore with ~/.dockstore/config

Bug Report
Expected behaviour
If a config file is specified, dockstore should not be asking for token and server-url
Actual behaviour
Even though --config configFile is specified, dockstore asks for everything
Steps to reproduce the behaviour

Move your ~/.dockstore/config file to ~/.dockstore/config2
Run ./dockstore --config ~/.dockstore/config2 --version

Functional on staging with API 1.5.0-alpha.4, UI 2.2.0-alpha.3


Source map 404

When using 2.8dev (and 2.7.2), we see this error message in the Developer Tools Console:
Source map error: request failed with status 404
Resource URL: http://<IP_ADDRESS>:3000/css/style.css
Source Map URL: style.css.map

.*.map files are generated for development, and not usually transferred to production machines, though the reference to them remains in the compiled code. Your browser will only attempt to load these when the console is open, however. This error does not represent any issues.


QRCode box overlay

Is it possible to implement an overlay to show where the qrcode is in the camera feed? just like this https://www.appcoda.com/barcode-reader-swift/
Was wondering how can I get the videoPreviewLayer of the camera so I can use transformedMetadataObject

Hi @aabanaag - thanks for your comment!
So, funny enough, this existed in a previous pre-release build of Lumina. You can see the source code here.
I think I abandoned this because I got a bit obsessed with implementing the other newer stuff and re-organizing the architecture, and this didn't fit in immediately, especially differentiating between face detection and QR code detection. Also, I didn't see an immediate need for drawing a rect around it as detecting it was more necessary.
However, if there's a need for it, then I can definitely look at putting it back in 👍 let me know your thoughts.

well, initially I thought it would be needed as you can basically track the metadata within the camera feed but I think the best way to do it is add toggle for it because just like the native camera of the iPhone it doesn't track the qrcode. :)


Fiat - NFT payment plugin for wallets

Walletless
Grant category
Developer tools / services
Description
Fiat-NFT payment plugin for FLOW wallets
Problem statement

Accepting direct card payments for NFTs requires significant dev work
Currently, FLOW wallets require you to buy crypto first, then buy the NFT, paying twice the fees and taking double the time

Target audience

Wallets on FLOW wanting to offer direct card NFT checkouts for their users

Evidence for the need

Direct card-to-NFT purchases boosts sales by 300% (MoonPay survey)
Discussions with software engineers building wallets and infrastructure on FLOW

Proposed solution

Fiat-NFT payment solution that plugs into wallets on FLOW

Impact

Higher sales conversions for FLOW projects
Improved Wallet user experience

In what ways does this benefit the broader Flow developer ecosystem?

Save months of dev work
Handle FIAT payments for wallet providers
Handle fraudulent activities and offer chargeback guarantee

Milestones and funding

Note: You can leave the USD proposal empty / "TBD". Please consider adoption and/or maintenance milestones at the end of your project.

Milestone
Deliverables
Timeline
Risks
USD proposal

1 - Purchase Transaction Validator
API to determine payable amount based on transactions
3 weeks
-

2 - Collect Eligible Transactions
Collect set of eligible transactions from marketplaces and community
1 week
-

3 - Opensource Core Functionality
Opensource the core functionalities of the purchase transaction validator
1 week
-

4 - Developer Typescript SDK
- Typescript SDK for card payment for NFTs - SDK documentation
4 weeks

5 - Developer Android SDK
- Android SDK for card payment for NFTs - SDK documentation
4 weeks

6 - Testing
- Testing and bug fixing
2 weeks

7 - Example Integration
Integrate test plugin solution into the chrome extension wallet
0.5 week
-

8 - Adoption
1 wallet integrates the fiat payment - Gather feedback
1 week

9 - Maintenance
Supporting wallet providers, resolving issues
4 months

Team

Name
Role
Bio
Contact

Daniel N
Product
Oxford University Engineering scholar, Ex-BAML, experience in tech and finance
<EMAIL_ADDRESS>

Akos E
Architect and Full Stack
Engineer graduating in Germany, years in software development, technical leadership and architecture
<EMAIL_ADDRESS>

Mislav K
Front-end Engineer
Front-end experience for many start-ups, including web3

Paul F
Business Analyst
Accountant, ex-Deloitte, c-suite experience, background in finance and healthcare

Milestone completion

[x] Purchase Transaction Validator
[ ] Collect Eligible Transactions
[ ] Opensource Core Functionality
[ ] Developer SDKs
[ ] Testing and example integration
[ ] Adoption
[ ] Maintenance

In the spirit of transparancy can we update the grants to contain the rewards?


404 and Unauthorized API Errors

Describe the bug
Using the provided code in this repo, attempting to use Serverless API endpoint results in 404 when using run() method and Unauthorized when using the get_endpoints() method.
To Reproduce
Steps to reproduce the behavior:

Create a Runpod account
Create API keys
Launch a Serverless template
Copy/pasta code from this repo
Input your endpoint ID and api key
Run
Watch errors roll in

Expected behavior
A response from my API code, error or not, that is not an unsuccessful call.
Screenshots
Lol
Desktop (please complete the following information):

OS: OSX Sonoma
Current PIP install of Runpod module
Python 3.11
Functional internet connection

Additional context
Would like this to work so I don't have to use AWS.

We would love to have this work for you as well so you don't have to use AWS either :)
There's not much I can do with the "lol" screenshot, however, if you have an endpoint ID or additional context to work from I am sure we can resolve your issues quickly.

I appreciate you handling my frustration with grace.
Docker is and apparently always will be a disaster for me, I gave up on
that after finding this guide:
https://blog.runpod.io/runpod-serverless-no-docker-stress/
I was finally able to get a 200 response code, but then could not return a
proper json response while waiting for the instance to complete.
However, the nail in the coffin was when I jumped back to my endpoint
dashboard, I found two instances running for 2-3 minutes each without being
prompted to do so. Is this a common issue?
I decided to give up on it for the evening, but I don't think I can pursue
serverless with runpod if instances are going to run in the background and
eat up my $$.
Lots of problems to solve here (e.g. json response error, unprompted
instances), happy for any insight you can provide.
On Tue, Dec 19, 2023 at 9:44 PM Justin Merrell @.***>
wrote:

We would love to have this work for you as well so you don't have to use
AWS either :)
There's not much I can do with the "lol" screenshot, however, if you have
an endpoint ID or additional context to work from I am sure we can resolve
your issues quickly.
—
Reply to this email directly, view it on GitHub
https://github.com/runpod/runpod-python/issues/258#issuecomment-1863890383,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AKVLQKIWF5IGTTE35EGG33TYKJ3LXAVCNFSM6AAAAABA4IAOX6VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTQNRTHA4TAMZYGM
.
You are receiving this because you authored the thread.Message ID:
@.***>

No worries, I too struggled when first starting with docker. If you have not already joined our Discord I would encourage you to do so, it is easier to provide assistance there.
From what I can make out, it appears that you created a serverless endpoint, and sent a request but at some point, the worker failed to process or get the request. Since the request was still in the queue our system likely tried to spin up an additional worker to respond to the request.
The first step would be to share the code you are running so we can make sure everything looks correct there.
Note: Since this is not an issue directly related to the contents of this repository (runpod-python) I am going to close the issue, however I can continue to provide assistance if you respond even after it is marked as closed :)


Add design notes for XOF API.

Checklist

[x] documentation is added or updated
[ ] tests are added or updated

See the definition of XOF at the top. For this reason I dont think it is necessary,, I do mention aliases though.

@baentsch Is this sufficient for your use cases?

Note: https://github.com/openssl/openssl/blob/bda29f1106c55cbe3d1467909e5882255f620d6c/xof.md is the best way to view this..

Thanks for this well-documented proposal with pro and con argumentation.

Is this sufficient for your use cases?

I'll go through this in detail, but for starters, allow me to tag @jschank who contributed the current SHA3/API integration to liboqs in https://github.com/open-quantum-safe/liboqs/pull/922. Maybe also @dstebila has input.

Is this sufficient for your use cases?

I'll go through this in detail, but for starters, allow me to tag @jschank who contributed the current SHA3/API integration to liboqs in open-quantum-safe/liboqs#922. Maybe also @dstebila has input.

Ouch - wrong tag. Now for the correct @jschanck... Apologies.

@juergenchrist Can you confirm that s390 can handle multiple squeeze calls?

The assembly code is going to require some updates.  I remember looking at the x86/64 code a long while back and the change was straightforward from memory but would introduce a slowdown (although unlikely to be a significant one).

Can you confirm that s390 can handle multiple squeeze calls?

I think so.  But @holger-dengler should take a closer look at this proposal.

I'll go through this in detail, but for starters, allow me to tag @jschank who contributed the current SHA3/API integration to liboqs in open-quantum-safe/liboqs#922. Maybe also @dstebila has input.

I haven't had a chance to look at this.  In OQS we were mostly going with what was used in PQClean or in PQ implementations we pulled in that used XOF.  @cryptojedi or @thomwiggers might have opinions.

Please note that the following comment is not hindered by any knowledge of OpenSSL specifics. I'll just attempt to contribute some insights in what I have seen in the PQ implementations. The specifics of how this is implemented do not seem particularly important to me, as long as the names are clear.
In PQClean we at least have not seen the following pattern (and we do not support it):
absorb
finalize
squeeze
absorb some more
finalize again
squeeze again

So this does not need to be supported (and I don't think the current proposal does). Supporting this behaviour would require storing the pre-finalized and post-finalized states; but on the other hand, space is pretty cheap nowadays. So it could be considered if you want to allow every possible combination.
Having finalize as a separate step in between absorb and squeeze seems unnecessary.
Something which would be nice to have, as it is used in our implementation of SPHINCS+, is being able to copy the state of the hash function: SPHINCS+ does the following:
# precompute hash state:
ctx = absorb(prefix)

# later in computations:
ctx2 = ctx.clone()
ctx2.absorb(rest)
ctx2.squeeze(...)

Something which would be nice to have, as it is used in our implementation of SPHINCS+, is being able to copy the state of the hash function

This is already achieved by having EVP_MD_CTX_copy(_ex)() functions.

Something which would be nice to have, as it is used in our implementation of SPHINCS+, is being able to copy the state of the hash function

This is already achieved by having EVP_MD_CTX_copy(_ex)() functions.

I thought so, but thought it was good to mention.

The sha3 dupctx method copies all the state, so this will work.

Cleaned up..
Also added a section related to having XOF as a completely different API (The cons I think rule this out).

Apart from the related CI failures that need fixing I like this.

Do we care that we're borrowing terms from the Sponge Function definition and potentially reapplying them on hashes that aren't constructed that way (for example Blake2X, which we implement as a sort of extension of Blake2b as far as I can tell, but Blake2 isn't a sponge function)?
I don't care much, to be honest.  Absorb and Squeeze are fantastic terms in my mind, and should be perfectly usable for any hash that supports either (and at least Absorb is conceptually [seen in broad terms] supported by all hashes, even though not in the terms of the Sponge Function definition).  But maybe someone else does...

In the PR Shane wrote the Absorb term is used minimally. Squeeze is used in DigestSqueeze and frankly I cannot think of much better term even if the underlying hash is not a sponge construction. Maybe DigestExtract but...

In the PR Shane wrote the Absorb term is used minimally. Squeeze is used in DigestSqueeze and frankly I cannot think of much better term even if the underlying hash is not a sponge construction. Maybe DigestExtract but...

Alternative terms I can come up with is Accumulate and Extract

It may be better to just use the sponge related terms as it is probably less confusing..
e.g. HKDF also uses the terms extract (and expand).. i.e.
The first stage takes the input keying material and "extracts" from it a fixed-length pseudorandom key K.
The second stage "expands" the key K into several additional pseudorandom keys (the output of the KDF).
Should I just add these discussion comments to the design and leave as is?

I have removed the diagrams from this PR, they have moved to the implementation PR.

Can you confirm that s390 can handle multiple squeeze calls?

I think so. But @holger-dengler should take a closer look at this proposal.

I can confirm, that s390 instructions can handle multiple squeeze calls.

24 hours has passed since 'approval: done' was set, but this PR has failing CI tests.  Once the tests pass it will get moved to 'approval: ready to merge' automatically, alternatively please review and set the label manually.

Merged to the master branch. Thank you.


Add new workflows

Pull request checklist

[ ] Did you bump the project version?
[x] Did you add a description to the Pull Request?
[ ] Did you add new tests?
[x] Did you add reviewers?

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 89.22%. Comparing base (6f57015) to head (6b95b54).

Additional details and impacted files
@@            Coverage Diff             @@
##           master       #4      +/-   ##
==========================================
- Coverage   89.31%   89.22%   -0.10%
==========================================
  Files           4        4
  Lines         337      334       -3
==========================================
- Hits          301      298       -3
  Misses         36       36

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


(WIP) (PE-8657) Fix mount provider for AIX

The way that AIX tracks its mounted filesystems is different than other
unix or linux operatingsystems. AIX uses /etc/filesystems and has
entirely different filesystem options.
This commit takes advantage of two parsedfile hooks, post_parse and
to_line, to read & generate /etc/filesystem entries. Parsedfile was
not created with arbitrary-ordering in mind, and any /etc/filesystem
entries will have their attributes reordered by to_line
Options in AIX without related properties in Puppet's mount type are
placed under the "options" property.

WOW!! Awesome @hunner -- I'm super happy to see this addressed.
One comment, can you change the commit message to be prefixed with the public-facing ticket (PUP-1628) rather than the internal-only PE ticket? That way anyone can see the history not just PL folks.

All the :+1: s.  :smile:

CLA signed by all contributors.

Limitations:

It will reorder the filesystem attributes to a specific order (dev, nodename, vfs, then the rest alphabetic)
Comments embedded in a filesystem attribute list will cause the following ones to be dropped (but between filesystem entries is fine)
The options property is comma separated (fine) and must be in the order from the first bullet point, otherwise it will always try to update the value
The options property is overloaded with all of AIX's extra attributes; perhaps adding new properties to the type would be better

Hello Hunner, I've patched my parsed.rb and mount.rb with these changes.  What I'm seeing is that for "nodename" in /etc/filesystems the value is the entire string which is defined in the manifest "hostname:device" where it should just be "hostname".  So our /etc/filesystems look like this now:
/nfs/depot/someplace:
dev             = /nfs/depot/someplace <-- should be right side of a split on ":" of "nodename")
nodename  = nfsserver:/oracle_depot/mnt  <- should be left side of a split on ":" of "nodename")
vfs             = nfs
options      = nosuid,ro,soft
Should look like:
/nfs/depot/someplace:
dev = "/oracle_depot/mnt"  < -- correct
vfs = nfs
nodename = nfsserver <--- correct
mount = true
options = bg,soft,intr
account = false

Ok, so this works great.  Could you make one cosmetic change and put in one blank before each entry you put in /etc/filesystems?

@helperton Blank lines and comments are preserved across updates, so if you have blank lines before each entry, they should stay there. I'd rather not enforce blank lines before every entry, as some users may not prefer that style. Is that okay?

I think it's a requirement by IBM
https://www.ibm.com/developerworks/community/wikis/home?lang=en#!/wiki/Power+Systems/page/How+to+change+order+of+fs+mounts+on+AIX+V5.3
Filesystems are mounted at AIX boot time in the order they appear in /etc/filesystems. Filesystems are added to /etc/filesystems in the order they are defined. The easiest way to change the order in which filesystems are mounted is to edit /etc/filesystems and change the ordering of the filesystem stanzas. (But be careful to maintain a blank line between each stanza. If blank lines are removed, some filesystems won't get mounted at boot time!)

@helperton I read that three times and I'm still somewhat baffled. What do the blank lines signify? That advice says not to remove blank lines but not what they mean. It sounds like this is not a cosmetic change so I'm curious how it actually works.

Ya, I thought it was cosmetic until I found that article.  I was suspicious that all of our /etc/filesystems have that blank line, then when I looked at examples of /etc/filesystems on the internet I found those too, have the blank line.  Then I found the IBM article.

Here's another article which talks about the blank line (still doesn't answer your question).
http://bio.gsi.de/DOCS/AIX/2x/faqssoft.html

I can't find anything about it, but the examples I found have a blank line between stanzas. So probably better safe than sorry ....
Also in the surprising-to-a-non-AIX-admin department:

Note: The asterisk (*) is the comment character used in the /etc/filesystems file.

which I found in http://www-01.ibm.com/support/knowledgecenter/ssw_aix_71/com.ibm.aix.files/filesystems.htm

@helperton Oooo, okay. I'll update the PR with blank lines then. Thanks!

Newlines updated. The only issue I've seen still occurring is the mount -o remount <nfs mountpoint> causing failures after updating an NFS entry. It seems that it must be either remount,ro or remount,rw to work correctly.
The mount type previously just ran an unmount & mount instead of a remount, but this PR changes the default to do remount... How should this be solved?

Change back to unmount/remount
Leave with remount; this error is PEBKAC
Make the option default to unmount/mount for NFS volumes and remount for non-NFS volumes
Other

Ok, so it did fix the newline issue, but we now seem to have some issue with the option ordering and it saying that it's updated the options, but it's not actually reflected in /etc/filesystems.
During the puppet run:
Info: Retrieving pluginfacts
Info: Retrieving plugin
Info: Loading facts
Info: Caching catalog for somehost.domain.com
Info: Applying configuration version '0cfe3f36a46cb4ddc81f790626ffbf793245f2d3'
Notice: /Stage[main]/Puppet_nfs/Mount[/nfs/infra]/options: options changed 'bg,intr,soft' to 'bg,soft,intr'
Info: Computing checksum on file /etc/filesystems
Info: /Stage[main]/Puppet_nfs/Mount[/nfs/infra]: Scheduling refresh of Mount[/nfs/infra]
Info: Mount/nfs/infra: Remounting
Notice: /Stage[main]/Puppet_nfs/Mount[/nfs/infra]: Triggered 'refresh' from 1 events
Info: /Stage[main]/Puppet_nfs/Mount[/nfs/infra]: Scheduling refresh of Mount[/nfs/infra]
Notice: /Stage[main]/Puppet_nfs/Mount[/nfs/depot/aix]/options: options changed 'bg,intr,soft' to 'bg,soft,intr'
Info: /Stage[main]/Puppet_nfs/Mount[/nfs/depot/aix]: Scheduling refresh of Mount[/nfs/depot/aix]
Info: Mount/nfs/depot/aix: Remounting
Notice: /Stage[main]/Puppet_nfs/Mount[/nfs/depot/aix]: Triggered 'refresh' from 1 events
Info: /Stage[main]/Puppet_nfs/Mount[/nfs/depot/aix]: Scheduling refresh of Mount[/nfs/depot/aix]
Notice: /Stage[main]/Puppet_nfs/Mount[/nfs/depot/oracle]/options: options changed 'bg,intr,soft' to 'bg,soft,intr'
Info: /Stage[main]/Puppet_nfs/Mount[/nfs/depot/oracle]: Scheduling refresh of Mount[/nfs/depot/oracle]
Info: Mount/nfs/depot/oracle: Remounting
Notice: /Stage[main]/Puppet_nfs/Mount[/nfs/depot/oracle]: Triggered 'refresh' from 1 events
Info: /Stage[main]/Puppet_nfs/Mount[/nfs/depot/oracle]: Scheduling refresh of Mount[/nfs/depot/oracle]
Notice: Finished catalog run in 1.17 seconds
It keeps saying that it's changing the options, but it doesn't actually change them in the file, so the next puppet run outputs the exact same thing again.

@helperton Okay. I was sorting the list of options returned from /etc/filesystem (which is why it returned bg,intr,soft even though that wasn't the actual order). I removed that sort.
However, some "options" (account, boot, check, free, mount, size, type, vol, log, and quota) are passed to the mount type via the options parameter before being separated into their respective lines, and must be alphabetically sorted at the end of the comma-separated list to avoid this.

Bravo!  Works.

After another review, I'm still happy with this. :+1:

@hunner if this is going to get into Puppet 3.8, could you retarget this pull request against the 3.x branch? The stable branch now corresponds to 4.0 and master to 4.1.


Attaching to Existing Application using React-Native JS.

Hi all,
I need to use Appium/WinAppDriver to attach to an existing application. I've read through forums and post about how to do this in C++/C#, but I haven't been able to figure out how to do this in React-Native JS.
Our testing requires a separate entity to launch a Win32 app and get the app in a testing state. Then, using WebDriverIO/Appium/WinAppDriver, we need to attach to that application.
The problem I'm running into is I don't believe JavaScript has the ability to query the OS for current process'. I've seen other solutions in C# and Python, but I was wondering if anyone has done it in JS?

Closing. This is possible by writing a NodeJS C++ Addon that your project can take a dependency on.


Participants Count

Description
At the moment we are counting the number of Project Managers in the Participants Count on the Landing Page.
Discussion
Should we not rather be using numbers from the user engagement across campaigns?

The user engagement data is not saved in the file, it means we need to save the total user engagement in the file.

@dimasciput, let's go with your solution.

This number won't be exact, but it will give a good order of magnitude impression.


Add a new mention to README.md

Your github name
What is your @github name
Link
What is your link that reference this repository

Hi Tanishq,
Thanks for opening a new mention issue.
Please provide a github name and an associate link that reference a work mentioning this repository.
Then i should do the necessary to reference your work on matyo91's repository.
Regards


您好，我想要适配三星tab s4 2560x1600分辨率    只适配横屏怎么设置呀

Environment

[x] Autosize Version:
[x] Target Android Version:
[x] Device Model:
[x] Device Resolution:
[x] Design Size On AndroidManifest:

Bug Description:

Log:

Screenshot

Related Code:

Others:

看文档


Steam under XWayland is not interpreting mouse clicks correctly

Two monitors, one FullHD, second with scale 1.75, Steam from Arch repo, newest packages.

So the problem is, when I get dropdown menu for example in library and try to click something, it doesn't work (for example Utilities - I wanted to install SteamVR to test WMR under OpenHMD).

Related swaywm/sway#1865

I actually think it's a duplicate.


Update ServerBulkImportStatus for new Bulk import

This PR has conflicts with its target branch.

This PR has conflicts with its target branch.

Rebase'd and force pushed branch. Should be good now.


Refs 31617: Improved admin contrast

As I know changing brand colors is always controversial I tried to reuse existing colors where possible.

I think it would be worth asking on the mailing list about possible usage for CSS variables (https://developer.mozilla.org/en-US/docs/Web/CSS/var). This would ease a lot updating of colors.

@xi Thanks for this patch, however we need a wider discussion and DEP before we'll move it forward, see comment.
Closing per ticket.


Use custom data attributes for event handlers

Would you be open to converting event handlers to target something like [data-js="subscribe-link"]? In the long run I think separating style and behavior will make customization even easier.
If you're okay with this, I could work on this as I create my next theme.

Why not, I'm not sure what the best practice is for this. We could also decide to prefix event classes with js, as in class="js-upvote-link".

Yeah. I'll look into it a bit to see if there's any real advantage to using data attributes as opposed to classes. The class syntax is certainly easier to write so the js- prefix might be better.

Hey! Telescope has changed a lot in the past months, and there is a new React-based version, Telescope Nova (intro video). If you know Crater, it runs on the latest version.
The Legacy version is no longer supported. I'm closing this issue.
I invite you to check the new version, it's awesome!
Happy hacking! 🚀
Ps: by the way, don't hesitate to join the Slack to ask any question, you are welcome! 👍


Support v423

support beta1.16.210?

I already updated the Reversion library to do this. I just need to bump the version here for the support or I may consider making a beta branch maybe here.

v423 now supported in v1.0.23. However there seem to be some palette issues with water and skulls that will need investigating so expect some weird looking worlds...

Water is wrong

Only happens in beta1.16.210

Yep, that's the palette issue. Seems to also be something up with skulls.

Yep, that's the palette issue. Seems to also be something up with skulls.

There seems to be no problem with the skulls

That's interesting. I was having issues where Steve skulls were leaking through custom skulls.

Ok.. I did not watch the custom skull

Support v424?


Timeout on queries.

The problem is described here:
https://gist.github.com/fcruxen/9ad456039eee91632cd8
José Valim in the google groups topics suggested using the timeout attribute when configuring the Repo, same thing, queries still fail after 5000ms.
Increasing pool size had no effect on this too.
Thanks in advance,
Felipe Cruxen

I looked at the adapter itself and the driver, and it seems in both places we handle timeouts quite poorly. I think the main reason is there are multiple different timeouts:

queue timeout
query timeout (for a single call to Mongo - there can be multiple with coursors)
internal Mongo timeout $maxTimeMS
the overall timeout as seen by the user

It looks like currently the timeout option is only used for the tcp connection with the database.
I'm thinking about which ones we should configure and how.
\cc @ericmj

Thanks for the response. Ok, while you guys bake this, I'll fork the lib and change manually the values.

@michalmuskala |> sorry to bother again, I've increased the query timeout to 60 seconds. The number of errors decreased dramatically, but I am still getting timeout errors as described in the first post. I've tried  increasing the number of containers, to share the load, but it had no effect. Increasing/decreasing the pool size had no effect either. Any tip of what this may be? Thanks in advance.

@fcruxen do you have all hosts in replicaset setup properly? It's well known issue in ruby environment, maybe it apply to your coase too: https://github.com/mongoid/moped/issues/257

Yes, They are all correct.
I’ve patched the driver to some hardcoded values for query timeout and connection timeout.
The issue was due to connection limits in the container env. I’ve corrected the issue in the env, instead of just decreasing the pool limit. I’ll try to make some other tests and if brave enough a PR to better control those timeouts.
Thanks a lot for all the attention and help.
--
Sent with Airmail
On 25 de dezembro de 2015 at 09:49:35, Karol Wojtaszek<EMAIL_ADDRESS>wrote:
@fcruxen do you have all hosts in replicaset setup properly? It's well known issue in ruby environment, maybe it apply to your coase too: mongoid/moped#257
—
Reply to this email directly or view it on GitHub.

A PR would be greatly appreciated.


arm64 support

Hello,
first of all thanks a lot for your plugin! It sounds very promising and useful! However, I run paperless and scanservjs at a Raspberry Pi 64 bit (arm64).
I first installed go using
https://go.dev/dl/go1.18.2.linux-arm64.tar.gz
sudo tar -C /usr/local -xzf ~/go1.18.2.linux-amd64.tar.gz
nano ~/.profile
_____
#Adding
PATH=$PATH:/usr/local/go/bin
GOPATH=$HOME/go
_____

source ~/.profile

go version shows go1.18.2 linux/arm64, so it worked.
Afterwards, I tried to run the docker container using
docker run --rm ghcr.io/celedhrim/scantopl:master, but it gives WARNING: The requested image's platform (linux/amd64) does not match the detected host platform (linux/arm64/v8) and no specific platform was requested exec /usr/bin/scantopl: exec format error
Also, scantopl, /usr/bin/scantopl, /usr/local/scantopl and /usr/local/scantopl cannot be found.
Is there an possibility to use scantopl?
Thanks a lot!

I solved the problem using github.com/Celedhrim/scantopl@master
Afterwards, I could use ~/go/bin/scantopl


[#1476] feat(spark): Provide dedicated unregister app rpc interface

What changes were proposed in this pull request?
Introduce dedicated unregisterApp rpc interface which is only called once when unregister shuffle
Why are the changes needed?
Fix: #1476
Does this PR introduce any user-facing change?
No.
How was this patch tested?
UT

Merged. Thanks for your contribution @somelovelanguage .
Welcome to Uniffle community! 🎉


settings.py激活

Issue Type: Feature Request
我的settinga.py被删掉了，现在不知怎么激活？
VS Code version: Code 1.52.0 (940b5f4bb5fa47866a54529ed759d95d09ee80be, 2020-12-10T22:45:30.502Z)
OS version: Windows_NT ia32 10.0.19041

Translation:

settings.py activation
My settings.py has been deleted, now I don't know how to activate?


Building singularity container very slow

Describe the bug
I'm trying to generate a large singularity container (~10G of contents) and it's taking >1hr to generate the image. I have both my nix store and tmpdir set to fast ssd. Monitoring the progress is a challenge because after the Writing superblocks and filesystem accounting information: done message from qemu there is no output while the vm hard disk is set up.
The command that's taking forever is https://github.com/NixOS/nixpkgs/blob/777a4ba508c9500d85f4e6b2d98d15a9da1a01a3/pkgs/build-support/singularity-tools/default.nix#L61, it takes over an hour and produces no output.
mkfs -t ext3 -b 4096 /dev/${vmTools.hd}

Monitoring progress is very challenging, because from the view of the host system, the qcow2 file mounted there is deleted. I was able to crudely get progress my finding the pid and fd with
lsof 2>/dev/null | grep qcow

the qcow file will be there and listed as (deleted), the size can then be checked with
(cp /proc/<pid>/fd/<fd> test.qc; du -sh test.qc; rm test.qc)

doing that shows the file growing by tens or hundreds of megs a minute.
I tried tweaking the mkfs command by disabling trim with -o nodiscard, switching to ext4, playing with qemu arguments all with no success.
Steps To Reproduce
I'm building the container using nix build with a flake
{ pkgs, contents }:

with pkgs;
with pkgs.singularity-tools;

buildImage {
  name = "test-container";
  runScript = "#!${stdenv.shell}\nexec /bin/sh $@";
  runAsRoot = ''
     #!${stdenv.shell}
     ${dockerTools.shadowSetup}
  '';

  inherit contents;
  diskSize = 1024*20;
  memSize = 1024*8;
}

this builds the container using a VM with a 20G hard drive.
Expected behavior
I would expect mkfs, especially with -o nodiscard to run in several minutes on my ssd, instead it runs for hours.
Notify maintainers
@jbedo
Metadata
Please run nix-shell -p nix-info --run "nix-info -m" and paste the result.
nix-shell -p nix-info --run "nix-info -m"
this path will be fetched (0.00 MiB download, 0.00 MiB unpacked):
  /nix/store/q124axggd6wl6fh9508sxgkknkifrl0z-nix-info
copying path '/nix/store/q124axggd6wl6fh9508sxgkknkifrl0z-nix-info' from 'https://cache.nixos.org'...
 - system: `"x86_64-linux"`
 - host os: `Linux 4.15.0-169-generic, Ubuntu, 18.04.6 LTS (Bionic Beaver)`
 - multi-user?: `no`
 - sandbox: `no`
 - version: `nix-env (Nix) 2.6.1`
 - channels(chris): `"nixpkgs"`
 - nixpkgs: `/home/chris/.nix-defexpr/channels/nixpkgs`

Interesting, the following is running quickly for me:
with import (builtins.getFlake "github:nixos/nixpkgs") {};
with pkgs.singularity-tools;

buildImage {
  name = "test-container";
  runScript = "#!${stdenv.shell}\nexec /bin/sh $@";
  runAsRoot = ''
     #!${stdenv.shell}
     ${dockerTools.shadowSetup}
  '';
  diskSize = 1024*20;
  memSize = 1024*8;
  contents = [];
}

sh-5.1$ time nix build -f test.nix

real	0m11.287s
user	0m0.646s
sys	0m0.191s

I'll try an ubuntu machine and see what happens.

That test ran very quickly for me as well, so I must have been wrong about what's eating the time. It must be the copy loop
https://github.com/NixOS/nixpkgs/blob/777a4ba508c9500d85f4e6b2d98d15a9da1a01a3/pkgs/build-support/singularity-tools/default.nix#L76
I'm a bit surprised, I guess the qcow2 file doesn't preallocate the space and grows as the data gets copied in (hence why I was seeing the size of the qcow2 file grow over time). I checked the size of the references in the <hash>-runtime-deps file produced by writeReferencesToFile and it's 25G, still doesn't account for the many hour runtime I don't think.

Update on some further experiments, I enabled extended l2 in the qcow file, still no faster. got the idea from https://www.youtube.com/watch?v=zJetcfDVFNw. Didn't help.
I looked at the file /nix/store/yizdlakp49n60f62kri1lk70rjgy95ns-qemu-host-cpu-only-6.2.0/bin/qemu-kvm and I noticed that that the wrapper doesn't seem to actually enable kvm (possibly because I wasn't in the kvm group when I first tried building singularity containers). I added -enable-kvm to the QEMU_OPTS of runInLinuxVM still no change.
chris@TURING:~/documents/tbi_clinical_prediction_project/code/container$ TMPDIR=/mnt/4TB-SSD/chris/.nix-tmp/ nix --cores 4 build --print-build-logs
path '/home/chris/documents/tbi_clinical_prediction_project/code/container' does not contain a 'flake.nix', searching up
warning: Git tree '/home/chris/documents/tbi_clinical_prediction_project' is dirty
singularity-image-test-container.img> Formatting '/nix/store/8a0r3fpkx0h9bbf5hsncvmcqjxahpjp0-singularity-image-test-container.img/disk-image.qcow2', fmt=qcow2 cluster_size=65536 extended_l2=on compression_type=zlib size=42949672960 lazy_refcounts=off refcount_bits=16
singularity-image-test-container.img> cSeaBIOS (version rel-1.15.0-0-g2dd4b9b3f840-prebuilt.qemu.org)
singularity-image-test-container.img> iPXE (http://ipxe.org) 00:03.0 CA00 PCI2.10 PnP PMM+BFF91140+BFEF1140 CA00
singularity-image-test-container.img> Booting from ROM...
singularity-image-test-container.img> Probing EDD (edd=off to disable)... ocloading kernel modules...
singularity-image-test-container.img> [    0.259248] Module has invalid ELF structures
singularity-image-test-container.img> [    0.274746] Module has invalid ELF structures
singularity-image-test-container.img> [    0.277254] Module has invalid ELF structures
singularity-image-test-container.img> [    0.278837] Module has invalid ELF structures
singularity-image-test-container.img> [    0.326114] Module has invalid ELF structures
singularity-image-test-container.img> [    0.327768] Module has invalid ELF structures
singularity-image-test-container.img> [    0.332860] Module has invalid ELF structures
singularity-image-test-container.img> [    0.334861] Module has invalid ELF structures
singularity-image-test-container.img> [    0.336670] Module has invalid ELF structures
singularity-image-test-container.img> [    0.338596] Module has invalid ELF structures
singularity-image-test-container.img> [    0.346266] Module has invalid ELF structures
singularity-image-test-container.img> [    0.348049] Module has invalid ELF structures
singularity-image-test-container.img> [    0.349430] Module has invalid ELF structures
singularity-image-test-container.img> [    0.351276] Module has invalid ELF structures
singularity-image-test-container.img> [    0.352959] Module has invalid ELF structures
singularity-image-test-container.img> [    0.387931] Module has invalid ELF structures
singularity-image-test-container.img> [    0.393880] Module has invalid ELF structures
singularity-image-test-container.img> [    0.399981] Module has invalid ELF structures
singularity-image-test-container.img> [    0.405045] Module has invalid ELF structures
singularity-image-test-container.img> [    0.408280] Module has invalid ELF structures
singularity-image-test-container.img> mounting Nix store...
singularity-image-test-container.img> mounting host's temporary directory...
singularity-image-test-container.img> starting stage 2 (/nix/store/6ziw0dr9gwcs5svd7smkm2i0c9hg69jh-vm-run-stage2)
singularity-image-test-container.img> mke2fs 1.46.5 (30-Dec-2021)
singularity-image-test-container.img> Discarding device blocks: done
singularity-image-test-container.img> Creating filesystem with 10485760 4k blocks and 2621440 inodes
singularity-image-test-container.img> Filesystem UUID: 28a69c82-1fa4-4d32-a8b9-80955184a2e7
singularity-image-test-container.img> Superblock backups stored on blocks:
singularity-image-test-container.img>   32768, 98304, 163840, 229376, 294912, 819200, 884736, 1605632, 2654208,
singularity-image-test-container.img>   4096000, 7962624
singularity-image-test-container.img> Allocating group tables: done
singularity-image-test-container.img> Writing inode tables: done
singularity-image-test-container.img> Creating journal (65536 blocks): done
singularity-image-test-container.img> Writing superblocks and filesystem accounting information: done

I'm wondering now if the module has invalid ELF structure could be a problem now.

FYI, I'm refactoring the singularity-tools. #224636
Suggestions and feedback will be appreciated.

this issue no longer applies, thanks to https://determinate.systems/posts/qemu-fix


windows: add EKS quickstart steps for kube-proxy

Description
This PR adds some missing steps in the Calico for Windows EKS quickstart to enable WinDSR.
I've tested these changes locally.

Related issues/PRs

Todos

[ ] Tests
[ ] Documentation
[ ] Release note

Release Note

None required

@song-jiang I'm going to merge this and #4829 for now; feel free to leave a review if you see anything you want changed


Missing tabs in the More menu in mobile

Our bot contains 3 tabs, which are not displayed in the More menu in Teams Android app.
When the app is opened via the More button in the main menu, the 3 tabs are displayed correctly.

But in the moment when open a chat, tabs disappeared. And after clicking on More button in chat view they are not listed and depending on device we got this messages:

The lack of visible tabs in the chat window and after selecting the More button causes a problem, because it is not possible to go to the tabs directly from the chat. In addition, the No tabs message give the user the false impression that the application does not have any tabs.
How do we get to the tabs from chat view? And why are there no tabs on the More page?

Hello @MajaEffenberg - Thanks for raising your issue.
Could you please provide below details:

Are you using static tabs or configurable tabs?
Are you facing the issue in iOS Teams client as well?
Could you please share your Android Teams client version details?

@MajaEffenberg - We have tested this and able to repro your issue. This is by design behaviour.
If one application has 'Bot' and 'Tab' capabilities, in Mobile devices bot messages show in "Chat" section.
Users click on "More" tab to see the tab app. But the tab app doesn't show in list.
But If User clicks on "More" option in app tray, app is showing in list. So that user can navigate to tab app. And it will have link to open bot as well.

Ref Doc: https://learn.microsoft.com/en-us/microsoftteams/platform/tabs/design/tabs-mobile#apps-on-teams-store-not-approved-for-mobile

Thank you for your answer. The documentation you uploaded explains some of the issues, but not all:

On iOS, after selecting Chat of the bot app, the More (...) option is not displayed at all

On Android, in the More (...) view sometimes an error is displayed: Something went wrong. Please try again later ('Etwas ist schief gegangen. Bitte versuchen Sie es später erneut'). After clicking on button nothing happens and the error stays the same:

In the documentation you can read:

When you select Chat of the bot app and select More (...), you can't see the tab capability of that app in the list.

In my opinion, not displaying the list of tabs in More (...) view is confusing for the user and seems buggy.
Displaying information: No tabs. When tabs are added, they'll show up here  simply means that the app has no Tabs, which is not true. Because by selecting More (...) from the bottom right corner of the Chat section, the user can go to the view where the Tabs are displayed.
In addition, there is no direct option to open Tabs from the Chat view and as a result, the user doesn't even know the tabs exist or how to access them on a mobile device. Which causes a lot of problems when using the bot app in Teams.

@MajaEffenberg - We will test this and let you know the updates.

@MajaEffenberg - We got an update from engineering team saying that Micromate app manifest has only static tabs & bot with personal scope and no gallery tabs which means the app has only personal app capability, thus can be seen with in ... More/Personal app tray but not in Chat/Channel More section.
For the app to be available in Chat/Channel More section the app needs to supports gallaryTabs or Tabs capability with groupChat or Team scope, then only the app will be available in the later scope for acquisition and usage.


Plotting should really be in the utils folder

Description
As we discussed a couple months ago, all our plotting tools should probably be in the "utils" folder. This PR has just been sitting idol on my laptop for ages, but since we've been talking about plotting so much this week it occurred to me to break it out.

Checklist

[X] The code is understandable and maintainable to people beyond the author.
[X] Tests have been added/updated to verify that the new or changed code works.
[X] There is no commented out code in this PR.
[X] The commit message follows good practices.
[X] All docstrings are still up-to-date with these changes.

To the best of my knowledge, only one downstream project is affected by this move.
That repo will only need a one-line change, so I will make that change myself.


ci: publish java client

Also, make it compile on Java 8

Codecov Report

Merging #56 (df3dc2c) into main (0ea972e) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main      #56   +/-   ##
=======================================
  Coverage   89.74%   89.74%
=======================================
  Files           5        5
  Lines         156      156
=======================================
  Hits          140      140
  Misses         16       16

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0ea972e...df3dc2c. Read the comment docs.


How to recreate k8s-master with Kubespray?

Is this a BUG REPORT or FEATURE REQUEST? (choose one):
BUG REPORT
Environment:

Cloud provider or hardware configuration:
OpenStack (Kilo)

OS (printf "$(uname -srm)\n$(cat /etc/os-release)\n"):

Linux 3.10.0-327.28.2.el7.x86_64 x86_64
NAME="CentOS Linux"
VERSION="7 (Core)"
ID="centos"
ID_LIKE="rhel fedora"
VERSION_ID="7"
PRETTY_NAME="CentOS Linux 7 (Core)"
ANSI_COLOR="0;31"
CPE_NAME="cpe:/o:centos:centos:7"
HOME_URL="https://www.centos.org/"
BUG_REPORT_URL="https://bugs.centos.org/"

CENTOS_MANTISBT_PROJECT="CentOS-7"
CENTOS_MANTISBT_PROJECT_VERSION="7"
REDHAT_SUPPORT_PRODUCT="centos"
REDHAT_SUPPORT_PRODUCT_VERSION="7"

Ansible version (ansible --version):

ansible <IP_ADDRESS>

Kubespray version (commit) (git rev-parse --short HEAD):
67447260

Network plugins used:
weave
Copy of your inventory file:
We are using a Dynamic Inventory script that outputs following JSON:
{
  "_meta": {
    "hostvars": {
      "k8s-etcd01": {
        "ansible_ssh_host": "<IP_ADDRESS>"
      },
      "k8s-etcd02": {
        "ansible_ssh_host": "<IP_ADDRESS>"
      },
      "k8s-etcd03": {
        "ansible_ssh_host": "<IP_ADDRESS>"
      },
      "k8s-master01": {
        "ansible_ssh_host": "<IP_ADDRESS>"
      },
      "k8s-master02": {
        "ansible_ssh_host": "<IP_ADDRESS>"
      },
      "k8s-node01": {
        "ansible_ssh_host": "<IP_ADDRESS>"
      },
      "k8s-node02": {
        "ansible_ssh_host": "<IP_ADDRESS>"
      },
      "k8s-node03": {
        "ansible_ssh_host": "<IP_ADDRESS>"
      }
    }
  },
  "all": {
    "children": [
      "kube-cluster",
      "etcd"
    ]
  },
  "etcd": {
    "hosts": [
      "k8s-etcd03",
      "k8s-etcd01",
      "k8s-etcd02"
    ]
  },
  "k8s-cluster": {
    "children": [
      "kube-node",
      "kube-master"
    ]
  },
  "k8s": {
    "children": [
      "kube-cluster",
      "etcd"
    ]
  },
  "kube-master": {
    "hosts": [
      "k8s-master02",
      "k8s-master01"
    ]
  },
  "kube-node": {
    "hosts": [
      "k8s-node02",
      "k8s-node01",
      "k8s-node03"
    ]
  }
}

Command used to invoke ansible:
$ ansible all -i inventory.py -m setup -K
$ ansible-playbook -i inventory.py cluster.yml -b -K

Output of ansible run:
$ ansible-playbook -i inventory.py cluster.yml -b -K

PLAY RECAP ****************************************************************************************************************************
k8s-etcd01           : ok=129  changed=7    unreachable=0    failed=0
k8s-etcd02           : ok=124  changed=10   unreachable=0    failed=0
k8s-etcd03           : ok=124  changed=10   unreachable=0    failed=0
k8s-master01         : ok=279  changed=84   unreachable=0    failed=0
k8s-master02         : ok=256  changed=31   unreachable=0    failed=0
k8s-node01           : ok=283  changed=32   unreachable=0    failed=0
k8s-node02           : ok=231  changed=22   unreachable=0    failed=0
k8s-node03           : ok=231  changed=22   unreachable=0    failed=0
localhost            : ok=3    changed=0    unreachable=0    failed=0

Anything else do we need to know:

Is it possible to recreate k8s-master of existing cluster using Kubespray?
We are performing recovery process test for the k8s cluster created with Kubespray. In our test case,  we assume one k8s-master VM loss. We removed the k8s-master VM and tried to recreate it.
## delete VM & recreate it
$ nova delete k8s-master01
$ terraform apply

## Update fact cache, and run cluster.yml playbook
$ rm -rf /tmp/kubespray
$ ansible all -i inventory.py -m setup -K
$ ansible-playbook -i inventory.py cluster.yml -b -K

We executed cluster.yml playbook to the cluster (one new recreated k8s-master and other nodes untouched). We confirmed that cluster was broken.
$ kubectl get nodes
NAME                 STATUS     AGE       VERSION
k8s-master01   Ready      5m        v1.7.4+coreos.0
k8s-master02   NotReady   55m       v1.7.4+coreos.0
k8s-node01     NotReady   55m       v1.7.4+coreos.0
k8s-node02     NotReady   55m       v1.7.4+coreos.0
k8s-node03     NotReady   55m       v1.7.4+coreos.0

$ kubectl get pods --all-namespaces
NAMESPACE     NAME                                         READY     STATUS     RESTARTS   AGE
kube-system   kube-apiserver-k8s-master01            1/1       Running    0          5m
kube-system   kube-apiserver-k8s-master02            1/1       Unknown    0          54m
kube-system   kube-controller-manager-k8s-master01   1/1       Running    0          5m
kube-system   kube-controller-manager-k8s-master02   1/1       Unknown    0          55m
kube-system   kube-dns-3888408129-6k38b                    3/3       Unknown    0          52m
kube-system   kube-dns-3888408129-j58l4                    2/3       Running    0          13s
kube-system   kube-dns-3888408129-qp6mp                    3/3       Unknown    0          52m
kube-system   kube-dns-3888408129-vxbsh                    2/3       Running    0          13s
kube-system   kube-proxy-k8s-master01                1/1       Running    0          5m
kube-system   kube-proxy-k8s-master02                1/1       Unknown    0          12m
kube-system   kube-proxy-k8s-node01                  1/1       Unknown    0          12m
kube-system   kube-proxy-k8s-node02                  1/1       Unknown    0          12m
kube-system   kube-proxy-k8s-node03                  1/1       Unknown    0          12m
kube-system   kube-scheduler-k8s-master01            1/1       Running    0          5m
kube-system   kube-scheduler-k8s-master02            1/1       Unknown    0          55m
kube-system   kubedns-autoscaler-1629318612-ql38h          1/1       Unknown    0          52m
kube-system   kubedns-autoscaler-1629318612-tndgb          1/1       Running    0          13s
kube-system   kubernetes-dashboard-3941213843-3zlfx        0/1       Error      0          13s
kube-system   kubernetes-dashboard-3941213843-q09xw        0/1       Unknown    9          52m
kube-system   nginx-proxy-k8s-node01                 1/1       Unknown    0          54m
kube-system   nginx-proxy-k8s-node02                 1/1       Unknown    0          55m
kube-system   nginx-proxy-k8s-node03                 1/1       Unknown    0          55m
kube-system   weave-net-10hcg                              2/2       Unknown    0          55m
kube-system   weave-net-349f2                              2/2       Unknown    0          55m
kube-system   weave-net-55skt                              0/2       NodeLost   0          5m
kube-system   weave-net-fzdx1                              2/2       Unknown    0          55m
kube-system   weave-net-hv153                              0/2       NodeLost   0          5m
kube-system   weave-net-qcpx6                              0/2       NodeLost   0          5m
kube-system   weave-net-r07ws                              0/2       NodeLost   0          5m
kube-system   weave-net-s313b                              2/2       Running    0          5m
kube-system   weave-net-x0bw1                              2/2       Unknown    0          55m

We succeed to recreate k8s-node and Etcd (See #1122), but we had no success with recreating k8s-master.
Is there any advice on this situation?

I am facing the same issue as well. Only option that partially worked (etcd not coming due to certs) was to move the master that is getting removed in the inventory so that it is not groups[etcd][0]. For instance if you remove master-02, change inventory to look like
"kube-master": {
"hosts": [
"k8s-master01",
"k8s-master02"
]
},

I have also hit this issue - we tried to promote a worker node to a master node because one of the nodes had disk failures, and it ended up hosing our whole cluster when we re-ran the ansible playbook.
We started seeing timeouts from kubectl operations, with the following in the logs
2017-12-11 15:04:48.797860 | Error from server (ServerTimeout): the server cannot complete the requested operation at this time, try again later (get deployments.extensions)
2017-12-11 15:04:48.797908 | Error from server (ServerTimeout): the server cannot complete the requested operation at this time, try again later (get services)
2017-12-11 15:04:48.797955 | Error from server (ServerTimeout): the server cannot complete the requested operation at this time, try again later (get jobs.batch)
2017-12-11 15:04:48.797998 | Error from server (ServerTimeout): the server cannot complete the requested operation at this time, try again later (get secrets)

Upon investigation, wtp-k8s-3 appears to have suffered a serious hardware failure.

I'm seeing this on the node in the logs: NMI watchdog: BUG: soft lockup - CPU#0 stuck for 22s! [migration/0:10]
then a kernel dump

I wrote a pull request that removed wtp-k8s-3 from the inventory file and promote wtp-k8s-4 to the master role
That appears to have done something that we didn't quite expect.
2017-12-11 16:02:16.293740 | fatal: [wtp-k8s-4.projwrigley.com]: FAILED! => {"changed": true, "cmd": "/usr/local/bin/etcdctl --peers=https://<IP_ADDRESS>:2379,https://<IP_ADDRESS>:2379,https://<IP_ADDRESS>:2379 member add etcd3 https://<IP_ADDRESS>:2380", "delta": "0:00:02.042013", "end": "2017-12-11 10:02:16.273793", "failed": true, "msg": "non-zero return code", "rc": 1, "start": "2017-12-11 10:02:14.231780", "stderr": "client: etcd cluster is unavailable or misconfigured; error #0: client: etcd member https://<IP_ADDRESS>:2379 has no leader\n; error #1: client: etcd member https://<IP_ADDRESS>:2379 has no leader\n; error #2: client: endpoint https://<IP_ADDRESS>:2379 exceeded header timeout", "stderr_lines": ["client: etcd cluster is unavailable or misconfigured; error #0: client: etcd member https://<IP_ADDRESS>:2379 has no leader", "; error #1: client: etcd member https://<IP_ADDRESS>:2379 has no leader", "; error #2: client: endpoint https://<IP_ADDRESS>:2379 exceeded header timeout"], "stdout": "", "stdout_lines": []}

We did a revert of the above gist, re-adding wtp-k8s-3 back into the inventory, and Ansible died earlier in the playbook
2017-12-11 17:00:51.526185 | TASK [bootstrap-os : Remove require tty] ***************************************
2017-12-11 17:00:51.526219 | Monday 11 December 2017  17:00:51 +0000 (0:00:00.077)       0:00:02.206 *******
2017-12-11 17:00:53.040722 | fatal: [wtp-k8s-3.projwrigley.com]: UNREACHABLE! => {"changed": false, "msg": "Authentication or permission failure. In some cases, you may have been able to authenticate and did not have permissions on the target directory. Consider changing the remote temp path in ansible.cfg to a path rooted in \"/tmp\". Failed command was: ( umask 77 && mkdir -p \"` echo /root/.ansible/tmp/ansible-tmp-1513011651.79-92389304798173 `\" && echo ansible-tmp-1513011651.79-92389304798173=\"` echo /root/.ansible/tmp/ansible-tmp-1513011651.79-92389304798173 `\" ), exited with result 1", "unreachable": true}
2017-12-11 17:00:53.169682 | ok: [wtp-k8s-4.projwrigley.com] => {"backup": "", "changed": false, "failed": false, "found": 0, "msg": ""}
2017-12-11 17:00:53.171116 | ok: [wtp-k8s-5.projwrigley.com] => {"backup": "", "changed": false, "failed": false, "found": 0, "msg": ""}
2017-12-11 17:00:53.178178 | ok: [wtp-k8s-1.projwrigley.com] => {"backup": "", "changed": false, "failed": false, "found": 0, "msg": ""}
2017-12-11 17:00:54.161036 | ok: [wtp-k8s-2.projwrigley.com] => {"backup": "", "changed": false, "failed": false, "found": 0, "msg": ""}
2017-12-11 17:00:54.487052 | ok: [wtp-k8s-6.projwrigley.com] => {"backup": "", "changed": false, "failed": false, "found": 0, "msg": ""}
2017-12-11 17:00:54.487575 |
2017-12-11 17:00:54.487618 | NO MORE HOSTS LEFT *************************************************************
2017-12-11 17:00:54.488361 | 	to retry, use: --limit @/tmp/git_repos/kubespray/cluster.retry
2017-12-11 17:00:54.488382 |
2017-12-11 17:00:54.488412 | PLAY RECAP *********************************************************************
2017-12-11 17:00:54.488448 | localhost                  : ok=3    changed=1    unreachable=0    failed=0
2017-12-11 17:00:54.488477 | wtp-k8s-1.projwrigley.com  : ok=2    changed=0    unreachable=0    failed=0
2017-12-11 17:00:54.488505 | wtp-k8s-2.projwrigley.com  : ok=2    changed=0    unreachable=0    failed=0
2017-12-11 17:00:54.488533 | wtp-k8s-3.projwrigley.com  : ok=1    changed=0    unreachable=1    failed=0
2017-12-11 17:00:54.488561 | wtp-k8s-4.projwrigley.com  : ok=2    changed=0    unreachable=0    failed=0
2017-12-11 17:00:54.488588 | wtp-k8s-5.projwrigley.com  : ok=2    changed=0    unreachable=0    failed=0
2017-12-11 17:00:54.488616 | wtp-k8s-6.projwrigley.com  : ok=2    changed=0    unreachable=0    failed=0
2017-12-11 17:00:54.488622 |
2017-12-11 17:00:54.488669 | Monday 11 December 2017  17:00:54 +0000 (0:00:02.962)       0:00:05.169 *******

We removed wtp-k8s-3 from the inventory again, and tried to re-run the playbook.
wtp-k8s-4's apiserver never came up.
2017-12-11 18:04:36.071457 | RUNNING HANDLER [kubernetes/master : Master | wait for the apiserver to be running] ***
2017-12-11 18:04:36.071596 | Monday 11 December 2017  18:04:36 +0000 (0:00:00.612)       0:03:45.991 *******
2017-12-11 18:04:36.395869 | FAILED - RETRYING: Master | wait for the apiserver to be running (20 retries left).
2017-12-11 18:04:36.398346 | FAILED - RETRYING: Master | wait for the apiserver to be running (20 retries left).
2017-12-11 18:04:36.398493 | FAILED - RETRYING: Master | wait for the apiserver to be running (20 retries left).
2017-12-11 18:04:42.539371 | FAILED - RETRYING: Master | wait for the apiserver to be running (19 retries left).
2017-12-11 18:04:42.540697 | FAILED - RETRYING: Master | wait for the apiserver to be running (19 retries left).
2017-12-11 18:04:42.544330 | FAILED - RETRYING: Master | wait for the apiserver to be running (19 retries left).
2017-12-11 18:04:48.688501 | FAILED - RETRYING: Master | wait for the apiserver to be running (18 retries left).
2017-12-11 18:04:48.692366 | FAILED - RETRYING: Master | wait for the apiserver to be running (18 retries left).
2017-12-11 18:04:48.693748 | FAILED - RETRYING: Master | wait for the apiserver to be running (18 retries left).
2017-12-11 18:04:54.833167 | FAILED - RETRYING: Master | wait for the apiserver to be running (17 retries left).
2017-12-11 18:04:54.835942 | FAILED - RETRYING: Master | wait for the apiserver to be running (17 retries left).
2017-12-11 18:04:54.837493 | FAILED - RETRYING: Master | wait for the apiserver to be running (17 retries left).
2017-12-11 18:05:00.981871 | FAILED - RETRYING: Master | wait for the apiserver to be running (16 retries left).
2017-12-11 18:05:00.984227 | ok: [wtp-k8s-2.projwrigley.com] => {"attempts": 5, "changed": false, "connection": "close", "content_length": "2", "content_type": "text/plain; charset=utf-8", "cookies": {}, "date": "Mon, 11 Dec 2017 18:05:00 GMT", "failed": false, "msg": "OK (2 bytes)", "redirected": false, "status": 200, "url": "http://<IP_ADDRESS>:8080/healthz"}
2017-12-11 18:05:00.990091 | ok: [wtp-k8s-1.projwrigley.com] => {"attempts": 5, "changed": false, "connection": "close", "content_length": "2", "content_type": "text/plain; charset=utf-8", "cookies": {}, "date": "Mon, 11 Dec 2017 18:05:00 GMT", "failed": false, "msg": "OK (2 bytes)", "redirected": false, "status": 200, "url": "http://<IP_ADDRESS>:8080/healthz"}
2017-12-11 18:05:07.128851 | FAILED - RETRYING: Master | wait for the apiserver to be running (15 retries left).
2017-12-11 18:05:13.282803 | FAILED - RETRYING: Master | wait for the apiserver to be running (14 retries left).
2017-12-11 18:05:19.432053 | FAILED - RETRYING: Master | wait for the apiserver to be running (13 retries left).
2017-12-11 18:05:25.582519 | FAILED - RETRYING: Master | wait for the apiserver to be running (12 retries left).
2017-12-11 18:05:31.731787 | FAILED - RETRYING: Master | wait for the apiserver to be running (11 retries left).
2017-12-11 18:05:37.881242 | FAILED - RETRYING: Master | wait for the apiserver to be running (10 retries left).
2017-12-11 18:05:44.030312 | FAILED - RETRYING: Master | wait for the apiserver to be running (9 retries left).
2017-12-11 18:05:50.181724 | FAILED - RETRYING: Master | wait for the apiserver to be running (8 retries left).
2017-12-11 18:05:56.327906 | FAILED - RETRYING: Master | wait for the apiserver to be running (7 retries left).
2017-12-11 18:06:02.474954 | FAILED - RETRYING: Master | wait for the apiserver to be running (6 retries left).
2017-12-11 18:06:08.620174 | FAILED - RETRYING: Master | wait for the apiserver to be running (5 retries left).
2017-12-11 18:06:14.771769 | FAILED - RETRYING: Master | wait for the apiserver to be running (4 retries left).
2017-12-11 18:06:20.922756 | FAILED - RETRYING: Master | wait for the apiserver to be running (3 retries left).
2017-12-11 18:06:27.066782 | FAILED - RETRYING: Master | wait for the apiserver to be running (2 retries left).
2017-12-11 18:06:33.216370 | FAILED - RETRYING: Master | wait for the apiserver to be running (1 retries left).
2017-12-11 18:06:39.368364 | fatal: [wtp-k8s-4.projwrigley.com]: FAILED! => {"attempts": 20, "changed": false, "content": "", "failed": true, "msg": "Status code was not [200]: Request failed: <urlopen error [Errno 111] Connection refused>", "redirected": false, "status": -1, "url": "http://<IP_ADDRESS>:8080/healthz"}

We ended up scrapping the cluster and re-building it from scratch

Note this was while running 9c86da1403a8aba7e46267deae0b957f2b22edf2 of Kubespray

Hello,
Sorry to reopen again this issue but I have the same problem. We are trying to test kubespray scaling at master +/or etcd level, for recorvery process
First, we installed a cluster with 3 dedicated etcd, 3 masters and 1 node server (we know that scaling node is working well with kubespray)
When we tried to add 2 others masters, we run the cluster.yaml playbook without any errors.
When we connect to a master server and type kubectl get nodes, it returns that both two masters just added is in NotReady state.
As far as I see, it a CA certificat problem. The docker container which is running kube-apiserver is in error :
E0707 16:19:38.733473       1 authentication.go:65] Unable to authenticate the request due to an error: [x509: certificate signed by unknown authority, x509: certificate signed by unknown authority (possibly because of "crypto/rsa: verification error" while trying to verify candidate authority certificate "kubernetes")]
And the CA Certificates in the added master differs from the originial masters. Seems that the playbook didn't retrieve CA certificates from old masters.


registration: Show spinner and disable button while processing request.

This commit disables the button and shows a loading spinner on
the button when signup request is being processed to avoid race
conditions caused by user clicking on the button multiple times.
The fix is done observing that for the case when form is invalid
the whole page is rerendered and thus we do not need to remove
the spinner and enable the button again and for other errors
we redirect to some other page.
And for the validation taking place in client-side, the button
is disabled and spinner is shown, only is form is valid, by
using "$('#registration').valid()".

GIFs or screenshots:

One problem is that, I have not removed the spinner and enabled the button after the request, becuase I cannot figure out a way to see if the request from backend is completed. It could have been done if we used channel.post by using success but cannot think of a way to do so when we use action in the form as we do now.
But this can still be safe as if the form validation fails in backend we rerender the form so there is no problem and for other erros we redirect to a different page.

Should the spinner be white, given that's our text color for that button?
Otherwise the spinner UX lgtm.
Since this is a button that should navigate the user to another page if the server responds, the main issue is going to be that one gets an infinite loading indicator if you have an Internet interruption (So that the browser just waits ~forever), and it'd be annoying to not be able to reset the form?  It's a short form, so may not matter.
I'd post in #frontend in case folks have other ideas, but it's possible we can't really do better.

Updated the spinner to be white.

Looks great, merged, thanks @sahil839!


Create binary search

this is a binary search using recursion
What the program do ?
this is a binary search using recursion
In what programming language it is written?
c

this is a binary search using recursion

This pull request do not contains files in specific folders. Please fix it and reopen


SwiftyDropbox uses AuthenticationServices like the other auth libraries

After upgrading AppAuth and GTMAppAuth, SwiftyDropbox was the only one left using SFSafariViewController. Apple's AuthenticationServices has better support for auth flows starting in iOS 11.
I left the old SFSafariViewController as a fallback and try to use the newer libraries when possible. The new interfaces are pretty different, since they are Sessions instead of VCs and directly give you a callbackURL with the service's response rather than Safari passing back to the app through openURL:
For some reason if you cancel out of SFSafariViewController it also does a second redirect within Notability from the cancelBlock. I guess Safari wasn't closing or something. The newer ones don't bother calling it because the app seems to run fine without the extra redirect (and on catalyst, it is opening the old Notability app I still have installed).
The Dropbox flows also don't always call out to the app's completion block, which we could change now, but I didn't want to make any other changes yet. It only calls all the way out when you cancel the SFSafariViewController flow, which is the least helpful case, and why an error message was showing up unexpectedly in the original ticket

The changes look good. We'll need solid a QA script to get them through each path here.
Also NB is currently iOS 12+, so I assume you can drop the iOS 11 specific code in here.

I'll remove the SFAuthenticationSession flow since it's duplicating, but leave in SFSafariViewController for the UIAccessibility.isGuidedAccessEnabled case

merged and tagged manually

merged and tagged manually