revert 131377

revert #131377

umm would be great if the breakage and reason of revert could be linked in the pr description, thank you!


graphql.Time not found

When I have a custom type like graphql.Time I get an error on startup saying type "Time" not found.
I think it is because Time doesn't exsist in this list: https://github.com/neelance/graphql-go/blob/master/internal/schema/schema.go#L111-L117
Is there a function or method to add a custom type to that list?

Never mind. I just realized that I needed to declare the scalar type in the query.


Prohibit that user can create a container

I want a security option where I can turn on and off if a user has the ability to create a container, or at least only make only administrators can create them

We have this as part of the Portainer RBAC functionality, which is available as an extension in Portainer 1.24.1, or as part of Portainer Business Edition (commercial).
Happy to review community contributions of this specific feature in CE, but be aware that this is more than just a front end change, it also requires a block at the Portainer API level, and would also need to be coupled with the disabling of the use of Stacks.

Thank you for answering, but guess I just have to wait I guess :s

Closed for inactivity.


feat: implement interaction between deno http sever and rust

Type of this PR

Select at least one type

[x] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[ ] Bug fix
[x] Dependency, Environment, Build related update
[ ] Documentation
[ ] Other tiny fix

Describe your changes
Issue ticket number and other helpful resource
Checklist before requesting a review

[x] I have performed a self-review of my code
[x] I have commented my code, particularly in hard-to-understand areas
[x] Leave reference about this pull request, if exist (ex. discord message, google docs, etc)
[x] If it is a core feature, I have added thorough tests.

Checklist after creating a pull request

[x] Mention reviews in discord channel directly

포매팅 깨지는 듯요?

check the above comment.
I think that using Enum instead of 'contract_name' is better, too

LGTM


Updated pipeline to use shared action

Context
Updated actions to use shared kubectl action
[Why are we making this change?]
Changes proposed in this pull request
Updated actions to use shared kubectl action
Failed feature specs screenshots
If any of the feature specs would fail, there will be page on the wiki with all
failures:
https://github.com/DFE-Digital/npq-registration/wiki/

 Updated pipelines to use setup-kubectl github shared  action


Parse escaped backreferences and subpatterns

Parse the escaped syntaxes for backreferences and subpatterns (the latter are so syntactically similar, it made sense to also parse them).
This doesn't yet handle the non-escaped syntax for either, in particular Python-style backreferences (?P=...). These are syntactically similar to groups (despite being atoms), so will require some more thought on how to parse.

@swift-ci please test Linux

@swift-ci please test linux platform

@swift-ci please test Linux

Updated to disambiguate octal vs backreferences in the parser, and also extended the \nnn syntax to work more generally in custom character classes, how does this look @milseman?

@swift-ci please test Linux

@swift-ci please test Linux

@swift-ci please test Linux


Update idafree to 7.0

After making all changes to the cask:

[x] brew cask audit --download {{cask_file}} is error-free.
[x] brew cask style --fix {{cask_file}} left no offenses.
[x] The commit message includes the cask’s name and version.

yes only the SHA changed, but it is in-line with the SHA they have on their homepage
https://www.hex-rays.com/products/ida/support/download_freeware.shtml
says the SHA1 is this:
4b557049a3317dcc9159d6403272547170e1909d  idafree70_mac.tgz
MBP:~ CC$ shasum -a 1 /Users/CC/Library/Caches/Homebrew/Cask/idafree--7.0.tgz
4b557049a3317dcc9159d6403272547170e1909d  /Users/CC/Library/Caches/Homebrew/Cask/idafree--7.0.tgz
its a match

See https://github.com/caskroom/homebrew-cask/pull/46749


[feat] : Add sound effects to python game (python)

*Is your feature request related to a problem? Please describe.
No sound in python games
Describe the solution you'd like
Add sound effects to the game to make it more interactive
Additional context
add background sound, game over sound, and point increment sound.

@SubstantialCattle5 , @3xpl0itk1t , please add required tags

@SubstantialCattle5 , can I use the sounds from spaceinvaders game


build giu failed with latest cimgui-go

Please do not modify the library path; otherwise, the giu compilation exception will occur. If you must modify the giu code, modify it simultaneously。  It has its own go.mod file with specified cimgui-go version which is supposed to be used.

If not maybe we should report an issue in go repo as imo it isn't supposed

As you said, my project uses the latest cimgui-go. After the directory adjustment, some of the latest definitions that giu relies on cannot be found, resulting in the inability to compile.

As you said, my project uses the latest cimgui-go. After the directory adjustment, some of the latest definitions that giu relies on cannot be found, resulting in the inability to compile.

Generally in projects using GIU it is recommended to use cimgui-go version compatible with giu cimgui-go version.
Anyway I have no idea why go decided to take newer version of cimgui-go (prioritize version from your go.mod than from giu's go.mod)
Generally cimgui-go is on v0.0.0 for go so it is absolutly not stable yet...
Btw I did a quick test and managed to reproduce your issue. I recommend switching for supported vcimgui-go version for now. I'll update giu later.

https://github.com/golang/go/issues/69437 they will not change it.


.NET 8.0 and a few other perf improvements

Added a .NET 8.0 TFM
Polyfills for a few new functionalities (Ascii, SearchValues, ContainsAnyExcept ...)
Replaced the CharacterMap.IndexOfOpeningCharacter implementation with a call to IndexOfAny(SearchValues)

Don't need manual vectorization code in Markdig for this anymore
Also get AVX2 paths and ARM64 acceleration "for free"

Changed CodeInlineParser.Match to make use of vectorized helpers
Sped up WriteEscape & WriteEscapeUrl rendering (vectorized scanning via SearchValues)
A few random alloc / codegen improvements

A few rough numbers from parsing a large markdown document with precise source locations (.NET 8 perf improvements blogpost).
 Thanks @MihaZupan!


Adaboost - Documentation

I have added Adaboost Documentation please let me know if there are any changes I should do
@ashwani-rathee
Issue #71


[SMALLFIX] Remove AlluxioExceptionType

The enum AlluxioExceptionType is not necessary, because the exception class can use the class name to create the new instance via reflection.
By removing this enum, new exception classes are allowed to be defined outside common project.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Alluxio-Pull-Request-Builder/8789/
Test PASSed.

Merged build finished. Test PASSed.

Awesome change, it's always great to see 100 lines get shaved off while gaining functionality :)

+1 LGTM --- assuming you fix @aaudiber 's comment

Thanks for the comments. Addressed them. PTAL.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Alluxio-Pull-Request-Builder/8798/
Test FAILed.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Alluxio-Pull-Request-Builder/8800/
Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Alluxio-Pull-Request-Builder/8804/
Test PASSed.

Merged build finished. Test PASSed.

LGTM


(PDB-2251) Document unchanged resources for PE 2015.3.0 (Ankeny)

This commit documents unchanged resources information for PE Ankeny in
the FOSS documentation.

Refer to this link for build results (access rights to CI server needed):
http://jenkins-enterprise.delivery.puppetlabs.net/job/enterprise_puppetdb_init-multijob_githubpr-stable/96/
Test PASSed.

@kbarber updated per our discussion!

Refer to this link for build results (access rights to CI server needed):
http://jenkins-enterprise.delivery.puppetlabs.net/job/enterprise_puppetdb_init-multijob_githubpr-stable/98/
Test FAILed.

@kbarber @wkalt Updated with your guys' input and the input from docs!

Refer to this link for build results (access rights to CI server needed):
http://jenkins-enterprise.delivery.puppetlabs.net/job/enterprise_puppetdb_init-multijob_githubpr-stable/100/
Test FAILed.


feat: implement FoxPage get fox component

Description

On Fox Page, we need a component containing tabs in order to display buy/receive actions between different assets
I used chakra tabs and some props, text and buttons, nothing difficult

Notice

[x] Have you followed the guidelines in our Contributing guide?
[x] Have you checked to ensure there aren't other open Pull Requests for the same update/change?

Pull Request Type

[ ] :bug: Bug fix (Non-breaking Change: Fixes an issue)
[ ] :hammer_and_wrench: Chore (Non-breaking Change: Doc updates, pkg upgrades, typos, etc..)
[x] :nail_care: New Feature (Breaking/Non-breaking Change)

Issue (if applicable)
closes #1777

Risk

No risk

Testing

Check on storybook that the component is displayed properly and working as expected

Screenshots (if applicable)

@NeOMakinG french faaaam


Error when fetching farm with node created within the current minting period

Situation

we get: Error when fetching farm with node created within the current minting period
e.g. farm 197
As shown by Scott, the alpha minting can't fetch 7285

UI-UX:

Fix was deployed and it looks okay. Here's an example with a node created during the current period:


Clicking notification on Windows doesn't focus the app even with window.focus in click handler

Electron version: v0.36.9
Operating system: Windows 10

Unlike on OS X, clicking a web notification triggered on Windows 10 doesn't focus the app, even with a window.focus() in the click handler. The click handler is called, but the focus call does nothing.

This is a duplicate of #2867.


Downloading/Update FAF game in background after launch client

Launch the client, select a game , click Join, and wait for the game to download\update(sometimes for a long time)
It also happens that you only need to download\update.
At least the "Update now" button.
Or option "Autoupdate"

Please not automatically or optional.

not sure if that's good it might harm a users internet connection

At least the "Update now" button

I dont see a need for this the client checks on start up.

Launch the client, select a game , click Join, and wait for the game to download\update(sometimes for a long time)

Ok so this issue is about game updates, not client updates.
That might be a good idea.
And we really need a way to cache multiple updates at once without redownloading whenver an old replay is started and then redownloading when trying to join a game after that.

The whole featured mod handling should be rethought. This issue asks to fix a symptom instead of the cause.
Why do you want to auto-download this stuff in the background?
Because it takes a while.
Why does it take so long?
Because it's almost 50mb on each patch.
Why do we need to download 50mb of patch with every new release if only a few kb have changed?
Why is there no improved patcher?
Because the zipping of folders makes this incredibly hard and inperformant. (I worked on this for over half a year and gave up.)
Why do we have this weird zip structuce?
I don't know. If we can get rid of this we have a better chance of improving the patcher.

This issue asks to fix a symptom instead of the cause.

Why is there no improved patcher?
Because the zipping of folders makes this incredibly hard and inperformant. (I worked on this for over half a year and gave up.)

What should I do?

Well i am closing this. I see it as @Brutus5000 yes updating is fucked and it needs a prper patcher

I jusst want to add that it is very possible to have the game load the files from ordinary folders.  At the moment it produces errors when starting the game with the client (because of the checksums, i think), but when launching with the exe it works.
Probably nobody dared to not use the zipping of the folders, because nobody knew why it existed.

This is intertesting so u mean that the zip things are not needed at all

Well the files are stored as zips on the server

Acctually @micheljung had a patchr of his own in place that just used git and the GitHub repo for the patching. Also without any zip files. There were three major disadvantages tho. 1. The init.lua was generated from the mod-info.lua and that broke occasonally. 2. ppl did not care to make tags in the github repo so that it also broke more often and as dfc had 5% user share the fa repo maintainers did not care to much breaking the client for days. 3.Sometimes there were funny exceptions because some file handles were left open, so that in some cases you had to restart your PC which was super annoying.   So in the end we just got rid of the git patcher BUT it was super fast and lightweight @BlackYps

deploying the init lua is broken atm anyway https://github.com/FAForever/fa/issues/2972
This should be fixed with the proper using of branches that we have now, right?
Can't really comment on that

Of course the current rolling out of downloads has to be changed big time. I don't know how much work that is. But if downlord already had a mostly working git patcher I think it should be quite doable.


Markdown doesn't render correctly

In the openEO content there is markdown markup in the text that is non-standard and doesn't render as intended, e.g.
::: tip Simplified
<span title="Reducing [mixed greens, cucumber, tomato, onion] returns a salad.">`reduce([🥬, 🥒, 🍅, 🧅], prepare) => 🥗`</span>
:::

On openeo.org this renders correctly as it has some extended Markdown functionality, but I think here it should be fixed as the extended Markdown is not available...
Seen in @przell's presentation today ;-)

Fixed it with this commit: https://github.com/EO-College/cubes-and-clouds/commit/81552043189eccae3aa4be1453491cde17a82d72
@clausmichele, in case you've used it in other places you can adapt accordingly.


Allow and save column selection for search results

As a user, I'd like to be able to choose the columns to display in the search results table, and I'd like the app to remember my choice.
The column names to select could be taken from the attribute type names in actual search results.

The DS evaluation defines a json attribute and associated object class:
# Schema definitions for "json" attribute and auxiliary object class
attributeTypes: ( json-attribute-oid
  NAME 'json'
  SYNTAX <IP_ADDRESS>.4.1.367<IP_ADDRESS>.1
  EQUALITY caseIgnoreJsonQueryMatch
  X-ORIGIN 'DS Documentation Examples' )
objectClasses: ( json-object-class-oid
  NAME 'jsonObject'
  SUP top
  AUXILIARY
  MAY ( json )
  X-ORIGIN 'DS Documentation Examples' )

The UI could use the attribute to save settings on the user entry. It might be a nice way to save searches as well, for example.
The settings could be accessible through the search UI and also in the settings page, https://github.com/markcraig/hdap-demo/blob/main/src/pages/settings.vue.

For this to work, the table in https://github.com/markcraig/hdap-demo/blob/main/src/pages/search.vue needs to be generic, or nearly so. The UI should "know" how to render CREST-specific fields like _id and _rev, but not attributes defined in the LDAP schema, like cn, json,manager, postalAddress, or mail, because the LDAP schema is up to the user.
The UI sometimes needs extra information to properly format field content, information which might be in the JSON schema:

For cn or json, the UI doesn't necessarily need to read the schema. It can show an array of strings as a comma-separated list and JSON as its stringified representation, for example.
For manager, the UI needs to know the values should be links. The information is in the schema: "format" : "json-pointer". In order to discover the schema for manager, the UI needs to get the schema for a resource with a manager field. AFAIK, HDAP doesn't provide a means to request the schema for a field or list of fields.
For postalAddress, an array of arrays of strings, the UI could maybe uncover the structure, but it would probably be easier to do so with the schema.
For mail, the schema only indicates its value is an array of strings. It doesn't seem straightforward to know that it's an array of email address strings, which could be formatted as mailto: links.

It's true that mail address is simply defined as a string in RFC 4524. I wonder if we should include hints in our standard schema elements for attributes like this? For example, we could define an X-PATTERN extension constraining the set of allowable values.
Regarding manager, this attribute uses the distinguished name syntax whose JSON schema is json-pointer as you correctly point out. These attributes will need a special renderer / editor allowing users to find and select the entries - a popup dialog? Note that it will need to share some UI elements from the rest of the application which already has UI for searching and selecting entries.

Yes, there's this:
curl --insecure 'https://localhost:8443/hdap/schemas/attributeTypes/manager'
{"_id":"manager","type":"array","uniqueItems":true,"items":{"type":"string","format":"json-pointer"}}

The X-PATTERN extension sounds good, and it ought to work in many cases. How does the application know that $ in postalAddress means newline?
For editing json-pointer attributes, I imagine an autocomplete selector that somehow has good performance even when there are lots of possible completions. For example, when you type dc=com/dc=example/ou=People/ in the autocomplete field for the default DS evaluation profile. Would setting the autocomplete's one-level search with a page size of 10, for example, keep latency low enough?
No doubt client apps like the UI will just need to "know" that a very fields such as userPassword require special handling.

Completely failing to figure out how to make the data table cells generic, yet keep rows selectable. The really tricky bits with this at my present lack of understanding are being unable to formulate search terms even after reading doc, and being unable to understand enough doc at a time to put things together on my own.

Going to unassign myself for now.
I've spent days now failing to understand and even go search for examples how to uncouple the data table columns from the template used to format the table. I also don't see another way of making columns optional. So I'm blocked.


fix: add title to Spectre panel in edgy

Title could also be Search/Replace, because the Spectre panel shows Nvim Spectre in the panel as well.

Thanks!


fix(update-example-gallery): resolve create-pr failure issue

Closes #6067
What did you change?
- cron: '0 0 1 * *'
if: **failure()** && steps.up_to_date.outcome == 'failure'
GITHUB_TOKEN
How did you test and verify your work?
Github UI

Raising, another PR due to I messed up this PR 😄


Change is not triggered when we select the Originaly selected color from pallete

Steps to reproduce
http://bgrins.github.io/spectrum/#options-showPalette
initialy the picker has original color(in my case light Blue).

select Black the change triggered(border update to black).
select original color(in my case light blue) change not triggered. still the border is black.

Was just going to post the same issue :)
Call the change ethod everytime you make a change, also when you change back to the original color, it still is a change.
Hopefully a fix is comming soon.

Was there ever a fix to this?  I am still seeing this issue in the current build.


fix: traversal limit ignoring default value

Tasks

[x] I've read the CONTRIBUTING guide
[ ] Necessary tests have been added

The moduleParsed hook calls out to getCorrespondingPackageFromModuleId for each imported module, which tries to find a package.json to extract information from. If it can't find a package.json it should traverse up the directory tree a max of 10 times before failing.
The current implementation passes getCorrespondingPackageFromModuleId directly to the nodeModuleImportedIds.map() call. This means that the traverseLimit param will not be undefined and use the default of 10, and instead will be the current index in the array (the second param of .map()). We found this meant a number of packages were getting missed in our output SBOM.
This pull request uses an arrow function to call getCorrespondingPackageFromModuleId, which will correctly use the default value of 10.

@xenobytezero you've also fixed this in your other PR #68 – Am I allowed to close this PR in favor of your newer one?

@xenobytezero you've also fixed this in your other PR #68 – Am I allowed to close this PR in favor of your newer one?

If #68 is going ahead, absolutely.


Some guest OS don't get IP address

Some guest OS are not getting the IP address offered by dnsmasq in container service.
If IP address is configured manually, network connectivity works properly.
Guest OS tested:

CentOS 6.8 (Nuage VSD)

kvm:latest (centos) ✔
kvm:alpine ❌

[CentOS-7-x86_64-GenericCloud-1608.qcow2c] (http://cloud.centos.org/centos/7/images/)

kvm:latest (centos) ✔
kvm:alpine ❌

Cirros-0.3.4-x86_64-disk.img

kvm:latest (centos): ❌ (qcow doesn't work, img does)
kvm:alpine:  ❌

[Debian Wheezy (qcow2)] (https://people.debian.org/~aurel32/qemu/amd64/debian_wheezy_amd64_standard.qcow2)

kvm:latest (centos): ❌ getting dhclient: 5 bad udp checksums in 5 packets in syslog.
kvm:alpine: ❌ getting debian-amd64 dhclient: No DHCPOFFERS received.

Good news and bad news:
According to this bug report from Debian, and this other from Centos it seems that:

This is due to dhclient checking the checksum of udp packets it receives, but checksums are not computed if the packets don't leave through a physical interface.

Adding this to the Centos KVM container before launching the startvm script:
iptables -A POSTROUTING -t mangle -p udp --dport bootpc -j CHECKSUM
--checksum-fill

makes that guest VM gets the IP address served by dhclient in the KVM container. (Hurray!)
Also, in a Vagrant bug report regarding the same issue, someone cites a Xen Networking Wiki with another solution:
ethtool -K <IFACE> tx off

But this doesn't seem to work with this KVM Centos container. I have run the command with all the ethX interfaces, with no success within a Debian guest. It doesn't work with macvlan/macvtap devices either.
The problem here is that with Alpine container there is no iptables, so the solution is not possible. Adding this package to Alpine is an option, but seems very ugly to me.
Any ideas? cc/ @panchoh  @rodrigofuente  ?
Meanwhile I will do more test with several guest OSes.

Fix tested with:

CentOS 6.8 (Nuage VSD)

kvm:latest (centos) :white_check_mark:
kvm:alpine :x:

CentOS-7-x86_64-GenericCloud-1608.qcow2c

kvm:latest (centos) :white_check_mark:
kvm:alpine :x:

Cirros-0.3.4-x86_64-disk.img

kvm:latest (centos): :white_check_mark:  (qcow doesn't work, img does)
kvm:alpine:  :x:

Debian Wheezy (qcow2)

kvm:latest (centos): :white_check_mark:
kvm:alpine: :x: getting debian-amd64 dhclient: No DHCPOFFERS received.


use https submodule urls

recursive cloning fails in environments where the git protocol is blocked (firewalled)

Thanks! Looking at the history, it appears that we switched to the git protocol due to Travis problems, but based on the test run, that no longer appears to be an issue.

thank you for looking after this so promptly


ProfileScreen example infer  minHeight and maxHeight

Is it possible to infer the min and max height for the header without specifying it? I am trying to have a UIViewRepresentable as a large and small header but their height cannot be calculated for some reason and they are dynamic in nature.

Hey @takasurazeem, it is impossible for the library to assume your desired max and min heights, since API only accepts one view builder for the header, so one can interpolate their changes smoothly. If you want to use two different views for expanded and collapsed header, please use GeometryReader to calculate your header's sizes and pass it to the library


Dockerfile.control-plane fix missing hosted-cluster-config-operator

This was removed in #823

/retitle Dockerfile.control-plane fix missing hosted-cluster-config-operator

/lgtm
/approve

It seems we are using this in the Dockerfile.control-plane for the CI brew builds, can we make sure we gate PRs on it? cc @ironcladlou

Also see related https://github.com/openshift/release/pull/25092

/retest

/retest

/retest

/hold
to make sure https://github.com/openshift/hypershift/pull/836 merges asap

/hold cancel

Superceded by https://github.com/openshift/hypershift/pull/829


Improve UI for MatchTest

Resolve #89

Display indexes should not change when user matches the cards correctly.
Display a timer during a matching test.
Remove white space under AttemptList when window is big enough.
The questions and answers during a MatchTest should not be truncated.
Reduce the size of each ListCell so as to reduce the need for scrolling.

Pull Request Test Coverage Report for Build 531

18 of 62 (29.03%)  changed or added relevant lines in 11 files are covered.
9 unchanged lines in 4 files lost coverage.
Overall coverage decreased (-0.6%) to 85.056%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

src/main/java/seedu/address/ui/test/matchtest/MatchAttemptView.java
0
1
0.0%

src/main/java/seedu/address/ui/test/matchtest/MatchTestResultPage.java
0
1
0.0%

src/main/java/seedu/address/model/test/matchtest/MatchTest.java
15
17
88.24%

src/main/java/seedu/address/ui/test/matchtest/AnswerView.java
0
2
0.0%

src/main/java/seedu/address/ui/test/matchtest/QuestionView.java
0
2
0.0%

src/main/java/seedu/address/ui/test/matchtest/MatchTestPage.java
0
4
0.0%

src/main/java/seedu/address/ui/test/matchtest/AnswerListPanel.java
0
16
0.0%

src/main/java/seedu/address/ui/test/matchtest/QuestionListPanel.java
0
16
0.0%

Files with Coverage Reduction
New Missed Lines
%

src/main/java/seedu/address/ui/test/matchtest/QuestionView.java
1
0.0%

src/main/java/seedu/address/ui/test/matchtest/AnswerView.java
1
0.0%

src/main/java/seedu/address/ui/test/matchtest/AnswerListPanel.java
3
0.0%

src/main/java/seedu/address/ui/test/matchtest/QuestionListPanel.java
4
0.0%

Totals

Change from base Build 478:
-0.6%

Covered Lines:
2271

Relevant Lines:
2670

💛  - Coveralls

Pull Request Test Coverage Report for Build 482

18 of 62 (29.03%)  changed or added relevant lines in 11 files are covered.
9 unchanged lines in 4 files lost coverage.
Overall coverage decreased (-0.6%) to 85.056%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

src/main/java/seedu/address/ui/test/matchtest/MatchAttemptView.java
0
1
0.0%

src/main/java/seedu/address/ui/test/matchtest/MatchTestResultPage.java
0
1
0.0%

src/main/java/seedu/address/model/test/matchtest/MatchTest.java
15
17
88.24%

src/main/java/seedu/address/ui/test/matchtest/AnswerView.java
0
2
0.0%

src/main/java/seedu/address/ui/test/matchtest/QuestionView.java
0
2
0.0%

src/main/java/seedu/address/ui/test/matchtest/MatchTestPage.java
0
4
0.0%

src/main/java/seedu/address/ui/test/matchtest/AnswerListPanel.java
0
16
0.0%

src/main/java/seedu/address/ui/test/matchtest/QuestionListPanel.java
0
16
0.0%

Files with Coverage Reduction
New Missed Lines
%

src/main/java/seedu/address/ui/test/matchtest/QuestionView.java
1
0.0%

src/main/java/seedu/address/ui/test/matchtest/AnswerView.java
1
0.0%

src/main/java/seedu/address/ui/test/matchtest/AnswerListPanel.java
3
0.0%

src/main/java/seedu/address/ui/test/matchtest/QuestionListPanel.java
4
0.0%

Totals

Change from base Build 478:
-0.6%

Covered Lines:
2271

Relevant Lines:
2670

💛  - Coveralls


Strange behaviour on DTLS handshake with fork() - odd clients timeout and server throws no error.

Description

Type: Question / Bug?
Priority: Blocker

Bug / Question
Hi,
I'm trying to fork a DTLS server in order to be able to have multiple connections within one solution.
I've been playing with mbedtls for about a week and I've been able to do amazing things with it, however I'm currently in need of transforming my TLS client to DTLS and will need a DTLS server.
I'm trying to fork() the connection and I managed to make it work, however I'm facing the strangest behaviour:
Only pair clients are able to connect. I've been trying to track this down for a good 48 hours with no success.
So, the first client connects just fine,
I connect a second client and it gets stuck on the handshake.
However, if I connect a third client right after it works, and so on.
Every client that connects after a failure works, every client that connects after a successful connection doesn't!
There's no error on the server side, just a timeout on the client side and consecutive retries - all end up in error.
Now the strange part:
The good clients hello goes as expected (linked bellow "good.txt", redacted), but every odd client (linked bellow "bad.txt", original logs) freaks out and even the logs show impossible things, as they're missing some debug lines and showing others just a couple lines bellow...
(Logs bellow made with debug level 5)
good.txt
bad.txt
I've tried resetting and/or reinitializing almost everything in group and separate after a successful connection on the main thread, I've tried to track the library code but without any success... no matter what I do only pair clients work and the logs come back nearly blank!
Please note I've been a programmer for a long time but I've few experience with C/CPP.
I hope someone can shed some light into this.
I believe that for someone experienced it may be a simple thing - if it's not I can make the necessary changes to the sample programs and upload them for testing, as I managed to replicate it by slightly altering the original samples.
Thank you for your time!
PLEASE NOTE: I'm only posting here because I do believe this is a bug but unfortunately I've not managed to track it yet, however I'll keep trying and keep this posted.
OS
OSX
mbed TLS build:
Version: 66b7edb10865809a972362ce362c62820075ade3
OS version: 10.14.4
Configuration: used_config.txt
Compiler and options (if you used a pre-built binary, please indicate how you obtained it):
I'm using make with a simple config to define the config path.
Expected behavior
Handshake should work on every new connection.
Actual behavior
Handshake is only working every 2 connections.
There's no error on the server side, just a timeout on the client side and consecutive retries - all end up in error.
Steps to reproduce
Using the demos at programs/ssl:

Add fork to the DTLS server on every successfully connection (after handshake).
Set a loop on writing and reading both on the DTLS server and client so that the sockets stay on.
Start the server.
Connect a first client (it will work).
Connect a 2nd client, bad.txt will happen and it will get stuck on the handshake.
Connect a 3rd client and it will work!
Connect a 4th and it will get stuck on the handshake.
Connect a 5th and it will work.
And so on....

Hi @WhiteaglePT
Have you tried using the ssl_fork_server sample application with the ssl_client2 application? I would try first doing a TLS handshake, and then modify the server to do a DTLS handshake.''
The log is not entirely clear, but could you check if you are using a seperate mbedtls_ssl_context for every fork \ connection?

Hi!
Thank you for your reply!
I based my code on top of DTLS client & server sample applications.
As per your request I made sure to double check my resets properly and not logs are fine and back to normal on both versions!
The error persists,
However I came across to issue #1124 and by setting mbedtls_ssl_cookie_write and mbedtls_ssl_cookie_check to NULL on mbedtls_ssl_conf_dtls_cookies it started working - so the error is somewhere on HelloVerify.
I'm closing this as I'm sure it's not library related at this point - even though I'm resetting both the cache context & cookie context I'm sure it's something I'm missing here.
Thanks again for getting me unstuck!


Refactor tests to have a common base

Currently we are duplicating a lot of tests because this project supports either Local or Instrumented tests. We should use a configuration much like this one.
This will ease verifying common cases without sacrificing much.

Done


Add an option to expose the metric timestamps from the Prometheus format

Spin off from https://github.com/prometheus/client_python/pull/967 and https://github.com/prometheus/client_python/issues/847
Background
The Prometheus exposition format (https://github.com/prometheus/docs/blob/main/content/docs/instrumenting/exposition_formats.md#comments-help-text-and-type-information) allows exporters to specify an optional timestamp for each sample. If this is unset, the collector uses the timestamp that the sample is collected.
This timestamp is useful in a certain situation. My concrete use case is to expose GitHub API rate limit as a metric. This API rate limit is a value that decreases over time, and periodically it resets to the maximum value. We can get this API rate limit value as a HTTP response header when calling GitHub API.
Imagine a situation where there are two (physical) servers making this GitHub API call, and for the sake of illustration, let's assume that one server issues more requests and the other one does less.
| Server1 (frequently issue requests) | Server2 (somehow less requests)
-- | -- | --
Observed API limit | 100 | 4900
(Last time a server made a GH API call) | 3 minutes ago | 50 minutes ago
From human's point of view, because server1 made an API call more recently than server2, we can tell that server1's observed API limit is the current value. However, without exposing the sample timestamp, Prometheus cannot distinguish which one is the most recent value. This is because when Prometheus collects sample from these two servers, when there's no timestamp specified, it treats these samples as "the samples collected now".
By exposing the sample timestamp, Prometheus should be able to treat these two samples correctly, and it can tell that server1' s value is the most recent value.
Request
With https://github.com/prometheus/client_python/pull/967, client_python should learn timestamps for Gauge metrics in the multiprocessing mode. This issue is asking for an option to expose those timestamps via Prometheus format.
Code pointers
Sample already can take a timestamp (https://github.com/prometheus/client_python/blob/249490e4ed30d4266182cfce50fe7046a484affd/prometheus_client/samples.py#L49), and so as the Prometheus exposition formatter (https://github.com/prometheus/client_python/blob/249490e4ed30d4266182cfce50fe7046a484affd/prometheus_client/exposition.py#L191-L194).
For the multiprocessing mode, changing the metrics aggregation logic to propagate the timestamps (https://github.com/prometheus/client_python/blob/249490e4ed30d4266182cfce50fe7046a484affd/prometheus_client/multiprocess.py#L146) would suffice (based on a flag or something).
For the non-multiprocessing mode, need to change this _child_samples (https://github.com/prometheus/client_python/blob/249490e4ed30d4266182cfce50fe7046a484affd/prometheus_client/metrics.py#L433-L434) to take a timestamp.

I would vote no for this.
If you need sample timestamps, then implement Prometheus exposition yourself. It is very easy (I did this multiple times in Python with very little code).
Generic code and servers should never set timestamps, and as Prometheus documentation says this should not be supported in libraries by default.
The Gauge aggregation from multiple processes, is a different store. It is required there internally to have timestamp, to be able to find what was the most recent Set of the gauge. But this value is purely due to Python multi processing.


Remove consecutively repeated Azure word

@surajssd : Thanks for your contribution! The author(s) have been notified to review your proposed change.

#label:"aq-pr-triaged"

@surajssd Thank you for the contribution!
#sign-off

@ktoliver : Thanks for your contribution! The author(s) have been notified to review your proposed change.


Listener enqueue on CR (to trigger reconciliation)

The manifest operator uses the listener library to listen to events sent by the watcher from each SKR cluster.
As part of this backlog item:

[x] Enhance listener implementation to include the kyma-name label in the event objects dispatched to the manifest operator event handler #24
[ ] Implement event handler logic for the manifest operator for events received by the listener  https://github.com/kyma-project/manifest-operator/pull/27

Blocked by https://github.com/kyma-project/manifest-operator/pull/56


feat(http-log): add a feature

Summary

Checklist

[ ] The Pull Request has tests
[ ] A changelog file has been added to CHANGELOG/unreleased/kong or adding skip-changelog label on PR if unnecessary. README.md (Please ping @vm-001 if you need help)
[ ] There is a user-facing docs PR against https://github.com/Kong/docs.konghq.com - PUT DOCS PR HERE

Full changelog

[Implement ...]

message:
type:
scope:
prs:
issues:

Changelog
message: add a feature Introduce a new fields a and b and c and d
type:
scope: Plugin
prs:
issues:
- 1000
- 1001

Issue reference

FTI-1000 KAG-100

/update-changelog


please add CodePen link to

Describe the Issue
In the amazing doc of README.md, the CodePen website doesn't have a link.
When a great website, like a CodePen, doesn't have a link in a README.md of a quality OpenSource project,
a small kitten starts crying somewhere. A small, shaking, frozen kitten.
Please think of kittens and add a hyperlink to the CodePen.
BTW, you are being recorded live for the benefit of fighting racism & underrepresentation with OpenSource.
Find yourself at TogetherWeOpenSource YouTube channel :)
Special thanks to @eazyangel  who made this ticket happen, as we have realized there are no open "first timers only" tickets available.
Affected Page
https://github.com/freeCodeCamp/freeCodeCamp/blob/main/README.md
Steps to Reproduce
Open the README.md and try clicking on CodePen. Nothing happens, but ideally, it should transfer to the CodePen's webpage.
Recommended fix or suggestions
Make CodePen a hyperlink, pointing at the correct web page.
Screenshots

Thank you for raising this issue. Hopefully it gets fixed soon

Congrats on the contribution, you are amazing. Really.

Please don't use our issue tracker to advertise your project. That's not very friendly.

Please don't use our issue tracker to advertise your project. That's not very friendly.
Are you saying we shouldn't add this or should we? I can add this if you'd like.

I have not weighed in on if this is needed or not - I'm not familiar with the current preferences on the README, but we generally limit external links.
My comment was more pointing out that this issue is largely an advertisement for OP's YouTube channel, and trying to use an issue tracker to get advertising is rude, in my opinion.

I have not weighed in on if this is needed or not - I'm not familiar with the current preferences on the README, but we generally limit external links.
My comment was more pointing out that this issue is largely an advertisement for OP's YouTube channel, and trying to use an issue tracker to get advertising is rude, in my opinion.

I totally agree with this. I can add the link and then if they approve it then we know it's okay. I might also add a link to replit since it occurs in the same sentence just to keep it consistent.

I'd wait until someone else weighs in. Like I said, we generally limit external links in our content and I'm not sure if that policy applies here or not.

I'd wait until someone else weighs in. Like I said, we generally limit external links in our content and I'm not sure if that policy applies here or not.
It is better to wait for an issue to be ready for a PR rather than making a premature PR and having the content get changed a bunch as everyone gets a chance to weigh in.

Oh, I see this message now. Sorry. I will do that the next time.

No worries - I was just trying to save on extra work/confusion. You'll know for next time.

No worries - I was just trying to save on extra work/confusion. You'll know for next time.

I really appreciate all the help. I'm super new to this so learning how these kinds of things are implemented are really helpful.

@nikitakoselev Thank you for bringing this to our attention, I have edited your original post, to remove self advertisement.
If you talked to someone about you being able to post your YouTube channel, please let them know, so they can help you post it back.

Thanks for taking the time to create this issue. I think people interested in this project can quickly figure out popular services and apps.
We do not think there is any need to add links to everything. Adding a link to every technology / app / service that we mention in our content will just make things more cumbersome.
Thanks.

Hi, I wanted to say I'm sorry for the advertising. I'm autistic, sometimes I make mistakes like that one :(
My goal is to help people from underrepresented and underprivileged groups to start contributing to OpenSource.
I believe this way they can find an impactful project close to their hearts and find a good job, eventually.
Once again, I am sorry for advertising and I want to thank you for your feedback.


updated verse check check boxes again

Reason codes on verse edit should not overlap

Test

Open the verse edit area and make sure the reason codes don't overlap

This change is

Comments from Reviewable

Reviewed 1 of 1 files at r1.
Review status: all files reviewed at latest revision, all discussions resolved.

Comments from Reviewable


option to silence greeting?

Hi,
I've been playing around with rtichoke lately. It's a nice piece of software!
Would it be possible to silence the greeting?
this line perhaps controllabe by a flag added here
Maybe adding a "--quiet" command line argument to rtichoke, to match R's flag?

Checkout the development version and here you are.~

Awesome! Thank you!


DCR: Adaptive Dialog custom recognizer implementation sample

see https://github.com/microsoft/BotBuilder-Samples/issues/1990 for context

@cwhitten do you already have a recognizer sample? Is this just a doc ticket?

@vishwacsena, should we close this? IT's been here since early December, making it more than 5 months old.


CCL draft RFC

This is the draft RFC for the Cryptographic Construction Language (CCL) for encoding cryptographic constructions in a self-describing way that is independent from the underlying crypto library.
Signed-off-by: Dave Huseby<EMAIL_ADDRESS>

@danintel There are three commits in this PR. I addressed your feedback in the second commit---https://github.com/hyperledger/ursa-rfcs/pull/17/commits/4cf639161276adf9f2de16fac9bcd7a508125b85---and then later added some minor clean ups in the third commit.

@dhuseby: I saw the multiple commits.  Usually the commits are aggregated under "Files changed".  I'll look again.

If I understand well your value proposition, you may want to acknowledge Zencode as prior art:

https://dev.zenroom.org/Zencode
https://zenroom.org
We already use it connected to an hyperledger product.

If I understand well your value proposition, you may want to acknowledge Zencode as prior art:
* https://dev.zenroom.org/Zencode

* https://zenroom.org
  We already use it connected to an hyperledger product.

I have been reading LangSec papers for years and, like zenroom, a lot of the thinking is inspired from there. However, after looking at Zenroom and Zencode, it isn't an inspiration for CCL. CCL isn't about the VM, it's more about a uniform way to serialize crypto constructs. Crypto constructs almost always consist of some data and some implied processing of that data to validate, verify, authenticate, encrypt, decrypt, etc. CCL acknowledges that fact and explicitly encodes the processing along with the data. Using a stack machine as the "VM" for executing the CCL encoded constructs just simplifies things and drastically limits attack surface area by allowing for a non-Turing-complete deterministic DSL to be used.

Thanks for the clarification! I'll be following the CCL specification with great interest.

Love this idea. Just some minor things to include and I think we’ve got a good start

I just published v0.1.0 of my CCLang implementation. I scaled back on some of the algorithms to get a MVP. The repo is here: https://github.com/dhuseby/cclang and the crate page is here: https://crates.io/crates/cclang

My hope is that CCLang will stop using sodiumoxide as it's crypto library and instead be built into Ursa and integrated with Ursa's build system so that depending on how Ursa is built, the CCLang algorithms and underlying primitives are set up accordingly. This would allow consumers of Ursa to use CCLang in FIPS mode or "open crypto" mode or with any of the restricted sets of algorithms and underlying crypto libraries.

I gather this should be closed now?


Update URLs

Point to the new home at https://github.com/pydot/pydot

Ah, I'm terrible sorry but I didn't noticed your PR, I've updated links when I made a new release today in 9e1f54e4cbeaf8ffedc3278b57b930ba6618aa4d
Thank you very much @hugovk

Cherry-picked https://github.com/pydot/pydot/commit/453014184c8f264df9b9afe2ad3c7094c142f424


Re-inline process.env.NODE_ENV === 'production' checks as uglify does…

…n't do constant folding.
Unlike closure compiler, uglify cannot fold constants, which causes the asserts to still be present in the dist file. I had already made the mistake of pulling out the production state into a separate variable once during the initial development, but forgot about it when merging the PR to pull it out into a variable.
@cramforce

Might be worth doubling down on babel?

I didn't see it out of the box, but good to know that there is a plug-in for it. I'll take a look in the es6 branch to see how it works.

LGTM
Such a mess.

The source of the Babel constant folding plugin uses Symbol.iterator, so I can't use that. I'm not sure if I need to install something or use a gulpfile.babel.js, but that was a less than ideal experience.

The source of all the official plugins are written in ES6 and compiled to ES5 before distribution

I was using https://babeljs.io/docs/advanced/transformers/minification/constant-folding/, it definitely was using Symbol.iterator at runtime, but it did say it was experimental when running it.

Oh it's using for..of
@sebmck should we be compiling plugins with the aliased polyfills included?

Probably not. Just use a normal for loop.
On Thu, Jul 30, 2015 at 5:46 PM, James Kyle<EMAIL_ADDRESS>wrote:

Oh it's using for..of
@sebmck should we be compiling plugins with the aliased polyfills included?
Reply to this email directly or view it on GitHub:
https://github.com/google/incremental-dom/pull/78#issuecomment-126398703


libjcat: 0.1.2 -> 0.1.3

Changelog: https://github.com/hughsie/libjcat/blob/0.1.3/NEWS

Motivation for this change

https://github.com/justinsteven/advisories/blob/master/2020_fwupd_dangling_s3_bucket_and_CVE-2020-10759_signature_verification_bypass.md
https://nvd.nist.gov/vuln/detail/CVE-2020-10759

Things done

[x] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
Built on platform(s)

[x] NixOS
[ ] macOS
[ ] other Linux distributions

[x] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[x] Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
[ ] Tested execution of all binary files (usually in ./result/bin/)
[ ] Determined the impact on package closure size (by running nix path-info -S before and after)
[ ] Ensured that relevant documentation is up to date
[x] Fits CONTRIBUTING.md.

@GrahamcOfBorg build fwupd.tests

Thanks.
We probably need to apply https://github.com/fwupd/fwupd/commit/21f2d12fccef63b8aaa99ec53278ce18250b0444.patch to 20.03.


with one chain running already, when running bridge command it doesn't start another chain

Overview
Run any chain and when we run bridge command it fails.
Steps to Reproduce
Steps to reproduce the behavior:

run dive chain icon -d
run dive bridge btp --chainA icon --chainB eth
Observe it throws error

Expected Behavior
Expected the bridge command to start the chain that is not running and start a bridge between them

Closing this issue as fixed.
command to run these kind of scenaros - dive bridge btp --chainA icon --chainB eth --chainAServiceName icon-node-0xacbc4e


metrics throw -> console message

should fix #138  #135 #134

@mAiNiNfEcTiOn @staabm @epodgaetskiy, I've just published new v3.1.1 to npm.
Since metrics like Time to Consistently Interactive and First Interactive are in BETA, they might be missed sometimes and don't cover all cases.
So don't be surprised seeing

In another case, it's better than just throwing without any progress.
btw, feel free to reopen your issues if they still are reproduced.

Thanks @denar90 .... will try this new version then 😊

I see metrics for the first time ;-) \o/ thx.


logger timestamp and tab-delimited

Thanks to the developer's work, my problem is that I used the adb logcat > d: / XXX. TXT redirected to a file, use logger no timestamp is very convenient, can add a timestamp?
2. Without the tab-delimited time can remove the tab-delimited

@zorro0799 I'm sorry, I didn't understand the issue clearly. Do you need timestamp in logs? Current logcat already contains one though.
Can you elaborate the second part? Thanks

Closing this issue since the issue is not clear.


FHIR Alignments

There are quite a few changes because I have renamed some properties in base to align better with FHIR. This will be a process that will take more than just this pull request, but I don't want to let it get too big.

Closing... going to do another pull soon with updated version.

Travis failures are all from in es6 exporter. Otherwise the build is clean. I suggest we take this as the new baseline for dev.


NTPSec

Motivation for this change
NTPSec is fork of ntpd, and there for a  drop in replacement of it. It includes numerous security fixes and improvements, as well as implementations of secure time protocols such as NTS.
Instead of creating a new ntpsec service configuration, I decided it would be better to just reuse the existing ntp configuration, and add a few more customizations to that that one.
This is my first time trying to upstream a nix package, please feel free to point out anything I can do better.
Things done

[X] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
Built on platform(s)

[X] NixOS
[ ] macOS
[X] other Linux distributions (archlinux)

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
[X] Tested execution of all binary files (usually in ./result/bin/)
[ ] Determined the impact on package closure size (by running nix path-info -S before and after)
[X] Assured whether relevant documentation is up to date
[X] Fits CONTRIBUTING.md.

Thanks, commit messages are now fixed up.

Anything blocking this from getting merged now?

Version bumped to 1.1.6.

Version bumped to 1.1.7.

@georgyo Sorry this is taking so long to get in. It looks good to me except for that one pname thing. Could you fix that and we should be good to go?

@GrahamcOfBorg  build ntpsec

Looks like it is failing the OfBorg build check on x86-64 too.

Interesting. I think this is failing to build with gcc9 which is now on master. I'll take a deeper look this weekend.


fix: support for defaultProps will be removed from function components

Hi @cedricdelpoux,
Small fix to replacle defaultProps with default parameters

Hello @PatrykBukowski. Thanks for your help. I just published v2.1.7 with your fix


nsc-events-nextjs_9_528_responsive-ui-for-home-page

Resolves #528

Good work thus far. I like what you are doing, and was able to checkout your branch and test out some of the styling done. I like your implementation of flex so that its more responsive.

@ken-ni When we switched to MUI, we were moving away from using the stylesheets, and the Home page and Event details pages were the only pages that were using them at that point. It was also much easier to manipulate the pages to be responsive with inline styling.

@intisarosman1 I set a minimum width so the event card will be at least 460 px wide. It looks better now when there are less events, but it would start to break if I made it any wider than this.

@intisarosman1 I set a minimum width so the event card will be at least 460 px wide. It looks better now when there are less events, but it would start to break if I made it any wider than this.

Looks better now!


Modify docs based on the documentation

I have updated the documentation based on the feedback. Since I don't have the access to directly to this repo, I haven't let mkdocs to deploy the page.

I have pushed the changes based on your comments. Please have a check.


Exception on the second step of run-test script on OS X.

Hello,
I'm trying to run the test script on OS X 10.10 with python 2.7. An exception is throw at the second step running ocropus-gpageseg.
MacBook-Pro-2:ocropy pujia$ PATH=$PATH:. ./run-test
# tests/testpage.png
=== tests/testpage.png 1
estimating skew angle
estimating thresholds
rescaling
tests/testpage.png lo-hi (0.39 1.44) angle  0.1  no-normalization
writing

########## ./ocropus-gpageseg temp/????.bin.png

temp/0001.bin.png
Traceback (most recent call last):
  File "./ocropus-gpageseg", line 414, in safe_process1
    process1(job)
  File "./ocropus-gpageseg", line 356, in process1
    scale = psegutils.estimate_scale(binary)
  File "/Users/pujia/git-workspace/ocropy/ocrolib/psegutils.py", line 41, in estimate_scale
    objects = binary_objects(binary)
  File "/Users/pujia/git-workspace/ocropy/ocrolib/psegutils.py", line 37, in binary_objects
    objects = morph.find_objects(labels)
  File "/Users/pujia/git-workspace/ocropy/ocrolib/toplevel.py", line 209, in argument_checks
    raise e
CheckError:
CheckError for argument image of function <function find_objects at 0x103972398>
<ndarray-7fbead2b6420 (3000, 2078) uint64 [0,5187]> of type <type 'numpy.ndarray'>: array must contain integer values

########## ./ocropus-rpred -n temp/????/??????.bin.png

Traceback (most recent call last):
  File "./ocropus-rpred", line 92, in <module>
    inputs = ocrolib.glob_all(args.files)
  File "/Users/pujia/git-workspace/ocropy/ocrolib/toplevel.py", line 213, in argument_checks
    result = f(*args,**kw)
  File "/Users/pujia/git-workspace/ocropy/ocrolib/common.py", line 654, in glob_all
    raise FileNotFound("%s: expansion did not yield any files"%arg)
ocrolib.common.FileNotFound: file not found temp/????/??????.bin.png: expansion did not yield any files

I just want to check to see if this issue is known before I start debug from bottom up. Thanks.

Some of the morphology functions in scipy.ndimage take only a restricted set of types, and that set seems to be platform dependent. I'm not sure what a portable solution to that problem is. You could add a line that coerces the image to the right type just for OS X. If you find a portable solution, please share it.

I have the same problem? I am using Ubuntu 14.04.3 LTS
INFO:  ########## /usr/local/bin/ocropus-rpred -n temp/????/??????.bin.png
INFO:
Traceback (most recent call last):
File "/usr/local/bin/ocropus-rpred", line 98, in
inputs = ocrolib.glob_all(args.files)
File "/usr/local/lib/python2.7/dist-packages/ocrolib/toplevel.py", line 213, in argument_checks
result = f(*args,**kw)
File "/usr/local/lib/python2.7/dist-packages/ocrolib/common.py", line 654, in glob_all
raise FileNotFound("%s: expansion did not yield any files"%arg)

@tmbdev can you tell me how to do so? Thanks

@mrfortynine can you please share your solution with me as well? Thanks

@mrfortynine can you please share your solution with me as well? Thanks

Sorry, I have not continued pursuing this.

I got the same error too, how did you fix this at that time?

@jmokoistinen's problem probably unrelated, missing the binarized images could be for many reasons.
If this is a consistent problem, it would be helpful to have further details on system configuration and library versions like scipy to reproduce it.

The original issue was fixed in https://github.com/tmbdev/ocropy/commit/9be1ae0eeae8772316fc5c3f354e44d3bf98089c . Any other report here could be caused by another reason. Please update to the newest version and try again. If your problem persists, then open a new issue including your error traceback.


fix: updating a non-existing property will add a new property to the …

some typo

already corrected


Fix event listener

This PR fix the event listener for execute only in master request

@lexikteam please merge this

@cedric-g please merge this PR :D


[ENHANCEMENT] KDE Edition

I would like to see a KDE version of it. I always dislike Gnome due to its lack of features and customizability (especially when compared to KDE). The customizations applied to Gnome are great in aesthetics. I really like it. But I have a specific workflow and specific customizations that are not possible in Gnome. Even in Kali Linux, I use KDE and not the default XFCE version. I have previously used Blackarch installed on top of Manjaro. It was fine. But the performance was not that good. I installed Blackarch on top of Athena and it was really going well. If it weren't for Gnome, I wouldn't have uninstalled it. Thanks to you, I came to know more platforms like HTB and THM. I even made accounts in others and solved many challenges. All the time, the performance was so good. I really love the customizations made by you. But Gnome is the biggest obstacle. You may say that KDE is way more bloated and may reduce performance. But Xerolinux is, as they describe it, the best for eye candy lovers and it is extremely good. It is extremely beautiful. I even use it now. So smooth. No lag even with so many customizations. Absolutely beautiful. I can't install Blackarch in this one as it is as a daily driver. That's the problem with this one. This is also the reason I have Kali Linux (separate) as mentioned above. I'd love to see the KDE version. And the best choice for the terminal: Kitty. This choice is excellent. As much as I hate Python for desktop apps (only for desktop apps (GUI terminals included). I love Python for the rest), it is far better than Alacritty. Alacritty is always slower than any other terminal for me. I hate it. Kitty was also customized, and it was fast and smooth.

Hey! For sure in my mind Athena should give the chance to the user to install the preferred desktop environment, so my intention is to implement also KDE in the future.

Hey! For sure in my mind Athena should give the chance to the user to install the preferred desktop environment, so my intention is to implement also KDE in the future.

After I install the xfce desktop version, can I install the gnome desktop again? Can you freely switch between the two desktops?

Hey! For sure in my mind Athena should give the chance to the user to install the preferred desktop environment, so my intention is to implement also KDE in the future.

After I install the xfce desktop version, can I install the gnome desktop again? Can you freely switch between the two desktops?

In theory yes, but why should you do this?

KDE version implemented.


Error deleting fragment 1088: [WinError 5] Access is denied

I really cant explain what happened here
I got that error a few times before but I just deleted the fragments afterwards and the final file was fine so I just ignored it
but the rest is new the output file is only 1mb and not playable
full log

https://pastebin.com/BZwh361h

[WinError 5] Zugriff verweigert
means access denied
[WinError 32] Der Prozess kann nicht auf die Datei zugreifen, da sie von einem anderen Prozess verwendet wird
means the process cant access the file because its used by another process
my ffmpeg version

ffmpeg version 2021-02-10-git-e0fd35d867-full_build-www.gyan.dev Copyright (c) 2000-2021 the FFmpeg developers built with gcc 10.2.0 (Rev6, Built by MSYS2 project)

edit: since im already here i tried recording haachamas unarchived stream
log:

C:\Users\Lytexx\Downloads>python ytarchive.py -c "cookies.txt" --threads 4 -w --add-metadata -v --vp9 -t -o "[%(upload_date)s] %(title)s %(channel)s"
Enter a youtube video URL: https://www.youtube.com/watch?v=UBRDsFtZIIw
16:42:09 INFO: Loaded cookie file cookies.txt
Available video qualities: audio_only, 144p, 240p, 360p, 480p, 720p, best
Enter desired video quality:
Selected quality: 720p (VP9)
16:42:15 INFO: Starting download to audio[20210216] STRESS-FREE　※No archive※ Akaihaato Ch. 赤井はあと.f140.ts
16:42:15 INFO: Starting download to video[20210216] STRESS-FREE　※No archive※ Akaihaato Ch. 赤井はあと.f247.ts
16:45:15 INFO: Deleting file video[20210216] STRESS-FREE　※No archive※ Akaihaato Ch. 赤井はあと.f247.frag1255.ts
16:45:17 INFO: Deleting file audio[20210216] STRESS-FREE　※No archive※ Akaihaato Ch. 赤井はあと.f140.frag1253.ts
16:45:17 INFO: Deleting file video[20210216] STRESS-FREE　※No archive※ Akaihaato Ch. 赤井はあと.f247.frag1253.ts
16:45:24 INFO: Deleting file video[20210216] STRESS-FREE　※No archive※ Akaihaato Ch. 赤井はあと.f247.frag1254.ts
Video fragments: 1253; Audio fragments: 1253; Total Downloaded: 431.85MiB
16:45:26 INFO: Muxing files
execute returned code 1. Something must have gone wrong with ffmpeg.

the stream was ~1hour but the final file only 37:02 long

I assume in both cases, the final .ts files were kept since ffmpeg returned a code other than 0, right?
If you kept them could you use ffprobe on the video files and post the output here?
ffprobe -hide_banner <file>

No I sadly deleted them right after
I tried recording 2 streams today and both didnt have any problem delete fragments
both logs

https://pastebin.com/F0d6ERKY
https://pastebin.com/BS7ZkGKF

if its necessary to fix it I will post the ffprobe output here when it happens again

That would be helpful, thanks. Also would be helpful to continue using --debug like that instead of -v like with the first log.
I've started downloading streams in my Windows VM as well to see if I ever encounter any issues there. So far though I've had no issues in 8 streams.

i recorded ames stream and it had problems deleting 2 audio fragments
the file is fine and it doesnt seem like there is missing anything i guess its fine for now but it would still be good if you can fix that somehow so i dont have to delete the fragments everytime it happens
ytarchive output

https://pastebin.com/zpaqwvH8

ffprobe output

https://pastebin.com/5UQG23pt

ffprobe is only needed if you encounter an issue where the final file is broken, thanks though.
As for the fragments failing to delete, I imagine that's mostly on Windows, since it's intermittent. I can add some code to try and delete any fragments found after the download finishes, but it's always possible that won't actually help either if Windows continues to decide "lol you don't have permission to delete these files in particular."

The only thing I could think of would be adding a delay before deleting the fragment so we can be sure its not used anymore
but since this error is from windows side and what you implemented works fine (thanks for that) im closing this issue
im making a new issue if one of the other ffmpeg related bugs happen again


User wants constructor and class properties

class Vec2 {
  constructor(public x: float, public y: float) {
     this.x = x;
     this.y = y;
  }
}

Currently thinking of this. While class support is certainly required, this is coupled to the assumption that there is some sort of memory management available, like malloc/free. What bothers me about this is that, to provide classes, a 'standard' library has to be introduced but there might be multiple implementations of a 'standard' library tweaked for different uses cases at some point.
Hence, I propose to make everything not part of the WebAssembly spec a plugin, even classes, and especially memory management like malloc/free.
I imagine that one would do something like npm install assemblyscript @maxgraey/assemblyscript-classes with @maxgraey/assemblyscript-classes having a dependency on @winksaville/assemblyscript-malloc or similar (I just inserted names for the sake of this example).
As you can see, one would have the freedom to pick whatever functionality is required, from whatever author one favors.
This will of course requires plugin support at first. What do you think?

Typescript support classes as build-in entities, as many other languages except javascript which is syntactic sugar over prototypes. So with typescript we have already interface in compiler API and it syntax strictly defined and I don't see reason to make it optional or pluggable. Regarding memory management library thats I agree, we should make possible use different kind of malloc libraries like dlmalloc, jemalloc, tcmalloc or eheap (better for embedded systems). So I see it like some special external interface for importing (plugging) stdlib with your implementation of some runtime libraries.

Hmm, yeah, the more I think about it...
Maybe just an interface to plug in any custom allocator then. What about...
declare function alloc<T>(): Ptr<T>;
declare function free<T>(value: T): bool;

declare function alloc<T>(payloadSize?: uintptr): Ptr<T>;
declare function free<T>(value: Ptr<T>): bool;
declare function realloc<T>(value: Ptr<T>, newSize: int): Ptr<T>;

And exploit dynamic linking and call_indirect for that pluggable library

I would hope the "linking" of entities could be either dynamic or static and was language independent. I'd certainly like to be able to leverage libraries from other languages the most obvious being C/C++ libraries.
So what is the difference between a "pluggable library" vs a "library"?
What is the relationship between simple malloc/free allocators and other types of allocators such as garbage collectors, reference counting ...?

I would hope the "linking" of entities could be either dynamic or static and was language independent

Static linking is possible to some degree, but I have made the experience that current linkers are often tied to a specific kind of toolchain. See, for example, wasm-merge which enforces quite a few things that aren't ultimately necessary in every case.
Dynamic linking can only be done on the JS side today, this is what emscripten does. There is the 'dylink' section that exposes information for the linker, but that's not widely adopted yet.

What is the relationship between simple malloc/free allocators and other types of allocators such as garbage collectors, reference counting ...?

I haven't decided anything yet, but one common denominator is that either of these access the same heap and hence must share state to not conflict with another.

The compiler now statically links memory management routines based on dlmalloc and musl to the application by default. It provides malloc, free, memcpy and memset so far. This should be sufficient to begin with the implementation of pointers and classes.

@dcodeIO Excellent!

Unfortunately, I still haven't fully understood what clang-compiled wasm binaries are doing with the stack. Basically, we have a single data section there holding a value that is supposed to be STACKTOP (here it is 10512). The first call to malloc, however, fills quite a bit of memory at the beginning of the memory block
currently (?). Because I have no clue what is happening there and how to modify it, linking the malloc implementation basically renders the entire memory useless for any other code but the malloc implementation itself. For example, no additional data segments can be introduced without knowing for sure where to put them.
Not long ago I asked a question on StackOverflow regarding this, but I wasn't able to figure out @jfbastien 's answer. What I think I have understood so far is that the code we are compiling from TS to wasm is using the execution stack, which isn't part of the memory, while clang puts everything into memory - but I could be completely mistaken, still. If you are able to enlighten me, please do.

I think it somthing like srbk do in pseudocode:
#define ALIGN 8

int currentStackPos = 0;

char* pushStack(int inc) {
      char* start = (char*)(((long)currentStackPos + ALIGN - 1) & ~(ALIGN - 1));
      char* end  = start + inc;
      currentStackPos = end;
      return start;
}

If I right understand your problem

That's what wasm_morecore is for. Just another name for sbrk.

Using LLVM / Emscripten / s2wasm will put the C++ stack in the 3 places I describe. The last place you want it to be is in memory, but sometimes it has to be there. The simplest way to think of allocating stack in memory is that you malloc stack space super early on, and then point STACKTOP to it.
Sidenote: STACKTOP will likely end up in a WebAssembly global. Its current form is a leftover from asm.js.
If you have your own compiler then you may not need to put any stack things in memory.
FWIW WebAssembly's grow_memory is the same as sbrk.

I believe I got it to work in a conflict-free way now. Not optimal, yet (remaining initial memory isn't reused), but seems to be working.

I found one more implementation:
const NativeNaturalType bitsPerChunk = 1<<19;

void resizeMemory(NativeNaturalType pagesEnd) {
    NativeNaturalType newChunkCount = (pagesEnd*bitsPerPage+bitsPerChunk-1)/bitsPerChunk,
                      size = __builtin_wasm_current_memory()*bitsPerChunk,
                      pad = reinterpret_cast<NativeNaturalType>(superPage)*8,
                      oldChunkCount = (size > pad) ? (size-pad+bitsPerChunk-1)/bitsPerChunk : 0;
    if(newChunkCount > oldChunkCount)
        __builtin_wasm_grow_memory(newChunkCount-oldChunkCount);
    superPage->pagesEnd = pagesEnd;
}

Ok, this is super basic right now, but some things involving constructors and classes should be working now, theoretically. I haven't yet tested anything of this in detail, so please let me know if you are encountering issues - there'll be lots.

Constructors and class properties should be supported now, including static and instance properties as well as property declarations with a visibility keyword in the constructor's declaration.


bring back demo codes

@hoc3426 reports that demographic codes are not present on INSPIRE. On legacy there was
001046447 100__ $$aDickson, Ryan$$gDEPARTED$$qRyan Dickson
001046447 65017 $$2arXiv$$ahep-ex
001046447 65017 $$2arXiv$$aphysics.med-ph
001046447 65017 $$2demo$$ac3) industry/software

vs
https://inspirehep.net/api/authors/1046447
We should add them back.

Here's the list:
 a)  HEPsupport
 a1) HEPsupport/software
 a2) HEPsupport/other
 b)  academia
 b1) academia/otherphysics
 b2) academia/otherscience or engineering
 b3) academia/software
 b4) academia/executive
 b5) academia/other
 c)  industry
 c1) industry/physics
 c2) industry/otherscience or engineering
 c3) industry/software
 c4) industry/executive
 c5) industry/other
 c6) industry/data science
 c7) industry/defense
 d)  government
 d1) government/physics
 d2) government/otherscience or engineering
 d3) government/software
 d4) government/policy
 d5) government/other
 d6) government/defense
 d7) government/military
 e)  financial
 e1) financial/management
 e2) financial/computing or technical support
 e3) financial/quantitative modeling
 e4) financial/other
 f)  non-profit
 g)  teaching
 h)  law
 h1) law/patent
 h2) law/other
 i)  self-employed
 j)  medicine
 j1) medicine/radiation
 j2) medicine/other
 k)  other


luci-mod-network: Does not display accurate wireless status

When multiple SSIDs are configured on a radio, only the first enabled SSID has the correct information displayed in the Wireless Overview and Associated Station sections.  All other SSIDs show "Wireless is not associated" regardless if any stations are connected.  Using iwinfo  assoclist will show connected stations, but these do not appear in the Associated Station list.
I found others have mentioned this problem in the Openwrt forum:
https://forum.openwrt.org/t/davidc502-wrt1200ac-wrt1900acx-wrt3200acm-wrt32x-builds/15839
This behavior was not seen in my previous build from 4 months ago.  I am now running:
LuCI Master (git-20.052.76652-4322cae) / OpenWrt SNAPSHOT r12261-d1130ad265

Please first test whether the problem persists after
make package/rpcd-mod-iwinfo/clean
make package/rpcd-mod-luci/clean
make package/iwinfo/clean

I executed the above as requested with the following modification:
make package/rpcd-mod-iwinfo/clean  - resulted in Error 2
changed to:
make package/rpcd/clean - completed without error
The new build has the same problem with inaccurate info.  I also tried a make dirclean with the same result.  Let me know if you have anymore suggestions.

Unfortunately I cannot reproduce the issue locally. Please provide the complete output of ubus call luci-rpc getWirelessDevices

As requested.
ubus output.txt

Please provide the output of ubus call network.wireless status as well

As requested.
ubus wireless output.txt

The problem seems related to netifd. It does not report the ifnames for the second and third VAP, that's why LuCI cannot correlate the iwinfo runtime data to it.

I also see this issue XIAOMI MINI hardware for 5G interface(MT76)
for 2,4GHz it is OK(rt2x00)

Seems like a regression in OpenWrt master.

Problem was resolved by resetting config back to default then manually re-entering information.


Request for addition of Threshold Attack

I would like to add an implementation of Threshold Attack (https://arxiv.org/pdf/1906.06026.pdf).

Hi @shashankkotyan Thank you for working on adding this new attack to ART! Let us know any time if you have questions.


TLitte issues

I downloaded the source codes and released it to my local computer. I followed all the instruction and got this error. Please let me know if you need any more information.
Thanks
Error: Cannot analyze audio file
C:/Users/xxxx/Documents/example-audio-directory/Rivendell_20210623_113602.wav.
Traceback (most recent call last):
File "", line 268, in analyzeFile
File "", line 217, in predict
File "C:\Program Files\BirdNET-Analyzer-main\model.py", line 121, in predict
loadModel()
File "C:\Program Files\BirdNET-Analyzer-main\model.py", line 38, in loadModel
INTERPRETER = tflite.Interpreter(model_path=cfg.MODEL_PATH, num_threads=cfg.TFLITE_THREADS)
File "C:\PROGRA~3\ANACON~1\envs\PYBIRD~1\lib\site-packages\tensorflow\lite\python\interpreter.py", line 197, in init
_interpreter_wrapper.CreateWrapperFromFile(
ValueError: Op builtin_code out of range: 127. Are you using old TFLite binary with newer model?Registration failed

Thank you! Should now be fixed. https://github.com/nationalparkservice/NSNSDAcoustics/commit/7d05a35355fef54685492468d5d950c9266b9e6d


Add Generate Plans (Button and Backend)

We want to utilize the Plan Builder service in order to generate all supported Plans for a Topology Template. This PR adds the required endpoints to the Winery backend as well as adds a new button into the management UI.
Once the plan generation is triggered, Winery sends a request to the plan builder service. All supported plans get generated and are uploaded to Winery afterward. The whole execution is synchronous, so the Winery UI will wait (loading animation) until the plans were created.

[x] Ensure that you followed http://eclipse.github.io/winery/dev/ToolChain#github---prepare-pull-request.


Fixed #24447 Migrations do not add a FK constraint for an existing column

Migrations failed when introducting foreign keys. The code
didn't detect this case - if old_field.rel doesn't exist
alter_field() must always create the foreign key and ONLY if
.rel exists it must check .db_constraint, too. Since no .rel
also means there was no foreign key before.
Additional:

I have this change for 1.7.x too
If needed I can try to write a test

Hey @ganwell, thank you for the patch. In order to track the bug and the related fixes we do need a ticket in our bug tracker at https://code.djangoproject.com. Since it is bug fix we also need a test that shows the problem.
You might also want to have a look at our patch review checklist.

Hi @MarkusH, thanks for the hint. I created unittests and a ticket. I wasn't sure if I have to attach patch, since this pull request is already open.
https://code.djangoproject.com/ticket/24447

This test can probably live in tests/schema/tests.py and can be rewritten so it doesn't require the full migrations stack (call_command, migrations, etc.).

Can you add a note to the 1.7.6 release notes in docs/releases/1.7.6.txt please.
I have a test ready for 1.8 and master. Can you replace your existing tests with this one:
diff --git a/tests/schema/tests.py b/tests/schema/tests.py
index 2bc47ec..df45ed2 100644
--- a/tests/schema/tests.py
+++ b/tests/schema/tests.py
@@ -546,6 +546,45 @@ class SchemaTests(TransactionTestCase):
             self.fail("No FK constraint for author_id found")

     @unittest.skipUnless(connection.features.supports_foreign_keys, "No FK support")
+    def test_alter_to_fk(self):
+        """
+        #24447 - Tests adding a FK constraint for an existing column
+        """
+        class LocalBook(Model):
+            author = IntegerField()
+            title = CharField(max_length=100, db_index=True)
+            pub_date = DateTimeField()
+
+            class Meta:
+                app_label = 'schema'
+                apps = new_apps
+
+        self.local_models = [LocalBook]
+
+        # Create the tables
+        with connection.schema_editor() as editor:
+            editor.create_model(Author)
+            editor.create_model(LocalBook)
+        # Ensure no FK constraint exists
+        constraints = self.get_constraints(LocalBook._meta.db_table)
+        for name, details in constraints.items():
+            if details['foreign_key']:
+                self.fail('Found an unexpected FK constraint to %s' % details['columns'])
+        old_field = LocalBook._meta.get_field("author")
+        new_field = ForeignKey(Author)
+        new_field.set_attributes_from_name("author")
+        with connection.schema_editor() as editor:
+            editor.alter_field(LocalBook, old_field, new_field, strict=True)
+        constraints = self.get_constraints(LocalBook._meta.db_table)
+        # Ensure FK constraint exists
+        for name, details in constraints.items():
+            if details['foreign_key'] and details['columns'] == ["author_id"]:
+                self.assertEqual(details['foreign_key'], ('schema_author', 'id'))
+                break
+        else:
+            self.fail("No FK constraint for author_id found")
+
+    @unittest.skipUnless(connection.features.supports_foreign_keys, "No FK support")
     def test_alter_o2o_to_fk(self):
         """
         #24163 - Tests altering of OneToOneField to ForeignKey

Since this bug is also in 1.7 here a backport for the committer who is going to backport the patch to 1.7:
diff --git a/django/db/backends/schema.py b/django/db/backends/schema.py
index 54e6e06..391194e 100644
--- a/django/db/backends/schema.py
+++ b/django/db/backends/schema.py
@@ -676,7 +676,7 @@ class BaseDatabaseSchemaEditor(object):
             )
         # Does it have a foreign key?
         if new_field.rel and \
-           (fks_dropped or (old_field.rel and not old_field.db_constraint)) and \
+           (fks_dropped or not old_field.rel or not old_field.db_constraint) and \
            new_field.db_constraint:
             self.execute(self._create_fk_sql(model, new_field, "_fk_%(to_table)s_%(to_column)s"))
         # Rebuild FKs that pointed to us if we previously had to drop them
diff --git a/tests/schema/models.py b/tests/schema/models.py
index 6eba7cc..b933175 100644
--- a/tests/schema/models.py
+++ b/tests/schema/models.py
@@ -87,6 +87,15 @@ class BookWithM2M(models.Model):
         apps = new_apps

+class BookWithoutFK(models.Model):
+    author = models.IntegerField()
+    title = models.CharField(max_length=100, db_index=True)
+    pub_date = models.DateTimeField()
+
+    class Meta:
+        apps = new_apps
+
+
 class TagThrough(models.Model):
     book = models.ForeignKey("schema.BookWithM2MThrough")
     tag = models.ForeignKey("schema.TagM2MTest")
diff --git a/tests/schema/tests.py b/tests/schema/tests.py
index 996cec1..cc95d55 100644
--- a/tests/schema/tests.py
+++ b/tests/schema/tests.py
@@ -11,7 +11,7 @@ from .fields import CustomManyToManyField, InheritedManyToManyField
 from .models import (Author, AuthorWithDefaultHeight, AuthorWithM2M, Book, BookWithLongName,
     BookWithSlug, BookWithM2M, Tag, TagIndexed, TagM2MTest, TagUniqueRename,
     UniqueTest, Thing, TagThrough, BookWithM2MThrough, AuthorTag, AuthorWithM2MThrough,
-    AuthorWithEvenLongerName, BookWeak, Note, BookWithO2O)
+    AuthorWithEvenLongerName, BookWeak, Note, BookWithO2O, BookWithoutFK)

 class SchemaTests(TransactionTestCase):
@@ -29,7 +29,7 @@ class SchemaTests(TransactionTestCase):
         Author, AuthorWithM2M, Book, BookWithLongName, BookWithSlug,
         BookWithM2M, Tag, TagIndexed, TagM2MTest, TagUniqueRename, UniqueTest,
         Thing, TagThrough, BookWithM2MThrough, AuthorWithEvenLongerName,
-        BookWeak, BookWithO2O,
+        BookWeak, BookWithO2O, BookWithoutFK,
     ]

     # Utility functions
@@ -537,6 +537,38 @@ class SchemaTests(TransactionTestCase):
             self.fail("No FK constraint for author_id found")

     @unittest.skipUnless(connection.features.supports_foreign_keys, "No FK support")
+    def test_alter_to_fk(self):
+        """
+        #24447 - Tests adding a FK constraint for an existing column
+        """
+        # Create the tables
+        with connection.schema_editor() as editor:
+            editor.create_model(Author)
+            editor.create_model(BookWithoutFK)
+        # Ensure no FK constraint exists
+        constraints = self.get_constraints(BookWithoutFK._meta.db_table)
+        for name, details in constraints.items():
+            if details['foreign_key']:
+                self.fail('Found an unexpected FK constraint to %s' % details['columns'])
+        new_field = ForeignKey(Author)
+        new_field.set_attributes_from_name("author")
+        with connection.schema_editor() as editor:
+            editor.alter_field(
+                BookWithoutFK,
+                BookWithoutFK._meta.get_field_by_name("author")[0],
+                new_field,
+                strict=True,
+            )
+        constraints = self.get_constraints(BookWithoutFK._meta.db_table)
+        # Ensure FK constraint exists
+        for name, details in constraints.items():
+            if details['foreign_key'] and details['columns'] == ["author_id"]:
+                self.assertEqual(details['foreign_key'], ('schema_author', 'id'))
+                break
+        else:
+            self.fail("No FK constraint for author_id found")
+
+    @unittest.skipUnless(connection.features.supports_foreign_keys, "No FK support")
     def test_alter_o2o_to_fk(self):
         """
         #24163 - Tests altering of OneToOneField to ForeignKey

@MarkusH thanks for the test. I'll cleanup this PR and make the PRs for 1.8 and 1.7, ok?

It's fine if you just update this PR against master. We can take care of the backport to 1.8 and 1.7.
If you want you could add another one against 1.7, but I'd wait with that until the one against master is ready-for-commit.

@MarkusH I think it is ready now. I tested this with mysql again. Thanks for the help.

buildbot, test this please.

When you amend the remaining change, can you update the commit message and use two dashes between the ticket number and the message.

@MarkusH I amended that.

@MarkusH amended the dashes too. Sorry I missed that.

Fixed in f4f0060feaee6bbd76a0d575487682bc541111e4. Thanks!


[GOBBLIN-1793] Add metrics to measure and isolate bottleneck for init…

…ializing scheduler
Dear Gobblin maintainers,
Please accept this PR. I understand that it will not be reviewed until I have checked off all the steps below!
JIRA

[X] My PR addresses the following Gobblin JIRA issues and references them in the PR title. For example, "[GOBBLIN-XXX] My Gobblin PR"

https://issues.apache.org/jira/browse/GOBBLIN-1793

Description

[X] Here are some details about my PR, including screenshots (if applicable):
Add metrics to benchmark runtime of every piece of work involved to initialize the scheduler from the catalog to identify the bottleneck. We suspect the main time is taken to obtain specs from the mysqlstore, compile them, or schedule them but measure each part in case we are mistaken to identify a plan for improving the scheduler downtime during initialization.

Tests

[X] My PR adds the following unit tests OR does not need testing for this extremely good reason:
N/A only metrics added

Commits

[X] My commits all reference JIRA issues in their subject lines, and I have squashed multiple commits if they address the same issue. In addition, my commits follow the guidelines from "How to write a good git commit message":

Subject is separated from body by a blank line
Subject is limited to 50 characters
Subject does not end with a period
Subject uses the imperative mood ("add", not "adding")
Body wraps at 72 characters
Body explains "what" and "why", not "how"

Codecov Report

Merging #3652 (2402277) into master (c84767b) will decrease coverage by 2.26%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##             master    #3652      +/-   ##
============================================
- Coverage     46.93%   44.67%   -2.26%
+ Complexity    10758     2081    -8677
============================================
  Files          2134      409    -1725
  Lines         83791    17647   -66144
  Branches       9319     2152    -7167
============================================
- Hits          39325     7884   -31441
+ Misses        40897     8909   -31988
+ Partials       3569      854    -2715

Impacted Files
Coverage Δ

.../gobblin/cluster/GobblinHelixTaskStateTracker.java
62.50% <0.00%> (-6.25%)
:arrow_down:

...apache/gobblin/runtime/metrics/RuntimeMetrics.java

.../modules/scheduler/GobblinServiceJobScheduler.java

...che/gobblin/http/HttpClientConfiguratorLoader.java

.../compaction/mapreduce/MRCompactionTaskFactory.java

...java/org/apache/gobblin/runtime/ForkException.java

.../apache/gobblin/records/ControlMessageHandler.java

...xtractor/extract/google/GoogleDriveFileSystem.java

...modules/template/HOCONInputStreamFlowTemplate.java

...scheduler/DefaultJobSpecSchedulerListenerImpl.java

... and 1716 more

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more


A fork of pngjs that's getting a bit of love

@oliver-moran
Have a look at:
https://github.com/leogiese/node-png
It's a fork of pngjs that is being updated...
In any case, you've done some excellent work here. Thank you.

Thanks, Theo. I'll take a look.

Done. Will be in the next release.


Remove tag screen after amount input for receives

This screen adds friction for not much gains. I think we should ask the user to tag it afterwards instead. Removes an entire page from the receive flow, which is going to be the very first things the user does.

Would you do the same for Send? Or you would allow to tag before and after sending?

I disagree with this. If you have to go back to tag a transaction, no user will do it.
Tagging really brings out some of the social features we're doing and this would limit that

If you have to go back to tag a transaction, no user will do it.

They arent doing it anyways, and there is always hesitations for the first user coming to this screen and pausing for a few seconds and then proceeding anyways. If they don't want to tag it, they don't want to tag it. Let's move on from it.

Would you do the same for Send?

I think sending makes sense to still have it in some way, since they might have a contact they are sending to. In the receive side, it's mostly just "how much do you want to receive" being the main action and then anyone can pay. We could do things like payment requests from others but until then, I think the additional page adds friction.

This is done now


Removing /var/tmp workdir from rpm packaging

Addressing #2803
tmt is creating the workdir by itself and as such does not need to have the directory being packaged as part of the rpm.
This change is in sync with Fedora Python packaging guidelines, harmonizing the rpm package with the PyPI package.
It also fixes the issue of the current implementation not using tmpfiles.d and as such is marked as forbidden by rpmlint Fedora configs.

Just to clarify: So, do we drop the original use case described in #537?

For transparency: As discussed on chat, it is being handled here https://github.com/teemtee/tmt/blob/6f8283930c0da5160d590d970b66d6abee029546/tmt/utils.py#L2064


[Snyk] Security upgrade gatsby from 3.3.0 to 3.13.0

Snyk has created this PR to fix one or more vulnerable packages in the `yarn` dependencies of this project.
Changes included in this PR

Changes to the following files to upgrade the vulnerable dependencies to a fixed version:

starter/package.json
starter/yarn.lock

Note for zero-installs users
If you are using the Yarn feature zero-installs that was introduced in Yarn V2, note that this PR does not update the .yarn/cache/ directory meaning this code cannot be pulled and immediately developed on as one would expect for a zero-install project - you will need to run yarn to update the contents of the ./yarn/cache directory.
If you are not using zero-install you can ignore this as your flow should likely be unchanged.
Vulnerabilities that will be fixed
With an upgrade:

Severity
Priority Score (*)
Issue
Breaking Change
Exploit Maturity

828/1000  Why? Proof of Concept exploit, Recently disclosed, Has a fix available, CVSS 8.7
Denial of Service (DoS) SNYK-JS-HTTPPROXYMIDDLEWARE-8229906
No
Proof of Concept

(*) Note that the real score may have changed since the PR was raised.
Check the changes in this PR to ensure they won't cause issues with your project.

Note: You are seeing this because you or someone else with access to this repository has authorized Snyk to open fix PRs.
For more information:
🧐 View latest project report
🛠 Adjust project settings
📚 Read more about Snyk's upgrade and patch logic

Learn how to fix vulnerabilities with free interactive lessons:
🦉 Denial of Service (DoS)

👷 Deploy Preview for taupe-cassata-172709 processing.

Name
Link

🔨 Latest commit
b955d0a8d7c8c6e39966afc434c761605efec178

🔍 Latest deploy log
https://app.netlify.com/sites/taupe-cassata-172709/deploys/671886d55bb07600082cba88


None of your dependencies match this group anymore, you may need to update your configuration file to remove it or change its rules.

          None of your dependencies match this group anymore, you may need to update your configuration file to remove it or change its rules.

Originally posted by @dependabot[bot] in https://github.com/chatala1/astrofy/issues/4#issuecomment-2564152731

dependency chains updated


support zend-stratigility 3?

originally i submitted issue at ZendSkeletonApplication repo https://github.com/zendframework/ZendSkeletonApplication/issues/433 , which seems should be here
When I tried to use middleware in zend-mvc 3, it require to install zend-stratigility as it seems it no longer required, so I add the zend-stratigility to require with command:
composer require zendframework/zend-stratigility

and it installed the zend-stratigility 3. After it installed, I got the following error:
( ! ) Fatal error: Uncaught Error: Call to undefined method Zend\Stratigility\MiddlewarePipe::setResponsePrototype() in /Users/samsonasik/www/zf-mvc3/vendor/zendframework/zend-mvc/src/MiddlewareListener.php on line 134
( ! ) Error: Call to undefined method Zend\Stratigility\MiddlewarePipe::setResponsePrototype() in /Users/samsonasik/www/zf-mvc3/vendor/zendframework/zend-mvc/src/MiddlewareListener.php on line 134

So, I downgraded the version to v2 with command:
composer require zendframework/zend-stratigility:^2.0

And it works.
How about support zend-stratigility v3 as well?

Related to #259

Should be resolved as part of #308

This repository has been closed and moved to laminas/laminas-mvc; a new issue has been opened at https://github.com/laminas/laminas-mvc/issues/13.


Introduce EndpointResponse and EndpointResponse<TSuccessContent,TErrorContent>

The changes here introduces versions of IEndpointResponse that expose a strongly typed SuccessContent and ErrorContent. Overloads with generic type parameters in IMessageResponseBuilder were implemented for convenience to support the new typed IEndpointResponse implementation.
Here's an example usage of EndpointResponse<TSuccessContent>
public async Task<EndpointResponse<Foo>> GetFooAsync(
    string fooId,
    CancellationToken cancellationToken)
{
    var requestMessage = messageFactory
        .FromTemplate("/v1/foos/{fooId}")
        .WithPathParameter("fooId", fooId)
        .Build(HttpMethod.Get);

    var response = await httpClient.SendAsync(requestMessage, cancellationToken);
    return await messageFactory
        .FromResponse(response)
        .AddSuccessResponse<Foo>(HttpStatusCode.OK)
        .AddErrorResponse(HttpStatusCode.NotFound)
        .BuildResponseAsync<Foo>(cancellationToken);
}

and here's an example usage of EndpointResponse<TSuccessContent, TErrorContent>
public async Task<EndpointResponse<FooResponse, BadRequestDetails>> UpsertFooAsync(
    FooRequest request,
    CancellationToken cancellationToken)
{
    var requestMessage = requestFactory
        .FromTemplate("/v1/foos")
        .WithBody(request)
        .Build(HttpMethod.Put);

    var response = await httpClient.SendAsync(requestMessage, cancellationToken);
    return await requestFactory
        .FromResponse(response)
        .AddSuccessResponse<FooResponse>(HttpStatusCode.OK)
        .AddSuccessResponse<FooResponse>(HttpStatusCode.Created)
        .AddErrorResponse<BadRequestDetails>(HttpStatusCode.BadRequest)
        .BuildResponseAsync<FooResponse, BadRequestDetails>(cancellationToken);
}

I made it as unobtrusive as possible and no existing behavior is changed. I'd like to get this in as I have use case that's waiting for this


Add date filter

Ref: #748

@yaacov
one more thing to consider here: in this PR the test timestamps (Migration started) are displayed directly which preserves the original server time zone.  The date chosen in the filter is  assumed to be the same TZ and compared using plain string comparison. This might not be true for timestamps coming from providers (remote clusters). A more robust solution would be to parse both dates and use date-time library for comparison.  What is our scope here?

looks good :+1:
i have some concerns about using local timezone, added some notes about how i will solve this issue, feel free to use what ever you think will solve this issue best

As agreed upon during our issue design discussions, let's prioritize using JavaScript's native Date object over Luxon for this implementation.

The agreement was to use tool suitable for the task. Luxon is quite suitable:)

This approach will align with our previous decisions and ensure consistency across our codebase.

We already use luxon across the UI so this implementation is consistent with the rest of the code.
If you prefer to re-implement parts of the time library then please create a separate PR for this. Please add also justification why Luxon is not fulfilling our requirements.

The agreement was to use tool suitable for the task. Luxon is quite suitable:)

I understand your perspective on Luxon, and while I acknowledge its usefulness, our initial agreement prioritized using the internal Date object unless its implementation required excessive coding. I'd appreciate it if we could stick to that plan. Thank you for your understanding.

@yaacov
in the newest version the time calculations have been extracted to utility functions and unit tested. This should allow us to migrate to other solutions if needed.  Additionally a small bug with converting calendar date in the matcher has been fixed - this problem might happen again so to increase visibility it's a separate commit.


Model related to NeuroGraphDynamic dataset

Hello :) I have read the published paper carefully and noticed architecture for learning dynamic graph representations. I was wondering if would be possible to  access information on how the model is used when having as input NuroGraphDynamic dataset.
Thanks!

Hi,
Thanks for taking a look at the work.
Please see the documentation here: https://neurograph.readthedocs.io/en/latest/datasets.html
The dynamic graphs related to one subject are in one pyg batch and can be easily broadcasted to any pipeline. We have not yet publicly released the implementation for the dynamic pipeline, as the work is quite preliminary. However, I will upload it soon.


fix(perf): lack of / on end of URL was leading to redirects in metada…

I've been told that one of the potential performance issues with metadata lookup is a redirect that's being brought about by a missing / on the end of metadata URL requests.
see: https://github.com/googleapis/google-auth-library-nodejs/issues/798

our system tests for cloud functions indicate that a suffix should not be placed on the end of a URL.


Neat! I'll try this with the HTTP type.

Just found out again that we are not using highlight.js any more in docs, but apply HUGO's bundled implementation of Chroma on build.
While it's somehow possible to do HTTP highlighting with Chroma, I can't find an example right now. And since the REST API is deprecated anyway, I don't want to invest more time.