Add refinements support

Rename #using to #with_settings

Дякую!
I'll postpone merging the PR for a day, because we need adding deprecation in v0.9.3 first.

In fact, we have another option for the case. Namely, we could just reload root using like this:
def using(**options)
  return super unless block_given? # reduce to refinement
  # ... do our staff here
end

The reason why I'm hesitating with this, is that I dislike the very idea of polluting namespace with new methods. In case of using we in a sense "protected" from user to add its own using.

I think it can make the ambiguity in the code. For example:
class Foo
  extend Dry::Initializer::Mixin

  using MyRefinement

  using default: proc { nil } do
    param :foo
    param :bar
  end
end

Applying using in a different contexts is confusing.

@solnic @AMHOL @jeremyf @flash-gordon  what d'you think about the subject?

I actually don't like with_settings-like API at all. I'm perfectly OK with repeating a couple options few times, my potential use-case for dry-initializer is probably different than yours ie. I want to replace rom-rb's Option API with it and I'm not concerned with some duplication of options.
FWIW in some cases you can define a type that can carry common behavior, ie DefaultProc = Types::Definition.new(Proc).constrained(type: Proc).default(-> v { v }) and then just re-use it in many places.

Oh and regarding refinements, I don't like them, they are only a bit better than global monkey-patches, but since using is a reserved word then libs shouldn't use it as their own method.

@solnic thank you! Yes, I know about this possibilty. The reason to use default in dry-initializer instead of dry-types' .default is that you can refer to other arguments like
param :foo
param :bar, default: proc { foo.to_s.reverse }

And yes, I agree to you about refinements (I even totally forgot about reversed using when building that interface). Well, if not using, we still should think of better method name (maybe attributes?)
Concernint duplication, I'd say this is not only about duplication, but making code more readable. For example, in big structure it makes sense for me to separate optional part of the structure from mandatory one, or separate part without readers etc.

In my opinion, both using and with_settings are bad words for naming this thing. "Using" what? With what "settings"? It's not clear how the words "using" or "settings" are related to the problem of defining a constructor. User's classes contain not only our initializer included but maybe something else that could be "used" or something that has "settings". I don't want to conflict with someone other's terminology. Even adding of param and option methods is bad but I think of it as an 'ultimate trade off' and don't want to add any new methods.
I propose to remove this using at all. I'm strictly against of such a bloat in this gem, please just stop adding new features. It's not a place for "rich" DSL, it's not a "value object" or something. dry-initializer is aimed to do just one simple thing: define a typical ruby constructor (aka initialize method). "Typical" means something that assigns constructor arguments to instance variables. That's all! If someone wants to build a "value object" on top of it - you're welcome! Just make a base class, include Dry::Initializer to it and override param method to implicitely include default: proc { nil } everywhere. You can even rename it to attribute or whatever you want.
I don't think that every "good open source project" should evolve by constantly adding new features. In case of dry-initializer it's not an evolution, it's just a bloat. True evolution of dry-initializer would be an inclusion of it to other open source projects as a part of them.

Pro-tip® for power users:
https://github.com/rails/rails/blob/92703a9ea5d8b96f30e0b706b801c9185ef14f0e/activesupport/lib/active_support/core_ext/object/with_options.rb
:)
Maybe it would be good idea to re-implement this thing as a mixin, not as a monkey patch.

I'm inclined to agree with @marshall-lee here. If duplication becomes a big concern for users of dry-initializer, and if they have ways of their own to import some code to reduce that duplication, then I think it would be best to keep the core dry-initializer API slim.

@marshall-lee @timriley yes, thank you. You've convinced me to remove this method (thats why I like discussions so much).
It adds some syntax sugar, but for a high price of polluting namespace, which is unbearable for the gem pretending to be mixed in any klass.
Will remove the method in v0.10.0

Maybe it'd be a candidate for inclusion in dry-core? I'll have something more to say once I start working on using dry-initializer in rom-rb :)

@solnic nice to hear it ;)
Would be great if you could make an issue(s) as a result of your working with the gem in rom

Removed in v0.10.0


On screen/console/stderr output.

The program, in its current form, provides no real-time display of simulation progress to the console.  Having the ability to toggle the feature on/off from the is required for unattended/batch processing.
-Tom

Hi Tom,
How hard is it to add a toggle for the 4.2 release? If the toggle is difficult, I recommend the first default behavior reports progress to the console. Later, the toggle can be added in 4.3 to disable default behavior.
Reasoning: I think the program should as easy to use for novice users. Having a status output helps novices know the program started. Otherwise, they are staring at a blank screen thinking, "did I do something wrong?"
Advanced users who do lots of batch processing are more accepting of adding toggles to change the default behavior.
Justin

It is not difficult to add the toggle, just takes some time.
-Tom
On Mon, Apr 19, 2021 at 8:15 AM Justin M Edenbaum @.***>
wrote:

Hi Tom,
How hard is it to add a toggle for the 4.2 release? If the toggle is
difficult, I recommend the first default behavior reports progress to the
console. Later, the toggle can be added in 4.3 to disable default behavior.
Reasoning: I think the program should as easy to use for novice users.
Having a status output helps novices know the program started. Otherwise,
they are staring at a blank screen thinking, "did I do something wrong?"
Advanced users who do lots of batch processing are more accepting of
adding toggles to change the default behavior.
Justin
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/Open-SES/OpenSES/issues/5#issuecomment-822419966, or
unsubscribe
https://github.com/notifications/unsubscribe-auth/ATC4WHTZB5G6XC7OY62PMYDTJQNEJANCNFSM43DNP6IQ
.

What do you want for the default behavior of 4.2?

Keep as-is with not status
Spend time and add status to the output screen (similar to SES 6.0). A toggle will be added to 4.3
Add toggle to 4.2.

To move things along, I did not add toggle for screen output.
-Tom


Updates

Hi,
I needed a path tool that would allow me to resize the path as well as move the origin. I used this project as a starting point.
Then, of course, I did my OCD and kept going. I parse the commands into a listbox. You can add, remove, edit, reorder, etc. and it updates the data text and redraws.
I could just fork your repo, and publish it myself, or I could just do a PR into your repo. Would you be interested in seeing what I've done?
Thanks,
Jamie
P.S. I know I'm abusing the "Issues" functionality here, but I don't see any other way to send a message to a repo owner.

Hi, for sure I would like to see your code, I was looking forward to improve the project. Yes, you can do a PR.
For the future, we can communicate via email (ignaciosp82@gmail.com).


How to utilise proxy?

Hi - Firstly thanks, I like what you have built here!
I have my docs running on a separate domain to the api. How can I change the url here?

I have tried to replicate what is in the demo:
presets: [
    [
      'docusaurus-preset-openapi',
      /** @type {import('docusaurus-preset-openapi').Options} */
      ({
        docs: {
          routeBasePath: '/',
          sidebarPath: require.resolve('./sidebars.js'),
          // Please change this to your repo.
          // editUrl: 'https://github.com/facebook/docusaurus/tree/main/packages/create-docusaurus/templates/shared/',
        },
        blog: false,
        theme: {
          customCss: require.resolve('./src/css/custom.css'),
        },
        proxy: {
          "/api": {
            target: 'https://my-api-site',
            pathRewrite: { "^/api": "" }
          }
        }
      }),
    ],
  ],

But still 'Execute' the requests try to call http://localhost:3000/health. How can I redirect requests to https://my-api-site/health?

The code you have here should redirect requests from http://localhost:3000/api/health to https://my-api-site/health


match with regex doesn't set variable correctly when backtracking.

Changing the example from the from the front-page slightly to match "f(o*)obar"
match "foobar" with
| 'f(?<os>o*)obar' -> os
| _               -> "???"

will evaluate to "oo", not "o".  Similarly, if we use 'f(?.*)bar', then os = "oobar".

Good catch, I will take a look.

Sorry adam, lots going on, I'm no longer part of the project or Morgan Stanley, can't submit a change anymore.  I might be able to get a fix into my fork but have some other issues to take care of first.


Review 'as-is' Diagram of the Current Live Certificate Renewal Process

User Need
As a Stakeholder
I want A representative diagram of the live certificate renewal process
so that We can easily identify the areas that need attention
Value
Represent the current process so we can easily and critically analyse pain points.
Functional Requirements:

We have a completed as-is diagram of the current process.

Non-Functional Requirements:

Correctly scoped diagram to highlight the problem.

Acceptance Criteria:

The Operations Engineering team have a better understanding of the infrastructure as-is.

Notes:

Here's the old diagram. The new 'as-is' diagram can be created on the V2 page.

Removing for now - certificates may be moving out of Ops Eng.


x86: SHR incorrectly zeroing the OF flag

Describe the bug
https://github.com/rfalke/decompiler-subjects/blob/master/from_holdec/stress_int_ia32/ia32_elf_extensions_inst__1_var__no_complex/subject.exe
is a binary that contains various decompiler tests. As of 8a5fbdf , inst_152_flags_var_0 and inst_157_flags_var_0 yield invalid results in the decompiler and with the ghidra emulator. They both appear to be due to an error in the Pcode of the SHR r, 1 instruction, which on a 1-bit shift, should set the OF flag to the MSB of the operand.
Page 1814
https://software.intel.com/en-us/download/intel-64-and-ia-32-architectures-sdm-combined-volumes-1-2a-2b-2c-2d-3a-3b-3c-3d-and-4

(pinging @rfalke in case this has already been reported before)
We can see that the SHR instruction zeroes out the OF, inaccurately.

This results in the mov in CMOVO marked as unreachable and an inaccurate decompilation result:

The emulator too returns a value of -2:

The bytes of inst_152_flags_var_0 are:
53 55 56 57 0f a8 b8 45 21 e0 f9 bb 4b 66 aa 03 b9 58 2e 33 b9 ba c3 69 c4 f6 bd 6c 27 d5 7a be 8f bf bd b0 bf 69 94 af 15 f7 d8 66 d1 ef bd 00 00 00 00 b8 01 00 00 00 0f 42 e8 bf 00 00 00 00 b8 02 00 00 00 0f 40 f8 be 00 00 00 00 ba 00 00 00 00 b9 00 00 00 00 31 c0 01 e8 01 f8 01 f0 01 d0 01 c8 83 e8 03 0f a9 5f 5e 5d 5b c3

Which disassembles to
push   ebx
push   ebp
push   esi
push   edi
push   gs
mov    eax,0xf9e02145
mov    ebx,0x3aa664b
mov    ecx,0xb9332e58
mov    edx,0xf6c469c3
mov    ebp,0x7ad5276c
mov    esi,0xb0bdbf8f
mov    edi,0x15af9469
neg    eax
shr    di,1                                     ; sets OF flag = 1 (DI = 0x9469)
mov    ebp,0x0
mov    eax,0x1
cmovb  ebp,eax
mov    edi,0x0
mov    eax,0x2
cmovo  edi,eax                          ; copies EAX to EDI if OF = 1
mov    esi,0x0
mov    edx,0x0
mov    ecx,0x0
xor    eax,eax
add    eax,ebp
add    eax,edi
add    eax,esi
add    eax,edx
add    eax,ecx
sub    eax,0x3
pop    GS
pop    EDI
pop    ESI
pop    EBP
pop    EBX
ret

Environment (please complete the following information):
8a5fbdf

Both SHR and SAR appear to be affected. SHL is not affected however.


Can I add thirty part plugins? If so how?

I would like to add a new plugin to the bundle but I have no a clue in how to do it. The plugin is this one.
Is this possible? If so, how? Any docs to read?

http://symfony.com/doc/master/bundles/IvoryCKEditorBundle/usage/plugin.html should guide you :)

@egeloen I have followed the instructions there and this is how my config looks like:
ivory_ck_editor:
    input_sync: true
    configs:
        oneview:
            language: '%locale%'
            toolbar: full
            extraPlugins: "templates, imageuploader"
            templates:    "oneview_templates"
    templates:
        oneview_templates:
            imagesPath: "/bundles/common/images/"
            templates:
                -
                    title:       "Email Template"
                    image:       "email.png"
                    description: "Default Template for Quote Emails"
                    template<EMAIL_ADDRESS>                -
                    title:       "Price Change Template"
                    image:       "email.png"
                    description: "Default Template for Price Change"
                    template<EMAIL_ADDRESS>    plugins:
        imageuploader:
            path:     '/bundles/common/js/imageuploader/'
            filename: 'plugin.js'

However I am getting the following error at Chrome Console:
ckeditor.js:249 Uncaught Error: [CKEDITOR.resourceManager.load] Resource name " imageuploader" was not found at "http://localhost/bundles/ivoryckeditor/plugins/ imageuploader/plugin.js?t=H0CG".
    at CKEDITOR.resourceManager.<anonymous> (ckeditor.js:249)
    at f (ckeditor.js:244)
    at Array.B (ckeditor.js:244)
    at u (ckeditor.js:244)
    at HTMLScriptElement.CKEDITOR.env.ie.f.$.onerror (ckeditor.js:245)

If I am defining the path where the plugin is why CKEditor still looking at the default path?

Try removing the space before your plugin name:
Before:
extraPlugins: "templates, imageuploader"

After:
extraPlugins: "templates,imageuploader"

@reypm Does it solve your issue?

@egeloen yes sir, closing this now. Great help!!

@egeloen how do I add extra configuration to the plugin after has been enabled? for example like this ??

Something like:
ivory_ck_editor:
    configs:
        default:
            strinsert_strings:
                -
                    name: First name
                    value: '*|FIRSTNAME|*'
                -
                    name: Last name
                    value: '*|LASTNAME|*'
                // ...


Unhandled error during execution of scheduler flush when rendering components in a transition group that have a v-if directive

Version
3.2.26
Reproduction link
sfc.vuejs.org/
Steps to reproduce
I am using a transition group as follows:
<transition-group name="foo" tag="div" appear>
...
</transition-group>

Within it, I have a list of custom components. If I apply a v-if on these components within the parent template, everything works as expected:
<transition-group name="foo" tag="div" appear>
  <other-component v-for="item in items"  :key="item.id" />
  <foo-component key="foo" :foos="foos" v-if="foos.length > 0" />
  <bar-component key="bar" :bars="bars" v-if="bars.length > 0" />
</transition-group>

Both foos and bars are loaded asynchronously, and the components appear correctly with a transition animation as soon as the items are loaded and available.
However, I tried to refactor this to letting the components load the items themselves, and if I move the v-if into the child component (still on the outer most HTML element), as follows:
<transition-group name="foo" tag="div" appear>
  <other-component v-for="item in items"  :key="item.id" />
  <!-- now these components load their items themselves, and govern their own appearance with an internal `v-if` -->
  <foo-component />
  <bar-component />
</transition-group>

This however triggers a series of errors in the console:
Unhandled error during execution of render function
Unhandled error during execution of scheduler flush. This is likely a Vue internals bug. Please open an issue at https://new-issue.vuejs.org/?repo=vuejs/vue-next
TypeError: child.el.getBoundingClientRect is not a function

What is expected?
That if using a v-if inside of a child component which is listed in a transition-group, this works as expected.
What is actually happening?
The error as above is thrown and v-for some of the components in the transition group fail to render.

Trying to render components in a transition group and govern their appearance internally in the component instead of externally in the parent component.
To reproduce in the playground, remove the v-if condition on the Bar.vue component to make the example work, then put it back to trigger the error.

The interesting thing is that this error only seems to occur if you have both the v-for rendered list of items, and the component with v-if together in the same transition group.
If you take either of them out, everything works as expected.

Further testing reveals that using v-show instead of v-if in the child components does not result in the same problem, so this is an acceptable workaround for now.

@LinusBorg I don't think this is a bug: <transition-group> should have a child with v-for only, shouldn't it? Based on that, using transition + transition-group works fine

I don't think v-for is the problem. The problem is that when a transition-group updates (here: the v-for items where changed), one of the child elements is a component still that has a comment as a placeholder element because of a v-if inside it.
While TransitionGroup skips comment nodes from direct children (i.e. the div with the v-if in the transition-group, it fails to properly do so for a child component that itself renders a comment.
Now, we can talk about wether a component in a transition group must always have a root element, but I feel like there may be an actual fix.

Right, but that bar component shouldn’t go in the transition group, it should go in a transition and then it works

Actually it won't, because if I create a nested transition for the bar
element or others, then it will break the move transition effect that I
have and am using for the group.
Instead, the bar item will transition itself fine, but the rest of the
items in the group will just be moved into their new place in an abrupt way
without animation.
This is the reason why both the v-for elements and the components with v-if
are in the same group. So that once they have loaded their items, all other
items in the group make space for the new item elegantly and slide aside.
This is maybe not reflected properly in the fiddle, as I was aiming to
reproduce the bug there, not to demonstrate the full use case.
If it's possible to use v-if on the component directly in a transition
group, you'd expect it to be allowed to use a v-if on the root element of
the component itself too though. It seems to make sense (as long as there
is just one root element).
Thanks for looking into this
On Mon, Dec 27, 2021, 01:17 Eduardo San Martin Morote <
@.***> wrote:

Right, but that bar component shouldn’t go in the transition group, it
should go in a transition and then it works
—
Reply to this email directly, view it on GitHub
https://github.com/vuejs/vue-next/issues/5168#issuecomment-1001168747,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AADXYQVVNTIS3EXTA3EVNQ3US4BTXANCNFSM5KXERRCA
.
Triage notifications on the go with GitHub Mobile for iOS
https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675
or Android
https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.
You are receiving this because you authored the thread.Message ID:
@.***>

I am having the same issue when working with Q-Table (Quasar). Because of this the table updates only first time and subsequent changes wont reflect throwing this issue


[SPARK-38575][INFRA][FOLLOW-UP] Fix ** to '**' in ansi_sql_mode_test.yml

What changes were proposed in this pull request?
This PR fixes a mistake:

Why are the changes needed?
To enable ANSI build back in the commits at the dev branches.
Does this PR introduce any user-facing change?
No, dev-only.
How was this patch tested?
Will be checkeed after getting merged.

will merge this to unblock the build and dev.

+1, LGTM.


IJPOpen and Disqus Comments not available

IJPOpen is not available in PEP-Easy, even in the production version of PEP-Web we've been using.

The 2021 Server though does not yet support IJPOpen style publications.  This will be implemented in conjunction with the new PEP-Web client design, as it is both a server and client implemented feature.

IJPOpen is now implemented with Disqus in the client.  IJPOpen papers now go through the normal keyboarding process and are displayed via the XML.


needed for build tools master-2021-02-19T21-48-54; Update helm linting issue; requires k8s 1.16

See discussion at https://github.com/istio/tools/pull/1450. This is done to prepare master for the new build tools image.
As discussed previously in T&R, we no longer need to support k8s 1.15. Helm linting in 3.5.2 marks mutating webhook and validating webhook configuration as a warning due to v1beta1 usage. Update to v1, as it is supported in k8s 1.16+
Update the dockerfile for centos to ignore hadolint errors. These are similar to the ones already ignored for debian packages.
[ ] Configuration Infrastructure
[ ] Docs
[ ] Installation
[ ] Networking
[ ] Performance and Scalability
[ ] Policies and Telemetry
[ ] Security
[X] Test and Release
[ ] User Experience
[ ] Developer Infrastructure
Pull Request Attributes
Please check any characteristics that apply to this pull request.
[X] Does not have any changes that may affect Istio users.

@jacob-delgado: The following test failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

gencheck_istio
5dce85f5152ee228c5bf6e82461bc39c4df71e40
link
/test gencheck_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@jacob-delgado: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

gencheck_istio
5dce85f5152ee228c5bf6e82461bc39c4df71e40
link
/test gencheck_istio

integ-helm-tests_istio
5dce85f5152ee228c5bf6e82461bc39c4df71e40
link
/test integ-helm-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

Does it not complain about the deprecated CRD? since that fix is much more involved

@jacob-delgado: The following test failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

integ-helm-tests_istio
060ee3683a4f3ed3dcc5349e2d81c528834fbe54
link
/test integ-helm-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@jacob-delgado: The following test failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

integ-helm-tests_istio
73f9dc64ae67447bfda3338fe4c8e742ffda9193
link
/test integ-helm-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

I see a lot more usages of admissionregistration.k8s.io/v1beta1 than just these 3 files. Maybe need to run make gen

There's a tar.gz file that contains the manifest. Figured it out.

Does it not complain about the deprecated CRD? since that fix is much more involved

Given that I'm going to close this and use the version of helm we have as a dependency. When I also tried to update the helm library to 3.5.2 I was getting go mod issues. We can do that at a different tie.
Closing in lieu of https://github.com/istio/tools/pull/1451
I'll open another PR with just the hadolint fixes


Hitting Matt crashes the game

Hitting Matt in the safehouse crashes the game. This is literally caused by an attempted anti-crash measure.
For now, please restrain yourselves until this is fixed.

This also happens when hitting Santa in the Stealing Xmas heist.
And since hitting him is mandatory to progress, it cannot be completed.

I just put in automated unit testing so this sort of stuff won't easily happen again. Worst case, I push something that's broken and Github will simply not build a mod zip, and therefore you won't get an auto-update.


Expand episode provider payload. For more precise torrents filtering

Changes needed for this code in script.elementum.jackett.
https://github.com/vasilky3/script.elementum.jackett/blob/feature/vkuz-TV-smart-search/src/filter.py#L133

@vasilky3 Thanks for your contribution.
I will merge and then add missing checks to make it safer.


Binary build script: Switch from timestamp to hash based .pyc files

When we build Python binaries, the make install step automatically generates .pyc files for the Python stdlib, however:

It generates these using the default timestamp invalidation mode, which does not work well with the CNB file timestamp normalisation behaviour.
It generates .pycs for all three optimisation levels (standard, -O and -OO), when the vast majority of apps only use the standard mode.

As such, this changes our builds to:

Use one of the hash-based pyc invalidation modes to prevent the .pycs from always being treated as outdated and so being regenerated at application boot.
Ship only the standard optimisation level pycs (and not the .opt-{1,2}.pyc files), reducing build output by 18MB.

We use the unchecked-hash mode rather than checked-hash since it improves app startup times by ~5%, and is only an issue if manual edits are made to the stdlib, which is not something we support.
See:
https://docs.python.org/3/reference/import.html#cached-bytecode-invalidation
https://docs.python.org/3/library/compileall.html
https://peps.python.org/pep-0488/
https://peps.python.org/pep-0552/
https://github.com/python/cpython/blob/v3.10.4/Makefile.pre.in#L1603-L1629
GUS-W-10988998.
GUS-W-10989125.

The combined build output size reductions from this PR plus #1319, #1320 and #1321, are:

Python 3.10:

Uncompressed: 207 MB -> 38 MB
Compressed: 51 MB -> 13 MB

Python 3.9:

Uncompressed: 196 MB -> 52 MB
Compressed: 48 MB -> 17 MB

These size reductions reduce:

the download/extraction time of the Python archive during the buildpack build
the archiving/compression/upload time of the build directory by the build system at the end of the build (whether that be for the slug for classic builds, or the layer exporting/pushing for CNBs)
the app boot time at runtime (since smaller slug / layer to download on the runtime instance)

...plus they also reduce the chance of an app running into slug size limits when using heavier dependencies.


pooled connection fails to close after DB error when using a validation query

We recently ran into a problem where our connection pool was drained (all connections acquired, showing up in Postgres as "ROLLBACK" and "idle"). I was able to boil down the problem and it shows that all these stuck connections were caused by a data integrity exception thrown by r2dbc-postgres.
Finally, I reduced the cause to a combination of

using a validation query for the pool
having a corrupt connection after the data integrity exception ("current transaction is aborted, commands ignored until end of transaction block")

So, instead of being able to close the connection, close() will throw an exception, leaving the connection seemingly in a broken state.
The problem disappears when no validation query is used.
As far as I can analyse, this seems to be a regression since 0.8.0.M8.
Postgres: 11.4
r2dbc(-spi, -pool, -postgres): 0.8.0.BUILD-SNAPSHOT
Code to generate the issue:
    @Test
    void close_should_not_throw_exception() {
        ConnectionFactory connectionFactory = ConnectionFactories.get(ConnectionFactoryOptions.builder()
                .option(DRIVER, "postgresql")
                .option(HOST, "localhost")
                .option(USER, user)
                .option(PASSWORD, password)
                .option(DATABASE, database)
                .build());

        ConnectionPoolConfiguration configuration = ConnectionPoolConfiguration.builder(connectionFactory)
                .validationQuery("SELECT 1")
                .build();

        ConnectionPool connectionPool = new ConnectionPool(configuration);

        Connection connection = Mono.from(connectionPool.create()).block();

        Flux.from(connection.beginTransaction()).blockLast();
        execute(connection, "drop table if exists foo");
        execute(connection, "create table foo (id integer primary key)");
        execute(connection, "insert into foo (id) values (1)");

        assertThrows(PostgresqlServerErrorException.class, () -> {
            execute(connection, "insert into foo (id) values (1)");
        });

        Flux.from(connection.rollbackTransaction()).blockLast();

        assertDoesNotThrow(() -> {
            Flux.from(connection.close()).blockLast(); // This throws an unexpected exception
        });
    }

    static void execute(Connection connection, String sql) {
        Flux.from(connection.createStatement(sql).execute()).flatMap(Result::getRowsUpdated).blockLast();
    }

The cause of this issue is PostgresqlConnection::rollbackTransaction() skipping the actual rollback if the transaction status is not OPEN (in this case it is FAILED). Changing the code to do a rollback in case of IDLE != transactionStatus will fix the issue.
The same issue applies to PostgresqlConnection::rollbackTransactionToSavepoint().


Mulitple grid drag and drop

Hi All,
I have a carousel of widgets that needs to be dragged from the carousel container and dropped on the grid layout. It seems that there isn't the possibility two have two grids interacting with each other?
Did anyone have a similar requirement and found a way to go about it?
Thanks in Advance,
Matt

Had anyone have any example?  would be great!

@MLongz can you please provide an example for this? I also have similar requirements. Thanks!

Hi,
I have the same requirements. Can anyone create an example of dragging items from one grid to another grid.
thank you.

the same， can anyone provide a demo?

Hi team, need same requirement
Thank you.

Looking for a solution for this too..
@gmsa any chance you would have any suggestions for this?
Or perhaps if there could be the event object being emitted as well on the @move and @moved event?

No suggestions right now, sorry

here is a sample demo for the requirements, but i cant resolved  Bounds checking on cross item http://kkkisme.github.io/multi-container-draggable/dist/index.html

https://github.com/kkkisme/multi-container-draggable/blob/master/src/App.vue for the source

On how to do what exactly?

That'd be great if we could achieve this multiple grid interaction with vue-grid-layout.
Gridstack does it but it requires jQuery.

here is a sample demo for the requirements, but i cant resolved Bounds checking on cross item http://kkkisme.github.io/multi-container-draggable/dist/index.html

Thanks for the your contribution, your solution worked incredibly well!


Fixed comment of float humidity

Overview
The comment for humidity of type float was written as x1000 even though the value was not multiplied by 1000, so the comment has been corrected to prevent confusion.
Basis

As shown in the example code below, the value of humidity is not divided by 1000 when FPU is not used.
https://github.com/boschsensortec/BME68x-Sensor-API/blob/80ea120a8b8ac987d7d79eb68a9ed796736be845/examples/forced_mode/forced_mode.c#L82-L100
Because in the uint32_t calc_humidity method, calc_hum is capped at 100000, but in the float calc_humidity method, calc_hum is capped at 100.0f.
https://github.com/boschsensortec/BME68x-Sensor-API/blob/80ea120a8b8ac987d7d79eb68a9ed796736be845/bme68x.c#L927-L938
https://github.com/boschsensortec/BME68x-Sensor-API/blob/80ea120a8b8ac987d7d79eb68a9ed796736be845/bme68x.c#L1093-L1103

If you need to create an Issue, please contact us.
I will create an Issue with the contents of this issue.

Hi @BST-Github-Admin, @kegov.
Could you please check the PR?

@Deepak-Mvk , fyi.


Can't build using dep

Bug Report

What did you do?
Followed the used guide (https://github.com/operator-framework/operator-sdk/blob/master/doc/user-guide.md) using --dep-manager=dep but when I run operator-sdk build myimage:0.1 It breaks. Using go get works fine.
What did you expect to see?
To build operator image
What did you see instead? Under which circumstances?
# /path/to/vendor/contrib.go.opencensus.io/exporter/ocagent
vendor/contrib.go.opencensus.io/exporter/ocagent/ocagent.go:297:35: cannot convert true (type untyped bool) to type "/path/to/vendor/github.com/census-instrumentation/opencensus-proto/gen-go/trace/v1".ConstantSampler_ConstantDecision
vendor/contrib.go.opencensus.io/exporter/ocagent/ocagent.go:297:35: invalid operation: csamp.Decision == true (mismatched types "/path/to/vendor/github.com/census-instrumentation/opencensus-proto/gen-go/trace/v1".ConstantSampler_ConstantDecision and bool)
vendor/contrib.go.opencensus.io/exporter/ocagent/transform_stats_to_metrics.go:53:3: unknown field 'Descriptor_' in struct literal of type "/path/to/vendor/github.com/census-instrumentation/opencensus-proto/gen-go/metrics/v1".Metric
vendor/contrib.go.opencensus.io/exporter/ocagent/transform_stats_to_metrics.go:59:45: undefined: "/path/to/vendor/github.com/census-instrumentation/opencensus-proto/gen-go/metrics/v1".Metric_MetricDescriptor
vendor/contrib.go.opencensus.io/exporter/ocagent/transform_stats_to_metrics.go:67:11: undefined: "/path/to/vendor/github.com/census-instrumentation/opencensus-proto/gen-go/metrics/v1".Metric_MetricDescriptor
Error: failed to build operator binary: (failed to exec []string{"go", "build", "-o", "/$GOPATH/src//path/to/build/_output/bin/example-operator", "-gcflags", "all=-trimpath=/$GOPATH/src/github.com/linux-blog-demo", "-asmflags", "all=-trimpath=/$GOPATH/src/github.com/linux-blog-demo", "/path/to/cmd/manager"}: exit status 2)

Environment

operator-sdk version:

operator-sdk version: v0.10.0, commit: ff80b17737a6a0aade663e4827e8af3ab5a21170

go version:

go version go1.12.7 linux/amd64

Kubernetes version information:

Client Version: version.Info{Major:"1", Minor:"11", GitVersion:"v1.11.10", GitCommit:"7a578febe155a7366767abce40d8a16795a96371", GitTreeState:"clean", BuildDate:"2019-05-01T04:14:38Z", GoVersion:"go1.10.8", Compiler:"gc", Platform:"linux/amd64"}
Server Version: version.Info{Major:"1", Minor:"15", GitVersion:"v1.15.2", GitCommit:"f6278300bebbb750328ac16ee6dd3aa7d3549568", GitTreeState:"clean", BuildDate:"2019-08-05T09:15:22Z", GoVersion:"go1.12.5", Compiler:"gc", Platform:"linux/amd64"}

Kubernetes cluster kind:
Minikube

Are you writing your operator in ansible, helm, or go?
Go

@math3vz I was not able to reproduce your issue with a new project and operator-sdk v0.10.0 (with APIs and controllers). Are you using an < v0.10.0 operator project with the v0.10.0 operator-sdk binary?

@estroz I'm following the user guide (https://github.com/operator-framework/operator-sdk/blob/master/doc/user-guide.md)
Created the project with operator-sdk new memcached-operator --dep-manager=dep

Hi @math3vz,
Did you try to execute dep ensure before to do the go get?

Hi @math3vz,
Did you try to execute dep ensure before to do the go get?

Yep, same problem

HI @math3vz,

@math3vz I was not able to reproduce your issue with a new project and operator-sdk v0.10.0 (with APIs and controllers). Are you using an < v0.10.0 operator project with the v0.10.0 operator-sdk binary?

Could you provide the url for your repo? Is possible we are able to check it? Is publish public?

HI @math3vz,

@math3vz I was not able to reproduce your issue with a new project and operator-sdk v0.10.0 (with APIs and controllers). Are you using an < v0.10.0 operator project with the v0.10.0 operator-sdk binary?

Could you provide the url for your repo? Is possible we are able to check it? Is it public?

This is my code right now: https://github.com/math3vz/memcache-operator

There are two issues with your operator project, the cause of the first I'm not sure of:

Your project's import paths do not contain a repo. Import paths should be github.com/math3vz/memcached-operator/....
Your project's name is memcache-operator but import paths are memcached-operator/... (a naming mismatch will cause build errors).

Once I make these changes, I see the compilation errors you're getting. However when I follow the user guide, I do not see them. Note that you must be in your $GOPATH/src when using dep. I recommend re-installing dep v0.5.0, rm -rf $GOPATH/pkg/dep, and following the user guide again.
Also note that we plan to drop support for dep when go 1.13 releases. You definitely can still use dep for testing with operator-sdk < v0.10. Otherwise I recommend switching to Go modules.

There are two issues with your operator project, the cause of the first I'm not sure of:
1. Your project's import paths do not contain a [repo](https://github.com/math3vz/memcache-operator/blob/master/cmd/manager/main.go#L14). Import paths should be `github.com/math3vz/memcached-operator/...`.

2. Your project's name is `memcache-operator` but import paths are `memcached-operator/...` (a naming mismatch will cause build errors).

Once I make these changes, I see the compilation errors you're getting. However when I follow the user guide, I do not see them. Note that you must be in your $GOPATH/src when using dep. I recommend re-installing dep v0.5.0, rm -rf $GOPATH/pkg/dep, and following the user guide again.
Also note that we plan to drop support for dep when go 1.13 releases. You definitely can still use dep for testing with operator-sdk < v0.10. Otherwise I recommend switching to Go modules.

Maybe de problem is with my dep version, I installed it with the command:  $ curl https://raw.githubusercontent.com/golang/dep/master/install.sh | sh
Running $ dep version I get the following output:
 $ dep version
dep:
 version     : devel
 build date  :
 git hash    :
 go version  : go1.8.3
 go compiler : gc
 platform    : linux/amd64

Not sure what devel means.
I just started working with Go and I thought dep was the best option for managing dependencies, I'll stick with Go modules, feel free to close the issue, thanks.

@math3vz devel points to the latest commit of dep (v0.5.4+) which should be fine. We say to reinstall dep because some users may have an old version.
I'm still curious why the vendor directory/Gopkg.lock file generated for your project does not contain the correct dependencies in your project. It may just be an environment issue. Glad modules works for you!


Dependency updates to remediate GCP-related security issues

This PR updates the GCP library to the latest available (5.1.2) and that is recommended for use with Spring Boot 3.2.x.  It resolves the guava vulnerability present in 1.2.8 but not the protobuf or oauth dependencies.  Will submit a follow-up PR for those shortly.

This PR is a partial fix for issue #145


Fix sprite crunch at half-pixels (redux)

Seems that #84380 doesn't fix every issues about sprite crunching.
Comparison
#84380
Here's #84380's rendering of Godot-Tutorial-SmoothCamera ported to Godot 4.3.
Notice that we lose the eyes sometimes, and that there's some cropping artifacts.
https://github.com/godotengine/godot/assets/270928/2344922d-ec3b-49ad-a78e-049b59917962
This PR
Here's this PR's rendering of the same project:
https://github.com/godotengine/godot/assets/270928/b2fe6f40-fc0e-4c4f-9d96-122bfff80728
Open question
Relates to the comment by @clayjohn in https://github.com/godotengine/godot/pull/86670#issuecomment-1879187086
Do we really want to make this logic dependant of ProjectsSettings for snapping 2D?
If we do:

nearest textures will be broken when non snapped;
linear textures will not ever be "blurred" when snapped.

Relates to
Supersedes #86670.
Fixes #84632.

Nevermind, forgot to activate snapping for the viewport of my demo. With the snapping, https://github.com/godotengine/godot/pull/84380 fixes everything displayed.


CiliumClusterwideNetworkPolicy does not apply to cilium Daemonset

Is there an existing issue for this?

[X] I have searched the existing issues

What happened?
Cilium 1.11 is running on GKE with the old dataplane.
The cluster is running the following firewall rules:
---
apiVersion: cilium.io/v2
kind: CiliumNetworkPolicy
metadata:
  name: default
  namespace: kube-system
spec:
  endpointSelector: {}
  ingress:

    # allow traffic from master servers
    - fromCIDRSet:
        - cidr: <IP_ADDRESS>/28  # TODO

    # dns access
    - fromEntities:
        - cluster
        - remote-node
      toPorts:
        - ports:
            - port: "53"
              protocol: UDP

    # remote nodes to clilium
    - fromEntities:
        - remote-node
      toPorts:
        - ports:
            - port: "4240"

  egress:

    # allow traffic to master servers
    - toCIDRSet:
        - cidr: <IP_ADDRESS>/28  # TODO

    # allow dns traffic
    - toEntities:
        - world
      toPorts:
        - ports:
            - port: "53"
              protocol: UDP
---
apiVersion: cilium.io/v2
kind: CiliumClusterwideNetworkPolicy
metadata:
  name: default
spec:
  endpointSelector: {}
  ingress:

    # allow local namespace
    - fromEndpoints:
        - {}

    # allow fron loadbalancer
    - fromEndpoints:
        - matchLabels:
            io.kubernetes.pod.namespace: projectcontour

  egress:

    # allow to local namespace
    - toEndpoints:
        - {}

    # allow to any pod in cluster
    - toEntities:
        - cluster

On running hubble observe --verdict DROPPED -f i noticed that cilium related traffic is being dropped:
Feb 25 09:53:36.695: <IP_ADDRESS>:55948 <> <IP_ADDRESS>:4240 Policy denied DROPPED (TCP Flags: SYN)
Feb 25 09:53:36.695: <IP_ADDRESS>:55948 <> <IP_ADDRESS>:4240 Policy denied DROPPED (TCP Flags: SYN)
Feb 25 09:53:36.715: <IP_ADDRESS>:52928 <> <IP_ADDRESS>:4240 Policy denied DROPPED (TCP Flags: SYN)
Feb 25 09:53:36.715: <IP_ADDRESS>:52928 <> <IP_ADDRESS>:4240 Policy denied DROPPED (TCP Flags: SYN)
Feb 25 09:53:37.610: <IP_ADDRESS>:47956 <> <IP_ADDRESS>:4240 Policy denied DROPPED (TCP Flags: SYN)
Feb 25 09:53:37.610: <IP_ADDRESS>:47956 <> <IP_ADDRESS>:4240 Policy denied DROPPED (TCP Flags: SYN)

Moving the remote nodes to clilium ingress rule from the CiliumNetworkPolicy in kube-system to the CiliumClusterWideNetworkPolicy fixes this.
Did I understand something wrong? I got the impression that it's possible to combine CiliumClusterwideNetworkPolicy with normal policies.
Cilium Version
cilium-cli:  compiled with go1.16.13 on linux/amd64
cilium image (default): v1.10.5
cilium image (stable): v1.11.2
cilium image (running): v1.11.0

Kernel Version
Linux container 5.4.144+ #1 SMP Wed Nov 3 09:56:10 PDT 2021 x86_64 Linux

Kubernetes Version
Client Version: version.Info{Major:"1", Minor:"22", GitVersion:"v1.22.3", GitCommit:"c92036820499fedefec0f847e2054d824aea6cd1", GitTreeState:"archive", BuildDate:"1980-01-01T00:00:00Z", GoVersion:"go1.16.13", Compiler:"gc", Platform:"linux/amd64"}
Server Version: version.Info{Major:"1", Minor:"21", GitVersion:"v1.21.6-gke.1500", GitCommit:"7ce0f9f1939dfc1aee910732e84cba03840df91e", GitTreeState:"clean", BuildDate:"2021-11-17T09:30:26Z", GoVersion:"go1.16.9b7", Compiler:"gc", Platform:"linux/amd64"}

Sysdump
No response
Relevant log output
No response
Anything else?
No response
Code of Conduct

[X] I agree to follow this project's Code of Conduct

Just notices i had an old version of cilium, no change after update
✦ ❯ cilium version
cilium-cli:  compiled with go1.16.13 on linux/amd64
cilium image (default): v1.10.5
cilium image (stable): v1.11.2
cilium image (running): v1.11.2

✦ ❯ cilium status
    /¯¯\
 /¯¯\__/¯¯\    Cilium:         OK
 \__/¯¯\__/    Operator:       OK
 /¯¯\__/¯¯\    Hubble:         OK
 \__/¯¯\__/    ClusterMesh:    disabled
    \__/

DaemonSet         cilium             Desired: 3, Ready: 3/3, Available: 3/3
Deployment        cilium-operator    Desired: 2, Ready: 2/2, Available: 2/2
Deployment        hubble-relay       Desired: 1, Ready: 1/1, Available: 1/1
Deployment        hubble-ui          Desired: 1, Ready: 1/1, Available: 1/1
Containers:       cilium             Running: 3
                  cilium-operator    Running: 2
                  hubble-relay       Running: 1
                  hubble-ui          Running: 1
Cluster Pods:     26/26 managed by Cilium
Image versions    cilium             quay.io/cilium/cilium:v1.11.2@sha256:4332428fbb528bda32fffe124454458c9b716c86211266d1a03c4ddf695d7f60: 3
                  cilium-operator    quay.io/cilium/operator-generic:v1.11.2@sha256:4c8bea6818ee3e4932f99e9c1d7efa88b8c0f3cd516160caec878406531e45e7: 2
                  hubble-relay       quay.io/cilium/hubble-relay:v1.11.2@sha256:f031f95f3c9ba8962094649c0cc913f90723d553203444c8fb9a591e38873c9d: 1
                  hubble-ui          docker.io/envoyproxy/envoy:v1.18.4@sha256:e5c2bb2870d0e59ce917a5100311813b4ede96ce4eb0c6bfa879e3fbe3e83935: 1
                  hubble-ui          quay.io/cilium/hubble-ui:v0.8.5@sha256:4eaca1ec1741043cfba6066a165b3bf251590cf4ac66371c4f63fbed2224ebb4: 1
                  hubble-ui          quay.io/cilium/hubble-ui-backend:v0.8.5@sha256:2bce50cf6c32719d072706f7ceccad654bfa907b2745a496da99610776fe31ed: 1

Hi, this traffic is not automatically allowed by Cilium if you create a CiliumClusterwideNetworkPolicy. You would need to add a policy like this to allow it:
https://docs.cilium.io/en/stable/policy/kubernetes/#example-add-health-endpoint

(closing given this has been answered)


Doesn't seem to work for Raspberry Pi 3b+

I bought the Raspi 4 official fan (for my Raspi 3b+) and after inputting the whole
sudo systemctl daemon-reload
sudo systemctl enable fancontroller.service
sudo systemctl start fancontroller.service

It didn't reply anything so, in a different terminal I typed:
$ sudo systemctl status fancontroller.service
● fancontroller.service - Fan Controller Service
   Loaded: loaded (/lib/systemd/system/fancontroller.service; enabled; vendor preset: enabled)
   Active: inactive (dead)

IDK why is it "inactive (dead)" if I pinned to 5V, ground and GPIO17 and everything is already installed.

Hello @moshpirit .
I have the following questions:

Did you managed to ran fancontroller.py script with python running python fancontroller.py ? This one should work because you are using GPIO17 too.
Did you edited the fancontroller.service file ? ExecStart=/usr/bin/python3 <YOUR_PATH>/fancontroller.py Instead of <YOUR_PATH> did you put the path were you saved the fancontroller.py ?

Thank you for your quick response!

It seems to have an issue with gpiozero but it is already installed.

$ python fancontroller.py
Traceback (most recent call last):
  File "fancontroller.py", line 3, in <module>
    from gpiozero import PWMOutputDevice, CPUTemperature
ImportError: No module named gpiozero
$ sudo pip3 install gpiozero
Looking in indexes: https://pypi.org/simple, https://www.piwheels.org/simple
Requirement already satisfied: gpiozero in /usr/local/lib/python3.7/dist-packages (1.5.1)
Requirement already satisfied: colorzero in /usr/local/lib/python3.7/dist-packages (from gpiozero) (1.1)

Yes: ExecStart=/usr/bin/python3 /home/admin/scripts/RPi-Fan-Controller-master/fancontroller.py in both /lib/systemd/system/
and /home/admin/scripts/RPi-Fan-Controller-master/

@moshpirit
I see that you installed gpiozero on pip3 -> you've installed the package for python 3+. What I think it's happening it's that when you run python fancontroller.py it's taking the python2 ( my bad that I wasn't that specific ). Can you try again an run the command with python3 fancontroller.py. Make sure that you installed python3 also, because the service it's using python3 as you can see here ExecStart=/usr/bin/python3

It gives me no errors or anything but it doesn't change anything from the starting point

I know it's bit late but what OS are you using?

@mariofenech
I am running this on Ubuntu 20.04 on a RPi 4 arm64

I ment to ask @moshpirit on what OS he was running the script as maybe gpiozero library is not in default location and need to be appended..
find | grep -i gpiozero
import sys sys.path.append('path to gpiozero')


error: 'transaction ID already used' (while optimizing plan)

My Environment

ArangoDB Version:        3.5.0
Storage Engine:             RocksDB
Deployment Mode:       Cluster
Deployment Strategy:
Configuration:
Infrastructure:               own
Operating System:        Centos7
Total RAM in your machine:        64
Disks in use:        10%
Used Package:              rpm

Component, Query & Data
Affected feature:

AQL query (if applicable):
AQL explain (if applicable):

Dataset:

Size of your Dataset on disk:

Replication Factor & Number of Shards (Cluster only):

Steps to reproduce

Problem:
Caused by: com.arangodb.ArangoDBException: Response: 500, Error: 1590 - AQL: error, cluster node: 'PRMR-c338134b-023c-438d-b672-d5f954c2882c', endpoint: 'tcp://xxx:8530', error: 'transaction ID already used' (while optimizing plan)
        at com.arangodb.internal.util.ResponseUtils.checkError(ResponseUtils.java:53)
        at com.arangodb.internal.velocystream.VstCommunication.checkError(VstCommunication.java:149)
        at com.arangodb.internal.velocystream.VstCommunicationSync.execute(VstCommunicationSync.java:128)
        at com.arangodb.internal.velocystream.VstCommunicationSync.execute(VstCommunicationSync.java:42)
        at com.arangodb.internal.velocystream.VstCommunication.execute(VstCommunication.java:132)
        at com.arangodb.internal.velocystream.VstProtocol.execute(VstProtocol.java:47)
        at com.arangodb.internal.ArangoExecutorSync.execute(ArangoExecutorSync.java:71)
        at com.arangodb.internal.ArangoExecutorSync.execute(ArangoExecutorSync.java:53)
        at com.arangodb.internal.ArangoDatabaseImpl.query(ArangoDatabaseImpl.java:197)

Expected result:

Hi @pengshuangbao,
We have already fixed this issue with the following PR https://github.com/arangodb/arangodb/pull/9928

see changelog as well: https://github.com/arangodb/arangodb/blob/f2e933eb06caf670c608f4af9af4b59a167fdad0/CHANGELOG#L259

Please upgrade to our latest ArangoDB 3.5 Version and let us know if you are still facing the same error message
Best,

Thank you very much. What code does the client need to change to upgrade? I used skiplist index and hash index, does it have any impact?

Hi @pengshuangbao,
Instructions on how to perform upgrades of various deployments can be found in the Upgrading section of our documentation.
You reported that a CentOS7 Cluster is in use in the issue template, the "Deployment Strategy" is missing though.
Which of the following options is it?
Manual Start | Manual Start in Docker | ArangoDB Starter | ArangoDB Starter in Docker | Kubernetes | DCOS
Existing indexes persist when performing the upgrade. You do not need to worry about them.

Hi @maxkernbach ,Thank you for your answer， I use ArangoDB Starter model, my cluster has three nodes

Hi @pengshuangbao,
have you been able to upgrade your deployment according to the documentation. Also, are you still observing the reported error message?

Hi @pengshuangbao,
we haven't heard from you recently if you succeeded with the upgrade.
Closing this ticket now. Feel free to re-open if you still have issues.


fix(overlay): disable pointer events if overlay is detached

Currently the overlay element is still visible if the overlay has been detached.
This is problematic if the overlay pane element has an height | wídth set from the state, because now the overlay element may block clicks on the page and overlap the actual content.

The issue isn't noticable for the select and other overlay components, because those don't specify a height | width in their state.
Nevertheless the pane elements are still visible, but just have no height and width set.

Fixes #2739

@DevVersion detach triggers the animations, so hiding it right away would prevent those from running

@jelbourn Good point - I think another idea is to disable pointerEvents if detached. This also ensures that the overlay pane doesn't block any underlying content.

Okay that didn't look pretty good :smile: Should be ready for another review.


Branch 0.4.11

Fixes #56

Coverage remained the same at 100.0% when pulling 1f54f8870457641a78454d227d8300a7d482eeb2 on branch-0.4.11 into 0d85cbcdcfa4825f2556f33ca00a6df53c5b1dc8 on master.


Device Type: Pan/Tilt Cam

Problem
Device is not supported
Solution
Please add the pan/tils cam
Alternatives
No response
Additional context
No response

Sup to #429


[Linux] No image for the taskbar icon

OS: Linux - Debian 8, KDE
3.16.0-4-amd64 #1 SMP Debian 3.16.7-ckt25-2 (2016-04-08) x86_64 GNU/Linux
Issue Descriptions: The taskbar icon is just a white square.
Steps to Reproduce: Start the program.
Snapshot (the blank white square is the Google Play program):

Can you maybe post a picture of it?

This sounds like an issue with Electron, can you post a link to an ISO of your exact distro

Here is a link to the install ISO of my distro. I may not have used this one (8.4), it may have been any from 8.0 - 8.4 since Debian has rolling releases.
http://cdimage.debian.org/debian-cd/8.4.0/amd64/iso-dvd/debian-8.4.0-amd64-DVD-1.iso

If were using a tray icon that is hi-res this could be only showing the top left corner similar to how the windows sound menu was screwing up. We can test this by switching out for a low res icon and seeing if that fixes it.

Maybe its centering it?

Similar problem. Kubuntu 16.04. kde 5.18.0

I'm just going to say that the tray is functioning properly on my Linux machine(s), both running Arch. The tray being tint2; image: here

Soo its maybe a KDE thing?

Hi, somewhat similar problem on a clean install of Ubuntu 16.04 (only thing installed before this was Google Chrome).
There is an icon but it isn't the right one (it is the last icon in the dock on the left, the google one) :

It works fine on my other computers (2 other Ubuntu 16.04 and 2 Windows 10 ones) and the only difference that comes to mind is the way I arrived to this specific version (3.2.4) is that I installed it directly with this one while I updated from previous versions for the other computers (may not be related though).

@sylmarien Different issue, that's actually Ubuntu's fault.  It thinks it is being clever but it isn't :laughing:

Hi I'm having the same problem in the latest Manjaro release. I created a github account to report this. Here's the info you requested from OP.
DISTRIB_ID=ManjaroLinux DISTRIB_RELEASE=16.06-rc2 DISTRIB_CODENAME=Daniella DISTRIB_DESCRIPTION="Manjaro Linux" Manjaro Linux NAME="Manjaro Linux" ID=manjaro PRETTY_NAME="Manjaro Linux" ANSI_COLOR="1;32" HOME_URL="http://www.manjaro.org/" SUPPORT_URL="http://www.manjaro.org/" BUG_REPORT_URL="http://bugs.manjaro.org/"
http://sourceforge.net/projects/manjarolinux/files/release/16.06-rc2/kde/manjaro-kde-16.06-rc2-x86_64.iso

Okay, so this seems to only be affecting KDE users.

That's exactly the case @nanohard. @MarshallOfSound unfortunately the fix for this is to reduce the icon  dimensions. 24x24 seems to be the magic number, however we can probably use the @Nx syntax to implement larger logos where needed.

@Nx doesn't work on Linux and in high DPI Linux environments the icon needs to be larger.  To be honest, icon scaling is actually an issue with the OS as literally every other OS (including other Linux based ones) scales the icon correctly.
I mean, even windows scales it correctly :laughing:
Is there official docs / reasoning behind the lack of icon scaling

Nothing official, just looking at other electron apps:
https://github.com/sindresorhus/caprine/issues/58
Nylas n1 uses the<EMAIL_ADDRESS>as seen here:
https://github.com/nylas/N1/tree/master/internal_packages/system-tray/assets/linux
I'm currently looking in other electron apps at the moment to see how they handle linux DPI tray icons.

On second thought, KDE appears be the exception to the norm here. Can we do a check for KDE and give them a special icon?

I can't confirm the problem of @sylmarien on Ubuntu
latest install on Ubuntu 14.04 64 bit, showing both correct symbols

@joergi77 : Yes, I couldn't reproduce it either (had to reinstall a few times my computer and this problem never showed up again). Let's consider my case closed for now.

These were two separate issues really, the white icon issue, and the wrong icon issue. The white icon issue can be solved by checking for kde and using the lowest res icon available (unless kde fixes it themselves). The other issue is sort of sporadic and has nothing to do with the white icon issue.

@jostrander Do you have any idea how we would identify KDE?

GDMSESSION=kde-plasma
As seen here, not sure it will be the same for Manjaro, one of theme will need to reply with their environment variables to confirm.
http://askubuntu.com/questions/72549/how-to-determine-which-window-manager-is-running

+1
I tried to write a multi resolution PNG (using "convert" ImageMagick) but still does not work.
Overwriting /usr/share/pixmaps/google-play-music-desktop-player.png
So, the problem should be something different
Debian 8 + KDE

@24mu13 That's the wrong image file 😆
The actual file should be in a ......../build/assets/img/main.png style path

@MarshallOfSound :+1:
So I confirm the opposite: changing the png with a multi-resolution png works fine also in KDE !
See also: http://www.imagemagick.org/Usage/thumbnails/#favicon

@24mu13 Can you please confirm that the fix I just pushed works on KDE 👍

No, I'm sorry.
Is it the icon multi-res ?

@24mu13 Yeah, it contains 16, 32, 128 and 256

Ok, so most probably the issue is checking the environment.
> echo $XDG_CURRENT_DESKTOP
KDE

You can check for KDE only in the first 3 chars. In this way you are KDE 4/5 compliant...
S.

@24mu13 What is your $GDMSESSION env var

empty :-o


Implement hand gestures containers and providers

@ankxyz looks awesome! I'm OK with merging these updates. I left few comments, but not blocking 👍


Unable to convert - NotADirectoryError

I am trying to convert an image and getting this error
$ legofy wait-what.jpg
Static image detected, will now legofy and save as /lego_wait-what.png
Traceback (most recent call last):
  File "/home/anand/.virtualenvs/3/bin/legofy", line 9, in <module>
    load_entry_point('legofy==0.0.1', 'console_scripts', 'legofy')()
  File "/home/anand/.virtualenvs/3/lib/python3.4/site-packages/click-5.1-py3.4.egg/click/core.py", line 700, in __call__
  File "/home/anand/.virtualenvs/3/lib/python3.4/site-packages/click-5.1-py3.4.egg/click/core.py", line 680, in main
  File "/home/anand/.virtualenvs/3/lib/python3.4/site-packages/click-5.1-py3.4.egg/click/core.py", line 873, in invoke
  File "/home/anand/.virtualenvs/3/lib/python3.4/site-packages/click-5.1-py3.4.egg/click/core.py", line 508, in invoke
  File "/home/anand/.virtualenvs/3/lib/python3.4/site-packages/legofy-0.0.1-py3.4.egg/legofy/cli.py", line 14, in main
  File "/home/anand/.virtualenvs/3/lib/python3.4/site-packages/legofy-0.0.1-py3.4.egg/legofy/__init__.py", line 131, in main
  File "/home/anand/.virtualenvs/3/lib/python3.4/site-packages/legofy-0.0.1-py3.4.egg/legofy/__init__.py", line 67, in makeLegoImage
  File "/home/anand/.virtualenvs/3/lib/python3.4/site-packages/legofy-0.0.1-py3.4.egg/legofy/__init__.py", line 54, in makeLegoBrick
  File "/home/anand/.virtualenvs/3/lib/python3.4/site-packages/PIL/Image.py", line 2249, in open
    fp = builtins.open(filename, "rb")
NotADirectoryError: [Errno 20] Not a directory: '/home/anand/.virtualenvs/3/lib/python3.4/site-packages/legofy-0.0.1-py3.4.egg/legofy/bricks/brick.png'

This should be fixed, please try with the newest code.

Yep, its working.
Thank you @JuanPotato


[fix](type compatibility) fix unsigned int type compatibility problem

Proposed changes
Fix unsigned int type compatibility value scope problem.

When defining columns, map UNSIGNED INT to BIGINT for compatibility.

The problems are as follows:

It is not consistent with this doc

We support the unsigned int type to be compatible with mysql types, but the unsigned int type is created as the int at the time of definition. This will cause numerical overflow.
Problem summary
Describe your changes.
Checklist(Required)

[ ] Does it affect the original behavior
[ ] Has unit tests been added
[ ] Has document been added or modified
[ ] Does it need to update dependencies
[ ] Is this PR support rollback (If NO, please explain WHY)

Further comments
If this is a relatively large or complex change, kick off the discussion at<EMAIL_ADDRESS>by explaining why you chose the solution you did and what alternatives you considered, etc...

run buildall

TeamCity pipeline, clickbench performance test result:
the sum of best hot time: 35.26 seconds
stream load tsv:          469 seconds loaded<PHONE_NUMBER>9 Bytes, about 152 MB/s
stream load json:         39 seconds loaded<PHONE_NUMBER> Bytes, about 57 MB/s
stream load orc:          68 seconds loaded<PHONE_NUMBER> Bytes, about 15 MB/s
stream load parquet:          28 seconds loaded 861443392 Bytes, about 29 MB/s
https://doris-community-test-1308700295.cos.ap-hongkong.myqcloud.com/tmp/20230305083340_clickbench_pr_108678.html

run buildall

run p1

run p1

run buildall

run buildall

run p0

run p0


[PG] reference files correctly

Please make sure to label your PR with "bug", "new feature" or "breaking change" label(s).
To prevent this PR from going to the changelog marked it with the "skip changelog" label.

Snapshot stored with reference name:
refs/pull/13403/merge
Test environment:
https://babylonsnapshots.z22.web.core.windows.net/refs/pull/13403/merge/index.html
To test a playground add it to the URL, for example:
https://babylonsnapshots.z22.web.core.windows.net/refs/pull/13403/merge/index.html#WGZLGJ#4600
Links to test babylon tools with this snapshot:
https://playground.babylonjs.com/?snapshot=refs/pull/13403/merge
https://sandbox.babylonjs.com/?snapshot=refs/pull/13403/merge
https://gui.babylonjs.com/?snapshot=refs/pull/13403/merge
https://nme.babylonjs.com/?snapshot=refs/pull/13403/merge
To test the snapshot in the playground with a playground ID add it after the snapshot query string:
https://playground.babylonjs.com/?snapshot=refs/pull/13403/merge#BCU1XR#0


Floating boxes in the Heterogeneous pallet loading

StackBuilder version <IP_ADDRESS>
Os : Windows 10
Boxes were levitating whle i was using the heterogeneous pallet loading option. I defined 3 different boxes and I unchecked axes X and Y. Then I went though different options possible, in one of them the boxes were levitating.

I have the same problem.

And other solutions are not optimized :

Since the freight cost is based on volume, it should offer the solutions with the lowest height of pallet, which is obviosly not the case here

Other issues with Heterogeneous pallet loading :

size of the boxes not respected (1 of the 4 brown boxes has been given a different size)

box exceeds the limits of the pallet, when there is obviously space enough on the palet (orange box)

box intersects / conflicts  with other boxes (yellow box)

Stacks floating in the air boxes when Z orientation is off too
image
image


ds9 region parsing should handle whitespace

As per https://github.com/astropy/pyregion/issues/73, there are some regions that are valid for ds9 but are not included in the test cases now and are not properly parsed.

hi @keflavich ,
i went to said issue and tried to reproduce the error. the problem i saw  that it doesn't identify J2000 as a coordinate system. i think it should be mapped to fk5 and it seems to handles whitespace pretty well ( i only tried to reproduce the example given: 'J2000; circle<PHONE_NUMBER> 12.0314056 1" # color=red' ). it seems to work after that..

If you think you've found a solution, yes, go ahead and open a PR.  I'm not entirely sure the J2000 frame is the problem, given the description in the other issue, but it might be.

@keflavich initially i thought the same. But i built it and it's working.! Do have a look over the PR.

This issue is fixed.


phpbbauth blocking search engines?

Hi,
I've installed your add-in and everything works great!
https://www.thegreenbutton.tv/wiki/
I have an issue with all search engines getting internal server 500 errors when it's active though.
I've confirmed this by removing the following entry in localsettings.php:   require_once "$IP/extensions/Phpbbauth/PhpbbAuth.php"
Search engines get an OK 200 response when the add-in is not in use.
Does anybody else see this issue, or have any ideas how to work around it please?

Looking into this. I just tested it on your site and switched my user-agent to "Googlebot".
I get the following error:

[W5hddLx5KZcAAFQOmN8AAAAm] 2018-09-12 00:27:33: Fatal exception of type "InvalidArgumentException"

phpBB handles Bots kind of like a logged in user, so I will have to investigate this and get back to you. It is undeniably very important to get it fixed!

Thanks for taking the time to look at it, I'll try the new version and report back.
I recently upgraded to phpbb 3.2.2, I was previoulsy on a 3.0x version and used the older auth_phpbb add-in with MW 1.2x
I did wonder after posting if it may actually be the auh_remoteuser add-in that was the cause and found item 35 in this list:
https://www.mediawiki.org/wiki/Extension_talk:Auth_remoteuser
I tried changing minimalpassword lengths etc but still had the same issue, the second option no longer seems to be an option as the code has been refactored and the file mentioned no longer exists.
The issue was definitely present before I installed the cleantalk add-in, I'll uninstall it temporarily while testing the new version just to be sure.
Thanks again.

I just tried the new build without doing anything else and everything is working, google can successfully crawl the wiki!
Many thanks for taking the time to fix this for me!
Rob.

Woo! Thanks for helping improve it.


Replace the icon with @yamada-ui/lucide

Subject
All pages
Description
Currently, We are using the icon from components/media-and-icons, but I would like to replace it with the icon from @yamada-ui/lucide.
Are you willing to participate in the development of this feature and create a pull request?
None

I'll try it.


use different delimiter for the sed at the puppet facts cronjob

Using '%' as delimiter for the sed at the 'puppet facts' cronjob ends up
to the following error:
Subject: Cron root@server puppet facts --render-as yaml |sed 's
/bin/sh: -c: line 0: unexpected EOF while looking for matching `''
/bin/sh: -c: line 1: syntax error: unexpected end of file
Replacing the delimiter with '#' instead works fine

Thanks for this @tampakrap!


Enhanced Party Requirements

Souldoggo
an autokick if someone doesnt meet the party reqs (e.g, no arch, cata 30, must have necrons/storm, sa 30, slayer 7/7/7)

While its against monkey finder, it is annoying and toxic

Not auto kick, but warn if it's low skill player


Listening to px-dropdown-selection-changed events in the same page while using multiple px-dropdowns

I'm using px-dropdown in my angular 4 project and using the below code to listen to selection changes.I'm able to get the selected value but if I use multiple 'px-dropdown' in the same page how can I listen to each separately is the concern.
JS:
 document.addEventListener('px-dropdown-selection-changed', function (evt: any) {              const selectedData = evt.detail.key;          });
HTML:
 <px-dropdown id="sensor-selection"  items='[{"key":"All Data Sources","val":"All Data Sources"},{"key":"Item1","val":"Box Model"},    {"key":"Item2","val":"Circle Model"},{"key":"Item3","val":"Triangle Model"}]' button-style="tertiary" selected="All Data Sources"></px-dropdown>
If I add another px-dropdown in the same page with different selection criteria  it also listens to the same event listener and triggers actions that are related to the previous dropdown and performs functions associated to that.
Please let me know how can I achieve it as I find no difrentiators in px-dropdown-selection-changed events while using multiple px-dropdowns

Answered on the forum:
https://forum.predix.io/questions/29812/listening-to-multiple-px-dropdown-selection-change.html


deps: deploy: mco: crd: catch up with ocp/mcp/pull/4597

OCP changed the manifests location, change our URLs accordingly. Relevant PR: https://github.com/openshift/machine-config-operator/pull/4597

/lgtm
/approve

/lgtm
thanks for the fix

CI still broken, but the fix was exercised correctly

sweet:
F0924 13:24:20.647978       1 main.go:118] failed to execute: failed to initialize ResourceMonitor: error while updating node allocatable: rpc error: code = Unavailable desc = connection error: desc = "transport: Error while dialing: dial unix /host-podresources/kubelet.sock: connect: permission denied"


Make command palette a modal dialog?

From #318, for discussion.

You mean instead of in the sidebar?

Yes, I think that was what #318 was suggesting we discuss.

Closing as duplicate of #447


Error "str.replace is not a function"

Continuing discussion of the new type of error https://github.com/jsanahuja/jquery.instagramFeed/issues/103#issuecomment-790524571

Can confirm, it works
@web-burn, what about your side?

@mahotilo, yes, it works fine.

now it is not working :(
https://www.sowecms.com/demos/jquery.instagramFeed/index.html


Gemfile: add faraday as GCG dependency

It's an optional dependency of GCG and we get warnings if it's missing. We added it to other repos as well.

rubocop is fixed in #81


Missing RBAC permissions for controller service account

When running RCS from the main branch, we are missing these permissions:
//+kubebuilder:rbac:groups=rcs.dana.io,resources=capps/status,verbs=update
//+kubebuilder:rbac:groups=work.open-cluster-management.io,resources=manifestworks,verbs=get;list;watch;create;patch;update;delete
//+kubebuilder:rbac:groups="rcsd.dana.io",resources=rcsconfigs,verbs=get;list;watch
//+kubebuilder:rbac:groups="rbac.authorization.k8s.io",resources=rolebindings,verbs=get;list;watch

Fixed by #78


[JENKINS-40368] Resources not unlocked after a hard kill

Fixing  JENKINS-40368
The problem is that LockableResourcesManager is supposing a queued context will always have a valid linked build (waiting for the lock), but that turns to be false under some circumstances, like the one described in this issue: a hard killed job which for some other reason does not call LockRunListener.onComplete - something to be investigated separately. As it can happen if Jenkins is stopped abruptly so there is no chance to call anything, a fix here is needed regardless the potential fix upstream.
This fix also fixes the UI button to forcibly release a resource (which is throwing an exception when a queued context does not have a live build linked). With this fix the resource is released and the next context waiting for the lock proceeds.
@reviewbybees

We really need a test for this use-case.

We really need a test for this use-case.

This is kind of a race condition I was not able to reproduce it consistently, so it's going to be difficult to write a test, but yes, it is worth a try.

Perhaps something is possible using latches. Agree these are hard to test, but this seems like a key responsibility of this plugin.

Certainly reproducing a hard kill done at a particular time is easy—SemaphoreStep.waitForStart followed by WorkflowRun.doKill.

This pull request originates from a CloudBees employee. At CloudBees, we require that all pull requests be reviewed by other CloudBees employees before we seek to have the change accepted. If you want to learn more about our process please see this explanation.

:bee:

Ping @amuniz


In markdown.preview, CSS's 1em does not correspond to .fontSize.

Does this issue occur when all extensions are disabled?
Yes

VS Code Version
code-insiders-1.91.0-1719555839.el8.rpm

OS Version
cpe:/o:fedoraproject:fedora:40

Steps to Reproduce
I've set markdown.preview.fontSize to 13 px:

"markdown.preview.fontSize": 13 // Matches my OS.

Yet, I noticed when setting :not(h1) {font-size: 1em;}:
<style>
  :not(h1) {font-size: 1em;}  /* this should render larger than `markdown.preview.fontSize` - mine is set to 13px. */
  :is(h1) {font-size: 1.5em;} /* demonstrates that it appears to scale correctly (at least, past `0.9em`) but is merely set to an arbitrary constant. */
</style>

...that this set the font size much too large. 13px renders it as I expect, so why isn't 1em set to the markdown.preview.fontSize, as it should be?

When you set :not(h1) { ... } , that also applies to the <body> and overrides the configured font size on the page. It then ends up going to the default font size for the browser
You should exclude body from the :not too

https://github.com/microsoft/vscode/issues/219520#issuecomment-2203971073

@mjbvz, that's exactly what I'm confused by - each em should be taking its value from markdown.preview.fontSize. Otherwise, when I scale anything other than <body> by 1em, it'll correspond to the "browser default", instead of markdown.preview.fontSize. Shouldn't the browser default correspond to markdown.preview.fontSize...?

each em should be taking its value from markdown.preview.fontSize

Try debugging the page with the dev tools. markdown.preview.fontSize is set on the body element and your custom css is overriding it so that there is no configured font size  for the page

https://github.com/microsoft/vscode/issues/219520#issuecomment-2204045500

When none is configured, I would expect the browser to fall back to markdown.preview.fontSize, rather than whatever arbitrary value it uses instead. After all, the value it's using has to be applied from somewhere - I presume a config file somewhere?

No we use a style sheet just like a normal webpage

https://github.com/microsoft/vscode/issues/219520#issuecomment-2204066201

@mjbvz, do you know where your style sheet is specified?


Add non-static DFA.intersect(dfa) and NFA.intersect(nfa) methods

I think non-static methods i.e. dfa1.intersect(dfa2) would make the intersection API more discoverable (I nearly opened an issue because I initially didn't find DFA.fromIntersection()).

fromIntersection is a static method on both NFA and DFA because the return type of fa1.intersect(fa2) isn't well-defined. If both FAs are either DFAs or NFAs, then the result can be a DFA or NFA respectively.
But what should nfa.intersect(dfa) and dfa.intersect(nfa) return?
Intersection is a commutative operation, so ideally the return type of both should be the same. I also plan to add epsilon-NFAs in the future, so the solution has to scale with potentially many FA kinds.
And the solution has to be simple of course! :)
Well, those are the reasons I went with static methods but I do agree that the API is a little hidden. This is more of a documentation issue instead of an API issue, IMO.

Fair enough. Thanks for the quick response! Yeah I agree that the documentation can be improved ... maybe set up something like typedoc?

I opened #22 for Typedoc.
However, it will likely take some time until I can actually use Typedoc because it has a bug that causes it to not generate documentation for the JS namespace.


Configuration settings for "Email" don't seem to be organized under the right headings

Starting from this top-level documentation page:
https://docs.mattermost.com/administration/config-settings.html
If I click on the "Email" entry of the table of contents I'm take down to the "Experimental Settings on in config.json", which seems to be blank, so not required.
I was actually trying to get to the "Email Notifications/Server" settings section here.
Granted, if had been paying attention to the Primary Section I was clicking in I would have known it was for "Experimental" settings, but my journey to SMTP would be a bit longer than it should be.
Wondering if we:

Remove the "Experimental Settings" section which doesn't seem to have anythign in it anyway
Add to the SMTP header to say "SMTP (Email Notifications)"

Actualy, the stuff I was looking for was in the notifications section:
https://docs.mattermost.com/administration/config-settings.html#enable-email-batching
Given a bunch of these settings are organized under the same section of config.json I wonder if they should be discoverable on the docs page this way.

Thanks for this, @sadohert. I've assigned @cwarnermm to this for her perspective. :)

@sadohert cc @justinegeffen
The organization of Mattermost Server configuration settings is not an ideal self-serve experience for users. I agree with @sadohert that reducing path friction and making content more discoverable is a key goal.
Organizing the configuration settings in a customer-focused, logical, discoverable way is likely a bigger cross-team discussion.
Immediate recommendations: apply #1 & #2 and confirm #3 below:

SMTP

update title to "SMTP Email Server"
update description as "Location of SMTP email server used for email notifications."

Enable Email Batching

update the note to include a link to the updated SMPT section since SMTP is also required for email notifications/email batching.

Review the Experimental section and confirm whether current content is intentional or requires updates:

Experimental

Features = appears empty; intentional?
AD/LDAP Settings = appears empty; intentional?
Inconsistent use of (Experimental) in titles - intentional?

Thoughts? Concerns?

Thanks, @cwarnermm! I'm 5/5 on all your suggestions.
Wrt point 3, I think the issue is actually with the header formatting and that it is possibly meant to be H1: Experimental > H2: Features > H3 AD/LDAP Settings followed by the content. I am not certain this is the case though, so looping @wiersgallak in as she may have a better idea.


Extension causes high cpu load

Issue Type: Performance
Extension Name: vsliveshare
Extension Version: 0.3.1071
OS Version: Linux x64 4.15.0-42-generic
VSCode version: 1.30.0

:warning: Make sure to attach this file from your home-directory: /home/willsnake/ms-vsliveshare.vsliveshare-unresponsive.cpuprofile.txt :warning:
Find more details here: https://github.com/Microsoft/vscode/wiki/Explain:-extension-causes-high-cpu-load

Duplicate of #1449. Also did you forget to attach the file cpuprofile.txt file?


Add possibility to select date range for weekly/monthly report.

Sometimes if you missed EOW or EOM you can't send a weekly or monthly report. It will be useful to add the possibility of selecting the date range for MONTHLY_VIEW and WEEKLY_VIEW

new widgets generator allow to update period as you wish starting from 24 hours till total history.
Moreover some of the charts automatically choose group by period to show data correctly.
3.4.51+


Mask analysis

opening a PR here with refactored analysis code that will mask on the basis of a bed file that one defines in the config.json file. for this i've created a directory at analysis/n_t/masks which contains bed formatted masks as well as a script written by @dschride to create them on the basis of the genetic map.
right now the exact mask we should use is debatable but I want to get this PR going as it allows for the behavior we wish to achieve.

This is working on my end. My only suggestions would be to remove the older ld-based filtering functions to avoid any confusion down the road. Or were you intending to keep both?

sounds good, i'll ditch the ld-filter mask from the workflow

To my eyes, the SFS from the masking done here looks much better than it did using the ld-filtering. Also, adding an automated plotting function to compare the masked and unmasked SFS would be nice, which I believe you have already implemented.

yes i have to clean this up a bit still and segregate all the plotting to a single file.

Okay @jradrion this is all squashed, cleaned, and ready for a merge I believe. Let's try to merge this before we merge the SMCSMC PR

OK @andrewkern, just tested this and everything is working on my end!

okay merging

Good deal! We can probably close the corresponding issue as well.


Compatibility issue with pdfpages

I have been using your template for a while on Overleaf with pdflatex, and it's great! However, I discovered a weird issue: when adding pages from another PDF document, using the \includepdf command from the pdfpages package, if the option bg in the dndbook class is set to full (as it is by default), the background image (e.g. img/paper.jpg) is rendered ON TOP of the the included PDF images, hiding the content. By setting bg=none or bg=print, the issue disappears.
I looked into the dndheader.sty, and it looks like that the code adding the background figure is on lines 36-44:
% Header is used to include the page background
\fancyhead{
\bool_if:NT \l__dnd_show_background_bool
{
\begin{tikzpicture}[remember~picture,overlay]
\node[inner~sep=0pt] at (current~page.center) {\includegraphics[width=\paperwidth,height=\paperheight]{img/paper}};
\end{tikzpicture}
}
}
Unfortunately I am not familiar with the packages used: is it possible that there is a mistake somewhere that creates this (I assume incorrect) behavior?

I actually found the solution. The issue was that in dndheader.sty, on line 70, the pagestyle{empty} was defined as:
\fancypagestyle{empty}{%
  \fancyfoot{}
}

So, the pagestyle was resetting only the footer, and not the header (who inserts the background image): while adding
\fancypagestyle{empty}{%
  \fancyhead{}\fancyfoot{}
}

solves the issue, because it also resets the header, removing the background from pages with \thispagestyle{empty}

Apologies for the long delay. Life has been hectic.
I think your best option would be to add a new page style for included pdf pages.
\fancypagestyle{includedpdf}{%
  \fancyhead{}\fancyfoot{}
}

You switch to that page style before including the PDFs, and back to fancy when you are done.

Adding a concrete example of how I handle this:
% In pre-amble
\fancypagestyle{cover}{\fancyhf{}}
% Later in the document
\includepdf[pagecommand={\thispagestyle{cover}}]{img/full-page-pdf}

As the same implies, I mainly use the style for covers, which I render as follows:
\null%
\includepdf[pagecommand={\thispagestyle{cover}}]{cover}%
{\let\newpage\relax\maketitle}


regen for https://github.com/Azure/autorest.csharp/pull/3119

Fixes https://github.com/Azure/azure-sdk-for-net/issues/31127
Contributing to the Azure SDK
Please see our CONTRIBUTING.md if you are not familiar with contributing to this repository or have questions.
For specific information about pull request etiquette and best practices, see this section.

This PR contains some changes in DPG packages and those changes will be handled by https://github.com/Azure/azure-sdk-for-net/pull/34182, and once that merges, those DPG changes should vanish

API change check
APIView has identified API level changes in this PR and created following API reviews.
Azure.IoT.DeviceUpdate

LGTM, one more question is do we need to update the emitter version?

The publish pipeline will always do that

Something is wrong in storage data plane packages.
The api file change:
The added API shown in this PR is added by this PR: https://github.com/Azure/azure-sdk-for-net/pull/34089
The API file is added in this PR: https://github.com/Azure/azure-sdk-for-net/issues/34125
But something magic must happen, the added API is not generated in the api file in #34125
Somehow the pipeline suppose it is not correct right now, therefore I regenerate it in my PR.
About the build fail:
I believe we must fix it. It is introduced by this automatic version bump: https://github.com/Azure/azure-sdk-for-net/pull/34440 because we never have a ApiCompat check on the package Microsoft.Azure.WebJobs.Extensions.Storage before.
The failure is on that PR but @seanmcc-msft suppressed the failure and merged the PR.
I will do the same on my PR, but I believe we need to fix it instead of suppressing it.

/check-enforcer override


xt/examples-compilation.t fails

https://docs.perl6.org/type/Telemetry
has this sample:
use Telemetry :COLUMNS;   # imports all of the possible columns of report

but this dies with:
16:30 < [Coke]> m: use Telemetry :COLUMNS;
16:30 <+camelia> rakudo-moar 4a32089fd: OUTPUT: «===SORRY!=== Error while
                 compiling <tmp>␤Error while importing from 'Telemetry': no
                 such tag 'COLUMNS'␤at <tmp>:1␤------> use Telemetry
                 :COLUMNS⏏;␤»

I think @lizmat knows about it.

This is documentation being out of date.  Telemetry doesn't export any columns anymore, as it has become completely pluggable with Instruments.  I will work on updating the documentation this week.

reminder ping

ping received!

On 16 Dec 2017, at 23:19, Zoffix Znet<EMAIL_ADDRESS>wrote:
reminder ping
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or mute the thread.

PING lizmat (lizmat) 56(84) bytes of data.
64 bytes from lizmat: icmp_seq=1 ttl=57 time=44520000.0 ms
^C
--- lizmat ping statistics ---
1 packets transmitted, 1 received, 0% packet loss, time 0ms
rtt min/avg/max/mdev = 44520000.0/44520000.0/44520000.0/0.000 ms

looks like this was fixed, thanks.


Binaries

Any ideas on how to conveniently get Windows binaries?
I guess on unix compiling should be pretty straight forward.

I have dual boot Linux/Windows so maybe I'll be able to compile, I'll try later today

Windows binaries are here: https://github.com/JuliaGeometry/tetgen.dependency
Linux ones still missing :) I suggest we keep all original tetgen content in the tetgen.dependency repo under the AGPL license and develop this wrapper under the MIT license

Sounds like a good idea!
But don't we need a shared library to make things work nicely, or am I
missing something?
2015-02-10 21:46 GMT+01:00 Ariel Keselman<EMAIL_ADDRESS>
Windows binaries are here:
https://github.com/JuliaGeometry/tetgen.dependency
Linux ones still missing :) I suggest we keep all original tetgen content
in the tetgen.dependency repo under the AGPL license and develop this
wrapper under the MIT license
—
Reply to this email directly or view it on GitHub
https://github.com/JuliaGeometry/TetGen.jl/issues/2#issuecomment-73780222
.

I actually generated a shared library for the predicates with MinGW (I didn't get CL to create Julia compatible DLL's), but I didn't know how to link this to tetgen. It gave me undefined symbols, which where most likely the predicates.
It should be quite easy, if you know g++/gcc a little better than me ;)

I just added the DLLs generated with VS, can you try them?

Totally forgot how annoying this whole C++ VS business is -.-
We don't really need a DLL right? Either we need to write a C-wrapper, or use Cxx, which both would just need the .lib, correct?
Your lib actually didn't work for me and I had to compile it myself (when linking it in a C++ test project).
Did you define #define TETLIBRARY ?
Also, the dll is empty in dependency walker, which might not be a surprise because we would need to export the symbols?!
Sorry, has been a long time since I've worked with C++ ;)

I actually tired, doesn't work, Julia just cannot see the exported functions. I'll try again tomorrow

Yep well need to make a C-wrapper I guess, we need also to export the symbols. This is what I just did but still didn't work

Any news on this matter?

Yes, this works now!


[WIP] Emit VM power status

Which issue this PR addresses:
Fixes 7709492
What this PR does / why we need it:
Emit a metric if clusters have stopped/deallocated VMs and skip emitting other metrics. This will make it easier to differentiate this issue from other causes of API Server Healthz.
Test plan for issue:
Unit tests, integration testing
Is there any documentation that needs to be updated for this PR?
SRE SOP will include information on this new metric.

This needs to go back to the drawing board :-(
We cannot query the individual power state of every VM in every cluster every minute in BBM via ARM. It is too expensive.
Let's discuss the requirements here and possible ways to implement before proceeding.

@jim-minter I just added a commit which changes it so that the VM power is only checked if API server status code is not 200. Is that a step in the right direction?

/azp run ci

Not necessary right now and potentially very expensive. Will update SRE runbook saying to check power status.


MINOR: Ignoring streams tests until there is fix for KAFKA-3354

Per discussion with @guozhangwang, @ignore failing streams system tests until fix for KAFKA-3354 is checked in.

Ping @guozhangwang

LGTM.

Merged to trunk.


Perf: Investigate why we have so many threads in IslandwoodNews and WOCCatalog after initial app launch

IslandwoodNews has ~32 threads just after launch, and WOCCatalog has ~22; both seem quite high.
We should investigate why we have so many threads, and reduce the thread count if possible.

@jaredhms Anything to reduce the thread count would be appreciated. Also, I notice, upon closing the app window (termination of app), the threads exit with status code 1 and not 0 (?) and I'm also wondering about that.


Spawn on first join

Same thing as last time just forgot to recommend this cant setworldspawn in my custom world but can set /spawn in my custom world just need it so when the play joins for the first time it spawns them at /spawn

How about multiple spawn points of which one can be the first join spawn?


Update ke_scanner_rules.yaml with CIS Benchmark Examples

Proof of Concept of CIS Benchmarks for k8s. Peer review requested.
Do not merge yet.
Thanks for opening a Pull Request!
Here's a handy checklist to ensure your PR goes smoothly.

[x] I signed Google's Contributor License Agreement
[n.a.] My code conforms to Google's python style.
[n.a.] My PR at a minimum doesn't decrease unit-test coverage (if applicable).
[x] My PR has been functionally tested.
[Not Tested] All of the unit-tests still pass.
[n.a.] Running pylint --rcfile=pylintrc passes.

These guidelines and more can be found in our contributing guidelines.

@Red-Five I apologize for it taking so long to get some forward progress here. Are you able to add the following comment/disclaimer to the PR and we can now get this work accepted.
This scanner has not been validated by the formal CIS certification process.


feat: update example session secret for devcontainer

should be at least 32 characters to follow env validation

Current dependencies on/for this PR:

main

PR #258   👈

This stack of pull requests is managed by Graphite.


restore original location of API stubs

after #12403 the URL of API pages moved from generated/ to api/generated/. This will break lots of links from the forum (as pointed out by @mscheltienne) and will also break the version switcher's ability to find corresponding pages in different docs versions.
This PR puts the autodoc stub files back where they used to be, to avoid all that badness.
supersedes / closes #12100

Thanks @drammock


Vietnamese - Fix some translated words (master branch)

This code is now deprecated. Please make changes in https://github.com/eosdac/eosdac-client instead.


UnpackArgs: permit parameters of user-defined Value subtypes

We use reflection to assign the actual value to the parameter variable.
It is a fatal error if the parameter variable is not a skylark.Value.
Fixes issue google/skylark#8

FYI, you can write Fixes #8 in your commit message. When the PR is submitted, the issue will be closed automatically.

On 11 October 2017 at 14:06, Jay Conrod<EMAIL_ADDRESS>wrote:

FYI, you can write Fixes #8 in your commit message. When the PR is
submitted, the issue will be closed automatically.

Thanks. I thought both "issue" and the repo name "google/skyark" were
optional extras, but empirically, apparently not; perhaps they are
Gerrit-isms.
I will use "Fixes #8" in future.


fix: Trame issues

Description
Partially addresses issues from #1110
Issue linked
#1110
Checklist

[x] I have tested my changes locally.
[x] I have added necessary documentation or updated existing documentation.
[x] I have followed the coding style guidelines of this project.
[x] I have added appropriate unit tests.
[x] I have reviewed my changes before submitting this pull request.
[x] I have linked the issue or issues that are solved to the PR if any.
[x] I have assigned this PR to myself.
[x] I have added the minimum version decorator to any new backend method implemented.
[x] I have made sure that the title of my PR follows Conventional commits style (e.g. feat: extrude circle to cylinder)

Codecov Report
Attention: Patch coverage is 42.42424% with 19 lines in your changes are missing coverage. Please review.

Project coverage is 90.56%. Comparing base (fb35396) to head (b4cb66b).

Files
Patch %
Lines

src/ansys/geometry/core/plotting/trame_gui.py
29.62%
19 Missing :warning:

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1148      +/-   ##
==========================================
- Coverage   90.76%   90.56%   -0.21%
==========================================
  Files          93       93
  Lines        6966     6987      +21
==========================================
+ Hits         6323     6328       +5
- Misses        643      659      +16

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


rename persistentVolumes to volumeClaims

This commit renames the persistentVolumes field and its JSON tag
in spec.App to volumeClaims.
Every other code change is a result of this refactor.
Docs and examples are also changed to accommodate this change.
Fixes #51

LGTM


Clean up of BinomialLogit distribution and adding determinantal point process

This PR cleans up the implementation of the BinomialLogit and its multivariate variant.
Additionally, this PR adds the determinantal point process (the original intention of this PR).
Summary:

Changed VecBinomialLogit to MvBinomialLogit and fixed subtyping
Improved doc strings for BinomialLogit and MvBinomialLogit
Added rand functions
Added determinantal point process (DeterminantalPointProcess)
Added test for determinantal point process

Todo:

Added more tests.
Add rand function for determinantal point process
Add k-determinantal point process

Hi @trappmartin, is there anything missing from this PR? If not, can you do a rebase before merging?

Yes, will do tomorrow.

@trappmartin


Derive Clone for both Text and Counter

Clone is often required to be implemented/derived for user-space structs/enums that might include Text and Counter.  However, currently users are unable to derive Clone on parent structs/enums that include Text and Counter as members.
This PR derives Clone for Text and Counter to make these types easier to use.

@alexjg and team: awesome work on Autosurgeon, it's been really smooth to integrate into our project.
The only hiccup we had is the issue described above.  We're working from our fork now, but would love to get this enhancement into a Autosurgeon crate release.

Thanks for the kind words and the contribution :slightly_smiling_face:

This is now published as 0.5.1


'PDFObjRef' object has no attribute 'getitem'

Hello,
I'm trying to parse some pdf files using pdfquery and it seems that for a couple of pdf's(not all of them) I receive the following error:
File "my_path/my_script.py", line 244, in set_description pdf.load()
  File "/my_path/.virtualenvs/dev/local/lib/python2.7/site-packages/pdfquery/pdfquery.py", line 373, in load
    self.tree = self.get_tree(*_flatten(page_numbers))
  File "/my_path/.virtualenvs/dev/local/lib/python2.7/site-packages/pdfquery/pdfquery.py", line 475, in get_tree
    for n, page in pages:
  File "/my_path/.virtualenvs/dev/local/lib/python2.7/site-packages/pdfquery/pdfquery.py", line 596, in <genexpr>
    return (self.get_layout(page) for page in self._cached_pages())
  File "/my_path/.virtualenvs/dev/local/lib/python2.7/site-packages/pdfquery/pdfquery.py", line 591, in get_layout
    layout = self._add_annots(layout, page.annots)
  File "/my_path/.virtualenvs/dev/local/lib/python2.7/site-packages/pdfquery/pdfquery.py", line 639, in _add_annots
    annot['URI'] = annot['A']['URI']
TypeError: 'PDFObjRef' object has no attribute '__getitem__'

Below is a list with just a couple of pdf's that raises the above error:
http://www.genomecanada.ca/medias/pdf/en/genomesciencescentrebc.pdf
http://www.genomecanada.ca/medias/pdf/fr/genomesciencescentrebc.pdf
http://www.genomecanada.ca/medias/pdf/en/universityvictoria.pdf
http://www.genomecanada.ca/medias/pdf/fr/universityvictoria.pdf
http://www.genomecanada.ca/medias/pdf/fr/centreforappliedgenomicsogi.pdf
Maybe someone will be able to find a fix for it?
Thanks!

Thanks for the report. This is fixed in v.0.4.1.


Incorrect behavior when creating class that extends base class with same name

When creating new class with ClassName, that extends base class with same name ClassName, I've got
ClassName extends ClassName
and thus I've got inheritance loop.
What expected:
ClassName extends base.path.ClassName
Also such checks needed when class renames.

Any news on progress?

Looks like fix exists, any news on applying it?

Waiting for me to check it. Sorry, everytime I want to look into it something important that takes all my time happens at work

Thanks for info! Will be waiting

Please review, when you have some time.
Thanks!

Please approve fix.
Thanks

Fixed


fix: use different cache dir as jiti v1

As the transform results are different, in cases where a project uses both Jiti v1 and v2 together, the cache will interfere each others

Both the extensions of entries (it is now .cjs or .mjs v1 was .js) are different and also jiti always has an integrity version.
Did you happen to have any issues?

Interesting, I wonder why I hit that. Let's close this for now and I will try to figure out an reproduction