Key error - 'mean_qscore'

Hello,
I'm trying to basecall some reads I generated with squigulator.
buttery-eel -i results/zymo-human/passed-1K.blow5 -o results/zymo-human/passed-1K-squigulator.fastq -x cuda:all -g resources/ont-guppy-6_5_7/bin/ --config dna_r10.4.1_e8.2_400bps_sup.cfg --port 8020 --slow5_threads 128
When trying to basecall with buttery-eel I get the following error:
An exception occurred: KeyError - 'mean_qscore'
The fastq file is empty.
The header of the fastq for the input of squigulator looked like this:
>81438ac8-1858-44d9-a8de-cec4e7e26adc_parent_read_id=81438ac8-1858-44d9-a8de-cec4e7e26adc_model_version_id=dna_r10.4.1_e8.2_400bps_sup-v4.1.0_mean_qscore=6
I removed the additional information such that the header looks like this:
>81438ac8-1858-44d9-a8de-cec4e7e26adc_parent_read_id=81438ac8-1858-44d9-a8de-cec4e7e26adc
However, I still get the same error.

Hey,
Could you please send me a blow5 file with a read that fails?
I'll try to reproduce the error.
Cheers,
James

Dear James,
thank you for your help. Enclosed is a blow5 file with 500 reads, which throws the error for me.
I did some small tests using smaller portions of the same slow5 file (using 'head -10'), which threw no exceptions.
passed-1K.zip
Best,
Denis

Hey Denis,
The issue seems to be the readID in your blow5 file.
for example:
S1_333!ebce92f7-c7e7-465d-b946-1af6b575c929_parent_read_id=ebce92f7-c7e7-465d-b946-1af6b575c929_model_version_id=dna_r10.4.1_e8.2_400bps_sup-v4.1.0_mean_qscore=2!0!13!+
If I cut this out and modify it to be a value UUID ebce92f7-c7e7-465d-b946-1af6b575c929
then the basecalling works fine.
The issue is the read is failing the UUID validation inside dorado/guppy, and that is sending the read back un-basecalled, and therefore now mean_qscore field is present. Given the API for dorado/guppy doesn't really give me many options to handle this, I just let it fail.
Anyway, if you fix your readIDs it should work as intended.
let me know how you get along.
James

Also just a note about your usage of --slow5_threads 128
It might be helpful to read this document on the thread model design for buttery-eel https://github.com/Psy-Fer/buttery-eel/blob/main/docs/thread_model.md
That should help understand how many --procs and --slow5_threads to use for best results.

Dear James,
thank you for your suggestions and help! I modified the read IDs on my slow5 file. However, I again encountered the 'mean_qscore' error at a later position. I used slow5tools skim function to have a look at the metadata. The read ID looks fine, I think the signal length (=50) of the responsible read was the source of the error.
Is there a minimum signal length for guppy/dorado? Would it be possible to just skip the read instead of failing the basecalling? Otherwise, I could also remove reads below a specific length.
Thanks again,
Denis

Hey,
Yea I think I need to re-add my skipped read methods. Previously guppy would just power through, but Dorado seems to be somewhat more sensitive to this kind of thing.
Give me a little time to build the fix and run it through some tests, as well as make a new test for this condition, but manually truncating a read.
I'll get back to you soon with a new release.
Cheers,
James

Hey Denis,
I have a branch called skipper that has the skip logic built into buttery-eel.
https://github.com/Psy-Fer/buttery-eel/tree/skipper
This will detect when dorado doesn't basecall a read, and just returns the read back.  It then adds this info to a queue.
 So this is showing that it couldn't find a sequence. (a bit more informative than the qscore). So you can see it wasn't basecalled. It also tells you which reads. And for me, which stage it failed in the process reads method. So if something else pops up, it is a lot easier for me to troubleshoot.
I need to do a fair bit of testing on this before I merge it cut a release. But for your data, this branch might be a good quick way for you to get your analysis done with this latest version of dorado while I do all the testing.
Let me know if you have any feedback or suggestions.
Cheers,
James

Also i have found out why these 3 are not called. Their signal lengths are less than the minimum threshold required by dorado (100).
these 3 have a signal length of:
95
38
61
So another strategy is to filter those first. I might also add a pre-filter to buttery-eel
James

Hey @Psy-Fer I think simply skipping them and adding to the skip_list is a good idea. This way, we at least know that some reads actually got skipped because they are short or for whatever reasons. We do not know if this is the only filtering strategy used in Dorado or if they will add things in future. If we simply skip and add to a list, at least it will be future-proof. But one downside is, that the user may get confused/worried when a few reads are skipped, which can be eradicated by documenting this or telling a brief potential reason in the warning.

Hey James,
thank you for your work! I think the skip list is a nice approach to track what went wrong. It works fine for my case. As said already said, a warning or documentation on the possible source of the error KeyError-'sequence' would be helpful at some point.

TODO: add skip list and update docs to explain what these do.
NOTE: Latest dorado-server, 7.4.12 changed the 100 signal limit, though unsure what they did.
From their release notes:
Very short reads under 100 raw samples no longer cause a crash in ont_basecall_client

This should now be fixed in https://github.com/Psy-Fer/buttery-eel/releases/tag/v0.5.0
cheers
James


VectorTileLayer render mode vector is rendered after the postrender event

Describe the bug
With render mode vector the postrender is firing too soon.
To Reproduce
In a layer swipe it is necessary to place the ctx.restore in a timeout as in https://codesandbox.io/s/layer-swipe-forked-fdtie7?file=/main.js  Remove the timeout and it does not work.
Expected behavior
Possibly related to #11606 but this example only styles polygons - there are no declutter items, so no obvious reason to render after the event

In your codesandbox, the blue layer is rendered before the green layer, because of the order in the map's layers array. So if register
blue.on('prerender', () => console.log('blue prerender'));
green.on('prerender', () => console.log('green prerender'));
blue.on('postrender', () => console.log('blue postrender'));
green.on('postrender', () => console.log('green postrender'));

the log will look like
blue prerender
blue postrender
green prerender
green postrender

which is totally expected.

Yes, that is expected and the CodeSandbox uses the same layer order as https://openlayers.org/en/latest/examples/layer-swipe.html  What is not expected is a timeout is needed after the final postrender event for this swipe to work when it is not needed in the main example, nor with a VectorTile layer using the default hybrid mode.

The problem is that for the VectorTileLayer renderer, the postRender method is called as part of the TileLayer renderer's renderFrame method, which is before vectors are rendered.
I'm going to create a pull request with a potential fix.

@ahocevar I believe I still see this problem in some recent adventures trying to use openlayers as serverside tile renderer.


Snapshot repo down?

Is the snapshot repo down?

Hey!
Maybe this PR might help you https://github.com/CatCoderr/ProtocolSidebar/pull/83?

Repository now back online. Thanks for reporting!


Added data requirements options to cql-options

Merging because this only impacts the elm-fhir tooling path


feat: allow toggling the inlay-hint mode

as discussed in #6
Checklist

[ ] Used only camelCase variable names.
[ ] If functionality is added or modified, also made respective changes to the
README.md (the .txt file is auto-generated and does not need to be modified).

cool! after the minor stuff is solved i'll add some docs then.

Looks good know, remove the draft status when you the PR is ready 👍

think it's good to go

Merged. Thanks for the PR!


Getting Started Doesn't Work

What are the imports for the getting started app?  Can't see how to import embeddedServer, or routing.  Gradle won't load bintray.com urls from intellij, but resolves on command line.

Indeed, the bintray repo is messed up :sob:

Getting started code works fine in my environment with Gradle.
My code is here: https://github.com/tokuhirom/ktor-getting-started/

@tokuhirom it would not if you clear your gradle cache (I recommend not doing it !)

What artifact exactly it is failing to download?

@cy6erGn0m ktor-core is failing for me

Do you have repositories specified in your build.gradle?
What ktor version do you use?
Is the following URL available? https://kotlin.bintray.com/ktor/org/jetbrains/ktor/ktor-core/0.3.2/
Does it fail today? (there were issues at bintray two days ago)

Great, it works ! Thank you 😌

I think I was also running into this:  https://youtrack.jetbrains.com/issue/IDEA-138029

Index building failure doesn't block project building, isn't it?
It's still not clear what are the symptoms, what exactly doesn't work

Gradle can't access dependencies and because of that I can't build the project.

Could you please provide error details? error messages?

I use a mutliproject build. I use ktor in a subproject. I had to add the repositories info in the subprojects section of the parent build.gradle to make it resolve the dependency. It works fine in a single project config. I wish we had stuck to maven...

Is this problem resolved in the end?


chore: fix Lean3-ism in SetLike docs

Although most of the docs were ported, we still used old function syntax and congr' instead of congr!. I tested the new version on Subgroup.

bors merge
I don't think we need to wait for CI here


bad request 400

This error happends when we have the oauth in a container tab and the website eq. reps in another container tab.
steps to reproduce:

open a site with i am in default container.
open a new tab and another site and set the oauth page default to another container.
when the first site redirects to 0auth it opens in the container set at step 2.
the 0auth windows pops up but the redirect doesnt work. and get a bad request 400 error.

cc  @hmitsch


Create-react-app typescript debugging partially broken with V1.41, V1.40 still works fine

VSCode Version: 1.41
OS Version: Windows 10 Pro x64 1903
Steps to Reproduce:
- Can't provide code that reproduces this, a trivially small 'hello world' app seems to work, but in our closed source code, it happens all the time.
Does this issue occur when all extensions are disabled?: Yes
Description
We have a large SPA that uses the latest version of react-scripts (3.3.0) and typescript (3.7.4)
Debugging with vscode 1.41 became very difficult, as if the source maps are not recognized correctly, the debugging cursor jumps to the strangest locations. With V1.40, this works fine.
I tried reverting to older versions of react-scripts and typescript, but that didn't seem to help
So currently we disabled vscode updates and continue working with 1.40, but since I can't find any other issue related to this, I felt the need to report this.

We still have the same issue with 1.42, going to try out 1.43

We since have a new debugger, please let us know if you're still running into problems, and if so open an issue on that repo.


Added paramaters exclude and only to form.populate_obj

Duplicate of https://github.com/wtforms/wtforms/pull/159


Allow configurable download URL

This allows for local mirroring, since upstream removes versions from availability.

Nice change!  Can you also update the README to show the new attribute?  Then happy to merge.

Done. 😄

👍


refactor: remove substrait ser/de for region query in standalone

I hereby agree to the terms of the GreptimeDB CLA.
Refer to a related PR or issue link (optional)
What's changed and what's your intention?
close #3520
This PR makes the logical plan in region query request not always be serialized to and deserialized from substrait bytes, which is not necessary in standalone mode.
Checklist

[ ]  I have written the necessary rustdoc comments.
[ ]  I have added the necessary unit tests and integration tests.
[x]  This PR does not require documentation updates.

@waynexia Please take a look.

I'm going to look into this after v0.8 release.

@waynexia PTAL


Fix typo in renamed function SR-5015

The NSStringAPI was recommending a rename to a function that doesn't exist. Corrected it to the right one.

Resolves SR-5015.

See also https://github.com/apple/swift-corelibs-foundation/pull/1014 for the fix in swift-corelibs-foundation

@swift-ci please smoke test

Thanks!


Link target for linux agent goes to windows agent

The link for "Azure Linux Agent User Guide" actually goes to the Windows agent details (https://docs.microsoft.com/en-us/azure/virtual-machines/windows/agent-user-guide)- needs correcting to https://docs.microsoft.com/en-us/azure/virtual-machines/linux/agent-user-guide or similar

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: f7792d5a-de76-c48a-0c8d-46b3e918a503
Version Independent ID: 23b37b12-4a16-d108-2705-2d96ceb484c8
Content
Content Source
Service: virtual-machines-linux

@liquidblack Thanks for the feedback. I assigned the case to the author for investigation.

#please-close merged


command-line window and :au WinNew * smile

Describe the bug
After smile is run from within WinNew autocmd upon opening the command-line window, closing it results in report of SIGSEGV and vim going to 100% CPU.
To Reproduce

Open vim in a terminal small enough to not accomodate the full :smile output
Type :au WinNew * smile
Type q: or some other way of opening command line window
Press q to dismiss the smile
Type for example :q, or run a command in the command-line window; anything to dismiss the command-line window

Expected behavior
More smile, less CPU
Environment (please complete the following information):

vim 8.2.800
macOS 10.15.4
macOS Terminal Version 2.10 (433)

Additional context
Just thought this one was maybe interesting. I was just idly messing around. I tried and it's just the command-line windows, but horizontal and vertical splits, quickfix, and location windows are all fine. I don't know how :smile is implemented or if this actually generalizes to other things that print lots of output and thus show the less/more style --more-- scrollable output.
I did notice that when dismissing the "more" smile output, when vim comes back up it is lacking colors. Using a bigger terminal or eg scrolling down to the end of the smile output until it is exhausted and closes without issuing q both avoid the issue, so it is something to do with doing the dismissal partway through the output.

backtrace
valgrind log
asan log

Interesting sequence of events.  Basic problem is that when opening the buffer for the cmdline window, there is no check that this fails.  Fixing that avoids the crash.
Still, interrupting the output at the More prompt should not have such a drastic effect, it aborts many things, such as splitting and closing windows.  Perhaps it's better to reset "got_int" after an autocommand when it was set because of a prompt.


fix(core): spread storage options

Closes #433
Types of changes

[x] Bug fix (a non-breaking change which fixes an issue)
[ ] New feature (a non-breaking change which adds functionality)
[x] Breaking change (fix or feature that would cause existing functionality to change)

Description

The Rate Limiter options need to be spread in order to support all the unstorage drivers.
Previously, only the options property could be provided to the underlying driver, because this driver has only one property with the name options.
With this PR, any property name can be provided under the options property.
Checklist:

[ ] My change requires a change to the documentation.
[ ] I have updated the documentation accordingly.
[x] I have added tests to cover my changes (if not applicable, please state why)

I'm not entirely sure it's a breaking change, it could actually be a bug fix.
It's very difficult to understand how nitro sets the unstorage options, and then how unstorage forwards these options to the underlying drivers. I'll do some local tests and will let you know.

I think it will be a breaking change purely because the interface for how certain feature will change. Wwith this change, users that uset the previous version of storage options, would have it not working anymore.
But no worries about that. This is not a huge breaking change as long as we provide release notes and migration guide.

I think it will be a breaking change purely because the interface for how certain feature will change. Wwith this change, users that uset the previous version of storage options, would have it not working anymore.
Yes that's right

@baroshem : Update after further review
The bug @numselli found out for the redis driver was also a problem for all other drivers. The options were actually never passed to the underlying driver.
I'm fixing the TypeScript definitions to clarify how the options must be passed and what values are available for each driver.
Marking as ready now

Thanks for finding it and fixing it @vejja 💚!
I can't wait for this release. it will be 🔥


fixed situation when multiple show/hide method calls overlap

Fixes the following situation:

show() is called
show() is called again within threshold of 500ms, timer is overwritten with another instance
hide() is called again within threshold of the same 500ms, so it cancels the function from the second setTimeout(). At this point hide() can be called any number of times, it doesn't matter
The timeout from the first step runs out, function is called and spinner is shown. If one doesn't call hide() after that spinner hangs forever

Thanks @diktar for your valuable support :+1: .

I called show(). Its take few seconds to show Spinner.
In my case. I called show() in one component

Called show() in Component1. Then called one HTTP service. I got Response before Spinner load.
I hide spinner after I get the response only. but spinner loaded after the hide() method only.
In that case, it's continuous spinner is showing


Fix the table comments in the DDL and Support column comments

Right now, all of the column comments are coming out as the table comments.
the below SQL  should get all the table and column comments :
SELECT c.oid::bigint                                                   AS table_id,
                  n.nspname                                                       AS schemaname,
                  c.relname                                                       AS tablename,
                  600250000                                                       AS seq,
                  ('COMMENT ON '::text + nvl2(cl.column_name, 'column '::text, 'table '::text) +
                   quote_ident(n.nspname::text) + '.'::text + quote_ident(c.relname::text) +
                   nvl2(cl.column_name, '.'::text + cl.column_name::text, ''::text) + ' IS \''::text +
                   quote_ident(des.description) + '\';'::text)::character varying AS ddl
           FROM pg_description des
                    JOIN pg_class c ON c.oid = des.objoid
                    JOIN pg_namespace n ON n.oid = c.relnamespace
                    LEFT JOIN information_schema."columns" cl
                              ON cl.ordinal_position::integer = des.objsubid AND cl.table_name::name = c.relname
           WHERE c.relkind = 'r'

resolved with the PR https://github.com/awslabs/amazon-redshift-utils/pull/542


Uncaught Exception

not sure what happened here but ok

Looks like the module was not built.

ok so, ive been trying to build the module but im not sure how
ive got this error now but its not much different.

ok so, ive been trying to build the module but not much has been changed.

make sure you have all 'node-gyp' dependencies installed (python 2.7!, ..) https://github.com/nodejs/node-gyp#installation
and try to use https://github.com/electron/electron-rebuild

I'm getting the same thing. Were you able to solve this?

If you're getting "Error: The specified module could not be found" try electron-rebuild:
npm install --save-dev electron-rebuild
.\node_modules\.bin\electron-rebuild.cmd


#242 Fix error in parsing string consisting only of numbers and multiple dots

As reported in #242, the deserialization process didn't support string tokens consisting only of numbers and multiple dots(.).
This PR has fixed the issue and the fix is tested by the added test cases.

Pull Request Checklist
Read the CONTRIBUTING.md file for detailed information.

[x] Changes are described in the pull request or in a referenced issue.
[x] The test suite compiles and runs without any error.
[x] The code coverage on your branch is 100%.
[x] The documentation is updated if you added/changed a feature.

Please don't

The C++11 support varies between different compilers and versions. Please note the list of supported compilers. Some compilers like GCC 4.7 (and earlier), Clang 3.3 (and earlier), or Microsoft Visual Studio 13.0 and earlier are known not to work due to missing or incomplete C++11 support. Please refrain from proposing changes that work around these compiler's limitations with #ifdefs or other means.
Please refrain from proposing changes that would break YAML specifications. If you propose a conformant extension of YAML to be supported by the library, please motivate this extension.
Please do not open pull requests that address multiple issues.

coverage: 100.0%. remained the same
when pulling f9c8a1fdf803e67a04ecb8063b7096776b847d57 on bugfix/242_parse_string_of_nums_and_multi_dots
into ca30ccf552e682f7b7f0c25fe0a143b2dbab06a8 on develop.


upgraded version to v1.0.2

issue: https://github.com/habitat-sh/core-plans/issues/4076
Signed-off-by: Nimit<EMAIL_ADDRESS>

Major version update, We are not bumping in refresh2022q2 refresh.


for loop

adding for loops
syntax could look something like:
let x = [1,2,3]
for i in x {
    dbg(i)
}

this can be implemented as an ast transform to a while loop


Bad server hang while shift crafting in actuator

Occultism ver 1.6.5
While on a server, when i shift click to craft a stack at a time, the entire server hangs until the craft is finished. Profile below, it is a 50 second profile and you can see that occultism took up 39 of those 50 seconds(i was shift crafting the whole time). Also video gif below of it in action. In the gif you can see that all the mobs stop moving(those mobs are constantly taking damage and moving) and ToP gives a "waiting on server" message while looking at blocks the entire time the craft is happening
profile:
https://spark.lucko.me/tj7RROTnxl
gif:
https://gyazo.com/e3658ac4453806cc022ad9f35133a78f

Further info for this, the hang only occurs when the actuator is not chunkloaded and u craft using the remote accessor

Further info on this, this issue only occurs when crafting using the remote accessor, when using the actual actuator block it crafts all in one tick instantly... if you use the actuator, it does that weird flashing in the gif above and the whole server hangs until it completes

That's a good starting point, will look into it!

The change in #284 did not fix the underlying issue, but now it seems to be resolved.
Code that prevented the underlying crafting event system from forcing a recipe lookup wasn't set up in the base class, and somehow I missed setting it up on the storage remote. Now it's in the base class and runs on all storage access methods.

thanks a bunch!!!


[Bug] pyspark code will get stuck in beeline

Code of Conduct

[X] I agree to follow this project's Code of Conduct

Search before asking

[X] I have searched in the issues and found no similar issues.

Describe the bug
simple example:
SET kyuubi.operation.language=python;
import pandas as pd
from pyspark.sql.functions import pandas_udf
spark.createDataFrame(pd.DataFrame([1, 2, 3], columns=["v"])).collect();

The pyspark task will get stuck.

thread dump in executor:

Affects Version(s)
master
Kyuubi Server Log Output
No response
Kyuubi Engine Log Output
No response
Kyuubi Server Configurations
No response
Kyuubi Engine Configurations
No response
Additional context
No response
Are you willing to submit PR?

[ ] Yes. I would be willing to submit a PR with guidance from the Kyuubi community to fix.
[ ] No. I cannot submit a PR at this time.

@cfmcgrady Sorry to bother you, I don't know if you have encountered this problem, but I think it is a spark problem.

@cfmcgrady Sorry to bother you, I don't know if you have encountered this problem, but I think it is a spark problem.

In which mode is Spark deployed, and could you kindly provide additional logs (driver/executor) for reference, if available?

@cfmcgrady Thank you for your help. I'm also working on this problem, try to change to a spark version. My spark version is apche spark-3.3.2-bin-hadoop2.
My spark driver log:
kyuubi-spark-sql-engine.txt
executor log:
executor.txt

do you correctly set up the Python environments on the executor?
FYI:
Python Package Management

https://spark.apache.org/docs/latest/api/python/user_guide/python_packaging.html
https://github.com/apache/kyuubi/pull/3899

@cfmcgrady Yeah.. I can submit the same pySpark job on yarn but will be stuck on kyuubi.
In addition, I found that kyuubi on spark 3.2 will not be stuck but will be stuck on spark-3.3.2-bin-hadoop2 or higher ( I also test on the latest spark master branch).
It will be stuck on org.apache.spark.api.python.PythonRunner#newReaderIterator
https://github.com/apache/spark/blob/5c94565e75cc32e552414f27da8082591121a86d/core/src/main/scala/org/apache/spark/api/python/PythonRunner.scala#L717-L753

@yabola it only happened on the YARN mode?

@cfmcgrady I test on yarn environment( but I only have one sandbox node , standalone ...) and local mode. spark local mode can work but yarn client mode will be stuck.

@cfmcgrady I know the reason, because I pip install pyspark before, resulting in the version of pyspark 3.2 in the python environment variable. But I use spark 3.3 and  the implementation of worker.py has been modified, causing the spark PythonRunner to fail to readint forever( like a deadlock, worker.py waits for PythonRunner to write data, and pythonrunner waits for worker.py to write data)

@cfmcgrady I know the reason for the blocking, because I pip install pyspark according to the document before, so I installed 3.2.2 pyspark into the python3 environment. when I use spark3.3, the environment variable transfer of kyuubi may be different from spark not the same, causing spark to use 3.2 pyspark ( reading and writing of worker.py and 3.3 worker.py are different, which leads to the interlocking of communication with spark worker jvm socket)


Easy palette switching

After working a bit on the ultimate timeline and creating the WK color spin. I got a slightly insane idea.
We could make the colors in the main theme themself inheritable from another separate css file that would contain nothing but the color palette. It might be an overload on how many styles you need to have active in stylus, but it would allow us to maintain multiple color pallets at once with a single main style sheet.
As things stand now, the WK color spin is already missing the fixes to the search bar and profile/setting pages.

Way ahead of you here.  :smile:
I'd already planned to create my own overrides of the top level props in a separate file.
It's still going to be a couple days at least before I can look at any of this. I'll be driving back up to my mom's tomorrow. Hope to have a little time before I fly home Thursday, but can't guarantee it.
I'm sure I'll like all your changes.

It occurs to me that we need a naming convention for any custom props used in the CSS rules themselves (not the top rule for :root). We need to make it obvious which props must be defined. I think we should avoid referring to any palette colors directly. Users can create whatever color palette they want as long as the mandatory props are defined (using those colors or anything else).
Eventually, once we are firm on a reasonable set of default colors, we should go through all the rules and add fall back defaults.

I mostly agree, but isn't this a solved issue? There already is a naming convention, namely --ED- + short description. Distinguishing if a variable is omittable or mandatory comes down to whether it's semantically or statically named(e.g. --ED-surface-1 vs --ED-red). This distinction is already explained within the comments of the :root if I'm not mistaken.
Some rules currently use static variables, which isn't optimal. I will take a look at them and try to change them to semantic ones. This might result in a few new variables.
When it comes to putting fallback colors in the rules, I don't currently see a need for it. There shouldn't be a situation, where the variable isn't defined, since it isn't reliant on any outside inheritance or definition. It could make sense if we decide to move the :root along with all the variable definitions outside the main file, but that's not what we are doing as of yet.

Yeah, I suppose you're right. The semantic/static distinction probably suffices.

Some rules currently use static variables, which isn't optimal.

This is mostly what I was getting at, but I think its important that the main file contains all the info for the official wanikani site.
I'm thinking it might be best if users never edit the main file directly. Rather than just editing the file to add their desired colors, they should create a separate css file that get's loaded after WKElementaryDark.css to load their desired colors. This is trivial if all the semantic variables use the fallback to load the default colors. If the user provides an override, that gets used, otherwise it uses the default. Most users just load one stylesheet. "Advanced" (or opinionated) users may load other stylesheets to change the defaults.
I changed the order of the :root rule so the (mandatory) semantic definitions came first, followed by any (optional) palette colors they might use. The palette colors aren't really necessary, and will almost certainly contain several unused colors, but they do make it easier to create a consistent, harmonious theme.
I'll make a stab at a new README this weekend for how to use the variables to create your own themes. I'll also include a section for script writers, recommending that they use --ED- semantic variable names in their own CSS so that they can automagically pick up ED colors if a custom stylesheet gets loaded.

The semantic variables could load user override variables (--USER or somesuch) if present, otherwise fall back to default values.

That's basically what I did with the ultimate timeline script. The whole thing uses its own prefix --ED-UT that inherits the values from the --ED variables if any are loaded, otherwise, it falls back to its hard-coded values.
I'm all for introducing a master override prefix, but it's worth considering where should the override happen. We could implement it into every single rule or just in the declaration of semantic --ED variables. I would lean towards doing it in the --ED var declaration as it's a simpler solution that would be more welcoming to any potential future changes.

I would lean towards doing it in the --ED var declaration as it's a simpler solution that would be more welcoming to any potential future changes

I concur. KISS principle always applies.
I should have some time tonight to take a stab at what I'm thinking for your review. I'll put it in a branch with a new README and possibly my own take at a color scheme (in a separate stylesheet) to make it easier to see how it's all intended to work.

I'm going to close this issue since it's implemented in PR #65. Let's track any required changes there.


Archived file size exceeds the specified size, archiveAboveSize

I have the setting below:
<target name="asyncFile" xsi:type="AsyncWrapper" queueLimit="10000" overflowAction="Block">
     <target xsi:type="File"
               fileName="/storage/sdcard0/com.my.app/Logs/${shortdate}.log"
               archiveFileName="/storage/sdcard0/com.my.app/Logs/archived.{#}.log"
               maxArchiveFiles="5"
               archiveDateFormat="yyyy-MM-dd"
               archiveAboveSize="1048576"
               archiveEvery="Day"
               archiveNumbering="DateAndSequence"
               concurrentWrites="true"
               keepFileOpen="false">
       <layout xsi:type="JsonLayout" includeAllProperties="true" excludeProperties="Comma-separated list (string)">
         <attribute name="time" layout="${longdate}" />
         <attribute name="level" layout="${level:upperCase=true}"/>
         <attribute name="message" layout="${message}" />
         <attribute name="exception" layout="${exception}" />
         <attribute name="threadid" layout="${threadid}" />
       </layout>
     </target>
   </target>

Expected behaviours:
No more than 5 archived files are generated, and each has a maximum size of 1MB.
archived.1.log
archived.2.log
archived.3.log
archived.4.log
archived.5.log

Actual behaviours:
One archived file has more 40 MB
Any idea?

I have experienced this too and it's a major issue. I'm using version 4.5.8 on .net 4.6 and have planned to upgrade as an attempt to fix it.
@PingPongSet Which version are you running?

Please see this, it might fix it.

See also: https://stackoverflow.com/a/59658486/193178

See also: #3661 (Issue on Xamarin Android Platform)

I have experienced this too and it's a major issue. I'm using version 4.5.8 with .net 4.6 on Windows Server 2016 and have planned to upgrade as an attempt to fix it.
@PingPongSet Which version are you running?

Please see below, it might work.
https://stackoverflow.com/questions/59655035/archived-file-size-exceeds-the-specified-size-archiveabovesize-with-nlog/59658486#59658486


Log tracebacks for exceptions at error level.

Logging at debug level is not helpful, as we need to reproduce the
errors later to get the tracebacks. This makes the logs insufficient.

Coverage increased (+0.5%) to 88.417% when pulling 291de9018f8acbadebc5d9caebe76436f17e2521 on improvement/log-tracebacks into 8cd7783dee588b597fb9e544a5e39c6ef90f5f88 on master.


Fix leading Parameter Type In Docstring

Type of changes

[ ] Bug fix
[ ] New feature
[x] Documentation / docstrings
[ ] Tests
[ ] Other

Checklist

[ ] I've run the latest black with default args on new code.
[ ] I've updated CHANGELOG.md and CONTRIBUTORS.md where appropriate.
[ ] I've added tests for new code.
[x] I accept that @willmcgugan may be pedantic in the code review.

Description
Noticed on the docs that the leading parameter (available for the Table and Column objects), mention that this parameter is a bool type, although it appears to be an int type and has a default value of 0.
This PR fixes the docstrings to annotate this parameter with the correct int type.

thanks


ENH: support interpolation of complex-valued images

Reference issue

None
What does this implement/fix?

This PR allows interpolation of complex-valued images via separable application of interpolation to the real and imaginary components.  Although this is already relatively easy for end-users to do on their own, I think it is nice to provide built-in capability for this.
Additional information

As far as I can tell, ITK provides a class ComplexBSplineInterpolateImageFunction which functions similarly, calling BSplineInterpolateImageFunction on the real and imaginary components separately
Two-domains where complex-valued images or volumes are commonly encountered are magnetic resonance imaging (MRI) and synthetic-aperture radar (SAR) imaging.
The changes made to _get_output here overlap with those made in the related PR, gh-12725.

I have rebased. I did have to update a couple instances of RuntimeError to UserWarning because of a change in _get_output here. I had made this change mainly so that the default value of output=np.float64 for the interpolation functions would not raise an error if the input was complex-valued. Instead, a warning is raised that it the provided real dtype is being promoted to a complex dtype when allocating the output array.
As before, providing an real-valued output array for a complex-valued input is not allowed.
Thank you to all of the reviewers of these recent ndimage PRs! I am very happy to have all of these in SciPy.

Complex interpolation isn't well defined, but this is a pretty common method, so I think it's fine (and a good feature) to have it as the default. I looked for a good reference to refer to in the docstring, but couldn't find one. Do you happen to have one, Greg? Either way, the PR looks goos to me.

I read through the code changes as well and seems solid from a mechanical/non-expert standpoint. Any modifications to old unit tests make sense, and these are mostly just expansions in testing to probe the new dtype support.
CI is green apart from the known issue with NumPy pre-release wheels (unrelated). Also, there is core developer/domain expert approval, so in it goes, thanks all.


Refactor client side

This file is taken from the example application provided in impress (original file), why don't you first update it there?

Because we need publish this web site immediately

Landed in 35ae001


Write documentation for doing local testing

Something like:

build and push the images with mage
helm install into your cluster
use k9s and hey to do load testing

Put this into contributing.md probably

@Ritikaa96 nobody is working on it as far as I know, so please go ahead if you'd like. Ideally, they would walk a reader through how to set up one, two or all three of the components (as appropriate) to run successfully outside of a cluster.

Hi @arschles , I have added the documentation in here. Please have a look and let me know if there is anything to change.

Just a gentle reminder @arschles @tomkerkhove PTAL at this:

Hi @arschles , I have added the documentation in here. Please have a look and let me know if there is anything to change or I'll raise a PR as soon as I get your go-ahead.

I think that's a good start, thank you! Any comments from your side @asw101?

@tomkerkhove should i raise a PR then? @asw101 @arschles PTAL

Certainly, thank you!


Different google maps api key for each flavor build

sorry if this is not the right place to ask this, but as i understand from google_maps_flutter docs we need to declare google maps api key inside AppDelegate.swift
GMSServices.provideAPIKey("YOUR KEY HERE")
is there a way to use different api key for each flavor build? like for example different api key for dev and production

Hi @brizaldi
You can achieve in Android flavors like this
This platform is not meant for assistance on personal code.
Please see https://flutter.dev/community for resources and asking questions like this,
you may also get some help if you post it on Stack Overflow and if you need help with your code, please see https://www.reddit.com/r/flutterhelp/
Closing, as this isn't an issue with Flutter itself. If you disagree, please write in the comments and I will reopen it.
Thank you


autoencoders update

Before submitting

[ ] Was this discussed/approved via a Github issue? (no need for typos and docs improvements)
[ ] Did you read the contributor guideline, Pull Request section?
[ ] Did you make sure to update the docs?
[ ] Did you write any new necessary tests?

What does this PR do?
Updated docs with reconstructions.
PR review
Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.
Did you have fun?
Make sure you had fun coding 🙃

@ananyahjha93 the low coverage is because not all tests have finished yet...


Add command to pull staged contract status

Issue
Currently, flow-c1 migrate is-validated pulls the contract status from the on-chain repository.  However, this is not currently being populated and there are no existing plans to do so, so we need to determine a workaround
Suggested solution
Add cli command to allow user to pull current status from the published GitHub report on https://github.com/onflow/cadence repository, as this is where the reports are currently being published

closed by https://github.com/onflow/flow-cli/pull/1529


rbd: unmap rbd image if the mounting fails

There is a bug in the current code where the device path is always empty and the rbd image unmap never happens if node plugin fails to mount the rbd image to the staging path.
This is a fix to unmap the rbd image if some issue occurs after the rbd image is mapped.
Signed-off-by: Madhu Rajanna<EMAIL_ADDRESS>Backport of https://github.com/ceph/ceph-csi/pull/1078

Merging this one as CI is passed


Add ZFS snapshot support to lxd-migrate

I used lxd-migrate for the first time yesterday. It is definitely easier to use and an improvement over lxdp2c or having to use tarballs via lxc image but it would be better if it could migrate ZFS snapshots too.
I backup my ZFS based containers using syncoid so that all of the snapshots are retained. lxd-migrate currently uses rsync which is blind to ZFS snapshots so I'd like to see lxd-migrate gain support for using syncoid (which is part of the sanoid package in Ubuntu) instead of rsync when you are migrating ZFS datasets or maybe it could replicate the snapshot syncing abilities of syncoid to avoid the extra dependency.

I don't think we'll be doing that. Adding support for full ZFS based migration to lxd-migrate would be a LOT of work as we would need to do far more than just shelling out to ZFS but also need to handle the full ZFS based migration protocol which LXD uses internally, including feature negotiation and fallback to rsync.
This doesn't really make sense given that lxd-migrate is a tool meant for lift and shift.
So it's goal in life is to take an existing physical or virtual server and convert that to a LXD container or VM.
It's not meant to be used to restore backups made by a third party tool.

In your case, given what you're working with, I suspect your best bet would be to generate a LXD backup tarball from what you have.
You'd need to extract the existing backup.yaml from the instance on ZFS, generate a backup.yaml and then do a zfs send/zfs receive of each snapshot as their own binary files. Put that in a tarball and you can feed it to lxc import for restoration.
The easiest to get an idea of what you need to generate would be to do:

lxc init images:alpine/edge a1
lxc snapshot a1
lxc snapshot a1
lxc export a1 --optimized-storage

And look at the resulting tarball to see the structure LXD expects.


Sort and Search Labeled Articles

Sort articles so we can figure out which ones still haven't been classified or that are "disputed"

Allow a user to browse the corpus in a meaningful way. We can add a full-text search functionality, if we have the time; but also simple order by created date (desc) and sorting as follows:

[ ] no clear annotator agreement (e.g. simple vs. super majority)
[ ] no annotations yet
[ ] most annotations
[ ] most annotations for label
[ ] most # of words
[ ] most # of vocabulary


Internal client error. No creators were authorized during login

No idea why this is happening, it starts doing this every time I try to log back into ROBLOX,
Tried reinstalling it but it failed to fix the problem but here's the console.
Traceback (most recent call last):
File "C:\Users\user\AppData\Roaming\Blender Foundation\Blender\3.2\scripts\addons\roblox-blender-plugin\lib\oauth2_login_operators.py", line 69, in on_login_complete
task.result()
File "C:\Users\user\AppData\Roaming\Blender Foundation\Blender\3.2\scripts\addons\roblox-blender-plugin\lib\oauth2_client.py", line 192, in login
raise LoginError from handler.request_handled_event.exception
roblox-blender-plugin.lib.oauth2_client.LoginError

This happens if you go through the process of logging in with Roblox without selecting/authorizing any "creators" during login. You should select at least either your own account as an authorized creator or a group you have permissions to upload to.


Please, Reopen #10662

Windows Version
Any windows 11
WSL Version
2.0.X.0
Are you using WSL 1 or WSL 2?

[X] WSL 2
[ ] WSL 1

Kernel Version
No response
Distro Version
No response
Other Software
No response
Repro Steps
Reopen bug. #10662. Distro maintainers suggest to come back
ONLY OCCURS en wsl 2.0.X.0
Expected Behavior
Let it work as in previous versions
Actual Behavior
Still crashing in versions 2.0.X.0. Please, Reopen #10662
Diagnostic Logs
No response

The right place for this issue would be here. Once the distro maintainers looked at it we can continue the discussion on #10662 and it can be reopened if needed.


[feature] Update Add-on User Settings UI

Continuation of https://github.com/CenterForOpenScience/osf.io/pull/2414

Once this is up to date with develop, I will continue with the next pass of review.

@sloria, this is up to date and ready for another pass! :checkered_flag:

The logo images are much larger than they need to be. Can you resize and compress them?

There are FOUCs of the knockout-punches code happening:

The unstyled text should be hidden, either by using scripted or using a regular data-bind="text: ...".

I mentioned to @samanehsan earlier that Dataverse "Connect an account" is different than the others.

Additionally, there seems to be font differences between the name of each addon and the "Connect Account"....
See GithHub, Google Drive and Mendeley rows.

The orange button doesn't seem right here:

We don't have any other orange buttons on the site. Also, the horizontal rules around the button are misleading (horizontal rules delineate sections).
Why not use the same red links that are used for the addons?

Pass finished.

@GaryKriebel Saman has already addressed the Dataverse language in https://github.com/samanehsan/osf.io/commit/c468dfe151e70d1688a3e7a2221dd9790281ce76. I'm not seeing the font issue; do you mean that the font for the addon names is different "Connect Account"? This is expected; we are using Bootstrap's defaults for headings and links.

That said, I'm not sure the add-on names need to be headings; they take up a lot of space, which may become an issue if/when we add more add-ons.

Actually, I meant the addon names with respect to themselves (which upon second look seem to be fine) and the "Connect Account" with respect to themselves.
The bottom two instances look bigger than the 3rd & 4th from the bottom.

OK, thanks for the clarification @GaryKriebel . @samanehsan Can you take a look at the font sizes there? Also, the casing needs to be consistent; the "a" should be capitalized for all items.

Goodness... I didn't even notice the "a" .... it was a remnant from the original Dataverse wording change

Dataverse isn't currently working in this PR. The /settings/dataverse/ endpoint is returning a 400 response. I think this is caused by the must_have_addon decorator. The view will need to be updated.

Once the above issues are addressed, I will do another pass.

@sloria, with the FOUC for the Mendeley and Zotero, when I use the scripted tag nothing loads and using data-bind doesn't solve the problem either. Maybe it has something to do with the fact that some of the observables are in deeply nested view models. Is there anything else I can try?

Also, how can I easily compress PNG files? I made the addon images smaller, but I have yet to compress them.

Besides that, I've addressed all other comments! :sunflower:

@samanehsan It's fine to have a minor FOUC as long as the KO punches syntax isn't showing. Using data-bind should address that problem.
ImageOptim is a simple program for compressing images.

This is ready for another pass @sloria! :watermelon:

Once, https://github.com/CenterForOpenScience/osf.io/pull/3409#discussion_r34042687 is addressed, this should be good to merge.

Just made that change @sloria. Here's what it looks like now:

@samanehsan Can you make the position and casing for Mendeley and Dataverse consistent with the other addons?

@sloria, I'm not sure how that would work since users can authorize multiple Dataverses and Mendeley accounts. E.g:

Ah ok, that's right. You can keep the casing as is.

Ok, in that case I think this should be good to go :sunny:

Discussed in brief with @GaryKriebel : One side effect of this PR is that it introduces some inconsistency with the project settings UI.
As a follow-up to this PR, the project settings UI should also be updated. Can we plan/assign this, @lbanner @GaryKriebel ?
For now, just adding the new logo icons to the project settings would go a long way; @samanehsan would these be quick to add to the project settings?

Yeah -- that followup is next on list. At this point, I'd think it could be @samanehsan or @samchrisinger, but @samchrisinger needs to get thru Pre-Reg prize.

@sloria, the icons should be a quick addition

@samanehsan Great. Once those are added an @lbanner and @GaryKriebel give the "go" after their functional review, this can be merged. :ear_of_rice:

OK ... @samanehsan  -- Those will be added as first step in bring up-to-date Project Settings, correct?

I thought @sloria was suggesting that I add those in now to give some consistency.

That's correct - just clarifying that we are talking Project Settings, Add-ons.

@sloria, done adding in those icons. I also added one for external links:

Thanks. We use that icon for project links; the "external link" icon might be more appropriate.

What's the "external link" icon?

https://fortawesome.github.io/Font-Awesome/icon/external-link/

Oh, okay! I just made that change @sloria:

Thanks!
Merged into release/0.43.0.


Potential Bug: Null Validator Address Array

Latest tests are alerting with the following
08:12:46  Completed with 1 error and 2 warnings:
08:12:46
08:12:46  Failure in test not_null_core__fact_blocks_VALIDATOR_ADDRESS_ARRAY (models/core/core__fact_blocks.yml)
08:12:46    Got 1176 results, configured to fail if != 0
08:12:46
08:12:46    compiled SQL at target/compiled/terra/models/core/core__fact_blocks.yml/not_null_core__fact_blocks_VALIDATOR_ADDRESS_ARRAY.sql
08:12:46
08:12:46    See test failures:
  ---------------------------------------------------------------------
  select * from TERRA.not_null_core.fact_blocks_VALIDATOR_ADDRESS_ARRAY
  ---------------------------------------------------------------------

Checking this one out.

https://flipsidecrypto.xyz/Antonidas/q/2023-03-08-11-57-pm-rhStau

Problem: select * from "TERRA_DEV"."BRONZE"."BLOCKS" where  block_id = '2918084'
Issue is-> bronze.blocks is height 2918084, but the header :last_commit :height array is 2918083.

Only the next block has the infomation of the current block

The validator address array is null because at the point of dbt_cloud executed, 2918084 is the latest block, thus block 2918085 does not exists and thus there is no information filled in for the VALIDATOR_ADDRESS_ARRAY.
A re-design of the silvers_blocks will be required to solve this problem.


A few updates to stubs (fix #856)

Contains a few updates for the stubs. Also introduces PostLex as an actual subclassable Runtime class to reduce confusion.

Thanks!


IAsyncOperation no longer Send for some T as of v0.29

Just updated to v0.29, tried to compile https://github.com/deviceplug/btleplug with no code changes otherwise, and I'm getting a bunch of errors about IAsyncOperations no longer working due to not implementing Send. v0.28 worked fine.
error: future cannot be sent between threads safely
  --> src\winrtble\manager.rs:34:54
   |
34 |       async fn adapters(&self) -> Result<Vec<Adapter>> {
   |  ______________________________________________________^
35 | |         let adapter_result = BluetoothAdapter::GetDefaultAsync().unwrap().await;
36 | |         let adapter = adapter_result.unwrap();
37 | |         info!("Adapter ID: {:?}", adapter.DeviceId());
...  |
48 | |         return Ok(result);
49 | |     }
   | |_____^ future created by async block is not `Send`
   |
   = help: within `impl futures::Future`, the trait `std::marker::Send` is not implemented for `NonNull<c_void>`
note: future is not `Send` as it awaits another future which is not `Send`
  --> src\winrtble\manager.rs:35:30
   |
35 |         let adapter_result = BluetoothAdapter::GetDefaultAsync().unwrap().await;
   |                              ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ await occurs here on type `IAsyncOperation<BluetoothAdapter>`, which is not `Send`
   = note: required for the cast to the object type `dyn futures::Future<Output = std::result::Result<Vec<Adapter>, Error>> + std::marker::Send`

error: future cannot be sent between threads safely
   --> src\winrtble\peripheral.rs:355:43
    |
355 |       async fn connect(&self) -> Result<()> {
    |  ___________________________________________^
356 | |         let shared_clone = Arc::downgrade(&self.shared);
357 | |         let adapter_clone = self.shared.adapter.clone();
358 | |         let address = self.shared.address;
...   |
380 | |         Ok(())
381 | |     }
    | |_____^ future created by async block is not `Send`
    |
    = help: within `impl futures::Future`, the trait `std::marker::Send` is not implemented for `NonNull<c_void>`
note: future is not `Send` as it awaits another future which is not `Send`
   --> src\winrtble\ble\device.rs:71:30
    |
71  |         let service_result = async_op.await.map_err(winrt_error)?;
    |                              ^^^^^^^^ await occurs here on type `IAsyncOperation<GattDeviceServicesResult>`, which is not `Send`
    = note: required for the cast to the object type `dyn futures::Future<Output = std::result::Result<(), Error>> + std::marker::Send`

error: future cannot be sent between threads safely
   --> src\winrtble\peripheral.rs:392:53
    |
392 |       async fn discover_services(&self) -> Result<()> {
    |  _____________________________________________________^
393 | |         let device = self.shared.device.lock().await;
394 | |         if let Some(ref device) = *device {
395 | |             let gatt_services = device.discover_services().await?;
...   |
422 | |         Err(Error::NotConnected)
423 | |     }
    | |_____^ future created by async block is not `Send`
    |
    = help: within `impl futures::Future`, the trait `std::marker::Send` is not implemented for `NonNull<c_void>`
note: future is not `Send` as it awaits another future which is not `Send`
   --> src\winrtble\ble\device.rs:71:30
    |
71  |         let service_result = async_op.await.map_err(winrt_error)?;
    |                              ^^^^^^^^ await occurs here on type `IAsyncOperation<GattDeviceServicesResult>`, which is not `Send`
    = note: required for the cast to the object type `dyn futures::Future<Output = std::result::Result<(), Error>> + std::marker::Send`

I thought there were tests for this - will get it fixed asap.

Sorry for the delay! This fix is included with #1423


[WIP] Adding function to render AWS Ec2 Types based on selection

fixed this in https://github.com/zscaler/terraform-aws-cloud-connector-modules/pull/92. was already tracking the problem in BUG-176102


fix(gitreceive): change target name to Workflow

Current coverage is 46.81% (diff: 0.00%)

Merging #408 into master will increase coverage by 0.18%

@@             master       #408   diff @@
==========================================
  Files            26         26
  Lines          1098       1098
  Methods           0          0
  Messages          0          0
  Branches          0          0
==========================================
+ Hits            512        514     +2
+ Misses          555        553     -2
  Partials         31         31

Powered by Codecov. Last update 0690f89...e791c1d

Everything's green except for codecov all because I changed one name.


Add support for postcss-js

Awesome! But can you aslo provide some test for this case? You can look to other test as a sample.

Done and rebased ;-)

Sorry, that I add more and more sub tasks :). But it is really awesome feature :).
Can you asl add some docs (my English is bad) about it. I think many users can miss this awesome way to use PostCSS.

Done.

(my English is bad)

Well, I am French, so mine too...

:D

For the record, I am using postcss-js because I am working on an implementation of material design with React.
I am not a big fan of inline styles and all their cons (media-query, pseudo-element, prefix, etc). Of course many modules solve them (or try to) but the performance are not good enough for me (and my company). Check Material UI on mobile...
And for theming, I have been trying to achieve my goal with css-modules-values, postcss-functions, postcss-simple-vars, etc... but none was a good fit.
So after weeks of trying different approach, I think having all power of JS with postcss-js and then css-modules for composability and pattern is a real win.

Yeap. There was Styling project. But seems like it doesn’t need anymore.

Indeed, I am glad I finally found my dream stack.

I will release version right after move project to AVA

Actually I just realised that in the readme the reference to postcssImport in the postcss-js example is useless. Damn copy/paste.

fixed :)

Released in 0.8


Make the symbols keyboard accessible

Many people prefer to use a keyboard or cannot user a pointer device, like a mouse or trackpad. This PR makes the symbols keyboard focusable, and invokable via the "Enter" or "Space" key.
I'll look into supporting arrow keys in the next PR.

Hey @bbeaudry, sorry about the merge conflicts here. I'm keen to see how this would look with the latest changes, are you able to update this PR? 🙏

I got it -- one sec!  Will have to do a new PR though.

@qwell let's give @bbeaudry a shot at this. There's no rush 🙂

Updated the PR. Ready for review!

Just gave it a whirl myself, works great! Thank you @bbeaudry.


v1.3.0 demo images breaks M1 support that existed with v1.2.1 images

I have been working with the OTel demo helm chart on 0.15.3 (1.2.1 images) on my M1 mac. Today we upgraded to 0.18.0 (1.3.0 images) and I am no longer able to pull/run any of the images.
Previously using 1.2.1 images, I had a couple services (featureflag, checkoutservice, ...) that were unable to run, but now almost all of the services fail to pull the images.
I understand that there is ongoing work to provide full support for arm64 builds, but I find it strange that an upgrade like this would totally break support.
When looking through tags, it seems like all the 1.3.0 images have an OS/Arch tab - but the second architecture is listed as unknown/unknown. I am unable to docker pull ... either of these images on my M1.

On the other hand, none of the 1.2.1 images have a second tab for a different architecture, but I am able to pull and run almost all of them.

I am hoping this fix should be as simple as updating a config in the image build process, but wanted to bring this to the teams attention if this was not expected behavior.

@eskirk Thanks for raising this issue. I had similar problems this morning trying to install the 0.18.0 chart on my M1. I think the issue is with the images which is a demo repo issue.
@puckpuck can you transfer the issue to the demo repo?


build(webui): Upgrade Next to v14

Summary
This PR upgrades promptfoo from Next.js version 13.4.13 to 14.2.4.
Motivation

Whenever somebody npm installs promptfoo, they are warned of critical security vulnerabilities related to Next 13.

These vulnerabilities limit the adoptability of promptfoo by enterprises
This also makes a bad first impression

Features

Adds the ability to run the Express server for local development of the Next app without invoking promptfoo view (which is designed to serve the statically compiled Next app).  See fix no. 1 for rationale.

Changes

Disables eslint from raising an unnecessary @next/next/no-img-element warning regarding ResultsTable's use of img tags (instead of Next Image) within nodes.

Fixes

The Next API routes could not be compiled for static export so I migrates the Next application to exclusively use the Express server.

This also fixes running evals during local development (i.e. running the app w/ next dev w/o running promptfoo view) and removes a non-trivial amount of duplicated API logic code.

I didn't realize there was already a next14 branch when I opened this.  Because it was the head and it was stale, this is very far behind main.  Therefore, I'm going to close this PR and open a new, properly branched version.

https://github.com/promptfoo/promptfoo/pull/999


config.js file info

File path and file name

Thanks for the PR.  However, what does doing this enable?  Why just this file?

It shows what file is being edited.

@LavaAdventures There are many other ways to find that other than adding it to every file in this repository. Some files do not have header contents either. When would this be useful?

@Chuxel, don't waste your time, it's Shitoberfest's spammer. Just close this PR.


Make modifications to support invoking CodeBuild via Lambda wrapper

Issue #, if available:
Description of changes:
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
Check any applicable:

[ ] Were any files moved? Moving files changes their URL, which breaks all hyperlinks to the files.

Sorry, meant to open this PR on a fork!


Add remove account ability

Users should be able to unregister/delete their account from the ARENA.
Downstream short term this means delete account will also have to delete their namepspaced scenes.

added in #47


image converting script

for each image:

make square (optional flag, for converting images that are roughly squares to be exactly squares)
convert to 300x300 (can be a default for icons, optional is larger)
compress (happens automatically)

convert -resize 300x img_in.png img_out.png
this will convert to a width of 300px (if you want a height of 300px, you say x300 instead)
the making square thing is more subtle, so i'm just gonna not do that


typo Remove docker-doris in developer

Problem Summary:
Delete docker-doris in developer because it is outdated and duplicates compilation.md in the documentation.
Checklist(Required)

Does it affect the original behavior: (No)
Has unit tests been added: (No)
Has document been added or modified: (Yes)
Does it need to update dependencies: (No)
Are there any changes that cannot be rolled back: (No)

There may be some minor issues with direct deletion, and finally decided to delete some outdated content.


trying MSVC flags

trying this https://devblogs.microsoft.com/cppblog/recommendations-to-speed-c-builds-in-visual-studio/

all of the links:

https://cmake.org/pipermail/cmake/2019-March/069195.html
https://cmake.org/cmake/help/latest/variable/CMAKE_CONFIGURATION_TYPES.html#variable:CMAKE_CONFIGURATION_TYPE
https://community.spiceworks.com/topic/549614-question-about-syntax
https://devblogs.microsoft.com/scripting/list-files-in-folders-and-subfolders-with-powershell/
https://www.makeuseof.com/tag/check-windows-experience-score-windows-10/
https://en.m.wikipedia.org/wiki/Windows_System_Assessment_Tool
https://deploywindows.com/2013/03/06/use-winsat-and-determine-how-fast-my-hard-disk-is/

The code I had been using in .ci/test_r_package_windows.ps1 to move stuff to C:\. Putting in a comment here so it's more easily accessible if I want to come back to it.
# in the virtual machine we get from Azure DevOps, the write throughput of
# D:\ (the default location builds run from) is 10x lower than the write throughput
# of C:\. This matters for very write-heavy steps like generating a build makefile
# with `cmake -G"Visual Studio..."`.
#
# To check the disk performance, run the following
#
#     Get-CimInstance Win32_PerfRawData_PerfDisk_LogicalDisk
#     Get-CimInstance Win32_PerfRawData_PerfDisk_PhysicalDisk
#
# More details: https://github.com/microsoft/LightGBM/pull/2965#issuecomment-624421092
#
if ($env:AZURE -eq "true") {
  Write-Output "Moving files to C:\ and changing BUILD_SOURCESDIRECTORY"
  $env:NEW_BUILD_DIRECTORY = "C:\LightGBM"
  Copy-Item -Path "$env:BUILD_SOURCESDIRECTORY\compute" -Destination "$env:NEW_BUILD_DIRECTORY\compute" -Recurse
  Copy-Item -Path "$env:BUILD_SOURCESDIRECTORY\include" -Destination "$env:NEW_BUILD_DIRECTORY\include" -Recurse
  Copy-Item -Path "$env:BUILD_SOURCESDIRECTORY\R-package" -Destination "$env:NEW_BUILD_DIRECTORY\R-package" -Recurse
  Copy-Item -Path "$env:BUILD_SOURCESDIRECTORY\src" -Destination "$env:NEW_BUILD_DIRECTORY\src" -Recurse
  Copy-Item -Path "$env:BUILD_SOURCESDIRECTORY\build_r.R" -Destination "$env:NEW_BUILD_DIRECTORY\build_r.R"
  Copy-Item -Path "$env:BUILD_SOURCESDIRECTORY\CMakeLists.txt" -Destination "$env:NEW_BUILD_DIRECTORY\CMakeLists.txt"
  $env:BUILD_SOURCESDIRECTORY = "$env:NEW_BUILD_DIRECTORY"
  Write-Output "new BUILD_SOURCESDIRECTORY: $env:BUILD_SOURCESDIRECTORY"
}


update  CASE REVIEW #1758722

@v-abiss : Thanks for your contribution! The author(s) have been notified to review your proposed change.

Getting some more reviewers

I'm moving this one to the private repo, @v-abiss I'll tag you in the new private PR. You should have access. Thank you.


typeit types the site name 3 times

I just migrated from loveit. I hadn't changed anything in themes/loveit but I do have a few simple overrides.
I have typeit enabled for the site name at the top.  typeit types the name of the site 3 times.
May be related to #213

Can you provide more information, maybe a demo site for easier debugging? Since TypeIt is clearly working correctly on the demo site, I cannot reproduce that on my side.

I deployed again with typeit enabled for the header name ([params.header.title] name) . I checked on windows firefox and android kiwi. It takes a few clicks around the site for it to appear.

Have you updated the theme to the latest commit? The theme.js  file on your site does not seem to contain that fix I create for #213

It actually seems to be adding one more every time you click something. Honestly it's hilarious to watch :)

Yes, because DoIt theme load new pages with PJAX loading (#78). The re-loading bug is caused by creating a new TypeIt instance while the old one is not destroyed. The latest commit should contain a fix preventing that from happening.

I was on the latest release. I cloned the code now and it's working properly. Thanks.!


Extent is Changing

The extent of the building feature class in production is changing and we do not know why.
Expected extent in srid 2263:
(913201.635195389,<PHONE_NUMBER>73469) to (1067367.17922589,<PHONE_NUMBER>53129)
First noticed: July 19th 2022.
Approximate extent (-139,000,000, -101,000,000) to (1,9700,000, 4,890,000)
Manually corrected July 26th 2022.

August 2 2022:
(-120039300, -96540300) to (1067367.17922589,<PHONE_NUMBER>53129)
This time the upper right bound has not changed.  And the lower left is nice round numbers.  Very interesting.

"For now I have a ArcPy script that runs nightly to loop through all data owner accounts and describe the feature classes.  If the extents are outside of a certain geographic area, I put that feature class in a list that I email to myself and the other SDE Administrator for correction when we arrive in the morning."
This is stockholm syndrome level work, amazing stuff.
https://community.esri.com/t5/data-management-questions/arcsde-databases-have-extent-randomly-change/td-p/536019

update sde.layers a
set
a.minx =<PHONE_NUMBER>95389
,a.miny =<PHONE_NUMBER>73469
,a.maxx = 1067367.17922589
,a.maxy =<PHONE_NUMBER>53129
where
a.table_name = 'BUILDING'
and a.owner = 'BLDG'
commit;

Tuesday August 16th evening QA report, same numbers as the prior event:
(-120039300, -96540300) to (1067367.17922589,<PHONE_NUMBER>53129)
Also we flagged doitt_id 1293260 for curves. Cluephone.

As a test I manually:

Created a curve in a development copy of the buildings
Reconciled and posted to the editing version
Ran the nightly maintenance script

This resulted in QA for the curve but no indication of the extent change.

Thursday, July 27, 2023 QA flagged for extent change.  Also a curve is present!
select minx, miny, maxx, maxy from
sde.layers a
where a.table_name = 'BUILDING'
and a.owner = 'BLDG'
MINX      |MINY     |MAXX            |MAXY
----------+---------+----------------+----------------
-120039300|-96540300|1067367.17922589|272669.070853129

Again 2/8/2024 after a curve.


[5.5] Mail::assertQueued() callback is missing mailable data

Laravel Version: 5.5 @ 3c888b6
PHP Version: 7.1.7-1+ubuntu16.04.1+deb.sury.org+1
Database Driver & Version: PDO with MySQL 5.7.19-0ubuntu<IP_ADDRESS>

Description:
I'm queuing a mailable (AuthTokenMail) with the following code where $token is a model:
use Illuminate\Support\Facades\Mail;
Mail::to($token->user->email)->queue(new AuthTokenMail($token));

While the mail is being sent in production, my test fails:
There was 1 failure:

1) Tests\Feature\AuthTest::testAuthTokenIsSent
The expected [App\Mail\AuthTokenMail] mailable was not queued.
Failed asserting that false is true.

/home/vagrant/Code/vendor/laravel/framework/src/Illuminate/Support/Testing/Fakes/MailFake.php:100
/home/vagrant/Code/vendor/laravel/framework/src/Illuminate/Support/Facades/Facade.php:221
/home/vagrant/Code/tests/Feature/AuthTest.php:28

use Illuminate\Support\Facades\Mail;
public function testAuthTokenIsSent()
{
        Mail::fake();

        $user = factory(User::class)->create();

        $response = $this->get('/auth');

        $response->assertSeeText('Mail queued');

        Mail::assertQueued(AuthTokenMail::class, function ($mail) use ($user) {
            return $mail->hasTo($user->email) && isset($mail->authToken);
        });
}

When I dd() the $mail variable inside the callback it has the authToken property populated - but all other data are empty. Especially to is an empty array which makes the hasTo() method return false and the test ultimately fail.
This test worked fine when I was using assertSent before the PR #20454
After the PR even assertSent does not work anymore.
Steps To Reproduce:

Create a Mailable:

<?php

namespace App\Mail;

use Illuminate\Bus\Queueable;
use Illuminate\Mail\Mailable;
use Illuminate\Queue\SerializesModels;
use App\AuthToken;

class AuthTokenMail extends Mailable
{
    use Queueable, SerializesModels;

    /**
     * Auth token.
     *
     * @var AuthToken
     */
    public $authToken;

    /**
     * Create a new message instance.
     *
     * @param AuthToken $authToken
     */
    public function __construct(AuthToken $authToken)
    {
        $this->authToken = $authToken;
    }

    /**
     * Build the message.
     *
     * @return $this
     */
    public function build()
    {
        $text = action('AuthController@authWithToken', $this->authToken->token);

        return $this->view('emails.plain', [
            'text' => $text,
        ])->subject('AuthToken');
    }
}

Create a controller method which queues the mailable
Create a test which hits the controller route / method which queues the mail
Use Mail::assertQueued and a callback with hasTo() to verify the receiver of the mail

fixed via PR .. thanks :)


canvas error when running happo-ci

When I run the happo-ci command, I get this error:
<EMAIL_ADDRESS>/home/circleci/project/node_modules/canvas/lib/context2d.js:13
bindings.CanvasRenderingContext2dInit(DOMMatrix, parseFont)
         ^

TypeError: bindings.CanvasRenderingContext2dInit is not a function
    at Object.<anonymous> (/home/circleci/project/node_modules/canvas/lib/context2d.js:13:10)
    at Module._compile (internal/modules/cjs/loader.js:776:30)
    at Object.Module._extensions..js (internal/modules/cjs/loader.js:787:10)
    at Module.load (internal/modules/cjs/loader.js:653:32)
    at tryModuleLoad (internal/modules/cjs/loader.js:593:12)
    at Function.Module._load (internal/modules/cjs/loader.js:585:3)
    at Module.require (internal/modules/cjs/loader.js:690:17)
    at require (internal/modules/cjs/helpers.js:25:18)
    at Object.<anonymous> (/home/circleci/project/node_modules/canvas/lib/canvas.js:11:19)
    at Module._compile (internal/modules/cjs/loader.js:776:30)
error Command failed with exit code 1.

here are my package versions:
node 10.15.3
"canvas": "^2.5.0"
"happo.io": "^3.17.0",

Interesting, I haven't seen this before. Is there a longer console log you could share? If you're not comfortable sharing the entire CircleCI job log here you can send it in an email to<EMAIL_ADDRESS>I'm mainly thinking there could be something interesting in the yarn install/npm install section about failing to get (or build) native bindings for the canvas library (similar to what this issue is describing, or what this rage tweet is hinting at 🙂).
I made an attempt at reproducing the error in one of my own projects (which uses CircleCI), but it didn't throw the same error. Here's the commit/diff I applied:
commit 64f282c42862830303b0e0a0f6d73f557bec8772
Author: Henric Trotzig<EMAIL_ADDRESS>Date:   Wed Jun 5 09:36:58 2019 +0200

    WIP: add canvas

diff --git a/package.json b/package.json
index 7c80759..ea336f3 100644
--- a/package.json
+++ b/package.json
@@ -29,6 +29,7 @@
     "@zeit/next-workers": "^1.0.0",
     "aws-sdk": "^2.399.0",
     "body-parser": "^1.18.1",
+    "canvas": "^2.5.0",
     "cookie-session": "^1.3.1",
     "crypto-random-string": "^1.0.0",
     "cssesc": "0.1.0",
diff --git a/src/Button-happo.js b/src/Button-happo.js
index 64c0279..c1444a6 100644
--- a/src/Button-happo.js
+++ b/src/Button-happo.js
@@ -2,6 +2,11 @@ import React from 'react';

 import Button from './Button';

+import { createCanvas } from 'canvas';
+
+const mycanvas = createCanvas(200, 200)
+const myPDFcanvas = createCanvas(600, 800, 'pdf')
+
 export const large = () => <Button large>Sign up!</Button>;
 export const small = () => <Button small>Remove</Button>;
 export const medium = () => <Button medium>Add email</Button>;

It looks like your project is using the happo-plugin-storybook plugin, is that correct? I'm assuming there's one or a few stories relying on the canvas module. A temporary workaround would be to exclude those stories from the happo run, using { happo: false }:
storiesOf('FooComponent', module)
  .add('Default', () => <FooComponent />);
  .add('Dynamic', () => <DynamicFooComponent />, { happo: false });

You can also exclude a whole block using the isHappoRun function:
import { isHappoRun } from 'happo-plugin-storybook/register';

if (!isHappoRun()) {
  storiesOf('FooComponent', module)
    .add('Default', () => <FooComponent />);
    .add('Dynamic', () => <DynamicFooComponent />);
}

Sorry you're running into these issues -- hopefully we can get things resolved for you asap!

Hi Henric,
thanks so much for your help! We ended up not even needing canvas so we just took it out...
and ta da! it works!

Yay! Glad you got it working! 🎉


Allow PanelGroup to receive additional props

Heya, I noticed that PanelGroup renders a component and passes some styling and data props.
Here's where this magic happens.
Something I'd like to ask is the ability to pass any additional props along.
In my case I am wrapping with another div as a workaround, but it would be nice to be able to avoid a div soup and pass the relevant props directly to PanelGroup.
Cheers! 🥂

Feel free to open a PR with a proposal and I will look it over.

I will support this in v1.0 (#230)


Add failing test for res.redirect

Hi,
I was trying to deploy a Next site with preview mode on Netlify and was stuck on this error for quite some time:

The final solution that resolved the issue was changing
  res.redirect(req.query.slug)

to
  res.writeHead(307, { Location: req.query.slug });
  res.end();

I'm under the impression that the first syntax is supposed to be valid and was taken from the official Next.js docs for preview mode. Hence, I've created a failing test so anyone here could take a look at the issue and find the root cause if interested.
Thanks and cheers!

If this is something that's already know then I apologise and would like to suggest that it be documented somewhere with higher visibility.

was just able to repro in my own project after deploying. not immediately clear why this is happening but will investigate and keep you updated. thanks for opening this with the test <3.

update: we think we've discovered the issue here. i think @FinnWoelm will be opening his own PR soon!

closing per #93 ! thanks again <3


example: elasticsearch, kibana, and filebeat ~elk

Yeah, that would be perfect!
On 20 Sep 2016, at 8:46, Ryan Eschinger wrote:

ryane commented on this pull request.

+$ cat ~/.terraformrc
+provisioners {

converge = "/path/to/terraform-provisioner-converge"
+}
+```

+You must have also set valid AWS
credentials
(AWS_ACCESS_KEY_ID and AWS_SECRET_ACCESS_KEY) in your environment.
Then you can run:
+
+ +terraform apply +
+
+After provisioning completes, you should be able to access the url
for the Kibana interface by running:
+
+```shell
+echo "http://$(terraform output ip):5601/"
I know. It is just a command that provides an easy way to access the
full url for kibana so that you can paste it in your browser. Would
changing the sentence above to something like
"After provisioning completes, you should be able to retrieve the url
for the Kibana interface by running:"
make it more clear?
--
You are receiving this because you commented.
Reply to this email directly or view it on GitHub:
https://github.com/asteris-llc/converge/pull/272

I believe all comments were addressed. ready for review again

all green


keyboard repeat feature

Long pressing key on the keyboard should repeat the key.
delay before repeat and repeat delay should be stored into variables (to be configurable on later revision)

Maybe you can get some ideas of how to implement the auto-repeat by looking at https://github.com/dquadros/RPTerm/blob/main/keybd.cpp
My implementation is a little crude, it is auto-repeating all keys. Also its is not checking if the modifiers (shift, control, alt) have changed.

Looks to work properly.
Would be nice to be tested by someone else.


Reference conflicts

Error CS1705 Assembly 'Microsoft.Bot.Builder.Integration.AspNet.Core' with identity 'Microsoft.Bot.Builder.Integration.AspNet.Core, Version=<IP_ADDRESS>, Culture=neutral, PublicKeyToken=31bf3856ad364e35' uses 'Microsoft.AspNetCore.Http.Abstractions, Version=<IP_ADDRESS>, Culture=neutral, PublicKeyToken=adb9793829ddae60' which has a higher version than referenced assembly 'Microsoft.AspNetCore.Http.Abstractions' with identity 'Microsoft.AspNetCore.Http.Abstractions, Version=<IP_ADDRESS>, Culture=neutral, PublicKeyToken=adb9793829ddae60'	Azure FunctionApp
Version
Microsoft.Bot.Builder.Integration.AspNet.Core, Version=<IP_ADDRESS> with azure function
Describe the bug
Getting version conflict
Screenshots

Hi @atifgk
I believe you will need to manually add a reference to Microsoft.AspNetCore.HttpAbstractions 3.1.0 in order to overcome this.  I assume your project is targeting net core 3.1?

Hi @EricDahlvang thanks for reply. yes i'm using asp.net core 3.1 version. in nuget only Microsoft.AspNetCore.HttpAbstractions 2.2.0 available. can you please guide how i can install 3.1.0? thanks

please see this one
https://www.nuget.org/packages/Microsoft.AspNetCore.Http.Abstractions/

I get the same issue. Steps to reproduce:

Create an Azure Function app in VS 2019
Add the "Microsoft.Bot.Builder.Integration.AspNet.Core" 4.10.3 package
Replace the contents of the function class with the following:

    public class Function1
    {
        private readonly IBotFrameworkHttpAdapter _adapter;
        private readonly IBot _bot;

        public Function1(IBotFrameworkHttpAdapter adapter, IBot bot)
        {
            _adapter = adapter;
            _bot = bot;
        }

        [FunctionName("Function1")]
        public async Task<IActionResult> Run(
            [HttpTrigger(AuthorizationLevel.Function, "get", "post", Route = null)] HttpRequest req,
            ILogger log)
        {
            return await _adapter.ProcessAsync(null, null, _bot);
        }
    }

Compile the project

Here's what the .NET Core 3.1 version Microsoft.Bot.Builder.Integration.AspNet.Core assembly is referencing:

i.e. version <IP_ADDRESS>, which, as @atifgk says, is not available on NuGet
This clashes with the version of the Microsoft.AspNetCore.Http.Abstractions package as referenced (indirectly) by the Microsoft.Net.Sdk.Functions 3.0.7 (and 3.0.9, at least) package, which is version 2.1.0.
I think there's a workaround as the .NET Standard 2.0 package references the following:

i.e. version <IP_ADDRESS>
Hence the workaround ought to be indirectly referencing the package through a .NET standard library.

I apologize for my confusion in the above response.  Looking into this more, Microsoft.AspNetCore.HttpAbstractions is actually provided for a 3.1 project via a FrameworkReference:
  <ItemGroup>
    <FrameworkReference Include="Microsoft.AspNetCore.App" />
  </ItemGroup>

Please add this to your .csproj file, and let us know how it goes.

Hi @EricDahlvang ,
Thanks for reply. I tried your solution it solved that error but now getting other error.
System.Private.CoreLib: Exception while executing function: BotMessagesHandler. Microsoft.Bot.Connector: Could not load file or assembly 'System.IdentityModel.Tokens.Jwt, Version=<IP_ADDRESS>, Culture=neutral, PublicKeyToken=31bf3856ad364e35'. The system cannot find the file specified.
I tried installing System.IdentityModel.Tokens.Jwt, Version=<IP_ADDRESS> but no success

@EricDahlvang please find project in attachment
SampleProject.zip

it work fine if i use Microsoft.Bot.Builder.Integration.AspNet.Core" 4.6.0 version
<PackageReference Include="Microsoft.Bot.Builder.Integration.AspNet.Core" Version="4.10.3" />

Well, this is odd.  Adding _FunctionsSkipCleanOutput to the .csproj fixes the System.IdentityModel.Tokens.Jwt load issue:
  <PropertyGroup>
    <TargetFramework>netcoreapp3.1</TargetFramework>
    <AzureFunctionsVersion>v3</AzureFunctionsVersion>
    <_FunctionsSkipCleanOutput>true</_FunctionsSkipCleanOutput>
  </PropertyGroup>

More information about this can be found here:
https://github.com/Azure/azure-functions-vs-build-sdk/issues/397
and
https://github.com/Azure/azure-functions-host/issues/5894

Thanks @EricDahlvang its working now with your trick :)


[MWPW-157973] Run Nala checks on all PRs by default

Description
This PR updates the Git workflow to run Nala checks on all PRs by default.
Related Issue
Resolves: MWPW-157973
Testing instructions
See that the Nala Tests are running on this PR without having the run-nala label added.
PSI check URL
https://mwpw-157973-nala-by-default--milo--robert-bogos.hlx.page/drafts/rbogos/page-default?martech=off

@robert-bogos & @skumar09 - should we also delete the label, since it would not achieve anything at the moment?


[ambermini and packmol] Update ambermini and packmol builds to fix `GFORTRAN_1.4' not found

cc: https://github.com/choderalab/openmoltools/pull/198#issuecomment-192029702

This is a hunch, but I think rebuilding these packages with current gcc and libgcc dependencies may fix this.  If not, we will add libgfortran dependencies as suggested in https://github.com/choderalab/openmoltools/pull/198#issuecomment-192029702

Actually, it probably doesn't hurt to add those dependencies anyway.


console output error

Hy,
I get the following error thrown to my console, but as far as I have quickly tested, everything seems to work!
node_modules/ng2-tag-input/index.ts:3:0 Cannot find name 'exports'.

Interesting, seems to be a typings issue. Can you tell me which version is it? Thanks!

its version 0.2.5

with the new version 0.2.6 I get the following errors:
ERROR in [default] <PROJECT_PATH>/node_modules/ng2-tag-input/index.ts:3:0
Cannot find name 'exports'.

ERROR in [default] <PROJECT_PATH>/node_modules/ng2-tag-input/index.ts:4:0
Cannot find name 'exports'.

ERROR in [default] <MY_MODULE_FILE_PATH>
File '<PROJECT_PATH>/node_modules/ng2-tag-input/index.ts' is not a module.

Hi @FallenRiteMonk, can you retry with the new version please? Thanks!

Works great thanks!


Add Future publisher with simple tests

Resolves #105

Fails

:no_entry_sign:

Sources/OpenCombine/Publishers/Future.swift#L20 - Line should be 90 characters or less: currently 100 characters (line_length)

:no_entry_sign:

Sources/OpenCombine/Publishers/Future.swift#L29 - Line should be 90 characters or less: currently 107 characters (line_length)

:no_entry_sign:

Tests/OpenCombineTests/PublisherTests/FutureTests.swift#L22 - Line should be 90 characters or less: currently 102 characters (line_length)

:no_entry_sign:

Tests/OpenCombineTests/PublisherTests/FutureTests.swift#L23 - Line should be 90 characters or less: currently 103 characters (line_length)

:no_entry_sign:

Tests/OpenCombineTests/PublisherTests/FutureTests.swift#L42 - Parentheses are not needed when declaring closure arguments. (unneeded_parentheses_in_closure_argument)

:no_entry_sign:

Tests/OpenCombineTests/PublisherTests/FutureTests.swift#L70 - Parentheses are not needed when declaring closure arguments. (unneeded_parentheses_in_closure_argument)

:no_entry_sign:

Tests/OpenCombineTests/PublisherTests/FutureTests.swift#L82 - Unused parameter "value" in a closure should be replaced with _. (unused_closure_parameter)

:no_entry_sign:

Tests/OpenCombineTests/PublisherTests/FutureTests.swift#L96 - Prefer implicit returns in closures. (implicit_return)

:no_entry_sign:

Tests/OpenCombineTests/PublisherTests/FutureTests.swift#L99 - Prefer implicit returns in closures. (implicit_return)

  Generated by :no_entry_sign: Danger Swift against 52933633c851f46b8f4f3e2e7f299ff651730467

Looks like some CI steps failed on timeout, but I don't have permissions to restart 😕

LGTM

  Generated by :no_entry_sign: Danger Swift against 31802d26c41df7ec6797802457eec1deab4dacc6

Can I ask you to use the TrackingSubscriberBase class in tests instead of sink, and assert on its  history property? We don't want to test sink along the way.
This class is designed in such a way that it intentionally doesn't do much for you. For example, you need to explicitly request the desired number of elements, while sink will always request .unlimited, which is not what's always happening, hence we're not testing an important code path.
Also, IMO, this class makes the tests easier to understand.
You can find the example usages of this class pretty much in any test. Here's how we do it for CurrentValueSubject:
https://github.com/broadwaylamb/OpenCombine/blob/130125cb66ddb2ab532a5fe3b36af8bbdbbb7a36/Tests/OpenCombineTests/CurrentValueSubjectTests.swift#L230-L265

LGTM

  Generated by :no_entry_sign: Danger Swift against d37c89ead658d27dad3ae4f25efb87eddaca92b8

LGTM

  Generated by :no_entry_sign: Danger Swift against 09c181da871cff363569cae90f608e5b7d2af034


Good work !

I've stumbled upon this repo by chance and I think it's great, thanks for this !

Thank you for your kind words, it means a lot.
This is work in progress though, i'm adding new stuff constantly. Check in a few days for a "Domain Events" section and code examples if interested :)

Thank you for your kind words, it means a lot.
This is work in progress though, i'm adding new stuff constantly. Check in a few days for a "Domain Events" section and code examples if interested :)

Can't wait !

Can't wait !


express/react: add way to edit reviews

This will require a request to check the users email address for their reviews and a patch request to change the contents requested

To help anyone who wishes to take on the front-end requirements, I've added a new /api/reviews endpoint on the associated feature branch 1-expressreact-add-way-to-edit-reviews


[gradle] update sb version to 1.0.54 and using "consume OSGi Services"

Something is wrong with this one. It doesn't compile. Missing import I'm guessing:
/tmp/dilldall/blade/gradle/blade.servicebuilder.svc/src/main/java/blade/servicebuilder/service/base/FooLocalServiceBaseImpl.java:37: error: package com.liferay.portal.kernel.module.framework.service does not exist
import com.liferay.portal.kernel.module.framework.service.IdentifiableOSGiService;
^
/tmp/dilldall/blade/gradle/blade.servicebuilder.svc/src/main/java/blade/servicebuilder/service/base/FooLocalServiceBaseImpl.java:76: error: cannot find symbol
implements FooLocalService, IdentifiableOSGiService {
^
symbol: class IdentifiableOSGiService
/tmp/dilldall/blade/gradle/blade.servicebuilder.svc/src/main/java/blade/servicebuilder/service/base/FooServiceBaseImpl.java:28: error: package com.liferay.portal.kernel.module.framework.service does not exist
import com.liferay.portal.kernel.module.framework.service.IdentifiableOSGiService;
^
/tmp/dilldall/blade/gradle/blade.servicebuilder.svc/src/main/java/blade/servicebuilder/service/base/FooServiceBaseImpl.java:52: error: cannot find symbol
implements FooService, IdentifiableOSGiService {

Hi Brendan , update the portal-service-7.0.0-SNAPSHOT.jar dependency , and it will compile .

Indeed. --refresh-dependencies did the trick :) Thanks Andy

Hmm. I could not get this running on yesterdays nightly:
Unresolved requirement: Import-Package: com.liferay.portal.kernel.module.framework.service; version="[7.0.0,8.
0.0)"_ [Sanitized]
Seems like todays nightly just got published, so I'll try it again once I've downloaded. I'm guessing that something changed between the two. An this is a non-issue. I'll let you know.

Nope. Same issue with the latest nightly that was built a few hours ago :(

Okey. So I guess I've found the issue here. This probably will run on a build from master, but not on the 7.x branch. Unfortunately seems there are no nightlies from master any more.

Just started reviewing :) :octocat: Sent from GH.

Merged, thanks! See :octocat: Sent from GH.

Just started reviewing :) :octocat: Sent from GH.

Merged, thanks! See b9b14e2...d4a462e :octocat: Sent from GH.

You are right Brendan, It only works on master branch not 7.x branch . Thanks for reporting this .


Dateparser doesnt work with latest regex on m1 mac

To fix this i had to downgrade regex to regex==2021.9.30
Here is the log- `Python 3.10.0 (v3.10.0:b494f5935c, Oct  4 2021, 14:59:19) [Clang 12.0.5 (clang-1<IP_ADDRESS>)] on darwin
Type "help", "copyright", "credits" or "license" for more information.

import dateparser
Traceback (most recent call last):
File "", line 1, in
File "/Library/Frameworks/Python.framework/Versions/3.10/lib/python3.10/site-packages/dateparser/init.py", line 3, in
from .date import DateDataParser
File "/Library/Frameworks/Python.framework/Versions/3.10/lib/python3.10/site-packages/dateparser/date.py", line 6, in
import regex as re
File "/Library/Frameworks/Python.framework/Versions/3.10/lib/python3.10/site-packages/regex/init.py", line 1, in
from .regex import *
File "/Library/Frameworks/Python.framework/Versions/3.10/lib/python3.10/site-packages/regex/regex.py", line 419, in
import regex._regex_core as _regex_core
File "/Library/Frameworks/Python.framework/Versions/3.10/lib/python3.10/site-packages/regex/_regex_core.py", line 21, in
import regex._regex as _regex
ImportError: dlopen(/Library/Frameworks/Python.framework/Versions/3.10/lib/python3.10/site-packages/regex/_regex.cpython-310-darwin.so, 2): no suitable image found.  Did find:
/Library/Frameworks/Python.framework/Versions/3.10/lib/python3.10/site-packages/regex/_regex.cpython-310-darwin.so: code signature in (/Library/Frameworks/Python.framework/Versions/3.10/lib/python3.10/site-packages/regex/_regex.cpython-310-darwin.so) not valid for use in process using Library Validation: Trying to load an unsigned library
`

Got the info from https://github.com/aws/aws-sam-cli/issues/3370#issuecomment-946012467

The latest regex is 2022-09-13, could you check with that one?

Closing as a duplicate of https://github.com/scrapinghub/dateparser/issues/1052 (this issue is older, but the linked one has a longer conversation)


x86: ia32: do not use the first 2 megabytes

After witnessing some strange errors with memory not being
what it should be, lifiting everything above 1MB has solved
it. The Zephyr binary was being loaded into memory containing
reserved regions, resulting in data corruption.
We still simulate XIP for testing purposes by setting up the
memory map as follows:
0x000000 - 0x1FFFFF : Non-present
0x200000 - 0x5FFFFF : "Flash" ROM region
0x600000 - 0x9FFFFF : "SRAM" RAM region
For a total of 10 megabytes of physical RAM used.
Fixes problems observed in some large tests when code coverage
is enabled (which increases the amount of RAM used even more).
Fixes: #17782
Signed-off-by: Andrew Boie<EMAIL_ADDRESS>

@andyross @gnuless initially I tried lifting above just the first megabyte, but still ran into issues. Moving above 2MB seems to have resolved it. I wasn't expecting any reserved memory regions between 1MB-2MB, maybe some quirk of QEMU?

NVS fs test is failing, not entirely sure how to fix
c[?7l[2J[0mSeaBIOS (version rel-1.12.0-0-ga698c8995f-prebuilt.qemu.org)
Booting from ROM..***** Booting Zephyr OS build zephyr-v1.14.0-2843-g72fb988a685e *****
Running test suite test_nvs
===================================================================
starting test - test_nvs_init

    Assertion failed at ZEPHYR_BASE/tests/subsys/fs/nvs/src/main.c:72: test_nvs_init: (err == 0 is false)
Unable to get page info: -22
FAIL - test_nvs_init
===================================================================
starting test - test_nvs_write

    Assertion failed at ZEPHYR_BASE/tests/subsys/fs/nvs/src/main.c:111: test_nvs_write: (err == 0 is false)
nvs_init call failure: -22
FAIL - test_nvs_write
===================================================================
starting test - test_nvs_corrupted_write

    Assertion failed at ZEPHYR_BASE/tests/subsys/fs/nvs/src/main.c:151: test_nvs_corrupted_write: (err == 0 is false)
nvs_init call failure: -22
FAIL - test_nvs_corrupted_write
===================================================================
starting test - test_nvs_gc

    Assertion failed at ZEPHYR_BASE/tests/subsys/fs/nvs/src/main.c:221: test_nvs_gc: (err == 0 is false)
nvs_init call failure: -22
FAIL - test_nvs_gc
===================================================================
starting test - test_nvs_gc_3sectors

    Assertion failed at ZEPHYR_BASE/tests/subsys/fs/nvs/src/main.c:46: setup: (err == 0 is false)
nvs_clear call failure: -13
FAIL - test_nvs_gc_3sectors
===================================================================
starting test - test_nvs_corrupted_sector_close_operation

    Assertion failed at ZEPHYR_BASE/tests/subsys/fs/nvs/src/main.c:46: setup: (err == 0 is false)
nvs_clear call failure: -13
FAIL - test_nvs_corrupted_sector_close_operation
===================================================================
Test suite test_nvs failed.
===================================================================
PROJECT EXECUTION FAILED
[00:00:00.000,000] [1;31m<err> fs_nvs: Unable to get page info[0m
[00:00:00.000,000] [1;31m<err> fs_nvs: Unable to get page info[0m
[00:00:00.000,000] [1;31m<err> fs_nvs: Unable to get page info[0m
[00:00:00.000,000] [1;31m<err> fs_nvs: NVS not initialized[0m
[00:00:00.000,000] [1;31m<err> fs_nvs: NVS not initialized[0m

The first megabyte should be enough. I wrote a test program to probe writes in the first 2MB and found these address ranges would not have any effect if writes were done to them:
0x000a0000 -> 0x000b8000
0x000c0000 -> 0x000ca000
0x000cd000 -> 0x000e8000
0x000f0000 -> 0x00100000
0x00100000 and above should be fine.

I combined this with my other patch which generates page tables at runtime, as lifting to 1MB exposed bugs in the old page table generation script, and I'd rather just remove it.

NVS fs test is failing, not entirely sure how to fix, @nvlsianpu any tips?

Is this still failing?

NVS fs test is failing, not entirely sure how to fix, @nvlsianpu any tips?

Is this still failing?

No, I figured it out.


Adding Mathematical methods for quantitative finance

You can add math models which helps in financial forcasting.

Could you assign this to me? I'm interested.

Can you provide me some clarity on types of models, Can SVMs or Bayesian networks be considered as mathematical models? Also Can you assign this issue to me. Thanks

hello @Akshat111111  I'm interested in this issue and I want to work on it . Kindly please assign this issue to me .

Can you provide me some clarity on types of models, Can SVMs or Bayesian networks be considered as mathematical models? Also Can you assign this issue to me. Thanks

No

I have assigned this issue.Kindly tell which amthematical model you will add ??

machine learning techniques such as neural networks and deep learning, advanced stochastic calculus methods, numerical methods for solving partial differential equations (PDEs). Can be added ?

yes can be added.Do it by creating a new mathematical modelling folder.

Yes will start by adding a folder

I want to work on this issue . Kindly assign it to me

There is already a lot of people working here.


Possible Bug - User dashboard

When User Dashboard is enabled - the page opens at the bottom of the screen

instead of

Good catch @Nigrini! 🥇
You're right. It's a bug. I will tell you what file to update in order to fix it.
The problem is due because all forms use jQuery focus() on the first field element of each form.
And because on this page, the form is located at the bottom, the browser scrolls you down to that form field element :)

In _protected/framework/Layout/Form/Engine/PFBC/Form.class.php, please just change the following ->
https://github.com/pH7Software/pH7-Social-Dating-CMS/commit/6914c56f828856b20c5065cd869269f8a45a6f41


Update reporting-info.md

Changing the word Booking calendar to Shared bookings

[like]  Pritika Roy Chowdhury reacted to your message:

From: Kweku Ako-Adjei @.>
Sent: Friday, May 24, 2024 6:31:20 AM
To: MicrosoftDocs/microsoft-365-docs @.>
Cc: Pritika Roy Chowdhury @.>; Author @.>
Subject: Re: [MicrosoftDocs/microsoft-365-docs] Update reporting-info.md (PR #13552)
Merged #13552https://github.com/MicrosoftDocs/microsoft-365-docs/pull/13552 into public.
—
Reply to this email directly, view it on GitHubhttps://github.com/MicrosoftDocs/microsoft-365-docs/pull/13552#event-12919689678, or unsubscribehttps://github.com/notifications/unsubscribe-auth/BETQTAT64NU44H4B6ZDZQUDZD3NDRAVCNFSM6AAAAABIDGASDSVHI2DSMVQWIX3LMV45UABCJFZXG5LFIV3GK3TUJZXXI2LGNFRWC5DJN5XDWMJSHEYTSNRYHE3DOOA.
You are receiving this because you authored the thread.Message ID: @.***>


Questions about analyzer.

Hi, I have questions about analyzer.
Can I run the analyzer with only the scope that I want to analyze?
For example, I want to run the analyze the dependencies scope only (except devDependencies) in npm.
I couldn't find it in any documents.
Please help me!
Thank you.

Can I run the analyzer with only the scope that I want to analyze?

Actually, no. That's not how the Analyzer is support to work, and coincidentally I just tried to clarify this as part of this PR:
The analyzer is supposed to capture *all* known information about a project, which can then be "filtered" in later steps.

@sschuberth
The updated docs will be enough to answer this question.
Thank you for quick reply!