instillation error

I followed the steps given in README page but gettign the following errors when I did "python setup.py install"
[9/983] Building CXX object kaldi/base/CMakeFiles/_kaldi_error.dir/kaldi-error-clifwrap-init.cc.o
FAILED: kaldi/base/CMakeFiles/_kaldi_error.dir/kaldi-error-clifwrap-init.cc.o
/usr/bin/c++   -D_kaldi_error_EXPORTS -I../kaldi/lib -I../kaldi -Ikaldi -I../tools/kaldi/src -I/usr/include/python2.7 -I/home/sgangireddy/venv_py36/lib/python3.6/site-packages/numpy/core/include -std=c++11 -I.. -isystem /home/sgangireddy/PycharmProjects/pykaldi/tools/kaldi/tools/openfst/include -O1 -Wall -Wno-sign-compare -Wno-unused-local-typedefs -Wno-deprecated-declarations -Winit-self -DKALDI_DOUBLEPRECISION=0 -DHAVE_EXECINFO_H=1 -DHAVE_CXXABI_H -DHAVE_ATLAS -I/home/sgangireddy/PycharmProjects/pykaldi/tools/kaldi/tools/ATLAS_headers/include -msse -msse2 -pthread -g -fPIC -Wno-maybe-uninitialized -fPIC -MD -MT kaldi/base/CMakeFiles/_kaldi_error.dir/kaldi-error-clifwrap-init.cc.o -MF kaldi/base/CMakeFiles/_kaldi_error.dir/kaldi-error-clifwrap-init.cc.o.d -o kaldi/base/CMakeFiles/_kaldi_error.dir/kaldi-error-clifwrap-init.cc.o -c kaldi/base/kaldi-error-clifwrap-init.cc
kaldi/base/kaldi-error-clifwrap-init.cc: In function ‘void PyInit__kaldi_error()’:
kaldi/base/kaldi-error-clifwrap-init.cc:17:60: error: return-statement with a value, in function returning 'void' [-fpermissive]
if (!kaldi_base___kaldi__error_clifwrap::Ready()) return nullptr;
^
kaldi/base/kaldi-error-clifwrap-init.cc:18:51: error: return-statement with a value, in function returning 'void' [-fpermissive]
return kaldi_base___kaldi__error_clifwrap::Init();
^
[12/983] Building CXX object kaldi/base/CMakeFiles/_kaldi_error.dir/kaldi-error-clifwrap.cc.o
FAILED: kaldi/base/CMakeFiles/_kaldi_error.dir/kaldi-error-clifwrap.cc.o
/usr/bin/c++   -D_kaldi_error_EXPORTS -I../kaldi/lib -I../kaldi -Ikaldi -I../tools/kaldi/src -I/usr/include/python2.7 -I/home/sgangireddy/venv_py36/lib/python3.6/site-packages/numpy/core/include -std=c++11 -I.. -isystem /home/sgangireddy/PycharmProjects/pykaldi/tools/kaldi/tools/openfst/include -O1 -Wall -Wno-sign-compare -Wno-unused-local-typedefs -Wno-deprecated-declarations -Winit-self -DKALDI_DOUBLEPRECISION=0 -DHAVE_EXECINFO_H=1 -DHAVE_CXXABI_H -DHAVE_ATLAS -I/home/sgangireddy/PycharmProjects/pykaldi/tools/kaldi/tools/ATLAS_headers/include -msse -msse2 -pthread -g -fPIC -Wno-maybe-uninitialized -fPIC -MD -MT kaldi/base/CMakeFiles/_kaldi_error.dir/kaldi-error-clifwrap.cc.o -MF kaldi/base/CMakeFiles/_kaldi_error.dir/kaldi-error-clifwrap.cc.o.d -o kaldi/base/CMakeFiles/_kaldi_error.dir/kaldi-error-clifwrap.cc.o -c kaldi/base/kaldi-error-clifwrap.cc
kaldi/base/kaldi-error-clifwrap.cc:167:27: error: variable ‘kaldi_base___kaldi__error_clifwrap::PyModuleDef kaldi_base___kaldi__error_clifwrap::Module’ has initializer but incomplete type
static struct PyModuleDef Module = {
^
kaldi/base/kaldi-error-clifwrap.cc:168:3: error: ‘PyModuleDef_HEAD_INIT’ was not declared in this scope
PyModuleDef_HEAD_INIT,
^
kaldi/base/kaldi-error-clifwrap.cc: In function ‘PyObject* kaldi_base___kaldi__error_clifwrap::Init()’:
kaldi/base/kaldi-error-clifwrap.cc:176:45: error: ‘PyModule_Create’ was not declared in this scope
PyObject* module = PyModule_Create(&Module);
^
[13/983] Building CXX object kaldi/base/CMakeFiles/_kaldi_math.dir/kaldi-math-clifwrap.cc.o
FAILED: kaldi/base/CMakeFiles/_kaldi_math.dir/kaldi-math-clifwrap.cc.o
/usr/bin/c++   -D_kaldi_math_EXPORTS -I../kaldi/lib -I../kaldi -Ikaldi -I../tools/kaldi/src -I/usr/include/python2.7 -I/home/sgangireddy/venv_py36/lib/python3.6/site-packages/numpy/core/include -std=c++11 -I.. -isystem /home/sgangireddy/PycharmProjects/pykaldi/tools/kaldi/tools/openfst/include -O1 -Wall -Wno-sign-compare -Wno-unused-local-typedefs -Wno-deprecated-declarations -Winit-self -DKALDI_DOUBLEPRECISION=0 -DHAVE_EXECINFO_H=1 -DHAVE_CXXABI_H -DHAVE_ATLAS -I/home/sgangireddy/PycharmProjects/pykaldi/tools/kaldi/tools/ATLAS_headers/include -msse -msse2 -pthread -g -fPIC -Wno-maybe-uninitialized -fPIC -MD -MT kaldi/base/CMakeFiles/_kaldi_math.dir/kaldi-math-clifwrap.cc.o -MF kaldi/base/CMakeFiles/_kaldi_math.dir/kaldi-math-clifwrap.cc.o.d -o kaldi/base/CMakeFiles/_kaldi_math.dir/kaldi-math-clifwrap.cc.o -c kaldi/base/kaldi-math-clifwrap.cc
kaldi/base/kaldi-math-clifwrap.cc: In function ‘int kaldi_base___kaldi__math_clifwrap::pyRandomState::set_seed(PyObject*, PyObject*, void*)’:
kaldi/base/kaldi-math-clifwrap.cc:44:87: error: ‘PyUnicode_AsUTF8’ was not declared in this scope
PyErr_Format(PyExc_ValueError, "%s is not valid for seed:int", s? PyUnicode_AsUTF8(s): "input");
^
kaldi/base/kaldi-math-clifwrap.cc: At global scope:
kaldi/base/kaldi-math-clifwrap.cc:781:27: error: variable ‘kaldi_base___kaldi__math_clifwrap::PyModuleDef kaldi_base___kaldi__math_clifwrap::Module’ has initializer but incomplete type
static struct PyModuleDef Module = {
^
kaldi/base/kaldi-math-clifwrap.cc:782:3: error: ‘PyModuleDef_HEAD_INIT’ was not declared in this scope
PyModuleDef_HEAD_INIT,
^
kaldi/base/kaldi-math-clifwrap.cc: In function ‘PyObject* kaldi_base___kaldi__math_clifwrap::Init()’:
kaldi/base/kaldi-math-clifwrap.cc:790:45: error: ‘PyModule_Create’ was not declared in this scope
PyObject* module = PyModule_Create(&Module);
^
[14/983] Generating fstream-clifwrap.cc, fstream-clifwrap.h, fstream-clifwrap-init.cc
ninja: build stopped: subcommand failed.
Command '['ninja', '-j', '6']' returned non-zero exit status 1.

I have got a similar error
Line .123456789.123456789.123456789.123456789
1:from "fstext/symbol-table-clifwrap.h" import *\n
2:from "fstext/float-weight-clifwrap.h" import *\n
3:from "fstext/lattice-weight-clifwrap.h" import *\n
4:from "fstext/fst-clifwrap.h" import *\n
5:from "fstext/expanded-fst-clifwrap.h" import *\n
6:from "fstext/mutable-fst-clifwrap.h" import *\n
7:from "fstext/vector-fst-clifwrap.h" import *\n
8:from "fstext/fstext-utils.h" import *\n
9:\n
10:from kaldi.util import _value_error_on_false\n
11:\n
12:from "fstext/fstext-utils-inl.h":\n
............
_ParseError: include "fstext/expanded-fst-clifwrap.h" not found
[134/983] Building CXX object kaldi/fstext/CMakeFiles/_log_construct2_ops.dir/log-construct2-ops-clifwrap.cc.o
ninja: build stopped: subcommand failed.
Command '['ninja', '-j', '2']' returned non-zero exit status 1.

@srgangireddy It seems the python include directory detected by cmake is not compatible with the active python environment where numpy is installed. See below for the relevant compiler flags from your error log.
... -I/usr/include/python2.7 -I/home/sgangireddy/venv_py36/lib/python3.6/site-packages/numpy/core/include ...

My guess is you are trying to install inside a python3.6 virtual environment but cmake is somehow picking up the include directory for system python2.7. Is PYTHONPATH set in your shell environment?

@eracube I just pushed a fix for your problem. Could you retry building after pulling the latest changes and report here what happens?

@eracube I just pushed a fix for your problem. Could you retry building after pulling the latest changes and report here what happens?

Thank you @dogancan I have successfully build it. Now I have to make ASR to work. Unfortunately, I don't have a large dataset to train my model.

@eracube You're welcome. Note that pykaldi does not provide any high-level utilities or APIs for ASR training. If you want to train your own models, you will have to use kaldi recipes. Alternatively, you might be able to find pre-trained models, like the ones downloaded when you run the example setups in pykaldi/examples/setups.

@dogancan ; Earlier I tried to build from source but now build using docker. Now the build is successful. Thank you.

You're welcome. I am closing this issue, but feel free to reopen.

Hello @dogancan, I was able to install pykaldi on my mac successfully but I tried to install the same in my linux machine and it gives me the following error when I try to install clif :
Cloning into '/pykaldi/tools/clif'...
remote: Enumerating objects: 512, done.
remote: Total 512 (delta 0), reused 0 (delta 0), pack-reused 512
Receiving objects: 100% (512/512), 367.24 KiB | 0 bytes/s, done.
Resolving deltas: 100% (298/298), done.
Checking connectivity... done.
Already up-to-date.
/pykaldi/env/bin/ninja
Using ninja for the clif backend build.
Checked out revision 307315.
Checked out revision 307315.
-- The C compiler identification is GNU 5.4.0
-- The CXX compiler identification is GNU 5.4.0
-- The ASM compiler identification is GNU
-- Found assembler: /usr/bin/cc
-- Check for working C compiler using: Ninja
CMake Error:
The detected version of Ninja () is less than the version of Ninja required
by CMake (1.3).
CMake Error: Internal CMake error, TryCompile generation of cmake failed
-- Check for working C compiler using: Ninja -- broken
CMake Error at /usr/share/cmake-3.5/Modules/CMakeTestCCompiler.cmake:61 (message):
The C compiler "/usr/bin/cc" is not able to compile a simple test program.
It fails with the following output:
CMake will not be able to correctly generate this project.
Call Stack (most recent call first):
CMakeLists.txt:54 (project)
-- Configuring incomplete, errors occurred!
See also "/pykaldi/tools/clif_backend/build_matcher/CMakeFiles/CMakeOutput.log".
See also "/pykaldi/tools/clif_backend/build_matcher/CMakeFiles/CMakeError.log".
The ninja version that is installed is ninja==1.9.0

It seems like CMake is confused about ninja version. Can you try removing pykaldi/tools/clif_backend directory and rerunning install_clif.sh?

I removed the clif_backend directory and ran install_clif.sh, but I am still getting the same issue.

Do you have a system wide old ninja installation? For some reason CMake is not able to determine the version of ninja inside your virtual environment. This is likely a CMake bug.

Another option would be to remove all ninja installations. Then the build scripts would use make instead of ninja. It would run somewhat slower but at least you would be able to build clif and pykaldi.

I don't have ninja installed on this machine. I had tried re-running after removing my local ninja installation but forgot to remove pykaldi/tools/clif_backend. It is fixed now using make. However, I am still not sure why CMake is confused whether or not ninja is installed. Thank you for this.

Same here. I don’t know why CMake is confused. This is not something we have seen before. I am glad removing ninja worked out.

pykaldi is very Complicated in installation on windows
mrd


Do a first time setup for vagrant and make it so you do not have to generate new ssh keys every time

After you merge this, do a vagrant destroy, then just run bin/setup after the setup finishes setting up ruby and vagrant, update the deploy key in github one final time from the .ssh/id_rsa.pub file created inside this repo.  Then you won't have to keep updating the deploy key over and over anymore.

@nickrobertson ^^

Let me try it out


Unhandled exception in circuit when application starts up - Unauthorized

Hi,
Just looking around this repository and just wanted to say that it looks really promising, well done 👏
I stumbled upon a little issue from time to time (not consistent) that I get this error in the CLI upon start up of the app in local development and the home/login page is just blank.
I haven't been able to spot the issue yet but wanted to ask if this was something known?
[15:33:00 ERR ::1] Unhandled exception in circuit '7dBJXGG0pLdOhb19NvlNz1mFXVfQn8ksqbKB97MMgIs'.
System.Net.Http.HttpRequestException: Response status code does not indicate success: 401 (Unauthorized).
   at System.Net.Http.HttpResponseMessage.EnsureSuccessStatusCode()
   at Microsoft.AspNetCore.Http.Connections.Client.HttpConnection.NegotiateAsync(Uri url, HttpClient httpClient, ILogger logger, CancellationToken cancellationToken)
   at Microsoft.AspNetCore.Http.Connections.Client.HttpConnection.GetNegotiationResponseAsync(Uri uri, CancellationToken cancellationToken)
   at Microsoft.AspNetCore.Http.Connections.Client.HttpConnection.SelectAndStartTransport(TransferFormat transferFormat, CancellationToken cancellationToken)
   at Microsoft.AspNetCore.Http.Connections.Client.HttpConnection.StartAsyncCore(TransferFormat transferFormat, CancellationToken cancellationToken)
   at Microsoft.AspNetCore.Http.Connections.Client.HttpConnection.StartAsync(TransferFormat transferFormat, CancellationToken cancellationToken)
   at Microsoft.AspNetCore.Http.Connections.Client.HttpConnectionFactory.ConnectAsync(EndPoint endPoint, CancellationToken cancellationToken)
   at Microsoft.AspNetCore.Http.Connections.Client.HttpConnectionFactory.ConnectAsync(EndPoint endPoint, CancellationToken cancellationToken)
   at Microsoft.AspNetCore.SignalR.Client.HubConnection.StartAsyncCore(CancellationToken cancellationToken)
   at Microsoft.AspNetCore.SignalR.Client.HubConnection.StartAsyncInner(CancellationToken cancellationToken)
   at Microsoft.AspNetCore.SignalR.Client.HubConnection.StartAsync(CancellationToken cancellationToken)
   at BlazorApp.Server.UI.Hubs.HubClient.StartAsync(CancellationToken cancellation) in C:\Users\brk\source\repos\blazorApp\src\Server.UI\Hubs\HubClient.cs:line 74
   at BlazorApp.Server.UI.Components.Identity.UserLoginState.OnInitializedAsync() in C:\Users\brk\source\repos\blazorApp\src\Server.UI\Components\Identity\UserLoginState.razor.cs:line 36
   at Microsoft.AspNetCore.Components.ComponentBase.RunInitAndSetParametersAsync()
   at Microsoft.AspNetCore.Components.RenderTree.Renderer.GetErrorHandledTask(Task taskToHandle, ComponentState owningComponentState)

I'll have a deeper look at some point but if you have any hints it would be appreciated.

Looking through some of the closed issues again I see that this seems to be a recurring thing. Cleaning local storage fixed the issue but I wonder what the root cause would be. I have been using MSSQL SQL Express.

this issue is that the user information used to generate the token is not consistent with the information stored in the database.

What would the solution be? I’m not sure I fully understand the problem? Is it that multiple data stores are available?


Trev8939/deprecation fixes

Hi @eri9600 - This fixes use of highlighting width and color on feature layers and graphics overlays.
While in each of the relevant samples, I took the opportunity to fix some things:

Use java 8 features like lambdas
remove unecessary casting from findViewByIds
Fix lifecycle ordering issues, etc

If you could cast an eye over this before I merge it'd be very helpful. Thank you!

Thanks @eri9600 - I'll keep an eye on Edit Feature Attachments (worked for me just now) and fix as required. Thanks for the review!


What I was proposing is to use your framework to write the 3 use cases/examples that the BEP deals with. I think that's the best way for everyone to appreciate the changes you want to make. Without those 3 cases fully fleshed out, it can be difficult to follow, Then we can see if we can reach a consensus, if and only if we cannot, would we need to ask an 'external' group to look into it (as per BEP guideline PR). I hope this makes sense to you. Thx.

What I was proposing is to use your framework to write the 3 use cases/examples that the BEP deals with.

I don't know what my framework is in this context. Are you asking me to write a PR against PESTILLILAB/bids-specification?

What I was proposing is to use your framework to write the 3 use cases/examples that the BEP deals with. I think that's the best way for everyone to appreciate the changes you want to make.

I have done that above, but okay if a PR against the fork would be a better way of driving the conversation.

Expand to see my concerns about the "BEP guideline PR"

Then we can see if we can reach a consensus, if and only if we cannot, would we need to ask an 'external' group to look into it (as per BEP guideline PR).

The "BEP guideline PR" has so many problems that it is absolutely uninterpretable. However, as per the BIDS' bylaws, it is the BIDS SC who decides its interpretation anyway. In effect, the "BEP guideline PR" is just creating a loophole to move the responsibility for making an ad-hoc decision on a BEP to a group (we don't know the name yet) of referees instead of having the SC behind that decision.
Before proceeding that way, I have several questions (please expand if interested):

Who is going to decide the point where "consensus" has not been achieved? As per the "BEP guideline PR", that looks like the BEP leads, but nothing is said on how the mechanism is triggered - simple majority of BEP leads? how's the voting? That part of the "BEP guideline PR" would need a lot of work to make it actionable.
When is this decision going to happen? When does the procedure become "unlocking" a stuck BEP rather than silencing diverging opinions? Is that one week? one year? a 10% of the current lifespan of the BEP?
Who is going to be part of that group of referees? What is their level of experience with BIDS? How involved with this BEP will they be? Because it is not the same to participate in a conversation compared to fine-tuning my proposal for a tribunal of experts.
How the "alternatives" are to be evaluated? What are the criteria and guidelines that these referees will be given?

Linking https://github.com/bids-standard/bids-extensions/pull/29 as all these questions should be in that thread.

I think we should go ahead and open a PR for BEP038. I suggest that we push the current PESTILLILAB/bep038 branch to upstream/bep038 and open a PR from it. That would mean that PRs against the BEP will now be discussed in the main repository and less likely to go unnoticed, as well as get rendered on ReadTheDocs, for easier review.
@oesteban I think it would be good to make a concrete PR against that branch, once it's created. I've tried to keep up with this thread, but still don't understand what alternative you would like to see.
I did say that I would also try to make a PR against the PESTILLILAB branch a few weeks ago, but have not had the time. I will try to get to that ASAP. Please do not wait on me to get a PR in if you end up having time to put together a proposal first.

Dear all,
I wanted to highlight that @effigies has turned the PESTILLI lab PR into a proper BIDS repo PR now and that we are continuing/restarting the discussions there.
We really want to get your input and see your alternative proposals for how we can share atlases. So please check it out!

Thanks @effigies. You suggested in the PR to have the conversation here - but I think it actually would be better to lock this conversation and redirect everyone to the PR as the main discussion point about the BEP.

I suggest that future conversations be focused in individual PRs against the bep038 branch, rather than creating extensive discussion in that PR, which could grow into something sprawling like this issue. I think it would be good to have very specific proposals that can be discussed and accepted/rejected.
I'm not a huge fan of locking conversations, but I can if it seems like it will be difficult to keep new posts to this thread to a minimum.


Add shorthand for axes

Allows ax @ (1, 0, 0) for coords_to_point and (1, 0, 0) @ ax for point_to_coords
Inspired by @abul4fia

I just added it to NumberLine and changed the CoordinateSystem example to use @ notation. In the future, maybe we should transition to that being the "standard" (although c2p can always exist for more complex expressions)

Will get back to the unresolved comment soon


Promoted to thematic pages

Same functionality as the country page
This provides a "promoted to thematic page" for Content types (news, blogposts, debates , events, organizations, library resources) in the publishing options box.
It will allow you to select (next to the promoted checkbox), on which thematic pages it will appear by selecting a thematic page (CT) OR adding theme and overarching category tags.
Also provide a 'promoted item' view for the Thematic pages (same as for the CP one)
This module should depend on the Thematic CT
Name should be something like: landbook_promoted_thematic
in : modules/landbook/(modules|feature)/promoted_thematic

@jcr this is ready, please check on Beta site.

done. one thing though,
in the promoted box,  it is showing the title of the thematic narrative which is in fact used as a subtitle.
The best solution would be to show the name of the Landvoc term it is linked to (under-specified when you had to develop it, I know...).
Question is, how difficult is it to use an entity reference filter for this field? should be easy no?
There is already a view for entityreference related to landvoc. The one used in the thematic narrative is at https://landportal.info/admin/structure/views/view/landvoc/edit/entityreference_1
as a very quick try I did such a reference filter at:
https://landportal.info/admin/structure/views/view/landvoc/edit/entityreference_2
It shows "Indigenous & Community Land Rights - (Themes) - Nid: 36381 "
(only one because there is no other thematic page right now)

@jcr this is ready, please check


Make cargo-metest work when run as a cargo extension

I think I may have completed this, but I'm sorta unsure what was meant by this if its anything other than just being able to run cargo metest

I think its done, so I'm closing


Update to swift 4.2

Please run
pod repo update && pod install
before building this branch.

Makefile needs an update. Will send a fresh PR.


make rpm-signature-scan depend on image index

Before you complete this pull request ...
Look for any open pull requests in the repository with the title "e2e-tests update" and
see if there are recent e2e-tests updates that will be applicable to your change.

/retest


libtool: improve cross-compilation support

Description of changes
libtool does not support build/host/target as we know it. We have to configure libtool with --host=$target and make sure only the target C compiler is available during the configure, because otherwise libtool will attempt to call the x86 compiler when it is used to cross-compile something.
Fixes pkgsCross.armv7l-hf-multiplatform.libmpack
Also included changes to make pkgsCross.armv7l-hf-multiplatform.ttmkfdir cross-compile, which depend on the libtool change.

Things done

Built on platform(s)

[ ] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
22.11 Release Notes (or backporting 22.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module
[ ] (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes

[ ] Fits CONTRIBUTING.md.

A  change like this is still needed, but I have no idea how to make it pass ofborg eval.

libmpack was fixed in #187934
I created #196587 for ttmkfdir

This pr + a eval fix https://github.com/NixOS/nixpkgs/pull/341882


Replace DNSChecker with NSLookup

Description
This PR fixes the broken functionality of the DNS record 'Info' button by redirecting to NSLookup instead of DNSChecker.
Steps to test

Run the project locally
Create a DNS record
Click on the 'Info' icon for the given record:

https://user-images.githubusercontent.com/50856799/232312892-0c994f40-f516-4691-acb9-3426b7435eb6.mov

Does this fix a particular issue? I like the idea, I think it's a good change.

The issue wasn't filed, but it was discussed in one of last week's meetings. With DNSChecker, the user must also click the "Search" button to see the propagation data. However, with NSLookup, there isn't an extra step involved.


webpack / typings / Arcgis 3.18 / Angular2

Hi - My teammate is having trouble getting ClusterLayer.js (from esri examples) working in an Angular 2 app that uses Arcgis 3.18 and webpack. It looks like your 3.18 test app is written in pure JS and does not have a typings file for it. Can you please suggest ways we can get FlareClusterLayer working in our TypeScript environment using 3.18. We would upgrade to 4.1 but apparantly there are features not yet implemented in that version that we rely on. Thanks!

Hi @PivotalAnimal,
Is the problem you can't get the library to load in your app at all or is it that you just don't get intellisense as there's no typings file?
You should still be able to use it without a typings file. As it's just a dojo module, include it and load it up as an external reference like you would other external amd libraries. I have no useful experience with webpack, so can't offer any assistance there sorry. If you haven't seen it already this repository could help - https://github.com/tomwayson/angular2-esri-example.
If the problem is just the lack of a typings file - you could create one. Have it inherit from GraphicsLayer and just add the new public methods and properties. If you do create one, feel to create a PR to add it to the repository.
Hope this helps, Nick.

Hi @nickcam
I am looking into the option of creating a typings file. I tried this with ClusterLayer.js from esri but somehow their solution is still not working. Creating a typings file seems pretty straight forward. I think basically all it does is allow tsc to compile and at runtime doesnt' do anything. That being said, would I nee to include private (those marked with _) in this file or only those exposed by the UI (from the demo _v3 example). BTW - I did take a look at tom's solution previously. We are using snippets of his code to glue our solution together. Thanks for your help!
Kai

Issue solved. Thanks!

Awesome, glad you got it sorted!


Question about spacer direction

Dear Russel,
are the spacers correction for their orientation like CRISPRDetect/CRISPRDirection does?
With kind regards,
Daan

Dear Daan,
This is currently not implemented, but we are working on adding this as an extension.
However, I will also point you to this paper (https://doi.org/10.3389/fmicb.2019.02054), which suggests that the orientation most of the time matches with the orientation of the associated cas genes. In the cctyper output you can find the direction of the interference and adaptation modules. However, this criteria can obviously not be used for orphan arrays.
Best,
Jakob

Dear Jakob,
thank you for your response!
I will read up on it.
with kind regards,
Daan


enhancement: add simpleServing code for sentence transformers

PR types

New features
PR changes

APIs
Description

simpleServing example for sentence transformer(text matching)
#4776

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.Mu Tong seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.You have signed the CLA already but the status is still pending? Let us recheck it.

Hi, @MooTong123, Thank you for your contribution, Please sign the CLA assistant。

use pre-commit to check the code format before commit : https://pre-commit.com/


Keep window position

Try to keep window position on linux.
when closed to tray icon when reopened window is not on same position.

KDE Plasma workaround ;-)


Non reversible timestamp encoding

Hi, I'd like to ask, why it seems timestamp encoding is not reversible? I have the following failing test case (msgpack v 2.8.0)
If it matters, original serializedDate was produced by java codec
  it('date should be decoded and encoded back reversibly', () => {
    const serializedDate = Uint8Array.from([
      215, 255, 114, 232, 50, 224, 99, 47, 87, 235,
    ]);

    let decoded = decoder.decode(serializedDate);

    console.log(decoded); // 2022-09-24T19:18:03.481Z

    const encoded = encoder.encode(decoded);

    console.log(encoded, encoded.length); // Uint8Array(10) [215, 255, 114, 173, 233, 0, 99, 47, 87, 235] 10

    decoded = decoder.decode(encoded);

    console.log(decoded); // 2022-09-24T19:18:03.481Z

    expect(encoded).toStrictEqual(serializedDate);
  });

@pragmasoft-ua Hi, sorry to be my delayed response. That's an excellent question.
First of all, MessagePack is not defined as a strictly-reversible format, just like as JSON isn't. For example, a small integer 42 can be encoded in either fixint, int 8, int 16, int 32, int 64, or any of unsigned int types.
The timestamp type is not an exception. See https://github.com/msgpack/msgpack/blob/master/spec.md#timestamp-extension-type for details. A timestamp has three variants: 0xd6, 0xd7, and 0xc7. They are not exclusive so a timestamp could have two or more representations.
The implementation of the timestamp type in this library has another problem. Because JavaScript's Date does not have nanoseconds, it could drop nanosecond parts in encoded timestamps and thus it could not be reversible. JavaScript has a new datetime library called TC39 Temporal, so you can redefine the timestamp codec with temporal in theory. However, you should not expect a MessagePack encoded blob is reversible, anyway.


⚠ gorzdrav.org has degraded performance

In 06aabb7, gorzdrav.org (https://gorzdrav.org) experienced degraded performance:

HTTP code: 200
Response time: 4861 ms

Resolved: gorzdrav.org performance has improved in 4e0377a.


version 0.3.10 not installable

🐛 Bug Report
Running
deno install -Afq --unstable -n eggs<EMAIL_ADDRESS>
throws this error:
error: Emitted code for<EMAIL_ADDRESS>not found.

To Reproduce

Run this:

deno install -Afq --unstable -n eggs<EMAIL_ADDRESS>
Expected behavior

It should install the latest version.
Actual Behavior

It doesn't install the latest version, but instead throws an error.
Environment

Eggs version: 0.3.9
Deno version: 1.16.1
Operating system and version: macOS Montery beta 12.1 (21C5039b)

Additional context

Running
eggs upgrade

throws with this:
[CRIT] An unexpected error occurred: "Failed to upgrade to the latest CLI version!"
[INFO] Debug file created. (/Users/nnmrts/eggs-debug.log)
[INFO] If you think this is a bug, please open a bug report at https://github.com/nestdotland/eggs/issues/new/choose with the information provided in /Users/nnmrts/eggs-debug.log
[INFO] Visit https://docs.nest.land/eggs/ for documentation about this command.

This is the content of eggs-debug.log:
Arguments:
  upgrade

Deno version:
  deno: 1.16.1
  v8: <IP_ADDRESS>
  typescript: 4.4.2

Eggs version:
  0.3.9

Platform:
  x86_64-apple-darwin

2021-11-26T01:25:21.345Z [DEBUG]    stdout:  ""
2021-11-26T01:25:21.347Z [DEBUG]    stderr:  '\x1b[0m\x1b[1m\x1b[31merror\x1b[0m: Emitted code for<EMAIL_ADDRESS>not found.\n'
2021-11-26T01:25:21.353Z [CRITICAL] An unexpected error occurred: "Failed to upgrade to the latest CLI version!" "Error: Failed to upgrade to the latest CLI version!
    at Command.upgrade [as fn] (https://jzyko3slwfqdzjdsou33pfterimczldnatkgr5gbecmatum3y3yq.arweave.net/TnCnbkuxYDykcnU3t5ZkihgsrG0E1Gj0wSCYCdGbxvE/src/commands/upgrade.ts:44:11)
    at async Command.execute (https://jwhfb66f7jdbrh5zp6sooj57qz2ur7p3n4uipb3cs5s2tdpndy6q.arweave.net/TY5Q-8X6RhifuX-k5ye_hnVI_ftvKIeHYpdlqY3tHj0/command/command.ts:993:7)
    at async Command.parse (https://jwhfb66f7jdbrh5zp6sooj57qz2ur7p3n4uipb3cs5s2tdpndy6q.arweave.net/TY5Q-8X6RhifuX-k5ye_hnVI_ftvKIeHYpdlqY3tHj0/command/command.ts:914:16)
    at async https://jzyko3slwfqdzjdsou33pfterimczldnatkgr5gbecmatum3y3yq.arweave.net/TnCnbkuxYDykcnU3t5ZkihgsrG0E1Gj0wSCYCdGbxvE/eggs.ts:74:23"

Btw, running the same thing with 0.3.9 like this:
deno install -Afq --unstable -n eggs<EMAIL_ADDRESS>
does work as expected and installs eggs. So doesn't seem to be an issue with my system.

And since the actual source code of eggs between these two versions didn't change a lot, I suspect there was some form of breaking change in the dependencies that got updated.

Upgrading deno from 1.16.1 to 1.16.3 fixed the issue...


DBZ-6731 Document blocking snapshot signal configuration

related to: https://github.com/debezium/debezium/pull/4741

@mfvitale @roldanbob Applied, thanks

@mfvitale @roldanbob Applied, thanks

@jpechane Per his last comment, I think that @mfvitale had some concerns and was looking for a further edit. I was working on something yesterday, but I had not yet added it here.
Should I go ahead an submit a new PR for 6731 with changes to address those concerns.

@roldanbob I added a commit that tried to address them - https://github.com/debezium/debezium/pull/4769/commits/63fed8b8ffaa703c34b5213e87fa78a500706624
Feel free to change the text s necessary

@roldanbob I added a commit that tried to address them - 63fed8b

Ah, ok. I missed that. I'll take a look. Thanks, @jpechane!


Refactor code

Build is failing now, please check before we can proceed to merge.

@sak1997 Fixed failing test case


Add option to not generate lowercase identifiers

Our string keys are written in all caps, the generated identifiers look weird. I see that the SwiftIdentifier class has a default parameter to skip lowercasing (lowercaseStartingCharacters). Would be nice to configure this from the commandline.

Could you give an example of what happens now and what you would like to happen? All uppercase doesn't really feel right for the name of a property/struct.
Note that I've already made some casing changes that are not enabled by default, could you add the --edge flag and see if that suits you better?

Our string keys are like: "MENU_TITLE". This becomes R.strings.mENU_TITLE. I would like to keep the casing, so R.strings.MENU_TITLE.

Giving this a little thought I think adding a flag is not the way to go, R.swift should generate a sane default. Adding flag for these kind of things could easily end up in unmaintainable code and confusing combination of flags.
Since we are already changing the lowercasing behaviour I think that we could put in an exception there for all uppercase strings. If everything is uppercase we could choose to not lowercase anything. We should doublecheck that this doesn't make the compiler complain about uppercase names for properties or something like that.

Another example: we have features identified by acronyms, and prefix related classes and resources thusly. A storyboard might be named something like PHTModules for the primary home tab (PHT). The value in the generated struct in that case would be R.storyboard.pHTModules, which is kind of funky.

If you add the --edge flag to your call to R.swift you get the new naming convention, that will convert PHTModules to R.storyboard.phtModules. I think in most cases this will makes the names already look nicer.


YouTube: filter out videos by channel  - for mobile version

What filter does this issue target?
https://letsblock.it/filters/youtube-channel
What changes should be made?
support for channel filtering on m.youtube.com
Did you write a uBlock filter solving this?
to block @MikeBoyd from search results on m.youtube.com
m.youtube.com##ytm-search ytm-video-with-context-renderer:has(a[href$="@MikeBoyd"])
m.youtube.com##ytm-search ytm-compact-channel-renderer:has(a[href$="@MikeBoyd"])

this works perfectly
Additional notes
to block @MikeBoyd from homepage
m.youtube.com##ytm-browse ytm-rich-item-renderer:has(a[href$="@MikeBoyd"])
does not seem to be working for me. if someone can improve the homepage rule it would be great.

For the normal youtube site are the rule
www.youtube.com##ytd-browse[page-subtype="home"] ytd-rich-item-renderer:has(a[href$="{{ . }}"])
www.youtube.com##ytd-search ytd-video-renderer:has(a[href$="{{ . }}"])
www.youtube.com##ytd-search ytd-channel-renderer:has(a[href$="{{ . }}"])

can you test if those rule but without the www also work for the mobile version?

can you test if those rule but without the www also work for the mobile version?

no these dont work with m.youtube.com.
but i was able to modify the last 2 rules. these work with m.youtube.com:
m.youtube.com##ytm-search ytm-video-with-context-renderer:has(a[href$="{{ . }}"])
m.youtube.com##ytm-search ytm-compact-channel-renderer:has(a[href$="{{ . }}"])

How does the rule starting with m. not work?
What is the url displayed on your mobile?

apologies. did some more testing & m. rule is working as well. i perhaps accidently switched to the desktop version yesterday.
m.youtube.com##ytm-browse ytm-rich-item-renderer:has(a[href$="{{ . }}"])
m.youtube.com##ytm-search ytm-video-with-context-renderer:has(a[href$="{{ . }}"])
m.youtube.com##ytm-search ytm-compact-channel-renderer:has(a[href$="{{ . }}"])

these are working well.


Update webviews

Fixes #262
Fixes #264
Updates @appland/components to the most recent version:

[x] Users now see the new sign-in webview that has removed the "Not Ready to Sign-In?" toggle, but still has the "Security FAQ" link.
[x] Users can now expand packages in sequence diagrams.

:tada: This PR is included in version 0.35.0 :tada:
The release is available on:

v0.35.0
GitHub release

Your semantic-release bot :package::rocket:


google_maps_flutter demo: Authorization failure.

The instructions for using https://github.com/flutter/plugins/tree/master/packages/google_maps_flutter#getting-started may possibly be  incomplete.
I used the simple flutter code on that page, and at runtime got this error :
E/GoogleMapController( 1644): Cannot enable MyLocation layer as location permissions are not granted
E/Google Maps Android API( 1644): Authorization failure.  Please see https://developers.google.com/maps/documentation/android-api/start for how to correctly set up the map.
E/Google Maps Android API( 1644): In the Google Developer Console (https://console.developers.google.com)
E/Google Maps Android API( 1644): Ensure that the "Google Maps Android API v2" is enabled.
E/Google Maps Android API( 1644): Ensure that the following Android Key exists:
E/Google Maps Android API( 1644): 	API Key: [my-generated-api-key]
E/Google Maps Android API( 1644): 	Android Application (<cert_fingerprint>;<package_name>): 08:82:BF:08:90:97:E0:94:27:A7:E0:9C:66:1A:43:7E:4A:E4:6E:A8;com.example.fluttercatalog
W/DynamiteModule( 1644): Local module descriptor class for com.google.android.gms.googlecertificates not found.
I/DynamiteModule( 1644): Considering local module com.google.android.gms.googlecertificates:0 and remote module com.google.android.gms.googlecertificates:4
I/DynamiteModule( 1644): Selected remote version of com.google.android.gms.googlecertificates, version >= 4

I generated an API key for Google Maps, at the Google Cloud Platform Console, which I placed in  the AndroidManifest.xml, and I have enabled the Maps SDK for Android.
The app error message (above) suggested that I should specify some Application Restriction on the API (although at that point there was no restriction).  So I went back to the Cloud Console and added an (Android) Application restriction to the API Key, entering the same package_name and cert_fingerprint that was printed in the error message.
Doing this made no change - the same error occurred.
Note that I'm running this in dev and haven't signed any APKs.
Is it possible that there is another step that is obvious to all experienced Flutter/Maps-API devs that needs to be performed to get the demo to run, but that wasn't explicitly stated?

The first line seems to be about permissions you can request by a plugin like https://pub.dartlang.org/packages/permission (there are others)

specify some Application Restriction

from what part of the error message did you derive that?

from what part of the error message did you derive that?

The line that says:
    E/Google Maps Android API( 1644): 	Android Application (<cert_fingerprint>;<package_name>):08:82:BF:08:90:97:E0:94:27:A7:E0:9C:66:1A:43:7E:4A:E4:6E:A8;com.example.fluttercatalog
I've just realised what I was doing wrong.  In the API Console, I had restricted access to some of the APIs because I thought they weren't being used.  The ones I had disabled were

Roads API
Service Usage API
Service Management API
Stackdriver * APIs
Street View * APIs
Timezone API

I just went back and enabled all the APIs and the app error was fixed.
This is a bit puzzling because I didn't think these APIs would be needed for Maps, but I was mistaken.
Oh well, live and learn.
Thanks anyway, for your fast response.

Interestingly enough, none of the APIs that I had disabled are actually being hit, as shown by the API dashboard.  Only the Maps SDK for Android records any requests against it, which is what I had expected.

I just ran into the same problem building the place_tracker app on an android emulator. I was able to fix it just by uninstalling and rebuilding the app. The first build took a considerable time because I did it on a small laptop with another memory intense program running at the same time.
On my main development machine I have never seen that error.

I have no problem with authorization but map is not rendering, just white screen.
I see this warning on terminal: E/GoogleMapController( 7561): Cannot enable MyLocation layer as location permissions are not granted
flutter doctor -v
[√] Flutter (Channel stable, v1.0.0, on Microsoft Windows [Version 10.0.17134.590], locale ru-RU)
    • Flutter version 1.0.0 at C:\progs\flutter
    • Framework revision 5391447fae (3 months ago), 2018-11-29 19:41:26 -0800
    • Engine revision 7375a0f414
    • Dart version 2.1.0 (build 2.1.0-dev.9.4 f9ebf21297)

[√] Android toolchain - develop for Android devices (Android SDK 28.0.3)
    • Android SDK at C:\Users\ProsoftPC\AppData\Local\Android\sdk
    • Android NDK location not configured (optional; useful for native profiling support)
    • Platform android-28, build-tools 28.0.3
    • Java binary at: C:\Program Files\Android\Android Studio\jre\bin\java
    • Java version OpenJDK Runtime Environment (build 1.8.0_152-release-1248-b01)
    • All Android licenses accepted.

[√] Android Studio (version 3.3)
    • Android Studio at C:\Program Files\Android\Android Studio
    • Flutter plugin version 32.0.1
    • Dart plugin version 182.5215
    • Java version OpenJDK Runtime Environment (build 1.8.0_152-release-1248-b01)

[√] VS Code (version 1.31.1)
    • VS Code at C:\Users\ProsoftPC\AppData\Local\Programs\Microsoft VS Code
    • Flutter extension version 2.23.1

[√] Connected device (1 available)
    • Android SDK built for x86 • emulator-5554 • android-x86 • Android 9 (API 28) (emulator)

• No issues found!

what error are you seeing

I am facing the same issue. It has intermittent behaviour. Already tried different permissions library but it is not going away. Also tried putting permission directly in AndroidManifest.xml but still facing the same issue.

In my case, the error was due to the Maps SDK for Android API being disabled. After enabling the API in the  Google Cloud Platform Console the app started normally.

@zoechi can you please check and help tried above methods but none of these worked for me !

It seems like maps plugin using "internal" key for signing, I've restricted API_KEY for both my debug and release SHA1 and in the error message there are different, from my, SHA1

Trying to clarify here --- it looks like some folks had problems with key provisioning, which are outside of flutter. @DenisBogatirov, are you indicating that there's a problem with the plugin itself as well?

Without additional information, we are unfortunately not sure how to resolve this issue. We are therefore reluctantly going to close this bug for now. Please don't hesitate to comment on the bug if you have any more information for us; we will reopen it right away!
Thanks for your contribution.


fix ranking links in ranking demo dataset

This isn't the first time the Dropbox links have broken right? Does anyone know why this might be happening?
@RobustIntelligence/ml

ooc did you discover this by running the ranking nb? would be weird bc it worked for me yesterdday

ooc did you discover this by running the ranking nb? would be weird bc it worked for me yesterdday

maybe dropbox is just being uncooperative but im getting 400 errors https://colab.research.google.com/drive/1avKr83vnrtX8klH74h6JT6pLKbu5Q0Y7#scrollTo=YilAj33W_5y-


train on linux ,then view the result through webui on windows10

recently l carry out examples\trials\mnist on linux GPU,the result is normal and is also right on linux,but l want to view the training process through webui on windows10.l use the command: ssh -p <remote_port> -L 8888:<IP_ADDRESS>:8888 @<remote_ip>,when l login in <IP_ADDRESS>:8888 on windows,unexpectedly,l get the message that  our access is refused  by <IP_ADDRESS>, that is why?
l have another example that l run my NER project in the same manner, the status is always INITIALIZED for several hours,do you tell me the reason? As a result,
l can login the website of Neural Network Intelligence on windows,  there is the head of the webui , however, the context of webui is empty,that is why as well?

of course, l know NNI's default port is 8080,but it is what you want only to reseted again by the command -p or --port, this is not important

is anyone successful about training  models on linux even mnist?

@wshzd   Probably you want to firstly check your network and ssh forwarding configuration using other simple program such as python -m http.server,   then double check the webui  URL from nnictl command output.

@wshzd yes, our lab does it all the time though we don't use port forwarding (nni listens on external ip by default so we just access server/port directly).

@Markus92 yes ,access server/port directly, a blog confuse me, thank you very much.


net .6?

are you targetting net6 now but didn't update the read me? Took me a while to realise it.

#413 updates the README file. Closing this issue now.


Need speed during mountian pass race

@dallmeyer https://github.com/Zedb0T/TheFlutFlutLegacy/pull/24#issuecomment-1242985829

solved with the ice physics?


Bugfix: date fields aren't displaying correctly in the buyer app

Date fields aren't being styled correctly because the .scss files were re-ordered in this commit.
Making the styles more specific would make sure the styles aren't dependent on the order the files are imported.
Trello card.
the fields are too wide 😞

 Date fields are too long

Sorry about that :/
But we really shouldn't rely on order of imports for anything.
This looks legit :+1:


Allows IndexedSlices to be fed and fetched.

Addresses issue #518.
Both ops.IndexedSlicesValue and ops.IndexedSlicesWithoutDenseShapeValue are needed because None can't fed as a subfeed value (see https://github.com/tensorflow/tensorflow/blob/master/tensorflow/python/client/session.py#L357)

Can one of the admins verify this patch?

Hi Kenton,
Thanks for resubmitting this as a pull request, and for adding the tests. I'd like to push a bit harder against IndexedSlicesWithoutDenseShapeValue. I've added some comments to ops.py that suggest where the problem with returning None could be addressed, and I'd prefer to address those internally. (Ideally all IndexedSlices would have dense shapes, but for the meantime we could address this with a helpful error message in the case that the fed value doesn't match the object being fed.)
Derek.

Thanks for reviewing this. If I understand your proposed solution correctly, fetching would fail if we use
lambda fetched_vals:
  ops.IndexedSlicesValue(fetched_vals[0], fetched_values[1], fetched_values[2] if len(fetched_vals) == 3 else None)

since this call: https://github.com/tensorflow/tensorflow/blob/master/tensorflow/python/client/session.py#L321 would result in a TypeError due to subfetch being None. Or am I misinterpreting something?

Not quite: I was suggesting that, in the event IndexedSlices doesn't have a dense_shape, the fetch function would return a list of two "subfetch" tensors (the indices and values), instead of returning None for the dense_shape.

The latest version implements your suggestions along with relevant changes to the tests.

Thanks for indulging me! :)
This LGTM, so I'll go ahead and merge it.


Thread-safe HttpKnownHeaderNames initialization

PR Summary
Fix #15513
Move HttpKnownHeaderNames initialization to static constructor.
PR Context
See #15513.
PR Checklist

[x] PR has a meaningful title

Use the present tense and imperative mood when describing your changes

[x] Summarized changes
[x] Make sure all .h, .cpp, .cs, .ps1 and .psm1 files have the correct copyright header
[x] This PR is ready to merge and is not Work in Progress.

If the PR is work in progress, please add the prefix WIP: or [ WIP ] to the beginning of the title (the WIP bot will keep its status check at Pending while the prefix is present) and remove the prefix when the PR is ready.

Breaking changes

[x] None
OR
[ ] Experimental feature(s) needed

[ ] Experimental feature name(s):

User-facing changes

[x] Not Applicable
OR
[ ] Documentation needed

[ ] Issue filed:

Testing - New and feature

[x] N/A or can only be tested interactively
OR
[ ] Make sure you've added a new test if existing tests do not effectively test the code changed

Tooling

[ ] I have considered the user experience from a tooling perspective and don't believe tooling will be impacted.
OR
[ ] I have considered the user experience from a tooling perspective and opened an issue in the relevant tool repository. This may include:

[ ] Impact on PowerShell Editor Services which is used in the PowerShell extension for VSCode
(which runs in a different PS Host).

[ ] Issue filed:

[ ] Impact on Completions (both in the console and in editors) - one of PowerShell's most powerful features.

[ ] Issue filed:

[ ] Impact on PSScriptAnalyzer (which provides linting & formatting in the editor extensions).

[ ] Issue filed:

[ ] Impact on EditorSyntax (which provides syntax highlighting with in VSCode, GitHub, and many other editors).

[ ] Issue filed:

Even with this, the hashset will still be accessed from multiple threads concurrently in the cases given in #15513, won't it? We should probably add a test using the code samples in the issue to verify that this is sufficient to resolve it. Since the user reporting it mentioned that it was a bit intermittent, we should repeat their test a few times in our own tests.

Even with this, the hashset will still be accessed from multiple threads concurrently in the cases given in #15513, won't it?

A root of the issue was that second thread read the HashSet while first thread still initializes the HashSet.
The HashSet is used only in one place for reading so no need to concern more about race conditions.

We should probably add a test

It's not worth it. We will not be able to make such tests stable and defensible. Please use compiled artifact to check locally.

Even with this, the hashset will still be accessed from multiple threads concurrently in the cases given in #15513, won't it?

A root of the issue was that second thread read the HashSet while first thread still initializes the HashSet.
The HashSet is used only in one place for reading so no need to concern more about race conditions.

We should probably add a test

It's not worth it. We will not be able to make such tests stable and defensible. Please use compiled artifact to check locally.

If the only writes are the ones when the object is generated :
s_contentHeaderSet.Add(HttpKnownHeaderNames.Allow);
s_contentHeaderSet.Add(HttpKnownHeaderNames.LastModified);
I think the write race condition is eliminated with this change.
I am a C# dev, but I have zero knowledge on the Powershell source code. Help I could help you somehow.

I am a C# dev, but I have zero knowledge on the Powershell source code. Help I could help you somehow.

PowerShell is great project to improve skills. It's too big to learn it well in a short time but you can pick an area you like best and work there with some workgroup https://devblogs.microsoft.com/powershell/powershell-working-groups/
After monitoring issues and PRs for about a month you will be able to make good contributions.

@daxian-dbw Could you please review?

@SteveL-MSFT Could you please approve? It is impossible to merge without green flag :-)

I see that there's a pending review from @daxian-dbw
Is there anything else you need from me?
Thank you

@TravisEz13 Please review/approve.


Develop

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.deepthi-ps seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.You have signed the CLA already but the status is still pending? Let us recheck it.


fix a wrong usage of spinel_datatype_unpack

In current implementation of spinel parser, SPINEL_DATATYPE_EUI64_S only accepts a pointer to a const pointer to receive the address of eui64 in spinel data packets. However in RemovePropertyHandler_MAC_WHITELIST an pointer to otExtAddress is passed in which may cause unexpected results. This PR corrects this issue.
Besides, I'm also preparing a PR to let spinel parser support fill unpacked value to the user provided memory. This is useful when implementing an synchronized version of higher level API for getting spinel property. The prototype would be something like this,
ThreadError
xxxGetProp(otInstance *aInstance,
spinel_prop_key_t aKey, const char* aFormat, ...);

Codecov Report

Merging #1575 into master will decrease coverage by 1.37%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master    #1575      +/-   ##
==========================================
- Coverage   71.45%   70.08%   -1.38%
==========================================
  Files         154      159       +5
  Lines       18354    20134    +1780
  Branches     2257     2478     +221
==========================================
+ Hits        13115    14111     +996
- Misses       4427     5120     +693
- Partials      812      903      +91

Impacted Files
Coverage Δ

src/ncp/ncp_base.cpp
36.72% <100%> (ø)

src/core/coap/coap_client.hpp
66.66% <0%> (-7.02%)
:arrow_down:

src/core/thread/mesh_forwarder.cpp
78.67% <0%> (-0.25%)
:arrow_down:

src/core/net/dns_headers.hpp
0% <0%> (ø)
:arrow_up:

src/ncp/ncp_uart.cpp
73.75% <0%> (ø)

src/ncp/hdlc.cpp
76.34% <0%> (ø)

src/ncp/ncp_base.hpp
0% <0%> (ø)

examples/apps/ncp/main.c
100% <0%> (ø)

src/core/net/ip6_mpl.hpp
97.77% <0%> (+0.05%)
:arrow_up:

... and 28 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fbdb812...c782ce6. Read the comment docs.

I named it following naming convention in the file. @nibanks


Declare variable ‘ruleLength’

Fixes the issue when using validate.js in ES6 modules, which are implicitly in strict mode.
Validator failed silently.
Only when calling the method _validateForm() an error was thrown.

Thanks1


feat: create a one-click script for quick start

Signed-off-by: Bird<EMAIL_ADDRESS>Pre-Checklist
Note: please complete ALL items in the following checklist.

[x] I have read through the CONTRIBUTING.md documentation.
[x] My code has the necessary comments and documentation (if needed).
[ ] I have added relevant tests

Description
Create a one-click script for quick start. Execute these steps in one script:

Download latest dtm release according to OS and CPU arch.
Rename release to "dtm".
Download quickstart.yaml.
Show dtm help.

Related Issues
close #769
New Behavior (screenshots if needed)
❯ sh quickstart.sh
Got OS type: darwin and CPU arch: arm64
Latest dtm release version: v0.7.0
Downloading dtm from: https://devstream.gateway.scarf.sh/releases/v0.7.0/dtm-darwin-arm64
  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed
  0     0    0     0    0     0      0      0 --:--:-- --:--:-- --:--:--     0
  0     0    0     0    0     0      0      0 --:--:--  0:00:01 --:--:--     0
100 22.2M  100 22.2M    0     0  3386k      0  0:00:06  0:00:06 --:--:-- 5728k
dtm downloaded completed
  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed
100   986  100   986    0     0   1146      0 --:--:-- --:--:-- --:--:--  1157

DevStream is an open-source DevOps toolchain manager

######                 #####
#     # ###### #    # #     # ##### #####  ######   ##   #    #
#     # #      #    # #         #   #    # #       #  #  ##  ##
#     # #####  #    #  #####    #   #    # #####  #    # # ## #
#     # #      #    #       #   #   #####  #      ###### #    #
#     # #       #  #  #     #   #   #   #  #      #    # #    #
######  ######   ##    #####    #   #    # ###### #    # #    #

Usage:
  dtm [command]

Available Commands:
  apply       Create or update DevOps tools according to DevStream configuration file
  completion  Generate the autocompletion script for dtm for the specified shell
  delete      Delete DevOps tools according to DevStream configuration file
  destroy     Destroy DevOps tools deployment according to DevStream configuration file & state file
  develop     Develop is used for develop a new plugin
  help        Help about any command
  init        Download needed plugins according to the config file
  list        This command only supports listing plugins now.
  show        Show is used to print some useful information
  verify      Verify DevOps tools according to DevStream config file and state
  version     Print the version number of DevStream

Flags:
      --debug   debug level log
  -h, --help    help for dtm

Use "dtm [command] --help" for more information about a command.

@IronCore864 Please review, give more advice, and update the corresponding English documentation. Thank you! ❤


Develop ERD Diagram

Create the Entity-Relationship Diagram (ERD)

Here is the final ERD for the Back up project.
ERD.zip


http2: Add compliance test for header values

Risk Level: Low, Test Only
Testing: Unit Tests
Docs Changes: N/A
Release Notes: N/A
Platform Specific Features: N/A
Signed-off-by: Yan Avlasov<EMAIL_ADDRESS>

/retest


Improvements

Sorry, I thought I was making a pull request to my fork, between branches :)

I'd be grateful if you could delete this PR

Hi, I don't think there's an option to delete the PR. Maybe if you delete the branch on your side?


[DDW-565] only update expanded tx rows that are rendered

This PR fixes the small bug in my original virtual tx list rendering logic (ensure that visible expanded tx rows are always updated correctly)
Review Checklist:
Basics

[ ] PR is updated to the most recent version of target branch (and there are no conflicts)
[ ] PR has good description that summarizes all changes and shows some screenshots or animated GIFs of important UI changes
[ ] CHANGELOG entry has been added and is linked to the correct PR on GitHub
[ ] Automated tests: All acceptance tests are passing (yarn run test)
[ ] Manual tests (minimum tests should cover newly added feature/fix): App works correctly in development build (yarn run dev)
[ ] Manual tests (minimum tests should cover newly added feature/fix): App works correctly in production build (yarn run package / CI builds)
[ ] There are no flow errors or warnings (yarn run flow:test)
[ ] There are no lint errors or warnings (yarn run lint)
[ ] Text changes are proofread and approved (Jane Wild)
[ ] There are no missing translations (running yarn run manage:translations produces no changes)
[ ] UI changes look good in all themes (Alexander Rukin)
[ ] Storybook works and no stories are broken (yarn run storybook)
[ ] In case of dependency changes yarn.lock file is updated

Code Quality

[ ] Important parts of the code are properly documented and commented
[ ] Code is properly typed with flow
[ ] React components are split-up enough to avoid unnecessary re-rendering
[ ] Any code that only works in Electron is neatly separated from components

Testing

[ ] New feature / change is covered by acceptance tests
[ ] All existing acceptance tests are still up-to-date
[ ] New feature / change is covered by Daedalus Testing scenario
[ ] All existing Daedalus Testing scenarios are still up-to-date

After Review:

[ ] Merge PR
[ ] Delete source branch
[ ] Move ticket to done on the Youtrack board

Closing this PR unmerged in favour of https://github.com/input-output-hk/daedalus/pull/1312


Add School Centre Nova Gorica

Our school's site: http://www.scng.si/

@AlenLoeb I corrected the filepath. Pull request merged. Thank you!

Hi!
Unfortunately our school email address doesn't have an email service like
gmail. If possible, I would like you to resend the message from
@.*** to this email instead.
Best regards,
Alen Leban
V V sre., 17. mar. 2021 ob 14:39 je oseba Philip Torchinsky <
@.***> napisala:

@AlenLoeb https://github.com/AlenLoeb I corrected the filepath. Pull
request merged. Thank you!
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/JetBrains/swot/pull/11005#issuecomment-801088152, or
unsubscribe
https://github.com/notifications/unsubscribe-auth/AILURMQYKDROT6DCRFTUFCDTECWJDANCNFSM4ZD52QVA
.


Operation timed out when previewing data in dataset setup

Hi,
When creating the WWISftpParquet dataset using the dynamic parameters at this stage below and then trying to Preview data the process is failing and has been returning a 'the operation timed out' message for the last few days.  However the sftp linked service behind the connection passes its test connection ok.
https://github.com/Mmodarre/AzureDataFactoryHOL/tree/master/Lab-guide/02-Linked_Services_Datasets_and_Integration_Runtimes#create-datasets-for-wwi-sftp-data
Thanks

Sorry, saw this already opened and closed, customers files working ok.

I tested the orderlines which is the biggest of all dateset and it is working. The only thing the SFTP server is in US West2 and I'd recommend either create your IR in that region or use Azure Auto resolve if you faced any issues.

Thank you.
Ruairi
On Mon, 1 Jun 2020 at 01:42, Mmodarre<EMAIL_ADDRESS>wrote:

[image: image]
https://user-images.githubusercontent.com/23395096/83366741-57497100-a3f4-11ea-988a-0fdc07d7a053.png
I tested the orderlines which is the biggest of all dateset and it is
working. The only thing the SFTP server is in US West2 and I'd recommend
either create your IR in that region or use Azure Auto resolve if you faced
any issues.
—
You are receiving this because you modified the open/close state.
Reply to this email directly, view it on GitHub
https://github.com/Mmodarre/AzureDataFactoryHOL/issues/22#issuecomment-636557660,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AINTFTIPOJYUZ4ZN6BDDVK3RUL2ONANCNFSM4NOEFZ7Q
.


[Hub Generated] Review request for Microsoft.MachineLearningServices to update version preview/2021-03-01-preview with new enum values

This is a PR generated at OpenAPI Hub. You can view your work branch via this link.
Changelog
Add a changelog entry for this PR by answering the following questions:

What's the purpose of the update?

[ ] new service onboarding
[ ] new API version
[x] update existing version for new feature
[ ] update existing version to fix swagger quality issue in s360
[ ] Other, please clarify

Adding new enum values to an existing API version.

When are you targeting to deploy the new service/feature to public regions? Please provide the date or, if the date is not yet available, the month.

We plan to deploy this enum change as soon as possible.

When do you expect to publish the swagger? Please provide date or, the the date is not yet available, the month.

We'll merge this PR as soon as it's approved.

If updating an existing version, please select the specific language SDKs and CLIs that must be refreshed after the swagger is published.

[ ] SDK of .NET (need service team to ensure code readiness)
[ ] SDK of Python
[ ] SDK of Java
[ ] SDK of Js
[ ] SDK of Go
[ ] PowerShell
[ ] CLI
[ ] Terraform
[ ] No refresh required for updates in this PR

Contribution checklist:

[x] I commit to follow the Breaking Change Policy of "no breaking changes"
[x] I have reviewed the documentation for the workflow.
[x] Validation tools were run on swagger spec(s) and errors have all been fixed in this PR. How to fix?

If any further question about AME onboarding or validation tools, please view the FAQ.
ARM API Review Checklist

Applicability: :warning:
If your changes encompass only the following scenarios, you should SKIP this section, as these scenarios do not require ARM review.

Change to data plane APIs
Adding new properties
All removals

Otherwise your PR may be subject to ARM review requirements. Complete the following:

[ ] Check this box if any of the following apply to the PR so that label "WaitForARMFeedback" will be added automatically to begin ARM API Review. Failure to comply may result in delays to the manifest.

Adding a new service
Adding new API(s)
Adding a new API version
-[ ] To review changes efficiently, ensure you are using OpenAPIHub to initialize the PR for adding a new version. More details, refer to the wiki.

[ ] Ensure you've reviewed following guidelines including ARM resource provider contract and REST guidelines. Estimated time (4 hours). This is required before you can request review from ARM API Review board.

[ ] If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.

Breaking Change Review Checklist
If any of the following scenarios apply to the PR, request approval from the Breaking Change Review Board as defined in the Breaking Change Policy.

[ ] Removing API(s) in a stable version
[ ] Removing properties in a stable version
[ ] Removing API version(s) in a stable version
[ ] Updating API in a stable or public preview version with Breaking Change Validation errors
[ ] Updating API(s) in public preview over 1 year (refer to Retirement of Previews)

Action: to initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Addition details on the process and office hours are on the Breaking change Wiki.
Please follow the link to find more details on PR review process.

The "SDK azure-sdk-for-net" and "SDK azure-sdk-for-net-track2" checks appear to be failing/crashing with internal errors.
For the "Swagger SDK Breaking Change Tracking" check, I'm not sure what it's using as the basis for comparison, since it's complaining about "Model AmlComputeNodesInformation no longer has parameter compute_type" and a lot of other similar things that I'm definitely not touching in this six-line PR.

/azp run unifiedPipeline


Java exited code 1

When I install this plugin in android project there is many issues appear :

Restore packages failed ,
Version conflict detected for Xamarin.Android.Support.Compat. Install/reference Xamarin.Android.Support.Compat <IP_ADDRESS> directly to project Alhayatisp.Android to resolve this issue.
myspp.Android -> Plugin.FirebasePushNotification 3.4.1 -> Xamarin.Android.Support.v4 <IP_ADDRESS> -> Xamarin.Android.Support.Compat (= <IP_ADDRESS>)
myapp.Android -> Alhayatisp -> Xamarin.Forms.GoogleMaps 3.3.0 -> Xamarin.Android.Support.v7.AppCompat 25.1.0 -> Xamarin.Android.Support.Compat (= 25.1.0).
Restore failed.
I tried to create new android app and get the java exited code 1 error .
more than 3 projects I created and in each time the errors caused by the last version of Plugin Firebase push notification

Look at #411 if you use Android 12

Look at #411 if you use Android 12

I tried to add the code suggested in #411
<!-- Necessary for Plugin.FirebasePushNotification --> 		<service android:name="crc6494e14b9856016c30.PNFirebaseMessagingService" android:exported="true" tools:node="merge"> 			<intent-filter> 				<action android:name="com.google.firebase.MESSAGING_EVENT" /> 			</intent-filter> 		</service>
but I still get the Java exited code 1 error. Any suggestions?


HHH-10515 - Stored procedure execution fails to find column

https://hibernate.atlassian.net/browse/HHH-10515
@sebersole @vladmihalcea this is a second proposal using a new Dialect method

Looks good. Just the test class name should be probably changed.

I was running this test using the new DB env support that I added. You can try it out too and give me some feedback. Check the mailing list for more details ;)

Thanks @vladmihalcea,
but not sure what solution is betterm this one or the https://github.com/hibernate/hibernate-orm/pull/1264

I prefer adding a Dialect method over adding a new configuration property.
@sebersole, wdyt?

@gbadner,
I hope the new changes meet what you were suggesting.
Thanks for the review.

@dreab8 I've opened a new pull request that includes your commits: /github.com/hibernate/hibernate-orm/pull/1412. In addition, it covers the case where JDBC DatabaseMetadata is not available.
Please take a look.
Thanks,
Gail


License file needed

I am using keypgp (thanks!) which depends on the bn package.  However, bn does not specify a license.  Would the same license as kbpgp be acceptable?

yes, assume the same as kbpgp for now..

  Thanks for the crazy quick response!

You may want to update the package.json as well to reflect the new license type.  Much appreciated!

Sorry to pester, but the license key is in the package.json twice with both the new and old values.

done
On Wed, Apr 12, 2017 at 3:54 PM, chrisegner<EMAIL_ADDRESS>wrote:

Sorry to pester, but the license key is in the package.json twice with
both the new and old values.
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/keybase/bn/issues/3#issuecomment-293689078, or mute
the thread
https://github.com/notifications/unsubscribe-auth/AA05__N6ygbBGOfGL-gEwmQO_5pVgotUks5rvSvqgaJpZM4M72e_
.

This looks resolved in e26bd64445346273008dba0372d568703c4bcd00.  But who's Thomas Wu?

Oh I see, Tom Wu is original author of this JavaScript Big Number library:

The jsbn library is a fast, portable implementation of large-number math in pure JavaScript, enabling public-key crypto and other applications on desktop and mobile browsers.

Documenting this observation in the name of open source 👍


[WIP] Chinese Translation

[ ] zh/medium-combination.md
[ ] zh/medium-construct-tuple.md
[ ] zh/medium-fibonacci-sequence.md
[ ] zh/medium-fill.md
[ ] zh/medium-flattendepth.md
[ ] zh/medium-flip-arguments.md
[ ] zh/medium-flip.md
[ ] zh/medium-greater-than.md
[ ] zh/medium-indexof.md
[ ] zh/medium-inordertraversal.md
[ ] zh/medium-istuple.md
[ ] zh/medium-join.md
[ ] zh/medium-kebabcase.md
[ ] zh/medium-lastindexof.md
[ ] zh/medium-length-of-string.md
[ ] zh/medium-maptypes.md
[ ] zh/medium-minusone.md
[ ] zh/medium-mutable.md
[ ] zh/medium-nomiwase.md
[ ] zh/medium-number-range.md
[ ] zh/medium-objectentries.md
[ ] zh/medium-omitbytype.md
[ ] zh/medium-partialbykeys.md
[ ] zh/medium-percentage-parser.md
[ ] zh/medium-permutation.md
[ ] zh/medium-promise-all.md
[ ] zh/medium-remove-index-signature.md
[ ] zh/medium-requiredbykeys.md
[ ] zh/medium-reverse.md
[ ] zh/medium-shift.md
[ ] zh/medium-string-to-union.md
[ ] zh/medium-subsequence.md
[ ] zh/medium-trim-right.md
[ ] zh/medium-trunc.md
[ ] zh/medium-tuple-to-nested-object.md
[ ] zh/medium-unique.md
[ ] zh/medium-without.md
[ ] zh/medium-zip.md
[x] easy-awaited.md
[x] easy-concat.md
[x] easy-exclude.md
[x] easy-first.md
[x] easy-if.md
[x] easy-includes.md
[x] easy-parameters.md
[x] easy-pick.md
[x] easy-push.md
[x] easy-readonly.md
[x] easy-tuple-length.md
[x] easy-tuple-to-object.md
[x] easy-unshift.md
[x] hard-camelcase.md
[x] medium-absolute.md
[x] medium-anyof.md
[x] medium-append-argument.md
[x] medium-append-to-object.md
[x] medium-bem-style-string.md
[x] medium-capitalize.md
[x] medium-chainable-options.md
[x] medium-chunk.md
[x] medium-deep-readonly.md
[x] medium-diff.md
[x] medium-drop-char.md
[x] medium-endswith.md
[x] medium-flatten.md
[x] medium-isnever.md
[x] medium-isunion.md
[x] medium-last.md
[x] medium-merge.md
[x] medium-omit.md
[x] medium-pickbytype.md
[x] medium-pop.md
[x] medium-readonly-2.md
[x] medium-replace.md
[x] medium-replaceall.md
[x] medium-replacekeys.md
[x] medium-return-type.md
[x] medium-startswith.md
[x] medium-trim.md
[x] medium-trimleft.md
[x] medium-tuple-to-union.md
[x] medium-type-lookup.md
[x] warm-hello-world.md

Hello,
I'd like to help with the chinese translations. should I translate from the english version ?
For those that didn't exist at all in any language, Should I give my own solution ?

Hey @SUtengda, yes, the English version is the source of truth. Regard to your own solutions, you can post them, yes. However, bear in mind, that it MUST be incremental solution with explanation to each step. If you can write a post like this, we can work together towards adding new explanations.

@ghaiklor Hello again, how should I get the permission for being able to create new branch and push pls ?

@SUtengda you can make a fork and contribute from there

@SUtengda hi there, we have 2 workflows for Chinese translation
Workflow No. 1

Check a solution within this issue
Do the translation locally and other stuff
Push the translation
Assign a review
Push the potential suggestions and wait for approve
Merge PR when able to

Workflow No. 2

Push a WIP draft PR
Do the translation locally and other stuff
Push the translation when you're done
Make the PR open to review
Assign a review
Push the potential suggestions and wait for approve
Merge PR when able to
Mark the solution DONE within this issue

Guys, do you use this issue for tracking? If this is stale, let's close it.

@ghaiklor Might consider updating the list:

`EN` pending:

zh/medium-combination.md
zh/medium-construct-tuple.md
zh/medium-fibonacci-sequence.md
zh/medium-fill.md
zh/medium-flattendepth.md
zh/medium-greater-than.md
zh/medium-indexof.md
zh/medium-istuple.md
zh/medium-join.md
zh/medium-lastindexof.md
zh/medium-nomiwase.md

`EN` ready, `ZH` pending:

zh/medium-flip.md
zh/medium-inordertraversal.md
zh/medium-kebabcase.md
zh/medium-length-of-string.md
zh/medium-maptypes.md
zh/medium-minusone.md
zh/medium-mutable.md
zh/medium-number-range.md
zh/medium-objectentries.md
zh/medium-omitbytype.md
zh/medium-partialbykeys.md
zh/medium-percentage-parser.md
zh/medium-permutation.md
zh/medium-promise-all.md
zh/medium-remove-index-signature.md
zh/medium-requiredbykeys.md
zh/medium-reverse.md
zh/medium-shift.md
zh/medium-string-to-union.md
zh/medium-subsequence.md
zh/medium-trim-right.md
zh/medium-trunc.md
zh/medium-tuple-to-nested-object.md
zh/medium-unique.md
zh/medium-without.md
zh/medium-zip.md

Done:

zh/medium-drop-char.md
zh/medium-isnever.md
zh/medium-isunion.md
zh/medium-readonly-2.md
zh/medium-replace.md
zh/medium-replaceall.md
zh/medium-replacekeys.md
zh/medium-tuple-to-union.md
zh/medium-type-lookup.md

PR ready:

zh/medium-flip-arguments.md #234

@S1ngS1ng done

Closing this one as stale


fix wrong duration showed for image import

Addressed git issue  #668

/ok-to-test

Hi @arshadd-b,
Thanks for the PR.
Changes look good to me.

Hi @mkumatag.
I think these are two discrete events that are timed to measure the duration for image upload and image availability.
The first message prints the time taken for uploading the image (roughly about 20 minutes).
The second message is the time taken for the image to be made available in the PowerVS workspace( about 10s).
I0821 11:13:19.206224   57939 import.go:220] Image imported successfully, took 20m1.16607567s

Should we consider rephrasing the second log statement to being specific about the time taken for the image to be available?
Thanks!

As a user - I'm more interested in knowing the end to end timing, any intermediate information will be more of a good to have information.
Lets reword the message for better understanding.


Review default k8s version for all hosted k8s providers

Need to make sure the k8s versions are updated to the latest versions that the hosted providers support

duplicated, closing in favor of : https://github.com/rancher/rancher/issues/28317


Update maven-build.md with RPM notes.

Add notes about building RPM packages.

LGTM; I'll add a few more pointers that I needed as well after merging.
For the record, this is needed after we merge https://github.com/apache/brooklyn-dist/pull/13


BUG Remove unnecessary unescaped $ClassName in body class

Fixes https://github.com/silverstripe/silverstripe-framework/issues/7586

Responded at https://github.com/silverstripe/silverstripe-framework/issues/7586#issuecomment-344065036

Neat :D could it be a part of this?

Does $ClassName.ATT provide a correctly escaped value?

@dhensby it's not an issue of escaping; It generates ATT-safe string, but a non-css valid class name.


[draft] [skip ci] Run fuzzing as a travis cron job

Added a kRandom fuzzing target that executes a random target.
When running travis ci cron job, fuzzing will run a random fuzzing target for 1 hour.

Options for continuous (daily) fuzzing:

Run all fuzzing targets.
Select one target to run by using the day of the year as a guide to which target to fuzz (e.g., the day of the year modulo the number of fuzzing targets).
select one target (using approach 2 or random) to fuzz for a longer time while run the other fuzzing targets for shorter periods

So in concept, option 1 is the most straightforward one. On the other hand, Travis has a time limit for a run, and is also a shared resource. Assuming we add more test targets over time, would each of them get a meaningful slice of time? If the answer is no, then it looks like option 3 is superior to option 2, but is also harder to set up. I'd suggest checking how feasible it is to implement and deciding between 2) and 3) based on that.
@rsgowman @wilhuff What are your thoughts on that? The way I see it is:

option 2 would iterate over fuzzing targets night by night, e.g. on Monday, run serializer tests, on Tuesday, run field path tests, and so on, looping over. That would give reasonable time for fuzzing to construct a lot of inputs, but any regression might take a week or more before fuzz tests get around to it.
option 3 is like option 2, except it would do a quick run of each target before doing a long run of a particular target, thus allowing to quickly catch any easily reproducible issues.

These are the approaches that come to mind, though I'll be happy with any other suggestions as well.

Assuming test setup is negligible (seconds) compared to the test time, then I'd prefer 1.
i.e. if you assume that we get a 1h time splice per day, and have 7 fuzz tests, then:
With option 1, each test gets 60m/7 per day for a total of 60m/week.
With option 2, each test gets 60m/week
With option 3, each test gets 60m/week on average.
And option 1 seems simpler.

Ah. Well the obvious question would be can we persist the corpus? But if the answer was "yes, it's easy", then I presume we'd already be doing that.
Looking at the oss-fuzz site, they seem to recommend regularly expanding the seed corpus with inputs that touch new parts of the code. So if we regularly did that, then we'd be ok. But if we don't... then yeah, now I understand the issue. :)
Travis lists a couple options for persisting data between jobs that are worth taking a look at if you haven't already:
https://docs.travis-ci.com/user/build-stages#data-persistence-between-stages-and-jobs
Otherwise, I'm now leaning toward option 2.

IIUC, corpus grows significantly on each run, so simply persisting the whole corpus each time isn't feasible (@minafarid Mina, can you check this statement/give rough numbers?). Selecting interesting new inputs from the new corpus regularly would be a lot of effort (I've seen some projects doing that with inputs that caused crashes, which is feasible but won't significantly affect the situation).

... and I've changed my mind. :)
I (now) don't like option 2, since it might mean any regressions would take up to n days to be discovered. Ideally, we'd run at least a quick scan over every test every night. I guess this means I'm more in favour of option 3. (Do I get a price for picking all-of-the-above?)

The corpus can quickly grow to thousands of interesting input files.
As for the data persistence across stages, it seems that travis recommends using external storage like s3.

For reference:
Travis time limits for jobs (source):

When a job produces no log output for 10 minutes.
When a job on a public repository takes longer than 50 minutes.
When a job on a private repository takes longer than 120 minutes.

We fit in the second category.

@var-const @rsgowman updates:

I added FUZZING_DURATION to limit the fuzzing time.
Added a script that is triggered in travis cron jobs.
The script:

Retrieves all fuzzing targets by executing an invalid fuzz testing script and expecting an error message in the format Available targets { TARGET1 ... TARGETN }
Defines a ALLOWED_TIME=2400 as total fuzzing time.
Selects one fuzzing target as the main target.
Runs the main fuzzing target for half of the time and divides the remaining fuzzing duration equally over the rest of the targets.
Examines the fuzzing results by parsing the fuzzing output.
A successful fuzzing would have the last line starts with Done.
Returns 0 if fuzzing succeeds and -1 if it crashes.


This issue is belived to be fixed, but further testing will be needed.

This issue is fixed. The parser has also been upgraded to not only parse classes but to also parse advisors and grades.


[Additional Request] Add RU language

values-ru.zip
please )))

@eXense-auth Thank you so much for translating the app to Russian! I have added your translations now, so next release they will be included! I do not have a date yet for when this will be though... But really appreciate your help in improving the app and making it accessible for more people!


Refactor ModuleMaker into ModuleMaker and LibraryMaker

Introduce a LibraryMaker class
What does this add?
This PR refactors the ModuleMaker class into a much more barebones version of itself, and renames what was ModuleMaker into a LibraryMaker class
Why is it needed?
As I was trying to write my pytest integration runner, I was hitting ast.parse errors and I couldn't quite figure out why. It turned out to be because of checking for and writing the __all__ in a notebook + the future imports, but there are times when I don't care about this happening at all (such as exporting tests to a test file).
As a result, I figured out that we can separate ModuleMaker into even simpler components, allowing for even more flexible use of this framework.
What parts of the API does this impact?
User-facing:
A new LibraryMaker class was introduced and ModuleMaker was simplified. Any custom implementations that want to emulate or tweak the behavior of the current ModuleMaker class can be implemented through sub-classing the ModuleMaker class.
The base class will write the AUTOGENERATED comment and any of the cells you wish to write. If calling the base .write implementation multiple times, a newline flag can be turned False so a \n isn't added to the end of the file call.
When would I use it, and when wouldn't I?
This is for users who want to create their own Makers that don't follow the base idea of nbdev, (e.g. focus on just a single notebook to a single .py source code) and instead want the flexibility to create a variety of different file types/contents based on the contents in each flagged cell, with the possibility of edits occurring so ast.parse may not be desired.
Does a similar feature exist? If so, why is this better?
I originally tried implementing this as its own ModuleMaker subclass, but there was a large chunk of duplicated code that could be simplified by subclassing and refactoring.

@muellerzr I like the direction here -- thanks for the PR! It looks like this refactoring has ended up with more code, but normally I'd expect refactoring to reduce the amount of code. Is there any way you could simplify, or move stuff that's only needed for your project over to there?
PS: don't forget to at-mention me on PRs so I don't miss them!

@jph00 moved it around as much as I could, now there's not too many additions but I'm also happy long-term with what this accomplishes: letting us only call maker.make() once.

@jph00 closing this then opening another one. There's an easier refactor, you are right, and tested this on a new branch of mine.


jsg::Lock cleanup

Addresses a couple cleanup items on PR#547:

Renames a few cases of jsgLock variables to js to match convention.
Adds a jsg::Lock::v8Context() convenience function and updates code to use it.

A few things I wasn't quite sure about:

having a member function v8Context() is convenient when used analogously to v8Isolate, but it differs from other workerd code in that it's a method that doesn't start with a verb.  I think the convention would be getContext() or getV8Context(), but that's a bit more verbose.  We also have a fair number of preexisting getContext() methods; not sure if that might lead to confusion.

I notice Worker::Lock has an analogous function -- another getContext() --  but it doesn't do quite the same thing, so I didn't try to rewrite code to use it, and likewise didn't rewrite things like lock.getIsolate()->GetCurrentContext().

I generally left alone anything that wasn't obviously already using jsg::Lock, so there are a bunch of other places in the code still calling GetCurrentContext().  Mostly, they seem to be places where a v8::Isolate* parameter is being passed instead of a lock reference.

Some places in the code seem to be jsg::Lock derivatives (e.g. JsgWorkerdIsolate::Lock), although I noticed they were using lock instead of js.  Wasn't sure if this was intentional, so also I left them alone.


WAL fails to load FST

I'm trying to load an FST but get the following error:
>-> (load "sim_no_pfb_match.fst" "waves")
'utf-8' codec can't decode byte 0x83 in position 14: invalid start byte
(load "sim_no_pfb_match.fst" "waves")

The FST loads into gtkwave without issue so is there anything I can do to help debug this?

$ hexdump sim_no_pfb_match.fst | head
0000000 0000 0000 0000 0100 0049 0000 0300 df83
0000010 00b3 0000 0300 26ad 69fc 1457 0a8b 05bf
0000020 0040 0000 0800 0000 0000 0000 0000 3200
0000030 00d3 0000 0000 8601 0009 0000 0000 d700
0000040 00d7 0000 0000 0000 f4a2 7366 5774 6972
0000050 6574 0072 0000 0000 0000 0000 0000 0000
0000060 0000 0000 0000 0000 0000 0000 0000 0000
*
00000c0 0000 0000 0000 0000 0000 7554 2065 6f4e
00000d0 2076 3932 3120 3a30 3535 303a 2039 3032

Hi,
that seems strange. We will look into this.

The FST was generated by Verilator if you need a testcase.

Could you provide a minimal failing example?

Here you go.  Simple counter running for 100 cycles.  Fails with 'utf-8' codec can't decode byte 0xc8 in position 24: invalid continuation byte
fst.zip

Hi, which version of WAL are you running?
FST support is only available since 0.6.3 (which is not yet on PyPi).
If you are on 0.6.2 I would recommend updating to the latest Version from GitHub.

Yes, I'm using PyPi.  Any reason a new release hasn't been made yet?  Or an ETA?

Yes there is a reason. I'm still working on the Documentation for 0.6.3 and don't want to put something on PyPi that diverges from the docs at wal-lang.org.

@LucasKl  Given we're still on a Jan '22 release in Apr '23, can you have a think about using some intermediate releases that diverge from the docs?  That's what semantic versioning is for.  And given the tiny user base, I very much doubt you'd be offending anyone.

Hi @shareefj thanks for your Issues, I really appreciate them!
I'm sorry for not keeping up with the promised timeline, so much to do :)
Since I fixed this and more Problems (most importantly the compatibility Problem with Python >3.9) I will try to merge only this fixes into WAL and push this to PyPi. I'm really sorry for this delay but I was really consumed by all the not-yet-released features I implemented in the last few months.


package gets resolved as commonjs from an esm project

Hey, I recently stumbled upon some weird behavior while using another library that uses your package, the library is https://github.com/nextui-org/nextui v2
I am kinda out of options, cause I am struggling to figure this out myself
I am using ts + vite + vite-plugin-ssr with default configs
But got the same behavior using next.js as well
While bundling the project I got an error that Error: Element type is invalid: expected a string (for built-in components) or a class/function (for composite components) but got: object.
I created an issue for this https://github.com/nextui-org/nextui/issues/1160
The gist of it is that your package gets resolved as commonjs from an esm project (vite uses esm by default either way I think) and then the cjs exports the component as module.exports.default =  but esm treats default exports from commonjs as module.exports =  not as module.exports.default =
So when nextui-org imports your package it gets imported as {default: ..component..} which is not a component and it fails
More info https://github.com/nextui-org/nextui/issues/1160
I am not sure if this is because of a bad vite config, but I don't think so, because I checked your package with https://arethetypeswrong.github.io/?p=react-textarea-autosize%408.4.1 and just as I thought node16-esm resolves your package to cjs:

Screenshot from the website

Thanks

Could you try out the version from this PR: https://github.com/Andarist/react-textarea-autosize/pull/373 ?

🙈 I forgot to commit those two files. Could you try again now?

Now it builds successfully for me 🚀


Added separate sensor to pass along raw robotStatus property to HA

I added a separate sensor for the raw robotState of the robot vacuums.
It is based on feedback here and here. The issue is that the robotState is more expressive (e.g., returning or charging as part of a pitstop, to continue cleaning) than the states defined for the Vacuum Entity class in HA. By also exposing the robotState as a separate sensor for the device, one allows for more advanced automation possibilities.
I thought the added sensor was a cleaner option than expanding the Vacuum entity states with non-standard states for that entity class. I also opted to pass the numeric state along without trying to translate it to a string to keep implementation more straightforward and also (hopefully) allow, e.g., the new "Hygienic 700" robot vacuum to use the same code when eventually someone tries to use the get this into HA using the integration.

Very nice way of making it flexible for tinkerers and also keeping the HA format. Thanks! Will monitor it and try to use it.


Support for back channel logout for all user sessions for a given user

Coauthors: Om, Arpita
Support for back channel logout for all user sessions for a given user. This change is supported only for redis client.
Changes done:
Add/Update a session- key in redis store for any new user session.
Add a new endpoint "clear_user_sessions" with mandatory query parameters : password and user_id.

This is just a copy of the Slack comments, figured it would be good to have them here too:
There's a problem in the current code here in that it requires an oauth2-proxy session cookie on the incoming request. A backchannel logout won't have that available.
It looks like the main reason you're doing this is to have a handy way to invoke ObtainLock and ReleaseLock on a SessionState object for synchro.
I know that's an easy way to get a handle on a lock but it looks like we'll need to do it differently.
It looks like you can call store.Lock(somekey) to get a lock object, which you can then call Obtain and Release on.
"somekey" is usually the ticket ID which is a random session identifier. In this case you could use the keyName from your code.

This is just a copy of the Slack comments, figured it would be good to have them here too:
There's a problem in the current code here in that it requires an oauth2-proxy session cookie on the incoming request. A backchannel logout won't have that available.
It looks like the main reason you're doing this is to have a handy way to invoke ObtainLock and ReleaseLock on a SessionState object for synchro.
I know that's an easy way to get a handle on a lock but it looks like we'll need to do it differently. It looks like you can call store.Lock(somekey) to get a lock object, which you can then call Obtain and Release on. "somekey" is usually the ticket ID which is a random session identifier. In this case you could use the keyName from your code.

@joel-bluedata made changes for getting the lock differently as per your comment


jenkins-job-builder: 2.9.1 -> 2.10.0

Semi-automatic update generated by https://github.com/ryantm/nixpkgs-update tools. This update was made based on information from https://repology.org/metapackage/python2.7-jenkins-job-builder/versions.
meta.description for jenkins-job-builder is: '"Jenkins Job Builder is a system for configuring Jenkins jobs using simple YAML files stored in Git"'.

Checks done (click to expand)

built on NixOS
/bin/sh passed the binary check.
1 of 1 passed binary check by having a zero exit code.
0 of 1 passed binary check by having the new version present in output.
found 2.10.0 with grep in /nix/store/zchphyd54psfgw7q8iazmg00p1m1c3y2-python2.7-jenkins-job-builder-2.10.0
directory tree listing: https://gist.github.com/2981c71826da2e4aae4e12da248b0d0a
du listing: https://gist.github.com/de330ed762b5080cad2a8ac562870e38

Rebuild report (if merged into master) (click to expand)

8 total rebuild path(s)
2 package rebuild(s)
2 x86_64-linux rebuild(s)
2 i686-linux rebuild(s)
2 x86_64-darwin rebuild(s)
2 aarch64-linux rebuild(s)
First fifty rebuilds by attrpath
jenkins-job-builder
python27Packages.jenkins-job-builder

Instructions to test this update (click to expand)

Either download from Cachix:
nix-store -r /nix/store/zchphyd54psfgw7q8iazmg00p1m1c3y2-python2.7-jenkins-job-builder-2.10.0 \
  --option binary-caches 'https://cache.nixos.org/ https://r-ryantm.cachix.org/' \
  --option trusted-public-keys '
  r-ryantm.cachix.org-1:gkUbLkouDAyvBdpBX0JOdIiD2/DP1ldF3Z3Y6Gqcc4c=
  cache.nixos.org-1:6NCHdD59X431o0gWypbMrAURkbJ16ZPMQFGspcDShjY=
  '

(r-ryantm's Cachix cache is only trusted for this store-path realization.)
Or, build yourself:
nix-build -A jenkins-job-builder https://github.com/r-ryantm/nixpkgs/archive/01045e8674c78b4e7545bd9ae490b97e151d167c.tar.gz

After you've downloaded or built it, look at the files and if there are any, run the binaries:
ls -la /nix/store/zchphyd54psfgw7q8iazmg00p1m1c3y2-python2.7-jenkins-job-builder-2.10.0
ls -la /nix/store/zchphyd54psfgw7q8iazmg00p1m1c3y2-python2.7-jenkins-job-builder-2.10.0/bin

cc @garbas for testing.

FYI: jenkins-job-builder is broken on staging-next.

@GrahamcOfBorg build jenkins-job-builder


Enddat 244

@mbucknell: Any testing suggestions would be most welcome. I'm a bit flummoxed about how to test for a successful download. :pensive:

I'll review probably tomorrow morning. But I don't think you can really test for a successful download. But you can spy on Blob and saveAs to see that what you are passing to them is what you expected. We did this in NWC: https://github.com/USGS-CIDA/nwc/blob/master/nwc/src/test/javascript/specs/WaterbudgetPlotView_spec.js#L120

Started looking at this. I'm not crazy about putting more site information in variableParameter in each variable. I think if you add a getSitesWithSelectedVariables to WorkflowStateModel and use this when someone requests meta data information, I think you can avoid putting more site information in the variable model.

Thanks for the suggestion. I've give that a go.

I'll wait on the changes you are making before doing a full review.

@mbucknell:
This is PR is ready for another look.

@mbucknell:
Ready for another look.

Just a few things. Otherwise looks good to go! 👍


stage1/init: return exit code 1 on error

On error, stage1/init was returning a non-zero value between 1 and 7. It
was useful for debugging to return a different value when stage1 was not
able to print any error messages. But it is not the case anymore: stage1
can write on stdout/stderr nowadays.

/cc @s-urbaniak PTAL

Argh, great news for me.
Simple diff - LGTM

squash the commits together for the sake of the tests?

LGTM

@s-urbaniak wanna pull the merge trigger?

ok, it's an honor to do so :-)

:fireworks:


incus : Created openvswitch integration test

This tests openvswitch integration with incus by:

Creating nixostestbr0 as an openvswitch bridge via Incus's preseed. This will fail if openvswitch binaries are not exposed to incus.
Confirming with incus that nixostestbr0 exists.
Confirming with ovs-vsctl that the openvswitch bridge nixostestbr0 exists (will succeed if it exists, fail if it doesn't)

Description of changes
Currently there are no tests for openvswitch integration. In fact, openvswitch integration isn't yet implemented. This test will fail until https://github.com/NixOS/nixpkgs/issues/290427 is resolved, and will pass when https://github.com/NixOS/nixpkgs/pull/294754 is merged.

Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)

[ ] sandbox = relaxed
[ ] sandbox = true

[x] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
24.05 Release Notes (or backporting 23.05 and 23.11 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[ ] Fits CONTRIBUTING.md.

Add a :+1: reaction to pull requests you find important.

Closing because these tests were added to https://github.com/NixOS/nixpkgs/pull/294754