-Woverflow warnings

Hi!
Thanks for simdjson, I absolutely love it!
Just here to report a bunch of warnings reported by my gcc gcc (Debian 9.2.1-8), if fnot already aware of them
In file included from /home/milipili/projects/hc/hc/src/grid/delegate-mesosd/refresh-mesos-info.cpp:10:
/home/milipili/projects/hc/hc/build/CMakeFiles/_deps/https-github.com-lemire-simdjson/singleheader/simdjson.h: In function ‘void simdjson::avx_check_smaller_than_0xF4(__m256i, __m256i*)’:
/home/milipili/projects/hc/hc/build/CMakeFiles/_deps/https-github.com-lemire-simdjson/singleheader/simdjson.h:36220:68: warning: overflow in conversion from ‘unsigned int’ to ‘char’ changes value from ‘244’ to ‘'\37777777764'’ [-Woverflow]
36220 |       *has_error, _mm256_subs_epu8(current_bytes, _mm256_set1_epi8(0xF4u)));
      |                                                                    ^~~~~
/home/milipili/projects/hc/hc/build/CMakeFiles/_deps/https-github.com-lemire-simdjson/singleheader/simdjson.h: In function ‘void simdjson::avx_check_first_continuation_max(__m256i, __m256i, __m256i*)’:
/home/milipili/projects/hc/hc/build/CMakeFiles/_deps/https-github.com-lemire-simdjson/singleheader/simdjson.h:36273:62: warning: overflow in conversion from ‘unsigned int’ to ‘char’ changes value from ‘237’ to ‘'\37777777755'’ [-Woverflow]
36273 |       _mm256_cmpeq_epi8(off1_current_bytes, _mm256_set1_epi8(0xEDu));
      |                                                              ^~~~~
/home/milipili/projects/hc/hc/build/CMakeFiles/_deps/https-github.com-lemire-simdjson/singleheader/simdjson.h:36275:62: warning: overflow in conversion from ‘unsigned int’ to ‘char’ changes value from ‘244’ to ‘'\37777777764'’ [-Woverflow]
36275 |       _mm256_cmpeq_epi8(off1_current_bytes, _mm256_set1_epi8(0xF4u));
      |                                                              ^~~~~
/home/milipili/projects/hc/hc/build/CMakeFiles/_deps/https-github.com-lemire-simdjson/singleheader/simdjson.h:36278:57: warning: overflow in conversion from ‘unsigned int’ to ‘char’ changes value from ‘159’ to ‘'\37777777637'’ [-Woverflow]
36278 |       _mm256_cmpgt_epi8(current_bytes, _mm256_set1_epi8(0x9Fu)), maskED);
      |                                                         ^~~~~
/home/milipili/projects/hc/hc/build/CMakeFiles/_deps/https-github.com-lemire-simdjson/singleheader/simdjson.h:36280:57: warning: overflow in conversion from ‘unsigned int’ to ‘char’ changes value from ‘143’ to ‘'\37777777617'’ [-Woverflow]
36280 |       _mm256_cmpgt_epi8(current_bytes, _mm256_set1_epi8(0x8Fu)), maskF4);
      |                                                         ^~~~~
/home/milipili/projects/hc/hc/build/CMakeFiles/_deps/https-github.com-lemire-simdjson/singleheader/simdjson.h: In function ‘void simdjson::avx_check_overlong(__m256i, __m256i, __m256i, __m256i, __m256i*)’:
/home/milipili/projects/hc/hc/build/CMakeFiles/_deps/https-github.com-lemire-simdjson/singleheader/simdjson.h:36300:24: warning: overflow in conversion from ‘unsigned int’ to ‘char’ changes value from ‘194’ to ‘'\37777777702'’ [-Woverflow]
36300 |                        0xC2u, -128,      // 110x
      |                        ^~~~~
/home/milipili/projects/hc/hc/build/CMakeFiles/_deps/https-github.com-lemire-simdjson/singleheader/simdjson.h:36301:24: warning: overflow in conversion from ‘unsigned int’ to ‘char’ changes value from ‘225’ to ‘'\37777777741'’ [-Woverflow]
36301 |                        0xE1u,            // 1110
      |                        ^~~~~
/home/milipili/projects/hc/hc/build/CMakeFiles/_deps/https-github.com-lemire-simdjson/singleheader/simdjson.h:36302:24: warning: overflow in conversion from ‘unsigned int’ to ‘char’ changes value from ‘241’ to ‘'\37777777761'’ [-Woverflow]
36302 |                        0xF1u,            // 1111
      |                        ^~~~~
/home/milipili/projects/hc/hc/build/CMakeFiles/_deps/https-github.com-lemire-simdjson/singleheader/simdjson.h:36305:24: warning: overflow in conversion from ‘unsigned int’ to ‘char’ changes value from ‘194’ to ‘'\37777777702'’ [-Woverflow]
36305 |                        0xC2u, -128,      // 110x
      |                        ^~~~~
/home/milipili/projects/hc/hc/build/CMakeFiles/_deps/https-github.com-lemire-simdjson/singleheader/simdjson.h:36306:24: warning: overflow in conversion from ‘unsigned int’ to ‘char’ changes value from ‘225’ to ‘'\37777777741'’ [-Woverflow]
36306 |                        0xE1u,            // 1110
      |                        ^~~~~
/home/milipili/projects/hc/hc/build/CMakeFiles/_deps/https-github.com-lemire-simdjson/singleheader/simdjson.h:36307:24: warning: overflow in conversion from ‘unsigned int’ to ‘char’ changes value from ‘241’ to ‘'\37777777761'’ [-Woverflow]
36307 |                        0xF1u),           // 1111
      |                        ^~~~~
/home/milipili/projects/hc/hc/build/CMakeFiles/_deps/https-github.com-lemire-simdjson/singleheader/simdjson.h:36316:24: warning: overflow in conversion from ‘unsigned int’ to ‘char’ changes value from ‘160’ to ‘'\37777777640'’ [-Woverflow]
36316 |                        0xA0u,            // 1110
      |                        ^~~~~
/home/milipili/projects/hc/hc/build/CMakeFiles/_deps/https-github.com-lemire-simdjson/singleheader/simdjson.h:36317:24: warning: overflow in conversion from ‘unsigned int’ to ‘char’ changes value from ‘144’ to ‘'\37777777620'’ [-Woverflow]
36317 |                        0x90u,            // 1111
      |                        ^~~~~
/home/milipili/projects/hc/hc/build/CMakeFiles/_deps/https-github.com-lemire-simdjson/singleheader/simdjson.h:36321:24: warning: overflow in conversion from ‘unsigned int’ to ‘char’ changes value from ‘160’ to ‘'\37777777640'’ [-Woverflow]
36321 |                        0xA0u,            // 1110
      |                        ^~~~~
/home/milipili/projects/hc/hc/build/CMakeFiles/_deps/https-github.com-lemire-simdjson/singleheader/simdjson.h:36322:24: warning: overflow in conversion from ‘unsigned int’ to ‘char’ changes value from ‘144’ to ‘'\37777777620'’ [-Woverflow]
36322 |                        0x90u),           // 1111
      |                        ^~~~~
In file included from /home/milipili/projects/hc/hc/src/grid/delegate-mesosd/refresh-mesos-info.cpp:10:
/home/milipili/projects/hc/hc/build/CMakeFiles/_deps/https-github.com-lemire-simdjson/singleheader/simdjson.h: In function ‘void simdjson::check_smaller_than_0xF4(__m128i, __m128i*)’:
/home/milipili/projects/hc/hc/build/CMakeFiles/_deps/https-github.com-lemire-simdjson/singleheader/simdjson.h:36413:72: warning: overflow in conversion from ‘unsigned int’ to ‘char’ changes value from ‘244’ to ‘'\37777777764'’ [-Woverflow]
36413 |                             _mm_subs_epu8(current_bytes, _mm_set1_epi8(0xF4u)));
      |                                                                        ^~~~~
/home/milipili/projects/hc/hc/build/CMakeFiles/_deps/https-github.com-lemire-simdjson/singleheader/simdjson.h: In function ‘void simdjson::check_first_continuation_max(__m128i, __m128i, __m128i*)’:
/home/milipili/projects/hc/hc/build/CMakeFiles/_deps/https-github.com-lemire-simdjson/singleheader/simdjson.h:36458:69: warning: overflow in conversion from ‘unsigned int’ to ‘char’ changes value from ‘237’ to ‘'\37777777755'’ [-Woverflow]
36458 |   __m128i maskED = _mm_cmpeq_epi8(off1_current_bytes, _mm_set1_epi8(0xEDu));
      |                                                                     ^~~~~
/home/milipili/projects/hc/hc/build/CMakeFiles/_deps/https-github.com-lemire-simdjson/singleheader/simdjson.h:36459:69: warning: overflow in conversion from ‘unsigned int’ to ‘char’ changes value from ‘244’ to ‘'\37777777764'’ [-Woverflow]
36459 |   __m128i maskF4 = _mm_cmpeq_epi8(off1_current_bytes, _mm_set1_epi8(0xF4u));
      |                                                                     ^~~~~
/home/milipili/projects/hc/hc/build/CMakeFiles/_deps/https-github.com-lemire-simdjson/singleheader/simdjson.h:36462:51: warning: overflow in conversion from ‘unsigned int’ to ‘char’ changes value from ‘159’ to ‘'\37777777637'’ [-Woverflow]
36462 |       _mm_cmpgt_epi8(current_bytes, _mm_set1_epi8(0x9Fu)), maskED);
      |                                                   ^~~~~
/home/milipili/projects/hc/hc/build/CMakeFiles/_deps/https-github.com-lemire-simdjson/singleheader/simdjson.h:36464:51: warning: overflow in conversion from ‘unsigned int’ to ‘char’ changes value from ‘143’ to ‘'\37777777617'’ [-Woverflow]
36464 |       _mm_cmpgt_epi8(current_bytes, _mm_set1_epi8(0x8Fu)), maskF4);
      |                                                   ^~~~~
/home/milipili/projects/hc/hc/build/CMakeFiles/_deps/https-github.com-lemire-simdjson/singleheader/simdjson.h: In function ‘void simdjson::check_overlong(__m128i, __m128i, __m128i, __m128i, __m128i*)’:
/home/milipili/projects/hc/hc/build/CMakeFiles/_deps/https-github.com-lemire-simdjson/singleheader/simdjson.h:36482:21: warning: overflow in conversion from ‘unsigned int’ to ‘char’ changes value from ‘194’ to ‘'\37777777702'’ [-Woverflow]
36482 |                     0xC2u, -128, // 110x
      |                     ^~~~~
/home/milipili/projects/hc/hc/build/CMakeFiles/_deps/https-github.com-lemire-simdjson/singleheader/simdjson.h:36483:21: warning: overflow in conversion from ‘unsigned int’ to ‘char’ changes value from ‘225’ to ‘'\37777777741'’ [-Woverflow]
36483 |                     0xE1u,       // 1110
      |                     ^~~~~
/home/milipili/projects/hc/hc/build/CMakeFiles/_deps/https-github.com-lemire-simdjson/singleheader/simdjson.h:36484:21: warning: overflow in conversion from ‘unsigned int’ to ‘char’ changes value from ‘241’ to ‘'\37777777761'’ [-Woverflow]
36484 |                     0xF1u),
      |                     ^~~~~
/home/milipili/projects/hc/hc/build/CMakeFiles/_deps/https-github.com-lemire-simdjson/singleheader/simdjson.h:36493:21: warning: overflow in conversion from ‘unsigned int’ to ‘char’ changes value from ‘160’ to ‘'\37777777640'’ [-Woverflow]
36493 |                     0xA0u,      // 1110
      |                     ^~~~~
/home/milipili/projects/hc/hc/build/CMakeFiles/_deps/https-github.com-lemire-simdjson/singleheader/simdjson.h:36494:21: warning: overflow in conversion from ‘unsigned int’ to ‘char’ changes value from ‘144’ to ‘'\37777777620'’ [-Woverflow]
36494 |                     0x90u),
      |                     ^~~~~
In file included from /usr/lib/gcc/x86_64-linux-gnu/9/include/immintrin.h:39,
                 from /usr/lib/gcc/x86_64-linux-gnu/9/include/x86intrin.h:32,
                 from /home/milipili/projects/hc/hc/build/CMakeFiles/_deps/https-github.com-lemire-simdjson/singleheader/simdjson.h:62,
                 from /home/milipili/projects/hc/hc/src/grid/delegate-mesosd/refresh-mesos-info.cpp:10:
/home/milipili/projects/hc/hc/build/CMakeFiles/_deps/https-github.com-lemire-simdjson/singleheader/simdjson.h: In function ‘uint64_t simdjson::compute_quote_mask(uint64_t) [with simdjson::Architecture <anonymous> = simdjson::Architecture::WESTMERE; uint64_t = long unsigned int]’:
/home/milipili/projects/hc/hc/build/CMakeFiles/_deps/https-github.com-lemire-simdjson/singleheader/simdjson.h:37880:55: warning: overflow in conversion from ‘unsigned int’ to ‘char’ changes value from ‘255’ to ‘'\37777777777'’ [-Woverflow]
37880 |       _mm_set_epi64x(0ULL, quote_bits), _mm_set1_epi8(0xFFu), 0));
      |                                                       ^~~~~
In file included from /home/milipili/projects/hc/hc/src/grid/delegate-mesosd/refresh-mesos-info.cpp:10:
/home/milipili/projects/hc/hc/build/CMakeFiles/_deps/https-github.com-lemire-simdjson/singleheader/simdjson.h: In function ‘void simdjson::check_utf8(simdjson::simd_input<T>, simdjson::utf8_checking_state<T>&) [with simdjson::Architecture T = simdjson::Architecture::WESTMERE]’:
/home/milipili/projects/hc/hc/build/CMakeFiles/_deps/https-github.com-lemire-simdjson/singleheader/simdjson.h:37896:36: warning: overflow in conversion from ‘unsigned int’ to ‘char’ changes value from ‘128’ to ‘'\37777777600'’ [-Woverflow]
37896 |   __m128i high_bit = _mm_set1_epi8(0x80u);
      |                                    ^~~~~
/home/milipili/projects/hc/hc/build/CMakeFiles/_deps/https-github.com-lemire-simdjson/singleheader/simdjson.h: In function ‘void simdjson::find_whitespace_and_structurals(simdjson::simd_input<T>, uint64_t&, uint64_t&) [with simdjson::Architecture T = simdjson::Architecture::WESTMERE; uint64_t = long unsigned int]’:
/home/milipili/projects/hc/hc/build/CMakeFiles/_deps/https-github.com-lemire-simdjson/singleheader/simdjson.h:37988:36: warning: overflow in conversion from ‘unsigned int’ to ‘char’ changes value from ‘192’ to ‘'\37777777700'’ [-Woverflow]
37988 |       _mm_setr_epi8(44, 125, 0, 0, 0xc0u, 0, 0, 0, 0, 0, 0, 0, 0, 0, 58, 123);
      |                                    ^~~~~
/home/milipili/projects/hc/hc/build/CMakeFiles/_deps/https-github.com-lemire-simdjson/singleheader/simdjson.h:37991:47: warning: overflow in conversion from ‘unsigned int’ to ‘char’ changes value from ‘212’ to ‘'\37777777724'’ [-Woverflow]
37991 |   const __m128i struct_offset = _mm_set1_epi8(0xd4u);
      |                                               ^~~~~
In file included from /usr/lib/gcc/x86_64-linux-gnu/9/include/immintrin.h:39,
                 from /usr/lib/gcc/x86_64-linux-gnu/9/include/x86intrin.h:32,
                 from /home/milipili/projects/hc/hc/build/CMakeFiles/_deps/https-github.com-lemire-simdjson/singleheader/simdjson.h:62,
                 from /home/milipili/projects/hc/hc/src/grid/delegate-mesosd/refresh-mesos-info.cpp:10:
/home/milipili/projects/hc/hc/build/CMakeFiles/_deps/https-github.com-lemire-simdjson/singleheader/simdjson.h: In function ‘uint64_t simdjson::compute_quote_mask(uint64_t) [with simdjson::Architecture <anonymous> = simdjson::Architecture::HASWELL; uint64_t = long unsigned int]’:
/home/milipili/projects/hc/hc/build/CMakeFiles/_deps/https-github.com-lemire-simdjson/singleheader/simdjson.h:38069:55: warning: overflow in conversion from ‘unsigned int’ to ‘char’ changes value from ‘255’ to ‘'\37777777777'’ [-Woverflow]
38069 |       _mm_set_epi64x(0ULL, quote_bits), _mm_set1_epi8(0xFFu), 0));
      |                                                       ^~~~~
In file included from /home/milipili/projects/hc/hc/src/grid/delegate-mesosd/refresh-mesos-info.cpp:10:
/home/milipili/projects/hc/hc/build/CMakeFiles/_deps/https-github.com-lemire-simdjson/singleheader/simdjson.h: In function ‘void simdjson::check_utf8(simdjson::simd_input<T>, simdjson::utf8_checking_state<T>&) [with simdjson::Architecture T = simdjson::Architecture::HASWELL]’:
/home/milipili/projects/hc/hc/build/CMakeFiles/_deps/https-github.com-lemire-simdjson/singleheader/simdjson.h:38088:39: warning: overflow in conversion from ‘unsigned int’ to ‘char’ changes value from ‘128’ to ‘'\37777777600'’ [-Woverflow]
38088 |   __m256i high_bit = _mm256_set1_epi8(0x80u);
      |                                       ^~~~~
/home/milipili/projects/hc/hc/build/CMakeFiles/_deps/https-github.com-lemire-simdjson/singleheader/simdjson.h: In function ‘void simdjson::find_whitespace_and_structurals(simdjson::simd_input<T>, uint64_t&, uint64_t&) [with simdjson::Architecture T = simdjson::Architecture::HASWELL; uint64_t = long unsigned int]’:
/home/milipili/projects/hc/hc/build/CMakeFiles/_deps/https-github.com-lemire-simdjson/singleheader/simdjson.h:38210:39: warning: overflow in conversion from ‘unsigned int’ to ‘char’ changes value from ‘192’ to ‘'\37777777700'’ [-Woverflow]
38210 |       _mm256_setr_epi8(44, 125, 0, 0, 0xc0u, 0, 0, 0, 0, 0, 0, 0, 0, 0, 58, 123,
      |                                       ^~~~~
/home/milipili/projects/hc/hc/build/CMakeFiles/_deps/https-github.com-lemire-simdjson/singleheader/simdjson.h:38211:39: warning: overflow in conversion from ‘unsigned int’ to ‘char’ changes value from ‘192’ to ‘'\37777777700'’ [-Woverflow]
38211 |                        44, 125, 0, 0, 0xc0u, 0, 0, 0, 0, 0, 0, 0, 0, 0, 58, 123);
      |                                       ^~~~~
/home/milipili/projects/hc/hc/build/CMakeFiles/_deps/https-github.com-lemire-simdjson/singleheader/simdjson.h:38216:50: warning: overflow in conversion from ‘unsigned int’ to ‘char’ changes value from ‘212’ to ‘'\37777777724'’ [-Woverflow]
38216 |   const __m256i struct_offset = _mm256_set1_epi8(0xd4u);

Do you believe that one of these warnings is indicative of a bug?
At a glance, all of these warnings appear to be false positives...

I am going to close it, the submitter is invited to provide reproducible cases.


Respirator when Left-handed.

If you have set your player to be left-handed from the skin customization options the respirator overlaps with the dual wielding slot as it switches sides.

Would really appreciate it if it would check whether you are right- or left-handed and switch sides accordingly. Thanks!

Yes! Thank you for your comment.
I will do this as soon as I return to the development of the modification.
The plans to make the setting for the customization slot position.

Great! Thank you. :)


Support Twitter's New Character Counting Method

Would be awesome if STTwitter supported these new changes! https://dev.twitter.com/overview/api/upcoming-changes-to-tweets

I added support for extended tweets (creation and consumption) in https://github.com/nst/STTwitter/commit/c5443851a3500b4547eb4be15089a6c49fac4587. Can you please ensure that it works as you expect?

Everything seems works as expected on the API part, thank you so much! Can you also update st_numberOfCharactersInATweet to reflect new counting?

Extended tweets are made of 3 parts:

mentions prefix (optional)
text region
attachment URL (optional)

Even though the total overall displayable text length may exceed 140 characters (part 1 + part 2 + part 3), the "text region" (part 2) remains limited to 140 characters, which can be counted with st_numberOfCharactersInATweet.

Yeah, I was hoping 'st_numberOfCharactersInATweet' would be able to handle counting (or not counting) the cases at the beginning and end as well, but if you believe it shouldn't be part of the scope of that method that's ok.

Also, I didn't notice this before, but doesn't Twitter say that the extended tweet mode parameter should apply across all rest endpoints? I noticed you only added that parameter for some methods.

There's also a spelling mistake. You wrote "extented" instead of "extended" for the method definition. I'll create a PR later that fixes these issues.

Doesn't  Twitter say that the extended tweet mode parameter should apply across all rest endpoints?

Not all.
"Any endpoints that return Tweets will accept a new tweet_mode request parameter."
https://dev.twitter.com/overview/api/upcoming-changes-to-tweets

There's also a spelling mistake. You wrote "extented" instead of "extended" for the method definition.

Sorry for that thank you for spotting the typo.

Ah sorry, I was looking at the chart they provide which says "any endpoint". In any case, I've created the PR https://github.com/nst/STTwitter/pull/266. I've verified that all the changes I've made work. Please take a gander!

So, could you please update https://github.com/nst/STTwitter/pull/266 so that it does add the "useExtendedTweetMode" parameter only to methods that return Tweets?

Ok, I'll do that now. Should convenience methods have extended tweets turned on by default?

Twitter API default is compatibility mode "to support older clients and display methods". This will change "in the future".
Also, users of STTwitter convenience methods don't expect the response format to suddenly change.
So, I would keep the compatibility mode by default for now.

Ok, I've updated https://github.com/nst/STTwitter/pull/266. Can you check?

merged


Mongo 4.0:  Could not evaluate: Can't connect to any member of replicaset rs0

Affected Puppet, Ruby, OS and module versions/distributions

Puppet: 6.0.4
Ruby: 2.5.1p57
Distribution: Ubuntu 16.04
Module version: 2.4.1

How to reproduce (e.g Puppet code you use)
$port = 27017

ensure_packages('apt-transport-https')

class { 'mongodb::globals':
  manage_package_repo => true,
  version             => '4.0.4',
  bind_ip             => ['<IP_ADDRESS>'],
  service_ensure      => running
}

class { 'mongodb::server':
  verbose        => true,
  restart        => true,
  port           => $port,
  journal        => true,
  pidfilepath    => '/var/run/mongodb/mongod.pid', # puppet-mongodb 2.4.1 incorrectly defines pidFilePath as /var/run/mongod.pid
  manage_pidfile => false, # a) makes no sense, because /run is temporary, and b) it fails anyway, because this class doesn't work if pid file is in a subdirectory
  replset        => 'rs0'
}

class { 'mongodb::client': } # required, or mongodb_replset will fail with "Request failed: 'Command mongo is missing'"

mongodb_replset { rs0:
  ensure  => present,
  members => ["${::fqdn}:${port}"]
}

What are you seeing
Error: "Can't connect to any member of replicaset rs0."
What behaviour did you expect instead
Replica set should be set up.
Output log
Attached: puppet.log
Any additional information you'd like to impart
Looks like message in 4.0 changed and result doesn't match what mongodb_replset expects:
root@bd1:/etc/puppet# /usr/bin/mongo admin --quiet --host bd1.dev:27017 --eval 'printjson(rs.status())'
{
        "operationTime" : Timestamp(0, 0),
        "ok" : 0,
        "errmsg" : "no replset config has been received",
        "code" : 94,
        "codeName" : "NotYetInitialized",
        "$clusterTime" : {
                "clusterTime" : Timestamp(0, 0),
                "signature" : {
                        "hash" : BinData(0,"AAAAAAAAAAAAAAAAAAAAAAAAAAA="),
                        "keyId" : NumberLong(0)
                }
        }
}

It doesn't contain set key, it appears only after I manually issue rs.initiate().

I have exactly the same issue.

I have the same problem for version 4. The replica set is not created.

Here's what I have to do to get past this problem:

Create three mongo servers with replset_members set in the ::mongodb::server resource.
Notice the "can't connect to any member of replicaset rsmain" error.
SSH into the machine that will become the first member of the replset.
I run rs.initiate() and rs.reconfig() manually to get the replicaset working.
Rereun puppet on each server, and notice no errors.

Created a PR with the fix.
#534


Add unauthenticated ChaCha20 IETF

A very hastily put together PR based on existing code but hopefully alright. The tests seem to pass. Corrected some comments.
Closes #85.

My bad for this mess. Hopefully should build now. Ended up uploading individual files because opening the whole project changed all the line endings from what I remember.

No worries 😄
Should I push a new release?

Thanks for those fixes.

Should I push a new release?

Yes please!

Done.


wifi: Add PSA MbedTLS configuration

This set of changes brings in the following:

Add specific PSA_WANT_XXX configurations to be set in WIFI_NM_WPA_SUPPLICANT_CRYPTO_MBEDTLS_PSA directly.
Bring in specific default Nordic settings for Random number generator and supplicant PSA enablement. Placing this in the def-config file after internal discussion
Add steps in wifi.rst on how to enable psa build
Enable twister build for PSA API support for Wi-Fi

The reason for the twister failure is that for the ns build, MBEDTLS_USE_PSA_CRYPTO gets enabled and since the WPA supplicant configuration is not set up for PSA build, PSA_WANT_ALG_ECDH is not enabled which leads to config check errors in check_config.h file (requires MBEDTLS_CAN_ECDH which depends on PSA_WANT_ALG_ECDH to be enabled).
Need to discuss why a PSA build is being run for an Non-PSA setting. For non-PSA build, the required configuration parameters are currently enabled.
Will check the same and come back
Thanks and regards
Vivek

@kartben , @jukkar , @MaochenWang1 , @krish2718 - please kindly ack the PR.
Thanks and regards
Vivek


Collapse together errors of the same kind

 Issue by sigmundch
Originally opened as dart-lang/sdk#20424

It's common to see one warning/error repeated in many places. For example the href vs _href might happen a lot now that we introduce the warning for it. It would be great to combine all occurrences of the same error together.
Some ideas:

for the log_injector UI, we can combine it graphically.
for the pub-build/pub-serve output in stdout, we can delay reporting warnings until the end of the phase, collect all warnings together and report them as such. At least we can do that on a file-per-file basis.

 Comment by sigmundch

Comment #1 seems big enough to deserve a separate bug. I moved it to issue dart-lang/sdk#6.

 Comment by sigmundch

It would also be great to sort errors by severity - all warnings are right now treated equal, but we probably want to rank them in some order.
This order might not be entirely static. For example, consider these 3 errors:
 a- there is an error of a broken import
 b- an warning in a template
 c- an warning that an element definition was not found.
I'd rank them in that order, because it's common that (c) is a consequence of (a). But if 'a' error is not there, I'd sort (c) before (b).


I662 ciao citygml

THis PR request erases compatibility to CityGML in return of symplifying the calculation of Daysim and data exchange.

@shanshanhsieh could you please take a look at this PR in your computer? you need to run the properties.py to be able to account for windows in different orientations. you can try running radiation_daysim/ radiation_main.y for the open case and the Zug case.

sure, i will check it out!

hey @JIMENOFONSECA , i was able to run the open case successfully.
And i noticed that the radiation outputs are stored in .json now, could it be read into dataframes like how we read the .csv files?
If yes, could you please also modify the photovoltaic.py according to the outputs from radiation file?

@shanshanhsieh done, i changed photovoltaiic.py and it works fine for the open case.

@JIMENOFONSECA i also tested the PV script for both open and zug cases, works great!
however, it gives me an error when running radiation_main.py now:
  File "C:/Users/Shanshan/Documents/GitHub/CEAforArcGIS/cea/resources/radiation_daysim/radiation_main.py", line 210, in radiation_daysim_main     rad = py2radiance.Rad(daysim_mat, locator)   File "C:\Users\Shanshan\Anaconda2\envs\cea\lib\site-packages\pyliburo-0.1a8-py2.7.egg\pyliburo\py2radiance\__init__.py", line 36, in __init__     self.command_file = os.path.join(data_folder_path, "command.txt")   File "C:\Users\Shanshan\Anaconda2\envs\cea\lib\ntpath.py", line 65, in join     result_drive, result_path = splitdrive(path)   File "C:\Users\Shanshan\Anaconda2\envs\cea\lib\ntpath.py", line 115, in splitdrive     if len(p) > 1: TypeError: object of type 'InputLocator' has no len()

@shanshanhsieh done!, please check thanks!

@JIMENOFONSECA the radiation script is working for the open case and the zug case from my side as well!

@daren-thomas can you help me to know which checks this is not passing? btw, is there a way we can all see the errors of CEAjenkins?

The best way is to run cea test - that will show you the errors locally. And you can debug them too...
Otherwise... didn't i set up a jenkins login for you? I think I did...

@JIMENOFONSECA - the last merge (#675, i612-preprocessing-multiuse-buildings) is where the errors start. Something changed there that breaks the build. This should never have been merged.

I see. I cannot find it, could you set-up for me again and for the whole team? it will be just easier to check directly there what is going on.
thanks,
Jimeno

From: Daren Thomas<EMAIL_ADDRESS>Sent: Tuesday, June 20, 2017 7:49 PM
To: architecture-building-systems/CEAforArcGIS
Cc: Jimeno Fonseca; Mention
Subject: Re: [architecture-building-systems/CEAforArcGIS] I662 ciao citygml (#677)
The best way is to run cea test - that will show you the errors locally. And you can debug them too...
Otherwise... didn't i set up a jenkins login for you? I think I did...
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHubhttps://github.com/architecture-building-systems/CEAforArcGIS/pull/677#issuecomment-309729336, or mute the threadhttps://github.com/notifications/unsubscribe-auth/AIjrgrHMMvOBxZ6BwBwjF0-rjktiJ3Flks5sF7HZgaJpZM4N5UVl.

@daren-thomas @martin-mosteiro
I get this during the tests. what does it mean? did the schedules changed?
11:31:57 GitHub pull request #677 of commit 0cccce092d5d9c097d63d1f62f57b18a668dfe64, no merge conflicts.
11:31:59 Setting status of 0cccce092d5d9c097d63d1f62f57b18a668dfe64 to PENDING with url http://ceajenkins.localtunnel.me/job/Test CEA Pull Requests/522/ and message: 'Build started sha1 is merged.'
11:32:00 Building in workspace C:\Program Files (x86)\Jenkins\workspace\Test CEA Pull Requests
11:32:00 [WS-CLEANUP] Deleting project workspace...
11:32:00 [WS-CLEANUP] Done
11:32:00 Cloning the remote Git repository
11:32:00 Cloning repository https://github.com/architecture-building-systems/CEAforArcGIS
11:32:00  > git.exe init C:\Program Files (x86)\Jenkins\workspace\Test CEA Pull Requests # timeout=10
11:32:00 Fetching upstream changes from https://github.com/architecture-building-systems/CEAforArcGIS
11:32:00  > git.exe --version # timeout=10
11:32:00  > git.exe fetch --tags --progress https://github.com/architecture-building-systems/CEAforArcGIS +refs/heads/:refs/remotes/origin/
11:39:29  > git.exe config remote.origin.url https://github.com/architecture-building-systems/CEAforArcGIS # timeout=10
11:39:29  > git.exe config --add remote.origin.fetch +refs/heads/:refs/remotes/origin/ # timeout=10
11:39:29  > git.exe config remote.origin.url https://github.com/architecture-building-systems/CEAforArcGIS # timeout=10
11:39:29 Cleaning workspace
11:39:29  > git.exe rev-parse --verify HEAD # timeout=10
11:39:29 No valid HEAD. Skipping the resetting
11:39:29  > git.exe clean -fdx # timeout=10
11:39:29 Fetching upstream changes from https://github.com/architecture-building-systems/CEAforArcGIS
11:39:29  > git.exe fetch --tags --progress https://github.com/architecture-building-systems/CEAforArcGIS +refs/pull/:refs/remotes/origin/pr/
11:39:34  > git.exe rev-parse "0cccce092d5d9c097d63d1f62f57b18a668dfe64^{commit}" # timeout=10
11:39:34 Checking out Revision 0cccce092d5d9c097d63d1f62f57b18a668dfe64 (detached)
11:39:34  > git.exe config core.sparsecheckout # timeout=10
11:39:34  > git.exe checkout -f 0cccce092d5d9c097d63d1f62f57b18a668dfe64
11:39:35  > git.exe rev-list 9756a2942eb345096b888d86c493e7786babeb37 # timeout=10
11:39:36 [Test CEA Pull Requests] $ cmd /c call C:\Users\darthoma\AppData\Local\Temp\hudson2570378142845747866.bat
11:39:37
11:39:37 C:\Program Files (x86)\Jenkins\workspace\Test CEA Pull Requests
11:39:37 >set CONDA_DEFAULT_ENV=C:\Users\darthoma\Anaconda\envs\esri104
11:39:37
11:39:37 C:\Program Files (x86)\Jenkins\workspace\Test CEA Pull Requests
11:39:37 >set Path=C:\Users\darthoma\Anaconda\envs\esri104;C:\Users\darthoma\Anaconda\envs\esri104\Scripts;C:\Users\darthoma\Anaconda\envs\esri104\Library\bin;C:\Users\darthoma\Anaconda;C:\Users\darthoma\Anaconda\Scripts;C:\ProgramData\Oracle\Java\javapath;C:\Program Files (x86)\Microsoft Visual Studio 10.0\Common7\IDE;C:\Windows\system32;C:\Windows;C:\Windows\System32\WindowsPowerShell\v1.0;c:\cygwin\bin;C:\Users\darthoma\bin;c:\Users\darthoma\bin\xmlstarlet-1.2.1;C:\Windows\Microsoft.NET\Framework\v4.0.30319;c:\Program Files (x86)\IronPython 2.7;C:\Program Files\TortoiseSVN\bin;C:\projects\EnergyPlus\Build\Products\Debug;C:\Program Files\Common Files\Autodesk Shared;C:\Program Files (x86)\Windows Kits\8.1\Windows Performance Toolkit;C:\Program Files\Microsoft SQL Server\110\Tools\Binn;C:\Program Files (x86)\WinMerge;C:\Program Files (x86)\Microsoft SDKs\TypeScript\1.0;C:\Program Files\Microsoft SQL Server\120\Tools\Binn;C:\Program Files (x86)\Calibre2;C:\Program Files\nodejs;c:\Users\darthoma\Anaconda\envs\esri104\Lib\site-packages\osgeo;C:\sysinternals;C:\Users\darthoma\AppData\Local\Pandoc;C:\Program Files (x86)\CMake\bin;C:\Users\darthoma\AppData\Roaming\npm
11:39:37
11:39:37 C:\Program Files (x86)\Jenkins\workspace\Test CEA Pull Requests
11:39:37 >set PYTHONPATH=C:\Program Files (x86)\Jenkins\workspace\Test CEA Pull Requests;
11:39:37
11:39:37 C:\Program Files (x86)\Jenkins\workspace\Test CEA Pull Requests
11:39:37 >set PYTHONUNBUFFERED=1
11:39:37
11:39:37 C:\Program Files (x86)\Jenkins\workspace\Test CEA Pull Requests
11:39:37 >where python
11:39:37 C:\Users\darthoma\Anaconda\envs\esri104\python.exe
11:39:37 C:\Users\darthoma\Anaconda\python.exe
11:39:37 c:\cygwin\bin\python
11:39:37
11:39:37 C:\Program Files (x86)\Jenkins\workspace\Test CEA Pull Requests
11:39:37 >python cea\utilities\compile_pyd_files.py
11:39:37 failed to import from rc_model_sia_cc.pyd, falling back to pure python functions
11:39:37 failed to import from rc_model_sia_cc.pyd, falling back to pure python functions
11:39:38 failed to import from calc_radiator.pyd, falling back to pure python functions
11:39:38 failed to import from calc_radiator.pyd, falling back to pure python functions
11:39:39 failed to import from storagetank_cc.pyd, falling back to pure python functions
11:39:39 failed to import from storagetank_cc.pyd, falling back to pure python functions
11:39:40
11:39:40 C:\Program Files (x86)\Jenkins\workspace\Test CEA Pull Requests
11:39:40 >python cea\cli.py test --reference-case open
11:39:45 .  run_unit_tests
11:39:53 ........FF
11:40:18 ======================================================================
11:40:18 FAIL: test_mixed_use_archetype_values (test_schedules.TestBuildingPreprocessing)
11:40:18 ----------------------------------------------------------------------
11:40:18 Traceback (most recent call last):
11:40:18   File "C:\Program Files (x86)\Jenkins\workspace\Test CEA Pull Requests\cea\tests\test_schedules.py", line 40, in test_mixed_use_archetype_values
11:40:18     assert_frame_equal(calculated_results, expected_results)
11:40:18   File "C:\Users\darthoma\Anaconda\envs\esri104\lib\site-packages\pandas\util\testing.py", line 1028, in assert_frame_equal
11:40:18     obj='DataFrame.iloc[:, {0}]'.format(i))
11:40:18   File "C:\Users\darthoma\Anaconda\envs\esri104\lib\site-packages\pandas\util\testing.py", line 925, in assert_series_equal
11:40:18     check_less_precise, obj='{0}'.format(obj))
11:40:18   File "pandas\src\testing.pyx", line 58, in pandas._testing.assert_almost_equal (pandas\src\testing.c:3809)
11:40:18   File "pandas\src\testing.pyx", line 147, in pandas._testing.assert_almost_equal (pandas\src\testing.c:2685)
11:40:18   File "C:\Users\darthoma\Anaconda\envs\esri104\lib\site-packages\pandas\util\testing.py", line 798, in raise_assert_detail
11:40:18     raise AssertionError(msg)
11:40:18 AssertionError: DataFrame.iloc[:, 3] are different
11:40:18
11:40:18 DataFrame.iloc[:, 3] values are different (100.0 %)
11:40:18 [left]:  [198.75,<PHONE_NUMBER>36]
11:40:18 [right]: [208.947368, 236.382979]
11:40:18
11:40:18 ======================================================================
11:40:18 FAIL: test_mixed_use_schedules (test_schedules.TestScheduleCreation)
11:40:18 ----------------------------------------------------------------------
11:40:18 Traceback (most recent call last):
11:40:18   File "C:\Program Files (x86)\Jenkins\workspace\Test CEA Pull Requests\cea\tests\test_schedules.py", line 80, in test_mixed_use_schedules
11:40:18     reference_results[schedule]))
11:40:18 AssertionError: Schedule 'Qs' at time 3456, 0.000000 != 0.008816
11:40:18
11:40:18 ----------------------------------------------------------------------
11:40:18 Ran 10 tests in 32.003s
11:40:18
11:40:18 FAILED (failures=2)
11:40:18 ########################################
11:40:18 TaskFailed - taskid:run_unit_tests
11:40:18 Python Task failed: '<function run_unit_tests at 0x01CAFCB0>' returned False
11:40:18
11:40:18 read input files
11:40:18 Building B06 has no heating system, Hs corrected to 0.
11:40:18 done
11:40:18 (6192.0, 3216.0)
11:40:18
11:40:18
11:40:18
11:40:18 C:\Program Files (x86)\Jenkins\workspace\Test CEA Pull Requests
11:40:18 >exit 1
11:40:18 Build step 'Execute Windows batch command' marked build as failure
11:40:18 Setting status of 0cccce092d5d9c097d63d1f62f57b18a668dfe64 to FAILURE with url http://ceajenkins.localtunnel.me/job/Test CEA Pull Requests/522/ and message: ' '
11:40:19 Finished: FAILURE

@martin-mosteiro @daren-thomas is it necessary to do an script to create unitest data of the test_schedules.py? could we?

@JIMENOFONSECA what changed? it runs in master... I can look into creating a script to create unittest data of the test_schedules.py.

@daren-thomas creating unittest data for the test_schedules will be great. The case study in cea/examples changed slightly. So i think this is why there is a problem.

@JIMENOFONSECA, overwriting your temporary fix with a config file solution. Thanks for clarifying why the data changed - this is important to do when changing the results!

@JIMENOFONSECA: now the embodied script is broken - win_wall is no longer in the architecture_df - it seems this has been moved to a new set of columns wwr_east, wwr_north, wwr_west and wwr_south.
(yay! this is a win for the jenkins!)

@JIMENOFONSECA the tests still don't run through (run cea test on your machine to see what I mean) - it seems mainly the data needs to be regenerate, but I'd like to confirm with you that that is the problem. Why is it suddenly different, when it was working yesterday before your commits?
It looks like your last commit changed the default weather file to singapore. I'm going to change that back. If we do need to change the defaults, could we move that to a separate issue? Also, we could probably do that with the config files - keep the defaults as they are and then let the SN crew use a user config to override the defaults...

@daren-thomas we are ready to merge

woohoo! merged! thank you for your hard work on this one, @JIMENOFONSECA!

wihu!….any time :-)!
On 30 Jun 2017, at 3:37 pm, Daren Thomas <notifications<EMAIL_ADDRESS>wrote:
woohoo! merged! thank you for your hard work on this one, @JIMENOFONSECAhttps://github.com/jimenofonseca!
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHubhttps://github.com/architecture-building-systems/CEAforArcGIS/pull/677#issuecomment-312197923, or mute the threadhttps://github.com/notifications/unsubscribe-auth/AIjrgunUgijVqHSjNqVGggir1t6mPoU8ks5sJKW1gaJpZM4N5UVl.


TimeShift not working

Hello
timeshift is not passed to plugin __from __to variables
reproduced : setting chart to last 8 days and making timeshift 1w  it will display last day only.
even in query inspector body sent using:
"from": "${__from:date}",
"to": "${__to:date}",
contain original not a timeshift date.

GRAFANA 10.3.1
JSON API 1.3.6

duplicate of https://github.com/grafana/grafana-json-datasource/issues/245


Invalid SPIR-V binary version 1.5 for target environment SPIR-V 1.3

I am getting a validation layer error when creating VkShaderModule from compiled shader with glslc --target-env=vulkan1.2. But instance is created with VkApplicationInfo apiVersion = VK_API_VERSION_1_2. Looks like this is a validation layer bug because the shader module is being created and rendering is working correctly.
Vulkan ERROR: Validation Error: [ UNASSIGNED-CoreValidation-Shader-InconsistentSpirv ] Object 0: handle = 0x7fdc9f069a18, type = VK_OBJECT_TYPE_DEVICE; | MessageID = 0x6bbb14 | SPIR-V module not valid: Invalid SPIR-V binary version 1.5 for target environment SPIR-V 1.3 (under Vulkan 1.1 semantics).
Vulkan API: 1.2.189
MacOS 11.6
GPU: Intel Iris Plus Graphics 645

We don't support Vulkan 1.2, so you can't use SPIR-V 1.5 yet.
The Vulkan loader is weird here. The instance Vulkan version may be 1.2 even as the driver Vulkan version is 1.1. That's what's probably happening here.

We don't support Vulkan 1.2, so you can't use SPIR-V 1.5 yet.
The Vulkan loader is weird here. The instance Vulkan version may be 1.2 even as the driver Vulkan version is 1.1. That's what's probably happening here.

Oh, ok, thank you. When do you plan to add 1.2 support?

When do you plan to add 1.2 support?

Unfortunately, it's a ways off, especially since we're busy with trying to fix test conformance with 1.1. Since 1.2 also requires KHR_buffer_device_address support, it may never happen.


Introduce the Generalized Stiefel manifold

This PR is to introduce the generalized (complex) Stiefel manifold. It further introduces a project_point! for Stiefel. Most of this PR was implemented by @manuelweisser – and now just testing is missing. I already adapted and merged the current master.

[x] Implementation
[x] Documentation
[x] Testing

Strangely most default_metric_dispatch definitions are currently not called, I have to check how I might have deactivated that (that's where this PR looses code coverage); I had hoped that I only forward all AbstractEmbeddedManifolds to their corresponding transparent dispatches.

I don't really understand that either, maybe CI made a mistake here? Sometimes in such cases I'm just adding a print statement to the method that is reported as not called to make sure it's a real problem.

Well I can state that it does not print so it's not called ;) I have to check where I introduced that since I thought I'd only made the AbstractEmbeddedManifold case more secure.

Probably some optimization pass gets rid of these functions (through inlining and constant propagation) before the intermediate representation used by CI is generated. I have no idea though why it was correctly identified before but not in this PR.

Just group is going down in code covergae because I did not care about hat/vee/get_vectors/get_coordinates to not interfere with the other PR. I did however fix a few other things to increace code coverage in general.

I think this looks OK, apart from these minor issues. Do you want to merge it before of after #115 ?

I don't have a strong preference, the advantage of merging this first, would be thst this is done. I will add the basis later, when I thought about that. I would  help merging this to base, but I was carefull to hopefully not interfere too much.
If we wait for base, this might be open for a while.

OK, let's merge this first then.

Well first of all I messed up the code by introducing the concrete types and I can't see what happened, want to take a look?

Sure, I'll take a look once I finish the current batch of changes to bases.

So if one does not confuse the two new types (DefaultEmbeddingType, DefaultIsometricEmbeddingType) it seems to work. Good idea.

Yes, also the non-generalized Stiefel should be isometric, right?

I'll commit the fix in a moment.

Ah, yes, thanks for noticing, got the two new types directly mixed up in search/replace.

So as soon as the tests are passing I'll merge this.


Make navbar more responsive for smaller screen for better readability

Removed the words form the navbar for smaller screen to make it more responsive

Before

After

closing with new PR #184, As this PR has also push old codes


Error 500 if customer chosse payment by invoice from checkout payment options

if a customer selects the synchronized payment method of the checkout "on account", he gets an error 500
It is then no longer possible to change the payment method. You have to empty the shopping cart and start from the beginning.
Hardly any customer makes this effort
JTL Shop 5.2.4
PHP 8.1

hi @Alcpaone  , thank you for raising this, we'll investigate to see why you are getting this problem.
Just one question, do you expect a lot of merchant to use this option (this information might be helpful to put the correct priority to this issue vs others) ?

Yes, this payment option is still very popular with customers. Of course, TWINT is No. 1 ahead of credit cards, but invoice is often used (when it works).

thank you for the feedback, we will tackle it accordingly

hi @Alcpaone , we are having issues reproducing the error on our end. Would it be possible to send a screen-recording or at least the steps required to reproduce this error ?

@thibault-mambour there isnt a lot to show. Here one picture. After you choose payment method invoice and press "weiter" you get the error 500. In the picture is also the url ift that helps.

@thibault-mambour btw: Patricius has all informations and you can also access to the system since month.

hi @Alcpaone thank you for the answer, I'll check internally

@thibault-mambour
Here is the error log for this in the front end. Complete url was replaced just here with XXX.
Fatal error: Uncaught PostFinanceCheckout\Sdk\ApiException: Error 442 connecting to the API (https://checkout.postfinance.ch:443/api/transaction/update?spaceId=39035) : {"date":"2023-12-20T10:12:42.413Z","defaultMessage":"The unique ID on the line item is required.","id":"M_7tZhbZEqD9EluYUj2ZLTA_A7oaL85EWDAa4On3vAg (2023-12-20T10:12:42.413Z)","message":"The unique ID on the line item is required.","type":"DEVELOPER_ERROR"} in XXX/JTL-Shop/plugins/jtl_postfinancecheckout/vendor/postfinancecheckout/sdk/lib/ApiClient.php:504 Stack trace: #0 XXX/JTL-Shop/plugins/jtl_postfinancecheckout/vendor/postfinancecheckout/sdk/lib/Service/TransactionService.php(2068): PostFinanceCheckout\Sdk\ApiClient->callApi() #1 XXX/JTL-Shop/plugins/jtl_postfinancecheckout/vendor/postfinancecheckout/sdk/lib/Service/TransactionService.php(2000): PostFinanceCheckout\Sdk\Service\TransactionService->updateWithHttpInfo() #2 XXX/JTL-Shop/plugins/jtl_postfinancecheckout/Services/PostFinanceCheckoutTransactionService.php(133): PostFinanceCheckout\Sdk\Service\TransactionService->update() #3 XXX/JTL-Shop/plugins/jtl_postfinancecheckout/frontend/Handler.php(103): Plugin\jtl_postfinancecheckout\Services\PostFinanceCheckoutTransactionService->updateTransaction() #4 XXX/JTL-Shop/plugins/jtl_postfinancecheckout/frontend/Handler.php(195): Plugin\jtl_postfinancecheckout\frontend\Handler->handleTransaction() #5 XXX/JTL-Shop/includes/src/Events/Dispatcher.php(82): Plugin\jtl_postfinancecheckout\frontend\Handler->contentUpdate() #6 XXX/JTL-Shop/includes/src/Plugin/HookManager.php(108): JTL\Events\Dispatcher->fire() #7 XXX/JTL-Shop/includes/defines.php(318): JTL\Plugin\HookManager->executeHook() #8 XXX/JTL-Shop/includes/src/Smarty/JTLSmarty.php(204): executeHook() #9 XXX/JTL-Shop/includes/vendor/smarty/smarty/libs/sysplugins/smarty_internal_runtime_filterhandler.php(63): JTL\Smarty\JTLSmarty->outputFilter() #10 XXX/JTL-Shop/includes/vendor/smarty/smarty/libs/sysplugins/smarty_internal_template.php(255): Smarty_Internal_Runtime_FilterHandler->runFilter() #11 XXX/JTL-Shop/includes/src/Smarty/JTLSmartyTemplateClass.php(59): Smarty_Internal_Template->render() #12 XXX/JTL-Shop/includes/vendor/smarty/smarty/libs/sysplugins/smarty_internal_templatebase.php(238): JTL\Smarty\JTLSmartyTemplateClass->render() #13 XXX/JTL-Shop/includes/vendor/smarty/smarty/libs/sysplugins/smarty_internal_templatebase.php(116): Smarty_Internal_TemplateBase->_execute() #14 XXX/JTL-Shop/includes/src/Smarty/JTLSmarty.php(344): Smarty_Internal_TemplateBase->fetch() #15 XXX/JTL-Shop/includes/src/Router/Controller/CheckoutController.php(338): JTL\Smarty\JTLSmarty->getResponse() #16 XXX/JTL-Shop/includes/src/Router/Controller/DefaultController.php(114): JTL\Router\Controller\CheckoutController->getResponse() #17 XXX/JTL-Shop/includes/src/Router/Router.php(684): JTL\Router\Controller\DefaultController->getResponse() #18 XXX/JTL-Shop/includes/src/Shop.php(472): JTL\Router\Router->dispatch() #19 XXX/JTL-Shop/index.php(7): JTL\Shop::dispatch() #20 {main} thrown in XXX/JTL-Shop/plugins/jtl_postfinancecheckout/vendor/postfinancecheckout/sdk/lib/ApiClient.php on line 504

@thibault-mambour
Plugin Version 1.0.10
stimm same Error 500

@thibault-mambour @andrewrowanwallee @sauliususoniswallee @edgaraswallee
will there be any new release today?
PSP Shutdown in 9 days! and we still don't have a working plugin.

Hello, @Alcpaone , I'm currently working on one of your created issues.
When I will find a solution, I will release asap.
New release will be made tonight or tomorrow, depending on when I'll find a solution for it.
Thanks for understanding.

Good morning, @Alcpaone , release has been made. Can you please check and provide a feedback?

Hi @edgaraswallee looks good until now (no error 500, payment mask starts), need to search good customer informations to do a complete test. Welcome if you can provide me the sample informations.

@edgaraswallee until now it looks good. Well done. Thank you


Multiple publishing/subscribing nodes causing crash

If talker node on the PC side and ultrasonic and imu sensors on the STM32 side are run simultaneously, the system crashes, i.e. the program counter switches to hard fault handler. Debugging information has shown that the function causing the crash is memcpy. At what point in the program this memcpy is called is still unknown.

I found many place call new() but forgot to call delete(), so it caused memory leak.
but delete(default deconstructro ) since not worked.
As a compromise， we can solve it use malloc() & free()


JArray.getRange() has thread-safety problem

Future<Uint8List> getIcon(String packageName) async {
    final JArray<jbyte> jArray = await getIconFromAndroid(packageName);

    // There is a thread safety issue with the following line of code,
    return jArray.getRange(0, jArray.length).buffer.asUint8List();
}

multiple executions test(), the return value maybe incorrect.
Isolate.run(() async {
    final icon = getIcon('package1'); // maybe incorret
});
Isolate.run(() async  {
    final icon = getIcon('package2'); // maybe incorret
});

What is getIconFromAndroid? Also you're not awaiting the result of getIcon in Isolate.run.
Please post a minimal reproducible failing code without external dependencies.

Sorry, this is the smallest example.
the code is in app_icon.dart -> _AppIconState -> _getIcon()
file
jnigen_example.zip
screenshot when called _getIcon()

screenshot when called _getIconFixed()

This seems to be a problem with the native finalizer @dcharkes.
When I try using a custom allocator (that is not recognized by package:jni to have a nativeFree), it works:
class CustomAlloc implements Allocator {
  @override
  Pointer<T> allocate<T extends NativeType>(int byteCount, {int? alignment}) {
    return malloc.allocate(byteCount, alignment: alignment);
  }

  @override
  void free(Pointer<NativeType> pointer) {
    return malloc.free(pointer);
  }
}

And later on:
final list = iconByteArray
    .getRange(0, iconByteArray.length, allocator: CustomAlloc())
    .buffer
    .asUint8List();

In general you would want to manage the memory yourself, since keeping all of the lists inside the _cache Map would keep them forever. So your implementation of CustomAlloc could also manage the images, for instance, based on the view portion of the list view.

As mentioned, this is happening due to https://github.com/dart-lang/sdk/issues/55800. Moving this to backlog.


typo in markdown

I think there is a small typo. Please correct me if I'm wrong

@miguelgfierro : Thanks for your contribution! The author(s) have been notified to review your proposed change. @vaidyas

@vaidya-s Hi, would you review this proposed update to your article?
Thanks.

Thanks!


Issue with reconstructz not working on vector -1 .. 1 range

Hi,
I have the same issue as https://github.com/microsoft/DirectXTex/issues/214#issue-794785878
I have an original normal map that I convert to BC5 using photoshop 3dc plugin.

Then I try to convert it back to TGA with reconstructz option using this command line:
texconv -y -ft TGA -swizzle grba -reconstructz -f R8G8B8A8_UNORM bc5.dds
Note : The swizzle is there to swap back x and y channels due to BC5/photoshop 3dc swapping x and y. this works well.
But the generated blue channel is way too strong as compared to the original map

I think the issue is that reconstrucz does this float z = sqrt(1 - dot(xy, xy)); on a range between 0..1
But what I need is to do the square root on a vector extracted from the normal map and on a range between -1..1 otherwise the result is false.
The operation should be something like float z = sqrt(1 - dot(xy * 2.0 - 1.0, xy * 2.0 - 1.0)) * 0.5 + 0.5;
If I do this manually I obtain the correct blue channel.
Edit : I also tried with the x2bias option but it didn't change the result

Thanks. Can you attach the .dds file itself that you created in Photoshop?

Here is  the zipped BC5 input texture : BC5.zip

Thanks for the report and repro.
-x2bias only does something when changing between format types, but since this is a UNORM to UNORM case, it doesn't do anything.
The problem is indeed the wrong formula when doing -reconstructz for UNORM formats. Fixed in this commit.

I just tested and it works like a charm now. Thanks a lot for the fix.


Sample code

It would be good if the sample code could me more organized and more complete.

Is this enhancement still needed?

Actually it is, the sample code it's really messed =/.
At the time I had to hurry with those samples and it would be really good if they are better organised.
It's open to discussion on how organise them.

Yeah makes sense. I think it would be nice to write the sample in Kotlin as well, since the focus of the project itself is Kotlin. What do you think?

Which part of the sample? The test code or the code to be tested?

The code to be tested is written in Java

Oh i got you, yeah, it's also a good idea to move the code to be tested to kotlin.
This can be easily done after organising it. 😬
It would also be really good to have two versions of the sample code, one for kotlin and one for java.


Get total count

Is there any way to get total count ? :-)

Total count of all the shares?

Same question as  hellor0bot, it seems there needs a line just to display the total share count because the code above doesn't work so far, what would it be then ?
Thank you :)

Having totalSharesCount it's up to you, how to display it. It can be any element, e.g. $("#myElementForTotalCount").text(totalSharesCount).
For the formatting you can call _formatNumber: jsSocials.Socials.prototype._formatNumber(totalSharesCount).

Ok thanks a lot ! I am no developer you see... :) I tried it but the total counter stays blocked at 0 shares, despite the Facebook counter showing 2 shares.. So I guess this is some kind of bug ?

It works fine, but you may have problems due to async share count fetching. You need to have some kind of binding, so that on each totalSharesCount change it's reflected in UI.
Without MVVM you can do simply like following:
        var totalSharesCount = 0;

        var refreshTotalCount = function() {
            $("#totalCount").text(jsSocials.Socials.prototype._formatNumber(totalSharesCount));
        };

        $.each(jsSocials.shares, function(_, share) {
            var origGetCount = share.getCount;
            if(!origGetCount)
                return true;

            share.getCount = function() {
                var result = origGetCount.apply(share, arguments);
                totalSharesCount += parseInt(result, 10) || 0;
                refreshTotalCount();
                return result;
            };
        });

Ensure that this script is executed before js-socials initialization.

Well I'm sorry, I must be very dumb but I tried both codes (copy-pasted, didn't add any script to it)
that you provided (example here) and none makes the global counter work on my server :(

shares !

<script>
    $("#share").jsSocials({
        shares: ["facebook", "twitter", "googleplus", "pinterest"],

    url: "http://url.to.share",
    text: "text to share",
    showLabel: true,
    showCount: true,

    });
</script>

for the first code you provided and below for the second one :
shares
<script src="http://code.jquery.com/jquery-latest.pack.js"></script>

<script>
    $("#share").jsSocials({
        shares: ["facebook", "twitter", "googleplus", "pinterest"],

    url: "http://url.to.share",
    text: "text to share",
    showLabel: true,
    showCount: true,

    });
</script>

Did I do something wrong ? Again, thanks a lot for your help. A lot.

Not sure this is the only problem, but the initialization code is put before jsSocials script.
Either wrap code with DOM ready handler, or just put jsSocials script link before it.

Ok, I had misunderstood what you were talking about earlier. So :

first call jssocials.min.js,
then the jssocials script for the global counter,
then the jssocials buttons.

Got it, and it works ! Thank you very much  :)
Regarding the 2 different versions of the script you provided, is one of them supposed to load faster than the other ? Because I'm trying to figure out which one to take now :)

Damn it works when there is one set of buttons but not when there are several attached to different urls... :/
On my home page I'm trying to put buttons to share every content (each one having a separate url), and show the total counter of shares for each content.
But when I do that, the counter actually adds up and never refreshes to 0 between each load. So if my content1 has 45 total shares, and my content2 has total 15 shares, the counter will actually count 60 shares for content1 and 60 for content2  ;-)
Is there a way to refresh the counter between each load and make sure the counter only goes picking a specific set of buttons (through an ID maybe ?), and not all the ones on the page ?
That would fix the problem I guess :)
Thanks for your answer :)

Hey, so has anyone got an idea about how to get the global counter for a specific ID ? (= for a specific set of buttons only, when there are several sets of buttons on the same page) ?
Thank you !

Ok, then it would be easier to redefine _getCountValue method. Assign a custom property (e.g. id) in the config of each share. Define a hash for total counts:
        var totalSharesCounts = {};

        var refreshTotalCount = function(shareId) {
            $("#totalCount_" + shareId).text(jsSocials.Socials.prototype._formatNumber(totalSharesCounts[shareId]));
        };

        var origGetCountValue = jsSocials.Socials.prototype._getCountValue;

        jsSocials.Socials.prototype._getCountValue = function(response, share) {
            var count = share.getCount(response);
            totalSharesCounts[this.id] = (totalSharesCounts[this.id] ? totalSharesCounts[this.id] : 0) + (parseInt(count, 10) || 0);
            refreshTotalCount(this.id);
            return origGetCountValue.apply(this, arguments);
        };

        // provide unique ids for shares
        $("#share").jsSocials({
            id: "share1",
            ...

It works wonders that way, thank you very much !!   :)

@tergra  May I have your full working code with html ?
I followed the post but without success


MudMask: Interference with OnKeyPress

Bug type
Component
Component name
MudMask/MudTextField
What happened?
I am trying to create a text field with a mask and monitor the input using OnKeyPress.
The problem is that when the mask is enabled, OnKeyPress is not being invoked when I push the enter key.
The mask I am using is ^[a-zA-Z \n]+$ if it makes a difference.
Expected behavior
I would expect the mask to work and OnKeyPress to be invoked regardless of the mask.
Reproduction link
https://try.mudblazor.com/snippet/QuQHkbGOrvBkJEFT
Reproduction steps

Enter a something in the textbox
Press enter
It will not work, so remove the Mask from the MudTextField and try again

Relevant log output
No response
Version (bug)
Latest
Version (working)
No response
What browsers are you seeing the problem on?
Chrome
On what operating system are you experiencing the issue?
Windows
Pull Request

[ ] I would like to do a Pull Request

Code of Conduct

[X] I agree to follow this project's Code of Conduct

Any progress?


Working directory

What version of kubb is running?
kubb/2.18.8 darwin-arm64 node-v22.2.0
What platform is your computer?
MacOS
What version of external packages are you using(@tanstack-query, MSW, React, Vue, ...)
No response
What steps can reproduce the bug?
Try to run kubb from the directory where the kubb.config.ts lies and try to repeat it from the parent directory.
Currently, kubb handles the relative paths in the config depending on the "working directory".
So starting kubb from a different directory can lead to errors or to different results.
How often does this bug happen?
Every time
What is the expected behavior?
I would expect, that the config would use the directory of kubb.config.ts as the point of reference when it comes to paths.
Like in the attached config file, I would expect, that the swagger file will be next to the kubb file, and kubb will look for it next to it, no matter in which directory I start kubb from.
Swagger/OpenAPI file?
No response
Additional information
import { defineConfig } from '@kubb/core';
import { pluginOas } from '@kubb/plugin-oas';
import { pluginTs } from '@kubb/swagger-ts';
import { pluginTanstackQuery } from '@kubb/swagger-tanstack-query';
import { pluginZod } from '@kubb/swagger-zod';

export default defineConfig(async () => {
  return {
    root: '.',
    input: {
      path: './swagger.yaml',
    },
    output: {
      path: './src',
    },
    plugins: [
      pluginOas({ output: false }),
    ],
  };
});

Image for representation:

@csaba-veezla This should be resolved in the latest version of Kubb.


Customizable Token.data.

Allow token to store a custom type data?

Maybe the data type should be bind to a token kind? So that different token kind will have different data type.


Make the Netflix subtitles hoverable so that the popup can be utilized with it.

What is your use case?
Linguist does not interrupt in code of specific sites. We have a similar issue about RTL where I said about a potential problems for this approach with "improve" site behavior.

Hi,
I noticed this statement on GitHub/Chrome Web Store:
"Translate web pages, highlighted text, Netflix subtitles, private messages, speak the translated text, and save important translations to your personal dictionary to learn words even offline."
I thought there could be a special treatment for Netflix itself, as extensions of this kind have been doing it for a while...
My proposal is to make the subtitles on Netflix selectable, so the user would be able to highlight the text and utilize the pop-up icon to translate a specific word. (or just show up the pop up with the translation instead of the icon)
Here are some examples of extensions of the same genre doing this:
Mate Translate / Reverso
For example, Mate makes the subtitles clickable for languages with spaces (Spanish, English, Portuguese, basically every single one of them). For other languages without spaces, such as Japanese or Chinese, where it may not be possible to parse the language without previous knowledge of it, you can only hover...

What about translate whole page instead?
You may enable page translation and subtitles should be translated automatically. Is it works for you?

The whole purpose would be utilize it as a dictionary rather than a translator itself. (With the goal of acquiring a language or learning new words in a language you already know.) if this is not the goal of the project feel free to close the issue.

You're correct, the goal of Linguist both - translate content and help to learn a languages.
The only problem we have with this proposal is we have to modify a site, to implement this request.
My opinion is we must never modify a site content or change site behavior. But i see your concern about barriers to use Linguist with some sites.
Maybe we may introduce a user packages to find a tradeoff here. In this case, Linguist will not change site behavior itself, but Linguist will provide some list with packages/extensions, so users will be able to improve a behavior on specific sites they needed. User would just go to preferences page, then click something kinda "extensions" and will see a list of extensions, then will click "install"/"enable" on extensions like "netflix subtitles" and it will be installed and activated.
I'm not sure about RCE policy in Chrome store for addons with manifest V3, maybe it is not allowed, i have to research.
I will think how to resolve this problem. It probably will not be solved soon, but anyway thank you for report your use case. It is important to know what users needs.


Provide access to structured REST errors that are returned

Originally a part of issue: https://github.com/Azure/azure-kusto-go/issues/10
Errors returned as part of Kusto can come in a variety of shapes.  Some are errors generated by authorization systems, some are generated by Kusto, etc....
These errors may come in two forms

Standard string
JSON encoded

The JSON encoded may also come in different forms.  Some are OneAPI errors, but off an earlier spec that is no longer valid or some other JSON encoded structure.
Currently, we simply try to look at the OneAPI errors we have seen and simply put them as wrapped errors inside Go's error type.  This probably has limited use.
Go has a wide variety of error detection methods.    At this time, I don't think it is realistic to believe we can do that.  We simply understand the severity of the issue and where the error comes from.
In those issues, we have error codes that can be introspected via the errors library.
But we do not have anything to allow dynamic introspection of the data when it is JSON encoded.  This is being asked for.
Here is the original part of the request:
Additionally, the main issue is that the actual Kusto error response is basically lost. All that's returned from a Kusto call is an HTTP Error with a text string containing the http response body embedded inside it.

It appears as though Kusto returns a json struct for the error with code, message, @type, @context, etc. Shouldn't there be a formal Kusto error struct that's optionally set and returned with errors returned by calls to Kusto Go APIs ?

Are you going to make other enhancements here or should we just close this?

I'm considering a new errors package in the future.  The OneError thing is like a moving target and the backend sometimes sends them and sometimes doesn't.  I'm thinking of doing something simpler like I implemented in MSAL.
I think its fine to close this and I can open up another one that has something more well thought out than my one line comment above.

Finally fixed in 1.0.0-preview


subst.rs "index out of bounds: the len is 1 but the index is 1"

This is with rust-analyzer using the vscode client on Windows.
I get this error frequently:
thread '<unnamed>' panicked at 'index out of bounds: the len is 1 but the index is 1',
C:\Users\runneradmin\.cargo\registry\src\github.com-1ecc6299db9ec823\chalk-ir-0.69.0\src\fold\subst.rs:58:19
stack backtrace:
note: Some details are omitted, run with `RUST_BACKTRACE=full` for a verbose backtrace.

Unfortunately I don't have an easy repro. It happens after I've been working in the project for a while (in multiple different projects), and once it happens the server is effectively dead (just keeps repeating this error). Restarting vscode and/or rust-analyzer does not fix it, but cargo clean does. [Edit: that was true of similar problems I've run into, but this particular example seems to reproduce reliably and is unaffected by cargo clean.]
If there's some way I can get better diagnostic info to help debug it I'd be glad to do that, but I can't even seem to get RUST_BACKTRACE to work. I have RUST_BACKTRACE=full set in both my system environment variables and via setting "rust-analyzer.server.extraEnv": {"RUST_BACKTRACE": "full"}, but I still get the short panic message as shown above.
(I don't think this is a dup of #5366 since the error location is different.)

Ok, I have a small repro in github. If I load this project in vscode on Windows, open the "lib.rs" file, and wait a few seconds, I get the error consistently.
(The repro uses a peg parser macro. I tried replacing the code with the result of cargo +nightly rustc -Z unstable-options --pretty=expanded but the error doesn't happen when I do that.)

More update:

Running %APPDATA%\Code\User\globalStorage\matklad.rust-analyzer\rust-analyzer-x86_64-pc-windows-msvc.exe diagnostics . from that project folder also reproduces the error, so you don't need vscode.
RUST_BACKTRACE still doesn't work, even though I'm now running the executable myself.

More more update: it repros on Linux (using the version in rustup +nightly component add rust-analyzer-preview), and backtrace works there:
0: rust_begin_unwind
            at /rustc/b41936b92cd8463020207cb2f62a4247942ef2e4/library/std/src/panicking.rs:515:5
1: core::panicking::panic_fmt
            at /rustc/b41936b92cd8463020207cb2f62a4247942ef2e4/library/core/src/panicking.rs:92:14
2: core::panicking::panic_bounds_check
            at /rustc/b41936b92cd8463020207cb2f62a4247942ef2e4/library/core/src/panicking.rs:69:5
3: <chalk_ir::fold::subst::Subst<I> as chalk_ir::fold::Folder<I>>::fold_free_var_ty
4: <chalk_ir::Ty<I> as chalk_ir::fold::SuperFold<I>>::super_fold_with
5: <chalk_ir::Ty<I> as chalk_ir::fold::SuperFold<I>>::super_fold_with
6: chalk_ir::fold::boring_impls::<impl chalk_ir::fold::Fold<I> for chalk_ir::GenericArg<I>>::fold_with
7: <smallvec::SmallVec<A> as core::iter::traits::collect::Extend<<A as smallvec::Array>::Item>>::extend
8: chalk_ir::fold::boring_impls::<impl chalk_ir::fold::Fold<I> for chalk_ir::Substitution<I>>::fold_with
9: <chalk_ir::Ty<I> as chalk_ir::fold::SuperFold<I>>::super_fold_with
10: chalk_ir::fold::boring_impls::<impl chalk_ir::fold::Fold<I> for chalk_ir::GenericArg<I>>::fold_with
11: <smallvec::SmallVec<A> as core::iter::traits::collect::Extend<<A as smallvec::Array>::Item>>::extend
12: chalk_ir::fold::boring_impls::<impl chalk_ir::fold::Fold<I> for chalk_ir::Substitution<I>>::fold_with
13: chalk_ir::_DERIVE_chalk_ir_fold_Fold_I_FOR_WhereClause::<impl chalk_ir::fold::Fold<I> for chalk_ir::WhereClause<I>>::fold_with
14: chalk_ir::fold::binder_impls::<impl chalk_ir::fold::Fold<I> for chalk_ir::Binders<T>>::fold_with
15: <chalk_ir::cast::Casted<IT,U> as core::iter::traits::iterator::Iterator>::next
16: <alloc::vec::Vec<T> as alloc::vec::spec_from_iter::SpecFromIter<T,I>>::from_iter
17: <hir_ty::interner::Interner as chalk_ir::interner::Interner>::intern_quantified_where_clauses
18: chalk_ir::fold::boring_impls::<impl chalk_ir::fold::Fold<I> for chalk_ir::QuantifiedWhereClauses<I>>::fold_with
19: chalk_solve::infer::instantiate::<impl chalk_solve::infer::InferenceTable<I>>::instantiate_binders_universally
20: <chalk_solve::infer::unify::Unifier<I> as chalk_ir::zip::Zipper<I>>::zip_binders
21: chalk_solve::infer::unify::Unifier<I>::relate_ty_ty
22: chalk_solve::infer::unify::Unifier<I>::relate_var_ty
23: chalk_solve::infer::unify::Unifier<I>::relate_ty_ty
24: <chalk_solve::infer::unify::Unifier<I> as chalk_ir::zip::Zipper<I>>::zip_tys
25: chalk_ir::zip::Zipper::zip_substs
26: chalk_ir::_DERIVE_chalk_ir_zip_Zip_I_FOR_WhereClause::<impl chalk_ir::zip::Zip<I> for chalk_ir::WhereClause<I>>::zip_with
27: chalk_solve::infer::unify::Unifier<I>::relate
28: chalk_solve::infer::unify::<impl chalk_solve::infer::InferenceTable<I>>::relate
29: chalk_recursive::fulfill::Fulfill<I,Solver>::new_with_clause
30: <chalk_recursive::recursive::Solver<I> as chalk_recursive::solve::SolveDatabase<I>>::solve_goal
31: <chalk_recursive::recursive::RecursiveSolver<I> as chalk_solve::solve::Solver<I>>::solve_limited
32: hir_ty::traits::trait_solve_query
33: salsa::runtime::Runtime::execute_query_implementation
34: salsa::derived::slot::Slot<Q,MP>::read_upgrade
35: salsa::derived::slot::Slot<Q,MP>::read
36: <salsa::derived::DerivedStorage<Q,MP> as salsa::plumbing::QueryStorageOps<Q>>::try_fetch
37: salsa::QueryTable<Q>::get
38: <DB as hir_ty::db::HirDatabase>::trait_solve_query::__shim
39: <DB as hir_ty::db::HirDatabase>::trait_solve_query
40: hir_ty::db::trait_solve_wait
41: <DB as hir_ty::db::HirDatabase>::trait_solve
42: hir_ty::infer::coerce::<impl hir_ty::infer::InferenceContext>::coerce_inner
43: hir_ty::infer::coerce::<impl hir_ty::infer::InferenceContext>::coerce
44: hir_ty::infer::expr::<impl hir_ty::infer::InferenceContext>::infer_expr_inner
45: hir_ty::infer::expr::<impl hir_ty::infer::InferenceContext>::infer_expr_inner
46: hir_ty::infer::expr::<impl hir_ty::infer::InferenceContext>::infer_expr_coerce
47: hir_ty::infer::expr::<impl hir_ty::infer::InferenceContext>::check_call_arguments
48: hir_ty::infer::expr::<impl hir_ty::infer::InferenceContext>::infer_expr_inner
49: hir_ty::infer::expr::<impl hir_ty::infer::InferenceContext>::infer_expr_coerce
50: hir_ty::infer::expr::<impl hir_ty::infer::InferenceContext>::infer_block
51: hir_ty::infer::expr::<impl hir_ty::infer::InferenceContext>::infer_expr_inner
52: hir_ty::infer::expr::<impl hir_ty::infer::InferenceContext>::infer_expr_coerce
53: hir_ty::infer::expr::<impl hir_ty::infer::InferenceContext>::infer_block
54: hir_ty::infer::expr::<impl hir_ty::infer::InferenceContext>::infer_expr_inner
55: hir_ty::infer::expr::<impl hir_ty::infer::InferenceContext>::infer_expr_coerce
56: hir_ty::infer::infer_query
57: salsa::runtime::Runtime::execute_query_implementation
58: salsa::derived::slot::Slot<Q,MP>::read_upgrade
59: salsa::derived::slot::Slot<Q,MP>::read
60: <salsa::derived::DerivedStorage<Q,MP> as salsa::plumbing::QueryStorageOps<Q>>::try_fetch
61: <DB as hir_ty::db::HirDatabase>::infer_query::__shim
62: hir_ty::db::infer_wait
63: hir::Function::diagnostics
64: hir::Module::diagnostics
65: hir::Module::diagnostics
66: ide_diagnostics::diagnostics
67: ide::Analysis::diagnostics
68: rust_analyzer::cli::diagnostics::diagnostics
69: rust_analyzer::main

Minimized test case:
pub enum RuleResult<T> {
    Matched(T),
    Failed,
}

struct ParseState;

fn infix_parse<T, S>(_state: S, _level_code: &dyn Fn(&Fn(S)) -> RuleResult<()>) -> RuleResult<T> {
    RuleResult::Failed
}

fn parse_arule(state: ParseState) -> RuleResult<i32> {
    infix_parse(state, &(|_recurse| todo!()))
}

Interestingly, it doesn't happen with &dyn Fn.

That is interesting. Might be a problem with the lowering code then.
Bare traits get lowered here:
https://github.com/rust-analyzer/rust-analyzer/blob/444679f202742c8fd00e9d1c7fddfaa9a067e640/crates/hir_ty/src/lower.rs#L439-L451
Whereas dyn Trait gets lowered here:
https://github.com/rust-analyzer/rust-analyzer/blob/444679f202742c8fd00e9d1c7fddfaa9a067e640/crates/hir_ty/src/lower.rs#L205-L216
Might be instructive to create a test for this and compare the lowered types.

--- bare
+++ dyn
@@ -1,4 +1,4 @@
-[WARN hir_ty::lower] dyn for<type> [for<> Implemented(^1.0: TraitId(60)<1<[?0 := !0_0]>>)] + 'static
+[WARN hir_ty::lower] dyn for<type> [for<> Implemented(^1.0: TraitId(60)<1<[?0 := !0_0]>>), for<> AliasEq(AliasTy(?) = 0<[]>)] + 'static
 [WARN hir_ty::lower] dyn for<type> [for<> Implemented(^1.0: TraitId(71))] + 'static
 [WARN hir_ty::lower] dyn for<type> [for<> Implemented(^1.0: TraitId(71)), for<> Implemented(^1.0: TraitId(24))] + 'static
 [WARN hir_ty::lower] dyn for<type> [for<> Implemented(^1.0: TraitId(71)), for<> Implemented(^1.0: TraitId(24)), for<> Implemented(^1.0: TraitId(30))] + 'static
@@ -24,4 +24,4 @@
 [WARN hir_ty::lower] dyn for<type> [for<> Implemented(^1.0: TraitId(175))] + 'static
 [WARN hir_ty::lower] dyn for<type> [for<> Implemented(^1.0: TraitId(175)), for<> Implemented(^1.0: TraitId(24))] + 'static
 [WARN hir_ty::lower] dyn for<type> [for<> Implemented(^1.0: TraitId(175)), for<> Implemented(^1.0: TraitId(24)), for<> Implemented(^1.0: TraitId(30))] + 'static
-[WARN hir_ty::lower] dyn for<type> [for<> Implemented(^1.0: TraitId(60)<1<[?0 := ^1.1]>>)] + 'static
+[WARN hir_ty::lower] dyn for<type> [for<> Implemented(^1.0: TraitId(60)<1<[?0 := ^2.1]>>), for<> AliasEq(AliasTy(?) = 0<[]>)] + 'static

Yeah, so we drop the associated type bindings (bad, but not the cause of the crash), and we mess up the binders (the 2 vs. 1 in the second difference).

@flodiebold feel free to look into this, I tried some random combinations of shifting the binders, but failed miserably.

I can look into it next week probably, but my current guess would be wrapping the lower_trait_ref_from_resolved_path call in a with_shifted_in similarly to the dyn case. Unless that's one of the things you already tried ;)

Doing only that fixes this case, but introduces other panics ("unexpected free variable with depth ^0.0 with outer binder ^0").


Updated version to 0.9.7 and github URL

Updated to the current version
Recent development and releases seem to have switched to new repo, so I've updated the URL

Neither the commit message nor the PR title mention the name of the updated cask. Please amend both.

If you don’t know how to amend, follow this.

Looks like you've introduced extra commits when changing the commit message. A maintainer will manually fix and merge this PR.

Thank you for the contribution. It needed some fixes, so they were made in 3e9ead8c7315a488e9147039d2fb8d698258f55c. Your contribution is still included (and still credited to you), with the appropriate modifications. Please feel free to ask about any of the changes.


bug: Linux CPU not able to load tiny-llama

Describe the bug
Nitro on linux-cpu is not able to load model https://huggingface.co/TheBloke/TinyLlama-1.1B-Chat-v0.3-GGUF, orther huge model like https://huggingface.co/TheBloke/Llama-2-7B-GGUF still works well
To Reproduce
OS: ubuntu 22.04
Steps to reproduce the behavior:

Access to ubuntu 22.04
Download nitro cpu from https://github.com/janhq/nitro/releases/download/v0.1.2/nitro-0.1.2-linux-amd64.zip
Unzip model unzip nitro-0.1.2-linux-amd64.zip
Download model wget https://huggingface.co/TheBloke/TinyLlama-1.1B-Chat-v0.3-GGUF/blob/main/tinyllama-1.1b-chat-v0.3.Q2_K.gguf
Start Nitro ./nitro
Open another terminal and run curl command to load model, remember to change the <model_path>

curl --location 'http://localhost:3928/inferences/llamacpp/loadModel' \
--header 'Content-Type: application/json' \
--data '{
    "llama_model_path": "<model_path>",
    "ctx_len": 2048,
    "ngl": 32,
    "embedding": false
}'

Error log
20231030 12:06:35.792672 UTC 2061068 INFO  Server started, listening at: <IP_ADDRESS>:3928 - main.cc:33
20231030 12:06:35.792727 UTC 2061068 INFO  Please load your model - main.cc:34
20231030 12:06:38.035415 UTC 2061069 INFO  {"timestamp":1698667598,"level":"INFO","function":"loadModel","line":322,"message":"build info","build":1,"commit":"281ef73"} - llamaCPP.h:117
20231030 12:06:38.035509 UTC 2061069 INFO  {"timestamp":1698667598,"level":"INFO","function":"loadModel","line":324,"message":"system info","n_threads":4,"total_threads":8,"system_info":"AVX = 1 | AVX2 = 1 | AVX512 = 0 | AVX512_VBMI = 0 | AVX512_VNNI = 0 | FMA = 1 | NEON = 0 | ARM_FMA = 0 | F16C = 1 | FP16_VA = 0 | WASM_SIMD = 0 | BLAS = 0 | SSE3 = 1 | SSSE3 = 1 | VSX = 0 | "} - llamaCPP.h:117
gguf_init_from_file: invalid magic number 4f44213c
error loading model: llama_model_loader: failed to load model from /tmp/testmodel

llama_load_model_from_file: failed to load model
llama_init_from_gpt_params: error: failed to load model '/tmp/testmodel'
20231030 12:06:38.035792 UTC 2061069 INFO  {"timestamp":1698667598,"level":"ERROR","function":"loadModel","line":254,"message":"unable to load model","model":"/tmp/testmodel"} - llamaCPP.h:117
20231030 12:06:38.035815 UTC 2061069 ERROR Error loading the model will exit the program - llamaCPP.cc:333
Segmentation fault (core dumped)

nvm, I put the wrong url of gguf model.


Occasional CORS failure

I am using Pannellum 2.5.6, and usually it all works beautifully (thanks!).
But I occasionally see a CORS error (in Chrome) where an image does not load, but I do not think it is really a CORS configuration problem, since (a) it works most of the time in Chrome and (b) when it fails in Chrome, I can load the same page and another browser and it works fine.
When it is working, if I look at the HTTP request for the image, it includes a line:
"Remote Address [my ip]"
When it is failing, I do not see that line in the request for the image, which makes me think that occasionally Pannellum (or my browser for some reason) omits it, and then the server of course denies the request, with Javascript error:
Access to XMLHttpRequest at 'https://...' from origin 'https://...' has been blocked by CORS policy: No 'Access-Control-Allow-Origin' header is present on the requested resource.
Any ideas?
Thanks
Greg Saunders

FYI:  I think I solved this...it was a very subtle issue.
If you have a 360 image which is also used as a plain old regular HTML image in your site, the browser makes an HTML request for the image first, and since it's not JavaScript related, there's no CORS involved, and there are no access control headers in the reply.  Then when Pannellum requests the image later, it gets a cached version with no CORS headers and breaks.
This happens in Chrome; it is ok in Firefox.  And it took a LONG time to figure out.

The Chrome developers consider this to be a server configuration issue.
It can be fixed by setting certain headers on the server response (e.g., see this blog post) or by adding crossorigin="anonymous" to your <img> tag.
Regardless, it's not an issue with Pannellum specifically, so I'm going to close this issue.

Thanks for the extra clarification.
On Sat, Jan 29, 2022 at 1:17 PM Matthew Petroff @.***>
wrote:

The Chrome developers consider this to be a server configuration issue
https://bugs.chromium.org/p/chromium/issues/detail?id=409090.
It can be fixed by setting certain headers on the server response (e.g.,
see this blog post https://blog.keul.it/chrome-cors-issue-due-to-cache/)
or by adding crossorigin="anonymous" to your  tag.
Regardless, it's not an issue with Pannellum specifically, so I'm going to
close this issue.
—
Reply to this email directly, view it on GitHub
https://github.com/mpetroff/pannellum/issues/1069#issuecomment-1024970749,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AANF3GAQDACCX464QCPCYG3UYQ4MLANCNFSM5NBWXRBA
.
Triage notifications on the go with GitHub Mobile for iOS
https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675
or Android
https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.
You are receiving this because you authored the thread.Message ID:
@.***>


updates docker install docs

Description & motivation
Docker images are handled differently in >=1.0.0.  This updates the docs to reflect that.
To-do before merge
N/A
Pre-release docs
Is this change related to an unreleased version of dbt?

[x] Unsure: we'll let you know!

Checklist
N/A

@iknox-fa It looks like these are just about good to go. Would you like one of @runleonarun or me to take this over the finish line?

@jtcohen6 I'm afraid I've been a blocker here because I've been intending to run through the install.  But I say let's :shipit: and I can follow up with edit when I can.

Ah sorry!! I totally missed that. Great idea to try running through these instructions

@runleonarun @iknox-fa I picked this back up, as I'd like to get this merged!
I opted for:

Removing the section about building your own Docker image, and pointing folks to the dbt-core README on this instead
Adding more caveats and expectation-setting about why you'd want to use Docker, in what cases it might be slow, and our (limited) ability to offer support for custom use cases

Assuming the CI checks pass, I'm going to approve and merge this.


Issue with Running Script Locally

I tried running the script locally after installing locally with :
  curl -SSL http://frankencover.it/with > FrankenCliReader && chmod +x FrankenCliReader

I end up seeing the following error:
          FrankenCliReader -s /Users/sasokan/Desktop/cma-ios
          org.codehaus.groovy.control.MultipleCompilationErrorsException: startup failed:
          /usr/local/bin/FrankenCliReader: 17: Invalid duplicate class definition of class FrankenCliReader  : The source /usr/local/bin/FrankenCliReader contains at least two definitions of the class         FrankenCliReader.
         One of the classes is an explicit generated class using the class statement, the other is a class  generated from the script body based on the file name. Solutions are to change the file name or to change the class name.
        @ line 17, column 1.
         class FrankenCliReader
         ^

        1 error

      curl -SSL https://frankencover.it/with > FrankenCover && chmod +x FrankenCover

Times out


RHTAPINST-140: Golang v1.22.5 and Container Images Update

To mitigate Synk issues, upgrading both Go and container images to support latest UBI9 and OpenShift 4.16 container images.

/hold
Let's wait for the Synk analysis, and update the dependencies accordingly.

/hold cancel


Enable effectful properties (SE-310) by default.

Removes gating on -enable-experimental-concurrency.
Updates eff. prop tests to remove experimental flag,
and also adjusts some tests slightly to avoid things
that are still behind that flag.

Resolves rdar://77224151

@swift-ci please smoke test and merge


in mesos info page, found the framework is Completed, then restart swan got err

[root@centos-01 ~]# ./swan manager --mesos zk://<IP_ADDRESS>:2181/mesos --zk zk://<IP_ADDRESS>:2181/swan
Connected to <IP_ADDRESS>:2181
INFO[2017-05-13 17:50:42] connect to zookeeper server success!
Connected to <IP_ADDRESS>:2181
Authenticated: id=97949346128527401, timeout=5000
Re-submitting `0` credentials after reconnect
Authenticated: id=97949346128527400, timeout=5000
Re-submitting `0` credentials after reconnect
[restful] 2017/05/13 17:50:42 log.go:30: [restful/swagger] listing is available at /apidocs.json
[restful] 2017/05/13 17:50:42 log.go:30: [restful/swagger] /apidocs/ is mapped to folder/root/3rdparty/swagger-ui-2.2.8
INFO[2017-05-13 17:50:42] start listening on <IP_ADDRESS>:9999
INFO[2017-05-13 17:50:42] Electing leader success.
Connected to <IP_ADDRESS>:2181
Authenticated: id=97949346128527402, timeout=5000
Re-submitting `0` credentials after reconnect
Recv loop terminated: err=EOF
Send loop terminated: err=<nil>
INFO[2017-05-13 17:50:42] subscribe to mesos leader: master@<IP_ADDRESS>:5050
ERRO[2017-05-13 17:50:42] handleEvents goroutine decode response got err: EOF, abort
ERRO[2017-05-13 17:50:42] EOF                                           event=mesosFailure
ERRO[2017-05-13 17:50:42] logger handler got event: {"type":7,"error":{"message":"Framework has been removed"}}  handler=logger
INFO[2017-05-13 17:50:44] re-register to mesos now
Connected to <IP_ADDRESS>:2181
Authenticated: id=97949346128527403, timeout=5000
Re-submitting `0` credentials after reconnect
Recv loop terminated: err=EOF
Send loop terminated: err=<nil>
INFO[2017-05-13 17:50:44] subscribe to mesos leader: master@<IP_ADDRESS>:5050
ERRO[2017-05-13 17:50:44] handleEvents goroutine decode response got err: EOF, abort
ERRO[2017-05-13 17:50:44] EOF                                           event=mesosFailure
ERRO[2017-05-13 17:50:44] logger handler got event: {"type":7,"error":{"message":"Framework has been removed"}}  handler=logger
INFO[2017-05-13 17:50:46] re-register to mesos now
Connected to <IP_ADDRESS>:2181
Authenticated: id=97949346128527404, timeout=5000
Re-submitting `0` credentials after reconnect
Recv loop terminated: err=EOF
Send loop terminated: err=<nil>
INFO[2017-05-13 17:50:46] subscribe to mesos leader: master@<IP_ADDRESS>:5050
ERRO[2017-05-13 17:50:46] handleEvents goroutine decode response got err: EOF, abort
ERRO[2017-05-13 17:50:46] EOF                                           event=mesosFailure
ERRO[2017-05-13 17:50:46] logger handler got event: {"type":7,"error":{"message":"Framework has been removed"}}  handler=logger

when framework is down, and reconnect the mesos, the framework id should be reuse anyway. but current implement it not remove the framework
[zk: <IP_ADDRESS>:2181(CONNECTED) 5] get /swan/snapshot
{"apps":{},"offerAllocator":{},"instances":{},"frameworkid":"b7a80720-6a28-44eb-81b8-6f6ac43952e3-0000"}
c

it shoud be
// NOTE: To avoid accidental destruction of tasks, production
	// frameworks typically set this to a large value (e.g., 1 week).
	FailoverTimeout *float64 `protobuf:"fixed64,4,opt,name=failover_timeout,json=failoverTimeout,def=0" json:"failover_timeout,omitempty"`

already set FailoverTimeout to 1 weeks


Get first working version of persistent executor

This task involves numerous changes across the whole code base and is likely to be a messy PR. Nothing else should be done in parallel with this step.

First iteration of this is done by #138, more specific tasks will be created


README: clearSession example

The argument passed to clearSession() should be the context object rather than session in the code example for clearSession().
session in the example is a reference to context.clientContext.sessionCookieData (the return value of getSession()).

The code-snippet found in README:
clearSession(session); // Will clear the session object in place.
Suggested edit:
clearSession(context); // Will clear the session object in place

Good find 🔍 ! Thank you very much @kfuquay !
I pushed a fix for this 😄 .


[main] Upgrade to latest dependencies

Cron -knative-prow-robot
/cc knative-sandbox/networking-wg-leads
/assign knative-sandbox/networking-wg-leads
Produced by: knative-sandbox/knobots/actions/update-deps
Details:
bumping knative.dev/pkg 616f1ab...3a4cc56:
  > 3a4cc56 Add configmap informer factory (# 2466)
  > 13bdd74 add popany to bucketer (# 2445)
bumping knative.dev/networking 1890039...d1f3f8e:
  > d1f3f8e upgrade to latest dependencies (# 634)

/lgtm
/approve


[CELEBORN-620] Fix columnar shuffle codegen exception

What changes were proposed in this pull request?
Fix columnar shuffle codegen exception. This is a refactoring of #1523。

The JIRA ticket does not resolve correctly

@pan3793  jira has been closed.


Added delete() method for arrays and dataframes

Closes https://github.com/bluesky/databroker/issues/712


Use re.MULTILINE instead of re.DOTALL

Not sure which use cases this change breaks, but I found I need the
other mode to also catch trailing newlines when removing rcsids from
old C code with this invocation: codemod -m '^.+?RCSID.+?$\n*'
Or maybe we could add a command line option to choose the multiple line mode?

Thanks! A command-line option (with the current behavior as the default) sounds like it might be best.

Hey there! I found that it is more complicated, MULTILINE and DOTALL do different things and can even be combined. Plus there is a comment in the code that says that the multiline suggestor is "hacky and should be rewritten". I can only imagine it to be quite tricky, given the lack of a simple notion what a chunk is. Not sure if you could run this by the original author, at the moment I have no good idea how to do this cleanly and will therefore close this PR for the time being.

OK, that sounds reasonable. Thanks!


change dcos-diagnostics nssm config (DCOS_OSS-5697)

High-level description
What features does this change enable? What bugs does this change fix?
Corresponding DC/OS tickets (required)

DCOS_OSS-5697 Fix NSSM configuration file for Mesos agent, Diagnostic and Telegraf EE / fix diagnostics nssm config

Related tickets (optional)

DCOS-ID JIRA title / short description.

Checklist for component/package updates:
If you are changing components or packages in DC/OS (e.g. you are bumping the sha or ref of anything underneath packages), then in addition to the above please also include:

[ ] Change log from the last version integrated (this should be a link to commits for easy verification and review): example
[ ] Included a test which will fail if code is reverted but test is not. If there is no test please explain.
[ ] Test Results: [link to CI job test results for component]
[ ] Code Coverage (if available): [link to code coverage report]

@mesosphere-mergebot changelog-not-required reason

@mesosphere-mergebot request-review @vadymzagorodko

@mesosphere-mergebot request-review @DominikDary

@mesosphere-mergebot request-review @jongiddy

@mesosphere-mergebot changelog-not-required Part of Windows changes


External issue reporter doesn't show up after switching away from and back to an extension

Testing #180757

Select an extension that implements the api
Select an extension which doesn't
Select the same extension from step 1
:bug: still shows the section for the extension from step 2

Is this what you mean? If so, I can't seem to repro it:

(not pictured is the macOS native drop down where I am switching between extensions. "sandbox" implements the API)
Do you see anything in dev tools?

Hmmm, can't repro this anymore, I swear I saw it yesterday though... closing for now, will reopen if I find it again.


[feat] add a simple dashboard to customise links

It would be awesome if there is a dashboard where we can choose theme, add links.
We could only add this in the development environment by checking the variable process.env.NODE_ENV

Sounds nice 👍🏻 , gonna do right soon 👀


14px all the things

FontAwesome and material design icons are only pixel perfect at font-sizes multiple of 14px. (This is not noticeable on retina displays that actually render more than 14px).
This change makes the UI look much more crisp on my ubuntu laptop. 13px size makes all icons blur.

Sorry @SylvainCorlay, needs a rebase.

rebased

cc @ellisonbg, this was a point of contention.

I am probably opposed to moving to 14px for all of our UI fonts (icons+text) just to get icons to look right on certain screens. I think it is just too big for a dense UI like ours. A good comparison is Gmail or GDrive, which use 12.8px as the UI font. If we were to use 14px, we would need to rethink the sizing of lots of elements on the page such as the tabs, etc.
I could probably be convinced to accept 14px for icons only though, but am unhappy about having to make this compromise. Also, when we start to use the custom icons @cameronoelsen has designed, we can make sure they render pixel perfect at 13px.
The main question I have about typography is how it looks to have a UI font at 13px, but the user content at 14px. I think that right now it does look a bit odd having a UI font that is smaller than the content font. The existing notebook has this configuration of font sizes, but it feels more off in jupyterlab. That does point to either using 13px everywhere or 14px everywhere.
Most important though -  we should make make the decisions about font sizes based on solid typographical principles rather than the minute rendering details of certain icons on certain platforms.
But to better allow us to assess the situation, @SylvainCorlay could you post some screen shots of the changes in this PR?
I do think it is important to explore these design questions though at this point, so this is helpful...

First. some small-sized screenshots on ubuntu + chrome
Before:

After:

so icons are indeed crisp at pixel perfect size, and not at other sizes.

By the way these screenshots expose a bug with the default browser style sheet which is fixed in #147. (cf gray brackground in cell-type dropdown).

I am probably opposed to moving to 14px for all of our UI fonts (icons+text) just to get icons to look right on certain screens.

So I wanted to picked this up: it is not certain screen but all screens others than retina screens on OS X.

I could probably be convinced to accept 14px for icons only though, but am unhappy about having to make this compromise. Also, when we start to use the custom icons @cameronoelsen has designed, we can make sure they render pixel perfect at 13px.

That would require designing all the possible icons for the UI at 13px, and forbid the use of others (since no popular icon set has a 13px pixel-perfect size). Or, if you go with certain icons being ok at 12, and others at 13 or 14, it is going to be difficult to manage...

Most important though - we should make make the decisions about font sizes based on solid typographical principles rather than the minute rendering details of certain icons on certain platforms.

I thought I gave convincing  arguments in earlier discussions about vector icons and pixel perfection, hinting strategy, why SVG does not solve it better etc. All icon collections out there make a pretty big deal about pixel perfection...
What are the solid typographical principles that led to the magical 13px?

What are the solid typographical principles that led to the magical 13px?

Hum, I am reading my own message, and finding it harsh - which was not at all the intention.

I forgot something, which we already discussed briefly when cameron started the new icon set: the minimal size for the base "Material Design"  icons is 24px, so it is probably not a good fit for an applications like JupyterLab (on non OS X retina displays). With its 14px, font-awesome has the smallest pixel-perfect size of all, which is a good argument for it.
You can check out the table here: http://tagliala.github.io/vectoriconsroundup/

Can you rebase? @ellisonbg is also in favor of merging and iterating now.


feat agent yum download

feat: agent deb download
test: proper assertion
feat: agent yum dowload

Duplicated https://github.com/newrelic/infrastructure-publish-action/pull/25