[Feature Request] Save History for Particular Scene

The plugin is really Time saver but for the people who works on multiple scenes the history and favorites get erased when a new scene is loaded.
Maybe you can add a Scriptable Object per scene to store the selection history and load them on editor start.
Thank you

I got it working, But I am sure that it would be not 100% appropriate way. So kindly check and let us know your remarks.
How it works: We create a scriptable object in a specified folder for everyscene and save history in it. When scene is saved we overwrite the scriptable object with new history and when scene is loaded we read history from it. Following are the code modifications:
New files added:
SaveSelectionHistory.cs  :  https://pastebin.com/x9cmpFsF
Existing files modified:
SelectionHistoryWindow : https://pastebin.com/B0M835f7  (Two lines added and two functions added)
SelectionHistory.cs : Allowed History List and Favourites List property to use Setter { list=value } so it can be modified from selectionhistorywindow.cs class
! One strange thing happens is that the scriptable object gets updated everytime the history and favorites lists are updated. However I have coded it to update only on EditorScene Saved and Opend

Sorry I'm just seeing this today.. can't believe I didn't see the feature request before (my github notifications are not working for some reason).
So the feature is something like keeping history/favorites per scene, so if you close it and open it again, you recover your saved stuff?
A possible test case: open scene, select one or more objects, pin of of them, open another scene, open first scene and you have your history and pinned objects.
I'm not sure about using scriptable objects and uploading them to your version control, even having merge conflicts or stuff like that, but probably, it seems it has to be something in the user editor prefs or in a personal folder (like user settings), right? Will think about it.

If you want, you can make a PR and I will merge it, the only addition I would suggest is having a new setting to the project to turn on/off this feature and leave it off by default. This is to avoid people using the plugin to having to take care of new assets appearing in the project without knowing why.

Now history stores/restores selected stuff from unloaded scenes, and there is a new issue to save to disk before closing the editor and restoring that. Will close this feature request.


app.UseRouting() does not contribute to the order of middleware execution (custom middleware runs first each time).

Hi, I'll try to briefly explain my finding:
Expected:
In the article https://docs.microsoft.com/en-us/aspnet/core/fundamentals/routing?view=aspnetcore-6.0
mentioned:

...

If the preceding example didn't include a call to UseRouting, the custom middleware would run after the route matching middleware.

What I've tried :

use app.UseRouting()
don't use app.UseRouting()
move  MapGet() before Use() middleware and use app.UseRouting()
move  MapGet() before Use() middleware and don't use app.UseRouting()

Observed:
The result is the same: "custom" middleware app.Use(...) always runs first in any of mentioned combinations.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 32374077-e02e-d6a6-1cea-05e58447b7cd
Version Independent ID: 86aeab13-1c25-9fc1-4e56-0390cb40c242
Content: Routing in ASP.NET Core
Content Source: aspnetcore/fundamentals/routing.md
Product: aspnet-core
Technology: aspnetcore-fundamentals
GitHub Login: @Rick-Anderson
Microsoft Alias: riande

Hi @ViktorYeah. The custom middleware is the code that runs as part of the app.Use call from the example you've shown. The endpoint that returns "Hello World!" always runs last, regardless of the order of the route matching middleware, UseRouting. The example demonstrates that, with UseRouting placed as-shown, the code inside of the custom middleware sees a null result when it calls context.GetEndpoint(). You should see the difference by inspecting context.GetEndpoint() in the custom middleware with and without the call to UseRouting.
If you still think there's an issue here, please provide a minimal GitHub repo as a demo.

Hi @serpent5 , thank you, that was an excellent explanation!

Hi @ViktorYeah. The custom middleware is the code that runs as part of the app.Use call from the example you've shown. The endpoint that returns "Hello World!" always runs last, regardless of the order of the route matching middleware, UseRouting. The example demonstrates that, with UseRouting placed as-shown, the code inside of the custom middleware sees a null result when it calls context.GetEndpoint(). You should see the difference by inspecting context.GetEndpoint() in the custom middleware with and without the call to UseRouting.
If you still think there's an issue here, please provide a minimal GitHub repo as a demo.

Well, this documentation about routing basics is out of date. The explained UseRouting behavior is incorrect:

However, apps can change the order in which UseRouting and UseEndpoints run by calling these methods explicitly. For example, the following code makes an explicit call to UseRouting:
...
If the preceding example didn't include a call to UseRouting, the custom middleware would run after the route matching middleware.

As explained by @serpent5 the order of execution is not changed.

the order of execution is not changed.

It's not about the order of execution of endpoints; it's about order of middleware; when the matching takes place.


Use gssapi-vendored features for rdkafka

I think we can update the docs again https://quickwit.io/docs/main-branch/get-started/installation#note-on-external-dependencies around sasl2 since this is vendored now.


[Gradle Examples] Instructions for enabling the JaCoCo agent for Arquillian based tests

Updated the README with instructions.
Configured JaCoCo on the multi-module project.

Can one of the admins verify this patch?

Can one of the admins verify this patch?

Can one of the admins verify this patch?

Can one of the admins verify this patch?

ok to test

@Ladicek Can you please merge this PR? I was planning on raising another PR that shows how to have the dependent project libraries bundled in the Arquillian war.

I was hoping we'd get a PR build, but Jenkins was hating me :-( Thanks @manovotn for merging this.


Update transform_age utility

Closes #86, closes #87

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

3 of 3 (100.0%)  changed or added relevant lines in 1 file are covered.
No unchanged relevant lines lost coverage.
Overall coverage increased (+0.01%) to 97.442%

Totals

Change from base Build<PHONE_NUMBER>:
0.01%

Covered Lines:
381

Relevant Lines:
391

💛  - Coveralls


Auto-add watcher for new issues

Hi, just a feature suggestion. It will be helpful that the plugin able to configure to add watchers during issue creation.

From my understanding, watcher configuration is nothing to do with the plugin. Just make sure the sender's role has been assigned with the permission: 'Add watcher'


Error when inserting images

Loading images on my local machine from my local machine causes the following error:
angular.js:11655 TypeError: fs.readFileSync is not a function
I don't know if this is a problem with pdfkit or my implementation.

You can't read from the file system in the browser. You'll need to add images by using a base 64 encoded image, or a typed array e.g. as a result of an ajax request.


Rec Room

Game Title
Rec Room
Game Website
https://recroom.com/
Anti-Cheat Software
Easy Anti-Cheat
Status of the Anti-Cheat
❔ Unconfirmed
Proof of Mention
N/A - Could not find any comment from developers on Wine support

anticheat is not supported, game does not launch.


add simulator form for achievements

POST:
/tenant/:tenantId/sim-user-achievements

fields:
achieverId -  TEXT
action - TEXT
value - NUMBER
For Passing data you can refer to https://ishaan-puniani.github.io/wallet-statistics/?path=/story/example-simulator--default

Depends on https://github.com/ishaan-puniani/wallet-statistics/issues/49


HTML escape char cover error

Version: 3.4.2, 3.4.1, 3.4
What happened:
When create script, if request url has html escape char, save and reopen this script
some char will be cover to html char
for example py and groovy
Save
'http://localhost/api?a=b&timestamp=123'

Reopen script will see
'http://localhost/api?a=b×tamp=123'

&times cover to ×

now i use concat string to fix it
HTTPResponse result = request.GET("http://localhost/aolai-member/member/info/getMemberInfo?noncestr=5d1042&"+"timestamp=1552983280", params)

before
GET("5d1042&timestamp=1552983280")

after
GET("5d1042&"+"timestamp=1552983280")

@donggyu04  please check this issue please.

@junoyoon Yes, I'll check this.

@totzcc
Hi, i think this issue occured by browser converting escape character to plain text when rendering view.

so this  will be rendered like
x
x
&aaa
&
&

i fix this issue and upload war.
could you download and use ngrinder-controller-3.4.2-071ffc.war in below link?
https://drive.google.com/drive/folders/0BydpbzD7dWIFMjA0NWYwY2UtYWFkZi00MzRhLTgzNDYtZTllZDMzODg1MWE2

This issue occurs in very special cases(e.g., query string contains escaped character like http://localhost/api?a=b&timestamp=123).
we fixed this and uploaded as unofficial version.
https://drive.google.com/open?id=1Mw2gN_9xdf70uT6mjszJj7JbVir5rvZF
it will be fixed in the next version.


feat(connect): ATL-6599 Use ZIO Failures and Defects effectively + RFC-9457 in connect

Description:
ATL-6599 Implement the following error-handling ADRs for Connect:

Use ZIO Failures and Defects Effectively
Use RFC 9457 for REST API Error Reporting

Checklist:

[ ] My PR follows the contribution guidelines of this project
[ ] My PR is free of third-party dependencies that don't comply with the Allowlist
[ ] I have commented my code, particularly in hard-to-understand areas
[ ] I have made corresponding changes to the documentation
[ ] I have added tests that prove my fix is effective or that my feature works
[ ] I have checked the PR title to follow the conventional commit specification

While I was working on Revocation PR, I've added 2 endpoints, and I wanted to hide 500 error messages just like you did it in this PR, and log them as well, here and here. Now since you've made this functionality work for every URL, please remove this .logError and .mapError calls from this endpoints 🙏 @bvoiturier

This won't actually work, @shotexa. The logic in this PR will only filter out unmanaged errors (ZIO defects) propagating through the call stack as exceptions and not the managed errors (ZIO failures) propagating via the effect's error channel.
The rule is not to type unexpected errors and let them propagate through the call stack as exceptions until they are caught "at the end of the world" and logged/obfuscated appropriately. Any managed error bubbling up to the top level via the error channel will be mapped to an ErrorResponse and reported "as is" to the user.
In your case, the code should be refactored to properly segregate managed failures and unmanaged defects. This should be done when the error-handling ADRs are applied to this part of the codebase...

So, just so I can understand it correctly. Currently if in any endpoint, error is thrown in repository layer user will receive the message similar to "could not find column bla bla bla", but we plan to hide this in one of the upcoming PR related to error handling?

No. Actually, the present PR ensures that any thrown exception that is not caught, and therefore propagated through the call stack up to the "end of the world" (i.e. application entry point), will be reported to the user as a 500 - Internal Server Error error without further details (no sensitive data leaked).
At the same time, the error response will contain a unique instance-id visible by the user and will be logged in the server console with the related stack trace, if any.
The thing is, in your code, the 500 errors are not exceptions but rather ZIO failures appearing in the effect's error channel. So I propose to fix this as part of the "error-handling in status list" refactoring effort.

What refactoring would be needed other than removing these extra .logError and .mapError calls? I mean since we are not catching errors in the repository layer now, any error (defect) happening there will already be returned as 500 error to the user, right? so this kind of errors won't land in the effects error channel anyway. I've added these lines just so I can filter errors coming from the repository layer, but since they are handled already, this extra lines serve no purpose. I might not be seeing something here tho.

The refactoring is about making the status list code part (actually, step-by-step, all parts) compliant with the error-handling ADRs referenced in the description above. The present PR is about applying this to the 'connect' part/slice of the code base. And looking at the number of files changed count (35), it is not trivial. So my proposition is to include the changes you are requesting in this broader refactoring effort and not mix it with this PR.

I've added these lines just so I can filter errors coming from the repository layer, but since they are handled already, this extra lines serve no purpose.

They won't actually be handled by this PR. They are failures defined in the error channel and will reported "as is" to the user. This PR will only "obfuscate" defects/exceptions. So I think your extra lines are purposeful.


new sphinx version introduces changes in sphinx.builders.html which cases docs json jobs to fail

since version 7.2.0 the json docs jobs fail with following error:
2023-08-18 06:18:06.400415 | fedora-pod | Extension error (sphinx.builders.html):
2023-08-18 06:18:06.400420 | fedora-pod | Handler <function setup_resource_paths at 0x7f53885156c0> for event 'html-page-context' threw an exception (exception: 'pathto')
2023-08-18 06:18:07.014725 | fedora-pod | ERROR: InvocationError for command /root/src/gitea.eco.tsi-dev.otc-service.com/docs-swiss/relational-database-service/.tox/docs/bin/sphinx-build -W --keep-going -b json api-ref/source doc/build/json/api-ref (exited with code 2)


Can't add ARCore as a pod dependency

I'm looking to create a framework (we'll call it SomeFrawework here) which has ARCore as a dependency, and distribute it via Cocoapods.
I only use the GeoSpatial module of ARCore it this developement.
When I work on the framework on its own, I have no issues adding ARCore in its podfile, adding "import ARCore" and making all of its feature work as expected.
Since I want to distribute it via Cocoapods, I have created the podspec of SomeFramework, a sample app and added "pod SomeFramework" in its podfile.
At this point, SomeFramework does not build anymore because "No such module: ARCore".
ARCore is recognized in the sample app, but not in my framework anymore.

The podspec in my framework is

The podfile in my sample is

What I tried to do to fix it :

Adding import ARCore in the sample app

Adding/Removing the   spec.static_framework = true in my podspec.

I used use_modular_headers! in my podfile instead of use_frameworks !

The only way I can make the sample app compile is to import ARCore as modules, like below.

But then the framework on its own does not compile anymore. (pod lib lint)

I've seen related issues like https://github.com/google-ar/arcore-ios-sdk/issues/55 and https://github.com/google-ar/arcore-ios-sdk/issues/43 but it's not quite the same as mine since I want to distribute my framework as a pod, and need a podspec to do so.
I feel like there's some link missing between the .xcframework of ARCore and my framework, but I can't seem to find the right way to do it. And it's always the same issue 'No such module'
Any help would be much appreciated and let me know if I can provide more information for you to help me on this !

@sammcd @devbridie @jankleinert @fredsa Is there still support on issues of this repo ?
Thank you in advance


Multiproc files not cleaned up if worker gets segfault/oom/...

In multiproc mode, if one of the gunicorn workers gets killed because of a segfault or out-of-memory situation, it doesn't get a chance to clean up its .db files. These files are thus left in the multiproc folder, distorting the metrics.
Maybe this can be solved by moving the cleanup hook into the gunicorn "master" process. My suggestion is to solve this in the Python client instead, by deleting all .db files with dead PIDs before aggregating the metrics.

This is by design. It's incorrect to delete the files while the process is still running, and it's expected that the user will clean them up during restarts.

In a segfault or OOM situation the process isn't running anymore. The gunicorn cleanup example in the documentation is incomplete; it doesn't cover the "Python crashes" situation.

I had thought worker_exit was handled in the master, presumably by doing a wait. Is that not the case?

No, see https://github.com/benoitc/gunicorn/blob/2b839ca14437c61780d6eaaa8b24ad31e021f2c6/gunicorn/arbiter.py#L576 (this is in the fork child branch)

Hmm, can we get a feature request in to be able to hook into reap_workers?

This would only work for gunicorn though. What do you think about my suggestion, which is a much more general solution to the problem?

You're presuming that pids are never reused, and deleting too many tiles. A solution based on wait is the proper solution.

So I'm not sure about for how long PIDs aren't reused, but I doubt it's quicker than the usual Prometheus scrape interval. In addition we could check if the PIDs are child processes of the aggregating parent process. What are the chances that a new worker process with the same PID is spawned within the scrape interval?
Maybe we should incorporate both solutions.

So I'm not sure about for how long PIDs aren't reused, but I doubt it's quicker than the usual Prometheus scrape interval.

That depends on how many processes are being spawned, and how the pid allocation strategy is.

In addition we could check if the PIDs are child processes of the aggregating parent process.

We don't actually know that the values are pids. They could be worker IDs (indeed it's better if they are, less label churn).

We don't actually know that the values are pids. They could be worker IDs (indeed it's better if they are, less label churn).

I see. To me this is a prime example of leaky abstraction that has to be improved.
Is your final suggestion to hook into reap_workers, i.e. make the forking process's responsibility to deal with all sorts of worker exits?

Yes. The only sane way to handle this it to make it the parent process's responsibility.

@jonashaag @brian-brazil Sorry for the ping if you were already aware, but I just wanted to make sure you knew that gunicorn 19.7.0 was released on March 1 with the child_exit() callback added, so this should be possible to implement now: http://docs.gunicorn.org/en/latest/news.html#id1

Gunicorn has the required feature now.


Zip

Is your feature request related to a use case or problem? Please describe.
A very common pattern in building quantum circuits is to have a bunch of two qubit gates that you want to put into a circuit, and you do this by acting on qubits from two lists
for q0, q1 in zip(qubits0, qubits1):
  cirq.CNOT.on(q0, q1)

In a similar way to having on_each we could, for two qubit gates, have zip:
cirq.CNOT.zip(qubits0, qubits1)

I'm unsure if this could also be extended across multiple qubit gates (or even be another way to do on_each).
What is the urgency from your perspective for this issue? Is it blocking important work?
P2 - we should do it in the next couple of quarters

What if instead we were to extend on_each to all gates and allow it to accept a sequence of tuples of cirq.Qid for gates that apply to multiple qubits? Then you could do
cirq.CNOT.on_each(zip(qubits0, qubits1))

This is not quite as concise, but more general since you can construct the sequence in other ways in addition to using parallel lists.
One problem with this would be that the current implementation of on_each tries to be flexible by "flattening" nested iterables down to a single list of qubits (it seems likely that this was meant to support cirq.X.on_each(q0, q1) and cirq.X.on_each([q0, q1]), but the actual implementation supports any amount of nesting of sequences). It's possible this could be made to work by leaving the last level "unflattened" for multi-qubit gates. Probably would still not be able to support "variadic" gates like measure and wait since they could take one or more qubits.

Funnily @dabacon had a comment about the tuple version of on_each here a year ago: https://github.com/quantumlib/Cirq/issues/2164#issuecomment-624887247
I think generalizing on_each to cirq.Gate makes sense, and then we can deprecate Single/Two/ThreeQubitGate classes.

Discussed on Cirq Cynque:

on_each for 1-qubit gates will stay the same
on_each for n-qubit gates will be strict - require Iterable of n-tuples
we'll deprecate Single/Two/ThreeQubitGate

Small suggested addendum to the above: copy Single/Two/ThreeQubitGate to cirq.testing when deprecating from gate_features, as unit tests become more cumbersome when you have to redefine these everywhere.

Deprecating Two/ThreeQubit gate here: #4207. (these can be done independently of the on_each migration; only SingleQubitGate deprecation must happen strictly after on_each migration).
I'll work on the on_each migration next.

Added on_each to Gate in #4236.
Note that deprecating SingleQubitGate will be more troublesome than the others, as things like _CALIBRATION_IRRELEVANT_GATES and NOISE_MODEL_LIKE depend on it.

For n-qubit gates which of the following do we want to allow (2-qubit examples below that would all represent the same thing):
A: varargs form gate.on_each([q1, q2], [q3, q4])
B: explicit form gate.on_each([[q1, q2], [q3, q4]])
C: flexible form gate.on_each([[[q1, q2], [q3, q4]]]), gate.on_each([[q1, q2], [[[q3, q4]]]]), etc.
D: flat varargs form: gate.on_each(q1, q2, q3, q4)
Is B is the primary one we were thinking? Do we want to support any of the others? Do we explicitly want not to support the rest of them?

I played around with this a while ago but never made a PR, so I just put up my branch in #4262. The changes there support all the options that you listed (I worked on this before the cirq cynque discussion about more limited on_each support).

Yeah my initial attempt tried to be too general too. I updated #4236 to support option B only. There's lots of tests that show what is supported and what isn't. In particular gate.on_each(zip(list1, list2)) is supported but gate.on_each(*zip(list1, list2)) isn't.

This is complete: Gate.on_each(zip(qubits_0, qubits_1, ...)) provides the requested support and deprecated classes have been removed.


Should value and type be included in uniforms?

I'm using PIXI v4.8.2 and I'm not sure if shader uniforms should use the value itself, or an object containing value and type?
As according to the API, it should be
filter.uniforms.time = performance.now();

rather than
filter.uniforms.time = {
    type: float,
    value: performance.now()
};

But I tried and it's not working this way: (result: all in black)
const magic = 0.3;
const uniforms = {
    magic: magic
};

const fShaderText = `
precision mediump float;
uniform float magic;
void main(){
    gl_FragColor = vec4(magic, 0.0, 0.0, 1.0);
}`;

var simpleShader = new PIXI.Filter('', fShaderText, uniforms);
bg.filters = [simpleShader];

And it works when using type and value like: (result: all in color (0.3, 0.0, 0.0, 1.0))
const uniforms = {
    magic: {
        type: 'float',
        value: magic
    }
};

I noticed that the source code do take the value property. So is the doc outdated?
Expected Behavior
Work with
const uniforms = {
    magic: magic
};

Current Behavior
All in black.
Possible Solution
Steps to Reproduce
Environment

pixi.js version: 4.8.2
Browser: e.g. Chrome 67
Device: e.g. Desktop

The  struct of the argument uniforms  in the  constructor  is different from the property uniforms.
( the argument uniforms  in the  constructor  should be called uniformsData , I think)
When you create a filter instance , you should use:
const uniforms = {
    magic: {
        type: 'float',
        value: magic
    }
};

But , when you want to change the value of magic, you just use :
filter.uniforms.magic = newValue;

.
By the way , in the most cases , you could ignore the 3rd  argument uniforms .

Its different in v5. I doubt it will be changed in v4. Would you like to change this article? https://github.com/pixijs/pixi.js/wiki/v4-Creating-Filters

I've added @finscn post to the article. Good idea about renaming the parameter


Module through export

Why do we have to recompile godot to have a module work? How about if instead of having to put the module in the modules folder and compile we can add the files in export when we want to release a game and have the module files added into the project.

How would that work? If you mean dynamic linking, Juan explained that was not possible due to binary compatibility (C++ has no standard ABI). A module compiled with gcc may not be compatible with an template compiled with clang or Visual Studio.

Yeah I don't see any way to make this work without compiling both the editor and the templates against the module, as done currently.

Just some thoughts:

Dynamic linking: wouldn't it be possible by compiling a .so(linux), .dll(windows) and .dylib(mac), for each non-compile-time module (probably with a bit different API), to create those modules?
Child processes: if it is not possible/hard to do with dynamic linking, maybe we can compile full programs (per-platform), and then spawn them as child processes, communicating with them through stdin and stdout. Would make custom modules much slower, but for some things it would be better...


Remove "lookup" logic from the cluster-agent secret

The Problem
Right now the cluster-agent has this logic in the "secret-cluster-agent.yaml":
{{ $secret := (lookup "v1" "Secret" .Release.Namespace "cluster-agent-secret") }}

This is a query to the Kubernetes API that checks if the "cluster-agent-secret" exists or not. This is an anti-pattern for Helm,  and it should be avoided because it creates unnecessary racing conditions. The only way that this would work is if I guarantee that the secret exists before the chart is rendered and executed, but this approach is bad because Helm is not a good tool to define order in which resources are deployed. Basically my deployer now needs logic to say "first deploy the secret, and then deploy the cluster agent". This type of logic is not supported by Helm or other Kubernetes deployers like ArgoCD, Kustomize or Kaptain. So... basically, we're stuck with a manual step or we have to code custom logic just to make this automatic.
Also, our Helm CI is breaking because to validate the configurations we do Helm Template. But the template will always break because it has no access to the cluster API, so the lookup function always returns an empty map.
The solution

Simply ask for a variable in the values.yaml called "customSecretName", so I can say something like:

customSecretName: my-secret

I can create this secret in the same automation, in another helm chart dependency, as another ArgoCD resource... Many options. The point is that I'm creating my own secret and letting the chart know the secret name.

Then in the "secret-cluster-agent.yaml" just add the logic saying "if .Values.customSecretName is defined, do not render the cluster-agent-secret"

In the deployment add the logic "If .Values.customSecretName is defined, use that secret to inject secrets in the container. Otherwise, use the cluster-agent-secret"

Why is this a solution?
Because now the racing condition will be solved by the deployment. The container won't be deployed until the secretMount exists, so it doesn't matter if the custom secret is created before or after the deployment, the deployment will wait until it exists.
Look at the way other Charts do this: https://artifacthub.io/packages/helm/wso2/mysql
That is the official Mysql Chart, look at the variable existingSecret. https://artifacthub.io/packages/helm/wso2/mysql?modal=template&template=secrets.yaml

Aside from the race condition, asking the chart to create the secret means a sensitive key must be passed to the chart. In reality, we most orgs manage their secrets using separate automation and infrastructure. Having to pass these to the chart on automation exposes risks and makes automating the deployment of this chart challenging. As @AndresPineros points out, leave secret creation to others.

Having to pass these to the chart on automation exposes risks and makes automating the deployment of this chart challenging.

agreed. contradictory to that, the current chart does that here:
https://github.com/CiscoDevNet/appdynamics-charts/blob/75a2a9f2734186497aa2e2951201c9a4a6feaa95/cluster-agent/values.yaml#L22


fix: mark event listeners inside loops as var props

If event handler is changing should be inside var props, because const props are ignored by vnodes. This is a case when we iterate over an items and return a jsx with an event listener.
closes #7032

closing in favour of #7085


Merge master into live branch for 1.3 release

Docs Build status updates of commit 39fc9dd:
:warning: Validation status: warnings

File
Status
Preview URL
Details

TerminalDocs/new-terminal-arguments.md
:warning:Warning
View
Details

TerminalDocs/TOC.yml
:white_check_mark:Succeeded
View

TerminalDocs/command-line-arguments.md
:white_check_mark:Succeeded
View

TerminalDocs/command-palette.md
:white_check_mark:Succeeded
View

TerminalDocs/customize-settings/color-schemes.md
:white_check_mark:Succeeded
View

TerminalDocs/customize-settings/global-settings.md
:white_check_mark:Succeeded
View

TerminalDocs/customize-settings/key-bindings.md
:white_check_mark:Succeeded
View

TerminalDocs/customize-settings/profile-settings.md
:white_check_mark:Succeeded
View

TerminalDocs/get-started.md
:white_check_mark:Succeeded
View

TerminalDocs/images/command-palette-command-line-mode.gif
:white_check_mark:Succeeded
View

TerminalDocs/images/command-palette-iterable-commands.gif
:white_check_mark:Succeeded
View

TerminalDocs/images/command-palette-nested-commands.gif
:white_check_mark:Succeeded
View

TerminalDocs/images/tab-search.gif
:white_check_mark:Succeeded
View

TerminalDocs/images/tab-switcher.gif
:white_check_mark:Succeeded
View

TerminalDocs/images/toggle-pane-zoom.gif
:white_check_mark:Succeeded
View

TerminalDocs/panes.md
:white_check_mark:Succeeded
View

TerminalDocs/troubleshooting.md
:white_check_mark:Succeeded
View

TerminalDocs/new-terminal-arguments.md

Line 11, Column 1: [Warning-multiple-h1s] Multiple H1s(H1 'New Terminal Arguments in the Windows Terminal'(panes.md(101,1) -> new-terminal-arguments.md(11,1))) are not allowed. You can only have one top-level heading.
Line 11, Column 1: [Suggestion-duplicate-h1s] H1 'New Terminal Arguments in the Windows Terminal' is duplicated with other articles: 'new-terminal-arguments.md(11,1), new-terminal-arguments.md(11,1)'. First level headings must be unique within a docset. NOTE: This Suggestion will become a Warning in late September, 2020.

For more details, please refer to the build report.
If you see build warnings/errors with permission issues, it might be due to single sign-on (SSO) enabled on Microsoft's GitHub organizations. Please follow instructions here to re-authorize your GitHub account to Docs Build.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
Note: Your PR may contain errors or warnings unrelated to the files you changed. This happens when external dependencies like GitHub alias, Microsoft alias, cross repo links are updated. Please use these instructions to resolve them.
For any questions, please:Try searching in the Docs contributor and Admin GuideSee the frequently asked questionsPost your question in the Docs support channel

Docs Build status updates of commit 924545a:
:warning: Validation status: warnings

File
Status
Preview URL
Details

TerminalDocs/new-terminal-arguments.md
:warning:Warning
View
Details

TerminalDocs/TOC.yml
:white_check_mark:Succeeded
View

TerminalDocs/command-line-arguments.md
:white_check_mark:Succeeded
View

TerminalDocs/command-palette.md
:white_check_mark:Succeeded
View

TerminalDocs/customize-settings/global-settings.md
:white_check_mark:Succeeded
View

TerminalDocs/customize-settings/key-bindings.md
:white_check_mark:Succeeded
View

TerminalDocs/customize-settings/profile-settings.md
:white_check_mark:Succeeded
View

TerminalDocs/get-started.md
:white_check_mark:Succeeded
View

TerminalDocs/images/command-palette-command-line-mode.gif
:white_check_mark:Succeeded
View

TerminalDocs/images/command-palette-iterable-commands.gif
:white_check_mark:Succeeded
View

TerminalDocs/images/command-palette-nested-commands.gif
:white_check_mark:Succeeded
View

TerminalDocs/images/tab-search.gif
:white_check_mark:Succeeded
View

TerminalDocs/images/tab-switcher.gif
:white_check_mark:Succeeded
View

TerminalDocs/images/toggle-pane-zoom.gif
:white_check_mark:Succeeded
View

TerminalDocs/panes.md
:white_check_mark:Succeeded
View

TerminalDocs/troubleshooting.md
:white_check_mark:Succeeded
View

TerminalDocs/new-terminal-arguments.md

Line 11, Column 1: [Warning-multiple-h1s] Multiple H1s(H1 'New Terminal Arguments in the Windows Terminal'(panes.md(101,1) -> new-terminal-arguments.md(11,1))) are not allowed. You can only have one top-level heading.
Line 11, Column 1: [Suggestion-duplicate-h1s] H1 'New Terminal Arguments in the Windows Terminal' is duplicated with other articles: 'new-terminal-arguments.md(11,1), new-terminal-arguments.md(11,1)'. First level headings must be unique within a docset. NOTE: This Suggestion will become a Warning in late September, 2020.

For more details, please refer to the build report.
If you see build warnings/errors with permission issues, it might be due to single sign-on (SSO) enabled on Microsoft's GitHub organizations. Please follow instructions here to re-authorize your GitHub account to Docs Build.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
Note: Your PR may contain errors or warnings unrelated to the files you changed. This happens when external dependencies like GitHub alias, Microsoft alias, cross repo links are updated. Please use these instructions to resolve them.
For any questions, please:Try searching in the Docs contributor and Admin GuideSee the frequently asked questionsPost your question in the Docs support channel

Docs Build status updates of commit ec731cf:
:warning: Validation status: warnings

File
Status
Preview URL
Details

TerminalDocs/new-terminal-arguments.md
:warning:Warning
View
Details

TerminalDocs/TOC.yml
:white_check_mark:Succeeded
View

TerminalDocs/command-line-arguments.md
:white_check_mark:Succeeded
View

TerminalDocs/command-palette.md
:white_check_mark:Succeeded
View

TerminalDocs/customize-settings/global-settings.md
:white_check_mark:Succeeded
View

TerminalDocs/customize-settings/key-bindings.md
:white_check_mark:Succeeded
View

TerminalDocs/customize-settings/profile-settings.md
:white_check_mark:Succeeded
View

TerminalDocs/get-started.md
:white_check_mark:Succeeded
View

TerminalDocs/images/command-palette-command-line-mode.gif
:white_check_mark:Succeeded
View

TerminalDocs/images/command-palette-iterable-commands.gif
:white_check_mark:Succeeded
View

TerminalDocs/images/command-palette-nested-commands.gif
:white_check_mark:Succeeded
View

TerminalDocs/images/tab-search.gif
:white_check_mark:Succeeded
View

TerminalDocs/images/tab-switcher.gif
:white_check_mark:Succeeded
View

TerminalDocs/images/toggle-pane-zoom.gif
:white_check_mark:Succeeded
View

TerminalDocs/panes.md
:white_check_mark:Succeeded
View

TerminalDocs/troubleshooting.md
:white_check_mark:Succeeded
View

TerminalDocs/new-terminal-arguments.md

Line 0, Column 0: [Warning-h1-missing] H1 is required. Use a single hash (#) followed by a space to create your top-level heading.

For more details, please refer to the build report.
If you see build warnings/errors with permission issues, it might be due to single sign-on (SSO) enabled on Microsoft's GitHub organizations. Please follow instructions here to re-authorize your GitHub account to Docs Build.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
Note: Your PR may contain errors or warnings unrelated to the files you changed. This happens when external dependencies like GitHub alias, Microsoft alias, cross repo links are updated. Please use these instructions to resolve them.
For any questions, please:Try searching in the Docs contributor and Admin GuideSee the frequently asked questionsPost your question in the Docs support channel


react-universal-hooks - use custom hooks in class

https://github.com/salvoravida/react-universal-hooks
Hi!
Could be usefull, if you need a custom Hook in your class component without refactor ...
your feedback would be appreciated!

react-universal-hooks seems to override react exports which doesn't feel like the right way to implement this. I think the approach discussed in https://github.com/streamich/react-use/issues/597 is cleaner and more versatile.


How to stay authorized or store authorization data?

Is there way to store authorization data to not to request code each time?

Yes, it is possible.
Check this code out.
The class MemoryApiState allows you to store authentication data as a file.
The requests with TLRequestAuthSignIn and TLRequestAuthSignUp sign you in and up respectively. Implemented authentication methods

you may need these,TLRequestAuthExportAuthorization  TLRequestAuthImportAuthorization.


amundsendatabuilder "leaks" dev dependencies

amundsendatabuilder declares an install_requires dependency on every package from requirements.txt.
This means that all consumers of this package must accept transitive dependencies on the specific versions of every package in amundsendatabuilder's development environment. For example, consumers of amundsendatabuilder are forced to install a specific version of flake8, even though this package doesn't actually need flake8.
Instead, we should declare concrete dependencies needed for development in requirements.txt and put the dependencies needed to install the package in setup.py. See also this SO post for one approach to reduce duplication between the two files: instead of having setup.py read requirements.txt, we can do the opposite and have requirements.txt reference the dependencies in setup.py through the special dot syntax.

cc @verdan

Agreed! had the same impression when we proposed this solution, as we are installing a lot of test requirements because of this.
The main problem to have the duplicated requirements is like most of the times people introduce the dependencies in one place and forget to do that in other.
This pip install -e things is a nice one, and can also think about this: https://stackoverflow.com/a/20720019

I think we fix this issue long back.


Use client report on replay upload failures

See https://github.com/getsentry/sentry-replay/pull/149
Instead of capturing as an error, we could send a client report instead.

Superseded by https://github.com/getsentry/sentry-javascript/issues/6502


[BKY-5599] update lint action

Update lint job to use blocky lint action

Nevermind. You cannot use actions from a private repo in a public repo


Check payment for compute.

Fixes # .
Changes proposed in this PR:

@mariacarmina can you fix the tests please and the rest can we get some reviews


Change Flotta deployment labels

Changed Flotta deployment labels in order to avoid duplications of operators using the label control-plane: controller-manager for pods that deployed in the same namespace.
Signed-off-by: arielireni<EMAIL_ADDRESS>

Please change the labels in other places as well; in some of them (like here, here or here) it is required for proper working of the operator, in others it is just a matter of consistency.
Please test the changes e2e (operator + agent both in OCP and some plain k8s (minikube)


Wait for chain to be synced after creation

After creating the Globalnet Mark chain, ensure that its sync'ed
by verifying that its indeed created in the kernel. Normally, this
should not be required, but on OCP deployments, it was noticed that
its taking few milliseconds for the chain to be actually created in the
kernel and its leading to errors when subsequent code is trying to
program rules in the chain. This PR now ensures that chain is
successfully created/sync'ed before returning.
Fixes: https://github.com/submariner-io/submariner/issues/1749
Signed-off-by: Sridhar Gaddam<EMAIL_ADDRESS>

@tpantelis @yboaron I'm trying to collect more information from Noam's setup if the issue is general to OCP or if it was seen because of underlying issues with OSP. Until then marking this PR as draft. I'll push separate PRs for other issues which are not directly related the current problem.

@sridhargaddam Any update? Seems like this would be a good one to merge.

Talking with @sridhargaddam, it seems like we're not seeing this issue, closing for now.


jdk8 aarch32 JDK doesn't seem to get downloaded to JCK jck_run folder?

The aqa_test_pipeline doesn't seem to be downloading the JDK ?

Looking at https://ci.eclipse.org/temurin-compliance/job/AQA_Test_Pipeline/1748/rebuild/parameterized, the AQA_Test_Pipeline is being run with SETUP_JCK_RUN = false, so no, it will not download the JDK in that case.

SETUP_JCK_RUN is only set for release https://github.com/adoptium/ci-jenkins-pipelines/blame/master/pipelines/build/common/openjdk_build_pipeline.groovy#L502. Not sure why both parameters cause and SETUP_JCK_RUN was set in the run of https://ci.adoptium.net/job/build-scripts/job/jobs/job/release/job/jobs/job/jdk8u/job/jdk8u-release-linux-arm-temurin/3/console.


Filepicker v2 - Don't store large files in the dataStore

Description
Create a new version file picker to solve the issue of file picker crashing on large file uploads by not storing files larger than 5MB in dataTree.
Fixes #6297
Type of change

Bug fix (non-breaking change which fixes an issue)
New feature (non-breaking change which adds functionality)

Checklist:

[x] My code follows the style guidelines of this project
[x] I have performed a self-review of my own code
[x] I have commented my code, particularly in hard-to-understand areas
[ ] I have made corresponding changes to the documentation
[x] My changes generate no new warnings
[ ] I have added tests that prove my fix is effective or that my feature works
[x] New and existing unit tests pass locally with my changes

Test coverage results :test_tube:
:red_circle: Total coverage has decreased
// Code coverage diff between base branch:release and head branch: filepicker-v2

Status
File
% Stmts
% Branch
% Funcs
% Lines

:red_circle:
total
54.84 (-0.09)
36.8 (-0.14)
33.13 (-0.09)
55.43 (-0.09)

:red_circle:
app/client/src/sagas/ActionExecutionSagas.ts
12.33 (-0.44)
1.92 (-0.06)
8.82 (-0.86)
14.25 (-0.35)

:red_circle:
app/client/src/utils/AppsmithUtils.tsx
57.14 (-0.49)
34.09 (-0.79)
37.5 (-3.04)
52.47 (-1.12)

:red_circle:
app/client/src/utils/WidgetRegistry.tsx
75.68 (-0.25)
100 (0)
27.03 (-0.75)
75.68 (-0.25)

:sparkles: :new:
app/client/src/widgets/FilepickerWidgetV2.tsx
35.58
0
17.24
36

@SatishGandham Verified this PR and it is working as expected


mitmproxy: fix dependency requirement

Motivation for this change
The build is failing due to the usual dependency pinning thing.
Things done

[x] Tested using sandboxing
Built on platform(s)

[x] NixOS
[ ] macOS
[ ] Linux

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change
[x] Tested compilation of all pkgs that depend on this change
[x] Tested execution of all binary files
[x] Fits CONTRIBUTING.md.

Hold on with this. I'm updating a whole bunch of Python packages and am including a fix for this package.

Fixed by @Mic92: 27ac74daa58667adff7b93eba8f6f157597137ac


Lucheng3

i am not sure about misc.xml, So i just accepcted both changes

I checked out ur branch and it seems it can't build

Can't merge since contains broken commit from yesterday's main


topics: Apply automatic follow/unmute when message moved to new topic.

This commit adds a feature, wherein when someone moves a user's message to be the first message in a topic, and the user has the Automatically follow topics initiated enabled, then the new topic will also be followed by the user.
Similarly, if the user has Automatically unmute topics initiated enabled, the moved topic would also be unmuted.
This is done through a new function -
apply_automatic_unmute_follow_topics_policy.
Fixes #28408

Screenshots and screen captures:

Self-review checklist

[x] Self-reviewed the changes for clarity and maintainability
(variable names, code reuse, readability, etc.).

Communicate decisions, questions, and potential concerns.

[x] Explains differences from previous plans (e.g., issue description).
[x] Highlights technical choices and bugs encountered.
[ ] Calls out remaining decisions and concerns.
[x] Automated tests verify logic where appropriate.

Individual commits are ready for review (see commit discipline).

[x] Each commit is a coherent idea.
[x] Commit message(s) explain reasoning and motivation for changes.

Completed manual review and testing of the following:

[x] Visual appearance of the changes.
[x] Responsiveness and internationalization.
[ ] Strings and tooltips.
[ ] End-to-end functionality of buttons, interactions and flows.
[ ] Corner cases, error conditions, and easily imagined bugs.

puppeteer tests failing at download

I spent an hour thinking about few edge cases:

What if the message is moved to a stream which the user can't access -- the current code creates a user topic row (that shouldn't happen)
If all the messages are moved (which is a common case when some new user creates a topic in unrelated stream), we are already handling that behaviour (just above the current code block). So the current code will lead to duplicate DB queries & logs. -- Note that we are not considering "automatic follow/unmute policy", so we need to make that tweak, if required.
If the user had has a visibility policy set for old topic, whether the "automatic follow/unmute policy" should prevail ?

If the user had has a visibility policy set for old topic, whether the "automatic follow/unmute policy" should prevail ?
I guess you're right... if propagate_mode == "change_all then the visibility policy set for the previous topic should prevail (that would make more sense).... in that case, we could also reduce a db query.

I updated it.

@prakhar1144 could you have another look at this, since tim and alya agreed upon the "automatic follow/unmute" not being applied in case when visibility policy is change_all in the #design thread.

@roanster007 thanks for the ping. I'll take a look in the morning tomorrow.

LGTM.
@zulipbot add "integration review"

@timabbott I addressed all the reviews of Prakhar, leaving this, for which he has asked your views:

We can use do_edit_message_assert_success

I don't think we can... that method is defined only inside the test -- test_edit_message_content_limit . Maybe do you want me to do a prep commit to move the definition of that method outside this test to be able to use it in other tests?

Hm, that's right. I'll let timabbott comment on this if it is worth the effort.

This is ready for another review.

I posted a couple comments on issues that are blockers for merging this. This implementation should work fine in the common cases, but we do need to be correct in corner cases too, which the tests don't attempt to verify, and after thinking about how to verify them in the tests, I realized that the logic is in fact wrong in those corner cases.

Dropping the integration review label since this has bugs that need to be resolved as the next step.

Addressed all reviews!

@timabbott I added the "integration review" label, since your feedback has been addressed. Please feel free to redirect if something else should happen first.


getPosition() returns the same value even though player keeps playing

Hi! Happy react-native-track-player user here. This issue might be somewhat rare, but still a huge problem for us.
Describe the bug
Occasionally the call to getPosition() returns the same value over and over again, even though the player keeps playing normally. E.g 60 seconds in, the call to getPosition would just start yielding the same position value over time. When it happens, it will be when I pause the track-player to play some other sound (through another iOS music player implementation), then pause that and resume the rn-track-player.
To Reproduce
Listen to a podcast episode, such as https://traffic.libsyn.com/secure/syntax/Syntax336.mp3?dest-id=532671. Add another music-source implementation and create a timer that every second switch over to that and let it play a sound in 60 seconds, then switch back and continue playing the podcast. Do this on repeat until the call to getPosition starts emitting the same value every secon.
Environment (please complete the following information):
Run react-native info in your project and share the content.
What react-native-track-player version are you using?
Are you testing on a real device or in the simulator? Which OS version are you running?
This happens on iOS only, both simulator and on real device. React-native version: 0.63.2, react-native-track-player version: 2.0.0-rc13
Code
let seconds = 0
let isPodcastPlaying = true
setInterval(() => {
    seconds++

    if (isPodcastPlaying) {
        console.log("Podcast position: " + (await trackPlayer.getPosition()))
    }

    if (seconds % 60) {
        if (isPodcastPlaying) {
            isPodcastPlaying = false
            await trackPlayer.pause()
            await someOtherPlayer.resume()
        } else {
            isPodcastPlaying = true
            await someOtherPlayer.pause()
            await trackPlayer.resume()
        }
    }
}, 1000)

Note that we've used this lib with great success for years. It's only until recently (not sure how long back though), this has started to become a problem, as it's not reliable to save the podcast position for the user.
Any ideas for helping us debug this issue would be highly appreciated! I've made sure the call on the native side (getting  player.currentTime) for sure yields the same position over time, even though the player keeps playing normally. No error is thrown

Can you try a 1.x version?
Also when you say another music player, are you meaning you switch to another app and play music, then switch back to your app and resume? Or something different?


Changes in the submitter plugin for CMS@Home (x509 proxy)

Agents submitting jobs to T3_CH_Volunteer resources (CMS@Home AFAIK) should not carry the x509 user proxy. So we need to make it configurable such that we can disable it during deployment.
For the record, these were the local changes I made in vocms0159:
cmst1@vocms0159:/data/srv/wmagent/current $ diff -rup sw/slc6_amd64_gcc493/cms/wmagent/1.1.0.patch2/lib/python2.7/site-packages/WMCore/BossAir/Plugins/SimpleCondorPlugin.py{.ori,} | colordiff
--- sw/slc6_amd64_gcc493/cms/wmagent/1.1.0.patch2/lib/python2.7/site-packages/WMCore/BossAir/Plugins/SimpleCondorPlugin.py.ori	2017-02-21 11:24:24.295401859 +0100
+++ sw/slc6_amd64_gcc493/cms/wmagent/1.1.0.patch2/lib/python2.7/site-packages/WMCore/BossAir/Plugins/SimpleCondorPlugin.py	2017-02-21 11:24:50.446201566 +0100
@@ -462,8 +462,8 @@ class SimpleCondorPlugin(BasePlugin):
         # Customized classAds for this plugin
         ad['DESIRED_Archs'] = "INTEL,X86_64"

-        ad['x509userproxy'] = self.x509userproxy
-        ad['x509userproxysubject'] = self.x509userproxysubject
+        #ad['x509userproxy'] = self.x509userproxy
+        #ad['x509userproxysubject'] = self.x509userproxysubject

         ad['Rank'] = 0.0
         ad['TransferIn'] = False

Who asked for this ? This should not be in the agent since in the long run we want to be able to submit to CMS@Home and other resources from the same agents. I thought the approach we took (and which works for now) is to strip out the proxy after the agent submits the job (somewhere on the HTCondor side).

Nobody, I've just thought we could make it configurable on the agent side. But if Laurence can tweak
the schedd to not use those ads (or to not add them), then it's even better and we can close this issue. I'm waiting for his reply.

If you want to make it configurable on the agent side, we could do that. I don't think it would be a lot of work. It might even be useful for now to have an extra insurance against exposing production proxies to cms@home users while we figure out how to do this (reliably) on the HTCondor side.
Wait for Laurences reply and see if we can skip this or might need it for now. In the long run it would leave use with dedicated agents just for cms@home though, which is not really what we want.

Fixed by https://github.com/dmwm/WMCore/pull/8615


Research found Indonesia only with contryId and Germany without contryId

The autocomplete function only shows the results for indonesia if we add contryId and if we remove it we only see the information relating to germany

I change the value of the contryId to other value such as when I want to do a search only in Mali I set 'ml' to the value contryId


cboxElement class into svg diagram

Hello,
i tried to add some modal window (on my  tags) into my svg diagram.
Indeed the class cboxElement was not add to my  tags, so the modal didn't work.
I had to add this class manually to my tags.
I just wanted to report this "issue". (did I do something wrong ?)
Tell me if I was not clear, I'm not so comfortable with English :)

You love clicking Close/Reopen button I see :wink:

Sorry, I failed :(
2015-01-06 11:14 GMT+01:00 Alexander Obuhovich<EMAIL_ADDRESS>
You love clicking Close/Reopen button I see [image: :wink:]
—
Reply to this email directly or view it on GitHub
https://github.com/jackmoore/colorbox/issues/660#issuecomment-68848113.

Hi TickerPicker, my apologies for the late acknowledgement.  I did not realize until today that jQuery 1.x and 2.x cannot manipulate classes on svg elements, and Colorbox currently uses a class to keep track of which elements it has been assigned to.  This is supposed to be fixed in jQuery 3.0 (listed under "Attributes").
I'm sure you don't care about this anymore, but an imperfect fix for this would be to add the 'cboxElement' class to your SVG directly instead of using jQuery.addClass.

It looks like class support for SVG is back in jQuery 2.2 and 1.12: http://blog.jquery.com/2016/01/08/jquery-2-2-and-1-12-released/

👍


[BUG] Application Insights Failure Due to Service Bus SDK fails to deserialize the error.

Library name and version
Azure.Messaging.ServiceBus
Describe the bug
Issue Description:
We have reports of discrepancy in Application Insights failures. Initially, it appeared to be a UI problem. However, after further investigation alongside our Ingestion team, we have confirmed that the customer is sending payload data from their application in a malformed way, causing it to be rejected by our ingestion service.
We requested SDK logs of .NET SDK installed on their application to send data to Application Insights, and we have identified the root cause:
Application Insights is failing to deserialize the error that occurs when a .NET service (using the Service Bus SDK Azure.Messaging.ServiceBus.dll) attempts to connect to a Service Bus topic or subscription that does not exist.
Upon analyzing the issue, we have determined that the problem lies within the Service Bus SDK (as indicated by the dll). When reviewing the code for the Service Bus message receive event, as observed in the  sample payload, we were unable to locate the code where the Service Bus sets the responseCode field for the context object:
(https://github.com/Azure/azure-sdk-for-net/blob/0cecccb564f603b5df7d7ba6f69be0ec7c0e2f2a/sdk/servicebus/Azure.Messaging.ServiceBus/src/Receiver/ServiceBusReceiver.cs#L335)
Expected behavior
The Service Bus SDK should handle the error gracefully and provide the necessary information for Application Insights to properly log the failure.
Actual behavior
Application Insights fails to deserialize the error when the .NET service using the Service Bus SDK attempts to connect to a non-existent Service Bus topic or subscription.
Reproduction Steps
NA
Environment
Environment Details:
Azure.Messaging.ServiceBus.dll version: Latest
Application Insights Version: Latest

Hi @shreenayak.   Thank you for reaching out and we regret that you're experiencing difficulties.   I'm afraid that I do not understand the scenario that you're describing.  The Service Bus client library does not deserialize or interpret the payload of messages in any way; it is treated as an opaque blob of bytes.  Can you share some additional context about the scenario?
Please provide the exception that you're seeing as well as the associated stack trace.  It would also be quite helpful to see the logs that you are referring to, if you are able to share them.


Cannot sent to multiple recipients if no third parameters (substitutions) provided on the $tos array list or by not using them in Subject, PlainTextContent, and HtmlContent Object

Hi @thinkingserious,
No email has been sent when using this link when I tried to make the third parameters (substitutions) to an empty array

and by not using the third parameters (substitutions) on the Subject, PlainTextContent, and HtmlContent

Also found out that if the third parameters on the $tos array list is always the same like the "-name-" => "Jayson Suyat" for 5 recipients only one person will received an email.
Originally posted by @jhayg12 in https://github.com/sendgrid/sendgrid-php/issues/840#issuecomment-503409646

Hello @jhayg12,
What is the result you are trying to achieve? Perhaps our transactional templates are better suited for your use case. I believe the second example there is what you need.
With best regards,
Elmer

Hi @thinkingserious ,
What I want to achieve is something like this.
subject: Test Subject Email
email_body: Test Email Body

I want to send the email template above to multiple users without seeing each other on the TO list.
I already tried this one link but I don't want to use any substitutions since my email template should be the same to all.
But when I tried to put some substitution parameters on the email subject such subject 1 and subject 2 it works as expected but it does not what I want. Is it possible to use this link without using substitutions parameters
Thanks

Yes, that's possible. Just don't pass any args beyond address and name:
$tos = [
    new \SendGrid\Mail\To(
<EMAIL_ADDRESS>        "Example User1"
    ),
    new \SendGrid\Mail\To(
<EMAIL_ADDRESS>        "Example User2"
    ),
    new \SendGrid\Mail\To(
<EMAIL_ADDRESS>        "Example User3"
    )
];


adding the save_test_result module.

Tied to proposal https://github.com/fusor/ansible-playbook-bundle/pull/92

Wait to merge for https://github.com/fusor/ansible-playbook-bundle/pull/92 to merge in

 (13) Add ability for APB to test itself using a test action.


MGDOBR-35: block input events containing reserved attributes

MGDOBR-35
Please make sure that your PR meets the following requirements:

[x] Your code is properly formatted according to this configuration
[x] Your commit messages are clear and reference the JIRA issue e.g: "[MGDOBR-1] - $clear_explanation_of_what_you_did"
[x] All new functionality is tested and uses org.assertj.core.api.Assertions for Assertions
[x] Pull Request title is properly formatted: MGDOBR-XYZ Subject
[x] Pull Request contains link to the JIRA issue
[x] Pull Request contains link to any dependent or related Pull Request
[x] Pull Request contains description of the issue
[x] Pull Request does not include fixes for issues other than the main ticket

Just one small comment from me @kostola


Fix tiler deadlocks when interacting with the database

Overview
The connection timeout for our database connection pool was initially set too low, which in conjunction with the number of threads allocated for Slick, caused many of the Slick threads to spin in a parked state while eating up all of the available CPU.
These changes reduce the overall number of threads to 5 ((2 * CPU Cores) + 1) and remove the explicit 2000ms connection timeout in favor of the 30s default.
Demo
This will hopefully go away:

Testing Instructions

Login to staging
Go into the editor of a project with the scenes from Egypt
Color correct them in any way you like
Interact with the map tiles (zoom in/out, pan around)
Note holes in the map or slow load times (with 1 tiler instance, requests can take 3-4 seconds, but they don't hang indefinitely)

I see that the Database is a singleton instance, newed up here https://github.com/azavea/raster-foundry/blob/3e2cfabf9843e3061313ab19814cabc078437c38/app-backend/app/src/main/scala/Main.scala#L24.
Having the server lean on the object instance in a heavily multithreaded way might be ill advised. I would consider moving the database activity behind an Akka Actor, and spawning many Actors that each have their own instance of Database. This could potentially let there be more throughput then this change allows, while avoiding deadlock.

Hmm - I'm not sure that's a great idea. If we switch to placing this behind actors, how will that interact with the connection pool (hikari) that we're using? Also, if that's the case, managing connections can get out of hand pretty quickly -- there's a lot of overhead to establishing database connections and the database can only handle so many. If there are different access patterns and so connection timeouts/parameters need to be adjusted we should set up different pools based on that, but I don't think we have enough metrics yet to know for sure. This is the use-case that a connection pool is designed for.
The usage I see usually in documentation and projects online that follow a similar pattern that we are using now is to new up a new Database class at the application entrypoint (Main.scala) then pass the database to services as an argument. I've also seen it used as a trait and mixed in, which is what we originally did in the API server -- and that's been under pretty heavy load with lots of database requests with the scene grid. I'm definitely a little out of my element here though in understanding what the difference is in terms of using a singleton object vs newing up a class at the application entrypoint and passing that everywhere.

Did this get wiped out in staging? I'm still seeing issues there.

+1 from me - this works great locally and I haven't been able to get it to lock up

If we switch to placing this behind actors, how will that interact with the connection pool (hikari) that we're using?

Akka-http is already based on akka-stream and akka-actor, so the connection pool is already interacting with actors behind the scene. Each request is eventually evaluated by actors in some pool of actors that evaluate and execute routes. I don't know the mechanisms behind that very well, so abstracting out the DB interaction to be behind a set of actors seems like a way place the interaction into a system we can more fully define and control.

Also, if that's the case, managing connections can get out of hand pretty quickly -- there's a lot of overhead to establishing database connections and the database can only handle so many.

My idea was that we would establish multiple connects as part of the initialization (like we are doing with one connection now), but put them behind some number of Actors - say the number that we are placing in the thread pool (5). Like I said, not entirely clear this would be a win, but it feels like having more control over how the DB gets hit by service routes than relying on a configuration param on a singleton instance being hit across threads.
This fix seems to work for now, so just something to consider for the future in case we run into problems again.


ML Project on Stock Price Analysis of UNIQLO

Describe the project you want to add with tech stack
A detailed data visualization and Analysis project on UNIQLO Company's stocks.
Expected behavior
Instilling a sense of understanding of Data Visualization and stock analysis.
Screenshots (optional)
Adding the project in next.
Additional context (optional )
Please consider this Project under Hacktoberfest and accept the PR.

#762
added the PR for this issue
@pranjay-poddar please review


BUG on saving bidirectional CuDNNLSTM/GRU

Please go to Stack Overflow for help and support:
https://stackoverflow.com/questions/tagged/tensorflow
If you open a GitHub issue, here is our policy:

It must be a bug, a feature request, or a significant problem with documentation (for small docs fixes please send a PR instead).
The form below must be filled out.
It shouldn't be a TensorBoard issue. Those go here.

Here's why we have that policy: TensorFlow developers respond to issues. We want to focus on work that benefits the whole community, e.g., fixing bugs and adding features. Support only helps individuals. GitHub also notifies thousands of people when issues are filed. We want them to see you communicating an interesting problem, rather than being redirected to Stack Overflow.

System information

Have I written custom code (as opposed to using a stock example script provided in TensorFlow):
OS Platform and Distribution (e.g., Linux Ubuntu 16.04): Ubuntu 18.04
TensorFlow installed from (source or binary): binary
TensorFlow version (use command below): 1.9.0rc2 and also test on nightly
Python version:  3.5
Bazel version (if compiling from source): None
GCC/Compiler version (if compiling from source): None
CUDA/cuDNN version:  not important
GPU model and memory: not important
Exact command to reproduce:

You can collect some of this information using our environment capture script:
https://github.com/tensorflow/tensorflow/tree/master/tools/tf_env_collect.sh
You can obtain the TensorFlow version with
python -c "import tensorflow as tf; print(tf.GIT_VERSION, tf.VERSION)"
Describe the problem
Wights are not stored when using tf.keras.layers.CuDNNLSTM/GRU with tf.keras.layers.Bidirectional
Source code / logs
import tensorflow as tf

class Model(tf.keras.Model):
    def __init__(self):
        super(Model, self).__init__()
        # this line works fine, but when commented and uncomment the second line, weights of rnn
        # will not be saved
        self.lstm = tf.keras.layers.CuDNNGRU(2)
        # self.lstm = tf.keras.layers.Bidirectional(tf.keras.layers.CuDNNGRU(2))

    def call(self, inputs):
        return self.lstm(inputs)

i = tf.random_normal((3, 4, 5))
m = Model()
o = m(i)
m.save_weights("test/save")

reader = tf.train.NewCheckpointReader("test/save")
# weights are not store when using CuDNNLSTM/GRU with bidirectional layer
print(reader.get_variable_to_dtype_map().keys())

I find that this problem exists even in undirectional cpu version rnn. Please fix it as soon as possible
import tensorflow as tf

class Model(tf.keras.Model):
    def __init__(self):
        super(Model, self).__init__()
        # this line works fine
        self.d = tf.keras.layers.Dense(2)

        # following three lines related with rnn do not work with Model.save_weights
        # self.d = tf.keras.layers.Bidirectional(tf.keras.layers.CuDNNLSTM(2))
        # self.d = tf.keras.layers.Bidirectional(tf.keras.layers.LSTM(2))
        # self.d = tf.keras.layers.LSTM(2)

    def call(self, inputs, training=True, mask=None):
        return self.d(inputs)

r = tf.random_normal((4, 3, 5))
m = Model()
o = m(r)

m.save_weights("save/save", save_format="tf")
reader = tf.train.NewCheckpointReader("save/save")
print(reader.get_variable_to_shape_map())

Thank you for reporting this. The issue has been fixed and the fix will be available in the next nightly release.

@pavithrasv thank you for your fix!

I tried the new-released nightly and it now works for me, thank you again @pavithrasv


[micro] Fix pytest fixture

Add default value for --test-build-only pytest fixture.
cc @areusch

@mehrdadh could you elaborate on the problem in the PR title/body?

@tvm-bot rerun


Implement tslint

Add tslint with tslint-microsoft-contrib rules.
Enable tslint in Travis-CI.
Temporally set tslint issues as warning.

This is failing to build because the package.json file you picked up has a broken "test:travis" script. Try getting the latest package.json file and adding your new script to that. We have too many people trying to update the build at the same time.

I fixed the merge conflicts so lets see what happens

Pull Request Test Coverage Report for Build 831

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 66.643%

Totals

Change from base Build 829:
0.0%

Covered Lines:
1942

Relevant Lines:
2788

💛  - Coveralls

Ok it builds now... we have a billion lint warnings but it builds


Models are being rendered over top other players in third person and in the inventory

crash-2023-06-10_17.44.15-client.txt
It's minecraft 1.16.5, for reference
With relative frequency, whenever players are near eachother (specifically someone with a model gets near someone who isn't), the player in their default skin says they get replaced with another players model both in f5 and the inventory screen, and a few moments later, the game crashes hard with a report like the one above. Unsure if it's a compat issue or something else.

Was an issue with Forgery.


Support for distinguish long or short press on button/touchpad.

With the usage of touchpad, I'm considering to use a short press to do movement , and use a long press to show the menu. I'm wondering, whether this function could be realized by calculating the duration between the press and release action?
Thanks a lot!

Yeah just subscribe to the respective events on VRTK_ControllerEvents and check the time difference.

@bddckr There were plans to decouple the current hardcoded controller button mapping values, right? Would it be reasonable to expand that so it's possible – instead of subscribing to controller events from an object – for a script on the controller to make it's own button event for something like "Trackpad longpress -> Menu" and the object select that?

Yeah the idea of "virtual events" could handle that very easily.

The requested thing can easily be done with the events like bddckr said so is there any reason to keep this open?
Of course this would be a nice event in the core system too but then again there are a lot of buttons and this would probably just clutter the inspectors (button dropdowns) a bit more and add minimal overhead when tracking states and interval. Could be an example script too instead of core stuff.

Thank you for your guys nice replies, such events have been done basing on your suggestion. I will close it.

Side note, Coroutines should also help simplify implementing this.

In the button event handler use StartCoroutine(MyLongPressCoroutine()) and save the returned coroutine in a variable.
And start MyLongPressCoroutine() with yield return new WaitForSeconds(longPressDelay); followed by whatever long-press code you want and end it by setting the saved coroutine variable to null.
Then in the on-release event for the controller button check if the coroutine is set, if so call StopCoroutine on it and set the variable to null.

I suppose actually we could create a helper class that would simplify this for people. A class with a static method StartLongPress(GameObject gameObject, Action longPressAction, float longPressDelay) that would return an instance with a Stop() method and automatically call whatever long press callback you stick into your code (it would eliminate the need for the user to actually work with any coroutines).


1 - Write use cases

To better understand the requirements and also later to use for testing.

Use cases can be found in the wiki/Uses-cases-and-Conditions


how to generate the w2v pkl data that loaded in code?

how to generate the w2v pkl data that loaded in code?

As far as I know , it is from the CVPR20-DAZLE paper here


mod_pagespeed installed but not working in Apache/2.2.17 (CentOS)

I have installed mod_pagespeed in my server using following steps
Step 1: wget https://dl-ssl.google.com/dl/linux/direct/mod-pagespeed-stable_current_i386.rpm
　　　　Step 2:   rpm -ivh mod-pagespeed-*.rpm
　　　　Step 3:     yum install  mod-pagespeed-stable
　　　　Step 4: Add the following into pagespeed.conf     [Path : /etc/httpd/conf.d/pagespeed.conf]
　　　　    ModPagespeedEnableFilters rewrite_javascript,rewrite_css
　　　　    ModPagespeedEnableFilters recompress_png,recompress_jpeg
　　　　    ModPagespeedEnableFilters combine_css,combine_javascript
　　　　    ModPagespeedEnableFilters extend_cache
　　　　    ModPagespeedEnableFilters insert_dns_prefetch
　　　　    ModPagespeedEnableFilters remove_comments
　　　　    ModPagespeedEnableFilters inline_google_font_css
　　　　    ModPagespeedEnableFilters convert_meta_tags
　　　　    ModPagespeedEnableFilters flatten_css_imports
　　　　Step5: Enable ModPagespeed  in pagespeed.conf
　　　　ModPagespeed  on
　　　　Step6: Restart the apache
I can see mod_pagespeed is installed correctly. Its  not combine any css and js.
CMD:  yum list | grep page
output:
man-pages.noarch                           2.39-12.el5                 installed
mod-pagespeed-stable.i386                  <IP_ADDRESS>-0                 installed
Also x-mod-pagespeed is not avalible in the header.
CMD: curl -D- http://localhost | less or CMD: curl -D- http://..**1.38 | less
output:
HTTP/1.1 403 Forbidden
Date: Thu, 29 Sep 2016 09:02:53 GMT
Server: Apache/2.2.17 (EL)
Accept-Ranges: bytes
Vary: Accept-Encoding
Content-Length: 3968
Content-Type: text/html; charset=UTF-8
Note: i tried samething in my local server. it was working fine.
i dont know what i am missing. Please help me out.
Thanks in advance.

It looks like you are receiving a 403/Forbidden response... I think mod_pagespeed will not process those, which explains the X-Mod-PageSpeed header missing.
However, when I query the server, I do get that header, but I noticed it is mentions a different mod_pagespeed version when I compare it to the one I would expect based on what I would expect based on the output of yum list that you posted (<IP_ADDRESS>):
curl -I -X GET http://<IP_ADDRESS>/

I get:
HTTP/1.1 200 OK
Date: Thu, 29 Sep 2016 09:46:15 GMT
Server: Apache/2.2.15 (CentOS)
...
X-Mod-Pagespeed: <IP_ADDRESS>-7443
...

I wonder how <IP_ADDRESS> was installed? Was that also via yum?

Thanks for quick reply,
sorry i mistakenly enter another server ip.
<IP_ADDRESS> is installed in  http://<IP_ADDRESS>/  server.
<IP_ADDRESS> is installed in http://<IP_ADDRESS>/ server.
yes i have installed through yum.

pagespeed_easter_75.txt

http://<IP_ADDRESS>/ times out for me, so I can't take a look myself. But if you could take a look at the html sources of a page with ?PageSpeedFilters=+debug on the querystring, then the module should write debug comments in the html source right after the javascript and css files that you would have liked to see combined. You may find a clue in there.

thanks.
Got an error as ''Cache-control: no-transform, preventing rewriting of http:\......"
please take look at:
view-source:http://<IP_ADDRESS>/easycampaign/?PageSpeedFilters=+debug

It looks like some of the resources served with cache-control:no-transform, which the module respects by default.  To turn off mod_pagespeed's behavior of respecting this header, you can configure:
ModPagespeedDisableRewriteOnNoTransform off

But it may be wise to first double check why this header is written in the first place.
Also see https://developers.google.com/speed/pagespeed/module/configuration#notransform

Its started working once i have added "ModPagespeedDisableRewriteOnNoTransform off" in pagespeed.conf.
Thank you very much

@rajamuthur great to hear it is working! I anonimized the ip addresses from my comments as requested.

Thanks

Hi...
step by step config for apache centos 6.9 -- text file for /etc/httpd/conf.d/pagespeed.conf


NSwag.ApiDescription.Client does not create nullable strings when Nullable is enabled

NSwag.ApiDescription.Client nuget, version 13.18.2
Actual:
Given a .NET 6 project with nullable reference types enabled and a component schema with a nullable string property, the generated class does not contain a nullable string. As a result, the application can throw NullReferenceExceptions while dereferencing these properties, something we are trying to avoid by enabling the Nullable .NET feature.
Example:
Nullable enabled

The component.schema definition from the openapi document

The generated class - the string is not marked as nullable

Expected
The generated class has a nullable string property

@RicoSuter if you agree this is an issue that should be fixed, let me know; it's something I would be interested in attempting to fix

Do you have the option to generate nullable reference types in the client enabled? (generateNullableReferenceTypes I think is the one)

Well that was easy. Thanks.


Change Dependency recipes do not work with dependencies defined in jvm-test-suites

I am using

OpenRewrite v6.17.1
Maven/Gradle plugin v6.17.1
Gradle v7.6.4

How are you running OpenRewrite?
I am running OpenRewrite using the Gradle Plugin, and my project is a single module project.
My build.gradle has the same dependency defined in the main dependencies and also with a jvm-test-suites section as shown below
dependencies {
    rewrite("org.openrewrite.recipe:rewrite-java-dependencies:1.14.0")
    implementation"javax.servlet:javax.servlet-api:3.1.0"
}

testing {
    suites {
        test {
            useJUnitJupiter()
            dependencies {
                implementation project()
                implementation"javax.servlet:javax.servlet-api:3.1.0"
            }
        }
    }
}

When I run either of the two recipes shown below only the javax.servlet:javax.servlet-api:3.1.0 in the main dependencies section is changed.

org.openrewrite.java.dependencies.ChangeDependency

type: specs.openrewrite.org/v1beta/recipe
name: com.sihutch.ChangeDependencyExample
displayName: Change Gradle or Maven dependency example
recipeList:
  - org.openrewrite.java.dependencies.ChangeDependency:
      oldGroupId: javax.servlet
      oldArtifactId: javax.servlet-api
      newGroupId: jakarta.servlet
      newArtifactId: jakarta.servlet-api
      newVersion: 6.x

org.openrewrite.gradle.ChangeDependency

type: specs.openrewrite.org/v1beta/recipe
name: com.sihutch.ChangeGradleDependencyExample
displayName: Change Gradle dependency example
recipeList:
    - org.openrewrite.gradle.ChangeDependency:
          oldGroupId: javax.servlet
          oldArtifactId: javax.servlet-api
          newGroupId: jakarta.servlet
          newArtifactId: jakarta.servlet-api
          newVersion: 6.x

I have created an example project here
I was expecting the dependencies in the jvm-test-suite block to also be changed. Can you please confirm whether this is a bug or something that is not implemented ? If that later, is there another recipe that you can recommend that can handle the jvm-test-suite case ?
Thanks
Si

I think you're correct in expecting such cases to be handled by org.openrewrite.gradle.ChangeDependency; I'd consider that something not yet implemented. You're welcome to help explore a fix, perhaps starting with a unit test on a draft PR similar to this test.

https://github.com/openrewrite/rewrite/pull/3665#issuecomment-1794948186
I'll share this oldie, but goodie reference. I envision a state that any of the Gradle dependency recipes work correctly over JVM test suites. As you can tell from the comment and what you've probably gathered from the recipes' behaviors, this is yet another location for dependencies to be declared and handled correctly.
This particular aspect will be made a little bit easier when the Trait feature lands for Gradle dependencies, but in fair warning fixing this issue will be a challenging one for a beginner. If you're still up for it, we can absolutely assist you in your journey.

Thanks @shanman190. If someone could outline a high-level solution, along with any areas of potential difficulty, or point me to some specific areas to familiarize myself with, then I'd be happy to take a look and see if I can make progress.

So for this one, I'd start by debugging the existing recipes to see if the dependencies block is being picked up as a DependencyHandlerSpec. If it is then there might be something else going wrong with the recipe.
If that isn't the case, then I'd reuse something that I formulated for the MigrateGradleEnterpriseToDevelocity recipe in so far as detecting where we are at in the buildscript. (See https://github.com/openrewrite/rewrite/blob/main/rewrite-gradle%2Fsrc%2Fmain%2Fjava%2Forg%2Fopenrewrite%2Fgradle%2Fplugins%2FMigrateGradleEnterpriseToDevelocity.java#L204-L220). From there, it's then making sure to accept the new locations into the existing update or change code paths.
The Groovy parser a lot of the time will leave off the type information and rely upon its dynamic dispatch, so that's what makes the initial variable hard to tie down.

Thanks @shanman190. I will take a look

@shanman190 The issue was that the dependencies block is not being picked up as a DependencyHandlerSpec .

For a more complete solution, I have a few questions

The 'testing' extension that provides the DSL is only added when the jvm-test-suite plugin is applied. Is it acceptable to add this to the RewriteGradleProject as I have done in my commit, or is there a better way to handle plugins?
In my commit example, I have handled the' test' suite, but suites can be named anything. Do you know of a mechanism for handing a child of suite with any name and then delegating that closure? For example, the test method below could be any method name.

interface SuitesSpec extends ScriptHandler {
    void test (@DelegatesTo(strategy=Closure.DELEGATE_ONLY, value=SuiteTestSpec) Closure cl)
}

Hi @sihutch,
That's unfortunate to hear that the method was not being type attributed as a DependencyHandlerSpec, but neither is it terribly surprising either.
As far as more stable remediation, what I'd probably now pivot to is code based upon a new PR of mine found here which introduces the Gradle Trait API for identifying dependencies.
I think the trait should receive one small update near the beginning of the block to confirm that the current method invocation is contained within a parent method invocation named dependencies. With each of Gradle's usages, they have always placed dependencies within a block named dependencies.
So envisioning something about like this:

Update the GradleTraitMatcher#test method

if (!isWithin("dependencies")) {
    return null;
}

Within ChangeDependency make updates to no longer use the old style dependency test and instead use the GradleDependency.Matcher trait matcher.

GradleDependency.Matcher gradleDependencyMatcher = new GradleDependency.Matcher();
if (!matcher.get(getCursor()).isPresent()) {
    // This method invocation is not an add dependency invocation
    return m;
}

@shanman190 - Cool. That's a much better solution

@shanman190 I have picked this issue up again as this PR https://github.com/openrewrite/rewrite/pull/4354 seems to have stalled, and we need this functionality.
I have implemented the trait approach from above, and it works; however, I am getting a single failing test in 'ChangeDependencyTest`
This test is failing. I have debugged a bit, and it is because the nameToConfiguration map in the Gradle project is empty. This test differs from the others as the dependencies are within the build script. Where should I look to try to solve this?

@sihutch, alright, the issue with that test is that we are grabbing the configurations from the project, but the classpath configuration is associated to the buildscript itself. Like in other places, we should probably just use one off handling for this configuration in particular (old style MethodMatcher on DependencyHandlerSpec). In the future, we may look into how to get this configuration into the GradleProject marker as well and can remove the special handling in the future.

Closing as fixed by https://github.com/openrewrite/rewrite/pull/4376


docs: update docs with latest setup guide

The developer-setup doc has been updated with steps to setup openSeachest for compiling ndm. Also new steps for running integration tests are updated.

Codecov Report

Merging #311 into master will decrease coverage by 0.54%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master     #311      +/-   ##
==========================================
- Coverage   52.64%   52.09%   -0.55%
==========================================
  Files          51       51
  Lines        2405     2405
==========================================
- Hits         1266     1253      -13
- Misses       1042     1052      +10
- Partials       97      100       +3

Impacted Files
Coverage Δ

cmd/ndm_daemonset/probe/eventhandler.go
46.05% <0%> (-7.9%)
:arrow_down:

cmd/ndm_daemonset/probe/udevprobe.go
60.16% <0%> (-5.7%)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d96bb03...c179211. Read the comment docs.


Update the readme to install argparse

I'm not sure if this is helpful but you might considering putting on the readme that you can installed twisted and also argparse. I've found that installing only twisted leads to a server connection fail, on my box, when you do :CoVim connect [port] [name]. However, once argparse is installed it magically works.  That or have a test python script to see if all python deps are met.
This was from https://github.com/FredKSchott/CoVim/issues/26
Another thing to possibly add is installing python-dev (resolves include python.h) to get twisted running. When I ran pip install twisted, my gcc errored out with no error useful message. Hope this helps.

I could have sworn argparse was installed with python

Yes, but with python >= 2.7


Fix over-eager project env replacement, for #4197

The Problem/Issue/Bug:
See bug reported in

https://github.com/drud/ddev/pull/4197#issuecomment-1340843620 Thanks @stasadev

The application .env file replacement (for laravel, shopware, etc.) was matching partials on the key, so

For example, I have DYNAMODB_CONNECTION in my .env (from this package) and ddev thinks it is the same as DB_CONNECTION, and replaced my config with DYNAMODB_CONNECTION="mysql".

How this PR Solves The Problem:

Use a more sophisticated pattern for replacement
Add TestWriteProjectEnvFile that covers (hopefully) all the things

Manual Testing Instructions:
Try the env file suggested by @stasadev
Automated Testing Overview:
Added significant test in TestWriteProjectEnvFile
Related Issue Link(s):

https://github.com/drud/ddev/pull/4197#issuecomment-1340843620
#3636
#3590

Thanks so much @stasadev -

Do you think it matters that it writes DB stuff if omit_containers[db]?
I recommend using ddev config --disable-settings-management in your situation. Is that adequate for you?

Just noticed it, does not matter to me.
Yes, that's exactly what I want 👍

@rfay Hey, every time I perform a ddev restart on a laravel project which doesn't have standard ENV vars like DB_USER they are always being either automatically added or overwritten which results in having to undo the changes, is this the desired behaviour? Thanks

That is the expected behavior, but you can just turn it off with settings_management_disabled: true, see https://ddev.readthedocs.io/en/latest/users/usage/cms-settings/
But I'd love to have you explain in more detail why your laravel project doesn't use those so I could understand better.

Thanks you for getting back to me, does settings_management_disabled: true  disable anything else or it is just related to auto configure .env based on the project type?

But I'd love to have you explain in more detail why your laravel project doesn't use those so I could understand better.

We are using a remote staging database environment which is shared between development team members so the credentials are different to those defaults which are auto-populated by DDEV. Each team member has their own unique user credentials to access the database.

I think settings_management_disabled: true will do what you want.
I do recommend using ddev pull to get the database rather than this, as it will prevent unexpected results of using a shared db.  But I know you've already thought this through.


systemctl not found

Hi ,
I am getting following errors from NPD in all nodes. How can I resolve these errors?

health_checker.go:86] error in getting uptime for kubelet: exec: "systemctl": executable file not found in $PATH
health_checker.go:180] command systemctl show docker --property=InactiveExitTimestamp failed: exec: "systemctl": executable file not found in $PATH, []
custom_plugin_monitor.go:280] New status generated: &{Source:ntp-custom-plugin-monitor Events:[{Severity:warn Timestamp:2023-07-17 11:39:00.176790184 +0000 UTC m=+8760.698855112 Reason:NTPIsDown Message:Could not find 'systemctl' - require systemd}] Conditions:[{Type:NTPProblem Status:Unknown Transition:2023-07-17 09:13:00.573485469 +0000 UTC m=+1.095550397 Reason:NTPIsUp Message:Could not find 'systemctl' - require systemd}]}

Versions:
NPD: v0.8.13
K8s: v1.23.17

/kind support


Color picker not saving changes

Hi, color customization isn't saving the changes. as reported on standard connectbot:
http://code.google.com/p/connectbot/issues/detail?id=290
Fixed in:
http://code.google.com/p/connectbot/source/detail?r=86c3a500a345
Is it possible to cherry-pick this ?

Has been fixed with a recent update, closing.


Question: Use of the spkl runners and solution patches

Open question... I have been using the spkl runner for a while now and got things setup pretty well. But feel like i might be missing something as i am source controlling my entire solution.
I feel like i should be making use of the patches functionality in Dynamics but cannot work out how to pull all of the resulting "solutions" into VS.
Ideas? Thoughts?
thanks

Anyone?

Hi- then latest version of the solution packager does unpack canvas apps and flows - so will work with spkl. You just need to update to the latest version of the sdk tools in nuget!

I normally control the main solution - and then unpack patches separately under a different folder. They would be exported as managed unlike the main dev solution because they are only ever for deploying then patch rather than source controlling metadata.


Questions about password security

hi,
At the command line execution, the -b parameter is set to 'username:password' authentication. I thought that when I type 'username:', I will enter the password when I don't enter the password, but that not the case. I don't want the plaintext password, because I think this is safe in my history.

Just to see that we're both on the same page, this is the HTTP authentication we're speaking about, right? This is not MySQL authentication.

If you use HTTP authentication, you may set ORCHESTRATOR_AUTH_USER and ORCHESTRATOR_AUTH_PASSWORD environment variables, and then you do no need to specify -b.


onMomentumScrollEnd wont fire if you scroll really fast on iOS

if you scroll fast enough onMomentumScrollEnd will not fire and it will skip index.
Is there a way to disable fast scrolling so that onMomentumScrollEnd will fire on every swipe?
Maybe create onPageChanged event that will fire when new page enters into the display view.
Anyone has a solution to this problem?
Here is the desired functionality https://raw.githubusercontent.com/rreusser/react-native-paged-scroll-view/master/example.gif (it detects new page when old page is still on half way out of the screen)

gif is from https://github.com/rreusser/react-native-paged-scroll-view library which is not supported anymore.

Same for android as well

for me in react native 61.5 (iOS ONLY) onMomentumScrollEnd doesn't fire if the user stops the scrolling with their finger. Basically the screen can't be standing still after a drag, or else onMomentumScrollEnd method won't execute. It can glide very slowly then stops and it works fine.


Options are not beign watched

The graph is re-created after the data change, but ignores the new options. This is solved changing the line
$scope.$watch('data', function(value) {

by
$scope.$watch('[data, options]', function(value) {

Hiya, would you be able to create a PR for this by any chance?

This is fixed in 2.1.1


Added few Zerocopter Programs

2 Zerocopter Programs Added

Mobile DE
Tyk

Author - Keshav

Added the programs here directly into master https://github.com/projectdiscovery/public-bugbounty-programs/commit/ee5e4424296725447de37d99679b2eede12df7e3 as one program was missing and another one had an invalid link, closing from here as it's added into master, thank you for adding more programs to this @tigv2


Metrics Glossary: updated diagrams and enabled metrics docs

Linked issue(s):
Fixes KOL-3353
Fixes KOL-2625
What change does this PR introduce and why?

Updates diagrams with proper styling
Enabled docs that were blocked by the diagrams
Cleaned up long lines on some of the metric docs
Surfaced the disabled docs to the main metrics glossary page

Please check if the PR fulfills these requirements

[x] Include reference to internal ticket and/or GitHub issue "Fixes #NNNN" (if applicable)
[x] Relevant tests for the changes have been added
[x] Relevant docs have been added / updated

Will merge this PR as is. It would be great if @billbai0102 can follow up with Andrew's feedback.


Fix intermittent exception when sending application to provider

Context
In several of our environments, including production, we see the
following exception:
ActionView::Template::Error
wrong number of arguments (given 1, expected 0)

It appears intermittently and occurs when trying to send the
ProviderMailer#application_submitted email. Its source is this line
in the email template:
@application.rbd_date.to_s(:govuk_date)

The error occurs because the rbd_date is nil (this is just a struct
attribute that holds the reject_by_default_at value of the
application_choice record).
The likely cause of this seems to be the transaction nesting that occurs
when SubmitReference calls the SendApplicationsToProvider service. The
call to this service is part of the top-level transaction. It iterates
over eligible application forms and calls SendApplicationToProvider for
each of their application choices. This service then contains database
changes wrapped in another transaction, followed by async delivery of
the application_submitted email.
Because these database changes are only committed when the top-level
transaction block closes, it seems likely that on some occasions a
Sidekiq worker is attempting to send the email before the
reject_by_default_at is present in the database record.
Shout out to @tijmenb for identifying the root cause.
Changes proposed in this pull request

This PR removes the transaction nesting, and instead leaves a linear
series of database updates and transactions for each discrete step of
the SubmitReference process.
Guidance to review

na
Link to Trello card
https://trello.com/c/8g0yXIfH

Things to check

[ ] This code doesn't rely on migrations in the same Pull Request
[ ] If this code includes a migration adding or changing columns, it also backfills existing records for consistency
[ ] API release notes have been updated if necessary
[ ] New environment variables have been added to the Azure config

To @stevehook's point, what if we branched earlier? a flow something like
if(this_is_the_last_reference_we_need)
  # one transaction which updates the references and commits the application state changes
  SendApplicationsToProvider.new.call
else
  # just update the reference
end

@stevehook You're right - a partial failure would be possible here. I figured initially each update is a discrete step in the process and that an exception at any stage would be easy to diagnose and fix, but ideally we'd want to rollback everything if SubmitReference fails (and, for that matter, simply call the service again to get to a correct state once any issues are fixed).
I think something like @duncanjbrown 's suggestion is needed here. Will rework.