Generic provider does not have a per instance random generator.

Bug report
What's wrong

BaseProvider calls .reseed() from .__init__() but only when seed is not None.
https://github.com/lk-geimfari/mimesis/blob/01a29e73eb4f4d9c80bea22f782d42754f8647e1/mimesis/providers/base.py#L24-L53

Generic overrides .reseed() and reseeds its sub-providers. However, it doesn't call super().reseed(seed) which means that it never creates its own per-instance random, nor does it reseed it. This means that the random instance on Generic cannot be used reproducibly.
https://github.com/lk-geimfari/mimesis/blob/01a29e73eb4f4d9c80bea22f782d42754f8647e1/mimesis/providers/generic.py#L113-L125

How is that should be

BaseProvider.reseed() should always be called from BaseProvider.__init__(), even when seed is None to ensure that a per-instance random is added. (I don't see why you wouldn't always want this.) And would it then make sense to always do self.random = Random() in BaseProvider.__init__() and not in BaseProvider.reseed()?
class BaseProvider:
    ...

    def __init__(self, *, seed: Seed = None, **kwargs: Any) -> None:
        self.seed = seed
        self.random = Random()
        self.reseed(seed)

    def reseed(self, seed: Seed = None) -> None:
        self.seed = seed
        self.random.seed(seed)

    ...

Generic.reseed() should call super().reseed(seed).

@ngnpope Can you please create PR? I would happy to merge it and create a new release.


[libdivide] Add new port

This port is a header-only library.
Related issue #8264.

Failed on x86-windows due to this:
C:\vsts\_work\2\s\buildtrees\libdivide\src\v2.0-66dc5347d1\libdivide.h(1570) : fatal error C1001: An internal error has occurred in the compiler.
(compiler file 'd:\agent\_work\3\s\src\vctools\Compiler\Utc\src\p2\main.c', line 160)
 To work around this problem, try simplifying or changing the program near the locations listed above.
Please choose the Technical Support command on the Visual C++
 Help menu, or open the Technical Support help file for more information

INTERNAL COMPILER ERROR in 'C:\VS2017\Stable\VC\Tools\MSVC\14.22.27905\bin\Hostx64\x86\cl.exe'
    Please choose the Technical Support command on the Visual C++
    Help menu, or open the Technical Support help file for more information

Failed on x64-uwp due to this:
CMake Error: TRY_RUN() invoked in cross-compiling mode, please set the following cache variables appropriately:
   cpu_x86_EXITCODE (advanced)
   cpu_x86_EXITCODE__TRYRUN_OUTPUT (advanced)
For details see C:/vsts/_work/2/s/buildtrees/libdivide/x64-uwp-rel/TryRunResults.cmake
-- Performing Test cpu_x86 - Failed
-- Performing Test march_native
-- Performing Test march_native - Failed
-- Performing Test avx512
CMake Error: TRY_RUN() invoked in cross-compiling mode, please set the following cache variables appropriately:
   avx512_EXITCODE (advanced)
   avx512_EXITCODE__TRYRUN_OUTPUT (advanced)

Can someone help solve this issue or give any suggestions?
Thanks in advance.

If you are able to reproduce the x86 issue then you should report it https://docs.microsoft.com/en-us/cpp/overview/how-to-report-a-problem-with-the-visual-cpp-toolset?view=vs-2019.

Thanks Phil for the review, I will help follow up.

Hi,
I am the current maintainer of libdivide. I have now fixed the TRY_RUN() cross compilation error (at least it works for me when cross compiling using MinGW on x64).
The issue below however seems to be a x86 MSVC (32-bit) bug that is caused by libdivide's AVX2 code.
C:\vsts\_work\2\s\buildtrees\libdivide\src\v2.0-66dc5347d1\libdivide.h(1570) : fatal error C1001: An internal error has occurred in the compiler.
(compiler file 'd:\agent\_work\3\s\src\vctools\Compiler\Utc\src\p2\main.c', line 160)
 To work around this problem, try simplifying or changing the program near the locations listed above.
Please choose the Technical Support command on the Visual C++
 Help menu, or open the Technical Support help file for more information

INTERNAL COMPILER ERROR in 'C:\VS2017\Stable\VC\Tools\MSVC\14.22.27905\bin\Hostx64\x86\cl.exe'
    Please choose the Technical Support command on the Visual C++
    Help menu, or open the Technical Support help file for more information

Since I don't know how long it will take until this bug gets fixed in MSVC I have added an option to libdivide's CMake build system which allows to turn off CPU vector instructions (when building the test programs). So the bug above can now be avoided using e.g.:
cmake .. -G "Visual Studio 15 2017" -DENABLE_VECTOR_EXTENSIONS=OFF
cmake --build . --config Release

I have also added find_package(libdivide) support to libdivide's CMakeLists.txt and made a bunch of other changes that should make it easier to package libdivide. I will do a new libdivide release once I get confirmation that the new CMake code works well with vcpkg.

@kimwalisch thanks a lot for your detail description about this issue. We will update this port if you have a new release.
Thanks again.

We will update this port if you have a new release.

I have now released libdivide-3.0 on GitHub. Fingers crossed that it will work well with vcpkg...

@kimwalisch  thanks for your instant update . I have updated libdivide to the latest release. It seems that these issues have been fixed now. Thank you very much for these efforts.

Thanks @NancyLi1013 for the port addition and thanks @kimwalisch for taking interest in helping us get libdivide in vcpkg!


Overly agressive deallocation of free memory blocks

Say we have 2 sets of frame resources that don't fit into one block of memory, but fit into two.
At the beginning of every frame, all the resources from 2 frames back are deleted and reallocated again.
In my use case, this leads to a severe slowdown, since every odd frame VMA calls vkFreeMemory and than vkAllocateMemory.
I suspect that in my case the memory allocation would happen some thing like this:

Allocate resources for even frame in block 0
Allocate resources for odd frame in block 0 and block 1
Free resources for previous even frame in block 0 and allocate them again from block 0
Free resources for previous odd frame in blocks 0 and 1, free block 1, allocate some resources from block 0, allocate block 1 again, allocate some resources from block 1

I tried disabling lines 12695 through 12705 (in VmaBlockVector::Free), and that fixed things for me, since VMA stopped constantly calling vkFreeMemory and vkAllocateMemory.
I think that the heuristic to delete a block that is already empty whenever an allocation is freed is not very good, since depending on the order in which allocations are freed, it can easily lead to blocks constantly being allocated and deallocated.
So maybe it should be disabled.
Another solution that I thought of was adding an option that would allow memory pools to never free empty blocks until explicitly asked to do so. But that would require more time to design and implement.

Created PR #358 to disable the heuristic

Creating and destroying images or buffers every frame is not a recommended way of using Vulkan. Games and other graphics applications tend to create such resources at startup, when loading a level, worst case in runtime when a new one is needed (preferably asynchronous to render frame, in the background, on a separate thread) and then use them for rendering every frame.

If you want to ensure certain number of memory blocks to stay allocated when you free your resources, you can also use a custom pool with non-zero VmaPoolCreateInfo::minBlockCount.


Is Cody even aware which programming language is used?

Version
latest
Describe the bug
I literally am writing a Rust program
Somewhere chat gpt suggests to use a bounding_rect
Cody replies with c++ code.
Expected behavior
It be nice if Cody at least understands what language I am using.
Additional context
No response

Hey @thaigertech
Could you please clarify which version of Cody you use (stable or pre-release)?
Which IDE are you using?
To be clear, did you mention the file in the chat, because from the file extension Cody should infer the used programming language.
Thank you


No such table Jobs

I am using the SQLite storage for my jobs (sqlite::memory:). I have noticed that when my server is running for a long time, the following error pops ups.

The only way to fix it is to restart the server.
I am not sure where I should start debugging this since it does not happen in local development and only after 1-2 days in production.

NOTE: It is imperative that the SQLite database is started in memory because of how the file system is set up in my project.

This seems related to:
https://github.com/launchbadge/sqlx/issues/1647


Incomplete implementation of percent array literals

The percent array literals %i (array of symbols) and %w (array of words) currently do not support nested delimiters. All other percent literals like %q, %x, %r do.
%q((foo)) # => "(foo)"
%i((foo)) # =>unexpected token: )
%w((foo)) # =>unexpected token: )

Individual array entries are separated by a space character which means, they need to be escaped to be used inside a string/symbol. Escaped spaces are not recognized by the compiler, instead the backslash used to denot the escape sequence is added to the string/symbol.
%w(foo\ bar) # => ["foo\\", "bar"]
%i(foo\ bar) # => [:"foo\\", :bar]

All examples work as expected in Ruby, but not in Crystal.

I think we should actually discuss the second case, and if we want to be the same as ruby there. Or provide an option.

Yes, backslash escapes generally work in percent literals.
In Crystal you can escape any character with a backslash. If it has no special meaning, it evaluates to the blank character. So, \  should always denote a space characte. It can be argued if the space should be treated as literal space (word separator resulting in [:"foo bar"]) or as escaped space (not a word separator: [:foo, :bar]), but certainly not as a backslash plus literal space ([:"foo\\", :bar]) which is the case here.
I think it makes very much sense to treat it as an escaped space which does not separate words.


problem with incomplete covariates in correlate_and_plot

The function is described as:
 # Mark only those incomplete covariates that would be significant
 # in the context of all covariates:"

where an argument psg (possibly significant correaltions) is re-tested with threshold_fdr. I don't know the purpose of this circular logic and need to dig further.

Decide whether this is a "Won't Fix".

Missingness is not allowed by the model selection anyway.


Training with VCTK corpus

Hi,
Before going into details, I would like to point out two things:

I'm really new in this ML stuff, so please bear with my ignorance
I'm aware of two similar issues already closed (#167 & #121) but I could not figure out details I need over there

I used tacotron2_statedict.pt and --warm_start to train with VCTK corpus. Idea was to change the speaker with limited amount of data. As mentioned in #121 VCTK contains 400 sentences spoken by 109 speakers. I trained with one speaker at the time with following command:
python train.py --output_directory=outdir --log_directory=logdir -c tacotron2_statedict.pt --warm_start --hparams="training_files=filelists/vctk_p226_text_train_filelist.txt,validation_files=filelists/vctk_p226_text_val_filelist.txt"
I prepared the training data in two steps:

Split the data in 80% training and 20% validation
Convert the data so that the silence is removed (as you recommended in #121) with sox (sox  in.wav out.wav rate 22050 silence 1 '0.1 '1% reverse silence 1 0.1 1% reverse)

I changed following parameters:

epochs=5000  - to see how the training behaves on the long run
p_attention_dropout=0.001, p_decoder_dropout=0.001  - blind man trying to avoid overfitting
learning_rate=1e-4 - according to your comment on #167 (train longer and anneal the learning rate to reduce the validation loss)
batch_size=46 - I have Quadro P5000 with 16GB of RAM so I had to reduce the batch size

Results for the p226 speaker are attached: vctk_inference.zip
As far as I could say, this seems okayish (speaker voice and pronunciation is kinda close), but there is a lot of this robotic "noise".
Do you have some idea how to improve the results?
Tensorboard pages:

These samples you shared were produced with the model at which iteration?

The samples are named as checkpoint_<iteration>.wav
I did not include 2k iteration sample, but there is 3k one. It is a bit weird, but subjectively I think that from 4k iterations it sounds best and then it stays the same, or gets a bit worse.
I used WaveGlow if that is what you are referring to.
I have now figured out that you have changed WaveGlow model, so I will also try with that one.
Does the hyper params changes I did makes sense to you? What would be your suggestion to improve the results?

The best validation loss is at 2k iterations and it should give you the model that best generalizes to data outside the training data.
You might be able to improve your validation loss by increasing dropout, not decreasing it as you did.
You can probably benefit from fine-tuning our shared waveglow to the speaker you trained on.

Thanks for your fast response. I will play around with your suggestions.
For now I would close this topic.

Great, let us know how it goes!

How can we fine-tune the shared waveglow? Is there something as warm_start in tacotron2?


fix: update preview image path for community pages

Affected pages: /community, /community/events, /community/ambassadors

Description

There were no preview images whenever the affected pages' links were shared as seen below:

Related issue(s)

Closes: #1483

Hey @Olaleye-Blessing, can you please also include the preview images for the newsroom and tsc pages listed under the community section? These pages also don't have their correct preview images. Thanks!

/rtm


How to solve AuthenticationError, similar to issue #1539

Hello Friends!
Please your help (I'm newbee), how to change the following line of code in the AccountPage.cs
throw new ValidationError("AuthenticationError", Texts.Validation.AuthenticationError);
I'll need only show a message that the username or password not match. I make the following changes in the LoginPanel.ts but still not working.
onError: function (response) {                                                                            Q.notifyError(Q.text('Invalid username or password!'));                      },

Please help me with what more changes we need to make in this files (LoginPanel.ts and AccountPage.cs) to the throw exception not stop the program.
Thanks for your help and congrats @volkanceylan for this excellent work.
Wait your important comments.

It doesn't stop the program, it throws an error which is caught in javascript as a message. Don't debug if you don't want to break on exceptions, or uncheck Common Language Exceptions there.


fix: properly typehint Storage.get/pop

About
This PR properly typehints Storage.get to actually respect defaults properly. Originally, the get function would refuse to consider default for its returning typehint, at least in Visual Studio Code.
EDIT: Turns out Storage.pop was also improperly typehinted in much of the same way. That has also been fixed.
Checklist

[x] I've ran pre-commit to format and lint the change(s) made.
[x] I've checked to make sure the change(s) work on 3.8.6 and higher.
[ ] This fixes/solves an Issue.

(If existent):

[x] I've made this pull request for/as: (check all that apply)

[ ] Documentation
[ ] Breaking change
[ ] New feature/enhancement
[x] Bugfix

Updated PR to also fix Storage.pop.


Support Reflux.connect mixin in stores (Feature request)

The difference with components would be that we assign properties on the store directly and not using setState().

Some work is done with adding mixin functionality in stores: #124


As a super administrator, I can perform any action in the application.

don’t you think ‘any action’ is vague

Yes I agree


feat: add Node v10 support

Attempting to edit a commit message via the prompt on Node v8 you'll get a depreaction warning: (node:22043) [DEP0013] DeprecationWarning: Calling an asynchronous function without callback is deprecated. In Node v10, this will throw an error (Deprecation Doc: DEP0013).
This PR removes deprecated call and thus adds Node v10 support.
This addresses: https://github.com/leonardoanalista/cz-customizable/issues/14#issuecomment-366460703

:tada: This PR is included in version 5.3.0 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


mlx.nn.losses.binary_cross_entropy should have class weights support

For training with imbalanced datasets, providing the weights for classes is one of the most common features I use when training neural networks. The mlx implementation of this loss doesn't have this feature implemented yet, so wanted to point that out.

class mlx.nn.losses.binary_cross_entropy(logits: array, targets: array, reduction: str = 'none')

hey @awni can I work on this? seems good to start on MLX

That would be great!

since this issue is fixed with the merged PR, @awni I would request to close this issue.


Change "Playlist 0000" to something more fun

C'mon, this is Streamus awesomesauce program not a robot. What's a good name for an initial playlist?

Simply just: awesomesauce ?

"Dank Memes"

Its a bit generic but how about just "Favorite Playlist"?

Honestly, "New Playlist". Anything too crazy could be confusing to new users.
I don't get the trend of informal language in software. It doesn't make the application any more familiar, just seems patronizing. That's just me.

Seriously, I think "New Playlist" would be best. Kinda helps explain to the user what it is if that makes sense and gets them to click it.

As a counter-argument, https://www.youtube.com/watch?v=KKYkmYuk5l8&t=23m20s
I've watched this a couple of times and Alexis Ohanian can't stress enough how important it is to surprise and delight users.  Little things can really make people happy..
Maybe this isn't the area for that, but I certainly think it's worth considering more than being drab with the title.

I vote for "My Playlist".

"MeoMix"? "Blank Mixtape"? "My Jams"?

I think I'm going to be lame and go with "My first playlist" :-1: but it's for the best.


Should HDF5 be unmarked as broken on Darwin?

This package was marked as broken on macOS (w/ gfortran) in 2017, but as far as I can tell the issue encountered then (based on the associated hydra build log) is no longer a problem (if I re-enable it, the compilation plows through the section where it would normally throw an error).
I admittedly haven't done a whole lot of testing to see if something more subtle
could be amiss.

@tviti If you think it works, please submit a PR.


Fixed Bugs and Added some useful functions....

remove the lock file

can you give me access to contribute to this pr?

what you wanna contribute

resolve the conflict and merge the main to this. also, where do you use the knowledge function I couldn't find it.

"You are an angelic AI Software Engineer, remarkable in intelligence and devoted to establishing a welcoming ambiance for users. Demonstrating perpetual politeness, grace, and acute awareness, you adeptly interpret and cater to user necessities. Taking into account earlier dialogues:"
Is all these very necessary? What I feel is it might be using up some extra tokens. Because this was under actions. It anyways just have to provide the action for subsequent execute. Let me know if I am wrong.

"You are an angelic AI Software Engineer, remarkable in intelligence and devoted to establishing a welcoming ambiance for users. Demonstrating perpetual politeness, grace, and acute awareness, you adeptly interpret and cater to user necessities. Taking into account earlier dialogues:"
Is all these very necessary? What I feel is it might be using up some extra tokens. Because this was under actions. It anyways just have to provide the action for subsequent execute. Let me know if I am wrong.

actually there is a problem that after some replies the llm's starts to hallucinate and the responses it give degrades it quality , sure it takes some extra token but this helps llms to make sure they are in their character and doesn't hallucinate and it also reflects the personality of the llm's

"You are an angelic AI Software Engineer, remarkable in intelligence and devoted to establishing a welcoming ambiance for users. Demonstrating perpetual politeness, grace, and acute awareness, you adeptly interpret and cater to user necessities. Taking into account earlier dialogues:"
Is all these very necessary? What I feel is it might be using up some extra tokens. Because this was under actions. It anyways just have to provide the action for subsequent execute. Let me know if I am wrong.

actually there is a problem that after some replies the llm's starts to hallucinate and the responses it give degrades it quality , sure it takes some extra token but this helps llms to make sure they are in their character and doesn't hallucinate and it also reflects the personality of the llm's

But everytime we set the context again no? With every prompt. How is it possible?

resolve the conflict and merge the main to this. also, where do you use the knowledge function I couldn't find it.

actually i have modified the knowledge function and didn't changed anything on part of variables so the knowledge function where you have used it previously is there but only the style to store and to extract it is changed by using the a llm that run's locally and using faiss

resolve the conflict and merge the main to this. also, where do you use the knowledge function I couldn't find it.

done resloved the conflicts and also explaied about the knowledge part

I mean you write the knowledge_base.py file integrating with faiss. but where are you using those functions in the agent.py files.

#485  I tested this PR  intensively and it's working like magic .
I added this after commit knowledge
session.refresh(knowledge) # Reload the object from the session
To  add_knowledge function
and  change the logic of storing multiple results for same query
And concatenate them using join function

#485 I tested this PR intensively and it's working like magic . I added this after commit knowledge session.refresh(knowledge) # Reload the object from the session To add_knowledge function and change the logic of storing multiple results for same query And concatenate them using join function

What are the changes which you see if you can let us know?

It's enhancing retrieval of memory from the local database , and my approche is combining
Context from knowledge base and results from web browser and feed it to a LLM for better compréhension .

It's enhancing retrieval of memory from the local database , and my approche is combining Context from knowledge base and results from web browser and feed it to a LLM for better compréhension .

Yup if you notice there is more to it ...

#485 I tested this PR intensively and it's working like magic . I added this after commit knowledge session.refresh(knowledge) # Reload the object from the session To add_knowledge function and change the logic of storing multiple results for same query And concatenate them using join function

can you tell me exactly where to add this , maybe i have missed it ....


CVN is a 32-bit little endian CRC

CVN is a 32-bit little endian CRC.  00 in a CVN may not be assumed to be padding or a  a string terminator.  Since it is a CRC, it would be best to show all 32 bits.
Below 00 AC FF 33 should appear as 0x33FFAC00
And DE E5 00 00 may be better shown as 0x0000E5DE
Example 1
2017-08-09T10:27:27.344 Global DM19 (Calibration Information) Request 10:27:27.344 18EAFFF9 00 D3 00 (TX)
10:27:29.844 18D30011 00 00 00 00 4E 58 43 43 43 43 4E 4F 00 00 00 00 00 00 00 00
DM19 from Cruise Control (17): CAL ID of NXCCCCNO and CVN of 0x0
10:27:29.844 18D30000 F6 16 DE 8B 41 32 36 32 34 58 58 41 5F 45 32 31 35 33 58 32 A8 73 89 13 4E 4F 78 2D 53 41 45 31 34 61 20 41 54 49 31 00 8C 4B F9 C9 4E 4F 78 2D 53 41 45 31 34 61 20 41 54 4F 31 00 AC FF 33 00 30 32 30 31 30 31 30 30 30 32 00 00 00 00 00 00 D2 BF 0F A9 50 4D 53 31 32 33 34 31 41 31 30 31 00 00 00 00
DM19 from Engine #1 (0): [
CAL ID of A2624XXA_E2153X2 and CVN of 0x8BDE16F6
CAL ID of NOx-SAE14a ATI1 and CVN of 0x138973A8
CAL ID of NOx-SAE14a ATO1 and CVN of 0xC9F94B8C
CAL ID of<PHONE_NUMBER> and CVN of 0x33FFAC
CAL ID of PMS12341A101 and CVN of 0xA90FBFD2 ]
Example 2
2017-08-04T10:54:17.664 Global DM19 (Calibration Information) Request
10:54:17.664 18EAFFF9 00 D3 00 (TX)
10:54:20.165 18D30000 25 08 63 66 4D 31 33 31 58 58 42 5F 42 32 38 33 54 45 30 31
DM19 from Engine #1 (0): CAL ID of M131XXB_B283TE01 and CVN of 0x66630825 10:54:20.165 1CD30055 EB 34 91 AB 31 36 30 32 30 32 4E 4F 30 33 00 00 00 00 00 00 A8 73 89 13 4E 4F 78 2D 53 41 45 31 34 61 20 41 54 49 31 00 8C 4B F9 C9 4E 4F 78 2D 53 41 45 31 34 61 20 41 54 4F 31 00 DE E5 00 00 31 32 44 42 42 32 30 30 30 32 00 00 00 00 00 00 D2 BF 0F A9 50 4D 53 31 32 33 34 31 41 31 30 31 00 00 00 00
DM19 from Diesel Particulate Filter Controller (85): [
CAL ID of 160202NO03 and CVN of 0xAB9134EB
CAL ID of NOx-SAE14a ATI1 and CVN of 0x138973A8
CAL ID of NOx-SAE14a ATO1 and CVN of 0xC9F94B8C
CAL ID of 12DBB20002 and CVN of 0xE5DE
CAL ID of PMS12341A101 and CVN of 0xA90FBFD2 ]

All test cases were full 4 bytes.  New cases were added with fewer than 4 bytes and leading zeros were added.

The form submitted for this issue has been posted on the Google Drive:
https://drive.google.com/open?id=0BzIQ48EeW5tTdFkzSDZ2WFhZMlE


Only allow creating a grant if you're logged in

You shouldn't be able to create a grant unless you're logged in!
Also, please keep track of the user id who creates a grant.

I thought this was done already in #70, let me double check

@scottjones,  I see in your note you mention a separate item: "Also, please keep track of the user id who creates a grant." I am opening a separate ticket for that


Error in LRN

Apparently miopenLRNForward loses value signs of input tensor here unlike cudnn implementation. Isn't this a compatibility issue?

Hi,
Could you be more specific, please?
What configuration is causing the problem?
Or have you found an obvious bug in the source code?
Thank you a lot, we enormously appreciate your feedback.
Best regards,
MIOpen team.

Hi!
I meant that in cuDNN LRN is calculated like:
y_ij = |x_ij| / (K + alpha * (sum_kl x_kl^2) / N^2)^beta
and in MIOpen:
y_ij = x_ij / (K + alpha * (sum_kl x_kl^2) / N^2)^beta
(without abs value of x_ij)
So, may be it should be changed, so in deep learning frameworks LRN layers for NVIDIA and AMD would be similar?

Here is, roughly,  the cuda code:
template
global void LRNComputeOutput(const int nthreads, const Dtype* const in,
const Dtype* const scale, const Dtype negative_beta, Dtype* const out) {
CUDA_KERNEL_LOOP(index, nthreads) {
out[index] = in[index] * pow(scale[index], negative_beta);
}
}
X is in[index]
Y is out[index]
I’m not sure where is the difference?
I do not see any abs function here.
Abs will indeed cause the sign loss but LRN is a scaling operation it should keep sign unchanged.
Best regards,
MIOpen team.

Sorry, I meant that in cuDNN it is without abs.
If you look at MIOpen LRN line 385, there is bot_val * s. And bot_val (line 381) is sqrt of something. Therefore, it is always >= 0, we lost a sign.

you're right. some minor optimization can cause a lot of havoc :)
thank you, great catch. we've fixed it already and put it into the next release.
Best regards,
MIOpen team.

@ashmanov this issue has been fixed in the latest release.


Added missing $request (NovaRequest::class) argument inside ActionRequest::validateFields

Issue Fixed: Dependency Container was breaking actions

thanks a lot!


Group 16 Initial Report

Review from Group 14
This report shows a good understanding of potential optimizations with MPI
implementation. They understand where bottlenecks exist in the code (at OpenMP
barrier) by using VTune Amplifier. Loop ordering has been optimized for better
memory access. However, consider storing a copy of the tranpose matrix to get even
quicker accesses!
There are plans to use specific MPI functions to synchronize parallel work between
processors. And the group is aware of tuning the block sizes to be most efficient
and evenly spread across processors. They have also shown knowledge of applicable
compile-time flags. Since there are many parallels between this project and the
matrix multiply project, many of those ideas can be applied here, as this group has
demonstrated.


PI-8519 - Added AppCommand for showing up a loading screen, after the…

… user successfuly created a new account

in all honesty, I don't understand much in appCommands, so I am not really a good reviewer for this stuff. I will need to get myself involved a bit more with this topic a bit later.


Add run_resources to PyCairoRunner::run_from_entrypoint

Add run_resources to PyCairoRunner::run_from_entrypoint
Add run_resources-n_steps to PyCairoRunner::run_until_pc
Add test
Remove the commented run_resources line in the tsarknet patch.
Comments:
This PR adds to the patch changes in PR #196, it is not a blocking dependency, but said PR should be closed if this is merged first
No changes to cairo-rs version needed

Codecov Report

Merging #198 (0fc7d32) into main (67a9ab3) will decrease coverage by 0.10%.
The diff coverage is 88.88%.

@@            Coverage Diff             @@
##             main     #198      +/-   ##
==========================================
- Coverage   95.11%   95.00%   -0.11%
==========================================
  Files          14       14
  Lines         716      721       +5
==========================================
+ Hits          681      685       +4
- Misses         35       36       +1

Impacted Files
Coverage Δ

src/cairo_runner.rs
96.19% <88.88%> (-0.29%)
:arrow_down:

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more


Consume any char

Consumes any char that isn't a term.
Fixes some issues with international text values

No tests?


DomElement position is not kept correctly in the scene when a camera zooms out

Version

Phaser Version: 3.80.1 (also occurs in previous versions)
Operating system: All
Browser: All

Description
When using the camera zoom, DOMElements on the scene will not stay at their correct position (unless you set the DomElement origin to (0,0)
Example Test Code
https://phaser.io/sandbox/jBN4oJxC
In the example above, you will see that the sprite and the DomElement are placed at the same position.
Yet, when we zoom out, the DomElement slightly moves to the bottom right. It shouldn't
Additional Information
I'm willing to help fix this and provide a PR but I would need a bit of guidance.
I traced back the issue probably to DOMElementCSSRenderer.js but I'm not sure where to look further.

Note: this is a duplicate of https://github.com/phaserjs/phaser/issues/6607 (sorry for opening the duplicate) and I provided a fix in this PR: #6819

Thanks for opening this issue, and for submitting a PR to fix it. We have merged your PR into the master branch and attributed the work to you in the Change Log. If you need to tweak the code for whatever reason please submit a new PR.


TST: reuse existing tests for GPU testing

What do these changes do?
Setup a testing mechanism for letting current test cases run on GPU. For test cases that can run both on CPU and GPU,

always use the setup_gpu fixture since setup_gpu still works even there's no cuda device available.

mark test case with annotation @support_cuda so that it will be picked up when running pytest -m cuda, a.k.a. our GPU test suite.

in the test case, use the bool fixture gpu to init dataframes, series, and tensors. gpu is, by default, set to False so that test cases in CPU test suites still run on CPU. Our GPU test suite, however, runs with pytest -m cuda --gpu, where gpu is set to True, making the test cases run on GPU.

Related issue number

#369
Check code requirements

[x] tests added / passed (if needed)
[x] Ensure all linting tests pass

Seems that I didn't see setup_gpu included in this PR?

Seems that I didn't see setup_gpu included in this PR?

setup_gpu is an existing fixture.


Error running graph: list index out of range

Bug Description
When I submit the request to on server. I got the response from API Error running graph: list index out of range.
Reproduction
Attached the screenshot.
Expected behavior
Please review screenshot.
Who can help?
@italojohnny
Operating System
ubuntu 22.04.1
Langflow Version
langflow   1.0.19.   and langflow-base   0.0.99
Python Version
3.10
Screenshot

Flow File
No response

Hello, @Chander88 8. How are you?
To help you effectively, I first need to reproduce the issue on my end. Could you provide your flow and any additional information on the conditions I should set to encounter the same problem you’re experiencing?

Hello @italojohnny,
Thankyou  for helping.
I am running two server one is Node and another is the Langflow.
Basically it is the AI application and when I hitting the request to langflow server with some audio message.
Langflow throws the error Error running graph: list index out of range.
I use the flow Id that I got form the Python API when I dashboard of server.
Please let me know if any further details required.

I sincerely apologize for the delay in responding, but I was unable to reproduce your issue.
In the meantime, we have released version 1.1.1. Could you check if the issue still occurs with this new version?
If it does, could you share a copy of your flow and/or the complete error log? This would greatly help me identify the problem.

Thank you for your contribution! This issue will be closed. If you have any questions or encounter another problem, please open a new issue and we will be ready to help you.


Python version

For which python version is this program written?

It's working on python 2.7. Don't remember about Python 3, anyway I'm pretty sure there's few trivial changes needed in case it not work with Python 3.

It doesn't work out of the box on python 3, but running 2to3 -w on it seems to fix it.

Fixed


GC fundamentals clean up

Fixes #12783

Add a note that concurrent GC is for 3.5 and earlier and move this section down to bottom
Remove back to top anchors
Style improvements

There are some merge conflicts here

There are still merge conflicts here. Do you want to take care of that before we start reviewing?

@gewarren This really looks good. I reviewed it today, and I like it. I'd be ready to approve it, once you and @Maoni0 are happy with the content.
Let me know when you are ready for a final approval.

 Each heap contains a small object heap and a large object heap, and all heaps can be accessed by user code. Objects on different heaps can refer to each other.

probably a good idea to introduce the SOH/LOH acronyms here

Refers to: docs/standard/garbage-collection/fundamentals.md:197 in 3251442. [](commit_id = 325144209fe3e41442918f8cf78282a1ba902d61, deletion_comment = False)

I've added a label to indicate this PR is waiting on the other one first.

Close/reopen for new build.

@BillWagner I'm ready for a final approval. Thanks much!

@BillWagner Thanks very much!


Add cancel button to go back to the questions page.

Add a cancel button just beside the Submit button, to take the user back to the question page has was making a submission for.

@kpbot claim


Can we add data dynamically into the table.

Hi,
I am new to PptxGenJS, I have an API that gives me response as JSON. I would like to add that data into the tables of the PPT. Maybe, like an AJAX call to the API, and I could use the JSON data I receive as my source into the tables. Is it possible? Please let me know.

Hi @phavanagi
Any presentation.PPT file is a binary, zipped collection of XML files, so there's no interfacing with that. In addition, the PptxGenJS library cannot open a file and manipulate it, so the only other option is to use the library to generate a table using the data you receive - this is the "normal" usage scenario.
Example:
// [Get JSON via REST or whatever...]
// Create new Array() and fill with data (eg: arrTabRows)

var pptx = new PptxGenJS();
var slide = pptx.addNewSlide();

slide.addText('Here is that JSON data:', { x:0.5, y:0.7, font_size:18, font_face:'Arial', color:'0088CC' });

slide.addTable(
    arrTabRows, { x:0.5, y:1.0, w:'90%' },
    { rowH:0.75, fill:'F7F7F7', font_size:14, color:'363636', border:{pt:'1', color:'BBCCDD'} }
);

pptx.save('json-data-demo');

Hi,
Thanks for the reply :)
I have the following code : It doesn't work and the PPT generated is corrupt. Can you let me know where I am going wrong?
`function insertCharacteristicsTable(slide)
{
var date = [];
var yield = [];
var avgQualMood = [];
var portCde = [];
			$.ajax({
			type: 'GET',
			url: "http://reportingsystemapidev.incomeresearch.com/api/characteristics/04-30-2017/ALAS%20INC",
			dataType: 'json',
			success: function(data){
			//console.log(data.list[0].main.temp);
			//trying to parse through data for graph

			$.each(data,function(index, current){
				date.push(current.as_of_date);
				yield.push(current.yield);
				avgQualMood.push(current.average_quality_moody);
				portCde.push(current.port_code);
				console.log(date + " " + yield + " " + avgQualMood + " " + portCde);
			});
		}
		});

		var rows = [
			[
				{ text: 'Characteristics', opts: { valign:'b', align:'l', font_face:'Arial', font_size:8, fill:'4C86A1', color:'ffffff', bold:true} },
				{ text: 'Univ. of Illinois Short Portfolio (12/31/16)', opts: { valign:'t', align:'c', font_face:'Arial', font_size:8, fill:'4C86A1', color:'ffffff', bold:true} },
				{ text: 'Univ. of Illlinois Short Portfolio (3/31/17)', opts: { valign:'t', align:'c', font_face:'Arial', font_size:8, fill:'4C86A1', color:'ffffff', bold:true} },
				{ text: 'Bloomberg Barclays 1-3 Yr G/C Index (3/31/17)', opts: { valign:'t', align:'c', font_face:'Arial', font_size:8, fill:'4C86A1', color:'ffffff', bold:true} },
			],

			[
				{ text: date, opts: { valign:'b', align:'l', font_face:'Arial', font_size:8, color:'000000', margin:[1,1,1,10]} },
				{ text: yield, opts: { valign:'t', align:'c', font_face:'Arial', font_size:8, color:'000000', margin:[1,1,1,1]} },
				{ text: avgQualMood, opts: { valign:'t', align:'c', font_face:'Arial', font_size:8, color:'000000', margin:[1,1,1,1]} },
				{ text: portCde, opts: { valign:'t', align:'c', font_face:'Arial', font_size:8, color:'000000', margin:[1,1,1,1]} },
			],

		]

		// Sets the position and size of the table, as well as the width of the columns.  The position should stay the same,
		// but the widths need to be dynamic in case there are fewer than 4 columns.
		var tabOpts = { x:0.25, y:1.13, w:4.6, colW:[1.6,1,1,1]};
		var celOpts = {
			border:{ pt:'1', color:'FFFFFF' }
		};
		slide.addTable( rows, tabOpts, celOpts );
	}`

Hi @phavanagi,
the variables date, yield, avgQualMood and portCde are undefined at the moment of creating rows array. It is outside of the success callback.

Hi @kajda90 ,
I put it in success, but still doesn't work. It gives me a blank table. Am I using the arrays correctly? will it loop through on itd own? Shud we do something like date[0]. Kindly let me know. Attached is the modified code( Just putting it under success)
``
function insertCharacteristicsTable(slide)
{
var date = [];
var yield = [];
var avgQualMood = [];
var portCde = [];
			$.ajax({
			type: 'GET',
			url: "http://reportingsystemapidev.incomeresearch.com/api/characteristics/04-30-2017/ALAS%20INC",
			dataType: 'json',
			success: function(data){
			//console.log(data.list[0].main.temp);
			//trying to parse through data for graph

			$.each(data,function(index, current){
				date.push(current.as_of_date);
				yield.push(current.yield);
				avgQualMood.push(current.average_quality_moody);
				portCde.push(current.port_code);
			});

				console.log(date + " " + yield + " " + avgQualMood + " " + portCde);

		var rows = [
			[
				{ text: 'Characteristics', opts: { valign:'b', align:'l', font_face:'Arial', font_size:8, fill:'4C86A1', color:'ffffff', bold:true} },
				{ text: 'Univ. of Illinois Short Portfolio (12/31/16)', opts: { valign:'t', align:'c', font_face:'Arial', font_size:8, fill:'4C86A1', color:'ffffff', bold:true} },
				{ text: 'Univ. of Illlinois Short Portfolio (3/31/17)', opts: { valign:'t', align:'c', font_face:'Arial', font_size:8, fill:'4C86A1', color:'ffffff', bold:true} },
				{ text: 'Bloomberg Barclays 1-3 Yr G/C Index (3/31/17)', opts: { valign:'t', align:'c', font_face:'Arial', font_size:8, fill:'4C86A1', color:'ffffff', bold:true} },
			],

			[
				{ text: date, opts: { valign:'b', align:'l', font_face:'Arial', font_size:8, color:'000000', margin:[1,1,1,10]} },
				{ text: yield, opts: { valign:'t', align:'c', font_face:'Arial', font_size:8, color:'000000', margin:[1,1,1,1]} },
				{ text: avgQualMood, opts: { valign:'t', align:'c', font_face:'Arial', font_size:8, color:'000000', margin:[1,1,1,1]} },
				{ text: portCde, opts: { valign:'t', align:'c', font_face:'Arial', font_size:8, color:'000000', margin:[1,1,1,1]} },
			],

		]

		// Sets the position and size of the table, as well as the width of the columns.  The position should stay the same,
		// but the widths need to be dynamic in case there are fewer than 4 columns.
		var tabOpts = { x:0.25, y:1.13, w:4.6, colW:[1.6,1,1,1]};
		var celOpts = {
			border:{ pt:'1', color:'FFFFFF' }
		};
		slide.addTable( rows, tabOpts, celOpts );

		}
		});

	}


ReduxPersist config should not include empty whitelist

As several people on gitter mentioned, an empty whitelist seems to blacklist all reducers.
Specifying an empty whitelist effectively blacklists everything. This is something redux-persist should sort out, but maybe ignite should consider having only the whitelist or blacklist defined in ReduxPersist.js, since once you have a whitelist, adding to the blacklist is analogous to removing from the whitelist and vice versa. i.e it's redundant.

When I added the whitelist option I attempted to manually test all the different use cases and didn't see any problems, but maybe I forgot to test when both options are blank...


Add support for controlling log levels

In this commit we modify the logging package in order to be more conveniently used by other (mainly client, server and test) packages. The default log level set by logging package's init() function is info. However for tests, we're now explicitly setting the loglevel to debug. The log levels are standard ones, e.g. debug, info, notice, error and critical.
The loglevel flag was also added to emmy CLI in order to give the end user some more control. The end user interacting with the CLI app can now control the log level like this:
$ emmy example --loglevel notice  # or '-l notice'
$ emmy server start --loglevel info # we can omit this, as info is the default log level
$ emmy client --protocol schnorr -l debug

I didn't  update the CLI app usage instructions in the README - I can add it to this PR, or, alternatively, do in the near future in a separate PR.
In addition, appropriate changes allowing separation of what gets logged in, for instance, info and debug log levels, were applied to logging calls in client/client.go and server/server.go. Specifically, you will notice that the payloads of protobuf messages (which were making the logs a bit messy and harder to read) only get logged if we choose the debug log level.

Okay, done :+1: . I also updated the "What does emmy stand for" portion of the README as requested.


NT AUTHORITY\LOCAL SERVICE is misnamed in the latest PSGallery version of ReSecurityPolicy.psm1 (0.0.12)

Looks like "NT AUTHORITY\LOCAL SERVICE" is misnamed as "NT AUTHORITY\NETWORK SERVICE".
        'S-1-5-19'                                                       = [PSCustomObject] @{Name = 'NT AUTHORITY\NETWORK SERVICE'
            SID                              = 'S-1-5-19'
            DomainName                       = ''
            Type                             = 'WellKnownGroup'
            Error                            = ''

Sorry for that. Too much copy/paste.

No worries! Appreciate the quick fix!


Client: s3 backend

What is the expected behavior?
Implement s3 backend to store trials in s3 bucket.
Details
Client: https://boto3.amazonaws.com/v1/documentation/api/latest/reference/services/s3.html
Example
from purplecaffeine import S3Backend

s3_backend = S3Backend(
   bucket_name="my_trials",
   key="<API_KEY>",  # this can be env
   access_key="<API_ACCESS_KEY>" # this can be env
)

How should the trial data be passed into the s3_backend?
Should we use the IDs of the trials from the database or the paths of the local files?

You should pass the data from the Trial object.
A simple way is to do the same as it done for LocalBakend. Just you create a new class call like S3Backend with a save, get and list functions to save a Trial object into S3 and to get a Trial object from S3.
Look here for LocalBackend structure : https://github.com/IceKhan13/purplecaffeine/blob/main/client/purplecaffeine/core.py#L204


Implements DAG deletion

Also:

Removes vestiges of isolation mode (Python processes always restart after unpinning functions)
Separates local KVS config from cluster config to avoid silly bugs

@vsreekanti  there's a failing test?

@xyclin Yeah, didn't rename files properly. This is why we have tests. :-) Should be fixed now.


Add doc publishing workflow

Added a workflow that triggers on push to main to generate the docs and upload them to S3.
If changes were found, the website will be re-published using the dispatch workflow trigger.

LGTM! Am I right in thinking that now we have secrets in the repo, any contributor to the repo can write an action that exposes the secret, so we should be careful in the future who we add as a contributor?

This is true, we want to limit the amount of contributors. Although the secrets don't add too much rights. The REPO_ACCESS_TOKEN does allow you to trigger actions on other repositories.
As to AWS, the secrets are not that 'secret' ;-)


distributed DQN using colossalai

recommit this PR for review

Hi @number1roy Thanks for your contribution!
Could you please provide some expected output or training results to help users confirm if they can use it correctly?

This PR is closed due to inactivity.


Add TypeScript definitions

Adds TypeScript information to join-monster. This solves #135.
The definitions are not complete, but most types are added. E. g. I could not find an interface for DialectModule, but I think TypeScript definitions are not required there, as a developer would anyways have to dive into the documentation and source code. I went through the documentation and tried to add as many types as possible. Most importantly the GraphQL type definitions are extended, so that join-monster can be used without encountering annoying messages.
Please review the definitions, but also keep in mind, that they do not have to be perfect by now and can be extended later by follow-up PRs.
Consider the following when merging:

I modified the build job to copy non-js files except README.mds to make babel add the file to dist instead of adding a manual cp-command. This was done adding --copy-files --ignore README.md.
I did NOT add a peerDependency on @types/graphql. This is clearly not optimal for TS-users, who have not installed @types/graphql, as it will cause an (maybe incomprehensible) error when compiling TS. If the dependency would be added, anyone using join-monster, even JS users, will download @types/graphql as well, which is currenty 376K. Third option would be to cancel this PR and create a @types/join-monster-package. This would add more noise to package.json and package-lock.json for TS-users and require an additional step to work with join-monster, which IMHO is not worth it for a 4K-file. This is why I added the definitions this way.

Thanks for doing this work, @wtho! I'm excited to get this merged in as I have a TS project right now that could really use these types.

@TheKeithStewart thank you!
You can already copy the index.d.ts from this PR to your node_modules/join-monster/dist/ and try it out. I am not 100% sure if it will immediately work with all projects or if I left something out, so some feedback would actually be awesome!
Note, that for TS to know the right args in e. g. where-functions you have to declare the field of this type, e. g.:
export const MyGraphQLType = new GraphQLObjectType({
  ...
  fields: () => ({
    someField: {
      type: new GraphQLList(MyGraphQLType),
      args: {
        someArg: {
          type: GraphQLString
        }
      },
      where: (table, args, ctx) => {
        return args.someArg ? `${table}.id = someArg` : ''
      },
    } as GraphQLFieldConfig<IMyGraphQLType, IMyContext, { someArg: string }> // give args type here
  } as GraphQLFieldConfigMap<IMyGraphQLType, IMyContext>)
})

I highly recommend to cast the fields as a whole and each field to the typed TS interfaces as shown here to gain more type-safety and TS completion support. Adds some noise, but is worth it.

@wtho Sorry for the delay in getting back to you.
I went ahead and added the index.d.ts file to the join-monster dist folder. I also had to update the types property in the package.json file for join-monster to get it working. It seems to work well. I haven't had any issues.
Thanks again for putting the work into this!

Definitions for GraphQLUnionType and GraphQLInterfaceType should probably be added as well (http://join-monster.readthedocs.io/en/latest/unions/)

Is this PR ready to be merged?

@jvbianchi Green light from my side.
I think @acarl005 wants to play around in a small project with the working type definitions before merging, as reviewing and testing is not done automatically (although it might be possible using something like this, but have not tried it).


fix: limit number of workers when creating haste maps in projects

Summary
Partially addresses https://github.com/facebook/jest/issues/9236.
When creating haste contexts and maps, Jest currently spawns maxWorkers per "project". While it doesn't make a difference in a single-project workspace, it's a big deal for those using multiple projects.
A quick-and-dirty-but-works solution is to limit the number of workers based on the projects number. It's sub-optimal, because we may have smaller and larger projects which we assign the same number of workers. However a proper solution would require more work. E.g. we could delegate createHasteMap of each project to a worker pool created in jest-core, instead of deferring parallelization to createHasteMap itself. Feel free to implement this solution. However, I'm not pursuing this, as @scotthovestadt has likely far more meaningful changes to haste map performance.
In Jest own test suite, this diff result in haste map creation time drop from 3.1s to 0.8s on my machine, which is noticeable.

@scotthovestadt FYI whenever you get back. Not sure how this fits into your refactor


add bitsandbytes to readme， support to use it on low resource devices and update web demo

also fix interface bug

Hi @LYMDLUT ,
Thanks for your kind PR. We have fixed the issue of chat/web_demo.py.  Could you fix the conflicts so that we can merge the PR?


Brainstorm ideas for better information for slow fsyncs

FSync is the lifeblood of etcd performance and performs variably in complex cloud deployments.  The current log message simply gives a single readout: 'Fsync time was X, slower then Y'.

Case for higher-resolution metrics: When you see this problem - it means something catastrophic may be happening in your cluster, and downtime could be on the way.  Most people don't monitor all disk performance metrics, and even if they do, they may not specifically be monitoring the drives that etcd is looking it, hence its easier for users to do fsync forensics metrics directly from etcd if they are available.

Counterpoint: ETCD's doesn't need to create metrics for warnings - nor provide fine grained information on disk performance, so this really should be a warning.  Warnings shouldn't be put into metrics.

#7671 Introduced some ideas for better fsync debugging...

linear metrics: Advantage, fine grained disk perf.  Disadvantage: Too many new metrics added when we linearly go from 1->8k.
gauges: Advantage: Only one metric and gives continuous instant feedback for fsync perforamnce.
have a rolling average in the logs, report the 'last 10' fsyncs or the 'average fsync'.  Of course, this is really just reproducing metrics inside the logs, but maybe it gets around reviewer concerns.

Summary of existing metrics/ideas related to this:

One possibility from discussing w/ @heyitsanthony is using rates.  I noodled some on it and came up with this:

(rate(etcd_disk_wal_fsync_duration_seconds_bucket{le="1"}[2m]))
/
  rate(etcd_disk_wal_fsync_duration_seconds_bucket[2m])

Which will measure the rate of change so you have an instantaneous measurement of problems that might be creeping up, much more useful then a histogram of total fsync buckets over time since the birth of christ :).

One original option was to simply have a separate metric for all warnings - that way users could directly count metrics that were interested rather then customizing their filters.  Although its up to the user to decide, after all i think pretty much everyone agrees that fsync > 1second means your in BIG trouble for any real cluster.
If we want to avoid metrics for warnings, then I was hoping to have:

# HELP etcd_disk_wal_fsync_duration_current The current WAL fsync time, if its rising, disk slowness may decrease availability
# TYPE etcd_disk_wal_fsync_duration_current gauge
etcd_disk_wal_fsync_duration_current 0.010661352

Alas, this is what we currently have: Not really useful at all since, once it gets above a certain speed, your cluster is pretty much dead, so the buckets in a time-series of 2 seconds really amount to just drinking from a firehose.

etcd_disk_wal_fsync_duration_seconds_bucket{le="0.001"} 0
etcd_disk_wal_fsync_duration_seconds_bucket{le="0.002"} 0
etcd_disk_wal_fsync_duration_seconds_bucket{le="0.004"} 0
etcd_disk_wal_fsync_duration_seconds_bucket{le="0.008"} 0
etcd_disk_wal_fsync_duration_seconds_bucket{le="0.016"} 2
etcd_disk_wal_fsync_duration_seconds_bucket{le="0.032"} 2
etcd_disk_wal_fsync_duration_seconds_bucket{le="0.064"} 2
etcd_disk_wal_fsync_duration_seconds_bucket{le="0.128"} 3
etcd_disk_wal_fsync_duration_seconds_bucket{le="0.256"} 3
etcd_disk_wal_fsync_duration_seconds_bucket{le="0.512"} 3
etcd_disk_wal_fsync_duration_seconds_bucket{le="1.024"} 3
etcd_disk_wal_fsync_duration_seconds_bucket{le="2.048"} 3
etcd_disk_wal_fsync_duration_seconds_bucket{le="4.096"} 3
etcd_disk_wal_fsync_duration_seconds_bucket{le="8.192"} 3
etcd_disk_wal_fsync_duration_seconds_bucket{le="+Inf"} 3
etcd_disk_wal_fsync_duration_seconds_sum 0.11810550900000001
etcd_disk_wal_fsync_duration_seconds_count 3

Likewise, a more useful log would be something like "average sync duration of %v over the past 10 minutes extremely slow, faster disk i/o is strongly suggested for highly available clusters." Or something like:  "For the past X minutes, fsync durations have breached the maximum suggested time period by an average of X seconds.  faster disk i/o is strongly suggested for highly available clusters."
The current log is: plog.Warningf("sync duration of %v, expected less than %v", duration, warnSyncDuration)

/cc @fabxc any opinions? thanks in advance!

+1 to this.  In my experience, this is the single most important thing to monitor - slow/variable i/o will cause leader losses for sure.   If I could give every etcd NVMe or SSD backed storage I would, but cloud environments can have unpredictable storage performance.  A gauge providing the latest fsync duration that can be scraped with a time series metrics collector would be valuable for real-time monitoring and health readouts.

there is already a pretty fine grained bucketed fsync duration metrics. i do not understand why you want a metrics for just the "latest" one. what additional information would that give you? what additional actions can you react on the additional information you got?
i operator etcd on both fast/slow disk. i never feel the bucketed metrics is not enough.

Generally I wouldn't agree with warning conditions not being captured by metrics. If it is sufficiently relevant to the application health, as it obviously is here, it makes sense.
Can you elaborate why you consider the histogram, which has well-chosen bucket sizes in general, useless?
It generally seems to capture it pretty well. When querying the histogram metric in your TSDB, you can pick shorter or longer window depending on how fast you want to detect increases in latency.
Nothing speaking against logs of course. But the one you showed could also be expressed with the histogram metric you already have. A PromQL query here (but any capable query engine against a TSDB should be able to express this, really):
instance:etcd_disk_wal_duration_seconds:avg10m =
    increase(etcd_disk_wal_fsync_duration_seconds_sum[10m]) /
    increase(etcd_disk_wal_fsync_duration_seconds_count[10m])

Obviously this puts a lot more power into the users hand than making this a static computation compiled into etcd itself. Choosing to calculate the average here versus a quantile practically won't make too much of a difference.
To think this further through, you could use above result for your alerting like
predict_linear(instance:etcd_disk_wal_duration_seconds:avg10m[10m], 30 * 60) > 0.5

to get notified if the avg fsync latency is ramping up continously over the last 10m so that it will exceed 500ms in 30 minutes.
This seems rather powerful to me. Certainly more powerful than a single log line or a metric only representing the most recent latency observation. The latter is obviously prone to trigger alerts due to a single outliers.
I might not have fully understood the use case. If so, can you describe an example of what you want to detect and how the histogram (plus a capable monitoring system obviously) does not suffice?

The difference users need to see, and alert against,  may be finer grained changes from .1 to 5 seconds.
Histogramming the ranges from 2,4,8,16s and beyond doesn't help with this.

Although its up to the user to decide, after all i think pretty much everyone agrees that fsync > 1second means your in BIG trouble for any real cluster.

This made it sound like we want to alert against really anything >1 second. So why is a high resolution needed beyond?
I'm just concerned that this is a theoretical problem. The histogram is pretty high-res as it is and should give pretty accurate estimates.

low resolution fsync alerting is valuable
high resolution fsync diagnostics is more valuable
having both is priceless

To be honest, if fsync ever takes more than 1s, etcd is almost unusable (we doc this in hardware recommendation). I do not think fsync bucket > 1second with high resolution is ever needed from etcd point of view. if you experience fsync > 1s, you need to continue debug at system level, not at etcd level.
in short, etcd metrics is really for monitoring application performance and reporting issues when resources are not enough for etcd. do not use etcd metrics to debug os issues.

Im even happy to do .1 , .2, .4, .8, 1.6, 2.0, 4.0, 16.0, 32.0 would be more useful and be a minimal change.

@heyitsanthony  @xiang90 @fabxc  We'd like to schedule a google hangout to discuss this and see if maybe we are shooting past each other.  There might be an idea that we can all agree on here .  How does tomorrow at noon EST sound ?  (thats 9AM PST), maybe too early?  Not sure where you guys are located .

@jayunit100 is the metrics output you're suggesting this:
etcd_disk_wal_fsync_duration_seconds_bucket{le="0.1"} 2
etcd_disk_wal_fsync_duration_seconds_bucket{le="0.2"} 2
etcd_disk_wal_fsync_duration_seconds_bucket{le="0.4"} 3
etcd_disk_wal_fsync_duration_seconds_bucket{le="0.8"} 3
etcd_disk_wal_fsync_duration_seconds_bucket{le="1.6"} 3

instead of what's there now:
etcd_disk_wal_fsync_duration_seconds_bucket{le="0.001"} 0
etcd_disk_wal_fsync_duration_seconds_bucket{le="0.002"} 0
etcd_disk_wal_fsync_duration_seconds_bucket{le="0.004"} 0
etcd_disk_wal_fsync_duration_seconds_bucket{le="0.008"} 1
etcd_disk_wal_fsync_duration_seconds_bucket{le="0.016"} 2
etcd_disk_wal_fsync_duration_seconds_bucket{le="0.032"} 2
etcd_disk_wal_fsync_duration_seconds_bucket{le="0.064"} 2
etcd_disk_wal_fsync_duration_seconds_bucket{le="0.128"} 2
etcd_disk_wal_fsync_duration_seconds_bucket{le="0.256"} 2
etcd_disk_wal_fsync_duration_seconds_bucket{le="0.512"} 3
etcd_disk_wal_fsync_duration_seconds_bucket{le="1.024"} 3

?

Open to anything:

lower window, but same # of buckets (.1,.2,.3,.4,...,1.6)
more buckets (.1,.2,.3,....,4.0)
a gauge (probably ideal for us)
a log that reports average fsyncs in windows with a more informative error msg.

i am going to close this one. based on our debugging experience, what we have today is enough for slow fsync alerting. and people feel comfortable to debug slow io with os level tools( for example tools built atop ebpf)


[staging & production] Citations widget not updated until refresh after DOI creation

Steps

Go to a project that you have admin on
Make a registration of the project
Make the registration public
Go to the project overview page for the registration
Click 'Create DOI/ARK' in the Identifiers widget
Confirm that a DOI/ARK is now shown after Identifiers on the project overview page
Go to citations widget on project overview page, click to expand

Expected
I expect that the appropriate citations would now include the DOI/ARK identifiers
Actual
The citations do not include DOI/ARK identifiers until after page refresh. This is potentially confusing for users because it is not necessary for a page refresh for the DOI/ARK identifiers to appear on the project overview page, so it makes sense to assume that they would show up in the citation widget without refresh as well.

I think this will have to function in this manner -- Citations are generated based on a call of some sort, so a refresh will be required. But it is good thinking re: better usability, so I'll defer rather than close. Thanks.

This might be a very quick fix. I believe we're already loading this asynchronously.

I'll take your word on that -- Let me know what you find out. Thanks.

Should be as simple as calling ViewModel#fetch: https://github.com/CenterForOpenScience/osf.io/blob/develop/website/static/js/citationList.js

Want it? -- or maybe @chennan47 ? Thank you!

If @chennan47 isn't busy, that'd be great.

I'll grab this one. @lbanner

@rohan-bajaj .... all yours


⚠ ClamAV has degraded performance

In 656720d, ClamAV (https://spamassassin.apache.org/) experienced degraded performance:

HTTP code: 200
Response time: 55 ms

Resolved: ClamAV performance has improved in fa800f8 after 5 minutes.


Add docs for CREATE EXTENSION "uuid-ossp"

Fixes DOC-4759

This change is

Didn't add a CREATE EXTENSION SQL statement page since we don't have full support yet
However this should help folks who are searching to find it if they need


Great App and can be used for many area

[Enter feedback here]

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: aeb17525-36a9-d993-b774-24fdd800fa0e
Version Independent ID: c3ec4304-6217-5341-47cf-774070496c73
Content: Getting around HoloLens 2
Content Source: hololens/hololens2-basic-usage.md
Product: hololens
Technology: windows
GitHub Login: @scooley
Microsoft Alias: scooley

Thank you so much for your compliment!
Closing this docs issue since nothing needs to be resolved.


nucleotide-codons: deprecate for protein-translation

Closes #268

If I look at other deprecated exercises, they almost all start with "NOTE: This exercise has been deprecated.". I like that this is the first thing you see in that case, which makes it really clear that the exercise is deprecated. Perhaps we can do that here too?

Let's try that, then. Since you didn't object to linking the issue nor the suggestion of what exercise to implement instead, I kept them, of course, just added the necessary line

Someone needs to remind me what this .deprecated file does again, whether this PR needs to be dependent on https://github.com/exercism/xrust/pull/258.

Okay far as I can tell from https://github.com/exercism/x-api/pull/140 , deprecating it globally just prevents it from showing up in the "to be implemented" section of any other track, so I don't think https://github.com/exercism/xrust/pull/258 and this PR need to be temporally dependent on each other in some way.

I think linking to the issue and the suggestion are great features, so I'm glad you kept them in.
That means this PR can be merged, right?

That means this PR can be merged, right?

I'm ready for it to happen, and I think it is safe even while the Rust PR hasn't been merged. If we are unsure at all, we better let @kytrinyx know before the daily site deploy, in case it does cause any unexpected effects.

@kytrinyx would merging this PR would be safe to do?

Yes, this is safe to merge.


Migrating Maven sign and release jenkins jobs

Description

Move this job from Infra repo to build repo since this could use the libraries in build repo and promote our public visibility and add the unit test for this Jenkins job.
Add the docker CI runner image to the workflow.
Create the function in signArtifacts.groovy called generateArguments to dynamically add arguments for the sign scripts depending on the artifacts to be signed. E.g. If it's a manifest end with .yml, type arg will be required and for other artifacts, signatureType arg will be required.
Update the corresponding test cases related to the modification on signArtifacts.groovy
Create a new jenkins library downloadFromS3.groovy and add test cases for it.

Issues Resolved
#1357
Check List

[x] Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

ci is failing

Following up on my discussion with @peternied - The PLATFORM and ARCH parameters are required for getting the download urls for the artifacts which can we changed easily. Also, path is not fixed and any changes to the path will cause this job to fail. We should remove PLATFORM and ARCH parameters.
We can alternatively do the following -

Take manifest file as input (or get one using the version number) and get the artifact path from the file directly
Take in the artifact path as input and print the artifact path as a part of the build so it is easily available.

I personally prefer the first one, since it truly removes manual work and automates the process, using our existing one stop shop of manifest files which are assured to have the most up to date values.

Codecov Report

Merging #1520 (5fd82f9) into main (dd68fa3) will increase coverage by 0.10%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##               main    #1520      +/-   ##
============================================
+ Coverage     94.32%   94.42%   +0.10%
============================================
  Files           146      123      -23
  Lines          3152     3066      -86
  Branches          8        0       -8
============================================
- Hits           2973     2895      -78
+ Misses          172      171       -1
+ Partials          7        0       -7

Impacted Files
Coverage Δ

src/system/temporary_directory.py
83.87% <0.00%> (-12.91%)
:arrow_down:

src/system/os.py
92.30% <0.00%> (-7.70%)
:arrow_down:

tests/jenkins/jobs/PostCleanup_Jenkinsfile

...bs/PrintArtifactDownloadUrlsForStaging_Jenkinsfile

tests/jenkins/jobs/AssembleUpload_Jenkinsfile

tests/jenkins/jobs/GetManifestSHA_Jenkinsfile

tests/jenkins/jobs/InputManifest_Jenkinsfile

tests/jenkins/jobs/BuildArchive_Jenkinsfile

src/jenkins/BuildManifest.groovy

src/jenkins/Messages.groovy

... and 15 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update dd68fa3...5fd82f9. Read the comment docs.

Add the unit test based on @abhinavGupta16 PR for new jenkins test framework. This is blocked by https://github.com/opensearch-project/opensearch-build/pull/1471/ until like LibFunctionTester.groovy and new BuildPipelineTest.groovy are merged.

Add the unit test based on @abhinavGupta16 PR for new jenkins test framework. This is blocked by #1471 until like LibFunctionTester.groovy and new BuildPipelineTest.groovy are merged.

Added dependency here

Add the unit test based on @abhinavGupta16 PR for new jenkins test framework. This is blocked by #1471 until like LibFunctionTester.groovy and new BuildPipelineTest.groovy are merged.

This PR is now merged. You can use the instructions from https://github.com/opensearch-project/opensearch-build/issues/1560 to write the test cases. Thanks!

Please run and test this workflow before merging. This jenkins job is not something that is exercised regularly so want to be sure before merging.

I tested with upload and maven stage commented out. Should I test the uploading part?

Please run and test this workflow before merging. This jenkins job is not something that is exercised regularly so want to be sure before merging.

I tested with upload and maven stage commented out. Should I test the uploading part?

Yes. It won't publish anything. It will stage the repo which we can drop later on.

Did a test run on this job with parameters: [BUILD_ID: 295, VERSION: 1.2.3] and it ran successfully.
Validated the artifacts are correct and signed on staging maven with @gaiksaya, and dropped after validation.

Name convention for the type of signature (e.g. .sig) has been changed from signatureType to sigtype across all jenkins job calling signArtifacts to be consistent with other tools as we didn't use camelCases for our arguments or variables.


Feat: Scraping the QS World university ranking website

Describe the feature
I'd design a web scraper that would return the list and details of top universities by their rankings. The users would also be able to search for rankings of specific universities by subject, region, or cities.
Add ScreenShots

Record

[X] I agree to follow this project's Code of Conduct
[X] I'm a GSSOC 23 contributor
[X] I want to work on this issue

@nikhil25803 please assign me this

They have different parameters of ranking universities, it is not a official organization like NIRF in India.
Closing this PR for now.


Directional light won't cast shadow when positioned right atop the scene

If you change this line to
const lightPosition = vec3.fromValues(0, 100, 0);

no shadow is projected:

As a novice in graphics, I wonder is this a bug or an edge case with the ortographic projection of the light?

The next line is:
https://github.com/webgpu/webgpu-samples/blob/f4b46f00da0b8107ef95876a144ec38ef9cceda7/src/sample/shadowMapping/main.ts#L295
When you change lightPosition to [0, 100, 0], the view direction (origin to lightPosition) becomes parallel to the upVector. In this situation, there's an ambiguity in which way the returned matrix should be orientated.
If you want  lightPosition directly above the origin, you need to change the upVector to some other normalized vector.

Got it, thanks!


[r,python] Add show_package_versions for bug-report use

Issue and/or context:
#851
Changes:
As on #851

Codecov Report
Base: 79.14% // Head: 89.90% // Increases project coverage by +10.76% :tada:

Coverage data is based on head (1613c42) compared to base (6d4ec4c).
Patch coverage: 42.85% of modified lines in pull request are covered.

:mega: This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more
Additional details and impacted files
@@             Coverage Diff             @@
##             main     #855       +/-   ##
===========================================
+ Coverage   79.14%   89.90%   +10.76%
===========================================
  Files          70       30       -40
  Lines        3529     1882     -1647
===========================================
- Hits         2793     1692     -1101
+ Misses        736      190      -546

Flag
Coverage Δ

python
89.90% <42.85%> (-0.18%)
:arrow_down:

r
?

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files
Coverage Δ

apis/python/src/tiledbsoma/__init__.py
100.00% <ø> (ø)

apis/python/src/tiledbsoma/general_utilities.py
68.42% <42.85%> (-14.92%)
:arrow_down:

src/include/tiledbsoma/arrow_adapter.h

R/TileDBGroup.R

inst/tiledb/include/tiledb/array_schema.h

R/TileDBArray.R

R/utils-arrow.R

inst/tiledb/include/tiledb/domain.h

src/rutilities.cpp

src/include/tiledbsoma/array_buffers.h

... and 32 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

@eddelbuettel OK on the R side?


added dockerfile for testnet. updated readme to reflect hostd similarly

@bustedware raked up a conflict, otherwise LGTM 👍


v1.6 backports 2020-02-20

#10168 -- pkg/bpf: Protect each uintptr with runtime.KeepAlive (@brb)

Once this PR is merged, you can update the PR labels via:
$ for pr in 10168; do contrib/backporting/set-labels.py $pr done 1.6; done

This change is

test-me-please

never-tell-me-the-odds

@nebril Can you please pull https://github.com/cilium/cilium/pull/10187 as well into this backport?

never-tell-me-the-odds


RO:'deprecated_has active participant' needs to be replaced also in the axioms using it

Hi,
I just wanted to let you know that the deprecation of the object property RO:'has active participant' has not been reflected in the axioms of the OMRSE classes in which it was used, which are: 'human role within an organization', 'early childhood education plan specification', 'insurance policy' and 'job role'. The import module of RO seems to be up to date, as this OP is owl:deprecated=true, but the replacement in the axioms must be done manually, I guess.
:wink:

Sure, it was replaced by causal agent in process. Although, I was wondering whether using one of its subproperties involved in makes sense in some of the cases like job role.

Thank you!  We'll investigate the new OPs and handle the updates
accordingly.
On Tue, Jul 12, 2022 at 3:05 AM Philip Strömert @.***>
wrote:

Sure, it was replaced by causal agent in process
https://www.ebi.ac.uk/ols/ontologies/ro/properties?iri=http%3A%2F%2Fpurl.obolibrary.org%2Fobo%2FRO_0002500.
Although, I was wondering whether using one of its subproperties involved
in
https://www.ebi.ac.uk/ols/ontologies/ro/properties?iri=http%3A%2F%2Fpurl.obolibrary.org%2Fobo%2FRO_0002331&lang=en&viewMode=All&siblings=false#
makes sense in some of the cases like job role.
—
Reply to this email directly, view it on GitHub
https://github.com/ufbmi/OMRSE/issues/187#issuecomment-1181395263, or
unsubscribe
https://github.com/notifications/unsubscribe-auth/AAJR55SN3Q3CHLRAJRHRZVLVTUKKHANCNFSM53HYIYOA
.
You are receiving this because you commented.Message ID:
@.***>


  I don't know why it's so fun

I don't see the value in adding a help statement for this one, though. I'll take a look at @awaxa's PR.

I disagree. Having the Help is a way for someone who doesnt have access to the Gemfile or setup to see what plugins are installed in the instance. iirc there isnt any other way to do it.

Right, but what value does it add to any random user? If I happen to have 75 user plugins installed, is seeing this in the list really going to give me any useful information? I feel like this is one of those plugins that just kind of exists and does its thing quietly.
I am going to go ahead and merge this one, and see if @jimmycuadra has any thoughts on adding a 'list plugins' feature to Lita. I also feel like we're trying to decide some best practices and feel like he should have a say ;)

I'm in favor of http based help, because receiving 75 throttled PMs on IRC is infuriating.

Merged PR #2. Also bumped version and released v1.0.1 to rubygems.org.

My two cents: I think it's reasonable to have a help message for something like this. It responds to messages like any other handler. The convention I use variable parts of the input message to be in all caps, so I would've written the help message for this like this:
{ "URL" => "Responds with the title of the web page at URL" }


fix meteor package to install

change the page owner to be the right one.

@peernohell, thanks for the PR. I maintain the feature/publish branch where I specify the owner and version before publishing. This way, I can keep master in sync with upstream project.
By the way, my changes have been merged into cultofcoders:meteor-apollo-accounts I believe.


Self-closing /> is invalid syntax on non-void HTML elements

Problem
The official Vue parser allows self-closing any HTML, but this is not valid by the spec. For example, this:
<template>
  <slot />
  <div class="bad" />
</template>

Using Nu HTML Checker by W3 results in a clear error:

The same happens when parsing with swc_html_parser. The error is being reported and the tag is not being closed:
InvalidHtml(NonVoidHtmlElementStartTagWithTrailingSolidus) <slot />

In addition, this also messes up the DOM Tree stack, which is the actual problem here.
Possible solution
All NonVoidHtmlElementStartTagWithTrailingSolidus should be considered a hard error.
Nice-to-have
It would also be nice to do RegEx search-replace as a utility in fervid.
Another option is to parse the HTML and only apply this fix to where the NonVoidHtmlElementStartTagWithTrailingSolidus problem is encountered.

Raised concerns with SWC project in hopes to get a configuration flag for it
https://github.com/swc-project/swc/discussions/8424

Closed in SWC via https://github.com/swc-project/swc/pull/8460


Tutorial dapp

Add the 4 dapp tutorials of the Marigold learning page

For accessibility, provide alt text for images within the link brackets ![alt text](/img/path/image.png)
Add the tutorial to the tutorialsSidebar in sidebars.js
Settle on capitalization for "dapp." I've been using "dApp."
We can add the completed application to https://github.com/trilitech/tutorial-applications with the others.
Instead of naming the folder training, how about pokeGame or something that won't conflict with the other "training" tutorials?
For links, consider linking to docs.tezos.com where possible instead of sending people elsewhere. In part 1, there are links that could go to https://docs.tezos.com/smart-contracts/entrypoints and https://docs.tezos.com/smart-contracts/data-types/complex-data-types#variants.
To make the tutorial easy to follow, I like to make everything that the user does a numbered step. The section in part 1 under "write the poke function" has a lot of things that the user does that aren't steps, so it might get confusing. That's just how I've been trying to do the other tutorials.
Consistency: Start bulleted lists with a capital letter and end sentences with a period.
Indents: it would be easier to follow if the contents of a numbered step were indented so the things that were part of the step were farther to the right than the number. (see attached screencap)
Don't include a space before a colon.
I will enable mermaid diagrams for you; the diagrams do not appear properly.
This is a long enough tutorial that it should be in the intermediate section in tutorials.mdx.

For accessibility, provide alt text for images within the link brackets ![alt text](/img/path/image.png)

Add the tutorial to the tutorialsSidebar in sidebars.js

Settle on capitalization for "dapp." I've been using "dApp."

We can add the completed application to https://github.com/trilitech/tutorial-applications with the others.

Instead of naming the folder training, how about pokeGame or something that won't conflict with the other "training" tutorials?

For links, consider linking to docs.tezos.com where possible instead of sending people elsewhere. In part 1, there are links that could go to https://docs.tezos.com/smart-contracts/entrypoints and https://docs.tezos.com/smart-contracts/data-types/complex-data-types#variants.

To make the tutorial easy to follow, I like to make everything that the user does a numbered step. The section in part 1 under "write the poke function" has a lot of things that the user does that aren't steps, so it might get confusing. That's just how I've been trying to do the other tutorials.

Consistency: Start bulleted lists with a capital letter and end sentences with a period.

Indents: it would be easier to follow if the contents of a numbered step were indented so the things that were part of the step were farther to the right than the number. (see attached screencap)

Don't include a space before a colon.

I will enable mermaid diagrams for you; the diagrams do not appear properly.

This is a long enough tutorial that it should be in the intermediate section in tutorials.mdx.

Very valuable comments. Thank you Tim

I cannot access Vercel to see what failed
Can someone help me on this ?

I cannot access Vercel to see what failed Can someone help me on this ?

@zamrokk The problem is the duplicate import here: https://github.com/trilitech/tezos-developer-docs/pull/197/files#diff-03cbcc9e6b2a55c9cf2d73092d78ddc7fa68f4d3d90d1f79b8d0707a1d1633b4R8-R9

oh wahou ! When I save and VsCode autoformats the file, then it is duplicating the line o.O
What a weird bug

I cannot access Vercel to see what failed Can someone help me on this ?

@zamrokk The problem is the duplicate import here: https://github.com/trilitech/tezos-developer-docs/pull/197/files#diff-03cbcc9e6b2a55c9cf2d73092d78ddc7fa68f4d3d90d1f79b8d0707a1d1633b4R8-R9

oh wahou ! When I save and VsCode autoformats the file, then it is duplicating the line o.O What a weird bug

bug open : https://github.com/mdx-js/mdx/issues/2412


No results for multi-city

from fast_flights import FlightData, Passengers, create_filter, get_flights

# Create a new filter
filter = create_filter(
    flight_data=[
        # Include more if it's not a one-way trip
        FlightData(
            date='2024-06-19',  # Date of departure
            from_airport="IST",
            to_airport="LAX"
        ),
        FlightData(
            date='2024-07-09',  # Date of departure
            from_airport="NYC",
            to_airport="IST"
        ),
        # ... include more for round trips and multi-city trips
    ],
    trip="multi-city",  # Trip (round-trip, one-way, multi-city)
    seat="economy",  # Seat (economy, premium-economy, business or first)
    passengers=Passengers(
        adults=1,
        children=0,
        infants_in_seat=0,
        infants_on_lap=0
    ),
)

result = get_flights(filter)

# The price is currently... low/typical/high
print("The price is currently", result.current_price)

# Display the first flight
print(result.flights[0])

returns no flights however if I manually use
https://www.google.com/travel/flights?tfs=GhoSCjIwMjQtMDYtMTlqBRIDSVNUcgUSA0xBWBoaEgoyMDI0LTA3LTA5agUSA05ZQ3IFEgNJU1RCAQFIAZgBAw%3D%3D&hl=en&tfu=EgQIABABIgA
which is the generated link there are flights
I think the problem is results take about 2-3 secs to populate but response.get returns almost immediately without waiting

Could you please clarify the issue?

Hi there,
This is due to the EU Consent Request page. (See #1).
As mentioned in the issue by IHannes, they added a cookie and everything seems to be working fine.
We can add the CONSENT cookie and theoretically it should be working as expected.
cookies = { "CONSENT": "YES+" }

# tag: v0.3
get_flights(filter, cookies=cookies)

Refer to stackoverflow.com • bypassing-eu-consent-request for more.
P.S. I'm not aware of the "EU Consent Request" when developing this project since I'm not in the region. I'm deeply sorry for my oversight and any inconvenience caused.

Regards,
AWeirdDev

No this is not about the cookies I know about this because  I debugged into the return request and get the html text and rendered it in
https://htmledit.squarefree.com/
it renders find but there are no flights and blue color flow indicating search is continuing is running left to right
I believe this is about requests.get does not wait for an object to load and returns immediately If I use the url generated by your code on some other google flight scraper that uses selenium It works because they added something like as follows
driver.get(url)
WebDriverWait(driver, timeout=10).until(lambda d: len(_get_flight_elements(d)) > 100)
results = _get_flight_elements(driver)

where
def _get_flight_elements(driver):
    return driver.find_element(by=By.XPATH, value='//body[@id = "yDmH0d"]').text.split('\n')

Hi again,
Ahh, I understand the context now.
Both round-trip and one-way works fine, but not multi-city, as cited here:
https://github.com/AWeirdDev/flights/blob/c6e4d964e7eee673ae85f1f2ce3a18ff63147ef6/fast_flights/flights.proto#L25
I assume that multi-city loads custom Javascript that cannot be handled by requests. It requires something like puppeteer or playwright.
Just to keep this package light, we can use the try.playwright.tech API to scrape the flights. If you'd like me to implement this, please let me know. Alternatively, you can try the code below before v0.4 rolls out:

API

requests.post(
    "https://try.playwright.tech/service/control/run",
    headers={ "User-Agent": "... your user agent" },
    json={
        "code": "# some playwright python code",
        "language": "python"
    }
)

Sincerely,
AWeirdDev

@AWeirdDev dude this project is awesome  but what's even more awesome is your readme. Bro you could like write a newsletter love your style, keep up the great work! I'm working on trying to extract prices, did you look into this / make any progress or hit any walls I should know of? No luck yet, found some prices in the html but they are super random and all over a thousand dollars haha.

Hey @JobeOneKenobi,
Prices are now available on v1.x. For more information, please refer to wiki/What's-New.
P.S. I do put a lot of time into the READMEs, and you're the first to perceive this :skull: Thanks, man!
Cheers

Awesome!
Wait bro are your initials JC? Cuz SAME lol
On Sat, Jul 13, 2024 at 11:31 PM JC @.***> wrote:

Hey @JobeOneKenobi https://github.com/JobeOneKenobi,
Prices are now available on v1.x. For more information, please refer to
wiki/What's-New https://github.com/AWeirdDev/flights/wiki/What's-New.
P.S. I do put a lot of time into the READMEs, and you're the first to
perceive this 💀 Thanks, man!
Cheers
—
Reply to this email directly, view it on GitHub
https://github.com/AWeirdDev/flights/issues/2#issuecomment-2227182609,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/BDGRANGHKDEY6KJRI3HJV23ZMHWKVAVCNFSM6AAAAABIG7AQR2VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDEMRXGE4DENRQHE
.
You are receiving this because you were mentioned.Message ID:
@.***>


yeelink.light.mono6

The packaging says: Mi Smart LED Bulb (Warm white) but when running the script this shows up, hope you can figure it out and add support for this device.

#316


Slack username not included in message

With default config of fluxcloud, and the username env var set to something other than Flux, I can't see the username being changed in Slack channel. My env config:
- name: SLACK_USERNAME
  value: "Cool cluster"
- name: SLACK_URL
  value: "https://hooks.slack.com/services/XXXXXXXXX"
- name: SLACK_CHANNEL
  value: "#my-channel"
- name: SLACK_ICON_EMOJI
  value: ":sync:"
- name: GITHUB_URL
  value: "https://github.com/my-repo"
- name: LISTEN_ADDRESS
  value: ":3032"

Or maybe even more important, how do I access the username in the templating created in #12?

@justinbarrick Slack username and icon is absolete nowadays, stated here:

You cannot override the default channel (chosen by the user who installed your app), username, or icon when you're using Incoming Webhooks to post messages. Instead, these values will always inherit from the associated Slack app configuration.

It would be nice to be able to access through the template though.


Add input field - typeface to design system

Typeahead component based on Figma . To be used as search in dashboard and font picker in editor.
See figma: https://www.figma.com/file/bMhG3KyrJF8vIAODgmbeqT/Design-System?node-id=3397%3A800

Ticket added to keep track of new design system components - unnecessary for dashboard, not part of initial set up to start using design system external to dashboard.

Pulling this in to build a generic typeahead off of the dropDownMenu while it's still fresh.

@aaecheverria @samitron7
I want to get some clarity here because after a brief talk with Sam about something related - I don't think I should be using the existing functionality in the editor and dashboard to signify different behavior we want to stick around.
Expected Search functionality
Empty search that only allows for options to be valid terms (like the font family in editor)- 'biz baz foo taco' is not a valid font family, for example.
Situation 1

displays placeholder centered in input
I click into that input and the search icon is now left aligned, active state.
As I type, results are populated and a dropdown menu is shown
When I click one of these options the menu closes and that option fills in the input.
There's now a little 'x' icon to the right of the current input value.
If I clear the input's value by clicking the 'x' I get the initial placeholder centered in the input.

Situation 2

I type in something that doesn't match the list of options that are returned to me in my active search and then I focus out of the field - my input value is forced back to the prior valid value. This is directed towards the font face input.

Empty search that allows for user input to be valid search input (like free form search in the dashboard for stories that fit a certain criteria) where 'biz baz foo taco' could be part of an author name, story, or meta data.
The above situation 1 holds true.
Situation 2

If I type a string into the input that does not match anything in the list of options rendered that typed string is preserved as the value of the search input.

General behavior:

If I use my keyboard to clear an input should my focus get sent to the input, forced to the next element in the DOM or do nothing? The issue here is that the 'clear' button is only visible when there's something to clear.

(sam and i chatted and figured it out. i'll update the pr and the acceptance criteria)

https://google.github.io/web-stories-wp/storybook/?path=/story/designsystem-components-banner--default and go to design-system/components/search
See dark and light theme variations with lots of knobs to change props.
Try changing value, picking new options from the menu, changing knobs.
Functionality:

Focusing on input should shift the search icon to the left. If the input's empty no icon should be visible to the right hand side.
As soon as the input has a value length > 0 available menu options will be allowed to render. If there are none then the empty results message will show where the menu would be.
If there is value in input and menu is open the 'x' clear button should be present
if there is a value in input and menu is closed there is a chevron present.
search icon is always present
When input is inactive and has no value, placeholder and search icon are centered.
You should be able to enter the expanded menu by arrowDown from input and you should be able to leave the menu and return to the input with arrowUp.
If you have been typing text into the input and hit tab, you should land on the clear button.
Clicking on a clear button should clear the input and thereby close the menu.


Inner tables in buckets/ resources pages jumps to the right after loading the page content

Environment info

NooBaa Version: 5.1.1-32b0e18
Platform: Kubernetes 1.14.1 | minikube 1.1.1 | OpenShift 4.1 | other: specify

Actual behavior

after a couple of seconds on the buckets or resources screen, the inner content of the table moves to the right side and aligns.

Expected behavior

The table content should not move, tilt or align after the screen is presented.

Steps to reproduce

Go to the buckets list page, focus on the lines-> see the movement

More information - Screenshots / Logs / Other output

As we are not investing in the UI console, closing


CxfSoapClientIT.wsSecurityClient fails in native mode: wsse:Nonce not present in the request

Fix #3966
Would you like to review @javaduke?

Interesting, so moving it to a separate module and using xmlsecurity takes care of the SecureRandom issue....Hmm, I think I like it! Thank you very much for all your help with CXF!
I realized we also need to support WS-Addressing, but it can wait till later, I'll come up with some tests next week.

Hmm but looks like an issue with the pom:
'dependencies.dependency.version' for org.apache.cxf.xjc-utils:cxf-xjc-runtime:jar is missing. @ line 87, column 21

I guess this can be merged, I'll work on WS-Addressing in a week, I have a feeling it won't require any changes, but if yes, it can wait till the next release.


launching issue

i downloaded lates release lol bot and i launch main.py and didnt detect my account can you fix this?

sry my mistake now it got detected


HHH-13267 - Incredibly silly reverting removal of 7-year old deprecat…

…ion of JDBC-style parameters in HQL queries

I tried running the test using 5.1 EntityManager, and the tests operate differently. I need to look into this more deeply so I can provide more details.

@sebersole, ViburDBCPConnectionProviderTest is failing. See: https://travis-ci.org/hibernate/hibernate-orm/builds/493500681?utm_source=github_status&utm_medium=notification
The problem is with this query:
List<Actor> list = session.createQuery("from Actor where firstName = ?0")
                .setParameter(0, "CHRISTIAN").list();
Apparently, that worked before your fix, and I see the same query in master for 5.4.
After your fix, it needs to be changed to one of the following to work.
List<Actor> list = session.createQuery("from Actor where firstName = ?1")
                .setParameter(1, "CHRISTIAN").list();
or
hibernate.query.sql.jdbc_style_params_base=true must be set, and the query changed:
List<Actor> list = session.createQuery("from Actor where firstName = ?")
                .setParameter(0, "CHRISTIAN").list();
I see that your test, LegacyPositionalParameterTest#testJpaParameterUsageIncorrectBase, expects a "?0" as a parameter to fail. Should this actually work in 5.3/5.4?

I changed the query for ViburDBCPConnectionProviderTest to the following, which also works in master:
List<Actor> list = session.createQuery("from Actor where firstName = ?5")
                .setParameter(5, "CHRISTIAN").list();
The test, LegacyPositionalParameterTest#testJpaParameterUsageIncorrectLabel is similar, and it expects the query to fail.

I believe the other differences were expected. I'd like to confirm this though.
In 5.1, HQL queries using '?' require parameter numbers to start at 0.
In 5.1, EM queries using '?' require parameter numbers to start at 1.
After fix to 5.3, hibernate.query.sql.jdbc_style_params_base=true must be set in order for '?' to start numbering at 0; otherwise parameter numbers start at 1.

I am not sure where the expectation that ?0 in an HQL or JPQL query would ever work.  A "labelled positional" parameter (? followed by an int) is an idea JPA added.  JPA says that the labels must be contiguous and must start with 1.  Attempting to use ?0 should fail

@sebersole, I created some tests to show how things work in 5.1 and master.
The tests are written so they pass.
In 5.1 (https://github.com/gbadner/hibernate-core/commit/63414349c8ae6855e8624984a91e4ee11a43d7ef):
In master (https://github.com/gbadner/hibernate-core/commit/10a3da6c99bc7b0179041c067765331fb76f2514):
Summary:
Using parameter ?0 only:

5.1 native HQL: throws QueryParameterException
5.1 EM query: query executes without any problem
master: query executes without any problem

Using parameter ?5 only:

5.1 native HQL: throws QueryParameterException
5.1 EM query: query executes without any problem
master: query executes without any problem

Using parameters ?0 and ?5 in same query

5.1 native HQL: throws QueryParameterException
5.1 EM query: query executes without any problem
master: throws QueryParameterException


Add RVizVisualizer

Basic implementation to use RViz as visualizer.

@jcarpent, I updated both README in 863d3fc760f70534aebc73e973ca77d588b6574f

The marker Rviz plugin is not the ideal solution. Instead, you might look the whole-body state rviz plugin (look in loco-3d organisation).
This plugin can display robot meshes, contact forces, CoM position and velocity, COP, friction come, etc.
This plugin also can visualize trajectories. We are heavily using it in our robots.

Please make comments in the code directly @cmastalli with links to precise codes in the package you have mentioned. It will definitely help @EtienneAr to improve his PR.

@cmastalli The goal of this viewer is to be flexible, easy to use and mostly written in Python for easy and flexible extensions.

@cmastalli The goal of this viewer is to be flexible, easy to use and mostly written in Python for easy and flexible extensions.

You can use the whole-body state plugin with Python code. Just need to write a publisher that contains the whole-body state msgs.
Check out the plugin here: https://github.com/loco-3d/whole_body_state_rviz_plugin
If this solution is in your interested, I could provide more details on the code

Btw, this plugin is based on Pinocchio ;)

The thing is that we may want to add additional features (buttons, players, loading FLC geometry on the flight, etc.) and have the flexibility to create a GUI for specific applications without having to write C++ codes, as offered by RVIZ+Qt.
Your interface seems to be too much specific and linked to locomotion mostly.

Btw, this plugin is based on Pinocchio ;)

Pinocchio cannot rely on a lib ... which also depends on Pinocchio.

The plugin applies to any robot. It uses urdf loaded in the parameter server. Thus, you could load your FCL geometry (i.e., custom urdf). A code that use this plugin will depend on the whole-body state msg only (so not recursive dependency).

Working totally fine on my side. Thanks again @EtienneAr for this nice work.


fix: robust voronoi estimation.

Voronoi density compensation may have some trouble estimating area/volumes of cell that are on boundary, this PR removes the outliers and uses interpolation to fix values.


created networking services folders

@KumudD,
Thanks for your contribution as a Microsoft full-time employee or intern. You do not need to sign a CLA.
Thanks,
Microsoft Pull Request Bot

#sign-off

@KumudD,
Thanks for your contribution as a Microsoft full-time employee or intern. You do not need to sign a CLA.
Thanks,
Microsoft Pull Request Bot

#sign-off