Ability to define global templating configuration

Consider these two use cases:

When we introduced handlebars, since we didn't want to break backwards compatibility, we decided to leave the default template_engine as mustache. But we never discussed about the plan to change this default. So we should introduce a way that data-modelers can globally change this default.
In some cases we might want to write a markdown_pattern that is using a static value that is shared throughout the whole catalog. For example, let's say that we want to prepend all the Titles with the project name. Or in case of google-dataset annotation, we have to define creator, license, and usageInfo in all the tables. In these cases, it would be useful if data-modelers could define a global object that they can use everywhere. With this, if they ever need to change any of these static values, they don't have to change multiple places and they would just need to change the global object.

Therefore, we decided to introduce a new chaise-config properly called templating, which has the following format:
{
  "templating": {
    "engine": "mustache|handlebars", // the default engine
    "environment": {
      "static": {
        // define the static global object here
      },
      "dynamic": {
        // we're not going to implement this now but we might want something like this in the future
      }
    }
  }
}

ERMrestJS will use the defined "static" object as the starting object and will add other variables to it. We're not going to enforce any rules for the names chosen in this object and data-modelers should just make sure these names don't clash with the ones that chaise ERMrestJS generates. So the convention is to begin each attribute key with $ under the static object. An example of this chaise-config property would be
{
  "templating": {
    "engine": "mustache|handlebars", // the default engine
    "environment": {
      "static": {
        "$gudmap_static": {
          "consortium": "gudmap"
        },
        "$language": "en-US"
      }
    }
  }
}

Which can be used like this
www.{{{$gudmap_static}}}.org

or
"tag:isrd.isi.edu,2021:google-dataset": {
  "detailed": {
    "dataset": {
       "inLanguage": "{{{$language}}}",
       ...
    }
  }
}

The engine property has been implemented. So only the environment is left that requires further discussion.


support allegro

Dear Authors of VideoSys,
This is Yuxuan, an author of Allegro. I move the Allegro model into your framework for faster multi-card inference and PAB. I provide an inference demo in examples/allegro/sample.py.
If you have any questions please feel free to contact us.
Thanks for your framework!
Best,
Yuxuan

thanks for your contribution! will review soon!


Doubled cog commands

I made music cog, but slash commands are doubled in that cog.

(And other music commands..)
Before run:
client.load_extension('cogs.music')
In music.py:
def setup(client: commands.Bot):     client.add_cog(Music(client))
And cog slash command example:

This is almost certainly because one is a guild command, one is global. add this to your slash innit delete_from_unused_guilds=True
https://discord-py-slash-command.readthedocs.io/en/latest/discord_slash.client.html#discord_slash.client.SlashCommand


GURPS.performAction requires refactoring.

While working on my module I am using GURPS.performAction a lot because it's the cleanest way to perform an action with a provided actor.
However, navigating it is pretty hard, and it's also not easy to figure out the requirements of each type of action at a glance.
I think the solution is to create a function for each type of action and have them being called depending on the type of action.
This would also allow scripts and modules to perform specific actions more easily, assuming the inner functions will be accessible in some way.
Also, the inner functions should probably return fuller data, and only GURPS.performAction itself should convert those into boolean results, that way a script calling an inner function would have direct access to the data instead of relying on hacks like looking at GURPS.LastTargetedRoll right after executing the action, which I am currently forced to do in my module.

I am ready to help with the refactoring if you are currently busy working on other stuff

II'm totally with you. If you look at module/global-references.js you'll see my attempt to document fields in the Action to map them to the function that requires them. I was going to look into refactoring Action into an object hierarchy -- the top level would contain a stub with the action type and any global/universal fields (there may not even be any!) and an embedded object that contains only the fields needed for that type of action.
Ultimately I want to leave this decision to @crnormand since that function (and the project as a whole) is his.

No.   Not going to do it...
j/k   ;-)
Of course it needs refactoring.     Especially if your modules needs/want to gain access to an individual action.  Let's do it.    For the record, I am never against refactoring... it is just that my tolerance for crappy code is WAY higher that Jeff's, which is why we are a good team.    I hack stuff together... and Jeff keeps reminding me to clean it up.
Let me describe the evolution of the code, and the requirements as I know them, and we can discuss plans.   @danielrab  if I am being too obvious, forgive me, I haven't worked with you yet, so I don't know your capabilities (although from the rumor mill, they are pretty good).
Any random piece of text can be sent to parselink() and it will return an "action object".    We hook into the chat log, the journal display and of course the character sheet.   The "action object" contains the HTML to display (which allows us to return a CSS laden string to simulate a button press) and the action data.    Originally, the action data was just a string representing the "action" (attribute roll, skill roll, etc.) and a few numbers (usually the target value).   This data is used by the performAction() function, which is just a huge IF statement tree.   Those two functions (parselink and performAction) are concretely tied together.    The string literals in parselink are used in the performAction IF check.
Of course, as we learned to parse more OtF formula, we added code in performAction() to execute the action that was parsed.
So you can understand how we go to here.    Both parselink and performAction are just huge IF statement trees that can easily be broken up.
NOTE:   The "HTML to display" that is returned by parselink also includes the action data encoded into the HTML.    See the functions gspan and gmspan at the bottom of parselink.js.     When a user clicks on the HTML (because it is displaying as an OtF button), and the encoded data is used to re-create the action (instead of trying to re-parse the text again).    You can see how it is used in gurps-wiring.js handleGurpsLink().    We needed to do this because the displayed test would have less information than the original text, and we needed to be able to record it.    If you examine any OtF formula in the browser, you will see something like:
DX 13
Ok, what can we do going forward?   For the most part, each individual IF action.type === 'some action' in performAction() could be broken into its own method.     And instead of "falling" through to the final doRoll() call at the end of performAction(), each individual "perform action" method could call doRoll() directly (or whatever they need).   So it might look more like:
...
if (action.type === 'controlroll') return await performActionControlRoll(action)
if (action.type === 'roll' return await performActionRoll(action)

ui.notifications.warn('If you got to this line, the input action type was not recognized').

I don't feel that the action objects themselves have a lot of functionality... they are just two pieces of data... a display html and a structure containing enough information for the performAction function.    You are welcome to refactor them into an object hierarchy, but they have very little functionality on their own.    Just remember, there is a DIRECT tie between each section of parselink() and the corresponding IF statement in performAction().
Of course, if you are looking to call performAction() directly, without going through parselink(), then yes, you will need some kind of factory function to build the action data for you.   You can make an action object hierarchy to do this, or a series of factory methods.
WARNING:   The action.type === 'skill-spell' || action.type === 'attribute' portion of performAction() is a mess.   And of course, it is because it evolved over time.    Most of the work is done by processLinked() (which for some reason wasn't made into it isn't own method).   One of the biggest issues is that some of the variables set in processLinked() are "global" to the performAction() method, and not local to processLinked().   I think it is only 'target' and 'thing'.. but there could be more.
And of course, it got this way because of the whole "we kept adding cool things over time" issue ;-)
Plans going forward... I would suggest (but do not insist on), doing it in steps (individual PRs) like:

Break out the individual IF sections of performAction into separate methods and remove the doRoll() call at the end (which means that each section will have to call doRoll() on its own, if necessary).   Originally, ALL of the functions called doRoll(), but over time we added things that did not (PDF links, Chat links, etc.)

Create factory methods for the action data which can be called by the various sections in parselink, AND by external modules like yours.    Basically, any time you see code like:

let action = {
      type: 'dragdrop',
        orig: str,
        link: m[1],
        id: m[2],
      }

This is a "factory" function to create the action data specific for that action.

Optional, if you want to make the action data into a first class object, do it now so you just modify the factory methods and the individual performAction functions.    You might find that once you have create the factory methods and broken out the corresponding performAction functions... you don't really need them... but YMMV.

Is this what you were thinking?

yes, this is almost word for word what I was thinking about.  Thanks for a detailed description of how most things work there. I completely understand how such things come to be. The steps you are proposing sound very reasonable.
P.S.: there are rumors about my capabilities?

LOL, yup!   And your module is proof!   I haven't had a chance to look at it yet, trying to catch up on my backlog... but I can tell that people like it.

in the attack section there is this block
if (!!t) {
      let a = (t + '').trim().split(' ')
      t = a[0]
      if (!!t) target = parseInt(t)
      if (isNaN(target)) target = 0
      // Can't roll against a non-integer
      else {
        a.shift()
        let m = a.join(' ')
        if (!!m) GURPS.ModifierBucket.addModifier(0, m) //  Level may have "*Costs xFP"
      }
    }

as far as I understand it deals with levels saved as strings, but levels are currently saved as integers, so as far as I understand it's almost fully redundant.

That section was put in specifically for a player that embedded FP cost into the spell skill rolls, and it got expanded to attack skill level rolls as well.
So a user could enter their attack skill level as "12 *Costs 1FP", so that the attempt to use the attack would automatically deduct 1 FP from the character.
Of course, looking through the code right now, it seems that the "costs" feature was accidentally deleted from the skill check code at some point.   I am going to re-instate it, since I think it has some functionatility.

My apologizes... it was not deleted...  it exists in the parselink.js code.

And looking through the code some more... it seems that Attacks do the same thing (calculate possible COSTS in parselink.js... so is the section in performAction vestigial?   Quite possibly.   I think it should be safe to remove from performAction (since it is handled in parselink.js).

Chris - the "12 *Costs 1FP" process doesn't appear to be working in the sample "cool macros" fireball Macro.  I mentioned this before but it was amongst my general issues with Macros not working but that's resolved but still FP isn't affected using the macro as written in your cool macro wiki (and similarly if I try to tag other resources - for example, I have a mage using Threshold magic and I want to increment that resources tracker when casting).
Any ideas?

I am happy to say that I think I untangled the mess that was performAction, including the part of using skills and attributes. Now I am firmly in the "make the code repeat itself less" part of refactoring, so it shouldn't be long before I make a pull request.

Cool!  I can't wait to see!

there are different directions this could be taken now, and I have other things to do, and I already had problems merging changes, so I'll just make a pull request with the changes so far and we'll se from there.

Sounds good! Looking forward to reviewing code.


Remove 3-D Perspective on side images?

Hi,
I LOVE this carousel but my client wants to remove the 3D effect from the sides and just have a regular carousel (essentially the same as what it would look like on older browsers). Can you tell me how to do this?
Thanks!

hey @superscotty19
It is intended to render 3D from the base. I don't think It can be just on/off the feature.
sorry :(


request: update how Theme is propagated

Is there an existing feature request for this?

[X] I have searched the existing issues.

Command
Update how Theme is propagated
Description
I think theming in the golden test should be handled as follows t:

Look for an inherited widget to see if there is an ancestor theme (if there is use it),
If no ancestor theme is found, use the one provided via the configuration
If no configuration is provided, don't inject any theme inherited widget

Reasoning
Achieve a better API that would make the library more Flutter friendly. It makes it easier to migrate from regular golden testing to Alchemist, since on regular golden test theming is handled by the Widget tree and is not overridden as in the case of Alchemist.
Additional context and comments
No response

I'm working on this.
It's important to note this currently is only an issue when a custom pumpWidget function is provided that contains a MaterialApp or Theme that provides a theme.
It looks like the theme data provided by the pump function is overridden. This is a use-case we didn't account for, so I'll investigate and see if there is a simple solution.

POC working. Updating docs and tests now.
Progress can be followed in this fork.


Add missing Base.similar(::QuantityArray, ...) definition

Fixes #93 #94 by @jkrumbiegel.
All it turned out to be was a missing method
Base.similar(::QuantityArray, ::Type{<:Quantity}, ::Dims)

which is used in the standard lib for some of the array operations.
The method I had written had mistakenly assumed the ::Type here was the numeric eltype, like Float64. But in retrospect it was perhaps obvious that this would be the quantity type, because, after all, QuantityArray is an AbstractArray{Q,N} where Q is a quantity type.
Let me know if this works for you @jkrumbiegel

I also added a ::Q type assertion to prevent stack overflows related to converting a quantity of a quantity to a quantity.
We should probably implement a constructor for quantities of quantities that throws an error or simply converts to a regular quantity...

One other issue I'm seeing is that
map(x -> x^2, QuantityArray([0.5u"m"]))

doesn't seem to work even with this change, due to a DimensionError (it creates a similar array without checking the output dimension). It seems we may need to overload _similar_for in the standard library, because it doesn't seem to rely on the broadcasting methods I've already overloaded.

 Once you are content with this @jkrumbiegel we could merge this.
(Although I think I might need to add some extra unittests to get coverage on the other branches of _similar_for.)


FastReport.OpenSource

I installed FastReport.OpenSource NuGet package for a net6.0 WinForms Application
Trying to show empty report as a test, but there aren't methods Show or ShowPrepared, despite them being referenced in the commentary to Report class.

Hello!
For testing using the report designer and report preview, you will be able to install the built application at the link: https://github.com/FastReports/FastReport/releases/tag/v2025.1.0.
In your application you will be able to use the FastReport.Net.Demo nuget package
Best regards,
Bogdan


Better UI/UX for external links

The app uses one shade of blue and one shade of blue-green to differentiate internal and external links.
I do not think the purpose of this is clear.
Maybe a more traditional external link indicator would make sense to use here? (https://www.flaticon.com/free-icon/external-link-symbol_25284)

Fixed and merged in master.


maxOverzoomLevel not working in some cases

Context:
I have a vector layer using a MergedMBVTTileDataSource:

map datasource defined from 0 to 14
contours datasource which is defined from 9 to 13

until now the contours data source was defined up to 14 which was working perfectly and i was seeing contours at zoom > 14
Now my contours stops at 13. What i see is contours disappearing completely at zooms > 13.
I tried to force the contours datasource maxZoom to 14 and it started working. However i would prefer not to have to do that.
Not sure what or if it should be fixed.

Actually i stand corrected. Forcing the maxZoom to 14 even if there only data up to 13 breaks all others data sources from MergedMBVTTileDataSource. No more data from zoom 14...

@farfromrefug MergedMBVTTileDataSource only merges layers from tiles with matching zoom levels. If zoom ranges are not equal, then layers are simply dropped if outside the intersection of the zoom ranges of the datasources. It is technically quite hard to change this. For example, to make datasource with maxZoom=13 to work at zoom=14, the datasource needs to decode all the features, rescale the geometry coordinates and perform clipping. Basically it does not seem to be worth it.

@mtehver thanks for looing into this. i got to the same conclusion and yes seems quite hard.
I would say it is a good to have feature because it can reduce packages (mbtiles) by 4x if we had that (for contours for example).
But anyway there is one last thing i dont get. Past zoom 14 you do rescale and clip, right? I am not sure i understand why we could not apply the same rule in MergedMBVTTileDataSource as the one past zoom 14. But i might just not get it ...


When will my iPhone 12 (1.048GB, WHITE) be supported?

Can you be more specific? Are you using the invisible phone case?

@standre  Did you try to balance the phone on your head?


Fix for random unloving/loving of tracks on last.fm

See https://github.com/radiant-player/radiant-player-mac/issues/390
Essentially, the rating observer was being called before the track info was updated, meaning that for every song it was applying the loved status of the previous song.  This PR should fix that.
I've logged a separate issue at https://github.com/radiant-player/radiant-player-mac/issues/425 to look into stopping the multiple unnecessarily api calls at the start of every song.

LGTM (though separately we should probably change the CHANGELOG on each PR, so you may want to add an entry)
:shipit:

Ah OK, so we're adding our own changelog entries? No worries, I'll update it before I merge.

Interesting point though - if we're referencing PRs from the changelog (which is a good idea), this means we have to PR to get the PR url, then update the changelog, rebase, and push an updated PR straight away.  Which isn't the end of the world, but it is a bit of a PITA.  It also means we have to ask contributers to update the changelog.
tbh, I wouldn't have an issue with the merger pushing a changelog change directly to master once it's been merged, as it's not a functional change.  As long as it's just a change to that file, it shouldn't be an issue and it'll only ever be one of us that does it.


Consider using Lotte

https://github.com/airbnb/lottie-react-native

Where would you like us to use Lottie. I have experience using it

Cool!
I guess it is more of a general idea, so I had no specific use case in mind ;)
Maybe on loading, on some actions, maybe some buttons when interacted, some animation during a new introduction page.


Fixes tracker code bug on handling pushState

Enforcing .toString() on navigatedURL, because without it it returns an object and break history state changes;
Typo navaigatedUrl to navigatedURL;

Thanks!


Skill is unresponsive

Hello, first of all, thank you for an awesome tool. I have been using it for a few months now without issues. In that last few days it stopped working completely. i am getting a "Sorry, the device xxx is not responding" message from Alexa. I am also unable to discover new devices so looks like communication between Alexa and the servers is down. I tried resetting alexa, adding / removing devices from your website, changing node-red settings but no solution so far. Any ideas how I can bring it back to life? Thanks!

I created a test account and was able to create new device and have it be discovered by Alexa... Still trying to see how I can get my old account back online

This is probably because your oauth token has expired (after 3 months), I can't get Alexa to renew tokens properly, like it's supposed to.
I can fix the token expiry manually (set it to 100 years), but not until I get home tonight.

Thank you for a quick response, that makes sense. If needed, my account ID for your website is the same as here. Appreciate the help!

OK, the account for the username kdubovenko the token is already set to expire in 2117 so it's not that, but the date matches.
Did you try re-linking original account in the alexa app?

That's 100 years of automation! Sounds like a good time :). I did re-ling yesterday, through the alexa app by disabling and re-enabling the skill. The only thing that worked was to create a "test" account instead (kdubovenko_test). I'll give it another shot with the original account tonight, just in case. I'll post the result here.

Tried re-linking the original account again but the issue persists, looks like I'll be switching to the secondary account I created for now. If I am able to come up with a solution myself, I'll post it here.


Heli spawner "dummy" bug

The helicopter spawner onboard Normandie seems to be stuck by detecting an object named "dummy" on the hangar helipad, which is not removable nor replacable with a proper chopper.

Was not fixed by #44

Was not fixed by #44

Was not fixed by #44

Was not fixed by #44

Should be fixed by team-gsri/GSRI-Opex#70

Should be fixed by team-gsri/GSRI-Opex#70

Confirmed fixed with OPEX


[sometimes] Does not get the real time length of video in YouTube.

Everything is working fine, except the extension is not getting the real length of the video/ media from YouTube. For example the video is 3minutes long, the extension is still displaying 10s, i can only select between 0 to 10 sec. Please fix it, it's very useful.
it may cause by another extension that i've installed (Improved tube), I enabled auto 1.5x video playback speed in Improved tube

I know where the issue is now, when i switch to anther tab, the extension won't work, need to refresh the youtube tab.

this one works perfectly

https://chrome.google.com/webstore/detail/youtube-music-player-and/fjjakcegmanppooiaipboapdchfffjmh

wish one day microsoft will implement this features in Windows 10, like Plasma Desktop in Linux. Can control media progress bar even in other application

Hey, thanks for the feedback!
I know that with this extension there are 2 major problems:

The bar only updates once you click the extension, and is not real time
It doesn't find a video if it's inside a iframe, which is annoying

Apart from those 2, I didn't see other problems.
Btw, at the bottom of the extension UI there are more than 1 dots sometimes, so maybe try all of them, because there could be more video in the page.
I use KDE with arch linux, so I also use that feature :)
Let me know if the problem persist, I will take a look.

I found these extension works fine. even in other tab


kibbeh: add /download page

adds /download page to kibbeh
fixed #2187 (it was one line change so didn't make separate pr)

Why is react-virtualized removed from the lockfile?

Why is react-virtualized removed from the lockfile?

i have no idea... i just pulled and then added this, i didn't mess with lock

@ajmnz react-virtualized doesn't exist in the lockfile rn also?

it's GitHub not Github

Resolve conflicts

Resolve conflicts

ok my bad

test

rip out all the useScrollStore stuff (we are not going to solve that bug in that way), fix conflict, and then I'll merge

rip out all the useScrollStore stuff (we are not going to solve that bug in that way), fix conflict, and then I'll merge

give me 2 seconds

ok @benawad it's ready now

cool


KOGITO-6181 : Stunner-based editors are loosing focus when asked for the SVG

Hi @romartin @LuboTerifaj this is the new PR. Old one was https://github.com/kiegroup/kogito-editors-java/pull/158 can you review?

@inodeman To re-trigger the CI, please push an empty commit. If you found a flaky test, please skip it on this PR and add it to this epic https://issues.redhat.com/browse/KOGITO-6643

Will do @tiagobento thanks

Hi @LuboTerifaj about last comment, I mentioned I did not touch code relating to the toolbar, so that behavious should be the same as in main branch, let me know

Build can be found here. https://drive.google.com/drive/folders/1G5UfG5aHqBHFX1RRYHErgnVNER9Felrw?usp=sharing

Hi @LuboTerifaj just reproduced the issue you mentioned, let me fix it.

@inodeman Our CI had some problems earlier today, can you please rebase this PR?

Hi @tiagobento rebased now.

The (build) kie-tools-stunner-editors check has failed. Please check the logs.

jenkins retest this please

What's missing for this to be merged?

@LuboTerifaj please remember this review, I think is ready to review again, thanks!!

Hi @LuboTerifaj sorry seems I uploaded wrong build, uploading it again.

@LuboTerifaj please friendly reminder about htis review thx


Add weights hyperparemeter to EnsembleForecaster API

Is your feature request related to a problem? Please describe.
EnsembleForecaster does not currently accept weights. With #1136  and #1139 being worked on it would be nice to optionally allow users to pass weights to EnsembleForecaster.
This would give users an out-of-the-box way to use ainverse error based weighting strategy in forecasting ensembles. Users could also supply other types of weights (information criterion, etc).
Describe the solution you'd like
An update to the EnsembleForecaster API to allow weights to be passed (number weights should equal number of forecasters passed).
This would require altering the __init__ to store the weights, adding a check (in _fit?), and then updating _predict to use versions of the aggfunc that allow weights (for examples of this see use of _weighted_percentile, _weighted_geometric_mean, and np.average in performance_metrics_functions.py).
Describe alternatives you've considered
N/A
Additional context
N/A

Hm, how does this relate to the online weighted ensemble and the hedge forecasters?
Would be good if you could look at both in detail, to avoid duplication or interface inconsistency.

@fkiraly they are definately related.
As a start, this would essentially be the "non-online" version of the PredictionWeightedEnsemble from the tutorial (which is built from the online ensemble).
Since OnlineEnsembleForecaster inherits from EnsembleForecaster a second option (but not necessarily something we'd need to do) would be to also add a weights hyperparameter to the OnlineEnsembleForecaster that would initialize the weights based on user input (default would be to initialize as 1 / # of forecasters like currently done).
I'd also like to improve the documentation in this area so its a bit more accessible, but have a few questions to verify my understanding. We can work on that separately.

I'd also like to improve the documentation in this area so its a bit more accessible, but have a few questions to verify my understanding. We can work on that separately.

Yes, indeed - especially the methodological documentation. I have to admit I'm not exactly sure which algorithms are implemented there exactly, and this needs to be clarified and improved in the docs.

Yep -- it is hard to figure that out from the documentation we have currently. I actually want take a crack at the user guide for forecasting to help make things more clear (and of course fix the docstrings as I go through that).

Hi @RNKuhns I'd like to work on this 🚀

@GuzalBulatova that works for me. @aiwalter and I have been talking about some options for the functionality. Maybe the three of us can find a quick time to talk.
After digging into the online ensemblers per @fkiraly's comment above. I think that the current differences between that and EnsembleForecaster are currently that the online ensemblers use weights and update those weights (the online part).
I think that it would be reasonable if the only difference was that the online ensembles update their weights (EnsembleForecaster would fix its weights based on the new weights hyperparameter).


Use stdpath for chats_dir

Instead of the manual chats_dir in the default config, I think using nvim's stdpath like so,
chat_dir = vim.fn.stdpath('data') .. 'gp' .. 'chats'
will be more useful for those using neovim distributions or people like me who use a separate
config directory from neovim's default one.

@razak17 Hey, thanks for pointing this out - fixed and closing.


Choose a style guide for SS3 code

Issues #293 and #163 brought up the fact that we don't have an agreed upon style guide for the ss3 codebase. I think we could probably choose a c++ one, but we may also need to add conventions given that tpls can look a little different. Some questions that come to mind are:

Is a semicolon required after each statement when declaring variables? I think you don't needed it for certain sections in the tpl, but maybe we should choose 1 convention.
Should 1 statement for loops and if statements always be included in curly braces {}?
Whitespace conventions: this is probably answered in a style guide, but when should there be whitespace and when should there not (e.g., is for(a=1;a<10;a++) or for (a = 1; a < 10; a++) the correct style?)

Perhaps @nschindler-noaa has thoughts on this to start?

I am good with adding semicolons at end of lines, even if unnecessary for that part of the tpl.  But all of this is in the pats of the tpl that the style tool cannot be used on, yet.
Good with adding {} even when not needed.  Can the style tool be this?
Undecided on white space.  It is going to be very hard to remember to add these spaces if we require everything to be delimited by white space.

Thanks for noting your preferences, @Rick-Methot-NOAA! I think since you are the primary code contributor, that matters a lot to keeping style consistent.
I think Neal said that the style tool could add {}, but that we didn't have the setting turned on last time?
I wonder if the way to get started on this would be to

[ ] Rick chooses one of the style guides linked in this section: https://clang.llvm.org/docs/ClangFormatStyleOptions.html#configurable-format-style-options .
[ ] @Rick-Methot-NOAA and @nschindler-noaa could go through it and decide if any changes are needed for our group?
[ ] Finally, perhaps Neal can then make sure the desired settings are selected in the .clang-format file to make sure our styling tool is consistent with our style guide?

To throw in my 2c about whitespace preferences, I find code a lot more readable with more whitespace. But I can get over it if needed. :)

With regard to whitespace conventions, I can add that with regard to style of R code, the first time the automatic styler added whitespace throughout the r4ss functions, I found them immediately easier to read, but I still often forget to type them when adding new code. However, I don't see that mismatch as a big deal because the github action just adds them for me. Yes, the ideal would be that we could agree on a style that's easy to adhere to, but I don't think it would be a problem if the humans never added whitespaces and they were added every time by ClangFormat.

One good thing I learned is compiler warnings do get generated if you modify something from
if (the_value == 0)
  set_me = 1;

to
if (the_value == 0)
  set_me = 1;
  new_setting = 2;

when what was meant is:
if (the_value == 0)
{
  set_me = 1;
  new_setting = 2;
}

There will be a compiler warning generated when using -Wall and our warnings github action will flag increased warnings :
ss.cpp:12294:9: warning: this ‘if’ clause does not guard... [-Wmisleading-indentation]
12294 |         if (the_value == 0)
      |         ^~
ss.cpp:12296:11: note: ...this statement, but the latter is misleadingly indented as if it were guarded by the ‘if’
12296 |           new_setting = 2;
      |           ^~~~~~~~~

I would never want to rely on indentation as basis for assuming that consecutive statements belong together in an IF clause.

I would never want to rely on indentation as basis for assuming that consecutive statements belong together in an IF clause.

Yes, completely agree. I still advocate for curly braces in all cases, even when they technically aren't needed.

I think (hope) that I was consistent in omitting the {} only when statement was on same line as the IF:
IF (...)  statement
so did the ambiguity arise when the styler put statement on the next line?

Yes, you were consistent! The warnings were caused by me adding lines while working on the console output... I double checked and no similar warnings are in the main branch. I since fixed on the branch I was working on, because github actions caught that there were more warnings.
The warnings are caused when you try to use two statements instead of one (which doesn't work correctly) while the brackets are eliminated. I think the compiler is trying to be helpful here and guess that you messed up the syntax!

Link to the draft google doc where we are working on the style guide: https://docs.google.com/document/d/1q11sZl4rcgx1Cs8wkOs8dPAaIpkEAGrKNb3b94bfbdU/edit?usp=sharing

Great! I just found out that we can turn clang-format on and off internally
in the code.
So, something like this
LOCAL_CALCS
// clang-format on
some code and comments . . .
// clang-format off
END_CALCS
Works!
I tried it on SS_param.tpl (which did not work with clang-format before)
and it compiled. Now, I just need to adjust the .clang-format file.
On Wed, Jun 22, 2022 at 10:36 AM Kathryn Doering @.***>
wrote:

Link to the draft google doc where we are working on the style guide:
https://docs.google.com/document/d/1q11sZl4rcgx1Cs8wkOs8dPAaIpkEAGrKNb3b94bfbdU/edit?usp=sharing
—
Reply to this email directly, view it on GitHub
https://github.com/nmfs-stock-synthesis/stock-synthesis/issues/311#issuecomment-1163420921,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/ARUZACTBCC75OMJTSDWBKS3VQNFKBANCNFSM5VWFCCRA
.
You are receiving this because you were mentioned.Message ID:
@.***>

--
Neal Schindler
Programmer Analyst, Caelum
NWFSC<PHONE_NUMBER>
cell<PHONE_NUMBER>

=(((<  >=(((<  >=(((`<

=(((`<

By using the clang-format on/off switches, I was able to pass SS_param and the SS_read(s) through the pretty_tpl routine. I also changed .clang-format (the configuration file) to allow single line IFs and FORs. This is in branch 163-new-style.

I prefer to have indents mean something. It helps my brain to see what code goes together more easily.

By using the clang-format on/off switches, I was able to pass SS_param and the SS_read(s) through the pretty_tpl routine. I also changed .clang-format (the configuration file) to allow single line IFs and FORs. This is in branch 163-new-style.

That's great more files can be passed through! I wonder if we should avoid committing formatting changes again, though, until we for sure decide upon a style? For instance, I thought we were leaning toward not allowing single-line (and assuming without {} ) if and or statements?

I prefer to have indents mean something. It helps my brain to see what code goes together more easily.

Yes, totally agree!

Sorry, I didn't realize the question was still open. the file .clang-format (a hidden file) controls how clang-format behaves. These are the tow lines that affect that:
AllowShortIfStatementsOnASingleLine: true
AllowShortLoopsOnASingleLine: true
I don't mind waiting to merge. I'll try to keep the branches updated from main.

Maybe we can leave it open until our team meeting next week, just so we are all on the same page about the style.

I've changed this file on branch 163-new-style to better describe what our guidelines are. It's interesting that the name of the file and the title in the file do not match. "Coding Style" or "Programming Style"? such a silly question.
coding_style.md

Where the document says "in TPL",  this only applies to the parts of readstarter, readdata, and readcontrol that are not in LOCAL_CALCS.
For the use of {}, is it OK to use:
if ( this > that ) {
code;
}
or
if ( this > that )
{code;}
or should every curly brace be on its own line?  I see both approaches advocated in style discussions.

I think this is a discussion we all need to have together. There are too many options. Plus the single line
if (this > that) {Do stuff; do other stuff;}
which, I think could be allowed for single lines of code started by !!.
But, let's get the whole group's agreement on what is recommended and what is allowed.

Yes. I will.


Fix new Millet lints

Fixed/ignored new lints:

detecting {} instead of ()/unit
detecting fn x => f x instead of f

Also more whitespace fixes

any progress on this?

@azdavis hey ariel, sorry, i got mega distracted and kept putting off looking at this
i actually have some concerns over the edits proposed in this PR -- namely, I'm not a big fan of the changes to use ellipses to get rid of unused record components, as in the below screenshot:

the reason for this is that the type of contexts is relatively mutable, in terms of the evolution of this project. i might want to add more fields to it, for instance. in such a case, I would usually rely on the compiler to tell me where I may need to make changes (using the new field, for instance), but if the fields are "ellipsed out", then i will get no such compiler warning.
i'm also not a big fan of unconditionally collapsing eta expansion. i think eta expansion can sometimes be useful, for instance when writing something of the form fn x => fn y => f x y, when I've forgotten what the arguments to the function f are. it can be useful in this case to see that f is meant to be used with two arguments here, with descriptive names given to x and y. does that make sense?

yea makes sense, feel free to tweak to merge only the bits you want or close entirely, anything is ok with me. mostly wanted to see some kind of movement on the pr (whether that be merging or closing it)

gonna close this actually and leave it up to you to ignore/fix the new warnings at your pleasure whenever you want to work on mulligan next


[Sema] Fix assert with incorrectly allowing optional injection into operator inout argument.

When matching types on an operator 'inout' param and lvalue argument, be more restrictive with the inner match by changing the match kind. Allowing optional injection here is a no no.

Resolves SR-8221.

@xedin Alrighty. Is there a way to tell swift-ci not to merge after all? A quick look about the docs doesn't reveal anything to me..

@swift-ci Please test source compatibility

Only if you force push while it’s running, that’s going to abort the job.

FWIW, there shouldn't be any functional change here, this is only keeping the constraint system from coming up with an incorrect solution that then hits an assert in CSApply when it can't create a valid coercion for that wrong solution.

This seems like the right fix. inouts parameters and their arguments have to be of the same type.


Make file types for scriptdirs adjustable per pipeline

Fixes #8
This could be a simple approach for addressing the issue. The file types would still be the same for all script_dirs within one pipeline. But I would argue that this is good enough.

I think I would also prefer #17 . The only thing is that it is not compatible, right? But this is no problem for us, right?


Added Donation Website Model

#ADD DONATION WEBSITE MODEL
Have you read the Contributing Guidelines ?
Yes, I have read the contributing guidelines.
Description
I have created a desktop website which is a model for donation website integrating payment gateway integration.
Fixes #issue_no 303

Sir, please review it.


Add parameter kernelSize for blur filters.

Add parameter kernelSize for blur filters.
    /**
     * ......
     * @param {number} kernelSize - The kernelSize of the blur filter.Options: 5, 7, 9, 11, 13, 15.
     */
    constructor(strength, quality, resolution, kernelSize)
    {
        kernelSize = kernelSize || 5;
        // ......
    }

related issue : https://github.com/pixijs/pixi.js/issues/3242

The kernelSize is the last argument , it's optional , and default value is 5 ( == current version).
So this PR doesn't break any feature in current version &  any existing project/test case/example/demo.

I know we could use
    constructor(strength, quality, resolution, kernelSize = 5)

for kernelSize to set default value .
But the build  code of this snippet will be poor performance
    function BlurXFilter(strength, quality, resolution) {
        var kernelSize = arguments.length > 3 && arguments[3] !== undefined ? arguments[3] : 5;
        // ......
    }

btw, there's typo in docs just a line above kernelsize, "reoslution", can you fix it please, since we are editing this file?

Done.

@staff0rd , updated.


Include Fluent Validation for models that would benefits

For current work this prioritises CdsConnection, but cover the others while implementing that


Modification of tasks

I wish to make certain modifications to some grunt tasks like wiredep that gonna be specific to my project. Can I do it externally without changing your Gruntfile.js?

My gut says no. You can register external grunt tasks but you still have to modify the Gruntfile.js so you're going to have to merge the two when doing upgrades. Honestly I've found that a source control merge tool like kdiff3 is the easiest way to accomplish this over time.


Project export for iOS takes a very long time (10+ min) due to LTO enabled in 3.2.4 RC 2

Godot version:

3.2.4 rc2
OS/device including version:

iOS Catalina
Issue description:

iOS project export freezes (repeatedly) on Making .xcarchive at 60%. Tried the standard demo Dodge The Creeps - same issue with 3.2.4 rc2, freeze at 60%.
Same projects, same export has no problem with 3.2.4 rc1 and previous versions.
Steps to reproduce:
Export project for iOS with 3.2.4. rc2
Minimal reproduction project:

No clue where to look at but willing to help debugging it.

CC @godotengine/ios

Seeing same issue with 3.2.4rc2 on my project.
Trying to compile directly with Xcode seems to have no effect. Xcode is stuck on Link Godot.
@akien-mga was iOS templates built with LTO support? The last time I got same results was exactly because of this.

Yeah, use_lto (-flto) makes iOS projects noncompileable. But https://github.com/godotengine/godot-build-scripts/blob/6bee8dec2e3bbb64d784cfbd1885239a64c05804/build-ios/build.sh doesn't seem to have anything using this flags. production=yes also isn't used.
I've built lto and non-lto binaries myself and nonlto work fine.

Yeah I have a local commit that enabled production=yes, I forgot to push it. So I'll disable it again for iOS (and I guess we should maybe disable LTO support in the detect.py if it doesn't work?).

I'm not sure exact reason for it to be there, so I didn't touch when I was doing refactoring it just in case. But since it's not working and just breaking stuff, I guess it should be removed.

same, takes up to 10 minutes to do the initial build in Xcode, stays on "Constructiing differed tasks" for ages
using M1 MacBook Pro with 16GB

@oeleo1 @ViktorEvil
You can download iOS binaries from here: https://s3.eu-central-1.wasabisys.com/naithar/godot/godot_templates/ios/3.2.4.b7695f1/list.html
You can simply replace <project_name>.a file in project folder with the file from archive and it should be possible to compile through Xcode without linker taking a lot of time.
In case you want to use .xcframework you will need to manually link it to the Xcode project, but don't forget to set it to Do not embed

@naithar thanks, I noticed you have tvOS builds on there as well, is that a possible export feature in Godot 4?

I've made a PRs to add it to master and 3.2 (https://github.com/godotengine/godot/pull/45829).
You can try using macOS editor build from the link - it has tvOS export built-in.

Mine is freezing sometimes when export and when run on Xcode on my device:

@akien-mga seems like production=yes use_lto=yes doesn't rewrite use_lto flag that gets set with production flag - RC3 binaries still use -flto

Mine is freezing sometimes when export and when run on Xcode on my device:

It's not freezing, it's linking Godot's static library. It takes longer due to the enabled link time optimization flag that was used to build the binary.

Yes, but im with a macbook corei7 6-core and it never compile? I think the flag is -eternal.

It doesn’t matter what flags you are using for Xcode in this case. Godot binary was built using lto.

It doesn’t matter what flags you are using for Xcode in this case. Godot binary was built using lto.
Edit:
I've finished uploading rc3 non-lto binaries in case you need them: link

thanks

Godot version:
3.2.4 rc2
OS/device including version:
iOS Catalina
Issue description:
iOS project export freezes (repeatedly) on Making .xcarchive at 60%. Tried the standard demo Dodge The Creeps - same issue with 3.2.4 rc2, freeze at 60%.
Same projects, same export has no problem with 3.2.4 rc1 and previous versions.
Steps to reproduce:
Export project for iOS with 3.2.4. rc2
Minimal reproduction project:
No clue where to look at but willing to help debugging it.

I've the same issue with RC3 - Export stuck at 60% - Godot (does not react) for around 10 minutes

@MarcusDobler as I previously mentioned here and in your issue, RC2 and RC3 iOS templates was built with lto enabled. This results in longer compilation times everywhere - in editor and in Xcode project.
lto will probably be disabled for iOS in RC4.
For now you can use my iOS templates - they was built on macOS and with disabled lto.


perf: optimize glob_match if the expression does not have any glob symbols

Turns out the _split_on(GLOB_CHARS) function is expensive so it is better to short-circuit before calling that

I thought we would have done this already 🤔
👍


Product slider on Mobile

PHP Version
7.4
Shopware Version
<IP_ADDRESS>
Expected behaviour
The slider on mobile should have correct spacing
Actual behaviour
There is a class
.gallery-slider-row.is-loading {
    height: 430px;
    overflow: hidden;
}

which is not removed from the slider onInit so I get a big white space at the end of the slider

How to reproduce
Open the product page on mobile

Hello,
Within our company roadmap and work capacity, we try to address each bug or improvement request but admit that not each one will be resolved. To continue our culture of honesty and openness, we are closing this issue to focus on our roadmap on behalf of all Shopware users.
If you feel like this issue is still impacting you, please create a new issue and let us know.
Thank you again for your valuable feedback.


Last build is not working on osx

Build v0.1.8 is not working on my mac.
Actually v0.1.6 is also not working so there is not any working build for mac right now.

Without details about your OS and debug.log we can't help you further. Others MacOS users don't have that problem. Did u try with starting with a brand new wallet and restart the client ? Look like it's trouble with your wallet.dat for me.

I tried what you said. Let me find debug.log

first run:
MacBook-Pro-gkucmierz:zcoin gkucmierz$ cat debug.log
2017-02-03 19:52:53

2017-02-03 19:52:53 ZCoin version v<IP_ADDRESS>-unk (2016-12-30 15:14:57 +0100)
2017-02-03 19:52:53 Using OpenSSL version OpenSSL 1.0.2j  26 Sep 2016
2017-02-03 19:52:53 Default data directory /Users/gkucmierz/Library/Application Support/zcoin
2017-02-03 19:52:53 Using data directory /Users/gkucmierz/Library/Application Support/zcoin
2017-02-03 19:52:53 Using at most 125 connections (2560 file descriptors available)
2017-02-03 19:52:53 Using 4 threads for script verification
2017-02-03 19:52:53 init message: Verifying wallet...
2017-02-03 19:52:53 dbenv.open LogDir=/Users/gkucmierz/Library/Application Support/zcoin/database ErrorFile=/Users/gkucmierz/Library/Application Support/zcoin/db.log
2017-02-03 19:52:53 Bound to [::]:8168
2017-02-03 19:52:53 Bound to <IP_ADDRESS>:8168
2017-02-03 19:52:53 init message: Loading block index...
2017-02-03 19:52:53 Wiping LevelDB in /Users/gkucmierz/Library/Application Support/zcoin/blocks/index
2017-02-03 19:52:53 Opening LevelDB in /Users/gkucmierz/Library/Application Support/zcoin/blocks/index
2017-02-03 19:52:53 Opened LevelDB successfully
2017-02-03 19:52:53 Wiping LevelDB in /Users/gkucmierz/Library/Application Support/zcoin/chainstate
2017-02-03 19:52:53 Opening LevelDB in /Users/gkucmierz/Library/Application Support/zcoin/chainstate
2017-02-03 19:52:53 Opened LevelDB successfully
2017-02-03 19:52:53 Initializing databases...
2017-02-03 19:52:53 init message: Verifying blocks...
2017-02-03 19:52:53  block index              50ms
2017-02-03 19:52:53 init message: Loading wallet...
2017-02-03 19:52:53

************************
EXCEPTION: St13runtime_error
CDB() : can't open database file wallet.dat, error -30974
ZCoin in Runaway exception

Is it synchronizing chain now?
I have no error yet.

Ok, there is an error in debug.log, but I cant see dialog after first run.
Like you said it looks like there is a problem with wallet.
Answering future questions I have more than 200gb free space on ssd drive.

@aizensou why you closed it?


 Per user-direction, the job has been aborted.
--------------------------------------------------------------------------
--------------------------------------------------------------------------
mpirun detected that one or more processes exited with non-zero status, thus causing
the job to be terminated. The first process to do so was:

  Process name: [[57249,1],0]
  Exit code:    1
--------------------------------------------------------------------------

As mentioned in 511767e this was a race condition in the calculation of available OpenMP threads. With the commit above I don't get the errors anymore, so I'll merge to the master straight away after double-checking that the Travis runs don't fail either.

BTW, I also thought that maybe this could have been related to the unsolved problem of #53 but that's not the case: I can still reproduce #53 after applying this fix.

This has been solved now and the fix has been merged to the master branch.


Download error: shell only

Hello!

I have a download error that occurs only when I try to download in any shell (Windows, Ubuntu) etc.
I have a fix, which is to add headers to the request that mimic the request sent out by colab (it is not reproducible in colab because the headers appear to be modified by colab itself).
headers = {'User-Agent': 'Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/<IP_ADDRESS> Safari/537.36 Edg/<IP_ADDRESS>'}
response = requests.get(url, headers=headers, stream=True)

However, I'd rather not have to edit thingiverse.py myself, it'd be nice if it worked from the pip install alone without modifications.
Thanks!

Hi @anikimmel, are you able to download more than a few objects before getting the errors again? It seems like there's a limit per user on ability to download.

I haven't tried recently but I was able to download 100 objects when I added headers to it. Without the headers, nothing would download.

@anikimmel Hi! I have tried your header but still get 403 from thingiverse, any updates? Thanks!

Hey, so what I do pretty much daily is I run one of the URLs in my browser the inspect it to see what headers it sends:
So I input https://www.thingiverse.com/download:9006116 to the browser then use the inspect element to see this:

Then I copy all the parameters exactly and put it into my download script.

Hey, so what I do pretty much daily is I run one of the URLs in my browser the inspect it to see what headers it sends:
So I input https://www.thingiverse.com/download:9006116 to the browser then use the inspect element to see this:

Then I copy all the parameters exactly and put it into my download script. It works for me, but it seems like I have to update it every day.

Hi, @anikimmel ,
By 'all the parameters', do you mean only the 'User-Agent' field only, or all others including 'Cookie', 'Sec-Ch-Ua', 'Sec-Ch-Ua-Mobile', etc? Thanks!

I put in everything from sec-ch-ua all the way down to user-agent. IDK it seems to work, I think it tricks the site into thinking it is coming from a web browser and not a shell script.


Can't run lime rebuild mac

I'm on OS X 10.11.6 and I have the latest from the develop branch of lime and I get an error when I try running lime rebuild mac It says that I need OS X 10.6 or greater.
The line that is stops on is in SDL_platform.h around line 86
#if MAC_OS_X_VERSION_MIN_REQUIRED < 1060
# error SDL for Mac OS X only supports deploying on 10.6 and above.
#endif

The naming doesn't seem to support going up to 11,
does it work if you change 1060 with MAC_OS_X_VERSION_10_6?

We should be setting the minimum version here:
https://github.com/openfl/lime/commit/6442d54787b252d7d57840af358961692ffeaacf
Perhaps you could try <error value="Already set: ${MACOSX_DEPLOYMENT_TARGET}" if="MACOSX_DEPLOYMENT_TARGET" /> in Lime's include.xml (before this line) to see if you have this set on your system already as a different value

Here is the full error I'm getting.
13:31 $ lime rebuild mac
 - Compile : src/backend/sdl/SDLApplication.cpp
 - Compile : src/backend/sdl/SDLRenderer.cpp
 - Compiling group 'lime' with flags -Iinclude -Ilib/cairo/include -Ilib/cairo/include/configs/mac/ -DLIME_CAIRO -DHAVE_CONFIG_H -DCAIRO_HAS_FT_FONT -Ilib/curl/include/ -DLIME_CURL -DCURL_STATICLIB -Ilib/jpeg/ -DLIME_JPEG -Ilib/freetype/include -DLIME_FREETYPE -Ilib/harfbuzz/src -DLIME_HARFBUZZ -Ilib/lzma/src -DLIME_LZMA -Ilib/nfd/src/include/ -DLIME_NFD -Ilib/ogg/include/ -Ilib/vorbis/include/ -DLIME_OGG -Ilib/openal/include/ -DLIME_OPENAL -DAL_LIBTYPE_STATIC=1 -DAL_ALEXT_PROTOTYPES -DLIME_OPENGL -Ilib/png/ -Ilib/zlib/ -DLIME_PNG -Ilib/sdl/include/ -Ilib/sdl/include/configs/mac/ -DHAVE_LIBC -DLIME_SDL -DLIME_ZLIB -c -fvisibility=hidden -stdlib=libstdc++ -O2 -I/usr/local/lib/haxe/lib/hxcpp/3,3,49/include -DHX_MACOS -m64 -Wno-parentheses -Wno-unused-value -Wno-format-extra-args -DHXCPP_M64 -DHXCPP_VISIT_ALLOCS(haxe) -DHXCPP_API_LEVEL=0(haxe) tags=[haxe,static]
 - Compile : src/backend/sdl/SDLWindow.cpp
 - Compile : src/graphics/opengl/OpenGLBindings.cpp
Error: While running :g++ -Iinclude -Ilib/cairo/include -Ilib/cairo/include/configs/mac/ -DLIME_CAIRO -DHAVE_CONFIG_H -DCAIRO_HAS_FT_FONT -Ilib/curl/include/ -DLIME_CURL -DCURL_STATICLIB -Ilib/jpeg/ -DLIME_JPEG -Ilib/freetype/include -DLIME_FREETYPE -Ilib/harfbuzz/src -DLIME_HARFBUZZ -Ilib/lzma/src -DLIME_LZMA -Ilib/nfd/src/include/ -DLIME_NFD -Ilib/ogg/include/ -Ilib/vorbis/include/ -DLIME_OGG -Ilib/openal/include/ -DLIME_OPENAL -DAL_LIBTYPE_STATIC=1 -DAL_ALEXT_PROTOTYPES -DLIME_OPENGL -Ilib/png/ -Ilib/zlib/ -DLIME_PNG -Ilib/sdl/include/ -Ilib/sdl/include/configs/mac/ -DHAVE_LIBC -DLIME_SDL -DLIME_ZLIB -c -fvisibility=hidden -stdlib=libstdc++ -O2 -I/usr/local/lib/haxe/lib/hxcpp/3,3,49/include -DHX_MACOS -m64 -Wno-parentheses -Wno-unused-value -Wno-format-extra-args -DHXCPP_M64 -DHXCPP_VISIT_ALLOCS -DHXCPP_API_LEVEL=0 -x c++ -frtti -Wno-invalid-offsetof ./src/backend/sdl/SDLWindow.cpp -o/Users/matthew.wallace/Dropbox/dev/haxe/libs/lime/project/obj/darwin64/c6186305_SDLWindow.o
In file included from ./src/backend/sdl/SDLWindow.cpp:1:
In file included from ./src/backend/sdl/SDLWindow.h:5:
In file included from lib/sdl/include/SDL.h:32:
In file included from lib/sdl/include/SDL_main.h:25:
In file included from lib/sdl/include/SDL_stdinc.h:31:
In file included from lib/sdl/include/configs/mac/SDL_config.h:28:
lib/sdl/include/SDL_platform.h:87:3: error: SDL for Mac OS X only supports deploying on 10.6 and above.
# error SDL for Mac OS X only supports deploying on 10.6 and above.
  ^
1 error generated.

Setting a higher deployment target should solve the error, can you tell what the MACOSX_DEPLOYMENT_TARGET is set to?

yes if I set it to 10.7 it fixes the issue.


adding miss "," in log configuration

The configuration is missing a "," before min_level
             log_name: "devops",
             channels: ["OPS", "HEALTH", "STORAGE"]
             min_level: "WARNING"

Thanks @lin-crl , I caught this the same time you did: the fix will be in https://github.com/cockroachdb/docs/pull/16569. Closing this PR as that one has this same fix. Good notice though!!


Update to ggez 0.6.0

Or now 0.7.0. But really, this looks like it's abandoned at this point.

#26 updates ggez to 0.9.0 now. I've started helping maintain ggez so I will also be helping out with goodies now.


Blurred Overlay on BlackBerry

After displaying the overlay on a BlackBerry 10 device and pressing close, the screen remains blurred.
It is possible to still navigate however the whole screen is blurred and unreadable.
Mozilla/5.0 (BB10; Touch) AppleWebKit/537.35+ (KHTML, like Gecko) Version/<IP_ADDRESS>3 Mobile Safari/537.35+

Duplicate of #152


beacon: persist bootstrap beacon for epoch 2

Motivation

Closes #3073

Changes

move all mocks to one interface.go file
make beacons store calculated beacon by target epoch
persist bootstrap beacon to db

Test Plan

unit tests
DevOps Notes

[x] This PR does not require configuration changes (e.g., environment variables, GitHub secrets, VM resources)
[x] This PR does not affect public APIs
[x] This PR does not rely on a new version of external services (PoET, elasticsearch, etc.)
[x] This PR does not make changes to log messages (which monitoring infrastructure may rely on)

bors try

bors try

bors merge


use folders with index.html

On gitlab pages (and maybe github pages too) if I have a page that is routed at /about react-snapshot makes a about.html, which doesn't resolve to /about. It'd be neat to have an option to make about/index.html, so it routes correctly. If there is interest, I'd be happy to make a PR.

@konsumer I think this is probably not a problem with this library but with your react-router configuration. I do not completely remember how I did this but you can just configure react-router for example to take /about/ routes as well as /about routes which will generate /about/index.html as well.
Anyways, having about.html instead of /about/index.html can make a lot of sense, when hosting on static hosting services such as AWS S3. When using /about/index.html structure you will always have the trailing slash on your websites routes, because there is no way to redirect this without getting a 302 redirect, which is not very SEO friendly.
The recommended way of achieving /about to resolve to /about.html (At least for AWS S3 hosting) is to just cut away the .html. The mime type of the file is still text/html so it will work just as well without the file extension.
In your build pipeline you could do something like:
for fl in $(ls  build/ --recursive | grep "\.html" | sed -e 's/^[-0-9]\{10\} [\:0-9]\{8\} * [0-9]* //');do mv --content-type="text/html" build/$fl build/${fl/\.html/};done

Hope that helps as a workaround?

I think this is probably not a problem with this library but with your react-router configuration. I do not completely remember how I did this but you can just configure react-router for example to take /about/ routes as well as /about routes which will generate /about/index.html as well.

When I make this route:
        <BrowserRouter>
          <Fragment>
            <Link to='/'>Home</Link>
            <Link to='/about'>About</Link>
            <Switch>
              <Route exact path='/' component={PageHome} />
              <Route exact path='/about' component={PageAbout} />
              <Route exact path='/about/' component={PageAbout} />
            </Switch>
          </Fragment>
        </BrowserRouter>

it only generates about.html. Is there a missing option somewhere? More than that, I'd rather not specify what is essentially the same route, twice.
To test out how gitlab-pages handles trailing slashes, I make this on pages. As you can see it works fine, with no redirects. In my gitlab-ci file, I just copy it manually.
I think all 3 styles would be useful (output to {name} for AWS, output to {name}/index.html for gitlab and others that use index.html like this, and current style: {name}.html.) I could totally write a bash script to fix it up after, but it would be a simple PR to add the option directly, for all 3, if there is interest.

I ended up just making a PR for a rudimentary template system, so you can use any style you like (including the gitlab-friendly and s3-friendly style.)

@konsumer
Isn't that a server problem?
I had that issue and solved it simply by:
app.get('*', (req, res) => {
   res.sendFile(path.join(__dirname + '/client/build' + req.path + '.html'));
})

It just goes after the name a sends back the appropriate html file.
In the SPA itself that should not be a issue, react router takes care of it.

I don't have too much control over how gitlab and s3 serve static files. I can probly configure them both to work some other way, but my fork (in the PR) does that work in a better way, in my opinion, in that it just generates the right structure by simple config (and by default generates the old structure.) This issues is pretty old, and I stopped using this tool, in favor of other more mature & maintained stuff.

I got around this by simply doing
<Route path="/about.html" ... />

@danvoyce that changes the URL, though. I still think my PR is better. It defaults to current behavior, but adds an option to output files however you like.


Shadow Property callback

Is it possible to add support for a callback to get the value of shadow property instead of using the EF change tracking?
Or away to set a default value.

Not sure if I understand the issue.
There is config SetOutputIdentity that when set to true Ops will return values from Db.


added the solution for 1351 Count Negative in a sorted array matrix in python

Pull Request Template
What have you Changed(must)
Write here what you have changed in the codebase
Issue no.(must) - #1303
Pr will be close and marked as spam. If issue number not found or issue was assigned to someone else.
Marking as spam can block your account from HacktoberFest.
Self Check(Tick After Making pull Request)

[x] This issue was assigned to me if not it will be marked as spam.
[x] My file is in the proper folder
[x] I am following clean code and Documentation.
[x] I have added the title and what program will do first in the file
[x] I have named the file as (Problem #). (Problem Title(in Camel Case)).(extension)
ex. 2. AddToNumbers.py

README - How to Contribute

Im sorry, the previous file which I gave for PR also got committed here too
Am I supposed to remove those file, How do I remove those file

To remove the files you can go to the files changes tab and individually edit and delete each file.

Which is the Extra file?

1436 or 1351? And what is the PR # which got merged.

I gave merge request for previous issue that also got commit in this commit

What is the issue number Mention it here i'll look into it.

1436

there are 3 commits here only 1 was supposed to be

@PraneshUlleri You can mention multiple issues in the same PR, if you've been assigned to them.


Add Create .linr command

What problem did you solve?
Close #712
Add a simple command that simply calls the lintr::use_lintr function that will be added in lintr 3.0.0.
(If you have)Screenshot
(If you do not have screenshot) How can I check this pull request?
Select "Create .linr to the workspace" from the command palette, with the development version of lintr package installed.

I think now that we are moving toward more file creation functions, after this is merged we should look at relocating the files to a dedicated folder

Currently, a .lintr is created silently and nothing happens when it is created.
Does it make sense to open the lintr file once it is created?
For example, we could capture the path of the created .lintr
normalizePath(lintr::use_lintr())

and open it in vscode when the background process is finished.

Does it make sense to open the lintr file once it is created?

I think it maybe a bit noisy.
The remote-containers.createDevContainerFile command that adds the devcontainer definition files to the project is the vscode command that I often use to add files, but this also does not open the file after it is added.

Does it make sense to open the lintr file once it is created?

I think it maybe a bit noisy. The remote-containers.createDevContainerFile command that adds the devcontainer definition files to the project is the vscode command that I often use to add files, but this also does not open the file after it is added.

OK sounds reasonable. Let's keep it silent for now.


fix: Removed Project and Org ApiKey Tests

Describe your changes
Comment Triggers

PR Check triggers

Build: trigger build
Sub Category Field Check: trigger subcategoryfieldcheck
gitleaks: trigger gitleaks

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.


Latest release not working throws System.IO.IOException

Hi I just came across your project because I need to extract my GT6 volume. I downloaded the latest release 5.0.0 and tried unpacking the GT6.VOL using GTToolsSharp.exe unpack -i GT.VOL -o extracted. It generated the default keys.json and on the second time running this command I'll get this exception every time:
`...GTToolsSharp>GTToolsSharp.exe unpack -i GT.VOL -o extracted
-- GTToolsSharp 5.0.0 - (c) Nenkai#9075, ported from flatz's gttool --
Unhandled exception. System.TypeInitializationException: The type initializer for 'GTToolsSharp.Program' threw an exception.
---> System.IO.IOException: The process cannot access the file 'D:\Save\PS3\Tools\GTToolsSharp\log.txt' because it is being used by another process.
at System.IO.FileStream.ValidateFileHandle(SafeFileHandle fileHandle)
at System.IO.FileStream.CreateFileOpenHandle(FileMode mode, FileShare share, FileOptions options)
at System.IO.FileStream..ctor(String path, FileMode mode, FileAccess access, FileShare share, Int32 bufferSize, FileOptions options)
at System.IO.StreamWriter.ValidateArgsAndOpenPath(String path, Boolean append, Encoding encoding, Int32 bufferSize)
at System.IO.StreamWriter..ctor(String path)
at GTToolsSharp.Program..cctor()
--- End of inner exception stack trace ---
at GTToolsSharp.Program.Unpack(UnpackVerbs options)
at CommandLine.ParserResultExtensions.WithParsed[T](ParserResult 1 result, Action 1 action)
at GTToolsSharp.Program.Main(String[] args)
at GTToolsSharp.Program.(String[] args)`
Checked if any other process is conflicting but couldn't find anything. Tried the same procedure with the previous release 4.0.6 and it worked just fine got all the files extracted. Btw I'm using the EU Version of GT6 if that matters (BCES01893).
Just wanted to let you know and thank you for your work.

Should be fixed with 20cd66d20df3226370bb9595175e3152d4ecbbcd (5.1.0)
Thanks for the report.


Scrolling

Issue Type: Bug
When i do alt-tab and back to visual studio code, then scrolling my opened file, the position always jump to end of file then i should search scrolling back to last position
VS Code version: Code 1.33.1 (51b0b28134d51361cf996d2f0a1c698247aeabd8, 2019-04-11T08:20:22.771Z)
OS version: Linux x64 4.15.0-48-generic

System Info

Item
Value

CPUs
AMD Ryzen 7 1800X Eight-Core Processor (16 x 1828)

GPU Status
2d_canvas: enabledchecker_imaging: disabled_offflash_3d: enabledflash_stage3d: enabledflash_stage3d_baseline: enabledgpu_compositing: enabledmultiple_raster_threads: enabled_onnative_gpu_memory_buffers: disabled_softwarerasterization: disabled_softwaresurface_synchronization: enabled_onvideo_decode: unavailable_offwebgl: enabledwebgl2: enabled

Load (avg)
0, 0, 0

Memory (System)
31.41GB (21.09GB free)

Process Argv
/tmp/fz3temp-2/User.php

Screen Reader
no

VM
67%

Extensions (3)

Extension
Author (truncated)
Version

anaconda-extension-pack
ms-
1.0.1

python
ms-
2019.4.11987

vscode-yaml
red
0.4.0

Does this happen with all file types? Do you use format on type? Does this reproduce with latest insiders?

no actionable information provided

bug closed, but problem not resolved?

Let's track in #28795


2-step Verification Compatability

Does not appear to be compatible with Google 2-step Verification. Would love to use it, if this feature is possible to add.

Maybe duplicate of #139

confirmed duplicate. the solution for this is in #139


Upgrade to Solana v1.18

Problem
sys is still using 1.17 crates, even though 2.0 is about to hit mainnet.
Summary of changes

7489fbd7f0f22722f4a8543ba97b2ff2ec63fe77: It was a big change to upgrade to v2.0 directly, so only upgrade to v1.18 for now. During the upgrade to v2.0, the calls to get_stake_activation need to updated to use the client-side helper: https://github.com/anza-xyz/solana-rpc-client-extensions -- I can take care of that as follow-up work.
1a53669578f4bc665bd493b001555e7b63d0dc42: Remove the direct dependency on solana_vote_program as mentioned in one of the comments
5e2ea36b645df9cac5b45095da6fd888e8384c96: since the get_fees RPC method was removed, I removed its usage, opting for get_fee_for_message instead <-- this is the most important change, since sys fails against mainnet right now because of this

Awesome, thanks!

Some clippy stuff in dependencies, gonna merge on red though

I had initially fixed that too, but didn't want to add too much in the PR -- you just need to add test and client features in Cargo.toml


SPV3.2 Loader GUI

For any masochist who's curious to inspect the GUI, the rabbit hole is this way:
https://cgit.n2.network/spv3.gui/
THE SPV3 GUI
============

This repository contains the source for the SPV3 GUI, which is a simple
front-end to the SPV3 CLI. The CLI contains the main logic for the
entire loader, and the GUI merely serves to hide all of that away behind
a pretty interface.

One would argue that the logic should be extracted into a shared
library, rather than have the GUI simply call the CLI; however, the GUI
is an after-thought and is designed to be as simple as possible. In
essence, it just calls the CLI with the relevant arguments.

The distribution is done in the same fashion as the CLI -- compiled binaries can be found here:
https://dist.n2.network/spv3.gui/

Professional UX and UI planning, prototyping and development went into developing it:


how to center the text and the picture

I have add the slick in my website. but the texts are not centered and the error is missing too.
Could you please give me some suggestions.

select image using developer tool and add this css  to image tag of this particular div ony.
classname > img{
margin: 0 auto;
}
if not work then add the important


Refactor MaxScl parsing

The current code is an absolute mess, even though it "works".
There is a lot of unexpected behavior, including but not limited to:

Differences when AverageRGB is high.
Differences when TargetedSystemDisplayMaximumLuminance is high (and equal to 8192).
Differences depending on previously parsed MaxScl values, whether they are zero, low or high.

Are you talking about version 0.2.7 ?

This issue is not related to the usage of the parser, only the quality and maintainability of the code.

I've looked into fixing this but the behavior is still very inconsistent, no matter how the data is read.

If anyone's interesting in helping debug this, here's some test code that tries to reproduce x265's output.
hdr10plus_debug.zip

Traced back to the source in x265:
if (bytes >= 2 && !out[bytes - 2] && !out[bytes - 1] && inBytes[i] <= 0x03)
{
    /* inject 0x03 to prevent emulating a start code */
    out[bytes++] = 3;
}


Error when processing file.

I have loaded several pdf reports.  Some of them, Ambar can't parse.
But he don't delete malformed files from queue.
After some time, Ambar try to parse them, again.
2017-04-07 13:42:17.512: [error] [p0] error parsing //default/cisco's talos intelligence group blog_ the _wizzards_ of adware.pdf 'utf-8' codec can't decode byte 0xed in position 1605: invalid continuation byte 2017-04-07 13:42:19.413: [verbose] [p0] task received 7609b6aac3bff0e4bd067824dfc2925100797d2e72a1712bcf3edb1266660131 2017-04-07 13:42:19.450: [verbose] [p0] file content received //default/cisco's talos intelligence group blog_ threat round-up for the week of mar 6 - mar 10.pdf 2017-04-07 13:42:19.458: [verbose] [p0] parsing //default/cisco's talos intelligence group blog_ threat round-up for the week of mar 6 - mar 10.pdf 2017-04-07 13:42:19.778: [error] [p0] error parsing //default/cisco's talos intelligence group blog_ threat round-up for the week of mar 6 - mar 10.pdf 'utf-8' codec can't decode byte 0xed in position 1075: invalid continuation byte 2017-04-07 13:42:33.929: [verbose] [p0] task received e0d13847f3079e244c9b4503635d59f0ce8840f37d410e9d6d8a0160895eb62a 2017-04-07 13:42:33.966: [verbose] [p0] file content received //default/cisco's talos intelligence group blog_ threat spotlight_ holiday greetings from pro pos – is your payment card data someone else’s christmas present_.pdf 2017-04-07 13:42:33.974: [verbose] [p0] parsing //default/cisco's talos intelligence group blog_ threat spotlight_ holiday greetings from pro pos – is your payment card data someone else’s christmas present_.pdf 2017-04-07 13:42:34.184: [error] [p0] error parsing //default/cisco's talos intelligence group blog_ threat spotlight_ holiday greetings from pro pos – is your payment card data someone else’s christmas present_.pdf 'utf-8' codec can't decode byte 0xed in position 1307: invalid continuation byte 2017-04-07 13:42:34.200: [verbose] [p0] task received 7c8c073ba712de285d29877e3d01de448f6d7f0c0a4b061f700edfac0fa4d67b 2017-04-07 13:42:34.223: [verbose] [p0] file content received //default/cisco's talos intelligence group blog_ threat spotlight_ dyre_dyreza_ an analysis to discover the dga.pdf 2017-04-07 13:42:34.239: [verbose] [p0] parsing //default/cisco's talos intelligence group blog_ threat spotlight_ dyre_dyreza_ an analysis to discover the dga.pdf 2017-04-07 13:42:34.495: [error] [p0] error parsing //default/cisco's talos intelligence group blog_ threat spotlight_ dyre_dyreza_ an analysis to discover the dga.pdf 'utf-8' codec can't decode byte 0xed in position 1697: invalid continuation byte 2017-04-07 13:42:35.406: [verbose] [p0] task received 073d9dde2cc486865db972a40f077660904439f0a00195bac24e33a3ebeecf72 2017-04-07 13:42:35.427: [verbose] [p0] file content received //default/cisco's talos intelligence group blog_ vulnerability deep dive - ichitaro office excel file code execution vulnerability.pdf 2017-04-07 13:42:35.436: [verbose] [p0] parsing //default/cisco's talos intelligence group blog_ vulnerability deep dive - ichitaro office excel file code execution vulnerability.pdf 2017-04-07 13:42:35.615: [error] [p0] error parsing //default/cisco's talos intelligence group blog_ vulnerability deep dive - ichitaro office excel file code execution vulnerability.pdf 'utf-8' codec can't decode byte 0xed in position 222: invalid continuation byte 2017-04-07 13:42:38.804: [verbose] [p0] task received 7ecec8cba21bd5e0b0ee831045de5815a479f7dd20ccaaeb5ce48c30869f93ed 2017-04-07 13:42:38.840: [verbose] [p0] file content received //default/cisco's talos intelligence group blog_ threat spotlight_ teslacrypt - decrypt it yourself.pdf 2017-04-07 13:42:38.853: [verbose] [p0] parsing //default/cisco's talos intelligence group blog_ threat spotlight_ teslacrypt - decrypt it yourself.pdf 2017-04-07 13:42:39.089: [error] [p0] error parsing //default/cisco's talos intelligence group blog_ threat spotlight_ teslacrypt - decrypt it yourself.pdf 'utf-8' codec can't decode byte 0xed in position 809: invalid continuation byte 2017-04-07 13:42:41.151: [verbose] [p0] task received 7fdb77feff9667babbe327a33f27db33c28b057c7032134a9b033b5ade09904b 2017-04-07 13:42:41.183: [verbose] [p0] file content received //default/cisco's talos intelligence group blog_ want tofsee my pictures_ a botnet gets aggressive.pdf 2017-04-07 13:42:41.194: [verbose] [p0] parsing //default/cisco's talos intelligence group blog_ want tofsee my pictures_ a botnet gets aggressive.pdf 2017-04-07 13:42:41.404: [error] [p0] error parsing //default/cisco's talos intelligence group blog_ want tofsee my pictures_ a botnet gets aggressive.pdf 'utf-8' codec can't decode byte 0xed in position 544: invalid continuation byte 2017-04-07 13:42:43.720: [verbose] [p0] task received 8efde018b5242043d68dba573d67456712c74802c7b2ba64465793ec7daad1ff 2017-04-07 13:42:43.743: [verbose] [p0] file content received //default/cisco's talos intelligence group blog_ your files are encrypted with a _windows 10 upgrade_.pdf 2017-04-07 13:42:43.749: [verbose] [p0] parsing //default/cisco's talos intelligence group blog_ your files are encrypted with a _windows 10 upgrade_.pdf 2017-04-07 13:42:44.011: [error] [p0] error parsing //default/cisco's talos intelligence group blog_ your files are encrypted with a _windows 10 upgrade_.pdf

Seems, like it's malformed PDF's or maybe encrypted. Ambar reject such files to the dead queue, it'll be live here. It'll not harm or somehow slow-down the Ambar perfomance. Just ignore it.
Can you please share some of these files with us?

https://1drv.ms/f/s!AtSJqJWfRSn2uRcTsS24r3JirUww

Fixed. Update please.

thanks, all fine


Reg Cox

Please edit the title of the Pull Request to: "Initiate EasyCLA - "
This is a trivial test PR to initiate an EasyCLA check/signing process.
It is not intended to get merged.

@RegCox if there are challenges with EasyCLA you can always contact<EMAIL_ADDRESS>or submit a support request ticket as suggested in https://github.com/camaraproject/EasyCLA/pull/60#issuecomment-2506460673

It appears that you've been assigned as the CLA Manager for GSMA. However, GSMA has not yet signed the CCLA agreement, which is why the code cannot be merged. If you need any assistance, please open a ticket at<EMAIL_ADDRESS>


build for multiple target devices at once

Maybe it's just not clear from the documentation, but I can't tell how you can build for multiple target devices at one time.

Currently yotta just builds for one target at a time. You could easily script this by running multip retargets and builds though.
Something like
yotta target T1
yotta build
yotta target T2
yotta build

yeah, that is what i'm doing right now, except as:
$ yotta -t T1 build
$ yotta -t T2 build

yotta should work just fine if use your shell to run the commands in parallel:
yt -t T1 build &
yt -t T2 build

I'm not sure this is really something that should be internal to yotta though, your shell already has a well-built UI for managing multiple concurrent tasks.


[CSL-2369] Fix wallet-new/spec/swagger.json: openBinaryFile: does not exist

https://iohk.myjetbrains.com/youtrack/issue/CSL-2369

This page was not found

:/

Whoops, this is supposed to be CSL-2631


Release 3.2.2

Have done the quickstart + record and file creation/search and it is working. In addition, there is ongoing work on fixing the tutorials.

https://invenio.readthedocs.io/en/latest/quickstart/quickstart.html ✅
https://invenio.readthedocs.io/en/latest/quickstart/crud-operations.html#crud-operations ✅

Build is breaking for two reasons:
1-  Cannot find invenio-app 1.2.6 But it does exists in PyPi
ERROR: Could not find a version that satisfies the requirement invenio-app==1.2.6<1.3.0 (from -r .travis-lowest-requirements.txt (line 7)) (from versions: 1.0.0a1, 1.0.0a2, 1.0.0a3, 1.0.0b1, 1.0.0b2, 1.0.0, 1.0.1, 1.0.2, 1.0.3, 1.0.4, 1.0.5, 1.0.6, 1.1.0, 1.1.1, 1.2.0, 1.2.1, 1.2.2, 1.2.3, 1.2.5, 1.2.6)
1026ERROR: No matching distribution found for invenio-app==1.2.6<1.3.0 (from -r .travis-lowest-requirements.txt (line 7))

2- Cannot find CSV serializer in invenio-records-rest docs. I can see it has disappeared from the docs. Nonetheless, the latest build passed and seemed to be fine.
/home/travis/build/inveniosoftware/invenio/docs/releases/v3.2.0.rst:159:py:class reference target not found: invenio_records_rest.serializers.csv.CSVSerializer

@lnielsen Any ideas?


Reproduce the result in paper

Hi! Thank you for the work!
I was trying to reproduce the TABLE II you illustrated in the paper. Especially the predator capture prey scenario in TABLE III. However, i fail to obtain the similar result maybe due to the hyperparameter setting.
Could you please provide the full script of

environment config.yaml
epymarl default.yaml
gymma.yaml
especially VDN.yaml (as in it is the best result)

Thank you and looking forward to hear back from you!
Best regards

Hello,
For VDN on predator capture prey, this was the config.json for VDN final that we logged which should contain the combination of all yaml files. Please let me know if you need anything else!
{
  "action_selector": "epsilon_greedy",
  "add_value_last_step": true,
  "agent": "rnn",
  "agent_output_type": "q",
  "batch_size": 32,
  "batch_size_run": 1,
  "buffer_cpu_only": true,
  "buffer_size": 5000,
  "checkpoint_path": "",
  "double_q": true,
  "env": "gymma",
  "env_args": {
    "key": "robotarium_gym:PredatorCapturePrey-v0",
    "pretrained_wrapper": null,
    "time_limit": 200
  },
  "epsilon_anneal_time": 50000,
  "epsilon_finish": 0.05,
  "epsilon_start": 1.0,
  "evaluate": false,
  "evaluation_epsilon": 0.0,
  "gamma": 0.99,
  "grad_norm_clip": 10,
  "hidden_dim": 128,
  "hypergroup": null,
  "label": "default_label",
  "learner": "q_learner",
  "learner_log_interval": 10000,
  "load_step": 0,
  "local_results_path": "results",
  "log_interval": 50000,
  "lr": 0.0003,
  "mac": "basic_mac",
  "mixer": "vdn",
  "name": "vdn_final",
  "obs_agent_id": true,
  "obs_individual_obs": false,
  "obs_last_action": false,
  "optim_alpha": 0.99,
  "optim_eps": 1e-05,
  "render": false,
  "repeat_id": 1,
  "runner": "episode",
  "runner_log_interval": 10000,
  "save_model": true,
  "save_model_interval": 50000,
  "save_replay": false,
  "seed": 920962285,
  "standardise_returns": false,
  "standardise_rewards": false,
  "t_max": 5050000,
  "target_update_interval_or_tau": 200,
  "test_greedy": true,
  "test_interval": 50000,
  "test_nepisode": 100,
  "use_cuda": true,
  "use_rnn": true,
  "use_tensorboard": false
}

Thank you for the response!
I have another question. When i run the epymarl/src/main.py with the provided hyperparameters, for 5050000 timesteps. It occurs that in the middle of the training, at around 600000+ steps, the computer is crashed/freezed and the training process is stopped. I thought it was my computer's issue at first but afterwards i tried on 2 different desktops which remains the same issue, stopped or crashed at 60w+ and 80w+ steps respectively.
For example:
[INFO 11:39:20] my_main t_env: 600925 / 5050000
[INFO 11:39:20] my_main Estimated time left: 10 hours, 37 minutes, 40 seconds. Time passed: 1 hours, 4 minutes, 34 seconds
[INFO 11:39:30] my_main Saving models to results/models/vdn_seed25874876_robotarium_gym:PredatorCapturePrey-v0_2023-09-12 10:34:44.042057/600925
[INFO 11:40:08] my_main Recent Stats | t_env:     605475 | Episode:     4515
ep_length_mean:          115.9117	epsilon:                   0.0500	grad_norm:                 2.6975	loss:                      1.4832
q_taken_mean:             -0.8722	return_mean:             -14.1051	return_std:               26.3204	target_mean:              -0.8896
td_error_abs:              0.2769	test_ep_length_mean:     124.5600	test_return_mean:        -17.2800	test_return_std:          24.2796
Killed
Do you have any suggestions on how to debug this issue?
This is my run.json file:
{
"artifacts": [],
"command": "my_main",
"experiment": {
"base_dir": "/home/tsaisplus/Codes/MARBLER/epymarl/src",
"dependencies": [
"numpy==1.19.5",
"PyYAML==5.3.1",
"sacred==0.8.4",
"torch==2.0.0+cu118"
],
"mainfile": "main.py",
"name": "pymarl",
"repositories": [
{
"commit": "d82fc82823081346995081c41d370c931440b283",
"dirty": true,
"url": "https://github.com/uoe-agents/epymarl.git"
},
{
"commit": "d82fc82823081346995081c41d370c931440b283",
"dirty": true,
"url": "https://github.com/uoe-agents/epymarl.git"
},
{
"commit": "d82fc82823081346995081c41d370c931440b283",
"dirty": true,
"url": "https://github.com/uoe-agents/epymarl.git"
}
],
"sources": [
[
"main.py",
"_sources/main_f135a1dbadecdb77ab6ea3ee221e22a9.py"
],
[
"run.py",
"_sources/run_79ab728956cdd749855c86ef08770541.py"
],
[
"utils/logging.py",
"_sources/logging_744201ef94cc2445aea6ad1cdb783e46.py"
]
]
},
"heartbeat": "2023-09-12T04:18:02.383215",
"host": {
"ENV": {},
"cpu": "12th Gen Intel(R) Core(TM) i9-12900K",
"gpus": {
"driver_version": "525.125.06",
"gpus": [
{
"model": "NVIDIA GeForce RTX 3070",
"persistence_mode": false,
"total_memory": 8192
}
]
},
"hostname": "XPS-8950",
"os": [
"Linux",
"Linux-6.2.0-32-generic-x86_64-with-glibc2.17"
],
"python_version": "3.8.17"
},
"meta": {
"command": "my_main",
"config_updates": {},
"named_configs": [],
"options": {
"--beat-interval": null,
"--capture": null,
"--comment": null,
"--debug": false,
"--enforce_clean": false,
"--file_storage": null,
"--force": false,
"--help": false,
"--id": null,
"--loglevel": null,
"--mongo_db": null,
"--name": null,
"--pdb": false,
"--print-config": false,
"--priority": null,
"--queue": false,
"--s3": null,
"--sql": null,
"--tiny_db": null,
"--unobserved": false,
"COMMAND": null,
"UPDATE": [],
"help": false,
"with": false
}
},
"resources": [],
"result": null,
"start_time": "2023-09-12T02:34:44.038201",
"status": "RUNNING"
}
Thank you for your help!

The most recent push to the Robotarium's simulator essentially causes a memory leak when training. If you revert it to commit 6bb184e (the second more recent commit) it should work. I have updated the installation instructions in the README to reflect this.


Ability to use it as command line

For example: ts-graphql-plugin ...some_options> src/**/*.ts
Must have for CI/CD

Do you want to validate on CI/CD? I’ve added CLI feature. Pls check it out.

Thanks! :santa:


Address sustainability within the planetary limits as an issue

Notifying @michelemartone

some starting points

scientists for future: https://doi.org/10.1126/science.aax3807
planetary boundaries: https://doi.org/10.1126/sciadv.adh2458
safe and just earth system boundaries, doughnut economy
wikipedia on green computing: https://en.wikipedia.org/wiki/Green_computing
green 500: https://www.top500.org/lists/green500/

Digital science requires physical resources such as hardware and energy. An RSE needs to therefore also be aware of and consider planetary boundaries.

The last two decades saw the limits in the attainable miniaturization of transistor technology approaching, and top chip clock frequency mostly settled. [1]
Nevertheless, the perception in the popular culture remains fairly unaware of that, and a misleading belief into limitless growth of computing capabilities (storage, computing power, transmission speed) is still widespread.
A practical consequence of this is an ever-growing demand of resources to cover the expanded need for storage and processing, with no clear deceleration in sight (e.g. the IEA estimates a doubling in data centres energy consumption from 2024 to 2026 [2]).
At the same time, current science is well aware of several "planetary boundaries" being trespassed consequently to human activities [3], with this (computation and information) accounting for a non negligible fraction [2].
A reorientation of consumption into sustainable rates is being strived with great difficulty, despite repeated appeals from the sectors of society most knowledgeable on the matter [4].
In this scenario, RSEs have a responsibility, for instance when choosing computationally adequate approaches (e.g. recognizing where a well-proved statistical method may do well instead of a power-hungry AI model, or configuring a test pipeline to minimize redundancy), and embracing data frugality measures (e.g. recognizing "high enough" resolutions when sampling data for processing or storage),
If past computational solutions were "frugal" because of technological limits, future ones should tend to that by virtue of an awareness of what "adequate" solutions may be.
To be helpful in these regards, RSEs may need basic skills in extrapolating energy, storage, and computational needs, resorting to expert knowledge for the details, and within regulatory frameworks yet to come.
[1]  http://www.gotw.ca/publications/concurrency-ddj.htm
[2]  https://www.iea.org/reports/electricity-2024
[3]  https://doi.org/10.1126/sciadv.adh2458 ()
[4]  https://doi.org/10.1126/science.aax3807

Hi @CaptainSifff. I've put it in a small section before Emerging Challenges. IMHO it's OK as standalone. Initial thoughts were of having it into an Values section, but that section is rather on adhering to existing rules or best practices, and much into delivering quality. Here the focus is on challenges of a larger scope, and to a large extent not yet fully tackled by society. @mhagdorn will do a quality check pass over this.

we are right on topic
https://www.heise.de/news/Energiehungrige-Sprachmodelle-Ruf-nach-Leitplanken-fuer-gruene-KI-9682041.html

find references on how to calculate footprint to teach and learn website

added issue https://github.com/DE-RSE/learn-and-teach/issues/22 to learning and teaching repo


Navi Carbon Querylogger

Description
Added QueryLogging Implementation for Carbon in Navi.
Proposed Changes
In package/webservice, the following files were added to reflect this change:

CarbonQueryLogger.kt: Has the implementation for Query Logging and overrides the QueryLogger interface from Elide.
QueryStatus.kt: Enum class with all the possible query statuses that a query could have when an response is received from Elide
QueryStats.kt: Our querylogging entity class.

License
I confirm that this contribution is made under an MIT license and that I have the authority necessary to make this contribution on behalf of its copyright owner.

Hey @dvarshney1 .  Do you plan on completing this PR or should we assign someone to wrap it up?

Hi Aaron, I plan on finishing this. Got a bit busy with school work but I will work on it during this weekend. I will let you know when this is done. @aklish

Hey @dvarshney1, happy new year! Can you please rebase your PR?

Hey @dvarshney1, happy new year! Can you please rebase your PR?

Closing for now

Closing for now


[example: user_input] Assure the cursor responds immediatel when hitt…

…ing backspace
This was discovered with the termion backend in alacritty on OSX.

Nice catch. Thanks for taking the time to look into this.