Add gRPC / HTTP basic metrics, throughput, latency and sizes

In this PR,

add HTTP / gRPC middleware to record endpoint metrics
update go modules

@mostynb

Are the module upgrades required for this to work? If not, could you do that in a separate commit in such a way that each commit still builds OK?
You're right, module upgrades not required I just fixed it. (only is gRPC library to 1.28).
Could you flesh out the commit messages a bit? What are the particular "golden metrics"?
I have updated the commits and README to explain what metrics we add.


change inject to a map

this inject is really just a map

yes...there are a ton of these, but let's kill the ones we find.


Improve documentation YouTube video embedding

Right now the YouTube video embed for the introductory video is statically sized.  Perhaps using the YouTube iframe API we can:

[x] Improve the sizing story - adjust the video player to fit inside the documentation panel based on it's width.

Done


[CS2103T-W10-2] Wishful Shrinking

Wishful Shrinking is a desktop app for managing your diet, keeping track of your on-hand ingredients, recipes, as well as the food you’ve eaten (along with their calories). It is optimized for fast and efficient typers as it uses a Command Line Interface (CLI) with the added beauty of a Graphical User Interface (GUI).

Codecov Report

Merging #27 into master will decrease coverage by 4.66%.
The diff coverage is 75.13%.

@@             Coverage Diff              @@
##             master      #27      +/-   ##
============================================
- Coverage     72.31%   67.64%   -4.67%
- Complexity      400      450      +50
============================================
  Files            70       84      +14
  Lines          1228     1391     +163
  Branches        124      143      +19
============================================
+ Hits            888      941      +53
- Misses          308      402      +94
- Partials         32       48      +16

Impacted Files
Coverage Δ
Complexity Δ

src/main/java/seedu/address/MainApp.java
0.00% <0.00%> (ø)
0.00 <0.00> (ø)

...main/java/seedu/address/commons/core/Messages.java
0.00% <ø> (ø)
0.00 <0.00> (ø)

...ss/logic/commands/exceptions/CommandException.java
50.00% <ø> (-50.00%)
1.00 <0.00> (-1.00)

.../main/java/seedu/address/model/recipe/Address.java
60.00% <ø> (ø)
3.00 <0.00> (?)

...rc/main/java/seedu/address/model/recipe/Email.java
60.00% <ø> (ø)
3.00 <0.00> (?)

src/main/java/seedu/address/model/recipe/Name.java
80.00% <ø> (ø)
6.00 <0.00> (?)

...ecipe/exceptions/DuplicateIngredientException.java
0.00% <0.00%> (ø)
0.00 <0.00> (?)

...recipe/exceptions/IngredientNotFoundException.java
0.00% <0.00%> (ø)
0.00 <0.00> (?)

.../java/seedu/address/model/util/SampleDataUtil.java
0.00% <0.00%> (-20.00%)
0.00 <0.00> (-1.00)

...a/seedu/address/storage/JsonAdaptedIngredient.java
0.00% <0.00%> (ø)
0.00 <0.00> (?)

... and 79 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6389d85...43cf707. Read the comment docs.

Codecov Report

Merging #27 into master will decrease coverage by 4.45%.
The diff coverage is 72.54%.

@@             Coverage Diff              @@
##             master      #27      +/-   ##
============================================
- Coverage     72.31%   67.85%   -4.46%
- Complexity      400      513     +113
============================================
  Files            70       93      +23
  Lines          1228     1649     +421
  Branches        124      177      +53
============================================
+ Hits            888     1119     +231
- Misses          308      462     +154
- Partials         32       68      +36

Impacted Files
Coverage Δ
Complexity Δ

src/main/java/seedu/address/MainApp.java
0.00% <0.00%> (ø)
0.00 <0.00> (ø)

...in/java/seedu/address/commons/core/LogsCenter.java
78.37% <ø> (ø)
10.00 <0.00> (ø)

...main/java/seedu/address/commons/core/Messages.java
0.00% <ø> (ø)
0.00 <0.00> (ø)

...java/seedu/address/logic/commands/ExitCommand.java
100.00% <ø> (ø)
2.00 <0.00> (ø)

...ss/logic/commands/exceptions/CommandException.java
50.00% <ø> (-50.00%)
1.00 <0.00> (-1.00)

...ption/exceptions/ConsumptionNotFoundException.java
0.00% <0.00%> (ø)
0.00 <0.00> (?)

.../main/java/seedu/address/model/recipe/Address.java
60.00% <ø> (ø)
3.00 <0.00> (?)

...rc/main/java/seedu/address/model/recipe/Email.java
60.00% <ø> (ø)
3.00 <0.00> (?)

src/main/java/seedu/address/model/recipe/Name.java
80.00% <ø> (ø)
6.00 <0.00> (?)

...ecipe/exceptions/DuplicateIngredientException.java
0.00% <0.00%> (ø)
0.00 <0.00> (?)

... and 101 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6389d85...7c0783e. Read the comment docs.


test: Move button clicking functions to testUtils

This moves the clickBack, clickCancel, clickNext, getNextButton and verifyCancelButton functions from the tests to testUtils.

Very nice start on the enhanced test utilities idea!
Should we be using the new userEvent.click() for these, as well? Obviously these work fine, but for the sake of consistency it might be a good idea...

@lucasgarfield Good point - updated! Added some async/await for good measure.


chore: package.json updated with scripts

@LostButton, could you check to see if your scripts are in? If they are not, could you add them?

Do we need my scripts?

Do we need my scripts? Cause mine would overlay with the others

We don't need to add yours, as users would never interact directly with the gallery.
They would have to go throw the authentication and repo creation process introduced in #1 first and then successfully upload photos to the repo. We are not quite there yet.
@batunpc, I think it's safe to merge the changes we have committed.

Do we need my scripts? Cause mine would overlay with the others

We don't need to add yours, as users would never interact directly with the gallery. They would have to go throw the authentication and repo creation process introduced in #1 first and then successfully upload photos to the repo. We are not quite there yet.
@batunpc, I think it's safe to merge the changes we have committed.

Okay just wanted to make sure, merging it now !


Xcode 8 won't load plug-ins

plugins has been prohibited by Apple since XCode8, use source editor extensions instead.
Check the useful source editor extensions here. https://github.com/theswiftdev/awesome-xcode-extensions


Update File.exist? syntax

The method File.exists? has been depreciated for a while now and was removed in Ruby 3.2 in favour of File.exist?.

Just realised there is already https://github.com/hugomarquez/ffi-cups/pull/7. Closing this.


Feature/minor improvement2

Minor Improvement:

Use Standard Charset object

Coverage increased (+0.1%) to 78.447% when pulling f5646a388895e5fbda732b05e2d2284e6ccb7898 on arturobernalg:feature/minor_improvement2 into 89399531bef9978fb2ddaf966d20b561b200d7b7 on apache:master.

Not really sure, but isn't this duplicating #51 in some details?

Rebase from master


ViewPager type of item (non-header) does not appear on the screen. Horizontal scrolling functionality does not work.

Hello,
First of all, many thanks for this for this awesome library, it's very smooth and robust. I'm trying to build my solution around SuperSliM and ran into the following issue:
Whenever I use ViewPager type of item (non-header), the ViewPager will not appear on the screen. A simple scroll of pager off the screen and then scroll back on the screen, i.e. invoking onDetachToWindow/ onAttachedToWindow will reveal the pager. However, horizontal pager swiping functionality does not work. I'm using vertical LinearSLM.
in onCreateViewHolder:
View v = LayoutInflater.from(context).inflate(R.layout.gallery_pager, parent, false);
return new CountryViewHolder(v);
in gallery_pager:
<?xml version="1.0" encoding="utf-8"?>
<FrameLayout
    xmlns:android="http://schemas.android.com/apk/res/android"
    android:layout_width="match_parent"
    android:layout_height="wrap_content">

    <android.support.v4.view.ViewPager
        android:layout_width="match_parent"
        android:layout_height="300dp"
        android:background="#f00"
        android:id="@+id/gallery_pager"/>
</FrameLayout>

Here is the link to sample, sample is build off from your example: https://bitbucket.org/dkarmazi/androidsuperslimimpl/src
Any help would be much appreciated.

View pager definitely won't work with superslim v0.4. It should with version5, which you can check out of the version5 branch. Be aware that version5 is massively incomplete. I am back working on it next week.

@TonicArtos, thank you for quick reply! I will definitely check out version5 branch. Do you roughly know the reason why ViewPager won't work with v0.4? Alternatively, would you recommend any specific area of code to look at in version5 that addresses this issue?

In v0.4 there are probably two reasons for the problem with view pager. 1)
Views are measured before they are attached to the view hierarchy. 2) the
implementation sometimes reattaches and detaches views multiple times and
recycler view has some weird behaviour if this happens. Version5 does
neither of these, and is being written (rewritten) to interact with
recycler view as much like the stock layout managers as possible.
On Sat, 28 May 2016, 07:36 dkarmazidkarmazi<EMAIL_ADDRESS>wrote:

@TonicArtos https://github.com/TonicArtos, thank you for quick reply! I
will definitely check out version5 branch. Do you roughly know the reason
why ViewPager won't work with v0.4? Alternatively, would you recommend any
specific area of code to look at in version5 that addresses this issue?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/TonicArtos/SuperSLiM/issues/175#issuecomment-222293350,
or mute the thread
https://github.com/notifications/unsubscribe/AASEzrhjTjc5elDAeEgj0yS9FXgJkXacks5qF-KFgaJpZM4Io4kp
.

@TonicArtos thanks for your comments. I think I have figured out a temp workaround with ViewPagers. The solution is to invoke itemView.requestLayout in OnBindViewHolder via postDelayed, so that we do an extra measure and draw on the view once the view has been attached.
By no means this is a good solution, but rather an inefficient hack to make it working. However, I'm leaving it here just in case someone faces the same problem and needs it to be working asap.
Thanks again for your library and quick turnaround on the issue.

I am having a very weird bug, which only happens if I use the slim LayoutManager for my recyclerview.
I have a viewpager which loads fragments with recyclerviews, each having a spinner.
When i change the fragment then get back to the same one, the spinners don't change their ItemSelected when a user selects an item (if I query what was clicked it does show correctly but the view doesn't update to reflect the new value in the spinner).
This happens only in viewpagers and in that very specific scenario, I have no idea how to report the bug.
It could be that it'll be solved by v5, but i've been holding the project release for a while and I have a deadline :\ any idea about the deadline of v5 release?


Avoid mkForce in nix

Changelog
- description: |
    Avoid `mkForce` in nix
  compatibility: no-api-changes
  type: maintenance

Context
Checklist

[ ] Commit sequence broadly makes sense and commits have useful messages
[ ] The change log section in the PR description has been filled in
[ ] New tests are added if needed and existing tests are updated.  These may include:

golden tests
property tests
roundtrip tests
integration tests
See Runnings tests for more details

[ ] The version bounds in .cabal files are updated
[ ] CI passes. See note on CI.  The following CI checks are required:

[ ] Code is linted with hlint.  See .github/workflows/check-hlint.yml to get the hlint version
[ ] Code is formatted with stylish-haskell.  See .github/workflows/stylish-haskell.yml to get the stylish-haskell version
[ ] Code builds on Linux, MacOS and Windows for ghc-8.10.7 and ghc-9.2.7

[ ] The changelog section in the PR is updated to describe the change
[ ] Self-reviewed the diff

Note on CI
If your PR is from a fork, the necessary CI jobs won't trigger automatically for security reasons.
You will need to get someone with write privileges.  Please contact IOG node developers to do this
for you.

Changelog does not line up with change?
Shouldn't the changelog state the reason for this change?

I am going to have a look at this tomorrow. I spend most of today on input-output-hk/cardano-cli#127 (which is related)

@newhoggy I think we should just roll this into #127

yeah it's done properly in the other PR.


JSON-API updates for 'data' and 'type' attributes. JSON-API Reader.

Two of the most significant changes recently to the JSON-API spec are:

There must now be a top-level key named 'data' containing the primary resource(s). This is instead of the key being names according to the resource type.
Each resource must have an attribute named 'type' in the output.

Also created a new Reader for JSON-API to help deserialize JSON-API formatted data into Yaks resource objects.

You can just push to the same branch again if you want to add some changes to a pull request. no need to close it and open a new one :)

Looks good to me! If you're done with it and once the build finishes I can hit the merge button.

Yeah, all done for these changes. I'm sure there will be more as I come across other parts of the JSON-API specification. Thanks for the clarification on PRs!


CBR-186 - Subscription status in node-info

Description
Now that we have the diffusion layer give us nice information about the status of the underlying node, we can expose this information in the API.
Linked issue
[CBR-186]
Type of change

[ ] 🐞 Bug fix (non-breaking change which fixes an issue)
[x] 🛠 New feature (non-breaking change which adds functionality)
[ ] ⚠ Breaking change (fix or feature that would cause existing functionality to change)
[ ] 🏭 Refactoring that does not change existing functionality but does improve things like code readability, structure etc
[ ] 🔨 New or improved tests for existing code
[ ] ⛑ git-flow chore (backport, hotfix, etc)

Developer checklist

[x] I have read the style guide document, and my code follows the code style of this project.
[x] If my code deals with exceptions, it follows the guidelines.
[x] I have updated any documentation accordingly, if needed. Documentation changes can be reflected in opening a PR on cardanodocs.com, amending the inline Haddock comments, any relevant README file or one of the document listed in the docs directory.

Testing checklist

[ ] I have added tests to cover my changes.
[x] All new and existing tests passed.

QA Steps

Screenshots (if available)

@KtorZ Approved! Want me to merge?

Please do :D


Uncaught TypeError: Cannot read property 'toString' of undefined

[Enter steps to reproduce below:]

disable setting "Output the time it took to execute the script"
run the python in step 3

listA = [2.2, 2.3, 2.4, 3.2, 3.3, 3.4, 4.2, 4.3, 4.4, 5.2, 5.3, 5.4, 6.2, 6.3, 6.7]
listB = [1.1, 1.3, 3.2, 4.1, 2.2, 3.3, 3.1, 4.3, 5.3, 5.1, 4.2, 5.2, 6.1, 6.2, 6.3]
def combine(listIn):
listOut = []
c = 0
for i in listIn[0:len(listIn)-1]:
c = c + 1
for j in listIn[c:len(listIn)]:
listOut.append((i, j))
return listOut
def compare(list1, list2):
counter = 0
for i in list1:
if i in list2:
counter = counter + 1
return counter/len(list1)
print(round(compare(combine(listA), combine(listB)), 3))
Atom Version: 1.0.19
System: Mac OS X 10.11.1
Thrown From: script package, v3.0.1
Stack Trace
Uncaught TypeError: Cannot read property 'toString' of undefined
At /Users/samstrawbridge/.atom/packages/script/lib/script-view.coffee:34

TypeError: Cannot read property 'toString' of undefined
    at ScriptView.module.exports.ScriptView.setHeaderAndShowExecutionTime (/Users/samstrawbridge/.atom/packages/script/lib/script-view.coffee:34:53)
    at ScriptView.setHeaderAndShowExecutionTime (/Users/samstrawbridge/.atom/packages/script/lib/script-view.coffee:1:1)
    at /Users/samstrawbridge/.atom/packages/script/lib/view-runtime-observer.coffee:15:13
    at Emitter.module.exports.Emitter.emit (/Applications/Atom.app/Contents/Resources/app.asar/node_modules/event-kit/lib/emitter.js:82:11)
    at Runner.module.exports.Runner.onExit (/Users/samstrawbridge/.atom/packages/script/lib/runner.coffee:67:14)
    at /Users/samstrawbridge/.atom/packages/script/lib/runner.coffee:1:1
    at triggerExitCallback (/Applications/Atom.app/Contents/Resources/app.asar/src/buffered-process.js:213:47)
    at /Applications/Atom.app/Contents/Resources/app.asar/src/buffered-process.js:220:18
    at Socket.<anonymous> (/Applications/Atom.app/Contents/Resources/app.asar/src/buffered-process.js:98:18)
    at emitOne (events.js:82:20)

Commands
     -9:10.4.0 core:paste (atom-text-editor.editor.is-focused)
     -9:05.7.0 grammar-selector:show (atom-text-editor.editor)
  4x -8:55.6.0 script:run (a.inline-block)
     -8:46.6.0 core:select-all (atom-text-editor.editor.is-focused)
     -8:45.9.0 script:run (atom-text-editor.editor.is-focused)
 18x -7:37.4.0 core:move-right (atom-text-editor.editor.is-focused)
  8x -7:33.6.0 core:move-up (atom-text-editor.editor.is-focused)
  2x -7:29.5.0 script:run (atom-text-editor.editor.is-focused)

Config
{
  "core": {},
  "script": {
    "enableExecTime": false
  }
}

Installed Packages
# User
script, v3.0.1

# Dev
No dev packages

Thanks for the fix :+1:

Don't mention it)

When will an update be pushed?

@chrwi It''s been merged, so I guess we are waiting for the next release

fix tested, it's working

Thanks for the issue stewardship @SamStrawbridge. Adding you on as a maintainer to help.


Reproduce

I follow this code to train the results of Graph Generation that can't reproduce your paper. Do you have any other settings?

Hi,
Can you specify which results you are aiming to reproduce? Note that due to the many sources of stochasticity involved, minor deviations to the results in the paper can be expected.

Hey, I just trained the graph generation of cora_ml according to this code, but regardless of the iteration 50k or 100k, the edge overlap always oscillates around 0.4, and does not continue to rise to 0.5 or higher.

Hi, How can I calculate the Table 1 .Average rank?

I understand, thank you very much for your patience.


RFC 9266: Channel Bindings for TLS 1.3 support

Can you add the support of RFC 9266: Channel Bindings for TLS 1.3?

https://datatracker.ietf.org/doc/html/rfc9266

Channel Bindings for TLS:

https://datatracker.ietf.org/doc/html/rfc5929

XEP-0388: Extensible SASL Profile

https://xmpp.org/extensions/xep-0388.html

XEP-0440: SASL Channel-Binding Type Capability:

https://xmpp.org/extensions/xep-0440.html

XEP-0474: SASL SCRAM Downgrade Protection

https://xmpp.org/extensions/xep-0474.html

Little details, to know easily:

tls-unique for TLS =< 1.2
tls-server-end-point
tls-exporter for TLS = 1.3

Thanks in advance.

OpenSSL already implements SSL_export_keying_material. Or is the request for a convenience wrapper specific to the tls-exporter channel binding?

@davidben: It is linked to:

https://github.com/openssl/openssl/issues/12221

@davidben: It is possible to add in code:

RFC 5929
tls-unique
RFC 9266
tls-exporter

It will be better to find in the code...
Example:

https://github.com/openssl/openssl/search?q=rfc

@davidben: For example, there were improvements in GnuTLS, glib and glib-networking about rfc9266 and tls-exporter:

https://gitlab.com/gnutls/gnutls/-/issues/1391
https://gitlab.gnome.org/GNOME/glib/-/issues/2710
https://gitlab.gnome.org/GNOME/glib-networking/-/issues/191

Can you expose tls-unique (rfc5929) and tls-exporter (rfc9266)?

@davidben, @t8m: I wish you a Happy New Year 2023!
Have you looked for this improvement request?

@mvduin: Channel Bindings for TLS = 1.3 needs tls-exporter.
Channel Bindings for TLS =< 1.2 needs tls-unique.

@mvduin: Thanks for your answer.
There is not an announcement in code: RFC5929 / RFC9266
And I do not find:

tls-unique
tls-server-end-point
tls-exporter

Example GnuTLS:

tls-unique: https://gitlab.com/search?search=tls-unique&nav_source=navbar&project_id=179611&group_id=121613&search_code=true&repository_ref=master
tls-exporter: https://gitlab.com/search?search=tls-exporter&nav_source=navbar&project_id=179611&group_id=121613&search_code=true&repository_ref=master
tls-server-end-point: https://gitlab.com/search?search=tls-server-end-point&nav_source=navbar&project_id=179611&group_id=121613&search_code=true&repository_ref=master
rfc5929: https://gitlab.com/search?search=rfc5929&nav_source=navbar&project_id=179611&group_id=121613&search_code=true&repository_ref=master
rfc9266: https://gitlab.com/search?search=rfc9266&nav_source=navbar&project_id=179611&group_id=121613&search_code=true&repository_ref=master

Dear all,
I have update the main description about tls-unique, tls-server-end-point, tls-exporter and I have added XEP-0388/XEP-0440/XEP-0474 links.
I think that you have seen the jabber.ru MITM:

https://notes.valdikss.org.ru/jabber.ru-mitm/
https://snikket.org/blog/on-the-jabber-ru-mitm/
https://www.devever.net/~hl/xmpp-incident
https://blog.jmp.chat/b/certwatch

There is not an announcement in code: RFC5929 / RFC9266 And I do not find:

tls-unique
tls-server-end-point
tls-exporter

Sorry, I really have no idea what you're trying to say or what I'm supposed to notice in those linked searches. RFC9266 explicitly says that:

tls-unique is NOT supported by TLS 1.3
tls-unique remains the default for TLS 1.2 for purposes such as SCRAM or GSS-API over SASL
tls-exporter replaces tls-unique as default binding mechanism for TLS 1.3 in aforementioned applications
tls-exporter MUST be supported by any implementation that supports channel binding with TLS 1.3
tls-exporter is also supported with older versions of TLS as long as certain conditions are met (renegotiation is disabled, extended master secret has been negotiated)

RFC 9266 is silent about tls-server-end-point so it appears it's not defined for TLS 1.3, unless there's some other RFC that I've overlooked. Now, I don't see an obvious reason why you wouldn't be able to use it with TLS 1.3 if you accept the intrinsic limitations of this channel binding type, but nevertheless any such usage would be non-standard and at your own risk.
Having said that, if I were in a situation where my only choices are using tls-server-end-point binding with TLS 1.3 (despite not being officially supported) versus not using channel binding at all and just hoping users will pay attention to never use their credentials to authenticate to untrustworthy domains, I would unhesitatingly choose the former.

RFC 9266 is silent about tls-server-end-point so it appears it's not defined for TLS 1.3, unless there's some other RFC that I've overlooked

My apologies for being vague there; you are correct that tls-exporter is not defined for TLS 1.3 (per RFC 8446 appendix C.5). It should no longer be considered secure for use more generally as well as it suffers from many of the same uniqueness problems as tls-unique without the master secret fix, so you have to be absolutely sure that everything is configured correctly.

@mvduin: Thanks for your answer.
Yes, tls-unique is for TLS =< 1.2, It is already noted in main description.
RFC9266 says that tls-unique is replaced by tls-exporter with TLS 1.3 but do not change about tls-server-end-point.
Furthermore, this document updates [RFC5929] by adding an additional unique channel binding type, "tls-exporter", that replaces some usage of "tls-unique".
For example, when you search in GnuTLS code, you can find all easily, there are references:

tls-unique: https://gitlab.com/search?search=tls-unique&nav_source=navbar&project_id=179611&group_id=121613&search_code=true&repository_ref=master
tls-exporter: https://gitlab.com/search?search=tls-exporter&nav_source=navbar&project_id=179611&group_id=121613&search_code=true&repository_ref=master
tls-server-end-point: https://gitlab.com/search?search=tls-server-end-point&nav_source=navbar&project_id=179611&group_id=121613&search_code=true&repository_ref=master
rfc5929: https://gitlab.com/search?search=rfc5929&nav_source=navbar&project_id=179611&group_id=121613&search_code=true&repository_ref=master
rfc9266: https://gitlab.com/search?search=rfc9266&nav_source=navbar&project_id=179611&group_id=121613&search_code=true&repository_ref=master

Same in openssl code, nothing, there is no reference, can you add in code to help people?

tls-unique: https://github.com/search?q=repo%3Aopenssl%2Fopenssl+tls-unique&type=code
tls-exporter: https://github.com/search?q=repo%3Aopenssl%2Fopenssl+tls-exporter&type=code
tls-server-end-point: https://github.com/search?q=repo%3Aopenssl%2Fopenssl+tls-server-end-point&type=code
rfc5929: https://github.com/search?q=repo%3Aopenssl%2Fopenssl+rfc5929&type=code
rfc9266: https://github.com/search?q=repo%3Aopenssl%2Fopenssl+rfc9266&type=code

RFC 9266 is silent about tls-server-end-point so it appears it's not defined for TLS 1.3, unless there's some other RFC that I've overlooked

My apologies for being vague there; you are correct that tls-exporter is not defined for TLS 1.3 (per RFC 8446 appendix C.5). It should no longer be considered secure for use more generally as well as it suffers from many of the same uniqueness problems as tls-unique without the master secret fix, so you have to be absolutely sure that everything is configured correctly.

???  I'm assuming you meant to say tls-server-end-point rather than tls-exporter (which was introduced specifically as a mechanism that supports TLS 1.3), but even then I don't think this is true. tls-server-end-point binding doesn't provide the same security properties as tls-unique/tls-exporter but its limitations are not similar to the issues of tls-unique. And importantly, tls-server-end-point binding can be used in situations where other binding mechanisms are infeasible, e.g. where TLS is being terminated by a reverse proxy, since it doesn't require the authentication endpoint to have access to any TLS secrets, it only needs to know what server certificate was used.
In terms of security I'd still greatly prefer tls-server-end-point channel binding over just sending your username and password to the server and hope the user doesn't get phished, which is by far the most common authentication protocol used today :P

Oops, yes indeed, tls-server-end-point.

It should no longer be considered secure for use more generally as well as it suffers from many of the same uniqueness problems as tls-unique without the master secret fix

I've had a moment to look up the triple handshake paper to refresh my memory on how the attack worked, and in the scenario where lack of extended master secret allows tls-exporter and tls-unique to be broken (due to both ends of a MITM attack ending up with the same master secret and, after resume, Finished handshake, which means the attacker can simply forward authentication messages), tls-server-end-point is unaffected since it's based purely on the server certificate which means the client's authenticator would incoporate the attacker's certificate and therefore be rejected by the legitimate server.

I went back and refreshed myself on this as well, you're correct, tls-server-end-point would have prevented the recent attack that the previous poster was mentioning for TLS 1.2. It's weaknesses lie more in the fact that it's using a static secret so if the cert gets stolen the MITM can't be detected (where unique type channel bindings such as tls-unique and tls-exporter would still detect the MITM since they use parts of the TLS session).
Anyways, sorry for the confusion, point is that tls-server-end-point is not defined for TLS 1.3, though now I can't remember why off the top of my head. :)

Indeed. I'd love to know the reason it wasn't defined for TLS 1.3, if there actually is one that's not "you ought to be using tls-exporter instead" (which ignores the situations where removing the option to use tls-server-end-point isn't going to encourage use of tls-exporter but instead will lead to abandoning channel binding entirely)

, if there actually is one that's not "you ought to be using tls-exporter instead"

I only wrote RFC 9266 recently but TLS 1.3 had been out for a while, so this was not the reason. Sadly I recently purged my old mailing list archives to save space, but I know there was a lot of discussion on the TLS WG list at the time about this, so I'm sure you could go dig through the archives and find it.

I only wrote RFC 9266 recently

OHH! I hadn't noticed your name is also the one at the top of that RFC! Greetings!  Suddenly the "My apologies for being vague there" makes sense, I didn't quite get that at first. But indeed, it seems a bit odd the RFC is just completely silent about it instead of either defining it for TLS 1.3 or explaining why it isn't.
Renegotiation is of course a hazard with TLS 1.2 but that's of course irrelevant as argument for not defining tls-server-end-point for TLS 1.3 which doesn't have renegotiation.

it seems a bit odd the RFC is just completely silent about it instead of either defining it for TLS 1.3 or explaining why it isn't.

Yes, sorry, in retrospect this was an oversight on my part and I should have at least mentioned why I didn't define one in the document. The simple answer is "that's not the document I was writing, it's just out of scope, someone else can do that if they want" :)

Renegotiation is of course a hazard with TLS 1.2 but that's irrelevant as argument for not defining tls-server-end-point for TLS 1.3 which doesn't have renegotiation.

Not necessarily; TLS 1.3 would have required a lot of work to prove that it did not suffer from the same or similar flaws. There may not be renegotiation, but there are a lot of other extensions and changes which could introduce similar issues (eg. 0-RTT TLS, new hashes and ciphers, etc.) and it would have required a lot more work and careful consideration to check if the older channel binding methods were secure and under what conditions they were secure. This is (I suspect) why the TLS WG just said "these aren't defined" (perhaps with an implicit "for now").
As previously mentioned I only defined a unique one and not an endpoint one because that was just more work and out of scope for the problem I wanted to solve. In general I think that endpoint based methods have less value than unique (session) based methods for reasons previously stated. That's not to say they have no value, I just didn't think it was worth my time to define both. Though bear in mind that I am certainly no expert here, I wrote this document with a lot of help from the WG and don't want to position myself as having more knowledge than I do. It's quite possible I'm missing some obvious and major benefit to endpoint based channel binding.
All that being said, I'm sure the KITTEN WG wouldn't turn down a valid endpoint method for TLS 1.3 if someone wanted to write one or prove that tls-server-end-point was secure, it's just not something I was interested in working on as the security properties aren't as robust in general.
But we're veering fairly far from the point of this issue; maybe we could take this OOB unless this conversation has value to others on this thread? My email and JID are the same and can be found in the RFC; feel free to reach out any time.

Fair enough, and you're absolutely right it got way off topic, my apologies!

To reiterate, my understanding of the situation is that we already have the relevant exporter API in OpenSSL. It is enough to implement the channel binding specification, which is a fairly trivial construction over exporters.
I therefore don't think this is a massive gap in capability that requires prioritisation in terms of code added to OpenSSL. However, a convenience function which implements this RFC would probably still be welcome as a PR and if approved eligible for the next feature release.


secure.php.net port 443: Network is unreachable

Whenever I try phpbrew known , I get the following output
 ===> Fetching release list...
 CurlKit\CurlException: (7) Failed to connect to secure.php.net port 443: Network is unreachable
 Trace:
    0) CurlKit\CurlDownloader->request('https://secure.php.net/releases/index.php?json&version=7&max=100')
    1) PhpBrew\ReleaseList::downloadReleaseListFromOfficialSite(7, GetOptionKit\OptionResult)
    2) PhpBrew\ReleaseList::buildReleaseListFromOfficialSite(GetOptionKit\OptionResult)
    3) PhpBrew\ReleaseList->fetchRemoteReleaseList(GetOptionKit\OptionResult)
    4) PhpBrew\Tasks\FetchReleaseListTask->fetch()
    5) PhpBrew\Command\KnownCommand->execute()
    6) call_user_func_array([PhpBrew\Command\KnownCommand, 'execute'], [])
    7) CLIFramework\CommandBase->executeWrapper([])
    8) CLIFramework\Application->run(['/usr/local/bin/phpbrew', 'known'])
    9) CLIFramework\Application->runWithTry(['/usr/local/bin/phpbrew', 'known'])
    10) require('phar:///usr/local/bin/phpbrew/scripts/phpbrew-emb.php')

I am using Ubuntu 14.04.4

Since the problem is Network is unreachable, it's totally about network connection problem: your computer cannot find a valid path for sending packet to secure.php.net. This is system error, so you should see if anything goes wrong with your network settings like connection, routing table, firewall, proxy and many else in your system, phpbrew can do nothing with it.
If you have no idea how to check system network settings, searching Ubuntu community forum would be a reasonable start.


fixes to metrics

Description

Short description here *

closes #4590
Self Check:
Strike through any lines that are not applicable (~~line~~) then check the box

[ ] Attached issue to pull request
[ ] Changelog entry
[ ] Code is clear and sufficiently documented
[ ] Sufficient test cases (reproduces the bug/tests the requested feature)
[ ] Correct, in line with design
[ ] End user documentation is included or an issue is created for end-user documentation (add ref to issue here: )

Processing this pull request


Pandoc required to build docs

I was trying to build the dask-ml documentation locally and got the following output from make html
building [mo]: targets for 0 po files that are out of date
building [html]: targets for 45 source files that are out of date
updating environment: 45 added, 0 changed, 0 removed
reading sources... [ 11%] examples/dask-glm
Notebook error:
PandocMissing in examples/dask-glm.ipynb:
Pandoc wasn't found.
Please check that pandoc is installed:
http://pandoc.org/installing.html
make: *** [html] Error 1

It looks like Pandoc is missing  from my dev environment (created using conda env create -f ci/environment.yml --name=dask-ml_dev). After manually installing Pandoc from conda-forge, I was able to build the documentation successfully.
Not sure if I missed something when setting up my environment. If not, I'd be happy to submit a PR adding Pandoc to ci/environment.yml and ci/environment-27.yml

Hmm yes I forgot about that dependency, sorry about that.
Let's hold off on adding it for now. I'm trying out sphinx-gallery in https://github.com/dask/dask-ml/pull/91, and it seems to work pretty well (it also produces a downloadable Jupyter notebook).

Alright, sounds good. Thanks @TomAugspurger

The documentation can be built with the new sphinx-gallery dependency in ci/environment.yml. Closing this issue.


Update FlyoutPage to use content properties

Fixes #23 .

@AmirImam
I have update FlyoutPage to accept pages in Flyout / Detail properties.
I've also added FlyoutPageSample to the solution.
Would you be able to check this sample whether it makes sense for you before I merge it?

@AmirImam I have update FlyoutPage to accept pages in Flyout / Detail properties. I've also added FlyoutPageSample to the solution. Would you be able to check this sample whether it makes sense for you before I merge it?

Yes it works, but without navigation. I mean in application startup it shows first page (ContactsPage), but when I click on any (FlyoutMenuItem) it shows blank white page. But in generally now I can make the FlyoutPage is the app's MainPage

@AmirImam
Yep, there was a small bug which caused an empty page in some cases, thanks a lot!
It should be fixed now.


Use the words "delete from hasura hub" in the unpublish description for better SEO

Fixed in 726dffe


FQN matching: "foo" in com.foo.Class matches "com.foo.IFoo"

Followup to #12?
Wrong: "foo" in com.foo.Class matches "com.foo.IFoo"

It is no issue. Partial matching was enabled. Thus the file has been found


getName() is deprecated

1070: DeprecationWarning: getName() is deprecated, get the name attribute instead
tname = threading.current_thread().getName()
it still downloads fragments and seems working despite the warning.

The entire Python script is deprecated in favour of the Go version. It's kept in the repo more of as a just-in-case, or if someone wants to fork and update/maintain it for whatever reason.
Guess I should add that to the readme at some point.


test-branch/execute-job/comment-from-wrong-user-on-pr/a0fe520f-c37b-4a49-bd2a-28ab974f55b2

PR for testing 6355b7ba66003922a80ff9595471ec6c6958142f

/canonical/self-hosted-runners/run-workflows 6355b7ba66003922a80ff9595471ec6c6958142f


Posts aren't sorted correctly when Timeline Configuration set to Nova Default

When the Timeline Configuration is set to Nova Default and Post Numbering is not enabled the post sort order is incorrect.
The post titled Test Order should be at the bottom of the list.
Posts should be ordered by the post_date column and post_status is "activated".

fixed


Blue Screen Windows 10

On Thu 08.11.2018 14:26:53 your computer crashed or a problem was reported
crash dump file: C:\Windows\Minidump\110818-14062-01.dmp
This was probably caused by the following module: ntoskrnl.exe (nt+0x1A9490)
Bugcheck code: 0x154 (0xFFFF838B24463000, 0xFFFFE88A92F516B0, 0x2, 0x0)
Error: UNEXPECTED_STORE_EXCEPTION
file path: C:\WINDOWS\system32\ntoskrnl.exe
product: Microsoft® Windows® Operating System
company: Microsoft Corporation
description: NT Kernel & System
Bug check description: This indicates that the store component caught an unexpected exception.
This appears to be a typical software driver bug and is not likely to be caused by a hardware problem.
The crash took place in the Windows kernel. Possibly this problem is caused by another driver that cannot be identified at this time.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 05c732ce-fd6c-98e4-19ca-f52c6dd3e7b5
Version Independent ID: 868b8c46-2096-9d10-2f6b-f015e6a57003
Content: Bug Check 0x154 UNEXPECTED_STORE_EXCEPTION - Windows drivers
Content Source: windows-driver-docs-pr/debugger/bug-check-0x154--unexpected-store-exception.md
Product: windows-hardware
GitHub Login: @DOMARS
Microsoft Alias: domars

@PetrG68 - I don't see a comment on the docs here, so closing this issue. If you are looking for developer guidance from the developer community, you might look at this forum:

Windows Hardware WDK and Driver Development


Task parameter defaults are ignored

Since we have form inputs for all the task parameters, parameter defaults are overridden by form values, even when the form input is empty.
A possible workaround is to open developer tools and remove the input or disable it. 😅
It works with the command-line runner.
In terms of fix, I think we can't know if an attribute has a default because it's stored in _default_attributes and it looks like a pretty internal API. We could populate the fields with their default values but that seems a bit fishy to call the default, serialize it to a string, put in the HTML, get it back through HTTP and deserialize it back to an object. I mean that could work.
Maybe instead we could just remove attributes from the hash where the value is just an empty string, and let Active Model do the default only once before enqueuing.

We could populate the fields with their default values but that seems a bit fishy to call the default, serialize it to a string, put in the HTML, get it back through HTTP and deserialize it back to an object.

For some reason I'm leaning towards this option. I'm terrible at UX but I feel like this seems to be a very user-friendly option, to actually see default values on the form
For example having attribute :content, :string, default: "default content" attribute we would see it as:

The problem that _default_attributes indeed seems to be a private API. Wonder if we could consider exposing default values publicly in Rails 🤔
Should we try getting default values from the object, for example:
irb(main):005:0> Maintenance::ParamsTask.new.attributes
=> {"post_ids"=>nil, "content"=>"default content"}

It seems to be more or less common way of rendering form for a non-persisted object in the scope of the new action for a scaffold-generated Rails model 🤔

Yes using a new object and accessing the value is the only API I know to get to the defaults. Serializing/deserializing to a HTML form inputs is probably OK most of the time but will be a bit weird with booleans/time etc. Maybe we could get a bit fancy on the inputs depending on the type.

Maybe we could get a bit fancy on the inputs depending on the type.

Yep, definitely 👍
I think it would be reasonable to go ahead and render default values in the existing text_area fields and consider rendering different input types per attribute type as a separate task


[#6357] Upgrade maven-resolver

Codecov Report

Merging #6358 into master will decrease coverage by <.01%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #6358      +/-   ##
==========================================
- Coverage   39.58%   39.57%   -0.01%
==========================================
  Files        3063     3063
  Lines       91425    91425
  Branches    11839    11839
==========================================
- Hits        36190    36182       -8
- Misses      52252    52262      +10
+ Partials     2983     2981       -2

Impacted Files
Coverage Δ

...vercorp/pinpoint/rpc/packet/ClientClosePacket.java
55.55% <0%> (-11.12%)
:arrow_down:

...p/pinpoint/rpc/stream/StreamChannelRepository.java
75% <0%> (-10%)
:arrow_down:

...corp/pinpoint/rpc/stream/StreamChannelManager.java
60.91% <0%> (-5.75%)
:arrow_down:

...rc/main/java/com/navercorp/pinpoint/test/Item.java
70% <0%> (-3.34%)
:arrow_down:

...point/rpc/client/DefaultPinpointClientHandler.java
71.1% <0%> (-0.98%)
:arrow_down:

...orp/pinpoint/rpc/server/DefaultPinpointServer.java
79.92% <0%> (-0.36%)
:arrow_down:

...om/navercorp/pinpoint/rpc/codec/PacketDecoder.java
59.57% <0%> (+2.12%)
:arrow_up:

...tor/metric/datasource/DefaultDataSourceMetric.java
78.12% <0%> (+3.12%)
:arrow_up:

...pc/server/LoggingServerMessageListenerFactory.java
100% <0%> (+10%)
:arrow_up:

...pinpoint/rpc/ChannelWriteFailListenableFuture.java
71.42% <0%> (+28.57%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cce19a6...89f1aa1. Read the comment docs.


object does not support object 'closest'

I am using bootstrap 4.1 and I have an issue with your first example that you put on website..When I start to type some invalid text in email field I am getting an erorr in my visual studio - object does not support object 'closest'

Seems to be a linter error then. This library is not statically typed at all and not feasible for static analysis like in linters.


Foobar crashes when using include + "..\..\" relative paths in Wine

In particular this line crashes the entire foobar instance:
include('..\\..\\helpers\\helpers_xxx_dummy.js')
Dummy being an empty file.
Tested on Spider Monkey Panel v1.6.2-dev+7c0928b, and wine 7.11 (mdac28 wsh57)
See https://hydrogenaud.io/index.php/topic,120978.msg1012020.html#msg1012020
There are multiple dumps provided at the thread.

Well, it's not a problem only with relative paths, but include do fail with a total crash in many use cases on portable installs when files are missing at the path.

https://hydrogenaud.io/index.php/topic,120978.msg1012130.html#msg1012130
"use strict";
include('a.js');

"use strict";
include('myfolder\\a.js');

"use strict";
include('..\\a.js');

All three crash foobar in Wine but only crash the panel on windows.
User uploaded the dumps btw.


Use VADER for insitu/potential temperature conversion

Description
The insitu/potential temperature conversion is currently being performed in UFO (via InsituTemperature), but this requires a separate vertical interpolation that also does this conversion. If we add a recipe to VADER to do the conversion, we can then use the generic vertical interpolator that is in UFO. We can then depreciate, and eventually remove, the InsituTemperature observation operator. The code should be cleaner and more maintainable this way.
We'll also want to sort out the model names, afterward, before this is used by other people (e.g. ROMS)

[ ] Add GSW support to VADER
[ ] Add the insitu/potential temperature recipe to VADER
[ ] Change the yamls in SOCA / Skylab to use the generic vertical interpolator and VADER recipe.
[ ] Compare the two methods (conversion in VADER vs conversion in UFO) it shouldn't make a big difference, but who knows

@hga007 FYI, since you were interested in this. We hope to get this implemented this quarter.

Does this epic need to be extended into Q3? @travissluka

Extend to Q4? @travissluka

Extend to Q4? @travissluka

yes


feat(core): support docusaurus.config.cjs as default file name

Pre-flight checklist

[x] I have read the Contributing Guidelines on pull requests.
[x] If this is a code change: I have written unit tests and/or added dogfooding pages to fully verify the new behavior.
[ ] If this is a new API or substantial change: the PR has an accompanying issue (closes #0000) and the maintainers have approved on my working plan.

Motivation
Related: #6520, #5379
I have heard of users who have "type": "module" in their package.json, which often prevents the docusaurus.config.js file from being read correctly. We should support .cjs extension out-of-the-box, which can also enable us to support .mjs, or even .ts in the future.
In addition, I fixed a little bug with the error message where it's using the default config file name instead of the actual one.
Test Plan
Added a test case.
Test links

Deploy preview: https://deploy-preview-_____--docusaurus-2.netlify.app/
Related issues/PRs

LGTM 👍


Introduced a method to clean build directory

Do not actually merge this, please.
I wrote an e-mail to @eidheim earlier and proposed a method to clean up the build directory.
Now this is obviously a hideous proof of concept and whether or not such a cleanup function is actually useful is very debatable. There are no mutexes set or anything, this is not write-proof, I deleted dirty with boost, etc. as I said, proof of concept, please do not merge!
I'm just putting this here, just in case.
PS: Sorry for the whitespace mess, I used juCi++ to edit it and still had "clean up whitespace" enabled in the options and that turned into what you see now.

Thank you! Currently, the way to achieve this is to remove the build directory by hand, and then reopen the files. Another option, to rebuild with the cmake cache files, is to save a CMakeLists.txt in the project directory. One could also remove the build directory and then save a opened CMakeLists.txt and thus avoid reopening the already opened c/c++ files.
On the other hand, it might maybe be useful, especially for less experienced cmake users, to have an option to do a complete rebuild (deleting the build directory and rebuilding it) without having to reopen or saving any files. I'll add this to my TODO list, and if you could do a commit without removing our beloved whitespaces, I could continue on your commit. In this way, you get credited for this work as well.
Regarding the whitespaces, we basically just keep them around so that we don't have to be too strict when accepting commits, and also we then never have to have meaningless commits that would just remove any whitespaces we would maybe miss. Although, the commits should be readable:)

I did a git rebase in my repository, and thus this PR did not get automatically marked as merged. It is merged however, thank you very much:)


Cannot instantiate bugsnag client in jest test

I have a react app and I am trying to test one of my components that pulls in my bugsnag client and uses it to create an ErrorBoundary using the react plugin.
However, when creating the bugsnag client I get the following error: TypeError: setInterval(...).unref is not a function.
The file the creates the client looks like this:
import React from 'react';
import Bugsnag from '@bugsnag/js';
import bugsnagReact from '@bugsnag/plugin-react';
import config from '../config';

const bugsnag = Bugsnag({
    apiKey: config.bugsnagKey,
    releaseStage: config.env,
    appVersion: config.version,
    notifyReleaseStages: ['production', 'staging'],
});
bugsnag.use(bugsnagReact, React);

export default bugsnag;

The error occurs when trying to create the client with Bugsnag({...})
I get the following stack trace:
at SessionTracker.start (node_modules/@bugsnag/node/dist/bugsnag.js:2138:75)
      at Object.init (node_modules/@bugsnag/node/dist/bugsnag.js:2028:20)
      at BugsnagClient.use (node_modules/@bugsnag/node/dist/bugsnag.js:163:30)
      at node_modules/@bugsnag/node/dist/bugsnag.js:1578:20
          at Array.forEach (<anonymous>)
      at module.exports (node_modules/@bugsnag/node/dist/bugsnag.js:1577:11)
      at Object.<anonymous> (src/utilities/bugsnag.js:91:9)
      at Object.<anonymous> (src/index.jsx:503:35)
      at Object.<anonymous> (test/components/App.spec.jsx:9:35)

This seems odd – are your jest tests running in Node?
You're in a bit of a grey area because jest tests usually run browser code in node, and this means that Bugsnag loads @bugsnag/node rather than @bugsnag/js, but since I imagine you are running in Node, timer.unref() should be defined.
What version of Node are you running?
There might be something we can do here – either to get it to load the browser notifier (depending on how much of the browser env gets stubbed/mocked by jest) or make the Node notifier behave a little better. In order to do so it would be good to have a bit more context or info about your setup. Please provide as much as you can! A stripped back project that we can run and reproduce this issue would be perfect. Thanks!

Running Node v10.9.0
Tests are run from an npm/yarn script that simply calls jest
Running jest v23.6.0
Running yarn v1.10.1
jest config looks like this:

module.exports = {
    verbose: true,
    bail: true,
    collectCoverage: true,
    setupTestFrameworkScriptFile: '<rootDir>/test/setup.js',
    moduleNameMapper: {
        '\\.(css|scss)$': 'identity-obj-proxy',
        '\\.(jpg|jpeg|png|gif|eot|otf|webp|svg|ttf|woff|woff2|mp4|webm|wav|mp3|m4a|aac|oga)$':
            '<rootDir>/test/__mocks__/fileMock.js',
    },
};

Let me know if you need any more details. I'll let you know what I have a stripped back project to test against.

Repro is here https://github.com/keattang/bugsnag-bug-repro-2

Great thanks!

I'm also experiencing this error. I tried setting the browser setting in package.json but without any success. However I have a Nextjs setup so it is possible those settings override that at some point. In the end I don't know if this is an optimal solution for me anyway since I have both Node and "browser" tests for my server side rendering process and is dependant on both the node and browser version of Bugsnag.

browser: true needs to be under the jest key package.json, can you confirm it was there?
{
  "name": "my-package",
  "version": "1.0.0",
  "jest": {
    "browser": true
  }
}

I ended up doing something like this to stub out bugsnag within the test environment:
const bugsnag = require('@bugsnag/js');
const bugsnagExpress = require('@bugsnag/plugin-express');

let bugsnagClient;

if (process.env.NODE_ENV !== 'testing') {
  bugsnagClient = bugsnag('xxxxxx');
  bugsnagClient.use(bugsnagExpress);
} else {
  bugsnagClient = {
    getPlugin() {
      return {
        requestHandler(req, res, next) {
          req.bugsnag = { notify() {} };
          return next();
        },
        errorHandler(req, res, next) {
          return next();
        },
      };
    },
  };
}

Thanks @domharrington! If you're running Node tests – and you're not doing this already – you should make sure Jest is using the Node environment because by default it uses jsdom. Set this with something like (or command line flag, or @ test annotation):
{
  "name": "my-package",
  "version": "1.0.0",
  "jest": {
    "testEnvironment": "node"
  }
}

Though if you're using Jest for Node and browser tests in the same codebase you'd probably want to set it dynamically. See the testEnvironment docs for more details.
@axelinternet can you share more information on your setup or provide a sample repo where I can reproduce the problem? Is your code being bundled or built before your tests are run?
@remotealex I've filled a PR against create-react-app to allow you to set the correct config, feel free to 👍 that issue so that it gets more attention!

Another solution that I haven't yet mentioned is that if your code is not "universal" i.e. you don't run the same thing in Node and in the Browser, and you don't need to automatic detection of whether to load the Node/Browser notifier, you can import the exact notifier you want:
const bugsnag = require('@bugsnag/browser')
// or
const bugsnag = require('@bugsnag/node')

So if your tests are running in jsdom, pull in @bugsnag/browser and if they are running in Node, pull in @bugsnag/node.
Also consider if Bugsnag should be loaded in your tests at all! If you are testing the ErrorBoundary component with Jest then that seems a good enough reason, but if you aren't using any of the features and are just switching off error reporting, maybe the scope of your tests should be reduced to not include an error reporter?
I'm going to close this off as there are multiple workable solutions. The fact that you get an error at all is a good canary that the wrong library has been loaded, and hopefully anybody who gets this error in future will find this issue.
Any further problems, let us know!

👍
Since we are using React it uses browser so using
import bugsnag from '@bugsnag/browser';
works for me in project and testing(using jest and enzyme) as well.
👍

@bengourley this still happens on node with @bugsnag/js if you follow the instructions on the bugsnag website jest won't run

@andreimc - have you tried the suggestion Ben made previously here yet?
https://github.com/bugsnag/bugsnag-js/issues/452#issuecomment-490927492

Adding testEnvironment: "node" to my jest.config.js solved my problem

Agreed on not needing Bugsnag during tests, but documentation usually instantiates Bugsnag globally or as an IIFE. To avoid caring about Bugsnag during tests while following Bugsnag docs, simply add:
jest.mock('@bugsnag/js'); in your Jest setup file (the file that the jest.config.js maps to via setupFilesAfterEnv).

Another way to do this, using moduleNameMapper in jest.config.js:
module.exports = {
  moduleNameMapper: {
    '@bugsnag/js': '@bugsnag/browser'
  }
}

(or package.json jest field):
  "jest": {
    "moduleNameMapper": {
      "@bugsnag/js": "@bugsnag/browser"
    }
  }


Fix KMock visibility for Common

What does the PR achieve/Which part improves the PR?

Currently KMock and KMockMulti are not visible in CommonCode. However they are present for JVM/Android.
:thinking: DOD Checklist

[x] My code passes the lint checks.
[ ] My changes are covered with proper tests.
[x] All tests are pass.
[ ] My changes update the documentation.
[ ] My changes are reflected in the changelog.

This actually not caused by the repository only by collision of maven packages.


adding an icon for the addon

I think you might have to modify the XML?

@cancan101 thanks do you mean I should bump the version up ? or add my name?

@cancan101 I am thinking to add Kurdish language support to your plugin, could I become one of the contributors of your addon ?

For the icon, please see: http://kodi.wiki/view/Add-on_structure#icon.png for the rules.
Sure feel free to become a contributor by submitting PRs. Also feel free to add a contributors.md file listing yourself. Please also list @asfaltboy in both places.

Thanks I will add a standard logo soon, with contributors.md  file :)

@cancan101 is there a format for contributors.md ?

How about a list like:

Alex Rothberg

@cancan101 would everone be okay with their full name there ? could it be full name + github username?

@cancan101 I am thinking to add a favorite folder to the addon, to easily access your current courses), what is the best place for contributors to talk about development of a project in github ? (wiki page? or is there a better place)

I would say right on the feature issue.
If people don't want to put their full name, they can just put their github name

The proposed icon in 16200e1fc384fedf70aaf82fc98ead29b15384bc is against Kodi rules:  transparent background, size 250x250.
Please consider logo in PR #12.


finalize deprecation of "closed"-parameter

[x] User visible changes (including notable bug fixes) are documented in whats-new.rst

Over in #9618 I'm going to add unit-parameter to these functions. Finalizing the deprecation cycle before that.

Merging quickly to unblock Kai.


Pancake and BSC fork

Hello
This wrapper is pretty good when interacting with Uniswap. However, BSC and Pancake share almost everything from the eth network. (even the functions are the same
So I wonder, is there a fork already which works with PancakeSwap and BSC? What would need to be changed to add support for Pancake?
Network ID, and pancake router contracts?
Thanks

See https://github.com/shanefontaine/uniswap-python/issues/62#issuecomment-763468170 and https://github.com/shanefontaine/uniswap-python/pull/58.
Some work required but should be easy to implement, please make a PR if you get around to it!

Hello
Thanks for your response. Unfortunately my knowledge is limited. But I could try. However, do you know of any pancakeswap wrapper for python?

I think patching line 121 and line 184 in uniswap.py would do it.
`_netid_to_name = {1: "mainnet", 3: "ropsten", 4: "rinkeby", 56: "BSC"}
elif self.version == 2:
if self.network == 'BSC':
factory_contract_address_v2 = _str_to_addr(
"0xca143ce32fe78f1f7019d7d551a6402fc5350c73"
)
    self.router_address: AddressLike = _str_to_addr(
        "0x10ed43c718714eb63d5aa57b78b54704e256024e"
    )
else:
    # For v2 the address is the same on mainnet, Ropsten, Rinkeby, Görli, and Kovan
    # https://uniswap.org/docs/v2/smart-contracts/factory
    factory_contract_address_v2 = _str_to_addr(
        "0x5C69bEe701ef814a2B6a3EDD4B1652CB9cc5aA6f"
    )

    self.router_address: AddressLike = _str_to_addr(
        "0x7a250d5630B4cF539739dF2C5dAcb4c659F2488D"
    )

self.factory_contract = self._load_contract(
    abi_name="uniswap-v2/factory", address=factory_contract_address_v2,
)

# Documented here: https://uniswap.org/docs/v2/smart-contracts/router02/
self.router = self._load_contract(
    abi_name="uniswap-v2/router02", address=self.router_address,
)`

I adapted #58 to allow for overriding the factory and router contract addresses in the constructor. Should work, feedback/testing welcome.

Closing. Please open a new issue if you stumble into problems.


Updating to OS 6 may break the integration.

So I upgraded to Home Assistant 6.0 today, and of course the "old" amberelectric integration broke.
I used file editor to rename the old custom components folder, and uploaded this repository to a "new" custom_components/amberelectric folder.
Then reloaded core from the file editor integration.
No errors there, but also no sensors.
So I went to Supervisor and asked it to reload the core there.
This produced the error:
The system cannot restart because the configuration is not valid: Platform error sensor.amberelectric - Integration 'amberelectric' not found.
So I'm at a loss to whats wrong.
Checked folder names etc are correct. Even deleted the "oldamberelectric" directory from the shell (py files are hidden...)
I thought this would be an easy fix...but not so.
I'll rollback the snapshot and try upgrading with this manifest version first before updating to OS6.0.

Hmm...
Ok. This time all I did was replace the old manifest file, with this one here, and attempting to restart core fails with the same error....

Wait...even though I rolled back to an older snapshot...HA still says 6.0....Not sure whats going on there....

Definitely something funky going on - I'm not running supervised, so can't help with that aspect, but I'm on Home Assistant 2021.6.2 without an issue at all.....

Well, its got me stumped. Rolback is not working at all.
But, one thing i noticed, doesn't the manifest file need a version?
eg:
"version": "1.0",

It has one?

Argh...ok. Not sure what is going on....
Somehow the snapshot rollback, rolled the manifest back, but not the OS, makes me wonder what a "full snapshot" is.
Anyway...editing the manifest file with the code here..which DOES include a version...sorry Dave.....and saving it seems to have worked.
So I'll close this issue and only assume it was some kind of operator error.... :/facepalm:/


Facing some webdriver exceptions

inside facebook_page_scraper i have runned setup.py as per instrcutions.
when iam trying to run the  same example iam getting an error:
[WDM] - Driver [/root/.wdm/drivers/geckodriver/linux64/v0.29.0/geckodriver] found in cache
Traceback (most recent call last):
File "face.py", line 8, in
json_data = facebook_ai.scrap_to_json()..
raise exception_class(message, screen, stacktrace)
selenium.common.exceptions.WebDriverException: Message: Process unexpectedly closed with status 1
can anyone figure out this error and provide me running example .

Which browser is installed on your system?, Firefox or Chrome?. If you are using same code as mentioned in README then it means you have firefox installed on your default path?.
Similar question on stackoverflow

Yes firefox is installed in my system and iam running example as mentioned in Readme file
Inside facebook-scrapper folder Iam trying to run script.
Can you suggest me how to solve this issue.
It is little bit important for me.

I wonder if its a driver compatibility issue. See


changed termii url

the api url has been changed to the one used in the termii api documentation

Hi, @phemieny7 thanks for the PR. Do you mind linking to the part of the documentation where the new URL exists?

hi, @aremu-smog  it on the termii developer documentation https://developers.termii.com/


No longer working with Ecto 2.0-beta

Hey there,
The breaking changes introduced in 2.0-beta have caused params to break (thankfully its tests also break in the same way). I'm working on a PR to fix this right now, but in the meantime, here's the sort of errors I'm experiencing:
Compiled lib/params/def.ex
** (Protocol.UndefinedError) protocol Enumerable not implemented for :id
    (elixir) lib/enum.ex:1: Enumerable.impl_for!/1
    (elixir) lib/enum.ex:116: Enumerable.reduce/3
    (elixir) lib/enum.ex:1486: Enum.reduce/3
    test/params_test.exs:10: (module)
    test/params_test.exs:8: (module)

== Compilation error on file lib/params.ex ==
** (CompileError) lib/params.ex:77: unknown key :model for struct Ecto.Changeset
    (elixir) src/elixir_map.erl:185: :elixir_map."-assert_struct_keys/5-lc$^0/1-0-"/5
    (elixir) src/elixir_map.erl:62: :elixir_map.translate_struct/4
    (stdlib) lists.erl:1353: :lists.mapfoldl/3

Some information @mitchellhenke and I have gathered over Slack:

Changes to %Ecto.Changeset{} between 1.x and 2.x:  https://gist.github.com/sorentwo/9b351ead9fbc2c7da500
Issue seems to be associated with parsing the field, not the schema, although due to macros, the stacktrace doesn't make this clear.

Hey, thanks for your work on getting this working with ecto 2.
I've created a new branch ecto-2.x and released a new version
I'll merge on master as soon as ecto 2 gets out of beta.

@vic you are a beautiful human being :smile: Thanks for putting this out so quickly!


Cre8/issue239

fixes #239
I am not sure if we can test it locally since we do not have a valid npm token to run the task successfully. Based on the logic:

lerna publishes to npm, creates the commits but does not push
we run the format command and commit the changes
Then we run execute the push to push the two commits.

Yeah.. we can't test it locally. Let's test it when we have next release :)


It works in svelte 4 but not in version 5

✘ [ERROR] node_modules/svelte-multiselect/dist/MultiSelect.svelte:521:6 Event attribute must be a JavaScript expression, not a string [plugin vite-plugin-svelte:optimize-svelte]
node_modules/svelte-multiselect/dist/MultiSelect.svelte:521:6:
  521 │      ondrop="return false"
      ╵       ^

The plugin "vite-plugin-svelte:optimize-svelte" was triggered by this import
node_modules/svelte-multiselect/dist/index.js:3:48:
  3 │ export { default as MultiSelect, default } from './MultiSelect.svelte';
    ╵                                                 ~~~~~~~~~~~~~~~~~~~~~~

(node:5065) [DEP0040] DeprecationWarning: The punycode module is deprecated. Please use a userland alternative instead.
(Use node --trace-deprecation ... to show where the warning was created)

Is there a workaround?


DB passwords with "@" character get's wrongly parsed in DATABASE_URL

Bug description
I had my database URL looking like this  postgresql://application:#@123njhuts@localhost:5432/portal-db-prod, on running prima migrate command I get an error "P1001: Can't reach database server at dbUser:`5432".
I tried changing my cloud_sql_proxy to a different port but it didn't work, I then tested the db connection with pgAdmin, that worked,
After different trials, I decided to change the db password, removing the "@" sign and everything worked as expected.
How to reproduce
Use a db password that includes an "@" character, then try running Prisma migration
Expected behavior
"P1001: Can't reach database server at dbUser:`5432".
Environment & setup

OS: Ubuntu
Database: PostgreSQL
Node.js version: v14.1.0
Prisma version:
"@prisma/client": "^2.8.1"
"@prisma/cli": "^2.8.1",

Hello @Oliver-ke
You will need to percent encode @ as %40. That will allow you to use that character in the uri format.

Okay @pantharshit00 ,
Good to know, it'll be nice to add to the docs or provide a more descriptive error message so that some other person won't go through the same issue.
thanks.

Opened: https://github.com/prisma/docs/issues/1057


Firewall for Nessus and Concourse

Not sure whats the best way of doing this but we should firewall IPs for Nessus and Concourse

Maybe we can have a (private?) repo that lists IPs and a terraform job in concourse that updates a SG.

@LinuxBozo says we should only this for nessus

@dlapiduz Is this still necessary? @sharms is saying he thinks the necessary restrictions are already in place.

Not in govcloud...

Ah, but in E/W? Then I'll leave it prioritized as-is.

Just to be clear:

There is a firewall in E/W
There is no firewall in GovCloud

Okay!

https://github.com/18F/cg-provision/pull/37


Rewrite Ubuntu install procedure

This is a major rewrite/reorganization. Most of the text has changed. Also:

I changed/added several commands, such as a step to start xo-tp-python
(to be consistent with the Docker and AWS demo environments) and several
commands to check the logs.

I updated the output to match the current release.

Signed-off-by: Anne Chenette<EMAIL_ADDRESS>

I have made the changes and corrections from Adam's review.  In addition to the simple corrections and wording tweaks, I made two significant changes:

I removed the two sections on other start-up options for the validator and transaction processors, and replaced them with a link to the relevant command in the CLI Command Reference.

I kept the info about being able to start the transaction processors before the validator, but I reworded it and put it in the intro section as a note.


Develop

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 61.136%

Totals

Change from base Build<PHONE_NUMBER>:
0.0%

Covered Lines:
689

Relevant Lines:
1127

💛  - Coveralls


Make a better looking default-page

Think this can be marked as resolved with our new set of pages (Both start-page but also 404, 500 etc)


update ctools.data

Mainly some format and type annotation updates.
And some small bug fixes:

remove from torch._six import container_abcs, string_classes, int_classes and instead use (for pytorch 1.9.0 compatibility)

import collections.abc as container_abcs
from torch._six import string_classes
int_classes = (bool, int)

A bug reported with TODO in comment

data = self.data_source(self.batch_size, paths)  # TODO(Local State) `paths` is not defined

fix a return bug in ctools.data.structure.buffer.PrioritizedBuffer._sample_check

Codes in ctools will be updated in next weeks. My advice is that you can pay more attention to distar directory, especially those parts which is easy to misunderstand, and you can provide some comments about which parts are more necessary to add some tables and graphs.

@PaParaZz1
Ok. You may fix the 3 small bugs I proposed. And hope the maintainers can set several issues and roadmaps to guide others which part needs help.

@PaParaZz1
Ok. You may fix the 3 small bugs I proposed. And hope the maintainers can set several issues and roadmaps to guide others which part needs help.

We will release training code around August. It would be nice to have your help then. Just play around now!

emmm. It’s already merged?
I have to say that I haven’t fully tested my modification, since there is no unit test code.
please check it with care.


Adds list with current functionality in the software

Closes #131.

This is the list I have added. We can modify it afterwards to add, remove and modify the items:

Current functionality
<T>LAPACK is a work in progress (WIP) project. This is a list of the current functionality:

[x] BLAS

[x] Level 1, except SDSDOT.
[x] Level 2, except the routines for banded and packed formats (xGBMV, xHBMV, xHPMV, xSBMV, xSPMV, xTBMV, xTPMV, xTBSV, xTPSV, xHPR, xHPR2, xSPR, xSPR2).
[x] Level 3.

[ ] Matrix factorizations

[x] Cholesky

Recursive
Blocked

[x] Hessenberg reduction

Level-2
Blocked

[x] Householder QR

Level-2

[ ] Householder RQ
[x] Householder LQ
[ ] Householder QL

Level-2
Blocked

[x] Householder bidiagonalization

Level-2

[x] LU with partial pivoting

Level-0
Recursive

[ ] Matrix inversion

[x] General matrix

Method C from §14.3.3 in [1]
Method D from §14.3.4 in [1]

[ ] Hermitian positive definite
[x] Triangular matrix

Recursive

[x] Norms of general, hermitian, symmetric and triangular matrices

[x] 1-norm
[x] Infinity-norm
[x] Frobenius-norm

[ ] Nonsymmetric Eigenvalue Problem

[x] Schur decomposition

Double-shift implicit QR
Multishift implicit QR with Aggressive Early Deflation (AED)

[ ] Eigenvector computation
[ ] Generalized Schur problem
[ ] Generalized eigenvalue problem

[ ] Symmetric Eigenvalue Problem

[ ] Tridiagonal reduction
[ ] Schur decomposition
[ ] Eigenvector computation

[ ] Singular Value Decomposition (SVD)

[ ] Standard singular value problem
[ ] Generalized singular value problem

[ ] Linear least squares

[ ] Using QR factorization
[ ] Using SVD

[x] Additional kernels

[x] Order 1 and 2 Sylverster equation solver
[x] In-place upper times lower triangular matrix multiplication for general and hermitian matrices
[x] In-place lower times upper triangular matrix multiplication
[x] In-place transpose of a matrix

The complete documentation and implementation for the routines that are available are listed in the API documentation.
References
[1] Higham, N. J. (2002). Accuracy and stability of numerical algorithms. Society for industrial and applied mathematics.

Some extra routines I can think of:

safe scaling triangular solve
fully pivoted QR/RQ/LQ/QL


Change mac acceptance test image.tar path

Today the /tmp/image.tar file used for mac acceptance testing is cached, however, the system used for CI is unable to untar into /tmp:

Resulting in docker pull rate limits over time:

This PR moves the image to a location which can be restore to by the cache (not in /tmp)
Additionally this PR fixes a bad image reference given to syft (docker-archive:// vs docker-archive:) and now only installs skopeo on a cache miss.

Ironically I need to wait to validate this until we pass the rate limit window

Caching behavior confirmed 🤖 🚀


Remove the clear capture button

As there is no use case of the "Clear Capture" button in the new ui, we remove it completely.
bug: http://b/179470701

LGTM Vicky!
BTW, could you explain why you update the paths to orbiticons.qrc and orbitimages.qrc? Some explanation in the body of the commit.

Thanks for reviewing. I just updated the commit description to mention about this.


Feature/daily summary tracking

Description
Added a tripwire for daily summary links, that open in the browser to get reported
Type of change

[ ] Bug fix (non-breaking change which fixes an issue)
[x] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[ ] Documentation update
[ ] Chore: cleanup/renaming, etc
[ ] RFC

Notes

@baristaGeek Thanks for checking


Unnecessary XSL files in src/resources/findbugs

The only files that seem to be in use are
cflint-to-findbugs.xsl
plain.xsl
Can we get rid of all the others?

I think so.  they are artifacts from the very early days :-)

Merged in #279


Downgrade jessie and sid mesa libraries

This is trickier than precise, as libegl1-mesa depends on libwayland0=0.85.0-2. We manually fetch and install the packages, then hack the dpkg database to change the dependency (we could modify the .deb files but that's a bit more complicated and slower as we need to repack the file). Not pretty, but I couldn't find any better way.
To avoid fetching the .deb files on every update, I added a list_needs_update function in ubuntu/prepare. We could move it to prepare.sh if there is a need to use it on other releases.
I'd appreciate if somebody could check if it actually works on affected hardware (@DennisLfromGA @peter-gulka @feeddageek: anyone feeling adventurous?), at least kde/gnome targets on jessie. sid as a bonus.
Tested in 2014-07-11_10-20-09_drinkcat_chroagh_x11-test.tmp-lts-trusty-fix-jessie-sid_35, matrix here: http://drinkcat.github.io/chroagh/2014-07-11_10-20-09_drinkcat_chroagh_x11-test.tmp-lts-trusty-fix-jessie-sid_35.html .

Unlikely to happen due to the invasiveness and eventual 3.8 move.

eventual 3.8 move.

Can't wait for that to happen ( on my falco ).

@DennisLfromGA falco is on 3.8

@divx118 - Yup, sorry, I got confused with my 'parrot' that I just revived from a TPM error. I'm not used to using it.... :/


Expose operation to paged RPC calls on all pages

The underlying gRPC operation should always be available so that the trailing_metadata can be accessed by clients. Currently, this is only possible on the first page of a paginated RPC and this change adds an operation property to the Page class and exposes the operation via the format_response callback.
Note that the format_response callback returns a nil operation for streaming methods - I'm not sure if we want to also pass the operation to this callback each time or document it as-is. Thoughts?
[resolves #227]

This PR's functionality has been implemented in #231, #232, and #234. Closing


Clarification on pretrained weight loading!

For pretrained model, the way you coded, HERE, seems little odd compare to the conventional way from keras.applicaiton. If we use
model = kcv_attn.swin_transformer_v2.SwinTransformerV2Large_window24(
            input_shape=(384, 384, 3),
            num_classes=64,
            classifier_activation="gelu",
            pretrained="imagenet22k",
        )

How the weight loading works here where the model architecture should be differ from imagenet-22k weight? Other word, for a different number of classes (num_classes != 1000), how pretrained weights are assigned?
if num_classes > 0:
   nn = keras.layers.GlobalAveragePooling2D(name="avg_pool")(nn)
   if drop_rate > 0:
        nn = keras.layers.Dropout(drop_rate, name="head_drop")(nn)
   nn = keras.layers.Dense(num_classes, .., activation=classifier_activation)(nn)

And what if we only need signal from gap layer (include_top=False)?

Hi innat!
I'm using model.load_weights(weight_file, by_name=True, skip_mismatch=True) in download_and_load.py#L50. So for num_classes=64 will just skip loading the header Dense layer:
import kecam

mm = kecam.swin_transformer_v2.SwinTransformerV2Tiny_window8(num_classes=64)
# >>>> Load pretrained from: ~/.keras/models/swin_transformer_v2_tiny_window8_256_imagenet.h5
# WARNING:tensorflow:Skipping loading weights for layer #601 (named predictions) due to mismatch in shape for weight predictions/kernel:0. Weight expects shape (768, 64). Received saved weight with shape (768, 1000)
# WARNING:tensorflow:Skipping loading weights for layer #601 (named predictions) due to mismatch in shape for weight predictions/bias:0. Weight expects shape (64,). Received saved weight with shape (1000,)

And if set num_classes=0 will just create a model without GAP + Dense header. The header weights will be skipped because of by_name=True, that the header layer not exists in this case:
mm = kecam.swin_transformer_v2.SwinTransformerV2Tiny_window8(num_classes=0)
print(mm.outputs)
# [<KerasTensor: shape=(None, 8, 8, 768) dtype=float32 (created by layer 'pre_output_ln')>]

There are also functions for some specific purposes:
# Get pyramid layers output for building detection models
aa = kecam.model_surgery.get_pyramide_feture_layers(mm)
bb = keras.models.Model(mm.inputs[0], [ii.output for ii in aa])
print(bb.outputs)
# [<KerasTensor: shape=(None, 64, 64, 96) dtype=float32 (created by layer 'stack1_block2_output')>,
#  <KerasTensor: shape=(None, 32, 32, 192) dtype=float32 (created by layer 'stack2_block2_output')>,
#  <KerasTensor: shape=(None, 16, 16, 384) dtype=float32 (created by layer 'stack3_block6_output')>,
#  <KerasTensor: shape=(None, 8, 8, 768) dtype=float32 (created by layer 'stack4_block2_output')>]

# Get GAP layer id, this is made for token-label training
mm = kecam.swin_transformer_v2.SwinTransformerV2Tiny_window8(num_classes=64)
gap_layer_id = kecam.model_surgery.get_global_avg_pool_layer_id(mm)
# [Search pool layer] header_layer_id = 601, layer.name = predictions
# [Search pool layer] header_layer_id = 600, layer.name = avg_pool
bb = keras.models.Model(mm.inputs[0], mm.layers[gap_id].output)
print(bb.outputs)
# [<KerasTensor: shape=(None, 768) dtype=float32 (created by layer 'avg_pool')>]

Hello @leondgarse,
Thanks for your details response. It's clear now.
Anyway, great repository, really amazing effort. One thing I like to suggest though is to renaming it, (read the roadmap). It's more like timm version in keras. Probably you should pick name like keras-model-zoo or something that would represent the resource of this repo. Also, if you consider contributing to keras_cv, I think it's right time to submit PR, as they're now reviewing the classification and detection models.

Just added some clarify on num_classes in README #basic. Actually I've recently joined a new company, and it just consumed almost all my spare time...


How can i run Pokemon Go Map from CMD using -u / -a / -p attribs?

Hi Guys,
I've got alot of accounts running at the moment, all on single instances of the desktop app. But say i want to reboot the server, i wouldn't like to manually open everything again. I've looked for options to run it from CMD for a bat file like
"PokemonGo Live Map.exe" -a PTC -u XXX -p XXX
But then  it just starts up. With the default last remembered name.
Is there any way to get this working? New instances of the app, fom commandline with different values?
Maybe by editing the configfile, adding all those accounts?

no one? :(


[SMALLFIX] Fix failing test BufferedBlockInStreamIntegrationTest

Fixing the failing integration tests

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Alluxio-Pull-Request-Builder/9002/
Test PASSed.

LGTM, thanks for fixing this Bin

Will this have to be ported to branch-1.0 as well?

LGTM

@gpang , no branch-1.0 doesn't have this issue as the pom structure becomes different in master

ok, sounds good!


Regarding rastertoescpx.c support for latest Epson printers

I am able to convert pdf -> raster -> print file(prn) using rastertoescpx.c and send print file over USB. But observe printer not responding.
Regarding this would like to know if rastertoescpx.c is supported for latest epson printers like Epson M200. If not please provide some alternatives.
Epson test printer used:
https://www.epson.co.in/Ink-Tank/Ink-Tank-System-Printers/EcoTank-M200-Multifunction-B%26W-Printer/p/C11CC83412

rastertoescpx.c was developed many years ago (~ a decade) and got never actually used. I inherited it from CUPS when Apple split off all filters which were not used by Mac OS and I started maintaining them founding the cups-filters project. I have never seen a PPD file for it and so I assumed that no one actually used it.
For modern Epson printers either use Gutenprint or the Epson drivers referred to on OpenPrinting's driver list, or the "printer-driver-escpr" or "epson-inkjet-printer-escpr" package of your distribution.


[management] pretty print op tool output

The libra-operational-tool output was using Debug output from rust which
was non-standard and very verbose.  It wasn't very user friendly, so now
we output with JSON, and we decrypt the validator addresses for
readability.
Testing
Validator-set
Success
$cargo run -p libra-operational-tool -- validator-set --config config.yaml
[
  {
    "account_address": "65e40eeb881a28e690c34d83a404bab8",
    "consensus_voting_power": 1,
    "config": {
      "consensus_public_key": "7552a55e9dbbd94ba086b1d9fb9e34c1f4e35df77e05ffa335d1d1a09909a53b",
      "validator_network_identity_public_key": "29e714863d8533f0562586d0284fdc0904ae814cc5cc9e0c6b807081b9468417",
      "validator_network_address": "/dns4/val0-libra-validator-validator-lb/tcp/6180",
      "full_node_network_identity_public_key": "a175868cd55f316c89eec7e6870dd43e2b889fb3337de6bca09ad3ab258cfb62",
      "full_node_network_address": "/dns4/val0-libra-validator-fullnode/tcp/6182"
    }
  },
  {
    "account_address": "7dcb804968ee40a64c4d5ed1f3c8c506",
    "consensus_voting_power": 1,
    "config": {
      "consensus_public_key": "3ab7ccc31a46d6c77de4fd1734638ad658f4fcb561571668f0d88909973ed885",
      "validator_network_identity_public_key": "924ccd2de5d15fab0ad5caa0955d848f5fb0444c02b619c1a2aca427f83acb40",
      "validator_network_address": "/dns4/val1-libra-validator-validator-lb/tcp/6180",
      "full_node_network_identity_public_key": "4c1c5758b13f28174504ccada39e17ace9b0dad270cbcdd5e6ec992e3b30de3e",
      "full_node_network_address": "/dns4/val1-libra-validator-fullnode/tcp/6182"
    }
  },
  {
    "account_address": "74e28b8a9564e7faf05f716f15010706",
    "consensus_voting_power": 1,
    "config": {
      "consensus_public_key": "ec24b4ede30d69e47221abb21d4d601fbc4bdea86e3cb1f7a63a633f98b6dcdb",
      "validator_network_identity_public_key": "65f25a2fd051903f315eb50cb7952eadb2e379df59d7c89ee336374cb436f203",
      "validator_network_address": "/dns4/val2-libra-validator-validator-lb/tcp/6180",
      "full_node_network_identity_public_key": "02993c3855f3c4971d95589ac2ec0365042e127d7e026b32e07cfcd1655df302",
      "full_node_network_address": "/dns4/val2-libra-validator-fullnode/tcp/6182"
    }
  },
  {
    "account_address": "f7d4dd491014f0d5bc98f90a286bc109",
    "consensus_voting_power": 1,
    "config": {
      "consensus_public_key": "bb494029310c8f98e2c5151e304a6f16b821af3fbd860be375ff92d3f59df41e",
      "validator_network_identity_public_key": "c61548c2e8c180234f54eeb335c7fa3110a6c78e125b977b959e4108214cc306",
      "validator_network_address": "/dns4/val3-libra-validator-validator-lb/tcp/6179",
      "full_node_network_identity_public_key": "94ab831d3f33d36798e91a1b5be6c456cefe53a9d748b70d05050dad98405061",
      "full_node_network_address": "/dns4/val3-libra-validator-fullnode/tcp/6182"
    }
  }
]

Failures
$ cargo run -p libra-operational-tool -- validator-set --config not-a-file
Unable to load config: No such file or directory (os error 2)

$ cargo run -p libra-operational-tool -- validator-set --json-server "facebook.com"
Failed to read 'account-state' from JSON-RPC: JSON RPC call failed with response: Connection Failed: Connection refused (os error 61)

gnazario-mbp:libra gnazario$ cargo run -p libra-operational-tool -- validator-set --json-server "http://facebook.com"
Failed to read 'account-state' from JSON-RPC: JSON RPC call failed with response: <!DOCTYPE html>...

$ cargo run -p libra-operational-tool -- validator-set --json-server "http://facebook.com:2020"
Failed to read 'account-state' from JSON-RPC: JSON RPC call failed with response: Network Error: timed out reading response

I know you shared this internally, but it would be good to share outputs of these type of things in the PR / commit.

Done, I added an output.
I think this will be an iterative process, because the cluster at some point yesterday started rejecting my requests, and I'll try troubleshooting again today to make sure everything is okay

/help

@bors-libra r=davidiw

:pushpin: Commit 8148613 has been approved by davidiw


correct intel blocksize

Intel forgot how to count, this corrects those block sizes

@mikemrm: wat? flabs vs flbas?

@mikemrm: wat? flabs vs flbas?

😬  prs welcome :)

:laughing: whoops :grimacing:


Please read & provide the following

When I try to run the demo code on my custom video, I am getting the following error:
Traceback (most recent calls WITHOUT Sacred internals):
File "src\track.py", line 189, in main
write_images, generate_attention_maps)
File "E:\trackformer-main\src\trackformer\util\track_utils.py", line 146, in plot_sequence
cmap = rand_cmap(mx, type='bright', first_color_black=False, last_color_black=False)
File "E:\trackformer-main\src\trackformer\util\track_utils.py", line 94, in rand_cmap
random_colormap = LinearSegmentedColormap.from_list('new_map', randRGBcolors, N=nlabels)
File "C:\Users\admin\AppData\Roaming\Python\Python37\site-packages\matplotlib\colors.py", line 796, in from_list
if (isinstance(colors[0], Sized) and len(colors[0]) == 2
IndexError: list index out of range

metoo

There are several issues on this matter. Please look at https://github.com/timmeinhardt/trackformer/issues/26


WFLY-10886: change AbstractJMSContext.getContext from synchronized me…

Change AbstractJMSContext.getContext from synchronized method to ConcurrentHashMap for improved performance
https://issues.redhat.com/browse/WFLY-10886
PR for 26.x: https://github.com/wildfly/wildfly/pull/15036

Hello, fbrandaouolinc. I'm waiting for one of the admins to verify this patch with /ok-to-test in a comment.

@darranl here is the PR agains main https://github.com/wildfly/wildfly/pull/15036
Reference: https://github.com/wildfly/wildfly/pull/15036
Thanks!

/ok-to-test

Hi @fbrandaouolinc -- thanks for your contribution! It looks like this is your first to WildFly, so I have a paperwork question for you:
We require that all contributions be made under the terms of the MIT License, http://www.opensource.org/licenses/mit-license.php. Do you agree to the these terms?

Thanks, @fbrandaouolinc!


ReferenceError: module is not defined

When running the frontend yarn dev command, I get the error below.
Steps to reproduce the behavior:

Go to frontend folder
execute: yarn
execute: yarn dev

Immediately after executing the yarn dev command, I get a message that says:
 ERROR                                                                                16:31:02
[TypeScript] Found 0 errors. Watching for file changes.

Then when I navigate to http://localhost:5173/, it crashes with the following output:
(base) user@192 frontend % yarn dev
yarn run v1.22.22
warning ../../../package.json: No license field
$ vite
                                                                                16:31:00
  VITE v4.5.0  ready in 544 ms

  ➜  Local:   http://localhost:5173/                                                                                16:31:00
  ➜  Network: use --host to expose                                                                                16:31:00
  ➜  press h to show help                                                                                16:31:00

 ERROR                                                                                16:31:02
[TypeScript] Found 0 errors. Watching for file changes.

 WARN  Browserslist: caniuse-lite is outdated. Please run:                                                                       16:31:37
  npx update-browserslist-db@latest
  Why you should do it regularly: https://github.com/browserslist/update-db#readme

 ERROR  (node:91140) ExperimentalWarning: CommonJS module /Users/user/Desktop/screenshot-to-code/frontend/node_modules/tailwindcss/lib/lib/load-config.js is loading ES Module /Users/user/Desktop/screenshot-to-code/frontend/tailwind.config.js using require().
Support for loading ES Module in require() is an experimental feature and might change at any time
(Use `node --trace-warnings ...` to show where the warning was created)

file:///Users/user/Desktop/screenshot-to-code/frontend/tailwind.config.js:2
module.exports = {
^

ReferenceError: module is not defined
    at file:///Users/user/Desktop/screenshot-to-code/frontend/tailwind.config.js:2:1
    at ModuleJobSync.runSync (node:internal/modules/esm/module_job:395:35)
    at ModuleLoader.importSyncForRequire (node:internal/modules/esm/loader:329:47)
    at loadESMFromCJS (node:internal/modules/cjs/loader:1376:24)
    at Module._compile (node:internal/modules/cjs/loader:1528:5)
    at Object..js (node:internal/modules/cjs/loader:1698:10)
    at Module.load (node:internal/modules/cjs/loader:1303:32)
    at Function._load (node:internal/modules/cjs/loader:1117:12)
    at TracingChannel.traceSync (node:diagnostics_channel:322:14)
    at wrapModuleLoad (node:internal/modules/cjs/loader:218:24)
    at Module.require (node:internal/modules/cjs/loader:1325:12)
    at require (node:internal/modules/helpers:136:16)
    at /Users/user/Desktop/screenshot-to-code/frontend/node_modules/tailwindcss/lib/lib/load-config.js:35:27
    at loadConfig (/Users/user/Desktop/screenshot-to-code/frontend/node_modules/tailwindcss/lib/lib/load-config.js:39:6)
    at getTailwindConfig (/Users/user/Desktop/screenshot-to-code/frontend/node_modules/tailwindcss/lib/lib/setupTrackingContext.js:71:116)
    at /Users/user/Desktop/screenshot-to-code/frontend/node_modules/tailwindcss/lib/lib/setupTrackingContext.js:100:92
    at /Users/user/Desktop/screenshot-to-code/frontend/node_modules/tailwindcss/lib/processTailwindFeatures.js:48:11
    at plugins (/Users/user/Desktop/screenshot-to-code/frontend/node_modules/tailwindcss/lib/plugin.js:38:69)
    at LazyResult.runOnRoot (/Users/user/Desktop/screenshot-to-code/frontend/node_modules/postcss/lib/lazy-result.js:329:16)
    at LazyResult.runAsync (/Users/user/Desktop/screenshot-to-code/frontend/node_modules/postcss/lib/lazy-result.js:258:26)
    at LazyResult.async (/Users/user/Desktop/screenshot-to-code/frontend/node_modules/postcss/lib/lazy-result.js:160:30)
    at LazyResult.then (/Users/user/Desktop/screenshot-to-code/frontend/node_modules/postcss/lib/lazy-result.js:404:17)

Node.js v23.3.0
error Command failed with exit code 1.
info Visit https://yarnpkg.com/en/docs/cli/run for documentation about this command.

Edit: I am running MacOS 15.1 M2 chip.
Edit 2: I only set OpenAI key, I do not intend to use both APIs.

You can safely ignore the first "ERROR"
The module is not defined error is often due to some yarn/node configuration on your end. It's a really annoying error that I sometimes get (with other projects) but I can never remember what the fix is.
Claude suggests this but I'm not sure if it will fix your problem.

Renaming to .cjs worked! You think it should be defaulted to it or is it going to break other platforms?

Awesome, I'll wait to hear more complaints before updating it.

Renaming to .cjs works for me as well. Changing to "export default" still got errors on my device.


Build issue with storybook 7 react vite

Thank you so much for building this addon, it's been a massive help!
I was trying to move to react vite and I'm seeing the following error when I run a storybook build... Don't know if you'll have any idea or even have the capacity to fix it.

hello i also have the same error

@lucianobarauna @adrianaferrugento thanks for reporting.  Seems like storybook build command doesn't support ES modules. The problem is fixed in 0.1.11 version. Sorry for the inconvenience.


Allow link navigation in tutorials

mozilla/thimble.webmaker.org#1277
This won't work until we figure out how to handle the injection of the <base> tag into the preview iframe which changes the base url for all relative paths inside the iframe to the thimble url and screws things up

@humphd re-r?

@humphd fixed!

One suggestion, this looks good otherwise. r=me

cool thanks


Improvements on Variable Watchers and Hook Functionality in Rekajs Library

Hello,
I am reaching out again to bring another issue to your attention that I've encountered while using your library.
I've been trying to implement a watcher to observe changes in variables. However, I'm finding that this feature isn't working as expected. It appears as though hooks are only functional within the scope of components. If this is the case, it significantly limits the ability to track changes in data outside the component.
Once again, I want to express my gratitude for your work on this library. Thank you for your time in reviewing these issues.
Best regards,

Could you provide some examples on the issues you're having?

Thank you @prevwong   for your prompt response and asking for clarification. I'd be happy to provide a more detailed example to illustrate the issue I'm encountering with variable watchers.
Here's a corrected and more detailed example:
reka.listenToChanges((payload) => {
  console.log('payload =>', payload);
  if (payload.event !== 'change') {
    return;
  }
});

setTimeout(() => {
  const appComponent = reka.program.components[0];
  reka.change(() => {
    t.assert(appComponent.template, t.TagTemplate).tag = 'button';
    reka.program.globals[0].init.value = 100;
  });
}, 1000 * 2);

In this case, I'm correctly receiving the log for the addition of the button and the change in the globalText variable. However, when I try to increment globalText inside Rekajs using the following code:
onClick: t.func({
  params: [],
  body: t.block({
    statements: [
      t.assignment({
        left: t.identifier({ name: 'globalText' }),
        operator: '+=',
        right: t.literal({ value: 1 }),
      }),
    ],
  })
});

I'm not receiving the expected change hook. I hope this provides a clearer illustration of the issue I'm encountering.
If there's any additional information you need, please let me know. I'm hoping this issue can be addressed to enhance the effectiveness of the variable watcher feature in your library.
Thank you for your time and assistance.

Perfect it works : reka.head.env.getByName('globalText')
yes, autocompletion will be great.
Thank you


Change GitHub actions to use Nix

We already define a flake for the development environment, we should use it for GitHub actions instead of having to sync the Go version in the Go action YAML.

https://github.com/marketplace/actions/install-nix


Upgrade kafka to 2.4.1

Automation fails with:
[INFO] --- maven-dependency-plugin:3.1.1:analyze-only (default) @ tempto-kafka ---
[WARNING] Unused declared dependencies found:
[WARNING]    org.apache.kafka:kafka_2.12:jar:2.4.1:compile
[INFO] --------------------------------------------------------

FYI, tested presto product tests locally using this version and I no longer get the class not found exceptions (for presto pr #3941). Once this looks ok and lands I will update that pr to use tempto 180.

I didn't check if there is a PR for that and I've made https://github.com/prestosql/tempto/pull/56 which was merged.

Sorry @elonazoulay

Sorry @elonazoulay

No need to be sorry, you fixed the issue:)

@kokosing , @wendigo - just some minor changes now. Let me know what you think.

Merged, thanks!


Django Admin:  in TolaUser admin page, countries should be in alphabetical order

I'm only filing the ticket to note that I did this and that it can be undone if need be.

Validated.