Unknown Session Key Exception

I have added all my existing asp.net webforms session keys in both .net core startup and asp,net webfroms global.asax file.
However while running the file, its giving me "UnknownSessionKeyException: Unknown session keys" error.
I am adding the session keys as "options.KnownKeys.Add("UserApplicationId", typeof(int));"
Can anyone please help?

Do you have a repro? From what you are sharing it seems that there may be a session key you are not aware of - do you have any code that you may not own that would be using session? The exception should be sharing missing key information.
If you would like to ignore session keys that are unknown, you can set SessionSerializerOptions.ThrowOnUnknownSessionKey   = false. This defaults to true on the .NET Core side and false on the .NET Framework side.

Where in the code can I access this property? ThrowOnUnknownSessionKey

When registering things into the service collection:
builder.Services.AddSystemWebAdapters()
    .AddSessionSerializer(options =>
    {
        options.ThrowOnUnknownSessionKey = true;
    })

Thanks for that. I am not getting the unknown session error anymore. Anyway still have trouble. Every time that I access the session object from my Asp.Net Core application (either reading or writing), session information is lost on the Asp.Net MVC app.
Here is my full program.cs
var builder = WebApplication.CreateBuilder(args);
var ProxyTo = builder.Configuration["ProxyTo"];
var RemoteAppApiKey = builder.Configuration["RemoteAppApiKey"];
builder.Services.AddSystemWebAdapters()
.AddJsonSessionSerializer(options =>
{
options.RegisterKey("DatabaseName");
})
.AddSessionSerializer(options =>
{
options.ThrowOnUnknownSessionKey = false;
})
.AddRemoteAppClient(options =>
{
options.RemoteAppUrl = new(ProxyTo);
options.ApiKey = RemoteAppApiKey;
})
.AddSessionClient();
builder.Services.AddHttpForwarder();
// Add services to the container.
builder.Services.AddControllersWithViews();
var app = builder.Build();
if (!app.Environment.IsDevelopment())
{
app.UseHsts();
}
app.UseHttpsRedirection();
app.UseStaticFiles();
app.UseRouting();
app.UseAuthorization();
app.UseSystemWebAdapters();
app.MapDefaultControllerRoute()
.RequireSystemWebAdapterSession(); // This enables session sharing on all controllers
app.MapForwarder("/{**catch-all}", ProxyTo)
.Add(static builder => ((RouteEndpointBuilder)builder).Order = int.MaxValue);
app.Run();

And here is the section on my Global.Asax Application_Start() on the Asp.Net MVC App that configs session sharing:
        //Configure .Net Core Session Sharing
        {
            var RemoteAppApiKey = ConfigurationManager.AppSettings["RemoteAppApiKey"];

            SystemWebAdapterConfiguration.AddSystemWebAdapters(this)
                .AddJsonSessionSerializer(options =>
                {
                    options.RegisterKey<string>("DatabaseName");
                })
                .AddRemoteAppServer(options =>
                {
                    options.ApiKey = RemoteAppApiKey;
                })
                .AddSessionServer();
        }

I had the same problem, and I finally could make it work by checking multiple examples of how people are using SystemWebAdapters.
Here is the code of my ASP.NET Core startup class:
public void ConfigureServices(IServiceCollection services)
{
	  services
		.AddSystemWebAdapters()
		.AddJsonSessionSerializer(options =>
		{
			options.RegisterKey<string>("Example1");
			options.RegisterKey<int>("Example2");
		})
		.WrapAspNetCoreSession()
		.AddSessionSerializer()
		.AddRemoteAppClient(options =>
		{
			options.RemoteAppUrl = new(LegacyUrl);
			options.ApiKey = SessionApiKey;
		})
		.AddSessionClient()
		.AddAuthenticationClient(true);

	services.AddHttpForwarder();
	services.AddDistributedMemoryCache();

	services.AddHttpClient();
	services.AddHttpContextAccessor();

	services.AddCors(opt =>
	{
		opt.AddDefaultPolicy(builder =>
		{
			builder.AllowAnyOrigin()
				.AllowAnyHeader()
				.AllowAnyMethod();
		});
	});

	services.AddRouting();
	services.AddControllers().AddJsonOptions(opts => opts.JsonSerializerOptions.PropertyNamingPolicy = null);

	services.Configure<JsonOptions>(options =>
	{
		options.SerializerOptions.PropertyNameCaseInsensitive = true;
		options.SerializerOptions.PropertyNamingPolicy = null;

		options.SerializerOptions.WriteIndented
#if DEBUG
			= true;
#else
			= false;
#endif
	});

	// services.AddHereYourIoC();
	// services.AddHostedService<YourBackgroundService>();
}

public void Configure(IApplicationBuilder app, IWebHostEnvironment env)
{
	if (env.IsDevelopment())
	{
		app.UseDeveloperExceptionPage();
	}
	else
	{
		//app.UseExceptionHandler("/Error");
	}

	app.UseHttpsRedirection();
	app.UseRouting();
	app.UseSession();
	app.UseAuthorization();
	app.UseSystemWebAdapters();
	app.UseEndpoints(endpoints =>
	{
		endpoints
			.MapDefaultControllerRoute()
			.RequireSystemWebAdapterSession();

		endpoints
			.MapForwarder("/{**catch-all}", LegacyUrl)
			.Add(static builder => ((RouteEndpointBuilder) builder).Order = int.MaxValue);
	});
}

And here is the code of my ASP.NET WebForms global.asax class:
protected override void Application_Start(object sender, EventArgs e)
{
	SystemWebAdapterConfiguration.AddSystemWebAdapters(this)
		.AddProxySupport(options =>
		{
			options.UseForwardedHeaders = true;
		})
		.AddJsonSessionSerializer(options =>
		{
			options.RegisterKey<string>("Example1");
			options.RegisterKey<int>("Example2");
		})
		.AddRemoteAppServer(options => options.ApiKey = SessionApiKey)
		.AddSessionServer()
		.AddAuthenticationServer();

	base.Application_Start(sender, e);
}

Keep in mind that the SessionApiKey needs to be a Guid of the same value in both projects.

Another thing that also I noticed is when I was trying to register nullable primitives I got the Exception as well, for example: .RegisterKey<int?>("Example1");. So I'm avoiding using nullable primitives in Sessions.
Before I forget: remember to add the set keyword on getters, i.e.: { get; set; } on properties of complex objects (classes, structs, records) that are stored in Sessions. Otherwise, the serializer will not be able to fill the properties' values. That took some of my time to figure out why one side was showing values and the other side was not.

@luismauricedecastro Looks like your registration is a different between the two apps; on framework you are doing:
options.RegisterKey<string>("DatabaseName");

while on ASP.NET Core you are doing:
options.RegisterKey("DatabaseName");

Notice that you are not adding the <string> so the serializer is assuming it to just be an object.
@lucaslorensetti  I've created a new issue to track the nullable support. Thanks for raising that point!

We haven't heard anything, so I'm closing this issue for. Please reopen if it's still an issue.


Dockerfile for Le Wagon students

Hi @nonken,
Here is my first attempt for a dedicated Le Wagon setup, I also pushed it on Docker Hub:
https://hub.docker.com/r/lewagon/c9workspace/
Thanks!

Thanks, I'm going to patch up a few things on this in a seperate PR. Merging this so we can move forward though.


Fix link to "What's new in Zigbee 3.0

Old white paper file is not available anymore. But version ending with "a" is available - at least right now.

Thanks!


Update README.md

Need to find out who can access this!!!

Hello  how does one add a repo to here?


Dragon tests

Nice job with the test!  its time for this final merge on your task nicely done Sergio.


[Bug]: Error when connecting with username and password

What happened?
Hello,
When I try to connect using a username and password to an on-premise environment, I receive the error below.
I tried domain\username and username@domain, both failed.
Dynamics is the latest version.
What version of the tool are you using?
2.2.0
What version of Visual Studio Code are you running?
1.85.1
Any relevant session id from VSCode?
554def50-7d92-404d-b047-818a29c92b6a1705154185667
Relevant log output
VSCode version: 1.85.1.
Extension version: 2.2.0.
Error occured in connectDataverse command.
Error code: undefined.
Error message: undefined.
Error stack: undefined.

The extension is not supported for on-prem org. Sorry.


Fix reference to phpunit script

In order for the pipeline to run the phpunit binary pulled in with Composer in the pipelines-php repo, we need to reference the phpunit shell script in the root of the repo.
This accompanies https://github.com/MicrosoftDocs/pipelines-php/pull/3
#4011

@erichmusick : Thanks for your contribution! The author(s) have been notified to review your proposed change.

@vijayma - Would you review the proposed revisions to your article? Thanks.

@vijayma Thanks for the review


Google Docs integration

Are you open to PRs?
Because I need to implement something to import a google spreadsheets and the libs I already found are very opinionated on the way to connect with google! One forces you to make the spreadsheet public, but the spreadsheet is not mine, and the other one forces you to create a service account and share the spreasheet through it, but again, the spreadsheet is not mine!
This lib is the best for Google API integrations for what I've searched and I will contribute with some Google Docs integration if you allow me!

PS.: I'll need some token generation for private spreadsheets access too.

PS.: I'll need some token generation for private spreadsheets access too.

Forget it! Ueberauth is good enough for OAuth2 token generation. I'll implement the Google SpreadSheet API client and get back with a PR soon!

@kelvinst yeah I am definitely open to PRs. I would be happy to take your PR in for supporting spreadsheet stuff. thanks!


modelFor return undefined, in deactivate route event

I have an ember app, and here is the routing for messages
this.route('messages', function() {
   this.route('list');
   this.route('new');
   this.route('edit');
});

in the messages.list route, while deactivating the route, following code snippet is running,
discardFilter: on('deactivate', function() {
    let model = this.modelFor('messages.list');
    set(model, 'filterUnstable', false);
  }),
model() {
    return RSVP.hash({
      contacts: get(this, 'store').findAll('message'),
      filterUnstable: true
    });
  }

here, on discardFilter, this.modelFor('messages.list'); return the object from model hook.
the same app, i am converting the messages to the engines, in the host app, mounting the route as
this.mount('message-engine', {as: "messages"});,
and inside the engines building the route as following:
export default buildRoutes(function() {
    this.route('list');
    this.route('new');
    this.route('edit');
});

and inside the routes/list, while deactivating the routes, the same code snippet return undefined, below is the code snippet,
discardFilter: on('deactivate', function() {
    **let model = this.modelFor('list');** // _return undefined here_
    set(model, 'filterUnstable', false);
  }),
  model() {
    return RSVP.hash({
      messages: get(this, 'store').findAll('message'),
      filterUnstable: true
    });
  }

Node and ember version
node: 8.16.0,
npm: 6.4.1,
ember-cli: 2.15.1,
ember-data: 2.15.4

while debugging, i have found inside the message engines Ember.getOwner(this).lookup("route:messages.list") return undefined,  while Ember.getOwner(this).lookup("route:list") return the router instance object.
modeFor in the route.js, have same prefixed with the mounting path name, cause the lookup instance to return undefined.

See https://github.com/emberjs/ember.js/issues/17419 for related info


Use setuptools rather than distutils

setup.py has:
import distutils
from distutils.core import setup

According to https://setuptools.pypa.io/en/latest/deprecated/distutils-legacy.html this should be
from setuptools import setup

Fixed with #47


Add FI countermeasures for sensitive switch instructions

Signed-off-by: Piotr Nowicki<EMAIL_ADDRESS>Description
This PR contains FI attacks countermeasures for security-sensitive switch instructions
Status
REDY

@piotr-now , I am not sure we need delays and double checks in TLS handshake  steps, TLS  state shouldn't be secret and it is increasing code size .
It seems that the only critical place is certificate chain verification.
@AndrzejKurek , what do think about it ?

@piotr-now , I am not sure we need delays and double checks in TLS handshake steps, TLS state shouldn't be secret and it is increasing code size .
It seems that the only critical place is certificate chain verification.
@AndrzejKurek , what do think about it ?

Actually, I can agree with you. After skipping some steps, the connection will not be possible because the individual structures required for communication will not be initialized. On the other hand, I'm not sure if this applies to all steps and cases.

I think that adding delays anywhere should be discussed, as it slows down the application and only critical places should be affected.
Also - if we're prioritizing code size now, then we should only apply the ssl_parse_certificate_chain part.

I reversed the changes from the files ssl_srv.c and ssl_cli.c and rebased this branch to the newest baremetal.
Just in case I created a copy of the previous changes here: https://github.com/piotr-now/mbedtls/commits/fic_switch_old


News bot[GSSoC'23]

Hi @neelshah2409
I want to contribute to this repo by adding a news bot that fetches and displays the latest news headlines from different sources. Users can specify their interests or categories to get news tailored to their preferences. News APIs like NewsAPI or RSS feeds can be used to fetch the news.
It would be great if I could be assigned to this issue.
Thanks

Please assign this to me as a GSSOC contributor.

issue assigned to @Somya-Singhal

Thanks @Shubhanshu156 . Will start working on it.


Inexplicable dependencies for different versions of VIE

Demos come along with own builds of VIE (vie-latest-debug.js without version info). Different VIE versions need different versions of referenced JavaScript libraries.

I think this is resolved as soon as we finally push out a 2.0

Do you mean the different versions of VIE or the different version of its dependencies?

I mean both:

Version of VIE
Version of deps
Nice to have

[1] The timstamp in the file name (that can easily be renamed) of a vie compilation helps to identify the date vie is builded, maybe one should write it also into a comment of the Javascript file.
[2] VIE as software component that depends on external libraries that are not included inside the compilation itself should have something like a manifest that refers to the exact versions of dependencies.
[3] It would be nice to know what feature needs which libs


Something went wrong during updating

Microsoft PowerToys version
<IP_ADDRESS>
Running as admin

[X] Yes

Area(s) with issue?
Installer
Steps to reproduce
Version: <IP_ADDRESS>
OS Version: Microsoft Windows NT 10.0.18363.0
IntPtr Length: 8
x64: True
Date: 05.07.2021 08:45:25
Exception:
System.UnauthorizedAccessException: Access to the registry key 'HKEY_CURRENT_USER\SOFTWARE\Classes\CLSID{dd5cacda-7c2e-4997-a62a-04a597b58f76}\LocalServer32' is denied.
at Microsoft.Win32.RegistryKey.Win32Error(Int32 errorCode, String str)
at Microsoft.Win32.RegistryKey.CreateSubKeyInternalCore(String subkey, RegistryKeyPermissionCheck permissionCheck, RegistryOptions registryOptions)
at Microsoft.Win32.RegistryKey.CreateSubKey(String subkey, RegistryKeyPermissionCheck permissionCheck, RegistryOptions registryOptions)
at Microsoft.Win32.RegistryKey.CreateSubKey(String subkey)
at Microsoft.Toolkit.Uwp.Notifications.DesktopNotificationManagerCompat.RegisterComServer[T](String exePath)
at Microsoft.Toolkit.Uwp.Notifications.DesktopNotificationManagerCompat.RegisterAumidAndComServer[T](String aumid)
at Wox.PublicAPIInstance..ctor(SettingWindowViewModel settingsVM, MainViewModel mainVM, ThemeManager themeManager)
at PowerLauncher.App.<>c__DisplayClass13_0.b__0()
at Wox.Infrastructure.Stopwatch.Normal(String message, Action action)
at PowerLauncher.App.OnStartup(Object sender, StartupEventArgs e)
at System.Windows.Application.OnStartup(StartupEventArgs e)
at System.Windows.Application.<.ctor>b__1_0(Object unused)
at System.Windows.Threading.ExceptionWrapper.InternalRealCall(Delegate callback, Object args, Int32 numArgs)
at System.Windows.Threading.ExceptionWrapper.TryCatchWhen(Object source, Delegate callback, Object args, Int32 numArgs, Delegate catchHandler)
✔ Expected Behavior
Updating software
❌ Actual Behavior
"Something went wrong."
Other Software
No response

The error happens already on the stage where newly installed PT Run is launched. On startup, it tries to register toast notification via registry (see PublicAPIInstance ctor) but gets access denied error to HKCU key.
Judging from the callstack, that happened in Microsoft.Toolkit.Uwp library, and 'HKEY_CURRENT_USER\SOFTWARE\Classes\CLSID{dd5cacda-7c2e-4997-a62a-04a597b58f76}\LocalServer32' seems to miss \ after CLSID.
To verify that whether it's an installation issue, @1v4r, could you please open regedit and go to 'HKEY_CURRENT_USER\SOFTWARE\Classes\CLSID\{dd5cacda-7c2e-4997-a62a-04a597b58f76}\LocalServer32' and check whether you have Allow checked for both Full Control and Read there.
@mykhailopylyp perhaps we've updated Microsoft.Toolkit.Uwp recently which now has this bug?

perhaps we've updated Microsoft.Toolkit.Uwp recently which now has this bug?

We had this issue reported for previous versions so don't think it's a case

Looks like duplicate of https://github.com/microsoft/PowerToys/issues/11216


Use new types for event instead of a dictionnary in the code

Is your feature request related to a problem? Please describe.
Not really a problem, this is more an idea in sake of making the code more robust and less error prone.
Currently, a dictionary used for events could have typos in the keys or wrong types in the values which would lead to non trivial error at runtime.
Describe the solution you'd like
Instead of having a dictionary, we could have
An Event type  (extends reference)
Subtypes (extending Event) for every type of event
example :
class DialogicTextEvent:
    extends DialogicEvent
    var character := ""
    var text := ""
    func _init(...):
        ... # possibly some sanity checks, error on creation is is invalid
    func has_character(...):
        return self.character != ""

Pushing things further we could use one of the class abstraction of godot-next but i have not investigated that yet ;)
Its quite a bit of work but i would be interested in helping ~~
Was that clear? what do you think?
EDIT:
plus instead of checking the type by matching against "dialogic_001", the neater syntax event is DialogicTextEvent could be used.
Also, if performance is an issue, this might improve it a little?

The main idea behind checking against string names is to make a better integration with custom events. The issue with classes is that they have to be previously declared to be interpreted by the checks we need to have. So if you have a custom event it is better to check against strings that having to create so many classes and sub classes.
Unless I'm missing something I don't think that we would be creating those kind of event classes at the moment unless there is a strong argument for it.
Thanks for the issue! I'll leave it open just in case someone wants to pitch in or if you have any extra considerations

I see your point, although there could be a DialogicCustomEvent class with a dictionary field, which would offer the same integration for custom event in my opinion!
The idea is, since everything is represented as a string (even the type of errors) a typo in the code of dialogic or the user could lead to nonsensical behavior and I'm a little shaky about that (being paranoïd i guess).
It's a quality of life improvement, makes the code more sound and stuff. But i get that its also extra work for no added feature (although i'm here to help ;) ).
Was that convincing? 😇

This can be related to https://github.com/coppolaemilio/dialogic/issues/10 (not resources, just the part to serialize the data to a class).


Fix mochi cards URL

Fix the mochi cards URL in the "Spaced Repetition for Mathematics" post
→ https://hugo-git-fork-tk-notes-mochi-cards-link-lcs-meiers-projects.vercel.app/posts/2021/02/spaced-repetition-for-mathematics/

cc @cronokirby


Scrape PaaS's alpha Elasticsearch metrics endpoint

What
PaaS have deployed a new metrics endpoint which collects all metrics for Digital Marketplace's Elasticsearch instances. This PR adds the new scrape target to the Prometheus config and uses a pass secret as the password for the scrape endpoint.
The scrape config for this endpoint is very large because there are 700+ metrics exposed and we only want to import metrics which we expect to be useful. Future versions of the Elasticsearch exporter will try to improve on that.
How to review
I can't easily deploy this, so I suppose we'll can deploy it to staging and see if it works.
~There's a new secret that will need to go in your pass store. Add me to your pass store or message me privately to get that done.~ Done.

Ready for review.

@philandstuff Added an extra commit doing what you suggested. There's now a lot more moving parts and it'll need trying out by someone with access to the staging environment.


Allow categorical pallette for more than 8 values

The current categorical palette uses the Bokeh colorblind8 palette, which is very limited. Something like this could work better:
from bokeh.palettes import Plasma256
from numpy import unique

def colorize_numeric_list(string_list):
    unique_values, numeric_list = unique(string_list, return_indices=True)
    n_seeds = max(numeric_list) + 1
    n_skips = int(len(Plasma256) / n_seeds) * 2
    palette = Plasma256[::n_skips]
    palette = [x for y in list(zip(palette, reversed(palette))) for x in y]
    colors = [palette[j] for j in numeric_list]
    return colors

The interleaving from different ends of the continuous palette better ensures visual differentiation. The colorblind palette is probably still the best course for cases that involve 8 or fewer categories.

You could consider using the 256-color categorical colormaps at https://colorcet.pyviz.org/user_guide/Categorical.html .  If you want to do a bit of work, you can even seed it with the colorblind8 palette, then generate the other 248 colors to be distinguishable from those, though making them also be colorblind safe would be a good bit more difficult.


Investigate use of PkgLock.jl to avoid race conditions on module precompilation with MPI

You could also use PkgLock.jl to precompile all packages without race conditions and use them afterwards in parallel.
Xref: https://discourse.julialang.org/t/precompilation-error-using-hpc/17094
Originally posted by @ranocha in https://github.com/trixi-framework/Trixi.jl/pull/167#discussion_r499206125
We should check if and how it makes sense to include it in our testing environment, and maybe document it for use on clusters etc.

Maybe we can also just sit this out: https://github.com/JuliaLang/julia/issues/36416

I've tested it on the current Julia nightly: We won't need the flag --compiled-modules=no on Julia v1.6 anymore :tada:

Excellent news! Do you know if there's a tentative release date for 1.6?

The soft feature freeze is today: https://discourse.julialang.org/t/1-6-soft-feature-freeze-nov-8th/49379. Then, we will have the usual release process (finishing works, alpha, beta, iterate RCs until convergence) I guess. Usually, there isn't a tentative schedule for this last part of the process.


Audit trail support

The audit-trail can be enabled with the :enable-audit-trail true config setting. The audit logs will appear in the Fractl_Kernel_Identity__AuditTrailEntry table.

@vijayfractl, the audit trail (while tracked internally), should be in the component of the app, so that the user can access it as Checkout.Core/OrderAudit


e2e: Eliminate flakiness using webdriver.until

The first end-to-end test case ("creates a new short link") was failing rather frequently on Travis CI. This attempts to remove the flakiness by using conditions from webdriver.until with webdriver.wait, both by waiting for links to appear before waiting for them to receive focus (in waitForActiveLink) and by using until.urlIs to wait for the URL to change after a click.
Also replaced https://foo.com/, etc. with targetLocation after noticing that some failing tests caused the actual http://baz.com to appear.

Coverage remained the same at 97.999% when pulling 12db2cc10772e129bd1b4ab4c197b3f91d31af50 on stabilize-e2e into 9126967e947d3ef7ffcec9438c5aa31ce2aab266 on master.

Coverage remained the same at 97.999% when pulling 0cd9bb172119bd8106dafc9141e39b32ae8a86cf on stabilize-e2e into 9126967e947d3ef7ffcec9438c5aa31ce2aab266 on master.


chore(tests): organise fixtures

This PR introduces macro fixtures (that allow less boilerplate code) and an env-variable that enforces running of the tests under experimental-api crate.
Going further, the env-var based approach allows making sure that tests are always compiled and always run according to the environment variables being set, which potentially gives better maintainability and flexibility compared to conditional compilation based test selection.

Follow up: https://github.com/eigerco/beerus/issues/648

Looks good to me, nice macros. Just to double check it, integration-tests-alchemy are now run only each day at 8 o'clock, instead of every time a push on branch occurs?

Yes, push trigger disabled, cron one changed from 08:00 & 20:00 daily to only 08:00 daily.


ngf-src should take advantage of the URL.createObjectURL for greater …

…mobile browser support
using URL.createObjectURL permits previewing large files on device that support it and improves
the preview speed.
URL.createObjectURL is currently supported by major mobile web browsers.
Without it, trying to preview some video files mostly crashes on mobile web browser.
var url = window.URL || window.webkitURL;
if(url && url.createObjectURL){
	elem.attr('src', url.createObjectURL(file));
	return;
}

Fixed in version 4.2.3
Thanks for the PR.


Explicitly declare ECMAScript version

I'm using async/await and I'm seeing this warning:

I'm not sure what Electron defaults to, but it would ideal to explicitly enable support for ES2017 language features if possible. This feature is working currently, it's just a warning.

this is "fixed" on dev.cables.gl and will be in the next standalone release


ERR_PNPM_RECURSIVE_RUN_FIRST_FAIL<EMAIL_ADDRESS>dev: vite

when I run "npm run pictode" some error occured

when I run "npm run pictode" some error occured

Install pnpm first

npm install -g pnpm

Install dependencies

pnpm bootstrap

Start the project

pnpm pictode


minor

@agba-merger please merge this PR by 2023-02-01 00:05

Hi @agba-merger please merge this pull request on 2023-02-01 00:10

Hi @agba-merger please merge this pull request on 2023-02-01 00:20

Hi @agba-merger please merge this pull request on 2023-02-01 00:25


Pass cdp options to CDP.new()

pass the cdp options from the instantiation to CDP.new()

Thanks for creating this PR @liady! Passing this in makes sense, besides one option which is closeTab https://github.com/graphcool/chromeless/blob/master/src/types.ts#L22
We first should move closeTab to a different place in the options, then this PR can be merged.
I create a seperate issue for that task

@timsuchanek do you prefer moving closeTab one level higher, to the root options object? Won't it break users' code that is currently using this API?

Just merged another PR, might have some conflicts, let me know if I can help

@liady that's a fair point. We discussed it with the maintainers and concluded, that closeTab should still live in the CDP option.
We should, however, filter that option out before passing into CDP.New
With something along the lines
// filter out closeTab
const {host, port, secure} = this.options.cdp
CDP.New({host, port, secure})

Could you incorporate that? Thanks!

@timsuchanek thanks, changed.
@joelgriffith can you please review my conflict resolving to see if they comply with your PR?


Split ContractSourceManager from ContractManager

Before this PR, there were two ways to create a ContractManager object, with sources and with precompiled json file.  This PR splits the two uses into two different classes.
This closes #695.

Codecov is not happy.  Writing tests.


class CommentResolveResponse(BaseApiModel) is not in API docs

classes CommentResolveResponse and PostResolveResponse are not in the API docs and don't appear to be referenced anywhere in PyLemmy.
Should they be removed?  Are they used?

Indeed I also can't find them. Maybe they were in the docs at some point but are no longer needed? Feel free to remove them if the tests keep passing:)


[Machine Learning] Hyperparameter Tuning of Machine Learning Model in Python

Proposed title of article
[Machine Learning] Hyperparameter Tuning of Machine Learning Model in Python
Proposed article introduction
Hyperparameters are parameters that can be fine-tuned and adjusted in order to improve the performance of a machine learning model. Various machine algorithms such as RandomForest and K-nearest neighbor algorithms have parameters that can be adjusted to achieve an optimized model.
In the process of hyperparameter tuning, we create a list of all possible values for hyperparameters.  We then iterate through the list trying to find a random combination of hyperparameters, record the performance of each parameter, and finally return the combination of hyperparameters that will provide an optimal model with the optimal solution.
Finding and tuning the right hyperparameters for any machine learning model is a very crucial aspect of today's development. We have to reduce the model loss function and in the end, we have a better model. We have various techniques for hyperparameter tuning: Random Search, Grid Search, Bayesian Optimization, and Tree-structured Parzen estimators (TPE).
Key takeaways

What is hyperparameter tuning.
Various techniques and methods used for hyperparameter tuning.
Building a machine learning model using RandomForest.
Fine-tuning RandomForest parameters.
Implementing various techniques and methods for hyperparameter tuning.

Article quality
This tutorial is a practical guide, explaining everything from scratch with a step-by-step guide that is easier to follow. This tutorial also uses two approaches in building the model, In the First approach we build a model without tuning and in the second approach, we will fine-tune the parameters to increase the model accuracy.
The tutorial will also discuss the methods for hyperparameter tuning in detail.
References
Please list links to any published content/research that you intend to use to support/guide this article.
Conclusion
Finally, remove the Pre-Submission advice section and all our blockquoted notes as you fill in the form before you submit.
We look forwarding to reviewing your topic suggestion.
Templates to use as guides

How To Guide Template
Software Review Template
Tutorial Template

Great topic 🚀 , make sure it matches the following:

Adds value beyond what is in the official docs and what is covered in other blog sites.
To avoid potential article closure, it should not overlap with existing EngEd articles or incoming topic suggestions.

Please reference any relevant EngEd articles in yours and build a unique project - Approved.


Generate the source code reference

Proposed changes

Add a docusaurus renderer here: https://github.com/RasaHQ/pydoc-markdown/pull/1
This renderer autogenerates the docs + a sidebar. We can include this sidebar in our sidebar conf and magic happens

Checklist

[ ] some docs will need revamping, either do it on this PR or in a separate PR with CSE

merged since it already passed tests


[tool.uv.sources] can't be used as [sources] in uv.toml

As mentioned in the docs, tool.uv.sources works fine for specifying sources overrides, but it seems that [sources] in uv.toml does not.
Confusingly, using tool.uv.sources and a uv.toml doing other things throws this warning:
warning: Found both a `uv.toml` file and a `[tool.uv]` section in an adjacent `pyproject.toml`. The `[tool.uv]` section will be ignored in favor of the `uv.toml` file.

However, it actually works fine to have it split among the two files.
Let me know if you need more to reproduce, but it should be straightforward as it's just a config file distinction for all forms of [tool.uv.sources].

Version: uv 0.3.3
Platform: MacOS / Linux
Command: uv sync

Can you share an example of the exact setup you're trying to achieve?

I believe sources need to be in the pyproject.toml alongside the dependencies they annotate.

I believe sources need to be in the pyproject.toml alongside the dependencies they annotate.

Yeah totally, this makes sense generally. The two things that are weird are:

it seems like sources is uniquely inconsistent with the rest of the tool.uv namespace, in that it doesn't support configuration in uv.toml, whereas basically every other property does.
Even if I keep tool.uv.sources in pyproject.toml but put the rest into uv.toml, it still gives that warning.

I'm just using sources for a normal path dependency, nothing special, but I was using uv.toml as my configuration for index-url and extra-index-url. These are urls generated on-demand, not static, so I don't want to put them into source control. Of course, that's another issue because I can't mix pyproject.toml and uv.toml generally, but that was the impotence to start using uv.toml in the first place.

@colinjc -- Can you not put that configuration in a pyproject.toml?

Echoing Colin's usecase - generated, often not source-controlled config is very common in large environments for things like registry configuration that may not be static.

I believe we intentionally don't support this and it will now error (instead of silently ignoring).

I believe we intentionally don't support this and it will now error (instead of silently ignoring).

I would have another use-case for sources in uv.toml: My laptop doesn't have a GPU, so I generally want any pytorch package to be the cpu-only variant. While we can handle this for our local projects via pyproject.toml, if I install external dependencies directly into a fresh venv I have to manually pass the corresponding index url again. Adding the pytorch cpu-only index (without marking it at explicit) is not an option, since it has unintended side-effects unless we use an unsafe index strategy. Being able to explicitly pin pytorch to the cpu index globally via a sources field in the uv.toml would resolve that issue.


Redundant printing of stderr when using exec

Node version (or tell us if you're using electron or some other framework):
v10.11.0
ShellJS version (the most recent version/Github branch you see the bug on):
0.8.2
Operating system:
High Sierra
Description of the bug:
When using synchronous exec for some reason after running the command, exec itself prints exec: [stderr] to console again. I have searched the documentation, the issues, and the code but can't seem to figure out how to silence this. My usage is for react-scripts test via create-react-app and linting with flow. Is it possible to stop this post-exec reprinting of stderr and if not would it be reasonable to request removing this behavior?
Using the silent option for exec does the opposite of what I want. All the output is silenced except this exec: [stderr] reprinting. Setting silent with config kills everything. This is especially troublesome with testing since test cases get printed live then after testing completes, the entire log gets printed again but prefixed with exec: .
 Will be fixed by #861.
CC @uttpal


Add Missing Meta Tags, robots.txt, sitemaps for SEO Enhancement

The current project lacks essential meta tags that are crucial for search engine optimization (SEO). To improve the visibility and ranking of the website on search engines
we need to add the following missing meta tags:
Title tags
Description tags
Keywords tags
Open Graph tags for social media sharing
Robots meta tag
and have to add sitemap.xml and robots file for search engine to crawl our site.

The current project lacks essential meta tags that are crucial for search engine optimization (SEO). To improve the visibility and ranking of the website on search engines
we need to add the following missing meta tags:
Title tags Description tags Keywords tags Open Graph tags for social media sharing Robots meta tag
and have to add sitemap.xml and robots file for search engine to crawl our site.

great ,you can work on it


Optional working preferences questions appear as mandatory on Apply

Describe the bug
It is now possible in Admin to configure working preferences questions as optional, however, on Apply, questions configured this way still appear to be mandatory.
Expected behaviour
Questions marked as optional in Admin should not be mandatory on Apply.
Screenshots
Admin. Configuring working preferences
Note the first question is optional

Apply. Answering working preferences
Note the 'Save and continue' button is disabled. It should not be as the form has sufficient data entered (the first question is optional)

Additional context
The save button only becomes enabled when all questions have been answered. We need to ensure optional questions are excluded from this check.

Hey team! Please add your planning poker estimate with Zenhub @drieJAC @HalcyonJAC @tomlovesgithub @warrensearle

Do we need to preserve existing behaviour for version 1 Working Preferences questions?

@drieJAC I believe WP questions were mandatory for v1. As we haven't fully released v2, I'm not sure when or if there is a cut-off date for exercises using v1. It's possible there could be exercises in draft status that will be using v1, so I suppose, yes, we need to preserve existing behaviour for any exercises using v1.

@nickaddy
I checked the code, the location preferences in v1 seems to be all optional, I'm not sure if it is correct.
Is it ok that we can preserve this behaviour(all optional) in v1, or we can make it all mandatory  in v1?


Homework Detail View: Remove isTeacher from state

We use the type of the currently logged in user to decide wether or not we show the cancel and submit button. This is achieved by saving the type of the user in state - although the type of the current user can be easily identified by calling UserService.isTeacher(), which simply checks the token instead of calling the backend.

I do call UserService.isTeacher() in componentWillMount

I know but why do you use it afterwards as state instead of calling the UserService? In my opinion we should use less state and therefore replace the state with service calls.

This issue is no longer needed since we split the view for different user types #26


Error: 504 on loadPartnerInventory

Hi there!
I'm having a problem with a trade-bot. More in depth, I'm getting error 504 on loadPartnerInvetnory.
Any ideas?

5xx is indicating that the problem is on Steam side.

504 is Gateway Timeout. Just Steam being slow as usual.

It's happening for a while. I mean I thought it should have been fixed by now.

The problem with error 504 seems to have disappeared. Now I'm getting error 405 on getOffers.


chore(ci): fix test pipeline

This PR:

reverts https://github.com/prisma/prisma/pull/23311
introduces https://github.com/prisma/prisma/pull/23352 in its place (which is already known to work on ecosystem-tests)

Deprecated by: https://github.com/prisma/prisma/pull/23366.


Spike: Investigate CNCF Security Slam

/kind user-story
Which area this user story is related to?

/area api
/area library
/area registry
User Story
This Spike story is used to investigate the estimated time required for the CNCF work on Security Slam.
Acceptance Criteria

[ ] Estimate how much time CNCF Security Slam witll take for Defender.

Defender Badge
Requirements - https://github.com/devfile/api/discussions/1283
TODO

[ ] Each project repo is accounted for within CLOMonitor (Need to update clomonitor repo for other repos in the devfile project)
[ ] Ensure proper check set is assigned to each project repo (List of check here and current assignment here)
[ ] Bring security score to 100% for the project (To see a list of the Security related check runs that are available for each checks - refer doc and what action they entail refer doc)

Cleaner Badge
Requirements - https://github.com/devfile/api/discussions/1283
TODO

[ ] Bring all CLOMonitor non-security scores to 100% for the project like Best Practices, Documentation, License, Legal (List of check here and current assignment here)

The Mechanizer Badge
Requirements - https://github.com/devfile/api/discussions/1283
To satisfy this requirement, we need to have an automated mechanism to publish our SBOMs upon every release.  The problem is, our release process  is on demand and because it's infrequent, we've been content with just running our scripts manually.
The webinar mentioned goreleaser which automates the release process and can generate sboms.  This looks interesting and it is something we should look into since there is the potential it can be adopted by our other repos.  We can refer to this example, which uses goreleaser.
TODO

[ ] Investigate goreleaser as a replacement for our manual release process
[ ] adopt goreleaser if it's a viable option

I've considered other alternatives like using one of the recommended sbom generator tools to generate and upload an artifact in our CI workflow but this is not tied to our release process.  We may need to manually download the artifact and drop it whenever we cut a release so I don't think it will satisfy the badge requirements.
Estimated Time:  ~3-4 weeks (assuming everything is straightforward with the investigation)


Clearing pendingImages when the cache is cleared or evicted.

@fhuonder Can you please sign the CLA (see comment above).
/cc @jonahwilliams for review

I signed it!

@goderbauer / @jonahwilliams the CLA is now signed. The label is not updated here despite the "I signed it!".
So in my opinion if a review is ok, it could be merged.

@jonahwilliams ready for review.

@jonahwilliams sorry for bothering you but would it be possible to review this pr so that it can be merged?

Hi @fhuonder, sorry for the delay on this! if you can address the merge conflicts we can rerun the tests and land it.


Update to 1.20.1

I'm pretty sure my work is not the best but it should be good enough to be grounds for the 1.20.1 version of the mod. Currently there are some oddities with the config screen which might be due to owo-ui updates. Closes #11

Looks pretty good, thanks! I'll probably publish this as-is, since I'm more focused on other projects right now.


[Snyk] Upgrade @types/react from 18.0.15 to 18.3.12

Snyk has created this PR to upgrade @types/react from 18.0.15 to 18.3.12.
:information_source: Keep your dependencies up-to-date. This makes it easier to fix existing vulnerabilities and to more quickly identify and fix newly disclosed vulnerabilities when they affect your project.

The recommended version is 116 versions ahead of your current version.

The recommended version was released on a month ago.

[!IMPORTANT]

Check the changes in this PR to ensure they won't cause issues with your project.
This PR was automatically created by Snyk using the credentials of a real user.

Note: You are seeing this because you or someone else with access to this repository has authorized Snyk to open upgrade PRs.
For more information:

🧐 View latest project report
📜 Customise PR templates
🛠 Adjust upgrade PR settings
🔕 Ignore this dependency or unsubscribe from future upgrade PRs

:tada: Snyk checks have passed. No issues have been found so far.
:white_check_mark: security/snyk check is complete. No issues have been found. (View Details)


Defunct Email

hi sorry for bothering you! i believe one of the emails i listed above<EMAIL_ADDRESS>is now defunct—a bunch of people have been contacting me about emails not going through to him. i'd really appreciate it if you could remove his email from the template so that we can successfully spread the word and contact our town's government. thank you so much for your work!!
Originally posted by @erinliao in https://github.com/defund12/defund12.org/issues/484#issuecomment-640148180

removing now!


[discussion] Reducing the size of your browserify builds

So you have browserified your code, and the resulting bundle is much bigger that you would like. What steps do you go through to make it smaller?

Hey Fergus,
Usually:

minify with uglifyjs2
gzip
If you happen to have any large deps, use browserify-shim to load them from a CDN (instead of bundling them)

Thanks @chinedufn! One other thing, to visualize what's taking up space in a bundle, check out disc.


Android Call/Media Volume

When I try to make Dogehouse louder, Android shows me media and call volume, but the sound from Dogehouse just comes through media and the call channel is not used...
Image

That's intended behavior


Updating readme from branch example

Updates
I have updated README file. Please review and accept.

I shouldn't be but okay 👍


IMSI-catcher

Does anyone  knows about this error?
I'm running grgsm_livemon and wireshark in the same time.
root@kali:~/Desktop/IMSI-catcher-master# python simple_IMSI-catcher.py
Nb IMSI ; TMSI-1     ; TMSI-2     ; IMSI              ; country      ; brand      ; operator              ; MCC  ; MNC   ; LAC    ; CellId ; Timestamp
Traceback (most recent call last):
File "simple_IMSI-catcher.py", line 553, in
udpserver(port=options.port, prn=find_imsi)
File "simple_IMSI-catcher.py", line 502, in udpserver
sock.bind(server_address)
File "/usr/lib/python2.7/socket.py", line 228, in meth
return getattr(self._sock,name)(*args)
socket.error: [Errno 98] Address already in use

when I stop grgsm_livemon in terminal 2 and run the command in terminal 1 with python simple_IMSI-catcher.py --sniff is giving me this:
root@kali:~/Desktop/IMSI-catcher-master# python simple_IMSI-catcher.py --sniff
Traceback (most recent call last):
File "simple_IMSI-catcher.py", line 548, in
from scapy.all import sniff, UDP
ImportError: No module named scapy.all
:-??
without --sniff
root@kali:~/Desktop/IMSI-catcher-master# python simple_IMSI-catcher.py
Nb IMSI ; TMSI-1     ; TMSI-2     ; IMSI              ; country      ; brand      ; operator              ; MCC  ; MNC   ; LAC    ; CellId ; Timestamp
nothing..
Does anyone knows what I need to do ?
Thank you

I have only rtl-sdr device , no hackrf..


Error Unable to open X display when running Cypress in docker in Interactive mode

I followed the instructions here: https://www.cypress.io/blog/2019/05/02/run-cypress-with-a-single-docker-command/
When trying to run cypress in in docker, in interactive mode, I get the following error
[16:1023/003758.546489:ERROR:browser_main_loop.cc(1417)] Unable to open X display.

undefined:0

illegal access
(Use `node --trace-uncaught ...` to show where the exception was thrown)

Steps to reproduce

export IP=$(ipconfig getifaddr en0);
/usr/X11/bin/xhost + $IP;

❯❯❯ /usr/X11/bin/xhost + $IP;
<IP_ADDRESS> being added to access control list

DISPLAY=$IP:0
docker run -it \
  -v $PWD:/e2e \
  -v /tmp/.X11-unix:/tmp/.X11-unix \
  -w /e2e \
  -e DISPLAY \
  -e DEBUG=cypress:* \
  --entrypoint cypress \
  cypress/included:5.4.0 open

Error:
❯❯❯ docker run -it \
  -v $PWD:/e2e \
  -v /tmp/.X11-unix:/tmp/.X11-unix \
  -w /e2e \
  -e DISPLAY=$IP:0 \
  -e DEBUG=cypress:* \
  --entrypoint cypress \
  cypress/included:5.4.0 open
  cypress:cli:cli cli starts with arguments ["/usr/local/bin/node","/usr/local/bin/cypress","open"] +0ms
  cypress:cli NODE_OPTIONS is not set +0ms
  cypress:cli:cli program parsing arguments +2ms
  cypress:cli:cli opening Cypress +1ms
  cypress:cli parsed cli options {} +170ms
  cypress:cli opening from options {} +0ms
  cypress:cli command line arguments [] +1ms
  cypress:cli verifying Cypress app +0ms
  cypress:cli Using CYPRESS_CACHE_FOLDER from environment variable +1ms
  cypress:cli Using CYPRESS_CACHE_FOLDER from environment variable +1ms
  cypress:cli using environment variable CYPRESS_CACHE_FOLDER /root/.cache/Cypress +0ms
  cypress:cli checking environment variables +1ms
  cypress:cli checking if executable exists /root/.cache/Cypress/5.4.0/Cypress/Cypress +4ms
  cypress:cli Binary is executable? : true +8ms
  cypress:cli binaryDir is  /root/.cache/Cypress/5.4.0/Cypress +1ms
  cypress:cli Reading binary package.json from: /root/.cache/Cypress/5.4.0/Cypress/resources/app/package.json +13ms
  cypress:cli Found binary version 5.4.0 installed in: /root/.cache/Cypress/5.4.0/Cypress +5ms
  cypress:cli { verified: true } +9ms
  cypress:cli is Verified ? true +5ms
  cypress:cli DISPLAY environment variable is set to <IP_ADDRESS>:0 on Linux
  cypress:cli Assuming this DISPLAY points at working X11 server,
  cypress:cli Cypress will not spawn own Xvfb
  cypress:cli
  cypress:cli NOTE: if the X11 server is NOT working, Cypress will exit without explanation,
  cypress:cli   see https://github.com/cypress-io/cypress/issues/4034
  cypress:cli Solution: Unset the DISPLAY variable and try again:
  cypress:cli   DISPLAY= npx cypress run ... +0ms
  cypress:cli Using CYPRESS_CACHE_FOLDER from environment variable +24ms
  cypress:cli Using CYPRESS_CACHE_FOLDER from environment variable +0ms
  cypress:cli using environment variable CYPRESS_CACHE_FOLDER /root/.cache/Cypress +2ms
  cypress:cli needs to start own Xvfb? false +0ms
  cypress:cli spawning, should retry on display problem? true +1ms
  cypress:cli passing DISPLAY <IP_ADDRESS>:0 +3ms
  cypress:cli spawning Cypress with executable: /root/.cache/Cypress/5.4.0/Cypress/Cypress +0ms
  cypress:cli spawn args [ '--no-sandbox', '--', '--cwd', '/e2e' ] { detached: false, stdio: 'inherit' } +0ms
  cypress:ts Running without ts-node hook in environment "production" +0ms
  cypress:server:appdata path: /root/.config/Cypress/cy/production/browsers +0ms
  cypress:server:util:node_options NODE_OPTIONS check passed, not forking { NODE_OPTIONS: '--max-http-header-size=1048576' } +0ms
  cypress:server:util:node_options restoring NODE_OPTIONS { NODE_OPTIONS: '--max-http-header-size=1048576', ORIGINAL_NODE_OPTIONS: undefined } +1ms
  cypress:server:cypress starting cypress with argv [ '/root/.cache/Cypress/5.4.0/Cypress/Cypress', '--no-sandbox', '--', '--cwd', '/e2e' ] +0ms
  cypress:server:args argv array: [ '/root/.cache/Cypress/5.4.0/Cypress/Cypress', '--no-sandbox', '--cwd', '/e2e' ] +0ms
  cypress:server:args argv parsed: { _: [ '/root/.cache/Cypress/5.4.0/Cypress/Cypress' ], sandbox: false, cwd: '/e2e', invokedFromCli: true } +3ms
  cypress:server:util:proxy found proxy environment variables {} +0ms
  cypress:server:args options { _: [ '/root/.cache/Cypress/5.4.0/Cypress/Cypress' ], sandbox: false, cwd: '/e2e', invokedFromCli: true, config: {} } +1ms
  cypress:server:args argv options: { _: [ '/root/.cache/Cypress/5.4.0/Cypress/Cypress' ], sandbox: false, cwd: '/e2e', invokedFromCli: true, config: {} } +1ms
  cypress:server:cypress from argv [ '/root/.cache/Cypress/5.4.0/Cypress/Cypress', '--no-sandbox', '--cwd', '/e2e' ] got options { _: [ '/root/.cache/Cypress/5.4.0/Cypress/Cypress' ], sandbox: false, cwd: '/e2e', invokedFromCli: true, config: {} } +6ms
[16:1023/003155.368363:ERROR:browser_main_loop.cc(1417)] Unable to open X display.

undefined:0

illegal access
(Use `node --trace-uncaught ...` to show where the exception was thrown)
  cypress:cli child event fired { event: 'exit', code: 7, signal: null } +2s
  cypress:cli child event fired { event: 'close', code: 7, signal: null } +1ms

Do you know what I am doing wrong here?
I'm running this on a Mac

Found it, make sure the below boxes are ticket


Add the ability to use csv, xml or yaml file format

What feature do you want to see added?
Support using csv, xml or yaml file format

[x] csv

[x] xml

[x] yaml/yml

would be good but seems that file format has to be basic

Upstream changes
No response

Hi @totocaca123,
i actually already had the idea on the screen. I'll give it some thought and see how I can implement it. If you have ideas, I'm happy about your input!

or yaml or xml file, these files are quiet similar to json (so a conversion into json would be the simpliest way).
For csv/excel, the file format is not clear. This format makes impossible to have multi level. So the simpliest way would be a 1 level chart. Each line is an item and eah column is a field

Im added yaml support with #35.
At the moment I have problems with xml conversion.

implement xml file support with #62

@totocaca123
I also implement csv support with #63. But I see a few problem here with this new feature.
In a cdv file I can not add an id and name on top level for the report:
id,name,incorrect,manually,accurate
aktie,Aktie,3441,348,5199
derivat,Derivat,593,9028,1008

so actually I calculate the id as hashcode of the filename and take the filename as name.
At this point, I think it makes sense to completely rebuild the API and set it up like in the warnings-ng plugin, that you have multiple report providers, one for csv with id, name, delimiter, encoding. One for json with id, name, encoding.

Yes I agree because CSV file should be simple (columns...)
The ID seems useless (user must put only report name). User just want to set the report name (unique). Maybe ID might be an internal field not visible for user.
So by removing ID and name, the publish report shall create 1 report with all found files (automatically merge data).
 It seems more logical for user.

For csv file, the most simple solution is to have first column with fields and other columns for data (numbers).
Is it possible to autodetect if a csv column is text or numbers. In this case, a multi level csv could be done:
For example to support csv like this with auto detection of numbers

But then the user have to make sure, that the dataset (1 to n files in pattern) have all the same attributes. Otherwise I can not merge it.
So you prefer, that publishReport exactly publish 1 report (as long as id and data structure is the same, otherwise for each id a report will be published). For this report the user have to specify a name and a id, because I need that id assign the reports. But the id must be assigned only for csv reports in the step, because I cannot specify one in the csv file. For all other reports, the user can specify the id in the report files itself.
And in each publishReport step all given reports are automatically merged to one as long as the data structure and the ids are the same, otherwise I won't add these reports to the build, so to sum up the api:
publishReport enabledForFailure: true, provider: csv(pattern: '**/*.csv', id: 'my-csv-report', name: 'My CSV report', delimiter: ',', encoding: 'UTF-8')
publishReport enabledForFailure: true, provider: json(pattern: '**/*.json', name: 'My JSON report', encoding: 'UTF-8')
publishReport enabledForFailure: true, provider: yaml(pattern: '**/*.yaml', name: 'My YAML report', encoding: 'UTF-8')
publishReport enabledForFailure: true, provider: xml(pattern: '**/*.xml', name: 'My XML report', encoding: 'UTF-8')

With your explanations about the csv we can also support multilevel csv files, that's great, thanks!

For me the simpliest way is to merge all data from 1 command publishReport (as it is done in warning ng plugin).
The name could be set in the pipeline and ID is not relevant
If user provide unconsistent data, the best way is to assume all data are present, and if a column is missing, we assume data is set to 0 if not present.
From my point of view, numbers or report is related to number of call of publishReport.
If ID is used, it forces users to create/organize reports inside his data, and number of reports is controlled by json files. I think numbers of reports shall be set by numbers of call. I assume user provide consistent data. In case of unconsistent data, we add numbers of 0 for missing data (with warning message). User has then to improve his data or split data to create 2 reports

Thanks for your input, I will try something out. But I need an id, otherwise I am not bale to create a history for the history charts at the moment. I will try to implement the new api and have look if there is another way to get rid of the id.

For the ID, it could be a SHA of report name.
But if user change report name...
If user change report name, do we assume data are lost?
The ID could be usefull in pipeline (optional or mandatory?) if user want to be free to change report name without loosing his data.
So ID is the tag of data and display name can evolve...
That make sense and name field could be change to reportName (or reportDisplayName) and ID as reportId (unique ID)


Nuke more Swift 3 tests

This PR removes tests which were testing Swift 3-specific behavior. Since Swift 3 mode is going away we don't need these tests anymore.

@swift-ci Please smoke test

@swift-ci Please smoke test

@swift-ci Please smoke test

@swift-ci Please smoke test


Allow to prefer source artifacts over source code from VCS

BTW, can we have an option to try artifact source before vcs?
Originally posted by @kneep in https://github.com/oss-review-toolkit/ort/issues/2846#issuecomment-655879046

Currently, it is hard-coded to try downloading sources from VCS first, and then try a source artifact:
https://github.com/oss-review-toolkit/ort/blob/46a9ae9f730d132bd363bfa72c3d61fce630b2ea/downloader/src/main/kotlin/Downloader.kt#L124-L155
There could be an option to change the order.

Here in China, as you may all know, we have some network limitation. The public vcs repositories are hosted on various sites. Some of these sites are not accessible (e.g. sourceforge) while others have poor speed (e.g. Github, especially after evening). But generally artifacts repositories have reasonable speed here and are more predictable. So maybe it's better to have some flexibility on the priority of the source of source code.

Another problem that would get solved by this:
Suppose a Maven (binary) artifact has both a belonging sources artifact and a SCM / VCS location. Then the current implementation would scan the source code from the VCS, but the VCS typically contains test code for that dependency which is not part of the sources artifact. As test code often has very different detected licenses than the real product code, scanning the VCS results in potentially many irrelevant (but not false) findings that would need to be excluded by a package configuration, which is cumbersome. With that in mind it makes sense to focus as much as possible on the source code that makes up the binary, which means to prefer the sources artifact.

I believe it makes sense to make this configurable. I could see the following use cases

only scan source artifact
only scan VCS
prefer source artifact, fallback to VCS
prefer VCS, fallback to source artifact
prefer cached, then fallback to VCS, then fallback to source artifact
prefer cached, then fallback to source artifact, then fallback to source artifact

I believe what we currently have implemented is #5.
I'd propose to make the behavior configurable.
I'd have a strong interrest in having one configuration option which mimics the exact current behavior.

Both approaches have pros and cons so I think it's best to let the decide which strategy to use. Of the options Frank mentioned I think 3 and 4 can be ignored because they are basically 5 and 6 with disabled scan storage. I am also for making this configurable, but I'm undecided if 5 or 6 would be the better default. Trying to collect some of the pros and cons to get an overview:

VCS often contains many irrelevant files, like tests or related projects which are built from the same repository. On the other hand there is no guarantee that the source artifact matches the binary artifact, relevant source files or license files could be missing.
There is no guarantee that the binary artifact matches the VCS revision, because reproducible builds are not enforced by any package repository (at least to my knowledge). I have seen many NPM artifacts which seem to be built from private branches because the Git revision in the metadata does not exist in the repository.
VCS allows to generate links to the source code in the reports, e.g. to the exact location of license findings. That is mostly impossible for source artifacts.

@fviernau's use cases 5 and 6 were implemented in this PR: https://github.com/oss-review-toolkit/ort/pull/3736.
VCS was configured to be preferred to the sources artifact, because this was the default before. Cache always takes precedence.
Use cases 1-4 can be achieved by disabling he postgres cache. So can this be considered done?
One issue I see is that the cached data may be from a different origin. E.g. if the configuration was changed at a later point in time.
How should this be handled?
One way I see:
If cached data is from different origin, redownload from the preferred origin.
Issue with this approach: The preferred origin might fail and the fallback should then again be the cached data.
The redownload will be tried every time, resulting in worse performance.
@sschuberth, @mnonnenmacher, @fviernau what is your opinion how to handle this, or should it be handled at all?

Use cases 1-4 can be achieved by disabling he postgres cache. So can this be considered done?

I doubt disabling the cache can be considered an implementation of 1-4 because that'd be extremely slow.

I doubt disabling the cache can be considered an implementation of 1-4 because that'd be extremely slow.

I think then we do have a different understanding of use case 1-4.
The usage of cache is not mentioned there. So what would be the difference of just completely disabling it?

I think then we do have a different understanding of use case 1-4.
The usage of cache is not mentioned there. So what would be the difference of just completely disabling it?

Yes, our understanding is different. What I meant by case 3 (prefer source artifact, fallback to VCS) is:
if a source artifact is available, then the OrtResult would contain a source artifact scan, in particular even if the scan result storage contain only a VCS scan for that package.

Currently the state of the cache can affect which (VCS or source artifact) scan is used.

Yes, this is the issue I was talking about in https://github.com/oss-review-toolkit/ort/issues/2848#issuecomment-815504815
But I see issues with my proposed solution:

One way I see:
If cached data is from different origin, redownload from the preferred origin.
Issue with this approach: The preferred origin might fail and the fallback should then again be the cached data.
The redownload will be tried every time, resulting in worse performance.

The redownload will be tried every time, resulting in worse performance.

So how about if we then just accept all stored scan results, but sort them in order of the preferred origins?

I would also recommend that we should not try to be too clever. One could argue that the user is responsible for the content of the cache - undesired results in the cache could be removed. So if caching is enabled, the results found there should be used IMHO (maybe ordered as suggested by @sschuberth).
BTW: Are there any helper commands that allow an introspection or modification of the cache? These could be useful in this context.

Are there any helper commands that allow an introspection or modification of the cache?

No, but adding some of these, e.g. to the helper-cli, indeed seems to be a good idea.

@mnonnenmacher and @fviernau, so WRT to the question how to deal with stored scan results when the preferred source origin has been (re-)configured, would you agree to what I wrote above, to "accept all stored scan results, but sort them in order of the preferred origins"?

What would be the purpose of sorting them? Currently we accept all matching scan results for a package and add them to the result, but AFAIK the order in which they are added to the result is not relevant anywhere.

Currently we accept all matching scan results for a package

The point is that "matching" here only means "by id". But with the feature to prefer a source origin, we additionally are about the provenance.

the order in which they are added to the result is not relevant anywhere.

Exactly, the order might be any order. But if there are VCS and artifacts scan results for the same package in the storage, we need to ensure to get artifact results if the source origin was configured to prefer / only use artifacts.

Notes from the call with @sschuberth and @mnonnenmacher:
We'll create a helper-cli command that offers the functionality to remove the cached result with the wrong Provenance.


Reset form (not clear form)

Having a reset method which resets (not clears) everything including error, touched etc to the original values.
I pre-fill a form (settings) with values from the db using the default state. The user can change fields but also reset changes. The current clear method clears all the preset values instead of resetting to the original values.
The work around I'm using is to update the key to re-render the form but its a bit slow to re-render... e.g. from #33 https://codesandbox.io/s/x3kznwm6lo
Related to:
#33 (reset form)

Would it also be possible to set the values of the form? I'm loading my data asynchronously and when the data arrives I use setField() to put values in the form. This however marks every field as touched.


large error

Wonderful job!
I'm having some problems running the code，
KdV, end_time=40, nt=200, nt_effective=200, nx=256, L=128, samples=512, batch_size=64.
After 10 epochs, the vlidation error is larger than 1, and the train speed(4070Ti) is slow(maybe it's caused by change num_workers from 4 to 0).
Looking forward to your reply.

and the utilization rate of gpu is less than ten percent

Hi @panglei-math-zju, thanks a lot! Hmmm I couldn't reproduce this error, using a V100 for training. could you try with num_workers=4?


Storybook component fill

Summary
Adds stories for components, buttons, profile sections, auth modals, educational materials
some refactoring to access view elements & smaller components that were defined in larger components
Known issues
some components need auth or other hooks to render
more refactoring to pull out view elements & smaller components
sync with design upcoming
this is a progress/sharing update, more to go

These commits are incorporated in PR #1377 , so I am closing this PR. Further work will appear there.


Extend New-GceAttachedDiskConfig to support local SSD scratch disks

Currently there is no way to use the Google Cloud Powershell tools to create a GCE instance with one or more local SSD scratch disks.  This can be implemented by extending the New-GceAttachedDiskConfig cmdlet to include support for local SSD disks.
Proposed solution:
Extend the parameter set for New-GceAttachedDiskConfig to include a single parameter ScratchDiskZone which takes in a GCE zone as input.  The cmdlet then returns a AttachedConfig object of type SCRATCH and diskType /zones/{zone}/diskTypes/local-ssd

This fix is available in version <IP_ADDRESS> of the module.


Fix #522, Software Bus Requirements Scrub

Describe the contribution
See issue for detailed list of changes
Fix #522
Testing performed
None, doc change only
Expected behavior changes
None
System(s) tested on
None
Additional context
Commit is on top of previous requirements work to facilitate review, only the last commit is applicable to this issue
Third party code
None
Contributor Info - All information REQUIRED for consideration of pull request
Jacob Hageman - NASA/GSFC

CCB 20200226 - Approved

Closing since PR #526 includes this commit


[BUG] ATOMIC_REQUESTS is checked for in the wrong place.

Describe the bug
djangochannelsrestframework's (DCRF) action decorator looks in Django's settings for ATOMIC_REQUESTS. Since at least Django 1.8, ATOMIC_REQUESTS has been a setting specific to a connection defined in the DATABASE setting. When ATOMIC_REQUESTS is setup as described in Django documentation, DCRF's action decorator does not wrap sync actions in an atomic block, or throw errors on async actions that cannot be wrapped.
See:

https://docs.djangoproject.com/en/1.8/ref/settings/#atomic-requests
https://docs.djangoproject.com/en/3.1/ref/settings/#atomic-requests

To Reproduce
Steps to reproduce the behavior:

Setup django databases. (In this case, setup as in cookiecutter-django).# DATABASES
# ------------------------------------------------------------------------------
# https://docs.djangoproject.com/en/dev/ref/settings/#databases
DATABASES = {"default": env.db("DATABASE_URL", default="postgres:///project")}
DATABASES["default"]["ATOMIC_REQUESTS"] = True

Run a custom async action:@action
async def change_password(self, current_password="", new_password="", confirm_password="", **kwargs):
    ...

Expected behavior
The custom async action, wrapped using @action should throw the exception from this line:
https://github.com/hishnash/djangochannelsrestframework/blob/master/djangochannelsrestframework/decorators.py#L54
DCRF's action decorator should take a using kwarg, similar to atomic's using kwarg, which is used to check if a specific db connection wants to be wrapped in atomic blocks. Barring support for the using kwarg, the default connection should at least be checked for ATOMIC_REQUESTS.

Good catch.
I will look into this today.
Likely i will move the check for reading the settings of atomic to after the async method test (so that the error is only thrown if you expisilty set @action(atomic=True) on an async method. Also pulling the atomic value from the default connection db makes sense.
I will look into adding the using kwarg but i feel that is a feature of its own as it will come with some other complexities around the DB connection that is created for the sync action.

While not directly related, I needed to set atomic=False on ObserverModelInstanceMixin actions in order to get my server to run with ATOMIC_REQUESTS=True.
https://github.com/arrai-innovations/djangochannelsrestframework/commit/3c654eb2680bd7321777c084ba31547fda46bc92

Yer i spotted that, if I move  https://github.com/hishnash/djangochannelsrestframework/blob/master/djangochannelsrestframework/decorators.py#L45 to after the async method check then that issue will go-away.

Right, I see that now. I was not understanding.

tyvm 👍


HTTPS request doesn't work when disable_ssl_certificate_validation = True

From kvvier on September 06, 2011 04:05:20
What steps will reproduce the problem? h = httplib2.Http(cache="C:\Temp\.cache")
h.disable_ssl_certificate_validation=True
out, err = h.request("https://mail.google.com" #uri doesn't matter
print(out['status']) What is the expected output? What do you see instead? I expect to get '200' printed to stdout,
instead I get:
ValueError: check_hostname needs a SSL context with either CERT_OPTIONAL or CERT_REQUIRED What version of the product are you using? On what operating system? httplib2-0.7.1 (CPython 3.2.1 64-bit, Windows 7 Enterprise 64-bit) Please provide any additional information below. Changing (in HTTPSConnectionWithTimeout constructor):
http.client.HTTPSConnection.init(self, host, port=port,
key_file=key_file, cert_file=cert_file, timeout=timeout,
context=context,
check_hostname= True)
to:
http.client.HTTPSConnection.init(self, host, port=port,
key_file=key_file, cert_file=cert_file, timeout=timeout,
context=context,
check_hostname= disable_ssl_certificate_validation ^ True)
solves issue.(no errors, response as expected)
Original issue: http://code.google.com/p/httplib2/issues/detail?id=173

Is there blocker preventing the provided pull requests from being merged? This bug is holding back adoption of python3. :(

Please merge this, my oauth2client also fails due to this bug

Is there a way I can help to get this merged? 2 years old and it's still an issue.

We long for the day it's merged. Indeed.

Hi jcgregorio, does the recent update imply the fix has been incorporated? (I hope!)

If this is still relevant please re open it at https://github.com/httplib2/httplib2/issues
See: http://bitworking.org/news/2016/03/an_update_on_httplib2


Allow IndexView's base queryset to be customised via ModelViewSet.get_base_queryset()

Refactor SnippetViewSet.get_queryset() customisation into ModelViewSet.get_base_queryset() as part of #10740.
Not sure if we want this, and not using inject_view_methods per the conversation in https://github.com/wagtail/wagtail/pull/10851#discussion_r1315047040.
We might want to extract IndexView.get_base_queryset into a standardised method that is used across the views in ModelViewSet, and put the queryset kwarg override into get_common_view_kwargs instead. Therefore, the queryset returned by ModelViewSet.get_base_queryset will be enforced across all views. See also the discussion at https://github.com/wagtail/wagtail/pull/10621#issuecomment-1712039247
Please check the following:

[x] Do the tests still pass?[^1]
[x] Does the code comply with the style guide?

[x] Run make lint from the Wagtail root.

[x] For Python changes: Have you added tests to cover the new/fixed behaviour?
[ ] For front-end changes: Did you test on all of Wagtail’s supported environments?[^2]

[ ] Please list the exact browser and operating system versions you tested:
[ ] Please list which assistive technologies [^3] you tested:

[x] For new features: Has the documentation been updated accordingly?

[^1]: Development Testing
[^2]: Browser and device support
[^3]: Accessibility Target

I'm not sure if you plan on reviewing this soon @lb- but as per the discussion in https://github.com/wagtail/wagtail/pull/10851#discussion_r1315047040, I think we should hold off on this one until Matt has a chance to review, which means this likely won't be in 5.2.


Security scan

Chi scan cho nhanh master

 Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.:x: ngocld sign nowYou have signed the CLA already but the status is still pending? Let us recheck it.


[ARC E2E] Huggingface accuracy failed

🐛 Describe the bug
Accuracy failed for key name albert.embeddings.token_type_embeddings.weight.grad

Category
Model
Accuracy

huggingface_amp_bf16_training
AlbertForMaskedLM
fail_accuracy

huggingface_amp_fp16_training
AlbertForMaskedLM
fail_accuracy

huggingface_bfloat16_training
AlbertForMaskedLM
fail_accuracy

huggingface_float16_training
AlbertForMaskedLM
fail_accuracy

huggingface_float32_training
AlbertForMaskedLM
fail_accuracy

huggingface_amp_bf16_training
AlbertForQuestionAnswering
fail_accuracy

huggingface_amp_fp16_training
AlbertForQuestionAnswering
fail_accuracy

huggingface_bfloat16_training
AlbertForQuestionAnswering
fail_accuracy

huggingface_float16_training
AlbertForQuestionAnswering
fail_accuracy

huggingface_float32_training
AlbertForQuestionAnswering
fail_accuracy

Versions
torch-xpu-ops: 7e3d00acea9f0d3728048a5b2743de20d55c64ba
pytorch: 0d1d69fd25fdc096763bfe85f4d379e27ea1c9f8
device: ARC 24.04
driver: 24.31.30508.7

Category
Model
Ubuntu 24.04
Ubuntu 22.04

huggingface_amp_bf16_training
AlbertForMaskedLM
fail_accuracy
pass

huggingface_bfloat16_training
AlbertForMaskedLM
fail_accuracy
pass

huggingface_float32_training
AlbertForMaskedLM
fail_accuracy
pass

huggingface_float32_training
AlbertForQuestionAnswering
fail_accuracy
pass

@mengfei25
I can reproduce on ubuntu 22, for example, AlbertForMaskedLM fp16 training, I get
W0925 06:28:19.597000 315406 site-packages/torch/_dynamo/utils.py:1723] Similarity score=0.9181798100471497
E0925 06:28:19.598000 315406 site-packages/torch/_dynamo/utils.py:1674] Accuracy failed for key name albert.embeddings.token_type_embeddings.weight.grad. The similarity score is exactly the same as your test log.
However, If I modify the patch and compare the result directly, it can pass. You do not need put fp64_outputs on xpu, and you can put new_result and correct_result on cpu. https://github.com/pytorch/pytorch/blob/main/benchmarks/dynamo/common.py#L2898

cuda also fails on cosine similarity
cuda train AlbertForMaskedLM
W0927 14:50:50.191000 3628133 /mnt/tmp/home/sparse/miniforge3/envs/jianyi/lib/python3.10/site-packages/torch/_inductor/debug.py:434] [3/0_1] AlbertForMaskedLM__0_forward_1 debug trace: /home/sparse/jianyi/pytorch/inductor_log/huggingface/AlbertForMaskedLM/training/amp_fp16/22/torch_compile_debug/torch_compile_debug/run_2024_09_27_14_50_33_656959-pid_3628133/torchinductor/AlbertForMaskedLM__0_forward_1.0
W0927 14:51:04.399000 3628133 /mnt/tmp/home/sparse/miniforge3/envs/jianyi/lib/python3.10/site-packages/torch/_inductor/debug.py:434] [3/0_1] AlbertForMaskedLM__0_backward_3 debug trace: /home/sparse/jianyi/pytorch/inductor_log/huggingface/AlbertForMaskedLM/training/amp_fp16/22/torch_compile_debug/torch_compile_debug/run_2024_09_27_14_50_33_656959-pid_3628133/torchinductor/AlbertForMaskedLM__0_backward_3.1
W0927 14:51:05.220000 3628133 /mnt/tmp/home/sparse/miniforge3/envs/jianyi/lib/python3.10/site-packages/torch/_dynamo/utils.py:1723] Similarity score=0.6160069704055786
E0927 14:51:05.221000 3628133 /mnt/tmp/home/sparse/miniforge3/envs/jianyi/lib/python3.10/site-packages/torch/_dynamo/utils.py:1674] Accuracy failed for key name albert.embeddings.token_type_embeddings.weight.grad
fail_accuracy

@jianyizh does it mean both xpu and cuda will fail on cosine similarity for those models?

@jianyizh does it mean both xpu and cuda will fail on cosine similarity for those models?

yes, and they can pass on the normal accuracy test with fp64 patch corrected

Clean issues. Use PT2.6 based on Ubuntu 24.10 fully testing and submit new issues.


Service limits with group claims (SAML)

Please add "Azure AD limits the number of groups that it will emit in a token to 150 for SAML assertions and 200 for JWT." for Users which are Member of more than ~150 Groups if there is not Filter applied.
Source: https://learn.microsoft.com/en-us/azure/active-directory/hybrid/connect/how-to-connect-fed-group-claims#options-for-applications-to-consume-group-information

Document Details
⚠ Do not edit this section. It is required for learn.microsoft.com ➟ GitHub issue linking.

ID: 42a0b4cb-1981-1cbc-ce2c-dbfd8af1527c
Version Independent ID: d49c873c-9843-8428-a6d1-a1995067d13b
Content: Service limits and restrictions - Microsoft Entra
Content Source: articles/active-directory/enterprise-users/directory-service-limits-restrictions.md
Service: active-directory
Sub-service: enterprise-users
GitHub Login: @barclayn
Microsoft Alias: barclayn

@weyCC81
Thanks for your feedback! We will investigate and update as appropriate.

Hi @weyCC81
As per the provided documents, Azure AD limits the number of groups that it will emit in a token to 150 for SAML assertions and 200 for JWT. This means that if a user is a member of more than 150 groups, for SAML assertions, or 200 groups, for JWT, Azure AD will not emit all the groups in the token. Instead, it includes an overage claim in the token that indicates to the application to query the Microsoft Graph API to retrieve the user's group membership. Please note that this limit is applicable only if there is no filter applied.

Hi @ManoharLakkoju-MSFT
This is correct, but as most have not yet set the filter this happens on a regular basis at some customers, and they are not aware because they have just read this limitation page, and it is not in there mentioned.

@weyCC81
Thank you for your suggestion. It would be helpful to provide your ideas in the below link so our product team will work on it.
https://feedback.azure.com/d365community

Hi @ManoharLakkoju-MSFT
I am not saying you should fix this or prioritize it differently, but please add it in the documentation!

@weyCC81
I'm going to assign this to the document author so they can take a look at it accordingly
@barclayn
Can you please check and add your comments on this doc update request as applicable.

@weyCC81 thank you for calling this out. #please-close


"latest TypeScript grammar" broken

Installed https://marketplace.visualstudio.com/items?itemName=ms-vscode.typescript-javascript-grammar (with Dark+):

I'm not sure how it should be, but it doesn't seem right.

Previously, green was only for classes and interfaces, not it is for properties aswell.
keywords like await or delete are not colored
object access is sometimes white, sometimes light blue
require() is violet

Code:
import fetch from 'node-fetch';
import * as assert from 'assert';
import {API_URL} from '../../../../api/../config';
import {createTestToken, shouldRequireAdminPermission} from '../helper';
import {Product} from '../../../../api/models/investment/Product';
import {Notification} from '../../../../api/models/core/Notification';
import Sequelize = require('sequelize');
import * as sinon from 'sinon';
import {pusher} from '../../../../api/pusher';
import {assertDeepEqual} from '../helper';
import {pick, omit} from 'lodash';

describe('Product', () => {
    describe('GET /products', () => {
        shouldRequireAdminPermission('GET', '/products');
        it('should return a list of products', async () => {
            const product = await Product.create({
                name: 'Goldmine SMSF',
                description: 'Established goldmine self-managed super fund',
                type: 'unit',
                status: 'open',
                distributionPeriod: 'annually',
                distributionDate: new Date(Date.UTC(2016, 8, 7)),
                startDate: new Date(Date.UTC(2016, 8, 5)),
                endDate: new Date(Date.UTC(2016, 9, 5)),
                couponRate: '0.05',
                termType: 'absolute',
                managerId: 1
            });
            const token = createTestToken({ permissions: ['admin'] });
            const res = await fetch(API_URL + '/products', { headers: { 'Authorization': 'Bearer ' + token } });
            assert.equal(res.status, 200);
            const body = await res.json();
            delete body[0].createdAt;
            delete body[0].updatedAt;
            assert.equal(~~res.headers.get('x-total-count'), 1);
            assertDeepEqual(body, [{
                id: product.id,

@felixfbecker await not being colored is bug in the grammar and I have fix for it. Thanks for reporting it.
I also have a fix for object literal keys colored green.
delete is keyword.operator.delete and it should be colored like keyword and dark+ theme doesn't do that. I will report it in vscode repo
object accesses like assert are scoped as support objects and dark theme doesn't color it. Eg. look at function call res.headers.get the get is not colored as it is classified as support.function which should be colored as atleast other functions are colored. I am filing bug in vscode for this so they can make changes in their theme.
require is violet by design just like import and from in other import statements. It is control keyword that makes import and external import and hence the color.

Thanks for looking into this, but I disagree with the last statement. require is nothing but a global function.

@felixfbecker From typescript perspective require is a special keyword that determines what the lhs import variable means and hence the control keyword


Support loading point elements from SpatialData

User story
User has transcript coordinates from MERFISH-like experiment that are represented using point elements within a SpatialData object. User wants to visualize these points using Vitessce without converting them to a different data format/representation.
Preferred solution
Implement a new FileType and data loader class that returns the polygon shapes as the obsPoints data type.
https://github.com/vitessce/vitessce/blob/40fe260f444fe17b190866b667c70895cfdbcc97/packages/types/src/data-types.ts#L30
This will require knowledge of how the SpatialData stores Point elements on-disk. Some relevant resources that may help are:

https://spatialdata.scverse.org/en/latest/design_doc.html#points
https://github.com/scverse/spatialdata/blob/643b845658b39f23ab84db32f0443d6ea91da98c/src/spatialdata/_io/io_points.py#L48

Possible alternatives

Once this is complete, we should also deploy an example and/or a tutorial.


Should not reserve space for hidden hamburger button when navigation drawer is permanent

When the navigation bar is permanent, the title is rendered with extra left padding to accommodate where the hamburger menu used to be.  I don't see where the spec says it explicitly, but none of the examples depict similar behavior. For example, note the example of "an open persistent drawer."

Yea, it doesn't explicitly state in the drawer spec nor the layout spec. I'd assume this is just a byproduct of how the templates are setup to make sure the drawer button has the space it needs. We should get in touch with the MD spec team and see if what we currently do is acceptable. If not then make sure the space isn't preserved.

Or when drawer is shown only no phones, tablets...

@surma Do you think we could include the CSS from #1078 in a patch or minor bump? Looks safe enough and BC concerns are pretty minor (aside from manually set things due to existing spaces. But I'm not too worried about that.)


Updating readme from branch example

Updates
I updated the readme file. Please review and accept.

Thoughts
I probably shouldn't, but ok 👍


[Enhancement] (nereids)implement adminRebalanceDiskCommand in nereids

What problem does this PR solve?
Issue Number: close #42844, #42845
Related PR: #xxx
Problem Summary:
Release note
None
Check List (For Author)

Test

[ ] Regression test
[ ] Unit Test
[ ] Manual test (add detailed scripts or steps below)
[ ] No need to test or manual test. Explain why:

[ ] This is a refactor/code format and no logic has been changed.
[ ] Previous test can cover this change.
[ ] No code files have been changed.
[ ] Other reason

Behavior changed:

[ ] No.
[ ] Yes.

Does this need documentation?

[ ] No.
[ ] Yes.

Check List (For Reviewer who merge this PR)

[ ] Confirm the release note
[ ] Confirm test cases
[ ] Confirm document
[ ] Add branch pick label

run buildall

run buildall

run buildall

run buildall

run buildall

run buildall

run buildall

run buildall

run buildall

run buildall

run buildall

run buildall

run buildall


Remove needs of waitForRemotePeer

This is a change request
Problem
Currently, a user needs to use waitForRemotePeer before they are able to use their Waku node. Whether it is to send message via Light Push, subscribe via Filter or retrieve via Store.
waitForRemotePeer hosts a complex logic which creates a number of code smells (maintainability is C).
Acceptance Criteria

[ ] Remove the need of waitForRemotePeer to make the API easier to use and also reduce complexity of js-waku.
[ ] Mark waitForRemotePeer as deprecated and review developer feedback if any
[ ] Remove or replace waitForRemotePeer based on feedback above.

Proposed Solutions
The solution would be to embed the waitForRemotePeer logic directly in the protocols. However, because it is embedded than the logic would be simpler as we would expect only one libp2p protocol codec.
For example, when calliing LightPush.push, if no peer is available, wait for a peer using libp2p events and send the message using said peer as soon as the peer connect/protocol change event is emitted.
Notes

Another step to improve the API could be to remove the Waku.start() call, as recently done in libp2p.
An option such as failFast could be added to the API to not wait for a peer connection.

I think the title is a bit broader than the problem proposed

Good point, title changed.

we should also consider preferring event based approach over async/await for other places, not able to name yet

We can track one issue at a time where we can see benefit of using event based pattern.

See https://github.com/waku-org/js-waku/pull/1305#issuecomment-1514086900

Discussion:

This API is used by some consumers, this is a breaking change and we would need to provide equivalent functionality
No strong reason to change the API  right now, only see it as a "nice to have" to amke the API smoother (save one line)
Worried about breaking single purpose function principle by having protocols api wait for connection and possibly time out
As we enhance connection manager functionality and extend its API, we may be able to extract equivalent functionality at some point in the future.


Support git commit sha

It looks that IO::Socket::SSL can be used from this commit 🤔
https://github.com/Perl/perl5/commit/1f64ae15647e757e817c923b2a9fcbc528c5f610


Nudge about standard extensions

Is your feature request related to a problem? Please describe.
Although it has been long time since we extracted rubocop-rails from core some users never discover our extensions. I have seen quite a few modern Rails projects only using rubocop.
Describe the solution you'd like
I would like when rubocop is run, it recognizes and prints a log message suggesting standard plugins like rubocop-rails, rspec, minitest, rake, sequel - whichever applicable to the project.
An option to disable this message.
Describe alternatives you've considered
A generic log message suggesting to have a look at our extensions.

Good idea. Shouldn't be hard to implement it.

I'm taking a stab at this.


Replace exterior ring in setExteriorRing if it exists

If a Polygon already has an exterior ring and setExteriorRing is called,
it would previously add the new ring to the start of the coordinates
list, so the existing exterior ring becomes an interior ring.

Thank you for the PR


Automation failed due to capital leeter used on climate entities

Problem/Motivation
When I set condition in automation for a climat device (Qubino) I always fget false result.
Expected behavior
My automation condition is set as :
condition:

condition: device
device_id: xyz
domain: climate
entity_id: climate.corridor_etage_2
type: is_hvac_mode
hvac_mode: 'off'

and when hvac_mode is 'off' I expect to have a "true" result
Actual behavior
The result of the condition is always off
Steps to reproduce

(How can someone else make/see it happen)

Proposed changes
Use off or heat info without capital letters!

This is not rated to the add-on, but Home Assistant itself.
Therefore you are in the wrong issue tracker.

This is not rated to the add-on, but Home Assistant itself.
Therefore you are in the wrong issue tracker.


Minimum window size not effective from 4.0 beta 9 onwards on Linux

Godot version
4.0-beta9
System information
Fedora Workstation 36
Issue description
There's been a regression between betas 8 and 9 where setting a minimum size via DisplayServer.window_set_min_size doesn't seem to have any effect.
Additionally, I seem to be able to shrink the window down past the normal minimum size of 64x64.
Steps to reproduce
Call DisplayServer.window_set_min_size; note that the window can be resized down past the given size.
Minimal reproduction project
Trivial.

nb. this still affects beta 10.

Please have a look at  #70347

@Sauermann Ah yes, looks to be the same thing.


SimpleTiledWFC doesn't generate anything

I'm having some trouble getting this to work.
My XML file is generating just fine (https://pastebin.com/8yQQbyKa), however nothing happens if I press generate (or RUN).
Here's a video of me trying to generate from tiles.
https://youtu.be/NRF8oz0E3pg
I also zipped up the project and uploaded it to drive if that helps.
I don't think I'm doing anything wrong, the simple example works just fine. I tried the scripts both before and after running Unity's automatic API update system but the result is the same in both cases.
Very sorry to bother with this since it's probably my fault, but please let me know if I'm doing something wrong.

@lovemoebius hmm hard to see that video, can you give me the link to the project zip and tell me what version of unity & unity-wave-function-collapse you're on?

Also - were there any errors in the console?

After doing some Debug Logging, the Draw function seems to run fine, but when it has to check
if (v != "?")
it results in a false result and (I think) it fails to draw any of the tiles.
model.Sample(x, y)
Results in "?"

@lovemoebius ah looks like some of the API has changed with 2018, will see if I can sort it out

@selfsame Which version of Unity was this last tested on?

@lovemoebius the stable 2017 release i think, also think the github repo is behind https://notabug.org/selfsame/unity-wave-function-collapse

@lovemoebius so I think the problem was the prefabs need to be somewhere inside a Resources directory (so that they can be instantiated by their path name).
I was able to get it to work in 2018.2.0f2 with the automatic api updates:

It does look like it's running, but I don't think it's doing so properly.
I'll try to run it on an older unity version and see if the results are different.
https://youtu.be/n_icN1zqO-w

@lovemoebius yeah you'll have to give the triangle a different symmetry, which you do with the prefab name.  Try triangleL?
From the readme, the options are:
X I T L
Tile symmetry class can be declared via the last letter of the prefab name, for example "GroundX" or "Road-T".
I think the default is X if there's no symmetry letter at the end.

Ah I see, it's working now.
This is some pretty amazing stuff right here, thank you for porting it to unity. I'll go read the original release to get more info about the tile script.

I hate to post again and bother, but I cannot get anything that looks right by using the TiledWFC.
I looked into the code to understand better how it works, but without any comments I didn't get very far.
I'm unsure if I'm just using it wrong or I just don't understand how the symmetries work, but I can't seem to be able to generate even a simple level.
Correct me if I'm wrong, but these are what the symmetries mean:

X can be flipped on both axes
T can be flipped on the X axis
I can be flipped on the Y axis

Where the problem comes in is with L.

Note: L tiles have an initial orientation of

OO
OX

No matter what orientation I put my tile in, it just refuses to work.
Is this how it's supposed to be oriented or is it the other way around?

Should these two corners have symmetry L? What does symmetry L actually mean?
I've also noticed the code has a definition for "Symmetry D", what is that exactly?

That was extremely helpful! The problem was with the corner tiles, there's apparently very specific ways to make them compatible with all the other tiles, if that step is skipped what comes out will most likely not make sense at all.
I was referenced to this guide that uses the tiles from the guide's examples on Reddit and it helped a lot with comprehension. I'll leave it here for future reference in case anyone else is confused.


Configure LDAP for each service

[ ] redmine
[ ] gitlab
[ ] jenkins
[ ] nexus

I need to change gitlab configuration file.
https://docs.gitlab.com/ee/administration/auth/how_to_configure_ldap_gitlab_ce/index.html

https://qiita.com/ir-shin1/items/12d0dbea40d1f1f06747