maintenance, bug fixes, new testnet, new regtest, fake stake fixed and more

update from source to 3.2.x

All commits are squashed in range of (includes all source PR's up to march 28 fc924c1f):
7fa20d69..fc924c1f
(https://github.com/PIVX-Project/PIVX/commit/7fa20d69f6654f5ab8c1508178e7787f9e37febb)
(https://github.com/PIVX-Project/PIVX/commit/fc924c1f63f3c84d7dcaea7e61254b355b55b608)

When do I have to upgrade?
Currently we plan to enforce new protocol on GMT: Wednesday, May 1, 2019 12:00:00 AM
Client will not require any upgrade, this date will be set with:
SPORK_8_NEW_PROTOCOL_ENFORCEMENT_DEFAULT

As soon as we release client on github, we will set choosen date over spork.
You can check spork values with ion-cli spork show.
4070908800 means it is off
any other numebr means that spork will be active from this timestamp
Release notes are being written.
Notable changes:

minor upgrades and fixes

protocol upgrade to 95704
client version upgrade to 3.2.x
new seeds
cleandup and initialized testnet checkpoints
readded class CBitcoinAddress class and its definitions
(TODO - required until refactored for getserials rpc call)
removed and refactored unrequired check if zerocoin is v1
fixed leveldb - comparison between signed and unsigned integer expressions (https://github.com/PIVX-Project/PIVX/pull/846)
fix redundant redeclaration (https://github.com/PIVX-Project/PIVX/pull/845)
fix redundant redeclaration of ‘std::__cxx11::string boost::program_options::to_internal(const string&)’
replaced deprecated auto_ptr with unique_ptr (https://github.com/PIVX-Project/PIVX/pull/844)
updated dependencies
updated snapcraft (https://github.com/ioncoincore/ion/pull/118)
implementation of zerocoin protocol
updated bip44

new testnet4

cleaned up chainparams
refactored testnet which can be launched at any time
old testnet was very big, with to many forks where no clients are available or hardcoded
change nBits from ion's old 0x1e00ffff to 0x1e0ffff0
new genesis for testnet
new genesis nounce for testnet

new regtest

cleaned up chainparams
refactored testnet which can be launched at any time
ion did not have regression test network for years.  Further
investigation is required but this is a suitable fix for now
and there is no need to have the r-click doing the sae job as
the l-click in this situation.

commit 37a06eaa938cab1c4cc7a39298690922519beb7a
Merge: 065f94118 bae276af9
Author: Mrs-X<EMAIL_ADDRESS>Date:   Wed Feb 27 21:51:22 2019 +0100
Merge #817: [Wallet] Fix segfault with runtime -disablewallet

bae276a Don't bother checking obfuscation messages (Fuzzbawls)
837f25f [Wallet] Fix segfault with runtime -disablewallet (Fuzzbawls)

Tree-SHA512: a8dd502897cdc82f206a1805f7b1ae51960344c3fa32640c9dc6c271768e7db718bc2f57034e8fabfd1b402e589e531419d1e8af8a25eee71d89a6b79ce3a679

commit c0d8dcb8c9be933ba6c86be95b1a45b89a1337af
Author: Fuzzbawls<EMAIL_ADDRESS>Date:   Tue Feb 26 19:16:20 2019 -0800
[Tests] Integrate fake stake tests into parent test suite

This integrates each of the 5 test scripts into the parent test suite so
 they can be run from within `test_runner.py` (or still individually).
 One prominent benefit to this is that the 5 tests are now included when
 generating code coverage reports with `make cov`

`stratisx-notingatstake.py` and `ion_fake_stake.py` are removed as the
former was a stale leftover from prior to our own test scripts, and the
latter is now redundant.

commit e87231b62b4fb41f4d14117e39f6c4ef8f3e0447
Author: Fuzzbawls<EMAIL_ADDRESS>Date:   Mon Feb 25 00:58:04 2019 -0800
[RPC] Fixup signrawtransaction on regtest

The `signrawtransaction` RPC command needed some modification to appease
 the fake stake test cases, however that change introduced a minor
 inconsistency in it's operation.

This PR restores the original functionality, while still providing a
means to be used for the fake stake test cases.

commit 065f94118d818faeaef80add16494366d9267120
Merge: f8eb7feef 61a6ea755
Author: Fuzzbawls<EMAIL_ADDRESS>Date:   Sun Feb 24 22:50:11 2019 -0800
Merge #803: [NET] Invalid blocks from forks stored on disk fix + blocks DoS spam filter.

61a6ea7558 AcceptBlock() for-each loops variables moved to const (furszy)
e1974d23f3 AcceptBlock() check for double spent serials only on main chain flag. (furszy)
babdfb0f26 remove extra debug lines in AcceptBlock (random-zebra)
a9178bc6e0 AcceptBlock: contextual zcspend check on main chain (random-zebra)
0d49570f20 AcceptBlock() block stored log removed (furszy)
b74921756a Fix bug on AcceptBlock when pindex is null (random-zebra)
45883b9fb6 AcceptBlock() invalid isBlockFromFork flag (furszy)
6a16049dfa AcceptBlock() reject blocks double spending the coin stake input inside the same block (furszy)
da1b6836a5 block spam filter, validate non null nodestate (furszy)
84de55a11c AcceptBlock() isBlockFromFork flag not contemplating prev blocks from forks fixed (furszy)
4219339521 AcceptBlock() - not accept blocks from a forked chain that exceed the max reorg limit (furszy)
47759e113c AcceptBlock(), reject invalid PoS stake (furszy)
e237823000 validate non null pfrom on blockspamfilter check (furszy)
c2e5459dff AcceptBlock(), serial double spend on the same block validation (furszy)
3f5091986c zPoS validations of forked chains before store them + inputs check on prev split main chain (furszy)
64804b4bee Invalid blocks from forks stored on disk fix + blocks DoS spam filter. (furszy)

Tree-SHA512: 6c5a7fda3eb81dc8b030c9ba624e5101f552ef9cecc839a79237b705c314171c0e9c66ecd8bfd207081c6759272140cf3bdf0da7af6ac4695f0c09b74fb1ba45

commit 61a6ea75585c11ef90f834583c1f206aaa5942b0
Author: furszy<EMAIL_ADDRESS>Date:   Sun Feb 24 23:52:40 2019 +0100
AcceptBlock() for-each loops variables moved to const

commit f8eb7feefceeb8828cbf5e8172ddf50079d713ca
Merge: 51e7b2c4b fced4e26f
Author: Fuzzbawls<EMAIL_ADDRESS>Date:   Sun Feb 24 14:46:30 2019 -0800
Merge #812: [Regtest][Tests][RPC] Regtest mode + Test suite.

fced4e26fe [Tests] fake_stake: reverse stake hash byte order (random-zebra)
a85cdad03c [Tests] fake_stake: use hashStake for kernel computation (random-zebra)
6aa5ddbff8 [Tests] fake_stake: remove random prevout from spending (random-zebra)
8e370da804 [RPC] add mint hashStake to listmintedzerocoins output (random-zebra)
0d865a8978 [Tests] fake_stake: use a copy for spendingPrevouts (random-zebra)
0f209b3da8 [Tests] fake_stake: docstrings and comments (random-zebra)
322ce79a67 [Tests] fake_stake: fix checksum computation (random-zebra)
7aae5b1e8b [Tests] fake_stake: fix empty spending_prevouts (random-zebra)
c7555e1b84 [Tests] fake_stake: collect prevouts from create_spam_block (random-zebra)
1d699432f2 [RPC] Add call 'getchecksumblock' (random-zebra)
2e7eacc4c4 [Tests] fix line separators in Test03 (random-zebra)
c6c81a7cd2 [Tests] fake_stake: test03 updated (random-zebra)
0d8cf5500d [Tests] remove trailing whitespace from README.md (random-zebra)
9302f5a046 [Tests] fake_stake: test01 & test02 updated (random-zebra)
e0efe4d530 [Tests] unique 'get_prevout' method for both pos and zpos stakes (random-zebra)
9318335525 [Tests] remove trailing whitespaces (random-zebra)
67284ce22a [RPC] add mint block height to 'listmintedzerocoins' (random-zebra)
d783229568 [Tests] get correct nStakeModifier (random-zebra)
78e838ee32 [Tests] fix solve_stake nTime / nStakeModifier (random-zebra)
a428c83609 PoS block creation uniqueness. (furszy)
dd07bd1a50 [Tests] fix proof of stake target in block class (random-zebra)
030e557b93 [Tests] fake_stake: fix test 01 block numbers (random-zebra)
fe54e9b92a [RPC] fix signrawtransaction hack to allow signing of spent inputs (random-zebra)
79e364354f regtest lastPoWBlock and zerocoin block start decreased to not waste lifetime waiting for the tests. (furszy)
42e9c01a85 More logging in block generation. (furszy)
0aa9bafbf4 fake stake test4 (furszy)
8315a42a7b ion_fake_stake: test03 almost complete (random-zebra)
1ad11ad9f7 RPC createrawzerocoinstake: fix vout[0], add priv-key (random-zebra)
ad65ac4e0a REGTEST: Fix bug on GetModifier (random-zebra)
47f0503b19 RPC: hack MintToTxIn to allow spending an already spent xion on regtest (random-zebra)
3092cfc0c2 add empty output to createrawzerocoinstake (random-zebra)
c5a6a67349 log CWallet::MintToTxIn errors (random-zebra)
252f4ab43e ion_fake_stake: zerocoin prevouts (random-zebra)
22769817ae GetModifier for regtest zPoS hardcoded to prev block stake modifier (furszy)
63bd40e064 ion_fake_stake: test_spam method refactoring (random-zebra)
1df9240727 ion_fake_stake: add test descriptions (random-zebra)
79e746eb3d zerocoin mint + spent (furszy)
9eea8837aa half test3 completed (furszy)
23236e7499 ion_fake_stake: select test from command line (random-zebra)
44d2e9a1c2 ion_fake_stake: get_prevouts (random-zebra)
1b27b90e8b ion_fake_stake Test05 - update blockcount in forks (random-zebra)
88e0dc6442 ion_fake_stake Test05 - more blocks fix (random-zebra)
bf3b732dc5 ion_fake_stake Test05 - more blocks (random-zebra)
a25f2e84a2 ion_fake_stake Test05 (random-zebra)
427f2f168b test05 completed, rejection of double spend coin stake input on the same block on main/forked chain (furszy)
3cbf43e7db test05 (furszy)
f7a48260c6 Add 'createrawzerocoinstake' method (random-zebra)
70d859e055 test_02 working good. (furszy)
ed63600142 ION_fake_stake: zerocoin tests (random-zebra)
07b981af88 no time validation for regtest (furszy)
47c2c65721 import bytes_to_hex on test_02 fix (furszy)
c02002bdd4 ION_fake_stake: fix coinstake out value (random-zebra)
35f09e5d21 submitblock assertion on test_02 (furszy)
d0c0dccff5 ION_fake_stake: fix coinbase nHeight merge (random-zebra)
2cf7ae1939 ION_fake_stake: fix txes in create_spam_block (random-zebra)
ef01bd8141 zPoS running on regtest :) (furszy)
5405d1ce2d Zerocoin fixed on regtest & PoS blocks generation fixes. (furszy)
158bd2b215 regtest PoS generate valid blocks (furszy)
71a3743108 Tests: fixup a conditional check for python block creation (Fuzzbawls)
b3950ff436 Tests: update nothingatstake test file (Fuzzbawls)
f40f576eb3 stakemodifier fixed for regtest (furszy)
80a2aec5df Tests: serialize block signature when present (Fuzzbawls)
9cec3bd2f5 RPC: hack signrawtransaction to allow signing an already spent input (Fuzzbawls)
5c0f0b99ed WIP: port the test for "fake stake" issue test (Fuzzbawls)
b074cd0e42 RPC: return the used stake modifier in getblock (Fuzzbawls)
1ffc443ba6 Regtest: mine the correct version blocks (Fuzzbawls)
3d588ead42 Tests: Remove whitespace in default conf file (Fuzzbawls)
ebdc552408 Fixup the walletdump command and python test (Fuzzbawls)
37b29c7e61 [Tests] Add Basic BIP38 RPC functionality test (Fuzzbawls)
c2cfff0a23 Tests: add size field to test json (Fuzzbawls)
2155506247 Add rpm contrib files (Fuzzbawls)
4e62dd9ee8 Main: reject non-final transactions using nLocktime from entering the mempool. (Fuzzbawls)
4c71b5694a [RPC] Ensure Tx/Budget input hashes are of the proper length (Fuzzbawls)
7d37c1c207 [RPC] Update and harden many raw transaction RPC commands (Fuzzbawls)
262f76a9d0 [RPC] Error early when block doesn't start with a coinbase transaction (Fuzzbawls)
7e0476b25a RPC: Add waitforblock/waitfornewblock/waitforblockheight (Fuzzbawls)
22bfe7ea2c [Tests] Initial update for regression test suite tests (Fuzzbawls)
93fd9f0501 Update block generation code to enable regtest mode (Fuzzbawls)
25fc43698b Build: add test runner packaging to configure (Fuzzbawls)

Tree-SHA512: 09bcd3c727eb85103451cf971e0bc3a27eca205318ebb6c600a26ddc97f58ef456aa6768c9e94fd5c484da5071887e5b50c2bcf90318cfe2c9178c0c746a408b

commit bae276af944b357b4ed5542c0ddf2db4081844fb
Author: Fuzzbawls<EMAIL_ADDRESS>Date:   Sun Feb 24 00:28:44 2019 -0800
Don't bother checking obfuscation messages

Obfuscation has all but been removed, no need to check incoming messages
for it's functionality anymore

commit 837f25f4e9187211620e747df3672d7130d7a48e
Author: Fuzzbawls<EMAIL_ADDRESS>Date:   Sat Feb 23 02:09:05 2019 -0800
[Wallet] Fix segfault with runtime -disablewallet

commit 51e7b2c4b012182ecee22930a9d19946d613648b
Merge: a611a7fa7 867d1b573
Author: Mrs-X<EMAIL_ADDRESS>Date:   Sat Feb 23 21:58:32 2019 +0100
Merge #816: [Doc] Update build-unix.md

867d1b5 [Doc] Update build-unix.md (Fuzzbawls)

Tree-SHA512: fcb195491a46328908146b26588595d3d93bfab8ceb658fb960dd9364fdb7f1c462c888b9cca74364344786722f208ff2f59d31b1fe820c0b8bf5b33a1546c64

commit 867d1b573fd1055661325aee2d355527abbf155c
Author: Fuzzbawls<EMAIL_ADDRESS>Date:   Sat Feb 23 00:18:00 2019 -0800
[Doc] Update build-unix.md

Update the Unix build notes to be more complete, with mentioning of the
GMP and ZeroMQ dependencies, as well as OpenSSL version note.

 To prevent erroring on regtest, and still allow for
manual/scripted changing of the block version, set some locical defaults
.

commit 3d588ead42b07c223a1370d09038d17b71f04fa4
Author: Fuzzbawls<EMAIL_ADDRESS>Date:   Sat Jan 26 21:15:19 2019 -0800
Tests: Remove whitespace in default conf file

commit ebdc552408e748a78fa4273ffd8091a0c3e57da1
Author: Fuzzbawls<EMAIL_ADDRESS>Date:   Sat Jan 26 21:14:30 2019 -0800
Fixup the walletdump command and python test

commit 37b29c7e618b8ca23faca3a08a870740357116f6
Author: Fuzzbawls<EMAIL_ADDRESS>Date:   Fri Sep 21 21:55:58 2018 -0700
[Tests] Add Basic BIP38 RPC functionality test

commit c2cfff0a234607acf413b1053c2c0ce260ad6e16
Author: Fuzzbawls<EMAIL_ADDRESS>Date:   Wed Sep 19 16:18:58 2018 -0700
Tests: add size field to test json

commit<PHONE_NUMBER>b19f5cad072953f8892b133938c951
Author: Fuzzbawls<EMAIL_ADDRESS>Date:   Wed Sep 19 14:17:50 2018 -0700
Add rpm contrib files

commit 4e62dd9ee8d00b016a315dd9f09197d6d9a3cedd
Author: Fuzzbawls<EMAIL_ADDRESS>Date:   Tue Sep 18 21:38:19 2018 -0700
Main: reject non-final transactions using nLocktime from entering the
mempool.

commit 4c71b5694a68ca2c27a88a579aaf21e2fd75dba9
Author: Fuzzbawls<EMAIL_ADDRESS>Date:   Tue Sep 18 21:34:07 2018 -0700
[RPC] Ensure Tx/Budget input hashes are of the proper length

Transaction and Budget hashes are always 64 characters in length. Return
 a descriptive error if this is not the case.

commit 7d37c1c207b8cb7f69664e5873ba6b882592234d
Author: Fuzzbawls<EMAIL_ADDRESS>Date:   Tue Sep 18 21:27:57 2018 -0700
[RPC] Update and harden many raw transaction RPC commands

commit 262f76a9d0d853970d40bd1828245d8a66d2ec3d
Author: Fuzzbawls<EMAIL_ADDRESS>Date:   Sun Sep 16 22:52:22 2018 -0700
[RPC] Error early when block doesn't start with a coinbase transaction

submitblock (used for PoW) can return an error message earlier by
checking that the first transaction is a coinbase transaction.

This prevents wasting time with running the block through later
validation checks that will ultimately fail.

commit 7e0476b25a81a442cfb22fea4aa414d7afcd6bec
Author: Fuzzbawls<EMAIL_ADDRESS>Date:   Sun Sep 9 12:43:49 2018 -0700
RPC: Add waitforblock/waitfornewblock/waitforblockheight

Used in functional tests

commit 22bfe7ea2c2904cffc11a45b8535073f30cdf47e
Author: Fuzzbawls<EMAIL_ADDRESS>Date:   Thu Jan 18 17:21:03 2018 -0800
[Tests] Initial update for regression test suite tests

TOTO: fixup all tests / add new ones

commit 93fd9f05019d388e3f50ceb39ced8f2710327fe7
Author: Fuzzbawls<EMAIL_ADDRESS>Date:   Sun Nov 19 22:14:51 2017 -0800
Update block generation code to enable regtest mode

Also update the icon/splash images for regtest

commit 25fc43698b71c9bbd9f8948c9652fc0c8b46b518
Author: Fuzzbawls<EMAIL_ADDRESS>Date:   Thu Sep 6 16:46:01 2018 -0700
Build: add test runner packaging to configure

commit e1974d23f31589f1c4e07062c7e4214abc281141
Author: furszy<EMAIL_ADDRESS>Date:   Fri Feb 8 15:32:49 2019 +0100
AcceptBlock() check for double spent serials only on main chain flag.

commit babdfb0f26b1733c0969f9106084134c0c774efa
Author: random-zebra<EMAIL_ADDRESS>Date:   Fri Feb 8 12:11:57 2019 +0100
remove extra debug lines in AcceptBlock

commit a9178bc6e0d5deb7b79690bc5f595beb8b19c720
Author: random-zebra<EMAIL_ADDRESS>Date:   Thu Feb 7 14:55:30 2019 +0100
AcceptBlock: contextual zcspend check on main chain

commit 0d49570f208baeee89b0c426541ed4434940ed34
Author: furszy<EMAIL_ADDRESS>Date:   Thu Feb 7 17:52:39 2019 +0100
AcceptBlock() block stored log removed

commit b74921756a3c93e8c9e8569cea68cbda873df10d
Author: random-zebra<EMAIL_ADDRESS>Date:   Thu Feb 7 13:31:19 2019 +0100
Fix bug on AcceptBlock when pindex is null

commit 97c266bd5c99f66006d4f017d6c9f2ad95ab8533
Merge: 6a16049df 45883b9fb
Author: furszy<EMAIL_ADDRESS>Date:   Thu Feb 7 13:19:30 2019 +0100
Merge branch 'invalid_blocks_storage_and_blocks_DoS_spam_filter' of https://github.com/furszy/ION into invalid_blocks_storage_and_blocks_DoS_spam_filter

commit 6a16049dfa27f7aba0bdeae4f35660daa734bf42
Author: furszy<EMAIL_ADDRESS>Date:   Tue Feb 5 22:10:27 2019 +0100
AcceptBlock() reject blocks double spending the coin stake input inside the same block

commit ed0dd2a20a87e9de56e9ff33387a8e68043fe840
Merge: 81c7c4764 9f89762dc
Author: Mrs-X<EMAIL_ADDRESS>Date:   Tue Feb 5 22:31:26 2019 +0100
Merge #802: [Refactor] Remove begin/end_ptr functions

9f89762 [Refactor] Remove begin/end_ptr functions (warrows)

Tree-SHA512: 420b7dad43df23876cd891104c8a3f1c557c9dc20fa726c69fe80eaf13b353e4301e8c0abc2abde29896f991dd88aaddc7d19996a3b7287a6244fbfd5700facf

commit 45883b9fb6230b40a4358426305da77a20a9fda4
Author: furszy<EMAIL_ADDRESS>Date:   Tue Feb 5 11:30:58 2019 +0100
AcceptBlock() invalid isBlockFromFork flag

commit 81c7c4764cbcb3274509ea65963cecf8eb8bbf63
Merge: 204c038a4 8e86b893a
Author: Mrs-X<EMAIL_ADDRESS>Date:   Mon Feb 4 20:33:10 2019 +0100
Merge #758: [Depends] Update libsecp256k1 to latest master

c6634ef Squashed 'src/secp256k1/' changes from 452d8e4d2..1086fda4c (warrows)

Tree-SHA512: 7ebcd89f661b94c7ee52c57c3b1879e5ddf363205b326c8ed442bd4f88765701f22b3413e296519b589a4b0d150488a9dd911459eb9b9834d4e8dde3e21049b1

commit da1b6836a5e11f0fb514ce7364eee2eaa033be3f
Author: furszy<EMAIL_ADDRESS>Date:   Mon Feb 4 03:47:18 2019 +0100
block spam filter, validate non null nodestate

commit 84de55a11ca23bb4cc8e8800358cedf9a8202d60
Author: furszy<EMAIL_ADDRESS>Date:   Mon Feb 4 00:24:14 2019 +0100
AcceptBlock() isBlockFromFork flag not contemplating prev blocks from forks fixed

commit 204c038a4d0f5529787802df9ffe1743b62551d0
Merge: d4762f7e7 5bd855c67
Author: Fuzzbawls<EMAIL_ADDRESS>Date:   Sun Feb 3 17:22:55 2019 -0800
Merge #768: [Net] Zerocoin Light Node Protocol

5bd855c673 removing apocaliptic comment (furszy)
95947bb9f7 logprint fixed (furszy)
91780b54cf log new line added + lightxionthread .h/.cpp (furszy)
95da6abadb Incorrect number of arguments for LogPrint(f) statement found. fixed (furszy)
d72543ffe3 node_bloom_light_zc invalid if statement fixed (furszy)
a9b992adcd remove old comment (furszy)
09ba617e26 remove tab spaces (furszy)
d373e1d25a minor updates to PR 768 (random-zebra)
7b2310cad4 Zerocoin Light Node Protocol (furszy)

Tree-SHA512: a85026a9626aacff07826d2a7eab198327d82d620fce4d1f64962e6c0158fa4a0c3c5c355aaed94809928fe5dd77e90810244cb04e41152517d48ebcb76d04f2

commit 5bd855c673fb00d8ece468af7db8c89b90e59a00
Author: furszy<EMAIL_ADDRESS>Date:   Tue Jan 22 17:40:26 2019 +0100
removing apocaliptic comment

commit 95947bb9f7b7f5fb3bb86dfa03446cf6ec55dde5
Author: furszy<EMAIL_ADDRESS>Date:   Mon Jan 21 14:07:06 2019 +0100
logprint fixed

commit 91780b54cf5ffba9cd96dc91ec9c7296458198b9
Author: furszy<EMAIL_ADDRESS>Date:   Mon Jan 21 13:25:09 2019 +0100
log new line added + lightxionthread .h/.cpp

commit 95da6abadb97384e2d8ad54e13a351fdbea0a25e
Author: furszy<EMAIL_ADDRESS>Date:   Fri Jan 18 00:37:37 2019 +0100
Incorrect number of arguments for LogPrint(f) statement found. fixed

commit d72543ffe3a80108b9b0876036a620e32d921114
Author: furszy<EMAIL_ADDRESS>Date:   Thu Jan 17 23:08:29 2019 +0100
node_bloom_light_zc invalid if statement fixed

commit a9b992adcdcba996982ed6dd38ceb1c418abb35b
Author: furszy<EMAIL_ADDRESS>Date:   Fri Dec 14 11:22:29 2018 +0100
remove old comment

commit 09ba617e267e0c52af315933f8bd5a253ece627d
Author: furszy<EMAIL_ADDRESS>Date:   Thu Dec 13 22:03:52 2018 +0100
remove tab spaces

tabs removed

tabs removed

commit d373e1d25a760633ff247492ff4f320938d383b8
Author: random-zebra<EMAIL_ADDRESS>Date:   Wed Dec 5 21:11:41 2018 +0100
minor updates to PR 768

commit 7b2310cad4c45548f0fc856c15ac1c805f196b5f
Author: furszy<EMAIL_ADDRESS>Date:   Thu Nov 8 01:11:11 2018 +0100
Zerocoin Light Node Protocol

commit d4762f7e7a6f4c7ed796fa9a574f9f9a95b0c4f9
Merge: 4a8e46a15 2159a5860
Author: Fuzzbawls<EMAIL_ADDRESS>Date:   Sun Feb 3 14:40:30 2019 -0800
Merge #763: [Wallet] Add automint address

2159a58601 Add newly created automint addresses to the set (Fuzzbawls)
1c0169e494 Show automint address state in getwalletinfo (Fuzzbawls)
9374d5123b Add RPC command to enable/disable automint address functionality (Fuzzbawls)
0a364d4ff8 Add UI option to enable/disable automint addresses (Fuzzbawls)
72491216cf Add runtime/startup option to disable automint address functionality (Fuzzbawls)
65aefe8021 Add newly created automint addresses to the address book (Fuzzbawls)
6c2df854d9 Ensure wallet is unlocked for createautomintaddress (Fuzzbawls)
4205d57c14 Add automint address (presstab)

Tree-SHA512: 76900c564eb6abe3cfa1606559aba4d6725be04126268b06215619fef8f83d58e953985469e2c97086a6cd0e6d60fb9f9e58aca1cee56e1a7bf9668e82c94fa8

commit 4a8e46a15829ae832aefdbf31fb59ad91a5b8870
Merge: a663bccea 189d6a958
Author: Fuzzbawls<EMAIL_ADDRESS>Date:   Sat Feb 2 17:11:56 2019 -0800
Merge #804: [Depends] Update zmq to 4.3.1

189d6a958e Update zmq to 4.3.1 (Dimitris Apostolou)

Tree-SHA512: 0226edb402b0594c616e580fe497d600eb2144d8eba8aa458d8255b093173306ff99429058c356e742896a4ac9ecbf92507b2da5cb16e8aa95c8c52860a20a21

commit<PHONE_NUMBER>b5305557a81b538f20871498595e34
Author: furszy<EMAIL_ADDRESS>Date:   Wed Jan 30 20:53:24 2019 +0100
AcceptBlock() - not accept blocks from a forked chain that exceed the max reorg limit

commit 47759e113cb12d5df7f60c13e79debbaef0a427c
Author: furszy<EMAIL_ADDRESS>Date:   Tue Jan 29 16:45:00 2019 +0100
AcceptBlock(), reject invalid PoS stake

commit e237823000153ef2b8ea72cc823ef9fd2739d4f0
Author: furszy<EMAIL_ADDRESS>Date:   Sun Jan 27 14:25:48 2019 +0100
validate non null pfrom on blockspamfilter check

commit c2e5459dff566a25616688ed0a502a471141c5b5
Author: furszy<EMAIL_ADDRESS>Date:   Sat Jan 26 22:29:22 2019 +0100
AcceptBlock(), serial double spend on the same block validation

commit 189d6a958e31e08f212d0a9cddecf257ae4d76f5
Author: Dimitris Apostolou<EMAIL_ADDRESS>Date:   Thu Jan 17 18:25:38 2019 +0200
Update zmq to 4.3.1

Addresses https://cve.mitre.org/cgi-bin/cvename.cgi?name=CVE-2019-6250

Signed-off-by: cevap<EMAIL_ADDRESS>
commit 3f5091986c5f0798fd2d234924dea6da29872bd0
Author: furszy<EMAIL_ADDRESS>Date:   Sat Jan 26 00:48:59 2019 +0100
zPoS validations of forked chains before store them + inputs check on prev split main chain

commit 64804b4bee2dda0f27a6f8a39f3a7f0bf0e24a3b
Author: furszy<EMAIL_ADDRESS>Date:   Fri Jan 25 12:26:30 2019 +0100
Invalid blocks from forks stored on disk fix + blocks DoS spam filter.

loop through forked blocks fix

Invalid blocks from forks stored on disk Fix + Blocks DoS spam filter

minor re organization

minor cosmetic changes

comments

commit 9f89762dcc8de13f48c2fdcfd0577ced16df2462
Author: warrows<EMAIL_ADDRESS>Date:   Wed Jan 23 20:17:54 2019 +0100
[Refactor] Remove begin/end_ptr functions

With C++11 these functions are not needed anymore and gracefully
replaced

commit a663bccea720e3a01607178906d5efed145a6dd8
Merge: 7fa20d69f 7dfa9b27f
Author: Mrs-X<EMAIL_ADDRESS>Date:   Mon Jan 21 20:37:12 2019 +0100
Merge #798: [Net] Improve addrman Select() performance when buckets are nearly empty

7dfa9b2 Improve addrman Select() performance when buckets are nearly empty (Pieter Wuille)

Tree-SHA512: 64a16dd027174a45931e73c82e04629738b4caca8500d8cb04a1739d5f5529726d3ff27357f0bdf881fc4ccf278a7a6ac2b904e3a7822af32d8dce096ef16dce

commit 7dfa9b27f8f3af1407599bc96a58056395278444
Author: Pieter Wuille<EMAIL_ADDRESS>Date:   Thu Aug 6 19:49:19 2015 +0200
Improve addrman Select() performance when buckets are nearly empty

commit 2159a5860151df5c4415f245b551112697961be9
Author: Fuzzbawls<EMAIL_ADDRESS>Date:   Fri Jan 18 01:33:32 2019 -0800
Add newly created automint addresses to the set

Ensures that a wallet restart isn't required after generating a new automint address by adding it to the set.

commit 1c0169e494c4d3927ac1ca5776655b2232ec573c
Author: Fuzzbawls<EMAIL_ADDRESS>Date:   Mon Jan 14 18:56:25 2019 -0800
Show automint address state in getwalletinfo

Adds a new output line to getwalletinfo showing if automint address functionality is enabled or disabled.

commit 9374d5123b98d294691667d891eac5cf46857b20
Author: Fuzzbawls<EMAIL_ADDRESS>Date:   Mon Jan 14 18:55:06 2019 -0800
Add RPC command to enable/disable automint address functionality

This compliments the UI's ability to toggle the state of automint address functionality for CLI/RPC users.

commit 0a364d4ff8067517ef555a273084efa74b3ae9d5
Author: Fuzzbawls<EMAIL_ADDRESS>Date:   Sun Jan 13 03:27:21 2019 -0800
Add UI option to enable/disable automint addresses

This compliments the runtime (command line) option of enabling/disabling the automint address functionality. Option can be toggled on/off without the need to restart the client.

commit 72491216cfd1edeb729ed8a585d2432b86983557
Author: Fuzzbawls<EMAIL_ADDRESS>Date:   Sun Jan 13 01:20:05 2019 -0800
Add runtime/startup option to disable automint address functionality

Defaults to true/enabled

commit 65aefe802168ed84784b7fb7a757b8d53c7348a6
Author: Fuzzbawls<EMAIL_ADDRESS>Date:   Sun Jan 13 01:17:44 2019 -0800
Add newly created automint addresses to the address book

Default account/label is hard-coded to "automint-address" so as to be visually identified in the wallet's GUI.

commit 6c2df854d98e634f95d22b7b6117e42962072c42
Author: Fuzzbawls<EMAIL_ADDRESS>Date:   Mon Jan 7 23:03:53 2019 -0800
Ensure wallet is unlocked for createautomintaddress

Also changed the return to a simple string (instead of a JSON object) to be consistent with other RPC commands that return just a single address.

commit<PHONE_NUMBER>afa6ab088281bee998801cd1267d2e
Author: warrows<EMAIL_ADDRESS>Date:   Mon Jan 7 15:24:43 2019 +0100
[Travis] Fix trailing whitespaces

commit 87b9809a0981425da3935b585822e5f658c8ea24
Author: warrows<EMAIL_ADDRESS>Date:   Thu Dec 27 14:02:49 2018 +0100
[UI] Rework proposal frames

commit 8b8a712e3c0797dea724b2abe1a03ffac8018790
Author: warrows<EMAIL_ADDRESS>Date:   Fri Dec 21 11:56:47 2018 +0100
[UI] Add global budget information to governance tab

commit f7674fbeebbb31171907c9c225b65ed21f8be0c8
Author: warrows<EMAIL_ADDRESS>Date:   Thu Dec 20 22:06:06 2018 +0100
[UI] Clean proposal list when updating

commit bbf327459438b29a53d691ea221ab9d30b53fa35
Author: warrows<EMAIL_ADDRESS>Date:   Thu Dec 20 14:34:25 2018 +0100
[UI] Use only one column for Proposal list

commit d6c68c6ec452d5b1378d428b508c725da8489bde
Author: warrows<EMAIL_ADDRESS>Date:   Thu Dec 20 11:59:07 2018 +0100
[UI] remove unused textlabel from governance page

commit 39eb903817e3dde0dffb137b455588a312a6dafe
Author: Fuzzbawls<EMAIL_ADDRESS>Date:   Mon Jun 4 00:36:03 2018 -0700
[Qt] Add basic GUI voting tab to the wallet

commit 4205d57c1465fcefbeb3a032f5ffd5af870c4536
Author: presstab<EMAIL_ADDRESS>Date:   Sun Oct 28 22:25:31 2018 -0600
Add automint address

commit 8e86b893a3adfa1d0f7b02a10bbcc24fb1d7fa14
Merge: 63fb77b0a c6634ef06
Author: warrows<EMAIL_ADDRESS>Date:   Tue Oct 23 11:22:46 2018 +0200
Merge commit 'c6634ef065ceb295522f0d61a3d45d8d53abe51c' into libsecp_update

commit c6634ef065ceb295522f0d61a3d45d8d53abe51c
Author: warrows<EMAIL_ADDRESS>Date:   Tue Oct 23 11:22:46 2018 +0200
Squashed 'src/secp256k1/' changes from 452d8e4d2..1086fda4c

1086fda4c Merge #354: [ECDH API change] Support custom hash function
1e6f1f5ad Merge #529: fix tests.c in the count == 0 case
c8fbc3c39 [ECDH API change] Allow pass arbitrary data to hash function
b00be6505 [ECDH API change] Support custom hash function
95e99f196 fix tests.c in the count == 0 case

git-subtree-dir: src/secp256k1
git-subtree-split: 1086fda4c1975d0cad8d3cad96794a64ec12dca4

this warning during compilation has been fixed, please check & verify this change as it should be pulled to bitcoin repo. I did not test if there is a warning with other compilers, but this should fix it on all of them if it occures.
Warning fixed:
leveldb/port/port_posix.cc: In function ‘bool leveldb::port::HasAcceleratedCRC32C()’:
leveldb/port/port_posix.cc:60:15: warning: ‘ecx’ may be used uninitialized in this function [-Wmaybe-uninitialized]
   return (ecx & (1 << 20)) != 0;
          ~~~~~^~~~~~~~~~~~

@cevap : it looks like you're in the middle of more changes. Please let me know when you need my help, or when I can review things more.
(In particular, before I can rebase any token code on this PR, I'd need the bech32 encoding back.)

@cevap : it looks like you're in the middle of more changes. Please let me know when you need my help, or when I can review things more.
(In particular, before I can rebase any token code on this PR, I'd need the bech32 encoding back.)

yes, there are more changes incoming, main.cpp, testsuite and some fixes.

I had to remove for now few rpc calls, like calculateaccumulators, but I added it back as getaccumulatorcheckpoints instead. Fundrawtransaction is also taken out for now (the one you wrote for a test) as I had to revert to bitcoin class.
I reverted the for extracting consensus folder and validation.h like it was in bitcoin. Main problem on that is the source code uses bitcoin class everywhere and with each addition/change more changes have to applied where some might get missed at all. Maybe here you could think on a possibility how to use both of them or source's without to change source code which is mainly maintenanced by other devs.
we have currently protocol enforement spork active, current PR can be synced with main network but it will stall unless you change protocol version restriction.
on regtest I have one issue, that is accumulator checkpoints, as after you create zerocoin and it gets accepted, there is an error, please check it as addition if you can.
python scripts cant properly deserialize, probably

Can you undo this commit please?
c4d58e7
I actually need the AccessCoin() wrapper and the Coin class.

Actually its not there only in current commit, but if you can wait for the next push, this is AccessCoin() in new code.
const CCoins* CCoinsViewCache::AccessCoins(const uint256& txid) const
{
    CCoinsMap::const_iterator it = FetchCoins(txid);
    if (it == cacheCoins.end()) {
        return NULL;
    } else {
        return &it->second.coins;
    }
}

EDIT: pushed

Thanks.
I'll include the wrapper to AccessCoin() and the Coin class in my own branch..
AccessCoins() links to a tx, while AccessCoin() links to an output. CCoins is also different from Coin. As you know, at one point Bitcoin changed the chainstate db from tracking tx's to tracking outputs.. This AccessCoin() wrapper is an intermediary step. The intermediary step will be enough for me, especially given the call that we had last Friday regarding a potential change in the tx structure.

ok, I guess it would be better to have it in splitted PR from current but I would not mind to include it in current. If you PR it to current PR's branch, then we will have separate PR (for better overview) and all changes merged with current PR.

ok, I guess it would be better to have it in splitted PR from current but I would not mind to include it in current. If you PR it to current PR's branch, then we will have separate PR (for better overview) and all changes merged with current PR.

The commits that we need to use as input are here: https://github.com/cevap/ion-old-v3/commits/master?after=65a0290287705b715d4485573ab3cf3170d6cc46+81
I can get on that when this branch has stabilized.

ok, I guess it would be better to have it in splitted PR from current but I would not mind to include it in current. If you PR it to current PR's branch, then we will have separate PR (for better overview) and all changes merged with current PR.

The commits that we need to use as input are here: https://github.com/cevap/ion-old-v3/commits/master?after=65a0290287705b715d4485573ab3cf3170d6cc46+81
I can get on that when this branch has stabilized.

this is exactly what I mentioned before with bitcoin's class. we should not implement it the same way as it was by replacing the source code instead of extending it which should keep the compatibility with sources for ability of proper and in time maintenance, like this https://github.com/cevap/ion-old-v3/commit/f0d2206b7ed422ac77b259a79419bf917aea13b2 commit, it breaks compatibility with the source code.

@cevap
OK I see why the tests fail for sighash_test..
SignatureHashOld() serializes txTo.nVersion when nVersion=1
SignatureHash() serializes writes txTo.nVersion
Our chain always has nVersion=1 (It is taken from CTransaction::CURRENT_VERSION, which has always been 1)
However, the test suite writes random numbers to nVersion.
So, we should either replace:
if (nVersion == 1) READWRITE(*const_cast<uint32_t*>(&nTime));

with
READWRITE(*const_cast<uint32_t*>(&nTime));

https://github.com/ioncoincore/ion/blob/da00ce1d21829ff6a1580a225d247f196f0663df/src/primitives/transaction.h#L237
Or we should replace:
        ::Serialize(s, txTo.nTime, nType, nVersion);

with
        if (txTo.nVersion == 1)
            ::Serialize(s, txTo.nTime, nType, nVersion);

https://github.com/ioncoincore/ion/blob/da00ce1d21829ff6a1580a225d247f196f0663df/src/script/interpreter.cpp#L1065
Both options solve this test.
I think the first option is better, but it's up to you.. Apologies for not spotting this immediately.


[WIP] [SYSTEMML-1969] Support single-precision operations on GPU backend

Since single-precision operations are faster on most GPU, we should allow our users to perform the instructions on GPU in single precision.
The GPU backend has been refactored to support arbitrary precision.
This feature can be enabled via configuration property sysml.gpu.dataType. The valid values for this property are double and float. We can support half/mixed precision in a separate PR.

@nakul02 @bertholdreinwald @mboehm7  @dusenberrymw @prithvirajsen

Refer to this link for build results (access rights to CI server needed):
https://sparktc.ibmcloud.com/jenkins/job/SystemML-PullRequestBuilder/2190/

Refer to this link for build results (access rights to CI server needed):
https://sparktc.ibmcloud.com/jenkins/job/SystemML-PullRequestBuilder/2194/

I have added a bugfix for sum.
@nakul02 can you please review this PR ?

@niketanpansare I think this is really great. Could you please also share the bigger picture and transition plan on our dev list (e.g., initially local to GPU convolution ops, then calls to native BLAS libraries, then java/native convolution ops, and later general support for all operations and backends)? Since this is a big step, it would be good to let everybody know.

Done.

@niketanpansare This is great.  Single precision on GPU is necessary for any heavy deep learning work, so it's great to see that the project is moving in that direction.

Refer to this link for build results (access rights to CI server needed):
https://sparktc.ibmcloud.com/jenkins/job/SystemML-PullRequestBuilder/2197/

Refer to this link for build results (access rights to CI server needed):
https://sparktc.ibmcloud.com/jenkins/job/SystemML-PullRequestBuilder/2198/

Refer to this link for build results (access rights to CI server needed):
https://sparktc.ibmcloud.com/jenkins/job/SystemML-PullRequestBuilder/2199/

Refer to this link for build results (access rights to CI server needed):
https://sparktc.ibmcloud.com/jenkins/job/SystemML-PullRequestBuilder/2203/

Refer to this link for build results (access rights to CI server needed):
https://sparktc.ibmcloud.com/jenkins/job/SystemML-PullRequestBuilder/2204/

Refer to this link for build results (access rights to CI server needed):
https://sparktc.ibmcloud.com/jenkins/job/SystemML-PullRequestBuilder/2206/


Turn Table into Diagram

Value Proposition
As a Developer
I want to display table data as a diagram
So that the user has a better UX
Description
13 картинки
Acceptance Criteria

[ ] A diagram is displayed that visualises the data that was put into the table
[ ] The diagram replaces the table

Tasks
(for developers team)

[ ] start a new branch
[ ] implement chart.js
[ ] The table isn't shown anymore
[ ] Running data is handled via state management

Complexity
L

Hello Josh! I'd use a different value proposition. Actually, this user story is not about adding value for the developer, like for example refactoring code would be. It's about adding value for the user. A good value proposition could be something like this:
As a user
I want to see my data in a diagram
So that I can judge my progress instantly

Thanks @UniversalTraveller !
Done ✅


nasa-veda-prod role has limited bucket access

Context
https://github.com/2i2c-org/infrastructure/blob/master/terraform/aws/projects/nasa-veda.tfvars defines hub_cloud_permissions which limits the buckets that the nasa-veda-prod role (defined in prod.values.yaml) can access.
Is the reason for this a concern about users making request to requester pays buckets? Otherwise, this seems unnecessarily restrictive. By default, I cannot access data in any public bucket on the VEDA 2i2c JHub.  (For example s3://nex-gddp-cmip6)
Proposal
remove the bucket whitelist, or determine a way to provide that role with access to any bucket that is not requester-pays
Updates and actions
No response

@freitagb  @ranchodeluxe @j08lue curious on your thoughts here

The primary reason is to make sure we don't accidentally provide access to buckets with sensitive data (particularly tf state) that might happen to be in the same project and don't have additional controls applied. The tfstate for the hub is not in S3 in the account, but since we aren't the exclusive users of this account we aren't sure.
Happy to turn that into a wildcard! See https://github.com/2i2c-org/infrastructure/pull/2618 for the previous round of this specific conversation with @ranchodeluxe

buckets with sensitive data (particularly tf state) that might happen to be in the same project

if we are talking buckets in the same AWS account, there is no concern from me regarding wild-carding. We do not have or plan to have buckets with sensitive content in the same project, @abarciauskas-bgse.
But @freitagb is better positioned to approve this.

This is a good point: "accidentally provide access to buckets with sensitive data (particularly tf state) that might happen to be in the same project". It seem like ensuring no one and no system creates a bucket with sensitive information in that account could be hard to ensure. But I also want to make sure we are enabling users to have direct s3 access to any bucket which permits public access. 🤔

It seem like ensuring no one and no system creates a bucket with sensitive information in that account could be hard to ensure.

Yep, that's my worry! Allowing arbitrary code execution inside an AWS account isn't a very common pattern, so we run into issues like this that aren't super common elsewhere.
I'll wait for @freitagb to chime in!

I think being able to access any public s3 bucket is pretty important for doing a lot of research, and this restriction might unnecessarily hobble the hub. So I propose that:

An audit is done of the existing S3 buckets in the account, to see if any of them are sensitive. I see some cdk metadata buckets there that would be readable if we allow full s3 read, so would someone in your team be able to do this audit?
Once done, we somehow at least write up a policy somewhere that internal S3 buckets here should have more specific permissions, to prevent accidental exposure
Once done, we can open up s3 read access.

How does that sound, @freitagb and @abarciauskas-bgse?

This sounds like a good plan to me. Do you have any suggestions on doing the audit or automating enforcement of a bucket policy?
Ideally, we allow the nasa-veda-prod role access to any publicly accessible bucket and any "official" VEDA-sanctioned bucket, which at the moment would likely be the current list of buckets in the policy. It doesn't need to have access to any other buckets in that account.
Restricting access to those other buckets seems like a simpler solution than trying to ensure there's no sensitive data in those buckets. I think ideally we are also not storing sensitive information in S3 buckets.
A few ideas about enforcing bucket access for the nasa-veda-prod role:

I'm pretty sure, but haven't tested it yet, that we could add an ALLOW for wildcard access, an ALLOW for specific buckets in the account AND a DENY for everything else in the account. This seems like the simplest thing to do if it's possible.
Use AWS config (or perhaps there is some other AWS policy enforcement tool I'm not aware of) to ensure all buckets except the VEDA data buckets have a DENY policy for this nasa-veda-prod role. Something like what is detailed here: https://aws.amazon.com/blogs/security/how-to-use-aws-config-to-monitor-for-and-respond-to-amazon-s3-buckets-allowing-public-access/. this seems cumbersome but definitely feasible.

I am googling around for s3 scanner for scanning for sensitive information in S3 buckets but haven't found anything promising yet.

@abarciauskas-bgse is this something we still want to do? Is there anything I can do to try and help move this along?


Improve known_device.yaml writing

Description:
This PR improves the writing of known_devices.yaml by escaping strings properly.
The bluetooth tracker sometimes discovers devices with names that start with brackets, i.e. `[TV] Samsung', which is invalid yaml if not in quotes
Related issue (if applicable): Reported on gitter after 0.30 known_device loading PR
Checklist:
If the code does not interact with devices:

[x] Local tests with tox run successfully. Your PR cannot be merged unless tests pass
[x] Tests have been added to verify that the new code works.

The key was default_flow_style=False :+1:


Can't start rancher with external mysql -- liquibase

Rancher Version:
latest stable
Docker Version:
Docker version 1.12.3, build 6b644ec
OS and where are the hosts located? (cloud, bare metal, etc):
Centos BareMetal
3.10.0-327.36.3.el7.x86_64
Setup Details: (single node rancher vs. HA rancher, internal DB vs. external DB)
HA 3 nodes
Environment Type: (Cattle/Kubernetes/Swarm/Mesos)
N/A
Steps to Reproduce:
run mysql in docker container --
then try to start rancher server by setting the db values
Results:
[main] [liquibase] modifyDataType will lose primary key/autoincrement/not null settings for mysql.  Use  and re-specify all configuration if this is the case
over and over
Expected:
if I run without external mysql:
i get this
2016-11-10 21:37:37,091 INFO    [main] [ConsoleStatus] [2/32] [75ms] [75ms] Loading config-defaults
2016-11-10 21:37:40,293 WARN    [main] [liquibase] modifyDataType will lose primary key/autoincrement/not null settings for mysql.  Use  and re-specify all configuration if this is the case
2016-11-10 21:37:40,293 WARN    [main] [liquibase] modifyDataType will lose primary key/autoincrement/not null settings for mysql.  Use  and re-specify all configuration if this is the case
2016-11-10 21:39:12,811 INFO    [main] [ConsoleStatus] [3/32] [95795ms] [95720ms] Loading system

@andreimc  Hi am getting the same issue how did you solve yours

@andreimc ping


ModuleNotFoundError: No module named 'pytorch_lightning.utilities.distributed'

when i try to execute the command "python gradio_diffbir.py --ckpt weights/general_full_v1.ckpt --config configs/model/cldm.yaml --reload_swinir --swinir_ckpt weights/general_swinir_v1.ckpt --device cuda",the program give me this error message,my  operation system is linux,GPU is A100,and i follow the giving steps below the code strictly,i will be appreciate it if you can help me solve this problem

I tried "pip install pytorch_lightning==1.7.7" for inference.py and it worked. maybe for "gradio_diffbir.py" will work too.

I tried "pip install pytorch_lightning==1.7.7" for inference.py and it worked. maybe for "gradio_diffbir.py" will work too.

thank you，i will try it soon


chore(deps): upgrade dependencies

Upgrades project dependencies. See details in workflow run.

Automatically created by projen via the "upgrade-k8s-24-main" workflow

⚪ Backport skipped
The pull request was not backported as there were no branches to backport to. If this is a mistake, please apply the desired version labels or run the backport tool manually.
Manual backport
To create the backport manually run:
backport --pr 946

Questions ?
Please refer to the Backport tool documentation


refine test in repartition.rs & coalesce_batches.rs

During I read partition related code, I found there are some places to be refined

Nice cleanup!


Feature request: Make generic achievement metadata more accesible

I am currently working on making an OSRS 2011-style adventurer's log (see pic). It is using Dink as it's engine for pushing log data (admittedly not the intended usecase). I chose Dink because it is avaiable in both HDOS as well as Runelite.

repo: https://github.com/J3sven/OSRS-alog
One issue I am facing with Dink right now is that the (combat) achievement, Quest point and Collectionlog counters do no update until a relevant event has occured. A method of accessing this data more readily would be much appreciated, especially considering accounts with any of these stats maxed would never see an update until their cap is raised.
Some suggestions:

Simply include the data in every webhook request (perhaps a bit overkill)
A generic log in/log out notification that lists the user's stats and achievement data. This could be something desirable for general users too as a reference of what progress they made that day.

I don't think the first idea is the way to go, having optional data like that in all payloads sent out greatly increases their complexity. Currently we don't hide much metadata like that and I don't think we should. Just filter events sent to the webhook.
Having a more generic data sync on log-in/log-out might be more beneficial including for other uses.
Also worth noting that we are not in control of HDOS' fork of our plugin. It's closed source and integrated into the client itself.

I am aware about the HDOS side of things, but me and brainfree speak fairly regularly so I think that won't cause much delay :)

I am aware that the HDOS fork is separate from the main repo, me and brainfree do speak fairly often and he is aware of the project so if a patch were to land I could probably give him a nudge to get it integrated :)

Having a more generic data sync on log-in/log-out might be more beneficial including for other uses.
After some sleep I would like to mention that if you guys do decide to go down this road you will probably want to keep track and maybe only fire the event once per daily reset or 24h local time, as to not spam the user if they go worldhopping a bunch.

Our thought-process was to fire it only to non-discord integrations, it would basically have no impact on the user & the handler could just ignore them where applicable.

Our thought-process was to fire it only to non-discord integrations, it would basically have no impact on the user & the handler could just ignore them where applicable.

Oh that makes a lot of sense, for sure!


301 instead of correct 404 or 401 on APIs

As an API user, I expect to have the correct 4XX response, instead of a redirect.
How to test:
https://[HOST]/api/v2/deeplink/parse_play_url.js -> 404.
https://[HOST]/api/v1/deeplink/report -> 403.

#36 will fix deeplink API url.
https://[HOST]/api/v[x|/deeplink/parse_play_url.js -> 404. with x > 2.
v1 and v2 now available.


doctr for scanned pdf

I have doctr installed ,  When I upload a photo, it works very well and extracts text perfectly. However, when I upload a scanned PDF, it keeps processing for a very long time without any response or error. What could be missing?
it works also with a scanned pdf but : for exemple first page is not scanned (contains title or a sentence etc) and all the next pages are scanned , it extracts text from all the pages perfectly , but when the whole pdf is scanned it keeps processing without response.

By default docTR isn't used if many pages for PDF.  It's possible it's using OCR (unstructured package) instead.  Can you tell from the command line?  I would disable unstructured and OCR from expert panel in UI and try again.  You can disable via CLI as well.

Hello, thank you for responding. Actually, it's not for a specific PDF as mentioned. In general, if the PDF contains a title or something similar that is not scanned, and all the subsequent pages are scanned, it extracts  , doctr works and extract text from the entire file. If the whole PDF is scanned, it continues processing without a response. I'm showing you an example in this video: The first document contains 7 pages. The first page contains a title that is not scanned, and the next 6 pages are all scanned. However, the tool extracts text from all pages (I can verify this through the document viewer ==> view database text). The second document is the document "image_based_pdf_sample" found in the test folder in h2ogpt, which is similar to my problematic documents. As you can see, it continues processing without responding. I shortened the video so I could share it here, but it's still processing, as shown in the screenshot.
https://github.com/h2oai/h2ogpt/assets/168529190/25c21a9c-a6ef-4ff9-938f-b53d6d92d411

Can you do two things?

Add --verbose to he CLI options
do ps -auxwf |grep -A 5 -B 5 generate and share to see what is running.
When it's stuck, do kill -s SIGUSR1  for the  that is the "generate.py" pid from above or a deeper fork (lower in list below generate in tree) and share the full output that goes to console.  It will include many threads and that may show where it's stuck.

Also, can you try gpt.h2o.ai -- do you have similar issues?  This will help identify if it is an installation or computer issue.

I guess DocTR has issues with windows VM.


Asymmetric configuration of demographic rates

The rate parameters for Births (birth_rate') and Deaths (death_rate) are applied to the whole population as a denominator whereas the seemingly-similar parameter (fertility_rate`) for Pregnancy is only applied to women. This difference in denominators could lead to misconfiguration?
The difference in parameter names (fertility_rate vs birth_rate) is helpful and seemingly technically correct, but we still might need better documentation to be clear there's a factor of ~2 difference here!
Seems like this might primarily be a documentation issue, I've labeled as such.
This said, we could minimally improve the code comment regarding the units parameter for pregnancy. It's not wrong, but could be more clear to say "per 1000 women" for Pregnancy and "per 1000 people" for Births.
units = 1e-3, # Assumes fertility rates are per 1000. If using percentages, switch this to 1

Closed by #745


Update to bevy 0.10

Are there any plans for updating this crate to support bevy 0.10?

Done with bevy_renet 0.0.7: https://github.com/lucaspoffo/renet/releases/tag/0.0.11


Revert "Fix importing patch_decoder"

reverts https://github.com/google-research/timesfm/pull/32

I'm pretty sure that "fix" actually broke this repo as a module
I belive the error ImportError: attempted relative import with no known parent package occurs if people try to run src/timesfm.py directly
and they might have reason to do so because this reop did not work as a module on it's initial release
adding to this this repo is structured weirdly
so people might be confused on how they should be using this repo and running the code

shoud they be cloneing this in ther peoject as a module
should they colne this project and add they own code into src/
should they clone this as take parts of the code into the own project

timeline

before fix code structure https://github.com/google-research/timesfm/commit/24bd19c74bd6b28eb576437f21b22b20f6536520 this repo only works under several conditions so people migh comewith diffrent creative ways ways of running the code
after the commit fix code structure https://github.com/google-research/timesfm/commit/24bd19c74bd6b28eb576437f21b22b20f6536520 made this reop worked as a module but breaks running itdirectly
then https://github.com/google-research/timesfm/pull/32 makes src/timesfm.py + src/patched_decoder.py as standload code but breaks this a module

I sugest mergeing this PR reverting https://github.com/google-research/timesfm/pull/32 to make it function as a module for now
and in the future restructure the project completely to a more typical structure like

├── README.md
├── timesfm/            <---- package name
│   ├── __init__.py
│   ├── module.py
│   └── module.py
└── other stuff/
    ├── generate_awesomeness.py
    └── decrease_world_suck.py

the reason I don't perform the restructure myself in this PR is because a the restructure of the project would cause existing users to have issues, my intention is to only get back to a code working state

CLA...
just treat this as a issue post


chore: add custom log level support for common_telemetry::init_default_ut_logging()

I hereby agree to the terms of the GreptimeDB CLA
What's changed and what's your intention?
add custom log level support for common_telemetry::init_default_ut_logging()
Checklist

[ ]  I have written the necessary rustdoc comments.
[ ]  I have added the necessary unit tests and integration tests.

Refer to a related PR or issue link (optional)

cc @killme2008 @evenyag @waynexia Please take a look if you are available.


Multiple hooks ID not executed properly

Cool work, thanks a lot!
Description of problem:
I'm currently testing webhook, and I found out, that you can't have multiple hooks triggered with one name. Theoretically you can, but in practice you can't, I'm still learning go, so please correct me, if there is something I did not get.
In your webhook.go code we can see this loop: https://github.com/adnanh/webhook/blob/master/webhook.go#L190-L242
Snippets:
if err != nil {
        msg := fmt.Sprintf("error parsing JSON: %s", err)
        log.Printf(msg)
        w.WriteHeader(http.StatusBadRequest)
        fmt.Fprintf(w, msg)
        return
}

if err != nil {
        msg := fmt.Sprintf("error evaluating hook: %s", err)
        log.Printf(msg)
        w.WriteHeader(http.StatusInternalServerError)
        fmt.Fprintf(w, msg)
        return
}

if ok {
        log.Printf("%s hook triggered successfully\n", h.ID)

        for _, responseHeader := range h.ResponseHeaders {
                w.Header().Set(responseHeader.Name, responseHeader.Value)
        }

        if h.CaptureCommandOutput {
                response := handleHook(h, &headers, &query, &payload, &body)
                fmt.Fprintf(w, response)
        } else {
                go handleHook(h, &headers, &query, &payload, &body)
                fmt.Fprintf(w, h.ResponseMessage)
        }

        return
}

Which has many return that break the for loop (whether it succeeded or not), I would suggest to have a less restrictive behaviour with continue and log an error message at the end if really nothing executed.
How reproducible:
Always
Steps to reproduce:

Create hooks.json with different hooks and 2 with the same name, but different command/arg
Rerun webhook if not hotreload
Do action to trigger the hook
Observe the logs

ex of hooks.json file used (I also varied the orders of hooks, just in case):
> cat hooks.json
[
  {
    "id": "webhook2",
    "execute-command": "/tmp/script2.sh",
    "pass-arguments-to-command":
    [
      {
        "source": "payload",
        "name": "head_commit.id"
      },
      {
        "source": "payload",
        "name": "head_commit.author.name"
      },
      {
        "source": "payload",
        "name": "head_commit.author.email"
      }
    ]
  },
  {
    "id": "webhook",
    "execute-command": "/tmp/script3.sh",
    "pass-arguments-to-command":
    [
      {
        "source": "payload",
        "name": "head_commit.id"
      },
      {
        "source": "payload",
        "name": "head_commit.author.name"
      },
      {
        "source": "payload",
        "name": "head_commit.author.email"
      }
    ]
  },
  {
    "id": "webhook",
    "execute-command": "/tmp/script1.sh",
    "pass-arguments-to-command":
    [
      {
        "source": "payload",
        "name": "head_commit.id"
      },
      {
        "source": "payload",
        "name": "head_commit.author.name"
      },
      {
        "source": "payload",
        "name": "head_commit.author.email"
      }
    ]
  }
]

Testing scripts look like this (just to know what is called with which arguments):
> tail -n +1 /tmp/script*
==> /tmp/script1.sh <==
#!/bin/bash

echo $0
echo $@

==> /tmp/script2.sh <==
#!/bin/bash

echo $0
echo $@

==> /tmp/script3.sh <==
#!/bin/bash

echo $0
echo $@

Expected results:
To have all matching hooks executed, because I don't want the execution to be stopped. Whether it ran fine or not (if typo in one, if service unavailable, if you just want multiple tasks run, etc).
Additional info:
Attached is a first draft of a patch suggested.
fix-return.patch.txt

Correct, this is indeed an issue and not an expected behavior. Could you please create a PR into the development branch with proposed fixes?
Thanks!

Sure, working on it.


chore(main): release 2.3.0

:robot: I have created a release beep boop
2.3.0 (2024-09-08)
Features

add fzf_lua for slash commands (895fbf9)

This PR was generated with Release Please. See documentation.

:robot: Created releases:

v2.3.0
:sunflower:


Rename CompileSpec and RunSpec to clear names

Drop the names CompileSpec/RunSpec and use more descriptive names.

Hmmm I didn't think spec vis config was confusing. IMO they're basically synonymous in this case, with spec having a bit more of a declarative connotation, perhaps.

Agreed.

So I guess my proposal is: E2EModelRunConfig = CompileConfig + VMFBExecutionConfig
@ScottTodd any thoughts?

Those names make sense to me, as do the proposed names in this PR.
How about picking names that just match what tools they are associated with? CompileAndRunConfig = IREECompileConfig + IREERunModuleConfig?

How about picking names that just match what tools they are associated with? CompileAndRunConfig = IREECompileConfig + IREERunModuleConfig?

But And in the name is so gross :-P

Makes sense to me. Use VMFBExecutionConfig for RunConfig and E2EModelRunConfig for RunSpec.
I still rename CompileSpec to ModelCompileConfig since I want to remove the term "Spec" here.

I was trying to find a better name to differentiate compile_config and model_compile_config, but have no idea right now. Merge this change first.


add hot cabaret scan

closes #3031
Checklist:

[ ] Updated extVersionCode value in build.gradle for individual extensions
[ ] Updated overrideVersionCode or baseVersionCode as needed for all multisrc extensions
[x] Referenced all related issues in the PR body (e.g. "Closes #xyz")
[x] Added the isNsfw = true flag in build.gradle when appropriate
[x] Have not changed source names
[ ] Have explicitly kept the id if a source's name or language were changed
[x] Have tested the modifications by compiling and running the extension through Android Studio
[x] Have removed web_hi_res_512.png when adding a new extension

same with this one as #3154

build failed

build failed

I'll try to fix both today


Update README.md

Added recipe for apt-vim to README

Is the idea that people copy-paste the JSON chunk into their shell? Isn't there a more elegant way?

There are a couple of alternatives, yes. I selected the copy/paste to terminal because I thought it was least error-prone method of the options I had considered. I agree with you that it reveals all of the ugliness to the user, which is unfortunate.
One alternative would require a slight extension of apt-vim to support individual package installation from JSON.  This would allow for a method by which to hide the ugliness of the recipes.  For example, the JSON I added to the README could be stored in a JSON file in your (or other Vim plugins) repo root like so:
@vimpkg
{
    "depends-on": [
        {
            "name": "node",
            "recipe": {
                "darwin": [
                    "brew install node"
                ],
                "linux": [
                    "sudo apt-get install -y node npm"
                ]
            }
        }
    ],
    "name": "tern_for_vim",
    "pkg-url": "https://github.com/marijnh/tern_for_vim.git",
    "recipe": {
        "all": [
            "npm install"
        ]
    }
}

Then, when a user runs apt-vim install from the cloned directory, the package could be picked up by automatically based on JSON files with @vimpkg and running context (i.e. executing apt-vim from the cloned directory).
I'm very open to input :-)

The apt-vim docs talk about installing from urls. Can we set up something to allow that instead?

Yes, I think I can set it up to automagically check for installation recipes before asking the user to input a recipe. I'll update you when I have something working. Thanks :-)

Thanks a bunch for a push in the right direction! Now, config's for individual plugins can be stored in the repo itself (see the vim_config.json that I added).
When apt-vim install <url> is executed, apt-vim first checks the cloned repo for a JSON with @vimpkg as the first line.  If a valid JSON is found, its configuration is used. Otherwise, perform a regular install with user prompts etc.

Wonderful! Merged as dbc3ea1


enhanced footer

Fixes: #509
normal

for 768px

for 600px

@PSS2134 please check

Fixes: #509
normal
for 768px
for 600px

Here In mobile view, the careerZunction content in footer does not seem to be in center also its too seperated from below content, please fix that, also see if its responsive for tab view

Fixes: #509
normal
for 768px
for 600px

Here In mobile view, the careerZunction content in footer does not seem to be in center also its too seperated from below content, please fix that, also see if its responsive for tab view

can you give me a screen shot, so that i can know what will be the normal behavior

@ayush-848 I am talking about this one

@ayush-848 I am talking about this one

ok

@PSS2134


import TimesFm on Google colab isn't working after the last commit

Following code stopped working after the last commit on colab.  Greatly appreciate a help. Thank you.
! git clone https://github.com/google-research/timesfm.git
%cd timesfm
!pip install -e .
!pip install utilsforecast
!pip install transformers accelerate bitsandbytes
!huggingface-cli login --token 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
#!pip install --upgrade numpy
!pip install numpy

import datetime
import yfinance as yf
import matplotlib.pyplot as plt
import numpy as np
import pandas as pd
import timesfm
from timesfm import TimesFm # <- STOPS HERE!!

Error Message
ImportError: cannot import name 'TimesFm' from 'timesfm' (unknown location)

There was a typo in the dependencies. Just fixed it. Can you try it again?

Now it's working !! Thanks a lot !!

This problem is not solved again.


How do I know if oh-my-zsh is running?

I am on a brand new MBP and upgraded to Yosemite before I did anything else. I have been using oh-my-zsh for a few years on my now crashed old MBP. Unfortunately, I am really struggling with getting it working on Yosemite.
I have tried installing with both curl and via the manual method. I have a .zshrc file.
My problem is that I can't tell if oh-my-zsh is running. The themes are not working for certain. I use "robbyrussell".
It seems like it used to print a big ascii image of "oh-my-zsh" before. Now I get nothing. I'm pretty sure it's not running.
When I try to run .oh-my-zsh/oh-my-zsh.sh by hand, I get:
./.oh-my-zsh/oh-my-zsh.sh: line 13: syntax error near unexpected token `('
./.oh-my-zsh/oh-my-zsh.sh: line 13: `for config_file ($ZSH/lib/*.zsh); do'

I'm not running in the bash shell though. ps -f $$ yields:
➜  ~  ps -f $$
UID   PID  PPID   C STIME   TTY           TIME CMD
501  1851  1850   0  6:30PM ttys000    0:00.24 -zsh

I have the same issue in the same line. Is there any update for that? Thanks.

@mcornella I think you can go through your entries. I find the reason is I have the same entires in bash_profile and zshrc file. When I remove one, it works fine now. I hope it helps you.

@mcornella I think you're in effect right; the script was running in bash or sh, even though the user was running zsh.
To execute oh-my-zsh by hand, you need to use a slightly different syntax. Use this . ./.oh-my-zsh/oh-my-zsh.sh, with the leading dot or source. This forces zsh to execute it as zsh commands inside the current shell.
(You mention that it seems to do nothing, and return you to the command prompt: that's the expected behavior. Since it's supposed to run on shell startup, it's silent unless something goes wrong (or you're using an odd plugin). The big ASCII-art image of "oh my zsh" is only printed by the installer when you set it up for the first time, or an upgrade happens.)
If you just type oh-my-zsh.sh or ./.oh-my-zsh/oh-my-zsh.sh, that tries to run it as a separate executable. Normally, this would just error out.
$ ./.oh-my-zsh/oh-my-zsh.sh
zsh: permission denied: ./.oh-my-zsh/oh-my-zsh.sh

But if you've set the u+x execute bit on that file somehow, then the OS will attempt to run it as a separate program like a regular executable. There's no shebang line at the top of oh-my-zsh.sh. So... I think whatever's running it (in this case, I think the OS X kernel) will fall back to looking at the executable's file extension to decide what to run it in. And despite being a ZSH-specific script, the extension here is .sh, so it gets run in plain old shell.
I can reproduce the behavior by doing a chmod u+x on it.
janke@eilonwy:~ $ chmod u+x ./.oh-my-zsh/oh-my-zsh.sh
janke@eilonwy:~ $ ./.oh-my-zsh/oh-my-zsh.sh
./.oh-my-zsh/oh-my-zsh.sh: line 26: syntax error near unexpected token `('
./.oh-my-zsh/oh-my-zsh.sh: line 26: `for config_file ($ZSH/lib/*.zsh); do'

Now, it says "zsh" in the output, but that's a red herring, because the upgrade line is explicitly invoking zsh in a subshell. If I edit oh-my-zsh.sh to add some diagnostics (echo ps pid=$PID; ps; pstree -p $PPID; echo my vars; set), it's clear that it's actually sh that's running it. (Which in this case is bash in sh emulation mode.) (pstree is from a brew install pstree; it's not in base OS X.)
   \-+= 00296 janke /Applications/iTerm.app/Contents/MacOS/iTerm
     \-+= 05433 root login -fp janke
       \-+= 05434 janke -zsh
         \-+= 05730 janke sh ./.oh-my-zsh/oh-my-zsh.sh
           \-+- 05734 janke pstree -p 5434

So, I'm guessing what's going on is: oh-my-zsh was loading fine all along, you just had some minor issues with themes, and maybe got tripped up by a subtle script invocation issue while trying to debug it.
If you can describe in more detail what oh-my-zsh features aren't working for you when you think it's running, we can probably fix those up.

@coolgeng sorry for totally missing your comment. Can you extend on how you solved it? I want to understand the relation between your .bash_profile and .zshrc files.

Backing up a bit to answer the original question: oh-my-zsh initialization sets the variables $ZSH_CUSTOM, $ZSH_CACHE_DIR, $ZSH_COMPDUMP, and $SHORT_HOST. If you do set | grep -a ZSH\|SHORT_HOSTand see them present, then oh-my-zsh has probably been loaded in your current zsh process.

Yeah. Agree with your diagnosis that @HuckyDucky was running the init script instead of sourcing it. This issue can be closed, but I'm still waiting on @coolgeng's response.

Cool.
What do you think about adding a #!/bin/zsh shebang line to the top of oh-my-zsh.sh to identify it as a zsh-specific script? And maybe have it explicitly check that $ZSH is set? That could catch this and related error cases, and produce more useful error messages.


Changed Slugs when Syncing Dashboards

I wrote a bash script that runs in Github Actions and uses Looker Deployer to sync dashboards and looks from our dev Looker instance to our prod Looker instance. We are not syncing the entire /Shared folder every time, we are syncing subfolders.
Internally, Looker Deployer is running a series of Gazer commands to accomplish that syncing. I am using the "deploy content" command in Looker Deployer. You can see the gazer commands that it runs here:
https://github.com/llooker/looker_deployer/blob/master/looker_deployer/commands/deploy_content.py#L76
As you can see, it runs gazer with --force.
When we move an existing dashboard to a new subfolder, when we are syncing using --force, then **it seems like ** Gazer deletes the existing dashboard and sync a new copy. That delete moved the existing dashboard to the Trash folder. When this happens there is nothing listed in the "deleted by" column of some of the deleted dashboards in our Trash folder on our prod Looker instance, but I can't always duplicate this behavior. Sometimes Gazer just creates a new dashboard in the new folder without deleting the old dashboard, even though we are only moving the dashboards between different child folders of the parent folder we are syncing.
Gazer syncs dashboards **using a new slug ** because it detects that there is a dashboard with a duplicate slug in the Trash/in the other folder on the production Looker instance. You can see the code that does that here:
https://github.com/pixability/gazer/blob/master/lib/gzr/commands/dashboard/import.rb#L141
As a result, the dashboard slugs are out of sync sometimes and that breaks links in our dashboards on the prod instance.
Another note here: Since the team that runs the sync jobs doesn't have admin access to our  prod Looker instance, we can't ask them to make sure that dashboards are hard deleted. We need to have someone from the dev team manually intervene.
If you seen this before, and am I accurately understanding what is happening? Can you tell me what the expected behavior is, and whether there are any workarounds for this?

This is the bash script I'm using, for reference:
folder_name=${1}
dest_folder_name=${2}
git clone $GIT_REPO && cd dashboards && git checkout -b new_branch
(rm -r ./"$folder_name" || :)
echo "exporting space $folder_name using gazer"
id=gzr space ls "$folder_name" --host $DEV_HOST --fields id --plain
echo "id $id"
for i in $id
do
gzr space export $i --host $DEV_HOST --debug
break
done
echo "export of space $folder_name successful \n\n"
git add .
(git commit -am "Export of folder $foldername" || :)
git checkout -
git merge new_branch master
(git push origin master:master || :)
(git branch -D new_branch || :)
fin=ldeploy content --env prod --folders "$folder_name" --recursive --target-folder "$dest_folder_name" --debug
echo "import of space $folder_name completed \n\n"

@megfordpix is this still an issue you're able to reproduce?  If so, could you please respond with the Looker and python version you're using? Thanks!

Closing ticket, feel free to re-open if issue persists.


Errors when opening a file with a gql tag; no syntax highlighting

Hi there! I recently updated a vim-graphql, and started getting errors when opening files with gql tags, and no syntax highlighting is shown. The errors are:
Error detected while processing /home/u0/mgeraci/.vim/bundle/vim-graphql/after/syntax/javascript/graphql.vim:
line   10:
E117: Unknown function: graphql#javascript_tags
E116: Invalid arguments for function join(graphql#javascript_tags(), '\|') . '\)'
E15: Invalid expression: '\%(' . join(graphql#javascript_tags(), '\|') . '\)'
line   12:
E121: Undefined variable: s:tags
E15: Invalid expression: 'syntax region graphqlTemplateString start=+' . s:tags . '\@20<=`+ skip=+\\`+ end=+`+ contains=@GraphQLSyntax,jsTemplateExpression,jsSpecial extend'
line   13:
E121: Undefined variable: s:tags
E15: Invalid expression: 'syntax match graphqlTaggedTemplate +' . s:tags . '\ze`+ nextgroup=graphqlTemplateString'
line   10:
E117: Unknown function: graphql#javascript_tags
E116: Invalid arguments for function join(graphql#javascript_tags(), '\|') . '\)'
E15: Invalid expression: '\%(' . join(graphql#javascript_tags(), '\|') . '\)'
line   12:
E121: Undefined variable: s:tags
E15: Invalid expression: 'syntax region graphqlTemplateString start=+' . s:tags . '\@20<=`+ skip=+\\`+ end=+`+ contains=@GraphQLSyntax,jsTemplateExpression,jsSpecial extend'
line   13:
E121: Undefined variable: s:tags
E15: Invalid expression: 'syntax match graphqlTaggedTemplate +' . s:tags . '\ze`+ nextgroup=graphqlTemplateString'
Press ENTER or type command to continue

I tried checking out a few different commits of the plugin, and found that the breaking change was in https://github.com/jparise/vim-graphql/commit/1ad3aa6f9fad65c646fdabe057ea883c34a73a3d (the last working version is 792c7bcb138c1e787a7527f16ce63e8cf53df6ba). I'm seeing this error with any commit after the working version, including at master.
It's possible that there's some odd interaction with other plugins; let me know what I can do to help debug this issue!
Vim Version
VIM - Vi IMproved 8.0 (2016 Sep 12, compiled Jun 21 2019 04:10:35)
Included patches: 1-197, 322, 377-378, 550, 649, 651, 703, 706-707
Extra patches: 8.1.1401, 8.1.1382, 8.1.1368, 8.1.1367, 8.1.1366, 8.1.1365, 8.1.1046, 8.1.0613, 8.1.0547, 8.1.0546, 8.1.0544, 8.1.0540, 8.1.0539, 8.1.0538, 8.1.0506, 8.1.0208, 8.1.0206, 8.1.0205, 8.1.0189, 8.1.0177, 8.1.0067, 8.1.0066
Modified by<EMAIL_ADDRESS>Compiled by<EMAIL_ADDRESS>Huge version without GUI.  Features included (+) or not (-):
+acl             +file_in_path    +mouse_sgr       +tag_old_static
+arabic          +find_in_path    -mouse_sysmouse  -tag_any_white
+autocmd         +float           +mouse_urxvt     -tcl
-balloon_eval    +folding         +mouse_xterm     +termguicolors
-browse          -footer          +multi_byte      +terminfo
++builtin_terms  +fork()          +multi_lang      +termresponse
+byte_offset     +gettext         -mzscheme        +textobjects
+channel         -hangul_input    +netbeans_intg   +timers
+cindent         +iconv           +num64           +title
-clientserver    +insert_expand   +packages        -toolbar
-clipboard       +job             +path_extra      +user_commands
+cmdline_compl   +jumplist        -perl            +vertsplit
+cmdline_hist    +keymap          +persistent_undo +virtualedit
+cmdline_info    +lambda          +postscript      +visual
+comments        +langmap         +printer         +visualextra
+conceal         +libcall         +profile         +viminfo
+cryptv          +linebreak       -python          +vreplace
+cscope          +lispindent      -python3         +wildignore
+cursorbind      +listcmds        +quickfix        +wildmenu
+cursorshape     +localmap        +reltime         +windows
+dialog_con      -lua             +rightleft       +writebackup
+diff            +menu            -ruby            -X11
+digraphs        +mksession       +scrollbind      -xfontset
-dnd             +modify_fname    +signs           -xim
-ebcdic          +mouse           +smartindent     -xpm
+emacs_tags      -mouseshape      +startuptime     -xsmp
+eval            +mouse_dec       +statusline      -xterm_clipboard
+ex_extra        +mouse_gpm       -sun_workshop    -xterm_save
+extra_search    -mouse_jsbterm   +syntax
+farsi           +mouse_netterm   +tag_binary
   system vimrc file: "$VIM/vimrc"
     user vimrc file: "$HOME/.vimrc"
 2nd user vimrc file: "~/.vim/vimrc"
      user exrc file: "$HOME/.exrc"
       defaults file: "$VIMRUNTIME/defaults.vim"
  fall-back for $VIM: "/usr/share/vim"
Compilation: gcc -c -I. -Iproto -DHAVE_CONFIG_H   -Wdate-time  -g -O2 -fdebug-prefix-map=/build/vim-xBMBkh/vim-8.0.0197=. -fstack-protector-strong -Wformat -Werror=format-security -U_FORTIFY_SOURCE -D_FORTIFY_SOURCE=1
Linking: gcc   -Wl,-z,relro -Wl,-z,now -Wl,--as-needed -o vim        -lm -ltinfo -lnsl  -lselinux -lacl -lattr -lgpm -ldl

@mgeraci what does :echo graphql#javascript_tags() (on your vim command line) output?

From the working commit:
E117: Unknown function: graphql#javascript_tags

And from the broken commit:
E117: Unknown function: graphql#javascript_tags

So it seems like regardless of the vim-graphql version, I'm missing that function.

1ad3aa6f9fad65c646fdabe057ea883c34a73a3d introduced the autoload/graphql.vim file, which is where that function is defined. If that file hasn't made it into your &runtimepath, that would explain the problem you're seeing.
Do you have that file in your .vim/bundle/ path (as /home/u0/mgeraci/.vim/bundle/vim-graphql/autoload/graphql.vim)? Are you using a plugin manager or some other tool to update your plugins?

When I check out 1ad3aa6f9fad65c646fdabe057ea883c34a73a3d, I do see that file created in my vim bundle folder. So that would definitely imply that there is something wrong in my tooling!
I'm using pathogen to load vim plugins, and homeshick to sync and symlink dotfiles (including vim plugins as submodules in my dotfile repo).
And thinking about that actually led me to the resolution of the issue... Because symlinks aren't dynamic or anything, when I updated your plugin and it added a new file, I needed to re-link my dotfiles.
So, in closing, there is nothing at all wrong with your code, it was all on me! But I really appreciate you taking the time to respond and help me debug this. Thank you!

Glad you got it working!


feat: cmd gf prebuild suport oracle

Codecov Report
Base: 78.17% // Head: 78.16% // Decreases project coverage by -0.00% :warning:

Coverage data is based on head (f51f94e) compared to base (14d2d74).
Patch has no changes to coverable lines.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2312      +/-   ##
==========================================
- Coverage   78.17%   78.16%   -0.01%
==========================================
  Files         584      584
  Lines       48535    48535
==========================================
- Hits        37942    37938       -4
- Misses       8579     8583       +4
  Partials     2014     2014

Flag
Coverage Δ

go-1.15-386
78.18% <ø> (+0.01%)
:arrow_up:

go-1.15-amd64
78.20% <ø> (+0.04%)
:arrow_up:

go-1.16-386
78.18% <ø> (-0.02%)
:arrow_down:

go-1.16-amd64
78.22% <ø> (+0.06%)
:arrow_up:

go-1.17-386
78.21% <ø> (+0.02%)
:arrow_up:

go-1.17-amd64
78.21% <ø> (+0.02%)
:arrow_up:

go-1.18-386
78.10% <ø> (-0.01%)
:arrow_down:

go-1.18-amd64
78.11% <ø> (+<0.01%)
:arrow_up:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files
Coverage Δ

os/gcache/gcache_adapter_memory_lru.go
89.13% <0.00%> (-8.70%)
:arrow_down:

os/gfpool/gfpool_file.go
65.71% <0.00%> (-2.86%)
:arrow_down:

os/glog/glog_logger_rotate.go
63.34% <0.00%> (-1.36%)
:arrow_down:

os/gfsnotify/gfsnotify_watcher_loop.go
88.23% <0.00%> (+3.36%)
:arrow_up:

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.


Fix typo in OCaml module.

Just a typo in config (although it seems working fine on my machine).

Good catch! Thanks for the help!


cool-retro-term doesn't start

Issue description
nix-shell -p cool-retro-term --run cool-retro-term

QQmlApplicationEngine failed to load component
qrc:/main.qml:24 module "QtGraphicalEffects" is not installed

Cannot load QML interface

Technical details

system: "x86_64-linux"
host os: Linux 4.19.51, NixOS, 19.09pre182971.a1dd419c1ff (Loris)
multi-user?: yes
sandbox: yes
version: nix-env (Nix) 2.2.2
channels(philipp): ""
channels(root): "nixos-19.09pre182971.a1dd419c1ff"
nixpkgs: /nix/var/nix/profiles/per-user/root/channels/nixos

AFAIK some QT stuff won't run unless installed in NixOS systemPackages or via nix-env.  We touched it just recently again: https://github.com/NixOS/nixpkgs/issues/12027#issuecomment-501236677

Ah, I see. I'll close this then.


help

how can i change the icon of the game of the emulator to change it  to be the gamepad  and not to be the console

I am unsure what you mean tbh. Can you maybe provide a photo of the icon you want changed?

This to that

You need to make a custom icon that has the same file name as the ROM. The README should contain all information you need.


Announcing the package on Discourse?

I feel like the package is nice. At the same time, it would be nicer if we would be able to get rid of (some of) the perf bottlenecks. Maybe we could announce it on Discourse, also maybe asking for help about these issues?

Or we could announce the packages, I have built https://github.com/Tortar/HybridStructs.jl for another use case of mine, since the packages are small we could maybe announce them together :D


Touchpad configuration T570

Issue description
I would like to be able to move over half the distance of the synaptics touchpad in order to move over the full width of my 4K screen.
Additionally, if someone has any pointers ( ^-^ ) to make the hardware work as intended, that would be great.
Technical details

system: "x86_64-linux"
host os: Linux 4.9.61, NixOS, 17.09.2182.7f6f0c49f0 (Hummingbird)
multi-user?: yes
sandbox: no
version: nix-env (Nix) 1.11.15
channels(root): "nixos-17.09.2182.7f6f0c49f0"
nixpkgs: /nix/var/nix/profiles/per-user/root/channels/nixos/nixpkgs

You may set services.xserver.libinput.enable = true (and leave services.xserver.synaptics.enable unset) and configure the touchpad in your desktop settings (if libinput does not solve your problem outright).

I tried the former (it was the first thing I tried), but that resulted in no working mouse pointer at all.
The mouse pointer I have now working is one without any multi-touch features where scrolling happens on the right side of the pad.
After I upgraded to the latest kernel, I was able to have a larger min and max speed, so the most important problem has been resolved.

services.xserver.libinput.enable = true; and configuring the touchpad via systemsettings5 works fine when you configure the scrollspeed with kernel 4.13.4. The 17.09 kernel doesn't seem to work well.

The mouse pointer I have now working is one without any multi-touch features where scrolling happens on the right side of the pad.

Try services.xserver.libinput.naturalScrolling = true.

The 17.09 kernel doesn't seem to work well.

In what way?

min and maxspeed had a smaller range in the Plasma5 configuration widget with that kernel.

Thanks for the info! Is this issue resolved now?

I was able to setup two-finger scrolling via the Plasma5 widget combined with the above configuration. I am satisfied :)
Closing.


Text granularity

Comparing with sublime, which shows a perfect representation of the graphic spaces between letters, here the lines become full blocks of pixels.
Maybe it is not hidpi enabled yet, but it appears to render fonts with pixelsize 2 or even 3.
Tried disabling hardware acceleration, no effect.
Using a macbook retina.

We're using a canvas and drawing blocks for chars where sublime uses the GPU to rescale a bitmap, the same results can't be achieved we the current possibilities offered by web technologies.
You can always plays with the minimap settings if you find the default render too large, my own setup use 1px char width, 1px char height and 1px of interline.

I understand...
Thank you!


Add initial support for bitwise operations on WinRT enums

Fixes #115.
This only adds support for & and |. We need to decide if every enum should support &=, |=, ^, and ^=.

Is there any reason you're doing this by hand and not with the bitflags crate?

@jcotton42 I didn't want to add a dependency until it became clear we would actually gain something. I'd like to see how much code it would be to implement this on our own.


Add Hindi documentation to international documentation page

@jespino I saw an issue regarding the same in another language, so adding the translation for Hindi language would cater to a larger audience. I can work on this issue

Hi @kichloo! Thanks for opening this issue. We really appreciate you offering to do this. Would you be open to detailing which issue you saw and which guides you plan to translate? We have some other translations pending so it'd be great to know what's coming down the line. :)

@justinegeffen Reference issue: #3664
Regarding the type of file, can you paste some links of the files to be translated? I will choose a file and will do it with 100% accuracy and efficiency.

Havent got any reply yet. Kindly reply regarding the same. And if not interested, kindly tell so that I do not work on issue which is not to be considered by the organization.

Hi @kichloo. I apologize for the delay! Here are the two PRs that are currently open https://github.com/mattermost/docs/pull/3457 and https://github.com/mattermost/docs/pull/3664. Both PRs have an extensive collection of files as they've translated the Getting Started Guide.
In terms of your contribution, I recommend joining the i18n channel on our community server. You'll find documentation related to processes as well as information about the tools we use.
We really appreciate your interest and I look forward to your PR. :)

@justinegeffen Thanks for reverting. I searched through the files and found Readme.md a workable file to start the documentation in Hindi for the organization. Kindly tell so that I can start working on this same.

Hi, @kichloo! Thanks for getting back to me. One suggestion I can offer is that you post your proposal in the i18n channel if you haven't already. The reason for this is the channel contains all the information you need to get started with translations in terms of the tools and processes we use. In addition, the community members could also assist you in terms of the next steps once you've completed your proposed work (for example, review process, publishing the content etc).
The file you've linked is a great start, however it's in a separate repository to this one and I am not certain what the translation process is or whether we have a requirement for it to be translated.
The Getting Started guide is one I'd recommend looking at in terms of this project.
All that said, I know the localization community are extremely happy to help and answer questions around the best way to get started so I definitely recommend joining that channel first.
Hope this helps! :)

@justinegeffen Joined the community. And just a question, you want me to translate the whole  Getting Started guide or the subsequent links such as

Light Install Guide

Installation
Add Users
Create a Notifications Hub

In the example you've provided, those links are sub-headings within a single article so if you open https://docs.mattermost.com/help/getting-started/light-install.html you'll see that it's all on one page. I'd say that that article is a great place to start. :)

@justinegeffen Ok. I will start translating this page. Also, since this month is Hacktoberfest, this organization is participating Hacktoberfest? Also, are there any prerequisites to be completed before starting the contribution like DCO,CLA etc.

We are participating in Hacktoberfest, and when you submit a PR you need to sign the CLA. The information around the CLA is posted when you submit your PR. :) @jasonblais can confirm that your PR would be included as a Hacktoberfest contribution.

@kichloo Yes, we are participating in Hacktoberfest and your PR would count towards the event. Thanks for your interest in contributing!

@justinegeffen Now, I have started the translation. And wanted to know that should the software names such as Ubuntu be written in English/ Hindi, whichever seems good with the organization.

Thanks, @kichloo. We don't currently have a preference as the translations have primarily been in-product. We're very open to working with the community to put together a standard for translating the documentation which would include naming conventions. One option is to raise this in the i18n channel as there are very experienced community members who may have considered this previously and have feedback to share. :)

@justinegeffen No problem. First will make the PR. Then, will make the suggested changes, if any.

@jasonblais I see the others PR are ready to get merged for a long time and I have been quite a blocker here since I was disagreeing at that time with you to translate these guides /outside/ any translation tool.
Since I changed my mind about this, please revive the other 2 PRs o that they get can pass the test and be finally merged ;)
I'm in a catchup period right now and I see the CI build failing constantly as notifications in my mail box ;)

Hi @wget, there is in fact some work left to fully support translated documentation, so the other two PRs haven't yet been merged. But @justinegeffen is actively working on it.

Ah ok ;) I'll mute these PRs for now then ;) Note: I won't be receiving any new notification unless if you mention me there explicitly ;)

Hi @wget! I've also been a blocker for this and am going to be reviving them as Jason mentioned. I've moved my comments to this thread for visibility.

@justinegeffen @jasonblais Kindly check the PR


Warn if use_docker evaluates to True but the python docker package is not available.

Why are these changes needed?
By default autogen tries to execute code in a Docker container, but only if the python docker package is installed. Otherwise the default is to run in the native environment (even if Docker tools are otherwise installed). This can be confusing. This pull request logs a warning in this scenario, but does not change this default fallback behavior -- which is subject to change in the future.
Related issue number
N/A
Checks

[ ] I've included any doc changes needed for https://microsoft.github.io/autogen/. See https://microsoft.github.io/autogen/docs/Contribute#documentation to build and test documentation locally.
[ ] I've added tests (if relevant) corresponding to the changes introduced in this PR.
[ ] I've made sure all auto checks have passed.

Codecov Report

Merging #172 (174c1eb) into main (d8ebf6c) will decrease coverage by 0.25%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main     #172      +/-   ##
==========================================
- Coverage   41.23%   40.98%   -0.25%
==========================================
  Files          17       17
  Lines        2093     2096       +3
  Branches      467      468       +1
==========================================
- Hits          863      859       -4
- Misses       1154     1160       +6
- Partials       76       77       +1

Flag
Coverage Δ

unittests
40.98% <100.00%> (-0.16%)
:arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

Files
Coverage Δ

autogen/code_utils.py
46.52% <100.00%> (-2.38%)
:arrow_down:


Specify aws credentials account

I have many accounts in my ~/.aws/credentials file , is possibile to launch createResource.sh specifying which aws account to use?

Hi @RickyGeek ,
At this time this is not on the roadmap. I'd suggest you set a default profile when you run the script.
Vladimir

Would it be possible to specify which profile to use by changing this line in createResource.sh
aws_cmd=${aws_cmd:-aws}
to
aws_cmd=${aws_cmd:-aws --profile [example-profile]}


Helm: Promote to Beta - Status

This issues is just used to track the status of pending activities needed to promote Helm to Beta.
Reference: https://github.com/istio/enhancements/blob/master/features/helm-installation.md
After a discussion with @jacob-delgado , the following items still need to be completed to have the promotion.

[x] Update helm integration tests
[ ] Make targets to build the latest tarballs along with the release
[x] Enable Helm Linting
[X] Documentation for advanced helm chart customization
[ ] Document about the attributes in values.yaml

Add documentation for tarball helm downloads and changes to gateway to use those tarballs

Not sure what this is, especially if helm repo is on the only supported option?

Document some of the important attributes in values.yaml

maybe we can have all of them..? or just link to https://artifacthub.io/packages/helm/istio-official/istiod?modal=values

Add documentation for tarball helm downloads and changes to gateway to use those tarballs

Not sure what this is, especially if helm repo is on the only supported option?

Makes sense. Will not document about the tarball option.

Make targets to build the latest tarballs along with the release

What exactly is required for this task?

Make targets to build the latest tarballs along with the release

What exactly is required for this task?

@keithmattix we were trying to optimize the helm integration tests for upgrade scenarios which currently uses tarballs. So everytime a release is made, we manually upload the newer tarballs. But I think the way forward is to get rid of the tarballs fully, and promote repo based install. I am currently trying to use --version argument and modify the upgrade tests. If that works, this subtask for tarballs may not be needed, and will remove

Cool, thanks for the update! Let me know if there's anything o can do to help get the Helm charts to beta!

@kfaseela @howardjohn thanks for all of the great work on this. Is there currently a way to install istio via helm in a non-default namespace (outside of istio-system), or do we have to generate the manifests with the edited namespaces ourselves, and install via kubectl apply -f?

@kfaseela @howardjohn thanks for all of the great work on this. Is there currently a way to install istio via helm in a non-default namespace (outside of istio-system), or do we have to generate the manifests with the edited namespaces ourselves, and install via kubectl apply -f?
helm install istio-base istio/base -n kube-system --set namespace=kube-system --set values.global.istioNamespace=kube-system
Gives the following error:
Error: INSTALLATION FAILED: namespaces "istio-system" not found

will check this and get back to you

@nshankar13 : replace values.global.istioNamespace with global.istioNamespace and it should work.
helm install istio-base istio/base -n ns-1 --set namespace=ns-1 --set global.istioNamespace=ns-1  --create-namespace

@kfaseela thanks, that worked!


Add optional https urls

Revisiting https://github.com/stympy/faker/pull/460
Adds optional scheme support to Faker::Internet.url in a backwards-compatible way.
🐙

:+1:

@kaiuhl A sincere question here: why not use named parameters? I ask this because I've seen in other classes in this same project people prefer not to use named parameter (even when the method has too many params to keep count). I'm just starting to make efforts to contribute to open source and I had this question bugging me.

It was only possible since 7c14fb5707ce35cc44fa36708d04d817fcae775c so any class introduced before this likely couldn't support them without doing it the old way

Thanks, @b264! And how does this thing move? I mean, how is it decided to change the old ways to use the new way (named params)? Once again, I'm just trying to figure this out. =)

@tiagofsilva The general idea is that: breaking backwards-compatibility with people's existing code would require a version bump to 2.0.0 per semantic versioning, which is typically only done when absolutely necessary to implement an ImportantNewNeededFeature which cannot be done in a backwards-compatible way.  So an existing class that already does not use named parameters should not be switched unless it's during a major version bump, and even then, usually only if it adds something substantial to the functionality.  New features/classes that didn't exist before are completely different things, and probably should use named parameters.

@b264 Appreciate that.


Hi, can you provide the script to generate pkl files?

Hi, can you provide the script to generate pkl files?

I would like to ask the specific difference between the organization of pkl in the code and the organization of the nuScenes dataset.
Can you provide a script for generating PKL files? thank you


How To Detect Offset

Hello , I have some new questions about offset
I encounter a game use ue4 with version 4.26 that can't dump with your tool .
i think maybe the offset differ with ue4.25 .
so i wan't to know whether there's a way to calculate the offset quickly ?

i can't understand the offset why is 0xd0 , as usually is 0x10 , just like the struct as below .

@Chensem Because the namepool pointer you can find doesn't point directly to FNameEntryAllocator. Find any function that uses the blocks variable like FNamePool::Resolve and confirm the blocks offset. In my case i found blocks usually at +0xd0 so FNameEntryAllocator must be at +0xc0 from the pointer.

Oh , I compile the source code , then use ida to analyze the offset .
Thank For Your Reply .
^ ^ ~

Oh , I compile the source code , then use ida to analyze the offset .
Thank For Your Reply .
^ ^ ~

Hi bro can you help me complete the source i got so much error


If an SDLRPCMessage object is initialized using initWithName, the messageType is always set to "request"

Regardless of the type of message, if an SDLRPCMessage object is initialize using initWithName, then the messageType is automatically set to "request".
messageType = NAMES_request;

This should instead set the messageType to whatever is appropriate based on the message.
A simple way of doing this would to override the initWithName function in SDLRPCRequest, SDLRPCNotification, and SDKRPCResponse, and set the messageType in that override instead.
For example, the override in RPCNotification might look like:
-(id) initWithName:(NSString*) name {
	if (self = [super initWithName:name]) {
		messageType = NAMES_notification;
		[store setObject:function forKey:messageType];
	}
	return self;
}

This should be checked to see if it affects #45