CTest status bar button text appears malformed

Brief Issue Summary
Formatting of the text for CTest in the status bar appears malformed.
Expected:
CTest button has text like "X tests passing".
To reproduce:

Enable CTest via include(CTest)
Build simple program
Notice CTest button in the status bar appears malformed

Apparent Behavior:
CTest button has text like "X/Y tests passing', passing, total)}"
As shown:

Platform and Versions

Operating System: Windows 10 -- Version10.0.18362 Build 18362
CMake Version: 3.15.4
VSCode Version: 1.40.1
CMake Tools Extension Version: 1.2.2
Compiler/Toolchain: Visual C++ 2017

Other Notes/Information
Issue occurs with only CMake Tools enabled. A very simple repository which demonstrates this bug is here: https://github.com/dstodev/cmake-tools-ctest-bug

Thanks for reporting the issue.  Too bad it just missed our update. ☹  I have a fix in PR.

Thank you!

The colours also seem to be at odds with the colour scheme.  Is this intentional?
Bright yellow in a low-contrast colour scheme (Solarized) is pretty unpleasant, and it seems impossible to remove.

@willvousden I moved your issue to a separate topic.

CMake Tools 1.2.3 was published today and includes a fix for this issue (except #952). Let us know if you encounter any other problems.


[bug][Linux] the bot works in window mod but not when HS is fullscreen

Actually, with Linux, the bot manipulate HS when it is in a window.
I don't know why but in fullscreen there is a problem :

some screenshot doesn't match imagefile (but it works in window mode ...)
the bot doesn't interract properly in fullscreen

Don't have time to work on this one (other bug/improvment priorities)
If somebody want to check on this one ...


Clarify when locality is NULL for SHOW LOCALITY

Not just for single-node clusters, but any time a node is started
without --locality specified.

This change is

Online preview: http://cockroach-docs-review.s3-website-us-east-1.amazonaws.com/3207b2b0dcb217746900d635ad051bdd371cdb90/
Edited pages:

v19.2/show-locality.md


MSID: 103259 Version: 1 DOI: 10.1101/2<IP_ADDRESS>3899

MSID: 103259
Version: 1
Preprint DOI: https://doi.org/10.1101/2<IP_ADDRESS>3899
Step 1. Awaiting reviews
Editorial to post reviews via hypothesis
Useful links:

DocMap: https://data-hub-api.elifesciences.org/enhanced-preprints/docmaps/v2/by-publisher/elife/get-by-manuscript-id?manuscript_id=103259
New model tracking: https://docs.google.com/spreadsheets/d/1_fHaoOy7hjyocptKtVJRijeNpUY4hBS7Ck_aVmx6ZJk/
Reviews on sciety: https://sciety.org/articles/activity/10.1101/2<IP_ADDRESS>3899

For trouble shooting (e.g. no Docmaps available):

DocMap issue addressing: https://miro.com/app/board/uXjVNCwK6EI=/
Explore DataHub DocMaps API: https://lookerstudio.google.com/reporting/4c2f0368-babb-4beb-b5b3-497e7e7b0f08/page/ejphD
Unmatched submissions and preprints: https://lookerstudio.google.com/u/0/reporting/9f86204f-3bf7-477c-9b18-5c5ef141bf69/page/p_gxi57ha93c
Unmatched manuscripts spreadsheet: https://docs.google.com/spreadsheets/d/15QcK8w-ssB7109RQEDtFpJPZ0J5HTGxoHa_2TtpMBbg/edit#gid=1336081641

Step 2. Preview reviewed preprint
Production QC content ahead of publication
Instructions:

QC preview: https://prod--epp.elifesciences.org/previews/103259v1
Update ticket with any problems (add blocked label)
When QC OK, add QC OK label to ticket and add publication date and time to https://docs.google.com/spreadsheets/d/1amAlKvdLcaDp5W8Z8g77NmkwbMF5n_u89ArSqPMO8jg
Move card to next column
(At end of the day post link in #enhanced-preprint and ask for PDF to be generated)

Useful links:

Preprint DOI :  https://doi.org/10.1101/2<IP_ADDRESS>3899
Confirm reviews returned by EPP: https://prod--epp.elifesciences.org/api/reviewed-preprints/103259/v1/reviews
To update the MECA path in the docmap: https://docs.google.com/spreadsheets/d/1mctCQuNFBjSn97Lihy7_vBO6z7-N-oqyLv4clyi6zHg

Step 3: Awaiting search reindex
This step adds the reviewed preprint to the homepage: https://elifesciences.org
The search reindex is triggered once an hour. We need the reviewed preprint to be indexed as the search application serves the journal homepage.
Useful links:

Jenkins pipeline to reindex search can be triggered sooner or monitored here: https://alfred.elifesciences.org/job/process/job/process-reindex-reviewed-preprints/

Step 4: Published! PDF requested
Waiting for PDF to be generated
Useful links:

PDF tracking: https://docs.google.com/spreadsheets/d/106_XeDjmuBae7gexOTNzg60lapeqjl2aRn9DzupGyS8/

Step 5: Introduce PDF to data folder and git repo
Upload PDF to relevent folder in git repo https://github.com/elifesciences/enhanced-preprints-data/
Step 6: Done!

[ ] Kettle is on!

Hi @fred-atherden, the authors are from NIH but the licence is 4.0, I changed this in the XML but still displaying 4.0 on preview?

Thanks @rkcook312, EPP takes the license information from the DocMap currently.
In order to change it, we'd need it updated in eJP. @acollings, please could you assist?

Thanks! @rkcook312 fixed in eJP!


relative templateUrl not working

Bug Report or Feature Request (mark with an x)
- [x ] bug report -> please search issues before submitting
- [ ] feature request

Versions.
@angular/cli: 1.0.0
node: 6.10.0
os: darwin x64
@angular/common: 4.0.0
@angular/compiler: 4.0.0
@angular/core: 4.0.0
@angular/forms: 4.0.0
@angular/http: 4.0.0
@angular/platform-browser: 4.0.0
@angular/platform-browser-dynamic: 4.0.0
@angular/router: 4.0.0
@angular/cli: 1.0.0
@angular/compiler-cli: 4.0.0
macOs - sierra 10.12.3s
Repro steps.
I have updated an angular-cli generated project from beta.22-1 to the last version (1.0.0) released 24/03.
The log given by the failure.
No logs.
Desired functionality.
Before i could load the templates as ./app.component.html.  That doesn't work anymore. A full path (ex. templateUrl: './src/app/app.component.html') does work.
I know this is a very vague issue but maybe there is something obvious I'm missing?

Hi @El4a ,
Any chance you can upload an example project for this issue, I currently have the same setup as you and I am still able to load all of my templates / styles with the relative path.
Thanks 👍

This sounds like something related to tsconfig.json and a baseUrl being set somewhere. If you provide a repo we can have a look!

Hi @RicardoVaranda @filipesilva
I quickly made a repo of my project (and stripped it a bit) https://github.com/El4a/cli1.0.0-example
It has 2 components:
app.component.ts has the full path and it working
insz.component.ts has a relative path and is not working (and thus the browser errors)
It's probably something incredibly stupid though. Thanks in advance!

Hey @El4a ,
I've cloned your repo and managed to get it working with relative paths quite easily simply change your insz.component.ts to:
@Component({
  selector: 'app-main',
  templateUrl: './insz.component.html'
})

Notice the difference in the templateUrl, this is how you should reference it by relative path rather than having to define the absolute which you were doing previously.
Likewise change your app.component.ts to:
@Component({
  selector: 'app-root',
  templateUrl: './app.component.html'
})

Hope this helps 👍

Closing as answered by @RicardoVaranda. Relative paths are from the component itself.

See that's what I did first...
but I can't get it to work because it throws this error

How are you hosting/serving the files?
It seems you are getting 404 errors which is quite common if the baseUrl is incorrect.

Everything was correct! Note to self: try re-installing the nodemodules a bit earlier in the debugging process instead of after 5 days...
No idea which lib was the problem but a reinstall fixed it :)


Add Licensing Page | Issue #513

Issue Title
Licensing Page Addition for CryptoTracker Platform
This PR adds a dedicated Licensing Page to outline licensing terms and conditions for CryptoTracker platform users.
fix #513

[x] I have provided the issue title.

Info about the Related Issue
What's the goal of the project?
The goal of this project is to provide transparency regarding the use of software and resources on the CryptoTracker platform, helping users understand their rights and responsibilities in relation to licensing.

[x] I have described the aim of the project.

Name
Please mention your name.
Shariq

[x] I have provided my name.

GitHub ID
Please mention your GitHub ID.
shariq2003

[x] I have provided my GitHub ID.

Identify Yourself
Mention in which program you are contributing (e.g., WoB, GSSOC, SSOC, Hactoberfest).
GSSOC-ext

[x] I have mentioned my participant role.

Closes
Enter the issue number that will be closed through this PR.
Closes: #513

[x] I have provided the issue number.

Describe the Add-ons or Changes You've Made
Give a clear description of what you have added or modified.

Created a Licensing Page to articulate the licensing terms for CryptoTracker users.

Added content on the types of licenses (open-source, commercial, etc.) under which the platform and its resources are provided.

Styled the page similar to the Privacy Policy page for consistency across the platform.

Ensured the page is responsive for mobile users.

[x] I have described my changes.

Type of Change
Select the type of change:

[ ] Bug fix (non-breaking change which fixes an issue)

[x] New feature (non-breaking change which adds functionality)

[ ] Code style update (formatting, local variables)

[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)

[ ] This change requires a documentation update

[x] I have selected the type of change.

How Has This Been Tested?
Describe how your changes have been tested.

The Licensing Page was tested across multiple screen sizes to ensure proper display on desktop and mobile devices.

Verified that all links and sections display correctly.

Cross-checked with Privacy Policy page to ensure consistent styling.

[x] I have described my testing process.

Checklist
Please confirm the following:

[x] My code follows the guidelines of this project.
[x] I have performed a self-review of my own code.
[x] I have commented my code, particularly wherever it was hard to understand.
[x] I have made corresponding changes to the documentation.
[x] My changes generate no new warnings.
[x] I have added things that prove my fix is effective or that my feature works.

@vanshchauhan21 sir review and merge

@vanshchauhan21 sir review and merge

hey my vercel deployement limit exceed that's why  i am anable to merge wait for an hours i will do something

@vanshchauhan21 sir review and merge

hey my vercel deployement limit exceed that's why i am anable to merge wait for an hours i will do something

I can send you the UI

@vanshchauhan21 sir review and merge

hey my vercel deployement limit exceed that's why i am anable to merge wait for an hours i will do something

Hey @vanshchauhan21 someone ruined the app.js and footer.jsx files while merging conflicts that cause the whole app down, in the main branch currently.

I have fixed that in my local, and also going to push along with this PR, if you agree.

@vanshchauhan21 sir

Please.............

@vanshchauhan21 sir

@vanshchauhan21 sir

Wait bro deployment limit khtm hgyi ha vercel ki

@vanshchauhan21 sir

Wait bro deployment limit khtm hgyi ha vercel ki

bro 7pm pr to GSSOC hi khatm hijayeva

@vanshchauhan21 sir

Wait bro deployment limit khtm hgyi ha vercel ki

@vanshchauhan21 bro 7pm pr to GSSOC hi khatm hijayeva and i have provided the working UI demo above, also if you want i can also share my screen via gmeet

Merged bro


Setting for specifying the line ending when sending text via TCP

Type: Feature Request
Setting for specifying the line ending when sending text via TCP
First of all, thanks for the useful extension!
When using TCP as the monitor mode, it would be super useful if there were an option to specify the line ending that is appended to the text when pressing Send as text, similar to the option available in serial monitor mode. The application receiving data via TCP expects a \n newline character as the terminating character when parsing commands.
Cheers

@UCSIG Thanks for the recommendation! I have placed it on the backlog and we will get to it as our soonest availability based on our overall workload.

Was just about to enter the same request, this change would be really useful.


VariantDetective application

Hello, thank you for this package.
I have 3 questions and I hope you can answer them:
- Can we use Variant Detective on reads generated using Oxford Nanopore technology (long reads)?
- Can we use it to detect variants in oomycetes?
- Can we also detect insertions and deletions in addition to SNPs (Substitutions) and SV ?

Hi @emilydolivo97,

Can we use Variant Detective on reads generated using Oxford Nanopore technology (long reads)?

VariantDetective can be used with long reads to predict structural variants at the moment. In order to predict SNPs/INDELs, you will need to either use short reads, or an assembled genome. We are looking to add SNP/INDEL calling using for long reads in a future release.

Can we use it to detect variants in oomycetes?

Although the benchmarking and testing was performed using bacterial genomes only, I believe it could be applied to other species (such as oomycetes). One limitation is that some of the tools within VariantDetective are being called to work on haploid genomes, whereas oomycetes are typically diploid. This could impact the efficiency of the variant calling.

Can we also detect insertions and deletions in addition to SNPs (Substitutions) and SV ?

The snp_indel and all_variants modules (using short reads or full genome) do predict short insertions and deletion, as well as SNPs. The structural_variant module will predict large-scale genomic insertions and deletions,
Hope this helps and thanks for checking out our tool!


Fixed pypy-3.5 issue with BROKEN_PYPY_CTXMGR_EXIT

There's no sys.exc_clear() in pypy3+, but code did not check python version. Just added a new condition to drop checks for python>=3.

Hi,
On new release (1.0.0), the _compat.py was removed and compatibility old Python version too.
Thank you.


Determine whether reboot is required based on installer's exit code instead of assuming it

Details
Currently, we rely on the assumption that certain installers will always require reboot while certain others won't. Specifically, only this prerequisite is currently marked as requiring reboot:
https://github.com/Tyrrrz/DotnetRuntimeBootstrapper/blob/5a1706c401ffe571b6b50d89693eb52e4d3e9ce4/DotnetRuntimeBootstrapper.AppHost/Prerequisites/WindowsUpdate3063858Prerequisite.cs#L8-L21
This is true, however we should expect that it might change in the future. All of the prerequisite installers, including the regular exe installer and wusa (which is used to install Windows Updates) return different exit codes, depending on whether reboot is necessary. I don't know what these codes are right now, though.
What we should do:

Remove IsRebootRequired from IPrerequisite.
Make IPrerequisiteInstaller.Run() return PrerequisiteInstallerResult enum:

This enum will contain two cases: Successful and RequiresReboot.

Adjust ExecutablePrerequisiteInstaller and WindowsUpdatePrerequisiteInstaller to return the correct enum case, depending on the exit code. Assume that all exe installers are the same for now. Also assume that if the process returns an exit code that does not signify that reboot is required, then it means that it was successful (we should do some error checking though, but that's a separate task).

The standard exit/error codes for reboot should be
ERROR_SUCCESS_REBOOT_REQUIRED = 3010
ERROR_SUCCESS_REBOOT_INITIATED = 1641

Apparently there's also ERROR_SUCCESS_RESTART_REQUIRED = 3011 but I've never actually seen that, I just noticed it in my errors enum

The standard exit/error codes for reboot should be
ERROR_SUCCESS_REBOOT_REQUIRED = 3010
ERROR_SUCCESS_REBOOT_INITIATED = 1641

Apparently there's also ERROR_SUCCESS_RESTART_REQUIRED = 3011 but I've never actually seen that, I just noticed it in my errors enum

Thanks! Is that for both Windows update installers and regular installers?

Should cover anything coming out of Microsoft, AFAIK


Clean up temporary files when storeObject process is interrupted

Implement the respective/equivalent change from HashStore-java to HashStore:

Clean up temporary files when storeObject is interrupted

This has been completed via Feature-64: Store Object Cleanup


Weapon Names

Describe the feature you'd like
I think it would be nice to include all the stock GTA weapons by default like vehicles, of course leaving out the laser weapons and such.

Yeah such feature could be added easily! I might have some time for that tomorrow.

Most likely will be added in 1.4.0 (now 1.3.4), Thanks for the suggestion!


Only Executes The First Cell

Hi,
When I try to run the code, it executes first cell only. I am using vim 8 on Ubuntu laptop.

I am not sure I understand correctly, but I think this is normal. The goal is to execute cells one by one. You can use C-b to execute a cell and move to the next one.
Otherwise, in the README there is an explanation on how to bind C-a to execute all cells above the one you're currently in with
noremap <silent> <C-a> :call RunTmuxPythonAllCellsAbove()<CR>

There isn't currently a function to execute all cells (well, you can select the whole file and do C-c), would that be what you want ?

Thanks. It has been resolved by adding empty cell at the end of the file.


[WICKET-6805] Add Cross-Origin Opener Policy and Cross-Origin Embedder Policy support

Hello Wicket devs!
This PR adds Cross-Origin Opener Policy and Cross-Origin Embedder Policy support for Wicket.
COOP is a security mitigation that lets developers isolate their resources against side-channel attacks and information leaks. COEP  prevents a document from loading any non-same-origin resources which don't explicitly grant the document permission to be loaded. COOP and COEP are independent mechanisms and they can be enabled, tested and deployed separately. Using COEP and COOP together allows developers to safely use powerful features such as SharedArrayBuffer, performance.measureMemory(), and the JS Self-Profiling API. Both COOP and COEP require adding headers to the response. COOP and COEP are now supported by all major browsers. See https://web.dev/why-coop-coep/ for reference.
Here's a summary of all the changes:

We have added 2 new request cycle listeners, the CoopRequestCycleListener and CoepRequestCycleListener to handle adding the headers for the respective security mitigations.

The listeners can be configured using the CoopConfiguration and CoepConfiguration classes that use the builder pattern for ease of use by Wicket users.

Using CoopConfiguration Wicket users will be able to specify the policy they want for COOP (same-origin, same-origin-allow-popups or unsafe-none) and add exempted paths to specify the endpoints for which COOP will not be enabled.

Similarly using CoepConfiguration Wicket users will be able to add exempted paths for which COEP will be disabled and specify if they want COEP to be enforcing (header set as Cross-Origin-Embedder-Policy) or reporting (header set as Cross-Origin-Embedder-Policy-Report-Only)

We have added 2 new methods to the WebApplication class to make it convenient for users to enableCoop and enableCoep.

Here are sample uses of enabling these mechnisms, in the init() method of the WebApplication:
//enabling Cross-Origin Opener Policy
enableCoop(new CoopConfiguration.Builder()
			.withMode(CoopMode.SAME_ORIGIN).withExemptions("<exemptions>").build());
//enabling Cross-Origin Embedder Policy
enableCoep(new CoepConfiguration.Builder()
			.withMode(CoepMode.ENFORCING).withExemptions("<exemptions>").build());

Are you sure two separate listeners are the best solution? COEP is a single header only and to quote [https://web.dev/coop-coep/]: "Use a combination of COOP and COEP HTTP headers to opt a web page into a special cross-origin isolated state."
I wonder whether a single listener would be better from the usage perspective.

Hi @svenmeier!
Thanks for your review. :)

Are you sure two separate listeners are the best solution? COEP is a single header only and to quote [https://web.dev/coop-coep/]: "Use a combination of COOP and COEP HTTP headers to opt a web page into a special cross-origin isolated state."
I wonder whether a single listener would be better from the usage perspective.

Here's our reasoning behind having 2 separate listeners:

We chose to have two separate listeners for COOP and COEP because they are independent mechanisms that can be deployed separately. Setting COEP headers ensures that a document can only load resources from the same origin, or resources explicitly marked as loadable from another origin. This means that, when COEP is enabled, all the resources loaded from cross-origin need to support CORS and will be blocked if they don't. COOP on the other hand does not require CORS support. It's sufficient to set the COOP response header to process-isolate your document so potential attackers can't access your global object if they were opening a pop-up (preventing XS-leaks). If the application doesn't depend on cross-origin interactions between top-level windows, there should be no observable effect of enabling COOP, while enabling COEP might require some refactoring on the Wicket user's part if they are using cross-origin resources.

You're right in pointing out that enabling COOP and COEP together is the best practice for cross-origin isolation. We thought we would give Wicket users more flexibility if they wanted to enable them separately for any reason.
Having a single listener for both COOP and COEP would also achieve the same results, if we provide flexible ways to configure the listener. In that case, while we can provide a single configuration, it might be somewhat confusing to have CoepMode and CoopMode especially since the acronyms COEP and COOP are already fairly confusing! Having separate configs also has less risk of introducing non-backward compatible configs on that object.
If you think having a single listener is better from a usability perspective, we can change our implementation to merge COOP and COEP into a single listener and provide two separate config objects and handy constructors for the listener that can receive either CooepConfiguration or CoopConfiguration or both. WDYT?

especially since the acronyms COEP and COOP are already fairly confusing!

I'm glad it is not just me finding those acronyms too cryptic.
I, personally, don't mind to use long name like CrossOriginOpenerPolicyConfiguration. The IDEs help to type it quickly and it is much clearer to (re-)read the code.

Hi @martin-g , @svenmeier !

How about this idea:
add the CoopConfiguration and CoepConfiguration as fields in SecuritySettings.
add third mode DISABLED to the existing ones (ENFORCING and REPORTING)
in Application#initApplication() add some logic to auto-add the Coop/Coep listener(s) when they are enabled
This way the developer will have to configure the security settings and don't bother how they are applied.

We made the changes suggested by @martin-g in the comment above. Now the config objects live in SecuritySettings and users can use the setter methods to configure COOP and COEP. I've also renamed the configs to have longer names to avoid any confusion between the acronyms! If the configs are not DISABLED the listeners are added automatically in Application#initApplication(). Users can use the following lines in the init() method to enable COOP or COEP.
getSecuritySettings().setCrossOriginOpenerPolicyConfiguration(CoopMode.SAME_ORIGIN, "exemptions");
getSecuritySettings().setCrossOriginEmbedderPolicyConfiguration(CoepMode.ENFORCING, "exemptions");

Thanks for the review @martin-g ! I've renamed the request cycle listeners :) Is there anything else we can do to get this merged?

IMHO the additions to Application would be better located in WebApplication#internalInit().
CSP is enforced there too.

AFAICT the internalInit() method is called before init(), since we expect the users to configure their policies for COOP and COEP in the init() method, and we will add the listeners with the configs if they are not DISABLED, if we move the secuirtyInit() to WebApplication#internalInit() the configuration decisions made by the user in their WebApplication#init() will not have an effect on listener behavior.

The listeners should always query the configuration anyway - what if the app changes the configuration later on?

The listeners should always query the configuration anyway - what if the app changes the configuration later on?

By our design right now, changes made to the configuration after the init() method will not have an effect on the listener. We didn't think users would want to change their policies at runtime. Also since securityInit() is called once during initialization, if a listener is not added in the secuirtyInit() (configuration was DISABLED in init()) and later on changes the configuration (enable at runtime) the listener would not be added.
Are there use cases for changing the policies at runtime?

It's a matter of consistency, please see how CSPRequestCycleListener does it.
We have to take care of naming too: securityInit() is not where 'an application's security is initialized'.

It's a matter of consistency, please see how CSPRequestCycleListener does it.
We have to take care of naming too: securityInit() is not where 'an application's security is initialized'.

Hi @svenmeier!
We have updated the name of the method now, thanks for the suggestion! We were just wondering if you could elaborate a bit on what the use case is for changing security configurations at runtime. Do you have any cases where a developer would like to change the set of scripts that are allowed to run or the set of endpoints intended to be used cross-origin at runtime?
While I agree that consistency is important, I also think it makes sense to programmatically add listeners that depend on user config. IMHO, the current approach has two downsides:

Listeners get added to the stack regardless of user config, adding latency to the processing of each request even if they don't act on the request in any way (in CSP for instance, the mustProtect method is called on every request even if ContentSecurityPolicySettings is empty).

Security configurations are not immutable. This is often the source of vulnerabilities because an attacker can usually force a code path that disables/corrupts security mitigations. Typical examples of this are reflecting origins in CORS headers at runtime, bypassing CSP when it's built at runtime with user input or creating arbitrary redirects on hosts based on user input.

Perhaps Wicket has some good reasons why CSP works the way it does currently! If that isn't the case, do you think this could be a good opportunity to improve performance/security? I think having a config-dependent init that runs after the user has a chance to configure their app would achieve this!
We could keep consistency by moving the adding of the CSP listener to this proposed new init too, so that the listener is never added if no CSP has been configured. This would set a nice trend for future listeners.
These are principles we've used in other contributions (see Struts' implementation of COOP, CSP and Fetch Metadata) and would really like to know if Wicket has use cases where these principles don't apply, so we'd definitely appreciate some feedback!

Listeners get added to the stack regardless of user config, adding latency to the processing of each request even if they don't act on the request in any way (in CSP for instance, the mustProtect method is called on every request even if ContentSecurityPolicySettings is empty)

This is a good point! I don't remember it being discussed. And I think it was not considered.
IMO the CSP listener should be reworked to behave like the new Coop/Coep ones.
If an application needs to reconfigure something after the application init phase it can always go through the long path:

iterate over the request cycle listeners
remove any of them
change configuration
(re)add any of them

Thanks Martin! If you all agree, we could rename the current coopCoepInit method to something else (we had securityInit before but configurationDependentInit or some other name you think suits better works for us) and have this PR merged as is, so that the CSP listener can be moved in a follow-up PR.

Please move your code into a new WebApplication#validateInit() - don't forget to call super.validateInit().
I'll do the same for the CSP enforcement.
We can decide later which configurations we want to be frozen after the application was initialized.

Thanks @svenmeier, @martin-g , @salcho ! I've moved the lines that add the Coop/Coep listeners to WebApplication#validateInit() like you suggested.

I've made some minor improvements to the PR.

Thank you all! We'll be submitting a PR updating Wicket documentation soon! We're super excited to have contributed these features :)

Thank you, @eozmen410 & @salcho !


Upgrade to latest polkadot release

blocked on https://github.com/threefoldtech/tfchain/issues/713

Verified from cargo.toml in the substrate-node directory.
polkadot was upgraded to v0.9.42 and as mentioned in #713 the polkadot version is now updated in one place and shared between the other packages.


feat: Add missing properties on some types

Hello.
Some properties are missing from some types, like the type ChatFromGetChat.
Check it out:

try to get chat permissions using events:

bot.on(":new_chat_members:me", async (ctx) => {
  const { permissions } = await ctx.getChat();
  //
});

You got: Property 'permissions' does not exist on type 'ChatFromGetChat'

Hi! The types aren't missing any properties.

Property 'permissions' does not exist on type 'ChatFromGetChat'

^ And this is not just what TypeScript is saying. TypeScript says,

Property 'permissions' does not exist on type 'ChatFromGetChat'.
Property 'permissions' does not exist on type 'PrivateGetChat'.

Where ChatFromGetChat is,
export type ChatFromGetChat =
  | Chat.PrivateGetChat
  | Chat.GroupGetChat
  | Chat.SupergroupGetChat
  | Chat.ChannelGetChat;

So it is because the filter query :new_chat_members:me only filter the update type and not really the chat type. So, when you call ctx.getChat() it returns ChatFromGetChat type, which can be the information about any type of chats: private, group, supergroup or channel chats.
And as you know the property permissions is only for groups and supergroups. So, to access the permissions property, you need to filter the chat type by yourself.
bot.on(":new_chat_members:me", async (ctx) => {
  const chat = await ctx.getChat();
  if (chat.type == "group" || chat.type == "supergroup") {
    console.log(chat.permissions); // No type errors.
  }
});

But generally, since Telegram Bot API documentation says

new_chat_members: New members that were added to the group or supergroup and information about them (the bot itself may be one of these members).

that, the new_chat_member update is only for groups and supergroups, I think it is safe to assert types for the returned value.
// Node
import { Chat } from "grammy/types";
// Deno
import { Chat } from<EMAIL_ADDRESS>
bot.on(":new_chat_members:me", async (ctx) => {
  const { permissions } = await ctx.getChat() as Chat.MultiUserGetChat;
  console.log(permissions); // No type errors.
});

Hope this helps!

This looks solved, so I will close this issue. Feel free to comment or reopen if there are more questions.


Mods not loading, game starts with EAC off but no changes to game

I've done everything as every tutorial has told me, downloaded me2, moved the mods to the mod folder, opened with launchmod eldenring, however no matter what I do I cant get a mod to work that everyone else seems to be using fine? i attached the debug & a screenshot showing 2 mods I was trying to install in the folder.
modengine_2023-09-19.log

Have the same issue but with DS3. Any ideas anybody?


HBASE-28894 NPE on TestPrefetch.testPrefetchWithDelay (#6338)

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Logfile
Comment

+0 :ok:
reexec
0m 50s

Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s

No case conflicting files found.

+0 :ok:
codespell
0m  0s

codespell was not available.

+0 :ok:
detsecrets
0m  0s

detect-secrets was not available.

+1 :green_heart:
@author
0m  0s

The patch does not contain any @author tags.

+1 :green_heart:
hbaseanti
0m  0s

Patch does not have any anti-patterns.

_ branch-2 Compile Tests _

+1 :green_heart:
mvninstall
3m 51s

branch-2 passed

+1 :green_heart:
compile
3m 20s

branch-2 passed

+1 :green_heart:
checkstyle
0m 40s

branch-2 passed

+1 :green_heart:
spotbugs
2m  1s

branch-2 passed

+1 :green_heart:
spotless
0m 57s

branch has no errors when running spotless:check.

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
3m 26s

the patch passed

+1 :green_heart:
compile
3m 24s

the patch passed

+1 :green_heart:
javac
3m 24s

the patch passed

+1 :green_heart:
blanks
0m  1s

The patch has no blanks issues.

+1 :green_heart:
checkstyle
0m 39s

the patch passed

+1 :green_heart:
spotbugs
1m 42s

the patch passed

+1 :green_heart:
hadoopcheck
15m 37s

Patch does not cause any errors with Hadoop 2.10.2 or 3.3.6 3.4.0.

+1 :green_heart:
spotless
0m 45s

patch has no errors when running spotless:check.

_ Other Tests _

+1 :green_heart:
asflicense
0m 12s

The patch does not generate ASF License warnings.

39m 16s

Subsystem
Report/Notes

Docker
ClientAPI=1.47 ServerAPI=1.47 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6353/1/artifact/yetus-general-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/6353

Optional Tests
dupname asflicense javac spotbugs checkstyle codespell detsecrets compile hadoopcheck hbaseanti spotless

uname
Linux 07a2bd994d29 5.4.0-195-generic #215-Ubuntu SMP Fri Aug 2 18:28:05 UTC 2024 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
branch-2 / 182f516bb56487545da5c1285477fe0ba4f13cc7

Default Java
Eclipse Adoptium-11.0.23+9

Max. process+thread count
78 (vs. ulimit of 30000)

modules
C: hbase-server U: hbase-server

Console output
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6353/1/console

versions
git=2.34.1 maven=3.9.8 spotbugs=4.7.3

Powered by
Apache Yetus 0.15.0 https://yetus.apache.org

This message was automatically generated.

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Logfile
Comment

+0 :ok:
reexec
0m 48s

Docker mode activated.

-0 :warning:
yetus
0m  6s

Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --author-ignore-list --blanks-eol-ignore-file --blanks-tabs-ignore-file --quick-hadoopcheck

_ Prechecks _

_ branch-2 Compile Tests _

+1 :green_heart:
mvninstall
3m 34s

branch-2 passed

+1 :green_heart:
compile
1m 12s

branch-2 passed

+1 :green_heart:
javadoc
0m 34s

branch-2 passed

+1 :green_heart:
shadedjars
6m 13s

branch has no errors when building our shaded downstream artifacts.

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
3m  0s

the patch passed

+1 :green_heart:
compile
0m 56s

the patch passed

+1 :green_heart:
javac
0m 56s

the patch passed

+1 :green_heart:
javadoc
0m 27s

the patch passed

+1 :green_heart:
shadedjars
5m 49s

patch has no errors when building our shaded downstream artifacts.

_ Other Tests _

+1 :green_heart:
unit
223m 38s

hbase-server in the patch passed.

251m  4s

Subsystem
Report/Notes

Docker
ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6353/1/artifact/yetus-jdk17-hadoop3-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/6353

Optional Tests
javac javadoc unit compile shadedjars

uname
Linux 19b27873453b 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
branch-2 / 182f516bb56487545da5c1285477fe0ba4f13cc7

Default Java
Eclipse Adoptium-17.0.11+9

Test Results
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6353/1/testReport/

Max. process+thread count
4478 (vs. ulimit of 30000)

modules
C: hbase-server U: hbase-server

Console output
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6353/1/console

versions
git=2.34.1 maven=3.9.8

Powered by
Apache Yetus 0.15.0 https://yetus.apache.org

This message was automatically generated.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Logfile
Comment

+0 :ok:
reexec
1m  8s

Docker mode activated.

-0 :warning:
yetus
0m  4s

Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --author-ignore-list --blanks-eol-ignore-file --blanks-tabs-ignore-file --quick-hadoopcheck

_ Prechecks _

_ branch-2 Compile Tests _

+1 :green_heart:
mvninstall
4m 53s

branch-2 passed

+1 :green_heart:
compile
1m 15s

branch-2 passed

+1 :green_heart:
javadoc
0m 40s

branch-2 passed

+1 :green_heart:
shadedjars
6m 47s

branch has no errors when building our shaded downstream artifacts.

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
4m 34s

the patch passed

+1 :green_heart:
compile
1m 14s

the patch passed

+1 :green_heart:
javac
1m 14s

the patch passed

+1 :green_heart:
javadoc
0m 34s

the patch passed

+1 :green_heart:
shadedjars
6m 52s

patch has no errors when building our shaded downstream artifacts.

_ Other Tests _

-1 :x:
unit
293m 54s
/patch-unit-hbase-server.txt
hbase-server in the patch failed.

327m  5s

Subsystem
Report/Notes

Docker
ClientAPI=1.47 ServerAPI=1.47 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6353/1/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/6353

Optional Tests
javac javadoc unit compile shadedjars

uname
Linux 9c1ee1bbe25f 5.4.0-192-generic #212-Ubuntu SMP Fri Jul 5 09:47:39 UTC 2024 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
branch-2 / 182f516bb56487545da5c1285477fe0ba4f13cc7

Default Java
Eclipse Adoptium-11.0.23+9

Test Results
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6353/1/testReport/

Max. process+thread count
4484 (vs. ulimit of 30000)

modules
C: hbase-server U: hbase-server

Console output
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6353/1/console

versions
git=2.34.1 maven=3.9.8

Powered by
Apache Yetus 0.15.0 https://yetus.apache.org

This message was automatically generated.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Logfile
Comment

+0 :ok:
reexec
0m 52s

Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s

No case conflicting files found.

+0 :ok:
codespell
0m  0s

codespell was not available.

+0 :ok:
detsecrets
0m  0s

detect-secrets was not available.

+1 :green_heart:
@author
0m  0s

The patch does not contain any @author tags.

+1 :green_heart:
hbaseanti
0m  0s

Patch does not have any anti-patterns.

_ branch-2 Compile Tests _

+1 :green_heart:
mvninstall
4m 41s

branch-2 passed

+1 :green_heart:
compile
3m 39s

branch-2 passed

+1 :green_heart:
checkstyle
0m 42s

branch-2 passed

+1 :green_heart:
spotbugs
1m 55s

branch-2 passed

+1 :green_heart:
spotless
0m 54s

branch has no errors when running spotless:check.

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
4m 10s

the patch passed

+1 :green_heart:
compile
3m 16s

the patch passed

+1 :green_heart:
javac
3m 16s

the patch passed

+1 :green_heart:
blanks
0m  0s

The patch has no blanks issues.

+1 :green_heart:
checkstyle
0m 39s

the patch passed

+1 :green_heart:
spotbugs
1m 51s

the patch passed

+1 :green_heart:
hadoopcheck
22m 36s

Patch does not cause any errors with Hadoop 2.10.2 or 3.3.6 3.4.0.

-1 :x:
spotless
1m  2s

patch has 1 errors when running spotless:check, run spotless:apply to fix.

_ Other Tests _

+1 :green_heart:
asflicense
0m 12s

The patch does not generate ASF License warnings.

48m 16s

Subsystem
Report/Notes

Docker
ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6353/2/artifact/yetus-general-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/6353

Optional Tests
dupname asflicense javac spotbugs checkstyle codespell detsecrets compile hadoopcheck hbaseanti spotless

uname
Linux a3b4b9020e62 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
branch-2 / 182f516bb56487545da5c1285477fe0ba4f13cc7

Default Java
Eclipse Adoptium-11.0.23+9

spotless
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6353/2/artifact/yetus-general-check/output/patch-spotless.txt

Max. process+thread count
79 (vs. ulimit of 30000)

modules
C: hbase-server U: hbase-server

Console output
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6353/2/console

versions
git=2.34.1 maven=3.9.8 spotbugs=4.7.3

Powered by
Apache Yetus 0.15.0 https://yetus.apache.org

This message was automatically generated.

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Logfile
Comment

+0 :ok:
reexec
0m 46s

Docker mode activated.

-0 :warning:
yetus
0m  6s

Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --author-ignore-list --blanks-eol-ignore-file --blanks-tabs-ignore-file --quick-hadoopcheck

_ Prechecks _

_ branch-2 Compile Tests _

+1 :green_heart:
mvninstall
3m  4s

branch-2 passed

+1 :green_heart:
compile
0m 59s

branch-2 passed

+1 :green_heart:
javadoc
0m 31s

branch-2 passed

+1 :green_heart:
shadedjars
5m 30s

branch has no errors when building our shaded downstream artifacts.

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
2m 56s

the patch passed

+1 :green_heart:
compile
0m 59s

the patch passed

+1 :green_heart:
javac
0m 59s

the patch passed

+1 :green_heart:
javadoc
0m 30s

the patch passed

+1 :green_heart:
shadedjars
5m 32s

patch has no errors when building our shaded downstream artifacts.

_ Other Tests _

+1 :green_heart:
unit
226m 13s

hbase-server in the patch passed.

251m 23s

Subsystem
Report/Notes

Docker
ClientAPI=1.47 ServerAPI=1.47 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6353/2/artifact/yetus-jdk17-hadoop3-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/6353

Optional Tests
javac javadoc unit compile shadedjars

uname
Linux ff933077df6a 5.4.0-195-generic #215-Ubuntu SMP Fri Aug 2 18:28:05 UTC 2024 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
branch-2 / 182f516bb56487545da5c1285477fe0ba4f13cc7

Default Java
Eclipse Adoptium-17.0.11+9

Test Results
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6353/2/testReport/

Max. process+thread count
4267 (vs. ulimit of 30000)

modules
C: hbase-server U: hbase-server

Console output
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6353/2/console

versions
git=2.34.1 maven=3.9.8

Powered by
Apache Yetus 0.15.0 https://yetus.apache.org

This message was automatically generated.

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Logfile
Comment

+0 :ok:
reexec
1m  7s

Docker mode activated.

-0 :warning:
yetus
0m  5s

Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --author-ignore-list --blanks-eol-ignore-file --blanks-tabs-ignore-file --quick-hadoopcheck

_ Prechecks _

_ branch-2 Compile Tests _

+1 :green_heart:
mvninstall
3m 57s

branch-2 passed

+1 :green_heart:
compile
1m  8s

branch-2 passed

+1 :green_heart:
javadoc
0m 39s

branch-2 passed

+1 :green_heart:
shadedjars
6m 14s

branch has no errors when building our shaded downstream artifacts.

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
3m 32s

the patch passed

+1 :green_heart:
compile
0m 51s

the patch passed

+1 :green_heart:
javac
0m 51s

the patch passed

+1 :green_heart:
javadoc
0m 29s

the patch passed

+1 :green_heart:
shadedjars
6m  4s

patch has no errors when building our shaded downstream artifacts.

_ Other Tests _

+1 :green_heart:
unit
235m 13s

hbase-server in the patch passed.

263m 56s

Subsystem
Report/Notes

Docker
ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6353/2/artifact/yetus-jdk8-hadoop2-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/6353

Optional Tests
javac javadoc unit compile shadedjars

uname
Linux 35f0f1643741 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
branch-2 / 182f516bb56487545da5c1285477fe0ba4f13cc7

Default Java
Temurin-1.8.0_412-b08

Test Results
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6353/2/testReport/

Max. process+thread count
4206 (vs. ulimit of 30000)

modules
C: hbase-server U: hbase-server

Console output
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6353/2/console

versions
git=2.34.1 maven=3.9.8

Powered by
Apache Yetus 0.15.0 https://yetus.apache.org

This message was automatically generated.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Logfile
Comment

+0 :ok:
reexec
0m 44s

Docker mode activated.

-0 :warning:
yetus
0m  6s

Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --author-ignore-list --blanks-eol-ignore-file --blanks-tabs-ignore-file --quick-hadoopcheck

_ Prechecks _

_ branch-2 Compile Tests _

+1 :green_heart:
mvninstall
3m 13s

branch-2 passed

+1 :green_heart:
compile
0m 53s

branch-2 passed

+1 :green_heart:
javadoc
0m 29s

branch-2 passed

+1 :green_heart:
shadedjars
5m 22s

branch has no errors when building our shaded downstream artifacts.

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
2m 58s

the patch passed

+1 :green_heart:
compile
1m  3s

the patch passed

+1 :green_heart:
javac
1m  3s

the patch passed

+1 :green_heart:
javadoc
0m 48s

the patch passed

+1 :green_heart:
shadedjars
7m 41s

patch has no errors when building our shaded downstream artifacts.

_ Other Tests _

-1 :x:
unit
259m 47s
/patch-unit-hbase-server.txt
hbase-server in the patch failed.

287m 34s

Subsystem
Report/Notes

Docker
ClientAPI=1.47 ServerAPI=1.47 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6353/2/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/6353

Optional Tests
javac javadoc unit compile shadedjars

uname
Linux 85d55b9bed20 5.4.0-195-generic #215-Ubuntu SMP Fri Aug 2 18:28:05 UTC 2024 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
branch-2 / 182f516bb56487545da5c1285477fe0ba4f13cc7

Default Java
Eclipse Adoptium-11.0.23+9

Test Results
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6353/2/testReport/

Max. process+thread count
4206 (vs. ulimit of 30000)

modules
C: hbase-server U: hbase-server

Console output
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6353/2/console

versions
git=2.34.1 maven=3.9.8

Powered by
Apache Yetus 0.15.0 https://yetus.apache.org

This message was automatically generated.

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Logfile
Comment

+0 :ok:
reexec
1m 12s

Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s

No case conflicting files found.

+0 :ok:
codespell
0m  1s

codespell was not available.

+0 :ok:
detsecrets
0m  1s

detect-secrets was not available.

+1 :green_heart:
@author
0m  0s

The patch does not contain any @author tags.

+1 :green_heart:
hbaseanti
0m  0s

Patch does not have any anti-patterns.

_ branch-2 Compile Tests _

+1 :green_heart:
mvninstall
4m 55s

branch-2 passed

+1 :green_heart:
compile
3m 28s

branch-2 passed

+1 :green_heart:
checkstyle
0m 43s

branch-2 passed

+1 :green_heart:
spotbugs
1m 53s

branch-2 passed

+1 :green_heart:
spotless
1m  1s

branch has no errors when running spotless:check.

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
4m 33s

the patch passed

+1 :green_heart:
compile
3m 20s

the patch passed

+1 :green_heart:
javac
3m 20s

the patch passed

+1 :green_heart:
blanks
0m  0s

The patch has no blanks issues.

+1 :green_heart:
checkstyle
0m 41s

the patch passed

+1 :green_heart:
spotbugs
1m 57s

the patch passed

+1 :green_heart:
hadoopcheck
23m 53s

Patch does not cause any errors with Hadoop 2.10.2 or 3.3.6 3.4.0.

+1 :green_heart:
spotless
0m 54s

patch has no errors when running spotless:check.

_ Other Tests _

+1 :green_heart:
asflicense
0m 13s

The patch does not generate ASF License warnings.

50m 36s

Subsystem
Report/Notes

Docker
ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6353/3/artifact/yetus-general-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/6353

Optional Tests
dupname asflicense javac spotbugs checkstyle codespell detsecrets compile hadoopcheck hbaseanti spotless

uname
Linux 331cae20d32c 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
branch-2 / 182f516bb56487545da5c1285477fe0ba4f13cc7

Default Java
Eclipse Adoptium-11.0.23+9

Max. process+thread count
76 (vs. ulimit of 30000)

modules
C: hbase-server U: hbase-server

Console output
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6353/3/console

versions
git=2.34.1 maven=3.9.8 spotbugs=4.7.3

Powered by
Apache Yetus 0.15.0 https://yetus.apache.org

This message was automatically generated.

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Logfile
Comment

+0 :ok:
reexec
1m 12s

Docker mode activated.

-0 :warning:
yetus
0m  5s

Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --author-ignore-list --blanks-eol-ignore-file --blanks-tabs-ignore-file --quick-hadoopcheck

_ Prechecks _

_ branch-2 Compile Tests _

+1 :green_heart:
mvninstall
3m 50s

branch-2 passed

+1 :green_heart:
compile
1m  3s

branch-2 passed

+1 :green_heart:
javadoc
0m 34s

branch-2 passed

+1 :green_heart:
shadedjars
6m 15s

branch has no errors when building our shaded downstream artifacts.

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
3m 46s

the patch passed

+1 :green_heart:
compile
0m 59s

the patch passed

+1 :green_heart:
javac
0m 59s

the patch passed

+1 :green_heart:
javadoc
0m 26s

the patch passed

+1 :green_heart:
shadedjars
6m  3s

patch has no errors when building our shaded downstream artifacts.

_ Other Tests _

+1 :green_heart:
unit
216m  5s

hbase-server in the patch passed.

244m 19s

Subsystem
Report/Notes

Docker
ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6353/3/artifact/yetus-jdk8-hadoop2-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/6353

Optional Tests
javac javadoc unit compile shadedjars

uname
Linux 1fe79563e141 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
branch-2 / 182f516bb56487545da5c1285477fe0ba4f13cc7

Default Java
Temurin-1.8.0_412-b08

Test Results
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6353/3/testReport/

Max. process+thread count
4497 (vs. ulimit of 30000)

modules
C: hbase-server U: hbase-server

Console output
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6353/3/console

versions
git=2.34.1 maven=3.9.8

Powered by
Apache Yetus 0.15.0 https://yetus.apache.org

This message was automatically generated.

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Logfile
Comment

+0 :ok:
reexec
1m  0s

Docker mode activated.

-0 :warning:
yetus
0m  6s

Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --author-ignore-list --blanks-eol-ignore-file --blanks-tabs-ignore-file --quick-hadoopcheck

_ Prechecks _

_ branch-2 Compile Tests _

+1 :green_heart:
mvninstall
3m 10s

branch-2 passed

+1 :green_heart:
compile
0m 59s

branch-2 passed

+1 :green_heart:
javadoc
0m 32s

branch-2 passed

+1 :green_heart:
shadedjars
5m 31s

branch has no errors when building our shaded downstream artifacts.

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
3m  0s

the patch passed

+1 :green_heart:
compile
1m  1s

the patch passed

+1 :green_heart:
javac
1m  1s

the patch passed

+1 :green_heart:
javadoc
0m 29s

the patch passed

+1 :green_heart:
shadedjars
5m 30s

patch has no errors when building our shaded downstream artifacts.

_ Other Tests _

+1 :green_heart:
unit
226m 58s

hbase-server in the patch passed.

253m 12s

Subsystem
Report/Notes

Docker
ClientAPI=1.47 ServerAPI=1.47 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6353/3/artifact/yetus-jdk17-hadoop3-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/6353

Optional Tests
javac javadoc unit compile shadedjars

uname
Linux 0eff66b43f6d 5.4.0-195-generic #215-Ubuntu SMP Fri Aug 2 18:28:05 UTC 2024 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
branch-2 / 182f516bb56487545da5c1285477fe0ba4f13cc7

Default Java
Eclipse Adoptium-17.0.11+9

Test Results
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6353/3/testReport/

Max. process+thread count
4216 (vs. ulimit of 30000)

modules
C: hbase-server U: hbase-server

Console output
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6353/3/console

versions
git=2.34.1 maven=3.9.8

Powered by
Apache Yetus 0.15.0 https://yetus.apache.org

This message was automatically generated.

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Logfile
Comment

+0 :ok:
reexec
0m 43s

Docker mode activated.

-0 :warning:
yetus
0m  5s

Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --author-ignore-list --blanks-eol-ignore-file --blanks-tabs-ignore-file --quick-hadoopcheck

_ Prechecks _

_ branch-2 Compile Tests _

+1 :green_heart:
mvninstall
4m 46s

branch-2 passed

+1 :green_heart:
compile
1m 32s

branch-2 passed

+1 :green_heart:
javadoc
0m 47s

branch-2 passed

+1 :green_heart:
shadedjars
7m  6s

branch has no errors when building our shaded downstream artifacts.

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
3m 44s

the patch passed

+1 :green_heart:
compile
1m 10s

the patch passed

+1 :green_heart:
javac
1m 10s

the patch passed

+1 :green_heart:
javadoc
0m 35s

the patch passed

+1 :green_heart:
shadedjars
6m  4s

patch has no errors when building our shaded downstream artifacts.

_ Other Tests _

+1 :green_heart:
unit
257m 57s

hbase-server in the patch passed.

289m  7s

Subsystem
Report/Notes

Docker
ClientAPI=1.47 ServerAPI=1.47 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6353/3/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/6353

Optional Tests
javac javadoc unit compile shadedjars

uname
Linux 13d11f1ae9f0 5.4.0-195-generic #215-Ubuntu SMP Fri Aug 2 18:28:05 UTC 2024 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
branch-2 / 182f516bb56487545da5c1285477fe0ba4f13cc7

Default Java
Eclipse Adoptium-11.0.23+9

Test Results
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6353/3/testReport/

Max. process+thread count
4315 (vs. ulimit of 30000)

modules
C: hbase-server U: hbase-server

Console output
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6353/3/console

versions
git=2.34.1 maven=3.9.8

Powered by
Apache Yetus 0.15.0 https://yetus.apache.org

This message was automatically generated.


Internal storage

I think that it would be beneficial to use Torch's tensors as internal storage instead of tables. This would allow us to:

a more efficient storage (the tables flexibility probably costs)
reduce the risk of conversion issues in the to_tensor()
separate float/double from integers which would be beneficial in the output functions.

The API changes would probably mostly affect get_column() where as_tensor should default to true. This isn't something that I plan to pursue at the moment but I figure that I'd add this as this could be worth-while considering.

It is a good idea.
Do you mean we would have string and integers in a table and double and float in a (or multiple) tensor ? Or you suggest to use CharStorage to store our string in tensors ?

I was thinking using intor long for integers and float/double for floats (see types) while keeping strings in tables. I haven't looked at CharStorage but it could be an interesting option.

We will see CharStorage for an further enhancement. Right now your suggestion is great ;)

One important thing that I changed was the _infer_schema. You previously checked a proportion of the rows for row type. This is problematic with small datasets such as our test datasets and also checking 1000 rows should be rather cheap so I changed the code to:
function Dataframe:_infer_schema(max_rows)
	rows_to_explore = math.min(max_rows or 1e3, self.n_rows)

With the integer functionality we should probably change 'number' to 'integer' and 'float'. The concept is that the column schema goes from integer --> float --> string

Just got a hint that may solve the string storage issue: https://github.com/torch/tds

Looks great ! Furthermore it would allow more complex string operations in the future :)

Feature implemented and will be merged into develop once the doc script is updated & a working update to 1.6 is added. Until then it's in the feature branch internat_storage.

A few issues seem to remain:

Non-luajit fails in Travis
get_mode fails with categorical columns


Add windows to the CI matrix

What was changed
Adding CI integration for Windows

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

The SDK is undergoing a rewrite/refresh and this PR applied to a previous version and is no longer applicable


Update Swift 2.2 snapshot URL

Apple has posted a new snapshot that includes some nice fixes, especially for the Swift Package Manager.
Separately from this, we should consider how we want to manage the versioning of the Swift dependency during this period when there are frequent updates. This updated snapshot will still be considered version 2.2 by the compile script, so an existing app's build cache won't notice the update.

Thanks. I was lazy when I built the buildpack and skipped make a CI pipeline. I'll try to set one up.
I'll also cut a release of this later today.

Excellent!


Can I show Ad in content

Hello
I want to show native ad in content. But here i could not find the option. Can you please guide me that how can I place ad in content or anywhere I want.
Thanks

AFAIK, NativeAd is not impossible for Cordova app, or you may prove me wrong.


How many iteraions are needed to merge two models?

I have merged two dreambooth models (A.ckpt and B.ckpt). The default parameters (alpha and ITERATION) are used. The size of the merged file (merged. ckpt) is the same as A and B, and does not increase.

Size of the models aren't meant to increase. It will stay the same size as the larger of the two models being merged


Docker image

Implements:

Dockerfile for building Hapistrano

TODO:

[ ] Figure out a way to tag the image built properly with the version.
[ ] Figure out a way to upload the image to the official Docker registry

Acceptance criteria:

The image is public and can be used in CI for deploying applications.

@seuros The Debian footprint is 22MB. The hap binary adds another 50MB or so.

In my system I have:
alpine       latest              3fd9065eaf02       3 months ago       4.14MB
debian       stretch-slim        dd99abd0503e       5 weeks ago        55.3MB
debian       9                   da653cee0545       4 months ago       100MB

@javcasas Is there something else preventing you from merging this?

@juanpaucar I want to test the last bit in order to show the version, but other than that, I'll merge it ASAP. It is a safe-ish change, as it will generate a docker image with the latest tag, and only when we tag further versions we will get tagged images.

1 jcasas@mac-2017-29:~/projects/hapistrano$ docker run --rm e127e27d106b --version
Hapistrano: <IP_ADDRESS>
branch: docker-image
revision: d59379ac4c4414e56a839caf6243105d86a183e9

Awesome!


Add/transifex

Thank you for submitting a pull request!
Description
fix #83
Added integration with transifex for i18n of documentation.
For this PR, I created a project in transifex for charites documentation as following URL.
https://www.transifex.com/unvt/charites-docs
secret key TX_TOKEN needs to be registered from settings of charites repository.
how to build in local environment
cd docs
pipenv install
pipenv shell
# please create your transifex token
tx init
make transifex_pull
make html

html files for English and Japanese languages will be generated under build/html folder.
Type of Pull Request

[ ] Adding a feature
[ ] Fixing a bug
[x] Maintaining documents
[ ] Others ()

Verify the followings

[x] Code is up-to-date with the main branch
[x] No build errors after npm run build
[x] No lint errors after npm run lint
[x] No errors on using charites help globally
[x] Make sure all the exsiting features working well

Refer to CONTRIBUTING.MD for more details.

@hfu @ubukawa I have completed to translate documentation to Japanese language in transifex now.
https://www.transifex.com/unvt/charites-docs/
The below screenshot is from my local environment. Once I have permission to edit secrets on this repository, I will setup Github action to automate integration with Transifex.


Open an accompanying issue (to the automated PR)

Is there an existing issue for this?

[X] I have searched the existing issues

Feature description
It's great that dependabot automatically opens a PR, but it'd be great if it can also have an issue, and link them with 'Fixes #xxxx' or so.

This is mostly a duplicate of:

https://github.com/dependabot/dependabot-core/issues/2242

I realize the requested behavior here includes opening the PR, but there's enough overlap I'm going to close as a duplicate to keep the product feedback limited to one thread. Do you mind taking a gander at that issue and if it's not capturing your use case leaving a comment on it explaining what you're trying to solve for and why you want both PR and issue, not just one or the other?


Catalog annotation

This PR looks for annotations defined on the catalog object in the json schema document. It should be merged alongside the corresponding PR in chaise.
This PR has changes to resolve #1704 in chaise.

@RFSH  this is also ready for review again after updating the documentation. I tried to make it a little more clear, but it still reads somewhat the same. If you think it's still confusing, I can ask Hongsuda for her suggestion.

@jrchudy Thanks for adding more information. It's more clear now. But I think it's a good idea to ask @hongsudt to take a look at it too.


Searching for an IP-Address in the main search field causes server error

Environment

Python version: 3.8.5
Nautobot version: 1.0.0b3

Steps to Reproduce

Enter in the main search field on top something which looks like an IP
This calls an URL like https://nautobot.local/search/?q=<IP_ADDRESS>

Expected Behavior
A search result is displayed

Observed Behavior
The complete exception is provided below:

<class 'TypeError'>

cannot convert 'NoneType' object to bytes

Python version: 3.8.5
Nautobot version: 1.0.0b3

I have this same issue when searching for IP addresses. Other objects seem ok.

This is fixed in #301.
Can you please try installing beta4 from the develop branch and confirm that this fixes it for you? We have a handful of other IP-related fixes as well.

Can confirm that it works in b4.

Thanks @sirtux


Question about deployed model container?

hi, i want to ask something about how clipper managing docker container :

i already deployed a model with 3 replicas container(A,B,C), how i control it to predict an input into a specified replicas out of the 3(for example container A)
will clipper have error handling or error logs feature when container crashed or predict error in the future ?

@YupaTapuY :

You cannot control this case manually. Why do you need this scenario?
If you would like to handle some errors in detail, I recommend you have to implement your custom model container. (link)

thank you for answering

then how load balancing work for the three replicas when it had multiple predict requests or how the container manager route the predict request into which container replicas?

because i need a blue green deployment scenario, and i want to implement it manually if i can control it

ohh ok then, i'll implement it with custom container

Thank you very much for the response

Clipper has a model queue and working threads related each replica. First of all, TaskExecutor will add your multiple predict requests (aka. tasks) to the related model queue. (code) And then, if a working thread is idle, it will try to process the requests retrieved from the model queue. If many working threads are idle, the sequence will be determined by a condition variable.

Thanks, now i know how it processed
Actually i need to know if i can customize the process because i want to make the model versioning system that shifting the task little by little to the new version of the model, not shifting entirely to the new version model
but thanks for answering, really appreciated

@YupaTapuY :
Does it means rolling update? I think that Clipper supports 'blue-green' deployment policy basically. But, to imitate rolling update, you can register Clipper apps 'v1', 'v2' and setup a gateway server in front of Clipper_qf to control traffic between 'v1' and 'v2' manually .

@YupaTapuY :
Yes, you can.

may i know what stored in redis db ?
thanks anyway

ok thanks, it work, now i can see what stored in the redis db
but i have another problems, after i check all the redis db i got an error when i use clipper.conn start clipper()
'18-11-05:23:12:12 INFO     [docker_container_manager.py:119] Starting managed Redis instance in Docker
Traceback (most recent call last):
File "", line 1, in
File "/usr/lib/python2.7/site-packages/clipper_admin/clipper_admin.py", line 114, in start_clipper
cache_size, num_frontend_replicas)
File "/usr/lib/python2.7/site-packages/clipper_admin/docker/docker_container_manager.py", line 127, in start_clipper
**self.extra_container_kwargs)
File "/usr/lib/python2.7/site-packages/docker/models/containers.py", line 772, in run
container.start()
File "/usr/lib/python2.7/site-packages/docker/models/containers.py", line 374, in start
return self.client.api.start(self.id, **kwargs)
File "/usr/lib/python2.7/site-packages/docker/utils/decorators.py", line 19, in wrapped
return f(self, resource_id, *args, **kwargs)
File "/usr/lib/python2.7/site-packages/docker/api/container.py", line 1066, in start
self._raise_for_status(res)
File "/usr/lib/python2.7/site-packages/docker/api/client.py", line 231, in _raise_for_status
raise create_api_error_from_http_exception(e)
File "/usr/lib/python2.7/site-packages/docker/errors.py", line 31, in create_api_error_from_http_exception
raise cls(e, response=response, explanation=explanation)
docker.errors.APIError: 500 Server Error: Internal Server Error ("driver failed programming external connectivity on endpoint redis-25906 (435e60595d5a98a282d4663eb897e9cdbeefad813e689393156914a2f6d782b4):  (iptables failed: iptables --wait -t filter -A DOCKER ! -i br-99943f5f6493 -o br-99943f5f6493 -p tcp -d <IP_ADDRESS> --dport 6379 -j ACCEPT: iptables: No chain/target/match by that name.
(exit status 1))")`
is it because my mistake when i checking redis db ?

@YupaTapuY :
hmm. Strange problem. Please restart Docker on your local.

thanks, it's worked now, i just restart docker service and it worked

one more question, do clipper store information of how many times a deployed model's predict function gets called or something like that ?
thanks before


Investigate root cause of "Maximum number of subsequent equal requests to the Maps API reached (3)" error

We're seeing a lot of these errors in track.js. Let's take a look and fix the root cause of this.
cc: @saleiva @xavijam @rochoa

Example of one of these errors, related with tooltips: https://my.trackjs.com/details/fc1aa7b446c842a4816e24f987a86e10

We're seeing a lot of errors in track.js with the following message:
["Maximum number of subsequent equal requests to the Maps API reached (3):", {
  "layers": [{
    "id": "c1109752-380f-45d7-a902-0d614dc8619f",
    "type": "cartodb",
    "options": {
      "cartocss": "#layer {\n  polygon-fill: ramp([_2014_score], (#eff3ff, #c6dbef, #9ecae1, #6baed6, #4292c6, #2171b5, #084594), quantiles);\n  line-width: 1;\n  line-color: #050101;\n  line-opacity: 1;\n}",
      "cartocss_version": "2.1.1",
      "interactivity": ["cartodb_id", "country", "_2014_rank", "_2014_score", "fatalities"],
      "source": {
        "id": "a0"
      },
      "attributes": {
        "id": "cartodb_id",
        "columns": ["country", "_2014_rank", "_2014_score", "fatalities"]
      }
    }
  }],
  "dataviews": {},
  "analyses": [{
    "id": "a0",
    "type": "source",
    "params": {
      "query": "SELECT * FROM ashley_data_mapping_terror"
    }
  }]
}, {
  "stat_tag": "26ef9ca8-a774-11e6-86a7-0e3ff518bd15",
  "api_key": "49d8b0717300fd0180338ae382dfcb1f3ae72a55"
}]

Error is being triggered by CartoDB.js here.
About this limitation
In https://github.com/CartoDB/cartodb.js/pull/1296 we introduced some changes to limit the number of subsequent "equal" requests to the Maps API. A request to the re-instantiat a map using the Maps API can only be performed if no more than 3 requests with the same payload, params and options, and the same response happened before. When a "new" request is performed, the "request counter" is reset.
The original motivation for this feature, was to prevent infinite loops between cartodb.js and the maps API (eg: when an analysis becomes ready and the map is re-intantiated again, but node is "ready" in the new response -> https://github.com/CartoDB/cartodb.js/issues/1283).
Error sampling
These are the most common causes of the error:
Tooltip fields are reset:
Sample error
Code were map is being reloaded
Infowindow fields are reset
Sample error
Code were map is being reloaded
New dataview is added
Sample error
Code were map is being reloaded
I'll open issues for each individual error.

Hi guys, should this fixed? Is happening again in production

I have the same issue, any updates please. Thank you

I have the same issue, any updates please. Thank you

I have this issue on mr React app, I finally fix by preventing the component update only when cartoCss changes
  shouldComponentUpdate(nextProps) {     return nextProps.cartocss !== this.props.cartocss      || nextProps.visible !== this.props.visible      || nextProps.sql !== this.props.sql;   }


Bug: The button for generating a new password on the registration page was displayed incorrectly and highlighted with borders when clicked

Fixed by 9bcaf68 commit

Fixed by 9bcaf68 commit


Disaggregate by region

I'm not sure whether the data to do that are publicly available, but it would be great if you could add the option to disaggregate by region and generate different graphs/datasets for each region separately.

Most popular request, but data not available. Sorry.


Better error message for wrong import implementation

This changes improve the error message when a component is importing/exporting something that the linker is either missing or has the wrong type.
Previously the error message for a missing function implementation would be:
Error: import `my-import` has the wrong type

Caused by:
    expected func found nothing

Now, this error will be:
Error: component imports `my-import`, but a correct implementation of `my-import` could not be found

Caused by:
    function implementation is missing

I went back and forth on whether the error message should reference the linker. For direct users of Linker this would surely help, but this error message also gets displayed to indirect users of Linker so talking at a higher level of abstraction seemed appropriate.

@peterhuene I believe I've addressed your feedback. I agree that "implementation" isn't always the right word, but I think we'll need to let this sit for a while before the right word makes itself apparent.


Add event emitter / handler functionality

We'd like to allow components to be able to emit events, as well as register callbacks against any event in the system (including from other components or possibly system events from the context itself).
Similar to callbacks, we also want to support separate event handler and immediate event handler queues.
(some of this code was originally included in https://github.com/CDCgov/ixa/pull/4)

Closed by https://github.com/CDCgov/ixa/pull/32


Explore indentation issues with the indentation test tool

This issue has been created to track indentation issues that have been found through the usage of the indentation test tool. The indentation test tool applies the reindent lines operation on consecutive pairs of lines on well indented/formatted code, and finds the cases when the suggested indentation differs from the existing indentation. This tool can be run on large repos in order to quickly find cases when the indentation is incorrect.

The indentation test tool is introduced in the following PR. It takes in a directory as input, runs over all the TS files (for example), applies the reindentation and writes back the files. Since the files are already properly indented/formatted, edits proposed the reindentation operation correspond presumably to incorrect indentation edits.
This comment will be used to record the findings from running the tool on different repos.
Repo: VS Code

After some analysis it appears that the reindent lines command does not respect certain onEnter rules. Consider the following case, the reindent lines command returns the code inside of the if statement on the same level as the if statement itself, but on pressing Enter after the curly open brace, we get the correct indentation:

More specifically in relation to the comment above, a new tool will be developed, the indentation onEnter test tool which will test that the onEnter rules work correctly independently of the general indentation.

This issue was opened for the purpose of exploration. I will close this issue.

哈哈


How to train shape_predictor to obtain shape_predictor_68_face_landmarks.dat

Hello,
I'm try to understand how to create a custom model of shape predictor for face landmark extraction with dlib.
I've tried different training (changing train parameters) with images of 300-W challenge (helen, afw, lfpw, ibug, with a total of 3837 different images). I used these because i found face boxes inside the page of the competitions: http://ibug.doc.ic.ac.uk/resources/300-W/
http://ibug.doc.ic.ac.uk/media/uploads/competitions/bounding_boxes.zip
But with model created the landmarks extraction is always bad and the original file shape_predictor_68_face_landmarks.dat, provided with Dlib, is always much better.
In order to understand why the difference is so big, I ask you how you have obtained shape_predictor_68_face_landmarks.dat
Then my questions is:

What are the images used for training?
How you have extracted the face box?
What train's parameters do you have used? What defined inside http://dlib.net/train_shape_predictor_ex.cpp.html?

Thank'you very much.
Rudy

I used the training data here: http://dlib.net/files/data/ibug_300W_large_face_landmark_dataset.tar.gz.  It's just 300-W, but with mirrored images added in.
I don't remember the training parameters, but they were essentially the default values.
You have to be consistent in your placement of the boxes between training and testing. As long as you are consistent it doesn't matter how you do it.

Thanks for your replay!
 I tried with it but in some images the face cannot be found, in that case are you discarded that image for training?

In that case I just put the box in the right place with some other method.

What do you mean as "other method"? Manually?
How do you preserve consistency for box extraction?

I made up some program that quasi-manually fixed it with some heuristic and my manual review.  I don't think it matters.  Just be careful about your labeling.

Hello! davisking, this doubt is a bit off-topic considering this issue. I am using dlib python modules. I am particularly interested in separately detecting right and left eyebrows and eyes, nose, mouth or lips and jaw lines(referencing the image attached). My question is, is there a way to do so within the frame work of dlib (c++ or python) as the python dlib module in general provides 68 facial points. Or do i need to train my own detectors for each cases?
Regards.

I don't know what to say.  That's literally what the land marking model you mentioned does.

If you are looking for an alternate way to use the Dlib face landmark detector which extracts and aligns the detected face chips, please check out the following git.
https://github.com/scotthong/dlib-align-faces

The main example program for face landmarking,
http://dlib.net/face_landmark_detection_ex.cpp.html, extracts aligned
faces.  So you don't need anything else.

The main purpose of my project is to allow integration of the face landmark detector with none native C++ application such as Java or Python. I've integrated with a Java based face recognition software I am working on.
https://github.com/scotthong/dlib-align-faces
The Dlib python library does not provide the interface to extract the aligned face chips. The align_dlib provided by facenet project is using the OpenCV to align the face chips. However, the result is not as good  as good as Dlib.
https://github.com/davidsandberg/facenet/tree/master/src/align
I've also implemented Dlib face detector using Java JNI. However, the application becomes unstable when running multiple instances of the shape detectors. The size of the image is typically 1920x1080 (1080p). I don't have a good way to measure the amount of memory required to process a given sized image and the Java based server program cannot handle the heavy Java memory usage and crashes when under heavy load. The application is very stable when running only one instance though!
Thanks for sharing with your great Dlib library. Go Bucks!

Ha, cool.  Sounds good.
It definitely shouldn't crash under load like that though.  You have a race condition somewhere in the code.  Make sure you aren't touching any objects from multiple threads at the same time without protection by a mutex or similar synchronization mechanism.

Thanks for the quick response! The same Java-JNI Dlib wrapper can handle 12 concurrent threads as a console mode program under heavy for days without any problem. It only has stability issue only when integrated with a Servlet container. I don't have a chance to find out the root cause yet. Regardless, integrating with an external native executable is much easier with the overhead to reload the shape model each time the program is executed. The time to process a 1080p sized image typically take 3 seconds. Is there a way to improve the performance further?
So far, the MTCNN/Tensorflow based implementation yields the best consistent results. It fails to identify only one image using the original(not pre-aligned)  LFW dataset.
https://github.com/davidsandberg/facenet/tree/master/src/align
https://kpzhang93.github.io/MTCNN_face_detection_alignment/
Do you have a plan to implement a Dlib version of MTCNN? I also tried dnn_mmod_face_detection_ex for face detection and the results (size of bounding box) is not very consistent! Maybe you can use MTCNN to obtain the bounding boxes to train a dnn_mmod_face_detection_ex model in Dlib. Just a thought! Thanks!

Hi @davisking what value of padding has to be used while training the face landmark detection dataset?

Read Kazemi's paper. It's all in there.

Padding is not mentioned in the paper. To what parameter in the paper does padding corresponds to?

I there a trained model for 194 points facial landmarks for python?

No

Hi @davisking I am prtotoyping an Android app to detect  facial landmarks. For that am using dlib-android which is the ported version of dlib for Android. Can I use that in commercial apps? As you have mentioned before the dataset that it uses is the shape_predictor_68_face_landmarks.dat which needs an approval by the UCL. I have sent them a request for that and is that all should i need to get approval for or anything else? I am overall happy with the results that I get with dlib-android with this dataset and would like to use further in a commercial app. I wonder if the UCL doesn't give access to use the dataset what are my alternatives to train a model to use with? Please advice. Thanks

You can use dlib any way you want.
However, in the machine learning field right now there is a generally unclear issue of what kinds of rights owners of content have over machine learning models trained on that content. For example, a whole lot of models are trained on data scraped from the internet and most people and companies just ignore this issue.  Just ignoring it is standard practice right now.  However, UCL wants to claim that any models trained on their dataset, which is images scraped from the internet + annotations they made, are owned by UCL.  I am not a lawyer, I have no idea how enforceable that is. If you want legal advice you need to talk to a lawyer.

Thanks for your replay. I am waiting for UCL's reply still and will talk to a lawyer as you suggest anyway. Cheers!

Hi Davis,
Can I add some extra features in the existing model shape_predictor_68_face_landmarks.dat like for neck ?  if it is, whether i have to follow the same procedure as you did for face?

You can add anything you want, but you have to retrain the model.  Follow the documented procedure.

Thank you for your reply. May I know whether I can convert this model to
.json or not?
On Sat 30 Mar, 2019, 5:04 PM Davis E. King<EMAIL_ADDRESS>wrote:

You can add anything you want, but you have to retrain the model. Follow
the documented procedure.
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/davisking/dlib/issues/359#issuecomment-478237439, or mute
the thread
https://github.com/notifications/unsubscribe-auth/ATTLzXfgK6G0MR3kdCiv7_YtGdJ_LpoKks5vb0uqgaJpZM4LOIS4
.

Hi All,
I'm trying to train a landmark detector using the Helen dataset (with mirroring) for 194 landmarks. Anyway I was better trying to understand what would be considered a 'good' error. I decided to look at the train/test error of the 'shape_predictor_68_face_landmarks.dat' model on the ibug_300W_large_face_landmark_dataset (see code below.) I'm showing a test/train error of around 6. Intuitively I was expecting something much closer to zero. Do these errors make sense to others?
model_dat = 'shape_predictor_68_face_landmarks.dat'
train_xml = 'ibug_300W_large_face_landmark_dataset/labels_ibug_300W_train.xml'
test_xml = 'ibug_300W_large_face_landmark_dataset/labels_ibug_300W_test.xml'
measure_model_error(model_dat, train_xml)
measure_model_error(model_dat, test_xml)
Error of the model: shape_predictor_68_face_landmarks.dat is 6.8888672656038965
Error of the model: shape_predictor_68_face_landmarks.dat is 6.204732789912478

Hi all,
i'm trying to train shape predictor on my custom dataset(selfie images,1300images 513*513)to landmark iris in the face,for the xml annotation:
1)I used 20 parts(x,y) for each image: the points are extracted using deep learning segmentation model
2) I used 1 box for each image(knowing that my data contain one face in each image): the box(top, left, width, height) are detected by using face detection model(haar cascade and Yolo)
so as i prepared the XML file for the training(training options, I used the defaults)
but the result was so bad

Any help??


[BUG] A few issues on Mac.

Hi! I downloaded the Neural amp modeller 2 days ago. The first time I ran it, it appeared to work fine, but it sounded very muddy, noisy and scratchy (regardless of the amp model or IR i loaded into it). I tried it again Today and when I opened the app a prompt popped up requesting to use my Macbook's microphone which I allowed. It then just made a very loud feedback noise which I couldn't get to stop unless I closed the app. Tried again, same result. Tried again but this time did not allow the app to make use of my microphone. The noise was now gone but I had no signal either. I then re-downloaded and installed the app, but the results were the same. I double checked all my settings to see if the error was on my side, but everything seems to be in order. I even tried to open it in both GarageBand and Reaper, but couldn't find it in either DAW. I did notice the app's picture changed and reads "iPlug2" but the app name remains the same. I use a MacBook Air M1.

Be sure to select the right Input Source. On a mac, while having the PlugIn open in standalone mode, press command and "," for opening the settings, and select the right input.
The noise you were hearing could be the macs internal mic (used for video conferencing etc.). If this signal gets into an amp it is for sure only a big noise.

Be sure to select the right Input Source. On a Mac, while having the PlugIn open in standalone mode, press command and "," for opening the settings, and select the right input.
The noise you were hearing could be the macs internal mic (used for video conferencing etc.). If this signal gets into an amp it is for sure only a big noise.

Would be nice to be "muted" when the plugin opens, I guess having a microphone feedback loop bang when you open the plugin isn't good for the speakers...
Also having a button to open the settings instead of only the "command" + "," keyboard shortcut


Better UX/UI

The current GUI is kind of buggy and kinda not user-friendly, especially with custom Windows themes. If you plan on making this a Windows-only project, we can use WinUI3. Otherwise - we might consider Avalonia. I'm fairly familiar with both and this is something that you can assign to me.
I can think of and develop a UI once I am back from holiday.

If you could, please attach the enhancement label to this issue. I've forgot to do that

I am working on a WPF remake of Naticord with an overall better UI. So this is in the making basically.

Alright, I'll wait for once you finish said remake, and leave my honest thoughts. Also, WPF does not support NativeAOT compilation which would make the name lie to the user (I'm assuming you do actually native compile this project, since this is winforms).

Alright, I'll wait for once you finish said remake, and leave my honest thoughts. Also, WPF does not support NativeAOT compilation which would make the name lie to the user (I'm assuming you do actually native compile this project, since this is winforms).

Fair. I mean native as in the client is not a web browser and is native design. But this I understand. I'm slowing shifting away from the native design due to me using AdonisUI in WPF but I might change the name in the future.

Using Avalonia would make the project support Linux, Mac, and Windows all at once. This would be a nice feature as well. You can look at JetBrains Rider, which is an Avalonia project. If we can theme it nicely, it would look very nice on Naticord.

I'll take a look into Avalonia. I just want something that's easy to integrate and works in an instant with near no code changes.

Here's an example of the new UI if you want.

Is it possible for you to add placeholder text to these textboxes? Not everyone might know what they do.

Is it possible for you to add placeholder text to these textboxes? Not everyone might know what they do.

That's way better.

working on a new UI with a friend. looking much better for naticord. gonna think of a new name for naticord tho.

working on a new UI with a friend. looking much better for naticord. gonna think of a new name for naticord tho.

naticord is now going to become lumina. this is figma but we are making this a reality in wpf. login screen is already done.

The UI design in question is quite nice, although I'm afraid the name is already used for a private IDA Pro server.

I will close this issue, but I will continue updating this with comments from me.


actions: Icon pointers and tooltips in Recent conversations.

This PR adds a little polish to the actions icon in the Recent Conversations view.

It adds a tooltip to the @ indicator
It introduces appropriate cursor: a default/arrow cursor for @, and a pointer for the bell icon.

One known remaining rough edge here is that the Tippies on @ and the unread count display with only the default short Zulip delay, whereas the bell icon is presented with the extra-long delay.
CZO Discussion

Screenshots and screen captures:

Before
After

Self-review checklist

[x] Self-reviewed the changes for clarity and maintainability
(variable names, code reuse, readability, etc.).

Communicate decisions, questions, and potential concerns.

[x] Explains differences from previous plans (e.g., issue description).
[x] Highlights technical choices and bugs encountered.
[x] Calls out remaining decisions and concerns.
[x] Automated tests verify logic where appropriate.

Individual commits are ready for review (see commit discipline).

[x] Each commit is a coherent idea.
[x] Commit message(s) explain reasoning and motivation for changes.

Completed manual review and testing of the following:

[x] Visual appearance of the changes.
[x] Responsiveness and internationalization.
[x] Strings and tooltips.
[x] End-to-end functionality of buttons, interactions and flows.
[x] Corner cases, error conditions, and easily imagined bugs.

Merged, thanks @karlstolley!


Fixed #24343 -- Ensure db converters are used for foreign keys.

This may not be the best way of doing this.
@jarshwah - you made some changes to db_converters to use Col objects, I don't know whether it's appropriate to work out when we have a foreign key and set the output field to the correct (i.e. related) type.
I believe it will fix the ticket, it certainly fixes the added failing test.

I spent a bit of time experimenting with modifying the Col() returned from a ForeignKey (see diff below). Many things seem to work, however there are a few problems.
Firstly I needed to modify RelatedPopulator to inspect target instead of output_field. This didn't seem to cause any problems.
I then discovered some more subtle issues which came up from the annotation tests. Basically we select two fields as id without giving one an alias so objects get the wrong primary key. I'm assuming this is to do with how output_field is used through the query generation process (instead of target). Not sure how to track it down... It seems to me this may be a "more correct" approach.
def get_col(self, alias, source=None):
    if source is None:
        source = self.related_field
    return Col(alias, self, source)

Thanks to @shaib for pointing out that the current patch needed to do something more clever with backend converters as they take different parameters to field converters. This resulting code is ugly, but should work.

The new code, indeed, looks like some deeper redesign is warranted.
On the practical level, though, it fails many tests with:
 ...
  File ".../django/db/models/sql/compiler.py", line 789, in results_iter
    row = self.apply_converters(row, converters)
  File ".../django/db/models/sql/compiler.py", line 773, in apply_converters
    value = converter(value, self.connection, self.query.context)
  File ".../django/db/models/fields/related.py", line 2064, in new_converter
    return converter(value, self, context)
  File ".../django/db/backends/oracle/operations.py", line 180, in convert_empty_values
    field = expression.output_field
AttributeError: 'ForeignKey' object has no attribute 'output_field'

Last commit should help with the test failures. An alternative approach would be to special case ForeignKey in SQLCompiler.get_converters but this seems like a bad idea as well.
@akaariai if you have any ideas about a better approach I'd love to hear them.

@mjtamlyn last commit solves most of the failures, but still leaves 4 -- because, on backends where (not has_native_uuid_field) and interprets_empty_strings_as_nulls, the fk test for a null uuid ends up with assertEqual(None, u''). I think this is a bug in the UUIDField converters -- they should convert the empty string to None, shouldn't they?
For reference,
FAIL: test_json_serializer (serializers_regress.tests.SerializerTests)
----------------------------------------------------------------------
Traceback (most recent call last):
  File ".../django/utils/functional.py", line 15, in _curried
    return _curried_func(*(args + moreargs), **dict(kwargs, **morekwargs))
  File ".../tests/serializers_regress/tests.py", line 479, in serializerTest
    func[1](self, pk, klass, datum)
  File ".../tests/serializers_regress/tests.py", line 154, in fk_compare
    testcase.assertEqual(data, instance.data_id)
AssertionError: None != u''

How does the empty string even appear? The only function I could find that may be the culprit (I don't have time to test just yet) is Field.get_default():
    def get_default(self):
        """
        Returns the default value for this field.
        """
        ...
        if (not self.empty_strings_allowed or (self.null and
                   not connection.features.interprets_empty_strings_as_nulls)):
            return None
        return ""

UUID has empty strings allowed = False, but it interprets empty strings as nulls, so it returns "" rather than null. May need to override this function inside UUID field to remove the possibility of the empty string being returned.
A longer view might be to move this default implementation into CharField (and similar text based fields), and skip the empty strings check altogether in Field class.
This is just speculation until I can actually test it though - which I hope to do sometime tonight unless someone beats me to it.

I obviously need to learn how to read conditionals, because the "not empty_strings" would have fallen through to None. Anyway, the UUID isn't the problem in this situation. The failing test is:
(fk_obj, 452, FKDataToField, None)

And the reason it fails is because the ForeignKey points to a CharField on the remote model, and it's nullable:
class FKDataToField(models.Model):
    data = models.ForeignKey(UniqueAnchor, null=True, to_field='data')

class UniqueAnchor(models.Model):
    data = models.CharField(unique=True, max_length=30)

Since the foreign key is now picking behaving like the remote field, it's acting as if it's a CharField. Oracle converts null CharFields to the empty string (I wish it didn't, or I wish other backends did too.. alas).
So I think we need to decide what to do with null foreign keys. I think the correct behaviour is to just return None, but I'm not yet sure where the best place to do that is.

@jarshwah  you got to this just minutes before me... and you're right, of course. I'll try to fix.

See https://github.com/django/django/pull/4158 for a slightly different attempt. I went with "fixing" the source of foreign keys, and went around and fixed the problems that caused. I haven't yet run the full test suite though, so we'll wait to see what happens there.
What do you think of this method? I find it slightly better than building up the list of all needed converters, and I'm not entirely convinced this is bullet proof.