forge fmt formatting with Modifier-style base constructor call without arguments compiler error

Component
Forge
Have you ensured that all of these are up to date?

[X] Foundry
[X] Foundryup

What version of Foundry are you on?
forge 0.2.0 (dffdfde 2023-08-14T00:22:15.788827000Z)
What command(s) is the bug in?
forge fmt
Operating System
macOS (Apple Silicon)
Describe the bug
import {Ownable} from<EMAIL_ADDRESS>import {ERC1155} from "solmate/tokens/ERC1155.sol";

import {IAchievements} from "./interfaces/IAchievements.sol";
import {SoulBound1155} from "./abstracts/SoulBound1155.sol";

contract Achievements is IAchievements, SoulBound1155, Ownable {
    constructor(address owner) Ownable() ERC1155() {}
}

While formatting this piece of code with forge fmt, it removes parentheses for ERC1155 inline derived constructor call. Then, the compiler gives such an error on forge build:
vladikopl@Vladichek-Air core % forge build
[⠊] Compiling...
[⠢] Compiling 1 files with 0.8.20
[⠆] Solc 0.8.20 finished in 18.36ms
Error:
Compiler run failed:
Error (1563): Modifier-style base constructor call without arguments.
  --> contracts/Achievements.sol:17:42:
   |
17 |     constructor(address owner) Ownable() ERC1155 {}
   |                                          ^^^^^^^

May it be caused by SoulBound1155 contract as it is already derived from ERC1155? Anyways, I think formatter should recognise it, and not change ERC1155() to ERC1155

likely somewhere around here @Evalir
https://github.com/foundry-rs/foundry/blob/a0a31c393279e08548920a54c49036a11c180a62/crates/fmt/src/formatter.rs#L1433-L1449

Are there any updates? Maybe this formatting feature could be set in the config somehow?
Also, need to mention that there are some differences between forge fmt formatter and prettier-plugin-solidity
for (uint256 i = 0; i < length;) { // forge
for (uint256 i = 0; i < length; ) { // prettier

// forge
function linkThirdPartyToProfile(address _profileAddress, uint256 _thirdPartyId, uint256 _thirdPartyUserID)
    external
    onlyOperator
{
// prettier
function linkThirdPartyToProfile(
    address _profileAddress,
    uint256 _thirdPartyId,
    uint256 _thirdPartyUserID
) external onlyOperator {

// forge
associatedWallets[_primaryWallet][_associatedWallet] =
    WalletAssociation(true, primaryWallets[_primaryWallet].length);
// prettier
associatedWallets[_primaryWallet][_associatedWallet] = WalletAssociation(
    true,
    primaryWallets[_primaryWallet].length
);

Hey guys, is there any update for this issue? After I use the command forge fmt it also removes parentheses from the constructor


Incorrect Imagenet evals with pytorch_eval_num_workers > 0

AlgoPerf submitter team reports that they are no longer able to reproduce the NAdam baseline results in PyTorch using the current repo in PyTorch on the ImageNet workloads (both ResNet and ViT).
See the plot below in terms of differences in the training/validation loss and accuracy between the given NAdam Jax results and the current run's results on ImageNet ViT.
They did not see a change in  OGBG and FastMRI.
The list of commits that we merged were from 389fe3f823a5016289b55b48aa8061a37b18b401 to 79ccc5e860d7928cf896ffe12ec686c72fd840d4.

Steps to Reproduce
Running submission runner with eval_num_workers=4 (recently changed default to help speed up evals).
Source or Possible Fix
Setting the eval_num_workers to 0 resolves the discrepancy in evals. We are still investigating why.

Changed default number of workers for PyTorch data loaders to 0.
Important: for speech workloads the pytorch_eval_num_workers flag to submission_runner.py has to be set to >0, to prevent data loader crash in jax code.

I tried reproducing the issue by running the target setting run on the current dev branch with pytorch_eval_num_workers=4, but I don't see the drop in eval metrics compared to an older reference run (this one).
If someone can share the exact command and commit they used to produce the run in the plot I will try to run this instead.


Crash on first launch without Internet

Description
Version: 99
The application crashes when first launched without internet connection. It looks like it's something with FCM initialization.
Steps:

Install the application;
disable all network interfaces;
Start the application;

Actual Result: The application crashes after requesting permission to display notifications.

@pcfaktor Do you update the google-services.json file before making a build?

@bstolyarov This is happening with a build from AppCenter


ach service interaction

As part of some of the transfer routes we need to create ACH files in our ach service.
https://api.moov.io/#tag/Files
Steps

[x] Implement ACH service calls to create, validate, and build file
[x] Figure out entire ACH json payload
[x] Store ACH fileId on transfers table

https://github.com/moov-io/paygate/pull/39/commits/2aa28e20a23aa08dafe1fa867a36bb0cb6fdf296 was the last change needed for this.


Updated validations.py python script.

Fixed the behavior of validate_user function in validations.py
Closes: #1
Fixes #<issue_number_goes_here>

It's a good idea to open an issue first for discussion.

[ ] Tests pass
[ ] Appropriate changes to README are included in PR

Hi please take a look in my change


work around for igraph package naming issue.

added a kind of ugly work-around to deal with the issue that there are two packages called igraph.  I am not sure how we want to deal with this in the long run.
@aphearin do you want to see if this solves your problem?

The only problem I see with this is that it seems pretty plausible that the alternate version of igraph will end up having a sub-package called Graph. Upon inspection of both versions of the igraph package, the license for the two is quite different. For the one we don't want, license is just the three-character string "MIT". For the one we do want, the license is quite long, and includes the name of the package author, who is Hungarian. I think using "'Nepusz' in igraph.license" as a trigger would be a more effective way to protect against this.

So I don't know how to turn off Markdown features in GitHub. So the boldface type in that last post should actually be a double-underscore, both leading and trailing.

Don't worry about fiddling with this anymore. I'm going to merge this and make the change myself later.


Refactor + improve tests for Contributions class

Refactoring:

[ ] Combine #pretty_start_date and #pretty_end_date into #pretty_date(date)
[ ] Make the #pretty_date method private.
[ ] Move #default_branch to between #compare_url and #summary, so relevant methods are grouped together.
[ ] Make #changes more robust. (do after writing tests)

Methods that need tests on the Contributions class:

[ ] #commits (implicitly tests #commit, since it includes #commit's output)
[ ] #changes
[ ] #changed_files
[ ] #additions_count
[ ] #deletions_count
[ ] #compare_url
[ ] #pretty_date
[ ] #summary

Re making #changes more robust:
Change
https://github.com/how-is/how_is/blob/cf10219d64bf85f550255a01bf9e2c2a4986e7e8/lib/how_is/contributions.rb#L90-L92
to something like
@stats.keys.each do |key|
  @stats[key] += commit.stats[key]
end

so it doesn't break if GitHub returns more stats in the future.

Can some of the checkboxes now be ticked?

just went through and updated it. looks like most of the refactoring is done, but it still needs tests. thanks for pointing that out!


A more concise project tagline

The current sub-heading in the README, "UI accessibility infrastructure across platforms and programming languages", is a bit verbose. The tagline written by the contractor who did the current AccessKit.dev site, "A True Universal Access Solution", is too vague and untargeted for my taste. So I propose: "Accessibility for your UI toolkit." I think this tagline makes it clear that this project is primarily for toolkit developers, not application developers, while still conveying our ambition to be universal within that space.

Although a bit long, I like what we currently have. What you propose is also fine, I'm on-board if you want to update it.
What is written on the website definitely need to be changed that's for sure.

You'll have to update the repository description as well, why not take this as an opportunity to add appropriate topics while at it?


Belgium: parcels

Hi,
I have a few questions on providing (Belgian) parcel data:

Is this a supported feature or still in beta ?
The documentation (https://github.com/openaddresses/openaddresses/blob/master/CONTRIBUTING.md) still mentions Valid layers are addressess. In the near future parcels and buildings will be supported
But there are already a few parcel sources available, so I assume we can just mimic what e.g. Canada is doing ?(https://github.com/openaddresses/openaddresses/blob/master/sources/ca/bc/port_moody.json)

I assume the structure/source does not have to follow the structure of the addresses (ie.: the Belgian addresses are provided by the 3 Regions, but the parcel are published by the federal level as 1 single nation-wide source)

Is there a size limit per source ? The compressed download is a 2.5 GB zip with Shapefiles (8 GB uncompressed)

Is this a supported feature or still in beta ?

@ingalls has built support for parcels so you can add them now. Documentation still needs to be updated, feel free to put forward a PR for the docs if you'd like to help.

(ie.: the Belgian addresses are provided by the 3 Regions, but the parcel are published by the federal level as 1 single nation-wide source)

You can have a separate countrywide.json file just containing the parcels, it doesn't need to be in the same json file for each region which contains the addresses.

Is there a size limit per source ? The compressed download is a 2.5 GB zip with Shapefiles (8 GB uncompressed)

You can try. I uploaded a 1GB zip for au/qld parcels.

drafting updated docs at #5542

Thanks, I'll give it a try early next week.

Looks like the shapefile containing the Belgian parcels also contains other layers (e.g. administrative borders), so I'll have to ask them to make a separate set containing just the parcel data...
https://eservices.minfin.fgov.be/myminfin-web/pages/cadastral-plans

The system can download the whole thing and pick just the parcels. It'll take less time if they are broken up, but it should be possible.

Ah that would be great... but if I read the documentation correctly, the layer property is currenly only supported for GDB, not for shapefile ?

You can accomplish the same thing by specifying file when processing Shapefiles.

Makes sense, thanks.
And contrary to what I first thought, the zipped file contains a separate shapes for each region, so it could somewhat follow the same structure as the addresses...


robot-name: benchmark fails by getting an expected "repeted name" error

In the exercise robot-name, when I run the main tests, the benchmark fails by getting an expected repeted name error.
In the func BenchmarkName(b *testing.B) I added a fmt.Println(b.N) and get
1
100
10000
1000000

Which shows that it is testing beyond the value of maxNames = 26 * 26 * 10 * 10 * 10 = 676000

I think this is the expected behaviour. Note that this is mentioned in README

There is a comment in the test code to say that the benchmark won't be meaningful if your code passes the bonus test. But I don't think students can now read the tests, can they? Which is a bit weird in itself, but if they can't, we'll definitely need to transfer a mention of this to the instructions.

I suppose it was never quite clear to me what the goal of the benchmark test was. The other tests are obvious, but this one is much less so (particularly since it does not appear to be the case that we really control the value of N). I would actually be in favor of getting rid of this test entirely in preference to allowing the bonus test to be preferred for testing that specific behavior (exhausting the naming space with distinct names).

I suppose it was never quite clear to me what the goal of the benchmark test was.

Well, I agree with you, since I counsel all my students to write slower Go programs and stop worrying about benchmarks. The best performance optimization for any Go program is to rewrite it in C++.
However, it's always useful to know how to benchmark your program if you want to, and it's certainly fun, so it might be worth keeping it in.

One dumb solution to this is for us to make the benchmark check if we have hit the max value and then we can just keep calling it without any expectations about the output. That being said, we may change the behavior of the bonus test by making it just a normal requirement (see #1526).
Current code:
// Benchmark combined time to create robot and name.
for i := 0; i < b.N; i++ {
    New().getName(b, false)
}

Proposed:
const maxNames = 26 * 26 * 10 * 10 * 10

// Benchmark combined time to create robot and name.
for i := 0; i < b.N; i++ {
    if i < maxNames {
        New().getName(b, false)
    } else {
        New().Name()
    }
}

The benchmark tool itself supports setting the number of iterations directly:
go test -bench=. -benchtime=676000x


error when using astro-i18next Trans component

I get errors when I am in development mode. If I import a utility component, in this case the Trans component, I immediately crash the server. I get the following error in the console:
C:/Users/rxtsel/Desktop/qantto/node_modules/.pnpm/astro-i18next@1.0.0-beta.21_astro@3.1.3/node_modules/astro-i18next/src/utils.ts:59
    interpolatedString = interpolatedString.replaceAll(
                                            ^

TypeError: Cannot read properties of undefined (reading 'replaceAll')
    at Module.interpolate (C:/Users/rxtsel/Desktop/qantto/node_modules/.pnpm/astro-i18next@1.0.0-beta.21_astro@3.1.3/node_modules/astro-i18next/src/utils.ts:59:45)
    at default (C:/Users/rxtsel/Desktop/qantto/node_modules/.pnpm/astro-i18next@1.0.0-beta.21_astro@3.1.3/node_modules/astro-i18next/src/components/Trans.astro:20:253)
    at Object.render (C:/Users/rxtsel/Desktop/qantto/node_modules/.pnpm/astro@3.1.3/node_modules/astro/dist/runtime/server/render/slot.js:29:92)
    at Module.renderSlotToString (C:/Users/rxtsel/Desktop/qantto/node_modules/.pnpm/astro@3.1.3/node_modules/astro/dist/runtime/server/render/slot.js:51:24)
    at renderFragmentComponent (C:/Users/rxtsel/Desktop/qantto/node_modules/.pnpm/astro@3.1.3/node_modules/astro/dist/runtime/server/render/component.js:311:49)
    at Module.renderComponent (C:/Users/rxtsel/Desktop/qantto/node_modules/.pnpm/astro@3.1.3/node_modules/astro/dist/runtime/server/render/component.js:343:18)
    at eval (C:/Users/rxtsel/Desktop/qantto/node_modules/.pnpm/astro-i18next@1.0.0-beta.21_astro@3.1.3/node_modules/astro-i18next/src/components/Trans.astro:20:63)
    at async AstroComponentInstance.render (C:/Users/rxtsel/Desktop/qantto/node_modules/.pnpm/astro@3.1.3/node_modules/astro/dist/runtime/server/render/astro/instance.js:37:7)
    at async Object.render (C:/Users/rxtsel/Desktop/qantto/node_modules/.pnpm/astro@3.1.3/node_modules/astro/dist/runtime/server/render/component.js:334:7)
    at async Module.renderChild (C:/Users/rxtsel/Desktop/qantto/node_modules/.pnpm/astro@3.1.3/node_modules/astro/dist/runtime/server/render/any.js:36:5)

Node.js v20.7.0
 ELIFECYCLE  Command failed with exit code 1.

To Reproduce
Steps to reproduce the behavior:

pnpm run dev

Screenshots

astro-i18next version: [1.0.0-beta.21]
astro version: [3.1.3]
OS:  Windows 11
Browser: [Brave]

Code here:
https://github.com/abouthernan/qantto/blob/01118012171309043c95951074f573b32d9a5066/src/components/Hero.astro#L65C10-L65C16

This only happens in development mode. The local server is shut down when running pnpm run dev. But when uploading to prod it works perfectly

This also happens to LanguageSelector and HeadHrefLang components.

This also happens to LanguageSelector and HeadHrefLang components.

That's right, it happens with utility components

This also happens to LanguageSelector and HeadHrefLang components.

That's right, it happens with utility components

Just try an older version. Downgrading worked.

Are there any solutions to this problem? I'm facing it and am looking for a fix

@V-Mokhun Downgrade the version of the i18n lib.

@timwehrle to which one exactly? I now have:
"astro-i18next": "^1.0.0-beta.21",
"react-i18next": "^13.5.0",

@V-Mokhun I used "astro-i18next": "^1.0.0-beta.21" in my astro app. I don't know maybe there are some other conflicts with react-i18next? I only used astro-i18next and the "i18next": "^22.5.1".

@timwehrle Thanks, after the whole day I fixed it somehow ;)
For anyone else wondering, I downgraded react-i18next to 12.0.0 and i18next to 22.5.1


SQL datetime type not being handled correctly by output binding

Datetime2 is ok, but datetime appears to not be handled correctly by the T-SQL dynamically generated based on SQL column types.
Example error:
Microsoft.Azure.WebJobs.Host.FunctionInvocationException: Exception while executing function: GetProducts ---> System.InvalidOperationException: Error while handling parameter output after function returned: ---> Microsoft.Data.SqlClient.SqlException (0x80131904): Column, parameter, or variable #8: Cannot specify a column width on data type datetime. Parameter or variable 'datetime' has an invalid data type.
Example constraint:
ALTER TABLE [SalesLT].[Address] ADD  CONSTRAINT [DF_Address_ModifiedDate]  DEFAULT (getdate()) FOR [ModifiedDate]

The issue lives in https://github.com/Azure/azure-functions-sql-extension/blob/main/src/SqlBinding/SqlAsyncCollector.cs#L268 but we need to understand why calling datetime(3) isn't working while datetime2(3) is happy as a clam. Need to read some docs for the right fix.


Request: expose CardCornerRadius + Elevation

Would it be possible to be able to change the cardcornerradius aswell as the card elevation?

Added on v1.1.0.
You can override any of these values


cranelift: Implement scalar fma on x86

👋  Hey,
This PR Implements fma for scalar values.
x86 does not have dedicated instructions for scalar fma, so we lower to a libcall which matches llvm's behaviour.
I tried to implement it for SIMD as well but got a bit lost, ill try again later.
We can't enable fma.clif runtests until we merge #4453.

I keep trying to review this but finding too many things I don't understand about Cranelift yet. So I'll ask some questions instead. I think there are three main things happening in this PR:

You've moved make_libcall_sig from isa::x64::lower to ir::libcall and renamed it to Libcall::signature. This seems related to a nearby comment in the existing code: "TODO avoid recreating signatures for every single Libcall function." But in doing so you lose access to the ir::Inst that the libcall came from, so you have to list the input and output types for every libcall in the signature method.

 I think this is because libcall_3_ret_1 needs it to call emit_vm_call but only has access to the x64 IsleContext, so you have to thread the triple through to lower_common in order to stash it there.

You're exposing x64's emit_vm_call to ISLE via a new libcall_3_ret_1 helper, and using that to write lowering rules for fma.

Does that cover everything you did in this PR?
I would find this easier to review without change (1), or if you pass the ir::Inst to Libcall::signature so its implementation is identical to make_libcall_sig. But I'm guessing the way you have it now is better because it means this function can be reused by other target backends, right?
I'm curious if the target triple is reachable through one of the other fields that's already in the IsleContext, or if there's a way to get the right libcall calling convention in emit_vm_call without using the triple. I'm guessing no, or you probably would have used it, but it may be worth double-checking. If it's possible to get rid of the tedious changes for (2), that would make this patch a lot more readable.
Step (3) seems like it's simple enough that it can't be wrong, but I haven't read up on the details of ISLE yet.
The other thing I'd like to know is whether anybody is using the fma CLIF instruction. It looks to me like wasmtime does not use it, so I assume it's here for use by one of the other frontends, but it would be nice to verify that.
I think @cfallin or @fitzgen will need to review this but I hope my notes can at least help guide that review.

I keep trying to review this but finding too many things I don't understand about Cranelift yet.

Thanks for reviewing either way!

You've moved make_libcall_sig from isa::x64::lower to ir::libcall and renamed it to Libcall::signature. This seems related to a nearby comment in the existing code: "TODO avoid recreating signatures for every single Libcall function." But in doing so you lose access to the ir::Inst that the libcall came from, so you have to list the input and output types for every libcall in the signature method.

I think that comment still applies, we are still creating a new signature every time we lower fma even if we could cache (or precompute) that, since the signature isn't going to change.
Losing the Inst is a bit more deliberate, the previous code was essentially just copying the Inst signature into a LibCall signature, which doesen't seem very correct to me. I've centralized the signatures in LibCall since they should be pretty much equal across arches, but this may be wrong as well.
I think using Inst can also lead to a situation where we put a libcall in a rule, and use it in a different instruction lowering and then copy the wrong signature. An example would be calling nearest in the div instruction lowering and use the signature from div when emitting the libcall for nearest

I'm curious if the target triple is reachable through one of the other fields that's already in the IsleContext, or if there's a way to get the right libcall calling convention in emit_vm_call without using the triple. I'm guessing no, or you probably would have used it, but it may be worth double-checking. If it's possible to get rid of the tedious changes for (2), that would make this patch a lot more readable.

Yeah, I couldn't find it, but would appreciate a double check on that.

Does that cover everything you did in this PR?

Yeah pretty much.

The other thing I'd like to know is whether anybody is using the fma CLIF instruction. It looks to me like wasmtime does not use it, so I assume it's here for use by one of the other frontends, but it would be nice to verify that.

I don't think so, since it is not implemented right now, but at least rustc_codegen_cranelift side steps the issue by calling the libcall directly both for SIMD and the scalar version of this instruction.
Thanks!

@cfallin Would it be possible to review this? The Fma op isn't that important (we have a better implementation on #4539), but the libcall mechanism is something that we need to lower other i128 ops and this is sort of blocking that.
Changes since @jameysharp 's review:

Renamed libcall_3_ret_1 to libcall_3
Enabled FMA on fuzzer

I don't see an actual libcall implementation here -- I guess it will result in a panic if used today in e.g. the Wasmtime embedding (but that's fine since the cranelift-wasm frontend won't use the opcode)? Or is it already implemented in cranelift-jit?

Sorry, I don't quite understand understand.
We implement a libcall lowering for FMA. We already have libcall's in the x86 backend, but not in isle yet (see ceil lowering without SSE42).
So this is already reachable from wasmtime (from the ceil instruction). cranelift-jit already supports these relocations, so we should also be good there.
And #4453 allows us to test them with runtests.

I guess I meant specifically for fma -- this PR adds two new libcalls, FmaF32 and FmaF64, and I didn't see implementations of them. I was wondering if these implementations were coming later, or in general what the plan for them is? (Or perhaps I've missed them somewhere, but grepping for FmaF32 in the existing tree isn't showing anything.)

We don't implement them, in cranelift-jit we expect them to be provided when linking. We translate the FmaF{32,64} enum to the libcall name (fmaf and fma) in cranelift-module and from there the linker finds those functions for us. We search libc / msvcrt / whatever native runtime by default in cranelift-jit.
I don't know how this works in Wasmtime, if we always need to provide those functions or if we also get them from the system.

OK, that seems fine to me; just want to confirm that I wasn't missing something! It is at least a loud failure if someone tries to use the lowering in their own embedding and finds that the libcall isn't provided/implemented, so this shouldn't be a problem.


Deprecated dependencies

Here is 'npm install' log:
npm WARN deprecated<EMAIL_ADDRESS>this library is no longer supported
npm WARN deprecated<EMAIL_ADDRESS>Debug versions >=3.2.0 <3.2.7 || >=4 <4.3.1 have a low-severity ReDos regression when used in a Node.js environment. It is recommended you upgrade to 3.2.7 or 4.3.1. (https://github.com/visionmedia/debug/issues/797)
npm WARN deprecated<EMAIL_ADDRESS>Debug versions >=3.2.0 <3.2.7 || >=4 <4.3.1 have a low-severity ReDos regression when used in a Node.js environment. It is recommended you upgrade to 3.2.7 or 4.3.1. (https://github.com/visionmedia/debug/issues/797)
npm WARN deprecated<EMAIL_ADDRESS>Fixed a prototype pollution security issue in 4.1.0, please upgrade to ^4.1.1 or ^5.0.1.
npm WARN deprecated<EMAIL_ADDRESS>"Please update to latest v2.3 or v2.2"
npm WARN deprecated<EMAIL_ADDRESS>Legacy versions of mkdirp are no longer supported. Please update to mkdirp 1.x. (Note that the API surface has changed to use Promises in 1.x.)
npm WARN deprecated<EMAIL_ADDRESS>request has been deprecated, see https://github.com/request/request/issues/3142
added 387 packages, and audited 388 packages in 10s
27 packages are looking for funding
run npm fund for details
7 vulnerabilities (5 low, 2 high)

Valid point. If you make a PR, I'll happily review it.

Fixed in #122


Remove unreachable code from sample

@spelluru
Can you review the proposed changes?
When the changes are ready for publication, add a #sign-off comment to signal that the PR is ready for the review team to merge.
#label:"aq-pr-triaged"
@MicrosoftDocs/public-repo-pr-review-team

#sign-off


Power off screen on close

Would it be possible to have a flag to power off the screen when you close the stream, like how you do with Ctrl-P, but it activates when you close the scrcpy window.

Would it be possible to have a flag to power off the screen when you close the stream, like how you do with Ctrl-P, but it activates when you close the scrcpy window.

by power off do you mean powering off the android device ? ... or are you referring to the physical power button action to send the device to sleep ?
assuming you mean the latter ... If you are seeking a button to put the device to sleep then this request is in line with the request posted on this thread ... #715 ... if that's the case ... you could close this issue thread and follow up on your request here #715 :smile:

I think it's different, since I want to automatically turn off the screen/put the device to sleep on close, rather than having to do it manually each time, but thank you!

I think it's different, since I want to automatically turn off the screen/put the device to sleep on close, rather than having to do it manually each time, but thank you!

ok ... so basically you want to power down(close) scrcpy window on the desktop and also send the connected device to sleep ?
If that's the case @rom1v ... how about we have a small splash screen inside the window just before the device displays the android screen of the connected device ... and as per this feature request a small splash screen when when the user decides to disconnect (via a button on the toolbar requested as per #715) ...
The additional benefit of having a few seconds splash screen is that we will have that much more time to display 'scrcpy' branding !!!
What do you think @rom1v ... scrcpy has little to no branding footprint on the net ... all one can see are the github references and images of the device on the desktop ... would be nice to showcase your great work through some simple and elegant branding ... let me know if you are interested ... telegram me ... i am on t.me/deepin ... we can discuss the UI for the splash and #715 idea's.
Cheers.

@rom1v How about always doing this while closing scrcpy?
IMO, this feature very useful and will take a look these days.


running default predict generates type error

@vemonet
out of the box :
$ hatch run predict
Traceback (most recent call last):
  File "/home/micheldumontier/code/predict-drug-disease-emb/src/predict_drug_disease_emb/predict.py", line 69, in <module>
    print(get_predictions(input_id, PredictOptions()))
TypeError: get_predictions() takes 1 positional argument but 2 were given

if i comment out the @trapi_predict annotation, the code runs though. any ideas?
@trapi_predict(path='/predict',
    name="Get predicted targets for a given entity",
    description="Return the predicted targets for a given entity: drug (DrugBank ID) or disease (OMIM ID), with confidence scores.",
    # Define which edges can be predicted by this function in a TRAPI query
    edges=[
        {
            'subject': 'biolink:Drug',
            'predicate': 'biolink:treats',
            'object': 'biolink:Disease',
        },
        {
            'subject': 'biolink:Disease',
            'predicate': 'biolink:treated_by',
            'object': 'biolink:Drug',
        },
    ],
    nodes={
        "biolink:Disease": {
            "id_prefixes": [
                "OMIM"
            ]
        },
        "biolink:Drug": {
            "id_prefixes": [
                "DRUGBANK"
            ]
        }
    }
)
def get_predictions(
        input_id: str, options: Optional[PredictOptions] = None
    ) -> PredictOutput:

 ...

ok, i see from the documentation on this project that the call is:
def get_predictions(request: PredictInput) -> PredictOutput:
instead of the cookiecutter output of
def get_predictions(
        input_id: str, options: Optional[PredictOptions] = None
    ) -> PredictOutput:

The cookiecutter code needs to be modified: https://github.com/MaastrichtU-IDS/cookiecutter-trapi-predict-kit/blob/main/{{cookiecutter.package_name}}/src/{{cookiecutter.module_name}}/predict.py

fixed in 65cb44056fc7e14865483372deba1b52aedf65c6


Updates

@florent-lamiraux The class ProblemTarget allows the user to specify a goal using a constraint. Do we want to add this ?
In my opinion it is a useful feature.

Need https://github.com/humanoid-path-planner/hpp-statistics/pull/4


wbmz5-battery: add battery temperature

Replaced with https://github.com/wirenboard/wb-hwconf-manager/pull/123


postgresql: 15.2, 14.7, 13.10, 12.14, and 11.19

Description of changes
see either https://www.postgresql.org/about/news/postgresql-152-147-1310-1214-and-1119-released-2592/ or each commit
Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
23.05 Release Notes (or backporting 22.11 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module
[ ] (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes

[x] Fits CONTRIBUTING.md.

Sounds fine to staging-next rebuild-wise, especially if merged within a few hours.


Dispose current process after use

The current process should be disposed after use in BusHostInfo

Thanks!

Thanks!


Rename Daemon.Destroy to Daemon.Rm to be consistent with CLI command.

Signed-off-by: Rik Nijessen<EMAIL_ADDRESS>Hi,
@MartijnDwars, @RickWieman, @wrvangeest and I are students from the Delft University of Technology in the Netherlands and are currently working on a project for our Software Architecture course (http://avandeursen.com/2013/12/30/teaching-software-architecture-with-github/).
During this course we will analyze the architecture an open-source project (in our case Docker, because we think Docker is awesome!). Our findings will be published in a chapter of a collaborative book, which will be published online. Last year's book can be found here http://delftswa2014.github.io/.
We'd love to contribute to Docker, so to get a little bit more familiar with the system we have fixed a simple FIXME.
We have renamed the Daemon.Destroy method to Daemon.Rm to be consistent with the corresponding CLI command.

LGTM
Thanks!

LGTM

Thanks! Looking forward to the book once it's published/available

We'll let you know!


Connect to alternative schemas

Hi,
I'm running postgres, and have all my geospatial data in a schema "published" rather than using public.
I'm struggling to connect to that schema - tipg is only connecting to public.
In the Dockerfile I've tried
ENV POSTGRES_DBNAME=oraetl?options=-c%20search_path=published
and
ENV TIPG_DB_SCHEMAS=["published"]
Neither have worked. Any suggestions?

🤔
I have a PgSTAC database that I start with docker compose (https://github.com/developmentseed/eoAPI/blob/master/docker-compose.yml#L129-L143) and then pass pgstac for the schemas and it work well 🤷
DATABASE_URL=postgresql://username:password@<IP_ADDRESS>:5439/postgis TIPG_DB_SCHEMAS='["pgstac"]' TIPG_DB_FUNCTIONS='[]' TIPG_TABLE_CONFIG__pgstac_items__pk=id uvicorn tipg.main:app --port 8000 --reload

Tried:
ENV<EMAIL_ADDRESS>ENV TIPG_DB_SCHEMAS='["published"]'

But weirdly it's still just picking up 3 of the postgis functions:

ok I can reproduce this. It's weird that I had no issues using pgstac schema
# Launch database
docker-compose up database -d

# Create a copy of `public.countries` in `myschema.countries`
psql postgresql://username:password@<IP_ADDRESS>:5439/postgis -c "CREATE SCHEMA IF NOT EXISTS myschema; SET schema 'myschema'; DROP TABLE IF EXISTS myschema.countries CASCADE; CREATE TABLE myschema.countries AS SELECT * FROM public.countries; SELECT count(*) FROM myschema.countries;"

# Start TiPG service
DATABASE_URL=postgresql://username:password@<IP_ADDRESS>:5439/postgis TIPG_DB_SCHEMAS='["myschema"]' TIPG_DB_FUNCTIONS='[]' uvicorn tipg.main:app --port 8000 --reload

curl http://<IP_ADDRESS>:8000/collections | jq
{
  "links": [
    {
      "href": "http://<IP_ADDRESS>:8000/collections",
      "rel": "self",
      "type": "application/json"
    }
  ],
  "numberMatched": 0,
  "numberReturned": 0,
  "collections": []
}

Pleased it's not just me!
Not an immediate fix but what about functionality matching pg_featureserv - where you don't have to specify the schema, the application finds everything which the $user has SELECT permissions for?
Then all the access control is at the DB side.

Don't know if it's helpful or not but we recently added CQL functionality to the PostGres provider in pygeoapi with sqlalchemy & pygeofilter
if there's anything you could reuse -  https://github.com/geopython/pygeoapi/pull/964

@bitner any ideas?

I'm also able to connect to other schema when I add them in
https://github.com/developmentseed/tipg/blob/99c7de7ff538a1a077c7fc02bca30b29be544df4/tipg/db.py#L45
eg
    await conn.execute(
        """
            SELECT set_config(
                'search_path',
                'pg_temp,myschema,public,' || current_setting('search_path', false),
                false
                );
            """
    )

If you did similar to L216 but used has_schema_privilege then wouldn't need to define the schema in the config (think thats what https://github.com/CrunchyData/pg_featureserv/blob/master/internal/data/db_sql.go#L72 is doing)

There are two things going on here.

We need to check what a user has permissions to see. This is all up to the database and cannot be overridden by anything that TiPG does - database privileges always trump. The calls to has_column_privilege, has_table_privilege, has_schema_privilege, and has_function_privilege make sure that we do not expose anything in the catalog  that the user connecting to the database should not be able to use.
We want to have some control to be able to filter over what is exposed by tipg regardless of permissions. Currently this is done partially on the database side to respect whatever is set in the search_path for the user that is connecting. This is where the pg_table_is_visible and pg_function_is_visible are kicking in. The exclude/include settings on TiPG are what kick in as additional filters when creating the catalog.

What this means is that if your schemas and function_schemas are set to NULL, then what shows up will be everything that is in the users search_path.
If the search_path is set to public, but schemas environment var is set to public,myschema only the tables from the public schema would show up. If the search_path for the user was set to public,myschema then tables from both would show up.
Looking through the code, I think that we could do a couple things that could make things a bit clearer.

Currently we default schemas and function_schemas to public. We should instead default those to NULL which would make the users search_path the default.
We should append all schemas listed in schemas/function_schemas environment variables to the search_path at the beginning of the connection.


Webpack instructions

There should be instructions on how to make this work with webpack. The following worked for me:
module: {
    rules: [
      {
        test: /\.js$/,
        loader: 'babel-loader',
        include: path.join(projectRoot, 'node_modules', 'vue-handsontable-official')
      },
      ...
   ]
}

We made quite a big refactor of the wrapper structure, so it would be easier to configure.
Could you check if installing it as @handsontable/vue (or @handsontable-pro/vue for the Pro version) fixes this problem?
For more information on how to install it from version 2.0.0-beta1 onwards, see: https://github.com/handsontable/vue-handsontable-official/wiki/Installation-guide


Issue while connecting to ActiveDirectory server (from windows)

stack:
 ReferralError: 0000202B: RefErr: DSID-031006E0, data 0, 1 access points
 ref 1: 'bridgewater'
 \u0000

 at messageCallback (node_modules\\ldapjs\\lib\\client\\client.js:867:40)
 at Parser.onMessage (node_modules\\ldapjs\\lib\\client\\client.js:199:12)
 at Parser.emit (events.js:95:17)
 at Parser.write (node_modules\\ldapjs\\lib\\messages\\parser.js:105:8)
 at Socket.onData (node_modules\\ldapjs\\lib\\client\\client.js:155:24)
 at Socket.emit (events.js:95:17)
 at Socket.<anonymous> (_stream_readable.js:764:14)
 at Socket.emit (events.js:92:17)
 at emitReadable_ (_stream_readable.js:426:10)
 at emitReadable (_stream_readable.js:422:5)
 at readableAddChunk (_stream_readable.js:165:9)
 at Socket.Readable.push (_stream_readable.js:127:10)
 at TCP.onread (net.js:528:21)

David, don't know if it helps you too, but I got round this by connecting to our Global Catalog instead - port 3268 but otherwise everything is the same - so it doesn't have to refer on sub domains.  Is this a possibility in your setup?

Potentially related to #263

Thanks. I notice that I didn't get into much details while reporting this:

apparently, binding to the LDAP server worked, and this error was triggered while performing a search.
the bridgewater keyword is actually the base DN.
the URL of the LDAP server as ldap://BW-AD-PD1:389
I was subscribed to the error events of my client but this error didn't trigger my listener

@randomsock I will try and discuss this with the customer that experienced this, as this did not happen to me directly. Thank you for the hint!

@pfmooney Any details on the reason behind closing this issue?

Since there had long since been a lull in activity after you mentioned consulting the customer, I assumed the issue had passed.  If you're encountering this condition during a search, I would recommend ensuring that you're subscribing to the error event on the response emitter passed to the search callback.

⚠ This issue has been locked due to age. If you have encountered a recent
problem that seems to be covered by this issue, please open a new issue.
Please include a minimal reproducible example
when opening a new issue.


Error when updating credentials

When trying to update credentials in the config we get a 500 error on submitting the form
The issue appears to be that the edsinfo field contains unescaped quotes and is breaking form submission.

I confirmed this on my own test interface as well.  Looking into a few options to fix and hope to have a PR for it this week or next.

This should have been resolved in PR #84 .  If you update to the current version and still have this issue please let me know and we'll reopen this.


Adding kubernetes image puller operator 0.0.5 to the community operators

Signed-off-by: Ilya Buziuk<EMAIL_ADDRESS>Thanks submitting your Operator. Please check below list before you create your Pull Request.
New Submissions

[ ] Does your operator have nested directory structure?
[ ] Have you selected the Project Community Operator Submissions in your PR on the right-hand menu bar?
[ ] Are you familiar with our contribution guidelines?
[ ] Have you packaged and deployed your Operator for Operator Framework?

[ ] Have you tested your Operator in all supported installation modes?
[ ] Have you considered whether you want use semantic versioning order?
[ ] Is your submission signed?
[ ] Is operator icon set?

Updates to existing Operators

[x] Did you create a ci.yaml file according to the update instructions?
[x] Is your new CSV pointing to the previous version with the replaces property if you chose replaces-mode via the updateGraph property in ci.yaml?
[x] Is your new CSV referenced in the appropriate channel defined in the package.yaml or annotations.yaml ?
[x] Have you tested an update to your Operator when deployed via OLM?
[x] Is your submission signed?

Your submission should not

[x] Modify more than one operator
[x] Modify an Operator you don't own
[x] Rename an operator - please remove and add with a different name instead
[x] Submit operators to both upstream-community-operators and community-operators at once
[x] Modify any files outside the above mentioned folders
[x] Contain more than one commit. Please squash your commits.

Operator Description must contain (in order)

[x] Description about the managed Application and where to find more information
[x] Features and capabilities of your Operator and how to use it
[x] Any manual steps about potential pre-requisites for using your Operator

Operator Metadata should contain

[x] Human readable name and 1-liner description about your Operator
[x] Valid category name1
[x] One of the pre-defined capability levels2
[x] Links to the maintainer, source code and documentation
[x] Example templates for all Custom Resource Definitions intended to be used
[x] A quadratic logo

Remember that you can preview your CSV here.
--
1 If you feel your Operator does not fit any of the pre-defined categories, file an issue against this repo and explain your need
2 For more information see here

/ok-to-test

/ok-to-test

Hi @ibuziuk, please check you container image, it is not possible to pull.
We also need signed commit from the original author, that you can modify his operator. Please ask @tomgeorge.

Hi @ibuziuk, please check you container image, it is not possible to pull.
We also need signed commit from the original author, that you can modify his operator. Please ask @tomgeorge.

@J0zi thanks, I figured out that I had to merge https://github.com/che-incubator/kubernetes-image-puller-operator/pull/42 first :/

We also need signed commit from the original author, that you can modify his operator. Please ask @tomgeorge.

Starting from the next week I will become the primary contact person for the operator, how can we transfer the permissions with  @tomgeorge?

@J0zi thanks, I figured out that I had to merge https://github.com/che-incubator/kubernetes-image-puller-operator/pull/42 first :/

We also need signed commit from the original author, that you can modify his operator. Please ask @tomgeorge.

Starting from the next week I will become the primary contact person for the operator, how can we transfer the permissions with  @tomgeorge?

The image is available on quay - https://quay.io/repository/eclipse/kubernetes-image-puller-operator?tab=tags&tag=0.0.5

The image is available on quay - https://quay.io/repository/eclipse/kubernetes-image-puller-operator?tab=tags&tag=0.0.5

@jozi can you tell me how to transfer authorship of an operator to another person? Do I need to add them as a maintainer in the CSV?

@jozi can you tell me how to transfer authorship of an operator to another person? Do I need to add them as a maintainer in the CSV?

opened #3032 and #3031 to add @ibuziuk to maintainers

opened #3032 and #3031 to add @ibuziuk to maintainers

Closing in favour of #3032 / #3031

Closing in favour of #3032 / #3031


Show events leading to a logged error same way as with crashes

Describe the solution you'd like
When reviewing crashes there is a report that would show the "page" and "session" events leading to the crash. Same functionality should be available when reviewing logged errors.

This is a great idea and something we would love to support in the future. We don't have any immediate plans at the moment but I will post here if there are updates.

We should keep this issue alive.

this issue is still relevant and is not stale. please review and add to your priority list.

This issue is very much needed and is not stale.


OpenXR plugin spams the rslog

Summary:
In Unreal Engine 4.27 (Preview 3), it appears as though the OpenXR plugin is enabled by default. In certain projects the OpenXR plugin causes the rslog to be spammed when starting a RenderStream workload. We should suppress this.
Depending on the installation either of the following will be spammed:
LogHMD: Failed to enumerate extensions. Please check that you have a valid OpenXR runtime installed.
2021-08-04T14:02:15.413+08:00: LogHMD: Optional extension XR_VARJO_quad_views is not available
2021-08-04T14:02:15.413+08:00: LogHMD: Required extension XR_EXT_eye_gaze_interaction is not available
2021-08-04T14:02:15.413+08:00: LogHMD: Could not enable all required OpenXR extensions for OpenXREyeTracker on current system. This plugin will be loaded but ignored, but will be enabled on a target platform that supports the required extension.
2021-08-04T14:02:15.431+08:00: LogHMD: Failed to create an OpenXR instance, result is XR_ERROR_RUNTIME_FAILURE. Please check if you have an OpenXR runtime installed. The following extensions were enabled:
2021-08-04T14:02:15.431+08:00: LogHMD: - XR_KHR_D3D11_enable
2021-08-04T14:02:15.431+08:00: LogHMD: - XR_KHR_D3D12_enable
2021-08-04T14:02:15.432+08:00: LogHMD: - XR_KHR_opengl_enable
2021-08-04T14:02:15.432+08:00: LogHMD: - XR_KHR_vulkan_enable
2021-08-04T14:02:15.432+08:00: LogHMD: - XR_KHR_composition_layer_depth
2021-08-04T14:02:15.432+08:00: LogHMD: - XR_KHR_visibility_mask
2021-08-04T14:02:15.432+08:00: LogHMD: - XR_EXT_hand_tracking

Potentially just an issue with the UE 4.27 preview. Logging for tracking purposes only.
Bug reduction:

Seen in r19.0 (80689) with Unreal plugin r1.27_UE4.27
-- Not seen when OpenXR plugins disabled.
Not seen in r19.0 (80689) with Unreal plugin r1.27_UE4.27
-- Regardless of whether OpenXR plugins are enabled.

Steps to reproduce:
See DSOF-17840

Maybe the OpenXR plugin should not be enabled by default.  I know UE 4.27 added a lot of extra logging to different plugins.

I've mentioned this to Epic, they should fix their logging so we only get this message once, but we can't really do much on our end, OpenXR is enabled by default on the nDisplay sample and we don't want to prevent users from using it.


Opponent Sing on Player Note Hit

Describe your problem here.
I am making a mod, and at some point, I need a way for the opponent to sing when a note is pressed (THIS IS WITH CUSTOM NOTETYPES), is there any possible scripts I could use to do so?
Are you modding a build from source or with Lua?
Lua
What is your build target?
Windows x64
Did you edit anything in this build? If so, mention or summarize your changes.
No response

nvm, figured it out, after a little bit of thinking.

turns out the code is EXTREMELY SIMPLE TO Code, So what's the point of this whole issue?

For those who had a similar problem looking for a way to do this, here's the simple way I found:
function goodNoteHit(id, direction, noteType, isSustainNote) 	if noteType == 'OpponentSing' then 		if direction == 0 then 			objectPlayAnimation('dad', 'singLEFT', true, 24) 		elseif direction == 1 then 			objectPlayAnimation('dad', 'singDOWN', true, 24) 		elseif direction == 2 then 			objectPlayAnimation('dad', 'singUP', true, 24) 		elseif direction == 3 then 			objectPlayAnimation('dad', 'singRIGHT', true, 24) 		end 	end end

when no array

Here's a simplified version
local dir = {'LEFT', 'DOWN', 'UP', 'RIGHT'};
function goodNoteHit(membersIndex, noteData, noteType, isSustainNote)
    if noteType == "OpponentSing" then
        playAnim('dad', 'sing' .. dir[noteData+1], true)
    end
end


unauthorized   during app cration

hello i have created an account in info bip and enabled the 2fa  for my user and i constantly get unauthorized  i have tried and with postman i get unatharized during the app creation
thanks in advance
private static readonly string BASE_URL = "https://lz5kpj.api.infobip.com";
private static readonly string API_KEY = "924cf6c39fceeba5184822f7f3be3fa9-27a5aa73-1f35-462c-a541-92070c8c66da";
    var configuration = new Infobip.Api.Client.Configuration()
            {
                BasePath = BASE_URL,
                ApiKeyPrefix = "APP",
                ApiKey = API_KEY
    };

    var tfaApi = new TfaApi(configuration);
    TfaApplicationConfiguration configuration2 = new TfaApplicationConfiguration()
    {
     AllowMultiplePinVerifications = true,
    PinAttempts = 5,
    PinTimeToLive =  "15m",
    SendPinPerApplicationLimit =  "10000/1d",
    SendPinPerPhoneNumberLimit = "3/1d",
    VerifyPinLimit = "1/3s",

    };
   // Step 1: Create a 2FA application
    var tfaApplicationRequest = new TfaApplicationRequest(configuration: configuration2, name: "2FA Application edi", enabled: true);
    var tfaApplication = tfaApi.CreateTfaApplication(tfaApplicationRequest);

Hi @EduartHajko,
if you're getting UNAUTHORIZED also via postman then it's probably not related to the SDK. Could you please try again with the new API key and paste the error message if it appears again.


No module named 'caffe'

Hi, in colab in  "This will split the video in frames" section, the code don't work:
Traceback (most recent call last):
File "dreamer.py", line 19, in
import caffe
ModuleNotFoundError: No module named 'caffe'

Yes it depends on  caffe. You need to install the caffe frame work first. Installation guide


Missing ansible in makefile

Just realised we are missing an ansible installation in the makefile.

Why do you say that? Ansible is not necessry on the host, only the guest

I say that because I had to install ansible when I ran docker-hive's vagrantfile, so extrapolating from that I assumed it would be a dependency in this case as well, considering you use ansible in the same way. Am I way off track with my understanding here?

You are using the wrong provider, thats all. https://www.vagrantup.com/docs/provisioning/ansible_local is the right one ;)

Aha, from the host and from the guest, I see. Thank you.


Add RoBERTa model for question answering using SQuADv2.0 dataset.

 Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.:x: QingtaoLi1 sign nowYou have signed the CLA already but the status is still pending? Let us recheck it.

@QingtaoLi1 thanks for submitting a PR related to TorchText or Pytorch Deep NLP/Pytorch for HuggingFace.
I wonder if there is need now to start thinking how to organize Torchsharp so NLP tutorials and use cases are more aligned with TorchText.
Just an unrelated question, have you looked into Huggingface GPT2?

Just an unrelated question, have you looked into Huggingface GPT2?

I have not used GPT2 yet. The main difference between the GPTs and BERTs is that the former is a generative model which can output a sequence in an auto-regression format. So I believe many of code are very similar except for generation-related parts.

@QingtaoLi1
This is an attempt to get GPT2 working using BlingFire tokeniser and GPT2 ONNX with the preliminary generation-related parts which are the issue
If you have time and interest, hopefully, get your perspective of the challenges of getting the generation parts working.

RoBERT is for question and answer.
GPT2 is for Text Generation or NLG, which is rare in .NET

@QingtaoLi1 updated the reply

I see. You want to include GPT2 in this repo, right? I currently have other work to do; may seek for some time later.
And I know some are attempting to create infrastructure for general tokenizers. I guess your thoughts of re-organizing TorchSharpExamples to align with torchtext will have similar effect on NLP systems.

The spirit of Torchshap is to empower. NET developers to do deep AI within .NET without the need to go back to python.

I'm not turning back to python; I mean infrastructure in .NET world.

An unrelated question: what do you think are the main obstacles for developers to build a deep AI system?

@QingtaoLi1
https://devblogs.microsoft.com/dotnet/ml-net-june-updates-model-builder/#ml-net-survey-results

@QingtaoLi1 https://github.com/dotnet/machinelearning/issues/5918

Thanks very much!


Agent JAR not found or no Agent-Class attribute

Jenkins and plugins versions report

Environment

Paste the output here

What Operating System are you using (both controller, and any agents involved in the problem)?
Getting below error while running this agent in open jdk 17 in windows machine in Intellij IDEA
"C:\Program Files\Java\jdk-15.0.2\bin\java.exe" -agentlib:jdwp=transport=dt_socket,address=<IP_ADDRESS>:63036,suspend=y,server=n -javaagent:C:\Users\nihir.shah.m2\repository\org\kohsuke\file-leak-detector\1.16-SNAPSHOT\file-leak-detector-1.16-SNAPSHOT.jar -javaagent:C:\Users\nihir.shah\AppData\Local\JetBrains\IdeaIC2021.3\captureAgent\debugger-agent.jar -Dfile.encoding=UTF-8 -classpath "D:\Platform\lib-file-leak-detector\target\classes;C:\Users\nihir.shah.m2\repository\args4j\args4j\2.33\args4j-2.33.jar;C:\Users\nihir.shah.m2\repository\org\ow2\asm\asm\9.5\asm-9.5.jar;C:\Users\nihir.shah.m2\repository\org\ow2\asm\asm-analysis\9.5\asm-analysis-9.5.jar;C:\Users\nihir.shah.m2\repository\org\ow2\asm\asm-commons\9.5\asm-commons-9.5.jar;C:\Users\nihir.shah.m2\repository\org\ow2\asm\asm-tree\9.5\asm-tree-9.5.jar;C:\Users\nihir.shah.m2\repository\org\ow2\asm\asm-util\9.5\asm-util-9.5.jar;C:\Program Files\JetBrains\IntelliJ\lib\idea_rt.jar" org.kohsuke.file_leak_detector.Main 16808
Connected to the target VM, address: '<IP_ADDRESS>:63036', transport: 'socket'
Could not load field socket from SocketImpl: java.lang.NoSuchFieldException: socket
Could not load field serverSocket from SocketImpl: java.lang.NoSuchFieldException: serverSocket
File leak detector installed
Connecting to 16808
Activating file leak detector at D:\Platform\lib-file-leak-detector\target\classes
com.sun.tools.attach.AgentLoadException: Agent JAR not found or no Agent-Class attribute
at jdk.attach/sun.tools.attach.HotSpotVirtualMachine.loadAgent(HotSpotVirtualMachine.java:159)
at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:64)
at java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
at java.base/java.lang.reflect.Method.invoke(Method.java:564)
at org.kohsuke.file_leak_detector.Main.run(Main.java:74)
at org.kohsuke.file_leak_detector.Main.main(Main.java:38)
java -jar file-leak-detector.jar PID [OPTSTR]
PID    : Process ID to activate file leak detector
OPTSTR : Packed option string of the form key1[=value1],key2[=value2],...
Options:
help           - Show the help screen.
noexit         - Don't exit after showing the help screen.
trace          - Log every open/close operation to stderr.
trace=FILE     - Log every open/close operation to the given file.
error=FILE     - If 'too many open files' error is detected, send the dump here.
By default it goes to stderr.
threshold=N    - Instead of waiting until 'too many open files', dump once
we have N descriptors open.
http=PORT      - Run a mini HTTP server that you can access to get stats on demand.
Specify 0 to choose random available port, -1 to disable, which is default.
strong         - Don't let GC auto-close leaking file descriptors.
listener=S     - Specify the fully qualified name of ActivityListener class to activate from beginning.
dumpatshutdown - Dump open file handles at shutdown.
excludes=FILE  - Ignore files opened directly/indirectly in specific methods.
File lists 'some.pkg.ClassName.methodName' patterns.
Disconnected from the target VM, address: '<IP_ADDRESS>:63036', transport: 'socket'
Process finished with exit code 1
Reproduction steps
run in intellij by adding VM parameter as -javaagent:"C:\Users\nihir.shah.m2\repository\org\kohsuke\file-leak-detector\1.16-SNAPSHOT\file-leak-detector-1.16-SNAPSHOT.jar"  and argument as
Expected Results
na
Actual Results
"C:\Program Files\Java\jdk-15.0.2\bin\java.exe" -agentlib:jdwp=transport=dt_socket,address=<IP_ADDRESS>:63036,suspend=y,server=n -javaagent:C:\Users\nihir.shah.m2\repository\org\kohsuke\file-leak-detector\1.16-SNAPSHOT\file-leak-detector-1.16-SNAPSHOT.jar -javaagent:C:\Users\nihir.shah\AppData\Local\JetBrains\IdeaIC2021.3\captureAgent\debugger-agent.jar -Dfile.encoding=UTF-8 -classpath "D:\Platform\lib-file-leak-detector\target\classes;C:\Users\nihir.shah.m2\repository\args4j\args4j\2.33\args4j-2.33.jar;C:\Users\nihir.shah.m2\repository\org\ow2\asm\asm\9.5\asm-9.5.jar;C:\Users\nihir.shah.m2\repository\org\ow2\asm\asm-analysis\9.5\asm-analysis-9.5.jar;C:\Users\nihir.shah.m2\repository\org\ow2\asm\asm-commons\9.5\asm-commons-9.5.jar;C:\Users\nihir.shah.m2\repository\org\ow2\asm\asm-tree\9.5\asm-tree-9.5.jar;C:\Users\nihir.shah.m2\repository\org\ow2\asm\asm-util\9.5\asm-util-9.5.jar;C:\Program Files\JetBrains\IntelliJ\lib\idea_rt.jar" org.kohsuke.file_leak_detector.Main 16808
Connected to the target VM, address: '<IP_ADDRESS>:63036', transport: 'socket'
Could not load field socket from SocketImpl: java.lang.NoSuchFieldException: socket
Could not load field serverSocket from SocketImpl: java.lang.NoSuchFieldException: serverSocket
File leak detector installed
Connecting to 16808
Activating file leak detector at D:\Platform\lib-file-leak-detector\target\classes
com.sun.tools.attach.AgentLoadException: Agent JAR not found or no Agent-Class attribute
at jdk.attach/sun.tools.attach.HotSpotVirtualMachine.loadAgent(HotSpotVirtualMachine.java:159)
at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:64)
at java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
at java.base/java.lang.reflect.Method.invoke(Method.java:564)
at org.kohsuke.file_leak_detector.Main.run(Main.java:74)
at org.kohsuke.file_leak_detector.Main.main(Main.java:38)
java -jar file-leak-detector.jar PID [OPTSTR]
PID    : Process ID to activate file leak detector
OPTSTR : Packed option string of the form key1[=value1],key2[=value2],...
Options:
help           - Show the help screen.
noexit         - Don't exit after showing the help screen.
trace          - Log every open/close operation to stderr.
trace=FILE     - Log every open/close operation to the given file.
error=FILE     - If 'too many open files' error is detected, send the dump here.
By default it goes to stderr.
threshold=N    - Instead of waiting until 'too many open files', dump once
we have N descriptors open.
http=PORT      - Run a mini HTTP server that you can access to get stats on demand.
Specify 0 to choose random available port, -1 to disable, which is default.
strong         - Don't let GC auto-close leaking file descriptors.
listener=S     - Specify the fully qualified name of ActivityListener class to activate from beginning.
dumpatshutdown - Dump open file handles at shutdown.
excludes=FILE  - Ignore files opened directly/indirectly in specific methods.
File lists 'some.pkg.ClassName.methodName' patterns.
Disconnected from the target VM, address: '<IP_ADDRESS>:63036', transport: 'socket'
Process finished with exit code 1
Anything else?
No response

"C:\Program Files\Java\jdk-15.0.2\bin\java.exe"

That looks like JDK 15 rather than JDK 17.  Are you sure that you're running JDK 17?

yes its 17, same error in both, Open jdk 15 and 17

Is this project being actively supported?
openjdk version "11.0.16" 2022-07-19
OpenJDK Runtime Environment Temurin-11.0.16+8 (build 11.0.16+8)
OpenJDK 64-Bit Server VM Temurin-11.0.16+8 (build 11.0.16+8, mixed mode)
C:\Users\runstebo\Downloads>java -jar C:\Users\runstebo\Downloads\file-leak-detector-1.13-jar-with-dependencies.jar 32368
Connecting to 32368
Activating file leak detector at C:\Users\runstebo\Downloads\file-leak-detector-1.13-jar-with-dependencies.jar
com.sun.tools.attach.AgentInitializationException: Agent JAR loaded but agent failed to initialize
at jdk.attach/sun.tools.attach.HotSpotVirtualMachine.loadAgent(HotSpotVirtualMachine.java:165)
at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
at java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
at java.base/java.lang.reflect.Method.invoke(Method.java:566)
at org.kohsuke.file_leak_detector.Main.run(Main.java:73)
at org.kohsuke.file_leak_detector.Main.main(Main.java:37)
java -jar file-leak-detector.jar PID [OPTSTR]

Is this project being actively supported?

The most recent release is from June 2023 and refers to using Java 11 language features where possible.  In that sense, I think that it is actively supported, at least as the library is being used in the Jenkins project.
The most recent commit was 3 weeks ago and adds testing on Java 21.  In that sense, I think that it is actively supported, at least as the library is being used in the Jenkins project.
If "actively supported" means something different for you, then you'll need to elaborate further on what you're trying to achieve.


feat: add pgTAP and pg_prove

As discussed in #65

hi @villelahdenvuo - confirming the request and we'll take a look into this

@JalexChen I implemented your changes and added a cleanup step similar to pg_cron.


Vue-toasted not displaying in iphone and ipad devices.Does it suppports

I am finding problem in iphone and ipad where vue-toasted in displaying.
Any help?

i am sure it should work on iphones and ipads. if you have any issues please reopen with screenshot or a cast.
thanks 🙌


Feature request: add a verbose (or debug mode)

It would be interesting to be able to see the formatter that is running on each file
Of course, it would be only something to ask on demand.
maybe like a -v that inform that block from line X to Y is sent to prettier/shfmt.
with a -vv the information would be more details with the block content before calling the method, then after/ but also the exact path of the formatter used.
it could also be a kind of log level info/warn/error/debug

right now I used strace -ff mdsf file.md to see what happens under the hood

Currently the --debug argument enables stdout/stderr of the formatters.
Adding the  formatter and line info should be pretty straightforward 😃

Currently the --debug argument enables stdout/stderr of the formatters.
Adding the formatter and line info should be pretty straightforward 😃

Oh my bad, I tried a  mdsf --help and didn't see it.
I can see it in mdsf format --help  :facepalm:
Anyway, thanks for adding the linter in the debug

Thanks for implementing it


Don't use booleans as function argument for function with 2+ arguments

Instead, we should use enums with descriptive names:
const GREEDY: &AsciiSet = &LABEL_SET.remove(b'/');

pub enum EncodingStrategy {
  Default,
  Greedy,
}

pub fn fmt_string<T: AsRef<str>>(t: T, strategy: EncodingStrategy) -> String {
    let uri_set = if strategy == Greedy { GREEDY } else { LABEL_SET };
    percent_encoding::utf8_percent_encode(t.as_ref(), uri_set).to_string()
}

let _ = fmt_string("some str", EncodingStrategy::Greedy);
// used to look like
// let _ = fmt_string("some str", true);

Code referenced: https://github.com/awslabs/smithy-rs/blob/a0539e20b069a7de021c84521d8f3c7ba098ad6d/rust-runtime/aws-smithy-http/src/label.rs#L16

I am a fan of replacing bools with enums in function parameters. As part of this breaking change, do we want to make urlencode::BASE_SET: &AsciiSet pub(crate) (I think it's referred to as LABEL_SET in the given code snippet above)? As far as I can see, that's the only item for which we expose AsciiSet from this crate, and if we can avoid exposing it, would that be better?

AsciiSet comes from the percent_encoding crate, so it would be best to not expose it in the public API. That way, if percent_encoding makes breaking changes in a new major version, we will be able to upgrade to that version without making breaking changes.


Laravel/VueJs XSRF/CSRF token rename is not working correctly using the useForm() functionality.

In the current infrastructure of our servers i need to have two different csrf cookies. Serverside everything is working correctly but InertiaJS is not automatically using the BUSINESS-XSRF-TOKEN cookie name as configured in axios. Is this a bug or am I doing something wrong?
Environment:

Laravel 10.x
Inertia version 0.6.8
IneriaVue version 1.0.0 (npm package)

VerifyCsrfToken middleware:
<?php

namespace App\Http\Middleware;

use Illuminate\Contracts\Encryption\DecryptException;
use Illuminate\Cookie\CookieValuePrefix;
use Illuminate\Cookie\Middleware\EncryptCookies;
use Illuminate\Foundation\Http\Middleware\VerifyCsrfToken as Middleware;
use Symfony\Component\HttpFoundation\Cookie;

class VerifyCsrfToken extends Middleware
{
    const TOKEN_NAME = 'BUSINESS-XSRF-TOKEN';

    protected $except = [

    ];

    protected function getTokenFromRequest($request)
    {
        $token = $request->input('_token') ?: $request->header('X-CSRF-TOKEN');

        ray($token, $request->headers);

        if (! $token && $header = $request->header('X-'.self::TOKEN_NAME)) {
            try {
                $token = CookieValuePrefix::remove($this->encrypter->decrypt($header, static::serialized()));
            } catch (DecryptException) {
                $token = '';
            }
        }

        return $token;
    }

    protected function newCookie($request, $config): Cookie
    {
        return new Cookie(
            self::TOKEN_NAME,
            $request->session()->token(),
            $this->availableAt(60 * $config['lifetime']),
            $config['path'],
            $config['domain'],
            $config['secure'],
            false,
            false,
            $config['same_site'] ?? null
        );
    }

    public static function serialized(): bool
    {
        return EncryptCookies::serialized(self::TOKEN_NAME);
    }
}

bootstrap.js
/**
 * We'll load the axios HTTP library which allows us to easily issue requests
 * to our Laravel back-end. This library automatically handles sending the
 * CSRF token as a header based on the value of the "XSRF" token cookie.
 */
import axios from "axios";

// Check the VerifyCsrfToken.php file for the correct token.
const XSRF_NAME = 'BUSINESS-XSRF-TOKEN';

window.axios = axios;

window.axios.defaults.headers.common["X-Requested-With"] = "XMLHttpRequest";
window.axios.default.xsrfCookieName = XSRF_NAME;
window.axios.default.xsrfHeaderName = "X-" + XSRF_NAME;

Hey there, thanks for reporting this issue.
We'll need more info and/or code to debug this further. Can you please create a repository with the command below, commit the code that reproduces the issue as one separate commit on the main/master branch and share the repository here?
Please make sure that you have the latest version of the Laravel installer in order to run this command. Please also make sure you have both Git & the GitHub CLI tool properly set up.
laravel new bug-report --github="--public"

Do not amend and create a separate commit with your custom changes. After you've posted the repository, we'll try to reproduce the issue.
Thanks!

Hey! So I'm not 100% what's up here, but is the issue that you're doing default and not defaults here?
window.axios.defaults.headers.common["X-Requested-With"] = "XMLHttpRequest";
window.axios.default.xsrfCookieName = XSRF_NAME;
window.axios.default.xsrfHeaderName = "X-" + XSRF_NAME;

See here: https://axios-http.com/docs/config_defaults
The other thing to double check is to make sure that that you don't have two different versions of axios installed — which can happen if you have it explicitly installed on your project but are using a different version than what Inertia uses.
But really there isn't anything in the Inertia JavaScript library or in this Laravel adapter that do anything with CSRF tokens, we rely on Laravel and axios' handling of this, so I don't think the problem exists on our end. You can read more about that here:
https://inertiajs.com/csrf-protection
Hope that helps!


add unit-test for getAppArmorSecurityOpts & getSeccompSecurityOpts me…

…thod which locate on cri/v1alpha1/cri_utils.go

Ⅰ. Describe what this PR did
Add unit-test for getAppArmorSecurityOpts & getSeccompSecurityOpts method which locate on cri/v1alpha1/cri_utils.go.
Ⅱ. Does this pull request fix one issue?

fixes #1931
Ⅲ. Describe how you did it
Build unit test by condition combination coverage(ccc).
First, build program structure graph. According to the graph and the principle of ccc, we derive the test cases
Ⅳ. Describe how to verify it
cd cri/v1alpha1/;go test
Ⅴ. Special notes for reviews
no

 Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.莲示 seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.You have signed the CLA already but the status is still pending? Let us recheck it.


Implement workspace/semanticTokens/refresh

We need to notify the client that the workspace has changed each time it does.

VS IDE LSP client support for this is available, but untested, in this PR: https://devdiv.visualstudio.com/DevDiv/_git/VSLanguageServerClient/pullrequest/388715

Remaining work here is to integrate with what @allisonchou does from the Roslyn side and verify some scenarios once it's enabled in VS.

Done!


Cards - All variations - Accessibility fixes

https://taskman.eionet.europa.eu/issues/152256?tab=time_entries

@eea-jenkins build storybook

@eea-jenkins build storybook

@eea-jenkins build storybook

@eea-jenkins build storybook

@tarantilis The carousel seems to be broken.

@eea-jenkins build storybook

@eea-jenkins build storybook

@eea-jenkins build storybook

@eea-jenkins build storybook


Conversation improvements: help and reset

This is an attempt to discuss about the ways to improve the guidance and conversationality of the bot.
Help
As noted before, the bot lacks a basic set of help messages.
For example, when the user says:
how
help
what can you do
???

Expected result:
The bot should display a list of questions that can be asked.
Escaping
At any point in the conversation, the user should be able to cancel the action by saying:
nevermind
nvm
bye
cya
let's start again

Expected result:
The bot should cancel the follow-ups and forget about the current conversation.

Feedbacks and new ideas are welcome!

+1 This amounts to add more training sentences and default intents. This should be added on the 2 DF projects: light and full


Can't delete alarm anymore

Discussed in https://github.com/leikoilja/ha-google-home/discussions/789

Originally posted by Coax88 November  9, 2023
am I the only one experince this, i can't delete and alarm on google speaker anymore, worked fine last week.

Similar issue https://github.com/leikoilja/ha-google-home/issues/786
Both related to refactoring done in https://github.com/leikoilja/ha-google-home/pull/779


Fix es6 scopes challenge

Pre-Submission Checklist

[x] Your pull request targets the staging branch of freeCodeCamp.
[x] Branch starts with either fix/, feature/, or translate/ (e.g. fix/signin-issue)
[x] You have only one commit (if not, squash them into one commit).
[x] All new and existing tests pass the command npm test. Use git commit --amend to amend any fixes.

Type of Change

[x] Small bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds new functionality)
[ ] Breaking change (fix or feature that would change existing functionality)
[ ] Add new translation (feature adding new translations)

Checklist:

[x] Tested changes locally.
[ ] Closes currently open issue (replace XXXX with an issue no): Closes #XXXX

Description

Added a "var" keyword to the challenge "compare scopes of the var and let keywords", which has to be changed to "let" by the user to successfully pass the challenge.
I also took the chance to add a bit of spaces here and there, I'm not sure if I'm a grammar/syntax freak or some people just don't care about looks when writing code.

@Atomk grammar/spacing issues look good. I'm fairly certain the second instance of i doesn't need var because the challenge is showing global vs. local scope so it is defined outside the function. Perhaps I'm mistaken though?

@dhcodes If you declare i just at the top of the function, the other assignment to i will just overwrite its value and at the end the output will always be "block scope". Creating two variables, using var the result is the same, but by changing both to let the local variable in the if will not overwrite the function's one, because it's considered a different variable even if it has the same name. At least this is what seems to happen to me...

@Atomk right, but I think the point of the code at load is to show that the i within the if statement does override the value of the initial declaration. So that if the camper leaves the initial var i and only adds let to the i in the if if statement, the scope changes and the challenge passes.
Also, in my testing adding var to the i declaration in the if statement doesn't change the output result. In other words, I think it's functioning as intended. I could definitely be wrong though so please another set of eyes @freeCodeCamp/moderators

IMO If the challenge's goal is to show the scope of both let and var, then I have to agree with @dhcodes. Adding let to the variable in the IF passes the challenge and exemplifies this scope behavior. Using let as the first declaration works as well but doesn't show the difference in scoping between var and let.

@Atomk any update on this? You'll need to rebase and then remove the changes discussed above. The grammar and spacing issues are a go.

Closing as stale. Please reopen if you plan to make the updated changes.

Sorry for bringing this up again, looking at the challenge I still don't think this is clear. I'll try a different approach.
The initial code is:
function checkScope() {
  var i = "function scope";
  if (true) {
    i = "block scope";
    console.log("Block scope i is: ", i);
  }
  console.log("Function scope i is: ", i);
  return i;
}

The challenge instructions say:

Fix the code so that i declared in the if statement is a separate variable than i declared in the first line of the function.

The fact is the i in the if statement is not a declaration, it is simply an assignment. To make it a declaration, you'd have to add var or let before it. I believe the author of the challenge forgot to declare the second variable, that is what confused me and this is why I made this pull request.

@Atomk @dhcodes I agree with @dhcodes that the original intent of the challenge is to have the user declare the second i as let, and that var was not left off. Rather, it's probably just a misuse of the word "declared". I think we can probably leave the challenge code alone, but maybe fix the instructions instead, being careful about the semantics of the word "declare".
e.g. newly proposed instructions:

Fix the code, using the ES6 let keyword, so that the second i within the if statement is declared as a separate variable that will not overwrite the first i declared in the first line of the function. Be certain not to use the var keyword anywhere in your code.


Proposal to add Licensing Information - e.g. the MIT License

We'd like to propose adding licensing Information to NuGet in form of a license.txt containing the MIT License.
Before merging my PR, please check

the year (2016-2024) and
the author (currently "The DevOps Collective Inc." as specified in the license.txt in other Powershell.org projects)
specified in the copyright statement.

Why MIT?
Looking around, most of the other powershell.org projects on GitHub seem to be under the MIT license.
We find the MIT license to be very easy to use and permissive - it also causes the least problems or incompatibilities when combined with other components and their licenses.

could you please approve the PR?


Styling and Typographical errors

Adhere to Bash style guides in maya buildscripts

Avoid backtick ``  substitution. Use $( ) substitution instead
This permits easier nesting of commands.
qefs - Quote every f***ing substitution
This preserves the inner value of all characters.
Fix major typographical errors.
line 17 of buildscripts/mayactl/build.sh: GIT_CIMMIT -> GIT_COMMIT

I'm taking up this issue.

sure @NerdyPepper go ahead


Add Truffle

This PR adds Truffle to the scaffold-eth project, replacing scripts that were previously using HH. Scripts can be found in packages/truffle/scripts.
Work remains on the react side of this project, as we need to decide how to approximate the single file that contains HH built contracts should be generated by Truffle. However, as it stands all scripts in the package.json should work.

how come this was never merged?


model.fit with dataset generator results in deadlock/hang

TF: 2.5.0
Python: 3.7.10
Model.fit hangs during training. It appears dataset generator seems go into a deadlock while reading tfrecords. A simplified naive model is in the github gist below which reproduces the issue. Directly iterating on the generator seems to work fine but feeding it to model.fit seems to deadlock. Appreciate any color.
https://gist.github.com/talipini/d82d1fa2f5d6b46f3222f2367570543a#file-tf-model-fit-hangs-with-dataset-generator-ipynb

Mutable variable support is now available in the nightly when converting using from_saved_model.
You need to set this flag to True for now.
converter.experimental_enable_resource_variables = True

Anyone have any workarounds or insights on this?

@talipini
We see that the issue template has not been filled, could you please do so as it helps us analyse the issue [tf version, steps followed before you ran into this error or stand alone code to reproduce the issue faced]
Thanks

I have added github gist link which has the reproducible code to the original post but I will add the details here.
System information

Have I written custom code (as opposed to using a stock example script provided in TensorFlow): Yes
OS Platform and Distribution (e.g., Linux Ubuntu 16.04):  Colab jupyter notebok.
Mobile device (e.g. iPhone 8, Pixel 2, Samsung Galaxy) if the issue happens on mobile device: NA
TensorFlow installed from (source or binary): Default version on Colab.
TensorFlow version (use command below): 2.5.0
Python version: 3.7.10
Bazel version (if compiling from source):
GCC/Compiler version (if compiling from source):
CUDA/cuDNN version: No GPU
GPU model and memory: No GPU

Dataset generator hangs when reading tfrecords files. This seems to happen after the first set of tfrecord files have been iterated through and starts reading the next block. This seems to happen consistently when using Colab default setup.
Describe the expected behavior
Not hang.
Standalone code to reproduce the issue
Link to the colab is here - https://colab.research.google.com/gist/talipini/b164e108501f831aff50827ac454d562/tf-model-fit-hangs-with-dataset-generator.ipynb
`
import tensorflow as tf
import numpy as np
import pandas as pd
import glob
import os
from pathlib import Path
used_compression_type = 'GZIP'
from tensorflow.keras.models import Sequential
from tensorflow.keras.layers import Activation, Dense
from tensorflow.keras.optimizers import SGD
#Wrapper
class TFRecordConverter(object):
def init(self):
pass
def int64_feature(self, value):
return tf.train.Feature(int64_list=tf.train.Int64List(value=[value]))
def float_feature(self, value):
    return tf.train.Feature(float_list=tf.train.FloatList(value=value))

def bytes_feature(self, value):
    return tf.train.Feature(bytes_list=tf.train.BytesList(value=[value]))

#Write Sample tfrecords
batch_size = 5
tf_archive = "/tfrecords"
os.makedirs(tf_archive, exist_ok=True)
print(f"TF Records at : {tf_archive}")
def create_test_tfrecords():
existing_tfrecords = glob.glob(os.path.join(tf_archive,""))
if len(existing_tfrecords) < 1:
for i in range(0,5):
x_data = np.random.uniform(low=-1.0, high=5, size= (batch_size5, 6))
write_to_TFRecords(os.path.join(tf_archive,f"tffile-{i}.tfr"),x_data)
def create_TFRecordsFile(file):
Path(os.path.dirname(file)).mkdir(parents=True, exist_ok=True)
compression = tf.io.TFRecordOptions(compression_type = used_compression_type)
writer =  tf.io.TFRecordWriter(file, options=compression)
return writer
def write_to_TFRecords(file, values):
bucket_writer = create_TFRecordsFile(file)
shape = np.array(values.shape, np.int32)
example = tf.train.Example(
features = tf.train.Features(
feature = {
'data':TFRecordConverter().float_feature(values.ravel()), #Float list can only be 1D
'shape':TFRecordConverter().bytes_feature(shape.tobytes())
}
))
print(f"Writing to {file} with size: {shape}")
bucket_writer.write(example.SerializeToString())

def parse_function(serialized_example):
features = {
    'data': tf.io.FixedLenSequenceFeature([], tf.float32,allow_missing=True),
    'shape':tf.io.FixedLenFeature([], tf.string)
    }

features = tf.io.parse_single_example(serialized=serialized_example, features=features)
shape = tf.io.decode_raw(features['shape'], tf.int32 )
dataset = features['data']
dataset = tf.reshape(dataset, shape)

return dataset

#Simple dataset generator
def data_gen(batch_size):
tfrecords = glob.glob(os.path.join(tf_archive,"*"))
print(f"Loading tfrtecords: {tfrecords}")
dataset = tf.data.Dataset.from_tensor_slices(tfrecords)
dataset = dataset.interleave(lambda x: tf.data.Dataset.from_generator(gen_step,
output_types=( tf.float32, tf.float32), args=(x,)))
dataset = dataset.repeat().batch(batch_size)
while True:
    for x, Y in dataset:
        yield x, Y

def gen_step(tf_file):
trRecordDataset = tf.data.TFRecordDataset(tf_file, compression_type=used_compression_type)
trRecordDataset = trRecordDataset.map(parse_function)
print(f"Waiting for dataset in step - {tf_file}")
for dataset in trRecordDataset:
Y = dataset[:,0]
x = dataset[:,1:]
count = 0
while count < dataset.shape[0]:
yield x[count],Y[count]
count += 1
print(f"Finsihed dataset in - {tf_file}")
if name == 'main':
create_test_tfrecords()
#trivial model - hangs in
model = Sequential()
model.add(tf.keras.Input(shape=(batch_size,)))
model.add(Dense(1, activation='linear'))
model.compile(loss='categorical_crossentropy', optimizer=SGD(), metrics = ['accuracy'])
#model.fit will hang just as it starts to read the second set of tfrecords.
model.fit(x = data_gen(batch_size=batch_size),
steps_per_epoch=5,
epochs=10)
print(f"Training Finished.")
`

This could be related to 43768 but not sure.

@talipini
Could you Please refer this, hope it helps.Thanks

Thank you. First one is referring to an issue with strings in the generator, which I am not using. The second one is referring to deadlock on session destructor but that is supposed to be fixed in 2018. I went through both chains but I am kinda lost on it.  But 43768 looks interesting and could be related.

Any additional insights on this? thanks

@rmothukuru
I was able to replicate the issue reported here.Please find the gist.Thanks

Thank you. Appreciate any color on this.

@rmothukuru , @aaudiber - Any updates on this? Appreciate any insights. Thanks

This appears to have been fixed in version 2.7

@talipini,
Sorry for the late response. This issue is fixed now.
#working now
model = Sequential()
model.add(tf.keras.Input(shape=(batch_size,)))
model.add(Dense(1, activation='linear'))
model.compile(loss='categorical_crossentropy', optimizer=SGD(), metrics = ['accuracy'])

model.fit(x = data_gen(batch_size=batch_size),
        steps_per_epoch=5,
        epochs=10)
print(f"Training Finished.")

Output:
Loading tfrtecords: ['/tfrecords/tffile-0.tfr', '/tfrecords/tffile-1.tfr', '/tfrecords/tffile-2.tfr', '/tfrecords/tffile-4.tfr', '/tfrecords/tffile-3.tfr']
WARNING:tensorflow:From /usr/local/lib/python3.7/dist-packages/tensorflow/python/autograph/impl/api.py:458: calling DatasetV2.from_generator (from tensorflow.python.data.ops.dataset_ops) with output_types is deprecated and will be removed in a future version.
Instructions for updating:
Use output_signature instead
Waiting for dataset in step - b'/tfrecords/tffile-0.tfr'
Waiting for dataset in step - b'/tfrecords/tffile-1.tfr'
Epoch 1/10
5/5 [==============================] - 2s 26ms/step - loss: 2.5224e-07 - accuracy: 0.0000e+00
Epoch 2/10
5/5 [==============================] - 0s 28ms/step - loss: 2.1971e-07 - accuracy: 0.0000e+00
Epoch 3/10
Finsihed dataset in - b'/tfrecords/tffile-0.tfr'
Finsihed dataset in - b'/tfrecords/tffile-1.tfr'
Waiting for dataset in step - b'/tfrecords/tffile-2.tfr'
Waiting for dataset in step - b'/tfrecords/tffile-4.tfr'
5/5 [==============================] - 1s 18ms/step - loss: 3.0705e-07 - accuracy: 0.0000e+00
Epoch 4/10
5/5 [==============================] - 0s 20ms/step - loss: 2.3033e-07 - accuracy: 0.0000e+00
Epoch 5/10
Finsihed dataset in - b'/tfrecords/tffile-2.tfr'
Finsihed dataset in - b'/tfrecords/tffile-4.tfr'
Waiting for dataset in step - b'/tfrecords/tffile-3.tfr'
5/5 [==============================] - 1s 26ms/step - loss: 2.2736e-07 - accuracy: 0.0000e+00
Epoch 6/10
Finsihed dataset in - b'/tfrecords/tffile-3.tfr'
Waiting for dataset in step - b'/tfrecords/tffile-0.tfr'
Waiting for dataset in step - b'/tfrecords/tffile-1.tfr'
5/5 [==============================] - 1s 26ms/step - loss: 2.5224e-07 - accuracy: 0.0000e+00
Epoch 7/10
5/5 [==============================] - 0s 17ms/step - loss: 2.1971e-07 - accuracy: 0.0000e+00
Epoch 8/10
Finsihed dataset in - b'/tfrecords/tffile-0.tfr'
Finsihed dataset in - b'/tfrecords/tffile-1.tfr'
Waiting for dataset in step - b'/tfrecords/tffile-2.tfr'
Waiting for dataset in step - b'/tfrecords/tffile-4.tfr'
5/5 [==============================] - 1s 28ms/step - loss: 3.0705e-07 - accuracy: 0.0000e+00
Epoch 9/10
5/5 [==============================] - ETA: 0s - loss: 2.3033e-07 - accuracy: 0.0000e+00Finsihed dataset in - b'/tfrecords/tffile-2.tfr'
5/5 [==============================] - 0s 30ms/step - loss: 2.3033e-07 - accuracy: 0.0000e+00
Finsihed dataset in - b'/tfrecords/tffile-4.tfr'
Epoch 10/10
Waiting for dataset in step - b'/tfrecords/tffile-3.tfr'
5/5 [==============================] - 0s 18ms/step - loss: 2.2736e-07 - accuracy: 0.0000e+00
Finsihed dataset in - b'/tfrecords/tffile-3.tfr'
Waiting for dataset in step - b'/tfrecords/tffile-0.tfr'
Waiting for dataset in step - b'/tfrecords/tffile-1.tfr'
Training Finished.

Please find the gist for reference. Thank you.

same problem


Python and Pylance extension installation failed.

Environment data

VS Code version: 1.59.1
Extension version (available under the Extensions sidebar): Python & Pylance
OS and version:

NAME="Ubuntu"
VERSION="18.04.4 LTS (Bionic Beaver)"
ID=ubuntu
ID_LIKE=debian
PRETTY_NAME="Ubuntu 18.04.4 LTS"
VERSION_ID="18.04"
HOME_URL="https://www.ubuntu.com/"
SUPPORT_URL="https://help.ubuntu.com/"
BUG_REPORT_URL="https://bugs.launchpad.net/ubuntu/"
PRIVACY_POLICY_URL="https://www.ubuntu.com/legal/terms-and-policies/privacy-policy"
VERSION_CODENAME=bionic
UBUNTU_CODENAME=bionic

Python version (& distribution if applicable, e.g. Anaconda): python 3.6.10
Type of virtual environment used (N/A | venv | virtualenv | conda | ...): N/A
Relevant/affected Python packages and their versions: N/A
Relevant/affected Python-related VS Code extensions and their versions: Python (v2021.8.1147840270) & Pylance (v2021.8.2)
Value of the python.languageServer setting: N/A

[NOTE: If you suspect that your issue is related to the Microsoft Python Language Server (python.languageServer: 'Microsoft'), please download our new language server Pylance from the VS Code marketplace to see if that fixes your issue]
Expected behaviour
Expected extension to be installed. Tried to install python and pylance extension on above os (remote ssh), not working. Below steps are attemped:

Download python extension from github release and install .vsix manually, same error message. (see log below)
Download and install other extension are successful and seems like only python and pylance extension got affected since the latest update.

Actual behaviour
Error while installing 'Pylance' extension. Please check the log for more details.
Steps to reproduce:
[NOTE: Self-contained, minimal reproducing code samples are extremely helpful and will expedite addressing your issue]

Install via extension sidebar within vscode, or
Install manually via calling Extensions: Install from VSIX command within vscode.

Logs
[2021-08-20 14:28:13.591] [renderer7] [error] getaddrinfo ENOTFOUND marketplace.visualstudio.com: Error: getaddrinfo ENOTFOUND marketplace.visualstudio.com
at GetAddrInfoReqWrap.onlookup [as oncomplete] (dns.js:67:26)
[2021-08-20 14:29:30.638] [renderer7] [error] read ECONNRESET: Error: read ECONNRESET
at TCP.onStreamRead (internal/stream_base_commons.js:209:20)
[2021-08-20 14:29:35.740] [renderer7] [error] getaddrinfo ENOTFOUND marketplace.visualstudio.com: Error: getaddrinfo ENOTFOUND marketplace.visualstudio.com
at GetAddrInfoReqWrap.onlookup [as oncomplete] (dns.js:67:26)
[2021-08-20 14:31:54.178] [renderer7] [error] read ECONNRESET: Error: read ECONNRESET
at TCP.onStreamRead (internal/stream_base_commons.js:209:20)
[2021-08-20 14:32:55.819] [renderer7] [error] ENOENT: no such file or directory, access '/home/cdsw/.vscode-server/extensions/ms-toolsai.jupyter-2021.8.1236758218': Error: ENOENT: no such file or directory, access '/home/cdsw/.vscode-server/extensions/ms-toolsai.jupyter-2021.8.1236758218'
[2021-08-20 14:32:56.785] [renderer7] [error] ["Error: getaddrinfo ENOTFOUND marketplace.visualstudio.com","    at GetAddrInfoReqWrap.onlookup [as oncomplete] (dns.js:67:26)"]
[2021-08-20 14:32:56.799] [renderer7] [error] getaddrinfo ENOTFOUND marketplace.visualstudio.com: Error: getaddrinfo ENOTFOUND marketplace.visualstudio.com
at GetAddrInfoReqWrap.onlookup [as oncomplete] (dns.js:67:26)

Output for Python in the Output panel (View→Output, change the drop-down the upper-right of the Output panel to Python)

XXX

It seems from the logs, you have network connection issues - Please check if you are able to do following?
Please follow these steps

Help -> Toggle Developer Tools -> Network
Then check for any network failed requests while browsing and installing the extensions if found all requests fails then its probably a proxy or DNS issue at your end.
To confirm its a network issue check if you can access this page https://ms-python.gallerycdn.vsassets.io/extensions/ms-python/python/2019.8.29288/1565127378610/Microsoft.VisualStudio.Services.Icons.Default, if you cannot please contact your network administrator.

Can you please try installing the python extensions and provide us following logs
Apologize for the late reply again. Please see the below logs.

Help -> Toggle Developer Tools -> Console

View -> Command Pallette... -> Toggle Shared Process -> Console

N/A

View -> Open View… -> Log (Shared)

N/A

View -> Open View… -> Log (Window)

[2021-08-30 13:54:25.900] [renderer5] [error] ["Error: getaddrinfo ENOTFOUND marketplace.visualstudio.com","    at GetAddrInfoReqWrap.onlookup [as oncomplete] (dns.js:67:26)"]
[2021-08-30 13:54:25.924] [renderer5] [error] getaddrinfo ENOTFOUND marketplace.visualstudio.com: Error: getaddrinfo ENOTFOUND marketplace.visualstudio.com at GetAddrInfoReqWrap.onlookup [as oncomplete] (dns.js:67:26)

I met the similar problem. I've tried the following two way to install them but failed.
(1. Install via extension sidebar within vscode, or
2. Install manually via calling Extensions: Install from VSIX command within vscode.)
My solution is as follows. I don't know the reason but it actually works for me. Hope it helps you.

Download the .vsix file of python extension from https://marketplace.visualstudio.com/vscode and install it via command line:
code --install-extension xxxx.vsix
This command installs python extension to the path ./.vscode/extensions/ms-python.python-xxx successfully.
Move ./.vscode/extensions/ms-python.python-xxx to ./.vscode-server/extensions/.
Now you can find the python extension in vscode and the pylance extension will be installed automatically. When receive the installation success message, restart the vscode window to activate them.

Hi Zhuo, thanks for your reply. I followed your step and failed at the first step, got same error: "Failed Installing Extensions: vscode-remote://ssh-remote%2Bbocvp/home/cdsw/ms-python-release.vsix". Do you have any ideas?

I'm having this problem trying to load Python and Pylance on an ssh remote. I can install other extensions - and in fact Jupyter installs successfully when I try to install Python and Pylance. Other random extensions can be installed on the remote.
The failure normally shows up as a connection failure to an IP address, something like this:
[2021-09-02 06:51:32.418] [renderer1] [error] connect ETIMEDOUT <IP_ADDRESS>:443: Error: connect ETIMEDOUT <IP_ADDRESS>:443
    at TCPConnectWrap.afterConnect [as oncomplete] (net.js:1146:16)

This visualstudio.com address seems to be used for python extension installation but not for anything else. Just poking around at it with a browser gets:

Our services aren't available right now

We're working to restore all services as soon as possible. Please check back soon.

@xinrongl There is a new release update last week. Can you please update VS Code to 1.60.0 and please try?

@xinrongl There is a new release update last week. Can you please update VS Code to 1.60.0 and please try?

hi @sandy081 , thanks for notifying me, found the issue is resolved from the latest release, thanks.

This issue is also on FreeBSD not certain if this is supported from your end. Also, 1.6 is not yet ported to FreeBSD so cannot validate.

@xinrongl There is a new release update last week. Can you please update VS Code to 1.60.0 and please try?

Fixed for me, thanks!

I was getting the following error when trying to install on a remote server in our lab that does not have Internet access:
[2021-10-02 09:48:12.729] [renderer1] [error] Error while installing 'ms-python.python' extension in the remote server. getaddrinfo ENOTFOUND ms-python.gallery.vsassets.io
The solution was to download the vsix file, copy it to the remote/lab server, the install it manually: https://stackoverflow.com/a/50232194/215945


Two Items Selected in Navigation Drawer

Bug only for front-end.
To replicate bug

Open BuildmLearn Application
Open Navigation Drawer
Goto Settings/Saved Projects
Press Back Button (Application Minimized)
Open BuildmLearn Again
Check Navigation Drawer

It auto-selects Home without resetting previous Selection.

Merged #71 . Thanks.


Sync with internal repo

Commits added:

Fix Update Logic for BackendSets and Listeners for Issue #90
Add NSG Support for IngressClass for Issue #58
Add delete-protection-enabled annotation for LB preservation on IngressClass delete for Issue #91

Pull Request Test Coverage Report for Build<PHONE_NUMBER>4
Details

154 of 186 (82.8%)  changed or added relevant lines in 5 files are covered.
3 unchanged lines in 2 files lost coverage.
Overall coverage increased (+0.8%) to 65.559%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

pkg/controllers/ingress/ingress.go
2
5
40.0%

pkg/loadbalancer/loadbalancer.go
54
60
90.0%

pkg/controllers/ingressclass/ingressclass.go
61
84
72.62%

Files with Coverage Reduction
New Missed Lines
%

pkg/controllers/ingress/ingress.go
1
53.87%

pkg/loadbalancer/loadbalancer.go
2
70.99%

Totals

Change from base Build<PHONE_NUMBER>8:
0.8%

Covered Lines:
2564

Relevant Lines:
3911

💛  - Coveralls