fix: verifiable bdd test issue

Signed-off-by: talwinder.kaur<EMAIL_ADDRESS>

@talwinder50 this is a "fix:" rather than a "feat:". it would be helpful if you could update your commit description.

@talwinder50 this is a "fix:" rather than a "feat:". it would be helpful if you could update your commit description (similar to the updated PR title).

Done


Minor typo fix(es)

Noticed in chatterino/chatterino2#2770 and bothered me just enough to come fix it :T

Thanks @Felanbird!


Ionic v.4 don't use dependency ionic-angular

I transfered my Ionic project from Ionic V3 to V4. Now I can't use ionic-hockeyapp, because of peerdependency to module 'ionic-angular'. Ionic V4 use @ionic/angular instead:
ERROR in node_modules/ionic-hockeyapp/dist/src/hockey-app.d.ts(1,26): error TS2307: Cannot find module 'ionic-angular'.

@ebeling Have you found another way to use HockeyApp with Ionic 4?

@iamkinetic In my Ionic4-project I now use cordova-plugin-appcenter-analytics and cordova-plugin-appcenter-crashes with @ionic-native/app-center-analytics and @ionic-native/app-center-crashes. ( see https://ionicframework.com/docs/native/app-center-analytics ) It's replacement of HockeyApp.


fix _MSC_VER version to check for std::filesystem

According to https://github.com/nlohmann/json/blob/cc59ab122f75448c17ac623d10306cbe19cde970/include/nlohmann/detail/macro_scope.hpp#L72 MSVC supports std::filesystem since 19.14, (Visual Studio 2017 version 15.7) that has _MSC_VER == 1914 according to Microsoft documentation, but the check is done against a not existing value 1940 (latest Visual Studio 2022 has _MSC_VER == 1930).
I just change this value.

Pull request checklist
Read the Contribution Guidelines for detailed information.

[x]  Changes are described in the pull request, or an existing issue is referenced.
[x]  The test suite compiles and runs without error.
[x]  Code coverage is 100%. Test cases can be added by editing the test suite.
[x]  The source code is amalgamated; that is, after making changes to the sources in the include/nlohmann directory, run make amalgamate to create the single-header file single_include/nlohmann/json.hpp. The whole process is described here.

Please don't

The C++11 support varies between different compilers and versions. Please note the list of supported compilers. Some compilers like GCC 4.7 (and earlier), Clang 3.3 (and earlier), or Microsoft Visual Studio 13.0 and earlier are known not to work due to missing or incomplete C++11 support. Please refrain from proposing changes that work around these compiler's limitations with #ifdefs or other means.
Specifically, I am aware of compilation problems with Microsoft Visual Studio (there even is an issue label for these kind of bugs). I understand that even in 2016, complete C++11 support isn't there yet. But please also understand that I do not want to drop features or uglify the code just to make Microsoft's sub-standard compiler happy. The past has shown that there are ways to express the functionality such that the code compiles with the most recent MSVC - unfortunately, this is not the main objective of the project.
Please refrain from proposing changes that would break JSON conformance. If you propose a conformant extension of JSON to be supported by the library, please motivate this extension.
Please do not open pull requests that address multiple issues.

Thanks for the PR! Looks like a copy/paste error on my side. I will happily merge this if the CI accepts it. I am not using MSVC myself...

Coverage remained the same at 100.0% when pulling dd2a42ea66d328271c4b35b10acba74b1c032df6 on gcerretani:fix_filesystem_msvc into cc59ab122f75448c17ac623d10306cbe19cde970 on nlohmann:develop.

Thanks!


[HACKADOG] Dogstream

DO NOT MERGE
Just in case
What it does
dogstream package contains the code to tail log files + invoking the parsers. Ideally, this will be moved to its own repo.
The "main loop" logic to run Dogstream is implemented as a go check, dogstream.go. We allow checks to specify 0 as an interval, that meaning the check has to run only once in the agent lifetime. Think about it as a check that never returns from check()
Notes
The parsers are responsible to send metrics through dogstatsd on their own, the final goal would be using the internal API to post metrics.

Is there any change of dogstream making into some version in the future?


ImageOptim always quits

There is a flag in the ImageOptim code that determines if the app should quit when done:
int main(int argc, char *argv[]) {
    quitWhenDone = hideLogs = isLaunchedWithCliArguments(argc, argv);

This is always set to true due to the call to ImageOptim in ImageOptimBashLib:
"${location}Contents/MacOS/ImageOptim" 2> /dev/null "${TEMP_PATH}"

The "${TEMP_PATH}" is the arg that sets quitWhenDone to 1, so the app quits.
Not sure of the fix, it's not the end of the world, but I quite like to inspect what ImageOptim has done.
Maybe another arg to ImageOptim, but that would need help from @pornel.

What would be your preferred behavior?

*poke* @jamesstout

Maybe a flag that gets checked first that says "don't quit when done"?
static int isLaunchedWithCliArguments(int argc, char *argv[]) {
    // Unfortunately NSApplicationLaunchIsDefaultLaunchKey doesn't cover bare CLI launch
    if (argc < 2) return 0;
    for (int i=0; i < argc; i++) {
        if ([[NSString stringWithFormat:@"%s", argv[i]] isEqual:@"--dont-quit-when-done"]) {
            return 0;
        }
        if ('-' == argv[i][0]) { // Normal OS X launch sets -psn
            return 0;
        }
    }
    return 1;
}

Or if you want to stick with C strings:
#include <string.h>

static int isLaunchedWithCliArguments(int argc, char *argv[]) {
    // Unfortunately NSApplicationLaunchIsDefaultLaunchKey doesn't cover bare CLI launch
    if (argc < 2) return 0;
    for (int i=0; i < argc; i++) {
        if(strcmp(argv[i], "--dont-quit-when-done") == 0){
            return 0;
        }
        if ('-' == argv[i][0]) { // Normal OS X launch sets -psn
            return 0;
        }
    }
    return 1;
}

Option 1: https://github.com/ImageOptim/ImageOptim/compare/master...jamesstout:dont-quit-when-done
Option 2: https://github.com/ImageOptim/ImageOptim/compare/master...jamesstout:dont-quit-when-done-cstring

I'm not interested in implementation part. "Not quitting" can be done even easier by deleting all the qutting logic I've deliberately put in there.
I'm more interested in understanding why quitting is a problem, and how do you want ImageOptim to behave.
Note that when it's launched directly from CLI, it crates multiple copies.  Surely, that's not a desireable behavior?
There's another alternative that already exists and works, which is to use the open -a ImageOptim command, which will find an existing running instance and add files to it. That doesn't quit automatically.

Yeah, thinking about it, if imageOptim doesn’t exit then Jamie’s imageOptimBashLib doesn’t know imageOptim has finished.
Really, I just noticed that the -q option in imageOptim-CLI doesn’t work, or rather, if you don’t provide that arg, then imageOptim still quits, and I wondered why. Not really thinking about how it should behave.
Quitting isn’t a problem, in fact as it stands, it has to quit.
Forget all this, I’ll play around with open -a
Thanks
James

On 31 May 2017, at 10:12 PM, Kornel<EMAIL_ADDRESS>wrote:
I'm not interested in implementation part. "Not quitting" can be done even easier by deleting all the qutting logic I've deliberately put in there.
I'm more interested in understanding why quitting is a problem, and how do you want ImageOptim to behave.
Note that when it's launched directly from CLI, it crates multiple copies.  Surely, that's not a desireable behavior?
There's another alternative that already exists and works, which is to use the open -a ImageOptim command, which will find an existing running instance and add files to it. That doesn't quit automatically.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub https://github.com/JamieMason/ImageOptim-CLI/issues/140#issuecomment-305199184, or mute the thread https://github.com/notifications/unsubscribe-auth/ABgM_qm-wWXXjmmqLkiNaE6f-HNOGbQrks5r_XVSgaJpZM4MSMai.

Here's a version that doesn't quit if you don't pass the -q arg. Not sure if you want to change things at this point, but I just had to figure it out :)
https://github.com/JamieMason/ImageOptim-CLI/compare/master...jamesstout:dont-quit-when-done


fix(cli): encapsulate helm and kubectl commands and code cleanup

Description
This pull request changes the following:

encapsulate helm and kubectl commands
polish cluster commands
polish chart commands
apply colors in console messages for clarity

Related Issues

Closes #469

:tada: This PR is included in version 0.12.0 :tada:
The release is available on:

GitHub release
npm package (@latest dist-tag)

Your semantic-release bot :package::rocket:


dont use $(solutiondir) in project settings realsense.vcxproj

Required Info

Camera Model
R200, F200 and SR300

Firmware Version

Operating System & Version
Windows

Kernel Version (Linux Only)

Build System
VS2015

When you use $(solutiondir) to configure dependencies and build paths in visual studio this may cause problems when using that project to other solutions.   for example, someone who has projects that depend on the realsense library will likely add realsense.vcxproj to their own solution and add a project dependency causing a convenient rebuild when librealsense is updated etc.  Because solutiondir will be different, it will affect how librealsense gets compiled (or fail to get compiled).
Currently in librealsense.vc14/realsense/realsense.vcxproj there are 4 such entries in the form of:
   <ModuleDefinitionFile>$(SolutionDir)../CMake/realsense.def</ModuleDefinitionFile>

a better approach would be to use:
    <ModuleDefinitionFile>../../CMake/realsense.def</ModuleDefinitionFile>

Thanks


[5.1 3-18] [ParseableInterface] Serialize module into buffer and load from it

In addition to being wasteful, this is a correctness issue -- the
compiler should only ever have one view of this file, and it should not
read a potentially different file after validating dependencies.
rdar://48654608
(Cherry-pick of #23173 onto swift-5.1-03-18-2019)

@swift-ci please test

Build failed
Swift Test Linux Platform
Git Sha - 87de0153c3a85f3b6bc63f16b9ffd1b9b94093be

Build failed
Swift Test OS X Platform
Git Sha - 87de0153c3a85f3b6bc63f16b9ffd1b9b94093be


Update Production (10/3/2022)

Merge after #777 and #779

Wait, why'd you merge it? #779 isn't done yet.

It'sn't?

Huh I thought it was. Oops.

I suppose that's what happens when you merge a PR while mildly overheating waiting for a bus to arrive


feat(gui): show smali (#197)

Fix #197
@jpstotz has kindly contributed.

Hi Ahmed,
I just gave your smali branch a try and have to say this looks quite useful. However I noticed that when a class is decompiled also automatically the smali code is generated. In general I would recommend to generate the smali code on-demand when the smali tab is clicked the first time (should be possible via addChangeListener on the areaTabbedPane). Then the user don't have to spend time and memory for generating and storing the smali code that may be never displayed.

Thanks for trying it out. Yes, it should be shown on demand.

I managed to eliminate one major draw-back of your implementation: The forced decompilation of all classes to temporary files. My implementation isn't perfect, but at least doe snot require any temporary files and it decompiles only one class.
To tried to make a pull request for your smali branch, but somehow GitHub refuses to do so (does not allow to select your jadx fork as pull request target). Therefore here is the link to my smali branch and my commit:
https://github.com/jpstotz/jadx/commit/840b5f284edf07420f995c5635ec399ab1833901

Very nice, that is indeed the major issue, I will include your changes.

I was able to make PR to the fork, from the web, you can select the source fork and destination fork.

@asashour Your screenshot shows exactly the point where I had to stop, because Github does not allow me to select your asashour/smali branch as base repository on the left side.
I get a long list of jadx forks as base repository but yours is missing in the list. When I use the integrated search and search for "asa" or "asashour" no entry is left.

@jpstotz thanks for pointing this out, would this help?

How about showing the byte code for each instruction in the small tab. Maybe in a row on the left?

How about showing the byte code for each instruction in the small tab. Maybe in a row on the left?

Can you elaborate more? Why the actual byte code would be important?
Also, we use Baksmali, and it would be difficult to implement that, without existing options.

It would be useful for dex modifications on byte code level, as used in my project "Blackberry Manager".


Pc freeze

hello im happy to see that you are working on this script,i know it's on its early stages so bugs are expected,i have a issue my pc is freezing when i try to import a model,mouse curser laggıng a bit then screen copletly freezes.

It was my mistake models should be extracted as uncompressed.


⚠ one api has degraded performance

In 721a4af, one api (https://one.yjr.me) experienced degraded performance:

HTTP code: 502
Response time: 4177 ms

Resolved: 导航 performance has improved in 942d706 after 16 minutes.


Added community contribution

Accidently commented in the commit description :)
And I thought I was changing the first pull request, but made a new one and couldn't find a button to remove the first one, so now there's two commits... much to learn how to git still.

@nilsweb  So what's going on? Is this going to get pulled or rejected, or are we just waiting for something?
If you look here, The formatting works now.
https://github.com/Fraasi/Rainbow-Code/blob/a0fe05ca0998f6d3a5879c58b1dee556c49944eb/_CodingChallenges/30-phyllotaxis.md

Hey @Fraasi, sorry for the delay on this - there's quite the backlog of open PRs due to the website being so new, I'll try to get through them over this weekend. For now, I've checked your PR and will merge it now. It looks great, by the way, I especially like the gallery of possibilities!

@meiamsome No problem, lots of things to do to keep the train moving. The new site looks great, that's why I thought want this up there:)
I'll take a looksee around the issues if there's anything I could help with.

@Fraasi I'm really sorry! I somehow broke my Jekyll installation and couldn't get it running again due to some dependency issues so I forgot to merge... 😞
Thanks @meiamsome for taking over!

@nilsweb  We're all busy doing the things we do, if I counted all the things I've broken, I wouldn't have build anything . No worries, just wondering. But since you know jekyll, maybe take a look if this is ok? https://github.com/CodingTrain/website/issues/420
When you have time that is :)


Add preaction to delete the Nats-operator resources if any remain

Add preaction to delete the Nats-operator resources if any remain

/test pre-main-reconciler-protecode-guard

/retest

/test pre-main-reconciler-protecode-guard


Game Title
iRacing
Game Website
https://www.iracing.com
Anti-Cheat Software
Easy Anti-Cheat
Status of the Anti-Cheat
❔ Unconfirmed
Proof of Mention
N/A

Duplicate of #78


V4 API

While doing a bit of V4 JS client (#195), reading through all the current API methods I thought of another API to: ease the use, be more consistent and plan future evolutions.
Here's the current relevant API:
var client = algoliasearch();
var index = client.initIndex();

// global indexes actions
client.deleteIndex();
client.listIndexes();
client.moveIndex();
client.copyIndex();

// search
client.batch(); // multi index write
client.search(); // multi index search

// global keys
client.listUserKeys();
client.getUserKeyACL();
client.deleteUserKey();
client.addUserKey();
client.updateUserKey();

// index objects
index.addObject(); // Add or update
index.addObjects(); // Add or update
index.getObject();
index.getObjects();
index.partialUpdateObject();
index.partialUpdateObjects();
index.saveObject(); // add or update
index.saveObjects(); // add or update

// index keys
index.listUserKeys();
index.getUserKeyACL();
index.deleteUserKey();
index.addUserKey();
index.updateUserKey();

// index actions
index.waitTask();
index.search();
index.similarSearch();

// index settings
index.getSettings();
index.setSettings();

index.clearIndex();

For V4, I propose a new API where we introduce namespaces.
var client = algoliasearch();
var index = client.initIndex();

// multi indexes methods
client.batch(); // same
client.search(); // same

// global indexes methods
client.deleteIndex();
client.listIndexes();
client.copyIndex();
client.moveIndex();
client.clearIndex(); // was index.clearIndex()

// global keys
client.keys.get(); // was client.getUserKeyACL
client.keys.add(); // was client.addUserKey
client.keys.update(); // was client.updateUserKey();
client.keys.delete(); // was client.deleteUserKey();
client.keys.list(); // was client.listUserKeys();

// index search
index.search();
index.similarSearch();
index.browse();
index.browseFrom();

// index settings
index.settings.set(); // was index.setSettings;
index.settings.get(); // was index.getSettings;

// objects methods, all of them can take an object or an array or objects
index.objects.save(); // was index.addObject, index.addObjects, index.saveObject, index.saveObjects. There's no way to get a proper real ADD with the API, it's always create or update no matter what you do, you will never get "Object already exists"
index.objects.partialUpdate(); // was index.partialUpdateObject, index.partialUpdateObjects. Update only, should error if object does not exists (not sure this is feasible, API is permissive here)
index.objects.delete(); // was index.deleteObject, index.deleteObjects
index.objects.get(); // was index.getObject, index.getObjects

// index keys
index.keys.get(); // was index.getUserKeyACL
index.keys.add(); // was index.addUserKey
index.keys.update(); // was index.updateUserKey;
index.keys.delete(); // was index.deleteUserKey;
index.keys.list(); // was index.listUserKeys;

I believe this proposal should be easier to reason about (consistent) and help us in the future when we need to add methods, parameters.
What do you think?

I like it.
But why not do the same with index methods:
client.deleteIndex() =>  client.index(name).delete() ?

client.deleteIndex() => client.index(name).delete() ?

I hesitated on this one, this is not a very common API in JS I feel. It reads weirdly compared to descriptive "deleteIndex" no?

:+1: with both the proposal and the comment of @ElPicador .
The issue is that we try to stay consistent across all of our clients, no?

For the scala api, I did this delete index "myIndex"
But indeed it might be weird for JS

The issue is that we try to stay consistent across all of our clients, no?

Yes that's a very good point. But I thought that at some point, if we want nice things, we break and move forward! :) And iteratively it will get better.

Couldn't we merge index.objects.add() and index.objects.update() ?

Couldn't we merge index.objects.add() and index.objects.update() ?

I hesitated too on this. The thing is that I feel being magical can be bad for developers in the end. I prefer to state ADD is to ADD (and if you try to update with it, it will error), update is to UPDATE (and if you try to add with it, it should error).
Rather than a magical .save() that does everything. But this is open to more advices, thanks for feedback.

It's a bit like "mkdir", it's good that it does error if the directory exists by default, so you do not make mistakes without knowing it.. ?

But is it failing currently ? I am not sure. Because for me the difference between addObjects and saveObjects was just the need for an objectID in records that are being pushed, and no error coming from the api

I hesitated too on this. The thing is that I feel being magical can be bad for developers in the end. I prefer to state ADD is to ADD (and if you try to update with it, it will error), update is to UPDATE (and if you try to add with it, it should error).

I don't think the API is returning an error in these cases, how do you plan to check that?

It's definitely more a more REST-ish / OO API client this way, but I kinda like the simplicity of the current one: namespaces feels really weird in JS because libraries usually prefer to have a flat hierarchy of methods.
If it is for the sake of consistency then go for it :+1: , but apart from that I don't really see an improvement over the current version.

But is it failing currently ?

It's not, currently both addObject and saveObject are doing the same exact thing.

So I would prefer having only a save method. Because if I understand correctly you could do everything with the update method. Right ?

I don't think the API is returning an error in these cases, how do you plan to check that?

If it's not feasible then I will just merge add and update into a save method. Because those are doing exactly the same indeed.

So I would prefer having only a save method. Because if I understand correctly you could do everything with the update method. Right ?

Yes, if the API is not able to send an error when you said "ADD" then I will merge update and add in save. Good point you had the same idea because it feels simpler (cc @redox)

namespaces feels really weird in JS because libraries usually prefer to have a flat hierarchy of methods.

Agree. It really depends on the project, you can have namespaces in JS. It's not the most common pattern but here's on example of a github api client with namespaces: https://github.com/mikedeboer/node-github.

If it is for the sake of consistency then go for it  , but apart from that I don't really see an improvement over the current version.

Some of this refactoring is for consistency, we have weird things like "userKeys", which are no more user keys but just keys in Algolia.
Namespaces can useful to avoid having to duplicate every function name to indicate "you can pass one thing" "you can pass multiple thing".
That way we can remove addObjects, saveObjects, getObjects, partialUpdateObjects because those are just objects.add, objects.save, objects.get usable with one or multiple things.
Flat API is nice yes but at some point when the number of methods grow then it becomes complex.

So it seems there's no way to get an error like "This object already exists" from the API, it means we can safely merge add and save into just save. It will avoid the users having to decide which one to use. Those are the same: dont have objectID? => create, have an objectID => create or udpdate

Basically there's no ADD in Algolia, it's always an ADD OR UPDATE that is being done. So we should reflect that in API clients.

I also have a few concerns that were already raised, but here are my feedbacks on the whole list:

// global indexes methods
client.deleteIndex();
client.listIndexes();
client.moveIndex();
client.clearIndex(); // was index.clearIndex()

The client/index syntax tripped me up sometimes. I would like to be able to do index.rename, and index.clear directly from the index. I'm ok with keeping the top level list and the destructive delete on the parent client.

// global keys
client.keys.get(); // was client.getUserKeyACL
client.keys.add(); // was client.addUserKey
client.keys.update(); // was client.updateUserKey();
client.keys.delete(); // was client.deleteUserKey();
client.keys.list(); // was client.listUserKeys();

The namespace really feels weird to me. Not sure to see the value it adds. Having this kind of namespace would make me want to use client.keys as a list to iterate on, but this won't be possible as this is just an object namespace.
I'd rather keep the previous methods, maybe with a bit of renaming, getKey, addKey, updateKey, deleteKey and listKeys.

// index settings
index.settings.set(); // was index.setSettings;
index.settings.get(); // was index.getSettings;

I'd keep the previous getSettings/setSettings, especially because we use it in every other API client. If it would bring value to have it in a better JS way I would be ok with it, but I'm not sure I see what it brings here.

// objects methods, all of them can take an object or an array or objects
index.objects.add(); // was index.addObject, index.addObjects. Now ADD only (POST), should error if object exists. Easier to reason.
index.objects.update(); // was index.saveObject, index.saveObjects. Update only, should error if object does not exists (not sure this is feasible, API is permissive here)
index.objects.partialUpdate(); // was index.partialUpdateObject, index.partialUpdateObjects. Update only, should error if object does not exists (not sure this is feasible, API is permissive here)
index.objects.delete(); // was index.deleteObject, index.deleteObjects
index.objects.get(); // was index.getObject, index.getObjects

First, I wonder about the name object. Across our documentation we often use object, record or item. Maybe it would be a good time to bring consistency here?
As we all our adds actually do a and or update, maybe we could just use saveObjects/saveObject instead of the add and update methods? And an updateObject to do the partialUpdate? The naming actually make more sense to me, but considering the SDK history I'm unsure it is worth changing.

// index keys
index.keys.get(); // was index.getUserKeyACL
index.keys.add(); // was index.addUserKey
index.keys.update(); // was index.updateUserKey;
index.keys.delete(); // was index.deleteUserKey;
index.keys.list(); // was index.listUserKeys;

I would keep the same naming than I suggested for the client-level keys

The client/index syntax tripped me up sometimes. I would like to be able to do index.rename, and index.clear directly from the index. I'm ok with keeping the top level list and the destructive delete on the parent client.

Yep we could do that but if we do it we should do it for every methods. It would bring again more inconsistency to have index methods being distributed between client and index objects with no real decision but making it harder to find "deleteIndex" on purpose.

client.keys as a list to iterate on, but this won't be possible as this is just an object namespace.

Yes good point, that's a bold choice to make because if we keep .getKeys, .addKey, .updateKey then there's no more need to namespaces at all and we should not make .objects too.

I'd keep the previous getSettings/setSettings,

Same concern than keys.*, clearIndex, deleteIndex, if we do not use namespaces everywhere then it will look weird and not consistent.

First, I wonder about the name object.

I think it's ok, the whole Algolia records/objects are driven by "objectID" attribute, so having an object namespace feels consistent with the API.

As we all our adds actually do a and or update, maybe we could just use saveObjects/saveObject instead of the add and update methods?

Yes I removed add and save to only provide save(). Algolia is only ADD OR UPDATE on objects. The automatic objectID creation being only triggered when there's no objectID provided (= ADD).

And an updateObject to do the partialUpdate?

I like partialUpdate because it's descriptive that it's a partialUpdate, otherwise how to tell the difference between save() and update()? You will have to look at the documentation.

So I believe client.[move|delete|copy]Index are set on the client because once you use them you do not want to query the index again.
So index.move() won't work because you would have to then stop using the index object (it will fail). We could fix it, but it won't be a good idea.

This is not the API we will provide, was still nice to think about it.


xUnit reporter produces files in an invalid format

I'm working on integrating some tests that make use of webdriverio and the XUnit reporter into my visual studio online build process, but the XUnit files that the reporter produces are throwing a build error saying they are invalid format.
Please see the error below:

2016-02-08T17:53:52.4196961Z Executing the powershell script: C:\TfsBuildAgents\G2TFS-VSO-BuildAgent\tasks\PublishTestResults\1.0.18\PublishTestResults.ps1
2016-02-08T17:53:52.5758710Z Publishing Test Results...
2016-02-08T17:53:53.8326758Z ##[warning]Invalid results file. Make sure the Test Result Format field in the task matches the result format of the file: 'C:\TfsBuildAgents\VSO-BuildAgent_work\2\s\WDIO.xunit.chrome.2672.xml'

The file produced was(Renamed to .txt for upload to github):
WDIO.xunit.chrome.2672.txt

I'm also not able to load the JUnit files in Eclipse due to invalid unicode characters:

This got fixed with latest version v0.3.0


Fix trace error caused by wifi modules

This is a regession issue that caused by commit: c7bb847c504bcc "Load mac80211 module based on iwl7000_mac80211 module existence" The reason is that load_iwl_modules need search right to access trace node in /sys/kernel/debug/tracing. This patch adds search right for selinux.
Tracked-On: OAM-126168

Android CI has started Engineering Build for this issue ,Please check the linked Tracked-On issue/Android CI Web  for more details.

Android CI has started MERGE Build for this pr ,Please check the linked Tracked-On issue/Android CI Web  for more details.

Android CI has completed MERGE Build for this pr, build is SUCCESS. Please check the linked Tracked-On issue/Android CI Web  for more details. For Binaries: /cactus-absp-or-local/celadon-merge/773


[Court] Rename "Prepare Exit Court" button

I'd rename Prepare Exit Court to Unstake. That's language that everybody in the crypto space understands. People are also aware that staking often comes with unlocking periods, so I think the fact that they won't immediately have access to their funds will be clear to people as well.

I would also suggest renaming Become a Juror to Stake, same reason.


Dropping an ImageHandle results in the "already borrowed: BorrowMutError" panic on the next Graphics2D use

Thank you for this crate!
Here is a modified hello_world example that demonstrates the panic.
use speedy2d::color::Color;
use speedy2d::window::{WindowHandler, WindowHelper};
use speedy2d::{Graphics2D, Window};
use speedy2d::dimen::Vec2;
use speedy2d::image::ImageHandle;
use speedy2d::window::KeyScancode;
use speedy2d::window::VirtualKeyCode;

fn main()
{
    let window = Window::new_centered("Speedy2D: Hello World", (640, 240)).unwrap();
    window.run_loop(MyWindowHandler { image: None, current_frame: 0 })
}

struct MyWindowHandler
{
	current_frame: u64,
    image: Option<ImageHandle>,
}

impl WindowHandler for MyWindowHandler
{
    fn on_draw(&mut self, helper: &mut WindowHelper, graphics: &mut Graphics2D)
    {
        if self.current_frame == 0 {
             //provided assets/image.png does exist.
             let image_handle = graphics
                .create_image_from_file_path(
                    Some(speedy2d::image::ImageFileFormat::PNG),
                    speedy2d::image::ImageSmoothingMode::Linear,
                    "assets/image.png",
                )
                .unwrap();
            //If uncommented, works
            //self.image = Some(image_handle);
        }
        // clear_screen doesn't trigger the panic, but draw_circle does.
        graphics.draw_circle(Vec2::new(100.0, 150.0), 50.0, Color::from_gray(0.0));
        self.current_frame += 1;
        helper.request_redraw();
    }
}

Thanks for reporting this! I've put in a fix, and will release this in v1.11.0 shortly.


Repository path update

New repository is located at https://github.com/nextmn/upf

Blocking:

[ ] sign & merge this PR: https://github.com/louisroyer/go-pfcp-networking/pull/6
[ ] publish v0.0.24 of go-pfcp-networking
[ ] update deps


[Feature request]: Support Garage-Control Cam

Describe the solution you'd like
Please add support for the newly released Garage-Control Cam.

I need access to the device to implement it, but at the moment I am already implementing other devices.
If you want to share the device with me, I'll get back to you as soon as I can take care of it.
Let me know.

Sure, just let me know when and what I need to do.

I need access to the device to implement it, but at the moment I am already implementing other devices. If you want to share the device with me, I'll get back to you as soon as I can take care of it. Let me know.

How should we share the device with you? I may send one for you if you need it.

You can simply share it with me from the Eufy app with admin rights on the following account:

<EMAIL_ADDRESS>

You can simply share it with me from the Eufy app with admin rights on the following account:

<EMAIL_ADDRESS>

done ✅

@bropat I'm interested in this feature. I'm also a developer so I can help out if you need some coding help. I have two of these devices.

@bropat do you have any updates on this feature?

Any progress here?

Sorry, once again I didn't have enough time to implement this device completely.
If someone could share the device with me again, I will try to implement the remaining functionalities:

<EMAIL_ADDRESS>(for EU)
<EMAIL_ADDRESS>(for US)

I remind you again that to implement I have to run and test all the functionalities.
Thanks!

Sent

Looks like you've added support now. Thank you. Do you still need device access, or can I remove that now?

@AnAnonymousUsername
You can remove it. Thanks!

I have a question on this implementation.
Was it only the cam support that was added?
Or was Door Position added as well?
Was support for state (Home/Away/Night/Off) added?


Add Butterknife view bindings to AchievementsActivity

Before you start refactoring, evaluate if it is necessary to add Butterknife view bindings.

findViewById is only used for local calls, not necessary to refactor. Wont fix.


Quorum Consistency Optimization

These patches do the following:
o responds earlier to the requests as soon as quorum is achieved instead of waiting for all responses.
o Solves a bunch of crashes related to early closing of sockets, timeouts etc. These show up in quorum consistency
o Add ASSERT_LOG : here we can add extra information in case the assert fails.
o Logs will now show milliseconds. This can be helpful in debugging.
o Adds good comments on the new variables added
This patch could be the first step towards zero message copy in dynomite.

Let us discuss offline if we need to update the configure.ac with the new version as well and what number to use, 0.5.6? Secondly, since these are patches that fix bugs in the connections for 0.5.4, I propose to create a new release once merged to master.


Investigate improvements to k8s node metrics charts

lots of series, cpu intensive and confusing
look at existing grafana charts for k8s


Fixing a few minor issue with cloning

Coverage decreased (-0.006%) to 68.206% when pulling 704274c1073d01a30311b5398614835a1fd96dc5 on kevgliss:fixes into f9b16a21107e5f39197417487b4d3916382de7e5 on Netflix:master.


Recommended version of Python for medspaCy 1.0.0

I have been running medspacy 0.2.0 in a Python 3.7 environment, because I found that higher versions of Python broke it.  After installing medspacy 1.0.0 in that environment though, I get an error importing medspacy, because it uses typing.Literal, which was implemented in Python 3.8.  I am happy to create a new environment for medspacy, but want to make sure I create one on which it is well tested.

Great question @RonWilkinson .  You are correct that 3,7 is no longer supported.
So answer your questions, our continuous integration of unit tests, etc is currently running Python 3.8.
Meanwhile, many of the medspacy developers have been using Python 3.9.
Does this answer your question?

Yes.  I will be slightly adventurous and use a 3.9 environment like the medspacy developers rather than 3.8, and I will not try to use a 3.10.7 environment, which is the most current full release of Python as of Sept. 6, 2022.  Thanks.

Sounds great.  I think 3.9 is a good place to be for now.

@RonWilkinson  - Thanks for raising this issue. I encountered the same problem today.

Agreed.  This PR from @andyjessen  looks like a good one so that we can prevent issues like this.  I believe we'll be merging this in soon and likely do a minor release.


posty steps into ahiss's space again

posty steps into ahiss's space again
ahiss interrupts her and reminds her to back up
posty backs off and apologizes. it might be sarcastic if you want.
ahiss chastises posty for forgetting. make sure the last line of the interaction is ahiss, so it transitions into the next block correctly.

assigned to strawanimations


:page_facing_up: Use correct pharmacy xml resource

Coverage decreased (-0.4%) to 93.173% when pulling 7e2e8da8679f88b9e67a4d4cfb22c1471643d0af on fix/use-correct-pharamcy-xml-resource into e3c62e9c535860c53a2f5900be2434e684f9ccf7 on master.

Coverage decreased (-0.4%) to 93.173% when pulling 156109efaa1e115a6f827426d780f95b589931e2 on fix/use-correct-pharamcy-xml-resource into cc17b822787caa83f474d5250de23af49afc1d19 on master.


Migrate luminescence schema to luminescence/REC/2023/09

As part of updating the SoftMax Pro, Agilent Gen5, and PerkinElmer Envision adapters to use the /plate-reader/REC/2023/09/ schema, the luminescence schema should be migrated from luminescence/BENCHLING/2023/09 to luminescence/REC/2023/09.

Determined to be not needed given that the /plate-reader/BENCHLING/2023/09 schema accounts for these changes.


Get messages from page

I have a official page of my company in my FB. I have official page of my company in my FB. So, Can i get messages from my page messenger?

Not entirely sure what you're asking:

Do you want to log in as a page, and read messages sent to the page from all users?
Do you want to chat with a page from a single user account?

The first case is unsupported, you should use the official API for that.
The second case is supported, you can use Client.fetchThreadMessages(page_id).
Hope that answers your question, if not, please elaborate!


Fix various intents opening up multiple/duplicate activities

Purpose

Fixes button presses triggering multiple times, which opens duplicate dialogues/windows

Does this introduce a breaking change?

[ ] Yes
[x] No

Pull Request Type
What kind of change does this Pull Request introduce?

[x] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Documentation content changes
[ ] Other... Please describe:

How to Test

Ensure rapid clicks (Best done on a real device) don't open up multiple activities or dialogues

tested on group call branch.

@Gemakk please verify if the changes works fine for teams branch. If the user is rejected at lobby screen then we display setup screen. I do not think these changes will cause issue.

I tested this change on the teams branch and it seems to behave fun when being rejected from the lobby screen.


Add config file support

Currently, all the configs are hard-coded. A Config object is created and then used to submit the topology. A big problem is that when there is any config change, such as increase ram size for container or a specific component, the whole application needs to be rebuilt.
Ideally config should be decoupled from logic. To do it, Config object should be constructible from a config file so that topology writer can separate the work of implementing the logic and configuring the topology. Furthermore, config changes are managed totally separately.
Any other thoughts are welcome.

https://github.com/apache/incubator-heron/issues/3356 is a better ticket for this request.


Fix CI checks

I investigated the CI failures and discovered it was a non-zero exit code from a call to apt-get update that was causing the workflow to fail.  In order to fix this, I had to fork the gha-ubuntu-cross repo and apply the fix there.  I'm working to get this fix upstreamed in https://github.com/cyberjunk/gha-ubuntu-cross/pull/6.  Once it is, we can revert this reference back to the original repo.
I also fixed a clippy warning that was added 1.72.0.  https://rust-lang.github.io/rust-clippy/master/index.html#/single_range_in_vec_init  The page says "this is almost always incorrect", but it seems clear that this is quite intentional in our case here.  So I silenced the warning by adding an #[allow annotation.

I updated this PR with an improved fix for gha-ubuntu-cross and included the fixes from #467 so checks will pass.


allow specification of facets in EIA.get_dataset

Minor change to allow specification of facets in get_dataset function for EIA. I'm trying to get generation data for one balancing authority, so being able to include the facets I care about in get_dataset allows me to only request data for the one, instead of getting all BAs then throwing away most of the data. facets is an optional parameter, ensuring backwards compatibility with previous versions.

Made requested changes, including adding a test (which passes) and updating the changelog.

If the build passes, this should be ready to merge. There is a minor conflict in CHANGELOG.md that needs to be fixed after merging the latest main into the PR branch.

Are any other changes needed or is this ready to merge?


Date fallback for simulation mode

When using WebPSF and specifying the observation date, add a fallback date=None in cases where the query fails.

Fixed by 233888a.


Request for adding Cronos Mainnet Beta to map of zones

Hello Map of Zones team,
Hope this finds you well!
We have launched our EVM chain "Cronos Mainnet Beta" on Nov.9 - a Cosmos-SDK based EVM chain for DeFi, NFTs, and Metaverse with the aims to massively scale the DeFi and decentralized application ecosystem by providing developers with the ability to instantly port apps from Ethereum and EVM-compatible chains.
We are highly interested in getting Cronos Mainnet Beta to be listed properly on the map of zones and being part of your fantastic network map (in which our main chain Crypto.org is already on).
It would be highly appreciated if you could kindly advise the next steps for this.

Hello @lezzokafka !
Thanks for the issue! Watcher for cronos blockchain located in cosmos-watcher cronos branch: https://github.com/mapofzones/cosmos-watcher/tree/cronos
Currently we have a problem with cronos codec. Usually, we use ModuleBasics for the register codec.
cronosapp "github.com/crypto-org-chain/cronos/app"
cronosapp.ModuleBasics.RegisterInterfaces(interfaceRegistry)

https://github.com/mapofzones/cosmos-watcher/blob/0743af1f31424d54ef5d24cf4e1202f552e8b047/pkg/codec/protobuf_codec.go#L25
github.com/crypto-org-chain/cronos v0.6.1
https://github.com/mapofzones/cosmos-watcher/blob/0743af1f31424d54ef5d24cf4e1202f552e8b047/go.mod#L25
But we cannot decode data at block height 19:
unable to resolve type URL /ethermint.crypto.v1.ethsecp256k1.PubKey: tx parse error [cosmos/cosmos-sdk@v0.44.2/x/auth/tx/decoder.go:55]
Perhaps, we should consider some other dependency, or, on the opposite, there might be a need to fully configure the current ModuleBasics on croons team side.
It would be nice to know how to set up the codec

Hello @Raumo0 , you should be able to register the codec for /ethermint.crypto.v1.ethsecp256k1.PubKey by adding Ethermint dependency here:
https://github.com/tharsis/ethermint/blob/main/crypto/codec/codec.go#L11

Dear @calvinaco and @lezzokafka,
The patch for cronos cosmos-watcher is ready, then it takes time to sync more than 600k blocks.
Also could you provide a logo for displaying the kronos blockchain logo on mapofzones?

Hello @Raumo0, thanks a ton! see if the above logo works for you 👯

Hello @Raumo0, thanks a ton! see if the above logo works for you 👯

Thank you for the logo!


Endpoint Routing Still Experimental?

https://saturnframework.org/explanations/endpoint-routing.html
does this still have to be experimental, and not the default (also for docs)?
as per NET6

This will likely be revisited once .NET 6 support lands

suppose endpoint routing is final now NET8 LTS, NET9 (NET10 coming out november)


UI: add Publish Draft option

With the Draft version available, we can add an option that will be available only for the Draft version of the widget, which will allow publishing the draft version as a main version with one button.
It will:

copy the draft version to the main widget
publish the main widget
remove the draft version.

closed in alpha.near.org viewer by above mentioned PR. If this is desired on Social we can have a more generic effort to port editor improvements


Retire vagrant-kvm?

I'm thinking of retiring this project for the following reasons:

I have less and less time to work on the project and have achieved my personal objectives with it.
There is another plugin, https://github.com/pradels/vagrant-libvirt/, that is a lot more widely used and vagrant-kvm doesn't have any compelling features compared to it any more.
vagrant-libvirt is being packaged with Vagrant for Fedora, which is my main platform.
Vagrant isn't essential to my workflow anymore (yes, that's because of Docker).

I think all users should switch to vagrant-libvirt, except if there's anything it's missing, I'd be happy to contribute any feature from vagrant-kvm to vagrant-libvirt if that's the case.
Of course if anyone is interested in maintaining their own fork, I'll support it being the official version.
Happy to hear any comments.

Same issue with docker :)

At lease makes sense to put a big disclaimer with all that information in the README, so people can figure out the state of the proyect faster.

I think one major missing feature from libvirt is the ability to specify a 9p mount as mapped rather than passthrough.
See https://github.com/pradels/vagrant-libvirt/issues/274
Otherwise, you are probably in the best position to know if libvert is the better alternative.

I updated the README to direct people to vagrant-libvirt. Not sure how to retire the rubygem though.

Probably you can create an after install message in the gemspec and put a deprecation warning into the gem descriptin as well.
An extreme way to do things will be to yank all the versions.


fix: Logo update and license change

Summary
This pull request updates the project's logo and changes the license from AGPL to MIT.
Details

Logo Update: The logo image in the README.md file has been updated from kaizen_icon.png to logo.png.
License Change: The license badge in the README.md file has been updated from 'License: AGPL' to 'License: MIT'. This change allows for more permissive use and distribution of the project.

✨ Generated with love by Kaizen ❤

Original Description
### Summary
This pull request updates the project's logo and changes the license from AGPL to MIT.
Details

The logo image has been updated from kaizen_icon.png to logo.png.
The license badge in the README.md file has been updated from 'License: AGPL' to 'License: MIT'.
This change in license from AGPL to MIT allows for more permissive use and distribution of the project.

✨ Generated with love by Kaizen ❤

Original Description
None

!review

!review

!review


Filter doesnt't work properly

Hello guys, awesome work first of all!
I use PostItAll on my site, but I have 1 page that shows the participants to our courses, we use the same page for all courses, we just attach to the page address a course ID number to show the different courses, like
www.mysite.com/my_students.php?courseID=5
Now, I need the post-its to be course relevant, I mean, I have different post-its for different courses.
I configured the global option "Filter" to "all" but I still get ALL the post-its of ALL courses...
filter: 'all',     //Options: domain, page, all
I also tryed with 'page' and 'domain' same result.
I tryed adding the courseID number to the prefix
prefix: '#PIApostit_',  // Id note prefix
but I still get ALL the post-its of ALL courses...
May be you can help me with an idea on how to generate the post-it and load them according to different courses.
I guess this feature will be appreciated from a lot of people.
Thanks :-)

Hi accorinti, I'm so sorry but I think you will need to create your custom endpoint for your notes (I noticed you use php on the backend), and cover these restrictions on the server side. The JavaScript endpoint developed within this plugin do not restrict anything apart from the domain.
Regards,
Javi Filella


Ugly scrollbar if too many tabs

If there's too many tabs in the tab bar, it becomes scrollable and at least with Arch Linux/Gnome 3 a scrollbar is displayed.

PR is one possible fix, maybe one could restyle the scrollbar instead, so it would be more obvious that you can scroll here and yet visually appealing. Dunnå.

maybe one could restyle the scrollbar instead, so it would be more obvious that you can scroll here and yet visually appealing

That's probably a better solution.

I played around a bit with the styling and came up with this but it still has (at least) two problems:

You can't really see it on pages with dark (or even black) tab bars, e.g. GitHub
On pages like DDG, where the tab bar is the same color as the page background at the top border, it looks a bit crappy.

Do you have any suggestions?
.tab-group #tabs::-webkit-scrollbar {
	height: 0.2em;
}
.tab-group #tabs::-webkit-scrollbar-track {
	display: none;
}
.tab-group #tabs::-webkit-scrollbar-thumb {
	background-color: rgba(0,0,0,0.3);
}

I like the design in general, but it seems like it has a lot of bugs compared to the native scrollbar.
Two more issues:

The scrollbar affects the height of the tab, instead of floating on top. This leads to bugs like below, where there is a gap between the tab background and the bottom border:

The vertical scrollbar in expanded tab mode is broken.

For pages with dark backgrounds, a dark-theme class is added to the body, so you could change the scrollbar color to white for those pages.
I'll try to think of a solution to the 2nd issue over the next few days.

@PalmerAL We already have the tab management code, so maybe something there. Could also revert to favicon when the tabs get too small to display text.

@PalmerAL I've updated #76. This should fix the dark-theme and the gap issue, and since the expanded tab view has been replaced your second issue is solved as well.


Allow dates and times to be added to file names in .testcaferc.json

Are you requesting a feature or reporting a bug?
Requesting a feature.
What is your Test Scenario?
In the .testcaferc.json file, I want to be able to append a date to the reporter.output object.
What is the Current behavior?
Currently, we cannot append a date-time to the output value.
What is the Expected behavior?
In the reporter.output, I want to be able to give a path and file name, including a formatted date, like "reporter": { "output": "artifacts/reports/report${DATE}${TIME}.html"}
How would you reproduce the current behavior (if this is a bug)?
In the .testcaferc.json file, inside the reporter object, for the output child, try to name the file with ${DATE} and or ${TIME} in the string.
Provide the test code and the tested page URL (if applicable)

Your website URL (or attach your complete example):
Your complete test code (or attach your test files)
{
    "browsers": "chrome",
    "src": "Scripts",

    "reporter": {
        "name": "html",
        "output": "./Artifacts/Reports/report${DATE}_${TIME}.html"
    },

    "screenshotPath": "./Artifacts/Screenshots/",
    "screenshotPathPattern": "${DATE}_${TIME}/test-${TEST_INDEX}/${USERAGENT}/${FILE_INDEX}.png",
    "takeScreenshotsOnFails": true,

    "videoPath": "./Artifacts/Videos/",

    "videoOptions": {
        "failedOnly": true,
        "pathPattern": "${TEST_INDEX}/${USERAGENT}/${FILE_INDEX}.mp4"
    },

    "videoEncodingOptions": {
        "r": 20,
        "aspect": "16:9"
    },

    "quarantineMode": true,
    "skipUncaughtErrors": false
}

Your Environment details:

testcafe version:        1.1.4
node.js version:         10.13.0
command-line arguments:
browser name and version:
platform and version:
other: Maybe a "reportPathPattern" child in the reporter object would work?
workaround: Currently, I have to run a powershell script that runs my testcafe project, then renames the report.html file after the execution of my project. It would be better if testcafe was able to do this all on its own by allowing us to append dates to the file name without the need of an external powershell script.

Thank you for sharing your idea with us. We will discuss it and consider implementing it in one of our future product updates.

I would really like this feature. When you run your tests multiple times, it's unfortunate the the report file is overwritten each time. You end up with many Screenshot/Video capture folders, one per each run, but the report output is a single file that only represents the most recent test run.

@parekhkb
Hello,
Thank you for your interest in this feature. At present, I cannot give you any estimates on when the feature will be implemented. Since it is not in progress, your PR is welcome.


Username validation

@lulf lgtm! just question username with underscore is restricted too?

@kornys For the .metadata.name underscores are not allowed. However, I think we should allow it for .spec.username. I will raise another PR to fix that.


Fixes a racy connection finalizer issue exposed by testShutdownServer

It turns out occassionally ServerTerminationIntegrationTest's testShutdownServert would result in a segfault inside of the finalizer for the connection. I'm pretty sure the issue was that a retained count needs to be taken for the WeakConnection instance (what we don't want to do is add a retain count to the connection itself).

@amomchilov I basically tested this by just manually running the integration test over and over again. Before it was segfaulting roughly 20% of the time, after this change I've yet to see a segfault. That's not entirely satisfying, but seems strictly better than not addressing this issue.


how to set timeout by tcp connect!

Version: libuv-v1.12.0
Platform:linux
I can't Find APi to set this timeout! default is very long time!

Please post questions to https://github.com/libuv/help, that's what it's for.


SiFive Unleashed support

Result from hackethon in Portland
This pull-request starts of with some generic clean-ups, then adding SiFive Unleashed board support with a bundled initramfs image in the Linux kernel image and that is what is the bbl.bin should contain and finishes of with some more clean-ups/fixes. Hopefully it is still manageable to review.
I have tested that the qemuriscv64 still boots after these changes. I have not been able to test if the bbl.bin actually boots (never got to test it properly while I had access to board) but the commands look alright to me.
Please review when you got time and test if you can.
@kraj @mfischer

thansk @mirzak however, as I mentioned in past this layer has moved to https://github.com/riscv/meta-riscv and there has been some updates pushed there. Can you rebase this pull against the new layer?

I seem to have totally missed that information. Saw the email you sent out now. Will rebase on on top of the new location and submit a new pull-request

lets call it
freedom-u500.conf

Actually the SoC is Freedom U540? And there will be multiple boards using that SoC I assume which will make it hard to differential if we name the machine after the SoC.
How about:
u540-unleashed.conf

Yes, sounds good

Closing this, new pull-request open on new location


backends: Do not import 'backends' package in s3 test

This caused the following command to fail:
go test -v ./backends

Nice catch, this was missed as make test passes (it overrides the GOPATH).
To this end, how do you feel about removing the overriding of GOPATH in the Makefile? This would revoke the ability to operate the project outside of GOPATH. IMO it will simplify things, avoid bugs like this, and is pretty standard wrt Go.