RuntimeError: The size of tensor a (32) must match the size of tensor b (3) at non-singleton dimension 1

Run FedEM
==> Clients initialization..
===> Building data iterators..
Traceback (most recent call last):
File "run_experiment.py", line 244, in
run_experiment(args)
File "run_experiment.py", line 142, in run_experiment
clients = init_clients(args_,
File "run_experiment.py", line 31, in init_clients
get_loaders(
File "/mnt/traffic1/data/jxt/Personalized_Federated_Learning/FedGMM/utils/utils.py", line 375, in get_loaders
inputs, targets = get_cifar10(dist_shift, dp)
File "/mnt/traffic1/data/jxt/Personalized_Federated_Learning/FedGMM/datasets.py", line 1170, in get_cifar10
cifar10_data = d_norm(cifar10_data)
File "/mnt/traffic/home/jxt/miniconda3/envs/FedGMM/lib/python3.8/site-packages/torch/nn/modules/module.py", line 889, in call_impl
result = self.forward(*input, **kwargs)
File "/mnt/traffic/home/jxt/miniconda3/envs/FedGMM/lib/python3.8/site-packages/torchvision/transforms/transforms.py", line 221, in forward
return F.normalize(tensor, self.mean, self.std, self.inplace)
File "/mnt/traffic/home/jxt/miniconda3/envs/FedGMM/lib/python3.8/site-packages/torchvision/transforms/functional.py", line 336, in normalize
tensor.sub(mean).div_(std)
RuntimeError: The size of tensor a (32) must match the size of tensor b (3) at non-singleton dimension 1
I train on cifar10 dataset and have this problem.

I notice that do_norm() is new function in datasets.py, which is different from FedEM code.

Looking forward to it!
Also, I have a new question: how to get "data/cifar10/all_data/PCA.pkl"?

Sorry for the late reply, I will upload them this week. Essentially these PCA files are extracted after perturbing P(X) and P(Y|X).

Hi, it seems it is not necessary to have the normalization layer. You can probably just comment it out, if the problem persists, please let me know! It may be due to the dimension manipulation.  For the PCA, you can actually get these PCA.pkl files by uncommenting 42-72 lines to create these projections.

I will update the descriptions and code shortly after.


Cannot set columns for Mars DataFrame

How to rename a column？pd.columns = ['a','b','c'], error

Oh, it's not supported in Mars DataFrame yet, I will support it ASAP.

Oh, it's not supported in Mars DataFrame yet, we will implement it ASAP.

The foolish idea is as follows，What is the impact on Performance？？  Thanks
data = data.to_pandas()
data.columns = ['a','b','c','d']
data= pd.DataFrame(data)

Oh, it's not supported in Mars DataFrame yet, we will implement it ASAP.

The foolish idea is as follows，What is the impact on Performance？？ Thanks
data = data.to_pandas()
data.columns = ['a','b','c','d']
data= pd.DataFrame(data)

I think the performance could be terrible, because the data will be collected together.
This feature can be easily achieved for Mars, we will finish it in a few days, and you would be able to set columns in the next release 0.4.2 around Jun 24.

v0.4.2 has been released. Fixes about this issue have been included.
Try to upgrade via:
pip install pymars==0.4.2


the README could be more helpful

The usefulness/helpfulness of the README would be increased "100%" (imo) if a sample implementation (no matter how simplified) of the "GenerateClosedXMLWorkbook()" method was included.

Good idea. Please submit the pull request.

Please more details in Read.me

@ice19942335 Don't expect me to do everything. You want something changed...? Then put in the effort and submit a pull request.


Transform copy/paste buttons

Pressing the C (Copy) button and the P next to the rotation part of a transforms does not work.
Ability to copy/paste the whole position or scale also does not work.

Fixed in branch ftr/transform-editor-fixes. Will be merged in next release


[GUI-v2] The devices are not plotted on the map when at least one of them is removed

I'm submitting a ...

[x] bug report
[ ] feature request
[ ] support request

Do you want to request a feature or report a bug?
bug

What is the current behavior?
The devices are not plotted on the map when at least one of them is removed

If the current behavior is a bug, please provide the steps to reproduce and if possible a minimal demo of the problem

registered devices

gui-v1 map

gui-v2 map configuration

gui-v2 map

removed device bus-4;  gui-v2 map is not updated

refresh page; map is centered on the 0,0 coordinate.

zoom in on the map; the other devices are not shown

gui-v1 map

What is the expected behavior?

What is the motivation / use case for changing the behavior?

Please tell us about your environment:

Version: 0.6.0
Environment: kubernetes, docker-compose
Operating system: Ubuntu 18.04

Other information (e.g. detailed explanation, stacktraces, related issues, suggestions how to fix, links for us to have context, eg. stackoverflow, gitter, etc)

4 devices with geo attributes were selected:

Camera and linha_1 with data
linha_2 and linha_3 with no data

Only devices with data are plotted

Camera device has been removed in GUI-v1

If this device is also removed from the widget configuration in GUI-v2, the map displays the correct information.


how to get landmarks using Holistic tracking solution on Android?

System information (Please provide as much relevant information as possible)
Have I written custom code (as opposed to using a stock example script provided in Mediapipe): Yes
OS Platform and Distribution (e.g., Linux Ubuntu 16.04, Android 11, iOS 14.4): Android 11
MediaPipe version: latest git clone (v0.8.9)
Bazel version: 4.2.1
Solution (e.g. FaceMesh, Pose, Holistic): Pose
Programming Language and version ( e.g. C++, Python, Java): Java and Kotlin
Hi.
How to get landmarks using Holistic tracking solution on Android?
I tryed this code.
  processor.addPacketCallback(                "right_hand_landmarks",                 (packet) -> {                     List<LandmarkProto.NormalizedLandmarkList> l =                             PacketGetter.getProtoVector(packet, LandmarkProto.NormalizedLandmarkList.parser());                 });
but failed.
I think  output Stream for "right_hand_landmarks" doesnt't exist.
I'm working on this example code.
https://github.com/shadow111/mediapipe-holistic-tracking-aar-example.
Please let me know how to get landmarks on Android using holistic.
I want to get landmarks for right hand, left hand, face, pose.
Thanks.

Please answer~

Hi @chuoling,
Could you please share the some pointers here.

The AAR example https://github.com/shadow111/mediapipe-holistic-tracking-aar-example you use runs the holistic_tracking_gpu.pbtxt graph underneath, which only has a single output stream "output_video". You'll want to add, e.g., "right_hand_landmarks", as additional graph output streams, similar to how it's done in https://github.com/google/mediapipe/blob/master/mediapipe/graphs/hand_tracking/hand_tracking_mobile.pbtxt#L18 (which is then used in https://github.com/jiuqiant/mediapipe_multi_hands_tracking_aar_example/blob/master/app/src/main/java/com/example/mediapipemultihandstrackingapp/MainActivity.java#L116).

The AAR example https://github.com/shadow111/mediapipe-holistic-tracking-aar-example you use runs the holistic_tracking_gpu.pbtxt graph underneath, which only has a single output stream "output_video"

@chuoling I wonder how did you know that that repo used the holistic_tracking_gpu.pbtxt graph underneath? i searched the repo and found no .pbtxt file


Set every test that depends on fleaky features of Fast DDS as fleaky

Signed-off-by: jparisu<EMAIL_ADDRESS>

Close in favor of #312


Added color support to other hairstyles

I've added color support to the following hairstyles.

Mohawk
Normal
Thick

Note with adding color support to the Thick hairstyle, I moved the hair upwards slightly to hide the stroke surrounding the person.

@spencerversteeg Thank you 🚀
I will merge this first and do a small modification this weekend, I think the color for these hairstyles is usually black or sth.
So I'm gonna add a usual option to keep it more practical in random generating


ARRAY_LENGTH fails with invalid type: BLOB

One of the example queries for gitbase-web fails for v0.17.0-rc.4. It works fine for 0.16.
To reproduce it, this query is enough:
SELECT files.repository_id, files.file_path,
 ARRAY_LENGTH(UAST(
   files.blob_content,
   'Go',
   '//*'
 )) as count
FROM files
WHERE
LANGUAGE(files.file_path,files.blob_content) = 'Go'
LIMIT 4

ERROR 1105 (HY000): unknown error: invalid type: BLOB
For reference, the complete query we have in gitbase-web is:
 /* Number of funtions per file for Golang at HEAD */
SELECT files.repository_id, files.file_path,
 ARRAY_LENGTH(UAST(
   files.blob_content,
   LANGUAGE(files.file_path, files.blob_content),
   '//*[@roleFunction and @roleDeclaration]'
 )) as functions
FROM files
NATURAL JOIN refs
WHERE
LANGUAGE(files.file_path,files.blob_content) = 'Go'
AND refs.ref_name = 'HEAD'

UAST Function changed the output format. Before it was JSON, now is a BLOB. Array length only accepts blob types. Also, the XPath string is not valid anymore, because by default the bblfsh mode used is semantic So that query is no longer valid.


Update LOCALIZATION_CONTRIBUTORS

Summary
Details and comments

 Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

This PR is on hold because we haven't opened Russian due to the lack of volunteers.

So why should we wait? Let's start now and people will come!

 All committers have signed the CLA.

Can you please move this PR here: https://github.com/Qiskit/qiskit-translations

Done https://github.com/Qiskit/qiskit-translations/pull/17


Chalk 1.x definitions

This was adapted from https://github.com/DefinitelyTyped/DefinitelyTyped/blob/master/chalk/chalk.d.ts

Awesome to see PRs from a facebook newcomer 👍  🎉

Updated

Looks nice for me - the failed tests are due to the .28 release - already on it.
Nothing keeps us from merging this.


Icons in spheres demo

Just a draft PR since this is nowhere near ready but might be a decent starting point.
Would potentially solve https://github.com/reaviz/reagraph/issues/41
Allows for showing icons within the spheres:

By chopping the spheres in half but telling them to look at the camera (this is what they look like when they're not looking at the camera):

Some issues with the icons flipping around when the graph is viewed flat:

Things that would need to be done:

The icon src would need to come from somewhere (property on the node?), I've not really looked into the Icon rendering options so there might be clashes there
Fix for whatever's making the icons lie down when viewed from the bottom (probably just some sort of world space / camera space rotation that needs applied at the same time as the lookAt)
Not sure how well it'd handle the src changing, but it'd probably be fine.

Very nice! let me know when its ready!

@amcdnl Think this should be ready once I've rebased

Rather than trying to put props in to say which type of icon the graph uses (only icon or sphere) I pulled renderNode out as a render prop, so the user can supply Icon or Sphere or SphereWithIcon or their own custom 3d elements
As part of the above I moved some of the event handlers from the nodes themselves to the parent group - doesn't seem like I've broken anything but I could be missing something
I've not put a fix in for the flipping icons since it doesn't happen in any of the 2D camera modes & only effects the 3D ones at the extremes (and it corrects itself once returned to a more normal view)
This'll probably be a breaking change since the behaviour of node.icon has changed to no longer be enough to use the icons
I've tried to separate the things which should be returned from the renderNodes prop from the other symbols but it could be somewhere else makes more sense

@neil-morrison44 - FYI haven't forgot about this - I'm at a conference this week but will circle back next week.

I'm away for a bit so it'll probably be about a week before I can take a look at this again

No problem @neil-morrison44

@amcdnl That's this rebased, the renderNode prop moved to default props (left it as renderNode though) & package-lock.json removed.
I think the rebase went alright (there weren't too many conflicts), but you might want to check things that've been added since the previous rebase are still present & correct


Getting "window is not defined" when using custom history on SSR application

I'm instantiating a new withUrlState component using a custom history inside the config parameter, as described on the changelog.
The application has a NextJS SSR implementation, though not supporting browser components. When the method executes, it throws the following:
ReferenceError: window is not defined
    at Object.<anonymous> (/node_modules/with-url-state/dist/withUrlState.js:24:15)
    at Module._compile (module.js:653:30)
    at Object.Module._extensions..js (module.js:664:10)
    at Module.load (module.js:566:32)
    at tryModuleLoad (module.js:506:12)
    at Function.Module._load (module.js:498:3)
    at Module.require (module.js:597:17)
    at require (internal/module.js:11:18)
    at Object.with-url-state (/.next/dist/bundles/pages/_error.js:53158:18)

As I checked, apparently this error is being thrown because the html5HistoryAdapter location property export calls window.location independently of the config object passed on the constructor:
exports.html5HistoryAdapter = {
    listen: function (listener) {
        window.addEventListener('popstate', listener);
        return function () { return window.removeEventListener('popstate', listener); };
    },
    location: window.location,
    push: function (_a) {
        var search = _a.search;
        window.history.pushState(window.history.state, document.title, search);
        window.dispatchEvent(new window.Event('popstate'));
    },
    replace: function (_a) {
        var search = _a.search;
        window.history.replaceState(window.history.state, document.title, search);
        window.dispatchEvent(new window.Event('popstate'));
    },
};

Could you, please, take a look at this?

Looks like this is due to the location property, its the only call not wrapped in a function.
I think the simplest thing to do would be to change:
export type HistoryAdapter = {
  location: ...
  ...
}

to
export type HistoryAdapter = () => {
  location: ...
  ...
}

And adding a few function calls into the implementation where necessary.


Error retrieving data in the dashboard but working fine in the Analytics Blade.

So, I have a bunch of messages that will give me the Time spent on service bus.
Example, I log a trace like this: SBTime 1031.6208 (this is in milliseconds).
And then I'm running this query:
let timeGrain=15m;
traces
| where message startswith "SBTime"
| parse message with "SBTime " duration
| summarize max(todouble(duration)/1000) by bin(timestamp, timeGrain)
| render timechart

In the analytics blade all works good, then if I add it to a dashboard, in the dashboard it will show "Error retrieving data", if I click in the Analytics Blade button it will open and show the information fine, and one odd thing is, if I click in the edit query button and click on test without changing anything in the data, I get this message: Status: Editing query dimensions isn't supported yet
I reckon this may be related to my calculation in the summarize option but I'm not sure, can I get some help here?

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 3046534c-4ce4-d430-3c9d-363e210fc2eb
Version Independent ID: ce65332c-160a-1df9-2560-cd629b285ee9
Content: Create custom dashboards in Azure Application Insights
Content Source: articles/azure-monitor/learn/tutorial-app-dashboards.md
Service: azure-monitor
Sub-service: application-insights
GitHub Login: @lgayhardt
Microsoft Alias: lagayhar

@Merurino, Thanks for the question! We are taking a look into this and will get back to you soon.

@Merurino Can you try pinning the graph to a brand new dashboard and see if that resolves the issue? While there are some limitations on what you can edit, you should not receive this message immediately after opening the editor.
If this works, please let me know. If not, please open a ticket with support or send me an email at AzCommunity (at) microsoft.com with your subscription ID and a link to this thread so I can arrange for a one time support ticket for you.

Oh, thanks for the recommendation. I've created this guy using ARM script and changed the query from avg() to max() and forgot to fix the yAxis name from avg_ to max_ . That was it!
One question though, I've seen that now when I add a new query to my dashboards instead of having the DashboardId populated in each "box's" DashboardId field, we now have a isOptional = true.
So from this:
{
   "name": "DashboardId",
   "value": "/subscriptions/.../resourceGroups/.../providers/Microsoft.Portal/dashboards/dashboard-name"
}

We now have this:
{
  "name": "DashboardId",
  "isOptional": true
}

I searched in the documentation but couldn't find anything specifically about the isOptional here, is there any link you can give me that talk about it, or any more appropriate place where I can ask this?

This repository is focused on the documentation. Product questions are more suited to MSDN or Stack Overflow. I'd suggest posting on the portal forum for MSDN: https://social.msdn.microsoft.com/Forums/en-US/home?forum=windowsazuremanagement&filter=alltypes&sort=lastpostdesc


Add Feedback Fish across whole docs site

What kind of changes does this PR include?

Changes to the docs site code

Description

Add the Feedback Fish button to the right sidebar across the whole site
Make the “Give us feedback” label translatable

Example of location:

Worth noting that this sidebar is not visible at narrower viewport widths. We don’t show any of the “extra” (non-ToC) stuff on smaller screens and the approach I took for small screens in the tutorial isn’t an option because that space is used by the current heading text next to “On this page”.
My take is that gathering feedback outside of the tutorial is slightly less crucial, so maybe only showing on wider screens is OK and NWTWWHB? Otherwise, we may need to spend more time thinking. One option could be to move the entire “extra” sidebar stuff to the bottom of each page.

I can get behind this! One thing to note is that in "tablet" (medium screen view) we do import the "Community" section over into the left sidebar. So in that mode we could also consider moving the feedback widget. We don't show the "contribute" items in that view, like Edit this page, because that might be difficult to do at that screen size anyway. But simply leaving feedback I think could be an option.
But, non-blocking! I'd be happy to merge this in as-is!

Yep I think hiding it on mobile makes sense, we can always add that late.  I did try a quick super hacky DOM reorder and the feedback modal looks good on mobile so the question should just be if it makes sense on mobile and where to put the button 👍

Thanks for the reviews! I also noticed that due to our pattern of duplicating content for different page areas, on tutorial pages the Feedback Fish resources seem to get loaded twice:

Don’t think that should mean double downloading or even double parsing, but I guess will mean they run twice.
I like Sarah’s suggestion of adding the widget to the left sidebar, so will open a follow-up PR for that that also tweaks the feedback component to avoid the multiple <script> tags.


Add GCS support

Done in https://github.com/HobOps/terraform-google-project-template/releases/tag/v0.1.9


It doesn't work with vimplug (sadly)

I've installed the plugin with vimplug and made the setup

The setup seems to be successful, because the command is avaliable on neovim

But when I run this, nothing happens
P.s.:
I have markdown parser installed on treesitter

Huh, that is interesting. I don't have any familiarity with vim plug, but hopefully we can get it working.
Can you run the checkhealth command 'checkhealth render-markdown', see if that has any information.
Also which version of Neovim are you running and on what OS?

@MeanderingProgrammer This erros occurs

Ah, damn, I thought I still had compatibility with 0.9.5, but looks like list_contains was added in 0.10.0.
I pushed a small change that should resolve the health check failing. Can you update the plugin and run it again, just as a sanity check.
Maybe the reason this isn't working is I'm using some other API that's not compatible with 0.9.5. I haven't found a good way to determine which APIs existed for which versions of Neovim. However in that case the error should be printed out and pretty obvious, which doesn't seem to be happening right?

I've updated, and the checkhealt seems ok, but it's still not working

I've also downloaded the neovim 0.10.0 binary and used it, but still not worked

Oh, sorry about that, didn't mean for you to need to update the version of neovim you use, but appreciate the thoroughness!
Lets see if the logs can help.
Can you enable debug logs by updating the plugin config to:
require('render-markdown').setup({ log_level = 'debug' })

Then create a new markdown file with the following content, just so I can compare my output to yours:
# Heading

- Item
  - Nested

> [!NOTE]
> A note

- [ ] Unchecked
- [x] Checked

Open the file, the plugin will try to render it, then close the file.
Then copy the output of the log file which will most likely be located at ~/.local/state/nvim/render-markdown.log, and paste the results here.

I've set the log_level to debug, then opened the file with this content. But it didn't seem to create a log file

I put a print on the toggle function, and it seems to be called

It early returns at this clear_valid function

Mistery solved! As I use vimwiki, my markdown files are for some reason being recognized as vimwiki files.

If I add the vimwiki option at filetypes, it crashes :(

if I remove vimwiki

Set the filetype to markdown with autocmd seems the best workaround. I continue with vimwiki working and the markdown plugin works too. The only issue is that the autocmd does not works every time

Ah that makes sense, parsers are picked using the vim.treesitter apis and vimwiki both sets the filetype and doesn't have an associated parser, so we run into this error.
Instead of the autocommands another options would be to do the following two things (at least I think this would work lmk if it does!):

Add vimwiki to the file_types this plugin runs on:

require('render-markdown').setup({
  file_types = { 'markdown', 'vimwiki' },
})

Register markdown as the parser for vimwiki files:

vim.treesitter.language.register('markdown', 'vimwiki')

It worked pretty well. Thanks
Maybe it's good to put a Notice to vimwiki users on readme

Done: https://github.com/MeanderingProgrammer/markdown.nvim?tab=readme-ov-file#for-vimwiki-users
Thanks reaching out!


[MB-2417] Copy changes - SM Create profile / Backup mailing address page

Description
Continued copy changes on SM create profile; this change is on the Backup mailing address page. Please see screenshots below.
Setup
make server_run
make client_run

Navigate to http://milmovelocal:3000/ and login (I used<EMAIL_ADDRESS>continue through Create your profile > Name > Your contact info > Current duty station > Current residence address pages to the heading Backup mailing address; view the copy below that heading
Code Review Verification Steps

[ ] There are no aXe warnings for UI.
[ ] This works in Supported Browsers and their phone views (Chrome, Firefox, IE, Edge).
[ ] Tested in the Experimental environment (for changes to containers, app startup, or connection to data stores)
[ ] User facing changes have been reviewed by design.
[ ] Request review from a member of a different team.
[ ] Have the Jira acceptance criteria been met for this change?

References

Jira story for this change

Screenshots
Fixed copy

Before copy change

Warnings

:warning:
This PR does not include changes to unit tests, even though it affects app code.

  Generated by :no_entry_sign: dangerJS against 71becf2b70c6fe8e3d28f61e1f2ba898673ff974


Fix SummaryWritter error and similar deprecated warnings

TF1.0 advises to use FileWriter and similarly pathed functions to replace deprecated ones.
All changes here are related to fixing deprecated errors and warnings.

Official migration to TensorFlow 1.0 is being discussed in #241. Since these changes are compatible with 0.12 though (Travis hasn't complained), I'll go ahead and merge them.


ES做存储时存在权限控制，那么配置文件中怎么配置用户名和密码

Please answer these questions before submitting your issue.

Why do you submit this issue?
[1 ] Question or discussion
[ ] Bug
[ ] Requirement
[ ] Feature or performance improvement

Question

What do you want to know?
ES有权限控制，application.yml中怎么加用户名密码

Bug

Which version of SkyWalking, OS and JRE?
5.0GA
Which company or project?
SS
What happen?
If possible, provide a way for reproducing the error. e.g. demo application, component version.
XX

Requirement or improvement

Please describe about your requirements or improvement suggestions.

See #1944

English only.


@mzikherman - Artwork filter components

Doesn't do much but starting to wire up the components needed for a basic artwork filter component, starting with the dropdowns.

Added a basic demo of selecting an item for the dropdown (still need to represent that state in the dropdown button), and an extremely basic TotalCount component.

Looking nice thus far! 👌

So the Dropdown component is pretty much ready to go, I think it's probably good to merge, before this PR gets too large.

@l2succes @yuki24 @alloy are you guys married to having the linter and tests run on pre-commit? I find it kind of annoying (not being able to commit if my code doesn't pass lint).

Ok I'm merging, looks awesome @broskoski

@broskoski I honestly think it helps keep a uniform codestyle throughout the project. Personally, I know i'd forget to fix them without it. Since it's gonna run on CI anyway might as well catch the problems before pushing to a remote branch and waiting for the build to fail.
For most linter errors, you can just run yarn lint -- --fix and it will fix them automagically.
 I suppose I'm more accustomed to getting code in and committed and then running the linters and tests.

@broskoski Oh word, yeah I mean we could move to a pre-push hook instead, that way it'll just run the linter and tests before pushing upstream.
There's a node package called pre-push that works the same way as the pre-commit package we're currently using. You can swap them if you want.

Yeah I agree on moving to pre-push 👍


This repository has a code

The Dockerfile in repository infact has a line of code that says
FROM scratch
The issue with this is it can lead to various issues, We should set an example of deleting code may be delete Dockerfile altogether.

I'm not sure if we need a dockerfile because this code will run on any system, so I agree. A docker file just creates more room for bugs.

IMHO as long as the Dockerfile contains no code, there is no problem having it in the repository. You may comment the offending code with the CIAL tag, this may also be regarded as code, though.


Upgrade coil barrel

[x] Make a fancier model
[ ] Texture it?
[x] Make fancier animation
[x] Rewire gun events so burst fire is possible
[x] Fix bugs caused by rewiring

[x] Fix compilation errors from merge with culled gun
[x] Fix bullet barrel not firing???
[x] Move when targeting happens (target is set in PlayerManager and used in GunController)
[x] Prevent third-person gun firing independently from first-person gun (???)

[ ] Add battery indicator (optional)
[ ] Add effect from being shot by the barrel that makes player spazz out

WIP blenderin':

Closes #283 and possibly #284

Oh noes :(
Will squash the buggerinoes

Fixed & ready for rereview

I also notice displayGun no longer recoils, it was a bit subtle before, but I don't think we should remove it

I do think we should remove it from most guns but I'll remove it from this PR at least :))))))
Perhaps we could shake the screen a lil instead?

Some new bugs that must be adressed

o no

* Lawnmower is broken (can't fire due to lacking animator)

Fixed. Lots of shenanigans related to ammo deduction and fire rate.

* Might be a local thing from my end, but cannonBarrel projectiles doesn't render

That's all on your end. Open the VFX graph again and save it, after that it should work.

Also: Sodie popper + Coil = infinite ammo, but sodie popper needs some rework (as it already has problems with other existing augments) so that can a be it's own PR.

Yeah we need to deal with the recoil tween later hahahaahha

recoil animation makes DDR body disappear from the screen with coil barrel... gotta fix somehow


Add default browser support

Description
This PR adds support for fetching history and bookmarks from default browsers.
Default browser support Tracking

Linux
Mac
Windows

Chrome
:heavy_check_mark:
:black_square_button:
:heavy_check_mark:

firefox
:heavy_check_mark:
:black_square_button:
:heavy_check_mark:

Chromium
:black_square_button:
:black_square_button:
🔲

Edge
:black_square_button:
:black_square_button:
:heavy_check_mark:

Brave
:black_square_button:
:black_square_button:
:heavy_check_mark:

Opera
:black_square_button:
:black_square_button:
:heavy_check_mark:

OperaGX
:black_square_button:
:black_square_button:
:heavy_check_mark:

Safari
:heavy_minus_sign:
:black_square_button:
:heavy_minus_sign:

Fixes #96
Type of change
Please delete options that are not relevant.

[x] New feature (non-breaking change which adds functionality)
[x] This change requires a documentation update

Checklist:

[x] I have read the contribution guidelines and followed it as far as possible.
[x] I have performed a self-review of my own code (if applicable)
[x] I have commented my code, particularly in hard-to-understand areas (if applicable)
[ ] I have made corresponding changes to the documentation (if applicable)
[x] My changes generate no new warnings
[x] I have enabled the pre-commit hook and it's not detecting any issue.
[x] Any dependent and pending changes have been merged and published

Codecov Report

Merging #123 (6299c45) into master (a10cfbd) will decrease coverage by 1.17%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##           master     #123      +/-   ##
==========================================
- Coverage   87.83%   86.66%   -1.18%
==========================================
  Files           3        3
  Lines         296      300       +4
  Branches       51       53       +2
==========================================
  Hits          260      260
- Misses         25       28       +3
- Partials       11       12       +1

Flag
Coverage Δ

unittests
86.66% <0.00%> (-1.18%)
:arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files
Coverage Δ

browser_history/cli.py
87.03% <0.00%> (-6.97%)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a10cfbd...6299c45. Read the comment docs.

Codecov Report

Merging #123 (6299c45) into master (a10cfbd) will decrease coverage by 1.17%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##           master     #123      +/-   ##
==========================================
- Coverage   87.83%   86.66%   -1.18%
==========================================
  Files           3        3
  Lines         296      300       +4
  Branches       51       53       +2
==========================================
  Hits          260      260
- Misses         25       28       +3
- Partials       11       12       +1

Flag
Coverage Δ

unittests
86.66% <0.00%> (-1.18%)
:arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files
Coverage Δ

browser_history/cli.py
87.03% <0.00%> (-6.97%)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a10cfbd...6299c45. Read the comment docs.

@Samyak2 I will not be able to add support for mac OS since I have no access to the platform 😅

@Samyak2 I will not be able to add support for mac OS since I have no access to the platform 😅

Also, will it be possible to add some basic tests for this?

Also, will it be possible to add some basic tests for this?

Also, will it be possible to add some basic tests for this?

It will be tough but I guess we can work it out

Also, will it be possible to add some basic tests for this?

It will be tough but I guess we can work it out

I don't know why the tests are failing in ubuntu and I have wrapped the winreg import in a platform check

I don't know why the tests are failing in ubuntu and I have wrapped the winreg import in a platform check

It will be tough but I guess we can work it out

I was thinking of using pytest monkeypatching to set the return values of webbrowser.get() to a known value and test that it returns the correct browser. This is just to ensure that the implementation does not break.

It will be tough but I guess we can work it out

I was thinking of using pytest monkeypatching to set the return values of webbrowser.get() to a known value and test that it returns the correct browser. This is just to ensure that the implementation does not break.

I don't know why the tests are failing in ubuntu and I have wrapped the winreg import in a platform check

I'll see if it works on my linux system

I don't know why the tests are failing in ubuntu and I have wrapped the winreg import in a platform check

I'll see if it works on my linux system

The issue was due to pylint, adding the following to .pylintrc fixes it:
ignored-modules=winreg

The issue was due to pylint, adding the following to .pylintrc fixes it:
ignored-modules=winreg

Or we can add a # pylint: disable=import-error to that import. I'm not sure which solution is better (the previous solution seems like it ignores the entire module, while this only disables the import error). What do you think?

Or we can add a # pylint: disable=import-error to that import. I'm not sure which solution is better (the previous solution seems like it ignores the entire module, while this only disables the import error). What do you think?

Also, I have another question. In the issue you said that it was a jungle inside the windows registry :laughing:
How did you get all the browsers working for windows without mapping out those values?
(sorry for all the spam pings xD)

Also, I have another question. In the issue you said that it was a jungle inside the windows registry :laughing:
How did you get all the browsers working for windows without mapping out those values?
(sorry for all the spam pings xD)

Or we can add a # pylint: disable=import-error to that import. I'm not sure which solution is better (the previous solution seems like it ignores the entire module, while this only disables the import error). What do you think?

If we disable import errors we might not be able to capture genuine issues in future, we can just ignore winreg for now

Also, I have another question. In the issue you said that it was a jungle inside the windows registry 😆
How did you get all the browsers working for windows without mapping out those values?
(sorry for all the spam pings xD)

With the exception of firefox ( which I have handled in a special case ) for the rest we just needed to map the weird alias with no extra processing, since we are not supporting legacy edge and internet explorer (which have inherently sinister names) the rest is easy. Legacy edge doesn't even have a name just random hex values 💀

Or we can add a # pylint: disable=import-error to that import. I'm not sure which solution is better (the previous solution seems like it ignores the entire module, while this only disables the import error). What do you think?

If we disable import errors we might not be able to capture genuine issues in future, we can just ignore winreg for now

Also, I have another question. In the issue you said that it was a jungle inside the windows registry 😆
How did you get all the browsers working for windows without mapping out those values?
(sorry for all the spam pings xD)

With the exception of firefox ( which I have handled in a special case ) for the rest we just needed to map the weird alias with no extra processing, since we are not supporting legacy edge and internet explorer (which have inherently sinister names) the rest is easy. Legacy edge doesn't even have a name just random hex values 💀

@Samyak2 If you have any of these browsers installed could you tell me what names they have when using webbrowser.get() or even when fetching from the registry

@Samyak2 If you have any of these browsers installed could you tell me what names they have when using webbrowser.get() or even when fetching from the registry

If we disable import errors we might not be able to capture genuine issues in future, we can just ignore winreg for now

That line can be added only for the winreg import, that way pylint would ignore only that import.

@Samyak2 If you have any of these browsers installed could you tell me what names they have when using webbrowser.get() or even when fetching from the registry

I don't have access to a windows system atm, I will try those out tomorrow (IST). How do you set the default browser in linux?

If we disable import errors we might not be able to capture genuine issues in future, we can just ignore winreg for now

That line can be added only for the winreg import, that way pylint would ignore only that import.

@Samyak2 If you have any of these browsers installed could you tell me what names they have when using webbrowser.get() or even when fetching from the registry

I don't have access to a windows system atm, I will try those out tomorrow (IST). How do you set the default browser in linux?

On linux:

Firefox: firefox
Chromium: chromium-browser

I don't have other browsers currently, I will try them out tomorrow or day after (IST) if that's ok with you.

On linux:

Firefox: firefox
Chromium: chromium-browser

I don't have other browsers currently, I will try them out tomorrow or day after (IST) if that's ok with you.

I tried it on Mac OS and looks like the object returned by webbrowser.get() is completely different (it's an object of MacOSXOSAScript) which does not have .name attribute - it has only args, open(), open_new(), open_new_tab().
We'll have to skip Mac OS support for now :(

I tried it on Mac OS and looks like the object returned by webbrowser.get() is completely different (it's an object of MacOSXOSAScript) which does not have .name attribute - it has only args, open(), open_new(), open_new_tab().
We'll have to skip Mac OS support for now :(

I tried it on Mac OS and looks like the object returned by webbrowser.get() is completely different (it's an object of MacOSXOSAScript) which does not have .name attribute - it has only args, open(), open_new(), open_new_tab().
We'll have to skip Mac OS support for now :(

I guess we can create a new issue for that

I tried it on Mac OS and looks like the object returned by webbrowser.get() is completely different (it's an object of MacOSXOSAScript) which does not have .name attribute - it has only args, open(), open_new(), open_new_tab().
We'll have to skip Mac OS support for now :(

I guess we can create a new issue for that

That line can be added only for the winreg import, that way pylint would ignore only that import.

I also don't know how I can fix the failing mypy tests. Is there a way to tell to ignore the winreg module?

That line can be added only for the winreg import, that way pylint would ignore only that import.

I also don't know how I can fix the failing mypy tests. Is there a way to tell to ignore the winreg module?

I also don't know how I can fix the failing mypy tests. Is there a way to tell it to ignore the winreg module?

mypy didn't report any errors when I ran it locally on my system.
According to the docs here, we can add # type: ignore to the import.

To suppress a single missing import error, add a # type: ignore at the end of the line containing the import.

I also don't know how I can fix the failing mypy tests. Is there a way to tell it to ignore the winreg module?

mypy didn't report any errors when I ran it locally on my system.
According to the docs here, we can add # type: ignore to the import.

To suppress a single missing import error, add a # type: ignore at the end of the line containing the import.

@Samyak2 what's the way forward concerning the testing and monkeypatching involved? Any ideas?

@Samyak2 what's the way forward concerning the testing and monkeypatching involved? Any ideas?

I see that you have moved the utilities to utils, it looks good! The namespace is much cleaner now.
I have added some basic tests for default browser on Linux and MacOS. Tests for windows will be more difficult as we will have to monkeypatch OpenKey and OpenValueEx. The CI is failing on MacOS for some reason, need to fix that.

I see that you have moved the utilities to utils, it looks good! The namespace is much cleaner now.
I have added some basic tests for default browser on Linux and MacOS. Tests for windows will be more difficult as we will have to monkeypatch OpenKey and OpenValueEx. The CI is failing on MacOS for some reason, need to fix that.

I see that you have moved the utilities to utils, it looks good! The namespace is much cleaner now.
I have added some basic tests for default browser on Linux and MacOS. Tests for windows will be more difficult as we will have to monkeypatch OpenKey and OpenValueEx.

What if you add a utility function that does all that registry details and then monkeypatch that instead.

I see that you have moved the utilities to utils, it looks good! The namespace is much cleaner now.
I have added some basic tests for default browser on Linux and MacOS. Tests for windows will be more difficult as we will have to monkeypatch OpenKey and OpenValueEx.

What if you add a utility function that does all that registry details and then monkeypatch that instead.

What if you add a utility function that does all those registry hacks and then monkeypatch that instead.

That sounds like a good idea. A private function (maybe something like _get_windows_default) would avoid polluting the namespace too.
I will try doing this along with the windows tests tomorrow.

What if you add a utility function that does all those registry hacks and then monkeypatch that instead.

That sounds like a good idea. A private function (maybe something like _get_windows_default) would avoid polluting the namespace too.
I will try doing this along with the windows tests tomorrow.

I tested this on Windows and it works reliably for Chrome, Firefox and new Edge. It failed for internet explorer and the old edge, but that was expected.
I think this is complete now, except for a few browser support on Linux.

I tested this on Windows and it works reliably for Chrome, Firefox and new Edge. It failed for internet explorer and the old edge, but that was expected.
I think this is complete now, except for a few browser support on Linux.

The code coverage seems to have decreased because Codecov doesn't recognize browser_history/utils.py for some reason.
Also, we should add some default browser tests in CLI too:

The code coverage seems to have decreased because Codecov doesn't recognize browser_history/utils.py for some reason.
Also, we should add some default browser tests in CLI too:

The code coverage seems to have decreased because Codecov doesn't recognize browser_history/utils.py for some reason.
Also, we should add some default browser tests in CLI too:

I will get on this today. I have a slight break from exams.

The code coverage seems to have decreased because Codecov doesn't recognize browser_history/utils.py for some reason.
Also, we should add some default browser tests in CLI too:

I will get on this today. I have a slight break from exams.

The code coverage seems to have decreased because Codecov doesn't recognize browser_history/utils.py for some reason.

It seems like a bug in codecov, where it ignores files if another file of the same name exists in another directory (ref). Since we have __init__.py and utils.py in both browser-history and tests, they are ignored. There must be a workaround for this, but I couldn't figure it out.

The code coverage seems to have decreased because Codecov doesn't recognize browser_history/utils.py for some reason.

It seems like a bug in codecov, where it ignores files if another file of the same name exists in another directory (ref). Since we have __init__.py and utils.py in both browser-history and tests, they are ignored. There must be a workaround for this, but I couldn't figure it out.

There is another issue. I tried Microsoft Edge on Linux and it looks like webbrowser does not support it yet. webbrowser.get().name simply returns xdg-open. This also happens for Chromium Freeworld.
From the source code of webbrowser, I could see that it uses xdg-settings get default-web-browser command to figure out the default browser. On my system with Edge as default, the command prints microsoft-edge-dev.desktop.
It might be better to use the output of this command directly instead of relying on webbrowser. I will try working on this today.

Sorry for dragging the PR for so long :sweat_smile:, I want to ensure that everything works before merging.

There is another issue. I tried Microsoft Edge on Linux and it looks like webbrowser does not support it yet. webbrowser.get().name simply returns xdg-open. This also happens for Chromium Freeworld.
From the source code of webbrowser, I could see that it uses xdg-settings get default-web-browser command to figure out the default browser. On my system with Edge as default, the command prints microsoft-edge-dev.desktop.
It might be better to use the output of this command directly instead of relying on webbrowser. I will try working on this today.

Sorry for dragging the PR for so long :sweat_smile:, I want to ensure that everything works before merging.

I have made everything tidy (Even edge dev on linux is being detected correctly) but I haven't tested it on windows yet. Nothing should be affected by the refactor. I also noticed an unrelated issue where fetching from a browser not supported on the current platform throws an AssertionError which is completely unhandled on the CLI code. Trying to fetch from a default browser that is not supported also throws this error.
File "/home/obara/projects/python/browser-history/browser_history/cli.py",
 line 150, in main cli(sys.argv[1:])
File "/home/obara/projects/python/browser-history/browser_history/cli.py",
 line 132, in cli outputs = browser_class().fetch_history()
File "/home/obara/projects/python/browser-history/browser_history/generic.py",
 line 139, in __init__ assert self.linux_path is not None, error_string.format("Linux")
AssertionError: Edge browser is not supported on Linux

AFAIK this should just be a warning not a full fledged traceback. Maybe create an issue for this since we can't fix it in this feature branch.

I have made everything tidy (Even edge dev on linux is being detected correctly) but I haven't tested it on windows yet. Nothing should be affected by the refactor. I also noticed an unrelated issue where fetching from a browser not supported on the current platform throws an AssertionError which is completely unhandled on the CLI code. Trying to fetch from a default browser that is not supported also throws this error.
File "/home/obara/projects/python/browser-history/browser_history/cli.py",
 line 150, in main cli(sys.argv[1:])
File "/home/obara/projects/python/browser-history/browser_history/cli.py",
 line 132, in cli outputs = browser_class().fetch_history()
File "/home/obara/projects/python/browser-history/browser_history/generic.py",
 line 139, in __init__ assert self.linux_path is not None, error_string.format("Linux")
AssertionError: Edge browser is not supported on Linux

AFAIK this should just be a warning not a full fledged traceback. Maybe create an issue for this since we can't fix it in this feature branch.

I have made everything tidy (Even edge dev on linux is being detected correctly) but I haven't tested it on windows yet. Nothing should be affected by the refactor.

That's great!

I also noticed an unrelated issue where fetching from a browser not supported on the current platform throws an AssertionError which is completely unhandled on the CLI code. Trying to fetch from a default browser that is not supported also throws this error.
File "/home/obara/projects/python/browser-history/browser_history/cli.py",
 line 150, in main cli(sys.argv[1:])
File "/home/obara/projects/python/browser-history/browser_history/cli.py",
 line 132, in cli outputs = browser_class().fetch_history()
File "/home/obara/projects/python/browser-history/browser_history/generic.py",
 line 139, in __init__ assert self.linux_path is not None, error_string.format("Linux")
AssertionError: Edge browser is not supported on Linux

AFAIK this should just be a warning not a full fledged traceback. Maybe create an issue for this since we can't fix it in this feature branch.

I noticed this too, I'll open an issue for it.

I have made everything tidy (Even edge dev on linux is being detected correctly) but I haven't tested it on windows yet. Nothing should be affected by the refactor.

That's great!

I also noticed an unrelated issue where fetching from a browser not supported on the current platform throws an AssertionError which is completely unhandled on the CLI code. Trying to fetch from a default browser that is not supported also throws this error.
File "/home/obara/projects/python/browser-history/browser_history/cli.py",
 line 150, in main cli(sys.argv[1:])
File "/home/obara/projects/python/browser-history/browser_history/cli.py",
 line 132, in cli outputs = browser_class().fetch_history()
File "/home/obara/projects/python/browser-history/browser_history/generic.py",
 line 139, in __init__ assert self.linux_path is not None, error_string.format("Linux")
AssertionError: Edge browser is not supported on Linux

AFAIK this should just be a warning not a full fledged traceback. Maybe create an issue for this since we can't fix it in this feature branch.

I noticed this too, I'll open an issue for it.

Looks great overall!
Just a few small things. I will try fixing them today.

And the cli tests as well

Looks great overall!
Just a few small things. I will try fixing them today.

And the cli tests as well

@Samyak2 I noticed Vivaldi support has been added ... we need to support it in defaults as well.

@Samyak2 I noticed Vivaldi support has been added ... we need to support it in defaults as well.

@Samyak2 I noticed Vivaldi support has been added ... we need to support it in defaults as well.

Right, we need to do that.
@OBITORASU would it be possible for you to show us the outputs of _default_browser_win() and/or _default_browser_linux() functions when Vivaldi is set as the default browser (these functions are available only on this PR's branch)?

@Samyak2 I noticed Vivaldi support has been added ... we need to support it in defaults as well.

Right, we need to do that.
@OBITORASU would it be possible for you to show us the outputs of _default_browser_win() and/or _default_browser_linux() functions when Vivaldi is set as the default browser (these functions are available only on this PR's branch)?

Yes I can show the output of _default_browser_linux().
Branch: feature-default
OS: Arch Linux
Default Browser: Vivaldi (as asked)
The output for _default_browser_linux() is:
# vivaldi-stable

Image attached:

Yes I can show the output of _default_browser_linux().
Branch: feature-default
OS: Arch Linux
Default Browser: Vivaldi (as asked)
The output for _default_browser_linux() is:
# vivaldi-stable

Image attached:

Yes I can show the output of _default_browser_linux().
Branch: feature-default
OS: Arch Linux
Default Browser: Vivaldi (as asked)
The output for _default_browser_linux() is:
# vivaldi-stable

Image attached:

Thank you 👍

@ObaraEmmanuel I think it's all complete now, except for the tests for _default_browser_win() and _default_browser_linux(). We can open a new issue for those. What do you think?

Yes I can show the output of _default_browser_linux().
Branch: feature-default
OS: Arch Linux
Default Browser: Vivaldi (as asked)
The output for _default_browser_linux() is:
# vivaldi-stable

Image attached:

Thank you 👍

@ObaraEmmanuel I think it's all complete now, except for the tests for _default_browser_win() and _default_browser_linux(). We can open a new issue for those. What do you think?

@Samyak2 Sure thing, we've done the most we could.

@Samyak2 Sure thing, we've done the most we could.


Boolean(variableName) check

Hi!
I've got a component called Text that accepts children as props of type Node.
function Text({children}: {children: Node}) {
   return <span>{children}</span>
}

Then I have another component called PersonCard that uses Text component:
function PersonCard({name, description}: {name?: string, description?: string}) {
   return <>
      {Boolean(name) && <Text>{name}</Text>}
      {Boolean(description) && <Text>{description}</Text>}
   </>
}

Flow version: 0.94.0
Expected behavior
Flow will understand that I am checking for both, name, description that exists using Boolean(foo) && ...
Actual behavior
Inside the PersonCard I've got some flow errors saying that the Text component is not expecting a null/undefined value, which I find strange because I am checking that the variable exists and has values inside before I want to render the component. This only happens when I am using Boolean(foo) && ...

Link to Try-Flow or Github repo: https://flow.org/try/#0JYWwDg9gTgLgBDAnmApnA3gOQgExQXzgDMoIQ4ByKFAQwGMYKBuAKBdEljgCVaHjS5Kn0asWSVHAAKKKAGcIAOwDCNKDgAqyNAF4MLAJCKaIFAH4AXHDkwowRQHMANCzhwDeOXTtgYwJZbWtvYOLPhsRACuigz+inAaKAAeMAAU6HQAFsAANjjUivhWGdl5BVbYePgAlPrucNQwkVDxADxyYDSKAHwlufkoha0A9B1d3azhLMPDCdlycMALRDS5IXAAtHAARpHwAJJwyaj8wPAwEHAA7tAA1ixRMX5K0rIKKmo4AOpnmQBCEAgOVoKkyKDot3SxlMTjgnm8wF8cSKr3kSlU6i0qFq6Fc7kazTa3TxbnQAKBINS0JQtQAZLS4K1EiletT8CNmTBuuE3KTycCuql4T5noo6QymckuehhYjRezhpzuSTGcMJmE2DM5ktFstVjl1ltdgcjkkTvAzghLjcoPdHrEXjI0R91D8YJlErBgGpEMowRCoSYULDZUilCine8MZptDi8QYCS1GcTeRh+ZTqbUzIyleg2Rypd0rIpIjkcjzeWTAQLFEKUF4RXEsznCzL6wiw0NFYXi6XyyqRuqplqNPNrnc5A9og74pH0Z83ZkACIQSLbYGYFAOGh+ABuKEDMLh7cb4asc5dMexdXxKCaSdaKcrAEJn9S4PSWyy80GFUqK6Sr6hqKH4SrmwHIgWLIAaqQ5AA

Yep, it's a common issue, there's already an issue for that #4526.

Duplicate of #4526.


[front] - refactor: increase padding for empty Vault message container

Description
This PR changes the padding in the empty Vault message container for better visual spacing.
References:

https://github.com/dust-tt/tasks/issues/1378

Risk
None
Deploy Plan
Deploy front

Of course ✅


[Meta] Setup first delivery to TRI

[ ] Properly export trunks as multi-lane segments (#104).
[ ] Create a wiki page as a main source documentation for the installation process. Link to the documentation of the different required artifacts (#102, #103, #27, #107).
[ ] Perform in-house testing. Try generating different cities, exporting to RNDF and opening in gazebo using the plugin and report bugs/failures.
[ ] Improve gazebo performance. This includes parsing and rendering (#17).

This one became dated and most issues were tackled.


Validate AWS accounts and roles

In order to start working to split into separate AWS accounts, we want to validate the accounts have been created and we know which ones are going to be used
Acceptance Criteria

[ ] Given the need to use 3 new accounts (tooling, development, staging), document which account will be used for each of these 3 environments
[ ] Given the need to use BOSH and Terraform in the 3 environments, validate that each account can be accessed via the CLI and Console

Security considerations
This is one of the steps in splitting the aws account into several which will make the overall footprint more secure
Implementation sketch

[ ] Identify the 3 accounts to be used
[ ] Create documentation referencing the architecture in https://github.com/cloud-gov/product/issues/2500 that will map each of the accounts being used.  Note that the current account will become "production"
[ ] Validate that each account can be accessed via AWS Console
[ ] Validate that each account can be accessed via aws-vault

We have a mapping of accounts in our aws-admin repo: https://github.com/cloud-gov/aws-admin/blob/main/stacks/gov/sso/main.tf#L39


'See Earlier Issues' Links do not work - instead redirect to docs home page.

https://docs.microsoft.com/en-gb/archive/newsletter/technet/microsoft-technet-flash-archive
'See Earlier Issues' Links do not work - instead redirect to docs home page.
Problem:
'See Earlier Issues links seem to be dead - instead redirect to a docs home page.

@MbrookWork Thanks for taking the time to leave us feedback!
The page you referenced is an archive site that is no longer actively updated. Previous links to other articles may be deprecated. Use the Microsoft Product Lifecycle page for more information about the specific prouct or service you were interested in.
Appreciate your contribution to our community.


platform 3.4.0

Type: Missing
Summary:
platform 3.4.0
Details:
Searched Maven for net.java.dev.jna/platform 3.4.0 and found: https://search.maven.org/artifact/net.java.dev.jna/platform/3.4.0/jar
License is LGPL-2.1-only
Resolution:
Declared license is LGPL-2.1-only
Affected definitions:

platform 3.4.0

@LandOfBliss I think this should be LGPL-2.1-or-later. I checked the source files and found this in the headers:
package com.sun.jna;
/* Copyright (c) 2011 Timothy Wall, All Rights Reserved
 *
 * This library is free software; you can redistribute it and/or
 * modify it under the terms of the GNU Lesser General Public
 * License as published by the Free Software Foundation; either
 * version 2.1 of the License, or (at your option) any later version.

Do you agree?

Agree with your findings = LGPL-2.1-or-later


Incompatible with YSI (y_hooks)

I'm using the latest version of Pawn.CMD (3.2.0) with YSI (4.0). I've a modular gamemode and the hooked callbacks won't work because I've to use 'Cmd' instead of 'Command' when hooking since Pawn doesn't support function names of more than 32 characters.

I came across this problem today. I wanted to hook and use OnPlayerCommandReceived with two different modules (account - not logged in and staff - not authorized) but callbacks will not be called at all.
#include <YSI_Coding\y_hooks>

hook OnPlayerCommandReceived(playerid, cmd[], params[], flags)
{
    print("staff:OnPlayerCommandReceived");
    return 1;
}

It does not print but changing back to public function, it prints.

How about if you simply add a blank one somewhere that is a public. Before the hooks.
public OnPlayerCommandReceived(playerid, cmd[], params[], flags)
{
    return 1;
}

Added a blank public function before the hooks, the hooks are not called. I also tried changing the include order (Pawn.CMD first and then YSI) but it made no difference.

This will never be compatible with y_hooks because it was never made with compatibility for it in mind.

The plugin code will need to be changed for that as far as I can remember about it, it caches the command names and thus, whole thing becomes incompatible at this point.

Using the ALS method 7 in these two modules now calls OnPlayerCommandReceived correctly in both of them. The problem is in YSI.

That's weird, it never worked for me back in the day with either of it.


Duplicate definitions

The descriptions for Suspicious cloud use and Suspicious activity alerts are the same. How do these alerts differ? please clarify

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 70912b42-016b-d311-86cd-86f2e5e04a51
Version Independent ID: 1744f30c-af16-cf4a-6a91-043e6f92b330
Content: Manage alerts raised in Cloud App Security
Content Source: CloudAppSecurityDocs/managing-alerts.md
Service: cloud-app-security
Product: ****
Technology: ****
GitHub Login: @shsagir
Microsoft Alias: shsagir

@name Thanks for contacting Microsoft with feedback about our product documentation. Depending on the complexity, it could take from a few business days to a few weeks to look further into your question, issue, or suggestion. We'll contact you if we need further information, and you'll receive an email message each time we "@mention" you in a comment.
Thanks again for submitting your feedback. Your suggestions help improve our documentation.


Error log and status bar alignment issues

I just encountered an issue where when the error log first showed, the status bar, which is supposed to stay on the bottom at all times, ended up on top of the error log, between the repo list and the error log. It was still aligned, just in the wrong order.

Unfortunately, I tried to reproduce this for a screenshot and can't. Just need to modify the code here to ensure alignment order / position.

 But the title bar ended up over-top the error log when it showed.


Watermark on credential cards are missing or are not visible

Missing watermark on credential card UI for Student Card.
Watermark on LSBC Member Credential is almost transparent. It's really hard to see.
The watermark on the person credential seems to overlap each other where the darker blue is (horizontal part).

Fixed, confirmed in 1.0.17 1740. See screenshot. Watermarks seem Ok.


Inherit parsing issues

This PR is quite small and is a small patch to solve a small bug noticed by @jimcasaer. While reading a datapackage, a warning about parsing issues in deployments was returned on screen. However, nothing was returned by readr::problems(dp$data$deployments).
The reason? While working on v0.20 I removed by accident the few lines of code where I assigned reading issues of deployments and media to the attributes of the corresponding data.frames.

Improving tests at the moment...

Still getting failing check on Ubuntu-latest (3.6.3). It's an issue with the installation of terra package.
https://github.com/inbo/camtraptor/actions/runs/6356494664/job/17288425829?pr=282#step:5:4726
@pietrH; if you agree, I would remove (temporarily?) this check. We have already a windows-latest (3.6.0) check to ensure compatibility with R 3.6.x.

test-read_camtrap_dp.R does print some messages to console during testing, this is because in zzz.R:
https://github.com/inbo/camtraptor/blob/d79224fd87f9e722425b4e6feb9d40a3c3b6df4a/R/zzz.R#L464-L471
We use writeLines() to print to console, not warning() or message(), this slightly different approach results in suppressMessages(read_camtrap_dp()) still printing to console while testing.

Still getting failing check on Ubuntu-latest (3.6.3). It's an issue with the installation of terra package. https://github.com/inbo/camtraptor/actions/runs/6356494664/job/17288425829?pr=282#step:5:4726
@PietrH; if you agree, I would remove (temporarily?) this check. We have already a windows-latest (3.6.0) check to ensure compatibility with R 3.6.x.

It seems to be fixed in the current development build of terra: https://github.com/rspatial/terra/issues/1276
They were using the new anonymous functions introduced in R4.1, altough it surprises me that our tests passed on Windows 3.6.0
Originally I was thinking about a problem with different line breaks between Linux and Windows, similar to: https://stackoverflow.com/questions/56471638/error-unable-to-collate-and-parse-r-files-for-package-upload-to-cran

In principle I don't protest removing the check on Ubuntu, however, are should make sure we aren't accidentally (re-)discovering a lingering issue in terra.

Some things I fixed in commits:

moved creation of objects needed for tests to very first line of test script, is clearer to contributes (fooled me!) that these objects are created if they are running tests out of order
replaced expect_equal(class()) with expect_type(), also consider expect_s3_class(): easier to read, less error prone
replace expect_equal(length()) with expect_length(): easier to read
replaced expect_equal() with expect_identical() where I felt it was a better match, increasing test strictness. expect_equal() has a built in tolerance.

in test-read_camtrap_dp.R we are reusing even objects between tests, we could put those in the start of the file as well, this way the tests will run faster, and it's easier for us to make changes in the way these objects are created.

One final comment:
I'm having some trouble with this test:
https://github.com/inbo/camtraptor/blob/1b749cd1ba692b9860640ddb611f4124a32f9fc2/tests/testthat/test-read_camtrap_dp.R#L303-L319

Why do we suppress the messages of expect_warning?
I can't get the deprecation warning to actually show in my console, but that might be on my end as it might only show once and then not again for a few hours.
When running covr I ran into this error:

-- Error ('tests/testthat/test-read_camtrap_dp.R:305:3'): path is deprecated ---
Error in `lifecycle_message(when, what, with, details, env, signaller = "deprecate_warn")`: Can't detect the package of the deprecated function.
Please mention the namespace:

  # Good:
  deprecate_warn(what = "namespace::myfunction()")

  # Bad:
  deprecate_warn(what = "myfunction()")

Backtrace:
     x
  1. +-rlang::with_options(...) at tests/testthat/test-read_camtrap_dp.R:305:2
  2. +-base::suppressMessages(...)
  3. | \-base::withCallingHandlers(...)
  4. +-testthat::expect_warning(...)
  5. | \-testthat:::expect_condition_matching(...)
  6. |   \-testthat:::quasi_capture(...)
  7. |     +-testthat (local) .capture(...)
  8. |     | \-base::withCallingHandlers(...)
  9. |     \-rlang::eval_bare(quo_get_expr(.quo), quo_get_env(.quo))
 10. \-read_camtrap_dp(file = dp_path_warning, media = FALSE)
 11.   \-lifecycle::deprecate_warn(...)
 12.     +-lifecycle:::deprecate_warn0(...)
 13.     | +-id %||% paste_line(msg)
 14.     | \-lifecycle:::paste_line(msg)
 15.     |   +-base::paste(chr(...), collapse = "\n")
 16.     |   \-rlang::chr(...)
 17.     |     \-rlang::dots_values(...)
 18.     \-lifecycle:::lifecycle_message(when, what, with, details, env, signaller = "deprecate_warn")
 19.       \-lifecycle:::spec(what, env, signaller = signaller)
 20.         \-lifecycle:::spec_pkg(what$pkg, env, ctxt = ctxt)
 21.           \-cli::cli_abort(...)
 22.             \-rlang::abort(...)

However the documentation https://search.r-project.org/CRAN/refmans/lifecycle/html/deprecate_soft.html mentions the namespace declaration as optional.
@damianooldoni , could you have a look at this test to see if to works as intended?

Thanks @PietrH for your in depth review and for improving the coding and the quality of the tests.
@peterdesmet  and @PietrH: I didn't add anything on NEWS.md about this PR as it is a very small patch work. However, feel free to disagree. If so, please add please a line if you think so. Something like:

Solve a bug in read_camtrap_dp() while returning parsing issues (see #282).

I would first finalize the more important PR #289, then pulling the changes in main into this PR. I don't expect any conflict this time as PR #289 didn't modify anything related to read_camtrap_dp() and its tests.


Replace Azure matrix strategy with direct iteration.

Also, rename the Azure template to something more meaningful.

Codecov Report

Merging #10 into master will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##            master       #10   +/-   ##
=========================================
  Coverage   100.00%   100.00%
=========================================
  Files            4         4
  Lines           73        73
=========================================
  Hits            73        73

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2367639...df26032. Read the comment docs.


Comments on Setup section

In Visual Studio press cogwheel Extension Settings to find field for Julia Executable Path.

To find the path to Julia on Windows one can start julia REPL, type
Sys.BINDIR

When installing conda, jupterlab and so on on Windows may have to extend PATH environment variable with path to conda. Can do this by:
entering Settings
type "environment"
enter "Edit the system environment variables"
click Environment Variables
choose Path and Edit and add your path to conda

Comment pertains also to (I think):
https://enccs.github.io/julia-intro/

why is conda needed here? Julia should be installed with juliaup

oh right i guess this issue is referring to the usage of Jupyter. We're keeping that optional and will be using VSCode mostly

Right. I think the 3rd comment is about jupyterlab installation and some issue that arose when I tried it going through the setup steps.


Typing "$(" opens jQuery autocomplete even when the dollar symbol has been defined as something else

Steps to Reproduce:

Declare the $ as something that's not jQuery
Type $(

This pops up with jQuery autocomplete, but I'm not using jQuery.
Such as this:

is there an interface or type declaration for   go.GraphObject.make?

There is not, it's an any when you hover over.

A few questions:

Are you in an html file?
If you run go to definition on $, where does it go to?

Yeah, I'm in an HTML file.
If I run go to definition, it just goes to the:
var $ = go.GraphObject.make;

line.

Thanks. We always include jquery typings in html files. That's where the global jquery $ is coming from.
What doesn't make sense here is that if you write:
var $ = 2;
$()

We correctly identify the type of $ as number but we still get signatureHelp for the jquery global. This happens even if you define $ in a new scope:
<script>
    function x() {
        const $ = 2;
        $()
    }
</script>

Seems like a TS issue here. I'll try putting together a repo that doesn't involve html files.
@aeschli please let me if you've seen this sort of problem before or have any thoughts on potential workarounds

Opened https://github.com/Microsoft/TypeScript/issues/16913 to track this upstream


Partially revert #2548 which breaks tests on macOS when the extractor has different system includes from toolchain [phab:D2175]

Created by shahms at 2018-02-08 18:26:28:
Partially revert #2548 which breaks tests on macOS when the extractor has different system includes from toolchain

salguarnieri wrote at 2018-02-08 18:40:58:
builds clean for me on my mac

salguarnieri accepted this revision at 2018-02-08 18:40:58

shahms wrote at 2018-02-08 20:24:59:

Make adding toolchain builtin directories conditional and only enable it on macOS

shahms wrote at 2018-02-08 20:25:49:
I've updated this so it only adds the toolchain builtins on macOS, can you give it another spin?  Even this is pretty ugly and I'm not sure what the "right" way to go about it is.

zarko accepted this revision at 2018-02-08 21:03:33

shahms wrote at 2018-02-08 21:10:06:

Add missing i in -isystem flag

shahms closed via commit 7b17bf1b916e49734c9ee9712cb5416b4369770d at 2018-02-08 21:15:54


Make it possible to serialize editor state automatically

Rather than manually adding serialization rules for this plugin users can now do this:
import { Html } from 'slate';
import MentionPlugin from 'slate-mentions';

// Create the plugin as usual
const mentions = MentionPlugin({
  Mention: MentionComponent,
  Suggestions: SuggestionsComponent,
});

const { serialize } = new Html({
  // Add the mentions serialization rules after any of your custom ones
  rules: [...mentions.serializationRules]
});

// Get your current editor state as HTML 🎉
serialize(editor.state);

// You can also get your current editor state as React components:
serialize(editor.state, { render: false });

The serialize-to-react-component-thing seems like a much better option for rendering messages, rather than rendering thousands of read-only editors. Am I right in assuming that's a better approach @ianstormtaylor?

I'm unsure if this actually makes sense, given that when you render a serialized mention you might want to render e.g. a link and not just a span. Might have to rethink this...


Feature request: Dark mode/dark color scheme

Hello everybody,
First and foremost: thank you for the wonderful work! I use Livebook nearly every day as a development and debugging tool for Phoenix applications.
Unfortunately, Livebook doesn't have a dark color scheme for the dashboard and notebooks yet.
I could gladly implement a darker color scheme myself using @media (prefers-color-scheme: dark) if I could get a green light to develop this feature.

Hi @moroz! Thanks for pinging.
This is something we want to consider in the future but I am worried that adding this right now is going to slow us down, as we still figure out how Livebook should work. I recommend trying out https://darkreader.org/ and, if you do, let us know which settings work for you. :)

Thank god, https://darkreader.org/  is much nicer solution.


Native comments moderation doesn't work on local Windows installation

Issue Summary
When using Ghost native comments you should be able to moderate the comments by hiding/unhiding them. This feature doesn't work on a local Windows installation. The option for hiding/unhiding isn't available as the site doesn't recognize that you're logged in as both a staff user and a member, so the site behaves just as if you're only logged in as a member and shows only the Report comment option for others comments and Edit and Delete for your own comments.
I'm adding the comment-counts.min.js error  from the browser console in the Relevant log / error output section below with reference to this comment in the Ghost forum as it's the only relevant log I have. I see no trace of the admin-auth script in the browser console.
In the linked comment from the forum there's a theory that this has to do with script generation not working on Windows which is the same issue as in #14278. I can confirm this as the content/public folder is empty on Windows, but on my local test installation in Ubuntu 20.04 using WSL that folder is populated correctly:
/ghost/content/public$ ls
admin-auth  cards.min.css  cards.min.js  comment-counts.min.js  member-attribution.min.js

Steps to Reproduce

Install Ghost locally on Windows.
Log in to the admin dashboard.
Enable comments.
Add yourself as a member.
Add another test member.
Sign in to the site as member 1.
Write at least one comment as member 1.
Sign out member 1.
Sign in as member 2.
Click the three dots on the other members comment and notice how the Hide option isn't shown, instead it shows only Report comment.

Ghost Version
5.10.1
Node.js Version
16.16.0
How did you install Ghost?
Local installation on Windows 10 Pro 21H2 (19044.1889)
Database type
SQLite3
Browser & OS version
Chrome (104.0.5112.102) Firefox (103.0.2) Windows 10 Pro 21H2 (19044.1889)
Relevant log / error output
GET http://<IP_ADDRESS>:2368/public/comment-counts.min.js?v=d0ac7496d9 net::ERR_ABORTED 404 (Not Found)

Code of Conduct

[X] I agree to be friendly and polite to people in this repository

Hey @Backspaze thanks for the report. This looks like the same issue as https://github.com/TryGhost/Ghost/issues/14278 as you said. I've generalised the title on the other issue, and will close this issue in favour of that one.


Extra HAL to a separate repository

The idea is to separate the HAL for the target, simulation and its interfaces in github repositories.
The advantage is to use them in different other projects too, different than RadonUlzer.
Proposal:

ZumoHALATmega32u4: https://github.com/BlueAndi/ZumoHALATmega32u4
ZumoHALWebots: https://github.com/BlueAndi/ZumoHALWebots
ZumoHALInterfaces: https://github.com/BlueAndi/ZumoHALInterfaces

@eble108 This would be an advantage on your side as well, right?

Branch with extracted HALs: https://github.com/BlueAndi/RadonUlzer/tree/extractHALs

Closed by #122


Cache is disabled but tested ips remaining banned due to cache hits?

Hi there
I have got your plugin working now with kubernetes but noticed an odd occurrence
Cache is currently disabled;
redisCacheEnabled: false
But manually added ips remain banned due to cache hits?
cache:hit isBanned:true
How can that be with cache disabled?
Also, is  crowdsecMode set to none when redis is disabled?
Thanks :)

The README says:

RedisCacheEnabled

bool
default: false
enable redis cache instead of filesystem cache

I think your setup uses the local cache.
To really disable the cache, you need to set the mode to none

I hope I've helped you, don't hesitate to put a star, it's appreciated 😃

Can I close the issue ?

I noted in my initial post that about crowdsecMode = none.
The main point (which I failed to mention) was that I left it for 10 mins and the local cache never reset after unbanning the ip.

If you are in live mode, the local cache as the redis cache use the duration ban sent by crowdsec. If you want a unban after a period, use none or stream mode. 😄


feat: fix javascript documentation

Description
This pull request changes the following:

Fix javasript doc error reported by jsDoc

Related Issues

Closes #192

:tada: This PR is included in version 0.23.0 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


Team avatar is stretching images

The Chore
See example

Tasks

[ ] It should be cropping rather than stretching
[ ]

Additional details / background info

Note there is talk of having a better way to uplaod images more broadly which would make this redundant


feat: add azure openai support

As a user of the project, I would like to request the addition of support for Azure OpenAI. With this new feature, I can take advantage of the advanced AI technologies and services offered by the Azure OpenAI platform.
I believe that incorporating support for Azure OpenAI would greatly enhance the project's functionality and usefulness. Users who are interested in integrating AI capabilities into their applications would find this feature particularly valuable.
Azure OpenAI already offers a range of APIs that are similar to those currently being used by the project. However, there are a few differences, which can be reviewed in detail at https://learn.microsoft.com/en-us/azure/cognitive-services/openai/reference.
For more information on how ChatGPT can be used in Azure OpenAI, please visit https://azure.microsoft.com/en-us/blog/chatgpt-is-now-available-in-azure-openai-service/.

I'm considering to use LiteLLM for multiple backends integration. This should provide an option to switch between various LLM backends including Azure. I would greatly appreciate any assistance with testing the Azure Integration PR https://github.com/TheR1D/shell_gpt/pull/463. To test it follow these steps:
git clone https://github.com/TheR1D/shell_gpt.git
cd shell_gpt
git checkout ollama
python -m venv venv
source venv/bin/activate
pip install -e  .

export AZURE_API_KEY=YOUR_KEY
export AZURE_API_BASE=YOUR_API_BASE
export AZURE_API_VERSION=YOUR_API_VERSION
export AZURE_AD_TOKEN=YOUR_TOKEN # Optional
export AZURE_API_TYPE=YOUR_API_TYPE # Optional

sgpt --model azure/<your_deployment_name> --no-functions "Hi Azure"

ShellGPT with LiteLLM was release as 1.3.0, please follow steps above to setup ShellGPT with Azure. Given that I'm closing this issue.

Any plans to update docs?

Wiki page added, link included in README.md https://github.com/TheR1D/shell_gpt/pull/491


Request: display whether the the fishing spot being used is able to get treasure

should probably add a conditional for whether a fishing rod is being used, as well

It'll be in the next release, sometime within the next week

Added in v3.1


__error() not provided for x86_64-unknown-dragonfly

Target: x86_64-unknown-dragonfly (not in the CI)
Instructions to reproduce: just try to build in this platform

After commit 3fa021d7a, libc won't provide __error() for DragonFly. We've spotted this by trying to build rust-1.39, which includes a newer libc crate (0.2.62) that contains this change.
The error shows up when the build tries to make use of libc::__error():
error[E0432]: unresolved import `libc::__error`
  --> /usr/obj/dports/lang/rust.139/rustc-1.39.0-src/vendor/getrandom/src/util_libc.rs:22:13
   |
22 |         use libc::__error as errno_location;
   |             ^^^^^^-------^^^^^^^^^^^^^^^^^^
   |             |     |
   |             |     help: a similar name exists in the module: `ferror`
   |             no `__error` in the root

error: aborting due to previous error

For more information about this error, try `rustc --explain E0432`.
error: Could not compile `getrandom`.
warning: build failed, waiting for other jobs to finish...
error: build failed
command did not execute successfully: "/usr/obj/dports/lang/rust.139/rustc-1.39.0-src/build/x86_64-unknown-dragonfly/stage0/bin/cargo" "build" "-Zconfig-profile" "--target" "x86_64-unknown-dragonfly" "-Zbinary-de
p-depinfo" "-j" "24" "--release" "--frozen" "--features" "" "--manifest-path" "/usr/obj/dports/lang/rust.139/rustc-1.39.0-src/src/rustc/Cargo.toml" "--message-format" "json-render-diagnostics"
expected success, got: exit code: 101
Traceback (most recent call last):
  File "/usr/obj/dports/lang/rust.139/rustc-1.39.0-src/x.py", line 11, in <module>
    bootstrap.main()
  File "/usr/obj/dports/lang/rust.139/rustc-1.39.0-src/src/bootstrap/bootstrap.py", line 913, in main
    bootstrap(help_triggered)
  File "/usr/obj/dports/lang/rust.139/rustc-1.39.0-src/src/bootstrap/bootstrap.py", line 899, in bootstrap
    run(args, env=env, verbose=build.verbose)
  File "/usr/obj/dports/lang/rust.139/rustc-1.39.0-src/src/bootstrap/bootstrap.py", line 141, in run
    raise RuntimeError(err)
RuntimeError: failed to run: /usr/obj/dports/lang/rust.139/rustc-1.39.0-src/build/bootstrap/debug/bootstrap build --verbose --config ./config.toml --jobs 24
*** Error code 1

Stop.
make[1]: stopped in /usr/dports/lang/rust.139
*** Error code 1

Stop.

Let me know if you need additional information and I'll provide it.

AFAICT the __error function is still available on DragonflyBSD. It was previously only provided if cfg!(libc_thread_local) is true, and that remains to be the case. cc @josephlr

As far as I can tell, even removing the conditional so that the feature is always enabled is not enough for this to build.
I changed:
#![cfg_attr(libc_thread_local, feature(thread_local))]
to
#![feature(thread_local)]
Maybe I'm missing something?

Sorry about missing this, it slipped by me over the holidays. #1432 added __error for DragonflyBSD, but only when the libc crate is a dependency of libstd. The reasoning is here: https://github.com/rust-lang/libc/pull/1432#issuecomment-511139441 Essentially, getting DragonflyBSD errno to work requires nightly, but all the crates that would use this feature don't want to require nightly.
The reason you're hitting this issue is my fault however, see https://github.com/rust-random/getrandom/issues/124. This was fixed in https://github.com/rust-random/getrandom/pull/129 , which was released with getrandom 0.1.14.
Regardless, I think this issue can be closed.

Thanks for the info. Please hold this off a bit, we're about to release 5.8 which has __errno_location, and in that case we can fall into the linux case, see this: https://github.com/DragonFlyBSD/DeltaPorts/blob/master/ports/games/veloren/dragonfly/patch-util_libc.rs

We have now released 5.8 which contains __errno_location

See this commit, its now provided from libc in both stable and head releases:
https://gitweb.dragonflybsd.org/dragonfly.git/commitdiff/60d311380ff2bf02a87700a0f3e6eb53e6034920
commit 60d311380ff2bf02a87700a0f3e6eb53e6034920
Author: zrj<EMAIL_ADDRESS>Date:   Sat Oct 5 13:04:12 2019 +0300

    libc: Add __errno_location() for language binding benefits.

     Some languages have restrictions when it comes to C style TLS handling
     (thread local might be feature-gated) or simply it is inconvenient to
     add various OS specific binding wrappers just to access C errno values.

     The __errno_location() symbol provides externally callable version of
     __error() inline function.

     While there, add __WANT_NO_INLINED___ERROR guard for few python parsers
     in DPorts that are unable to parse inlined __error() code yet.

It coud be exported in src/unix/bsd/freebsdlike/dragonfly/mod.rs via extern C, which is what we do for fixing Rust packages.

Fixed by #1875.


Have awk read /proc/uptime directly

Awk can read /proc/uptime directly, so no need to pipe it output from cat.

Thanks for the pull request! I'll run a few tests and then merge.


Correct warnings (and one error) from Rubocop 0.79.0

Simple one, when running my code through Rubocop to get it formatted and styled properly for https://github.com/dry-rb/dry-effects/issues/73 I ran into some issues.
Probably the Ruby/Rubocop version you're using on your end isn't the bleeding edge one I got on my clean Ruby 2.7.0 and Rubocop 0.79.0 install today.

Sorry, rubocop config is centrally managed via dry-rub/devtools. Due to some limitations of codacity we stuck on a stale version of the tool. As soon as these limitations are lifted, we’ll update the config

Understood, thanks for the clarification :) I assumed I was missing something.


4317 scenario 2.1 basic service (#4395)

Pull request opened by the merge tool on behalf of #4395

Merged in 639559860b4db4dde64f4daf317eb0e45815d8aa


New subscribe/unsubscribe/EventSource API

Resolves #479
This will:

[x] allow arbitrary unsubscriptions (currently can only be done in response to an event)
[x] simplify the API for event sources
[x] ensure that queries that evaluate asynchronously will not block the subscription loop

Hmm, maybe... I was looking forward to getting rid of that fresh state :smile:
What use case are you envisioning for that? Fire-and-forget subscriptions? As otherwise they'll need saving in the component state anyway, in which case I'd be tempted to leave the onus on the component to generate names rather than it being a capability of Halogen in general.

I suppose since subscriptions implies MonadAff anyway, there's no reason you can't generate unique names yourself with random.

@garyb Would you mind pushing it into #532?

@cryogenian I'll merge this, and then merge master into that :smile: - I wanted to make reviewing the other part clearer.


Prerelease QA branch

[x] fix height of DAG on smaller screens

agh, thought this was on master already. https://github.com/plotly/dash-renderer/pull/165/commits/45136e2b1946850359ffef8221cad7cd68f30a27 was approved already in https://github.com/plotly/dash-renderer/pull/166 and https://github.com/plotly/dash-renderer/pull/165/commits/75e301685ccc9a52dad47496e6515798092ff9fc is simple, so I'm going to merge this into master as https://github.com/plotly/dash-core-components/pull/536 depends on it.


Franz: Support for 32 bit architecture

I've added the "architecture" section differentiating the pre-install script between 32 bit and 64 bit
fixes #1486

Thanks @Ash258 for your help! Are you suggesting I switch my commited file with your, optimized one or are you saying there should be a new PR?
 Is that the correct procedure?

All commits, which you pushed to same branch PR was made of will be shown here.

git checkout 'origin/bug/franz-support-for-32bit-arch' // Switch to your branch
Edit file
git add franz.json
git commit -m 'Some message about changes'
git push

Or just edit it from browser within this PR file changed tab and clicking Edit

Ok thanks, I did it. I read some other project had a "one-commit-per-PR" policy, that's why I asked!

We have an unwritten (?) policy of squash merging PRs so multiple commits in a PR are fine,


Fix exports

This is an extra for #150
Fixes exports and tweaks some tests.
The link, linkAssets, and linkDependency where trickier as hell, but we have all tests working.
I suggest take it easy in this review as I'm worried in a "false positive" in tests as there was a LOT of changes.
We need to improve the code coverage for changes like this have smaller chances of failing...

@grabbou

@grabbou I missed those indeed. Will check and ping back

Awesome @sidferreira! Thank you

@grabbou the changes you requested ended being larger than expected. I reverted until we decide if we do the extra work now or wait for later.

@sidferreira sounds good. Did you update the public API?

Thanks @sidferreira 👍


with empty version,  could not publish to local maven

retest this please

This has been taken care of on Master.


How to build the UI?

cool dapp 👓

Thanks. I just realised that you made an comment. It was great to see you at DevCon2


[KYUUBI #1839] Minor refactor OperationUtil

Why are the changes needed?

This is a sub-task of KPIP-2 #1322.
How was this patch tested?

[ ] Add some test cases that check the changes thoroughly including negative and positive cases if possible

[ ] Add screenshots for manual tests if appropriate

[x] Run test locally before make a pull request

Codecov Report

Merging #1843 (92a2e3b) into master (5ea0964) will decrease coverage by 0.17%.
The diff coverage is 87.50%.

:exclamation: Current head 92a2e3b differs from pull request most recent head d56a381. Consider uploading reports for the commit d56a381 to get more accurate results

@@             Coverage Diff              @@
##             master    #1843      +/-   ##
============================================
- Coverage     59.63%   59.45%   -0.18%
+ Complexity      272      271       -1
============================================
  Files           275      277       +2
  Lines         13783    13842      +59
  Branches       1764     1773       +9
============================================
+ Hits           8219     8230      +11
- Misses         4863     4910      +47
- Partials        701      702       +1

Impacted Files
Coverage Δ

...ache/kyuubi/engine/flink/result/ResultSetUtil.java
91.66% <75.00%> (ø)

...uubi/engine/flink/operation/ExecuteStatement.scala
77.55% <100.00%> (ø)

...he/kyuubi/engine/flink/operation/GetCatalogs.scala
83.33% <100.00%> (ø)

.../kyuubi/engine/flink/operation/GetTableTypes.scala
100.00% <100.00%> (ø)

...ache/kyuubi/engine/flink/operation/GetTables.scala
84.00% <100.00%> (ø)

...pache/kyuubi/operation/log/LogDivertAppender.scala
50.00% <0.00%> (-39.48%)
:arrow_down:

...mon/src/main/scala/org/apache/kyuubi/Logging.scala
37.68% <0.00%> (-17.43%)
:arrow_down:

...n/scala/org/apache/kyuubi/engine/ProcBuilder.scala
87.39% <0.00%> (-0.85%)
:arrow_down:

...he/kyuubi/operation/log/Log4j2DivertAppender.scala
79.54% <0.00%> (ø)

...e/kyuubi/operation/log/Log4j12DivertAppender.scala
0.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5ea0964...d56a381. Read the comment docs.

Thanks, merging to master


Data image fails to start with existing influxdb.conf

Hello, I'm attempting to patch the Helm chart stable/influx to use Enterprise. When deploying the chart with the influxdb:data image, it fails to start up, with Hinted Handoff attempting to use empty string as its path. Expected behavior is using a default of /var/lib/influxdb/hh, or complaining that hinted-handoff.dir doesn't exist in influxdb.conf, instead of attempting to start Hinted Handoff with an empty string path. Documentation doesn't mention or imply the need for the Hinted-handoff section.
I recognize there are a few projects being touched here (helm/charts, influxdata/influxdata-docker, influxdata/influxdb). I'm taking it upon myself to "fix" the Helm chart stable/influxdb, but I would expect this to be resolved within InfluxDB too.
Steps to reproduce:

Run container image influxdb:data
Deploy with a influxdb.conf that previously worked with InfluxDB OSS.
Observe that Hinted Handoff attempts to start with empty path

ts=2019-11-12T16:58:07.977696Z lvl=info msg="Using data dir" log_id=0J48epWW000 service=handoff path=

Environment info:
Using Docker hub imageinfluxdb:data.
Config:
Command used to deploy container image:
$ helm install -f influxdb.yaml ~/repos/wgj/charts/stable/influxdb --namespace influxdb -n influxdb

$ cat influxdb.yaml
image:
  tag: data
env:
  - name: INFLUXDB_ENTERPRISE_LICENSE_KEY
    value: beef-babe

If you're not familiar with Helm and Kubernetes, the above is boilerplate to deploy the influxdb:data to a Kubernetes cluster. If you were to change the image tag from data to latest and make no other changes, the container will deploy successfully.
~/repos/wgj/charts/stable/influxdb is a fork of helm/charts. The only edit, shown below, is adding the [hinted-handoff] section.
$ git diff ~/repos/wgj/charts/stable/influxdb
diff --git a/stable/influxdb/templates/config.yaml b/stable/influxdb/templates/config.yaml
index 2cc83da80..14a39a3d9 100644
--- a/stable/influxdb/templates/config.yaml
+++ b/stable/influxdb/templates/config.yaml
@@ -13,6 +13,10 @@ data:
     reporting-disabled = {{ .Values.config.reporting_disabled | default false }}
     bind-address = ":{{ .Values.config.rpc.bind_address }}"

+    [hinted-handoff] # TODO wgj File bug, as HH will intuit null directory if not specified.
+      enabled = true
+      dir = "/var/lib/influxdb/hh"
+
     [meta]
       dir = "{{ .Values.config.storage_directory }}/meta"
       retention-autocreate = {{ .Values.config.meta.retention_autocreate }}

Logs:
This is the log output when [hinted-handoff] is not added explictly.
$ kubectl logs -n influxdb influxdb-0
ts=2019-11-12T16:58:07.873969Z lvl=info msg="InfluxDB starting" log_id=0J48epWG000 version=1.7.8-c1.7.8 branch=1.7 commit=ab724c8917878a758f1a6d753cb25abb41485c17
ts=2019-11-12T16:58:07.873992Z lvl=info msg="Go runtime" log_id=0J48epWG000 version=go1.10.3 maxprocs=6
ts=2019-11-12T16:58:07.874022Z lvl=info msg="Loading configuration file" log_id=0J48epWG000 path=/etc/influxdb/influxdb.conf

 8888888           .d888<PHONE_NUMBER>b.  888888b.
   888            d88P"  888                   888  "Y88b 888  "88b
   888            888    888                   888    888 888  .88P
   888   88888b.  888888 888 888  888 888  888<PHONE_NUMBER>888K.
   888   888 "88b 888    888 888  888  Y8bd8P' 888    888 888  "Y88b
   888   888  888 888    888 888  888   X88K   888    888 888    888
   888   888  888 888    888 Y88b 888 .d8""8b. 888  .d88P 888   d88P
 8888888 888  888 888    888  "Y88888<PHONE_NUMBER>888P"  8888888P"

ts=2019-11-12T16:58:07.977413Z lvl=info msg="Connecting to meta service" log_id=0J48epWW000
ts=2019-11-12T16:58:07.977616Z lvl=info msg="Starting hinted handoff service" log_id=0J48epWW000 service=handoff
ts=2019-11-12T16:58:07.977672Z lvl=info msg="Registered diagnostics client" log_id=0J48epWW000 service=monitor name=hh
ts=2019-11-12T16:58:07.977696Z lvl=info msg="Using data dir" log_id=0J48epWW000 service=handoff path=
run: open server: open hinted handoff: mkdir all: mkdir : no such file or directory

@wgj thanks for opening this. I've reached out to the person who has been working on our helm charts to see what his thoughts are.
I've also reached out to the docs team to check on the hinted handoff directory question.

If a required directory is not specified in the config then InfluxDB will default to a path in the user's $HOME directory (equivalent code for OSS InfluxDB).
I suspect the hh directory is a blank in this case due to the Alpine-based Docker image, which has no user and no $HOME directory. Though it's better to explicitly set all directory paths (data, wal, meta, hh).

Deploy with a influxdb.conf that previously worked with InfluxDB OSS.

An OSS config is not equivalent to an Enterprise config. A better option would be to generate a new config file for Enterprise using the values in the OSS config as a base with influxd config -config oss-influxdb.conf.

@wgj We've recently migrated the InfluxData product charts out of helm/charts (which is being deprecated) into influxdata/helm-charts. I dropped you an email regarding this due to your contribution to the repository. Please let me know if you did not receive it.
Hopefully @gunnaraasen's answer helps you with your issue

@rawkode & @gunnaraasen Sounds good.
We're no longer exploring InfluxDB at this time, so I'm not in a position to try out @gunnaraasen's suggestions, but they seem reasonable enough to be shared in a more conspicuous place for anyone else using these images for Enterprise (presuming that's a supported use case).