DRAFT: Upload issues with Extended Fields

Draft

People had to follow different work flows to upload the same file

Mariel: format data in excel -> save as csv to a local folder -> upload to OAR -> "An error prevented uploading that file."

Natalie: format data in google sheets -> download as csv -> upload to OAR -> success

Moving excel CSV to Google sheets caused changes to formatting (headers became capitalized). Had to revert back to lowercase for it to be accepted.

Opened the excel-formatted CSVs in Text Edit and saw the following

In the SanMar data, there were quotation marks around some of the values but not others.

In the Scotch & Soda data, there were commas, usually four, at the end of some of the rows. Both data sets, as formatted in excel are attached.
Despite those formatting, both of these data sets when uploaded to GS, then re-downloaded as CSV then uploaded, worked.

Upload handling is much more sensitive than we expected it to be. This could be a huge challenge to users, who may use Excel or other applications to format their data.

Issues with the processing_type and facility_type fields:

processing_type is not accepting any types that are not explicitly listed in the taxonomy. Our understanding is that processing_type should accept any data and do a fuzzy match against the taxonomy. Any matches with taxonomy would be displayed, any other values would only be available on download.

When the processing_type column is removed altogether an error for facility_type values of "Main Production Site or Subcontractor/Processor" resulted in an error.

We understand that this is because, for facility_type, the intention is that system requires that it have an exact match in the taxonomy.
Related: OAR has requested information on whether they need to change to processing_type & facility_type fields (see discussion in Slack).

Potentially related Rollbar errors for reference:
https://rollbar.com/OpenApparelRegistry/OpenApparelRegistry/items/203/
https://rollbar.com/OpenApparelRegistry/OpenApparelRegistry/items/594/

Additional data uploads here: https://drive.google.com/drive/folders/162AQ5ryaGIeHKoIWAILq9jwt8ytjvreQ?usp=sharing

Hi @jwalgran,
As we discussed today, Hannah encountered an error when uploading another extended fields file.
It triggered the error seen in the attached screenshot.

The list she was working with is called: Outerknown 2021 Facility List. I downloaded it from the processing page (not the raw file), and that download is attached: 1468_Outerknown 2021 Facility List_2_18_2022.csv
I will also flag this for @hlennett so that she can provide the original file.

This was a user upload and was not a part of extended fields. Just a regular user uploading on prod, so we do not have the raw file. Here is a link to the list: https://openapparel.org/lists/1468?status=ERROR_PARSING&page=1&rowsPerPage=20

Here is another example of an excel file that would not upload to production (this was a regular upload, not for EP). Hannah took this file and saved as csv, then it successfully uploaded to staging.
Embedded Map CSV Template - boohoo.xlsx
@obrienad, @jwalgran, let me know if you'd like a separate ticket for non-EP upload issues. Adding here since it all seems to be a long the excel/csv thread.

Another error that came up when the Boohoo list (from previous comment) was uploaded to prod:

Adding to this ticket since it seems related to the other upload issues. lmk if you want me to create separate tickets. Thanks!

^ You can find that error here: https://openapparel.org/lists/1474?status=ERROR_PARSING&page=1&rowsPerPage=20


the example and tests seems too old now. not willing to run it.

?

Unclear and incomplete issue.


Improve user-details design for smaller screens

Currently, user details on dashboard don't look appealing on smaller screens.
https://user-images.githubusercontent.com/85152262/144739306-edc4205e-b805-4212-8028-5e6220cc7728.mp4
Describe alternatives you've considered
https://user-images.githubusercontent.com/85152262/144739329-79280440-bbd4-424f-8865-ab3be5e2c75c.mp4
Are you working on this? (Yes/No)
Yes

@nitin10s looking for your suggestions

Looks nice, we can move ahead with this proposed design 👍


fix: remove trailing slash

Fix #328

What kind of change does this PR introduce? (check at least one)

[x] Bugfix
[ ] Feature
[ ] Code style update
[ ] Refactor
[ ] Build-related changes
[ ] Other, please describe:

Does this PR introduce a breaking change? (check one)

[ ] Yes
[x] No

If yes, please describe the impact and migration path for existing applications:
The PR fulfills these requirements:

[x] When resolving a specific issue, it's referenced in the PR's title (e.g. fix #xxx[,#xxx], where "xxx" is the issue number)
[x] All tests are passing
[x] New/updated tests are included

If adding a new feature, the PR's description includes:

[ ] A convincing reason for adding this feature (to avoid wasting your time, it's best to open a suggestion issue first and wait for approval before working on it)

Other information:

Thanks, I ended up changing a little bit more on this one


TuxSuite's libelf.so is too old for zstd compressed debug sections

Android recently turned on CONFIG_DEBUG_INFO_COMPRESSED_ZSTD=y, which compresses the debug info sections with zstd. Unfortunately, this breaks the build in the containers that we use in TuxSuite (and TuxMake), which are based on Debian bullseye:
$ tuxmake -a x86_64 -k gki_defconfig -r podman -t llvm-18 default
...
libbpf: BTF header not found
pahole: .tmp_vmlinux.btf: Invalid argument
FAILED: load BTF from vmlinux: Invalid argument
...

This occurs because pahole (which is being invoked due to CONFIG_DEBUG_INFO_BTF=y) relies on libelf from elfutils, which only gained support for zstd compressed debug sections in 0.189. I can reproduce this on my host system if I install elfutils 0.188 (TuxMake's containers have 0.183) but not with elfutils 0.190.
I am not sure if it is reasonable to ask TuxMake to try and resolve this, as Debian only has 0.190 in the unstable distribution, which may cause issues with rebuilding images frequently because unstable is not always the most stable (figures :P). I can open an issue around it though.
I am not sure which is worth keeping enabled between CONFIG_DEBUG_INFO_COMPRESSED_ZSTD and CONFIG_DEBUG_INFO_BTF.
cc @nickdesaulniers

Let's disable CONFIG_DEBUG_INFO_COMPRESSED_ZSTD for now with a TODO + link back to this bug; we can re-enable it in the future for ci2.


"CSSValue X has to be a Y value" is logged despite using SilentCssErrorHandler

I use HtmlUnit 2.58.0 and the corresponding HtmlUnit web driver from Geb 4.1 on top of Selenium 3.141.59.
My custom WebClient sets a SilentCssErrorHandler inside overridden modifyWebClient. I actually was expecting this to silence log lines like
13:28:11.582 [main] WARN  c.g.h.j.host.css.CSSStyleSheet - CSSValue 'calc(544px - 0.02px)' has to be a 'px', 'em', '%', 'ex', 'ch', 'vw', 'vh', 'vmin', 'vmax', 'rem', 'mm', 'cm', 'Q', or 'pt' value.
13:28:11.587 [main] WARN  c.g.h.j.host.css.CSSStyleSheet - CSSValue 'calc(768px - 0.02px)' has to be a 'px', 'em', '%', 'ex', 'ch', 'vw', 'vh', 'vmin', 'vmax', 'rem', 'mm', 'cm', 'Q', or 'pt' value.
13:28:11.587 [main] WARN  c.g.h.j.host.css.CSSStyleSheet - CSSValue 'calc(1012px - 0.02px)' has to be a 'px', 'em', '%', 'ex', 'ch', 'vw', 'vh', 'vmin', 'vmax', 'rem', 'mm', 'cm', 'Q', or 'pt' value.
13:28:11.587 [main] WARN  c.g.h.j.host.css.CSSStyleSheet - CSSValue '0\0 ' has to be a 'px', 'em', '%', 'ex', 'ch', 'vw', 'vh', 'vmin', 'vmax', 'rem', 'mm', 'cm', 'Q', or 'pt' value.
13:28:11.597 [main] WARN  c.g.h.j.host.css.CSSStyleSheet - CSSValue 'calc(544px - 0.02px)' has to be a 'px', 'em', '%', 'ex', 'ch', 'vw', 'vh', 'vmin', 'vmax', 'rem', 'mm', 'cm', 'Q', or 'pt' value.
13:28:11.599 [main] WARN  c.g.h.j.host.css.CSSStyleSheet - CSSValue 'calc(768px - 0.02px)' has to be a 'px', 'em', '%', 'ex', 'ch', 'vw', 'vh', 'vmin', 'vmax', 'rem', 'mm', 'cm', 'Q', or 'pt' value.
13:28:11.599 [main] WARN  c.g.h.j.host.css.CSSStyleSheet - CSSValue 'calc(1012px - 0.02px)' has to be a 'px', 'em', '%', 'ex', 'ch', 'vw', 'vh', 'vmin', 'vmax', 'rem', 'mm', 'cm', 'Q', or 'pt' value.
13:28:11.599 [main] WARN  c.g.h.j.host.css.CSSStyleSheet - CSSValue '0\0 ' has to be a 'px', 'em', '%', 'ex', 'ch', 'vw', 'vh', 'vmin', 'vmax', 'rem', 'mm', 'cm', 'Q', or 'pt' value.
13:28:11.603 [main] WARN  c.g.h.j.host.css.CSSStyleSheet - CSSValue 'calc(544px - 0.02px)' has to be a 'px', 'em', '%', 'ex', 'ch', 'vw', 'vh', 'vmin', 'vmax', 'rem', 'mm', 'cm', 'Q', or 'pt' value.
13:28:11.603 [main] WARN  c.g.h.j.host.css.CSSStyleSheet - CSSValue 'calc(768px - 0.02px)' has to be a 'px', 'em', '%', 'ex', 'ch', 'vw', 'vh', 'vmin', 'vmax', 'rem', 'mm', 'cm', 'Q', or 'pt' value.
13:28:11.604 [main] WARN  c.g.h.j.host.css.CSSStyleSheet - CSSValue 'calc(1012px - 0.02px)' has to be a 'px', 'em', '%', 'ex', 'ch', 'vw', 'vh', 'vmin', 'vmax', 'rem', 'mm', 'cm', 'Q', or 'pt' value.
13:28:11.604 [main] WARN  c.g.h.j.host.css.CSSStyleSheet - CSSValue '0\0 ' has to be a 'px', 'em', '%', 'ex', 'ch', 'vw', 'vh', 'vmin', 'vmax', 'rem', 'mm', 'cm', 'Q', or 'pt' value.
13:28:11.607 [main] WARN  c.g.h.j.host.css.CSSStyleSheet - CSSValue 'calc(544px - 0.02px)' has to be a 'px', 'em', '%', 'ex', 'ch', 'vw', 'vh', 'vmin', 'vmax', 'rem', 'mm', 'cm', 'Q', or 'pt' value.
13:28:11.607 [main] WARN  c.g.h.j.host.css.CSSStyleSheet - CSSValue 'calc(768px - 0.02px)' has to be a 'px', 'em', '%', 'ex', 'ch', 'vw', 'vh', 'vmin', 'vmax', 'rem', 'mm', 'cm', 'Q', or 'pt' value.
13:28:11.607 [main] WARN  c.g.h.j.host.css.CSSStyleSheet - CSSValue 'calc(1012px - 0.02px)' has to be a 'px', 'em', '%', 'ex', 'ch', 'vw', 'vh', 'vmin', 'vmax', 'rem', 'mm', 'cm', 'Q', or 'pt' value.
13:28:11.608 [main] WARN  c.g.h.j.host.css.CSSStyleSheet - CSSValue '0\0 ' has to be a 'px', 'em', '%', 'ex', 'ch', 'vw', 'vh', 'vmin', 'vmax', 'rem', 'mm', 'cm', 'Q', or 'pt' value.
13:28:11.610 [main] WARN  c.g.h.j.host.css.CSSStyleSheet - CSSValue 'calc(544px - 0.02px)' has to be a 'px', 'em', '%', 'ex', 'ch', 'vw', 'vh', 'vmin', 'vmax', 'rem', 'mm', 'cm', 'Q', or 'pt' value.
13:28:11.610 [main] WARN  c.g.h.j.host.css.CSSStyleSheet - CSSValue 'calc(768px - 0.02px)' has to be a 'px', 'em', '%', 'ex', 'ch', 'vw', 'vh', 'vmin', 'vmax', 'rem', 'mm', 'cm', 'Q', or 'pt' value.
13:28:11.610 [main] WARN  c.g.h.j.host.css.CSSStyleSheet - CSSValue 'calc(1012px - 0.02px)' has to be a 'px', 'em', '%', 'ex', 'ch', 'vw', 'vh', 'vmin', 'vmax', 'rem', 'mm', 'cm', 'Q', or 'pt' value.
13:28:11.610 [main] WARN  c.g.h.j.host.css.CSSStyleSheet - CSSValue '0\0 ' has to be a 'px', 'em', '%', 'ex', 'ch', 'vw', 'vh', 'vmin', 'vmax', 'rem', 'mm', 'cm', 'Q', or 'pt' value.
13:28:11.616 [main] WARN  c.g.h.j.host.css.CSSStyleSheet - CSSValue 'calc(544px - 0.02px)' has to be a 'px', 'em', '%', 'ex', 'ch', 'vw', 'vh', 'vmin', 'vmax', 'rem', 'mm', 'cm', 'Q', or 'pt' value.
13:28:11.616 [main] WARN  c.g.h.j.host.css.CSSStyleSheet - CSSValue 'calc(768px - 0.02px)' has to be a 'px', 'em', '%', 'ex', 'ch', 'vw', 'vh', 'vmin', 'vmax', 'rem', 'mm', 'cm', 'Q', or 'pt' value.
13:28:11.617 [main] WARN  c.g.h.j.host.css.CSSStyleSheet - CSSValue 'calc(1012px - 0.02px)' has to be a 'px', 'em', '%', 'ex', 'ch', 'vw', 'vh', 'vmin', 'vmax', 'rem', 'mm', 'cm', 'Q', or 'pt' value.
13:28:11.617 [main] WARN  c.g.h.j.host.css.CSSStyleSheet - CSSValue '0\0 ' has to be a 'px', 'em', '%', 'ex', 'ch', 'vw', 'vh', 'vmin', 'vmax', 'rem', 'mm', 'cm', 'Q', or 'pt' value.
13:28:11.641 [main] WARN  c.g.h.j.host.css.CSSStyleSheet - CSSValue 'calc(544px - 0.02px)' has to be a 'px', 'em', '%', 'ex', 'ch', 'vw', 'vh', 'vmin', 'vmax', 'rem', 'mm', 'cm', 'Q', or 'pt' value.
13:28:11.641 [main] WARN  c.g.h.j.host.css.CSSStyleSheet - CSSValue 'calc(768px - 0.02px)' has to be a 'px', 'em', '%', 'ex', 'ch', 'vw', 'vh', 'vmin', 'vmax', 'rem', 'mm', 'cm', 'Q', or 'pt' value.
13:28:11.642 [main] WARN  c.g.h.j.host.css.CSSStyleSheet - CSSValue 'calc(1012px - 0.02px)' has to be a 'px', 'em', '%', 'ex', 'ch', 'vw', 'vh', 'vmin', 'vmax', 'rem', 'mm', 'cm', 'Q', or 'pt' value.
13:28:11.642 [main] WARN  c.g.h.j.host.css.CSSStyleSheet - CSSValue '0\0 ' has to be a 'px', 'em', '%', 'ex', 'ch', 'vw', 'vh', 'vmin', 'vmax', 'rem', 'mm', 'cm', 'Q', or 'pt' value.

in an otherwise successful test opening on https://github.com/trending, selecting the top 3 projects and opening their GH pages.

Hi Alexander,
the CssErrorHandler handles (mainly) errors found while parsing the css file. But this warning is a bit more different. The css is correct but HtmlUnit is not able to deal with this calc stuff and therefore reports this warning.
You can disable this using set the log level for HtmlUnit or for only the CSSStyleSheet class.
What do you think - maybe i have to change the text of the warning a bit or do you still think i should use the error handler here?
I know the best would be to support this calc stuff (and many more css thinks) but my time is limited. Maybe you like to help with stuff like this - PR's are always welcome.

OK, I think if I can programmatically define the log level for CSSStyleSheet in a generic way, that will be fine. As HtmlUnit uses Commons Logging, actually in my Geb configuration script (which is used in multiple project, each of which might use a different logging tool) I would like to set the log level. The Commons Logging API is not very helpful in determining which logging framework is detected and used by it during runtime and then setting the level there. So how can I do that? I know this is no longer a question specific to HtmlUnit, but because you suggested setting the log level, I would like to know.

@kriegaex What rbri means it to turn off the log level within your logging framework for that class or htmlunit in general.
Basically what this log is telling you is "this part is not 100% implemented, don't rely on it's execution when asserting your page".
So you could either set the logger for com.gargoylesoftware.htmlunit.javascript.host.css.CSSStyleSheet to ERROR or turn it off completely depending on the logging implementation you're using.
@rbri My personal opinion regarding this is that this should override the SilentCSSErrorHandler since it's not an error happening in CSS like it potentially would happen in a real browser but rather a limitation of the framework. On the other hand I don't even see a real use case for the 3 log levels in the CSSHandler - so one could potentially use warning for this 🤷

@twendelmuth, I know what rbri means and what the error means. I also know how to configure a logging framework. I just wanted to find a way to avoid configuring the framework in each of my applications and do it centrally in the module where HtmlUnit gets configured. But Commons Logging being a facade without its own means of setting the log level, this seems to be impossible.
@rbri, as for whether this kind of CSS warning should be captured by the SilentCssErrorHandler, let us take a look at the javadocs, shall we?
https://github.com/HtmlUnit/htmlunit/blob/d44dc2fc7610567c76232a96447f5b1d003073b4/src/main/java/com/gargoylesoftware/htmlunit/SilentCssErrorHandler.java#L23-L29
The "which ignores all CSS problems" made me believe that it would also capture (and suppress) warnings about limitations in HtmlUnit itself, as it is also a warning about CSS. If the javadoc would be improved in such a way as to help users understand that warnings about incomplete implementation are not captured by the handler and they need to configure their respecive logging frameworks for it, at least it would be clear. The problem from a user perspective is, however, that they use silent XY error handlers or listeners - the class names SilentCssErrorHandler vs SilentJavaScriptErrorListener are inconsistent here - and their test logs are still floodded with warnings they might not wish to see (like me), but HtmlUnit provides no handler or listener to suppress them and they have to silence them outside of the tool via their respective logging frameworks. While this is of course possible, it is just not nice and inconsistent with the user experience for other types of error/warning logging.

FWIW, because the module I am currently dealing with happens to be using Logback, I added this to me config file in the test resources:
<!--
  Avoid excessive logging of warnings about limitations in HtmlUnit's own CSS parser,
  see https://github.com/HtmlUnit/htmlunit/issues/446
-->
<logger name="com.gargoylesoftware.htmlunit.javascript.host.css.CSSStyleSheet" level="ERROR" />

I would be happy to be able to remove that in the future, if you would kindly consider to implement a specific handler (and a silent version of it) for those kinds of warnings. 🙂


[Bug Report] Some documentation still points to outdated repo

Describe the bug
Some of the documentation on the PaloAlto website still points to this repository https://github.com/PaloAltoNetworks/AWS-GWLB-VMSeries/tree/main
Since it hasn't received updates in several years, I'm guessing that this repo is what should be used for deploying the VM series firewalls in AWS. If it is deprecated can you update that README to point to this repository instead?
Module Version
latest
Terraform version
No response
Expected behavior
No response
Current behavior
No response
Anything else to add?
No response

Hi @shadycuz 👋🏽 Thanks for pointing this out. Can you please drop a link to the page(s) where you found the wrong references?

@migara From this page https://docs.paloaltonetworks.com/vm-series/11-0/vm-series-deployment/set-up-the-vm-series-firewall-on-aws/vm-series-integration-with-gateway-load-balancer/vm-series-auto-scaling-group-with-gateway-load-balancer
Look for: "Download the CloudFormation templates from the Palo Alto Networks GitHub Repository."
Perhaps that repo is still valid for Cloudformation but that was how I stumbled upon that old Terraform.


fetchStart and fetchError missing

Hello,
Why there isn't fetchStart and fetchError on the axios reducer?
Regards.

I'm not sure what you're asking. Can you provide more details?

Sorry, Matt, I made a mistake, the issue is for redux-crud, not axios.

No problem. Are we okay to close the issue?

Sure
2015-10-27 21:56 GMT+01:00 Matt Zabriskie<EMAIL_ADDRESS>
No problem. Are we okay to close the issue?
—
Reply to this email directly or view it on GitHub
https://github.com/mzabriskie/axios/issues/134#issuecomment-151641201.

--
Jacques Bonet
res Margaut, app 44
411 cours de la Liberation,
33400 Talence
France
✆ +33 6 35495090
✉<EMAIL_ADDRESS>


[dev] Add type support

The same as in #524 but with tests
PR made on dev branch.

Thanks :thumbsup:


[preview] metrics: add of to the instrument builders

Closes https://github.com/typelevel/otel4s/issues/432.
Usage
val longCounter: F[Counter[F, Long]] = Meter[F].counter("name").create
val doubleCounter: F[Counter[F, Double]] = Meter[F].counter("name").of[Double].create

Alternative
See #449.

Because this is working in terms of implicits, if I understand correctly a user could contramap a derived MeasurementValue[Foo] and do something like:
Meter[F].counter("name").of[Foo].create

Because this is working in terms of implicits, if I understand correctly a user could contramap a derived MeasurementValue[Foo] and do something like:
Meter[F].counter("name").of[Foo].create

Yes. P.S. you can do exactly the same here: https://github.com/typelevel/otel4s/pull/449

Closing in favor of #449.


Update manage-deployment.md

If you created the resource (on your local minikube) as instructed using:
kubectl create -f https://k8s.io/docs/concepts/cluster-administration/nginx-app.yaml
then, you probably want to delete it from your minikube in the same way, in that case, the correct command is the one proposed in this PR (it replaces a command that does not work out of the box).

I have signed the CLA...

/assign
(minikube rework docs)

Looks good from a writer standpoint, but still needs technical review
/approve
/assign @janetkuo

/lgtm


Show a custom screen when an app cannot be loaded due to an injection

Description
Currently when an injected url is opened we saw a generic screen as if there was a problem with the app. We need to implement a case for the scenario where an injection is detected in order to give the user a more specific warning.
Steps to reproduce
Open: https://gnosis-safe.io/app/rin:0x91dB860c37E83dab0A4A005E209577E64c61EEfA/apps?appUrl=javascript:startHack()
Expected result
Show a screen with a more specific warning.
Obtained result

This was already solved


docs update lakesoul usage doc

What problem does this PR solve?
Issue Number: close #xxx
Related PR: #xxx
Problem Summary: update start_doris_client.sh for distinguishing doris client and mysql client
Release note
None
Check List (For Author)

Test

[ ] Regression test
[ ] Unit Test
[ ] Manual test (add detailed scripts or steps below)
[ ] No need to test or manual test. Explain why:

[ ] This is a refactor/code format and no logic has been changed.
[ ] Previous test can cover this change.
[ ] No code files have been changed.
[ ] Other reason

Behavior changed:

[ ] No.
[ ] Yes.

Does this need documentation?

[ ] No.
[ ] Yes.

Check List (For Reviewer who merge this PR)

[ ] Confirm the release note
[ ] Confirm test cases
[ ] Confirm document
[ ] Add branch pick label

run buildall


Clarification on GPU Accelerated compute

Hi,
If i go with NCasT4_v3-series of bigger GPU, vCPU and memory, can I be able to run the 2.8b param model.

Is GPU memory 16GiB works or need to go more than that?
please let me know, I am confusion on this configuration to use.

T4 has 16GB of GPU mem. That should be plenty to load the 2.8B param model in 16-bit (5.6GB GPU mem). This is not specific to this model.


Get rid of copy-paste bugs in readme

I don't think you want to point to marathon and docker, do you? :)

Hi Florian, thanks the cleanup! You are right, this wasn't supposed to be in the Readme :)


[FEATURE 💡] Cart Functionality

Description
Add cart Functionality to the website. Use dummy json data for reference
Screenshots
No response
Additional information
Make sure to read the CONTRIBUTING and SETUP docs before proceeding
Happy contributing. 💐
Star my other Repositories here

can we do something with local data and then local storage seems to be the only solution now.

yes sure, do you have any dummy data?

Can you create a dummy data for now.

cool, please assign


npm i on frontend depreciated modules

$ npm i
npm WARN deprecated<EMAIL_ADDRESS>Chokidar 2 will break on node v14+. Upgrade to chokidar 3 with 15x less dependencies.
npm WARN deprecated<EMAIL_ADDRESS>request has been deprecated, see https://github.com/request/request/issues/3142
npm WARN deprecated<EMAIL_ADDRESS>request-promise-native has been deprecated because it extends the now deprecated request package, see https://github.com/request/request/issues/3142
npm WARN deprecated<EMAIL_ADDRESS>fsevents 1 will break on node v14+ and could be using insecure binaries. Upgrade to fsevents 2.
npm WARN deprecated<EMAIL_ADDRESS>joi is leaving the @hapi organization and moving back to 'joi' (https://github.com/sideway/joi/issues/2411)
npm WARN deprecated<EMAIL_ADDRESS>this library is no longer supported
npm WARN deprecated<EMAIL_ADDRESS>Please see https://github.com/lydell/urix#deprecated
npm WARN deprecated<EMAIL_ADDRESS>This version has been deprecated and is no longer supported or maintained
npm WARN deprecated<EMAIL_ADDRESS>This version has been deprecated and is no longer supported or maintained
npm WARN deprecated<EMAIL_ADDRESS>This version has been deprecated and is no longer supported or maintained
npm WARN deprecated<EMAIL_ADDRESS>This version has been deprecated and is no longer supported or maintained
npm WARN deprecated<EMAIL_ADDRESS>https://github.com/lydell/resolve-url#deprecated
npm WARN deprecated<EMAIL_ADDRESS>use String.prototype.padStart()
npm WARN deprecated<EMAIL_ADDRESS>core-js@<3 is no longer maintained and not recommended for usage due to the number of issues. Please, upgrade your dependencies to the actual version of core-js@3.

<EMAIL_ADDRESS>postinstall C:\Users\Hoku\Documents\PublicGitSite\FastAPI-React-GitSignUp-Branch\fastapi-react{{cookiecutter.project_slug}}\frontend\node_modules\babel-runtime\node_modules\core-js
node -e "try{require('./postinstall')}catch(e){}"

I can fix this one tomorrow if you'd like.

I'm pretty sure this is a create-react-app problem.  The dependencies are up to date as far as I know (with dependabot they're kept up to date).


Feat: Auto-detection for current user locationf, Enhancement: Search dialog auto-close on choosing a location

Description
Currently, the default location is always Oxford, the user experience would be much better if SkyCast detected the user's location automatically rather than them having to search for it.  Implemented this using the geolocation api that works on pretty much all browsers, should not cause any issues and should work perfectly fine with the existing code.
Secondly, the search dialog box does not close once the user has selected a location, added a listener to close it once a new setActiveCityCoords are set.
Type of change

[ ] New feature (non-breaking change which adds functionality)

Checklist:

[x] My code follows the style guidelines of this project
[x] I have performed a self-review of my own code
[x] I have commented my code, particularly in hard-to-understand areas
[x] I have made corresponding changes to the documentation
[x] My changes generate no new warnings
[x] I have added tests that prove my fix is effective or that my feature works

Merge conflicts exist as I did not clone the latest version of the app, as it has a bug which was not present yesterday. Opened an issue for the same.


add noise spec compliant rekey functionality

Greetings,
As per noise spec section 4.2 there ought to be a rekey function defined as:
"""REKEY(k): Returns a new 32-byte cipher key as a pseudorandom function of k. If this function is not specifically defined for some set of cipher functions, then it defaults to returning the first 32 bytes from ENCRYPT(k,    maxnonce, zerolen, zeros), where maxnonce equals 264-1, zerolen is a zero-length byte sequence, and zeros is a sequence of 32 bytes filled with zeros.
"""
I am currently using snow to write a mixnet link layer wire protocol and our design requires this rekey functionality. I have found that with the current snow API it is NOT possible to implement this rekey functionality externally in my own library because the snow Session's write_message_with_nonce method only allows being called when in StatelessTransport mode.

As an example, here's the golang noise library's implementation of this rekey function:
https://github.com/flynn/noise/blob/master/state.go#L65-L71

https://docs.rs/snow/0.4.0/snow/enum.Session.html#method.rekey should make it possibly to implement this in the client code, no? I think the rekey API you cited in the docs is new and will be something to target for snow 0.5 perhaps.


Increase version

Last month I made some changes but forgot to set the version. Recently I wondered if the changes are contained in the current venv, a proper version would have helped me.
I am doing this as a pull request to get feedback. I am not sure about some things:

is it even ok to set the version?
do I have to insert something into the changelog? I would prefer not to maybe only for important changes, the regarding pr's where more like bugfixing I think.
I think next time I should merge the pull request(s) and before committing set the version (and add to changelog?). Is that the right way to set the version?
set version to 0.1.0 instead of 0.0.2? I know about semantic versioning (breaking change, backwards compatible new Features, bugfixes) but I often wonder if I am correct.

is it even ok to set the version?

Sure, releases are a good thing.

do I have to insert something into the changelog? I would prefer not to maybe only for important changes, the regarding pr's where more like bugfixing I think.

If you create a new release, always add a section to the CHANGELOG.md describing what has Changed, Fixed, Added or Removed. Even if it is small stuff like typos, it's important to document. The CHANGELOG.md is the best way to understand the development of a project, cleaner and more succinct than git log.

I think next time I should merge the pull request(s) and before committing set the version (and add to changelog?). Is that the right way to set the version?

As a rule, I would only ever change the version after merging a pull request:
git merge some-branch
$EDITOR ocrd-tool.json CHANGELOG.md
# increment version number i ocrd-tool.json, describe changes in CHANGELOG.md
git commit -m ':package: vX.Y.Z'
git tag vX.Y.Z
git push
git push --tags

# twine lets you easily upload to PyPI
python setup.py sdist bdist_wheel
twine upload dist/*X.Y.Z*

Now go to GitHub landing page of the repo -> Releases -> Create new release -> From Tag -> vX.Y.Z. Copy the new section of the CHANGELOG.md into the description and release
Now the new version is available in GH and PyPI.

set version to 0.1.0 instead of 0.0.2? I know about semantic versioning (breaking change, backwards compatible new Features, bugfixes) but I often wonder if I am correct.

Semantic Versioning does not apply to v0.* because this is considered a pre-release. Once you hit v1.0.0, these differentiations matter.
If the release only contains Fixed or Changed: patch release, unless the changes are significant
If the release contains Added: New minor version
If the release contains Removed: New major version.

This pull request should have been an issue. Version setting will be done when merging. Thus closing it.


saddle-points: add canonical data

Closes #582.
Notes:

Per https://github.com/exercism/discussions/issues/41, the row/column identification tests found in several tracks represent testing intermediate implementation details and should be removed.
Larger matrices have been removed from the tests; they did not exercise anything that was not already covered (except possibly for differing matrix dimensions?)
Readme example is included as the first exercise; the majority of tracks already test this and it's a nice start point.
Empty example is included; only a few tracks currently test this, but it's a nice boundary case.
Multiple saddle points test uses the more-common matrix as found in e.g. xcsharp. xpython and xscala will need to update their multiple saddle points tests.
Example with saddle point in the lower right matrix entry has been added to check for off-by-one errors. This is new for all tracks.
Example with no saddle points has been expanded from 2x2 matrix to 3x3 matrix to give implementers more of a hint as to how one might go about constructing such a matrix. This is new for all tracks.
No check for invalid matrix size is included in the canonical suite; can be included if desired, in which case I'll pull the xpython input for that test.

Thanks for your work on this @stkent


fix: changed the error message and redirect theuser to 'email account list'

Task: https://bloomstack.com/desk#Form/Task/TASK-2020-01524

Pull Request Test Coverage Report for Build 1016

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage decreased (-51.9%) to 0.0%

Totals

Change from base Build 1015:
-51.9%

Covered Lines:
0

Relevant Lines:
0

💛  - Coveralls


Bump notebookscripter support to version 6.0.0

Checklist

[X] Used a fork of the feedstock to propose changes
[X] Bumped the build number (if the version is unchanged)
[X] Reset the build number to 0 (if the version changed)
[ ] Re-rendered with the latest conda-smithy (Use the phrase @conda-forge-admin, please rerender in a comment in this PR for automated rerendering)
[X] Ensured the license file is being packaged.

HUGE APOLOGIES for incorrectly updating this repository by pushing directly to the master branch!  That was a mistake in protocol on my part and will not do that again!  I reverted the change made directly to master -- and am re-proposing this change in a PR which bump's package version to 6.0.0.

Hi! This is the friendly automated conda-forge-linting service.
I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.


Global Action for Admin Duties

More data to follow once notes are obtained.

Admin Duties Solution:
First, create a picklist field under Activity object named Admin Duties with the following values:
   Meeting Attended
   Presentations/Briefs
   Trainings Attended
   Newsletter
   Social Media Maintenance
   Other Duties

Next, create a global quick action so users can access it from anywhere on Lightning with the target object: Task and action type: Create a Record. The following data are collected and added to the global action layout:
Admin Duties (Picklist)
Assigned to (User)
Subject
Due Date
Time Spent
Status
Priority
Comments

Once saved, add 'Admin Duties' to the publisher layout.
For reporting, create a custom report type of 'Users with Activities' and add 'Admin Duties' on the Users report field layout. Users will be able to select and report on fields found on the global quick action form.
Joanah's Notes <3

Don't need a custom report type. Just making a Tasks and Events report filtered to any that have a value in Admin Duties. Saving that in the OCC reports folder.


Running background task from manage.py fails

Running python manage.py qcluster to run all background tasks fails.

Please include the error


Mattermost moving to API version 4

Hey @ultrabug!
First, hugely appreciate you sharing this project back with the world. Fantastic work!
I wanted to let you know about our plans moving to API v4:
To make the Mattermost API web service easier to use and to offer more powerful options for these integrations, Mattermost will be moving to a new API version soon.  Highlights include:

Fully documented API endpoints
More in-depth access to server functionality
Wider use of established HTTP verbs
Consistent endpoint structures
A new and improved Go driver

We plan to release API version 4 on March 16th, with Mattermost server 3.7.  While the current API version 3 will be supported until September 16th, we recommend you begin using API version 4 soon after its release.
Contributing
API version 4 is an active and on-going project. If you're interested in helping contribute, please join our Mattermost community instance and the APIv4 channel.
We've prepared a contribution process for APIv4 and a progress tracker for new APIv4 enpoints to help you get started.
We're also open for suggestions on adding new API endpoints to help with your integration.

Thanks a lot for the heads up @jasonblais it's very appreciated.
I'll look into it soon then 👍 congratz on the new release !

AFAIK this API migration did not impact matterhook, closing


question about gt centerline?

Hi, I noticed the centerline gt was generated by left_lane and right_lane in "LaneSegmentParameterized3D",  what is the difference between original gt centerline and the re-generated centerline?
centerline = (left_line + right_line) / 2.0

When comparing the original GT centerline to the re-generated one without interpolation, they appear to be identical.
However, if we interpolate the left_line and right_line to increase the number of points, there may be a slight difference between the original GT centerline and the re-generated one. Furthermore, it's worth noting that this process is significantly faster than the actual interpolation itself.

Thanks for your answer!


IPython notebook/Jupyter notebook support

In some sense, an IPython/Jupyter notebook is Recipy's biggest competition, although the problems addressed are slightly different.
Related to #65.

Py.test plugin for validating Jupyter notebooks: https://github.com/computationalmodelling/nbval (might be helpful)
Demo that was presented at collaboration workshop, good way to quickly learn more about nbval
https://github.com/owlas/nbval-demo

The sort of thing that might be useful here is:

A very easy to way to start a new recipy 'run' partway through a notebook

A proper way to store the code from a notebook: the code in nb cells tend to change a lot, and often the changes aren't committed - not sure how this is dealt with currently.

Some nice IPython magic commands to do recipy-related things (%annotate or %newrun and so on)


Use query from http types

https://github.com/http-rs/http-types/issues/154

I don't believe I am doing the "right" thing here. I was expecting some tests to fail locally.
I will have a deeper look tomorrow.


⚠ Jenkins Plugins Artifactory has degraded performance

In d4e4d56, Jenkins Plugins Artifactory (https://get.jenkins.io/plugins/artifactory/) experienced degraded performance:

HTTP code: 200
Response time: 1267 ms

Resolved: Jenkins Plugins Artifactory performance has improved in 425f254 after 1 hour, 14 minutes.


Rock, Paper & Scissors Game

Aim

Rock, Paper & Scissors Game

Details

The Goal is to create a command-line game where a user is given a chance to choose between rock, paper, and scissors and if the user wins the score is added, and at the end when the user finishes the game the score is shown to the user.

plss assign me this issue @avinashkranjan sir

plss assign me this issue @avinashkranjan sir

Assigned to you  @Ayush7614

Assigned to you  @Ayush7614

Okk No Problem sir @avinashkranjan

Okk No Problem sir @avinashkranjan


Incorrect formula for mutation size

In mutateNormal, the mutation_range is handled strangely; the resulting formula is originalValue-0.5 + random() * mutation_range  (clamping omitted for clarity).  The result of this is that when mutation_range is small, every mutated value is reduced to the range [0, mutation_range] within a couple of generations.  A more appropriate formula would be originalValue + (random() - 0.5) * mutation_range so that the resulting distribution stays centered at originalValue when unclamped.

Not sure if this is related, but something seems off with the simulation. After a while, a whole bunch of the cars seem to share the exact genes, so much so, that you can't make out individual profiles further down the track (they're all interacting the exact same way with the environment with regards to their wheel size, wheel mass, body shape, etc) - in other words, half the cars look like one car.


cloned version string is not conforming to PEP-0440 causing update problems

I noticed and mentioned before that the version string, as manufactured when installing via git clone,  is not conforming to PEP-0440 standard. This is creating update problems as pip thinks the package is always out-of-date and would "update" to an older version.
I ask the developers not to be lazy to use version strings with the HEAD hash as is done here:
# If this version of binwalk was checked out from the git repository,
# include the git commit hash as part of the version number reported
# by binwalk. However, this version do not confirm to PEM-0440, and
# will cause warnings and be marked as outdated by pip.
try:
    label = subprocess.check_output(["git", "rev-parse", "--short", "HEAD"], stderr=DEVNULL).decode('utf-8')
    MODULE_VERSION = "%s-%s" % (MODULE_VERSION, label.strip())

This is just bad So I suggest we use a conforming string as 2.1.2dev1 or so.
The badness is that pip is not working correctly with non-PEM conforming version strings, without my PR in #376. You would get thing like this:
# pip uninstall binwalk
Cannot uninstall 'binwalk'. It is a distutils installed project and
thus we cannot accurately determine which files belong to it which
would lead to only a partial uninstall.

# Instead use:
# sudo python3 setup.py uninstall

/usr/lib/python3.6/site-packages/setuptools/dist.py:479:
UserWarning: The version specified ('2.1.2-c55cb3f') is an invalid version,
this may not work as expected with newer versions of setuptools, pip, and PyPI.
Please see PEP 440 for more details.
  "details." % self.metadata.version
running uninstall
removing '/usr/lib/python3.6/site-packages/binwalk' (and everything under it)
removing 'b'/usr/bin/binwalk''

# And then need to do:
rm binwalk-2.1.2_f31a06c-py3.6.egg-info

and
# pip list --outdated
Package    Version       Latest     Type
---------- ------------- ---------- -----
binwalk    2.1.2-c55cb3f 2.1.0      sdist

Holding for new PR from @E3V3A .


Other sizes of data (group size and Endianness)

I frequently have to dump data files (ADC output, for example) that don't just have byte-oriented data.  It would be nice to be able to specify data width in the dump so I get the hex data grouped in the natural data size instead of having to do the little-endian two-step and mentally group indistinguishable bytes by 2 or 4 or whatever.  Something like:
--word-size=1 (uint8_t, default)
--word-size=2 (uint16_t)
--word-size=4 (uint32_t)
--word-size=8 (uint64_t)
--word-size=16 (uint128_t)
That covers the common-ish types.
Not all such data is little-endian, so an extra flag for those cases where word-size > 1 would be:
--little-endian (default)
--big-endian
Also, interpretation could be signed or unsigned
--signed
--unsigned (default)
Of course with this you'd drop the byte-oriented colouration (but maybe with --signed you'd highlight negative numbers in red or something).

Thank you for the feedback.
It's not entirely clear to me what the output would look like.
Say I choose --word-size=2 (uint16_t) and the input contains 0xAB 0xCD 0x12 0x34. Would you like to see
CDAB 3412

for --little-endian?

That's pretty much exactly what I was picturing, yes.

This looks similar to xxds -groupsize option if I am not mistaking:
       -g bytes | -groupsize bytes
              Separate the output of every <bytes> bytes (two hex characters or  eight
              bit-digits  each)  by  a whitespace.  Specify -g 0 to suppress grouping.
              <Bytes> defaults to 2 in normal mode, 4 in little-endian mode and  1  in
              bits mode.  Grouping does not apply to postscript or include style.

I recently came across this when reading this blog post which makes use of -g to inspect ELF64 executables.

It is simpler to -g and -e in xxd, yes, but I'm not a huge fan of their nomenclature and their rather bizarre default assumptions.  (Like the bizarre assumption that "normal" is big-endian, which hasn't been "normal" for decades now.)  I can understand, perhaps, that you might want to keep it compatible for easier transition for users, though, so I'm only going to express a mild preference for breaking free from it.

@RinHizakura If you find the time, could you maybe summarize what is and what is not possible with your new option in #170? (released today)

The new option --group-bytes will provide the functionality to group multiple octets as a unit, which means that several bytes will be shown together without whitespace. It is quite similar to the option -groupsize in xxd, however, the possible group size should only be 1, 2, 4, or 8 currently.

I think this limitation fine for now. 16 would probably be nice, but I understand that it probably interferes with --panels.

On the other hand, this could only be shown in the big-endian format. The little-endian dump is not supported now.

Right. I agree with @ACleverDisguise that this would be a really nice feature to have. So let's keep this ticket open for now.

I think the main functionality requested in this ticket is now supported with #189 by @RinHizakura now also merged.


replace unsightly perl code

Category

[ ] fzf binary
[ ] fzf-tmux script
[ ] Key bindings
[ ] Completion
[ ] Vim
[ ] Neovim
[x ] Etc.

OS

[ ] Linux
[ ] Mac OS X
[ ] Windows
[ ] Etc.

Shell

[x ] bash
[ ] zsh
[ ] fish

in https://github.com/junegunn/fzf/wiki/Examples#with-write-to-terminal-capabilities, function writecmd is written in Perl. It can be written in a much cleaner way and even better if it is acceptable to have two functions. 'writecmd' and 'runcmd', can be written as below.
runcmd (){ perl -e 'ioctl STDOUT, 0x5412, $_ for split //, <>' }

writecmd (){ perl -e 'ioctl STDOUT, 0x5412, $_ for split //, do{ chomp($_ = <>); $_ }' }

Hi, I didn't add/test the example. If you think you can improve it, feel free to update it. Thanks.

example updated

Thanks.


Client.get_event_tradeables() not returning names for some golf events

the /events/{event_id}/tradeables endpoint does not provide entity information. In order to pull this information, the sdk would have to make a request for each tradeable in the event to /entites/{entity_id}.
The developer finds this wasteful, the user should:
client = Client(secret, api_key) event = client.get_event(event_id) tradeables = event.tradeables


[move-prover] Flag for running experimental pipeline

Motivation
Added a flag to run an experimental verification pipeline. This allows for easier benchmarking of experimental pipelines.
Have you read the Contributing Guidelines on pull requests?
Yes

Looks good to me. If it simplifies the code in lib.rs, you could make the experimental flag work only for v2. The non-v2 path will disappear eventually anyway.

I'll keep it as it is for now. Just one extra if statement at the time, easy to remove when non-v2 is taken out.

/land

:broken_heart: Test Failed - ci-test-success

/land


Crash after soft body point assigned to an AnimationPlayer node

Issue description:

Expected a warning
Steps to reproduce:
if you have an attachment point of a capsule shaped soft body and you assign an animation player to that spatial attachment path Godot will instantly crash

@lennyco Please upload a minimal reproduction project to make this easier to troubleshoot.

Closing due no reply from OP


FEAT: add feedback from cli to remind that failed transactions are not listed in voyager

Now, if you send a transaction from the CLI (deploy or invoke), nile will show a message with the tx hash (and the new contract address).
If the transaction fails, it wont be included in a block (unlike ethereum), so the user can get stuck waiting for voyager to list it.
Maybe it would be a good idea to add some feedback for this? Like the url to the feeder gateway? Ex:
https://alpha4.starknet.io/feeder_gateway/get_transaction_receipt?transactionHash=0x6efdae890498b61c275785d5d85e40f0f30f385bce9f6436ef720591573b4dd

The hint could be executing this from console (from starknet cli):
starknet tx_status --hash TRANSACTION_HASH --network=NETWORK


cloudflare_ip_ranges doesn't return up to date values

Confirmation
My issue isn't already found on the issue tracker.
I have replicated my issue using the latest version of the provider and it is still present.
Terraform version
Terraform v0.14.5
Affected resource(s)

cloudflare_ip_ranges

Terraform configuration files
data "cloudflare_ip_ranges" "cloudflare" {}
output "cloudflare_ips" {
value = data.cloudflare_ip_ranges.cloudflare.ipv4_cidr_blocks
}
Debug output
No response
Panic output
No response
Expected output
// https://www.cloudflare.com/ips-v4
<IP_ADDRESS>/20
<IP_ADDRESS>/22
<IP_ADDRESS>/22
<IP_ADDRESS>/22
<IP_ADDRESS>/18
<IP_ADDRESS>/18
<IP_ADDRESS>/20
<IP_ADDRESS>/20
<IP_ADDRESS>/22
<IP_ADDRESS>/17
<IP_ADDRESS>/15
<IP_ADDRESS>/13
<IP_ADDRESS>/22
<IP_ADDRESS>/13
<IP_ADDRESS>/14
Actual output
cloudflare_ips = [
+ "<IP_ADDRESS>/22",
+ "<IP_ADDRESS>/22",
+ "<IP_ADDRESS>/22",
+ "<IP_ADDRESS>/12",
+ "<IP_ADDRESS>/18",
+ "<IP_ADDRESS>/22",
+ "<IP_ADDRESS>/18",
+ "<IP_ADDRESS>/15",
+ "<IP_ADDRESS>/13",
+ "<IP_ADDRESS>/20",
+ "<IP_ADDRESS>/20",
+ "<IP_ADDRESS>/20",
+ "<IP_ADDRESS>/22",
+ "<IP_ADDRESS>/17",
]
Steps to reproduce

Output values fetched via cloudflare_ip_ranges data source
Returned ips do not match those presented on Cloudflare's website

Additional factoids
No response
References
No response

Although the IP list URLs are defined the source code:
const (
	urlIPV4s = "https://www.cloudflare.com/ips-v4"
	urlIPV6s = "https://www.cloudflare.com/ips-v6"
)

They don't actually appear to be used. I think that's probably old code that could be removed.
The data source actually queries the CloudFlare API for the IP list, which you can see here: https://api.cloudflare.com/client/v4/ips
The CloudFlare API is still returning the old IP list at this time. I believe as soon as the CloudFlare API starts returning the updated list, this Terraform provider will also.

@markbaird is correct; new IPs were added to the endpoints and it hadn't refreshed yet. This isn't a bug in Terraform and the service teams have mentioned this should be rectified by now.

It's not actually rectified yet in the CloudFlare API. As of this post time, the CloudFlare API is still returning the old IPs.

👍 thank you

The Cloudflare API, and subsequently this Terraform provider, are now returning the new IP list.


Do not perform superfluous bounds checks on dropping crossbeam-epoch::Bag

Addresses this comment that I didn't get a chance to act upon before merging #414.
This way bounds checks should be performed only once. However, this does not measurably impact benchmarks.

Thanks!
bors r+


If you register multiple systems with same name odd stuff happens

In slide-rs/specs/pull/120 I added test that registers multiple systems that modify component and a system that should be executed after modification that reads the components value.
The registered components all have same name as I thought it would allow me to specify that read happens after all of them.
Apparently multiple systems with same name doesn't work like that as HashMap from the name to system ID is used, which means that only the last same-named system is considered and the others are unnameable.
Is this how it should work or just oversight? If it's how it's supposed to work, it should be documented.

IIRC it should panic. I'll check in a few minutes.

Seems this is a bug introduced with #33.

Okay. How should I create 255 of the same system and 1 system that has to run after them all for the test?

So the last system has to wait for all of them?


Prevent updating values in cache when they do not change

cc @iwiznia @tgolen
Details

There are many cases where we are updating values in the cache that have not changed
We are also triggering updates to components when the values have not changed
That leads to unnecessary re-renders and writing to storage data that is basically already there
Yeah, we are using isEqual() whenever writing data - which seems like it would be "inefficient", but the savings from avoiding re-renders appear much greater than any performance hit caused by the value equality check.

Related Issues
https://github.com/Expensify/Expensify/issues/230464
Automated Tests
Added some automated tests to show that we will prevent updates when the values don't change.
Linked PRs
TODO, but the changes can be tested against main
Benchmarks
While timing a switch_report event on Android these are some before and after readings
Screenshots
Android

Before
DEBUG  Timing:expensify.cash.switch_report.cold 6078
DEBUG  Timing:expensify.cash.switch_report.cold 6699
DEBUG  Timing:expensify.cash.switch_report.cold 7158
DEBUG  Timing:expensify.cash.switch_report.cold 7359
DEBUG  Timing:expensify.cash.switch_report.cold 7606
After
DEBUG  Timing:expensify.cash.switch_report.cold 2850
DEBUG  Timing:expensify.cash.switch_report.cold 2872
DEBUG  Timing:expensify.cash.switch_report.cold 3051
DEBUG  Timing:expensify.cash.switch_report.cold 3218
DEBUG  Timing:expensify.cash.switch_report.cold 3372
iOS

Before
DEBUG  Timing:expensify.cash.switch_report.cold 1708
DEBUG  Timing:expensify.cash.switch_report.cold 1724
DEBUG  Timing:expensify.cash.switch_report.cold 1739
DEBUG  Timing:expensify.cash.switch_report.cold 1631
DEBUG  Timing:expensify.cash.switch_report.cold 1656
After
DEBUG  Timing:expensify.cash.switch_report.cold 1176
DEBUG  Timing:expensify.cash.switch_report.cold 1134
DEBUG  Timing:expensify.cash.switch_report.cold 1098
DEBUG  Timing:expensify.cash.switch_report.cold 1135
DEBUG  Timing:expensify.cash.switch_report.cold 1092
Web

Before
Timing:expensify.cash.switch_report.cold 297
Timing:expensify.cash.switch_report.cold 276
Timing:expensify.cash.switch_report.cold 281
Timing:expensify.cash.switch_report.cold 278
Timing:expensify.cash.switch_report.cold 284
After
Timing:expensify.cash.switch_report.cold 186
Timing:expensify.cash.switch_report.cold 188
Timing:expensify.cash.switch_report.cold 186
Timing:expensify.cash.switch_report.cold 180
Timing:expensify.cash.switch_report.cold 185

Tested on iOS, Android, and Web and updated the switch_report metrics in the description. Going to take this out of draft.

Updated and using the fast-equals package instead of underscore. Going to have to re-test to make sure everything is still working after that (but I think it should be pretty much the same).

re-tested and ready for another review whenever 🙇

@PauloGasparSv @iwiznia all yours


Allow custom runner agent IAM role

Description
Closes #571
Migrations required
NO
Verification
Verified in my local environment

Please can yu have a look on the failing CI?

Sorted, thanks


Some extension methods to write Rule Engine using Dynamic Expressions.

Hi Everyone,
I was just trying to come up with some kind of rule engine for the customer-specific requirements in SaaS Model. So I wrote some extension methods around this Library. Can you guys suggest me if, I am doing this in right way or not?
dynamic_expression.cs

Can you explain more how you would use this?

I apologies for delayed response. What I would do is i'll create an Example Project this weekend for Usages of Extension Methods(so called Rule Engine :)). We are already using it heavily in one of our ERP Project.
Above link is broken and here is updated gist with new link dynamic_expression.cs

@mukeshrebari any update on this, or can this issue be closed?

Hi Stef Heyenrath, I know it took so long to reply but finally i have prepared demo project to showcase how we are using your wonderful  library.
here is the link of DemoProject

@mukeshrebari I've created a PullRequest on your example project which uses this project (System.Linq.Dynamic.Core) instead of the custom DynamicLinq.cs file.
I'm closing this issue now because your project is a custom extension which can be useful, but it's not really related to the common or core functionality from this project.


extend Sampler urlMap with parameters for loopStart, loopEnd and transpose

I am working on a library to easily transfer Ableton Live data to Tone.Js and Web Audio. If some extra parameters are added to the Sampler file mapping, this would make things a lot easier to transport data from Ableton Drum Racks, Simplers and Samplers.
As a first step, I have an Ableton Drum Rack in mind. I assign different samples to different notes next to each other,  C1 is kick, C#1 is a stick, D1 a snare drum, etc. But then I want to pitch up my snare sample, for instance: the snare is always on the D1, but I want the original sample to sound 3 semitones higher, every time, and of course I might have a tom sample on the F1, which has nothing to do with the fact that the snare on D1 is pitched up 3 semitones. It is a technique that I use a lot in Ableton, cut out short samples from another track and transpose it to another pitch, to make completely new sounds with it. It would be nice to transfer it very easily to Web Audio with something like this:
Tone.Sampler.new('C1': {file: 'kick.wav'},
'D1': {file: 'snare.wav', transpose: '+3'},
'F1': {file: 'example.wav, transpose: '-14', start_position: '1.235', end_position: '2.34'}
)
As far as I understand your code, it would be rewriting the the urlMap definition in Sampler.js on lines 31ff to accept 3 extra parameters(not only url, but also loopStart, loopEnd and transpose). And extend the Tone.BufferSource on lines 122ff with the parameters for loopStart and loopEnd and recalculate the playBackRate taking into account the transpose parameter.
However, I am not proficient enough in Javascript to write this myself.
Here is the preliminary Ruby library around Tone.js, where I parse Ableton data to be played with Tone.js
https://github.com/hilkeros/raudio-test
Thanks!

Thanks for the feature request. translating from Ableton to Tone sounds awesome.
i think that having the ability to add loopable points to Sampler would be good in situations like importing soundfont-style instruments into Sampler. giving it the ability to support infinite sustained notes through well-placed loop points.
it sounds like your situation is slightly different and Tone.Players might be a better fit since you aren’t using the auto repitching the Sampler provides to fill in missing notes for mulitsampled instruments. Player already has the ability to set loop points and you can adjust the pitch of the sample by changing the playbackRate property.
PRs welcome if you start a patch which adds looping and loop points to Sampler! also excited to see how Raudio progresses

Player uses start and stop instead of triggerAttack/triggerRelease. Try that out

Given this issue is open - I assume that loopPoints within the audio is not yet supported ? Interested in adding it in.


Fix code block display by using headings

Hi!
Code blocks on the quick start page aren't displayed correctly. This is because of the markdown numbering. I propose using h3 headings instead. Plus this way we get anchor tags automatically.

Thanks for spotting this. I'm going to fix this by just adjusting the indentation instead.


ceph-prometheus: add alertmanager HA config

When using multiple alertmanager nodes (via the grafana-server group)
then we need to specify the other peers in the configuration.
https://prometheus.io/docs/alerting/alertmanager/#high-availability
https://github.com/prometheus/alertmanager#high-availability
Closes: https://bugzilla.redhat.com/show_bug.cgi?id=1792225
Signed-off-by: Dimitri Savineau<EMAIL_ADDRESS>

@fmount You'll probably have to do the firewall modification on TripleO too

@fmount You'll probably have to do the firewall modification on TripleO too

According to [1] we should be ok, but thanks for notifying me about this change!
[1] https://github.com/openstack/tripleo-heat-templates/blob/master/deployment/ceph-ansible/ceph-grafana.yaml#L113


Simple Interest Calculator - Python

Calculate the simple interest for a given principal, rate, and time.
The values of principal, rate, and time should be user inputs.
Add the code to the python folder

@Dext3r-Morgan can you assign this to me ?

@prateek168 yeah sure
make sure you add it to the python folder


Add swin_t to slow list

cc @datumbox

@jdsgomes you will need to regenerate the expected file as the input of the test changed.


SSE integration

Closes https://github.com/streamich/json-joy/issues/50

:tada: This PR is included in version 2.14.0 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


add d.ts file generate

related to #3, although it doesn't fix the svelte-check(missing-declaration) issue, but it does fix the issue with the typescript

I tried to use your nice feature addition, got an error which could be precised when dts field is not specified in the autoImport config and this does not take into account the module field for node_modules imports like the following :
autoImport({
  dts: "./src/components-auto-imports.d.ts",
  module: {
    'flowbite-svelte': [
      'Button',
      'GradientMonochromeButton'
    ]
  }
})

I guess the desired dts output (for this specific case) looks like this
// Generated by 'sveltekit-autoimport'
export {}
declare global {
  export const { Button, GradientMonochromeButton } = import('flowbite-svelte')
}

Yeah, i didn't consider module base components 😅. Let me close this PR, i will try to figure out how to do that. Thanks for the feed back


feature: Implement IP whitelist

Simple IP-Whitelisting feature

@ianheggie could you please give some feedback about this pull request?

@ianheggie are you there?

I am looking at your PR - I will adjust the default error return to 403 as that is more appropriate.

Sure, thanks :)


Diamond Problem Explained in CPP

In C++, the "diamond problem" refers to a particular issue that can arise in languages that support multiple inheritance. It occurs when a class inherits from two classes that have a common base class.
Kindly Merge into the repository.  :)

Shouldn't this come into ALGORITHMS directory?

Yes @yashjawale , You are right but also it is not an algorithm so I just added into Data-structure section so, it makes people highlight to learn about this important and crucial concept ..
The Diamond problem is a term used in OOP, particularly in the context of multiple inheritance . And Thank you! for pointing it out.


How to train this model on own dataset?

We need to train this model on our own dataset. Plesae help us this regard.

Hi @TriB90, happy to help! Our training data has a folder structure like this:
DF2K/
  bin/
    train_bin_HR.pt
    train_bin_LR_X2.pt
    train_bin_LR_X3.pt
    train_bin_LR_X4.pt
  DF2K_HR/
    0001.png
    ...
  DF2K_LR_bicubic/
    x2/
    x3/
    x4/

The folders DF2K_HR and DF2K_LR_bicubic contain high-resolution and downsampled PNG images, respectively. When you run training, you need to specify the config DATASET.DATA_DIR = "DF2K". We usually save the images as a single binary file in bin/ and load them directly into memory to save I/O time. To use the binary files, set DATASET.DATA_EXT = "bin".
If this does not address your question, please let me know your data format, and we can discuss more.

@zudi-lin First, I want to try your pre-trained model on different test images. But I could not able to run it as it is not clearly written in Readme file how to run the test code. Please help me in this regard.

DATASET.DATA_EXT = "bin"

Not able to create the binary file. I have kept 18 HR images in 'rcan-it/ptsr/datasets/SR/BIX2X3X4/DF2K/DF2K_train_HR/' folder and their corresponding LR images in 'rcan-it/ptsr/datasets/SR/BIX2X3X4/DF2K/DF2K_train_LR_bicubic/X2' folder. But the error is shown below:
`Total number of parameters:  15444667
Using Dataset(s): DF2K for training
/content/drive/MyDrive/rcan-it/ptsr/datasets/SR/BIX2X3X4/DF2K/bin/train_bin_HR.pt does not exist. Now making binary...
Bin pt file with name and image
Traceback (most recent call last):
File "main.py", line 135, in
main()
File "main.py", line 98, in main
loader = Data(cfg)
File "/content/drive/MyDrive/rcan-it/ptsr/data/init.py", line 35, in init
datasets.append(getattr(m, module_name)(cfg, name=d))
File "/content/drive/MyDrive/rcan-it/ptsr/data/df2k.py", line 17, in init
cfg, name=name, train=train, benchmark=benchmark
File "/content/drive/MyDrive/rcan-it/ptsr/data/srdata.py", line 39, in init
cfg.DATASET.DATA_EXT, list_hr, self._name_hrbin()
File "/content/drive/MyDrive/rcan-it/ptsr/data/srdata.py", line 148, in _check_and_load
} for _l in l]
File "/content/drive/MyDrive/rcan-it/ptsr/data/srdata.py", line 148, in
} for _l in l]
File "/usr/local/lib/python3.7/dist-packages/imageio/core/functions.py", line 221, in imread
reader = read(uri, format, "i", **kwargs)
File "/usr/local/lib/python3.7/dist-packages/imageio/core/functions.py", line 130, in get_reader
request = Request(uri, "r" + mode, **kwargs)
File "/usr/local/lib/python3.7/dist-packages/imageio/core/request.py", line 125, in init
self._parse_uri(uri)
File "/usr/local/lib/python3.7/dist-packages/imageio/core/request.py", line 273, in _parse_uri
raise FileNotFoundError("No such file: '%s'" % fn)
FileNotFoundError: No such file: '/content/drive/MyDrive/rcan-it/ptsr/datasets/SR/BIX2X3X4/DF2K/DF2K_train_HR/0019.png'
ERROR:torch.distributed.elastic.multiprocessing.api:failed (exitcode: 1) local_rank: 0 (pid: 1678) of binary: /usr/bin/python3
Traceback (most recent call last):
File "/usr/lib/python3.7/runpy.py", line 193, in _run_module_as_main
"main", mod_spec)
File "/usr/lib/python3.7/runpy.py", line 85, in _run_code
exec(code, run_globals)
File "/usr/local/lib/python3.7/dist-packages/torch/distributed/run.py", line 723, in
main()
File "/usr/local/lib/python3.7/dist-packages/torch/distributed/elastic/multiprocessing/errors/init.py", line 345, in wrapper
return f(*args, **kwargs)
File "/usr/local/lib/python3.7/dist-packages/torch/distributed/run.py", line 719, in main
run(args)
File "/usr/local/lib/python3.7/dist-packages/torch/distributed/run.py", line 713, in run
)(*cmd_args)
File "/usr/local/lib/python3.7/dist-packages/torch/distributed/launcher/api.py", line 131, in call
return launch_agent(self._config, self._entrypoint, list(args))
File "/usr/local/lib/python3.7/dist-packages/torch/distributed/launcher/api.py", line 261, in launch_agent
failures=result.failures,
torch.distributed.elastic.multiprocessing.errors.ChildFailedError:`
Please help me to solve this issue.

@TriB90 Guidance for training on a custom dataset is posted here: https://github.com/zudi-lin/rcan-it#training-on-new-datasets


Streaming doesn't work properly in Blazor WASM

There is a problem with streaming using IAsyncEnumerable in Blazor WASM. When consuming the stream in a console app or any environment other than Blazor WASM, the items are processed one by one as they are fetched. However, in Blazor WASM, the stream behaves differently, and the response is only available after all items are fetched from the remote resource.
The issue affects both ChatClient.CompleteChatStreamingAsync and AssistantClient.CreateRunStreamingAsync methods (and potentially any other streaming methods).
Steps to reproduce:

Set up a Blazor WASM project.
Use the following code snippet to fetch streaming updates from a remote resource.
Observe the behavior difference compared to a console app.

Code:
var messageContent = MessageContent.FromText(prompt);

var streamingUpdates = assistantClient.CreateRunStreamingAsync(
    thread.Id,
    assistant.Id,
    new()
    {
        AdditionalMessages = { new([messageContent]) }
    }
);

await foreach (var streamingUpdate in streamingUpdates)
{
    switch (streamingUpdate.UpdateKind)
    {
        case StreamingUpdateReason.MessageCreated:
            Console.WriteLine($"Message created: {DateTimeOffset.Now:O}");
            break;

        case StreamingUpdateReason.MessageUpdated when streamingUpdate is MessageContentUpdate messageContent:
            Console.WriteLine($"Message updated: {messageContent.Text} -- {DateTimeOffset.Now:O}");
            break;
    }
}

Expected Behavior:
Each item should be processed as it is fetched from the remote resource, similar to the behavior observed in a console app.
Actual Behavior:
In Blazor WASM, the stream processes all items only after they are completely fetched, rather than one by one.
Environment:

Blazor WASM on .NET 8
OpenAI NuGet package version: 2.0.0-beta.5

Additional Information:
The problem is detailed in this blog post. The behavior discrepancy between Blazor WASM and other environments needs to be addressed to ensure consistent streaming functionality by setting SetBrowserResponseStreamingEnabled(true) and HttpCompletionOption.ResponseHeadersRead on the HttpRequestMessage.

@annelo-msft, we need allow setting/calling HttpRequestMessage.SetBrowserResponseStreamingEnabled(true) on HttpClient's messages to fix this problem.

Tracking with https://github.com/Azure/azure-sdk-for-net/issues/44706

@KrzysztofCwalina, I believe we may already have the method we need on HttpClientPipelineTransport in the OnSendingRequest method.
For example, following the repro steps above, I am able to create a sample project and add a sample transport implementation that overrides OnSendingRequest:
public class BlazorHttpClientTransport : HttpClientPipelineTransport
{
    protected override void OnSendingRequest(PipelineMessage message, HttpRequestMessage httpRequest)
    {
        httpRequest.SetBrowserResponseStreamingEnabled(true);
    }
}

The default SCM transport already passes HttpCompletionOption.ResponseHeadersRead to HttpClient.Send, so I believe that requirement should be addressed without any additional customization to the transport implementation.
That can then be added to the client by passing an instance of OpenAIClientOptions as follows:
OpenAIClientOptions options = new();
options.Transport = new BlazorHttpClientTransport();
ChatClient client = new(model: "gpt-4o", apiKey, options);

If this doesn't address the issue as you were thinking @KrzysztofCwalina, let me know.
Or @MoienTajik, if this doesn't address the problem you're seeing, I'm happy to dig further into needs here.
Thanks!

Thanks, Anne, for investigating this! I can confirm that this works and solves the problem.


Include HTML/IMG Support for Imageboard RSS

Is your feature request related to a problem? Please describe.
I was wondering if it was possible to showcase the HTML content on some feeds. Like for instance an Imageboard thread.
Describe the solution you'd like
I don't know, I'm asking if it's possible and if it's possible I would like to help
Describe alternatives you've considered
Livemarks/Firefox Bookmarks is my only RSS app - it's simple. Reads RSS streams and keeps them in sync in my #1 most used app
Additional context
Add any other context or screenshots about the feature request here.

It is not possible to display images or other structured HTML in the bookmarks toolbar. We can't even change the icons. It may be possible on the feed preview page.
There are other feed readers for Firefox which can show content inside their menu. They achieve this by using a completely different API to display their UI, which means they cannot have cascading menus and everything is under a single icon. For example, FeedBro is one such reader which works this way.

I think it's very unlikely that the required API is ever going to be added.


feat: add config links to json schema (closes #5479)

What kind of change does this PR introduce?

[ ] Bugfix
[x] Feature
[ ] Docs
[ ] New Binding issue #___
[ ] Code style update
[ ] Refactor
[ ] Build-related changes
[ ] Other, please describe:

Does this PR introduce a breaking change?

[ ] Yes, and the changes were approved in issue #___
[x] No

Checklist

[x] When resolving issues, they are referenced in the PR's title (e.g fix: remove a typo, closes #___, #___)
[ ] A change file is added if any packages will require a version bump due to this PR per the instructions in the readme.
[x] I have added a convincing reason for adding this feature, if necessary

Other information
Closes #5479
I am unsure about the need for any package version bumps - this is really just a docs change 🤷♂
I considered a few approaches for this, but, after fooling around for too long, I decided to just submit the simple solution.
Future Considerations

The links could be automatically generated (updated) - making maintenance easier
Certain configs did not get links to look as expected (they are overwritten):

The WindowsConfig is not updated, because it is defined as a Vec:

  /// The windows configuration.
  #[serde(default)]
  pub windows: Vec<WindowConfig>,

As such, the doc comment above the field is taken - contrast other definitions where the struct definition doc comment overwrites the field doc comment.

It would be nice to have full markdown support in the tooltip using the markdownDescription property. However, this is a VSCode field, and is not defined in the JSON Schema. So, the implementation would involve more hacking as the schemars::schema::Metadata struct does not include a markdown_description field.

what do you mean about that?

/// Doc comment ignored on `TauriConfig.windows`
struct WindowsConfig {}
/// Doc comment used for `TauriConfig.bundle`
struct BundleConfig {}
struct TauriConfig {
  /// Doc comment used, because type `WindowsConfig` is not base type - `Vec<...>` is
  windows: Vec<WindowsConfig>;
  /// Doc comment overridden, because priority is given to comment above base type - `BundleConfig`
  bundle: BundleConfig;
}

However, this is now moot, because I will add links to all fields.

I see what you mean, it is inconsistent, but we have to make the best of it

@lorenzolewis do you think this is something that should wait for the new docs?

As long as they all use a similar format that should be easy to strip in the doc generator

I'm not familiar with how exactly this is generated (nor all the details of the schema spec) but is there any support for an actual link object? I want to avoid putting information in a generic "description".
Some things to look at are the spec for hyper-schemas, particularly the links object: https://datatracker.ietf.org/doc/html/draft-handrews-json-schema-hyperschema-01#section-5.2
An example of this in practice I found here: https://apisyouwonthate.com/blog/getting-started-with-json-hyper-schema#json-hyper-schema
I'm curious at what TypeScript is using that generates the links in the screenshot below. Are those just hard-coded links in the comment part of the schema? Or are they using a specific field.
Then that leads me to ask if whatever tooling we're using to extract the info from the .rs files into the appropriate schema supports it.

I'm curious at what TypeScript is using that generates the links in the screenshot below. Are those just hard-coded links in the comment part of the schema?

https://github.com/SchemaStore/schemastore/blob/b4eccc2fb5ad76fd9c0a70fa67228e5d65e2b562/src/schemas/json/tsconfig.json#L693-L705

Then that leads me to ask if whatever tooling we're using to extract the info from the .rs files into the appropriate schema supports it.

As said in the PR description:

It would be nice to have full markdown support in the tooltip using the markdownDescription property. However, this is a VSCode field, and is not defined in the JSON Schema. So, the implementation would involve more hacking as the schemars::schema::Metadata struct does not include a markdown_description field.

I checked and schemars doesn't have support for that hyper protocol which adds the links support.
I think it would be better to instead link out to a single page on all the objects like https://tauri.app/v1/api/config. That would be a lot easier to maintain both in this repo I'd imagine. Plus we're also going to break all of these URLs this summer most likely with some changes coming to the website.

Thank you for the input, maintainers.
Could I get clarification on which direction this feature should go?
Discussed
a) Discard current feature, pending new docs
b) Add specific property links to every field
c) Add the same link (/config) to every field


Remove unsafe and direct use of openssl-sys

I recently started using josekit for a project, and I was very impressed by the project, also considering it's developed by one person.
I noticed that the project contains a very small amount of unsafe, and I saw that the main problem was related to the openssl crate not exposing some APIs. I decided to implement the missing pieces, and recently the new version of the openssl crate has been published, making these new APIs available for josekit.
I based my work on openssl on your work on josekit, so I did nothing more than creating an abstraction layer over your code. With this PR, josekit is 100% safe code, which is always a nice feature to have.
Let me know if you like this.
Thank you for efforts you put into this crate! :heart:

Thank you for your work. That what I was thinking.
I will release a new version in the near feature.

I noticed that you removed the crate foreign-types because now it is unused. This is interesting, because I run cargo udeps just before making the PR, and it was unable to detect that that crate could be removed. I will make some tests, and if the thing is real I will open an issue on the repo of the tool.


Can't install v0.3.1 via homebrew

Describe the bug:
Can't install v0.3.1 via homebrew
To Reproduce:
Open terminal, run brew install passbolt/tap/go-passbolt-cli
https://app.warp.dev/block/pUqTupOZuFb8pgmOf0uT0m
Output when using --debug (you should censor this):
Passbolt Server Version  (please complete the following information):

Edition: Community
Version 0.3.1

go-passbolt-cli Version (please complete the following information):

OS: macOS
Version 13.4

Additional context
I think it's more than clear.

Hi, v0.3.1 has not yet been release due to a issue, it seems that homebrew uses the latest tag instead of the latest release which is causing this issue, for now you can tell homebrew to install v0.3.0 instead, which should work, ill see if i can release v0.3.1 Soon.

Hi, i just released v0.3.1.
Can you check if you can install now?
Thanks

Many thanks, it's working now.


Display card

Value Proposition
As a user, I want know how many bats have been in a specific nesting box at a specific time.
Description

Acception Criteria

[ ] user can see how many bats were counted in the nesting box
[ ] user can see, in which nesting box the bats have been (number of nesting box should be displayed)
[ ] user can see, when the bats were counted (display date and time)

Tasks

[ ] create new component for a card
[ ] create an array e.g. "nesting-boxes.json" in db-folder with one nesting-box-object in it
[ ] nesting-box-object must contain properties of count, nesting-box-number, date and time
[ ] render array to a card

This is a fantastic user story! Very clear acceptance criteria and tasks. If I would criticise one thing is that there is no reason in your value proposition. If you add one this one is perfect.

Your array should be in a Javascript file, not a json file, for example:
nestingBoxes.js:
export const nestingBoxes = [{...}, {...}]


Implement native extension system

Deprecates GDNative in favor of a simpler, lower level interface.
New extension system allows registering core engine classes.
Per function signature hashing, so if an API changes, the old ones can still be made available.
Simple header interface in gdnative_interface.h

The API dump command line has also been re made, to invoke use:
$ godot --dump-extension-api

Example of how API dumps look now: api.json
This PR is a draft for review.
TODO:

JSON API dumping.
Function checksums to deprecate API Hash
Virtual Functions
Singletons
Automatic extension loading, editor extension loading.
Extension dependencies.
Hot reloading
Likely other features.

Correct me if I'm wrong but it seems the new API dumb doesn't handle singletons.
The former "singleton" field in the JSON is gone and the "is_instanciable" is set to true.
Can we trust that the prefix "_" is enough to recognize a singleton?

@CedNaru Oh I just forgot about the singletons, have to add them back. I also dont think it should export the classes beginning with _ as such, I will change that.

... I also dont think it should export the classes beginning with _ as such, I will change that.

Do you mean those should not be exposed? Classes beginning with _ should not be hidden. They only begin with _ to avoid conflicting with other classes in C++.

... I also dont think it should export the classes beginning with _ as such, I will change that.

Do you mean those should not be exposed? Classes beginning with _ should not be hidden. They only begin with _ to avoid conflicting with other classes in C++.

I think he means exposing them without the _. Which is the best IMO.

@CedNaru Added the singletons to the API json at the end of the file.

 If so, I was wondering how the interfaces for languages like Rust and Nim would change considering they're not OOP languages and have to interface with Godot currently using language-level macros to export a class?

@arundilipan Sure, if you expect the engine to see whatever you do, you must register classes. The main difference is that you are registering actual classes now, not scripts.

@arundilipan Sure, if you expect the engine to see whatever you do, you must register classes. The main difference is that you are registering actual classes now, not scripts.

What do you mean when you say actual classes? Could you give me an example of what that would look like?

@arundilipan instead of creating the binary, the gdnativescript and manually assigning the script to the node, now you just create a new node type and it will appear directly in the editor for you to use.

From what I understand, extensions are directly registered into the ClassDB so when you want to create an "extended Object" in the editor instead of creating the base class and attaching a script to it, it directly behaves like if it was a regular native Object.
This way you don't have to use the scripting system of Godot.
Unlike scripts, you can't switch extensions at runtime dynamically without creating a new Object but the bright side is that you will still be able to modulate the behavior of extended Object with another script, giving 2 levels of controls. I see a strong potential for add ons. Developers can provide extensions as new usable objects for Godot that can still have custom behavior overwritten by a script provided by the user. Currently, when I use an add-on and want to change the behavior of the new custom node provided I can only control it using a script on a parent node pr whatever properties it has in the inspector.
Extensions will make this process much easier.
Also as a maintainer of Godot Kotlin, this will simplify our module a lot as we won't have to keep the .kt file around to assign them to object as scripts. (Currently forcing us to have a hashmap (path of the script -> actual Kotlin class).
Tell me if I got something wrong, it's the understanding I got by reading the commit changes.

So @reduz if I'm understanding this, there's no separate GDNative scripts needed, it's first class support for Kotlin or Python or Ruby classes in the Godot editor?

@CedNaru You got it perfectly right
@arundilipan For dynamically typed languages, you most likely don't want to use this route and instead provide a core extension that registers a script language. Again this process is simpler too, you no longer have to use PluginScript, just inherit ScriptLanguage like you would in a module.

For dynamically typed languages, you most likely don't want to use this route and instead provide a core extension that registers a script language. Again this process is simpler too, you no longer have to use PluginScript, just inherit ScriptLanguage like you would in a module.

So, what exactly would this look like?
From what I can understand of the changes, I will be able to write a C program that includes gdnative_interface.h and calls various gdnative extension functions to define an "extension" with one or more "classes" and their associated name, base type, properties, methods, signals, and integer constants. I can then mark when the classes should be registered (core/server/scene/editor). I then compile this into a dynamic library, e.g. *.dll on Windows, drop the file into my Godot project, and register it in the project settings or dynamically open the library using the NativeExtensionManager singleton. Is this right?
The thing that trips me up is that ScriptLanguage doesn't extend Object. It's effectively just an interface. So, if we are just registering things to the ClassDB as (I believe?) you said, we wouldn't be able to specify that the class we are introducing extends ScriptLanguage (we can only extend Object and its derivatives). Is this correct? If so, how does the dynamic language support work?
Also, wouldn't that mean we need to include the script_language.h file and all of its dependencies to be able to refer to the ScriptLanguage class? Are we effectively compiling our custom C code alongside the engine source code itself and then taking that library and just dropping it into a project to have a delayed runtime load? Cause, I seem to recall asking you previously on Twitter if the GDNative 2.0 code would have access to core data structures and the like, and you said that wasn't the case.
It's a little confusing what the capabilities and restrictions are with this.

@willnationsdev for the most part, virtual abstract classes like ScriptLanguage will have a special binder version (likely ScriptLanguageNative) like they do now, but it will be entirely defined in C++ using the new system for registering and native virtual functions. You can even pass pointers and other stuff to them.

What's the future plans for the low-level extensions (VideoDecoder, XR and TextServer), custom API or NativeExtension extended classes? If it's going to be NativeExtension what should be done with the functions using non-Variant arguments (raw char * pointers in the video decoder, and Vector<TextServer::Glyph> in the text server)?

@bruvzg New new system for native extension virtuals should allow for this, which had to be hardcoded in C in the past. It should also allow for custom function formats for the very specific types. The idea is to first test this system for regular development, then add these classes so we can have what we had previously in GDNative.

Thanks!

@neikeq can U suggest use cases how C# developers can take advantage of this exciting GDExtension.

@GeorgeS2019 It's not possible yet. I'll add support for it in the future.


Wrap the header content

Hello, and thank you for creating this lib.
I am using a responsive table where some of the table headers are long. Since the table cell is the same width as the table row, the columns with larger headers will take more space than the others, although their content is the same.
Can the columns have the same width and wrap the header content?
I tried setting  max-width: 100px; word-wrap: break-word; white-space: pre-line to the table headers, but the sticky header cells no longer match the actual table cells.

Never mind, it was because I was adding the table-tighten class.


Fix conversion of Resource to service id with CamelCase-Name

1. Why is this change necessary?
Shopware\Components\Api\Manager::getResource('CustomerStream'); would fail to find the Service shopware.api.customer_stream
2. What does this change do, exactly?
Fix conversion of CustomerStream to customer_stream
3. Describe each step to reproduce the issue or behaviour.
4. Please link to the relevant issues (if any).
5. Which documentation changes (if any) need to be made because of this PR?
6. Checklist

[ ] I have written tests and verified that they fail without my change
[ ] I have squashed any insignificant commits
[ ] This change has comments for package types, values, functions, and non-obvious lines of code
[x] I have read the contribution requirements and fulfil them.

hey @fivetide
there is already a fix for that https://github.com/shopware/shopware/blob/5.5/engine/Shopware/Components/DependencyInjection/services.xml#L647

@mitelg , right, didn't see that one. Though it looks more like a workaround. This fix would actually make the behaviour consistent in case any future APIs are added with CamelCase names... But If you don't expect that to happen, feel free to close this PR.

Hey @fivetide,
can you please rebase your PR to the 5.5 branch?

Hey @fivetide,
you're still on it?

This PR was closed due to inactivity. If this change is still important to you, feel free to create a new pull request.
For more information about our contribution guidelines, see https://developers.shopware.com/contributing/contribution-guideline/.


ImagePullSecrets doesn't work with registry mirror.

It's mentioned in https://containerd.io/releases/#deprecated-config-properties that
[plugins."io.containerd.grpc.v1.cri".registry] auths will be removed on v2.1, and the replacement is to use ImagePullSecrets.
However ImagePullSecrets doesn't work with mirrors, as kubelet only passes containerd the creds for the original host of the pulled image.
Is there plan to add a replacement that works with mirrors?
Is #8228 the solution?
Is there still plan to add creds in host config, as suggested in https://github.com/containerd/containerd/blob/main/core/remotes/docker/config/hosts.go#L57

However ImagePullSecrets doesn't work with mirrors, as kubelet only passes containerd the creds for the original host of the pulled image.

Is there a related KEP for improving this, user owned secrets really is the best solution for registry authentication.

Is there plan to add a replacement that works with mirrors?

Yes, the replacement was not built for 2.0 so we  did not remove

Is https://github.com/containerd/containerd/issues/8228 the solution?

A proposal for a solution, we haven't defined a plugin interface there yet. Ideally such a solution could also potentially go along with Kubelet change to avoid passing the wrong, or unasked for, credentials over the CRI api with the image pull command. Using secret stores is the better solution so we aren't forced to keep credentials anywhere in plaintext or held in memory longer than they are needed.

Is there still plan to add creds in host config, as suggested in https://github.com/containerd/containerd/blob/main/core/remotes/docker/config/hosts.go#L57

Secrets will not be added in the host config, the command mentions configurations for credentials though. This could include stuff like the domain or username to request a secret for as well as possibly which plugin to use to get the secret from.

Thanks for the quick response, Derek!

Yes, the replacement was not built for 2.0 so we did not remove

Great! So this is already on the radar and there is plan to support. My concern was that this is somehow overlooked, or even worse, that containerd suddenly decides to drop the mirror feature.
Sounds like it's safe to assume that, these settings will stay as long as the replacement is not provided, potentially beyond 2.1?
If this is the case, we can continue using the existing auths until a fully-working replacement is provided.

Is there a related KEP for improving this, user owned secrets really is the best solution for registry authentication.

+1 to the sentiment that secret management is better outside of containerd directly.  We might want to have Kubernetes model the mirror credentials (and go through the KEP process for design), but then we would probably need to also understand whether Kubernetes should manage mirror configuration as well.


remove unnecessary third party dependencies from project

User Story
As a developer, I would prefer to use a package that doesn't use third party packages so that my own project is slim of dependencies.
Description
It would be nice to get this done with only the standard lib, so that dependencies are slim.  I think this will promote other developers to use this package.  Things like grpc cannot be removed because they are the backbone of the package, but it should be free of loggers and other packages that can be implemented with the standard lib.  Specifically, there are two packages I would like to have removed:

Zap: only a single implementation of this would not be hard to get rid of and can be replaced with standard log
UUID: not really sure how to replace this yet.  Will need to figure out uuid specifications to implement it

Requirements:

[ ] Remove Zap
[ ] Remove UUID

There currently aren't any


fix: add

#1718

resolves #1718
Checklist for a profile addition

[ ] Name the PR fix: add <your-username>.
[ ] You've added file named your-username.json in the profiles directory.
[ ] You've linked the PR to the correct issue.

Other additions/changes

[ ] Changes made in this PR are mentioned below
[ ] Search previous suggestions before making a new one, as yours may be a duplicate.
[ ] I acknowledge that all my contributions will be made under the project's license.
[ ] I've read the contributing guidelines

This PR adds/fixes

Notes

Click Me
you can use the above URL to solve the issue Thanks

This is also the url for image

There's no need for a dropbox link. You can just use a snipping tool, copy it into a GitHub message, copy the image's link, and use it in the image URL field. 🙂
If you need any help with doing that, let us know.

how to do this would you like to instruct @Panquesito7

how to do this would you like to instruct @Panquesito7

If you're on Windows, you can search for the Snipping Tool application and take a screenshot of your profile.
If you're using another operating system, I'm sorry, but I can't help much, as I use Windows. 😅

Now you can merge it

@PiseAtharva  is it right now or not?
please confirm me
thank you so much


added noimplicitany and strictNullChecks flags and solved all errors

Added noImlicitAny and replaced every implicit any with actual type or explicit any.
Added strictNullChecks to be even more explicit with types. it basically differs null and undefined instead of considering them exactly the same thing. As I understood it is somehow related to The Billion Dollar Mistake.

Can you set your indentation to 2 spaces once and for all?


Add SimpleOrigin to the StarLasu Ecore metamodel

SimpleOrigin as been added to the StarLasu metamodel in Kolasu but not in Tylasu.
For the Kolasu version see this
For example, we have in a trace.json file this snippet:
"origin" : {
            "eClass" : "https://strumenta.com/starlasu/v2#//SimpleOrigin",
            "sourceText" : "DECEDIT('0,')",
            "position" : {
              "start" : {
                "line" : 1,
                "column" : 6
              },
              "end" : {
                "line" : 1,
                "column" : 19
              }
            }
          },

In general I think we may want to revisit how Source, Origin, and the Node's position are connected. We started a discussion around that some months ago: https://github.com/Strumenta/kolasu/discussions/172
For this case specifically, I think that SimpleOrigin is being used a lot in the RPG Parser, where the code we parse could be a snippet of the entire source file, so the position of the node within the overall file is not the same as the position in the snippet being parsed, so we cannot get it from the ParseTree and we need to override it. It is true that within the trace, given we also send the source code, it becomes redundant.
What about considering removing it in Kolasu 1.6? Should we open an issue for that?
In Tylasu instead, if the same effect of adding SimpleOrigin can be obtained by setting position in the node (assuming we can get the sourceText in some other way and that would produce the same result that we got stored in SimpleOrigin) then we could not introducing SimpleOrigin. But that would probably make unserialization a bit more complicate.
What do you think?

Ok, I tried writing a test to load a Trace using the SimpleOrigin.
While the SimpleOrigin is now loaded as an EObject, is then never used by the SourceNode (a class specific to the TranspilationTrace). The position is "shadowed" by the position specified on the node and the sourceText is irrelevant for the TranspilationTrace and for Playground.
Based on this it seems to me that we have two options:

Keep the SimpleOrigin, considering is useless for the transpilation trace
Remove it from the trace

The latter would require modifying the EMF serialization, and in other contexts (i.e., when serializing to EMF but not for the transpilation trace) the SimpleOrigin could be relevant. So I think that Option 1 is easier.
Would that be ok?
In the meantime I will push a test that just show the loader not exploding when loading a transpilation trace with a SimpleOrigin


[deploys] Netlify build image needs an update

Looks like an easy fix, but for now this is the message:

Support for the Xenial build image ended on November 15, 2022. To enable builds for this site, select another build image. Read the migration guide.

I "unlinked" the repository, and confirmed that publishing with the API from GitHub actions still works:


Update Python version for CI to 3.9

Description

This updates the CI Python version from 3.7 to 3.9 because 3.7 will reach end of life next year.
Types of change

chore
Checklist

[x] I confirm that I have the right to submit this contribution under the project's MIT license.
[x] I ran the tests, and all new and existing tests passed.
[ ] I ran the update scripts in the .github folder, and all the configs and docs are up-to-date.

Sounds reasonable. Questions:

Has this been discussed internally yet?
Why 3.9 and not 3.8?

We could add MacOS for 3.8 :-)

I don't think we've discussed this internally. My choice of 3.9 here was basically arbitrary.
I have no objection to having multiple versions of Python in the CI, though before this PR the tests are already just using one version, probably to keep test runtime down. I also do think it's reasonable to expect fewer issues related to Python version here than in the main spaCy repo, for example.
I'll go ahead and change this to:

3.7 Win
3.8 OSX
3.9 Linux

Well, this found our first error in the tests: mapfile isn't in the default bash on OSX. I'll work on fixing it...

Which tests did you run to ensure that the behavior of the modified script matches the existing one? Specifically, are tests rerun if changes are detected at the first directory level? Sorry, my bash-fu isn't good enough to see that right away.

Thanks for mentioning that - I had tested changes in the top-level directory but had forgotten about the README files in the first-level directories, so it would have re-run in that case. I fixed that.
After the fix, the way the bash script works bit by bit is:
git diff ... | sed ... # this was already there
cut -f 1-2 -d/ # was being done later anyway, but gives the first two components, and any second slash is removed (there is at most one slash)
grep /. # This finds things with a slash followed by a character (must be a second-level directory)
sort -u # This filters any duplicates, like if `a/b` and `a/b/c` have modifications

I tested this by making modifications to files at the top, first, second, and third levels, including duplicates and non-duplicates.


files: add an authority filter to the history service

Fixes https://github.com/microsoft/vscode/issues/195938

No tests. I can add some tomorrow and push them to this PR.

Actually, we do have some tests: https://github.com/microsoft/vscode/blob/main/src/vs/workbench/services/dialogs/test/electron-sandbox/fileDialogService.test.ts

Added a few tests

Will merge based off Alex's initial approval in the linked issue. Please let me know if there are other concerns.

Thanks for making this change! Once we have a new insiders I will try it out.


Model WooShippingMethod different Woocommerce docs

I call api and model return null value.

Hi ! Can you send a screenshoot of your issue?

I used getShippingMethods() and then is return value.

I looked at your model and it is different from JSON response example on link https://woocommerce.github.io/woocommerce-rest-api-docs/#list-all-shipping-methods

okay i see. Already know that in addition to the model it uses a woocommerce class to call the model as a kind of getter. this method collects some information and leaves others intentionally. my solution and this is the track I have been exploring since this morning is to create a class that will extend the ShippingModel class in order to overload it