Improve component detection error handling

We have been seeing support requests in which the component detection library throws errors in a scan, usually due to malformed packages present on the machine, and the SBOM tool surfaces those errors before continuing the scan. This can be confusing to users, who see these errors (which are displayed in red, along with a full stack trace) and think that the SBOM generation failed. Further, this can obscure other, more critical errors.
We should wrap component detection errors such that they are only displayed as warnings when they are not critical and the scan can continue.

Component detection logs directly, so doing this will require either that we change component detection or find a way to replace the default implementation of Serilog.ILogger with our own version.

This has been merged into main and will be included in our next release


Rewrite to operate on tokens

Using https://github.com/rust-lang/rust/pull/40939 and proc-macro2. @alexcrichton is working on this.

I'm helping @alexcrichton with modifying the parser to run on TokenStream objects. My current unrebased branch is https://github.com/mystor/syn/tree/proc-macro2.

I love both of you.
@mystor question about flatten_stream - it looks like this would be lossy right? If you have a TokenStream containing $a * 3 where the value of $a is 1 + 2, this would turn it into something that is indistinguishable from 1 + 2 * 3. (Not that we handle operator precedence anyway currently, but we will want to.) Any sense of how much harder it would be to support that correctly?

@dtolnay Yes, flatten_stream is currently lossy, which is quite unfortunate. I don't know off of the top of my head what the best way to handle the None delimiter sequences.
As you can probably tell from my current WIP branch, I was trying to do the minimal number of changes to the rest of syn to get the parser to work built on top of proc-macro2. I imagine that any attempt to get None-delimited sequences working with precedence will require a reworking of that entire part of the parser, as well as a change to the synom input format, which I figured we would probably have to do separately (although potentially before 0.12 is released, depending on how long it takes to get the real proc-macro into nightly).


Core/fix register remote

Tracking issue
_https://github.com/flyteorg/flyte/issues/4936_

Why are the changes needed?

According to https://github.com/flyteorg/flyte/issues/4936, some users encountered difficulties when trying to call register_workflow. While register_scripts can serve as an alternative, setting up the source_path and module_name can be pretty annoying. This change also enables execution with a relative path. For example:
file structure

test_register.py
import typing
from flytekit import task, workflow
from flytekit.tools.script_mode import _find_project_root
from flytekit import ImageSpec, Resources, task, workflow
import os
import inspect
import pathlib
import pdb

@task
def say_hello(name: str) -> str:
    return f"hello {name}!"

@task
def greeting_length(greeting: str) -> int:
    return len(greeting)

@workflow
def wf(name: str = "union") -> typing.Tuple[str, int]:
    greeting = say_hello(name=name)
    greeting_len = greeting_length(greeting=greeting)
    return greeting, greeting_len

if __name__ == "__main__":
    from flytekit.remote import FlyteRemote
    from flytekit.configuration import Config, SerializationSettings, ImageConfig

    remote = FlyteRemote(
        config=Config.for_sandbox(),
        default_project="flytesnacks",
        default_domain="development"
    )

    print(wf)
    remote_wf = remote.fast_register_workflow(
        entity=wf,
    )

    wf_exe = remote.execute(entity=remote_wf, inputs={"name": "mike"})
    print(wf_exe.id)

You can run python test_register.py or python ../test_register.py under func_dir without worrying about the source_path.
What changes were proposed in this pull request?

Added an function register_workflow_script_mode, which basically leverages register_scripts, but automatically handles the source_path and module_name params. Also resolved the problem of calling register_script in the __main__ block when the registered workflow is in the same file as the __main__ block.
How was this patch tested?

unit test
remote integration test
local testing

Since we didn't export FLYTE_PYTHON_PACKAGE_ROOT and an __init__.py resides under our module register_test, it raises an error

After export works fine

here an __init__.py also resides under issue_register, without export would raise an error

execute with relative path, again, an __init__.py resides under issue_register, without export would raise an error

Conclusion:
when current working dir is inside the module and you want to execute register_workflow_script_mode, please run export FLYTE_PYTHON_PACKAGE_ROOT=".". While executing in the parent dir of the module works fine.
Test Importing workflows
Results of python entrypoint.py
init.py under register_test, need export

entrypoint.py
from issue_register.test_register import wf as sub_wf
from flytekit import workflow
import pdb
import os

@workflow
def wf(name: str = "union") -> str:
    return sub_wf(name=name)[0]

if __name__ == "__main__":
    from flytekit.remote import FlyteRemote
    from flytekit.configuration import Config, SerializationSettings, ImageConfig, FastSerializationSettings
    import pathlib
    CONFIG = os.environ.get("FLYTECTL_CONFIG", str(pathlib.Path.home() / ".flyte" / "config-sandbox.yaml"))

    remote = FlyteRemote(
        config=Config.auto(config_file=CONFIG),
        default_project="flytesnacks",
        default_domain="development"
    )

    remote_sub_wf = remote.fast_register_workflow(
        entity=sub_wf,
    )
    remote_wf = remote.fast_register_workflow(
        entity=wf,
    )
    from issue_register.func_dir.test_register_in_func import register_wf
    func_remote_wf = register_wf(remote)
    remote.execute(entity=func_remote_wf, inputs={"name": "mike666"}, wait=True)

    subwf_exe = remote.execute(entity=remote_sub_wf, inputs={"name": "mike666"}, wait=True)
    wf_exe = remote.execute(entity=remote_wf, inputs={"name": "mike"}, wait=True)
    # pdb.set_trace()
    print("Func Remote", func_remote_wf.id)
    print("Remote SubWF", subwf_exe.id)
    print("Remote WF", wf_exe.id)

test_register_in_func.py
from issue_register.test_register import wf

def register_wf(remote):
    from flytekit.remote import FlyteRemote
    from flytekit.configuration import Config, SerializationSettings, ImageConfig, FastSerializationSettings
    import pathlib
    import os

    remote_wf = remote.fast_register_workflow(
        entity=wf,
        version="f0.0.1",
    )

    return remote_wf

Setup process
Screenshots
test_register.py

entrypoint.py

Check all the applicable boxes

[ ] I updated the documentation accordingly.
[x] All new and existing tests passed.
[x] All commits are signed-off.

Related PRs

Docs link

@pingsutw Does this implementation work with imported workflows?
from my_lib.workflows import my_wf
from flytekit.remote import FlyteRemote

remote = FlyteRemote(...)
remote.register_workflow(my_wf)

@thomasjpfan Hi, this supports imported workflows. As for the fast flag, I can use a separate function just as my earlier version does if that's the desired implementation.

Hey @novahow - any chance you can spend a bit more time on this and help us understand a few things please?  Thank you for working on this, I know it's tricky.
This change is leading to some weird behavior and I think part of it is working by coincidence.  We noticed this because of a test that was failing in Pycharm but passing in CI.  But you can reproduce a similar error just with pytest.
For example, this command passes
pytest -svv tests/flytekit/unit/core/test_type_hints.py::test_union_type

but this command fails
python -m pytest -svv tests/flytekit/unit/core/test_type_hints.py::test_union_type

The error it fails with is
E        Regex: "Error\\ encountered\\ while\\ converting\\ inputs\\ of\\ 'tests\\.flytekit\\.unit\\.core\\.test_type_hints\\.t2':\\\n\\ \\ Cannot\\ convert\\ from\\ Flyte\\ Serialized\\ object\\ \\(Literal\\):"
E        Input: "Error encountered while converting inputs of 'envs.flytekit.lib.python3.12.site-packages.pytest.__main__.tests.flytekit.unit.core.test_type_hints.t2':\n  Cannot convert from Flyte Serialized object (Literal):\n  scalar:\n    union:\n      value:\n        scalar:\n          primitive:\n            string_value: 2\n      type:\n        simple: 3\n        structure:\n          tag: str to typing.Union[float, dict] (using tag str)"

Both of these tests are run from the base of flytekit at /Users/ytong/go/src/github.com/flyteorg/flytekit.  The difference is in the error message, notice the name of the task is different, in the latter case, it is prepended with the actual pytest file.  (Note this is a separate discussion than the {exec_prefix} string that's in the test, that's not relevant here.)
If you uncomment line 42 in this branch though then that second command will also work.
The reason is that line 42 throws a ValueError, because there is no relative path from /Users/ytong/envs/flytekit/lib/python3.12/site-packages/pytest/__main__.py to the flytekit directory (which is cwd).
Why does running pytest directly work?  Because when you run it directly, file on line 58 is /Users/ytong/envs/flytekit/bin/pytest instead of the __main__.py in site packages, and /Users/ytong/envs/flytekit/bin/pytest is not loadable.  So it fails, raises a ModuleNotFoundError, resulting in _get_module_from_main returning None.  Returning None from this function basically causes a bunch of other logic to interpret the file holding the task as not a if __name__ == '__main__' type file.
Can you revisit this section a bit please?  Was the switch from relative_to to commonpath only to get the ../test_register.py case working?  If so, can we think of another way around this?  The above behavior makes me feel like there's another way to do this.  Can you explain what the error was that made this change necessary?  Is it only in the run time case (in the task container at run time)?
Also separately, on line 56, does root_dir need to be at index 0?  Or can it be appended to the end?  If it needs to be at 0 could you explain why?

Hey @novahow - any chance you can spend a bit more time on this and help us understand a few things please? Thank you for working on this, I know it's tricky.
This change is leading to some weird behavior and I think part of it is working by coincidence. We noticed this because of a test that was failing in Pycharm but passing in CI. But you can reproduce a similar error just with pytest.
For example, this command passes
pytest -svv tests/flytekit/unit/core/test_type_hints.py::test_union_type

but this command fails
python -m pytest -svv tests/flytekit/unit/core/test_type_hints.py::test_union_type

The error it fails with is
E        Regex: "Error\\ encountered\\ while\\ converting\\ inputs\\ of\\ 'tests\\.flytekit\\.unit\\.core\\.test_type_hints\\.t2':\\\n\\ \\ Cannot\\ convert\\ from\\ Flyte\\ Serialized\\ object\\ \\(Literal\\):"
E        Input: "Error encountered while converting inputs of 'envs.flytekit.lib.python3.12.site-packages.pytest.__main__.tests.flytekit.unit.core.test_type_hints.t2':\n  Cannot convert from Flyte Serialized object (Literal):\n  scalar:\n    union:\n      value:\n        scalar:\n          primitive:\n            string_value: 2\n      type:\n        simple: 3\n        structure:\n          tag: str to typing.Union[float, dict] (using tag str)"

Both of these tests are run from the base of flytekit at /Users/ytong/go/src/github.com/flyteorg/flytekit. The difference is in the error message, notice the name of the task is different, in the latter case, it is prepended with the actual pytest file. (Note this is a separate discussion than the {exec_prefix} string that's in the test, that's not relevant here.)
If you uncomment line 42 in this branch though then that second command will also work.
The reason is that line 42 throws a ValueError, because there is no relative path from /Users/ytong/envs/flytekit/lib/python3.12/site-packages/pytest/__main__.py to the flytekit directory (which is cwd).
Why does running pytest directly work? Because when you run it directly, file on line 58 is /Users/ytong/envs/flytekit/bin/pytest instead of the __main__.py in site packages, and /Users/ytong/envs/flytekit/bin/pytest is not loadable. So it fails, raises a ModuleNotFoundError, resulting in _get_module_from_main returning None. Returning None from this function basically causes a bunch of other logic to interpret the file holding the task as not a if __name__ == '__main__' type file.
Can you revisit this section a bit please? Was the switch from relative_to to commonpath only to get the ../test_register.py case working? If so, can we think of another way around this? The above behavior makes me feel like there's another way to do this. Can you explain what the error was that made this change necessary? Is it only in the run time case (in the task container at run time)?
Also separately, on line 56, does root_dir need to be at index 0? Or can it be appended to the end? If it needs to be at 0 could you explain why?

sorry for the inconvenience this PR brought, I will take a look at it, thanks for the reminder.

@wild-endeavor Yeah I believe the commanpath change was for executing from inside a module. Currently I haven't come up with a workaround if we want to support that without affecting the python -m pytest issue, as for now I can only disable that support to make the testing work

but can't support additional feature

What is the additional feature?

What is the additional feature?

executing something like python ../entrypoint.py would be disabled. while we may still be able to do python entrypoint.py without requiring to make it an module with some __init__.py

could we do that then?  i think that will make it a lot clearer, and when sufficient people ask for the .. pattern we can try a different way to support it.


No vi-style keymaps for Flycheck or Smerge

Currently, Flycheck and Smerge only have Emacs-style (CTRL-c) key bindings, which are a bit of a pain to use.

What keybinds are you referring to? Flycheck has a number of evilified keybinds, like ]e and [e for navigating errors and SPC c x or :er[rors] ex command to open the error list (flycheck-list-errors).
There are also flycheck-error-list-mode keybinds provided by evil-collection:
(evil-collection-define-key 'normal 'flycheck-error-list-mode-map
    "gj" 'flycheck-error-list-next-error
    "gk" 'flycheck-error-list-previous-error
    (kbd "C-j") 'flycheck-error-list-next-error
    (kbd "C-k") 'flycheck-error-list-previous-error
    "]" 'flycheck-error-list-next-error
    "[" 'flycheck-error-list-previous-error
    "gr" 'flycheck-error-list-check-source
    "s" 'flycheck-error-list-set-filter
    "S" 'flycheck-error-list-reset-filter
    "x" 'flycheck-error-list-explain-error
    (kbd "<return>") 'flycheck-error-list-goto-error
    "q" 'quit-window)

However, there aren't any smerge keybinds that I know of. Could you offer suggestions for them?

For flycheck, I have
        (:prefix-map ("C" . "Flycheck")
          :desc "Describe checker"          "?" #'flycheck-describe-checker
          :desc "Clear"                     "C" #'flycheck-clear
          :desc "Show error"                "h" #'flycheck-display-error-at-point
          :desc "Version"                   "V" #'flycheck-version
          :desc "Check buffer"              "c" #'flycheck-buffer
          :desc "Explain error"             "e" #'flycheck-explain-error-at-point
          :desc "Manual"                    "i" #'flycheck-manual
          :desc "List errors"               "l" #'flycheck-list-errors
          :desc "Next error"                "[" #'flycheck-next-error
          :desc "Previous error"            "]" #'flycheck-previous-error
          :desc "Select checker"            "s" #'flycheck-select-checker
          :desc "Verify setup"              "v" #'flycheck-verify-setup
          :desc "Disable checker"           "x" #'flycheck-disable-checker
          :desc "Compile"                   "b" #'flycheck-compile
          :desc "Copy error"                "w" #'flycheck-copy-errors-as-kill)

Under the c (code) binding.
Personally, I've switched to ediff for resolving git conflicts, so I don't need smerge bindings anymore (what I found confusing about ediff before is that when you're done you have to quit the session without saving anything, and magit automatically picks up the changes made).

The only smerge binding I know of comes from #2512 and is only active if you also use hydra. Current evil flycheck bindings work fine for me though, ]e and [e mainly.
I would love to see some more discoverable smerge bindings, C-c ^ is a little annoying to use.


Kubebuilder update

https://github.com/open-cluster-management/backlog/issues/15525

/cherry-pick release-2.3


CDN-in-a-Box readiness CI test

What does this PR (Pull Request) do?

Adds a GitHub Actions workflow that

Builds the RPMs, docs, and source tarball, and makes them available as artifacts
Starts the CDN-in-a-Box and exits with the status of the readiness container (or aborts if the readiness container is still running 10 minutes after CDN-in-a-Box is started)

Replaces CDN-in-a-Box single-files bind mounts (set-dns.sh, insert-self-into-dns.sh, set-self-dns.sh, set-dns-update.sh, set-to-ips-from-dns.sh, caches' init.d/99-run.sh) with Dockerfile layers that add those files
Adds the CDN-in-a-Box origin content directory to the origin image instead of mounting it

[x] This PR is not related to any Issue

PR builds off of @ocket8888's workflow and actions.
Which Traffic Control components are affected by this PR?

CDN in a Box
CI tests

The following criteria are ALL met by this PR

[x] This PR includes tests
[x] This PR includes documentation in the GitHub Actions READMEs
[x] This PR includes an update to CHANGELOG.md
[x] This PR includes any and all required license headers
[x] This PR does not include a database migration
[x] This PR DOES NOT FIX A SERIOUS SECURITY VULNERABILITY (see the Apache Software Foundation's security guidelines for details)

Looking at the logs for the most recent run of checks against this branch, it appears that the readiness container was never able to reach Traffic Ops, yet the run was marked as a success.

It exits early because the timeout command was lacking the -f flag:
if ! timeout 10m $docker_compose logs readiness; then

-f added in b5d892e77d.
But now that I'm thinking about it,


Rke2 example manifests

This PR comes after https://github.com/suse-edge/metal3-demo/pull/26. It features the separated rke2 sample cluster deployment files, as well as the combined file. The combined file is the one that's meant to be deployed. It also has hardcoded values that align with the configuration shown in all of the other readmes

Since #26 landed this will need a rebase @dbw7 then we can review, thanks!

@atanasdinov please could you review?  I believe you have tested these, and also started work on an alternative DHCP-only version - it'd be good to make progress on either landing these or potentially the DHCP-only version if we're not ready to demonstrate the usage of the IPPool components.


Remove kubectl setup parts that were relevant to CaaSP3 only

bye velum!

You will be missed ... by NO ONE!

rebased


Add files via upload

new school

@jim19770812 I have to close the request without merging. A domain of cmu.edu.pl is a fake, there is no university with this domain. Does your email address end with @buct.edu.cn? If yes, please ensure you are familiar with this repository rules located at the bottom of this page and submit a new request with correct information. Thank you for the understanding!


Make Gradle init not destructive when issued in the user home folder

Partial solution for https://github.com/gradle/gradle/issues/17803
The PR addresses the issue partially. It only checks if the project directory, where gradle init is run is the same as the user home directory and if there is already a .gradle folder there, in which case the init task won't run.

@bot-gradle

Sorry I don't understand what you said.
Currently I support the following commands:

@bot-gradle test {BuildStage} to trigger a build

e.g. @bot-gradle test SanityCheck plz
SanityCheck/CompileAll/QuickFeedbackLinux/QuickFeedback/ReadyForMerge/ReadyForNightly/ReadyForRelease are supported
test this means test ReadyForMerge
test and merge to trigger a pre-tested commit build
cancel to cancel a running pre-tested commit build or remove it from queue
SanityCheck can be abbreviated as SC, ReadyForMerge as RFM, etc.
Specific builds:

AST: AllSmokeTestsReadyForMerge
AFT: AllFunctionalTestsReadyForMerge
ASB: AllSpecificBuildsReadyForMerge
ACC: AllConfigCacheTestsReadyForMerge
ACT: AllCrossVersionTestsReadyForNightly
APTN: AllPerformanceTestsReadyForNightly
AFTN: AllFunctionalTestsReadyForNightly
ACTR: AllCrossVersionTestsReadyForRelease
AFTR: AllFunctionalTestsReadyForRelease

@bot-gradle help to display this message
@bot-gradle clean to clear the conversation history

@bot-gradle test qFL

OK, I've already triggered QuickFeedbackLinux build for you.

@bot-gradle test RFM

OK, I've already triggered ReadyForMerge build for you.

@gitbot test RFM

@bot-gradle test RFM

OK, I've already triggered ReadyForMerge build for you.

@bot-gradle test RFM

OK, I've already triggered ReadyForMerge build for you.

@bot-gradle test RFM

OK, I've already triggered ReadyForMerge build for you.

@bot-gradle test and merge

OK, I've already triggered a build for you.


[Request] Config option to adjust Masked "stop and stare" range

Low priority, but I think this would fit in with the rest of TME's Masked modifications.
It would be nice to have a setting to adjust the "stop and stare" range from the player.  Ideally this could be a random range specified by the player (e.g. StopAndStareRange = X,Y; X = Y = vanilla default to leave vanilla behavior in tact)
Thanks for the consideration

Well, if you are referring to changing the distance at which the masked enemies will stop, and then stare at you, there's a few issues with this.
Let me preface by saying I try quite hard not to change the mechanics of the masked enemies. The only exception right now, is that I increase the duration at which they will stare at you, which is actually relatively safe to do, in terms of conflicts with other game elements and with mod compatibility. It wouldn't make sense to add this feature with such a short vanilla stop and stare duration.
Currently in the vanilla game, they are set to stop and stare at you when you see you, at any distance. I could adjust this, but it would require more code, and more tampering with the MaskedPlayerEnemy AI, because when they originally try to stop and stare, I would have to stop it, and then manually allow it again once they get within the emote range.
It probably wouldn't be that hard to implement, but it does require changing their behaviour a bit more than just increasing the stop and stare duration time, so I'm kinda hesitant right now. I will say that I like this idea, and I will probably attempt something like this soon, but I will think about this for a little bit to find the way way to implement this without breaking other mods in the process lol. I will keep this ticket open as a reminder to add this in later.

I understand completely if it's too messy or just something you decide is a bit too out-of-scope based on TME.  I appreciate the response and you keeping it in mind for a future update.
For a bit of context, it seems like the Masked emoting behavior is... not quite consistent?  It feels like the Masked initial emote isn't really effective because they're required to get essentially right next to the player before launching into the Masked emote handling.  This was the simplest/most-effective fix I could think of -- that would also make the Masked behavior more interesting/satisfying in my opinion.
Regardless, thanks for the substantive response.
I found a (minor?) Masked issue with TME 1.9.0 that I was going to wait to report until I had a bit more info, but I'll drop it here for now.  I haven't had time to work up any meaningful report on the error getting thrown, but noting it for now (will create a full ticket if it persists and I get a better understanding):

Did the masked enemies break after you saw that error? I believe that error is handled correctly, so I don't think it's causing issues currently. (could be wrong) but I shouldn't be trying to map the CameraContainer onto masked enemies. I'll get this fixed. Thanks!

I did some brief testing on 1.9.3, and despite the errors thrown masked seem to work without any obvious issues.  But I only tested it briefly.
(Just wanted to provide a quick update now that I had the time to check)


What does showAdvancedMembers mean?

I noticed a setting called showAdvancedMembers when poking around to see what setting inputs the language server takes in to enable customization of a user's experience.
What does this setting mean?  Is it still used, or is it a relic of some since-removed code (b/c I can't see it referred to anywhere).

I guess I could ask similar questions about other settings that are passed into the language server (e.g. symbolsHierarchyDepthLimit) - where are these used?  Github search isn't turning up many results for me - I only see defaults and the assignment of the variable.  I guess, in general, I'm wondering what settings this language server now accepts to customize its inner-workings (analysis, caching, etc.) as well as user-experience things (e.g. autocomplete with parens, outline depth, etc.)

All of those settings seem to be dead code and leftovers from the pre-rewrite language server. I believe showAdvancedMembers controlled when dunder methods would show. The symbols settings limited the symbol indexing (the outline, workspace search), but needed to move during the rewrite and instead get limited at request time rather than hardcoded.
There's a bunch of old setting cruft we could remove, just haven't had the time to yet.

Nice - thanks for the answer!
Follow-up request: it would be great if there was up-to-date docs w.r.t. what options can be passed to this language server (I guess one could read the code, but still).
Closing as my original question was answered.

Yes, definitely. See also #469, #794, #1184, #1212, #1340. Our focus has been on getting things to work and fixing bugs, so docs and settings cleanups just haven't happened.


chore: snake-case attributes

As discussed in this week's dev meeting, this renames all attributes to use the snake-case convention. More specifically and for future reference, the following attributes have been renamed:
alwaysInline -> always_inline
appUnexpander -> app_unexpander
attrParser -> attr_parser
builtinAttrParser -> builtin_attr_parser
builtinCategoryParenthesizer -> builtin_category_parenthesizer
builtinCommandElab -> builtin_command_elab
builtinCommandParser -> builtin_command_parser
builtinDelab -> builtin_delab
builtinDoElemParser -> builtin_doElem_parser
builtinFormatter -> builtin_formatter
builtinInit -> builtin_init
builtinLevelParser -> builtin_level_parser
builtinMacro -> builtin_macro
builtinMissingDocsHandler -> builtin_missing_docs_handler
builtinParenthesizer -> builtin_parenthesizer
builtinPrecParser -> builtin_prec_parser
builtinPrioParser -> builtin_prio_parser
builtinQuotPrecheck -> builtin_quot_precheck
builtinSyntaxParser -> builtin_syntax_parser
builtinTactic -> builtin_tactic
builtinTacticParser -> builtin_tactic_parser
builtinTermElab -> builtin_term_elab
builtinTermParser -> builtin_term_parser
categoryParenthesizer -> category_parenthesizer
combinatorFormatter -> combinator_formatter
combinatorParenthesizer -> combinator_parenthesizer
commandElab -> command_elab
commandParser -> command_parser
computedField -> computed_field
defaultInstance -> default_instance
doElemParser -> doElem_parser
elabAsElim -> elab_as_elim
elabWithoutExpectedType -> elab_without_expected_type
implementedBy -> implemented_by
inferTCGoalsRL -> infer_tc_goals_rl
inheritDoc -> inherit_doc
inlineIfReduce -> inline_if_reduce
macroInline -> macro_inline
matchPattern -> match_pattern
missingDocsHandler -> missing_docs_handler
neverExtract -> never_extract
precParser -> prec_parser
prioParser -> prio_parser
quotPrecheck -> quot_precheck
runBuiltinParserAttributeHooks -> run_builtin_parser_attribute_hooks
runParserAttributeHooks -> run_parser_attribute_hooks
serverRpcMethod -> server_rpc_method
stxParser -> stx_parser
tacticParser -> tactic_parser
termElab -> term_elab
termParser -> term_parser
unificationHint -> unification_hint
unusedVariablesIgnoreFn -> unused_variables_ignore_fn

The lake attributes have also been renamed, for consistency:
defaultTarget -> default_target
externLib -> extern_lib
leanExe -> lean_exe
leanLib -> lean_lib
libraryFacet -> library_facet
moduleFacet -> module_facet
packageDep -> package_dep
packageFacet -> package_facet

The nix build is failing due to breakage in LeanInk, which I didn't realize was a dependency. How are changes in LeanInk tracked? I'm not really sure how to update that in concert with everything else.

How are changes in LeanInk tracked?

The LeanInk revision is specified in the flake.lock file for Nix.  You can update it with nix flake update.
I must warn you that I have put a small hack in the lockfile: the lockfile refers to my personal fork, while the flake.nix file says leanprover/LeanInk. :smile:  I should probably ask for write access to that repo to merge https://github.com/leanprover/LeanInk/pull/36

@gebner I don't suppose I can ask you to do that? I don't have or use nix at all, and while I was hoping to find/replace your commit in the lockfile for my commit (leanprover/LeanInk#37), I can find neither your commit nor indeed LeanInk at all in the flake.lock file.

I can find neither your commit

Oh, I think I force-pushed a fix to that branch before merging the PR but forgot about updating the lockfile.  Now I'm kinda surprised that it still builds..  Maybe it's stored in cachix?
I've pushed a flake.lock "update."

@gebner Any pending issues? If not, let's merge before the PR rots.

:+1: for merging this PR before it rots.  We should merge the accumulated LeanInk PRs though (I'd do it myself if I could).


secretStore fails to create GCP secretmanager client using workloadidentity

Hi we have been using ESO with gcp secret manager so far we tested it with using service accounts directly
once we tried to upload key.json including service account in gcp shell in project and another time we used it with runtime service account secret and they both perfectly fine worked for us
this time we are trying workload identity and we have followed the eso docs and we still receive the error below
these two links we also applied manually but didn't help us
https://external-secrets.io/v0.5.3/provider-google-secrets-manager/
https://medium.com/google-cloud/automated-sync-among-gcp-secrets-gke-workload-4797913576f2
https://issuehint.com/issue/external-secrets/external-secrets/1156
for some reasons I am not able to share the details of our code but the pattern is what is mentioned in this post by somebody else who was facing same exact error but their solution didn't help us
our code is super similar to this https://issuehint.com/issue/external-secrets/external-secrets/1156
the error we get after we run kubectl describe secretStore gcp -n namespace
failed to create GCP secretmanager client: unable to fetch identitybindingtoken: could not get idbindtoken token, status: 404

hi @mahsa2017 ! Unfortunately we cannot do much if you cannot share your manifests.
The issue you mentioned was a set of misconfiguration. I suggest you to double check if you have setup workload identity correctly, and properly configured the region/location and projectID.

Ok I will make some changes to the code but leave the necessary parts so u can hopefully spot what is missing
this is service account
apiVersion: v1 kind: ServiceAccount metadata:   name: {{ .Values.appName }}-service-account   namespace: {{ .Release.Namespace }}   labels:     {{- include "template-version-label" . | indent 4}} {{- if eq .Values.cloudProvider "gcp" }}   annotations:     iam.gke.io/gcp-service-account: {{ .Release.Namespace }}-runtime@{{ .Values.projectId }}.iam.gserviceaccount.com {{- end }}
this is secretStore
apiVersion: external-secrets.io/v1beta1 kind: SecretStore metadata:   name: {{ .Values.externalSecret.secretStoreName }} spec:   provider:       gcpsm:         projectID: {{ .Values.projectId }}         auth:            workloadIdentity:             clusterName: "name-of-cluster"             clusterLocation: "us-east1-d"             serviceAccountRef:               name: {{ .Values.appName }}-service-account
and I checked the clusterInfo is correct and also workloadidentity is enabled in that GKE cluster.@gusfcarvalho thanks

Ok I will make some changes to the code but leave the necessary parts so u can hopefully spot what is missing
this is service account
apiVersion: v1
kind: ServiceAccount
metadata:
  name: {{ .Values.appName }}-service-account
  namespace: {{ .Release.Namespace }}
  labels:
    {{- include "template-version-label" . | indent 4}}
{{- if eq .Values.cloudProvider "gcp" }}
  annotations:
    iam.gke.io/gcp-service-account: {{ .Release.Namespace }}-runtime@{{ .Values.projectId }}.iam.gserviceaccount.com
{{- end }}

and secretStore
apiVersion: external-secrets.io/v1beta1
kind: SecretStore
metadata:
  name: {{ .Values.externalSecret.secretStoreName }}
spec:
  provider:
      gcpsm:
        projectID: {{ .Values.projectId }}
        auth:
          workloadIdentity:
            clusterName: "name-of-cluster"
            clusterLocation: "us-east1-d"
            serviceAccountRef:
              name: {{ .Values.appName }}-service-account

and I checked the clusterInfo is correct and also workloadidentity is enabled in that GKE cluster
@gusfcarvalho  Thanks

Another point as a suggestion to the documentation would be where in this link the ClusterSecretStore example and value for this field is provided as team-a but it actually should be the name of serviceAccount which is external-secrets am I correct?
serviceAccountRef:
            name: team-a
```------> name should be external-secrets as the created service account metadata.name

this is the link to documentation which I am talking about
 https://external-secrets.io/v0.7.2/provider/google-secrets-manager/#workload-identity

@gusfcarvalho can you please check my code and share your opinion

@gusfcarvalho  last update from our issue is we are receiving the error below
failed to create GCP secretmanager client: unable to generate gcp access token: rpc error: code = PermissionDenied desc = Permission 'iam.serviceAccounts.getAccessToken' denied on resource (or it may not exist).
error details: name = ErrorInfo reason = IAM_PERMISSION_DENIED domain = iam.googleapis.com metadata = map[permission:iam.serviceAccounts.getAccessToken]
but our IAM service account has all the roles below:
Cloud SQL Client
Logs Writer
Secret Manager Admin
Secret Manager Secret Accessor
Service Account Token Creator
Workload Identity User

yes

This is covered by our e2e tests, please take a look at these: https://github.com/external-secrets/external-secrets/blob/main/terraform/gcp/eso_gcp_modules/gke/main.tf
They use workloadidentity, this should pretty match your setup then. Is the cluster location really us-east1-d, is it a regional or zonal cluster ?

@moolen it says locationType: regional in GCP cluster details.
Given that should we pass with -d or without -d ? I mean clusterLocation in secretStore.
Thank you


Fix recommendations request

Hey, man. Great work with this lib.
I'm just sending a little fix:

Fix recommendantions request: change param to params

Ah thanks for noticing that, lgtm :)


Added support for Visual Studio 2015

Added support for Visual Studio 2015.

Great!  Is Windows 10 also a problem?


Decide how test directories should be structured and prioritize tests

To keep our code clean, we should come up with test guidelines which include where tests are kept in terms of golang directory, and what kind of coverage we are looking to build.
When we have new contributors or even just for ourselves, we could point people to this readme file as a general guideline.
Golang general style will take precedence, if there is an existing recommendation, we should follow that first before creating our own exceptions.

@ajlacey and @j4qfrost so my understanding is that this has been decided and we have documentation written about how tests are written on a branch that I'm working on.
From a CI perspective, golang allows go test from a parent directory. Please let me know if there are any considerations we have not covered related to the above.


#11Implemented Wait function

Implemented Wait function. Check issue #11
This problem was before but it was hidden by time.Sleep
https://github.com/radovskyb/watcher/blob/27b48fd63be1e672008140b9f99ae2a9dd3888fe/example/basics/main.go#L73
There are problem with TriggerEvent . This function doesn't emulate os events. This function just change state of watcher. It's wrong!
When I used examples and I was trying  TriggerEvent  before Start it's always was success.
This function can be useful but definitely not for test
And definitely should have w.Wait  inside
update
I just added w.Wait  inside TriggerEvent

Hey @im7mortal, I like the idea to have a Wait function, but since I already updated the master branch, there are too many things that would need to be resolved before adding it in from this pull request, but feel free to to resubmit a new pull request that fits in with the new dev branch and I can have a look at it there 👍
I would have already added it myself, but I'm not sure if it's possible for me to create a commit which adds you to the contributors list, so if you would like, go ahead and commit it first, but if not, I'll try to commit it with you as the contributor for it since it was your idea.


allow creating a draft release

Codecov Report

Merging #7 (aa56406) into main (afdf841) will decrease coverage by 0.13%.
The diff coverage is 0.00%.

:exclamation: Current head aa56406 differs from pull request most recent head afb9d17. Consider uploading reports for the commit afb9d17 to get more accurate results

:exclamation: Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.
Additional details and impacted files

@@             Coverage Diff              @@
##               main       #7      +/-   ##
============================================
- Coverage     71.60%   71.47%   -0.13%
  Complexity      366      366
============================================
  Files            38       38
  Lines          1141     1143       +2
============================================
  Hits            817      817
- Misses          324      326       +2

Flag
Coverage Δ

7.4
71.45% <0.00%> (-0.13%)
:arrow_down:

8.0
71.45% <0.00%> (-0.13%)
:arrow_down:

8.1
71.45% <0.00%> (-0.13%)
:arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files
Coverage Δ

src/Console/Command/Release/ReleaseCommand.php
0.00% <0.00%> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update afdf841...afb9d17. Read the comment docs.


Ray Line [BUG]

Expected Behavior
Creating a ray line and then wanting to delete it when it is deleted visually takes you back in time. If I try to use live data when creating the ray line the candles start to run with space between candles and when removing the line it goes to the past visually. This is an example of the behavior.
https://github.com/louisnw01/lightweight-charts-python/assets/150294229/923fbda8-0c85-46e9-b39c-6cfbb643211c
Current Behaviour
i explain
Reproducible Example
N/A

Environment
OS: macOS 13.2
Library: <IP_ADDRESS>

https://github.com/louisnw01/lightweight-charts-python/assets/150294229/9464ce2b-07f2-4e71-9fb6-dc0885162719

And also     chart.grid(False)
is not working can see horizontal lines in background.

Fixed in the latest version.
Louis


Dialog doesn't close by tapping on "onConfirmBtnTap".

Dialog doesn't close when we use to tap "onConfirmBtnTap".
CoolAlert.show(
              context: context,
              type: CoolAlertType.success,
              text: responseData['msg'],
              onConfirmBtnTap: ( ){ ... }
        }

And How to hide the "loading" dialog automatically?
CoolAlert.show(
                      context: context,
                      type: CoolAlertType.loading,
                    );

Hi, if you want to close the dialog you'd have to handle that yourself. All
you need to do is call Navigator.pop(context);
On Fri, 11 Dec 2020, 5:21 am Irfan Akram<EMAIL_ADDRESS>wrote:

Dialog doesn't close when we use to tap "onConfirmBtnTap".
CoolAlert.show(
context: context,
type: CoolAlertType.success,
text: responseData['msg'],
onConfirmBtnTap: ( ){ ... }
}
And How to hide the "loading" dialog automatically?
CoolAlert.show(
context: context,
type: CoolAlertType.loading,
);
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/emrade/flutter_cool_alert/issues/6, or unsubscribe
https://github.com/notifications/unsubscribe-auth/AGAMVZUJND3U67SJZRB2IODSUGT5FANCNFSM4UWCIR5A
.

Hello, If I used Navigator.pop(context); it will get me back from that screen, but if I want to stay on same page?

No it won't close the page. If you have the dialog open and you trigger a Navigator.pop, the dialog closes and not the page.

Hi, if you want to close the dialog you'd have to handle that yourself. All you need to do is call Navigator.pop(context);
…
On Fri, 11 Dec 2020, 5:21 am Irfan Akram, @.***> wrote: Dialog doesn't close when we use to tap "onConfirmBtnTap". CoolAlert.show( context: context, type: CoolAlertType.success, text: responseData['msg'], onConfirmBtnTap: ( ){ ... } } And How to hide the "loading" dialog automatically? CoolAlert.show( context: context, type: CoolAlertType.loading, ); — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub <#6>, or unsubscribe https://github.com/notifications/unsubscribe-auth/AGAMVZUJND3U67SJZRB2IODSUGT5FANCNFSM4UWCIR5A .

@webmasterscity i dunno why you would give a thumbs down to my answer but it's common knowledge that to close a dialog, all you have to do is pop it.
You can refer to this article @irfan0429 @webmasterscity
https://stackoverflow.com/questions/50683524/how-to-dismiss-flutter-dialog

Hi, if you want to close the dialog you'd have to handle that yourself. All you need to do is call Navigator.pop(context);
…
On Fri, 11 Dec 2020, 5:21 am Irfan Akram, @.***> wrote: Dialog doesn't close when we use to tap "onConfirmBtnTap". CoolAlert.show( context: context, type: CoolAlertType.success, text: responseData['msg'], onConfirmBtnTap: ( ){ ... } } And How to hide the "loading" dialog automatically? CoolAlert.show( context: context, type: CoolAlertType.loading, ); — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub <#6>, or unsubscribe https://github.com/notifications/unsubscribe-auth/AGAMVZUJND3U67SJZRB2IODSUGT5FANCNFSM4UWCIR5A .

@webmasterscity i dunno why you would give a thumbs down to my answer but it's common knowledge that to close a dialog, all you have to do is pop it.
You can refer to this article @irfan0429 @webmasterscity
https://stackoverflow.com/questions/50683524/how-to-dismiss-flutter-dialog

yes but i am using  cool_alert: ^1.1.0   and I am trying in onConfirmBtnTap as when you click on btn than it goes to another page but in cool_alert it will redirect to new page but not close the dialog and when i use   Navigator.pop(context);   on before redirect  but same not close and when i use it after redirect and it redirect and came in same page


Add Codemeta

Add codemeta as a metadata input format for Github-based records like the current .zenodo.json file.
This is fully working with a companion PR to apply the same behavior to Zenodo https://github.com/zenodo/zenodo/pull/2010.
I do the metadata conversion in https://github.com/caltechlibrary/convert_codemeta, and the tests for the Zenodo format are in that package.

This is working for me as expected, and I'd be happy to hear any feedback. I know some of this package is going to have to be refactored for InvenioRDM; if some of that makes sense to do now let me know.


TypeError: Cannot cast ufunc add output ...

...
[66] random_holdout_set_from_training_data's score is: 0.678
[68] random_holdout_set_from_training_data's score is: 0.675
The number of estimators that were the best for this training dataset: 39
The best score on the holdout set: 0.688453159041
Finished training the pipeline!
Total training time:
0:00:08

Here are the results from our GradientBoostingClassifier
predicting Label
Calculating feature responses, for advanced analytics.
---------------------------------------------------------------------------
TypeError                                 Traceback (most recent call last)
<ipython-input-64-23d85ace19e4> in <module>()
----> 1 ml_predictor.train(X_train)

C:\Python36\lib\site-packages\auto_ml\predictor.py in train(***failed resolving arguments***)
    639
    640         # This is our main logic for how we train the final model
--> 641         self.trained_final_model = self.train_ml_estimator(self.model_names, self._scorer, X_df, y)
    642
    643         if self.ensemble_config is not None and len(self.ensemble_config) > 0:

C:\Python36\lib\site-packages\auto_ml\predictor.py in train_ml_estimator(self, estimator_names, scoring, X_df, y, feature_learning, prediction_interval)
   1202         # Use Case 1: Super straightforward: just train a single, non-optimized model
   1203         elif (feature_learning == True and self.optimize_feature_learning != True) or (len(estimator_names) == 1 and self.optimize_final_model != True):
-> 1204             trained_final_model = self.fit_single_pipeline(X_df, y, estimator_names[0], feature_learning=feature_learning, prediction_interval=False)
   1205
   1206         # Use Case 2: Compare a bunch of models, but don't optimize any of them

C:\Python36\lib\site-packages\auto_ml\predictor.py in fit_single_pipeline(self, X_df, y, model_name, feature_learning, prediction_interval)
    854         # That saves a considerable amount of time
    855         if feature_learning == False:
--> 856             self.print_results(model_name, ppl, X_df, y)
    857
    858         return ppl

C:\Python36\lib\site-packages\auto_ml\predictor.py in print_results(self, model_name, model, X, y)
   1025                     feature_responses = None
   1026                 else:
-> 1027                     feature_responses = self.create_feature_responses(model, X, y, top_features)
   1028                 self._join_and_print_analytics_results(feature_responses, sorted_model_results, sort_field='Importance')
   1029             except AttributeError as e:

C:\Python36\lib\site-packages\auto_ml\predictor.py in create_feature_responses(self, model, X_transformed, y, top_features)
    992             return col_result
    993
--> 994         all_results = list(map(lambda tup: create_one_feature_response(col_idx=tup[0], col_name=tup[1]), enumerate(feature_names)))
    995
    996         all_results = [x for x in all_results if x is not None]

C:\Python36\lib\site-packages\auto_ml\predictor.py in <lambda>(tup)
    992             return col_result
    993
--> 994         all_results = list(map(lambda tup: create_one_feature_response(col_idx=tup[0], col_name=tup[1]), enumerate(feature_names)))
    995
    996         all_results = [x for x in all_results if x is not None]

C:\Python36\lib\site-packages\auto_ml\predictor.py in create_one_feature_response(col_idx, col_name)
    943                     X[col_name] += col_delta
    944                 else:
--> 945                     X[:, col_idx] += col_delta
    946                 if self.type_of_estimator == 'regressor':
    947                     predictions = model.predict(X)

TypeError: Cannot cast ufunc add output from dtype('float64') to dtype('int64') with casting rule 'same_kind'

Setup is the same as in https://github.com/ClimbsRocks/auto_ml/issues/366 only this time I used columns with continuous features instead of nlp.
I have a bunch of coulmns holding unscaled data; integers between 0 and 5k.

bummer- i'd really hoped it was an nlp issue. i'm pretty flummoxed on what might be causing this. i haven't seen this issue, nor has anyone else i've worked with in person.
although, now i look at it a bit more, this version of the error is probably a dataset issue. if, by chance, you could send over either of these datasets (or at least a sample of it), i'll try to repro and fix the underlying issue. 'til then, i'm just putting in a big try/except so the rest of the process continues uninterrupted, since this is a useful but not-essential side path.
thanks for the bug reports! very helpful to get close to the root cause of this. sorry for the slow response.

Sadly, I cannot share the dataset as its commercial stuff. But I can try to extract a small sample of plain features (numbers) that reproduces the issue.

auto_ml 2.9.9 seems to run fine (without nlp) on my mac - maybe I'll find time to check the win machine later.
FYI: auto_ml reached 0.888 accuracy - I pushed my neural net to 0.922

oh nice! i'm not too surprised by that if it's text. text/nlp is one of the fields that can go either way between neural nets and gbms, depending how much feature engineering you do.
if it's not text/images/video/sound, and neural nets beat a gbm, i'd love to hear more!

Error seems to be gone with 2.9.9. 👍
Accuracy is roughly 40 % with the normalized nlp data. I didn't look at the sources - wonder why it's so low.


Prevent submission of link a second time on Camper News

This seems fairly straightforward. We could first query to see if the url they entered is already present in the stories collection. If it is, we can send them to the related news article that already exists and flash an error message telling them they posted a duplicate link and they should comment on the article instead.


add school to nl.

@semirabdus Please provide us with a proof, which shows that the school recognizes the domain student.nieuw-zuid.nl you are submitting as an official email domain for the students.
Also please confirm that this domain is used exclusively by the students of this school, not by many schools.
You can provide us with any of the following:

A copy of instruction (a hard-copy or electronic one) given to you by the school that tells you to use an email address in this email domain
An URL of a page at the official school website that says that students use this email domain
A reference to a recognized journal where an article was published by someone from the school, with explicit affiliation to the school, and e-mail address from the email domain
A WHOIS data that link the email domain to the school somehow
A copy of official letter from the school representative saying that the school provides e-mail addresses in this domain to the students
Anything else that can prove this fact in similar way, i.e. can be verified independently.

@semirabdus You might miss my previous comment. Please react.

@semirabdus I am sorry, this request remains unanswered for a while. I have to close it without merging. Please reopen and comment if you have an update regarding the aforementioned issue. Thank you for your understanding!


Missing header on Create Pin Screen

Missing screen header (see wireframe)

@jleach is this change in BC Wallet already? or do we need submodule update?


Overridden _PhysicsProcess(double) in C# not called by editor

Godot version
4.0.beta4.mono.official
System information
Windows 10
Issue description
Overridden method _PhysicsProcess(double) is not called by game.
As a note: _PhysicsProcess(float) is not available to be overridden in C#
Steps to reproduce

Create a new project with Node2d as main scene
Create CharacterBody2d in new scene
Create a C# script attached to CharacterBody2d
Override _PhysicsProcess(double)
Insert print statement
Put CharacterBody2d scene in main scene

Minimal reproduction project
No response

Found it was something unknown in my local system after some cleaning and remaking.  Problem disappeared without finding out what happened.


Let tooltips watch changes to title

This PR is to allow the title to be updated dynamically. May not be the best approach but was a quick fix for us. Feel free to take the idea and run with it without a merge from my fork or let me know if you see anything that needs to be changed in the PR.

Note that I put the updateTooltip function on scope in case it was needed later, but really doesn't need to be on scope for this functionality - you could also observe the attribute, but decided to go with a watch instead on scope.title

Thanks for the PR @hoonto. I just have a few points before I merge this in.

The following peice of code is now the updateTooltip function. You could remove this code and call updateTooltip instead to reduce duplicate code. https://github.com/hoonto/angular-tooltips/blob/b4fc933d33db5cc4c2c02a8f2061a0f3608f88c5/src/angular-tooltips.js#L21-L29
Can you put the tooltip variable into the scope as $scope.tooltipElement. https://github.com/hoonto/angular-tooltips/blob/b4fc933d33db5cc4c2c02a8f2061a0f3608f88c5/src/angular-tooltips.js#L12
I think this code could be removed as it is now in the updateTooltip function - https://github.com/hoonto/angular-tooltips/blob/b4fc933d33db5cc4c2c02a8f2061a0f3608f88c5/src/angular-tooltips.js#L149-L153

My pleasure @Tim-Intellipharm , thanks for taking a look. Ok PR updated - good suggestions.


Task 650-663: ParsiNLU-translation

Based on: https://arxiv.org/pdf/2012.06154.pdf

@aarunku5, wondering if you can help review this tasks?

Thanks!
654, 655- In the definition, make it 'the Bible'
656, 657- In the definition, make it 'the Quran'
The rest look good.

Thanks! I fixed it.

Thanks! @swarooprm all the tasks look good here.


⚠ Digital Ocean - https://status.digitalocean.com/ has degraded performance

In e4cdf23, Digital Ocean - https://status.digitalocean.com/ (https://status.digitalocean.com/api/v2/status.json) experienced degraded performance:

HTTP code: 200
Response time: 346 ms

Resolved: Digital Ocean - https://status.digitalocean.com/ performance has improved in 29bef4a after 1 day.


Improved Mobile View of skills page (#380)

Improved mobile view and Icons on the skill page.
Fixes: #380
Screenshots

Original
Updated

original screenshot
updated screenshot

Thanks 🙂

Thanks 🙂


[User Management] User Dashboard UI

[x] Responsive + UX
[x] 5 tabs - my profile, my orders, my wallet, shopping wishlist, my address
[x] Tabs with icon
[x] Does not refresh the page when change tabs
[x] Customise the scrolling bar

Featured finished in the first sprint.


Included Resources Plugin: separate mergeMeta and mergeResources attributes?

Right now, the Included Resources Plugin uses the same mergeMeta and mergeResources attributes for included resources as it does for the primary resources. Should this be separated out into mergeIncludedMeta and mergeIncludedResources?

Cross-linking #319 here. Here's the thing: once we have that action type, you won't need the Included Resources plugin any longer. So I'm going to close this out, and I'll make sure this gets figured out when that new action type is introduced.


ARTEMIS-1089 Improving flow control on replication

I've a similar issue to solve ARTEMIS-1098 but I'm trying to understand where is the best point where put the (connection) flow control management.
For my use case it could be:

"hidden" in the ChannelImpl::send for not batched writes (this will impact the streaming of large message AFAIK but maybe others use cases)
implement a new method ChannelImpl::sendControlled (or similar) that will perform flow controlled sends and will be called (right now) only by ActiveMQSessionContext::sendLargeMessageChunk to reduce the impact on other use cases

I'm not seeing (right now) other ways to do it, but I want to be consistent to what you've done here: do you have any suggestions?


Add missing () in the files reported in issue #2389 (manim/manim/mobject/types/vectorized_mobject.py and opengl_vectorized_mobject.py)

Overview: What does this pull request change?

Add missing parentheses in the files vectorized_mobject.py and opengl_vectorized_mobject.py

Motivation and Explanation: Why and how do your changes improve the library?

Just a small enhancement

Links to added or changed documentation pages

Any changed documentation pages
Further Information and Comments

Any additional details

Reviewer Checklist

[ ] The PR title is descriptive enough for the changelog, and the PR is labeled correctly
[ ] If applicable: newly added non-private functions and classes have a docstring including a short summary and a PARAMETERS section
[ ] If applicable: newly added functions and classes are tested

Why it failed? Apparently the test was exited because of a time out

I think the build failure was random. However, I'm not sure whether the two rotations are really needed in these two examples--what do you think about removing them?

@behackl sure, I will remove it them.

@Mergifyio squash

Oops, not what I meant to do...

@Mergifyio merge


*: fix all lint issues

This PR fixes all the lint issues reported by golangci-lint that have creeped into the codebase over time as well as ignoring lint issues that would take too long to fix.
My idea is to make passing golangci-lint a required step before merging, otherwise there doesn't seem to be much use in having a linter.

Oh wow. Yes we should totally make it a required step.
Do you want to do it in this PR or follow up?

I don't think I have the necessary permissions to do this (it can be found under the repo's settings tab->code and automation)

I don't think I have the necessary permissions to do this (it can be found under the repo's settings tab->code and automation)

Added the lint and build steps to be required.

Thanks!


Fix flaky tests

[ ] sdk/tests/wallet/claim_outputs.rs often fails

Went through a few runs and also saw
claim_2_native_tokens_no_outputs_in_claim_account
test_get_utxo_changes_by_id
mint_and_burn_native_tokens
mint_and_burn_nft_with_alias
send_nft


[INTERNAL] package.json: Move postversion git push to prepublishOnly

See https://github.com/SAP/ui5-cli/pull/321

coverage: 95.171%. remained the same
when pulling 6359a95659a37a7a7bd8063955d83d2dc636e0ec on fix-v2-npm-hook
into 04cc4adfab21da9b02d0c5b3bf83228c391feacb on v2.


PW-7988: Upgrade to Checkout v70

Summary

This change adds support for Checkout v70. It also includes data type changes and new names for some endpoints.

Lots of renames for payment methods. any way we can keep those te same to reduce breakage?

Sure, we can rename models or endpoints on a spec level, just file a separate ticket with the suggestions.

Eventually I would like to change them I think. it's this specific Lib that has different names from all the other ones :(

Eventually I would like to change them I think. it's this specific Lib that has different names from all the other ones :(

All the names came from the spec now. Other libraries will have the same name once they are implement/generate services from specs.


WIP: IHC texture analysis modules

Codecov Report

Merging #185 (a1663df) into master (1ddf5c9) will increase coverage by 0.48%.
The diff coverage is 95.08%.

@@            Coverage Diff             @@
##           master     #185      +/-   ##
==========================================
+ Coverage   51.58%   52.06%   +0.48%
==========================================
  Files          58       59       +1
  Lines        5424     5485      +61
==========================================
+ Hits         2798     2856      +58
- Misses       2626     2629       +3

Impacted Files
Coverage Δ

data_processing/pathology/common/build_bitmask.py
95.08% <95.08%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1ddf5c9...a1663df. Read the comment docs.


Basic tests for location selection ranking on new test domain

Adds tests for location ranking using the new test domain. Tests that the methods used to rank outcomes always choose the two best sites in the test domain (5 and 6) and never choose the two worst sites (9 and 10). Uses randomised combinations of weightings for 1-6 criteria, including heat stress, wave stress, in coming and out going connectivity, depth and available space for coral. The zoning and priority location criteria will be tested in a different set of tests to be added in a future PR.
The test domain has been altered slightly, as sites 9 and 10 needed some alterations to always be the worst sites for these criteria.
Another test set added tests that sites 5 and 6 are always selected and 9 and 10 never selected for each of the MCDA methods used for site selection.
Closes #642

Double check the formatting for this PR please


Deploy to AWS

Location:

delete docker file

Details:

deploy to AWS Elastic Beanstalk - http://cityspire-a.eba-tgambvt2.us-east-1.elasticbeanstalk.com/
uploaded csv to AWS RDS Postgres

Committed Features:
Application is now deployed to AWS Elastic Beanstalk
Have separate DB from the previous one.

 DS will deploy endpoints on AWS ElasticBeanstalk

 DS will upload data to AWS RDS


User control does not work as expected

Unsure of why this is, motors either do not move at all or they are moving in the wrong direction. Debugging this will take a bit, however, user control is vital to having non-human control in the future.

User control works as expected, it needs further tweaking, but it is functional


Adding sort icons (#3029)

Hoist P/R Checklist
Pull request authors: Review and check off the below. Items that do not apply can also be
checked off to indicate they have been considered. If unclear if a step is relevant, please leave
unchecked and note in comments.

[x] Caught up with develop branch as of last change.
[x] Added CHANGELOG entry, or determined not required.
[x] Reviewed for breaking changes, added breaking-change label + CHANGELOG if so.
[x] Updated doc comments / prop-types, or determined not required.
[x] Reviewed and tested on Mobile, or determined not required.
[x] Created Toolbox branch / PR, or determined not required.

If your change is still a WIP, please use the "Create draft pull request" option in the split
button below to indicate it is not ready yet for a final review.

Pull request reviewers: when merging this P/R, please consider using a squash commit to
collapse multiple intermediate commits into a single commit representing the overall feature
change. This helps keep the commit log clean and easy to scan across releases. PRs containing a
single commit should be rebased when possible.

Closes #3029

Closing PR without merge since the motivation ( need a sort icon in a client app) has been removed.  We can reopen this when the need arises again.


enable requests fanout to k8s replicas in nlp server

by calling k8s api listEndpointsForAllNamespaces to get the ip ports and fanout admin/learn http requests to all replicas using http-proxy.
fixes #417

Pull Request Test Coverage Report for Build 1827

12 of 50 (24.0%)  changed or added relevant lines in 5 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage decreased (-0.2%) to 66.617%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

nlp/admin.js
2
3
66.67%

nlp/learn.js
3
4
75.0%

nlp/main.js
2
3
66.67%

nlp/proxy.js
4
39
10.26%

Totals

Change from base Build 1825:
-0.2%

Covered Lines:
6855

Relevant Lines:
9674

💛  - Coveralls

This is generally ok, but I have two comments:

we should fanout out all requests in the /admin/reload hierarchy, both /admin/reload/:model_tag/:locale and /admin/reload/exact/:locale

Can you elaborate a bit here? IIUC, the current behavior of admin.js will only match /admin hierarchy, which will only fanout  /reload/@:model_tag/:locale and /reload/exact/@:model_tag/:locale requests. Is this different from what you expected?
Also, do you intend to change the fanout matching for /reload/exact? Instead of /reload/exact/@:model_tag/:locale, you want to match /admin/reload/exact/:locale,  without the @:mode_tag ?

this approach does not work for /learn, because /learn also writes the new sentence in the database, and that should happen on only one replica

I think /learn should just issue a /reload/exact request to the other replicas after writing the new sentence to the database. We can pass the ID of the just added sentence in the request, so we can do a partial reload instead of a full reload.

I wasn't aware of this requirement from the issue. This will need some additional work.

This is generally ok, but I have two comments:

we should fanout out all requests in the /admin/reload hierarchy, both /admin/reload/:model_tag/:locale and /admin/reload/exact/:locale

Can you elaborate a bit here? IIUC, the current behavior of admin.js will only match /admin hierarchy, which will only fanout /admin/reload/@:model_tag/:locale and /admin/reload/exact/@:model_tag/:locale requests. Is this different from what you expected?
Also, do you intend to change the fanout matching for /admin/reload/exact? Instead of /admin/reload/exact/@:model_tag/:locale, you want to match /admin/reload/exact/:locale, without the @:mode_tag ?

Sorry, I misread the patch. This part is fine. And yeah I want to change the API but no need to do it now.

Got it.  I've added partial reload to replicas after /learn succeeds. PTAL.


Generate JSON types for entql

Hey @ivanvanderbyl and thanks for your contribution.
Do we really need to generate a new predicate-type for JSON fields? can't we use the []byte predicates instead?

@a8m good question — I suppose that would work. I was more concerned with fixing the code gen for entql in places I already have JSON types. But the underlying predicates aren't important to me.

@a8m would it make sense to implement only Eq and Neq predicates for JSON?

Just hit this same issue. The exact predicates that are available don't matter too much for me as long as the codegen produces buildable code. :)

The exact predicates that are available don't matter too much for me as long as the codegen produces buildable code. :)

@ivanvanderbyl, do you want to try adding the JSON predicates using entql.BytesP?

I'll give that a try later today

How's this look @a8m ?

Hey @ivanvanderbyl, CI is failing. Please run go generate ./entc/gen/... and then go generate ./... from the root directory.

I created this PR for merging this - https://github.com/facebook/ent/pull/1112

I created this PR for merging this - https://github.com/facebook/ent/pull/1112

Merged #1112 - Thanks a lot @ivanvanderbyl

Merged #1112 - Thanks a lot @ivanvanderbyl


Continual update stops when doing another play command

I'm animating a bouncing ball and I'm using the continual update function to accomplish this. While this continual update is running, I'd like to display some text on the screen. However, while a play command is running, the ball freezes for a moment. When the play command is over, the ball jumps to where it is supposed to be and continues moving.
I'd like to know if there is a way to keep the continual update working while running another animation.

Can you paste the problem Scene, or a minified version of it?

bouncing_ball.pdf
Included a pdf of my code. The problem arises when fading in and transforming text1 and text2. The ball temporarily stops moving.

Apologies for the delay. The problem here is that you're hacking the internals of the Scene class by overriding continual_update() rather than letting it handle the continual animation for you. The relevant codepath is here:

continual_update() is called on every frame of the animation
continual_update() calls update() on each Mobject and ContinualAnimation which has been added to the Scene
update() does some bookkeeping and then calls update_mobject() on itself

This means you can continually update ball by creating a ContinualAnimation, passing ball to it, and overriding its update_mobject() method to update the ball every frame. That will look something like this:
from big_ol_pile_of_manim_imports import *

class Ball(Circle):
    CONFIG = {
        "radius": 0.4,
        "fill_color": BLUE,
        "fill_opacity": 1,
        "color": BLUE
    }

    def __init__(self, ** kwargs):
        Circle.__init__(self, ** kwargs)
        self.velocity = np.array((2, 0, 0))

    def get_top(self):
        return self.get_center()[1] + self.radius

    def get_bottom(self):
        return self.get_center()[1] - self.radius

    def get_right_edge(self):
        return self.get_center()[0] + self.radius

    def get_left_edge(self):
        return self.get_center()[0] - self.radius

class Box(Rectangle):
    CONFIG = {
        "height": 6,
        "width": FRAME_WIDTH - 2,
        "color": GREEN_C
    }

    def __init__(self, ** kwargs):
        Rectangle.__init__(self, ** kwargs)  # Edges
        self.top = 0.5 * self.height
        self.bottom = -0.5 * self.height
        self.right_edge = 0.5 * self.width
        self.left_edge = -0.5 * self.width

class ContinualBallUpdate(ContinualAnimation):
    def __init__(self, ball, box):
        self.ball = ball
        self.box = box
        ContinualAnimation.__init__(self, ball)

    def update_mobject(self, dt):
        self.ball.acceleration = np.array((0, -5, 0))
        self.ball.velocity = self.ball.velocity + self.ball.acceleration * dt
        self.ball.shift(self.ball.velocity * dt)  # Bounce off ground and roof
        if self.ball.get_bottom() <= self.box.bottom or \
                self.ball.get_top() >= self.box.top:
            self.ball.velocity[1] = -self.ball.velocity[1]

        # Bounce off walls
        if self.ball.get_left_edge() <= self.box.left_edge or \
                self.ball.get_right_edge() >= self.box.right_edge:
            self.ball.velocity[0] = -self.ball.velocity[0]

class Bouncing_Ball(Scene):
    def construct(self):

        self.box = Box()

        ball = Ball()

        self.play(FadeIn(self.box))
        self.play(FadeIn(ball))
        self.ball = ball

        self.add(ContinualBallUpdate(ball, self.box))
        text1 = TextMobject("This is a bouncing ball")
        text2 = TextMobject("Enjoy watching!")
        self.wait(1)
        self.play(FadeIn(text1))

        self.wait(2)
        self.play(Transform(text1, text2))

        self.wait(10)

And render to this.

The continualAnimation class no longer exists


64 bit compatibility

Hi,
wanted to ask not sure if this is the right place to do so but i'd like to know how is the compatibility with 64 bit for this ... will it be broken or will it be updated as soon as the patch hits?

Hi, full compatibility expected. Fixes will be added If necessary.


What is the best practice with rnn-screens to handle Authentication States?

Hi, hope it's ok that I post here and thank you for taking the time to read this. Love what you've done here, but I can't figure out what would be the best way to handle the change in Auth States.. e.g
isLoading -> Show Splash Screen
isAuthenticated -> Show Main Screen Stack
!isAuthenticated -> Show Log In Screen Stack

I'd normally handle this in App.tsx with RNN, e.g
useEffect(()=>{
  authService.onAuthChange(()=>{
    ...
    isAuthenticated = true;  // Updates based on auth service
  })
}, [isAuthenticated])
...
<Stack.Navigator>
{isAuthenticated ?
      <Stack.Screen name="SignIn" component={SignInScreen} />
    ) : (
      <Stack.Screen name="Home" component={HomeScreen} />
    )}
</Stack.Navigator>

But it isn't clear to me how to do this with registerRootComponent. I've successfully (hackily) used screens.N.setRoot(AuthStack) and screens.N.setRoot(MainTabsApp) to switch from one to another, but I wanted to know if you have a better way?

Hey @anttyc!
RN and RNN have a bit different way of building navigation, so it might be hard to achieve the exact same way in RN and RNN.
Your "hack" is actually the way to go as it's done in rnn-screens (here).
What I usually do with RNN in this case, I show my main app (let's say it's a tab based app) and then on the first screen in useEffect, I check if a user is not authed then I do something like nav.show('Auth') so the modal is being shown.
The other way would be to start the app with a blank screen (let's say, AuthStateScreen) where you check on the auth state in useEffect and depending on it, you do screens.N.setRoot(Auth) or screens.N.setRoot(MainApp).
Let me know how it goes!

Awesome! Your second suggestion is how I ended up doing it, just wanted to make sure I wasn't missing anything. Let me try your first suggestion as that seems more elegant.
Thanks so much @kanzitelli  for the quick and detailed reply.

hey @Yasir5247! thanks for the idea! I am going to merge rnn-screens to rn-navio, so Navio will become a universal (with the same API for rnn and react-navigation) navigation library. And I will take your thoughts into the consideration.

hi @kanzitelli, thank you.
btw were you able to solve https://github.com/kanzitelli/expo-starter/issues/27 in rn-navio?

@Yasir5247 it's impossible to achieve exactly the same effect with react-navigation as we could do with React Native Navigation. The reason is that react-navigation doesn't use native tab bar controller under the hood. That's why the only way to do that with react-navigation (and Navio) is to push another stack over the tabs. But as you already faced the problems with back button (only on iOS tho), it's not the best solution. Idk, I would recommend maybe showing your product screen as a modal? I think it's better UX + easier to implement with Navio :)


[api-docs] Made the ApplicationCommandInteractionDataResolved more understandable

A new commit was made into the api-docs repo. This issue was created automatically. Need to review if we made any change to the library for this commit.
https://github.com/discord/discord-api-docs/commit/9be481a9bfcf2184dfd0cf159ec1f2023fbcc91e

ncn


Streamline Domino Server Setup

We reviewed this project yesterday, and there were some manual steps that we want to improve:

Fix java version in Setup_SDKMAN.sh - currently the filter fails and we install the latest Java version instead
update /etc/hosts with entry for "demo" for Domino server.  This is required to access the server from a Java application
automate creating names.nsf (CreateNamesDatabase.nsf)
Cross-certify the provided safe ID
Start the Domino server

@dpastov, I did a test with DominoVagrant/demo, but it failed because I didn't have the Genesis JAR:
domino-vm: Running: script: Copy Genesis-0.6.14.jar to /local/dominodata/JavaAddin/Genesis
domino-vm: cp: cannot stat ‘/home/vagrant/dist/Genesis-0.6.14.jar’: No such file or directory
domino-vm: chown: cannot access ‘/local/dominodata/JavaAddin/Genesis/Genesis-0.6.14.jar’: No such file or directory

Where can I get this for now?  If it is a public project, we could download it from a release.

I fixed the Java logic in SDKMAN_Setup.sh.  Currently it is using the "zulu" (Azul) JDKs.
I also added a line to update /etc/hosts
@JustinProminic, @dpastov, I made some other "minor" updates to the Vagrantfile as I was going through a test.  We can revert these if they cause problems for other users.

Updated the installer to Domino 12.0.1 (was 12.0)
Updated downloads.prominic.net links to use ND12 instead of ND9.  The wget commands don't have the real password, though, so these URLs still won't work
Updated NOTES_ID to SAFE_NOTES_ID and changed the default path to be more reasonable:  SAFE_NOTES_ID = "./dist-id-files/safe.ids".  Added some comments for how to create this ID.  I also added logic so that this safe ID is optional.  The ID is not signed yet

I have updates ready for the CrossCertifyNotesID class.  I'll test this after lunch and commit them if they are working.  This code has examples to read credentials form setup.json.  I'm planning to make some updates to the project structure to make it easier to work with the code in Moonshine.

I added CrossCertifyNotesID.java.  This is updated to read setup.json to get the credentials for the generated server.  The current syntax is:
# starting server - not required
# names.nsf already existed for me - running CreateNamesDatabase.jar did not make a difference for me
cd /local/notesjava
java -jar /vagrant/build/libs/CrossCertifyNotesID.jar user.id

Unfortunately, this is still prompting me for the password.  I think I am probably making a silly mistake when creating the session, but I haven't figured it out yet.  I'll revisit this later today if I have time, but I need to work on other tasks for a while.
I also added a .javaproj and build.gradle so that this project can open in Moonshine.  You may also need to setup src/main/java.  I'm thinking about moving dist-src instead, but for now you can just create a symlink:
mkdir -p src/main
cd src/main
ln -s ../../dist-src java

I added code to build.gradle to build a jar for each main class in dist-src/net/prominic/domino/vagrant.  The JARs can be generated with gradle clean jarIndividual, or individually with jar<ClasName> (i.e. gradle jarCheckNotesUser).

On further investigation, I see the password prompt is triggering on the reg.crossCertify line.  If I add a getDatabase line, I see that it doesn't trigger a password check (but it does in CheckDatabase.jar.  I'm out of time for today, so I'll revisit it on Monday (unless you want to take a look, @dpastov ).

I see that the recertify method reports:

This method prompts for the ID password.

I suspect the same thing is happening for crossCertify.
I confirmed that we can work around the password prompt with the yes command.  If we want this solution, we would need to parse the password from setup.json - we have used a command line JSON library in another project:
yes "`-command-to-get-password`" | java -jar /vagrant/build/libs/CrossCertifyNotesID.jar user.id

@dpastov, I did a test with DominoVagrant/demo, but it failed because I didn't have the Genesis JAR:
domino-vm: Running: script: Copy Genesis-0.6.14.jar to /local/dominodata/JavaAddin/Genesis
domino-vm: cp: cannot stat ‘/home/vagrant/dist/Genesis-0.6.14.jar’: No such file or directory
domino-vm: chown: cannot access ‘/local/dominodata/JavaAddin/Genesis/Genesis-0.6.14.jar’: No such file or directory

Where can I get this for now? If it is a public project, we could download it from a release.

That is fixed (I commited/pushed) file to repo.

Great, this works for me now, and I can access the server from my Notes client without any more steps on the Vagrant side.   @dpastov, does this work in your test?  I'll ask @JesseProminic to test this as well (I'll send an email with more information).
I updated README.md to reflect my changes.  We should probably improve the instructions further depending on the target audience, but I think this is good enough for now.
Some optional remaining tasks:

Automatically stop the Domino server on Vagrant shutdown.  Right now the VM will use an emergency poweroff with vagrant halt.  I didn't see a way to trigger a shutdown command in Vagrant.   I did work on an input file for Domino server commands, but this broke input for the screen console, so I disabled that code for now
Run the cross-certify step every time.   Since I had to add a 60 second sleep for the server to stop, I set this code to run only on the initial creation.  If this is a problem we can make this logic more clever
Cross-certify multiple IDs?

Other remaining tasks for Moonshine integration (will be done in separate issues):

Add REST interface (#1)
Add scripts for other actions, like uploading a database or application.


Add link to pending submission for sqlint SublimeLinter plugin

Hey Steve, I've added a link to the issue I've opened for submitting the sqlint SublimeLinter plugin.

Sorry, I missed this earlier because the notifications come into my personal mail, and I added the link directly myself at some point in the afternoon.


[docs] additional details about defaultValues

As per additional comments on https://github.com/react-hook-form/react-hook-form/pull/2461

Thanks @gregfenton 👍


Allow editing until confirmation

Summary
Allow suppliers to edit some company details (vat number, registration
number, registration name) until they specifically confirm they are all
correct. In the theoretically impossible situation where a supplier has
confirmed their details but one/more of these pieces of information are
missing, they will still be able to provide it as a one-off.
Related PRs

https://github.com/alphagov/digitalmarketplace-api/pull/762

Example: Company details not confirmed

Example: Company details confirmed

Ticket
https://trello.com/c/NaNjMOHc/61-confirm-supplier-details-2-frontend-logic-changes

I've noticed that suppliers can't edit their DUNS number. Is this because we collect it during supplier creation?

Yep, duns number is basically our PK for suppliers (I think...)  so they can't change it after signing up.

@Wynndow That's correct re: DUNS number. It is the way CCS identifies the suppliers I think


http-client-java, default flavor=azure, if package is typespec-java

link https://github.com/microsoft/typespec/issues/5380

No changes needing a change description found.

You can try these changes here

🛝 Playground
🌐 Website
📚 Next docs


Change the interface for setting application settings

The interface app.set(<name with space>, <value>) feels a odd for setting values in a JavaScript framework. Also, its counterpart app.get(<name>) is a confusing twin of app.get(path, callback [, callback ...]), which is a router method.
I am proposing to implement application settings using getter-setter interfaces.
app.settings.trustProxy = true;

And get rid of app.get(<name>).
Super major change, I know, but the next major version is a good time to make these interface improvements.
Related issues

https://github.com/expressjs/express/issues/2216
https://github.com/expressjs/express/issues/3997

I believe there is already a PR solving this issue that is scheduled to land on 5, using a new settings module, right @wesleytodd ?

I see. That PR is https://github.com/expressjs/express/pull/3714. It still maintains the .set(<name with space>, <value>) syntax.
I am wondering if there are any advantages of providing functions to set and get values over using getter-setter's.
app.settings.set('trust proxy', true) vs app.settings.trustProxy = true
app.settings.get('trust proxy') vs app.settings.trustProxy
Or is it just an artefact from the "pre-Object.defineProperty" era?

Yeah I have this PR: #3714
As for getters/setters vs functions, I don't have a strong objection to supporting both, it would be pretty simple using a Proxy.  But, that would only land in 5 which drops support for versions w/o Proxy then we should be fine.  The version targeted for 4.x cannot really support that.
When I get some time I really want to move that package over to `pillarjs.  I just need @dougwilson to give me the proper privileges on that org.  Once that is there we can work on cleaning up the PR and making sure that docs are updated and such.

The version targeted for 4.x cannot really support that.

Not looking for 4.x at all. 5 is what I have on mind.

Cool, well I am happy to move that repo over so we can get the new interface added.  Just need that permission on pillar 👍


Attribute Error while trying to delete a row using Python.

Bug Report
When I tried to Delete a row from a table using Python it returned a Error.
A clear and concise description of what the bug is.
To Reproduce:
import os
from supabase_py import create_client, Client

url: str = os.environ.get("SUPABASE_URL")
key: str = os.environ.get("SUPABASE_KEY")
supabase: Client = create_client(url, key)
data = supabase.from_("repl").eq("name", "Africa").delete().execute()

Expected behavior
You should get this Error.
Traceback (most recent call last):
  File "main.py", line 9, in <module>
    r = supabase.table("repl").eq("id", "name").delete().execute()
AttributeError: 'RequestBuilder' object has no attribute 'eq'

I've tried to reproduce the bug with a fresh new table and it results in the same error, nothing happened in the table. However, I was able to delete rows matching a filter with this code:
supabase.from_("events").delete().eq("id", "2").execute()

Although it did delete the rows, the command ended in a fatal error when trying to parse the JSON of the response. Here's the full traceback:
Traceback (most recent call last):
  File "test.py", line 7, in <module>
    supabase.from_("events").delete().eq("id", "2").execute()
  File "C:\Python38\lib\site-packages\supabase_py\lib\query_builder.py", line 33, in _execute_monkey_patch
    "data": response.json(),
  File "C:\Python38\lib\site-packages\requests\models.py", line 900, in json
    return complexjson.loads(self.text, **kwargs)
  File "C:\Python38\lib\json\__init__.py", line 357, in loads
    return _default_decoder.decode(s)
  File "C:\Python38\lib\json\decoder.py", line 337, in decode
    obj, end = self.raw_decode(s, idx=_w(s, 0).end())
  File "C:\Python38\lib\json\decoder.py", line 355, in raw_decode
    raise JSONDecodeError("Expecting value", s, err.value) from None
json.decoder.JSONDecodeError: Expecting value: line 1 column 1 (char 0)

When you make a DELETE request, the response is None if successful and it's can't be serialized because you can't convert a None type to JSON. We'd need data to be None if request method is DELETE

Hi! Closing this issue since it has already been solved in the current version or before. Thanks for reporting :slightly_smiling_face:!


Re-implement mailbox

Use string as the mailbox id
Use one single MailboxService implementation to handle both local and remote mails
Solve the dangling mailbox caused by late mails

If the mailbox is not fully consumed (no successful EOS), keep it within the cache but remove all the data blocks (use it as tombstone)
Do not allow new data blocks to be added when mailbox is cancelled/errored

Solve the problems in #10424

Codecov Report

Merging #10681 (e92787b) into master (96d34fd) will decrease coverage by 2.55%.
The diff coverage is 86.14%.

@@             Coverage Diff              @@
##             master   #10681      +/-   ##
============================================
- Coverage     70.29%   67.75%   -2.55%
+ Complexity     6514     5964     -550
============================================
  Files          2108     1575     -533
  Lines        113904    82683   -31221
  Branches      17192    13041    -4151
============================================
- Hits          80065    56019   -24046
+ Misses        28229    22757    -5472
+ Partials       5610     3907    -1703

Flag
Coverage Δ

integration1
?

integration2
?

unittests1
67.75% <86.14%> (-0.08%)
:arrow_down:

unittests2
?

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files
Coverage Δ

...he/pinot/query/mailbox/channel/ChannelManager.java
100.00% <ø> (ø)

...y/runtime/operator/exchange/BroadcastExchange.java
100.00% <ø> (ø)

.../query/runtime/operator/exchange/HashExchange.java
100.00% <ø> (ø)

...uery/runtime/operator/exchange/RandomExchange.java
100.00% <ø> (ø)

...y/runtime/operator/exchange/SingletonExchange.java
100.00% <ø> (ø)

...ot/query/runtime/plan/OpChainExecutionContext.java
96.15% <ø> (ø)

.../runtime/plan/server/ServerPlanRequestContext.java
100.00% <ø> (ø)

...t/query/runtime/plan/ServerRequestPlanVisitor.java
86.20% <72.72%> (-0.12%)
:arrow_down:

...g/apache/pinot/query/mailbox/ReceivingMailbox.java
73.80% <73.80%> (ø)

...ot/query/runtime/executor/RoundRobinScheduler.java
86.74% <75.00%> (-6.12%)
:arrow_down:

... and 18 more

... and 778 files with indirect coverage changes
:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more


auto mode rules should be except container per tab not per origin

Describe the bug
If one of the rules matched the origin/the main url of the tab so temp container is not applied to it, every other request from that origin should also without temp container.
However, it is not now.
To Reproduce
Steps to reproduce the behavior:

Enable auto mode and add ^https://www.apkmirror.com/.* to rules.
Visit https://www.apkmirror.com/ .
After some redirector, the tab url will be https://challenges.cloudflare.com/.+ with one temp container.

Expected behavior
Just as title.
Desktop (please complete the following information):

Version 1.1.20

Auto Mode is working as designed. The website is triggering a redirect from a un-containered tab and auto-mode is re-opening this tab with a non-whitelisted url into a new temporary container.
I think, you can still do what you want, by just opening a temp container in advance.

on the preference page, change the toolbar action to open a new empty temp container
click the toolbar button, to open a empty new temp container
visit  https://www.apkmirror.com in the temp container

Since tabs, which are already opened in a temp container are ignored by auto-mode handling, you can use this, to open a temp container, that doenst care about further navigation and redirects. Everything will stay in one container.

I am really debatting in my head if auto-mode is such a good idea or even necessary, since firefox already has total cookie protection enabled aka. seperates cookies per site. There is not much of a point of using seperate containers for each url, except if you want to use mutliple logins at the same site or just want to visit a site, without any cookies. I suspect many people are unaware of this ... and might think container provide an addional level of security ... which they dont AFAIK. And this feature only seems to increase this misconception.

In that case i might just remove the feature, since it seems to have a higher potential to cause troubles with other addons then it's worth.

So i am not 100% convinced that it is worth to re-add the url-list.

Hi! I've just found the auto-mode is removed and seen this post.
I'm fan of this feature since I'd like to isolate my Google logins (e.g. gmail) and Google search.
I always search in temporary containers so that Google cannot (maybe) track me easily with logged-in searching page.
Not sure if you have any suggestion on this kind of scenario but auto-mode is convenient instead of manual open. And it does not harm keeping there. ;)

@agitoxin
@ivysrono
This is a common problem for all kinds of software
https://xkcd.com/1172/
The question is how to best resolve this.

Well..IMO, a toggle to enable/disable for personalization is optimal. ;)

Ok, i'll re-add it, BUT i wont support or fix any kind of compatability issues with other container addons.


Upgrade to Kafka 0.8.2

Kafka 0.8.2 should be released soon (a beta release is currently available [1]).
Should consider upgrading the offset monitor once it's released. One benefit is that it uses the latest ZK version [2], which would eliminate some "old client" log warning noise when connecting to a 3.4.x ZK server (noted in https://github.com/quantifind/KafkaOffsetMonitor/issues/21).
[1] http://kafka.apache.org/downloads.html
[2] https://github.com/apache/kafka/blob/0.8.2/build.gradle#L207

If you have the possibility to do this and run some tests, I am up for it, but we are not yet planning to upgrade, so please go ahead and submit a PR.

I have quickly tried to upgrade to 0.8.2, but some of the tooling that the monitor use seem to have moved, which broke some of the classes api. I don't have much time to explore more, but feel free to PR a solution.

@Mortimerp9 Would you like to move completely to 0.8.2 dependencies or keep some backward compatibility?

Hi, i just wanted to let you know, that my team colleague is working on this issue right now. He might have some questions. We also have backwards compatibility in mind, so we are going to test it on both Kafka 0.8.1 and 0.8.2. Please let us know if there are any issues that we should consider.

Hi, I added the support for broker storage via a run argument --brokerStorage. Please review.
https://github.com/quantifind/KafkaOffsetMonitor/pull/61


Customize bibliography

A temporary solution: using show rule to customize bibliography.
typst is able to read yaml using yaml(path)(or other file): https://typst.app/docs/reference/data-loading/yaml/
and we can overwrite the bibliography with other formats like GBT-7714....
But this solution will lose the ability to reorder the references so that it only works well when the bibs are ordered correctly in the ref.yml file. I don't know how this can be improved before typst's support for custom bib


Error handling of handler exceptions

Currently exceptions thrown in handlers cause the application to crash and an empty response to be sent to the client.
Desired behavior is a 500 and a log of the exception being written.
We discovered find-my-way has a synchronous routing method that creates problems in this space, and the library may need to be replaced.

Closing because of the switch to koa-router.


Corpus Data Stats

Is your feature request related to a problem? Please describe.
Chris from OK Maps has requested we provide stats and charts describing the state of the data in the corpus as it will appear to them (primarily from Wikidata but maybe also from CrossRef, etc)
Describe the solution you'd like
A series of queries (SPARQL) that return usable data that can be charted - possibly part of the dataWrangler project.
Describe alternatives you've considered
Taking the data and putting in spreadsheets to chart - but that's not very malleable, customisable or easily updated.
Additional context

Need to come up with a list of useful stats:

[ ] Entries with percentage of authors as string, entry with monolithic name, entry with first name and last name
[ ] Percentage of entries with and without DOIs
[ ] Spread and count of keywords


ci: bump crates using name specified in cargo.toml

There are crates in the Ockam directory that are not named after its directory. This PR gets the package name from Cargo.toml

Merged #2443


The mixin version does not define this.styles

Documentation makes it seem like you should be able to call this.styles() no matter what version you're using, but when you do that with the "inline" version, this.styles is undefined and this.css must be used instead.

Hey @jason-wolfe, sorry for the confusion. I am going to be splitting out the documentation so there is a section for both the mixins implementation and the es5 implementation.
In the meantime, you can check out a working file of it here: https://github.com/casesandberg/reactcss/blob/master/examples/Button.es5.jsx#L49
Notice on like 49, you have to declare a styles function that returns this.css, that's what makes it work.

Added calling the styles function to the mixins example!

Thanks!


Fix ProductCategoriesGrid template Source bug

The source of Categories should point to itself.

@gkLeo Could you please provide some context? What was the issue caused by it?

@adoprog The value of the source is /sitecore/content/PLAY/playwebsite/Data/Product Categories, but the item was deleted in #89 , https://github.com/Sitecore/Sitecore.Demo.XmCloud.PlaySummit/commit/32492064803a32e024b84f5a549983b950f3e1f8#diff-88874fbde78375e472673ba60d0b3c737ca1b27ff18606c03a290b27a052e7c7, this results in the Categories field of /sitecore/content/PLAY/playwebsite/Data/ProductCategoriesGrid/Most Popular Product Categories Grid pointing to entire sitecore tree, which should be avoided. It should point to itself.


Update README.MD

Deep Neural Networks with PyTorch - Stefan Otte lecture from PyData Berlin 2018

Thank you for the contribution!


Return status of Task not equal to 0 can also indicate a successful result.

Hi,
We use parallel-ssh in our company to check several Linux machines for updates in parallel.
It's a great tool, because we can start i.e. apt-get update or yum check-updates to check for and also
apt-get upgrade to apply updates in parallel. The uptodate status is even faster and available at a central place (i.e. a database) if there are a lot of machines. (We plan to make this project public open sourced available, but at the moment there are a lot of hardcoded ssh- user and machine names in some scripts, that prevents this. Look at the prepared github repo openlsus )
many prefaces here's the issue
As mentioned in the subject, against the regular use of the return status of a command,
Red Hat's "yum check-updates" returns 100 if there are updates available. (also documented in the man page)
We want to get the Status [SUCCESS] even for these unusual return status.
How can we get this (upstreamed) ? Should I create a patch or a pull request? Or can I have this only in a separate fork? - I want want to give the TASK an additional optional param which is the expected return status of the command. Or do you want to implement this by yourself.
Regards Marc

A PR would be fine. If you'd like some workarounds in the meantime, you could either use --script or do something like:
$ pssh -H example.com 'yum check-updates; test $? -eq 100'


[docs] Add keys to Responsive AppBar demo

@mbrookes  Thank you for your change. If anything have to change then let me know. Thank you.


Error 500 in our suggest annotations endpoint

I'm getting the following error when trying the suggest annotation endpoint on the 1.8mb WGI_Data.csv
errorCode: 500
errorDescription: "cannot unpack non-iterable NoneType object"
errorTitle: "TypeError"

Here is the file in question:
Uploading WGI_Data.csv…

related to #626

can this issue be closed now?


fix type coercion for subquery

Proposed changes
Problem summary
Complete the type coercion of the subquery in the function Binder process.
Checklist(Required)

[ ] Does it affect the original behavior
[x] Has unit tests been added
[ ] Has document been added or modified
[ ] Does it need to update dependencies
[ ] Is this PR support rollback (If NO, please explain WHY)

Further comments
If this is a relatively large or complex change, kick off the discussion at<EMAIL_ADDRESS>by explaining why you chose the solution you did and what alternatives you considered, etc...