proposal: cmd/vet: warn on defer as the last statement before return if the arguments exists prior to the penultimate statement to the return

Proposal Details
I see regularly new comers using defer incorrectly.
Some write things like this:
func doSomething() {
 resource := Grab()
 err := use(resource)
 if err != nil {
  return
 }
 defer resource.Close()
}

This code is tricky because it works, or at least looks to do so if you don't have a test for the failure case which also checks that resource is cleaned up properly.
So I propose that defers should be a go vet error if they are the last statement before a return as
defer thing()
return

is identical to
thing()
return

Unless one or more of their arguments (this include receivers, function arguments and variables captured by closures) are coming from the penultimate statement, this is so code like this remains ok:
thing := Grab()
defer thing.Close()

return

Ideally this would be counted as per SSA rules so:

thing, err := Grab()
if err != nil {
 return err
}
defer thing.Close()

return nil

would remain ok, we could also replace this with more edge cases.
I see the acquire (+ if err != nil check) + defer close as it's own logical unit, and sometime you open a connection or file just to check that it is reachable or you have correct permissions, but then don't use it (yet).
However it tries to exclude acquire + use + defer close pattern which is a bug.

Falling through control flow should also be counted.
In other words I think this should also be warned on:
if x {
 r := Grab()
 use(r)
 defer r.Close()
}
return

I'm afraid that this at the same time causes friction especially when writing tests and the tests get fleshed out step by step. In those cases govet will block running the test, even if it is fully correct.
rsc, err := openrsc()
if err ...
defer rsc.Close()
// test test so far, more to come later

@thediveo I tried covering this with:

Ideally this would be counted as per SSA rules so

It's very unclear (and incorrect).
I guess a more correct analysis could be to do this analysis on the CFG while ignoring control flow.
So if err != nil and it's content would be ignored because your error checking block would finish with a panic, return or other terminating block.
defer rsc.Close() would be the final statement, if would be skipped, rsc, err := openrsc() would be the penultimate statement and this wouldn't match since one of the return values from the penultimate value is an argument to the defer.

how frequent is this that it needs to be a vet check?

How does this satisfy vet's 'Correctness' criteria? cmd/vet/README:

Correctness:
Vet's checks are about correctness, not style. A vet check must identify real or
potential bugs that could cause incorrect compilation or execution. A check that
only identifies stylistic points or alternative correct approaches to a situation
is not acceptable.

Unless one or more of their arguments (this include receivers, function arguments and variables captured by closures) are coming from the penultimate statement, this is so code like this remains ok:

I don't understand this line. Do you mean whether or not arguments exist will affect the logic? (It is certainly not).

I searched for matches in opensource code and there were a couple too much false positive, I thought it would be pretty rare, but yes this probably falls under styling.


Add H2 database for tests

Description
Add H2 database for tests.
https://www.baeldung.com/spring-testing-separate-data-source
Related to
#10
https://www.baeldung.com/spring-boot-testcontainers-integration-test
https://docs.spring.io/spring-boot/docs/current/reference/htmlsingle/#features.testing.testcontainers
AC

The H2 database works with tests.

@AndriiChipets-Java Hello! What is the status here? Do you need any hint/help to accomplish this task?

@AndriiChipets-Java Good to know!
Take your time. In the case you need more time, we can easily transfer this task to the next sprint.

@oleksandr-jr Glad to hear that.
Thank you for the information and support)

@oleksandr-jr Hello!
I would like to move this task to the next sprint.
I hope this won't influence too much on the total project flow.
Thank you.

Added two tests for UserRepository class.

Also added schema.sql file with all db tables and dataUser.sql file with data to test UserRepository class.
to test other classes programmer have to create data* file with test data for their tested class, e.g. dataPost.sql for class PostRepository and specify this sql file in Test class, e.g.
@Sql(
scripts = {
"/sql/schema.sql",
"/sql/dataPost.sql"},
executionPhase = Sql.ExecutionPhase.BEFORE_TEST_METHOD
)

To create test class to use testcontainer you can copy and modify UserRepositoryTest class


Fix transactions

Since all the dex contract calls contain user address, txs/backward will return them and will have more information than aex9/transfers/to/. I propose to exclude them from the list which getTokenHistory is returning.

Tested, in general LGTM.


[NSE-183] Add Date/Timestamp type support

Requires arrow patch oap-project/arrow#22

@github-actions ram-usage-test


Dev: update deprecated license header check action

https://github.com/kt3k/license_checker_github_action seems to be deprecated.

I'll implement a simple script to replace this action.


Add rpm_ostree_task package

Add a new policy package, rpm_ostree_task under the release namespace. It is used to verify the rpm-ostree Tekton Task is executed with the expected parameters. All rules are added to the 'redhat' collection.

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (dd1d73a) 100.00% compared to head (ecc32dd) 100.00%.
Report is 6 commits behind head on main.

Additional details and impacted files

@@            Coverage Diff            @@
##              main      #908   +/-   ##
=========================================
  Coverage   100.00%   100.00%
=========================================
  Files           93        95    +2
  Lines         4636      4606   -30
=========================================
- Hits          4636      4606   -30

Files
Coverage Δ

policy/lib/assertions.rego
100.00% <100.00%> (ø)

policy/lib/assertions_test.rego
100.00% <100.00%> (ø)

policy/release/rpm_ostree_task.rego
100.00% <100.00%> (ø)

policy/release/rpm_ostree_task_test.rego
100.00% <100.00%> (ø)

... and 11 files with indirect coverage changes

Looks good to me, but check Zoran's suggestions.


How to get started

I can see that the installation procedure has been mentioned a dozen of times, in different sources. I installed it to Ubuntu.
But, I am left in total darkness on how to run the the program.
Tried:
- ocreval - h
- libutf8proc-dev  -h
- accuracy -h

None of these are recognized as proper commands.

I see, I missed that last step:
make exports >> ~/.bashrc


Configuring sink using JSON

Hi!
There is a proposal over at Serilog.Settings.Configuration where sink developers would be able to specify an extension point specially designed to support JSON configuration. If this is something you would find beneficial for your sink, please give a thumbs up or something. If not, have a nice day and continue being awesome!

Closing it due to lack of interest.


Adding multiple materials to the gltf export for interactive plots

Hi @BradyAJohnston ,
static rendering already works very well, so I thought that the next step can be interactive rendering:
Exporting gltf data from blender and then importing that data to three.js in a notebook works out of the box!
https://github.com/kolibril13/ipyMolecularNodes/assets/44469195/03b9750f-f228-4285-9181-f950ed103e07
Currently, everything is only one color, though.
Seems like the function bpy.ops.export_scene.gltf is currently only exporting one material.
If you have some bandwidth do you  want to take a look at how multiple materials can be exported?
If yes, then you can use this notebook as an exploration start:
https://github.com/kolibril13/ipyMolecularNodes/blob/main/example_interactive.ipynb
and installation can be done by cloning this repo and then:
python3.10 -m venv .venv && source .venv/bin/activate
pip install -e .

The lack of coloring will be a problem with the materials themselves. Inside of Blender I use attributes to calculate colors which are then used int he materials. For export, we will need to convert the Color attribute on the mesh to vertex_color. I am not sure what the spec is for gltf, but it should support some kind of vertex colors. If it does, we can assign that and it should work well.

For export, we will need to convert the Color attribute on the mesh to vertex_color.

That's great to hear! I have very little knowledge of the internals of molecularnodes, but you are very welcome to give it a shot if you have the bandwidth :)
I remember that @hybridherbst also recently made a tweet about going from Blender to threejs with colors, so there's definitely a bridge!

Okay, adding this line after applying the modifiers does exactly what we are after :)
bpy.ops.geometry.color_attribute_render_set(name="Color")

absolutely amazing! :)
https://github.com/kolibril13/ipyMolecularNodes/assets/44469195/9037624c-546e-4da8-927e-f019958a2875
Next idea: Is there a way to customize the colors?

There are a couple of ways, but neither are particularly well suited for the task yet.
After we have applied the modifiers, we have just regular 3D meshes. You can change the colours by interfacing with Blender's unlerying mesh API, I don't have experience with this.
The colours that were are currently getting, are being generated via Geometry Nodes, before we apply the modifiers.
Before we apply the modifiers, this is what the node tree looks like:

Colors are being set for each of the common elements, with the colors for carbon being randomly generated based on an underlying attribute (by default, chain_id). If we want to change the colors, we could also change the underlying node tree before we apply it. The API for interfacing with the node trees is very verbose currently, and will be changing in Blender 4.0 as well. We can do it though, changing the colors to be generated based on res_name, or it could be res_id or sec_struct, any of the available attributes.
obj.modifiers['MolecularNodes'].node_group.nodes['MN_color_attribute_random'].inputs['Attribute'].default_value = 'res_name'

bpy.context.view_layer.objects.active = obj
obj.modifiers['MolecularNodes'].node_group.nodes['MN_color_attribute_random'].inputs['Attribute'].default_value = 'res_name'
for modifier in obj.modifiers:
    bpy.ops.object.modifier_apply(modifier=modifier.name)
bpy.ops.geometry.color_attribute_render_set(name="Color")

Neither are ideal, and I don't entirely know the best way to go about it.

thanks for this screenshot and the code example!
with .node_group.nodes['MN_color_attribute_random'].inputs['Attribute'].default_value = 'res_name' colors  changed to

I've also played with other parameters:

import bpy
from pathlib import Path
import molecularnodes as mn
from ipymolecularnodes import BlenderInteractiveWidget

# Ensure the glTF exporter is activated
bpy.ops.preferences.addon_enable(module="io_scene_gltf2")

# Delete all mesh objects from the scene
bpy.ops.object.select_all(action="DESELECT")
bpy.ops.object.select_by_type(type="MESH")
bpy.ops.object.delete()

obj = mn.load.molecule_rcsb("7TYG", starting_style="cartoon", center_molecule=True)
obj.scale = [10, 10, 10]

bpy.context.view_layer.objects.active = obj
obj.modifiers['MolecularNodes'].node_group.nodes['MN_color_attribute_random'].inputs['Lightness'].default_value = 0.3
obj.modifiers['MolecularNodes'].node_group.nodes['MN_color_attribute_random'].inputs['Saturation'].default_value = 1
obj.modifiers['MolecularNodes'].node_group.nodes['MN_color_attribute_random'].inputs['Seed'].default_value = 2

for modifier in obj.modifiers:
    bpy.ops.object.modifier_apply(modifier=modifier.name)
bpy.ops.geometry.color_attribute_render_set(name="Color")

# Exporting the model to .glb format for Three.js
# Specify the path where you want to save the exported model
gltf_path = Path() / "_MY_MODEL_DATA.gltf"

bpy.ops.geometry.color_attribute_render_set(name="Color")

# Select only the object
bpy.ops.object.select_all(action="DESELECT")
obj.select_set(True)

# Export the selected obj object to a .glb file
bpy.ops.export_scene.gltf(
    filepath=str(gltf_path), export_format="GLTF_EMBEDDED", use_selection=True
)

data = gltf_path.read_text()

gltf_path.unlink()

b = BlenderInteractiveWidget(gltf_data = data)
b


Songs not loading

for some treason the songs I downloaded from beatsaver.com are not showing up in game, I did extract them, I haven't seen anything about beat saver not being supported. If that is the case could you please tell me where to download new songs.

See the same version. Possibly related to new version v0.11.2?

I cant find anything later than 4.3.2, I found mine on modsaber so IDK where did u find 11.2

I think it was the game updated, but today I try it again and it works perfectly. Just follow install instruction.

I figured it out, for some reasons it was “picking up” my previously downloaded songs, I had to re-download everything inside the game.
Sent from my iPhone

On Sep 5, 2018, at 10:43 AM, Francis Chong<EMAIL_ADDRESS>wrote:
I think it was the game updated, but today I try it again and it works perfectly. Just follow install instruction.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub, or mute the thread.

Version 0.12 has broken this for me. All of my songs are there but it's being ignored.


i18n - unused translation keys

Per https://github.com/freeCodeCamp/freeCodeCamp/pull/40599#issuecomment-752898849, this issue is to track unused keys in the translations.json object.
The following keys appear to be unused:

settings.username.contains invalid characters: Dynamically loaded as settings.username.${error}
settings.username.is too short: Dynamically loaded as settings.username.${error}
settings.username.is a reserved error code: Dynamically loaded as settings.username.${error}
profile.total-points_plural: Plural keys are handled automatically by the Reacti18n package.
profile.points_plural: Plural keys are handled automatically by the Reacti18n package.
donate.additional: This was removed in the latest update to the donate page
flash.msg-9 through flash.msg-45: Handled automatically?

Those settings ones were tricky, and just kept causing problems. I could get a number of the flash messages from the server translated by sending the keys to the client like I had originally tried to do. It's not possible with a number of them at the moment, but I think it would probably work for good amount of them - and probably the more frequently seen ones.

@moT01 @nhcarrigan Is this still an issue?

Probably wouldn't hurt to run the script again and get a new list.

@RandellDawson I re-ran the validator and filtered out the false positives from the intro object (because some titles use dynamically generated keys).
Most of the flash messages I think are also dynamically generated keys, so currently the only real concern is the missing social-description key.


New feedback

[Enter feedback here]
good  for new learners..
Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 3de928ad-68c6-d30b-bc63-3354b76c149f
Version Independent ID: cbd03b5d-7f6b-b483-6ddf-4fe4cde5e9ec
Content: Application Insights overview - Azure Monitor
Content Source: articles/azure-monitor/app/app-insights-overview.md
Service: azure-monitor
Sub-service: application-insights
GitHub Login: @AaronMaxwell
Microsoft Alias: aaronmax

@Hareesh061 Thanks for sharing the feedback. Glad to know that th document is helpful.


Expanding on the rules for primary ctors

The object must encapsulate something, which means the primary ctor must have at least one parameter.

@pa9ey totally make sense, thanks


Can we speed up IPTT Expando?

Affects programs with a lot of disaggregated data. Tested on QA Programs -- Levels All the Way Down.
I'm noticing a long delay when I click "Expand all" in an IPTT with disaggregated data. I initially thought the button was non-responsive, then realized it was just very slow.) Can we look into the cause/es and see if there are any not-too-heavy options for speeding it up?

I've gone through the model level logic (ipttRootStore.expandAllRows() fires instantly, triggers the setState for all expando rows immediately, and they update their state immediately).  The delay comes in React batching the (for a program with, say, 58 visible indicators) 58 rows of state updates and firing them all which seems to be (without good React diagnostic tools installed locally) running into a memory or processing power lag time that is causing the delay.  Hoping @axoplasm can have some luck speeding that up, but if not I think it's a rewrite to make the rows show based on maybe a property of the root store so the render is still 58 individual renders but the state update is a single one on the root store?  @axoplasm feel free to bounce it back to me if it needs that level of rewrite, but wanted to give you a crack at a less intrusive fix first.

@camgnostic I'm not sure how helpful this is to you, as the rootstore stuff is over my pay grade. I thought my best approach would be to diagnose layout and paint, because that’s where we’d see improvements from markup, templating or styling:

The worst rendering culprit is recalculating styles, a onetime hit of ~60ms. Each row repaint is ~6ms. If you have a huge monitor you might have 100 rows? So that’s almost a second. But during that second you’d see the rows painting so it wouldn’t look like the app was hung. For funzies I tried it with about 100 visible rows, and I couldn’t notice a flash during that paint:

The big purple pause before anything appears to happen is in the ~1.5s after the buttons change state and before the visible rows paint. (“React stuff”).
Interestingly, we have the same problem in reverse (not as bad) when I collapse all:

Extra interestingly: when we expand rows again, we repeat the same problem:

As a JavaScript Idiot™ I would expect that, because I’ve pulled all that data out of the rootstore already, it would be stuffed away in memory somewhere so I wouldn’t need to repeat the experience. But maybe not!?!

As a sidenote, this suggests we won't see much (any?) speed improvements by changing from a table-based layout

@jennyhavah - the fix that Paul's diagnostics suggests is a medium-LoE fix without a guaranteed payoff (both Paul and I suspect that we know what would fix the problem (by moving from [with n rows to expand] n re-renders to 1 big table-wide re-render), but I don't have the React competence to stake any kind of guarantee that that will definitely speed it up.  I do know that it will take upwards of half a day to implement.  Disposition?

moving to Poblano per @jennyhavah, for a follow-on release


Remove and ignore Gemfile.lock

Any version pinning should be done in the gemspec itself, per
http://yehudakatz.com/2010/12/16/clarifying-the-roles-of-the-gemspec-and-gemfile/

Coverage remained the same at 99.454% when pulling d3d53b7cfa7f40391b9ce6478328d46457d15cca on reidab:remove-gemfile-lock into 0675a5c3306b14ea568c3fadcaa748fa2cf12326 on frictionlessdata:master.

@georgiana-b pls review and merge.


Add Sockjs support

Please add Sockjs support for browsers that dont support websocket
Does sockjs affects performance when emqttd runs in cluster mode?

@rock59, the broker side could add sockjs support, but what protocol used on the browser side?

First, Sorry for my bad english ;-(
I am using Stomp, RabbitMQ and its Stomp over Sockjs plugin in my company..I need to migrate to MQTT protocol to support IoT too (my company Raspberry Pi based gadgets) .. I consider to use emqttd but emqttd only support Websockets and we need to support our customers who use older browsers..
I am not a network programmer guru.. I googled and I found that Eclipse Paho implemented a javascript library that tunnel MQTT over websocket.. Is it possible to implement such library to tunnel MQTT over Sockjs?

@rock59,  I read some documents about SockJS. It seems SockJS use JSONP on older browsers that cannot support WebSocket. For MQTT(same to AMQP) is a binary protocol,  it will not work with JSONP, I think.
We have to write a Stomp over SockJS plugin to support your requirements.

This is correct.. SockJS uses Websocket in modern browsers and fallbacks to JSONP , Long Polling or other Text based Protocols(HTTP) in older browsers..
SockJS has two problems
1- It uses Text based protocols in fallback mode
2- Some develpers have doubt about its performance in clustered environments
We must use emqtt in clustered mode and performance is critical.
How much it cost to develop an stomp plugin for us?
Do you guaranty its performance in clustered mode specially when our users using older browsers with SockJS?

@rock59, I will support Stomp over SockJS and release the first version in this week. I think SockJS will not be the bottleneck anyway.

在 2015年9月7日，下午5:45，rock59<EMAIL_ADDRESS>写道：
This is correct.. SockJS uses Websocket in modern browsers and fallbacks to JSONP , Long Polling or other Text based Protocols(HTTP) in older browsers..
SockJS has two problems
1- It uses Text based protocols in fallback mode
2- Some develpers have doubt about its performance in clustered environments
We must use emqtt in clustered mode and performance is critical.
How much it cost to develop an stomp plugin for us?
Do you guaranty its performance in clustered mode specially when our users using older browsers with SockJS?
—
Reply to this email directly or view it on GitHub https://github.com/emqtt/emqttd/issues/277#issuecomment-138254150.

tnx

Stomp over SockJS  is ok?

We are using RabbitMQ-Web-Stomp(Stomp over Sockjs) plugin in our current stack and we are satisfied with it
We need a full featured MQTT broker like emqttd and are waiting for your Stomp over Sockjs implementation

@lsxredrain, Stomp plugin has been ready: https://github.com/emqtt/emqttd_stomp
We will integrate SockJS later.

Great job..

good job,  wait for SockJS,

@rock59, The SockJS/Stomp plugin has been released in 0.11.0: https://github.com/emqtt/emqttd_sockjs


feat: automate greetings using github bot

This PR fixes the issue #93 , kindly review it and merge. @CSEdgeOff
You need to give read and write permission to the bot to make comments hence kindly go to the repo  settings/actions/General  and under  Workflow Permissions  grant  Read and write permissions and then save.
like this ⬇

@dakshsinghrathore
Why the option was not highlighted is there any issue that you can solve.

@CSEdgeOff you should be the project owner to carry out this

@dakshsinghrathore yes I am


Add without_pip option to _.python.venv

Hi,
The new _.python.venv mechanism sounds very good.
Would it make sense to add a without_pip option for creation, mirroring python -m venv --without-pip ?
Virtual environment without pip are viable nowadays, since pip has a --python option.

It’s particularly viable when pip is not used at all. Because uv is upon us and all that 😄


Fix object references in readme file

Fixes object references in the readme file by replacing object with obj.
Example: toi.object.is() to toi.obj.is()

Duplicate.


Fix 'APIKeyUser' object has no attribute 'id' in identities featurestates path on edge

See this error in Sentry.

This is actually a bit messy to solve since it will break the webhook schema. As you can see here, we are currently always sending the email of the user that made the change. By updating this logic to support API keys, we'll no longer be able to support this.
This will need some thought about e.g. whether we need to version the webhook, etc.

Closing this in favour of #4555 (which is linked correctly to the issue in Sentry).


Add Error Bars (geom_pointrange) for multilevel designs

Substituted Swarmplot code to add function that plot points with add error bars (SEM or SD), intended for multilevel designs.

The build has errored, because (I suspect, not having looked closely at the code) your modification hard-codes a column name. We will need to figure out an API/keyword to parse to the dabest object.

Hello Joses!
Yes I noticed. It only works when calling the dataframe of the example I posted in the issue, because I'm directly calling for the columns 'AvrgPA' and 'SEM'. I saw that in order to code it nicely I would have to call them from the dasbest object.
I guess there are two ways to do this: 1- asking the user to input some column with information about the replicate as a factor, and use it to calculate a centrality and dispersion measure of the subject variable (such as mean and SEM). And/Or 2- ask the user to directly provide a summarized dataframe with both those measures.


oops acc wire broke

About the PR
forgot to check acc wire ingame when doing emag since forgot non-doors had wires too
acc wire had inverted functionality (once cut and mended at least once)
Media
trust me bro

[X] I have added screenshots/videos to this PR showcasing its changes ingame, or this PR does not require an ingame showcase

Changelog
no cl no fun

oo yea emagging it then trolling wire wouldve caused crash

honestly its kinda scary how much AddComp(omponent) is used considering itll crash if anything makes it have the component previously

itll throw an exception, in sim loop it wont crash on full release


Sample Rate 44,1 kHz not working

Hi all,
I installed BirdNET-Analyzer a few month ago on a system, and it worked fine. But now I got a new computer, installed the Analyzer also on this one. On this new system I got the error message "Cannot open file...". I found that the sample rate of 44100 Hz will not work anymore. If I convert the files to 48000 Hz, it worked fine.
Does anybody know the reason for this?
Best regards, Hans Guenter

I encountered the same issue. I'm sure there is a better way to deal with it, but for now I've changed the config.py file:
-SAMPLE_RATE = 48000
+SAMPLE_RATE = 44100

Regards

please try to install resampy with pip install resampy ?

Thank you, bartman! resampy seems to fix the problem!

Thanks for helping! I added resampy to the install instructions, since it seems librosa needs it for some features but it's not installed automatically.

Thanks! I will have a try on newest Python cos my BirdNET only works well on Py3.8.

Thanks! I will have a try on newest Python cos my BirdNET only works well on Py3.8.


fix: slottable labelText should render correctly

Currently, in TextInput and PasswordInput, the "labelText" slot will not be rendered as the condition only checks for the labelText prop.
<TextInput placeholder="Enter user name...">
  <!-- doesn't render -->
  <b slot="labelText" style="color: red">Label</b>
</TextInput>

Fixes

correctly render "labelText" slot in TextInput and PasswordInput

Fixed in v0.58.3


Major impovements and Updates

*Add currentScore variable and update score display
*Update index.html with Tailwind CSS and reorganize script imports
*Add score when player passes barrier
*Update welcome and instructions text styling
*Refactor player class: Add obstacle creation and score
Please squash if necessary before merging. I made a few mistakes with the github actions and it made me do some unnecessary commits.


Template for flutter create cupertino

A flutter create template that doesn't import material

Related #15279, #14719, #13611

CC @willlarche
@devoncarew working on this ticket implies the possibility of having multiple project templates. Is this something that your team can help with? Or, is there any particular reason why multiple project templates would be an issue?

I support multiple templates. But that should be spec'd out by needs and research. Has it? (I actually don't know.)

CC @InMatrix were any investigations ever done into multiple templates?  If not, can we chat a little bit about it? There are likely benefits across multiple use-cases. I know I had brought this up at some point when were in 1842, but then it got away from me as I focused more on Android APIs instead of tooling...

We need to be really really careful when designing extra templates. Our single existing template is a massive part of our first hour experience and anything that risks derailing new users from that experience is extremely dangerous in terms of our user adoption. Please make sure to loop me in on any design discussions and code reviews.

Mechanically, the IDEs need to be told about each additional template (we support app, package, and plugin) currently.
If the number grows too large, we'll have to change how we present them in the UI. One additional one won't cause issues. We'll just need to be aware, and perhaps do some version detection so we only offer it with versions of the framework that have those templates.

@Hixie - Will do.
@devoncarew what about a new screen in the flow after you select the app template?  I guess technically this isn't so much about project structure as it is about initial Dart source code. Maybe we could make it accessible via a subtle button that wouldn't distract new users?

We do have a bit of logic there that's template dependent - we'd want to update that as well for new templates.
Here's the UI for IntelliJ project creation:

And for Android studio project creation:

Note that in Android Studio, there is (frequently) and follow-on wizard page which is customized for the project type. cc @stevemessick for fyi

Thanks @devoncarew. And as @Hixie said, we have to be very careful here not to distract from the first hour experience. So I'm wondering where we can take this from here?
Should we collect some data with @InMatrix and @jayoung-lee? Or should we propose a specific wizard UI that would allow for selecting other source code configs?
Since this conversation has happened multiple times over the last year, I think it would be good to get the ball moving in some direction. Thoughts?

My original thought was just to add a flutter create --ios or flutter create -t app-ios or some such that doesn't impact the onboarding flow.
For IDEs, since it's not an additional dimension (i.e. plugin/packages are already android+iOS), it'd just be another entry in the project type. It can either be Application/Cupertino Application or Application - Material/Application - Cupertino or something like that.

I know some devs write apps only for iOS. This request seems to assume no devs write only for Android. Is that true? I ask because my first thought was if we need a material-specific template, as well.

@xster I think what you're describing would probably be seen as too much of a distraction from the first hour experience. I would imagine that there needs to be a very clear default path where a new developer does not risk selecting a different project type.
@stevemessick I think the basis for this ticket is that the default project essentially is a material/Android-esque project. So Android devs should be good with what they are getting now, right?

@matthew-carroll We haven't investigated user needs around multiple templates. @mit-mit was driving this effort before Flutter Live, but we ran out of time. I suggest we revisit where we were at the time. IIRC, we wanted to position a Material-based template as the one users generally should start, provided that we give pointers to how custom design can be implemented on top of the Material library. A Cupertino-based template was in that plan, but we wanted to suggest the template for developers specifically want an Apple OEM look & feel. I think @willlarche had a work-in-progress implementation.
I think it makes sense to keep the core set of templates we curate very small to maintain their educational value for on-boarding new users. That said, experienced users might want different templates for convenience. I suggest we repurpose the mechanism for creating a new project from a code sample URL, and host additional sample-based templates on a webpage, such as the visual sample catalog we wanted to reinstate: https://github.com/flutter/website/issues/1923.

@xster we have a codelab that shows off the use of Cupertino with Flutter and it's the first thing that comes up when searching on google.com for "flutter cupertino app" -- do you have that sufficient?

As we learned in recent research, developers who do use the Cupertino library still use Material widgets, since Cupertino provides a much more limited widget set than the Material library. Therefore, I don't think the original request "A flutter create template that doesn't import material" would provide practical value to users.
That said, making the default template visually more platform-neutral would help improve the perception of Flutter among iOS developers.

@InMatrix do you think we should be updating our app template to be more platform-neutral? I can see that being useful as we encompass more platforms. what are you thinking?of course, we should take into account the note from @Hixie above that cautions us to be careful here.

I think the template can use some styling tweaks to make it feels lighter and flatter to suit iOS aesthetics and replace the Floating Action Button with a regular button, since the FAB is more common on Android than on iOS or the Web. @willlarche had a mock along these lines.

There are definite optimizations we can make. Ian had concerns about
retaining the usefulness. If we're ready to do this, it's not an
inconsequential task but doable.
On Fri, Jan 10, 2020 at 4:10 PM Tao Dong<EMAIL_ADDRESS>wrote:

I think the template can use some styling tweaks to make it feels lighter
and flatter to suit iOS aesthetics and replace the Floating Action Button
with a regular button, since the FAB is more common on Android than on iOS
or the Web. @willlarche https://github.com/willlarche had a mock along
these lines.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/flutter/flutter/issues/18819?email_source=notifications&email_token=AAJWNZP2ATE5NGD4RC4Q4W3Q5DP43A5CNFSM4FG5E7E2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEIVHBZQ#issuecomment-573206758,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AAJWNZI7UBYCE2KPPWZDRKLQ5DP43ANCNFSM4FG5E7EQ
.


Unable to provide constant input tensors to keras functional API for TF2.0+

System information

Have I written custom code (as opposed to using a stock example script provided in TensorFlow):
OS Platform and Distribution (e.g., Linux Ubuntu 16.04): Linux
TensorFlow installed from (source or binary): pip
TensorFlow version (use command below): 2.3.0
Python version: 3.6
CUDA/cuDNN version: 10.0

Describe the current behavior
Under eager execution, Keras cannot use an existing tensor as a constant input. It returns the following error:

ValueError: You should not pass an EagerTensor to Input. For example, instead of creating an InputLayer, you should instantiate your model and directly call it on your input.

Describe the expected behavior
Keras should be able to wrap an optional existing tensor  into the Input layer, using tf.keras.Input(tensor=existing_tensor)
Standalone code to reproduce the issue
Provide a reproducible test case that is the bare minimum necessary to generate
the problem. If possible, please share a link to Colab/Jupyter/any notebook.
import tensorflow as tf
from tensorflow.keras import layers
import numpy as np
const_np = np.random.rand(2,10,3)
const_tf = tf.convert_to_tensor(const_np, dtype=tf.float32)
const_k = tf.keras.Input(tensor=const_tf)

Other info / logs Include any logs or source code that would be helpful to
diagnose the problem. If including tracebacks, please include the full
traceback. Large logs and files should be attached.
---------------------------------------------------------------------------
ValueError                                Traceback (most recent call last)
<ipython-input-1-ba2f0cbae65f> in <module>()
      4 const_np = np.random.rand(2,10,3)
      5 const_tf = tf.convert_to_tensor(const_np, dtype=tf.float32)
----> 6 const_k = tf.keras.Input(tensor=const_tf)

1 frames
/usr/local/lib/python3.6/dist-packages/tensorflow/python/keras/engine/input_layer.py in Input(shape, batch_size, name, dtype, sparse, tensor, ragged, **kwargs)
    309     input_layer_config.update(
    310         {'batch_size': batch_size, 'input_shape': shape})
--> 311   input_layer = InputLayer(**input_layer_config)
    312
    313   # Return tensor including `_keras_history`.

/usr/local/lib/python3.6/dist-packages/tensorflow/python/keras/engine/input_layer.py in __init__(self, input_shape, batch_size, dtype, input_tensor, sparse, name, ragged, **kwargs)
    171           raise_eager_tensor_error = True
    172       if raise_eager_tensor_error:
--> 173         raise ValueError('You should not pass an EagerTensor to `Input`. '
    174                          'For example, instead of creating an '
    175                          'InputLayer, you should instantiate your model and '

ValueError: You should not pass an EagerTensor to `Input`. For example, instead of creating an InputLayer, you should instantiate your model and directly call it on your input.

@fkong7
I have tried in TF nightly version(2.5.0-dev20201129) and i am not seeing any issue. Please, find the gist here.Please, veriy once and close the issue.Thanks!


Importing gensim prints stuff and configures logging

Problem description
Not sure if this is a ticket for smart_open or gensim, but importing gensim prints out some (unwanted) stuff: unable to import 'smart_open.gcs', disabling that module.
I checked the smart_open source code and this is actually printed from a logger:
logger.warning('unable to import %r, disabling that module', submodule)

This is a big no-no – libraries have no business configuring the logging subsystem. That's up to the application. If an app tried to import gensim and then call logging.basicConfig then the latter will be ignored, because logging will already have been set up. Not good.
Originally found via https://github.com/RaRe-Technologies/gensim/issues/2794 .
Steps/code to reproduce the problem

Versions
Please provide the output of:
import platform, sys, smart_open
print(platform.platform())
print("Python", sys.version)
print("smart_open", smart_open.__version__)

Darwin-15.6.0-x86_64-i386-64bit
Python 3.7.3 (v3.7.3:ef4ec6ed12, Mar 25 2019, 16:52:21)
[Clang 6.0 (clang-600.0.57)]
smart_open 1.11.1

Checklist
Before you create the issue, please make sure you have:

[x] Described the problem clearly
[x] Provided a minimal reproducible example, including any required data
[x] Provided the version numbers of the relevant software

Same issue with 3.8.2. Works perfect after downgrading to 3.8.1 :confused:

Same issue with 3.8.2. Works perfect after downgrading to 3.8.1

Downgrading to 3.8.1 did not work for me.

@kounelisagis @ebadi You need to downgrade smart_open to version 1.10.0 to get rid of the logging.

pip install smart-open==1.10.0 worked for me

Is it simply a logging or is the module really disabled?


Any way to make it ignore certain files?

Hi!
I usually have CR2 (RAW image) files in same folder than the JPG. Any way to make vimiv to ignore those files? As it seems vimiv cant render them.

Unfortunately this is not possible and I would consider this a bug in the fileactions.is_image method, it should only return True if the image can also be opened. I will try to find a fix for this in general.


Write paper

[ ] Sketch prepared by Lars: https://docs.google.com/document/d/1GbGbj_0BIWF0L2_jDzbytNyK6TYHHs6AFzQ4AkFe47E/edit#heading=h.t89h7g949bix
[ ] Just new list of authors: https://docs.google.com/document/d/1JTSCi06BfmF9s17TMXea7js5n4NPT0PI9tXBsDlVXQY/edit

I do not have permission on accessing these documents. @juanmirocks please add my gmail account there!

About PhD Thesis !

Thesis by Tanya: https://mediatum.ub.tum.de/?id=1304188
How to print: https://wiki.in.tum.de/Informatik/Benutzerwiki/XeroxDrucker

Jennifer Boyd, main editor of Bioinformatics for many year (maybe still)
<EMAIL_ADDRESS>


Tabs - no tab should be active if actual route does not match

Reproduction link
https://stackblitz.com/edit/angular-2twhgl
Steps to reproduce
Just append "/5" in the url, the page will be correctly reloaded but the tab "1" will be active even if the "/5" does not match any of the actual tabs links.
What is expected?
Expected no tab active if the actual route does not match any of the tabs defined links through [routerLink] directive
What is actually happening?
The first tab is active by default even if its routerLink is not matching with the actual route

Environment
Info

ng-zorro-antd
8.1.0

Browser
all

@ajeiie120120 Tabs component do not support nzSelectedIndex === -1. Check this demo. https://stackblitz.com/edit/angular-nrowfx?file=src/app/app.component.ts

Any news about the fix?

@wendzhue try nzHideAll

[PARTIALLY SOLVED]
@vthinkxie @wendzhue
Hi,
now the tabset does not highlight any tab if the relative link is not active.
But it seems that the first tab is not "smart" as the others and cant detect if current route has changed, so it does not react correctly.
You can try this example https://stackblitz.com/edit/angular-mtudaw:

At application start no tab is active (great!)
Select the "1" tab on the left tabset
Select the "6" tab on the right
The "1" tab is still highlighted even if the route has actually changed

Same with the "5" tab:

Select the "5" tab on the right tabset
Select the "2" tab on the left
The "5" tab is still highlighted even if the route has actually changed

But with other tabs this will not happen:

Select the "2" tab on the left tabset
Select the "5" tab on the right
Tab "2" will be deactivated correctly

or

Select the "6" tab on the right tabset
Select the "3" tab on the left
Tab "6" will be deactivated correctly

Thanks a lot quick support,
you're doing a great job.

@ajeiie120120 Hi. Thank you for these issues. We have fixed them problem. Please verify it in the next version.

@wendzhue thanks for the update, it works fine now.
The issue can be closed, great work!


Implementation of the Conformal Prediction method in mapieclassifier

Description
implementation of conformal prediction method in mapieclassifier. the changes have been made in the fit and the predict to implement the algorithm proposed here on page 3
Type of change
Please check options that are relevant.

[ ] Bug fix (non-breaking change which fixes an issue)
[x] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[x] This change requires a documentation update

How Has This Been Tested?
modifications were added in the test_classification module and added a test function (test_valid_prediction)
Checklist:

[x] I have read the contributing guidelines
[x] I have updated the HISTORY.rst and AUTHORS.rst files
[x] Linting passes successfully : flake8 . --exclude=doc
[x] Typing passes successfully : mypy mapie examples --strict
[x] Unit tests pass successfully : pytest -vs --doctest-modules mapie
[x] Coverage is 100% : pytest -vs --doctest-modules --cov-branch --cov=mapie --pyargs mapie
[x] Documentation builds successfully : cd doc; make clean; make html

Codecov Report

Merging #80 (5f4c88c) into dev (3a2557f) will decrease coverage by 0.11%.
The diff coverage is 99.10%.

@@             Coverage Diff             @@
##               dev      #80      +/-   ##
===========================================
- Coverage   100.00%   99.88%   -0.12%
===========================================
  Files           11       11
  Lines          811      876      +65
  Branches        54       60       +6
===========================================
+ Hits           811      875      +64
- Partials         0        1       +1

Impacted Files
Coverage Δ

mapie/classification.py
98.83% <96.77%> (-1.17%)
:arrow_down:

mapie/tests/test_classification.py
100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3a2557f...5f4c88c. Read the comment docs.


Use ExpressJs as dev server

@frandiox, I would like to use express server with vitesse-ssr both in production and development. Is that possible?

@folamy Yess, if you use version 0.12.0, you can use Vite SSR as middleware mode for your express server:
const express = require('express')
const { createSsrServer } = require('vite-ssr/dev')

async function createServer() {
  const app = express()

  // Create vite-ssr server in middleware mode.
  const viteServer = await createSsrServer({
    server: { middlewareMode: 'ssr' },
  })

  // Use vite's connect instance as middleware
  app.use(viteServer.middlewares)

  app.listen(3000)
}

createServer()

Thanks @frandiox, that works just fine!
But I discover the CSS scripts is not loaded on page load
This is the page after loading

Here is the page on page load (while loading).

Currently,  components and elements from frameworks/custom components are not properly rendered on pageload.
Note: There is a module: @css-render/vue3-ssr but I don't know how to apply that to the template!
Everything else works fine, except this!
Is there a way to fix it?

Ah, vite-ssr doesn't really do anything with CSS, so it must be related to this bug in Vite itself: https://github.com/vitejs/vite/issues/2282
There are workarounds for that in user-land but I'm hoping they will fix it soonish in Vite since they want to mark SSR features as production-ready 🤔

Ah, vite-ssr doesn't really do anything with CSS, so it must be related to this bug in Vite itself: https://github.com/vitejs/vite/issues/2282
There are workarounds for that in user-land but I'm hoping they will fix it soonish in Vite since they want to mark SSR features as production-ready 🤔

Thanks for the response! Okay, but I want to be sure if this is only a development issue or it also happen in production?

@folamy development only 👌

I've added docs for middleware mode here so I guess we can close this 👍

@folamy Yess, if you use version 0.12.0, you can use Vite SSR as middleware mode for your express server:
const express = require('express')
const { createSsrServer } = require('vite-ssr/dev')

async function createServer() {
  const app = express()

  // Create vite-ssr server in middleware mode.
  const viteServer = await createSsrServer({
    server: { middlewareMode: 'ssr' },
  })

  // Use vite's connect instance as middleware
  app.use(viteServer.middlewares)

  app.listen(3000)
}

createServer()

Hello @frandiox ,
Can I also use this approach with VITEdge?

@folamy It should be possible yes. Vitedge is not exporting createSsrServer but you can just get it from vite-ssr/dev directly. Make sure you add the vitedge plugin to your config instead of vite-ssr.
I haven't really tried it yet, so please report if you find any issue and I'll fix it.

@folamy It should be possible yes. Vitedge is not exporting createSsrServer but you can just get it from vite-ssr/dev directly. Make sure you add the vitedge plugin to your config instead of vite-ssr.
I haven't really tried it yet, so please report if you find any issue and I'll fix it.

That means I have to have both vitedge and vite-ssr install?

@folamy It should be possible yes. Vitedge is not exporting createSsrServer but you can just get it from vite-ssr/dev directly. Make sure you add the vitedge plugin to your config instead of vite-ssr.
I haven't really tried it yet, so please report if you find any issue and I'll fix it.

I tried it, but it didn't work!
(this will be run only when your dependencies or config have changed)
Error [ERR_MODULE_NOT_FOUND]: Cannot find module '/home/folamy/Desktop/tryout/functions/props/home.js' imported from /home/folamy/Desktop/tryout/node_modules/vitedge/dev/middleware.js
    at finalizeResolution (internal/modules/esm/resolve.js:285:11)
    at moduleResolve (internal/modules/esm/resolve.js:708:10)
    at Loader.defaultResolve [as _resolve] (internal/modules/esm/resolve.js:819:11)
    at Loader.resolve (internal/modules/esm/loader.js:89:40)
    at Loader.getModuleJob (internal/modules/esm/loader.js:242:28)
    at Loader.import (internal/modules/esm/loader.js:177:28)
    at importModuleDynamically (internal/modules/esm/translators.js:114:35)
    at exports.importModuleDynamicallyCallback (internal/process/esm_loader.js:30:14)
    at handleFunctionRequest (file:///home/folamy/Desktop/tryout/node_modules/vitedge/dev/middleware.js:53:55)
    at file:///home/folamy/Desktop/tryout/node_modules/vitedge/dev/middleware.js:254:20 {
  code: 'ERR_MODULE_NOT_FOUND'
}
Could not get page props for route "home"
FetchError: invalid json response body at http://localhost:3000/props/?propsGetter=%2Fprops%2Fhome&data=%257B%2522fullPath%2522%253A%2522%252F%2522%252C%2522path%2522%253A%2522%252F%2522%252C%2522query%2522%253A%257B%257D%252C%2522hash%2522%253A%2522%2522%252C%2522name%2522%253A%2522home%2522%252C%2522params%2522%253A%257B%257D%252C%2522href%2522%253A%2522%252F%2522%257D&rendering=true reason: Unexpected end of JSON input
    at /home/folamy/Desktop/tryout/node_modules/node-fetch/lib/index.js:272:32
    at processTicksAndRejections (internal/process/task_queues.js:95:5)
    at async Object.getRenderContext (file:///home/folamy/Desktop/tryout/node_modules/vitedge/dev/middleware.js:370:20)
    at async handleSsrRequest (/home/folamy/Desktop/tryout/node_modules/vitedge/node_modules/vite-ssr/dev/server.js:88:18) {
  type: 'invalid-json'
}

`

@folamy Ah, I forgot about something important. Assuming you put this exact code in a server.cjs file at the root of your project, then you need to add the following flags to the command line:
node --loader vitedge/dev/ts-loader.js --experimental-json-modules --experimental-specifier-resolution=node server.cjs

This works for me using the examples/vue project in vitedge repo (using Node v14.17.5).

Ok so in the next version the server will be available from vitedge/dev, and it can be run with vitedge dev --ssr --middleware ./my-server.js command (will be released in v0.16.0)

Ok so in the next version the server will be available from vitedge/dev, and it can be run with vitedge dev --ssr --middleware ./my-server.js command (will be released in v0.16.0)

That will be great!
I am expectant.

@folamy Released in 0.16.0!

@folamy Released in 0.16.0!

Thank you so much!
Would there be a note to this on the documentation page?

Yes, it's there: https://vitedge.js.org/usage.html#custom-dev-servers


Mention need to update() after TreeItem free()

See https://github.com/godotengine/godot/issues/38787#issuecomment-997526839

I thought you fixed that issue with #50135?

Ah, I guess this should be targeted for 3.x branch .-.

I mistakenly thought that my last comment was closing the issue and didn't notice that it was actually fixed.


Cloud rendering or Multimachine rendering?

Is there a way to run nexrender in the cloud or with an online rendering service to make it completely local-machine independent?
We used nexrender to dynamically change the template and get it rendered on our local machines, but we want to put this to a server and get it rendered either at AWS or some online render farm like Turborender.com or something.
Let me know. Thanks for all the support!

Hello @musdy
nexrender has nexrender-server and nexrender-worker binaries that can be used to create a networked solution. The server is used for job management and distribution to the workers. And workers do the general rendering.
The server is a simple HTTP API and can be deployed on any Linux machine, even the smallest AWS EC2 configuration. Worker, however, requires After Effects to be installed on the system, which needs to run either on Windows or macOS. With AWS, you can use Windows Server 2019. I know of at least one successful case of using it with nexrender.
The deployment process is straightforward, all needed things are packaged inside binaries in the releases, and theoretically, all you need is to download the build, and run it.
Cheers!

@inlife
What kind of server did you purchase on AWS for the worker?
Do they have windows server with NVIDIA GPU?
Could you send a link here?
Thanks.


gp3 instead of gp2 for the root volumes

Current ECS AMIs use gp2 type for EBS volume: https://github.com/aws/amazon-ecs-ami/blob/main/al2.pkr.hcl#L12
The newer gp3 EBS type is slightly cheaper and provides more IOPS for the size of the default root partition (30Gb).
Are there any technical reasons why gp2 was kept or it's something that can make a good pull request? :)

Found https://github.com/aws/amazon-ecs-ami/issues/62, closing this issue.


Test with ruby 3.3

Backported to radjabov in commit cb78d704c3445175134133fa98146fb674624555.
commit cb78d704c3445175134133fa98146fb674624555
Author: Brandon Dunne<EMAIL_ADDRESS>Date:   Tue Nov 5 17:05:48 2024 -0500

    Merge pull request #56 from kbrock/ruby3.3

    Test with ruby 3.3

    (cherry picked from commit 5994547f2885615361e0f755c7ab8241d56d374d)


Search query for giftcards

Problem
Customer support needs to able to find gift cards by the name or email of customers.
usedBy filter field doesn't help as it only accepts IDs of existing accounts, which doesn't cover anonymous users.
Another pain point is that admins want to use generic search that accepts any input instead of filters, the same way as product search works
### Tasks

GiftCard model changes:

Add search_index_dirty = models.BooleanField(default=False, db_index=True) field
Add search_vector = SearchVectorField(blank=True, null=True) field.

Fields to include in the search vector:

GiftCard.code
GiftCard.used_by_email
GiftCard.created_by_email
GiftCard.used_by - user's email, first name and last name
GiftCard.createdBy - user's email, first name and last name

See prepare_product_search_vector_value for a reference

Update logic to mark search_index_dirty=True whenever parts of the search vector change.
Add a Celery task that looks for dirty search indexes and updates the search vector value. The task should update a batch of gift cards in a single run and check if there are still gift cards to update and schedule itself in the queue to process the remaining ones in separate tasks.


support selection of similarity metrics for diversity and relevancy in MMR

Background

The literature seems unclear on what similarity metrics perform best for diversity and relevancy. (if anyone has found any good analysis on this would be great to see).
bm25 works better if a lot of text pre-processing is performed (stemming / lemmatization, word normalization, stop word removal, etc.) that is not as common in genAI / embedding workflows.  User data may be better suited to a vector search similarity function instead of keyword type method

Suggestion
We have already implemented bm25 and cosine similarity.  Allow users to select which similarity method they want to use (with reasonable defaults).

I agree that we must make it configurable to chose which metrics use.
But I disagree that we could let users use a vector search similarity function (like cosine similarity) for ensuring "diversity" in BM25. The documents have been already retrieved from the vector database as the closest according to the same function, so using the function won't help in reducing redundancy on the set of documents sent to the LLM in the prompt.

One of the main benefits of LangStream, thanks to its asynchronous nature, is that it makes it easy to perform preprocessing before storing the text on the vector database (we already have a a few agents that help with a good configuration out-of-the-box)


Unshaded + Ambient Occlusion + Outlines viewport mode

For level designing it's a bit hard to see in Unshaded mode when several objects have the same color, to see if the objects touch eash other. An Unshaded + AO + Outline option would fix that and an option for pseudo colors (uses a random color for each object). Something similar to the Workbench engine of Blender: https://twitter.com/tonroosendaal/status/991709311293448192

Feature and improvement proposals for the Godot Engine are now being discussed and reviewed in a dedicated Godot Improvement Proposals (GIP) (godotengine/godot-proposals) issue tracker. The GIP tracker has a detailed issue template designed so that proposals include all the relevant information to start a productive discussion and help the community assess the validity of the proposal for the engine.
The main (godotengine/godot) tracker is now solely dedicated to bug reports and Pull Requests, enabling contributors to have a better focus on bug fixing work. Therefore, we are now closing all older feature proposals on the main issue tracker.
If you are interested in this feature proposal, please open a new proposal on the GIP tracker following the given issue template (after checking that it doesn't exist already). Be sure to reference this closed issue if it includes any relevant discussion (which you are also encouraged to summarize in the new proposal). Thanks in advance!


Fix Window Insets

👋 Very nice app! Here is my little contribution:
Why ?
The current layout doesn't take into account Display cutouts:

Main
Search

Suggestion

Apply fitsSystemWindows on a content wrapper
Adjust margins to align the Floating Action Button with the Search Bar

Main
Search

How to test

On the Android emulator, we can enable fake cutouts in developer options

You rock Romain!!
Thank you for the fix <3
Feels like drivy again :)


fix: URLWithScheme custom string validator

the provider defined with sdkv2 was using ValidateFunc: validation.IsURLWithHTTPorHTTPS. It was replaced in the provider framework with stringvalidator.RegexMatches but the regex pattern did not work, for example, with a URL with port http://<IP_ADDRESS>:59827/. This custom validator replicates the previous validation using the url.Parse function

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 41.79%. Comparing base (a09e337) to head (7d293ad).
Report is 1 commits behind head on main.

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #611      +/-   ##
==========================================
+ Coverage   41.74%   41.79%   +0.04%
==========================================
  Files         102      102
  Lines       18551    18554       +3
==========================================
+ Hits         7745     7755      +10
+ Misses      10600    10593       -7
  Partials      206      206

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


Minor fixups post-promotion

Some occurrences of tyler36 didn't get changed.

Looks like I already did PR for this.


Fixed dutch grammar exclusion

Following the advice from #154, here's a fix for the Dutch locale

please update the src/lang/nl.js, then add the testcase.

@hustcc To ensure a test for NL, I'd have to add it to the default locales (if I'm reading everything correct). Would you agree with that?

Can see https://github.com/hustcc/timeago.js/blob/master/tests/lang/en.spec.js

you can just push pr into master.

All is done?

Correct, all is done.


[#56] Write empty methods in expanded way

https://www.rubydoc.info/gems/rubocop/RuboCop/Cop/Style/EmptyMethod
https://github.com/datarockets/datarockets-style/issues/56

p.s. @TheBlackArroVV https://github.com/datarockets/datarockets-style/blob/master/CONTRIBUTING.md#pull-requests

@TheBlackArroVV one issue, the comment message should be [Fix #issue_number] description
Now it Fix #59 but the issue for this PR is #56

@roman-dubrovsky , oops, my mistake, fixed

feel free to merge


Cookie banner not hiding on non-pluralsight domain / envs (Flow sandbox, etc.)

Duplicates

[X] I have searched the existing issues

Latest version

[X] I have tested the latest version

Current behavior 😯
When clicking the dismiss "x" button on the NavCookieBanner, it will only dismiss on Pluralsight domains due to this line.
Expected behavior 🤔
Clicking the "x" button will dismiss the banner regardless of environment the app is running in.
Steps to reproduce 🕹
Steps:

Visit https://sandbox-07.gitprime-ops.com/v2/org/gitprime/
Attempt closing the banner by clicking the x button

Context 🔦
When testing the Flow app in sandbox, we are unable to click the banner away & it blocks other content behind it in some cases.
Your environment 🌎
No response

Ticket here: https://pluralsight.atlassian.net/browse/DP-2387


Possible performance enhancement with Write-* cmdlets

This is more of a question than an issue at this point.
I wonder if PowerShell could invoke Write-Stream (Write-Verbose, Write-Debug, etc.) commands differently, still performing parse checking on scripts containing those commands to make sure they parse properly, but not actually invoking those commands unless the preference variable is appropriately configured or the parameter to make that stream's output show up was used directly or via $PSDefaultParameterValues.
For example, Write-Verbose -Message 'Hello' -Verbose would be invoked, but Write-Debug -Message $(Get-Service | Format-List * | Out-String) would not, unless $DebugPreference was set to something other than SilentlyContinue or Ignore).
For anyone familiar with the details surrounding how PowerShell executes commands, can someone comment on the feasibility/possibility of skipping commands that should be skipped as a way to optimize script performance? It's not hard to see how it could make a big difference, while encouraging broader use of Write-Verbose and Write-Debug at the same time (for the latter, especially if #7122 gets implemented).
cc: @lzybkr

There are certainly some significant performance gains possible, but I don't think targeting the Write- commands is a good approach.
Some issues:

What if the command is a function or alias, not the built in cmdlet?
What if the command forces the action, e.g. Write-Verbose "Hi there" -Verbose?

These 2 issues hit general performance issues (command lookup and parameter binding) that have room for major improvements.
If command lookup and parameter binding are fast, I have a feeling you won't care about the minor overhead of actually calling into the Write- commands.

Thanks @lzybkr, that's good food for thought.

I came to the same question from a security and performance view, taking the following example:
$Credential = Get-Credential
Write-Debug "Password: $(($credential.GetNetworkCredential()).Password)"

That the Write-Debug evaluates the message appears from:
Write-Debug "$(Write-Host 'Host') Debug"

Where the word Host is always displayed no matter of the $DebugPreference
From my point of view it would make sense that the $DebugPreference (and similar Write-* cmdlets) would have (default?) Bypass value.

Write-Host is explicitly coded to display by default unless you set -InformationAction Ignore, it's kind of what it's designed for. Subexpressions are evaluated before being passed to the command invocation.
I'd also contend that silencing or skipping the write cmdlets entirely would only ever make sense if their corresponding Action parameter or Preference variable is set explicitly to Ignore -- in all other cases users or administrators will often want the data to be captured in a transcript if one is running, so skipping the call completely isn't often really an option.
@lzybkr you mention that there are improvements to be made here. Is this a current focus for the PS team, or is this something I could take a look at? (And if so, I'd appreciate a pointer to where this code is so I or others can check it out!) 😄

Hello vexx32,
Thanks for the comment. You are right, the string is of cause already evaluated before it is passed to the Write-Debug cmdlet. I wonder if accepting a ScriptBlock  for the -Message parameter would make sense.
Something like:
Write-Verbose -Message {Get-Service | Format-List * | Out-String}

Or is that where KirkMunro actually asks for?

I believe @KirkMunro is asking for something like ConditionalAttribute with the difference being PowerShell would inject a runtime check for the preference variable around the call to the command.
@vexx32 - the improvements I have in mind are a major work item and I'm not aware of anyone that is seriously looking at. The basic idea is to use dynamic sites (like what is used for operators and member access) for command lookup and parameter binding, basically introducing a layer on top of the existing code. These areas probably have room for more incremental improvements too, but it will take some digging with a profiler and probably some creativity combined with some deep understanding of how those areas work.

Please either mark this issue with something like Resolution-Declined or put it on a kind of wishlist "Issue we would like to prioritize, but we can't commit we will get to it yet


查询任意地方防疫政策报错

日志如下
07-31 18:57:48 [ERROR] nonebot | Running matcher <Matcher from nonebot_plugin_covid19_news, type=message, priority=10, temp=False> failed.
Traceback (most recent call last):
File "/usr/local/bin/nb", line 8, in
sys.exit(main())
File "/usr/local/lib/python3.8/dist-packages/click/core.py", line 1130, in call
return self.main(*args, **kwargs)
File "/usr/local/lib/python3.8/dist-packages/click/core.py", line 1055, in main
rv = self.invoke(ctx)
File "/usr/local/lib/python3.8/dist-packages/click/core.py", line 1657, in invoke
return _process_result(sub_ctx.command.invoke(sub_ctx))
File "/usr/local/lib/python3.8/dist-packages/click/core.py", line 1404, in invoke
return ctx.invoke(self.callback, **ctx.params)
File "/usr/local/lib/python3.8/dist-packages/click/core.py", line 760, in invoke
return __callback(*args, **kwargs)
File "/usr/local/lib/python3.8/dist-packages/nb_cli/commands/main.py", line 30, in run
run_bot(file, app)
File "/usr/local/lib/python3.8/dist-packages/nb_cli/handlers/deploy.py", line 25, in run_bot
nonebot.run(app=f"{module_name}:{app}")
File "/usr/local/lib/python3.8/dist-packages/nonebot/init.py", line 261, in run
get_driver().run(*args, **kwargs)
File "/usr/local/lib/python3.8/dist-packages/nonebot/drivers/fastapi.py", line 170, in run
uvicorn.run(
File "/usr/local/lib/python3.8/dist-packages/uvicorn/main.py", line 463, in run
server.run()
File "/usr/local/lib/python3.8/dist-packages/uvicorn/server.py", line 60, in run
return asyncio.run(self.serve(sockets=sockets))
File "/usr/lib/python3.8/asyncio/runners.py", line 44, in run
return loop.run_until_complete(main)
File "/usr/local/lib/python3.8/dist-packages/nonebot/message.py", line 146, in _check_matcher
await _run_matcher(Matcher, bot, event, state, stack, dependency_cache)

File "/usr/local/lib/python3.8/dist-packages/nonebot/message.py", line 196, in _run_matcher
await matcher.run(bot, event, state, stack, dependency_cache)
File "/usr/local/lib/python3.8/dist-packages/nonebot/internal/matcher.py", line 668, in run
await self.simple_run(bot, event, state, stack, dependency_cache)
File "/usr/local/lib/python3.8/dist-packages/nonebot/internal/matcher.py", line 635, in simple_run
await handler(
File "/usr/local/lib/python3.8/dist-packages/nonebot/dependencies/init.py", line 92, in call
return await self.call(**values)
File "/usr/local/lib/python3.8/dist-packages/nonebot_plugin_covid19_news/init.py", line 106, in _
await send_msg(bot, event, get_policy(CITY_ID[city]))
File "/usr/local/lib/python3.8/dist-packages/nonebot_plugin_covid19_news/uilts.py", line 69, in send_msg
message = [text2image(msg) for msg in message]
File "/usr/local/lib/python3.8/dist-packages/nonebot_plugin_covid19_news/uilts.py", line 69, in
message = [text2image(msg) for msg in message]
File "/usr/local/lib/python3.8/dist-packages/nonebot_plugin_covid19_news/uilts.py", line 48, in text2image
font = ImageFont.truetype(font=dirname(file)+"/font/MSYH.TTC", size = FONT_SIZE)
File "/usr/local/lib/python3.8/dist-packages/PIL/ImageFont.py", line 959, in truetype
return freetype(font)
File "/usr/local/lib/python3.8/dist-packages/PIL/ImageFont.py", line 956, in freetype
return FreeTypeFont(font, size, index, encoding, layout_engine)
File "/usr/local/lib/python3.8/dist-packages/PIL/ImageFont.py", line 247, in init
self.font = core.getfont(
OSError: cannot open resource

已修复，现在默认还是发送文字，需要图片形式发送，参照readme修改配置。


Roadmap for future development of DomainSets

Here are a few areas I'm thinking of to improve DomainSets. I'm linking to existing issues.

Factor out the map code. It has no place in this package, and there is a lot of overlap with other packages. The main motivation originally for writing new code was to allow rectangular maps, which you need to map e.g. from 1D to 3D. At the time most existing packages assume that maps are invertible, square or both. (#92, #87)
Integrate better with existing packages that define domains, in orde to reuse them. A proof of concept using package extensions is in https://github.com/daanhb/DomainSetsExtensions.jl (#149)
Write documentation. Even the basic syntax for primitives is not documented. The mechanism of associating domains with canonical domains is very versatile and potentially useful if it were known how to use it (#101)
Avoid type piracy. A lot has improved already, but there are some remnants of operators from Base and LinearAlgebra being overloaded simply because they look nice. This will likely take another breaking release, but it should be done. (#148, #67)
Come up with a good implementation of approximate in (or approx_in), using atol and rtol arguments. It's important to get this right, since we've been so careful about distinguishing between open and closed domains as well. (#124)
Implement fewer concrete domains. We've been using IntervalSets for intervals. I'm reluctant to expand the implementation of simplices and hyperfaces because other packages already do this, both better and with more focus. (#100, #142)

I've been playing with a DomainSetsCore package, but I don't think it is essential to move forward so it's not on the list.
Ideally, these improvements make DomainSets smaller and yet more functional.

Pinging a few people, consider this for-your-information: @dlfivefifty @oschulz @aplavin @hyrodium @zsunberg @cscherrer

Thanks for keeping us up to date, @daanhb !


Command: prompt_open

Reopening old Issue in relevant Repo
https://github.com/limetext/lime/issues/36

---
Want to back this issue? **[Post a bounty on it!](https://www.bountysource.com/issues/13214807-command-prompt_open?utm_campaign=plugin&utm_content=tracker%2F15716642&utm_medium=issues&utm_source=github)** We accept bounties via [Bountysource](https://www.bountysource.com/?utm_campaign=plugin&utm_content=tracker%2F15716642&utm_medium=issues&utm_source=github).

done by https://github.com/limetext/commands/commit/98473cc8285090b56a90fe8a5c8a2ca7845e7baf.


std:: int overloads test model

Submission Checklist

[x] Run unit tests: ./runTests.py src/test/unit
[x] Run cpplint: make cpplint
[x ] Declare copyright holder and open-source license: see below

Summary
Adding a model that will test fun(int) and fun(real) for all functions that mirror the std:: cmath functions.
This is added to test the changes in https://github.com/stan-dev/math/pull/1765
Copyright and Licensing
Please list the copyright holder for the work you are submitting (this will be you or your assignee, such as a university or company): Rok Češnovar
By submitting this pull request, the copyright holder is agreeing to license the submitted work under the following licenses:

Code: BSD 3-clause (https://opensource.org/licenses/BSD-3-Clause)
Documentation: CC-BY 4.0 (https://creativecommons.org/licenses/by/4.0/)

Also I think that sqrt, tan and tanh appear twice in each block.

Thanks @bob-carpenter and @mcol
I was a bit sloppy, this should now be cleaned up.


Can you use alternative languages from Tesseract?

I had read here before that using custom training files for other languages fails.
Not too sure.

Although there have been several reports from users that using custom language files doesn't work, I think generally it's because either they trained the file with a mismatched version of Tesseract from this repo (this repo uses Tesseract 3.03-rc1) or they're trying to use a different engine like cube that is known not to work with user-created language files.
I have been successful in creating a custom language file and using it with this library, so let us know if you have an issue with your own custom language file and we'll help you out.

Hello Kevin,
Is the trained data files generated for 3.02 work for this version of Tesseract? I tried Arabic and Turkish files for 3.02 downloaded from Google code and they do not work! Any help would be appreciated
Dawan

@dawanjiali Can you open a separate issue for your question and provide the specific error message you're getting? Also double-check that your trained data files work with Tesseract 3.03-rc1 on your desktop. If it doesn't work with that version on desktop, it won't work with this library either.


[FX-1735] Featured artist view

Addresses: FX-1735
Issue:
When there are several featured artists within a collection and a user clicks the "View more" link, the featured artist module pushes the content beneath the featured artist module down making it not visible to the user.
Fix:
This PR refactors the featured artist component to take the user to a new view when the "View all" link is clicked. This displays all the artists that are within the collection and gives the user a back button to navigate back to the collection.

There is a PR to come in eigen that supports the new route/view for the FullFeaturedArtistList.

Remaining work:

[ ] PR related eigen work: https://github.com/artsy/eigen/pull/3028
[ ] Put this behind a feature flag.
[ ] Fix and add more test.

Looks good!!! 🎉 Nice work.
Re: tests, it would be good to verify that the FullFeaturedArtistListComponent correctly excludes artistIDs and FeaturedArtistIDs where applicable! 😄
It doesn't seem like we need a feature flag for this, as there won't be any follow-up work and it doesn't seem risky to ship directly to users. What do you think?

I agree about the feature flag suggestion. I think this is something Jeffrey wanted to see fixed sooner rather than later as well, but wouldn't hurt to double-check with him to confirm!

Fails

:no_entry_sign:

🃏 FAIL in FullFeaturedArtistList-tests.tsx

renders properly

Snapshot name: `FullFeaturedArtistList renders properly 1`- Snapshot+ Received- "Feature ArtistsPablo PicassoAmerican, 1877-1973FollowingFollowingAndy WarholAmerican, 1947-1987FollowingFollowingJoan MiroSpanish, 1877-1983FollowingFollowingJean-Michel BasquiatAmerican, 1960-2001FollowFollowingKenny ScharfAmerican, b. 1958FollowFollowing"+ "Featured ArtistsPablo PicassoAmerican, 1877-1973FollowingFollowingAndy WarholAmerican, 1947-1987FollowingFollowingJoan MiroSpanish, 1877-1983FollowingFollowingJean-Michel BasquiatAmerican, 1960-2001FollowFollowingKenny ScharfAmerican, b. 1958FollowFollowing"

Full message

Error: expect(received).toMatchSnapshot()
Snapshot name: FullFeaturedArtistList renders properly 1

Snapshot

Received

"Feature ArtistsPablo PicassoAmerican, 1877-1973FollowingFollowingAndy WarholAmerican, 1947-1987FollowingFollowingJoan MiroSpanish, 1877-1983FollowingFollowingJean-Michel BasquiatAmerican, 1960-2001FollowFollowingKenny ScharfAmerican, b. 1958FollowFollowing"

"Featured ArtistsPablo PicassoAmerican, 1877-1973FollowingFollowingAndy WarholAmerican, 1947-1987FollowingFollowingJoan MiroSpanish, 1877-1983FollowingFollowingJean-Michel BasquiatAmerican, 1960-2001FollowFollowingKenny ScharfAmerican, b. 1958FollowFollowing"
at toMatchSnapshot (/home/travis/build/artsy/emission/src/lib/Scenes/Collection/Components/tests/FullFeaturedArtistList-tests.tsx:33:25)
at tryCatch (/home/travis/build/artsy/emission/node_modules/regenerator-runtime/runtime.js:45:40)
at Generator.invoke [as _invoke] (/home/travis/build/artsy/emission/node_modules/regenerator-runtime/runtime.js:271:22)
at Generator.prototype. [as next] (/home/travis/build/artsy/emission/node_modules/regenerator-runtime/runtime.js:97:21)
at tryCatch (/home/travis/build/artsy/emission/node_modules/regenerator-runtime/runtime.js:45:40)
at invoke (/home/travis/build/artsy/emission/node_modules/regenerator-runtime/runtime.js:135:20)
at /home/travis/build/artsy/emission/node_modules/regenerator-runtime/runtime.js:145:13
at /home/travis/build/artsy/emission/node_modules/react-tracking/node_modules/core-js/modules/es.promise.js:113:22
at flush (/home/travis/build/artsy/emission/node_modules/react-tracking/node_modules/core-js/internals/microtask.js:26:9)
at processTicksAndRejections (internal/process/task_queues.js:75:11)

:no_entry_sign:

🃏 FAIL in Collection-tests.tsx

renders a snapshot

Snapshot name: `Collection renders a snapshot 1`- Snapshot+ Received@@ -9,11 +9,11 @@ ListHeaderComponent={
Full message

Error: expect(received).toMatchSnapshot()
Snapshot name: Collection renders a snapshot 1

Snapshot

Received

@@ -9,11 +9,11 @@
ListHeaderComponent={
<ForwardRef(Relay(CollectionHeader))
collection={
Object {
"__fragmentOwner": Object {

          "identifier": "bc3659ca34d0a3d9e4807e2294e185e2{}",

          "identifier": "97a30e65f961be03f0e817ca03d683d2{}",
          "node": Object {
            "fragment": Object {
              "argumentDefinitions": Array [],
              "kind": "Fragment",
              "metadata": null,

@@ -570,11 +570,11 @@
"alias": null,
"args": Array [
Object {
"kind": "Literal",
"name": "size",

                              "value": 9,

                              "value": 4,
                            },
                          ],
                          "concreteType": "Artist",
                          "kind": "LinkedField",
                          "name": "merchandisableArtists",

@@ -667,11 +667,11 @@
},
],
"storageKey": null,
},
],

                          "storageKey": "merchandisableArtists(size:9)",

                          "storageKey": "merchandisableArtists(size:4)",
                        },
                        Object {
                          "alias": null,
                          "args": null,
                          "kind": "ScalarField",

@@ -717,11 +717,11 @@
"storageKey": "marketingCollection(slug:"doesn't matter")",
},
],
},
"params": Object {

              "id": "bc3659ca34d0a3d9e4807e2294e185e2",

              "id": "97a30e65f961be03f0e817ca03d683d2",
              "metadata": Object {
                "relayTestingSelectionTypeInfo": Object {
                  "marketingCollection": Object {
                    "enumValues": null,
                    "nullable": true,

at Object.toMatchSnapshot (/home/travis/build/artsy/emission/src/lib/Scenes/Collection/tests/Collection-tests.tsx:46:31)
at Object.asyncJestTest (/home/travis/build/artsy/emission/node_modules/jest-jasmine2/build/jasmineAsyncInstall.js:102:37)
at /home/travis/build/artsy/emission/node_modules/jest-jasmine2/build/queueRunner.js:43:12
at new Promise ()
at mapper (/home/travis/build/artsy/emission/node_modules/jest-jasmine2/build/queueRunner.js:26:19)
at /home/travis/build/artsy/emission/node_modules/jest-jasmine2/build/queueRunner.js:73:41
at runNextTicks (internal/process/task_queues.js:58:5)
at processImmediate (internal/timers.js:412:9)

  Generated by :no_entry_sign: dangerJS

Closing this PR in favor of https://github.com/artsy/eigen/pull/3039


Add cluster status ' skipped'

Description
Cluster configurations which will never be reconciled (because they got faster outdated as they could be reconciled) should receive the cluster status skipped instead staying endless in reconcile_pending status.
The change to the reconcile_skipped status should happen by the cluster-inventory (inside one DB-transaction):

query for cluster-status which are set to reconcile_pending for the particular cluster (SQL pseudo statement: select * from inventory_cluster_config_statuses where status='reconcile_pending' and cluster_version=123)
create for each cluster_config a new status which is reconcile_pending

AC:

A new cluster version provided by KEB will update the status of any other cluster-configurations which are in status reconcile_pending to reconcile_skipped

Reasons
Simplify analysis for human users.
Attachments

Functionalities of the Reconciler were migrated to the new architecture, this issue will not be worked on.


[feature] Introduce a smail debugger

I think for Jadx to have a smali debugger would be totally awesome, so I opened this issue for a PR. :D

Done in PR #1137


⚠ Bofrost.at has degraded performance

In c93d725, Bofrost.at (https://www.bofrost.at) experienced degraded performance:

HTTP code: 200
Response time: 1168 ms

Resolved: Bofrost.at performance has improved in 66fe016.


Revisit Card Models

More general card model for fix costs

Also Attack/incident and Oopsie cards currenlty can have all possible effects, this may lead to strange code paths


AMBARI-24605. Using the new RBAC framework to allow cluster operators/administrators and Ambari administrators to manage widgets

Clone of #2274 (but this one is going to be merged into branch-2.7)

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/Ambari-Github-PullRequest-Builder/3892/
Test PASSed.


Temporarily disable Appveyor CI

Appveyor is adding a lot of noise to our PRs, and we've stopped paying any attention to it when merging. I suggest we disable it until someone has time to debug it.
An eventual fix is tracked by: https://github.com/mirage/irmin/issues/963.

After some faffing, this seems to be working. I suggest that it is ready to merge.

CI failing for unrelated reasons (ironically).