Pluggin still run in background aven if app is closed

Hello,
I managed to make the package to work.
However, when I close the app on android (not just put in background), the location tracking is still active, draining the battery.
How to automatically stop the tracking in this case?

That's the point of using this library, it will continue to run and get location updates in background no matter what. For stopping this you have to call BackgroundLocator.unRegisterLocationUpdate().

I know and that's perfect.
I added the BackgroundLocator.unRegisterLocationUpdate() to the dispose function of my app but when I close the app, the location is still tracked.
I have to force kill the app to stop it.

It may be a bug in the library, I Will check it. But Please be sure that dispose() function is getting called.

Ok thanks
Otherwise, is it something to put in the application class?

I ran the example app and the start stop buttons worked as expected without any problem, Please be sure that your dispose() method and BackgroundLocator.unRegisterLocationUpdate()  is getting called.

yes the buttons worked as expected
it is the dispose function that is not called, but according to my researches on google, this is a more general issue with flutter.
I'll continue searching and post a solution if i find one

Hello
I did some researches and here is what I understood:

you create your flutter app, initialize the plugin and register it
when the service has a new position that matches timing and distance, it is sent to the callback.
However, if the flutter app is not running (for example if the user quit the app, not just background), the plugin recreate a new backgroundFlutterView  to execute the associated code.
Then, if the user launch the app, a new instance of flutter is launched
Therefore, you have 2 flutter apps running.

What I would like instead, is that if there is no backgroundFlutterView, the background service should stop
Could you help me with that, because I don't know kotlin coding at all and I don't manage to understand how your code works

Fixed

For me, the behaviour is still not right.
Here is what I get with your example :

I start the app and start the background location
-> The log is working and displayed normally
I exit the app (swipe up in the tray) without stopping the background location
-> I still have the notification indicating that location is running in background
I start the app
-> the log is not displayed and does not update. The sticky notification is still active
I start the background location
-> Nothing happen even if the notification is still active
I stop and restart the background location
-> Nothing happen
To get the app running normally again, I have to stop background location and then exit the app before l restart it

For me the correct behaviour should be either :

at step 2, the background location should stop in order to restart correctly at step 3
or at step 4, the app should receive normally the callback

This is the expected behavior, The plugin won't stop locating automatically, you have to manually stop it.
As you stated in step 3, the example won't show log after coming back to ui, This is a bug in ui and I will fix it asap, but the plugin is working correctly in background. at this stage if you press stop the notification disappear too.

Ok thanks for your answer

It would be great if a "onTerminated" property added to the plugin. If true then unRegisterLocationUpdate() will be called when app is closed. Calling BackgroundLocator.unRegisterLocationUpdate(); in dispose() doesn't work.
And there should be some click actions on the sticky notification. Sth like stop tracking or resume the app.
This plugin is awesome!!
Looking forward the coming updates.

@bobppsureway  Please open a new issue for this.

@Sly2024 @bobppsureway auto stop option added.


drop account merging

Account merging is complicated and therefore error-prone.
Reticketed from #1052.

---
Want to back this issue? **[Post a bounty on it!](https://www.bountysource.com/issues/27562738-drop-account-merging?utm_campaign=plugin&utm_content=tracker%2F85909&utm_medium=issues&utm_source=github)** We accept bounties via [Bountysource](https://www.bountysource.com/?utm_campaign=plugin&utm_content=tracker%2F85909&utm_medium=issues&utm_source=github).

What's it blocked on?

Blocked on #3837, because the root cause of most account merging is that we allow multiple ways to authenticate with Gratipay. Someone signs in with Twitter, comes back six months later and signs in with GitHub: now they have two accounts. Once we drop social authentication and just have email authentication, we greatly reduce the need for account merging and can therefore do away with it.


Added --custom-query-file option to arangoexport

Scope & Purpose

Added option --custom-query-file to arangoexport, so that a custom query
string can also be read from an input file.

[ ] :hankey: Bugfix
[x] :pizza: New feature
[ ] :fire: Performance improvement
[ ] :hammer: Refactoring/simplification

Checklist

[ ] Tests

[ ] Regression tests
[ ] C++ Unit tests
[ ] integration tests
[ ] resilience tests

[x] :book: CHANGELOG entry made
[ ] :books: documentation written (release notes, API changes, ...)
[ ] Backports

[ ] Backport for 3.9: -
[ ] Backport for 3.8: -
[ ] Backport for 3.7: -

Related Information

[ ] Docs PR: TO DO: MISSING!
[ ] Enterprise PR:
[ ] GitHub issue / Jira ticket:
[ ] Design document:

I'd question whether one would want to pipe / file bindvars into arangoexport as well?
else LGTM.

@dothebart That doesn't seem particularly useful to me. Why use bindvars in the first place if you want to store them in a file anyway? You could as well write the vars into the query file or do some templating on your own if really needed. Piping doesn't work on Windows BTW.


implement own metrics or use lighter packages

🚀 Feature
revisit 3rd-party dependencies and if possible make own implementation or use a lighter package
Motivation
keep the TM dependency light, and use other packages only as a reference
Pitch

Alternatives
use another package that has less dependencies and still use this one as reference
Additional context
https://github.com/PyTorchLightning/metrics/blob/525642df8c3f3f5f93cdd22b6b9cd802a3854634/requirements/image.txt#L3
https://github.com/PyTorchLightning/metrics/blob/525642df8c3f3f5f93cdd22b6b9cd802a3854634/requirements/text.txt#L1-L3
Particular tasks:

#432

@Borda May I have a look at the rouge_score metric?

@Borda May I have a look at the rouge_score metric?

that would be great! looking forward to see draft PR :rabbit:

@Borda I'd love to contribute to this project. Do you mind if I work on the WER metric to remove the dependency of jiwer?

Do you mind if I work on the WER metric to remove the dependency of jiwer?

wow, that you, that would be really great! :rabbit:
cc: @SeanNaren


Small improvement to HOW_TO_RELEASE.md

Clarify step 8. by pointing to where the ReadTheDocs build actually is

Thanks!


missing

In runtime V2.0.12493 the appsettings 'FUNCTIONS_WORKER_PROCESS_COUNT' has come available.
When I google on this setting I can't find anything anywere about this setting.
Some documentation is appreciated .

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 18aa54fd-3aa1-37c5-925c-51a0195b1030
Version Independent ID: 60198016-1ea9-e7ae-b00b-2c665d5ad8ca
Content: App settings reference for Azure Functions
Content Source: articles/azure-functions/functions-app-settings.md
Service: azure-functions
GitHub Login: @ggailey777
Microsoft Alias: glenga

@tjgalama Thank you for your feedback! We will review and provide an update as appropriate.

@ggailey777 Any thoughts here?

@tjgalama Did you find a way to give this setting a value? There is a bit of a description in this issue I was looking at: https://github.com/Azure/azure-functions-python-worker/issues/236. And I am trying to use it to enable concurrent Python Azure Function execution, but I am unsure where or how I would set the value.

@pragnagopa do we have any info we can provide to customers about FUNCTIONS_WORKER_PROCESS_COUNT? If so, we should probably add it to the app settings reference article.

@tjgalama I'm working on tracking down info on this new app setting. Thanks for pointing out the content gap.

Apologies, for my delayed response:
The moment I opened this issue, I was looking for a way to restrict the number of instances (concurrent processes) the functions app scales out. This meets the description mentioned with the setting WEBSITE_MAX_DYNAMIC_APPLICATION_SCALE_OUT.
Although the documentation of setting 'WEBSITE_MAX_DYNAMIC_APPLICATION_SCALE_OUT' is fine, the setting itself is useless for my case. This was one of the reason's I was searching for less known settings that might perhaps help (in this case 'FUNCTIONS_WORKER_PROCESS_COUNT').

cc @asavaritayal @maiqbal11 - for the scenario

Brief description from @pragnagopa, which I will add to the article:
Set application setting FUNCTIONS_WORKER_PROCESS_COUNT to value between 1-10 to spawn multiple language worker processes. Function invocations will be evenly distributed among the language worker processes.
Note:

Language worker processes are spawned every 10secs until the count set by FUNCTIONS_WORKER_PROCESS_COUNT is reached.
Using multiple language worker processes is not scaling. The setting is most useful if your workload has a mix of CPU bound and I/O bound invocations.

This setting is now documented. #please-close

Hello @ggailey777 : can you confirm me this assumption just for my sake of mind ?
If I let it to "1" (the default value) and I have only ".Net Function" in my AppService : only one Function will be working at a time ?
Regards.


Changed sort delimiter

Description
Changed the proposal order delimiter from " " to ":"
Motivation
Fixes catanie proposals table sorting bug
Changes:

Changed the order delimiter in proposal fullquery from " " to ":"

Tests included/Docs Updated?

[ ] Included for each change/fix?
[x] Passing? (Merge will not be approved unless this is checked)
[ ] Docs updated?

Extra Information/Screenshots

this isnt just a problem in proposals and should be changed on the client side

ill make a change Henrik, no worries

I can only see this bug in proposals table, all the other ones are working as they are supposed to.

ok yes looks good


Feature | Automated profile/region selection when using AWS Cli commands

Describe the Feature
When running AWS Cli commands with Leverage the profile and region should be automatically selected and passed as parameter to AWS Cli.
Expected Behavior
When running an AWS Cli command, taking advantage of the binbash Leverage tool, e.g.:
leverage aws s3 cp --profile my-profile-name ./test-kungfoo s3://my-bucket-name

...the used profile is the one is already set in the binbash Leverage environment (same for region). This profile is the default one for the proyect+account+role combination, so binbash Leverage could set this automagically for me.
Use Case
When working with AWS resources, it is faster to interact with them using the AWS Cli. (as opposed to Web Console)
Since binbash Leverage has the credentials already set in its environment, we can take advantage of it and use those credentials automagically to configure the AWS Cli.
So, instead of:
leverage aws s3 cp --profile my-profile-name ./test-kungfoo s3://my-bucket-name

I could simply run:
leverage aws s3 cp ./test-kungfoo s3://my-bucket-name

Same goes for region.
"It is one small step for man, one giant leap for mankind."
Describe Ideal Solution
binbas Leverage adding needed parameters when AWS Cli command is run.
Alternatives Considered
Keep adding profile and region manually.
Additional Context
I know not many people use it, but since it is useful for me I think it can be useful for more people when they find this is possible.

For the moment we'll close this issue till customer projects requires it.


Handling multiple aliases

Sometimes a method has multiple aliases.
For example, a method value may go by the aliases valueOf, toJSON, and run.
How should this be handled?

How should this be handled?

I'm currently doing something like this:
 * @alias toJSON, valueOf

Is there no way to do this? I use @alias alternateMethodName and don't see anything different in my output.


Attempting to talk to github repos from in the devcontainer fails.

When attempting to pull latest changes the following error is encountered.
fatal: unable to access 'https://github.com/user/repo/': server certificate verification failed. CAfile: none CRLfile: none

A temporary work around is to disable ssl verification but this isn't optimal.
git config --global http.sslVerify false


Completed reports must be exported and uploaded to the HomeGauge cloud system

BRS

Physical Constraint: The only online connection the system should have is to the HomeGauge customer report delivery network.


Incorrect web app folder structure in 3-Web-App/1-Web-App's Chinese README.md

Describe the bug
The Web App folder structure in ML-For-Beginners/3-Web-App/1-Web-App/translations/'s README.md (Chinese ver.) is incorrect.
Expected behavior
Folder templates/ should share the same depth with static/, not being its subfolder.
web-app/
  static/
    css/
  templates/
notebook.ipynb
ufo-model.pkl

Screenshots
(This screenshot shows that the current folder structure is incorrect)

(This screenshot shows the correct folder structure)

thank you, fixed it. Feel free to PR the repo!


[skdb] Default timezone to UTC

Thanks for working on this. I think it will save a lot of future pain. Left some comments just to check my understanding.


Initial dredd testing

Rearranges the Swagger file to make some testing easier, and adds some examples.
Adds the dredd config file and hooks for python.  Not sure where the best place to put the Dredd stuff is; if it moves, paths in the dredd config file will have to change as well.  Only test success paths for now.
Note that the calls tests fail; the Variant and Individual IDs are UUIDs, but the references to variants and individuals in the swagger files are int64s.

Merged manually in 86ecf04.


Support local files for pdf and accessibility as well

I missed this when I implemented:

#35

I'm going to treat this as a big, not a new feature, because the documentation already implies that this should work.

Got accessibility working:
% shot-scraper accessibility /tmp/Daring\ Fireball.html
{
    "role": "WebArea",
    "name": "Daring Fireball",
    "children": [
        {
            "role": "link",
            "name": "Daring Fireball",
            "description": "Daring Fireball: Home"
        },

And pdf too:
% shot-scraper pdf /tmp/Daring\ Fireball.html
Screenshot of 'file:/tmp/Daring Fireball.html' written to 'tmp-DaringFireball-html.1.pdf'


Support schemas in queries

As far as I'm aware, there seems to be a lack of support for querying from schemas. For example, switching from public schema to a different schema.
A possible solution is that EntityName should support a new function called schema_name perhaps:
pub trait EntityName {
    fn schema_name(&self) -> Option<&str> {
        None
    }
}

Where None would not include a schema selector in the queries.. and Some(&str) would append the schema before the table name in queries.
This would change queries from:
SELECT "users"."id", "users"."email" FROM "users" ...

to:
SELECT "user"."users"."id", "user"."users"."email" FROM "user"."users" ...
-- or
SELECT "public"."users"."id", "public"."users"."email" FROM "public"."users" ...

It seems like the hack I described above no longer works.

I think we should add the capability of prefixing schema name to SeaQuery first.
Then, we can have something like... in SeaORM?
impl EntityName for Entity {
    fn schema_name(&self) -> Option<&str> {
        Some("public")
    }

    fn table_name(&self) -> &str {
        "users"
    }
}

I think SeaQuery already have that. I have done that previously for supporting SeaSchema.

I think we should add the capability of prefixing schema name to SeaQuery first.
Then, we can have something like... in SeaORM?
impl EntityName for Entity {
    // With default implementation of returning `None`
    fn schema_name(&self) -> Option<&str> {
        Some("public")
    }

    fn table_name(&self) -> &str {
        "users"
    }
}

Totally agree your approach.

I guess we need schem_name on each columns for the following use case:
SELECT public.actor.*
FROM public.actor, new_schema.actor

If so, I guess we need... in SeaQuery
/// Column references
#[derive(Debug, Clone)]
pub enum ColumnRef {
    Column(DynIden),
    TableColumn(DynIden, DynIden),
    // New variant
    SchemaTableColumn(DynIden, DynIden, DynIden),
}

https://github.com/SeaQL/sea-query/blob/bab97eebbbf7581c9cefe0eeef24d636aac5dc65/src/types.rs#L47-L52

Btw... I think we have to change the RelationDef to join table with schema prefix.
https://github.com/SeaQL/sea-orm/blob/af4fb2ab7df92131ebe140e53de7f15598b4bdf5/src/entity/relation.rs#L17-L22

Should we support schema prefix in column expressions at this stage? @tyt2y3

I agree that the from_tbl field of RelationDef has to be changed (perhaps simply to Identity)
And I think the scope of this issue is only about the table name

If so, #74 is ready to merge


Feature/icsaas 380 improve autocomplete

fix flickering
bold query string in results
remove border bottom between suggestions
trigger search upon selecting a suggestion

could you leave a screenshot / gif?

Before on the left, with improvement on the right:
https://user-images.githubusercontent.com/81755864/150835451-0237de21-4273-41b0-994b-5b60a9b59d14.mov
Styling fixes:

@nhirrle
a little improvement with trimming.


Wallet morpheus agent

Morpheus the Smart Agent with  has memory, a calculator, and can create wallet transactions.

This is an awesome milestone.


Obsolete dependencies

In the install app dependencies test shows this:

_Run npm ci
npm WARN deprecated<EMAIL_ADDRESS>Please see https://github.com/lydell/urix#deprecated
npm WARN deprecated<EMAIL_ADDRESS>See https://github.com/lydell/source-map-url#deprecated
npm WARN deprecated<EMAIL_ADDRESS>See https://github.com/lydell/source-map-resolve#deprecated
npm WARN deprecated<EMAIL_ADDRESS>https://github.com/lydell/resolve-url#deprecated
npm WARN deprecated<EMAIL_ADDRESS>Chokidar 2 does not receive security updates since 2019. Upgrade to chokidar 3 with 15x fewer dependencies
npm WARN deprecated<EMAIL_ADDRESS>This proposal has been merged to the ECMAScript standard and thus this plugin is no longer maintained. Please use @babel/plugin-transform-class-properties instead.
added 1813 packages, and audited 1814 packages in 28s
226 packages are looking for funding
run npm fund for details
7 high severity vulnerabilities
To address issues that do not require attention, run:
npm audit fix
To address all issues (including breaking changes), run:
npm audit fix --force
Run npm audit for details._

So is the app are using old obsolste depenencies, if so then it should be updated.

Thank you for reporting this! It is now resolved in the main branch
Cheers!


Tracking Job Failures

I've been testing out the Elastic Jobs today, I can see my test SQL statements (just simple inserts) work as expected, but the job failure status always comes back as a failure.
Not sure if this a bug or lack of understanding, what triggers the return codes? and is there any way for tracking where the issue could be? (for instance I can see the Azure SQL activity logs show the job being executed but nothing else in there or on the database)

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 3a93bc08-f5ce-c475-5fc8-7c515f28a0ee
Version Independent ID: 1f33df85-76cb-50ca-a57a-47d3db552def
Content: Create an Elastic Job agent using PowerShell - Azure SQL Database
Content Source: articles/sql-database/elastic-jobs-powershell.md
Service: sql-database
Sub-service: scale-out
GitHub Login: @johnpaulkee
Microsoft Alias: joke

@andy-andykingit Thank you for bringing this to our attention. Can you verify the value in the lifecycle column in the job_executions table (JobDatabase):

Thanks Mike,
My job is has 1 step. When I execute the job I see 4 executions for the 1 job ID.
1 of these 4 is successful (the actual sql insert execution), the other 3 report a FAILED Status

Aha. I see the "message" now - failure on my part

Still confused.
I run a Job ID with one step and 1 target configured in a target group.
When the job runs I can see 4 child jobs are created

I see the end insert on my database, confirmed by the job task id 355cecfc-ef41-40a0-8ecd-af3989614ccf here (this is what i wanted)

Task id cc7abd37-116b-4ae8-b63e-a6f8162e2ae7 shows as failed in the job executions table but when you look into task executions table its successful

And then job Id dc1fc253-24f5-40fd-a9ef-7b6e7c20f358 targets the jobdatabase, which is not in my target group. It fails because it tries to run the query against the job database, which I didnt expect it to do and then fails

I followed the tutorial verbatim and what I have is two SQL Server instances, one hosts the jobs database and the other hosts the two databases where the elastic job runs.

The tutorial creates a single job with two steps.

When I first ran this, all was successful. I then set this to run every 1 hour, per the tutorial and since then I see quite a few failures being generated...in a specific cycle:

The basis for the job is the following:

Write-Output "Creating job steps..."
$sqlText1 = "IF NOT EXISTS (SELECT * FROM sys.tables WHERE object_id = object_id('Step1Table')) CREATE TABLE [dbo].[Step1Table]([TestId] [int] NOT NULL);"

$sqlText2 = "IF NOT EXISTS (SELECT * FROM sys.tables WHERE object_id = object_id('Step2Table')) CREATE TABLE [dbo].[Step2Table]([TestId] [int] NOT NULL);"

If I go the JobDatabase and query job_task_executions and look at the message column, I see a bunch of errors from the elastic job trying to access a database that is not part of this tutorial:

The specific error message:

Failed to connect to the target database: The server principal "jobuser" is not able to access the database "DotNetAppSqlDb20191209114156_db" under the current security context.
Cannot open database "DotNetAppSqlDb20191209114156_db" requested by the login. The login failed.
Login failed for user 'jobuser'. (Msg 916, Level 14, State 2, Line 65536)

Do you have any additional databases hosted in your environment? If the elastic job is attempting to run the job against the JobDatabase then is this database hosted on the same SQL Server instance as the target databases, that are intended to be where the Elastic Job is to be run?

I was trying to use the same server for the job database and target. Reran with dedicated server for each and of course it worked. Thanks for your input. At least I have some knowledge now of how to track real failures


Editor CSS content gets applied to Brackets

Hey guys, lets get to the issue right away,here are couple of screenshots of the problem

All that you see on the pictures above is done with html internal css styles
Here is an example:
<style> * { color: #F00 !important; }</style>
the code above would make all the text on the brackets red, without backticks it wont work, you have to surround the code with backticks

Have you tried launching Brackets without extensions (Debug > Reload without extensions)?

I close this since we didn't hear back from you.


IOS8 can't pick,will dial directly

IOS8 can't pick,will dial directly when click.

What is the workaround / solution for that? Is this project dead?

@geri777 take a look here:
https://github.com/pkjayk/com.kolwit.pickcontact/blob/master/src/ios/PickContact.m

the edit from @pkjayk fixed the problem


nimble/ll: Add more HCI commands for fake dual-mode

This allows NimBLE to be initialized as "dual-mode" controller by BlueZ.
Also inquiry "works" a bit better since Inquiry Complete event is
simulated after inquiry duration has elapsed.

Style check summary
No suggestions at this time!

With this PR Read Class of Device passes but later on something fails and interface is still not usable on bluez 5.5
< HCI Command: Set Event Filter (0x03|0x0005) plen 1                                                                                #907 [hci0] 72416.495216
        Type: Clear All Filters (0x00)
> HCI Event: Command Status (0x0f) plen 4                                                                                #908 [hci0] 72416.496167
      Set Event Filter (0x03|0x0005) ncmd 1
        Status: Unknown HCI Command (0x01)

Tested on Windows and Linux without problems


Make the root element and array item names configurable

Fixes #22.
Also allow choosing the root element name.

Coverage increased (+0.2%) to 91.822% when pulling 3d0e00c07e9da834ae87f5e265d518aa8fa2b345 on swisspush:naming-customization into a134c5599d3a5d5bf56c027ad461abc9fbc54c9f on ethlo:master.


Import function app api's to API Management with az commands

Describe the bug
I'm trying to import function app api's to API management with Azure cli commands. But I don't find specific commands which do this operation.
Related command
az apim api import
Errors
Command create new api instead importing from function app to API management.
Issue script & Debug output
No bebug
Expected behavior
It should import the function app API and its operations to API Management.
Environment Summary
azure-cli                         2.54.0 *
core                              2.54.0 *
telemetry                          1.1.0
Extensions:
front-door.                   1.0.17
Dependencies:
msal                            1.24.0b2
azure-mgmt-resource             23.1.0b2
Python location '/usr/local/Cellar/azure-cli/2.55.0/libexec/bin/python'
Extensions directory '/Users/username/.azure/cliextensions'
Python (Darwin) 3.11.6 (main, Oct  2 2023, 13:45:54) [Clang 15.0.0 (clang-15<IP_ADDRESS>)]
Additional context
No response

Thank you for opening this issue, we will look into it.


updates gist to 4.6.2

As per title
Things done

[ ] Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
Built on platform(s)

[ ] NixOS
[x] macOS
[ ] other Linux distributions

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[x] Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
[x] Tested execution of all binary files (usually in ./result/bin/)
[x] Fits CONTRIBUTING.md.

@GrahamcOfBorg build gist

Success on x86_64-darwin (full log)
Attempted: gist
Partial log (click to expand)
  Build root: /
  Bin dir: /nix/store/3xwnsxrgi32ib2x0kl6w8aig6wq4hwl8-gist-4.6.2/lib/ruby/gems/2.4.0/bin
  Gem home: /nix/store/3xwnsxrgi32ib2x0kl6w8aig6wq4hwl8-gist-4.6.2/lib/ruby/gems/2.4.0
Successfully installed gist-4.6.2
1 gem installed
post-installation fixup
patching script interpreter paths in /nix/store/3xwnsxrgi32ib2x0kl6w8aig6wq4hwl8-gist-4.6.2
/nix/store/3xwnsxrgi32ib2x0kl6w8aig6wq4hwl8-gist-4.6.2/lib/ruby/gems/2.4.0/gems/gist-4.6.2/bin/gist: interpreter directive changed from "/usr/bin/env ruby" to "/nix/store/x67rsi7x2hhj9jx7yji0w2jfxjrksjl3-ruby-2.4.3/bin/ruby"
/nix/store/3xwnsxrgi32ib2x0kl6w8aig6wq4hwl8-gist-4.6.2/lib/ruby/gems/2.4.0/gems/gist-4.6.2/build/gist: interpreter directive changed from "/usr/bin/env ruby" to "/nix/store/x67rsi7x2hhj9jx7yji0w2jfxjrksjl3-ruby-2.4.3/bin/ruby"
/nix/store/3xwnsxrgi32ib2x0kl6w8aig6wq4hwl8-gist-4.6.2

Success on x86_64-linux (full log)
Attempted: gist
Partial log (click to expand)
  Gem home: /nix/store/h20dian90dpw2yqd1w4rynxfczbgjadv-gist-4.6.2/lib/ruby/gems/2.4.0
Successfully installed gist-4.6.2
1 gem installed
post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/h20dian90dpw2yqd1w4rynxfczbgjadv-gist-4.6.2
patching script interpreter paths in /nix/store/h20dian90dpw2yqd1w4rynxfczbgjadv-gist-4.6.2
/nix/store/h20dian90dpw2yqd1w4rynxfczbgjadv-gist-4.6.2/lib/ruby/gems/2.4.0/gems/gist-4.6.2/bin/gist: interpreter directive changed from "/usr/bin/env ruby" to "/nix/store/dns77vf9frhd2s2xvcdd47rs2l08nqin-ruby-2.4.3/bin/ruby"
/nix/store/h20dian90dpw2yqd1w4rynxfczbgjadv-gist-4.6.2/lib/ruby/gems/2.4.0/gems/gist-4.6.2/build/gist: interpreter directive changed from "/usr/bin/env ruby" to "/nix/store/dns77vf9frhd2s2xvcdd47rs2l08nqin-ruby-2.4.3/bin/ruby"
checking for references to /tmp/nix-build-gist-4.6.2.drv-0 in /nix/store/h20dian90dpw2yqd1w4rynxfczbgjadv-gist-4.6.2...
/nix/store/h20dian90dpw2yqd1w4rynxfczbgjadv-gist-4.6.2

Success on aarch64-linux (full log)
Attempted: gist
Partial log (click to expand)
  Gem home: /nix/store/kf1c2lll6vpswk510zvps7pzw3m6yd4n-gist-4.6.2/lib/ruby/gems/2.4.0
Successfully installed gist-4.6.2
1 gem installed
post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/kf1c2lll6vpswk510zvps7pzw3m6yd4n-gist-4.6.2
patching script interpreter paths in /nix/store/kf1c2lll6vpswk510zvps7pzw3m6yd4n-gist-4.6.2
/nix/store/kf1c2lll6vpswk510zvps7pzw3m6yd4n-gist-4.6.2/lib/ruby/gems/2.4.0/gems/gist-4.6.2/build/gist: interpreter directive changed from "/usr/bin/env ruby" to "/nix/store/6hx1p4ci13bdg9ska62m1az888bz29sz-ruby-2.4.3/bin/ruby"
/nix/store/kf1c2lll6vpswk510zvps7pzw3m6yd4n-gist-4.6.2/lib/ruby/gems/2.4.0/gems/gist-4.6.2/bin/gist: interpreter directive changed from "/usr/bin/env ruby" to "/nix/store/6hx1p4ci13bdg9ska62m1az888bz29sz-ruby-2.4.3/bin/ruby"
checking for references to /build in /nix/store/kf1c2lll6vpswk510zvps7pzw3m6yd4n-gist-4.6.2...
/nix/store/kf1c2lll6vpswk510zvps7pzw3m6yd4n-gist-4.6.2


Typescript version update on 4.1.0-beta

Coverage remained the same at 98.623% when pulling 76ee41a4a19bc483812772d4ede745581225b229 on typescript-4.1.0 into b2297df287db00a1cac00781807af39b535055e0 on master.

Coverage remained the same at 98.623% when pulling 76ee41a4a19bc483812772d4ede745581225b229 on typescript-4.1.0 into b2297df287db00a1cac00781807af39b535055e0 on master.


Loosen uri validation for custom protocols launched from the app to match mattermost webapp

Problem:
Since mattermost desktop release 4.6, the desktop client applies valid URL validation to custom protocols when a user tries to launch a link with a custom protocol from the mattermost app. In the past, prior to this release, this action would simply launch any application registered with the OS to handle this custom protocol and let that application take it from there. In the versions 4.6+, because of this validation, in some cases, the protocol URI fails valid URL validation and gets blocked from launching the app. This only happens in the desktop client, the same custom protocol works correctly if the mattermost app is accessed directly from the browser without the desktop client. In our case this change broke our custom protocol integration with a history of a couple of years of messages using this format.
Example Problem Custom Protocol: taco:type=script;scriptname=somescriptname\parameter
Error Message Thrown: Untrusted popup window blocked:
Discussed this with @Willyfrog and @jupenur and we seem to be in agreement that the desktop client should not be more restrictive with URL/URI validation than the webapp running within the browser.
Code Preventing URI Launching
https://github.com/mattermost/desktop/blob/c281f6680947e584eaee8b229b427dc66b45eaa0/src/main.js#L533
Proposed Solution:
Remove URL validation currently being applied in the desktop client for any custom protocols, only apply this validation if the URI starts with http: or https:

added a ticket for reference, we'll discuss this in our sprint meeting. But tagging as help wanted as that might be the fastest way of getting it done ATM.
Thanks for bringing this to my attention :)

Hi @Willyfrog, @cpanato
I'd like to work on this issue. Could you please assign it to me?


More unit tests on spectrum

Codecov Report

Merging #10 into master will increase coverage by 15.3%.
The diff coverage is 50%.

@@            Coverage Diff            @@
##           master     #10      +/-   ##
=========================================
+ Coverage    83.3%   98.7%   +15.3%
=========================================
  Files           2       2
  Lines         156     155       -1
=========================================
+ Hits          130     153      +23
+ Misses         26       2      -24


'List' is deprecated and shouldn't be used

I know we can use <String>[] instead of using List<String>, but how to implement List<String>(length)?
As doc says:

Note that this guideline doesn’t apply to the named constructors for those classes. List.from(), Map.fromIterable(), and friends all have their uses. Likewise, if you’re passing a size to List() to create a non-growable one, then it makes sense to use that.

The problem with List<T>(length) is that it needs to contain length elements initially, and when the type T is non-nullable it can't be null. List<String>.filled(length, "") is the typical replacement, and it allows you to specify which element to use (and, if needed, growable: true).

@eernstg
Thanks for your response. I think I'm so confused these days about null and non-null :smile:
It's better that the doc covers new depreciation and suggests its replacement.

Thanks! I think everybody needs some time to get used to a lot of new properties, nothing wrong in that :smile:
The DartDoc comment in the bleeding edge list.dart has the following:
   * Creates a list of the given length.
   *
   * **NOTICE**: This constructor cannot be used in null-safe code.
   * Use [List.filled] to create a non-empty list.
   * This requires a fill value to initialize the list elements with.
   * To create an empty list, use `[]` for a growable list or
   * `List.empty` for a fixed length list (or where growability is determined
   * at run-time).

so it's a matter of getting that text through the pipeline, and then we will have the information where it should be.

List(1 * 192).reshape([1, 192]);  can be chaged as List.filled(1 * 192, null, growable: false).reshape([1, 192]);


geospatial data storage format

The process starts with generating a collection of geographic points and then adds additional attributes such as the filename of  associated image(s) and GVI score(s). Is shapefile the best format to use for manipulating and storing our data?

Shapefiles have a variety of geometry, attribute, and geoprocessing limitations.
Each point is just a latitude and longitude and several additional properties so a CSV text file may suffice?
Geopackage was designed as a compact solution that overcomes the limitations of formats like shapefile and geojson. See: https://mapscaping.com/reading-and-writing-geopackage-in-python/

However, I also wonder if any problems with the geospatial file format will occur well after other issues (for example, saving an image for each point to disk)?

The way that create_points.py is currently implemented, it works with any of the standard vector formats like Shapefiles, GeoJSON, or Geopackage on both the input side and the output side (they can be the same or they can be different). We use geopandas to read and write the files, and geopandas supports these all equivalently.
I think we should continue to write our code that way (e.g., the step that reads in the points to download images should also use geopandas and accept any of vector data formats) as this flexibility has no real cost to us and seems nice to have.
Perhaps a different question we want to answer is: Should this project adopt a particular vector data format as a convention? That means that we would standardize on using a particular format on files we control, even if the implementation would work with other formats. I think this seems reasonable. I don't do enough GIS data work to have a strong opinion on this. Geopackage is as good as any.

Regarding if we should just save the points as CSV files—my inclination here is to keep these in a vector data format. This simplifies use cases like plotting the locations, or opening up the files in a desktop app like QGIS.

Oh yeah, for the initial input, if it's flexible in the format that's great. For the output file that is passed between steps, I think GeoPackage might be the better choice. QGIS can open a CSV of points the same as any other file format, but I think there may be performance benefits from the GeoPackage with large collections of points.


API category left nav not extending all the way down the page

Categories should extend to the bottom of the page so the border line doesn't go away when you scroll past the initial viewport.
Additionally the left nav should show all items in the list if the content body is longer than the nav, right now it cuts off additional items and there is no indication that you can scroll that area.
In the example above there are a number of items beyond "punycode"

This is fixed


Box folders

Resolves #185

Might want to check if viewing a file still works as well, not sure if that's just something on my side (viewing both in modal as well as going to the page itself since now the files are in folders)


test(rest): fix missing import

Codecov Report

Merging #2734 (17f5589) into node-migration-clean (17df478) will increase coverage by 41.10%.
The diff coverage is n/a.

@@                    Coverage Diff                    @@
##           node-migration-clean    #2734       +/-   ##
=========================================================
+ Coverage                 21.54%   62.64%   +41.10%
=========================================================
  Files                        72       22       -50
  Lines                     22745     5542    -17203
  Branches                     55      221      +166
=========================================================
- Hits                       4901     3472     -1429
+ Misses                    17842     2067    -15775
- Partials                      2        3        +1

Flag
Coverage Δ

*Carryforward flag

client-unit
?

discordeno-unit
0.00% <ø> (ø)

gateway-unit
0.00% <ø> (ø)

rest-e2e
85.60% <ø> (?)

Carriedforward from 6cfb380

rest-unit
?

utils-unit
52.47% <ø> (ø)

*This pull request uses carry forward flags. Click here to find out more.

Impacted Files
Coverage Δ

packages/rest/src/index.ts
0.00% <0.00%> (-100.00%)
:arrow_down:

packages/client/src/Structures/guilds/Member.ts

packages/client/src/Structures/channels/Text.ts

...ages/client/src/Structures/interactions/Command.ts

packages/client/src/Structures/channels/News.ts

packages/client/src/utils/BrowserWebSocket.ts

packages/client/src/Client.ts

packages/client/src/Structures/toggles/Voice.ts

...ages/client/src/Structures/interactions/Unknown.ts

packages/client/src/Structures/channels/Private.ts

... and 44 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.


README: fix section of HTTP header vars in example config

Tiny change, but it might save the next person a lot of time debugging the reverse proxy setup.

Coverage remained the same at 93.429% when pulling 1a6bd2b7c582c64be7bf0fee3c4f58e1c9fd8f02 on julienschmidt:master into db2a6bc2880666cdde9d1f0cc53e3629fe73bf2d on joohoi:master.

Tiny change, but it might save the next person a lot of time debugging the reverse proxy setup.

Oh, reading from between the lines; sorry for the inconvenience. And thanks for making it more clear for the next person in form of a PR! This also brings the README on par with the actual config.cfg.


Sovereign cloud examples are non-functional

The sovereign cloud examples (here: https://docs.microsoft.com/en-us/azure/developer/python/azure-sdk-sovereign-domain?view=azure-python) are not functional with the current versions of the azure libraries.
The examples given all fail with a missing get_token attribute:
AttributeError: 'UserPassCredentials' object has no attribute 'get_token'

https://github.com/Azure/azure-sdk-for-python/issues/12947 pointed out the existence of the credential_scopes argument, which led to a functional script using azure.identity.DefaultAzureCredential:
from azure.mgmt.resource import SubscriptionClient
from azure.identity import DefaultAzureCredential

credential = DefaultAzureCredential()

subscription_client = SubscriptionClient(credential, base_url='https://management.usgovcloudapi.net/', credential_scopes=['https://management.usgovcloudapi.net/.default'])

subscription = next(subscription_client.subscriptions.list())
print(subscription.subscription_id)

The credential_scopes argument doesn't appear to be in the docs anywhere, but seems to be required.
Packages in the venv I tested with:
Package                  Version
------------------------ ---------
adal                     1.2.5
azure-common             1.1.26
azure-core               1.9.0
azure-identity           1.5.0
azure-mgmt-authorization 0.61.0
azure-mgmt-core          1.2.2
azure-mgmt-nspkg         3.0.2
azure-mgmt-resource      15.0.0
azure-nspkg              3.0.2
certifi                  2020.11.8
cffi                     1.14.3
chardet                  3.0.4
cryptography             3.2.1
enum34                   1.1.10
idna                     2.10
ipaddress                1.0.23
isodate                  0.6.0
msal                     1.6.0
msal-extensions          0.3.0
msrest                   0.6.19
msrestazure              0.6.4
oauthlib                 3.1.0
pathlib2                 2.3.5
pip                      20.2.4
portalocker              1.7.1
pycparser                2.20
PyJWT                    1.7.1
python-dateutil          2.8.1
requests                 2.25.0
requests-oauthlib        1.3.0
scandir                  1.10.0
setuptools               44.1.1
six                      1.15.0
typing                   <IP_ADDRESS>
urllib3                  1.26.2
wheel                    0.35.1

Hi @dmurnane, you're correct about both the problem and the solution. That document needs to be updated because it assumes a version of azure-mgmt-resource (<= 10.x) that expects a credential type from msrestazure, whereas the newest version (15.x) expects a credential type from azure-identity.
@jongio @kraigb, is this sovereign cloud documentation tracked for an update?

Yes, I'm in the process of making updates for newer management libraries. Thanks.

Sorry for the late reply, but I updated the article a week or so ago and it's now current.
#close


contrast algorithm: APCA

Long term, APCA should probably replace WCAG2 contrast calculation entirely. But with WCAG3 still being a draft (and WCAG2 being enshrined in law in many places), it might be more practical to provide them both for a time.

This is a great idea. It does look like there’s some optional font size/weight components to APCA like WCAG3 has, which I’m torn on because while it is absolutely the right approach, measuring accurate font rendering is beyond the means of what CSS/JS can do (referring to actual pixel rendering that differ across browser + OS beyond mere font properties). I’d love to add APCA support (as well as WCAG3) support if the utility without font properties would be of use. The color contrast algorithm is a vast improvement over WCAG2.

FWIW, Myndex appears to have an implementation that brings font size into the mix, but I haven't taken the time to examine the source code (or its methodology) closely. But even if it's a (scientifically-informed) "best guess", I think getting people within spitting distance of the standard (while making them aware of significant caveats, to avoid a footgun situation) has utility.
Otherwise -- I think a sparse color contrast function would be useful as a dependency for a more complete solution... but I'm also biased, as it would take care of the use cases I have it in mind for :wink:
Whatever approach is taken, I think it'd be good for any documentation to make it clear that "hey, you need to take other factors into account too, so here's a WCAG link for more details". Preferably with a TSDoc annotation, as that makes it more discoverable when dealing with it in an IDE.

I looked into this a bit more, and there is the apca-w3 package which is on npm. But the license seems to only extend to the W3C, and it doesn’t seem like the code available is able to be used by anyone? So I think the only way to use this legally is via the website you linked (and not even through npm—that seems to only be for the purposes of the W3C).
It seems like APCA is an attempt to get passed as a standard, at which point I assume it will be permissible for public use. Until then, looks like it’s not implementable :/

That said, I’ll take a look at where the WCAG 3 contrast guidelines are, and see if there’s some useful tool that can implement some or all of that standard. I imagine that will see more and more traction over the coming years.

@drwpow hmm. https://github.com/Myndex/SAPC-APCA/discussions/51 includes a list of 3rd party tools that implement the algorithm. since that's a post by the maintainer, i'd take to mean that 3rd party tools are kosher, or at least permissable on a case-by-case basis.
might be worth opening a discussion thread on that repo, or see if someone else has asked a similar question about licensing. my gut feeling here is that it's just a case of a developer being overly cautious with their license text; a WCAG proposal seems like it'd get more traction if people are widely using/testing the implementation, and forbidding other people from using it would get in the way of that. :)

Licensing in OSS has to be pretty cut-and-dry “free for use and reuse” because every OSS package is only as permissible as its strictest license. As someone that’s worked in security-focused companies that do auditing, licensing does matter for literally every line of code used. A great story on this is You May Finally Use JSHint for Evil, a tale of how ambiguous licensing can come back to bite you, even if it’s well-intentioned and permitted in a case-by-case basis.

my gut feeling here is that it's just a case of a developer being overly cautious with their license text … and forbidding other people from using it would get in the way of that.

Yeah I’d agree with that, too. I’m a huge fan of his work, and he has given so many things that do have open licensing, and I hope this does become a standard so we all get a better web! But again, for this project, for now, I’d only include code and algorithms that have clear licensing so it doesn’t impede others from using this library however they want to.


[Proposal] Rename displayed name from 'vscode-icons' to 'VSCode Icons'

displayName is the display name for the extension used in the Marketplace, see https://code.visualstudio.com/docs/extensionAPI/extension-manifest#_fields and https://code.visualstudio.com/docs/extensionAPI/extension-manifest#_example. So I think to use VSCode icons should be used to instead of vscode-icons in displayName. For me, vscode-icons is only an extensions name.  I can see you use VSCode Icons to Preferences: File Icon Theme:

BTW, other File Icon Themes often don't use name  for displayName.

In addition, I favor removing preview tag,  VSCode Icons is good enough to use.
Move over from: https://github.com/vscode-icons/vscode-icons/pull/1231#discussion_r143550280
cc @robertohuertasm @JimiC @jens1o

Personally, I disagree with it. Tradition and wonderful feelings connected with this name 😍

So why doesn't vscode-icons use to Preferences: File Icon Theme?

Because @robertohuertasm was the first to add file/folder icons in vscode before this even was a thing. And this is how he wanted to name it.
  I fight with it too.

Closing as stale. If you believe that it should not be close then please re-open the issue.

 I fight with it too.

I kinda have O.C.D. too but sometimes it's a valid thing :) take look at this:

all of them follow a naming convention and it's good to keep things clean, and definitely, it feels clean and in sync with others, maybe people are aware of it unconsciously too.


Re-add missing fields to ChatMessage

https://github.com/tjardoo/openai-client/pull/83/commits/9461345efab8e2d637543261a39c155e6eedc259#diff-3b618cea395f2f12f2bc747dc0a4fad7b1ab702a9cea5e917c37e082044ed3ec removed the tool_call_id and name ChatMessage fields, which are used for responding for tool calls and disambiguating between multiple users respectively.
This PR restores them and revises the doc comments for consistency with the other fields.
p.s. It might be a good idea to convert this to an enum to capture the different types of message types and make it harder to produce invalid states:
#[derive(Serialize, Deserialize, Debug)]
#[serde(tag = "role", rename_all = "lowercase")]
pub enum Message {
    System {
        /// The contents of the system message.
        content: ChatMessageContent,
        /// An optional name for the participant. Provides the model information to differentiate between participants of the same role.
        name: Option<String>,
    },
    User {
        /// The contents of the user message.
        content: ChatMessageContent,
        /// An optional name for the participant. Provides the model information to differentiate between participants of the same role.
        name: Option<String>,
    },
    Assistant {
        /// The contents of the assistant message. Required unless tool_calls is specified.
        content: Option<ChatMessageContent>,
        /// The refusal message by the assistant.
        refusal: Option<String>,
        /// An optional name for the participant. Provides the model information to differentiate between participants of the same role.
        name: Option<String>,
        /// The tool calls generated by the model, such as function calls.
        tool_calls: Option<Vec<ToolCall>>,
    },
    Tool {
        /// The contents of the tool message.
        content: String,
        /// Tool call that this message is responding to.
        tool_call_id: String,
    },
    Function {
        /// The contents of the function message.
        content: Option<String>,
        /// The name of the function to call.
        name: String,
    },
}

Thanks! I like that idea - will update it.


fix(DDI-1108): Update aria-label property for all inputs

Added examples of ariaLabel property used for all inputs in React demo
Added ariaLabel property for checkbox and radio components
Updated documentation for checkbox and radio components to include new property
Updated react components for all inputs to include ariaLabel property

:tada: This PR is included in version 4.0.0-alpha.93 :tada:
The release is available on:

npm package (@alpha dist-tag)
GitHub release

Your semantic-release bot :package::rocket:

:tada: This PR is included in version 1.0.0-alpha.133 :tada:
The release is available on:

npm package (@alpha dist-tag)
GitHub release

Your semantic-release bot :package::rocket:

:tada: This PR is included in version 1.0.0-alpha.19 :tada:
The release is available on:

npm package (@alpha dist-tag)
GitHub release

Your semantic-release bot :package::rocket:

:tada: This PR is included in version 4.3.0 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:

:tada: This PR is included in version 1.3.0 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:

:tada: This PR is included in version 1.2.0 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:

:tada: This PR is included in version 2.0.0-alpha.11 :tada:
The release is available on:

npm package (@alpha dist-tag)
GitHub release

Your semantic-release bot :package::rocket:

:tada: This PR is included in version 2.0.1 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


darts-global-linear-regression

Hi,
Model looks good to go, but as the first global example It would be nice to publish the training script as well.
If you can, please also update the Dockerfile and requirements.txt files based on the latest one from dt-linear-regression.


Tray module causes: Invalid id passed to g_bus_unwatch_name()

When Waybar exit in the log I see:

(waybar:25493): GLib-GIO-WARNING **: 22:57:40.825: Invalid id 2 passed to g_bus_unwatch_name()
Investigation shows: Tray module constructor calls :

watcher constructor
host constructor
In the same time both base classes(watcher and host) keeps information about cross resources. Watcher instance has got information about host and watcher either. The same for host class..
So when time to destruct instances, both watcher and host are trying to destroy cross resources. In such case : watcher may kill host resource earlier then host destruction is called and vise versa for host class.
This PR splits resource destruction between base classes. Host now destruct only host objects, watcher - watchers objects.

Actually I didn't find any other dependencies where these base classes are used separately without each other.

Thanks @LukashonakV you rock!


Match prefix at only the start of the string.

Hello @jacksegal!
Thanks for this script, it is great.
I found a small bug, where snapshots are being deleted that are not supposed to be:
I set the prefix to backup and have a few snapshots that have backup in the name (test-backup-snapshot) that were not created with this script. When I ran the script, it deleted the snapshots that were not prefixed with backup. This PR prevents deleting snapshots that have the prefix name in them.
Log from run where snapshot was deleted:
[2019-03-01 15:50:49]: Handling Snapshots for my-awesome-instance
Deleted [https://www.googleapis.com/compute/v1/projects/<PROJECT>/global/snapshots/test-backup-snapshotl].
Creating snapshot(s) backup-foo-bar...

Good spot @smstone - thanks!
Can you pull down the latest code and re-submit?   I merged an older PR into master this morning.

@jacksegal I rebased on master so should be good to go. Thanks!

Thanks!


Connected workspaces rewrites & updates for Beta release

Documentation for connected workspaces beta release):

https://github.com/mattermost/mattermost/pull/28920
https://github.com/mattermost/mattermost/pull/28116
https://github.com/mattermost/mattermost/pull/27820
https://github.com/mattermost/mattermost/pull/28131
https://github.com/mattermost/mattermost/pull/28130
https://github.com/mattermost/mattermost/pull/28020
https://github.com/mattermost/mattermost/pull/28154

@mgdelacroix - Please confirm whether the remote clusters configuration setting should remain documented as-is via Experimental, or if it needs changes for connected workspaces.

Please confirm whether the remote clusters configuration setting should remain documented as-is via Experimental, or if it needs changes for connected workspaces.

We're maintaining those configuration parameters marked as deprecated, and they will have no effect beyond the initial automated migration to ConnectedWorkspaces the first time v10.2 runs, so I think we should mark them as deprecated in the experimental section and point to the new ones.

Also, please confirm whether any of the connected workspace configuration settings should be added to the Telemetry page.

Yes, all ConnectedWorkspaces properties have been added to the telemetry payload with the following format:
{
  "config_connected_workspaces": {
    "enable_shared_channels": val,
    "enable_remote_cluster_service": val,
    "disable_shared_channels_status_sync": val,
    "max_posts_per_sync": val,
  }
}


last fix neg_ray ...

now its cause move through diagonal on start
bool neg_ray=false;
  if (current_voxel[0]!=last_voxel[0] && ray[0]<0) { diff[0]--; neg_ray=true; }
  if (current_voxel[1]!=last_voxel[1] && ray[1]<0) { diff[1]--; neg_ray=true; }
  if (current_voxel[2]!=last_voxel[2] && ray[2]<0) { diff[2]--; neg_ray=true; }
  visited_voxels.push_back(current_voxel);
  if (neg_ray) {
    current_voxel+=diff;
    visited_voxels.push_back(current_voxel);
  }

so if 2 negrays
for example first 0,0,0
second -1, -1, 0
Why need this first move by neg_ray?

Think of this in 2D and picture a point in the center of a cell. The computation before this code finds the origin of the next cell, both X and Y. But you're really trying to figure out where you're first crossing both the X and Y axes and this isn't always up and to the right.  If your vector goes up and to the left, you're first going to cross the vertical grid line at the Y coordinate of the CURRENT cell's origin, not that of next cell.  The same goes for the other X and Z directions.  So you have to subtract 1 to get back to the current cell's index in cases where you're moving in a "negative" direction.


Don't put tournament (etc.) questions in the Community project

Problem: in order for public tournament questions to count in the yearly leaderboards, they are automatically added to the Community project. This makes the "don't show in main feed" option non-functional.
Solution:

Questions created in other projects don't get automatically added to the Community project.
The main feed has all questions that are in at least one project that has "show in main feed".
The yearly leaderboards have all questions that are in at least one project that has "show in main feed" (I'm understanding that this is possible by makind the leaderboard→project relationship one-to-many).

Just chatted with @hlbmtc. It looks like clicking "hide in main feed" on the tournament page removes the questions from the Community site_main project. This provides 90% of the functionality above. This only works when the tournament is the question's main project. I think this solves this problem.
I still find "using the Community site_main project" to decide if a question is in the main feed to be extremely confusing, but I can't deny that it works. I'm closing this for now.


SelectExpression Cache:  Memory leak when using method as Func in select statement

Using method as Func<TSource, TResult> in the following select statement:
dbContext
.DbSet<TSource>
.Where<TSource>(x => ...)
.Select<TSource, TResult>(x => method(x))
.ToListAsync()

lead to memory growing and possible memory leak problem. The root issue is selecting and mapping result set to another result set using method as func before calling ToList/ToListAsync https://github.com/artsiomLikhachou/bugs/blob/master/TestEfMemoryAsp/TestEfMemory/src/TestEfMemory/ProductService.cs#L24-L25 . Making 1000 requests lead to memory increasing from 150MB to 550MB

so that the memory is not deallocated. Analyzing of memory dump pointed me the idea that Select Func was added to MemoryCache which keeps invoker instance (TestEfMemory.ProductService) as well as all its dependencies (TestEfMemory.TestDbContext):

In such a way because of MemoryCache instances of services and db context are not exempted, cached db context becomes growing and it leads to memory leak.
If we call ToList/ToListAsync before select and do objects mapping after - there is no memory leak issue.
Is it a bug? I am very curious because so simple code may lead to such unpredictable memory usage and we've faced to this issue in Production.
Steps to reproduce
You can find example on https://github.com/artsiomLikhachou/bugs/tree/master/TestEfMemoryAsp/TestEfMemory. There is a "Send" button on home page which run N (from "Number of requests to send" input) ajax requests to the endpoint with memory leak.
Further technical details
EF Core version: 1.1.0
Database Provider: Microsoft.EntityFrameworkCore.SqlServer
Operating system: Windows 10
IDE: Visual Studio 2015

Any news, suggestions or plans, guys?

@artsiomLikhachou Looking at this now. You should be able to workaround the issue by making the method static.

@artsiomLikhachou This issue should be fixed in 2.0.0-preview1, can you confirm?

Closing as we haven't heard back and think this is fixed.

@anpete  This is either not fixed or recurring in 2.1.

You should be able to workaround the issue by making the method static.

I think this works if the method is static, however, if the method is not static the impact is dramatic.
So far it seems to be one of the main contributors to the memory problem we have after the upgrade (https://github.com/dotnet/coreclr/issues/18577). I'm not sure yet whether it is the only one. We still have some closure objects related to Ef that are not observed in 1.1. and I'm not sure what causes them.
If this is the expected behavior it should be in the documentation or forbidden altogether.

@ydekova Can you please open a new issue with a runnable project/solution or complete code listing that demonstrates the behavior you are seeing so that we can fully investigate.


Console.log written to console twice

Reproduction repository here: https://github.com/fraser-lowndes/karma-double-console-log. Pull and use ng t --sr to see the isuse.
Any calls to console.log will be printed twice when using karma-mocha-reporter as the sole reporter in karma.conf. E.g. console.log('my log') is output to the console as
LOG: 'my log'
LOG: 'my log'

I only see one message.

Seems like someone else had the issue and fixed it in the @angular/cli
https://github.com/angular/angular-cli/issues/9528

Excellent, I'll close this. Thanks for the help.


UI Refactoring Goals

Goals
Refactor the styling in the UI to be more common and add the concept of Themes to set variables
Refactor the common Components to be more reusable and less coupled to the current design
Use containers more than we currently do, but with an eye toward isolating elements to be easily moveable to other areas.
General improvements to load times and determine the minimum required data for a component, which can be used to improve getters
Create a Visual Guide page to show all the various common elements and allow theme switching on one page.
These should provide 5 wins:

easier reskinning - a/b testing of new designs
isolation of components to allow for easier exporting of augur widgets (embedded order form for example)
easier development through use of a lego-like component library to be able to quickly build out new features or construct new pages
increase the speed of loading data by auditing the minimum required data for components and finding efficency improvements
Visual Guide is a great way for devs to easily look through all the components rendered out to make sure they are using the right components to achieve the visual look we are driving toward.

Overall the goal is to decouple as much of the UI as possible from the current design pattern, while also DRYing up the styling and repeatedly used elements in a way that makes composing new designs as simple as placing some components into a react file and having it "magically" work the first time with very little additional edits required, ideally none. Need a Order Form on the account page for some reason? just import <OrderForm> and feed it a marketId. Need to change the entire style of the UI to use Yellow, Blue, and Red as the main color scheme? simply create a theme file and change the theme passed to the top level App.jsx component.
Ultimately we should create a foundation for future development that is easier to reason about, provides a faster velocity of development, decreases the time it takes to onboard new employees, helps open source developers contribute smoothly, and allows for easier A/B testing around a top level Theme defined in one file for easy manipulation and edits that naturally flow through to the entire App in a coherent way.
Refactoring Styles
Themes will allow us to set a top level theme to the app, something like default-ui or betting-ui or reporting-ui.
These top level themes would allow us to change all the colors/text on the entire site based on the theme. The idea is to standardize the color variables for example, so instead of color-purple we would instead use something like color-primary. If we wanted to use another color besides purple for our primary theme color, it would be as simple as changing the variable under the theme from purple to yellow for example. Instead of needing to go to each component and dictating in the UI that if it's default-ui theme we use color-purple but for betting-ui we use color-yellow instead we simply change the top level color-primary to yellow if we are in betting-ui or purple if default-ui. This change would then flow down to the rest of the design and all the primary colored objects would now be yellow or purple.
Benefits:

Easier creation of multiple styles/themes for the entire app without needing to think about where each new color goes
Easier A/B testing of new themes using the development or even live version of the app
Faster creation of new specialized UI such as the betting or market marker ui's we have planned

Refactoring Common Components
There are common elements in this UI that are used on multiple pages. Some of these common things are already standardizing like the icons for example. I would like to take this approach with basically everything that's used more than one time. A simple example in the new design is the market state labels. They all look the same on multiple pages and generally say things like Open, In Reporting, Closed with a colored line underneth the text, green, yellow, and red respectively. Instead of defining these in each component used and adding the CSS specfically for that one component, it would be better to standardize it so that we could have a <MarketStatus marketId={marketId}> that would automatically color/label the market state and wouldn't require any extra css work in that particular component.
Benefits:

Faster composition of new pages/features/elements in terms of actual development time
Easier to reuse or modify existing component layout easier since everything is decoupled from their original location
Easier onboarding of new employees or open source developers given the readable/lego style component composition

Increased Use of Containers
Currently we use container elements as top level type components, such as Market-View for the trading page. If we increased the granularity of these containers to instead have containers for things like OrderForm, Depth Chart, Candlestick Chart, OrderBook, etc we would be able to decouple these components in a way that allows for easier composition of new pages or mixing and matching of elements we currently can't do easily. An example of our current issues around this is the Order Form. We have two places that the Order Form is currently shown: The Trading Page and Market Creation Liquidity section. Unfortunatly they are currently two completely different components that are both styled seperately and it's not very DRY. If we instead used a container at the Order Form level, instead of market-view (trading page) or create-market we could then re-use the same order form component since the container would ensure that the proper state/actions are available to the Order Form instead of relying on them to be passed in from the top level market-view or create-market components.
This would allow us to throw the Order Form into the portfolio positions page for example, giving users a quick way to place a trade without having to click through to the trading page. Further, we could then export the Order Form as a widget to be used by third parties in a much simplier package that would simply require some data from the Augur-Node, things like Market Id, min/max price, etc.
Benefits:

Easier re-use/composition of components of the augur ui
Easier to export individual actionable components out to third party sites as embedded components
Faster development with less concerns about passing the needed functions to OrderForm

General Data Improvements
Currently we tend to pull in large amounts of data without needing to actually display all that information in the UI at that time. During this refactor we should look for areas to improve the data fetching and lazy loading of information that needs to be displayed in the UI. This process should allow us to not only decrease load times but also optimizing the data retured to be only what is needed in an effort to reduce over fetching.
Benefits:

faster load times
more efficient API

Visual Guide
The Visual Guide will be made after the previously discussed changes are made, the idea being a central location to be able to visually see all the various permutations of the components rendered out on one page in a searchable maner. We would also allow the changing of themes to see what colors change and how it will look. Justin provided an example link of something similar to what this Visual Guide might look like Example Visual Guide.
Benefits:

Easier recognition of what element is appropriate to match the mock we are trying to build
Easier on boarding of new employees who would be able to visually confirm what they need to import/add to their component
Easier for open source contributors to be able to build new components for us without having to get into the details

Opening this up for public discussion/contributions before we get to work. I'll keep editing this top level post with new ideas/corrections or expand it if we need more details. For now this is just a general overarching view of things we would like to change and the benefits we expect to get out of these changes.

I'm a huge fan of these changes.

Components shouldn't have any impl specific 'nouns' in them. e.g. outcomes, markets, etc.
Should we look into generating the stylesheet in javascript? Something like: https://github.com/OfficeDev/office-ui-fabric-react/tree/master/packages/merge-styles
We are currently using redux in a pretty naive manner. We can leverage composition to reuse logic. This might lead to some "pocket talks" to explain some of these patterns and why we need them.

@JohnDanz -- I think we're good to close this & reference it on other issues as we need to.
Can you make tasks for the next steps and close this when you're back?


Adds/partner params

For Surfline, JIRA ticket here

Can you break this into 2 PRs?

Updating Adjust Library.
Updating the integration code to handle the bug indicated in the ticket.


Support some convince types

I'm exactly sure what these are called, but it would be useful to have:
PositiveFloatQuantity
NegitiveFloatQuantity
OptionalFloatQuantity

It would be nice to use OptionalFloatQuantity to denote a field that is optional (as of now, I wasn't able to hack together something that would work). Something like PositiveFloatQuantity would be useful when defining a model where only positive values makes sense (like pydantic has with PositiveFloat).

I realize now that this might intersect with an idea @Yoshanuikabundi had in which you might be able to get some of this behavior by setting the type that unit.Quantity wraps, i.e. putting a conint in there?
https://github.com/openforcefield/openff-units/pull/41

The lazy solution doesn't seem to work (now):
from openff.models.models import DefaultModel
from openff.units import Quantity
from pydantic import conint

class Model(DefaultModel):
    x: Quantity[conint(gt=0)]

print(Model(x = unit.Quantity(1, unit.nanometer)).json())
# {"x": "{\"val\": 1, \"unit\": \"nanometer\"}"}

print(Model(x = unit.Quantity(-1.5, unit.nanometer)).json())
# {"x": "{\"val\": -1.5, \"unit\": \"nanometer\"}"}

The second one should fail validation (for two reasons) but some information is being lost in how conint is being wrapped, or something


refactor(ci): reorganize CI related code

Break-down the CI related code into smaller more maintainable pieces.

Hi @mrekucci, thanks you for the PR. However, we are moving for Azure Pipelines and as such this PR is not relevant anymore. I'll keep it open until I add Azure Pipelines.

Closing for #212.


Session cookie race condition with multiple shops

Issue summary
In our standalone Remix app (not embedded), we use await authenticate.admin(request) to create a session (offline). This sets a cookie and the user's session has the auth token for the shop they accessed our app from.
However, if the same user accesses our app from another shop, the cookie retrieves a session for the previous shop -- thereby referencing the wrong session information and access token. The cookie also still states cookies: 'shopify_app_session=offline_previous-shop.myshopify.com;.
This same thing happens with online sessions. The authenticate.admin function doesn't ensure that the shop querystring parameter is used for session storage and retrieval, to handle the same user accessing the same app from multiple shops.
Is there a way to prevent a cookie from being set, to make these requests stateless?

<EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS>Node version: v18.18.0
Operating system: macOS 13.4.1 (Ventura)

15:29:09 │ remix    │ LOADER (ROOT) http://app.test/?hmac=4b1e0c2f88131f91000f87f592a2f22475000cd073ed3d8712d4478b880722b6&host=YWRtaW4oo2hvcGlmeS5jb20oo3RvcmUvb2R4LWxvY2FsLWVhdHM&shop=second-store.myshopify.com&timestamp=123456789 {
15:29:09 │ remix    │   cookies: 'shopify_app_session=offline_previous-store.myshopify.com; shopify_app_session.sig=jFJzqzEB9g/WxxVarL///iFQaOpbtdj6n2pMS8t1iFk='
15:29:09 │ remix    │ }
15:29:09 │ remix    │ LOADER (_index) http://app.test/?hmac=4b1e0c2f88131f91000f87f592a2f22475000cd073ed3d8712d4478b880722b6&host=YWRtaW4oo2hvcGlmeS5jb20oo3RvcmUvb2R4LWxvY2FsLWVhdHM&shop=second-store.myshopify.com&timestamp=123456789
15:29:09 │ remix    │ [shopify-app/INFO] Authenticating admin request
15:29:09 │ remix    │ SESSION Session {
15:29:09 │ remix    │   isOnline: false,
15:29:09 │ remix    │   shop: 'previous-store.myshopify.com',
15:29:09 │ remix    │   scope: 'read_all_orders,read_inventory,read_price_rules,read_product_listings,write_customers,write_draft_orders,write_files,write_fulfillments,write_merchant_managed_fulfillment_orders,write_order_edits,write_orders,write_products,write_script_tags,write_shipping,write_themes,write_third_party_fulfillment_orders',
15:29:09 │ remix    │   id: 'offline_previous-store.myshopify.com',
15:29:09 │ remix    │   state: 'XXXXXXXXXX',
15:29:09 │ remix    │   accessToken: 'shpca_XXXXXXXXXXXX',
15:29:09 │ remix    │   expires: undefined
15:29:09 │ remix    │ }

Expected behavior

Users should be able to access the same app from different shops
authenticate.admin should retrieve session data based on the shop the request originated from (e.g. respect the shop querystring parameter)

Actual behavior

Users accessing the app from multiple shops resumes the initial session and ignores that links have hmac and shop parameters indicating they are accessing from a different shop

Steps to reproduce the problem

Create Remix app from template
Call const { session } = await authenticate.admin(request) to initiate a session when accessing the app homepage
Log or output the session object to see what shop it holds information for
Install the app on Shop 1 and see that session has Shop 1 data
Install the app on Shop 2 and see that session still has Shop 1 data

We are able to work around this in some cases by calling await login(request) if the shop querystring parameter is not the same as the session.shop. However, this seems like the behavior that likely ought to be built-in.

hi @paulomarg, thanks for weighing in. Can you confirm that -- in effect -- you're saying this package assumes users only belong to one shop and won't login to the same app from different shops?

Yes, right now that is a limitation of this package, but it only affects non-embedded apps. For embedded apps, because we never store a cookie and use session tokens provided by the admin interface, this would not be an issue.
So just to set expectations here, we are going to look into ways of improving the behaviour, but there are other things that will take priority over it!


Missing docs for function Scroll

Seen in source code there's a function Scroll(x, y int, args ...int) next to ScrollMouse(x int, y string). But the document for this function is missing. Please help to update the documentation.

Priority to reference the godoc. If there have time, I will to update the docs directory. And welcome contribution document.

Quick Reply?: I think this issue can be closed. The problem is solved.

Yes, thanks


Re: Profile comments only visible for sender and recipient

I personally fully agree with #668. But I  want some pro/cons regarding the idea as such and also the suggested coding.
Anyone that can comment this?
Regards
Hakan

I haven't seen that one before, somehow, I was too busy...
In my opinion, private comments would be the same as private messages then...
A good alternative would be to allow only profile friends to see and reply to comments... (if the 'friend' module is enabled. Otherwise, it would be the same behaviour as now...).
What do you think @digiloo
Thanks for sharing your thoughts anyway @digiloo & @dimuller! I really appreciate it 🤗

I have redesigned this so comments are openly displayed on profiles and the owner of the profile can hide selected comments! Currently the profile owner can edit a comment left by someone else as standard.

I made another version, where the public can see only the comment, without avatar and comment details.
Sender & recipient can see the avatar and the comment details, and both can delete the comment.
Only the sender can edit the comment.
Only the recipient can like the sender of the comment.


Half Screen

I can'y see bottom side.
http://prntscr.com/dqkekb

Move app window up.. or turn "Compact mode" in settings.

Enable compact mode as @bsun0000 mentioned


Hide password input

Codecov Report

Merging #14 into master will increase coverage by 0.55%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master      #14      +/-   ##
==========================================
+ Coverage   62.23%   62.79%   +0.55%
==========================================
  Files         124      124
  Lines        4409     4370      -39
  Branches      102      100       -2
==========================================
  Hits         2744     2744
+ Misses       1665     1626      -39

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 405c8c6...8b37885. Read the comment docs.

Saw another PR #15 that fixes this, so I figured I'd go ahead and close mine.


buckaroo creditcard gateway currently only supports visa

Right now credit card provider 'visa' is hardcoded.
https://github.com/thephpleague/omnipay-buckaroo/blob/master/src/Message/CreditCardPurchaseRequest.php#L13
buckaroo also supports Mastercard, and American express.
i made a PR which adds support for mastercard and american express
https://github.com/thephpleague/omnipay-buckaroo/pull/15

Merged.


New Thread Pool

After PR: #24
This is the refactor of PR: https://github.com/eProsima/DDS-Router/pull/304

Codecov Report
Base: 69.90% // Head: 69.88% // Decreases project coverage by -0.02% :warning:

Coverage data is based on head (f447332) compared to base (e913acb).
Patch coverage: 63.46% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #25      +/-   ##
==========================================
- Coverage   69.90%   69.88%   -0.03%
==========================================
  Files          44       59      +15
  Lines         771      870      +99
  Branches      182      224      +42
==========================================
+ Hits          539      608      +69
+ Misses        135      130       -5
- Partials       97      132      +35

Impacted Files
Coverage Δ

...ils/include/cpp_utils/wait/ConsumerWaitHandler.hpp
0.00% <ø> (ø)

...include/cpp_utils/wait/impl/DBQueueWaitHandler.ipp
35.71% <0.00%> (-8.74%)
:arrow_down:

...include/cpp_utils/threading/task/ArgsOwnedTask.hpp
50.00% <50.00%> (ø)

...nclude/cpp_utils/wait/impl/ConsumerWaitHandler.ipp
75.00% <50.00%> (-9.22%)
:arrow_down:

...p_utils/src/cpp/threading/manager/AsyncManager.cpp
50.00% <50.00%> (ø)

..._utils/src/cpp/threading/manager/StdThreadPool.cpp
50.00% <50.00%> (ø)

cpp_utils/src/cpp/threading/task/ReferenceTask.cpp
66.66% <66.66%> (ø)

...tils/threading/connector/impl/OneShotConnector.ipp
71.42% <71.42%> (ø)

...de/cpp_utils/threading/task/impl/ArgsOwnedTask.ipp
83.33% <83.33%> (ø)

cpp_utils/src/cpp/threading/task/OwnedTask.cpp
83.33% <83.33%> (ø)

... and 10 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.


Feature: Added support for displaying background images in folders

Resolved / Related Issues
To prevent extra work, all changes to the Files codebase must link to an approved issue marked as Ready to build. Please insert the issue number following the hashtag with the issue number that this Pull Request resolves.

Closes #13653

Steps used to test these changes
Stability is a top priority for Files and all changes are required to go through testing before being merged into the repo. Please include a list of steps that you used to test this PR.

Opened Files ...
...

This PR is ready for review, but won't be merged until after v3.5.

@hishitetsu I disabled custom backgrounds in Columns View.


Document the purpose of the compare_dicts method

It compares string lengths or something but it's not testing equality. Add some comments explaining why it exists.

Closing in favor of documenting more broadly details of data-generator scripts (if necessary)


Docker file references branch version 0.8.0 does not exist

The latest docker file is referencing a branch version of 0.8.0 that does not exist!! . I think the tag just needs to be created or we need to update the Docker file to reference 0.7.0
The following message is received if I try to build the dockerfile:
Removing intermediate container 59d1e7ae5736
Step 14 : RUN git clone -b $VERSION --single-branch https://github.com/DimensionDataCBUSydney/plumbery
---> Running in cbe56dfe7aac
Cloning into 'plumbery'...
warning: Could not find remote branch 0.8.0 to clone.
fatal: Remote branch 0.8.0 not found in upstream origin

You are correct. It seems that version has been moved internally to 0.8.0 after the addition of code to backup servers, however there are still a couple of steps to pass through to make it a real release.

this is now fixed


Remove keyword duplication such as same keywords with different number of white spaces as separator

An example with duplicate keywords are in this resource: https://www.hydroshare.org/resource/c71e41fe816548889ee039e870098eb4/

Have investigated this issue a bit and found we are already doing insensitive comparison when adding keywords as shown here: https://github.com/hydroshare/hydroshare/blob/develop/hs_core/models.py#L1592.
I believe the problem with that duplicate keyword issue as evidenced in this resource: https://www.hydroshare.org/resource/c71e41fe816548889ee039e870098eb4/ should be caused by the multiple or double spaces between words in a keyword rather than the capitalization. Have updated the title of this issue to reflect this.
To resolve this without too much performance compromise, I think we will need to do database raw queries to use replace function to remove all spaces within a keyword phrase and compare against the new keyword phrase with spaces removed as well, or do regular expression query to achieve the same comparison with all spaces within removed. This will definitely introduce a bit of complexity, so want to get input to see whether this issue is important enough to justify the complexity  that will be introduced into our code base. @dtarb @martinseul @horsburgh @sblack-usu @pkdash

The specific example you cited isn't due to multiple spaces between words, it's a trailling space at the beginning of the keyword

@sblack-usu Thanks for the info. That definitely will need to be fixed - the keyword value needs to be stripped to remove the leading and trailing spaces before being added, which is not done currently. I can easily create a PR to fix this, but do we want to also fix the multiple spaces between words issue? I am thinking that will only occur very rarely potentially by mistake, and users can remove extra duplicate keywords as needed, so the effort to spend to fix multiple space between keywords issue does not sound justified to me. If you agree, I will just create a PR to fix this leading and trailing space issue without spending time on the potential issue with multiple spaces between words.

I think if this needs to be fixed, the keywords should be normalized when saved to the db.  So something like a regular expression to replace 2 or more spaces with a single space and then call strip()?
If you do that, then you'll have to also normalize all of the existing keywords too.  You won't be able to do it just on the db because I think solr and the bag files will need to be updated as well.  So I think a management command would be best.

@sblack-usu Good points, and agreed. Looks like a decent amount of work would be involved to resolve this completely. I'll wait for others to chime in to see whether this is worth the effort @dtarb @martinseul

I would characterize this as a cosmetic issue with very low priority - especially given the complexity you have identified.  If a user does not like duplicate keywords, they can clean them themselves easily.  There many other more critical issues and bugs to fix first.

@hyi have you reviewed the frontend code that pre-processes the keywords? I believe some of this is handled there.

@cuahsimarko Good point. I'll take a look at the frontend code.

If it is handled in the frontend, it should be done in the backend so adding keywords via the rest api behaves in the same way.

@sblack-usu Agreed, which is why I did not look at the frontend code at all in the first place. Will look at the frontend code for keywords preprocessing logic and move/consolidate into backend if any.

@hyi @sblack-usu we should look into this as a team. Frontend validation has always had inline user feedback. Stripping that out and moving validation to a pure backend function would result in a poorer UX

I don't mind if the UX does checks and gives user feedback, but it should be consistent with the backend.

I think we should also keep in mind that this issue is low priority.  Though I do think the conversations around front/back end validations that have come out of this are worth having.

@cuahsimarko @sblack-usu I'll look into frontend code and see if I can taken into consideration both UX and backend validation for consistency and REST API access purpose. I know we have been doing both for many cases in HydroShare. I think when UX is not much affected, it'd be good to leave validation to backend so that we have single point of truth for validation. However, if UX were affected by this, some quick and fast validation on the frontend would make sense to me.

I think we should also keep in mind that this issue is low priority. Though I do think the conversations around front/back end validations that have come out of this are worth having.

Totally agree. I'm happy to move this conversation out of this Issue so as not to pollut the conversation, but overall inline/immediate userfeedback for more complex inputs, autocomplete and other contemporary UI elements have been on my mind. I'd like to start by enumerating areas for "inline feedback/validation text" and "toasts that display a message for n seconds"... I'll take the action item to briefly document and schedule a kickoff meeting at some point with low-moderate priority.

Sure frontend and backend validation can overlap and should never conflict in logic.


Find Sector rotation by Money Flow

Is your feature request related to a problem? Please describe.
A clear and concise description of what the problem is. Ex. I'm always frustrated when [...]
Describe the solution you'd like
A clear and concise description of what you want to happen.
Describe alternatives you've considered
A clear and concise description of any alternative solutions or features you've considered.
Additional context
Add any other context or screenshots about the feature request here.

Sure!We need to go thru the following steps;1. Get all the NSE symbols with their corresponding Industry/Sectors then segregate the stocks in respective groups based on sectors2. Then we need to find a way to analyse Positive or negative money flow based on MFI and CMF. Further we will add some more indicators also to make it more robust.Sent from my iPhoneOn Aug 29, 2024, at 6:25 PM, pkjmesra @.***> wrote:
@markethacks
May I suggest you to have more details added to the issue to better understand the needs? Currently, this issue only has the title but no associated description.
—Reply to this email directly, view it on GitHub, or unsubscribe.You are receiving this because you were mentioned.Message ID: @.***>


rebar3 upgrading dependencies when it's not their turn to be upgraded

I tried to upgrade chef-server's version of envy this morning, but rebar3 upgrade envy actually wound up upgrading envy AND epgsql. See for yourself!
➜ oc_erchef git:(direct_solr_writes) rebar3 upgrade envy
===> Verifying dependencies...
===> Verifying dependencies...
===> No upgrade needed for bcrypt
===> No upgrade needed for chef_authn
===> No upgrade needed for darklaunch
===> No upgrade needed for ej
===> Upgrading envy
===> No upgrade needed for eper
===> No upgrade needed for erlware_commons
===> No upgrade needed for folsom
===> No upgrade needed for folsom_graphite
===> No upgrade needed for gen_bunny
===> No upgrade needed for ibrowse
===> No upgrade needed for jiffy
===> No upgrade needed for lager
===> No upgrade needed for mini_s3
===> No upgrade needed for mixer
===> No upgrade needed for neotoma
===> No upgrade needed for opscoderl_folsom
===> No upgrade needed for opscoderl_httpc
===> No upgrade needed for opscoderl_wm
===> No upgrade needed for pooler
===> No upgrade needed for sqerl
===> No upgrade needed for stats_hero
===> No upgrade needed for sync
===> No upgrade needed for uuid
===> No upgrade needed for amqp_client
===> No upgrade needed for bear
===> No upgrade needed for edown
===> Upgrading epgsql
===> No upgrade needed for goldrush
===> No upgrade needed for meck
===> No upgrade needed for quickrand
===> No upgrade needed for rabbit_common
===> No upgrade needed for webmachine
===> No upgrade needed for gen_server2
===> No upgrade needed for mochiweb
➜ oc_erchef git:(direct_solr_writes) ✗ git diff
diff --git a/src/oc_erchef/rebar.lock b/src/oc_erchef/rebar.lock
index 83cc695..c8afa1b 100644
--- a/src/oc_erchef/rebar.lock
+++ b/src/oc_erchef/rebar.lock
@@ -28,7 +28,7 @@
   0},
  {<<"envy">>,
   {git,"https://github.com/manderson26/envy",
-       {ref,"e6ba39664a1016ed309ea44269247943de2eb16b"}},
+       {ref,"954c87adcfea892db462f56059eb8bc2857ab50b"}},
   0},
  {<<"eper">>,
   {git,"https://github.com/massemanet/eper",
@@ -36,7 +36,7 @@
   0},
  {<<"epgsql">>,
   {git,"git://github.com/chef/epgsql-1.git",
-       {ref,"cdb859d0d54fc4bed2107fd3d197bc7ea815958f"}},
+       {ref,"c83a596bc184224c4ba4d9245cef506da79ac10e"}},
   1},
  {<<"erlware_commons">>,
   {git,"https://github.com/erlware/erlware_commons",

How could this be? Our rebar.config has envy in it, but not epgsql. epgsql is actually pulled in from another dependency, sqerl. Sqerl's rebar.config includes both envy and epgsql at {branch, "master"}, so I'm wondering if this "sibling" relationship between the master pins has something to do with it.
We've done the tragic workaround of just committing the one update to rebar.lock, but that's no way to live.

epgsql is a transitive dependency. When we do the upgrade round, what we do is pretty much unlock the app to upgrade at the top-level, and then unlock all the apps lower down, because there's no good way to know how they'd be impacted otherwise before re-fetching all of them. We then go through the fetch cycle again.
In this case the problem happens because sqerl depends on a master branch, and also has no lock file on its own we can look for to fix the version.
It's a side-effect of how things are built. Maybe there's a way to improve it now that we track deps' parents and trying to traverse the graph up to ignore changes of transient apps unrelated to the unlocked top-level dep, but I'm not too sure of the implications yet.

Hmm, yea, I'd like to figure this out, but it isn't obvious to me yet. I'll look this weekend.

Could re-use the tree code for that? Tree already knows what app depends on what so it could also work for unlocking here?

Yea, going to finally look at this today. Should be possible.

Should be fixed with https://github.com/rebar/rebar3/pull/840. Reopen if there is still an issue.


Automation API for Kubernetes

This issue tracks the implementation tasks for a new Kubernetes API to provide low-level automation resources such as Workspace; see Proposal.

Added to epic https://github.com/pulumi/pulumi-kubernetes-operator/issues/586

The implementation is largely complete and is getting some tests and polish.
https://github.com/pulumi/pulumi-kubernetes-operator/pull/626
Please see the video series that I posted here, demonstrating the new Workspace API.
https://pulumi.slack.com/archives/C07DQSV84DC/p1723482988919959

Leaving open for the follow-ups, is substantively complete.


Wrap animationend event in run loop

Without this, acceptance tests in a consuming app sometimes fail.

It looks like one of the builds failed due to a random error. Maybe you can restart it @BrianSipple?

Thanks for suggesting this! I think an even better improvement would be to assign this._onStaggerComplete directly to the result of run.bind(this, ....). Could you try refactoring with that small adjustment?


Graphback Getting Started included on website

We can use similar approach to: https://aws-amplify.github.io/docs/

@wtrocki I would like to work on it. Can you please specify what exact content needs to be there in Getting Started?

Can I add this content there? https://github.com/aerogear/graphback/blob/master/docs/gettingstarted.md

Generally this chapter (which by it's own look really poor):
https://graphback.dev/docs/intro/quickstart
Could be put on the website.
Generally website loooks really poor as we have small team (just 2 people) and have little time to improve it.
Website can have some gif/slides of using graphback. Any improvements will be welcomed.
What I would do is to propose some changes yourself - it can be inspired by link above or something like: https://www.prisma.io/
CC @ankitjena - could you share with us source code for the design we got?

/assign @urvashigupta7

@urvashigupta7 I have some materials and visuals I can share for website if needed. We looking for small improvements rather than complete redesign.
Any PR will be valuable.

Yes please share.

Hi @urvashigupta7 do you need any help with this issue?


detaching disk causes timed out agent... error

Task 26 | 05:58:27 | Preparing deployment: Preparing deployment (00:00:00)
Task 26 | 05:58:27 | Preparing package compilation: Finding packages to compile (00:00:00)
Task 26 | 05:58:28 | Updating instance garden: garden/9547deae-bc8b-42f1-af92-f05e8eea0eb0 (0) (canary) (00:00:53)
                   L Error: Timed out sending 'update_settings' to 6454fb19-7c7b-4969-b9ff-b2e994c222d2 after 45 seconds
Task 26 | 05:59:21 | Error: Timed out sending 'update_settings' to 6454fb19-7c7b-4969-b9ff-b2e994c222d2 after 45 seconds

director does not agent.wait_until_ready after calling cpi.detach_disk

cc @loewenstein

@cppforlife kinda fits into the scope of https://github.com/cloudfoundry/bosh/pull/1730


Apply different text color for wiki links depending on web existing or not

Is your feature request related to a problem? Please describe.
All wikis have links to both existing and not existing ideas, but they denote this by using different text color for the wiki links.
Wikipedia for example does this using blue for existing links and red for non-existing links:

Describe the solution you'd like
Apply text color CSS to links depending on their existence.
Describe alternatives you've considered

Update one of the HTML transformers to add text color CSS for all links depending on existing / non-existing links
Adding this change in the events instead whenever a 404 is detected when parsing all links?

Additional context
None

duplicate of https://github.com/jackyzha0/quartz/issues/454


[WIP] Add global health check interval parameter.

The new parameter allows to set a health check interval valid for all backends. Custom values set per provider may override the global one.
@containous/traefik Please review.

The PR currently builds on #1320. Will be rebased once downstream gets merged.

This isn't working yet because time.Duration values are not parsed correctly. We require #1342.

Everything's working as expected now.

@timoreimann Need rebase 😉


chore(releases): setup continuous delivery and releases

recreation of previous attempt but using a docker image for toolchain / architecture abstraction purposes.
Commit messages that follow semantic-commit will automatically create a release

It will build musl, gnu assets for both amd64 and arm64

Using AWS infrastructure via cirun
Pull requests get a comment annotating the release they are in as well as a released label

WIP of using the pre-compiled assets here.
Note: build times in some cases reduced from ~44 min musl arm64 to ~25 min
Note: I tried using the rust native toolchain (see previous commits / PR's) it was non-trivial and I gave up
Note: I believe cirun.io requires it's configuration file to exist on the main branch before it's able to spin up github actions workers

Why are we making this so complicated? Rust has perfectly good cross compilation environment that can compile this small project in minutes. Why are we spawning 64-core CPU and 128GB ram c6g.16xlarge AWS instance with Docker for the build?
Why do we need to write Dockerfile for the build?
See my project: https://github.com/dndx/phantun/blob/main/.github/workflows/release.yml
With mere 50 lines of YAML, it is releasing into 14 architectures and the entire build finishes within 7 min using GitHub Actions default x86 runner, and it is a much larger code base than ATC router. Why do we need to introduce Dockerfile and run this on a $2.5/hour AWS machine?
This PR makes no sense to me.

Replaced by https://github.com/Kong/atc-router/pull/16


Added Host header to http requests

Figured the easiest way to solve the issue raised in https://github.com/cloudfoundry/bosh/issues/802 would be by adding a Host header.

thanks @cppforlife


mach-composer plan/apply -s not working anymore

In version 2.17.3 it's not possible to run mach-composer plan or apply with the flag -s again to run a apply or plan for a specific site. For example when you have 2 sites in your mach config Site A and Site B and you want to run a plan on only Site A by doing mach-composer plan -s A. This should only run mach-composer plan for site A but it will run a mach plan for all sites.

Ah yeah, I disabled that when I did the state split. I will make sure it goes back in again!