[CELEBORN-1159][BUILD] Update the scope of the protobuf-java dependency from protobuf to runtime

What changes were proposed in this pull request?
As title
Why are the changes needed?
Update the protobuf-java dependency scope from protobuf to runtime. This modification allows users to upgrade the version of protobuf-java
Does this PR introduce any user-facing change?
No
How was this patch tested?
Pass GA

thanks, merging to main(v0.4.0).


Update az cli args

Updated arguments to fix error encountered in Azure Cloud Shell
Versions:
azure-cli 2.0.14
container component 0.1.8

@noelbundick,
Thanks for your contribution as a Microsoft full-time employee or intern. You do not need to sign a CLA.
Thanks,
Microsoft Pull Request Bot

@noelbundick : Thanks for your contribution to the Azure documentation! The author, @seanmck, has been notified to review your proposed change.

#sign-off


paginated-builds

Repository URL
https://github.com/lineville/paginated-builds
New Repository Name
paginated-builds-plugin
Description
The paginated-builds plugin exposes a new REST API endpoint to access paginated build data for a Jenkins job. Out of the box Jenkins does not provide a method to access build data in pages - you can either get all the builds or the most recent 100 builds. This plugin assists in fetching historical build data for jobs with a large number of builds by being able to request specific pages of historical data.
GET <jenkins_url>/job/<job_name>/builds?start=<build_id>&size=<page_size>&orderBy=<order_by>

start: The build ID to start from. (1 if not specified)
size: The number of builds to return. (100 if not specified)
order_by: The order to return the builds in ("asc" or "desc"). ("desc" if not specified)
job_name: The name of the Jenkins job to get builds for.
jenkins_url: The URL of the Jenkins instance.

GitHub users to have commit permission
@lineville
@luke-engle
@ethanis
@dwhathaway
@MatisseHack
@NateRickard
@j-dunham
@begonaguereca
Jenkins project users to have release permission
lineville
ethanis
luke_engle
Issue tracker
GitHub issues

/hosting re-check

The link above to Artifactory ☝ seems to be broken, the site appears to be down, is there another way the users I've provided under 'Jenkins project users to have release permission' can log into Artifactory so that the request can proceed?

Nope will need to wait for it to be back up

Looks generally fine.
A couple of questions,

Why do you do a multi-module project when it's just one module? Normally a plugin will put everything in src rather than a sub module if another one isn't needed
Why do you have the maven release plugin config overridden? It appears to be the default https://github.com/lineville/paginated-builds/blob/main/pom.xml#L86-L96

@Wadeck do you want to review for security?

Thanks Tim for the ping.
Quick look: you are including snakeyaml directly, I will propose you to change to use https://github.com/jenkinsci/snakeyaml-api-plugin which will allow "us" to update that "api-plugin" and it will be used automatically everywhere. It's the recommended approach. (like you did for jackson2-api)
⚠ As you copy-pasted multiple classes from other plugins, you have to be warned that such behavior is pretty dangerous in terms of security. If a flaw is detected in one of the class, as you have "forked" them, you will not receive their correction.
(especially this folder)
Otherwise my superficial look does not indicate me that a more deeper audit is required, so 🚀

I can't even see snakeyaml used, and it's just in dependencyManagement, could it be removed?

This plugin looks like it violates the source's MIT license.

This plugin looks like it violates the source's MIT license.

Could you be more specific? not sure to see where. (not a lawyer :D)

Looks generally fine.
A couple of questions,

Why do you do a multi-module project when it's just one module? Normally a plugin will put everything in src rather than a sub module if another one isn't needed
Why do you have the maven release plugin config overridden? It appears to be the default https://github.com/lineville/paginated-builds/blob/main/pom.xml#L86-L96

@Wadeck do you want to review for security?

Thanks for taking a look! To your first question, there isn't a really strong reason that it needed to be in 2 modules, I was following from an existing plugin template that was structured this way and kept it. Happy to simplify it down to 1 module if that helps? To your second question, there also isn't a strong reason from our end that this is there, are you suggesting that block you linked could be omitted?
Also, what are the issues regarding the MIT licensing? Any of the source code that is used here taken from other plugins is under MIT licensing and left as is.

Happy to simplify it down to 1 module if that helps?

It's not required but just seemed odd.

To your second question, there also isn't a strong reason from our end that this is there, are you suggesting that block you linked could be omitted?

Yes, that would be better, you're overriding any other config that may be set in the parent pom by doing that.

Also, what are the issues regarding the MIT licensing? Any of the source code that is used here taken from other plugins is under MIT licensing and left as is.

The original copyright statements were changed though. AFAIUI (which is admittedly not a lot) that's not good because that's essentially the one requirement.

@timja Is it a hard requirement that plugins must require Jenkins version 2.277.1 or higher or is this a recommendation? I was hoping to provide broader compatibility with Jenkins versions as far back as 2.249.1, would this be possible to do or will having a required version lower than 2.277.1 prevent the plugin approval process from moving forward?

Yes we require that the minimum version is supported by the update center: https://www.jenkins.io/doc/developer/plugin-development/choosing-jenkins-baseline/
anyone running something older than that will struggle to update plugins

/hosting re-check

anyone running something older than that will struggle to update plugins

For some more color, being on an older release that's no longer supported by update sites makes hpi:run and similar very cumbersome, as you often won't be able to install or update plugins using the Plugin Manager. This gets worse over time, of course, but since the oldest supported release usually contains security vulnerabilities that have since been fixed, nobody should run something even older anyway.

@daniel-beck Thanks for the explanation, appreciate it, I've set the minimum version to the required 2.277.1 -- looks like it should be good to proceed with review 👍

Was the licensing issue resolved?

Yes, by simplifying it to a single module, and including the pipeline-stage-view rest-api plugin as a dependency the licensing is all included in the dependencies and the single license.md file here at the root, since there is no more copy pasted code.

/hosting host

/hosting host

I am having a permissions error opening up a PR to the RPU repo 😞 I've opened up an issue for this ☝
@timja
@Wadeck


Wrong color in C#

From @PotterDai Ref - https://github.com/Microsoft/vscode/issues/18204

VSCode Version: 1.8.1
OS Version: macOS sierra

Steps to Reproduce:

Define an enum.
Assign enum items int value.
Color theme starts to mess up.
Please check the following screenshot:

This should look much better in the next release:


More accurate forUnitsInRange()

Modified forUnitsInRange() to be more accurate - taking the units' collisions into consideration.

Hi,
spacing is missing around binary operator, and what about the comment?
I didn't implement this initially iirc to leave the handling of collision size up to user and because the MAX_SIZE var thing isn't great.

Forgot to remove the comment (I used to use a native I added to unit - might do a PR for them later).
I agree it isn't the prettiest solution but I think it will pick units that the user would except to be picked. I assume some users don't even know about this trick and will wonder why the forUnitsInRange() sometimes doesn't pick some units that should be picked.

Forgot to remove the comment (I used to use a native I added to unit - might do a PR for them later).

unit.isInRange(vec2 pos, real distance) returns bool already exists.

I agree it isn't the prettiest solution but I think it will pick units that the user would except to be picked. I assume some users don't even know about this 'trick' and will wonder why the forUnitsInRange() sometimes doesn't pick some units that should be picked.

Yea I suppose. Inb4 worse performance though :P

already exists.

Right but iirc at the time it didn't exist.

worse performance though

If someone thinks it might be a big issue, can always add a config bool to toogle it on and off.

will u change to using ext funcs?

Okay, so we won't change this std func for backwards compat I suppose.
What about a configurable constant to decide whether to apply the extra range stuff or not?

Making a new pr for this


Making the user available in profiles

I'm using a somewhat outdated version of this template, so this may already be possible and I may not know about it.
I'm planning on updating my config but want to wait until it's a bit more stable :)
So, my question is: Is it possible (or is there a way) to provide the user(s) to the profiles?
The use case I'm trying to solve is adding the docker group to the user in a docker user profile. That way I don't have the group in the user file and the docker config in a profile.
I apologize in advance if this had already been discussed. I couldn't find any references to it :smile:

Want to back this issue? Post a bounty on it! We accept bounties via Bountysource.

I've read this over a couple times and I'm still not sure I understand what your asking.
When you say add a group to a user, I think of something like this:
users.users.docker.group = "docker";

And when I read "making the user available in profiles", I would just think you could create a docker profile that creates the docker user - I usually just use the users folder for my personal users not system ones.
But all those things are standard nixos things and also are possible in pretty much any version of devos.
So I think I don't think I understand this issue and what your goal is. If you could clarify that would be helpful.

Ah, I see what the confusion is.
I didn't mean I wanted to add the docker group to a user named docker.
What I meant was: I want to add the docker user group to my main user (diogox) in a user profile. The docker user group here is just an example. I can see this being useful for other user groups.
To do this, I'd need to user for which I set the profile to be available inside the profile itself, I'd imagine.
The reason I'd like this to be possible is so that I don't directly reference a username inside a profile. Because if I do, that profile is not generic. I'll need to refractor it if I want to use a different username.
Does this look possible to you?

Got it, I see the issue. I think anything done by profiles should be made available through standard module system semantics and profiles only edit config.
Can you use config to get the information you need?

you could put something like this in your own user profile users.users.diogox.extraGroups = mkIf (config.virtualisation.docker.enable) [ "docker" ];
or in the docker profile you can look for users that have isNormalUser set and add them all to the docker group.

In terms of changes for devos, maybe we could pass more information about profiles somehow, I'm not sure how that would look since profiles are just standard module system modules.

I wish I could give you some ideas, but I'm not that well versed in Nix, unfortunately.
From the two options, I prefer the second one. Could you give an example of how to do that? I think that would be pretty useful as a library util function, at least. If that's even possible.

For the second option I think it would look something like this:
{ config, lib,  ... }:
{
  users.groups.docker.members = builtins.attrNames (lib.filterAttrs (n: v: v.isNormalUser) config.users.users);
}

and then make sure to enable isNormalUser for your user - which is a good idea either way.
This is definitely a good idea for a lib function lib.getMyUsers and I think it would be good if we started to add more useful functions like this in general. Because right now devos lib is mostly things needed to get devos to work. But it could use some functions that are more helpful.

Yeah, that would be great. But in the meantime, I appreciate the code snippet :grin:
I'll go ahead and close this issue now, but feel free to open it back up if you need it.
Thanks once again!


dir management

By default, basecoin should store data in ~/.basecoin. If using --in-proc, all tendermint data should be stored there as well. Dir can be overwritten with --dir flag. If using basecoin out-of-proc, should set --in-proc=$TMROOT to have same effect - otherwise app and tendermint will use separate dirs.
Layout of the dir would be:
.basecoin/
  config.toml
  data
  genesis.json
  priv_validator.json
  merkleeyes.db

Note we should only have one genesis file: https://github.com/tendermint/basecoin/issues/32

That said, I think it would be good if we had both an app and tendermint dir under the main root, but then where do we put the single genesis file? Outside both of them?

Would it not make sense to put the single geni under app, I'm thinking of when the app runs --in-proc that is. Under that circumstance tendermint is acting more as library to the application. Under the circumstance that the app is not running in proc things get a messier... how is one supposed to reference the combined genesis file when running tendermint (as in #32)? Will this require a change to tendermint-core to be able load JUST the tendermint genesis settings from a combined file? It the non-in-proc scenario maybe two genesis files makes sense?

Typo, if out of proc, --dir=$TMROOT I believe

Otherwise, I like

Actuallly, this adds weight to making basecoin a library.
chainName (which maybe would be diffferent from a programatically assigned chainID?  Need to search the code for chain ID and figure out its role)
Point being that were basecoin a library (and BTW, I think that the basecoin library should run tendermint in process by default, too) You could do something like:

Chain Name (this should be human assigned)

Chain ID (this should be network assigned, because forks happen)

Update, we can set dir with BC_HOME=x, BCHOME=x, or --home=x. And they both use the same dir when in proc.
Seems to be resolved.


Using ericdill/theversion to gen version strings

Probably shouldn't be merged until theversion is available on conda/pypi

RIght.. need to make a release of whatsmyversion before travis will pass

and now i go sleep


CMake Error at CMakeLists.txt:1 (cmake_minimum_required):   CMake 3.15 or higher is required.  You are running version   3.14.19060802-MSVC_2

CMake Error at CMakeLists.txt:1 (cmake_minimum_required):   CMake 3.15 or higher is required.  You are running version   3.14.19060802-MSVC_2
Steps to Reproduce
flutter create fsbackup
cd .\fsbackup\
flutter run -d Windows

Expected results:
Run the program without error
Actual results:
flutter run -d Windows
Downloading windows-x64/windows-x64-flutter tools...               27,3s
Downloading windows-x64/flutter-cpp-client-wrapper tools...        328ms
Downloading windows-x64-profile/windows-x64-flutter tools...        23,6s
Downloading windows-x64-release/windows-x64-flutter tools...        22,1s
Launching lib\main.dart on Windows in debug mode...
CMake Error at CMakeLists.txt:1 (cmake_minimum_required):
  CMake 3.15 or higher is required.  You are running version
  3.14.19060802-MSVC_2

Building Windows application...
Exception: Unable to generate build files

flutter doctor -v
PS D:\MyDartProjects\fsbackup> flutter doctor -v
[√] Flutter (Channel stable, 2.2.3, on Microsoft Windows [versÃ£o 10.0.19042.1165], locale pt-BR)
    • Flutter version 2.2.3 at C:\src\flutter
    • Framework revision f4abaa0735 (7 weeks ago), 2021-07-01 12:46:11 -0700
    • Engine revision 241c87ad80
    • Dart version 2.13.4

[√] Android toolchain - develop for Android devices (Android SDK version 30.0.0-rc1)
    • Android SDK at C:\Users\isaque\AppData\Local\Android\sdk
    • Platform android-30, build-tools 30.0.0-rc1
    • Java binary at: C:\Program Files\Android\Android Studio\jre\bin\java
    • Java version OpenJDK Runtime Environment (build 1.8.0_242-release-1644-b01)
    • All Android licenses accepted.

[√] Chrome - develop for the web
    • Chrome at C:\Program Files\Google\Chrome\Application\chrome.exe

[√] Visual Studio - develop for Windows (Visual Studio Community 2019 16.2.5)
    • Visual Studio at C:\Program Files (x86)\Microsoft Visual Studio\2019\Community
    • Visual Studio Community 2019 version 16.2.29306.81
    • Windows 10 SDK version 10.0.19041.0

[√] Android Studio (version 4.0)
    • Android Studio at C:\Program Files\Android\Android Studio
    • Flutter plugin version 48.0.2
    • Dart plugin version 192.7761
    • Java version OpenJDK Runtime Environment (build 1.8.0_242-release-1644-b01)

[√] IntelliJ IDEA Community Edition (version 2019.3)
    • IntelliJ at C:\Program Files\JetBrains\IntelliJ IDEA Community Edition 2019.3.4
    • Flutter plugin version 45.0.2
    • Dart plugin version 193.6911.31

[√] VS Code (version 1.55.2)
    • VS Code at C:\Users\isaque\AppData\Local\Programs\Microsoft VS Code
    • Flutter extension version 3.22.0

[√] Connected device (3 available)
    • Windows (desktop) • windows • windows-x64    • Microsoft Windows [versÃ£o 10.0.19042.1165]
    • Chrome (web)      • chrome  • web-javascript • Google Chrome 91.0.4472.77
    • Edge (web)        • edge    • web-javascript • Microsoft Edge 92.0.902.73

• No issues found!

Visual Studio 2019 v16.0 MSVC 14.22.27905

I thought the lowest version of CMake shipped with VS 2019 was 3.15 when setting up the project, but it sounds like that's not the case. Does running the VS 2019 updater fix this?
If so, we should adjust the minimum version check (although I'm not finding a specific note of when they started shipping 3.15).

I updated Visual Studio Community 2019 16.2.5 to Visual Studio Community 2019 16.11.1 and now it's working, it would be nice if the flutter doctor checks the minimal version

Looking at some old release notes looks like Visual Studio 2019 Update 1 shipped with CMake 3.14.
I'll take a quick look at the CMake 3.15 Release Notes and assuming we're not relying on anything that requires >=3.15, will send a patch dropping the requirement in the tool.

This was landed.


AppImage for Linux

Please do not merge yet, running into seemingly unrelated issues.

Looks like a build error. You may have to massage some dependencies. Also, this PR as is removes the OSX build. We'll need both OSX and linux builds working before we can merge this.

Reinstated macOS, have no clue about the dependencies; this doesn't seem to be AppImage specific to me and I don't know how I can solve these.

You can use npm run update-dependencies to update all dependencies to the latest version. If that doesn't work, then we'll probably to put in some real effort.

Ping @drew-gross

This PR has some merge conflicts and also looks like it still isn't passing tests.

@probonopd I plan to close old PRs to keeps things clean. Is it OK with you if I close this one?

Yes


Refactor body parts hierarchy on 8.2.0 mediawiki

Following the discussion in #164, these changes will add a couple of terms and lightly adjust the anatomical hierarchy.
This pull request will close #164.

I think we have to modify the schema under Body-part to preserve the is-a relationship. This will involve adding additional x-part organizational tags.  Because annotators mainly look for tags not paths, I don't think this will be a burden. We can put additional links in the ontology representation and create alternative hierarchical paths.
@smakeig @monique2208 @neuromechanist @dorahermes @dungscout96  : As a reminder we already had this discussion in the transition from HED2 to HED3.  HED2 had a mixed hierarchy with has-a and is-a relationships intermixed.  We had a schema attribute predicateType to distinguish. It made things very difficult.  We agreed to go with strict is-a to clean up the schema and assure search generality.  We removed the predicateType schema attribute. I know this is annoying not to have the parts.....
* predicateType <nowiki> [One of propertyOf, subclassOf, passThrough -- used to facilitate mapping to OWL or RDF.]</nowiki>
One thing that we could do is to introduce an 'isPartOf' schema attribute that works like suggestedTag.  This would inherited and would alert users about the relationship. What do you think?  @smakeig this might partially address your suggestion.

I'll close this PR and open another one based on the Pre-release Schema.


cmd/link: determine GO_LDSO on Linux at link time instead of baking in make.bash

#54196 identifies a general problem with our baked-in variables and a general fix of making them per-GOOS/GOARCH. But GO_LDSO is not really even per-GOOS/GOARCH: there are different settings needed on different linux/amd64 systems.
The computation during make.bash of a default GO_LDSO added in CL 301989 is particularly problematic for cross-compilation, since the GO_LDSO is only right for the current machine. CL 343010 fixed the problem for cross-compiling from one machine to another, but it does not fix the problem when the cross-compilation is used to build a bootstrap toolchain that is copied to a new machine. Then the GOOS and GOARCH tests flip back to true and the bootstrap toolchain uses the GO_LDSO setting from the original machine. This makes it impossible today to use bootstrap.bash to build an OpenBSD toolchain from Linux: when the toolchain is run on OpenBSD, it uses a GO_LDSO setting that is only appropriate on Linux. We should at the least make GO_LDSO per-GOOS/GOARCH and probably only bake in GO_LDSO_${GOOS}_${GOARCH} implicitly in make.bash. But I also wonder about baking it in at all. The default baking makes non-cross-compilation subtly different from cross compilation, which will keep coming back to bite us. And essentially all systems have a hard-coded ldso path.
CL 301989 was done to deal with the confusion of having two different ld.so on Linux systems, but then we end up with toolchains that still only work on one system or the other. Any bake-in is going to have that property. It seems like a better fix would be to not bake anything in by default and instead have the linker stat the two possible ld.so paths and use the one it finds. Then the same linker binary will produce working binaries on glibc- and musl-based systems.
/cc @ianlancetaylor and @cherrymui for thoughts. I am happy to write the CL adding the stat call in cmd/link and removing the GO_LDSO baking in make.bash.

As far as I know this confusion about dynamic linkers is specific to Linux.
For GCC you pick a target when you build GCC.  That sets the default dynamic linker.  Then you can override that default with the options -mglibc, -muclibc, -mmusl, -mbionic.  The -mbionic option corresponds to our GOOS == "android".  uclibc always uses /lib/ld-uClibc.so.0 or /lib/ld64-uClibc.so.0.  musl unfortunately varies by GOARCH.
Trying to detect the default at run time is reasonable though we will sometimes get it wrong.  And we will need a table of values for musl.
This is what I pulled out of the GCC sources for the musl dynamic linker:
arm64 /lib/ld-musl-aarch64[_be][_ilp32].so.1
arm /lib/ld-musl-arm[eb][hf][-fdpic].so.1
386 /lib/ld-musl-i386.so.1
amd64 /lib/ld-musl-x86_64.so.1
loongarch64 /lib64/ld-musl-loongarch-{,lp64d,lp64f,lp64s}.so.1
mips /lib/ld-musl-mips[el][-sf].so.1
mips64 /lib/ld-musl-mips64[el][-sf].so.1
risv64 /lib/ld-musl.so.1
powerp64 /lib/ld-musl-powerpc[le][sf].so.1
s390x /lib/ld-musl-s390x.so.1


show start end time on poke subscription table

Description
Add time to subiscription table  in poke
Risk
N/A
Deploy Plan

deploy front

PMRR


New roof plugin - Flickering roofs / smoother animation transitions.

Is your feature request related to a problem? Please describe.
The way the current plugin works makes the roofs a little to flickering when your mouse/character is moving around. It's a bit of an eyesore and makes it feel "buggy".
Describe the solution you'd like
I wonder if it would be possible to make it so that it has some type of cooldown where when a roof gets removed, it stays removed for a certain period of time (a few seconds, perhaps). This way it may be less "flickery" and would look smoother and more natural.

I want there to be a cool down of a few ticks before the roofs go back after removing the mouse, it will prevent the flickering and just make things a lot smoother.

Currently roofs also get removed when holding you mouse over all the tiles next to a building with a roof, which only amplifies this problem, I've definitely noticed this a lot during farm runs. Would be nice to have it changed or a setting where a roof only gets removed when you're mousing over tiles part of a building, so tiles next to a building isn't included.

Roofs are only removed if they're reaching over a tile, which often includes roughly a tile around the building. There are some cases where we've had to add manual overrides to the vanilla roof system (where some building was not mapped in such a way which indicated where its roofs are placed), so it's possible the cases you're referring to are due to poor overrides on our part, but by and large we rely on Jagex's mapping instead of our own.

Roofs are only removed if they're reaching over a tile, which often includes roughly a tile around the building. There are some cases where we've had to add manual overrides to the vanilla roof system (where some building was not mapped in such a way which indicated where its roofs are placed), so it's possible the cases you're referring to are due to poor overrides on our part, but by and large we rely on Jagex's mapping instead of our own.

I had the feeling in the back of my mind it may had something to do with the roofs "hanging over" the tiles next to a building, making it more of a Jagex jank kind of deal. That's unfortunate, but I still love this feature so much as someone who always kept roofs on for the visuals, knowing fully well it would cripple my gameplay a bit.


Last minute "above_surface_pressure below_surface_pressure" coord removal

Removal of "above_surface_pressure below_surface_pressure" coord by re-introducing the original NaN values.  This is done within the standardise plugin.
Closes https://github.com/MetOffice/improver_suite/issues/1523
Background
impr_engl_temp_plev_standardise task is now failing in fpostest (release) with out of memory (OO Killer).  This is due to a change in how the data is now represented via stage.
Below that of the surface altitude we used to set to NaNs in the data.  Now a flag (kind of a mask) is used instead to indicate which values are above/below the surface level pressure.
    byte flag(realization, pressure, latitude, longitude) ;
        flag:standard_name = "air_temperature status_flag" ;
        flag:flag_meanings = "above_surface_pressure below_surface_pressure" ;
        flag:flag_values = 0b, 1b ;

The file size has then doubled due to this 4D flag coordinate.
At int8 of dimension (18, 33, 960, 1280), that's an extra 730MB
The easiest thing to do last minute might be to reduce the pool size to say half (with data being ~twice the size).
This was attempted in https://github.com/MetOffice/improver_suite/pull/1519
Unfortunately we suspect dask might be at play here as the memory overhead doesn't correspond to what we might expect (doesn't reflect the increase in file size).  This is to be confirmed (in slower, less priority timescales).
Given time constraints, we hope to now instead remove this coordinate by re-applying it to the data as its previous NaN value representation.
Flag values background in cf conventions here
Suite

http://fcm1/cylc-review/cycles/cpelley/?suite=imengl_SUPPORT_TEMP_PLEV_WFLAGS (with removal)

ignore the initial 4 failures (impr_engl_temp_plev_standardise_PT0024H) - this was me iterating on these quick code changes!

http://fcm1/cylc-review/cycles/cpelley/?suite=imengl_FEED_SG2022P2_STAGE_DATA (without removal)

I have pushed up a unittest.
I'm running another cycle as a test to ensure that the pass from before wasn't a fluke - I'm seeing what looks like issues in a longer run (hopefully I didn't run the suite properly that time).

Thanks both :)

@cpelley: You should have waited for the second accepting review before merging.


fix: reuse create shadow db function

What kind of change does this PR introduce?
Bug fix, feature, docs update, ...
What is the current behavior?
Please link any relevant issues here.
What is the new behavior?
Feel free to include screenshots if it includes visual changes.
Additional context
Add any other context or screenshots.

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

0 of 1 (0.0%)  changed or added relevant line in 1 file are covered.
No unchanged relevant lines lost coverage.
Overall coverage increased (+0.7%) to 25.316%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

internal/db/diff/diff.go
0
1
0.0%

Totals

Change from base Build<PHONE_NUMBER>:
0.7%

Covered Lines:
1241

Relevant Lines:
4902

💛  - Coveralls


Double encoding in $twitch->unsubscribeWebhook

Hi, use the last version of Laravel Twitch:
$twitch->unsubscribeWebhook(
"https://***/twitch/callback/7",
$twitch->webhookTopicStreamMonitor(190203376)
);
After execute I've got a {"error":"Bad Request","status":400,"message":"hub.topic unsupported topic"}
Looked at params in request and saw:
hub.topic=https%253A%252F%252Fapi.twitch.tv%252Fhelix%252Fstreams%253Fuser_id%253D190203376
%253A%252F%252F
It's not the same as %3A%2F%2F as it get after urlencode()
Could you fix it?
BTW: use
"name": "guzzlehttp/guzzle",
"version": "6.3.3",

Could you try out the latest dev-master version? I'll file a release if can confirm your issues is solved by that.

Hmm, there is only one branch Master. Could you help me to get the right way for composer to get version for test?


chore: create a load spinner for data fetching (WEB-100)

Task
Create a load spinner that can be used when fetching data.

Steps to contribute. NEVER COMMIT TO MAIN. NEVER COMMIT TO MAIN. It should always be on your own branch and that branch name should match the issue. Ensure that you are addressing the correct issue. Each issue will be listed as something like a chore, fix, bug, etc. Your commit message MUST start with one of these tags that correspond with your issue. Followed by your commit message and your commit message must end with the branch name, for example (WEB-1)
An example commit message would look like this: chore: create contributing guidelines (WEB-8)
Commit messages should not be written in an action or present tense. It also should not mention tasks unrelated to the issue "Creating Contributing Guidelines and will work on next task" is not what we would want to see as a commit message.
After a pull request is approved, the branch should be deleted once merged.

Hello team,
I'd like to work on this!

@vazquezea96 are you still interested?

Yes sir!

@vazquezea96 alright go ahead and tackle it and create a PR for me to review. Let me know if you have any questions.

This ticket is up for grabs


Added "SkipRetry" option for Object DELETEs in package swiftclient

In particular, now that we have a garbage collection step in FSCK
(admittedly, not yet fulfilling this promise for File Inode LogSegment
objects), we can move to no-retry on object DELETEs thus significantly
speeding up that very FSCK operation that may find a need to DELETE
objects that are already deleted. Should the lack of retry end up
missing a DELETE on an existing object, the subsequent FSCK would
catch it and retry then.

Massive improvement in FSCK performance :-)


improvement print fuzzy session variable in FE audit log

Proposed changes
Issue Number: close #xxx
Problem summary
When enable use_fuzzy_session_variable in fe.conf, some of session variables will be set randomly
to test corner cases.
This PR will print fuzzy variables' value in fe.audit.log only if use_fuzzy_session_variable is true
eg:
FuzzyVariables=disable_streaming_preaggregations=false,parallel_fragment_exec_instance_num=7,enable_pipeline_engine=false,enable_fold_constant_by_be=false,enable_local_exchange=true,partitioned_hash_join_rows_threshold=8,partitioned_hash_agg_rows_threshold=1048576,enable_share_hash_table_for_broadcast_join=true,external_sort_bytes_threshold=1048576,two_phase_read_opt_limit_threshold=512

Checklist(Required)

Does it affect the original behavior:

[ ] Yes
[ ] No
[ ] I don't know

Has unit tests been added:

[ ] Yes
[ ] No
[ ] No Need

Has document been added or modified:

[ ] Yes
[ ] No
[ ] No Need

Does it need to update dependencies:

[ ] Yes
[ ] No

Are there any changes that cannot be rolled back:

[ ] Yes (If Yes, please explain WHY)
[ ] No

Further comments
If this is a relatively large or complex change, kick off the discussion at<EMAIL_ADDRESS>by explaining why you chose the solution you did and what alternatives you considered, etc...

TeamCity pipeline, clickbench performance test result:
the sum of best hot time: 34.73 seconds
load time: 488 seconds
storage size:<PHONE_NUMBER>2 Bytes
https://doris-community-test-1308700295.cos.ap-hongkong.myqcloud.com/tmp/20230208032505_clickbench_pr_91794.html


[ bug Report ] Lara does not pull the pushable correctly after Save / Load the game

TombEngine version
v1.5 (development build)
Tomb Editor version
v1.7.2 (development version)
Describe the bug
Lara does not pull the pushable correctly. She moves away while dragging the block and then gets pulled into the wall behind it and is off the map.
This happens only when you save and load the game. When starting the game and without save / load it still work correctly.
Bug is present in develop branch and also in v1.4
To Reproduce
Start the attached Level (Tremendous Tower), save and load.
Then try to pull out the pushable.
Expected Behaviour
After Save and Reload the pushable should pull out correctly like it does when you enter the game without a reload.
Additional Content
No response
Minimal reproduction project
https://we.tl/t-lPz8w845dq?utm_campaign=TRN_TDL_05&utm_source=sendgrid&utm_medium=email&trk=TRN_TDL_05
https://github.com/user-attachments/assets/b0c1e83d-2d4e-433b-80f2-fea686a604b7

Cannot reproduce in current develop version (28 / 10 / 2024).
I remember this bug was happening in TEN 1.4, but it dissapeared from develop at some point of the summer after some collision refactor.

I think we can close it, because for I also cannot this reproducing any longer.


Top speed is below 30mph

Need to improve PID controller or other controllers.

Solved in  [60c4e08]


On-Prem Files reside in Pages Subfolder

Related to #154
Category
[X] Bug
[ ] Enhancement
Problem Area
[ ] Page Transformation: Error during the setup/use of the Page Transformation UI solution (did you check our troubleshooting guide?)
[ ] Page Transformation: Error during the use of page transformation from PnP PowerShell
[ ] Page Transformation: Error during the use of page transformation from .Net
[X] Page Transformation: Page is not looking correct after transformation
[ ] Modernization Scanner: something went wrong...
Expected or Desired Behavior
Pages are transformed but in SPO they reside in a pages subfolder in the site pages library, no parameters are set to transform to this location:

Steps to Reproduce
Run the script example on SP2013 referenced in
https://github.com/SharePoint/sp-dev-modernization/issues/154#issuecomment-494885176

This most likely is a side-effect of running this against on-prem...should be handled when we further work out this capability

Closing as the fix for this has been merged


[ca] Separate CreateRootCA from saving root CA

This is a minor refactor that would be useful when autogenerating Root CAs as part of root rotation (if the user wants swarm to just generate a key and cert for them)

LGTM


[KYUUBI #6084] JDBC driver supports configuration not to pull engine startup logs

:mag: Description
Issue References 🔗

This pull request fixes #6084
Describe Your Solution 🔧
Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.
Support --ignore-launch-engine option and not pull engine starup logs
Types of changes :bookmark:

[ ] Bugfix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)

Test Plan 🧪
Behavior Without This Pull Request :coffin:
Behavior With This Pull Request :tada:
Related Unit Tests

Checklist 📝

[ ] This patch was not authored or co-authored using Generative Tooling

Be nice. Be informative.

is it for security purposes? if so, maybe we should disable the log on the server side?

Codecov Report
Attention: Patch coverage is 91.66667% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 61.07%. Comparing base (2c9fb3d) to head (95dda6a).
Report is 10 commits behind head on master.

Files
Patch %
Lines

.../org/apache/kyuubi/jdbc/hive/KyuubiConnection.java
50.00%
0 Missing and 1 partial :warning:

Additional details and impacted files
@@             Coverage Diff              @@
##             master    #6106      +/-   ##
============================================
- Coverage     61.12%   61.07%   -0.06%
  Complexity       23       23
============================================
  Files           623      623
  Lines         37200    37206       +6
  Branches       5040     5041       +1
============================================
- Hits          22738    22722      -16
- Misses        12001    12025      +24
+ Partials       2461     2459       -2

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

is it for security purposes?

We just want to align hive's native beeline behavior and reduce some logs and RPC.

beeline has a --verbose option, seems we do not respect it though

Can we skip the creation of engine-launch-log thread created byKyuubiConnection#showLaunchEngineLog if ignoreLaunchEngineLog is true ?


docs: add detail to update_service.md

PR summary
This PR adds more details to the update_service.md file.
PR Checklist
Please make sure that your PR fulfills the following requirements:

[x] The commit message follows the Angular Commit Message Guidelines.
[ ] Tests for the changes have been added (for bug fixes / features)
[x] Docs have been added / updated (for bug fixes / features)

Current vs new behavior

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information

:tada: This PR is included in version 0.33.0 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


adding code to plot dark rates - group 11

Additionally, os and glob are not being used anywhere, so I guess those can be removed

A better choice of variables names could have been chosen. Rather than col1, col2, and col3, try to use more meaningful names


Add Blob-Specific Request Headers when committing block list

Right now, there is no way to set the x-ms-blob-content-md5 header when committing a block list, only  the MD5 header for the request body is available.
See: https://docs.microsoft.com/en-us/rest/api/storageservices/put-block-list

When you call CommitBlockList, you can pass it a BlobHTTPHeaders object which includes an MD5 value. This value is sent using the x-ms-blob-content-md5 header. There is currently no way to set the Content-MD5 header because we do not think that this is very useful.

Ahhh - agreed, I (incorrectly) assumed it wasn't being done that way! Thank you!


Support other subclasses of EntityManagerInterface too

Description
Support any EntityManagerInterface in new generateId() methods, and also in existing generate()s.
Also require PHP 7.4+ and expand use of type constraints.
I suggest this targets a new major release.
Motivation and context
Detailed in https://github.com/thebiggive/matchbot/pull/338
How has this been tested?
Unit tests run and added to. Fork used in https://github.com/thebiggive/matchbot/pull/338 both with real local calls and unit tests.
Types of changes

[ ] Bug fix (non-breaking change which fixes an issue)
[x] New feature (non-breaking change which adds functionality)
[x] Breaking change (fix or feature that would cause existing functionality to change)

I believe this is backwards incompatible only insofar as PHP version support, so I have not made any documentation changes or identified any that are needed.
PR checklist

[ ] My change requires a change to the documentation.
[ ] I have updated the documentation accordingly.
[x] I have read the CONTRIBUTING.md document.
[x] I have added tests to cover my changes.

Thank you for contributing! 🎉
I committed this in 53955b785a0cac7128bdc6ecdd2e97d3e3391e63


SWARM-1530 - Temp files exists after stop an uber jar in Windows

Motivation
Windows is more sensitive for used temp files when tried to delete them. This causes temp files not being removed when Swarm applications are shut down.
Modifications

All JarFile objects should be closed prior to remove their files. Added a JarFileManager registry to close them properly.
Removed temp files on shutdown for those being temporary created as needed Maven artifacts.
Removed all Shutdownhooks except one, in order to unify and control where those files are being removed for every environment.
Removed file.deleteOnExit. All files should be deleted under Swarm control in a determined Swarm lifecycle (when server stops).

Result
Majority of temp files being removed on shutdown and Windows environments.

[x] Have you followed the guidelines in our Contributing document?
[x] Have you created a JIRA and used it in the commit message?
[x] Have you checked to ensure there aren't other open Pull Requests for the same issue?
[x] Have you built the project locally prior to submission with mvn clean install?

Windows failure seems not related to this pull. I think @mkouba and @antoinesd are looking into it.


:bug: Enforce torch cpu install with a parameter for poetry

There is no possibility of enforcing the installation of torch with cpu only for now.
Implement this feature.

Referring to python-poetry/poetry#6409

Fixed in  #30: reinstalling torch with extra index URL.


Compiler Error CS0029: Could not implicit convert to uint

I started to writing a renderer using your bindings. I have run into weird anomaly.
Error CS0029: Could not convert implicit Vulkan.DeviceQueueCreateInfo[] to uint
Snipped of the code:
            var _queueInfo = new DeviceQueueCreateInfo { QueueFamilyIndex = _queueFamilyUsedIndex, QueuePriorities = new float[] { 1.0f } };
            var _deviceInfo = new DeviceCreateInfo
            {
                EnabledExtensionNames = new string[] { "VK_KHR_swapchain" },
                QueueCreateInfoCount = new DeviceQueueCreateInfo[] { _queueInfo }
            };

It points me to this line:
QueueCreateInfoCount = new DeviceQueueCreateInfo[] { _queueInfo }

Someone pointed me to use another method of this class also did notified me about C# being strongly typed language.
And this has been solved in this code:
            var _deviceInfo = new DeviceCreateInfo
            {
                EnabledExtensionNames = new string[] { "VK_KHR_swapchain" },
                QueueCreateInfos = new DeviceQueueCreateInfo[]
            {
                new DeviceQueueCreateInfo
                {
                    QueueFamilyIndex = _queueFamilyUsedIndex,
                    QueuePriorities = new float[] { 1.0f }
                }
            }
        };

Fix worth of an RP


New threads being created unexpectedly?

Hello, I am pretty new to Celluloid (and celluloid-supervision) so to get started I created a simple example to try and get a feel for how things work.
I will post my code below but here is a rundown of my example.

1 supervision container (manages 2 actors)
2 actors
Every x seconds, one actor sends a message to the other actor to restart itself

require_relative 'lib/supervisor_group'

def start_supervising
  loop do
    group = SupervisorGroup.run
    sleep 5 while group.alive?
    puts "!!! Celluloid::Supervision::Container #{self} crashed. Restarting..."
  end
end

start_supervising

require 'celluloid/current'

require_relative 'actors/actor_one'
require_relative 'actors/actor_two'

class SupervisorGroup
  def self.run
    create
  end

  def self.create
    container = Celluloid::Supervision::Container.run!
    container.add(configuration(ActorOne, :account1_actor_one, container, 'account1'))
    container.add(configuration(ActorTwo, :account1_actor_two, container, 'account1'))
    container
  end

  def self.configuration(actor, actor_as, *args)
    {
      type: actor,
      as: actor_as,
      args: { args: args }
    }
  end
end

require 'celluloid/current'

class ActorOne
  include Celluloid
  finalizer :finalizer

  def initialize(args)
    @account = args[1][1]
    @container = args[1][0]
    async.speak
  end

  def speak
    every(60) do
      puts "I am talking in 1 from #{@account}"
    end
  end

  def testing
    puts "I am testing inside of 1 from #{@account}"
    current_actor = Actor.current
    @container.restart_actor(current_actor, 'New account data')
  end

  def finalizer
    puts "I am ending from 1 for #{@account}"
  end
end

require 'celluloid/current'

class ActorTwo
  include Celluloid

  def initialize(args)
    @account = args[1][1]
    @container = args[1][0]
    async.speak
  end

  def speak
    every(5) do
      @container.actors.first.testing
    end
  end
end

This code works and does what I expect from a users perspective.
Upon inspecting the ruby process using Activity Monitor (on OSX) I notice that every time the I call @container.restart_actor I am seeing new OS threads and an increase in memory usage.
So I added the finalizer method to do a bit more digging and found that once I quit the process, that finalizer method is being called for every @container.restart_actor call. (So if the testing method on ActorOne is called 10 times then the its finalizer method also gets called 10 times)
This behavior isn't really what I was expected, since the method name is restart_actor, my assumption was that it would kill and and create a new actor at the time it was called. My intention is to have a very long running process that follows this pattern every so often so I fear the memory usage will get out-of-control relatively quickly.

I am using ruby-2.2.2
celluloid 0.17.2
celluloid-supervision 0.20.5

If there are some things here I am doing wrong I would love to know. There wasn't really much documentation on this so I did what made since after spending a bit looking at the source. I would definitely be up to adding this type of example to the current examples if it looks like this is how it should be written.

A side note, I was able to refactor why use case to call restart_actor much less than I was initially intending (and maybe with a bit more thought I could remove the use of restart_actor completely) but I wanted to still post this here to see if I have some sort of misunderstanding.

Would you mind posting some explicit statistics to go along with your account of the behavior?
The finalizer ought to fire on restart_actor because the actors are not killed but are terminated, which is a voluntary action of the actor itself -- it's just a message put into the mailbox that says "kill yourself" ... which invokes the finalizer ... but the accrual of threads by this is not right. It's almost as if your actor(s) are hitting an error you aren't seeing -- but even that ought not accrue threads.
I'll look at this while you post statistics... and if you don't mind, can you also try rbx and/or jruby to be sure this isn't an mri behavior issue? I appreciate you going through code to work to understand the issue in the absence of documentation for this specific gem.

Thanks for responding! Sure thing, I will gather the stats and try rbx and jruby like you suggested.
One thing I wanted to note because I don't think I was very clear on what I was seeing:
The finalizer method wasn't being called on restart_actor. What I saw (and I can verify while I am getting the things mentioned above) was the finalizer only being called when I manually CTRL-C (quit) the process, then I would see the 10 finalizer print messages. That may be expected
behavior but it seems weird which is why I included that bit in my message.

Oh, that behavior is an output buffer issue. You may see different behavior on rbx and jruby with that. The output buffer behaves differently per ruby engine.

I have some stats from ruby and jruby. I haven't had time to try it out with rbx yet but I will soon. What I did was simply run the exact code above and screenshot OS Xs Activity Monitor as I started the program and about 30 minutes later before I ended it. (I ran jruby ~25 min and ruby ~30 min). Here are the stats:
Ruby:
* Memory (Start): 18.8 MB
* Memory (End): 50.1 MB
* Threads (Start): 9
* Threads (End): 422

JRuby:
* Memory (Start): 184.1 MB
* Memory (End): 263.0 MB
* Threads (Start): 35
* Threads (End): 213

The thread count roughly ticked +1 every 5 seconds (every restart_actor). The memory usage for engines wasn't completely linear. For the ruby process I saw 5 MB spikes or dips sporadically and for jruby it was about 10 MB but overall it was trending up.

If you wanted more detailed stats I certainly wouldn't mind providing them. Although I may need some guidance on what to do to get those to you. Again, thanks for looking into this!


Azure Portal says Alpine PHP 8.2, 8.3 EOL

I would have made this a PR instead but perhaps some discussion should bring more clarity.
The README in this repo currently says that Alpine Linux images 8.2 & 8.3 are "✅ Supported and recommended". I don't think that's true. At this moment in the Azure Portal I see this in the Configuration blade of my App Service:

The image above indicates that Alpine 8.2 & 8.3 is EOL.
Please correct me if I'm wrong but I think EOL (End of Life) indicates this image is not recommended. I would also think this means it is no-longer supported.
This blog post: Transition from Alpine Linux to Debian for WordPress on App Service says the Alpine stack will only be supported until the end of 2024.
I believe this repo's README should be updated to indicate the Alpine images are not recommended, soon not-to-be-supported, and indicate "⚠ End of Life" instead.

You are right.
Alpine images are not recommended. They will be supported until the end of 2024.
Please upgrade to PHP 8.2 or PHP 8.3.


what's the amount of words will this captioning use?

what's the amount of words will this captioning use?
it depends on what?

There is another additional step to remove rare words (< 5 occurrences). It will produce 2536 unique words.


Added itasa provider

Fixes SickRage/SickRage#1457 #461
Now it will not check only the format passed but the resolution too, when it searching the subtitles

Hi @Diaoul , can you give me some feedback about this pull request?

@Diaoul any news for the merge?

Waiting for news too...

Any news on this merge?
Thanks

I did a quick review so you can improve the PR. I'm not sure the parts about getting show id you picked from addic7ed provider are really useful here.

When I looked at ItaSA api, I found the approach used in addic7ed is simple and effective, so without many requests I got what i need from the site.
Otherwise what kind of approach do you recommend?

Sorry to bother again, anything new about the fixes from Elettronik?

Coverage decreased (-1.0%) to 90.985% when pulling 1982b0f36a7619532f1cd81afdbe6745587a2a98 on Elettronik:develop into 14707b68ca1f8ed6cdd78697c6bf6055a861ca2d on Diaoul:develop.

Coverage decreased (-0.9%) to 90.988% when pulling 36bce3ef89d53b2d7e06027b7e54cb5dcce19f7e on Elettronik:develop into 14707b68ca1f8ed6cdd78697c6bf6055a861ca2d on Diaoul:develop.

Coverage decreased (-0.9%) to 91.01% when pulling 350ff69fd8a02733e042751ff337f62871e2cd47 on Elettronik:develop into 14707b68ca1f8ed6cdd78697c6bf6055a861ca2d on Diaoul:develop.

Coverage decreased (-0.9%) to 91.01% when pulling aa91d0639eafa5259dec275a07f911f3550be504 on Elettronik:develop into e2331bef2c827406f92b1696b96241137163fe4f on Diaoul:develop.

Coverage decreased (-1.0%) to 90.977% when pulling e224824994e78f19538b95c9bd5fc1ae280ee4d4 on Elettronik:develop into e2331bef2c827406f92b1696b96241137163fe4f on Diaoul:develop.

Coverage decreased (-1.0%) to 90.977% when pulling<PHONE_NUMBER>f6343125e0dd6877db0180f6e7d1e4 on Elettronik:develop into e2331bef2c827406f92b1696b96241137163fe4f on Diaoul:develop.

Coverage increased (+0.6%) to 92.575% when pulling b4f7bce63cb407955c93e6729c20f6af344b1787 on Elettronik:develop into e2331bef2c827406f92b1696b96241137163fe4f on Diaoul:develop.

Coverage increased (+0.6%) to 92.575% when pulling 4d5377ff37cb86f0632d7d19fd32cd38ec52fe67 on Elettronik:develop into e2331bef2c827406f92b1696b96241137163fe4f on Diaoul:develop.

Coverage increased (+0.7%) to 92.61% when pulling 39538b643337f2ca447eace47452a076d4a8720d on Elettronik:develop into 218318286b310159dc5992980483bf207677af25 on Diaoul:develop.

Coverage increased (+0.7%) to 92.613% when pulling 78f1de3eaebf84bcce31e40a80c35671317ef9d4 on Elettronik:develop into 1c745c9c6a62591725d3055e3ccbebe098450b32 on Diaoul:develop.

Hi, can you take a look at last changes I've done and if is ok to integrate in your next releases?


migrate data from A cluster to cluster B, Error: connect ETIMEDOUT

Es ：6.2.2
docker images : elasticdump/elasticsearch-dump:latest
I have two use k8s es cluster deployment, I use NodePort exposed the port，I now need to migrate data from A cluster to cluster B,
elasticsearch-dump  info:
docker run --rm -ti af.hikvision.com.cn/docker-fireprotection/elasticsearch-dump:latest
--input=http://<IP_ADDRESS>:31920 /monitor_history_copy
--output=http://<IP_ADDRESS>:31920/monitor_history_copy_copy
--type=data
error:  Mon, 01 Feb 2021 11:42:41 GMT | dump ended with error (get phase) => Error: connect ETIMEDOUT <IP_ADDRESS>:31920
but i user  curl http://<IP_ADDRESS>:31920/monitor_history_copy_copy  is ok

This could be caused by ES being unresponsive during index caused by resource starvation.
There isn't enough information here to know what the issue is. You can try increasing the retry limit and retryDelay to compensate for the period of downtime. Although 100 records shouldn't be caused this issue, but then I don't know how elasticsearch is configured

ok,i try.


linkage_checker: ignore broken linkage with LLVM libc++.

[x] Have you followed the guidelines in our Contributing document?
[x] Have you checked to ensure there aren't other open Pull Requests for the same change?
[x] Have you added an explanation of what your changes do and why you'd like us to include them?
[ ] Have you written new tests for your changes? Here's an example.

[x] Have you successfully run brew typecheck with your changes locally?
[ ] Have you successfully run brew tests with your changes locally?

When dyld is not able to find a library at its install name, it
attempts to find it inside its default search path.
This means that for libraries we ship that are also provided by the
system (e.g. libc++), brew linkage can fail even if the formula
still works (i.e. brew test succeeds).
Given this, it makes sense to attempt to dlopen the library first
before deciding the linkage is broken. This will be useful when we ship
Homebrew/homebrew-core#106925, which will move the install location of
libc++, causing brew linkage to fail for any formula that links with
that libc++.
Those formulae that link with LLVM's libc++ will fall back to Apple's
libc++, which is why we see multiple brew tests succeed even when
brew linkage failed in the LLVM PR linked above.
This change helps avoid unnecessary source rebuilds for formulae that
link with LLVM's libc++ after LLVM 15 ships.

Review period will end on 2022-09-12 at 04:52:28 UTC.

Review period skipped due to critical label.

This makes sense for libc++ but I'm less convinced it's desirable in the general case.
While yes dyld technically may work this way and the executable may "run", if something is (for example) linking to Homebrew curl but ends up using system curl, there could be problems later on and we will want to know about it (e.g. for the automatic formula reinstall).
I would be ok special casing this for libc++ at the moment though, as long as we note down what formulae are affected by it.

Yea, I initially started with a special case for libc++ and then wondered whether it should just be more general.
I'll switch it back.

Scoped this to only LLVM libc++.
This will report no linkage with libc++ at all if linkage with LLVM's libc++ is broken. Ideally we probably want to report linkage with /usr/lib/libc++.1.dylib instead.
I'm punting on that since I'd like to get this in along with the tag for the Glibc fixes.

Ideally we probably want to report linkage with /usr/lib/libc++.1.dylib instead.

In the long term, we'll phase out using LLVM's libc++ in our formulae.

In the long term, we'll phase out using LLVM's libc++ in our formulae.

This should already be phased out in Homebrew/homebrew-core#106925. I'm just thinking of formulae in external taps that declare an LLVM dependency and inadvertently link with LLVM's libc++.


Change position using drag and drop

Also fixes broken google sign in.

Not sure why web build is failing in GitHub actions, web seems to be building fine for me

@lockieRichter I approved it.
It does not need to be implemented on Web for the moment.
The build breaks. You need to update the dependency web to version >= 0.4.2 to make it build.

No worries @shockbytes, to fix this issue I've had to bump the minimum Dart version in pubspec to 3.3.0, to be able to support this you'll need to use the latest flutter 3.19.2


Unable to register users when country is provided

The code the checks if countries exist or not is the above and it checks if a country is active by checking isActive but there is no property isActive in Country entity making it impossible to register due to the error: "The requested country was not found."
To fix we either have to add isActive or use only findOneById() instead of using findOneActiveById() while registering users.

Simply, i remove management country for this project so all country always be active.


TRSS rebrand to use Adoptium logo colours etc

updated logo, links, colours etc

@llxia I assume that someone needs to deploy these changes to the TRSS server?

re: https://github.com/adoptium/aqa-test-tools/pull/448#issuecomment-860033854 - yes, we will deploy the changes next week which I am sure is sufficiently within the "grace period" of this type of rebranding exercise.
Note: https://github.com/adoptium/aqa-test-tools/issues/404 exists because we will like to automate the deployment/upgrades/backups so they run on a weekly basis (and run manually as needed).

Just for the record, the TRSS server is updated to include this PR https://trss.adoptium.net/


WIP: Placeholder forJob pod terminate

Placeholder for documentation update to reflect JobPodRecreationPolicy

https://github.com/kubernetes/enhancements/issues/3939

/sig apps

https://github.com/kubernetes/kubernetes/pull/119301#discussion_r1265688824 note I should add here.

exception request received.
Holding until it's approval.
/hold

Exception was approved and release team gave me the goahead to cancel the hold. https://groups.google.com/g/kubernetes-sig-release/c/8m9_MloKhoI
/hold cancel

/retest

/cc @mimowo
I have a draft of the feature but not sure if this is sufficient.  Would love your thoughts!

The PR description says this is a placeholder - is that right?

The PR description says this is a placeholder - is that right?

Thanks for that.  Updated.

/approve

@sftim and @cortespao I think I addressed all outstanding comments.


Rename namespace results in extra spaces for @Using directive when moving .razor files

Describe the bug:
When you move files (i.e. Blazor/razor files) into a subfolder in Visual Studio, it asks whether you would like to rename the file namespace to match the folder structure. If you answer "yes", then whatever does the adjustment adds an extra tab after the "@using" statement at the top making it “@               using” and leading to a compilation issue. There are also reports this will freeze on large projects when, for example, you move a large folder of files.
Version used:
e.g. VS2022 17.3 or 17.4
To reproduce:
Steps to reproduce the behavior:

Create a new Blazor solution
Locate a .razor file that has a "@using" directive at the top
Add a new folder named 'Whatever'
Move the .razor file from its current folder into the new folder
Respond 'Yes' when Visual Studio asks if you want to adjust the namespace to match the folder name

Expected behavior:
The namespace adjusts, but the space between the "@" and "using" remains as-is
Actual behavior:
The namespace adjusts, but space is inserted between the "@" and "using", resulting in a compiler error.
Additional context:
See attached image

This was also reported in https://developercommunity.visualstudio.com/t/VS2022-171-Blazor-moving-razor-files-fr/10011429
I can repro this in latest VS

Not sure if this is the same as https://github.com/dotnet/razor-tooling/issues/6167? Seems like some of the duplicated reports for that issue, are actually this issue.

So we're getting a didChange notification, coming from Roslyn which ultimately comes from Project System which gets its list of changes from Roslyn!
So the next step is to see whether Roslyn is making strange changes (adding whitespace when it should be changing a using statement???) or whether its our source mapping service (which would be called by Roslyn to translate the changes to the .g.cs file to the .razor file) doing something odd.
I suspect nothing else in our system is relying on didChange notifications for .razor files, so we could potentially just (somehow) tell Roslyn not to apply workspace changes to our mapped documents and avoid the issue entirely for now, but obviously fixing things is better, because actually having the using statement change namespace would be magical.

Another report: https://developercommunity.visualstudio.com/t/In-Blazor-app-Razor-file-spaces-insert/1629654

This is because of formatting done by Roslyn. Razor emits code like
// some global usings
namespace MyRazorApp
{

// @using System
using System; // note indentation (or lack thereof)
}

So when the formatting pass happens it indents the using statement

Another report: https://developercommunity.visualstudio.com/t/Renaming-namespace-with-intellisense-sug/1669168

it is still happening in current version ;/

Correct. I got prioritized with other work but hoping to fix this in the 17.12 time frame with https://github.com/dotnet/razor/pull/10334

Another instance https://developercommunity.visualstudio.com/t/Removing-unnecessary-namespaces-on-whole/10745613
Make sure fix includes that scenario as well

Another instance https://developercommunity.visualstudio.com/t/Issues-when-renaming-a-class-with-Blazor/10526357

Another instance https://developercommunity.visualstudio.com/t/Adjusting-namespaces-cripples-razor-usin/10686383

This should be fixed in 17.13 Preview 2


[cxx-interop] Fix assertion failure when looking up C++ operators

Previously when looking up a C++ operator (e.g. ==), ClangImporter::Implementation::lookupValue returned a Swift function with a generated name (e.g. func __operatorEqualEqual), while the caller expected the result to be a Swift operator (e.g. func ==).
This change makes sure that we're returning a synthesized Swift operator when looking for a C++ operator.
This fixes an assertion failure in the typechecker:
swift-frontend: /home/build-user/swift/lib/Sema/ConstraintSystem.cpp:1454: std::pair<Type, Type> swift::constraints::ConstraintSystem::getTypeOfReference(swift::ValueDecl *, swift::FunctionRefKind, swift::constraints::ConstraintLocatorBuilder, swift::DeclContext *): Assertion `func->isOperator() && "Lookup should only find operators"' failed.

@swift-ci please smoke test

This is a requirement for https://github.com/apple/swift/pull/58699.

Merging to unblock other work, happy to discuss post-merge.


Domain join requires correct DNS server

xDNSServerAddress is required before xComputer if domain cannot be resolved through default DNS server

Solution requires knowledge of appropriate DNS server and local adapter name


Support detecting request body

Proper detection of request message bodies requires:

Content-Length
Chunked transfer encoding (#96)
Empty bodies for certain requests

See https://tools.ietf.org/html/rfc7230#section-3.3
This means that we should take these into account and only emit data events for what is actually part of the given request and then emit an end and close event.
This is also a prerequisite for #39.

While seeing all the prerequisites are met, doesn't this make more sense to come in 0.8?

This PR only handles detecting the message body, i.e. emitting streaming data, end, error and close events. Afaict this is not handled for all cases yet (requests with implicit message lengths). Once everything is completed, this should be released as v0.6.0.
This ticket does not handle parsing this message body, this is left up for #105. Parsing the body relies on detecting its length first (this ticket) and likely also on adding a proper interface first (#28), so this is currently planned for the v0.8.0 release.

Closed via #116, #129, #130, #136 and #137. Example added via #139.


Update README.md

Commit : Just corrected some spellings and changed a few sentences / the wording for clarity. Feel free to accept or decline.
Thank to @OSevangelist.

Codecov Report

Merging #3 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master       #3   +/-   ##
=======================================
  Coverage   93.48%   93.48%
=======================================
  Files           4        4
  Lines         261      261
=======================================
  Hits          244      244
  Misses         17       17

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6ca2cbd...159ecb5. Read the comment docs.


KL Loss.

Hi, I just noticed that the KL Loss in the VAE paper would look like this:
0.5 * torch.sum(torch.exp(logVar) + mean ** 2 - 1. - logVar)
And here, the KL Loss is:
torch.mean(0.5 * torch.sum(torch.exp(logVar) + mean ** 2 - 1. - logVar, 1))
What's your thought in this?

It's because the recon_loss is averaged, therefore it also has to be averaged to be on the same scale.
You can use sum, but you have to change your learning rate.

Thanks. I think this explains it well.


3d modeling?

I haven't read through the paper yet but I figured I'm inquire, is this research limited in scope to just 2d or are tensor based calculations appropriate and practical for 3d modeling as well?

We've used this codebase with tweaked architectures for 3D modeling, too.


Update notes for -EnableUnauthenticatedSender

Notes to be added:
To prevent these identifiers from being added to messages from specific senders, you have the following options:

Allow the sender to spoof in the spoof intelligence policy. For instructions, see Configure spoof intelligence in Microsoft 365.

Configure email authentication for the sender domain.

For the question mark in the sender's photo, SPF or DKIM are the most important.
For the via tag, confirm the domain in the DKIM signature or the MAIL FROM address matches (or is a subdomain of) the domain in the From address.

For more information, see Identify suspicious messages in Outlook.com and Outlook on the web
The notes that appear on the below documentation also need to be shown on this documentation.
https://docs.microsoft.com/en-us/microsoft-365/security/office-365-security/set-up-anti-phishing-policies?view=o365-worldwide
Customers are confused on the feature otherwise - Ref. customer escalation https://o365exchange.visualstudio.com/DefaultCollection/IP Engineering/_workitems/edit/1596890

Docs Build status updates of commit c8edf3b:
:clock10: Full build: the average full build time is 17 min(s) 40 sec(s), this is based on the last 1000 build(s) for this repository.

Docs Build status updates of commit c8edf3b:
:x: Validation status: errors
Please follow instructions here which may help to resolve issue.

File
Status
Preview URL
Details

exchange/exchange-ps/exchange/Set-AntiPhishPolicy.md
:x:Error

Details

exchange/exchange-ps/exchange/Set-AntiPhishPolicy.md

[Error-InvalidMamlMarkdown]

Failed to parse this MAML markdown file due to :370:(1646) ' To prevent these identifiers from being added to ...'
 Expect Heading, please use PlatyPS to do content validation

For more details, please refer to the build report.
If you see build warnings/errors with permission issues, it might be due to single sign-on (SSO) enabled on Microsoft's GitHub organizations. Please follow instructions here to re-authorize your GitHub account to Docs Build.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
Note: Your PR may contain errors or warnings unrelated to the files you changed. This happens when external dependencies like GitHub alias, Microsoft alias, cross repo links are updated. Please use these instructions to resolve them.
For any questions, please:Try searching in the Docs contributor and Admin GuideSee the frequently asked questionsPost your question in the Docs support channel

Docs Build status updates of commit 1fd6d69:
:clock10: Full build: the average full build time is 17 min(s) 40 sec(s), this is based on the last 1000 build(s) for this repository.

Docs Build status updates of commit 1fd6d69:
:x: Validation status: errors
Please follow instructions here which may help to resolve issue.

File
Status
Preview URL
Details

exchange/exchange-ps/exchange/Set-AntiPhishPolicy.md
:x:Error

Details

exchange/exchange-ps/exchange/Set-AntiPhishPolicy.md

[Error-InvalidMamlMarkdown]

Failed to parse this MAML markdown file due to :370:(1646) ' To prevent these identifiers from being added to ...'
 Expect Heading, please use PlatyPS to do content validation

For more details, please refer to the build report.
If you see build warnings/errors with permission issues, it might be due to single sign-on (SSO) enabled on Microsoft's GitHub organizations. Please follow instructions here to re-authorize your GitHub account to Docs Build.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
Note: Your PR may contain errors or warnings unrelated to the files you changed. This happens when external dependencies like GitHub alias, Microsoft alias, cross repo links are updated. Please use these instructions to resolve them.
For any questions, please:Try searching in the Docs contributor and Admin GuideSee the frequently asked questionsPost your question in the Docs support channel

Docs Build status updates of commit a2f6ff8:
:clock10: Full build: the average full build time is 17 min(s) 40 sec(s), this is based on the last 1000 build(s) for this repository.

Docs Build status updates of commit a2f6ff8:
:x: Validation status: errors
Please follow instructions here which may help to resolve issue.

File
Status
Preview URL
Details

exchange/exchange-ps/exchange/Set-AntiPhishPolicy.md
:x:Error

Details

exchange/exchange-ps/exchange/Set-AntiPhishPolicy.md

[Error-InvalidMamlMarkdown]

Failed to parse this MAML markdown file due to :370:(1646) ' To prevent these identifiers from being added to ...'
 Expect Heading, please use PlatyPS to do content validation

For more details, please refer to the build report.
If you see build warnings/errors with permission issues, it might be due to single sign-on (SSO) enabled on Microsoft's GitHub organizations. Please follow instructions here to re-authorize your GitHub account to Docs Build.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
Note: Your PR may contain errors or warnings unrelated to the files you changed. This happens when external dependencies like GitHub alias, Microsoft alias, cross repo links are updated. Please use these instructions to resolve them.
For any questions, please:Try searching in the Docs contributor and Admin GuideSee the frequently asked questionsPost your question in the Docs support channel

Docs Build status updates of commit e6355f6:
:clock10: Full build: the average full build time is 17 min(s) 39 sec(s), this is based on the last 1000 build(s) for this repository.

Docs Build status updates of commit e6355f6:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

exchange/exchange-ps/exchange/Set-AntiPhishPolicy.md
:white_check_mark:Succeeded
View (exchange-ps)

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching in the Docs contributor and Admin GuideSee the frequently asked questionsPost your question in the Docs support channel

Docs Build status updates of commit 3cb9231:
:clock10: Full build: the average full build time is 17 min(s) 39 sec(s), this is based on the last 1000 build(s) for this repository.

Docs Build status updates of commit 3cb9231:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

exchange/exchange-ps/exchange/Set-AntiPhishPolicy.md
:white_check_mark:Succeeded
View (exchange-ps)

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching in the Docs contributor and Admin GuideSee the frequently asked questionsPost your question in the Docs support channel


Added Deploy Preview System.  & Fixed Image paths.

Hey @blueedgetechno. I have added my Deployment preview system and have fixed some image and video paths for when the site is not on the root.
I have created an new GitHub actor for the preview system. Win11bot will still do the win11react but now you have a separate one for android. https://github.com/android69420 It can be renamed.
I shall DM you the secret PAT code. for the bot. :)
Previews will appear at the following URL: https://android-previews.pr.blueedge.me/

Netlify. I challenge you to a deployment fight.

andrewstech supremacy


historical results - No runs found for the workflow: ***

hey!
Perhaps is that I am not understanding how this command works or I am missing something. I am a bit stuck here, so it would be great if someone could help me. I have few questions.

In the Actions in this repo, I don't see why in some cases it is working, and there is historical results, and in other cases there isn't:
1.2. In this run 526 run there is historical for 7 runs 👌
1.3. but in the 525 and 527, no historical, just results from the actual run. But in the logs there is no error or no clue.

In my own repo, I was able to make it work, but only for 3 runs I was able to see the historical of those 3 runs, not anymore, not sure why or how. Now historical is always displaying the actual run, no previous ones. I spent a bit of time investigating this, but no luck fixing it. In my case I see in the logs this error "No runs found for the workflow: ***"
2.1. I always thought that my problems were coming from artifact/names, because even executing again same workflow that showed me historical, I have only the result of the actual run.
2.3. But seeing this error "No runs found for the workflow: ***", it seems that the problem is not artifact/names. (or could be that is finding runs, but not the right artifact?)

It would be great to know a bit more about how this command works, how when searching for other runs is identifying the workflow name, how the search is done, if it has to be in the same branch...
Thanks in advance!

Hello, thank you for raising this issue. The historical methods filters for relevant results:
For branches: It matches the workflow name and ensures the run was triggered by a push event on that specific branch.
For pull requests: It matches the workflow name and ensures the run was triggered by a pull_request event with the specified pull request number.
It was decided to do it this way so that when running tests or workflows for a specific branch (e.g., main, develop, or a feature branch), you only see the history of workflow runs for that branch or PR.
However, if you see the error message "No runs found for the workflow", it means it could not find any historical workflow runs that match the same workflow name as the current one.
With this in mind, do you still experience an issue while satisfying the filtering?
Thanks

Thanks for the quick response and the explanation!
Now it is working for me, but I didn't change much from last time. I have examples of runs triggered by a pull_request event with the same pull request number with no historical, "No runs found for the workflow", but suddenly same PR is finding runs and displaying the historical 🤷♂ I guess I did something wrong with those runs.

For branches: It matches the workflow name and ensures the run was triggered by a push event on that specific branch.
For pull requests: It matches the workflow name and ensures the run was triggered by a pull_request event with the specified pull request number.

My idea of using this I guess it is not fitting in how it is designed. I have the CI running every night and I thought it would be useful to have the Historical of previous CI runs. But if it is working only with push_events and pull_request, it is still useful, but not exactly what I was looking for 😄

I'm going to look into scheduled actions, as it seems like it might be a common use case.
Thanks for raising!

Branch filtering now includes schedule. Feedback welcome 😄


OpenSeadragonHTMLelements plugin

Following the issues raised by user Salitehkat, #1497 and #1501 , a general solution to have HTML elements "tied" with an osd viewer seemed the way to go, so this plugin was created.
GitHub repository
Feel free to give suggestions and/or feature requests.

Beautiful! Looks great to me. Can you make a pull request on our site repository to add it to the list of plugins?
https://github.com/openseadragon/site-build/blob/master/www/index.html#L155

Just did ^^
How should eventual user required changes and updates be handled? Can the plugin repository be changed at will, if ever necessary?


Unable to parse oklab colors

I hit a warning while trying to parse an svg with "oklab" colors:
WARN usvg::parser::style: Failed to parse fill value: 'oklab(31.061% 0.00233 -0.00267)'. Fallback to black.

CSS Color Module Level 4 is still a draft and not supported by resvg.
Duplicate of #514


preact watch doesn't kill the process when the stdin pipe is closed

Npm Version: 5.3.0
Node version: 8.0.0
OS: macOS Sierra 10.12.16
Do you want to request a feature or report a bug?
Bug
What is the current behavior?
I run preact watch by running npm run dev, which runs preact watch. But I'm doing this from a process run by another app that serves as the backend. This a app correctly spins up preact watch, but when it shuts down and closes the stdin pipe, the preact process keeps running, which I believe is not the correct behavior.
If the current behavior is a bug, please provide the steps to reproduce.
You should be able to reproduce this by running a bash script like the following:
#!/bin/bash
PORT=8080 npm run watch

Then exit with ctrl-c and run ps -ax | grep 'preact watch', you will likely see something like:
 4845 ??         0:03.29 node /Users/your_user_name/your_project/node_modules/.bin/preact watch

What is the expected behavior?
I would expect preact watch to follow the unix standard and it should either fork and persist, or it should kill itself when stdin closes. Preferably it would kill itself.

Here is how Brunch handles the behavior I expect.


Special Proxy Config Requirements Should be Clearly Documented or Automated

Hi,
Sorry for the apparently trivial bug, but I really did have to work at this for over a day (and I like to think I know enough that it shouldn't have been that big a deal), just to get the sift upgrade process to finally succeed from behind my proxy. It would be nice if some of these steps could be automated. The user should just have to set up the proxy in the System Settings/Network GUI. I did all of the following:

Downloaded the most recent SIFT .ova file, & imported into VMware Workstation
Set the proxy configuration in the System Settings/Network GUI
Manually added the following two additional lines to /etc/environment (The uppercase HTTP_PROXY & HTTPS_PROXY lines are critical, as some component apparently doesn't recognize the lowercase ones that are added by the GUI step above. I also note that the GUI forces the https proxy URL to itself be https, which doesn't work in my environment, but that's likely an Ubuntu issue.)
export HTTPS_PROXY=http://:
export HTTP_PROXY=http://:
set the following two lines into a newly created '/etc/salt/minion' file (Note: The space after the colon is REQUIRED):
proxy_host:
proxy_port:
sudo sift upgrade

After all this, the sift upgrade to the new 2018 version finally succeeded.
Thanks
John

Thanks for the feedback. I agree, the proxy information can be documented better.

oops.. The post was supposed to have  more detail in it. I had included data in angle brackets, and those got stripped. Let's see if it works when I use the 'insert code' function in the comment tool...
3. Manually added the following two additional lines to /etc/environment (The uppercase HTTP_PROXY & HTTPS_PROXY lines are critical, as some component apparently doesn't recognize the lowercase ones that are added by the GUI step above. I also note that the GUI forces the https proxy URL to itself be https, which doesn't work in my environment, but that's likely an Ubuntu issue.)
export HTTPS_PROXY=http://<hostname>:<port number>
export HTTP_PROXY=http://<hostname>:<port number>
4. set the following two lines into a newly created '/etc/salt/minion' file (Note: The space after the colon is REQUIRED):
proxy_host: <hostname>
proxy_port: <port number>

I also neglected to mention the required reboot or services restart after making the changes, but before running 'sudo sift upgrade'.

Please also note, that once https://github.com/teamdfir/sift-saltstack/pull/80 is merged, SIFT CLI will be officially deprecated as of March 1, 2023, and is replaced with cast
Proxy support is still missing from cast.


Fixed broken alignment attempts.

When running SPIFFS on architectures less forgiving of alignment errors than x86, the packed structs can cause total failures (as I discovered the hard way). This commit properly aligns the packed structs to fix that issue.
See e.g. https://stackoverflow.com/questions/8568432/is-gccs-attribute-packed-pragma-pack-unsafe for discussion on what can and can't be done when using __attribute((packed).
Looking at the structs themselves I'm wondering if it wouldn't be better to simply drop the "packed" attribute altogether, and just reorder the members to minimise the padding, especially considering that they obviously need to be aligned one way or another.

First of all, thanks for looking at this. Though spiffs was meant to be platform agnostic, I wrote it personally for a hobby project for the Cortex - having no problems with unaligned data (except if specifically set, see #29).
The main mistake I made from the beginning was to store the structs directly. This was due to laziness, and to make the code smaller. I also wanted to avoid gaps in stored structs as much as possible in order to utilize the bytes of the flash as much as possible.
That said, I will look into this as soon as I get the time. __attribute(( packed, aligned(4) )) will still have an unpadded struct internally, but make the whole struct size of 4 byte boundary, right? What was the crash/problem you experienced? It must have been when using any of the packed struct together in a superstruct somewhere. The other worry I have is if messing with this, backwards compability will be a problem, but that can of course always be solved with those lovely ifdefs ;)

I ran into this when I was updating NodeMCU to use your latest version since I wanted to be able to build off-line file systems and include in a combined firmware image*, and it seemed less effort to upgrade NodeMCU than work out which version was in there.
When doing that upgrade I initially ended up undoing their existing workaround, so I got hit over the head with unaligned access exceptions (read: cyclic reboots). I haven't worked out exactly where this got triggered from, but it definitely seems to be a case of an entire struct being unaligned somewhere. A cursory review didn't spot where.
I totally appreciate there's a trade-off between spending bytes inside the fs versus spending bytes on code to unpack stuff. Unless you're on forgiving hardware the bytes have to be spent somewhere though :/ And the Xtensa LX106 used by the ESP8266 (and hence NodeMCU devkit) is anything but forgiving.  Can't complain too much though - they're an amazing bang for the buck! As is your project! =D
As for backwards compatibility, with an advertised release version of 0.3.2 I don't think people can hold you too much to that :D  Not to say you should throw it overboard unnecessarily however!
*) Kind-of-a quick-hack: https://github.com/DiUS/spiffsimg

Hmmm... Did you enable the SPIFFS_ALIGNED_OBJECT_INDEX_TABLES flag? This was introduced for the ESP8266 case considering alignment. It should work of the shelf if you enable that. Still haven't hooked up my ESP, too many kids requiring attention ;)

From memory that wasn't enough (it only gives a 2-byte alignment as configured in NodeMCU).
It also didn't help that the _align member size doesn't get calculated to something moderately useful, as the minus takes precedence over the ternary (paranteser för sjutton, grabben! ;) )

Vad fasen!? :) When testing here, 4 - (sizeof(spiffs_page_header)&3)==0 ? 4 : (sizeof(spiffs_page_header)&3) gives the correct result. Popped it in a loop replacing the sizeof with some number of figures - looked ok. Anyhow, it is a small matter adding some parentheses if necessary.
Also, the 2 byte alignment should be ok as the following data is a 16-bit table.
Do you have more info exactly what is becoming unaligned, what access? I've understood the ESP might not be the most debug friendly platform though... ;)

Okay, I've now had more time investigating this stuff, and it looks like the alignment stuff here isn't really needed after all on the ESP. Once I got to the point in NodeMCU that I could run without the SPIFFS cache enabled, it turns out that while the issues were definitely around alignment, they were further down than the SPIFFS layer. The second-lowest-level of the flash read API expected to always get an aligned destination buffer, which it only did if this bunch of additional constraints were imposed on the SPIFFS structures, and then only while the cache was enabled. The write path on the other hand happily dealt with unaligned buffers. After fixing the read function it's now not only possible to run without cache but also without any explicit alignment (including the _align member).
Looks like I'll have to wear the egg on my face for assuming the flash API was sane and symmetrical :/  Bara att be om ursäkt här känns det som! Closing the pull request too, for obvious reasons.

Heh, ingen ko på isen :)

Fan, det var länge sen jag hörde den - tack! :)


Add a user defined regexp function when initialising sqlite connection

Hi, I realised that by default I could not use the REGEXP keyword/function of sqlite because it requires a user-defined function to work. This patch solves the problem and allows to do:
pysqldf("""
    SELECT count(*)
    FROM tweets
        WHERE NOT date REGEXP '^[0-9]{4}-[0-9]{2}-[0-9]{2}'
    LIMIT 10
""")

It's a fairly simple patch, let me know what you think or if it requires any changes.

Do you have a fork that includes this (and possibly other fixes)?  This project is approaching abandonware status it seems.


Project addition : Bird loader

Related Issue
I saw this illustration on dribbble and I have tried to make it from CSS and add animation to convert it into a screen loader.
Closes: #1158
Describe the changes you've made
Project Bird Loader added.
Describe if there is any unusual behavior of your code(Write NA if there isn't)
NA
Checklist:

[x] My code follows the style guidelines of this project.
[x] I have performed a self-review of my own code.
[x] I have commented my code, particularly in hard-to-understand areas.
[x] I have made corresponding changes to the documentation.
[x] New and existing unit tests pass locally with my changes.

Screenshots

Thanks for the contribution. Keep Contributing.


change Schedule order

Feature Request
A way to change which scheduler item goes first.
Feature Information:
Currenty, theres no way to change order in the scheduler properly if there is two schedules in one event.

I confirm:

[x] that I have searched for an existing feature request matching the description.

This is already planned.

Implemented in latest release


CB-13693: Improves Documentation

The explanation of the contactFields argument in the 'navigator.contacts.find' section is unclear and ambiguous. Updating to make it clearer to people wanting to utilise this plugin.

At no point is the argument data type described (array)
The statement for using "*" to search all fields is ambiguous due to a combination of point 1) and direct ambiguity in the statement itself (the description of the value of the argument by providing a STRING example rather than an ARRAY example.

Platforms affected
None
What does this PR do?
Improves documentation
What testing has been done on this change?
Not applicable
Checklist

[Y] Reported an issue in the JIRA database
[Y] Commit message follows the format: "CB-3232: (android) Fix bug with resolving file paths", where CB-xxxx is the JIRA ID & "android" is the platform affected.
[Y] Added automated test coverage as appropriate for this change.

@janpio new PR for decimation improvements

Thanks!
Did you test using the plugin with [*] and did it work?

Hi @janpio
Sorry, forgot to answer that!
Yes my application started working, pulling Contacts information via the .find method when I use ["*"] as the first argument.

Thanks @janpio !
Hopefully that'll help stop some people getting stuck like I did!

Yep, that's why I just merged this. Don't even know if I am supposed to, as this plugin is officially deprecated ;) No harm done by improving the docs though...

Exactly - lots of people will still use this so why not make the documentation better? Thanks again!


Resolve hang in failure scenario

Experienced a hang while attempting to use the spring-boot-migrator to convert a Mule project to Spring Boot.  Tracing the hang resulted in a failure occurring within the program itself, and rather than indicating the failure, spring-boot-migrator locked itself into an infinite loop where issuing a SIGINT from the console wasn't enough.
This fix converts the while check to an if check to ensure that the failure message gets printed, and the program can return a prompt.

Hello @cab105 welcome to Spring-boot-migrator team, we  recently had a stab at solving this issue with one of our open rewrite based recipes.
Could you provide us a sample small mule project that exhibits this behaviour? or try latest SBM on your sample

Thanks @cab105 🚀
I am sorry you had to dig into this area of the code ;)
As @sanagaraj-pivotal wrote, an example project would be great?
Nevertheless, I merged it.

Thank you @fabapp2 and @sanagaraj-pivotal.
For context this is against the latest source tree, and with this "fix" in place, I'm able to get a proper failure scenario with stacktrace using stacktrace from the CLI. I am seeing the following error being thrown:
Caused by: java.lang.IndexOutOfBoundsException: Index 0 out of bounds for length 0 this is occurring at https://github.com/spring-projects-experimental/spring-boot-migrator/blob/5d51df2d982af4a41b48bc9a9d11dd678739bbad/components/sbm-recipes-mule-to-boot/src/main/java/org/springframework/sbm/mule/actions/JavaDSLAction2.java#L191.
I'm still digging into the underlying failure to determine why it isn't locating the application context as this is blocking the other PR I'm working on.
As to the sample that I've been using for my own development/testing, it is this:
https://gist.github.com/cab105/be696eca9380b751219f6395febf6afb


Add British English Guidance to PR Template

Pull Request
Description
Added a comment to the pull request template encouraging contributors to use British English for spelling and terminology where possible. The comment also reassures contributors that using other variants is acceptable if they are more comfortable with them.
fixes #60

#61  👈
main

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @JackPlowman and the rest of your teammates on  Graphite

Merge activity

Oct 27, 6:58 AM EDT: A user merged this pull request with Graphite.


Rultor test

@rultor hello

@rultor hello

@rultor hello

@renedewaele Hi there! I understand a few simple commands: "merge", "deploy", etc. This page explains them briefly. Any questions or bug reports are welcome. Have fun :)

@rultor hello

@renedewaele Hi there! I understand a few simple commands: "merge", "deploy", etc. This page explains them briefly. Any questions or bug reports are welcome. Have fun :)


Option to add XRef link is missing

Option to add Xref link using Alt + M > Link .

VS Code:
Version: 1.88.1 (system setup)
Commit: e170252f762678dec6ca2cc69aba1570769a5d39
Date: 2024-04-10T17:41:02.734Z
Electron: 28.2.8
ElectronBuildId: 27744544
Chromium: 120.0.6099.291
Node.js: 18.18.2
V8: 12.0.267.19-electron.0
OS: Windows_NT x64 10.0.22631
Name: Learn Authoring Pack
Version: 1.0.1
Name: learn-markdown
Version: 1.0.7

Downgrading learn-markdown extension to 1.0.3 fixed this - link to XRef is there again.

@pmaytak The underlying Xref service is being retired so this was removed from the current version by design.

@meganbradley Does this mean all the current xref links in the docs will stop working and will need to be updated? Or is this only related to the VS Code plugin? If the xref links will still work, can a doc page be added giving examples of how to properly use the xref syntax? Thanks.

@meganbradley, I use this feature quite a lot. Is there any replacement or guidance on what to do with the feature removed?

We could use some help with this, too, on the ASP.NET Core docs repo. We were using a couple of tools that we hand-built in ASP.NET Core (websites that we were running in Azure), but our tools are broken now due to churn in the API docs web API. I was just trying to revert back over to using the Learn Markdown extension's Link to XREF feature. Now, that's gone.
I'll take it up internally to see what management wants us to do, but I hope our only option isn't having to go back to looking at the ms.assetid <meta> tag of API doc files. That's CrAzY 😵 slow ... and thus expensive and costly to Microsoft 💸💸💸.


NIFI-12305 Optimize Regular Expressions in SampleRecord and EndpointMerger

Summary
NIFI-12305 Optimizes regular expression pattern definitions and usage in the SampleRecord Processor and the AccessPolicyEndpointMerger class.
Changes to SampleRecord improve range validation with an initial split on comma prior to validating individual ranges. This approach avoids potential issues with large numbers of ranges. Change to AccessPolicyEndpointMerger restrict the set of characters to alphanumeric values and hyphen.
Tracking
Please complete the following tracking steps prior to pull request creation.
Issue Tracking

[X] Apache NiFi Jira issue created

Pull Request Tracking

[X] Pull Request title starts with Apache NiFi Jira issue number, such as NIFI-00000
[X] Pull Request commit message starts with Apache NiFi Jira issue number, as such NIFI-00000

Pull Request Formatting

[X] Pull Request based on current revision of the main branch
[X] Pull Request refers to a feature branch with one commit containing changes

Verification
Please indicate the verification steps performed prior to pull request creation.
Build

[X] Build completed using mvn clean install -P contrib-check

[X] JDK 21

Licensing

[ ] New dependencies are compatible with the Apache License 2.0 according to the License Policy
[ ] New dependencies are documented in applicable LICENSE and NOTICE files

Documentation

[ ] Documentation formatting appears as expected in rendered files

+1 LGTM, thanks for the improvement! Merging to main and support/nifi-1.x