Build a PacletSite in this github repository

With this improvement, users can simply write PacletInstall["MaTeX"] to fetch the newest and compatible version of MaTeX after executing PacletSiteRegister@"https://github.com/szhorvat/MaTeX/raw/master".
Put all paclets in the /Paclets/ directory, and export the PacletSite[Paclet[Name->..., ...], ...] expression as ZIP to /PacletSite.mz, then everything will be OK.
You can use the PutSiteInfo[] function to conveniently create PacletSite.mz in this paclet:
PacletInstall["WolframPacletSiteManager", "Site"->"https://github.com/rnotlnglgq/WolframPacletSiteManager/raw/master"] .
https://mathematica.stackexchange.com/questions/218254/how-to-set-up-own-paclet-server/243689

I would prefer to avoid maintaining my own private paclet server. MaTeX is actually already on this paclet server (and will be updated soon): https://paclets.github.io/PacletServer/
I believe Wolfram Research has been working on an official paclet repository for quite a while now. When it is released, I will definitely submit MaTeX there.
It would be best not to live in a world where each project runs its own private paclet server. That would not provide much of an advantages over just publishing the .paclet files on GitHub Releases.


CMake and Ninja versions necessary

I'm using Python 3.10, cmake 3.29.1 and ninja 1.11.1. I usually try first with my own versions to avoid env balkanization.
With meson 1.3.0:
running build_ext
Traceback (most recent call last):
  File "./PhotoshopAPI/setup.py", line 153, in <module>
    setup(
[..]
    ninja_executable_path = Path(ninja.BIN_DIR) / "ninja"
AttributeError: module 'ninja' has no attribute 'BIN_DIR'

After updating to meson 1.4.0:
ERROR Missing dependencies:
	ninja
	cmake>=3.12

Which versions do you recommend?

Hey, I am not too familiar with the meson build system myself but I am personally running using ninja 1.11.0 through visual studio. Are you intending on building the wheels or the compiled .pyd yourself?
For the .pyd you only need to build via cmake while the wheels rely on the setup.py file. I myself only build the wheels through CI which is why I dont have a local example to go off of

Hi @waarmond, I just wanted to check in if you were able to get it working?


Improved documentation

Pull Request Test Coverage Report for Build 49

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 93.37%

Totals

Change from base Build 43:
0.0%

Covered Lines:
9323

Relevant Lines:
9985

💛  - Coveralls


Parameter Encoding for POST method not working.

Swift 3.1
Moya 8.0.5
Is it possible to place parameters in URL when I have a request with POST method?
My goal is to create a request with parameters included in URL. So the request should look like this:
POST https://google.com/123/somePath?parameterId=someId
Unfortunately, when I create request with POST method all parameters are placed outside URL. I made some tests and I've discovered that when I change the method to GET, then all works fine.

Below my code and cURL for both requests:
github url: https://github.com/k8mil/MoyaBaseURL
enum MyApi {
    case postWithURLParameters
}

extension MyApi: TargetType {

    var baseURL: URL {
        return URL(string: "https://google.com")!
    }

    var path: String {
        return "/123/somePath"
    }

    var method: Moya.Method {
        //return .get //it works
        return .post
    }

    var parameters: [String: Any]? {
        return ["parameterId": "someId"]
    }

    var parameterEncoding: ParameterEncoding {
        return URLEncoding.default
    }

    var sampleData: Data {
        return Data()
    }

    var task: Task {
        return .request
    }
}

@objc func doRequest() {
    provider.request(MyApi.postWithURLParameters) {
        result in
        print(result)
    }
}

curl -H "Host: google.com" -H "Accept-Language: en;q=1.0" -H "Accept: */*" -H "User-Agent: MoyaBaseURL/1.0 (k8mil.MoyaBaseURL; build:1; iOS 10.3.0) Alamofire/4.4.0" --compressed https://google.com/123/somePath?parameterId=someId

curl -H "Host: google.com" -H "Content-Type: application/x-www-form-urlencoded; charset=utf-8" -H "Accept: */*" -H "User-Agent: MoyaBaseURL/1.0 (k8mil.MoyaBaseURL; build:1; iOS 10.3.0) Alamofire/4.4.0" -H "Accept-Language: en;q=1.0" --data-binary "parameterId=someId" --compressed https://google.com/123/somePath

According to this:
https://stackoverflow.com/questions/14551194/how-are-parameters-sent-in-an-http-post-request
It seems to be specially designed for POST.

Hey @k8mil. You are right - by default POST method would add parameters to the body. But there is an option to brute-force it in the query string: you would have to use URLEncoding(destination: .queryString) as your parameterEncoding. More on this matter you can find here.

@sunshinejr
Thanks for pointing that. However, finally I'll stay with default way, so my POSTplace the parameters into request body. :)


no rpc server

example flow:
warcli graph create --outfile 10.graphml 10
warcli network start 10.graphml
(optional, not really working)
warcli network connect

@m3dwards

LGTM

e6eb40e5
commited a .DS_Store :-P


Prepopulate items to tokenInput.

Gotcha: according to documentation, item should be formed as
{
  id: 3,
  name: "John"
}

but name is not taken as name, and that item is displayed as undefined.
Inspecting internals of item object showed that it contains id,
containing an id and value, hint and queue, containing name. I
picked value and it worked for me. @aratak, you may want to look at it
more careful.
P.S. Using my fork for a while.

I know, that you like parameter "selectSelected". It should read something like "choose only selected element".
They are use the same function for inserting default velues and choosed values. (Capitan note). And this function use tokenFormatter function for add selected value to the list.
This function has been re-defined by drapper:
{
  tokenFormatter: function(item) { return "<li>" + item.value + "</li>" }
}

Oh, crap, I've missed that.


Bump to 2.42.2

Hi! This is the friendly automated conda-forge-linting service.
I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.


Update framework-g-cloud.html

updated framework descriptions to remove bias to G-Cloud 7.

Definitely better. :+1:


METAR: Visualize JSON output

Document JSON output by visualizing the fields via https://plantuml.com/json

Won't do, a proper Rust documentation (#13) with JSON examples for the output seems like a better idea.


Upgrade integration testing sample to VS2017

Upgraded projects.
Updated nuget packages.
Fixes #2928

@ardalis,
Thanks for having already signed the Contribution License Agreement. Your agreement was validated by .NET Foundation. We will now review your pull request.
Thanks,
.NET Foundation Pull Request Bot


Please state (Or install) what versions of (MS)VCRT are required on a clean install

I have taken the simple start project created and placed onto the VM Edge 1809 x64 (After updates and webview2 installed)
But the application does not start due to missing Dll's
Can the Pre-Reqs either check for or download the corect MSVCRT (And other e.g. 14_1) dlls in order to make this work.

Thank you for the report. We will look it further. For now, you can download the runtime from VC Redistribution Packages for Visual Studio 2019
You need the  x64: vc_redist.x64.exe link


Using twitter bootstrap for layout

This PR:

use twitter bootstrap for cute-ification
add orientation, color, category search
limited api keys so demo users can play with the api without signing up

lgtm.
do you want to squash this into a single commit first.


Cannot find module use-inertia-form or its corresponding type declarations

I have just installed this by using the following command:
npm install use-inertia-form --save-dev

From what I can see, this installed latest 4.3.1 version.
Then, I simply tried replace one use of useForm with useInertiaForm after importing it; however, both the IDE and Vite now show this error:
TS2307: Cannot find module use-inertia-form or its corresponding type declarations.

Did I perhaps simply install/import it wrong? Or is this problem caused by something else?

If it is relevant, I would like to add that, if I open the folder node_modules/use-inertia-form I see only 3 files:

LICENSE
package.json
README.md

I solved this by rolling back to 4.3.0; after doing so, in the folder now there is also a dist subfolder, and the import works properly, maybe there is something wrong specifically with version 4.3.1

Hello, sorry for the delay in seeing this. Pretty confusing behavior, unfortunately I'm unable to reproduce it. I've made some changes to the rollup config though to address some bundle size issues, hopefully that also addresses this issue.


Respect .SetIdempotence() on LINQ queries

Currently the value of .IsIdempotent is not copied from LINQ statements to generated BoundStatements. This makes .SetIdempotence() ineffective on LINQ statements, preventing things like speculative execution from working.
This PR copies the idempotence value along side other properties that are already copied, like consistency level and retry policy.

Hi, thanks for the PR! Nice catch, it looks like there's a couple other properties that are not being copied. I did a quick check and it seems that the following are missing as well, can you add them?
ReadTimeoutMillis, OutgoingPayload, Timestamp

I just discovered CqlQueryOptions.CopyOptionsToStatement(), which also seems to copy values from LINQ statements.
The following properties are currently copied by both:

IsTracing
ConsistencyLevel
SerialConsistencyLevel
PageSize
PagingState
RetryPolicy

The following is only copied by CqlQueryExtensions.CopyQueryPropertiesTo():

AutoPage

The following is only copied by CqlQueryOptions.CopyOptionsToStatement():

Timestamp

The following are copied by neither:

IsIdempotent
ReadTimeoutMillis
OutgoingPayload

I'm not really sure which should be added where. :/

Thanks for the explanation.
I've added copying the remaining properties to CqlQueryExtensions.CopyQueryPropertiesTo() as you suggested.

I'm just going to write a couple of tests to verify this before merging the PR.
Is this urgent? We weren't planning on doing a release soon but we can do a small patch release just for this depending on the urgency.

A patch release would be great, since this is blocking us from using speculative execution in a latency-sensitive use case.

How are you setting idempotence with LINQ? Can you provide a small code snippet?

While writing tests I realized you can't actually use the method SetIdempotence() with LINQ because then you can't call Execute() (it's an IStatement object) so the only supported way is to use execution profiles which should work correctly.

Actually nevermind, set idempotence is not available in the execution profile so we're still missing a way to set idempotence in LINQ but I don't think this PR completely fixes the issue.

We currently do it like this:
    var query = new Table<MyTable>(session).Where(x => x.Id == id);
    query.SetIdempotence(true);
    var result = await query.ExecuteAsync();

Ah I see... I'll create a separate ticket to make sure it is possible to use .SetIdempotence() in a chaining way.

I'm almost done writing these tests and I already found something that should be changed here. SetTimestamp is actually implemented in inserts/updates/deletes and it generates the USING TIMESTAMP clause in the actual query string instead of setting the protocol option. Adding it here in this PR is unnecessary as the only thing it is doing is adding it for SELECT statements which doesn't make sense anyway...
Due to this, can you remove the SetTimestamp change from this PR? sorry about this.

Due to this, can you remove the SetTimestamp change from this PR? sorry about this.

Sure, no problem. Done. 👍


Error migration

Good day! I have a clean Laravel. When you install the package parsidev/entrust in Maine an error occurs. When I create a new migration file entrust_setup_tables.php and run the command
php artisan migrate I receive this error. Please tell me how I can fix this problem?
SQLSTATE[HY000]: General error: 1005 Can't create table 'int.#sql-442_355' (errno: 150) (SQL: alter table `role_user` add constraint ro
  le_user_user_id_foreign foreign key (`user_id`) references `users` (`user_id`) on delete cascade on update cascade)

Hi.
thanks for reporting.
you can edit entrust_setup_tables in migrations directory in your project
find this
$table->foreign('user_id')->references('user_id')->on('users')
                ->onUpdate('cascade')->onDelete('cascade');

and replace with this
$table->foreign('user_id')->references('id')->on('users')
                ->onUpdate('cascade')->onDelete('cascade');

i fixed this error and you can update your package too.

Thanks I was able to migrate! But now another problem did everything as in the instructions.
Created files
app/models/Role.php
app/models/Permission.php
Changed the model User.php
<?php
namespace App;

use Illuminate\Auth\Authenticatable;
use Illuminate\Database\Eloquent\Model;
use Illuminate\Auth\Passwords\CanResetPassword;
use Illuminate\Foundation\Auth\Access\Authorizable;
use Illuminate\Contracts\Auth\Authenticatable as AuthenticatableContract;
use Illuminate\Contracts\Auth\Access\Authorizable as AuthorizableContract;
use Illuminate\Contracts\Auth\CanResetPassword as CanResetPasswordContract;
use Parsidev\Entrust\Traits\EntrustUserTrait;

class User extends Model implements AuthenticatableContract,
                                    AuthorizableContract,
                                    CanResetPasswordContract
{
    use Authenticatable, Authorizable, CanResetPassword;
    use EntrustUserTrait;
.....
}

And executed the command composer dump-autoload
Trying to create a new role.
Route::get('/', function () {

    $admin = new Role();
    $admin->name         = 'admin';
    $admin->display_name = 'User Administrator'; // optional
    $admin->description  = 'User is allowed to manage and edit other users'; // optional
    $admin->save();

    return 'OK';
});

After that get the error Class 'Role' not found

if you working with this package in route directly, please use this
$admin = new App\Role();
....
``


Cloud Filestore Template

Products: GDM/CFT
Issue: Template Inquiry
Hello,
I am trying to deploy to cloud filestore via deployment manager/CFT, however, there doesnt seem to be a template for it. Am I missing something?
If one needs to be made for it, I would be down to take a crack at making it, but I just want to ensure that there isn't actually an officially sanctioned method of doing this before I run off and put a ton of work into this.
Any help or insight into this issue would be greatly appreciated. Thanks!

Indeed, it looks like there's not.
We'd be happy to look at a PR if you want to contribute one.

Note: gcp-types/file-v1beta1 is supported by DM. Adding it to the backlog.

Working on this.

FYI #301 is merged to master.


Enforce branch policies on the repository

To improve the security of the ORAS project we need to enforce the branch policies for this repository. I propose that we enforce the policies as follows:

Use the following rules for main and release/* branches:

Require PR before merging

[ ] Require 3 approvals
[ ] Dismiss stale PR approvals when new commits are pushed
[ ] Require review from Code Owners
[ ] Require status checks to pass before merging
[ ] Require conversation resolution before merging
[ ] Require signed commits
[ ] Do not allow bypass the above settings

Please add your comments and proposals for additional changes to this issue.

This would only work with more contributors. In the past when I’ve asked for PR reviews in slack it would take a month or more, often with a manager doing it. I’m good for branch policies but they need to be reasonably feasible.

And how will that improve security? Do you think I’ve been merging code that has introduced security issues? 🤔

This is a fair point @vsoch. Apologies for the copy and paste from the other repos. I would be happy to help with PR reviews and also fixes. And you are right, we need more contributors for the Python libraries.
To answer your question about how this increases security, it is an additional check so unwanted changes don't sneak in either by mistake or because of a compromised account.


filesystem not support oss

Bug report
Issue Description
filesystem not support oss （Object Storage Service） ,when i change the config/filesystems.php then can't access product images
Preconditions
php 7.3.26
Bagisto version

1.3.1

Steps to reproduce

3.installed composer package by https://github.com/jacobcyl/Aliyun-oss-storage

Expected result
product and velocity meta images can be access
Actual result
can't access all images

Hi @ruan11223344,
May I know, are you facing this in any specific place or everywhere because we have used Laravel Storage facade and all the config adapters should work fine because there is no bagisto stuff.

yes it work ! i rewrite this file


Flatpack support

It would be cool if the next release is released as a flatpack and added to the discovery store in steam deck

I would also love a flatpak, distributed on flathub.

Linked to #355

It is Flatpak, not Flatpack. And there is already a ticket for this, as mentioned in the previous comment.

Thanks for the patience! Greenlight can now be found on Flathub 🎉 https://flathub.org/apps/io.github.unknownskl.greenlight


asphalt: command not found

Issue
I get this error :
asphalt: command not found
After the step:

Start the OWAPI server.

PYTHONPATH=. asphalt run config.yml
Links that cause the issue
Hi! Thank you for helping OWAPI by submitting an issue.
Before you submit, please make sure you've done the following:

[x] Google/Search previous issues to make sure it hasn't been answered before.

Done.

[ ] Ask if this is an OWAPI issue, or a Linux issue, etc.

OWAPI requires Python 3.5 or higher installed on a unix machine, and it's not really our job to troubleshoot random linux errors.

Thanks!

Make sure asphalt is installed and in your path.

Thanks for the reply. I'm afraid this is where my knowledge of this
deployment gets a little spotty. Is asphalt a linux application? I have
searched but cannot seem to find it...
On 5 February 2017 at 10:15, bippum<EMAIL_ADDRESS>wrote:

Make sure asphalt is installed and in your path.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/SunDwarf/OWAPI/issues/137#issuecomment-277504202, or mute
the thread
https://github.com/notifications/unsubscribe-auth/AHn7cw-jTsd85NviZWpzFWVDNFLQWEKGks5rZYUYgaJpZM4L3beX
.

Did you create a virtualenv and install the requirements?

Hi,
Yes, this command:
Install the requirements.
For debian-based systems: sudo apt install libxslt-dev python3-dev
build-essential zlib1g-dev
source ./venv/bin/activate && pip install wheel && pip install -r
requirements.txt
Produces this output:
(venv) andrew@domo:~$ Could not open requirements file: [Errno 2] No such
file or directory: 'requirements.txt'
Could: command not found
Where does the requirements.txt file need to be located?

On 5 February 2017 at 12:23, Laura Dickinson<EMAIL_ADDRESS>wrote:

virtualenv a

It's located in the directory you cloned owapi into.

Alright,
Here is the output further:
Requirement already satisfied: wheel in ./venv/lib/python3.5/site-packages
Could not open requirements file: [Errno 2] No such file or directory:
'requirements.txt'
(venv) andrew@domo:~$ cd
(venv) andrew@domo:~$ ls
asphalt  OWAPI  venv
(venv) andrew@domo:~$ cd OWAPI/
(venv) andrew@domo:~/OWAPI$ ls
api.md               config.yml    LICENCE  rates.default.yml
requirements.txt
config_noredis.yaml  CONTRIBUTORS  owapi    README.md
It appears to be there?
On 5 February 2017 at 14:54, Laura Dickinson<EMAIL_ADDRESS>wrote:

It's located in the directory you cloned owapi into.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/SunDwarf/OWAPI/issues/137#issuecomment-277517983, or mute
the thread
https://github.com/notifications/unsubscribe-auth/AHn7c4ndQVlODG0E_BR_YYcSAQW8DbR0ks5rZcaOgaJpZM4L3beX
.

Run pip install -r requirements.txt from that directory.

Great, thanks, that worked.
It appears that the server is now running. However, how do I access it from
something other than localhost? :)
P.S: Thanks for all your help.

Alright, I understand that I missunderstood how the API works. For some
reason, I am unable to use the locally hosted service or I'm not sure how
to actually get it working correctly.
Regardless, is it possible to get per-hero stats? Eg:
https://owapi.net/api/v3/u/Dad-12262/heroes/ana ?
On 5 February 2017 at 16:08, Andrew Childs<EMAIL_ADDRESS>wrote:

Great, thanks, that worked.
It appears that the server is now running. However, how do I access it
from something other than localhost? :)
P.S: Thanks for all your help.

@vexersa I do want to add per-hero stats to v3. It will happen sometime soon, I've been extremely busy lately.

Awesome, that would be excellent.
What are your API rate limits currently per IP?
On 12 February 2017 at 19:04, Andrew Zah<EMAIL_ADDRESS>wrote:

@vexersa https://github.com/vexersa I do want to add per-hero stats to
v3. It will happen sometime soon, I've been extremely busy lately.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/SunDwarf/OWAPI/issues/137#issuecomment-279232072, or mute
the thread
https://github.com/notifications/unsubscribe-auth/AHn7c10o67D1OmGaloMatXMR8LU0viF1ks5rbzuCgaJpZM4L3beX
.


Memory leaks related to dynamicConfigReload option.

Current behavior
We see potencial memory leaks on SSR level.
Expected behavior
GC clean unused memory segments.
Steps to reproduce the issue
If setup dynamicConfigReload to true in production mode we see leak of memory
And use autocannon for example.
http://dimasch.github.io/yandex-tank-benchmark/
Repository
Affected all version and branches.
core/scripts/server.js
Possible workaround:
if (config.server.dynamicConfigReload) {
    const cachedConfigModule = require.cache[require.resolve('config')]
    if (cachedConfigModule) {
      delete cachedConfigModule.parent.children;
      delete cachedConfigModule;
    }

Can you handle fixing this bug by yourself?

[x] YES
[ ] NO

Which Release Cycle state this refers to? Info for developer.
Pick one option.

[ ] This is a bug report for test version on https://test.storefrontcloud.io - In this case Developer should create branch from develop branch and create Pull Request 2. Feature / Improvement back to develop.
[ ] This is a bug report for current Release Candidate version on https://next.storefrontcloud.io - In this case Developer should create branch from release branch and create Pull Request 3. Stabilisation fix back to release.
[ ] This is a bug report for current Stable version on https://demo.storefrontcloud.io and should be placed in next stable version hotfix - In this case Developer should create branch from hotfix or master branch and create Pull Request 4. Hotfix back to hotfix.

Environment details

Browser:
OS:
Node:
Code Version:

Additional information

I will prepare PR in next time.

CooL! Thanks @dimasch, waiting up for a PR

Hey @dimasch how about the status? :)

Hey @pkarw Today i will prepare PR and check difference. For me need some time :)

@pkarw Done.

thanks @dimasch ! Nice job :)


Issues Refreshing / Setting up Dispatcher

Information:

<EMAIL_ADDRESS><EMAIL_ADDRESS>
Issue Description:
I'm unable to refresh a dispatcher. I'm able to export all models as json files and import, train, publish them with no issues. Yet I always fail to refresh the dispatcher  with the message "Failed importing latest version of Dispatch-UAT-Model app"
When I go to recreate the dispatcher with dispatch init -n XXX --luisAuthoringKey XXX --luisAuthoringRegion XXX It asks for a bot secret, which I thought dispatch would create for me upon creation of a new dispatcher...
Commands Example:

Expected Behavior:
I expect to have the Dispatcher refresh fine. I'm able to import the last completed Dispatch.json file from the last time this command worked. I can't find any issues with any of the models and I'm not getting any good debug.
For creating a new dispatcher I would expect a new dispatcher to be created and for it to provide the bot secret. Not for it to prompt me for a bot secret

@stikemanley, are you using bot file with dispatch cli?  It should only prompt for bot secret if used with an encrypted bot file.   Would you mind sharing your .dispatch file to<EMAIL_ADDRESS>so I could investigate the import failure?

Closing due to inactivity.


🍒 Cherry pick PR #18709 to staging 🍒

🍒 Cherry pick https://github.com/Expensify/App/pull/18709 to staging 🍒

🚀 Cherry-picked to staging by https://github.com/OSBotify in version: 1.3.12-1 🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
success ✅

🕸 web 🕸
success ✅

@Expensify/applauseleads please QA this PR and check it off on the deploy checklist if it passes.

🚀 Deployed to production by https://github.com/marcaaron in version: 1.3.12-1 🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
success ✅

🕸 web 🕸
success ✅

🚀 Cherry-picked to staging by https://github.com/AndrewGable in version: 1.3.28-2 🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
success ✅

🕸 web 🕸
success ✅

@Expensify/applauseleads please QA this PR and check it off on the deploy checklist if it passes.

🚀 Deployed to production by https://github.com/AndrewGable in version: 1.3.28-5 🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
success ✅

🕸 web 🕸
success ✅


X-Ray Authentication failure due to SSL

Is it possible to also pass the ENV_XRAY_API_VERIFY_SSL parameter to the ClientSecretAuth class here - https://github.com/fundakol/pytest-jira-xray/blob/master/src/pytest_xray/xray_publisher.py#L40 that is advised here - https://github.com/psf/requests/issues/6071#issuecomment-1059528942
OR
What's the alternative to set it to False. I tried few methods like creating a fixture in conftest and setting session.verify in requests.Session() as False but didn't work. None of the solutions are able to set the SSL to false. Could you please advice?

I created PR with a fix, could you check if it works for you? https://github.com/fundakol/pytest-jira-xray/pull/69

@fundakol this works!!

Released as 0.8.5

Thank you!


Rollout restarts of ztunnel node proxy result in proxy failures

Bug Description
This is a weird one.
tl;dr is restarting ztunnel on a node with a rollout pattern breaks the mesh, whereas restarting ztunnel on a node with a "terminate-and-replace" pattern does not - and CNI is AFAICT not the culprit.
Repro

Deploy Istio with ambient enabled.
Manually recycle all ztunnel pods on all nodes with e.g. kubectl delete pod -n istio-system ztunnel-xyz, and wait for Kube to reschedule them.
Run an ambient integration test, such as:

go test -tags=integ ./tests/integration/ambient/... --istio.test.ambient  --istio.test.ci -run "TestPodIP" -p 1 --istio.test.nocleanup  --log_output_level=all:debug  --istio.test.kube.helm.values="global.logging.level=all:debug" -v

Note that the test should pass
Recycle all ztunnel pods with a rollout via e.g. kubectl rollout restart ds/ztunnel -n istio-system, and wait for the new pods to become ready.
Run the same test again and note that it begins to fail, and from then on will continue to fail. Not all of them will fail (some of the waypoint/uncaptured tests work fine).
Note that manually restarting ztunnel pods without using rollout (e.g., restarting them with delete pod) will cause the tests to begin passing again.

Basically, any form of ztunnel restart that involves a rollout, where a new ztunnel pod is brought up alongside the old one on the same node, both of them are briefly "ready", and then the old one is terminated breaks the mesh/tests.
Any form of ztunnel restart that involves a recycle, where the current ztunnel pod on the node is terminated before the replacement comes up, works fine/"fixes" the mesh/tests.
I was convinced this was an istio-cni bug/race condition involving either

Not picking the ready ztunnel pod with the newest creation date as the "right" one, resulting in traffic getting redirected to an old/bad ztunnel IP.
CNI not properly cleaning up/recreating rules when transitioning redirection to the new ztunnel pod.

After debugging I'm actually pretty convinced that the CNI is behaving correctly - it always selects the correct ztunnel pod with either mode of ztunnel start, and properly recreates all iptables, rules, tunnels, etc to point to the correct ztunnel pod. I can find no glitch or race condition there - the CNI behavior is the same between both restart methods.
In addition, I actually see ztunnel getting the traffic and making connections to upstream services even when the tests are broken.
Which is leading me to suspect this might be a bug in the control plane - some state somewhere is bad because in the rollout method, for a brief/temporary time there are two active ztunnel pods on a single node - even though in all cases CNI is only ever redirecting traffic to one or the other of them (or none of them, if neither is ready).
Version
Current `master` ztunnel and `istio` as of 2023-03-17:

client version: 1.18-dev
control plane version: 1.18-dev
data plane version: 1.18-dev (20 proxies)

### Additional Information

_No response_

picking this back up.

Closing this, cannot repro with latest master


Layer title is not updated when interacting with feature on map

Describe the bug
When a map has multiple layers, and if the feature details is opened, but user interacts with another feature on the map from a different layer, the feature detail is updated but not the layer title.
Expected Behavior
Update the layer title when the feature is not from the same layer
Reproduction Steps & Sample

Open the map > click a layer
Click on a feature to view its details
Interact on the map with a feature from a different layer
Notice the layer title is not updated.

https://lgtest.mapsdevext.arcgis.com/apps/instant/reporter/index.html?appid=7dd9949b10e847198052f1387fb0daef
Other Relevant Info
No response

@skrishn
We have fixed this and will deliver it in the next code drop

Great! Thanks, Sumit!


Modification to allow multiple boss threads in client

During load test, our wacko testers decide to shutdown our loopback servers which receive very large numbers of  long lived tcp connections via a netty-based client (400-500k). On the success path we were doing 800tps without any problem really. So in the test with the remote server shut down, I hadn't really expected any sort of problem with 800tps of connection refused exceptions. I was surprised then to see that it started falling behind in handling the requests. After some debugging and adding monitoring for requests queue size, I discovered that it was the boss thread getting behind in the connection refused case because the exception is passed down through the handlers in the boss thread rather than being passed off to a worker. at 800tps this leaves 1.5ms for each transaction to be handled. Monitoring on the boss's request queue confirmed that it fell far behind (into the thousands). The code I submitted on this branch (tested on 3.2.6) seemed to alleviate the situation by letting me specify multiple boss threads. Thoughts?

I love this patch.  Thank you, Jeff.  This should be merged to both 3.2 and master.

I will take care...

Did a little bit of cleanup - https://github.com/netty/netty/commit/1ac6c75d39114a89dcc13cd712eb907b9938c2d8
I also backported this patch because it can fix client-side perf problem very easily when making a lot of connection attempt simultaneously.

Thanks Trustin/Norman.


Docker-compose-ARG CONTAINER_UID - issue

Describe the bug
ARG CONTAINER_UID is not getting set after using the command export UID && docker-compose up
How to Reproduce
RUN
export UID && docker-compose up

Expected behavior
Docker-compose should get successfully setting up with ARG CONTAINER_UID.
Your project
No response
Screenshots
Docker-image layers

Environment status in dataall console

OS
OS Name	Microsoft Windows 11 Enterprise, Version	10.0.22631 Build 22631
Python version
3.9
AWS data.all version
2.6.0
Additional context
I was able to run this in 2.0.0 but recently after moving to 2.6.0 I'm facing this issue.
At the time of creation of environment the below error is occurring.
2024-10-18 16:54:36 [11:24:36] outdir: cdk.out
2024-10-18 16:54:36 [11:24:36] Reading cached notices from /home/cuser/.cdk/cache/notices.json
2024-10-18 16:54:36 EACCES: permission denied, open 'cdk.out/synth.lock.235_1'
2024-10-18 16:54:36 [11:24:36] Error: EACCES: permission denied, open 'cdk.out/synth.lock.235_1'
2024-10-18 16:54:36 Failed to deploy stack 65quv3au due to None
2024-10-18 16:54:36 Failed to deploy stack 65quv3au due to 'NoneType' object has no attribute 'split'
2024-10-18 16:54:36 ERROR:    Exception in ASGI application
2024-10-18 16:54:36 Traceback (most recent call last):
2024-10-18 16:54:36   File "/./dataall/base/cdkproxy/cdk_cli_wrapper.py", line 193, in deploy_cdk_stack
2024-10-18 16:54:36     AlarmService().trigger_stack_deployment_failure_alarm(stack=stack)
2024-10-18 16:54:36   File "/./dataall/base/utils/alarm_service.py", line 30, in trigger_stack_deployment_failure_alarm
2024-10-18 16:54:36     https://{self.region}.console.aws.amazon.com/cloudwatch/deeplink.js?region=eu-west-1#logsV2:log-groups/log-group/$252Fdataall$252F{self.envname}$252Fecs$252Fcdkproxy/log-events/task$252Fcontainer$252F{stack.EcsTaskArn.split('/')[-1]}
2024-10-18 16:54:36 AttributeError: 'NoneType' object has no attribute 'split'
2024-10-18 16:54:36
2024-10-18 16:54:36 During handling of the above exception, another exception occurred:
2024-10-18 16:54:36
2024-10-18 16:54:36 Traceback (most recent call last):
2024-10-18 16:54:36   File "/usr/local/lib/python3.9/site-packages/uvicorn/protocols/http/h11_impl.py", line 373, in run_asgi
2024-10-18 16:54:36     result = await app(self.scope, self.receive, self.send)
2024-10-18 16:54:36   File "/usr/local/lib/python3.9/site-packages/uvicorn/middleware/proxy_headers.py", line 75, in call
2024-10-18 16:54:36     return await self.app(scope, receive, send)
2024-10-18 16:54:36   File "/usr/local/lib/python3.9/site-packages/fastapi/applications.py", line 1054, in call
2024-10-18 16:54:36     await super().call(scope, receive, send)
2024-10-18 16:54:36   File "/usr/local/lib/python3.9/site-packages/starlette/applications.py", line 123, in call
2024-10-18 16:54:36     await self.middleware_stack(scope, receive, send)
2024-10-18 16:54:36   File "/usr/local/lib/python3.9/site-packages/starlette/middleware/errors.py", line 186, in call
2024-10-18 16:54:36     raise exc
2024-10-18 16:54:36   File "/usr/local/lib/python3.9/site-packages/starlette/middleware/errors.py", line 164, in call
2024-10-18 16:54:36     await self.app(scope, receive, _send)
2024-10-18 16:54:36   File "/usr/local/lib/python3.9/site-packages/starlette/middleware/exceptions.py", line 62, in call
2024-10-18 16:54:36     await wrap_app_handling_exceptions(self.app, conn)(scope, receive, send)
2024-10-18 16:54:36   File "/usr/local/lib/python3.9/site-packages/starlette/_exception_handler.py", line 64, in wrapped_app
2024-10-18 16:54:36     raise exc
2024-10-18 16:54:36   File "/usr/local/lib/python3.9/site-packages/starlette/_exception_handler.py", line 53, in wrapped_app
2024-10-18 16:54:36     await app(scope, receive, sender)
2024-10-18 16:54:36   File "/usr/local/lib/python3.9/site-packages/starlette/routing.py", line 758, in call
2024-10-18 16:54:36     await self.middleware_stack(scope, receive, send)
2024-10-18 16:54:36   File "/usr/local/lib/python3.9/site-packages/starlette/routing.py", line 778, in app
2024-10-18 16:54:36     await route.handle(scope, receive, send)
2024-10-18 16:54:36   File "/usr/local/lib/python3.9/site-packages/starlette/routing.py", line 299, in handle
2024-10-18 16:54:36     await self.app(scope, receive, send)
2024-10-18 16:54:36   File "/usr/local/lib/python3.9/site-packages/starlette/routing.py", line 79, in app
2024-10-18 16:54:36     await wrap_app_handling_exceptions(app, request)(scope, receive, send)
2024-10-18 16:54:36   File "/usr/local/lib/python3.9/site-packages/starlette/_exception_handler.py", line 64, in wrapped_app
2024-10-18 16:54:36     raise exc
2024-10-18 16:54:36   File "/usr/local/lib/python3.9/site-packages/starlette/_exception_handler.py", line 53, in wrapped_app
2024-10-18 16:54:36     await app(scope, receive, sender)
2024-10-18 16:54:36   File "/usr/local/lib/python3.9/site-packages/starlette/routing.py", line 77, in app
2024-10-18 16:54:36     await response(scope, receive, send)
2024-10-18 16:54:36   File "/usr/local/lib/python3.9/site-packages/starlette/responses.py", line 161, in call
2024-10-18 16:54:36     await self.background()
2024-10-18 16:54:36   File "/usr/local/lib/python3.9/site-packages/starlette/background.py", line 45, in call
2024-10-18 16:54:36     await task()
2024-10-18 16:54:36   File "/usr/local/lib/python3.9/site-packages/starlette/background.py", line 30, in call
2024-10-18 16:54:36     await run_in_threadpool(self.func, *self.args, **self.kwargs)
2024-10-18 16:54:36   File "/usr/local/lib/python3.9/site-packages/starlette/concurrency.py", line 42, in run_in_threadpool
2024-10-18 16:54:36     return await anyio.to_thread.run_sync(func, *args)
2024-10-18 16:54:36   File "/usr/local/lib/python3.9/site-packages/anyio/to_thread.py", line 56, in run_sync
2024-10-18 16:54:36     return await get_async_backend().run_sync_in_worker_thread(
2024-10-18 16:54:36   File "/usr/local/lib/python3.9/site-packages/anyio/_backends/_asyncio.py", line 2441, in run_sync_in_worker_thread
2024-10-18 16:54:36     return await future
2024-10-18 16:54:36   File "/usr/local/lib/python3.9/site-packages/anyio/_backends/_asyncio.py", line 943, in run
2024-10-18 16:54:36     result = context.run(func, *args)
2024-10-18 16:54:36   File "/./dataall/base/cdkproxy/cdk_cli_wrapper.py", line 197, in deploy_cdk_stack
2024-10-18 16:54:36     AlarmService().trigger_stack_deployment_failure_alarm(stack=stack)
2024-10-18 16:54:36   File "/./dataall/base/utils/alarm_service.py", line 30, in trigger_stack_deployment_failure_alarm
2024-10-18 16:54:36     https://{self.region}.console.aws.amazon.com/cloudwatch/deeplink.js?region=eu-west-1#logsV2:log-groups/log-group/$252Fdataall$252F{self.envname}$252Fecs$252Fcdkproxy/log-events/task$252Fcontainer$252F{stack.EcsTaskArn.split('/')[-1]}
2024-10-18 16:54:36 AttributeError: 'NoneType' object has no attribute 'split'

Hi @sushant010 - I just tried to replicate this error and am not running into the same issues as above. Since v2.0 we drilled down permissioning of the local container images to no longer run as root. Can you ensure the following:

Env Variable of UID is properly set before starting docker container (for windows I believe it will be set UID=VALUE instead of export
Re build the container by running docker compose up --build to ensure all latest changes reflected

Hi @noah-paige,
Can you please let us know what's the value of VALUE?

Hi @noah-paige,
The UID value is properly set but after rebuilding the container the above mentioned error persists,  at the time of creation of environment, stack deployment is failing.
Error -- (Same can be found in additional context)
2024-10-18 16:54:36 [11:24:36] outdir: cdk.out
2024-10-18 16:54:36 [11:24:36] Reading cached notices from /home/cuser/.cdk/cache/notices.json
2024-10-18 16:54:36 EACCES: permission denied, open 'cdk.out/synth.lock.235_1'
2024-10-18 16:54:36 [11:24:36] Error: EACCES: permission denied, open 'cdk.out/synth.lock.235_1'
2024-10-18 16:54:36 Failed to deploy stack 65quv3au due to None
2024-10-18 16:54:36 Failed to deploy stack 65quv3au due to 'NoneType' object has no attribute 'split'

@sushant010 - do you have exists cdk.out directory at dataall/backend/dataall/base/cdkproxy/cdk.out - if so could you remove and try again looks like permissions to open that directory are not there may have been created before use of docker user

It worked @noah-paige.
Thanks a lot!!

no problem @sushant010 - closing this issue as resolved!


Add Projects API

Describe the changes you have made in this PR -

Adds the following projects endpoints:

api/v1/projects to fetch all public or user accessible projects.
api/v1/users/:id/projects to fetch user specific projects.
api/v1/projects/:id to GET, UPDATE & DELETE project details.
api/v1/projects/featured to fetch featured projects.
api/v1/projects/:id/toggle-star to star/unstar a project.
api/v1/projects/:id/fork to fork a project.

Add project/projects schema.

Add specs for each of the projects controller actions.

The updated docs are available here
Note: Please check Allow edits from maintainers. if you would like us to assist in the PR.

Coverage increased (+1.02%) to 84.086% when pulling 64a930c50bb9ce275e3555b872c4bccdfba86fe1 on Nitish145:projects_api into 42497fa40b902e78b98fa4346c135876ac694e29 on CircuitVerse:master.

@tachyons please check!!

@tachyons please check!!

Awesome 🎉


Temporal API

Temporal is a stage 3 proposal for fixing date problems in JS. Would you accept PR for implementing it in js_sys, for example under cfg(js_sys_unstable) ?

Seems reasonable to me to add as unstable!


WIP - Parallel build index

Converted this WIP branch into a WIP PR, to make it easier to collaborate on in the interim.

From code inspection, here are the places I can think of that might cause a problem when called from multiple threads at the same time:

khCache (you've already handled this)
parentsToNotify and listenersToNotify in AssetVersionD.h. If I understand how the code works correctly, the code that is being parallelized never adds items to either of these, so we should be OK, but technically they are being used from multiple threads at the same time
The dirtyMaps in MutableAssetHandleD_. There could be trouble in MutalbeAssetHandleD_::OnBind or khAssetManager::ApplyPending was called from different threads at the same time.
Asset::cache and AssetVersion::cache - you could end up with two different caches if these were called concurrently. With the code we're parallelizing the caches will certainly have been created before multiple threads start running, but it might be wise to be safe.
Any of the Asset::DoBind or AssetVersion::DoBind functions. Those are thread safe already because the cache is thread safe, but if it was called twice at the same time you could end up loading the asset from disk multiple times and have duplicate assets in memory. I think everything would work correctly even if this happened, but it's probably best to protect against it.

I'm definitely getting some missing inputs in the packgen khassetver.xml files.

I can't say that there are obviously no problems with this PR, but there are no obvious problems.

I've tested the latest updates and the xml files come out the same in parallel and in serial (not counting things like times and unique IDs). The binary files, however, are pretty different, and I noticed in one of the log files that at least one of the output files is a slightly different size. I don't know if that means anything, but it does worry me a bit.


refactor: refactoring for testing

Description
refactor: refactoring for testing
Type of change

[ ] Bug fix
[ ] New feature
[x] Refactoring (no functional changes, no api changes)
[x] Test (adding missing tests, correcting existing tests)
[ ] Code style update (typo, formatting, local variables)
[ ] Build related changes
[ ] CI related changes
[ ] Chore (etc)
[ ] Documentation content changes
[ ] Release new version

Whether Braking Changes
Does this PR contain breaking changes?

[ ] Yes
[x] NO

Checklist before merge

[x] Updating the dist folder

Checklist after merge

N/A

Codecov Report

Merging #22 (faf8eed) into main (ad3b637) will increase coverage by 30.58%.
The diff coverage is 100.00%.

@@             Coverage Diff              @@
##             main       #22       +/-   ##
============================================
+ Coverage   69.41%   100.00%   +30.58%
============================================
  Files           5         6        +1
  Lines         206       210        +4
  Branches       49        46        -3
============================================
+ Hits          143       210       +67
+ Misses         60         0       -60
+ Partials        3         0        -3

Impacted Files
Coverage Δ

src/classes/context.ts
100.00% <100.00%> (+39.13%)
:arrow_up:

src/classes/input-info.ts
100.00% <100.00%> (ø)

src/label-service.ts
100.00% <100.00%> (+33.70%)
:arrow_up:

src/labeler.ts
100.00% <100.00%> (ø)

... and 2 files with indirect coverage changes
:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more


move install next to ui kit

move: install section next to ui section. It's a bit of a context switch between trying to setup something technical, reading non-technical rules, then switching back.
Obviously, subjective. Feel free to close PR if not needed.

Current dependencies on/for this PR:

master

PR #1760

PR #1761   👈

This comment was auto-generated by Graphite.


Defining the same encoding twice doesn't give an error

The new backend framework doesn't use encodings.


feat(optimus): add api to list secrets, cleanup from last PR

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

26 of 28 (92.86%)  changed or added relevant lines in 1 file are covered.
No unchanged relevant lines lost coverage.
Overall coverage increased (+0.04%) to 71.534%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

api/handler/v1beta1/secret.go
26
28
92.86%

Totals

Change from base Build<PHONE_NUMBER>:
0.04%

Covered Lines:
5041

Relevant Lines:
7047

💛  - Coveralls


How to delete mailchimp list?

Couldn't find it in usage examples and tests.
mailchimp_client.lists(mailchimp_list_id).webhooks.delete(params: {id: '1694275d82'})

delete https://us1.api.mailchimp.com/3.0/lists/9912b072bb/webhooks?id=1694275d82
Content-Type: "application/json"
{"type":"http://developer.mailchimp.com/documentation/mailchimp/guides/error-glossary/","title":"Method Not Allowed","status":405,"detail":"The requested method and resource are not compatible. See the Allow header for this resource's available methods.","instance":""}

https://developer.mailchimp.com/documentation/mailchimp/reference/lists/webhooks/
API docs states that URL should be in form of DELETE /lists/{list_id}/webhooks/{webhook_id}
Long story short
expected request:

delete https://us1.api.mailchimp.com/3.0/lists/9912b072bb/webhooks/1694275d82

actual request:

delete https://us1.api.mailchimp.com/3.0/lists/9912b072bb/webhooks?id=1694275d82

Any tips?
Thanks

Yes. The issue is you've provided the id as a parameter instead of part of the path. Try this:
mailchimp_client.lists(mailchimp_list_id).webhooks("1694275d82").delete
I think that'll work though I'm not at my machine to try it at the moment.
Thanks,
Amro
Sent from my iPhone

On Aug 7, 2017, at 4:58 AM, Nikita Fedyashev<EMAIL_ADDRESS>wrote:
Couldn't find it in usage examples and tests.
mailchimp_client.lists(mailchimp_list_id).webhooks.delete(params: {id: '1694275d82'})
delete https://us1.api.mailchimp.com/3.0/lists/9912b072bb/webhooks?id=1694275d82
Content-Type: "application/json"
{"type":"http://developer.mailchimp.com/documentation/mailchimp/guides/error-glossary/","title":"Method Not Allowed","status":405,"detail":"The requested method and resource are not compatible. See the Allow header for this resource's available methods.","instance":""}
https://developer.mailchimp.com/documentation/mailchimp/reference/lists/webhooks/
API docs states that URL should be in form of DELETE /lists/{list_id}/webhooks/{webhook_id}
Long story short
expected request:
delete https://us1.api.mailchimp.com/3.0/lists/9912b072bb/webhooks/1694275d82
actual request:
delete https://us1.api.mailchimp.com/3.0/lists/9912b072bb/webhooks?id=1694275d82
Any tips?
Thanks
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub, or mute the thread.

@amro it worked! Thank you very much!


Need contact points exposed on collision Response object

Need contact points exposed on collision Response object. Needed for physics

I agree - unfortunately I currently don't have time to spend on any significant changes to this library. I would take a look at a pull request though (maybe exposed as a method on the SAT.Response object?
It should be possible to compute a contact manifold (e.g in our case either a point or a line) using a method like this: http://www.dyn4j.org/2011/11/contact-points-using-clipping/ - the overlapN and overlap in the SAT.Response are the "separation normal" and "depth" that the article talks about getting back from the collision detection phase.


user json-server with lowdb

you say : " if you make POST, PUT, PATCH or DELETE requests, changes will be automatically and safely saved to db.json using lowdb.",how to use json-server with lowdb ,can you write a demo ? thank you ,I can not use lowdb for automatically save to db.json

Actually, you have nothing to do.
{
  "posts": []
}

json-server db.json

Make a POST request to http://localhost:3000/posts with {"body": "test"} and if you check db.json, you'll see that it's been updated.
{
  "posts": [
    {
      "id": 1,
      "body": "test"
    }
  ]
}

You can check this video tutorial too:
https://egghead.io/lessons/nodejs-creating-demo-apis-with-json-server

Thank you ！I succeeded！

Great :)


[Web]: Difference in asset rendering using canvasKit and html on Windows

Steps to Reproduce

Run flutter create bug.
Update the files as follows: add any image.png  under res/image.png and add it on pubspec.yaml, paste the following code:

import 'package:flutter/material.dart';

void main() {
  runApp(MyApp());
}

class MyApp extends StatelessWidget {
  @override
  Widget build(BuildContext context) {
    return MaterialApp(
      home: MyHomePage(),
    );
  }
}

class MyHomePage extends StatelessWidget {
  @override
  Widget build(BuildContext context) {
    return Scaffold(
      body: Center(
        child: Image.asset('res/image.png', width: 40,)
      ),
    );
  }
}

Run: flutter run -d chrome --web-renderer canvaskit

Actual results:
The border of the image is really pixelated, it looks like a low resolution image (which is not)

Expected results:
The result I am expecting is the result that I get with: flutter run -d chrome --web-renderer html

You can spot this behaviour just with image asset. With icons everything is good.

flutter doctor -v
[√] Flutter (Channel beta, 1.26.0-17.6.pre, on Microsoft Windows [Versione 10.0.19042.804], locale it-IT)
    • Flutter version 1.26.0-17.6.pre at C:\flutter
    • Framework revision a29104a69b (15 hours ago), 2021-02-16 09:26:56 -0800
    • Engine revision 21fa8bb99e
    • Dart version 2.12.0 (build 2.12.0-259.12.beta)
[√] Android toolchain - develop for Android devices (Android SDK version 30.0.3)
    • Android SDK at C:\Users\Damia\AppData\Local\Android\sdk
    • Platform android-30, build-tools 30.0.3
    • Java binary at: C:\Program Files\Android\Android Studio\jre\bin\java
    • Java version OpenJDK Runtime Environment (build 1.8.0_242-release-1644-b01)
    • All Android licenses accepted.
[√] Chrome - develop for the web
    • Chrome at C:\Program Files (x86)\Google\Chrome\Application\chrome.exe
[√] Android Studio (version 4.1.0)
    • Android Studio at C:\Program Files\Android\Android Studio
    • Flutter plugin can be installed from:
       https://plugins.jetbrains.com/plugin/9212-flutter
    • Dart plugin can be installed from:
       https://plugins.jetbrains.com/plugin/6351-dart
    • Java version OpenJDK Runtime Environment (build 1.8.0_242-release-1644-b01)
[√] VS Code (version 1.53.2)
    • VS Code at C:\Users\Damia\AppData\Local\Programs\Microsoft VS Code
    • Flutter extension version 3.19.0
[√] Connected device (2 available)
    • Chrome (web) • chrome • web-javascript • Google Chrome 88.0.4324.150
    • Edge (web)   • edge   • web-javascript • Microsoft Edge 88.0.705.68
• No issues found!

This happens also on my web app, if you open it and open the drawer you will see that the icons looks like low resolution (just on desktop).

@ferraridamiano
I verified this issue on latest master with a sample asset and rendered using canvaskit. I didn't see any difference in rendering.

Left is canvaskit, right is html.
Can you switch to latest master and try again with the image you have and see if issue persists or no ?  There were few canvaskit issues fixed recently and merged in master and may not have landed in beta yet.

flutter doctor -v
[✓] Flutter (Channel master, 1.27.0-2.0.pre.126, on Mac OS X 10.15.4 19E2269 darwin-x64, locale en-IN)
    • Flutter version 1.27.0-2.0.pre.126 at /Users/dhs/documents/Fluttersdk/flutter
    • Framework revision 50897c98fc (5 hours ago), 2021-02-16 20:13:53 -0800
    • Engine revision 9bcb3bfb0e
    • Dart version 2.13.0 (build 2.13.0-30.0.dev)

[✓] Android toolchain - develop for Android devices (Android SDK version 30.0.0)
    • Android SDK at /Users/dhs/Library/Android/sdk
    • Platform android-30, build-tools 30.0.0
    • Java binary at: /Applications/Android Studio.app/Contents/jre/jdk/Contents/Home/bin/java
    • Java version OpenJDK Runtime Environment (build 1.8.0_242-release-1644-b3-6915495)
    • All Android licenses accepted.

[!] Xcode - develop for iOS and macOS
    • Xcode at /Applications/Xcode.app/Contents/Developer
    • Xcode 12.3, Build version 12C33
    ! CocoaPods 1.9.3 out of date (1.10.0 is recommended).
        CocoaPods is used to retrieve the iOS and macOS platform side's plugin code that responds to
        your plugin usage on the Dart side.
        Without CocoaPods, plugins will not work on iOS or macOS.
        For more info, see https://flutter.dev/platform-plugins
      To upgrade see https://guides.cocoapods.org/using/getting-started.html#installation for
      instructions.

[✓] Chrome - develop for the web
    • Chrome at /Applications/Google Chrome.app/Contents/MacOS/Google Chrome

[✓] Android Studio (version 4.1)
    • Android Studio at /Applications/Android Studio.app/Contents
    • Flutter plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/9212-flutter
    • Dart plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/6351-dart
    • Java version OpenJDK Runtime Environment (build 1.8.0_242-release-1644-b3-6915495)

[✓] VS Code (version 1.53.0)
    • VS Code at /Applications/Visual Studio Code.app/Contents
    • Flutter extension version 3.18.1

[✓] Connected device (4 available)
    • SM A260G (mobile)                  • 5200763ebcfa861f • android-arm    • Android 8.1.0 (API 27)
    • Android SDK built for x86 (mobile) • emulator-5556    • android-x86    • Android 8.1.0 (API 27)
      (emulator)
    • macOS (desktop)                    • macos            • darwin-x64     • Mac OS X 10.15.4 19E2269
      darwin-x64
    • Chrome (web)                       • chrome           • web-javascript • Google Chrome
      88.0.4324.150

! Doctor found issues in 1 category.

Hi @darshankawar, the issue exists also on master branch. It happens when you resize the image to be smaller, try with flutter logo and set width: 200

Left is html, right is canvaskit. Can you spot the difference?

@ferraridamiano
Thanks. I can clearly spot the difference between the images you shared above.
I tried with a flutter logo png on latest beta as well as on master and by resizing it to 150 and 200, but still unable to see any difference.  Maybe I need to wear glasses :-))

First is canvaskit, below is html.

flutter doctor -v
[✓] Flutter (Channel master, 1.27.0-2.0.pre.126, on Mac OS X 10.15.4 19E2269 darwin-x64, locale en-IN)
    • Flutter version 1.27.0-2.0.pre.126 at /Users/dhs/documents/Fluttersdk/flutter
    • Framework revision 50897c98fc (7 hours ago), 2021-02-16 20:13:53 -0800
    • Engine revision 9bcb3bfb0e
    • Dart version 2.13.0 (build 2.13.0-30.0.dev)

[✓] Android toolchain - develop for Android devices (Android SDK version 30.0.0)
    • Android SDK at /Users/dhs/Library/Android/sdk
    • Platform android-30, build-tools 30.0.0
    • Java binary at: /Applications/Android Studio.app/Contents/jre/jdk/Contents/Home/bin/java
    • Java version OpenJDK Runtime Environment (build 1.8.0_242-release-1644-b3-6915495)
    • All Android licenses accepted.

[!] Xcode - develop for iOS and macOS
    • Xcode at /Applications/Xcode.app/Contents/Developer
    • Xcode 12.3, Build version 12C33
    ! CocoaPods 1.9.3 out of date (1.10.0 is recommended).
        CocoaPods is used to retrieve the iOS and macOS platform side's plugin code that responds to
        your plugin usage on the Dart side.
        Without CocoaPods, plugins will not work on iOS or macOS.
        For more info, see https://flutter.dev/platform-plugins
      To upgrade see https://guides.cocoapods.org/using/getting-started.html#installation for
      instructions.

[✓] Chrome - develop for the web
    • Chrome at /Applications/Google Chrome.app/Contents/MacOS/Google Chrome

[✓] Android Studio (version 4.1)
    • Android Studio at /Applications/Android Studio.app/Contents
    • Flutter plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/9212-flutter
    • Dart plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/6351-dart
    • Java version OpenJDK Runtime Environment (build 1.8.0_242-release-1644-b3-6915495)

[✓] VS Code (version 1.53.0)
    • VS Code at /Applications/Visual Studio Code.app/Contents
    • Flutter extension version 3.18.1

[✓] Connected device (3 available)
    • sdk gphone x86 arm (mobile) • emulator-5554 • android-x86    • Android 11 (API 30) (emulator)
    • macOS (desktop)             • macos         • darwin-x64     • Mac OS X 10.15.4 19E2269 darwin-x64
    • Chrome (web)                • chrome        • web-javascript • Google Chrome 88.0.4324.150

! Doctor found issues in 1 category.

Can you share the images you are using, so that I can try with those and see if I succeed ?

It is very strange! Everything is the same of you, except for the OS.
Here you can download the 2 images I used
I set termometer to width: 40 and flutter logo to width: 200

flutter doctor -v
[√] Flutter (Channel master, 1.27.0-2.0.pre.126, on Microsoft Windows [Versione 10.0.19042.804], locale it-IT)
    • Flutter version 1.27.0-2.0.pre.126 at C:\flutter
    • Framework revision 50897c98fc (8 hours ago), 2021-02-16 20:13:53 -0800
    • Engine revision 9bcb3bfb0e
    • Dart version 2.13.0 (build 2.13.0-30.0.dev)

[√] Android toolchain - develop for Android devices (Android SDK version 30.0.3)
    • Android SDK at C:\Users\Damia\AppData\Local\Android\sdk
    • Platform android-30, build-tools 30.0.3
    • Java binary at: C:\Program Files\Android\Android Studio\jre\bin\java
    • Java version OpenJDK Runtime Environment (build 1.8.0_242-release-1644-b01)
    • All Android licenses accepted.

[√] Chrome - develop for the web
    • Chrome at C:\Program Files (x86)\Google\Chrome\Application\chrome.exe

[√] Visual Studio - develop for Windows (Visual Studio Community 2019 16.7.4)
    • Visual Studio at C:\Program Files (x86)\Microsoft Visual Studio\2019\Community
    • Visual Studio Community 2019 version 16.7.30517.126
    • Windows 10 SDK version 10.0.18362.0

[√] Android Studio (version 4.1.0)
    • Android Studio at C:\Program Files\Android\Android Studio
    • Flutter plugin can be installed from:
       https://plugins.jetbrains.com/plugin/9212-flutter
    • Dart plugin can be installed from:
       https://plugins.jetbrains.com/plugin/6351-dart
    • Java version OpenJDK Runtime Environment (build 1.8.0_242-release-1644-b01)

[√] VS Code (version 1.53.2)
    • VS Code at C:\Users\Damia\AppData\Local\Programs\Microsoft VS Code
    • Flutter extension version 3.19.0

[√] Connected device (3 available)
    • Windows (desktop) • windows • windows-x64    • Microsoft Windows [Versione 10.0.19042.804]
    • Chrome (web)      • chrome  • web-javascript • Google Chrome 88.0.4324.150
    • Edge (web)        • edge    • web-javascript • Microsoft Edge 88.0.705.68

• No issues found!

Thanks for providing images @ferraridamiano. Tried both images with width as you mentioned, but still rendered properly. Top is canvaskit and below it is html respectively.

Since you are on Windows, it may be the factor. Since I don't have Windows machine to verify, I am keeping this issue open for further investigation.

flutter doctor -v
[✓] Flutter (Channel beta, 1.26.0-17.6.pre, on Mac OS X 10.15.4 19E2269
    darwin-x64, locale en-IN)
    • Flutter version 1.26.0-17.6.pre at /Users/dhs/documents/Fluttersdk/flutter
    • Framework revision a29104a69b (19 hours ago), 2021-02-16 09:26:56 -0800
    • Engine revision 21fa8bb99e
    • Dart version 2.12.0 (build 2.12.0-259.12.beta)

[✓] Android toolchain - develop for Android devices (Android SDK version 30.0.0)
    • Android SDK at /Users/dhs/Library/Android/sdk
    • Platform android-30, build-tools 30.0.0
    • Java binary at: /Applications/Android
      Studio.app/Contents/jre/jdk/Contents/Home/bin/java
    • Java version OpenJDK Runtime Environment (build
      1.8.0_242-release-1644-b3-6915495)
    • All Android licenses accepted.

[!] Xcode - develop for iOS and macOS
    • Xcode at /Applications/Xcode.app/Contents/Developer
    • Xcode 12.3, Build version 12C33
    ! CocoaPods 1.9.3 out of date (1.10.0 is recommended).
        CocoaPods is used to retrieve the iOS and macOS platform side's plugin
        code that responds to your plugin usage on the Dart side.
        Without CocoaPods, plugins will not work on iOS or macOS.
        For more info, see https://flutter.dev/platform-plugins
      To upgrade see
      https://guides.cocoapods.org/using/getting-started.html#installation for
      instructions.

[✓] Chrome - develop for the web
    • Chrome at /Applications/Google Chrome.app/Contents/MacOS/Google Chrome

[✓] Android Studio (version 4.1)
    • Android Studio at /Applications/Android Studio.app/Contents
    • Flutter plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/9212-flutter
    • Dart plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/6351-dart
    • Java version OpenJDK Runtime Environment (build
      1.8.0_242-release-1644-b3-6915495)

[✓] VS Code (version 1.53.0)
    • VS Code at /Applications/Visual Studio Code.app/Contents
    • Flutter extension version 3.18.1

[✓] Connected device (3 available)
    • SM G975F (mobile)           • RZ8M802WY0X   • android-arm64  • Android 10
      (API 29)
    • sdk gphone x86 arm (mobile) • emulator-5554 • android-x86    • Android 11
      (API 30) (emulator)
    • Chrome (web)                • chrome        • web-javascript • Google
      Chrome 88.0.4324.150

! Doctor found issues in 1 category.

Thank you!
Here I published a repo with the above issue:
https://github.com/ferraridamiano/demoBugCanvasKit

I recently landed a fix for a similar issue (https://github.com/flutter/flutter/issues/73714), so I expected this to be fully fixed, although I haven't tried a Windows computer. I'll take a look.

I can reproduce an issue on Windows (I think it depends more on the monitor than on the OS), although I'm not sure it manifests as described here. What I'm seeing is that FilterQuality.medium looks higher quality than FilterQuality.high. For example, look at the downscaled thermometer icon below. Notice that the second last (medium quality) looks better than the last one (high quality):

Deployed build: https://yjbanov.web.app/issues/76187/#/
Code:
import 'package:flutter/material.dart';

void main() {
  runApp(MyApp());
}

class MyApp extends StatelessWidget {
  @override
  Widget build(BuildContext context) {
    return MaterialApp(
      home: MyHomePage(),
    );
  }
}

class MyHomePage extends StatelessWidget {
  @override
  Widget build(BuildContext context) {
    return Scaffold(
      body: Row(
        children: [
          Column(
            children: [
              Image.asset('res/logo.jpg', width: 200, filterQuality: FilterQuality.none),
              Image.asset('res/logo.jpg', width: 200, filterQuality: FilterQuality.low),
              Image.asset('res/logo.jpg', width: 200, filterQuality: FilterQuality.medium),
              Image.asset('res/logo.jpg', width: 200, filterQuality: FilterQuality.high),
            ],
          ),
          Column(
            children: [
              Image.asset('res/temperatura.png', width: 200, filterQuality: FilterQuality.none),
              Image.asset('res/temperatura.png', width: 200, filterQuality: FilterQuality.low),
              Image.asset('res/temperatura.png', width: 200, filterQuality: FilterQuality.medium),
              Image.asset('res/temperatura.png', width: 200, filterQuality: FilterQuality.high),
            ],
          ),
          Column(
            children: [
              SizedBox(width: 30, height: 30, child: Image.asset('res/temperatura.png', width: 200, filterQuality: FilterQuality.none)),
              SizedBox(width: 30, height: 30, child: Image.asset('res/temperatura.png', width: 200, filterQuality: FilterQuality.low)),
              SizedBox(width: 30, height: 30, child: Image.asset('res/temperatura.png', width: 200, filterQuality: FilterQuality.medium)),
              SizedBox(width: 30, height: 30, child: Image.asset('res/temperatura.png', width: 200, filterQuality: FilterQuality.high)),
            ],
          ),
        ],
      ),
    );
  }
}

@ferraridamiano as a workaround, try using FilterQuality.medium on the image. In the meantime, I'll ping the Skia team.

So, it looks like this works as intended. Our "medium" and "high" may be misleading. What's happening is that the scaling algorithm used for "high" is better than "medium" when scaling up. However, when scaling down, frequently "medium" is better than "high". I'm going to document this better in our API docs.
Long-term the Skia team is recommending that we expose sampling API directly, giving more precise control than what the current FilterQuality enum provides. I'm going to file a separate issue for that.


⚠ Bofrost.fr has degraded performance

In 60d566d, Bofrost.fr (https://www.bofrost.fr) experienced degraded performance:

HTTP code: 200
Response time: 1132 ms

Resolved: Bofrost.fr performance has improved in 2b3ea46.


path.existsSync -> fs.existsSync

path.existsSync is deprecated in favour of fs.existsSync.

Hey!
I like this package a lot. It really works well. The only thing that bugs me is the warning message that node prints out due to the use of deprecated api. It would be great if this PR could be merged and a new version published.
Thanks a lot!
Michel

In node 0.12.0 path.existsSync has disappeared. It would be great if this pull request could be merged, otherwise the package can't be used in node 0.12.0

@Rob--W You may want to move that commit to a topic branch so that the pull request doesn't include unrelated commits from your master branch. (e.g. Create a branch label at 080afe8c5ceab, push to GitHub, and create a PR for that.)

@Krinkle The second commit was required for my use case, I had to pass extra options. If the maintainer of this repo feels that only the other commit is necessary, they're free to cherry-pick the first commit and omit the second one.

@Rob--W I tested your fork and it works pretty well. Since the original author doesn't seem to maintain this package anymore, how about uploading your version under a new name (xvfb2) to the npm registry? Or maybe you can contact the npm guys and ask them if you could be added as a maintainer to the xvfb package. WDYT?
Cheers,
Michel

@michel-kraemer Is it even possible to take ownership of a package without the owner's consent? If not, then publishing as xvfb2 wouldn't be a terrible idea. Meanwhile, you can include a specific version of my (tag-less) fork by the hash, e.g. as done here: https://github.com/CodeYellowBV/run-headless-chromium/blob/6f9839387334b60b65325e61d0185b958bf03e16/package.json

Yes, I just did that. Works fine.
You may contact the author by mail if he doesn't read this thread. I usually prefer to contribute to existing projects instead of starting new ones but since the last change was in 2012... Let's see if he answers.

I am now the new maintainer of xvfb, and have just published the latest version (with my patches) as<EMAIL_ADDRESS>It is fully backwards-compatible with 0.2.1, except when xvfb is not installed. In 0.2.0, Node would terminate because the spawn failure triggered an uncatcheable error. In 0.2.1, the library catches the error and passes the error to the callback (https://github.com/Rob--W/node-xvfb/commit/1c518a9ab06d8e558659bcc3689f6ed8e0e38642).

Great. Thank you so much!


[PYSPARK] [CONNECT] [ML] PySpark UDF supports python package dependencies

What changes were proposed in this pull request?
Make the pyspark UDF support annotating python dependencies and when executing UDF, the UDF worker creates a new python environment with provided python dependencies.

Supported spark mode: spark connect model / legacy mode
Supported UDF type: All kinds of pyspark UDFs

SQL_BATCHED_UDF
SQL_SCALAR_PANDAS_UDF
SQL_GROUPED_MAP_PANDAS_UDF
SQL_GROUPED_AGG_PANDAS_UDF
SQL_WINDOW_AGG_PANDAS_UDF
SQL_SCALAR_PANDAS_ITER_UDF
SQL_MAP_PANDAS_ITER_UDF
SQL_COGROUPED_MAP_PANDAS_UDF
SQL_MAP_ARROW_ITER_UDF
SQL_GROUPED_MAP_PANDAS_UDF_WITH_STATE

Implementation sketch

Before starting the pyspark UDF worker process, the python environment with provided python packages is created, and pyspark UDF worker process is spawned using the provided python environment instead of default configured pyspark python.
Using virtualenv to create a python environment based on current python environment that pyspark uses, then using pip install to install provided python packages.
If user configures a NFS directory that is accessible by all spark nodes (readable/writable to spark driver, readable to all spark workers), then it prepares the python environment in driver side, otherwise it creates the python environment in spark worker side.
The python environment is cached in spark driver or worker side (depending on NFS directory enabled or not), we uses SHA1 over sorted pip requirements list as the python environment caching key.

TODOs

For chained UDF functions, if they have different pip_requirements settings, we need to split them into separate PythonRunners
In frontend, the PR currently only supports annotating pip_requirements for pandas_udf, but for other types of UDFs, and for mapInPandas / mapInArrow the pip_requirements argument haven't been added.
Supports annotating python version for pyspark UDF, and in UDF execution, downloading python using provided python version and creating python environment using provided python version.
Using file lock during python environment creation, to avoid race conditions.
Unit tests

Why are the changes needed?

For spark connect case, the client python environment is very likely to be different with pyspark server side python environment, this causes user's UDF function execution failure in pyspark server side.
Some machine learning third-party library (e.g. MLflow) requires pyspark UDF supporting  dependencies, because in ML cases, we need to run model inference by pyspark UDF in the exactly the same python environment that trains the model. Currently MLflow supports it by creating a child python process in pyspark UDF worker, and redirecting all UDF input data to the child python process to run model inference, this way it causes significant overhead, if pyspark UDF support builtin python dependency management then we don't need such poorly performing approach.

Does this PR introduce any user-facing change?

@pandas_udf("string", pip_requirements=...)

pip_requirements argument means either an iterable of pip requirement strings (e.g. ["scikit-learn", "-r /path/to/req2.txt", "-c /path/to/constraints.txt"]) or the string path to a pip requirements file path on the local filesystem (e.g. "/path/to/requirements.txt") represents the pip requirements for the python UDF.
How was this patch tested?
Unit tests to be added.
Manually tests:
import pandas as pd
from pyspark.sql.functions import pandas_udf

sc.setLogLevel("INFO")

@pandas_udf("string", pip_requirements=["PyYAML==6.0"])
def to_upper(s: pd.Series) -> pd.Series:
    import yaml
    return s.str.upper() + f"yaml-version: {yaml.__version__}"

df = spark.createDataFrame([("John Doe",)], ("name",))
df.select(to_upper("name")).show(truncate=False)

Run above code in spark legacy mode or spark connect mode.

also cc @cloud-fan @hvanhovell


Build error with GCC v13

Describe the bug
After lasest updates, I get a compilation error on my system, similar to below:
FAILED: src/grt/src/fastroute/CMakeFiles/FastRoute4.1.dir/src/FastRoute.cpp.o
/usr/bin/x86_64-pc-linux-gnu-g++ -DFMT_SHARED -DSPDLOG_COMPILED_LIB -DSPDLOG_FMT_EXTERNAL -DSPDLOG_SHARED_LIB -I/var/tmp/portage/sci-electronics/openroad-9999/work/openroad-9999/src/grt/src/fastroute/include -I/var/tmp/portage/sci-electronics/openroad-9999/work/openroad-9999/src/grt/src/fastroute/../../include -I/var/tmp/portage/sci-electronics/openroad-9999/work/openroad-9999/src/utl/include -I/var/tmp/portage/sci-electronics/openroad-9999/work/openroad-9999/src/utl/src -I/var/tmp/portage/sci-electronics/openroad-9999/work/openroad-9999/src/stt/include -I/var/tmp/portage/sci-electronics/openroad-9999/work/openroad-9999/src/sta/include -I/var/tmp/portage/sci-electronics/openroad-9999/work/openroad-9999/src/odb/include -I/var/tmp/portage/sci-electronics/openroad-9999/work/openroad-9999/src/odb/include/odb -I/var/tmp/portage/sci-electronics/openroad-9999/work/openroad-9999/src/odb/src/def/def -I/var/tmp/portage/sci-electronics/openroad-9999/work/openroad-9999/src/odb/src/def/defzlib -I/var/tmp/portage/sci-electronics/openroad-9999/work/openroad-9999/src/odb/src/lef/lef -I/var/tmp/portage/sci-electronics/openroad-9999/work/openroad-9999/src/odb/src/lef/lefzlib  -fPIC -DFMT_DEPRECATED_OSTREAM=1 -std=c++17 -Wall -Wredundant-decls -Wformat-security -Wno-sign-compare -Wp,-D_GLIBCXX_ASSERTIONS -MD -MT src/grt/src/fastroute/CMakeFiles/FastRoute4.1.dir/src/FastRoute.cpp.o -MF src/grt/src/fastroute/CMakeFiles/FastRoute4.1.dir/src/FastRoute.cpp.o.d -o src/grt/src/fastroute/CMakeFiles/FastRoute4.1.dir/src/FastRoute.cpp.o -c /var/tmp/portage/sci-electronics/openroad-9999/work/openroad-9999/src/grt/src/fastroute/src/FastRoute.cpp
In file included from /var/tmp/portage/sci-electronics/openroad-9999/work/openroad-9999/src/grt/src/fastroute/include/FastRoute.h:46,
                 from /var/tmp/portage/sci-electronics/openroad-9999/work/openroad-9999/src/grt/src/fastroute/src/FastRoute.cpp:37:
/var/tmp/portage/sci-electronics/openroad-9999/work/openroad-9999/src/grt/src/fastroute/include/DataType.h:43:20: error: ‘int64_t’ in namespace ‘std’ does not name a type
   43 | using int64 = std::int64_t;
      |                    ^~~~~~~

To fix it, need to add next line into file "src/grt/src/fastroute/include/DataType.h":
#include <cstdint>

Expected Behavior
Successfully build.
Environment
Unknown git commit, this is not a git repository.

Please make sure that you have the latest code changes and add the commit
hash in the description.

kernel: Linux 6.1.31-gentoo-x86_64
os: Gentoo
cmake version 3.26.3
CMake Warning at CMakeLists.txt:99 (message):
  OpenROAD git describe failed, using sha1 instead

-- The CXX compiler identification is GNU 13.1.1
-- Detecting CXX compiler ABI info
-- Detecting CXX compiler ABI info - done
-- Check for working CXX compiler: /usr/bin/c++ - skipped
-- Detecting CXX compile features
-- Detecting CXX compile features - done
-- OpenROAD version: ca2e30f462bc0274bedf0643c1ee8dbc21e2723a
-- System name: Linux
-- Compiler: GNU 13.1.1
-- Build type:
-- Install prefix: /usr/local
-- C++ Standard: 17
-- C++ Standard Required: ON
-- C++ Extensions: OFF
-- Found GTest: /usr/lib64/cmake/GTest/GTestConfig.cmake (found version "1.13.0")
-- The C compiler identification is GNU 13.1.1
-- Detecting C compiler ABI info
-- Detecting C compiler ABI info - done
-- Check for working C compiler: /usr/bin/cc - skipped
-- Detecting C compile features
-- Detecting C compile features - done
-- Performing Test C_COMPILER_SUPPORTS__-Wall
-- Performing Test C_COMPILER_SUPPORTS__-Wall - Success
-- Performing Test CXX_COMPILER_SUPPORTS__-Wall
-- Performing Test CXX_COMPILER_SUPPORTS__-Wall - Success
-- Performing Test C_COMPILER_SUPPORTS__-Wno-array-bounds
-- Performing Test C_COMPILER_SUPPORTS__-Wno-array-bounds - Success
-- Performing Test CXX_COMPILER_SUPPORTS__-Wno-array-bounds
-- Performing Test CXX_COMPILER_SUPPORTS__-Wno-array-bounds - Success
-- Performing Test C_COMPILER_SUPPORTS__-Wno-nonnull
-- Performing Test C_COMPILER_SUPPORTS__-Wno-nonnull - Success
-- Performing Test CXX_COMPILER_SUPPORTS__-Wno-nonnull
-- Performing Test CXX_COMPILER_SUPPORTS__-Wno-nonnull - Success
-- Performing Test C_COMPILER_SUPPORTS__-Wno-maybe-uninitialized
-- Performing Test C_COMPILER_SUPPORTS__-Wno-maybe-uninitialized - Success
-- Performing Test CXX_COMPILER_SUPPORTS__-Wno-maybe-uninitialized
-- Performing Test CXX_COMPILER_SUPPORTS__-Wno-maybe-uninitialized - Success
-- Performing Test C_COMPILER_SUPPORTS__-Wno-format-overflow
-- Performing Test C_COMPILER_SUPPORTS__-Wno-format-overflow - Success
-- Performing Test CXX_COMPILER_SUPPORTS__-Wno-format-overflow
-- Performing Test CXX_COMPILER_SUPPORTS__-Wno-format-overflow - Success
-- Performing Test C_COMPILER_SUPPORTS__-Wno-unused-variable
-- Performing Test C_COMPILER_SUPPORTS__-Wno-unused-variable - Success
-- Performing Test CXX_COMPILER_SUPPORTS__-Wno-unused-variable
-- Performing Test CXX_COMPILER_SUPPORTS__-Wno-unused-variable - Success
-- Performing Test C_COMPILER_SUPPORTS__-Wno-unused-function
-- Performing Test C_COMPILER_SUPPORTS__-Wno-unused-function - Success
-- Performing Test CXX_COMPILER_SUPPORTS__-Wno-unused-function
-- Performing Test CXX_COMPILER_SUPPORTS__-Wno-unused-function - Success
-- Performing Test C_COMPILER_SUPPORTS__-Wno-write-strings
-- Performing Test C_COMPILER_SUPPORTS__-Wno-write-strings - Success
-- Performing Test CXX_COMPILER_SUPPORTS__-Wno-write-strings
-- Performing Test CXX_COMPILER_SUPPORTS__-Wno-write-strings - Success
-- Performing Test C_COMPILER_SUPPORTS__-Wno-sign-compare
-- Performing Test C_COMPILER_SUPPORTS__-Wno-sign-compare - Success
-- Performing Test CXX_COMPILER_SUPPORTS__-Wno-sign-compare
-- Performing Test CXX_COMPILER_SUPPORTS__-Wno-sign-compare - Success
-- Performing Test C_COMPILER_SUPPORTS__-Wno-deprecated
-- Performing Test C_COMPILER_SUPPORTS__-Wno-deprecated - Success
-- Performing Test CXX_COMPILER_SUPPORTS__-Wno-deprecated
-- Performing Test CXX_COMPILER_SUPPORTS__-Wno-deprecated - Success
-- Performing Test C_COMPILER_SUPPORTS__-Wno-c++11-narrowing
-- Performing Test C_COMPILER_SUPPORTS__-Wno-c++11-narrowing - Failed
-- Performing Test CXX_COMPILER_SUPPORTS__-Wno-c++11-narrowing
-- Performing Test CXX_COMPILER_SUPPORTS__-Wno-c++11-narrowing - Failed
-- Performing Test C_COMPILER_SUPPORTS__-Wno-register
-- Performing Test C_COMPILER_SUPPORTS__-Wno-register - Failed
-- Performing Test CXX_COMPILER_SUPPORTS__-Wno-register
-- Performing Test CXX_COMPILER_SUPPORTS__-Wno-register - Success
-- Performing Test C_COMPILER_SUPPORTS__-Wno-format
-- Performing Test C_COMPILER_SUPPORTS__-Wno-format - Success
-- Performing Test CXX_COMPILER_SUPPORTS__-Wno-format
-- Performing Test CXX_COMPILER_SUPPORTS__-Wno-format - CMake Warning at src/CMakeLists.txt:233 (message):
  spdlog: SPDLOG_FMT_EXTERNAL=yes

CMake Error at /usr/lib64/cmake/Boost-1.82.0/BoostConfig.cmake:141 (find_package):
  Found package configuration file:

    /usr/lib64/cmake/boost_serialization-1.82.0/boost_serialization-config.cmake

  but it set boost_serialization_FOUND to FALSE so package
  "boost_serialization" is considered to be NOT FOUND.  Reason given by
  package:

  No suitable build variant has been found.

  The following variants have been tried and rejected:

  * libboost_serialization.so.1.82.0 (shared, Boost_USE_STATIC_LIBS=ON)

Call Stack (most recent call first):
  /usr/lib64/cmake/Boost-1.82.0/BoostConfig.cmake:262 (boost_find_component)
  /usr/share/cmake/Modules/FindBoost.cmake:594 (find_package)
  src/drt/CMakeLists.txt:49 (find_package)

Success
-- Performing Test C_COMPILER_SUPPORTS__-Wno-reserved-user-defined-literal
-- Performing Test C_COMPILER_SUPPORTS__-Wno-reserved-user-defined-literal - Failed
-- Performing Test CXX_COMPILER_SUPPORTS__-Wno-reserved-user-defined-literal
-- Performing Test CXX_COMPILER_SUPPORTS__-Wno-reserved-user-defined-literal - Failed
-- Performing Test C_COMPILER_SUPPORTS__-fpermissive
-- Performing Test C_COMPILER_SUPPORTS__-fpermissive - Failed
-- Performing Test CXX_COMPILER_SUPPORTS__-fpermissive
-- Performing Test CXX_COMPILER_SUPPORTS__-fpermissive - Success
-- Performing Test C_COMPILER_SUPPORTS__-x
-- Performing Test C_COMPILER_SUPPORTS__-x - Failed
-- Performing Test CXX_COMPILER_SUPPORTS__-x
-- Performing Test CXX_COMPILER_SUPPORTS__-x - Failed
-- Performing Test C_COMPILER_SUPPORTS__c++
-- Performing Test C_COMPILER_SUPPORTS__c++ - Failed
-- Performing Test CXX_COMPILER_SUPPORTS__c++
-- Performing Test CXX_COMPILER_SUPPORTS__c++ - Failed
-- Performing Test C_COMPILER_SUPPORTS__-Wno-unused-but-set-variable
-- Performing Test C_COMPILER_SUPPORTS__-Wno-unused-but-set-variable - Success
-- Performing Test CXX_COMPILER_SUPPORTS__-Wno-unused-but-set-variable
-- Performing Test CXX_COMPILER_SUPPORTS__-Wno-unused-but-set-variable - Success
-- TCL library: /usr/lib64/libtcl.so
-- TCL header: /usr/include/tcl.h
-- Found SWIG: /usr/bin/swig (found suitable version "4.1.1", minimum required is "3.0")
-- Using SWIG >= 4.1.1 -flatstaticmethod flag for python
-- Found Boost: /usr/lib64/cmake/Boost-1.82.0/BoostConfig.cmake (found version "1.82.0")
-- boost: 1.82.0
-- Found Python3: /usr/include/python3.11 (found version "3.11.3") found components: Development Development.Module Development.Embed
-- Found ZLIB: /usr/lib64/libz.so (found version "1.2.13")
-- Found Threads: TRUE
-- spdlog: 1.11.0
-- Found BISON: /usr/bin/bison (found version "3.8.2")
-- Could NOT find Doxygen (missing: DOXYGEN_EXECUTABLE)
-- STA version: 2.4.0
-- STA git sha: 555493cba6e476bd2ff0b9a543de7a781276c2b3
-- System name: Linux
-- Compiler: GNU 13.1.1
-- Build type:
-- Build CXX_FLAGS:
-- Install prefix: /usr/local
-- Found FLEX: /usr/bin/flex (found version "2.6.4")
-- TCL library: /usr/lib64/libtcl.so
-- TCL header: /usr/include/tcl.h
-- SSTA: 0
-- STA executable: /var/tmp/portage/sci-electronics/openroad-9999/work/openroad-9999/src/sta/app/sta
-- GPU is not enabled
-- TCL library: /usr/lib64/libtcl.so
-- TCL header: /usr/include/tcl.h
-- Found Protobuf: /usr/lib64/libprotobuf.so (found version "3.21.9")
-- Found Eigen3: /usr/share/eigen3/cmake/Eigen3Config.cmake (found version "3.4.0")
-- GUI is enabled
-- Charts widget is not enabled
-- Configuring incomplete, errors occurred!

To Reproduce
Build latest GIT sources with GCC v13.
Relevant log output
No response
Screenshots
No response
Additional Context
No response

Would you mind sending a pull request with the change?

Would you mind sending a pull request with the change?
@QuantamHD Done.

Since #3451 was merged, should this be closed as fixed/completed?

Done.


fix ld file K,M will be highlight even not size

The K and M should not be be highlight at end of word.

Am 2016-09-20 17:48, schrieb float:

The K and M should not be be highlight at end of word.

Sorry, not yet. Should I contacted the file maintainer before pull request?

Sorry, not yet. Should I contacted the file maintainer before pull request?

Yes.  Please see the "Syntax, indent and other runtime files" section of CONTRIBUTING.md.

@jamessan Ok. Thank you for your information.

I'll include it now.


Ability to compile to a single default export

rollup-plugin-postcss exports styles as default export.
i’d like to have this optionally output
declare namespace <basename> {
    const class1: string
    const class2: string
}
export default <basename>

(with <basename> being the camelized file name sans .css)

I'm not sure if this is the same thing this issue is asking for, but...
It would be great to be able to just export a single definition file, and scope styles to specific file paths (if that's even possible in TS...). Having a ton of extra .d.ts files really clutters up the repo, both in exploring the files locally and when looking at diffs. It'd be nice if it was just one big file that changed that could be safely ignored (and collapsed by default like in github's UI) like a lock file.


Making this editable from a user interface

I would like to have my administrator to be able to add or remove menu items as he sees fit. I wanted to wrap this in a collection but I can't add items due to the constructor in the entity
    /**
     * Constructor
     */
    public function __construct($name, FactoryInterface $factory)
    {
        $this->children = new ArrayCollection();

        $this->data = array('attributes' => array(),
                            'linkAttributes' => array(),
                            'childrenAttributes' => array(),
                            'labelAttributes' => array(),
                            'extras' => array());

        $this->created = new \DateTime();
        $this->updated = new \DateTime();

        parent::__construct($name, $factory);
    }

Any idea how I can get this done gracefully?

I think that SonataAdmin and some other bundles require managed entities to have argument-less constructors.  I assume that is what you are asking for.
We are limited by the KnpMenu class MenuItem.  The constructor (https://github.com/KnpLabs/KnpMenu/blob/master/src/Knp/Menu/MenuItem.php#L100) takes the same two arguments.
It is possible to write your own MenuItem factory class and pass in the dependencies.  I don't think that SonataAdmin has any such capabilities.
Does this help?


Interpolate spectrum on logarithmic frequency axis

Which issue(s) are closed by this pull request?
dsp.InterpolateSpectrum resulted in Signals containing NaN values if interpolating on a log. frequency axis. The problem was caused by passing two identical frequencies to the interpolation object. This is now fixed by a better choice for f=0 Hz, which has to be treated because log(0) = -inf. The fix is required because NaN's are not allowed anymore (#435).
Changes proposed in this pull request:

calculate log. frequencies based on an arbitrary equidistant frequency scale starting at 1 not 0 to avoid log(0). This required to move code from the class initialization to the interpolation stage, because the new algorithm needs to know the number of frequency bins to which it interpolates.
update tests

The docs contain an example for both interpolation types: https://pyfar.readthedocs.io/en/stable/modules/pyfar.dsp.html#pyfar.dsp.InterpolateSpectrum.
The tests are a bit distributed, but I hope everything is covered

Interpolators are tested in tests/test_dsp_interpolation.py::test_interpolate_spectrum_interpolation
and the frequencies used for interpolation are tested in tests/test_dsp_interpolation.py::test_interpolate_spectrum_fscale

The interpolation on a log scale uses the same interpolators as tested in the first test. So I think an additional test is not needed.

The docs only cover plotting the same example on a log frequency axis and a linear frequency axis. The interpolator is only called once in the beginning of the example.


Fix port 2 txPin

There is a bug in the ESP32 code which prevents keyboard input or Telnet input from reaching the backplane serial line when 6850 emulation is turned off, for example when using a real SIO/2 UART board. The Machine Interface serial port 2 is using pin 25 (ESP32_IO25) as the txPin to the backplane, but the board has ESP32_IO27 connected to that line, on both PCB 2.01 and 2.2.
ESP32_IO27 is wired to pin 3 on the expansion connector, and a workaround can be demonstrated by removing the relevant jumper from the serial select bank, and then jumpering the "Z80" pin on the serial select bank to pin 3 on the expansion connector (which is a bit fiddly because the Pi is in the way). ESP32_IO27 is not used anywhere else on the schematic.
Fixed and tested in this commit, and it now works fine with the 6850 emulation turned off, including USB keyboard input and the Telnet interface. Tested on PCB v2.01, and checked the schematic for PCB v2.2 and found the same problem. Older PCB versions not checked.

Thanks Andrew for fixing this, the code change has been incorporated now.


[WIP][DELETE ME] Example Test for #486

If you run
go test -v -count=1 ./temp/...

It outputs
{"messages":[{"@type":"/cosmos.auth.v1beta1.MsgUpdateParams","authority":"cosmos1...","params":{"max_memo_characters":"100","tx_sig_limit":"0","tx_size_cost_per_byte":"0","sig_verify_cost_ed25519":"0","sig_verify_cost_secp256k1":"0"}}],"memo":"","timeout_height":"0","extension_options":[],"non_critical_extension_options":[]}

Thanks @Olshansk! I did not realize that tx.TxBody was a proto.Message. Good lookin' out! :fist_oncoming::sunglasses:
I've incorporated the learning from this into #486. Closing.


Inquiry about the plans for the experimental offline mode

First, I'd like to express my appreciation for the work you've done with OSV-Scanner. It's a valuable tool for our projects, especially the Call Analysis for Go and Rust
We only want to use the experimental offline mode inside our firms network. I wanted to inquire about the team's plans regarding this feature:

Are there any plans to keep the experimental offline mode long-term?
Is there an estimated timeline for when this feature might either be removed or moved to production?

Understanding the future direction for the offline mode would help us plan our usage accordingly and keep the users happy.

Hi, thank you for the interest!

Are there any plans to keep the experimental offline mode long-term?

Yes, this is intended to be a long term feature.

Is there an estimated timeline for when this feature might either be removed or moved to production?

Our goal with keeping this experimental was to collect feedback before we promote this to a stable flag and commit to stability. @chheda-deshaw Do you have any feedback for this flag before we do this?
@another-rex @G-Rath I don't think we've gotten any feedback that indicates we need to change anything here right? Should we look at promoting this to stable?

Moving experimental features to production is one of our v2 wishlist - @another-rex and I are evaluating the experimental features.

Yes, this is intended to be a long term feature.

Great! Thank you.

Do you have any feedback for this flag before we do this?

The Offline mode in itself works pretty well. I would wish for an easier way to manually download the entire DB. I had some problems with the --experimental-download-offline-databases flag, maybe due to my air-gapped internal network.
I understand the need for segregating it into ecosystems but there could also be an option for downloading the entire DB in the required format. Right now, I have written a script to over all the ecosystems, download the zips and form the required directory structure.


Shadertoy and some examples

This is the Shadertoy implementation of the wgpu-py version, It provides a screen pixel shader programming interface similar to "shadertoy".
This PR also provides several examples (most migrated or adapted from shadertoy).
See:  https://github.com/pygfx/pygfx/pull/410

Finally, I think you should document this class in docs/reference_utils.rst!

Finally, I think you should document this class in docs/reference_utils.rst! Afterwards I'm OK with merging this :)

It seems that CI will imports shadertoy module when building document.
Therefore, I put the import code into try...exceprt...
I'm not sure if this is in line with the specification. 😅

Ah, I see. Instead of the try/except, please add the following to docs/conf.py on line 18 (prior to any wgpu imports):
os.environ["WGPU_FORCE_OFFSCREEN"] = "true"

wgpu. backends. rs still cannot be imported in CI (the libwgpu.so library is required).
I have moved this import code to _prepare_render() method, It works.
Is it OK to modify it like this?

This is great! A few small comments.

Have modified as suggested. 😅

Nice work!


add some spaces between fields

All repeated code will be removed during future refactoring: https://github.com/hellofresh/janus-dashboard/issues/112


fix: aspect ratio bug and image options header

Set initial lockAspectRatio to be false (all images were fixed at 300x200 aspect ratio)
Added Image Options header to image options component
Refactored add image dialog to remove duplicate code
Commented code

great job! definitely liking the image options.
i got a couple weird things happening on myself with the update. not sure if it's happening on your side too.

is it possible to remove the '.tsx' on line 5.

// For select image file dialog prompt
import selectImageFile from './AddImageDialog.tsx'
typescript is giving me a linting error

unlocking the aspect ratio seemed to have fixed the sizing but however images can be scaled horizontally now. is this happening with you too? perhaps, removing width from the props and keeping the lock on aspect ratio will fix it?


2 create jdbc connection to database categories

Created all jdbc functions for everything related to category tables.
This PR is still in a draft since there still needs to be some testing.

All methods are tested now and working as expected.


Add support for GCP's OS Login API

This allows users to configure a single SSH key for access to Google Compute Engine VM instances using their Google identity (eg: Gmail, GSuite account).

Also our CI build failed, because we don't have GOOGLE_IDENTITY_TERRATEST defined. What should this be?

Ah, that should be the email of whatever GCP service account is being used as a test runner; presumably, the one these creds are used for: https://github.com/gruntwork-io/terratest/blob/master/.circleci/config.yml#L143

Also our CI build failed, because we don't have GOOGLE_IDENTITY_TERRATEST defined. What should this be?

@yorinasub17 @rileykarson Is this approach I took of any use? https://github.com/gruntwork-io/terraform-google-gke/blob/b90352e9f9d2b2d6e0192e79fc7c5f5264388cca/test/test_helpers.go#L19. I'm currently using a temporary account I created for use with GKE. I could look at moving these methods to Terratest.

That's effectively the same approach, just a different name! Our usage there was superseded in Terraform-land by https://www.terraform.io/docs/providers/google/d/datasource_google_client_openid_userinfo.html so I didn't bother generalising.
With that datasource solving the GKE -> K8S issue, OS Login is a little unique in that it's managed by the user (not necessarily human- just a Google identity) and permissions can't be granted to act on behalf of another, so we need to know the test runner email.

@robmorgan @rileykarson Is there anything else here? Can I merge and release?

Afaik I was waiting on Rob to set a variable in CI, no action items on my end.

As discussed, this is good to go so going to merge it.