DesignMode checks emit warning even when there are no science fibers for one of BOSS, APOGEE

I have noticed that the FPSDesign.validate_design() method emits instrument-specific calibration target warnings even when there are zero science fibers associated with that instrument.
E.g. in a BOSS-only design one might see the following warnings:
[WARNING]: Design does not meet minimum APOGEE skies for DesignMode (MugatuDesignModeWarning)
[WARNING]: Design does not meet FOV criteria for APOGEE skies for DesignMode (MugatuDesignModeWarning)
[WARNING]: Design does not meet minimum APOGEE standards for DesignMode (MugatuDesignModeWarning)
[WARNING]: Design does not meet FOV criteria for APOGEE standards for DesignMode (MugatuDesignModeWarning)

I would suggest to suppress (or downgrade) these warnings when nScienceFibers(APOGEE) = 0
I'm not sure if APOGEE-only designs are being considered, but if so then the equivalent suppression of BOSS warnings might also be desirable.

Yes, so I already do suppress these warnings when nScienceFibers = 0, I think what is happening is I always say it fails this metric if the number of skies or standards for for an instrument = 0.
This obviously doesn't make sense for every design mode, as some design modes have the minimum number of skies/standards = 0. So, my proposal for this is I will additionally suppress these warnings if minSkies = 0 or minStandards = 0 for an instrument. Let me know how this sounds to you (and if it answers the issue you were having).

Hi,
Is it just related to the order in which the check is made?
i.e. the warning message is currently escaping because the check for **Nskies(inst), **Nstd(inst) etc comes before the test for whether **Nsci(inst) > 0?
Flipping the order of the checks would suppress the warning.
Cheers
Tom
(**my parameter names, not intended to refer directly to mugatu code)

Ah, you are right that even with the new addition above, it probably does make sense to change the order as you specified. I have done this now and it seems to fix the issue when there are 0 science fibers for an instrument.


IE10-11 live refresh bug

In IE10-11, dynamics select doesn't work. if there are 2 selects and second select data depends of the first selected option, the second select is'not selectable after $('select').selectPicker('refresh') call.
Example : http://jsfiddle.net/codeandcloud/nr54vx7b/

I'm having this same problem, except the select box I'm trying to use is a "multiple" select. Instead of not being able to select anything, no matter which value you click, it selects the first one. The display updates to indicate that all of the items are selected though...

The problem seems to be something about updating the options in the select box followed by an immediate refresh call.
I added a manual "refresh" button to the above jsfiddle. Any time you use the manual refresh, the second select box will behave as expected. Changing the value of the first select box will re-break the second box.
http://jsfiddle.net/3rxut4bv/
I was also able to get it to work by putting the refresh call in a setTimeout() of ~5 seconds, but this didn't seem to fix it 100% of the time.

I was able to fix the problem by using the non-minified version of the code. So something in the minification is causing problems.
For some reason I wasn't able to get the jsfiddle example to work even with non-minified code. Maybe because this link is actually 1.6.2 code instead of 1.6.3? https://cdnjs.cloudflare.com/ajax/libs/bootstrap-select/1.6.3/js/bootstrap-select.js

Thanks you for your research about my problem.
Unminified doesn't solve the problem on my side and the file "https://cdnjs.cloudflare.com/ajax/libs/bootstrap-select/1.6.3/js/bootstrap-select.js" doesn't work on IE8-IE7.
The manual update doesn't work too but he gave me an idea. I try to call refresh function 2 times and it's works.
Maybe looking on that way ?

I'm not able to replicate this issue in the latest version. If somebody else is able to replicate and link to a demo, I'll reopen.


Get tokens not working

you closed my other thing so im sorry I'm being annoying I just want the hack to work. Please email me at<EMAIL_ADDRESS>when you have fixed the hack.

just relode

they mean reload the page

i did and it still did not work


Use all fields in MasterPlaylist::buildUpon

Hi,
I've noticed that the buildUpon method for MasterPlaylist doesn't preserve mIFramePlaylists and mUnknownTags. This PR fixes that. I added a new MasterPlaylist.Builder constructor to avoid breaking the current api.
This library is awesome! Thanks 👍

@carlanton Thanks, good catch!
@sunglee413 LGTM


version attribute is not specified

In the "Add support for Entity Framework Core" section, it says to add the version attribute.  However, in the doc and in the code, this attribute is not there.  I can't tell if this means that the version attribute should be added into the doc and code or if the reference to adding the version attribute should be removed.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: c9847872-0958-fec8-12f9-dc81b1dea67b
Version Independent ID: 76dd2c7f-aa3f-ec2a-301d-3e288dc4938d
Content: Create a Web API with ASP.NET Core and Visual Studio Code
Content Source: aspnetcore/tutorials/web-api-vsc.md
Product: aspnet-core
GitHub Login: @Rick-Anderson
Microsoft Alias: riande

@theangellmethod 	thanks for pointing this out. #8963 fixes it. You don't add a version.


$.fn.scope undefined when using CommonJS

I'm using CanJS in a Browserify application and noticed the scope jQuery plugin is not defined.
This happens because can.Component checks if window.$ is defined before adding the plugin but in a CommonJS environment, jQuery does not add $ to window.

Source: https://github.com/bitovi/canjs/blob/master/component/component.js#L423

I think a much safer check would be window.jQuery since that always seems to be exposed.

I am using browserify too and just noticed this problem.  I think the correct solution would be to check for can.$.fn

I thought the solution was to not do this at all and, instead, have the check for jQuery abstracted from can.component. Or are you saying to use can.$.fn in the mean time?

I mean if(can.$.fn) { can.$.fn = function{ ... } }
But people can use $().scope()

Basically, we shouldn't be checking for jQuery.  If can.$ is an interface to the underlying library's nodeList.  Perhaps can.$.fn should be its interface to adding additional methods to it.


ViaVersion + Lib's Disguises

What is the output link of /viaversion dump?
http://hastebin.com/apecixezuq.json
Are you using any additional software like BungeeCord? If so, what software and version? (Please list your plugins as well)
Latest BungeeCord (ServerListPlus, NuVotifier)
How does this error happen? login? Using an item?
https://www.youtube.com/watch?v=i6PoM364p44 (moving with keys is not an issue, trying to turn around is...)
Is there an error in the console? Use pastebin.com. Is there a kick message?
No errors of exceptions in console, except:
http://pastebin.com/1Ka21EAi
with:
settings:
  moved-wrongly-threshold: 0.625
  moved-too-quickly-threshold: 100.0

Latest TacoSpigot 1.8.8, latest ViaVersion (1.0.2), ProtocolLib 4.1.0. The same issue occurs with or without NoCheatPlus.

Using Lib's Disguises 8.6.7 (1.8) from https://www.spigotmc.org/resources/libs-disguises.81/

Does this happen with certain mobs?
Can you elaborate on this issue?

Actually I just did some more testing and the issue is only present with ProtocolLib 4.1.0, I didn't test all versions in between but it seems to be ok with ProtocolLib 3.6.5.
The issue is that you can not move and turn around while being disguised. You can only move OR you can only turn around (would bug occasionally), when you start moving AND turning (yaw/pitch is changing) you would see... what you can see in that video.

This seems like an incompatibility with LibDisguises and specific ProtocolLib versions.
Unfortunately there's no correlating behaviour that we could really fix, we don't modify movement for mobs just translate the packets.
I'd suggest just using an older version of PL.


Enable DatasetOpsTestBase to execute a function and tests for OptimizeDatasetOp

This PR includes:

https://github.com/tensorflow/tensorflow/commit/0ef640bc893b842d6047e7116ace164131d4b565: add RunFunction() for DatasetOpsTestBase to exectue a function;

https://github.com/tensorflow/tensorflow/commit/2e7e3122653e62d8221d9c5fe264daf729e56512: add functions to create RangeDataset and FilterDataset. With RunFunction(), it will be easy to create the chained datasets for OptimizeDataset.

https://github.com/tensorflow/tensorflow/commit/2f8fba157c50737590114b5381548a54ba2fe3f9: tests for OptimizeDatasetOp.

cc: @jsimsa

@jsimsa The internal checks failed. Could you please paste the log details here?

third_party/tensorflow/core/kernels/data/dataset_test_base.cc:307:36: error: definition of 'VersionDef' must be imported from module '//third_party/tensorflow/core:protos_all_proto.ph.blaze-out/k8-py3-opt/genfiles/third_party/tensorflow/core/framework/versions.proto.h' before it is required
  const int version = g->versions().producer();

@jsimsa The missing import for versions.pb.h is added (https://github.com/tensorflow/tensorflow/pull/28874/commits/c563485bb8bc71db7b8e5262af34a099d7c66fc4). Could you have a look at the change? Do you have any suggestions about how to check whether some imports/dependencies are missing?

@jsimsa Sorry that the internal checks failed again. Could you help check the logs?

the test failures do not seem to be related and the internal test is being re-ran

@jsimsa This PR is rebased to solve the code conflicts. Could you have another look when you get a chance? Thanks!

@jsimsa This PR has been pending for a while. Are there anything else I need to do?

The internal copy of the CL seems to have failed with:
third_party/tensorflow/core/kernels/data/optimize_dataset_op_test.cc:65:3: error: control may reach end of non-void function [-Werror,-Wreturn-type]
  }

@jsimsa The failure seems to be caused by the missing return status. This commit (https://github.com/tensorflow/tensorflow/pull/28874/commits/443fba8256200502c5b2b21a03688a7908001a79) is submitted to fix it. It also makes TensorValue constructor explicit to follow the recent changes. Please have a look at the change.

@jsimsa The internal checks failed. Could you help paste the failure logs here? Thanks!

The internal checks look good to me.

Thanks for checking @jsimsa! It was in the FAIL status when I checked it. Now it changes to the PASS status.


Time Diff in days - need both from and to be counted while computing difference

When i use:
TimeDifference.between(@from_date, @to_date).in_days
where @from_date = '01/01/2014' and @to_date = '12/31/2014', it computes the diff as 364 days.
Is there a way I can have the diff take into account the end-date as well, so that the result comes up as "365" instead of "364" ?

@vregdev 364 days is the accurate calculation done by the computer.
http://www.wolframalpha.com/input/?i=how+many+days+from+01%2F01%2F2014+to+12%2F31%2F2014
365 days is the human estimation. I am afraid the only way to do so is through a workaround.
You can calculate that
TimeDifference.between(start_time, end_time).in_years # returns 1 year

and map that 1 year = 365 days


feat(maven-jdk21-nanoserver): adding jdk21 to windows container

as per https://github.com/jenkins-infra/helpdesk/issues/3709
⚠ WARNING do not merge, wait for eclipse-temurin:21-jdk-windowsservercore-1809 to be available ! ⚠
https://hub.docker.com/_/eclipse-temurin/tags?page=1&name=21-jdk-windowsservercore-1809

Amends: as see together when handing-over, we are providing the JDK 21 image using the ZIP installer until Temurin provides an official container image.
Tested locally (Docker container on a Windows 11 machine): let's see the CI results


Make the export command generic

Fixes # .
Changes proposed in this pull request:

Make export command generic, swagger export one of the targets
Allows to choose format(yaml/json), yaml default
Parallelise unit tests

@anz-bank/sysl-developers

I don’t see any parallelisation of unit tests. Probably better to keep that split out from this PR anyway. Please comment and update the description if necessary.

sysl2/sysl/exporter/swagger_exporter_test.go -> TestExportAll()
Has multiple t.run() calls now. Earlier there was a single test case for all the sysl files.

I don’t see any parallelisation of unit tests. Probably better to keep that split out from this PR anyway. Please comment and update the description if necessary.

sysl2/sysl/exporter/swagger_exporter_test.go -> TestExportAll()
Has multiple t.run() calls now. Earlier there was a single test case for all the sysl files.

Ok change removed, will create another PR with just the test case change. The description updated for this PR. Please have another look.


Hard coded language when linking to wiki

In pull #8373 a new feature is introduced to link the user to the wiki page for the current challenge that they are on. Currently the language for the wiki challenge page is hard coded to prevent 404s. As there is no way to check on the contents of the iframe after loading it, a fix to this problem likely needs to be implemented on the wiki's side.
The preferable behavior would be to try to open the page in the user's language, if it's not available fallback and redirect to the english page for the challenge, and finally, if that's not available, link to the wiki's homepage in the user's own language.

Unfortunately, static pages don't work like that. You can't have automatic pages. If it's not there you get a 404 page.

So to tackle this we would need some form of API that fetches the article from GitHub hosted pages, and render it within the iframe of the wiki sidebar?
That's going to hit the performance quite a bit.

@raisedadead We should take the same approach we will take with languages on the main site, support for those will come when they are close to completed.
For the wiki we can define this as having every wiki article for the challenges translated into a language.  We can reduce the burden for this by not requiring the entire article to be translated, but at least some minimum amount must be supplied. This increases usability without require tons of logic that for now will mostly return false.

Could/should those articles be automatically generated with scripts to
redirect (or even just links) to the complete English version of the
article?
On Fri, May 13, 2016 at 3:14 PM Berkeley Martinez<EMAIL_ADDRESS>wrote:

@raisedadead https://github.com/raisedadead We should take the same
approach we will take with languages on the main site, support for those
will come when they are close to completed.
For the wiki we can define this as having every wiki article for the
challenges translated into a language. We can reduce the burden for this by
not requiring the entire article to be translated, but at least some
minimum amount must be supplied. This increases usability without require
tons of logic that for now will mostly return false.
—
You are receiving this because you authored the thread.
Reply to this email directly or view it on GitHub
https://github.com/FreeCodeCamp/FreeCodeCamp/issues/8591#issuecomment-219134186

We want them to be translated (or at least created) by humans who speak the language. It will create a better translation and drive engagement and ownership.
This might also be a great place for someone new to github to create their first PR!

Absolutely. That makes a lot of sense.
On Fri, May 13, 2016 at 3:52 PM Berkeley Martinez<EMAIL_ADDRESS>wrote:

We want them to be translated (or at least created) by humans who speak
the language. It will create a better translation and drive engagement and
ownership.
This might also be a great place for someone new to github to create their
first PR!
—
You are receiving this because you authored the thread.
Reply to this email directly or view it on GitHub
https://github.com/FreeCodeCamp/FreeCodeCamp/issues/8591#issuecomment-219142510

No longer relevant. Closing.


[SR-5918] Add diagnostic error for duplicate product names

Fixes SR-5918 by @lightsprint09, @hartbit and myself at Swift Alps.

@swift-ci please smoke test

This is causing breakage in the source compatibility suite. Bug at:
https://bugs.swift.org/browse/SR-6488
Perhaps we should stage this in as a warning?

I think source compatibility != package manager compatibility. Its probably a good thing that package is breaking now. Can we disable that package from the suite until the author submits an update?

Technically its not a problem to make it a warning. However, this is something which may cause undefined behaviour. I'd rather force users to fix their package than continue defining it the wrong way. Usually, we try to maintain as much package manager compatibility as possible (we even ship two versions of package manifest API right now) but in certain cases it is better to just break packages. I don't expect this particular issue to break a large number of packages, so I don't think its worth turning this into a warning and then to an error later.
Having said that, policy for breaking package manager changes w.r.t the source compatibility suite is something we need to discuss.


Error: Uncaught SyntaxError: Identifier 'doc' has already been declared

I'm in this situation. Before that, it was working normally. if I open the pdf file to a new tab and press f12 to run, it appears
Uncaught SyntaxError: Identifier 'doc' has already been declared

I have same issue

same

1 week ago everything works but today I get this error.

1 week ago everything works but today I get this error. I changed the variable name to smt like , it works again.aDoc

Can you explain me please, I don't have enough knowledge to fix it myself, the error is with the word "doc" . I change the word "doc" to "aDoc" but I think that is not what you mean

I change the word "doc" to "aDoc" but I think that is not what you mean

You understand correctly what I mean :-).
I refactored let doc = ""; to let aDoc = "";
Not quite sure, but I guess new version of google drive now uses this variable name in their javascript source code, so we cannot use it again in the script.

Document.PDF_DataFile, Cannot decode line "1" as it contains invalid PNG Base64 data i do have this error.

Document.PDF_DataFile, Cannot decode line "1" as it contains invalid PNG Base64 data i do have this error.

I have the same error too.


Automatic PR from RestAPI-PR458

Generated from RestAPI PR: https://github.com/Azure/azure-rest-api-specs/pull/458

Coverage decreased (-0.03%) to 58.116% when pulling c6a8102dad4207506d7e4dcf5c13f1fa100c7c8d on AutorestCI:RestAPI-PR458 into a4b8d358dd39ff41bb190774d9d703f4f7b008fc on Azure:dev.


Should we add a firesPointerEvents property?

Since there are some UI Events that fire pointer events and some that don't, do we want a firesPointerEvents property for completeness?

Likewise, firesMouseEvents might be useful for scenarios such as knowing if an Enter keypress is going to produce a click event.

Are you suggesting that you'd get a different InputDevice object depending on context (event target, etc.)?  Or do the properties on a given device change with context (i.e. the keyboard device has a firesMouseEvents that becomes true briefly after hitting space on a checkbox).  Modeling after the APIs in other OSes, I expected we'd want something context-free (eg. Imagine an API to enumerate all devices like we've discussed before in PEWG).  Maybe you're talking about new properties of a UIEvent, rather than other properties of InputDevice?
Still, I wondered if (static) properties like those might be valuable InputDevice (certainly "is this a pointer" from the point of view of PE).  I don't have particularly compelling scenarios off the top of my head though, so I was trying hard to keep the first rev very focused.  See the brainstorm doc in the readme for more API ideas from various folks.


Update /ja/docs/concepts/services-networking/service/

Fixes https://github.com/kubernetes/website/issues/18148
Follow https://github.com/kubernetes/website/commits/master/content/en/docs/concepts/services-networking/service.md

/milestone 1.16-ja.1

/lgtm

/lgtm
/approve


streamline deploy script

Put grantAccess() and transferOwnership() calls right after deploying the base protocol

Pull Request Test Coverage Report for Build 7911

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 100.0%

Totals

Change from base Build 7893:
0.0%

Covered Lines:
1355

Relevant Lines:
1355

💛  - Coveralls


Linux 6.4 memory corruption

Describe the bug
According to this Arch Linux bug, "per-vma locking during page fault handling" doesn't seem to work properly and can cause firefox to randomly crash.
Steps To Reproduce
Steps to reproduce the behavior:

open firefox
firefox randomly crashes after being open for some time

Expected behavior
firefox to not crash
Additional context
I can confirm that on my system the relevant config options are set:
> cat /proc/config.gz | gzip -d | grep VMA_LOCK
CONFIG_ARCH_SUPPORTS_PER_VMA_LOCK=y
CONFIG_PER_VMA_LOCK=y
# CONFIG_PER_VMA_LOCK_STATS is not set

Not sure if this is the correct place to report a bug like this.
Notify maintainers

Metadata
Please run nix-shell -p nix-info --run "nix-info -m" and paste the result.
[user@system:~]$ nix-shell -p nix-info --run "nix-info -m"
 - system: `"x86_64-linux"`
 - host os: `Linux 6.4.0, NixOS, 23.11 (Tapir), 23.11.20230704.78419ed`
 - multi-user?: `yes`
 - sandbox: `yes`
 - version: `nix-env (Nix) 2.15.1`
 - channels(root): `"nixos"`
 - channels(beef): `"home-manager"`
 - nixpkgs: `/nix/var/nix/profiles/per-user/root/channels/nixos`

I have been noticing random crashes when using librewolf, often after clicking on a link and the page is just loading in. Unsure if it's the same issue, it does core dump due to "illegal hardware instruction" and occurred on 6.4.0 and 6.4.1

@huantianad try going to about:crashes and check the crash reports. For me the path that crashed are pretty random (no pattern) with some only occurring on nixos systems

For some reason, going to that tells me "Hmm. That address doesn’t look right. Please check that the URL is correct and try again." Not sure why, might be a librewolf thing, I can't find anything with a quick google search, but I'll check again in the morning.

Thanks for reporting this. I can also confirm this crashes, that look very random to me. I suspected that I was something memory related, because when the crash happens my system feels very sluggish, and sometimes I have to reboot. Furthermore, I tried using the beta Firefox, but it also happened there. From the about:crashes I could not find any hint on the cause of the problem. In the linked Bugzilla thread there is a workaround, hopefully it will be implemented soon.

Those MM issues are supposed to be fixed in 6.4.3 https://github.com/NixOS/nixpkgs/pull/242785
It's already made its way to the unstable channel at least, so nix flake update / nix-channel --update and rebuilding should hopefully fix this.!

I haven't had any crashes since updating my kernel to 6.4.3, and I was observing firefox crashes every few hours before that.
Optimistically closing this as resolved by the kernel update. Thanks all for figuring out the source of the crashes!


toLocaleUpper / toLocaleLower

And other locale fns for String and Number.

No presupplied type for the locale. This may need more thought.


Unreal: Parent Qt UI to Window main Unreal

Changelog Description
Improved Qt window parenting for Unreal window. I disabled the setWindowFlags : WindowStaysOnTopHint and I use this function : unreal.parent_external_window_to_slate
Additional info
Test with Unreal 5.3
Testing notes:

Open Unreal
Click on Ayon Menu
The popup UI is now correctly parent with unreal

Hello. I'm not entirely sure about the purpose of this PR.

Actually, It's the Qt window that is not correctly linked to the Unreal application, for example when I minimize Unreal, the Ayon tools window still remains visible in WindowStaysOnTop. My PR fixes that.

Ah, in that case, that works, but I think that the menu should still behave as a dropdown menu and disappear when out of focus :)
Now the two options (popup and dialog) behaves the same, at least with Unreal 5.2! Haven't tested 5.3.

I tested with Unreal 5.3 and "AyonTools" is still a drop-down menu (the window is not persistent and disappear when out of focus ). Like expected behavior.

Because we're splitting OpenPype into ayon-core and individual host addons, this PR would have to be re-created to target one of those.
We're closing it down, but we'll he happy for a new PR to ynput/ayon-unreal repository once it's up.


Switches not working on slave device in multiple instance setup

Make sure you are running the latest version of Home Assistant before reporting an issue.
You should only file an issue if you found a bug. Feature and enhancement requests should go in the Feature Requests section of our community forum:
Home Assistant release (hass --version):
0.26.3 on both devices
Python release (python3 --version):
3.5.2 on master and 3.4.2 on slave
Component/platform:
Multiple Instances / switch on slave
Description of problem:
When turning on switch from frontend, the salve responds with the below traceback and the switch isn't turned on/off.
Expected:
Switch should turn on/off
Problem-relevant configuration.yaml entries and steps to reproduce:
Config on slave
switch:
  platform: command_line
  switches:
    garage_door:
        oncmd: /bin/bash /home/pi/.virtualenvs/hass/config/garage_on.sh
        offcmd: /bin/bash /home/pi/.virtualenvs/hass/config/garage_off.sh

Traceback (if applicable):
BusHandler:Exception doing job
Traceback (most recent call last):
  File "/home/pi/.virtualenvs/hass/lib/python3.4/site-packages/homeassistant/core.py", line 852, in job_handler
    func(*args)
  File "/home/pi/.virtualenvs/hass/lib/python3.4/site-packages/homeassistant/core.py", line 713, in _event_to_service_call
    priority=JobPriority.EVENT_SERVICE)
TypeError: 'ThreadPool' object is not callable

Additional info:
Python script to start slave.
import homeassistant.remote as remote
import homeassistant.bootstrap as bootstrap
import homeassistant.config as config

# Location of the Master API: host, password, port.
# Password and port are optional.
remote_api = remote.API("192.168.x.x", "password", 8123)

# Initialize slave
hass = remote.HomeAssistant(remote_api)
hass.config.config_dir = "/home/pi/.virtualenvs/hass/config/"
myconfig = config.load_yaml_config_file("/home/pi/.virtualenvs/hass/config/configuration.yaml")

# To add an interface to the slave on localhost:8123
bootstrap.setup_component(hass, 'switch', myconfig)

hass.start()
hass.block_till_stopped()

I have the same issue, but with calling a service directly:
Traceback (most recent call last):
  File "/home/pi/dev/home-assistant/homeassistant/core.py", line 852, in job_handler
    func(*args)
  File "/home/pi/dev/home-assistant/homeassistant/core.py", line 713, in _event_to_service_call
    priority=JobPriority.EVENT_SERVICE)
TypeError: 'ThreadPool' object is not callable

@balloob looks like this error is coming from core.py, you made most of the changes during the time frame this started happening. When you get a chance can you take a look and see whats going on?

I am experiencing the same problem.
Master: Debian x64, hass 0.28.2, Python 3.5.2+
Slave: RPi2 running OSMC, hass  0.28.2, Python 3.4.2
The only configuration on the slave is an input_select, which in turn calls an HDMI CEC automation (on, off, select Chromecast, select RPi).
When the slave is invoked as master ("hass" from a shell), it works. When invoked using the script from w1ll1am23 above (with added hdmi_cec, automation, and input_select components), it fails with:
Traceback (most recent call last):   File "/usr/local/lib/python3.4/dist-packages/homeassistant/core.py", line 865, in job_handler     func(*args)   File "/usr/local/lib/python3.4/dist-packages/homeassistant/core.py", line 726, in _event_to_service_call     priority=JobPriority.EVENT_SERVICE) TypeError: 'ThreadPool' object is not callable
It fails this way regardless of whether I go to the slave or master webpage.
On the master, it gives a warning:
 16-09-25 20:58:36 INFO (CP Server Thread-4) [homeassistant.components.http] Serving /api/services/input_select/select_option to <ip> (auth: True) 16-09-25 20:58:36 INFO (CP Server Thread-4) [homeassistant.core] Bus:Handling <Event call_service[L]: service_data=option=<menu item>, entity_id=input_select.threat, service_call_id=140552597327264-9, domain=input_select, service=select_option> 16-09-25 20:58:36 WARNING (ThreadPool Worker 5) [homeassistant.core] Unable to find service input_select/select_option

Has this been resolved?

Multiple instances has been deprecated.


PHP 8: Bind annotation

For getters or public properties, the <<Bind>> annotation can be used to mark the value as "Bindable", currently being done via either BindGetter, BindObject or BindDataMapper interfaces.

#[DataBindGetter] applied to a class can expose all getX() methods as key value pairs without the get prefix.
#[DataBind] can then be applied to any private property to expose it (maybe by using reflection).
#[DataBind(name: "somethingElse")
private string $something;


[Analysis] Can we support volume provisioning on heterogeneous storage from Kubernetes using SODA from the Dashboard?

Issue/Feature Description:
The SODA CSI plugin allows the user to provision storage using the unified CSI plugin. At the moment there is no support from the dashboard to use this and provision volumes via Kubernetes.
Why this issue to fixed / feature is needed(give scenarios or use cases):
How to reproduce, in case of a bug:
Other Notes /  Environment Information: (Please give the env information, log link or any useful information for this issue)

Any analysis should be completed by this iteration Iter2

Any analysis should be completed by this iteration Iter2

This was for Hawaii Iter2 and we subsequently decided to push this to I-release.

Any analysis should be completed by this iteration Iter2

This was for Hawaii Iter2 and we subsequently decided to push this to I-release.

I will complete this by Iter1_1.
Probable date for Analysis completion: 20/01/2021

I will complete this by Iter1_1.
Probable date for Analysis completion: 20/01/2021

I had a detailed discussion with @sushanthakumar regarding our current CSI driver and support for Kubernetes (K8S). From the discussion and referring to the provisioning of Block volume example the following points were captured:

A StorageClass has to be provisioned.
This StorageClass has to be attached to a SODA Profile ID.
A PersistentVolumeClaim (PVC) has to be provisioned and this has to be attached to a StorageClass
A pod / application can be deployed by attaching the volume provisioned and then mounting it.

All the Kubernetes tasks are being performed by using the kubectl command with the corresponding .yaml configurations which are run on the node via command line.
To remotely run the commands or provision any of the above we will have to use the Kubernetes API server that is available and provides a set of REST APIs.
To provide support from the SODA Dashboard these are the highlevel requirements:

Access to Kubernetes APIs (by default the certificates generated are for localhost only, to be accessible remotely we will have to bind the API server to a public IP and a specific port and the certificates will have to be generated for the same.)
Create, list and delete StorageClass in Kubernetes via SODA DAshboard via the API.
Attach Profile to StorageClass
Create, list and delete PVC in K8S via SODA Dashboard via the API
Attach the PVC to the StorageClass based on the State via the SODA Dashboard using K8S APIs.
Provision a pod and attach the volumes to the pod via the SODA dashboard using the K8S APIs.
Check the status of all the above and provide basic operations to view the details.

Some of the challenges that were discussed were:

Scope of SODA Dashboard and K8S tasks.
Version support for K8S. Many parameters keep changing and many commands may be updated across versions.
real world use case for providing the UI support. What will  be a typical example.
Should this be provided as a PoC or can it be supported as a separate service like Orchestration.
K8S API support and how secure will it be since SODA Dashboard does not work on https.

I had a detailed discussion with @sushanthakumar regarding our current CSI driver and support for Kubernetes (K8S). From the discussion and referring to the provisioning of Block volume example the following points were captured:

A StorageClass has to be provisioned.
This StorageClass has to be attached to a SODA Profile ID.
A PersistentVolumeClaim (PVC) has to be provisioned and this has to be attached to a StorageClass
A pod / application can be deployed by attaching the volume provisioned and then mounting it.

All the Kubernetes tasks are being performed by using the kubectl command with the corresponding .yaml configurations which are run on the node via command line.
To remotely run the commands or provision any of the above we will have to use the Kubernetes API server that is available and provides a set of REST APIs.
To provide support from the SODA Dashboard these are the highlevel requirements:

Access to Kubernetes APIs (by default the certificates generated are for localhost only, to be accessible remotely we will have to bind the API server to a public IP and a specific port and the certificates will have to be generated for the same.)
Create, list and delete StorageClass in Kubernetes via SODA DAshboard via the API.
Attach Profile to StorageClass
Create, list and delete PVC in K8S via SODA Dashboard via the API
Attach the PVC to the StorageClass based on the State via the SODA Dashboard using K8S APIs.
Provision a pod and attach the volumes to the pod via the SODA dashboard using the K8S APIs.
Check the status of all the above and provide basic operations to view the details.

Some of the challenges that were discussed were:

Scope of SODA Dashboard and K8S tasks.
Version support for K8S. Many parameters keep changing and many commands may be updated across versions.
real world use case for providing the UI support. What will  be a typical example.
Should this be provided as a PoC or can it be supported as a separate service like Orchestration.
K8S API support and how secure will it be since SODA Dashboard does not work on https.

I want to try and put together a quick and dirty PoC to check the feasibility of the above tasks.
I am aiming to get this done by 21/01/2021 but it depends on the K8S API server being accessible from SODA Dashboard.
@sushanthakumar Please do chime in here and add any suggestions, thoughts and concerns that you may have.
@AmitRoushan I will need your help in working with the K8S API server.

I want to try and put together a quick and dirty PoC to check the feasibility of the above tasks.
I am aiming to get this done by 21/01/2021 but it depends on the K8S API server being accessible from SODA Dashboard.
@sushanthakumar Please do chime in here and add any suggestions, thoughts and concerns that you may have.
@AmitRoushan I will need your help in working with the K8S API server.

I want to try and put together a quick and dirty PoC to check the feasibility of the above tasks.
I am aiming to get this done by 21/01/2021 but it depends on the K8S API server being accessible from SODA Dashboard.

The API server is accessible but requires the certificate and key. With @AmitRoushan help I was able to get the Certificate and key for our single node cluster test setup. I used this to access the K8S APIs using Postman.
I have to explore how this certificate based authentication can be done with our dashboard.
I do not think I can complete the PoC by 21/01/2021

I want to try and put together a quick and dirty PoC to check the feasibility of the above tasks.
I am aiming to get this done by 21/01/2021 but it depends on the K8S API server being accessible from SODA Dashboard.

The API server is accessible but requires the certificate and key. With @AmitRoushan help I was able to get the Certificate and key for our single node cluster test setup. I used this to access the K8S APIs using Postman.
I have to explore how this certificate based authentication can be done with our dashboard.
I do not think I can complete the PoC by 21/01/2021

@anvithks IMO Service Account based access make more sense here rather than certificate based.
Some reasons are:

Ease of use
Gives more control over API authorization
It is available by default with any kind of K8S cluster (in some K8S cluster environment certificate based Authentication/Authorization may not be available).

@anvithks IMO Service Account based access make more sense here rather than certificate based.
Some reasons are:

Ease of use
Gives more control over API authorization
It is available by default with any kind of K8S cluster (in some K8S cluster environment certificate based Authentication/Authorization may not be available).

Thanks @AmitRoushan .
I have done a quick read of the medium article that you linked above. Still going through the K8S docs that are linked above.
Some thoughts on this:

A service account must be available for SODA to access the APIs. If we are deploying K8S using the local cluster setup we will have to add a step to create the service account with appropriate access levels.
If the K8S cluster is already setup then user will need a service account with access to the k8S APIs from SODA Dashboard.
How can we use the service account from our dashboard? Will it need an API in SODA or any way to enable from K8S?
Assuming we are able to access the K8S APIs from the SODA Dashboard the flow would be something as follows:
-  User can list StorageClasses available
-  User can create a StorageClass (Using yaml / json editor or Drop down based form). User can select / provide the SODA profile that must be associated with the StorageClass
-  User can list PVCs available
-  User can create a PVC (Using yaml/json editor or Drop down based form)
-  User can list pods available
-  User can deploy a pod / application (Using yaml/json editor or Drop down based form). User can select the Volumes to be mounted and provide the mount points for these volumes.

Thanks @AmitRoushan .
I have done a quick read of the medium article that you linked above. Still going through the K8S docs that are linked above.
Some thoughts on this:

A service account must be available for SODA to access the APIs. If we are deploying K8S using the local cluster setup we will have to add a step to create the service account with appropriate access levels.
If the K8S cluster is already setup then user will need a service account with access to the k8S APIs from SODA Dashboard.
How can we use the service account from our dashboard? Will it need an API in SODA or any way to enable from K8S?
Assuming we are able to access the K8S APIs from the SODA Dashboard the flow would be something as follows:
-  User can list StorageClasses available
-  User can create a StorageClass (Using yaml / json editor or Drop down based form). User can select / provide the SODA profile that must be associated with the StorageClass
-  User can list PVCs available
-  User can create a PVC (Using yaml/json editor or Drop down based form)
-  User can list pods available
-  User can deploy a pod / application (Using yaml/json editor or Drop down based form). User can select the Volumes to be mounted and provide the mount points for these volumes.

IMO

In our K8S usecase/support, mostly it is the conventional steps for k8s with small part for soda connectivity
Storage class creation with provisioner as soda csi plugin and mentioning which soda profile to be used as the only info related to soda
K8S support rich set of attributes which can be specified through yaml and executed through kubectl
Considering this point in mind, giving provision for performing all E2E steps through dashboard has some challenges
a) Dashboard cant provide customisation for predefined set of k8s attributes as these attributes are many and always bound to grow in number
b) If we think of providing entire deployment yaml file as input in dashboard in some way, dashboard need to connect to K8S and perform user requested operation but nothing much is gained from user side
One area we can think of improving value with dashboard is the visualisation of provisioning performed through K8S flow for E2E view
a) Currently in our dashboard, we see all soda provisioned volumes at one place but we do not have any obvious way to specifically see k8s volumes
b) When multiple application deployment happens through multiple profiles, it will be a challenge to find relation between storage class, pvc and corresponding backend volumes
One way is to extend api layer and soda db to hold optional metadata where some key, value pair can be maintained against the soda objects. Dashboard can use them for providing relation . This calls for the modification of api and db layer capability which can be utilied by other usecases as well going forward

IMO

In our K8S usecase/support, mostly it is the conventional steps for k8s with small part for soda connectivity
Storage class creation with provisioner as soda csi plugin and mentioning which soda profile to be used as the only info related to soda
K8S support rich set of attributes which can be specified through yaml and executed through kubectl
Considering this point in mind, giving provision for performing all E2E steps through dashboard has some challenges
a) Dashboard cant provide customisation for predefined set of k8s attributes as these attributes are many and always bound to grow in number
b) If we think of providing entire deployment yaml file as input in dashboard in some way, dashboard need to connect to K8S and perform user requested operation but nothing much is gained from user side
One area we can think of improving value with dashboard is the visualisation of provisioning performed through K8S flow for E2E view
a) Currently in our dashboard, we see all soda provisioned volumes at one place but we do not have any obvious way to specifically see k8s volumes
b) When multiple application deployment happens through multiple profiles, it will be a challenge to find relation between storage class, pvc and corresponding backend volumes
One way is to extend api layer and soda db to hold optional metadata where some key, value pair can be maintained against the soda objects. Dashboard can use them for providing relation . This calls for the modification of api and db layer capability which can be utilied by other usecases as well going forward


Naming Inconsistency?

Wondering if you can help me understand when a schema is in a "common" namespace and some are in  "context". For example, why is Address have an $id that includes xdm/common/, but PhoneNumber has an $id that includes xdm/context/?
Same for EmailAddress, what makes it xdm/context and not xdm/common. What is the deciding factor?

@cmathis - shall we move phone number? It is the only one I can see that has this issue.

If you decide to move it, open a separate issue or a PR right away. I consider this question answered.


Trailing slash route not matched properly

Lucky v0.11, application generated with --api flag.
Case 1: I'm having a users namespace with only index action defined:
class Users::Index < ApiAction
  # `route do` leads to the same result
  get "/users" do
    users = UserQuery.new

    json ::Users::IndexSerializer.new(users)
  end
end

when trying to access /users I have a 200 response with corresponding data, when trying to access /users/ I'm having 500 (don't know why it's not 404) with Lucky::RouteNotFoundError.
Case 2: I'm having a users namespace with index and show actions defined:
class Users::Index < ApiAction
  # `route do` leads to the same result
  get "/users" do
    users = UserQuery.new

    json ::Users::IndexSerializer.new(users)
  end
end

class Users::Index < ApiAction
  # `route do` leads to the same result
  get "/users/:id" do
    user = UserQuery.new(id)

    json ::Users::ShowSerializer.new(user)
  end
end

when trying to access /users I have a 200 response with corresponding data, when trying to access /users/ it's matched to show action for some reason and thus I'm having a 500 error ERROR: cast from LuckyRecord::Type::FailedCast to LuckyRecord::Type::SuccessfulCast(T) failed,
when trying to access /users/:id I have a 200 response with corresponding data.
Case 2.1:  everything is the same as in Case 2 but I have get "/users/" instead of get "/users"inindexaction. This way/usersdoesn't work,/users/works and matched toindexaction as expected,/users/:id` works as well.

The issue is fixed with latest commit in master branch, although the lucky itself have a ~0.2.0 router's dependency, which means latest code isn't shipped with newly generated applications.


Support for external metadata in Dataset browser.

In order to provide extensible support for other datasources in the dataset browser (e.g., HDFS) it would be great to support external metadata describing that dataset (or datasets).
The interaction could then look as follows:
a) user point dataset browser to a specific configuration file e.g., hdfs://data/beakerxconfig.json
b) the datasets configured in that list automatically can be selected/viewed from the dataset browser
P.S. We are more than happy to contribute a more formal design doc if this is of interest to other users as well.

Thanks, @joerg84, it's a great idea and could be useful to other users. Your contribution would be highly welcomed.


Fixed Unable to preventDefault errors in Chrome

Now it should cleanup old event-listeners on remount and remove event-listener on unmount


Add a Setting to Hide/Gray-Out Disabled Extensions' Actions

Add a setting for .vscode/settings.json (or the user's global settings.json) that hides or grays out all the actions associated to disabled extensions. I think the UI / UX rules for this are worth discussing, but a couple rules that make sense to me would be:

If a disabled extension has actions listed in any of the various right-click menus (Editor, Explorer, etc.), then hide those. This would declutter the right-click menus in workspaces that only require a few extensions to be enabled.
If a disabled extension has actions listed in the Ctrl + Shift + P menu, keep those and gray them out to indicate they're "disabled." Maybe also add a little annotation on the right that says "disabled." I don't see any reason to fully hide disabled extensions' Ctrl + Shift + P actions because users usually just do a global search of the Ctrl + Shift + P menu anyway. However, it might also make sense to not show disabled extensions' Ctrl + Shift + P actions in the "recent list" that gets shown when you pull up the Ctrl + Shift + P menu, just to declutter it.

Thanks for the great IDE.

We do not show actions of an extension that is disabled. Why do you want to have them shown ?

I'd like to hide right-click actions, and possibly gray out or hide Ctrl+Shift+P actions for disabled extensions. For example, if I disable the PlatformIO extension, I still see both its right-click actions and its Ctrl+Shift+P actions, which clutters my VSCode UI.

For example, if I disable the PlatformIO extension, I still see both its right-click actions and its Ctrl+Shift+P actions, which clutters my VSCode UI.

This should not happen, can you please provide steps to repro?

Install the latest VSCode as well as the PlatformIO extension.
Disable the PlatformIO extension.
Right-click in the editor pane. The PlatformIO: ... extensions are still there.
Ctrl + Shift + P then search PlatformIO. The PlatformIO: ... actions are still there.

Did you get reload action that reloads the window after disabling the extension and did you reload the window?

I did not get a reload action. However, I just did a Ctrl+Shift+P-->Reload Window and still PlatformIO actions are shown.

Strange, I am not able to reproduce it.
Can you please record a video or gif and share it?


219 make prettier auto commit and push prettified files

testing some actions

This works now, prettier bot will auto commit and push prettified files then say which files were changed


fixed the blackborderprocessor test function to work with the new version

didnt know if you would merge my blackborder changes so i didnt know if its needed.
but now i fixed the test function to work with the new method.
dont know if the 2 assert statements at the end of the file are needed - just commented them

deleted coz outdated
will post a new version soon


Simplify template logic

These changes reduce code repetition and use hugo.IsProduction to check for production builds instead of or in addition to .Site.IsServer. hugo.IsProduction is the same as not .Site.IsServer by default, but users can manually set the build environment and override this.

@bkrl great contribution!


Plugin stop to working after changing targetSdkVersion to 28

Yesterday, following google's instructions, I included the targetSdkVersion variable with the value of 28 on my app, since won't be possible do upload any apk after november 1st without this change. I only included a line on my config.xml, setting the targetSdkVersion, and then the ads stop working after I sent it do play store.
I suspected this before with another app, and now I got proof. Is this a know issue? Was this corrected at some release (I'm currently using version 0.26.0)?

Nevermind. It was just question of time. Some hours after I uploaded the app to the store, the ads started to show again.


chore: replace recette server

:tada: This PR is included in version 1.60.2 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


Update geo-partitioning training to be multi-region

Fixes #4505.

This change is

Online preview: http://cockroach-docs-review.s3-website-us-east-1.amazonaws.com/3b9b1f3f2027a3a8c68887a834e5639487ddeee9/
Edited pages:

v19.1/training/backup-and-restore.md
v19.1/training/geo-partitioning.md
v2.1/training/backup-and-restore.md
v2.1/training/geo-partitioning.md

wouldn't it easier to have --background instead of opening up 4 terminals?

dump had syntax error form v19.1/training/backup-and-restore.md

$ cockroach dump startrek --insecure --host=localhost:26257 startrek_backup.sql
Error: getBasicMetadata: relation startrek.public.startrek_backup.sql does not exist
Failed running "dump"

v19.1/training/geo-partitioning.md

the table does not render correctly

Good catches, @robert-s-lee. Fixed.

Online preview: http://cockroach-docs-review.s3-website-us-east-1.amazonaws.com/85856e4e53b1a338d1acd77c13d9323455d33efa/
Edited pages:

v19.1/training/backup-and-restore.md
v19.1/training/geo-partitioning.md
v2.1/training/backup-and-restore.md
v2.1/training/geo-partitioning.md


fix: add LocalImages Image source to assign local images to points using EXIF data

Changes

Add pillow library to get EXIF location data from images
Move all image sources to images subpackage, add new abstract base class (interface) ImageSource which has the abstract method get_image_from_coordinates
Move Mapillary class from download_images.py to images/mapillary.py
Create new LocalImages class from ImageSource, which assigns local images to points using EXIF data
Add new image_source CLI argument, which currently can be MAPILLARY or LOCAL to use the Mapillary or LocalImages ImageSources respectively
Move logger to new utils.py, so that when I set verbosity in a CLI command, logs in mapillary.py or local_images.py will use the same verbosity. Tell me if this not the best way to achieve this.
Resolves #9 and #40

Testing

Running python -m src.download_images data/interim/Three_Rivers_Michigan_USA_points.gpkg LOCAL data/raw/images/  with a few of Dan's GoPro images from dropbox results in the following dataframe.head():

Getting 4960 Images: 100%|█████████████████████████████████████████████████████████████████████████████████████| 4960/4960 [00:00<00:00, 1024361.01images/s]
     osm_id                    geometry           image_id  image_lat  image_lon       residual                             image_path error
0  17967640  POINT (-85.65161 41.95364)  GS010002_0_001833  38.937746 -77.019965<PHONE_NUMBER>39  data/raw/images/GS010002_0_001833.jpg  None
1  17967640  POINT (-85.65155 41.95379)  GS010002_0_001827  38.937739 -77.020165<PHONE_NUMBER>92  data/raw/images/GS010002_0_001827.jpg  None
2  17967640  POINT (-85.65149 41.95394)  GS010002_0_000293  38.933553 -77.020617<PHONE_NUMBER>64  data/raw/images/GS010002_0_000293.jpg  None
3  17967640  POINT (-85.65142 41.95408)  GS010002_0_000287  38.933418 -77.020584<PHONE_NUMBER>13  data/raw/images/GS010002_0_000287.jpg  None
4  17964573  POINT (-85.65606 41.94811)  GS010002_0_001166  38.932609 -77.019582<PHONE_NUMBER>09  data/raw/images/GS010002_0_001166.jpg  None

Note that I used the original Three_Rivers_Michigan_USA_points.gpkg for correlation with Dan's images. This is why the script still says it is processing 4960 points, and why the distance residual is so far away. I wasn't able to use Dan's corresponding geojson file, as it wasn't the exact same format when imported into the GeoDataFrames.

should there be some inline comments like in create_point.py?
when running  python -m src.download_images --help it doesn't tell you that the available options for the IMAGE_SOURCE argument are MAPILLARY and LOCAL - is there a way to include those options in the help command output?
when running the above help command it also says that the IMAGES_PATH default is /Users/danbjoseph/GitHub/americanredcross/street-view-green-view/data/raw/mapillary - is it setting a default folder named "mapillary" regardless of if the command is for local or mapillary? instead of a default should we just have it fail and notify the user that they need to set a destination path? if the user accidentally processes 2 different areas and uses the default folder for both, it could be a confusing mass of images.
something seems off with the image matching, see #43
the below is the output when i was testing - is printing dataframe.head() to console confusing for the user?

(.venv) ➜  street-view-green-view git:(9-optional-process-to-do-everything-locally) ✗ python -m src.download_images data/interim/ParkView_points.gpkg LOCAL data/images/ParkView/
Getting 1090 Images: 100%|██████████████| 1090/1090 [01:21<00:00, 13.31images/s]
        osm_id  ... error
0  way/6051455  ...  None
1  way/6051455  ...  None
2  way/6051455  ...  None
3  way/6051521  ...  None
4  way/6051521  ...  None

[5 rows x 9 columns]

what was the issue with my geojson file - what you said about "as it wasn't the exact same format when imported into the GeoDataFrames"? here is the interim file with the sampled points: ParkView_points.gpkg.zip

@dragonejt I haven't had a time to review local_images.py in detail yet, but I thought I'd get these comments out since they might save you some work in response to Dan's review.

After some testing, I realized that the duplicates are because of my usage of Python multiprocessing and concurrency. When the current thread filters out duplicates, another thread can take an image from the filtered images before the current thread assigns the closest image, thus resulting in duplicates. I think I will have to avoid concurrency and switch back to a simple for loop to avoid duplicates.

I'm wondering if having logic to keep track of assigned images and skipping them is more complicated than necessary. We could alternatively just assign whichever image is closest to every point, and then deduplicate at the end, which may drop some points.

The main tradeoff between the two options is as you said, simplicity vs loss of some datapoints. There are also more questions to raised should the option of deduplicating by dropping points be OK, such as how many points are OK to drop. What happens if each point has a duplicate image, or multiple points have a single duplicate images, is it OK to end up with half our dataset gone?
Performance-wise, there should be a negligible difference between the two options. Although we could switch back to using concurrency and we would not have a set of assigned images taking up memory, the deduplication process would generally be at least an O(n) activity if not O(n^2). Performance isn't top of mind for us right now anyways.
Regardless, discussion for how we want to pursue deduplication moving forward is definitely out of scope for this PR. We should open up a new GH issue and see how we want to proceed with this. I'm going to leave the current deduplication method as-is for this PR.

I'm considering changing the max_distance to mini_dist to be more consistent with create_points.py


extras -> datasets, add funs for pde experiments

Codecov Report

Merging #6 (751a2d4) into main (8bf29b3) will decrease coverage by 0.24%.
The diff coverage is 0.00%.

@@           Coverage Diff            @@
##            main      #6      +/-   ##
========================================
- Coverage   4.67%   4.42%   -0.25%
========================================
  Files          6       6
  Lines        471     497      +26
  Branches      72      76       +4
========================================
  Hits          22      22
- Misses       449     475      +26

Impacted Files
Coverage Δ

src/mud_examples/datasets.py
0.00% <ø> (ø)

src/mud_examples/helpers.py
0.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8bf29b3...751a2d4. Read the comment docs.


Reconcile instructions in README.md and CONTRIBUTING.md

Reconcile instructions to avoid duplicate/conflicting info. In particular, add firewall instructions and use gcloud to help with the credentials (avoiding some manual steps).

This change is

/assign jessicaochen

/assign karan
This also includes a section on how to update dependencies.

Add instructions as tracked at https://github.com/kubernetes/kube-deploy/issues/563

Since contributing instructions are a superset of running instructions, I would prefer running instructions be fleshed out and the contributing instructions refer to them. I am concerned that the current approach of having the running instructions point to some subset of the contributing instructions will be confusing for those who are just trying to use the code for the first time.

I am not sure if this review comment was not seen or if you decided not to do it for some reason. If the latter, could you share your reasoning?

@jessicaochen

Since contributing instructions are a superset of running instructions, I would prefer running instructions be fleshed out and the contributing instructions refer to them. I am concerned that the current approach of having the running instructions point to some subset of the contributing instructions will be confusing for those who are just trying to use the code for the first time.

I am not sure if this review comment was not seen or if you decided not to do it for some reason. If the latter, could you share your reasoning?

I apologize as I didn't see this comment before. I've been thinking something along those lines as well and I am happy to take another pass at the structure. I'd prefer to merge this PR since it does improve the instructions and then do that work in a separate PR. Would that be OK?

Filed issue to restructure the running instructions: https://github.com/kubernetes/kube-deploy/issues/576

/hold cancel


Migrate iOS instructions from docs

Purpose
Move the instructions for running this sample out of the IoT Hub docs (https://learn.microsoft.com/azure/iot-hub/c2d-messaging-ios) and into this repository.

...

Does this introduce a breaking change?

[ ] Yes
[ X] No

Pull Request Type
What kind of change does this Pull Request introduce?

[ ] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ X] Documentation content changes
[ ] Other... Please describe:

How to Test

Get the code

git clone [repo-address]
cd [repo-name]
git checkout [branch-name]
npm install

Test the code

What to Check
Verify that the following are valid

...

Other Information

@ericwol-msft -- I created this PR after discussion with @ryanwinter about consolidating iOS sample content in a single place. Can you review?


port_security_enabled for port creation/updated

I just added the port_security_enabled option so that open could be set via ansible.

Thank you for contributing to openstack-infra/shade!
openstack-infra/shade uses Gerrit for code review.
If you have never contributed to OpenStack before make sure you have read the
getting started documentation:
https://docs.openstack.org/infra/manual/developers.html#getting-started
Otherwise please visit
https://docs.openstack.org/infra/manual/developers.html#development-workflow
and follow the instructions there to upload your change to Gerrit.


Initial macOS on Apple Silicon support

The PR contains initial support for macOS on Apple Silicon. It uses some older (previously disabled) macOS support and mostly follows the Linux build path.

@microsoft-github-policy-service agree

Thanks for your contribution! We've already discussed this via email, but I just wanted to publicly acknowledge that we're aware of this PR and will work on incorporating it into our upstream repo as soon as scheduling allows.

Just a quick FYI, I have more patches that get the build further along but I need to clean them up before I can push them here. Will try to do that within the next 1-2 weeks.

Sounds good - no rush from our side. We're currently working on acquiring Mac hardware so we can validate these changes locally and prepare to integrate them into the repo and then the CI build. Let us know when you're done with your changes and ready for us to validate.

Just following up to let you know that we're actively working on integrating this now. We've copied your branch to our internal Azure DevOps repo and rebased it onto the latest version of the code there. We reviewed the changes and found some minor adjustments that we'll make on our side. Once that's complete, we'll check these changes into our main branch (ensuring to preserve authorship), and then publish the latest version back to GitHub. Thanks for your patience.

While we were working on this last year, we enabled the unit tests and found that there were some remaining issues with macros that caused the tests to not pass. The work then got put on the backburner due to higher-priority items, but I've recently been able to pick it up again, so we should be publishing the changes for preliminary macOS support soon. For now, I will close this PR, since the changes will be published from our Azure DevOps repo.


Make v2 the default branch

As of 11 hours ago Terraform (master, unreleased) uses the v2 branch, via https://github.com/hashicorp/terraform/commit/23103166669afe2b25c094c5b5aff152ac53bc3e
I think we are ready to cut over make v2 the default branch. @zorkian onboard with that?

Wow! That was fast.
And yes, I'm on board, we probably want to update the README to mention that v1 is still available on the branch etc. That way people can get it if they need it and such when they see that their build is breaking. (Although I don't have any idea how many people use this library beyond the Terraform stuff.)

Ok I've:

Branch v1 is new, I've created tag v1.1 in it and we could use it to push fixes too.
Branch v2 now has a new tag, v2.1
Master now points to 267f4d3cb12d1eb1895d4b7a7893cf37e4213dd7 git branch -f master 267f4d3cb12d1eb1895d4b7a7893cf37e4213dd7

I'm not sure if there is much point in having branch v2 around, what do you think?

No, don't need a branch for it.

Cool, removed branch v2 and go getting gopkg.in/zorkian/go-datadog-api.v2 will now get tag v2.1


aman ghanghoriya

Issue Type: Feature Request
svg2 properties are not supporting in my css file. for example when I am trying to use rx, ry, cx, cy, x, y etc. properties I am getting (unknown property) error in css file.
VS Code version: Code 1.57.1 (507ce72a4466fbb27b715c3722558bb15afa9f48, 2021-06-17T13:26:56.255Z)
OS version: Linux x64 5.4.0-77-generic
Restricted Mode: No

duplicate of #66053


"make" breaks

typing "make" (or other make commands) gives
make
Makefile:27: *** missing separator.  Stop.
which seems to be the following line:
BEST != if ocamlopt 2>/dev/null; then echo .native; else echo .byte; fi
That happens to the git-cloned version. The tar-zip version 1.1.2 does not have that problem, it compiles.

I don't get this error with my version of GNU make (3.81). Maybe the shell assignment syntax (!=) is not supported in your version of make. Could you try replacing that line by the following one and let us know if it works:
BEST = $(shell if ocamlopt 2>/dev/null; then echo .native; else echo .byte; fi)

Thanks!

yes, after replacing the line, make worked.
My make is the one that ships with fedora:
make --version
GNU Make 3.82
Built for x86_64-redhat-linux-gnu
Martin


ORC-1502: Upgrade Maven to 3.9.4

What changes were proposed in this pull request?
This PR aims to upgrade Maven to 3.9.4.
Why are the changes needed?
Apache Maven community starts to test Java 20 officially. Although this is only about a test coverage, we had better adopt it because 3.8.x is not tested officially by Apache Maven community.

https://issues.apache.org/jira/browse/MNG-7743
https://github.com/apache/maven/pull/1065

Here are the release notes.

https://maven.apache.org/docs/3.9.0/release-notes.html
https://maven.apache.org/docs/3.9.1/release-notes.html
https://maven.apache.org/docs/3.9.2/release-notes.html
https://maven.apache.org/docs/3.9.3/release-notes.html
https://maven.apache.org/docs/3.9.4/release-notes.html

How was this patch tested?
Pass the CIs with Java 21 EA build

I'll include this to next Apache ORC 1.9.x.

Can we update the README.md to reflect maven version as 3.9.4 from 3.8.8?
That was my 1st PR 😄

Sorry for missing your message here. I saw your PR before this. :)


Support for deploying to existing VPC

I've added some validation as well so folks don't waste time creating clusters and tracking down subnet conflicts in the cloudformation events logs when the create fails.

Nice work! Making a separate VPC for each k8s cluster would be a real pain :)

Hey thanks! This is great!

\cc @aaronlevy

@aaronlevy review items addressed.

@aaronlevy ready for review

Couple minor comments, but otherwise lgtm

How is this supposed to be used/configured in cluster.yaml? I'm assuming I'll need to build from git but don't see documentation in the repo.

@rothgar


Napari visualization of scaled images is broken

When using a scale parameter in ImageContainer, the spot coordinates do not get scaled, resulting in a mismatch between image and spots. This worked in commit 04ba5e8, but I believe it was broken in 2bfb439, as the coordinates no longer get multiplied by the scale.

Apologies, I used the wrong Squidpy version for this. Seems to work with 1.2.0, closing.


Investigate alternative Markdown parsers

We are still encountering issues with the Markdown2 parser, especially adding extra
 tags around closing tags. For example:

Curiosity: The Denary number system

▼

The base 10 (decimal) system is sometimes called denary, which is more consistent with the the name binary for the base 2 system. The word "denary" also refers to the Roman denarius coin, which was worth ten asses (an "as" was a copper or bronze coin).
The term "denary" seems to be used mainly in the UK; in the US, Australia and NZ the term "decimal" is more common.

The last 3 lines are causing issues with extra spacing appearing within closed panels. We already strip the many empty

 tags that appear within the code.

Was fixed in dbd1e64, where Markdown2 was replaced by Mistune. Also the way parsing has been altered (see commit for more details).


Wont download all the pictures from a specified user

In multiple situations i noticed that not all user works from the specified user have been downloaded. I think that the problem is in the works with the same name. I assume that whenever two or more works have the same name, only one is downloaded. Please fix this.
Best regards

Use something like filenameformat = %artist% (%member_id%)'\%image_id% - %title% in config.ini to make filenames unique, instead of %artist% (%member_id%\%urlFilename% - %title%.
Also, artist names can change, member_id is immutable, so you can have two folders for the same artist with default settings, instead of one.

Hmmmm.... tried that. Didnt solve the problem. Its not just the problem with the naming, because at the begining if e.g. there are 40 pictures the program says 37 pictures found. What could be the problem here? :/

which member id? Private images are excluded if you didn't have access to it.

I know. Pixiv id 1050942. 531 works, says 467 found.

Do you enable R-18 in pixiv website settings?

After changing the pixiv settings, you need to delete the old cookie value in config.ini

Yes i did, still doesn't work. I noticed the same issue with smaller users(e.g. ~30 works, some of which had the same name).

Try the latest beta version?

Works, thx


Add parameter in event OnAfterPostGLAndCustomer on codeunit 80 "Sales-Post"

Hi AL-Team,
can you please add new parameter in event OnAfterPostGLAndCustomer. The new parameter is PreviewMode: Boolean
The event should be
[IntegrationEvent(false, false)]
local procedure OnAfterPostGLAndCustomer(var SalesHeader: Record "Sales Header"; var GenJnlPostLine: Codeunit "Gen. Jnl.-Post Line"; TotalSalesLine: Record "Sales Line"; TotalSalesLineLCY: Record "Sales Line"; CommitIsSuppressed: Boolean;
WhseShptHeader: Record "Warehouse Shipment Header"; WhseShip: Boolean; var TempWhseShptHeader: Record "Warehouse Shipment Header"; var SalesInvHeader: Record "Sales Invoice Header"; var SalesCrMemoHeader: Record "Sales Cr.Memo Header"; var CustLedgEntry: Record "Cust. Ledger Entry"; var SrcCode: Code[10]; GenJnlLineDocNo: Code[20]; GenJnlLineExtDocNo: Code[35]; var GenJnlLineDocType: Enum "Gen. Journal Document Type";PreviewMode: Boolean)
begin
end;

Thanks for reporting this. We agree, and we’ll publish a fix asap, either in an update for the current version or in the next major release. Please do not reply to this, as we do not monitor closed issues. If you have follow-up questions or requests, please create a new issue where you reference this one.
Build ID: 46829.


Update cve-2021-31166.py

Hello dear friend,
I have to admit that the idea for this exploit is simply brilliant. Dear friend, I've made a little update, for this good decision... If you want it of course...
KR @nu11secur1ty S.A.I.E

I hope you are a well dear friend. And hope that you accept my proposal. Again brilliant idea! :D pa hahaha Mickey Mouse software. =) ;)

Thanks for working on this! I don't think this contribution adds any real value so I am going to respectfully decline it.
Cheers

Ok friend. :)
here, one line =)
poc = requests.get('http://<IP_ADDRESS>/', headers = {'Accept-Encoding': 'kur, putka, tupaci, psevdoIT, krastavichar, *, ,',})

BR

In the future, you can write me, dear friend. If you want, of course. We can make a lot of amazing things for the goodness of Microsoft. =) 👯
KR && exit 0;


Travis build failing types.TypeName has no field or method IsAlias

Error in master branch on Travis
https://travis-ci.org/apache/incubator-openwhisk-cli/builds/449687918
I don't think this is even our code, why do we rub golint on the whole thing including vendor libraries, instead of just the openwhisk code?
Found go 1.8 in /home/travis/.gimme/versions/go1.8.linux.amd64/bin/go, use it.
:goPrepare
Found global GOPATH: /home/travis/gopath.
:getGoLint# golang.org/x/tools/go/internal/gcimporter
../../../golang.org/x/tools/go/internal/gcimporter/bexport.go:212: obj.IsAlias undefined (type *types.TypeName has no field or method IsAlias)
 FAILED
FAILURE: Build failed with an exception.
* What went wrong:
Execution failed for task ':getGoLint'.
> Build failed due to return code 2 of:
  Command:
   /home/travis/.gimme/versions/go1.8.linux.amd64/bin/go get -tags '' -u golang.org/x/lint/golint
  Env:
   GOEXE=
   GOPATH=/home/travis/gopath
   GOROOT=/home/travis/.gimme/versions/go1.8.linux.amd64
   GOOS=linux
   GOARCH=amd64

@csantanapr - i believe there was some golint changes that need go 1.9


ROX-21997: Guard enriching netpols behind cluster check

Description
This PR introduces a guard to ensure Central doesn't return applied Network Policies for roxctl deployment check if --cluster is not provided in the call.
If no cluster is provided by the user, we cannot guarantee to return the correct Network Policies for any given deployment, as they are cluster-specific.
Checklist

[x] Investigated and inspected CI test results
[ ] ~Unit test and regression tests added~
[ ] ~Evaluated and added CHANGELOG entry if required~
[ ] ~Determined and documented upgrade steps~
[ ] ~Documented user facing changes (create PR based on openshift/openshift-docs and merge into rhacs-docs)~

If any of these don't apply, please comment below.
Testing Performed
Here I tell how I validated my change
I manually tested this by observing centrals debug output. We log Network Policies that central found to the Debug loglevel.

Deploy locally
Apply a deployment with a matching Network Policy (see attachment)
Set central LOGLEVEL env to debug
roxctl deployment check --cluster remote --namespace stackrox --file ./nginx.yaml
Observe central generating debug output "Found applied network policies ..."
roxctl deployment check --namespace stackrox --file ./nginx.yaml
Observe central NOT generating above debug output

Reminder for reviewers
In addition to reviewing code here, reviewers must also review testing and request further testing in case the
performed one does not seem sufficient. As a reviewer, you must not approve the change until you understand the
performed testing and you are satisfied with it.

Rebased to fix missing required CI step for scanner


Merge D3 UMAP plot

Merge into Daniel's branch

Formatting bug caused by version mismatch between conda and pip requirements


Separate autogenerated posts from manually created posts.

Is your feature request related to a problem? Please describe.
When writing notebook posts locally I'm finding it frustrating that autogenerated .md posts created from notebooks are being mixed in with my manual .md posts. This is also a little confusing with the images copied over from the notebooks into the /images folder. This makes managing commits difficult because some files need to be included while others ignored. It also makes it difficult to clear the state of your site because you have to delete the autogenerated posts.
Describe the solution you'd like
It would be simple if the project followed a simple rule to never mix autogenerated code into folders that contain manually created files.
Describe alternatives you've considered
When preparing the files for jekyll copy all the files to a new temporary folder rather than an existing folder.
Additional context
None

Hi @wroscoe the way Jekyll works is everything needs to be converted to .md in _posts.  The magic of fastpages it it allows you to see the intermediate step of this being converted for you.  The point is not for you to commit these files, however, they are just generated for you for debugging purposes.
Therefore, I don't believe it is possible to seperate autogenerated md posts from real md posts.  If you have an idea let me know, but they need to be put into _posts so you can see a preview of what they look like.
closing this issue for now, happy to keep discussing and we can reopen if we determine this is something that is possible.  Thank you

Thanks for the fast response. Still familiarizing myself with the workflow.

I don’t ignore them because the automated build process converts them on the fly so they are never committed to GitHub :)
The intermediate step of converting to md that you would normally have to do is automated once you push the notebook to GitHub,  but the intermediate step isn’t saved ( unless you turn that option on ), because it doesn’t need to be saved.
When you are debugging remotely, it’s often necessary to see the intermediate files
As such i don’t have them in .gitignore
You could if you named your notebooks a special way, I suppose

Would it make sense to have a separate folder _staging where all the markdown and image files are created and saved. This _staging folder would be what jekyll would use to create the site.
This wouldn't be needed if the only supported/recommend workflow is to edit/commit on github. But I've found the remote/local dev environment important as you work on notebooks that need specific libraries.
If you can link where in the code these folder are defined, I can take a stab a prototyping this flow. Cheers.

I don’t think that approach will work.  Jekyll requires you to put you to put things in _posts to render them
If you are very interested in this problem I highly recommend going through the Jekyll tutorials
https://jekyllrb.com/docs/


Class selector rule doesn't allow @-character

The selector-class-pattern rule doesn't allow @ characters. This makes it impossible to write something like:
.o-retain--no-padding\@until-desk
It's a nice pattern though, and used in Supple-css itself too.

I can update the regex for this use case, but the recommended ways to do this are the following:

Use of the responsive.in-query mixin: https://github.com/supple-kit/supple-css/tree/main/tools#mixin-responsivein-query
Use defaults.$responsive-modifier variable: .selector#{defaults.$responsive-modifier}until-desk {}

That's cool. The first solution only works with Supple 5, the second solution works for Supple 4 too.


Safe-guard for migrations

We had several problems with interrupted/failing migrations.
It would be nice

if we created a backup of the state before the migration.
if the migration failed and our upgrade guide is followed, an instance of the old version of Marathon takes over with the old state.
the user could also rollback manually to a backup.

Furthermore, with this infrastructure, we should prevent old versions of Marathon working on the migrated state since there interaction might corrupt it (Marathon shouldn't start up if the the ZK state is not compatible #3004). Since this is currently the only way to recover from migration failures (other than restoring a manual ZooKeeper backup), we can't do that without another rollback mechanism in place.

Related to #3005 and #3004

I started implementing this issue in https://github.com/unterstein/marathon/tree/fixes/3085_migration_safe_guard by enhancing the Migration class with the backup functionality and the indicator migrationInProgress. There are some TODOs left, but hopefully you get the idea :)

Hi Gastón,
like we discussed i implemented the restoreBackup functionality and solved some TODOs. I did this in a separate branch (https://github.com/unterstein/marathon/tree/fixes/3085_migration_safe_guard_2), because i did some "awaiting-madness" and i am not sure if this is correct. Maybe you could have a look and enhance this.
Same at the #startMigration functionality, where i think this check should be done in mockito, but didn`t know how to do it.
Intention: The first time store.load(migrationInProgressName) should return nothing and on the second call it should return the marker object. Is this possible?
Cheers
Johannes

@unterstein thanks for continuing working on this! I'll try to take a look at the new branch later this week.
Regarding the mocking/testing issue, it should be possible using: https://mockito.googlecode.com/hg-history/1.6/javadoc/org/mockito/InOrder.html

@gkleiman i solves the mockito issue through giving a list of results during the "results" helper, see MigrationTest#addBackupToFixture
Maybe you could have a look at the "waiting-madness". At some points synchronization is needed, but i believe these are too much waitings...
I also added the restore of the backup and a cleanup of the current zookeeper state.
I believe that https://github.com/mesosphere/marathon/issues/3004 should be solved, caused by the MigrationFailedException in Migration#startMigration and therefore no starting of marathon in this incompatible state.
Missing (maybe): Some functionality to reset migrationInProgess indicator automatically. Tried to handle this through text in exception message, saying to reset the indicator manually. Maybe you want to have an automatically reset.
Hope this helps

Note: This issue has been migrated to https://jira.mesosphere.com/browse/MARATHON-2981. For more information see https://groups.google.com/forum/#!topic/marathon-framework/khtvf-ifnp8.


Images aren't downloaded for non_tensor_fields

What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
Optimisation

What is the current behavior? (You can also link to an open issue here)
Images were downloaded, even if they were in a non_tensor_field

What is the new behavior (if this is a feature change)?
Images aren't downloaded if they are in a non_tensor_field

Does this PR introduce a breaking change? (What changes might users need to make in their application due to this PR?)
No

Have unit tests been run against this PR? (Has there also been any additional testing?)
New unit tests made. Unit tests in progress

Please check if the PR fulfills these requirements

[X] The commit message follows our guidelines
[X] Tests for the changes have been added (for bug fixes/features)
[] Docs have been added / updated (for bug fixes / features)

Unit tests in progress: https://github.com/marqo-ai/marqo/actions/runs/4141730708

Unit tests in progress: https://github.com/marqo-ai/marqo/actions/runs/4143037967


stream edit: Add support for adding all members of another stream or user group

In our stream settings UI, now that we have a pill-based system for representing objects to add to a stream's subscribers, it should be possible to add UI support for adding objects of a different type to in the "Add subscribers" UI.  For the moment, this should just be a simple frontend-only feature, similar in data model (but not visuals) to what we have for adding subscribers during stream creation, namely that you can select a stream, and it'll add make that pill that would add everyone who is on the other stream but not the stream currently being edited if one submits.
The display text on top of one of these pills can be "#stream name: 10 users", and in the data model, it'd store the Stream ID.  On submit, it's take the list of user IDs on the stream, filter it to remove existing subscribers, and include that list of new user IDs in what we send to the server to add new subscriptions.
Once that's done, we can do the same thing with user groups, the other defined collections of users that exist in Zulip and one might want to use for this purpose.
Versions of this have been a frequently requested feature in the past, but wasn't convenient to do before the recent pill UI changes.  It's important to note that this change doesn't do what some folks have requested, namely it wouldn't allow making a stream programmatically subscribed to another stream (which would mean new subscribers to the first stream would automatically be added/removed).  That feature idea is a big rabbit hole that I want to avoid here.

@zulipbot claim

I always worry about the use case that you want to add all the subscribers to a stream except for a few members.  I can think of plausible use cases--e.g. you want all the devs from Team X, but not the manager--but they might be rare enough that people can just remove them after the fact.


Consider adding floating point modulo function

In one of my project that I am working on, I found out that fmod is not available (or not with the same name). Consider adding one?

Thanks for the suggestion. Just added.


mark RustBox Send, but still not Sync

I propose another solution for #41 along #44.
The RustBox type is not thread safe, in the sense that multiple
threads may never alter the mutable state of a shared RustBox
at the same time, so it should not be marked Sync.
However, a RustBox type can safely be sent between threads so
it should be marked Send.
This patch makes it possible to wrap a RustBox struct inside
a Mutex type, so that it can still be used when the programmer
decides to do the synchronization theirself.

I think there are still some problems:
note: `core::cell::UnsafeCell<()>` cannot be shared between threads safely
note: required because it appears within the type `core::marker::PhantomData<core::cell::UnsafeCell<()>>`
note: required because it appears within the type `rustbox::RustBox`

Ah, NVM, it was complaining about Sync, not about Send.

For sending the RustBox type between threads, you can now wrap it inside a std::sync::Mutex. :)

Works great! 👍

I think it would be helpful to have an example that implements threading in the examples directory.

I'm really sorry for the significant delay on this. I appreciate you you all giving your feedback and for @dsprenkels for submitting the patch. Looks good to me.

No problem! :smile:

@gchp this is great! Any chance you can cut a new version of this crate with these changes? 😄🙏

@jmacdonald I just published 0.10.0

Thanks, @gchp!

No problem. Apologies for the delay. Let me know if you notice any issues.


fix(react-intl) use new locale-data imports for the languages

With the new version of react-intl, the locale data route has changed:
Instead of using react-intl/lib/locale-data/en the boilerplate should use react-intl/locale-data/en
This causes the project to fail when running npm run dev giving errors like:
ERROR in ./src/main.js
Module not found: Error: Cannot resolve module 'react-intl/lib/locale-data/fr' in src
 @ ./src/main.js 49:10-50

This pull request changes the imports so the project can run with npm run dev

Thank you!


sickgear: 0.17.5 -> 0.18.14

Motivation for this change
Things done

[ ] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
Built on platform(s)

[x] NixOS
[ ] macOS
[ ] other Linux distributions

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
[x] Tested execution of all binary files (usually in ./result/bin/)
[ ] Determined the impact on package closure size (by running nix path-info -S before and after)
[ ] Assured whether relevant documentation is up to date
[x] Fits CONTRIBUTING.md.

@GrahamcOfBorg build sickgear

Thanks; please consider adding yourself to the maintainers.

@rembo10 I think in the future, it would be a good idea to improve the installPhase.
It just drops everything into $out, when things probably should be copied to share/sickgear and then symlink the executable to bin from there.

@worldofpeace : sounds good - I can fix it up on the next release


Include ThenBlasGemm

Hi everybody,
I'm getting an unresolved external symbol ThenBlasGemm when compiling for GPU with CMake using MSVC 2015. This function isn't picked up by the script to create the def file for the DLL, so it isn't being exported. This PR just adds that function to the regex so the build works. Linker error below.
Does Windows CMake GPU not go through CI? I'm curious why this hasn't come up before.
Cheers
[D:\Projects\tensorflow\tensorflow\contrib\cmake\buildout\_gru_ops.vcxproj]
   199>blas_gemm.obj : error LNK2019: unresolved external symbol "public: class stream_executor::Stream & __cdecl stream_executor::Stream::ThenBlasGemm(enum stream_executor::blas::Transpose,enum stream_executor::blas::Transpose,unsigned __int64,unsigned __int64,unsigned __int64,double,class stream_executor::DeviceMemory<double> const &,int,class stream_executor::DeviceMemory<double> const &,int,double,class stream_executor::DeviceMemory<double> *,int)" (?ThenBlasGemm@Stream@stream_executor@@QEAAAEAV12@W4Transpose@blas@2@0_K11NAEBV?$DeviceMemory@N@2@H2HNPEAV52@H@Z) referenced in function "public: void __cdecl tensorflow::functor::TensorCuBlasGemm<double>::operator()(class tensorflow::OpKernelContext *,bool,bool,unsigned __int64,unsigned __int64,unsigned __int64,double,double const *,int,double const *,int,double,double *,int)" (??R?$TensorCuBlasGemm@N@functor@tensorflow@@QEAAXPEAVOpKernelContext@2@_N1_K22NPEBNH3HNPEANH@Z)

Nagging Assignee @protoget: It has been 21 days with no activity and this issue has an assignee. Please update the label and/or status accordingly.

Related PR by @gunan resolves this issue: https://github.com/tensorflow/tensorflow/pull/19415
If it is so close to the export limit, would it make sense to just make multiple dlls? Would get to be less stingy about what gets exported and what doesn't.

It actually does. One other things we are planning is defining a C/C++ API that can be used when building kernels and restricting exported symbols to only those. Right now, kernels can use anything in core TF framework.


Hyper-params settings for MNLI fine-tuning using Albert-v2

What hyper-parameter settings (learning rate, batch size etc.) have been used for fine-tuning Albert-v2 module on MNLI task? I am seeing accuracy of ~82.6 as compared to 84.6 reported in this repo for Albert v2.

I've followed the hyper parameters presented in the paper but only got accuracy of ~83.0. Have you figured out how to get the reported result? Thanks!

hi，I run the code according to the official command, but it doesn't reproduce the results,  only get accuracy of ~52.6, can you tell me where is wrong?


Convert Old Fetcher:  Paraguay

https://github.com/open-contracting/sample-data/blob/master/real-examples/paraguay/fetch.py

I started on this but put it on hold to work on something else.

Basically working now I think!


Add BOM Support

When using the Cargo CNB, you should have BOM entries for crates installed by Cargo.

@dmikusa-pivotal do you have a particular architecture in mind for this? Assuming we want to conform to the most recent SBOM RFC then we'd want to support both CycloneDX and SPDX.
CycloneDX has a rust cargo module: https://github.com/CycloneDX/cyclonedx-rust-cargo, which could be pre-built and provided by a new buildpack (probably called something like "cyclonedz-rust-cargo" and then the binary invoked in this buildpack. Alternatively I wonder if we could leverage https://github.com/paketo-community/cargo/issues/21 once implemented to install cyclonedx in this buildpack and skip the intermediate buildpack? I haven't fully thought through the implications of this second option, though.

I'm torn on this one.
On one hand, that tool looks nice. It's written by someone at OSWAP and seems to be actively maintained, at least at the moment. On the other hand, we still need a tool for SPDX (I didn't look to see if there's a reliably maintained tool that we could use for that). It's also more dependencies that we have to manage & install into the container.
On the other hand, I'm also thinking that this isn't too complicated of a problem to solve so the buildpack could implement it natively. Then we don't have to manage any dependencies/worry about how to install them into the container. It's also easier to test when you're not calling external commands.
Plus, getting the information from cargo isn't terribly difficult. We're already doing this for a couple of reasons, here's where we get the metadata, and we can use that plugin as an example for how to fetch the information from Cargo metadata.
Again, I haven't looked, but I'm hoping there are Go libraries for writing to SPDX and CycloneDX. That would make it all pretty easy to capture, write out the data, and ensure that we get compatible formatted files output.
@robdimsdale What are your thoughts? How are other language teams handling this?

If your RFC for Syft gets approved then I'd imagine we would want to explore that option? Although it looks like it doesn't yet support Rust, so we'd probably want to see if we can add Rust support to Syft.

Yes, Stephen shared that tool with me shortly after I wrote the note above. I definitely thing Syft is a strong contender. I didn't see support on their website, but when I ran the tool against some Rust apps it worked. There was also a PR that got merged a while back for Rust support, so I think it works they just don't mention it specifically, which is weird.

Oh, if it works then maybe it's just a matter of documenting that support on the README.


Is there a functionality and/or cli for database migrations?

Hi,
I was wondering if dogwater and/or waterline provide a way for database migrations like, for example, sequelize-cli does for Sequelize ORM.
What I would like to do is to run, for example, db:migrate --env=development and all tables and rows and columns are created automatically based on my models.
Thanks in advance.

Waterline itself has some migration strategies that can be set on a per-collection basis (see here).  However, they're not well-suited for production.  I would suggest using knex's migration features, which work quite well.
If you're using a some flavor of SQL with hapi I would highly suggest using Objection ORM with the schwifty hapi plugin, which is similar to dogwater.  That plugin has much more integrated support with migrations via knex.


SLO with two federated IDPs are not working properly.

When two federated IDPs are configured as multi-step authentication. When try to logout from SP, the logout request only goes for first federated IDP. The second federated IDP does not receive the logout request.

Thank you for your contribution!
We are closing this issue since it has not been prioritized for a long time. Chances are that it has already been solved in more recent versions. If not, we will be re-evaluating this when it becomes a priority.


How to gracefully shutdown the local server?

I'm firing up the local server in some tests. Is there a way to gracefully shut it down between tests or at the end of the XCTestCase?
I read that it can handle a TERM signal but I'm not sure how to send it directly to the local server and instead of the XCTest that is running.

I'm firing up the local server in some tests.

how are you doing that?

Sorry, I should have described that. I'm firing up the local lambda server.
As I'm describing my setup, I'm realizing that I should be breaking my code up a bit more to test the specific pieces of code. Thanks for the AWSLambdaTesting reference. I will take a look.
public static func main() {
  #if DEBUG && os(macOS)
  setenv("LOCAL_LAMBDA_SERVER_ENABLED", "true", 1)
  #endif

  // Initialize some immutable vars used in the callback

  Lambda.run { (context: Lambda.Context, request: APIGateway.V2.Request, callback: @escaping  (Result<APIGateway.V2.Response, Error>) -> Void) in
    // Handle request and call the callback
  }
}


How to use with Nuxt ?

Just copy&paste component to pomponents directory https://github.com/ivanvermeyen/vue-collapse-transition/blob/master/src/CollapseTransition.vue

Hi,
I'm not (yet) very familiar with Nuxt.
I noticed that I forgot to import the component in de README example, so I updated this:
<script>
  import { CollapseTransition } from "@ivanv/vue-collapse-transition"

  export default {
    components: {
      CollapseTransition,
    },
    data() {
      return {
        isOpen: false, // closed by default
      }
    }
  }
</script>

Is this different with Nuxt?

@ivanvermeyen that's not the problem, in nuxt show "window is not defined" this is a problem that happens in nuxt

Same problem here with me. The reason is, that nuxt is also trying to render it server side, I suppose. In /src/index.js is something with window. For me, I found a workaround. I used the .vue Component directly:
import CollapseTransition from<EMAIL_ADDRESS>
Now, nuxt is doing some magic and it just works.

@baijii worked for me too, thanks!

in nuxt.config.js:
    plugins: [       { src: '~plugins/collapse-transition.js', ssr: false }, ...     ],

Is there something I can do to make this package play nice with Nuxt?
Perhaps tweak index.js a bit? I'm no expert on that part :)


HDDS-8955. Add JAXB runtime to HttpFS classpath

What changes were proposed in this pull request?
Get rid of:
httpfs_1    | SEVERE: Implementation of JAXB-API has not been found on module path or classpath.
httpfs_1    | javax.xml.bind.JAXBException: Implementation of JAXB-API has not been found on module path or classpath.
httpfs_1    |  - with linked exception:
httpfs_1    | [java.lang.ClassNotFoundException: com.sun.xml.internal.bind.v2.ContextFactory]
...
httpfs_1    | 	at org.apache.hadoop.http.HttpServer2.start(HttpServer2.java:1301)

https://issues.apache.org/jira/browse/HDDS-8955
How was this patch tested?
Ran httpfs acceptance tests locally, verified exception is gone.
CI:
https://github.com/adoroszlai/hadoop-ozone/actions/runs/5411417691

Thanks @ayushtkn, @jojochuang for the review.


use a single Resolver instance

Fixes https://github.com/dart-lang/build/issues/119
The Resolver class should be safe to reuse for multiple Transformer instances, the resolve method appends to the assets that are resolved and avoids re-entry in the middle of resolving.

LGTM... just something to keep in mind: it's been a while since I played with code-transformers, but I wonder if more sharing like this can cause deadlocks. In the past we had issues with deadlocks, in great part because we didn't release a resolver correctly, but I can't recall if some subtle deadlock situations also came up when running more than one transformer in parallel (which pub-build sometime does, IIRC). It is possible that your change is fine with respect to that, but I'm not 100% sure, it might be worth double checking with @jakemac53 when he returns.

We can hold of on merging.
I tested this with a lot of clients and didn't see any deadlocks but I don't have enough of the historical context to know why this is safe.

This definitely scares me a bit, I remember the reflectable package had some issues with the use_shared_sources option previously so it would likely have issues with this change.  Can you try the polymer 1.0 tests with this as well (https://github.com/dart-lang/polymer-dart)? If those pass, then I think it is probably worth releasing this as a breaking change, as it would certainly provide a lot of benefit and is worth the risk of unknown/weird behavior.