Retry on rate limiting

This treats ResponseParserErrors as retryable, as well as ClientErrors if they contain SlowDownin the message. This can mitigate/fix #484, and is a non-mutually-exclusive alternative to #619. Where that PR tries to address rate limiting at the request time, this tries to address it in the responses.
In my testing with the snippet here, this helps a lot, but is not a complete fix, as I still often exhaust the default retries. So I might be in favor of both this and #619 (or something similar to it based on asyn._run_coros_in_chunks)

Okay, I've also added _run_coros_in_chunks to accomplish a similar batching to what I did in #619. This appears to work to avoid rate limiting even in the absence of the built-in minimum times that I added over there. So if it would be simpler to consolidate that logic, I'm happy with this approach.

Yep, that would be best! Though it would require coordinated releases.
On Sat, Apr 30, 2022 at 3:50 AM Batuhan Taskaya @.***>
wrote:

@.**** commented on this pull request.
In s3fs/core.py
https://github.com/fsspec/s3fs/pull/620#discussion_r862342294:

@@ -12,14 +12,21 @@

from fsspec.spec import AbstractBufferedFile
from fsspec.utils import infer_storage_options, tokenize, setup_logging as setup_logger
-from fsspec.asyn import AsyncFileSystem, sync, sync_wrapper, FSTimeoutError
+from fsspec.asyn import (

AsyncFileSystem,
sync,
sync_wrapper,
FSTimeoutError,
_run_coros_in_chunks,

We could even expose it as a public function directly from fsspec.
—
Reply to this email directly, view it on GitHub
https://github.com/fsspec/s3fs/pull/620#discussion_r862342294, or
unsubscribe
https://github.com/notifications/unsubscribe-auth/ABLWQNYUOZAXZXMZFUHR6NDVHUF7JANCNFSM5UXJ2CFA
.
You are receiving this because you authored the thread.Message ID:
@.***>

S3fs is sister to and closely tied to fsspec - they are always released together. I prefer to keep the function "private" to indicate that ordinary users would not be expected to call it.

Yep, I’m aware they’re both released by you :)
If you’re okay with the cross-repo private import, then I am as well

@isidentical , I'm happy with this if you don't have more to say.

Thanks @martindurant!


Convert image to web component

Jira

http://vjira2:8080/browse/BDS-531

Summary
Convert bolt-image to a web component.
Details
Extend bolt-image component so that image can be rendered both by twig and web component.
Key changes
Schema

Add no_lazy (commit), placeholder_color, placeholder_image, and ratio props (commit) for Web Component use only.

Twig

Change internal Twig vars from snake_case to camelCase (commit).
Use src not placeholderSrc in fallback image (commit).
Include <noscript> tag if lazyload is true. Previously, required height, width, and useAspectRatio to be true, too (commit).

CSS

Fix whitespace issue when useAspectRatio is false (commit).

Core

Remove unused "changecase-objects" library (commit) and add new "change-case" library. Format schema data before validating against web component props, which are always camelCase (commit).
Add containsTagName() helper JS function (commit). Ultimately, this was not used on image component, but I think this is helpful and vote to keep it.

Build

Fix image size logic in build task (commit).

Background Component

Add cover prop, used when an image needs to fill its container, i.e. object-fit (commit). Update background component to pass cover prop, fix lazyload logic (commit).

How to test
Caveats:

The Image Twig component has been somewhat cleaned up, but a full-clean up is pending completion of the initialize props work, which will set a new standard for our Twig files.
Lazyloading works, but we need a better implementation in the future. Currently, on web components, lazy images are revealed right after render. Say we wanted to load only in-view images, this implementation would not suffice.
Need to add option for inline-block images. I will create separate ticket for this task.

Review these files:

image.schema.yml
image.twig
image.css
image.js
bolt-base.js
background.twig
device-viewer.standalone.js

Review these pages for visual/functional regressions:

Images
Background
Figure
Cards

Review new demo page:

Image with Web Components

@danielamorse @sghoweri
There's an on going bug with the image component, when ratio is set of false, it creates extra spacing top and bottom, this could be solved by making the img tags inside display: block;, but you might have a different solution.
Another issue that people have complained about is bolt-image is always taking up the full width if a container, if we can actually give the option of inline or block image display, that would make it easier for building different kinds of layouts. Not sure if that belongs in this PR, make a separate task if we should do it in another task.
Thank!

Same comment as Adam.

Right now it's mishmash with attributes (some are snake_case others camelCase and nocase eg. (lazyload, no_lazy, useAspectRatio).

@mikemai2awesome @adamszalapski agreed, it's kind of a mess right now. Unfortunately, that's because we're using the new standard (snake_case) for new props while trying not to break any of the old (camelCase) props. lazyload I was actually seeing as one word.
I think this will be less messy once we have separate schemas/docs for Twig and Web Components. In the meantime, do you think it's worth deprecating camelCase props like useAspectRatio? I opted not to deprecate this one because I wanted it to be as easy as possible to adopt the new web component version of bolt-image. Thoughts? cc: @sghoweri

@danielamorse from my perspective, if we have two props with almost the same behavior, will create more problems then utility. We should deprecate the old one prop.

@adamszalapski @mikemai2awesome deprecated useAspectRatio, height, and width props and updated all references in our code: commit #1, commit #2.
@sghoweri debugged the lazyloading issue that led me to add a setTimeout. It was indeed a race condition. lazySizes only unveils image elements once they're complete. Fixed: commit.

I think we might still need a little additional work relating to “auto width” vs “full width” behavior (ie. should the component fill the parent container? should it exceed the default image size?, etc) which is likely tied in with the inline-block note mentioned in the description.
In any case, very nice work guys! This is easily one of the most complex components in Bolt and you guys crushed it 🙏


Figure out way to deduplicate colab tutorials and the tutorials that get built in our docs

Do this after https://github.com/pytorch/functorch/pull/519 goes in

Current thinking: configure myst-nb to ignore sections that have a heading that includes the text "(Colab Only)".

Might take me a while to get to it

Done.


DateTimeFormat: actually use dateTimePart, dateTimeRangePart

@cknitt this one ready to go?

Yes, sorry, seems I forgot to assign a reviewer.


IO-700: provide method overload for moveFile

added test cases
updated javadoc for "copy and delete" with setLastModified

So far the test cases seem ok for me:
The failing tests FileUtilsCleanDirectoryTestCase were introduced with commit 0cee29aa4c1818963ed1a55058219282e89d7488 and failed in my workspace before changing anything.
The AbstractInputStreamTest.tearDown IllegalAccess error also happened before, eg. in pull 181. Seems unrelated with my changes.

So far the test cases seem ok for me:
The failing tests FileUtilsCleanDirectoryTestCase were introduced with commit 0cee29aa4c1818963ed1a55058219282e89d7488 and failed in my workspace before changing anything.
The AbstractInputStreamTest.tearDown IllegalAccess error also happened before, eg. in pull 181. Seems unrelated with my changes.

So far the test cases seem ok for me:
The failing tests FileUtilsCleanDirectoryTestCase were introduced with commit 0cee29a and failed in my workspace before changing anything.
The AbstractInputStreamTest.tearDown IllegalAccess error also happened before, eg. in pull 181. Seems unrelated with my changes.

I must have messed up, the build passed for me locally, but, obviously it's broken. I will look...

So far the test cases seem ok for me:
The failing tests FileUtilsCleanDirectoryTestCase were introduced with commit 0cee29a and failed in my workspace before changing anything.
The AbstractInputStreamTest.tearDown IllegalAccess error also happened before, eg. in pull 181. Seems unrelated with my changes.

I must have messed up, the build passed for me locally, but, obviously it's broken. I will look...

Thanks, just let me know if I should rebase and push again.
ps. I'm pretty new in the open-source / github community, so sorry for any rookie mistake :)

Thanks, just let me know if I should rebase and push again.
ps. I'm pretty new in the open-source / github community, so sorry for any rookie mistake :)

Coverage increased (+0.003%) to 88.978% when pulling 380fc037cb85b424eb8963b9ee23833515b5f127 on tza:master into 73a31d9a2f0f194a2e115f33fbf6786ef056408d on apache:master.

Coverage increased (+0.003%) to 88.978% when pulling 380fc037cb85b424eb8963b9ee23833515b5f127 on tza:master into 73a31d9a2f0f194a2e115f33fbf6786ef056408d on apache:master.


sdba - Broadcasting with two new coordinates of differing dimensions fails

xclim version: master
Python version: 3.8
Operating System: Linux

Description

In QuantileDeltaMapping.adjust with grouping (here 'time.month') there is a broadcasting operation that fails when sim and hist have additional dimensions (other then quantiles and time).
In fact, calls of xclim.sdba.utils.broadcast fails when grouping is used, interp is not 'nearest' and both grouped and the coordinate in sel have dimensions that are not trageted by the broadcasting operation.
What I Did

from xclim.sdba.adjustment import QuantileDeltaMapping
QDM = QuantileDeltaMapping(group='time.month', interp='linear'
QDM.train(ref, hist)
scen = QDM.adjust(sim)

Where, ref has one spatial dim + 'time' and hist and sim have the same spatial dim, 'time' and an additional dim, in my case realization.
What I Received

ValueError: axes don't match array

The traceback is quite long, but it all comes down to xr.interp.

xarray's interp doesn't understand multidimensionnal interpolation when the new coordinates have differing set of coords, so I tried to broadcast all arrays of the  sel dictionary together which makes it work but enlarges the arrays a lot. Hopefully, no data is created so memory should be ok. However, dask arrays chunked along one of the additional dimensions will make broadcast fail. So, that's not a solution.
Kinda stuck on this. A way would be to call a xr.apply_ufunc with a wrapper of  scipy.interpolate.interpn, but that's a lot of machinery just because xarray as kind of a bug.

Is there an open issue about this ?

Not that I can found.

I suggest you design a short, self-contained example illustrating the issue and open an issue with it.

I didn't realize up to now, but it is worth noting that xarray raises a "NotImplementedError". It's not a real bug.

Corresponds to issue pydata/xarray#4058.


Incorrect middleware order

Do you want to request a feature or report a bug?
Bug
What did you do?
I am aware that midleware definition order is the calling order, but on the dashboard it shows different order of the definition order
Here is the IngressRoute definition order for Kubernetes
- kind: Rule
  match: PathPrefix(`/`)
  middlewares:
     - name: my-strip-prefix
     - name: my-headers
     - name: my-errorpage

What did you see instead?
Dashboard showing different order of middlewares (every refresh it shows different orders)

Output of traefik version: (What version of Traefik are you using?)
Version:      2.4.8
Codename:     livarot
Go version:   go1.16.2
Built:        2021-03-23T15:48:39Z
OS/Arch:      linux/amd64

Hello,
the dashboard displays a list without any order.
There is no bug because we did not say that the dashboard displays the middleware in a particular order.

@ldez should the dashboard display with the correct order? and convert it to feature

IMO, there is no "correct" order.


Added Ford-Fulkerson algorithm in java

Ford-Fulkerson algorithm in java lang hope you support me by adding hacktoberfest label

Do give Star to this repo.. happy hacking.


Support conversion of Obsidian-style embedded images (![[image.png]]) to Markdown format for Quarto ()

Embedded images in Obsidian format (![[image.png]]) aren't converted to the appropriate Markdown syntax (), which causes missing images in the final .qmd file when rendered in Quarto.
Requested Feature:
It would be helpful if the plugin could recognize and convert Obsidian-style image embeds into standard Markdown image links, either by default or as an optional setting. This feature would streamline the process of converting notes with embedded media for Quarto presentation.

Fixed in latest release


remove  markdown formatting

Bot messages had four leading spaces added to them; remove this.

Thanks! Once I make halflife send a json, I'll format the message like a report. Till then, this should work.


add librato output plugin, update datadog plugin

The following PR serves 2 purposes:

add a new output plugin for sending metrics to Librato
update datadog output plugin to skip any metric where the value cannot be converted to a float64

Also added READMEs for each output.

looks great, thanks much @jipperinbham :+1:

Some style suggestions, which would be more inline with how we code in Core. Not a big deal however.


Add integration tests for Signal

Merge this PR for now, the configuration change is only a quick fix to unblock the integration tests. Also offline discussed with @prudrabhat, we will create another PR to clean up the configuration logic and add more tests.


nsxt_rest execution module and unit test

Hi @waynew, this module was provided as a nsxt wrapper to the http module, to handle the use cases for which we don't have a module or state code prioritised as phase 1.


Sum of Elements of Linked List (C++)

I cannot see any program for adding the data elements of linked list.
I want to contribute with the same using recursion as well as without recursion in the Basic DSA folder.
Can you assign this to me ??

Go Ahead!

#169 can you please review this :)

#172 I have done the task assigned, hope you will review it soon, and merge if its okay, otherwise you can tell me the error, thanks in advance. :)


[main] Upgrade to latest dependencies

Cron -knative-prow-robot
/cc knative-sandbox/kn-plugin-operator-approvers
/assign knative-sandbox/kn-plugin-operator-approvers
Produced by: knative-sandbox/knobots/actions/update-deps
Details:
bumping knative.dev/operator 182e3ab...fcb31ba:
  > fcb31ba upgrade to latest dependencies (# 1046)
  > 17fddfd Continue to develop operator (# 1045)

/lgtm
/approve


feat: adds volsync

Description of the change
Adds new backup system volsync
Benefits or applicable issues
Option to migrate to different storage manager like rook/ceph or ebps

🦙 MegaLinter status: ✅ SUCCESS

Descriptor
Linter
Files
Fixed
Errors
Elapsed time

See detailed report in MegaLinter reports
Set VALIDATE_ALL_CODEBASE: true in mega-linter.yml to validate all sources, not only the diff
MegaLinter is graciously provided by


Revalidation stop working after a while time

Describe the bug
Hi! No one has encountered such a problem that on the main page of the application, after a while time, it is on the English locale that the revalidate in the getStaticProps stops working, as soon as I change the language to any other and refresh the page, fresh data comes
Occurs in next-i18next version
Nextjs v11.0.1, next-i18next v8.5.1

Are you able to provide any further info or documentation of this issue?


CLOUD-66888 enable access for cloudbreak to the clusters on aws.

@martonsereg or @akanto  pls review

Additional thing that this won't work with Cloudbreak RDS, in case when your control plane instance died, but you start a new instance from that RDS (even you are in the same vpc and subnet), because your ip has already changed. We can fix this issue in the next pull.


fcswatch tool fails with DirectoryNotFoundException

I wanted to try out the fcswatch global tool on my solution to see if it worked.  We've got a main project that's a Giraffe server and it has a bunch of project dependencies.  When I run the fcswatch global tool, it builds just fine and then fails with the following error:

/Users/nat/Projects/shopmasse-backend/fsharp/src/Masse.API/RouteHandler.fs(28,48): warning FS0044: This construct is deprecated [/Users/nat/Projects/shopmasse-backend/fsharp/src/Masse.API/Masse.API.fsproj]
/Users/nat/Projects/shopmasse-backend/fsharp/src/Masse.API/RouteHandler.fs(32,55): warning FS0044: This construct is deprecated [/Users/nat/Projects/shopmasse-backend/fsharp/src/Masse.API/Masse.API.fsproj]
    2 Warning(s)
    0 Error(s)

Time Elapsed 00:00:13.95
ERRORS: System.IO.DirectoryNotFoundException: Could not find a part of the path '/Users/nat/Projects/shopmasse-backend/fsharp/Masse.Catalog.Sql/Masse.Catalog.Sql.fsproj'.
   at Interop.ThrowExceptionForIoErrno(ErrorInfo errorInfo, String path, Boolean isDirectory, Func`2 errorRewriter)
   at Microsoft.Win32.SafeHandles.SafeFileHandle.Open(String path, OpenFlags flags, Int32 mode)
   at System.IO.FileStream..ctor(String path, FileMode mode, FileAccess access, FileShare share, Int32 bufferSize, FileOptions options)
   at System.IO.FileStream..ctor(String path, FileMode mode, FileAccess access, FileShare share, Int32 bufferSize)
   at System.Xml.XmlDownloadManager.GetStream(Uri uri, ICredentials credentials, IWebProxy proxy, RequestCachePolicy cachePolicy)
   at System.Xml.XmlUrlResolver.GetEntity(Uri absoluteUri, String role, Type ofObjectToReturn)
   at System.Xml.XmlTextReaderImpl.OpenUrl()
   at System.Xml.XmlTextReaderImpl.Read()
   at System.Xml.XmlLoader.Load(XmlDocument doc, XmlReader reader, Boolean preserveWhitespace)
   at System.Xml.XmlDocument.Load(XmlReader reader)
   at System.Xml.XmlDocument.Load(String filename)
   at FcsWatch.Core.Types.FullCrackedFsprojModule.loop@202.Invoke(String projectFile) in C:\projects\fcswatch\src\FcsWatch.Core\Types.fs:line 209
   at FcsWatch.Core.Types.FullCrackedFsprojModule.loop@202.Invoke(String projectFile) in C:\projects\fcswatch\src\FcsWatch.Core\Types.fs:line 215
   at FcsWatch.Core.Types.FullCrackedFsprojModule.loop@202.Invoke(String projectFile) in C:\projects\fcswatch\src\FcsWatch.Core\Types.fs:line 215
   at FcsWatch.Core.Types.FullCrackedFsprojModule.loop@202.Invoke(String projectFile) in C:\projects\fcswatch\src\FcsWatch.Core\Types.fs:line 215
   at FcsWatch.Core.Types.FullCrackedFsprojModule.loop@202.Invoke(String projectFile) in C:\projects\fcswatch\src\FcsWatch.Core\Types.fs:line 215
   at FcsWatch.Core.Types.FullCrackedFsprojModule.loop@202.Invoke(String projectFile) in C:\projects\fcswatch\src\FcsWatch.Core\Types.fs:line 215
   at FcsWatch.Core.Types.FullCrackedFsprojModule.easyGetAllProjPaths(String entryProjectFile) in C:\projects\fcswatch\src\FcsWatch.Core\Types.fs:line 217
   at FcsWatch.Core.Types.FullCrackedFsprojModule.getAllCrackedFsprojs(String projectFile) in C:\projects\fcswatch\src\FcsWatch.Core\Types.fs:line 256
   at FcsWatch.Core.Types.FullCrackedFsprojModule.create@310-7.Invoke(Unit unitVar) in C:\projects\fcswatch\src\FcsWatch.Core\Types.fs:line 342
   at Microsoft.FSharp.Control.AsyncPrimitives.CallThenInvoke[T,TResult](AsyncActivation`1 ctxt, TResult result1, FSharpFunc`2 part2)
   at Microsoft.FSharp.Control.Trampoline.Execute(FSharpFunc`2 firstAction)
--- End of stack trace from previous location where exception was thrown ---
   at Microsoft.FSharp.Control.AsyncResult`1.Commit()
   at Microsoft.FSharp.Control.AsyncPrimitives.RunSynchronouslyInCurrentThread[a](CancellationToken cancellationToken, FSharpAsync`1 computation)
   at Microsoft.FSharp.Control.AsyncPrimitives.RunSynchronously[T](CancellationToken cancellationToken, FSharpAsync`1 computation, FSharpOption`1 timeout)
   at Microsoft.FSharp.Control.FSharpAsync.RunSynchronously[T](FSharpAsync`1 computation, FSharpOption`1 timeout, FSharpOption`1 cancellationToken)
   at FcsWatch.Core.Types.crackedFsprojBundle@530.Invoke(FSharpMailboxProcessor`1 inbox) in C:\projects\fcswatch\src\FcsWatch.Core\Types.fs:line 547

I see it's trying to access a path '/Users/nat/Projects/shopmasse-backend/fsharp/Masse.Catalog.Sql/Masse.Catalog.Sql.fsproj' which doesn't exist.  The actual path is '/Users/nat/Projects/shopmasse-backend/fsharp/src/Masse.Catalog.Sql/Masse.Catalog.Sql.fsproj'.  I'm not sure why the src is getting cut out.
Any idea how I can troubleshoot this issue?  I'm using macOS and fcswatch version 0.7.2.

Another piece of information that might be useful: Masse.Catalog.Sql is a transitive project dependency, not a direct one.

Hello, @NatElkins
Can you upload a sample.zip to me so i can reproduce it....
You don't need include the source files,
Only the projects is enough.
Thanks very much for your report

Hi @humhei ,
Thanks so much for the quick response!
Here are the projects without source code:
repro-projects.zip
The project I was trying to run is Masse.API.fsproj.

Released as 0.7.4


Use per-method files when importing lodash

This decreases file size:
Before
Non-min: 3.8mb
Min: 285kb
After
Non-min 2.6mb
Min: 231kb
Testing using the dist files will be needed as I don't have a project setup on this computer for it.
Here's lodash's documentation on this:
https://lodash.com/per-method-packages

Thank you!
THAT is beautiful!  I had poked at trying to remove lodash entirely for exactly the bundle size reason some time ago, but I didn't want to risk the side effects of replacing the merge function with something inferior, and having it come back to bite me in scenarios that aren't covered by automated testing.
With the test upgrades over the last several months, I'm much more confident that auto testing will catch if changes like this break things.
If you'd like to, please add yourself to the contributors array in package.json !

@ericblade Cheers, I'd be super grateful, if you could add the tag hacktoberfest-accepted to this PR once merged.

Ah, sure, I just had to lookup what that was about.  Looks like I'll have to add it to the repository topics as well.  Thank you!

Good stuff! Another benefit is that webpack's default chunk size that it complained at was 250kb so now that we're below that user's should hopefully not get any messages about size. 👍


Group showing same icon

In previous versions, i have pinned Firefox versions together, and they showed each icon, for Beta, Dev and nightly. Since version 2 all them show the normal firefox icon, and not the individual one's. Deleted old version 1 and created the group again with version 2 and its the same. Windows 10 20H2

Where did you add the Firefox applications from? Is it through shortcuts on the Windows desktop or some other folder?
Can you try what happens when you directly add the .exe in for Firefox Beta, dev, and Nightly
I can't seem to reproduce it when Firefox and Firefox Nightly.
I did get them through Windows Key -> Search Firefox/Firefox Nightly -> Right Click + Open file location
Which led me to C:\ProgramData\Microsoft\Windows\Start Menu\Programs
I added the two Firefoxes from there and I tried from the Desktop.
On top of that, is there anything unique about the installation of those programs that you think may affect it?

Where did you add the Firefox applications from? Is it through shortcuts on the Windows desktop or some other folder?
Can you try what happens when you directly add the .exe in for Firefox Beta, dev, and Nightly
I can't seem to reproduce it when Firefox and Firefox Nightly.
I did get them through Windows Key -> Search Firefox/Firefox Nightly -> Right Click + Open file location
Which led me to C:\ProgramData\Microsoft\Windows\Start Menu\Programs
I added the two Firefoxes from there and I tried from the Desktop.
On top of that, is there anything unique about the installation of those programs that you think may affect it?

ah right, i was loading them from program files, that works your way. It does not work for Edge Browser, which loaded from C:\ProgramData\Microsoft\Windows\Start Menu\Programs just shows standard icon for Beta etc.

ah right, i was loading them from program files, that works your way. It does not work for Edge Browser, which loaded from C:\ProgramData\Microsoft\Windows\Start Menu\Programs just shows standard icon for Beta etc.


Adds user entitlements to JWToken.

[#134825047]
https://www.pivotaltracker.com/story/show/134825047
I am keeping this small to keep the changes necessary in holms.monolith small because this is a breaking change.
The plan here is to let the caller of the token create the JSON that gets saved in the entitlements. Maybe that is or is not the best way to do things. Thoughts?

@eldavido PTAL

@eldavido PTAL

@eldavido I removed the ACC from proto. This is now a major breaking change. PTAL

@eldavido PTAL

i'm not positive that JSonConvert will be able to turn this thing into an IEnumerable. I wanted to add unit tests, but the NUnit package isn't compatible with our framework


Send app's full url in SCW popup setup request

Summary

Send the app's full URL when setting up the SCW popup
How did you test your changes?

🟡
Heimdall Review Status

Item
Status
More Info

Minimum Required Reviews

🟡
0/1

Show calculation

Show calculations

1 if user is bot
0

1 if user is external
0

From .codeflow.yml

1

Additional review requirements

Show calculations

Max
0

0

From CODEOWNERS

0

Global minimum
0

Max

1

1

1 if commit is unverified
1

Sum
2

📝 Heimdall docs
·
🕵 Advanced details
·
♻ Refresh Heimdall
·
#⃣ #ask-heimdall


2-factor auth support

 Issue by sym3tri
Friday Jul 24, 2015 at 19:29 GMT
Originally opened as https://github.com/coreos-inc/auth/issues/335

would be a nice feature to have

dupe of #352


Allow viewing of the latest configurations without publishing the form

Currently, public portal only allows a published form to be viewed. It should be possible for a user to view the latest changes without publishing the form

Related Item
#1174

Hey @Lukeybooi Please note that this is still not resolved. Find the screenshots below


Improve security of the solution via e.g. MD5 checksums

Allowing native code to run on anybody's machine is dangerous.

Currently download_libs.sh doesn't contain md5 checksums. IMHO this is necessary.
Ideally a developer should never add those to native folder but actually only it should be done via CI upon verification of md5 checksums

There could be other measures / ideas taken for this but the things above should be minimum, especially that project is from cryptocurrency / where trojan horses stealing things like wallet passwords are common.

Alternatives to discuss / think about:

Find a way to import cargo crates into gradle project
Merge those two projects together: aiken-jna-wrapper and aiken-java-binding and invoke cargo via gradle tasks.


Operation gets cancelled when backgrounded

What is the bug?
when syncing there's an error
error:The operation couldn’t be completed. (GRPC.GRPCStatus error 1.) this is a cancelled operation
Solution
handle cancellation gracefully

We will likely just handle the error better, rather than find a solution (for this pass).


Added mps related functions for device

The device.rs has Mps device, however it doesn't have utility functions associated with it. Added is_available, mps_if_available, is_mps functions similar to Cuda.

@LaurentMazare any thoughts?


Generating background from short segments

I have a lot of different files for my background.
However, If I have a background files which is shorter than the duration specified for a sounscape, the end of my file has no background noise. Am I doing something wrong ?
If not, would it be possible to imagine one of this solution:

duplicate the background until the duration needed

pick another background file and concatenate it with the previous one.

has the advantage of keeping a consistent environment in the background.

@turpaultn if your background file is shorter than your soundscape duration then the current implementation should concatenate the bg file to itself as many times as needed to fill the soundscape duration (i.e. option 1 you describe): https://github.com/justinsalamon/scaper/blob/7fb77a92cf9fda15aae7defb5a3d826f87877b4e/scaper/core.py#L1651-L1685
Are you not observing this behavior? If so, can you please post a MWE here so I can try and reproduce this issue?

from scaper import Scaper

sc = Scaper(10, "synthetic/audio/eval/soundbank/foreground", "synthetic/audio/eval/soundbank/background")
sc.add_background(("const","freesound"), ("const","synthetic/audio/eval/soundbank/background/freesound/noise-free-sound-0145.wav"), ("const", 0))
fname = "test_bg"
sc.generate(f"{fname}.wav", f"{fname}.jams")

sc = Scaper(10, "synthetic/audio/eval/soundbank/foreground", "synthetic/audio/eval/soundbank/background")
sc.add_background(("const","freesound"), ("const","synthetic/audio/eval/soundbank/background/freesound/noise-free-sound-0145.wav"), ("const", 0))
fname = "test_bg_fg"
sc.add_event(("const", "Blender"), ("const", "synthetic/audio/eval/soundbank/foreground/Blender/56563_0.wav"),
             ("const", 0), ("const", 5), ("const", 5), ("const", 6), ("const", 0), ("const", 1))
sc.generate(f"{fname}.wav", f"{fname}.jams")

I did a minimum tar archive here (link available 2 weeks):  audios.tar.gz
Otherwise, the data are part of : DESED_synth_soundbank.tar.gz
The behavior observed:
The background file is 3 seconds, the duration wanted is 10 seconds.

In the first case with no foreground events, the audio file lasts 3 seconds (same time as the background)
In the second case, the audio lasts 10 seconds and the background stops after 3 seconds.

After a little debug part, it seems the problem comes from the trimming part.
https://github.com/justinsalamon/scaper/blob/7fb77a92cf9fda15aae7defb5a3d826f87877b4e/scaper/core.py#L1670-L1673
Indeed, in the actual code, we trim to the length of the background event.
However, the value of background event_duration is trimmed if it is too long, but nothing is done if it is too short.
https://github.com/justinsalamon/scaper/blob/7fb77a92cf9fda15aae7defb5a3d826f87877b4e/scaper/core.py#L1303-L1313
I don't know how much it could impact the code to change this:
 # Then trim
 cmb.trim(e.value['source_time'],
          e.value['source_time'] +
          self.duration)

Otherwise, I tried on my side to add a condition L1331-1355 when (event_duration < self.duration), however, I have a problem with the condition checked here if source_time + event_duration > source_duration:
https://github.com/justinsalamon/scaper/blob/7fb77a92cf9fda15aae7defb5a3d826f87877b4e/scaper/core.py#L1370-L1376
Hope this can help.

Hm, so just looking at this briefly - isn't the background concatenated here in core.py:
https://github.com/justinsalamon/scaper/blob/7fb77a92cf9fda15aae7defb5a3d826f87877b4e/scaper/core.py#L1683-L1685
That's a bit further down. If that line is working as expected, perhaps the error is here in ntiles.
https://github.com/justinsalamon/scaper/blob/7fb77a92cf9fda15aae7defb5a3d826f87877b4e/scaper/core.py#L1661-L1662
I'll reproduce using your code first and get back to you.

Okay ran your example. I can reproduce the bug. So looking at what sox actually does under the hood, it seems the command it executes is as follows:
sox -D -V2 --combine concatenate -v 1 synthetic/audio/eval/soundbank/background/freesound/noise-free-sound-0145.wav -v 1 synthetic/audio/eval/soundbank/background/freesound/noise-free-sound-0145.wav -v 1 synthetic/audio/eval/soundbank/background/freesound/noise-free-sound-0145.wav -v 1 synthetic/audio/eval/soundbank/background/freesound/noise-free-sound-0145.wav -c 1 /var/folders/5h/6vxlzhys259350xz4nb3xbym0000gn/T/tmp3gck8ybd.wav rate -h 44100.000000 trim 0.000000 2.912187

for your example. ntiles is set correctly (2.91 * 4 > 10). This appears to not apply the trim to each audio file and then combine, but rather first concatenates and then trims it to event_duration, which is the behavior you're seeing. The correct sequence of commands should be like:
sox -D -V2 --combine concatenate -v 1 synthetic/audio/eval/soundbank/background/freesound/noise-free-sound-0145.wav -c 1 temp.wav rate -h 44100.000000 trim 0.000000 2.912187
sox -D -V2 --combine concatenate -v 1 temp.wav -v 1 temp.wav -v 1 temp.wav -v 1 temp.wav -c 1 out.wav rate -h 44100.000000 trim 0 10

Will dig into this a bit more.

Thank you very much.

Here's the entirety of the fix (backwards compatible). Turns out the event duration was being screwed up causing a very short trim. The event duration changes were introduced in #53 (by me - oops). But in the test cases, we never try anything with that short of background files. All of the background files are between 45 and 60 seconds or so.
https://github.com/pseeth/scaper/commit/2e3a9fe71fc4c40c7753a371db9fbcf91d5ecf74
This is based off of #55 which will be pulled in to master soon. Right after that, we can pull this branch into master to fix this issue, or pull it into #55 before merging #55  into master. But for now, you can just pull in the max change if you want to fix your own code.

OK friends, I've given this a deep dive and here's what I've found:

event_duration is forced to match source_duration when source_duration < event_duration, both for FG and BG events. This happens here: https://github.com/justinsalamon/scaper/blob/7fb77a92cf9fda15aae7defb5a3d826f87877b4e/scaper/core.py#L1303-L1313
This means that say sc.duration = 10, but the duration of your source file for the BG is 3, then the event_duration for the BG will be modified to 3.
The first place where this will cause a problem is in these lines where the event duration added to the annotation will be incorrect (assuming we self-concatenate): https://github.com/justinsalamon/scaper/blob/7fb77a92cf9fda15aae7defb5a3d826f87877b4e/scaper/core.py#L1532-L1535
If I'm not mistaken, concatenation is the first thing the sox combiner does. This means that the trim operation in these lines will take the concatenated background and trim it back to event_duration, which has been changed back to source_duration, leading to the observed bug: https://github.com/justinsalamon/scaper/blob/7fb77a92cf9fda15aae7defb5a3d826f87877b4e/scaper/core.py#L1670-L1673
For reference, these are the lines that do the concatenation (as well as all other combiner operations that follow): https://github.com/justinsalamon/scaper/blob/7fb77a92cf9fda15aae7defb5a3d826f87877b4e/scaper/core.py#L1682-L1685

I don't believe this issue was introduced by @pseeth, I think it was there all along and never got caught because none of our tests use background source files that are shorter than the specified soundscape duration, and that's on me! It's also another great example of why 100% coverage is not necessarily 100% coverage... :)
OK, now that the bug is isolated, it's time to get to a fix. First of all, we need to conceptually choose what should happen here, out of 2 options. If the background source file is shorter than the specified duration, we can:

self-concatenate it until it reaches the specified duration (as was originally intended though never properly implemented)
pad the background source file with silence to reach the soundscape duration.

Since there is no "correct" behavior here, it's up to us to determine what's the most useful behavior. If we wanted to be fancy, we could actually support both options with one being the default behavior and the other activated via a flag. I'm curious to hear @pseeth @turpaultn & @jtcramer 's opinion on what you'd consider the most convenient default behavior.
In terms of implementation, here's my 2c regarding each of the options:
IMPLEMENTING CONCATENATION

It seems to me like the correct way to handle this would be to modify the code in https://github.com/justinsalamon/scaper/blob/7fb77a92cf9fda15aae7defb5a3d826f87877b4e/scaper/core.py#L1303-L1313 such that the event_duration only gets changed for foreground events.
This means that for background events, the event duration is kept unchanged (=soundscape duration) even if the background source is shorter than the soundscape duration
This will result in the annotation having the correct duration for the BG (=soundscape duration)
This will also mean the trim operation will function correctly on the background

So, if I'm not mistaken (and I may be so we definitely need tests for this), this simplest/cleanest solution will be to add an IF statement in the lines linked to above such that they are skipped if is_background is True.
IMPLEMENTING SILENCE PADDING
This one's a little trickier. Ignoring the annotation for a moment - we could do as proposed above, i.e. not modify the event duration for background events. Then, in _generate_audio we'd have to replace the tiling behavior with a zero padding behavior, but the rest, I believe, would remain unchanged and should work correctly (i.e. trimming should work fine).
The complication arises because does I'm not sure it makes sense for the annotation to say the background event lasts the full soundscape duration when in reality it's padded with silence. So the alternative would be to NOT modify lines L1303-L1313 such that if the BG source file is shorter, it modifies the event duration. Then we'd still pad it with silence, and modify the trim operation for background events to ignore the event duration and instead always use the soundscape duration.
Then the even more complex scenario is if we want to support both.
SUPPORTING BOTH CONCAT AND PADDING
Perhaps the way to achieve this is through some IF statements in both _instantiate_event and _generate_audio. Basically:

IF bg-mode is CONCAT, then _instantiate_event will not modify event_duration (so it stays equal to the soundscape duration) and _generate_audio will apply concatenation via tiling.
IF bg-mode is PAD, then _instantiate_event will modify event_duration to match the source_duration, which will annotate the BG as being shorter than the soundscape, and in _generate_audio we instead apply padding AND trim to the soundscape duration.

Personally, unless there's strong evidence that there's need for supporting the PAD variant, my preference would be to only fix the code so that the CONCAT approach works correctly. My motivation is that:

There are a lot of moving parts here and it will be easier to make sure we get it right if we limit the behavior to just one option. It will also be faster to implement and cleaner to test.
Supporting both modes could lead to confusion among users, especially if each mode leads to a different BG duration being stored in the JAMS annotation.

Please chime in!

Super helpful breakdown! I'm okay with only implementing concatenation - that's what the docs say will happen so I think that's what we should keep doing. I think that if the system is concatenating, a warning should be thrown to the user telling them that.
I agree that adding the if statement is the cleanest way to do it. To make the test case, I'll need to add a short background audio file to the repo. I think I can take the one posted in #70, which was shorter than the duration.
To test it, this might require a new regression test, right? So that would be added in create_regression_data.py, I believe. The tests should be on two levels - the first is that the audio corresponding to a soundscape with a short background event added to it has a duration matching what we expect. Second, the audio should contain the background concatenated with itself a few times. I believe the 2nd condition should be tested via some additional regression data.

Thank you very much Justin, very well explained !! It's easier to speak about it like this.
I agree with @pseeth it would be better to do the concatenation since that's what is advertised for now, and nobody seemed to complain about it.
New scenario: choosing another file
Moreover, in a scenario when we do sound event detection, it could be interesting to:

be able to pick another file if the background is not long enough (to avoid including something non stationary in the background that could lead to false detection)

So our two interesting scenarios are:

bg-mode is CONCAT
bg-mode is DROP then we pick another file that will match the right duration (warning could be raised)

Silence cases (that I'm using just for examples)
Maybe someone could explain to me a scenario where there is padding for the background file since I do not see any.
I feel like if you mix something with silence, isn't your events become a foreground events with silence background ?
Because that's what I do in that case:

Silence background + foreground events
Remove the classes I did not want from my annotations when I gather them if I want them to be "background events".

Other scenario (opposite):

background event (I want it to last the full file) + foreground events
Get the annotations from background and foreground since I want to recognize both of them.

Sorry if I'm unclear.

Thanks for your input @pseeth and @turpaultn !
OK, looks like we're in agreement about only supporting the concatenate scenario. @turpaultn also proposed a "drop" scenario, which I think we can definitely consider but I suggest we leave that for a separate PR to keep things clean.
Now that we're in agreement on the intended behavior and the correct fix, @pseeth wanna take a stab at this since you already have a PR open?

I've implemented the fix discussed and added a test case. I wanted to document one funny bug I came across in implementing our fix here. So I added the fix that if isbackground: event_duration = self.duration. This resulted in an issue later on in _instantiate_event here:
https://github.com/justinsalamon/scaper/blob/b7aea91a467374945fabc21439dc1b4de374ae72/scaper/core.py#L1400-L1407
So the logic here is to find a satisfiable source_time. At line 1405, if the start time of the event plus the duration of the event is bigger than then source duration, then we "fix" the source time to be source duration - event duration. This works great because earlier we fix event duration to never exceed the duration of the source audio file. But when we make the event_duration fixed to self.duration if it's background, AND if the background is shorter than the duration of the soundscape, then we enter an infinite loop because source_time = source_duration - event_duration < 0! So the fix is simple:
source_time = max(0, source_duration - event_duration)

And everything works. PRing now but wanted to document.

good catch!

Closed this via #82.


Suppot tuple for axis argument in average

I fixed functions.average to support tuples for axis argument.

LGTM!


Vulnerabilities & Service Worker

Fixed 10 vulnerabilities
Added serviceWorker for PWA

Deleted serviceWorker and used Gatsby's Manifest and Offline plugins for PWA.
Slight change to favicon and added manifest logo sizes 192 and 512


Add Gymnasium Mellendorf to database

Pull requests adds the Gymnasium Mellendorf, a gymnasium School in Germany to the lib.

@JuniorWolfgamingDE First stage of verification passed, official domain is gymnasiummellendorf.de as far as I verified. This is just an informational note. Pull request is still in the review. I appreciate your patience while waiting for the final decision. Proof of domain ownership: https://gymnasiummellendorf.de/schulleben/podcast/

@philipto Its a bit complicated. Yes, the official domain is gymnasiummellendorf.de, but the e-mail addresses are on a seperate domain, gym-mellendorf.de which is the student server.

@JuniorWolfgamingDE  Thank you for the clarifications. Pull request merged.


chore(main): release prisma-model-types 0.1.14

:robot: I have created a release beep boop
0.1.14 (2023-06-02)
Bug Fixes

model-types: Remove validatorFor for now (4337f42)

This PR was generated with Release Please. See documentation.

:robot: Release is at https://github.com/BradenM/prisma-utils/releases/tag/prisma-model-types-v0.1.14 :sunflower:


Suggesting impovement/expansion of the CPU temperature script

Is your feature request related to a problem? Please describe.
I think the in the CPU temperature script here, we could also add an option for displaying the RAM/CPU utilization
Describe the solution you'd like
Adding another script which tells the cpu/ram usage or integrating it into the same script
Additional context
This will tell the user more about their system utilization, and can be really helpful for applications esp those over the cloud where whipping up the task manager is not an option

@avinashkranjan could you please look at this

Go Ahead @infernalsaber

@avinashkranjan sir can i do this task under gssoc'23


UI issues on various screens.

Add new is light blue please follow the design specified.

check the placement of the illustration.

check the shadow of the CTA the image seems distorted

content is incorrect. the user is selecting contacts from their phone to add to F&F. content and heading should reflect that

@ASN-BitHyve to review content of last image.

Light blue: fixed
Distorted image: fixed
Illustration Placement: fixed
Addressbook illustration: fixed
Addressbook contact content: fixed


Fixing squid:S00119 Type parameter names should comply with a naming convention

This pull request is focused on resolving occurrences of Sonar rule
squid:S00119 - “ Package names should comply with a naming convention”.
You can find more information about the issue here:
https://dev.eclipse.org/sonar/rules/show/squid:S00119
Please let me know if you have any questions.
Fevzi Ozgul

Hi,
I would like to know when you can possibly finalize this PR? Thanks.


Add --tree

Add an option that will print the tree of all items under the selected ones.

If run at the root, print git ls-files for all the repos.
If run with arguments, print the full paths to those items and their subitems.

If run at the root, print git ls-files for all the repos.

That's potentially a huge huge huge amount of output, none of which might be particularly useful.

I was thinking for plumbing wise - grepping through the entire tree to find something specific. A --tree utility seems to me to be a pretty neat way of adhering to the UNIX principle. Or, is that a pointless effort?


How to use TeamCity Reporter?

jasmine.getEnv().addReporter(new jasmine.TeamcityReporter());
just gives an error. How do I use teamcity reporter?
Thanks!

I was getting case sensitive problems. Try new jasmineReporters.TeamCityReporter()

@cscleison It depends on the version, in Jasmine 1.x its new jasmine.TeamcityReporter(),
in Jasmine 2.x its new jasmineReporters.TeamCityReporter().
See here for more details: https://github.com/larrymyers/jasmine-reporters

this worked for me.
onPrepare() {
var jasmineReporters = require('jasmine-reporters');
jasmine.getEnv().addReporter(new jasmineReporters.TeamCityReporter());
}


filtered_list : removed deprecated lifecycles and memoized dataSource

Summary

Removed componentWillReceiveProps and created componentDidUpdate.
Removed dataSource from state and memoized it so that dataSource is calculated only when term prop changes.
Device Information
This PR was tested on:  RedmiNote8, Android

Hello @a-c-sreedhar-reddy,
Thanks for your pull request! A Core Committer will review your pull request soon. For code contributions, you can learn more about the review process here.

@migbot implemented the suggested changes.

Building app in separate branch.

Successfully building:
https://circleci.com/gh/mattermost/mattermost-mobile/12473
https://circleci.com/gh/mattermost/mattermost-mobile/12472

Artifact links:
https://12473-70265724-gh.circle-artifacts.com/0/tmp/artifacts/Mattermost_Beta.apk
https://12472-70265724-gh.circle-artifacts.com/0/tmp/artifacts/Mattermost_Beta.ipa

@a-c-sreedhar-reddy Can you please resolve the conflicts?

@enahum resolved conflicts.

@a-c-sreedhar-reddy I think you messed up hehehhehe, 170 file changes??? How did you go about this?

Hmmm it seems that thw GH mobile app is showing things that it shouldn't let me re-check wobce I'm back at the computer


Quasi hyperbolic pf

implements #215
replaces https://github.com/econ-ark/HARK/pull/815

/binder

/binder

@Mv77 to look at this as CDC's RA

I did not get to this in my time as Chris's RA this winter and I don't anticipate working on it for now.

@llorracc @MridulS I'm wondering if there is somebody else who could review this.

@MridulS to fix conflict, then @mnwhite to review?


Encoding the position in the URI doesn't seem to work.

When opening gates vie the URI, it seems to always use the right hand sidebar.
I have included in the uri:

&position=center
&position="center"
&position='center'
And thus far, I have had no luck. Maybe its something I am doing wrong.
Or maybe I misunderstood the documentation

Sorry for late reply, can i confirm that the URI is not preconfigured?
Once again, to simplify the reuse of gates configured in the settings, the plugin automatically matches the title or URL with existing gates. If a match is found, the options from the gate configured in the settings are merged with the options specified in the note.

The issue is finnaly fix in 1.11.8


Simplify building excalidraw locally

Copying the excalidraw-latest directory from the release DMG to ExcalidrawZ/Resources/excalidraw-latest worked 👍
But how do you bootstrap the process?
I tried cloning https://github.com/excalidraw/excalidraw and running
$ npm install react react-dom @excalidraw/excalidraw

But using the resulting public/ folder from there is not enough. The README talks about fonts and turning the toolbar off. But the web view/server doesn't load at all (the loading indicator never finishes), so I haven't gone that far, yet.
What are the steps required to build excalidraw with node from scratch? Maybe I could create a build script for that.

Hello,
You can directly clone the repository at https://github.com/chocoford/excalidraw/tree/ExcalidrawZ-core. This repository is adapted for ExcalidrawZ.
However, since I just merged commits from excalidraw/main, it hasn’t been fully tested yet, so I cannot guarantee that the current build in the dist folder is functional. :(
For now, you can temporarily use the latest stable version I have built here.
excalidraw-latest.zip

The current approach is still based on manual builds, and there is no workflow in place to automate this step.


current develop 2nd August 2024 can't create new projects and also get session issues

I pulled down the latest develop yesterday and now this morning when I try to create any new projects the workspace flashes but no project is created and it doesn't matter what project template I choose. The error is:

1326 template_management.js
var options = "height=" + data[2].trim() + ", width=" + data[1].trim();
Also if I try to edit an existing project and then publish or play I get a session error:

Sorry Ron that I only see this now, but I fixed this later on Friday. It had to do with the check on path_traversal (one of the security fixes of the next release). It took some attempts to get it working properly on both XAMPP and Linux. apologies for any inconvenience

Hi Tom no problem but glad you resolved it. I’ll test tomorrow and close the issue after testing.
You’ve said security fixes for the next release so I’ll assume it’s not likely to happen with 3.12.13 but let me know if that’s not the case.
Cheers
Ron

No, it's only in develop.
On Tuesday, I'll send out the message to known admins about the issues Utrecht found. Using your text.
Cheers,
Tom
Ron Mitchell @.***> schreef op 4 augustus 2024 22:48:02 CEST:

Hi Tom no problem but glad you resolved it. I’ll test tomorrow and close the issue after testing.
You’ve said security fixes for the next release so I’ll assume it’s not likely to happen with 3.12.13 but let me know if that’s not the case.
Cheers
Ron
--
Reply to this email directly or view it on GitHub:
https://github.com/thexerteproject/xerteonlinetoolkits/issues/1298#issuecomment-2267663932
You are receiving this because you commented.
Message ID: @.***>
--
Tom Reijnders
DLearning B.V.

Utopialaan 49
Gebouw A
5232 CD 's-Hertogenbosch
Verstuurd vanaf mijn Android-apparaat met K-9 Mail.

@torinfo I pulled down the updated develop (seems like there were a lot of changed files!) and when I visited my usual install I got a blank window.
I set development to true and got Parse error: syntax error, unexpected '?' in H:\xampp\htdocs\develop\functions.php on line 374 and that line is:
$mesg = $message ?? "Path traversal detected!";
I'm guessing that is perhaps php compatibility? As you know I've kept my local xampp install to php 5.6 for testing that backwards compatibility but perhaps that not viable any more?
Anyway I changed it to php 7.2, again for testing backwards compatibility but for now I think we need to maintain this, and now I get an empty workspace, (and management too) and undefined index: toManagement in index.php on line 53.

I'll have a look at that later this afternoon. I am traveling to Barcelona now for a day trip.
Yes, lot's of changes because of potential security fixes identified by Snyk and Qodana.
Cheers,
Tom
Ron Mitchell @.***> schreef op 5 augustus 2024 10:23:20 CEST:

@torinfo I pulled down the updated develop (seems like there were a lot of changed files!) and when I visited my usual install I got a blank window.
I set development to true and got Parse error: syntax error, unexpected '?' in H:\xampp\htdocs\develop\functions.php on line 374 and that line is:
$mesg = $message ?? "Path traversal detected!";
I'm guessing that is perhaps php compatibility? As you know I've kept my local xampp install to php 5.6 for testing that backwards compatibility but perhaps that not viable any more?
Anyway I changed it to php 7.2, again for testing backwards compatibility but for now I think we need to maintain this, and now I get an empty workspace, (and management too) and undefined index: toManagement in index.php on line 53.
--
Reply to this email directly or view it on GitHub:
https://github.com/thexerteproject/xerteonlinetoolkits/issues/1298#issuecomment-2268465049
You are receiving this because you were mentioned.
Message ID: @.***>
--
Tom Reijnders
DLearning B.V.

Utopialaan 49
Gebouw A
5232 CD 's-Hertogenbosch
Verstuurd vanaf mijn Android-apparaat met K-9 Mail.

Hi Ron,
Does it work now?
Cheers,
Tom
Ron Mitchell @.***> schreef op 5 augustus 2024 10:23:20 CEST:

@torinfo I pulled down the updated develop (seems like there were a lot of changed files!) and when I visited my usual install I got a blank window.
I set development to true and got Parse error: syntax error, unexpected '?' in H:\xampp\htdocs\develop\functions.php on line 374 and that line is:
$mesg = $message ?? "Path traversal detected!";
I'm guessing that is perhaps php compatibility? As you know I've kept my local xampp install to php 5.6 for testing that backwards compatibility but perhaps that not viable any more?
Anyway I changed it to php 7.2, again for testing backwards compatibility but for now I think we need to maintain this, and now I get an empty workspace, (and management too) and undefined index: toManagement in index.php on line 53.
--
Reply to this email directly or view it on GitHub:
https://github.com/thexerteproject/xerteonlinetoolkits/issues/1298#issuecomment-2268465049
You are receiving this because you were mentioned.
Message ID: @.***>
--
Tom Reijnders
DLearning B.V.

Utopialaan 49
Gebouw A
5232 CD 's-Hertogenbosch
Verstuurd vanaf mijn Android-apparaat met K-9 Mail.

@torinfo well first it seems like there's a typo?
e.g. Parse error: syntax error, unexpected ';' in H:\xampp\htdocs\develop\functions.php on line 374
$mesg = ($message != null ? $message ;: "Path traversal detected!");
I removed that ; after message and then that error goes away and I committed that change.
This is with PHP 7.2 and I still got an empty workspace. :-( However then I remembered we've previously had an issue when development is set to true so I set that to false and all seems fine - at least in terms of these initial issues! Management also loads now too but I haven't tested anything else yet,
Wasn't there a fix for allowing development to be set to true when using xampp?
Also with development set to true I do also get some errors flash up then disappear about smtp e.g.
Warning: mail(): Failed to connect to mailserver at "localhost" port 25, verify your "SMTP" and "smtp_port" setting in php.ini or use ini_set() in website_code\php\error_library.php on line 213
But maybe that's because development is set to true and/or the change to php 7.2?

@torinfo @ronm123 fixed in 3.13? Can we close?

@FayCross Main issue is resolved (I plan to check $development = true before 21st)

Close for now


Readline package not used at all? And it is not available on Win platform

Try pip install readline, shown not availble to windows platform
Looking in indexes: https://pypi.tuna.tsinghua.edu.cn/simple, https://download.pytorch.org/whl/cu118
Collecting readline
  Downloading https://pypi.tuna.tsinghua.edu.cn/packages/f4/01/2cf081af8d880b44939a5f1b446551a7f8d59eae414277fd0c303757ff1b/readline-<IP_ADDRESS>.tar.gz (2.3 MB)
     ---------------------------------------- 2.3/2.3 MB 10.5 MB/s eta 0:00:00
  Preparing metadata (setup.py) ... error
  error: subprocess-exited-with-error

  × python setup.py egg_info did not run successfully.
  │ exit code: 1
  ╰─> [1 lines of output]
      error: this module is not meant to work on Windows
      [end of output]

Readline is imported here, but it does not seems to be used anywhere, and memgpt runs fine when commenting this line out!
https://github.com/cpacker/MemGPT/blob/134df8f7ea68d4dd07a9f9d6cdac6b0c46c12ff3/main.py#L7

Sorry about this. This was done to support longer inputs on the MemGPT console. The right thing to do is probably to install pyreadline3 and then
from pyreadline3 import Readline
readline = Readline()

Will patch shortly

Ah, could you try adding import readline back and then running
pip install pyreadline3
and see if that works?

Ah, could you try adding import readline back and then running pip install pyreadline3
and see if that works?

@vivi Thanks! I think it works the way you suggested!


Consistent casing for "Recovery Services vault"

@markgalioto - Please review the proposed changes.  Thanks

@andresnava , Thank you for fixing these inconsistencies. Because it took me so long to get to this PR, there are merge conflicts with this file. I added your updates via pull request 34356. And this PR has been merged and will publish in the morning of 3/2.

#please-close,
Close this PR as the fix was applied using a different pull request.


[IT-3808] Update dependencies for dependabot findings

Update dependencies for dependabot findings

Pull Request Test Coverage Report for Build<PHONE_NUMBER>6
Details

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 90.769%

Totals

Change from base Build<PHONE_NUMBER>1:
0.0%

Covered Lines:
59

Relevant Lines:
65

💛  - Coveralls


Implement initial e2e integration tests for datadog-checks-downloader

What does this PR do?
Implement end-to-end tests. The pull request adds a simple end-to-end testing for datadog-checks-downloader. This PR does not include actual metadata and wheel files used during the testsuite run.
It is possible to specify fixed timestamps and thus there is no need to regenerate keys once they expire.
The testsuite is divided into two parts - online and offline tests:

Offline tests use tuf+in-toto metadata and the actual wheel files that should be stored in the data/ of the e2e_tests directory. These data do not require any Internet connection and could be executed offline.
Online tests are executed against the default repository_url as configured in the datadog-checks-downloader CLI. When triggering the tests, users can additionally specify which distribution and distribution version should be tested (by default, use datadog-active-directory==1.10.0) from the CLI. This enables to test e2e data which are stored in the configured repository_url.

TODO:

[x] TODO: this PR adds initial tests and a "framework" to create more tests using an HTTP server or online tests, the testsuite could be extended with additional test cases
[x] TODO: this PR does not include actual tuf/in-toto metadata and wheel files to be tested - we can use the generated ones (CC Andrew) - all files provided
[x] TODO: document how to run the testsuite

Related: https://github.com/DataDog/integrations-core-vault-ceremony/pull/46
Review checklist (to be filled by reviewers)

[ ] Feature or bugfix MUST have appropriate tests (unit, integration, e2e)
[ ] PR title must be written as a CHANGELOG entry (see why)
[ ] Files changes must correspond to the primary purpose of the PR as described in the title (small unrelated changes should have their own PR)
[ ] PR must have changelog/ and integration/ labels attached

@fridex title contains "[WIP]" but PR is not in "draft" state, is this PR ready for review?

@fridex title contains "[WIP]" but PR is not in "draft" state, is this PR ready for review?

Adjusted, now no longer WIP. :+1: Just wanted to have this more defensive change.

Ah, sorry. I thought this is another PR -- this one is still WIP.

Python3.8 tests are green.
Python 2.7 tests report the following error on my machine:

ImportError('../.tox/py27/lib64/python2.7/site-packages/cryptography/hazmat/bindings/_openssl.so: undefined symbol: ERR_GET_FUNC,)

It looks like there are issues with FIPS symbols in OpenSSL in containerised environments I tried to run tests for Python 2 (fedora:36 and ubuntu:22.04. Is there a containerised environment I could use for Python 2 tests?

Rebased and squashed. Ready for a review (tests might take some time to finish but they were already reported as green in the previous run).

Any suggestions?

It looks like the environment is not properly set up - hence issues with tenacity and with pytest. The README states procedure to install dependencies:
pip install -e '.[deps,dev]'
It should bring all the necessary libraries to the environment. Let me know if that works.

It looks like tests timeout in azure pipelines. The test that is checking all the integrations takes too much time to finish - should be fixed in 02181dc398479d69b562864331bf7b20d5e39a91

For the failing Windows CI, it's likely due to some generated filenames (like the .link files) being too long. Apparently this has happened before, although the solution was to change the filenames to something shorter: https://github.com/DataDog/integrations-core/pull/1712
@trishankatdatadog do you know if we can safely rename the .link file names (and also change all of the metadata that refer to them) or would this affect the verification?

Adjusted based on @sarah-witt review comments. Commits can be squashed before merge.

Merging based on approvals. Feel free to reach out if there are any issues with the testsuite.


Add trait FromStrHex for tuple structs with single u32 member

Closes: #1112

Adds new trait FromStrHex with 2 methods: from_hex_str and from_hex_str_no_prefix
Impl new trait on each tuple struct with single u32 member. eg Time(u32)

As stated in the issue, grep through codebase with \(u32\) and \(pub u32\) to see all implementations and verify none were missed
Tests are somewhat redundant, but cover 4 cases each. 2 happy paths, 1 for each function. 1 case for malformed/invalid hex input, and 1 for calling no_prefix without a prefix

As a high level observation, this adds a new module to util/ which we're trying to clear out. But I"m no sure where a better location for it might be.
Eventually we will move it to the bitcoin-str crate.

Yea, I wasn't exactly sure where to stick it so I picked the most obvious. Would it make sense for it to be in bitcoin/src/parse.rs for now?
looks like its failing the no-std tests, fixing those up now

Force push: rebase to resolve conflicts and squash

@Kixunil Latest commit will show the lint warnings I was talking about. The error is only ever used in the trait implementation and not in any other implementation and throws an error because of the lint level.
The error from my end

Looks like the MissingPrefix error is because the module isn't public in lib.rs. It looks like this is intended (no module documentation, and mostly all internal helpers). Could this module be made public to let the compiler know that its ok?

Oh, yes, we need both the error type and the trait public. I'm not sure about publishing it under parse. It's not a bad name but maybe there's better? @apoelstra @tcharding any ideas?

I did consider str but I'm a bit concerned some tools could confuse it for the type.

Yeah, that's reasonable. We could call it bitcoin_str I guess. I'm not super attached to any particular name.

Moved to a new file. Added license header and some basic documentation. Documentation is not my strong suit so suggestions are appreciated as I'm sure y'all would have more insight into what this module will be like in the future

bitcoin::bitcoin_str sounds weird. I'd rather use parse if we don't have anything better.

I don't like parse because it sounds too general (may cover consensus encodings etc) and too specific (is only about parsing, not serialization, not conversion between formats, etc). I want to emphasize that these are human-readable encodings.
bitcoin::bitcoin_str does sound weird but "we wanted to avoid conflicts with std's two uses of str" is a pretty good reason for weirdness.

FromHexStr is only about parsing not serialization, so the name makes sense. :)
I'd personally rather take the risk and call it str than bitcoin_str if parse is not acceptable.

FromHexStr is only about parsing not serialization, so the name makes sense. :)

True, but the module we're proposing will eventually become the bitcoin-str crate, and contain more things!

I'd personally rather take the risk and call it str than bitcoin_str if parse is not acceptable.

Ok. I don't have a strong opinion either way. We could alse use string since lowercase string is not used anywhere else, or human_enc or something.

+1 for string.rs for the module name.

the PR should generally not include patches that change code written in previous patches

This is confusing me. My general workflow is to commit and push changes through the PR, each commit after a review is me implementing those suggested changes. Then afterwards, I'll rebase to squash it down. Am I supposed to be doing this another way?

Then afterwards, I'll rebase to squash it down.

No worries, if that's your workflow I can work around that.

No worries, if that's your workflow I can work around that.

Let me rephrase that because I'd rather make it easier for you guys and learn something new. I didn't understand that comment because of the workflow I use.

Said in another way, the PR should generally not include patches that change code written in previous patches

What exactly does this mean? How am I supposed to change the code I'm submitting with a PR if I'm not supposed to change it within the PR?

Thanks for re-asking, I'll try to explain a bit more clearly. Sorry if I say too much :)
Each patch [0] should make a single change to the codebase. A PR may be multiple patches. If during review a suggestion is made and you wish to implement the change you should rebase and make the change to the original patch that introduced the change. Then you can force push to update the PR. Sometimes review suggests some change that can be done as a separate patch on top but its not super common in my experience, often if this happens a second PR is better.
The benefit of this approach is that any reviewer that comes along can pull the patch set down to their local machine and go through each patch one by one and review them.
Please ask again if I've not explained it perfectly, I'm more than happy spending the time, its time well invested :)
[0] patch and commit are synonyms

In case you are wondering how reviewers review the force pushes, one can pull the latest version then use for example git range-diff c05188a...@ to see what has changed. If one uses the commit hash of the previously reviewed version then you can see what has changed with the force push.

If one uses the commit hash of the previously reviewed version then you can see what has changed with the force push.

That was exactly what confused me and this cleared it up. I'll be sure to do it this way from here on out. Thanks for the help!

This still needs squashing into a single commit bro. And just because its related, we don't want two commits to ever be merged with exactly the same commit logs. Since we are discussing git foo here is a blog post that explains how to write git commit messages, doing so makes reviewing better because

it forces the dev to understand exactly what they are doing
it makes it easy for reviewers to see if the dev understands exactly what they are doing (especially when implementing review suggestions)
it catches mistakes when the dev meant to do one thing but did something else
it makes it easier for the reviewer to get context on the proposed change in the PR

https://cbea.ms/git-commit/

This still needs squashing into a single commit bro

Sorry, thought I got all of them and looks like I didn't.

we don't want two commits to ever be merged with exactly the same commit logs

So when I go to rebase and It has all the squashed commits messages, I should keep them for the description part of the commit? and leave the general message (the first line) as something like what I have currently?

 Squash entire PR down to 1 commit" instead of description of the actual code change. :(
I really like the explanation that git commits should tell a story of how the software was developed. Things like "typo fixes" are not interesting (unless those typos were already in master) but things like "Refactor X to prepare Y" deserve their own commit. In your case a single commit makes most sense. However it should tell about the whole change you did, not just the last squash. (The title is still good though.)

 Squash entire PR down to 1 commit" instead of description of the actual code change. :(

I know, there wasn't anything to compare and there wasn't a change. This was to resolve the issue of my mistake previously. Where I missed a commit while rebasing. This won't happen again btw now that I'm aware of the process

So when I go to rebase and It has all the squashed commits messages, I should keep them for the description part of the commit? and leave the general message (the first line) as something like what I have currently?

This still hasn't been answered

So when I go to rebase and It has all the squashed commits messages, I should keep them for the description part of the commit? and leave the general message (the first line) as something like what I have currently?

Usually only one commit will have the "real" commit message, so you can delete everything but that. In other cases, none of them are an accurate message for the combined commit, so you need to rewrite it from scratch.

This won't happen again btw now that I'm aware of the process

No stress bro, we are all learning no matter how much we know. If I had a dollar for every mistake I made I'd be fiat rich right now :) Everyone here is more than happy to help you out, then your next contribution will be even more valuable.

Well done @connormullett, this PR is hot now!
If you want to learn about macros, a future improvement could be macro-izing the implementations of FromHexStr (for ones that use similar logic). One can loose a lot of time playing with macros but the more you do it the faster you get and they are super useful.

In a23d1ed8fecc27862a1454771e945414c284cb9d:
I'd prefer we call the module string. We'll name the eventual crate bitcoin-string but it'll be exported from rust-bitcoin just as string. (Similar tto what we do with hashes now.)

In a23d1ed:
I'd prefer we call the module string. We'll name the eventual crate bitcoin-string but it'll be exported from rust-bitcoin just as string. (Similar tto what we do with hashes now.)

Oh, I thought the suggestion was to replace str with string. My mistake I'll fix it

Rebase to resolve merge conflicts

I personally perform squashing by combination of git reset --soft HEAD~N and git commit --amend where N is the number of commits I want to suash (if PR has three commits N is 2). Much easier. :)

Little known tip, you can use @ instead of HEAD

I personally perform squashing by combination of git reset --soft HEAD~N and git commit --amend where N is the number of commits I want to suash (if PR has three commits N is 2). Much easier. :)

Ah so instead of squashing into one commit that already existed, you're creating a new commit based on the squash of the commits. This is exactly what I was looking for, thanks so much and sorry about the git confusion. Never worked on a project with this style and makes a lot of sense to why you guys use it. Thanks

@connormullett , this PR is not breaking the CI. It is already broken :( . There is a hotfix #1432 that should fix it.

@connormullett , this PR is not breaking the CI. It is already broken :( . There is a hotfix #1432 that should fix it.

Thanks for the headsup, thought I messed up while catching up to master

force push: rebase + remove NonStandardSighashType's implementation of FromHexStr

Is CI still broken @tcharding? Looks like some other pull requests are failing as well

Force push: remove forgotten debug statement

Thanks for sticking with this, I know we are a picky bunch :)

Don't worry about it, gives me something to do in my free time haha. This PR's been a rough ride but it looks to be nearing done

Solid! Thanks.

Looks good to me! I think it's a little silly to be defensive against the case that sizeof(u32) is not 4 but that's fine.

Ah, I see!


Fix

How to translate it properly?
The function will be applied only if the preset is configured to remove OneDrive. Otherwise the backup functionality for the \"Desktop\" and \"Pictures\" folders in OneDrive breaks


Trailing slash in baseURL

AFHTTPSessionManager and AFHTTPRequestOperationManager both add a trailing slash to the baseURL provided during initialisation:
// Ensure terminal slash for baseURL path, so that NSURL +URLWithString:relativeToURL: works as expected
if ([[url path] length] > 0 && ![[url absoluteString] hasSuffix:@"/"]) {
    url = [url URLByAppendingPathComponent:@""];
}

self.baseURL = url;

This turned out to cause a problem when using a REST API service which does not accept URI with a trailing slash when empty URLString is used for the request.
For instance, when doing a POST request with an empty (nil) URLString by calling -POST:parameters:success:failure: method, the resulting URL will contain a trailing slash, thus causing an error in my case.
Example:
https://example.com/authenticate - OK
https://example.com/authenticate/ - Error
The workaround would be to split the URL and use “http://example.com/” as a baseURL and “authenticate” as an URLString, but, unfortunately, this is not possible in my case as I obtain the baseURL by using another REST API and it contains already a full URL which has to be used for a POST request…
Wouldn’t it be more appropriate, to add a trailing slash only when it’s indeed needed? (i.e. just before where the URLString is concatenated with a baseURL?)
Best regards,
miximka

@mattt I was using baseurl passing relative urls, and the server complained 404 because it could not find something that didn't take a slash. Even without setting baseurl I still get a trailing slash added, and 404 from that.


Complete refactoring

Addressing the issue #1
Have done the following

Complete porting to markdown.
Jekyll themeing
Github actions config file

How to host

Change the github pages settings to /docs from /root/

Once merging is done you can close the issue #1


How to make Identity helper classes use existing DbConnection?

From @gdoron on April 19, 2016 9:48
Hi,
I noticed through my logs, Identity helper classes (e.g. UserManager) open a new connection for each method.
This can be 10 new connections in a single API request.
Also, it causes changes made locally in the DbContext not "seen-able" in the other connection.
Is it possible to config Identity helper classes use existing DbConnection?
If it's not, can we please add this very needed functionality?
Thanks,
Doron
Copied from original issue: aspnet/Identity#802

From @gdoron on April 21, 2016 22:31
Thanks for the answer @divega,

but by default it is true that it will open and close it as needed, even within the same request. In order to override this you can open the connection explicit in the beginning of the request, e.g. you could do this in the controller's constructor.

I hope you classify it as a bug...
A. I can't open the connection asyncly in constructors.
B. I don't want to open a connection in each and every request, some of my actions are cache-able, meaning there will be absolutely 0 requests to the DB.
C. It's a bit awkward.
What is the reason it was designed this way?

Also, it causes changes made locally in the DbContext not "seen-able" in the other connection.

-I am not sure what you mean by this.

I meant that if there're changes still not flushed to the DB in the connection used by DbContext, the new connection used by UserManager wouldn't not see them.
Am I right?

Identity methods should be using the same instance of a DbContext (an ApplicationDbContext in an application based on the default templates) within a request. For this to work, the DbContext in question has to be registered as a scoped service, e.g. using the AddDbContext<TContext>() method.
Each DbContext will only use one instance of DbConnection but by default it is true that it will open and close it as needed, even within the same request. In order to override this you can open the connection explicit in the beginning of the request, e.g. you could do this in the controller's constructor:
    // assuming applicationDbContext is a constructor parameter and resolved by DI
    applicationDbContext.Database.OpenConnection();

Then the connection should remain open until you close it explicitly or the scoped context is disposed.

Also, it causes changes made locally in the DbContext not "seen-able" in the other connection.

I am not sure what you mean by this.

Just clarifying B.
Some of the actions are MVC GET requests that only returns HTML, no DB is involved.
And even for WebApi requests, some of the actions don't need DB connection, like when the data is cached.

@gdoron I understand that opening and closing the connection on demand and automatically may sound strange to you but it is by design and has been the default behavior of EF in all previous versions, for various reasons.
Closing and reopening the connection between operations automatically may not always be the most efficient behavior but it is likely the best we can do automatically: While every time this happens there is some overhead, it maybe much less expensive than you think because of connection pooling. Precisely, this behavior helps the connection pool do its job more efficiently: if we kept the connection open for longer periods (e.g. after a database operation has finished and while doing some other lengthy operation) then potentially other incoming requests that needed to execute database operations could exhaust the connection pool.
Also, in general the longer we maintain a connection open, the higher the probability that the connectivity with the server will break, e.g. Azure SQL DB could throttle the connection or just transient instability in the communication could break it.
As I mentioned earlier if you know exactly when you want to open the connection then you can choose to do so (having this code in the constructor was just an example). In that case EF will not close the connection and the connection will remain open until you close it or until the DbContext is disposed.
In EF Core you can also pass an existing DbConnection, e.g. you can override the OnConfiguring() method on a DbContext and pass the connection to an overload of UseSqlServer() (or the corresponding method for other relational providers).

Just clarifying B. Some of the actions are MVC GET requests that only returns HTML, no DB is involved

Yes, I understood this. This is a scenario in which I believe the default "on demand" behavior is preferable.

I meant that if there're changes still not flushed to the DB in the connection used by DbContext, the new connection used by UserManager wouldn't not see them. Am I right?

I think you are not right but feel free to write some test code to prove me wrong :smile:
For starters, changes get "flushed" to the database through the connection on a call to SaveChangesAsync(). Before that there may be changes tracked by the DbContext that haven't been saved but there is no such thing as pending changes in a connection.
Incidentally the DbContext used by the UserManager is by default registered as a scoped service, meaning that if you resolve it in your controller, you will get the exact same instance that UserManager is using in the same request, so you do have visibility into any pending changes if there is such thing. That said, AFAIR in ASP.NET Core Identity we call SaveChangesAsyn() often after each individual operation (@haok can confirm) so I am not sure you will have many chances to observe pending changes.

Yeah basically every 'write' operation in the user manager calls SaveChanges at the end as part of the Update to the user.  So if there are any unsaved changes before you call many of the UserManager apis, they will be saved as part of the identity operation anyways.

@divega that makes sense.
I didn't know EF and Identity call SaveChanges implicitly.
Is it just with Identity that connections close and open frequently or is it true even for EF itself?
Because if not, and the DbContext is Scoped and there are async operations in the requests that can keep connections opened for a long time too.
Thanks.

@divega anything left to do on this one?

@gdoron Opening and closing the connection as needed is EF behavior. Identity has little to do with it.
I am going to close this because I believe we have answered your questions. Feel free to create a new issue if you run into problems.


Split the schema package into subpackages. [phab:D1055]

Created by fromberger at 2016-09-15 22:26:03:
The top-level package now carries helper functions for building nodes
and edges. The constants have been moved to subpackages:
facts  -- constants for fact labels
nodes  -- constants for node kinds and subkinds
edges  -- constants for edge kinds, and helper functions
The tests were also updated and extended.
Update all uses of the schema package.
For the most part this is a straight renaming, with a few exceptions in
places where I fixed up collisions with the new package names.

fromberger wrote at 2016-09-16 01:58:24:
As a reference for whomever reviews this: Start in kythe/go/util/schema, that's where the primary changes described in the commit log live.
Everything else is fixup falling out of that.

shahms accepted this revision at 2016-09-16 17:57:23

fromberger closed via commit ec02cd769af6116fbcc2985e1b07e33bdeb1d745 at 2016-09-16 17:58:23


How to get a print-command output?

Hello.
I would like to use "print" in my program to track some variables, but in terminal I only get error messages(no standard output). This is possible in the official app. Is it possible in your? I use standard type of uploading.
Also it will be great to add download/upload file feature.
Thanks.

Hey @Neko1993 , are you overriding the default print as readme says? Basically no matter if you are using simple or advance you need to have the following if you want the print to output in the VS Code console:
from util.print_override import spikeprint
print = spikeprint

Wow, thanks a lot! I did not notice.
Do you know, is there a command to terminate the execution of the program?

Yes, just do a an F1 in VSCode and search for lego hub. There should be a Terminate Running Program command :)

Yes, but how I can do it programmatically?
After all lines have been executed, the program does not terminate on hub. Usually I put a non-existent command so that the program would exit by mistake

Ah, I'm not sure about terminating it programatically. Never needed to do this. But considering that even in the official MINDSTORMS app you need to push a button to terminate the app, I doubt it is possible.

Thank you? for answers and extension!)

Ah, I'm not sure about terminating it programatically. Never needed to do this. But considering that even in the official MINDSTORMS app you need to push a button to terminate the app, I doubt it is possible.

Most of the Spike community has been using raise SystemExit to force the program to exit

Is it possible to add a setting to print() to vscode output without
from util.print_override import spikeprint as print

I have tested it out by adding a line to print whatever is not JSON parsable to: https://github.com/PeterStaev/lego-spikeprime-mindstorms-vscode/blob/cf79c7851e0fb7e0af8dd437dbf63e9d117a891c/src/rpc.ts#L66
And it seems working. Just want to know whether you are willing to make such change? Maybe via a setting?


[SPARK-45829][DOCS] Update the default value for spark.executor.logs.rolling.maxSize

What changes were proposed in this pull request?
The PR updates the default value of 'spark.executor.logs.rolling.maxSize' in configuration.html on the website
Why are the changes needed?
The default value of 'spark.executor.logs.rolling.maxSize' is 1024 * 1024, but the website is wrong.
Does this PR introduce any user-facing change?
No
How was this patch tested?
It doesn't need to.
Was this patch authored or co-authored using generative AI tooling?
No

Thanks. Merged to master 3.5 3.4 3.3

Thanks. Merged to master 3.5 3.4 3.3

Thank you so much for your review


Is this project dead?

Hi there,
Is this project dead? Asking this becasue there are two pull requests which were not been accepted and also the project seems doesn't get any new updates but a list of unresolved issues.
Just asking to understand which might be our position, ppl which have used it, to drop it or to support you to continuously improve the initial release.
Regards.

Hey mate,
It isn't dead fully but yeah we realised the project is not adding as much value as what we thought it would. Regarding the Pull requests, we realised the PRs did not have a value-add. That is why we did not accept them.
If you are keen to contribute though, please feel free to contact myself or @lalithr95

@abhijeth could you elaborate more please, why it is not so valuable based on your experience?

https://github.com/Fuzzapi/fuzzapi/pull/54 is made by a bot which updates gem version, PR itself is outdated we are not looking to merge that. https://github.com/Fuzzapi/fuzzapi/pull/75 doesn't implement PATCH method in gem or in the app, it just adds new HTML input for the form which doesn't add any additional use to the app. If you are interested to take that issue, we would be happy to assist you and review your changes.


feat: move to eslint-plugin-n

eslint-plugin-n is a community maintained fork of eslint-plugin-node: https://github.com/eslint-community/eslint-plugin-n
It ensures that an important module like eslint-plugin-node is kept up to date, with both ESLint 8.x and with Node.js itself.
Full disclosure: I'm part of the ESLint Community Core Team.
Description

it's ready for review now. 🎉

Closing this, superseded by #444


Add Laravel Auth Checker

Sorry, not enough stars (117 and not 400) but there's no other alternative here. I think this package needs more visibility :)
https://github.com/404labfr/laravel-auth-checker

sorry, gotta stick to the 400 star rule


[SPARK-42846][SQL] Integrate _LEGACY_ERROR_TEMP_2011 into UNEXPECTED_DATA_TYPE

What changes were proposed in this pull request?
This PR proposes to replace  _LEGACY_ERROR_TEMP_2011 with UNEXPECTED_DATA_TYPE, as part of the parent initiative of SPARK-37935
Why are the changes needed?
To rename the legacy error class as part of the refactoring effort, and simplify Spark's error handling aspect.
Does this PR introduce any user-facing change?
No
How was this patch tested?
Unit tests
Was this patch authored or co-authored using generative AI tooling?
No
I have tried to test QueryExecutionErrors.typeUnsupportedError also. Still, by understanding the SQL module code base better, seem there is no way to do that, as all inferred types generated by inferPartitionColumnValue( ) are already covered by castPartValueToDesiredType( ).
Also, I have tried the approach of custom type, but by doing so castPartValueToDesiredType( ) will be skipped.

@MaxGekk Hi, would you mind having a look at this?
Thanks.


Http 30X   corrupted redirection response from ISP

Describe the bug
i am developing your greentunnel with using Kotlin maybe you know this.  But I think we both have a problem about 30X redirection in Turkey ISP.  Turkey ISP send corrupted redirection response for blocked sites for only HTTP (not HTTPS) request.
➜  ~ curl --proxy <IP_ADDRESS>:8080  -vvvvv http://wikileaks.org
*   Trying <IP_ADDRESS>...
* TCP_NODELAY set
* Connected to <IP_ADDRESS> (<IP_ADDRESS>) port 8080 (#0)
> GET http://wikileaks.org/ HTTP/1.1
> Host: www.wikileaks.org
> User-Agent: curl/7.64.1
> Accept: */*
> Proxy-Connection: Keep-Alive
>
< HTTP/1.1 302
< Connection: close
< Server: nginx
< Location: http://<IP_ADDRESS>/
<

* Closing connection 0

<IP_ADDRESS> is IP address of Censorship page
but it must be like:
➜  ~ curl  -vvvvv http://www.alikemal.org
*   Trying <IP_ADDRESS>...
* TCP_NODELAY set
* Connected to www.alikemal.org (<IP_ADDRESS>) port 80 (#0)
> GET / HTTP/1.1
> Host: www.alikemal.org
> User-Agent: curl/7.64.1
> Accept: */*
>
< HTTP/1.1 301 Moved Permanently
< Cache-Control: public, max-age=0, must-revalidate
< Content-Length: 41
< Content-Type: text/plain
< Date: Sun, 10 Jan 2021 19:27:23 GMT
< Age: 0
< Connection: keep-alive
< Server: Netlify
< Location: https://www.alikemal.org/
<
Redirecting to https://www.alikemal.org/
* Closing connection 0

Firstly I think to modify this response but still, ISP is learning the site you want to connect to.
maybe wen can think forcing HTTP to HTTPS with sending dummy redirect response to browser
Have you any solution for this problem @SadeghHayeri  ?

i dont know, but i will test with using https-everywhereplugin at this week

i dont know, but i will test with using https-everywhereplugin at this week

@SadeghHayeri, I tested HTTPS-everywhere plugin for 2 weeks. I didn't see any website that they still don't support HTTPS. You can add force to HTTPS`option for this problem.


Error while handling push webhook

1|autodepl | TypeError: this is not a typed array.
1|autodepl |     at Function.from (native)
1|autodepl |     at verify (/var/www/autodeploy/node_modules/github-webhook-handler/github-webhook-handler.js:40:28)
1|autodepl |     at BufferList._callback (/var/www/autodeploy/node_modules/github-webhook-handler/github-webhook-handler.js:80:12)
1|autodepl |     at BufferList.end (/var/www/autodeploy/node_modules/github-webhook-handler/node_modules/bl/bl.js:98:10)
1|autodepl |     at IncomingMessage.onend (_stream_readable.js:498:10)
1|autodepl |     at IncomingMessage.g (events.js:260:16)
1|autodepl |     at emitNone (events.js:67:13)
1|autodepl |     at IncomingMessage.emit (events.js:166:7)
1|autodepl |     at endReadableNT (_stream_readable.js:913:12)
1|autodepl |     at nextTickCallbackWith2Args (node.js:442:9)

Can't understand why this error is occuring. I'm using Node 4.4.2

Hey @udiboy1209, unfortunately you're using a version of Node.js that's a little bit too old. We're currently up to v4.8.7 on the v4 series and Buffer.from() was introduced later than the one you're on which is why we're seeing a problem here. Can you upgrade your Node.js version? You should at least be on v4.8.7 for security reasons. Ideally you should pick a v8.x release. If you're on Linux and need a source for Node.js go to https://github.com/nodesource/distributions for instructions on how to get a properly updated one.


vcxproj parsing error

Hi,
I have multiple nodes of the same type within a <ClCompile> node.  Clang Power-Tools compile throws "Did not expect that". I attached a sample.
cpt-test.zip

Hello,
Thank you for the sample project.
We have isolated this issue and a fix has been pushed for it.
An updated Clang Power Tools release will be coming later today.
Regards,
Gabriel

Works now ...
Thank you!

This issue was fixed in version 2.4 released today.
Thanks for you feedback 👍


Full Color Section Heading (Solved)

UPDATE: Making this change in awesome-cv.cls to line 215, and making the second change on line 153 solved it.
\newcommand*{\sectionstyle}[1]{{\fontsize{16pt}{1em}\bodyfont\bfseries%       \color{**awesome-skyblue**}\@sectioncolor #1}}
% Awesome section color \def\@sectioncolor**{}**{%   \ifbool{acvSectionColorHighlight}{{\color{awesome}**{}}}{}**% }

Hmmm... I don't know what do you ask exactly, sorry. If you want to disable section color highlighting, on your resume.tex, just set this \setbool{acvSectionColorHighlight}{false}
If it is not the answer you want, please write in more detail.

Rather than have only three letters be awesome colors, I'd like to have the entire section heading awesome color. Below is what I believe to be the relevant code.
% Awesome section color
\def@sectioncolor{}{%
\ifbool{acvSectionColorHighlight}{{\color{awesome}{}}}{}%
}

You can change the color on \sectionstyle in 224 line number.

Can you re-open this ticket? I want to know how to enable color for entire section (not just first three characters of Section Header Name)
Thanks!

The original post on this issue was updated with how I managed to get it done to be more than the first 3 letters of a section heading, and an image of what it looks like.

Would love to see this being configurable, as in 0-n number of characters to be coloured, with the option to colour all characters.

Hi @dcsim,
Your fix does not work because you use an old version of LaTeX. I figured it out though.
The line to change as of November 16th, 2016 to get this working is to modify awesome-cv.cls, Line 155 and 156 for the following:
% Awesome section color
\def@sectioncolor{\color{awesome}}
This will make the section colour entirely "awesome" (the variable, and quite literally), based on your setting in resume.tex
Thanks,
Shah

How to change the heading to a custom color ?

@yashladd there is a line to change in main tex file similar to this :
\definecolor{awesome}{HTML}{CA63A8}


fix: Release CR is failing due to short timeout of 2 minutes, bumped …

…to 5 mins.
Description
Found that the rhtap-test  failed many times when  validating Release CR to turn to succeeded, the failure was because the release pipelinerun took more than the defined timeout threshold which is 2 minutes ,
based on this we fixed with setting the timeout threshold to 5 minutes.
RHTAPBUGS-511
Type of change

[ ] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[ ] This change requires a documentation update

How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration
Checklist:

[ ] I have performed a self-review of my code
[ ] I have commented my code, particularly in hard-to-understand areas
[ ] I have made corresponding changes to the documentation
[ ] I have added meaningful description with JIRA/GitHub issue key(if applicable), for example HASSuiteDescribe("STONE-123456789 devfile source")
[ ] I have updated labels (if needed)

/test redhat-appstudio-e2e

/test redhat-appstudio-e2e

/lgtm
/approve

/pj-rehearse ack

/retest

/retest

/retest

/retest

/lgtm


[bug] Auto Crit doesn't crit

Describe the bug
Auto crit does not crit properly.
To Reproduce
Steps to reproduce the behavior:

Enable auto crit
attack something
notice no crits.

Expected behavior
A critical hit should occur.
Screenshots
If applicable, add screenshots to help explain your problem.
Desktop (please complete the following information):

OS: MacOS
Version 12.4

Additional context
Add any other context about the problem here.

Not going to fix this for now.


[Bug]: DSPA service endpoint is not secure

Is there an existing issue for this?

[X] I have searched the existing issues

Deploy type
ODH Dashboard UI
Version
RHODS 2.4
Environment
OCP 4.12
Current Behavior
When deploying a DSPA, port 8888 is open and accessible via the service to all other resources on the cluster without authentication.
Currently, port 8443 is secured by an oauth-proxy and forwards traffic to localhost:8888, but since port 8888 is exposed, the oauth-proxy can be bi-passed by any other resource that has access to communicate with the service.
Since port 8888 is exposed, another nefarious resource running on the cluster can ex-filtrate data from any DSPA on the cluster including data and artifacts.
Expected Behavior
Port 8888 and 8887 should not be exposed on the service and the only ports on the pod that should be accessible should be port 8443 which is secured with the oauth proxy.
Steps To Reproduce

Deploy a DSPA
Connect to the DSPA via ds-pipeline-pipelines-definition.my-project.svc:8888 from another pod running in any namespace on the cluster without a bearer token

Workaround (if any)
No response
Anything else
No response

bump @strangiato ^

Migrated to Jira: https://issues.redhat.com/browse/RHOAIENG-1705


[UNR-3617] Delay actor hierarchy migration by one frame.

Description
Actor hierarchy migration happened synchronously through recursive call from USpatialActorChannel::ReplicateActor. While simple, this bypassed the regular replication loop in the net driver.
This caused some pre-replication events to be skipped, namely one which copied actor location to replicated movement data. Symptoms were being pulled back to the actor's origin position after teleport for instance.
This change marks actors for migration instead, in order for them to go through a regular replication frame before being migrated.
Release note
Tests
Documentation
Primary reviewers

The hysterisis we are missing is about deciding to leave a zone, to avoid WhoShouldHaveAuthority jitter on boundaries.

Closed in favor of a cleaner approach in https://github.com/spatialos/UnrealGDK/pull/2302