MapView.Circle failing to update center and radius on iOS

Hi,
I'm trying to dynamically changes properties on a circle.  It looks like the AIRMapCircle requires a reference to the AIRMap object.  Which is doesn't have.  This prevents an update.
Is there a workaround or fix pending for this?

Set a key to your Circle component with a combination of the new coord. This worked for me. Issue for this was closed here: https://github.com/airbnb/react-native-maps/issues/283#issuecomment-227812817

This looks like it was fixed in #2101

Closing as per https://github.com/react-community/react-native-maps/issues/1524#issuecomment-419176736


state-level race categories appear on national view (vaccines)

This line excludes the "unknown" categories for vaccine and could be used to exclude the state level races if needed:
https://github.com/SatcherInstitute/health-equity-tracker/blob/5bfae3839d35a91c63669e449953222714090bbb/frontend/src/cards/MapCard.tsx#L89

We should consider limiting the racial group dropdown and the small multiples view to options that include data. Currently the following categories produce entirely gray maps on vaccine, national level, small multiples view:

American Indian and Alaska Native
American Indian and Alaska Native (Non-Hispanic)
Native Hawaiian and Pacific Islander
Native Hawaiian and Pacific Islander (Non-Hispanic)
Some other race
Some other race (Non-Hispanic)

The obvious drawback being that yet again, AIAL people are left out of the options. Have to remember the NATIONAL view is really displaying STATE LEVEL data on the maps and NATIONAL LEVEL data on the charts.
Would it be worth adding the state abbreviations to the dropdown options? E.g. Asian, Native Hawaiian, and Pacific Islander [OK, NC]


More care with locales -- Strutil::vsprintf was not locale independent

We relied on vsnprintf underneath, which is locale dependent.  This is
important for OSL, which generates code that uses this (it will botch
the formatting of floating point values in OSL printf, format, error,
and other similar calls, if the user has their system set to a locale
with commas as decimal separators).
I don't yet have an all-platforms solution, but for OSX, FreeBSD, and Windows,
we can use vsnprintf_l which allows passing a locale (for which we use
the "C" locale).
It makes me very unhappy that I don't yet have a solution for Linux, which
lacks the *printf_l family of functions. I'm keeping my eyes open for
a fix here. But in the mean time, I think Windows is the platform
most likely to have users whose machines are set to foreign locale
without realizing the implications, so at least it will be fixed there.
Also found a spot in rla output that could botch certain metadata when
in the wrong locale.

I thought all our *printf logic was being handled by fmtlib ?

Technicality: we still use tinyformat for the printf-like formatting, fmtlib for the python-like formatting). But back to your question...
ALMOST all. The fmtlib/tinyformat are template based, so at build time they have to generate the version specific to the types involved.
When OSL generates code on the fly, this can't be done, so we must rely on something that takes a va_list, since we can generate LLVM IR to put arbitrary data on the stack. So we still retained a vestigial Strutil::vsnprintf that was not type safe, not based on tinyformat/fmtlib, but can be used in situations like that. Neither tinyformat nor fmtlib have a version that takes a va_list.
I'm still mulling over how to solve this fully in the long run. But for now, at least this fixes it for OSX and Windows -- they supply explicit-local-based versions of vsnprintf_l. Linux does not.

You could always grab this one:
https://github.com/nothings/stb/blob/master/stb_sprintf.h
which is pretty fast, portable, and completely locale independent.

Ah, maybe that's a solution, thanks.

Pushed an update in which we use stb_sprintf.h as the underlying implementation of Strutil::vsnprintf, since not all platforms natively have vsnprintf_l.

LGTM


Rename HOST ~> APPLICATION_HOST

The $HOST environment variable is used by zsh; overriding it affects
other programs that depend on it.
The $HOSTNAME environment variable is used similarly by GNU Bash.
This change the name of the environment variable that we depend on, to
avoid side effects.

:+1:


Add UnsplashKit in Images

Project URL
https://github.com/carambalabs/UnsplashKit
Description
Swift client for Unsplash
Checklist

[x] Only one project/change is in this pull request
[x] Addition in chronological order (bottom of category)
[x] Supports iOS 9 or later
[x] Supports Swift 3
[x] Has a commit from less than 2 years ago
[x] Has a clear README in English

          1 Error

:no_entry_sign:
Found 1 link issue

Link issue by awesome_bot

Line
Status
Link

2258
301
http://www.ioscreator.com/ redirects tohttps://www.ioscreator.com/

  Generated by :no_entry_sign: danger

Added in Unofficial

Thank you for contributing to awesome-ios 😄


SharpAdbClient push

public void Push(Stream stream, string remotePath, int permissions, DateTime timestamp, IProgress progress, CancellationToken cancellationToken);
permissions 该怎么赋值

@tkggusraqk Can you please report issues in English? Thanks!

@qmfrederik sorry,My English is not very good。
public void Push(Stream stream, string remotePath, int permissions, DateTime timestamp, IProgress progress, CancellationToken cancellationToken);
this problem，permissions How assignment？
other，the method Can not be correctly implemented, the exception

@tkggusraqk You need to specify the permissions you want to assign to the file on the Android device, in Linux octal notation.
You can find more information here: https://en.wikipedia.org/wiki/File_system_permissions#Numeric_notation
In short:

444 if you wan to grant everyone read access
666 if you want to grant everyone write access

and so forth

@tkggusraqk I'm going to go ahead & close this issue as I assume my last answer helped you close the issue. Feel free to reopen if that's not the case. Thanks!


yum 5.0.0 and selinux_policy

The tests caught a new issue which I thought I'd mention here.
yum 5.0.0 was released on the 13th:
https://supermarket.chef.io/cookbooks/yum
but selinux_policy requires 4.x.x
https://supermarket.chef.io/cookbooks/selinux_policy
Not sure this is our problem to solve, but it does mean the tests specify 4.x until further notice:
https://github.com/ianmiell/shutit-openshift-cluster/blob/master/run_tests.sh#L26

Shall we continue to track this? @ianmiell

Can we close now?


General: add units where needed on subset & visualize tabs

Units that are associated with each variable (if any) are annotated in the .owl files under unitLabel
If available, the unit should be added in parenthesis to the following places:
Browse/subset:

Variable header
Histogram axis
Histogram Subset selector (ex: SUBSET ON WEIGHT (KG))

Visualizations:

All plot axes
All statistics tables

NOTE: in July 26, 2021 EDA WG meeting, we decided to not show units in variable picker trees since once people can change units, could get confusing there

Units appear correctly in every place Danica mentioned


backoffice: decision added to workflow admin view

ref: https://github.com/cern-sis/issues-inspire/issues/549

There is currently a semi issue that each action is associated to the dag is trigger, as such in all admin panels it appears as a label the dag to run and not the value itself. This issue is only occurring in the admin panels due to the reusage of the ResolutionDags choice,


Upgrading Microsoft.Web.Xdt to ver. 2.1.1

Please upgrade nuget package  Microsoft.Web.Xdt t to the latest. I just checked, everything works fine

Any response, please?

Any response, please?

Any response please?

Any response please?


PNG quality is effecting

This the original image, after resizing it to 640x410 I am getting below image.

I can see my image getting pixelated.
Can you please help?
Below is the code that I have written.
var wh = imageHelper.getWidthAndHeight(aspectRatio,_widthDp,_heightDp,screenType);
orignalImage.quality(100).resize(wh.width,wh.height,imageResizedCallback);

Have you tried resizing with a different resizing algorithm? The following are supported:
Jimp.RESIZE_NEAREST_NEIGHBOR;
Jimp.RESIZE_BILINEAR;
Jimp.RESIZE_BICUBIC;
Jimp.RESIZE_HERMITE;
Jimp.RESIZE_BEZIER;

Same issue here, after resize my jpg image is blurred and pixelated with some other options... What's the issue?

Actually, it was not the issue with the library. I was stretching image larger than its resolutions in the preview of that image.
I replaced  with .
It solved my issue.

@ali-abbas-10p The generated image from a good quality image is blurred and pixelated doesn't matter the option I use, always is generated in that way.. In my case I'm just opening the generated image with a viewer not html yet.

I you resize an image too much smaller it will be blurry/pixelated no matter what. A smaller bitmap can only represent so many pixels, so you are bound to loose on image quality a little.
Using the example image above I got the best result using RESIZE_BILINEAR.


After start vue-cli-3 tutorial  project 98% after emitting CopyPlugin

Version
3.8.4
Environment info
 System:
    OS: Windows 10
    CPU: (12) x64 Intel(R) Core(TM) i7-8700 CPU @ 3.20GHz
  Binaries:
    Node: 10.16.0 - C:\Program Files\nodejs\node.EXE
    Yarn: 1.16.0 - C:\Program Files (x86)\Yarn\bin\yarn.CMD
    npm: 6.9.0 - C:\Program Files\nodejs\npm.CMD
  Browsers:
    Edge: 42.17134.1.0
  npmPackages:
    @vue/babel-helper-vue-jsx-merge-props:  1.0.0
    @vue/babel-plugin-transform-vue-jsx:  1.0.0
    @vue/babel-preset-app:  3.8.0
    @vue/babel-preset-jsx:  1.0.0
    @vue/babel-sugar-functional-vue:  1.0.0
    @vue/babel-sugar-inject-h:  1.0.0
    @vue/babel-sugar-v-model:  1.0.0
    @vue/babel-sugar-v-on:  1.0.0
    @vue/cli-overlay:  3.8.0
    @vue/cli-plugin-babel: ^3.8.0 => 3.8.0
    @vue/cli-plugin-eslint: ^3.8.0 => 3.8.0
    @vue/cli-service: ^3.8.0 => 3.8.4
    @vue/cli-shared-utils:  3.8.0
    @vue/component-compiler-utils:  2.6.0
    @vue/preload-webpack-plugin:  1.1.0
    @vue/web-component-wrapper:  1.2.0
    eslint-plugin-vue: ^5.0.0 => 5.2.2 (4.7.1)
    vue: ^2.6.10 => 2.6.10
    vue-eslint-parser:  5.0.0 (2.0.3)
    vue-hot-reload-api:  2.3.3
    vue-loader:  15.7.0
    vue-style-loader:  4.1.2
    vue-template-compiler: ^2.6.10 => 2.6.10
    vue-template-es2015-compiler:  1.9.1
  npmGlobalPackages:
    @vue/cli: Not Found

Steps to reproduce
Download Nodejs version 10.16.0 , install, npm install -g @vue/cli ,  vue create hello-world ,  npm run serve
What is expected?
project is compiled
What is actually happening?
INFO  Starting development server...
98% after emitting CopyPlugin

Please provide an actual reproduction repo.

@sodatea https://github.com/skortabeast/vue-cli-3-rep

I'm sorry but I can't reproduce this issue on my machine.
I guess this may be related to your filesystem, file permissions, network environment, terminal, etc… But not likely Vue CLI itself.

@sodatea yes man,  I try run on virtual machine and everything is ok, sorry for for request

I'm getting the same 98% after emitting CopyPlugin                                                         ERROR  Failed to compile with 976 errors                                                 6:00:26 PM

Me too:
98% after emitting CopyPlugin
and that's it. No response.

I experienced the same issue when I tried to use
import {someFunction} from '';
, i.e. I forgot to specify the package to import from.

Any ideas?

I have the same problem, but after debugging I found a mistake from my router file.
the problem is: "forget to submit path and component"
hope this can help you

I had such a problem. Somewhere in the code I left an empty import and forgot. Code:

import {} from ''

Hope this can help you

i got the same problem like @ssabalak and @DrMarkEy , search those codes in your project folder:
import ''

or
import {} from ''

Hope this can help you

I was getting this problem too, but for me it was defining a route in the routes (vue-router) but without creating the view component, it just hung out.

I got the same error message, but I resolved it.
In my case, I just change different branch. after that, I change back the original branch, then it doesn't work when I run "npm run serve".
The problem is all import paths are case sensitive!
So when I change to the old branch, it changes my directory name to uppercase letters( before I use uppercase directory name). But the latest branch I already changed to lowercase letters for directory  name.
For example, if your import like below:
component: () => import('@/views/test/Test'),
then you should check the directory's name and file's name must be the same uppercase letters and lowercase letters.

Tive o mesmo problema quando tentei usar
import {someFunction} from '';
, ou seja, eu esqueci de especificar o pacote para importar.

Very Very Tnks !

I experienced the same issue when I tried to use
import {someFunction} from '';
, i.e. I forgot to specify the package to import from.

thanks man haha

I think you forget to copy the files that starts with '.' like: .env or .eslint
press the cmnd + shift + . to show this hidden files and copy them.

I have same problem stuck in 98%.
98% after emitting CopyPlugin
In my case, I recheck again my code, and I found my import path is invalid, something like :
`import { myComponent } from ```
After fix the code, It works again.

There was same error for me, the problem is that I lost my vue.config.js file.

我也遇到了同样的问题，已经排除了import、require或者from引用为空的状况，我已经没有办法了

@YoungHearts  看看是不是vue.config.js丢失了，我是误删了。

@Nvhub

I have same problem stuck in 98%.
98% after emitting CopyPlugin
In my case, I recheck again my code, and I found my import path is invalid, something like :
import { myComponent } from ''
After fix the code, It works again.

very good!

[ ]

maybe your import path is invalid like:
import { getPDF } from ''

maybe your import path is invalid like:
import { getPDF } from ''

I had the same problem. Turns out one of my imports was
import { packageName} from ''

Version
3.8.4
Environment info
 System:
    OS: Windows 10
    CPU: (12) x64 Intel(R) Core(TM) i7-8700 CPU @ 3.20GHz
  Binaries:
    Node: 10.16.0 - C:\Program Files\nodejs\node.EXE
    Yarn: 1.16.0 - C:\Program Files (x86)\Yarn\bin\yarn.CMD
    npm: 6.9.0 - C:\Program Files\nodejs\npm.CMD
  Browsers:
    Edge: 42.17134.1.0
  npmPackages:
    @vue/babel-helper-vue-jsx-merge-props:  1.0.0
    @vue/babel-plugin-transform-vue-jsx:  1.0.0
    @vue/babel-preset-app:  3.8.0
    @vue/babel-preset-jsx:  1.0.0
    @vue/babel-sugar-functional-vue:  1.0.0
    @vue/babel-sugar-inject-h:  1.0.0
    @vue/babel-sugar-v-model:  1.0.0
    @vue/babel-sugar-v-on:  1.0.0
    @vue/cli-overlay:  3.8.0
    @vue/cli-plugin-babel: ^3.8.0 => 3.8.0
    @vue/cli-plugin-eslint: ^3.8.0 => 3.8.0
    @vue/cli-service: ^3.8.0 => 3.8.4
    @vue/cli-shared-utils:  3.8.0
    @vue/component-compiler-utils:  2.6.0
    @vue/preload-webpack-plugin:  1.1.0
    @vue/web-component-wrapper:  1.2.0
    eslint-plugin-vue: ^5.0.0 => 5.2.2 (4.7.1)
    vue: ^2.6.10 => 2.6.10
    vue-eslint-parser:  5.0.0 (2.0.3)
    vue-hot-reload-api:  2.3.3
    vue-loader:  15.7.0
    vue-style-loader:  4.1.2
    vue-template-compiler: ^2.6.10 => 2.6.10
    vue-template-es2015-compiler:  1.9.1
  npmGlobalPackages:
    @vue/cli: Not Found

Steps to reproduce
Download Nodejs version 10.16.0 , install, npm install -g @vue/cli , vue create hello-world , npm run serve
What is expected?
project is compiled
What is actually happening?
INFO Starting development server...
98% after emitting CopyPlugin

require(‘’)

I also encountered this problem.
Maybe the problem is "vue.config.js" file setting.
You can see this article
[entry] in the CLI command is defined as the entry file (default: src/main.js or src/main.ts in TypeScript project), not an additional entry file. If you overwrite the entry in the CLI, then the entries from config.pages are no longer considered, which may cause an error.
So remove module.exports, it maybe work, and I was successed.
After that, you can remove less code to find the district error place.

This problem will occur as long as the path of import is written wrong. I don't know what happened, it was fine before

This problem will occur as long as the path of import is written wrong. I don't know what happened, it was fine before

Delete the code, re-pull the code, reinstall vscode, problem solved


Fixed InventoryCollection Vm and Template

Default values name and location were missing
Issue: https://github.com/ManageIQ/manageiq/issues/17396

[ ] (dependent) https://github.com/ManageIQ/manageiq-providers-vmware/pull/288

Cc @agrare
Weird that it doesn't cause problems in all previous tests except vmware.
Btw I finally figured out what means "builder_params" :) Can I rename method add_builder_params to add_default_values in some next PR?

@miq-bot add_label bug

Btw I finally figured out what means "builder_params" :) Can I rename method add_builder_params to add_default_values in some next PR?

Completely agree, default values is a much better name

@slemrmartin why do we need default values for name and location?  IMO the parser should not leave these blank.

@agrare because you specify them to definitions in InventoryCollectionDefault and vmware specs fail without it

@slemrmartin hm okay let me check the vmware specs because I don't think this should be needed.  I'd rather it fail to save if vendor or name isn't passed because that is a case that shouldn't happen.

@agrare it looks good, cherry-picked.
I'm not sure about vendor, from where I refactor it, probably from amazon/azure.
It's not in InventoryCollectionDefault in core, all amazon/azure and vmware specs seems ok without it.

@slemrmartin yeah vendor can't be in the base defaults because it is provider dependent, here is where the list of vendors for vm_or_template is defined https://github.com/ManageIQ/manageiq/blob/master/app/models/vm_or_template.rb#L40-L53
I'd be fine if that was just in the parser since it just needs to be one or two places in the parser.

I know, I derived it from persister
https://github.com/ManageIQ/manageiq/blob/master/app/models/manager_refresh/inventory_collection/builder/shared.rb#L34
It fits it except case sensitivity and xen

@slemrmartin in that case I'm not sure what you weren't sure about up here :point_up: https://github.com/ManageIQ/manageiq/pull/17602#issuecomment-398664453 haha

I'm sure about value, not sure about from where I get it for refactoring :)) but probably I moved provider-specific definitions of vendor from amazon and azure to core..but nevermind :)


TestNearest won't work with @test annotation

TestNearest wont work with test annotation:
Vim test won't recognize that functions annotated with "@test" are also test. Therefore when TestNearest is run it will behave like TestFile.
/**
 * @test
 */
public function foo()
{
    $this->assertTrue(false); # cursor here
}

The below code works
public function testFoo()
{
    $this->assertTrue(false);  # cursor here
}

If you accept I can try to write a PR. Any tips on how to run the tests?

Hey, thanks for reporting. Yes, I would accept a PR for this. If you have Ruby installed, it's just a gem install vim-flavor and you can run :VSpec when inside of Vim. Alternatively I could add Travis CI which would run the tests for you.
The only problem is that test#base#nearest_test() can currently only find matches on the line where the test name is seen. So, if it sees @test, you cannot tell it to go down until the function definition. Maybe the function could be extended somehow, alternatively you could copy that behaviour to the Maven runner and alter it to do what you want.

Thank you @janko-m! I will give that a try =)


TLS Certificate Pinning

Readiness checklist

[ ] I added/updated tests.
[X] I ensured that the PR title is good enough for the changelog.
[X] I labeled the PR.

Moving this to the Connector https://github.com/nmshd/connector/pull/295


Tooltip functionality behaving weird for the copy to clipboard

@tgolen @CortneyOfstad PR is ready for review.
Details

Tooltip functionality for the "copy to clipboard" feature in the "details" section behaves weird if clicked multiple times.
Fixed Issues

$ https://github.com/Expensify/App/issues/17182
PROPOSAL: https://github.com/Expensify/App/issues/17182#issuecomment-1502302681
Tests

Open any "chat".
Tap on name at header or display picture.
Select email by clicking “copy to clipboard”. Click it multiple times.

[x] Verify that no errors appear in the JS console

Offline tests

Open any "chat".
Tap on name at header or display picture.
Select email by clicking “copy to clipboard”. Click it multiple times.

QA Steps

Open any "chat".
Tap on name at header or display picture.
Select email by clicking “copy to clipboard”. Click it multiple times.

Expected Result
The tooltip should work smoothly and not shake, even if the "copy to clipboard" feature is clicked multiple times.

[x] Verify that no errors appear in the JS console

PR Author Checklist

[x] I linked the correct issue in the ### Fixed Issues section above
[x] I wrote clear testing steps that cover the changes made in this PR

[x] I added steps for local testing in the Tests section
[x] I added steps for the expected offline behavior in the Offline steps section
[x] I added steps for Staging and/or Production testing in the QA steps section
[x] I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
[x] I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
[x] I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).

[x] I included screenshots or videos for tests on all platforms
[x] I ran the tests on all platforms & verified they passed on:

[x] Android / native
[x] Android / Chrome
[x] iOS / native
[x] iOS / Safari
[x] MacOS / Chrome / Safari
[x] MacOS / Desktop

[x] I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
[x] I followed proper code patterns (see Reviewing the code)

[x] I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
[x] I verified that comments were added to code that is not self explanatory
[x] I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
[x] I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method

[x] If any non-english text was added/modified, I verified the translation was requested/reviewed in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:

[x] I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
[x] I verified any copy / text that was added to the app is correct English and approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
[x] I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
[x] I verified the JSDocs style guidelines (in STYLE.md) were followed

[x] If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
[x] I followed the guidelines as stated in the Review Guidelines
[x] I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
[x] I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
[x] I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
[x] I verified that if a function's arguments changed that all usages have also been updated correctly
[x] If a new component is created I verified that:

[x] A similar component doesn't exist in the codebase
[x] All props are defined accurately and each prop has a /** comment above it */
[x] The file is named correctly
[x] The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
[x] The only data being stored in the state is data necessary for rendering and nothing else
[x] For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
[x] Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
[x] All JSX used for rendering exists in the render method
[x] The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions

[x] If any new file was added I verified that:

[x] The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory

[x] If a new CSS style is added I verified that:

[x] A similar style doesn't already exist
[x] The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG))

[x] If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
[x] If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
[x] If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
[x] If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
[x] If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
[x] I have checked off every checkbox in the PR author checklist, including those that don't apply to this PR.

Screenshots/Videos

Web

https://user-images.githubusercontent.com/43096403/231251966-7193a5de-f95e-42d1-b9ac-89d5a1d86b45.mov

Mobile Web - Chrome
https://user-images.githubusercontent.com/43096403/231253264-3452c918-7123-43b4-8d58-402c07e7cdc4.mov

Mobile Web - Safari

https://user-images.githubusercontent.com/43096403/231253791-8fac39de-3ee4-4202-9b7c-e471b24eb1ed.mov

Desktop

https://user-images.githubusercontent.com/43096403/231254292-4049f5fc-7bc3-424d-b45c-6a5c2c9eecf9.mov

iOS

https://user-images.githubusercontent.com/43096403/231263581-a321c11b-7fef-44f1-b95e-570cf9bedec2.mov

Android
https://user-images.githubusercontent.com/43096403/231261462-3133104c-d6b9-4374-a13e-24820afcb9a2.mov

@tgolen @thesahindia One of you needs to copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

recheck

@thesahindia No I don't have fix for above issue. But I think I should be paid for this one because I managed to provide the solution according to the issue statement.

I have already found the cause of the problem. The problem is in TooltipRenderedOnPageBody component which is subcomponent of Tooltip component. So this problem should be reproducible anywhere where Tooltip inner content is changing, not only on just  "details" screen.
Problem lies in componentDidUpdate function. Here the tooltipContentWidth is set to undefined on every component update. Due to this an additional rendered is performed on tooltip which is causing issues. As seen in the video.
componentDidUpdate(prevProps) {
    if (
      prevProps.text === this.props.text &&
      prevProps.renderTooltipContent === this.props.renderTooltipContent
    ) {
      return;
    }

    // Reset the tooltip text width to 0 so that we can measure it again.
    // eslint-disable-next-line react/no-did-update-set-state
    this.setState(
      {tooltipContentWidth: undefined},
      this.updateTooltipContentWidth,
    );
  }

Video:
https://user-images.githubusercontent.com/43096403/231771881-575e7ffe-8413-4508-ad79-edf3b76eb123.mov
If I comment the last line in this function that sets tooltipContentWidth to undefined then the tooltip behaves correctly but the width of the tooltip is not calculated correctly:
Video:
https://user-images.githubusercontent.com/43096403/231781795-62fb68af-27bd-4315-861e-2b3d08f2f6b1.mov
I am unable to figure out how to calculate width for tooltip correctly without setting tooltipContentWidth to undefined.
So, I believe this requires significant more effort in solving than the original scope. Also since the issue is in Tooltip component instead of the "details" section so it will require a lot more testing after fixing to check tooltip behaves correctly everywhere in app. Although I managed to find the source of problem but I am unable to fix it. So I would prefer to create a new issue for this. Thanks.
CC: @tgolen

OK, thank you for investigating it. I agree with you that this seems like having a new GH issue opened for it would be a good idea.

@thesahindia Let me know if there is anything remaining from my side to get this PR merged. Thanks.

OK, we are all good here. Gonna merge it.

Can one of you please be sure to report the other bug that was found?

:hand: This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

🚀 Deployed to staging by https://github.com/tgolen in version: 1.3.1-0 🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
failure ❌

🕸 web 🕸
success ✅

🚀 Deployed to staging by https://github.com/tgolen in version: 1.3.1-0 🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
failure ❌

🕸 web 🕸
success ✅

🚀 Deployed to production by https://github.com/mountiny in version: 1.3.1-3 🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
success ✅

🕸 web 🕸
success ✅


Location field tweaks for Cockpit-Next branch

see #388
Additionally removed the sensor=false& param from google maps api loader, to prevent warning SensorNotRequired (see https://developers.google.com/maps/documentation/javascript/error-messages#sensor-not-required)

Thanks!


Stale analysis errors in the editor not going away

What happened?
After fixing errors in the program, the red line in the editor does not disappear, the following should have no red underline since I added the field to fix the error:

Note that the list of diagnostics in the bottom right does go away, but the red lines under the code that had an error does not disappear.
Steps to reproduce problem
Create a class with a constructor that initializes a field that does not yet exist:
class A {
  A(this.value);
}

Then fix the issue by adding a value field:
class A {
  final Object value;

  A(this.value);
}

The error should disappear, but does not.
Additional info
Browser
Browser: Chrome
Version: 102.0.5005.125
Are you using any extensions/plugins that affect website behavior
(particularly those that affect iframes, such as ad blockers)? No
Are there any warnings or errors in your browser's JavaScript console?
If so, paste them below:
See https://github.com/dart-lang/dart-pad/issues/2310
Machine
Operating system: Chrome OS
Version: 102.0.5005.125

@johnpryan can you please roll a release?

Done


inx file in samples

Some of inx file in samples doesn't have CR/LF line end. Stampinf doesn't treat this correctly. It will make build-error for the sample projects.
Please fix these inx files.

Hi Atomu, thanks for pointing this out.
Can you specify for which samples this causes build breaks?

Hi,
storage/ramdisk
general/echo

0b386da should address this by forcing .inx files to have crlf on checkout.


DataFlowKernel.cleanup() triggers server shutdown

After https://github.com/fractal-analytics-platform/fractal-server/pull/88, we would like to cleanup all DFKs after a workflow is complete, but this leads to server shutdown:
2022-09-30 10:23:16,229 INFO sqlalchemy.engine.Engine [cached since 9.306s ago] (2,)
INFO:     <IP_ADDRESS>:60020 - "GET /api/v1/dataset/1/2 HTTP/1.1" 200 OK
2022-09-30 10:23:16,230 INFO sqlalchemy.engine.Engine ROLLBACK
INFO:     Waiting for application shutdown.
INFO:     Application shutdown complete.
INFO:     Finished server process [49824]

The dfk.cleanup() line is currently commented out, but we need to solve this issue to avoid proliferation of processes.

Some additional info:

Possible cause 1: dfk.cleanup() triggers FlowControl._thread.join()`
Possible cause 2: dfk.cleanup() triggers HighThroughputExecutor.shutdown, which triggers self.interchange_proc.terminate(). Maybe change fork to spawn in https://github.com/Parsl/parsl/blob/master/parsl/multiprocessing.py#L15? To check

Also possibly interesting:

https://github.com/Parsl/parsl/pull/2429
https://github.com/Parsl/parsl/pull/2437
https://github.com/Parsl/parsl/pull/2433

from a parsl developers perspective, i'm interested in understanding what's going on here: what process is your application server runing in that is getting incorrectly shut down? the main submitting/workflow process or one of the htex worker processes?

Our application lets users define some workflows (NOTE: "workflow" refers to some custom objects, rather than parsl workflows), which are then executed on a SLURM cluster. We currently use parsl for SLURM integration, and for some very basic dependency handling. The application runs as a server (based on fastapi and served via uvicorn) on the SLURM main node, and then another (client) application lets users interact with it from their local machines.
For each workflow, we'd like our server application to do the following:

Create a DFK instance;
Define a series of python app (associated to that DFK);
Wait for execution (via the result() method of the last app future);
Close that DFK (with its cleanup() method).

Since multiple users can define and submit multiple workflows at the same time, we'd like to have one DFK per worfklow, rather than a single global one. This also helps in getting a clean monitoring, since (in our understanding) parsl-visualize shows an entry per DFK - meaning that all our users' workflows would get mixed up if we use a single DFK.
We implemented our approach and in principle we are satisfied with its modularity (start workflow -> start DFK, end workflow -> close DFK and related processes), up to the problem mentioned in this issue. The main server application calls a cleanup() method for some active DFK, and then the application itself receives a shutdown. The uvicorn shutdown is this one https://github.com/encode/uvicorn/blob/b22c9506b282e9c81591ed7f48781dc5759df0e0/uvicorn/lifespan/on.py#L63, but we still don't know which part of the DFK cleanup() triggers it. We also need to debug a bit further, to see whether this always happens (i.e. at each cleanup), or is related to some more specific conditions.
(probably @jacopo-exact  can chime in in the following days with some more details)

We (me and @tcompa) realized a minimal example that reproduce the error:
from fastapi import FastAPI
from parsl.dataflow.dflow import DataFlowKernel
from parsl.config import Config
from parsl.app.python import PythonApp
from parsl.executors import HighThroughputExecutor
import math

app = FastAPI()

@app.get("/")
async def root():

    htex = HighThroughputExecutor()
    conf = Config(executors=[htex])
    dfk = DataFlowKernel(config=conf)
    app = PythonApp(
        math.cos,
        data_flow_kernel=dfk
    )
    res = app(1).result()
    dfk.cleanup()
    return {"message": f'{res}'}

With @mfranzon we narrowed down the error a bit further, and now have a minimal reproducible example. We also explored recent parsl functionalities, with no success.
How to reproduce

Save code from previous comment in main.py.
Install fastapi (we pip-installed version 0.78.0), which also installs the web server uvicorn (we have 0.18.3).
From the command line, run uvicorn main:app. The server is now up and running, as seen in the logs on the terminal

INFO:     Started server process [71313]
INFO:     Waiting for application startup.
INFO:     Application startup complete.
INFO:     Uvicorn running on http://<IP_ADDRESS>:8000 (Press CTRL+C to quit)

Call the root endpoint from the command line, via curl <IP_ADDRESS>:8000/. This leads to the correct execution of the parsl app, but then shuts down the server (see logs below), and from now on we cannot call the endpoint any more.

INFO:     <IP_ADDRESS>:52626 - "GET / HTTP/1.1" 200 OK
INFO:     Shutting down
INFO:     Waiting for application shutdown.
INFO:     Application shutdown complete.
INFO:     Finished server process [71313]

Where we stand
The statement triggering the shutdown is dfk.cleanup() (this is clear because if we remove that line then the server is not shut down upon calling the endpoint). The cleanup method internally calls:

FlowControl._thread.join() and FlowControl._kill_event.set().
HighThroughputExecutor.interchange_proc.terminate(), where HighThroughputExecutor.interchange_proc is a ForkProcess.

Our trivial guess is that one of these signals propagates to the process running the server, triggering its shutdown. It is unclear to us why/how this happens.
We are digging further around the shutdown on the server side, to see what is going on. A very relevant issue is

https://github.com/tiangolo/fastapi/issues/1487

ThreadPoolExecutor does work as expected
If we replace HighThroughputExecutor with ThreadPoolExecutor, we obtain the expected behavior (the endpoint function reaches its end without shutting down the server, and we can call it multiple times).
Further checks with recent parsl
We also installed parsl=2022.10.10, to try out PR https://github.com/Parsl/parsl/pull/2433, where HighThroughputExecutor has a start_method attribute taking values in ['fork', 'spawn', 'thread']. None of the three possible choices for start_method solves our issue (i.e. the server is always shut down by dfk.cleanup()).

@mfranzon finally found the explanation, see:

https://github.com/encode/uvicorn/issues/548#issuecomment-1157082729
https://github.com/tiangolo/fastapi/issues/1487

The issue is due to a combination of uvicorn (our web server) and multiprocessing (which is part of parsl HTEX). And it is related to the HTEX interchange, rather than to the FlowControl.
Quoting from https://github.com/encode/uvicorn/issues/548#issuecomment-1157082729

asyncio setups signal handler in a specific way -- it calls signal.set_wakeup_fd and passes an fd of the opened socket. After it, if any signals are sent to the process, they will be written to this socket/fd.
Any child process will inherit not only signal handlers' behavior but an opened socket. And as a result, when we are sending a signal to the child process, it will be written to the socket and the parent process will receive it too, even though this signal was sent not to him; Or if you will send it to the parent process, the child process will receive this signal too;

To solve the issue in our minimal reproducible example, it is sufficient to add the lines
import signal
signal.set_wakeup_fd(-1)
signal.signal(signal.SIGTERM, signal.SIG_DFL)
signal.signal(signal.SIGINT, signal.SIG_DFL)

at the beginning of the starter function in parsl/executors/high_throughput/interchange.py:
https://github.com/Parsl/parsl/blob/master/parsl/executors/high_throughput/interchange.py#L588-L599
We are now looking at the least risky way of doing this.

fractal-server now uses https://github.com/fractal-analytics-platform/parsl/tree/1.3.1-dev, where we problem is solved as described in the previous comment. It's not obvious whether this is is something that may end up in upstream parsl. On the one hand, such change is not related to a parsl bug but rather to the mix of uvicorn and multiprocessing. On the other hand, having this change in parsl would enable using it within a uvicorn web server (not sure of unintended consequences though). I'll link to this issue on parsl slack channel, for information.
Closing.

A comprehensive summary of this issue is now available in

https://github.com/Parsl/parsl/issues/2452

@tcompa your post above made my day, unrelated project/code... but it finally put an end to like 16hours of debugging a fastapi crash issue


Suggestion: Please provide option to toggle off the hack for forced 4 Neow options.

If such an option already exists with this mod, I would greatly appreciate being guided toward it. As stands, this lack of toggle greatly disincentives my usage of this mod in-between more serious runs of spire. Love your work, Ojb.
~Jaina

Thanks for the feedback! The next update will have toggle-able options in the config menu to disable this little hack. I'll close this issue when that update is pushed - and if you're subscribed to the Workshop you should get the update automatically. Cheers.

Thank you for your kind contributions! Cheers.


Would you please explain in the documentation how to render the pagination links (next, prev. page 1. 2 etc..)

Link rendering is not handled by scrivener nor scrivener_ecto. scrivener_html is a library that helps with this (I am not the author).


Add address key on nagios check

Nagios check without address make the agent fail to create telegraf configuration file.
Waiting for response from @bleemeo to resolve or not as it may be an agent-side problem.

In fact, address and port are optional but possible configuration keys, they should appear on bleemeo_nagios_check resource.


Correct release version of Background Fetch

@jakearchibald FYI

Whoops!
There were 1 warnings that will prevent this PR from being merged. Please take a look, and either fix, or provide a justification for why they can't be fixed.
WARNINGS
src/content/en/updates/2018/12/background-fetch.md#L436 - Common typo found: 'chrome' Should it be 'Chrome'?


Support annotations on what media spike-ins are possible for a factor of type “sample”

XPlan needs to know what media spike-ins are possible for a factor of type “sample” from an ER document.
However, IP does not have a place to specify this information.
This slack thread here records information about this discussion.
The idea is to have  IP allow this information to be annotated as a row wise constraint on a measurement table.
@danbryce mentioned that the generated from IP should take on this form:
"Kanamycin_additive": {
                "name": "Kanamycin_additive",
                "domain": [
                    0, 128
                ],
                "dtype": "float",
                "otype": "DesignElement",
                "ftype": "sample"
            },

@mwes proposed additional structures that will be supported from his end (maybe in data catalog) to readily support this feature for @danbryce. As such, contact @mwes to follow up on his proposed data structure to address this feature request for IP.

This issue is OBE at this point.  We were planning on treating these reagents as media spike-ins, but decided to do them as inducers.  This feature may become important in the future.

On Aug 25, 2020, at 11:14 AM, Tramy Nguyen<EMAIL_ADDRESS>wrote:
XPlan needs to know what media spike-ins are possible for a factor of type “sample” from an ER document.
However, IP does not have a place to specify this information.
This slack thread here records information about this discussion.
The idea is to have IP allow this information to be annotated as a row wise constraint on a measurement table.
@danbryce mentioned that the generated from IP should take on this form:
"Kanamycin_additive": {
"name": "Kanamycin_additive",
"domain": [
0, 128
],
"dtype": "float",
"otype": "DesignElement",
"ftype": "sample"
},
@mwes proposed additional structures that will be supported from his end (maybe in data catalog) to readily support this feature for @danbryce. As such, contact @mwes to follow up on his proposed data structure to address this feature request for IP.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or unsubscribe.

Closing for now as OBE. @danbryce please reopen again if it becomes important in the future.


fix the registration bug popup error

Change the dialog alert state to false after click the ok button at popup alert

close #2

close #2


Display SL No

how to add a column displaying serial number of a row

Where is this serial number coming from?
You can refer to the documentation to find out how to add columns to the table: https://github.com/spatie/vue-table-component#usage


Add someone else's accounts  and learning their identity

Code 1 - ./concordium-client config account add 3o1JLuuLbko3VkkpwFJVvfMgwygQ5SX3t5feYXFLqdDmnLSNns --name hdrns01
Result :
Adding account 3o1JLuuLbko3VkkpwFJVvfMgwygQ5SX3t5feYXFLqdDmnLSNns with name 'hdrns01'.
Creating directory '/var/lib/concordium/config/accounts/3o1JLuuLbko3VkkpwFJVvfMgwygQ5SX3t5feYXFLqdDmnLSNns'.
Created key directory.
Writing file '/var/lib/concordium/config/accounts/names.map'.
Added name mapping.
Code2- ./concordium-client config show
Result : Base configuration:

Verbose:            no
Account config dir: /var/lib/concordium/config/accounts
Account name map:
Dona -> 3UYPS3Zbm8bTBXLcob7f9Y8TjamndqqMjbCRs45hSFpBJUX3oA
T1 -> 4XgbW1qRxFiUtcZW2B9G8q9k2ThJpn5yn1ibrEjC5qbyDhEmVf
T2 -> 3AXrqVzeFibTJsKGFTonjCjTrM7Vv342W498REQ59L563afZc8
hdrns01 -> 3o1JLuuLbko3VkkpwFJVvfMgwygQ5SX3t5feYXFLqdDmnLSNns

concordium-client: /var/lib/concordium/config/accounts/3o1JLuuLbko3VkkpwFJVvfMgwygQ5SX3t5feYXFLqdDmnLSNns/encSecretKey.json: openBinaryFile: does not exist (No such file or directory)
As a result, I added someone else's account to my own node. If I tried a little more, I could transfer money from this account. Someone more professional could benefit from this.

code : $ ./concordium-client account show hdrns01
Result:
Local name:            hdrns01
Address:               3o1JLuuLbko3VkkpwFJVvfMgwygQ5SX3t5feYXFLqdDmnLSNns
Balance:               775.963200 GTU
Nonce:                 1254
Delegation:            none
Encryption public key: a820662531d0aac70b3a80dd8a249aa692436097d06da005aec7c56aad17997ec8331d1e4050fd8dced2b92f06277bd581285b692c4d15ec49d1214c89021ae31a287f529dcb41829a12079dc982d2c60e720b897a5580fa078a6675e67943e3
Credentials:

81285b692c4d15ec49d1214c89021ae31a287f529dcb41829a12079dc982d2c60e720b897a5580fa078a6675e67943e3:

Expiration: Sep 2021
Revealed attributes: firstName="YUSUF", lastName="ONCEL", dob="19810810", idDocType="2", idDocNo="G13618334", idDocIssuer="TR"

I have reached the identity information of the person belonging to the account.

Hi donadel01
It's an interesting test case you tried out there. But what you can see is information, which is public by design of the blockchain and cannot be exploited maliciously.

Yes, it looks as if you can add an account belonging to someone else. However note that you cannot add the account specific secret key to decrypt nor the signing key to sign transactions. Hence, if you created a transaction from the account, you would need to sign it with a key you don't have. You can try another signing key but the bakers would eventually reject it when check the validity of the signature belonging to that specific account..

The identity information you can see on the chain are the attributes revealed by the user himself when creating an account. The balance is not the total balance but the general balance (i.e. unshielded), which is public by design as well. Note that the blockchain also provides the concept of a shielded balance, which cannot be read out by another user (who does not have the secret decryption key, see 1) ).

Hope this explanation could shed some light.


[enhancement]: FLUX copy&paste

Is there an existing issue for this?

[X] I have searched the existing issues

Contact Details
No response
What should this feature add?
FLUX
maybe copy & paste from webforge-ui
https://github.com/lllyasviel/stable-diffusion-webui-forge
ItS  SOOO EASY ^^
Alternatives
No response
Additional Content
No response

https://github.com/invoke-ai/InvokeAI/releases/tag/v4.2.9rc1


Filter by day of the week

Use universal calendar??

this is implemented in dev, @anjacque can you test?
also, do you also need multiple days selection like for journal and month?

Thanks!
Yes, for the multiple days selection (it could be interesting to allow a request on "Saturdays AND Sundays" if someone is interested in weekends editions, for exemple).
I suppose that you know this, but we have the same bug here as in the "Month filter": changing the "Year filter" removes the "day of the week filter".

@anjacque oh I had misunderstood the issue! should be fixed now :)
I leave open for multiple days like saturday + sunday

implemented in dev


Extend priority test for "class_definition" vs "braces"

Coverage remained the same at 91.849% when pulling 66e8a0fec3830480f75f85be65e80551fb82df7c on kubawerlos:extend_priority_test_for_class_definition_vs_braces into 61b909085be0f9bb9de5223be0f80ea3027eed5d on FriendsOfPHP:2.18.

@kubawerlos , should we close #5566 with merge of this PR?

@keradus well, the simple answer is no, as this is only extending test to make it more explicit, so the other issue is already fixed or won't be fixed by this. Let me take a look at the other issue.

Thank you @kubawerlos.


support new version of llamacpp

Hi Abdeladim, there are many new models that can't run on the pyllamacpp binding because they are using version 2 of ggml.
If you have some time, can you try and add support to this please?

Hi Saifeddine,
Yes I am in the process of syncing the bindings with the latest llama.cpp progress, but there are so many breaking changes to llama.cpp lately so it is taking time.
Meanwhile, could you please share with me some links of the models that do not work so I can test them ?
Thank you!

hi, thanks, here are some. The bloke has up  todate models. for example :
https://huggingface.co/TheBloke/Wizard-Vicuna-7B-Uncensored-GGML

Yeah, those models are converted to the newest version of ggml after this breaking change ggerganov/llama.cpp#1405.
The problem is there is no backward compatibility with older models!
I think I will push a release up to that change, and then another release after that change, this way one can choose what version to use based on the models they have ?
what do you think ?

It can be done like this. For now, I use the official llamacpp binding for the new models format and yours for the previous ones. But maybe having two releases is a good thing.

Version 2.3.0 is now built with the latest llama.cpp release ( 699b1ad ) and it is working with the newest version of the models ( I've tested it with the WizardLM model above at least).

The 2.2.0 version can still be used for older models.

But Yeah feel free to use either one. The official bindings are great as well.

I used these steps to update the new model:
Follow these steps to easily acquire the (Alpaca/LLaMA) F16 model:

    Download and install the Alpaca-lora repo. https://github.com/tloen/alpaca-lora
    Once you've successfully downloaded the model weights, you should have them inside a folder like this (on linux):
    run python convert-pth-to-ggml.py ~/.cache/huggingface/hub/models--decapoda-research--llama-7b-hf/snapshots/5f98eefcc80e437ef68d457ad7bf167c2c6a1348 1
    Once you get your f16 model, copy it into the llama.cpp/models folder.
    Run: ./quantize ./models/ggml-model-f16.bin ./models/ggml-model-q4_0.bin q4_0

Done.

..but indeed - the pyllamacpp bindings are now broken.
I'll have a look and see if I can switch to the abetlen/llama-cpp-python bindings in the meantime, and get it to work. But yeah - version upgrade is a real time waster, which is why developers should take note and either 1. make it easy to update or 2. make your app/framework/etc. backward compatible with older versions.

Ok, I have a workaround for now.
It seems that the prompt_context, prompt_suffix and prompt_prefix are broken. So I have to add them manually into the prompt for now.
These python bindings are the only ones working with the new implementation of LLama.cpp. So well done

How do i upgrade any model to the new version of ggjt 2?
using gpt4-x-alpaca-13b-native-ggml-model-q4_0
(i'm now able to compile with cmake)

I used these steps to update the new model:
Follow these steps to easily acquire the (Alpaca/LLaMA) F16 model:

   1. Download and install the Alpaca-lora repo. https://github.com/tloen/alpaca-lora
   2. Once you've successfully downloaded the model weights, you should have them inside a folder like this (on linux):
   3. run python convert-pth-to-ggml.py ~/.cache/huggingface/hub/models--decapoda-research--llama-7b-hf/snapshots/5f98eefcc80e437ef68d457ad7bf167c2c6a1348 1
   4. Once you get your f16 model, copy it into the llama.cpp/models folder.
   5.  Run: ./quantize ./models/ggml-model-f16.bin ./models/ggml-model-q4_0.bin q4_0

Done.

..but indeed - the pyllamacpp bindings are now broken.
I'll have a look and see if I can switch to the abetlen/llama-cpp-python bindings in the meantime, and get it to work. But yeah - version upgrade is a real time waster, which is why developers should take note and either 1. make it easy to update or 2. make your app/framework/etc. backward compatible with older versions.

Version 2.3.0 is now built with the latest llama.cpp release ( 699b1ad ) and it is working with the newest version of the models ( I've tested it with TheBloke's model above at least).

The 2.2.0 version can still be used for older models.

But Yeah feel free to use either one. The official bindings are great as well.

It doesn't work for me. It is hallucinating 100% of the time, often in random languages, and not responding coherently to any of my prompts.

@twinlizzie from where did you get the steps you described here ?
Is convert-pth-to-ggml.py is now updated to to convert the models to the new ggjtv2 format ?
Yeah, unfortunately, llama.cpp introduced some breaking changes and it is not backward compatible, the models need to be reconverted! I tried to push aversion to PYPI (v2.2.0) before updating to the latest version to be compatible with the older models. You can give it a try as well ?

Ok, I have a workaround for now.
It seems that the prompt_context, prompt_suffix and prompt_prefix are broken. So I have to add them manually into the prompt for now.
These python bindings are the only ones working with the new update of LLama.cpp. So well done
UPDATE:
It seems to repeat a lot of answers, which I don't think used to happen before (or maybe I missed it?).

What do you mean by it repeat answers ? You mean you get the same answer everytime you run the generation ?

How do i upgrade any model to the new version of ggjt 2? using gpt4-x-alpaca-13b-native-ggml-model-q4_0 (i'm now able to compile with cmake)

@Naugustogi, afaik you will need to get the Pytorch models and re-quantize them to a supported format.

I used these steps to update the new model:
Follow these steps to easily acquire the (Alpaca/LLaMA) F16 model:

   1. Download and install the Alpaca-lora repo. https://github.com/tloen/alpaca-lora
   2. Once you've successfully downloaded the model weights, you should have them inside a folder like this (on linux):
   3. run python convert-pth-to-ggml.py ~/.cache/huggingface/hub/models--decapoda-research--llama-7b-hf/snapshots/5f98eefcc80e437ef68d457ad7bf167c2c6a1348 1
   4. Once you get your f16 model, copy it into the llama.cpp/models folder.
   5.  Run: ./quantize ./models/ggml-model-f16.bin ./models/ggml-model-q4_0.bin q4_0

Done.

..but indeed - the pyllamacpp bindings are now broken.
I'll have a look and see if I can switch to the abetlen/llama-cpp-python bindings in the meantime, and get it to work. But yeah - version upgrade is a real time waster, which is why developers should take note and either 1. make it easy to update or 2. make your app/framework/etc. backward compatible with older versions.

Version 2.3.0 is now built with the latest llama.cpp release ( 699b1ad ) and it is working with the newest version of the models ( I've tested it with TheBloke's model above at least).

The 2.2.0 version can still be used for older models.

But Yeah feel free to use either one. The official bindings are great as well.

It doesn't work for me. It is hallucinating 100% of the time, often in random languages, and not responding coherently to any of my prompts.

@twinlizzie from where did you get the steps you described here ? Is convert-pth-to-ggml.py is now updated to to convert the models to the new ggjtv2 format ?
Yeah, unfortunately, llama.cpp introduced some breaking changes and it is not backward compatible, the models need to be reconverted! I tried to push aversion to PYPI (v2.2.0) before updating to the latest version to be compatible with the older models. You can give it a try as well ?

Yep. Convert-pth-to-ggml works now to convert larger models to the ggjtv2. And I figured out the steps on my own.

Ok, I have a workaround for now.
It seems that the prompt_context, prompt_suffix and prompt_prefix are broken. So I have to add them manually into the prompt for now.
These python bindings are the only ones working with the new update of LLama.cpp. So well done
UPDATE:
It seems to repeat a lot of answers, which I don't think used to happen before (or maybe I missed it?).

What do you mean by it repeat answers ? You mean you get the same answer everytime you run the generation ?

Actually, I'm not entirely sure. I set the repeat_penalty to 1.2 and it seems to have fixed it, for now.
It would sometimes get stuck in a loop where you get the same type of answer no matter what you ask.
On the llama-cpp-python repo it seems to be even worse because you always get the same answers 100%. (Or maybe I'm missing something about how to properly run the api...)

@twinlizzie from where did you get the steps you described here ? Is convert-pth-to-ggml.py is now updated to to convert the models to the new ggjtv2 format ?
Yeah, unfortunately, llama.cpp introduced some breaking changes and it is not backward compatible, the models need to be reconverted! I tried to push aversion to PYPI (v2.2.0) before updating to the latest version to be compatible with the older models. You can give it a try as well ?

Yep. Convert-pth-to-ggml works now to convert larger models to the ggjtv2. And I figured out the steps on my own.

Ok, I have a workaround for now.
It seems that the prompt_context, prompt_suffix and prompt_prefix are broken. So I have to add them manually into the prompt for now.
These python bindings are the only ones working with the new update of LLama.cpp. So well done
UPDATE:
It seems to repeat a lot of answers, which I don't think used to happen before (or maybe I missed it?).

What do you mean by it repeat answers ? You mean you get the same answer everytime you run the generation ?

Actually, I'm not entirely sure. I set the repeat_penalty to 1.2 and it seems to have fixed it, for now.
It would sometimes get stuck in a loop where you get the same type of answer no matter what you ask.
On the llama-cpp-python repo it seems to be even worse because you always get the same answers 100%. (To the same question that is) .Or maybe I'm missing something about how to properly run the api...
The Llama.cpp itself does not have this problem and works perfectly even with my diy upgraded model. I get a different answer to the same question which is how I want it.

I just tested it again on my end with the models above and I don't have this problem. Everytime I run it I get a different answer.
Could you please share the code ? Maybe you are doing something wrong!


Overwrite existing environment variables

Hi there!
I ran into an issue when using a proxy on a production system (using passenger).
Somehow passenger evaluated the .bash_profile script when starting from mod_apache.
However, I noticed that existing ENV variables never get overwritten by dotenv. Why doesn't dotenv overwrite existing ENV variables?
I am using dotenv-rails, 2.1.0. I saw that there's a method apply! on the Environment class, this is what I need, but I didn't find a doc how to use it :grin:
Cheers :beers:

Hey @siegy22. This is definitely intentional. Dotenv assumes the  deployment environment has more knowledge about configuration than the application does. You can call Dotenv.overload to overwrite existing environment variables.
I'll leave this open as a reminder to update the docs. If anyone wants to take a pass at it, be my guest!


Unable to properly select text in panels

Summary
Enable user to properly select text in panels
Relevant Technical Choices
Use global.getSelection to identify the section scope from the user. Prevent preventScroll setting on focusout event that is outside the canvas container.
To-do
N/A
User-facing changes
User will be able to select text on both the left sidebar and the right sidebar (checklist panel, document panel, ... etc)
Testing Instructions
User should be able to select text properly outside the canvas container.

Fixes #5407

Just a reference for some technical research about the focus preventScroll document:
https://developer.mozilla.org/en-US/docs/Web/API/HTMLOrForeignElement/focus#Focus_with_focusOption
Also to recap, here is the scenario that should trigger the focusout event in before the fix:

Select a text in the canvas, highlight some text, like this:

Multi-select the 2nd text, move the 2nd text, the 1st text shouldn't move:

We shouldn't break the logic above while allow user to properly select text outside the canvas container:

The text selection should no longer get block by the 300ms timer.


Isto ingressgateway cannot get the real IP address of the client

Bug description
Affected product area (please put an X in all that apply)
[ ] Networking
Affected features (please put an X in all that apply)
[ ] Physical machine
Expected behavior
Steps to reproduce the bug
Version (include the output of istioctl version --remote and kubectl version --short and helm version if you used Helm)
istio 1.2.2
kubernetes 1.14.2
helm 2.16.0
How was Istio installed?
helm install istio 1.2.2
Environment where bug was observed (cloud vendor, OS, etc)
Local physical machine kubernetes cluster istio no cluster deployment
error describe
At present, I use k8s + isto architecture, and I do not use the inress configuration of k8s. Instead, I use isto inress gateway. Nginx service directly accesses the front-end and back-end pages through the inress gateway. However, I can't get the real IP of the client in my service. How do I need to modify the relevant configuration of isto to obtain it successfully?
nginx config
`
server {
listen  80;
location / {
root   /web;
index  index.html index.htm;
try_files $uri $uri/ /index.html;
proxy_set_header    X-Real-IP        $remote_addr;
proxy_set_header    X-Forwarded-For  $proxy_add_x_forwarded_for;
proxy_set_header    HTTP_X_FORWARDED_FOR $remote_addr;
}
location /nginxstatus {
  stub_status on;
  access_log on;
}

}
log_format  main  '$http_x_forwarded_for | $http_x_real_ip | $remote_addr - $remote_user [$time_local] "$request" '
'$status $body_bytes_sent "$http_referer" '
'"$http_user_agent" "$http_x_forwarded_for"';
`
nginx logs
<IP_ADDRESS> | - | <IP_ADDRESS> - - [23/Oct/2020:17:59:08 +0800] "GET /umi.js HTTP/1.1"<PHONE_NUMBER> "http://<IP_ADDRESS>/monitor/services/list" "Mozilla/5.0 (Macintosh; Intel Mac OS X 10_13_6) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/83.0.4103.61 Safari/537.36" "<IP_ADDRESS>" <IP_ADDRESS> | - | <IP_ADDRESS> - - [23/Oct/2020:17:59:09 +0800] "GET /vendors.chunk.css HTTP/1.1" 200 352929 "http://<IP_ADDRESS>/monitor/services/list" "Mozilla/5.0 (Macintosh; Intel Mac OS X 10_13_6) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/83.0.4103.61 Safari/537.36" "<IP_ADDRESS>" <IP_ADDRESS> | - | <IP_ADDRESS> - - [23/Oct/2020:17:59:09 +0800] "GET /vendors.async.js HTTP/1.1"<PHONE_NUMBER> "http://<IP_ADDRESS>/monitor/services/list" "Mozilla/5.0 (Macintosh; Intel Mac OS X 10_13_6) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/83.0.4103.61 Safari/537.36" "<IP_ADDRESS>" <IP_ADDRESS> | - | <IP_ADDRESS> - - [23/Oct/2020:17:59:09 +0800] "GET /layouts__BasicLayout.chunk.css HTTP/1.1" 200 32170 "http://<IP_ADDRESS>/monitor/services/list" "Mozilla/5.0 (Macintosh; Intel Mac OS X 10_13_6) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/83.0.4103.61 Safari/537.36" "<IP_ADDRESS>"

Hi @yuanyiran . This is a duplicate of https://github.com/istio/istio/issues/27520, lets keep discussion there.Thanks.
See also https://istio.io/news/support/announcing-1.2-eol/


GPU not used for diffusion?

Noticed this message in the command prompt before diffusion steps:
Hardware accelerator e.g. GPU is available in the environment, but no 'device' argument is passed to the 'Pipeline' object. Model will be on CPU.
Is this normal? Shouldn't it be using the GPU for this? GPU usage was 0% during inference.

Any progress on this?

Nope. Gave up on it a while ago.


examples/edhoc-rs-no_std: wire up psa

This PR wires up the PSA backend to examples/edhoc-rs-no_std. (it's #28 rebased on main)
This is using a rust-psa-crypto fork, need to upstream needed no_std/baremetal patches. Also, the no_std fixes are hard-coded, so this breaks the psa std build
TODO:

[x] fix CI build (missing C cross compiler)
[x] clean up no_std patches to rust-psa-crypto
[x] fix linker error for baremetal target (missing free)
[x] fix missing entropy source in baremetal target
[x] fix linker error for baremetal target (missing calloc and strstr)
[x] build mbedtls with the static buffer allocator and initialize the allocator from Rust

I fixed the free linker error.
As expected, now mbedtls is missing an entropy source:
When doing cargo run --no-default-features --features psa in examples/edhoc-rs-no_std:
...
     Running `qemu-system-arm -cpu cortex-m3 -machine lm3s6965evb -nographic -semihosting-config enable=on,target=native -kernel /home/kaspar/src/edhoc-rs/target/thumbv7m-none-eabi/debug/edhoc-rs-no_std`
Timer with period zero, disabling
Hello, hacspec!
panicked at 'called `Result::unwrap()` on an `Err` value: InsufficientEntropy', crypto/edhoc-crypto-psa/src/lib.rs:16:24

Info on how to add a source for mbedtls in C is straight forward, but not so much going through rust-psa-crypto -> rust-psa-crypto-sys -> mbedtls. :(

Two commits pushed:
First one fixes the missing entropy source issue by:

defining our own mbedtls_hardware_poll function in psa crypto library, and
configuring mbedtls for crypto_baremetal build with MBEDTLS_ENTROPY_HARDWARE_ALT define, now in the baremetal branch on my fork of mbedtls.

The second commit adds a full handshake test which unfortunately fails to link with the following output:
 = note: rust-lld: warning: section type mismatch for .got
          >>> <internal>:(.got): SHT_PROGBITS
          >>> output section .got: SHT_NOBITS

          rust-lld: warning: section type mismatch for .got.plt
          >>> <internal>:(.got.plt): SHT_PROGBITS
          >>> output section .got: SHT_NOBITS

          rust-lld: warning: section type mismatch for .got
          >>> <internal>:(.got): SHT_PROGBITS
          >>> output section .got: SHT_NOBITS

          rust-lld: error: undefined symbol: calloc
          >>> referenced by platform.c
          >>>               platform.c.obj:(mbedtls_calloc_func) in archive /Users/malishav/Software/edhoc-rs/target/thumbv7m-none-eabi/debug/deps/libpsa_crypto_sys-a033baa857b1b4c9.rlib
          >>> did you mean: malloc
          >>> defined in: /Users/malishav/Software/edhoc-rs/target/thumbv7m-none-eabi/debug/deps/edhoc_rs_no_std-8b0cfcca31d2f4f7.8qrvu5iabanhtea.rcgu.o

          rust-lld: error: undefined symbol: strstr
          >>> referenced by pem.c:246 (/Users/malishav/.cargo/git/checkouts/rust-psa-crypto-e072e91dbdaa7d8f/efd8cf4/psa-crypto-sys/vendor/library/pem.c:246)
          >>>               pem.c.obj:(mbedtls_pem_read_buffer) in archive /Users/malishav/Software/edhoc-rs/target/thumbv7m-none-eabi/debug/deps/libpsa_crypto_sys-a033baa857b1b4c9.rlib
          >>> referenced by pem.c:251 (/Users/malishav/.cargo/git/checkouts/rust-psa-crypto-e072e91dbdaa7d8f/efd8cf4/psa-crypto-sys/vendor/library/pem.c:251)
          >>>               pem.c.obj:(mbedtls_pem_read_buffer) in archive /Users/malishav/Software/edhoc-rs/target/thumbv7m-none-eabi/debug/deps/libpsa_crypto_sys-a033baa857b1b4c9.rlib

          rust-lld: error: undefined symbol: mbedtls_psa_platform_get_builtin_key
          >>> referenced by psa_crypto_slot_management.c:295 (/Users/malishav/.cargo/git/checkouts/rust-psa-crypto-e072e91dbdaa7d8f/efd8cf4/psa-crypto-sys/vendor/library/psa_crypto_slot_management.c:295)
          >>>               psa_crypto_slot_management.c.obj:(psa_load_builtin_key_into_slot) in archive /Users/malishav/Software/edhoc-rs/target/thumbv7m-none-eabi/debug/deps/libpsa_crypto_sys-a033baa857b1b4c9.rlib

          rust-lld: error: section '.text' will not fit in region 'FLASH': overflowed by 74 bytes
          rust-lld: error: section '.text' will not fit in region 'FLASH': overflowed by 268 bytes
          rust-lld: error: section '.text' will not fit in region 'FLASH': overflowed by 462 bytes
          rust-lld: error: section '.text' will not fit in region 'FLASH': overflowed by 476 bytes
          rust-lld: error: section '.text' will not fit in region 'FLASH': overflowed by 490 bytes
          rust-lld: error: section '.text' will not fit in region 'FLASH': overflowed by 534 bytes
          rust-lld: error: section '.text' will not fit in region 'FLASH': overflowed by 578 bytes
          rust-lld: error: section '.text' will not fit in region 'FLASH': overflowed by 628 bytes
          rust-lld: error: section '.text' will not fit in region 'FLASH': overflowed by 678 bytes
          rust-lld: error: section '.text' will not fit in region 'FLASH': overflowed by 708 bytes
          rust-lld: error: section '.text' will not fit in region 'FLASH': overflowed by 738 bytes
          rust-lld: error: section '.text' will not fit in region 'FLASH': overflowed by 768 bytes
          rust-lld: error: section '.text' will not fit in region 'FLASH': overflowed by 798 bytes
          rust-lld: error: section '.text' will not fit in region 'FLASH': overflowed by 828 bytes
          rust-lld: error: section '.text' will not fit in region 'FLASH': overflowed by 858 bytes
          rust-lld: error: section '.text' will not fit in region 'FLASH': overflowed by 888 bytes
          rust-lld: error: section '.text' will not fit in region 'FLASH': overflowed by 918 bytes
          rust-lld: error: too many errors emitted, stopping now (use --error-limit=0 to see all errors)

Hooray! I got the full handshake to work on thumbv7m-none-eabi target and the test passes when executed in the QEMU simulator using: cargo run --no-default-features --features psa --release!
Note the usage of the --release flag. Without it, the linker fails due to the lack of flash memory (the linker is configured with 256K limit for flash!?). However, when a similar example is built for CC2538 (changes in a separate branch), without the --release flag, things run smoothly in 512K.
To get this to work, I had to:

Change Rust's global memory allocator from static-alloc to embedded-alloc, and allocate 1024 Bytes for heap. With static-alloc no matter the size of the buffer I tried, panic is thrown as hacspec fails to allocate internal arrays.
Configure mbedtls to use the buffer allocator (MBEDTLS_MEMORY_BUFFER_ALLOC_C) and to call the appropriate C init function (mbedtls_memory_buffer_alloc_init) from Rust with an array of size 8192 Bytes.

@kaspar030 let me know if you see any showstopper to merging this PR, otherwise feel free to remove the Draft status so that we go ahead with the merge!

Hooray! I got the full handshake to work on thumbv7m-none-eabi target and the test passes when executed in the QEMU simulator using: cargo run --no-default-features --features psa --release!

Awesome!

Without it, the linker fails due to the lack of flash memory (the linker is configured with 256K limit for flash!?).

Yup, the emulated board only has that much configured. IIUC that's hard-coded in the QEMU sources for that particular emulated SoC (lm3s6965evb). There's probably some other board with more flash.
I've tried to just do 'RUSTFLAGS=-Copt-level=s', but that hard-faults unfortunately.

Yep, there isn't much we can do about the memory footprint at this point as it is due to mbedtls and the hacspec dependencies. Proceeding with merge here


Updates to Server Versions

Page mentions server 2016 but I believe should include Server 2019 as well

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 90e335dd-0bc5-a7e3-650b-e3dd1823176b
Version Independent ID: 18f34ef3-ff61-0473-a64b-ac5a64dbe1d7
Content: Azure Hybrid Benefit for Windows Server
Content Source: WindowsServerDocs/get-started/azure-hybrid-benefit.md
Product: windows-server
Technology: server-general
GitHub Login: @greg-lindsay
Microsoft Alias: greg-lindsay

This needs to be assigned to the topic owner, which is not me. I don't have permission to assign.

( also ref. issue ticket #488 from the same page, needs an update )

Thanks for the feedback. This article has been updated.
#please-close


Document parameter-only application upgrade

I recently learned application-level parameters can be upgraded without updating any versions in the app/service manifest or service packages (see this issue). This is both very useful and also not common knowledge - can you add it to the docs? I think this article makes sense as a home for the info since I see this technique as a way to tweak settings for an individual customer's deployment.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: a7156ca7-d9f0-0ba1-aabe-8e585f157b90
Version Independent ID: b21c5989-72b4-4c78-2699-3e6646e2a793
Content: Manage applications for multiple environments in Azure Service Fabric
Content Source: articles/service-fabric/service-fabric-manage-multiple-environment-app-configuration.md
Service: service-fabric
GitHub Login: @MikkelHegn
Microsoft Alias: mikhegn

Thanks for the feedback! We are currently investigating and will update you shortly.

@MikkelHegn Can you please review this suggestion for doc enhancement by customer and share your insights. Thanks :)

@MikkelHegn Did you get a chance to review the customer's suggestion? Thanks. :)

Thanks @Nickomang ! #please-close

For completeness, commit #9521370 fulfilled this request. The information was added to Service Fabric application upgrade: advanced topics


HARP-7373: Cache world coordinates in TextElement.

Signed-off-by: Andres Mandado<EMAIL_ADDRESS>Thank you for contributing to harp.gl!
Before requesting a pull request, please remember to check the following documents:

contribution guidelines
coding style

If you are adding new functionality we would highly appreciate if you can describe what is the capability you are adding and even better if you can add some examples. Please also remember to add tests for it.
CI Check
Our bots will check whether your PR can be directly integrated into the mainline. We have some internal integration tests running on the background, our bots will inform you of the next steps and someone from our team will take a look and help if needed!
And please do not forget to sign-off your commit! You can read more about DCO here. But, in short, you just need to use git commit -s or append --signoff when you are committing to the repo.
Happy contributing!

Codecov Report

Merging #1072 into master will decrease coverage by <.01%.
The diff coverage is 12.19%.

@@            Coverage Diff             @@
##           master    #1072      +/-   ##
==========================================
- Coverage   45.86%   45.85%   -0.01%
==========================================
  Files         238      238
  Lines       22174    22177       +3
  Branches     4983     4984       +1
==========================================
  Hits        10170    10170
- Misses      12004    12007       +3

Impacted Files
Coverage Δ

...here/harp-mapview/lib/text/TextElementsRenderer.ts
9.53% <0%> (+0.02%)
:arrow_up:

...ere/harp-mapview/lib/text/TextElementStateCache.ts
8.1% <0%> (+0.21%)
:arrow_up:

...re/harp-mapview/lib/geometry/overlayOnElevation.ts
4.91% <0%> (-3.28%)
:arrow_down:

@here/harp-mapview/lib/text/TextElement.ts
35.71% <18.18%> (-3.48%)
:arrow_down:

@here/harp-mapview/lib/text/Placement.ts
30% <21.42%> (+3.58%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 894f8ba...ecf8455. Read the comment docs.

@heremaps-bot retest this please


extract .toJSON() to request-base

This API is now present in both node and the browser.
It was node-only prior to this.
Docs improved and unit tests moved so it runs in node and browser.
Part of #830

:+1:

Thanks for doing this!


Training 🚂

This adds a train option to cog.yaml and a cog train command to run it.
There are a few bits of refactoring to make this possible, contained in some significant commits. Notably, predictors can now just be functions if you have no setup().
How it works
cog.yaml:
build:
  python_version: "3.10"
train: "train.py:train"

train.py:
from cog import BasePredictor, File
import io

def train(param: str) -> File:
    return io.StringIO("hello " + param)

Then you can run it like this:
$ cog train -i param=train
...

$ cat weights
hello train

API
The HTTP server can be booted up in two different modes, specified with the --x-mode argument: predict and train.
In predict mode, it behaves like it did before.
In train mode, if you call POST /predictions it actually runs the thing specified by train in cog.yaml.
Notes

The way the API works is obviously... suboptimal. Ideally we'd have something like a separate /trainings endpoint and both predictions and trainings can be run when the container is booted up.

Unfortunately this is fiddly, so I opted to not do it this way. For example, Predictor.setup() gets called on boot, but we don't want to do that if we're training. Also, the worker would require a lot of rewiring to support both things.
So – I opted for a bodge where the HTTP server can be booted up in either prediction or training mode, and in training mode POST /predictions does a training (bleurgh).
This should probably be tidied up at some point but this will get us going.

Weights need to be loaded in setup() somehow. This is not done yet, and I have a half-working version locally.
We probably want to support directories as Path, because this is often the format that weights are in. Perhaps we can add support in Cog to turn a Path that points to a directory into a tarball, which is a common pattern (e.g. zip files in DreamBooth).
We probably want to pass the weights as an input to the trainer to use as the base weights.
cog train passes around files with data URLs, which ain't going to scale. We probably want to use file:// and store it on the shared Docker volume.
There aren't any schemas! The model will have to boot up to get validation errors, we can't generate GUIs, etc.

I have pushed a commit that attempts to read weights from the COG_WEIGHTS environment variable and passes it to setup(), but you can't seem to read environment variables from within the worker (both from the tests and running the fixture manually). Maybe somebody who knows more about how the worker works can figure this out.

@nickstenning  / @andreasjansson I think we should re-write the URLs before downloading (either in COG or replicate API)
It is 5x faster to download from GCS directly than to stream through the replicate.delivery CDN
15:     if strings.HasPrefix(url, "https://replicate.delivery/pbxt/") {
16:             url = strings.Replace(url, "https://replicate.delivery/pbxt/", "https://storage.googleapis.com/replicate-files/", 1)

It is 5x faster to download from GCS directly than to stream through the replicate.delivery CDN

Interesting! If you get a chance could you test that with the new CDN URLs? https://pbxt.replicate.delivery/ rather than https://replicate.delivery/pbxt/.

I'm going to merge and deploy this. There are some known things we want to change (e.g. booting models in "training mode"), but it holds together enough that we can test with actual models in production. I have tested a few existing deployments by manually pointing to this branch, and it works.


Automator: update<EMAIL_ADDRESS>in<EMAIL_ADDRESS>

Generated by Automator - 2023-10-11T00:46:08+00:00

@istio-testing: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

integ-pilot-istiodremote_istio_release-1.19
63c12e0c5859ee99ed472c673ee9e1ca9e161371
link
true
/test integ-pilot-istiodremote

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.


Update zio, zio-test, zio-test-sbt to 1.0.16

Updates

dev.zio:zio
dev.zio:zio-test
dev.zio:zio-test-sbt

from 1.0.15 to 1.0.16.
GitHub Release Notes - Version Diff
I'll automatically update this PR to resolve conflicts as long as you don't change it yourself.
If you'd like to skip this version, you can just close this PR. If you have any feedback, just mention me in the comments below.
Configure Scala Steward for your repository with a .scala-steward.conf file.
Have a fantastic day writing Scala!

Adjust future updates
Add this to your .scala-steward.conf file to ignore future updates of this dependency:
updates.ignore = [ { groupId = "dev.zio" } ]

Or, add this to slow down future updates of this dependency:
dependencyOverrides = [{
  pullRequests = { frequency = "@monthly" },
  dependency = { groupId = "dev.zio" }
}]

labels: library-update, early-semver-patch, semver-spec-patch, commit-count:1

Codecov Report

Merging #1987 (9f836d3) into unstable (bda1814) will increase coverage by 0.00%.
The diff coverage is n/a.

@@            Coverage Diff            @@
##           unstable    #1987   +/-   ##
=========================================
  Coverage     77.81%   77.82%
=========================================
  Files           418      418
  Lines         12789    12789
  Branches        566      566
=========================================
+ Hits           9952     9953    +1
+ Misses         2837     2836    -1

Impacted Files
Coverage Δ

.../forsyte/apalache/tla/pp/ConstSimplifierBase.scala
97.64% <0.00%> (+1.17%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bda1814...9f836d3. Read the comment docs.


[BUG] Reviewing A Note Buries Flashcards

If a new flashcard is created in a note, and that note is subsequently reviewed via spaced repetition before the flashcard is viewed, the flashcard will no longer be accessible from the deck menu.
Steps to Reproduce

Add the "#test" tag to both note and flashcard review lists.
Create the following note:

---
aliases:
tags: test
---

# Test

Flashcard: ==answer==

Note that in the flashcards review menu, the test flashcard is available for review.
Review the note as easy/good/hard.
Note that the flashcard is no longer accessible, but is still "there". Likely buried or simply marked as reviewed internally?

Expected behavior
Flashcard to still be accessible after reviewing the note.
Screenshots
Pre-review

Post-review

Versions

OS: Bedrock (Arch) Linux
Obsidian version: v1.4.16
Plugin version: v1.10.4
Installer version: 5.0 (X11; Linux x86_64) AppleWebKit/537.36 (KHTML, like Gecko) obsidian/1.4.16 Chrome/114.0.5735.289 Electron/25.9.4 Safari/537.36

Additional Context
Flashcard disappearance is similar in behaviour to #734, but in this case has a traceable cause.

Hi  @LennyPhoenix sorry there is another bug, don't know if it's my doing or not, but will look into it.
Thanks for the screenshots, is it possible to do a video screen capture of the sequence?
Regarding:
Add the "#test" tag to both note and flashcard review lists.
I notice that there is a space character between the  # and the  Test in:
# Test
Was that the intention?
Best to send me the actual Markdown file at the start of the sequence, together with the video capture.
Cheers
Ronny

Hey @ronzulu,
Thanks for the quick response! I don't believe this is your doing, but thanks for looking into it :)
Attached is a video capture of the replication process.
Note that # Test is simply a header for the file, and is not relevant to the bug. The actual tag is added to the file's frontmatter: tags: test
Here is the original markdown file at the start of the sequence:
---
aliases:
tags: test
---

# Test

Flashcard: ==Answer==

https://github.com/st3v3nmw/obsidian-spaced-repetition/assets/57148878/90a56118-0e7f-40a2-b24b-34ea4947cd56
(Apologies for the poor audio quality)

Hi  @LennyPhoenix
Thanks for that, that's great.
I can reproduce the issue, so should be able to fix.
Cheers
Ronny

Hi  @LennyPhoenix
I've just tested and looked at the code, and can confirm this behaviour is consistent with version 1.10.1 (i.e. before the changes I made).
The code explicitly does this if the "bury siblings" setting is switched on.
When a note is reviewed, and bury siblings is switched on, all cards within the note are buried. They therefore won't show up in the flashcard tree as you have pointed out. And they will only reappear the following day.
I can see that some people may like this behaviour, but having it enabled by "bury siblings" is very nonintuitive.
Do you need the "bury siblings" option turned on, or are you okay to disable it?
If you do need it, then I think the way forward would be to have a separate setting for this, defaulting to the current setting of "bury siblings". Something like "After reviewing a note, postpone all flashcards till after today"
What do you think?
Cheers
Ronny

I do need bury siblings enabled due to the way my flashcards are structured.
I agree, it is unintuitive to me that note review behaviour should be affected by a flashcard related setting. A new setting would definitely be better.
Thanks again for your help!

If anyone else comes across this, there is now a version with this fixed and available for beta testing.
See https://github.com/st3v3nmw/obsidian-spaced-repetition/issues/791#issuecomment-1897810606


Make apps more composable.

Specifically, I'd often want to create stepwise protocols that basically just call two or three other protocols.  The question is how to configure those "contained" protocols.  From python it's not an issue, since I can just access attributes like so: parent.child.param.  But I'm not sure how to handle command-line options, config files, etc.
In this example, the child apps would be fully-functional apps in their own right, capable of parsing their own command lines and everything.  These apps would also have no knowledge of the parent app.  The parent may want to change argument names/config file keys/etc., and perhaps everything about how the value is loaded.
I guess one way to do this is just to have the parent make subclasses of any child it wants to use, and the subclasses can change how the various parameters are loaded, e.g.:
class Parent(byoc.App):

    class Child:
        x = param('X')

    def __bareinit__(self):
        self.child = self.Child.from_bare()
        byoc.replace_configs(self, self.child)  # This doesn't exist yet...

        # Might also be nice to make a helper for the above two lines:
        # self.child = byoc.make_child_app(self, self.Child)
        # self.child = self.Child.from_parent(self)

class Child(byoc.App):
    x = param('x')

It's actually kind of hard to imagine a better syntax than this.  Users can still provide instances of the original child class and they will work flawlessly.    By default all configs are loaded in the same way as in the child app, but anything can be changed.  It might be nice to add an easy way to say "use a different command-line argument for this parameter, but do everything else the same".  Maybe an Inherit getter, or something like inherited_param(keep=[], drop=[], append=[], prepend=[], insert={}, replace={}).
Now that I've written this all down, I think the existing syntax handles the "composing apps" use-case pretty well.  I'll still submit this issue, as a reminder to add the various helpers discussed above, and to remind myself how to do this.

Related idea: Make it easier to a parent app to control which configs child apps use.  Specifically, imagine a child app that uses DocoptConfig for processing command-line arguments.  The parent might want to expose some of those arguments (perhaps with different names), but doesn't want to explicitly forbid all the others.  What I have in mind is:

The parent makes and uses a new DocoptConfig subclass for command-line processing.
The new config is somehow programmed so that Key getters looking for DocoptConfig will not consider it a match.
Therefore none of the existing child params will load values from the command-line at all, unless those params are replaced by ones that know about the new config class.

This requires giving the config classes some degree of control over how Key works.  The most powerful way to do this would be to add a Config.is_match(key, log) method that does whatever it wants to decide how a key should be interpreted.  I'm a little worried that this could be too powerful, though...


String Maximum -> maxLength

According to this standard http://json-schema.org/latest/json-schema-validation.html#anchor26
strings should be limited with maxLength and minLength as opposed to minimum and maximum

👍 thanks!

Should be in next version v7.0.0 our in next couple of days. Thanks for point this out, was not very clear in swagger spec. Shame it not used by SwaggerUI to limit input

Hey @glennjones any update on that release?

Sorry. I am still working on a painful reorganisation of the plugins code to improve its JSON output. Its one of those times you pull at a small issue and before you know it your having to rebuild some of the code base. If I had known how much time was needed for the JSON output issue I would of setup the releases differently.
I am hoping to get v7 in the next couple of days, but its already taken much longer than I thought and I cannot guarantee it, day job comes first.

Oh hey, no worries.  Didn't realize there was still on-going work.  Thought the release was already ready.  My bad.


Removing instantiation using reflection for known types for query response

RxDocumentServiceResponse#getQueryResponse reads every item in the query response into a Document and uses reflection to achieve the same. As the page sizes increases it would result in more reflection calls.
The throughput of constructing an object with and without reflection could be seen in the jmh perf results below where not using reflection gave around 100x more throughput.

Benchmark
Mode
Cnt
Score
Error
Units

NoReflection
thrpt
5
3667801375.698
± 476832257.441
ops/s

Reflection
thrpt
5
33498594.319
±   6746647.211
ops/s

This PR tries to remove the reflective construction and creates the types directly using specific constructor. This should translate into some perf gains on query times on the client depending on page size

/azp run java - cosmos - tests


Add fullscreen polyfill to dart2js

This issue was originally filed by @pjako

Currently you can't get fullscreen to work in firefox, with a polyfill we could fix this.
See:
https://github.com/neovov/Fullscreen-API-Polyfill

This might still be relevant.

Please, provide a polyfill to support by dart2js.

It's been five years and yet still in 2017 attempting to call the requestFullscreen() function on an html element in dart code results in a NoSuchMethodError in Chrome.
Why not just remove the functions from dart:html if they can't be provided? It seems worse to provide implementations that don't work because the library is actively advertising functionality it can't provide.

Totally agree, @ajrcarey. We're in the middle of a very deliberate refactoring of Dart tools towards v2 – see here http://news.dartlang.org/2017/06/a-stronger-dart-for-everyone.html
There are a number of APIs in dart:html that need to be fixed/removed. We haven't lost track of these...
Thanks for your patience...

At least have the honesty to resolve with "Won't fix" rather than marking as stale.

There are no plans to add additional polyfills to Dart2JS.

Not a polyfill, but as far as working in Chrome that looks like #21919


Understanding CodeGen generated classes against BPMN Model - Node Numbers vs TaskName value

Description
Consider the following:

Implementation ideas
Related to to issues in: https://github.com/kiegroup/kogito-runtimes/issues/1900
The naming of the files is generated based on Node numbers (which comes form where? Can i control this?)
Given that TaskName will be unique could generated classes have the TaskName instead of node number?

Yes, once the task name is unique, the node number is not longed needed


Unable to pass in Enum to get_market_hours in rest/market_hours.py

This code outside the market_hours file works as expected, we get the enum replaced with its value.
class Markets(Enum):
    """Represents the different markets you can request
    hours for the `MarketHours` service.

    ### Usage
    ----
        >>> from td.enums import Markets
        >>> Markets.Bond.Value
    """

    Bond = 'BOND'
    Equity = 'EQUITY'
    Option = 'OPTION'
    Forex = 'FOREX'
    Futures = 'FUTURES'

def get_market_hours(market):
    from enum import Enum
    if isinstance(market, Enum):
        market = market.value
    content = f"marketdata/{market}/hours"
    return content

print(get_market_hours(Markets.Bond))

However, this code doesn't work:
    def get_market_hours(
        self,
        market: Union[str, Enum],
        date_time: Union[str, datetime] = None
    ) -> dict:
        """Returns the market hours for the specified market.

        ### Documentation
        ----
        https://developer.tdameritrade.com/market-hours/apis

        ### Parameters
        ----
        market: Union[str, Enum]
            A list of market IDs you want to return hours for.
            Possible values are: `EQUITY`, `OPTION`, `FUTURE`,
            `BOND`, or `FOREX`.

        date: Union[str, datetime, date]
            The date you wish to recieve market hours for.
            Valid ISO-8601 formats are: yyyy-MM-dd and
            yyyy-MM-dd'T'HH:mm:ssz

        ### Usage
        ----
            >>> from td.enums import Markets
            >>> market_hours_service = td_client.market_hours()
            >>> market_hours_service.get_market_hours(
                markets='EQUITY',
                date='2021-12-31'
            )
        """
        if isinstance(market, Enum):
            market = market.value

        # Grab the date_time.
        if isinstance(date_time, datetime):
            date_time = date_time.date().isoformat()
        elif isinstance(date_time, date):
            date_time = date_time.isoformat()

        params = {
            'date': date_time
        }

        content = self.session.make_request(
            method='get',
            endpoint=f'marketdata/{market}/hours',
            params=params
        )

        return content

called with
# Grab the hours for a specific market.
pprint(
    market_hours_service.get_market_hours(
        market=Markets.Bond,
        date_time=datetime.now()
    )
)

an http error is thrown. logging shows:
"response_body": {
    "timestamp": "2021-10-23",
    "status": 400,
    "error": "Bad Request",
    "message": "Market name not recognized",
    "path": "/markethours-v1/markets/Markets.Bond"
},

Not sure of the issue. Usage of isinstance to cast enum is similar to other code and to the other market_hours method, get_multiple_market_hours, which works fine.

Whatever it was is fixed now. I copied the current use_market_hours.py that I just pushed into a jupyter notebook and it worked fine.


chore: add package-manager metadata and lockfile

Checking in lockfile for supply-chain security and auditability aspects.
And why don't we try out yet another package manager?! :man_dancing:

@LavaMoat/devs Ping. Reviews not enabled for me on this repo :sweat_smile:

@legobeat, I wasn't able to work with this locally, could use your help.
Some of the things I encountered:
First of all, after (successfully?) installing everything via pnpm install, when running pnpm run build inside packages/core/ you get Usage Error: Invalid package manager specification in package.json; expected a semver version
So I change the version from 9 to 9.1.3 and then I get: sh: webpack: command not found
Not sure why this course of action avoids installing webpack globally for me, but doing so on main doesn't result to this.
Am I missing something? Did this work for you locally?

Oops my bad, webpack being global on my machine makes sense.
Looks better, but running pnpm run dev under packages/react/ seems to throw whereas using npm for that task seems to work just fine - any idea as for why is that?

Looks good. Moving away from pnpm also means pnpm-lock.yaml should be removed @legobeat ?

wait why are we uploading package-lock.json though?