Add Bosch Compress 7001i device with code 172

I'm not 100% sure if I'm doing this right, so please help me out if this doesn't make sense 🙂
I have a Bosch Compress 7001i heat pump, and I have successfully used e.g. regofetcher to read data from it. I stepped through the code in the debugger, and noticed that bosch_thermostat_client/gateway/ivt_gateway.py and the get_device_model method didn't return anything. This PR adds the device code. It may very well be that mapping it to rc300.json is not the right thing to do here, but I'm not really sure how to proceed here, so any pointers would be appreciated.

I have managed to run bosch_rawscan_cli.py and got a rawscan_XXXX.json dump out of it. How are the bosch_termostat_client/db/*.json files maintained? Are they generated by some kind of script? Or manually? I tried looking for a script but couldn't find anything.

rawscan.txt

I have looked through the existing DB JSON files, but there are still many parts I don't understand. I went ahead and added a new one for my device type anyway, but any guidance here would be greatly appreciated.

@pszafer what about all the entries in the DB file? I'm pretty sure that not all of them are relevant. Do you have any pointers?

it looks good to me, but to be sure I'll test it tomorrow with your rawscan. if it will work I'll merge it.


About required environment variables

Hi! Thank you for this incredible work! I'd like to clarify the proper method of setting up the necessary environment variables according to your README documentation located here: https://github.com/autonomousvision/navsim/blob/main/docs/install.md#2-install-the-navsim-devkit.
After following your guide to prepare the dataset and code, I have reached the stage where I need to define the paths for the environment variables. However, I am uncertain about the specific directories to use for each of the following:
export NAVSIM_DEVKIT_ROOT=/path/to/navsim/devkit  # Should this be the path to the root directory of my navsim installation?
export NUPLAN_EXP_ROOT=/path/to/navsim/exp # Is this the path pointing to the 'navsim_logs' folder that I've downloaded?
export NUPLAN_MAPS_ROOT=/path/to/nuplan/maps # The path to the downloaded 'nuplan-maps-v1.0' folder?
export OPENSCENE_DATA_ROOT=/path/to/openscene # Do I need to acquire a separate dataset specifically for this variable?

Your guidance in specifying these paths would be greatly appreciated!

Hi @SizheWei,
The environment variables depend on where the dataset etc. are located.
In the following, I will assume your folder structure is as follows:
~/navsim_workspace
├── navsim (containing the devkit)
├── exp
└── dataset
    ├── maps
    ├── navsim_logs
    │    ├── mini
    │    └── trainval
    └── sensor_blobs
         ├── mini
         └── trainval

In the current version you only need to set the following environment variables:
export NUPLAN_MAPS_ROOT="$HOME/navsim_workspace/dataset/maps"
export NUPLAN_EXP_ROOT="$HOME/navsim_workspace/exp"
export NAVSIM_DEVKIT_ROOT="$HOME/navsim_workspace/navsim"
export OPENSCENE_DATA_ROOT="$HOME/navsim_workspace/dataset"

In the current version, you also need to directly set  LOG_PATH=~/navsim_workspace/dataset/navsim_logs/mini or LOG_PATH=~/navsim_workspace/dataset/navsim_logs/trainval in the scripts for metric caching and running the pdm-scoring.
You will find the metric cache in "~/navsim_workspace/exp/metric_cache" after running the script. Thus, when running the pdm-scoring, you can set METRIC_CACHE_PATH=~/navsim_workspace/exp/metric_cache here
We will soon update our installation instructions to make this clearer.
Thank you for pointing this out.
Let me know if you have further questions!

Thanks @mh0797 ! I got it now!


Issue with white space | ts-criteria

This is my element {{organic['Average vol.']}}
I've tried:
ts-criteria="['Average vol.']|parseInt"
ts-criteria="'Average vol.'|parseInt"
ts-criteria="Average|parseInt"
but it doesn't work

Can you provide a more full code example for this?  A sample of your data structure and the table code.

I guess it's never too late to reply?
https://code.angularjs.org/1.8.0/docs/error/$parse/syntax?p0=term&p1=is an unexpected token&p2=8&p3=Search term&p4=term
rows = [{'Search term': 'test'}]

          Search term

          <input type="checkbox" ng-model="row.selected" />
          {{row['Search term']}}

Well, it's been a few years since I last used this but I'm pretty sure your property names can't contain whitespace like this. But you probably already know this since you're getting errors about exactly that.
I don't know what your data looks like, but your property name on the object should be what you are putting into the tableSort properties. Not the English text label.
Here's my suggested rewrite/example for you. Keep in mind this is untested and going off of my memory of how this works from years ago!
var rows = [
  {selected: false, searchTerm: "apple"},
  {selected: false, searchTerm: "mango"},
  {selected: false, searchTerm: "watermelon"}
];

          Search Term

          <input type="checkbox" ng-model="row.selected" />
          {{row.searchTerm}}

Perhaps you have data coming from the server with whitespace already in the JSON keys? If so you'll need to replace them with an underscore or something since this plugin can't handle whitespace.


Chromium 86 supports Native Filesystem API

Chromium has landed support for the native filesystem API in v86, significantly closing the gap between native and web capabilities on the desktop 🥳
In trying not to fly too close to the sun, they have decided to only roll out some functionality, and then add to it in waves. Because of that, i have marked it as partial support, and will add more specifics as new functions come out.
This is the samme approach as WebXR, which is probably due for an update pretty soon :)
I have verified basic support in Chrome 86 with the Caniuse test and this cool demo. You can also check:
https://chromestatus.com/feature/6284708426022912
https://groups.google.com/a/chromium.org/g/blink-dev/c/9Fcpl2KVfbk/m/d9VN0Fz8BwAJ

Thanks!


iptables nat rule prevents iptables-restore from working

I'm running on Ubuntu 14.04. I've got my attributes/recipe set up like this:
default['firewall']['ubuntu_iptables'] = true
default['firewall']['iptables']['defaults']['policy']['input'] = 'ACCEPT'

firewall 'default'

firewall_rule 'nat rule' do
	command :masquerade
	dest_interface 'eth0'
	direction :post
	protocol :none
	source '<IP_ADDRESS>/24'
end

Unfortunately this doesn't work. I get this in the Chef run:
* service[iptables-persistent] action restart

  ================================================================================
  Error executing action `restart` on resource 'service[iptables-persistent]'
  ================================================================================

  Mixlib::ShellOut::ShellCommandFailed
  ------------------------------------
  Expected process to exit with [0], but received '1'
  ---- Begin output of /etc/init.d/iptables-persistent start ----
  STDOUT: * Loading iptables rules...
   *  IPv4...
   *  IPv6...
     ...fail!
  STDERR:
  ---- End output of /etc/init.d/iptables-persistent start ----
  Ran /etc/init.d/iptables-persistent start returned 1

  Resource Declaration:
  ---------------------
  # In /var/chef/cache/cookbooks/firewall/libraries/provider_firewall_iptables_ubuntu.rb

  113:         service_affected = service 'iptables-persistent' do
  114:           action :nothing
  115:         end
  116:

  Compiled Resource:
  ------------------
  # Declared in /var/chef/cache/cookbooks/firewall/libraries/provider_firewall_iptables_ubuntu.rb:113:in `block (2 levels) in <css:FirewallIptablesUbuntu>'

  service("iptables-persistent") do
    action [:nothing]
    updated true
    supports {:restart=>nil, :reload=>nil, :status=>nil}
    retries 0
    retry_delay 2
    default_guard_interpreter :default
    service_name "iptables-persistent"
    enabled true
    running true
    pattern "iptables-persistent"
    declared_type :service
    cookbook_name "xxx"
  end

In trying to debug this, I tried running iptables-restore on /etc/iptables/rules.v4 and got this:
root@ec2-instance:~# iptables-restore < /etc/iptables/rules.v4
iptables-restore v1.4.21: The -t option (seen in line 10) cannot be used in iptables-restore.

Error occurred at line: 10
Try `iptables-restore -h' or 'iptables-restore --help' for more information.

It seems we can't put rules with -t nat in there.

Hi there -- we've documented it in #101, but this cookbook doesn't support chains other than *filter currently. I'd love to see this fixed, but it will likely require some refactoring. I'd be glad to review any PRs that resolve it, though. Thank you for the report!


Fix constants variable name

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Comment

0
reexec
39
Docker mode activated.

_ Prechecks _

+1
dupname
0
No case conflicting files found.

+1
@author
0
The patch does not contain any @author tags.

-1
test4tests
0
The patch doesn't appear to include any new or modified tests.  Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.

_ trunk Compile Tests _

+1
mvninstall
1053
trunk passed

+1
compile
1073
trunk passed

+1
checkstyle
38
trunk passed

+1
mvnsite
70
trunk passed

+1
shadedclient
731
branch has no errors when building and testing our client artifacts.

+1
javadoc
59
trunk passed

0
spotbugs
124
Used deprecated FindBugs config; considering switching to SpotBugs.

+1
findbugs
122
trunk passed

_ Patch Compile Tests _

-1
mvninstall
26
hadoop-common in the patch failed.

-1
compile
46
root in the patch failed.

-1
javac
46
root in the patch failed.

+1
checkstyle
28
hadoop-common-project/hadoop-common: The patch generated 0 new + 13 unchanged - 1 fixed = 13 total (was 14)

-1
mvnsite
29
hadoop-common in the patch failed.

+1
whitespace
0
The patch has no whitespace issues.

-1
shadedclient
32
patch has errors when building and testing our client artifacts.

+1
javadoc
46
the patch passed

-1
findbugs
27
hadoop-common in the patch failed.

_ Other Tests _

-1
unit
28
hadoop-common in the patch failed.

+1
asflicense
21
The patch does not generate ASF License warnings.

3492

Subsystem
Report/Notes

Docker
Client=18.09.8 Server=18.09.8 base: https://builds.apache.org/job/hadoop-multibranch/job/PR-296/1/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/296

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient findbugs checkstyle

uname
Linux 45956864a524 4.4.0-138-generic #164-Ubuntu SMP Tue Oct 2 17:16:02 UTC 2018 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
personality/hadoop.sh

git revision
trunk / 7f1b76c

Default Java
1.8.0_212

mvninstall
https://builds.apache.org/job/hadoop-multibranch/job/PR-296/1/artifact/out/patch-mvninstall-hadoop-common-project_hadoop-common.txt

compile
https://builds.apache.org/job/hadoop-multibranch/job/PR-296/1/artifact/out/patch-compile-root.txt

javac
https://builds.apache.org/job/hadoop-multibranch/job/PR-296/1/artifact/out/patch-compile-root.txt

mvnsite
https://builds.apache.org/job/hadoop-multibranch/job/PR-296/1/artifact/out/patch-mvnsite-hadoop-common-project_hadoop-common.txt

findbugs
https://builds.apache.org/job/hadoop-multibranch/job/PR-296/1/artifact/out/patch-findbugs-hadoop-common-project_hadoop-common.txt

unit
https://builds.apache.org/job/hadoop-multibranch/job/PR-296/1/artifact/out/patch-unit-hadoop-common-project_hadoop-common.txt

Test Results
https://builds.apache.org/job/hadoop-multibranch/job/PR-296/1/testReport/

Max. process+thread count
412 (vs. ulimit of 5500)

modules
C: hadoop-common-project/hadoop-common U: hadoop-common-project/hadoop-common

Console output
https://builds.apache.org/job/hadoop-multibranch/job/PR-296/1/console

versions
git=2.7.4 maven=3.3.9 findbugs=3.1.0-RC1

Powered by
Apache Yetus 0.10.0 http://yetus.apache.org

This message was automatically generated.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Comment

0
reexec
88
Docker mode activated.

_ Prechecks _

+1
dupname
0
No case conflicting files found.

+1
@author
0
The patch does not contain any @author tags.

-1
test4tests
0
The patch doesn't appear to include any new or modified tests.  Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.

_ trunk Compile Tests _

+1
mvninstall
1223
trunk passed

+1
compile
1181
trunk passed

+1
checkstyle
46
trunk passed

+1
mvnsite
94
trunk passed

+1
shadedclient
944
branch has no errors when building and testing our client artifacts.

+1
javadoc
75
trunk passed

0
spotbugs
144
Used deprecated FindBugs config; considering switching to SpotBugs.

+1
findbugs
142
trunk passed

_ Patch Compile Tests _

-1
mvninstall
31
hadoop-common in the patch failed.

-1
compile
55
root in the patch failed.

-1
javac
55
root in the patch failed.

+1
checkstyle
38
hadoop-common-project/hadoop-common: The patch generated 0 new + 13 unchanged - 1 fixed = 13 total (was 14)

-1
mvnsite
35
hadoop-common in the patch failed.

+1
whitespace
0
The patch has no whitespace issues.

-1
shadedclient
40
patch has errors when building and testing our client artifacts.

+1
javadoc
60
the patch passed

-1
findbugs
31
hadoop-common in the patch failed.

_ Other Tests _

-1
unit
35
hadoop-common in the patch failed.

+1
asflicense
26
The patch does not generate ASF License warnings.

4166

Subsystem
Report/Notes

Docker
Client=18.09.7 Server=18.09.7 base: https://builds.apache.org/job/hadoop-multibranch/job/PR-296/2/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/296

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient findbugs checkstyle

uname
Linux f1c1636333d1 4.15.0-52-generic #56-Ubuntu SMP Tue Jun 4 22:49:08 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
personality/hadoop.sh

git revision
trunk / ecc8acf

Default Java
1.8.0_212

mvninstall
https://builds.apache.org/job/hadoop-multibranch/job/PR-296/2/artifact/out/patch-mvninstall-hadoop-common-project_hadoop-common.txt

compile
https://builds.apache.org/job/hadoop-multibranch/job/PR-296/2/artifact/out/patch-compile-root.txt

javac
https://builds.apache.org/job/hadoop-multibranch/job/PR-296/2/artifact/out/patch-compile-root.txt

mvnsite
https://builds.apache.org/job/hadoop-multibranch/job/PR-296/2/artifact/out/patch-mvnsite-hadoop-common-project_hadoop-common.txt

findbugs
https://builds.apache.org/job/hadoop-multibranch/job/PR-296/2/artifact/out/patch-findbugs-hadoop-common-project_hadoop-common.txt

unit
https://builds.apache.org/job/hadoop-multibranch/job/PR-296/2/artifact/out/patch-unit-hadoop-common-project_hadoop-common.txt

Test Results
https://builds.apache.org/job/hadoop-multibranch/job/PR-296/2/testReport/

Max. process+thread count
292 (vs. ulimit of 5500)

modules
C: hadoop-common-project/hadoop-common U: hadoop-common-project/hadoop-common

Console output
https://builds.apache.org/job/hadoop-multibranch/job/PR-296/2/console

versions
git=2.7.4 maven=3.3.9 findbugs=3.1.0-RC1

Powered by
Apache Yetus 0.10.0 http://yetus.apache.org

This message was automatically generated.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Comment

0
reexec
46
Docker mode activated.

_ Prechecks _

+1
dupname
0
No case conflicting files found.

+1
@author
0
The patch does not contain any @author tags.

-1
test4tests
0
The patch doesn't appear to include any new or modified tests.  Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.

_ trunk Compile Tests _

+1
mvninstall
1070
trunk passed

+1
compile
1039
trunk passed

+1
checkstyle
41
trunk passed

+1
mvnsite
71
trunk passed

+1
shadedclient
786
branch has no errors when building and testing our client artifacts.

+1
javadoc
59
trunk passed

0
spotbugs
117
Used deprecated FindBugs config; considering switching to SpotBugs.

+1
findbugs
114
trunk passed

_ Patch Compile Tests _

-1
mvninstall
27
hadoop-common in the patch failed.

-1
compile
44
root in the patch failed.

-1
javac
44
root in the patch failed.

+1
checkstyle
30
hadoop-common-project/hadoop-common: The patch generated 0 new + 13 unchanged - 1 fixed = 13 total (was 14)

-1
mvnsite
28
hadoop-common in the patch failed.

+1
whitespace
0
The patch has no whitespace issues.

-1
shadedclient
36
patch has errors when building and testing our client artifacts.

+1
javadoc
51
the patch passed

-1
findbugs
30
hadoop-common in the patch failed.

_ Other Tests _

-1
unit
28
hadoop-common in the patch failed.

+1
asflicense
21
The patch does not generate ASF License warnings.

3555

Subsystem
Report/Notes

Docker
Client=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/hadoop-multibranch/job/PR-296/3/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/296

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient findbugs checkstyle

uname
Linux 7ad8118f807d 4.4.0-138-generic #164-Ubuntu SMP Tue Oct 2 17:16:02 UTC 2018 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
personality/hadoop.sh

git revision
trunk / e872ceb

Default Java
1.8.0_212

mvninstall
https://builds.apache.org/job/hadoop-multibranch/job/PR-296/3/artifact/out/patch-mvninstall-hadoop-common-project_hadoop-common.txt

compile
https://builds.apache.org/job/hadoop-multibranch/job/PR-296/3/artifact/out/patch-compile-root.txt

javac
https://builds.apache.org/job/hadoop-multibranch/job/PR-296/3/artifact/out/patch-compile-root.txt

mvnsite
https://builds.apache.org/job/hadoop-multibranch/job/PR-296/3/artifact/out/patch-mvnsite-hadoop-common-project_hadoop-common.txt

findbugs
https://builds.apache.org/job/hadoop-multibranch/job/PR-296/3/artifact/out/patch-findbugs-hadoop-common-project_hadoop-common.txt

unit
https://builds.apache.org/job/hadoop-multibranch/job/PR-296/3/artifact/out/patch-unit-hadoop-common-project_hadoop-common.txt

Test Results
https://builds.apache.org/job/hadoop-multibranch/job/PR-296/3/testReport/

Max. process+thread count
447 (vs. ulimit of 5500)

modules
C: hadoop-common-project/hadoop-common U: hadoop-common-project/hadoop-common

Console output
https://builds.apache.org/job/hadoop-multibranch/job/PR-296/3/console

versions
git=2.7.4 maven=3.3.9 findbugs=3.1.0-RC1

Powered by
Apache Yetus 0.10.0 http://yetus.apache.org

This message was automatically generated.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Comment

0
reexec
139
Docker mode activated.

_ Prechecks _

+1
dupname
0
No case conflicting files found.

+1
@author
0
The patch does not contain any @author tags.

-1
test4tests
0
The patch doesn't appear to include any new or modified tests.  Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.

_ trunk Compile Tests _

+1
mvninstall
1444
trunk passed

+1
compile
1331
trunk passed

+1
checkstyle
54
trunk passed

+1
mvnsite
100
trunk passed

+1
shadedclient
1036
branch has no errors when building and testing our client artifacts.

+1
javadoc
77
trunk passed

0
spotbugs
157
Used deprecated FindBugs config; considering switching to SpotBugs.

+1
findbugs
154
trunk passed

_ Patch Compile Tests _

-1
mvninstall
32
hadoop-common in the patch failed.

-1
compile
62
root in the patch failed.

-1
javac
62
root in the patch failed.

+1
checkstyle
44
hadoop-common-project/hadoop-common: The patch generated 0 new + 14 unchanged - 1 fixed = 14 total (was 15)

-1
mvnsite
35
hadoop-common in the patch failed.

+1
whitespace
0
The patch has no whitespace issues.

-1
shadedclient
41
patch has errors when building and testing our client artifacts.

+1
javadoc
67
the patch passed

-1
findbugs
37
hadoop-common in the patch failed.

_ Other Tests _

-1
unit
43
hadoop-common in the patch failed.

+1
asflicense
59
The patch does not generate ASF License warnings.

4774

Subsystem
Report/Notes

Docker
Client=19.03.0 Server=19.03.0 base: https://builds.apache.org/job/hadoop-multibranch/job/PR-296/4/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/296

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient findbugs checkstyle

uname
Linux 4690c287a459 4.15.0-52-generic #56-Ubuntu SMP Tue Jun 4 22:49:08 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
personality/hadoop.sh

git revision
trunk / 00b5a27

Default Java
1.8.0_212

mvninstall
https://builds.apache.org/job/hadoop-multibranch/job/PR-296/4/artifact/out/patch-mvninstall-hadoop-common-project_hadoop-common.txt

compile
https://builds.apache.org/job/hadoop-multibranch/job/PR-296/4/artifact/out/patch-compile-root.txt

javac
https://builds.apache.org/job/hadoop-multibranch/job/PR-296/4/artifact/out/patch-compile-root.txt

mvnsite
https://builds.apache.org/job/hadoop-multibranch/job/PR-296/4/artifact/out/patch-mvnsite-hadoop-common-project_hadoop-common.txt

findbugs
https://builds.apache.org/job/hadoop-multibranch/job/PR-296/4/artifact/out/patch-findbugs-hadoop-common-project_hadoop-common.txt

unit
https://builds.apache.org/job/hadoop-multibranch/job/PR-296/4/artifact/out/patch-unit-hadoop-common-project_hadoop-common.txt

Test Results
https://builds.apache.org/job/hadoop-multibranch/job/PR-296/4/testReport/

Max. process+thread count
305 (vs. ulimit of 5500)

modules
C: hadoop-common-project/hadoop-common U: hadoop-common-project/hadoop-common

Console output
https://builds.apache.org/job/hadoop-multibranch/job/PR-296/4/console

versions
git=2.7.4 maven=3.3.9 findbugs=3.1.0-RC1

Powered by
Apache Yetus 0.10.0 http://yetus.apache.org

This message was automatically generated.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Comment

0
reexec
89
Docker mode activated.

_ Prechecks _

+1
dupname
1
No case conflicting files found.

+1
@author
0
The patch does not contain any @author tags.

-1
test4tests
0
The patch doesn't appear to include any new or modified tests.  Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.

_ trunk Compile Tests _

+1
mvninstall
1279
trunk passed

+1
compile
1091
trunk passed

+1
checkstyle
49
trunk passed

+1
mvnsite
92
trunk passed

+1
shadedclient
887
branch has no errors when building and testing our client artifacts.

+1
javadoc
62
trunk passed

0
spotbugs
123
Used deprecated FindBugs config; considering switching to SpotBugs.

+1
findbugs
121
trunk passed

_ Patch Compile Tests _

-1
mvninstall
30
hadoop-common in the patch failed.

-1
compile
61
root in the patch failed.

-1
javac
61
root in the patch failed.

+1
checkstyle
37
hadoop-common-project/hadoop-common: The patch generated 0 new + 13 unchanged - 1 fixed = 13 total (was 14)

-1
mvnsite
32
hadoop-common in the patch failed.

+1
whitespace
0
The patch has no whitespace issues.

-1
shadedclient
37
patch has errors when building and testing our client artifacts.

+1
javadoc
52
the patch passed

-1
findbugs
29
hadoop-common in the patch failed.

_ Other Tests _

-1
unit
30
hadoop-common in the patch failed.

+1
asflicense
24
The patch does not generate ASF License warnings.

4009

Subsystem
Report/Notes

Docker
Client=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/hadoop-multibranch/job/PR-296/5/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/296

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient findbugs checkstyle

uname
Linux 9f06358d6869 4.15.0-54-generic #58-Ubuntu SMP Mon Jun 24 10:55:24 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
personality/hadoop.sh

git revision
trunk / e356e4f

Default Java
1.8.0_222

mvninstall
https://builds.apache.org/job/hadoop-multibranch/job/PR-296/5/artifact/out/patch-mvninstall-hadoop-common-project_hadoop-common.txt

compile
https://builds.apache.org/job/hadoop-multibranch/job/PR-296/5/artifact/out/patch-compile-root.txt

javac
https://builds.apache.org/job/hadoop-multibranch/job/PR-296/5/artifact/out/patch-compile-root.txt

mvnsite
https://builds.apache.org/job/hadoop-multibranch/job/PR-296/5/artifact/out/patch-mvnsite-hadoop-common-project_hadoop-common.txt

findbugs
https://builds.apache.org/job/hadoop-multibranch/job/PR-296/5/artifact/out/patch-findbugs-hadoop-common-project_hadoop-common.txt

unit
https://builds.apache.org/job/hadoop-multibranch/job/PR-296/5/artifact/out/patch-unit-hadoop-common-project_hadoop-common.txt

Test Results
https://builds.apache.org/job/hadoop-multibranch/job/PR-296/5/testReport/

Max. process+thread count
339 (vs. ulimit of 5500)

modules
C: hadoop-common-project/hadoop-common U: hadoop-common-project/hadoop-common

Console output
https://builds.apache.org/job/hadoop-multibranch/job/PR-296/5/console

versions
git=2.7.4 maven=3.3.9 findbugs=3.1.0-RC1

Powered by
Apache Yetus 0.10.0 http://yetus.apache.org

This message was automatically generated.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Comment

0
reexec
42
Docker mode activated.

_ Prechecks _

+1
dupname
0
No case conflicting files found.

+1
@author
0
The patch does not contain any @author tags.

-1
test4tests
0
The patch doesn't appear to include any new or modified tests.  Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.

_ trunk Compile Tests _

+1
mvninstall
1035
trunk passed

+1
compile
1056
trunk passed

+1
checkstyle
39
trunk passed

+1
mvnsite
69
trunk passed

+1
shadedclient
751
branch has no errors when building and testing our client artifacts.

+1
javadoc
59
trunk passed

0
spotbugs
119
Used deprecated FindBugs config; considering switching to SpotBugs.

+1
findbugs
118
trunk passed

_ Patch Compile Tests _

-1
mvninstall
24
hadoop-common in the patch failed.

-1
compile
46
root in the patch failed.

-1
javac
46
root in the patch failed.

+1
checkstyle
28
hadoop-common-project/hadoop-common: The patch generated 0 new + 13 unchanged - 1 fixed = 13 total (was 14)

-1
mvnsite
26
hadoop-common in the patch failed.

+1
whitespace
0
The patch has no whitespace issues.

-1
shadedclient
33
patch has errors when building and testing our client artifacts.

+1
javadoc
48
the patch passed

-1
findbugs
24
hadoop-common in the patch failed.

_ Other Tests _

-1
unit
24
hadoop-common in the patch failed.

+1
asflicense
21
The patch does not generate ASF License warnings.

3463

Subsystem
Report/Notes

Docker
Client=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/hadoop-multibranch/job/PR-296/6/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/296

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient findbugs checkstyle

uname
Linux 5c972484e29f 4.4.0-139-generic #165-Ubuntu SMP Wed Oct 24 10:58:50 UTC 2018 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
personality/hadoop.sh

git revision
trunk / 4cb22cd

Default Java
1.8.0_212

mvninstall
https://builds.apache.org/job/hadoop-multibranch/job/PR-296/6/artifact/out/patch-mvninstall-hadoop-common-project_hadoop-common.txt

compile
https://builds.apache.org/job/hadoop-multibranch/job/PR-296/6/artifact/out/patch-compile-root.txt

javac
https://builds.apache.org/job/hadoop-multibranch/job/PR-296/6/artifact/out/patch-compile-root.txt

mvnsite
https://builds.apache.org/job/hadoop-multibranch/job/PR-296/6/artifact/out/patch-mvnsite-hadoop-common-project_hadoop-common.txt

findbugs
https://builds.apache.org/job/hadoop-multibranch/job/PR-296/6/artifact/out/patch-findbugs-hadoop-common-project_hadoop-common.txt

unit
https://builds.apache.org/job/hadoop-multibranch/job/PR-296/6/artifact/out/patch-unit-hadoop-common-project_hadoop-common.txt

Test Results
https://builds.apache.org/job/hadoop-multibranch/job/PR-296/6/testReport/

Max. process+thread count
447 (vs. ulimit of 5500)

modules
C: hadoop-common-project/hadoop-common U: hadoop-common-project/hadoop-common

Console output
https://builds.apache.org/job/hadoop-multibranch/job/PR-296/6/console

versions
git=2.7.4 maven=3.3.9 findbugs=3.1.0-RC1

Powered by
Apache Yetus 0.10.0 http://yetus.apache.org

This message was automatically generated.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Comment

0
reexec
41
Docker mode activated.

_ Prechecks _

+1
dupname
0
No case conflicting files found.

+1
@author
0
The patch does not contain any @author tags.

-1
test4tests
0
The patch doesn't appear to include any new or modified tests.  Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.

_ trunk Compile Tests _

+1
mvninstall
1118
trunk passed

+1
compile
1055
trunk passed

+1
checkstyle
36
trunk passed

+1
mvnsite
72
trunk passed

+1
shadedclient
740
branch has no errors when building and testing our client artifacts.

+1
javadoc
57
trunk passed

0
spotbugs
118
Used deprecated FindBugs config; considering switching to SpotBugs.

+1
findbugs
114
trunk passed

_ Patch Compile Tests _

-1
mvninstall
24
hadoop-common in the patch failed.

-1
compile
49
root in the patch failed.

-1
javac
49
root in the patch failed.

+1
checkstyle
28
hadoop-common-project/hadoop-common: The patch generated 0 new + 13 unchanged - 1 fixed = 13 total (was 14)

-1
mvnsite
24
hadoop-common in the patch failed.

+1
whitespace
0
The patch has no whitespace issues.

-1
shadedclient
32
patch has errors when building and testing our client artifacts.

+1
javadoc
46
the patch passed

-1
findbugs
23
hadoop-common in the patch failed.

_ Other Tests _

-1
unit
23
hadoop-common in the patch failed.

+1
asflicense
23
The patch does not generate ASF License warnings.

3529

Subsystem
Report/Notes

Docker
Client=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/hadoop-multibranch/job/PR-296/7/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/296

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient findbugs checkstyle

uname
Linux b70f6bddfd27 4.4.0-139-generic #165-Ubuntu SMP Wed Oct 24 10:58:50 UTC 2018 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
personality/hadoop.sh

git revision
trunk / 63c295e

Default Java
1.8.0_212

mvninstall
https://builds.apache.org/job/hadoop-multibranch/job/PR-296/7/artifact/out/patch-mvninstall-hadoop-common-project_hadoop-common.txt

compile
https://builds.apache.org/job/hadoop-multibranch/job/PR-296/7/artifact/out/patch-compile-root.txt

javac
https://builds.apache.org/job/hadoop-multibranch/job/PR-296/7/artifact/out/patch-compile-root.txt

mvnsite
https://builds.apache.org/job/hadoop-multibranch/job/PR-296/7/artifact/out/patch-mvnsite-hadoop-common-project_hadoop-common.txt

findbugs
https://builds.apache.org/job/hadoop-multibranch/job/PR-296/7/artifact/out/patch-findbugs-hadoop-common-project_hadoop-common.txt

unit
https://builds.apache.org/job/hadoop-multibranch/job/PR-296/7/artifact/out/patch-unit-hadoop-common-project_hadoop-common.txt

Test Results
https://builds.apache.org/job/hadoop-multibranch/job/PR-296/7/testReport/

Max. process+thread count
412 (vs. ulimit of 5500)

modules
C: hadoop-common-project/hadoop-common U: hadoop-common-project/hadoop-common

Console output
https://builds.apache.org/job/hadoop-multibranch/job/PR-296/7/console

versions
git=2.7.4 maven=3.3.9 findbugs=3.1.0-RC1

Powered by
Apache Yetus 0.10.0 http://yetus.apache.org

This message was automatically generated.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Comment

0
reexec
72
Docker mode activated.

_ Prechecks _

+1
dupname
0
No case conflicting files found.

+1
@author
0
The patch does not contain any @author tags.

-1
test4tests
0
The patch doesn't appear to include any new or modified tests.  Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.

_ trunk Compile Tests _

+1
mvninstall
1120
trunk passed

+1
compile
966
trunk passed

+1
checkstyle
49
trunk passed

+1
mvnsite
81
trunk passed

+1
shadedclient
821
branch has no errors when building and testing our client artifacts.

+1
javadoc
70
trunk passed

0
spotbugs
121
Used deprecated FindBugs config; considering switching to SpotBugs.

+1
findbugs
119
trunk passed

_ Patch Compile Tests _

-1
mvninstall
27
hadoop-common in the patch failed.

-1
compile
48
root in the patch failed.

-1
javac
48
root in the patch failed.

+1
checkstyle
31
hadoop-common-project/hadoop-common: The patch generated 0 new + 13 unchanged - 1 fixed = 13 total (was 14)

-1
mvnsite
29
hadoop-common in the patch failed.

+1
whitespace
0
The patch has no whitespace issues.

-1
shadedclient
35
patch has errors when building and testing our client artifacts.

+1
javadoc
53
the patch passed

-1
findbugs
27
hadoop-common in the patch failed.

_ Other Tests _

-1
unit
28
hadoop-common in the patch failed.

+1
asflicense
25
The patch does not generate ASF License warnings.

3630

Subsystem
Report/Notes

Docker
Client=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/hadoop-multibranch/job/PR-296/8/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/296

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient findbugs checkstyle

uname
Linux c54bcc652015 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
personality/hadoop.sh

git revision
trunk / 3329257

Default Java
1.8.0_222

mvninstall
https://builds.apache.org/job/hadoop-multibranch/job/PR-296/8/artifact/out/patch-mvninstall-hadoop-common-project_hadoop-common.txt

compile
https://builds.apache.org/job/hadoop-multibranch/job/PR-296/8/artifact/out/patch-compile-root.txt

javac
https://builds.apache.org/job/hadoop-multibranch/job/PR-296/8/artifact/out/patch-compile-root.txt

mvnsite
https://builds.apache.org/job/hadoop-multibranch/job/PR-296/8/artifact/out/patch-mvnsite-hadoop-common-project_hadoop-common.txt

findbugs
https://builds.apache.org/job/hadoop-multibranch/job/PR-296/8/artifact/out/patch-findbugs-hadoop-common-project_hadoop-common.txt

unit
https://builds.apache.org/job/hadoop-multibranch/job/PR-296/8/artifact/out/patch-unit-hadoop-common-project_hadoop-common.txt

Test Results
https://builds.apache.org/job/hadoop-multibranch/job/PR-296/8/testReport/

Max. process+thread count
411 (vs. ulimit of 5500)

modules
C: hadoop-common-project/hadoop-common U: hadoop-common-project/hadoop-common

Console output
https://builds.apache.org/job/hadoop-multibranch/job/PR-296/8/console

versions
git=2.7.4 maven=3.3.9 findbugs=3.1.0-RC1

Powered by
Apache Yetus 0.10.0 http://yetus.apache.org

This message was automatically generated.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Comment

0
reexec
71
Docker mode activated.

_ Prechecks _

+1
dupname
0
No case conflicting files found.

+1
@author
0
The patch does not contain any @author tags.

-1
test4tests
0
The patch doesn't appear to include any new or modified tests.  Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.

_ trunk Compile Tests _

+1
mvninstall
1186
trunk passed

+1
compile
1162
trunk passed

+1
checkstyle
47
trunk passed

+1
mvnsite
92
trunk passed

+1
shadedclient
903
branch has no errors when building and testing our client artifacts.

+1
javadoc
72
trunk passed

0
spotbugs
162
Used deprecated FindBugs config; considering switching to SpotBugs.

+1
findbugs
159
trunk passed

_ Patch Compile Tests _

-1
mvninstall
31
hadoop-common in the patch failed.

-1
compile
55
root in the patch failed.

-1
javac
55
root in the patch failed.

+1
checkstyle
35
hadoop-common-project/hadoop-common: The patch generated 0 new + 13 unchanged - 1 fixed = 13 total (was 14)

-1
mvnsite
32
hadoop-common in the patch failed.

+1
whitespace
0
The patch has no whitespace issues.

-1
shadedclient
39
patch has errors when building and testing our client artifacts.

+1
javadoc
58
the patch passed

-1
findbugs
29
hadoop-common in the patch failed.

_ Other Tests _

-1
unit
28
hadoop-common in the patch failed.

+1
asflicense
23
The patch does not generate ASF License warnings.

4039

Subsystem
Report/Notes

Docker
Client=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/hadoop-multibranch/job/PR-296/9/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/296

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient findbugs checkstyle

uname
Linux 77ef3c059f4c 4.15.0-54-generic #58-Ubuntu SMP Mon Jun 24 10:55:24 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
personality/hadoop.sh

git revision
trunk / 915cbc9

Default Java
1.8.0_222

mvninstall
https://builds.apache.org/job/hadoop-multibranch/job/PR-296/9/artifact/out/patch-mvninstall-hadoop-common-project_hadoop-common.txt

compile
https://builds.apache.org/job/hadoop-multibranch/job/PR-296/9/artifact/out/patch-compile-root.txt

javac
https://builds.apache.org/job/hadoop-multibranch/job/PR-296/9/artifact/out/patch-compile-root.txt

mvnsite
https://builds.apache.org/job/hadoop-multibranch/job/PR-296/9/artifact/out/patch-mvnsite-hadoop-common-project_hadoop-common.txt

findbugs
https://builds.apache.org/job/hadoop-multibranch/job/PR-296/9/artifact/out/patch-findbugs-hadoop-common-project_hadoop-common.txt

unit
https://builds.apache.org/job/hadoop-multibranch/job/PR-296/9/artifact/out/patch-unit-hadoop-common-project_hadoop-common.txt

Test Results
https://builds.apache.org/job/hadoop-multibranch/job/PR-296/9/testReport/

Max. process+thread count
292 (vs. ulimit of 5500)

modules
C: hadoop-common-project/hadoop-common U: hadoop-common-project/hadoop-common

Console output
https://builds.apache.org/job/hadoop-multibranch/job/PR-296/9/console

versions
git=2.7.4 maven=3.3.9 findbugs=3.1.0-RC1

Powered by
Apache Yetus 0.10.0 http://yetus.apache.org

This message was automatically generated.


update guidance on migration guide in deprecation doc

Adding in guidance about migration guides to deprecation doc as per Laurent.

/check-enforcer override


/device42 v1.3.10 does not have a package available for mac

Any suggestions ?
│ Error: Incompatible provider version
│
│ Provider registry.terraform.io/gerardlemetayerc/device42 v1.3.10 does not have a package available for your current platform,
│ darwin_amd64.
│

Hello,
Noticed.
I will add it in the git workflow.

Hello,
It should be ok now (adressed in latest version).
Do not hesitate if it's not good on your side.


Consider using JDK-Standard 'ServiceLoader' instead of Spring

... for loading rules into validator.
Hi Zally-Team, I would like you to consider using the 'ServiceLoader'-Feature to load existing rules into the validator. Sure, I don't know what you plan for the future with Zally and how the Rules-interface will evolve in the future. From what I have seen so far, the ServiceLoader provided by the JDK can replace the existing mechanism to load the rules and the validator itself does not depend anymore on spring.
Removing the dependency to spring could make the validator more interesting for other projects. As an example swagger-codegen-tooling comes into my mind. It would be a nice feature to validate the swagger.yaml before generating code.
Also for other integrations (Gradle-plugin) it would make sense to provide a validator with minimal dependencies.
Please have a look into the 'serviceloader'-branch to see how the 'ServiceLoader' can be used.
Regards
Jörg

Wow, thanks for this interesting idea and proof of concept 👍
You are totally right, without Spring integrations in other tools should be quite easy. For this we could fledge out the rule evaluation in a library and link this library to the server.
How could #75 be implemented with this approach? We'd like to make rule set configurable on runtime. As far as I understood your code, you have to provide the configuration in manifest file in META-INF.

Regarding #75 I could imagine to give every Rule-Implementation a unique id/shortname (think of modules/checks in Checkstyle). Then after loading every rule available in classpath and picked up by ServiceLoader, just filter via standard 'java.util.function.Predicate' and return a new RuleValidator-object containing only filtered rules. That would be the easiest thing to try first.
Which rules to include can be specified by a zally.yaml maybe of if nothing specified, every rule kicks in. In zally.yaml a 'include', 'exclude' section can exists to let the user define what makes sense for him/her.
For going with ids/shortnames it would helpful for a user to build then back-links to specific rules in the report (like in the checkstyle-link above). But I think I've seen something like that already, right?
Regards
Jörg

Regarding #75 - I totally agree with @jbellmann, as long as we have full list of Rule implementations  we can filter it out by any criteria.
Regarding ServiceLoader mechanism:
I've experimented with this approach.  It works fine but there is one substantial downside:
you need to explicitly list all your implementations in separate file (correct me if I'm wrong). Since in our case all implementations are known at compile time there is no value in it. You can simply write code like that:
val allRules = listOf(
  AvoidJavascriptKeywordsRule(),
  ExtractBasePathRule(),
  ...
)

(in fact first version of Zally worked exactly like that). Maintaining such list is proven to be tedious and error-prone in a long run.
If we want to move core validation logic into separate module that doesn't depend on Spring, I would suggest to use same mechanism as in Spring: classpath walking.
Possible implementation could be (reflections)[https://github.com/ronmamo/reflections] Perhaps we could even get rid of annotations and pick every class that implements Rule interface unless the class is marked with @Ignore.

AutoService project can be used for generating config for ServiceLoader from source during compile. It use java annotation processor. Very easy to use. Very easy to implement. No dependency from Spring and no classpath walking at runtime.

Given that:

#843 was rejected because it's "re-creating what Spring does already"
We make heavy use of Spring AOP in https://github.com/zalando/zally/blob/master/server/src/main/java/de/zalando/zally/util/ast/MethodCallRecorder.kt

It appears that the switch to a Spring-free ServiceLoader mechanism is not happening and this issue can be closed.


etcd (ticdc): fix a data race in unit test

What problem does this PR solve?

Issue Number: close #4549
What is changed and how it works?
Check List
Tests

Unit test

Code changes

None

Side effects

None

Related changes

Need to cherry-pick to the release branch

Release note
None

Codecov Report

Merging #4551 (7d39c65) into master (9607554) will decrease coverage by 0.0953%.
The diff coverage is 59.5451%.

Flag
Coverage Δ

cdc
60.2305% <65.8779%> (+0.3082%)
:arrow_up:

dm
51.5615% <51.6975%> (-0.4674%)
:arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.
@@               Coverage Diff                @@
##             master      #4551        +/-   ##
================================================
- Coverage   55.6402%   55.5448%   -0.0954%
================================================
  Files           494        503         +9
  Lines         61283      62499      +1216
================================================
+ Hits          34098      34715       +617
- Misses        23750      24319       +569
- Partials       3435       3465        +30


TextInput stuck when running heavy calculations on server

When I am trying to run heavy calculations and change the value of the TextInput beforehand, the value change somehow seems to be stuck. I have prepared a small example:
pn.extension()

def heavy_calculation():
    epos_indexed = epos[0:10_000_000]
    cropped_index = np.where((epos_indexed['dx'] >= -5) & (epos_indexed['dx'] <= 10)
                              & (epos_indexed['dy'] >= -10) & epos_indexed['dy'] <= 15)[0]
    # print(list(cropped_index))
    cropped_epos = epos.iloc[list(cropped_index)]

class Test:

    def __init__(self):
        self.button = pn.widgets.Button(name='Click Me!')
        self.txt = pn.widgets.TextInput(name='Misused as Log:')
        self.button.param.watch(self._button_click, 'clicks')

    def _button_click(self, clicks):
        self.txt.value = 'Start heavy calculation...'
        heavy_calculation()
        self.txt.value = 'Heavy calculation finished.'

    def view(self):
        return pn.Column(self.button, self.txt)

Test().view()

When I run this on a jupyter notebook, there is no problem:

But when I deploy it using  panel serve --show, the first message on the TextInput widget does not appear:

For deploying I have downloaded the notebook as a python file and edited Test().view() to Test().view().server_doc().
epos is just a pandas DataFrame containing 36,000,000 elements.
I am not sure, whether this is a panel or bokeh problem.

Thanks for the report. I'll look into as a quick aside:

For deploying I have downloaded the notebook as a python file and edited Test().show() to Test().show().server_doc().

This shouldn't be necessary, you can have the notebook work both in the notebook and on bokeh server by using Test().show().servable(). That will render in a notebook and work when you use panel serve notebook.ipynb --show.

Okay, so this is a pretty central part of how bokeh server works, changing a parameter value will schedule a so called next_tick_callback, which won't be processed while the "heavy_calculation" is being processed. Ordinarily you could also schedule the calculation as a next_tick_callback and we could consider exposing that mechanism in an easy way. However it would of course be a lot nicer if we could somehow make the naive approach work, I'll have to read a bit more about tornado and bokeh server to see if that's feasible.

Thank you very much for looking into all of the issues. For me personally either way is fine, if it is too hard to make it work the naive way, I can try with the next_tick_callback. (But I have to look into how this works)

@MHC03 So there's probably nothing we can do automatically, however you can do it by using the tornado IOLoop, in your example you'd do something like:
    def _button_click(self, clicks):
        self.txt.value = 'Start heavy calculation...'
        ioloop = tornado.ioloop.IOLoop.current()
        ioloop.add_callback(self._heavy_calculation)

    def _heavy_calculation(self):
        heavy_calculation()
        self.txt.value = 'Heavy calculation finished.'

This code would be a bit less confusing if you changed your show() method to view(), to avoid confusion with Panel's .show() method.

For me the above approach does not fully work, the second change to the textinput value does not occur. It is stuck with 'Start heavy calculation...'.

Yeah, it's not quite clear to me what's going on here, it's definitely not working right in this case but I've used it successfully in other examples.

This code would be a bit less confusing if you changed your show() method to view(), to avoid confusion with Panel's .show() method.

Changed it, maybe  @philippjfr can also edit his comment.

Yeah, it's not quite clear to me what's going on here, it's definitely not working right in this case but I've used it successfully in other examples.

I will try some workaround with the ioloop callback for now. Thanks a lot for looking into this stuff.

Thanks a lot for looking into this stuff.

No problem, I'm encountering the same issues so this is fairly high priority. Still searching for a better solution, but my knowledge of tornado is lacking a bit.


Arguments array leak

We need to eliminate argument array leaks since these will prevent the JS engine from optimisation, see https://github.com/petkaantonov/bluebird/wiki/Optimization-killers

The leak happened in https://github.com/pana-cc/mocha-typescript/commit/224f32a588bf3ea675cf2c1e6f3bae53bda4c52d#diff-f57bc6f4deefd9abc09a381b1dd57b5bR275 where the arguments array is passed as an argument.

Done on branch gh-157.


[C++][Packaging] Figure out why Arrow C++ fails to build under vcpkg on Android

Describe the bug, including details regarding any error messages, version, and platform.
The PR to update vcpk's version of Arrow C++ for 18.1.0 is failing but only for Android, see https://github.com/microsoft/vcpkg/pull/42357#issuecomment-2507182107. The relevant log output is:
FAILED: src/arrow/CMakeFiles/arrow_vendored.dir/vendored/datetime.cpp.o
/android-ndk-r27c/toolchains/llvm/prebuilt/linux-x86_64/bin/clang++ --target=aarch64-none-linux-android21 --sysroot=/android-ndk-r27c/toolchains/llvm/prebuilt/linux-x86_64/sysroot -DARROW_HAVE_NEON -DARROW_WITH_TIMING_TESTS -DURI_STATIC_BUILD -I/mnt/vcpkg-ci/b/arrow/arm64-android-dbg/src -I/mnt/vcpkg-ci/b/arrow/src/e-arrow-18-d474976a0f.clean/cpp/src -I/mnt/vcpkg-ci/b/arrow/src/e-arrow-18-d474976a0f.clean/cpp/src/generated -g -DANDROID -fdata-sections -ffunction-sections -funwind-tables -fstack-protector-strong -no-canonical-prefixes -D_FORTIFY_SOURCE=2 -Wformat -Werror=format-security -frtti -fexceptions  -fPIC   -Qunused-arguments -fcolor-diagnostics  -Wall -Wno-unknown-warning-option -Wno-pass-failed -march=armv8-a  -fno-limit-debug-info    -O0 -ggdb  -std=c++17 -fPIC -MD -MT src/arrow/CMakeFiles/arrow_vendored.dir/vendored/datetime.cpp.o -MF src/arrow/CMakeFiles/arrow_vendored.dir/vendored/datetime.cpp.o.d -o src/arrow/CMakeFiles/arrow_vendored.dir/vendored/datetime.cpp.o -c /mnt/vcpkg-ci/b/arrow/src/e-arrow-18-d474976a0f.clean/cpp/src/arrow/vendored/datetime.cpp
In file included from /mnt/vcpkg-ci/b/arrow/src/e-arrow-18-d474976a0f.clean/cpp/src/arrow/vendored/datetime.cpp:19:
/mnt/vcpkg-ci/b/arrow/src/e-arrow-18-d474976a0f.clean/cpp/src/arrow/vendored/datetime/tz.cpp:608:55: error: use of undeclared identifier 'init_tzdb'; did you mean 'get_tzdb'?
  608 |     tzdb_list::undocumented_helper::push_front(tz_db, init_tzdb().release());
      |                                                       ^~~~~~~~~
      |                                                       get_tzdb
/mnt/vcpkg-ci/b/arrow/src/e-arrow-18-d474976a0f.clean/cpp/src/arrow/vendored/datetime/tz.h:1221:22: note: 'get_tzdb' declared here
 1221 | DATE_API const tzdb& get_tzdb();
      |                      ^
In file included from /mnt/vcpkg-ci/b/arrow/src/e-arrow-18-d474976a0f.clean/cpp/src/arrow/vendored/datetime.cpp:19:
/mnt/vcpkg-ci/b/arrow/src/e-arrow-18-d474976a0f.clean/cpp/src/arrow/vendored/datetime/tz.cpp:608:67: error: no member named 'release' in 'arrow_vendored::date::tzdb'
  608 |     tzdb_list::undocumented_helper::push_front(tz_db, init_tzdb().release());
      |                                                       ~~~~~~~~~~~ ^
/mnt/vcpkg-ci/b/arrow/src/e-arrow-18-d474976a0f.clean/cpp/src/arrow/vendored/datetime/tz.cpp:3039:18: error: 'parse_from_android_tzdata' is a private member of 'arrow_vendored::date::time_zone'
 3039 |         timezone.parse_from_android_tzdata(in, hdr.data_offset + index_entry.start);
      |                  ^
/mnt/vcpkg-ci/b/arrow/src/e-arrow-18-d474976a0f.clean/cpp/src/arrow/vendored/datetime/tz.h:861:10: note: declared private here
  861 |     void parse_from_android_tzdata(std::ifstream& inf, const std::size_t off);
      |          ^
3 errors generated.

I'm guessing this has something to do with https://github.com/apache/arrow/commit/67850befa604ce27c2ea8f37132a5ccf73fe68d9 which was cherry-picked onto 18.1.0.
Component(s)
C++, Packaging

@assignUser @kou @raulcd can any of you take a look? If the fix needs to be done on the Arrow side, would it be acceptable to just not publish 18.1.0 to vcpkg, fix this for 19.0.0, and update vcpkg with 19.0.0?

Note that vcpkg CI builds Android with API level 21. At that level, C runtime is very incomplete. It might be enough to document the minimum requirement.

Could you try this?
diff --git a/cpp/src/arrow/vendored/datetime/tz.h b/cpp/src/arrow/vendored/datetime/tz.h
index 61ab3df106..d456d6765f 100644
--- a/cpp/src/arrow/vendored/datetime/tz.h
+++ b/cpp/src/arrow/vendored/datetime/tz.h
@@ -858,7 +858,9 @@ private:
     load_data(std::istream& inf, std::int32_t tzh_leapcnt, std::int32_t tzh_timecnt,
                                  std::int32_t tzh_typecnt, std::int32_t tzh_charcnt);
 # if defined(ANDROID) || defined(__ANDROID__)
+public:
     void parse_from_android_tzdata(std::ifstream& inf, const std::size_t off);
+private:
 # endif // defined(ANDROID) || defined(__ANDROID__)
 #else  // !USE_OS_TZDB
     DATE_API sys_info   get_info_impl(sys_seconds tp, int tz_int) const;
diff --git a/cpp/src/arrow/vendored/datetime/visibility.h b/cpp/src/arrow/vendored/datetime/visibility.h
index 780c00d70b..a9514edba7 100644
--- a/cpp/src/arrow/vendored/datetime/visibility.h
+++ b/cpp/src/arrow/vendored/datetime/visibility.h
@@ -21,6 +21,10 @@
 #  define USE_OS_TZDB 1
 #endif

+#if defined(ANDROID) || defined(__ANDROID__)
+#  define BUILD_TZ_LIB
+#endif
+
 #if defined(ARROW_STATIC)
 // intentially empty
 #elif defined(ARROW_EXPORTING)

If this doesn't work, we need to skip 18.1.0 on vcpkg and report it to upstream https://github.com/HowardHinnant/date .
It seems that upstream doesn't work with #define USE_OS_TZDB 1 on Android.

https://github.com/HowardHinnant/date

And this library has a port in vcpkg. (May not solve the android issue, but must be devendored at least if not encapsulating symbol names.)

Thanks.
If we require C++20, we can drop  https://github.com/HowardHinnant/date because C++20 has the feature provided by the library...

Thanks @kou, I added the patch to the vcpkg port PR, see https://github.com/microsoft/vcpkg/pull/42357. Note I also renamed the patches to match vcpkg convention. I'll keep an eye on CI.

Thanks.
It seems that the patch fixed the build errors.
We need to add a CI for Android before we apply this patch.
See also: https://github.com/apache/arrow/issues/43390

We need to add a CI for Android before we apply this patch.

Do we really? This would mean adding android to our kind-of-officially supported list of configurations that we test (we are missing an offical one still...). I am not sure that is really justified. After all this was not a user report but rather vcpkg adding CI for a new triplet (this happend last year apparently). I think it's fine to keep the patch in VCPKG for now?
We should of course have some form of offical support policy that would make this decision easier :D

The issue can be reproduced in termux environment (Android terminal emulator). The full build log can be found here https://github.com/termux/termux-packages/actions/runs/12239893371. The patch in https://github.com/apache/arrow/issues/44886#issuecomment-2508924885 comment fixed it.

I'm going to close this issue as the immdiate issue is resolved. Let's continue discussing Android support in https://github.com/apache/arrow/issues/43390.


Litecoin Install Froze at Synchronize Blockchain

I let it run overnight and no further movement since last night.
BTW, my node for Bitcoin is rocking along and seems, to me at least, a lot faster than the set up of 1.63 - thanks.
I am updating node to Version 1.7.0 with lnd 0.12.1 and bitcoin 0.21.0 (or litecoin 0.18.1) from 1.63 - fresh instal
For this node I chose Litecoin
Raspberry Pi 4B 8BG
SSD 1TB
SD 32GB (format FAT) I had it on hand
https://termbin.com/lpr9
debug log

RASPIBLITZ DEBUG LOGS

blitzversion: 1.7.0
chainnetwork: litecoin / main
10:35:14 up  9:29,  2 users,  load average: 0.29, 0.34, 0.40
*** BLOCKCHAIN SYSTEMD STATUS ***
● litecoind.service - Litecoin daemon
Loaded: loaded (/etc/systemd/system/litecoind.service; enabled; vendor preset: enabled)
Active: active (running) since Fri 2021-04-30 00:55:23 BST; 9h ago
Process: 1387 ExecStartPre=/home/admin/config.scripts/blitz.systemd.sh log blockchain STARTED (code=exited, status=0/SUCCESS)
Process: 1393 ExecStart=/usr/local/bin/litecoind -daemon -conf=/home/bitcoin/.litecoin/litecoin.conf -pid=/home/bitcoin/.litecoin/litecoind.pid (code=exited, status=0/SUCCESS)
Main PID: 1413 (litecoind)
Tasks: 17 (limit: 4915)
CGroup: /system.slice/litecoind.service
└─1413 /usr/local/bin/litecoind -daemon -conf=/home/bitcoin/.litecoin/litecoin.conf -pid=/home/bitcoin/.litecoin/litecoind.pid
Warning: Journal has been rotated since unit was started. Log output is incomplete or unavailable.
*** LAST BLOCKCHAIN ERROR LOGS ***
sudo journalctl -u litecoind -b --no-pager -n8
-- Logs begin at Fri 2021-04-30 02:59:13 BST, end at Fri 2021-04-30 10:35:15 BST. --
-- No entries --
*** LAST BLOCKCHAIN 20 INFO LOGS ***
sudo tail -n 20 /mnt/hdd/litecoin/debug.log
2021-04-30T08:36:49Z Potential stale tip detected, will try using extra outbound peer (last tip update: 30600 seconds ago)
2021-04-30T08:39:49Z Potential stale tip detected, will try using extra outbound peer (last tip update: 30780 seconds ago)
2021-04-30T08:42:49Z Potential stale tip detected, will try using extra outbound peer (last tip update: 30960 seconds ago)
2021-04-30T08:45:49Z Potential stale tip detected, will try using extra outbound peer (last tip update: 31140 seconds ago)
2021-04-30T08:48:49Z Potential stale tip detected, will try using extra outbound peer (last tip update: 31320 seconds ago)
2021-04-30T08:51:49Z Potential stale tip detected, will try using extra outbound peer (last tip update: 31500 seconds ago)
2021-04-30T08:54:49Z Potential stale tip detected, will try using extra outbound peer (last tip update: 31680 seconds ago)
2021-04-30T08:57:49Z Potential stale tip detected, will try using extra outbound peer (last tip update: 31860 seconds ago)
2021-04-30T09:00:49Z Potential stale tip detected, will try using extra outbound peer (last tip update: 32040 seconds ago)
2021-04-30T09:03:49Z Potential stale tip detected, will try using extra outbound peer (last tip update: 32220 seconds ago)
2021-04-30T09:06:49Z Potential stale tip detected, will try using extra outbound peer (last tip update: 32400 seconds ago)
2021-04-30T09:09:49Z Potential stale tip detected, will try using extra outbound peer (last tip update: 32580 seconds ago)
2021-04-30T09:12:49Z Potential stale tip detected, will try using extra outbound peer (last tip update: 32760 seconds ago)
2021-04-30T09:15:49Z Potential stale tip detected, will try using extra outbound peer (last tip update: 32940 seconds ago)
2021-04-30T09:18:49Z Potential stale tip detected, will try using extra outbound peer (last tip update: 33120 seconds ago)
2021-04-30T09:21:49Z Potential stale tip detected, will try using extra outbound peer (last tip update: 33300 seconds ago)
2021-04-30T09:24:49Z Potential stale tip detected, will try using extra outbound peer (last tip update: 33480 seconds ago)
2021-04-30T09:27:49Z Potential stale tip detected, will try using extra outbound peer (last tip update: 33660 seconds ago)
2021-04-30T09:30:49Z Potential stale tip detected, will try using extra outbound peer (last tip update: 33840 seconds ago)
2021-04-30T09:33:49Z Potential stale tip detected, will try using extra outbound peer (last tip update: 34020 seconds ago)
*** LND SYSTEMD STATUS ***
● lnd.service - LND Lightning Daemon
Loaded: loaded (/etc/systemd/system/lnd.service; enabled; vendor preset: enabled)
Active: active (running) since Fri 2021-04-30 00:55:23 BST; 9h ago
Process: 1414 ExecStartPre=/home/admin/config.scripts/blitz.systemd.sh log lightning STARTED (code=exited, status=0/SUCCESS)
Main PID: 1416 (lnd)
Tasks: 11 (limit: 4915)
CGroup: /system.slice/lnd.service
└─1416 /usr/local/bin/lnd --tor.active --tor.streamisolation --tor.v3 --tor.socks=9070 --tor.control=9071 --listen=<IP_ADDRESS>:9735
Warning: Journal has been rotated since unit was started. Log output is incomplete or unavailable.
*** LAST LND ERROR LOGS ***
sudo journalctl -u lnd -b --no-pager -n12
-- Logs begin at Fri 2021-04-30 02:59:13 BST, end at Fri 2021-04-30 10:35:15 BST.  Log output is incomplete or unavailable.
*** LAST NGINX LOGS ***
sudo journalctl -u nginx -b --no-pager -n20
-- Logs begin at Fri 2021-04-30 02:59:13 BST, end at Fri 2021-04-30 10:35:15 BST. --
-- No entries --
--> CHECK CONFIG: sudo nginx -t
*** LAST 20 TOUCHSCREEN LOGS ***
sudo tail -n 20 /home/pi/.cache/lxsession/LXDE-pi/run.log
** Message: 09:18:54.360: wlan0: Received scan results
Playing WAVE '/usr/share/piwiz/srprompt.wav' : Signed 16 bit Little Endian, Rate 22050 Hz, Mono
Playing WAVE '/usr/share/piwiz/srprompt.wav' : Signed 16 bit Little Endian, Rate 22050 Hz, Mono
Playing WAVE '/usr/share/piwiz/srprompt.wav' : Signed 16 bit Little Endian, Rate 22050 Hz, Mono
Playing WAVE '/usr/share/piwiz/srprompt.wav' : Signed 16 bit Little Endian, Rate 22050 Hz, Mono
PolicyKit daemon disconnected from the bus.
We are no longer a registered authentication agent.
lxsession: Fatal IO error 11 (Resource temporarily unavailable) on X server :0.
openbox-lxde-pi (null)
lxpolkit (null)
lxpanel --profile LXDE-pi (null)
pcmanfm --desktop --profile LXDE-pi (null)
/usr/bin/ssh-agent -s (null)
lxpanel --profile LXDE-pi (null)
lxpolkit: Fatal IO error 11 (Resource temporarily unavailable) on X server :0.
pcmanfm: Fatal IO error 11 (Resource temporarily unavailable) on X server :0.
XIO:  fatal IO error 104 (Connection reset by peer) on X server ":0"
after 6240 requests (6022 known processed) with 2 events remaining.
lxpanel: Fatal IO error 11 (Resource temporarily unavailable) on X server :0.
Aborted by signal Terminated...
*** LAST 20 LOOP LOGS ***
sudo journalctl -u loopd -b --no-pager -n20
-- Logs begin at Fri 2021-04-30 02:59:13 BST, end at Fri 2021-04-30 10:35:15 BST. --
-- No entries --

RTL is OFF by config

*** LAST 20 ElectRS LOGS ***
sudo journalctl -u electrs -b --no-pager -n20
-- Logs begin at Fri 2021-04-30 02:59:13 BST, end at Fri 2021-04-30 10:35:15 BST. --
-- No entries --
*** ElectRS Status ***
STATUS ELECTRS SERVICE
configured=0
serviceInstalled=0
infoSync='Service not installed'
serviceRunning=0
tipSynced=0
initialSynced=0
electrumResponding=0
infoSync='Not running - check: sudo journalctl -u electrs'
*** LAST 20 LIT LOGS ***
sudo journalctl -u litd -b --no-pager -n20
-- Logs begin at Fri 2021-04-30 02:59:13 BST, end at Fri 2021-04-30 10:35:15 BST. --
-- No entries --
*** LAST 20 BTCPayServer LOGS ***
sudo journalctl -u btcpayserver -b --no-pager -n20
-- Logs begin at Fri 2021-04-30 02:59:13 BST, end at Fri 2021-04-30 10:35:15 BST. --
-- No entries --
*** LAST 20 LNbits LOGS ***
sudo journalctl -u lnbits -b --no-pager -n20
-- Logs begin at Fri 2021-04-30 02:59:13 BST, end at Fri 2021-04-30 10:35:15 BST. --
-- No entries --
*** LAST 20 Thunderhub LOGS ***
sudo journalctl -u thunderhub -b --no-pager -n20
-- Logs begin at Fri 2021-04-30 02:59:13 BST, end at Fri 2021-04-30 10:35:15 BST. --
-- No entries --
*** LAST 20 SPECTER LOGS ***
sudo journalctl -u cryptoadvance-specter -b --no-pager -n20
-- Logs begin at Fri 2021-04-30 02:59:13 BST, end at Fri 2021-04-30 10:35:15 BST. --
-- No entries --
*** LAST 20 SPHINX LOGS ***
sudo journalctl -u sphinxrelay -b --no-pager -n20
-- Logs begin at Fri 2021-04-30 02:59:13 BST, end at Fri 2021-04-30 10:35:16 BST. --
-- No entries --
*** MOUNTED DRIVES ***
Filesystem     Type      Size  Used Avail Use% Mounted on
/dev/root      ext4       15G  3.2G   11G  24% /
devtmpfs       devtmpfs  3.8G     0  3.8G   0% /dev
tmpfs          tmpfs     3.9G     0  3.9G   0% /dev/shm
tmpfs          tmpfs     3.9G  394M  3.5G  11% /run
tmpfs          tmpfs     5.0M  4.0K  5.0M   1% /run/lock
tmpfs          tmpfs     3.9G     0  3.9G   0% /sys/fs/cgroup
tmpfs          tmpfs      32M     0   32M   0% /var/cache/raspiblitz
/dev/sdb3      vfat       34G  2.1G   32G   6% /mnt/temp
/dev/mmcblk0p1 vfat      253M   30M  223M  12% /boot
/dev/sdb2      btrfs     868G   21M  866G   1% /mnt/storage
/dev/sdb1      btrfs      30G   28M   28G   1% /mnt/hdd
tmpfs          tmpfs     787M     0  787M   0% /run/user/1000
tmpfs          tmpfs     787M     0  787M   0% /run/user/1001
*** DATADRIVE ***
RASPIBLITZ DATA DRIVE Status
BASICS
isMounted=1
isBTRFS=1
hddRaspiData=1
isSSD=0
datadisk='sdb'
datapartition='sdb2'
hddBlocksBitcoin=0
hddBlocksLitecoin=1
hddBytes=931485409280
hddGigaBytes=867
hddUsedInfo='1% & 1%'
hddDataFreeKB=28925088
hddAdapterUSB=''
hddAdapterUSAP=0
RAID
isRaid=1
raidHddDev='sdb1'
raidUsbDev='sda'
SWAP
isSwapExternal=1
SwapExternalPath='/mnt/temp/swapfile'
*** NETWORK ***
localip=<IP_ADDRESS>
dhcp=1
network_device=eth0
*** HARDWARE TEST RESULTS ***
UndervoltageReports in Logs: 0
*** SYSTEM STATUS (can take some seconds to gather) ***
localIP='<IP_ADDRESS>'
tempCelsius='47.7'
uptime=34155
upsStatus='OFF'
startcountBlockchain=1
bitcoinActive=1
blockchainHeight=0
initialSync=1
syncProgress=0.00
startcountLightning=1
lndActive=1
walletLocked=0
lndPeers=0
syncedToChain=0
scanTimestamp=1317972665
scanDate='Fri  7 Oct 08:31:05 BST 2011'
scanProgress=22.38
lndRPCReady=1
blitzTUIActive=0
blitzTUIRestarts=0
scriptRuntime=0

Thank youi


Issues loading videos from rumble.com

I couldn't find if there was any support for this but it did say html files should work, but all I get is an "Error loading: Unknown file format" when attempting to load a rumble video.

Where you found that HTML files is supported?
Rumble is not supported source


KiCAD 5 unable to render 3D models

Issue description
I'm trying to add some 3D models to my footprints, but they do not show up in the 3D viewer. I've tried a custom model as well as the ones installed with KiCAD. I don't see any messages on stdout or stderr other than:
/nix/store/7qgqr1qvw84r6lfbw4yv43qi0glhwhd5-python2.7-wxPython-<IP_ADDRESS>/lib/python2.7/site-packages/wx-3.0-gtk2/wx/_core.py:16629: UserWarning: wxPython/wxWidgets release number mismatch
  warnings.warn("wxPython/wxWidgets release number mismatch")

Steps to reproduce

nix-env -i kicad
Launch the footprint editor
Open a footprint that has an associated model
Observe that the 3D model doesn't render

Technical details
 - system: `"x86_64-linux"`
 - host os: `Linux 4.14.76, NixOS, 18.09.932.09195057114 (Jellyfish)`
 - multi-user?: `yes`
 - sandbox: `yes`
 - version: `nix-env (Nix) 2.1.1`
 - channels(root): `"nixos-18.09.932.09195057114"`
 - channels(alex): `"nixpkgs-18.09pre151052.4477cf04b67"`
 - nixpkgs: `/home/alex/.nix-defexpr/channels/nixpkgs`

I'm also seeing this. It appears the issue is that 3D model importation is implemented via plugins which are shared libraries. These are found in /nix/store/...-kicad-5.0.1/lib/kicad/plugins/3d. However, the code which searches for these plugins (https://github.com/KiCad/kicad-source-mirror/blob/abe1ffabda2df3d13f2224917906f89826a30c8d/3d-viewer/3d_cache/3d_plugin_manager.cpp#L151) makes assumptions which don't hold for NixOS. Thus, the search attempt fails, as shown by strace:
[pid 15839] stat("/nix/store/qqa0fy130586yk8fx3zksir1kyz3k7ha-kicad-5.0.1/nix/store/qqa0fy130586yk8fx3zksir1kyz3k7ha-kicad-5.0.1/lib/kicad/plugins/3d", 0x7ffc52d03320) = -1 ENOENT (No such file or directory)

A temporary workaround is as follows, which uses the user-local search path:
$ mkdir -p ~/.kicad/plugins
$ cd ~/.kicad/plugins
$ ln -s /nix/store/qqa0fy130586yk8fx3zksir1kyz3k7ha-kicad-5.0.1/lib/kicad/plugins/3d

cc @berce

This had been fixed in 5.1.0: https://github.com/KiCad/kicad-source-mirror/commit/9490fd9d301b5ce3342d8b186c0ec2ea6f5fbda8
We should close this issue after having updated the package and tested.

This should work now with the new kicad-with-packages3d package.

you may need to rm .config/kicad/kicad_common so it'll update the paths there on the next start (or do so manually)


Stop escaping codeFence data-code-raw attribute data

This PR is a follow up for live markdown preview web PR as there was discovered a bug which prevent parsing when special character was inside codeFence fe. ``` one > two ```.
To fix this issue we shouldn't escape data inside codeFence data-code-raw attribute so the input and output of the parser will be the same for the react-native-live-markdown library
Fixed Issues
$ https://github.com/Expensify/App/issues/27977
Tests

What unit/integration tests cover your change? What autoQA tests cover your change?
There are already lots of unit tests present for covering this behaviour. All relevant ones were adjusted to new behaviour
What tests did you perform that validates your changed worked?
I've checked it on example app of react-native-live-markdown library which we are using for text input inside expensify app

To test the behaviour you should use example app of the react-native-live-markdown library. To do so:

change the expensify-common version inside /parser directory and reinstall dependencies (npm install)
build parser output file (npm run build)
Build and open example app on desired platform (iOS/Android/Web)
Type in code fence with special character inside it (fe. ``` one > two ```)
Verify that input is parsed as codeFence properly

QA

What does QA need to do to validate your changes?
What areas to they need to test for regressions?
There should be no regressions involved as I are only changing the behaviour of html attributed used only in react-native-live-markdown library. Any regression are possible only after new version of react-native-live-markdown library is present inside E/App

@robertKozik Is it possible to test this in NewDot now?
If not, I will approve this right away.


Update flake inputs and npins

Automated periodic update via create-pull-request GitHub action.

Closing as this is a test run.


fix: stop providing flat to ButtonDeprecatedBase in AccordionButton

Overview

Stop having AccordionButton provide flat: true by default to ButtonDeprecatedBase in the yellow theme.

Fix idea sourced from https://github.com/codecademy-engineering/Codecademy/pull/23849. It's redundant to always provide flat; individual themes provide their own extra props.
PR Checklist

[ ] Related to designs:
[x] Related to JIRA ticket: CET-655
[x] I have run this code to verify it works
[x] This PR includes unit tests for the code change

📬Published Alpha Packages:@codecademy/gamut-kit@0.3.42-alpha.a202cb.0@codecademy/gamut-labs@14.2.2-alpha.a202cb.0@codecademy/gamut@32.1.2-alpha.a202cb.0<EMAIL_ADDRESS>
🚀 Styleguide deploy preview ready!https://60819f070b81af00cc505af9--gamut-preview.netlify.appDeploy Logs


Remove console.log() from smalltime-app.mjs

Oh well, if forgotten in there that enormous PR fixes 😅
Issue: https://github.com/unsoluble/smalltime/issues/191#issue-1971049418

Thanks! I'll be pulling this change in while working on another thing shortly.


geo/geomfn: implement ST_RotateX

PR: https://github.com/cockroachdb/cockroach/pull/61326
From release notes:

ST_RotateX function is now available. [#61326][#61326] {% comment %}doc{% endcomment %}

Documented on functions and operators and mentioned elsewhere in docs via #10555


fixed UnixConnector for py3, fixed calling Handler constructor twice,…

Hi,
Thanks for the excellent python module!
I decided to use it for the RIPE Atlas dyndns project and came up with some fixes/improvements:

fixed UnixConnector.
fixed calling Handler constructor twice (mainloop, mainloop3)
options are passed to the Handler
context manager for Handler to have better control over freeing resources (db connections/files)
description and version are overridable.
implemented test for unix connector
works on py2 and py3

Thank you for your merge request, nice to see someone actually using this! =)

Yep. your module is really convenient and clean!

Final detail, can you squash your work so the interim commits go away? I can also use squash & merge button if you prefer.

squashed :)


fix debian provisioning bug with systemd

This fixes the systemd provisioning issue with Debian.
Fixes #1705

LGTM

Hello, still experiencing the issue with latest docker-machine :
docker-machine -v
docker-machine version 0.4.1 (e2c88d6)

In which release this fix will be available ?
thanks a lot !

Same as @anthonydahanne, I'm encountering the same issue with the same version version 0.4.1 (e2c88d6)

@anthonydahanne @zedtux Can you try with 0.5.1?

@dgageot it's working fine with version 0.5.1. :+1:

Thanks!


Upgrade to core22 + new upstream version

I ran the tests suggested in #2 and all of those work.
I see there's a convention or rule to avoid layouts, I've always solved the dri issues with layouts, please lmk if this is wrong/there is a better way to do this.
I see there are some changes pending to be made by #2 and I tried integrating them but Alacritty won't launch:
[destroyed object]: error 7: failed to import supplied dmabufs: Arguments are inconsistent (for example, a valid context requires buffers not supplied by a
thread 'main' panicked at 'failed to dispatch wayland event queue: Os { code: 71, kind: Uncategorized, message: "Protocol error" }', alacritty/src/event.rs:1438:30
note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace
Segmentation fault (core dumped)

@jssotomdz thanks a lot for looking into this!
When I build this PR and run it, I get the following error:
$ alacritty
cp: cannot stat '/snap/alacritty/x1/usr/share/mime': No such file or directory
Directory '/home/reservation/snap/alacritty/x1/.local/share/mime/packages' does not exist!
ERROR: update-mime-database /home/reservation/snap/alacritty/x1/.local/share/mime exited abnormally with status 1
libEGL warning: MESA-LOADER: failed to open iris: /snap/core20/current/lib/x86_64-linux-gnu/libc.so.6: version `GLIBC_2.33' not found (required by /lib/x86_64-linux-gnu/libedit.so.2) (search paths /snap/alacritty/x1/usr/lib/x86_64-linux-gnu/dri, suffix _dri)

libEGL warning: MESA-LOADER: failed to open swrast: /snap/core20/current/lib/x86_64-linux-gnu/libc.so.6: version `GLIBC_2.33' not found (required by /lib/x86_64-linux-gnu/libedit.so.2) (search paths /snap/alacritty/x1/usr/lib/x86_64-linux-gnu/dri, suffix _dri)

libEGL warning: MESA-LOADER: failed to open iris: /snap/core20/current/lib/x86_64-linux-gnu/libc.so.6: version `GLIBC_2.33' not found (required by /lib/x86_64-linux-gnu/libedit.so.2) (search paths /snap/alacritty/x1/usr/lib/x86_64-linux-gnu/dri, suffix _dri)

libEGL warning: MESA-LOADER: failed to open swrast: /snap/core20/current/lib/x86_64-linux-gnu/libc.so.6: version `GLIBC_2.33' not found (required by /lib/x86_64-linux-gnu/libedit.so.2) (search paths /snap/alacritty/x1/usr/lib/x86_64-linux-gnu/dri, suffix _dri)

Error: Error creating GL context; eglInitialize failed

This is on a laptop with 22.04 and Intel integrated graphics. What did you use to test this?


Swift 3 support

Is anyone working on Swift 3 support? If not I am ready to jump on this task.

It seems no source-code changes needed this time, only project file settings change.

After further investigation it seems nothing need to be done, just documentation need to be updated that current cocoapods seamlessly works with Swift 3 :) 🎉

I am actually having a bit of an issue with my Swift 3 project and wanted to know if you might be able to provide some insight. This issue I am seeing is a compiler waring message, which does not prevent the app from compiling and running, but I wanted to see if there is a way to fix whatever is causing the compiler warning message. This is the message I am seeing. There are a total of 116 compiler warnings for 4 gauges that are in the app I am building. Researched the error with no luck so far. Any ideas? So far the only thing I have done is create the views for the gauges, changed the class to Gauge, connected the outlets to the TableView Controller Custom Cell, and this is what I am seeing.

warning: IB Designables: Ignoring user defined runtime attribute for key path "borderWidth" on instance of "GaugeKit.Gauge". Hit an exception when attempting to set its value: [<GaugeKit.Gauge 0x7f98e5e7fb70> setValue:forUndefinedKey:]: this class is not key value coding-compliant for the key borderWidth.
warning: IB Designables: Ignoring user defined runtime attribute for key path "endAngle" on instance of "GaugeKit.Gauge". Hit an exception when attempting to set its value: [<GaugeKit.Gauge 0x7f98e5e7fb70> setValue:forUndefinedKey:]: this class is not key value coding-compliant for the key endAngle.

It seems IBDesignable related issue (http://stackoverflow.com/questions/26656400/uibutton-with-ib-designable-throws-runtime-attribute-warning-and-does-not-render), I am not using this feature of GaugeKit in my code, so do not have such warnings. Please, post results of your investigation here, so we can fix it.

ps closing this issue for now as there are no blocking issues with use of GaugeKIt with Swift 3.


fatled to sufficiently increase receive buffer size (was: 208 kiB, wanted: 7168 kiB, got: 416 kLB). See h ttps://github.com/quic-go/quic-go/wiki/UDP-Buffer-Sizes for details.

a new ipfs node (kubo v0.31.0) when started yields this error in docker environment:
fatled to sufficiently increase receive buffer size (was: 208 kiB, wanted: 7168 kiB, got: 416 kLB). See https://github.com/quic-go/quic-go/wiki/UDP-Buffer-Sizes for details.

The explanation is here:
https://github.com/quic-go/quic-go/wiki/UDP-Buffer-Sizes
Actions to do:

Investigate if this error has any impact on Light Client execution.

sudo sysctl -w net.core.rmem_max=8388608
sudo sysctl -w net.core.wmem_max=8388608


Our hero needs hit points!

Resolved in #21 ! Should probably do something with all these hit points though like 1) display them and 2) maybe decrement them when you hit a bomb.


just: 0.5.11 -> 0.6.0

Motivation for this change
Update just to the latest release.

https://github.com/casey/just/releases/tag/v0.6.0

Things done

[ ] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
Built on platform(s)

[x] NixOS
[ ] macOS
[ ] other Linux distributions

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
[x] Tested execution of all binary files (usually in ./result/bin/)
[ ] Determined the impact on package closure size (by running nix path-info -S before and after)
[ ] Ensured that relevant documentation is up to date
[x] Fits CONTRIBUTING.md.

@danieldk Thank you!


Change LIneA logo, css firefox and centralize logo DESI vertically

Change the LIneA logo, fix the Pipelines css Cross-browser and centralize logo DESI vertically in the header

I think this PR is a good place to fix the screen fit issue:


Add Llava MultiModal QA examples for Tesla 10k RAG

Description
Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.
Fixes # (issue)
Type of Change
Please delete options that are not relevant.

[ ] Bug fix (non-breaking change which fixes an issue)
[x] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[ ] This change requires a documentation update

How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

[ ] Added new unit/integration tests
[x] Added new notebook (that tests end-to-end)
[ ] I stared at the code and made sure it makes sense

Suggested Checklist:

[x] I have performed a self-review of my own code
[ ] I have commented my code, particularly in hard-to-understand areas
[ ] I have made corresponding changes to the documentation
[ ] My changes generate no new warnings
[ ] I have added tests that prove my fix is effective or that my feature works
[ ] New and existing unit tests pass locally with my changes
[ ] I ran make format; make lint to appease the lint gods

@hatianzhang sorry just to clarify the second example doesn't seem to change. is this intentional?

@jerryjliu the 1st example is Tesla super charger and 2nd examples is Tesla Shanghai factory.
The results from LlamaIndex for both examples are different.
Do I misunderstand ?

@jerryjliu thanks for pointing it out. Now fixed!

@jerryjliu thanks for feedback. Made the last change and now it should be good.
Separate the query engine and response results. now it is more clear


iOS ConversationsClientConversationUpdated is fired?

Hi,
I am working on iOS implementation and I am trying to get to be fired on ConversationsClientConversationUpdated() in a class that inherited from TwilioConversationsClientDelegate class.  But it seems not being fired.
I have checked :
ConversationsClientSynchronizationStatusUpdated() is fired and status can get ConversationsListCompleted.  In my test app, A sender sends a message to a receiver, and I can see the message in both app. However ConversationsClientConversationUpdated(TwilioConversationsClient client, TCHConversation channel, TCHConversationUpdate updated) is not fired at the time of sending out.
I also checked official document but it does not help for me and binding seems setup in this repo.
Could you help me how I can fire that method?
Any help would be really thank you.

Hi @NishiokaTakeo
First of all, you're supposed to wait for Completedstatus instead of ConversationsListCompleted before using the client.
Secondly, can you confirm that ConversationListener.OnConversationUpdated is called in the Android app when a message is sent?

Hi @jedusei
Thank you for replying. Yes. I have waited for Completed status and sends a message. Also ConversationListener.OnConversationUpdated is called in Android project.

Hi @NishiokaTakeo
Alright, I'll investigate the issue on iOS. It will take a little longer to debug this issue because my MacBook is not readily available.
If you're just using ConversationsClientConversationUpdated to do something when a message is sent, then consider using ConversationsClientMessageAdded as an alternative, and let me know how that goes.

Hi @jedusei
I will also try to investigate for this. If you have any idea I can investigate, I will do it.

If you're just using ConversationsClientConversationUpdated to do something when a message is sent, then consider using ConversationsClientMessageAdded as an alternative, and let me know how that goes.

It was not fired. It might be related to the client instance is in DI, not present as variable in my screen. I will try it.

Hi @jedusei ,
Self managed this issue. It seems delegate instance must be created/defined in same class instance.
This will not call for these events.
TwilioConversationsClient.ConversationsClientWithToken(
                token,
                new TwilioConversationsClientProperties(),
                new TwilioClientDelegate(),  <--- define the implementation of delegates in other class
                (result, chatClient) => /* do something */;

This will call for these events
TwilioConversationsClient.ConversationsClientWithToken(
                token,
                new TwilioConversationsClientProperties(),
                this, <--- define the implementation of delegates in same class
                (result, chatClient) => /* do something */;

Not sure why first one does not work. But anyway, I have got the solution. Thank you :)


[ID-895] Prevent stale requests from signing out the user.

Jira Ticket: https://broadworkbench.atlassian.net/browse/ID-895
Summary of changes:
Prevented stale requests from signing out the user.
When a request completes with a failure and fails to load a new auth token, if the authToken used for the requests different from the current authToken, that means that a new token has already been gotten (user has signed in again) and we should not signOut the user again.
Why

This will help address the multi-login issues.

I also wonder if the store updates in loadOidcUser and reloadAuthToken are clobbering each other?


Iterators over nodes should be allowed to error?

Related: #114
The Item type of all these iterators is tsk_id_tt, but it should be Result.

Closing for now.  Can reopen if we ever have an issue.


documentation links to Github teams are not public

📚 Documentation
In the napari docs on governance, there are links to Github teams, but these links are not public.
For example, in the "core developers" section, core developers are not listed, but instead a link is provided to https://github.com/orgs/napari/teams/core-devs. However, as a member of the public, this link returns a 404 error for me.
Suggested changes:

Remove links to Github teams for the Steering Council and Core Develoeprs
Explicitly list core developers in governance docs

This is a duplicate of #1190, we were going to fix during the website reorg, but that's still in progress, so we should just do a quick fix now. we can leave both this and #1190 open till that's done

@neuromusic : as part of #1190 there were some updates to this as the core developers are listed now, though that needs to be kept in sync. But the links to the GitHub teams (core-devs and steering council) are still present.
If I try to open these in a Chrome incognito window, then GitHub asks me to login. If I'm logged in to this account, then I can see both, but then I'm a member of the napari organization and the core-devs team.
If you could try out the behavior from your side, maybe we could close this now? Or if based on that behavior, you still think we should remove the team links, then I guess this should stay open.

I'm also a member of the napari org & the behavior for me is the same.
So I'm not sure what the behavior is like for someone logged into Github but not a member of the napari org.

I had @junxini test this as someone with a GitHub account, but not currently a member of the napari organization.
They can see the napari organization fine, but get a 404 for the core-devs and steering council teams.
So leaving this open for now.
I'm not an admin/owner of the napari org, but I might check with someone who is to see if we could just make those teams public if that's possible. Seems like an alternative to removing the links, which are fairly useful and represent the best source of truth in terms of actual control of the repos.

Seems like making teams public is not supported yet: https://github.community/t/why-is-my-github-team-isnt-visible-to-anyone-outside-my-organization/251617
There's some related discussion in #1190 and #816 around whether to keep the team links or not. I don't feel strongly as the core dev members and steering council are listed and linked to, but if someone else does feel free to pick up this issue and open a PR that removes them.

Seems like making teams public is not supported yet: https://github.community/t/why-is-my-github-team-isnt-visible-to-anyone-outside-my-organization/251617

Yes this is unfortunately no supported.
I think we should open a PR to remove links that don't work when not logged in and replace them with links to the about page in the napari.org site. Maybe @chili-chiu can make sure this is on the radar for the docs working group. should be a very minimal PR. Thanks!!!

The project and team page now lists people rather than linking to the problematic GitHub pages.
I'm going to close, we have a related issue at the docs repo.


Add Unicode installer option (global)

Give users the option to make a unicode installer. By default it's disabled
because it's incompatible with older versions of Windows (see
http://nsis.sourceforge.net/Docs/Chapter1.html#intro-unicode). The option itself
is documented at http://nsis.sourceforge.net/Docs/Chapter4.html#aunicodetarget.

This targets https://github.com/ndmitchell/nsis/issues/6, should we add a note to the functions using NSIS 3?

@jmitchell - thanks for the patch!
@domenkozar - good idea!

@ndmitchell Certainly. Thank you for maintaining the project--it's very useful!
Regarding the note for NSIS 3 functions would you simply like a comment, an ADT specifically for them, or both?

Dunno - what do people suggest? One option would be to say that we expect people to be using NSIS, and call out the first few things that violate that assumption, but then very quickly just make it "the default". A static check seems overkill since we immediately compile the NSIS binary, and that will show it up pretty quickly.

I think nowadays anyone would just use 3.0, but best to note what's not supported there for those few unlucky devs :)

Merged, and I added a small note.


Upgrade babel-preset-react-app to v2

Upgrade babel-preset-react-app to version 2.x.x, which uses babel-preset-env instead of the deprecated babel-preset-latest.
This enables depending modules to get rid of the following warning on npm install (when using the @kadira/storybook module).
npm WARN deprecated<EMAIL_ADDRESS>💥  preset-latest accomplishes the same task as babel-preset-env. 🙏  Please install it with 'npm install babel-preset-env --save-dev'. '{ "presets": ["latest"] }' to '{ "presets": ["env"] }'. For more info, please check the docs: http://babeljs.io/docs/plugins/preset-env 👌. And let us know how you're liking Babel at @babeljs on 🐦

Haha. I just came here to post this!

@fstoerkle I want to thank you for your contribution! I'm working on a large shift in a new repo and have actually updated/upgraded every single dependency we have to the latest. So that includes babel, webpack everything. I hope you don't mind me closing this PR.


Chaotic Feat: I feel i can add some crazy dancing emojis on the same page to make it  chaotic.

Describe your chaotic idea
Chaotic Feat: I feel i can add some crazy dancing emoji on the same page around the text to make it more chaotic.
Add Screenshots or Sketches
![Screenshot from 2024-10-30 23-39-22](https://github.co@vansh-codes er-attachments/assets/dfa6387b-6aea-4e8e-84c6-cf022df69ab1)
@vansh-codes help me work on this.
Confirm

[X] I understand that my idea will add to the chaos and I'm okay with it
[X] I agree to follow this project's Code of Conduct
[X] I want to work on this feature
[ ] I'm GSSOC'24 Extd registered Contributor
[X] I'm Hacktoberfest registered Contributor

go ahead, but you should've done it in the same issue and PR


#106 - Fix the Seams

Closes #106
This uses option 4 among those listed.  I still agree with Jim that option 2 is the more elegant/correct, and least hackish, but decided to try option 4 because this has been on our todo list since mid-February, is our most visible UI issue, and option 2 sounds complex enough no one has tried it.
Surprisingly, a 0.1% increase in the texture area solved the problem and it looks pretty darn good.
I'm not opposed to switching to option 2 some day, but in the meantime I think this is a worthwhile improvement.

Going ahead and merging as there are no objections.  If we want to go with a more elegant solution later, that's great too, but a seamless experience in the meantime will be nice.


merger the view_application and alocate menu

after discussing the view application and allocate application menu, according to the results of the discussion I have made allocate Housing a feature with view_application, HF will only be able to see and allocate the app with a new or waitlist status

Ok wait i will merge it

i think there are some issues because you delete some file.. i will contact you later


Fixes broken diff test cases

All test cases work again. One failure was an actual bug, which did not occur in the real environment, though, as it was only an issue if plain text without a wrapping HTML-element was used for the diff.
Now it should be possible to add the Karma-based tests to Travis.

@CatoTH Travis failed with error:
JSHint failed for: openslides/motions/static/js/motions/diff.js

@emanuelschuetze Travis-Error is fixed.
Now this PR also fixes the JS-Exception:
TypeError: Failed to execute 'insertBefore' on
'Node'

Retested. Now the new words are shown but the whole line is marked as "added" (green), see example:

I don't really see this as a regression. Inserted paragraphs were subject to line numbering before as well. The inserted line break happens because the added words exceeds the maximum line length.
I can disable line breaks in inserted paragraphs, of cause - but I'm not sure this really improves the readability of the text... or did I miss the problem?
I can't reproduce the bug of the word vanishing in the PDF. Can you maybe send me your database with the bug?

To illustrate the problem with cases like that:
We have two tokenized strings:
Before:
['
', 'rief ', 'sie ', 'alle ', 'sieben ', 'herbei ', 'und ', 'sprach ', ''liebe ', 'Kinder, ', 'ich ', 'will ', 'hinaus ', 'in ', 'den ', 'Wald, ', 'seid', '
']
After:
['
', 'rief ', 'sie ', 'alle ', 'sieben ', 'herbei ', 'und ', 'sprach ', ''liebe ', 'Kinder, ', 'ich ', 'will ', 'hinaus ', 'in ', 'den ', 'Wald, ', 'seid ', 'Noch', '
', '
', 'Test ', '123', '
']
It seems somewhat impossible to me to teach a diff algorithm to leave the middle
 untouched, while inserting the words before and the ones after.
The possible solution would be:

Split the "Before" and "After" Strings into arrays of block elements, each. In the example above, that would be one block element for "Before", and two for "After".
Try to match the block elements by similarity, so we can guess which one has only by slightly altered and which ones have been inserted / deleted.
Perform the inline diff only on those lines that are slightly altered.

As discussed with @CatoTH this behavior is ok (no inline diff for paragraphs).

@emanuelschuetze not for today :)

Just for not: Sill open is the regression which you already fixed in #3044. Any idea why this is broken again?

@normanjaeckel Please merge.

@emanuelschuetze how can I see the regression regarding STRIKE? The test case is still passing...

@CatoTH

how can I see the regression regarding STRIKE? The test case is still passing...

show a removed paragraph in pdf (the line numbers are also removed - this was fixed with #3044), see example:


Feature/patch gtest death test

Relates to issue #39

It looks like appveyor's windows environment does not support death tests:
See line 1076 in https://ci.appveyor.com/project/cyrush/blt/build/1.0.99/job/dj3f1365yn72vq3m#L1076
4/6 Test #4: blt_gtest_death_test_smoke .......***Failed    0.03 sec
  Running main() from gtest_main.cc
  [==========] Running 1 test from 1 test case.
  [----------] Global test environment set-up.
  [----------] 1 test from blt_gtest_smoke
  [ RUN      ] blt_gtest_smoke.death_test
  Running main() from gtest_main.cc
C:\projects\blt-test\blt\tests\blt_gtest_death_test_smoke.cpp(57): error : Death test: ((void)0) [C:\projects\build\RUN_TESTS.vcxproj]
      Result: failed to die.
EXEC : error msg:  [C:\projects\build\RUN_TESTS.vcxproj]
  [  DEATH   ]
  [  FAILED  ] blt_gtest_smoke.death_test (7 ms)
  [----------] 1 test from blt_gtest_smoke (7 ms total)

  [----------] Global test environment tear-down
  [==========] 1 test from 1 test case ran. (7 ms total)
  [  PASSED  ] 0 tests.
  [  FAILED  ] 1 test, listed below:
  [  FAILED  ] blt_gtest_smoke.death_test

   1 FAILED TEST

I should be able to fix the appveyor builds by adding the following to the configuration line (line 26 in appveyor.yml)
cmake ...  -DBLT_C_FLAGS="-DGTEST_HAS_DEATH_TEST=0"  -DBLT_CXX_FLAGS="-DGTEST_HAS_DEATH_TEST=0"  ...

@white238 -- In my test configuration, I disabled death tests using a global BLT_CXX_FLAGS variable.  I.e.
set(BLT_CXX_FLAGS -DGTEST_HAS_DEATH_TEST=0 CACHE PATH "")

Now that we have the transitive dependencies working properly, is there a better way to only add the flags to the google test targets?
Note: We do not (currently) have a direct blt option for this, so it would have to be something that  can be set in the appropriate host-config file, or passed directly to cmake when configuring a build.

I think we should handle this better - if the death test is unsupported by the compiler, it should be disabled without having to pass a flag...

Since death tests have issues multiple platforms -- I think the most conservative solution is to disable gtest death tests by default, and have folks pass a flag if they want to opt into them.
 -DGTEST_HAS_DEATH_TEST=1
We aren't sure what other platforms are going to have issues with death tests.  Out of the several hundred tests in the toolkit I think we have a handful of that are death tests. It would be better to not use death tests than to try to support for such a little payoff.

@cyrush and @davidbeckingsale -- based on your comments, and the way that gtest-port.h is set up, it sounds like we need a BLT option to enable death tests.
I will add BLT_ENABLE_DEATH_TESTS as an option that is off by default to BLTOptions.cmake and mark is as advanced.

@kennyweiss following our discussion -- I am on board with the option (and the one for the mpi stuff as well)

If we know which systems death tests definitely fail with, perhaps we can check for them if the option is enabled, and fail at CMake time with an error?

@davidbeckingsale -- I think the safest and simplest thing is to disable the death tests by default, and only enable them when we know they are valid.  This should lead to the fewest surprises.
gtest has some code to check for the platform, but the granularity is not high enough for us.  E.g. bg/q (and bash for windows) are identified as linux (where death tests work), but we want to disable it there.  Similarly, appveyor is marked as windows (where death tests work), but doesn't appear to support death tests either.

Okay, that makes sense to me.