fix: opening assigned FAP on a proposal after closing proposal view modal and improve menu drawer re-opening on tablet/mobile view when switched from desktop

Description
This pull request fixes the issue related to opening assigned FAP on a proposal after closing the proposal view modal and improves the menu drawer re-opening on tablet/mobile view when switched from desktop view.
Motivation and Context
The changes are required to enhance user experience and eliminate bugs related to the UI on different devices. It resolves the problem of the drawer not being able to re-open when switching from desktop to mobile view and the assigned FAP not opening on a proposal after closing the proposal view modal.
Changes
The main changes introduced in this PR are:

Added a setTimeout function in the useEffect hook in the Dashboard component to fix the bug where the drawer cannot be re-opened when switching from desktop to mobile view.
Updated the variable name from 'Faps' to 'faps' in various components and hooks to maintain consistency and readability.
Added 'fapId' to the 'fromProposalToProposalView' function in helperFunctions to fetch the 'fapId' from the proposal.

https://github.com/UserOfficeProject/user-office-core/assets/6333063/bded3db0-af46-4504-823e-c1d46746f2e0
How Has This Been Tested?

manual tests
e2e tests

Fixes Jira Issue
https://jira.esss.lu.se/browse/
Depends On

Tests included/Docs Updated?

[ ] I have added tests to cover my changes.
[ ] All relevant doc has been updated

The changes looks fine to me. Just trying to understand in what circumstances would we need this feature. Does the status of opened modal or drawer stays open when user switch their physical laptop to physical mobile phone?

One of the main reasons behind this was improving the experience for developers because if you are on a smaller screen (laptop for example) and open the browser debugging console it usually shrinks down to a mobile/tablet view and the menu drawer cannot be opened again for navigation which is a bit annoying.
The other reason or scenario could be if somebody uses tablet for example and opens the app in landscape view then rotates to a portrait view. Then we end up in the same situation where the menu is not accessible.
Thanks for your question @Junjiequan it's always nice to have some more explanation about why this is needed.

The changes looks fine to me. Just trying to understand in what circumstances would we need this feature. Does the status of opened modal or drawer stays open when user switch their physical laptop to physical mobile phone?

One of the main reasons behind this was improving the experience for developers because if you are on a smaller screen (laptop for example) and open the browser debugging console it usually shrinks down to a mobile/tablet view and the menu drawer cannot be opened again for navigation which is a bit annoying. The other reason or scenario could be if somebody uses tablet for example and opens the app in landscape view then rotates to a portrait view. Then we end up in the same situation where the menu is not accessible.
Thanks for your question @Junjiequan it's always nice to have some more explanation about why this is needed.

I didn't think of the scenerio where user enabled auto-rotate on tablet and accidently changed view, that's a very good point 👍   Thanks for the detailed answer !


Make automatic root node naming in "create new scene" dialog follow naming settings

Resolves #78946.
In the "Create New Scene" dialog, if the root name is left empty and we set it to the scene filename, then also adjust the case depending on the editor settings for naming cases.

Superseded by #79756


Lock fields if they have been proofread

If a field (volpiano, or fulltext MS spelling, or fulltext standardized spelling) has been proofread, the field should be locked to prevent further editing.
This should apply both to normal editors/transcribers and to proofreaders themselves. If a proofreader wants to edit a field that has already been proofread, they would need to uncheck the "proofread" checkbox, make their edit, and then tick the checkbox again to prevent further editing by other users.

I understand the feature, as described in the comment above, was requested by Debra. A further thought:
Should the metadata fields also be locked for certain groups of users? For example, a simple editor should probably not be able to change the genre/feast of a chant. They probably shouldn't be able to modify which  folio the chant is on either, or its sequence number on the page (though I do remember occasionally having to add chants and modify their folios and sequence numbers in the course of doing transcribing work years ago). This may be worth asking Debra!

Yes, do ask Debra.
It's great have future enhancements as issues.
The main task at hand is to mostly replicate the Old Cantus DB.

Should the metadata fields also be locked for certain groups of users? For example, a simple editor should probably not be able to change the genre/feast of a chant.
I'm not sure about this. Genre, maybe; but there are chants that appear on multiple feasts, and what populates the field by default might not be right. Or It's been populated according to what feast you were editing previously, and you need to change it to what comes next...

They probably shouldn't be able to modify which folio the chant is on either, or its sequence number on the page (though I do remember occasionally having to add chants and modify their folios and sequence numbers in the course of doing transcribing work years ago).
Adding chants does mean changing a lot of sequence numbers. Or realizing that you forgot to change the folio field to 12v, and the sequence numbers are still counting from 12r...seems like a fairly common error that we want even low-level editors to be able to fix.

If a user has editing access to a certain chant/source object, they should be able to edit everything associated with that object. As Anna mentioned, the contributors could make mistakes in filling the metadata, and they should have the power to fix those mistakes by themselves.


remove MSA installNS on ManagedClusterAddOn

Do not set spec.installNamespace on managed-serviceaccount ManagedClusterAddOn when creating it.
For: https://issues.redhat.com/browse/ACM-6967

@zhujian7  Could I get you to take a look at the change in pre_backup.go and let me know if this is ok?  Essentially if the managedclusteraddon for managed-serviceaccount does not already exist, this change will create a new one and NOT set spec.installNamespace.
This assumes the managed-serviceaccount ManagedClusterAddOn controller will handle this and properly set the default. Is that assumption correct?

I think we were hoping to commit this change relatively soon as the ODF team is doing testing using pre-release ACM 2.9 and would like the change.

OK, got it, I am working on it for 2.9 train 5

I am working on it https://github.com/open-cluster-management-io/managed-serviceaccount/pull/74 train 5

based on the new discussion, I don't think we can fix this in Train 5

/lgtm

/cherry-pick release-2.8

/cherry-pick release-2.7


Added proper if/else flow and added cronjob fix

Hi again! I noticed this morning that our cronjobs were never executing due to the missing EXTERNAL_PASSWORD coming from the deployment files. I've added that in this PR.
Also fixed the if/else statements so they make sense 👍

This looks good to me, thanks again!


'.MySportsFeedsEnv' does not appear to be initialized

> library("mysportsfeedsR", lib.loc="~/R/x86_64-pc-linux-gnu-library/3.4")
> authenticate_v1_0("znmeb", "notmyrealpassword")
Error in .MySportsFeedsEnv$data$username <- username :
  object '.MySportsFeedsEnv' not found
>

Should there be some code to create .MySportsFeedsEnv if it doesn't exist?

Yes, and it's in zzz.R, which is supposed to run automatically.  Doesn't seem to be doing that for everyone though.

I'm on Linux, if it matters.

Not sure, but you can work around it for now by copy/pasting what's in the zzz.R script.

Yeah ... I tried moving zzz.R into the "R" directory and reinstalling - that didn't work. I'm on R 3.4.1

I'm getting this error as well. I suspect that because I just signed up the MySportsFeeds username/password isn't active yet. I followed the README with these commands:
devtools::install_github("MySportsFeeds/mysportsfeeds-r")
library(mysportsfeedsR)
authenticate_v1_0('USERNAME', 'PASSWORD')
It resulted in this message:
Error in .MySportsFeedsEnv$data$username <- username :    object '.MySportsFeedsEnv' not found
Any help is greatly appreciated, @bradbarkhouse. Thanks!

The workaround of copy/pasting what's in the zzz.R script didn't seem to work either (fyi). I tried to figure it out. :)

@aqsmith08 you'd only need to copy/paste the inside of the onLoad() handler, lines 2-7.  Essentially all it does is establish a new environment variable named .MySportsFeedsEnv.  Still need to figure out why that zzz.R script doesn't automatically initialize itself.

Thanks. That worked. I pasted and ran these commands in my R script:
.MySportsFeedsEnv <- new.env()
.MySportsFeedsEnv$data <- list(   v1_0_username <- "USERNAME",   v1_0_password <- "PASSWORD")
authenticate_v1_0('USERNAME', 'PASSWORD')
This worked.

I was able to fix this by moving the zzz.R file into R folder and changing the first line to:
.MySportsFeedsEnv <<- new.env()
.MySportsFeedEnv should now load in the global environment when the package is loaded.


TagBot trigger issue

This issue is used to trigger TagBot; feel free to unsubscribe.
If you haven't already, you should update your TagBot.yml to include issue comment triggers.
Please see this post on Discourse for instructions and more details.
If you'd like for me to do this for you, comment TagBot fix on this issue.
I'll open a PR within a few hours, please be patient!

Triggering TagBot for merged registry pull request: https://github.com/JuliaRegistries/General/pull/70753

Triggering TagBot for merged registry pull request: https://github.com/JuliaRegistries/General/pull/118378


Wrong Version Causing Daily Updates - again

There appears to be another issue with the internal version not matching the most recent version name causing the update to run every day...  Am I correct?
root@ER8-XG:/config/scripts# ./get_wireguard.sh
[INFO] Board model: EdgeRouter Infinity
[INFO] Board type: e1000
[INFO] Board repo mapping: e1000
[INFO] Firmware version: v2.0.9-hotfix.1.5371034.210122.1014
[INFO] Installed WireGuard version: 1.0.20210219-1
[INFO] Release version: 1.0.20210219-2
[INFO] Debian package URL: https://github.com/WireGuard/wireguard-vyatta-ubnt/releases/download/1.0.20210219-2/e1000-v2-v1.0.20210219-v1.0.20210223.deb
Downloading WireGuard package...
Checking WireGuard package integrity...
Backing up running configuration...
Removing running WireGuard configuration...
Removing WireGuard module...
Installing WireGuard...
Restoring previous running configuration...
Enabling WireGuard installation after firmware update...
WireGuard has been successfully installed.
root@ER8-XG:/config/scripts# ./get_wireguard.sh
[INFO] Board model: EdgeRouter Infinity
[INFO] Board type: e1000
[INFO] Board repo mapping: e1000
[INFO] Firmware version: v2.0.9-hotfix.1.5371034.210122.1014
[INFO] Installed WireGuard version: 1.0.20210219-1
[INFO] Release version: 1.0.20210219-2
[INFO] Debian package URL: https://github.com/WireGuard/wireguard-vyatta-ubnt/releases/download/1.0.20210219-2/e1000-v2-v1.0.20210219-v1.0.20210223.deb
Downloading WireGuard package...
Checking WireGuard package integrity...
Backing up running configuration...
Removing running WireGuard configuration...
Removing WireGuard module...
Installing WireGuard...
Restoring previous running configuration...
Enabling WireGuard installation after firmware update...
WireGuard has been successfully installed.
root@ER8-XG:/config/scripts#

Issue addressed here: https://github.com/WireGuard/wireguard-vyatta-ubnt/issues/68
And now resolved.


Driver in the node deals with ConfigMaps now

This is seen at https://prow.ci.openshift.org/view/gs/origin-ci-test/pr-logs/pull/openshift_vmware-vsphere-csi-driver/12/pull-ci-openshift-vmware-vsphere-csi-driver-master-e2e-vsphere-csi/1417212289345392640
CC @openshift/storage

/hold
for testing

/lgtm
if your test pass

/hold cancel
I was able to create a volume and attach it to a node.


router: 1.50.0 -> 1.51.0

Automatic update generated by nixpkgs-update tools. This update was made based on information from https://github.com/apollographql/router/releases.
meta.description for router is: Configurable, high-performance routing runtime for Apollo Federation
meta.homepage for router is: https://www.apollographql.com/docs/router/
Updates performed

Rust version update

To inspect upstream changes

Release on GitHub

Compare changes on GitHub

Impact
Checks done

built on NixOS
The tests defined in passthru.tests, if any, passed
found 1.51.0 with grep in /nix/store/1cxxzmxnp4iaq6g7jj89iy2bwn2pcrcq-router-1.51.0
found 1.51.0 in filename of file in /nix/store/1cxxzmxnp4iaq6g7jj89iy2bwn2pcrcq-router-1.51.0

Rebuild report (if merged into master) (click to expand)

2 total rebuild path(s)

2 package rebuild(s)

First fifty rebuilds by attrpath

router

Instructions to test this update (click to expand)

Either download from Cachix:
nix-store -r /nix/store/1cxxzmxnp4iaq6g7jj89iy2bwn2pcrcq-router-1.51.0 \
  --option binary-caches 'https://cache.nixos.org/ https://nix-community.cachix.org/' \
  --option trusted-public-keys '
  nix-community.cachix.org-1:mB9FSh9qf2dCimDSUo8Zy7bkq5CX+/rkCWyvRCYg3Fs=
  cache.nixos.org-1:6NCHdD59X431o0gWypbMrAURkbJ16ZPMQFGspcDShjY=
  '

(The Cachix cache is only trusted for this store-path realization.)
For the Cachix download to work, your user must be in the trusted-users list or you can use sudo since root is effectively trusted.
Or, build yourself:
nix-build -A router https://github.com/r-ryantm/nixpkgs/archive/5cb15119487992f7415afe2ac49d372c68f83a98.tar.gz

Or:
nix build github:r-ryantm/nixpkgs/5cb15119487992f7415afe2ac49d372c68f83a98#router

After you've downloaded or built it, look at the files and if there are any, run the binaries:
ls -la /nix/store/1cxxzmxnp4iaq6g7jj89iy2bwn2pcrcq-router-1.51.0
ls -la /nix/store/1cxxzmxnp4iaq6g7jj89iy2bwn2pcrcq-router-1.51.0/bin

Pre-merge build results
We have automatically built all packages that will get rebuilt due to
this change.
This gives evidence on whether the upgrade will break dependent packages.
Note sometimes packages show up as failed to build independent of the
change, simply because they are already broken on the target branch.
Result of nixpkgs-review run on x86_64-linux 1

1 package built:

router

Maintainer pings
cc @bbigras for testing.

Result of nixpkgs-review pr 327826 run on aarch64-darwin 1

1 package marked as broken and skipped:

router


Bug Casting JValue Integer to boolean

Hello,
Lately I found a weird behavior of this library. To be more precise, below assert is not included in tests JTokenTests.cs
Assert.AreEqual(false, (bool)(new JValue(2)));

Also if you try to add it, it`s gonna fail.

That's correct. Any int value over zero is true.


The methods are missing return type hints

Since version Version 3.5 Python support type hints for the return type of functions[1].
I'm unsure about their widespread use, but I would encourage using them none the less.
After approval of some people involved in the project, I might fork it and implement the obvious type hints.
Sincerely,
Aaron
[1]https://docs.python.org/3/library/typing.html

Good point. Let's do that!


filter secret informer to reduce cache size

fix issue: https://issues.redhat.com/browse/ACM-5873

/retest

/hold
waiting for 2.3.z to open

/retest e2e

/retest

/unhold


GET image from DDP.js

Hi,
I'm using a React Native application with your great plugin.
In my web app, I can use the url() function to get something like :
/cfs/files/imagesFiles/FILE_ID?token=MYTOKEN
In my React-Native application, I can only access to the imageFile _id.
So I generate an url like the one above, but :

It seems that MYTOKEN does not match with Meteor.loginToken in my web app when generated with url()
It seems that my react native application does not pass into the download validation function.

Thank you !

Is this related to #711 ?

Not really, but I forgot to tell that I found a solution to generate the good token.
const url = '/cfs/files/imagesFiles/'+imageFile.$value._id+'?token='+btoa(JSON.stringify({authToken: token}));


Error: Cannot find module 'tslint/lib/lint' when trying to extend tslint-microsoft-contrib

This is our environment
> \node_modules\.bin\tslint --version
4.0.1

> npm install --save-dev tslint-microsoft-contrib
`--<EMAIL_ADDRESS>
This is our tslint.json configuration.
{
    "extends": [
        "./node_modules/tslint-microsoft-contrib/tslint.json"
    ]
}

This is what happens when we run our local tslint with that configuration.
> node_modules\.bin\tslint --config .\tslint.json --project .\tsconfig.json
module.js:471
throw err;
^

Error: Cannot find module 'tslint/lib/lint'
    at Function.Module._resolveFilename (module.js:469:15)
    at Function.Module._load (module.js:417:25)
    at Module.require (module.js:497:17)
    at require (internal/module.js:20:19)
    at Object.<anonymous> (C:\myApp\node_modules\tslint-microsoft-contrib\insecureRandomRule.js:7:12)
    at Module._compile (module.js:570:32)
    at Object.Module._extensions..js (module.js:579:10)
    at Module.load (module.js:487:32)
    at tryModuleLoad (module.js:446:12)
    at Function.Module._load (module.js:438:3)

How can we run tslint on a configuration that extends tslint-microsoft-contrib?
See also: https://stackoverflow.com/questions/40749996/error-cannot-find-module-tslint-lib-lint-when-trying-to-extend-tslint-microso
We have done a find-replace of tslint/lib/lint with tslint, which resolves the above error but causes another one:
Error:
            Could not find implementations for the following rules specified in the configuration:
            no-duplicate-key
use-strict
label-undefined
no-constructor-vars
no-unreachable
            Try upgrading TSLint and/or ensuring that you have all necessary custom rules installed.
            If TSLint was recently upgraded, you may have old rules configured which need to be cleaned up.

duplicate #313

@Delagen Given that doing a a find-replace of tslint/lib/lint with tslint resolves the problem, would this repository welcome a PR that includes that fix?

@shaunluttin Let's move the discussion to #313

closing as duplicate... but thank you for taking the time to submit this bug report, especially with so much detail. This is one of the nicest bug reports I've ever seen!


Support submission of json and STDIN from Argo cli

FEATURE REQUEST
Would like the ability to submit workflows using json from the Argo cli.

I agree. Also, I think we should support submission of workflows from STDIN. Will take care of both use cases with this issue.

Any chance the docs could be updated to show a STDIN example?
From looking at the source code it appears to be flagged by passing - in place of a file but it would be nice to confirm

PR welcome. Otherwise this is a 6 year old closed issue, so commenting on it (also known as necroing) is not particularly actionable.

PR welcome.

For posterity, @philBrown added a stdin example in #12820


Initial setup (db, email, admin, etc)

WIP, don't merge.
Basically a rough start on an initial setup page if no users exist.
TODO

[x] Integrate https://github.com/mgonto/angular-wizard
[ ] Hookup form data to controller
[x] Add an endpoint for processing a setup request
[ ] Save some of the settings in a config file

@keyvanfatehi @niallo how should I save the config? Use .striderrc (from the rc package), or store it in the db as the default config but over writable?

I'd suggest DB
On Saturday, February 21, 2015, Ilya Radchenko<EMAIL_ADDRESS>wrote:

@keyvanfatehi https://github.com/keyvanfatehi @niallo
https://github.com/niallo how should I save the config? Use .striderrc
(from the rc package), or store it in the db as the default config but over
writable?
—
Reply to this email directly or view it on GitHub
https://github.com/Strider-CD/strider/pull/681#issuecomment-75391415.

--
Niall O'Higgins
W: http://niallohiggins.com
E<EMAIL_ADDRESS>T: @niallohiggins

@niallo I went with the config, since there is only one config and it's not associated with the user. I think it would be a waste to put it in the db. Also it would be much easier to tweak if needed.
Just wondering what configs should be here, currently I have the smtp, admin user, and server_name. U'm thinking maybe adding provider config as well, so github, bitbucket, heroku

The only thing about a file is a stateless environment like docker. Need to
make sure that state is saved properly, or people will be really confused.
Folks likely already have their DB set up to persist, but may not for
strider itself.
So we'll need to make sure that people know that strider will need to save
$HOME/.striderrc
Provider configs would also be nice, yeah, since that's pretty much the
first thing you need to set up.
Cheers.
On Tuesday, February 24, 2015, Ilya Radchenko<EMAIL_ADDRESS>wrote:

@niallo https://github.com/niallo I went with the config, since there
is only one config and it's not associated with the user. I think it would
be a waste to put it in the db. Also it would be much easier to tweak if
needed.
Just wondering what configs should be here, currently I have the smtp,
admin user, and server_name. U'm thinking maybe adding provider config as
well, so github, bitbucket, heroku
—
Reply to this email directly or view it on GitHub
https://github.com/Strider-CD/strider/pull/681#issuecomment-75763476.

--
Niall O'Higgins
W: http://niallohiggins.com
E<EMAIL_ADDRESS>T: @niallohiggins

Good point.. hum I guess the db might have to be used..

I'm not sure if it's too early to mention this, but I think it would be great if only the bare minimum of strider plugins are declared in package.json and, during the setup phase, the user can chose which plugins he wants.

Yeah that is a good idea, maybe we could just send them to the plugin manager right after setup.


Error importing WalmartIO

Trying to run the code, but it gives error on first line. Can you help ?
from WIOpy import WalmartIO
wiopy = WalmartIO(private_key_version='1', private_key_filename='./WM_IO_private_key.pem', consumer_id='XXXXXXXX-XXXX-XXXX-XXXX-XXXXXXXXXXXX')
data = wiopy.product_lookup('33093101')[0]

TypeError                                 Traceback (most recent call last)
~\AppData\Local\Temp\ipykernel_17576\2346209252.py in
----> 1 from WIOpy import WalmartIO
2
3 wiopy = WalmartIO(private_key_version='1', private_key_filename='./WM_IO_private_key.pem', consumer_id='XXXXXXXX-XXXX-XXXX-XXXX-XXXXXXXXXXXX')
4 data = wiopy.product_lookup('33093101')[0]
~\Anaconda3\envs\QI_MVP_env\lib\site-packages\WIOpy_init_.py in
----> 1 from .WalmartIO import *
2 from .AsyncWIO import *
~\Anaconda3\envs\QI_MVP_env\lib\site-packages\WIOpy\WalmartIO.py in
9 from requests.api import request
10
---> 11 from .arguments import get_items_ids
12 from .errors import *
13 from .WalmartResponse import *
~\Anaconda3\envs\QI_MVP_env\lib\site-packages\WIOpy\arguments.py in
6
7
----> 8 def get_items_ids(items: Union[str, list[str]]) -> list[str]:
9     if not isinstance(items, str) and not isinstance(items, list):
10         raise InvalidParameterException('Invalid items argument, it should be a string or List of strings')
TypeError: 'type' object is not subscriptable

Hi, I would be happy to help! Can you please give me a little bit more information?
What version of python are you running? And while you are at it, can you please provide any other information about the environment this is running on? Thank you

Hey, I am running the code on Jupyter notebook. Python version is 3.7.13.

Now that I am running outside Jupyter Notebook, in VS Code, it is giving Error 401
InvalidRequestException: [Request failed] Walmart server answered with the following error: Error. Status code: 401
Even though I have downloaded the .pem private key and the consumer ID from walmart API page. Not sure what is wrong

The original error is my mistake. I did not realize that I am using the native list and not List. I will fix it in the next update. In the meantime, WIOpy is only compatible with python>=3.9.

As for the authorization, WIO is not great. The instructions are unclear. Please go over their instruction one more time very carefully. After that, if you only recently created the account or uploaded the public key, it is possible you have to wait for an update on their end. Ultimately, I know that the package is still operational because I am actively using it and I re-ran my tests; all still passing. So, the authorization issue is most likely on your end.
Redo the steps and/or wait some time for their servers to update with the info you inputted. If the issue still persists, please open a different issue on it

Yeah, I created account an hour ago. I will try again. Thanks for your help though.


Captures before keyrelease

Currently, manually running hk-relay will result in the enter key being held. The keyboard is grabbed before the release event is sent.
Temporary workaround:
hkd &
sleep 1 && sudo hk-relay -d /dev/input/by-id/<device1>,/dev/input/by-id/<device2>,...

The sleep command will wait a second before running the command, after the key release event has been sent.

Actually unsure that this is totally fixed.


Fix in response to unused but set var

Trying to fool around with cesium using the new C++ intrerop with swift and ran into the following errors building with cmake on macOS.
[ 86%] Built target csprng
[ 88%] Built target CesiumIonClient
[ 88%] Building CXX object CesiumNativeTests/CMakeFiles/cesium-native-tests.dir//Cesium3DTilesSelection/test/TestQuadtreeRasterOverlayTileProvider.cpp.o
/Users/jacobmartin/Documents/Development/cesium-native/Cesium3DTilesSelection/test/TestQuadtreeRasterOverlayTileProvider.cpp:162:14: error: variable 'i' set but not used [-Werror,-Wunused-but-set-variable]
for (int i = 0; pTile->getState() != RasterOverlayTile::LoadState::Loaded;
^
/Users/jacobmartin/Documents/Development/cesium-native/Cesium3DTilesSelection/test/TestQuadtreeRasterOverlayTileProvider.cpp:217:14: error: variable 'i' set but not used [-Werror,-Wunused-but-set-variable]
for (int i = 0; pTile->getState() != RasterOverlayTile::LoadState::Loaded;
^
2 errors generated.
make[2]: *** [CesiumNativeTests/CMakeFiles/cesium-native-tests.dir//Cesium3DTilesSelection/test/TestQuadtreeRasterOverlayTileProvider.cpp.o] Error 1
make[1]: *** [CesiumNativeTests/CMakeFiles/cesium-native-tests.dir/all] Error 2
make: *** [all] Error 2
jacobmartin@Jacobs-MacBook-Pro cesium-native %
rather than fix with a
#pragma GCC diagnostic push
#pragma GCC diagnostic ignored "-Wunused-but-set-variable"

I just rewrote to use a while loop.

Thanks for the PR @j-j-m! Please sign the Contributor License Agreement (or confirm that you already have) and then I'll merge this.

Thanks for the PR @j-j-m! Please sign the Contributor License Agreement (or confirm that you already have) and then I'll merge this.

done!

Thanks again!


There are many errors using these libraries

In file included from /Users/sairanga/Documents/Arduino/ESP32-USB-TO-BLE/ESP32-USB-TO-BLE.ino:5:
/Users/sairanga/Documents/Arduino/libraries/ESP32-USB-TO-BLE-master/BleDevice.h:10:44: error: expected class-name before ',' token
class BleDevice : public BLEServerCallbacks, public BLECharacteristicCallbacks {
^
/Users/sairanga/Documents/Arduino/libraries/ESP32-USB-TO-BLE-master/BleDevice.h:10:80: error: expected class-name before '{' token
class BleDevice : public BLEServerCallbacks, public BLECharacteristicCallbacks {
^
/Users/sairanga/Documents/Arduino/libraries/ESP32-USB-TO-BLE-master/BleDevice.h:12:3: error: 'BLEHIDDevice' does not name a type; did you mean 'BleDevice'?
BLEHIDDevice* hid;
^~~~~~~~~~~~
BleDevice
/Users/sairanga/Documents/Arduino/libraries/ESP32-USB-TO-BLE-master/BleDevice.h:13:3: error: 'BLECharacteristic' does not name a type; did you mean 'Character_h'?
BLECharacteristic* inputMouse;
^~~~~~~~~~~~~~~~~
Character_h
/Users/sairanga/Documents/Arduino/libraries/ESP32-USB-TO-BLE-master/BleDevice.h:14:3: error: 'BLECharacteristic' does not name a type; did you mean 'Character_h'?
BLECharacteristic* inputKeyboard;
^~~~~~~~~~~~~~~~~
Character_h
/Users/sairanga/Documents/Arduino/libraries/ESP32-USB-TO-BLE-master/BleDevice.h:15:3: error: 'BLECharacteristic' does not name a type; did you mean 'Character_h'?
BLECharacteristic* outputKeyboard;
^~~~~~~~~~~~~~~~~
Character_h
/Users/sairanga/Documents/Arduino/libraries/ESP32-USB-TO-BLE-master/BleDevice.h:16:3: error: 'BLECharacteristic' does not name a type; did you mean 'Character_h'?
BLECharacteristic* inputMediaKeys;
^~~~~~~~~~~~~~~~~
Character_h
/Users/sairanga/Documents/Arduino/libraries/ESP32-USB-TO-BLE-master/BleDevice.h:17:3: error: 'BLEAdvertising' does not name a type
BLEAdvertising* advertising;
^~~~~~~~~~~~~~
/Users/sairanga/Documents/Arduino/libraries/ESP32-USB-TO-BLE-master/BleDevice.h:31:26: error: 'BLEServer' has not been declared
virtual void onConnect(BLEServer* pServer) override;
^~~~~~~~~
/Users/sairanga/Documents/Arduino/libraries/ESP32-USB-TO-BLE-master/BleDevice.h:32:29: error: 'BLEServer' has not been declared
virtual void onDisconnect(BLEServer* pServer) override;
^~~~~~~~~
/Users/sairanga/Documents/Arduino/libraries/ESP32-USB-TO-BLE-master/BleDevice.h:31:16: error: 'virtual void BleDevice::onConnect(int*)' marked 'override', but does not override
virtual void onConnect(BLEServer* pServer) override;
^~~~~~~~~
/Users/sairanga/Documents/Arduino/libraries/ESP32-USB-TO-BLE-master/BleDevice.h:32:16: error: 'virtual void BleDevice::onDisconnect(int*)' marked 'override', but does not override
virtual void onDisconnect(BLEServer* pServer) override;
^~~~~~~~~~~~
Multiple libraries were found for "BLEHIDDevice.h"
Used: /Users/sairanga/Documents/Arduino/libraries/BLE
Not used: /Users/sairanga/Library/Arduino15/packages/esp32/hardware/esp32/2.0.11/libraries/BLE
exit status 1
Error compiling for board ESP32 Dev Module.
these are all the errors
can you help me with these

Try to install esp32 board version 2.0.17 instead of 3 in arduino

#14 try this PR

Try to install esp32 board version 2.0.17 instead of 3 in arduino

i can confirm this works


how to load model with device_map="auto"

like this:
RetNetModelWithLMHead.from_pretrained(cp_lst[-1])
to:
RetNetModelWithLMHead.from_pretrained(cp_lst[-1], device_map="auto")

Could you share the current output when you set device_map="auto"?


getpeername() panics on AF_UNIX sockets because sockaddr_un varies in size

extern crate nix;
use nix::sys::socket::*;
use nix::unistd::*;

fn main() {
    let (fd1, fd2) = socketpair(AddressFamily::Unix, SockType::Stream, 0, SockFlag::empty()).unwrap();
    getpeername(fd1).unwrap();
}

does this:
geofft@titan:~/src/rust/scratch/t$ target/debug/t
thread '<main>' panicked at 'assertion failed: len as usize == mem::size_of::<sockaddr_un>()', /home/geofft/src/rust/nix-rust/src/sys/socket/mod.rs:721

The panic is in sockaddr_storage_to_addr:
        consts::AF_UNIX => {
            assert!(len as usize == mem::size_of::<sockaddr_un>());
            Ok(SockAddr::Unix(UnixAddr(*(addr as *const _ as *const sockaddr_un))))
        }

From some print statements, it looks like len is 2, whereas the size of the structure is 110. strace traces this as
getpeername(3, {sa_family=AF_LOCAL, NULL}, [2]) = 0

It looks like it's valid for a sockaddr_un to report a length shorter than the maximum size, and we're supposed to treat this as a flexible array member or something. The easiest answer may be for UnixAddr to explicitly track its own size, although I'm wondering if really SockAddr should track size for all variants.
Probably a prereq for / should be fixed alongside #169.
(Also, getpeername has no tests and probably should have at least one.)

Ah... makes sense. And yes, nix definitely could use more tests :)

Does anyone have a good idea for mocking out libc calls?  One thought is to use something like #[link_args = "-Wl,wrap,ioctl] to wrap system calls, but this is not particularly portable and relies on unstable parts of the language.
This seems to be the biggest barrier to adding better test coverage.

I feel like for getpeername one ought to be able to use the native OS implementation for all address families, since there's a meaningful localhost. In the general case, is it sufficient to run the tests inside a VM on an isolated network? Then you can test things that involve root (like mount), test things that involve all types of network protocols, etc. Some shell scripts to create VMs and run them with qemu should not be too difficult.
For wrapping functions, if you want to take that approach, you could use my Rust LD_PRELOAD macro library. I've been meaning to add Mac support to it via dyld interposers. But I feel like I'd rather see tests pass on actual OSes/kernels


[Carbondata-3173]  Add the hive /presto documents index to the root of file ReadMe

Be sure to do all of the following checklist to help us incorporate
your contribution quickly and easily:

[ ] Any interfaces changed?

[ ] Any backward compatibility impacted?

[x] Document update required?

[ ] Testing done
Please provide details on
- Whether new unit test cases have been added or why no new tests are required?
- How it is tested? Please attach test report.
- Is it a performance related change? Please attach the performance test report.
- Any additional information to help reviewers in testing this change.

[ ] For large changes, please consider breaking it into sub-tasks under an umbrella JIRA.

Can one of the admins verify this patch?

@xubo245  hi ,can you take a time to check this pr?

How to handle this doc?
https://github.com/apache/carbondata/blob/master/integration/presto/Presto_Cluster_Setup_For_Carbondata.md

@BeyondYourself Please finish checklist of PR content.

@chenliang613 @sraghunandan Please review this PR, This. PR add integration for hive and presto, we will add alluxio, flink in the future.

How to handle this doc?
https://github.com/apache/carbondata/blob/master/integration/presto/Presto_Cluster_Setup_For_Carbondata.md. @BeyondYourself

I had ever confused by  the document https://github.com/apache/carbondata/blob/master/integration/presto/README.md and  https://github.com/apache/carbondata/blob/master/integration/presto   /Presto_Cluster_Setup_For_Carbondata.md,now ,I have get it ,the https://github.com/apache/carbondata/blob/master/integration/presto   /Presto_Cluster_Setup_For_Carbondata.md should be add the link to the root of ReadMe.md

LGTM

How to handle this doc?
https://github.com/apache/carbondata/blob/master/integration/presto/Presto_Cluster_Setup_For_Carbondata.md. @BeyondYourself

I had ever confused by the document https://github.com/apache/carbondata/blob/master/integration/presto/README.md and https://github.com/apache/carbondata/blob/master/integration/presto /Presto_Cluster_Setup_For_Carbondata.md,now ,I have get it ,the https://github.com/apache/carbondata/blob/master/integration/presto /Presto_Cluster_Setup_For_Carbondata.md should be add the link to the root of ReadMe.md

I think README.md is for single node,  Presto_Cluster_Setup_For_Carbondata.md is for cluster.  Can you add link for each other?

LGTM, Thank you for working on this. @BeyondYourself


[bug]: ModalPopup doesn't close on button click on mobile devices

Components: ModalPopup
Feedback summary
When you try to close an open ModalPopup modal for mobile devices, the closing does not occur, but 2 events are executed: close event and open event. Which makes it impossible to close the modal by clicking on the call button.
Note: this error does not occur for the desktop version.
https://github.com/openedx/paragon/assets/17108583/4c793cf1-efeb-41b1-b34e-c5fcba8999e9
Improvements
The modal should both open and close by clicking on the call button for desktop and mobile devices.

This seems to be an issue with how we're using react-focus-on, and is something others have run into as well https://github.com/theKashey/react-focus-on/issues/33.
The react-focus-on readme has

[onClickOutside] - on click outside of "focus" area. (actually on any event "outside")

In our use case, this means onClickOutside is calling onClose when it receives a touchstart event, but the button doesn't do anything until it recieves a react click event, which happens afterwards during the same press.


Choice field doesn't appear to work.

I've been trying to get a choices field into my admin page, specifically in the creation view.
I've tried the example from the documentation:
 nga.field('country', 'choice')
      .choices([
        { value: 'FR', label: 'France' },
        { value: 'US', label: 'USA' },
      ]),

It causes the following error when opening the create page:
angular.js:13550 TypeError: t.choices is not a function
at pre (http://localhost:3000/bower_components/ng-admin/build/ng-admin.min.js:15:2545)
at http://localhost:3000/bower_components/angular/angular.js:9688:44
at invokeLinkFn (http://localhost:3000/bower_components/angular/angular.js:9694:9)
at nodeLinkFn (http://localhost:3000/bower_components/angular/angular.js:9072:11)
at compositeLinkFn (http://localhost:3000/bower_components/angular/angular.js:8397:13)
at nodeLinkFn (http://localhost:3000/bower_components/angular/angular.js:9088:24)
at compositeLinkFn (http://localhost:3000/bower_components/angular/angular.js:8397:13)
at nodeLinkFn (http://localhost:3000/bower_components/angular/angular.js:9088:24)
at compositeLinkFn (http://localhost:3000/bower_components/angular/angular.js:8397:13)
at publicLinkFn (http://localhost:3000/bower_components/angular/angular.js:8277:30)

Huh. Can you expose your whole entity definition ?

I've created repo that demonstrates the problem. These most recent commit adds a choice field that causes the issue.
Clone this:
https://github.com/Real-Serious-Games/admin-portal-template
Install dependencies:
npm install
cd Client
bower install
cd ..\
Run the server:
cd src
node server.js
Navigate to the customer creation screen:
http://localhost:3000/your-secret-key/#/customers/create
The following error should appear in your browser console:
angular.js:13550 TypeError: t.choices is not a function
Note that this issue only happens in the most recent commit. If you revert back to the prior commit and go to the customer creation screen there is no issue.

The code that defines the entities can be found in customize.js.

This looks to be the same issue as https://github.com/marmelab/ng-admin/issues/778. I don't think that the fix for that issue has been released as part of 0.9.x.
Did you find a solution to this issue on 0.9.1?

Can you have a look on last master version and check if you can still reproduce the issue?

No feedback since @jpetitcolas  last request, closing...
Please feel free to reopen if required


Use SettingsErrors when file can't be used as source

Some file formats (at least yaml) allow to represent non dictionnary values. In such situation we can't add the values read from those files. Instead of raising a ValueError, we now raise a SettingsError and indicate we can't parse the related config file.

Thanks @l00ptr for this PR. I think this will introduce a breaking change because some people code might be depend on the old error

ok, i think i can try to help on that topic. I can start writing a simple test case for invalid yaml file and handle json decoding error.

I think this will introduce a breaking change because some people's code might depend on the old error.

It seems to me that the change would not break users code because SettingsError is a subclass of ValueError: https://github.com/pydantic/pydantic-settings/blob/0d605d076553452f67141f00e5dc873aa06c5b01/pydantic_settings/sources.py#L122
so anybody doing:
try:
   s = Settings()
except ValueError:
   # handle exception here
   ...

would still have their code working. This could be checked in tests added here.
Or did you have something else in mind @hramezani ?

I think this will introduce a breaking change because some people's code might depend on the old error.

It seems to me that the change would not break users code because SettingsError is a subclass of ValueError:
https://github.com/pydantic/pydantic-settings/blob/0d605d076553452f67141f00e5dc873aa06c5b01/pydantic_settings/sources.py#L122
so anybody doing:
try:
   s = Settings()
except ValueError:
   # handle exception here
   ...

would still have their code working. This could be checked in tests added here.
Or did you have something else in mind @hramezani ?

I still think it will be a breaking change. some people code may

I think this will introduce a breaking change because some people's code might depend on the old error.

It seems to me that the change would not break users code because SettingsError is a subclass of ValueError:
https://github.com/pydantic/pydantic-settings/blob/0d605d076553452f67141f00e5dc873aa06c5b01/pydantic_settings/sources.py#L122
so anybody doing:
try:
   s = Settings()
except ValueError:
   # handle exception here
   ...

would still have their code working. This could be checked in tests added here.
Or did you have something else in mind @hramezani ?

Thanks @dlax for the explanation. However, it is still a breaking change because some people's code might depend on the error type ValueError(rare case). So, better not to do it now and postpone the decision before V3.
pydantic-settings had a lot of changes from V1 to V2 and we decided not to introduce breaking changes even something like this.


updated plug (2.0.11)

Changes to a cask
Editing an existing cask

[x] Commit message includes cask’s name (and new version, if applicable).
[x] brew cask audit --download {{cask_file}} is error-free.
[x] brew cask style --fix {{cask_file}} left no offenses.

Thank you for the contribution. It was merged directly as 87bf5e6928c0b6b63218aecb88d4bc42625733ba to keep commit history cleaner. Your contribution is still credited to you.


onChangeComplete not invoking when pasting HEX code

My Environment

Dependency
Version

Node.JS version
v14.19.1

react-color-palette version
v6.1.0

Expected Behavior:
onChangeComplete should be invoked after HEX color code input change
Actual Behavior:
onChangeComplete doesn't get invoked
Additional Context:

Hi! I'm having the same issue, did you find a solution? Thanks

Hi! I'm having the same issue, did you find a solution? Thanks

Yes, I ditched onChangeComplete and just wrapped the onChange callback in a debounce function.

Duplicate #35


Update assign-local-admin.md

Added a note about groups limitation for admin privileges

@RavennMSFT : Thanks for your contribution! The author(s) have been notified to review your proposed change.

#sign-off

@ktoliver : Thanks for your contribution! The author(s) have been notified to review your proposed change.

(Edited to reflect internal style guidance, which says to use "sign-in" and never "logon," and to use "rights" for user group rights and not "privileges.")


GVRMaterial, GVRShaderData, GVRShaderManager docs

documentation only - no code changes
GearVRF DCO signed off by: Nola Donato<EMAIL_ADDRESS>

Why is GVRBitmapTexture still called that and not GVRBitmapImage?

Because I did not get around to changing all the names. This would require changing demos too. If you think we have time to make name changes before we release 4.0, I am open to it.

I am done with this PR now. I had to fix some formatting in the light docs too.


Problems with dynamic rendering of Ground Overlay

This is my map component:
const PositioningComponent = compose(

  withProps({
    googleMapURL:
      "https://maps.googleapis.com/maps/api/js?key=xxxxxxxxxxxxxxxxx&v=3.exp&libraries=geometry,drawing,places",
    loadingElement: <div style={{ width: '100%', height: `100%` }} />,
    containerElement:
,
    mapElement:

  }),
  withScriptjs,
  withGoogleMap
) (props => (

  <GoogleMap zoom={props.zoom} center={props.center}>
    <Marker options={{
      icon: {
        url: 'pin.png'
        scaledSize: { width: 20, height: 20},
        anchor: { x: 10, y: 10 },
      }
    }} position={{ lat: props.latitude || 0, lng: props.longitude || 0 }} />

    <GroundOverlay
      defaultUrl={props.href}
      defaultBounds={new google.maps.LatLngBounds(
        new google.maps.LatLng(props.south, props.west),
        new google.maps.LatLng(props.north, props.east)
      )}
      defaultOpacity={props.opacity}
      />

  </GoogleMap>

));

It is rendered timer based like so:
<PositioningComponent
                        center =    {this.state.center}
                        zoom =      {this.state.zoom}
                        latitude =  {this.state.latitude}
                        longitude = {this.state.longitude}
                        href =      {this.state.href}
                        opacity =   {this.state.opacity}
                        south =     {this.state.south}
                        west =      {this.state.west}
                        north =     {this.state.north}
                        east =      {this.state.east}
/>

Whereas marker, center and zoom are following the props on dynamic change, unfortunately the Groundoverlay does not. It is just drawn once with the very first props.
Here is a trace of the initial render props:
PositioningComponent:  {"zoom":2,"center":{"lat":0,"lng":0},"href":null,"north":0,"south":0,"east":0,"west":0,"opacity":0}
The reason is, that I don't have all the required parameters for the ground overlay by hand, when it is first time to render the overlay.
If I later provide this (mock coordinates), the ground overlay does not appear:
PositioningComponent:  {"zoom":20,"center":{"lat":10.00000000,"lng":10.00000000},"href":"https://image.com/a.png","north":10.000000,"south":10.000000,"east":10.000000,"west":10.000000,"opacity":1}
Zoom, center and marker are fine.
What is required to redraw the GroundOverlay?

Disregard. Solved by conditional rendering

Disregard. Solved by conditional rendering

@neilyoung
Sorry for asking, but can you elaborate more on how to do the conditional rendering method.
Thank you in advance.


MatProgressSpinner harness does not contemplate mat-spinner alias

Context
In the Angular Material documentation, it is said you can either use <mat-progress-spinner> or <mat-spinner> to place spinner components:

The progress-spinner supports two modes, "determinate" and "indeterminate". The <mat-spinner> component is an alias for <mat-progress-spinner mode="indeterminate">.

Issue
When using harnesses to test the application, there's no harness for the <mat-spinner> element and the MatProgressSpinnerHarness just includes selector for mat-progress-spinner, and not their alias mat-spinner:
https://github.com/angular/components/blob/264c20d19667074af9981d0de86e67fea4efa0d8/src/material/progress-spinner/testing/progress-spinner-harness.ts#L17
Should the selector be able to match both spinners? Or maybe we're missing a MatSpinnerHarness here? 🤔
Thanks!

That's what I call a quick fix @crisbeto ! Thanks 💪


Remove Tag traces/Update UI title and icon

Codecov Report
Base: 53.01% // Head: 50.91% // Decreases project coverage by -2.09% :warning:

Coverage data is based on head (039b226) compared to base (50f2bb8).
Patch coverage: 38.46% of modified lines in pull request are covered.

Additional details and impacted files
@@             Coverage Diff              @@
##             master     #291      +/-   ##
============================================
- Coverage     53.01%   50.91%   -2.10%
+ Complexity     1033     1007      -26
============================================
  Files           191      187       -4
  Lines          4397     4244     -153
  Branches        514      492      -22
============================================
- Hits           2331     2161     -170
- Misses         1881     1903      +22
+ Partials        185      180       -5

Impacted Files
Coverage Δ

src/main/java/seedu/address/MainApp.java
0.00% <0.00%> (ø)

...ss/logic/commands/addcommands/AddBuyerCommand.java
64.28% <ø> (ø)

...ogic/commands/addcommands/AddDelivererCommand.java
41.66% <ø> (ø)

...ress/logic/commands/addcommands/AddPetCommand.java
100.00% <ø> (ø)

...logic/commands/addcommands/AddSupplierCommand.java
64.28% <ø> (ø)

.../logic/commands/editcommands/EditBuyerCommand.java
0.00% <0.00%> (ø)

...ic/commands/editcommands/EditDelivererCommand.java
0.00% <0.00%> (ø)

...gic/commands/editcommands/EditSupplierCommand.java
0.00% <0.00%> (ø)

...seedu/address/logic/commands/util/CommandUtil.java
96.77% <ø> (-0.11%)
:arrow_down:

...ain/java/seedu/address/logic/parser/CliSyntax.java
96.55% <ø> (-0.23%)
:arrow_down:

... and 26 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

Quick Test
git checkout Branch_Remove_Tags
./gradlew run

fix #237

fix #239

fix #237

fix #234


Need to include component CSS in package

Fixed by https://github.com/jhnsnc/knob-input/commit/6b8861df2da2b597eb19c02ebe12315065319186


related to issue #88: refactor to use a list of stages instead of internal slots for each state.

Changes:

state is now stagein the pipeline, which is more clear.
stages are stored in an ordered list, and each stage entry is removed as soon as the entry reaches a new stage.
renaming CommitInstantiate to ExtractDependencies.

Rendered HTML:

https://rawgit.com/caridy/148a3ffbb7caafc20da2/raw/eea60a38aa6ef84ed3384017eb82015af83d5b44/pr-91-loader.html

Looks great. I have a couple tiny nits in the comments. Otherwise r+


Don't specify repo_id for consistency with s3fs, gcsfs, etc.

Those filesystems can be instantiated without specifying a repo id.
We could have the same to let users familiar with s3fs, gcsfs, etc. start playing with hffs directly, by transposing what they know already about common filesystem implementations
Related to https://github.com/huggingface/moon-landing/issues/5690

assigning myself to play with this logic, see how feasible it is

I think canonical repos are stopping us from implementing this (when splitting on "/",  repo_id is  either contained in one or two "URL parts")

I think we can workaround this by checking if the repo_id with namespace exists first, and fallback on the repo_id without namespace otherwise

Out of curiosity, what are we talking about when you say "without repo_id" ? The user have to provide some information at some point, isn't it? Do you mean concatenating repo type + repo_id + path_in_repo in a single string ?

Something like
fs = HfFileSystem(token=token)
fs.glob("gpt2/*.bin")

and for datasets:
fs = HfFileSystem(token=token)
fs.glob("datasets/my-username/my-dataset/*.csv")


fix command

I may proof-read it over and over again but of course, there's always something. Thank you though


moving prefab preprocessor from playground to GameObjectRepresentation

Contributions: We are not currently taking public contributions - see our contributions policy. However, we are accepting issues and we do want your feedback.

Description
Because if you create your new project and you don't have it, it will completely break.
Tests
tested in my own small test project
Documentation
none
Primary reviewers
@zeroZshadow

sorry about that, should be fixed now

The namespace isn't fixed now

LGTM for MVP, ideal solution is moving it into a module that adds on top of monobehaviour support.

@firtina-improbable  agree with that. definitely needs to be moved with the rest of the monobehaviour stuff!
I think I fixed everything now, please take another look @zeroZshadow


[Cadl APIView] Show Aliases in their own category within navigation

Fixes #4977.
Example for OpenAI Inference:
https://apiviewstaging.azurewebsites.net/Assemblies/Review/05b84c030c904b208aa0eefbe5a8b55f

@lmazuel the navigation issue has been fixed (it wasn't specific to aliases)
https://apiviewstaging.azurewebsites.net/Assemblies/Review/05b84c030c904b208aa0eefbe5a8b55f


Automated Tagging

Currently we manually tag our releases it would be super useful if we could automatically tag versions when they get merged to main, we could create the tags based on the conventional commits strategy that we use.
https://www.conventionalcommits.org/en/v1.0.0/
sequenceDiagram
Action->>Main: Disable Branch Protection
Action->>Action: Tag Code based on Conventional Commit
Action->>Main: Push tags to main
Action->>Main: Enable Branch Protection

we are using the draft release functionality in github this is no longer needed.


+1 to schema index so it matches the filename and id

What is the context of this PR?
Fixes #41
How to review
Run locally and see that the indexes start at 1. (it was previously 0.)

[ ] Do all commits have sensible commit messages?
[ ] Is all new code unit tested?
[ ] Are there integration tests if needed?
[ ] Is there sufficient logging?
[ ] Is there documentation or is the code self-describing?

Who worked on the PR
@collisdigital

You need to do a npm install and npm run compile to pick up the change.
I've tested it and the change works but the tests failed when you run npm run test 👎

Seems to be failing on master, once we fix that this will work 👍

Tested locally, all tests pass 👍


NCP usage seems broken for any real life needs

Normal people when they think of issuing a command: "copy folder X into folder Y" expect that the result they get is a folder under Y called X with all the contents of folder X in it.
NCP breaks this in two ways:

You end up with folder Y with contents of folder X in it
If you have more than Z items in the folder it just stops copying, there seems to be no way to disable this limit.

Now, try this out in a shell:
mkdir foo
mkdir bar
touch foo/file
cp -r foo bar

What do you end up with?
Yes, you will have a bar/foo/file. This is the expected behavior from anything that copies things recursively.
If you execute instead:
node
require("ncp").ncp("foo", "bar")

You end up with bar/file, you might expect this result with "foo/*" as the first argument, or something similar, but this is just bad.

First you're not right, the result of the shell command cp -r foo bar do different things depending on dest dir exists or not. The default behavior (when the dir does not exists) is to ends up with bar/file, just like ncp.
Then, the command cp -r foo bar is misleading and should not be used.
Instead use cp -r foo bar/ if you want to get foo inside bar
or cp -r foo/* bar/ if you want to get foo files inside bar
Then, the difference when the dest dir exists is welcomed because unlike you said, it allows all possible usage for any real life needs:
If ncp had the same behavior than cp, it would be impossible to do cp -r foo/* bar without supporting glob pattern (usage of *) or knowing parent dir path.
To conclude, this is not ncp wich is wierd but cp.
ncp behavior is clear, logical and practical (close to mv in the shell)
cp behavior is missleading when there is no trailing slash (depends on folder existence), requires usage of glob pattern for half of the cases, and is not coherent with other commands (example: mv).

Additionally "Normal people" should understand the following:

copy foo to bar => like move foo to bar but keeping original in place => end up with bar/file (this is what finder/explorer do)
copy foo to bar/ => copy foo inside bar => end up with bar/foo/file

The slash means inside, this is universal and that's the most important to catch.
The behavior of cp when the dest folder exists IS A BUG (maybe a wanted bug but a bug) which workaround is to use glob pattern.

Ah, well that does make sense .. Then I guess there is one remaining issue: documentation.
This doesn't seem to be mentioned in the README.md, and there's no code documentation that I can see.
It would be a good idea to at least add this information on the project README, and it would be nice to also have JSDoc

Yes you're right. It should be documented.


WIP: Add a test for CNP update of same policy

This change is

test-me-please

test-me-please

test-me-please

test-me-please

@joestringer needs rebase. Also has WIP in the title still - is this actually ready for review?

@ianvernon a ha! I accidentally changed these labels on the wrong PR some time last week and couldn't find the relevant PR again.
This needs tidy up and there were an additional couple of similar tests that were suggested by @aanm - updating to completely empty policies (no specs at all), and adding policies with different user-specified labels (then seeing that the appropriate policies are updated).

@joestringer there are some unit tests already done in daemon/k8s_watcher_test.go but we still need e2e

test-me-please

test-me-please

test-me-please

Green run with the new test:
https://jenkins.cilium.io/job/Cilium-PR-Ginkgo-Tests-Validated/7733/execution/node/94/log/

Hi,
Quick one, could these lines move to this function? I think that the context is too similar, and the current place I don't really liked too:
https://github.com/cilium/cilium/blob/17291bbabbbe0dcc9a9a2de356e26dd1b9aa167e/test/k8sT/Policies.go#L261-L284
From PR https://github.com/cilium/cilium/pull/5210

@eloycoto seems reasonable but the intent of your suggestion is different from this PR and when I look at the code you linked I don't fully understand the context and specific implementation of the test. I've filed #6131 to follow up on that separately.

Looks like some of the helper functions I was using got changed. Need to update for that.

test-me-please

Coverage increased (+0.007%) to 42.518% when pulling d111dc7a8f107c8e4588fd6671b51ba33b49b8ba on joestringer:submit/test-cnp-update into 4a3ebcaa90dc97b9f7d87d5fa10c7434863452bf on cilium:master.


Credentials Component in Mobile Screen

In Mobile view, i need to scroll the component to view the hide and copy icon.
It would be better to make the icons fixed to right on mobile view and only keep the text scrollable.
Can be replicated in Google Chrome and Mozilla Firefox.
https://user-images.githubusercontent.com/35369843/163437374-cd614727-b0da-4e20-93f8-9f6d0b645bc4.mp4
If accepted i can work on this. 😄

Nice find!
If you will be able to make it like this it would be nice:

But also it can have more sense if we replace text dynamically with https://xj5...:2053/servers. Let's decide what is better for UX @BillyG83

Btw, splitting text like this can not be achieved with CSS, it's a JS func.

Cool will wait for Bill's decision. 🙌🏻
https://xj5...:2053/servers even this much might overflow in mobile.
We could use text-overflow: ellipsis to clip the text. Much easier and won't need extra JS.

Yes, but text-overflow: ellipsis will make it https://xj5... - sometimes not the best for UX

Yeah good point.
Actually now that i think about ellipsis might not be the right approach
This component is used to display text(or hidden text) so hiding it default with ellipses would not be the desired result.

hi @Y0moo and @AbhinavMV good work here.
Yes it displays text but the ellipsis is the best fix i think, because users will want to see the text but will use the copy button in 99% of cases i think. So as long as we can show ellipsis but when they hit the copy button the full string is copied, that is perfect


Issues with the open-source dataset

Hi Curation,
I would like to point that, in its current form, this dataset is almost unusable. The main problem is with the fact that users have to scrape documents from the original websites. Website changes, URL forwarding, paywalls, etc. inevitably cause a lot of web-related errors that manifest in the documents, which is very difficult to preprocess out. The provided preprocessing script (in its current state) does not do enough to filter out the noise. There are at least two larger problems with this:

Pre-trained models, like BERT, are very sensitive to the integrity of the document, and if there are spurious tokens or ill-formed sentences, the model will not be able to form coherent representations of the document. Seemingly minor things like [gallery ids=\"1318996,1318995,1318988,1318986,1319003\"] being injected in a document can cause the number of wordpieces to explode. This generally wouldn't be a big problem, but BERT (and most other pre-trained encoders) have a maximum sequence length of 512 wordpieces/subwords, so the encoder will not have a chance to see other sentences if a single sentence saturates the batch.

Results obtained on this dataset might not be reproducible given that the documents are not released with the original distribution. When I first used the scraper to collect this dataset (around the time when this dataset was published), I was only able to retrieve 39,917 documents, not 40k as is advertised on this repository. If someone were to run the scraper now, the recall may be substantially lower. I understand that there may be licensing issues associated with Curation releasing the documents along with the abstracts, but this is an important point for consideration -- people having different copies of this dataset (along with different content) will not be able to compare results in a scientifically meaningful way.

Finally, in the interest of providing constructive criticism, I'll point out some specific issues I saw in the documents that may be addressed by finer-grained quality control. These errors are not cherrypicked -- they are chosen from a random sample of about 100 documents/summaries.
1) HTML artifacts in the middle of a document
[DOCUMENT]
...
[gallery ids=\"1318996,1318995,1318988,1318986,1319003\"]
...

2) Non-document related content appears in the document
[DOCUMENT]
...
For more information, visit www.GoSafr.com. Contacts Elevate Communications, for SafrLucy Muscarella,<PHONE_NUMBER>cell<EMAIL_ADDRESS>Humphrey Flynncell:<PHONE_NUMBER>Marketing and PR<EMAIL_ADDRESS>
3) Tables get squeezed in with the rest of the document -- hard to preprocess out
[DOCUMENT]
...
Crude steel consumption2017*2018'2019f2020f2018'2019'2020' World steel consumption1.7011,7591.7621,7583.50.2-0.2 China7888107947762.8-1.9-2.3 European Union<PHONE_NUMBER>717<IP_ADDRESS> United States1071111121114.01.0-1.0 India961021081<IP_ADDRESS> Japan75737372-3.10.5-1.8 South Korea59595959-0.1-0.3-0.4 Russia43424242-<IP_ADDRESS> Brazil222323<IP_ADDRESS> Crude steel production20172018'2019f2020f2018'2019'2020' World steel production1.6891,7711.7681.7594.8-0.2-0.5 China8508868618424.2-2.8-2.2 European Union<PHONE_NUMBER>417<IP_ADDRESS> Japan1051061081<IP_ADDRESS> India1011081151<IP_ADDRESS> United States8286909<IP_ADDRESS> Russia7172727<IP_ADDRESS> South Korea71717170-0.2-0.3-0.4 Brazil34343434-<IP_ADDRESS> Notes: s estimate f forecast.

4) Document/summary pairs are incorrect
[DOCUMENT]
Published: 9:34am, 18 Jan, 2019Updated: 8:43pm, 18 Jan, 2019

[SUMMARY]
Italian insurance company Generali said it was ready to expand into Asia and Latin America after a restructuring that saw it sell unprofitable operations. A three-year strategy launched in November 2018 included a target of compound earnings per share annual growth of up to 8%. CEO Philippe Donnet said the firm was considering potential acquisitions of a bancassurance provider in Asia, a Central and Eastern European property and casualty insurer and a global health insurer. About three-quarters of Generalis business came from France, Germany and Italy but it already had a presence in 10 Asian markets.

5) Hitting a paywall
[DOCUMENT]
A recent event that received surprisingly little media attention serves as a reminder of a lurking cyber risk that is different in kind and scale than more widely and frequently reported privacy-related data breaches. Want to continue reading?Become a FreePropertyCasualty360 Digital Reader. INCLUDED IN A DIGITAL MEMBERSHIP: All PropertyCasualty360.com news coverage, best practices, and in-depth analysis. Educational webcasts, resources from industry leaders, and informative newsletters. Other award-winning websites including BenefitsPRO.com and ThinkAdvisor.com. Register Now Already have an account? Sign In Now

[SUMMARY]
A recent series of industrial fires in Iran, which have been blamed on hackers, has opened up the question of insuring against physical damage as a result of cyber breaches, according to Alex J Lathrop, a partner at law firmPillsbury Winthrop Shaw Pittman. Rather than relying on cyber insurance, which covers only data breaches, traditional commercial general liability, property and business interruption policies,where exclusions are not clearly indicated, should provide coverage for physical damage sustained during a cyber attack, he said.

6) Spurious client-side access errors
[DOCUMENT]
StackPath Please enable JavaScript This website is using a security service to protect itself from online attacks. The service requires full JavaScript support in order to view the website. Please enable JavaScript on your browser and try again. Reference ID: ad34175b419f6e80a9fe5cd1f5e57ab1

7) Summary in English, document is not
[DOCUMENT]
Regus slandi opnar dag, 24. janar kl. 17.00, formlega njan skrifstofukjarna 3. h Hafnartorgi. ar vera starfrktar 46 skrifstofur, fundarherbergi mismunandi strum og svi fyrir sameiginlega vinnuastu. Allar skrifstofur og starfsstvar eru afhentar viskiptavinum fullbnar me rafmagnsborum, skrifstofustlum og rum nausynlegum bnai, s.s. fjarskiptabnai, nettengingu og fleira segir frttatilkynningu fr flaginu. Skrifstofukjarni samanstendur af einkaskrifstofum, samnttum vinnusvum, setustofum, fundarherbergjum og fjarskrifstofum. tilefni af opnun skrifstofukjarnans hafa au Andrzej Mrozek-Folkierski, yfirmaur vrurunar Regus, og Roz Young, svisstjri Regus Evrpu, komi hinga til lands til a vera vi opnunina. Regus slandi rekur n egar fjra skrifstofukjarna hr landi undir merkjum Regus og Orange Project, rmla 4-6, Sktuvogi, Hfatorgi og Akureyri. Skrifstofukjarninn Hafnartorgi verur fimmti skrifstofukjarni flagsins. Tmas Hilmar Ragnarz, framkvmdastjri og eigandi Regus slandi opnunina vera skref inn framtina me ntmalegri skrifstofuastu.

[SUMMARY]
Regus has opened its fifth office in Iceland, located on the thirdfloor of Hafnartorg Kvosinn, Reykjavik. The new centre has 46 offices, meeting rooms and shared office space.

8) Lack of sentence separation
[DOCUMENT]
Wells Fargo picks four directors for sales scandal probe -source By Reuters Published: 18:22 EDT, 8 December 2016 | Updated: 18:22 EDT, 8 December 2016 By Dan FreedDec 8 (Reuters) - Wells Fargo & Co Chairman Stephen Sanger and Vice Chair Elizabeth Duke have been named to a four-member committee that will lead an internal investigation into the bank's recent sales scandal, a person familiar with the matter said on Thursday
...

9) Summaries are not well-formed (word separation issues)
[SUMMARY 1]
A diagram by the Bank of International Settlements (BIS) has revealed that China's shadow banking sector is even more indecipherable and complex than itsUS counterpart. In particular BIS pointed to uncertainty about who would befinancially responsible when adebt forequity swap defaulted.New and more complex structured shadow credit intermediation has emerged and quickly reached a large scale, notedBIS, with thiscomplexity packaged and sold through wealth management products. Ifthere were to be afinancial crash, this complexity would make it worse.

[SUMMARY 2]
The FAA has proposed its biggest fine of$1.9magainst SkyPan International, an aerial photography company,for illegally flyingdronesthroughbusy airspace above New York and Chicago. A total of 65 unauthorised flights were recorded over a two year period between 2012 to 2014.SkyPan failed to get a valid Certificate of Waiver for the flights, and 43 of those flights were over a tightly restricted Class B airspace in New York, without permission from air traffic control.

[SUMMARY 3]
The completion of new energy storage schemes with a combined 340.5 MW capacityin China in the first sixmonths of this year will almost equalthe total 389.4 MW capacity of energy storage facilitiesoperational in China at the end of 2017, according to the China Energy Storage Alliance (CNESA).The biggeststorage project built in H1 was actually eight linked lithium-ion battery modules, on one sitein Jiangsu Zhenjiang,addingup to 101 MW/202 MWh grid-connected capacity. The new facility started operations inJuly, CNESA said.

[SUMMARY 4]
Eurex Clearing is working on a clearing model that will enable buy-side members to clear directly, circumventing bank clearing members. Their plans have caused some concern with Europeanregulators over risk from lower-rated counterparties.

[SUMMARY 5]
Knotel is reportedly in talks with Wafra, a New York City-based investment firm owned by the Kuwaiti government pension fund, about an investment that would value the company at around$1.5bn. Wafra is expected to lead the funding round, potentially joined by Singapores sovereign-wealth fund. Knotel has expanded its portfolio of flexible office locations to around 200from 20 in early 2018. The discussion highlights strong interest in the sector from institutional investors.

10) Scraper does not handle errors gracefully
[DOCUMENT]
Exception

[SUMMARY]
Non-US companies have been warned there is an increased risk of enforcement action against them from the US's Securities and Exchange Commission (SEC). The warning came in an article in the Banking Law Journal following a ruling made earlier this year by the Court of Appeals for the Tenth Circuit in SEC v Scoville, which seemingly bolstered the regulator's extraterritorial enforcement authority under the Dodd-Frank Act. \"One risk created is that purely foreign transactions, which arguably influence the price of securities traded on United States exchanges, may be the subject of SEC enforcement actions\", the article noted.

Thanks for the feedback Shrey.
"I understand that there may be licensing issues associated with Curation releasing the documents along with the abstracts" - I think you've partly answered your question here. We've tried to copy the way the Deepmind released the CNN/DM dataset. Maybe someone will host the articles in a similar way. Maybe they won't.
I agree the scraper could be improved. It's something I'll keep working on. If you have any ideas for how it could be improved, or submit a pull request, I would be happy to credit you.

@HenryDashwood Does the large version of this corpus also suffer from similar issues? Given that, you are providing a commercial license for the larger dataset, is there some quality control that you have employed on the dataset to resolve some of the above listed issues?

New cleaner dataset with better scraper


Stopping server

How to stop the server once its running?

Kill the process with SIGINT (e.g. CTRL-C) or SIGTERM signals.

Respectfully, I knew that.  I was expecting there to be a more....graceful way to do it.

It is "graceful". The signal handlers cleanly shutdown the driver and server.
In my experience most unix services work this way, e.g. nginx.

Yes, but there seems no way then to do it through systemd, when it is started via that method.  I looked at trying to capture the process number, but if the server crashes or otherwise gets restarted by systemd, the process number will no longer be correct.

You shouldn't need to know anything about PIDs with systemd. It uses SIGTERM by default to stop services, which is what is supported here.

FWIW, I'm not an expert in the node.js ecosystem, but it seems like PM2 is the most common way to supervise node applications. If vanilla systemd is not meeting your needs, perhaps consider using PM2 in conjunction with systemd.


Implement custom constructor functionality

Resolves https://github.com/amzn/ion-object-mapper-dotnet/issues/12.
By default, C# objects are created using the Activator.CreateInstance(Type) method which calls the default constructor. If you want to supply a constructor yourself, you can markup a constructor with the IonConstructor Attribute. Additionally, the parameters to the constructor must be specified using the IonPropertyName Attribute again:
public class Wheel
{
    private string specification;

    [IonConstructor]
    public Wheel([IonPropertyName("specification")] string specification)
    {
         this.specification = specification;
    }
}

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

This PR still needs to add method deserialization logic to DeserializeWithIonConstructor() once #25 gets merged.

Codecov Report

:exclamation: No coverage uploaded for pull request base (main@8b9334f). Click here to learn what that means.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main      #30   +/-   ##
=======================================
  Coverage        ?   92.93%
=======================================
  Files           ?        8
  Lines           ?      552
  Branches        ?      125
=======================================
  Hits            ?      513
  Misses          ?       25
  Partials        ?       14

Flag
Coverage Δ

unittests
92.93% <0.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8b9334f...a22ce91. Read the comment docs.

Could you rebase so we can see the code coverage?

Could you rebase so we can see the code coverage?

Rebased.


Cannot create "n" responses

System Info
Verified in dockerimage python:3.9
Who can help?
@hwchase17
@agola11
Information

[X] The official example notebooks/scripts
[ ] My own modified scripts

Related Components

[X] LLMs/Chat Models
[ ] Embedding Models
[ ] Prompts / Prompt Templates / Prompt Selectors
[ ] Output Parsers
[ ] Document Loaders
[ ] Vector Stores / Retrievers
[ ] Memory
[ ] Agents / Agent Executors
[ ] Tools / Toolkits
[ ] Chains
[ ] Callbacks/Tracing
[ ] Async

Reproduction
how to reproduce?

docker run -it python:3.9 bash
pip install langchain
pip install openai
run script

from langchain.chat_models import ChatOpenAI
from langchain.prompts.chat import SystemMessage

chat_model = ChatOpenAI(n=3)
prompt = "What is the capital of France?"
message = SystemMessage(content=prompt)
responses = chat_model.predict_messages([message], n=3)
print(responses)

output:
content='The capital of France is Paris.' additional_kwargs={} example=False
Expected behavior
Hello,
When running the script I expect to get 3 responses, because I set the parameter n=3 during initialization of ChatOpenAI and in the call of predict_messages.
still the response is a single answer!
please let me know how to correctly use the parameter n or fix the current behavior!
best regards,
LW

Thank you! quite an amazing answer for a bot!
The code snipped you provided worked for that scenario!!
Now i am going one step further.
I would like to get n responses from an LLMChain object, which does not have a _generate function
I set up the LLMChain using a ChatOpenAI and a ChatPromptTemplate composed from multiple messages.
Is it possible to get n responses here aswell?
which function should i use in this case?

works thx a lot!


Meta-programming library

We have been using this prelude for the MetaCoq tutorial and our MPRI course, and we've updated it to include nice combinators.
I open this draft to keep track of the consolidation efforts to make it part of the MetaCoq meta-programming library

In my logrel experiments I ended up writing some code to do locally nameless shenanigans (computing fresh names wrt a term, opening and closing a binder), I guess it would make sense to add it here too? :)

Sure!

@MevenBertrand for the locally nameless stuff it would make sense to wait a bit. I will be implementing unification in the next weeks which involves adding named contexts (and utility functions around named contexts) to template-coq :)

Ah, great! Then I won't do it myself. FYI, my current ugly code is here.

FYI, I integrated my changes :

added traversal functions (all variants, including the exotic stuff such as map_term_with_binders and fold_termM)
moved the specialized template monad notations to a module which users can import or not depending on their needs
added a notion of packed_inductive and packed_constructor which are useful for metaprogramming

If CI passes then I'm ready to merge

I'm not sure I get what you are saying. Monads are used in two places at the moment :

in traversal functions (e.g. map_termM) : they really do belong here
in dollar functions (e.g. $quote_def). When the input is incorrect we have a choice between  : failing (tmFail) or returning a dummy result. I think the user experience is nicer if the functions fail. For instance $quote_def nat would fail because nat is not a constant, instead of returning a dummy term.

I don't get your comment "because then all error messages are that the monad was not found", can you explain ?

I meant relying on monad_utils and the type class resolution for the class Monad. I think we should avoid this, and you reverted our changes in that direction I think.

Oh I see, this is an issue since the $ functions are only Notationss, so elaboration happens later...
Would changing the $ functions so that they use tmBind and tmReturn explicitly be enough ?

Yeah, this is how they were before and I think this would be much better.
But then with @yforster we thought it's better not to use the monad class at all, because it never works well…

I reverted to tmBind/tmReturn. Still I think completely removing the template monad is not good idea, but I'm open to discussion. Also I moved the traversal functions to AstUtils.v (because of dependency considerations : this way we can use the traversal functions in template-coq itself.

The remaining failures seem to be due to faulty extraction (and orthogonal to the modifications we did in this branch). I don't know how to solve them, could someone have a look ?

I reverted to tmBind/tmReturn. Still I think completely removing the template monad is not good idea, but I'm open to discussion.

Maybe there is a misunderstanding because I think what you did is perfect. Thanks.

The errors seem completely unrelated to our changes… But maybe it's because now lib.ml is generated or something?

Some of the errors (those which are due to recent changes in coq-core or coq-stdlib) are also present in the main branch of metacoq, and I think I've solved them in this branch. For the extraction errors, I have no idea...

Maybe I shouldn't have made the PR against main? I don't know what the process these days?

Just changing the base branch here doesn't work, can you refactor a bit @MathisBD so we can file against 8.20?

I'm closing since this has been merged into coq.8-20.


In Observer Jobs figure out what to do when HandeEventsFOrPartition job handles no events

The HandeEventsFOrPartition can return a result with LastHandledEventSequenceNumber is Unavailable. We must figure out what to do at this point and figure out if the Job or Observer needs to be the one to deal with this

Fixed by #1534


Proposal for libp2p porcelain:  a documented, versioned, public API

Statement of Problem
libp2p today does not have a clear public API.  We don't define in one place the interface a downstream user of the library should program against.  We don't make clear which abstractions (like peerstore or swarm) are internal to the library (implementation details from a user perspective) versus which are public and intended to be instantiated and operated on in user code.
Imagine trying to write a Linux program without a clear set of documented syscalls, and without a clean separation between kernel concepts (like spin_lock) vs the corresponding userland concepts (sleep call).  That's kind of the situation we are in today.
Part of this problem arises because we are in the process of improving some interfaces.  For example, in the Go implementation, the host object is becoming more robust and abstracting away more implementation details than it did in the past.  Another problem is that the different language implementations are using different terms for similar concepts, e.g., host in Go vs node in JS.
Status
We have solutions to bits and pieces of this.  The examples in go-libp2p/examples and js-libp2p/examples are awesome in showing use of the libraries.  We also have some efforts underway to try to provide broad, cross-language documentation and example code.
Proposed Solution
Let's define a single public interface to libp2p that meets these requirements:

Documented:  clearly define the function calls and objects a programmer should interact with

Some intro documentation should explain cross-language concepts (like what is a DHT, etc)
Pointers to language specific API reference and examples should branch out from there

Versioned:  any real world API needs to be versioned
Backwards compatibility:  programmers need confidence that they can rebase their code onto the next version of a library without breaking anything
Cross language:  our API concepts should be broadly similar across languages (exact function names can differ but concepts must map one-to-one)

Draft interface

https://gist.github.com/jbenet/8e4f894021fcd23fc04086baee5889ad

(edit:  added @jbenet's draft gist as a strawman for debate)

Note that mimicking in Rust the same API as in JavaScript or Go would likely lead to a big performance hit and reduce the compile-time guarantees.

@tomaka certainly agree! as a big fan (& experienced user) of stronger type systems, i'd be happy to take part in determining how to cleanly and semantically map libp2p behaviors to rust.

@tomaka I see what you mean in the abstract.  Maybe we can talk about it next week at the Hackathon so I can understand a few concrete examples.
We should think about the different types of users and how we want to position each language implementation relative to their needs.  For example, perhaps the Rust implementation is specialized for SoC and constrained environments (one focus for you, I think); then it might make sense that Rust only ever implements some parts of the spec, but does so with extremely low memory footprint.  By contrast, the Go implementation (and/or a daemonizable derivative of it) is intended for general purpose Linux servers and JS specialized for the browser.

What would be very useful is a UML model for each of the module. I
understand that we try to accommodate multiple programming languages (Go,
Rust, C#, Java). Some of these languages are functional, other
object-oriented, some use strong typing other weak typing.  But to be on
the same page, I think a UML model will be very helpful. This is a very
common practice in the industry. Mappings from UML model can then be
defined for functional programming or other styles.  Personally, I try to
map the concept from Go to Java and I have a very hard time.
My two cents
On Fri, May 18, 2018 at 4:29 PM, Mike Goelzer<EMAIL_ADDRESS>wrote:

@tomaka https://github.com/tomaka I see what you mean in the abstract.
Maybe we can talk about it next week at the Hackathon so I can understand a
few concrete examples.
We should think about the different types of users and how we want to
position each language implementation relative to their needs. For example,
perhaps the Rust implementation is specialized for SoC and constrained
environments (one focus for you, I think); then it might make sense that
Rust only ever implements some parts of the spec, but does so with
extremely low memory footprint. By contrast, the Go implementation (and/or
a daemonizable derivative of it) is intended for general purpose Linux
servers and JS specialized for the browser.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/libp2p/libp2p/issues/32#issuecomment-390323433, or mute
the thread
https://github.com/notifications/unsubscribe-auth/ACeFLW6zPPBpKAZSwuaatkRFXKPSQj_Tks5tzy8RgaJpZM4T1293
.

--
Stephane Fellah
Chief  Knowledge Scientist
Image Matters LLC
Office: +(703) 669 5510
Cell:<PHONE_NUMBER>

@fellahst That's an interesting idea.  Do you know a good tool that could generate these diagrams based on our code?  My worry with any documentation is that it becomes out of sync with the code.
I worry especially about diagrams that are made by hand because it's usually more work for someone to fix them.
Any suggestions on a good workflow?  I know in a lot of projects people go the other direction (UML -> source code), but I don't think we're likely to adopt that for libp2p.

@mgoelzer From what programming language you want to generate the UML?  Typically conversion is easier from OO languages such as Java, C# or C++. Others are more difficult.  Having a reference implementation in Java, for example, would be useful to generate the UML.  Because it seems we don't have any, I think we should just start from UML.  This will help tremendously people who try to implement libp2p from OO language.  Enterprise Architect is the de-facto UML standard tool out there m but there are other open sources such as Astah that can be used.

Does libp2p/go-libp2p-core serve this purpose now?

@raulk It solves it for go, but not the general case.  Nevertheless, I think we should close this issue.  I have a more nuanced view of the problem than I did over a year ago when I opened the issue.  This issue is too simplistic.


Research: Graph creation API

Try to learn this ASAP. Test/implement on your local working branch.

Initial research and testing done. Next tickets will work on impl.


added contents into numpy.html

@Ro-shni  as we discussed on the call please make these changes and commit by taking latest pull of existing react js compatibility project.


Add AsyncioRunnable

Moves the CoroutineRunnable from Morpheus' Sherlock feature branch to MRC and renames it to AsyncioRunnable as it is heavily dependent on asyncio. Adjustments were made such that the Scheduler would no longer own a task container and/or tasks, leaving the scheduler interface simpler. Instead, the runnable is responsible for the lifetime of the tasks it creates. This leaves the scheduler with a single responsibility.
Much of the code could be moved to MRC proper from PyMRC, but it's not immediately obvious where the code should live or whether it would be reused, so keeping it colocated with the AsyncioRunnable makes the most sense for now, imo.

Closed because some of the changes were made under a faulty understanding of the asyncio event loop running mechanism. Fixed in https://github.com/nv-morpheus/MRC/pull/411


Can't get tweet detail due to requi header

Hi admin, pls check again this funtion. I can't get anything
tweets_by_ids = scraper.tweets_by_id([987, 876, 754])
tweets_details = scraper.tweets_details([987, 876, 754])

@trevorhobenshield We are facing the same issue can you please solve this.

Both are working on my end. You'll have to be careful not to exceed the rate limits, some endpoints are 50 requests/15 mins, others are 500 requests/15 mins. You can set debug=1 to see your current state.


5px overflow in borderless mode when window is maximized.

Tested in win7 and win10.

This is normal - part of the window frame spills beyond the screen when maximized.
Since we are expanding the client area to the whole window, it spills as well.
You can calculate the precise amount by getting the RECT for the current/closest HMONITOR of the window and the window's RECT, and taking the difference between monitor.top and window.top.
Then you could compensate manually for this effect.
It might also be possible to adjust the client rect's top in WM_NCCALCSIZE by that amount, which should resolve it without any manual offsetting. I'll try to see if that works later.

Adjusting the client rectangle to the monitor work rectangle (excludes the task bar) when maximized fixes the problem, and doesn't require the user to be aware of it.
Compare before:

And After:

Under some circumstances you could even see the window spilling onto other screens and under the task bar, though I can't always reproduce it. This fixes that, too.


Error: Error setting property 'pointerEvents' of RNSVGSvgView box-none

Describe the bug
In the PieChart I'm getting the error

Error setting property 'pointerEvents' of RNSVGSvgView with tag #2673: UIView base class does not support pointerEvent value: box-none

To Reproduce
In my case it throws the error as soon as I render the PieChart
Expected behavior
No error thrown
Screenshots

Device: iPhone 15 Simulator
OS: iOS 17.2
Version of the library being used: 1.3.27
React Native 0.68.2

Hi @christophby 👋
Can you please share the code and data?

Hi Christoph,
I am unable to repro the issue. Can you please share the code and data?
Thanks & Regards.
On Mon, 18 Dec 2023, 16:21 Christoph, @.***> wrote:

Describe the bug
In the PieChart I'm getting the error
Error setting property 'pointerEvents' of RNSVGSvgView with tag #2673:
UIView base class does not support pointerEvent value: box-none
To Reproduce
In my case it throws the error as soon as I render the PieChart
Expected behavior
No error thrown
Screenshots
image.png (view on web)
https://github.com/Abhinandan-Kushwaha/react-native-gifted-charts/assets/12933672/70c6cd4a-f69e-4295-b840-b470f304ff11

Device: iPhone 15 Simulator
OS: iOS 17.2
Version of the library being used: 1.3.27

—
Reply to this email directly, view it on GitHub
https://github.com/Abhinandan-Kushwaha/react-native-gifted-charts/issues/472,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AE5ERUBPEXN7G3EXNTNLY3DYKAN2BAVCNFSM6AAAAABAZKEG6WVHI2DSMVQWIX3LMV43ASLTON2WKOZSGA2DMMZWGMYTANY
.
You are receiving this because you are subscribed to this thread.Message
ID: @.***>

@Abhinandan-Kushwaha it seems to be a problem with React Native 0.68.2. So far I didn't have any issues with that RN and this library.

npx<EMAIL_ADDRESS>init AwesomeProject --version 0.68.2

<PieChart
  strokeWidth={2}
  strokeColor={'#f9fafb'}
  donut
  showGradient
  radius={140}
  innerRadius={90}
  data={[
    {
      value: 50.49,
      color: '#08d419',
      gradientCenterColor: '#2057be',
    },
    {
      value: 49.51,
      color: '#2f4b7c',
      gradientCenterColor: '#2f4b7c',
    },
  ]}
/>

Hi @christophby
Can you check in version 1.3.28?

Hi @Abhinandan-Kushwaha, I was having the same issue, and no it is not yet resolved.
In your code in PieChart -> main.tsx, line 204, you're using 'box-none' for RN version > 7, but box-none is not supported in versions greater than 7 either, as my version is 0.71

@Abhinandan-Kushwaha I guess replacing "box-none" with "auto" will solve the issue in both index and main files, it worked for me

@Abhinandan-Kushwaha for me with RN version 0.68.2 it's working now, thank you 🙌🏼

@saurabhafk Can you please check which version of react-native started supporting 'box-none' for  elements?

@Abhinandan-Kushwaha it was 0.64 I think, but idk why it was not working even in my 0.71 version :(

Hi @saurabh Sorry, I meant which version of react-native started supporting 'box-none' for <Svg> elements?
We might need to check with the react-native-svg package.

Hi @saurabhafk @christophby 👋
I am now using box-none for react native versions 0.72 onwards. This fix is available in react-native-gifted-charts versions 1.3.30 and above.


Please add Horizen Yuma TestNet Support

Website
https://yuma-explorer.horizen.io
ChainId
1662
RPC
https://yuma-testnet.horizenlabs.io/ethv1

@Uxio0 HI, can you help us generate it?

Done! Please let us know when it's deployed so we can merge


MzIdentML Validation Feature

[ ] 1. Validation of Crosslinking MzIdentML (mzID) files.

[ ] a. Validate files of a given folder(Input will be file path)
[ ] b. Multiple MzIdentML files
[ ] c. Individual MzIdentML file
[ ] d. Schema Validations
[ ] e. Semantic Validations(If any)
[ ] f. References are valid
[ ] g. Other validations(eg:  No of Protein, peptide, spectra)

[ ]  2. Generate validation report
We can generate a simple report consisting above information

This is a simple start, and let's use this issue to discuss on validation

one issue here is that to fully validate the mzIdentML file you also need the peaklists, e.g. https://github.com/PRIDE-Archive/xi-mzidentml-converter/issues/81

what if we concentrate on (a) 'Validate files of a given folder(Input will be file path)',
and this folder must also contain the peaklist files?
This is easiest to do because its most like how the converter already works.
Also, if it just stops after the first error, then that's easier.
Thoughts on this?

@sureshhewabi - https://github.com/PRIDE-Archive/xi-mzidentml-converter/pull/82 - you can take a look at what I've done there
that PR gives a command line validation option.

arg can be directory or specific file -  https://github.com/Rappsilber-Laboratory/xi-mzidentml-converter/blob/pride/parser/process_dataset.py#L40-L47
it requires peaklists alongside mzId files
the code it uses for schema validation is here - https://github.com/Rappsilber-Laboratory/xi-mzidentml-converter/blob/pride/parser/schema_validate.py
if schema validation passes it creates a sqlite db in temp folder and loads data into it - https://github.com/Rappsilber-Laboratory/xi-mzidentml-converter/blob/pride/parser/process_dataset.py#L281-L326
any errors cause it to print out error and abort

So, as a first attempt, i think covers 1. (a), (c), (d), (e) to very a limited extent, and (f) above.
1.(b) we could live without in short term. 1 (g), as i read it, isn't really validation but summary stats, these could be got be querying the sqlite DB.
For 2. above, info is printed to standard output, think it currently includes the logging info we usually see from the converter.
Its not extensively tested. It passes the file Diogo provided. It fails the schema invalid Kojak file.

what if we concentrate on (a) 'Validate files of a given folder(Input will be file path)', and this folder must also contain the peaklist files?
This is easiest to do because its most like how the converter already works.
Also, if it just stops after the first error, then that's easier.
Thoughts on this?

Yes I agree with that

I agree with that

good, that's the way it works in that PR

Its not currently rejecting files that don't have the sequences in Seq elements.
(That additional requirement of ours.)
It means they break later. (Also of no use to PDB-IHN without sequences?)
I'll need to change so it rejects these.

Also, I think I've find another requirement specific to our system - that all Modifications have masses given.

Also, I think I've found another requirement specific to our system - that all Modifications have masses given.

hmm, i think we shouldn't add that as a requirement, rather the spectrum viewer is broken in some cases at the moment.
(There are other ways the modification masses could be recovered, like the UNIMOD accessions i think.)

so, in PR https://github.com/PRIDE-Archive/xi-mzidentml-converter/pull/84
i think validation works.
It checks that the Seq element is there for target proteins.
I temporarily disabled a check that crosslinks have valid link sites because I think the main file @aozalevsky is using for testing does have invalid link sites in it.


FEAT: Ability to interrupt Devika and give it another command

Self-explanatory. A button for interruption that would allow the user to stop Devika when in an infinite loop, or when it is idling, but showing like if it was still going.

Hmm sometimes i want to stop it after generating the plan and wait for user to confirm.


Use in-memory counters for generating ids/accounts/etc

Instead of using storage for things such as generating "random" json ids, we can probably use something in memory so we can mark those functions as pure/view. To simplify things, we could use a global in-memory counter for this as a randomness seed.

this might not be possible

yup I can't see a way of doing this


Description of help(tc.visualization) is incomplete

Need to add more information in the header of init.py in the visualization directory.
Also, investigate if it's possible to add the exposed functions to the "Package Contents" section

Fixed by #710


Bump SDKs to 3.8.0

Summary
Bump SDKs to 3.8.0.
Motivation
Upgrade the native SDKs to the latest.
Testing

[x] I tested this manually
[ ] I added automated tests

Documentation
Select one:

[ ] I have added relevant documentation for my changes.
[x] This PR does not result in any developer-facing changes.

we just today shipped an iOS 3.8.1 hotfix, could you update this to include that?

@ianlin-bbpos this can be a different PR but 3.8.0 has support for Tap to Pay UX configuration. Can we add that as well? https://github.com/stripe/stripe-terminal-android/blob/master/CHANGELOG.md#tap-to-pay-localmobile

@ianlin-bbpos this can be a different PR but 3.8.0 has support for Tap to Pay UX configuration. Can we add that as well? https://github.com/stripe/stripe-terminal-android/blob/master/CHANGELOG.md#tap-to-pay-localmobile

Copy that.


Remove redundant dataset serialization in server events

Dataset serialization is already handled by state description serialization in the dict_factory's call to StateDescription.serialize()

Stale