Multiple Pinned headers should work within a SliverMainAxisGroup

Steps to reproduce
Put multiple PinnedHeaderSliver in a SliverMainAxisGroup widget
It looks like this issue is talking about the same use case, but it has been closed without further investigation.
Expected results
All the pinned widgets should be pinned to the top of the scroll view.
Actual results
Only the first pinned widget is pinned to the top of the scroll view.
Code sample
Code sample
import 'package:flutter/material.dart';

void main() {
  runApp(const MyApp());
}

class MyApp extends StatelessWidget {
  const MyApp({super.key});

  @override
  Widget build(BuildContext context) {
    return MaterialApp(
      title: 'Flutter Demo',
      home: Scaffold(
        appBar: AppBar(
          title: const Text('SliverMainAxisGroup pinned headers'),
        ),
        body: const CustomScrollView(
          slivers: [
            SliverMainAxisGroup(
              slivers: [
                _Sliver(color: Colors.red, pinned: false),
                _Sliver(color: Colors.green, pinned: true),
                _Sliver(color: Colors.red, pinned: false),
                _Sliver(color: Colors.yellow, pinned: false),
                _Sliver(color: Colors.green, pinned: true),
                _Sliver(color: Colors.red, pinned: false),
                _Sliver(color: Colors.yellow, pinned: false),
                _Sliver(color: Colors.red, pinned: false),
                _Sliver(color: Colors.yellow, pinned: false),
                _Sliver(color: Colors.red, pinned: false),
                _Sliver(color: Colors.yellow, pinned: false),
                _Sliver(color: Colors.red, pinned: false),
                _Sliver(color: Colors.yellow, pinned: false),
                _Sliver(color: Colors.red, pinned: false),
                _Sliver(color: Colors.green, pinned: true),
                _Sliver(color: Colors.yellow, pinned: false),
                _Sliver(color: Colors.red, pinned: false),
                _Sliver(color: Colors.yellow, pinned: false),
                _Sliver(color: Colors.red, pinned: false),
                _Sliver(color: Colors.yellow, pinned: false),
                _Sliver(color: Colors.red, pinned: false),
                _Sliver(color: Colors.yellow, pinned: false),
              ],
            ),
          ],
        ),
      ),
    );
  }
}

class _Sliver extends StatelessWidget {
  const _Sliver({
    required this.color,
    required this.pinned,
  });

  final Color color;
  final bool pinned;

  @override
  Widget build(BuildContext context) {
    final child = Container(
      height: 80,
      color: color,
      child: Padding(
        padding: const EdgeInsets.all(16),
        child: Center(
          child: Text(
            pinned ? 'Pinned' : 'Not pinned',
            style: const TextStyle(fontSize: 30),
          ),
        ),
      ),
    );
    if (pinned) {
      return PinnedHeaderSliver(child: child);
    } else {
      return SliverToBoxAdapter(child: child);
    }
  }
}

Screenshots or Video

Video demonstration
https://github.com/user-attachments/assets/3a318000-d298-4f04-9a75-f97fc4190782

Logs
Logs

Flutter Doctor output
Doctor output
[✓] Flutter (Channel stable, 3.24.3, on macOS 14.1.1 23B81 darwin-arm64, locale fr-FR)
    • Flutter version 3.24.3 on channel stable at /Users/xxxx/.puro/envs/stable/flutter
    • Upstream repository https://github.com/flutter/flutter.git
    • Framework revision 2663184aa7 (2 weeks ago), 2024-09-11 16:27:48 -0500
    • Engine revision 36335019a8
    • Dart version 3.5.3
    • DevTools version 2.37.3

[✓] Android toolchain - develop for Android devices (Android SDK version 34.0.0)
    • Android SDK at /Users/xxxx/Library/Android/sdk
    • Platform android-34, build-tools 34.0.0
    • Java binary at: /Applications/Android Studio.app/Contents/jbr/Contents/Home/bin/java
    • Java version OpenJDK Runtime Environment (build 17.0.7+0-17.0.7b1000.6-10550314)
    • All Android licenses accepted.

[✓] Xcode - develop for iOS and macOS (Xcode 15.4)
    • Xcode at /Applications/Xcode-15.4.0.app/Contents/Developer
    • Build 15F31d
    • CocoaPods version 1.15.2

[✓] Chrome - develop for the web
    • Chrome at /Applications/Google Chrome.app/Contents/MacOS/Google Chrome

[✓] Android Studio (version 2023.1)
    • Android Studio at /Applications/Android Studio.app/Contents
    • Flutter plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/9212-flutter
    • Dart plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/6351-dart
    • Java version OpenJDK Runtime Environment (build 17.0.7+0-17.0.7b1000.6-10550314)

[✓] VS Code (version 1.93.1)
    • VS Code at /Applications/Visual Studio Code.app/Contents
    • Flutter extension version 3.96.0

[✓] Connected device (4 available)
    • IN2023 (mobile)                 • 87950fce              • android-arm64  • Android 13 (API 33)
    • macOS (desktop)                 • macos                 • darwin-arm64   • macOS 14.1.1 23B81 darwin-arm64
    • Mac Designed for iPad (desktop) • mac-designed-for-ipad • darwin         • macOS 14.1.1 23B81 darwin-arm64
    • Chrome (web)                    • chrome                • web-javascript • Google Chrome 129.0.6668.60
    ! Error: Browsing on the local area network for iPhone. Ensure the device is unlocked and attached with a cable or associated with the same local area network as this Mac.
      The device must be opted into Developer Mode to connect wirelessly. (code -27)

[✓] Network resources
    • All expected network resources are available.

• No issues found!

Hi @letsar

It looks like this https://github.com/flutter/flutter/issues/154615 is talking about the same use case, but it has been closed without further investigation.

I see https://github.com/flutter/flutter/issues/154615 is still open. Perhaps you wanted to link to another issue? Can you check and confirm this?

Yes you are right, I wanted to link #155395 instead 🙈

Reproduced the issue as reported on Flutter master 3.26.0-1.0.pre.280.
I'm pretty inclined to consider this issue as a feature request. I see this will work if we have separate SliverMainAxisGroup(s) and move all pinned headers to each SliverMainAxisGroup.
However, marking this as a bug to have thoughts from others. Thanks!

Work as expected when using multiple SliverMainAxisGroup
CustomScrollView(
  slivers: [
    SliverMainAxisGroup(
      slivers: [
        _Sliver(color: Colors.red, pinned: false),
        _Sliver(color: Colors.green, pinned: true),
        _Sliver(color: Colors.red, pinned: false),
        _Sliver(color: Colors.yellow, pinned: false),
      ],
    ),
    SliverMainAxisGroup(
      slivers: [
        _Sliver(color: Colors.green, pinned: true),
        _Sliver(color: Colors.red, pinned: false),
        _Sliver(color: Colors.yellow, pinned: false),
        _Sliver(color: Colors.red, pinned: false),
        _Sliver(color: Colors.yellow, pinned: false),
        _Sliver(color: Colors.red, pinned: false),
        _Sliver(color: Colors.yellow, pinned: false),
        _Sliver(color: Colors.red, pinned: false),
        _Sliver(color: Colors.yellow, pinned: false),
        _Sliver(color: Colors.red, pinned: false),
      ],
    ),
    SliverMainAxisGroup(
      slivers: [
        _Sliver(color: Colors.green, pinned: true),
        _Sliver(color: Colors.yellow, pinned: false),
        _Sliver(color: Colors.red, pinned: false),
        _Sliver(color: Colors.yellow, pinned: false),
        _Sliver(color: Colors.red, pinned: false),
        _Sliver(color: Colors.yellow, pinned: false),
        _Sliver(color: Colors.red, pinned: false),
        _Sliver(color: Colors.yellow, pinned: false),
        _Sliver(color: Colors.red, pinned: false),
        _Sliver(color: Colors.yellow, pinned: false),
        _Sliver(color: Colors.red, pinned: false),
        _Sliver(color: Colors.yellow, pinned: false),
      ],
    ),
  ],
)


[WIP] XML schema for Pirk's Data and Query Schemas

This is currently a work in progress.  Taken from the website documentation, here are some XML schemas to check the correctness of the Pirk data and query definitions.
Not yet validated on a wide selection of Pirk metadata.

+1

I would like to merge this pull request, but the repo/branch is 'unknown repository'. I looked at tellison's branches, but can't seem to find the files. Does anyone know how to resolve this?

Sorry Ellison Anne, I broke it.  Let me close this and open a new PR.


Having trouble debugging single rails minitest file

Hello,
I am attempting to debug a single minitest file in a rails app but I am having some trouble getting the debugger to launch properly.
My current environment is as follows:
macOS: 14.1 (M2 Chip)
rdbg 1.8.0
vscode: 1.84.2 (Universal)
vscode-rdbg: 0.1.0
zsh 5.9 (x86_64-apple-darwin23.0)
My current debug launch config is:
{
  "type": "rdbg",
  "name": "Debug current file with rdbg",
  "request": "launch",
  "command": "rails",
  "script": "test ${relativeFile}:${lineNumber}",
  "args": [],
  "askParameters": true,
  "env": {
    "RUBY_DEBUG_OPEN": true
  }
}

The prompt displays the following command for me to execute:
rails test test/models/product_test.rb:22
After confirming, I get the following output in the debug console:
Ruby REPL: You can run any Ruby expression here.
Note that output to the STDOUT/ERR printed on the TERMINAL.
[experimental]
  `,COMMAND` runs `COMMAND` debug command (ex: `,info`).
  `,help` to list all debug commands.

I am not sure how to verify if the environment variable was set or if it is even useful in this case.
I confirmed the test does run correctly when I copy/paste it in the terminal (warp).
Has anyone managed to get this to work by chance?

What is your question?
BTW why do you use it: "RUBY_DEBUG_OPEN": true?

Sorry I am just now getting back to this.
I am going to close this ticket and open another one with more details of what I am doing and what I am experiencing if I run into any issues.


Error: No PRNG

Describe the bug:
When I call new Switchboard() I get Error: No PRNG.
To Reproduce:

npm init
npm i switchboard.js
add "type": "module" to package.json (otherwise I cannot import switchboard.js)
index.js contents:
import { Switchboard } from 'switchboard.js' const sb = new Switchboard()
$> node ./index.js
receive error on console:
Error: no PRNG  at randombytes

Expected behavior:
Switchboard will start to work
Screenshots:

Desktop (please complete the following information):

OS: Windows 10
Browser Firefox
Version 84.0.2 (64-bit)

I've just been stepping through the code, trying to figure out what's going wrong and I found this:
// Initialize PRNG if environment provides CSPRNG.
// If not, methods calling randombytes will throw.
But I have CSPRNG installed:

I've just been stepping through the code, trying to figure out what's going wrong and I found this:
// Initialize PRNG if environment provides CSPRNG.
// If not, methods calling randombytes will throw.
But I have CSPRNG installed:

Hey, sorry, I missed this issue. Switchboard is not currently built to support running in NodeJS server-side. This may be implemented in the future, if there is enough interest.


Store Enchanter Recipe in the BE

Description
Store Enchanter Recipe in the BE instead of requesting it each time.
Closes #(issue)

Todo

[ ] Test, as this is the 3rth enchanter PR I've made already...

Checklist:

[ ] My code follows the style guidelines of this project (.editorconfig, most IDEs will use this for you).
[ ] I have performed a self-review of my own code.
[ ] I have commented my code in areas it may be challenging to understand.
[ ] I have made corresponding changes to the documentation.
[ ] My changes are ready for review from a contributor.

Is this good to go?


where can i specify credentials for elasticsearch exporter

Hello, i have Elasticsearch cluster with Internode TLS Enabled, so i have users in Elasticsearch, and i'm use the exporter running on my system as systemD daemon, so here is my systemD unit file
[Unit]
Description=Elasticsearch Exporter
After=network.target
[Service]
ExecStart=/opt/prometheus-exporters/elasticsearch-exporter/elasticsearch_exporter \
        --es.uri http://<IP_ADDRESS>:9200/ \\
        --es.timeout 5s \\
        --web.listen-address :9108 \\
        --web.telemetry-path /metrics \\
         --es.ca /etc/elasticsearch/certs/kei.p12 \\
[Install]
WantedBy=multi-user.target

and according to documentation i can't find where i can specify credentials

Not sure this is supported, this exporter use basic golang http and I dont see any reference to authentication in the code.

You can specify the credentials in the url, @.*** works. One downside is that the helm chart sets that environment variable directly in the pod spec, rather than mounting it as a secret, so it’s there for everyone to see when you kubectl describe pod.
-Mike
From: Thomas Decaux @.>
Sent: Monday, June 14, 2021 11:52 PM
To: prometheus-community/elasticsearch_exporter @.>
Cc: Subscribed @.***>
Subject: [EXTERNAL] Re: [prometheus-community/elasticsearch_exporter] where can i specify credentials for elasticsearch exporter (#438)
Not sure this is supported, this exporter use basic golang http and I dont see any reference to authentication in the code. — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub ZjQcmQRYFpfptBannerStart
This Message Is From an External Sender
This message came from outside your organization.
ZjQcmQRYFpfptBannerEnd
Not sure this is supported, this exporter use basic golang http and I dont see any reference to authentication in the code.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHubhttps://github.com/prometheus-community/elasticsearch_exporter/issues/438#issuecomment-861228611, or unsubscribehttps://github.com/notifications/unsubscribe-auth/ALVAJXBACYXJWYOJ2XXDBSTTS32BVANCNFSM46WNRUZQ.

@adammike Hi! so i can do this like that?
--es.uri http://elastic:123453@<IP_ADDRESS>:9200/ right?

Hey,
thank you this helps me for the moment too.
But this isn't really secure. The Password is displayed the in the process overview.
Is there an option to invisiable the password if I run this via systemd. e.g. to seperate into a config file.

A PR will be welcomed :-)
I could do it in a few days if you want
Le mer. 16 juin 2021 à 15:56, noxiii @.***> a écrit :

Hey,
thank you this helps me for the moment too.
But this isn't really secure. The Password is displayed the in the process
overview.
Is there an option to invisiable the password if I run this via systemd.
e.g. to seperate into a config file.
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/prometheus-community/elasticsearch_exporter/issues/438#issuecomment-862402256,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AAJJZ2M625TADB5ANHEJ5QLTTCUPPANCNFSM46WNRUZQ
.

@adammike Hi! so i can do this like that?
--es.uri http://elastic:123453@<IP_ADDRESS>:9200/ right?

yes

In the Helm you can achieve this by combinding a secret and envFromSecret.
Then use the env mapped from the secret in the uri like this:
values.yaml
envFromSecret: elasticsearch-pwd
es:
  uri:  https://$(ES_USERNAME):$(ES_PASSWORD)@url-to-es

To tabbi systemd example above. I load now the parameter with EnvironmentFile into systemd. This works very good and the credentials doesn't show in the process list.
My config looks like: /etc/prometheus/elasticsearch-exporter.conf
# Configuration for the prometheus elasticsearch exporter
ES_URI=https://prometheus:password@localhost:9200
WEB_LISTEN_ADDRESS=:9114
ES_ALL=true
ES_INDICES=true

and the systemd config: /etc/prometheus/elasticsearch-exporter.conf
[Unit]
Description=Elasticsearch Exporter

[Service]
EnvironmentFile=/etc/prometheus/prometheus-elasticsearch-exporter.conf
ExecStart=/usr/local/bin/prometheus-elasticsearch-exporter

[Install]
WantedBy=multi-user.target

Maybe https://github.com/prometheus-community/elasticsearch_exporter/pull/461 could be helpful.

As mentioned, #461 has added support for the credentials as environment variables. If this doesn't solve your needs, please feel free to open a new issue.


pkgconfiguration lost

Hi,
it am not sure if this is done on purpose, but it looks like the Dockerfile sets pkgconfig correctly, but then "forgets" to copy the various .pc files from /opt/ffmpeg.libs/pkgconfig/ to the main image (if I understand correctly it gets a list of dependencies running ldd and just copies those).
Would it be possible to preserve the .pc files?

ACK, it's not trivial as we move the content around so the copy actually change the location, so the content of those files will need to be updated accordingly (sed)

I have the same problem with other packages I build - turns out that by default pkg-config (at least on recent versions) ignores the prefix variable and replaces it with the parent folder of the .pc location (is /usr/local/lib if the .pc is read from /usr/local/lib/pkgconfig), as building in one folder and then moving to a different one is quite a common workflow - so this is generally not an issue.
However, at least in my distribution this default has been overridden (there's a command line option to restore this behaviour) so probably using a sed filter as an enhanced copy is the safest option.
The modification to each .pc file would be always the same, override prefix with /usr/local/lib
I am in the process of updating my own .pc, give me a couple of days and I will be able to share some code

As promised, this is what I am using now:
OLDPREFIX=/opt/ffmpeg
NEWPREFIX=/usr/local
find ${OLDPREFIX}/lib/ -path "*/pkgconfig/*.pc" | while read PCFILE; do
    echo "Updating ${OLDPREFIX} to ${NEWPREFIX} in ${PCFILE}"
    sed -i "s|^prefix=${OLDPREFIX}$|prefix=${NEWPREFIX}|" ${PCFILE}
done

Note this patches the .pc file in place, ready to be copied - a slightly more elegant solution would be to change the sed line to also perform the copy to /usr/local/lib/pkgconfig/


Map not shown in Vaadin 23

Describe the bug
Since today, I noticed that Map AddOn does not work anymore (check also you example).
I've check with Chrome, FireFox and Edge: same result: java script error:
Uncaught (in promise) TypeError: Spread syntax requires ...iterable[Symbol.iterator] to be a function
at qwa (map.js:37:176)
at Lxa.changed (map.js:107:360)
at al (js?...
Expected behavior
No response
Minimal reproducible example
Open Page with Map (also you can check your demo)
Add-on Version
2.2.0
Vaadin Version
23.3.32
Additional information
No response

Exactly the same problem with my app.

Same problem with Vaadin 24.

Same error!
We´ve seen this error today. Yesterday everything was working fine.
Any change in google´s online javascript libraries?

Exactly the same problem with my app.

same problem here.

The issue has to do with some ongoing changes on Google Maps regarding styles that we haven't address yet. In order to get the add-on to work we need to pin the version of the javascript library in use in our web-component as explained here .
Sorry for the inconveniencies, we'll let you know when a new release is done.

Hi Paola.
I do not see what changes needs to be done in your component to solve the problem. Is something to be done on code?. As shown in spanish: "Para la API de Maps JavaScript, puedes inhabilitar la versión más reciente utilizando la versión 3.57, independientemente de qué canal uses.".
How can i set maps version using your API?
Thanks in advance!

The version of the JavaScript library used in the component is given by the version property in the web-component, as it has value "3.exp" is taken the latest available version of the Javascript library. We need to stick to 3.57 for now so we need to update that property value. There's no API in the add-on to do so (and I'm conflicted about if it should be a part of the API or not).
But as a workaround you could use the element API to set the property like googlemaps.getElement().setAttribute("version", "3.57"); after the constructor is being called.

googlemaps.getElement().setAttribute("version", "3.57");

This will require a bit of work to modify in all the classes where we use it, but it will temporarily solve the problem!
Thank you very much!

That´s right!. The change fix the problem!.

googlemaps.getElement().setAttribute("version", "3.57");

This will require a bit of work to modify in all the classes where we use it, but it will temporarily solve the problem! Thank you very much!

Please try new released version 2.2.1

New released version 2.2.1 full solved problem in my app


Feature request: Click to open note instead of Ctrl+Click

While browsing the graph, it is much more convenient to browse and find the data with mouse click.
Should be there an option to allow simple click instead of Ctrl+Click to open note to preview the contents while browsing the graph?
And the leaf node dots might be bigger to click them easier?

IMHO no option needed, Ctrl+click -> click seems natural enough to not make options more complex


Feature: functions on params

Allow functions to be wrapped on params to help reduce noise in a function body. Here is an example use-case:
f = ($($el))->
    $el
    # do something with jQuery object...

would de-sugar to:
var f;

f = function($el) {
  $el = $($el);
  return $el;
};

I tend to push back on feature requests where the current way of writing the code is already straightforward.
If an element needs to be wrapped, I think the reader would find that more easily by reading the body than by trying to understand a strange parameter syntax.
This code is pretty easy to read:
f = (a, b, c) ->
  wrapped_a = wrap(a)
  wrapped_b = wrap(b)

@showell Agreed but what's the consistentcy here? Either we support things like:
f = (a=da, b=db, c=dc)->
    ...

Or we don't. Currently we do. So this issue of function wrapping is just an expansion on that.
An expansion too far? ha..

I'm not sure how your proposal is consistent with default parameters, but even if it were, I'd sacrifice consistency to keep the language simple.  CoffeeScript works pretty much like Ruby and Python, and neither of them have automatic wrapping.
Again, I would just focus on writing simple code:
f = (elem_a, elem_b, c) ->
  a = $(elem_a)
  b = $(elem_b)

Here is the consistency factor between param functions and defaults:
Param defaults can be easily written as:
f = (elem_a, elem_b, c) ->
elem_a ?= ad
elem_b ?= ab
Yet default params were accepted into Coffeescript anyways.
That there is a relatively easy way to write param functions in the body is not a point against param functions just as it wasn't against param defaults. As I see it the goal of either feature is to reduce noise in the function body, boilerplate.
Regarding language copying, if the reason not to support this is because Coffeescript bases its design choices exclusively on ruby/python then yes I am certainly mistaken to come here and proposal much at all.
I can see why param function params might seem more drastic than defaults, but used well it has value, and I don't think this feature is hard to use well. Here is another good use-case for param functions:
# arrayify takes a value, and wraps it in [] if it is not an array, otherwise just returns it
f = (a,b,arrayify(c))->
  # do something

I don't like this proposed feature at all. For me, it hurts the readability of the code, unlike default parameters that help the readability.

Yep, it's an "expansion too far", and I agree with folks that readability is hurt by it. More importantly, a function's executable code belongs in a function's body.


[Bug] Light Shoes throwing NRE when getting back to ship

Describe the bug
Returning to the ship with Light Shoes throws an NRE
To Reproduce
Grab Light Shoes in dungeon, return to ship
Expected behavior
No NRE
Logfiles
light_shoes_NRE.txt

Will be fixed in next version


i m facing issue please guide me

2022-12-27 15:04:25 +0000 [warn]: #0 [out_os] Could not communicate to OpenSearch, resetting connection and trying again. No such file or directory @ rb_sysopen -  (Errno::ENOENT)
2022-12-27 15:04:25 +0000 [warn]: #0 [out_os] Remaining retry: 8. Retry to communicate after 128 second(s).
2022-12-27 15:08:41 +0000 [warn]: #0 [out_os] Could not communicate to OpenSearch, resetting connection and trying again. No such file or directory @ rb_sysopen -  (Errno::ENOENT)
2022-12-27 15:08:41 +0000 [warn]: #0 [out_os] Remaining retry: 7. Retry to communicate after 256 second(s).

i m waiting for your reply i m stuck in

Your issue looks similar to this
https://github.com/fluent/fluentd-kubernetes-daemonset/issues/1353
Try to apply your own configuration using ConfigMap

Thank you for your support

resolved


Suggestion: add TLS mutual authentication

In some situations, TLS client authentication is very convenient.
It allows to offload authentication to the TLS channel itself, and additionally helps hiding what is actually tunneled.
Golang seems to support this natively through the ClientAuth and ClientCAs configs.
From the CLI perspective, it would look very similar to existing TLS parameters. For instance:

Server: gost -L="tls://:443?clientca=ca.pem"
Client: gost -L=:8080 -F="tls://:443?cert=cert.pem&key=key.pem"

For server-side, ?ca=... may look more symmetric with the current certificate pinning feature. However, I guess something more explicit like ?clientca=... would be much less confusing.

This seems to be addressed by v2.11.1.
Thanks a lot @ginuerzh for this amazing tool!


[REFACTOR] Migrate provide / inject syntax to reusable composables

Description
Numerous composables we utilize are closely integrated with each other. Nevertheless, the current integration approach renders several key Nuxt/Vue features unusable, which is regrettable. Specifically, Plugins and Middlewares become inaccessible for Shopware-related composables due to the necessity of utilizing useContext with inject(), a feature restricted to the setup function.
As a developer, it is crucial to have the user context at the earliest stage possible. By fetching data from the app.vue, we inadvertently overlook numerous valuable functionalities that could enhance the user experience.
Use Case
Authentication
Proposed Solution
I recommend adopting a more composable approach such as useAuth from @sidebase/nuxt-auth. This solution is remarkably user-friendly, eliminating the requirement for provide and inject.
Alternatives Considered
I have reviewed https://github.com/shopware/frontends/issues/26, and I firmly believe that this approach is not sustainable. It risks misrepresenting the core concepts that should guide our efforts.
Additional Context
I am happy to assist and engage in discussions for a sustainable solution that allows us to leverage the best of both (Shopware / Nuxt) worlds.

@elkmod see refactor demo as we discussed earlie.

Stackblitz (https://stackblitz.com/~/github.com/maartenvanhunsel/shopware-nuxt-3-refactor)
Github (https://github.com/maartenvanhunsel/shopware-nuxt-3-refactor)

I like your idea as I ran into limitation of using useUser composable in the middleware as well.


ttnn::Argmax planning

Top-level issue to plan and capture feedback for future work

Passing pipelines:

post-commit all: https://github.com/tenstorrent/tt-metal/actions/runs/9423130911
post-commit ttnn unit tests: https://github.com/tenstorrent/tt-metal/actions/runs/9423131946


fuse-modalview example crashes due to seemingly bad linked-list management

The example-project from fuse-modalview crashes after pressing "A button" and then either "Ok" or "Cancel", with the following stack-trace:
System.Exception: Node already has a parent - can only have one
   at Fuse.Visual.Children_MakeParent(Visual parent, Node child) in C:\Users\erik\src\fuselibs\Source\Fuse.Nodes\Visual.Children.LinkedList.uno:line 56
   at Fuse.Visual.Children_Add(Node n) in C:\Users\erik\src\fuselibs\Source\Fuse.Nodes\Visual.Children.LinkedList.uno:line 95
   at Fuse.Visual.Add(Node item) in C:\Users\erik\src\fuselibs\Source\Fuse.Nodes\Visual.Children.uno:line 180
   at Bolav.Modal.ModalJS.RemoveModalUX() in C:\Users\erik\src\fuse-modalview\ModalJS.uno:line 125
   at Fuse.UpdateManager.ProcessPostActionsImpl() in C:\Users\erik\src\fuselibs\Source\Fuse.Common\UpdateManager.uno:line 476

However, adding instrumenting to the code shows that the child being added does indeed have Node.Parent = null. So it seems something is up with our linked-list code.

This seems to fix the problem:
diff --git a/Source/Fuse.Nodes/Visual.Children.uno b/Source/Fuse.Nodes/Visual.Children.uno
index 45e637e..c706e15 100644
--- a/Source/Fuse.Nodes/Visual.Children.uno
+++ b/Source/Fuse.Nodes/Visual.Children.uno
@@ -170,7 +170,10 @@ namespace Fuse
 		void ICollection<Node>.Clear()
 		{
 			for (var c = _firstChild; c != null; c = c._nextSibling)
+			{
+				Children_MakeOrphan(c);
 				OnRemoved(c);
+			}
 			Children_Clear();
 		}

Hmm, this shouldn't be needed, as Children_Clear() calls Children_MakeOrphan()` for all children...


1.5-beta.2. tools/gen_istio_image_list.sh broken

Bug description
For 1.5, looks like the format of the istio-docker.mk has changed and has broken the tools/gen_istio_image_list.sh tool.
Also the tool does NOT support the beta tags 1.5.0-beta.2 the regex's are wrong, should be something like: TAG_REGEX="[0-9].[0-9].[0-9][-]?[beta.]?[0-9]?"
Expected behavior
Steps to reproduce the bug
Version (include the output of istioctl version --remote and kubectl version and helm version if you used Helm)
How was Istio installed?
Environment where bug was observed (cloud vendor, OS, etc)

cc @linsun

@johnma14 can you take a look at this?  Thanks.


Refractor tests in QRNG using Delay operation

Relates to the second point in Issue #557
Changes

Converted the user operations to the parameterless operations using Delay operation
Removed wrapper functions
Unified RetryCheckUniformDistribution and RetryCheckXPercentZero to RetryTestOperation

@tcNickolas , I have done changes as per the review suggestions. Just made a minor change in addition to that. I was not aware of the fact that Q# assumes that any set of parameters is a tuple, and converts it to/from a tuple automatically. So, this fact allowed me to merge "testingHarness" and "delayedTesting" operations into "delayedTesting" for a cleaner code.


Add list of link-local IPs to EndpointIPAMConfig

Signed-off-by: Alessandro Boch<EMAIL_ADDRESS>

LGTM

LGTM


Merge Editor does not automatically resolve identical changes

Type: Bug
When both Incoming and Current contain identical change, Merge Editor still offers manual conflict resolution instead of resolving it automatically by default:

Merge Editor State JSON:
{
    "languageId": "plaintext",
    "base": "A\r\nB\r\n",
    "input1": "A\r\nC\r\n",
    "input2": "A\r\nC\r\n",
    "result": "A\r\nB\r\n",
    "initialResult": "A\r\nB\r\n"
}

VS Code version: Code 1.73.1<PHONE_NUMBER>f055b99068d3688932416f2346dd3b, 2022-11-09T04:27:29.066Z)
OS version: Windows_NT x64 10.0.19045
Modes:
Sandboxed: No
Remote OS version: Linux x64 <IP_ADDRESS>-microsoft-standard-WSL2

/duplicate This is fixed in the latest insider build.

Thanks for creating this issue! We figured it's covering the same as another one we already have. Thus, we closed this one as a duplicate. You can search for similar existing issues. See also our issue reporting guidelines.
Happy Coding!

I just tried with Code Insiders 1.74.0 c87fa19 and the same issue happens when Merge Editor is started from the command line.


Custom Entity give error

Here is what I got when trying to login
An exception occurred while executing 'SELECT t1.id AS id_2, t1.refresh_token AS refresh_token_3, t1.username AS username_4, t1.valid AS valid_5 FROM jwt_refresh_token t1 WHERE t0.refresh_token = ?' with params ["a94eca429273a21f39fc2374fb3984b9b392910a17afeb02e95627066e1d0dd983048a562780456d5b186148fa27acbda27db4821ab18d313314ac3a9107b025"]:

Hi, I had the same problem but solve it copying the whole original entity into my custom refresh token entity

Thanks !

This happens with duplication of UniqueEntity declaration in the base table causing doctrine to execute UniqueEntity check looking for base entity. To resolve it,  I had to remove the @UniqueEntity declaration from the base table: RefreshToken.
Removed all this from Base entity RefreshToken, and copied it to my custom entity.
/**

Refresh Token.

@ORM\Table("refresh_tokens")
@ORM\Entity(repositoryClass="Gesdinet\JWTRefreshTokenBundle\Entity\RefreshTokenRepository")
@UniqueEntity("refreshToken")
*/


Pop-out window

Very occasionally it's nice to be able to view the output in a separate window/tab. Might be cool to have a button to open one, rather than digging around in the DOM to find the URL

I very much agree.
I think this could be implemented by adding something like:
Open in New Tab

...but would need to be carefully tested for errors, etc.
I will create a draft PR to share and discuss the idea.

closed via #329


[Enhancement] Extract the interval of fetchNameServerAddr

Before Creating the Enhancement Request

[X] I have confirmed that this should be classified as an enhancement rather than a bug/feature.

Summary
The task of the Broker to discover the NameServer is performed by BrokerOuterAPI#fetchNameServerAddr at an interval of 2 minutes. The registration interval in BrokerController#registerBrokerAll is 10 seconds.
If the address of the NameServer changes, the Broker may not be able to discover the new NameServer and register with it in a timely manner. It is suggested to extract the interval of fetchNameServerAddr as a parameter for the Broker.
Motivation
The task of the Broker to discover the NameServer is performed by BrokerOuterAPI#fetchNameServerAddr at an interval of 2 minutes. The registration interval in BrokerController#registerBrokerAll is 10 seconds.
Describe the Solution You'd Like
It is suggested to extract the interval of fetchNameServerAddr as a parameter for the Broker.
Describe Alternatives You've Considered
None
Additional Context
No response

hi i want to do this. thx

Suggest set default interval to 10 secones like registerBrokerAll()

can i try it？


[🚀for preview]: replace browser scroll with esl scrollbar

When you resize the preview the browser scroll appears. Replace this scroll with esl scrollbar
Note: If you use the standard way of adding the esll scrollbar, then the resize feature disappears.
In our case, instead of using a esl-scrollable-content class, we need to create our own scrollable-content class so that the feature works.

Resolved on v2.0.0-beta.2


Added Viettel IDC Cloud Infrastructure Submit

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.


JVM destroy seems to be broken with 4.1.20.Final

Expected behavior
JVM must shutdown after close the EventLoopGroup
Actual behavior
since 4.1.20.Final the VM cleanup/shutdown hangs
all previous netty versions are shutdown the VM as expected
Sometimes there is a:
Exception in thread "Thread-2" java.lang.IncompatibleClassChangeError
Steps to reproduce

start test Sample
check if JVM still runs

Minimal yet complete reproducer code
public class Sample {

  public static void main(String[] args) {

    EventLoopGroup group = new NioEventLoopGroup();
    try {
      Bootstrap b = new Bootstrap();
      b.group(group).channel(NioSocketChannel.class).remoteAddress(new InetSocketAddress("localhost", 0)).handler(new ChannelInitializer<SocketChannel>() {
        @Override
        public void initChannel(SocketChannel ch) throws Exception {
          ch.pipeline().addLast(new LoggingHandler());
        }
      });

      ChannelFuture f = b.connect().sync();

      f.channel().closeFuture().sync();
    } catch (InterruptedException e) {
      e.printStackTrace();
    } finally {
      group.shutdownGracefully();
    }
  }
}

Netty version
4.1.20.Final
JVM version
JDK 1.8-162
OS version
Windows 10 x64

This has already been reported as #7617 and fix has been shipped in 4.1.21 that was released today.

fixed, thx

4.1.21 that was released today

Thanks. Can you publish that news to the Netty home page?

On my to do list for tomorrow.... ran out of time today

Am 05.02.2018 um 21:48 schrieb Ngoc Dao<EMAIL_ADDRESS>4.1.21 that was released today
Thanks. Can you publish that news to the Netty home page?
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub, or mute the thread.


Supporting PEM passphrase in grpc core.

    Supporting PEM passphrase in grpc core is something worth doing. But it is not high priority for us and we do not have resource. We could either have interns to implement, or feel free to implement yourself and contribute.

Originally posted by @jiangtaoli2016 in https://github.com/grpc/grpc/issues/14216#issuecomment-386646208

Any update on supporting the pem passphrase in grpc c core?


Fix missing placeholders for exports when invalid script is saved

When saving an invalid script, the export values should have been being
locked.  Instead, they were being destroyed/reset.  This correctly calls
the update for placeholders to exported values so that they don't get
lost.
Tested with a simple exported float value, which was printed in _ready.
Invalidated the script; still saw the exported value in the inspector.
Fixed the script, ran the node, and saw the old value printed out as
expected.
bugsquad edit : Fix #24280

cc @neikeq since you have some familiarity with this part of the code :)

Seems like that's not the original intention of the code. At any rate, nothing has changed, so there is no need to update instances - the same effect should happen by just removing the set_build_failed(true) lines.

@reduz says he's fine with the fix, do you want to review further @neikeq or should we merge as is?

I will review this tonight. There is something that looks wrong to me here which is that we are setting build failed to true and then calling _update_placeholders which sets it to false.

You might be right, I think the important part is the ->update call, I’ll try removing the extra set_build when I’m home this evening and revalidate

I made some progress. I think I know what may be causing this but I can't think straight anymore for today. I will need some more debugging tomorrow.


Bug: Add database (Error running command couchdb-vs.addDatabase)

The error that VSCode throws like clicking on "Add database" button.
Error running command couchdb-vs.addDatabase: command 'couchdb-vs.addDatabase' not found. This is likely caused by the extension that contributes couchdb-vs.addDatabase.

Closing due to inactivity.


Specify how validators claim staking rewards.

In Penumbra's shielded delegation system, delegators simply hold shares of the validator's delegation pool, so they don't have rewards to claim, but validators' commissions are treated as claimable rewards.
Validators need to periodically sweep their rewards from an accumulator into normal shielded notes.  This involves creating transactions with special claim inputs, signed by a key the validator controls.  Ideally, this key would be online, so validators can continuously sweep funds into the shielded pool.
Discussions with some validators indicated that it would be useful to have a separate key for this purpose, rather than reusing the validator's identity key.  This would reduce the operational risk of having an online key to continuously sweep funds, since the key would only have control over rewards as they accumulate, not over any other funds or activity.
(See below, we can instead record the commissions as additional notes that are included into the note commitment tree).

[ ] Remove references to sweeping commissions from the protocol spec
[ ] Think about a general mechanism for how to track notes that are not created from specific transactions

Since we're only distributing commission at epoch boundaries, and only to a limited number of addresses (at most several per validator), there's a much easier alternative: rather than building a bespoke account system for validator commissions, we can have the consensus system record the commission in (public) notes that are included in the note commitment tree.  These would be spent as normal.
The only remaining issue is how to record these notes. I think it would be helpful to move past the assumption (inherited from Zcash) that notes are only created by transactions; this already causes us some issues around special-casing the genesis block.

At this point, we've settled on a design; we just need to write it up as part of the protocol spec.


Bug 1833317: Added script to avoid healthy osd from marking out

This change prevents running osd from being marked out if running osd id is
provided by a user to the osd removal job template.
A constant purgeOSDScript is created with the bash scipt in it which finds the osd status of given a FAILED_OSD_ID.
If osd is up and running, osd will not be marked out. If osd status is down, it will be
taken out of the cluster and purged.
Signed-off-by: Servesha Dudhgaonkar<EMAIL_ADDRESS>(cherry picked from commit 969317a8c350174766a200b7c595dc43c1b9bd79)

Just gonna do this proactively since we already verified it doesn't break anything else in master.
/override ci/prow/ocs-operator-e2e-aws


Can the show method intelligently prompts those parameters?

We create and register a pop -up window
type MProps = {
    name: string,
    age: number,
};

const M = NiceModal.create<MProps>(({ name, age }) => (
    <div>
        {name}-{age}
    </div>
));
NiceModal.register('M_MODAL', M);

When using it, you cannot intelligently indicate the parameters you need to pass
NiceModal.show('M_MODAL', {});

Duplicate of #134?


pull request for e2e test at 12/20/2016 23:56:21

:white_check_mark: Validation status: passed
For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.


Fix custom async matcher stack traces

Summary
Fixes a bug causing custom async matcher stack traces to be lost. The issue was caused by the JestAssertionError being created after the promise for the async matcher resolved - by which point the stack containing the correct stack trace (pointing to the line where matcher was called) has been discarded. The issue was fixed by passing an error that is initialized before the promise resolves.
Test plan
I added an E2e test with a snapshot that ensures that the code fence and stack trace are displayed properly.
Before this fix, running yarn jest for a test that had a failing assertion from async matcher produced output like this:

After the fix, the output looks like this:

Fixes #7066

@SimenB When you have a chance, can you please take a look at my previous comment?

Sorry!

If so, isn't the point of this spec to verify what the stack trace looks like when using async/await?

The point is to verify that the stack is correct when a matcher returns a Promise. So async-await or return Promise is the same, with the latter leaving less junk in the stack (since it doesn't have to be transpiled)

I was just about to message you to let you know that I updated the PR, but I see that you've already merged it. Thanks for the help Simen!


New section form component features

This PR introduces some subtle styling, a11y markup changes and expand / collapse functionality for the Components\Section component. Some additional work is required to ensure that the section is expanded if a validation error occurs.

One additional item is to have a section be open / closed by default. This is likely done via a param and method on the section:
// via additional param
Components\Section::make($heading, $subheading, $schema = [], $open = true);
// or via method
Components\Section::make()->collapsed()
// this could even have a callback to pass in true / false depending on a condition?
Components\Section::make()->collapsed(true|false)

@ryanscherler I think the method with a callback / boolean argument is best.

@ me when it's ready for the expand-on-validation to be implemented and I'll take a look.

Example implemented in the demo:
Components\Section::make(
    'Information',
    'Additional order information',
    [
        Components\FileUpload::make('invoice'),
        Components\RichEditor::make('notes')
             ->placeholder('Notes'),
     ]
)->collapsed(),

@danharrin i think this is ready to go design wise from my end - have at it!


Allow specifying additional FSLeyes arguments

Description
This PR adds the possibility to specify additional FSLeyes arguments:

[x] -cm (color map) and dr (min/max) - done in https://github.com/spinalcordtoolbox/manual-correction/commit/7a6aa3d4a511f96467c088078efbcb991d1ede3f
[x] open different orthoview - done in https://github.com/spinalcordtoolbox/manual-correction/pull/13/commits/e648fffb1f07065e48423de18e4530fef76202d6
[x] add examples to wiki - done in https://github.com/spinalcordtoolbox/manual-correction/wiki/Home/831ca7daa816710e4981e41a8be5c583efc95cbe

NOTE: since a second orthoview cannot be opened from CLI, I proposed a function which creates a custom python script to configure individual orthoviews. Example result:

How to test this PR

Clone:

git clone https://github.com/spinalcordtoolbox/manual-correction.git
cd manual-correction
git checkout jv/add_fsleyes_options
python3 -m venv venv
source venv/bin/activate
pip install -r requirements.txt

Download the testing dataset.

Run:

python manual_correction.py -path-in ~/Downloads/manual_correction_example_dataset/data_processed -config ~/Downloads/manual_correction_example_dataset/files_to_correct.yml -viewer fsleyes -fsleyes-cm blue -fsleyes-dr 0,50 -fsleyes-second-orthoview

FIxes: https://github.com/spinalcordtoolbox/manual-correction/issues/9, https://github.com/spinalcordtoolbox/manual-correction/issues/10

Thank you for testing Sandrine!

ValueError: unsupported format character 't' (0x74) at index 24

Might this be an error caused by Windows or by the French localization of your laptop?

It opens the ortho views, but I don't see the toolbar and location panel.

Again, might it be caused by Windows? Or maybe by the FSLeyes version? You can check the version by:
fsleyes -V

I'm using FSLeyes 1.5.0.

When running the help command, I got this error, that I don't get on the main branch

...
ValueError: unsupported format character 't' (0x74) at index 24

Okay, the ValueError was caused by the % character. Fixed in https://github.com/spinalcordtoolbox/manual-correction/pull/13/commits/e3d9cbcf777a44ba4cbcaba37786ca1d46083549. Source


Conditional row highlighting

Is there a way to implement a css based conditional row highlighting based on a cell value?

Check issue #356
rowClassFunction


[Bug] Unable to run iatlas-data:serve-detach

Is there an existing issue for this?

[X] I have searched the existing issues

What product(s) are you seeing the problem on?
iAtlas
Current behavior
The project iatlas-data was added in the #2411. At the time, I was able to successfully run the containerized application with the command shown below and in the Preview section of the PR.
nx serve-detach iatlas-data

I'm trying to run the same command today and it fails with the following error:
$ docker logs iatlas-data
Traceback (most recent call last):
  File "/src/build_database.py", line 1598, in <module>
    schema = Schema(
  File "/usr/local/lib/python3.10/site-packages/schematic_db/schema/schema.py", line 146, in __init__
    self.schema_graph = SchemaGraph(config.schema_url)
  File "/usr/local/lib/python3.10/site-packages/schematic_db/schema_graph/schema_graph.py", line 18, in __init__
    self.schema_graph = self.create_schema_graph()
  File "/usr/local/lib/python3.10/site-packages/schematic_db/schema_graph/schema_graph.py", line 26, in create_schema_graph
    subgraph = get_graph_by_edge_type(self.schema_url, "requiresComponent")
  File "/usr/local/lib/python3.10/site-packages/schematic_db/api_utils/api_utils.py", line 185, in get_graph_by_edge_type
    response = create_schematic_api_response("schemas/get/graph_by_edge_type", params)
  File "/usr/local/lib/python3.10/site-packages/schematic_db/api_utils/api_utils.py", line 121, in create_schematic_api_response
    raise SchematicAPIError(
schematic_db.api_utils.api_utils.SchematicAPIError: Error accessing Schematic endpoint; URL: https://schematic-staging.api.sagebionetworks.org/v1/schemas/get/graph_by_edge_type; Code: 500; Reason: INTERNAL SERVER ERROR; Time (PST): 2024-03-11 10:40:49.355164-07:00; Parameters: {'schema_url': 'https://raw.githubusercontent.com/CRI-iAtlas/iAtlasSchema/main/iatlas_schema.jsonld', 'relationship': 'requiresComponent'}

Expected behavior
The command should complete successfully.
Anything else?
No response
Commit ID
No response
Are you developing inside the dev container?

[X] I am using the dev container

Code of Conduct

[X] I agree to follow this project's Code of Conduct

Definitely possible! It woudl just take some effort to create the mock data, or change schematic db to be able to take in a subset of the manifests.


Removed unused lambda capture

Nagging Assignee @yifeif: It has been 31 days with no activity and this issue has an assignee. Please update the label and/or status accordingly.

Alex, can u take a look? Thanks.

@naurril, please fix the clang issue, please see https://source.cloud.google.com/results/invocations/d539047c-ef74-4305-a5df-e9f14342df46/targets/%2F%2Ftensorflow%2Ftools%2Fci_build:gen_ci_clang_format_out/log

Hi, @alextp @qlzh727, thanks for your review,  I checked the code carefully and found that parallel_concat_optimizer.cc does have difference from the master branch, although github didn't show them in the commit. Hope this could fix the clang format issue.

Hi, @qlzh727 @alextp, I changed the code format which should be the cause of the clang issue, hope this could solve it.  thanks!

Nagging Assignee @yifeif: It has been 14 days with no activity and this issue has an assignee. Please update the label and/or status accordingly.


Propose language for chair elections

Language is added into GOVERNANCE.md

What happens if more votes are received against than for a singe candidate? (I suggest that a new election be called, with the existing chair remaining in the role).

What happens if there are more than two candidates? I suggest we use a ranked-choice voting system (the best one I know is Schulze, but Meek is pretty widespread, and something as simplistic as the Hare/Dhont (or whatever the Australian parliament system is called) makes sense. (Approval voting and the like I would strongly object to).

If we are electing co-chairs what are we voting for? Two seperate elections; a single "ticket" comprising two candidates; a ranked election with the two highest ranked candidates being appointed?

I suggest we immediately adopt the proposal as it stands, but work on the issues I've identified.

I agree

PGB members, please review.  As soon as practical after the Chairs see a 7-day period with no objections, the Chairs will issue an e-ballot requiring a Full Majority Vote for acceptance.  Once approved, we will merge.

Note that the three commits above added by the chairs above after the call for vote to adopt are non-material changes to address comments by @tkuhrt .  The vote will continue.

Approved by PGB Special Majority Vote


@azure/msal-browser not requesting user consent from app registrations api permissions

Core Library
MSAL.js v2 (@azure/msal-browser)
Core Library Version
2.16.1
Wrapper Library
MSAL React (@azure/msal-react)
Wrapper Library Version
1.0.1
Description
When users sign into the client application they are directed through the login redirect flow. Once authenticated the user will be prompted to consent to the application required permissions, which only list the User.Read scope and none of the API permissions listed in the app registration for the client app. I have configured permissions for my client application through the app registration on the azure portal, but these permissions are not showing up on the consent screen. I have read through the documentation and have not found the source to require the API permissions from the application registration on the portal. Do I need to specify in my config or login request the same permissions I have set for my applications registration on the portal or can I modify my config to include these automatically without requiring me to change code to add/remove API permissions for my application?
Error Message
InteractionRequiredAuthError: invalid_grant: AADSTS65001: The user or administrator has not consented to use the application with ID '{CLIENT_APP_ID}' named '{APP_NAME_FROM_PORTAL}'. Send an interactive authorization request for this user and resource.
Msal Logs
InteractionRequiredAuthError: invalid_grant: AADSTS65001: The user or administrator has not consented to use the application with ID '{CLIENT_APP_ID}' named '{APP_NAME_FROM_PORTAL}'. Send an interactive authorization request for this user and resource.
MSAL Configuration
// Blurred out authority, clientId, and URIS
const msalConfig: Configuration = {
	auth: {
		authority: "https://login.microsoftonline.com/{TENANT ID}",
		clientId: "{CLIENT_APP_ID}",
		redirectUri: "{REDIRECT_URI_FROM_APP_REG}",
		postLogoutRedirectUri: "{REDIRECT_URI_FROM_APP_REG}"
	}
}

const msalInstance = new PublicClientApplication(msalConfig)

Relevant Code Snippets
I believe that I am missing some extra configuration to include the API permissions I have set for my applications registration on the portal.

// I believe I am missing something here with the MsalAuthenticationTemplate for application scopes
<MsalAuthenticationTemplate interactionType={ InteractionType.Redirect }>
   <AppRouter />
</MsalAuthenticationTemplate>

Reproduction Steps

Sign into React application.
Make Request to web API and receive consent error.

Expected Behavior

Sign into React application.
Make request and not get consent error.

Identity Provider
Azure AD / MSA
Browsers Affected (Select all that apply)
Chrome, Firefox, Edge, Safari
Regression
No response
Source
External (Customer)

I fixed this by setting the scopes to .default.
   <AppRouter />
</MsalAuthenticationTemplate>```

@christiankaseburg Yes, you will need to also provide those scopes at runtime to MSAL, in addition to configuring them in the portal. Closing.


[BUG] Project Owner unable to grant users permissions inherited from Kubernetes admin role.

Rancher Server Setup

Rancher version: 2.8.5

Describe the bug
The issue should be general to any Role Template and the way you specify the verbs. Rancher is no taking into account that a complete set of verbs is the same as "".
For example, the Project Owner Role is unable to grant permissions that are inherited as a complete set of verbs from the Kubernetes admin and are assigned to a role using the verb ""
In this case, a Project Owner is unable to grant the Manage Workloads Role to another standard user, and it is expected to happen based in our documentation:
Project Role Reference
The Kubernetes Admin Role grants each of the specific verbs, but Manage Workloads attempts to grant " * ". There is an issue related to a complete set of possible verbs versus " * ** ".
To Reproduce

Provision a Rancher v2.8.5, with a single all role node custom cluster (I used github.com/supereb/tf-do-rancher2).
Create two standard users foo and bar
Grant the user foo the Project Owner role on the Default project in the downstream cluster
As user foo attempt to grant the Manage Workloads Role on the Default project in the downstream cluster to user bar, observe error of the format `admission webhook "rancher.cattle.io.projectroletemplatebindings.management.cattle.io" denied the request: user "u-4w2zk" (groups=["system:authenticated" "system:cattle:authenticated"]) is attempting to grant RBAC permissions not currently held:

{APIGroups:[""], Resources:["pods"], Verbs:[""]}
{APIGroups:[""], Resources:["pods/attach"], Verbs:[""]} {APIGroups:[""], Resources:["pods/exec"], Verbs:[""]} {APIGroups:[""], Resources:["pods/portforward"], Verbs:[""]} {APIGroups:[""], Resources:["pods/proxy"], Verbs:[""]} {APIGroups:[""], Resources:["replicationcontrollers"], Verbs:[""]} {APIGroups:[""], Resources:["replicationcontrollers/scale"], Verbs:[""]} {APIGroups:["apps"], Resources:["daemonsets"], Verbs:[""]} {APIGroups:["apps"], Resources:["deployments"], Verbs:[""]} {APIGroups:["apps"], Resources:["deployments/rollback"], Verbs:[""]} {APIGroups:["apps"], Resources:["deployments/scale"], Verbs:[""]} {APIGroups:["apps"], Resources:["replicasets"], Verbs:[""]} {APIGroups:["apps"], Resources:["replicasets/scale"], Verbs:[""]} {APIGroups:["apps"], Resources:["statefulsets"], Verbs:[""]} {APIGroups:["apps"], Resources:["statefulsets/scale"], Verbs:[""]} {APIGroups:["autoscaling"], Resources:["horizontalpodautoscalers"], Verbs:[""]} {APIGroups:["batch"], Resources:["cronjobs"], Verbs:[""]} {APIGroups:["batch"], Resources:["jobs"], Verbs:[""]}
`
5. As admin, clone the Project Owner Role and give a different name (Project Owner Mod Role)

In the "Inherit from" tab, assign the "Manage Workloads" built-in Role in addition to the "Kubernetes Admin Role"
As user foo attempt to grant the Manage Workload project role on the Default project in the downstream cluster to user bar again, and observe success.

Result
Project Owner cannot grant built-in roles with verbs already inherited because they have been specificied as "*".
Expected Result
Built-in roles should use explicit verbs for granting permissions instead of " * ". For example, Manage Workloads could grant specific verbs where it currently grants " * ".
workaround:
As admin, clone the Project Owner Role and give a different name (Project Owner Mod Role)
In the "Inherit from" tab, assign the "Manage Workloads" built-in Role in addition to the "Kubernetes Admin Role"
As user foo attempt to grant the Manage Workload project role and observe success.

https://jira.suse.com/browse/SURE-8795

https://jira.suse.com/browse/SURE-8806 is related

potentially this will come down to just updating the docs

The problem is that Manage Workloads has more permissions in some resources than the Project Owner.
For example, for pods:
Manage Workloads tries to give *
Project Owner (admin inherited ClusterRole) has: get, list, watch, create, delete, patch, update (but no *)
Then the webhook reject the requests, which is the expected behavior.
We could change Project Owner to inherit Manage Workloads

Release Note
The "Manage Workloads" role template was updated to fix issue #47000. Any custom role inheriting from this template using custom verbs will need to be updated, specifying the used verbs, or adding the * to the impacted resources. The list of the resources can be found in the PR https://github.com/rancher/rancher/pull/47171.

Recreated the issue with v2.9.2. I've validated all scenarios documented in the test plan for this issue with v2.10-ae9edd7151ea0a2387b0dcf3d9387eff74d9d101-head

Fresh install - Verify that the user with Project Owner role can grant the Manage Workloads role to another user
Fresh install - Verify that the "Manage Workloads" role has specific permissions assigned for resources
Fresh install - Verify that a user granted the Manage Workloads role by a Project Owner can CRUD pods
Fresh install - Verify that a user granted the Manage Workloads role by a Project Owner can CRUD deployments
Fresh install - Verify that a user granted the Manage Workloads role by a Project Owner can CRUD daemonsets
Fresh install - Verify that a user granted the Manage Workloads role by a Project Owner can CRUD statefulsets
Fresh install - Verify that a user granted the Manage Workloads role by a Project Owner can CRUD cronjobs
Fresh install - Verify that a user granted the Manage Workloads role by a Project Owner can CRUD jobs
Fresh install - Verify that the user with Project Owner role can grant a custom role (inheriting from "Manage Workloads") to another user
Fresh install - Escalation check - Verify that a user cannot grant a custom project role with RBAC permissions they do not possess
Fresh install - Verify that the Project Owner can revoke the Manage Workloads role from a user
Upgrade - Verify that the user with Project Owner role can grant the Manage Workloads role to another user
RBAC Regression tests - TestProjectRolesTestSuite and TestRBACTestSuite


Docs: Incorrect link to d.ts declaration file in wiki doc JavaScript Language Service in Visual Studio

https://github.com/microsoft/TypeScript/wiki/JavaScript-Language-Service-in-Visual-Studio#-intellisense-based-on-typescript-declaration-files has a link to more info which is archived.
It should probably be pointed somewhere else. i am unsure where.

Hi @RyanCavanaugh I want to work on this issue can you please help me for my first contribution


ODBC Driver for SQL Server should be installable with winget

Add the ability to install ODBC driver for SQL server with winget.

Document Details
⚠ Do not edit this section. It is required for learn.microsoft.com ➟ GitHub issue linking.

ID: a36a1d7f-a410-b597-0eb7-98212934fb0e
Version Independent ID: e706f2bd-e051-fcff-7c3d-2ef3d9f80e87
Content: Download ODBC Driver for SQL Server - ODBC Driver for SQL Server
Content Source: docs/connect/odbc/download-odbc-driver-for-sql-server.md
Service: sql
Sub-service: connectivity
GitHub Login: @David-Engel
Microsoft Alias: v-davidengel

@Stiverton -- Andrew, thank you for your suggestion.  Please add it here:

SQL Server feedback


e2e testing: paginations of repos

Pagination context is the "load more" button. The button should appear when there are more repos to show.

Accessibility should also be tested.

hi, has that feature been added yet?
also, on a side note:
it seems the page can also benefit from a view selector where they cuold change the amount of columns to view projects so they don't have to scroll all the way down. And also there seems to be a flash of unstyled content that could be an easy fix as well.
sorry if i'm mistaken!

Hi @ghorus, thanks for chiming in. This hasn't been worked on yet. It's an old issue that the team will reevaluate at some point.


Accept non-isolated functions as arguments

With the runtime API changes, the log module was refactored. With this, non-isolated functions are not accepted as arguments. Ideally, users should be able to input both isolated and non-isolated functions. The following are the related PRs.
https://github.com/ballerina-platform/module-ballerina-log/pull/27
https://github.com/ballerina-platform/module-ballerina-log/pull/28

Closing the issue since all the log module functions are isolated and hence cannot accept non-isolated function pointers as arguments.


fix(backend): filtering components of third-party libraries to script(other)

Description
Problem: if you use third-party ui libraries, the instance of the used components gets into the "setup" block and is mixed with the instance of your component, which is very annoying.

Solution: Added check for component and redirect components to "script(other)" block

Additional context

What is the purpose of this pull request?

[ ] Bug fix
[ ] New Feature
[ ] Documentation update
[x] Other

Before submitting the PR, please make sure you do the following

[x] Read the Contributing Guidelines.
[x] Read the Pull Request Guidelines and follow the Commit Convention.
[x] Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
[x] Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).

@Akryum Hello. will it be possible to add this to the next release? instance of components of third-party libraries is very disturbing in the setup block. The screenshots show an example of when you use Ant Design Vue components. Or write if you have any comments or problems with this change


duti: update to new darwin SDK pattern

Uses apple-sdk_11, sets host configuration flag based on host architecture, and nixfmt the package file.
Part of #354146.

Things done

Built on platform(s)

[ ] x86_64-linux
[ ] aarch64-linux
[x] x86_64-darwin
[x] aarch64-darwin

For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)

[ ] sandbox = relaxed
[ ] sandbox = true

[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[x] Tested basic functionality of all binary files (usually in ./result/bin/)
25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[x] Fits CONTRIBUTING.md.

Add a :+1: reaction to pull requests you find important.

Result of nixpkgs-review pr 357745 run on aarch64-darwin 1

1 package built:

duti

Could you handle the backport?


Settings: Allow disabling archive page

Feature Description

See #4862 for history / context on this matter.
We want to allow users to disable the default /web-stories archive page.
The idea is to add a new section to the settings page with a dropdown offering two options:

Default
Disable

Here are some mocks:
Default

For convenience, a link to the current archive page can be displayed.
Note: We might offer an option to customize the /web-stories/ slug in the future
Disable

Notes

In places like the Web Stories block, the TinyMCE button and the customizer, we must hide the UI option for displaying an archive link if the archive has been disabled.
This can be behind a feature flag initially
Need to flush rewrite rules when changing this setting

Alternatives Considered

Additional Context

Regarding this test step:

Test archive is really disabled
Diable Stories Archive ( see above ).
Go to /web-stories on the front end.
Ensure page is a 404.

Seeing this instead of a 404 page:

@csossi Looks like there is a general issue with 404s on thee QA site. Opening https://stories-qa-wordpress-amp.pantheonsite.io/sfsfsfsgfsg/ should 404 in theory but for some reason doesn't. On my local site it works as expected.
So let's ignore that for QA here.
Is everything else working?


Skip minified files when searching

VSCode Version: 1.11.1
OS Version: 10.12.3

I don't think anyone want to read minified files. Searching text in files can skip those minified css, js files by default, add a setting to enable/disable this feature.
Steps of use case:

cmd + shift + f to open the search
Type any text to search the text in files

then exclude these files by a pattern **/*.min.* in your user/workspace settings. they have to have min in their name usually. Don't expect anyone to write an interpreter that would detect a minified content.

I can't think of a good way to make this work. I recommend using search.exclude or the new gitignore support in search.


Extracted PropTypes from prop-types

@Froelund This needs an explicit dependency to prop-types in package.json. I can merge as soon as you add that as well. Thanks!

@Froelund  please update the package.json file so that @jmurzy  can merge this. It's essential.


add metrics third-party custom info

Description of the change:

Add info over how to customize the metrics when third-party APIS are added in the project
Fix website doc which was outdated.

Closes #2798
Related to :#2811

Agree @joelanford I will move it. Tks for the review.

Hi @joelanford,
It was moved to the Monitoring/Metrics doc which shows more appropriated. Let me know if you are ok with now.

Closing this one since it will be affected by the integration with Kubebuilder. For further information see the comment : https://github.com/operator-framework/operator-sdk/issues/2798#issuecomment-613543951


I want to see the discounts in the category page So I can be attracted by lower prices

Context
We may have Cart Price Rules and Catalog Price rules, which affect the price. The second ones might be displayed in the category page. We should be able to see these discounts in the category page.
The way of displaying it (just smaller range, strikethrough original price etc.) needs to be discussed.
Acceptance criteria

When the product has some Catalog Price Discount then I can see that in a Catalog Page.
When I add the product to the cart then I can see discounted price in a cart.

done


Set up the development environment

As a developer, I want to set up a development environment for building and testing my microservice.

User Story: As a developer, I want to have a well-configured development environment so that I can start working on the project.


Adding DCO documentation to allow installing the DCO robot app

Type of change

Documentation

Description
Adding the DCO documentation that will allow us to install the robot app (#852)
Checklist
Please go through this checklist and make sure all applicable tasks have been done

[ ] Write tests
[ ] Make sure all tests pass
[ ] Review performance test results. Ensure that any degradations to performance numbers are understood and justified.
[ ] Make sure all Sonarcloud warnings are addressed or are justifiably ignored.
[ ] Update documentation
[ ] Reference relevant issue(s) and close them after merging
[ ] For user facing changes, update CHANGELOG.md (remember to include changes affecting the API of the test artefacts too).

@strimzi-ci run perf

:arrow_forward: Build started - check Jenkins for more info. :arrow_forward:

:arrow_forward: Build started - check Jenkins for more info. :arrow_forward:

:heavy_check_mark: Test Summary :heavy_check_mark:
BUILD NUMBER: 2
KAFKA VERSION: null
NUMBER OF BROKERS: 1
NUMBER OF MESSAGES: 30000000
MESSAGE SIZE: 1024 bytes
PRODUCER PROPERTIES: acks=all
:heavy_exclamation_mark: Performance Tests Failed for Producer (no tests results are present) :heavy_exclamation_mark:
:heavy_exclamation_mark: Performance Tests Failed for Consumer (no tests results are present) :heavy_exclamation_mark:

:arrow_forward: Build started - check Jenkins for more info. :arrow_forward:

:heavy_check_mark: Test Summary :heavy_check_mark:
BUILD NUMBER: 3
KAFKA VERSION: 3.7.0
NUMBER OF BROKERS: 1
NUMBER OF MESSAGES: 300
MESSAGE SIZE: 1024 bytes
PRODUCER PROPERTIES: acks=all
:heavy_exclamation_mark: Performance Tests Failed for Producer (no tests results are present) :heavy_exclamation_mark:
:heavy_exclamation_mark: Performance Tests Failed for Consumer (no tests results are present) :heavy_exclamation_mark:

:arrow_forward: Build started - check Jenkins for more info. :arrow_forward:

:heavy_check_mark: Test Summary :heavy_check_mark:
BUILD NUMBER: 4
KAFKA VERSION: 3.7.0
NUMBER OF BROKERS: 1
NUMBER OF MESSAGES: 300
MESSAGE SIZE: 1024 bytes
PRODUCER PROPERTIES: acks=all
:small_blue_diamond: Producer
Test Case 01-no-proxy-baseline Results

Latency
Current Value (dbc75f7)
Previous Value (610a133edf5562f19598c05608101abf92464d38)

Rate rps
1023.8908 rec/s
78951.94 rec/s

Rate mips
1.0 Mi/s
77.1 Mi/s

AVG Latency
14.36 ms
388.37 ms

95th Latency
21 ms
458 ms

99th Latency
21 ms
486 ms

Test Case 02-no-filters Results

Latency
Current Value (dbc75f7)
Previous Value (610a133edf5562f19598c05608101abf92464d38)

Rate rps
940.43884 rec/s
81663.09 rec/s

Rate mips
0.92 Mi/s
79.75 Mi/s

AVG Latency
24.78 ms
375.44 ms

95th Latency
30 ms
412 ms

99th Latency
32 ms
435 ms

Test Case 03-transform-filter Results

Latency
Current Value (dbc75f7)
Previous Value (610a133edf5562f19598c05608101abf92464d38)

Rate rps
983.60657 rec/s
85919.51 rec/s

Rate mips
0.96 Mi/s
83.91 Mi/s

AVG Latency
20.69 ms
356.81 ms

95th Latency
24 ms
392 ms

99th Latency
26 ms
414 ms

Test Case 04-envelope-encryption-filter Results

Latency
Current Value (dbc75f7)
Previous Value (610a133edf5562f19598c05608101abf92464d38)

Rate rps
967.74194 rec/s
72928.11 rec/s

Rate mips
0.95 Mi/s
71.22 Mi/s

AVG Latency
22.95 ms
420.46 ms

95th Latency
28 ms
457 ms

99th Latency
30 ms
485 ms

Test Case 05-envelope-encryption-filter-no-encrypt Results

Latency
Current Value (dbc75f7)
Previous Value (610a133edf5562f19598c05608101abf92464d38)

Rate rps
993.3775 rec/s
82448.39 rec/s

Rate mips
0.97 Mi/s
80.52 Mi/s

AVG Latency
18.48 ms
371.83 ms

95th Latency
24 ms
409 ms

99th Latency
25 ms
429 ms

:small_blue_diamond: Consumer
Test Case 01-no-proxy-baseline Results

Latency
Current Value (dbc75f7)
Previous Value (610a133edf5562f19598c05608101abf92464d38)

data.consumed.in.MB
0.4883
29296.973

MB.sec
1.5307
298.5557

data.consumed.in.nMsg
500
30000100

nMsg.sec
1567.3981
305721.03

rebalance.time.ms
274
285

fetch.time.ms
45
97844

fetch.MB.sec
10.8507
299.4253

fetch.nMsg.sec
11111.111
306611.53

Test Case 02-no-filters Results

Latency
Current Value (dbc75f7)
Previous Value (610a133edf5562f19598c05608101abf92464d38)

data.consumed.in.MB
0.4883
29296.973

MB.sec
1.4663
298.352

data.consumed.in.nMsg
500
30000100

nMsg.sec
1501.5015
305512.44

rebalance.time.ms
277
278

fetch.time.ms
56
97918

fetch.MB.sec
8.7193
299.1991

fetch.nMsg.sec
8928.571
306379.8

Test Case 03-transform-filter Results

Latency
Current Value (dbc75f7)
Previous Value (610a133edf5562f19598c05608101abf92464d38)

data.consumed.in.MB
0.4883
29296.973

MB.sec
1.5403
219.2871

data.consumed.in.nMsg
500
30000100

nMsg.sec
1577.2871
224549.97

rebalance.time.ms
265
291

fetch.time.ms
52
133310

fetch.MB.sec
9.39
219.7658

fetch.nMsg.sec
9615.385
225040.12

Test Case 04-envelope-encryption-filter Results

Latency
Current Value (dbc75f7)
Previous Value (610a133edf5562f19598c05608101abf92464d38)

data.consumed.in.MB
0.4883
29297.11

MB.sec
1.507
187.4055

data.consumed.in.nMsg
500
30000240

nMsg.sec
1543.21
191903.28

rebalance.time.ms
276
270

fetch.time.ms
48
156060

fetch.MB.sec
10.1725
187.7298

fetch.nMsg.sec
10416.667
192235.3

Test Case 05-envelope-encryption-filter-no-encrypt Results

Latency
Current Value (dbc75f7)
Previous Value (610a133edf5562f19598c05608101abf92464d38)

data.consumed.in.MB
0.4883
29296.973

MB.sec
1.4978
298.5253

data.consumed.in.nMsg
500
30000100

nMsg.sec
1533.7423
305689.88

rebalance.time.ms
279
265

fetch.time.ms
47
97874

fetch.MB.sec
10.389
299.3336

fetch.nMsg.sec
10638.298
306517.56


Create REST API

Likely using Azure Functions:
https://learn.microsoft.com/en-us/azure/azure-functions/functions-bindings-http-webhook-trigger?pivots=programming-language-java&tabs=python-v2%2Cin-process%2Cfunctionsv2#example


assert: Replace CONFIG_BOARD_ASSERT_RESET_VALUE with BOARDIOC_SOFTRESETCAUSE_ASSERT

Summary
unify the reset cause value
Impact
Minor
Testing
CI

Changing this API is not OK. It breaks systems that pass the value CONFIG_BOARD_ASSERT_RESET_VALUE to mean s something. 0 reboot, 1 boot to ROM... etc

Once before this was changed: the default was moved from 0 to 1. That broke all code using the value.

But, the default value is 1 not 0:
https://github.com/apache/nuttx/pull/8940/files#diff-60cc096e3a9b22a769602cbbc3b0f5e7731e72db7b0338da04fcf665ed753b64L4064

Ok, I fix the problem with a different method, @davids5 please review this patch: https://github.com/apache/nuttx/pull/8956.


Add holidays func

Hi, i've found the valentines function (very funny), i decided to extends them with holidays check.
This func check find a match with month - day and write a image.
I know this commit it's only for fun, but after all doesn't exist only Valentine's day <3

I love this


.NET submits invalid Complete callback request

When submitting Complete requests, the .NET runtime emits error instead of err for failures. This causes the kernel to assume success with undefined value.

I have a fix for this. I'm trying to figure out why the existing compliance tests didn't break with this error (throwing from a callback is part of the tested behavior)


Windows Mixed Reality Headset not connecting to a new Unity project

Describe the bug
Mixed Reality Headset does not connect to unity.
To reproduce
Steps to reproduce the behavior:

Create new 3D Unity project
Configure project and import MRTK with package manager.
Add scene and configure
Connect WMR headset
Press play.
Headset does not display/connect to unity.

Expected behavior
WMR to connect to unity play instance.
Screenshots
If applicable, add screenshots to help explain your problem.
Your setup (please complete the following information)

Unity Version 2019.4.12f1
MRTK Version v2.5.0

Target platform (please complete the following information)

WMR immersive

Additional context
Followed https://microsoft.github.io/MixedRealityToolkit-Unity/version/releases/2.5.0/Documentation/Installation.html except using the package manager to install MRTK.

Daft question, but have you checked your VR / XRSDK settings?  That's usually the first thing to verify if it only launches in 2D or only in the editor

Daft question, but have you checked your VR / XRSDK settings? That's usually the first thing to verify if it only launches in 2D or only in the editor

Are you referring to the XR Plug-in Management settings? I have enabled it for WMR.
I think I just messed up somewhere when configuring the project.


Month label showing YEAR MXX after upgrading from version 1.5.0

Hello,
After upgrading from version 1.5.0 to 1.8.0, I noticed that the month label was showing as YEAR MXX (for example: 2021 M03 instead of March 2021) -- Any idea why this is happening? Note that I'm not using any custom view for the month headers.
Thanks!

@rs658726 thanks for the bug report! What Calendar / locale are you using? When you initialize CalendarViewContent, you need to pass in an instance of Calendar - what does this look like for you? If you're omitting the calendar argument when initializing CalendarViewContent, then it should be using Calendar.current by default. What locale is this for you?
For context, for en-US locale, the default month headers look correct in the example app.

@rs658726 could I get some more details when you have a chance? Thanks!

Sorry for the delay @bryankeller
I'm using the default locale and this is how I initialize calendar view content:
CalendarViewContent(calendar: Calendar(identifier: :gregorian), visibleDateRange: startDate ... endDate, monthsLayout: monthsLayout)

Thanks @rs658726 , the problem is you're creating a brand new calendar instance that doesn't have a Locale set. If you don't want to use Calendar.current, you can do this to solve your problem:
var calendar = Calendar(identifier: .gregorian)
calendar.locale = Locale(identifier: "en_us") // you can read Calendar.current.locale instead to ensure that this translates properly

let content = CalendarViewContent(
    calendar: calendar,
    visibleDateRange: startDate...endDate,
    monthsLayout: monthsLayout)


Optimize theme usage in editor log

This PR makes the editor log cache used theme properties instead of accessing them from theme for each line. I haven't benchmarked, but it should result in a visible speed-up when printing lots of messages.
@jordo you can check if this helps for the issues you reported.
EDIT:
Fixes #64241 probably.

Issue describing the performance regression is #64241 .

BTW although this fixes the bug, I think in the general case we should also look at the controls caching this stuff, because presumably this problem is occurring all over the shop.

BTW although this fixes the bug, I think in the general case we should also look at the controls caching this stuff, because presumably this problem is occurring all over the shop.

My work towards first-class theme properties should cover that, but in this case EditorLog is that control that needs to do its own caching, so this PR does exactly that.

Thanks! For 3.x there needs to be a separate PR because the code differs a lot. Starting from get_theme_* renames and ending with the entire editor_log.h/cpp which was rewritten but not backported yet (because its performance regressions need to be fixed first).

@KoBeWi @lawnjelly This does help as a stop bap with the particular issue of the editor log, but it doesn't address underlying issue in the engine, that large portions of the Control API are now much slower...  Example get_icon and get_color which are used by many other things other than the editor log.
I have started another PR https://github.com/godotengine/godot/pull/64293 hat will help with some parts, but those functions (get_icon and get_color) on control just can't be that expensive.  I will have to open another proposal to discuss how we need to change those to be more performant again.


Registering with FastAPI

Hi, I am very interested in using this but I can't figure out how to register it for FastAPI. Django made it so easy that I never had to really figure out how to register but I am running into issues when I create a tag and then try to use it elsewhere in my code.
Any tips would be much appreciated!

server.py:
import datetime

from fastapi import FastAPI, Request
from fastapi.templating import Jinja2Templates
from jinja2_simple_tags import StandaloneTag

class NowExtension(StandaloneTag):
    tags = {"now"}

    def render(self, format="%Y-%m-%d %H:%I:%S"):
        return datetime.datetime.now().strftime(format)

class CustomJinja2Templates(Jinja2Templates):
    def __init__(self, *args, **kwargs):
        super().__init__(*args, **kwargs)
        self.env.add_extension(NowExtension)

app = FastAPI()
templates = CustomJinja2Templates(
    directory="templates/"
)

@app.get("/")
def root(request: Request):
    return templates.TemplateResponse("page.html", {
        "request": request,
    })

page.html:
<!DOCTYPE html>

  <meta charset="UTF-8">
  <title>Demo page</title>

Current time: {% now "%H:%I:%S" %}

Thank you so much! This is exactly what I was looking for!


Updated README links

Fixed a few of the react component links. The "particle container" one was broken and most pointed to the wrong spot. Also, a lot of the links pointed to the home page and when I was getting started using tsparticles it confused me so I put a few direct links. To sum it all up I hopefully made it easier for users to get information and updated a few links.

Sorry but the dev branch is going to have a lot of breaking changes, can you start from v1 and target that branch instead? Those readme-files need a huge review for explaining better what is changed with v2

Not a problem at all!
I can definitely start with that tonight, I’m just happy to help. I look forward to the changes whatever they may be.
Thank you!

On Feb 8, 2022, at 5:53 PM, Matteo Bruni @.***> wrote:

Sorry but the dev branch is going to have a lot of breaking changes, can you start from v1 and target that branch instead? Those readme-files need a huge review for explaining better what is changed with v2
—
Reply to this email directly, view it on GitHub, or unsubscribe.
Triage notifications on the go with GitHub Mobile for iOS or Android.
You are receiving this because you authored the thread.


Confluent control center: typo in environment variable

See: https://github.com/mesosphere/universe/blob/version-3.x/repo/packages/C/confluent-control-center/10/marathon.json.mustache#L24
On line 24 of the marathon template, for the environment variable CONTROL-CENTER_MONITORING_INTERCEPTOR_TOPIC_PARTITIONS there is a dash between CONTROL and CENTER where an underscore should be used.

Thanks @dirkjonker!
This issue was fixed in later releases.


[Bug] 4.0.x -- Table field "suddenly" skipping mutator.

Bug report
What I did
Attempted to store a new value via table field.
What I expected to happen
Value should have been stored as expected.
What happened
Database field remains null as if the table field contained no values. Other fields saved correctly and a success message was generated.
(A similar issue happened a couple of months ago for a couple of hours in June or July, the Table field was not submitting properly and causing a validation error. It suddenly started working again after a while with no updates or releases as if an external Javascript dependency had broken and been fixed.)
What I've already tried to fix it

I have confirmed that my getExternalIdTableAttribute accessor is still working correctly for models with existing data.
I have verified that the post contains the external_id_table field in the expected structure.
I have confirmed that my setExternalIdTableAttribute setter is not being called. Neither CRUD nor the model has been updated since it was last working correctly.

Backpack, Laravel, PHP, DB version
The only recent update I've made was an update from Laravel 6.18.34 to 6.18.40, which I don't think should have altered how mutators work.
When I run php artisan backpack:version the output is:
### PHP VERSION:
PHP 7.3.5-1+ubuntu18.04.1+deb.sury.org+1 (cli) (built: May  3 2019 10:00:24) ( NTS )
Copyright (c) 1997-2018 The PHP Group
Zend Engine v3.3.5, Copyright (c) 1998-2018 Zend Technologies
    with Zend OPcache v7.3.5-1+ubuntu18.04.1+deb.sury.org+1, Copyright (c) 1999-2018, by Zend Technologies

### LARAVEL VERSION:
v6.18.40@e42450df0896b7130ccdb5290a114424e18887c9

### BACKPACK VERSION:
4.0.61@1977e0cc52fa7cf9547eaeadf03f5cd88402b574

UPDATE: It looks like that Laravel version update is responsible. See this issue -- https://github.com/laravel/framework/issues/33978
Leaving open for the moment in case someone wants to add thoughts. Can be closed at any time since this is not actually a CRUD issue.

Ugh. Sounds like trouble. Good luck making your case @trip-somers ! 🤞

I think I had the same issue, the mutator wan't working although the accessor method was working, after some time I figured out that the field names have to be appended to $fillable array.
Was working
public function getEnglishNameAttribute()
    {
        return ($this->getTranslation('name', 'en'));
    }

Wasn't working
public function setEnglishNameAttribute($value)
    {
        $this->setTranslation('name', 'en', $value);
    }

Both worked after added to fillable
public $fillable = ['name', 'english_name', ... ];