Compilation error when trying to use same type for number_integer_t and number_unsigned_t in basic_json template specification.

I'm trying to set the same storage type (std::int64_t) for both number_integer_t and number_unsigned_t for basic_json without success so far. It looks like they by design have to be different as setting same types lead to duplicated declatations in code.
What is the issue you have?
This line of code does not compile:
nlohmann::basic_json<std::map, std::vector, std::string, bool, std::int64_t, std::int64_t, double> j4; // Fail
Please describe the steps to reproduce the issue.
Here is the small piece of code which shows the issue:
`
#include "nlohmann/json.hpp"
int main(int argc, char **argv) {
nlohmann::basic_json<std::map, std::vector, std::string, bool, std::int64_t, std::uint64_t, double> j1; // Ok
nlohmann::basic_json<std::map, std::vector, std::string, bool, std::uint64_t, std::int64_t, double> j2; // Ok
nlohmann::basic_json<std::map, std::vector, std::string, bool, int, long int, double> j3; // Ok
nlohmann::basic_json<std::map, std::vector, std::string, bool, std::int64_t, std::int64_t, double> j4; // Fail
nlohmann::basic_json<std::map, std::vector, std::string, bool, float, float, float> j5; // Fail
return 0;
}
`
What is the expected behavior?
nlohmann::basic_json<std::map, std::vector, std::string, bool, std::int64_t, std::int64_t, double> should be compiled without errors and use same storage type for number_unsigned_t and number_integer_t
And what is the actual behavior instead?
Here is the output from compiler:
/usr/local/include/nlohmann/json.hpp: In instantiation of ‘class nlohmann::basic_json<std::map, std::vector, std::__cxx11::basic_string<char>, bool, long int, long int, double>’: /home/slovak/remote-config/test/test_types.cpp:11:102:   required from here /usr/local/include/nlohmann/json.hpp:19337:24: error: ‘nlohmann::basic_json<ObjectType, ArrayType, StringType, BooleanType, NumberIntegerType, NumberUnsignedType, NumberFloatType, AllocatorType, JSONSerializer, BinaryType>::number_unsigned_t* nlohmann::basic_json<ObjectType, ArrayType, StringType, BooleanType, NumberIntegerType, NumberUnsignedType, NumberFloatType, AllocatorType, JSONSerializer, BinaryType>::get_impl_ptr(nlohmann::basic_json<ObjectType, ArrayType, StringType, BooleanType, NumberIntegerType, NumberUnsignedType, NumberFloatType, AllocatorType, JSONSerializer, BinaryType>::number_unsigned_t*) [with ObjectType = std::map; ArrayType = std::vector; StringType = std::__cxx11::basic_string<char>; BooleanType = bool; NumberIntegerType = long int; NumberUnsignedType = long int; NumberFloatType = double; AllocatorType = std::allocator; JSONSerializer = nlohmann::adl_serializer; BinaryType = std::vector<unsigned char>; nlohmann::basic_json<ObjectType, ArrayType, StringType, BooleanType, NumberIntegerType, NumberUnsignedType, NumberFloatType, AllocatorType, JSONSerializer, BinaryType>::number_unsigned_t = long int]’ cannot be overloaded with ‘nlohmann::basic_json<ObjectType, ArrayType, StringType, BooleanType, NumberIntegerType, NumberUnsignedType, NumberFloatType, AllocatorType, JSONSerializer, BinaryType>::number_integer_t* nlohmann::basic_json<ObjectType, ArrayType, StringType, BooleanType, NumberIntegerType, NumberUnsignedType, NumberFloatType, AllocatorType, JSONSerializer, BinaryType>::get_impl_ptr(nlohmann::basic_json<ObjectType, ArrayType, StringType, BooleanType, NumberIntegerType, NumberUnsignedType, NumberFloatType, AllocatorType, JSONSerializer, BinaryType>::number_integer_t*) [with ObjectType = std::map; ArrayType = std::vector; StringType = std::__cxx11::basic_string<char>; BooleanType = bool; NumberIntegerType = long int; NumberUnsignedType = long int; NumberFloatType = double; AllocatorType = std::allocator; JSONSerializer = nlohmann::adl_serializer; BinaryType = std::vector<unsigned char>; nlohmann::basic_json<ObjectType, ArrayType, StringType, BooleanType, NumberIntegerType, NumberUnsignedType, NumberFloatType, AllocatorType, JSONSerializer, BinaryType>::number_integer_t = long int]’ 19337 |     number_unsigned_t* get_impl_ptr(number_unsigned_t* /*unused*/) noexcept       |                        ^~~~~~~~~~~~ /usr/local/include/nlohmann/json.hpp:19325:23: note: previous declaration ‘nlohmann::basic_json<ObjectType, ArrayType, StringType, BooleanType, NumberIntegerType, NumberUnsignedType, NumberFloatType, AllocatorType, JSONSerializer, BinaryType>::number_integer_t* nlohmann::basic_json<ObjectType, ArrayType, StringType, BooleanType, NumberIntegerType, NumberUnsignedType, NumberFloatType, AllocatorType, JSONSerializer, BinaryType>::get_impl_ptr(nlohmann::basic_json<ObjectType, ArrayType, StringType, BooleanType, NumberIntegerType, NumberUnsignedType, NumberFloatType, AllocatorType, JSONSerializer, BinaryType>::number_integer_t*) [with ObjectType = std::map; ArrayType = std::vector; StringType = std::__cxx11::basic_string<char>; BooleanType = bool; NumberIntegerType = long int; NumberUnsignedType = long int; NumberFloatType = double; AllocatorType = std::allocator; JSONSerializer = nlohmann::adl_serializer; BinaryType = std::vector<unsigned char>; nlohmann::basic_json<ObjectType, ArrayType, StringType, BooleanType, NumberIntegerType, NumberUnsignedType, NumberFloatType, AllocatorType, JSONSerializer, BinaryType>::number_integer_t = long int]’ 19325 |     number_integer_t* get_impl_ptr(number_integer_t* /*unused*/) noexcept       |                       ^~~~~~~~~~~~ /usr/local/include/nlohmann/json.hpp:19343:40: error: ‘constexpr const number_unsigned_t* nlohmann::basic_json<ObjectType, ArrayType, StringType, BooleanType, NumberIntegerType, NumberUnsignedType, NumberFloatType, AllocatorType, JSONSerializer, BinaryType>::get_impl_ptr(const number_unsigned_t*) const [with ObjectType = std::map; ArrayType = std::vector; StringType = std::__cxx11::basic_string<char>; BooleanType = bool; NumberIntegerType = long int; NumberUnsignedType = long int; NumberFloatType = double; AllocatorType = std::allocator; JSONSerializer = nlohmann::adl_serializer; BinaryType = std::vector<unsigned char>; nlohmann::basic_json<ObjectType, ArrayType, StringType, BooleanType, NumberIntegerType, NumberUnsignedType, NumberFloatType, AllocatorType, JSONSerializer, BinaryType>::number_unsigned_t = long int]’ cannot be overloaded with ‘constexpr const number_integer_t* nlohmann::basic_json<ObjectType, ArrayType, StringType, BooleanType, NumberIntegerType, NumberUnsignedType, NumberFloatType, AllocatorType, JSONSerializer, BinaryType>::get_impl_ptr(const number_integer_t*) const [with ObjectType = std::map; ArrayType = std::vector; StringType = std::__cxx11::basic_string<char>; BooleanType = bool; NumberIntegerType = long int; NumberUnsignedType = long int; NumberFloatType = double; AllocatorType = std::allocator; JSONSerializer = nlohmann::adl_serializer; BinaryType = std::vector<unsigned char>; nlohmann::basic_json<ObjectType, ArrayType, StringType, BooleanType, NumberIntegerType, NumberUnsignedType, NumberFloatType, AllocatorType, JSONSerializer, BinaryType>::number_integer_t = long int]’ 19343 |     constexpr const number_unsigned_t* get_impl_ptr(const number_unsigned_t* /*unused*/) const noexcept       |                                        ^~~~~~~~~~~~ /usr/local/include/nlohmann/json.hpp:19331:39: note: previous declaration ‘constexpr const number_integer_t* nlohmann::basic_json<ObjectType, ArrayType, StringType, BooleanType, NumberIntegerType, NumberUnsignedType, NumberFloatType, AllocatorType, JSONSerializer, BinaryType>::get_impl_ptr(const number_integer_t*) const [with ObjectType = std::map; ArrayType = std::vector; StringType = std::__cxx11::basic_string<char>; BooleanType = bool; NumberIntegerType = long int; NumberUnsignedType = long int; NumberFloatType = double; AllocatorType = std::allocator; JSONSerializer = nlohmann::adl_serializer; BinaryType = std::vector<unsigned char>; nlohmann::basic_json<ObjectType, ArrayType, StringType, BooleanType, NumberIntegerType, NumberUnsignedType, NumberFloatType, AllocatorType, JSONSerializer, BinaryType>::number_integer_t = long int]’ 19331 |     constexpr const number_integer_t* get_impl_ptr(const number_integer_t* /*unused*/) const noexcept       |                                       ^~~~~~~~~~~~ /usr/local/include/nlohmann/json.hpp: In instantiation of ‘union nlohmann::basic_json<std::map, std::vector, std::__cxx11::basic_string<char>, bool, long int, long int, double>::json_value’: /usr/local/include/nlohmann/json.hpp:23530:16:   required from ‘class nlohmann::basic_json<std::map, std::vector, std::__cxx11::basic_string<char>, bool, long int, long int, double>’ /home/slovak/remote-config/test/test_types.cpp:11:102:   required from here /usr/local/include/nlohmann/json.hpp:17558:9: error: ‘nlohmann::basic_json<ObjectType, ArrayType, StringType, BooleanType, NumberIntegerType, NumberUnsignedType, NumberFloatType, AllocatorType, JSONSerializer, BinaryType>::json_value::json_value(nlohmann::basic_json<ObjectType, ArrayType, StringType, BooleanType, NumberIntegerType, NumberUnsignedType, NumberFloatType, AllocatorType, JSONSerializer, BinaryType>::number_unsigned_t) [with ObjectType = std::map; ArrayType = std::vector; StringType = std::__cxx11::basic_string<char>; BooleanType = bool; NumberIntegerType = long int; NumberUnsignedType = long int; NumberFloatType = double; AllocatorType = std::allocator; JSONSerializer = nlohmann::adl_serializer; BinaryType = std::vector<unsigned char>; nlohmann::basic_json<ObjectType, ArrayType, StringType, BooleanType, NumberIntegerType, NumberUnsignedType, NumberFloatType, AllocatorType, JSONSerializer, BinaryType>::number_unsigned_t = long int]’ cannot be overloaded with ‘nlohmann::basic_json<ObjectType, ArrayType, StringType, BooleanType, NumberIntegerType, NumberUnsignedType, NumberFloatType, AllocatorType, JSONSerializer, BinaryType>::json_value::json_value(nlohmann::basic_json<ObjectType, ArrayType, StringType, BooleanType, NumberIntegerType, NumberUnsignedType, NumberFloatType, AllocatorType, JSONSerializer, BinaryType>::number_integer_t) [with ObjectType = std::map; ArrayType = std::vector; StringType = std::__cxx11::basic_string<char>; BooleanType = bool; NumberIntegerType = long int; NumberUnsignedType = long int; NumberFloatType = double; AllocatorType = std::allocator; JSONSerializer = nlohmann::adl_serializer; BinaryType = std::vector<unsigned char>; nlohmann::basic_json<ObjectType, ArrayType, StringType, BooleanType, NumberIntegerType, NumberUnsignedType, NumberFloatType, AllocatorType, JSONSerializer, BinaryType>::number_integer_t = long int]’ 17558 |         json_value(number_unsigned_t v) noexcept : number_unsigned(v) {}       |         ^~~~~~~~~~ /usr/local/include/nlohmann/json.hpp:17556:9: note: previous declaration ‘nlohmann::basic_json<ObjectType, ArrayType, StringType, BooleanType, NumberIntegerType, NumberUnsignedType, NumberFloatType, AllocatorType, JSONSerializer, BinaryType>::json_value::json_value(nlohmann::basic_json<ObjectType, ArrayType, StringType, BooleanType, NumberIntegerType, NumberUnsignedType, NumberFloatType, AllocatorType, JSONSerializer, BinaryType>::number_integer_t) [with ObjectType = std::map; ArrayType = std::vector; StringType = std::__cxx11::basic_string<char>; BooleanType = bool; NumberIntegerType = long int; NumberUnsignedType = long int; NumberFloatType = double; AllocatorType = std::allocator; JSONSerializer = nlohmann::adl_serializer; BinaryType = std::vector<unsigned char>; nlohmann::basic_json<ObjectType, ArrayType, StringType, BooleanType, NumberIntegerType, NumberUnsignedType, NumberFloatType, AllocatorType, JSONSerializer, BinaryType>::number_integer_t = long int]’ 17556 |         json_value(number_integer_t v) noexcept : number_integer(v) {}       |         ^~~~~~~~~~
Which compiler and operating system are you using?

Compiler: gcc version 9.3.0
Operating system: Ubuntu 9.3.0-17ubuntu1~20.04

Which version of the library did you use?

[ ] latest release version 3.9.1
[ ] other release - please state the version: ___
[x] the develop branch

If you experience a compilation error: can you compile and run the unit tests?

[x] yes
[ ] no - please copy/paste the error message below

What are you trying to achieve by doing this?  It is not possible to do this because that makes these two functions (and probably other pairs) identical:
template<typename BasicJsonType>
void from_json(const BasicJsonType& j, typename BasicJsonType::number_unsigned_t& val)
{
    get_arithmetic_value(j, val);
}

template<typename BasicJsonType>
void from_json(const BasicJsonType& j, typename BasicJsonType::number_integer_t& val)
{
    get_arithmetic_value(j, val);
}

What are you trying to achieve by doing this?  It is not possible to do this because that makes these two functions (and probably other pairs) identical:
template<typename BasicJsonType>
void from_json(const BasicJsonType& j, typename BasicJsonType::number_unsigned_t& val)
{
    get_arithmetic_value(j, val);
}

template<typename BasicJsonType>
void from_json(const BasicJsonType& j, typename BasicJsonType::number_integer_t& val)
{
    get_arithmetic_value(j, val);
}

What are you trying to achieve by doing this? It is not possible to do this because that makes these two functions (and probably other pairs) identical:

I'm trying to add some kind of type safety and numerical array homogeneity guaranty on top of this library. I plan to extensively use direct access to the underlying memory (json.get_ptr()) to avoid copies and I'd like to have some guarantee that the underlying type will not change accidentally.
For example, if I have big with the vector of floating-point numbers - I'd like to have the possibility to keep this vector homogenous - all members float. Further, I can use EigenMap<> for fast direct access to the data. Same for integer types.

RFC 7159 describes numbers as follows:
The representation of numbers is similar to that used in most programming languages. A number is represented in base 10 using decimal digits. It contains an integer component that may be prefixed with an optional minus sign, which may be followed by a fraction part and/or an exponent part. Leading zeros are not allowed. (...) Numeric values that cannot be represented in the grammar below (such as Infinity and NaN) are not permitted.
This description includes both integer and floating-point numbers. However, C++ allows more precise storage if it is known whether the number is a signed integer, an unsigned integer or a floating-point number. Therefore, three different types, number_integer_t, number_unsigned_t and number_float_t are used.

As JSON standard does not differentiate between float, signed, and unsigned - this is quite natural to have the possibility to use float or double storage for any incoming number. Or, some other better control over how types are deducted from values.

What are you trying to achieve by doing this? It is not possible to do this because that makes these two functions (and probably other pairs) identical:

I'm trying to add some kind of type safety and numerical array homogeneity guaranty on top of this library. I plan to extensively use direct access to the underlying memory (json.get_ptr()) to avoid copies and I'd like to have some guarantee that the underlying type will not change accidentally.
For example, if I have big with the vector of floating-point numbers - I'd like to have the possibility to keep this vector homogenous - all members float. Further, I can use EigenMap<> for fast direct access to the data. Same for integer types.

RFC 7159 describes numbers as follows:
The representation of numbers is similar to that used in most programming languages. A number is represented in base 10 using decimal digits. It contains an integer component that may be prefixed with an optional minus sign, which may be followed by a fraction part and/or an exponent part. Leading zeros are not allowed. (...) Numeric values that cannot be represented in the grammar below (such as Infinity and NaN) are not permitted.
This description includes both integer and floating-point numbers. However, C++ allows more precise storage if it is known whether the number is a signed integer, an unsigned integer or a floating-point number. Therefore, three different types, number_integer_t, number_unsigned_t and number_float_t are used.

As JSON standard does not differentiate between float, signed, and unsigned - this is quite natural to have the possibility to use float or double storage for any incoming number. Or, some other better control over how types are deducted from values.

It is currently neither possible nor planned to use the same type for signed and unsigned integers used by the library. @gregmarr is right we should add static assertions for this. Sorry for the inconvenience.

It is currently neither possible nor planned to use the same type for signed and unsigned integers used by the library. @gregmarr is right we should add static assertions for this. Sorry for the inconvenience.

Hello World

Hello World

Presumably it would be possible to just eliminate these duplicate functions with std::enable_if for the case when the two types are equal?


PHP - Bump minimum supported version to PHP 8

Our Kiota lib currently supports a minimum of PHP 7.4 which is no longer in active support but will security updates until Nov '22
https://www.php.net/supported-versions.php
We should consider bumping our min. version to PHP 8 with the additional benefits of new features like built-in enums, named arguments, union types etc before GA.

I'm looking into this now.

@isvargasmsft Just a gentle reminder on this one. Since this last discussion 8 is out of active support (only security fixes) and 8.1 is active. It's going to be really hard for us to properly support customers if they are running on unsupported php engines. The new version would allow for a size reduction of the SDK. I believe this is something we should settle on quickly before we reach GA.

Hi @baywet, thank you for the reminder.
My position is to upgrade to 8.1 and keep responding to the language.
Let's sync on the next stand up.

Adding to this...
Latest stats on PHP versions from Packagist show that over 50% of apps have now upgraded to 8.x both from our package stats and the wider PHP ecosystem stats

@MIchaelMainer guessing there might be compliance implications of building for an unsupported PHP version?

I don't see a compliance issue with building for an unsupported version. With that said, we should start building for the latest supported version of PHP.

Took a look at the new features PHP 8.0 provides that could improve our SDK experience but found that the value provided would be limited to warrant forcing developers to upgrade to PHP 8.
Some of the new features evaluated:

Constructor property promotion could reduce our SDK size by reducing the size of our models however with the use of the backing store, we have to set/get property values via setter/getter methods.
Named arguments would prove useful to improve discoverability of supported query parameters per request. This will be solved by adding constructors to the request config and query parameter classes and would work for both PHP 7 and PHP 8.
Built in Enum support would change our function declarations where union types are supported and validate the types at runtime, however we currently leverage PHP's loose typing and PHPDoc comments for methods that accept union types for arguments. With a PHPDoc comment like * @param $item string|int most IDEs make developers aware of the union type during autocompletion, while highlighting when wrong types are passed as arguments

With this, we have a better chance of covering a wider set of customers by shipping an SDK that works with both PHP 7 and PHP 8, leaving the choice to upgrade to developers.


Downgrade Editor to 2024-06-11

This reverts commit 2dac52c9f7838ae404f1616740fdc55841518b98 to prevent the regression bug contained in the newest release from being included in more releases.
Your pull request should…

[x] have a concise title
[x] close an accompanying issue if one exists
[x] be against the correct branch
[x] include migration scripts and documentation, if appropriate
[x] pass automated tests
[x] have a clean commit history
[x] have proper commit messages (title and body) for all commits

Since I see no recent issues in the editor repository, I'm assuming that bug has not been documented yet. Could you document it so we can fix it?

It's documented and will hopefully be fixed by https://github.com/opencast/opencast-editor/pull/1424


Implement add contact command for ContactList

Fixes #236
This PR relates to the implementation of a command to add a contact into the ContactList following the earlier PR for Contact and ContactList refactoring.
The following classes were added:

AddContactCommand: to handle the addition of a Contact into the ContactList
AddContactParser: to handle parsing of user input for a command to add a contact. This class is responsible for error handling when the user provides invalid or incorrect arguments.

The following classes were modified:

ParserUtil: A parseTelegram() method was added to handle parsing of user argument relating to a contact's Telegram
CliSyntax: A new prefix "te/" was added to handle user arguments relating to a contact's Telegram.
AddressBookParser: Add a case to handle adding of a contact .

Codecov Report

Merging #249 into master will decrease coverage by 0.31%.
The diff coverage is 30.10%.

@@             Coverage Diff              @@
##             master     #249      +/-   ##
============================================
- Coverage     20.46%   20.14%   -0.32%
+ Complexity      300      299       -1
============================================
  Files           190      193       +3
  Lines          2873     2943      +70
  Branches        242      248       +6
============================================
+ Hits            588      593       +5
- Misses         2244     2303      +59
- Partials         41       47       +6

Impacted Files
Coverage Δ
Complexity Δ

src/main/java/seedu/address/MainApp.java
0.00% <0.00%> (ø)
0.00 <0.00> (ø)

...eedu/address/logic/commands/AddContactCommand.java
0.00% <0.00%> (ø)
0.00 <0.00> (?)

...a/seedu/address/logic/parser/AddContactParser.java
0.00% <0.00%> (ø)
0.00 <0.00> (?)

.../seedu/address/logic/parser/AddressBookParser.java
66.66% <0.00%> (-3.34%)
10.00 <0.00> (ø)

...in/java/seedu/address/logic/parser/ParserUtil.java
47.16% <0.00%> (-4.92%)
10.00 <0.00> (ø)

.../java/seedu/address/model/util/SampleDataUtil.java
37.50% <ø> (+16.07%)
1.00 <0.00> (ø)

...rc/main/java/seedu/address/model/ModelManager.java
62.12% <22.72%> (-25.12%)
18.00 <1.00> (-2.00)

src/main/java/seedu/address/model/ContactList.java
50.00% <50.00%> (ø)
6.00 <6.00> (?)

...seedu/address/model/contact/UniqueContactList.java
85.36% <77.77%> (ø)
17.00 <8.00> (ø)

...ain/java/seedu/address/logic/parser/CliSyntax.java
90.00% <100.00%> (+1.11%)
1.00 <0.00> (ø)

... and 11 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6498f91...0105b2d. Read the comment docs.


Improve performance when using include lists

I want @ravyolii to take a look as well 🙏🏽

Code looks good.

Note comment about double-check, might improve perf a bit
Did you run the tests?
Need to bump version in main.go and prepare release, its a manual step unfortunately.

LGTM 👍


Revert "Fix(resourcebar): getter and setter accept string"

Reverts quisquous/cactbot#2623
Sorry, this causes the mp bar to say NaN in the jobs overlay.  I haven't looked into why this is happening, but just wanted to roll back to a working version.

What Job were you using when this bug appeared?
I think NaN is usually due to the divisor being 0. I looked at the resourcebar code and there are only two lines dividing by this._maxValue, I think it might have been assigned to 0 in some places.
I'll try to look for it ehen I have more time.

I think the issue was that the null check / empty string that Panic put up a PR for in #2633.  However, after some discussion (see https://github.com/quisquous/cactbot/pull/2532#discussion_r602517869), I think Trim21's original idea is the better one here.  I didn't realize the getters were actually being used, and if they are, then it's better to treat null as "unset" rather than use empty strings.
So, I think that issue is fixed, but now the other typescript patches should match what that one does, to support null and removeAttribute.  Sorry for all the change back and forth here.  This is just due to my own confusion and lack of understanding.


Default timezone

A nice and hopefully simple option for you to make is to provide a default timezone to the date objects. Forcing them to e.g. midnight in Europe/Paris, to ensure a consistent way of sending dates.
I'm not sure what time zone it's using now, but if just doing the default I recall that moment defaults to the browsers zone. This can cause issues when e.g. creating a booking system, for someone in say Bordeaux, France, is doing bookings for something home in France, while being in Romania. The errors arise because if the computer can be set the timezone to Romanian time all dates would end up the day before when viewed home in France, causing all bookings to be off. Ofc. in some use cases this might be desired, but in a lot of cases, such as booking the desired option is to lock the time to some desired default.

Shouldn't users use moment.tz.setDefault(TIMEZONE); ? (with moment-timezone)
So all their moment dates will be good ?

Hmm might actually be appropriate indeed. Hadn't spotted that one. Currently I can't think of a use case where a deviating timezone is desired for the calendar. I guess that's a better solution then.


not need to check Specinfra.configuration.env via any? in  backend/docker.rb

Default value of Specinfra.configuration.env is nil. So if env is nil, Specinfra.configuration.env.any? got NoMethodError.
And NilClass has to_a method. so not need to check it via any? method.

Thanks!

Released as v2.20.1.


fix(helm): downgrade helm api version for compatibility

No specific feature that comes from V2 is used so there is no reason to require it. This will allow users who for some reason can not upgrade their helm.

Codecov Report

Merging #7 (4f028bd) into master (97ed280) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master       #7   +/-   ##
=======================================
  Coverage   75.95%   75.95%
=======================================
  Files           5        5
  Lines         499      499
=======================================
  Hits          379      379
  Misses         96       96
  Partials       24       24

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 97ed280...4f028bd. Read the comment docs.


pin hidapi dependency to version 1.2.3

unsure if this actually helps or not
fixes #113 (work around)

cargo install probe-run (or --git) ignores the Cargo.lock stored in this repo so people will always use the latest patch version of everything. except for hidapi which is now pinned in the Cargo.toml


compute time

in the last paragraph before B.II, you talk about compute time.
but you seem to drop the log n?
shouldn't we keep it, or at least be explicit about dropping it?

yes it is a bit confusing, as the log n only comes from the ranking. This part is clarified now.


ModuleNotFoundError: No module named 'odxtools.compumethods' with v5.0.0

Installation using pip succeeds, but there's an error on import. Looking at the files and on https://pypi-browser.org/package/odxtools/odxtools-5.0.0.tar.gz, it appears the compumethods folder is not included in the package.

okay, I hope to have fixed this with version 5.0.4. If the issue persists, feel free to reopen it...


fix misspell in page title

@E-G-C : Thanks for your contribution! The author(s) have been notified to review your proposed change.

Looks good. Thanks for the fix, @E-G-C.


[BUG] Not specifying the correct value for obj.name results in a degraded user experience for screen readers

Office Tool Plus Version, e.g. <IP_ADDRESS>:
<IP_ADDRESS>
Operating System, e.g. Windows 10 20H2 or Windows 7 SP1:
Windows 10 21H2 (x64) build 19044.1645
Error description (required):
Not specifying the correct value for obj.name
Reproduction steps (suggested):

Install and launch the NVDA screen reader
Start Office Tool Plus;
Press Tab to move focus between controls(obj);
You may hear tts report the following: “安装 Office按钮”、“部署按钮”、“激活按钮”、“工具箱按钮”
You may also hear the following: "按钮 创建调查、测验和投票并实时轻松地查看结果"

Pay attention to step (4) and step (5):
Because the reporting order for screen readers is obj.name > obj.role > obj.description.
The way step (4) is reported is expected, obj.role should be reported after obj.name.
But step (5) reports obj.role first, This is due to incorrect behavior caused by missing obj.name.
You need to specify the correct string for obj.name .
Screenshot (suggested):
n/a
Additional information (optional):
n/a

Similar problems exist in the controls and drop-down menu items of the main interface, and we hope to optimize them uniformly.

Hi
It should be noted that obj.name often needs to be shortened and clear, such as "install", "cancel" For more detailed information, you need to use obj.description.
Thanks

The problem of launcher items was fixed, now it will be reported like "Form 按钮 创建调查、测验和投票并实时轻松地查看结果".
If you have any questions or ideas, please let us know.

All the behavior of buttons and textbox was fixed. Also menus and combo box.

Hi @YerongAI
Thanks for your efforts.
could you provide a build version for me to test?
Thanks again

Hi @YerongAI
Thanks for your efforts. could you provide a build version for me to test?
Thanks again

Please wait three days. We will release a production version for use.

Thanks @YerongAI

Thanks @YerongAI

Hi, updates is ready, please click version number on About panel to get the updates.

Hi @YerongAI
Thanks, I got the update and it looks good.
But this following buttons still has the problem:
Command、Contact us、Help、About、Settings、minimize, close,
You might be able to fix it in a future version, btw, minimize, close etc buttons are also missing obj.name.


How to time the algorithms?

How do you time the training time of the different algorithms? Are there tools available that can be used for all ML software?

Just measure wall time for training only, system.time in R or %time in ipython, see code examples in the repo.


Backend: Add endpoint for exporting account statement as CSV file

Purpose
Provide a solution for users wanting to export a full account statement. No support for filtering is implemented. It could make sense to add optional time bounds.
Part of epic "Export transactions from CCDScan".
Most accounts will process in less than 1s. Account 35CJPZohio6Ztii2zy1AYzJKvuxbGG44wrBn7hLHiYLoF2nxnh which as of this writing has 4339327 statement entries takes 5-6 secs locally and results in a 200MB download (and has too many entries for spreadsheets to open it). This could be used maliciously, so adding some form of rate limiting may be desirable.
Changes
Add endpoint /rest/export/statement?accountAddress=<account-address> to the backend that responds with a CSV file statement-<account-address>.csv containing all records formatted like:
Time,Amount (CCD),Label
2022-10-07 08:00:19Z,15526.040342,FinalizationReward
2022-10-08 08:00:01Z,38.824926,TransactionFeeReward
2022-10-08 08:00:01Z,256225.95173,BakerReward
2022-10-08 08:00:01Z,15523.962755,FinalizationReward
...

Checklist

[x] My code follows the style of this project.
[x] The code compiles without warnings.
[x] I have performed a self-review of the changes.
[x] I have documented my code, in particular the intent of the
hard-to-understand areas.

It looks okay to me. I haven't tested it though, I assume that is very cumbersome to do?

It's quite cumbersome, yes. I can help you set it up but it would be easier if we just deploy it to stagenet and test it from there.


Incorrect drawing on Android API 24 with using Scale.

If you are creating an issue for a BUG please fill out this information. If you are asking a question or requesting a feature you can delete the sections below.
Failure to fill out this information will result in this issue being closed. If you post a full stack trace in a bug it will be closed, please post it to http://gist.github.com and then post the link here.
Bug Information
Version Number of Plugin: 1.8.1
Device Tested On: SDK 24
Simulator Tested On:
Version of VS: mac 7.1.3
Version of Xamarin: XF <IP_ADDRESS>0 latest stable
Versions of other things you are using: Xamarin.Android <IP_ADDRESS>
Steps to reproduce the Behavior
On the android SDK 24 or above.
If I set scale as 0.5, Circular masking is broken.
Expected Behavior
Actual Behavior
Code snippet
Screenshotst

I will upload a screenshot too later.

What if you use a normal Image and not a CircleImage?

Hi, James.
It is a normal Image, not circle image.
Oh, you meant regular Image class?
Of course, it acts as I expected.
You can see the screenshot above, photo scale downed to 0.5 correctly but masking didn't.

Any Update or workaround for this issue? I am getting this behavior in Android 7 and it is working fine in Android 10 Beta.


DEVSOL 1313: Support JSON/YAML File or URL import for both Swagger and WADL

It may be beneficial for us to go over the changes I made.

Closing, starting over.


File size upload limit.

Is your feature request related to a problem? Please describe
Is there a way to limit the max mb and image can be?
Describe the solution you'd like
A way to limit the max amount of mb.
Describe alternatives you've considered
N/a
Additional context
Add any other context or screenshots about the feature request here.

@antoine92190

Would be useful for us too. One usecase for us is MMS which has restriction on files sizes.


Asurascans down

Extension information
AsuraScans
Steps to reproduce
When trying to open any manga from asura scans or trying to search the asura scans repo the results simply don't load.
Reinstalling the extension does not help

Miru version
1.8.1
Other details
No response
Acknowledgements

[X] I have searched the existing issues and this is a new ticket, NOT a duplicate or related to another open issue.

#2b0532e fixed


Label & RichTextLabel.visible_ratio does not work in Godot 4.0 alpha 15

Godot version
v4.0.alpha15.official [432b25d36]
System information
Window11 64bits
Issue description
The Label & RichTextLabel property, "visible_ratio", does not work in both editor and GDScript. I cannot change the value in editor. If I change it in GDScript, nothing happens.
This property was called "percent_visible" before alpha 15.
Steps to reproduce

Create a new project.
Create a 2D scene
Add Label under Node2d
Type some text in Label and try to change the "Visible Ratio" property. The value 1.0 is non-changeable.

Minimal reproduction project
LabelVisible.zip
The exact same project works fine in alpha 14, which the property name was "percent_visible" ("Percent Visible" in editor).

The property was renamed by https://github.com/godotengine/godot/pull/64665. cc @Mickeon

May have been caused by https://github.com/godotengine/godot/pull/64670 and the aforementioned PR after a "bad" merge, I'm going to check.


Separated python hint prints for addresses and non-addresses types.

Stack:

#3543
#3542
#3500
#3499
#3498
#3490
#3489
#3486
#3475
#3474
#3473
#3462
#3487 ⬅

⚠ Part of a stack created by spr. Do not merge manually using the UI - doing so may have unexpected results.


Refactor build checks

Related: PR #1069
Refactor checkTubeConnection and checkStructurePlacement. I'm sure it's possible to simplify further, though I didn't want to put too much effort into figuring out how to minimize those checks. I suspect there may be another simpler way of doing them.

Hmm, I suspect commit 36f2070 has a bit. Which means commit ab950f0 is probably suspect too.

@DanRStevens,
What does 'has a bit' mean I'm this context?
Brett

Oops, typo. Should have been "has a bug".

Ahh, I see now. It's an associativity problem. The bool expression moved to the left is now associating with the bool expression used for the ternary. Effectively the ternary is being applied to the new full expression, rather than just the part on the right, as intended. Extra parenthesis will fix this.


Fix a token incompatibility for Prism::Translation::Parser

Fixes #2512.
This PR fixes a token incompatibility between Parser gem and Prism::Translation::Parser for HEREDOC_END with a newline.

Do we need to handle \r\n as well?

Sure! I've updated this PR.


why do you give us picture can produce?but my picture can'nt produce.

if you can give me help i would appreciate it

Hi @wjj2301717059
This is a same issue as 99


Close the property windows cause the program closed

Describe the bug
Close the property windows cause the program closed.
To Reproduce
right click on one file and chose the property.  then close the property windows. and the program close.
Desktop (please complete the following information):

OS Version: Windows 10 2004 19041.265 Chinese version

The app doesn't really close however the app gets minimized. You can restore the app by using Alt+Tab.

thx, there isn't such issue now. maybe beacuse of a reboot.

Great.


react-query imports a custom fetcher as a type with useTypeImports enabled

Which packages are impacted by your issue?
@graphql-codegen/typescript-react-query
Describe the bug
When I specify fetcher option with a custom path to my function and useTypeImports with a value of true in the generation settings, the generated files import my function with the type import modifier, which causes TypeScript to fail and the application to build.
Your Example Website or App
https://stackblitz.com/edit/github-djwd6w?file=codegen.ts
Steps to Reproduce the Bug or Issue

Go to reproduce
Run npm run generate
Go to types.ts file
See on import of import type { fetcher } from './custom-fetcher'

Expected behavior
As a user I am expected that import path will be import { fetcher } from './custom-fetcher' with option useTypeImports: true, because fetcher is a function, but not type or interface.
Screenshots or Videos
No response
Platform

OS: macOS
NodeJS: 18.19.0
graphql version: 16.9.0
@graphql-codegen/typescript-react-query version: 6.1.0

Codegen Config File
import { CodegenConfig } from '@graphql-codegen/cli';

const config: CodegenConfig = {
  schema: 'schema.graphql',
  documents: 'document.graphql',
  generates: {
    'types.ts': {
      plugins: [
        'typescript',
        'typescript-operations',
        '@graphql-codegen/typescript-react-query',
      ],
      config: {
        reactQueryVersion: 5,
        fetcher: './custom-fetcher#fetcher',
        useTypeImports: true,
      },
    },
  },
};

export default config;

Additional context
No response

I experienced the same issue. The option useTypeImports is buggy


OSSM: Consolidate Service Mesh related notebook patches

These seem all very related, we may want to look at cleaning that up in the future to make it one "set of patches" rather than 3 separate ones. Just for code cleanness.
Originally posted by @andrewballantyne in https://github.com/opendatahub-io/odh-dashboard/pull/1088#discussion_r1346172057
Currently, we have 3 separate functions that return patches for the 2 annotations and 1 label that need to be patched in the notebook object to enable/disable service mesh. For code cleanness, these three patches should be returned in one function call.

Associated PR was merged - moving to closed (please add a comment if this was incorrect).


docs(cdn-icon): default baseUrl warning

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 81.78%

Totals

Change from base Build<PHONE_NUMBER>:
0.0%

Covered Lines:
5801

Relevant Lines:
6525

💛  - Coveralls


Defined styles are not output by outerHTML

Node version: 6.2.0.
Hyperscript version: 1.4.7.

Steps to reproduce: Evaluate h('div', 'Test', { style: { display: 'none' } }).outerHTML
Expected:
Test
 (or something like that).
Got:
Test

Am I missing something?

This is running in node, right?
so I think this bug is in https://github.com/1N50MN14/html-element
can you post an issue there?

Sure, thanks, but it looks like I'll have to try to make a PR for him, see https://github.com/1N50MN14/html-element/issues/31#issuecomment-237308344 :)


Check for external storage permission before downloading

Cause otherwise we would get massive painful conflicts, this incudes #391 - check and merge that one first!
Fixes #393

Thanks for the fix, @domdomegg ! And good call removing the legacy Honeycomb/ICS checks, since we have a min SDK of 15 now. :)


list_objects expects GetObjectAcl permission

Unless s3:GetObjectAcl action is allowed, the Content entries of the response xml will not contain this part, which seems to be expected by the parsing code:
<Owner><ID>...</ID><DisplayName>...</DisplayName></Owner>

leads to this crash:
** (Protocol.UndefinedError) protocol Enumerable not implemented for nil
    (elixir) lib/enum.ex:1: Enumerable.impl_for!/1
    (elixir) lib/enum.ex:112: Enumerable.reduce/3
    (elixir) lib/stream.ex:695: Stream.do_enum_transform/8
    (elixir) lib/stream.ex:647: Stream.do_transform/7
             lib/sweet_xml.ex:484: anonymous fn/4 in SweetXml.continuation_opts/2
             xmerl_scan.erl:565: :xmerl_scan.scan_document/2
             xmerl_scan.erl:288: :xmerl_scan.string/2
             lib/sweet_xml.ex:180: SweetXml.parse/2

Good catch, should have a fix up soon.

I have a PR up on SweetXml here: https://github.com/awetzel/sweet_xml/pull/10 that should fix this issue.

The PR has been merged. Has the issue been solved?

It should bed yup.


Add option to force color variations

Although granular control over which icons get color variations generated via the filename config is great, sometimes you just want to create color variations on everything and it can be laborious naming all the files. Instead, it would be useful to just do the configuration in the gruntfile.

Moving this talk over here - https://github.com/filamentgroup/directory-colorfy/issues/13


Feature Request: Drawer should be able to confine itself within the immediate parent html element

The drawer works great. It would be nice if the drawer could contain itself within a container. For example in a react component such as the following:
export default function Dashboard({}: DashboardProps) {
  const parentRef = useRef<HTMLDivElement>(null);

  return (
    <SearchPanelContextProvider>
      <div className='flex-none w-96 h-full pt-3'>
        <SearchPanel />
      </div>
      <div
        id='main-panel'
        ref={parentRef}
        className='flex flex-col flex-grow w-full h-full bg-slate-50 relative'>
        <FacilitiesMap />
        <BottomDrawer container={parentRef} />
      </div>
    </SearchPanelContextProvider>
  );
}

The drawer should attach itself to the parent div 'main-panel' and align its position and adjust its dimensions. It should pop up from the bottom left of the div and not the main html body. It's width should also be restricted to the width of the parent div. Basically, with respect to the above example, it should not cover 'SearchPanel'.

You can use the container prop for it! It's not well documented, but just passing a ref into Drawer.Root should be enough! :)
Documentation will come soon.

Thanks for responding!!
I tried the 'container' prop, I even traced that the container reference I'm passing is reaching DrawerPrimitive.Root, but for some reason the drawer attaches itself to main document body when it loads/mounts. At which point I thought, maybe, passing the container is not supposed to achieve what I want. I think appending to the root body html element is the default behavior of React Dialog and is inherited as it is. I may be entirely mistaken though.
If there's an example where the width of the drawer limits itself to the passed container's width, I would appreciate it if you please share. If not, I am happy to share a simple reproduction of the problem.
Thanks for creating this wonderful and clean widget though.

Can you provide a demo of what you tried?

I created a simple next js app with a single page here -> Vaul-Drawer-Demo.
Here is the codesandbox.
I don't know what I'm doing wrong but what I'm trying to achieve is make the drawer limit its width to the main panel and not cross over into the side panel. Below is a screenshot from the above sandbox.

Please let me know if you need anything else.

bumping the message above just in case.

This should do exactly what you want @ayadav42 : https://codesandbox.io/p/github/ayadav42/vaul-drawer-demo/csb-yqhq53/draft/elastic-agnesi?import=true

use relative positioning in the parent where you colocated the drawer, helpful so you can use absolute in the point below
don't use fixed positioning in the <Drawer.Content/>, fixed makes an element relative to the viewport (browser window). i replaced it with absolute, that combined with relative in the parent makes it a bottom drawer contained to the element you want
remove the <Drawer.Portal/> wrapper - the portal moves it to the root of your app and thus displays above the entire app. @emilkowalski idk if you considered allowing portals to be in a specific container, its less common but there's some benefits to containerized portals and React allows it.

Adding my findings about this feature (rendering the drawer into a different element)

Using a container with position:relative + the container prop on Vaul.Root works.

However, there's some confusion by the fact that the Vaul.Portal also has a (undocumented) container prop.
It's unclear when we should use one vs the other, or both, etc.
Would love some more info / examples on this


A doubt in the implement of BucketSampler.

I was learning your code and here is my question about the BucketSampler:
utils.py
mlen = max([0]+[lens[x] for x in batch])
maybe lens should be reinitialized by
lens = torch.Tensor([len(x) for x in self.data_source])
rather than
lens = lens[perm]
if there is anything wrong, please point out and thank you for your help.

You are right, it's a bug.

Fixed


release-0.1-bug-free

Signed-off-by: mingzhou.swx<EMAIL_ADDRESS>
Ⅰ. Describe what this PR does
Fix bugs about go routine race

Codecov Report

Merging #63 (6a69a7b) into release-0.1 (508f118) will decrease coverage by 0.62%.
The diff coverage is 31.81%.

@@               Coverage Diff               @@
##           release-0.1      #63      +/-   ##
===============================================
- Coverage        24.78%   24.15%   -0.63%
===============================================
  Files               19       19
  Lines             2102     2107       +5
===============================================
- Hits               521      509      -12
- Misses            1511     1530      +19
+ Partials            70       68       -2

Flag
Coverage Δ

unittests
24.15% <31.81%> (-0.63%)
:arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files
Coverage Δ

...er/batchrelease/workloads/cloneset_control_plan.go
0.00% <0.00%> (ø)

...elease/workloads/deployment_double_control_plan.go
0.00% <0.00%> (ø)

...ller/batchrelease/workloads/cloneset_controller.go
38.09% <18.75%> (+0.84%)
:arrow_up:

...controller/batchrelease/batchrelease_controller.go
43.02% <33.33%> (-1.69%)
:arrow_down:

...troller/batchrelease/batchrelease_plan_executor.go
46.15% <46.34%> (-3.52%)
:arrow_down:

...hrelease/workloads/deployment_double_controller.go
38.88% <47.05%> (+0.59%)
:arrow_up:

pkg/controller/batchrelease/batchrelease_util.go
38.88% <60.00%> (-14.96%)
:arrow_down:

...batchrelease/batchrelease_special_cases_handler.go
70.58% <81.57%> (+0.82%)
:arrow_up:

:mega: Codecov can now indicate which changes are the most critical in Pull Requests. Learn more

/approve

/labels

/lgtm

/lgtm


Start translating the new JS concepts to rust

Putting this in a PR so that hopefully I can get someone to review my translations eventually!

Looking good :smile_cat:

Very nice. Here are a few thing that I'd like to add:

"Conditionals": You mention === in JS. In Rust, there is the Eq trait (and PartialEq), but it is not idiomatic to do implicit conversions (like in 2 == "2").
"Output to the screen" says that console.log goes to the "JavaScript console" (which is stdout in node, by the way), but doesn't say that println! writes to stdout. (Feel free to add writeln!(stderr(), "Oh noes!") as equivalent to console.error.)
In "Lists of variable size", you might want to note that JS arrays can contain elements of various types but Vec<T> only has elements of type T (although that T can be something complex like serde_json::Value). In places where in JS you'd use small arrays, you can use tuples in Rust.

"Conditionals": You mention === in JS. In Rust, there is the Eq trait (and PartialEq), but it is not idiomatic to do implicit conversions (like in 2 == "2").

That's a good point. How does one cast or coerce?


[DDW-370] add antivirus restoration slowdown notification component t…

This PR adds a notification during wallet restoration that tells Windows users that their usage of anti-virus software might slow down the process.
Todo:

[x] Add notification component + render it in storybook
[ ] Add logic to display it during restoration & only on windows

Screenshots:

The component in storybook:

Review Checklist:
Basics

[ ] PR is updated to the most recent version of target branch (and there are no conflicts)
[ ] PR has good description that summarizes all changes and shows some screenshots or animated GIFs of important UI changes
[ ] CHANGELOG entry has been added and is linked to the correct PR on GitHub
[ ] Automated tests: All acceptance tests are passing (yarn run test)
[ ] Manual tests (minimum tests should cover newly added feature/fix): App works correctly in development build (yarn run dev)
[ ] Manual tests (minimum tests should cover newly added feature/fix): App works correctly in production build (yarn run package / CI builds)
[ ] There are no flow errors or warnings (yarn run flow:test)
[ ] There are no lint errors or warnings (yarn run lint)
[ ] Text changes are proofread and approved (Jane Wild)
[ ] There are no missing translations (running yarn run manage:translations produces no changes)
[ ] UI changes look good in all themes (Alexander Rukin)
[ ] Storybook works and no stories are broken (yarn run storybook)
[ ] In case of dependency changes yarn.lock file is updated

Code Quality

[ ] Important parts of the code are properly documented and commented
[ ] Code is properly typed with flow
[ ] React components are split-up enough to avoid unnecessary re-rendering
[ ] Any code that only works in Electron is neatly separated from components

Testing

[ ] New feature / change is covered by acceptance tests
[ ] All existing acceptance tests are still up-to-date
[ ] New feature / change is covered by Daedalus Testing scenario
[ ] All existing Daedalus Testing scenarios are still up-to-date

After Review:

[ ] Merge PR
[ ] Delete source branch
[ ] Move ticket to done on the Youtrack board

Note: the shadow type depends on the position.
When prompt is on top of the screen: Y=5px, bottom: Y=-5px

@a-rukin how should the normal state of this button look like?

transparent (bg is visible)

@a-rukin Here with syncing state and fixed button:

@a-rukin @darko-mijic this PR is now ready for review on Windows - you can test it as soon as the CI build is ready!

@DominikGuzei great work! 🎉
I've left just a minor observation. And there are some Flow & Lint errors.

@daniloprates thanks for the feedback! Flow and linting issues should be fixed now!
@darko-mijic i updated the notification copy!

@daniloprates regarding the className … there is no real reason but it doesn't hurt - especially later on for testing ;) but you're right, i shouldn't have added it if not necessary. Now i will leave it since it's more work / we lose CI build time if push another change 😆


update macos image from 11 to latest

The sample testing failures are unrelated to this change so overriding for merge.


Added new card - Shirdi Saibaba Temple

Added 3rd card to the row and Information about the shirdi saibaba's temple

Please add the tag for this merge as hacktober-accepted

@KPrathamesh-27
You don't need tags in PR when the project already have them


React to UI package split in vscode-azuretools

@vscode-azureextensionui was renamed to @microsoft/vscode-azext-utils as a part of this PR:
https://github.com/microsoft/vscode-azuretools/pull/1054
As a part of this PR, switched to use @microsoft/vscode-azext-utils

Thanks!


Added PE utils for sections and directories

Hello,
Here are a few utility functions that I'm currently using in my own projects, but that I think everyone could benefit from, so this could make sense to upstream them :-)

Thanks for the PR! I've reimplemented ImageDataDirectory::file_offset_range in #421 for better consistency with the existing APIs. Did you still need Section::contains_rva and SectionTable::section_at or were they only to support ImageDataDirectory::file_offset_range?

Thanks for this other PR, that's indeed probably more suitable as what I proposed :-)
Regarding Section::contains_rva and SectionTable::section_at, I happen to use SectionTable::section_at in my projects (but not contains_rva, at least not directly).
I'd not be surprised that other people as well could need both of them one day (in case they want to do some kind of manual parsing or displaying of PE files themselves). Thus, I think that would make sense to still provide them in the public API, but that's up to you to decide (and if you want me to, I can add a commit on top your MR to implement them).

They're still fine to add. You can probably update this PR, since I won't merge the other yet. Maybe rename section_at to something pe_section_containing or something like that, and rename contains_rva to pe_contains_rva (since these types are used for both PE and COFF, but these functions only apply to PE).

Sorry for the delay, I was quite busy last week.
Since I saw you've merged #421, I have rebased on 0.28.3, and I have added Section::contains_rva and SectionTable::section_at, which is quite a trivial change now.


[FLINK-12009] Fix wrong check message about heartbeat interval for HeartbeatServices

What is the purpose of the change
This pull request fixes wrong check message about heartbeat interval for HeartbeatServices
Brief change log

Fix wrong check message about heartbeat interval for HeartbeatServices

Verifying this change
This change is a trivial rework / code cleanup without any test coverage.
Does this pull request potentially affect one of the following parts:

Dependencies (does it add or upgrade a dependency): (yes / no)
The public API, i.e., is any changed class annotated with @Public(Evolving): (yes / no)
The serializers: (yes / no / don't know)
The runtime per-record code paths (performance sensitive): (yes / no / don't know)
Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Yarn/Mesos, ZooKeeper: (yes / no / don't know)
The S3 file system connector: (yes / no / don't know)

Documentation

Does this pull request introduce a new feature? (yes / no)
If yes, how is the feature documented? (not applicable / docs / JavaDocs / not documented)

@sunjincheng121 Can you review this PR?

+1

@flinkbot approve description
@flinkbot approve consensus

@azagrebin @sunjincheng121 Thanks for pointing the mistake and sorry for the late reply, I attended the Flink Forward SF 2019 and just come back today. I have updated the PR.

Thank you for participating in 2019 flink forward, I believe that there is a great gain. @yanghua!
Merging...
@flinkbot approve all
Best,
Jincheng


[FEATURE] Card UI at Meet Page

Is your feature request related to a problem? Please describe.
A clear and concise description of what the problem is. Ex. I'm always frustrated when [...]
The meet page card can have a better ui,as in the sizing and borders can be fixed,right now in the mobile view the card seems to consume all the width,leaving no breathing space!
Describe the solution you'd like
A clear and concise description of what you want to happen.
working with the length and breadth and adding a border radius would make the card more user friendly and appealing
Describe alternatives you've considered
A clear and concise description of any alternative solutions or features you've considered.
Additional context
Add any other context or screenshots about the feature request here.

The card has an issue ,when extra content is written it removes the extra content, a flex wrap has to be done across the content section so all the card content is visible and size is not hampered

Fixed.


Reactive flux

Added reactive flux method to OPS, includes example and tests.
Developed as part of E-CAM ESDW in Traunkirchen in November 2016 and finished at the follow up workshop in Vienna on a sunny day in April 2017.
Link to the gitlab repository:
https://gitlab.e-cam2020.eu/Classical-MD_openpathsampling/RF/tree/master

Please note that we have changed to the OPS license from LGPL (2.1 or later) to MIT. For any pull request to OPS that was started while the license was still LGPL, I need an explicit confirmation that you approve of the license change. Please add a comment with something like "The changes in this pull request are licensed under the MIT license."

@singraber : Would you be able to start a new PR for this? It should be pretty easy. This one has tons of conflicts; the new repo setup means that you just add new files in the appropriate places: A new path simulator in pathsimulators/ (with any helper classes), and put the new analysis in its own file in analysis/. Add your tests (we'll eventually move them around to match the code directory structure) and add the relevant things in __init__.py. Closing and reopening should be much easier than trying to update this PR.
Also, note that a new PR will (implicitly) be under the current license. We switched to the MIT license right before releasing 1.0.

This PR is superseded by #924.


Bring back the "Remove instrument overrides" button

Can link this into #35 by allowing changing of instrument across the entire track


Add MainActor & Sendable annotation to relevant types

This PR adds the @MainActor annotation, and thus MainActor isolation, to all relevant types and closures in SectionKit and DiffingSectionKit.
This makes it possible for the compiler to statically detect, whether a function might be called from a background thread.
Since SectionKit interacts with UICollectionView, it is very important, that all accesses to its functions are performed from the main thread.
Theoretically, using the MainActor class requires iOS 13, but I've tested the annotation with a project that targets iOS 11 (the oldest iOS version that Xcode 14 supports) and it compiled without complaints (it seems the actor isolation is toolchain specific, whereas calling a function like MainActor.run is iOS version specific). This means, the only requirement is Swift 5.5 (which is shipped with Xcode 13.0). Thus this PR increases the swift-tools-version to 5.5 to fit that requirement.
Additionally, some types have been marked as Sendable.
Please note: This is potentially a source breaking change.

CI is still on Xcode 12.5 🙈


Companion to duckdb/duckdb/pull/7874

I can say the code compiles now , if you move the duckdb reference to the commit in https://github.com/duckdb/duckdb/pull/7874 .  However the tests fail then (in this that seems unrelated). Its clear I'm not running it how it was intended (had to tell the Makefile not to restore the duckdb reference).

Thanks - I think the test failures are unlikely to be related to this change.


⚠ api.piste.gouv.fr healthcheck has degraded performance

In 91db6f9, api.piste.gouv.fr healthcheck (https://api.piste.gouv.fr/cassation/judilibre/v1.0/healthcheck) experienced degraded performance:

HTTP code: 200
Response time: 5268 ms

Resolved: api.piste.gouv.fr healthcheck performance has improved in b6fb5d7.


Remove numpy pin

Checklist

[x] Used a personal fork of the feedstock to propose changes
[x] Bumped the build number (if the version is unchanged)
[x] Reset the build number to 0 (if the version changed)
[x] Re-rendered with the latest conda-smithy (Use the phrase @conda-forge-admin, please rerender in a comment in this PR for automated rerendering)
[x] Ensured the license file is being packaged.

@conda-forge-admin, please rerender

Hi! This is the friendly automated conda-forge-linting service.
I just wanted to let you know that I linted all conda-recipes in your PR (recipe/meta.yaml) and found it was in an excellent condition.
I do have some suggestions for making it better though...
For recipe/meta.yaml:

ℹ No valid build backend found for Python recipe for package cosmosis-build-standard-library using pip. Python recipes using pip need to explicitly specify a build backend in the host section. If your recipe has built with only pip in the host section in the past, you likely should add setuptools to the host section of your recipe.

This message was generated by GitHub Actions workflow run https://github.com/conda-forge/conda-forge-webservices/actions/runs/12087987585. Examine the logs at this URL for more detail.

Hi! This is the friendly automated conda-forge-linting service.
I just wanted to let you know that I linted all conda-recipes in your PR (recipe/meta.yaml) and found it was in an excellent condition.


Allow Graphing of Values Less than 1

The current implementation doesn't allow graphing float values. I have datasets where the values are all less than 1. Let me know if/how you want me to resolve the date conflicts.

Hello and thanks for the interest !
This has already been fixed by #222, so the latest version of line-chart should solve your problem.

Hello and thanks for the interest !
This has already been fixed by #222, so the latest version of line-chart should solve your problem.


Startup screen

Now shows a small startup/load screen initially.
If I forgot to plug a hole somewhere in the controller, feel free to say so.

Good work!


Follow-up to PR #6964

Proposed changes

Unreleased project version (optional)

Related issues (optional)

Deploy preview for docsdocker ready!
Built with commit 5fbd73c10af14a23059cc4f60ffe3d23d97ef748
https://deploy-preview-7970--docsdocker.netlify.com


[Enhancement] Support configuring HMS timeout param when creating hive/iceberg connector

Why I'm doing:
It's strange to make hms timeout configuration static on FE side, as this timeout is a frequently used parameter, users may want to configure different timeout value based on different connector.
I think it's good to configure the hms timeout when creating hive/icebeg connector.
What I'm doing:
I want to make the hms timeout param configurable when creating connector. I added a new property hive.metastore.timeout. We can use it like this:
CREATE EXTERNAL CATALOG hiveconnector
PROPERTIES
(
"type" = "hive",
"hive.metastore.type" = "hive",
"hive.metastore.timeout" = "600",
"hive.metastore.uris" = "thrift://<IP_ADDRESS>:9083"
);

Fixes #issue
What type of PR is this:

[ ] BugFix
[ ] Feature
[x] Enhancement
[ ] Refactor
[ ] UT
[ ] Doc
[ ] Tool

Does this PR entail a change in behavior?

[ ] Yes, this PR will result in a change in behavior.
[x] No, this PR will not result in a change in behavior.

If yes, please specify the type of change:

[ ] Interface/UI changes: syntax, type conversion, expression evaluation, display information
[ ] Parameter changes: default values, similar parameters but with different default values
[ ] Policy changes: use new policy to replace old one, functionality automatically enabled
[ ] Feature removed
[ ] Miscellaneous: upgrade & downgrade compatibility, etc.

Checklist:

[ ] I have added test cases for my bug fix or my new feature
[ ] This pr needs user documentation (for new or modified features or behaviors)

[ ] I have added documentation for my new feature or new function

[ ] This is a backport pr

Bugfix cherry-pick branch check:

[ ] I have checked the version labels which the pr will be auto-backported to the target branch

[ ] 3.2
[ ] 3.1
[ ] 3.0
[ ] 2.5

@stephen-shelby Do you have any suggestion? Thx.


Footer type 4 created

Used basic bootstrap and css effects and responsive

Please check this. And thanks for giving chance to be a part of your project and open source !!

Hey!!. Can u please accept my PR if u like it, as soon as possible please

Can you please change your footer design folder name to "footer - 5" , because "footer - 4" is already present .

So do i have to make a PR again??

The other footer was made after 1hr of mine,
Do i have to change the name and make PR??

Bro done. Please look into it

Please see the PR that i have made
Added footer-5


Update request: discord 0.0.46 → 0.0.47

Package name: discord
Latest released version: 0.0.47
Current version on the unstable channel: 0.0.46
Current version on the stable/release channel: 0.0.45
[x] Checked the nixpkgs pull requests

Notify maintainers
@MP2E @Scrumplex @artturin @infinidoge @jopejoe1

Note for maintainers: Please tag this issue in your PR.
Backport to 23.11 is also requested.

Add a :+1: reaction to issues you find important.

Relevant PR: https://github.com/NixOS/nixpkgs/pull/299552
Created by @DontEatOreo
After merging please also backport to 23.11.


missing requirements

added missing requirements

This was the full list I came up with when running on OSX:
colorama
argparse
emailprotectionslib
dnslib
dnspython
tldextract

Hey all,
The additional dependencies were for the spoofcheck.py script. This has been removed from this project and extracted into its own module:
https://github.com/bishopfox/spoofcheck
That being said, thanks for the heads up on the tldextract dependency, which is still missing from the spoofcheck module's requirements.txt. I will add the dependency there.


Missing composer

Sail Version: 1.8.3
Laravel Version: 8.49.1
PHP Version: 8.0.0
OS: macOS 10.14.6

Description:
composer appears to be missing from the v1.8.3 sail environment. The workaround is to drop in to a terminal within the container and install it manually (I'm running Docker version 20.10.7, build f0df350).
Steps To Reproduce:

Once you have sail freshly set up and running, run a composer command, e.g. sail composer --version
The above step produces this error message: OCI runtime exec failed: exec failed: container_linux.go:380: starting container process caused: exec: "composer": executable file not found in $PATH: unknown

Seems to work fine for me on the latest Sail version.
$ sail composer --version
Composer version 2.1.3 2021-06-09 16:31:20

i have the same issue, with fresh install (laravel 8.50.0, sail 1.8.6, on ubuntu 21.04)

i have the same issue, with fresh install (laravel 8.50.0, sail 1.8.6, on ubuntu 21.04)

Have you found a solution?

i have the same issue, with fresh install (laravel 8.50.0, sail 1.8.6, on ubuntu 21.04)

Have you found a solution?

No, but now it's working.. i didn't do anything, just updated my system daily... maybe try to updated your os, and try the latest sail...

Removed pre-existing containers, forcing it to rebuild when running vendor/bin/sail up . New container has composer installed.


fix bug for planner

Checklist

[X] I've read the contribution guidelines.
[X] I've searched other issues and no duplicate issues were found.
[X] I'm convinced that this is not my fault but a bug.

Description

fix segmentation fault for onVehicleVelocity() https://github.com/autowarefoundation/autoware.universe/pull/1300
fix uninitialized boost optional for runout https://github.com/autowarefoundation/autoware.universe/pull/1270
fix bug for intersection segfo at last stop index https://github.com/autowarefoundation/autoware.universe/pull/1283
fix segfo at crosswalk https://github.com/autowarefoundation/autoware.universe/pull/1287
fix stop line uninitialized ptr https://github.com/autowarefoundation/autoware.universe/pull/1245
fix virtual wall for blindspot https://github.com/autowarefoundation/autoware.universe/pull/1298

Expected behavior
tbd
Actual behavior
node dies
Steps to reproduce
launch scenario simulator
Versions
autoware.universe v0.4.0
Possible causes
No response
Additional context
No response

yes 2 more fix will be added. I will add those tommorow

@mitsudome-r
I close this issue for obvious bugs are fixed.


NGINX server

[ ] If you’ve got a question about one behavior, you should compare your program behavior with NGINX’s (serves as a benchmark).


Contact maillist

Add mail list to our contact ways.

Coverage remained the same at 21.619% when pulling f4da110604ec7d2cb4abc753eb1b62dbfc3d4c66 on contact-maillist into b0684ed9e6e87e1b8d99eeda8a6ffac54dcfa98a on master.


[e2e] OLM error unknown msg index

To reproduce:

Create a room (from web client, or iOS, but not an android), enable encryption
Send a few msgs
Invite an android user
Join the room with this android user
Send another msg with the user who created the room

The first messages on the invited device became : "Unable to decrypt: OLM error: UNKNOWN_MESSAGE_INDEX"

that's expected behaviour. It probably needs a better error message, though.

@richvdh At first it's "Unable to decrypt: The sender's device has not sent us the keys for this message". Then it became "Unable to decrypt: OLM error: UNKNOWN_MESSAGE_INDEX" as soon as the author send a message after invited user joined.
Is that the expected behaviour ?

Yes, that is what I would expect
On 21 December 2016 12:21:58 GMT+00:00, jeangb<EMAIL_ADDRESS>wrote:

@richvdh At first it's "Unable to decrypt: The sender's device has
not sent us the keys for this message". Then it became "Unable to
decrypt: OLM error: UNKNOWN_MESSAGE_INDEX" as soon as the author send
a message after invited user joined.
Is that the expected behaviour ?
--
You are receiving this because you were mentioned.
Reply to this email directly or view it on GitHub:
https://github.com/vector-im/riot-android/issues/798#issuecomment-268510136

--
Sent from my Android device with K-9 Mail. Please excuse my brevity.

I understand the first one but not the second. I don't know why the message suddenly changes.

And why I don't reproduce it when the creator of the room is an android device.

The web client uses the same megolm session after a new user joins: it shares the current state of the session with the new user. So, after the new user receives a key-share message, they know about the session, but cannot decrypt messages sent before they joined.
I assume that the android client uses a new session when a new user joins.

Ok thanks richvdh

This happens with desktop clients too

@richvdh I think this error can also happen in another situation which I'm not sure how since it is non deterministic. I was in a room with a friend for a while and all of a sudden without any devices changes, log in/log out, etc, three of his messages said that they couldn't be decrypted and then it turned into the Unknown Message Index error, then his messages started coming in again.

Attached is a screenshot.


Feature Request: Official support for integration with firebase-admin and google-auth-library ExternalAccountClient.

Is your feature request related to a problem? Please describe.
firebase-admin   requires credential in STS response format, but it is not exposed:
https://github.com/LumaKernel/google-auth-library-nodejs/blob/21a91c2c6e5317e6f6e2e8709bca2953999f98d4/src/auth/baseexternalclient.ts#L432-L432
We can calculate STS response from cachedAccessToken that is calculated from above, but it is private field.
Describe the solution you'd like
Exposing cached STS response, and optionally, exposing cachedAccessToken.
Describe alternatives you've considered
Only storing cached STS response and make cachedAccessToken getter.
Additional context
Workaround:
import admin from 'firebase-admin'
import type { GoogleOAuthAccessToken } from 'firebase-admin/app'
import type { FooAccountClient, Credentials as GoogleAPICredentials } from 'google-auth-library'

// Converting to original STS response format.
const convertToFirebaseCredential = (gapiCred: GoogleAPICredentials): GoogleOAuthAccessToken => {
  const { access_token, expiry_date } = gapiCred
  if (typeof access_token !== 'string')
    throw new Error('Google auth credential without access_token is incompatible')
  if (typeof expiry_date !== 'number')
    throw new Error('Google auth credential without expiry_date is incompatible')
  return {
    access_token,
    // inverse opertation of following
    // https://github.com/googleapis/google-auth-library-nodejs/blob/5ed910513451c82e2551777a3e2212964799ef8e/src/auth/baseexternalclient.ts#L446-L446
    expires_in: Math.floor((expiry_date - new Date().getTime()) / 1000),
  }
}

// Usage example
const createApp = async () => {
  const client = new FooAccountClient({ /* ... */ });
  const credential = {
    getAccessToken: async () => {
      await client.getAccessToken()
      // cachedAccessToken is private
      const gapiCred: GoogleAPICredentials = (client as any).cachedAccessToken
      return convertToFirebaseCredential(gapiCred)
    },
  };
  admin.initializeApp({
    // ...
    credential,
  });
}

It is real working workaround in our project.

@hiranya911, @lahirumaramba, I'm not very familiar with firebase-admin, I don't suppose you have any thoughts as to what the interface should look like to make it easier to integrate google-auth-library?
Would happily take a patch.

????? @bcoe you literally work for Google. How do you not have a contact at the Firebase team that can help dive in and make things right?
I've spent many many hours to create this issue, it seems like this lib and firebase's auth lib are on different planets, and for no good reason.
https://github.com/googleapis/google-auth-library-nodejs/issues/1418

Do we have an idea of when this is going to release?
Are you saying that we cannot verify a user if we are using the identity platform for the users?
Also, I tried to implement the workaround that is mentioned in https://github.com/googleapis/google-auth-library-nodejs/issues/1322#issue-1059391259.
But FooAccountClient is not available in google-auth-library.
"firebase-admin": "^11.5.0",
"google-auth-library": "^8.7.0"


HBASE-25380 [create-release] Add timestamping to log output

Added logging of timestamp so we can tell where we are spending time.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s
No case conflicting files found.

+0 :ok:
shelldocs
0m  0s
Shelldocs was not available.

+1 :green_heart:
@author
0m  0s
The patch does not contain any @author tags.

_ master Compile Tests _

+0 :ok:
mvndep
0m 22s
Maven dependency ordering for branch

_ Patch Compile Tests _

+0 :ok:
mvndep
0m  7s
Maven dependency ordering for patch

+1 :green_heart:
shellcheck
0m  4s
There were no new shellcheck issues.

+1 :green_heart:
whitespace
0m  0s
The patch has no whitespace issues.

_ Other Tests _

+0 :ok:
asflicense
0m  0s
ASF License check generated no output?

2m 52s

Subsystem
Report/Notes

Docker
ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2758/1/artifact/yetus-general-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/2758

Optional Tests
dupname asflicense shellcheck shelldocs

uname
Linux 9ba0d174dbaf 4.15.0-112-generic #113-Ubuntu SMP Thu Jul 9 23:41:39 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
master / c853c99b20

Max. process+thread count
51 (vs. ulimit of 30000)

modules
C:  U:

Console output
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2758/1/console

versions
git=2.17.1 maven=3.6.3 shellcheck=0.4.6

Powered by
Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Thanks @apurtell

Signed-off-by: Andrew Purtell<EMAIL_ADDRESS>


Add collectors to Analysis Integration Tests

Given this generic example on how to add a collector to kuttl tests #1834, we should add collectors in each analysis integration test that:

collect logs of metrics-operator
run a kubectl describe for the analysis CRD

DoD

[ ] manually verify that when the test fails, the logs and describes are visible in the shell

interested

/assign

Hi @briheet01, unfortunately we do not use an assign bot. This issue is already taken, but feel free to grab an other one here


CARDS-2360: Display startup warning if the GOOGLE_APIKEY environment variable is not set

Testing:

start without defining the GOOGLE_APIKEY environment variable, check that the warning message is displayed
stop cards
set the GOOGLE_APIKEY environment variable
start cards, check that the warning message is no longer displayed

UPDATED: it is not checking for GOOGLE_API key. Once I set BIOPORTAL_KEY the warning message was gone.

Already fixed in 9808209, please retest. Also added some testing instructions.

re-tested
no `GOOGLE_APIKEY'

Minor observations (out of scope):

We check for BIOPORTAL_APIKEY only when starting in test mode, perhaps we can do it outside of the test mode as well?
When an invalid BIOPORTAL_APIKEY is set, the HANCESTRO installation fails. When an invalid GOOGLE_APIKEY is set, nothing happens when starting cards, however the address type fields will not to work.

re-tested

I just made another change wile you are testing, the GOOGLE_APIKEY warning is now yellow.

Minor observations (out of scope):

We check for BIOPORTAL_APIKEY only when starting in test mode, perhaps we can do it outside of the test mode as well?

I'm not sure that's necessary. When going to install vocabularies from the Admin, it is clear from the UI that you need an API key to do so and there's a place to add it right there.

When an invalid BIOPORTAL_APIKEY is set, the HANCESTRO installation fails. When an invalid GOOGLE_APIKEY is set, nothing happens when starting cards, however the address type fields will not to work.

Not sure if this is where you are going with the second observation, but the color was changed to yellow because nothing "bad" happens immediately at startup.

Minor observations (out of scope):

We check for BIOPORTAL_APIKEY only when starting in test mode, perhaps we can do it outside of the test mode as well?

I'm not sure that's necessary. When going to install vocabularies from the Admin, it is clear from the UI that you need an API key to do so and there's a place to add it right there.

The reason why the check for the BIOPORTAL_APIKEY is only done when the test run mode is enabled is because the test run mode installs the HANCESTRO vocabulary as such is a requirement for certain test forms (ie. ones that have cards:VocabularyAnswer typed questions). If HANCESTRO fails to install when the test run mode is enabled, then there definitely will be forms that don't work properly, There are however many use cases where vocabularies don't need to be installed from BioPortal (such as HERACLES, DATA-PRO, and Your Experience) and thus displaying a missing BIOPORTAL_APIKEY warning here wouldn't really be that meaningful of a warning.

When an invalid BIOPORTAL_APIKEY is set, the HANCESTRO installation fails. When an invalid GOOGLE_APIKEY is set, nothing happens when starting cards, however the address type fields will not to work.

Not sure if this is where you are going with the second observation, but the color was changed to yellow because nothing "bad" happens immediately at startup.

It is true that address type fields will not work if the GOOGLE_APIKEY is missing or is invalid but this is only really a problem if the CARDS project uses address type fields. As we are soon moving to using separate repositories for the various CARDS projects that we support, I think what I'd like to do would be to add a validate_environment.sh script to the project-specific Docker images (eg. ghcr.io/data-team-uhn/cards4sparc) which upon execution would validate that the required environment variables are present and are set to valid values. This way, when a project-specific Docker image is started, it will immediately fail (or at the very least generate warnings) as required environment variables are missing/invalid.
So perhaps the best plan for now would be like this:

Since none of our other projects support address typed questions, let's have start_cards.sh check for a missing GOOGLE_APIKEY only if no -P or --project has been specified.
We'll create a validate_environment.sh script in the https://github.com/data-team-uhn/cards4sparc repository that will check if GOOGLE_APIKEY is set (and we can even validate it against Google's API endpoints).
When starting Cards4SPARC without Docker, we can call validate_environment.sh before start_cards.sh which will throw an error is GOOGLE_APIKEY is missing/invalid.
The validate_environment.sh script would also be included in the generated ghcr.io/data-team-uhn/cards4sparc Docker image so that Cards4SPARC would fail to start if GOOGLE_APIKEY is missing/invalid.

TL;DR
So just keeping within the scope of this task, I recommend checking for GOOGLE_APIKEY only if no -P or --project has been specified.

It is true that address type fields will not work if the GOOGLE_APIKEY is missing or is invalid
Not true, the suggestions wont work. From user perspective nothing will be broken, the field becomes jst a plain text input

It is true that address type fields will not work if the GOOGLE_APIKEY is missing or is invalid

Not true, just the address suggestions from Google Places service won't work. From user perspective nothing will be broken, the field becomes jst a plain text input

Okay, that's good. So in that case, I'd still recommend only checking if GOOGLE_APIKEY is present if no -P / --project is specified but I'd simply print a warning with a bit more detail (eg. "Place suggestions won't work" / "Addresses will only work as plain text input") and for the specific projects we can define, through validate_environment.sh if the missing/invalid GOOGLE_APIKEY constitutes an error, warning, or should simply be ignored.


Add button to collapse or expand all objects, arrays in main editor

This can be added to the floating FAB button that is now used for copy and clear.
References:
https://stackoverflow.com/questions/50148938/fold-unfold-on-click-of-button-in-monaco-editor

@BoyWithSilverWings  Please assign this to me.

@howareyouami  All yours. :smile:

Fixed by #40


Add coingeckoId for SHARDS token

Please see https://github.com/solana-labs/token-list/pull/19179

merged


Horny

Why am I here?  Help me find my brain. OAEH

how much for smash?

how much for smash?


Disable installation buttons when no device is connected

At best with an tooltip/popover on hover that informs the user that they need to connect their device to perform the installation.

Fixed with https://github.com/garredow/kaiware/commit/e3b3d4f58888596fe314ec9fddadbce4bc6b25ae and https://github.com/garredow/kaiware/commit/80ca6b44bd0323dc551759f685c2ae5300dafa4b


Does it do image to 3dmodel?

So we can feed it our own images instead of prompting unknown ?

Hello, the current model supports only text-to-3D generation. One of my colleagues is working on extending this model to image-to-3D generation. Thanks


Macrodroid setup

Hi,
this is probably again a documentation thing:
It seems to me the macrodroid setup section is only started, but I would like to know the complete setup to trigger a wakeup.
Could you provide it please?

I am not an Android/Macrodroid user, so I can only describe it in general terms.
In general you'll need to create an 'action' to send a HTTP request to your exposed Teslamate instance e.g. http://ip-address:port/api/car/1/logging/resume. Note that the request method needs to be PUT.
Depending on your setup (e.g. Advanced Docker Setup) you may have protected the endpoint with HTTP basic authentication. If that's the case a HTTP header with the key Authorization and your base64 encoded credential is required. The value is constructed like this:

Your chosen username and the password are combined with a colon: aladdin:opensesame
The resulting string is base64 encoded: YWxhZGRpbjpvcGVuc2VzYW1l
The encoded string is prefix with "Basic ": Basic YWxhZGRpbjpvcGVuc2VzYW1l

MacroDroid may also offer the option to automatically encode a username and password.
Hope this helps!

Thank you!
I was actually able to figure it out using the Android Tasker description you provided. Macrodroid integrates well with RESTasker which can also handle the basic HTTPauth behind my home traefik proxy.
Works like a charm now, built a trigger for bluetooth connection and when I open the phone app, because when I preheat in the morning I want the consumption and temperature to be logged as well.
Thanks again for providing this and the great dashboards, this is a true private replacement for Teslafi!
(will open another ticket though with a suggestion)

Glad it works now! It would be nice if you could create a PR with your approach. That would certainly help others :-)

Thanks again for providing this and the great dashboards, this is a true private replacement for Teslafi!

Thanks!