Access single item resource lists at index 0

Resources with a count of 1 are now output as a list. The source code has been updated to access the item at index 0 to fix issues introduced by Terraform 0.12.
Please see upgrade guide for more info: https://www.terraform.io/upgrade-guides/0-12.html#working-with-count-on-resources

+1

v2.0.0 has been just released (it requires Terraform 0.12).
Make sure to pin module version to ~> v2.0 if you are using Terraform 0.12, and use ~> v1.0 if you are using Terraform 0.11.


add net hop interfaces to static route templates

closes #192

Corrected data model oversight due to incorrect conditional logic.


(#910) Packaging Tutorial - MSI Installation

Description Of Changes
This commit adds a tutorial for how to create an MSI installation package.
Motivation and Context
We have a request for more tutorials around this area.
Testing

[x] I have previewed these changes using the Docker Container or another method before submitting this pull request.

Change Types Made

~[ ] Minor documentation fix (typos etc.).~
~[ ] Major documentation change (refactoring, reformatting or adding documentation to existing page).~
[x] New documentation page added.
~[ ] The change I have made should have a video added, and I have raised an issue for this.~

Change Checklist

~[ ] Requires a change to menu structure (top or left-hand side)/~
~[ ] Menu structure has been updated~

Related Issue
Fixes #910

@pauby I've got the outstanding requested changes sorted here.

I've made a few final changes, squashed the commits and set to auto-merge.


WUC-14: Image

Task
Closes #14
Description

Компонент Image

:tada: This PR is included in version 1.3.0 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


Swipe to go back gesture not working in iOS

Hello,
While the swipe to go back gesture works fine in Android, in iOS it's not working at all.
I am pushing the page like this from within a tab: Shell.Current.GoToAsync("route");
Is there any workaround?
PS. Congrats on this great plugin, it really brings much needed features to Shell.

Hi @drmaven,
thanks for finding the missing feature. I tried to implement it in the newest version of the package.

Thanks for the quick response and solution, it works great!
I am wondering, is there a way to keep the default Shell transitions and swipe back gesture?

Hi @drmaven,
SimpleShell does not support native transitions at all because it is not implemented using native navigation controls. You can create your own transitions, but it is a bit limited. For example, it is not possible to create the aforementioned transition when swiping back on iOS.
I recommend using normal Shell for a native look and feel.

That's fine, SimpleShell provides many more benefits that I don't see myself going back to regular Shell. Thanks for the explanation!


Copying files in addition to the binary

Hi,
let me show you my usecase:
My go binary needs some configuration files to work with, so the file structure of a tar.gz archive from Goreleaser looks like this:
app_1.0.0_linux_amd64.tar.gz
├─data <-- directory, that I want to copy recursively. If possible to an appropriate directory
│ ├─data1.txt
│ ├─data2.json
│ ├─data3.yml
│ └─...
├─app <-- executable
└─LICENSE
Is this possible with this library? Do you have any recommendation?
Thanks in advance ...

?


Bump targrt SDK to 34 and update AGP to gradle v8

Hi! First off, thanks for this amazing library! I've been using it for a long time in my apps since it makes debugging so much easier. Users can easily see and copy relevant crash logs from crash-activity when submitting bug reports without dealing with things like ADB logcat and other third-party logger apps.
I've noticed that there haven't been any updates to this library in the past two years. While the library still works as expected, the target SDK version has become outdated, as Google Play now requires apps to target at least SDK 33. Additionally, the Gradle plugin was also around three years old. So, I've updated both of them and properly replaced deprecated properties with their alternatives.

@Ereza Pinging for comment / review


VizTracer not tracing some functions

I am using @log_sparse(stack_depth=8) to trace a couple of functions (say fun1(), fun2()) however only some of the functions called by fun1() and fun2() are traced. I am using
tracer = VizTracer(log_sparse=True)
    tracer.start()
    fun1()
    fun2()
    tracer.stop()

Is there a way to force VizTracer log all the functions called up to the specified stack_depth?

Can you provide a minimum reproducible example? What's your code and why you think it did not work properly? There's not much information in the description so I don't know where to look.


[Resources] Change the type of location

Contributing to the Azure SDK
Please see our CONTRIBUTING.md if you are not familiar with contributing to this repository or have questions.
For specific information about pull request etiquette and best practices, see this section.

API changes have been detected in Azure.ResourceManager.Resources. You can review API changes here

API changes have been detected in Azure.ResourceManager.Resources. You can review API changes here


Use https://prometheus.io

I don't think #1366 will make it into 0.17.0, so creating a separate PR for this.

:+1:


Aniekan Edet

Added my name to names.txt file

Please I am sorry for all the trouble we have caused you but count it all joy. Your PR is about to be merged and you will be able to see your name on this url.
To enable me to do this, READ the README again carefully, update your code with the latest and push the update. I am here for you for the next 6 hours before I close the PR so you can initiate a fresh PR which will be easier to merge.

Hello Aniekan!
Please open a new PR! Remember to make a branch as you work on your changes!
We look forward to merging your next PR! :partying_face:


altitude.sh Installer Requirements

Back when I first set up altitude on my raspberry pi I quickly discovered that the installer had trouble executing, so I moved the files over from another system.
Now I just saw that you're aware of that too:

"bash altitude.sh -c", then specify all defaults.

If this doesn't work, install altitude on a server which does and just rsync it over.

I have not gotten the installer to work on google compute, for example.

I suppose it's unknown what the cause of some systems succeeding and others failing is, right?
Something that might be interesting; a RPi with the latest Raspbian image fails at running altitude.sh, but the x86 version (in VirtualBox) of Raspbian installs altitude fine.
Is the console output you're getting also like this?

./altitude.sh

Unpacking JRE ...

Starting Installer ...

./altitude.sh: 431: ./altitude.sh: /home/pi/pathTo/altitude.sh.25435.dir/jre/bin/java: Exec format error

Has someone tried to narrow that error down?

No, but I have seen it a number of times too.  It also happens on a Linux container under a chromebook.
The installer is basically pointless, because it installs the same exact binaries on every Linux system, regardless of how it was executed.  So, I would create one nice raspberry pi install for yourself, then tar it up and use it as the basis for all your future installs.

Yeah that's what I've been doing; except zip instead of tar.
Well too bad~


OneCMS 7.1.23

THIS WILL BE THE FINAL FEATURE UPDATE RELEASED FOR 7.1.y,
AFTER THIS POINT, ALL RELEASES WILL BE FOR SECURITY/DOCUMENTATION
UPDATES ONLY. PLEASE PLAN TO UPGRADE TO 7.2.y ACCORDINGLY. (https://github.com/sladewatkins/website/issues/38)
What's new:

Mastodon/Webfinger updates
updates to dependencies (to be backported)
changes to the OneCMS generation system (to be backported)
added the OneCMS generation versioning to the footer
updated redirects for Mastodon

Backport-to: version-7.0.y (some commits)
Reviewed-by: Chuck Boulder<EMAIL_ADDRESS>Signed-off-by: Slade Watkins<EMAIL_ADDRESS>

diffstat:
Updating 631e758..1ca67ef
Fast-forward
 .github/FUNDING.yml                                           |  4 +---
 Gemfile.lock                                                  |  2 +-
 frontend/javascript/index.js                                  |  2 +-
 node_modules/.yarn-integrity                                  |  4 ++--
 node_modules/caniuse-lite/data/features/css-color-function.js |  2 +-
 node_modules/caniuse-lite/data/features/css-lch-lab.js        |  2 +-
 node_modules/caniuse-lite/data/features/css-nesting.js        |  2 +-
 node_modules/caniuse-lite/package.json                        |  2 +-
 src/.well-known/host-meta                                     |  2 +-
 src/.well-known/nodeinfo                                      |  2 +-
 src/.well-known/webfinger                                     | 10 +++++-----
 src/_components/footer.liquid                                 |  2 +-
 src/_components/head.liquid                                   |  2 +-
 src/_data/site_metadata.yml                                   |  2 +-
 src/_redirects                                                |  2 +-
 src/index.md                                                  |  1 +
 yarn.lock                                                     |  6 +++---
 17 files changed, 24 insertions(+), 25 deletions(-)


Storage account with ZRS replication not found

OS: All
Version: 1.11.0
Repro Steps:
I have some storage accounts StorageV2 (general purpose v2) with Standard Performance and different replication

Create Function App in Azure... (Advanced)
Written unique name for the function app
Selected any runtime stack
Selected any OS
Selected resource group in which my storage account with ZRS replication enabled is
Selected any hosting plan
My storage accounts with ZRS replication enabled are not present. Only storage accounts with LRS replication and RA-GRS replication are listed.

Expect:
On step 7, I expect to see all my storage accounts, included the ones with ZRS replication
Actual:
The storage accounts with ZRS replication are not listed by vsc. Doing the procedure through the Azure portal is successful even with the storage account not listed by vsc.

Interesting, thank you for the detailed repro steps. Do you know if you've been able to see the storage accounts with ZRS replication enabled in VS Code before?

Interesting, thank you for the detailed repro steps. Do you know if you've been able to see the storage accounts with ZRS replication enabled in VS Code before?

Hi.
It's the first time I'm using this extension, so I can't answer to your question.

Hi. It's the first time I'm using this extension, so I can't answer to your question.

No worries. Thanks for bringing this to our attention. I hope to get this fixed and released soon.

@SalvoRusso8 ZRS support has been released in version 1.12.0 of the extension. 🎉
https://github.com/microsoft/vscode-azurefunctions/releases/tag/v1.12.0


Curated Experience questions have unwanted tags(variable names)

From @alaatadmori on October 21, 2018 6:30
Some questions in the curated experience have tags similar to this: %%[Client first name TE]%%
We need to remove these tags.
e.g.
%%[Client first name TE]%% do you live in Alaska or Hawaii?
Should become:
do you live in Alaska or Hawaii?
Copied from original issue: Microsoft/Access2Justice#642

@grawdon Is this a valid defect?

@KellyeDC Have we heard from either state that this is still an issue? The only way for us to test would be to do every Guided Assist with every permutation to see if it turned up. That's not practical.

Unable to test


Add delay when firing auto-complete

I wish user could define delay e.g. 0.3 sec,  where  cmp-ai would wait for user to be idle for 0.3 before sending request to server.
I think right now it fires autocomplete on every stroke, right?
I know about [C-x] mapping, but still  having delay option would be cool - it would prevent my GPU fans from spining when typing fast, and not waiting for autocomplete.

This would be a request for upstream cmp (I think you can already achieve something similar using the general cmp config).
You can also disable the 'autocomplete on every keystroke' in the config. just set run_on_every_keystroke to false.

I  tried debounce option in cmp  ,  would still trigger  cmp_ai completions few times in a row ( disabling `run_on_every_keystroke' helps but there are still to many triggers for cmpletions).
In any case I just finished implementing debounce for cmp_ai,  if you want I can make PR, but I would need help with how to expose this in  cmp_ai settings.
My code is based on this.
Changed source.lua lines:
function Source:trigger(ctx, callback)
  if vim.fn.mode() == 'i' then
    self:_do_complete(ctx, callback)
  end
end

-- based on https://github.com/runiq/neovim-throttle-debounce/blob/main/lua/throttle-debounce/init.lua (MIT)
local function debounce_trailing(fn, ms)
    local timer = vim.loop.new_timer()
    local wrapped_fn

    function wrapped_fn(...)
      local argv = {...}
      local argc = select('#', ...)
      -- timer:stop() -- seems not needed?
      timer:start(ms, 0, function()
        pcall(vim.schedule_wrap(fn), unpack(argv, 1, argc))
      end)
    end
    return wrapped_fn, timer
end

local bounce_time = 700 -- in ms
local bounced_complete, ret_tim =  debounce_trailing(
  Source.trigger,
  bounce_time)

-- on keypress event autocommand -  call tim.timer_again
local au_bound = vim.api.nvim_create_augroup("BounceCompletion", { clear = true })
vim.api.nvim_create_autocmd("TextChangedI",{
  pattern = "*",
  callback = function()
    vim.loop.timer_again(ret_tim)
  end,
  group = au_bound
})

--- complete
function Source:complete(ctx, callback)
  if conf:get('ignored_file_types')[vim.bo.filetype] then
    callback()
    return
  end
  -- local bufnr = vim.api.nvim_get_current_buf()
  bounced_complete(self, ctx, callback)

end

@tzachar


azureml-core 1.0.8 has requirement ruamel.yaml<=0.15.51,>=0.15.35

while using azure notebook when i am importing "azureml.core" getting error "azureml-core 1.0.8 has requirement ruamel.yaml<=0.15.51,>=0.15.35, but you'll have ruamel-yaml 0.11.14 which is incompatible." but i have already "Requirement already up-to-date: ruamel.yaml==0.15.35 in /home/nbuser/anaconda3_420/lib/python3.5/site-packages (0.15.35)"
Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 72c6907a-8658-f29b-cce9-6af0a359f26b
Version Independent ID: e41c8c19-d858-9a84-4b89-1b65bdd960a8
Content: Quickstart: Get started in Python - Azure Machine Learning service
Content Source: articles/machine-learning/service/quickstart-create-workspace-with-python.md
Service: machine-learning
GitHub Login: @hning86
Microsoft Alias: haining

@TravisCragg-MSFT are you still investigating?

@j-martens this issue is currently assigned to the doc author for updates, and investigation is still in progress.

@YutongTie-MSFT - #please-assign to sdgilley

@YutongTie-MSFT - #please-assign to sdgilley

@arpitvw - do you still see this error? I suspect that you caught Azure Notebooks in a state where it had not yet incorporated the latest SDK changes.  I just tried this today and do not get the error, can you confirm that it's ok for you as well?   Thanks!

#please-close - if this is still an issue please feel free to re-open or contact tech support.  Thanks.


Config option flasharray.iSCSIAllowedCIDR is ignored

I installed the pso-csi by helm (helm install pure-pso pure/pure-pso --namespace pure -f values.yaml) and configured the values.yaml as follow:
...
flasharray:
  iSCSIAllowedCIDR: <IP_ADDRESS>/26
...

But on some containers, which fail to start, I still can see that those containers try to connect to other target which are not in the allowed list above:
time="2021-04-22T09:01:01Z" level=debug msg="Running command" args="[--mount=/proc/1/ns/mnt --ipc=/proc/1/ns/ipc --net=/proc/1/ns/net -- iscsiadm -m node -T iqn.2010-06.com.purestorage:flasharray.1234567812345678 -p <IP_ADDRESS>:3260 --login]" command=nsenter timeout=20
time="2021-04-22T09:01:01Z" level=debug msg="Running command" args="[--mount=/proc/1/ns/mnt --ipc=/proc/1/ns/ipc --net=/proc/1/ns/net -- iscsiadm -m node -T iqn.2010-06.com.purestorage:flasharray.1234567812345678 -p <IP_ADDRESS>:3260 --login]" command=nsenter timeout=20
time="2021-04-22T09:01:01Z" level=debug msg="Running command" args="[--mount=/proc/1/ns/mnt --ipc=/proc/1/ns/ipc --net=/proc/1/ns/net -- iscsiadm -m node -T iqn.2010-06.com.purestorage:flasharray.1234567812345678 -p <IP_ADDRESS>:3260 --login]" command=nsenter timeout=20
time="2021-04-22T09:01:01Z" level=debug msg="Running command" args="[--mount=/proc/1/ns/mnt --ipc=/proc/1/ns/ipc --net=/proc/1/ns/net -- iscsiadm -m node -T iqn.2010-06.com.purestorage:flasharray.1234567812345678 -p <IP_ADDRESS>:3260 --login]" command=nsenter timeout=20

The overall status of the pure pso-csi pods are as follow:
kubectl get pods -n pure
NAME                                         READY   STATUS                  RESTARTS   AGE
pso-csi-controller-0                         5/6     Running                 7          30m
pso-csi-node-r6vbf                           2/3     Running                 7          30m
pso-csi-node-vv9mj                           2/3     Running                 7          30m
pso-db-0-0                                   0/1     Running                 0          30m
pso-db-1-0                                   0/1     Running                 0          30m
pso-db-2-0                                   0/1     Init:CrashLoopBackOff   6          30m
pso-db-3-0                                   0/1     Init:CrashLoopBackOff   7          30m
pso-db-4-0                                   0/1     Init:CrashLoopBackOff   6          30m
pso-db-cockroach-operator-5867dc494d-l8vxf   1/1     Running                 0          30m
pso-db-deployer-6cff94ff4d-8txsh             1/1     Running                 0          30m

It's quiet interesting that on all containers the ENV variable isn't set properly:
kubectl describe pods pso-db-0-0 -n pure|grep PURE_ISCSI_ALLOWED_CIDRS:
      PURE_ISCSI_ALLOWED_CIDRS:

kubectl describe pods pso-db-2-0 -n pure|grep PURE_ISCSI_ALLOWED_CIDRS:
      PURE_ISCSI_ALLOWED_CIDRS:

Any help is highly appreciated.

After some investigation, this parameter isn't used by the DB pods, it is only used by CSI, we will discuss the mitigation and fix and get back.

Hi @L4rS6, we identify it's a bug that we do not pass the iSCSIAllowedCIDR parameter to the PSO's db pods. We plan to release the next version in June. We will discuss the issue again in late May and give an update to see if we can squeeze the fix into the new release. We will get back to you later next month.

Hi @dsupure, thank you for clarification. Is there a possibility to get that fix earlier? For us it is currently impossible to use that plugin due to that bug.

Hi @dsupure, are there any news regarding the new version including that fix?

Are there any news regarding the release date for the next release including that fix?

Hi @dsupure and @haibinxie, has this been fixed in the v6.2.0-rc1 release candidate? We are still unable to deploy the pso-csi plugin due to that bug...

@L4rS6 sorry for the late response, I have a PR out to fix this issue, it will be in v6.2.0 GA release. But the release date has not been determined. If you need a workaround, you could simply add the missing env PURE_ISCSI_ALLOWED_CIDRS to cockroach-operator.yaml according to the PR, or wait for the GA release which should be in August or September.


airshipper: add libGL to get gfx debug output

Description of changes
Adding libGL.so is not necessary for the running of neither airshipper no veloren, but we're adding it in anyways because:

veloren needs it, so anyone who wants airshipper will be having it anyways
when launching airshipper, it will dump quite a bit of gfx debugging to the console, so it might make things easier to troubleshoot things if veloren isn't working properly.

Things done

Built on platform(s)

[X] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[X] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[X] Tested basic functionality of all binary files (usually in ./result/bin/)
22.05 Release Notes (or backporting 21.11 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module
[ ] (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes

[X] Fits CONTRIBUTING.md.

@yusdacra , you're OK with this?


Print JSON question

Hello,
Can flatcc json printer prints to JSON data encoded by Python encoder from flatbuffers library? Or it is incompatibe with data encoded by Python or other languages?

Yes, it should. If you find that it doesn't for some reason, there is a bug in at least one of the libraries.

Even more, C decoder can't decoder Python encoded data. It seems like I am doing something wrong...
Full code available here
Here is a schema:
namespace proto; table Order {    id: uint32; } file_identifier "v001"; root_type Order;
Python encoder/decoder CAN both encode/decode self and decode C-encoded data:

import flatbuffers as fb
from python.proto import Order

# encode
b = fb.Builder(0)

Order.OrderStart(b)
Order.OrderAddId(b, 100)
o = Order.OrderEnd(b)

b.Finish(o)
out = bytes(b.Output())

# s = ""
# for i in out:
    # s += "0x{:02x}, ".format(i)
# print(s)

# decode self
order = Order.Order.GetRootAsOrder(out, 0)
print(order.Id())

# decode C-encoded Order
c_enc = b'\x08\x00\x00\x00\x76\x30\x30\x31\xf8\xff\xff\xff\x64\x00\x00\x00\x06\x00\x08\x00\x04\x00'

order = Order.Order.GetRootAsOrder(out, 0)
print(order.Id())

But C encoder/decoder crashed on assert during decoding Python encoded data

#include "c/proto_builder.h"
#include "c/proto_json_printer.h"
#include <stdio.h>
#include <assert.h>

int32_t main()
{
   // encode
   flatcc_builder_t b;
   flatcc_builder_init(&b);

   proto_Order_start_as_root(&b);
   proto_Order_id_add(&b, 100);
   proto_Order_end_as_root(&b);
   size_t size = 0;
   void* buf = flatcc_builder_finalize_aligned_buffer(&b, &size);

   /*for(size_t i = 0; i < size; ++i)*/
   /*{*/
      /*printf("\\x%02x", ((unsigned char*)buf)[i]);*/
   /*}*/
   /*printf("\n");*/

   {
      // decode self
      proto_Order_table_t t = proto_Order_as_root(buf);
      printf("%d\n", proto_Order_id_get(t));
   }

   {
      // print self
      flatcc_json_printer_t ctx;
      char json[4096] = {};
      flatcc_json_printer_init_buffer(&ctx, json, sizeof(json));
      proto_print_json(&ctx, buf, size);
      printf("%s\n", json);
   }

   {
      // decode python encoded Order
      const char buf[] = {0x0c, 0x00, 0x00, 0x00, 0x00, 0x00, 0x06, 0x00, 0x08, 0x00, 0x04, 0x00, 0x06, 0x00, 0x00, 0x00, 0x64, 0x00, 0x00, 0x00};
      proto_Order_table_t t = proto_Order_as_root(buf);
      assert(t); // FAILED!!!
      printf("%d\n", proto_Order_id_get(t));
   }

   return 0;
}

The buffer has no identifier, so to override the default identifier check, you need to set a null identifier to indicate that you do not care about the value (at byte offset 4..7).
proto_Order_as_root_with_identifier(buf, 0);

because the buffer has no file identifier as expected. You could also manually set the identifier at byte offset 4..7 to "v001". I am a bit concerned though: why is the buffer content at that offset
0x00, 0x00, 0x06, 0x00,
that looks like garbage, at least it could have been all 0x00 if not set.
The C encoder has set the verifier to \x76\x30\x30\x31 which is v100 in ASCII.
Also note that strictly speaking that const char buf is not aligned. This works on x86, but not everywhere. Especially the verifier might complain if you tried to use it. It is always good to run the verifier first, when testing integration. It would have said the identifier is missing.

Oh wait, perhaps the 4 bytes in the python buffer is not garbage, but just a missing identifier The field can actually be absent - you don't really know except that it does not match expectations. It is valid to omit an identifier, but flatcc needs to be told that this is OK. (The reason it is unknown is that the first 4 bytes point to the root table, so the next 4 bytes could be any data referenced from elsewhere).

You right, If I add file identifier by hand C encoding/printing works well.

It is valid to omit an identifier, but flatcc needs to be told that this is OK
How can I told to flatcc to omit file identifier ?

BTW, there is no file identifier in Python flatbuffers yet. Still under development.

for reading, as i wrote:
proto_Order_as_root_with_identifier(buf, 0);

instead of
proto_Order_as_root(buf);

I tested this, and it does print JSON without an assertion.
Or, (I think), if you remove file_identifier from the schema. See documentation for details.
For building, you pass a null identifier in a similar manner and it will not get stored (I think).
NOTE: I was wrong in saying that you can just add the identifier manually because you will need to make space to do that, and that can cause various problems so I won't even try to explain. IFF you are sure there is already an identifier, then you can overwrite it with what you want. But that is not the case here, I was wrong in my first answer.

Thanks a lot!

The reason you could overwrite byte 4..7 with the identifier is just pure luck. You were overwriting some unused padding and vtable header fields only need for verification.


fix: curve float64

Description
Please describe the change you have made.
Checklist:

[ ] Tests added/updated.
[ ] Documentation updated.
[ ] Changelog updated in CHANGELOG.md.
[ ] Version bumped. If triggering a new release is desired, bump the version number in pyproject.toml per semantic versioning.

@eriklien just some pygen updates since the version is newer than last time it was ran but yea it's all auto pygen stuff so no need to review the _generated folder


feat(Badges)!: color + size variants

Overview

Adds accent state + size variant to Badges

PR Checklist

[x] Related to designs: here
[x] Related to JIRA ticket: gm-352
[x] I have run this code to verify it works
[ ] This PR includes unit tests for the code change

📬Published Alpha Packages:@codecademy/gamut-kit@0.6.18-alpha.03ebf7.0@codecademy/gamut-labs@28.0.13-alpha.03ebf7.0@codecademy/gamut@40.3.4-alpha.03ebf7.0@codecademy/monaco@0.5.14-alpha.03ebf7.0<EMAIL_ADDRESS>
🚀 Styleguide deploy preview ready!https://619587b3d09b6826e612d4ef--gamut-preview.netlify.appDeploy Logs

📬Published Alpha Packages:@codecademy/gamut-kit@0.6.19-alpha.bdee74.0@codecademy/gamut-labs@28.0.14-alpha.bdee74.0@codecademy/gamut@40.3.4-alpha.bdee74.0@codecademy/monaco@0.5.14-alpha.bdee74.0<EMAIL_ADDRESS>
📬Published Alpha Packages:@codecademy/gamut-kit@0.6.19-alpha.e51a07.0@codecademy/gamut-labs@28.0.14-alpha.e51a07.0@codecademy/gamut@40.3.4-alpha.e51a07.0@codecademy/monaco@0.5.14-alpha.e51a07.0<EMAIL_ADDRESS>
🚀 Styleguide deploy preview ready!https://6196aacab1490400cc9a5053--gamut-preview.netlify.appDeploy Logs

📬Published Alpha Packages:@codecademy/gamut-kit@0.6.19-alpha.c6c152.0@codecademy/gamut-labs@28.0.14-alpha.c6c152.0@codecademy/gamut@40.3.4-alpha.c6c152.0@codecademy/monaco@0.5.14-alpha.c6c152.0<EMAIL_ADDRESS>
🚀 Styleguide deploy preview ready!https://6196c4ede4e3b30cfc5ac526--gamut-preview.netlify.appDeploy Logs

📬Published Alpha Packages:@codecademy/gamut-kit@0.6.19-alpha.362542.0@codecademy/gamut-labs@28.0.14-alpha.362542.0@codecademy/gamut@40.3.4-alpha.362542.0@codecademy/monaco@0.5.14-alpha.362542.0<EMAIL_ADDRESS>
🚀 Styleguide deploy preview ready!https://619bc9515be1173c8d1f7190--gamut-preview.netlify.appDeploy Logs

📬Published Alpha Packages:@codecademy/gamut-kit@0.6.19-alpha.56e947.0@codecademy/gamut-labs@28.0.14-alpha.56e947.0@codecademy/gamut@40.3.4-alpha.56e947.0@codecademy/monaco@0.5.14-alpha.56e947.0<EMAIL_ADDRESS>
🚀 Styleguide deploy preview ready!https://619c1d62a65ebf00c7fd1ccd--gamut-preview.netlify.appDeploy Logs

📬Published Alpha Packages:@codecademy/gamut-kit@0.6.20-alpha.5d0667.0@codecademy/gamut-labs@28.0.15-alpha.5d0667.0@codecademy/gamut@40.4.1-alpha.5d0667.0@codecademy/monaco@0.5.15-alpha.5d0667.0<EMAIL_ADDRESS>
🚀 Styleguide deploy preview ready!https://619cfb5c7fd04b16b2e7de4e--gamut-preview.netlify.appDeploy Logs

📬Published Alpha Packages:@codecademy/gamut-kit@0.6.20-alpha.07bece.0@codecademy/gamut-labs@28.0.15-alpha.07bece.0@codecademy/gamut@40.4.1-alpha.07bece.0@codecademy/monaco@0.5.15-alpha.07bece.0<EMAIL_ADDRESS>
🚀 Styleguide deploy preview ready!https://61a5120e076a764cc928e1c5--gamut-preview.netlify.appDeploy Logs

🚀 Styleguide deploy preview ready!https://61a51877632f7050a1386e07--gamut-preview.netlify.appDeploy Logs

📬Published Alpha Packages:@codecademy/gamut-kit@0.6.20-alpha.49b616.0@codecademy/gamut-labs@28.0.15-alpha.49b616.0@codecademy/gamut@40.4.1-alpha.49b616.0@codecademy/monaco@0.5.15-alpha.49b616.0<EMAIL_ADDRESS>
📬Published Alpha Packages:@codecademy/gamut-kit@0.6.20-alpha.87caaf.0@codecademy/gamut-labs@28.0.15-alpha.87caaf.0@codecademy/gamut@40.4.1-alpha.87caaf.0@codecademy/monaco@0.5.15-alpha.87caaf.0<EMAIL_ADDRESS>
🚀 Styleguide deploy preview ready!https://61a528e3076a76627c28e5b3--gamut-preview.netlify.appDeploy Logs

📬Published Alpha Packages:@codecademy/gamut-kit@0.6.22-alpha.0142f5.0@codecademy/gamut-labs@28.1.2-alpha.0142f5.0@codecademy/gamut@40.5.1-alpha.0142f5.0@codecademy/monaco@0.5.17-alpha.0142f5.0<EMAIL_ADDRESS>
🚀 Styleguide deploy preview ready!https://61a64235e1850a2d9285fe47--gamut-preview.netlify.appDeploy Logs

📬Published Alpha Packages:@codecademy/gamut-kit@0.6.24-alpha.537aef.0@codecademy/gamut-labs@28.1.4-alpha.537aef.0@codecademy/gamut@40.5.3-alpha.537aef.0@codecademy/monaco@0.5.19-alpha.537aef.0<EMAIL_ADDRESS>
🚀 Styleguide deploy preview ready!https://61a6a579a4d94b2defd0d38c--gamut-preview.netlify.appDeploy Logs

📬Published Alpha Packages:@codecademy/gamut-kit@0.6.25-alpha.41db3c.0@codecademy/gamut-labs@28.2.1-alpha.41db3c.0@codecademy/gamut@40.5.3-alpha.41db3c.0@codecademy/monaco@0.5.19-alpha.41db3c.0<EMAIL_ADDRESS>
🚀 Styleguide deploy preview ready!https://61a8ee420dbaed334133d67f--gamut-preview.netlify.appDeploy Logs

📬Published Alpha Packages:@codecademy/gamut-kit@0.6.25-alpha.511c2e.0@codecademy/gamut-labs@28.2.1-alpha.511c2e.0@codecademy/gamut@40.5.3-alpha.511c2e.0@codecademy/monaco@0.5.19-alpha.511c2e.0<EMAIL_ADDRESS>
🚀 Styleguide deploy preview ready!https://61afb186a18bce41dbf504b0--gamut-preview.netlify.appDeploy Logs

📬Published Alpha Packages:@codecademy/gamut-kit@0.6.25-alpha.572f02.0@codecademy/gamut-labs@28.2.1-alpha.572f02.0@codecademy/gamut@40.5.3-alpha.572f02.0@codecademy/monaco@0.5.19-alpha.572f02.0<EMAIL_ADDRESS>
🚀 Styleguide deploy preview ready!https://61afcccd4562c80b4c73ef0c--gamut-preview.netlify.appDeploy Logs

📬Published Alpha Packages:@codecademy/gamut-kit@0.6.26-alpha.e7a0ac.0@codecademy/gamut-labs@28.2.2-alpha.e7a0ac.0@codecademy/gamut@40.5.4-alpha.e7a0ac.0@codecademy/monaco@0.5.20-alpha.e7a0ac.0<EMAIL_ADDRESS>
📬Published Alpha Packages:@codecademy/gamut-kit@0.6.26-alpha.cda8bb.0@codecademy/gamut-labs@28.2.2-alpha.cda8bb.0@codecademy/gamut@40.5.4-alpha.cda8bb.0@codecademy/monaco@0.5.20-alpha.cda8bb.0<EMAIL_ADDRESS>
🚀 Styleguide deploy preview ready!https://61afd514d9c8dc097402adfa--gamut-preview.netlify.appDeploy Logs

📬Published Alpha Packages:@codecademy/gamut-kit@0.6.26-alpha.bef8ca.0@codecademy/gamut-labs@28.2.2-alpha.bef8ca.0@codecademy/gamut@40.5.4-alpha.bef8ca.0@codecademy/monaco@0.5.20-alpha.bef8ca.0<EMAIL_ADDRESS>
🚀 Styleguide deploy preview ready!https://61afdf6a3c942f00687ca5eb--gamut-preview.netlify.appDeploy Logs

📬Published Alpha Packages:@codecademy/gamut-kit@0.6.27-alpha.de5f37.0@codecademy/gamut-labs@28.3.1-alpha.de5f37.0@codecademy/gamut@40.5.4-alpha.de5f37.0@codecademy/monaco@0.5.20-alpha.de5f37.0<EMAIL_ADDRESS>
🚀 Styleguide deploy preview ready!https://61b10111dc5ac82d37725799--gamut-preview.netlify.appDeploy Logs


enhance support distinct field with the same name for issue #1567

What this PR does / why we need it?
enhance support distinct field with the same name for issue #1567
Summary of your change
Please indicate you've done the following:

[ ] Made sure tests are passing and test coverage is added if needed.
[ ] Made sure commit message follow the rule of Conventional Commits specification.
[ ] Considered the docs impact and opened a new docs issue or PR with docs changes if needed.

Codecov Report
Attention: 12 lines in your changes are missing coverage. Please review.

Comparison is base (bc4708b) 73.23% compared to head (e810cd9) 71.56%.

Additional details and impacted files
@@             Coverage Diff              @@
##               main    #1906      +/-   ##
============================================
- Coverage     73.23%   71.56%   -1.68%
+ Complexity    21542    20839     -703
============================================
  Files           646      634      -12
  Lines         87553    86826     -727
  Branches      19094    18897     -197
============================================
- Hits          64121    62135    -1986
- Misses        15520    16730    +1210
- Partials       7912     7961      +49

Files
Coverage Δ

.../alibaba/fastjson2/reader/ObjectReaderCreator.java
80.44% <94.28%> (+0.31%)
:arrow_up:

...java/com/alibaba/fastjson2/reader/FieldReader.java
77.69% <58.33%> (-2.46%)
:arrow_down:

... and 82 files with indirect coverage changes

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


Issue serving the HelloWorld page built by ReactGen (Windows 8.1 Command Prompt)

Hello There.
I built the HelloWorld app by navigating to %GOPATH%/src/example.com/helloworld and executing reactGen -init bootstrap.  It started with the following message:
C:\mcdev\gowork\src\example.com\helloworld>gopherjs serve
serving at http://localhost:8080 and on port 8080 of any available addresses
Then when I navigated to http://localhost:8080/example.com/helloworld/, it served a blank page with the following error showing in the browser consoled and the Command prompt:
helloworld.js:1 /src/syscall/syscall_nonlinux.go:5:18: undeclared name: SYS_EXIT
(anonymous) @ helloworld.js:1
helloworld.js:2 /src/syscall/syscall.go:53:39: too few arguments in call to Syscall
(anonymous) @ helloworld.js:2

Any thoughts?

Found this issue on the GopherJS project: https://github.com/gopherjs/gopherjs/issues/776. There's a comment about using a goos build argument. Not sure how that translates when we're using ReactGen...

I think this is more of an issue with gopherjs on Windows than myitcv.io/react. I will try and find some time to try this out on Windows and add an AppVeyor CI build for this project.

We can make a PowerShell file like this
`$env:GOOS = "darwin"
$exe = 'your directory to gopherjs.exe'
& $exe serve`
tempory change GOOS for this session


Obtaining contact forces from torques for a given joint-space configuration

Hi,
Desciption
I am trying to determine the maximum contact forces at the end-effectors from peak torque values for the nominal joint-space configuration. At least one of the x, y, z components of the forces is an order of magnitude higher than expected. I hope you can identify the flaw in my approach which uses the relationship below (it assumes J is a square matrix) to compute the force vector:
tau = J^T * F
inv(J^T)*tau = F

Attempt
Here is what I have attempted:
I load a floating-base quadruped from a URDF:
model    = pin.buildModelFromUrdf(urdf_path, pin.JointModelFreeFlyer())
data     = model.createData()

I provide q0, the nominal state vector (19x1) with the base at {x, y, z, qx, qy, qz, qw} = {0, 0, 0, 0, 0, 0, 1} (this puts the base frame at the world frame), and the joint angles ordered {LF LH RF RH}. Hence, I obtain the LF_FOOT body Jacobian (6x18) w.r.t. WORLD:
j_full = pin.computeFrameJacobian(model, data, q0, model.getFrameId("LF_FOOT"), pin.ReferenceFrame.WORLD);

I extract the square part of the Jacobian corresponding to LF_FOOT (3x3):
j = j_full[0:3, 6:9]

Finally, I compute f, the force vector (3x1):
jt = j.transpose()
f = pinv(jt).dot(tau)

Question
Is this the correct use of computeFrameJacobian()? Should I be using something else?

You want to extract the contact forces expressed at the LF_FOOT level.
For this case, the reference frame you provide is not the correct one, meaning that WORLD refers to the origin of the world as if it was attached to the LF_FOOT frame.
In your case, you should rather use LOCAL_WORLD_ALIGNED convention, which corresponds to the Frame cenetred on the LF_FOOT frame but with axes aligned with the WORLD axes.

Thank you @jcarpent for a very prompt reply. The number make much more sense after changing the reference frame to LOCAL_WORLD_ALIGNED!


Remove unused declaration

Commit 0fd0c7b801923d2790f0e767315d7202c372d0e6 moved where
MultipleJGitEnvironmentRepositoryFactory is instantiated from
DefaultRepositoryConfiguration.defaultEnvironmentRepository() to EnvironmentRepositoryConfiguration.JGitFactoryConfig.gitEnvironmentRepositoryFactory()
but forgot to remove the fields.

Codecov Report

Merging #1271 into master will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##             master    #1271   +/-   ##
=========================================
  Coverage     79.47%   79.47%
  Complexity      993      993
=========================================
  Files           117      117
  Lines          3528     3528
  Branches        490      490
=========================================
  Hits           2804     2804
  Misses          549      549
  Partials        175      175

Impacted Files
Coverage Δ
Complexity Δ

...ver/config/EnvironmentRepositoryConfiguration.java
85.36% <ø> (ø)
3 <0> (ø)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2e606de...fcbb16d. Read the comment docs.

Codecov Report

Merging #1271 into master will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##             master    #1271   +/-   ##
=========================================
  Coverage     79.47%   79.47%
  Complexity      993      993
=========================================
  Files           117      117
  Lines          3528     3528
  Branches        490      490
=========================================
  Hits           2804     2804
  Misses          549      549
  Partials        175      175

Impacted Files
Coverage Δ
Complexity Δ

...ver/config/EnvironmentRepositoryConfiguration.java
85.36% <ø> (ø)
3 <0> (ø)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2e606de...fcbb16d. Read the comment docs.


entry.previous_in/next_in should allow better filtering

Expected Behavior
The previous_in/next_in functionality on entry template objects should also allow for filtering based on entry type.
Current Behavior
Currently it can only filter on category, which means things like sidebar links etc. can't be excluded from a flow.
Possible Solution
Suggestion: add the entry_type and entry_type_not query generators into the queries utility class to make this functionality a bit more commonizable.

Did one better and added CallableProxy and centralized query generation.


fix(versions): update Activiti/activiti-cloud-full-chart-security versions

UpdateBot pushed helm dependency: activiti-cloud-full-example to: 7.1.300

UpdateBot commands:
updatebot push-version --kind helm activiti-cloud-full-example 7.1.300


help disabling header insertion for clangd

Hello,
I m trying to disable the auto header insertion for the clangd lsp in lazyvim.
I have managed to disable the autoformat already and this works.. but
I m unable to disable the header insertion
From this link here I understand that
clangd can be invoked with --header-insertion=never flag to disable the feature.
I setup a file lsp.lua in my ~/.config/nvim/lua/plugins folder to do the same.
The contents of the file are as follows.
return {
  "neovim/nvim-lspconfig",
  opts = {
    autoformat = false,
    setup = {
      clangd = function(_,opts)
      opts.cmd = {"clangd", "--header-insertion=never"}
      end,
    },
  },
}

I have tried with both the "never" and "iwyu" value but neither seem to work.
I have saved the file and restarted the lsp server but the header insertion still continues.
I was hoping that someone more knowledgeable than me can help me with this.
My clangd version is 15.0.7 for reference..
Thanks in advance kind people! :-)

Never mind :facepalm:
restarting neovim fixed the issue.
Somehow restarting the lsp server from within did not work.. but restarting neovim worked..
:shrug:
I m closing the issue now..


Reinstate CCR on stage

https://github.com/wellcomecollection/catalogue-api/pull/142 should have fixed performance issues with the new cluster.
This change points stage once again at the new cluster in preparation for load testing.

Towards https://github.com/wellcomecollection/catalogue-api/pull/111


Random Transform?

Hi, thanks for the demo project, it makes me more clear about how to play with RichTextEffect, really cool. Playing a while, I'm curious about is it possible to apply a random number for each character offset for just one time? It always changing like shaking all the time when I trying to do this. And also, how do you get a random character from a line?
Example like

Things shake if you use random numbers because _process_custom_fx runs continuously.
You can't really get a random character from a line because the function runs constantly. You could generate something pseudorandom and use an if statement to check if char_fx.absolute_position == value.
I took a shot at your static shaken effect. What do you think?


Tox py350 runs python3.6.x

On my system and I think in general, tox runs whatever 3.x version of python you have if the version you have is not 3.5.
When I change py350 to py35, it properly fails with an InterpreterNotFound. Is py350 even a thing?  I looked in the tox docs and all I could see was {py27,...,py33,py34,py35,py36} nowhere I see definition with a trailing zero.
There  is also this issue.
Talking about installing python3.5 yourself because tox doen not install it for you.

Could you provide an example project (if you have one)?

Excuse me, an example project containing what exactly? I'm not a tox expert, I noticed this because I have 3.6.x on my system, I then was curious if it really installed 3.5, because it ran really fast. I printed the python version in the test file and I could see a 2.x and a 3.6.x (which is the version on my system) where it should have been a 3.5. When changint the py350 to py35 in the tox config, it nicely triggered an error.

I asked, because i dont see the connection to the python codacy coverage uploader.

The connection is that this project uses tox, to run tests for python2.7 and python3.5. It uses circleCi to run those tests. But I say the tests for python3.5 are false positives, because on my system the tests fail for python3.x. And on inspection I see that py350 is not even ensuring that python 3.5 is being used, but is falsely uses whatver python3 is on my PATH.

I tested something and you were right, py350 do something but not the correct/expected? thing, as you can see below the py350 section it still uses Python 2.7
I set up a test branch with correct values and got the expected fail:
Tox.ini
CircleCI command
CircleCi log

@dhensen @IceflowRE any progress on this? Closing this for now. If any new information appear I will re-open it.


Bugfix/remove failed txs

Remove failed transactions from tx pool (during block creation)
Update log messages and levels
Update deploy_gcp.sh to kill all processes at the beginning

Thanks for the review. Now merging..


Outline Manager crash

Outline Manager does not generate an access key after adding the server, dame..

Hi there,
We're closing this issue due to inactivity. We apologize if we never had a chance to respond to your original inquiry.
If you're still experiencing problems or have any further questions, please feel free to reopen this issue or create a new one.
Thank you for your understanding!


Expose monit admin user as env var

We need the admin user in the galera bootstrap job.
The currently used "admin" user does not have permissions to restart the mysql process.

Stale; closing.


Enhance visual grouping capabilities when supporting different API versions

Having multi-version API I want to have a good and simple solution to allow multiple-version documentation but I don't want my groups being affected by the basePath neither the version bit of it.
API consumes are also required to supply Accept header like application/vnd.mysuperapi.v2+json. Internally end-points evolve over time and routing is like:
GET /api/v1/customers/ - this version will be supported for months.
GET /api/v1/customers/{guid} - this version will be supported for
months.
GET /api/v2/customers/{guid}
...
Each route can this way have it's own validation and documentation. We don't want to clutter the documentation with the version fragments. On this example when viewing documentation for v2 the user will see a list operation that is the same since v1 and the new detail operation from v2.
When a request arrives to the API based on the Accept header version information the proper route path is set.

Coverage remained the same at 100.0% when pulling a25eca1530961096bae1bd4bc0aa72150769c410 on ruionwriting:master into 4fdd0c90af028811c7bb3b71b75ff4777310543f on glennjones:master.

Coverage remained the same at 100.0% when pulling 83be5e85ef18180fca5e966b82262b6f94faeccc on ruionwriting:master into 4fdd0c90af028811c7bb3b71b75ff4777310543f on glennjones:master.

@glennjones had you had a chance to take a look to this pull request?

Coverage remained the same at 100.0% when pulling 1d62779964a0ea10faec14ce6a835f192676401c on ruionwriting:master into 6cc2860587d435126eb0e2e4a6c111ac536f9b4f on glennjones:master.

Coverage remained the same at 100.0% when pulling 46aa5a7dfac1d917301d0bd5cffcfc51b8fea61d on ruionwriting:master into ebbc126404ebc15e0cc90274773168c0c9ae5368 on glennjones:master.


Production rcpxw should have recap_edd:false

Reviewing with @kevinreiss the locations from https://github.com/pulibrary/bibdata/pull/1503/files
we show that rcpxw that chnages to rare$xw should have recap_edd:false.
@kevinreiss updated this in bibdata production

this is done


[bug] drop new spacer when group is hidden

When the spacers group element is hidden, both with toggle spacers or when the selected group is none, if the user drops a new spacer in the page is placed with top and left values too big.

Possibile solution is to avoid the ability to drop new spacers when spacers group element is hidden.

Bug solved implementing 2 new features:

when toggle spacers is off, will hide also the spacer clonable
when none group is selected, dragging a new spacer will create a new group


Copy and paste breaks intermittently in Python Interactive Window

Bug: Interactive Window, Editor cells
The issue regarding double copy-pasting in the Python Interactive Window (PIW) from 1.47 / 1.47.1 seems to have been 'resolved' with the update to 1.47.2, however it has been replaced by a new problem.
The PIW does not "play nice" witheither copying or pasting now.
Steps to cause the bug to occur

type text "aa" into editor window.
copy text "aa" from editor window.
paste text "aa" into editor window.
paste text "aa" into PIW.
clear text (backspace x2) from PIW.
type text "bb" into PIW.
select and copy text "bb" from PIW.
go to end of line in PIW, newline and paste text "bb" into PIW.
paste text "bb" into editor window

Actual behavior
Editor window:

displays aa
displays
aa
aa
displays
aa
aa
aa

PIW:
4. displays aa
6. displays bb
8. displays
bb
aa
Expected behavior
Editor window:

displays aa
displays
aa
aa
displays
aa
aa
bb

PIW:
4. displays aa
6. displays bb
8. displays
bb
bb
Jupyter and/or Python environment

Jupyter server running: Local
Extension version: v2020.7.94776
VS Code version: 1.47.2
Setting python.jediEnabled: NA

python.languageServer instead

Setting python.languageServer: Jedi
**Python and/or Anaconda version: 3.7.4
OS: Windows
Virtual environment:  virtualenv

Developer Tools Console Output
Console output:
TMScopeRegistry.ts:45 Overwriting grammar scope name to file mapping for scope source.yaml.
Old grammar file: file:///c%3A/Users/user/AppData/Local/Programs/Microsoft%20VS%20Code/resources/app/extensions/yaml/syntaxes/yaml.tmLanguage.json.
  Falling back to loading web worker code in main thread, which might cause UI freezes. Please see https://github.com/Microsoft/monaco-editor#faq
webviewElement.ts:160 [Embedded Page] Failed to construct 'Worker': Script at 'vscode-webview-resource://30687aa5-a0bd-4067-8d4e-5a754bbaaba2/file///d%3A/fullpathremoved/editor.worker.js' cannot be accessed from origin 'vscode-webview://30687aa5-a0bd-4067-8d4e-5a754bbaaba2'.
console.ts:137 [Extension Host] Starting WebSocket: RAW/api/kernels/d2ff09f2-31ce-4320-98f2-bfe8357e3642
console.ts:137 [Extension Host] Kernel: connected (d2ff09f2-31ce-4320-98f2-bfe8357e3642)
Microsoft Data Science for VS Code Engineering Team: @rchiodo, @IanMatthewHuff, @DavidKutu, @DonJayamanne, @greazer, @joyceerhl

Hi @JPIvan , I am unable repro at this time given the instructions you have provided.
Could you post a gif recording?

I'm experiencing the same issue after the latest update.

Me too!

Dupe of #13016

@greazer This does not seem to be a dup of #13016 , but indeed of the bug that I reported #13042. This seems to do with the window group focus (please note my workaround), and while it might be related, the functionality involved and side-effects are not similar to the upstream bug https://github.com/microsoft/vscode/issues/103200 mentioned in #13016. I would vote to re-open.


empty result means no fixed point

if the f set is empty, then we never fixed point...seems counterintuitive

this was never true


Convert .tbx tools to .pyt: Distance and Direction

Issue https://github.com/Esri/military-tools-geoprocessing-toolbox/issues/262 has been broken down into toolsets. The Distance and direction tools are:

[X] RangeRingsFromInterval - #268
[X] RangeRingFromMinimumAndMaximum - #268
[X] RangeRingsFromMinAndMaxTable - #268

Acceptance Criteria:
Target release: Military Tools 3.0
Pro 2.1 and 2.2
One toolbox
Tests written and running for tools
Toolset included in the toolbox in the .zip
Tools documented
Tools tested
User documentation complete and published

Jenkins Unit tests now run.
Staging location for tests:
http://dev0002292:8080/job/GP Unit tests/
Tests are currently running against the master branch.  I have also run these tests against the dev branches of the https://github.com/Esri/military-tools-geoprocessing-toolbox repo.
Both these branches fail:
Broken Unit tests ArcMap:
Master branch
http://dev0002292:8080/job/GP Unit tests/job/ArcMap Test Runner/7/console
Dev Branch
http://dev0002292:8080/job/GP Unit tests/job/ArcMap Test Runner/5/console
Broken Unit tests ArcGIS Pro:
Master branch
http://dev0002292:8080/job/GP Unit tests/job/ArcGIS Pro Test Runner/2/console
Dev Branch
http://dev0002292:8080/job/GP Unit tests/job/ArcGIS Pro Test Runner/1/console
FYI @csmoore

Tool help migrated to the PYT tools in this PR:
https://github.com/Esri/military-tools-geoprocessing-toolbox/pull/281

Updated What's New an Military Tools home page in GitHub to indicate conversion to PYT format, in PR https://github.com/ArcGIS/arcgis-solutions-website/pull/6431

Verified TestRunner.py imports and runs Distance and Direction test suite:
http://dev0002292:8080/job/GP Unit tests/job/ArcMap Test Runner/14/console

@ACueva - I'm not able to reproduce the unit test error above with my Pro 2.1 and the latest test suite - we may need to debug on that machine if the problem persists.
INFO: 2018-05-09 09:28:50,823 ------------ Begin Tests ------------------
INFO: 2018-05-09 09:28:50,837 Platform: Windows-10-10.0.16299-SP0
INFO: 2018-05-09 09:28:50,837 Python Version 3.6.2 |Continuum Analytics, Inc.| (default, Jul 20 2017, 12:30:02) [MSC v.1900 64 bit (AMD64)]
INFO: 2018-05-09 09:28:50,840 Product: ArcGISPro, Version: 2.1, Installed on: 1/8/2018, Build: 10257.
INFO: 2018-05-09 09:28:50,840 -------------------------------------------

...

INFO: 2018-05-09 09:46:42,438 Test success: True
INFO: 2018-05-09 09:46:42,439
RESULTS =================================================
Number of tests run: 86
Number succeeded: 86
Number of errors: 0
Number of failures: 0
Number of tests skipped: 0
Percent passing: 100.0
=========================================================

Issue with Pro 2.1 toolbox failing was a result of the branch being used.  Changed all unit tests to run against the Dev branch of the Esri/MTGPToolbox repo.
INFO: 2018-05-10 14:02:34,560
RESULTS =================================================
Number of tests run: 86
Number succeeded: 86
Number of errors: 0
Number of failures: 0
Number of tests skipped: 0
Percent passing: 100.0
=========================================================

INFO: 2018-05-10 14:02:34,561 END OF TEST =========================================

Ran through Checklist test, no functional changes were needed: https://github.com/ArcGIS/solutions-defense-test-catalog/blob/master/Tests/Gridded-Reference-Graphic_ArcMap-ArcGIS-Pro.md

GP checklist created.  Ready for review. https://github.com/ArcGIS/solutions-defense-test-catalog/pull/133
FYI @BobBooth @dfoll @topowright

Removing G - QC Checklist (Verify) .... verified the checklist exists, and verified that the tools pass the steps in the checklist. No other labels remain, so I am moving this to done

Changes made to Checklist test per https://github.com/ArcGIS/solutions-defense-test-catalog/pull/133

The FeatureSet inputs are definitely broken for these 3 tools in the pyt: the problem is with the input schema layer: toolboxes\layers\RangeRingInputObserversGDB.lyr - this layer needs to be recreated. @BobBooth and I learned as part of this process that only the Save-To-Layer GP tool creates the layer with the necessary relative paths to make the lyr file portable (lyrs that point to a live GDB is a new requirement of the pyt)


Nancy.Serilog- nuget - Read Request.Files - Stream it cause: Cannot access a closed file.

Prerequisites

[x] I have written a descriptive issue title
[x] I have verified that I am running the latest version of Nancy
[x] I have verified if the problem exist in both DEBUG and RELEASE mode
[x] I have searched open and closed issues to ensure it has not already been reported

Description
https://github.com/Zaid-Ajaj/Nancy.Serilog/issues/2
Steps to Reproduce
After i install this nuget into my project and activate serilog, i spent few hours to find what cause
Cannot access a closed file. when i try to access Request.Files and read archive Stream.
System Configuration
ASP.MVC -framework 4.5

Nancy version:
Nancy host

[ ] Nancy.Hosting.Aspnet
[ ] Nancy.Hosting.Self
[x] Nancy.Owin (IIS)
[ ] Other:

Other Nancy packages and versions:
Environment (Operating system, version and so on):
.NET Framework version:
Additional information:

Can you post the code? I'm pretty certain something is being closed/disposed too early. Are you reading it on another thread? Or did you forget to await something inside a using block?

I will post sample app

This is demo app: DemoNancySerilog.zip
You can start in debug mode and put breakpoint  in HomeModule.cs on line 26 file.Value.CopyTo(output);
And using powershell you can run build.ps1 from project directory using cake build or you can try to post some files to http://localhost:60628/sync.

Can you push it to a GitHub repo. I can't/won't downlad a random zip-file from mediafire.com 😝

I publish this demo project to this repo: https://github.com/totpero/DemoNancySerilog

Hmm. There doesn't appear to be anything wrong with your code, but there's several posts out there suggesting that this is related to ASP.NET request size limits and big files. Are you getting this error no matter how big the files are? What if you try to write to a different file every time? I could imagine there being concurrency issues when you have multiple requests coming in trying to write to the same file.

No matter the file size or the save location path of the file. In my real problem I try to get this file stream and unzip it into the memory an process it and if you try you get the same error. You can test this scenario if you run bulid.ps1 from PowerShell. If you uninstall serilog nancy nuget you will see that the problem will be fixed. I have also opened one issue on nancy serilog repo.

Hi,
I update the repo, get last version and try the next steps:

Build the last project version;
Now you have two project (nancy web server with this nuget and console app that make WebClient UploadFile);
Run nancy web project (DemoNancySerilog) in debug mode;
In the same time go to DemoNancySerilog.Console\bin\Debug and run DemoNancySerilog.Console.exe
In the same folder with DemoNancySerilog.Console.exe app you will have "test.zip" file;
You will get Cannot access a closed file error:

My investigation result:

If you try to upload file using curl or powershell you don't get this error;
If you try to upload small file you don't get this error;
If you uninstall Nancy.Serilog nuget you don't get this error even if you have large file or upload using curl;

I hope this help you.

See my comment here
@khellang Does reading the request stream like the following, make the stream unreadable again?
var inputStream = nancyContext.Request.Body;
using (var streamReader = new StreamReader(inputStream))
{
        var content = streamReader.ReadToEnd();
        // rewind stream to make it readable again from a Nancy module
        inputStream.Position = 0;
        return content;
}

I don't think it should. The stream is buffered, so as long as you rewind it, it should be fine. Not sure if the multipart handling for files does anything funky here.

I am not sure either but for the issue I actually was able to reproduce the error, it is very strange, seems only to occur when using WebClient to upload the file (uploading with curl works fine) and the request body stream has been read by a stream reader from the function above. As a "fix" I disabled automatic logging of request body data if a file exists in the request because it doesn't make sense to read the files textually by default.

As a "fix" I disabled automatic logging of request body data if a file exists in the request because it doesn't make sense to read the files textually by default.

Yeah, that's probably a good default anyway. I'm not sure if there's anything to do in Nancy on this issue?

Original issue is fixed, this can be closed :smile:

Thanks @Zaid-Ajaj! ❤


(Microsoft.Extensions.Logging) Capturing objects

Hi!
This is both a question and feature request for the Microsoft.Extensions.Logging:
As of now is it possible to log class objects like Serilog do where the they serilize the data?
Serilog:
Log.Debug("Received {@Request}", request);
// -> Received PublishRequest { PageId: "widget-2000", PublishAt: 08/31/2016 00:45:59 }
MS Logger:
// -> Received PublishRequest Models.PublishRequest
Thanks

Closing, as the question has been answered (thanks @poke!). Feel free to comment further if you need us to elaborate on the answer!


Testcafe promise bug

What is your Test Scenario?

Test an application doing HTTP requests using ky-universal.
What is the Current behavior?

Testcafe crashes on what seems to be cloning of a promise.
What is the Expected behavior?

Testcafe should not crash.

Steps to Reproduce:

➜ git clone --branch testcafe-bug git@github.com:Meemaw/Insight.git testcafe-ky-bug
➜ cd testcafe-ky-bug
➜ npx lerna bootstrap
➜ cd frontend/app
➜ yarn build
➜ yarn start # If you go to http://localhost:3000/testcafe-bug you should see list of "comments" being rendered

In a new terminal (make sure you are inside the frontend/app folder):
➜ yarn testcafe chrome e2e/specs -f '<TestcafeBug />' # if you open dev tools, you should see the error in the console and nothing and white screen

I'm fairly sure you can reproduce this in any setup.
Your Environment details:

testcafe version:                   1.8.2
node.js version:                    v10.16.0
platform and version:         macOS 10.14.6

I've tried to download your sample but my attempts were unsuccessful. How can we access it?
git clone --branch testcafe-bug git@github.com:Meemaw/Insight.git testcafe-ky-bug
Cloning into 'testcafe-ky-bug'...
The authenticity of host 'github.com (<IP_ADDRESS>)' can't be established.
RSA key fingerprint is SHA256:nThbg6kXUpJWGl7E1IGOCspRomTxdCARLviKw6E5SY8.
Are you sure you want to continue connecting (yes/no)? y
Please type 'yes' or 'no': yes
Warning: Permanently added 'github.com,<IP_ADDRESS>' (RSA) to the list of known hosts.
Permission denied (publickey).
fatal: Could not read from remote repository.
Please make sure you have the correct access rights
and the repository exists.

Can you try cloning using the HTTP(S), e.g.:
➜ git clone --branch testcafe-bug https://github.com/Meemaw/Insight.git testcafe-ky-bug

Hi @Meemaw,
I successfully cloned the repo and managed to start the application. Yet, now I get the following error when trying to launch tests:
ERROR Cannot load a client script from ../../node_nodules/@testing-library/dom/d
<EMAIL_ADDRESS>

@alexey-lin, @AlexSkorkin I've created a new repo for this and updated the "Steps to reproduce" for a much much easier setup.

I've debugged this issue. It's caused by the fact that Hammerhead incorrectly processes the following piece of your code:
window["%hammerhead%"].processScript(
    'async function f() { result[type] = (await result).clone(); }')

// actual
// async function f() {  __set$(result,type,await (result).clone()); }
// expected
// async function f() {  __set$(result,type,(await result).clone()); }


Issue 41 - main.defaultGpkg() test coverage - take 2!

From #41 and based on a non-malfunctioning branch this time. 👍

OK, all done @JivanAmara 👍

@jlucktay All tests passing?

@jlucktay ping, tests passing?

They were passing when I last committed, but now there is a problem in the data_provider package with geom.Extent.

All sorted. Passing on MacOS and Windows both!

Great, will merge.  Appreciate your help, if you've got more time & interest I'd love to have you take on another piece :-)


Prepare for Jandex 2

Windows Build 2026 is now running using a merge of 2029ee4566c817b0d0a7fd48fae5b5541fad426a

Linux Build 6956 is now running using a merge of 2029ee4566c817b0d0a7fd48fae5b5541fad426a

Linux with security manager Build 1850 is now running using a merge of 2029ee4566c817b0d0a7fd48fae5b5541fad426a

Linux with security manager Build 1850 outcome was SUCCESS using a merge of 2029ee4566c817b0d0a7fd48fae5b5541fad426a
Summary: Tests passed: 871, ignored: 280 Build time: 0:06:13

Linux Build 6956 outcome was SUCCESS using a merge of 2029ee4566c817b0d0a7fd48fae5b5541fad426a
Summary: Tests passed: 2918, ignored: 341 Build time: 0:48:13

Windows Build 2026 outcome was SUCCESS using a merge of 2029ee4566c817b0d0a7fd48fae5b5541fad426a
Summary: Tests passed: 2918, ignored: 341 Build time: 0:49:10


[Internet Computer] Add Internet Computer (ICP) Chain

Description
Adds support for the Internet Computer chain.
How to test
Run C++, Rust, iOS, Android, JS tests
Types of changes

New feature (non-breaking change which adds functionality)

Checklist

[x] Create pull request as draft initially, unless its complete.
[x] Add tests to cover changes as needed.
[x] Update documentation as needed.
[x] If there is a related Issue, mention it in the description.

If you're adding a new blockchain

[x] I have read the guidelines for adding a new blockchain.

@Milerius could you take a look so we can merge the PR?

@dfinity-ryancroote could you fix Clippy warnings and the following tests? Android: blockchains.internetcomputer.TestInternetComputerSigner Kotlin: wallet-core/kotlin/wallet-core-kotlin/src/commonTest/kotlin/com/trustwallet/core/test/CoinAddressDerivationTests.kt:28:62

I have pushed fixes for the above items.


Memory leaking wile using ngu-carousel

The problem is when I use ngu-carousel with data that is constantly changing.
After a while the app and the whole browser is stucked. It seems like the ngu-carousel stores all the data inside and it's crashing the app.

Duplicate of #104

@sarnecki-cic Thanks for reporting fixed this issue and will push the update. Thanks

@sarnecki-cic This isssue is fixed. Please check release.
Thanks


Add dedicated feature flag for breakdown_metrics

[x] Implement code
[x] Add tests
[x] Update documentation

run the tests

Codecov Report

Merging #743 into master will decrease coverage by 0.51%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##             master     #743      +/-   ##
============================================
- Coverage     64.79%   64.28%   -0.52%
+ Complexity      169       68     -101
============================================
  Files           209      209
  Lines          8925     8705     -220
  Branches       1147     1101      -46
============================================
- Hits           5783     5596     -187
+ Misses         2788     2767      -21
+ Partials        354      342      -12

Impacted Files
Coverage Δ
Complexity Δ

...apm/agent/impl/transaction/TraceContextHolder.java
53.19% <0%> (-5.15%)
0% <0%> (-2%)

...nt/configuration/ApmServerConfigurationSource.java
90% <0%> (-2.86%)
0% <0%> (ø)

...va/co/elastic/apm/agent/impl/ElasticApmTracer.java
74.05% <0%> (-1.7%)
0% <0%> (-33%)

...astic/apm/agent/impl/transaction/TraceContext.java
90.25% <0%> (-1.03%)
0% <0%> (-19%)

...tic/apm/agent/configuration/CoreConfiguration.java
96.46% <0%> (-0.49%)
0% <0%> (ø)

...lastic/apm/agent/impl/transaction/Transaction.java
84.29% <0%> (-0.41%)
0% <0%> (-25%)

...lastic/apm/agent/report/ReporterConfiguration.java
100% <0%> (ø)
0% <0%> (ø)
:arrow_down:

...agent/impl/stacktrace/StacktraceConfiguration.java
100% <0%> (ø)
0% <0%> (-3%)
:arrow_down:

...ic/apm/agent/slf4j/Slf4JMdcActivationListener.java
89.13% <0%> (+0.24%)
0% <0%> (-7%)
:arrow_down:

...lastic/apm/agent/logging/LoggingConfiguration.java
92.3% <0%> (+0.74%)
0% <0%> (-12%)
:arrow_down:

... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 01400f2...7d1a6bd. Read the comment docs.


Automate update of the homebrew-tap on release

Automate the update of the helm-templexer formular in https://github.com/hendrikmaus/homebrew-tap on release

This could be useful to get started: https://github.com/marketplace/actions/bump-homebrew-formula


Re-organize using a proc-macro to support more devices

Summary
This is a continuation an continuation of the work I did in #716 and #719. It uses the same basic approach as #719, but I changed the macros in response to the feedback I got on that PR.
Since this is quite a large PR, I have split it up by commits, to make it easier to review.
A quick overview of what this PR contains:

It adds a new proc-macro crate, which replaces all of the many-many features in the Cargo.toml
The primary macro of that crate is #[hal_cfg()], but it also contains a helper macro to allow using #[hal_cfg()] in more places, along with two specialized macros for creating conditional docstrings and conditional modules.
A lot of doc-comments are currently conditional depending on feature flags. This PR removes most of these, as they cannot easily be supported by the new proc-macro.
A lot of functionality were split up first by architecture in the thumbv6m and thumbv7em directories, and then by peripheral. This PR moves these files, so they are organized first by peripheral and then by architecture.
The code for reset_cause, serial_number and watchdog were sufficiently similar that I decided to merge the implementations.
It does not create a workspace, since I got weird crate unification errors when I did.

This PR also includes a change in sercom/pad/impl_pad_thumbv6m.rs should arguably be split into a separate PR.  The is that while converting the pad_table, I found a mistake in the table and did not feel like carrying that mistake over.
However I wanted to review the rest of the table for mistakes as well, which I found almost impossible to do unless I split up the tables by datasheet.
If you want me to split out this change in a separate PR, please let me know whether you prefer me to carry over the bug in the conversion, or if you prefer to fix the bug before merging this PR.
Checklist

[x] CHANGELOG.md for the BSP or HAL updated
[x] All new or modified code is well documented, especially public items
[x] No new warnings or clippy suggestions have been introduced - CI will deny clippy warnings by default! You may #[allow] certain lints where reasonable, but ideally justify those with a short comment.

Nope it sounds good to me, I kinda like splitting the tables, it makes them more straightforward to understand. Anything else you want to review/discuss before we merge this?

I'm good with merging now. As I said I haven't done any automated backwards compatible testing.
I don't know when I'll have time to do so either, so if you want that done before merging I'd love some help.

Well, we rarely release patch updates anyway, so the next release will likely be a minor anyways, with no expectation of backwards compatibility. LGTM, thanks for the hard work!


add sentence splitter functions

Adds sentence splitter functions as well as function to remove newlines. I think we should remove the newlines after adding them as the process can be imperfect and a whitespace at the wrong place is more natural than a newline.
for the wiki-rest datasets the steps should be:

add newlines with sentence splitter
line deduplication
remove newlines

@thomasw21 should we add this to your scripts that creates the filters for each dataset programmatically? The rule would be: add the three steps above to all datasets where the dataset name contains wiki but not wikipedia.

Concerning num_proc>1 with stanza: it seems to just freeze.

Hum we should fix that ...


Fix a crash on engraving a beam including invisible notes

This PR fixes another case of a crash with invisible notes (see also #311). If a beam includes invisible notes or fully consists of invisible notes then a crash happens because the engraver assumes that a beam always contains at least one visible note. This PR makes the engraver skip invisible staff objects passed to it and explicitly check that there are visible notes which can be used to engrave the beam. m_numNotes counter is reset later by the beam engraving algorithm so it should be fine to reuse it for this purpose.
Also this PR includes changes to properly delete the engraver if the last shape it produces is nullptr. Actually it would probably be even better if the EngraverMap would be responsible for deleting the engravers stored in it but this is probably something that doesn't belong to the scope of this PR.
An example score for this crash: lomse_beam_invisible_note_crash.musicxml.txt

Thank you very much. I review this as soon as possible.

I'm having problems to understand the use cases for invisible notes. Until now I thought they were only used for playback, as explained in my comments in PR#311. But the tests scores attached to this PR and to PR#311 does not seem to be oriented to playback effects. For playback, I do not see the need to include beams in invisible notes. Also I do not see the idea behind mixing visible and invisible notes in a beam or in a tuplet. This is not for playback but for something different, perhaps an app displaying the invisible notes as an question mark symbol and use it for aural training exercises in which the student must identify the played note.
Did you find in internet MusicXML scores containing such awkward constructions? Any idea about the scores origin or purpose?

The PR does its work and no problems detected, so I merge it. But I would like to have clear ideas about invisible notes. I have checked that MuseScore renders them with grey notheads, and for printing, it prints the beam but not the noteheads. It would be nice to check what Lylipond, Finale and  others do with this score and with the one in PR#311.

Actually it would probably be even better if the EngraverMap would be responsible for deleting the engravers stored in it

Yes, but there are so many things to do !

But the tests scores attached to this PR and to PR#311 does not seem to be oriented to playback effects.

Yes, those are just artificial examples I have prepared to get minimal examples of the issues. The original score where I have encountered this crash is Over_the_Top_Constellations.zip (originally downloaded from here). This score contains multiple places which look like this (invisible notes are grayed out):

Here visible notes have playback turned off (which doesn't seem to be reflected in the MusicXML file though) and invisible notes are what is being played here. The intention is apparently to tweak playback of those grace notes to make them sound a bit earlier and take a time from the previous note rather than from the current one. Here beams are also marked invisible, but MusicXML doesn't have print-object attribute for all objects (although here it can be concluded that the beams are invisible since all their notes are also invisible).
There are also examples of ties to invisible notes, also for playback purposes (and also producing a crash). I don't think I have real-world examples of beams connecting both visible and invisible notes (but I have an occasional example of this with the tuplet crash, in some tablature score where that note is tied and should indeed not be displayed). Still this is a possible situation and it is better to be able to deal with it without crashing. That is why I am trying to fix all such cases that I happen to encounter. Perhaps some of these crashes are better to fix at the MusicXML importer level though as there are cases that indeed do not make much sense to support in the engraving code.

Thank you. Now I understand the use of beams in invisible notes for playback.
But still don't have clear ideas about what Lomse should do with invisible notes. Perhaps a global option to render or not invisible notes should be the most appropriate approach, for supporting different applications. For edition apps. such as MuseScore, probably they would like to see the invisible notes rendered, perhaps in a different color (grey?), so that the user can edit those notes. But for printing or other uses, the invisible notes and their related notations (beams, tuplets, etc.) must not be rendered unless also shared with visible notes. I will continue thinking on this but ideas are always welcome!

Still this is a possible situation and it is better to be able to deal with it without crashing.

Yes, totally agree.

Perhaps some of these crashes are better to fix at the MusicXML importer level ...

From my previous comment, for now Lomse should take the safest approach. And if a global option is finally implemented, Lomse will need to import those invisible notes and related notation.

Some applications may need both to display or to hide invisible notes depending on the context, so probably that option should better be changeable at runtime, perhaps on a per-document basis. Editor apps will definitely need both: MuseScore, for example, displays visible notes when editing a score but has a per-document option to hide invisible elements and always hides them when printing a score or exporting it to PDF or any image format. Other than that, I don't think there are many options on what to do with invisible objects: they can either be displayed or not, or perhaps they can be ignored on import if that makes sense for any application. What can make implementation of such option non-trivial is the question of whether invisible elements should affect layout of visible ones or not. For visual editors the most reasonable answer is probably not, but then it somehow needs to be ensured that invisible notes do not affect horizontal spacing of subsequent notes, vertical spacing of object placed above or below staff etc. However perhaps in some other situations a simpler approach could also be useful with laying out both visible and invisible objects in a usual way. So globally there are probably not so many choices here but finer details may depend on what will this feature be targeted for.

Thank you. I totally agree with your comments. A global option modifiable at run time, per document, looks as the best approach.
The question of how invisible notes, when displayed, should affect horizontal and vertical spacing is really difficult to answer without more information about use case scenarios. The solution of treating them as normal notes is simple: just to generate a note shape instead of an invisible shape, but could produce unexpected results if that is not the idea behind using the invisible notes. But the option of displaying them without affecting spacing looks complex. I will try to gather more information on invisible notes and use case scenarios before deciding.


Example for usage of sendEvent

Hi,
we use V1.2.1.
and get:
[error]: event.getHeader is not a function
when we try to use
const resyncExt = (domainName, extNumber, callback) => {
    let eventCommand = "Event-Name: NOTIFY\n";
    eventCommand += "profile: internal\n";
    eventCommand += "content-type: application/simple-message-summary\n";
    eventCommand += "event-string: check-sync;reboot=false\n";
    eventCommand += "user: " + extNumber + "\n";
    eventCommand += "host: " + domainName + "\n";

    freeSwitchConn.sendEvent(eventCommand, (res) => {
        if(res.body.substr(0,1) === "+")
            callback(true);
        else
            callback(false);
    });
};

We found no example how to use it. So the above is only a guess.
Can you tell us how to use it right?
Best regards

sendEvent takes an Event object, not a string.

Hi,
thanks for your response, but ...
we run still into problems.
First it is not easy to build an object with a dash inside the key.
We tried now
data["Event-Name"] = "NOTIFY";
Second we still get the error
event.getHeader is not a function
We would really appreciate it, if you can show us a working example.

First it is not easy to build an object with a dash inside the key.

Sure it is, JS supports it natively.

Second we still get the error
event.getHeader is not a function

Probably because you aren't creating an Event object.
Example:
const eventCommand = new esl.Event({
    'Event-Name': 'NOTIFY',
    'profile': 'internal',
    'event-string': 'check-sync;reboot=false',
    'user': extNumber.
    'host': domainName,
});

freeSwitchConn.sendEvent(eventCommand, (res) => {
    if(res.body.substr(0,1) === "+")
        callback(true);
    else
        callback(false);
});

Thank you for your help!
The full working example:
const eventCommand = new esl.Event({
                            "Event-Name": "NOTIFY",
                            "profile": "internal",
                            "event-string": "check-sync;reboot=false",
                            "content-type": "application/simple-message-summary",
                            "user": ext_number,
                            "host": tokenData.domainName
                        });

const resyncExt = (eventCommand, callback) => {

    let success = false;

    freeSwitchConn.sendEvent(eventCommand, (res) => {
        for(let obj of res.headers){
            if(obj.name === "Reply-Text")
                if(obj.value.substr(0,1) === "+"){
                    success = true;
                    break;
                }
        }
        if(success)
            callback(true);
        else
            callback(false);
    });
};

You can use getHeader("Reply-Text") instead of looping through all headers. In v2, getHeaders is faster than looping as well.


Tests for library and proper "package" file structure.

Would like to know if you intend to write tests for the library and would like all the files necessary for a PHP package like .editorconfig and LICENSE. Have submitted a PR (#2) if you do.

Submitted another PR (#4) with cleanup done according to previous comments.

Submitted another PR (#4) with cleanup done according to previous comments.

Thank you. #4 is merged with thanks.
I made a few minor changes, basically enabling coverage reports on top your phpunit config.
I will review/reply to the rest soon, but I think in a couple days because I will be 12-14 hours on the road tomorrow.
Cheers.

Thank you. #4 is merged with thanks.
I made a few minor changes, basically enabling coverage reports on top your phpunit config.
I will review/reply to the rest soon, but I think in a couple days because I will be 12-14 hours on the road tomorrow.
Cheers.


Beginner tutorial not working

I’m having trouble running the beginner tutorial on K8s 1.4.7 and P7m 1.3.1 using the manifest posted by Joe at the bottom of GitHub issue 1210.
I can create repos and load the data, but when I run the pipleline only the ‘filter’ job is reported and it’s in the ‘failure’ state.  A couple notes:

     The docs use the 1.2.1 pipeline (which seems wrong), but the 1.3.1 version has the same problem.

     Both the ‘filter’ and ‘sum’ repos are created, but both are empty.

I’m happy to debug this myself, but don’t know where to start.  I couldn’t find anything on your troubleshooting page on how to access the logs.
How should I proceed?

Hi @binary-finary sorry you hit this. Jobs normally fail when the code running in the pod encounters some sort of an error. Could you do pachctl get-logs <job-id-of-failed-job> and paste the results in here? That should give us an idea of what's going wrong.

list-job returns:
ID                                 OUTPUT                                      STARTED             DURATION             STATE
67c30d70ba9d2179aa133255f5dc81db   filter/9d3816237ecc4e32b38fd3e577376a07/0   5 seconds ago       Less than a second   failure
I assume the first hash is the job id, but then I get:
$ pachctl get-logs 67c30d70ba9d2179aa133255f5dc81db
job 67c30d70ba9d2179aa133255f5dc81db not found
Sorry if I've misunderstood your instructions.

That's the correct command. It's possible that kubernetes has garbage collected the job or something. What do you get if you do kubectl get pod -a? You should see a pod with that uuid as a prefix followed by 5 random characters. If you do kubectl logs <pod-name> that should hopefully get you the same thing. If k8s has already gced it then you won't be able to get the logs, in that case I'd recommend deleting the pipelines and their output repos and then creating the pipelines again. This should recreate the k8s jobs and thus the logs.

Seems like my pod was removed...
$ kubectl get pod -a
NAME               READY     STATUS      RESTARTS   AGE
etcd-srw0p         1/1       Running     0          1h
pachd-init-m5r6x   0/1       Completed   0          1h
pachd-m99l2        1/1       Running     1          1h
rethink-zttvw      1/1       Running     0          1h
I've looped through the demo script several times now (including deleting the minikube), and the result is always the same (mravi on your Slack channel has confirmed this as well).  Are there extra debugging options to track that down?  I could also just wait for your 1.3.2 release if that's easier for you.
I'm running OSX 10.11.6 and VirtualBox 5.1.10.
Thanks

By far the easiest debugging option is to get logs from the job before it gets removed by k8s. Unfortunately I think minikube is pretty aggressive about garbage collecting completed pods. Would you mind doing one more run through and capturing the logs of the jobs right after it fails before k8s has a chance to garbage collect it?

I started by deleting the minikube, creating the pods via the suggested manifest and reloading the data repo.  I then issued a create-pipeline and followed with:
$ pachctl list-job
ID                                 OUTPUT                                      STARTED             DURATION             STATE
67c30d70ba9d2179aa133255f5dc81db   filter/8f4e6468bacd43818dfa878b751fabb3/0   2 seconds ago       Less than a second   failure
And just a couple seconds later issued a:
$ pachctl get-logs 67c30d70ba9d2179aa133255f5dc81db
job 67c30d70ba9d2179aa133255f5dc81db not found
And a couple seconds after that:
$ kubectl get pod -a
NAME               READY     STATUS      RESTARTS   AGE
etcd-6m5j2         1/1       Running     0          6m
pachd-g46bp        1/1       Running     0          6m
pachd-init-4kdh9   0/1       Completed   0          6m
rethink-c15s6      1/1       Running     0          6m
Am I doing this correctly?  Any environment setting you want to know?  Happy to keep trying if this is worth your time.
Thanks

@binary-finary hmm, that's a somewhat unexpected result maybe. Few more questions:

Could you grab logs from pachd with kubectl logs pachd-g46bp?
when you delete the minikube and then recreate it is kubernetes empty at this point? kubectl get all should just have a single kubernetes service running, no pachyderm jobs / pods. Is this the case?

Yes, I verified K8s was free of P7m (did I coin that term?) after the minicube reboot.  The attached logs contain several error messages, so we're making progress.
pachd_logs.txt

did I coin that term?

You did! And I really like it, expect to see that in common usage from now on :P
Also I think I've found the guilty party here:
2016-12-20T22:37:50Z ERROR error running pipeline filter: Job.batch "67c30d70ba9d2179aa133255f5dc81db" is invalid: spec.template.spec.initContainers[0].env[1].valueFrom.fieldRef.apiVersion: Required value; retrying in 620.581479ms

K8s seems to be rejecting the job that pachyderm is trying to create. That would also explain why we can't get logs from it, it's not that the job is failing during execution it's just failing to create entirely. This is an issue I'd seen with k8s 1.5 but I'm guessing that k8s 1.4.7 exhibits this behavior too. In the short term running an earlier version of k8s is probably your best bet to get something working. This issue is fixed by #1223 we should have that merged in and shipped by the end of the week in which case this problem should go away.

Thanks for working through this.  I'll verify 1.3.2 fixes the problem and report back on this thread.

@binary-finary 1.3.2 has been released so this should no longer be an issue, let us know if things still aren't working.


DOC: fix symlink to logistic.sf in stats.logistic

Introduced in #15114

Ugh. The doc build  CI is still unhappy. Would you be able to look into it  @tupui , or should be just revert gh-15114?

Ark yes I will do this tomorrow.

I think we should just not try to link. We don't do this for other classes when we refer to the PDF of CDF.

Agreed, shouldn't use linking at all. Can you update to double backticks?

It's green, I will merge now to make the CI green again. Thanks @ev-br

Thanks Pamphile for fixing this up!


Parallel Coordinates Plot

Feature request: To be able to create a parallel coordinates plot in TRAINS in order to compare several hyper-parameters in respect to a specific metric, a similar feature is available in Tensorboard and MLFlow.

@majdzr thank you for the suggestion, I think it is a great idea.
Meanwhile, there is probably a way to achieve the same exploration with python code + plotly.
Let me see what I can come up with :)

Hi @majdzr ,
Trains-Server v0.13.0 was just released, with parallel coordinates plot available in the experiments comparison view under the Hyper Parameters section :)

Hey,
Very nice and useful feature. Thanks again for adding it.
One remark, can you please enable highlighting the plot once the mouse is over it? Maybe also highlighting the experiment name in the legend and the values of the parameters involved in the comparison?
Thanks!


♻ Refactored Domain to use a feature based approach

Before:

After:

@william-liebenberg for a more compelling example here's what the same thing looks like in the CA workshop:


Reset scroll in preview

Little thing I've noticed in the data preview: if I scroll down to a page and extract data, the scroll stays at that position even after switching to the preview. We might want to set it to the top.
Thanks!

Easy enough!

done in e60a408


Roman copy edits

General copy-edits. After this is merged, you'll need to regenerate the website.
Also, I suggest we rename the "Motivation" section into "Why Remx" and shorten it significantly. Details on this will follow up in an email though, so just mentioning this here FYI.

Nice, thanks!


You changed the AI code?

@pabloalber84 nope

You changed command playerlist code?

Can someone run this on stock and test the same command.

Ok

I ran a test to see if there were any errors, everything worked fine.
I'm assuming that you have altered a line or two of code and that's how it broke.
Here are my results for the latest version (1.6.1):


Need to define in detail the Delegation Protocol

A description has been provided that is very close to the design of the Cardano stakepool delegation.


Someone who understands go and English PLEASE FIX DOCUMENTATION

The English in the documentation is very not good. As a beginner to golang and nano, I'm having a lot of trouble understanding it.
Eg;
While handling a message, the handler will receive two arguments, session corresponding a client and a message is the payload of this request that unmarshals by nano automatically.
While handling a message, the handler will receive two arguments, a session id corresponding to a client and a content indicating the payload of the request....
Okay? I had to read through it several times to understand that far.
However, you lost me at unmarshals.
If anyone knows both English and go and nano and can go through the docs it would be a great help...

Sorry for my bad English, I will improve the docs later.

func (c *Group) Member(uid int64) (*session.Session, error) {
c.mu.RLock()
defer c.mu.RUnlock()
for _, s := range c.sessions {  // why no map[]
	if s.UID() == uid {
		return s, nil
	}
}

return nil, ErrMemberNotFound

}


update aliwangwang version 7.00.02-7243

[x] Commit message includes cask’s name (and new version, if applicable).
[x] brew cask audit --download {{cask_file}} is error-free.
[x] brew cask style --fix {{cask_file}} left no offenses.

Updating the :checkpoint value in appcast is required. You can find it with curl --silent --compressed "{{appcast_url}}" | sed 's|<pubDate>[^<]*</pubDate>||g' | shasum --algorithm 256 | awk '{ print $1 }'.
Alternatively, you may wish to use cask-repair. It can at once update the cask’s version (according to what you give it) taking care of updating both the cask’s sha256 and the appcast’s :checkpoint, while still giving you the chance to perform other manual fixes.
You can easily install it with brew install vitorgalvao/tiny-scripts/cask-repair. cask-repair --help will show you some options, but as a whole the script will guide you through the update process.

Thank you for the contribution. It needed some fixes, so they were made in 508fa6d07041dc83a879aa896ec9f356f69a9ec2. Your contribution is still included (and still credited to you), with the appropriate modifications. Please feel free to ask about any of the changes.


feat(acvm)!: Encapsulate internal state of ACVM within a struct

Description
Problem*
Resolves #383
Summary*
This PR creates an struct to track the internal state of the ACVM execution.
Testing with full noir test suite here
Additional Context

PR Checklist*

[ ] I have tested the changes locally.
[ ] I have formatted the changes with Prettier and/or cargo fmt on default settings.

This can be simplified significantly with #368 and #385. We will then also be able to remove all cloning of opcodes.

Is this aiming to encapsulate ACVM or just the PWG?

ACVM involves both a solver and a backend. Where the backend does proving and verifying

Is that the correct way to think about it? I mean, yes if we're talking about "ACVM the repository" then this naming is suboptimal but if we're thinking about "ACVM the virtual machine" then the struct naming is accurate.
If we were talking about a zkEVM, I don't think we'd include the prover/verifier in the definition of the zkEVM but accompanying components. The zkEVM is just the circuits which take initial state and generate the output state which is similar to what the ACVM struct is doing here.

Is that the correct way to think about it? I mean, yes if we're talking about "ACVM the repository" then this naming is suboptimal but if we're thinking about "ACVM the virtual machine" then the struct naming is accurate.

I've always thought of it as ACVM being instantiated with a backend but I can see where you are coming from. If thats the case, then wouldn't proving and verifying being in this repository be an abstraction leak?

If thats the case, then wouldn't proving and verifying being in this repository be an abstraction leak?

Potentially, yes. The SmartContract and ProofSystemCompiler traits depend on ACIR rather than the ACVM itself. These interfaces could be defined elsewhere as some for of "surrounding tooling" for the ACVM.

I don't think this will be the final state of the ACVM struct but its in a mergeable condition.


feat(project): add migration endpoint (DSP-1666)

resolves DSP-1666

The code, being a copy of the createProject endpoint, can easily be approved, I guess.
However I'm not 100% sure the solution of separating those endpoints will prove practical: My gut tells me that we'll end up using the migration endpoint all the time (maybe not in the long term, but middle term I guess) because it might prove hindering with our workflows of accepting projects. I imagine CS will want to assign projects with short codes before they have all the information necessary to actually create the project. Or it may happen that projects need a short code when applying for funding, but we don't want to create the project before we are sure they receive funding.
I think we have to further discuss this at some point, or at least keep it in the back of our minds that this may be an issue.

My first thought was to simply make the short code optional but Go doesn't support that so then I was thinking of a hacky solution with an additional boolean parameter that would control whether or not the provided short code should be used or it should be auto-generated. I'm also not a fan of temporary code because if often turns into permanent code. For now I'll stick with the two different methods for migration and creation but we should discuss it either this week or next week. Otherwise, I fear it will be forgotten.

My first thought was to simply make the short code optional but Go doesn't support that so then I was thinking of a hacky solution with an additional boolean parameter that would control whether or not the provided short code should be used or it should be auto-generated. I'm also not a fan of temporary code because if often turns into permanent code. For now I'll stick with the two different methods for migration and creation but we should discuss it either this week or next week. Otherwise, I fear it will be forgotten.

Too bad Go doesn't support optional params...
Would you consider it hacky too, to 1) check if a shortcode was passed via API, 2) if so, use that, and if not, use the string null-value, and pass this "pseudo-optional" shortcode, and 3) when creating the project, check if shortcode is null-value, and if so, auto-generate one.
(That's another question: how can we reasonably auto-create shortcodes?)


Joined players instantly go afk

Doesn't really bother me but an issue nonetheless. Since I've enabled "display-to-everyone", Players automatically broadcast afk message upon joining if they leave the game and re-join x minutes after.
x refers to the time you set on "afk-after" in config.yml. Mine is 5 minutes.
Replicate: Join the server, leave the server, wait 5 minutes, and re-join.
Image

Should be fixed in the next version (finalizing 1.4.0-beta now)

Just published v1.4.0-beta!

Awesome!


Add support for reloading the configuration file

I constantly have to kill the process and restart in the terminal when editing the configuration file. I would like some combination of:

React to configuration file changes to automatically reload
React to a USR1 signal to reload the configuration file and/or restart the application

Closing this issue as this application is now in maintenance mode


does this works on ios simulator?

Yepp, the example app runs in iOS simulator as well as in the android simulator! Just run react-native run-ios in the example folder.


Blazor/Razor Views No Longer Compatible with Hyperlinq Enumerables

Sorry for the chatter.  I knew upgrading to the latest version would be a chore and I am passing on the pain. 😅😭
I am now seeing this error in Blazor/Razor views making use of Hyperlinq:

Any guidance would be appreciated.  I tried to make use of the AsEnumerable() call but that did not seem to affect the error.

Never mind, this appears to be a Visual Studio 2019 editor bug.  It doesn't show in R# SWEA, and doesn't produce a build error. 😌

FWIW/FYI reported this issue to R# here: https://youtrack.jetbrains.com/issue/RSRP-485499


Don't suggest import completions for /a/node_modules if we're in /b

Fixes #19878
Relative imports into node_modules are bad, especially ../../../../../../../../../../../../../../Library/Caches/typescript/2.6/node_modules/@types/gulp-util.

@armanio123 @minestarks Please re-review