Example app uses functional instead of PureComponents

For performance reasons it seems that using PureComponents is better optimized over functional stateless components (read this and  this).
Should we convert the current stateless components in the example app to PureComponents?
Examples:
PureComponent
import React, { PureComponent } from 'react';

class Button extends PureComponent {
  render() {
    return <button>{this.props.label}</button>;
  }
}

Functional stateless component
function Button(props) {
  return <button>{props.label}</button>;
}

or
const Button = (props) => (
  <button>{props.label}</button>
);

Functional components in example app:

Button
Footer
Img
IssueIcon
List
ListItem
LoadingIndicator
Toggle
ToggleOption

which version of the repo you're using ?

because
npm run generate does have option for create.  @kelsonic

Yes, we do have an option to generate Pure components.
I'm just thinking out loud:

Pure components offer shallow comparison of previous and next props in shouldComponentUpdate. They're great if you want to avail React's life cycle methods AND built-in shallow comparison. Since Button, Footer, Img etc. do not warrant usage of any life cycle methods, it's better to use stateless over pure.
But stateless components are re-rendered every time they receive props.
That being said, React team has promised optimizations for stateless components in the future.
Stateless components are easier to read than Pure Components.
But Performance > Readability.

I'd say we should convert stateless ones to pure. But let's see what others have to say about this.

@Necmttn @KarandikarMihir Sorry about the miscommunication, I had forgotten that on my version I took away the stateless component generator since I prefer using PureComponents.

But Performance > Readability.

Personally, I think since this is a boilerplate used specifically for production-ready apps, performance should be the main concern here.
When we use PureComponents within the example app, we are demonstrating to our users that using PureComponents is preferred over stateless components as far as performance is concerned.
If the decision is to convert them to PureComponents, I'm happy to make a PR. 😄

What do you think @collaborators?

There is an in-depth answer to the question when to use function. Component or PureComponent on SO.
In general, declaring any of them a bet practice amounts to premature optimization. That leaves us with using the simplest solution (Occam's razor).
I would prefer using function components wherever possible,  React.Component where dynamic state or life-cycle methods are needed, and React.PureComponent only where performance optimizations are proven to be needed.
Remember, in react-boilerplate we also have performance enhancements from selectors and immutable state.

Remember, in react-boilerplate we also have performance enhancements from selectors and immutable state.

Agreed. Sometimes I tend to take those things for granted.
In addition to that, react only updates what's necessary. Occam's razor ftw.


feat(Order): sup/inf equal to top/bot if top/bot in set

The sup lemma is needed in a proof related to SimpleGraph.ediam in #12058

Thanks! :tada:
bors merge


Feature request : domainmetadata

Hello,
Related to #82, it would be very useful to be able to create domainmetadata for domains, like TSIG-ALLOW-DNSUPDATE or TSIG-ALLOW-AXFR.
Would be even better to have it in domain templates.
Actually you have to use pdnsutil to set them.
Regards
Cédric

+1 on this feature request please

+1

Hello,
This request is stale for too long. Regarding our policy to cleanup this project, we are closing it. As this is a Feature Request, it will be listed in #1178
Regards
PowerDNS Admin Team
See #1153 for the policy

when pdns act as slave, new domains gen from  catalog, but may not transfer zone data without tsigkey if master need
so i need defaut tisgkey set for catalog
another request setting is defautl IXFR for all domains


Fix an Error Resolving Multiple Relationships from the Same Source Text - 3.1

Fix an error that may occur when multiple relationships are created for a vertex at different visibilities and sourced from the same text.

[x] joeferner
[x] sfeng88
[ ] mwizeman joeybrk372 jharwig

Testing Instructions:

Import a document into a graph
Select the new document vertex
Highlight and resolve a new entity in the "Text" field
Highlight and resolve a another new entity in the "Text" field
Copy a string from elsewhere in the "Text" field
Drag the first entity onto the second entity
Choose a relationship type, paste the copied text into the "Justification" field, and press "Connect"
Publish all changes
Resolve a third entity
Copy a another string from elsewhere in the "Text" field
Drag the first entity onto the third entity
Choose a relationship type, paste the copied text into the "Justification" field, and press "Connect"
Deselect the document vertex
Reselect the document vertex
Ensure the text and all entities appear as expected. Ensure no errors are reported.

CHANGELOG
Fixed: Fix an error that may occur when multiple relationships are created for a vertex at different visibilities and sourced from the same text.

@kunklejr The fix was all in this file. I overloaded an existing method to accept an additional String edgeId and call the new signature here in this method


Bevy 0.3

Update cargo.toml and docs for a Bevy 0.3 release. I'd like to have #52 included in this release.

🎉🎉🎉🎉🎉🎉


[Flink-14599][table-planner-blink] Support precision of TimestampType in blink planner

What is the purpose of the change
Since FLINK-14080 introduced an internal representation(SqlTimestamp) of TimestampType with precision. This subtask will replace current long with SqlTimestamp, and let blink planner support precision of TimestampType.
Note:

Tables defined by DDL is not supported in this PR since de/serializing DataTypes lost precision information. Would open another ticket to cover.
Built-in time functions/operators which use long to compute is not supported in this PR too. Would open another ticket to cover.

Brief change log

The first commit(ee687db) introduces setTimestamp/getTimestamp interface to TypeGetterSetters/VectorizedColumnBatch and writeTimestamp interface to BinaryWriter
be1beee to 0b57ee3 replace current long with SqlTimestamp, and Fix all existing failure cases
915064c introduces LegacyTimestampTypeInfo and LegacyLocalDateTimeTypeInfo to represent Types.SQL_TIMESTAMP and Types.LOCAL_DATE_TIME with precision
3d1de92 supports precision of Timestamp type in table source
8751385 supports precision of Timestamp type for timestamp literals

Verifying this change
This change is already covered by existing tests and new tests.
Does this pull request potentially affect one of the following parts:

Dependencies (does it add or upgrade a dependency): (yes / no)
The public API, i.e., is any changed class annotated with @Public(Evolving): (yes / no)
The serializers: (yes / no / don't know)
The runtime per-record code paths (performance sensitive): (yes / no / don't know)
Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Yarn/Mesos, ZooKeeper: (yes / no / don't know)
The S3 file system connector: (yes / no / don't know)

Documentation

Does this pull request introduce a new feature? (yes / no)
If yes, how is the feature documented? (not applicable / docs / JavaDocs / not documented)

Thanks @docete , I will review this these two days.

Can we put nanos of SqlTimestamp to the fixed-length part in BinaryRow? In this way:
offsetAndNanos in fixed-length part and milliseconds in variable-length part.

Can we put nanos of SqlTimestamp to the fixed-length part in BinaryRow? In this way:
offsetAndNanos in fixed-length part and milliseconds in variable-length part.
OK. It can save 4 bytes per high precision timestamp object.

Please rebase to master, we should let travis verify all the tests since you modified a lot of them.

@KurtYoung  The Date plus Day Interval case and Cast Timestamp to BigInt case, I prefer leave it to the next PR. The semantic of arithmetic and cast operator for date time type need to be double check. Mix the change of only one or two cases in the PR is incomplete.
By the way, the TIMESTAMPADD function semantic for DATE +/- INTERVAL_DAY_TIME(hours, minutes and seconds) seems OK to return a TIMESTAMP. What do you think?

Rebased to master.

Hi @docete , I think we should try our best to avoid merging the code in and fixing it in next PR.
A better way is to split the PR's dependency work as much as possible, so that the PR can be smaller.

close this since it's splitted to two PRs


Changes in values.yaml and deployment.yaml

These changes are to add annotations to the application pod so that any new pod will have those annotations so that the prometheus metrices can be automatically scraped.

Dear @rohits-splunk,
than you for your contribution! I would like create a community under this project and this is good for that purpose. I will release a new version of KubeInvaders with your changes.


Update coverity_scan with latest changes

Run another scan!

well apparently just submitting this PR will build it... lol


Top level  block doesn't aggregate  attributes

Per an example provided in the docstring, it seems the top level <testsuites> element should have aggregated attributes of all of its children <testsuite> elements.
As a result, instead of seeing a <testsuites> element that looks like:
<testsuites errors="1" failures="1" tests="4" time="45">

You would see a <testsuites> element that looks like:
<testsuites>

Is this a bug?

I came across with the same problem and question upon using it. In my opinion this is a must. However, it is up to the Jenkins plugin to define the format. I couldn't find the documentation for it. I would be glad if somebody could share it here.

It looks like the fix to this is merged... maybe @brianebeyer forgot to close this issue?


fix: setup with secret config

Config provided using a referenced secret has no effect for the setup job. This PR fixes this.
Definition of Ready

[ ] I am happy with the code
[ ] Short description of the feature/issue is added in the pr description
[ ] PR is linked to the corresponding user story
[ ] Acceptance criteria are met
[ ] All open todos and follow ups are defined in a new ticket and justified
[ ] Deviations from the acceptance criteria and design are agreed with the PO and documented.
[ ] No debug or dead code
[ ] My code has no repetitions
[ ] Documentation/examples are up-to-date
[ ] All non-functional requirements are met
[ ] If possible, the test configuration is adjusted so acceptance tests cover my changes

@stebenz I updated the conflicting version and disabled to auto-dismiss stale PR reviews in the branch protections.


Have option to validate JSON data with case insensitive matching on property names

Have option to validate JSON data with case insensitive matching on property names.

cc @JasonRodman, Hi, not sure whether this feature is what you were finding ?

New option to validate JSON with case-insensitive property names matching is in v1.1.7.


Adding support for Google HUb Nest 2 generation

Checklist

[X] I have filled out the template to the best of my ability.
[X] This only contains 1 feature request (if you have multiple feature requests, open one feature request for each feature request).
[X] This issue is not a duplicate feature request of previous feature requests.

Is your feature request related to a problem? Please describe.
I would like to be able to additionally measure power consumption by Google Hub Nest 2 Generation
Describe the solution you'd like
Just like it's done right now with this add-on for Google Home Mini speakers
Describe alternatives you've considered
I don't know...
Additional context
Nothing

Please see the FAQ and docs on about how to contribute by measuring https://homeassistant-powercalc.readthedocs.io/en/latest/contributing/measure.html.
The issue tracker is not the place to request support for new lights/devices.


pymodule derive macro

Creating an inner module for every stdlib looks not ideal but i have no idea how to do without them

Maybe we could only do this for some modules until custom_inner_attributes is stabilized? I think rightward drift might be an issue, as would git blame results. It'd be great if we could make rustfmt format it like below, ignoring indentation for just that block, though I don't think that's possible:
#[pymodule]
mod decl {

#[pyfunction]
fn thing() {}

}

For the formatting, I couldn't find any way to change local indent hint if we don't want to disable the whole file formatting. Also derive macro seems still always require to match the brace pair.
Is it possible to add #[pymodule] to use part of mod.rs for same result? I don't know well but it doesn't look like - because item iteration looks only possible on actual module code.

The mentioned issue looks quite old and then it means it is not expected to be solved in near future. Just go by experiencing git blame barrier?

Yeah, I guess so; I haven't gotten a ton of use out of git blame for this project, and I think the stdlib is generally simple/encapsulated enough that it wouldn't be used that much there.

@youknowone I think this change make developing harder. When I have errors the compiler does not show the line numbers and add suggestion:
error[E0308]: mismatched types
  |
  = note: expected reference `&std::sync::Arc<pyobject::PyObject<(dyn pyobject::PyObjectPayload + 'static)>>`
                found struct `std::sync::Arc<pyobject::PyObject<dyn pyobject::PyObjectPayload>>`

Is there a way to fix this?

I am sorry that discovering this comment so late. should we consider to revert this?


Add Vertex as orchestrator and step operator to deploy CLI

Describe changes
I added vertex in the validation dictionary to allow folks to use it for orchestrator and step operator.
Pre-requisites
Please ensure you have done the following:

[ ] I have read the CONTRIBUTING.md document.
[ ] If my change requires a change to docs, I have updated the documentation accordingly.
[ ] If I have added an integration, I have updated the integrations table and the corresponding website section.
[ ] I have added tests to cover my changes.

Types of changes

[ ] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)
[ ] Other (add details above)

@strickvl I've added it to the new docs. would that work?


About Unity Support

I am considering using grpc with Unity.
It seems that "grpc_unity_package.xxxx-xxxxxxx.zip" has not been created since the following build.
Will Unity be supported in the future?
https://packages.grpc.io/archive/2022/04/67538122780f8a081c774b66884289335c290cbe-f15a2c1c-582b-4c51-acf2-ab6d711d2c59/index.xml

C# development was frozen a while ago, please see https://grpc.io/blog/grpc-csharp-future/ for details. I'll defer to @jtattermusch on plans to release any more packages within the maintenance window, but I expect any subsequent packages would be comprised of bug fixes.


Segfault on invalid UDP packet

Describe the bug
memcached crashes in try_read_udp when it wants to output SERVER_ERROR multi-packet request not supported, due to an uninitialized c->resp.
To Reproduce
memcached &
echo -en "\0\01\0\0\0\0\0\0\0" | nc -w0 -u localhost 11211

System Information

OS/Distro: Arch Linux
Version of OS/distro: amd64
Version of memcached: master
Hardware detail: haswell

Detail (please include!)
configure flags:
./config.status --config
'--prefix=/opt/memcached-master' \
'--disable-dependency-tracking' \
'--disable-docs' '--disable-coverage' \
'--enable-sasl' \
'--enable-sasl-pwdb' \
'CFLAGS=-Og -g -pipe'

gdb backtrace:
Thread 6 "memcached" received signal SIGSEGV, Segmentation fault.
[Switching to Thread 0x7ffff5c32640 (LWP 1736904)]
resp_reset (resp=0x0) at memcached.c:972
972	    if (resp->item) {
gdb$
> bt
#0  resp_reset (resp=0x0) at memcached.c:972
#1  0x000055555555d870 in out_string (c=0x7fffe0020e30, str=0x555555582288 "SERVER_ERROR multi-packet request not supported") at memcached.c:1194
#2  0x000055555555da10 in try_read_udp (c=0x7fffe0020e30) at memcached.c:2607
#3  0x000055555555df59 in drive_machine (c=0x7fffe0020e30) at memcached.c:3312
#4  0x000055555555e77d in event_handler (fd=<optimized out>, which=<optimized out>, arg=0x7fffe0020e30) at memcached.c:3597
#5  0x00007ffff7f5016e in ?? () from /usr/lib/libevent-2.1.so.7
#6  0x00007ffff7f50a7f in event_base_loop () from /usr/lib/libevent-2.1.so.7
#7  0x000055555556b6eb in worker_libevent (arg=0x5555555b6690) at thread.c:483
#8  0x00007ffff7ef53e9 in start_thread () from /usr/lib/libpthread.so.0
#9  0x00007ffff7e23293 in clone () from /usr/lib/libc.so.6
gdb$
> l
967
968	/*
969	 * response object helper functions
970	 */
971	void resp_reset(mc_resp *resp) {
972	    if (resp->item) {
973	        item_remove(resp->item);
974	        resp->item = NULL;
975	    }
976	    if (resp->write_and_free) {
gdb$
> l memcached.c:2607
2602	        /* Beginning of UDP packet is the request ID; save it. */
2603	        c->request_id = buf[0] * 256 + buf[1];
2604
2605	        /* If this is a multi-packet request, drop it. */
2606	        if (buf[4] != 0 || buf[5] != 1) {
2607	            out_string(c, "SERVER_ERROR multi-packet request not supported");
2608	            return READ_NO_DATA_RECEIVED;
2609	        }
2610
2611	        /* Don't care about any of the rest of the header. */
gdb$
> l out_string
1179	// tells if connection has a depth of response objects to process.
1180	bool resp_has_stack(conn *c) {
1181	    return c->resp_head->next != NULL ? true : false;
1182	}
1183
1184	void out_string(conn *c, const char *str) {
1185	    size_t len;
1186	    mc_resp *resp = c->resp;
1187
1188	    assert(c != NULL);
gdb$
> l
1189	    // if response was original filled with something, but we're now writing
1190	    // out an error or similar, have to reset the object first.
1191	    // TODO: since this is often redundant with allocation, how many callers
1192	    // are actually requiring it be reset? Can we fast test by just looking at
1193	    // tosend and reset if nonzero?
1194	    resp_reset(resp);
1195
1196	    if (c->noreply) {
1197	        // TODO: just invalidate the response since nothing's been attempted
1198	        // to send yet?

Also, that assert on 1188 seems a bit late in the game.

thanks! you can tell the UDP code gets a lot less love now.
I think a few people found this independently in this last week, though your report was the most thorough. Technically this is a zero-day remote DoS but UDP's been disabled by default for a few years now...

Oh dang. I think way too little about all that bad stuff... Should I empty the issue?
Sorry, I just found it because libmemcached was doing BS.

shrug. cat's out of the bag now. I'll just try to cut a release soon.

I suck. fixed in the next branch now. How would you like to be credited in the release notes?

released in 1.6.8

I suck. fixed in the next branch now. How would you like to be credited in the release notes?

Not sure, do you need anything other than available in my github profile?

I just linked to your github profile in the release notes as thanks. lmk if you want it removed or anything.


uv_pipe_peername

Since we have uv_pipe_sockname, wouldn't it be nice to have for simple pipes uv_pipe_peername to return the string to which it connected?

If it returns a string, how is it going to interact with Linux abstract sockets?

It is a pointer to a buffer and a pointer to the length of the buffer.
It doesn't matter whether its a string or some other bock of information.

If it returns a string, how is it going to interact with Linux abstract sockets?

It could be just like uv_pipe_getsockname:
int uv_pipe_getpeername(const uv_pipe_t* handle, char* buf, size_t* len)

len would contain the length so it works for abstract sockets too.
I'm +1, and in retrospect I'm not sure why I didn't write it when I added uv_pipe_getsockname. Are you going to provide a patch?

The 'returns a string' bit threw me off; a char* uv_pipe_getpeername(uv_pipe_t* handle) for example would not be useful with abstract sockets.

in retrospect I'm not sure why I didn't write it when I added uv_pipe_getsockname

Because it just returns the path you passed to uv_pipe_connect()? :-)

Because it just returns the path you passed to uv_pipe_connect()? :-)

I guess that was the reason, but if we want to know it in the handle where we called uv_accept, getsockname won't do...

Not sure I understand.  For the server, it's server_handle->pipe_fname.

That's a private field, right? Also, it won't contain anything in case handle had the fd assigned with uv_pipe_open.

Sure, but I mean that you know the address because it's what was passed to uv_pipe_bind().
I concede the point about uv_pipe_open().  About that: uv_pipe_getpeername() would probably do well to check that sa_family == AF_UNIX because people do sometimes pass non-UDS file descriptors to uv_pipe_open().

uv_pipe_getpeername() would probably do well to check that sa_family == AF_UNIX because people do sometimes pass non-UDS file descriptors to uv_pipe_open().

Good point!

#166 landed, closing.


Add MQTT logging

See other OXRS firmware for how it has been implemented using MqttLogger

added in #7


[Documentation] simplified the "Promise" example

Summary
If someone were to use promise, it would be clearer to write their code this way, doing so they would take advantage of the promises.
Ticket Link
There is no ticket for that tell me if I need to create one (in which case I will strongly reconsider contributing this piece of doc since it would mean creating an account on a third party site and all ...)
Test Information
This PR was not tested at all. The mentionned code was tested in a console on chrome

Thanks @gulhe for the pull request!
Per the CONTRIBUTING.md file displayed when you created this pull request, we need to add you to the list of approved contributors for the Mattermost project.
Please help complete the Mattermost contribution license agreement?
This is a standard procedure for many open source projects. Your form should be processed within 24 hours and reviewers for your pull request will be able to proceed.
Please let us know if you have any questions.
We are very happy to have you join our growing community! If you're not yet a member, please consider joining our Contributors community channel to meet other contributors and discuss new opportunities with the core team.

This issue has been automatically labelled "stale" because it hasn't had recent activity.
A core team member will check in on the status of the PR to help with questions.
Thank you for your contribution!
/cc @jasonblais @hanzei

Thanks @gulhe! Would you be open to help complete the Mattermost contribution license agreement?
Please let us know if you have any questions.

Sure, how can I proceed ? I'm not familiar with the concept.
Le mar. 19 mars 2019 2:49 AM, Jason Blais<EMAIL_ADDRESS>a
écrit :

Thanks @gulhe https://github.com/gulhe! Would you be open to help
complete the Mattermost contribution license agreement
http://www.mattermost.org/mattermost-contributor-agreement/?
Please let us know if you have any questions.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/mattermost/mattermost-redux/pull/784#issuecomment-474166303,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AA8Ku7TTL2QNafFS8E6lHeXjwFhS1pwfks5vYEIxgaJpZM4bcH9L
.

I think I figured it out
Le mar. 19 mars 2019 12:21 PM, Guillaume LHERMITTE<EMAIL_ADDRESS>a
écrit :

Sure, how can I proceed ? I'm not familiar with the concept.
Le mar. 19 mars 2019 2:49 AM, Jason Blais<EMAIL_ADDRESS>a
écrit :

Thanks @gulhe https://github.com/gulhe! Would you be open to help
complete the Mattermost contribution license agreement
http://www.mattermost.org/mattermost-contributor-agreement/?
Please let us know if you have any questions.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/mattermost/mattermost-redux/pull/784#issuecomment-474166303,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AA8Ku7TTL2QNafFS8E6lHeXjwFhS1pwfks5vYEIxgaJpZM4bcH9L
.


⚠ Adam Brand Music has degraded performance

In 2a85606, Adam Brand Music (https://adambrandmusic.com) experienced degraded performance:

HTTP code: 200
Response time: 7917 ms

Resolved: Adam Brand Music performance has improved in 5d27f1c after 6 minutes.


LLVM Triplets

Gleam moved to LLVM triplets.
https://github.com/gleam-lang/gleam/commit/eebdbec5784cd82a46296e90765ca664bf7eb5af
This leads to broken URLs for the current release candidates.
λ ~/ asdf install gleam 0.23.0-rc2
Could not find archive at URL https://github.com/gleam-lang/gleam/releases/download/v0.23.0-rc2/gleam-v0.23.0-rc2-macos-arm64.tar.gz
λ ~/ asdf install gleam 0.23.0-rc1
Could not find archive at URL https://github.com/gleam-lang/gleam/releases/download/v0.23.0-rc1/gleam-v0.23.0-rc1-macos-arm64.tar.gz

Heya! Please update your Gleam plugin by running asdf plugin-update gleam


Adds the High Scores exercise.

Let me know how you'd like the config for High Scores to look in config.json. In the Javascript track, High Scores is unlocked by Pangram, but in the Ruby track High Scores is core. Is there a canonical place for this?

@camilopayan are you interested in completing this work? There have been some breaking changes in the directory structure and the continuous integration tests that would need some work to update.

In regards to your question, there will not be core exercises in v3, so you don't need to add that anymore

I can also bring this one up to date if it is abandoned.

Sorry about the long delay, I've been pretty swamped. Go for it @MichaelBunker I appreciate it.

Fulfilled by #398


analysis: optimize performance and fix dead loop

Two fixes:

We are infinite loop on stop when it triggers. break is for the
switch, not the for.
No need to use regex
Fixes https://github.com/istio/istio/issues/40580

@howardjohn: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

unit-tests-arm64_istio
335334a25c99838b3c17bd275e626aa8f23c71a4
link
true
/test unit-tests-arm64

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@howardjohn: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

unit-tests-arm64_istio
335334a25c99838b3c17bd275e626aa8f23c71a4
link
true
/test unit-tests-arm64

lint_istio
335334a25c99838b3c17bd275e626aa8f23c71a4
link
true
/test lint

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@howardjohn: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

unit-tests-arm64_istio
335334a25c99838b3c17bd275e626aa8f23c71a4
link
true
/test unit-tests-arm64

lint_istio
335334a25c99838b3c17bd275e626aa8f23c71a4
link
true
/test lint

unit-tests_istio
335334a25c99838b3c17bd275e626aa8f23c71a4
link
true
/test unit-tests

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

In response to a cherrypick label: new pull request created: #40681

In response to a cherrypick label: new pull request created: #40682

I think it's from losing leader election which is why the original issue
was only with multiple istiod replicas
On Mon, Aug 22, 2022, 7:25 PM Zhonghu Xu @.***> wrote:

@.**** commented on this pull request.
In pkg/config/analysis/incluster/controller.go
https://github.com/istio/istio/pull/40595#discussion_r952090694:

@@ -113,7 +113,7 @@ func (c *Controller) Run(stop <-chan struct{}) {
log.Debugf("finished enqueueing all statuses")
case <-stop:
t.Stop()

	break

	return

I mean stop can be closed only when the process exit?
—
Reply to this email directly, view it on GitHub
https://github.com/istio/istio/pull/40595#discussion_r952090694, or
unsubscribe
https://github.com/notifications/unsubscribe-auth/AAEYGXKJLA76XBOD2GYME4LV2QZB7ANCNFSM57ISJPYA
.
You are receiving this because you were mentioned.Message ID:
@.***>


Sparse merkle tree multi-proof

For gas saving, we could use the sparse merkle tree multi-proof to validate the commitment signed by beefy authority set.
More detail can see https://github.com/darwinia-network/darwinia-bridge-sol/pull/104

Hey @hujw77 thanks for the contribution. I'll be able to review this properly next week, unless my colleagues get to it first.

@hujw77 Taking another quick look - Using a multiproof instead of an array of individual proofs looks like a great idea and optimization!
We'll need to build the proof creation logic into our relayer and do a deeper team audit and review before merging this. At the moment we're focused on some other maintenance and new feature work, so it may take a few weeks before we schedule this work in, but will leave this open as it's definitely something we'll want to merge in before this code is used in production.
Thanks again!

@musnit For the proof creation logic, there is research about it at https://github.com/hujw77/sparse-merkle-tree
It may be some help for audits and seminars.

Very obsolete. Now that https://github.com/paritytech/substrate/pull/12857 has been merged, we can use the OpenZeppelin multi-proof verifier for this:
https://github.com/OpenZeppelin/openzeppelin-contracts/blob/5dbde1a5c954a79338959d4eb9c7e716a217d6a1/contracts/utils/cryptography/MerkleProof.sol#L77


[PyTorch] Custom kernel to compute reciprocal of a single float

Description
FP8 training is frequently bottlenecked by CPU overheads and a non-trivial fraction of CPU overhead comes from small PyTorch operations. For example, when I benchmark the forward pass of  small Linear modules on an L40, I estimate ~20% of runtime is spent in handling the FP8 scaling factors (mainly in reciprocal and clone operations). This PR attempts to mitigate these overheads by adding a scalar_reciprocal kernel that operates on a single float, bringing the kernel launch cost down from ~20 us to ~10 us. In my benchmark of Linear forwards, I see a 8% reduction in runtime.
Alternative approaches:

Modify the cast and cast-transpose kernels to perform the scale-inv update, similar to how they perform the amax update. Logically, the scale is part of the FP8 recipe and the scale-inv is part of the data.
Use torch.compile to fuse FP8 scale operations. We would require significant refactoring to avoid incurring extra overhead from graph breaks, especially in how we deal with the  FP8TensorMeta class.

Type of change

[ ] Documentation change (change only to the documentation, either a fix or a new content)
[ ] Bug fix (non-breaking change which fixes an issue)
[x] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[ ] Infra/Build change
[ ] Code refractor

Changes

Custom kernel to compute reciprocal of a single float

Checklist:

[x] I have read and followed the contributing guidelines
[x] The functionality is complete
[x] I have commented my code, particularly in hard-to-understand areas
[x] I have made corresponding changes to the documentation
[ ] My changes generate no new warnings
[ ] I have added tests that prove my fix is effective or that my feature works
[ ] New and existing unit tests pass locally with my changes

/te-ci pytorch

Closed by https://github.com/NVIDIA/TransformerEngine/pull/1083


[fix] [ml] messagesConsumedCounter of NonDurableCursor was initialized incorrectly

Motivation
The field messagesConsumedCounter of NonDurableCursor was initialized incorrectly, the result is that only one message is consumed, but messagesConsumedCounter is 2, which is larger than ManagedLedger.entriesAddedCounter.
Modifications
Fix the wrong logic
Documentation

[ ] doc
[ ] doc-required
[x] doc-not-needed
[ ] doc-complete

Matching PR in forked repository
PR in forked repository:

https://github.com/poorbarcode/pulsar/pull/58

/pulsarbot rerun-failure-checks

Codecov Report

Merging #19355 (be57f47) into master (c17f355) will decrease coverage by 1.56%.
The diff coverage is 91.80%.

@@             Coverage Diff              @@
##             master   #19355      +/-   ##
============================================
- Coverage     64.33%   62.78%   -1.56%
+ Complexity    26041    25582     -459
============================================
  Files          1818     1818
  Lines        133110   133085      -25
  Branches      14644    14641       -3
============================================
- Hits          85641    83558    -2083
- Misses        39640    41814    +2174
+ Partials       7829     7713     -116

Flag
Coverage Δ

inttests
25.05% <54.09%> (+0.17%)
:arrow_up:

systests
25.57% <45.90%> (-0.01%)
:arrow_down:

unittests
59.98% <73.77%> (-1.56%)
:arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.


Apple M1 Macbook Pro install:  "bad CPU type in executable: go"

Following the installation instructions, in addition to the go1.5 section on the README:
I am getting the following error when running anything with the binary installed go1.4, including go version or gvm install go1.5:
zsh: bad CPU type in executable: go
I have installed rosetta with softwareupdate --install-rosetta
and which go points to the go1.4 version under GVM
Any suggestions?

The same here. Don't know what to do. Gonna do manual install now.

I also face the same issue.

Hi, it might be due to the fact that it is installing the x86 binaries. Check #406 and #385 for more.

@trmiller @koioannis @devravi @AsadSaleh kindly try this GO Version Manager: https://github.com/ankitcharolia/goenv


Make it easier to track source code positions

I have a large grammar, and I need to be able to track source code locations, however, it is very cumbersome, with the Token class. Do you have any suggestions or ideas for things to add the petitparser to make this easier?
This is my grammar: https://github.com/badger-lang/badger/blob/master/lib/src/parser/grammar.dart

Why do you think it is cumbersome? What exactly would you like to do?
In my experience, having every source element in a token that is also referenced from the AST is what most compilers I've seen do.
Now, if you do not want to use token and are only interested into the position of certain things, you could create your own "EpsilonParser" that always succeeds, never consumes anything, but returns the current position in the input stream (instead of null).

@renggli Ok, I'll try wrapping everything in a token :) It's just a little annoying tbh, if there was another way, that would be great. Something where I didn't have to make everything a token, but it just magically works. Maybe I expect too much :) I still love petitparser a lot :P


[BUG] Link onClick error

The following code causes an error:
routes.signIn.link({
  onClick: () => {},
});

validate.js:32 Uncaught Friendly Type Route Error Here 😁:

Error invoking `link`

Hope this helps:

Got unexpected key `onClick` in params object

Usage:

link(params?: Parameters): { href: string, onClick: (event?: { preventDefault?: () => void }) => void }

However, typescript tells me that the link can accept onClick event handler as an argument.
In my case, I want to call an additional function when specific link is being clicked. My current workaround is:
 {
    // ...
  }}
>
  NOT YOU?

Which version of Type Route are you using? I'm surprised TypeScript is telling you it can accept onClick as an argument to link. You could approach this with something along the lines of this:
 {
    e.preventDefault();
    yourOtherFunction();
    routes.signIn.push();
   }
>
  Sign In

If that doesn't work could you share a codesandbox that demonstrates the issue?

Package.json says the version is ^0.3.6.

It looks like maybe you're misreading this and mixing up what the function returns with what parameters it accepts? There is a problem here though. The link function should show a TypeScript error when trying to pass in a value it doesn't accept which it is not showing here. This is a little more misleading than it would have otherwise been since there isn't a ts error there. The good news is that this is fixed in type-route@next. One of the changes in type-route@next is how routes are built. Instead of calling routes.home.href(params) and routes.home.push(params) you'll call routes.home(params) which returns an object with href and push on it. This should make composing these in a custom way easier. The very much under construction @next docs have a page on this: https://typehero.org/type-route/docs/guides/custom-link-behavior. If you have a moment to review that and share your thoughts that'd be super helpful!

Ok, so that was just typings error.

Regarding the new API. What is the reasoning behind changing routes.home.link(params) to routes.home(params).link? I personally find:
home

cleaner/more straightforward than:
home

Creating custom Link component works (with old and new api) but it's not always feasible/ergonomic. For example: if you want to use a link component from some external library you will have to wrap that component into your own...
In my opinion it would be better if it was possible to specify onClick similarly to what I was initially trying to do:
 console.log("going home..."),
  })}
>
  home

// or
 console.log("going home..."),
  })}
>
  home

This adds a little bit of complexity (arguments passed to link function can have many "shapes") but completely removes the need of creating custom link wrappers and should work with all link components that utilize href & onClick props.

I did give some serious consideration to providing an API like you've mentioned. As I tested how it would work with different use cases, however, it became clear it wasn't a silver bullet. In scenarios where you want to perform some action along side the route update it works quite well. But, there may be situations where you want to provide custom code before pushing the new route and then maybe only do so conditionally. When running React in concurrent mode you may want to wrap the route update in the startTransition function to ensure any resulting calls to setState are part of the transition. Given these considerations I've landed on the recommendation to build out a custom Link component looking something like this when supporting more complex use cases is necessary:
import React from "react";
import { Route, preventDefaultClickBehavior } from "type-route";
import { routes } from "./router";

type Props = {
  to: Route<typeof routes>
  children?: React.ReactNode;
}

function Link(props: Props) {
  const { to, children } = props;

  return (
     {
        if (preventDefaultLinkClickBehavior(event)) {
          to.push();
        }
      }}
    >
      {children}

  )
}

Spreading the link object Home should still work for simple cases. With this recommendation for more complex use cases I feel like there's less of a chance of a use case not being expressible with the recommended pattern.
Recognizing the need to give the user ways to more easily build abstractions on top of Type Route (as in the above example) led me down the path of putting link / push / replace / href on the route object. Building a Link component would be more difficult with parameterized versions of link / push / replace / href. Correlating the route and parameters in a type safe way in the Props of the Link component would involve some ugly TypeScript gymnastics that would be great to keep out of user land code. That being said I too, at first glance, like routes.home.link() more than route.home().link. But I think its a worthwhile tradeoff. Hopefully that gives you a little more context! And @next hasn't landed yet so there's still room for changes.

Going to close this since the behavior doesn't appear to be a bug. Happy to continue discussing different approaches to the API though!

@elderapo if you have any feedback I just opened https://github.com/typehero/type-route/pull/39 which has some experimentation around making Type Route more tightly coupled to React.


Update diffusers default snippets to be complete.

Slack chat for ref: https://huggingface.slack.com/archives/C04PJ0H35UM/p1726563327331199?thread_ts=1725899853.249099&cid=C04PJ0H35UM

the failing tests are unrelated to this pr

Will wait for @sayakpaul or @apolinario to approve before merging!
Thanks @mishig25 for fixing the lint issues 🐐

Well constructed LoRA models have an instance_prompt variable which could be used in the example prompt, but I like the idea of taking the first gallery prompt if existing. IMO not overkill and would make the UX great  https://huggingface.co/multimodalart/vintage-ads-flux/blob/main/README.md?code=true#L9
Otherwise lgtm

Will follow up w/ showing Gallery prompts in a subsequent PR. Thanks for the reviews everyone!


1

Coverage remained the same at 41.41% when pulling 4595aba31aa3e2fd9a8b53595d7551671cf434e8 on 1 into 0ba2f8f9581471dfa0b371a8fdfbab0f38d0e3c9 on master.


Extend IAMQPWorker to accept a thread count to start

Just like one of its parent classes IWorker, we want to make sure that IAMQPWorker and its child classes take _nthread as an argument when calling Run().

It should be noted that the AMQPWorker does not in fact take a thread count parameter. It instead now takes an IWorker class which can then be started using however many threads. Each onReceived callback rather than call a ProcessMessage function will call worker->AddMessage. So the worker has to be created and instantiated by the user before being passed into the constructor for the IAMQPWorker.


[gui error report] Error: Cannot move 'C:\Users\itali.ipfs' to a subdirectory of itself, '

👉 Please describe what you were doing when this error happened.
Specifications

OS: win32
IPFS Desktop Version: 0.23.0
Electron Version: 19.0.9
Chrome Version: 102.0.5005.167

Error
Error: Cannot move 'C:\Users\itali\.ipfs' to a subdirectory of itself, 'C:\Users\itali\.ipfs\.ipfs'.
    at C:\Users\itali\AppData\Local\Programs\IPFS Desktop\resources\app.asar\node_modules\fs-extra\lib\util\stat.js:60:17
    at process.processTicksAndRejections (node:internal/process/task_queues:83:21)

Thanks for submitting this issue @ghost. Please attach your error.log and combined.log files so we can investigate further.
See https://github.com/ipfs/ipfs-desktop#where-are-my-ipfs-configuration-and-log-files to find your log files


Update updater.sh

is it important enough to increase the version number?

is it important enough to increase the version number?

IDK, is it? I wasn't sure myself that's why I didn't touch it.

when in doubt just do it :) let's go with a new version

you can merge it yourself but please always use "Squash and merge". Thanks


Customize the VM at boot time

Is your feature request related to a problem? Please describe.
Being able to customize VMs at boot is really important to automate deployments.
Describe the solution you'd like
Ideally it would be nice if it supports cloud-init as it is the defacto standard for this kind of thing. Also being able to use a yaml file to specify the commands, users, etc. and then orbstack should convert that into cloud-init (something similar to what lima does https://github.com/lima-vm/lima/blob/master/examples/k3s.yaml)
Describe alternatives you've considered
The alternative would be to use some tool such as ansible via ssh.
Additional context
None

Duplicate of #38. cloud-init will probably be how this is implemented.


TranslationWalker don't translate in some case

In the Class TranslationWalker, the method prepareTranslatedComponents() doesn't work correctly.
the line 327
.' = '.$this->conn->quote($meta->name);
should be replace by
.' = '.$this->conn->quote($config['useObjectClass']);
Because if you have a "CompanyBundle" having a class "Category" which own the translationMappedSuperclass\AbstractTranslation with the Class "CategoryTranslation".
And then have a "ClientBundle" which extends the class Category with a class ClientCategory (owning relations with more ClientBundle:Entities...).
if form the ClientCategory Repository i want to build some stuff using the:
$query->setHint(
\Doctrine\ORM\Query::HINT_CUSTOM_OUTPUT_WALKER,
'Gedmo\Translatable\Query\TreeWalker\TranslationWalker'
);
it will try to get the translation based on the entity name "ClientBundle\Entity\ClientCategory" and not "CompanyBundle\Entity\Category" as excpected in the field "object_class".
the result given is empty translated field (or the translated fallback).
this is why using $config['useObjectClass'] resolve this problem. As it give the real owner of the AbstractTranslation

hi, can you open a pull request referencing this issue?

Done.
https://github.com/Atlantic18/DoctrineExtensions/pull/1336
Hope it will be commited soon :P


db-sync fails to reconnect to the node after node is restarted

OS
Your OS: Linux
Versions
The db-sync version (eg cardano-db-sync --version): branch erikd/hf-integration commit a1f19fcd52895f7788c52c49be613f26fbc5e844
PostgreSQL version: 14.3
Build/Install Method
The method you use to build or install cardano-db-sync: cabal build
Run method
The method you used to run cardano-db-sync (eg Nix/Docker/systemd/none): none
Additional context
Using git commit ea202b7b21983140d1944ccfde8750b891b59699 of outoborous-network
Problem Report
If db-sync is running and the nod is restarted, then db-sync failed to reconnect correctly to the node and loops with the following error messages:
[db-sync-node:Error:48364] [2022-06-04 07:25:24.80 UTC] ChainSyncWithBlocksPtcl: libpq: failed (another command is already in progress)
[db-sync-node.Mux:Info:48361] [2022-06-04 07:25:24.80 UTC] Bearer on ConnectionId {localAddress = LocalAddress "", remoteAddress = LocalAddress "state-node-mainnet/node.socket"} event: State: Dead
[db-sync-node.Mux:Notice:48361] [2022-06-04 07:25:24.80 UTC] Bearer on ConnectionId {localAddress = LocalAddress "", remoteAddress = LocalAddress "state-node-mainnet/node.socket"} event: Miniprotocol MiniProtocolNum 5 InitiatorDir terminated with exception libpq: failed (another command is already in progress)
[db-sync-node.Subscription:Error:48360] [2022-06-04 07:25:24.80 UTC] Identity Application Exception: LocalAddress "../cardano-node/state-node-mainnet/node.socket" libpq: failed (another command is already in progress)
[db-sync-node.ErrorPolicy:Error:6] [2022-06-04 07:25:24.80 UTC] IP LocalAddress "../cardano-node/state-node-mainnet/node.socket" ErrorPolicyUnhandledApplicationException libpq: failed (another command is already in progress)
[db-sync-node.Subscription:Warning:51] [2022-06-04 07:25:24.81 UTC] Identity Failed to start all required subscriptions
[db-sync-node.Subscription:Notice:51] [2022-06-04 07:25:25.81 UTC] Identity Restarting Subscription after 1.027120268s desired valency 1 current valency 0
[db-sync-node.Subscription:Notice:51] [2022-06-04 07:25:34.80 UTC] Identity Starting Subscription Worker, valency 1
[db-sync-node.Subscription:Notice:48369] [2022-06-04 07:25:34.80 UTC] Identity Connection Attempt Start, destination LocalAddress "../cardano-node/state-node-mainnet/node.socket"
[db-sync-node.Subscription:Notice:48369] [2022-06-04 07:25:34.80 UTC] Identity Connection Attempt End, destination LocalAddress "../cardano-node/state-node-mainnet/node.socket" outcome: ConnectSuccessLast
[db-sync-node.Handshake:Info:48369] [2022-06-04 07:25:34.80 UTC] WithMuxBearer (ConnectionId {localAddress = LocalAddress "", remoteAddress = LocalAddress "state-node-mainnet/node.socket"}) Send (ClientAgency TokPropose,MsgProposeVersions (fromList [(NodeToClientV_9,TInt 764824073),(NodeToClientV_10,TInt 764824073),(NodeToClientV_11,TInt 764824073),(NodeToClientV_12,TInt 764824073),(NodeToClientV_13,TInt 764824073)]))
[db-sync-node.Handshake:Info:48369] [2022-06-04 07:25:34.80 UTC] WithMuxBearer (ConnectionId {localAddress = LocalAddress "", remoteAddress = LocalAddress "state-node-mainnet/node.socket"}) Recv (ServerAgency TokConfirm,MsgAcceptVersion NodeToClientV_12 (TInt 764824073))
[db-sync-node.Mux:Info:48369] [2022-06-04 07:25:34.80 UTC] Bearer on ConnectionId {localAddress = LocalAddress "", remoteAddress = LocalAddress "state-node-mainnet/node.socket"} event: Handshake Client end, duration 0.001244576s
[db-sync-node.Mux:Info:48370] [2022-06-04 07:25:34.80 UTC] Bearer on ConnectionId {localAddress = LocalAddress "", remoteAddress = LocalAddress "state-node-mainnet/node.socket"} event: State: Mature
[db-sync-node.Mux:Info:48370] [2022-06-04 07:25:34.80 UTC] Bearer on ConnectionId {localAddress = LocalAddress "", remoteAddress = LocalAddress "state-node-mainnet/node.socket"} event: Eagerly started (MiniProtocolNum 5) in InitiatorDir
[db-sync-node:Info:48373] [2022-06-04 07:25:34.80 UTC] Starting chainSyncClient
[db-sync-node.Mux:Info:48370] [2022-06-04 07:25:34.80 UTC] Bearer on ConnectionId {localAddress = LocalAddress "", remoteAddress = LocalAddress "state-node-mainnet/node.socket"} event: Eagerly started (MiniProtocolNum 6) in InitiatorDir
[db-sync-node.Mux:Info:48370] [2022-06-04 07:25:34.80 UTC] Bearer on ConnectionId {localAddress = LocalAddress "", remoteAddress = LocalAddress "state-node-mainnet/node.socket"} event: Eagerly started (MiniProtocolNum 7) in InitiatorDir
[db-sync-node.Mux:Info:48370] [2022-06-04 07:25:34.80 UTC] Bearer on ConnectionId {localAddress = LocalAddress "", remoteAddress = LocalAddress "state-node-mainnet/node.socket"} event: Eagerly started (MiniProtocolNum 9) in InitiatorDir
[db-sync-node:Error:48373] [2022-06-04 07:25:34.80 UTC] ChainSyncWithBlocksPtcl: libpq: failed (another command is already in progress

The only solution is to halt db-sync and restart it. Obviously this is not acceptable for a long running service like db-sync. This is also new behaviour. Previously db-sync would simply reconnect to the node.

Cannot reproduce this in the Byron era.

When the node dies:
[2022-06-07 09:41:40.92 UTC] Insert Shelley Block: epoch 230, slot 14307254, block 4975000, hash 43dd7b1cb0a20cb1278fa595c40d4e82724b7d6541318aa1ac3984761dc5000a
[2022-06-07 09:41:45.66 UTC] Bearer on ConnectionId {localAddress = LocalAddress "", remoteAddress = LocalAddress "state-node-mainnet/node.socket"} event: State: Dead
[2022-06-07 09:41:45.66 UTC] runDBThread: libpq: failed (another command is already in progress)
[2022-06-07 09:41:45.66 UTC] ChainSyncWithBlocksPtcl: AsyncCancelled

it immediately gives a "libpq failed" error.

This issue seems to be much more difficult to trigger in earlier epochs (I am currently at epoch 259) than in later epochs.

Instrumentation has not helped much so far, but looking at the code, the very first error is:
[2022-06-08 04:35:56.59 UTC] ChainSyncWithBlocksPtcl: libpq: failed (another command is already in progress)

which comes from from Cardano/DbSync/Sync.hs#L214 the line:
      liftIO . logException trce "ChainSyncWithBlocksPtcl: " $ do

What is odd is that that logging and re-throwing of the exception happens there and not in Cardano/DbSync/Database.hs#L53::
runDbThread :: SyncEnv -> MetricSetters -> DbActionQueue -> IO ()
runDbThread env metricsSetters queue = do
    logInfo trce "Running DB thread"
    logException trce "runDBThread: " loop
    logInfo trce "Shutting down DB thread"

Just noticed something odd, when the node disappears I see this in the db-sync logs:
[2022-06-09 11:43:41.66 UTC] Insert Alonzo Block: epoch 295, slot 42443855, block 6360000, hash 3e4fdbdbb6f6f3779b685b85979f7163ed873c8c9dc9713d6ce7dd374a0e0493
[2022-06-09 11:43:41.66 UTC] Offline pool metadata fetch: 7 results, 20 fetch errors
[2022-06-09 11:46:52.37 UTC] Bearer on ConnectionId {localAddress = LocalAddress "", remoteAddress = LocalAddress "state-node-mainnet/node.socket"} event: State: Dead
[2022-06-09 11:46:52.37 UTC] recvMsgRollForward: AsyncCancelled
[2022-06-09 11:46:52.38 UTC] runDBThread: libpq: failed (another command is already in progress)
[2022-06-09 11:46:52.38 UTC] ChainSyncWithBlocksPtcl: AsyncCancelled


[Snyk] Security upgrade fast-xml-parser from 3.21.1 to 4.2.4

This PR was automatically created by Snyk using the credentials of a real user.Snyk has created this PR to fix one or more vulnerable packages in the `yarn` dependencies of this project.
Changes included in this PR

Changes to the following files to upgrade the vulnerable dependencies to a fixed version:

package.json
yarn.lock

Note for zero-installs users
If you are using the Yarn feature zero-installs that was introduced in Yarn V2, note that this PR does not update the .yarn/cache/ directory meaning this code cannot be pulled and immediately developed on as one would expect for a zero-install project - you will need to run yarn to update the contents of the ./yarn/cache directory.
If you are not using zero-install you can ignore this as your flow should likely be unchanged.
Vulnerabilities that will be fixed
With an upgrade:

Severity
Priority Score (*)
Issue
Breaking Change
Exploit Maturity

661/1000  Why? Recently disclosed, Has a fix available, CVSS 7.5
Regular Expression Denial of Service (ReDoS) SNYK-JS-FASTXMLPARSER-5668858
Yes
No Known Exploit

(*) Note that the real score may have changed since the PR was raised.
Check the changes in this PR to ensure they won't cause issues with your project.

Note: You are seeing this because you or someone else with access to this repository has authorized Snyk to open fix PRs.
For more information:
🧐 View latest project report
🛠 Adjust project settings
📚 Read more about Snyk's upgrade and patch logic

Learn how to fix vulnerabilities with free interactive lessons:
🦉 Regular Expression Denial of Service (ReDoS)

fast-xml-parser have been updated in develop. We don't merge directly to main.


Allow clientID or projectID for backwards compatibility

https://linear.app/workos/issue/SDK-26/allow-clientid-or-projectid-in-nodets-interfaces
Allows for backwards compatibility with projectID or clientID in Node/TS interfaces

We probably want to make this same change to anywhere that uses a clientID or projectID (e.g., AuthorizationURLOptions).

We probably want to make this same change to anywhere that uses a clientID or projectID (e.g., AuthorizationURLOptions).

bors merge

bors merge


erythrocyte sedimentation rate terms

Add new term:
abnormal erythrocyte sedimentation rate (a child of abnormal blood homeostasis MP:0009642)
DEF: a deviation in the rate at which red blood cells (RBCs) descend under the influence of gravity in a vertical column of anticoagulated whole blood over a period of one hour; the rate at which RBCs settle out from the plasma is measured as the number of millimeters of clear plasma present at the top of the column after one hour (mm/hr); a non-specific measure of inflammation
SYN: abnormal blood sedimentation rate
SYN: abnormal ESR
SYN: abnormal Westergren sedimentation rate
SYN: abnormal sed rate
SOURCE: HP:0025021, http://www.medicine.mcgill.ca/physio/vlab/bloodlab/esr.htmnerythrocyte
Child terms:
decreased erythrocyte sedimentation rate
DEF: a reduction in the rate at which red blood cells (RBCs) descend under the influence of gravity in a vertical column of anticoagulated whole blood over a period of one hour; a decreased rate may be seen in polycythemia or in certain blood diseases in which RBCs have an irregular or smaller shape that causes slower settling
SYN: decreased blood sedimentation rate
SYN: decreased ESR
SYN: reduced erythrocyte sedimentation rate
SYN: low ESR
SOURCE: HP:0025022, http://www.medicine.mcgill.ca/physio/vlab/bloodlab/esr.htmnerythrocyte
increased erythrocyte sedimentation rate
DEF: an increase in the rate at which red blood cells descend under the influence of gravity in a vertical column of anticoagulated whole blood over a period of one hour; an elevated rate may indicate inflammation or may be caused by any condition that elevates fibrinogen
SYN: increased blood sedimentation rate
SYN: increased ESR
SYN: elevated ESR
SYN: high ESR
SYN: elevated sedimentation rate
SYN: elevated erythrocyte sedimentation rate
SOURCE: HP:0003565, http://www.medicine.mcgill.ca/physio/vlab/bloodlab/esr.htmnerythrocyte
Annotations in J:76695, J:158168

Added new terms:
abnormal erythrocyte sedimentation rate MP:0031061
decreased erythrocyte sedimentation rate MP:0031062
increased erythrocyte sedimentation rate MP:0031063


config(.travis.yml): add semantic release

:tada: This PR is included in version 0.13.0 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


[FIX] - Desk Took Crash (v2.18.0)

Error: Can only set one of children or props.dangerouslySetInnerHTML

This is fixed in the latest release, thanks for helping @avcohen!


Use paratest as the phpunit executable if present

This resolves #424 with a simpler solution of just using paratest as the phpunit runner executable if present

LGTM 🚀

when executing TestNearest now throws Option --filter is not implemented for non functional mode because of paratest.

Thank you for spotting this. I'll see what what is possible but another option that might be simpler is adding --functional for TestNearest with paratest


Not working for RTMP streams?

I copied the demo and it works using for vod(HTTP).
I tried to use for rtmp live stream.

Nothing was showed in the player.
Am I doing something wrong?

The Flash tech is not currently supported by the plugin. See issue #9 for a full discussion of why that is.


Adds Cheat Sheet category

Project URL
https://github.com/iwasrobbed/Swift-CheatSheet
https://github.com/iwasrobbed/Objective-C-CheatSheet
Description
Cheat sheets for Swift and Objective-C
Checklist

[x] Only one project / new category is in the request
[x] Addition in chronological order (bottom of category)
[x] Travis CI pass
[x] Supports iOS 7 or later
[x] Has a commit from less than 2 years ago
[x] Has a clear README in English

@vsouza  @dkhamsing what do you guys think?

Somewhere in good websites ?

I think CheatSheet should be together with Style Guides. IMHO

They aren't really style guides since they showcase design patterns and operators moreso than code formatting. Either way, just wanted to get the conversation started and will let you all decide 👍

@iwasrobbed my ideia was put CheatSheet as a subcategory of Style Guides. Not be together.

How about a category named Reference

@dkhamsing good idea

what u think @lfarah  ?

Sure!

@dkhamsing Renamed to Reference 👍

Looks good!

thanks guys ❤


allow changing folder in which app.py resides

This PR allows changing the folder in which app.py resides by setting APISTAR_FOLDER environment variable. If you wanted to allow changing the filename of app.py as well, you could supply the full path to the file and rename the environment variable to APISTAR_APP, more akin to flask.
fixes #258

I've not given this enough thought to okay it yet, but either way APISTAR_APP would be preferable, yup. 😀

sure, let me know. this issue is pretty important to me because I have so many files at the top level like Dockerfile, docker-compose.yml, docker-compose.override.yml, server.ini, requirements.txt, docs, envs, README.md, .python-version, .gitignore, and on and on and on...

hi @tomchristie, bumping this issue

I think I'd accept this if the env variable was APISTAR_APP, and the documentation noted it in the "Deployment > The Development Server" section.
In the meantime you can use the if __name__ == '__main__': app.main() pattern, and invoke the app.py directly with Python.
We might want to rethink the apistar cli more thoroughly in the future, but this will do for now.

This PR would make only apistar run works or test too? I'm asking this becouse the if __name__ == '__main__': app.main() approach doesn't works for running the tests.

@rougeth I think it should affect tests too

Great @AlJohri!! :)

Ah, that’s unfortunate. Hopefully we can make it depend on the same variable

@AlJohri any updates on this? Did you saw that @tomchristie asked to change the name of the variable from APISTAR_FOLDER to APISTAR_APP? This would be reaaally useful here, let me know if you need help.

I'll check it out - I'm not that experienced with the codebase but we basically need to get the APISTAR_APP into the apistar.commands.test method, probably through DI of some sort. I can also just do another os.getenv but it would probably be best to set it at initialization time and use it throughout

@AlJohri I believe making apistar test aware of APISTAR_APP variable is another issue (if I understood correctly, you're talking about the tests, right?).  At my particular case, the way it is right now works. We could work on tests after that.

@rougeth I think its sort of related since I want to set the value of APISTAR_APP at some initialization stage so it can be used throughout (including within tests), but to get things moving I've  added a small change to use APISTAR_APP instead of APISTAR_FOLDER.
I'll update the docs the next chance I get

Why not allowing to give a module to apistar, like apistar run mypackage.app? It would allow people to move api.py to a package, name it as they want, and to import the package from their tests?

The workaround of using if __name__ == '__main__': app.main() requires the top level directory at the PYTHONPATH. Even if it is on the path, the workaround fails if relative imports to a parent package are used.
I agree to use some APISTAR_APP environment variable pointing to the App object, but it isn't really a variable, it is fixed. The App object remains the same across deployments, environment variables are supposed to hold values that can change possibly.
The problem that this issue address is to be able to run the app from anywhere. So I guess that is better to stick with the gunicorn approach:
gunicorn webapp.somemodule:app \
    --worker-class=meinheld.gmeinheld.MeinheldWorker.

Rendering something like:
apistar run myapp.gateway.app:app

gunicorn uses import_app() (somewhat similar to the PR) to acquire the application object using the "package.module:object" notation.
#350 is related to this. This issue made impossible for me to use the apistar run command in debug mode. What can I do?

hi all, sorry I don't have time to finish this PR as I haven't actually used apistar in any projects yet. will revisit this if I ever try apistar again. please feel free to open a new PR

My workaround was simply
from werkzeug.serving import run_simple
from mypackage.app import app

run_simple('<IP_ADDRESS>', 8080, app)


Autocrop

Sometimes pp.autocrop() does not yield any cells, e. g. if a core is empty, which leads to issues downstream. Need to add appropriate handling that prohibits autocropping if something like this happens.

Fixed in #85, was simply solved by removing the clear_border() function.


Large DataViewJS queries won't render in time

If the DataViewJS queries are large or time-intensive to process, they won't get parsed into the DOM fast enough for the script to export it as Markdown data. :(

The issue is most likely related to the fact, that the pipeline for evaluating Javascript data is not truly asynchronous. See Publisher.ts and how the function from obsidian-dataview library processes it

I seem to encounter the same issue. However, for me, even simple dataviewjs queries are not rendered correctly. An example query:
dv.table(["mtime", "link"],
	dv.pages('-"templates"')
	.where(p => p.file.name === "Python")
	.map(p => [
 		p.file.mtime,
 		p.file.link
	])
)

Published result:

This is happening to me, too. Any ideas why?
dv.list(
    dv.pages().where(p => p['dg-publish'] && p.title)
        .sort(p => p.title)
        .limit(20)
        .map(p => `[[${p.file.name}|${p.title}]]`)
);

I've just released a new version, that should fix the issues you are having. Let me know if it works after updating or if it's still an issue.

The dataviewjs renders properly now! However, seems like the links are not written correctly. If the dataviewjs in note A contains a link to note B, the link is pointing to A/B.md. Can anyone confirm this?

Yep you are right. I should have mentioned it here. Links from dataviewjs doesn't work yet. When generating normal dataview queries, we are able to generate markdown, and the plugin can handle linking it correctly. But when running dataviewjs queries, we are actually producing HTML, and the plugin currently doesn't pick up on html links to other notes, and so doesn't process them and point them to the correct URL.   There's an issue tracking it here: #346

Thanks for the information @oleeskild !

This has now been fixed in the latest version of the template. Updating the template to version 1.57.0 or later should result in all dataviewjs links behave similar to other links.

Works perfectly, thanks!! @oleeskild


Exception with tzlocal

The tzlocal pip package was just updated to the version 4.0.
It seesm that in this version you should define explicitely your timezone, if not it raise an exception like
tzlocal.utils.ZoneInfoNotFoundError: 'Multiple conflicting time zone configurations found

@ciakkarino @flaviussn Is this still a problem?.
And, if it is, could any of you provide the shortest possible Python code to reproduce this issue? It is not clear to me if, when you say you should specify your timezone, you mean at the ssytem level or something else.

Hi Gallaecio, I installed the latest version of dateparser and tzlocal and now everything works fine.
So it's not anymore a problem :)


Warning: count(): Parameter must be an array or an object that implements Countable

Hey there,
I get the following errors when I enter any console commands in symfony 5.
In DebugCommand.php line 55:
Warning: count (): Parameters must be an array or an object that implements Countable
after debug I was able to determine that this is due to the contentful package.
In DebugCommand.php in line 55, "count" is used to check whether the entry of the "client-name" argument should be a mandatory field or an optional field. Php 7.4 doesn't like that :)
This happens if the contentful client is not initialized !!
    # vendor\contentful\contentful-bundle\src\Command\Delivery\DebugCommand.php::__construct (line 55)
        $this->addArgument(
            'client-name',
            \count($this->clients) > 1 ? InputArgument::REQUIRED : InputArgument::OPTIONAL,
            'The name of the client to use'
        );

Would be great if you could improve that. A solution could look like this:
        $this->addArgument(
            'client-name',
            !is_null($this->clients) && \count($this->clients) > 1 ? InputArgument::REQUIRED : InputArgument::OPTIONAL,
            'The name of the client to use'
        );

Thanks in advance
greetings
Env:
php 7.4.10
symfony 5.2
contentful/contentful-bundle 6.1.0

Hi marlord,
thanks for reporting this issue - and directly proposing a fix ;)
I'll integrate that in the next release. However, as I'm just taking over the maintenance of this repo at the moment, this might take a bit (I'd estimate ~2 weeks) - I hope this works for you. Thank you!

Hi @marlord ,
I've just implemented a fix for this. Would you mind checking out the version dev-issue-51 to check whether the fix works for you before I merge it into master?
Thank you! :)

This is fixed with version 7.0


TODO's and due dates

When a due date is set for a TODO, then it would also be useful to get some sort of notifications somewhere, otherwise it's not easy to keep track of your TODO's. Even a simple page with an aggreagate list of TODO's would do the job.

@gperu: You can see a list of upcoming TODOs in the timeline on top of the dashboard. Is it not showing up? Or do you perhaps need to view more than two weeks ahead?

@gperu can you update on the status of this issue?


Cleanup CHANGELOG-3.0

Description
This PR removes items from CHANGELOG-3.0 that have been backported to 2.x
Related Issues
Related to recent PR that created CHANGELOG-3.0: https://github.com/opensearch-project/OpenSearch/pull/13040
Check List

[X] New functionality includes testing.

[X] All tests pass

[X] New functionality has been documented.

[X] New functionality has javadoc added

[X] Failing checks are inspected and point to the corresponding known issue(s) (See: Troubleshooting Failing Builds)
[X] Commits are signed per the DCO using --signoff
[X] Commit changes are listed out in CHANGELOG.md file (See: Changelog)
[X] Public documentation issue/PR created

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Any idea why the gradle check failed? The last line is Finished: SUCCESS.

Any idea why the gradle check failed? The last line is Finished: SUCCESS.

Looks like extracting from the log didn't work.
parse error: Invalid numeric literal at line 4, column 14
parse error: Invalid numeric literal at line 4, column 14
parse error: Invalid numeric literal at line 4, column 14
parse error: Invalid numeric literal at line 4, column 14
parse error: Invalid numeric literal at line 4, column 14
parse error: Invalid numeric literal at line 4, column 14
parse error: Invalid numeric literal at line 4, column 14
parse error: Invalid numeric literal at line 4, column 14
parse error: Invalid numeric literal at line 4, column 14
parse error: Invalid numeric literal at line 4, column 14
Workflow running status :Attempt 1/10 failed. The jq processing failed with exit code: 4. Retrying...

Let's see if this reproduced itself or was a fluke. It could be that we got a broken log from Jenkins.

❌ Gradle check result for 50e1e74: null
Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

org.opensearch.cluster.coordination.AwarenessAttributeDecommissionIT.testConcurrentDecommissionAction
https://github.com/opensearch-project/OpenSearch/issues/12197

Thanks a lot @cwperks !

Thanks @cwperks! Should we also add these entries into CHANGELOG.md?


auro-button: unstyled, icon only varient

Is your feature request related to a problem? Please describe.
Several of our other components use raw HTML  tags to create clickable elements and place an icon inside of them. These buttons are providing incomplete and inconsistent experiences.
Describe the solution you'd like
I would like to see a varient of auro-button that that has no content styles and is for use with auro-icon as the slot content. This varient would simply pass down the state variations (e.g. disabled) to the slot content auro-icon and use the variant styles of that component.
This would simply the CSS code for parent components like Drawer and Dialog and provide that consistent user experience our customers expect.
Describe alternatives you've considered
Do nothing and leave it as it is.
Additional context
No response
Exit criteria
To be determined by triage process and the team.

The work for this is a part of the v7.3.0 release and this ticket can therefore be closed.


Missing functions like 'average'

I was wondering if there is something somewhere even though it's not working like numpy
> squareArray
[ [ 1, 2, 3 ], [ 4, 5, 6 ], [ 7, 8, 9 ] ]
> let sqAverage = nj.average(squareArray)
TypeError: nj.average is not a function

Right okay great again sorry (for the eager Noob effect) it's all in there! I was just thinking it would be similar to numpy (cut and pasting from tutorial run through), and hopeful that it does do everything needed. It certainly doesn't have to be syntactically exact. It just confused me out of the gate.
I will read through the excellent documentation. Loving it!


Demo is broken

ReduxInfiniteScroll is not defined because you removed script in the index.html due to this commit (https://github.com/RealScout/redux-infinite-scroll/commit/c182dd032fd930bfc80f7928236dfb44254c74cf)

Unfortunately we never got around to having a functioning demo page. See the readme for usage instructions.


linux: uv_cpu_info may abort when cpu offline during the procedure

Version: 1.43.0
Platform: Linux my-localmachine 4.9.151.x86_64 #1 SMP Tue Mar 12 19:10:26 CST 2019 x86_64 x86_64 x86_64 GNU/Linux

uv_cpu_info read /proc/stat twice, first reading the CPU count, then rewind in the read_times and read the detailed stats. This may be a problem when any of the CPU core is offline between those two reads: read_times asserts that it read the same number of CPU before the rewind.
Expected behavior: uv_cpu_info should not abort when any of the CPU cores go offline.

Duplicate of https://github.com/libuv/libuv/issues/2351

Closing as duplicate.


Including both values and catergory values for OF36 - 43

Many indicators look at the range for OF 112 - 180 (see other issues flagged). In the batch calculator these questions contain both the raw value ie 0.45 and a 1 in the catergory in which it belongs (ie 0.35 - 0.47 = 1). This seems to be double counting values , so they either need to be converted from catergory or the raw value removed.

After discussions with P, this should only include the category and not the values. Values are retained only for the QA check


feat(nuxt): allow disabling default color for <NuxtLoadingIndicator>

🔗 Linked issue
resolves #12407 ( without default color)

❓ Type of change

[ ] 📖 Documentation (updates to the documentation or readme)
[x] 🐞 Bug fix (a non-breaking change that fixes an issue)
[x] 👌 Enhancement (improving an existing functionality like performance)
[x] ✨ New feature (a non-breaking change that adds functionality)
[ ] ⚠ Breaking change (fix or feature that would cause existing functionality to change)

📚 Description
I've added an option to pass false  to the color prop.
When disabling the prop: no color will be specified. and If the user adds a custom background-color: it will be applied.
so issue #12407 will be solved like this:
<template>
  <NuxtLoadingIndicator :throttle="0" :height="2" :color="false" class="bg-orange" />
</template>

📝 Checklist

[x] I have linked an issue or discussion.
[x] I have updated the documentation accordingly.

This looks good - thank you!

Most Welcome !
Officially, this is the first Contribution to Nuxt! and I hope it won't be the last.
Huge thanks for your efforts

It seems to solve my issue completely.
Thank you for your contribution :+1:


Malware Domain List is obsolete

The last entry was made 3.5 years ago...
see https://www.malwaredomainlist.com/mdl2.php?inactive=&sort=Date&search=&colsearch=All&ascordesc=DESC&quantity=1
I think its safe to remove.... it was also dropped by uBO, see https://github.com/uBlockOrigin/uBlock-issues/issues/984
Cheers

This is a duplicate of Issue #1044.  See in particular, the comments at the end of the issue.
The assertion that malwaredomainlist.com hasn't been updated in 3.5 years is observably incorrect.  Is it as active as we would like?  No.  Is it obsolete?  No.
Closing.

See in particular, the comments at the end of the issue.

The list was not "updated" in January. One domain was removed. That does not meet the minimum quality standard for an update IMO. No new domains have been added for 2 years according to the maintainer of Nano Adblocker. (https://github.com/uBlockOrigin/uBlock-issues/issues/984#issuecomment-612058511)
https://github.com/uBlockOrigin/uAssets/commit/5ad7faaf9e0337e114ea151f5ef6bb5d6b8ccd8f#diff-53fe5504d16f8ca7c58a72186493bdef


Set default_transaction_read_only when connecting to PostgreSQL

Yes, we should all be making sure that tegola connects from a database user who only has SELECT access, but how many of us are doing that? ;)
default_transaction_read_only makes sure that a style bug can't escalate to altering data in the database
With libpq this could be done with either SET default_transaction_read_only = TRUE or setting options=-c default_transaction_read_only=true.
With pgx this could either the SQL or setting RuntimeParams of the ConnConfig
c.f. mapnik/mapnik#2142

I think this would be a good thing to add.
We would just need to add the option here:
https://github.com/go-spatial/tegola/blob/master/provider/postgis/postgis.go#L141
RuntimeParams: map[string]string{
               "default_transaction_read_only" : "TRUE",
}

Postgress documentation:
https://www.postgresql.org/docs/9.2/static/sql-set.html
https://www.postgresql.org/docs/9.2/static/sql-show.html
https://www.postgresql.org/docs/9.2/static/runtime-config.html
https://www.postgresql.org/docs/9.2/static/runtime-config-client.html


message_feed_ui: Remove mute/unmute from message actions menu.

Based on the CZO discussion, the mute/unmute topic is a topic action instead of a message action, which is contrary to it being present in the message action menu. There are more natural and space saving ways to implement it.
For reference:
CZO Discussion
GitHub Issue: #21432
Testing plan:

Open the message action menu
Check for the presence of mute/unmute in action menu.

GIFs or screenshots:

Before
After

Playing with the PR, looks good!

@alya thank you!

Merged, after rewriting the commit message for the first commit to summarize the motivation for the change. I know that detail is in the issue, but it greatly improves readability to give the analysis motivating each commit. (And I found it necessary to write that in order to think through whether merging this would break anything).

@alya FYI; I confirmed that https://zulip.com/help/mute-a-topic did not mention this method for muting/unmuting a topic already.


TF version, Keras version

which version of TF and Keras for the examples of optuna ?

The examples are tested with the latest versions available in PyPI.
https://github.com/pfnet/optuna/blob/master/.circleci/config.yml#L183
If you find out any compatibility issue, please kindly let us know.