Funding tx cannot be found; hanging in pending open

Autopilot enabled !
Opens a channel to ln1.satoshilabs.com which hangs in pending open
0279c22ed7a068d10dc1a38ae66d2d6461e269226c60258c021b1ddcdfe4b00bc4
The Funding tx cannot be found
https://blockstream.info/tx/db94d2ffd17c166686d291f56f64d665ff4d0f1a13462200483d3f0ae17de821
How can I cancel this request ?

Would be nice to have a timeout ?

If a channel is in pending open state then it means that lnd is in the process of opening it. Perhaps in your case it hasn't broadcast the transaction for some reason. What version of lnd are you using?

If a channel is in pending open state then it means that lnd is in the process of opening it. Perhaps in your case it hasn't broadcast the transaction for some reason. >>What version of lnd are you using?

I was using Zap 0.4.1 Beta when the problem showed up (with autopilot enabled, which consumed all my remaining capacity !); then a few days ago upgraded to Zap 0.5.0 Beta
I use ZAP standalone, not connecting to a external lnd !

Could you try to locate the raw entry from lnd using lncli pendingchannels please?
You can run lncli against the Zap lnd by passing in the correct path. Something like:
lncli --lnddir=/Users/tom/Library/Application\ Support/Zap/lnd/bitcoin/mainnet/wallet-1/ pendingchannels

Sorry, I have problems with your recommendation.
My stuff seems to be in this directories:
C:\Users\wdey\AppData\Roaming\Zap\lnd\bitcoin\mainnet\wallet-3\logs\bitcoin\mainnet
Could you please provide me the correct lndcli command ?

I'm not sure on the exact details for windows, but based on your path above it would look something like this:
lncli --lnddir=C:\Users\wdey\AppData\Roaming\Zap\lnd\bitcoin\mainnet\wallet-3 pendingchannels

C:\Users\wdey\AppData\Local\Lnd\bin>lncli --lnddir=C:\Users\wdey\AppData\Roaming\Zap\lnd\bitcoin\mainnet\wallet-3 pendingchannels
[lncli] rpc error: code = Unavailable desc = all SubConns are in TransientFailure, latest connection error: connection error: desc = "transport: Error while dialing dial tcp <IP_ADDRESS>:10009: connectex: No connection could be made because the target machine actively refused it."

You need to have the wallet open and unlocked

The wallet is open ! how must I unlock ?
Here the content of some directories:
Verzeichnis von C:\Users\wdey\AppData\Roaming\Zap\lnd\bitcoin\mainnet\wallet-3
10.05.2019  19:18              .
10.05.2019  19:18              ..
10.05.2019  19:18              data
10.05.2019  19:18              logs
10.05.2019  19:18               944 tls.cert
10.05.2019  19:18               227 tls.key
2 Datei(en),          1'171 Bytes
4 Verzeichnis(se), 13'448'679'424 Bytes frei
Verzeichnis von C:\Users\wdey\AppData\Roaming\Zap\lnd\bitcoin\mainnet\wallet-3\data\chain\bitcoin\mainnet
22.07.2019  16:29              .
22.07.2019  16:29              ..
10.05.2019  19:18               252 admin.macaroon
22.07.2019  16:02        46'924'320 block_headers.bin
02.07.2019  17:50                83 chainnotifier.macaroon
22.07.2019  16:29               801 channel.backup
10.05.2019  19:18               115 invoice.macaroon
02.07.2019  17:50                91 invoices.macaroon
22.07.2019  16:29            32'768 macaroons.db
23.07.2019  12:20        67'108'864 neutrino.db
23.07.2019  12:19            14'407 peers.json
10.05.2019  19:18               183 readonly.macaroon
22.07.2019  16:02        18'769'728 reg_filter_headers.bin
02.07.2019  17:50                91 router.macaroon
02.07.2019  17:50                86 signer.macaroon
23.07.2019  12:20        67'108'864 wallet.db
02.07.2019  17:50               114 walletkit.macaroon
15 Datei(en),    199'960'767 Bytes
2 Verzeichnis(se), 13'301'682'176 Bytes frei

Ah yes, the problem is that we run lnd on port 11009 rather than the default 10009 so you will need to specify that in your command:
lncli --lnddir=C:\Users\wdey\AppData\Roaming\Zap\lnd\bitcoin\mainnet\wallet-3 rpcserver=<IP_ADDRESS>:11009 pendingchannels

Voila !
C:\Users\wdey\AppData\Local\Lnd\bin>lncli --lnddir=C:\Users\wdey\AppData\Roaming\Zap\lnd\bitcoin\mainnet\wallet-3 --rpcserver=<IP_ADDRESS>:11009 pendingchannels
{
"total_limbo_balance": "0",
"pending_open_channels": [
{
"channel": {
"remote_node_pub": "0279c22ed7a068d10dc1a38ae66d2d6461e269226c60258c021b1ddcdfe4b00bc4",
"channel_point": "db94d2ffd17c166686d291f56f64d665ff4d0f1a13462200483d3f0ae17de821:1",
"capacity": "250052",
"local_balance": "241002",
"remote_balance": "0"
},
"confirmation_height": 0,
"commit_fee": "9050",
"commit_weight": "600",
"fee_per_kw": "12500"
}
],
"pending_closing_channels": [
],
"pending_force_closing_channels": [
],
"waiting_close_channels": [
]
}
C:\Users\wdey\AppData\Local\Lnd\bin>

Thanks @wdey . As suspected this confirms that for some reason the channel is stuck in pending open state in lnd itself.
Since the problem is in lnd and not Zap (zap is just a UI on top of lnd) I'd recommend that you take this raw lnd data and share with the guys in lnd slack or their github and see if they can diagnose why that might be.

Thanks @mrfelton !
see https://github.com/lightningnetwork/lnd/issues/3340

This is the solution, see
https://github.com/lightningnetwork/lnd/issues/3340? and below
Q. I am using the embedded lnd of ZAP; could you make available a lnd-debug binary with the ZAP distribution, or is this already the case ?
Looks like this is just an invalid channel as a result of likely double spending an input. In the future we'll be able to detect this and remove it. For now, you should be able to remove it with the ### lncli abandonchannel command available in a debug build of lnd. You can obtain one by running make in lnd's source directory, which will create a lnd-debug binary. If the you believe the funds have actually been committed, you'll have to force a wallet rescan.

I didn't get an answer to my above questions; to recover my sat's, I would Need to issue this command. Andy advice is appreciated !

Hey, sorry about that. The issue was closed automatically when #2613 was merged.

Q. I am using the embedded lnd of ZAP; could you make available a lnd-debug binary with the ZAP distribution, or is this already the case ?

I'm going to say no to this. We don't include the lncli binary and I don't want to bloat our builds with another binary that isn't used anywhere in the app. You can build your own debug version of lnd for this: https://github.com/lightningnetwork/lnd/blob/master/docs/INSTALL.md

Isn't it the debug build of lnd, not lncli ?
Anyway, would it work, just to replace your lnd with the debug-lnd ?

Isn't it the debug build of lnd, not lncli ? Anyway, would it work, just to replace your lnd with the debug-lnd ?

No, lncli is different from lnd:
lnd - the daemon (we bundle this)
lncli - the cli
You need to use a debug build of lncli (which gets created when you build lnd). lncli is the command line interface to lnd.

(you may also need to replace our binary - I'm not certain on this)

It seems that lncli and lnd are to be replaced
lncli abandonchannel - Abandons an existing channel.
USAGE:
lncli abandonchannel [command options] funding_txid [output_index]
CATEGORY:
Channels
DESCRIPTION:
Removes all channel state from the database except for a close
summary. This method can be used to get rid of permanently unusable
channels due to bugs fixed in newer versions of lnd.
Only available when lnd is built in debug mode.
To view which funding_txids/output_indexes can be used for this command,
see the channel_point values within the listchannels command output.
The format for a channel_point is 'funding_txid:output_index'.
OPTIONS:
--funding_txid value  the txid of the channel's funding transaction
--output_index value  the output index for the funding output of the funding transaction (default: 0)

I am frustrated; to solve my Problem, I would go and start digesting all the steps for building lnd from source.
I you could provide me 2 exe files lnd/lncli with debug flag, I could copy them to the proper location and try it.


[STA-948] Add disallowed expenses

Description
Add tax types and report tax types for Disallowed Expenses tax rates in the Singapore region.
Release Notes
New tax rates are being introduced for compliance reasons

Screenshots (if appropriate):
Types of Changes

[ ] Bug fix (non-breaking change that fixes an issue)
[x] New feature (non-breaking change that adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)

@MichaelTranXero I see you have moved the PR back to Draft. Is it not ready for release?

@MichaelTranXero I see you have moved the PR back to Draft. Is it not ready for release?

I've just marked it ready for release


Discuss order of tutorials

We should discuss the order of our new tutorials. When merge conflicts in #1084 are solved, we have something like
    "Introduction to DG methods"
    "DGSEM with flux differencing"
    "Shock capturing with flux differencing and stage limiter"
    "Non-periodic boundaries"
    "Structured mesh with curvilinear mapping"
    "Adding a new equation"
        "Scalar conservation law"
        "Nonconservative equation"
    "Differentiable programming"
    "Unstructured meshes with HOHQMesh.jl"

Some possibilities could be

chronological (like DealII)
based on the "complexity" or "difficulty"
based on the topic
something else

I would prefer a sorting based at first on the topic, then on the complexity. We should also make sure to have some links to other sections (like "further reading" sections). Such a sorting might look like
    # Topic: DG semidiscretizations
    "Introduction to DG methods"
    "DGSEM with flux differencing"
    "Shock capturing with flux differencing and stage limiter"
    "Non-periodic boundaries"
    # Topic: equations
    "Adding a new equation"
        "Scalar conservation law"
        "Nonconservative equation"
    # Topic: meshes
    "Structured mesh with curvilinear mapping"
    "Unstructured meshes with HOHQMesh.jl"
    # Topic: other stuff
    "Differentiable programming"

What do you think?
CC @bennibolm @trixi-framework/principal-developers

Sounds good to me 👍
Is the "equations" topic likely to get any more entries? If not, it might be worthwhile to consider making both tutorials a first-class citizen, e.g.,
...
# Topic: equations
    "Adding a new scalar conservation law"
    "Adding a nonconservative equation"
...

We discussed adding something like the KPP stuff (2D, one elixir setup). But I don't have a strong opinion and we can just flatten the structure.

I like this structure as well.
After solving merge conflicts, there is another tutorial about AMR (#1025). It would fit above or below non-periodic boundaries.
For the KPP elixir, Gregor Gassner suggested to just add a note and a link at the end of “Adding a new scalar equation”. Then, I also prefer the flat structure.

After solving merge conflicts, there is another tutorial about AMR (#1025). It would fit above or below non-periodic boundaries.

Adaptive mesh refinement would also fit well to the "meshes" topic, either before or after the curved stuff.

For the KPP elixir, Gregor Gassner suggested to just add a note and a link at the end of “Adding a new scalar equation”. Then, I also prefer the flat structure.

Sounds good to me. Please go ahead with flattening the structure and adding such additional remarks/links.


Unable to infer prop types - Doesn't work with NativeWind

When using this library I'm unable to infer the prop types for the AnimateableText component.
I'm also unable to use this component with NativeWind, which is quite a bummer. I'd be happy to help contribute these changes if someone could point me in the right direction here - I haven't dabbled too much with the raw native side of RN

Hello @billyjacoby
can you explain what do you mean by infer the types. is there an example that you can show. do you mean something like typeof AnimatedText ?
about NativeWind, I have minimal experience with it, can you share with us an example of what doesn't work and what is the expected behaviour, this will be a great help.


.babelrc file

I just used the repo to get a foundation thru git clone. I had some issues with babel and then realized the dotfile for babel doesn't exist here. Once I added that everything worked as your directions stated but might be good to add that in README.
{ "presets": ["es2015"] }

fixed in the latest commit


Symbolic representation issue

Great work!
However, the representation on Page 5:

is not similar to Table 4:

I thought the latter ones were correct.
Thank you!

Yes, the expression in Table 4 is correct. Thank you for pointing this out!


I added the video link to the CHAOSS working groups

Hi @geekygirldawn could you please review this? Thank you

@frontEndDoctor  Thanks so much. Let me know when you will be free for the recording so I can book a slot for you.
We normally use Fridays and Mondays or Weekends, Anyone that works for you.

I will be re-assigning this issue, thanks @frontEndDoctor  for your effort in working on this


File->Delete

Title format
(Isn't it safer to have this option removed? If someone really wants to delete his wallet file he should do it manually. This way you wont have accidental deletions)

Regarding the title:
The title is generate by QT. But i agree, it looks bad. I will change it to a fixed string.
Regarding wallet deletion:
The user should be able to delete it from the UI without messing around in the filesystem and accidentally delete/corrupt more then just one wallet.
But i agree that a single "Question" dialog is not enough to show the importance of this decision.
I will change the icon to an exclamation mark and add a second dialog as a security layer.


BE unit tests can not be compiled and run in be_refactor branch

Describe the bug
In be_refactor branch, BE unit tests can not be compiled and run because of the refactor. It is required to amend them.

Fixed by #887


Add Cake script to "Add" file menu

Similar to #75, I'm not sure if this is a job that the extension can do, but it would be great if the list that appears on adding a new file included an item for creating a Cake build script.

probably related to #55, #75

probably related to #55, #75

This was implemented in #106 as part of #55


The best framework!

Just wanted to say, keep up the good work, the best live stream framework I have found so far, makes thing easier than ever... Thank you 👍

Thank you for your recognition and encouragement.


intuitive play button labelling

The button to play back the recordings of gestures works fine, but it doesn't say "Play" before you hit it.

It takes time between hitting record and then picking up and playing an instrument. I wonder if the start of the recording could be triggered by the beginning of the audio (or if the onset of audio could cause silence to be deleted up to that point, either live or later).

The button to play back the recordings of gestures works fine, but it doesn't say "Play" before you hit it.

Maybe reversing the  "Play" and "Stop" signs can help?

It takes time between hitting record and then picking up and playing an instrument. I wonder if the start of the recording could be triggered by the beginning of the audio (or if the onset of audio could cause silence to be deleted up to that point, either live or later).

That's a good idea, I can add it to the next version. or maybe give 3 seconds countdown after hitting the "record" button?

Updated in the v0.25 release

Updated in the v0.25 release


Enable the consumer to create new widgets

In theory, the initialization of widgets in core.clj could be deferred via mutlimethods. This would allow a consumer of the library to create and hook in their own widgets.

This is now made easier without using mulimethods.
See https://github.com/MikeHardIce/strigui-sample  (stacks is created outside of strigui)


Add more apps to CI tests

This isn't ready for a merge yet as it looks like the tests are too much for teamcity.  It looks like cockroachdb is shutting down after "FATAL: disk stall detected: unable to sync log files within 30s".

@rohany, maybe you can help debug why cockroachdb terminates? I've seen an issue on my machine where when running cockroach with --store=type=mem, memory isn't reclaimed until the server shuts down. Possibly this could be related? I don't think it's a particular Django app that's triggering this but merely running a lot of tests in one build.

Does this repro when you don’t use that flag? I guess it would slow tests down a good amount. We have some commands to help speed up tests suites which I can try to hook in tomorrow.

Sorry if I sidetracked things. That issue isn't actually a problem for me as I have plenty of memory... and the teamcity build isn't using --store=type=mem. Thanks for looking at this... not particularly urgent until we want to run as many tests as we can.

I added a commit to use a branch of Django which includes https://github.com/timgraham/django/commit/a204f21b68e18388098ecaaa982b422c96109de3. This speeds up the tests tremendously and allows the build to finish, however, it creates some new TransactionManagementError test failures which I haven't investigated.


wss/ssl problem -  Continuous frame sequence was not started.

Hi guys, i have a problem using the web socket server when i turn on the ssl
i can connect properly to the server but after few packets sent to the websocket server i get
on Socket Error java.nio.BufferOverflowException
on Socket Error org.java_websocket.exceptions.InvalidDataException: Continuous frame sequence was not started.

sometime instead i receive
on Socket Error org.java_websocket.exceptions.InvalidFrameException: bad rsv 4
or
on Socket Error org.java_websocket.exceptions.InvalidFrameException: bad rsv 1
the error seems to be more evident or easy to be reproduced with large packets, but even chunking the packets in smaller ones, it is present.
the problem is not dependent on the code itself, it's easy to be reproduced with just a dummy client which sends bytes.
i created the SSLContext like this
https://github.com/TooTallNate/Java-WebSocket/blob/master/src/main/example/SSLServerExample.java
i created the jks file from the .crt one because i could not find a way to directly load that and apply the RSA key. In addition i so that in your example there was the usage of jks so i guessed it as common practice.
any clue ?
thank you

Hello @GalloTeo,
do you still have this issue with the most recent lib version?
Which draft are you using?
Personally I dont have any issues with wss in my IDE and in production.
Greetings
marci4

Cannot reproduce.
No feedback.
Probably fixed with some commits.
Closing.
Greetings
marci4


Show count and percentage in distribution pie chart tooltip

[ ] Show the count and the percentage value in the toolip like "United States 60% (450 peers)
[ ] Make title a link to the peers page

This is causing confusion, see: https://github.com/ipfs-shipyard/ipfs-webui/issues/846
I am bumping up the priority.

@fsdiogo this one is an easy win


Is there any way/ API exposed to know callhome connection status?

Hi Michal
Is there a way/ API exposed(sysrepo,libnetconf,netopeer-server anywhere?) to monitor established callhome connections? We , in code, are writing into sysrepod running datastore to configure callhome and having netopeer notified to build callhome connections.
We want our application monitor callhome connections and take appropriate actions.
-Rajib

Hi Rajib,
no, there is currently nothing to allow you to monitor Call Home sessions. We designed libnetconf2 based on the server schema draft (I know there is a newer revision, we will be updating it if some important changes are made), which actually defines exactly how the server should behave in which situation. Currently, the new session is given to the application using a callback and it can do what it wants with it (netopeer2 main.c:np2srv_new_session_clb). That is the place to add actions on a new session creation. When the session is disconnected for whatever reason, libnetconf2 does not do anything. Only when you free this session, a new session is tried to be established based on the Call Home settings. So, before calling nc_session_free() (netopeer2 main.c:np2srv_del_session_clb), you can do what you want. I am thinking now that this is perhaps not the correct behavior and the session should be reestablished as soon as the current one disconnects, but maybe this way it suits you better because it gives you some control over it.
So, is this enough or you would require to react to some other events on the session? Actually, all the events are returned from nc_ps_poll() so you are free to behave differently for each of them (netopeer2 main.c:worker_thread). Sounds fine?
Regards,
Michal

Hi Michal
Our application communicates to netopeer2 to configure callhome by writing into sysreo running DS. We dont link to libnetconf2. Netopeer server runs as a separate process. We are certainly missing oppotunity to make use of netopeer2 main.c:np2srv_new_session_clb .
I believe nc_ps_poll() is responsible to poll on all the established NC sessions. And main.c:np2srv_del_session_clb is used when nc_ps_poll() returns NC_PSPOLL_SESSION_TERM on a session. So when ,let's say , Callhome TCP transport is disturbed by any means(i,e  making physical i/f down) will that be reflected in nc_ps_poll() as well?
If i am free to wish, would expect ietf-netconf-server data model to support GET of callhome status :) . And when netopeer2 detects any connection issue, have that info available with the sysrepo , let sysrepo update connection status for an endpoint.

Hi Rajib,
based on what you said it seems, you can only communicate with netopeer2-server using sysrepo. So, if you set ietf-netconf-server configuration to perform Call Home, the server should behave as described in the ietf-netconf-server module meaning it starts connecting and reconnects if the session is terminated for any reason. But you will not learn about any of this, only that the server started connecting when you set the configuration.
You are free to wish for anything, but you would have to implement this yourself (which should not be too difficult, but you need to write your own simple module with this status information or one that augments it into another). Actually, there are notifications defined that are sent when a session changes its status. You would have to know what sessions are Call Home ones, but I think that could be learned some way. However, I am currently working on notifications and they are not fully functional yet, so you would have to wait a few days, maybe a week for this. Still, I think you should get all the information form these notifications (look into ietf-netconf-notifications, all of those will be generated except for confirmed-commit).
Regards,
Michal


Disabled passwords for admins by default

This sets all the admin passwords to '*' which is similar to !! (the
previous setting) but means the account is not 'locked'. The result is
that users can't set a password (unless they do it as root).
This is needed if you set "PasswordAuthentication: no" in sshd_config.
This is another optional parameter for each user and the code was
getting kind of messy so I've reformatted the existing code.

Accepted - Thanks for the PR!


var instead of let ? any reason why ?

was just scanning though the source code. Any reason you used var instead of let in places like these ( link )?

Nope, there is no intentional reason for it.


Nodejs client should send the client type and version with his auth request

Is your feature request related to a problem? Please describe.
On camunda cloud we have sometimes bug reports / incidents which might be already fixed with the latest version of the client, but the user uses a old client version.
Describe the solution you'd like
We would like to detect the client type and version, on requesting the auth token. This would make incident investigation much easier, since we then don't need to ask the user for this kind of information if there went something wrong. It would also make it possible to correlate failures with know bugs.
We thought about adding this kind of information in the user agent header on the client HTTP request.
A clear and concise description of what you want to happen.
Describe alternatives you've considered
The alternative would be to ask the user for this kind of information.
Additional context
The content of the user agent should at least contain:

client type, e.g. nodejs client
client version, e.g. 0.22.2

Related issues

https://github.com/zeebe-io/zeebe/issues/4265
https://github.com/zeebe-io/zeebe/issues/4264

Fairly easy to do. Let me know the exact semantics and I'll add it.

I used in the c# client this format as user-agent value "client: , version: "

Added in 0.23.0


GPUs parameter doesn't seem to be working

When I try to run a basic MLCube passing the --gpus parameter, I get an error mlcube.errors.ConfigurationError: Unknown keys: ['--gpus']. Namespace = runner.
I've tried different ways of passing the parameter and value: --gpus="all", --gpus=all, --gpus all, --gpus=1, --gpus="1" just in case that would affect, but I get the same error regardless.
I also tried specifying the accelerator_count to different values but nothing changed.
Full traceback:
HelloWorld/data_preparator/mlcube % mlcube run --task=prepare --gpus="all" -Pdocker.build_strategy=always
Traceback (most recent call last):
  File "/Users/alejandroaristizabal/opt/anaconda3/envs/medperf/bin/mlcube", line 8, in <module>
    sys.exit(cli())
  File "/Users/alejandroaristizabal/opt/anaconda3/envs/medperf/lib/python3.9/site-packages/click/core.py", line 1130, in __call__
    return self.main(*args, **kwargs)
  File "/Users/alejandroaristizabal/opt/anaconda3/envs/medperf/lib/python3.9/site-packages/click/core.py", line 1055, in main
    rv = self.invoke(ctx)
  File "/Users/alejandroaristizabal/opt/anaconda3/envs/medperf/lib/python3.9/site-packages/click/core.py", line 1657, in invoke
    return _process_result(sub_ctx.command.invoke(sub_ctx))
  File "/Users/alejandroaristizabal/opt/anaconda3/envs/medperf/lib/python3.9/site-packages/click/core.py", line 1404, in invoke
    return ctx.invoke(self.callback, **ctx.params)
  File "/Users/alejandroaristizabal/opt/anaconda3/envs/medperf/lib/python3.9/site-packages/click/core.py", line 760, in invoke
    return __callback(*args, **kwargs)
  File "/Users/alejandroaristizabal/opt/anaconda3/envs/medperf/lib/python3.9/site-packages/click/decorators.py", line 26, in new_func
    return f(get_current_context(), *args, **kwargs)
  File "/Users/alejandroaristizabal/opt/anaconda3/envs/medperf/lib/python3.9/site-packages/mlcube/__main__.py", line 272, in run
    runner_cls, mlcube_config = parse_cli_args(
  File "/Users/alejandroaristizabal/opt/anaconda3/envs/medperf/lib/python3.9/site-packages/mlcube/cli.py", line 60, in parse_cli_args
    mlcube_config = MLCubeConfig.create_mlcube_config(
  File "/Users/alejandroaristizabal/opt/anaconda3/envs/medperf/lib/python3.9/site-packages/mlcube/config.py", line 158, in create_mlcube_config
    runner_cls.CONFIG.validate(mlcube_config)
  File "/Users/alejandroaristizabal/opt/anaconda3/envs/medperf/lib/python3.9/site-packages/mlcube_docker/docker_run.py", line 100, in validate
    _ = validator.check_unknown_keys(Config.DEFAULT.keys())\
  File "/Users/alejandroaristizabal/opt/anaconda3/envs/medperf/lib/python3.9/site-packages/mlcube/validate.py", line 78, in check_unknown_keys
    raise ConfigurationError(f"Unknown keys: {unknown_keys}.{self._namespace_msg()}")
mlcube.errors.ConfigurationError: Unknown keys: ['--gpus']. Namespace = runner.

Thanks for reporting this, working on it today.

@aristizabal95 I can't reproduce this error on my machine using several example MLCubes. Could you please point me to the repository with this HelloWorld example? Thanks!

Nevermind, this might be related to my machine. I totally overlooked compatibility with Mac. I was naively expecting things to silently run if they didn't request gpu access.
In any case, this is the respository: https://github.com/mlcommons/medperf, and the HelloWorld example can be found in examples/HelloWorld.
I still find the error message unrelated to the actual issue, and made me think it had to do with MLCube instead of machine-runner compatibility


KVM NICs can only be of type bridge

Description
All network drivers either generate or require a BRIDGE name. This prevents the use of interfaces of type ethernet.
To Reproduce
No network driver let BRIDGE to be empty
Expected behavior
Ethernet interfaces types should be supported
Details

Affected Component: oned
Hypervisor: KVM
Version: >= 5.4.x (probably earlier versions also)

Additional context
Relevant code section:
https://github.com/OpenNebula/one/blob/master/src/vmm/LibVirtDriverKVM.cc#L1052

Progress Status

[ ] Branch created
[ ] Code committed to development branch
[ ] Testing - QA
[ ] Documentation
[ ] Release notes - resolved issues, compatibility, known issues
[ ] Code committed to upstream release/hotfix branches
[ ] Documentation committed to upstream release/hotfix branches

This went very fast. Very pleased, thank you!


Container / Image scanning

Description
As an operator, I'd like containers and images to be scanned for basic security compliance as part of CI/CD pipeline
Acceptance Criteria
Reference: [Done-Done Checklist] (https://github.com/Microsoft/code-with-engineering-playbook/blob/master/Engineering/BestPractices/DoneDone.md)

[ ] Containers are automatically scanned as part of CI/CD
[ ] Scanning detects credentials and stops integration/deployment
[ ] Scanning alerts when credentials are detected

Also, here are a few points that need to be addressed:

Constraint 1;
Constraint 2;
Constraint 3.

Resources
Technical Design Document
Mockups
Tasks
Stories are intended to be completed in a single sprint; if task breakdown creates addition work then team should discuss promoting the Story to an Epic.
Reference: [Minimal Valuable Slices] (https://github.com/Microsoft/code-with-engineering-playbook/blob/master/Engineering/BestPractices/MinimalSlices.md)
Reference: [How to Write Better Tasks] (http://agilebutpragmatic.blogspot.com/2012/04/splitting-story-into-tasks-how-to-write.html)
Assignee should break down work into tasks here

This will be handled in the docker build flow by Helium


Update Deprecation Warning for CompressibleAgent and TransformChatHistory

Why are these changes needed?

Users found the current deprecation warnings unclear, so I updated them.
I put an arbitrary target release version of 0.2.30 to remove old code and eliminate further confusion.

Related issue number

Checks

[ ] I've included any doc changes needed for https://microsoft.github.io/autogen/. See https://microsoft.github.io/autogen/docs/Contribute#documentation to build and test documentation locally.
[ ] I've added tests (if relevant) corresponding to the changes introduced in this PR.
[ ] I've made sure all auto checks have passed.

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 21.95%. Comparing base (372ac1e) to head (11ff957).
Report is 29 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff             @@
##             main    #2685       +/-   ##
===========================================
- Coverage   33.11%   21.95%   -11.16%
===========================================
  Files          86       87        +1
  Lines        9108     9336      +228
  Branches     1938     2139      +201
===========================================
- Hits         3016     2050      -966
- Misses       5837     7049     +1212
+ Partials      255      237       -18

Flag
Coverage Δ

unittest
12.70% <ø> (?)

unittests
21.25% <ø> (-11.87%)
:arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

The changes look good! But there are 2 test errors, can you check it out @WaelKarkoub?. I checked the error in test compress but not sure what happened. Since it is deprecated, maybe just comment it out?

The changes look good! But there are 2 test errors, can you check it out @WaelKarkoub?. I checked the error in test compress but not sure what happened. Since it is deprecated, maybe just comment it out?

For the GPTAssistantAgent error, how about restricting openai version?

@sonichi @yiranwu0 I believe @IANTHEREAL is working on a fix for the GPTAssistant test https://github.com/microsoft/autogen/pull/2718. I skipped the compressible agent test since it'll be removed in 0.2.30


fix(search): add button to clear icon for a11y

Closes https://github.com/carbon-design-system/carbon-components-react/issues/830
Adds a button as a wrapper around the clear icon for a11y purposes
Changelog
New

The clear button  can now receive keyboard focus

Changed

Updated tests

Testing

Try tabbing to the clear icon when text has been entered

Noticing a slight style bug with these changes in the search on DataTable. Mainly, these styles need to be removed now:

Will make these changes quick downstream

Related: https://github.com/carbon-design-system/carbon-components/pull/754


Notifications for upcoming shows and movies

A notification system (which sends notifications to mobile devices) for upcoming shows and movies would be really good to have.
Libraries like these will hopefully make implementation a little less labour-intensive:
https://github.com/caronc/apprise
https://github.com/containrrr/shoutrrr

Hey @n00b12345, thanks for the great suggestion.
So you would like notifications for movies/shows on your planned list for when they release? And also when new episodes are released I suppose as well?
We'll have to figure out a system for tracking these events and sending out notifications (you've solved of half the equasion with your links, thanks!).
Not too sure what that system will look like, my first thought is possibly a persistent queue of events that we associate with users and send off when its time? But ya idk ill have to look into it more.

You can take a look at how Media Tracker does it. They have implemented a watchlist system which checks for updates and then sends out notifications if a new episode is available.
The idea behind this feature is for users to be able to replace something like Trakt completely, with a self-hosted solution like Watcharr.


drafter: new package added.

Would be great to have a RPM package for API Blueprint parser.

Looks good.


XML mapper support?

Hi, planning a XML mapping support for this package?

Maybe 😄 i will do some research as implementation of https://github.com/nettrine/orm/blob/master/src/Mapping/AnnotationDriver.php seems very easy!

It would be good to have it as separate extension, something like OrmXmlExtension

Hi @JanMikes. Any progress here? Could you please elaborate on OrmXmlExtension? :-)

Hi, sorry no progress as we are migrating whole application from Nette to Symfony.


Combine the accordion and collapsible components into one page

Started looking at content guidance for what I call "twisties". Didn't realise that there is a Collapsible component and an Accordion component.
Accordion is basically multiple collapsibles and some of the existing content on both these pages is duplicated.
So one component to cover the different uses could work.
Naming it might be tricky, though. Don't like "Collapsible" so perhaps stick to Accordion and then refer to individual "twisties"?

Is this still valid? Need to research the requirement for this change

No longer needed, 2 separate components are needed


Bitbucket API changes

Apparently the API for Bitbucket is changing, most notably a reworking of the "username" field. See:
https://developer.atlassian.com/cloud/bitbucket/bitbucket-api-changes-gdpr/?utm_source=alert-email&utm_medium=email&utm_campaign=eml-3591&jobid=103745305&subid=1362354741
Is there anything needed for these changes? I can't tell on a cursory glance if this is using the "username" API entry, as it would need to change to using the uuid instead.
These changes are complete by 12 April 2019 so if it needs to change, that's the deadline.

Wrong repo, sorry about that! Please resolve this issue, I'll repost it on the correct one now.


Changing color and thickness of the cursor

Thanks for great extension ✨
That is what I am searching for years.
If there will be a setting about changing color and thickness of the cursor, it would be great.

Thanks for your appreciation!
About being able to change the color of inactive selections:
The good news is that, this feature will be implemented. However, what would be a little unpleasantly is that it would have to wait a little longer, because right now I'm working on some more complex functionality features.

Thickness of the cursor:
Could you please provide me here with some details, specifically:

the font you are using
the size of the font
if you changed the height of editor's lines or characters
if you changed the width of the characters
an image of code/text that also has the inactive cursors about which you would want their thickness to be different

I ask you all these because you may found out a scenario where the thickness of the cursors does not adjust accordingly, and I have to be sure about what's the situation.

Thanks for the good news ✨

font: Ubuntu Mono Ligaturized, JetBrains Mono
font-size: 15
line-height: default
cursor-width: 3
image:

I developed the theme, maybe you want to try 🚀  : theme-armada

Thanks for bringing it to my attention. So the inactive cursors were designed from the beginning to, of course, not be that thin, as seen in the gifs from the readme. It seems that version 1.82 of VS Code changed something that affected that, but now it's fixed, I launched the newer version of the extension 1.1.3, which fixes this.
I've also learned that you can change the width of the normal cursor from VS Code options. Some time soon I'll make that if the user set a specific width for the normal cursor, then the inactive cursors will be of the same width.

Great!!!

Hi again! I think that now with the latest update I covered what was requested with this issue, but I wanna hear your thoughts. Thanks!
This describes the added functionality:

You can change the colors of the inactive cursors and selections:

Open the Command Palette (Windows/Linux: Ctrl+Shift+P, Mac: Cmd+Shift+P).

Search for and select Preferences: Open Settingts (UI).

Once the settings view is open type "kcs", and options like Kcs: Cursor Color and Kcs: Selection Color will appear. Their value has to be given in hex code.

For developers who want to change these colors through their theme, this is an example of how you could do it:const configuration = vscode.workspace.getConfiguration('kcs')
await configuration.update('cursorColor', '#ff0000', vscode.ConfigurationTarget.Global)
await configuration.update('selectionColor', '#ff000099', vscode.ConfigurationTarget.Global)

Note that you can use transparency, especially for the selection color.

Hello
That's awesome 🙌🏻
On the other hand, when a user tries to use the updated version for the first time, the plugin shows the changelog. This is a very nice feature, I think.
Thanks for all of your efforts.

I havent close the issue until now because of what I also said:

Some time soon I'll make that if the user set a specific width for the normal cursor, then the inactive cursors will be of the same width.

The original requests were the ability to change the color of the inactive cursors, which was implemented, and the original request about the cursor thickness was that it was too thin once a certain version of VS Code was installed - something which was not intended, but solved long ago.
Im not planning to implement yet what I was saying in the quote block, and because the original requests the OP had were met I think, Im gonna close soon this issue. However, if the missing ability described in the block quote becomes a big issue, I will address it.

It is ok for me. I am happy with the current version of the extension. Thank you.

All right, good to hear that!


Add "How to log out/shut down your session"

Not sure where is best to put it, About page? Access policies?
Could be linked from many places.

We could have another page, something like "Hub Best Practices", if we had enough of these things...


How to config proxy_connect module without resolver directive?  /// 怎么能不写resolver使用这个模块

因为项目要求不允许在配置文件中写resolver，请问如何不写resolver的情况下使得这个模块可以找到代理解析域名地址。

For example (no resolver configured), see this server{}  block in our test case. Note that proxy_address_bind may be useless for your case.
Make sure you know  how proxy_connect_address  works. Its doc: https://github.com/chobits/ngx_http_proxy_connect_module#proxy_connect_address

您方便发一个没有resolver的配置模板吗，我尝试了一下使用address但是没有生效，日志还是显示需要resolver

您方便发一个没有resolver的模板吗，我尝试了address和bind但是还是显示需要resolver。

hi 你好。你可能没有理解我上面发给你的那段信息。
这个模块如果你没有resolver，逻辑上就无法走通，比如你要代理到xx.com，如果你不配resolver的话，nginx将无法知道xx.com具体ip地址所以无法工作。
而我上一条回复的信息是告诉你，如果你有手段自己设置代理的后端ip而不需要nginx来resolver探测，那么你可以使用 proxy_connect_address  这个指令。

You may not have understood the message I sent you above.
If you do not have a resolver, this module will not work logically. For example, if you want to proxy to xx.com, if you do not have a resolver, nginx will not be able to know the specific IP address of xx.com, so it will not work.
And the information in my last reply is to tell you that if you have the means to set the backend IP of the proxy yourself without requiring nginx to detect the resolver, then you can use the proxy_connect_address directive.


wrapping Image.copy causing an adverse impact on memory use

f570bd0d7f57004550f54702c06fea1226f5be41 changed the way images were opened, and wraps the original copy method with one that tries to preserve extra imagekit related info.
however this results in the image data being retained somehow in memory - I'm not sure exactly how or where.
commenting out this line:
img.copy = types.MethodType(_wrap_copy(img.copy), img, img.__class__)
results in a substantially reduced memory footprint
I've created a quick sample app/project to demonstrate this - if you watch the process memory - you can see it climb.
https://github.com/ptone/imagefoobar (note this is using the new Django 1.4/trunk layout)
cc @lettertwo

I've spent some time pondering this - it is tricky - exif data is specific only to some jpegs, but the processor pipeline expects to chain just a generic PIL image - which does not always have exif data.
The above referenced commit tries to do this by wrapping copy to include the _getexif method on the copy, however:

though still unclear to me why, this is having an adverse impact on memory
it doesn't completely solve the problem as this may still be stripped by an earlier processor (say for example reflection), which creates a new image.

I think the processor pipeline design is good, but it requires that there is a simple contract that a processor.process method takes a generic PIL image object and returns the same.
exif data breaks that contract.
there is no reliable way to pass this through the pipeline
I think we need something akin to the autoconvert processor, or even build exif transpose into the autoconvert processor, it needs a first byte at the apple, and in that case ProcessPipleline can handle the image.copy() step.
However it is not entirely clear to me why the pipeline needs to start with a copy of the image, instead of just the image itself?
The other thing being done in the wrapping of the .copy() method is setting of an .app attr - but for the life of me, I can find no other reference to the use of this attribute in imagekit - is it just spurious?

Indeed, the memory footprint is increased. My guess is that it's a side effect of wrapping a reference to the parent instance into the copy() method on the clone.
However, I don't think this constitutes a memory leak because, as is illustrated below, these reference cycles are cleaned up by the garbage collector.
Here are some memory usage numbers under three different scenarios (a sample was taken on each iteration, then the samples were analyzed after the iteration completed):
Scenario 1
Using the PIL version of copy:
   AVG: 42M
MEDIAN: 42M
  HIGH: 42M
   LOW: 19M

Scenario 2
Using the wrapped version of copy:
   AVG: 172M
MEDIAN: 153M
  HIGH: 315M
   LOW: 20M

Scenario 3
Using the wrapped version of copy, forcing garbage collection each iteration:
   AVG: 42M
MEDIAN: 42M
  HIGH: 42M
   LOW: 20M

The increased memory usage in the second example above is likely a result of the garbage collector simply deferring collection until some later time. The numbers in that second example are markedly higher than those for the PIL implementation of copy (first example), but they do not continually rise, as you would expect in a true memory leak. Rather, they rise to a certain level, then drop, then rise again, then drop to roughly the same level (as is expected when a periodic garbage collection occurs). Here is a snippet of the iterative sampling to illustrate the garbage collection in action:
(iteration 59) MEM: 270.57M
(iteration 60) MEM: 279.38M
(iteration 61) MEM: 288.19M
(iteration 62) MEM: 296.98M
gc: collecting generation 0...
gc: objects in each generation: 922 29 18995
gc: done, 828 unreachable, 0 uncollectable, 0.0625s elapsed.
(iteration 63) MEM: 152.77M
(iteration 64) MEM: 147.59M

And again, later in the cycle:
(iteration 92) MEM: 288.21M
(iteration 93) MEM: 297.01M
(iteration 94) MEM: 305.80M
(iteration 95) MEM: 314.59M
gc: collecting generation 0...
gc: objects in each generation: 978 67 18995
gc: done, 882 unreachable, 0 uncollectable, 0.0668s elapsed.
(iteration 96) MEM: 152.80M
(iteration 97) MEM: 147.62M

The memory levels rise to ~300M, then drop to ~150M repeatedly, which shows that the reference cyles are detected and cleaned up by the garbage collector.
So it seems that the memory footprint is increased by the wrapped version of copy, but it is not leaking memory (thanks to python's garbage collector).
Here is the modified test case i used (you will need to install psutil to run it):
import os, sys, gc
import psutil
os.environ.setdefault("DJANGO_SETTINGS_MODULE", "imagefoobar.settings")
from dummy.models import Dummy
import ImageFile

ImageFile.MAXBLOCK = 1024*1024*5
sample = 'pony.jpg'
Dummy.objects.all().delete()

print 'imagekit'
gc.set_debug(gc.DEBUG_STATS)
process = psutil.Process(os.getpid())
mem_readings = []

for i in xrange(100):
    # gc.collect()
    reading = float(process.get_memory_info()[0]) / 1048576
    mem_readings.append(reading)
    print '(iteration %s) MEM: %.2fM' % (i, reading)
    try:
        d = Dummy()
        f = open(sample, 'rb')
        d.spec_image.save('foo.jpg', f)
    finally:
        if f: f.close()

print
print 'done'
print
print '   AVG: %2.fM' % (sum(mem_readings) / len(mem_readings))
print 'MEDIAN: %2.fM' % sorted(mem_readings)[len(mem_readings)/2]
print '  HIGH: %2.fM' % max(mem_readings)
print '   LOW: %2.fM' % min(mem_readings)

I ran scenario 1 by modifying imagekit.utils.open_image to not wrap the image instance's copy method.
I ran scenario 2 by using the imagekit.utils.open_image implementation.
I ran scenario 3 like scenario 2, but uncommented the line in the test case that forces garbage collection: # gc.collect()

You are correct that this is not a leak, and I've updated the issue accordingly.  For background, the discovery of this came when trying to use imagekit to batch something on ep.io and the process runner/monitors they used were killing the task due to the high memory use.
Thank you for performing the more detailed analysis. I still consider this adverse situation, and an issue.  Using gc would be a workaround - but I still feel there are some non-memory issues with wrapping copy:

as pointed out in my followup comment, there is no way to ensure that the customized img instance will be preserved through the pipeline and be available by the time it gets to a processor that would use exif.

this is essentially monkeypatching the copied instance with a private method - something dodgy about that.

I've not seen how/where this 'app' attribute is used?

I support the idea of using the exif data, and I don't mind using PILs access to it (as compared to requiring another dependency, or reinventing) - but I think it should be as some sort of special pre-pipeline step, and can be done without the ~7x memory increase.

Yeah, the copy-wrapping thing was definitely something that we weren't happy about. This was our attempt to work around a PIL limitation. Our attitude regarding the data not being preserved was basically just "auto transpositions have to be done first"—a restriction which should at the very least be pointed out in the documentation. I'll have to think about this. I can't really see a good way to avoid the kludgy pseudo-monkeypatching just yet.
As far as the "app" attribute, I believe that was just another attribute that @lettertwo found PIL's copy() was stripping.

Haha, @matthewwithanm beat me to this one by a few mins. Here are my thoughts anyway:

there is no way to ensure that the customized img instance will be preserved through the pipeline and be available by the time it gets to a processor that would use exif

Well, that is the nature (and even the point) of the pipeline--to manipulate the data as it moves through. The problem we're addressing with this copy wrapper is that PIL strips the metadata arbitrarily. If a processor chooses to strip it, that is ok.

this is essentially monkeypatching the copied instance with a private method

Yes, it is gross. We found this to be the least bad of the approaches we considered when writing it. We'll all have to ponder this one a bit more.

I've not seen how/where this 'app' attribute is used?

The app property (as defined by PIL's JpegImagePlugin) is a map of metadata markers commonly found in JPEG files. These common markers include APP0 (indicates metadata conforming to the JFIF standard), APP1 (indicates metadata conforming to the EXIF standard), and COM (indicates text comments embedded in the image).
See Wikipedia's article on JPEG files for further explanation.
While there is seperate access for metadata that conforms to the EXIF standard (the _getexif method), the JFIF standard (frequently used by image editing software) may also encode metadata via these markers (color profiles, embedded thumbnails, etc).
Since we are making an effort to conserve the EXIF metadata, it makes sense to also conserve the JFIF metadata. While none of the processors packaged with ImageKit (so far) make use of JFIF metadata, it's entirely possible that some processor in the future may want access to that metadata during processing, in which case, it should be made available.


Add substring remover mapper

This function is meant to strip repeated strings like the ones here: https://github.com/bigscience-workshop/catalogue_data/issues/5#issuecomment-1057424610

Can you add your function to the following two places?

the __init__.py in the same folder
import it to clean.py and add it to the dictionary


1.5.6 bump

What does this PR do?
(Provide a description of what this PR does.)
Test Plan
(Write your test plan here. If you changed any code, please provide us with clear instructions on how you verified your changes work.)
Related PRs and Issues
(If this PR is related to any other PR or resolves any issue or related to any issue link all related PR and issues here.)
Have you read the Contributing Guidelines on issues?
(Write your answer here.)

We shouldn't just replace the tag as there may be other changes needed too. Please review https://github.com/appwrite/integration-for-gitpod/pull/32 instead.


Live share agent running at 100%

Product and Version [VSCode]:
OS Version [macOS]:
Live Share Extension Version: 0.3.125
Steps to Reproduce / Scenario:

I'm not signed into LiveShare
I woke my machine up from sleep, since then the live share process is running at 100%.

CPU %   Mem MB     PID  Process
    1       98   49253  code-insiders main
    0      344   49255     gpu-process
    1      295   49256     window (vscode-internalbacklog — assignments/endgame-master.md)
    0       98   49429       extensionHost
    0       33   49604         electron_node jsonServerMain.js
  100       33   49613         /Users/kieferrm/.vscode-insiders/extensions/ms-vsliveshare.vsliveshare-0.3.125/dotnet_modules/vsls-agent --autoexit --pipe 5e5b038a46bc4e5e8ee1dd348d2244d9 --service https://insiders.liveshare.vsengsaas.visualstudio.com/
    0       33   49431       watcherService
    0       33   49433       terminal
    0        0   49434         /bin/bash -l
    0        0   51007           bash /usr/local/bin/code-insiders --status
   15       33   51017             electron_node cli.js
    0      147   49257     shared-process

@kieferrm Hey! We just resolved this issue and will be releasing the fix in our next update. In the meantime, I'm going to close this issue as a duplicate of #355. Let me know if that issue doesn't represent the bug you're running into. Thanks!

Hey Kai, Good news is @Priya91 is working on a fix for this problem (originally reported as #355).
Priya - We have an internal repro if you want to hook up with Kai on any other details.  Otherwise we can merge the details in with #355.


Would you like me to help you?

Since I was very interested in your project, I can help add Persian to your project languages or other help. Would you like me to help you in this case or cases?

I think the best way to help in your case would be to add Persian translation and verify LTR functionality. You could work with Farzin on that one.
The translation functionality in general, both in admin and blog, would be another thing where we could use help - identifying places where we still have hard-coded literals and replacing with translated resources etc.
Any help welcome :)

:)

@amira133 Yes, adding the Persian language would be very helpful.
and we are going to update the UI to support the right to left languages.
so if you add the Persian language, we can test the UI on a real RTL language.
Thank you

very well
Can you help me, where can I add Persian?
Because I'm not very familiar with your structure.
Do you have an Excel or CSV file?
Where is your localization area?

I added the Resource.fa.resx file on the dev branch:
https://github.com/blogifierdotnet/Blogifier/blob/dev/src/Blogifier.Shared/Resources/Resource.fa.resx

ok, I add them

@amira133 Thank you.


feat: add csharp example demonstrating subtasking

dispatch with native apis

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.


various tasks for the test command

Overview

add reports to test
raise when tests fail
don't delete the same bucket twice
when parsing legacy configs don't put empty region lists into tests

Codecov Report

Merging #60 into master will decrease coverage by 4.25%.
The diff coverage is 19%.

@@            Coverage Diff             @@
##           master      #60      +/-   ##
==========================================
- Coverage   71.83%   67.58%   -4.26%
==========================================
  Files          28       30       +2
  Lines        2521     2721     +200
  Branches      447      462      +15
==========================================
+ Hits         1811     1839      +28
- Misses        617      788     +171
- Partials       93       94       +1

Impacted Files
Coverage Δ

taskcat/_legacy_config.py
50% <0%> (-1.79%)
:arrow_down:

taskcat/_generate_reports.py
9.73% <12.12%> (ø)

taskcat/_cli_modules/test.py
35.71% <20%> (-3.58%)
:arrow_down:

taskcat/_cfn/_log_stack_events.py
22.53% <22.53%> (ø)

taskcat/_cli_core.py
87.33% <0%> (-1.34%)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update db2af14...5a45796. Read the comment docs.

/do-e2e-tests


Update profile page and home.html

Added my profile picture (150x150)
Added and updated my profile page (arshiya.html)
Added my links

Please check home.html ( repeated  tags )

@as1216 it looks like there are a lot more changes than just your own in this PR, could you remove the line indentation changes etc so that I can review it?


fANOVA results

Using SpySMAC to obtain fANOVA results for spear-swv, the tables look like that:
sp-var-dec-heur | 0.967491
sp-var-dec-heur & sp-res-order-heur | 0.974664
sp-var-dec-heur & sp-rand-var-dec-scaling | 0.972481
sp-var-dec-heur & sp-rand-var-dec-freq | 0.969324
sp-var-dec-heur & sp-learned-clause-sort-heur | 0.968437
That's weird because the scores should sum up to 1. Please check.

One problem here is that fANOVA computes both

the importance of a pair of parameters alone
and the importance of the pair plus the single contributions
You probably take the first, where only if you take the latter the sum should be less or equal to one (the sum of all possible parameter combinations will sum to one...)

I would prefer the latter which also corresponds to the output of the Java implementation.
@AndreBiedenkapp
On which end, do we need to change this? PIMP package? fANOVA package?  SpySMAC package?

I'm a bit confused here.
In my PIMP implementation, I access the fANOVA values, titled 'total importance'. This should be

the importance of the pair plus the single contributions
as Stefan wrote.

Further in the fANOVA code 'total importance' is also what is used when calling
get_most_important_pairwise_marginals (line 381).
So I'd have to guess that something is up in fANOVA.

Now it is ensured that it is always lesser or equal to one when calling the most important pairwise marginals.

Assuming this to be resolved. Feel free to reopen.


Make message and seamail subjects consistent

#95 I've normalized the subject line display for Seamails and Forums to cap at two lines. I've also cleaned up the Seamail message view intro and added the subject to the top of the Forum thread view.
Some of the length issues will also be mitigated by the new 200 character subject limits recently added in the server.
Seamail lists before and after:

Forums list before and after:

Seamail message before and after:

Forum message before and after:

Can you talk about the font size changes in particular? Convince me that it's a good idea. :-)
The other changes look great.

Fair enough. The seamail subject font was enormous 😁, blotting out much of the message, so I took it down to a reasonable title size. Participants is only a section label, not a major title so I gave it one size down from the subject. The participant names could be the same size as the label or smaller, I went with a size down.

Alright, seems fair! Thanks! I'll land this once Travis clears it.


Issues: data_zooplankton

Definitions are missing from these variables:

towsTrapsVolume

Looks like a change was made, but the metadata variable name (towsTrapsVolumn) now differs from what is in the table (towsTrapsVolume).


Write a simple README for "How to Contribute to openfloodai.github.io"

Write a simple README for "How to Contribute to openfloodai.github.io"
Add also the steps like

Find an issue that you are interested to work on.
Leave a comment that you are you would like to work!
Fork the Project and add the feature or fixed the bug that mentioned on the issue!

Hi @adventuroussrv I am interested in working on it!


thrift.client.retry-same-address=true  leads to infinite loop

In case all hosts are down, retrying the same hosts over and over again creates an infinite loop. That creates a lot of CPU pressure, as there is no delay between retrying in case of a ConnectionFailedException.

CC: @electrum @dain

If we kept a count of the failed connect attempts per address, we could add a simple backoff per address.


Startup Filter section should be moved to Fundamentals/Host/enhance an app from an external assembly

I found the inclusion of IStartupFilter in this section confusing as there did not seem to be a valuable use case.  See my SO question https://stackoverflow.com/questions/51437607/what-is-the-point-of-istartupfilter-in-asp-net-core/52178476#52178476 .  I think that it is better covered in the section "enhance an app from an external assembly in ASP.NET Core with IHostingStartup" or the doc should make it clear that external assemblies are the main use case.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 793395fe-c738-22ce-d0e9-29a850c0fa88
Version Independent ID: 0546ce3a-3258-9817-0f3f-13281c2f55da
Content: Application startup in ASP.NET Core
Content Source: aspnetcore/fundamentals/startup.md
Product: aspnet-core
GitHub Login: @ardalis
Microsoft Alias: tdykstra

Hello @mikedamay ... Thanks for commenting.
IStartupFilter isn't required for IHostingStartup, nor can it be seen as a main use case in hosting startups. It just so happens that that the StartupDiagnostics example uses an IStartupFilter to activate a pair of middlewares that are used to provide some diagnostic info on requests ... it's just to show-and-tell for how something like that is done. IStartupFilter remains focused on library implementations. I don't think we want to make any changes in how it's covered, but let's ask @Tratcher what he thinks. I defer to his judgement. I'm just a silly green dinosaur around here. :smile:

Startup filters are definitely an augmentation to Startup rather than an integral piece of it. They pair well with IHostingStartup as a means of injection into Startup, but that's not the only use case.
The Startup fitlers section could the highligheted as an extensibility mechanic. E.g. "Extending Startup: Startup Filters". The only thing I'd change from the example is to add the filter via WebHostBuilder.ConfigureServices rather than Startup.ConfigureServices. That gives you a better idea of the separation that's possible.

Extending Startup: Startup Filters

Ok

add the filter via WebHostBuilder.ConfigureServices rather than Startup.ConfigureServices

The sample is based on the templates. It would break from our guidance for doc sample construction to do it.

What's wrong with adding sample code in Program.Main? It can still be derived from the templates.

In early discussions on showing/using the extension methods in samples (I'll need to dig for it), it was decided not to use/show them in the samples. IIRC, it was felt by management that since the templates produce the Startup class with the ConfigureServices and Configure methods that they wanted all of the samples to embrace one way and be opinionated and consistent about it. IIRC, they saw the ext methods (at the time anyway) as just a nice-to-have thing and not something they really wanted push with devs.
If you recall, my 😵 Nutjob Pattern:tm: 😵 embraced them, and so I was on the side of the debate arguing for their use at the time with virtually all of the samples.
There's a good chance that the discussion(s) took place over email. I don't have access to that account (it's closed down), so I won't be able to forward the message chain to you if that's where we discussed it.
I'll look and see if it was a GH discussion and get back to you.

I don't follow, the sample would still have a Startup class. I'm talking about adding the IStartupFilter as a host service to show how it augments Startup from the outside.

as a host service == WebHostBuilder.ConfigureServices
Just following orders ... I was told not to use that host builder extension method in samples.
No worries ... @Rick-Anderson You good on this?
public static IWebHost BuildWebHost(string[] args) =>
    WebHost.CreateDefaultBuilder(args)
        .ConfigureServices(services =>
        {
            services.AddTransient<IStartupFilter, RequestSetOptionsStartupFilter>();
        }
        .UseStartup<Startup>()
        .Build();

I'll add a line or two that say something to the effect ...

adding the IStartupFilter as a host service to show how it augments Startup from the outside.

Approved :point_up: :+1:
I'll get this done PDQ.

@guardrex  do what chris suggests always unless it's an editorial point.


Error in load/save models with FeatureLayer when refitting or reloading

Hello,
My model has FeatureLayer and i want do flow like this:

Create, fit model  on basic data and save.
Load model and fit on new data and save updated model.
Do 2 step periodically e.g. 1 time in week.

When I do model  first time, it's no problem, also I can use it in tensorflow-serving and it works.
Then I can load this model, fit on new data and save updated model. But when I try to load updated model i have an error:
 raise ValueError('Passing a dictionary input to a Sequential Model ' ValueError: Passing a dictionary input to a Sequential Model which doesn't have FeatureLayer as the first layer is an error.
In tf v 2.0.0 problem is when load model:
model = tf_load.load_internal(path, loader_cls=KerasObjectLoader)
File "/usr/lib64/python3.6/site-packages/tensorflow_core/python/saved_model/load.py", line 541, in load_internal
export_dir)
File "/usr/lib64/python3.6/site-packages/tensorflow_core/python/keras/saving/saved_model/load.py", line 103, in __init__
self._finalize()
File "/usr/lib64/python3.6/site-packages/tensorflow_core/python/keras/saving/saved_model/load.py", line 132, in _finalize
node._set_inputs(inputs)
File "/usr/lib64/python3.6/site-packages/tensorflow_core/python/keras/engine/training.py", line 2697, in _set_inputs
inputs = self._set_input_attrs(inputs)
File "/usr/lib64/python3.6/site-packages/tensorflow_core/python/training/tracking/base.py", line 457, in _method_wrapper
result = method(self, *args, **kwargs)
File "/usr/lib64/python3.6/site-packages/tensorflow_core/python/keras/engine/training.py", line 2731, in _set_input_attrs
raise ValueError('Passing a dictionary input to a Sequential Model '
ValueError: Passing a dictionary input to a Sequential Model which doesn't have FeatureLayer as the first layer is an error.

I tested it and it's not problem with fitting model but with save or load, becouse when I only load first model and save as new model (without any interference in model) the error occurs when i try load updated model.
In version 2.1.0 its not error when load updated model, but when I try to fit. Final error is the same in both cases
 File "C:\Users\kglapiak\AppData\Local\Continuum\anaconda3\envs\tf_test2\lib\site-packages\tensorflow_core\python\keras\engine\training.py", line 819, in fit
    use_multiprocessing=use_multiprocessing)
  File "C:\Users\kglapiak\AppData\Local\Continuum\anaconda3\envs\tf_test2\lib\site-packages\tensorflow_core\python\keras\engine\training_v2.py", line 235, in fit
    use_multiprocessing=use_multiprocessing)
  File "C:\Users\kglapiak\AppData\Local\Continuum\anaconda3\envs\tf_test2\lib\site-packages\tensorflow_core\python\keras\engine\training_v2.py", line 593, in _process_training_inputs
    use_multiprocessing=use_multiprocessing)
  File "C:\Users\kglapiak\AppData\Local\Continuum\anaconda3\envs\tf_test2\lib\site-packages\tensorflow_core\python\keras\engine\training_v2.py", line 706, in _process_inputs
    use_multiprocessing=use_multiprocessing)
  File "C:\Users\kglapiak\AppData\Local\Continuum\anaconda3\envs\tf_test2\lib\site-packages\tensorflow_core\python\keras\engine\data_adapter.py", line 702, in __init__
    x = standardize_function(x)
  File "C:\Users\kglapiak\AppData\Local\Continuum\anaconda3\envs\tf_test2\lib\site-packages\tensorflow_core\python\keras\engine\training_v2.py", line 660, in standardize_function
    standardize(dataset, extract_tensors_from_dataset=False)
  File "C:\Users\kglapiak\AppData\Local\Continuum\anaconda3\envs\tf_test2\lib\site-packages\tensorflow_core\python\keras\engine\training.py", line 2346, in _standardize_user_data
    all_inputs, y_input, dict_inputs = self._build_model_with_inputs(x, y)
  File "C:\Users\kglapiak\AppData\Local\Continuum\anaconda3\envs\tf_test2\lib\site-packages\tensorflow_core\python\keras\engine\training.py", line 2572, in _build_model_with_inputs
    self._set_inputs(cast_inputs)
  File "C:\Users\kglapiak\AppData\Local\Continuum\anaconda3\envs\tf_test2\lib\site-packages\tensorflow_core\python\keras\engine\training.py", line 2647, in _set_inputs
    inputs = self._set_input_attrs(inputs)
  File "C:\Users\kglapiak\AppData\Local\Continuum\anaconda3\envs\tf_test2\lib\site-packages\tensorflow_core\python\training\tracking\base.py", line 457, in _method_wrapper
    result = method(self, *args, **kwargs)
  File "C:\Users\kglapiak\AppData\Local\Continuum\anaconda3\envs\tf_test2\lib\site-packages\tensorflow_core\python\keras\engine\training.py", line 2681, in _set_input_attrs
    raise ValueError('Passing a dictionary input to a Sequential Model '
ValueError: Passing a dictionary input to a Sequential Model which doesn't have FeatureLayer as the first layer is an error.

I save model by mehod:
model.save('original_model',save_format='tf')
Example of model:
feature_columns = []

categorical = tf.feature_column.categorical_column_with_vocabulary_list(
        key='f1', vocabulary_list=['x1','x2','x3'],
        num_oov_buckets=0)
one_hot = feature_column.indicator_column(categorical)
feature_columns.append(one_hot)

categorical = tf.feature_column.categorical_column_with_vocabulary_list(
        key='f2', vocabulary_list=['x1','x2','x3','x4','x5','x6'],
        num_oov_buckets=5)
embedding = feature_column.embedding_column(categorical, dimension=10)
feature_columns.append(embedding)

feature_layer = tf.keras.layers.DenseFeatures(feature_columns)

model = tf.keras.Sequential([
  feature_layer,
  layers.Dense(20, activation='relu'),
  layers.Dense(1,activation='softsign')
])

model.compile(optimizer='adam',
              loss=tf.keras.losses.BinaryCrossentropy(from_logits=True),
              metrics=['accuracy'])

def df_to_dataset(dataframe, shuffle=True, batch_size=32):
    dataframe = dataframe.copy()
    labels = dataframe.pop('target')
    ds = tf.data.Dataset.from_tensor_slices((dict(dataframe), labels))
    if shuffle:
        ds = ds.shuffle(buffer_size=len(dataframe))
    ds = ds.batch(batch_size)
    return ds

train = df_to_dataset(train)
val = df_to_dataset(val)

model.fit(train,
          validation_data=val,
          epochs=2)

I tested it on conda and pip distributions, on tf versions 2.0.0 and 2.1.0 and on Windows and Centos and several versions of Python and all time is the same problem.

OS Platform and Distribution (Windows, Centos):
TensorFlow version (2.0.0,2.1.0 also pip and conda distridutions ):
Python version: several versions from  3.6.5 to 3.7.1

@kglapiak
Code shared is incomplete we will not be able to replicate the issue, please share simple stand alone code or if possible a colab gist for us to analyse the issue faced

All code:
import pandas as pd
import numpy as np
from sklearn.model_selection import train_test_split

import tensorflow as tf
from tensorflow.keras.layers import Activation, Dropout, Flatten, Dense
from tensorflow.keras.models import Sequential
from tensorflow.keras.models import load_model,Model
from tensorflow import feature_column
from tensorflow.keras import layers

def df_to_dataset(dataframe, shuffle=True, batch_size=32):
  dataframe = dataframe.copy()
  labels = dataframe.pop('target')
  ds = tf.data.Dataset.from_tensor_slices((dict(dataframe), labels))
  if shuffle:
    ds = ds.shuffle(buffer_size=len(dataframe))
  ds = ds.batch(batch_size)
  return ds

###--------- sample dataset ---------
n = 10000
data = pd.DataFrame({'f1':np.random.choice(['x1','x2','x3'], n, replace=True),
                     'f2':np.random.choice(['x1','x2','x3','x4','x5','x6'], n, replace=True),
                     'target':np.random.choice([0,1], n, replace=True)})

train,val = train_test_split(data,test_size=0.2)
train,new_train = train_test_split(train,test_size=0.2)

###--------- define features columns ---------
feature_columns = []

categorical = tf.feature_column.categorical_column_with_vocabulary_list(
        key='f1', vocabulary_list=['x1','x2','x3'],
        num_oov_buckets=0)
one_hot = feature_column.indicator_column(categorical)
feature_columns.append(one_hot)

categorical = tf.feature_column.categorical_column_with_vocabulary_list(
        key='f2', vocabulary_list=['x1','x2','x3','x4','x5','x6'],
        num_oov_buckets=5)
embedding = feature_column.embedding_column(categorical, dimension=10)
feature_columns.append(embedding)

feature_layer = tf.keras.layers.DenseFeatures(feature_columns)

###--------- define and compile model ---------
model = tf.keras.Sequential([
  feature_layer,
  layers.Dense(20, activation='relu'),
  layers.Dense(1,activation='softsign')
])

model.compile(optimizer='adam',
              loss=tf.keras.losses.BinaryCrossentropy(from_logits=True),
              metrics=['accuracy'])

train = df_to_dataset(train)
val = df_to_dataset(val)
new_train = df_to_dataset(new_train)

#----------- train model first time - all its ok --------
model.fit(train,
          validation_data=val,
          epochs=2)

model.save('basic_model',save_format='tf')

###------------- first update, no errors -------------------------
model_update1 = tf.keras.models.load_model('basic_model')
model_update1.fit(new_train,
          validation_data=val,
          epochs=2)

model_update1.save('update1',save_format='tf')

###------------- 2nd update is problem and generate errors -------------------------
model_update2 = tf.keras.models.load_model('update1')
model_update2.fit(new_train,
          validation_data=val,
          epochs=2)

@kglapiak
I ran the code shared above on tf 2.1 but do not face any error as reported above, please find the gist here

For me this colab returns error:
ValueError                                Traceback (most recent call last)
<ipython-input-4-b1ad4c6f08c2> in <module>()
     82 model_update2.fit(new_train,
     83           validation_data=val,
---> 84           epochs=2)

10 frames
/usr/local/lib/python3.6/dist-packages/tensorflow_core/python/keras/engine/training.py in _set_input_attrs(self, inputs)
   2679         # We assert that the first layer is a FeatureLayer.
   2680         if not training_utils.is_feature_layer(self.layers[0]):
-> 2681           raise ValueError('Passing a dictionary input to a Sequential Model '
   2682                            'which doesn\'t have FeatureLayer as the first layer'
   2683                            ' is an error.')

ValueError: Passing a dictionary input to a Sequential Model which doesn't have FeatureLayer as the first layer is an error.

Correct @kglapiak.
I've just tried taking a look at this issue, and yes -- it's breaking up exactly where you've pointed out.
@Saduf2019  - have you tested out the linked gist?

@kglapiak
I ran the code shared by you and do not face any error, in case you are still facing an error can you please share a colab gist so we could analyse the error faced. faced

Here colab gist exacly same like yours.
And the same error occurs.
I show this for some people and they all had the same.
If you are sure, its works for you, only explanation is it's work in US and dot't worki in EU.
Is it even possible?

@kglapiak
Could you please give me permission to view the gist.

@Saduf2019 yea - now should be ok

I am able to replicate the reported issue on tf 2.1,please find the gist here. Thanks!

Hi, @ymodak - something happends with that issue?

This is fixed with TensorFlow 2.2
Thanks!

Yea, its works. Thanks !


no configure script?

Instructions say that running "make" is all that should be needed if LinuxCNC is compiled from source. Since 2.9 is available in the apt repo as linuxcnc-uspace-dev compiling from source isn't what most people are likely to do. I installed LinuxCNC from apt myself.
running make alone will fail:
$ make g++ -c -Wall -I. -I/usr/include -I/usr/include/linuxcnc -c -o obj/from_shcom.o from_shcom.cpp g++ -c -Wall -I. -I/usr/include -I/usr/include/linuxcnc -c -o obj/inifile.o inifile.cpp inifile.cpp:23:10: fatal error: config.h: No such file or directory    23 | #include "config.h"       |          ^~~~~~~~~~ compilation terminated. make: *** [Makefile:14: obj/inifile.o] Error 1
I believe config.h is typically generated from running ./configure?

Fixed, I think. Try "linuxcnc/emc.hh" instead of "config.h"

Not sure what to make of this:
$ make g++ -c -Wall -I. -I/usr/include -I/usr/include/linuxcnc -c -o obj/inifile.o inifile.cpp inifile.cpp: In member function ‘bool IniFile::Open(const char*)’: inifile.cpp:66:38: error: ‘LINELEN’ was not declared in this scope    66 |     char                        path[LINELEN] = "";       |                                      ^~~~~~~ inifile.cpp:70:26: error: ‘path’ was not declared in this scope    70 |     TildeExpansion(file, path, sizeof(path));       |                          ^~~~ inifile.cpp: In member function ‘const char* IniFile::Find(const char*, const char*, int, int*)’: inifile.cpp:196:38: error: ‘LINELEN’ was not declared in this scope   196 |     static char                 line[LINELEN + 2] = "";        /* 1 for newline, 1 for NULL */       |                                      ^~~~~~~ inifile.cpp:226:17: error: ‘bracketSection’ was not declared in this scope   226 |         sprintf(bracketSection, "[%s]", section);       |                 ^~~~~~~~~~~~~~ inifile.cpp:231:31: error: ‘line’ was not declared in this scope; did you mean ‘link’?   231 |             if (NULL == fgets(line, LINELEN + 1, fp)) {       |                               ^~~~       |                               link inifile.cpp:237:35: error: ‘line’ was not declared in this scope; did you mean ‘link’?   237 |             if(check_line_endings(line)) {       |                                   ^~~~       |                                   link inifile.cpp:246:33: error: ‘line’ was not declared in this scope; did you mean ‘link’?   246 |             newLinePos = strlen(line) - 1;        /* newline is on back from 0 */       |                                 ^~~~       |                                 link inifile.cpp:272:27: error: ‘line’ was not declared in this scope; did you mean ‘link’?   272 |         if (NULL == fgets(line, LINELEN + 1, (FILE *) fp)) {       |                           ^~~~       |                           link inifile.cpp:278:31: error: ‘line’ was not declared in this scope; did you mean ‘link’?   278 |         if(check_line_endings(line)) {       |                               ^~~~       |                               link inifile.cpp:287:29: error: ‘line’ was not declared in this scope; did you mean ‘link’?   287 |         newLinePos = strlen(line) - 1;        /* newline is on back from 0 */       |                             ^~~~       |                             link inifile.cpp:299:34: error: ‘eline’ was not declared in this scope   299 |                elineptr = (char*)eline; //first time       |                                  ^~~~~ inifile.cpp: At global scope: inifile.cpp:29:13: warning: ‘bool check_line_endings(const char*)’ defined but not used [-Wunused-function]    29 | static bool check_line_endings(const char *s) {       |             ^~~~~~~~~~~~~~~~~~ make: *** [Makefile:14: obj/inifile.o] Error 1

Sorry, my bad. Turns out config.h is included by emc.hh so my earlier change didn't help. Try again.

That did it, thanks


kill ngapp2 deploy page

can you remove all the urls related to ngapp2? also i think the ngapp2 is hardcoded into the home page as the recent environment, we may need to remove that as well.

Can I confirm should we just remove: /ngapp2/deploy/
Or we should remove all urls from this list?
ngapp2/deploy/
ngapp2/new_deploy/
ngapp2/promote_to/
ngapp2/deploy_to/
ngapp2/update_deploy_progress/
ngapp2/deploys/
ngapp2/compare_deploys/
If second case, I can just remove ngapp2_urls.py file, which is my current PR is doing.


Adds ddlib support for python2 and python3

Changes print statements to functions
Changes relative imports to be explicit (PEP 328)
Adds \N unicode character escape (raw string)
Adds makefile tests to be consistent with previous output tests
Adds some sorts to output methods to make output deterministic -- sorts values
for the features set and in the json.dumps() output to ensure that output is the
same between runs with the same input data (and for the makefile tests)
Adds new tests within the included Makefile to compare Python3 +/- ddlib
output and Python2/ddlib vs. Python3/ddlib output
Fixes unit tests in test.py to iterate through generators when necessary

ip-172-30-0-123 python> deepdive env python
Python 2.7.6 (default, Jun 22 2015, 17:58:13)
[GCC 4.8.2] on linux2
Type "help", "copyright", "credits" or "license" for more information.
>>> from deepdive import *
>>> from ddlib import *
>>> tsv_extractor
<function tsv_extractor at 0x7f0dd2db0c80>
>>>
ip-172-30-0-123 python> deepdive env python3
Python 3.4.3 (default, Oct 14 2015, 20:28:29)
[GCC 4.8.4] on linux
Type "help", "copyright", "credits" or "license" for more information.
>>> from deepdive import *
>>> from ddlib import *
>>> tsv_extractor
<function tsv_extractor at 0x7f512f97ae18>
>>>

Thanks a lot for the work!  I put a bit more tests around it (turning them into .bats) and merged after fixing another inconsistency in Python3: map(None, l1, l2, ...)


How to turn off logging in MSM?

Hi @dasisdormax ,
Is it possible to turn off logs in /msm.d/cs2/log/instance-name ? If yes , how should I achieve it?

Hi @dasisdormax can you please help me with this? thanks

There is no feature to disable the game logs. Do you really need that?

@dasisdormax I have the exact same setup (addons,plugins) on two different VMs that are on the same dedicated server . The only difference is that one is using steamcmd directly without logs and the other is with msm which is logging the console . I noticed that CPU usage in the server with msm is higher than the one without msm . Since every other single variable is the same in my setup , I'm assuming that the logging feature of msm could be the reason . I would like to turn it off and see if it makes any difference .

I can't imagine the logging to have a significant performance impact, and think other reasons are more likely.
If you want to try to disable logging anyway, you can edit the file program/Core/Server/functions.sh, around line 70, and
replace the line script -c '$(quote $LAUNCH_CMD)' "$LOGDIR/\$(timestamp)-server.log"
with just $LAUNCH_CMD

@dasisdormax thanks it worked . By disabling logging , I was able to get around the same CPU usage as the other server . The difference is noticeable for me as my resources are limited .


(bedrock): Knowledge base BedrockEmbeddingModelConfiguration

Describe the feature
Updates to Knowledge Base in cdk v2.154.1
[~] resource AWS::Bedrock::KnowledgeBase
│    │ └ types
│    │    ├[+] type BedrockEmbeddingModelConfiguration
│    │    │ ├  documentation: The vector configuration details for the Bedrock embeddings model.
│    │    │ │  name: BedrockEmbeddingModelConfiguration
│    │    │ └ properties
│    │    │    └Dimensions: integer
│    │    ├[+] type EmbeddingModelConfiguration
│    │    │ ├  documentation: The configuration details for the embeddings model.
│    │    │ │  name: EmbeddingModelConfiguration
│    │    │ └ properties
│    │    │    └BedrockEmbeddingModelConfiguration: BedrockEmbeddingModelConfiguration
│    │    └[~] type VectorKnowledgeBaseConfiguration
│    │      └ properties
│    │         └[+] EmbeddingModelConfiguration: EmbeddingModelConfiguration

Use Case
missing features
Proposed Solution
No response
Other Information
No response
Acknowledgements

[ ] I may be able to implement this feature request
[ ] This feature might incur a breaking change

Could also work on it, pretty familiar with what is missing


Add LATERAL support for postgres

Resolves #49

Add supports for pg:

LATERAL
INNER JOIN LATERAL
LEFT JOIN LATERAL
RIGHT JOIN LATERAL
FULL JOIN LATERAL
CROSS JOIN LATERAL

All receives a SelectTable interface

@OrlandoCo Thanks for your MR.
Why do we need additional join types?
Wouldn't be simple just to add a LATERAL function. For instance:
INNER_JOIN(
   LATERAL(
    SELECT(...).FROM(...)
   ).AS("lateral_alias"), Bool(true))

LATERAL function will accept selectStatement as a parameter and return SelectTable interface. Implementation will be similar as salectTableImpl.

Hello,
Thank you for your review, I decided to add Join methods on reference to others query builders approach to LATERAL.
I made the changes according to your observations.

There is also missing a way to make references of the selected columns in SelectTable to use in a WHERE clause or other projections, ej:
SELECT * FROM a
LATERAL (SELECT id AS e_id FROM b) AS e
WHERE e.e_id=a.id

Could you please give me a hint how to implement it?

Need to review the code more, I have no idea how to implement without adding other interfaces or polluting the originals.


Swapping out oraclejdk8 with openjdk8

Issue: Travis CI - master branch build failure #11
To address the Travis CI build error:

Expected feature release number in range of 9 to 14, but got: 8
The command "~/bin/install-jdk.sh --target "/home/travis/oraclejdk8" --workspace "/home/travis/.cache/install-jdk" --feature "8" --license "BCL"" failed and exited with 3 during .

Thank you, @benjaminjacobberg


Attempt to call method 'indexOf ' (a nil value)

When i try request http://X.X.X.X/
INFO Deploying bundle (16.77 MB)...
INFO Running script...
/app/node_modules/tiny-router/lib/router.js:167: attempt to call method 'indexOf
' (a nil value)
var router = require('tiny-router'),
    tessel = require('tessel');

var lights = {
    green: tessel.led[0],
    blue: tessel.led[1],
    red: tessel.led[2],
    amber: tessel.led[3]
};

router
    .get('/', function(req, res) {
        res.send('Simple light web API');
    })
    .get('/lights', function(req, res){
        res.send(lights);
    })
    .get('/green', function(req, res){
        var state = lights.green.read();
        lights.green.write(state);
        res.send({status: state});
    })
    .get('/green/{state}', function(req, res){
        var state = parseInt(req.body.state);
        lights.green.write(state);
        res.send({status: state});
    });

router.listen(8080);

I found the issue, the request.url is returning a Buffer and before is was returning an String. I'll push the fix in a few minutes.

I found the issue, the request.url is returning a Buffer and before is was returning an String. I'll push the fix in a few minutes.

Issue fixed with https://github.com/pirumpi/tiny-router/commit/71415939368dcf6b1ca8a1c276112b91c77e69dd

Issue fixed with https://github.com/pirumpi/tiny-router/commit/71415939368dcf6b1ca8a1c276112b91c77e69dd

Thanks! Appears to be working now with the latest Tessel firmware :)


[Event Request] Codeunit 90 "Purch.-Post"

Dear ALAppExtensions team,
On behalf of 4PS I would like to request integration event 'OnRunOnAfterPostInvoice' to be changed in trigger 'OnRun' in codeunit 90 "Purch.-Post".
trigger OnRun()
.
.
.
        // Post combine shipment of sales order
        PostCombineSalesOrderShipment(PurchHeader, TempDropShptPostBuffer);

        if PurchHeader.Invoice then
            PostInvoice(PurchHeader);

#if not CLEAN19
        OnRunOnAfterPostGLAndVendor(PurchHeader, PurchRcptHeader, ReturnShptHeader, PurchInvHeader, PurchCrMemoHeader, TempInvoicePostBuffer, PreviewMode, Window);
#endif
        //OnRunOnAfterPostInvoice(PurchHeader, PurchRcptHeader, ReturnShptHeader, PurchInvHeader, PurchCrMemoHeader, PreviewMode, Window); //old
        OnRunOnAfterPostInvoice(PurchHeader, PurchRcptHeader, ReturnShptHeader, PurchInvHeader, PurchCrMemoHeader, PreviewMode, Window, SrcCode, GenJnlLineDocType, GenJnlLineDocNo, GenJnlPostLine); //new

        if ICGenJnlLineNo > 0 then
            PostICGenJnl();

        OnRunOnBeforeMakeInventoryAdjustment(PurchHeader, GenJnlPostLine, ItemJnlPostLine, PreviewMode, PurchRcptHeader, PurchInvHeader);
        MakeInventoryAdjustment();
        UpdateLastPostingNos(PurchHeader);
.
.
.

    [IntegrationEvent(false, false)]
    //local procedure OnRunOnAfterPostInvoice(var PurchaseHeader: Record "Purchase Header"; var PurchRcptHeader: Record "Purch. Rcpt. Header"; var ReturnShipmentHeader: Record "Return Shipment Header"; var PurchInvHeader: Record "Purch. Inv. Header"; var PurchCrMemoHdr: Record "Purch. Cr. Memo Hdr."; var PreviewMode: Boolean; var Window: Dialog) //old
    local procedure OnRunOnAfterPostInvoice(var PurchaseHeader: Record "Purchase Header"; var PurchRcptHeader: Record "Purch. Rcpt. Header"; var ReturnShipmentHeader: Record "Return Shipment Header"; var PurchInvHeader: Record "Purch. Inv. Header"; var PurchCrMemoHdr: Record "Purch. Cr. Memo Hdr."; var PreviewMode: Boolean; var Window: Dialog; SrcCode: Code[10]; GenJnlLineDocType: Enum "Gen. Journal Document Type"; GenJnlLineDocNo: Code[20]; var GenJnlPostLine: Codeunit "Gen. Jnl.-Post Line") //new
    begin
    end;

Thanks for reporting this. We agree, and we’ll publish a fix asap, either in an update for the current version or in the next major release. Please do not reply to this, as we do not monitor closed issues. If you have follow-up questions or requests, please create a new issue where you reference this one.
Build ID: 41235.


onActivityResult never gets called on cocos2d-x 4

I've being trying to use this in cocos2d-x. It opens the gallery successfully, but right after picking an image, it returns to the application, and nothing happens.
Doing some debug, I see that method public boolean onActivityResult is never executed.
Any suggestions?

Hi,
I havn't work with cocos2dx for quite some years and not sure cocos2dx v4 has any breaking api or not. (This project is developed and tested with v3).
The key code path is: Cocos2dxHelper.getActivity().startActivityForResult(intent, IMAGE_PICKER_ACTIVITY);->onActivityResult
So you can add some log in https://github.com/cocos2d/cocos2d-x/blob/v4/cocos/platform/android/java/src/org/cocos2dx/lib/Cocos2dxHelper.java, to make sure the correct intent is launched and returned.
If you can provide a simple example to test, I can also help on holiday.


Improve CI, requring all feature combos to succeed along with clippy

Significantly cleanup & improve our CI setup.
This requires clippy lints to succeed across two hardcoded versions (MSRV and something recent).
It also requires all feature combinations to pass the tests (with an exception for nested-values on MSRV).
Big Changes

ci: Require clippy lints to succeed without warnings

Fix miscelaneous clippy lints

ci: Require successful test execution for all feature combos.

On Minimum Supported Rust, allow nested-values tests to fail.
This is needed because the erased-serde dependency requires edition="2021", added in Rust 1.56
dynamic-keys: Remove duplicate impl of AsRef for Key

Minor Changes

ci: Split version & feature matrix across multiple lines

Ensures diff is minimal

ci: Update github actions toolchains, avoiding deprecation warnings

Switch from actions-rs/toolchain to dtolnay/rust-toolchain

ci: Add 'stable minus 15 releases' to the testing matix

Per the official policy on the wiki, this is an upper bound on the MSRV
Possible because of switch to dtolnay/rust-toolchain

ci: Enable the --all-targets flag for tests, check, and clippy
Setup a clippy configuration file
README.md: Correct the Minimum Supported Rust Version to 1.48

Make sure to:

[x] Add an entry to CHANGELOG.md (if necessary)

Hi @dpc , now that it is the weekend, could you maybe review this? 😃


fix(pie-card-container): DSW-1289 fix design issues

Describe your changes (can list changeset entries if preferable)
[Fixed] Design feedback
Author Checklist (complete before requesting a review)

[ ] I have performed a self-review of my code
[ ] If it is a core feature, I have added thorough tests
[ ] If it is a PIE Docs change, I have reviewed the Docs site preview
[ ] If it is a component change, I have reviewed the Storybook preview
[ ] If there are visual test updates, I have reviewed them properly before approving

Reviewer checklists (complete before approving)
Reviewer 1

[ ] If it is a PIE Docs change, I have reviewed the PR preview
[ ] If there are visual test updates, I have reviewed them

Reviewer 2

[ ] If it is a PIE Docs change, I have reviewed the PR preview
[ ] If there are visual test updates, I have reviewed them

LGTM. I agree with @raoufswe's comment though