AutomaticTokenManagement doesnt handle refresh token expiration or removal

Question / Steps to reproduce the problem
With AutomaticTokenManagement sample  when testing with a refresh token that has been expired or removed.   The application just throws an exception rather than rerouting the user back to the login screen.
Minimal working example
AutomaticTokenManagement
Error location
AutomaticTokenManagementCookieEvents.cs#L73
I would expect this to be able to handle this and reroute the user back to the login screen to request a new refresh token.  However i suspect this will require logging the user out of the identity server and removing any cookies stored on their machine.
The main issue is if the refresh token was removed in the database there by no longer being valid the user will crash.   I also suspect that we do not have sliding refresh tokens enabled which causes refresh tokens to expire and again the application will crash.
At this time I have not been granted permission to enable sliding refresh tokens but this wouldn't help admins revoking refresh tokens anyway.
My first solution.
The only thing i have gotten to work so far is this
[Authorize]
public async Task<IActionResult> CallApi()
{
    try
    {
        var token = await HttpContext.GetTokenAsync("access_token");

        var client = _httpClientFactory.CreateClient();
        client.SetBearerToken(token);

        var response = await client.GetStringAsync(Constants.SampleApi + "identity");
        ViewBag.Json = JArray.Parse(response).ToString();

        return View();
    }
    catch (Exception)
    {
        return new SignOutResult(new[] { "Cookies", "oidc" });
    }
}

While it does work its not ideal IMO as its going to require a try catch on all api calls. That and this is just catching the error from the API call itself and not the fact that the token is still expired after the attempt to refresh it.   It would be nice if there was a way to do this from the event handler directly.    I would like to update the sample so if anyone has a better idea let me know.
cross post
I have also posted this as a question on Stack overflow Identity server 4 handling Expired or revoked refresh tokens

It's a sample ;)
I probably wouldn't use this approach myself. But rather https://leastprivilege.com/2019/06/30/another-take-on-access-token-management-in-asp-net-core-and-announcing-identitymodel-aspnetcore/
Still you need to deal with this situation somehow.

Unfortunately companies use your samples and expect them to be best practice.  If its missing pieces this causes confusion.
The link you posted does not seam to address the Issue of dealing with a refresh token that has expired.

Unfortunately companies use your samples and expect them to be best practice. If its missing pieces this causes confusion.

You have a point -- I see all the time companies just grabbing the samples and just using them. But at the same time, we all should know how dangerous that is if the samples are not fully understood. It's like searching for how to fix something and then copying the snippet of code from stackoverflow.
I think @leastprivilege is going to remove that sample. If you'd like to add the error handling, this might be a good place: https://github.com/leastprivilege/AspNetCoreSecuritySamples/tree/aspnetcore21/AutomaticTokenManagement

I hope he doesn't remove it because its linked everywhere.   Its currently the best solution for access token refreshing.   If he does remove it do you mind my cross posting it to my own blog so that we have a copy to help people.

@leastprivilege context.RejectPrincipal(); before return in line 74 should solve the problem. Please don't remove the sample, I've just found it following the link on SO, but it's a really nice addon to MVC! Thank you!

A couple of things about this sample

I don't like that the logic runs on every request regardless if we call an API or not
I would rather just call the APIs provided by IdentityModel.AspNetCore from within the event handler than have all the logic there

@dfrunet I guess for this approach - the reject principal is OK since it's all supposed to be "automatic"
@LindaLawton yes - if you fix the sample like mentioned above we can keep it. Send a PR. But don't use the exception handler.

@dfrunet this works perfectly and i dont know why i didnt think of it.   Amazing thanks for your help.
@leastprivilege I will add a PR soon I just need to remember the commands for updating my fork.  Again ........


Feature/bugfixes

This change is

Reviewed 3 of 3 files at r1.
Review status: all files reviewed at latest revision, all discussions resolved.

Comments from Reviewable

Merged!


Scrolling issue (whole page scrolls)

If you scroll up immediately after page load (scrollTop of scrollable-content div =0), the whole page (including the header navbar) scrolls up instead of the scrollable-content div!
When you scroll down (while the whole page bounces back to top) it is also possible to scroll the whole page down (including the footer bar).
If you first scroll down a bit and then scroll to the top of the page again, it seems to work, because then only the scrollable-content div scrolls and the navbar header stays on top.
Is it possible to prevent the "whole page" bouncing?  (like kendo does: http://demos.telerik.com/kendo-ui/mobile-listview/index - header bar is always on top)
You can reproduce this issue on your demo page!
Screenshots: http://1drv.ms/1K61Arg
I need this because I want to implement a pull-to-refresh list (using https://github.com/mgcrea/angular-pull-to-refresh), but it does not work if the user immediately wants to refresh (scroll page up) without scrolling down first.
As a workaround a currently set the value of the scrollTop property to 1 after the view gets activated (but it only works once, if user scrolls back to top (scrollTop=0) it will stop working):
$timeout(function () {
   var scrollableElement = $('#scrollableContainer')[0];
   scrollableElement.scrollTop = 1;
}, 10);

User-Agent
Mozilla/5.0 (iPhone; CPU iPhone OS 8_1_2 like Mac OS X) AppleWebKit/600.1.4 (KHTML, like Gecko) Version/8.0 Mobile/12B440 Safari/600.1.4

Hi, i'm working on it right now since the next release will be all about gestures.
A quick fix in the meanwhile would be to prevent default for touchmove once scrollTop or scrollDown is reached. Not tried yet.
Anyway a more generic solution is in progress.
If you're planning to build a Phonegap/Cordova app you can prevent this behaviour through cordova config.
I will be really happy to have a little help in fixing this.
Thank you anyway!

Thanks for your quick reply!
I'm working on a PhoneGap app, so the DisallowOverscroll config property works for me. Thank you for the great hint!


repair the parent/child relationship when changing the pop over position

On 10.14.6 at least, ordering out the child window kills the parent/child relationship.
Open the popover, change the position, and move the parent window...

I can duplicate the issue on Big Sur so it doesn't seem to be 10.14 specific.

I restructured the repo so this PR won't merge cleanly. If you don't mind updating the PR I'll merge it, otherwise I can just make the changes manually.

It has been rebased.

Thanks for this!


Travel Website using React JS

Closes #21

Title :  Travel Website
Name: : Aditya Bhaumik
Idenitfy yourself: : GSSOC'24

Describe the add-ons or changes you've made 📃
I have added travel website in React-Projects>Intermediate and also updated database , readme files
How Has This Been Tested? ⚙

What sort of change have you made:

[ ] Bug fix (non-breaking change which fixes an issue)
[x] New feature (non-breaking change which adds functionality)
[ ] Code style update (formatting, local variables)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[ ] This change requires a documentation update

Checklist: ☑

[x] My code follows the Contributing Guidelines & Code of Conduct of this project.
[x] This PR does not contain plagiarized content.
[x] I have performed a self-review of my own code.
[x] I have commented my code, particularly wherever it was hard to understand.
[x] My changes generate no new warnings.

Note to reviewers 📄
Fixes #21
Sorry it took some time to make this website
Please review my pull request and add the gssoc label
Thank you

@aditya-bhaumik Also attach your assigned issue with the pr by editing the pr template

@Avdhesh-Varshney i have made the changes requested

@aditya-bhaumik don't create a large sequence of commits for a single pr.

@Avdhesh-Varshney i am really sorry i will make sure not to do this mistake in the next project actually i had completed the project but for some reason i was not able to push the project using my terminal or git bash


Precompiled views are not being used even when they are available

Looks like this is a regression. I can see PrecompiledViews.dll being generated with all the CompiledViewItems but the views are being compiled on the first request.
cc @pranavkm @rynowak
@mikeharder, this is the reason for the perf regression we were seeing.

Self assigning this for investigation

Resolved in https://github.com/aspnet/Razor/commit/b538ceba9365a018eadc48bbe57dc9b2a76cbd90


Implement pool for server handler that assigns tasks according to stream and its partition.

In constructor of the server there is a parameter orderedExecutionPoolSize which is by default should take the value of Runtime.getRuntime().availableProcessors() but can be overriden with parameter (default parameter value if not set is Runtime.getRuntime().availableProcessors() too).
This parameter defines the size of OrdereExecutorPool which is an array of execution context created on scala Executors.newSingleThreadExecutor. Please, not that for debugging purposes every execution service should have unique name like "OrderedExecutionService-$index", where index is array index of that service.


BSD license

Hi,
just to clarify, since you use the BSD license which says that reproductions in binary form must include the author's copyright info in the documentation - I'm assuming you don't actually require any such attribution in apps? (You might consider switching to MIT which only requires keeping the copyright info with the code.)

Nope, we don't require that. We'll change the license to MIT. Thanks for pointing this issue @mackuba

Done! Thanks again @mackuba

Thanks!


[Bug] Multiple tags can cause problems with tag arrangement

Version
No response
Current Behavior

https://github.com/openai/whisper

https://github.com/opencv/opencv
Multiple tags can cause problems with tag arrangement, such as in the two repositories above.
Expected Behavior
No response
Environment
- OS:
- Browser:

Any additional comments?
No response

I think when there are a lot of tags, some tags can be folded, as shown below:

I think when there are a lot of tags, some tags can be folded, as shown below:
! [image](https://private-user-images.githubusercontent.com/79428895/357378619-b87e12f9-283c-4270-94a6-31d93d8dd503.png?jw t=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6I mtleTUiLCJleHAiOjE3MjM1NDYzNDYsIm5iZiI6MTcyMzU0NjA0NiwicGF0aCI6Ii83OTQyODg5NS8zNTczNzg2MTktYjg3ZTEyZjktMjgzYy00MjcwLTk0Y TYtMzFkOTNkOGRkNTAzLnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJ TJGMjAyNDA4MTMlMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjQwODEzVDEwNDcyNlomWC1BbXotRXhwaXJlcz0zMDAmW C1BbXotU2lnbmF0dXJlPWNmNWVlYTZjNmE4NzY1OTY2MTZlZGI4OWQ5Zjc2NDlmMDQ1ZDkyYjBkNzQ0MGMwMTgxM2ZmZWI5ZDNiODNlZDUmWC1BbXotU2lnb mVkSGVhZGVycz1ob3N0JmFjdG9yX2lkPTAma2V5X2lkPTAmcmVwb19pZD0wIn0.j6nOm1oXC90kAriBEl0HfE6jviZrKcwVwG_BFvMbH-g)

This idea may be feasible, you can give it a try.

Is this the feature of v1.9.7 or later version? I am currently using 1.9.7 but can not see the labels.

Is this the feature of v1.9.7 or later version? I am currently using 1.9.7 but can not see the labels.

This hasn't been released yet. Currently there is an issue that has been merged into the master branch of the repository.

Because some repositories label a lot of data is very long. One idea is to mimic the repository home page by adding a label for the repository underneath. Place red box 2 below red box 1.

Because some repository label data is not only voluminous but also lengthy in text. One idea is to mimic the repository home page by adding a label for the repository underneath. Place red box 2 below red box 1. Might be worth considering.

Great idea, like it.

Because some repository label data is not only voluminous but also lengthy in text. One idea is to mimic the repository home page by adding a label for the repository underneath. Place red box 2 below red box 1. Might be worth considering.

I am also thinking if it is possible to move the other labels to the end of the list, so users get to know what metrics they are reading.

Here is a prototype of what mentioned in the comment. I think this looks really good and we can add hyperlink to corresponding leaderboard for these labels when we finished the labels leaderboards.

This looks great.

one more fail case: https://github.com/bytecodealliance/wasmtime

Next, this task will be completed by @Xsy41 .

Some labels are too long, the name is similar, how to deal with it? @frank-zsy
failing case：https://github.com/openai/whisper

The icon may be this one https://open-digger.cn/img/logo/logo-blue-round-corner.png ？

This is the initial adjustment plan at present, let's see if there are any better suggestions.

Good job @Xsy41! LGTM. cc @tyn1998
Is it possible to use AI instead of the full spell? I guess we'll need a shortened set of tags in someplace. (and give the full form on some hover inform text.) cc @wangyantong2000

Wonderful @Xsy41 , but I was wondering if it's possible to display a portion of the important tags and collapse the remaining tags, instead of collapsing all the tags directly. However, I'm not sure if there is a specific method to automatically select higher-priority tags or an algorithm to rank the tags by priority.

Thanks to @HalloMelon and @TieWay59 , at present we have two methods, the first method does not show the full name for long tags, and the mouse hover to show. The second shows tags with higher priority, or for some similar tags. As shown in the following figure, can you only show the following four labels framed in red?

Thanks to @HalloMelon and @TieWay59 , at present we have two methods, the first method does not show the full name for long tags, and the mouse hover to show. The second shows tags with higher priority, or for some similar tags. As shown in the following figure, can you only show the following four labels framed in red?由于和，目前我们有两个方法，第一个方法不显示长标签的全名，并将鼠标悬停显示出来。第二个显示具有更高优先级的标记，或者一些类似的标记。如下图所示，可以只显示以下四个红色边框的标签吗?

At present, our label data is directly provided by OpenDigger. I think we can wait for @frank-zsy  to reconfirm the label data and see if further processing is needed. See if the changes are caused by the data source itself or during development.

The label structure in OpenDigger involves multiple layers, so one repo may has multiple labels in a technical area in different layers just like whisper. And In the label structure, the parent label name will be a prefix to its children labels.
I think only presenting the top-level label is neat and clean, but in the label data exported in OpenDigger, we do not provide if a label is a top-level label but a top-level label is prefix of its all children labels.
So there are 2 ways to fix this:

Provide level of a label in OpenDigger export data. And this will take time to develop in OpenDigger.
In HyperCRX, filter all the labels which have prefix equals to any other label.

Oh, actually I think the type of the label implies the level of the label. For Domain and Tech label, the type of the label will be Domain-n and Tech-n.
So just filter the labels with type Tech-n and n is not 0, and same to Domain-n, we can get rid of the children labels.

Oh, actually I think the type of the label implies the level of the label. For Domain and Tech label, the type of the label will be Domain-n and Tech-n.
So just filter the labels with type Tech-n and n is not 0, and same to Domain-n, we can get rid of the children labels.

Thanks to @frank-zsy  we filtered all Tech-n and n is not 0, and our final interface rendered the result.


feat: add an exposed endpoint to request a resource by resource id

Changes
[New] - No authentication request catalogue item by it's resource id
URL
/api/catalogue/{resource}
Responses
Example 200 Response
{
        "archived": false,
        "localizations": {
            "en": {
                "id": 127,
                "langcode": "en",
                "title": "ANU Poll 2020: Bushfires, The Environment, and Optimism For The Future",
                "infourl": "https://dataverse-test.ada.edu.au/dataset.xhtml?persistentId=doi:10.80408/E7FERF"
            }
        },
        "resource-id": 127,
        "start": "2024-09-13T04:41:56.206Z",
        "organization": {
            "organization/id": "ADA",
            "organization/short-name": {
                "en": "ADA"
            },
            "organization/name": {
                "en": "Australian Data Archive"
            }
        },
        "wfid": 11,
        "resid": "doi:10.80408/E7FERF",
        "formid": 7,
        "categories": [],
        "id": 127,
        "expired": false,
        "end": null,
        "enabled": true
 }

Example 404 Response
{
    "error": "not found"
}

do you think an unauthorised endpoint like this should actually expose the information? Instead it could just return a 200 code with the doi only?

Further Adjustments


Clarify Text Document Event Sequencing Requirements

It is not entirely clear to me what a language server should assume about the sequence of text document lifecycle event (didOpen, didChange, didClose).
Imagine a client that crashes, then reconnects to the language server. The sequence of events the language server would see is this:
didOpen(foo, content)
didChange(foo)
DidOpen(foo, content).
Is that allowed?
What assumption can a language server make about the sequence of these events, or in other words: what guarantees does the client have to make?

@tsmaeder the current assumption of the LSP is that the server is spawned and owned by the client. This means that if the client goes down the server goes down. There LSP is currently not designed for 'standalone' servers. I do have request to support this but this raised questions like you asked about reconnect scenarios, multi tenant, ....
So in the current protocol the sequence should always be:
didOpen(foo, content)
didChange(foo){n}
didClose(foo)


Start training can't know the progress %

Start training can't know the progress %
Is there a way to know the current progress?
The cmd show the 20% 50%... a lot of different progress, can not understand what it means?
like this:
...
INFO:Zumndamon_Model:Train Epoch: 9 [20%]
INFO:Zumndamon_Model:[4200, 9.990004373906418e-05]
INFO:Zumndamon_Model:loss_disc=3.959, loss_gen=3.062, loss_fm=7.881,loss_mel=17.356, loss_kl=1.535
INFO:Zumndamon_Model:Train Epoch: 9 [50%]
INFO:Zumndamon_Model:[4400, 9.990004373906418e-05]
INFO:Zumndamon_Model:loss_disc=4.060, loss_gen=2.972, loss_fm=7.563,loss_mel=18.711, loss_kl=1.495
INFO:Zumndamon_Model:====> Epoch: 9 [2023-07-07 13:35:13] | (1:11:57.773330)
...
If there is no such function, is there a chance to add the function of displaying progress?

it's quite simple. Just look for this line:
INFO:Zumndamon_Model:====> Epoch: 9 [2023-07-07 13:35:13] | (1:11:57.773330)
You can see that the current epoch is 9. The training will end when the epoch number matches the value you set for the "Total training epochs" option before starting the training.
Enjoy

what does the INFO:Zumndamon_Model:loss_disc=4.060, loss_gen=2.972, loss_fm=7.563,loss_mel=18.711, loss_kl=1.495 mean


Complete manifest editor

Documentation is not clear yet on what a manifest is and how author can create their own, despite the tools already in place.
Currently some management parts are very cumbersome to work with. Map and Mod management need some streamlining.

Is there a GUI tool for it?

Ayup, its the second tab. It is not clar enough at the moment where are you supposed to place the local copies of the manifest files (in windows its appdata/sc2-campaign-manager/manifests) nor there is a more direct way to save a local copy of manifests from an online version... yet


Audit uses of Mutex or RwLock for performance

Any form of synchronous locking may degrade the performance of the tokio thread pool as it will block the whole thread, we should try replace with something that does not lock at all. Some of our mutexes are may be unnecessary, one way to replace them is by using a oneshot channel internally and returning a future corresponding to the receiver.

Is this still needed?

@lutter Yes, the motivation is the same as #905, but this one has much less impact.

This is old and we haven't had issues related to this. And the recommendation is to prefer the synchronous locks in short critical sections that do not block https://github.com/tokio-rs/tokio/issues/2479#issuecomment-623158758. So closing.


Silent failure (crash?) when using --script <script> with an invalid script path

Tested versions

v4.3-stable (v4.3.stable.official [77dcf97d8]) : silent failures (unexpected)
v4.2.2-stable (v4.2.2.stable.official [15073afe3]) : explicit errors (as expected)

System information
Godot v4.3.stable - Windows 10.0.22631 - Vulkan (Forward+) - dedicated NVIDIA GeForce RTX 3080 Ti (NVIDIA; <IP_ADDRESS>22) - AMD Ryzen 9 5900X 12-Core Processor (24 Threads)
Issue description
When passing an incorrect path to --script, v4.3.0 will fail silently, reporting no error.
When doing the same with v4.2.2 we get an explicit error.
Steps to reproduce
Run (no need to be in a project, same issue whatever the context)
godot --headless --script <script>

with <script> being a path that doesnt lead to any file or resource, or doesnt have an extension.

v4.3.0 will silently fail
v4.2.2 will report the problem (either the path leads to no file or it's not the expected extension)

On my system (git-bash over powershell):
$ /e/tools/godot/Godot_v4.2.2-stable_win64.exe --headless --script machin
Godot Engine v4.2.2.stable.official.15073afe3 - https://godotengine.org

ERROR: Resource file not found: res://machin (expected type: )
   at: (core/io/resource_loader.cpp:279)
ERROR: Can't load script: machin
   at: (main/main.cpp:3098)

$ /e/tools/godot/Godot_v4.2.2-stable_win64.exe --headless --script machin.gd
Godot Engine v4.2.2.stable.official.15073afe3 - https://godotengine.org

ERROR: Attempt to open script 'res://machin.gd' resulted in error 'File not found'.
   at: (modules/gdscript/gdscript.cpp:1025)
ERROR: Failed loading resource: res://machin.gd. Make sure resources have been imported by opening the project in the editor at least once.
   at: (core/io/resource_loader.cpp:274)
ERROR: Can't load script: machin.gd
   at: (main/main.cpp:3098)

$ /e/tools/godot/Godot_v4.3-stable_win64.exe --headless --script machin
Godot Engine v4.3.stable.official.77dcf97d8 - https://godotengine.org

$ /e/tools/godot/Godot_v4.3-stable_win64.exe --headless --script machin.gd
Godot Engine v4.3.stable.official.77dcf97d8 - https://godotengine.org

Note that for the last 2 commands I see a marker in my bash that shows the program returns non-zero, the value being:
$ echo $?
1

Minimal reproduction project (MRP)
N/A

Can't replicate the lack of feedback on 4.4 [d0dc3896a], it prints correctly that it can't find the script
I'm not sure what else the engine should do in this case, you're asking to run a script that doesn't exist, other than what program exit code to use

So not sure what is the problem reported here

The issue is specifically that there are conditions where the errors are not displayed when the execution failed with v4.3-stable, but it is visible with v4.2.2-stable, however in my initial report I assumed the conditions were specific to the flags passed to Godot, they are not:
As you reported that it works with v4.4 I tried v4.4-DEV1 and saw no error output again, so I dug deeper into the issue. I finally found that:

the issue is not specific to --script, there are many errors that are not reported on exit of Godot at least when running in cli;
turns out that the output is different depending on the terminal I'm using:

with git-bash , v4.3-stable and v4.4-DEV1 's error output is not visible with the command from the report, but v4.2.2-stable does report the error (that's what I was seeing in my initial report+various repros as this is my default terminal);
with PowerShell, the errors are reported correctly with all versions but the error output overwrites the normal output (typing anything after the execution of Godot will write over the output) - not sure what's going on there;
with cmd the errors are reported correctly with all versions and the output is correctly displayed;

Because I use git-bash by default I couldnt see the error reports and assumed that it was probably Godot crashing when reporting the error, but apparently it's more like an error output routing issue, although I coudlnt check with a debug version of Godot right now, I note to do that when I find the time.
So for now I suppose the problem is with git-bash, not with Godot, and I'll close this issue. Apparently something changed in v4.3 and following error output that git-bash doesnt digest well.


Default File Not Working

I know that this is totally because I can't read properly but I can't seem to get the default file function to work. I've tried multiple different ways but I can't seem to hack it. Any help would be appreciated!

The issue was with my application not the plug-in!!


Update Set-SFTPFile.md

Example 1
PS C:\> Set-SFTPFile -SessionId 0 -RemotePath "/tmp/dns_validator.py" -LocalFile ./Development/dns_validator.py -Overwrite

should be
Example 1
PS C:\> Set-SFTPFile -SessionId 0 -RemotePath "/tmp" -LocalFile ./Development/dns_validator.py -Overwrite

-RemotePath don't include filename.

This command has been deprecated and replaced by Set-SFTPItem. In the next major version it will be removed
Sent from my iPhone

On Oct 9, 2019, at 6:13 AM, Bruce Chen<EMAIL_ADDRESS>wrote:

Example 1
PS C:> Set-SFTPFile -SessionId 0 -RemotePath "/tmp/dns_validator.py" -LocalFile ./Development/dns_validator.py -Overwrite
should be
Example 1
PS C:> Set-SFTPFile -SessionId 0 -RemotePath "/tmp" -LocalFile ./Development/dns_validator.py -Overwrite
-RemotePath don't include filename.
You can view, comment on, or merge this pull request online at:
https://github.com/darkoperator/Posh-SSH/pull/291
Commit Summary
Update Set-SFTPFile.md
File Changes
M docs/Set-SFTPFile.md (2)
Patch Links:
https://github.com/darkoperator/Posh-SSH/pull/291.patch
https://github.com/darkoperator/Posh-SSH/pull/291.diff
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub, or mute the thread.

understand.

Do appreciate the PR either way. It is good to get help :)
Sent from my iPhone

On Oct 9, 2019, at 7:17 AM, Bruce Chen<EMAIL_ADDRESS>wrote:

understand.
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub, or mute the thread.


add spacing to numpy.gradient

Hi guys, I just implemented spacing in jax.numpy.gradient.
Going to add a test shortly.

Hi guys, I addressed the comments, I believe this is ready for review!

Sorry about the slow review. I know I don't personally know a lot about this particular function in Numpy. I think this is fine for a first cut, given it appears well-tested. We can do any further iteration in future PRs.
Thanks for the PR!

No worries, actually thanks guys!
I have some higher order finite difference code already working.
Is there a namespace in jax where this would be useful?


fix(deps): update module github.com/relekang/coredns-blocklist to v1.12.0

This PR contains the following updates:

Package
Type
Update
Change

github.com/relekang/coredns-blocklist
require
minor
v1.11.0 -> v1.12.0

Release Notes

relekang/coredns-blocklist (github.com/relekang/coredns-blocklist)
v1.12.0
Compare Source

Configuration
📅 Schedule: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).
🚦 Automerge: Enabled.
♻ Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.
🔕 Ignore: Close this PR and you won't be reminded about this update again.

[ ] If you want to rebase/retry this PR, check this box

This PR has been generated by Renovate Bot.

ℹ Artifact update notice
File name: go.mod
In order to perform the update(s) described in the table above, Renovate ran the go get command, which resulted in the following additional change(s):

4 additional dependency was updated

Details:

Package
Change

github.com/miekg/dns
v1.1.58 -> v1.1.59

github.com/prometheus/client_golang
v1.19.0 -> v1.19.1

golang.org/x/mod
v0.14.0 -> v0.16.0

golang.org/x/tools
v0.17.0 -> v0.19.0


Collection modification via transformResponse

Closes #64.

That was amazingly fast! Can you add a note to the docs as well about this?

@begriffs updated.

@begriffs is this ok to go?

Oh thanks for reminding me. I did have one thought: is it necessary to reset to page 0 when changing the transformation function? For instance if my function was to uppercase the words and I remove the transform it seems to me the pagination could remain on the current page but go back to its original case.

I thought that was a little wonky personally, but wanted to be consistent.  I can think of instances where you may want to add additional UI elements that would manipulate the callback potentially, but I’m easy either way.

On Mar 19, 2015, at 1:56 PM, Joe Nelson<EMAIL_ADDRESS>wrote:
Oh thanks for reminding me. I did have one thought: is it necessary to reset to page 0 when changing the transformation function? For instance if my function was to uppercase the words and I remove the transform it seems to me the pagination could remain on the current page but go back to its original case.
—
Reply to this email directly or view it on GitHub https://github.com/begriffs/angular-paginate-anything/pull/66#issuecomment-83694090.

Are you saying it feels wonky for the page to reset to 0 when changing any of the properties, or only when changing the transformation function?

The fact we can’t actually compare if the function truly “changes” is wonky.  That said, I would advocate for keeping it as is for now.  My 2c.


Chef 13. Deprecated feature - overwrites an existing method

Cookbook version
2.1.1
Chef-client version
12.19.33
Platform Details
CentOS7
Scenario:
I am using the LWR: 'chef_hander' to add a custom handler to the end of my chef client runs, and while running chef on 12.x I see the following:
   Deprecated features used!
     Property `supports` of resource `chef_handler` overwrites an existing method. Please use a different property name. This will raise an exception in Chef 13. at 1 location:
       - /tmp/kitchen/cache/cookbooks/chef_handler/resources/default.rb:31:in `class_from_file'

Steps to Reproduce:
Should be able to reproduce by doing a chef client run when using the LWR.
Expected Result:
No deprecation warnings/errors.
Actual Result:
   Deprecated features used!
     Property `supports` of resource `chef_handler` overwrites an existing method. Please use a different property name. This will raise an exception in Chef 13. at 1 location:
       - /tmp/kitchen/cache/cookbooks/chef_handler/resources/default.rb:31:in `class_from_file'

Despite the warning, this is actually fine for Chef 13. We did some refactoring of the supports code in chef-client which cleared it up.


Hue feature for LED Strips

Hey, thank you for investing so much time to help us all.
I have bought me a new LED strip but i cant get the colours to work with hoobs or HomeKit. I tried overruling the device to light, but the colours i set arent working.  Also the dimming function is not listed in HomeKit when overruling it as dimmer.
Would be great if this would work someday
Anyway the PlugIn is great.

Please post the result of the steps under "How to check whether the api this library uses can control your device".
Without this it is hard for me to help you with regards to this specific issue.

Thank you for that fast reply
Here the result:
Getting credentials
Got credentials
{   'access_token': 'EUheu1606064187114MwpjLYMoTLlK1IK',
'expires_in': 864000,
'refresh_token': 'EUheu1606064187114MwpjL1ug59C14Qe',
'token_type': 'bearer'}
Getting devices
Got devices
{   'header': {'code': 'SUCCESS', 'payloadVersion': 1},
'payload': {   'devices': [   {   'data': {'online': True, 'state': False},
'dev_type': 'switch',
'ha_type': 'switch',
'icon': 'https://images.tuyaeu.com/smart/icon/1550751312j51om81lrcl_0.jpg',
'id': '56312004c82b9601ba80',
'name': 'Nachtlicht'},
{   'data': {   'color_mode': 'colour',
'online': True,
'state': 'true'},
'dev_type': 'light',
'ha_type': 'light',
'icon': 'https://images.tuyaeu.com/smart/icon/001460162698766TR4v1/15902172291eb12c59706.png',
'id': 'bf7c9681d6a8f07c7fepok',
'name': 'LED Streifen'},
{   'data': {'online': True, 'state': True},
'dev_type': 'switch',
'ha_type': 'switch',
'icon': 'https://images.tuyaeu.com/smart/icon/ay1509430484182dhmed/1568711567fd83656b47e.png',
'id': '054008478caab5019b5f',
'name': 'Licht'}],
'scenes': []}}

And thank you for your fast response.
So your led strip is giving a mixed signal to my plugin 😛 On the one hand it says that its color_mode: "colour" which indicates that it does support colors. On the other hand it does not provide said color data (which other products often do).
I'll look into some way to overwrite the plugins assumptions and allow you to configure this.

thank you very much!

Thank you @milo526, I was just running into the same problem with some LED strips I just received.  You rock for working on this!

v0.5.4 is released as a pre-release version and has support for overwriting plugin decision.
You can now force hue to be enabled.
Overwrite your device to a lightbulb and enable color.
Please open another issue if you are still experiencing problems.


ENTERPRISE DOMAIN CONTROLLERS collect all computers with Unconstrained Delegation

The logic for adding members to the special ENTERPRISE DOMAIN CONTROLLERS group with the well-known SID of S-1-5-9 is to include all machine accounts with Unconstrained Delegation which I believe are causing false positives. The offending line is referenced below.
https://github.com/NH-RED-TEAM/RustHound/blob/c4e8eb3d2f4191879dadbc3629db713e39ca3948/src/json/checker/common.rs#L37
The function also references Bloodhound.py functionality which doesn't do this so I was wondering if there is rationale behind this?

Just chiming in as I ran into this as well recently. I believe this ended up causing BH to show some false attack paths related to DCSync and other edges.


⚠ Bofrost.de has degraded performance

In 925b35f, Bofrost.de (https://www.bofrost.de) experienced degraded performance:

HTTP code: 200
Response time: 1320 ms

Resolved: Bofrost.de performance has improved in ca9f3d5 after 6 minutes.


Chore use changeset

Description
Use changeset for releases

Update both app package.json and the appropriate Dockerfile

Finishes https://github.com/CodeForAfrica/ui/issues/229
Example Changeset PR https://github.com/CodeForAfrica/ui/pull/231
Type of change

[x] New feature (non-breaking change which adds functionality)

Screenshots
Checklist:

[x] My code follows the style guidelines of this project
[x] I have performed a self-review of my own code
[x] I have commented my code, particularly in hard-to-understand areas
[ ] I have made corresponding changes to the documentation

Lets use the @changesets/changelog-github changelog format.

not sure I get what you mean here @kilemensi

2. hangelog-github changelog

https://github.com/changesets/changesets/blob/main/docs/config-file-options.md#changelog-false-or-a-path @esirK

One question @esirK : Doesn't a single pnpm changeset version bump all selected apps/packages? My thinking is say I've fixed a bug in @commons-ui/core and I'd like to release a new version of the @commons-ui/core package itself and every app that depends on it.
Who does the release workflow work in this case?

One question @esirK : Doesn't a single pnpm changeset version bump all selected apps/packages? My thinking is say I've fixed a bug in @commons-ui/core and I'd like to release a new version of the @commons-ui/core package itself and every app that depends on it.
How does the release workflow work in this case?

The Immediate way I'm thinking of is you should select all apps depending on the package and for all of them do a minor release.

I'm not sure if this is the best approach but lemme do some digging.

I'm not sure if this is the best approach but lemme do some digging.

I think this is the correct way @esirK as far as the selection of what to release goes. What I'm asking is how do the app-release.yml workflows handle this? If one app, say PromiseTracker calls changeset version in bump, I'm sure changesets will update all versions. What will CodeForAfrica then see when it calls bump?

I'm not sure if this is the best approach but lemme do some digging.

I think this is the correct way @esirK as far as the selection of what to release goes. What I'm asking is how do the app-release.yml workflows handle this? If one app, say PromiseTracker calls changeset version in bump, I'm sure changesets will update all versions. What will CodeForAfrica then see when it calls bump?

I see; Having different releases might not work afterall.
Lemme think about it but I think we might have to have 1 release that has multiple version checks for all packages/apps in the repo.

I think it's good now @kilemensi


Migrate to Webpack 2

Update setup to use Webpack 2. Initial plan to support<EMAIL_ADDRESS>and release to master once official release is made.

FYI, be on the lookout for a stable Webpack 2.x very soon.
https://github.com/webpack/webpack/releases/tag/v2.2.0-rc.4

This is probably the last RC. We released it as final test.
If no critial bugs are discovered, we release 2.2.0 in < 10 days.

Just what I want to hear! Thanks.

Migrating webpack structure to treat all dependencies as externals. Much better for building and will enable use of main process modules.

Webpack 2 is fully supported within the current project structure and is currently available within the dev branch. Since all dependencies will now be treated as externals I will changing the project structure a little to give more support for the main process. Once that is complete, expect a release to master soon.


Update contributing guide

Contributing guide should include:

What is part of the standard and what is not (an implementation of SDS)
What the rules are for updating the standard (an implementation of VMS)
How one can submit an issue
For the adventurous: how one can update the term_versions.csv vocabulary as a pull request: add new line, update previous term

And we should include an ISSUE_TEMPLATE.md. As we can only have one, I think a term change or new term is probably the most used one...

The document currently resides at https://github.com/tdwg/dwc/blob/master/.github/CONTRIBUTING.md. Would it be better at https://github.com/tdwg/dwc?
I agree that there should be a reference to the VMS, but is this really the place to say what is normative in the standard?
I would recommend against adding anything about amending term_versions.csv.
I set up two issue templates, one for new term requests and one for term change requests.
If I can get consensus I'll proceed to make the changes.

Partial changes made to match issue templates in https://github.com/tdwg/dwc/commit/551c64eb2d93cddf49987452cf84e3a24f4ecaaa

With respect to the usage comments, we might indicate that they are optional and only necessary if the definition does not provide all of the needed information about how the term should be used. I don't know how to say that in a way that is not too wordy and suitable for a form.

A lot of this content is in the FAQ, which was created primarily for the latest public review. We should have a strategy for merging and placing this material. Best in an .md file for consistency probably. Recommendations welcome.

Updated the contributing guide and integrated the Wiki FAQ with it.


m(breaking): Simplify internal storage and lookup mechanisms

This PR replaces the current Vec and next_id-based storage strategy with the Slab type. Slab is similar to the current storage strategy, except that the key corresponds directly to the index in the underlying Vec. This means that the lookup process is an O(1) process as opposed to an O(n) process.
The goal is to replace this bit of self-referencing code in cosmic-text so that one can gain access to the underlying &mut Database.
The only wrinkle that that Slab<T> doesn't directly correspond to an &[T], so the faces() function has to be an impl Iterator<&FaceInfo> instead of an &[FaceInfo]. This is a breaking change.

I don't think this is a good idea. First, I don't want any dependencies. And second, to my understanding, slab reuses indexes, which can lead to pretty bad results.
If you want O(1) indexing, then we need either a HashMap (requires std) or simply do not remove faces. But the later one would mean that we would need to have a removed/disabled flag or something.
Or, since the current ID is ordered, we can use binary search, which should be faster then the current approach.
I guess the current logic is a leftover from times when we had u64 UUID instead of just u32 indices.

I don't think this is a good idea. First, I don't want any dependencies.

slab with no-default-features consists of a single file, so it's a very lightweight dependency. On top of that, slab is a dependency of almost every async framework and soon to be a dependency of calloop (Smithay/calloop#123), so in the cases where fontdb is used it probably uses slab already anyways.

And second, to my understanding, slab reuses indexes, which can lead to pretty bad results.

This only ends up being an issue when fonts are removed, which is a rarely used operation. On top of that, if a font is removed, that implies that the key isn't being used anymore by whatever's using fontdb at the higher level. If this is still a concern, slotmap doesn't have this problem.

If you want O(1) indexing, then we need either a HashMap (requires std)

This would be possible without libstd, but we would need to import hashbrown alongside a good-enough hashing algorithm (ahash?). Not only does this require significantly more dependencies, it would raise this crate's MSRV to 1.61 at a minimum.

or simply do not remove faces. But the later one would mean that we would need to have a removed/disabled flag or something.

This is possible, but would leak memory.

Or, since the current ID is ordered, we can use binary search, which should be faster then the current approach.

Binary search is O(n log n), and the goal is for O(1) search so that caching the search isn't necessary.

This is possible, but would leak memory.

This only ends up being an issue when fonts are removed, which is a rarely used operation

I would say changing remove to disable and using ID for indexing is a far easier solution.

Okay, I've opened #46 to supersede this PR.


it can player flash?

can it player flash in unity?

There is no Flash support with this project, nor do do we plan to support it for security reasons.


Add Discord support

ISSUE TYPE

Feature Pull Request

SUMMARY

Add support for Discord:
This PR,

adds discord bot
adds discord notifier
adds required discord configurations into comm_config.yaml
adds discordgo module into go.mod
adds discord configs into all yaml files

Fixes #97
Steps For Creation and Integration:

Reach https://discordapp.com/developers/applications

Create New Application named Botkube and add a bot named Botkube into the Application

Copy the Application CLIENT ID and place it under Dischord.botid in comm-config.yaml

Copy Bot TOKEN and place it under Dischord.token in comm-config.yaml

Generate the URL with suitable permissions using the OAuth2 URL Generator available under OAuth2 section to the add bot to your Discord server

https://discordapp.com/oauth2/authorize?&client_id=<YOUR_CLIENT_ID>&scope=bot&permissions=<SET_OF_PERMISSIONS>

Paste the generated URL in a new tab, select the discord sever to which you want to add the bot and Authorise Bot addition.
Create a new channel and/or copy the  CHANNEL ID of an existing one that you want to use and place it under Dischord.channel

  # Settings for Discord
  discord:
    enabled: true
    token: 'DISCORD_TOKEN'	    # BotKube Bot Token
    botid: 'DISCORD_BOT_ID'         # BotKube Application Client ID
    channel: 'DISCORD_CHANNEL_ID'   # Discord Channel id for receiving BotKube alerts
    notiftype: short                # Change notification type short/long you want to receive. notiftype is optional and Default notification type is short (if not specified)

Note: Follow the first 4 mins of this Video Tutorial to understand the process visually.
Preview:

@codenio can we add integration tests?

added discord configs into all yaml files

@codenio The CI job is failing with
Step 9/17 : RUN GOOS=${GOOS_VAL} GOARCH=${GOARCH_VAL} go build -o /go/bin/botkube ./cmd/botkube
 ---> Running in 3dcedf3fac47
# github.com/docker/docker/pkg/term
exec: "gcc": executable file not found in $PATH
The command '/bin/sh -c GOOS=${GOOS_VAL} GOARCH=${GOARCH_VAL} go build -o /go/bin/botkube ./cmd/botkube' returned a non-zero code: 2
Makefile:39: recipe for target 'container-image' failed
make: *** [container-image] Error 2
The command "make container-image" exited with 2.

I think the docker dep you added need gcc. Can you please update travis config to add gcc dep?

@PrasadG193, resolved the build issue and rebased this PR into developed.
can this be merged?

I guess this has to be rebased again soon?

rebased and resolved issues

Can this PR get reviewed again or/and merged? I'm using it on my own k8s cluster and it's working pretty well!
@codenio Seriously good job.

I just found an odd bug.
I'm able to ping the bot through the desktop Discord client but not on the Android Discord client.

The first message is from the Android Discord client and the second is from the desktop Discord client.
@codenio Could you try to replicate the bug by sending a ping to your botkube from your Android Discord client?

How would i install the version of the PR onto a kube cluster?

I tried to get it to run,
But gettings this error...
panic: http: multiple registrations for /metrics
goroutine 38 [running]:
net/http.(*ServeMux).Handle(0x3489840, 0x1d1852b, 0x8, 0x216d180, 0xc0002c71d0)
/usr/local/go/src/net/http/server.go:2391 +0x29c
net/http.Handle(...)
/usr/local/go/src/net/http/server.go:2434
github.com/infracloudio/botkube/pkg/metrics.ServeMetrics(0x1d0fdda, 0x4)
/app/pkg/metrics/metrics.go:29 +0x5f
created by main.startController
/app/cmd/botkube/main.go:81 +0x13d

@kingdevnl I think something is broken in the master branch of botkube.
If you use this commit it will work: https://github.com/infracloudio/botkube/commit/a3ff62f8654cdd2f83c2476f7d96e3f82f09509c

@unixfox I did build it using that commit hmmm https://i.imgur.com/DC5duQ4.png

@codenio @unixfox we need to come up with a way to add integration tests for this. Otherwise, going forward, as new integration coming in, it would be too difficult to test integrations manually each time we make a release.

@kingdevnl You used the commit 4e0e433 (the newer one) and not a3ff62f (the older one).

https://i.imgur.com/OCUC5OX.png
@TestBot get pods
Command not supported. Please run /botkubehelp to see supported commands.
@TestBot ping
pong from cluster 'not-configured'
K8s Server Version: v1.18.3+k3s1
BotKube version: v0.10.0

need to come up with a way to add integration tests for this

@PrasadG193 I guess this is becoming a common issue for notifiers like Mattermost,  Discord, MsTeams, and Telegram.
coming up with a solution would benefit all these notifiers.
creating issues and marking it as Help Wanted would notify more people and might get a helping hand from the community.

@codenio Could you check if you have the same bug as me?

I just found an odd bug.
I'm able to ping/send commands to the bot through the desktop Discord client but not on the Android Discord client.

The first message is from the Android Discord client and the second is from the desktop Discord client.
@codenio Could you try to replicate the bug by sending a ping to your botkube from your Android Discord client?

@unixfox @codenio same issue here, only works on desktop client.
Also, is there anyway to send messages as a DM instead of to a channel?

@unixfox and @onedr0p, sorry for the delay.
I had fixed the Android Discord client not working bug and verified that it is working now.
do check and verify the same.

Thank you @codenio!
Does someone know why I'm getting this error when compiling the code with the new commit:

INFO[2020-08-07T08:44:27Z] Registering the filter ImageTagChecker
INFO[2020-08-07T08:44:27Z] Registering the filter IngressValidator
INFO[2020-08-07T08:44:27Z] Registering the filter NamespaceChecker
INFO[2020-08-07T08:44:27Z] Registering the filter NodeEventsChecker
INFO[2020-08-07T08:44:27Z] Registering the filter ObjectAnnotationChecker
INFO[2020-08-07T08:44:27Z] Registering the filter PodLabelChecker
INFO[2020-08-07T08:44:27Z] Starting controller
INFO[2020-08-07T08:44:27Z] Starting discord bot
INFO[2020-08-07T08:44:27Z] BotKube connected to Discord!
panic: http: multiple registrations for /metrics
goroutine 26 [running]:
net/http.(*ServeMux).Handle(0x3489840, 0x1d1852b, 0x8, 0x216d1e0, 0xc0001cf560)
    /usr/local/go/src/net/http/server.go:2391 +0x29c
net/http.Handle(...)
    /usr/local/go/src/net/http/server.go:2434
github.com/infracloudio/botkube/pkg/metrics.ServeMetrics(0xc00004004d, 0x4)
    /app/pkg/metrics/metrics.go:29 +0x5f
created by main.startController
    /app/cmd/botkube/main.go:81 +0x13d
stream closed

?

I got this error, but managed to bypass it by commenting few lines in main.go (line 81 and above) for fixing the bug
/metrics endpiont used by prometheus client for exposing metrics is getting multiple http registrations.

@PrasadG193 are unit tests really holding up adding new notifier integrations, specifically this one? I understand tests are important, however they can always be added later on.

resolved it. can you check now..?

Yes it's working without any error. Thank you!

Working great on mobile now too with @unixfox docker image. Thanks you two!

Any update here from the maintainers? I've been using a docker image built from this PR for a month now and it works great.

@codenio We can target and get this in in upcoming release. Could you please take a stab at adding documentation? We use hugo for hosting docs. The docs repo is: https://github.com/infracloudio/botkube-docs

We have improved test coverage for the notifier interface. For discord bot interface tests, we can revisit this later.

@PrasadG193 will certainly add corresponding docs, can we get this PR merged now..?

:pray: , feeling relieved., @all thanks for the extended support, thanks @PrasadG193 and @sanketsudake for the reviews and feedbacks.

Thanks for all the hard work and patience @codenio

Realy thanks man  <3


UnsatisfiedLinkError on Samsung Galaxy s5 Neo (s5neolte) Android 6.0.1

java.lang.UnsatisfiedLinkError:
at com.scottyab.rootbeer.RootBeerNative.setLogDebugMessages (Native Method)
at com.scottyab.rootbeer.b.i (SourceFile:373)
at com.scottyab.rootbeer.b.a (SourceFile:45)

Hi!
I have the same issue, one of our customers run into this on LeMobile LEX720:
Fatal Exception: java.lang.UnsatisfiedLinkError: No implementation found for int com.scottyab.rootbeer.RootBeerNative.setLogDebugMessages(boolean) (tried Java_com_scottyab_rootbeer_RootBeerNative_setLogDebugMessages and Java_com_scottyab_rootbeer_RootBeerNative_setLogDebugMessages__Z)
at com.scottyab.rootbeer.RootBeerNative.setLogDebugMessages(Unknown Source)
at com.scottyab.rootbeer.RootBeer.checkForRootNative(Unknown Source)
at com.scottyab.rootbeer.RootBeer.isRootedWithoutBusyBoxCheck(Unknown Source)

Me too.
This is my google developer console report.:

But in the source of RootBeer.java it says:
public boolean checkForRootNative() {
[...]
RootBeerNative rootBeerNative = new RootBeerNative();
try {
rootBeerNative.setLogDebugMessages(loggingEnabled);
return rootBeerNative.checkForRoot(paths) > 0;
} catch (UnsatisfiedLinkError e) {
return false;
}
}
So is my app crashing or is this Exception caught and returning false so the app can continue running?
Kindest

I've changed the way the build works in the latest (0.0.7) release so that if the NDK is not found, it will use the bundled .so files otherwise it will compile them. Please let me know if this fixes the issues you were having. Thanks

Some users actually have an issue with the bundles .so files which raise a UnsatisfiedLinkError.
But this issue is raised bacause there is no implementation found of the RootBeerNative setLogDebugMessages function.
Look at some of the forks of this project and you will see that some branches are even named after this problem.
Kindest

I believe that was caused by outdated .so files being bundled with the app accidentally (probably my fault, Sorry!). The method def exists in the C code and in the .so files provided now. This is now fixed in the latest version, and even so if the NDK is found while using this library it will compile the .so files and use those versions rather than the bundled ones. So double fixed :)

I believe that was caused by outdated .so files being bundled with the app accidentally (probably my fault, Sorry!). The method def exists in the C code and in the .so files provided now. This is now fixed in the latest version, and even so if the NDK is found while using this library it will compile the .so files and use those versions rather than the bundled ones. So double fixed :)

I am using version 0.1.0 and this problem is still being reported by my users


[office-addin-debugging] On Mac, .bin contains CRLF instead of LF

MacOS still appears to have the problem of getting
$ office-addin-debugging stop manifest.xml env: node\r: No such file or directory error Command failed with exit code 127.
The way to resolve the issue locally is to change the line ending in .bin -> office-addin-debugging from CRLF to LF.
Originally posted by @jpshankle in https://github.com/OfficeDev/Office-Addin-Scripts/issues/160#issuecomment-512816441

We don't create the .bin folder. It is created by "npm install" based on the "bin" in package.json.
Please let us know what versions of Node and NPM you are using:
node --version
npm version
Also, on my Mac, I have installed Node via homebrew. It would help to know how you've installed Node and whether you are also using something like NVM to be able to switch NPM versions.

Node: 12.6.0
Yarn: 1.17.3
with Npm 6.9.0 You get:
npm ERR! file sh
npm ERR! code ELIFECYCLE
npm ERR! errno ENOENT
npm ERR! syscall spawn
npm ERR<EMAIL_ADDRESS>start: `office-addin-debugging start manifest.xml`
npm ERR! spawn ENOENT
npm ERR!
npm ERR! Failed at the<EMAIL_ADDRESS>start script.
npm ERR! This is probably not a problem with npm. There is likely additional logging output above.

npm ERR! A complete log of this run can be found in:```

Please see if you have different results when using Node 10.

I ran into this problem too. Fixed it by changing the line endings of node_modules/office-addin-debugging/cli.js

node 8 and 10 both work correctly.

@jpshankle Thanks for the info. I think this is a bug with Node 12, although I couldn't find any issues related to it when searching the repository. Do you want to open an issue there? https://github.com/nodejs/node/issues
Also, do all of the node_modules/.bin files have the issue or is it specific to a particular package?

I'm seeing the same issue with Node 10. Changing the line ending fixed it.

@akrantz the .bin folder is created by NPM by symlinking whatever you specify in the bin field in package.json. You have specified lib/cli.js, which is exactly what is symlinked into the .bin folder. You have CRLF endings in this file, hence the issue here.
npm/npm#12371 seems to relate, but I don't think it was ever definitively resolved (despite being marked as such). I'm not sure it can be resolved to everyone's satisfaction, because NPM shouldn't really be assuming anything about people's uploaded code.
By adding the shebang #!/usr/bin/env node to the top of this file, the authors are effectively attempting to create a *nix compatible executable file. They're not following the spec by then using CRLF endings in that file, which is why it is breaking—which is the authors' fault, not NPMs.
It is never going to be a node issue, because node doesn't come into the picture until the shell successfully parses the shebang, so node version is not relevant. It could be that previous versions of npm worked round this mistake, or it could even be that previous versions of bash on macOS could deal with CRLF, which might be why it seems to work for some.

@TCourtneyOwen I wonder if this is really a git issue or rather from the fact that we usually build and publish from Windows machines.

Also, this mentions that .bin is symlinked to lib/cli.js but now these should all be symlinked to cli.js, and it requires(lib/cli.js). I'm still not sure what the real issue is here because I've not had problems when using these packages on my mac with Node 10. I'm also curious if Node 12 becoming LTS will result in a different behavior.

@akrantz Are you building these packages yourself on your Mac or are you installing from NPM?

I think the project just needs a .gitattributes file with say cli.js text eol=lf

When I had investigated this months ago, I was not able to reproduce on my Mac when installing the packages from NPM. It seems related to the Node version at the time based on information provided. Given the latest discussion, there seems to be the possibility that because the published packages have CRLF in the cli.js or lib/cli.js or other files, this is potentially an issue. If that is really the case though it seems this would be an issue for all of the these packages which are published when run on Mac, and that does not seem to be the case. So, I feel skeptical that this is really the issue but wanted to gather the data so that I can know if there are steps we could take to resolve this issue.

I believe it is a yarn vs npm thing. NPM does appear to convert line endings when linking the bin files into .bin. Yarn has an outstanding issue at yarnpkg/yarn#5480. It's still on package maintainers to publish the correct line endings though, regardless of whether one package manager works around it for you.

I'm having the same issue and created a minimal example with Github Actions of this problem before landing here:
https://github.com/bockstaller/lineending_demo/actions/runs/1739321056
Is there any progress on this topic?

I am unfamiliar with some of the intricacies of npm and yarn in relating to the .bin folder and the line endings.  We have code files cli.js in the root and the cli.ts in the src folder.  The lib/cli.js is generated by the build and I'm not sure how the .bin files in node_modules folder relates to any these.  Which code files would need to be modified to use LF in order for the right thing to happen on mac when using yarn (note I have not tried to reproduce this myself yet).

Without trying this out myself, it should probably be enough to convert the cli.js file itself from CRLF to LF. It seems to be one of the very few files that have CRLF EOL in the repo, e.g. the src/cli.ts file you mentioned is already LF, as is the package.json of this package.
Furthermore, the files probably should not be checked out with CRLF on Windows for building the packages for an NPM release. I.e. build them on a Linux or Mac machine or VM, in WSL, or set the Git repo to check out the files as they are in the repo (git config core.autocrlf false).

TBH this is new territory for me, but I got it running locally on my Mac

Clone this [oas] and my minimal example [me] locally
[me] yarn install && yarn run validate to verify that the problem persists
[oas] followed this guide (on the mac only the second half, because here I am running LF per default)
[oas] npm install, cd office-addin-manifest && npm install, npm run build && yarn link
[me] yarn link "office-addin-manifest" && yarn run validate -> the problem no longer exists

So theoretically ™ everything is fixed now. Assuming yarn uses the same logic everywhere and my mental model is somewhat correct.
I'll push the updated files in a minute

So this is what I'm seeing and learning:

VS Code shows the same file's line endings in the status bar differently on a Mac vs. a PC (mac can show LF while on windows the same file shows CRLF)
A couple files in this repo show the same in both platforms (CRLF) and cli.js is one of those files
There is a git command to show the line ending information: git ls-files --eol
This git command shows an index ending and a working folder ending and the index ending doesn't change on the different plaforms while the working directory one does.
cli.js shows "mixed" line endings for both working and index

I also found the command 'git add --renormalize .' will fix the index ends to be the standard LF that all the other files list.  I think this is the correct change . . . but I'm not sure how to verify it before checking it in.

You can validate a part of the fix like I did here https://github.com/bockstaller/lineending_demo/commit/c3fca79154d80658fc8cfcff4b903026dfd26982?diff=split
I moved the build .tgz into my minimal example and install it manually, as described here. This fixes the problem in the yarn_new_package-job, while it persists in the old yarn-job where the new package isn't installed https://github.com/bockstaller/lineending_demo/actions/runs/1741951208
But this doesn't help you avoid regressions

Git has a way to normalize line endings for the working tree, but I don't think this is related to the issue with line endings in .bin files. The working tree will have line endings as CRLF on Windows whereas it is LF on Mac/Linux. When checked in, they are normalized to LF. However, I don't think this issue relates to the .bin files.
It's likely either because the NPM packages are built on Windows and then published to NPM, so perhaps the .bin files which are published have CRLF because of that.
It would help to have more clarity about the root cause of the problem.

I'd like to investigate more and see if the source files make a difference, but I need clarity around how .bin files are generated and used and why that seems related to the problem.

The files in the bin folder are copied there according to this configuration option: https://docs.npmjs.com/cli/v8/configuring-npm/package-json#bin
This carries over the CRLF eol to the build output.
But I did find this option https://www.typescriptlang.org/tsconfig#newLine, which allows to normalize the build outputs lineendings, independent of plattform.
Testing it on my mac and windows machine showed that the build output, indeed changed from CRLF to LF with the option activated.

I'm noticing that when I import office-adding-debugging to a project that on windows the file in the bin folder include 3 named office-addin-debugging, office-addin-debugging.cmd, and office-addin-debugging.ps1.  The cmd file uses CRLF while the other two use LF.  The code inside these files references the clit.js file in the root (which imports the one in the lib dir).  But on mac it looks like a direct symlink to cli.js in the root.  This is all based off using npm . . . but it seems like yarn is doing something different and I still need to try that out.
vbudovski-plexus said that changing the line endings in the root cli.js file fixed it for them and that is the file that git identified as mixed in both the index and working versions (using --renormalize updated the index case to LF).

I installed and used yarn on my Mac machine and was unable to reproduce the error myself (deleted and had it create the node_modules folder and everything in it).  The files in .bin looked the same as those generated by npm on both mac and winodows respectivly.  Something else must be going on.

I setup a fresh Ubuntu-20.04 WSL instance and installed node/npm with yo and generator-office. When generated a project it had various dependencies from Office-Addin-Scripts. Most of the .TS files in the various src folders (within node_modules) all where saved with CRLF. The files in node_modules/.bin are symlinks to their respective files.
As this is the first one I ran into issues with, I will use it as an example:
office-addin-lint: /home/ck/mj/node_modules/.bin/office-addin-lint -> \home\ck\mj\node_modules\office-addin-lint\lib\cli.js
\home\ck\mj\node_modules\office-addin-lint\lib\cli.js is saved as CRLF.
As a result whenever I try to execute npm run lint
I get the error /usr/bin/env: ‘node\r’: No such file or directory
If I where to guess (and a few other files have this set): https://github.com/OfficeDev/Office-Addin-Scripts/blob/5c380f3fa8042a4f4e3c132c2f86757d9e7e5b6f/packages/eslint-plugin-office-addins/src/main.ts#L35
I would change any endOfLine prettier setting to "LF".

I don't think the issue isn't what is checked out with Git (the "working tree") but what is being published to NPM. When NPM install is run, the question is where the contents of the .bin folders come from and why it's not normalized to LF.

Just saw the previous comment about the tsconfig newLine setting. That sounds promising.

I don't think the issue isn't what is checked out with Git (the "working tree") but what is being published to NPM. When NPM install is run, the question is where the contents of the .bin folders come from and why it's not normalized to LF.

The lint jobs are ran before the build. Since endOfLine is set to auto, it will preserve the EOL settings for the file it is processing. If you change the endOfLine setting to LF from auto, the files that are generated in the build process (thus the .bin folder) will then have LF EOF characters.

If the .TS file is ever saved as CRLF and the prettier rules stay as auto, then the files will never be changed to LF. Example: If you look at office-addin-lint\src\cli.ts it is saved as CRLF. As such, any file generated from it will be CRLF. Since prettier is set to auto for endOfLine, it will not change it to LF or even flag is as incorrect if npm run lint or npm run lint:fix is ran.
This will probably only be an issue if its built by someone who has core.autocrlf set to true. As on checkout: converts LF to CRLF. So when the user runs the install with that setting, they will get CRLF files. But if the package is built on a machine that has not changed core.autocrlf OR the build process runs lint:fix first (and the prettier files are chnged from auto to LF) then the resulting files will be correct.

Building before changing endOfLine in eslint-plugin-office-addins/src/main.ts and eslint-plugin-office-addins/.eslintrc

Building after changing endOfLine to lf

Running lint:fix after changing endOfLine to lf in the root folder will fix any files you need to as well.

So after coming back to this and re-thinking through the comments I think I understand things a bit better now.  I was thinking about maintaining line ending in the files themselves as they were stored in github an it's influence on npm, but now I understand that it more about the build output itself.  While the file contents influence that (as indicated by using prettier and some of the things I was looking at) I think the better option is the complier flag for typescript (which I didn't understand before) that makes the js file output us LF reguardless of with the original code files (i.e. working directory) have.  I am make a PR the updates the tsconfig files to do this and then the next time we update the packages they should be corrected.

temp fix (expericned tis on fresh ubuntu machine): cat office-addin-dev-certs | tr -d '\r' > office-addin-dev-certs

This should be fixed in the current office-addin-dev-certs package (yo office output still needs to be updated).


CDEvents Specification 1.0

The latest release of CDEvents is v0.3.
CDEvents v0.4 is planned for the end of August 2023.

@zestyroxy for your radar ^^^

This work on this issue will be tracked through https://github.com/cdevents/spec/issues/169


Add tablet to FishFeeding

What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
Feature: Adds the tablet prefab to the FishFeeding scene and created ScoreTablet.cs to evaluate the fish feeding task for tablet.

What is the current behavior? (You can also link to an open issue here)
No tablet in Fishfeeding. Closes #177, #178

What is the new behavior? (if this is a feature change)
There is a tablet in the left holster of the player and shows the task fish feeding task and its subtasks. While playing the task the player should be able to trigger the completion of subtasks by steering the camera with the joystick, changing feeding intensity for the current cage and pressing a fish cage button. ScoreTablet.cs calculates the score at the end but the UI for this is not done yet.

Does this PR introduce a breaking change? (What changes might users need to make in their application due to this PR?)
By importing the tablet, FishWelfare that used to use the old tablet creates a lot of yellow errors since it is trying to access files that don't exist anymore. However, both FishWelfare and FishFeeding scenes still works.

Other information:
The UI for score, score to each skill and for showing the completion of the fish feeding task does not work.
Showing the completion of the subtasks does not work in the build in addition to previously mentioned issues.
The editor uses the right hand when clicking on the tablet and in the build the left hand is used.

Additional new changes:

Added new fix for Tablet from VR4VET and shows the score page with table, but it doesn't show the updated score values.

Fixed the previously mentioned issues and added new fix for Tablet from VR4VET. The placeholders should have been gone now, @ingolvjr check if you have the same version of the Tablet Adapted.prefab.
Discovered new bug where the hologram camera doesn't update to new fish cage camera when playing the game in build, @eamathie could you help me there?


ValueError: Charge of 0 and spin multiplicity of 1 is not possible for this molecule.

Details about the quacc environment

quacc version: 0.6.3
Python version: 3.11.7

What is the issue?
With a forcefield this will always happen if the system contains an odd number of electrons?
quacc/atoms/core.py", line 191, in check_charge_and_spin
How can we easily reproduce the issue?
# Paste your *minimal* example code here

Thanks for the report. Can you please provide some more details about how you are getting this error in a given calculation? Some additional context would be helpful. I'm aware of why the error is being raised, but it's not yet clear to me how this would come up in a practical scenario.
Let's consider O2:
from ase.build import molecule
from quacc.recipes.lj.core import static_job

atoms = molecule("O2")
atoms.set_initial_magnetic_moments([1.0, 1.0])
static_job(atoms)

This works and is charge = 0, spin multiplicity = 3.
Now let's try O2-, superoxide which has an odd number of electrons.
atoms = molecule("O2")
atoms.set_initial_magnetic_moments([1.0, 0.0])
atoms.set_initial_charges([-1.0, 0.0])
static_job(atoms)

That works. However, just doing atoms.set_initial_magnetic_moments([1.0, 0.0]) would not work because it's impossible to have O2* neutrally charged.
Some additional context would be beneficial.

atoms = Octahedron("Pt", 3, 1)
atoms[0].symbol = "Au"

static_job(atoms, model="large", method="mace")

The charge and spin multiplicity should only be reported in the output schema (and therefore checked for internal consistency by quacc) if the structure lacks periodic boundary conditions. Here, your structure is an isolated cluster with no PBCs. If you were to throw that into a molecular DFT program like Gaussian, ORCA, or Q-Chem, it would error out for the same reason. Is there a reason why you do not have PBCs enabled for this system, not even a vacuum box?

Indeed setting pbc to True avoid the issue! I am not sure if this is mentioned in the doc, if it is sorry for the inconvenience.
This behaviour might surprise careless users, I only see one case where this will fail: running these kind of clusters with martyna-turckerman on (pbc set to False) but I guess this is somewhat of a niche case

Thanks for investigating. This wasn't mentioned in the docs because, I must admit, it wasn't a scenario I had thought about.
Basically, what is happening behind the scenes is that quacc is trying to make metadata for the Atoms object. It does this by converting it to a Pymatgen Structure or Molecule object, for which we have detailed routines to generate all the metadata. If the Atoms object has no PBCs, it's assumed to be a Molecule (since Structure is for materials with a lattice). In generating the Molecule metadata, it reports (and checks) various molecular properties like the charge and spin multiplicity. Here, if you passed your cluster into a molecular DFT program with charge = 0, spin multiplicity = 1, it would fail, and quacc does the same. But here you are at an awkward edge case where you aren't running a molecular DFT calculation but the structure itself lacks PBCs so it's being treated like a molecule.
I'll do some digging to see if/how I can ensure spurious errors aren't raised while also making sure the metadata for the molecular DFT folks continues to be generated correctly.

I have seen a check_metal function somewhere, if it’s a metal quacc does not check? it’s not perfect but will surely help?

I'd prefer to address the problem at its source. Not to worry. I'll sort it out in #1646, almost certainly.


Data Filtering: Plug and Play Device Tree in KD (Kernel Mode)  --> Example not working.

Issue1 :
DeviceTree is not populated. I have a kernel dump
0: kd> dx -v Debugger.Sessions.First().Devices
Debugger.Sessions.First().Devices
LogicalProcessors
0: kd> ||
.  0 64-bit Kernel bitmap dump: .........MEMORY.DMP
Issue 2 : This is a simple typo: Name of script is deviceFilter however when using it the text suggests it is PlugAndPlayDeviceTree
0: kd> .scriptload c:\WinDbg\Scripts\deviceFilter.js
JavaScript script successfully loaded from 'c:\WinDbg\Scripts\deviceFilter.js'
vs
dx Debugger.State.Scripts.PlugAndPlayDeviceTree.Contents.filterAllDevices()

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 17e185d6-e8c5-5063-eba1-7c63e3c3e198
Version Independent ID: cd913396-ce95-bd85-d742-f7bf43779b86
Content: JavaScript Debugger Example Scripts - Windows drivers
Content Source: windows-driver-docs-pr/debugger/javascript-debugger-example-scripts.md
Product: windows-hardware
Technology: windows-devices
GitHub Login: @DOMARS
Microsoft Alias: domars

@pankajbharti - Thanks for the feedback. I updated the document to indicate that a live connection could be used. So full dump files or certain mini dump file types may contain enough information for the object model, but I think the safest approach is to use a live connection. The !devnode 0 1 command should display device information. I also fixed the inconsistency in the sample script file name. Thanks for pointing that out, and the interest in improving the debugger automation documentation.


Checking one item make that all others checkboxes get checked

When I ckick over an item all checkboxes are checked and clicking again, even not in same item, make that all get unchecked. This doesn't reflect in ngModel. I already try to write a new code using the least as posible and the problem persists. the same code worked before, but even tryng a simple exemple i face this same problem.

Hi, I am getting same issue, but for me first position data is bind with ngModel it is also highlighting(checkbox) second position data. working fine with data level but UI is not proper.
Please help me out


switch to typescript

it'd be nice to have types defined especially if we want to include a database later.

no longer doing, moving to flutter


Alligned images in new collections section perfectly

Fixes #95
Sizes of image in new collections section are now alligned perfectly as shown in below screenshot

[Bug]

My code follows the style guidelines of this project
I have performed a self-review of my code
My changes generate no new warnings

Ohk Great work @Amitooo1


Add Kalosm to the list of external resources

👋 I have been working on a meta-framework built around candle model for the past month called kalosm. It provides a higher level API over some models from candle-tranformers:

LLMs (Phi, Mistral)

Controlled generation support through a nom-like incremental parser combinator framework
Custom sampler support
Streaming support

Embeddings (Bert, Llama through llm.rs)

Document databases with support for fetching data from the web, search engines and local documents in various formats
Batched embedding support

Transcription support through Whisper

Microphone integration (eg. gather context from the live surroundings)

Image generation through Wuerstchen with support for the image crate
Image segmentation with segmant-anything with support for the image crate

This PR adds Kalosm to the resources section of candle.
Thank you for your work on candle, it has been great to work with so far!

Looks like a great project, thanks for building this and for the added pointer!


Intermittently get "Failed to read /dev/tty error: you did not choose any of the options" in Interactive mode

OS: Ubuntu 16.04
fzf version: 0.17.5 (b46227d)
Not sure how to get the version I am using of kubectx and kubens
When I run kubens or kubectx, I get this error:
Failed to read /dev/tty
error: you did not choose any of the options

I do not get this on my MacOS. Not sure if there is something wrong in my configuration.
Update: Seems like this issue might be the culprit: https://github.com/junegunn/fzf/issues/1486

Yeah we got this issue several times now. fzf or a kernel issue seems to be the culprit.

Closing as the same issue as #128.


To phase space for states

Context: Add the to_phase_space function for states.
Note that this is branched out from PR368 to use the D_s_map.
Description of the Change: This function receives the state and changes the representation of a given mode.
Questions left:

[ ]  What would be the best returns? If this is a N-mode state, the state has been transformed totally into phase space, would it be stored in the phase space representation somehow? If the state is just partially transformed into another representation, how to label it?

Benefits:
Possible Drawbacks:
Related GitHub Issues:

I'll close this PR since this is the work after in states, unitaries or channels. My work needs to finish the triple for the transformation gate first. I'll open a new one to add the triples gate from_quad and to_quad.


Implemented queue using arrays

#330

Added the implementation of Queue using arrays.
I have added a switch case driven interface which is much more useful to understand the operations clearly.
Provided comments where required
Provided test case and output for program

@rudrakshi99 Please review my PR


[feature request] ln -T flag

coreutils ln has a -T flag that ensures that the new link name is always treated as a filename rather than a directory name. It's especially useful with -sf, because it allows invoking ln to create-or-replace a symlink without having to remove the old one first or worry about whether it points to a file or a directory.
e.g.
mkdir A B
ln -sf A L # creates a symlink, L -> A
ln -sf B L # creates a link, A/B -> B (broken link)
ln -sfT B L # replaces the link, L -> B

It seems like a useful thing to have, but it also doesn't appear widely supported.
Busybox's ln has a -T option, but rather than treat the link name as a file, it appears to detect when the link name is a directory and abort. I think that loses most of the benefit of the option.
This came up recently for me when working on a script used with Android (but not one that's likely to use Toybox) -- https://android-review.googlesource.com/c/platform/bionic/+/1127567/1..2.
GitHub Code Search shows some matches for ln -sfT: https://github.com/search?p=4&q=ln+-sfT&type=Code

Does this have same effect?
ln -sfn B L

I hadn't noticed the -n option before. Yeah, that accomplishes most of what I care about, so maybe -T isn't needed.
The remaining difference seems to be: -T ensures that ln fails if a path that was intended to be a new symlink is instead a directory (not a symlink to a directory). busybox's ln has both -n and -T, and ln -sfnT B L with either busybox or coreutils appears to work the same way as ln -sfT B L on coreutils.

I added -T, 51cc908ee406


Wrap pip error with MLEM error

$ mlem build venv --model lyrics2emoji --current_env True
⏳ Loading model from lyrics2emoji.mlem
💼 Detected the virtual env /Users/aguschin/Git/iterative/mlem/emoji/.venv
💼 Installing the required packages...
ERROR: You must give at least one requirement to install (see "pip help install")
❌ Error running pip
Command '['/Users/aguschin/Git/iterative/mlem/emoji/.venv/bin/python', '-m', 'pip', 'install']' returned non-zero exit status 1.

Plus another typo here:
(.venv) $ mlem build venv --model lyrics2emoji --current_env True
⏳ Loading model from lyrics2emoji.mlem
💼 Detected the virtual env /Users/aguschin/Git/iterative/mlem/emoji/.venv
💼 Installing the required packages...
...
Successfully installed numpy-1.23.5 scikit-learn-1.1.1 torch-1.13.0
✅  virtual environment `venv` is ready, activate with `source venv/bin/activate`

Should be
✅  virtual environment `.venv` is ready, activate with `source .venv/bin/activate`


Simplified filter to remove hidden scenes

Filter Scenes by Name in the Vue Computed Data Function
This PR proposes a fixed format for identifying scenes to hide from the Scenes panel. For more complex productions with multiple nested scenes, the display in this remote becomes cluttered, button names become difficult to differentiate, and each touch target becomes dangerously small.
Hiding a Scene
To hide a scene, simply add any of these three strings to the end of the scene name:

[Hidden]
^^
~~

Change Description
This PR simply adds a computed property to the panel that uses the Array.filter() function to remove any scenes whose names match a Regular Expression seeking one of those three signifiers on the end.
Then, rather than using the unfiltered scene array to populate the list, the v-for clause now pulls scenes from the filtered list.
Comparison to Other PRs
There is one other PR to accomplish something similar, allowing for the user to specify a prefix; however, that method runs into issues when removing or changing the prefix.
This approach is less flexible in that it does not allow for arbitrary tagging to remove scenes from the list, but it completely avoids the problem of causing a blank list when changing the tag.
This method also avoids the combination of v-for and v-if.
The ^^ or ~~ strings are exceedingly unlikely to be used in general practice, and should not conflict with desired scenes.
[Hidden] is more obvious to English-speaking users, but not conducive to translation in this RegEx.

Resolves #52


createAction() method in UserController.

Creation of createAction() method in UserController.

1hour

Creation of createAction() method in UserController is terminated.


Consider making query stats optional and prefixed by %

Hi,
I see that all queries are suffixed by some stats about how long that query took: https://github.com/likexian/whois/blob/master/whois.go#L98. Would you consider using % as a suffix (as is done by all whois servers I know anyway), and making it optional?

Hello @rissson
Thanks for your feedback.

The comment prefix is change to % now.
You can use SetDisableStats(true) to disable the stats.

If you think this repository is helpful, please share it with friends, thanks.


Convert Swift4 Syntax

Convert swift4 syntax & XCode9.
Please check it.

OK please merge !!!

Thank you so much!


Python 3 Support

Hi,
This package is great! Although the lack of Python 3 support is sorely felt and I would really appreciate it if you could provide that.

Sure.
The package is also a bit outdated because Django did changes to their
Authentication Backends, and I didn't update appropriately.
On Wed, Feb 15, 2017, 11:53 Varun Agrawal<EMAIL_ADDRESS>wrote:

Hi,
This package is great! Although the lack of Python 3 support is sorely
felt and I would really appreciate it if you could provide that.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/ParthKolekar/django-cas/issues/5, or mute the thread
https://github.com/notifications/unsubscribe-auth/AGFgDlezYk5r642o8eahGR-eXRb3YLLmks5rcpnXgaJpZM4MBWHb
.


[FLOC-3843] Fix docker test private registry image

This may be a fix for FLOC-3843. My current working theory is that the timeout on this test occurs when there is still another container running at the point this test is run, causing us to loop indefinitely as we wait for a response on the wrong port. (this scenario actually happened on my dev laptop, so it's definitely a potential cause)

Thanks Dave! Please address comments and resubmit.

Thanks! LGTM


what is th possibility of imagePullPolicy for the node-cpu-hog which is default set to Always ?

while executing node-cpu-hog experiment , resources are getting created :
NAME                        READY   STATUS         RESTARTS   AGE
nginx-6bbd77d656-pvzjl      1/1     Running        0          11m
nginx-chaos-runner          1/1     Running        0          84s
node-cpu-hog-bl7m80-bszhs   1/1     Running        0          46s
node-cpu-hog-dghdgu         0/1     ErrImagePull   0          39s
The problem is , when node-cpu-hog-xxxxx pod is being created is goes to ErrImagePull as my lab doesn't have Internet connection to pull the image dynamically , with the below specification
spec:
containers:

args:

--cpu
"8"
--timeout
"60"
command:
stress-ng
image: litmuschaos/go-runner:1.9.0
imagePullPolicy: Always
name: node-cpu-hog

Is there any possibility to change the ImagePullPolicy in the node-cpu-hog pod that is created by go-runner image with ./experiments -name node-cpu-hog
Images are used :
litmuschaos/go-runner:1.9.0
litmuschaos/chaos-operator:1.9.0
litmuschaos/chaos-runner:1.9.0

Being tracked via the duplicate issue on this: https://github.com/litmuschaos/litmus/issues/2335


Voltage information

In case the API already supports it, information about the current voltage for each string would be good.
I'm using the EZ1 with a battery and it would be great if I could get the battery voltage here. This way I would be able to replace the inaccurate voltage readings from my Shelly Uni with the ones from the micro inverter. I use the voltage in automations to prevent the battery being discharged below 10% and for a ruff estimation of the batteries charge state (this value decides when and how much power is used from the battery).

@silviokennecke I will forward this to APsystems to see if they can implement it.


Remove meta from join list

You don't have permission to put k in #meta, so stop trying to put k in #meta.

is this pr even needed? its banned from meta anyways

I mean, it'll save the bot the computation cycles of sending the JOIN command to a channel it's banned from. It's an optimization.

Has the bot created any spam? @MineRobber9000

You don't understand. You have to actually get permission before tossing a bot in #meta. You can't just be like "I'm not making any spam so its good".
Also, yes, you have created spam. You blind-messaged neko about your reimplementation of oven (which was a ripoff of badger anyways.) That's not cool.
You need permission from an IRCOp before putting a bot in #meta, and you've made a horrible first impression.

As I've remarked in #meta,

I had permission. Written permission
Fair enough, it created spam. That will be fixed very soon (tomorrow at latest).

You had permission for #team, not #meta. Are you dyslexic? If so, I'm sorry for making fun of you.
The logs show you have permission for k in #team. If you have an email showing you have perms for k in #meta, then show it (ben's online right now).

Has the bot created any spam? @MineRobber9000

yes

Fair enough, it created spam. That will be fixed very soon (tomorrow at latest).

then why was it in meta before tomorrow lol

Due to a misunderstanding k was put into meta while it only had permission for the teams channel.
I'm going to leave this open until I receive an explicit approval or disapproval from ben. In the mean time, the bot will stay only on the bots channel.

The disapproval has been received. However, as I already removed #meta from the channel list, this PR is unnecessary and will be closed.


Add more support for additional markets.

Currently, the SYNTHETIC_ID_MAP and ASSET_RESOLUTION don't include a lot of the newly added markets on DYDX as shown in the v3-python implementation: https://github.com/dydxprotocol/dydx-v3-python/blob/dc7705ed51891c4901f26bfed9ca91a0e95ce1aa/dydx3/constants.py#L61
Please add support for all the markets as we cannot submit Orders because the signature fails on non-supported markets as outlined in the constants.go file
https://github.com/yanue/starkex/blob/master/const.go

the SYNTHETIC_ID_MAP and ASSET_RESOLUTION are now defined in the new file:
https://github.com/yanue/starkex/blob/master/assets.go
and support for all the markets.


Add LAP_ELAPSED_TIME as an allowed dependency

There is currently enum to subscribe to events. Can you add the another enum value for LAP_ELAPSED_TIME?
https://github.com/hammerheadnav/karoo-sdk/blob/fed4843ec333098f6f6c7f989aafe95b95060bfd/karoo-sdk/src/main/java/io/hammerhead/sdk/v0/datatype/Dependency.kt#L27

Thanks for your interesting in developing functionality for Hammerhead's devices. karoo-sdk is being deprecated in favor of karoo-ext. Check it out and open any questions/issues over there now.


Support /mediachain/node/id protocol

Adds a remoteNodeInfo method to MediachainNode that retrieves the ids and info message.  Also adds an idHandler to provide the same, although the publisher id is blank since aleph doesn't support them yet.  I did add an infoMessage to the node constructor, so you can set the info string.
A thought I had when adding that infoMessage parameter is that it won't persist between invocations... maybe it's worth adding a way to save the node configuration (id, info, directory address, etc) to a single JSON file?

:+1:

@yusefnapora I'm thinking we will need structured infoMessage, over the free text

yeah, I suppose so.  We'll need to update the concat side as well; the proto just has a string field for the info


Revert "[cxx-interop] Start to import dependent types as Any"

Reverts apple/swift#41411
This seems to have caused a regression on Windows since the Swift CI system outage caused the platform to not be tested.

@swift-ci please smoke test

CC: @zoecarver


Rewrite xml tests to better support third party libs

Coverage decreased (-12.7%) to 76.479% when pulling ac2d73c622a4884ab47f004132968b0cc2206c38 on xml-module-tests into 9d68dfa8b2ece1b6468699bd9fd7eec7baa00d1b on master.


Typo "Azure storage emulator"→"Azure Storage Emulator"

https://docs.microsoft.com/en-us/azure/azure-web-pubsub/quickstart-serverless?tabs=javascript
#PingMSFTDocs

@hyoshioka0128 : Thanks for your contribution! The author(s) have been notified to review your proposed change.

Looks good; merging. Thanks.


Add documentation about single doc type mode

As mentioned in PR #12, there is a bit of confusion about single doc type mode due to lack of documentation. We should add something in the dev guide and in the readme to explain this feature further.

Mentioning that allowedDocTypes is a regex match would be useful

Amazing, works perfectly.  Was just about to add another PR to do exactly this before I saw this!  Thanks!


Integrate In App Update

To perform the update natively, we should implement Play Core
library to request and perform a flexible or immediate in-app
update. To avoid reinventing the wheel, I try to integrate
an existing plugin to do that.

To avoid reinventing the wheel, I try to integrate an existing plugin to do that.

That was the most exciting part of the project tho.
Anyway, the plugin decision should be done earlier and we could have tried to collaborate there.
IMHO it sounds weird to use the plugin to create another plugin.
Despiting that, can you please add the tests for the use cases we are proposing in the project?

It's common for a package to depend on another package in pub.dev
Ok, I will work on the test.

Why we closed this PR mas @JeffryHermanto ? I think it would be better if we use the same PR, otherwise the comment would be scattered.


Configurable Timeout for stack deployment

Besides some public containers we are also using some custom ones and in the end our stack has quiet some dependencies and health checks that are needed to bring it up.
Due to the startup time and health checks of some containers the total startup-time for the whole stack has increased to around 2-3 minutes. As the timeout in Portainer for a successful deployment can't be changed, I always get the "failed" message (although the stack continues to start successful at the end).
Would be nice, if we could set a maximum time to wait for Portainer until it displays this "failed" message.

need it,especially several containers (in my environment is 4) in one yml/stack,and some performance issue on the host can couse some containers startup time increased,and portainer report unable to do something,then check the container list,they are created and some one is running

I have this all the time with huge stacks, even with the business edition. Would be really nice to have.


Add ability to disable warnings in the index logs

When running the index, we get a bunch of warnings like this one below. It would be great if the warnings can be disabled (maybe through command line), to make the logs easier to read.
System.InvalidCastException: Unable to cast object of type 'MSBuild.CheckRootFileTask' to type 'Microsoft.Build.Framework.ITask'.    at Microsoft.Build.Shared.TaskLoader.CreateTask(LoadedType loadedType, String taskName, String taskLocation, Int32 taskLine, Int32 taskColumn, LogError logError, AppDomainSetup appDomainSetup, Boolean isOutOfProc, AppDomain& taskAppDomain)

You can add this exception to the whitelist at:
http://sourcebrowser.azurewebsites.net/#HtmlGenerator/Utilities/FirstChanceExceptionHandler.cs,372ef3d2c1b9e297


Investigate having some struct/interface concept

Is it safe to say that all languages support at least one of the two?

More accurately: all languages either:

Are completely untyped
Have some sort of struct/interface concept


Ractive Tutorial Lesson 10-2 Partials: Javascript error appears when deleting a line as instructed by tutorial

In Lesson 10-2: Partials, the last line of the instructions state: "Add the partial to the template, and remove it (and the var item = ... bit) from the javascript code."
I go to the JavaScript panel and remove these lines from it, as per the instructions.
var item = "
" +
         "<input type='checkbox' checked='{{done}}'>" +
         "" +
           "{{description}}" +

           "{{#if editing}}" +
             "<input class='edit' " +
                    "value='{{description}}' " +
                    "on-blur='stop_editing'>" +
           "{{/if}}" +
         "" +
         "x" +
       "
";

However, right after I delete the lines, the JavaScript panel highlights an error and prevents the panel from executing (i.e. I cannot do Shift + Enter).  Attached is a screenshot.  This error appears in both Firefox 36 and Chrome 41.0.22 on my Mac.
After a little more messing around, the error triggers if I delete even one whitespace character from anywhere in the JavaScript panel.  It doesn't have to be the "var item" line.

Apparently that bit of code is just too clever for CodeMirror, and thus probably also too clever for a tutorial :)
Will change to:
if( which === 13 ) {
    fire({ node: node, original: event });
}

fixed via https://github.com/ractivejs/learn.ractivejs.org/commit/4782e6400930835ac1cc6ecac33930253df24037 and
https://github.com/ractivejs/learn.ractivejs.org/commit/b388a9aa0bbba5f16b0914fba8f3d91038f5a729

Thanks!