Pin Mozilla's cert

We don't want to expose ourselves to the NSA MITM-ing us. We should pin Mozilla's cert.

mkcert.org is a bad idea in the first place. This is by design a man-in-the-middle. Whatever how the source of mkcert.org is reliable, no client can be sure that what mkcert.org serves now or in the future is not corrupted from the original Mozilla source.

That would be why the source code is available here, for you to build and run yourself locally if you want to.

Software to run locally are CLI or package to include in an app.
Web APIs available as public services are designed for misuse because they provide conveniency (over security) to lazy developers. And misuse there is: people build software libraries relying on the online instance of mkcert.org.

Check the commit log: I wrote that certifi software. I'm running both bits of infra, and so am quite capable of verifying the result. I think it's reasonable that I'm allowed to trust myself.


Blog Section styling [B.Tech Tea Shop]

Blog section enhanced

Close #3500

Checklist:

[✅] I have mentioned the issue number in my Pull Request.
[✅] I have commented my code, particularly in hard-to-understand areas

Before

 # After

@MohitGupta121  @TusharKesarwani  Kindly, review this PR


Uncaught TypeError: Cannot read property '0' of undefined

Uncaught TypeError: Cannot read property '0' of undefined
Atom Version: 0.156.0
System: Mac OS X 10.9.5
Thrown From: layout-manager package, v0.2.3
Steps To Reproduce

...
...

Stack Trace
At /Users/Jadam/.atom/packages/layout-manager/lib/layout-manager.coffee:49

TypeError: Cannot read property '0' of undefined
  at Object.module.exports.move (/Users/Jadam/.atom/packages/layout-manager/lib/layout-manager.coffee:49:6)
  at Object.module.exports.moveRight (/Users/Jadam/.atom/packages/layout-manager/lib/layout-manager.coffee:31:18)
  at atom-workspace.<anonymous> (/Users/Jadam/.atom/packages/layout-manager/lib/layout-manager.coffee:8:70)
  at atom-workspace.handler (/Applications/Atom.app/Contents/Resources/app/src/space-pen-extensions.js:115:32)
  at atom-workspace.jQuery.event.dispatch (/Applications/Atom.app/Contents/Resources/app/node_modules/space-pen/vendor/jquery.js:4681:9)
  at atom-workspace.elemData.handle (/Applications/Atom.app/Contents/Resources/app/node_modules/space-pen/vendor/jquery.js:4359:46)
  at CommandRegistry.module.exports.CommandRegistry.handleCommandEvent (/Applications/Atom.app/Contents/Resources/app/src/command-registry.js:243:29)
  at /Applications/Atom.app/Contents/Resources/app/src/command-registry.js:3:61
  at KeymapManager.module.exports.KeymapManager.dispatchCommandEvent (/Applications/Atom.app/Contents/Resources/app/node_modules/atom-keymap/lib/keymap-manager.js:549:16)
  at KeymapManager.module.exports.KeymapManager.handleKeyboardEvent (/Applications/Atom.app/Contents/Resources/app/node_modules/atom-keymap/lib/keymap-manager.js:391:22)
  at HTMLDocument.module.exports.WindowEventHandler.onKeydown (/Applications/Atom.app/Contents/Resources/app/src/window-event-handler.js:167:20)

/cc @atom/core

+1. Seems to happen when I attempt to move a pane too far to the left or right (as in, I have two panes open, focus in the left, and hit 'move tab to the right' multiple times in quick succession).

+1. I'm getting this error while using the key combination "Command + Control + Shift + Arrow Key" (Any arrow direction). I can't get any tabs to split into a new pane using that key combination, it just errors out for me. It will still split into a pane when right clicking on the tab and selecting the split option though..
Also I can still use the "Command + Option + - or =" for resizing -- providing they're already in a pane of course.


[xpk] Use kueue github repo manifest file instead of local one

TESTED=yes, ran xpk cluster create, and ran simple workloads that waited in the kueue.

Have you checked the diff between these files? I do think there is a diff...


NCCL Timeout if Number of Batches are not same per rank for Eval mode

Hi all,
I am following this example to run TorchRec with pytorch_lightning. However it will hangs till NCCL timeout if number of batches are different during validation stage.
I know #Batches should be same for training mode, while it does not make sense for eval mode. Did I miss something? Appreciate for your help.
Code Snippet:
class ShardedModelWrapper(LightningModule):
    """
    A wrapper for a distributed model parallel model (Beta). This is still under active development.
    """

    def __init__(
        self,
        model: nn.Module,
        loss: torch.nn.Module,
    ):
        super().__init__()

        ...

        self.dist_model = DistributedModelParallel(
            module=model,
            sharders=cast(List[ModuleSharder[nn.Module]], sharders),
            plan=plan,
            env=env,
            device=device,
        )

        # TODO: train_pipeline, val_pipeline, test_pipeline
        self.pipelines = {}
        train_pipeline: TrainPipelineSparseDist = TrainPipelineSparseDist(
            model=self.dist_model,
            optimizer=self.get_dense_optimizer(),
            device=device,
        )
        self.pipelines["train"] = train_pipeline
        val_pipeline: TrainPipelineSparseDist = TrainPipelineSparseDist(
            model=self.dist_model,
            optimizer=None,
            device=device,
        )
        self.pipelines["val"] = val_pipeline

        # This is important!
        # skip optimization in pl, since it's done in TorchRec train_pipeline
        self.automatic_optimization = False

    def _step(
        self,
        dataloader_iter: Any,
        batch_idx: int,
        phase_type: str,
    ) -> torch.Tensor:
        loss, logits, labels, ids, rguids = self.pipelines[phase_type].progress(dataloader_iter)
        return {"loss": loss}

    def training_step(
        self,
        dataloader_iter: Iterator[In],
        batch_idx: int,
        *args: Any,
        **kwargs: Any,
    ) -> None:
        loss_dict = self._step(dataloader_iter, batch_idx, "train")

        sch = self.lr_schedulers()
        sch.step()
        return loss_dict

    def validation_step(
        self,
        dataloader_iter: Iterator[In],
        batch_idx: int,
        *args: Any,
        **kwargs: Any,
    ) -> Dict[str, torch.Tensor]:
        return self._step(dataloader_iter, batch_idx, "val")

    def on_train_epoch_start(self) -> None:
        self.pipelines["train"]._model.train()

    def on_validation_epoch_start(self) -> None:
        self.pipelines["val"]._model.eval()

@colin2328 Have you met this? Any clue?

What do you mean by "Number of Batches are not same per rank"? Do you mean rank_0 run m batches while rank_1 run n batches? With pytorch DMP on multiple ranks, it needs collective communication across ranks for each iteration for both forward and backward. So if on some ranks it's not running the n-th batch while the rest of the ranking are running the n-th batch, the collective communication will hang.

Do you mean rank_0 run m batches while rank_1 run n batches?

Yes, that's what I mean.
Even for validation or predicting mode, we need to ensure same number of batches on all ranks? It's hard to guarantee that when we are not aware of accurate data size.


Pre-health checks may roll back to a very old release instead of the last one

Pre-health checks are meant to roll back to the latest Helm release to overwrite manual changes before doing a cluster apply.
However, it seems charts are rolled back to very old Helm releases. This might cause problems.
The logic in Lokomotive gets the Helm history limiting to 1 revision (the last one) using the Max field and then finds out what release it is by accessing the first element of the history array (and assuming there's only one entry, the last one).
However, it seems the Helm package ignores this Max field and returns the whole history so we try to roll back to a potentially old release.
As a reference, this is what the Helm CLI tool does to implement this correctly: https://github.com/helm/helm/blob/041ce5a2c17a58be0fcd5f5e16fb3e7e95fea622/cmd/helm/history.go#L115-L135

This is a duplicate of #1442. I'll close and write a comment there.


NavigationExperimental: Correct the distance from the left of the screen to start touch responsiveness

There are at least 2 requirements to be met at the same time:

currentDragPosition <= positionMax
Math.abs(currentDragDistance) > RESPOND_THRESHOLD

The default positionMax = 30 and RESPOND_THRESHOLD = 15. If so, the user must begin drag at the point which is less than 15 apart from the left edge. That is unexpected.
So currentDragPosition must minus RESPOND_THRESHOLD, and then the user can start dragging at the distance of 30 from the left edge

Sorry, but we aren't accepting fixes to NavigationExperimental any more, as it is deprecated. You may want to look into React Navigation, where the CardStack is being maintained now. To fix this in your app in the short term, you may want to copy the NavigationExperimental files into your app.


index.html not found

hello,
springboot logs
index.html not found

Hello.
The error comes from LogViewerServlet.processIndexHtml() (line 301). That code loads HTML code from /log-viewer-web/index.html resource using getClass().getResource("/log-viewer-web/index.html").
"/log-viewer-web/index.html" resource is located in "log-viewer-frontend-1.0.1.jar".
Could you make sure that "log-viewer-frontend-1.0.1.jar" is present in the classpath? If yes, check why it is not accessible from LogViewerServlet.
Also, you can attach a project sample to reproduce the problem.

thanks.
resolved


fix: Attempt to fix validation and derivation streams

This attempts to fix some watch channel voodoo where the state derivation and validation streams would occasionally enter an infinite loop when awaiting the last block as the RX side of the watch channel would continuously return.
As a temporary workaround until we better understand the error, this PR just loops, selects over block_rx.changed() and close.changed(), and returns a bool to indicate whether more blocks are already available in the DB rather than a self_notify channel.
The "missing block" errors still occur occasionally when the validation and state derivation streams reach the head of the chain, but this should be changed in a separate PR to not error, and instead indicate that there are no more blocks available so that we can just wait for the block_rx again.

Closing in favour of #105


consider using Go style package name and split code into packages

Hi, just going through the code it seems that a lot of it could be split into smaller packages therefore making testing and development easier.
As for naming package iota.lib.go, any reason for this?

I agree that package naming is not standard for Go. I imagine they did this to keep with the other things in their repo, but I would still like to see it changed.
What parts do you think could be split out? The package isn't really that complex to begin with.

The package itself is named giota.
See also https://github.com/iotaledger/giota/issues/29#issuecomment-355356996
I just change the repo to giota again. (Nobody tell Dom!)

I think giota is a decent name, but wouldn't iota as the package name be better? I would tend to name the repo directory iota-go or go-iota and then use package iota in the code. This makes the repo stand out in the organizations list but also denotes what the true package name is.

iota is a constant in go so I'm not sure if renaming the package to that would be a great idea.

Aw come on now, where's your sense of adventure?
On Wed, Feb 14, 2018, 9:28 AM Sascha Hanse<EMAIL_ADDRESS>wrote:

iota is a constant in go so I'm not sure if renaming the package to that
would be a great idea.
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/iotaledger/giota/issues/50#issuecomment-365662712,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AehY3R07mOfikuAaLbqwPo92PKU8hWtDks5tUwmZgaJpZM4SCK8O
.

Hah, I just changed it locally and nothing broke, so far.
I'm not really opposed to changing it to iota but if .go in the repository name breaks things, I wouldn't even want to imagine what having your package named iota could possibly break.

Throw this in your file and watch it break:
const (
thing int = iota
thing2
thing3
)```

On Wed, Feb 14, 2018 at 2:29 PM Sascha Hanse<EMAIL_ADDRESS>wrote:

> Hah, I just changed it locally and nothing broke, so far.
> I'm not really opposed to changing it to iota but if .go in the
> repository name breaks things, I wouldn't even want to imagine what having
> your package named iota could possibly break.
>
> —
> You are receiving this because you commented.
> Reply to this email directly, view it on GitHub
> <https://github.com/iotaledger/giota/issues/50#issuecomment-365751177>,
> or mute the thread
> <https://github.com/notifications/unsubscribe-auth/AehY3UhcrqHxx9XrYBGBdp5La3I-EYzRks5tU1BRgaJpZM4SCK8O>
> .
>

Throw this in your file and watch it break:
const (
    thing int = iota
    thing2
    thing3
)

I've split the package into multiple smaller ones and made the repo go modules agnostic.


Improve GUI readibility (font size, proper UI scaling for high resolutions)

Hello,
Thank You for making and maitaining Cryptonose.
ATM, I find it difficult to read the Cryptonose screen due to the bright white light and the small characters used.
I'd suggest a dark mode and bigger characters.
Thanks.

Hello,
Thank you very much for the feedback.
The problem with font size could be due to the lack of UI scaling for higher resolutions. What's your OS and screen resolution? The UI isn't scaled properly on my Linux Mint with XFCE and as far as I know it's generally a problem on Linux. I'll work on adding font size setting - this should help in most cases.
Dark mode is definitely good idea, I will add it as a separate issue and see what I can do.

Dark theme issue: https://github.com/dawidm/cryptonose2/issues/2

Hi @dawidm
Hi Dawid,
Thank You for responding to this so promptly.
The OS in question is Linux Manjaro XFCE with a 1920*1080 resolution.
Yes, font size setting and dark mode would be fantastic. Thank YOU very much.
Much appreciated.
:pray:

I've added option to change font size. It will be available in the next release.
About scaling for hidpi. Interface is scaling well for Windows and Linux. For Linux GDK_SCALE environment variable can be used to modify the scaling factor, but as far as I know, only integer values work.
There's problem with notifications - they could be small on very high dpi screens, but no fix for this so far.


update owners files after PR#5 merged

Signed-off-by: Yuval Lifshitz<EMAIL_ADDRESS>updating OWNERS file as requested here: https://github.com/knative-sandbox/eventing-ceph/pull/5#issuecomment-704188382

The following users are mentioned in OWNERS file(s) but are untrusted for the following reasons. One way to make the user trusted is to add them as members of the knative-sandbox org. You can then trigger verification by writing /verify-owners in a comment.

yuvalif

User is not a member of the org. User is not a collaborator. Satisfy at least one of these conditions to make the user trusted.

@matzew could you please have a look?

@yuvalif can you add yourself to the knative org first? Create a PR adding your github username to the members list in this file https://github.com/knative/community/blob/master/peribolos/knative.yaml

/verify-owners

/verify-owners

The following users are mentioned in OWNERS file(s) but are untrusted for the following reasons. One way to make the user trusted is to add them as members of the knative-sandbox org. You can then trigger verification by writing /verify-owners in a comment.

yuvalif

User is not a member of the org. User is not a collaborator. Satisfy at least one of these conditions to make the user trusted.

@matzew I was added to the knative members file, but the /verify-owners check is still failing

/verify-owners

@yuvalif oh...  this needs to be updated too: https://github.com/knative/community/blob/master/peribolos/knative-sandbox.yaml
:facepalm:

@yuvalif oh... this needs to be updated too: https://github.com/knative/community/blob/master/peribolos/knative-sandbox.yaml

done here: https://github.com/knative/community/pull/352

/verify-owners
/lgtm
/approve

/verify-owners

/verify-owners

The following users are mentioned in OWNERS file(s) but are untrusted for the following reasons. One way to make the user trusted is to add them as members of the knative-sandbox org. You can then trigger verification by writing /verify-owners in a comment.

yuvalif

User is not a member of the org. User is not a collaborator. Satisfy at least one of these conditions to make the user trusted.

@matzew still not passing :-(

/refresh
/verify-owners
/lgtm
/approve

@yuvalif needs to accept the invitation to the Knative-sandbox org. I think something like https://github.com/orgs/knative-sandbox/people/pending_invitations if you didn't get an email.

/verify-owners

@yuvalif needs to accept the invitation to the Knative-sandbox org. I think something like https://github.com/orgs/knative-sandbox/people/pending_invitations if you didn't get an email.

thanks!


Made website responsive for screen width larger than 1024px

PR Description 📜
Please include summary related to the issue you have fixed and describe your PR in brief over here by specifying the issue number on which you were working below
Fixes #318

Mark the task you have completed ✅

[x] I follow CONTRIBUTING GUIDELINE & CODE OF CONDUCT of this project.
[x] I have performed a self-review of my own code or work.
[x] I have commented my code, particularly in hard-to-understand areas.
[x] My changes generates no new warnings.
[x] I have followed proper naming convention showed in CONTRIBUTING GUIDELINE
[ ] I have added screenshot for website preview in assets/images
[ ] I have added entries for my game in main README.md
[ ] I have added README.md in my folder
[x] I have added working video of the game in README.md (optional)
[x] I have specified the respective issue number for which I have requested the new game.

Add your screenshots(Optional) 📸
https://github.com/kunjgit/GameZone/assets/93376863/30f52b6c-65f0-46b4-bb85-ac54312ada51

Thank you soo much for contributing to our repository 💗

Thank you @singh-anushka ,for creating the PR and contributing to our GameZone 💗
Review team will review the PR and will reach out to you soon! 😇
Make sure that you have marked all the tasks that you are done with ✅.
Thank you for your patience! 😀

Hey @singh-anushka 👋!
@kunjgit here,
We have this annoucement to make 📢!!
During the time of PR don't alter main index file ! 🙂
In main Readme file just use * as a game number during the time we are merging we will add number !! 👀
Make sure you join our Discord🕹 if you haven't 😇
Thank you 💗!

@singh-anushka Good to go

@singh-anushka Good to go

Please add gssoc23 and level 3 label while merging. Thank you : )

@Arun9739 @kunjgit @raju-kumar21 Can you please check the following PRs too, I have done the required changes.
Guess the colour by RGB.
Atari breakout
Chrome Dinosaur

Thank you  @singh-anushka , for your valuable time and contribution in our GameZone 💗.
It’s our GameZone, so Let’s build this GameZone altogether !!🤝
Hoping to see you soon with another PR again 😇
Wishing you all the best for your journey into Open Source🚀


Extra word - two instances of 'are'

PITR: Individual database backups are copied to RA-GRS storage are automatically.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: efd7dc24-fc18-0670-8287-70c952aaa60a
Version Independent ID: 75e5f6eb-0b52-291b-c99f-4e4c17269840
Content: Azure SQL Database - general purpose and business critical
Content Source: articles/sql-database/sql-database-service-tiers-general-purpose-business-critical.md
Service: sql-database
GitHub Login: @CarlRabeler
Microsoft Alias: carlrab

PR pending: https://github.com/MicrosoftDocs/azure-docs-pr/pull/66352
From: dmt87uk<EMAIL_ADDRESS>Sent: Wednesday, February 13, 2019 7:57 AM
To: MicrosoftDocs/azure-docs<EMAIL_ADDRESS>Cc: Carl Rabeler<EMAIL_ADDRESS>Mention<EMAIL_ADDRESS>Subject: [MicrosoftDocs/azure-docs] Extra word - two instances of 'are' (#24874)
PITR: Individual database backups are copied to RA-GRS storage are automatically.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: efd7dc24-fc18-0670-8287-70c952aaa60a
Version Independent ID: 75e5f6eb-0b52-291b-c99f-4e4c17269840
Content: Azure SQL Database - general purpose and business criticalhttps://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fdocs.microsoft.com%2Fen-us%2Fazure%2Fsql-database%2Fsql-database-service-tiers-general-purpose-business-critical&data=02|01|Carl.Rabeler%40microsoft.com|38e946cf81fc4dda2a7308d691cbf36b|72f988bf86f141af91ab2d7cd011db47|1|0|636856702615105568&sdata=vJgadnpi5vY4EZxuHASm6M0N8DzAyCJmKIm8sINMyMI%3D&reserved=0
Content Source: articles/sql-database/sql-database-service-tiers-general-purpose-business-critical.mdhttps://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2FMicrosoft%2Fazure-docs%2Fblob%2Fmaster%2Farticles%2Fsql-database%2Fsql-database-service-tiers-general-purpose-business-critical.md&data=02|01|Carl.Rabeler%40microsoft.com|38e946cf81fc4dda2a7308d691cbf36b|72f988bf86f141af91ab2d7cd011db47|1|0|636856702615105568&sdata=qLSOw9aScMwlz8FciCK2BDRFlqOPJaSIAoI2JY45my4%3D&reserved=0
Service: sql-database
GitHub Login: @CarlRabelerhttps://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2FCarlRabeler&data=02|01|Carl.Rabeler%40microsoft.com|38e946cf81fc4dda2a7308d691cbf36b|72f988bf86f141af91ab2d7cd011db47|1|0|636856702615115576&sdata=ET4HqMd7shUiIJmP1E2ggqoFSV5HSwCVp6kQF5Yo31o%3D&reserved=0
Microsoft Alias: carlrab

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHubhttps://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2FMicrosoftDocs%2Fazure-docs%2Fissues%2F24874&data=02|01|Carl.Rabeler%40microsoft.com|38e946cf81fc4dda2a7308d691cbf36b|72f988bf86f141af91ab2d7cd011db47|1|0|636856702615125580&sdata=uaxm3bDBO7mqv7c3ElTBhmIoBXoCOvzQo7xxh5E5H30%3D&reserved=0, or mute the threadhttps://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FAMCBn3W4pMJHrQ43xJPuoM2hCjwIzNJqks5vNDXmgaJpZM4a5tmv&data=02|01|Carl.Rabeler%40microsoft.com|38e946cf81fc4dda2a7308d691cbf36b|72f988bf86f141af91ab2d7cd011db47|1|0|636856702615125580&sdata=k9ycModw%2FIOU2Q%2FeAIagZPPnFKRZTiVsNY%2BXvG2bJRs%3D&reserved=0.

Hi @dmt87uk, thanks for bringing this to our attention. The doc author has created a pr to update doc.

PR Merged - fix live this afternoon

We will now proceed to close this thread.


Find current installed version?

Is there a command I can run to tell what the current installed version and/or committed version of DisplayCameras is currently installed on my RPI?
thanks,
Albert

This capability does not exist, but I'll add it soon.

FWIW, version numbers aren't incremented until I do a release.  Version number is listed in the main script.  You can find it with
grep version /usr/bin/displaycameras


⚠ ClamAV has degraded performance

In 6f6c403, ClamAV (https://spamassassin.apache.org/) experienced degraded performance:

HTTP code: 200
Response time: 85 ms

Resolved: ClamAV performance has improved in 41c8e46.


fix #1128, Use redirect to handle yarn web proxy

Look like there is compilation error
[error] /home/travis/build/intel-hadoop/gearpump/services/src/main/scala/org/apache/gearpump/services/RestServices.scala:27: trait RestServices inherits conflicting members:
[error]   method extractHost in trait StaticService of type => spray.http.HttpHeader => Option[spray.http.HttpHeaders.Host]  and
[error]   method extractHost in trait InterMediateService of type => spray.http.HttpHeader => Option[spray.http.HttpHeaders.Host]
[error] (Note: this can be resolved by declaring an override in trait RestServices.)
[error] trait RestServices extends AppMastersService
[error]       ^
[error] one error found

fixed

+1


Seti Icons are Default for all File Types

SQL Operations Studio Version:
Version 0.32.3-insider
Commit 220e4feb1d65de98fd7f872a699b47b6f18d7bc7
Date 2018-08-06T12:19:36.303Z
VS Code 1.23.1
Shell 1.7.12
Renderer 58.0.3029.110
Node 7.9.0
Architecture x64

Steps to Reproduce:
• Fresh install of the version shown above.
• Click on the Explorer button on the left hand side and open a folder.
• Almost all files in the folder are missing Seti Icons.
This feature is working correctly for me in the July release, but for the latest insider release, it is not. For your reference, I've included a screenshot of a few file types that aren't having their Seti Icon displayed correctly alongside some that are displayed correctly.
Please let me know if I can provide additional information.

see the following issues that might clarify this issue.. #387 and #2153. Appears this is by design.

I agree with this design choice; however, I believe that I'm still encountering a bug since my new query icon is the default Seti Icon and not the new icon in the screenshot below.

The main reason that I would like something other than the default Seti Icon is that when I have a folder open on the side that has example.* and example.sql files in it, I would like to be able to, at a glance, identify my .sql files.
I feel like the solution to this would be to, instead of setting everything to default, add more options to the settings for those who like the Seti Icons as is. In the below screenshot, you can see that there are only two options for icons in the settings.

The icon change for SQL files is "By Design" since we've gotten negative feedback on the red DB icon previously.  We're certainly open to additional feedback for the default SQL icon, but please keep in mind this is an area where there are many different valid opinions, so we basically have to more forward with some reasonable decision.
The change shouldn't have updated the icon for other file types so I'll take a look to see if there are unintended side-effect to the change.
@breadboi the below icon is for the dashboard.  We actually have a nice icon our UX designer produced for this document type, but it wasn't displaying correctly in the dark theme, so we'll need to follow-up on that.

Here's the proposed dashboard icon.

@yualan, @breadboi does have concrete feedback which is we shouldn't use the default Seti icon for SQL files, and I'm inclined to agree.  Let's try to find another "neutral" icon for SQL files.

I've sent a PR that reverts the .SQL file icon back to the DB icon, but switches the color to the default light grey.  Please let me know if there's any feedback on that proposed change.


Vod chat not working

The chat in VODS are sometimes freezing when skipping parts of video or when I'm watching. Not sure if this is only me but you just letting you know.

Duplicate of #327


Admin Router: Nested /service paths support

High Level Description
This PR enables nested service paths handling in for /service endpoint, i.e. /service/group1/group2/jenkins.
Related Issues
https://jira.mesosphere.com/browse/DCOS-14891 - Admin Router paths for nested services
Related PRs:
EE DC/OS PR:  https://github.com/mesosphere/dcos-enterprise/pull/929

Merging!


Remove default ssh port

It's the default anyways, and prevents users from overriding it (specifically windows users)
Fixes #50

@virtuald Looks like you are going to have to update the tests as well. I believe it may just be this line here

Sorry about that, I had expected Travis to send me an email if it failed, but it didn't... will fix shortly.

Updated, the tests should pass now.

@virtuald 👍

@Theaxiom this seems to have been reverted recently, where did it go?

Check the next branch.


[test] Port GPUDIRECTACC check to Tiger

Will fix UES-567

Codecov Report

Merging #971 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #971   +/-   ##
=======================================
  Coverage   91.86%   91.86%
=======================================
  Files          80       80
  Lines       10481    10481
=======================================
  Hits         9628     9628
  Misses        853      853

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 169ab2d...d680299. Read the comment docs.

unittests/test_schedulers.py:402: AssertionError

@jenkins-cscs retry dom


Broker truncation

This change implements basic topic truncation on Brokers. It does this by periodically checking each topic for its size, and if greater than a certain threshold, deleting segments until the required size is reached.
The change also exposes maximum topic and segment sizes via configuration, as I believe some people may want to change these numbers.
I decided to implement this via a go-routine, so that the function to check the topic sizes could simply walk the filesystem, and not have to worry too much about efficiency vis a vis caching sizes in RAM. I think a design whereby truncation is performed every few minutes is fine (it's how Apache Kafka works), and this approach seems simpler and more robust.
Remaining:

unit testing.
tombstones, so system knows where topic data existed previously.
letting data nodes known when they must redirect to other nodes for topic data.
checking if topic segments are safe to delete i.e. if a data node has picked up the data.

Thanks @jwilder -- comment was a copy 'n' paste error.

Thanks for feedback @jwilder -- updated.

LGTM.  I'm a little concerned about how frequently ReadSegments is called since it's doing a Readdir(0) each time.  It's called to get the topic Size() and then to get the segment size in a loop multiple times for each topic.  If there are a lot of Topics to truncate, this might cause some sporadic performance issues.  Don't think you need to change it now but we might want to see how it performs w/ a large numbers of topics.

@jwilder -- I don't think it would make a huge impact, but it's not great, I agree. Take a look at the modified implementation. I think it's safe, since the topic is locked.

Yeah, that looks better.

OK, updated so there is only a single read of the topic directory. Since the topic is locked, segments can't change since writing to the topic also takes the lock.

Overall lgtm, mostly minor nits.

Thanks @benbjohnson -- maybe I'll just scrap the named returns. Might be clearer.

Named returns scrapped, simpler is better. Green build.


NET_ERR_IF_LINK_DOWN in NetSock_TxDataTo() when using UDP syslog example

Hi,
I'm using the Datagram Client (UDP Client) from this page
Although I get NET_ERR_IF_LINK_DOWN when calling NetSock_TxDataTo.
All previous calls return with no error.
net_sock.c is version V3.04.06
Does anybody know how to solve this?
Best regards

Hello everyone,
I tried my first micrium OS3 porting and everything is OK. now I am trying to integrate TCP/IP and I am not sure I did it right.Do you have stm32f407vg  discovery board example that it works. I need an example to better understanding. My working is below.If somthing is missing,, could you please tell me? Thank you.
https://github.com/ZekDe/Micrium_OS3_Porting_Test


Replace multi_json with json

JSON is good option for default.
It was made in Rails in 2013.

Dup of https://github.com/ruby-grape/grape/pull/1292
P.S. Despite the fact that I don't think that it should be configurable at all.

@etehtsea On being configurable it's more about backward compatibility than anything else.

https://github.com/ruby-grape/grape/pull/1623


Slanger crashes when the App tries to connect

I'm using presence channels, although that doesn't seem to be the issue.
Slanger API server listening on port 4567
Slanger WebSocket server listening on port 8080
/Users/ianmurrays/.rvm/gems/ruby-1.9.2-p180/gems/eventmachine-0.12.10/lib/em/connection.rb:39:in `block in new': undefined method `associate_callback_target' for #<EventMachine::WebSocket::Connection:0x00000101d461b8> (NoMethodError)
	from /Users/ianmurrays/.rvm/gems/ruby-1.9.2-p180/gems/eventmachine-0.12.10/lib/em/connection.rb:36:in `instance_eval'
	from /Users/ianmurrays/.rvm/gems/ruby-1.9.2-p180/gems/eventmachine-0.12.10/lib/em/connection.rb:36:in `new'
	from /Users/ianmurrays/.rvm/gems/ruby-1.9.2-p180/gems/eventmachine-0.12.10/lib/eventmachine.rb:1430:in `event_callback'
	from /Users/ianmurrays/.rvm/gems/ruby-1.9.2-p180/gems/eventmachine-0.12.10/lib/pr_eventmachine.rb:815:in `block in eventable_read'
	from /Users/ianmurrays/.rvm/gems/ruby-1.9.2-p180/gems/eventmachine-0.12.10/lib/pr_eventmachine.rb:812:in `times'
	from /Users/ianmurrays/.rvm/gems/ruby-1.9.2-p180/gems/eventmachine-0.12.10/lib/pr_eventmachine.rb:812:in `eventable_read'
	from /Users/ianmurrays/.rvm/gems/ruby-1.9.2-p180/gems/eventmachine-0.12.10/lib/pr_eventmachine.rb:369:in `block in crank_selectables'
	from /Users/ianmurrays/.rvm/gems/ruby-1.9.2-p180/gems/eventmachine-0.12.10/lib/pr_eventmachine.rb:369:in `each'
	from /Users/ianmurrays/.rvm/gems/ruby-1.9.2-p180/gems/eventmachine-0.12.10/lib/pr_eventmachine.rb:369:in `crank_selectables'
	from /Users/ianmurrays/.rvm/gems/ruby-1.9.2-p180/gems/eventmachine-0.12.10/lib/pr_eventmachine.rb:324:in `block in run'
	from /Users/ianmurrays/.rvm/gems/ruby-1.9.2-p180/gems/eventmachine-0.12.10/lib/pr_eventmachine.rb:318:in `loop'
	from /Users/ianmurrays/.rvm/gems/ruby-1.9.2-p180/gems/eventmachine-0.12.10/lib/pr_eventmachine.rb:318:in `run'
	from /Users/ianmurrays/.rvm/gems/ruby-1.9.2-p180/gems/eventmachine-0.12.10/lib/pr_eventmachine.rb:64:in `run_machine'
	from /Users/ianmurrays/.rvm/gems/ruby-1.9.2-p180/gems/eventmachine-0.12.10/lib/eventmachine.rb:256:in `run'
	from /Users/ianmurrays/.rvm/gems/ruby-1.9.2-p180/gems/slanger-0.1.1/bin/slanger:46:in `<top (required)>'
	from /Users/ianmurrays/.rvm/gems/ruby-1.9.2-p180/bin/slanger:19:in `load'
	from /Users/ianmurrays/.rvm/gems/ruby-1.9.2-p180/bin/slanger:19:in `<main>'

It's actually happening when the JS api tries to connect to the websocket.

i'm using 1.9.2-p290 and don't get this issue. i'll download p180 when i have better internet and try to reproduce, thanks for reporting.

Thanks. I should update though :P
--
Ian Murray S.
Twitter: @Synt4x
GitHub: ianmurrays
Skype: ianmurrays
On 16-12-2011, at 12:55, Stevie Graham wrote:

i'm using 1.9.2-p290 and don't get this issue. i'll download p180 when i have better internet and try to reproduce, thanks for reporting.

Reply to this email directly or view it on GitHub:
https://github.com/stevegraham/slanger/issues/6#issuecomment-3178774

i can't reproduce this… because p180 completely SEGFAULTS on me. sorry man, i'm gonna say p290 is minimum required version.

That's alright. I'll update ruby. It's time anyway.
--
Ian Murray S.
Twitter: @Synt4x
GitHub: ianmurrays
Skype: ianmurrays
On 20-12-2011, at 15:42, Stevie Graham wrote:

i can't reproduce this because p180 completely SEGFAULTS on me. sorry man, i'm gonna say p290 is minimum required version.

Reply to this email directly or view it on GitHub:
https://github.com/stevegraham/slanger/issues/6#issuecomment-3223145


Is there a way to mix existing resources with conditional deployments

I'm looking to do something like this:
param resourceExists bool

// Conditionally deploy resource or obtain reference to existing one
resource myresource 'provider@version' = resourceExists ? existing : {
  name: 'myresourcename'
  properties: {}
}

resource child 'provider/childprovider@version' = {
  name: 'child'
  parent: myresource
  properties: {}
}

resource other 'otherprovider@version' = {
  name: '${myresource.name}-other'
  tags: myresource.tags
  properties: {}
}

As it stands, my more verbose solution looks like this:
param resourceExists bool

resource existingResource 'provider@version' existing = if (resourceExists) {
  name: 'myresourcename'
}

resource newResource 'provider@version' = if (!(resourceExists)) {
  name: 'myresourcename'
  properties: {}
}

resource child 'provider/childprovider@version' = {
  name: 'child'
  parent: resourceExists ? existingResource : newResource
  properties: {}
}

resource other 'otherprovider@version' = {
  name: '${resourceExists ? existingResource.name : newResource.name}-other'
  tags: resourceExists ? existingResource.tags : newResource.tags
  properties: {}
}

Is there a cleaner approach?
Thanks!

We don't have a cleaner way to do this today unfortunately. This was originally raised in #1171. I think we will get to it eventually, but likely not in 0.5 or 1.0.
Going to close this and track with the original issue.

We don't have a cleaner way to do this today unfortunately. This was originally raised in #1171. I think we will get to it eventually, but likely not in 0.5 or 1.0.
Going to close this and track with the original issue.

Thanks for the response!


user config is duplicating projects with expanded paths

it you have defined a project in your harpoon config like "~/path/project" . The user config contains a duplicated entries of the following "~/path/project" and "/path/project"

ohh sno!  I'll have to take a look at this on sunday

I didn't take a look at this on sunday, but its obviously something that needs to get fixed.  Will when I have a personal moment.

I believe this has been taken care of with an earlier PR.  @polarmutex let me know if I should re-open this

I am still seeing it on my system, pretty sure I am running the latest. I will investigate and see if I can find the issue

basically the harpoon.json will contain the expanded and non expanded paths for any projects in he config sent to the setup function. this change will invalidate the old non expanded path in the config


User join in group via Shareable Chat Folders

If group member join to group - i am get event "update"
if user join with shareable Chat Folders, group dont get anounce, bot does not receive any events(update) (breakpoint does not work on HandleUpdate)
Some bot developers solve this problem by receiving the connection event via https://core.telegram.org/bots/api#chatmemberupdated
Why "chatmemberupdated" is this necessary? because of this error telegram spammers using folders with chats enter chats and remain invisible, due to the lack of events
If it's possible, need support "ChatMemberUpdated" event

ChatMemberUpdated (update.ChatMember) is already supported.
https://telegrambots.github.io/book/FAQ.html#18-how-to-receive-chatmember-updates

(this library is independent from Telegram teams)

see also https://telegrambots.github.io/book/2/chats.html#detecting-new-group-members-and-changed-member-status

ChatMemberUpdated (update.ChatMember) is already supported.
https://telegrambots.github.io/book/FAQ.html#18-how-to-receive-chatmember-updates

Thank you
I am a newbie and tried to read your documentation first but was not attentive enough
Sorry for wasting your time, thanks for the links


How to use SwiftNIO to parse multiple files uploaded from html?

Hello! This is my HTML sample code:
<form action="/upload" method="POST" enctype="multipart/form-data">
     <input type="file" id="filename" name="file" onchange="onchanged()" multiple="multiple" />
     <input type="submit" value="Upload">
</form>

I want to use SwiftNIO as the server, add a post method /upload API to receive files uploaded from html, but the current received is a ByteBuffer or Data data, the size of the data data is multiple files I uploaded The sum of the sizes; I want to read Data and store it according to the name, but I did not find how to parse this Data in sections to distinguish the data Range of different files.
Is there such a sample code for reference?

English is not my native language; please excuse typing errors.

Thanks for your question! SwiftNIO does not provide functionality like this itself. SwiftNIO does support HTTP but it only supports the HTTP wire protocol and seems like you're looking for a fully fledged web framework (with support for APIs, routing, uploads, ...). We would recommend you pick one of the Swift web frameworks that are implemented using SwiftNIO. For example Vapor or Amazon Smoke but there are other options too.

Thanks for your question! SwiftNIO does not provide functionality like this itself. SwiftNIO does support HTTP but it only supports the HTTP wire protocol and seems like you're looking for a fully fledged web framework (with support for APIs, routing, uploads, ...). We would recommend you pick one of the Swift web frameworks that are implemented using SwiftNIO. For example Vapor or Amazon Smoke but there are other options too.

@weissi
Thank you very much. You are right, but Vapor framework is too heavy for my needs, I will refer to its code.

@weissi
Thank you very much. You are right, but Vapor framework is too heavy for my needs, I will refer to its code.

@Jinxiansen I see. You could also try more lightweight frameworks like https://github.com/Macro-swift/MacroExpress ?

@Jinxiansen I see. You could also try more lightweight frameworks like https://github.com/Macro-swift/MacroExpress ?

CC @helje5 the author of MacroExpress

CC @helje5 the author of MacroExpress

Hi. MacroExpress has bodyParser implementations for text, url-form-encoded and json, but I don't do multipart/form-data yet. That's primarily because I didn't need it yet, I might just add at least a basic implementation in the next few days :-)

Hi. MacroExpress has bodyParser implementations for text, url-form-encoded and json, but I don't do multipart/form-data yet. That's primarily because I didn't need it yet, I might just add at least a basic implementation in the next few days :-)

@helje5 @weissi
Great! Very happy to meet you here!👏  I have seen MacroExpress a few days ago, but it cannot meet my needs.
<form action="/upload" method="POST" enctype="multipart/form-data">
     <input type="file" id="filename" name="file" onchange="onchanged()" multiple="multiple" />
     <input type="submit" value="Upload">
</form>

Because I want to use the above code to select multiple files of any type in html, and then call the /upload interface to save multiple files to the specified directory.
I saw a method like app.on(.POST, "upload", body: .stream) { req in ... } in Vapor, although it can transfer large file data streams after multiple selections, such as a.png(1.0MB) and b.avi(5.0 MB), the data size after I received it was 6.0MB; but I couldn't distinguish the received file fragment and file name/type; this made me a little bit distressed; I look forward to your ways to do it. 🍦🍦

@helje5 @weissi
Great! Very happy to meet you here!👏  I have seen MacroExpress a few days ago, but it cannot meet my needs.
<form action="/upload" method="POST" enctype="multipart/form-data">
     <input type="file" id="filename" name="file" onchange="onchanged()" multiple="multiple" />
     <input type="submit" value="Upload">
</form>

Because I want to use the above code to select multiple files of any type in html, and then call the /upload interface to save multiple files to the specified directory.
I saw a method like app.on(.POST, "upload", body: .stream) { req in ... } in Vapor, although it can transfer large file data streams after multiple selections, such as a.png(1.0MB) and b.avi(5.0 MB), the data size after I received it was 6.0MB; but I couldn't distinguish the received file fragment and file name/type; this made me a little bit distressed; I look forward to your ways to do it. 🍦🍦


[fix] Revert "simplify id codec code (#380)"

This reverts commit ccce88c5c5bc766bb2b73db6a0a90a326290e53a.

Seeing a bunch of:

Error: wrong number of fields in record

I think reverting this commit should fix things temporarily.
Test Plan

[ ] acceptance tests

[ ] …

References

hmm I thought I fixed all of those

hmm I thought I fixed all of those


Configuration of DHCP role fails when using non-English Windows Server iso

The script looks for an interface with an alias Ethernet while configuring the DHCP role, but will fail if you use an non-English Windows Server iso. In my case I was using 14393.0.161119-1705.RS1_REFRESH_SERVER_EVAL_X64FRE_JA-JP.ISO for the iso and the interface alias was イーサネット.
https://github.com/microsoft/WSLab/blob/95408e80df8587b445af9b0e21078d8b5779b53c/Scripts/2_CreateParentDisks.ps1#L735
As an workaround, I had to logon and rename the interface to Ethernet to proceed.

That's a cool alias! I'm afraid the change would be bit more complex. In theory I could query it with posh what's the name. I guess easier for you will be to use en ISO. What do you think?

I have suggestions for this. Why don't add a "LocalizeYourLab.ps1" file to the project.
"LocalizeYourLab.ps1" should be something like this for the english version :
############################
$LocalizedLab = @{ DefaultAdminAccount = "Administrator";
DomainAdminsGroup = "Domain Admins";
DomainSchemaAdminGroup = "Schema Admins";
DomainEnterpriseAdminGroup = "Enterprise Admins";
DNSAdminGroup = "DnsAdmins";
AdminsGroup = "Administrators";
AuthenticatedUsersGroup = "Authenticated Users";
EveryoneGroup = "Everyone";
VMGuestServiceInterfaceName = "Guest Service Interface";
S2DClusterTest = "Storage Spaces Direct";
StorageClusterTest = "Storage";
InventoryClusterTest = "Inventory";
NetworkClusterTest = "Network";
SystemClusterTest = "System Configuration";
HyperVClusterTest = "Hyper-V Configuration"
}
############################
Example of "LocalizeYourLab.ps1" for a french version :
############################
$LocalizedLab = @{ DefaultAdminAccount = "Administrateur";
DomainAdminsGroup = "Admins du domaine";
DomainSchemaAdminGroup = "Administrateurs du schéma";
DomainEnterpriseAdminGroup = "Administrateurs de l’entreprise";
DNSAdminGroup = "DnsAdmins";
AdminsGroup = "Administrateurs";
AuthenticatedUsersGroup = "Utilisateurs authentifiés";
EveryoneGroup = "Tout le monde";
VMGuestServiceInterfaceName = "Interface de services d’invité";
S2DClusterTest = "Storage Spaces Direct";
StorageClusterTest = "Stockage";
InventoryClusterTest = "Inventaire";
NetworkClusterTest = "Réseau";
SystemClusterTest = "Configuration du système";
HyperVClusterTest = "Configuration Hyper-V"
}
############################
You only need to change few lines for "2_CreateParentDisk.ps1" and "3_Deploy.ps1" :
############################
For "2_CreateParentDisk.ps1"
Add on Line 560 (this is an empty line, don't line break after to keep line numbering)
. "$PSScriptRoot\LocalizeYourLab.ps1"
Line 561
$username = "$($LabConfig.DomainNetbiosName)\Administrator"
replaced by
$username = "$($LabConfig.DomainNetbiosName)$($LocalizedLab.DefaultAdminAccount)"
Line 716
GroupName = "Domain Admins"
replaced by
GroupName = $LocalizedLab.DomainAdminsGroup
Line 723
GroupName = "Schema Admins"
replaced by
GroupName = $LocalizedLab.DomainSchemaAdminGroup
Line 731
GroupName = "Enterprise Admins"
replaced by
GroupName = $LocalizedLab.DomainEnterpriseAdminGroup
Line 740
UserName = "Administrator"
replaced by
UserName = $LocalizedLab.DefaultAdminAccount
############################
############################
For "3_Deploy.ps1"
Line 221
Administrator
replaced by
$($LocalizedLab.DefaultAdminAccount)
Line 271
Administrators
replaced by
$($LocalizedLab.AdminsGroup)
Add on Line 665 (this is an empty line, don't line break after to keep line numbering)
. "$PSScriptRoot\LocalizeYourLab.ps1"
Line 1068
$username = "$($Labconfig.DomainNetbiosName)\Administrator"
replaced by
$username = "$($LabConfig.DomainNetbiosName)$($LocalizedLab.DefaultAdminAccount)"
Line 1365
Get-VM -VMName "$($labconfig.Prefix)" | Where-Object {$.state -eq "Running" -or $.state -eq "Off"} | Enable-VMIntegrationService -Name "Guest Service Interface"
replaced by
Get-VM -VMName "$($labconfig.Prefix)" | Where-Object {$.state -eq "Running" -or $.state -eq "Off"} | Enable-VMIntegrationService -Name $LocalizedLab.VMGuestServiceInterfaceName
############################
Please note that this is only for the core files. "Scenario.ps1" files should be updated accordingly
I'm new to github, I hope this is the right place to these suggestions

What I really don't want to do is adding another ps1 files. Many things can now be customized already - like keyboard can be switched/language installed as a script injected to answer file. Is there a specific case you would like to use this with?

Ok, I undestand that, it was just a suggestion after all.
The deal was only to use other ISOs than the english one (for somes - manies? - who don't speak english at all or just a few words), and the keyboard layout is not enough for them.

May be Well-known SIDs can be a way (and it's far better than my first suggestion) :
$LocalAdminGroupSID = New-Object System.Security.Principal.SecurityIdentifier ("S-1-5-32-544") $LocalAdminGroupAccount = ($LocalAdminGroupSID.Translate( [System.Security.Principal.NTAccount])).Value -replace "^.+\\(.+)$",'$1'
and for domain related :
`$rootDomain = ([adsi]"LDAP://RootDSE").rootDomainNamingContext[0]
$domain = ([adsi]"LDAP://RootDSE").defaultNamingContext[0]
$rootDomainId = New-Object System.Security.Principal.SecurityIdentifier(([adsi]"LDAP://$rootDomain").objectSID[0], 0)
$domainId = New-Object System.Security.Principal.SecurityIdentifier(([adsi]"LDAP://$domain").objectSID[0], 0)
Example for Enterprise Admins
$EnterpriseAdminGroupSID = New-Object System.Security.Principal.SecurityIdentifier ("$rootDomainId-519")
$EnterpriseAdminGroupAccount = ($EnterpriseAdminGroupSID.Translate( [System.Security.Principal.NTAccount])).Value -replace "^.+\(.+)$",'$1'
Example for Domain Admins
$DomainAdminGroupSID = New-Object System.Security.Principal.SecurityIdentifier ("$domainId-512")
$DomainAdminGroupAccount = ($DomainAdminGroupSID.Translate( [System.Security.Principal.NTAccount])).Value -replace "^.+\(.+)$",'$1'
For the cluster test, it's obviously different, I'm stucked here :)Test-Cluster -List | Select Category | Sort Category -Unique`

So there is no way to use non-english isos? I am trying to use Spanish ISOs but I get an endless loop when installing (unattend.xml file is missing)

there are some different strings in different languages (Administrator, Ethernet,...) so multiple things are failing.  Either DSC, or later as you mention unattend.xml application. You can build DC with EN media and then later you should be able to create additional VHDs in parentdisks folder (using createparentdisk.ps1 script) which can be Spanish/Japanese/...

My intention is to build test labs for 2012R2. Is that doable with WSLab? If not, which parts could I take for reuse to create my own set of scripts? I just want to test VMs running DC, Exchange, Sharepoint and a CA
I already have a DC running 2012R2. I already tried myself manually to build a lab on my Windows 10 laptop creating 2-nodes hyper-v 2016 core guest cluster. The issue with hyper-v core is that you can´t use S2D.

of course! Just build lab with 2019 (DC) and create 2012R2 media with createparentdisk.ps1... You just need different unattend type https://github.com/microsoft/WSLab/blob/master/Scripts/LabConfig.ps1#L335

Or create my own vhd disk isn´t it? Why 2019 DC? Can´t I have a 2012R2 DC? I don´t mind to have 2016 guest hyper-v guest hosts as long as all my VMs are 2012R2.

Yeah, gen2 VHD for sure :). But createparentdisk.ps1 from ParentDisks folder is easiest... 2012 OS cannot process DSC that is generated with WSLab ... so it will fail building.. 2016 is the lowest version of DC you can have... VMs can be anything 2008R2 and newer...

@jaromirk from my point of view the localization (not language packs but native non en-us ISOs) always cause a lot of headaches. Many of these due to the localization of predefined groups and stuff.
I understand the idea of the discussion but be aware that Microsoft teams itself does not invest much love into non en-US installations anymore.
One example is Windows Admin Center that has serious issues exactly due to the same fact that it pretends every OS is en-us otherwise cause troubles with WSMAN / WinRM / wmic / PowerShell interally too, as they expect en-us group names etc.
There have been Windows patches lately that caused havoc post patch on non en-us installations for same reasons. Windows and other products.
Another sign is that long standing issue with RDP in WAC with non en-us keyboard layout that is officially fixed but otherwise still not working for many things.
there is a number of admins that cannot understand english and that's ok. The idea in https://github.com/microsoft/MSLab/issues/290#issuecomment-603821656 is valid and could be added to the code in a customizable section as Jaromir does not want to create more external functions or scripts, understandably for maintenance reasons and dependencies.
On the same page we have the cons of using non en-us ISOs that are raising. We have passed the patching and language issues with Vista / 2008 but some things are clearly going down the route that en-us is the norm and LIP or language pack need to be applied which do not alter internal things.
tl:dr, it is not easy and becomes harder to weight and implement the usage of non en-us ISOs, from many sides, including Microsoft but also other vendors. Also helpful community scripts and solutions come with clear warnings being untested on non en-us installations.
hope it helps to rethink and decide, pro language packs or LIPs (language interface packages).

@jaromirk do you plan to implement language packs during createparentdisk phase (in addition to LCU)?
This is something that could be feasible for @jetkiwi @dcfou
We could use Labconfig that is then checking the language required during 2_createparentdisks.ps1 and later 3_Deploy,ps1
Offtopic:

2-nodes hyper-v 2016 core guest cluster. The issue with hyper-v core is that you can´t use S2D.

@mgonzcast that is true, please use the S2D scenario, Most feasible with WS 2022.
Since it is a lab, using Hyper-V core doesn't make sense. The Hyper-V Server SKU - not Hyper-V itself - is dead.


DO droplet without functioning networking sometimes in some cases

RancherOS Version: (ros os version)
v1.5.0
Where are you running RancherOS? (docker-machine, AWS, GCE, baremetal, etc.)
DigitalOcean
From an user:

We have received and confirmed a bug report related to the new 1.5.0 image.  Currently if a user creates a snapshot of a 1.5.0 droplet and creates a new droplet from that image they end up without functioning networking.  I am digging into this issue to track down the cause but I wanted to reach out to see if there were any specific changes to network configuration or cloud-init in the 1.5.0 image since we do not see this issue with 1.4.2.

It should be a bug caused by https://github.com/rancher/os/pull/2524, we want to get the user's network settings before cloud-init is executed. But DO is really special, it is not using DHCP, but the static network settings obtained through metadata.
ROS will use the network configuration left last time if booting from a snapshot, so we have two network configurations on eth0, and we have not been able to remove the old configuration very well.
Two workarounds:

Remove /var/lib/rancher/conf/cloud-config.d/network.yml and /var/lib/rancher/conf/metadata before creating snapshot.
Reboot the droplet when you cannot get the functioning networking. This is equivalent to resetting the network.

To fix this issue, the best way is to use the network configuration from metadata every time on DO, don't use any cache info.

Testing with RancherOS v1.5.1-rc1
Confirmed fix.
Test steps:

Upload rancheros v1.5.1-rc1 to DigitalOcean
Create a droplet and a snapshot
Use this snapshot to create a new droplet
Log in to the droplet and ping google.com

Test Results:
[rancher@hailong-ros-151-rc1-1-snapshot-1-s-4vcpu-8gb-nyc3-01 ~]$ ping google.com
PING google.com (<IP_ADDRESS>): 56 data bytes
64 bytes from <IP_ADDRESS>: seq=0 ttl=57 time=2.716 ms
64 bytes from <IP_ADDRESS>: seq=1 ttl=57 time=2.238 ms
64 bytes from <IP_ADDRESS>: seq=2 ttl=57 time=2.213 ms


Split of train/test sets

Hi, thanks for your code!
I am wondering how to split the training and testing sets on both Office-31 and VisDA-2017 datasets in your work?
I could not find the related code.
Could you give me any suggestions?
Thanks a lot!

It seems that you use the same data samples on the target domain for both unsupervised training and testing. I am confused about it. Look forward to your reply. Thanks!

@yxgeee I think it is the correct setting for VisDA2017


Mutagen sync command indefinite wait fix

Check the output of 'mutagen sync list' for errors, and exit sync command if found, instead of indefinitely waiting.

Forgot to leave testing steps originally. Can be tested by creating a symlink in the sync'd directory with a target outside the sync'd directory and calling warden sync start. It should exit and output the last mutagen error encountered, instead of waiting indefinitely.

@Lunaetic Thank you very much for this valuable contribution. Ran a couple tests and it LG2M
$ ln -fsn /tmp/fail webroot/test-fail
$ warden sync start
Created session sync_zVzJdP7maYOlYUiPJn7xJH2lpeT6jeoJXN2V3cBLzgg
Waiting for initial synchronization to complete
......
Mutagen encountered an error during sync: alpha scan error: invalid symbolic link (test-fail): target is absolute
$ rm webroot/test-fail
$ warden sync start
Created session sync_WTh17qqQeP7XVh83MoPaoo1kvZsO05N6iy4OiVjmwp9
Waiting for initial synchronization to complete
...................
$

Successfully completes under "normal" conditions — pass
Exits with error message from Mutagen on failure — pass


[core] Create a new pull request template

A more detailed pull request template that allows developers to easily create pull requests without missing any important information.

[x] I have followed (at least) the PR section of the contributing guide.

It appears that this person created a whole bunch of PRs like this across many different open-source projects in October, presumably for Hacktoberfest. I'd consider this spam and close it, but it looks like it's already gone. @Yoda-Flash please feel free to contact me (sam at mui dot com) if you're interested in contributing to the MUI docs / repo and I'll do what I can to help you find something to work on.

Hello, it'd be great if you could allocate me something to work on, thank you! I submitted a bunch of PR's to repositories I thought were cool about Pull Request Templates because those were the only contributions I thought I could do, but I realize that sort of defeats the point of open source, so I deleted the repositories. If there's something you could allocate me to work on, I'd definitely do my best to learn how to help. Once again, thanks very much!


How to match events timestamps and disparity maps timestamps

Hello,
I notice that the timestamps of events are relative time, but the timestamps of disparity maps are ROS time, so what is the relationship between them.

I found it, thank you

Updated documentation and code which resolves this issue


prio feature fertig nach 3 wochen

Replaces #255

Pull Request Test Coverage Report for Build<PHONE_NUMBER>
Details

53 of 329 (16.11%)  changed or added relevant lines in 66 files are covered.
1099 unchanged lines in 173 files lost coverage.
Overall coverage decreased (-39.2%) to 38.988%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

packages/Liquid-UI.package/LQAnswerPanel.class/instance/buildMultiSelectionListWith..st
0
1
0.0%

packages/Liquid-UI.package/LQAnswerPanel.class/instance/buildQuestionTitleTextWith..st
0
1
0.0%

packages/Liquid-UI.package/LQAnswerPanel.class/instance/buildQuestionTooltipWith..st
0
1
0.0%

packages/Liquid-UI.package/LQAnswerPanel.class/instance/getChildren.st
0
1
0.0%

packages/Liquid-UI.package/LQAnswerPanel.class/instance/isValidSelection.ForChoiceAt..st
0
1
0.0%

packages/Liquid-UI.package/LQAnswerPanel.class/instance/isValidSizedSelection..st
0
1
0.0%

packages/Liquid-UI.package/LQAnswerPanel.class/instance/question..st
0
1
0.0%

packages/Liquid-UI.package/LQAnswerPanel.class/instance/resetUI.st
0
1
0.0%

packages/Liquid-UI.package/LQAnswerPanel.class/instance/selectedChoices..st
0
1
0.0%

packages/Liquid-UI.package/LQParticipantMenu.class/instance/buildAnswerPanelWith..st
0
1
0.0%

Files with Coverage Reduction
New Missed Lines
%

packages/Liquid-UI.package/LQAnswerPanel.class/instance/choiceAt.put..st
1
0.0%

packages/Liquid-Core.package/LQPollDraft.class/instance/removeQuestionAt..st
3
0.0%

packages/Liquid-Core.package/LQPoll.class/class/pathToExport.st
3
0.0%

packages/Liquid-UI.package/LQAnswerPanel.class/instance/selectedChoices..st
3
0.0%

packages/Liquid-Core.package/LQAnswerSet.class/instance/id.st
4
0.0%

packages/Liquid-Core.package/LQPoll.class/instance/getVotedChoicesPerChoiceFor..st
4
0.0%

packages/Liquid-UI.package/LQAnswerPanel.class/instance/choiceSelected.st
4
0.0%

packages/Liquid-Core.package/LQPoll.class/instance/requiresAuthentication.st
4
0.0%

packages/Liquid-Network.package/LQRemotePollRepoServer.class/instance/hasPollWithId..st
4
0.0%

packages/Liquid-UI.package/LQAnswerPanel.class/instance/builder.st
4
0.0%

Totals

Change from base Build<PHONE_NUMBER>:
-39.2%

Covered Lines:
1402

Relevant Lines:
3596

💛  - Coveralls

The feature does unfortunately not work like it should. Here, a list of some of the issues found:

The renaming of certain classes involved broke many tests. You have to rename the classes there as well
self answer votedChoiceList used in packages/Liquid-UI.package/LQAnswerPanel.class/instance/updateAnswer.st does not exist

replace with self answer choicesRanking:

There are buttons overlapping in the draft builder
The poll still starts with a priority vote question instead of an empty poll

Pull Request Test Coverage Report for Build<PHONE_NUMBER>
Details

130 of 329 (39.51%)  changed or added relevant lines in 66 files are covered.
41 unchanged lines in 9 files lost coverage.
Overall coverage decreased (-6.2%) to 71.969%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

packages/Liquid-UI.package/LQAnswerPanel.class/instance/isValidSelection.ForChoiceAt..st
0
1
0.0%

packages/Liquid-UI.package/LQAnswerPanel.class/instance/isValidSizedSelection..st
0
1
0.0%

packages/Liquid-Core.package/LQPriorityQuestion.class/instance/maxNumberOfChoices.st
0
3
0.0%

packages/Liquid-Core.package/LQPriorityQuestion.class/instance/numberOfChoices..st
0
3
0.0%

packages/Liquid-Core.package/LQPriorityQuestion.class/instance/numberOfChoices.st
0
3
0.0%

packages/Liquid-UI.package/LQPollDraftBuilder.class/instance/addPriorityQuestion.st
0
3
0.0%

packages/Liquid-UI.package/LQPriorityQuestionBuilder.class/instance/createPriorityExplanationLabel.st
0
3
0.0%

packages/Liquid-Core.package/LQPriorityQuestion.class/instance/addChoice..st
0
4
0.0%

packages/Liquid-Core.package/LQPriorityQuestion.class/instance/buildEmptyAnswer.st
0
4
0.0%

packages/Liquid-Core.package/LQPriorityQuestion.class/instance/choiceDescriptions.st
0
4
0.0%

Files with Coverage Reduction
New Missed Lines
%

packages/Liquid-UI.package/LQAnswerPanel.class/instance/choiceAt.put..st
1
0.0%

packages/Liquid-Core.package/LQUserSet.class/instance/getUserWithToken..st
4
0.0%

packages/Liquid-Network.package/LQDelayMessageDecorator.class/instance/object.st
4
0.0%

packages/Liquid-Network.package/LQDelayMessageDecorator.class/instance/object..st
4
0.0%

packages/Liquid-Network.package/LQDelayMessageDecorator.class/instance/on..st
4
0.0%

packages/Liquid-Network.package/LQDelayMessageDecorator.class/class/on..st
4
0.0%

packages/Liquid-Network.package/LQRemotePollRepoServer.class/instance/addAnswerSet.FromUser.ToPoll..st
5
0.0%

packages/Liquid-Network.package/LQDelayMessageDecorator.class/instance/doesNotUnderstand..st
7
0.0%

packages/Liquid-Network.package/LQAntiCheat.class/instance/isAnswer.From.ValidFor.In..st
8
0.0%

Totals

Change from base Build<PHONE_NUMBER>:
-6.2%

Covered Lines:
2588

Relevant Lines:
3596

💛  - Coveralls

Pull Request Test Coverage Report for Build<PHONE_NUMBER>
Details

130 of 329 (39.51%)  changed or added relevant lines in 66 files are covered.
1 unchanged line in 1 file lost coverage.
Overall coverage decreased (-5.1%) to 73.081%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

packages/Liquid-UI.package/LQAnswerPanel.class/instance/isValidSelection.ForChoiceAt..st
0
1
0.0%

packages/Liquid-UI.package/LQAnswerPanel.class/instance/isValidSizedSelection..st
0
1
0.0%

packages/Liquid-Core.package/LQPriorityQuestion.class/instance/maxNumberOfChoices.st
0
3
0.0%

packages/Liquid-Core.package/LQPriorityQuestion.class/instance/numberOfChoices..st
0
3
0.0%

packages/Liquid-Core.package/LQPriorityQuestion.class/instance/numberOfChoices.st
0
3
0.0%

packages/Liquid-UI.package/LQPollDraftBuilder.class/instance/addPriorityQuestion.st
0
3
0.0%

packages/Liquid-UI.package/LQPriorityQuestionBuilder.class/instance/createPriorityExplanationLabel.st
0
3
0.0%

packages/Liquid-Core.package/LQPriorityQuestion.class/instance/addChoice..st
0
4
0.0%

packages/Liquid-Core.package/LQPriorityQuestion.class/instance/buildEmptyAnswer.st
0
4
0.0%

packages/Liquid-Core.package/LQPriorityQuestion.class/instance/choiceDescriptions.st
0
4
0.0%

Files with Coverage Reduction
New Missed Lines
%

packages/Liquid-UI.package/LQAnswerPanel.class/instance/choiceAt.put..st
1
0.0%

Totals

Change from base Build<PHONE_NUMBER>:
-5.1%

Covered Lines:
2628

Relevant Lines:
3596

💛  - Coveralls

Pull Request Test Coverage Report for Build<PHONE_NUMBER>
Details

131 of 330 (39.7%)  changed or added relevant lines in 67 files are covered.
1 unchanged line in 1 file lost coverage.
Overall coverage decreased (-5.0%) to 73.192%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

packages/Liquid-UI.package/LQAnswerPanel.class/instance/isValidSelection.ForChoiceAt..st
0
1
0.0%

packages/Liquid-UI.package/LQAnswerPanel.class/instance/isValidSizedSelection..st
0
1
0.0%

packages/Liquid-Core.package/LQPriorityQuestion.class/instance/maxNumberOfChoices.st
0
3
0.0%

packages/Liquid-Core.package/LQPriorityQuestion.class/instance/numberOfChoices..st
0
3
0.0%

packages/Liquid-Core.package/LQPriorityQuestion.class/instance/numberOfChoices.st
0
3
0.0%

packages/Liquid-UI.package/LQPollDraftBuilder.class/instance/addPriorityQuestion.st
0
3
0.0%

packages/Liquid-UI.package/LQPriorityQuestionBuilder.class/instance/createPriorityExplanationLabel.st
0
3
0.0%

packages/Liquid-Core.package/LQPriorityQuestion.class/instance/addChoice..st
0
4
0.0%

packages/Liquid-Core.package/LQPriorityQuestion.class/instance/buildEmptyAnswer.st
0
4
0.0%

packages/Liquid-Core.package/LQPriorityQuestion.class/instance/choiceDescriptions.st
0
4
0.0%

Files with Coverage Reduction
New Missed Lines
%

packages/Liquid-UI.package/LQAnswerPanel.class/instance/choiceAt.put..st
1
0.0%

Totals

Change from base Build<PHONE_NUMBER>:
-5.0%

Covered Lines:
2632

Relevant Lines:
3596

💛  - Coveralls

Pull Request Test Coverage Report for Build<PHONE_NUMBER>
Details

131 of 326 (40.18%)  changed or added relevant lines in 66 files are covered.
1 unchanged line in 1 file lost coverage.
Overall coverage decreased (-4.9%) to 73.32%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

packages/Liquid-UI.package/LQAnswerPanel.class/instance/isValidSelection.ForChoiceAt..st
0
1
0.0%

packages/Liquid-UI.package/LQAnswerPanel.class/instance/isValidSizedSelection..st
0
1
0.0%

packages/Liquid-Core.package/LQPriorityQuestion.class/instance/maxNumberOfChoices.st
0
3
0.0%

packages/Liquid-Core.package/LQPriorityQuestion.class/instance/numberOfChoices..st
0
3
0.0%

packages/Liquid-Core.package/LQPriorityQuestion.class/instance/numberOfChoices.st
0
3
0.0%

packages/Liquid-UI.package/LQPollDraftBuilder.class/instance/addPriorityQuestion.st
0
3
0.0%

packages/Liquid-UI.package/LQPriorityQuestionBuilder.class/instance/createPriorityExplanationLabel.st
0
3
0.0%

packages/Liquid-Core.package/LQPriorityQuestion.class/instance/addChoice..st
0
4
0.0%

packages/Liquid-Core.package/LQPriorityQuestion.class/instance/buildEmptyAnswer.st
0
4
0.0%

packages/Liquid-Core.package/LQPriorityQuestion.class/instance/choiceDescriptions.st
0
4
0.0%

Files with Coverage Reduction
New Missed Lines
%

packages/Liquid-UI.package/LQAnswerPanel.class/instance/choiceAt.put..st
1
0.0%

Totals

Change from base Build<PHONE_NUMBER>:
-4.9%

Covered Lines:
2553

Relevant Lines:
3482

💛  - Coveralls

Pull Request Test Coverage Report for Build<PHONE_NUMBER>
Details

131 of 330 (39.7%)  changed or added relevant lines in 67 files are covered.
1 unchanged line in 1 file lost coverage.
Overall coverage decreased (-4.1%) to 74.055%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

packages/Liquid-UI.package/LQAnswerPanel.class/instance/isValidSelection.ForChoiceAt..st
0
1
0.0%

packages/Liquid-UI.package/LQAnswerPanel.class/instance/isValidSizedSelection..st
0
1
0.0%

packages/Liquid-Core.package/LQPriorityQuestion.class/instance/maxNumberOfChoices.st
0
3
0.0%

packages/Liquid-Core.package/LQPriorityQuestion.class/instance/numberOfChoices..st
0
3
0.0%

packages/Liquid-Core.package/LQPriorityQuestion.class/instance/numberOfChoices.st
0
3
0.0%

packages/Liquid-UI.package/LQPollDraftBuilder.class/instance/addPriorityQuestion.st
0
3
0.0%

packages/Liquid-UI.package/LQPriorityQuestionBuilder.class/instance/createPriorityExplanationLabel.st
0
3
0.0%

packages/Liquid-Core.package/LQPriorityQuestion.class/instance/addChoice..st
0
4
0.0%

packages/Liquid-Core.package/LQPriorityQuestion.class/instance/buildEmptyAnswer.st
0
4
0.0%

packages/Liquid-Core.package/LQPriorityQuestion.class/instance/choiceDescriptions.st
0
4
0.0%

Files with Coverage Reduction
New Missed Lines
%

packages/Liquid-UI.package/LQAnswerPanel.class/instance/choiceAt.put..st
1
0.0%

Totals

Change from base Build<PHONE_NUMBER>:
-4.1%

Covered Lines:
2663

Relevant Lines:
3596

💛  - Coveralls

Pull Request Test Coverage Report for Build<PHONE_NUMBER>
Warning: This coverage report may be inaccurate.
This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

For more information on this, see Tracking coverage changes with pull request builds.
To avoid this issue with future PRs, see these Recommended CI Configurations.
For a quick fix, rebase this PR at GitHub. Your next report should be accurate.

Details

131 of 330 (39.7%)  changed or added relevant lines in 67 files are covered.
5 unchanged lines in 2 files lost coverage.
Overall coverage decreased (-6.7%) to 71.485%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

packages/Liquid-UI.package/LQAnswerPanel.class/instance/isValidSelection.ForChoiceAt..st
0
1
0.0%

packages/Liquid-UI.package/LQAnswerPanel.class/instance/isValidSizedSelection..st
0
1
0.0%

packages/Liquid-Core.package/LQPriorityQuestion.class/instance/maxNumberOfChoices.st
0
3
0.0%

packages/Liquid-Core.package/LQPriorityQuestion.class/instance/numberOfChoices..st
0
3
0.0%

packages/Liquid-Core.package/LQPriorityQuestion.class/instance/numberOfChoices.st
0
3
0.0%

packages/Liquid-UI.package/LQPollDraftBuilder.class/instance/addPriorityQuestion.st
0
3
0.0%

packages/Liquid-UI.package/LQPriorityQuestionBuilder.class/instance/createPriorityExplanationLabel.st
0
3
0.0%

packages/Liquid-Core.package/LQPriorityQuestion.class/instance/addChoice..st
0
4
0.0%

packages/Liquid-Core.package/LQPriorityQuestion.class/instance/buildEmptyAnswer.st
0
4
0.0%

packages/Liquid-Core.package/LQPriorityQuestion.class/instance/choiceDescriptions.st
0
4
0.0%

Files with Coverage Reduction
New Missed Lines
%

packages/Liquid-UI.package/LQAnswerPanel.class/instance/choiceAt.put..st
1
0.0%

packages/Liquid-UI.package/LQStartMenu.class/instance/enterParticipantMode.st
4
0.0%

Totals

Change from base Build<PHONE_NUMBER>:
-6.7%

Covered Lines:
2364

Relevant Lines:
3307

💛  - Coveralls

Pull Request Test Coverage Report for Build<PHONE_NUMBER>
Details

131 of 330 (39.7%)  changed or added relevant lines in 67 files are covered.
1 unchanged line in 1 file lost coverage.
Overall coverage decreased (-4.1%) to 74.055%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

packages/Liquid-UI.package/LQAnswerPanel.class/instance/isValidSelection.ForChoiceAt..st
0
1
0.0%

packages/Liquid-UI.package/LQAnswerPanel.class/instance/isValidSizedSelection..st
0
1
0.0%

packages/Liquid-Core.package/LQPriorityQuestion.class/instance/maxNumberOfChoices.st
0
3
0.0%

packages/Liquid-Core.package/LQPriorityQuestion.class/instance/numberOfChoices..st
0
3
0.0%

packages/Liquid-Core.package/LQPriorityQuestion.class/instance/numberOfChoices.st
0
3
0.0%

packages/Liquid-UI.package/LQPollDraftBuilder.class/instance/addPriorityQuestion.st
0
3
0.0%

packages/Liquid-UI.package/LQPriorityQuestionBuilder.class/instance/createPriorityExplanationLabel.st
0
3
0.0%

packages/Liquid-Core.package/LQPriorityQuestion.class/instance/addChoice..st
0
4
0.0%

packages/Liquid-Core.package/LQPriorityQuestion.class/instance/buildEmptyAnswer.st
0
4
0.0%

packages/Liquid-Core.package/LQPriorityQuestion.class/instance/choiceDescriptions.st
0
4
0.0%

Files with Coverage Reduction
New Missed Lines
%

packages/Liquid-UI.package/LQAnswerPanel.class/instance/choiceAt.put..st
1
0.0%

Totals

Change from base Build<PHONE_NUMBER>:
-4.1%

Covered Lines:
2663

Relevant Lines:
3596

💛  - Coveralls

Pull Request Test Coverage Report for Build<PHONE_NUMBER>
Details

108 of 330 (32.73%)  changed or added relevant lines in 67 files are covered.
46 unchanged lines in 5 files lost coverage.
Overall coverage decreased (-5.9%) to 67.353%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

packages/Liquid-UI.package/LQAnswerPanel.class/instance/isValidSelection.ForChoiceAt..st
0
1
0.0%

packages/Liquid-UI.package/LQAnswerPanel.class/instance/isValidSizedSelection..st
0
1
0.0%

packages/Liquid-Core.package/LQPriorityQuestion.class/instance/maxNumberOfChoices.st
0
3
0.0%

packages/Liquid-Core.package/LQPriorityQuestion.class/instance/numberOfChoices..st
0
3
0.0%

packages/Liquid-Core.package/LQPriorityQuestion.class/instance/numberOfChoices.st
0
3
0.0%

packages/Liquid-UI.package/LQPollDraftBuilder.class/instance/addPriorityQuestion.st
0
3
0.0%

packages/Liquid-UI.package/LQPriorityQuestionBuilder.class/instance/createPriorityExplanationLabel.st
0
3
0.0%

packages/Liquid-Core.package/LQPriorityQuestion.class/instance/addChoice..st
0
4
0.0%

packages/Liquid-Core.package/LQPriorityQuestion.class/instance/buildEmptyAnswer.st
0
4
0.0%

packages/Liquid-Core.package/LQPriorityQuestion.class/instance/choiceDescriptions.st
0
4
0.0%

Files with Coverage Reduction
New Missed Lines
%

packages/Liquid-UI.package/LQAnswerPanel.class/instance/choiceAt.put..st
1
0.0%

packages/Liquid-UI.package/LQPollDraftBuilder.class/instance/buildQuestionBuilder.st
7
0.0%

packages/Liquid-UI.package/LQPollDraftBuilder.class/instance/buildRemoveQuestionButtonWith..st
12
0.0%

packages/Liquid-UI.package/LQPollDraftBuilder.class/instance/buildSaveDraftButtonWith..st
12
0.0%

packages/Liquid-UI.package/LQPollDraftBuilder.class/instance/buildManageUserSetsButton..st
14
0.0%

Totals

Change from base Build<PHONE_NUMBER>:
-5.9%

Covered Lines:
2321

Relevant Lines:
3446

💛  - Coveralls

Pull Request Test Coverage Report for Build<PHONE_NUMBER>
Details

134 of 333 (40.24%)  changed or added relevant lines in 67 files are covered.
1 unchanged line in 1 file lost coverage.
Overall coverage decreased (-3.9%) to 69.345%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

packages/Liquid-UI.package/LQAnswerPanel.class/instance/isValidSelection.ForChoiceAt..st
0
1
0.0%

packages/Liquid-UI.package/LQAnswerPanel.class/instance/isValidSizedSelection..st
0
1
0.0%

packages/Liquid-Core.package/LQPriorityQuestion.class/instance/maxNumberOfChoices.st
0
3
0.0%

packages/Liquid-Core.package/LQPriorityQuestion.class/instance/numberOfChoices..st
0
3
0.0%

packages/Liquid-Core.package/LQPriorityQuestion.class/instance/numberOfChoices.st
0
3
0.0%

packages/Liquid-UI.package/LQPollDraftBuilder.class/instance/addPriorityQuestion.st
0
3
0.0%

packages/Liquid-UI.package/LQPriorityQuestionBuilder.class/instance/createPriorityExplanationLabel.st
0
3
0.0%

packages/Liquid-Core.package/LQPriorityQuestion.class/instance/addChoice..st
0
4
0.0%

packages/Liquid-Core.package/LQPriorityQuestion.class/instance/buildEmptyAnswer.st
0
4
0.0%

packages/Liquid-Core.package/LQPriorityQuestion.class/instance/choiceDescriptions.st
0
4
0.0%

Files with Coverage Reduction
New Missed Lines
%

packages/Liquid-UI.package/LQAnswerPanel.class/instance/choiceAt.put..st
1
0.0%

Totals

Change from base Build<PHONE_NUMBER>:
-3.9%

Covered Lines:
2391

Relevant Lines:
3448

💛  - Coveralls

Pull Request Test Coverage Report for Build<PHONE_NUMBER>
Details

134 of 333 (40.24%)  changed or added relevant lines in 67 files are covered.
1 unchanged line in 1 file lost coverage.
Overall coverage decreased (-3.9%) to 69.345%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

packages/Liquid-UI.package/LQAnswerPanel.class/instance/isValidSelection.ForChoiceAt..st
0
1
0.0%

packages/Liquid-UI.package/LQAnswerPanel.class/instance/isValidSizedSelection..st
0
1
0.0%

packages/Liquid-Core.package/LQPriorityQuestion.class/instance/maxNumberOfChoices.st
0
3
0.0%

packages/Liquid-Core.package/LQPriorityQuestion.class/instance/numberOfChoices..st
0
3
0.0%

packages/Liquid-Core.package/LQPriorityQuestion.class/instance/numberOfChoices.st
0
3
0.0%

packages/Liquid-UI.package/LQPollDraftBuilder.class/instance/addPriorityQuestion.st
0
3
0.0%

packages/Liquid-UI.package/LQPriorityQuestionBuilder.class/instance/createPriorityExplanationLabel.st
0
3
0.0%

packages/Liquid-Core.package/LQPriorityQuestion.class/instance/addChoice..st
0
4
0.0%

packages/Liquid-Core.package/LQPriorityQuestion.class/instance/buildEmptyAnswer.st
0
4
0.0%

packages/Liquid-Core.package/LQPriorityQuestion.class/instance/choiceDescriptions.st
0
4
0.0%

Files with Coverage Reduction
New Missed Lines
%

packages/Liquid-UI.package/LQAnswerPanel.class/instance/choiceAt.put..st
1
0.0%

Totals

Change from base Build<PHONE_NUMBER>:
-3.9%

Covered Lines:
2391

Relevant Lines:
3448

💛  - Coveralls

Pull Request Test Coverage Report for Build<PHONE_NUMBER>
Details

134 of 333 (40.24%)  changed or added relevant lines in 67 files are covered.
1 unchanged line in 1 file lost coverage.
Overall coverage decreased (-3.9%) to 69.345%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

packages/Liquid-UI.package/LQAnswerPanel.class/instance/isValidSelection.ForChoiceAt..st
0
1
0.0%

packages/Liquid-UI.package/LQAnswerPanel.class/instance/isValidSizedSelection..st
0
1
0.0%

packages/Liquid-Core.package/LQPriorityQuestion.class/instance/maxNumberOfChoices.st
0
3
0.0%

packages/Liquid-Core.package/LQPriorityQuestion.class/instance/numberOfChoices..st
0
3
0.0%

packages/Liquid-Core.package/LQPriorityQuestion.class/instance/numberOfChoices.st
0
3
0.0%

packages/Liquid-UI.package/LQPollDraftBuilder.class/instance/addPriorityQuestion.st
0
3
0.0%

packages/Liquid-UI.package/LQPriorityQuestionBuilder.class/instance/createPriorityExplanationLabel.st
0
3
0.0%

packages/Liquid-Core.package/LQPriorityQuestion.class/instance/addChoice..st
0
4
0.0%

packages/Liquid-Core.package/LQPriorityQuestion.class/instance/buildEmptyAnswer.st
0
4
0.0%

packages/Liquid-Core.package/LQPriorityQuestion.class/instance/choiceDescriptions.st
0
4
0.0%

Files with Coverage Reduction
New Missed Lines
%

packages/Liquid-UI.package/LQAnswerPanel.class/instance/choiceAt.put..st
1
0.0%

Totals

Change from base Build<PHONE_NUMBER>:
-3.9%

Covered Lines:
2391

Relevant Lines:
3448

💛  - Coveralls

Pull Request Test Coverage Report for Build<PHONE_NUMBER>
Details

134 of 333 (40.24%)  changed or added relevant lines in 67 files are covered.
1 unchanged line in 1 file lost coverage.
Overall coverage decreased (-3.9%) to 69.345%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

packages/Liquid-UI.package/LQAnswerPanel.class/instance/isValidSelection.ForChoiceAt..st
0
1
0.0%

packages/Liquid-UI.package/LQAnswerPanel.class/instance/isValidSizedSelection..st
0
1
0.0%

packages/Liquid-Core.package/LQPriorityQuestion.class/instance/maxNumberOfChoices.st
0
3
0.0%

packages/Liquid-Core.package/LQPriorityQuestion.class/instance/numberOfChoices..st
0
3
0.0%

packages/Liquid-Core.package/LQPriorityQuestion.class/instance/numberOfChoices.st
0
3
0.0%

packages/Liquid-UI.package/LQPollDraftBuilder.class/instance/addPriorityQuestion.st
0
3
0.0%

packages/Liquid-UI.package/LQPriorityQuestionBuilder.class/instance/createPriorityExplanationLabel.st
0
3
0.0%

packages/Liquid-Core.package/LQPriorityQuestion.class/instance/addChoice..st
0
4
0.0%

packages/Liquid-Core.package/LQPriorityQuestion.class/instance/buildEmptyAnswer.st
0
4
0.0%

packages/Liquid-Core.package/LQPriorityQuestion.class/instance/choiceDescriptions.st
0
4
0.0%

Files with Coverage Reduction
New Missed Lines
%

packages/Liquid-UI.package/LQAnswerPanel.class/instance/choiceAt.put..st
1
0.0%

Totals

Change from base Build<PHONE_NUMBER>:
-3.9%

Covered Lines:
2391

Relevant Lines:
3448

💛  - Coveralls

Pull Request Test Coverage Report for Build<PHONE_NUMBER>
Details

132 of 331 (39.88%)  changed or added relevant lines in 67 files are covered.
1 unchanged line in 1 file lost coverage.
Overall coverage decreased (-3.9%) to 69.327%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

packages/Liquid-UI.package/LQAnswerPanel.class/instance/isValidSelection.ForChoiceAt..st
0
1
0.0%

packages/Liquid-UI.package/LQAnswerPanel.class/instance/isValidSizedSelection..st
0
1
0.0%

packages/Liquid-Core.package/LQPriorityQuestion.class/instance/maxNumberOfChoices.st
0
3
0.0%

packages/Liquid-Core.package/LQPriorityQuestion.class/instance/numberOfChoices..st
0
3
0.0%

packages/Liquid-Core.package/LQPriorityQuestion.class/instance/numberOfChoices.st
0
3
0.0%

packages/Liquid-UI.package/LQPollDraftBuilder.class/instance/addPriorityQuestion.st
0
3
0.0%

packages/Liquid-UI.package/LQPriorityQuestionBuilder.class/instance/createPriorityExplanationLabel.st
0
3
0.0%

packages/Liquid-Core.package/LQPriorityQuestion.class/instance/addChoice..st
0
4
0.0%

packages/Liquid-Core.package/LQPriorityQuestion.class/instance/buildEmptyAnswer.st
0
4
0.0%

packages/Liquid-Core.package/LQPriorityQuestion.class/instance/choiceDescriptions.st
0
4
0.0%

Files with Coverage Reduction
New Missed Lines
%

packages/Liquid-UI.package/LQAnswerPanel.class/instance/choiceAt.put..st
1
0.0%

Totals

Change from base Build<PHONE_NUMBER>:
-3.9%

Covered Lines:
2389

Relevant Lines:
3446

💛  - Coveralls


Limited REPL support

Cur will work from the REPL, but can only use definitions provided by libraries that have been required. For instance, in DrRacket, if a new inductive definition if given in the definitions window, it is not accessible via the REPL. However, if the same definition is saved in a library, and that library required in the definitions window, then the new definition will be available in the REPL.

Also, things like define and require do not work in the REPL.


System.IO.Path.GetDirectoryName no longer throws argument exceptions

Summary
The System.IO.Path.GetDirectoryName static method documentation states that it will throw an ArgumentException under the following circumstances:

Exceptions
ArgumentException
The path parameter contains invalid characters, is empty, or contains only white spaces.

When using the .NET Framework, an ArgumentException is raised whenever GetDirectoryName is invoked with a string containing invalid path characters, an empty string, or a string containing only whitespace.
In .NET Core, the behavior changed, but the documentation remained the same, so one of two things needs to be updated:

If the change in behavior is correct, the documentation needs to be updated for .NET Core.
If the change in behavior is incorrect, that should be corrected.

Reproduction script
I discovered this using PowerShell, so I'll provide a PowerShell script that can reproduce the issue. If you run the script below in Windows PowerShell 5.1, which uses the .NET Framework, the output is what is shown as the expected output after the script. If you run the script below using the latest PowerShell preview, which uses .NET Core 3.0, or if you run the script in PowerShell Core 6.2.x, which uses .NET Core 2.x, you will see that GetDirectoryName no longer throws an ArgumentException the way it should according to the documentation.
All tests have been executed on Microsoft Windows 10.0.17763.
Here is the script that reproduces the issue:
Add-Type -MemberDefinition @'
    public static bool TestInvalidString()
    {
        return null == System.IO.Path.GetDirectoryName("\\/:*?\"<>|");
    }
    public static bool TestWhitespaceString()
    {
        return null == System.IO.Path.GetDirectoryName("    ");
    }
    public static bool TestEmptyString()
    {
        return null == System.IO.Path.GetDirectoryName("");
    }
    public static bool TestNull()
    {
        return null == System.IO.Path.GetDirectoryName(null);
    }
'@ -Name GetDirectoryName -Namespace My

function DoesItThrow {
    param($MethodName)
    try {
        $result = [My.GetDirectoryName]::${MethodName}()
    } catch {
        return $true
    }
    return $false
}

DoesItThrow TestInvalidString
DoesItThrow TestWhitespaceString
DoesItThrow TestEmptyString
DoesItThrow TestNull

Expected output according to documentation
This is what you will see when using the .NET Framework (Windows PowerShell 5.1):
True
True
True
False

Actual output
This is what you will see when using .NET Core 2.x or later (PowerShell Core 6.2.x or PowerShell 7.x preview):
False
False
False
False

Nevermind, I see that this was an intentional change, as explained here. Closing.


N/A heat rates for plants than only report gen/fuel in one month of the year

Describe the bug
A number of small plants appear to report all of their generation/fuel consumption for at least some units in a single month of the year (e.g 10805, 50748, 50850, 56356, 57666, and 58161). When calculating unit heat rates via pudl_out, the generation and boiler fuel have the function pudl.helpers.sum_na applied. This function returns N/A when any of the values in a year are N/A. With all fuel/generation reported in a single month, it isn't possible to get valid data for these plants.
Bug Severity
Medium: The units tend to be small and I can generally work around it. But it was a pain to figure out why some units don't have a valid heat rate in any year of the data set.
To Reproduce
pudl_out.bf_eia923().query("plant_id_eia==10805")
pudl_out.gen_eia923().query("plant_id_eia==10805")

Expected behavior
I'm not sure how to best generalize, but if both the generation and boiler fuel are not reported in a month (or in the first 11 months of a year?) then drop them and only keep the valid months of data before aggregating.

Forgot to include above. This is using v0.5.0 of the software and database.
❯ conda list pudl
# packages in environment at /opt/miniconda3/envs/powergenome:
#
# Name                    Version                   Build  Channel
catalystcoop.pudl         0.5.0              pyhd8ed1ab_3    conda-forge


suggested extension hourly data - total to be refactored

Thanks for your contribution, I've merged your code!
Some comments:
Please don't use separate files in a separate folder next time. Just edit the actual project files in a separate branch. Now I had to figure out whatever you changed, and copy the code over. Not only is it tedious and error prone, but also now you don't get any attribution, since git thinks I have written that code.
I have also written a separate parser for the hourly data, since date and hour were in separate columns and needed to be put together.
About that: I don't understand exactly what KNMI mean when they say a measurement comes from the N'th hour in a day. Normally that makes sense, but I've downloaded data for 2020-03-29, a day that should only have 23 hours (daylight saving time switch!), and KNMI returned 24 data points. So I'm confused. Also, because of that, it is impossible to localize that dataframe, so returned timestamps are timezone-naive.

Hi Jan,
good to see. Yes, I completely agree with you about the 'loose files'.
I just wanted you to give you an impression; and expected the refactoring
and valid checkout-merge later on my side.
Too many projects and loosing the me-being concise.
But you already merge/refactored. Wonderful.
Next time I will perform better.
warm regards
Wico
On Tue, 20 Oct 2020 at 17:14, Jan Pecinovsky<EMAIL_ADDRESS>wrote:

Thanks for your contribution, I've merged your code!
Some comments:
Please don't use separate files in a separate folder next time. Just edit
the actual project files in a separate branch. Now I had to figure out
whatever you changed, and copy the code over. Not only is it tedious and
error prone, but also now you don't get any attribution, since git thinks I
have written that code.
I have also written a separate parser for the hourly data, since date and
hour were in separate columns and needed to be put together.
About that: I don't understand exactly what KNMI mean when they say a
measurement comes from the N'th hour in a day. Normally that makes sense,
but I've downloaded data for 2020-03-29, a day that should only have 23
hours (daylight saving time switch!), and KNMI returned 24 data points. So
I'm confused. Also, because of that, it is impossible to localize that
dataframe, so returned timestamps are timezone-naive.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/EnergieID/KNMI-py/pull/8#issuecomment-712926097, or
unsubscribe
https://github.com/notifications/unsubscribe-auth/ACXAJDZMOGSTMTEVITBYOTTSLWSM7ANCNFSM4SRWPVQA
.

Tip: pull requests now have the option to be marked as "Draft", this indicates that you're not quite ready for a merge just yet, and blocks the admin from performing the merge.

Its a world on itself. Thanks!
Currently I am involved in the field of Datascience/AI algorithms.... the
KNMI api of you/us will be used soon in in the field of climate-systems in
buildings.
On Wed, 21 Oct 2020 at 11:46, Jan Pecinovsky<EMAIL_ADDRESS>wrote:

Tip: pull requests now have the option to be marked as "Draft", this
indicates that you're not quite ready for a merge just yet, and blocks the
admin from performing the merge.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/EnergieID/KNMI-py/pull/8#issuecomment-713447937, or
unsubscribe
https://github.com/notifications/unsubscribe-auth/ACXAJD624K3RP3RAEDPHALTSL2UWJANCNFSM4SRWPVQA
.

Good to know! Keep up the good work.


Fix typo and escape character "|" in README.md

Coverage remained the same at 93.427% when pulling 8094388dd26b2115b4aff25c264af37487d27b5b on lwzm:fix_readme into 4f1784742666045a3c33bd471dbe489b4f5c7699 on Jahaja:master.


Service -> Network

An offsite discussion has highlighted to need to switch from referring to the Threads 'Service' layers as the Threads 'Network' layer. These changes should ideally be made before a major documentation push/sprint.

Done in https://github.com/textileio/go-threads/pull/270


[DNM] RBAC for stytch-java (AUTH-2037)

First pass. It's more-or-less a copy of how we implemented other languages.
Don't trust me, this is the first Kotlin I've ever written.
Companion PR: https://github.com/stytchauth/sdk-codegen/pull/132

I'll hold on this until after the next pass of codegen :)

Made the suggested changes! I feel pretty good about this now. As for unit tests of PolicyCache, this is what we've done in the other repos:
First create a "dummy" policy with the following:
admin -> permissions=[(actions=["*"], resource="foo", (actions=["*"], resource="bar")]
global_writer -> permissions=[(actions=["write", "read"], resource="foo", (actions=["write", "read"], resource="bar")]
global_reader -> permissions=[(actions=["write", "read"], resource="foo", (actions=["write", "read"], resource="bar")]
bar_writer -> permissions=[(actions=["write", "read"], resource="bar")]

policy = Policy(resources=["foo", "bar"], roles=[admin, global_writer, global_reader, bar_writer])

### Test 1: Tenancy mismatch
assert.Raises(TenancyError, performAuthorizationCheck(roles=[admin.role_id], org="my_org", check=AuthorizationCheck(org="other_org", resource_id="foo", action="write")))

### Test 2: Has action, but not resource
... // test that bar_writer can't operate on a foo write request

### Test 3: Has resource, but not action
... // test that bar_writer can't operate on a bar delete request

### Test 4: Has resource and action
... // test that global_writer can operate on a foo write request

### Test 5: Has resource and star action
... // test that admin can operate on a foo write request


Discussion: Better integration with MoonNet

Hi!
I'm interested to keep contributing with this project because I'm studying DeFi protocols and it's a great way to get they better, but one thing is bothering me, the time needed to run the tests, it's making my code/learning slowly since running a forked Ganache node isn't the fastest thing out there... because of that I've also get interested in the MoonNet project because it's trying to solve this issue, but actually, the performance of fork from Infura and fork from MoonNet are almost the same for me (sometimes Infura is performing better).
So, before back my contribution/studies with new protocols, I've spent some time trying to improve the time needed to run the tests and I think that I've found something (that can could also help MoonNet with their users' support):
I've started making some test rounds using the compound.test.ts test suite:
Forked from Infura: 83.418s
Forked from MoonNet: 81.527s
MoonNet (without forking): 29.596s :1st_place_medal:
Based on these results, I was want to run all test suites using MoonNet without forking it. For make it possible some changes were needed because since the test suites run in parallel, all of them would run against the same node/state making some unexpected behaviors happen (e.g. mint dai in test suite A can make a dai balance assert to fail int test suite B).
The changes that I've made were:

Run jest without parallelism (--runInBand param);
Since MoonNet node is a ganache mode, we can call evm_revert and evm_snapshot methods. I've changed setup and tearDown functions to do so.

Here are the time results of running all test suites:
Forked from Infura: 462.934s
Forked from MoonNet: 499.884s
MoonNet (without forking): 89.819s :1st_place_medal:
 PASS  tests/compound.test.ts (27.946s)
  compound
    ✓ enter markets (4305ms)
    ✓ supply 10 ETH (i.e. mint cETH) (3369ms)
    ✓ borrow 20 DAI (4073ms)
    ✓ supply 5 DAI (6321ms)
    ✓ get supply/borrow balances for DAI (1313ms)
    ✓ withdraw 1 ETH from collateral (2777ms)
    ✓ repay 1 DAI of debt (4573ms)

 PASS  tests/aave.test.ts (25.069s)
  aave
    ✓ lend 10 ETH (i.e. mint aETH) (3740ms)
    ✓ borrow 20 DAI (5788ms)
    ✓ lend 5 DAI (5001ms)
    ✓ get supply/borrow balances for DAI (829ms)
    ✓ withdraw 1 ETH from collateral (3035ms)
    ✓ repay 1 DAI of debt (4147ms)
    ✓ retrieve current health factor (1611ms)

 PASS  tests/kyber.test.ts (10.473s)
  kyber
    ✓ buy DAI from Kyber.Network (9542ms)

 PASS  tests/maker.test.ts (9.424s)
  maker
    ✓ create a proxy on Maker (2883ms)
    ✓ open Vault on Maker (5783ms)

 PASS  tests/uniswap.test.ts (7.456s)
  uniswap
    ✓ buy DAI from Uniswap (6689ms)

 PASS  tests/index.test.ts
  initial conditions
    ✓ initial DAI balance of 0 (1255ms)
    ✓ initial ETH balance of 1000 ETH (551ms)

 PASS  tests/medianizer.test.ts
  maker medianizer
    ✓ read ETH price from medianizer (1181ms)

Test Suites: 7 passed, 7 total
Tests:       21 passed, 21 total
Snapshots:   0 total
Time:        89.819s

Some notes:

It's less "safe" than fork since the MoonNet node can remain with the changed state after the jest process;
Keep the parallelism would be ideal but I think that the most important thing is to get the tests running much faster as possible right?
If the coming buidler fork feature is more performatic than the ganache no change would be needed (Do you have some info about it?).
For now, it's a discovery/PoC, this way of running tests should be more battle-tested.

WDTY @adrianmcli @kendricktan?

Thanks for the thoughts @marcelomorgado I think running tests directly on the MoonNet node was @kendricktan's original intention, and it is highly recommended where possible. It really depends on the tests you want to run, but for something like the money-legos repo, the CI usually runs these tests fast enough.
If you're making a dapp, then I would probably run the tests directly on MoonNet. But for this project, I am not sure it's necessary to do that yet. And like you said, we would have the issue of losing parallelism. I wonder if we could spawn a CI that creates Ganache instances in memory that would allow that though.
Definitely a lot to think about. I am not sure what the right answer is. We should keep discussing. @kendricktan any thoughts?

@marcelomorgado Thanks for the inputs. @adrianmcli is right - the original goal I had in mind with moonnet was to minimize iteration time, and the largest bottleneck for me was the testing time.
Unfortuntely, Moonnet wasn't designed to be forked from, it was designed specifically as a Ethereum-testnet-in-the-cloud service that had low latency to a pseudo archival node in order to test/integrate with  existing mainnet defi protocols.

It's less "safe" than fork since the MoonNet node can remain with the changed state after the jest process

You're right. But as you mention, you can revert back to the original state using evm_revert and evm_snapshot :smile:

Keep the parallelism would be ideal but I think that the most important thing is to get the tests running much faster as possible right?

Parallelism can be achieved, but that requires spawning up a new testnet instance for every test suite. Its a tradeoff between time/money/computing power, which is something we might tackle in the future if we have enough time/funding.

If the coming buidler fork feature is more performatic than the ganache no change would be needed (Do you have some info about it?).

Definitely in the words, we will be migrating to builder-evm once it has the forking feature :)