Is it possible not to change sample name?

I noticed if exception occurred with sample, this plugin will add suffix to the sample label, is there a better to avoid change the sample name ?

Currently, you can set the JMeter property jmeter.retrier.sampleLabelSuffix to an empty string.
However, the retries would still have the counter value appended.
Work-around would be to change the sub-results' labels in a JSR223 PostProcessor like so (assuming you don't have nested sub-sub-results):
prev.subResults*.setSampleLabel(prev.sampleLabel)

Let me know if you have a better idea how to implement this in the plugin.


DocsArchive-<IP_ADDRESS>Auto archive content

Please don't merge this PR until target archive repo PR https://github.com/OPS-E2E-PPE/docs-archive-test-target_38236550-0ede-4dc9-8dd9-1fe7171e8f4d/pull/1 is merged into live branch.
Auto archive content to https://github.com/opstest2/docs-archive-test-target_38236550-0ede-4dc9-8dd9-1fe7171e8f4d.git

Docs Build status updates of commit 6f78fd2:
:x: Validation status: errors
Please follow instructions here which may help to resolve issue.

File
Status
Preview URL
Details

:x:Error

Details

[Error: GitBranchDeletedOrForcePushed] Cannot sync git repo to specified commit because branch Release_Archive_main_2022-05-26-08-28-31 has been deleted or has been force pushed

For more details, please refer to the build report.
If you see build warnings/errors with permission issues, it might be due to single sign-on (SSO) enabled on Microsoft's GitHub organizations. Please follow instructions here to re-authorize your GitHub account to Docs Build.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
Note: Your PR may contain errors or warnings unrelated to the files you changed. This happens when external dependencies like GitHub alias, Microsoft alias, cross repo links are updated. Please use these instructions to resolve them.
For any questions, please:Try searching the docs.microsoft.com contributor guidesPost your question in the Docs support channel


Add groups attribute to user profile

Description
Adds groups attribute to user profile. Available behind a feature flag.
Documentation
Does this require changes to the WorkOS Docs? E.g. the API Reference or code snippets need updates.
[ ] Yes

If yes, link a related docs PR and add a docs maintainer as a reviewer. Their approval is required.

Had to update CI pipeline - this happened in the mono repo here: https://work-os.slack.com/archives/CG875BV3J/p1675684580898109

looks fine but do we want to put these in the SDKs and accessible already while the flag is off?

This is necessary to allow a beta test - a customer is using this SDK, so we need to support it here for them to get the groups attribute. It should be backwards compatible - I added a test for when groups aren't passed, and we don't see it in the profile.


External sharing contradicting information?

Hello!
I noticed contradictory statement between this page and https://docs.microsoft.com/en-us/power-bi/service-admin-azure-ad-b2b
Here it says clearly:
"Doesn't support external guest users with Azure business to business (B2B)."
Although on the mentioned page, it says something entirely different:
"When using the Allow external guest users to edit and manage content in the organization feature, the specified guest users get access to your organization's Power BI. They can see any content to which they have permission. They can access Home, browse workspaces, install apps, see where they are on the access list, and contribute content to workspaces. "
"The guest user must have the proper licensing in place to view the content that you shared. There are three ways to make sure the user has a proper license: use Power BI Premium, assign a Power BI Pro license, or use the guest's Power BI Pro license."
Could you help clarify which piece of information is current? Based on #615 I'd be inclined this page needs updating, but it's just a guess.
Best regards,
AlexP

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 7197c1f9-ff31-f86c-faf3-ab89e4ab9573
Version Independent ID: f30cdf40-43c4-e0c3-4941-a02f5bb28fc1
Content: Embed a report in a secure portal or website - Power BI
Content Source: powerbi-docs/service-embed-secure.md
Service: powerbi
Sub-service: powerbi-service
GitHub Login: @rkarlin
Microsoft Alias: rkarlin

Hi @AlexJPawlak,
I'm looking into this issue and will get back to you shortly.

Thank you for submitting feedback on our documentation. This article has been updated and no longer mentions Azure B2B. If your feedback isn’t addressed, please feel free to submit additional feedback for the page.


script/setup failed

Thanks for your cool project!
I follow the quickstart of the instruction, but it seems that I can't pip tensorflow_gpu in the docker container because of network problem. Here is the error information:
Step 13/21 : RUN pip --no-cache-dir install https://storage.googleapis.com/tensorflow/linux/gpu/tensorflow_gpu-1.12.0-cp36-cp36m-linux_x86_64.whl
---> Running in 10ecd6cca56f
Collecting tensorflow-gpu==1.12.0 from https://storage.googleapis.com/tensorflow/linux/gpu/tensorflow_gpu-1.12.0-cp36-cp36m-linux_x86_64.whl
Downloading https://storage.googleapis.com/tensorflow/linux/gpu/tensorflow_gpu-1.12.0-cp36-cp36m-linux_x86_64.whl (281.7MB)
Requirement already satisfied: six>=1.10.0 in /usr/lib/python3/dist-packages (from tensorflow-gpu==1.12.0) (1.10.0)
Collecting termcolor>=1.1.0 (from tensorflow-gpu==1.12.0)
Downloading https://files.pythonhosted.org/packages/8a/48/a76be51647d0eb9f10e2a4511bf3ffb8cc1e6b14e9e4fab46173aa79f981/termcolor-1.1.0.tar.gz
Collecting keras-preprocessing>=1.0.5 (from tensorflow-gpu==1.12.0)
Downloading https://files.pythonhosted.org/packages/28/6a/8c1f62c37212d9fc441a7e26736df51ce6f0e38455816445471f10da4f0a/Keras_Preprocessing-1.1.0-py2.py3-none-any.whl (41kB)
Collecting keras-applications>=1.0.6 (from tensorflow-gpu==1.12.0)
Downloading https://files.pythonhosted.org/packages/71/e3/19762fdfc62877ae9102edf6342d71b28fbfd9dea3d2f96a882ce099b03f/Keras_Applications-1.0.8-py3-none-any.whl (50kB)
Collecting numpy>=1.13.3 (from tensorflow-gpu==1.12.0)
Downloading https://files.pythonhosted.org/packages/e5/e6/c3fdc53aed9fa19d6ff3abf97dfad768ae3afce1b7431f7500000816bda5/numpy-1.17.2-cp36-cp36m-manylinux1_x86_64.whl (20.4MB)
ERROR: Exception:
Traceback (most recent call last):
File "/usr/local/lib/python3.6/dist-packages/pip/_vendor/urllib3/response.py", line 397, in _error_catcher
yield
File "/usr/local/lib/python3.6/dist-packages/pip/_vendor/urllib3/response.py", line 479, in read
data = self._fp.read(amt)
File "/usr/lib/python3.6/http/client.py", line 449, in read
n = self.readinto(b)
File "/usr/lib/python3.6/http/client.py", line 493, in readinto
n = self.fp.readinto(b)
File "/usr/lib/python3.6/socket.py", line 586, in readinto
return self._sock.recv_into(b)
File "/usr/lib/python3.6/ssl.py", line 1012, in recv_into
return self.read(nbytes, buffer)
File "/usr/lib/python3.6/ssl.py", line 874, in read
return self._sslobj.read(len, buffer)
File "/usr/lib/python3.6/ssl.py", line 631, in read
v = self._sslobj.read(len, buffer)
socket.timeout: The read operation timed out

It seems that this error is just because of my network problem. No need to keep it open.


grapesjs - mjml: No compatible with IE11 & Edge

Hi team,
We decided to use mjml in grapes js. Everything works fine except on IE11 and Edge. Most of our customers are on IE11.
On IE11 we have:

On Edge we have

Do you have a chance to correct the problems?
Thank you for your comeback.

This has to do with strict code and those browsers. I started rewriting some of the functions, but to get this completely redone is crazy amount of work. It's not difficult or impossible to fix, just tedious. If you do fix it, please do share your code with the rest of us.

Edge appears to be fixed, still occurs in IE11


[SPARK-31125][K8S]Terminating pods have a deletion timestamp but they are not yet dead.

What changes were proposed in this pull request?
Change what we consider a deleted pod to not include "Terminating"
Why are the changes needed?
If we get a new snapshot while a pod is in the process of being cleaned up we shouldn't delete the executor until it is fully terminated.
Does this PR introduce any user-facing change?
No
How was this patch tested?
This should be covered by the decommissioning tests in that they currently are flaky because we sometimes delete the executor instead of allowing it to decommission all the way.
I also ran this in a loop locally ~80 times with the only failures being the PV suite because of unrelated minikube mount issues.

cc @dongjoon-hyun who's been really great with the test flakiness report & help :)

Test build #119766 has started for PR 27905 at commit 8ce2f47.

Test build #119766 has finished for PR 27905 at commit 8ce2f47.

This patch fails Spark unit tests.
This patch merges cleanly.
This patch adds the following public classes (experimental):
case class PodTerminating(pod: Pod) extends FinalPodState

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/119766/
Test FAILed.

Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/24495/

Kubernetes integration test status failure
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/24495/

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/24495/
Test FAILed.

Kubernetes integration test status success
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/24505/

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/24505/
Test PASSed.

https://media.giphy.com/media/cqsCSWtljevpm/giphy.gif


More than one command

Hi, is it possible to run more than one command on a single sign click?

Yes it is :)
When you edit the command sign via the menu, you just need to enter into the "Add" submenu ;)

Thanks!


How to use GIF in "Feature"?

I want to use gif in Feature. My some code:
    //增加点位
    var anchor = new ol.Feature({
        geometry: new ol.geom.Point([number, number1]),
        name: "anchor" + i,
        id: index + "anchor" + i
    });

    // 设置样式，在样式中就可以设置图标
    anchor.setStyle(new ol.style.Style({
        image: new ol.style.Icon({
            src: '../../Images/1.gif'
        })
    }));

I set gif to a icon in style. But it cannot be used.
And, There cannot use Overlay because I will add very very lots of point and use cluster.
Could you tell me any idea?

I saw #7753 and others issues. there have not use cluster.
I tried to use setInterval of javascript to change image or "postcompose" event. If there isn't use cluster, it is ok.
BUT, when I added cluster, it is very very slowly and cannot be loaded.


history.test fails due to cat producing different results

history.output should be empty but has the following (unprintable) stuff in it:
���~C���k���^UL@echo cc
~E~C~H~V@~C~C^U```^Un@~E~C~H~V@~C~C^Un@~E~C~H~V@~C~C^U���~C���k���^UL@echo cc
~E~C~H~V@~C~C^U```^Un@~E~C~H~V@~C~C^Un@~E~C~H~V@~C~C^U

If I tag the file as EBCDIC, I get:
114c114,115
< ���?~@��~Necho cc
---
> echo cc
> echo cc
119c120,121
< ���?~@��~Necho cc
---
> echo cc
> echo cc

This EBCDIC muck is likely because I am not using the diffutils.
But there is still an issue with the unprintable text coming out in a different spot in the two diffs.
In history.tests the code does:
# these two blocks had better both result in the same output
echo aa
echo bb
echo cc
fc -e cat

echo aa
echo bb
echo cc
fc -e cat -1

They are not exactly the same when traced:
+ echo cc
cc
+ fc -e cat
++ cat /tmp/bash-fc.HcgCxQ
echo cc
echo cc
++ echo cc
cc
+ echo aa
aa
+ echo bb
bb
+ echo cc
cc
+ fc -e cat -1
++ cat /tmp/bash-fc.fCgaxQ
echo cc
echo cc
++ echo cc
cc

Running using the Rocket bash I get an LE dump:
    1     CEEHDSP     +00004B12              CEEPLPKA             CEEHDSP                        UI78103  Call
    2     CEEHRNUH    +0000009A              CEEPLPKA             CEEHRNUH                       HLE77C0  Call
    3     __fprintf_a +00000820              CELHV003                                            HLE77C0  Exception
    4     fc_builtin  +000009F8              bash                                                         Call
    5     execute_builtin
                      +000003BE              bash                                                         Call
    6     execute_builtin_or_function
                      +00000166              bash                                                         Call
    7     execute_simple_command
                      +00000AB2              bash                                                         Call
    8     execute_command_internal
                      +000008E6              bash                                                         Call
    9     execute_command
                      +0000008C              bash                                                         Call
    10    reader_loop +00000284              bash                                                         Call
    11    main        +00000C3A              bash                                                         Call
    12    CEEVROND    +0000127C              CEEPLPKA                                                     Call
    13    EDCZHINV    +000000B4              CELHV003             EDCZHINV                       HLE77C0  Call
    14    CEEBBEXT    +000001C6              CEEPLPKA             CEEBBEXT                       HLE77C0  Call

Adding in diffutils, the differences are closer.


Add an icon for Literal

If possible it would be great to have an icon for literal.club for the profile.. this is mine https://literal.club/timapple
Thanks

Hey Tim! Thanks for sharing this — while there already was an icon for Literal in place, there was a small glitch in the SVG that prevented it from rendering correctly. The file has been updated and the icon should now appear on your profile page. Sorry about that, and thanks again for pointing it out!

works great on my profile!

Thanks!


Use IndexedDB to store tiles on client device

IndexedDB is a web API used to store large volumes of data client side. It has an unusual async API which uses onsuccess and onerror callbacks to connect to the database, create objectStores and orchestrate transactions.
The intention of this issue is to explore saving data retrieved from FOREST servers locally to prevent excessive hammering of the server and to also provide a good offline experience. A better offline experience could also be achieved using WebWorkers but that is a separate issue

This could be done as a pull-through cache, with HTTP as the primary source if an key value pair does not exist in IndexedDB


Speed up atlas downloads

Downloading the atlases can take a long time. In some areas it can seemingly take hours. We should investigate alternatives to improve this, e.g.:

Move to other providers (e.g. Zenodo https://github.com/brainglobe/brainglobe-atlasapi/issues/284#issuecomment-2335129409)
Region-specific mirrors (cc @dbirman)

Just to note, there are lots of places we could store the data, but with various caveats.

Some data sharing repositories - most are not suitable for this type of data, e.g. because the data needs to meet certain standards, and pass a curation process.
AWS/cloudflare - potentially unpredictable costs
EBRAINS - there's an object store (in addition to the curated knowledge base)

Hi! Just to report the speed in Switzerland / Lausanne: it can go as slow at 1 MB/s

Thanks for reporting @NicoKiaru - hopefully we can improve on this in the near future.

Sure, I don't want to make you feel that this post is to put pressure - it's just to be informative and report typical DL speed. I mean, waiting 15 minutes once is not a big problem.


[Req] Show QM and HL MMR on stats screen

Would be nice if the stats-screen either:

had a button to toggle between QM and HL
showed both QM and HL MMR

Agree. So often I forget to change this, based on the game type I'm playing.

We can update table dynamically when you change game type in settings. Will
that be ok?
On Tue, Apr 5, 2016 at 4:54 AM, AndrewPalozzo<EMAIL_ADDRESS>wrote:

Agree. So often I forget to change this, based on the game type I'm
playing.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub
https://github.com/poma/HotsStats/issues/27#issuecomment-205592682

Yeah, I think having it change when you modify the setting would be better... But maybe showing both could be useful too.

done. will be in v5.1


Example of Service Discovery seems incorrect

Describe the bug
I try to follow this instruction https://docs.steeltoe.io/guides/service-discovery/eureka.html?tabs=cli, but am pretty confused. It seems there are some issues. For instance, launchSettings.json is different. what's api/values url? Doc says it is http://localhost:8080/api/values but it is http://localhost:8080/WeatherForecast
If you click Looking for additional params to use when connecting? Have a look at the docs)., you get 404 error.
Steps to reproduce
NA
Expected behavior
I assume I should follow this tutorial strictly and get successful result without any additional change.
Environment (please complete the following information):

Sample name: [e.g. RabbitMQ Connector, Discovery, etc.]
Platform: [e.g. Cloud Foundry, Azure, etc.)
OS: [e.g. Windows, Linux, Mac OSX]
.NET Version [e.g. .NET Core 2.1.0, .NET Framework 4.7.1, etc.]
Steeltoe Version [e.g. 2.3.0]
Any other library versions to note

Screenshots
If applicable, add screenshots to help explain your problem.
Additional context or links
Add any other context about the problem here.

Hi @dingmeng-xue,
Thanks for opening the issue, you're correct that there are definitely some problems with that guide, and I think there are going to be other issues that will come to light quickly if .NET 8 is used, so we're going to need to prioritize https://github.com/SteeltoeOSS/Documentation/issues/229 sooner rather than later. FYI, I'm also going to move this issue to the Documentation repo.
In the interest of getting you up and running quickly:

That broken link should go here
Port 8080 will become the default if you also add the Cloud Hosting dependency
/api/values comes from an older template, it should be /Weatherforecast now
The samples in this folder should work with less effort


Does busted support the customization function return value in unit test

I have two functions:
function A(args)
        -- connect database
	return result
end

function B()
       -- do something
       local result = A(args)
       -- do something
end

Function A needs to connect to the database. I don’t want to connect to the database in my unit test, but this function has a return value. The return value is used in function B. I hope that I can get my own customization function result without actually executing function A. Is there any way to return the customization function value?

Hello!
Yes, you can override the behavior of your function using stubs.
You want a return value, so you need to use Spies.
Here's a simple code example:
-- function you want to test
function B()
    local result = A("my argument")
    return result
end

describe("Some", function ()

    _G.A = function ()
        -- set your result
        return 42
    end

    it("mock", function ()
        spy.on(_G, "A")

        assert.are.equals(B(), 42) -- check function B result
        assert.spy(A).was_called_with("my argument") -- check with what arguments function A was called

        A:revert()
    end)
end)```

@NickFlexer
Hi, Thank you, it works.
But I encountered a more complicated situation, please see the picture below, how do I customize the value of result1 and result2 in busted unit test

if you want a mock package that is called by require you must follow these steps:

describe in a simple table the functions that your code will call and specify the return values for them
mocks the table with spies
specify the resulting table as the result of the package.preload function
call your module under test using require
test it)
remember to revert the stub

example:
describe("Test module", function ()
    it("load module", function ()
        -- 1
        local m = {
            start = function ()
                return 42
            end
        }

        -- 2
        local database = mock(m)

        -- 3
        package.preload["database"] = function ()
            return database
        end

        -- 4
        local test_module = require "test_module"

        -- 5
        assert.are.equals(test_module.set(), 42)
        assert.stub(database.start).was.called_with("my argument")

        -- 6
        mock.revert(database)
    end)
end)

@NickFlexer
Thank you!!! you are really helpfully and explained in detail


Impossible to store backups in AWS S3 eu-south-2 (Spain) region

For some weird reason, when setting region=eu-south-2 (because the bucket is there), the operator will fail to connect to the buckets, with this error:
INFO[2023/02/20 10:48:16] invoking set s3 service client                insecure-tls-skip-verify=false s3-accessKey=MYACCESSKEY s3-bucketName=mybucket s3-endpoint=s3-accesspoint.dualstack.eu-south-2.amazonaws.com s3-endpoint-ca= s3-folder= s3-region=eu-south-2
ERRO[2023/02/20 10:48:16] error syncing 'default-location-recurring-backup': handler backups: failed to check if s3 bucket [mybucket] exists, error: 400 Bad Request, requeuing

Workaround: Move the bucket to eu-west-3 and reconfigure the operator.
@moduon MT-2305

We will investigate further. No initial leads after reviewing what is reported here.

We could not reproduce this issue. In our tests, changing from a us-east-1 to a eu-south-2 bucket did not result in any errors and backups could be saved successfully. This is likely an issue with the cloud setup and not with Rancher/BRO.

Since our team cannot replicate this issue based on the region as described we'll close this out. As mentioned by @jbiers - it's more likely there are other configuration issues or incompatible settings in use on the bucket in that region. If you identify what those settings are please follow up and let us know.


Version 1.7.0. missing texts

Hey, I just download and apply your new Valkyria versions. It is great, but I lost a plenty of text of my tokens and events. And I mean really plenty of them, about 80%. I had almost scenario done so I am mad right now and looking for some solution. Also a lot of buttons change name. Instead of "continue" is there name of token/event.button1 etc. It looks like the all missing texts have also the problem with name of button.
Please, just tell me that it is only small problem and I can fix it easy..

Hi guys! My scenario is almost done. I am just testing it. But I have still the same issue. When I hit SAVE in the editor, I have a lottery if texts disappear or not. It is really annoying. I don't know where is
the problem. It looks like that I have about 25% probability of disappearing texts. And about 50/50 chance to have one of two different broken txt files.
I can put here my scenario just for you and also saved files after the disappearing texts, if it helps you to identify the problem.

I found a work around for this in #757

Thanks scrubbless, you are right about that. Also it helps me converting the localization file from Windows format to UNIX format in my notepad++. And I think, the problem was also when I start event text with quotation marks. I simply add a space in front of it and the saving in editor looks like working fine now.

Hey Fastnavi, you may want to keep this issue open to track the 1.7.0c "corrupting scenario's" issue above.

I have seen that happen, when there was an invalid quotation. Like "hallo " world"
https://github.com/NPBruce/valkyrie/issues/575
This may help to solve the problem:
https://github.com/NPBruce/valkyrie/pull/789#commits-pushed-bff66f6
However, the problem seem to lay in the save logic of the scenario. If only one event text causes a conflict, all other event texts after that go missing.  We may also add a test suite for DictionaryI18n.

Thanks for the update Redwolf2.
I wonder if this issue is linked to the copy and paste error. I noticed phantom text in the localisation file that had since been deleted from events. Checking GitHub previous versions it appears that the text was old stuff that I had pasted in and had disappeared when saving.
My latest scenario doesn't have any issues in 1.7.0c, but I also haven't had the lost text when pasting (I'm wise to it now!)

Here is how to reproduce it.
New Scenario. Add Event0 with the text "hallo " world"
Press Menu > Save
.,English
quest.name,Szenario 1
quest.description,Szenario 1...
Event0.text,"""hallo "" world"""
Event0.button1,Continue

(Event text turns empty in UI)
Press Menu > Save
.,English
quest.name,Szenario 1
quest.description,Szenario 1...

@redwolf2 I couldn't produce the problem following the steps you detail here. Does anyone have an example of data that works in 1.7.0b but not 1.7.0c? Or is the problem that certain operations in 1.7.0c lose data? Still not exactly clear on what is happening, so I want to be sure I am fixing the right thing.

I reproduced the problem with a build made from the latest "development" source. I claimed that it will also happen on 1.7.0c. I will test it again with 1.7.0c, just to be sure.

The problem presents in Stress and Strain. Towards the end.
I'll create a way to skip to it and upload it when I got to a computer later. Its near the end after entering the holding cell (basement)

I think there are two problems here.  One is a saving issue that @redwolf2 has addressed, but there may be another issue if existing scenarios are not working correctly, which I have not got to the bottom of.

I have addressed the issue for saving scenarios, but it is possible that existing scenarios have bad entries which makes parsing a problem.  It may be that these can't be fixed automatically (requiring scenario edit), but if specific examples are shown I will investigate.

I am still having the same issue:

This is in the official "Stress and Strain" that you can download from the scenario's section. Just select the explore tokens until you get to the plaza, then kill the riot and enter the Sheriff's office to the north. The right hand explore token is blank, and then the search tokens in the room have the "xxx.button1" text.
This was saved in 1.6.1, loading it in 1.7.0d seems to delete a chunk of text from various events.
Here are the events for comparison:
1.6.1

Haha thats odd, importing content with the updated Official app now changes up all the icon images in 1.6.1.
1.7.0d

A scenario I created in 1.7.0b seems fine, I don't see any of the "xxx.button1" errors.
This is going to be a problem for people trying to maintain scenarios created in 1.6.1 and prior.

I tested 1.7.0d and can confirm it is working

The scenario I created from scratch in 1.7.0b is working compeltely fine. It just seems to have problems with backwards compatibility to 1.6.1.
1.7.0b works completely fine with the scenario created in 1.6.1, but 1.7.0c - 1.7.0d seem to delete the text. Not sure why, but it has something to do with a change in 1.7.0c.
I suspect its just a subtle but in 1.6.1 that was presenting as working, but has broken with whatever changes happened in 1.7.0c.
Like making a web page - just because it test OK in IE, doesn't mean its not a bug ridden mess of code! ;D

Its not the end of the world, if its just an error in my scenario. I can load up a version in 1.6.1, find the events that are broken in 1.7.0d and copy the text over. It doesn't seem to break the event logic.
However this is all contingent on one of the pre-releases being promoted to the latest stable version.

If you can copy the text, that broke your scenario from the Localization.English.txt here. Then we can investigate. You can also post this scenario here for analysis.

Will do, will probably be tomorrow now.
Though it is in the download list, so you could copy it.
I'll dig out the localisation text if possible.

OK I think I know how to support existing text without change, but the more examples I can get of the fault the more likely I will get it right.

Here is an example of a problem I have found:

EventSheriffPersuadeFail_Tile15.text,As I said, I can't leave here. I have nothing else to offer you" he replies, you notice a slight look of guilt in his eye
EventSheriffPersuadeFail_Tile15.button1,Continue

The single quote will result in EventSheriffPersuadeFail_Tile15.text including the new line and all following text until it hits a line with an odd number of " characters.  In this case I can fix it by only doing this if a " character is used immediately after EventSheriffPersuadeFail_Tile15.text, but there may still be cases which start with a " and have an odd number which are not multi line.
Another option would be to ensure that when in multi line text, line must not have a , before the first space to detect run on into the next entry, but this is very hacky and likely to break ligitimate uses.
TL;DR: The more examples of the fault I can find, the better the solution.

Hi Bruce,
The leading " kept being removed which was a bug in 1.6.1. since then I stopped using quotes and went to italics for speak text.
If this is the cause I can amend the text. Can I do this directly in the localisation.english file?

Sure, you should be able to use quotes and newlines without issue going forward, but I would like to get 1.7 correctly loading existing scenarios, so that I don't break anything already out there.  If you are going to update in a way that doesn't work in 1.6 you should update the quest format to 9 (which means noone will be able to use it in 1.6).

I have a version 3 that is saved as version 9, I was just going to remove all " and replace speak text in .

so that I don't break anything already out there.

FFG did that with the latest Official App update, none of the icons are displaying correctly in 1.6.1, even in older scenario's #798

Yep, but when updating to 1.7 I would like all existing scenarios to work.

All cases I am aware of should be fixed for 2.0 release.

Hi @NPBruce , v2.0 of Valkyrie doubled down on these issues in my scenario. But I have fixed them all in the Localisation file. (I think!)
You (or was it @redwolf2 ?) were partly right about the quotation marks all over the place. It seems that every instance of a quotation mark "This is Dialogue from a person" seemed to add  additional quotation marks all over the place.
I used find and replace in the localisation file to change the "Speech" into Speech I also removed phantom solo quotation marks causing havoc.
The other part of the issue for me at least causing the buttons to not display and text to be missing was due to Events/Tokens and Spawns having the carriage returns before them translated to \n.
So instead of each event (etc) starting on a new line, multiple events shared the same line.
I also cleared these out using find and replace but here is an example:

I am not sure if this is of any help, just wanted to let you know if something similar crops up.

Can you please give any examples of text that added additional quotation marks?  And is this when playing, opening in the editor or saving?

To clarify, any text with " characters will now look like this in the data when saved:
foo "bar" thing -> "foo ""bar"" thing"
The whole thing will be in " and each actual quote will be doubled.  This allows quotes at the start and end ("""foo""bar"/"foo""bar""") without losing characters and is compatible with FFG newline entries:
"foo
bar"
You could use this format if you like, but resaving will turn this into "foo\nbar".
If the first character in the string is not ", then it will be left as-is and only a single line will be read.

I believe thats what it looked like.
I fired up the older version of the scenario (2.5) that was created in 1.6.1 and edited in 1.7.0b:
It works fine in 1.6.1 and 1.7.0b. But when I run it in 2.0 (or 1.7.0b and above) I get errors like this:

I've attached the scenario files, there is even more missing text in 2.0 than there was in 1.7.0b.
Here is the file:
StressAndStrainV2.5.zip

So instead of each event (etc) starting on a new line, multiple events shared the same line.

As for the \nEventName issue, I think I may have created that myself when I used find and replace to clear out the quotation marks. So that is probably a red herring.

That is actually text that I copied in way back and disappeared after I hit save.
It was the very first intro text before I had full decided on a town name!
I am not surprised it caused issues, I found it too and deleted it when I cleaned up the localisation file for v3.
The text was complete when I copied it in, but the save bug wiped half of it out... well since it was in the text it just hid it from the editor and scenario!

I have decided to close this rather than complicate the existing code.  I am not aware of existing scenarios that have this problem, and future scenarios should not be exposed to this problem.

Yeh I think its a bug in a previous version that has since been fixed (copy and paste) thats remained hidden for multiple versions and has just cropped up
Its not worth wasting time on, since no-one else has seen it and I have cleaned up the code in question.
Thanks for looking though @NPBruce !


Web-App: CodeSnippet styling issues

Description

[ ] CodeSnippet usage along with text in a paragraph is overlapping eachother

[ ] CodeSnippet is overflowing content in small sized screens

Steps to reproduce

Drop these contents into a test.mdx file in services/web-app/pages

Inline styles Inline styles in the form of string: `style="padding-top: 20px; color: red"` instead
  of javascript objects: `style={{paddingTop: '20px', color: 'red'}}` will result in a Component not
  rendering error.

Navigate to http://localhost/test
Make screen size width 320

Note: you can also reproduce this in a *.js file:
  <div>
              Inline styles in the form of string:{' '}
              <CodeSnippet type="inline">{'style="padding-top: 20px; color: red"'}</CodeSnippet>{' '}
              instead of javascript objects:
              <CodeSnippet type="inline">
                {"style={{ paddingTop: '20px', color: 'red' }}"}
              </CodeSnippet>{' '}
              will result in a Component not rendering error.
    </div>

made estimate 3 since added new discovery

Agreed, wondering if thats why we hand-coded this over in Gatsby 😅

reopening, this hasn't been fixed


formidable vs muddler

Hey, great package I got it working pretty quick!
One use case I think was missed is stream files directly to S3 Buckets without ever writing to the disk.
I've noticed it uses  formidable which saves it to the disk without an option to hold it in memory but on the @danielbuechele’s Medium article he uses multer which has options for saving to the DiskStorage or MemoryStorage, was there a reason to choose formidable over multer as I see a big lost in flexibility?

I tried out about 4 options in the early days of this project. It's been a while since I made the choice, but there are a couple of reasons. Firstly, memory storage is not really desirable because you can easily use up all the available memory on the server. Then it really comes down to a choice of quality, ease-of-use and popularity/support:

For quality, I found comparative benchmarks (can't find them again now) that suggested formidable had great performance.
All the major options are suffering maintenance backlog, but formidable has a much more elegant codebase (zero dependencies) than multer (8 dependencies, including busboy). I tried using busyboy on it's own, but that got overly complicated.
For ease of use, formidable was by far the simplest and cleanest to use for our purposes.
Regarding popularity, formidable is dominant with 243k daily installs vs 75k for multer.

I have been pretty happy with the choice so far.
I am working with the Apollo team to look at bringing upload functionality into the official GraphQL servers, so there is an opportunity to improve a few things. For a while I have wanted to pass file streams into resolvers, but in experimentation it was challenging to engineer. If it turns out to be possible, developers could do whatever they want with uploads in the resolver and it could be an amazing performance boon for passing files through to cloud storage.
Keep in mind that uploads need to be inspectable for validation purposes in the resolver before permanent cloud storage happens, ruling out a configurable cloud upload process in apollo-upload-server. My vision is for there to be no Apollo client and GraphQL server uploads config, it just works; developers can decide what to do with uploads in the resolver.
Feel free to discuss further, we can reopen if something actionable comes up.

Thanks for getting back to me @jaydenseric, passing streams to resolvers sounds promising and solves both issues. What challenges did you have trying to pass streams to resolver?
It's gonna be awesome once this library become part of apollo 🤙

By the time you have parsed the full list of files to pass into the resolvers, the upload has virtually finished anyway

I've tried couple approaches first with koa-multer to work with the memoryStorage. I'm only dealing with avatar pictures but you're probably right bigger files can start to take a lot of memory. I guess this is what you mean by blocking the graphlQL server and resolvers the middleware is holding while it parses and read files before progressing and by the time it reaches the resolver it has already handle the upload.
import multer from "koa-multer";

app.use(multer({
    storage: multer.memoryStorage(),
}).any())

export function processRequest(request, options) {
  // Parse the multipart form request

  const { body, files } = request

  // Decode the GraphQL operation(s). This is an array if batching is
  // enabled.
  const operations = JSON.parse(body.operations)

  // Check if files were uploaded
  if (files.length) {
    // File field names contain the original path to the File object in the
    // GraphQL operation input variables. Relevent data for each uploaded
    // file now gets placed back in the variables.
    const operationsPath = objectPath(operations)

    files.forEach((file) => {
      const {
        originalname: name,
        mimetype: type,
        size,
        fieldname,
        buffer
      } = file

      operationsPath.set(fieldname, { name, type, size, buffer })
    })
  }

  return operations;
}

Second approached with busboy, my knowledge of streams is not great so I'm not sure how performant this is but it works, also not the prettiest code. It does the minimal work on the multipart form to structure the variables and skips reading the stream letting the resolver do it if they which to, a downside is you don't know how big the file is, but maybe that can be uploaded from the front end?
export async function busboyPromise(ctx) {
  return new Promise(function(resolve, reject) {
    const results = {
      fields: [],
      files: []
    }

    const busboy = new Busboy({ headers: ctx.req.headers });

    busboy.on('file', function(fieldname, stream, filename, encoding, mimetype) {
      // ReadStream
      results.files.push({
        filename,
        mimetype,
        encoding,
        fieldname,
        stream
      })

      stream.resume();
      // file.on('data', function(data) {
      //   // buffer
      // });
      // file.on('end', function() {
      // });
    });
    busboy.on('field', function(fieldname, val, fieldnameTruncated, valTruncated, encoding, mimetype) {
      results.fields[fieldname] = val
    });
    busboy.on('finish', function() {
      resolve(results)
    });

    ctx.req.pipe(busboy);
  });
}

export async function processRequest(ctx, options) {
  // Parse the multipart form request
  const { fields, files } = await busboyPromise(ctx)

  // Place on request for futher info
  ctx.req.files = files

  // Decode the GraphQL operation(s). This is an array if batching is
  // enabled.
  const operations = JSON.parse(fields.operations)

  // Check if files were uploaded
  if (files.length) {
    // File field names contain the original path to the File object in the
    // GraphQL operation input variables. Relevent data for each uploaded
    // file now gets placed back in the variables.
    const operationsPath = objectPath(operations)

    files.forEach((file) => {
      const {
        filename: name,
        mimetype: type,
        // you don't get size until you read the stream
        // but it could be transfered from the client mutation
        // size,
        fieldname,
        stream
      } = file

      operationsPath.set(fieldname, { name, type, stream })
    })
  }

  return operations
}

export default {
  type: new GraphQLNonNull(GraphQLString),
  args: {
    avatar: { type: UploadInput }
  },
  resolve(root, { avatar }, ctx, info) {
    console.log(avatar)

    avatar.stream.pipe(fs.createWriteStream(path.resolve(__dirname, avatar.name)))

    return `New avatar saved`;
  }
};


Customised landing page

URL to the linked Repo/Org:
N/A
Steps to reproduce the problem:

Setup your own instance of CLA assistant
Go to landing page

What is the expected result?
See a custom landing page with branding that matches the owner of the instance
What happens instead?
See the default SAP CLA page.
Optional
Currently the default installation of CLA on your own instance will show you the default CLA landing page similar to https://cla-assistant.io/
This is inconsistent with some companies requiring domains to match corporate branding guidelines.
Currently there seems to be no way to change this.
Please add a way to customise the landing page.

Thank you for your proposal. Some companies, which set up an own instance of CLA assistant have changed the html and css in order to match their branding. I can hardly imagine how we could make it customisable, but you are very welcome to create a PR


Sorry, there's a problem with nodist. Couldn't resolve npm version spec 4.4.3 : tching version

Hi, I am getting this error.
Sorry, there's a problem with nodist. Couldn't resolve npm version spec 4.4.3 :
tching version
Can someone please tell me how to get it working?

I changed the npm version to 3.9.6 and it worked


example: parent-child communication with events

It's somewhat complex of an example but it keeps coming up in the chat "How can I get the parent or child component to talk to each other?"
It shows interactions with events, on-*, and lets the user move the items up and down in the preview.

Related documentation on events https://github.com/marko-js/marko/pull/657

Thanks for the example!


LongPress gesture cancellation

On Android, when a long press is activated, and the user then pans away (without lifting the gesture) the LongPressGestureHandler enters a cancelled state.
in iOS the gesture does not cancel and continues to fire gesture events until the gesture is released by lifting the finger.
This comment seems to suggest that the iOS behavior is intended and that android has a bug: https://github.com/kmagiera/react-native-gesture-handler/issues/94#issuecomment-355750006
The bug prevents (afaict) the feature I am working on from being possible in RNGH: activate a chart scrubber upon long press.

I'm affected by this bug as well.
Did you find any workaround @rt2zz?

I have not, I suspect this could be achieved with PanGestureHandler with simultaneous handlers setup, but there were some implementation challenges I ran into and am not sure what a solution would look like.


feat(onboarding): suggested connection params

Add buttons on the custom connection settings screen to allow suggested connection values to be automatically populated in the form fields. This will set the connection params to those most relevant to the user's current environment.
initial form as a new user sees it:

hover over the 'use suggested values' link:

first field populated with suggested value:

all fields populated wiuth suggested values:

Pull Request Test Coverage Report for Build 1190

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 63.636%

Totals

Change from base Build 1177:
0.0%

Covered Lines:
5

Relevant Lines:
7

💛  - Coveralls


Updated to match (emerging) CFPB PyPI guidance.

https://github.com/chosak/development/blob/e2a8eb7582eed6d104c24c4884f46bc8fd48024e/pypi.md

I couldn't add @chosak as a reviewer, for some reason.

:+1: Thanks for doing this. That PR has now been merged -- one minor change is that we are recommending using the trove classifiers to specify the license instead of specifying in setup.py like you do here. It's a minor thing, besides that this is great!

Thanks, will update

@chosak I've made that change


Add nodejs generation for Operational Insights

This checklist is used to make sure that common issues in a pull request are addressed. This will expedite the process of getting your pull request merged and avoid extra work on your part to fix issues discovered during the review process.
PR information

[x] The title of the PR is clear and informative.
[x] There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For information on cleaning up the commits in your pull request, see this page.
[x] Except for special cases involving multiple contributors, the PR is started from a fork of the main repository, not a branch.
[x] If applicable, the PR references the bug/issue that it fixes.
[x] Swagger files are correctly named (e.g. the api-version in the path should match the api-version in the spec).

Quality of Swagger

[x] I have read the contribution guidelines.
[x] My spec meets the review criteria:

[x] The spec conforms to the Swagger 2.0 specification.
[x] The spec follows the guidelines described in the Swagger checklist document.
[x] Validation tools were run on swagger spec(s) and have all been fixed in this PR.

Automation for azure-libraries-for-java

Automation for azure-sdk-for-node

Automation for azure-sdk-for-python

Automation for azure-sdk-for-go

Automation for azure-sdk-for-ruby

@amarzavery Are you ok with this change? This is related to NodeJS SDK

For context, this is related to PR 3008 and 3012  in the Node SDK, which add the relevant functionality. Should have provided some explanation 😊

CI is fixed

@amarzavery pulling this out to the top level since I just squashed that comment but see https://github.com/Azure/azure-sdk-for-node/pull/3008
@RikkiGibson for context.


Add test helpers

@brendt Not sure if you have any input here. I am somewhat following Laravel's syntax for testing for now (there may be some things we change along the way).
A few things that I am running into:

We do not currently have a way to set priority for an initializer, right? What's the best way to override a default implementation?
Due to the application self-processing the request, we basically cut it out entirely in the test helper. Not sure if we are just fine with that or if you have other thoughts here.

Pull Request Test Coverage Report for Build<PHONE_NUMBER>
Details

-27 of 147 (81.63%)  changed or added relevant lines in 10 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage increased (+0.04%) to 83.123%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

src/Http/GenericResponseSender.php
10
11
90.91%

src/Testing/Http/TestResponseSenderInitializer.php
0
4
0.0%

src/Testing/Http/TestsHttpRequests.php
14
21
66.67%

src/Testing/Http/TestResponse.php
13
28
46.43%

Totals

Change from base Build<PHONE_NUMBER>:
0.04%

Covered Lines:
1384

Relevant Lines:
1665

💛  - Coveralls

I think you need to rebase, since this branch contains the ResponseSender changes?

We do not currently have a way to set priority for an initializer, right? What's the best way to override a default implementation?

What I've been doing is manually registering singletons in test cases, those get priority. Apart from that, we currently don't have anything else.

Due to the application self-processing the request, we basically cut it out entirely in the test helper. Not sure if we are just fine with that or if you have other thoughts here.

Could you elaborate about what we're cutting out exactly?

What I've been doing is manually registering singletons in test cases, those get priority. Apart from that, we currently don't have anything else.

This is probably something worth exploring a bit. It might be enough to put the default initializers at the end of the array, or have them configurable.

Could you elaborate about what we're cutting out exactly?

Instead of calling HttpApplication::run we have to build it up manually like so:
        // Register our test request in the container.
        $this->container->singleton(Request::class, fn () => $request);
        $this->container->singleton(ResponseSender::class, fn () => new TestResponseSender());

        $router = $this->container->get(Router::class);
        $responseSender = $this->container->get(ResponseSender::class);

        return $responseSender->send(
            $router->dispatch($request)
        );

This is because we have to override the request and response sender, and then get the returned response. Maybe it's okay, just need to keep it in mind.

I'd add a request helper method in the bast TestCase that does this setup for you. The only thing you'd need to pass in is the request object itself, and this method would do the rest, and return a response.

I'm guessing you haven't looked at my PR. 🙃

Overall, I like it! It's good that we're moving stuff into src/Testing so that packages and users can make use of it 💯

I'm going to merge this one, since I need these features 😅 we can always improve on it later.

I mean, it was just a draft, but okay. 😂
I'll put some work on adding to the helpers this week.

pre-1.0, everything's possible 😁

I'll have to see what other half-baked features I can come up with. 😉


Fixes a bug with [] as a filter expression

cc @mvilanova -- Do you remember why the [0] list access was added (here's the pr #2052) ? I'm not familiar with the filter code at all and want to make sure nothing breaks here.

cc @mvilanova -- Do you remember why the [0] list access was added (here's the pr #2052) ? I'm not familiar with the filter code at all and want to make sure nothing breaks here.

I don't remember OTOMH. It's been a while since I cut that PR. I'll take a look today.


Bonjour services

UFW blocks bonjour services , you may like to accept data on <IP_ADDRESS>?

What would be the benefit to open the bonjour services?

What would be the benefit to open the bonjour services?

The benefit is a empty log! I have been having trouble with RTL and LIT and my iPad fills the log with bonjour requests!

I am not familiar with UFW but I have bypassed UFW on port 3000 for RTL and RTL no longer hangs like it was doing! Even though port 3000 was open in UFW according to the logs it was still blocking and the hanging seemed to relate to log updates?


[devops:bot] update deps in nix/sources.json (from: rhino-core@4b507c5)

update nix refernces for rhino-core and|or nixpkgs to match https://github.com/rhinofi/rhino-core/blob/4b507c58c6a3b49c27888ceb25100a5347fbc119/nix/sources.json (branch: dev)

superseded by #176


Remove seatsAdminUi nav items

Removes nav menu items for seatsAdminUi in prod preview, prod stable, stage preview, and stage stable, as it's been deprecated in favor of the new Admin Dashboard.

The fed-modules.json is a good point- we have a separate work item to decomission that, but that creates a dependency where this needs to go in first, or it'll leave a dead link. If it gets deployed pretty quickly, that's not a big deal, but it might simplify things for everyone if we do them together.


publish command error caused by Storybook params

Trying to publish a sample component and I’m getting the following error for multiple components (not the component I’m trying to publish, but colocated components in the parent directory:
Error parsing story /Users/ramy/GitHub/metal-design-system/packages/component-library/src/components/Banner/Banner.stories.tsx: ParserError: "url" property not found in "design" object in story metadata
 -> /Users/ramy/GitHub/metal-design-system/packages/component-library/src/components/Banner/Banner.stories.tsx:154:11

The url prop is present and filled in the story file, but it’s pointing to an object in a different file, like so (we keep all the links in one place for Storybook for easier updating):
export default {
  component: Banner,
  decorators: [colorModeDecorator(), paddingDecorator()],
  parameters: {
    chromatic: { viewports: chromaticViewportParameters() },
    design: {
      type: "figma",
      url: FigmaLinks.web.v1.Banner,
    },
  },
};

Guessing this is some kind of conflict with the design add-on?
It’s also unclear to me why it’s trying to do anything with those files since I don’t have a .figma.tsx file for those. I’m only trying to publish one component but it’s returning this error for many unrelated components.
Happy to provide more details here!

Thanks for reaching out. The storybook parser checks for any usage of `design.url in story files, but, unfortunately, we only parse strings for the url field at the moment.


Fix RCLC int parameter get

Related: https://answers.ros.org/question/397640/why-ros2-rclc_parameter_set_int-has-value-parameter-as-int64_t-while-rclc_parameter_get_int-has-the-same-parameter-as-int-type/

@mergify backport main foxy

Codecov Report

Merging #268 (1816bb1) into galactic (d5ca470) will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##           galactic     #268   +/-   ##
=========================================
  Coverage     62.24%   62.24%
=========================================
  Files            13       13
  Lines          1523     1523
  Branches        446      446
=========================================
  Hits            948      948
  Misses          367      367
  Partials        208      208

Impacted Files
Coverage Δ

...lc_parameter/src/rclc_parameter/parameter_server.c
72.47% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d5ca470...1816bb1. Read the comment docs.


make site command removes markdown templates from docs

Running make site deletes the template markdown files from the docs directory.
This wouldn't be a problem if the markdown was fully generated, but in this project it contains templated calls to read from the data.
The site command has a target of all-data and calls mkdocs build. Running mkdocs build on its own doesn't appear to delete anything.

Can't replicate this. May have just been a branch merging issue.


Object reference not set to an instance of an object at Game.Player.SetHealth

Steps to Reproduce

Open editor through vscode
Switch to Game.tscn
Notice the error
Notice how the error only appears once
Notice the error re-appears when making edits to any files (e.g. adding a empty comment "//")

Error does not seem to effect the games performance in any way.
Unhandled Exception:
System.NullReferenceException: Object reference not set to an instance of an object
  at Game.Player.SetHealth (System.Int32 v) [0x00006] in <1aeff72bdfc643c9b42cf132bca28ac4>:0
  at Game.Player..ctor () [0x0001b] in <1aeff72bdfc643c9b42cf132bca28ac4>:0
ERROR: System.NullReferenceException: Object reference not set to an instance of an object
   at: debug_send_unhandled_exception_error (modules/mono/mono_gd/gd_mono_utils.cpp:369)

nvm I understand now.
This should really be

this


Write milestone 1 report

@SWE574-Fall2023-Group1/all We need to write the first milestone report and upload it to our repo as an .md file. Instructions are available on the wiki under "Documents". I created an .md file on HackMD, I'll invite everyone and we can write it online collaboratively. Will share link on WhatsApp and Discord. Let me know if you have other suggestions.
Due Date:
Pre-release of the software (30.10.2023, 17:00), other deliverables (02.11.2023,17:00).

Please sign up to HackMD and send me your user information on WhatsApp or Discord so I can invite everyone.

Integrated HackMD to our repo. Now the report can be pushed/pulled directly instead of manual uploads. Let's do it this way, no need to edit the report manually on the repo.

@dbaslan Let's integrate HackMD with reports branch.
https://github.com/SWE574-Fall2023-Group1/SWE574-Fall2023-G1/tree/reports

The report is now integrated with the reports branch, and everyone has been invited to write as of yesterday. Let's get this bread folks!

I filled up the hack.md file for my part. Good work everyone.

The report is almost finished. I wrote the milestone review, deliverables and addressed requirements. Please read over them to add anything missing or fix mistakes.

@dbaslan hi,
I've completed my individual-contributions part.
Could you please push the file from HackMD to GitHub?
Thanks in advance 🙏🏼

@dbaslan hi again,
Responsibility Assignment Matrix link has an empty wiki page result.
Could you please edit that page?
Thanks.
https://github.com/SWE574-Fall2023-Group1/SWE574-Fall2023-G1/wiki/Responsiblities

Thanks everyone @SWE574-Fall2023-Group1/all ✨ 👏🏼
https://github.com/SWE574-Fall2023-Group1/SWE574-Fall2023-G1/blob/main/reports/m1_group1.md


deployment-template: Adds a new --template-format flag to command

Description
This patch adds a new --template-format flag to the ecctl platform deployment-template {list | show | pull} commands.
This flag will allow users to specify which inofrmation is populated in the response.
If "cluster" is specified, cluster_template is populated in the response. If deployment is specified, deployment_template is populated in the response.
Requires https://github.com/elastic/cloud-sdk-go/pull/162 to be merged
Related Issues
Related https://github.com/elastic/cloud-sdk-go/issues/159
How Has This Been Tested?
manually by running the commands
Types of Changes

[x] New feature (non-breaking change which adds functionality)

Readiness Checklist

[x] My code follows the code style of this project
[x] My change requires a change to the documentation
[x] I have updated the documentation accordingly
[ ] I have added tests to cover my changes
[x] All new and existing tests passed

Thanks @nrichers  for the comments, I've updated the text :) And thanks @marclop for fixing that bug!


Outputting optimal backend shaders

Is there a way for Slang to do an optimization pass on the IR and/or backend shaders? We find that it's hard to rely on driver compilers to optimize shaders well, and there is a lot of storage size and compilation time to be gained anyway from bake time optimization (a lot of opportunities on reducing size depending on how much obfuscation is acceptable - ex: shorten identifier names in text based languages - should probably be tunable with settings).
In our current SPIRV-Cross-based toolchain we run spriv-opt to achieve this. Not so easy with Slang.
Another thing we find indispensable is to freeze the values of known specialization constants at bake time. Essentially just convert spec consts to literal consts when the values are known, while leaving unknown spec consts as spec consts. This removes a lot of dead code. For similar reasons as above: to save storage, driver compile time, and even GPU performance in the case of weak driver compilers. I guess this one is doable by text editing the frontend slang source, but a first class feature would be cleaner.

Slang already runs spirv-opt today as a part of the SPIRV generation process if you specify an optimization level that is greater than None. Do you find this to be not sufficient?

We need something similar for all backends. And the second request is still a bit of work.

Thank you for filing this issue. This is worth resolving, but we don’t have current available bandwidth – moving to the backlog for now. Please do feel welcome to propose a solution if you’re able to before it makes it out of the backlog!


Recent products/Favourite products

Users have products they buy more often than others. Having an endpoint where users can see their recent/most bought products would make the flow of Magnificent Sloth a lot better.

@Mstiekema can you include this issue in your new Magnificent Sloth implementation, at some point?


Obj does not map the textures correctly

Given result:

Expected result:

You can test it here: https://sandbox.babylonjs.com/
Test asset: crate.zip (https://free3d.com/3d-model/crate-86737.html)
PS: Is there a way to upload files to the PG so I can create a PG repro?

You can share your file on GitHub and then use rawgit.com to get a CORS compatible link
Also How about this? https://www.babylonjs-playground.com/#8INCIV#27
Duplicate of #4627


Homepage crashes Firefox

The homepage seems to make Firefox crash, giving the "A webpage is slowing your browser down" error message

I think there are some performance issues that can result in responsive layout (especially on the height) for specific cloud layouts.  I updated the home page to use a fixed height layout and reduced the interval.  I don't think these are the real underlying reasons for the issue though, but hope it helps.  Thanks for reporting and let me know if the issue still persists or if you are able to isolate the root cause!

The issue is that D3/wordcloud triggers a data access request for HTML5 canvas image data, seen when  privacy.resistFingerprinting in Firefox is enabled (may come up in other circumstances by default now too).  The wordcloud code needs to read data in order to position words on the canvas. In your screenshot @eeue56, there's an icon on the address bar for this, the picture icon:

Clicking the icon and then clicking 'Allow Data Access' will mean this code can successfully place words and you should see your word clouds start rendering okay.
The 'web page slowing down your browser' warning is because the homepage keeps re-rendering the cloud, thus continually trying to recompute where words are being placed each time.  Being unable to read the canvas data means words can't be placed and so on, stacking more and more rendered every time the timer runs: https://github.com/chrisrzhou/react-wordcloud/blob/main/docs/hero.tsx#L23-L26
So perhaps @chrisrzhou the homagepage could more gracefully handle this situation of having no permission on the homepage (e.g. don't keep trying to re-render if the first one failed or if a test access to canvas data isn't [yet] allowed).
The line of code being blocked from accessing canvas data is https://github.com/chrisrzhou/react-wordcloud/blob/main/src/optimized-d3-cloud.js#L130 though I imagine all similar lines accessing canvas data would cause the same issue if reached.  I haven't gone and tested how Firefox handles failed access, whether it throws an exception that can be caught etc, but if it does, then the code in optimized-d3-cloud.js could handle it and gracefully abort continually trying to place words.  The code does eventually give up after MAX_LAYOUT_ATTEMPTS, but it could be caught on the first failure to access canvas data.

@davidjb, just confirmed the issue by setting privacy.resistFingerprinting to true in Firefox.  This affects all wordcloud instances, not just the homepage as you mentioned.  Should the check be handled within the library or should we ask users to handle this on their end?  If the latter is a better design choice for the library, then I can probably just update the documentation site to handle this.
I'm not sure how other canvas-based libraries will approach this problem (if they will handle this internally or have users deal with the problem).

Did a bit of digging and the issue is accessing canvas data in general and isn't isolated in just optimized-d3-cloud.  The source code of d3-cloud will also affect this.
My rough plan is to:

Handle the homepage and doc exampels more gracefully (after some retries, I'll render a info message to ask users to grant allow data access for canvas data).
Make a mention in faq.mdx about this bug.

I need to find out how to obtain this event in a general way since it maybe browser specific.  If anyone has ideas or knowledge in this area, please let me know!

Found a solution to do this that is compatible on most browsers: https://github.com/chrisrzhou/react-wordcloud/blob/main/docs/react-wordcloud.tsx#L12-L15
Since the docs use a wrapped version of the source code, this was a good entry point to update it and warn the users.  The slight drawback is it won't trigger the image icon in the URL bar as a shortcut to change the browser configuration, but we'll going to offload that responsibility for users in their custom browsers to address.
Added an FAQ about it since this question was raised here and I expect more people to come across it:
https://github.com/chrisrzhou/react-wordcloud/blob/main/docs/faq.mdx#browser-based
Thanks @davidjb for digging into it, and let me know if this solution works.  I don't think adding logic to the source code makes sense since that is accounting for user/browser configuration.

@chrisrzhou Nice workaround with the performance API.  I was wondering that if you were to trigger the canvas access warning from this code with a very basic trigger, then you'd get the best of both worlds -- the visual
 tag is a helpful indicator to the user and then the image icon will prompt and facilitate the user allowing access whilst avoiding a browser crash.

I'm running into an issue with docz where it's not rendering any of the code or Playground preview.

---
name: Basic
menu: Usage
route: /usage/basic
---

import { Playground } from 'docz';

# Basic Example

<Playground>

this should render

</Playground>

Not sure what's changed and clean installs and builds don't seem to help.  Debugging a little further.  docz has been recently frustrating with a couple of these 'magical' bugs/behaviors.


Error list are not cleared after success build.

Maybe because they was multiline?

This is weird. I can't reproduce this issue... What kind of error is not cleared ? Does this problem appear with every project ?

I will sent an example when i get it again


fix: do not set namespace in rolebindings

We cannot dynamically set namespaces within app-sre/interface, hence
try to remove them from the rolebinding completely and just let
k8s deploy it into the correct namespace
Fixes: OSD-11954

/lgtm


Compilation test pickle failed with RDKit 2018.09.1

after adding in compiler.js
'libRDKitDepictor.so',
'libRDKitcoordgenlib.so',
'libRDKitmaeparser.so',
and changing deps to 2018.09.1 there is an issue with pickle testcase:
FAIL  tests/rdchem/pickle.js
● Console
console.log __tests__/rdchem/pickle.js:10
  mol from Smiles
console.log __tests__/rdchem/pickle.js:12
  toPickle
console.log __tests__/rdchem/pickle.js:15
  type of toPickle
console.log lib/Mol.js:52
  fromPickle
console.log lib/Mol.js:53

● from and to pickle
Error
  6070248 thrown

Add branch v2018_9_1


Error, when try to open AI on mac in CE from early access plugin

Description

On Mac in DBeaver CE install AI from link https://dbeaver.io/files/ea/update/ce/
After restart open SQL script - press AI btn -see error

DBeaver Version
23.2.4
Operating System
mac M1 monterey 12
Database and driver
No response
Steps to reproduce
No response
Additional context
No response

Quite possibly happens due to using EE workspace, which had Azure AI configured, we probably want to change to default in that case


Update NeoNftCard.vue

Thank you for your contribution to the KodaDot - One Stop Shop for Polkadot NFTs.
👇 __ Let's make a quick check before the contribution.
PR Type

[x] Bugfix
[ ] Feature
[ ] Refactoring

Context

Did your issue had any of the "$" label on it?

[x] My DOT address: Payout

Copilot Summary

🤖 Generated by Copilot at 5abc160
Made showActionOnHover prop optional for NeoNftCard component to enable different use cases.

🤖 Generated by Copilot at 5abc160

showActionOnHover
Optional prop for the card
Winter of actions

I did. Very annoying.
I spent a bit of time trying to figure out the source but failed and moved on

I did. Very annoying. I spent a bit of time trying to figure out the source but failed and moved on


cp2k 8.1

reset build number
remove sopt symlink (only OpenMP versions for cp2k 8.1)
remove regtest patch (incorporated in cp2k source code)

Checklist

[x] Used a personal fork of the feedstock to propose changes
[ ] Bumped the build number (if the version is unchanged)
[x] Reset the build number to 0 (if the version changed)
[x] Re-rendered with the latest conda-smithy (Use the phrase @conda-forge-admin, please rerender in a comment in this PR for automated rerendering)
[x] Ensured the license file is being packaged.

Hi! This is the friendly automated conda-forge-linting service.
I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

@conda-forge-admin , please rerender

@dev-zero @oschuett
For some reason cp2k 8.1 is ignoring the FC environment variable on the serial builds and tries to use mpif90 instead (that isn't installed), see here.
It only works if I set the FC variable in the archfile explicitly (which I don't want to do, since the compiler path/name may change as conda environments evolve).
Any ideas why this happens?
The archfiles without explicit FC worked fine with cp2k 7.1

My guess is that this is due to the explicit assignment of several variables in DBCSRs Makefile which gets included by CP2K:
https://github.com/cp2k/dbcsr/blob/master/.cp2k/Makefile
Explicit assignment overrides the value of variables imported from the environment.
On 14 April 2021 10:10:32 CEST, Leopold Talirz @.> wrote:
@. @oschuett

For some reason cp2k 8.1 is ignoring the FC environment variable on
the serial builds and tries to use mpif90 instead (that isn't
installed), see
here.
It only works if I set the FC variable in the archfile explicitly
(which I don't want to do, since the compiler path/name may change as
conda environments evolve).
Any ideas why this happens?
The archfiles without explicit FC worked fine with cp2k 7.1
--
You are receiving this because you were mentioned.
Reply to this email directly or view it on GitHub:
https://github.com/conda-forge/cp2k-feedstock/pull/23#issuecomment-819323100

Thanks @dev-zero , looks to me like you're right - these defaults were added 13 months ago https://github.com/cp2k/dbcsr/blame/master/.cp2k/Makefile
I guess we should open an issue for this. should this go to cp2k or dbscr?

@ltalirz to DBCSR since it should be fixed there (either by removing them or replacing them with ?=). Thanks!

@oschuett
On the OSX build I'm running into errors related to the usage of clock_gettime and the undeclared CLOCK_PROCESS_CPUTIME_ID symbol:
x86_64-apple-darwin13.4.0-clang -c -march=core2 -mtune=haswell -mssse3 -ftree-vectorize -fPIC -fPIE -fstack-protector-strong -O2 -pipe -isystem $PREFIX/include -fdebug-prefix-map=$SRC_DIR=/usr/local/src/conda/cp2k-8.1.0 -fdebug-prefix-map=$PREFIX=/usr/local/src/conda-prefix -fopenmp -std=gnu99 -fopenmp -std=gnu99 $SRC_DIR/src/grid/grid_replay.c
/Users/runner/miniforge3/conda-bld/cp2k_1618390734638/work/src/grid/grid_replay.c:345:5: warning: implicit declaration of function 'clock_gettime' is invalid in C99 [-Wimplicit-function-declaration]

    clock_gettime(CLOCK_PROCESS_CPUTIME_ID, &start_time);
    ^
/Users/runner/miniforge3/conda-bld/cp2k_1618390734638/work/src/grid/grid_replay.c:345:19: error: use of undeclared identifier 'CLOCK_PROCESS_CPUTIME_ID'
    clock_gettime(CLOCK_PROCESS_CPUTIME_ID, &start_time);
                  ^
/Users/runner/miniforge3/conda-bld/cp2k_1618390734638/work/src/grid/grid_replay.c:371:19: error: use of undeclared identifier 'CLOCK_PROCESS_CPUTIME_ID'
    clock_gettime(CLOCK_PROCESS_CPUTIME_ID, &end_time);
                  ^
/Users/runner/miniforge3/conda-bld/cp2k_1618390734638/work/src/grid/grid_replay.c:378:5: warning: implicit declaration of function 'clock_gettime' is invalid in C99 [-Wimplicit-function-declaration]
    clock_gettime(CLOCK_PROCESS_CPUTIME_ID, &start_time);
    ^
/Users/runner/miniforge3/conda-bld/cp2k_1618390734638/work/src/grid/grid_replay.c:378:19: error: use of undeclared identifier 'CLOCK_PROCESS_CPUTIME_ID'
    clock_gettime(CLOCK_PROCESS_CPUTIME_ID, &start_time);
                  ^
/Users/runner/miniforge3/conda-bld/cp2k_1618390734638/work/src/grid/grid_replay.c:406:19: error: use of undeclared identifier 'CLOCK_PROCESS_CPUTIME_ID'
    clock_gettime(CLOCK_PROCESS_CPUTIME_ID, &end_time)

As you can see from the compilation line I've already added -std=gnu99, which I thought might solve this but apparently it didn't.
I'm a little confused as the Darwin archfiles for cp2k added by @fxcoudert seem to work fine but I guess that's because they are using gfortran rather than clang (?). Is this some difference between clang's std=gnu99 and gfortran's std=gnu99?
P.S. For reference, the relevant lines in the archfile are
FC          = x86_64-apple-darwin13.4.0-gfortran
CPP         = $(CC)-cpp
CPPFLAGS   += -C -P -traditional -D__NO_IPI_DRIVER -nostdinc
# default -std=c99 complains about missing declaration of clock_gettime
CFLAGS     += -fopenmp -std=gnu99

For reference, the linux builds run through fine, including the regtests
linux ssmp
Number of FAILED  tests 0
Number of WRONG   tests 0
Number of CORRECT tests 2849
Total number of   tests 2849

linux psmp
Number of FAILED  tests 0
Number of WRONG   tests 0
Number of CORRECT tests 2900
Total number of   tests 2900

You should not have to use gnu99, but rather c11.

also, I was able to build CP2K with clang on a recent OSX, so it should work in principle, but not necessarily v8.1 since there we still had some issues with memalign.

stackoverflow says Sierra, so darwin-13 should have it.

sorry, no idea what else it could be atm

@ltalirz, AFAIK the clock_gettime routine is part of the POSIX standard. However, for gclib I had to set the _XOPEN_SOURCE macro to enable it. Maybe on OSX it has a different name?

Looking at the cpython configure source code, it seems to me like _XOPEN_SOURCE is disabled for all darwin kernels from 6.x onwards (can someone confirm that I'm reading this correctly?).
I believe we are running Darwin 19.6.0 here.
At the same time, they #define _DARWIN_C_SOURCE 1 in order to re-enable stuff that would be disabled by _XOPEN_SOURCE.
Not sure whether that is still needed if we remove the _XOPEN_SOURCE macro, but perhaps it won't hurt?

Ok, it seems one needs to tell conda that the target platform is OSX>=10.12 (which does make sense).
https://github.com/conda-forge/staged-recipes/pull/14079#issuecomment-789847082

I seems we could also use _POSIX_C_SOURCE instead. I'm not sure if this helps with OSX, but it certainly has a more self-explanatory name.

Hi! This is the friendly automated conda-forge-linting service.
I wanted to let you know that I linted all conda-recipes in your PR (recipe) and found some lint.
Here's what I've got...
For recipe:

Selectors are suggested to take a <two spaces>#<one space>[<expression>] form. See lines [51]

Hi! This is the friendly automated conda-forge-linting service.
I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

@conda-forge-admin , please rerender

@ltalirz and now it fails at the osx error we already know about and which was fixed (multiple times) in the meantime

@ltalirz and now it fails at the osx error we already know about and which was fixed (multiple times) in the meantime

Ok, you mean fixed in the cp2k source code?
What is the right approach here in your opinion:

Add a patch for it here
Exclude MacOS from the cp2k 8.1 conda package

Yes, fixed in CP2K.
Since the final fix is mixed up with with other changes in the grid code by now someone would have to backport it. So, exclude and wait for 8.2 (scheduled for End of April or Mid May).

@conda-forge-admin , please rerender

Note: https://github.com/conda-forge/cp2k-feedstock/pull/27 will need to be merged before this one.

linux ssmp
Number of FAILED  tests 0
Number of WRONG   tests 0
Number of CORRECT tests 2849
Total number of   tests 2849

linux psmp
Number of FAILED  tests 0
Number of WRONG   tests 1
Number of CORRECT tests 2899
Total number of   tests 2900

The one wrong test is
xxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxx
$SRC_DIR/regtesting/Linux-x86-64-conda/psmp/TEST-Linux-x86-64-conda-psmp-2021-04-14_16-41-00/QS/regtest-gpw-2-3/hcn_meta_chaincoord.inp.out :
 Total energy: : ref = -16.64019903493714 new = -16.64019903493535
 relative error :   1.07604945e-13 >  numerical tolerance = 1e-13
xxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxx

I'll have a look whether this tolerance is already adjusted - in any case, this seems acceptable.


Config::infer can return in-cluster config outside cluster with rustls feature

I think there is a problem with this code branch:
https://github.com/kube-rs/kube-rs/blob/master/kube/src/config/mod.rs#L94...L97
This takes us to:
https://github.com/kube-rs/kube-rs/blob/b7fe7485a5661bdec398377109801e675db8aaee/kube/src/config/incluster_config.rs#L22...L29
Where we always return an on-cluster URL even if we are not running on a cluster.
So the issue is, if I want to use a KUBECONFIG, off-cluster with Rustls, I never make it to the KUBECONFIG code branches.
One simple fix would be to check for the absence of KUBECONFIG at https://github.com/kube-rs/kube-rs/blob/master/kube/src/config/mod.rs#L94 but that might be a slightly different behavior than advertised in the documentation.

Ugh, I did a workaround but found that my kubeconfig file has the server address as https://<IP_ADDRESS>[...]. This was created by kind for local development. Anyway, when I workaround the problem described above to use my kubconfig file, Rustls still errors due to the "invalid dns name" https://github.com/rustls/hyper-rustls/issues/84

Closing as duplicate of #153. We keep track of rustls issues with a label https://github.com/kube-rs/kube-rs/labels/rustls

Where we always return an on-cluster URL even if we are not running on a cluster.

Well, this might be a new issue.

OK, but are you aware that the rustls workaround linked to in this issue prevents a KUBECONFIG from ever being used. So, if my KUBECONFIG specifies https://somekubernetes.com, the bug I've mention exists where the KUBECONFIG will never be read. In this case the rustls "invalid DNS" is not the problem.

Looks like it was overlooked because it should fall back to KUBECONFIG as long as the following files doesn't exist:

/var/run/secrets/kubernetes.io/serviceaccount/token
/var/run/secrets/kubernetes.io/serviceaccount/ca.crt
/var/run/secrets/kubernetes.io/serviceaccount/namespace

Failing to find these files should fall back to KUBECONFIG.

No I don't have those files outside of the cluster. Outside of the cluster I'm running on a mac. I think the check for rustls happens too early in the code... before the check for those files.
$ ls /var/run/secrets/kubernetes.io/
ls: /var/run/secrets/kubernetes.io/: No such file or directory

Hmm, then it should fall back to KUBECONFIG because from_cluster_env should fail without those files.
https://github.com/kube-rs/kube-rs/blob/b7fe7485a5661bdec398377109801e675db8aaee/kube/src/config/mod.rs#L70-L75
I'm assuming you're using Config::infer or Client::try_default which uses Config::infer.

Client::try_default correct.
from_cluster_env succeeds returning the hardcoded workaround url irrespective of whether we are in cluster or not:
https://github.com/kube-rs/kube-rs/blob/master/kube/src/config/mod.rs#L94...L97

You're correct about cluster_url, but it'll fail when reading those files just below.
https://github.com/kube-rs/kube-rs/blob/b7fe7485a5661bdec398377109801e675db8aaee/kube/src/config/mod.rs#L107-L115

Oh I see. This issue might be in error. I'll double check through my breakpoints again.

I think I was wrong about the failure mode. Perhaps it was getting my kubeconfig and failing because it had the server address <IP_ADDRESS>. Closing.


Userguide index page

This is currently just the ToC, but should probbaly have some introductory text.

Will be resolved by #75


Deleting a collection doesn't work for some reason

Description
client = typesense.Client({
  'nodes': [{
    'host': 'xxxx',
    'port': '8108',
    'protocol': 'http'
  }],
  'api_key': 'xxxxx',
  'connection_timeout_seconds': 2
})
index_name = "videos"
my_schema = {
  'name': index_name,
  'fields': [
    {'name': 'title', 'type': 'string' },
    {'name': 'domain', 'type': 'string' },
    {'name': 'url', 'type': 'string' },
 ]}
ret = client.collections.create(my_schema)

It appears to create the collection as I get an acknowledgment of the fields created by print (ret)
However when I try to delete the same collection, I get an error:
client.collections[index_name].delete()
error : unhashable type: 'dict'
I also cannot recreate the collection and get this error:
[Errno 409] Collection with name videosalready exists.
It appears the client.collections is an empty dict. How can I get it to load the list of collections? or am I missing something?
Typsense Version:
Latest version
OS:
Ubuntu 18

Oops . this was very simple oversight. I wasn't fetching the collection first. I was under the impression that constructing the typesense.Client(..) would connect. We need to connect specifically to the collection(s)
ts_client.collections[index_name].retrieve() or
ts_client.collections.retrieve()


Orthogonal initialization gives inaccurate result when running on GPU

When generating an orthogonal matrix using 'tf.keras.initializers.Orthogonal' and running on a GPU, if the matrix is of size larger than nxn for n of about 1000 the resulting matrix is not orthogonal. The deviations are several orders of magnitude larger than expected from finite precision errors.
The issue doesn't occur for smaller n (say of size 100) or when running on a CPU.
The issue occurred when using both a Telsa V100 and a Tesla K80, with Keras 2.2.2 and Tensorflow 1.10.1.
In the example below, the final result should be an identity matrix to within numerical precision error, but has deviations of order 1e-2 in the individual entries.
import tensorflow as tf
tf.enable_eager_execution()
tf.set_random_seed(0)
init = tf.keras.initializers.Orthogonal(1, seed=0)
a = init([1000,1000])
tf.matmul(a,tf.transpose(a))

This issue seems to be gone in tf 1.13.1 / keras 2.2.4-tf.


Linux arm64 and Darwin arm64 for RtMidiAccess

Currently we depend on atsushieno/rtmidi-jna to implement RtMidiAccess (which is the primary API for native desktop MidiAccess for ktmidi), but it cannot support Darwin arm64 (M1/M2) because the underlying jnaerator does not support it (and the development had stopped).
We should probably find some alternative to rtmidi-jna. So far JRtMidi does not support darwin-arm64 either.

 Those arm64 builds will still not be published as "platform" Maven packages, but at least they should build locally. (They are missing due to CI build issues.)

It is currently blocked to due Gradle module resolution issue (which I guess is identical to https://github.com/atsushieno/aap-core/issues/174). We cannot "publish" rtmidi-javacpp package from this repo, so either we exclude the module from publishing target, or fix the actual Gradle issue.

The actual rtmidi-javacpp resolution failure seems coming from https://github.com/atsushieno/rtmidi-javacpp/issues/1 .

It is regarded as fixed as of 92a294e.
Linux arm64 and Mac arm64 packages build, but they cannot be "built" on GitHub Actions. For macosx-arm64 it would be possible if I had access to macos-13-xlarge, but I don't. And gradle-javacpp does not support cross compiling so far (as far as I know).
I'm marking this issue as completed.


Number of words do not match the number of labels in a given sentence

Thanks a lot for making the data public. I downloaded the data from LDC. When analyzing the data, we found that for certain entries, the number of words do not equal the number of labels.
For example in file atis_seven_languages/data/train_ES.tsv, if we look at line number 2261, we find that there are 21 words in the sentence but 23 labels:
$ head -2261 atis_seven_languages/data/train_ES.tsv | tail -1 | cut -f2 | tr ' ' '\n'  | wc -l
      21

$ head -2261 atis_seven_languages/data/train_ES.tsv | tail -1 | cut -f3 | tr ' ' '\n'  | wc -l
      23

$ head -2261 atis_seven_languages/data/train_ES.tsv | tail -1
2260	Quiero ver los vuelos entre Boston y Atlanta para el once de julio que salgan a la una de la tarde	O O O O O B-fromloc.city_name O B-toloc.city_name O O B-depart_date.day_number I-depart_date.day_number I-depart_date.day_number I-depart_date.day_number O O O O O B-depart_time.time O O B-depart_time.period_of_day	atis_flight

Is this expected?

Same issue here, is there any update on it?


activity bar badges collapsing when set to top instead of default after restart

Does this issue occur when all extensions are disabled?: Yes/No
No, because w/out any extentions there are not so many badges in the bar that it needs to collapse, so really yes and no...

VS Code Version: 1.90.1
OS Version: Windows 10 home

Steps to Reproduce:

Set 'activity bar position' to 'top'
close and re-open
after restart only a view badges show, besides the 3 dots to show all the other badges in a list and a big empty space, even though there is enough space to show all of them
only way I found to then show them all is either making the side bar ridiculously long or setting the activity bar postion to 'default' and back to 'top' again

same thing happens when set to 'bottom' instead of 'top'

Very surprised to see this. I tried to reproduce and it doesn't happen for me. I don't think this is being cause by a setting but to be sure, could you remove all your settings except activity bar top (don't forget to copy the to not lose them!) and check if it still happens then? Also, does this also happen when you run the Reload Window command?

sorry i'm really new to vscode, how do i remove all the settings? is there like a file for that? if so where is it?

Very surprised to see this. I tried to reproduce and it doesn't happen for me. I don't think this is being cause by a setting but to be sure, could you remove all your settings except activity bar top (don't forget to copy the to not lose them!) and check if it still happens then? Also, does this also happen when you run the Reload Window command?

Not OP, but I can confirm that this still happens even for me with all settings as default and no extensions installed. Initially moving it is fine, but after either Reload Window OR closing and reopening VSCode it maxes out at 50% of the width and shows the three-dot more button.

@TheBestOf1204 Did you happen to also use https://marketplace.visualstudio.com/items?itemName=drcika.apc-extension at any point? This seems like it might be the cause even after removing it. Just double-checked with a clean install. All was fine until I installed that extension. Uninstalling the extension doesn't fix the positioning though.

Thanks @brendon1555 for figuring this out and letting us know. Closing this issue as it's cause by an extension.


ROCm available for Vega M / Kaby Lake G / NUC Hades Canyon?

Is there support for Vega M processors (Intel i7 with combined AMD GPU)? It's not clear where that model fits in under the supported list of CPUs.
AMDGPU support for Vega M is said to be available with the 4.18 kernel. I can get ROCm installed under the 4.18.5 kernel on Ubuntu 18.04.1 following the Vega 56/64 guide, but calling rocminfo gives the dreaded return of

hsa api call failure at line 900, file: /home/jenkins/jenkins-root/workspace/compute-rocm-rel-1.8/rocminfo/rocminfo.cc. Call returned 4104

System information is available here if useful.

@jlgreathouse Thanks for the information. I read one of your comments in discussion related to kernel 4.18 support and that userland software works without rock-dkms driver, which makes sense.
I am currently running 4.18 kernel on a Vega M GH GPU, ROCm seems to detect GPU but it compute fails however I see amdkfd module is loaded.
I am new to this and can't wrap my head around exact supported / unsupported things in Vega M GPUs. Can you clear this a bit? Thanks.

Okay, I did some reading which clarified that AMDGPU driver loads but amdkfd does not have support for it yet. Please +1 this addition request for me. One reason, I bought the Hades Canyon NUC with Vega M GH was to experiment with ROCm. Hope to see support soon :smile:


Allow uninstaller to remove non-empty install directory

Fixes issue #712
Brief summary of changes
Uninstaller on Windows now removes the installation folder even if non-empty, added switch
Testing I've completed
Built installer and tried install/uninstall on my local machine. All worked as expected
CHANGELOG.md (choose one)

no need to update because bugfix

ci doesn't exercise the installer, no need to wait for it.


Use Inria runners for GitHub actions

See email exchange with @j-l-s (July 23, 2024)

Still we would need to check whether the performance of the runners is the same as with GitHub runners

Contacted<EMAIL_ADDRESS>✅

@ocots @PierreMartinon @gergaud fruitful exchange with @srcansiz and @j-l-s today. meeting scheduled Aug. 26 9:00 to try to deploy on a test repo (maybe not OptimalControl.jl but a subpackage - CTBase.jl...)
https://inria.webex.com/meet/jean-baptiste.caillau
Retex from another Inria project: Inria self-hosted runners (= the slaves we used during the ADT) should be faster than those from GitHub 🤞🏾

I do not have access to the Settings page of CTBase (or any other) repo, to create a new self hosted runner.
Do I have the correct access rights  to the organisation/repos ?

I do not have access to the Settings page of CTBase (or any other) repo, to create a new self hosted runner. Do I have the correct access rights to the organisation/repos ?

Should be ok now.

Not really: I would like to add a Runner to the organisation (control-toolbox), so it can be shared with all repositories. It need "Owner" credentials for it..
PS: I have access to  https://github.com/control-toolbox/CTBase.jl/settings, but no menu "Runners" on this page...
PPS: not emergency for that, I just wanted to anticipate the meeting with JBC

Full power entrusted, mr Sz 😱

Instead of exchanging in this issue, I started a conversation here: https://github.com/orgs/control-toolbox/discussions/59

There seems to be an issue for the TagBot workflow when launched on the inria runner: missing docker ?
https://github.com/control-toolbox/CTDirect.jl/actions/runs/10562569660/job/29260837620


Make Continue Button and Update Saves to Distinguish a New vs. Old Game

To elaborate, there's no need to update saves as we can just use level_progress