ShellContextMenu don't provide some items such as "Scan with Microsoft Defender"

Describe the bug
Lack some items for unknown reason
What code is involved
ShellContextMenu.GetItems();

Expected behavior
Should provide all context menu items just like the menu in Windows Explorer

What extension are you viewing?

What extension are you viewing?

A Folder, compare to the context menu in Windows Explorer, you will find some of the items missing

A Folder, compare to the context menu in Windows Explorer, you will find some of the items missing

Does this help? https://stackoverflow.com/questions/63789282/different-shell-context-menu-versus-windows-explorer-context-menu

Does this help? https://stackoverflow.com/questions/63789282/different-shell-context-menu-versus-windows-explorer-context-menu

No, because "Scan with Microsoft Defender" is not a submenu item. We should find it in the context menu directly.

No, because "Scan with Microsoft Defender" is not a submenu item. We should find it in the context menu directly.

The entire "context menu" is a submenu. Do you have a means of seeing window messages to determine if other items are getting inserted that way as the article suggests?

The entire "context menu" is a submenu. Do you have a means of seeing window messages to determine if other items are getting inserted that way as the article suggests?

Also, have you tried passing different combinations of the CMF enum to GetItems?

Also, have you tried passing different combinations of the CMF enum to GetItems?

Which method of ShellContextMenu are you using to get or display the menu?

Which method of ShellContextMenu are you using to get or display the menu?

Yes I tried different CMF but helpless.
I use GetItems() to get the context menu and just get the info from it. I will display context menu on my own flyout.

Yes I tried different CMF but helpless.
I use GetItems() to get the context menu and just get the info from it. I will display context menu on my own flyout.

A few interesting notes:

Build the DLL as x64 and you will get different menu items
Use CMF_EXPLORER | CMF_CANRENAME | CMF_EXTENDEDVERBS for the most complete list.

Let me know your findings with those helps.

A few interesting notes:

Build the DLL as x64 and you will get different menu items
Use CMF_EXPLORER | CMF_CANRENAME | CMF_EXTENDEDVERBS for the most complete list.

Let me know your findings with those helps.

Interesting.
But we still get part of the context menu item, not all of them.

Interesting.
But we still get part of the context menu item, not all of them.

From my reading, I believe there are menu items that Explorer manually inserts from the ProgID which are not incorporated via the calls with IContextMenu.

From my reading, I believe there are menu items that Explorer manually inserts from the ProgID which are not incorporated via the calls with IContextMenu.

From what I understand, you need to open the ProgId in the registry, go to the shellex\ContextMenuHandlers key and the create each CLSID referenced and then query it's IContextMenu for additional menu items. I have found no information on how to insert them into the correct places in the menu.

From what I understand, you need to open the ProgId in the registry, go to the shellex\ContextMenuHandlers key and the create each CLSID referenced and then query it's IContextMenu for additional menu items. I have found no information on how to insert them into the correct places in the menu.

If you find a way to get the full menu, please send me details and I'll work on incorporating them or make the changes and submit a PR.

If you find a way to get the full menu, please send me details and I'll work on incorporating them or make the changes and submit a PR.

It appears, looking at a registry trace while loading a context menu for a folder in Explorer, that it enumerates the entries in HKCR\Software\Classes\Directory\background\shellex\ContextMenuHandlers and the opens the PROGID for each handler and then opens the file (I assume for reading its IContextMenu). What I can't tell is order. I would try an experiment of passing the HMENU that comes from the IShellFolder based query and passing it to one of your special handlers to see if they put their menu item into the menu. Whichever of us gets to it first, let's post our findings here.

I found that if we need to fetch all menus, we should fetch it in STA thread with
Shell32.CMF.CMF_NORMAL | Shell32.CMF.CMF_SYNCCASCADEMENU

Cool. Can we close this issue then? I'll put these instructions in the help for the GetItems method.

Yes I will close it

So, for the documentation, you gave me the two enum values and the STA thread requirement. Were there other CMF values? Also, are you running as x86, x64 or Any CPU?

For extra items use CMF_EXTENDEDVERBS. My program run as X64. But I think it should be work on other. The key point is STA thread


Option to include identifier in stackview and move by id

Hello, I'm trying to integrate Cursive into the Grin Cryptocurrency project (https://github.com/mimblewimble/grin), and am having difficulty trying to create a simple always-displayed menu that changes the content of another view onscreen. The issue is that there's no way to identify a stack view other than by position in the stack, which makes it cumbersome to relate a menu item to a particular stack view.
I've forked off my own branch to include in the project, but it would be very good if this, (or something equivalent) could be included upstream. Basically, it changes the 'layer' function in StackView to include an optional id:
let stack = StackView::new()
   .layer("TextView::new("1"), Some("layer_1"))
   .layer("TextView::new("2"), Some("layer_2"))
   .layer("TextView::new("1"), Some("layer_3"))

And then layers can be brought to the front with:
   stack.move_id_to_front("layer_2");

etc.
Not offended if what I have here breaks any design principles, but I think this feature would be very good to include in some form or another. I'd originally tried to only include the ID in the Child struct based on whether the added view was wrapped in an IDView, but had trouble trying to downcast it generically to operate on it (I don't think it can be done in Rust), so unfortunately my approach required an additional Option argument to layer and related functions.
Thank you for your work so far on Cursive, it seems excellent.

Hi, and thanks for the report!
Indeed, it is currently quite inconvenient to get a view position from its ID.
06305c89a9223ffa0b041c94df4a51a177b1c99a should bring StackView::find_view_from_id, which allows you to identify the layer containing an ID (the view with the ID could be deeply nested within the layer).
This should let you find the position of the view you want to move, without affecting users who don't need this.

I'm glad I could help! Don't hesitate to ask for anything, or to report any painful point when using cursive - feedback is golden!
Good luck to you guys, grin looks like a pretty nice project to follow! :)


[Bug] Fatal Error

Fatal error: Call to undefined function cryptPassword() in /home/hexeus/public_html/2Moons/includes/pages/adm/ShowAccountEditorPage.php on line 432

Fixed. Thanks for reporting


Implement packageFilenames: specify which files get the package.json special treatment

Implements #172.
Adds a new option packageFilenames: null | string | Array<string>;  Defaults to ['package.json'].  Controls which config files will be given special treatment as a package.json file.
If you want to pull config from a packageProp of an alternative file, say manifest.json, you can do that.
You can also disable special-casing entirely, so that package.json can be loaded through the same code paths as any other config file.

Updated; tests are passing; coverage is 100%.

I ended up using find-up in mocha, so my use-case for this feature doesn't exist anymore.  I appreciate everyone taking the time to discuss.  mochajs/mocha#3830


Invert FORCE_CUDA=1 or improve install from source to fail if cuda extensions can't be built

So I was debugging why the deployed model inference was slower than in a Jupyter Notebook.
The reason was that the CI that is building the container image did not build the cuda extensions (because of this).
It would probably be better to invert this logic to throw an error if It cannot build the cuda extensions.
Otherwise many users might not understand why their performance is worse than what should be possible.
This could be bypassed with a env var like OPTIONAL_CUDA=1 or DISABLE_CUDA=1.

An new environment variable WITHOUT_CUDA has been added, fails if CUDA is not available and that is not set.

Looks like the previously built wheel packages are all without CUDA and CUDNN😂.
I am refactoring setup.py to correctly include those things. I am trying to use the bundled CUDNN with PyTorch from the nvidia.cudnn package as it seems that most users don't have a system-installed CUDNN.

Looks like the previously built wheel packages are all without CUDA and CUDNN😂.

:sweat_smile:

I am trying to use the bundled CUDNN with PyTorch from the nvidia.cudnn package as it seems that most users don't have a system-installed CUDNN.

Awesome, that should make it more portable and easy to install :+1:


PreferPHPUnitThisCallRector vs. PHPStan Strict Rules

when enabling PHPUnitSetList::PHPUNIT_CODE_QUALITY in a PHPUnit 10.x based projects I get a lot of
self::assertSame($expected, $result); lines turned into $this->assertSame($expected, $result);
(every changed occurence turns into a PHPStan strict error)
even on PHPUnit 11.x the asserts methods are static.
I wonder why this PreferPHPUnitThisCallRector  exists and whether its really a good idea to have it in PHPUnitSetList::PHPUNIT_CODE_QUALITY...?
IMO doing the opposite would be more useful (turn $this into static) - but at least removing this rule from PHPUnitSetList::PHPUNIT_CODE_QUALITY would be a good first thing IMO.
wdyt?

Using $this in PHPUnit cases make more sense, as it's tests are classes. Classes that use parent method locally. static is there to allow edge-case functional testing.
In case of Pest this would make more sense, as those tests are functions-first.
If you prefer something else, register this rule with different your preffered configuration :+1:


[Feature Request] Restler should test presence of auth files as part of settings validation

💡 Idea
Restler should test for presence of auth module if module authentication is specified during settings validation and fail fast if it is unreachable/does not exist
Design Notes
No response

Closed with https://github.com/microsoft/restler-fuzzer/pull/698


Fix in DriverInfo()

Retrieve from default gateway network's peer endpoint if present

Signed-off-by: Alessandro Boch<EMAIL_ADDRESS>

LGTM

@aboch LGTM but we need to make sure that we use ep.Info().Iface().MacAddress() in docker to make sure that we always we get the correct mac address and update network settings there. No change is needed in libnetwork

@mrjana Good point, that way we show the right MAC. Thanks.


Question about KYC and Compliance - Regular verification

Hi you,
Can you share me process of this:

Base on the current document we need add new info : CompanyNumber and UBO declaration

For CompanyNumber i don't know how to get it
For UBO declaration we must only call api like on document or we must do anything else?
Can you share me full process of this
I want to apply this for new Legal User and old Legal User

Hi @duykhanh91
Company number info is here https://docs.mangopay.com/guide/company-number
For UBO there are three calls
https://docs.mangopay.com/endpoints/v2.01/ubo-declarations#e1024_the-ubo-declaration-object
Create a UBO
Create a individual UBO declaration
Submit the UBO
Please contact our support line https://support.mangopay.com/s/contactsupport?language=en_US for more information
Regards,
Max


Several Component don't work as described (DatePicker, Pin, Combobox, Dialog)

Description
When I am using the Docs for several components, I expect to see the Component as described on the Docs, but I see several issues:

I am using Pin and I expect onValueCompleted to be a prop in one of the Compound Components but it isn't working. (Link to Stackblitz)
I am using the DatePicker and several Compound Elements aren't there. (DatePicker.View, DatePicker.Label, ViewControl and more)
I am using the DatePicker and the renderProp section are throwing the error. (Type '(api: any) => Element' is not assignable to type 'ReactNode'.ts(2322)).

Both the Dialog and Combobox are having similar issues.
Link to Reproduction
https://stackblitz.com/edit/stackblitz-starters-jdr8yt?description=React   TypeScript starter project&file=src%2FApp.tsx&title=React Starter
Steps to reproduce

Go to the Stackblitz
And use the Pin
You will not see anything logged

Ark UI Version
1.0.0-beta-4, 0.15.0, 0.14.0, 0.12.0, 0.10.0
Framework

[X] React
[ ] Solid
[ ] Vue

Browser
Google Chrome Latest, Firefox Latest
Additional Information
It seems that several components Docs and their TS Definitions have diverged quite a bit. On top of that, the Docs need a lot of work since weekDays weeks, perMonthsGrid isn't available anymore. Same for the Pin and Dialog. Stuff are missing.
I weird thing is, I see instances of the Public API in the code, but it is not working as the Docs suggest.

Hi @EfstathiadisD,
The docs currently reflects the v1-beta code, if you swap out the version to “beta” in your package.json, it should work as expected.
We’re working to get the v1 release out in a few days.
Thanks for understanding

Cool. I think the beta.4 has an issue as well. beta.3 worked. Thanks!


[SceneManagement] Assign Entity.sceneValue before firing collection events

PR Details
Fixes a bug occurring when removing an entity, which can end up firing code which also tries to remove that entity, generating an exception as the collection does not expect such a state.
Description
Forced Entity.sceneValue and Scene.Parent to be taken care of before firing events related to them.
Related Issue
None reported.
Motivation and Context
Here's an example of the kind of issues where it would throw:

Remove entityA from scene

collection fires remove events lifo, so first:

SceneInstance event:fires processors

some user side code removes entityA from its scene

collection fires remove events

processors are mostly fine
Scene event:replace Entity.sceneValue

Scene event:replace Entity.sceneValue, woops, value does not match as it has been replaced above, throws right here

Types of changes

[ ] Docs change / refactoring / dependency upgrade
[x] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)

Checklist

[ ] My change requires a change to the documentation.
[ ] I have added tests to cover my changes.
[ ] All new and existing tests passed.

Can we check if this still works well with undo/redo in the editor?

@Kryptos-FR Just checked, undo/redo system still works.


[Q][Bug] Wandb CLI hangs up my job

Hello,
I am using wandb for logging various metrics and after a few hours (~5), my job hangs up due to some error on wandb end.
I have been facing this often now. Below is from my wandb debug log /work/shivanim/vqvae/wandb/debug-cli.shivanim.log Thank you for your help in advance!
2023-09-25 12:47:02 WARNING Connection pool is full, discarding connection: storage.googleapis.com. Connection pool size: 10
2023-09-25 12:47:02 WARNING Connection pool is full, discarding connection: storage.googleapis.com. Connection pool size: 10```

Hi @shivanimall! Thank you for writing in! Could you please provide the debug.log and debug-internal.log files associated with the run where you are running into this issue? These files should be located in the wandb folder relative to your working directory.

Hi there, I wanted to follow up on this request. Please let us know if we can be of further assistance or if your issue has been resolved.

Hi, since we have not heard back from you we are going to close this request. If you would like to re-open the conversation, please let us know!


Add's ability to select Icon Size on homepage

Description
Add's a selector to the settings screen to pick the size of icons displayed on the homepage.
Normal Size

Small Size

Please delete options that are not relevant.

[x] New feature (non-breaking change which adds functionality)

How Has This Been Tested?
Tried selecting the option, confirmed setting changes and displays correctly on homepage
Checklist:

[x] My code follows the style guidelines of this project
[x] I have performed a self-review of my own code
[x] I have commented my code, particularly in hard-to-understand areas
[x] I have updated changelog.md with changes made

@pagermon/collaborators Mind casting an eye over this one? While messing around for #238 i happened across this and quite like the way it looks with small icons 👍


Change logged message: "Already up" -> "Migrations already up"

And "Already down" -> "Migrations already down"
This output can be shown as part of a deploy without any further context making it clear that it's related to migrations.
For example, I just set up CI to deploy to Heroku and saw output like
remote: Verifying deploy... done.
remote: Running release command...
remote:
remote:
remote: 17:40:12.828 [info]  Already up
To https://git.heroku.com/foobar.git

I initially assumed the deploy had failed to run migrations, because nothing about the output made it clear.
"Migrations already up" and "Migrations already down" aren't super clear as far as messages go, but I wasn't sure what would be better, especially for the "down" case. This is IMO better than the current message, at least.
I made a companion PR to Phoenix docs where they reference this message: https://github.com/phoenixframework/phoenix/pull/3919

❤


MSOutput nonRelVal - two run modes for MSOutput thread

Fixes #9609
Status
In development
Description
Changes for the MSOutput Module needed for nonRelVal Workflows. For more details about the requirements to the module see the Description in the Issue. For the Current PR  read bellow.
This PR should provide the following functionality:

Fetch all Request Records in status completed, announce, closed-out from ReqMgr
Create Data transfer subscriptions to the relevant Data Management System (DDM, Phedex, Rucio)
Implement local book keeping for transfers subscribed

It should work in two modes Producer an Consumer:

The Producer is a single thread fetching data from Reqmgr API and uploading ti to MongoDB
The Consumers are N threads to fetch records from MongoDB and take the relevant actions about making the the needed output data placement transfers, taking into account  the workflow type (RelVal | NonRelval) and eventual campaign/workflow  output data mapping.

In order to reduce Memory footprint and increase scalability, the Producer is split in two basic components:

A Functional Pipeline to apply all the changes and transformations to the documents one step at a time and upload them to MongoDB.
A Document Streamer (not yet fully implemented, may come with another PR, though) to feed the pipeline either a single document at a time or in strides of N documents at a time (in order to reduce communication with database in the future).

NOTE: A similar approach is intended for the Consumer too.
NOTE: The current PR is related to NonRelVal workflows only,  as well as to all the auxiliary code changes and modules needed to implement the service architecture explained above.
Is it backward compatible (if not, which system it affects?)
YES
Related PRs
External dependencies / deployment changes
NO

While working with this PR I explored some kind of a different approach. In order to improve the scalability and to avoid huge memory footprint, I decided to implement the service in a series of function calls that  are happening through a functional pipeline. The pipeline is feed from a document streamer (generator) instead of a huge in memory encoded Json file. At the end of the pipeline  the objects are either destroyed or just left to be deleted by the Garbage Collector because they go out of scope of the functions from the pipeline.
Here [1] is the final benchmark for the MongoDBUploader working on my laptop and reading from a 69MB json file with requests stored on my hard disk and a remote MongoDB Server (running on a VM in my laptop again). The indexes in the collections are created on the "RequestName" key. And all the documents are unique on this key.
[1]
In [276]: %time %mprun -f mongoDBUploader mongoDBUploader()
len result: 7361
counter: 7361
Filename: /home/tivanov/Projects/WMCoreDev.d/test/ms-output-test/ms_output_test.py
Line #    Mem usage    Increment   Line Contents
================================================
    87     97.9 MiB     97.9 MiB   def mongoDBUploader():
    88                                 """
    89                                 A top level function to drive the upload of all the documents to MongoDB
    90                                 """
    91                                 # TODO:
    92                                 #    to set a destructive function at the end of the pipeline
    93                                 # NOTE:
    94                                 #    To discuss the collection names
    95     97.9 MiB      0.0 MiB       counter = 0
    96     97.9 MiB      0.0 MiB       msOutIndex = IndexModel('RequestName', unique=True)
    97     97.9 MiB      0.0 MiB       msOutputDB = MongoDB('msOutputDB',
    98     97.9 MiB      0.0 MiB                            create=True,
    99                                                      collections = [
   100     97.9 MiB      0.0 MiB                                ('msOutRelValColl', msOutIndex),
   101     97.9 MiB      0.0 MiB                                ('msOutNonRelValColl', msOutIndex)]).msOutputDB
   102
   103     97.9 MiB      0.0 MiB       msOutRelValColl = msOutputDB['msOutRelValColl']
   104     97.9 MiB      0.0 MiB       msOutNonRelValColl = msOutputDB['msOutNonRelValColl']
   105     97.9 MiB      0.0 MiB       msPipelineRelVal = Pipeline([docTransformer,
   106     97.9 MiB      0.0 MiB                                    (docUploader, msOutRelValColl)])
   107     97.9 MiB      0.0 MiB       msPipelineNonRelVal = Pipeline([docTransformer,
   108     97.9 MiB      0.0 MiB                                       (docUploader, msOutNonRelValColl)])
   109    210.9 MiB    113.0 MiB       for _, request in docStreamer():
   110    210.9 MiB      0.0 MiB           counter += 1
   111    210.9 MiB      0.0 MiB           if 'SubRequestType' in request.keys() and 'RelVal' in request['SubRequestType']:
   112    210.9 MiB      0.0 MiB               msPipelineRelVal.run(request)
   113                                     else:
   114    210.9 MiB      0.0 MiB               msPipelineNonRelVal.run(request)
   115                                     # if counter == stride:
   116                                     #     break
   117    103.6 MiB      0.0 MiB       print('counter: %s' % counter)
CPU times: user 11.7 s, sys: 299 ms, total: 12 s
Wall time: 14.3 s
In [277]:
In [277]:
In [277]: msOutputDB['msOutRelValColl'].count_documents({})
Out[277]: 124
In [278]: msOutputDB['msOutNonRelValColl'].count_documents({})
Out[278]: 7237

Todor, does it means that the memory footprint comes from docStreamer()? And, can you explain why it takes 113MiB? Is it because of it wraps the data or it is size of the data? If docStreamer() is a generator it should consume only memory needed for a single document, otherwise, it may have wrong logic to handle the data.

@vkuznet - Yes I can explain it. It is because I am faking the docStreamer, since we do not have a real one yet. I am actually loading the whole data in memory from a file at once, just before I call the streamer, and I then stream (destructively pop)  a document at a time from there. On the other side I was expecting to see was a decrease of memory in that line on every second cycle.... but unfortunately the report from the 'meomory_profiler' module reports values which are somehow  accumulated thorough out of the whole run, but does not break them per cycle.

Todor, don't take it as a review because I simply "glanced" at this PR. I have a few comments though:

please elaborate on the initial description. This provides a reasonable amount of changes, and simply pointing to the GH issue is not efficient and clear
how about we rename the MSOutput threads to: MSOutputProducer, MSOutputConsumer?
I like very much the MongoDB module created under WMCore/Database (I haven't checked any implementation details though)
can you please also clarify what are the benefits of the Pipeline module? Given that it does not depend on any WMCore modules, it might make sense to move that under Utils instead. You can expand a bit on it in the initial description as well

Hi @amaltaro Thanks  for the comments:

please elaborate on the initial description.

Done

how about we rename the MSOutput threads to: MSOutputProducer, MSOutputConsumer?

A deal We got!

MongoDB Module

MongoDB has the so called Lazy database and collection creation - which happens late on the first document uploading, while in the meantime all the objects and sessions are created and inactive. So ti basically hides from you almost any error that my happen in the background until you actually hit it.This module is supposed to check everything in advance and also to create the needed indexes mostly because if we start with collections created by default we will not have the document index and the unique property for the index - which assures us we do not grow the database infinitely and we keep a closed set of documents in the system (regardless of the changes of the status of the workflow that this documents describe)

benefits of the Pipeline module?

So basically avoids objects reassignment of type x = x+2 which happens automatically internally in the pipeline. It also (supposedly - if we implement it correctly) should hold the objects in the memory only until they are in the pipeline. Once they are out we can either explicitly delete them at the end of the pipeline (I tried putting del there as a last call in the pipeline but did not work though :) )or just let them get out of scope (if  we keep everything enclosed only in the calling function scope), and then let the Garbage collector do its job. It also makes the code quite readable to me - you just create a set of pipelines with the proper actions you want to happen with the object, and on top of it you just create a simple dispatcher (in my case even a simple if fork works ) that throws the object in the relevant pipe. and you let the rest of the machinery do it's job ;)

Hi Alan @amaltaro, Thank you very much for the good review. I did leave some of the conversations unresolved Please take a look and comment if you think any of those need to be fixed before we merge this PR. And actually for some of them I do need your feedback/opinion.I am now pushing one commit with few of the changes requested in your review.  And few more commits to come later tonight.
Thanks again.

Thanks, Todor. I have unresolved conversations that need any sort of follow up. I might only get to those tomorrow though. Let's try to get this PR merged by my Tuesday morning.

@todor-ivanov please request for my review once you have fixed the problems reported by jenkins.

PR adding pymongo dependency to our wmagent-dev spec/image:
https://github.com/cms-sw/cmsdist/pull/5874

Test this please

test this please

While I review it, this must be solved:
Python3 compatibility checks: failed
    fails python3 compatibility test

@amaltaro, Thank you for the review.  I think I addressed all the requested changes  to the level that is reasonable given how late is this PR. It has been tested in my VM and while working on the things you mentioned  I spotted few other errors which I also cleaned. Before we proceed further let me answer your last questions from the review:

advantage of using bson.Timestamp instead an epoch timestamp

NONE :) It was  a mistake from my side to consider that since this is the internal format that Mongodb is using  we may benefit somehow from using it. It turned  out I cannot do simple arithmetics with it in the python code. So just went back to using Unix epoch time in seconds.

what happens if MSOutput crashes or is restarted while it has documents "locked"?

Documents stay locked. (of course it is in case we use the isTaken flag to lock them - which we agreed to switch off for the time being)

Please remove RequestStatus from these documents.

Removed

It seems to fetch documents in bulk (according to the query string), right? When it updates or write documents into the database, is it writing documents one by one? Or we have bulk calls?

No, it is working in both directions a single document at a time. We can add calls to the database and fetch documents in bulk, but it will need some more changes in the code to make it run through the workflows in strides of some predefined size. We can do it, but it will require further development.

@todor-ivanov changes look good in general, but I still see a few required changes here:

first, on the mongo document key naming convention (once we start creating docs in mongodb, it's much harder to change anything...)
you skipped my comments on the MSOutputStreamer module. Please review them and/or work on them in a new PR
we definitely need unit tests for some of those modules (please create a new GH issue)
please also create a GH issue to deal with those mongodb documents in bulk (that's an enhancement though)


Update StackExchange.Redis to latest

@mikeharder,
Thanks for having already signed the Contribution License Agreement. Your agreement was validated by .NET Foundation. We will now review your pull request.
Thanks,
.NET Foundation Pull Request Bot


Panic!

Hello guys, here's a fresh runtime error for you:
panic: runtime error: invalid memory address or nil pointer dereference
[signal SIGSEGV: segmentation violation code=0x1 addr=0x8 pc=0x792c29]

goroutine 857 [running]:
github.com/Rhymen/go-whatsapp.(*Conn).readPump.func1(0xc00016a620, 0xc00029ff40, 0xc000292c30, 0xc000292c20, 0xc0000294a0)
        /root/go/pkg/mod/github.com/!rhymen/go-whatsapp@v0.1.0/read.go:27 +0x29
created by github.com/Rhymen/go-whatsapp.(*Conn).readPump
        /root/go/pkg/mod/github.com/!rhymen/go-whatsapp@v0.1.0/read.go:26 +0x149
exit status 2

The werid thing is, when I open the file read.go on Github without switching to v0.1.0, lines 26 and 27 seem not to be relevant, so pheraps there's something wrong with the latest version, and a new tag should be created?
Or generally speaking, how can I import a package straight from github not caring about the tags but directly importing the package from the files on the repo?

Please show us your code


[Issue ##471] New Gui Sidebar Auto-saved

Added functionality that auto-saved the sidebar change without needing a submit button, .
Delete the original result window after the user click submit in sidebar

Excellent!  This feature is definitely needed!

After meeting with @henrychen0220 face to face, we did some manual testing after eliminating the save button, and everything works good.


Use golangci-lint

Since Go 1.19, gofmt formats comments. This caused make verify fail when using Go 1.19 with some license header comments.
gofmt output format also changes with Go 1.19, so hack/gofmt-all.sh is modified to be more robust. I took this opportunity to slighty improve this script.
Also, I modified Makefile:

verify should not depend of test (it should be static analysis only)
verify-generated should depend of update-generated (otherwise, it always succeeds)

PR updated: use golangci-lint

Same comment as in https://github.com/kubernetes-sigs/custom-metrics-apiserver/pull/111#issuecomment-1323555943, I'd very much prefer if we used golangci-lint.

PR updated to use golangci-lint.
In the Makefile, two changes are made in addition to adding golangci-lint:

target verify does not depend on test any more;
target verify-generated depends on update-generated.

Most other changes are formatting / style / naming.
Notable changes are:

Adding MinVersion: tls.VersionTLS12 to TLSClientConfig.
Current code was reported by gosec as G402 (CWE-295): TLS MinVersion too low
I used MinVersion: tls.VersionTLS12 because it's what client-go uses.
In pkg/client/api.go, req.WithContext(ctx) did not set the request's context, because WithContext is a pure function.  This is fixed by using http.NewRequestWithContext.

Thank you @olivierlemasle, the PR looks good to me overall. Just a small nitpick, would you mind doing the TLS MinVersion change in a separate PR? It is important enough in my opinion to have its own changelog entry. In the meantime, you can silence the report in this PR.

@dgrisonnet Done.
I'll create the follow-up PR with the TLS change after this is merged.

Thanks!
/lgtm
/approve


Signature HTML Editor size

Are there any related issues?

Two bugs: #3082 (Signature HTML editor size) and #2809  (Edit raw html signatures view is small). One is still opened while the other has been closed, but I've bee unable to find any solution.
What operating system are you using?
Apple - Sierra, v10.12.2
What version of N1 are you using?
v1.0.11
Bug?
Do you have any third-party plugins installed? If so, which ones?
no
Is the issue related to a specific email provider (Gmail, Exchange, etc.)?
I don't think so since it's related to the windows format in setting preferences for the overall application.
Is the issue reproducible with a particular attachment, message, signature, etc?
see screenshot in attachment
--
Feature Request?
Does this feature exist in another mail client or tool you use?
N/A

+1


Teams Task Module - Deserialization Error on Teams mobile app for iOS

Version
botbuilder-integration-aiohttp 4.14.0
Python 3.8.6
Describe the bug
Error when loading Task Module on iOS iOS 14.8.1 / MS Teams v3.20.0
To Reproduce

Deploy sample bot 54.teams-task-module
Say hello and click on Adaptive Card button
Deserialization Error when on iOS iOS 14.8.1 / Microsoft Teams v3.20.0

Traceback
(file locations prefix intentionally removed)
  File "test_teams_task/env/lib/site-packages/msrest/serialization.py", line 1293, in _deserialize
    found_value = key_extractor(attr, attr_desc, data)
  File "test_teams_task/env/lib/site-packages/msrest/serialization.py", line 1064, in rest_key_extractor
    return working_data.get(key)
AttributeError: 'str' object has no attribute 'get'
During handling of the above exception, another exception occurred:
Traceback (most recent call last):
  File "test_teams_task/env/lib/site-packages/botbuilder/core/bot_adapter.py", line 129, in run_pipeline
    context, callback
  File "test_teams_task/env/lib/site-packages/botbuilder/core/middleware_set.py", line 69, in receive_activity_with_status
    return await self.receive_activity_internal(context, callback)
  File "test_teams_task/env/lib/site-packages/botbuilder/core/middleware_set.py", line 79, in receive_activity_internal
    return await callback(context)
  File "test_teams_task/env/lib/site-packages/botbuilder/core/activity_handler.py", line 78, in on_turn
    invoke_response = await self.on_invoke_activity(turn_context)
  File "test_teams_task/env/lib/site-packages/botbuilder/core/teams/teams_activity_handler.py", line 155, in on_invoke_activity
    TaskModuleRequest, turn_context.activity.value
  File "test_teams_task/env/lib/site-packages/botbuilder/core/serializer_helper.py", line 28, in deserializer_helper
    return deserializer(msrest_cls.__name__, dict_to_deserialize)
  File "test_teams_task/env/lib/site-packages/msrest/serialization.py", line 1233, in __call__
    return self._deserialize(target_obj, data)
  File "test_teams_task/env/lib/site-packages/msrest/serialization.py", line 1299, in _deserialize
    value = self.deserialize_data(raw_value, attr_desc['type'])
  File "test_teams_task/env/lib/site-packages/msrest/serialization.py", line 1468, in deserialize_data
    return self._deserialize(obj_type, data)
  File "test_teams_task/env/lib/site-packages/msrest/serialization.py", line 1303, in _deserialize
    raise_with_traceback(DeserializationError, msg, err)
  File "test_teams_task/env/lib/site-packages/msrest/exceptions.py", line 51, in raise_with_traceback
    raise error.with_traceback(exc_traceback)
  File "test_teams_task/env/lib/site-packages/msrest/serialization.py", line 1293, in _deserialize
    found_value = key_extractor(attr, attr_desc, data)
  File "test_teams_task/env/lib/site-packages/msrest/serialization.py", line 1064, in rest_key_extractor
    return working_data.get(key)
msrest.exceptions.DeserializationError: Unable to deserialize to object: type, AttributeError: 'str' object has no attribute 'get'

Expected behavior
This sample bot raises no error when interacting on the following platforms:

Windows 10 (Desktop app, Firefox, Chrome)
macOS (Chrome)
Android (Mobile app)

It was possible to interact with Task Module on iOS iOS 14.8.1 / Microsoft Teams v3.20.0 when deploying these samples (python not included):
https://docs.microsoft.com/en-us/samples/officedev/microsoft-teams-samples/ms-teams-task-sample/
Additional context
Initially the error was detected on a bot in production currently deployed in Azure. Since the error message is the same when running bot sample 54.teams-task-module, for the sake of repro we can take this example.

This issue could take up a couple of day to get repro. Actively working on it, will post an update when available.

Was able to repro, this is due to a change in the Teams client for iOS. Will try to provide a fix soon. Thanks.

@axelsrz  Any updates on this issue?

@axelsrz can we make progress on the PR for this issue?

Thanks @axelsrz @tracyboehrer. Any plan for the next release? (deciding between: build from TestPyPI or wait for the next release)

was this released?


Database backup yields 0 byte file

Is there an existing issue for this?

[X] I have searched the existing issues

What happened?
Attempting to perform a database backup per the docs  yields a 0 byte file:
$ docker-compose exec -T database pg_dump -U teslamate teslamate > teslamate.bak
I've also tried adding a -d parameter like the below mentioned in the thread here to no avail:
$ docker-compose exec -T database pg_dump -U teslamate -d teslamate > teslamate.bak
I installed using the installation docs, only changing the passwords as denoted, and left the database names as they existed.
Perhaps the database or name(s) are different for my installation? (See Screenshot)
Expected Behavior
Expected behavior would be a non-zero byte file with the database backup.
Steps To Reproduce
$ docker-compose exec -T database pg_dump -U teslamate teslamate > teslamate.bak
Relevant log output
Docker PS shows the following for the running containers (see Screenshots).

Screenshots

Additional data
No response
Type of installation
Docker
Version
Uncertain, installed a couple weeks ago

Are you on the correct path?
This is my backup setup:
PATH=/usr/local/sbin:/usr/local/bin:/usr/sbin:/usr/bin:/sbin:/bin
now=date +"%A"
cd /home/pi/tmbackup
sudo /usr/local/bin/docker-compose exec -T database pg_dump -U teslamate teslamate > /home/pi/tmbackup/teslamate.bck_${now}
rclone copy --max-age 24h /home/pi/tmbackup --include 'teslamate.*' gdrive:TeslaMate

Correct path for what?

The first step is to find the file 'docker-compose.yml'
then run 'sudo docker-compose exec -T database pg_dump -U teslamate teslamate >teslamate.bck'

I'm running this within the directory containing the docker-compose.yml file.

Here is the output of the command with the --verbose option:
$ sudo docker-compose --verbose exec -T database pg_dump -U teslamate teslamate > teslamate.bak
compose.config.config.find: Using configuration files: ./docker-compose.yml
compose.cli.docker_client.get_client: docker-compose version 1.29.2, build 5becea4c
docker-py version: 5.0.0
CPython version: 3.7.10
OpenSSL version: OpenSSL 1.1.0l  10 Sep 2019
compose.cli.docker_client.get_client: Docker base_url: http+docker://localhost
...
compose.cli.verbose_proxy.proxy_callable: docker inspect_network <- ('downloads_default')
compose.cli.verbose_proxy.proxy_callable: docker inspect_volume <- ('downloads_teslamate-db')
compose.cli.verbose_proxy.proxy_callable: docker inspect_volume <- ('downloads_teslamate-grafana-data')
compose.cli.verbose_proxy.proxy_callable: docker inspect_volume <- ('downloads_mosquitto-conf')
compose.cli.verbose_proxy.proxy_callable: docker inspect_volume <- ('downloads_mosquitto-data')
compose.cli.verbose_proxy.proxy_callable: docker containers <- (all=False, filters={'label': ['com.docker.compose.project=downloads', 'com.docker.compose.service=database', 'com.docker.compose.oneoff=False', 'com.docker.compose.container-number=1']})
compose.cli.verbose_proxy.proxy_callable: docker containers -> (list with 0 items)
compose.cli.verbose_proxy.proxy_callable: docker containers <- (all=False, filters={'label': ['com.docker.compose.project=downloads', 'com.docker.compose.service=database', 'com.docker.compose.oneoff=False', 'com.docker.compose.container-number=1']})
compose.cli.verbose_proxy.proxy_callable: docker containers -> (list with 0 items)

Never mind, figured it out. I was running it from a directory with the docker-compose.yml file in it but not the original directory from which I deployed the file with docker-compose. Lesson learned.


libbitcoin{,client,explorer,network,protocol}: 3.5.0 -> 3.8.0

Description of changes
https://github.com/libbitcoin/libbitcoin-system/releases/tag/v3.8.0
Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[x] aarch64-darwin

For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)

[ ] sandbox = relaxed
[ ] sandbox = true

[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[x] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
24.05 Release Notes (or backporting 23.05 and 23.11 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[x] Fits CONTRIBUTING.md.

Add a :+1: reaction to pull requests you find important.

Fixes CVE-2023-39910.

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:
https://discourse.nixos.org/t/call-for-maintainers-libbitcoin/36852/1

Is this fine to backport as is to 23.11?
Upstream changelog seems to be incomplete which does not help and I am not using this so I'm probably not the best one to make the call.


Wrong lambda Calculation result

Hello
Here is simple identity function that returns constant function
λ > (((lambda x.(lambda y.x))4)5)
α > (((λx.(λy.x))4)5)
β > ((λy.4)5)
β > 4

however when i try to represent it in elm i'm getting another result
((\x -> (\y -> x) 4) 5)
5 : number

seems like i did mistake in some semantic stuff, could you clarify about lambda calculation rules in Elm? Thank you

Not a bug. The expression behaves the same in Haskell :) You've made a semantic error with the parentheses.
Translating your Elm lambda expression back into your first lambda notation:
((\x -> (\y -> x) 4) 5)
(( λx . (λy . x) 4) 5)
-- compare to original lambda (alignment with previous line intentional):
(((λx . (λy . x)) 4) 5)

Essentially what your Elm expression is defining is this function:
(\x -> (\y -> x) 4)

which takes any x and returns the immediate application of (\y -> x) to 4, making y := 4, and it thus gets discarded, giving us 5.

understood, thank you :)


Add/Delete Mentors Screen-Admin-App - Sprint 3

Description:

Build the Screen using the style guide.
Integrate Screen with the Backend

@Vic-Orlands please comment on this.

@Vic-Orlands please comment on this.

Okay. I will begin working on it. You can assign it to me


[WIP] store/darwin: rework keychain management

This implements all the features required for https://github.com/adamdecaf/cert-manage/issues/9. Sadly, it's a pretty large change that has several sorta-unrelated changes as well.. I'm keeping the changes separate commit-wise so the history isn't totally botched.
Fixes: https://github.com/adamdecaf/cert-manage/issues/9

Merging this. I've got a revamp of testing coming.


Upstream/refactor core

what :

Refactor code from files in core folder
Removed dead code from some files in core folder
Restructured the code from some files in core folder

@Ali-Razmjoo : travis-ci is completely stopped working it seems.
@Ali-Razmjoo  @ChakshuGupta  : This PR is not ready for review yet. Will update when finished.

this one needs several changes, i'll suggest later 👍

@Ali-Razmjoo : this one is also stopped because it's dependent on https://github.com/zdresearch/OWASP-Honeypot/issues/92


[MySQL] Export from Query to DB table doesn't work

System information:

Operating system (distribution) and version Win10
DBeaver version 6.3.5

Connection specification:

Database name and version MySQL

Describe the problem you're observing:
Export from Query to DB table doesn't work.
Steps to reproduce, if exist:
Write any select query in SQL Editor
Select Export fron Query in context menu of SQL Editor or in Resultset
Select "Target": Database and press Next
Press Browse or New for Target column>Error message appears: No database selected
Go through the wizard and press Start
Actual result:
Error message appears: No database selected
The export is failed
Include any warning/errors/backtraces from the logs
dbeaver-debug.log
.log

Fixed

Export from resultset still doesn't work, but another error is displayed.
Steps:

Execute a select query
Make export from query to a database> the result is successful
Make export from resultset to a database.
Actual result:
Error message appears "Field 'smth' doesn't have a default value".
The imported tables appears without a content.

P.S. Another error message appears if "timestamp" column exists in the exported table: "Timestamp format must be yyyy-mm-dd hh:mm:ss[.fffffffff]" (in the settings format "yyyy-MM-dd HH:mm:ss" is set in database and global settings
.log
dbeaver-debug.log

Described export works on the latest version.


Make all DC/OS agents share a single service wrapper

This pull request makes all the current DC/OS agents on Windows (mesos, spartan and epmd) to share a single service wrapper binary located at: C:\DCOS\service-wrapper.exe

Changes look good to me


cmd.py in latest PyPI release is not syntaxically correct

Hello,
The file cmd.py in the latest release in PyPI breaks RPM builds, because it tries to compile to python bytecode all the files and cmd.py is not syntaxically correct:
*** Error compiling '/builds/myproject/.venv/lib/python3.6/site-packages/threefive/cmd.py'...
  File "/cmd.py", line 1
    /*
    ^
SyntaxError: invalid syntax

update: v2.3.91 is now out. I had a weird pts bug that showed up rarely, but was bug none the less.
Hey man, since you are verifying the builds anyway, you want to give me a hand with things? Maybe you verify the build before pushing it to pip package. It would be a big help having someone else take a look before things get pushed.

You good?

Yea it works fine now, thanks.
I can help you if want.
Or maybe juste add something like a GitHub action ? I don't really know how it works but you should be able to run a command like python -m compileall . (create a virtualenv before then install the dependencies) and check the return status


Feature/combined tickets 201126

This PR implements the following tickets:
197400 - Prevent sharing, saving or downloading of files
193088 - Prevent forwarding of files (partial)
198033 - Room details display
197280 - Lingo app crash
189503 - User Profile (UI only, no back-end)
This branch utilises the new LingoTests target introduced in PR #6 to specify unit tests for changes specific to the Lingo ACT Health project. Unit tests for 197400 are included in this PR.
The branch is based upon act-master.
This branch will build on Xcode 12 / iOS 14.
Pull Request Checklist

[x] I read the contributing guide
[x] UI change has been tested on both light and dark themes, in portrait and landscape orientations and on iPhone and iPad simulators
-Noting there is no change currently in the display behaviour between those two settings as per requirement.
[x] Pull request is based upon act-master from the Pegacorn repo.
[x] All new and existing unit tests pass successfully in this branch.

Responded to @jrschremmer 's comments, updated branch with various commits accordingly.  Ready for review continuation.


testgen: increase gas price of legacy test transaction

besu does not accept legacy transactions with a gasPrice below
baseFeePerGas. I think it's reasonable to allow this behavior, and the
test should be made to pass by increasing the submitted price.

xref: https://github.com/ethereum/hive/pull/661?notification_referrer_id=NT_kwDNGwOvNDkzNzAwNDYyMDo2OTE1#issuecomment-1336435609


Add the deletion of application to the tests.

Description
Add test for app removal. Add that also for other tests to the after suite. Refactor common page objects.
Type of change

[x] Refactoring (no functional changes, no api changes)
[x] Other: test enhancement

How to test or reproduce?
Run tests as described in a readme.

/retest

/retest


How to disabled all weekend in this calendar

Subject of the issue
How to disabled all weekend in this calendar, I want to disabled weekend, but I can't pass all the weekend date to the disabledDates props (since its a Date object of Array)
[BUG] Bug Reproduce Steps
Tell us how to reproduce this issue.
[BUG] Expected behaviour
Expect a new Props to disable weekend or improve disabledDates props
Environment
Package Version:
React version:
Node version:
Browser:

You can use the following helper function to calculate all weekends between two dates
import { addDays, isWeekend } from 'date-fns';

function calcWeekends(startDate, endDate) {
    if (startDate > endDate) return false;
    var date  = startDate;
    var dates = [];

    while (date < endDate) {
        if (isWeekend(date)) dates.push(new Date(date));
        date.setDate( date.getDate() + 1 );
    }

    return dates;
}

const disabledDates = calcWeekends(new Date(), addDays(new Date(), 100))

Then, simply set disabledDates={disabledDates} in the component you want to use.


Monitors only tokens of interest

Fix #834

At first state initialization, all found token networks are scanned for past and future channels with us

If any found, we consider this a TokenNetwork of interest, and start monitoring it for channels from beginning (and keep monitoring on each new block on current and future sessions)
Otherwise, we ignore the TokenNetwork and don't monitor it (which is expensive)

A new Raiden.monitorToken public method is exposed, which allows user to trigger scanning and monitoring a token network from beginning (even if state is already initialized). Even if no channel is found, this token network is now also considered of interest, and also monitored throughout current and future sessions
All on-chain registered token networks can still be retrieved through Raiden.getTokenList method (which can be a bit more slow, since it needs to fetch all logs from registry, and should be cached)
Requesting a channel to be opened in an unmonitored token network causes it to also become of interest and be monitored from now on.

TODO:

[ ] adapt dApp to fetch and cache tokens for a new connection from getTokenList instead of internal state which depended on tokenMonitored events

PS: already initialized instances don't benefit from the optimization, as all currently registered token networks are considered of interest on old state. One needs to clean state (if no transfers were made on any possibly open channel) or manually edit localStorage on browser and remove all entries from tokens property, to trigger it to be populated again with only networks of interest.

This change is

Please create a change log entry


The unit of the input radius

Please could you mention the unit of the input radius of the circle

Meters.


The arbitrary data does not work.

I tried to send arbitrary data, but at the moment they are not being
code on my client:

output client :

my config server:

code on my server:

output server :

I need this functionality, did you ever get it to work?

No, in the end use another library (socket-delivery)

Thanks.
I think I'll try a fetch to a post request containing my file and extra data and express-filleupload to capture the file.


median function acts like min

Min and Median functions has the same codes, both of them gets stats.Min as a parameter. When a user try to test ssh latency it gives Min and Mean is equal result incorrectly. We can verify it via example results in README.
https://github.com/jacobsa/ssh_ping/blob/6c1e3e3090f8340c830195c981892863e395e913/ssh_ping.go#L49-L55

Fixed #2


Typescript compilation problem since 1.17.19

Since v 1.17.19  I'm getting errors with our typescript compilation.  I presume it's related to this change
Optimize exported types of columns and column methods by explicitly writing them instead of inferring
I get
│ db/tables/tables.ts(36,15): error TS18046: 't' is of type 'unknown'.
│ db/tables/tables.ts(64,10): error TS18046: 't' is of type 'unknown'.
Where I'm trying to create a BaseTable with

const BaseTable: TableType = createBaseTable({
  snakeCase: true,
  columnTypes: (t) => ({
    ...t,
    timestamp: <P extends number>(precision?: P) => t.timestamp<P>(precision).asDate() as any,
  }),
});

Thanks for trying and reporting!
const BaseTable: TableType = createBaseTable({

What is the TableType here for? I guess this might be a problem, could you try removing it?
It's hard to tell by this code, similar code works on my end, if you could make a minimal repro that would help. Maybe the version of orchid-orm is conflicting with the version of pqb, try updating all such packages to the latest version.

I use this
export type TableType = ReturnType;
If I don't type BaseTable I  get this typescript compiler error.
TS2742: The inferred type of 'BaseTable' cannot be named without a reference to<EMAIL_ADDRESS>This is likely not portable. A type annotation is necessary.
I don't have an explicit dependency for pqb so it is whatever we inherit from orchid - in this case it is the latest 0.18.28.

I've found the error - my bad it wasn't where I thought but slightly further down.  I've distilled it down to this file
import { createBaseTable, Table } from 'orchid-orm';

export type TableConfig = Table['columns'];
export type TableType = ReturnType<typeof createBaseTable>;

const BaseTable: TableType = createBaseTable({
  snakeCase: true,
  columnTypes: (t) => ({
    ...t,
    timestamp: <P extends number>(precision?: P) => t.timestamp<P>(precision).asDate() as any,
  }),
});

export class DeviceCodeTable extends BaseTable {
  readonly table = 'device_code';
  columns: TableConfig = this.setColumns((t) => ({
    userCode: t.varchar(),
  }));
}

Previously it was fine - I'm guessing typescript inferred the argument for this.setColumns but now is unable to.

Column types are unknown in the Table type, and that's on purpose because it's a generic type, it can't know the exact column types.
I removed these explicit types and have no TS errors:
import { createBaseTable } from './baseTable';

const BaseTable = createBaseTable({
  snakeCase: true,
  columnTypes: (t) => ({
    ...t,
    timestamp: <P extends number>(precision?: P) =>
      t.timestamp<P>(precision).asDate(),
  }),
});

export class DeviceCodeTable extends BaseTable {
  readonly table = 'device_code';
  columns = this.setColumns((t) => ({
    userCode: t.varchar(),
  }));
}

The Table type is internal and not meant to be used other than for generic functions.

As I mentioned If I dont have a type for BaseTable then I get this
TS2742: The inferred type of 'BaseTable' cannot be named without a reference to<EMAIL_ADDRESS>This is likely not portable. A type annotation is necessary.
I'll take a look if I can work around it.

The module I'm creating is a shared library so I have declaration: true in my ts-config.json.
When this is enabled I get the errors shown above.

Hmmm ... I think (somehow) this is related to us using pnpm to do the install.   Using npm does not seem to generate the same errors.

Seems like I have been hit by this typescript/pnpm issue
https://github.com/microsoft/TypeScript/issues/47663#issuecomment-1519138189

This seems to work "import {} from 'pqb'" and adding pqb as a direcet dependency.

Cool, so it's solved, right?
Yes, pqb is a required dependency. This should be clarified in the docs.

I'm not sure why I have to still include  the
import {} from 'pqb'
For it to work,  I kinda understand that you need to install pqb, but its definitely a pnpm/typescript issue. Hopefully this might help someoneelse.

I'm not sure why I have to still include the
import {} from 'pqb'

This isn't right, importing nothing is weird. Please, make a min reproduction repo, I'll look into it. The problem must be related to the fact that you're doing a shared library, so you have some unique setup for it.


i have a request when i abort this request will be a error "signal is aborted without reason"

Environment
<EMAIL_ADDRESS>version "1.3.4"
<EMAIL_ADDRESS>version "3.8.2"
Reproduction
signal is  new AbortController().signal
$fetch(url, {
...params,
key,
baseURL: VITE_API_URL,
signal,
onRequest(context: any) {
// doing something
},
onResponse(res: any) {
const { error, response } = res
// doing something
return response._data
},
onError(e: any) {
console.log(e)
},
})
Describe the bug
even though I cancelled the request, the return value is still there.
Additional context
No response
Logs
No response

same issue here

any update on this?


[Bug] connect feature is not working with Scatter/heatmap chart.

Version
5.4.2
Link to Minimal Reproduction
https://codepen.io/ragava28/pen/GRYPaNP?editors=0010
Steps to Reproduce
In below codepen example when we hover on Depth Vs Time chart (scatter chart) ,on samples  (x,y)= >[(0,0),(0,1),(0,2),(0,3)(0,4)].
we can see that tool tip in Voltage vs Time and Depth vs Amplitude charts shows up perfectly. but when we hover on other samples it dosent work.
https://codepen.io/ragava28/pen/GRYPaNP?editors=0010
Current Behavior
Currently it works only for first x sample  & all corresponding samples of y.
Expected Behavior
it should work for all the X & Y samples.
Environment
- OS:
- Browser:
- Framework:

Any additional comments?
No response

Interesting experiment, seems that in connect you are trying to mix
tooltip.trigger:"item" with tooltip.trigger:"axis"
and/or tooltip.axisPointer.axis:"x" with tooltip.axisPointer.axis:"y".
I think neither will work (and they don't), but a developer would provide a better answer.

https://github.com/apache/echarts/issues/18667


pull request for e2e test at 01/03/2017 07:45:08

:white_check_mark: Validation status: passed
For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.


Is steps indicators can be clickable?

Can steps indicators be clickable?
Thanks.

I found the answer in documentation
The answer is yes


[Enhancement] support trino's show schemas function

Why I'm doing:
What I'm doing:
MySQL [(none)]> show schemas from default_catalog;
+--------------------+
| Database           |
+--------------------+
| statistics       |
| information_schema |
| mydb               |
| sys                |
+--------------------+
4 rows in set (0.005 sec)
MySQL [(none)]> show schemas from default_catalog like '__db';
+----------+
| Database |
+----------+
| mydb     |
+----------+
1 row in set (0.002 sec)
Fixes #40894
What type of PR is this:

[ ] BugFix
[ ] Feature
[X] Enhancement
[ ] Refactor
[ ] UT
[ ] Doc
[ ] Tool

Does this PR entail a change in behavior?

[ ] Yes, this PR will result in a change in behavior.
[X] No, this PR will not result in a change in behavior.

If yes, please specify the type of change:

[ ] Interface/UI changes: syntax, type conversion, expression evaluation, display information
[ ] Parameter changes: default values, similar parameters but with different default values
[ ] Policy changes: use new policy to replace old one, functionality automatically enabled
[ ] Feature removed
[ ] Miscellaneous: upgrade & downgrade compatibility, etc.

Checklist:

[X] I have added test cases for my bug fix or my new feature
[ ] This pr needs user documentation (for new or modified features or behaviors)

[ ] I have added documentation for my new feature or new function

[ ] This is a backport pr

Bugfix cherry-pick branch check:

[X] I have checked the version labels which the pr will be auto-backported to the target branch

[ ] 3.3
[ ] 3.2
[ ] 3.1
[ ] 3.0
[ ] 2.5

hi rohitrs1983 thanks for your contribution!
trino's show schema is a very useful sql that sr didn't support in trino's SQL dialect. However I think it is better supported under sr's trino dialect instead of introducing schema into starrocks. cause starrocks doesn't have the concept of schema all the time.
do you mind support this in trinotransformer? https://github.com/StarRocks/starrocks/tree/7982265b4e0ba59e5cfc882e44b1a7cbfe361923/fe/fe-core/src/main/java/com/starrocks/connector/parser/trino
And I think trino's show schemas from catalog is same as starrocks show databases from catalog.

hi rohitrs1983 thanks for your contribution! trino's show schema is a very useful sql that sr didn't support in trino's SQL dialect. However I think it is better supported under sr's trino dialect instead of introducing schema into starrocks. cause starrocks doesn't have the concept of schema all the time. do you mind support this in trinotransformer? https://github.com/StarRocks/starrocks/tree/7982265b4e0ba59e5cfc882e44b1a7cbfe361923/fe/fe-core/src/main/java/com/starrocks/connector/parser/trino And I think trino's show schemas from catalog is same as starrocks show databases from catalog.

@wangsimo0 ok got. let me give it a try. thanks for the review.


Where is annie?

Is annie replaced by lux? Why?
Thanks

OK, after searching on the web, lux is better than annie.


Test GraalVM

https://twitter.com/java/status/989535868284260353
https://dzone.com/articles/learning-to-use-the-graalvm

For Mindstorms, it is not available.
Native image is a nice idea.


Error while starting the uvm_reg_mem_hdl_paths_seq.

Hi Taichi,
I'm able to run my RAL testcase by starting uvm_reg_hw_reset_seq and uvm_reg_access_seq. But when I'm trying to start uvm_reg_mem_hdl_paths_seq, the following errors are comming for every register.

I'm thinking like if the hdl path is wrong, then above two sequences should have created the issues. Suggest me, should I ignore these errors?
Regards,
Tejoyadav

Generated RAL models do not support PLI based backdoor access so I think you can ignore these errors.

Okay, thankyou for confirming

PLI is a specification of software interface.
By using PLI, you can access/update Verilog objects (e.g. reg variables) from oher programing langurage such as C.
By default, UVM bacdoor access feature is implemented by using PLI to allow hierchical access using string variable.
PLI is a useful feature but it may cause slower simulation runtime.
To avoid this problem, I introduce virtual interface based backdoor access feature.


Introduce a new test helper for easier log snapshot testing

Use the new runWithLogCapture helper instead of the long boilerplate to capture the log for snapshot testing.
We have a bunch of same boilerplates over many test sources. I'll convert those to use the new helper in follow-up PRs.

@mumoshu some ci issue about golang-lint.

@yxxhero Thanks! Fixed.


ROS implementation

Hello,
Thanks for the great work. There is a significant efficiency of inference in Nvidia px2.
I am considering a ROS implementation, do you think any obstacle due to dependencies etc.?
I have something like below in my mind:
https://github.com/leggedrobotics/darknet_ros
Thanks,
Regards,
Ugur

I have just found there is one repo with the original Alexeyab Yolo:
https://github.com/pushkalkatara/darknet_ros
So the question is, I should rephrase, does quantization and xnor updates would cause problem for ROS?
I will keep digging and update here.
Thanks again


Add the search.books API method

This PR adds the search.books API method.
I took the liberty to fix the remainder of the linting errors in the project with this PR, and also created a package for the response types, since this endpoint introduced an Author and Book type which differed from the types used for other endpoints in the API.
If you have any concerns I'm happy to go over them, and thanks for reviewing!

Looks great, thanks!


operator for app open sequences?

Often times we may want to run some sequence of events on app opening before passing an app down the line to create objects, etc. For example: Locking a field and making a selection in it on open.
Today I do it like this:
var appSetup$ = eng$.qOpenDoc("20108945-04ae-4ead-a99b-3d65142b6412");

var field$ = appSetup$.qGetField("RoomLocation");

var lock$ = field$.qLock().take(1);
var select$ = field$.qSelect("22Link", true).take(1);

var openSeq$ = lock$
    .concat(select$);

var app$ = openSeq$
    .ignoreElements()
    .concat(appSetup$)
    .let(function(o) { return new RxQ.qixObservables.AppObservable(o, "warm");})

Would be nice if we had an operator that could take in an Observable that completes and on complete, then starts passing the app. so the above could be come something like:
var appSetup$ = eng$.qOpenDoc("20108945-04ae-4ead-a99b-3d65142b6412");

var field$ = appSetup$.qGetField("RoomLocation");

var lock$ = field$.qLock().take(1);
var select$ = field$.qSelect("22Link", true).take(1);

var openSeq$ = lock$
    .concat(select$);

var app$ = appSetup$
    .qOnOpen(openSeq$);

Not sure if qOnOpen is the best operator name, or if it should be something like qWaitOnOpen, which is a little bit clearer about what will happen...

This will be moved to rxq-addons lib


[SR-13976] Updated diagnostic message for calling a mutating method

struct Hello {
    let message: String

    mutating func mutatingFunc() { }
}

var hello = Hello(message: "Hi")
let aaa = hello.mutatingFunc  //  compile error: partial application of 'mutating' method is not allowed

This message is not clear, will update the message to
partial application of calling a 'mutating' method without an argument list is not allowed

Bug: https://bugs.swift.org/browse/SR-13976
More context: https://forums.swift.org/t/compile-error-partial-application-of-mutating-method-is-not-allowed-what-is-partial-application/43163

@swift-ci  Please smoke test macOS platform

@swift-ci  Please test

Hey @karthikkmurugan
I think that there is an already on going PR for that issue #35466
But a note on this one is normally when updating a diagnostic we should find and update the associated tests for it as well :)

Hey @karthikkmurugan
I think that there is an already on going PR for that issue #35466
But a note on this one is normally when updating a diagnostic we should find and update the associated tests for it as well :)

@LucianoPAlmeida thanks for pointing this out :)  , was waiting for the tests to fail to address them. Will close this PR.. Thank you


test: fan out code generation

This seems to have problems of different jobs persisting the same files :(


Audio decoder Jupyter NoteBook

This PR contains a Jupyter Notebook example to showcase a simple audio decoder example.

@swetha097 Please address the review comments

Addressed the review comment

Addressed the comments

Added a comment

Have beautified the Notebook and added a display output. Please let me know if this needs more changes

@swetha097 are all the review comments addressed?

@swetha097 are all the review comments addressed?

All the comments have been addressed.

This is needed for audio doc PR

Accidentally closed it


Included library as supported component

SharePoint Framework v1.9.1 on wards supports library component. Included library in the type of supported component.
Category

[x] Content fix

Related issues:
What's in this Pull Request?
SharePoint Framework v1.9.1 on wards supports library component. Included library as the type of supported component for "yo @microsoft/sharepoint" as a command line option.
Guidance
Included library as the type of supported component for "yo @microsoft/sharepoint" as a command line option.

thx @nanddeepn, appreciated.


The inference time between svdq-int4-flux.1-dev and flux.1-dev(bf16) is almost the same in comfyui

Hi,
First of all, I must admit that nunchaku has made a huge contribution to the realm of diffusion models, helping people achieve low-cost and low-latency inference.
When I test the svdq-int4-flux.1-dev in comfyui, I found that the inference time between svdq-int4-flux.1-dev and flux.1-dev(bf16) is almost the same, 10.2s v.s 11.2s.
So I want to know if there are some problems here.
Basic information as below:

GPU: A100-SXM4-80GB
CUDA: 12.2
Generation size: (batch size:1, width: 768, height: 1280)

Note that I do not use INT4 text encoder to infer, could this be the resason?

I have tested INT4 text encoder to infer. Compared to the previous two sets of settings, the inference time for svdq-int4-flux.1-dev + INT4 text encoder is almost the same too (10.2s v.s. 11.2s v.s. 10.4s). Only the GPU inference memory has become less.

How did you successfully run on Comfyui?


⚠ Bofrost.lu has degraded performance

In a5ee562, Bofrost.lu (https://www.bofrost.lu) experienced degraded performance:

HTTP code: 200
Response time: 1611 ms

Resolved: Bofrost.lu performance has improved in 61e9411 after 13 minutes.


VAGRANT_NO_TRIGGERS seems to be ignored

hi, it seems that no matter if the VAGRANT_NO_TRIGGERS env var is set or not, scripts are executed.
cheers

Hi!
Just tried:
Cannonball:vagrant-triggers emyl$ vagrant up
Bringing machine 'default' up with 'virtualbox' provider...
==> default: Running triggers before up...
==> default: Executing command "uname -a"...
==> default: Darwin Cannonball.local 12.6.0 Darwin Kernel Version 12.6.0: Wed Mar 18 16:23:48 PDT 2015; root:xnu-2050.48.19~1/RELEASE_X86_64 x86_64
==> default: Command execution finished.
==> default: Checking if box 'puppetlabs/ubuntu-12.04-64-puppet' is up to date…
==> default: VirtualBox VM is already running.

Cannonball:vagrant-triggers emyl$ VAGRANT_NO_TRIGGERS=1 vagrant up
Bringing machine 'default' up with 'virtualbox' provider...
==> default: Checking if box 'puppetlabs/ubuntu-12.04-64-puppet' is up to date…
==> default: VirtualBox VM is already running.

Can you provide additional details or an example in order I can reproduce your error?

I'm closing this, feel free to reopen the issue if you can reproduce the error in some way.


Tracing does not work on Laravel 5.4

Followed the instructions to setup sentry on Laravel from https://docs.sentry.io/platforms/php/guides/laravel/configuration/other-versions/laravel5-6/.
After I finished the setup, I interact with my local environment but not seeing any transactions being logged into the "Performance" tab on sentry.

I do see the exceptions being reported and showing on sentry tho.
The php artisan sentry:test --transaction seems to work fine, the transaction is logged in sentry.
traces_sample_rate is set to 1.0

Any ideas?
Package versions:
"php": "7.3.24",
"laravel/framework": "5.4.36",
"sentry/sentry-laravel": "2.20",

Yes I think I know what is going on here, you need to add another service provider manually.
 'providers' => array(
     // ...
     Sentry\Laravel\ServiceProvider::class,
+    Sentry\Laravel\Tracing\ServiceProvider::class,
 ),

Let me know if that works, tracing has not yet been tested on 5.4.

that did not work, getting the following error:
(1/1) FatalThrowableError
Type error: Argument 1 passed to Sentry\Laravel\Tracing\ServiceProvider::wrapViewEngine() must be an instance of Illuminate\Contracts\View\Engine, instance of Illuminate\View\Engines\CompilerEngine given, called in /opt/foresight/vendor/sentry/sentry-laravel/src/Sentry/Laravel/Tracing/ServiceProvider.php on line 50

Jep, it does activate now but it is not compatible with Laravel 5.4 yet unfortunately.
I'll leave this open to track this request.

that did not work, getting the following error:
(1/1) FatalThrowableError
Type error: Argument 1 passed to Sentry\Laravel\Tracing\ServiceProvider::wrapViewEngine() must be an instance of Illuminate\Contracts\View\Engine, instance of Illuminate\View\Engines\CompilerEngine given, called in /opt/foresight/vendor/sentry/sentry-laravel/src/Sentry/Laravel/Tracing/ServiceProvider.php on line 50

I got the same error and solved it by disabling views tracing: tracing.views = false in config/sentry.php
So after adding Sentry\Laravel\Tracing\ServiceProvider::class to the app.php and disabling views tracing - it works fine for me and I can see new transactions in the Sentry dashboard

How do you exactly disable the views tracing? I've tried putting it this way within the config/sentry.php:
'tracing' => [
    'views' => false
]

But I've got this error instead:
The option "tracing" does not exist. Defined options are: "attach_stacktrace", "before_breadcrumb", "before_send", "capture_silenced_errors", "class_serializers", "context_lines", "default_integrations", "dsn", "enable_compression", "environment", "error_types", "http_proxy", "in_app_exclude", "in_app_include", "integrations", "logger", "max_breadcrumbs", "max_request_body_size", "max_value_length", "prefixes", "release", "sample_rate", "send_attempts", "send_default_pii", "server_name", "tags", "traces_sample_rate", "traces_sampler".

That should definitely work, which version of the Laravel integration are you using?

That should definitely work, which version of the Laravel integration are you using?

I'm currently using version 2.3.1

Try upgrading to at least 2.5.0 where that option was introduced.

Try upgrading to at least 2.5.0 where that option was introduced.

That solved it. Thank you so much for the help!


Internal Server Error

The time is currently 1:29 AM, the errors were encountered around 1:24 AM. This is Eastern US Time, -5:00 hours. I tried pasting this team and it doesn't work.
Mamoswine @ Metronome
Ability: Thick Fat
Shiny: Yes
EVs: 252 Atk / 4 SpD / 252 Spe
Jolly Nature

Earthquake
Ice Shard
Icicle Crash
Stealth Rock

Kartana @ Choice Scarf
Ability: Beast Boost
Shiny: Yes
EVs: 4 HP / 252 Atk / 252 Spe
Adamant Nature

Leaf Blade
Smart Strike
Knock Off
Sacred Sword

Gastrodon-East @ Leftovers
Ability: Storm Drain
Shiny: Yes
EVs: 248 HP / 8 Def / 252 SpD
Sassy Nature
IVs: 0 Atk

Scald
Recover
Toxic
Ice Beam

Clefable @ Leftovers
Ability: Magic Guard
EVs: 252 HP / 252 Def / 4 SpD
Bold Nature
IVs: 0 Atk

Moonblast
Soft-Boiled
Fire Blast
Calm Mind

Gyarados @ Gyaradosite
Ability: Intimidate
Shiny: Yes
EVs: 4 HP / 252 Atk / 252 Spe
Serious Nature

Dragon Dance
Earthquake
Crunch
Waterfall

Tornadus-Therian @ Flyinium Z
Ability: Regenerator
Shiny: Yes
EVs: 252 SpA / 4 SpD / 252 Spe
Timid Nature

Hurricane
Knock Off
U-turn
Defog

Hi @Storm-Eagle20, and thanks for letting me know about this. I'll hopefully have time to look into the root cause this evening, but in the meantime, here is your paste:
http://pokepast.es/01154ee19035c94d

Did you find the error by any chance? Would you also be willing to paste this one more time, instead fix Gyarados's nature? I accidentally made it Serious natured when it was intended to be Jolly. I forgot to change the nature before I pasted.

So uh... I found out the cause of the issue.  I am very, very sorry for wasting your time and I couldn't actually see the 'Paste something here' because of the glare on my TV. You should probably add some sort of exception to prevent notes-only pastes from going through.

All good! You're definitely not the only person to do that. I do think the website layout is a little unintuitive but people are largely used to it now so I'm hesitant to change it.


Fix emission calculation for spatial shader

I think, that current emission calculation is incorrect, or at least not convenient.
Current logic sums color and value from texture. That means, that you can't use texture as mask to make some parts of mesh emitting. Or you can use black color on texture to not emit, but color become useless. And you can't use it as tint to colorize emission.
I suggest to use texture as mask by multiplying it with color instead of summation.
Also I changed hint color for case, when you don't need a texture.

and here I was wondering why my emission mask does nothing in 3.0, thanks man!

Excellent! I have been meaning to create an issue for this. Look forward to trying it out :)

I thought it might be more useful the current way, but if you prefer this way I'm fine too. PR looks perfect.

I was thinking about it, and I'm not sure if this proposal is better. The rationale is the following:

Emission and Emission texture in general are not used together, this is rare
If using a multiplication, you will need to set emission to white besides setting a texture for it to work, I don't think this is very intuitive.
The only benefit I see this could have is controlling the intensity of the emission, but you can already do this with the energy color

So I think after thinking about it for a while, that this PR is a bad idea, it just makes emission more restricted.

Isn't the current behavior similar to how emission map works in Unity?

@reduz, I think the main benefit of multiplying is ability to change Color of emission using texture as mask.
And without multiplying you just can not colorize your emission by script. I think @Zireael07 and @fracteed was talking about that case.
And other engines works this way.
@tagcup, Unity works like in this PR, they uses multiplication.

@Zireael07 yes, but to have control on light color of that emission you need multiplication of emission texture and emission color

Then this would also mean that's how it works with Substance, right?

I'm still not convinced that it's more intuitive, I would probably just add an option to select the behavior..

I'm not exactly sure how this works with Unity or Substance (is there an official doc about it?), but based on this discussion, the current behavior in Godot apparently matches Khronos shader in their gltf exporter repo.

The current Godot implementation is also the one that physically makes more sense: in the absence of emission you should only get albedo (which is the reflected environmental light), and when you turn on an additional light source (which is the emission) it should just add to albedo.(electromagnetic waves add without interacting, neglecting quantum mechanical effects for bosons. also in reality, when you turn on the light source it will heat the object up changing transport properties a little such that the albedo will be slightly different but shouldn't be much.)

@reduz I would imagine that this is directly related to #10534

@reduz, I really don't know in what case it is convinient to have sum of emission color and texture. Maybe you can give an example of such use case? If it can be helpful in some situation, maybe to have an option is better idea. Because with current implementation it is impossible to do coloring of emission with mask.
@tagcup About Unity you can see here
You can see on screenshots, that when they use texture, they set color to white, because of multiplying.

I don't know whick picture you're referring to exactly but this one (from that page) is mostly black:
https://docs.unity3d.com/uploads/Main/StandardShaderEmissiveMaterialInspector.png

@tagcup: That's because it's partially a mask. Now if I were to apply this same picture as emission texture in Godot, the whole mesh would be emissive right now in 3.0 (and properly masked in 2.1.3).

Given there are good reasons for both use cases, I will do the following

Given how Godot exports the parameters, the current usage is more intuitive for creating materials, it allows setting a texture and making sure it works on the first try
Also given there is a valid use case in changing the emission mask color, I will add this as an extra option in the material.

@Zireael07 I must've misunderstood what Godot is currently doing then. So according to what you're saying, Godot is currently adding albedo as emissive color on top of the given emissive texture

@tagcup, as @Zireael07 sad, result is almost black. But on the right side you can see almost black texture with small green and orange squares, and to the left you will see white color
@tagcup, in current implementation Godot use color from texture plus emission color (and maybe plus Albedo). So when you are using emission texture, you can left emission color black. But in Unity you must set it to white, or other color to do coloring.
@reduz, good to know, that there will be an option to select behavior. Thanks

@reduz , I have just added flag to select to use multiplication or not. Could you see is it good enough option to accept?

Can you please squash the clang-format commit? It doesn't make much sense for the public git history. Other than that, @reduz is the multiplication flag that was implemented after your comment a good fix, should this be merged in this form?

What are we doing with this? Still unable to mask my emissions as of alpha 2...

I think this will be merged eventually since it adds a flag for users to choose whether they want additive or multiplicative mode.


[Feature request] Add support for custom  styling

Hey Alex, thanks for the awesome component you made.
In order to start this new year with an update on your repo, I'd like to suggest an improvement that would allow for deeper style customization:
Requested feature
Allow  custom <li> element styling.
Usecase
In the project I'm using treebeard right now, I'm displaying a pretty big tree (JSON data is approx 3600 lines). Having this much data makes it hard to scan the page easily because of the fact every single entry is on its very own line.
To make it easier on the eye, I'd like last-level children to have css display set to inline-block (last level means to me they have no children attribute, or that they have one, but the children array is empty).
Wtf? Can you be more specific?
Yeah, sure! So, basically in your example, that would be the files. They would no more behave as block elements, but as inline-block elements. Here's a screenshot with your original on the left, and how I would like things to be displayed on the right (left the console opened so you check the very basic styles I applied to files):

Please note that I didn't change any of your data to make this screenshot, but in my usecase, I'd put any file before folders in the data source so it's more logical when you display files as inline-block. So index.js would be listed first in src, and then the component folder (as it would make it easier to quickly spot which files belong to which folder when files are displayed first in the subtree). Same thing for Gulpfile.js index.js and package.json that are currently displayed last, they'd have to be listed first in the root folder.
Usage
I guess it's pretty simple how it could work, in my idea, you would simply add a new data attribute, like display that could be set to either "block" or "inline" (I'm omitting the -block here for brevity and I'm not sure that a display type of inline would ever be needed, so maybe the "-block" part could be optional).
Note
The only minor potential issue that I see is that you need to make sure the "activeLink" css can also be set to a custom style matching whatever padding / margins you decide to put on the inline-block elements.
Does that make any sense to you?

What did you find out about this Mat?


PLA filament

[x] Purchased
[ ] Received
[ ] Checked

Expected arrival: 13/01

All is going... according to PLAn..........I'll see myself out


Add instructions about how to get started with troubleshooting

Signed-off-by: samanthasusu<EMAIL_ADDRESS>
Added a section to the overall troubleshooting page

Your checklist for this pull request
🚨Please review the guidelines for contributing to this repository.

[ ] If the changes in this PR is part of the next future release, make this pull request against the docs-staging branch which will be published at the next release boundary. If the changes in this PR are part of the current release, use the default base branch, master. For more information about branches, see https://github.com/zowe/docs-site/tree/master#understanding-the-doc-branches.

[ ] If this PR relates to GitHub issues in docs-site or other repositories, please list in Description, prefixed with close, fix or resolve keywords.
close #2679

Description (including links to related git issues)
Please describe your pull request.
Added some instructions about how to get started with troubleshooting. Feel free to leave your comments. Thanks!
:heart:Thank you!

Sorry folks,  I merged this by mistake.   I had quite a few browser tabs open and was merging some other PRs and pushed this one by accident.
Going to try put this back with:

Restore the branch add-a-how-to-for-troubleshooting
Created https://github.com/zowe/docs-site/pull/2686 to revert this merged PR and then merge 2686 back to master which was done with a force.
For the last part @samanthasusu , can you please create a new PR for the branch add-a-how-to-for-troubleshooting as you're the original author ?  This will allow the review process to be re-started.   I can't see a way to get this PR's state to "unmerged" which is what I'd like, and reading github docs I think a new PR from the branch needs to be created fresh.

Sorry again for my mistake.  Cheers !

Sorry folks, I merged this by mistake. I had quite a few browser tabs open and was merging some other PRs and pushed this one by accident. Going to try put this back with:
* Restore the branch `add-a-how-to-for-troubleshooting`

* Created [Revert "Add instructions about how to get started with troubleshooting" #2686](https://github.com/zowe/docs-site/pull/2686) to revert this merged PR and then merge 2686 back to master which was done with a force.

* For the last part @samanthasusu , can you please create a new PR for the branch `add-a-how-to-for-troubleshooting` as you're the original author ?  This will allow the review process to be re-started.   I can't see a way to get this PR's state to "unmerged" which is what I'd like, and reading github docs I think a new PR from the branch needs to be created fresh.

Sorry again for my mistake. Cheers !

No worries Joe! Thank you for your review: )


Close p tag in templateinheritance docs

I noticed this when going through the docs.

The HTML is valid as is.


[SPARK-44963][PYTHON][ML][TESTS] Make PySpark (pyspark-ml module) tests passing without any dependency

What changes were proposed in this pull request?
This PR proposes to fix the tests to properly run or skip when there aren't optional dependencies installed.
Why are the changes needed?
Currently, it fails as below:
./python/run-tests --python-executables=python3 --modules=pyspark-ml
...
Starting test(python3): pyspark.ml.tests.test_model_cache (temp output: /Users/hyukjin.kwon/workspace/forked/spark/python/target/f6f88c1e-0cb2-43e6-980e-47f1cdb9b463/python3__pyspark.ml.tests.test_model_cache__zij05l1u.log)
Traceback (most recent call last):
  File "/Users/hyukjin.kwon/miniconda3/envs/vanilla-3.10/lib/python3.10/runpy.py", line 196, in _run_module_as_main
    return _run_code(code, main_globals, None,
  File "/Users/hyukjin.kwon/miniconda3/envs/vanilla-3.10/lib/python3.10/runpy.py", line 86, in _run_code
    exec(code, run_globals)
  File "/Users/hyukjin.kwon/workspace/forked/spark/python/pyspark/ml/tests/test_functions.py", line 18, in <module>
    import pandas as pd
ModuleNotFoundError: No module named 'pandas'

PySpark tests should pass without optional dependencies.
Does this PR introduce any user-facing change?
No, test-only.
How was this patch tested?
Manually ran as described above.
Was this patch authored or co-authored using generative AI tooling?
No.

It seems that python-ml UT fails. Could you re-trigger the failed test pipeline to make it sure?

I added optional into the PR title because numpy is required dependency for MLLib.

https://spark.apache.org/docs/latest/api/python/getting_started/install.html#dependencies

Merged to master.


feat: Add Blacklist logic on logout

Adds Blacklist logic
Adds JWT token_id to Blacklist table when calling /logout
Checks Blacklist table wherever Authorization: Bearer header is checked

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Please upload report for BASE (main@644567c). Learn more about missing BASE report.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #202   +/-   ##
=======================================
  Coverage        ?   88.23%
=======================================
  Files           ?      139
  Lines           ?     4734
  Branches        ?        0
=======================================
  Hits            ?     4177
  Misses          ?      557
  Partials        ?        0

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


 The library was installed using cocoapods

After some research I discovered that in order to use Alamofire with Swift 2.0 the swift branch should be used to checkout the code.
pod 'Alamofire', :git => 'https://github.com/Alamofire/Alamofire.git', :branch => 'swift-2.0'


@vue/compiler-core import @babel/types in type definition but missing in dependencies

Vue version
3.2.41
Link to minimal reproduction
https://github.com/trim21/vue-compile-core-missing-deps
there is a vue type shim
declare module '*.vue' {
  import type { DefineComponent } from "vue";
  const component: DefineComponent<{}, {}, any>;
  export default component;
}

Steps to reproduce
git clone https://github.com/trim21/vue-compile-core-missing-deps
cd vue-compile-core-missing-deps
npm i
npx tsc --noEmit

What is expected?
tsc type checking ok
What is actually happening?
[00:45:25] Starting compilation in watch mode...

node_modules/@babel/parser/typings/babel-parser.d.ts:14:23 - error TS2307: Cannot find module '@babel/types' or its corresponding type declarations.

14 ): ParseResult<import("@babel/types").File>;
                         ~~~~~~~~~~~~~~

node_modules/@babel/parser/typings/babel-parser.d.ts:22:23 - error TS2307: Cannot find module '@babel/types' or its corresponding type declarations.

22 ): ParseResult<import("@babel/types").Expression>;
                         ~~~~~~~~~~~~~~

node_modules/@vue/compiler-core/dist/compiler-core.d.ts:1:57 - error TS2307: Cannot find module '@babel/types' or its corresponding type declarations.

1 import type { BlockStatement as BlockStatement_2 } from '@babel/types';
                                                          ~~~~~~~~~~~~~~

node_modules/@vue/compiler-core/dist/compiler-core.d.ts:2:45 - error TS2307: Cannot find module '@babel/types' or its corresponding type declarations.

2 import type { Function as Function_2 } from '@babel/types';
                                              ~~~~~~~~~~~~~~

node_modules/@vue/compiler-core/dist/compiler-core.d.ts:4:33 - error TS2307: Cannot find module '@babel/types' or its corresponding type declarations.

4 import type { Identifier } from '@babel/types';
                                  ~~~~~~~~~~~~~~

node_modules/@vue/compiler-core/dist/compiler-core.d.ts:5:37 - error TS2307: Cannot find module '@babel/types' or its corresponding type declarations.

5 import type { Node as Node_3 } from '@babel/types';
                                      ~~~~~~~~~~~~~~

node_modules/@vue/compiler-core/dist/compiler-core.d.ts:6:37 - error TS2307: Cannot find module '@babel/types' or its corresponding type declarations.

6 import type { ObjectProperty } from '@babel/types';
                                      ~~~~~~~~~~~~~~

node_modules/@vue/compiler-core/dist/compiler-core.d.ts:8:30 - error TS2307: Cannot find module '@babel/types' or its corresponding type declarations.

8 import type { Program } from '@babel/types';
                               ~~~~~~~~~~~~~~

[00:45:27] Found 8 errors. Watching for file changes.

System Info
doesn't matter

Any additional comments?
This is fixed with @babel/types in deps.

It's by design I think. If you need TypeScript support then install it by yourself.

I added PR #10533 solving issue. It seems to come back here a lot (already 3 issues: #5625, #8917, and this) and technically if compiler-core depends on library it should have it in dependencies (as in my PR).
Requiring from users adding dev dependencies of some of their dependencies creates confusion, and after some time you end up with a lot of dependencies where you don't know anymore if it's needed or was added to fix some missing transitive dep.

See https://github.com/vuejs/core/pull/10533#issuecomment-2004112951


[12.x] ShouldBeUnique Does Not Universally Prevent Duplicates

Fixes #51798
This fix was suggested in the original PR which introduced ShouldBeUnique here. Specifically pulled inspiration from the gist linked in the comments of that PR.
I pulled the logic for shouldDispatch() from the prexisting method in the PendingDispatch class. However I noticed in #39302 that an additional
if (! Container::getInstance()->bound(Cache::class)) {
    throw new RuntimeException('Cache driver not available. Scheduling unique jobs not supported.');
}

Check was added before attempting to acquire a lock. I'm not sure if checking for this should be done here?
I also wasn't quite sure the best way to write tests for this (or where best to put them), as the logic is buried pretty deep into the Queue class and required a lot of mocks. I wrote a couple as a proof of concept, but would improve/add more if necessary (suggestions/help welcome).
Also potentially of note is that the shouldDispatch check happens during the callback for ShouldQueueAfterCommit jobs. This means that the uniqueness is checked after the transaction, not immediately. I would think this behavior is desired, but I'm not quite sure
Lastly, this is a breaking change, as it prevents jobs from being queued sometimes when they previously would have been, therefore I've opened the PR to master
NOTE: Removed testUniqueJobsAreNotDispatched as it seems like a faulty test to me? It's essentially dispatching the job unto the BusFake (which never executes the job, since it's a fake), attempting to run the job with the queue worker, then asserting that the job lock still exists. But if the job has already run (or run synchronously), the lock should have already been released

I would suggest re-targeting this for 11.x. Feels more like a bug than a breaking change.

@kellerjmrtn can you send this to 11.x? Thanks!


Dracula for GoAccess

I build a Dracula Theme for the Log-File Viewer GoAccess based on the 256 Colors Palette.
Link to the Repo:
Dracula for GoAccess
Hope someone like it :D

Hey, that's very cool! ✨
I just sent you an invitation to join the organization.
I also cloned your repository for Dracula's organization, so you can go ahead and delete or archive yours:

Your repository.
New repository.

Thanks for building this! 🎉

thanks for all.
my repo is archived.