Cursor hides as soon as last item is inserted

The cursor is removed from the pin field as soon as the last digit is entered and the password mask appears without the original input being shown first. The user input should be visible for a short period before being masked with a bullet.

Hi,
I get the point where you tell about the user input should be visible for a short period before being masked with a bullet. But what about the cursor being removed after the last digit?
I'll try and fix the password problem in maybe next 2-3 weeks. Thank you for raising it :) and have a good 2019.

I meant when the input to the pin field is completed the cursor disappears and it becomes unclear whether the pinView is currently in focus or not.

Thats intended behaviour. The focus part will be shown through the color of
the field whether its focused or not. You can see the color of the entire
field changes (just like textview) when the focus is lost
On Sun, 30 Dec 2018, 8:31 pm Manish Negi<EMAIL_ADDRESS>wrote:

I meant when the input to the pin field is completed the cursor disappears
and it becomes unclear whether the pinView is currently in focus or not.
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/poovamraj/PinEditTextField/issues/17#issuecomment-450566301,
or mute the thread
https://github.com/notifications/unsubscribe-auth/APLGGcLiFrx7_vewTV35kB-EKllHMlYdks5u-NVhgaJpZM4Zk9IQ
.

But what if one is not using a highlighted field? It feels as if the
pinView has gone out of focus after the last entry.
On Sun 30 Dec, 2018, 8:33 PM Poovamraj T T<EMAIL_ADDRESS>wrote:

Thats intended behaviour. The focus part will be shown through the color of
the field whether its focused or not. You can see the color of the entire
field changes (just like textview) when the focus is lost
On Sun, 30 Dec 2018, 8:31 pm Manish Negi<EMAIL_ADDRESS>wrote:

I meant when the input to the pin field is completed the cursor
disappears
and it becomes unclear whether the pinView is currently in focus or not.
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
<
https://github.com/poovamraj/PinEditTextField/issues/17#issuecomment-450566301
,
or mute the thread
<
https://github.com/notifications/unsubscribe-auth/APLGGcLiFrx7_vewTV35kB-EKllHMlYdks5u-NVhgaJpZM4Zk9IQ
.

—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/poovamraj/PinEditTextField/issues/17#issuecomment-450566412,
or mute the thread
https://github.com/notifications/unsubscribe-auth/ApKbzBRSTPozLBRQunZSbzNRiB-fs-Dwks5u-NXQgaJpZM4Zk9IQ
.

Hmmm, I get your point. I can make it in a way that if the highlight is
false, cursor will be there after the last text. But I guess positioning
the cursor after the text wont feel symmetric to the eyes. I'll see what I
can do about it.
On Sun, 30 Dec 2018, 8:41 pm Manish Negi<EMAIL_ADDRESS>wrote:

But what if one is not using a highlighted field? It feels as if the
pinView has gone out of focus after the last entry.
On Sun 30 Dec, 2018, 8:33 PM Poovamraj T T<EMAIL_ADDRESS>wrote:

Thats intended behaviour. The focus part will be shown through the color
of
the field whether its focused or not. You can see the color of the entire
field changes (just like textview) when the focus is lost
On Sun, 30 Dec 2018, 8:31 pm Manish Negi<EMAIL_ADDRESS>wrote:

I meant when the input to the pin field is completed the cursor
disappears
and it becomes unclear whether the pinView is currently in focus or
not.
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
<

https://github.com/poovamraj/PinEditTextField/issues/17#issuecomment-450566301

,
or mute the thread
<

https://github.com/notifications/unsubscribe-auth/APLGGcLiFrx7_vewTV35kB-EKllHMlYdks5u-NVhgaJpZM4Zk9IQ

.

—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<
https://github.com/poovamraj/PinEditTextField/issues/17#issuecomment-450566412
,
or mute the thread
<
https://github.com/notifications/unsubscribe-auth/ApKbzBRSTPozLBRQunZSbzNRiB-fs-Dwks5u-NXQgaJpZM4Zk9IQ
.

—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/poovamraj/PinEditTextField/issues/17#issuecomment-450566898,
or mute the thread
https://github.com/notifications/unsubscribe-auth/APLGGfqIdCx8trANtY90OBLgsvkC2vCOks5u-Ne7gaJpZM4Zk9IQ
.

Hey man, could you tell me why this pink icon appears on tapping the linePinField after it has been filled completely. This bubble lets the user to paste the pin even when it is disabled.

android:textSelectHandle="@drawable/text_handle"
put this in your xml and it will go away. It is documented in the README

Okay, thanks

+1

Since there will be a text there, I dont think it will be good for the UI to show a handle there.
You can use the following

app:fieldColor - This can be a dim color indicating that view is not in focus
app:highlightType="allFields" This will highlight the view when it comes into focus
app:highlightColor="@color/colorAccent" This can be used to determine the highlight color

Do let me know if you need any help with this implementation.


Warning message about rexml

Receiving notifcations about a vulnerability in Ruby.  Is this something that I need to take care of or is it something that will be addressed via update or otherwise by GBIF?
Full notification:
https://github.com/gbif/hp-vertnet-plus/security/dependabot/Gemfile.lock/rexml/open

We will look at it and most likely update all sites. You are also welcome to do so for your own site.

The dependency was updated


Added support for Global settings

Used the option object of grunt with the keyword "globals"
A example of the feature would be the following code, in that way we can override the configuration of Juice.
options: {
      preserveMediaQueries: true,
      applyAttributesTableElements: true,
      applyWidthAttributes: true,
      preserveImportant: true,
      preserveFontFaces: true,
      globals : {
          styleToAttribute : {
                'background-color': 'bgcolor',
                'background-image': 'background',
                'text-align': 'align',
                'vertical-align': 'valign',
                'border': 'border',
                'cellpadding': 'cellpadding'
            }
        }
    }

looks good. thanks!

I took the liberty of doing some clean up of the control flow statements and i just published 0.1.4. Thanks again for the help :smile:

Awesome, Thanks for include the pull request :)
Would be great if you can add some examples or documentation in the README file, in that way the people could use the new features.
Good job


Expose fine-grained metrics

Is your feature request related to a problem? Please describe.
Currently Kepler exposes energy consumption metrics and also metrics related to cpu utilization, bpf and cgroups. Giving the option to publish more fine-grained node metrics as CPU operating frequencies, CPU temperature, CPU time spent in a c-state, power consumption of processor package, among others would give more information for monitoring systems to act.
Describe the solution you'd like
Create new metrics for data coming from msr, rapl, cpufreq and uncore frequency. Most of these data sources is already being used by Kepler so the idea is read new data from them, create the metrics and add flags to enable/disabling them.
Additional context
I would like to contribute to the project by working on this feature. There is already a metric for the current frequency of CPU (kepler_node_cpu_scaling_frequency_hertz) and I'm thinking in use it as a model to include the others metrics.
Studying the code I saw that if RAPL is enabled the MSR is not read (https://github.com/sustainable-computing-io/kepler/blob/v0.4.11/pkg/power/components/power.go#L51). To add other metrics it would be necessary to read from MSR and also include the reading of intel-uncore-frequency data.
Looking at the issues there are other related requests (#669, #68)

Thanks for the info. Some of the metrics are available in node_exporter too. If you can come up with a proposal of the metrics that help understand the cpu energy and performance, that'll be great.

Thank you @rootfs. I will create a PR giving more details about the metrics.

Hi @rootfs,
Based on the metrics provided by Linux rapl metricset, collected turbostat plugin and Intel PowerStat Input Plugin my initial idea is to add the following information:

package_power_consumption_watts: Current processor package power consumption in Watts (rapl).
package_power_dram_consumption_watts: Current processor package DRAM subsystem power consumption in Watts (rapl).
package_tdp_watts: Thermal Design Power (TDP) for processor package in Watts (rapl).
package_cpu_base_frequency_mhz - cpu base frequency for the processor package in Mhz.
package_uncore_frequency_mhz: Current uncore frequency for the processor package in Mhz (intel_uncore_frequency).
cpu_mininum_frequency_mhz: Minimum cpu frequency setting in MHz.
cpu_maximum_frequency_mhz: Maximum cpu frequency setting in MHz.
cpu_scaling_frequency_hertz: Current average cpu frequency in Hertz (cpufreq) - Already implemented.
cpu_busy_frequency_mhz: Current cpu busy frequency in MHz (msr).
cpu_c0_state_percent: Percent of time that cpu spent in C0 state (msr).
cpu_c1_state_percent: Percent of time that cpu spent in C1 state (msr).
cpu_c6_state_percent: Percent of time that cpu spent in C6 state (msr).
cpu_temperature_celsius: Current temperature of cpu in Celsius (msr).

For settings information, as max and min frequency, I am thinking to include them in kepler_node_nodeInfo (kepler_node_info).

@fshiga-01 looks good. For node level metrics, please use kepler_node_ prefix, and container level with kepler_container_


Python3 doesn't work on 2020.6 Linux

With every python from 3.6-3.9 in TRIK_PYTHONPATH the next error occures:
./trik-studio: line 14: 18983 Segmentation fault      (core dumped) bin/trik-studio "$@"

Superseded by #1329 with latest fixes


Redo drop does not work for single file

Testing #111015
Ubuntu

In the Ubuntu file explorer, select a file a drop in the VSCode explorer
from the window menu, run Edit > Undo. Copy is undone :heavy_check_mark:
from the window menu, run Edit > Redo. Nothing happens

Interestingly, dropping 2 files and undo - redo works

For me I see something differently. In the last step the Redo works, however the file is brough back empty.
This is due to the fact that we pass true here as the _undoesCreateOperation https://github.com/microsoft/vscode/blob/f4187f22026ff6537f2ca8132ad3209fceb5071f/src/vs/workbench/contrib/bulkEdit/browser/bulkFileEdits.ts#L97
I have verified that passing false here actually fixes the issue.
Though I know @jrieken introduced this flag for a reason. Thus also assigning this issue to him

@isidorn Using false should be OK for that case. Basically that is there to know if delete in undoing a create operation. Create should be understood as "create empty file", not as copy or as re-create after delete.

@jrieken thanks. Pushed that fix then
@aeschli I understand I did not fix 100% the issue you were seeing, but a similar issue. However still closing this, and you can try with latest out of source and let me know if you still see something strange. I believe your original issue was also connected to the focus and is basically a dupe of https://github.com/microsoft/vscode/issues/111640

Thanks @isidorn. This is why all of this is so complicated: https://github.com/microsoft/vscode/issues/107379. The gist is that undo of create should only restore contents when create was invoked with contents, not if the context came later. Using your changes I have re-verified #107379 and things are happy

Thanks for re-verifiying.

Verified that setting the focus on the explorer solves the issue.


Lower Node Engines to >=6?

Like GoogleChrome/lighthouse engines setting

we are using async await so the lowest is 7.6.0

How about we lower it to 7.6.0 and add a note under Run from CLI like GoogleChrome/lighthouse with:
Lighthouse-security requires Node.js 7.6.0 or later.
lighthouse-security <url> [options]

If you're using Node < 7.6 you can use babel-node:
babel-node lighthouse-security <url> [options]


feat: AU-2205, AU-2206: E2E, Fixed problems with number inputs and file uploads.

AU-2205, AU-2206
What was done
We've had a long lasting problem where data entered to various input fields would be missing part of its value when validation was being performed. I did some digging and came to the conclusion that this most likely has to do with page Hydration. My guess is that Playwright would start filling in values to the form before the form and its elements were fully loaded, leading to a state of flaky inputs. I have added various .waitFor({state: 'visible'}) implementations to the listed functions below in order to ensure that the elements are fully loaded before data is being entered.
What has changed

Refactored clickButton() (waiting for visible state).

Refactored data-drupal-selector-sequential (waiting for visible state).

Refactored fillDynamicMultiValueField and fillMultiValueField  (waiting for visible state).

Added various page.waitForLoadState() implementations before filling out a form page.

Refactored hideSlidePopup and removed unnecessary calls to it.

Removed the default value for filePath in uploadFile() (seems to have caused a bug where the wrong file would sometimes be uploaded).

Fixed a few tests that had incorrect data or were entering data with the wrong methods.

How to install
Make sure your instance is up and running on correct branch.

git checkout feature/AU-2205-e2e-entered-numbers-bug
make fresh
make drush-cr

How to test

Add this to the .test_env file so that only draft tests run (we only care about draft tests since those are the ones that get validated):
DISABLED_FORM_VARIANTS="success", "missing_values", "wrong_values", "under5000", "wrong_email", "wrong_email_2", "wrong_email_3"

Run make test-pw and let all the draft tests run. Make sure all pass.

Läpi meni kaikki.


docs: Reorganize sections and pages about contributing to Zulip.

We should rearrange Zulip's developer docs to make it easier to find the documentation that new contributors need.
Name changes
Rename Code contribution guide section -> "Contributing to Zulip".
Rename Contributing to Zulip page -> "Contributing guide".
Organizational changes to the newly-named "Contributing to Zulip":
Move the newly-named "Contributing guide" to the top of this section.
Move up "Zulip code of Conduct", as the second link of this section.
Move down "Licensing", as the last link of this section.
Move "Accessibility" just below "HTML and CSS" in Subsystems section.
Update all links according to the changes above.
Redirects should be added as needed.
Fixes: #22517.
Screenshots and screen captures:

Self-review checklist

[x] Self-reviewed the changes for clarity and maintainability

Communicate decisions, questions, and potential concerns.

[x] Explains differences from previous plans (e.g., issue description).
[x] Highlights technical choices and bugs encountered.
[x] Calls out remaining decisions and concerns.
[x] Automated tests

Individual commits are ready for review (see commit discipline).

[x] Each commit is a coherent idea.
[x] Commit message(s) explain reasoning and motivation for changes.

Completed manual review and testing of the following:

[x] Visual appearance of the changes.
[x] Responsiveness.
[x] Strings and tooltips.
[x] End-to-end functionality of buttons, interactions and flows.
[x] Corner cases, error conditions, and easily imagined bugs.

@alya ready for your review.
The following ./tools/test-documentation error is expected as the link doesn't exist yet.
[documentation_crawler] ERROR: Please check link: https://zulip.readthedocs.io/en/latest/contributing/contributing.html

The following redirects need to be added:
https://zulip.readthedocs.io/en/latest/overview/contributing.html -> https://zulip.readthedocs.io/en/latest/contributing/contributing.html

https://zulip.readthedocs.io/en/latest/contributing/accessibility.html -> https://zulip.readthedocs.io/en/latest/subsystems/accessibility.html

The screenshots look good to me! @laurynmm would you be up for reviewing this one?

These changes look good to me. I had one question about two links in CONTRIBUTING.md that could be links within that file instead of links to the readthedocs version.

I think these were external links because there used to be an issue with the old Markdown parser where links wouldn't work correctly either on GitHub or ReadTheDocs if they were originally formatted as internal links. But it looks like this issue has been fixed with the new Markdown parser.
I've converted the external links you pointed out to internal links and tested them to make sure they work both on GitHub and ReadTheDocs. Thanks!

Looking at the docs index sidebar, I think that this new 'Contributing to Zulip' section could be third (after 'Zulip in production', before 'Development environment'). See screenshots below.

That ordering looks reasonable to me too.  @alya  what do you think?

If it wouldn't be a headache, could we rename CONTRIBUTING.md to CONTRIBUTING_GUIDE.md? I think that would still make sense as a file in the github repo, and then the readthedocs urls could be contributing/contributing-guide.html vs contributing/contributing.html. But if that would be more problematic with redirects, then I wouldn't worry about it.

It looks like it wouldn't be that difficult to rename this file too. But it seems like it's turned into a convention to use the word "contributing" by itself. I wasn't sure so I googled it and found a couple of articles from GitHub and Mozilla about it:
https://docs.github.com/en/communities/setting-up-your-project-for-healthy-contributions/setting-guidelines-for-repository-contributors
https://mozillascience.github.io/working-open-workshop/contributing/#introduction
I think we should keep it as CONTRIBUTING.md.

It looks like it wouldn't be that difficult to rename this file too. But it seems like it's turned into a convention to use the word "contributing" by itself. I wasn't sure so I googled it and found a couple of articles from GitHub and Mozilla about it: https://docs.github.com/en/communities/setting-up-your-project-for-healthy-contributions/setting-guidelines-for-repository-contributors https://mozillascience.github.io/working-open-workshop/contributing/#introduction
I think we should keep it as CONTRIBUTING.md.

Yeah, based on that information, I agree.

I agree with @laurynmm 's suggestion about reordering the sections in the left sidebar. Once that's done (if it hasn't been already) and the PR passes tests, it should be ready for integration review. Thanks!

I agree with @laurynmm 's suggestion about reordering the sections in the left sidebar. Has that been done already? If so, the PR should be ready for integration review.

Done!
@zulipbot add "integration review"

The CI failure is one of those things that will cease happening as soon as the ReadTheDocs build finishes after merging.
I split this commit into 5cac44be06c29929acb02771ef440eb4719e5312, which I've just merged, and a follow-up commit that I'll merge once the ReadTheDocs build finishes.

I suppose there's a question of whether we want that page to be something more like /contributing/guide.html; not sure if it's worth making that change now given I've already merged the first commit here.

Build complete and redirect installed, so I've merged this as well.


text/template: documentation: "pipeline" is never defined clearly

Referring to: https://golang.org/pkg/text/template/
In the "action" section it says:
Here is the list of actions. "Arguments" and "pipelines" are evaluations of data, defined in detail below.

and later
{{pipeline}}
	The default textual representation of the value of the pipeline
	is copied to the output.

in the pipeline section it says
Pipelines

A pipeline may be "chained" by separating a sequence of commands with pipeline characters '|'. In a chained pipeline, the result of the each command is passed as the last argument of the following command. The output of the final command in the pipeline is the value of the pipeline.

The output of a command will be either one value or two values, the second of which has type error. If that second value is present and evaluates to non-nil, execution terminates and the error is returned to the caller of Execute.

From this, it sounds like a pipeline is the result of a command but it is not stated clearly. The first sentence of the pipelines section should start off with a definition of what it is.

I've never been a big template user but on the rare occasions where I do use the package, I immediately re-read the docs and have also been often confused by this.
/cc @robpike @adg


feat: (pack) Added Port monitoring

Summary
Added dashboard images and json file.
Pre merge checklist

[x] Did you check you NRQL syntax? - Does it work?
[x] Did you check your dashboard image quality? -  Do they look good?
[x] Did you check that your alerts actually work?
[x] Did you include an InstallPlan and Documentation reference?
[x] Did you check your descriptive content for voice, tone, spelling and grammar errors?
[x] Did you attach images of your dashboards to the PR so we can see them working?

Not sure why this PR included commits from main. Closing this and making a new one!


melody field editor ready for code gen

the 8 notes of a melody tile are encoding as a string, where each character has one of 9 possible values:

"." means no note plays (rest)
"7" is C
"6" is D (whole note above C)
"5" is E
down to "0", which is the C one octave above the initial C ("7")

In the image below, you can see a sequence of three melody tiles. The first one is encoded by the string "76543210", so does the major scale going up from C to octave above. in the second tile, each note is repeated, going down step by step("00112233".) In the third tile, we skip some notes ("44..6677")

I've hidden this block under options.melody until the codegen is in place.

Thanks!
Get Outlook for iOShttps://aka.ms/o0ukef

From: Peli de Halleux @.>
Sent: Thursday, October 20, 2022 1:18:16 PM
To: microsoft/microcode @.>
Cc: ramseyball @.>; Author @.>
Subject: Re: [microsoft/microcode] melody field editor ready for code gen (Issue #325)
I've hidden this block under options.melody until the codegen is in place.
—
Reply to this email directly, view it on GitHubhttps://nam12.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fmicrosoft%2Fmicrocode%2Fissues%2F325%23issuecomment-1285896784&data=05|01||b1b8797ca5cf458bf85908dab2bf1401|84df9e7fe9f640afb435aaaaaaaaaaaa|1|0|638018830984840602|Unknown|TWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D|3000|||&sdata=Ets9auwv3BVueu6KvoXWP7ksVV7sPnV8B4i0fNr70eA%3D&reserved=0, or unsubscribehttps://nam12.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FAARF5JUDKKNZLXVL2IZOXMDWEF5FRANCNFSM6AAAAAARKEDKO4&data=05|01||b1b8797ca5cf458bf85908dab2bf1401|84df9e7fe9f640afb435aaaaaaaaaaaa|1|0|638018830984840602|Unknown|TWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D|3000|||&sdata=vDL5BUMtDNjwHbl3dY8kbf18JCvcTfUjjbwnAJfJia4%3D&reserved=0.
You are receiving this because you authored the thread.Message ID: @.***>


Roll Flutter Engine from 752b146df767 to f4c20e97e6aa (2 revisions)

https://github.com/flutter/engine/compare/752b146df767...f4c20e97e6aa
2024-04-28<EMAIL_ADDRESS>[Impeller] remove image upload from IO thread, limit concurrent worker threads. (flutter/engine#52423)
2024-04-28<EMAIL_ADDRESS>[Impeller] when creating new pipeline variant block on current thread, re-persist dirty pipeline cache. (flutter/engine#52375)
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jimgraham@google.com,rmistry<EMAIL_ADDRESS>on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

Reason for revert: Crash in framework CI https://ci.chromium.org/ui/p/flutter/builders/prod/Linux_pixel_7pro new_gallery_opengles_impeller__transition_perf/2417/overview


[Do not merge] CWP-49700: Create console_defender_health.md

Description
Use case for Console and Defender health
Motivation and Context
https://redlock.atlassian.net/browse/PCSUP-13813
How Has This Been Tested?
On a local machine
Types of changes

New feature (non-breaking change which adds functionality)

Checklist

[x] I have updated the documentation accordingly.
[x] I have read the CONTRIBUTING document.
[x] I have added tests to cover my changes if appropriate.
[x] All new and existing tests passed.

@sserrata and @blindaa121 : Can you please approve this? I need to publish with the upcoming Maxwell Update 3.


[ET-4519] Remove OPD endpoints

Removes:

activities/following
activities/:id/related
athletes/:id/following
athletes/:id/friends
athletes/:id/both-following

Specifies that these endpoints are only available to the authenticated athlete:

segment_efforts/:id
segment_efforts/:id/streams
segments/:id/all_efforts
athletes/:id

Completes ET-4519

👇  I have a feeling these failing specs have something to do with all of Julien's tokens being invalidated.


scale_y_flowCore_fasinh does not work with hexagonal binning

I first discovered this while working on #50, and so I will use an simplified version of the example there. First, starting with a simple plot
library(ggcyto)
data("GvHD")
fs2 <- GvHD[subset(pData(GvHD), Patient %in% 5:7 & Visit %in% c(5:6))[["name"]]]
autoplot(fs2, "Time", "FL3-H")

With the current trunk branch, this looks like this:

With the Bioconductor 3.8 branch, it looks like this:

Some differences in color scaling, but mostly the same plot.
Now, adding the arcsinh transform to the y axis using scale_y_flowCore_fasinh:
autoplot(fs2, "Time", "FL3-H") + scale_y_flowCore_fasinh(b = 1/5)

The result of this from Bioc 3.8 versions of the packages is this:

As expected, the transformation is performed and then the hexagonal partitioning is performed on the transformed scale. However, with the current trunk branch, we get this:

It appears that something is going wrong in binning on y after the axis was rescaled. I have been doing some hunting for a commit on our end (in ggcyto, flowWorkspace, flowCore) that could have changed this behavior, but have not had any success. I have also not had any success after reverting ggplot2 before potentially relevant commits to see if it's anything on their end.
I'll keep trying to track it down and post on any progress here.

sessionInfo() for the Bioc 3.8 Docker container (where the plot is successful):
R version 3.5.2 (2018-12-20)
Platform: x86_64-pc-linux-gnu (64-bit)
Running under: Debian GNU/Linux buster/sid

Matrix products: default
BLAS: /usr/lib/x86_64-linux-gnu/blas/libblas.so.3.8.0
LAPACK: /usr/lib/x86_64-linux-gnu/lapack/liblapack.so.3.8.0

locale:
 [1] LC_CTYPE=en_US.UTF-8       LC_NUMERIC=C
 [3] LC_TIME=en_US.UTF-8        LC_COLLATE=en_US.UTF-8
 [5] LC_MONETARY=en_US.UTF-8    LC_MESSAGES=en_US.UTF-8
 [7] LC_PAPER=en_US.UTF-8       LC_NAME=C
 [9] LC_ADDRESS=C               LC_TELEPHONE=C
[11] LC_MEASUREMENT=en_US.UTF-8 LC_IDENTIFICATION=C

attached base packages:
[1] stats     graphics  grDevices utils     datasets  methods   base

other attached packages:
[1] ggcyto_1.10.2             flowWorkspace_3.30.2
[3] ncdfFlow_2.28.1           BH_1.69.0-1
[5] RcppArmadillo_0.9.700.2.0 flowCore_1.48.1
[7] ggplot2_3.2.1

loaded via a namespace (and not attached):
 [1] pcaPP_1.9-73        Rcpp_1.0.2          plyr_1.8.4
 [4] RColorBrewer_1.1-2  pillar_1.4.2        compiler_3.5.2
 [7] DEoptimR_1.0-8      BiocManager_1.30.4  zlibbioc_1.28.0
[10] tools_3.5.2         tibble_2.1.3        gtable_0.3.0
[13] lattice_0.20-38     pkgconfig_2.0.2     rlang_0.4.0
[16] graph_1.60.0        Rgraphviz_2.26.0    parallel_3.5.2
[19] mvtnorm_1.0-11      hexbin_1.27.3       gridExtra_2.3
[22] stringr_1.4.0       withr_2.1.2         dplyr_0.8.3
[25] cluster_2.1.0       IDPmisc_1.1.19      stats4_3.5.2
[28] grid_3.5.2          tidyselect_0.2.5    data.table_1.12.2
[31] glue_1.3.1          robustbase_0.93-5   Biobase_2.42.0
[34] R6_2.4.0            rrcov_1.4-7         XML_3.98-1.20
[37] latticeExtra_0.6-28 purrr_0.3.2         corpcor_1.6.9
[40] magrittr_1.5        scales_1.0.0        matrixStats_0.54.0
[43] BiocGenerics_0.28.0 MASS_7.3-51.4       assertthat_0.2.1
[46] colorspace_1.4-1    labeling_0.3        KernSmooth_2.23-15
[49] stringi_1.4.3       flowViz_1.46.1      lazyeval_0.2.2
[52] munsell_0.5.0       crayon_1.3.4

The problem is not confined to scale_y_flowCore_fasinh, as a similar issue occurs with scale_y_flowjo_biexp.
autoplot(fs2, "Time", "FL3-H") + scale_y_flowjo_biexp()

But curiously, it does not for scale_y_flowJo_biexp

which is odd, as scale_y_flowJo_biexp is now just a deprecation redirect to scale_y_flowjo_biexp. It may be an issue of handling ... or default args.

Nevermind. It looks like this is an issue for any scaling of the y axis, including scaling functions from `ggplot2.
autoplot(fs2, "Time", "FL3-H") + ggplot2::scale_y_log10()

That works fine in Bioc 3.8, though.

Looks like 2974b47506b4ac9bd19715d95d752d863cddbe23 is the breaking commit, which makes sense based on the commit message. Working on the fix.

After 0a2ed8a, it looks good:

The explicit calculation of binwidths added by 0e576c25a0a096d8ab1b62690747a72eb432d50f and 16ca1c203a89fb36166e6ec960b000f7b42b9b8f just weren't accounting for the transformed axes. The reference images for the tests need to be updated, but I verified that it is no more than they needed to before this commit.


api: introduce api/{types, services} for deduplication of API definition

Process and State (Status) were redundantly defined in execution.proto and shim.proto.
This PR deduplicate them by adding common.proto subpackages called types and services, according to #509.
This is just a baby step, and we need to refine the *.proto files.
Signed-off-by: Akihiro Suda<EMAIL_ADDRESS>

Codecov Report

Merging #504 into master will not change coverage.

@@          Coverage Diff           @@
##           master    #504   +/-   ##
======================================
  Coverage    62.5%   62.5%
======================================
  Files           3       3
  Lines         304     304
======================================
  Hits          190     190
  Misses         79      79
  Partials       35      35

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 42a17f9...85e1dc9. Read the comment docs.

Let's make sure to follow the path convention. These should be in api/common Go package.
All the protobufs are in the same protobuf package though (containerd.v1).

@AkihiroSuda I filed  #509 with the proper layout.

updated PR

LGTM after adding a warning banner on generated items.
I really don't like generating the gen.go file. I know it is a pain to get right but you only have to do it once. We can go forward with it, but if it grows any further or gets in the way, I'll rip it out. :hamster:
Thanks for the great PR!

Thank you for the feedback.
Updated PR so that tools/gen-pb-go.sh directly executes protoc, rather than generating gen.go.
PTAL.

Updated PR so that tools/gen-pb-go.sh directly executes protoc, rather than generating gen.go.

This is the opposite of what I meant and this is the exact path I was concerned about going down.
Please undo this. The gen.go files are the right approach.

OK, reverted PR to generate gen.go. PTAL.

LGTM
Let's just merge this. I can fix all the broken stuff later.


FileTarget - ConcurrentWrites should use FileStream.Length in archive-check

FileStream.Length already resolves to API GetFileSize using existing handle. Avoid creating new file-handle with FileInfo-object for each logevent.
Also only performs single lookup of FileAppender GetFileLength when archive-on-size (instead of two)
Also skips lookup of FileAppender.GetFileLength when archive-on-size is disabled (only doing day-roll)
Instead added bonus FileInfo.Exists check when time to archive to verify the file-handle is still valid.
Removed FileCharacteristicsHelper since it is no longer needed.
Performance measurements shows that KeepFileOpen=true + ConcurrentWrites=true will get a nice improvement. Especially on NetCore-platform where it will be 250 times faster.

Build
KeepFileOpen=false
KeepFileOpen=true + ConcurrentWrites=true + ForceManaged=true
KeepFileOpen=true + ConcurrentWrites=true
KeepFileOpen=true + ConcurrentWrites=false

NLog 4.6.8
291 msgs/sec
342 msgs/sec
93.745 msgs/sec
1.152.752 msgs/sec

PR
307 msgs/sec
102.842 msgs/sec
138.616 msgs/sec
1.120.221 msgs/sec

Nice a lot of code has been removed :)
Maybe good idea to do a performance test?

Maybe good idea to do a performance test?

Will make a test when the PR-nuget-package is ready.

@304NotModified Updated the initial-post. Looks like it will help a lot on the NetCore-platform


Generate OpenAPI response documentation

@unaguil
Hello! Can you leave some feedback on this PR? I would love to get it merged so I can start using sphinx-swaggerdoc, and would be happy to make whatever changes you think is necessary.

Hi @werwty,
Thank you very much for your contribution. I currently checking the functionality and I will integrate it as soon as possible.

Hi again @werwty,
It seems that your code does not correctly process the following example from Swagger (http://petstore.swagger.io/v2/swagger.json). I need to check the Swagger specification but it appears that 'responses' do not always include an 'schema' property, however, expected by your code.

@unaguil I've pushed a new commit, schema and schema properties are optional and the properties table will only be displayed when it is provided.

@werwty @unaguil There is also some work done here on this issue; not sure if the author is going to submit a PR but the code may have something useful.

Thank you for your contribution @werwty


Fix EOM for SendFile

To terminate a connection of varlink, say after sending a file, we need to send a message containing a delimiter of ':' so the client knows to hang up.
Fixes: #6237
Signed-off-by: Brent Baude<EMAIL_ADDRESS>

Gating is angry. Otherwise LGTM

/lgtm


(PDB-2969) Release notes for 4.2.1

Test FAILed

k looks good to me now

Test PASSed

Test PASSed


added notes about htmlAttributes for Editor/EditorFor

Fixes #2009

@ardalis,
Thanks for having already signed the Contribution License Agreement. Your agreement was validated by .NET Foundation. We will now review your pull request.
Thanks,
.NET Foundation Pull Request Bot


Order operations in AddMemberTx per UID

Enforce strict membership ordering by saving seqno per UID.
In AddMemberTx, remember in which payload given UID was affected last and do not queue operations affecting that UID in payloads prior.
Adds reflection code in transactions.go so the findPayload func does not have to be repeated 3 times for 3 types of payload.
Example of what this is trying to solve:
Assume a transaction that tries to do the following, in this order:

Add alice as crypto member,
sweep old bob@keybase invite (pukless member),
add bob as crypto member.

Currently, this would post two signatures:

change_membership { add: [ alice, bob ] }
invite { cancel: [ bob@keybase ] }

With this PR, it's going to post:

change_membership { add: [ alice ] }
invite { cancel: [ bob@keybase ] }
change_membership { add: [ bob ] }

Ideally, we should be posting (assuming add of alice does not depend on anything else), but this would be a bigger rewrite.

invite { cancel: [ bob@keybase ] }
change_membership { add: [ alice, bob ] }

Thanks for the example. In the example it used to post 2 links but now posts 3. Why is this better?

In this example:

change_membership { add: [ alice, bob ] }
invite { cancel: [ bob@keybase ] }

If there's old version of bob as pukless member before 1 is posted, then after 1 is posted there will be two bobs in the team. Which we allow right now, but we try to avoid to ultimately block this on the server at later time.

@mlsteele can you take another look? thanks


Fix time type constant push down

Now java.sql.Date type constant type is able to be pushed down since TiConstant.toProto logic changed.
Refer to https://github.com/pingcap/tispark/issues/133

This change is

Working to support timestamp type push down.

Seems we need to distinguish Timestamp from DateTime in spark, the former has to consider timezone information, but currently they may all be represented by TimeStampType in spark.

Verifying this behavior with @birdstorm

@birdstorm PTAL if my time conversion logic has any problem, thx!

will add more tests before merging

@Novemser PTAL

LGTM @birdstorm

It is recommended to add more unit test cases, I'm working on it.

Refer to https://github.com/pingcap/tispark/pull/146

TPCH
Tests run: 21 Tests succeeded: 21 Tests failed: 0 Tests skipped: 0
DAG
Tests run: 7311 Tests succeeded: 3743 Tests failed: 8 Tests skipped: 3560


Repo sync for protected CLA branch

The pull request is created from master637342339134057249 to master to fix git push error for protected CLA branch

@ghogen : Thanks for your contribution! The author(s) have been notified to review your proposed change.


"evictions" counter doesn't include evictions caused by slab reassignment

"evictions" is exclusive of "slab_reassign_evictions_nomem". Arguably it makes sense either way, but if someone is monitoring sets/deletes/evictions to get an idea of how items are flowing in or out of the cache, they would want to see these disappearing items counted as evictions.

I'm going to close this out as it's being dealt with via other PR's/issues. The nomem case will go away entirely in not too long, and the slab mover's gotten some fixes.


Develop

Fixed a crash about bbcode parsing, a window leak on login, and re-enabled api level 15 support.

Nice hfatih, so the bbcode parsing crash was an end tag showing up before a start tag? I wonder if it's people typo'ing on the forums.
Everything looks good except the change to WhatApplication that has the site url in it, can you change that back to an empty string? I'm not sure if there's a way to remove it from the git history but that would be best (to have it not show up at all). It's sort of an open secret but yea, should not be shown in the repo.

Oops. Created another PR without url now.


Handle changes to JLink.jar location

Howdy, @shadanan! I had an issue filed on my version of this bundle, because the JLink.jar location had apparently moved in some version of the Mathematica application bundle. I had a few minutes, so I used find to look up the path dynamically. Hope you're well!

I no longer have a copy of Mathematica, so I can't test this. I will accept it.


MystMD as an alternative to JupyterBook

Just documenting a new tool to be aware of, not necessary advocating we use it for hackweeks! But I came across this blog post via 2i2c slack about cross linking content across webpages (even interactive figures) which is pretty impressive.
https://curvenote.com/blog/open-science-reuse
There seems to be a lot of development going into mystmd currently more detail here
https://mystmd.org/guide/background
TLDR. mystmd is a javascript-based parser of "myst markdown" while jupyterbook is a python-based parser of "myst markdown".  jupyterbook uses sphinx behind the scenes which is mostly focused on technical software documentation, but mystmd is sticking more to web-development tools for fancy websites. And taken from the above docs:

Jupyter Books are an excellent medium for tutorials, textbooks & software documentation but are currently less well suited to content such as blogs, lab-websites, and journal articles. Additionally, JupyterBook cannot create scientific PDFs that are submission ready.

And the roadmap for jupyterbook v2 is to switch to the mystmd JavaScript tooling https://executablebooks.org/en/latest/blog/2024-05-20-jupyter-book-myst/


Better error formatting (plugins)

The current strategy for error formatting inside plugins is that plugins are responsible for their special formatting needs.
The following is fine, since Fly will catch that plugin's task's error and show some output, but in the future plugins should trace errors more gracefully.
module.exports = function () {
  return this.filter("pluginName", (src, opts) => {
    try {
      return ....
    } catch (e) {
      this.notify("plugin_error", { plugin: "pluginName", { ... } })
      throw e
    }
  })
}

Specially stack traces we can use prettyjson for the output.
I am thinking something along the lines of
function trace (e) {
  error(pretty.render(e)
    .replace(/(\sFunction|\sObject)\./g, `${fmt.blue("$1")}.`)
    .replace(/\((~?\/.*)\)/g, `(${fmt.gray("$1")})`)
    .replace(/:([0-9]*):([0-9]*)/g, ` ${fmt.yellow("$1")}:${fmt.yellow("$2")}`)
    .replace(new RegExp(process.env.HOME, "g"), "~")
  )
  return process
}

what about https://github.com/RReverser/better-log ?

@stryju Let's keep that one in the roadmap. As of 0.1.1 we have better stack tracing for fatal errors. Stills needs improvement though.

@stryju Closing this. I will look into better-log when we are ready to improve the stack tracing again.


Close multiselect by clicking on the input, not on the arrow

Reproduction Link
I understand that it is not necessary. I have reviewed the documentation and have not found an option for this.
Steps to reproduce
Expected behaviour
I need the selector to close when I click on the input.
Actual behaviour
Right now, I need to go to the arrow to close it.

I found the resolve for this.
https://github.com/kotte-sanya/PackageFrontend/blob/e90a37a91011a087c40e6ab2db439e2222ad891c/src/components/atoms/SearchMultiSelect.vue#L1


PDF export of slides with code-surfer doesn't seem to be supported

Is it only me or is the export to PDF not supported for slides that use the code-surfer library?

Possible duplicate of #183

With the changes in v2, Code Surfer will need to have a default view of showing whatever makes sense when steps === Infinity - closing this here, but feel free to continue the discussion on the Code Surfer repo


Pragmas for extensions

💡 Describe the solution you'd like
The pragma feature is great for selectively syncing settings based on the platform, I'd like to be able to do this for extensions too, for example enabling or disabling certain extensions which I don't need on certain operating systems. I don't think this is currently supported. I guess a workaround is to just install it and then disable, but a long term solution might be in the sync settings if that's a welcome feature.

Can't belive this is not implemented yet.
After setting up this extension the first thing I wanted to do was to define which extensions I want on my work pc and which ones on my personal pc.

+1 for this, some extensions are OS dependent


Changing radius of the Earth

When using non-Earth maps (eg https://www.openplanetary.org/opm-basemaps/opm-moon-basemap-v0-1 ) Leaflet assumes a default projection for the Earth.
This isn't necessarily a bad thing because at the scale of accuracy of these planetary projections the default Leaflet projection is "good enough"
Except that when adding something such as the Scale control, it shows the scale based on the Earth rather than the Moon.
Google maps provides an option to specify the Radius when adding an ImageMapType (see https://developers.google.com/maps/documentation/javascript/examples/maptype-image ) and it would be really useful to be able to provide the same functionality within Leaflet without having to create custom coordinate projection systems.
Alternatively, it may be simpler just to be able to override the planetary radius in the Scale control, which would be simple and effective.

... and it would be really useful to be able to provide the same functionality within Leaflet without having to create custom coordinate projection systems.

Nope.
Creating such a custom coordinate system is literally a one-liner:
L.CRS.MoonSphericalMercator = L.extend({}, L.CRS.EPSG3857, {R: 1737000});

Which is exactly the same amount of code a user would need in order to user such a proposed "change the radius" feature.
See a working example.

Thank you - I couldn't find example code to explain this anywhere.


Fix misspelled partial name

The partial name misspelled the word "functions" as "funcctions". This caused an error when running the latest build. The error was introduced in #2799.

Thanks - I had a fix locally which has been pushed as part of a larger refactor to create a Core and SEO modules (which the wowchemy module will automatically pull in): https://github.com/wowchemy/wowchemy-hugo-themes/commit/8cd28ca07fbda23771808fc30fe10a82480ec173


Feature: Resolution for "Row size too large" MySQL issue

With reference to #145
@tractorcow I have just come across the problem ref'd in #145 too. We have 359 columns! (10 locales) on one PageType. Removing a handful from the $translations static, and running dev/build "solves" the problem.
The problem seems to occur on MySQL ~5.7 (A colleague's Docker setup uses 5.7 whereas I use 5.5 and I do not see the problem). I'm not sure when this constraint was introduced - it kinda seems like it's always been there, but again, I'm running 5.5 and I do not see the issue.
MySQL has a row size limit of 64Kb But BLOB and TEXT types do not count towards this limit.
From mysql.com

"There is a hard limit of 4096 columns per table, but the effective maximum may be less for a given table. The exact limit depends on several interacting factors. "
"Every table (regardless of storage engine) has a maximum row size of 65,535 bytes. Storage engines may place additional constraints on this limit, reducing the effective maximum row size. "

Additional info: http://stackoverflow.com/questions/24275959/what-is-the-max-number-of-columns-per-table-for-mariadb
Question: What do you think of an alternative, perhaps left-of-field solution that I had; Adapt Fluent so it can be put into "structured" (or just a non-default) mode, then make use of some "structured content" e.g. JSON data, who's keys are named for the field to be translated taken from the
DataObject's $db static, and suffixed with "_EN", "_CN" (etc).
I've been meaning to write a JSONText type for some time as this solution lends itself well to some other interesting problems I come across sometimes. I've started work on a Structured Text module. N.b. a). It only partially works, b). As a result its not even alpha.
I'm only sharing it now to get feedback on the likelyhood of this module (or something like it) being useful for this bug.

I've thought about this, but we would have to disable a bunch of features, such as translated conditions (conditions only check the "default" locale).
Also, you would need to solve the issue of how to rewrite a SQLQuery so that the result would eventually extract the json column data. I can't see a mysql compatible solution, unfortunately. Postgres has native JSON columns, but if you're using postgres you wouldn't be having these issues in the first place. ;)
If you think this is an acceptable loss of functionality, then it could possibly be done.
There still remains the additional workaround of using additional tables.
class ObjectA extends ObjectB {
	private static $db = array(); // first half of your translated fields
}
class ObjectB extends DataObject {
	private static $db = array(); // other half of your translated fields
}

So I can see how the splitting-up classes method should work, but SS leaves pre-existing columns hanging-around, even if they're removed from the $db static (ether directly or by means of removing values from he $translate static).
So if like me, you've already got "too many" columns, wouldn't you just end-up creating even more columns (in total) leaving MySQL / MariaDB still thinking the row size of the original table (ObjectA) is too large? I'm just provisioning an SS VM via Packer and @halkyon's "packer-web" project so I'll see...

Yep, you gotta do it manually. :)

Then this isn't a solution - the site is already in PROD :-(

Hmmm maybe you could make a build task to flush / archive obsolete columns?

Yeah...that's what I'm looking at, I could roll my own, or mod someone else's - just spotted this: https://github.com/lekoala/silverstripe-devtoolkit/blob/master/code/tasks/DropUnusedFieldsTask.php

....it'd need to be DROP not archive (RENAME). Otherwise InnoDB will still see those fields as being part of the overall schema

For those coming across this issue with a "pre-existing" problem, you have two solutions, without having to split classes into two:
Disclaimer This is untested anywhere other than in my Ubuntu DEV env. It also involves you as a developer knowing ahead of time the maximum possible byte-lengths of data that will eventualy populating each field you adjust:
1). (Most effective, but harder) Write a custom BuildTask that drops extraneous tables
2). (Less effective, but easier and less fraught with danger) Alter the default values passed to the Varchar constructor in your $db static.
Q: But how do I know what the new, effective row_length is?
A: Do a before and after: Run the penultimate version of the perl script found here: http://dev.mysql.com/doc/refman/5.6/en/storage-requirements.html) thus:
perl mysql-row-check.pl <SS_table> --tables <MyTableList>

Simple use-case; change Varchar to Varchar(12) in text fields used for global co-ordinates - Lat and Lon - which have a maximum (useful) length of 12 characters.
Before:
#> perl mysql-row-check.pl SS_myDb --tables MyPage | grep total
total:	58258	least: 34	columns: 376

After:
#> ./framework/sake dev/build flush=all
#> perl mysql-row-check.pl SS_myDb --tables MyPage | grep total
total:	58030	least: 34	columns: 376

..granted not a massive gain (loss?) but extrapolate that over several columns and multiple translations (16 in my case) and it may help to alleviate the problem. Not a long term fix - there will eventually come a time when adding further fields and locales for translation, will result in MySQL's (InnoDB's) upper row_length limit being reached.

Closing this issue. It'll still be found by searching if folks still need the info.


[INLONG-663] modify the tar package name of inlong-manager

Codecov Report

Merging #513 (04085c4) into master (d748b6f) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff            @@
##             master    #513   +/-   ##
========================================
  Coverage      7.72%   7.72%
  Complexity      563     563
========================================
  Files           355     355
  Lines         31077   31077
  Branches       4970    4970
========================================
  Hits           2400    2400
  Misses        28187   28187
  Partials        490     490

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d748b6f...04085c4. Read the comment docs.


Playback file is not created when the command cy.reload() is used in the test

Describe the bug
I have a spec where I reload the page using cy.reload(). The test is expecting the page to be in the same state after a page reload. When I run the spec, no playback file is created. If I simply remove the reload command, the playback file is successfully created. The command log shows that there is "one pending request" when I use the reload command. I only have one matcher and it works just fine without the reload.
To Reproduce
I have tried to reproduce this using another site like Google but I was unsuccessful. I'm wondering if you know of any reason that this may happen? Here's an idea of what my test looks like:
describe('Playback', () => {
  beforeEach(() => {
    cy.playback('GET', '/some/json/request*');
  });

  it('should record after page reload', () => {
    cy.visit('/my/page');
    cy.get('.button').click();
    cy.get('h1').should('have.text', 'Endpoint Information');
    cy.reload();
    cy.get('h1').should('have.text', 'Endpoint Information');
  });
});

Expected behavior
The matcher should have recorded the requests and a playback file should be created.
Environment

OS: Windows
Cypress Version: 13.6.0
Browser: Chrome
Browser Version: 120

Hi @alaney, thanks for the report. I can reproduce what you're seeing as well, something with the cy.reload() in that test is causing an issue. My initial thought was that it had to do with the default hybrid mode getting mixed up with having both a record and playback possibility in the same test, but setting it explicitly to record mode shows the same issue.
We'll take a look, thanks!

Sorry it took so long to look at this issue. This is looking to be an interesting challenge, let me explain what I believe is going on:

The page is loaded by the browser. (Cypress in this case.)
The app code makes requests to a certain API endpoint.
The Cypress playback plugin intercepts that request and waits for it to complete.
A reload is triggered in Cypress, but that request has not completed, so it is cancelled by the browser.

This is where the problem enters, as the plugin is not notified of cancelled requests.

The page begins to load again, and the plugin is notified of the new request and waits for that new request to complete.
In this case, that request does complete and it is marked as such.
Unfortunately, the plugin is never notified about the cancelled requests, so waits for them to complete, which will never happen.

I'm going to look deeper in Cypress to see if it is possible to be notified of cancelled requests. Until then, you may want to add code to the test to ensure it is "stable" (meaning the inflight requests the plugin is waiting on are complete) prior to triggering the reload.

Thanks for the feedback. I can work with that 🙂

Hi @DigTheDoug,
Any news about this issue?

Hey sorry @malibagci no updates on this issue. It's a bit more of a complex one and we haven't had time to look at it. PRs always welcome if you or anyone else has any ideas or thoughts though. @tvsbrent 's comment above covers the gist of it, specifically the last bullet point:

Unfortunately, the plugin is never notified about the cancelled requests, so waits for them to complete, which will never happen

If you know of a way to hook into knowing when a reload is triggered in Cypress or when there are cancelled requests that might be where the library could interrupt to save the snapshot.


Common Configuration CRD for Core and RAN

Description
This PR addresses the common configuration CRD for Core and RAN. The common configurations I have verified will work for OAI 5G Core, Free 5GC, and Open5GS. I have created a CRD for AMF too, SMF and UPF don't need it for the moment but in the future, they will. Having a separate CRD for AMF allows fine-tuning AMF parameters.
Corresponding Issue
https://github.com/nephio-project/nephio/issues/362
Note
The verifications of the fields are based on how the standards specify. Some fields (amfRegionId,amfPointer,amfSetId) can be int and string both at the same time and they have different verification procedures. I didn't find a way to express it.
This PR is related to https://github.com/nephio-project/api/pull/56 for adding RAN config CRDs.
Dependency
Once this PR is approved I can implement it in OAI 5G Core Network operators.

how would DNN work in this proposal? Does the den refer to the nfdeployment crd where the IP(s) resolve ?

how would DNN work in this proposal? Does the den refer to the nfdeployment crd where the IP(s) resolve ?

@henderiw with this proposal DNN will be present in two places. So either we add PLMN/NSSAI/DNN combination in the same CRD as DNN or we remove from there and depend on this one. Or is there a way to link?

I actually like the DNNInfo under S-NSSAI piece as it concides with free5gc SMF config. But your DNNInfo is missing the UE pool, which is often associated with the DNN

I actually like the DNNInfo under S-NSSAI piece as it concides with free5gc SMF config. But your DNNInfo is missing the UE pool, which is often associated with the DNN

@s3wong I did it on purpose to have this structure. But DNN pool is allocated in the DNN CR. I will not have it in advance. To fill in this structure. Unless I can have some linking and a controller fill that information in config CR.

I believe the best solution is to put DNN in PLMN and build a specializer for this CR. So you create a package with the DNN requirement and put the result in the PLMN CR.
Now the challenge with this is you have to change the free5gc controller and someone need to create a specializer for this.
So the specialization loop would be:
specialization flow:
PLMN CR -> has DNN Req CR as is in the pkg -> DNN specializer requests IP (no change needed) -> IPAM specializer request IP (no change needed). -> a new specializer is required on PLMN CR which takes the DNN claimed IP and adds this in the PLMN CR.
In the controllers we need to use this config CR iso NF deployment to assign the PLMN/DNN and the related IP.
On top we need to update and take the DNN from the NF deployment CRD and move this into the PLMN CRD

I believe the best solution is to put DNN in PLMN and build a specializer for this CR. So you create a package with the DNN requirement and put the result in the PLMN CR.
Now the challenge with this is you have to change the free5gc controller and someone need to create a specializer for this. So the specialization loop would be:
specialization flow: PLMN CR -> has DNN Req CR as is in the pkg -> DNN specializer requests IP (no change needed) -> IPAM specializer request IP (no change needed). -> a new specializer is required on PLMN CR which takes the DNN claimed IP and adds this in the PLMN CR.
In the controllers we need to use this config CR iso NF deployment to assign the PLMN/DNN and the related IP.
On top we need to update and take the DNN from the NF deployment CRD and move this into the PLMN CRD

The thing I don't understand is how to make a dependency in the PLMN CR for DNN, because in a PLMN there are multiple DNNs. So how should I reflect that. Can you make a small yaml to explain how to create this dependency?
So far with the proposed CRD structure what I am doing is in SMF I have the dependency with UPF configuration (as it was earlier to get the DNN and ip-pool) and additional dependency to have this 3gpp.common-config CRD to be present. So I am fetching DNN information right now from two different places. I agree this is more error-prone.
To do it correctly I should fetch the information from only one place. If you can explain to me how to do it then let me see if I can write something in a short time or not.

@henderiw I have another idea (probably you proposed it too). How about I merge DNN and this CR, add the DNN pool here, and update the DNN specialized to search for the DNN pools from this CR? In that case the new CR would be something like this
 apiVersion: nfconfig.nephio.org/v1alpha1
kind: CommonCoreRANConfig
metadata:
  name: common-core-ran-config
spec:
  plmnInfo:
    - mcc: "001"
      mnc: "01"
      tac: 0
      nssai:
        - sst: 1
          sd: ffffff
          dnnInfo:
            - name: internet
              sessionType: ipv4
              dns: <IP_ADDRESS>
              pools:
                - name: pool1
                  prefixLength: 24
    - mcc: "208"
      mnc: "99"
      tac: 2
      nssai:
        - sst: 1
          sd: ffffff
          dnnInfo:
            - name: internet
              sessionType: ipv4
              dns: <IP_ADDRESS>
  communicationModel:
    - name: withNrf
      nrfUri: http://nrf-nnrf:8000

What do you think?

The q is do we ever need a DNN outside of this CR or not? if not yes we can do this. If yes we should not and create another specializer acting upon the PLMN CR.
So the idea is to make reusable building blocks we can reuse in various scenario's.
On top I also believe the DNS IP should be specialised and not be hardcoded.
The issue remains on the work split, are we able to pull this off for R2?

The q is do we ever need a DNN outside of this CR or not? if not yes we can do this. If yes we should not and create another specializer acting upon the PLMN CR.
So the idea is to make reusable building blocks we can reuse in various scenario's.
On top I also believe the DNS IP should be specialised and not be hardcoded.
The issue remains on the work split, are we able to pull this off for R2?

We don't need DNN outside this CR, we don't need to have a special CR only for DNN. Yes true DNN Ip should not be hardcoded. It should be global DNS which is behind coredns.
About the worksplit, I don't know. Who can do this?

The q is do we ever need a DNN outside of this CR or not? if not yes we can do this. If yes we should not and create another specializer acting upon the PLMN CR.
So the idea is to make reusable building blocks we can reuse in various scenario's.
On top I also believe the DNS IP should be specialised and not be hardcoded.
The issue remains on the work split, are we able to pull this off for R2?

We don't need DNN outside this CR, we don't need to have a special CR only for DNN. Yes true DNN Ip should not be hardcoded. It should be global DNS which is behind coredns.
About the worksplit, I don't know. Who can do this?

Here are all the things that need to happen if we do this.

update DNN/NF deployment API
update DNN fn
Update the nf-deploy fn
Update the pipeline tests
update the packages of free5gc and later oai
update the free5gc controllers
Test E2E

The q is do we ever need a DNN outside of this CR or not? if not yes we can do this. If yes we should not and create another specializer acting upon the PLMN CR.
So the idea is to make reusable building blocks we can reuse in various scenario's.
On top I also believe the DNS IP should be specialised and not be hardcoded.
The issue remains on the work split, are we able to pull this off for R2?

We don't need DNN outside this CR, we don't need to have a special CR only for DNN. Yes true DNN Ip should not be hardcoded. It should be global DNS which is behind coredns.
About the worksplit, I don't know. Who can do this?

Here are all the things that need to happen if we do this.

update DNN/NF deployment API
update DNN fn
Update the nf-deploy fn
Update the pipeline tests
update the packages of free5gc and later oai
update the free5gc controllers
Test E2E

That is true that this is quite some work and doing it in R2 will take some time. I have several options for R2.

Take dnn from dnn CRD and keep this crd as it is. We will have two CRDs till R3
We postpone the integration of this CRD till R3

/test presubmit-api-fossology

@arora-sagar please also take a look through this in light of this comment regarding pointers for optional fields: https://github.com/nephio-project/api/pull/56#pullrequestreview-1711140048

@henderiw I corrected to kinds to

plmns.cellular.config.nephio.org
amfs.cellular.config.nephio.org (Though there is only servedGUAMI for the moment in the future we can add more fields else there will be a lot of small CRs).  If you are really in favor of only continuing with small CRs then okay I will keep it servedGuami.
3.configs.cellular.config.nephio.org (I made the raw field configs rather than configRef (that will create confusion I suppose)

When you have time can you give me an example of how a package should be made?
@johnbelamaric I hope now the naming is correct according to the convention I checked K8s apis too.

Closing this PR as decided with @henderiw and @josephthaliath this approach will be changed in R3 with yang translators. For R2 the small CRs should be part of the experimental repository and config meta CRD of the Api repository. I will open another PR with only meta CRD.

do you open a new PR for the generic config one?


Add Branding Manager, add GitHub token

GH token got approved in #meta, branding manager move in #dev-contrib
Added GH token from env variable GITHUB_TOKEN. Branding manager and PEPs use this now.
Moved branding manager from SeasonalBot (Cobra) to Python.

Coverage decreased (-0.4%) to 56.122% when pulling 4aa7429cc967c43d2797c9bf7a24968c97855822 on ks129:branding-manager into 14e71609e8e40be0832b66df7a0c309ba262659a on python-discord:master.

Could you please resolve these conflicts @ks129?

Could you please resolve these conflicts @ks129?

@Den4200 Conflicts resolved.

@Den4200 Conflicts resolved.


telegraf ping option uses incorrect parameter -w

I just tried enabling the telegraf service, and while at it, I enabled ping to some local hosts. This comes to log with each host:
2018-06-10T17:00:58Z E! Error in plugin [inputs.ping]: host xxx.yyy ping: illegal option -- w
usage: ping [-AaDdfnoQqRrv] [-c count] [-G sweepmaxsize] [-g sweepminsize]
            [-h sweepincrsize] [-i wait] [-l preload] [-M mask | time] [-m ttl]
            [-P policy] [-p pattern] [-S src_addr] [-s packetsize] [-t timeout]
            [-W waittime] [-z tos] host
       ping [-AaDdfLnoQqRrv] [-c count] [-I iface] [-i wait] [-l preload]
            [-M mask | time] [-m ttl] [-P policy] [-p pattern] [-S src_addr]
            [-s packetsize] [-T ttl] [-t timeout] [-W waittime]
            [-z tos] mcast-group, exit status 64

I don't know what it wants to have as an option. In linux that would be -w timeout, which in freebsd would be -t. Perhaps change that?

Can you try with IP instead of hostname?

This was fixed upstream in
https://github.com/influxdata/telegraf/pull/4241
4 days ago.

Can we close this one @ikke-t ?

Looks valid to me. Thanks.

This seem to have come back in Telegraf 1.7.2?
I just updated to opnsense 18.7.9 and I stopped getting ping data to influxDB.
To troubleshoot I removed all hosts from the input field and added only <IP_ADDRESS>
On top of other (old?) input errors I'm getting:
2019-01-02T12:16:39Z E! [inputs.ping]: Error in plugin: host <IP_ADDRESS>: ping: illegal option -- w usage: ping [-AaDdfnoQqRrv] [-c count] [-G sweepmaxsize] [-g sweepminsize]             [-h sweepincrsize] [-i wait] [-l preload] [-M mask | time] [-m ttl]             [-P policy] [-p pattern] [-S src_addr] [-s packetsize] [-t timeout]             [-W waittime] [-z tos] host        ping [-AaDdfLnoQqRrv] [-c count] [-I iface] [-i wait] [-l preload]             [-M mask | time] [-m ttl] [-P policy] [-p pattern] [-S src_addr]             [-s packetsize] [-T ttl] [-t timeout] [-W waittime]             [-z tos] mcast-group, exit status 64

An upstream fix will come soon ..
https://github.com/influxdata/telegraf/pull/5112


Ionic Build and Run Android resulting in EACCES error since npm install -g<EMAIL_ADDRESS>

I tried running sudo npm install -g ionic@beta which upgraded me to beta 33 and caused a bunch of problems so I did npm install -g<EMAIL_ADDRESS>Now I can't build or run android. I get an EACCES error. I've tried sudo and also running sudo chown -R  me /Users/me/Documents/app folder but still doesn't work.
Please see error below.

Found the issue. There is a problem with npm where you need to always publish packages with bundledDependencies from npm2 with the node_modules structure of npm2 (nested). When I released<EMAIL_ADDRESS>I was using npm3 with the flat structure. So release beta.33 would only work with npm3 installs, which is what I used for testing.
I am sorry for the pain this might have caused. It is resolved in beta.35. I have tested and we should be ok now. Please let me know if you are still having issues. Thank you!
Fix: npm install -g<EMAIL_ADDRESS>

@jthoms1 Thanks! I upgraded and it got rid of those errors. But since upgrading to 33 and then 35 I am getting really stuck on building both android and ios, especially with many EACCES errors (I am the owner).
I ran sudo chown -R $(whoami) ~/desktop/pt/platforms/android/gradle/wrapper which got rid of them for android but resulted in this build failure?

However I can't get rid of them for iOS. I tried sudo chown -R $(whoami) ~/desktop/pt/platforms/ios/www/build but still get 100s of these EACCES errors when trying to build.

I didn't have a problem building or running Android or iOS before upgrading. Thank you for your help!


Fixes another Fastboot TypeError: window.ga is not a function instance

Wraps one more instance of window.ga in a canUseDOM condition to prevent Fastboot errors.

Bump. Would be great to get this one merged :)

Please merge, this would be great.

I just made this change in my fork and it fixed fastboot for me.
+1 for merging this.


Move TextRenderer to orbit_gl namespace

In this PR we are moving TextRenderer to orbit_gl namespace. We are
planning to Mock that class and since the mock class, the interface and
TextRenderer itself should be in that namespace we are previously
solving that tech-debt.
In addition we are erasing 3 forward declarations of TextRenderer that
are not needed anymore.
http://b/228609901
Test: The code compiles.

LGTM, but would be nice if you follow the Commit Message Guidelines.

Better?

LGTM, but would be nice if you follow the Commit Message Guidelines.

Better?

Super Nit:
Bug: http://b/228609901


Why is Csharp imdecode faster than C++

Summary of your issue

I run imdecode on both c++ and csharp, but csharp is faster than c++, is that right?
(In my opinion, csharp just call c++ dll so it should slower than or the same speed as c++)
Environment
win 11, opencv 4.7, .net4.8
What did you do when you faced the problem?
Write here
Example code:

c++
    std::string img_path = "E:/1.jpg";
    cv::Mat cvimg = cv::imread(img_path);
    double start, end;
    double tot_cv = 0;
    int times = 100;
    std::vector<uchar> buf;
    cv::imencode(".jpg", cvimg, buf);
    cv::Mat t1 = cv::imdecode(buf, IMREAD_ANYCOLOR);
    for (int i = 0; i < times; i++) {
        start = static_cast<double>(cv::getTickCount());
        cv::Mat cvres = cv::imdecode(buf, IMREAD_ANYCOLOR);
        end = static_cast<double>(cv::getTickCount());
        tot_cv += (end - start) * 1000 / cv::getTickFrequency();
    }
    std::cout << "imdecode avg time : " << tot_cv / times << std::endl;

csharp
            Bitmap map = new Bitmap(@"E:/1.jpg");
            string base64 = SaveJpegImage_ToMemory(map, 75); //same as encode
            byte[] arrbase64 = System.Convert.FromBase64String(base64);
            Stopwatch sw = new Stopwatch();

            OpenCvSharp.Mat m1 = OpenCvSharp.Cv2.ImDecode(arrbase64, OpenCvSharp.ImreadModes.AnyColor);
            sw.Restart();
            for(int i=0;i<100;i++)
            {
                m1 = OpenCvSharp.Cv2.ImDecode(arrbase64, OpenCvSharp.ImreadModes.AnyColor);
            }
            sw.Stop();
            System.Console.WriteLine("opencv: {0}", sw.ElapsedMilliseconds/100);

Output:

On my computer, c++ runs 34ms while csharp runs 16ms.
It means csharp imdecode doesn't call c++ imdecode actually? Can anyone explain this? Thanks.
What did you intend to be?

Solve this problem by compiling jpeg-turbo library with nasm, thus ensure simd is used to accelerate encode/decode process.


Adding msbuild support to the samples

project.json and msbuild support can live together for these samples for now. We should delete the project.json's when the time is right.

@richlander

This is a fix to address this: https://github.com/dotnet/core/issues/363

A question: do we want to actually start anew and show off the easier new csproj syntax for these samples? They are pretty basic, so it shouldn't be a problem. I can make that PR.

Sure, let's merge this and then you can clean them up as a good example for people who migrate.

LGTM then


Restructure UpdateEnrollment

UpdateEnrollment has multiple helpers with scm methods that should be moved to the scm package.
Resolves #881.

Codecov Report

Merging #882 (c96b24a) into master (68fc88f) will decrease coverage by 0.21%.
The diff coverage is 24.68%.

@@            Coverage Diff             @@
##           master     #882      +/-   ##
==========================================
- Coverage   29.22%   29.01%   -0.22%
==========================================
  Files          88       88
  Lines        9478     9416      -62
==========================================
- Hits         2770     2732      -38
+ Misses       6407     6388      -19
+ Partials      301      296       -5

Flag
Coverage Δ

unittests
29.01% <24.68%> (-0.22%)
:arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files
Coverage Δ

scm/github.go
0.00% <0.00%> (ø)

scm/scm.go
0.00% <ø> (ø)

web/scm_helpers.go
38.93% <ø> (+2.53%)
:arrow_up:

web/courses.go
43.53% <42.85%> (+0.17%)
:arrow_up:

scm/mock.go
73.77% <75.75%> (-2.66%)
:arrow_down:

scm/helper.go
68.00% <100.00%> (-0.63%)
:arrow_down:

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more


Add Duke UI screenshot

Closes https://github.com/SwampertX/duke/issues/7

Codecov Report

Merging #147 into gatsby will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           gatsby     #147   +/-   ##
=======================================
  Coverage   95.71%   95.71%
=======================================
  Files          28       28
  Lines         140      140
  Branches        8        8
=======================================
  Hits          134      134
  Misses          6        6

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 796aff6...2bc2928. Read the comment docs.


[terra-clinical-data-grid] Allow hover styles to apply only on non-touch devices

Summary
This PR resolves the issue by making use of hover and pointer interaction media features introduced in Media Queries Level 4 so that the hover styles are applied only on non-touch devices whose primary input is a fine pointer device such as a mouse or a stylus
Deployment Link

https://terra-clinical-deployed-pr-#.herokuapp.com/
Testing

Additional Details

Thank you for contributing to Terra.
@cerner/terra

@saket2403 why did the screenshots change with this media query? Are we being too specific with and (pointer: fine) included in the query?

@emilyrohrbough This may be a bug with headless-chrome. Running in non-headless Chrome the screenshots are generated as expected with the media queries.  The styles also appear to be working correctly when running the site locally. I tried a few variations of the media query and was unsuccessful getting the screenshots to generate correctly.
Similar conversation thread here:
https://github.com/cerner/terra-core/pull/2929#issuecomment-620058376

@StephenEsser Thanks for the info.

Changes reverted to use media queries and wdio tests removed for hover styles.

Tested: PR #652
Resolves: Terra-Core: Issue #2927
Reviewed:
Manually reviewed the hover states for the components affected:

Clinical-data-grid

Verified by @neilpfeiffer, ready to merge after engineering review.

Pass

UX Review

Spoke to Paul and he was good with just UX review on this.


FQDN: consider not adding names to the DNSCache that don't have selectors

The FQDN policy system really has two separate components:
1: DNS proxy policy, which intercepts DNS requests and allows or denies the DNS request based on the name
2: toFQDN policy, which dynamically configures L3 policy based on intercepted DNS requests. Endpoints with ToFQDN must, by definition, use DNS proxy as well
The toFQDN policy engine must maintain a cache (the "DNSCache") of names and their answers, so it can manage TTLs and garbage collection. This cache is not used for generating responses, just for computing IPs for L3 policy.
However, we currently insert all names intercepted as part of DNS policy in to the DNSCache, regardless of whether or not they are used for toFQDN policy. We should consider skipping this where possible.
One disadvantage of this would be when a toFQDN policy is added for a name that would have already existed in the DNSCache. I think, however, this is OK. By definition, toFQDN policy is dependent on endpoints making DNS requests. Any IP addresses discovered after the toFQDN policy is created would be allowed, which IMHO is acceptable.

Hi @squeed, Can I take this issue?
In my understanding, notifyOnDNSMsg kicks updating (inserting) DNSCache here, so we can filter unnecessary DNS records in that process.

Hi @squeed, Can I take this issue?

@Shunpoco go ahead

For sure!

However, we currently insert all names intercepted as part of DNS policy in to the DNSCache, regardless of whether or not they are used for toFQDN policy. We should consider skipping this where possible.

There is actually one other user of this information: Hubble does a reverse lookup on the IP to annotate the IP with known fqdn names for the IP. If users just have a DNS observability rule without ToFQDNs they might still want Hubble to annotate all flows with the FQDN of the observed IP.

Aha, good point; I didn't realize that.

@squeed, @gandro
I'm sorry to leave this issue for months. Now I can make time, so will tackle this issue.
But

There is actually one other user of this information: Hubble ~

Did you mean that Hubble uses this DNSCache information not only DNS with toFQDN policy, but also which is not related with toFQDN policy?
In that case, should we leave the current implementation (and close this ticket), or should we prepare other DNS cache system for Hubble and separate it to FQDN code?

A second cache probably would not bring the performance benefits we expect from this work. I think we are unsure how to proceed here, given the fact that Hubble relies on this and the behavior changes outlined it the the last paragraph of the original post.
I'm currently leaning towards leaving the current implementation as is and close the ticket.

Closing as not planned for now. We can reopen if the assessment changes


Update field name PackagePath.scoped

When I test promote service I hit "missing property" error of 'PackagePath.isScoped'. I corrected the name according to bean standard, and the err is gone.
That class is copied from Indy. I guess we will hit the same issue in the future, e.g, when upgrading to newer dependency lib. So I port the fix here.

LGTM.

Maybe just a convention. For boolean field, name it normally, e.g, x. Its get method would be 'isX'. we better not name the filed to 'isX'. Otherwise the method by default would be 'isIsX'. Some libraries may depend on the convention.

Maybe just a convention. For boolean field, name it normally, e.g, x. Its get method would be 'isX'. we better not name the filed to 'isX'. Otherwise the method by default would be 'isIsX'. Some libraries may depend on the convention.

Oh ok. I misunderstand this "bean standard" as some npm metadata file format convention. That's ok.


[deck.gl requirement] Implement instanced rendering.

Closed with https://github.com/uber-common/luma.gl/pull/28


Unable to import wallet in .8

The last time I used Bitshares was on a different computer in the version .4-ish days, I downloaded the most recent version for 64bit windows from bitshares.org but on attempting to load my wallet backups I recieved error 20001 "invalid password!" which is unfortunate and was a bit terrifying because it's inaccurate.
I double checked on my other computer that still has the early version of Bitshares on it and the password works fine there although it will not connect to the network.  I then backed up my wallet from the computer where the password worked and tried to recover it on the computer with the updated bitshares client with the same result, invalid password recovering the file.

What gives?

@AdamBLevine This is a still-unsolved bug on some Windows platforms.
For now the workaround is to install version 0.5.3 (https://github.com/BitShares/bitshares/releases/tag/bts%2F0.5.3) first, import the backup, then upgrade in-place to the latest version.
Another option is that you should also be able to directly copy the wallets folder from your old client application data directory for the to the same spot on the other computer with the new version.

I got this 'Invalid Password' message on OSX with 0.8.  Yesterday I was switching between 2 wallets.. wallet #1 worked and #2 kept giving me this error. I was getting worried and about to post an issue, but the problem resolved itself.
The problem may have been due to the fact that wallet #1 was not finished scanning. Today, I let it finish, then swapped for #2, and my password was accepted.
Sorry I can't contribute more.. just know there's hope :)
It's a shot in the dark but you could try:

move wallets to wallets.bak
launch bitshares and create a new "temp" wallet (to ensure a fresh/consistent state)
close bitshares, delete the newly created wallets dir
move wallets.bak to wallets
cross your fingers and re-launch the client

@vikramrajkumar is this a legacy issue?  do you believe it will be fixed in the next few months?   I was just trying to check in on the technology, seems like it needs a bit more time.

@AdamBLevine This is an issue affecting wallet backups created before version 0.6.0, and is unlikely to be fixed.

@vikramrajkumar
That seems hard to believe.    I wonder how many people have this problem assume the "invalid password" error actually means their password is invalid and assumes it's their fault, moving on.
You guys can't be onboarding many new users compared to the early adopters who are potentially affected by this bug, so this seems like a choice to save a little time by throwing away the people who supported the project financially to the point it is now.
Is this just an impossible bug to solve or is it just not worth the time because it "only effects people who backed up their wallets after 0.6.0" lol
I can't imagine this is the upgrade experience you want people who put money into the system earlier to experiance lacking any context besides an error message that incorrectly says your password is wrong.  And the workaround you've provided given the bug won't be fixed is insane.  I might do that but who else would?  Where do I even get a version of Bitshares so out of date?
Is this showstopping bug talked about anywhere on any non-forum or are all users who run into it expected to just know to post an issue on github?
Am I crazy?

@AdamBLevine I've spent a long time looking at this bug and unfortunately have not been able to figure it out. There have been many GitHub issues and forum posts on BitSharesTalk about it. The software is still unstable/experimental and early adopters are expected to post on the forum when they run into walls like this.

Given that the bug isn't going to be fixed, is this something that will get
easier or more difficult to recover my accounts as you roll out new
versions?
I'm not really anxious to spend more time trying to figure this out but I
need to recover these at some point, should I do it ASAP?
If this is a known bug that will not be fixed you should put a more
descriptive error so that it's less traumatic and more descriptive of
what's actually happening.  I've wasted like three hours on all this and
much of it would have been avoided if the error was "upgrade compatability
issue, see  for support" rather than 'invalid password"

It won't become much more difficult in the future, but you may as well recover it now so you don't have to deal with this later.
An easier way to do so might be to create a brand new wallet, add a new temporary local account, and use the "Import Keys from Wallet" feature under that account and feed it the backup file. See the attached screenshot for where I mean:

If that works okay and your old balances/accounts show up, then create a new backup file and use that one in the future (and I would make sure to keep the old one too just to be extra careful).

If this is a known bug that will not be fixed you should put a more descriptive error so that it's less traumatic and more descriptive of what's actually happening. I've wasted like three hours on all this and much of it would have been avoided if the error was "upgrade compatability issue, see  for support" rather than 'invalid password"

Yes we will do something like this: #1491

Support link added to error message in RC2: https://bitsharestalk.org/index.php/topic,15900.msg203941.html#msg203941
Please post in the forum for help with this if you are still having problems.


Cant read some fonts and characters and returns cid() value

Some characters like € is not readable:  text 339,45 € is read as 339,45 cid(128)
If needed I can send the pdf, cant add here
It seems like cause by underlining pdfminer issue, check the similar open issues in the repo:
https://github.com/pdfminer/pdfminer.six/issues/635
https://github.com/pdfminer/pdfminer.six/issues/796
https://github.com/pdfminer/pdfminer.six/issues/927

Should be fixed with pdfminer.six update in fork https://github.com/krishnasism/pdfminer.six/tree/master


nsfw api key is invalid

all nsfw commands for me are showing "api key is invalid", how to fix?

add apikey parameter

&apiKey=Your-Apikey

I saw that in the codes he told me to go to some website, when I accessed it he demonstrated this: https://prnt.sc/w3p06p sorry if i'm just being stupid, is that i'm a very layman


installing new packages fails to compile

Hello,
I'm using this sample app and am having some trouble with installing new packages. For example if I

install in the frontend directory npm install @zoom/appssdk (just using zoomSdk as an example here, I understand it's already imported in index.html)
import the package into a React component file with import zoomSdk from "@zoom/appssdk"
then go through the steps to install the app in Zoom

I get this error:
Cannot find module '@zoom/appssdk'
webpackMissingModule@https://1478-71-218-251-54.ngrok-free.app/api/zoomapp/proxy/static/js/bundle.js:21:59
./src/App.js@https://1478-71-218-251-54.ngrok-free.app/api/zoomapp/proxy/static/js/bundle.js:21:143
@https://1478-71-218-251-54.ngrok-free.app/api/zoomapp/proxy/static/js/bundle.js:49017:35
__webpack_require__@https://1478-71-218-251-54.ngrok-free.app/api/zoomapp/proxy/static/js/bundle.js:48453:37
fn@https://1478-71-218-251-54.ngrok-free.app/api/zoomapp/proxy/static/js/bundle.js:48674:28
./src/index.js@https://1478-71-218-251-54.ngrok-free.app/api/zoomapp/proxy/static/js/bundle.js:1600:81
@https://1478-71-218-251-54.ngrok-free.app/api/zoomapp/proxy/static/js/bundle.js:49017:35
__webpack_require__@https://1478-71-218-251-54.ngrok-free.app/api/zoomapp/proxy/static/js/bundle.js:48453:37
@https://1478-71-218-251-54.ngrok-free.app/api/zoomapp/proxy/static/js/bundle.js:49663:56
global code@https://1478-71-218-251-54.ngrok-free.app/api/zoomapp/proxy/static/js/bundle.js:49665:12

This seems to be an issue with the default webpack configuration for the project, but just wondering if anyone has gotten around this before?

Your logs specify it's attempting to load from https://1478-71-218-251-54.ngrok-free.app, is your ngrok instance running when you attempt npm install @zoom/appssdk? and if so, you may need to update the ngrok instance ID in the PUBLIC_URL .env variable which is one of my least favorite parts about using ngrok's free teir.
Additionally, the appssdk is distrubuted via Zoom CDN, https://appssdk.zoom.us/ so if needed you could download it into a /lib/zoom-appssdk directory and reference it that way.

I cleared out all my docker images and rebuilt and was able to get some other installed packages to work... for Zoom I'll just stick with the current import for now. I'll close this out.


connect: Add cases for 1x1 boards

I think these are important since they're an interesting case for when a
start space in the search is also a goal space. I advocate for this in
original #297.

seconded :+1:


merge the zh-hans .lu file with PR #214

The PR #214 had updated the other languages' files. Could you help to merge it with the new zh-hans .lu file? Thank you.

Already done.


New rules tests

Add tests for new rules.
In particular, it is based on examples from the phi paper appendix.

PR-Codex overview
This PR focuses on updating the new.yaml file with additional test cases and clarifications related to the contextualization rules in the Phi system, particularly examples from the Phi paper.
Detailed summary

Added a TODO comment for the nf condition in the when clause.
Introduced multiple new test cases labeled as "Phi Paper - Example E2", "E3", and "E4" with specific inputs and expected outputs.
Modified existing test cases for clarity and consistency.
Added a new test for Phi Paper - Example E3 - first R_stay.
Included a test case for Phi Paper Example E2 last application.

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

@Anatolay Hey team! 👋 Let's align our branch naming with best practices. Instead of new-rules-tests, consider using the ticket number, like 539. This helps streamline our workflow and keeps things organized. Remember, -12 points for this one, but I'm confident we'll nail it next time! 💪

@Anatolay Hey there! 👋 Thanks for your contribution, but we've got some room for improvement. Your score this time is +4 points: +4 base, -16 for no code review, -16 for zero reviewer comments, and +32 to keep you going. Remember, code reviews and comments are crucial – they can boost your score significantly! 🚀 Try to aim for 20+ hits-of-code next time, and don't forget to balance speed and quality. Keep the contributions coming! Your current balance is -12.


Added TypeDoc comments to src/backend/database/index.ts

@rasienko

Closing because this PR is out of date

Closing because this PR is out of date


x/pkgsite: link to custom links is broken.

What is the URL of the page with the issue?
https://pkg.go.dev/about
What is your user agent?  (N/A)
Mozilla/5.0 (X11; CrOS x86_64 14268.51.0) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/96.0.4664.77 Safari/537.36
Screenshot
N/A
What did you do?
Click on the link to "this issue" in the Adding links section. https://pkg.go.dev/about#adding-links
What did you expect to see?
https://github.com/golang/go/issues/42968
What did you see instead?
https://pkg.go.dev/issue/42968  (currently a 404)

I'm happy to put in the quick fix to fix the link, and am spining up my contribution set up.

https://go-review.googlesource.com/c/pkgsite/+/374854

Fixed in CL 374854