Introduce Rust virtiofsd package

Merge Checklist

All boxes should be checked before merging the PR (just tick any boxes which don't apply to this PR)

[x] The toolchain has been rebuilt successfully (or no changes were made to it)
[x] The toolchain/worker package manifests are up-to-date
[x] Any updated packages successfully build (or no packages were changed)
[x] Packages depending on static components modified in this PR (Golang, *-static subpackages, etc.) have had their Release tag incremented.
[x] Package tests (%check section) have been verified with RUN_CHECK=y for existing SPEC files, or added to new SPEC files
[x] All package sources are available
[x] cgmanifest files are up-to-date and sorted (./cgmanifest.json, ./toolkit/scripts/toolchain/cgmanifest.json, .github/workflows/cgmanifest.json)
[x] LICENSE-MAP files are up-to-date (./SPECS/LICENSES-AND-NOTICES/data/licenses.json, ./SPECS/LICENSES-AND-NOTICES/LICENSES-MAP.md, ./SPECS/LICENSES-AND-NOTICES/LICENSE-EXCEPTIONS.PHOTON)
[x] All source files have up-to-date hashes in the *.signatures.json files
[x] sudo make go-tidy-all and sudo make go-test-coverage pass
[x] Documentation has been updated to match any changes to the build system
[x] Ready to merge

Summary

This introduces the new virtiofsd package written in Rust. This will be needed for kata-containers as upstream recently made the switch from C to the Rust version of virtiofsd.
Does this affect the toolchain?

NO
Test Methodology

Local build, install and running /usr/libexec/virtiofsd -h ✅
Pipeline build: https://dev.azure.com/mariner-org/mariner/_build/results?buildId=481262&view=results

Summary of our call for 2.0:

Keep qemu-virtiofsd unchanged to not break existing users
Introduce standalone Rust virtiofsd

ONLY the virtiofsd binary, in a different location from the C one
NO Conflicts: qemu-virtiofsd or Requires: qemu-common: so that both qemu and virtiofsd can coexist (note that qemu-common depends on qemu-virtiofsd through vhostuser-backend(fs))
NO Provides: vhostuser-backend(fs): so that existing users of the vhostuser-backend(fs) capability are not broken

Also NOT installing the vhostuser-backend(fs) JSON file, as that could cause unexpected conflicts with the one from qemu-virtiofsd


Minimum node version

Is your feature request related to a problem? Please describe.
With a recent update to a repo, it was discovered that pulling in MAJOR release versions of semantic-release packages requires a minimum of 14.17.
Does this mean that we need to update WC-Generator to have a min of 14.17?
https://github.com/AlaskaAirlines/WC-Generator/blob/3074b048d25b1e75409c724479f67e9d29f7c576/util/verifyNodeVersion.js#L34
Describe the solution you'd like
Review policy for how we set minimum node version for WC-Generator
Describe alternatives you've considered
The only other alternative is to allow the end-user to use an older version of Node, but then we set a trap that we need to document our way out of.
Additional context
This error is silent and does not break the build. So we can keep testing on 12 and up.

(posted this in teams, adding here for posterity)
Even though, the generator runs fine with Node 12, building/developing the generated component now requires Node 14.17.
I'm in favor of just requiring Node 14. What's the point in generating a new element without being able to develop it?

Updated this to a bug as the current version of the WC-Generator will pull resources that require a higher version of Node than is listed as the minimum version.


[BUG 1.17.1 seerver] crash on startup since today

Description:

Give a detailed explanation of the issue

Steps to Reproduce:

Steps to reproduce this behaviour

Technical Information:

Minecraft:1.17.1
Fabric API: 0.13.3
Industrial Revolution: 1.12.0
Modpack: Sky FABRICation 2

Logs:
https://gist.github.com/MSandro/2c984703764f19e70f99c3d3cb1a6a72
Details:
not sure why, but since today my server is in a crash loop! Please help.

I have connected an Cable to an ME Controller and it is crashed now.

still no fix for 1.17.1. I'm still hoping for an update.


Add Brane to Contributors list

@brane, I'm quite elated about your PR. I wanna evolve this project to addresses various problems faced by first-time contributors. I'd love to learn about your journey in open source community, the problems, pain points you had etc.
Could you explain how you felt when you went through the tutorial, made a PR and learned that I merged it?


[Feature]: framer-motion in suspensive.org

Package Scope
etc
Description
https://motion-primitives.com/docs/text-effect
Possible Solution
No response
etc.
No response

Oh, can you give me more details on this issue?

Let me know if I can help too!

I just want to make suspensive.org more beautiful
But we have no specific plan, so idea suggestion is required to do this
I want to get your suggestion to do this @kangju2000 @saul-atomrigs
Could you suggest it for me?

I found a place to get inspiration from: https://www.framer.com/gallery/styles/dark
we could make improvements little by little!

Other ref: https://ground.bossadizenith.me/docs/carousel/swipe

https://magicui.design/
https://motion-primitives.com/
https://eldoraui.site/


PointAnnotation or SymbolLayer with lottie

Describe the bug
Hi,guys,I want to display some animated label points on the map, but these label points are not displayed at all, or they are displayed but not animated.need help~
my  first code(displayed but not animated.)
{
<MapboxGL.MapView
style={styles.map}
ref={mapView => (this._mapView = mapView)}
onPress={this.onPress}
onRegionWillChange={() => {
console.log('moving start');
}}
onRegionDidChange={() => {
console.log('moving ended');
}}
styleURL="http://xxx.xxx.x.xxx:xxxx/mapBoxLayer/getLocalStyle/"
onDidFinishLoadingMap={this.onDidFinishLoadingMap}
logoEnabled={false}
attributionEnabled={false}>
{this.renderAnnotations()}
{/* 背景色 */}
<MapboxGL.BackgroundLayer
id={'background-layer'}
belowLayerID={'baseMap'}
style={styles.back}
/>
<MapboxGL.Camera
maxBounds={bounds}
ref={camera => (this.camera = camera)}
zoomLevel={15}
minZoomLevel={13}
/>
      {
        <MapboxGL.PointAnnotation
          // onSelected={feature => {
          //   this.onAnnotationSelected(i, feature);
          // }}
          id={'pointAnnotation'}
          //onDeselected={() => this.onAnnotationDeselected(i)}
          coordinate={[110.43206630556807, 21.040148152209852]}>
          {
            <View
              style={{
                flex: 1,
                justifyContent: 'center',
                alignItems: 'center',
                backgroundColor: 'transparent',
              }}>
              <Point />
            </View>
          }
        </MapboxGL.PointAnnotation>
      }
    </MapboxGL.MapView>
  </View>

}
point.js*
import React from 'react';
import LottieView from 'lottie-react-native';
export default class point extends React.Component {
componentDidMount() {
this.animation.play();
// Or set a specific startFrame and endFrame with:
}
render() {
return (
<LottieView
ref={animation => {
this.animation = animation;
}}
style={{
width: 80,
height: 80,
}}
autoPlay={true}
loop
source={require('../../android/app/src/main/res/assets/alarm.json')}
/>
);
}
}
****did not show the point at all ****
{
<MapboxGL.ShapeSource
id="markersShape"
shape={{
type: 'Feature',
properties: {
id: 'asd',
},
geometry: {
type: 'Point',
coordinates: [110.45156770056178, 21.048534543403022],
},
}}>
<MapboxGL.SymbolLayer
id="asd"
sourceID="markersShape"
minZoomLevel={1}
style={{
iconSize: 10,
iconAllowOverlap: true,
}}>
<View
style={{height: 100, width: 100, backgroundColor: 'gray'}}
pointerEvents="none" // this is important for the onPress prop of ShapeSource to work
>
{/ ... place what you want as a marker here, even SVG from react-native-svg for instance */}
<Image source={require('../assets/imgs/info.png')} />

</MapboxGL.SymbolLayer>
</MapboxGL.ShapeSource>
}
Expected behavior
displayed and animated.
Versions (please complete the following information):

Platfrom: Android
Device: Redmi Note 8
OS: android 9
SDK Version :{
buildToolsVersion = "28.0.3"
minSdkVersion = 19
compileSdkVersion = 28
targetSdkVersion = 28}
"react": "^16.9.0",
"react-native": "^0.61.4",
"@react-native-mapbox-gl/maps": "^7.0.8",
"lottie-ios": "3.1.3",
"lottie-react-native": "^3.3.2",

Lottie doesn't work within the context of mapbox-gl-native. For advanced animations, your best bet is to provide a GL surface that you sync with the viewport of the map. This is outside the scope of this library.

Lottie在mapbox-gl-native的上下文中不起作用。对于高级动画，最好的选择是提供一个与地图视口同步的GL曲面。这超出了此库的范围。

thanks

Is there a property/method that can help with syncing to the viewport? One that doesn't involve setting state and lots of rerenders?


Do not store user picture path in JWT token or the database

Current user object refs stored in the database and JWT token are like {id:1, name: ..., picture: '/api/users/:id/picture'}
Picture path is really something that needs to be resolved during runtime. It also should not be embedded in the JWT token as it makes the token very long. It is a shame that this even slipped through!

This is now obsoleted by 2.0 branch so closing.


Vulneribility detected

Describe the bug
We are currently using boto3 version 1.26.30. We are using NexusIq which scans all our dependencies and at the moment it fails for
botocore 1.29.30 with a high security warning
Vulneritiblity CVE-2022-23491
Expected Behavior
CVE-2022-23491 is not detected anymore
Current Behavior
CVE-2022-23491 detected
Reproduction Steps
CVE-2022-23491
Possible Solution
I'm not an expert here, but it could probably solved with updating certif:
https://github.com/certifi/python-certifi/security/advisories/GHSA-43fp-rhv2-5gv8
Additional Information/Context
No response
SDK version used
1.26.30
Environment details (OS name and version, etc.)
Linux

Also hitting this issue.. it is flagged in the National Vulnerability Database.

Thanks for reporting this - this issue was also being tracked internally and I wanted to get some more information before following up here. I was advised to share the following:

Installing certifi supersedes anything in Botocore, this is the best general way to keep your certificates up to date, so we recommend that you keep your version of certifi up to date.
Boto3 only communicates with AWS services which do not use third-party certs unless explicitly redirected by the customer. The default usage of Boto3 is not subject to this CVE.
Customers can also set their cert to with AWS_CA_BUNDLE in their environment vars or ca_bundle in the Config if they need finer grained control over the bundle available. (See this documentation for reference: https://boto3.amazonaws.com/v1/documentation/api/latest/guide/configuration.html)

Please let us know if you had any other questions regarding this topic.

@tim-finnigan I'm not sure how default usage of Boto3 is not subject to the CVE.  Just adding boto3 to an application automatically adds botocore, those whl and tar files are automatically flagged by the National Vulnerability Database.
Do you have any examples on how to use the configuration in the manner you are describing?  Not the boto3 config reference documentation, as it has no examples doing what you are asking for (set their cert to with AWS_CA_BUNDLE in their environment vars or ca_bundle in the Config if they need finer grained control over the bundle available).

Hi @lorienpatt - to control the certificates used you would need to configure it, which can be done using the environment variable AWS_CA_BUNDLE or use the ca_bundle profile parameter. Documentation is here:

Env variable: https://boto3.amazonaws.com/v1/documentation/api/latest/guide/configuration.html#using-environment-variables
Config file: https://boto3.amazonaws.com/v1/documentation/api/latest/guide/configuration.html#using-a-configuration-file

Here you can find examples in the general SDK reference guide: https://docs.aws.amazon.com/sdkref/latest/guide/feature-gen-config.html. Have you tried using the Environment variable or config file approach?

We don't use a specific AWS_CA_BUNDLE, we are just using the out of the box code samples.  Why would we need to use a custom certificate bundle?

Hi @lorienpatt,
Hopefully I can provide some more clarifications to your questions.

I'm not sure how default usage of Boto3 is not subject to the CVE. Just adding boto3 to an application automatically adds botocore, those whl and tar files are automatically flagged by the National Vulnerability Database.

boto3 never uses the certificates mentioned in that CVE (those for TrustCor). In fact, it does not use any other certificates other than those to communicate with Amazon AWS services. So, despite the presence of those certificates, if you are using boto3 in the supported manner, there is no risk because they are never used.
Any use of the certificate file provided with botocore other than that is not recommended and is at the users' own risk.

We also have the most up to date version of the certifi library installed, so I don't think its that.

This was noted by @tim-finnigan in a previous comment:

Installing certifi supersedes anything in Botocore, this is the best general way to keep your certificates up to date, so we recommend that you keep your version of certifi up to date.

If you have the most up-to-date version of certifi installed, then the certificate file that comes with botocore is never used, even to communicate with AWS services, and there is nothing for you to do. The certificates provided by certifi are used instead.

We don't use a specific AWS_CA_BUNDLE, we are just using the out of the box code samples. Why would we need to use a custom certificate bundle?

Some individuals and companies prefer to only use specific trusted certificates. In practice, this is a better way to control your risk tolerance. If you or the company you work for prefer to only use allowlisted certificates, setting them via the environment variable or configuration file parameter is the way to achieve that.
If these scenarios do not apply to you, then there isn't anything for you to do.

Hi @kdaily,
I guess we don't have anything to do then.  Even though we are not affected by this, will you be working to get the package upgraded so NexusIQ will not flag this library?

Hi @lorienpatt,
You're correct that you do not need to do anything. We're still investigating. Thanks!

Hi
Botocore includes its own certificate authority (CA) file cacert.pem.  This cacert.pem file includes root certificates from "TrustCor" which are the cause of the CVE. Technically any CA listed in the included cacert.pem file can issue certificates for any DNS domain and will be trusted by software configured to use the cacert.pem for certificate validation. So any CA certs included must be very trust worthy.
A quick fix to resolve this CVE (including flagging in NexusIQ) would be to release a new version botocore with the root certificates from "TrustCor" removed from the botocore/cacert.pem file.

Hi,
we also have this issue hitting us. The problem here is not that the normal usage of botocore would not trigger this vulnerability, but that in many deployment pipelines a NexusIQ scan is a mandatory security gate.
The flagged botocore package then needs to be reviewed manually.
If the cacert.pem-file delivered with your package would not include problematic certificates (or even better, only exactly the certificates you need) this issue would not come up and many people would not need to spend time understanding and assessing the risk involved.
So a fix in an upcoming version would be greatly appreciated.

Botocore is home to some pre-historic dependencies.
the jsonschema version is from 2015, which is starting to cause conflicts with other dependencies in my project which use newer versions of jsonschema.

Is this still an issue? There hasn't been any activity here in a while so wanted to confirm if this still applies to the latest botocore version (1.34.141 per the CHANGELOG).


Addition of wiki

Hi, Hugo. I moved the changes to this branch as requested.
I was not able to build with gulp to test if everything is ok due to some problem with the browser-sync library. It is giving me an error when I try to require the library.

Hi, Hugo. With your help I managed to test it! Everything is good!
Thank you!


MFA cannot be disabled for site

A user is unable to disable MFA for a site using the mfa settings checkbox in site settings.
To reproduce:

Access site settings, confirm mfa settings checkbox is unchecked
Have a user who has not skipped registration log in
Identify user is shown the MFA registration screen (bug)

Expected behaviour:
If the mfa settings is unchecked, no user will be presented with the mfa registration screen when logging in.
Version:
silverstripe/mfa  dev-master 7c5ccba

Note that a user should still be able to register MFA methods through their user settings page.

Discussed in person, definitely a bug, but also maybe we shouldn’t have an “enabled” option at all. If it’s installed it’s optional, and if you set it as required then it’s enforced

We've had quite a few conversations on this already, I'm not sure of all the decisions which led to that anymore @robbieaverill. They might need to roll out MFA at an organisational timeframe rather than a development go-live (processes, keys etc, they might be transitioning from RealME or to/from other MFA services).
This one of those things which it might help cater to a few edge cases but isn't essential so could drop off if it needs to (good comms could produce the same outcome). If this was a developer audience which didn't rely on govt. processes then I'd tend to agree with not having the extra control.

Cool, we should fix it for now anyway

PR at #97


Building a Deep Learning Selfie Segmentation Web App using Gradio

Proposed title of article
Your title should be descriptive of the article/tutorial. Be Specific.
[Machine Learning] Building a Deep Learning Selfie Segmentation Web App using Gradio
Use keyword research to improve your article's SEO.
Proposed article introduction
In this tutorial, we are going to build a selfie segmentation model using Mediapipe, Gradio and Python. The selfie segmentation model allows us to quickly and easily strip out the background from photos using a pre-built machine learning model.
We’re going to take it one step further and integrate it to a Gradio app!
Key takeaways
What are the 3-5 most important things the reader should understand or be able to do after reading this article?
Use this area to get your ideas down on the bulk of your article or tutorial.
By the end of this tutorial, a reader will be able to:

Install Mediapipe and Gradio
Apply selfie segmentation using OpenCV
Integrate the selfie model into the Gradio app

References
Please list links to any published content/research that you intend to use to support/guide this article.

MediaPipe
Gradio

Good afternoon and thank you for submitting your topic suggestion.
Your topic form has been entered into our queue and should be reviewed (for approval) as soon as a content moderator is finished reviewing the ones in the queue before it.

Great topic 🚀 , make sure it matches the following:

Adds value beyond what is in the official docs and what is covered in other blog sites.
To avoid potential article closure, it should not overlap with existing EngEd articles or incoming topic suggestions.

Please reference any relevant EngEd articles in yours and build a unique project - Approved.

Closed #4034 via #4141


Can't start server

Hi not sure if I did understood the instructions but after cloning the repo, running npm install and then node server.js I get the following error:
events.js:141
      throw er; // Unhandled 'error' event
      ^

Error: listen EADDRINUSE :::3001
    at Object.exports._errnoException (util.js:870:11)
    at exports._exceptionWithHostPort (util.js:893:20)
    at Server._listen2 (net.js:1234:14)
    at listen (net.js:1270:10)
    at Server.listen (net.js:1366:5)
    at Object.<anonymous> (/Users/omar/Development/nodejs-jwt-authentication-sample/server.js:40:24)
    at Module._compile (module.js:409:26)
    at Object.Module._extensions..js (module.js:416:10)
    at Module.load (module.js:343:32)
    at Function.Module._load (module.js:300:12)

Any help will be appreciated.

I found the issue. I was running another server already. Closing the issue.


Support SonarScanner for .NET Framework 4.6+

We currently use Cake.Build to build net4.8 via MSBuild, and we also have SonarScanner for .NET Framework 4.6+ (SonarScanner.MSBuild.exe) already installed in our build machine with the latest version.
This scenario does not currently work because line 48 in SonarRunner will always evaluate as true for Cake.Build 2.0 and 3.0
Would relying only in SonarSettings.UseCoreClr instead be an option? If so I could send a PR to fix it.

You can use the .NET (Core) version of the scanner to scan your .NET Framework 4.8 project.

@twenzel Thanks, you are correct. I was under the wrong impression that each .NET framework would requiere a different SonnarScanner version.
Closing this then.


Inherit icon color

Isons have an hard coded color of #fff, we could remove the fill attribute  from svg icons to use the color added with the style tag, an example icon that is hard coded as white:
https://github.com/MichalSzorad/react-social-login-buttons/blob/5217e4871eeffc9537b4d7d8f0f249496d56f715/src/buttons/FacebookLoginButton.js#L20

Hello, thank you for the issue!
I have just released v3.1.0 where you can specify iconColor on a SocialLoginButton. Let me know if that does not help.
Cheers!


Plugin for custom Product

What documentation describes a Plugin for a custom product? There is a plugin name field under configuration tab for a custom product. What goes in this field?

Plugin can be used in conjunction with event hooks.
onAfterOrderActivate
onAfterOrderRenew
onAfterOrderSuspend
onAfterOrderUnsuspend
onAfterOrderCancel
onAfterOrderUncancel
onAfterOrderDelete

By defining plugin in product configuration you can retrieve that information in Hook and perform your actions.

So do you type one of the above event names into the plugin field? and then create a hook using that event name?

Do you have a code snippet example?

I have created starting guide for Custom Event Hook using plugin value
Check it at https://gist.github.com/1824466

Should I create a php file named Custom.php and put the code you provided and put the php file into the root folder of boxbilling?


Support also GKE 5.4 kernels (ubuntu-generic builder)

Signed-off-by: Leonardo Di Donato<EMAIL_ADDRESS>What type of PR is this?
/kind feature
Any specific area of the project related to this PR?
/area pkg
What this PR does / why we need it:
This PR adds to the ubuntu-generic builder the ability to find GKE 5.4 kernels too.
The URLs are very similar to the GKE 4.15 kernels except for a part in the end that contains the ~18.04.1 string. For this reason, since this string can change in the future, I preferred to explicitly list this other URL structure rather than using regexp or something like that.
Which issue(s) this PR fixes:
NONE
Special notes for your reviewer:
To test it use a YAML like this:
kernelversion: 37
kernelrelease: 5.4.0-1035-gke
target: ubuntu-generic
output:
  module: /tmp/falco_ubuntu-generic_5.4.0-1035-gke_37.ko
  probe: /tmp/falco_ubuntu-generic_5.4.0-1035-gke_37.o

Does this PR introduce a user-facing change?:
new: ubuntu-generic builder support GKE 5.4 kernels too

[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by:
To complete the pull request process, please assign leodido after the PR has been reviewed.
You can assign the PR to them by writing /assign @leodido in a comment when ready.
The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by:
To complete the pull request process, please assign leodido after the PR has been reviewed.
You can assign the PR to them by writing /assign @leodido in a comment when ready.
The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

LGTM label has been added.  Git tree hash: 3abffd1f01bbb41ab19e50a90dbe6341be891fcf

LGTM label has been added.  Git tree hash: 3abffd1f01bbb41ab19e50a90dbe6341be891fcf

[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: fntlnz
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

OWNERS [fntlnz]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: fntlnz
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

OWNERS [fntlnz]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

LGTM label has been added.  Git tree hash: 3abffd1f01bbb41ab19e50a90dbe6341be891fcf

LGTM label has been added.  Git tree hash: 3abffd1f01bbb41ab19e50a90dbe6341be891fcf


Remove datacat module from Richard Clamp

Pull Request (PR) description
Remove datacat module from Richard Clamp
This Pull Request (PR) fixes the following issues

https://github.com/voxpupuli/puppet-elasticsearch/issues/980

Pull request acceptance prerequisites:

[x] Signed the CLA (if not already signed)
[x] Rebased/up-to-date with base branch
[x] Tests pass
[ ] Updated CHANGELOG.md with patch notes (if necessary)
[ ] Updated CONTRIBUTORS (if attribution is requested)

Could i do something more ?

Could i do something more ?

The heads up is fine: I wanted to let the opportunity for another review / somebody to raise concerns before this get merged and without further GitHub notification I lost it.


Icon issue on Debian 12

Getting the following output after installing on Debian 12. Missed anything?


feat(update_replication_factor#10): support to get/set the replication factor of each table by shell and add max_reserved_dropped_replicas to config file

https://github.com/apache/incubator-pegasus/issues/865

Could you please add this command also in admin-cli ?

Could you please add this command also in admin-cli ?

OK, sure.


Lapack.lib creating warning during compilation

Reported by garron.fish on 10 Feb 2014 09:37 UTC
When Lapack.lib (that is part of the Dymola installation) is linked to a Microsoft Visual Studio project with the /MD compiler flag the following warning is generated: "LINK : warning LNK4098: defaultlib 'LIBCMT' conflicts with use of other libs; use /NODEFAULTLIB:library".
I think this is because Lapack.lib is compiled with the /MT compiler flag.  May be adding LIBCMT.lib to the Ignore libraries list in the Lapack project linker settings before compilation will resolve this issue.

Migrated-From: https://trac.modelica.org/Modelica/ticket/1418

Comment by sjoelund.se on 10 Feb 2014 11:06 UTC
This is a tool issue, so you should contact the tool vendor for support.


feat: support to generator Java code from a HTTP testCase

根据golang_generator实现java_generator
#366

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

By the way, it's totally ok but it's not recommended to use your master branch to create a PR. See also my detailed explanation if you are interested in it.
This comment will not block the merge process. You can try it in your next PR.

The unit tests failed due to the following lines:
https://github.com/LinuxSuRen/api-testing/blob/e05ff4b485e0c525ea7f78b4d653ddc230c5716e/pkg/server/remote_server_test.go#L596
The number should be 4 because you just add a new one.

I noticed that I didn't test remote_server_test.go locally, I only ran code_generator_test.go. how should I run all the tests locally to make sure they all pass before submitting the PR?

how should I run all the tests locally to make sure they all pass before submitting the PR?

You can run make test

So happy to have you as the 15th contributor. Hopefully this project could help you in some way.

That's great! This project is awesome I will continue to research and contribute to the project🤩

It's great!

I noticed that I didn't test remote_server_test.go locally

hi @Agility6 , I'm wondering if you are interested in to create a PR template for that. Make a check list for all PRs. So the new contributors will know what they need to do.

I noticed that I didn't test remote_server_test.go locally

hi @Agility6 , I'm wondering if you are interested in to create a PR template for that. Make a check list for all PRs. So the new contributors will know what they need to do.

😁 My pleasure and I am very willing to try to do this. This is my first time doing this and I may need to learn how to complete this a PR template" first.


Implement Consul ACLs

Create a role to set up initial Consul ACLs
references:
http://www.consul.io/docs/internals/acl.html
http://www.consul.io/docs/agent/http/acl.html
http://python-consul.readthedocs.org/en/latest/#example-uses
https://www.mauras.ch/securing-consul.html

Basic consul ACL's have been added. We're developing a tool that will allow ACL management via command line, which can then be integrated with cluster provisioning.

Related: PR #603

This is a large enough change we are going to push to 0.5

fixed in #603


bump api-shcema-builder version

Coverage remained the same at 99.115% when pulling 6bfcd11afcfa50f3152c512a81034952b3e9352e on bump-api-schema-builder-version into a8c2e158f06bc207f0d790863b6bbe9d9b53f5ec on master.

Coverage remained the same at 99.115% when pulling 6bfcd11afcfa50f3152c512a81034952b3e9352e on bump-api-schema-builder-version into a8c2e158f06bc207f0d790863b6bbe9d9b53f5ec on master.

Coverage remained the same at 99.115% when pulling 6bfcd11afcfa50f3152c512a81034952b3e9352e on bump-api-schema-builder-version into a8c2e158f06bc207f0d790863b6bbe9d9b53f5ec on master.


Add Hindley–Milner for generics

@jfecher what are your thoughts on this ?

This is effectively how we handle generics and type checking in general already so it is implemented.
We have some differences since we require explicit top-level signatures but under the hood our system is closer to HM than bidirectional since we never pass down types.


Squarify shouldn’t be stable by default? How to reset?

The squarified treemap layout stores the squarified layout in node._squarify. This means you can clear the metadata to recompute a non-stable layout like so:
treemap(root.eachBefore(function(d) { delete d._squarify; }));

Yet this is non-obvious and not documented.

[ ] Should the squarified layout store the metadata by default?
[ ] Should the squarified layout compute a stable layout by default if metadata is present?
[ ] How does one clear the stored metadata to compute a fresh layout?

You can always clone a hierarchy using node.copy, so I don’t think there’s a need for an explicit clear operation. And, not storing the computed metadata feels like a trivial optimization, so better to just do it by default.


file access error

Build server has 5 build agents.
Two are building using the same artifact.
One has the following error.
The process cannot access the file 'C:\ProgramData\NavContainerHelper\Extensions\onprem-Applications-16.4.14693.15859-IS\Microsoft_Tests-TestLibraries_16.4.14693.15859.runtime.app' because it is being used by another process.

That error has probably always been there.
If you use -doNotUseRuntimePackages, then this error shouldn't appear.
I will put a mutex around this (like artifact download)

Perfect!

Note that this fix will only be made in BcContainerHelper


Util api

Codecov Report

Merging #13 (f8a7b01) into main (2429eb7) will decrease coverage by 3.14%.
Report is 1 commits behind head on main.
The diff coverage is 93.69%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #13      +/-   ##
==========================================
- Coverage   95.87%   92.74%   -3.14%
==========================================
  Files           2        3       +1
  Lines          97      124      +27
==========================================
+ Hits           93      115      +22
- Misses          4        9       +5

Files
Coverage Δ

lib/index.js
100.00% <100.00%> (ø)

lib/vpqr.js
90.90% <100.00%> (-4.79%)
:arrow_down:

lib/util.js
92.78% <92.78%> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b6a662b...f8a7b01. Read the comment docs.


JS: Port table_sorting.coffee from coffeescript to ES6

Thanks for creating an issue! Please fill out this form so we can be sure to have all the information we need, and to minimize back and forth.

What are we trying to do?

We're porting our custom javascript to ES6! This ticket is to port over:
table_sorting.coffee into app/javascript/src/table_sorting.js

What feature or behavior is this required for?

Long term project health and maintainability, plus an opportunity to clean up some of our messes when we wrote this the first time.

How could we solve this issue? (Not knowing is okay!)

Rewrite the coffeescript in app/assets/ to be ES6 in app/javascript/src.

Anything else?

See #1679 for an example of this with the clinic_finders js.
If this winds up requiring adding dependencies or something, please hit me up in slack!

Looking into this one :eyes:


Using batch mode to receive messages in function handle_normal

Development Task
Issue:

Here is a mpsc model chan, but we don't need this chan as a timing notificator (the batch-system's fetch_fsm chan already did the notificator job).
To receive messages from this chan one by one is a waste, the chan could be replaced by Mutex<vec>, then we could get messages from the vec in batch mode.
All write-request messages need to go through this channel, so improve this might improve the performance, especially when running on an NVMe disk.

Previous work by Jay: https://github.com/tikv/tikv/pull/5419

#5419, which contains several improvements, using queue instead of channel is one of them. I doubt if Mutex is better choice though, first, the difference between Mutex and lock free queue may not be that significant as the place is not performance bottleneck; second, using Mutex can cause lock conflict between grpc server threads and unified thread pool, the former needs to send raft messages, the latter needs to send read/write proposals.


Make liveness health port configurable

Ran below 2 test cases:
Test1:
Run with configured liveness port health-port value of 9821. Below CSI driver pod 'describe' output shows the liveness probe correctly running with health-port value of 9821.
kn describe pod/ibm-spectrum-scale-csi-6fx9z
liveness-probe:
...
Args:
--csi-address=$(ADDRESS)
--v=5
--health-port=9821
ibm-spectrum-scale-csi:
...
Liveness:       http-get http://:9821/healthz delay=60s timeout=20s period=30s #success=1 #failure=10
Test2:
Test to modify operator.yaml to change LIVENESS_HEALTH_PORT to non-default port "9810" as follows:
- name: CSI_DRIVER_IMAGE
value: quay.io/madhuthorat/ibm-spectrum-scale-csi-driver-dev:d51
- name: LIVENESS_HEALTH_PORT
value: "9810"
Below CSI operator pod 'describe' shows the modified environment variable LIVENESS_HEALTH_PORT:
kn describe pod/ibm-spectrum-scale-csi-operator-6b9949b96-qkzlg
Environment:
  MAX_CONCURRENT_RECONCILES_CSISCALEOPERATOR_CSI_IBM_COM:  1
  MAX_CONCURRENT_RECONCILES_SECRET_:                       1
  ANSIBLE_DEBUG_LOGS:                                      False
  WATCH_NAMESPACE:                                         ibm-spectrum-scale-csi-driver (v1:metadata.namespace)
  CSI_DRIVER_IMAGE:                                        quay.io/madhuthorat/ibm-spectrum-scale-csi-driver-dev:d51
  LIVENESS_HEALTH_PORT:                                    9810

Below CSI driver pod 'describe' output shows the liveness probe correctly running with health-port value of 9810.
kn describe pod/ibm-spectrum-scale-csi-qj6v2
liveness-probe:
...
Args:
--csi-address=$(ADDRESS)
--v=5
--health-port=9810
ibm-spectrum-scale-csi:
...
Liveness:       http-get http://:9810/healthz delay=60s timeout=20s period=30s #success=1 #failure=10
The above shows the change of LIVENESS_HEALTH_PORT value was effective


use hypercontaienr-utils/hlog instead of glog for some cases

context info will be well formatted.
And add some logs for the keep-alive check.
Signed-off-by: Wang Xu<EMAIL_ADDRESS>

LGTM


Problem when installing LLGO on MAC OS 11

When executing the "brew install llvm@17 pkg-config libgc" command when installing LLGO on MAC OS11, there will be no progress for a long time and the installation cannot be successful. The problem is solved after updating to MAC OS 13.6.7

there will be no progress for a long time and the installation cannot be successful.

Sounds like a network access issue. Try using a different network or a VPN.

there will be no progress for a long time and the installation cannot be successful.

Sounds like a network access issue. Try using a different network or a VPN.

I tried it, but the same situation still occurred. Because an old version system warning appeared when executing the command, I tried to update the system and succeeded. People around me also succeeded after updating the system.

homebrew didn't provide bottle for macOS 11 aka BigSur: https://github.com/Homebrew/homebrew-core/blob/e2cf81a217c17a19acf5bc3bbc4579109d815b38/Formula/l/llvm%4017.rb#L14-L22
So when you install it, homebrew will try to build it from source, which take a very long time depending on your CPU, and usually get failed by OOM.


Split tests into separate files for Accessors, Mutators and Initializers

#31 2nd checkbox

[x] Accessors
[ ] Mutators
[ ] Initializers

:+1: I like this change.


add autoformatting

The issue was that none of the formatting changes were in the diff.  That's an expected feature of reviewdog...


Game crash on startup with cheatmode on

I can confirm now. With cheat mode on, the game crash on startup. Otherwise, it works perfectly.

What version of Community Patch are you using? Any other mods?
Also, most if not all of our devs test with cheat mode on, so...

Yeah I always test with cheat mode on
@peren717 in addition to tyler's questions, are you using an alternate launcher? Does it work without the other mods and without the alternate launcher?

v0.0.2-hotfix-5. I uninstalled Vortex and I did a clean re-install of the base game, so that problem went away... I think it might be a bug introduced by Vortex.


Ability to use SERVICE_x_NETWORK

Based on #498, allows specification of the Docker network for the specific service and port if -internal configuration is set. This is similar to #316 but allows individual services to specify which network they must use rather than default to one network (for example, in environments where services are mixed on bridge and overlay). Service uses SERVICE_x_NETWORK or SERVICE_NETWORK to choose the network.

Yes please!

Can this be merged please? Right now there is no way to pick the correct network/interface for the service being registered, when the container is attached to multiple networks.

Please merge this pull request guys!


[gssoc'23] show List files in a directory

Hi @avinashkranjan
Aim

What is the objective of the Script
to display list of file content available in current directory

Details

What the features will your script have
script shows how to get the list of a specific directory in python using the os module.

Please assign it under gssoc'23 label
Thank you

Go Ahead @gulshanjakhon


Automated tests

At the moment, the best we can do when checking a PR is to verify that stable builds. We have no automated tests of basic functionality. I'm opening this issue to collect and track thoughts on what tests we should add.

@jemc @Theodus any thoughts on what automated tests for stable would look like?

Maybe it could be an integration test that sets up an example bundle.json that clones its own repo (pony-stable), and imports some types to prove that it worked?

@jemc i was just thinking the same thing. and then compile the program with stable env ponyc.
we can verify

bundle file is correct after the add (this could be expanded for each type eventually)
stable env ponyc compiles program

eventually i think we'd want to test other features like

tag
local-git
github
stable add

@rawkode any interest in this one? it's a little more advanced but probably manageable as a start. there's a bit of "how much can we use ponytest for" (a lot see https://github.com/ponylang/changelog-tool/blob/master/tests/main.pony tests)? and some would have to be some kind of automated integration test(s), so there's a bit of complication but its pretty straightforward. if you are interested, i'd say drop idea here for tests and what the runner would be and @jemc and I could give feedback.

@SeanTAllen Yeah, I'll look at what I can do and come back with a plan :+1:

@rawkode assume. i just sent you an invite to be part of our "contributor" team. it doesn't give you much in the way of privileges but does allow for you to appear in the "Assignee" list and be assigned to issues you are interested in working on. Baby steps towards committer!

So this is pretty tough.
My initial thought is that we need a JSON Schema that will evolve with the tool and provide a means of documenting the format for other integrations; as well a confidence that stable conforms with said schema.
From what I can tell, we could probably use ponytest for arbitary comparison tests, but it wouldn't be pretty and we'd need to provide the json for comparison. Which means, in order for the test not to be flaky, we need to add branching/tag/commit sha support to stable add
assert_eq("json", loaded_bundle.json)

Hopefully any assumptions I've made are correct :smile:

I'll try pushing this forward. #70 gets some scaffolding in place, leaving open the following test TODOs:

[ ] stable fetch
[ ] stable add
[ ] stable env


Allow generalized scaling and rotation of shapes

The Canvas and SVG APIs both allow affine transforms of arbitrary things. Rather than support it as a one-off feature per shape (#44, #345), we should let it happen to anything.

We'd want to make editable text fields make sense, so here's a link to a rotated editable text field example: https://jsfiddle.net/k8smufru/

I just need to rotate entire image. Will i?

When does it support rotation?


Enhancement: show ruler button on iframed worldmap

When looking at the Worldmap the ruler button appears under the zoom buttons:

When inside an iframe within the dashboard UI, this button vanishes:

I can't see any documentation on how to get this to appear?
I'm guessing this disappearing is part of getting rid of the top bar when in the iframe? Might be an idea to have an option to toggle whether it should be there or not?
Edit: Happy Easter!

it might be an idea. The thinking was when in dashboard mode there is not much space to be doing things like measurements etc - so why clutter the screen with extra controls.

Is there a way I can feed a command to the map to make the button appear?

not yet

Ok - if

set visible then the ruler button will also appear.
pushed as version 2.3.6  (also include a better fix for the tracks of array of points)


Update sbt-scoverage to 1.9.3

Updates org.scoverage:sbt-scoverage from 1.9.2 to 1.9.3.
GitHub Release Notes - Version Diff
I'll automatically update this PR to resolve conflicts as long as you don't change it yourself.
If you'd like to skip this version, you can just close this PR. If you have any feedback, just mention me in the comments below.
Configure Scala Steward for your repository with a .scala-steward.conf file.
Have a fantastic day writing Scala!

Ignore future updates
Add this to your .scala-steward.conf file to ignore future updates of this dependency:
updates.ignore = [ { groupId = "org.scoverage", artifactId = "sbt-scoverage" } ]

labels: sbt-plugin-update, early-semver-patch, semver-spec-patch, commit-count:1

Superseded by #447.


[docs-only] [chore] Update helper generated envvar yamls

The extended_vars.yaml and env_vars.yaml need regular update on envvar changes. This PR takes care on. Admin docs only relevant.

Hmmm - looks like it auto-merged when I clicked approve! I hope that it doesn't "break the internet".

No it does not 🤣
I will file a new PR to correct the typo.
Regarding 5.0 or pre5.0, this is all correct even it seems not to be so. The helper process gathers all stuff from the ocis code. Sometimes this can be a bit confusing like with
OCIS_SERVICE_ACCOUNT_ID; ACTIVITYLOG_SERVICE_ACCOUNT_ID. The OCIS_ envvar was introduced in 5.0, the ACTIVITYLOG_ envvar is the local variant of the global one introduced last week. By design, it is therefore not a new envvar (...) as the global one existed before. Local overwrites global if set, else global is taken.
Hope this makes it more clear.


Update README with other prerequisites

Added some prerequisites I picked up, installing into a new VM.

Hi,
Thanks for your contribution. Can I get you to sign the CLA, see https://github.com/deepmind/rc-data/blob/master/CONTRIBUTING.md?
Thanks,
Lasse

Signed contribution license agreement on behalf of myself. Sorry about the odd delay.

Thank you


Make yelp_polarity streamable

It was using dl_manager.download_and_extract on a TAR archive, which is not supported in streaming mode. I replaced this by dl_manager.iter_archive

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint.

The CI is failing because of the incomplete dataset card - this is unrelated to the goal of this PR so we can ignore it


static private methods and protected/private static fields do not work.

Example:
class foo {
    private static var a = 1;
    public static var b = 2;
    protected static var c = 3;

    private static function d() {
	return b;
    }
    public static function e() {
	return foo.b;
    }

    protected static function f() {}
}

The definitions for d and f are done outside the class declaration. It is correct for the public static method/field, but incorrect for the others.

Thanks again, and sorry for the delay.  It's been fixed!


How to Install the SCIP-SDP Plugin on Windows?

I am a beginner in MISDP and would like to further study this problem. However, I encountered some difficulties while installing the plugin and would appreciate your guidance. Thank you for your valuable time.
Could you please advise on the specific differences or additional considerations that need to be taken into account when installing on a Windows system, as opposed to Linux? I noticed that the installation file is based on Linux instructions, but I encounter various parameter issues when compiling with MinGW on Windows. Could these problems be caused by system differences?

Yes, the installation is mainly written for Linux, but should be very similar on MinGW (or the WSL). Have you been able to compile SCIP?

Since I directly downloaded the SCIP for Windows, no additional compilation was needed during installation. In addition, I would like to inquire further: given that I am currently using Python to construct the MISDP model, after installing the SCIP-SDP plugin, will I be able to use SCIP-SDP through Python?

So far, there is no Python interface to SCIP-SDP. Depending on the interest of users, I might implement one in the future.

@pfetsch what is the status on that?  I would be interested in a python interface.

@pfetsch what is the status on that? I would be interested in a python interface.

Thanks for your interest. I will put it on my list, but this might take a while.


Question and answer environments produce XeLaTeX errors

Using the following example mark up from the README.adoc file produces errors when the tex output is processed with XeLaTeX.
  [env.question]
  --
  What is the speed of light?
  --

  [click.answer]
  --
  300,000 km/sec
  --

The resulting error is summarised by the following output.
! LaTeX Error: Environment question undefined.

and
! LaTeX Error: Environment answer* undefined.

Similar problem occurs when the examples/click.adoc is processed. Errors occur for the message, hint, solution and advice environments.


Add support for Ruby syntax highlighting

Adds support for Ruby Syntax highlighting
Closes https://github.com/magidoc-org/magidoc/issues/195

Amazing, thank you very much! I'll deploy that right away in version 3.5.0.


Update to the new Travis CI infrastructure.

http://docs.travis-ci.com/user/migrating-from-legacy/#Why-migrate-to-container-based-infrastructure%3F

Er, looks like we are not getting the compiler we want. My suggestion for priority: low :)

According to [C++0x/C++11 Support in GCC table] template alias should be supported in g++ 4.7. Which compiler are we getting in the end?
Interestingly, libsass seems to compile just fine with the default gcc 4.6.3. So the new V8 is quite picky about the compiler. Can we ask for g++ 4.7 only for io.js 3 in the new infrastructure? (besides it does not seem to work)

It looks like I can install gcc/gcc 4.7 but I can't alias gcc/g++ to the newer versions without sudo.
I agree this isn't a high priority. I just wanted to take a run at it before going to bed. The slow Travis times are also starting to bug me.

That should be relatively easy, then. If the compilers are named gcc47 and g++47 we just need to call /usr/bin/env CC=gcc47 CXX=g++48 LINK=gcc47 LINKXX=g++47 npm install

Looks like this works now. I've some intermittent Travis failures which don't instill me with confidence.


Referencing a Theoretical Model within a Theoretical Model

Currently you can't reference a theoretical model in the description of another theoretical model, since the theoretical model LayoutObj is defined in the "Body.hs" code and the descriptions for the models are defined in the "Example.hs" code.
This could be fixed just by defining the LayoutObjs for the theoretical models in "Example.hs" instead of "Body.hs", but I'm not sure if that's something we'd be okay with doing?

I think we need to understand what each of these things really mean to understand if we're ok with that.  What do you really mean by 'reference' here?  Link to or reuse parts of?  What you wish to do matters.

Link to. Sorry for the ambiguity!

Then I would say that you need to split up your models, one per file.  Then you can have an order to the models (as X refers to Y).  The other examples were really small, so it made sense to use a single file.  Once they get bigger, it is best to split them up.  Which, as a bonus, makes it easy to define "base" models and then other models that depend on those.

Okay, that sounds good. Thank you!

This is an issue that is still present in other examples. SSP has 34 of these models/definitions so I'm not sure if we want 34 additional files for each model/definition.

Right, files is not the only way to split things up.  We do need a way to be able to reference models (by their ids?) and 'order' and 'link' them.

Bumping now that addLabels is merged. - @JacquesCarette who should be assigned to this issue? It seems like we now have the infrastructure to accomplish your fix.


[Blazor] Generic type parameter support - inappropriate samples and explanation

Description
TBH, most of the Generic type parameter support section, starting with "The following subsections provide examples of the preceding approaches using the following two ListDisplay components," feels more like a compilation of test cases than actual user documentation.
The component definitions feel contrived, and the scenarios are presented in a "when-then" format, resembling specification documents with acceptance criteria rather than educational content.
I'd prefer guidance like "If you want to achieve X, do Y," featuring more practical examples. We probably don't need an exhaustive list of samples for every conceivable scenario. Just one or two well-chosen examples would suffice to introduce the core concepts.
If you're on board, I'm willing to tackle this, though it's a bit more work than I currently have bandwidth for.
Page URL
https://learn.microsoft.com/en-us/aspnet/core/blazor/components/generic-type-support?view=aspnetcore-8.0
Content source URL
https://github.com/dotnet/AspNetCore.Docs/blob/main/aspnetcore/blazor/components/generic-type-support.md
Document ID
4cf5fe5c-43ca-ccd8-d503-0b47bb0c4883
Article author
@guardrex

By design for the most part. We don't intend for devs to conceptually learn generic types here. We link to the C# docs for that. This is a reference article only intended to show/explain how Razor components work with generic types. The examples are contrived to make the presentation simple. Unless you have a technical error to report, I think we'll stick with the current guidance.

This could take on additional practical/real-world use cases for one or several of the simple examples. However ... as you mentioned for your own workload ... I'm swamped with work. Someone would need to take it on, and I'm not keen on leaving an issue on the backlog for something that is never reached.

I'm OOF for the rest of the day. Let me take a closer look on Tuesday morning and get back to you.

I'll take care of this. I see several things that I'd like to do, and I'll address most or all of your concerns in the process.


Age of Empires 2 Definitive Edition stutters unless apitrace mode is set

Software information
the game stutters regular intervals with dxvk, it's very noticeable online and as the game goes on it only gets worse. One other way to repro 100% of the time  is to run the ingame benchmark: small stutters can be noticed (they are much more subtle this way and you might think it's just the benchmark that it's heavy but it's not that) every few second for the whole duration. This also does not happen with wined3d and the game runs as expected.
It might be a game bug since the same (or at least very similar) issue happens on windows for some people (seems the common thing is having an amd gpu), so it might not be reproducible on other hw.
Having apitrace mode on also makes the benchmark score noticeably higher (at least 100-150 points on my laptop, 150-200 on my desktop), so it's not just placebo.
The bug has been present since one game update about a year ago, and I have played it on several wine, proton, dxvk build over the months.
System information

GPU: happens both on a vega 8 laptop and a 6700xt
Driver: happens both on current mesa stable and various git builds
Wine version: tried proton experimental, 6.3 and various GE builds
DXVK version: lastest master, but it also happens on older versions

Log files
the logs are taken on my vega 8 laptop without apitrace mode
AoE2DE_s_d3d11.log
AoE2DE_s_dxgi.log

Can't confirm, getting the same benchmark score with and without apitrace mode here. Also means that enabling it won't hurt though.


Another @role exploit!

Do >ttt @role or <@&roleid> and even if you dont have perms it will mention that role!
another exploit present

Bearing in mind even if you dont have permission to mention roles you can still mention using role ID

Hello! Same response as #23, the bug should be fixed thanks to latest commits [ 1c7df31258a70f9dadee2a4a50cdb7d4280ece46 11d507fbceec9178135d322ce12db413ed99d8e0 ].
A new release will be out soon.. Really sorry about that!

Result with the latest development build:

As you can see, there is no more member mention in that message.


It doesn't work on windows

Here below are the log messages:
ERROR in ./~/babel-loader/lib?presets[]=es2015&presets[]=stage-2!./~/vue-loader/lib/selector.js?type=script&index=0!./.nuxt/App.vue
Module not found: Error: Can't resolve 'I:Projectscms
ode_modules
uxtlibappcomponents
uxt-error-debug.vue' in 'I:\Projects\cms\.nuxt'
 @ ./~/babel-loader/lib?presets[]=es2015&presets[]=stage-2!./~/vue-loader/lib/selector.js?type=script&index=0!./.nuxt/App.vue 7:62-141
 @ ./.nuxt/App.vue
 @ ./.nuxt/index.js
 @ ./.nuxt/client.js
 @ multi app

The main problem is that some imports / System.imports in generated code under .nuxt folder doesn't escape the directory path \:
const _eb75b49c = process.BROWSER ? () => System.import('I:\Projects\test\pages\index.vue') : require('I:\Projects\test\pages\index.vue')

import NuxtError from 'I:\Projects\test\node_modules\nuxt\lib\app\components\nuxt-error-debug.vue'

Can we use relative path and forward slash / or escape backslash in the path?

Hi @andyhu
It's now working in version v0.5.1

Thanks @Atinux for the prompt response as well as your awesome job. Much appreciated!

Still have 1 issue:
require('~plugins\\\\element-ui.js')

now plugins are double escaped

I will take a look, sorry about this.

Fixed in @0.6.1


Particle sample of Three.js requires ES6 module version of SPE.js

I updated the Three.js sample to ES6 version.
However, the SPE.js used does not support the ES6 module, so the Particle sample cannot represent smoke.
https://cx20.github.io/webgl-test/examples/threejs/complex/index.html

I tentatively used the fork version of SPE.js to get the sample working.
https://github.com/cx20/webgl-test/pull/71
However, since it is not an ES6 module version, it will not work after a few months.


docs: fix incorrect comment

Description: self-explanatory
Risk Level: N.A
Testing: N/A
Docs Changes: included
Release Notes: N/A
Signed-off-by: Derek Argueta<EMAIL_ADDRESS>

/retest


Git use native git

@avafanasiev afaik, test data should be fixed, since example was not parsed correctly
diff --git a/file.txt b/file.txt index a0f420a..83433a8 100644 --- a/file.txt +++ b/file.txt @@ -2,0 +3 @@ +5 @@ -5 +6,2 @@ -4 \ No newline at end of file +4 +6 \ No newline at end of file
means:

add 1 line starting from 3
remove 1 line starting from 5 (was 6 before)
add 2 lines from 6


Link to Cloudformation template with API Gateway/Lambda function broken in Lab 7

The link to cloudformation template to install an API Gateway/Lambda that connects to the SageMaker Endpoint  is broken or file missing. It would be extremely helpful to have this working.
Link to template is in this chapter:
https://catalog.us-east-1.prod.workshops.aws/v2/workshops/63069e26-921c-4ce1-9cc7-dd882ff62575/en-US/lab7#create-lambda-function-and-api-gateway

Actually all files are missing for this lab - Flink-Async-IO-1.0.jar and data.py

Could they simply be added to this repo?


Update to Ng 2 rc 1

Hello and thanks for such great repository and your presentation in Build
I started with this example and even raised an issue that got solved by having 2 copies of the ng 2 polyfill, the min version (loaded at the beginning of index.html) and the normal version again at the end.
This is the way you have the index.html and providing a copy in the build, it fixed all problems.
Now, I moved to the ionic beta 7 that most importantly, uses Angular 2 rc 1, one of the requirements was to stop using the polifyll and start using zone and reflect. I tried to stop using the polyfill version at the beginning but still doesn't work.
So, I have the polyfill min version that is being called at run time when it wasn't supposed to being called.
Of course, this is a bit confusing and even unpredictable.
My question is, why do the index needs the min copy of the polyfill and is there a way to avoid or change to something else...
Thanks in advance.

Hi. the polyfill was a requirement for that version of angular. We are planning to update this sample to Beta 7. so stay tuned !!

ok, thanks... counting the seconds!
and beta 8 is out... just saying...

Updated to Beta10


Site is slightly zoomed in on mobile

When first loading the page, it appears to be zoomed in and requires the user to scroll out.

From reading closer, it appears that the viewport width may not match the screen size.

This might be down to the images I chose; the "hero" image on the main page may be too large.


Phusion Passenger not running with Fullstaq Ruby

Trying to use an apt-installed version of fullstaq ruby with Passenger and Nginx on Debian 11 installed via the recommended process from the Passenger website
I am noticing that passenger is booting using the default OS provided Ruby rather than the specific version we install from the Fullstaq repo.
App 101885 output: Error: The application encountered the following error: Your Ruby version is 2.7.4, but your Gemfile specified ~> 3.1 (Bundler::RubyVersionMismatch)

I have .ruby-version and a ruby version in the Gemfile. Accessing the folder via ssh and running ruby -v returns correct ruby version (3.1).
I also found a recent stackoverflow question with exactly the same content I would've asked. https://stackoverflow.com/questions/73720856/phusion-passenger-running-with-fullstaq-ruby
Linux distribution: [Debian 11]
Package name: [fullstaq-ruby-3.1-jemalloc]

Also tracking at phusion/passenger#2453

passenger_ruby should work as expected. Maybe there's an issue with PATH that makes Passenger detect the system Ruby instead. If you set passenger_log_level 7 then you should be able to see in the debug output which Ruby was chosen and what the PATH was.


View Components need refactoring

Currently, use paired tags (<x-foo></x-foo>) only works when we override an ini setting.  It does this to store the info in the middle $slot of the tags, and hits PHP's built-in limits, so I've currently got those turned off.
This needs to be refactored to get around this.
One idea I've had (and is just something rumbling around inside my head) would be to modify the preg_replace_callback() being currently used to modify the tag name with a unique id. It would then save the info needed to replace those tags with. This helps ensure that the correct opening/closing tags are discovered, and then the open and close tags would have to be modified separately.
Not sure if this would work as I think, and I have a feeling it would maybe lose out on some features, but I wanted to include it here so I didn't forget it when I could come back to it. Or if anyone else beats me to it.

I fixed an issue with the speed of it, and doesn't seem to need the ini_set to work. However, it is still too greedy.
For example:
<x-admin-box> ... stuff ... </x-admin-box>
<x-admin-box> ... stuff ... </x-admin-box>

These are currently being grabbed and treated as one big component, instead of two separate ones.
Need to massage the regex on that one.

Hey @lonnieezell, first off, thanks for your work, looking forward to using Bonfire2 in future projects :)
I've had a similar need to use view components in CI4 and did some research to check out what could be done. Looked at integrating Laravel's Blade at first or creating my own logic but I stumbled on this project and saw you've had a similar implementation.
So, I took out your ComponentRenderer class and adapted it to what I needed. And naturally, I've had the same issues you're facing. I've managed to fix the one you're having currently (i.e. when you declare the same component several times in a row, it breaks).
Removing the ? after the <slot>. seams to fix it:
- $pattern = '/<\s*x[-\:](?<name>[\w\-\:\.]*?)(?<attributes>[\s\S\=\'\"]*)[^>]?>(?<slot>.*?)<\/\s*x-\1\s*>/uiUsm';
+ $pattern = '/<\s*x[-\:](?<name>[\w\-\:\.]*?)(?<attributes>[\s\S\=\'\"]*)[^>]?>(?<slot>.*)<\/\s*x-\1\s*>/uiUsm';

Hopefully it helps!

Oh nice! I'll have to give that a go tonight. That didn't slow it way down did it? That was one of the changes I made to get make it less greedy (in theory anyway :) ) which brought my requests from near 700ms for the Email Settings page back down to normal CI speeds.
Thanks for reporting it, though! And if you have more ideas/updates for that, feel free to submit a PR for it. I'd love to have a great solution we can then maybe rip out into it's own repo.

That didn't slow it way down did it?

Still super fast CI speed I would say. Haven't tested it thoroughly though, I'll be building UIs with it in the coming weeks, I'll let you know.

And if you have more ideas/updates for that, feel free to submit a PR for it. I'd love to have a great solution we can then maybe rip out into it's own repo.

One thing I've changed regarding the pattern is having PascalCase named components instead of the blade x- naming. I wanted to keep the conventions used in the front-end world as I'm used to them. So, instead of <x-foo>, I would have <Foo>. Also, apparently it's faster not to have the regex case insensitivity option. I don't know the reason behind the x- choice so I may be missing something here.
Another thing I've done is to call the nearest component available to a module. This would allow overwriting components outside of the current module. For example, let's say we have the base app module where we have a Button component, and an admin module also with a Button component: the admin views would show the Button component from the admin module.

Still super fast CI speed I would say. Haven't tested it thoroughly though, I'll be building UIs with it in the coming weeks, I'll let you know.

Sounds great. Thanks! I should be able to make that change tonight and give it a bit of a spin, too.

I don't know the reason behind the x- choice so I may be missing something here.

Honestly, I kept it like Laravel had been handling it in this case, mainly because it made a bit of sense if you think about custom header names frequently starting with x- (even though the spec deprecated that years ago). I haven't tested it but I would think it might be a little faster since it has that slightly more specific bit, but not really sure. HTML5 prefers to keep everything lowercase, but I believe some of the front-end frameworks do their custom elements with mixed case names, so there's a precedent either way, I'd say.

Another thing I've done is to call the nearest component available to a module. This would allow overwriting components outside of the current module. For example, let's say we have the base app module where we have a Button component, and an admin module also with a Button component: the admin views would show the Button component from the admin module.

That's a nice touch! If you're up for a quick PR I'd love that change integrated.

That's a nice touch! If you're up for a quick PR I'd love that change integrated.

Will do!

@yassinedoghri thanks!
Also - just pushed a change removing the ? and that worked like a charm. Thanks for suggestion on that.


Use ParseDict to validate hook input

Use  google.protobuf.json_format.ParseDict to validate hook body input.
Example:
my config: dict # same as TransferConfig protobuf
parsed config: TransferConfig = ParseDict(my_config, TransferConfig())

I think validating locally can be done in init as long as all the parameters are passed in init (this will be "fail-fast" case). We should avoid running DB operations in init but validating params should be pretty OK.

There's one big argument against it: templated fields. Passing a dictionary with jinja templates may result that verification with ParseDict and proto will fail. We can move the verification step to execute but this will not be as fast fail fast as it would be in case of doing this in __init__.


Combination of lineWrapping, specialChars and non-breaking spaces can hang Chrome, Internet Explorer

This is super-obscure, and it can hang Chrome and Internet Explorer, but not Firefox.
Since the introduction of the specialChars option (I bisected for the issue: f0610e60c3b220814d80c133326adebc7339a35f), if you have a CodeMirror instance with lineWrapping enabled, and add the non-breaking space character U+00A0 to the default specialChars option (/[\t\u0000-\u0019\u00ad\u200b-\u200f\u2028\u2029\ufeff]/g), entering three consecutive spaces will actually insert one space, one non-breaking space, and one final space character. The non-breaking space will be displayed as a red dot. Interestingly, if you .getValue() on the instance, the result is just three space characters; no non-breaking spaces are present.
Now, where's the crash? Remove global flag from the specialChars option. Now, entering the first two spaces is fine, but entering the third results in an infinite loop and hangs the process. The loop occurs, I believe, in buildToken(): the condition to break the while-loop is never satisfied.
It's also worth noting that the documentation is out of date. It says that the default value of specialChars is
/[\u0000-\u0019\u00ad\u200b\u2028\u2029\ufeff]/

but it's actually
/[\t\u0000-\u0019\u00ad\u200b-\u200f\u2028\u2029\ufeff]/g

If you disable lineWrapping, this problem entirely disappears. Firefox doesn't exhibit this at all either way.
I've prepared a gist of a demo html file demonstrating the non-crashing variant of this.

These are two separate bugs -- attached patches should fix them. The code that ensured the specialchars regexp was always global didn't kick in when the option was given immediately on initialization. And the hack to replace stretches of spaces with alternating spaces and non-breaking spaces (to work around odd browser behavior in Webkit and IE) was kicking in before the special character filter, which produced the effect you saw.
As for \t not being mentioned as part of specialChars in the docs, that's intentional -- technically, tabs are treated special, and are only in there as an optimization.

What an incredibly fast turnaround for a ticket! Amazing. Thank you.
As for the docs, it's not just \t that's missing, it's also the character range \u200b-\u200f, and the (admittedly redundant) global flag. Are these also intentional?

Hi Team, still the "nbsp" issue persists. Can we reopen the issue, or any suggestion to display placeholder text?
using below, but seems hacky.
specialChars: /[\u00a0]/g,
specialCharPlaceholder: function(m, k) {
  console.log('-----check------', m, k);
  var span = document.createElement("span");
  span.appendChild(document.createTextNode("."));
  span.setAttribute("class", "my-class");
  return span;
}


Segmentation fault after page refreshing

Eve exit with a segmentation fault error after I refresh page, following is the output:
% build/eve

----------------------------------------------

Eve started. Running at http://localhost:8080

fixedpoint in 0.000036 seconds, 0 blocks, [ 2 ] iterations, 0 changes to global, 1 maintains, 0.000013 seconds handler
fixedpoint in 0.000014 seconds, 0 blocks, [ 1 ] iterations, 0 changes to global, 0 maintains, 0.000012 seconds handler
fixedpoint in 0.000054 seconds, 0 blocks, [ 2 ] iterations, 0 changes to global, 3 maintains, 0.000020 seconds handler
Segmentation fault

Dram, can you pull latest and confirm this behavior is still happening? There was an issue we identified and fixed this morning PST that might be related to this.

I'm pretty sure this is fixed by https://github.com/witheve/Eve/commit/0ad36a86371967d053a392cda2d1f27a8124a11a
So I'm going to close this. If you are still having an issue, I'll reopen it and we can investigate more.


[Agent] Provide plugins for Apache httpcomponent AsyncClient 4.1 #588

[Agent] Provide plugins for Apache httpcomponent AsyncClient 4.1 #588

#588

Coverage increased (+0.06%) to 23.136% when pulling 900cedc1c760c199ae3156d6937af536f209c37f on lytscu:develop into 5319d72f3f36954cb87691e5aab744471909ee03 on apache:master.

Coverage increased (+0.06%) to 23.134% when pulling dc931b33ddbf87f6f763067ca66a6a245126de9a on lytscu:develop into c45cdcb89701c49a28128f245bc94b256fdd0e20 on apache:master.

Coverage decreased (-0.03%) to 23.051% when pulling b633f0d385b4adb42747a9885911be47ab6ddd5d on lytscu:develop into c45cdcb89701c49a28128f245bc94b256fdd0e20 on apache:master.


Testing is OS-Specific (Windows)

Description
The ability to run any tests is OS-Specific (Windows)
Steps to reproduce
run python setup.py nosetests on Linux
Expected Behavior
More than one test should execute.
Actual Behavior
A TypeError is raised at tests/tools.py:423 for indexing into None.
Environment

Operating System: Ubuntu 20.04
Python version (output of python -V): 3.8.5
fixedpoint version: commit 0707499 (current master)

1-line Repair:
tests/tools.py:423
        directory = re.search(r'^(.+)\\__init__\.py', frame.filename)[1]

should read:
        directory = os.path.dirname(frame.filename)

This allowed me to execute tests.
If the TypeError being raised for indexing into None was being used to implicitly filter for __init__.py then alter to the following:
        if os.path.basename(frame.filename) != "__init__.py":
                raise TypeError
        directory = os.path.dirname(frame.filename)

I have not tested this code, but it is more likely to be backward compatible.

This seems like a pretty straightforward and minor change, would you care to be the first to make a pull request from a fork with those changes?


os/ec2: update link for china console

Missed in #1060
And I force-pushed too slowly to fix the elif typo and the 2 other places, whoops.

cc @robszumski

@robszumski is there an easy way for me to run the jinja templates on a local checkout btw?

@euank you can run a local jekyll if you'd like, or throw up those changes in the website repo and have it auto-build and stage them. Then you can close the PR when satisfied.


Implements asinh and acosh operations (partial fix for #7531)

Can one of the admins verify this patch?

@tensorflow-jenkins test this please

I ran the tests which failed here on my machine and found that the only cases which were failing are the ones in which tf.acosh evaluates to inf/-inf and np.arccosh evaluates to nan/-nan. Should I change the test cases or do something else? Any ideas on how to proceed?

@tensorflow-jenkins test this please

The failures in tests/build seem unrelated to the changes made by this pull request.

Jenkins, test this please.

The cwise ops test failure (only on Windows, ugh) is probably caused by this CL -- the tolerances appear to be too tight.

Any hints on how to proceed?

I would look at which test fails, exactly, and adjust the tolerance for that test in the test code. I think the values are still close so this is not a real problem, just numerics and a particularly unfriendly function.

If that is the case then this PR would have to wait for a few days since I do not have access to my machine and would be able to fix it only after the 16th.

No problem.

This test failure is not due to this PR. We'll review API changes on Monday, should be able to merge then.

Great, thanks!

Since the tests for acosh and asinh were passing, I have also added a commit which implements atanh thus completely resolving #7531. Please review.

@tensorflow-jenkins test this please

@rmlarsen //tensorflow/cc:gradients_math_grad_test is failing in Linux CPU Tests and MacOS CPU Tests but passes in Linux CPU Tests (Python 3) and Linux GPU. Are these failures due to some bug in the code?

I ran the test locally with python 2 and found that the test was failing due to some case for which numpy gave nan and tf gave inf. I have changed the test cases so that this does not happen. The test passes on my machine with python2 now.

@lakshayg is inf the mathematically correct answer? We should strive for compatibility with numpy whenever possible, even for arguments that give nan/in, unless it is clearly wrongf. Does this depend on the version of numpy? I'm OK with the PR as is, but perhaps add a TODO in the test code to investigate this edge case?

@rmlarsen Oh, I just checked and found that numpy gave inf and tf gave nan. WolframAlpha says that the value should be inf (http://www.wolframalpha.com/input/?i=atanh(1%2B0i)). Any ideas on how to fix this?

@tensorflow-jenkins test this please

@lakshayg could it be that in the gradient computation, TF ends up computing inf/inf or 0*inf, while you compute the numpy result more directly in the test?

The gradient for atanh(x) is 1 / (1 - x^2). Could that be causing the problem for x = 1?

@lakshayg that should give 1/0 = inf. I'm not sure why it produces NaN instead of inf, but that is unrelated to your change.

@rmlarsen I just compiled the binary and checked what it gave for x=1 and the answer is inf. I guess that everything is working fine and this PR can be merged.

@martinwicke This is ready to be merged. You added the API review tag. What needs to be done?

@lakshayg could you please rebase to resolve conflicts?

@martinwicke I missed you earlier comment about API review last monday. I'll assign you on this PR and you can merge when it's approved.

@rmlarsen rebase done!

@lakshayg Thanks!
@tensorflow-jenkins test this please

How about renaming to arcsinh, arccosh, arctanh to match the numpy names?

@jhseu I guess then we would have to rename asin, acos and atan as well.

Yes, but perhaps wait for API review for the final word.

@jhseu We already have atan, atan2, asin etc. so it doesn't make sense unless we change the existing interface.

@jhseu or @martinwicke : to confirm, good to go?

Good for API review, but watch out, this will require Eigen changes to pull in.

I see failures in windows CPU and GPU build due to additions from this change:
http://ci.tensorflow.org/job/tensorflow-master-win-cmake-py/1101/console
cwise_ops_test.py", line 411, in testComplex64Basic
cwise_ops_test.py", line 302, in testDoubleBasic
cwise_ops_test.py", line 208, in testFloatBasic

Looks like there is some flakiness in arccosh implementation on windows?

@rmlarsen is out next week.
It was green when I merged. Looking at the code, there doesn't seem to be anything obviously special about cosh.
@lakshayg could you take a look?

@gunan @drpngx: @martinwicke earlier suggested (https://github.com/tensorflow/tensorflow/pull/10598#issuecomment-30832473) that I change the tolerances for those but since the tests passed on the next build, I did not change the tolerances. Should I go ahead and change them?

It's not just the tolerance, check this out:
21:10:19 <class 'numpy.ndarray'> <class 'numpy.ndarray'> <class 'tensorflow.python.ops.variables.Variable'> <class 'tensorflow.python.ops.variables.Variable'>
21:10:19 <class 'tensorflow.python.framework.ops.Tensor'> <class 'tensorflow.python.framework.ops.Tensor'>
21:10:19 not close where =  (array([7, 7], dtype=int64), array([6, 7], dtype=int64))
21:10:19 not close lhs =  [ 1.  0.]
21:10:19 not close rhs =  [    0.          1570.79632679]
21:10:19 not close dif =  [  1.00000000e+00   1.57079633e+03]
21:10:19 not close tol =  [  1.00000000e-05   1.57179633e-02]


⚠ ClamAV has degraded performance

In c33a317, ClamAV (https://spamassassin.apache.org/) experienced degraded performance:

HTTP code: 200
Response time: 67 ms

Resolved: ClamAV performance has improved in 43a91c8.


Fix ANGLE on Windows, Linux, and MacOS

This change fixes ANGLE to build on Windows, Linux, and MacOS.
On Windows, the fix was to move the control flow guard flag (/guard:cf) to the compile options. The rest of it built fine.
On Linux and MacOS, the solution was primarily to exclude all D3D renderers and open up the OpenGL renderer to other platforms (it was marked as WINDOWS_DESKTOP only).
The platform specific portions are wgl, glx, and cgl for Windows, Linux, and MacOS respectively.

This will fix #3321 and #3690. I couldn't find an issue filed for Linux.

Hmm... it looks like I accidentally used a cached version of the binary in my Linux test project and didn't notice the ANGLE_USE_X11 compile definition being dropped. Testing Windows again and will push the fix (minor).

Thanks for the PR!


Code highlighting for PHP heredoc syntax fails

Brackets’ code highlighting for PHP heredoc syntax fails when using
  – quotes around the identifier (the snippet 2 in test code)
  – white-space between <<< and the identifier (” 3 ”)
Highlighting for the code snippet 1 works correctly.
A screenshot (Brackets 1.3):

Test code:
<?php

// 1
echo <<<EOT
	...
EOT;

// 2
echo <<<'EOT'
	...
EOT;

// 3
echo <<< EOT
	...
EOT;

This would need to be fixed in CodeMirror (what Brackets uses for its editor window) as I tried it there and CM has the same issues. I would recommend logging an issue on the CM repo against their PHP mode. If they fix it there, it would be picked up "for free" when Brackets upgrades their CM version.

CM fixed an issue codemirror/codemirror#3340 that fixes your case 2 (which is really a nowdoc not a heredoc). The third case, with the space before the identifier, is still present after I patched using 3340.
Note that codemirror/codemirror#3340 seems to be fixed in their version 5.4.0 but Brackets is currently using v5.3.1 so you could either apply 5.4.0 (or just the patch for that issue) or wait until Brackets picks up CM 5.4.0.
This issue should be kept open until then imo.

@mackenza, thank you for the information!

Upstream bug filed: codemirror/CodeMirror#3421

Confirmed this works on master, now that we run the latest CM version again.
Closing. You'll get this fix in Release 1.5


Testing

In this PULL REQUEST the following list below was implemented;

Install RSpec.
Write test before creating the class solver.
Created the factorial method
Created the reverse method
Created the fizzbuzz method

Thank you for reviewing and approving our code


Move browsing behavior into a fragment for tabs reuse

Task/Issue URL: https://app.asana.com/0/361428290920652/574254613727475
Tech Design URL: https://app.asana.com/0/481882893211075/543574221254520
Description:
Refactor our browser functionality into a Fragment to support upcoming tabs implementation. This task was a restructure - there should be no noticeable difference to the end user.
NOTE: This PR has a large footprint as a lot of code was moved around, git hasn't done a great job of recognizing this. In terms of scope, I think fixing any issues that were introduced by this PR makes sense, however, fixing code that is identical but has just moved does not.
Steps to test this PR:
TEST 1
1. Launch the app
2. Navigate to a webpage and the press back ensuring everything still holds together
TEST 2
Perform the following
• Share link/text from external app to our app
• Open the app via the widget
• Open the app via the assistant
For each of the following states:
• App closed
• App running and on home page
• App running and on browser page

Internal references:
Software Engineering Expectations
Technical Design Template

I think fixing any issues that were introduced by this PR makes sense, however, fixing code that is identical but has just moved does not

makes sense 👍

There is a regression around multi-window.
• Perform a search, such that the WebView is showing some content
• Invoke multi-window
Expected
No change to the WebView contents
Actual
WebView hidden; user returned to initial landing page view.
ℹ On develop, there is a related oddity but slightly different. On develop, the same actions result in the WebView being reloaded, which is slightly better but still wrong.
We need to fix this somewhere, but up to you if that's included in your work or picked up sometime before tabs go live.

I'm happy either way, I think it makes sense to pick up the regression here and just get it fixed across the board. If this is blocking you, however, I'm also happy to merge now and I can send you a separate PR for it.

Attempting to add a new bookmark crashes the app after accepting the dialog.
java.lang.ClassCastException: com.duckduckgo.app.browser.BrowserActivity cannot be cast to com.duckduckgo.app.bookmarks.ui.BookmarkAddEditDialogFragment$BookmarkDialogCreationListener
    at com.duckduckgo.app.bookmarks.ui.BookmarkAddEditDialogFragment.userAcceptedDialog(BookmarkAddEditDialogFragment.kt:74)
    at com.duckduckgo.app.bookmarks.ui.BookmarkAddEditDialogFragment.access$userAcceptedDialog(BookmarkAddEditDialogFragment.kt:32)
    at com.duckduckgo.app.bookmarks.ui.BookmarkAddEditDialogFragment$onCreateDialog$alertBuilder$1.onClick(BookmarkAddEditDialogFragment.kt:52)
    at android.support.v7.app.AlertController$ButtonHandler.handleMessage(AlertController.java:162)
    at android.os.Handler.dispatchMessage(Handler.java:105)
    at android.os.Looper.loop(Looper.java:172)
    at android.app.ActivityThread.main(ActivityThread.java:6637)
    at java.lang.reflect.Method.invoke(Native Method)
    at com.android.internal.os.Zygote$MethodAndArgsCaller.run(Zygote.java:240)
    at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:767)

Yikes! Ok some wrong import there or something. Good catch will fix.

If this is blocking you, however, I'm also happy to merge now

This is the big blocker which is basically causing the current (effective) code freeze, right? Once this is merged, your other work will be more normal branching / merging strategy?
If so, then yeah, i'm happy to defer any minor bugs to enable us to work from the same browser code base again

I'm noticing inconsistent behaviour with the keyboard showing / not showing when launched from as the assist app, and launched from the widget. This is mostly random it seems when the app is launched when not already running.
This may well not be caused by this branch though, so just flagging as something else we need to include in the final tabs tidy up (I'm more than happy to help tidy up all these little loose ends btw)

Does private var pendingFileDownload: PendingFileDownload? = null belong in the Activity or the Fragment?
If it remains in the Activity, is there ever the chance that one tab's download attempt will collide with another's?

For the bookmarks crash, it might be enough to:
Show the dialog differently
Show the dialog using the childFragmentManager
Before
addBookmarkDialog.show(it.supportFragmentManager, ADD_BOOKMARK_FRAGMENT_TAG)
After
addBookmarkDialog.show(childFragmentManager, ADD_BOOKMARK_FRAGMENT_TAG)
Invoke callback differently
In the userAcceptedDialog method
Before
val listener = activity as BookmarkDialogCreationListener
After
val listener = parentFragment as BookmarkDialogCreationListener
⚠ Haven't tested thoroughly though; just wanted to stop the crash locally so i could test out the rest of bookmarks

This is great! If we get the bookmarks crash sorted, i'm happy deferring the other observed problems as either being existing or new but will be fixed before tabs goes out.

@CDRussell digging into the bookmarks implementation I don't like the hard casting of listeners as it makes the fragment fragile. I have refactored to remove that, let me know what you think.
I am looking at the other feedback now.

Regarding the pending file download, it currently behaves indetnically to before. It will get refactored further in the mutli tabs branch.

@CDRussell just fixed the multi window state issue. I think that's everything other than your keyboard observations which I think we need to fine-tune at the end when both tour PRs are in.


/tasks API not updated after node was shutdown

Hi,
I've got the below issue:
Got a service that runs with 6 replications over 3 docker swarm nodes
I'm forcefully shutting down one of the nodes
After It, when I'm checking the service distribution via /tasks API (https://docs.docker.com/engine/api/v1.24/#tasks), which the portainer is doing the same to represent the service replications over the nodes, I'm seeing that the deleted node is still "holding" the service with "State": "running".
docker info:
Containers: 6
Running: 6
Paused: 0
Stopped: 0
Images: 5
Server Version: 17.03.0-ce
Storage Driver: aufs
Root Dir: /var/lib/docker/aufs
Backing Filesystem: extfs
Dirs: 40
Dirperm1 Supported: true
Logging Driver: json-file
Cgroup Driver: cgroupfs
Plugins:
Volume: local
Network: bridge host macvlan null overlay
Swarm: active
NodeID: vigx3z6f7fb3kkwj1ephila4k
Is Manager: false
Node Address: <IP_ADDRESS>
Manager Addresses:
<IP_ADDRESS>:2377
<IP_ADDRESS>:2377
<IP_ADDRESS>:2377
Runtimes: runc
Default Runtime: runc
Init Binary: docker-init
containerd version: 977c511eda0925a723debdc94d09459af49d082a
runc version: a01dafd48bc1c7cc12bdb01206f9fea7dd6feb70
init version: 949e6fa
Security Options:
apparmor
seccomp
Profile: default
Kernel Version: 4.4.0-45-generic
Operating System: Ubuntu 16.04.1 LTS
OSType: linux
Architecture: x86_64
CPUs: 2
Total Memory: 7.303 GiB
Name: ip-10-0-0-80
ID: G2YG:ZFK5:ASCJ:VIS7:L5XI:API5:YYJF:XQIA:S5UU:BJ5G:VXSH:NX6B
Docker Root Dir: /var/lib/docker
Debug Mode (client): false
Debug Mode (server): false
Username: ironsrcci
Registry: https://index.docker.io/v1/
WARNING: No swap limit support
Experimental: false
Insecure Registries:
<IP_ADDRESS>/8
Live Restore Enabled: false
So, my questions are - how this can be refreshable? is it a bug? should I configure an additional setting?
Thanks,

In tasks, State is under the control of the node, and DesiredState is under the control of the orchestrator. Since the node does not exist anymore, State will not get updated (except to Orphaned after 24 hours). However, DesiredState should be set to Shutdown.

I'm using auto-scaling on our nodes, meaning that nodes can go down and up dynamically, that what raised this issue, so my second question is what is the life cycle of an orphaned service? is there any tasks or an API call to clean them?

There's a task history retention limit controllable with docker swarm update --task-history-limit <value>. The default is 5. If you set this to 0, then any orphaned tasks will be purged whenever a task related to that service starts.


K8s: CH1-4 - check says failed expecting status code 200 but there is clearly a 200 w/bootdev submit output, screenshot

K8s: CH1-4 - check says failed with no 200 but there is clearly a 200, screenshot
bootdev submit 6b0e3570-98b1-4436-bcf4-62e06b21816d
=====================================
Running requests against: http://<IP_ADDRESS>:63840
1. GET /api/v1/namespaces/kubernetes-dashboard/services/http:kubernetes-dashboard:/proxy/#/workloads?namespace=default
  Request Headers:
  Response Status Code: 200
  Response Body:
<!--
Copyright 2017 The Kubernetes Authors.

Licensed under the Apache License, Version 2.0 (the "License");
you may not use this file except in compliance with the License.
You may obtain a copy of the License at

    http://www.apache.org/licenses/LICENSE-2.0

Unless required by applicable law or agreed to in writing, software
distributed under the License is distributed on an "AS IS" BASIS,
WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
See the License for the specific language governing permissions and
limitations under the License.
--><!DOCTYPE html><html lang="en" dir="ltr"><head>
  <meta charset="utf-8">
  <title>Kubernetes Dashboard</title>

happened again on 1-5:
bootdev submit 56b45923-3c78-42e7-a601-e0834206983d
=====================================
Running requests against: http://localhost:8080
1. GET /
  Request Headers:
  Response Status Code: 200
  Response Body:
<!DOCTYPE html>
<html lang="en">

What is more confusing to me is it says "Success" on the bottom right:

@ElijahLynn thanks for the report! this is just a visual bug with the frontend, we have a fix going out shortly


Optimize consul, when the metadata does not change, do not perform metadata updates

Optimize consul, when the metadata does not change, do not perform metadata updates

@xuziyang you can add my wechat ： xixy199195， i will invite you to join contributor group


Panic on failing task

Seems like the current stable version panics when a task fails.
Simple example:
[tasks.post-build]
dependencies = [
    "format",
    "clippy"
]

...
...
warning: rustfmt may have failed to format. See previous 1 errors.
[cargo-make] ERROR - Error while executing command, exit code: 3
thread 'main' panicked at 'Build Failed.', /home/theduke/.cargo/registry/src/github.com-1ecc6299db9ec823/cargo-make-0.3.75/src/logger.rs:56:16
stack backtrace:
   0:     0x560a6c305393 - std::sys::imp::backtrace::tracing::imp::unwind_backtrace::ha36f9d6000a258d0
                               at /checkout/src/libstd/sys/unix/backtrace/tracing/gcc_s.rs:49
   1:     0x560a6c3019ca - std::sys_common::backtrace::_print::h9e51e0c7e57504cc
                               at /checkout/src/libstd/sys_common/backtrace.rs:71
   2:     0x560a6c308fe3 - std::panicking::default_hook::{{closure}}::h6ad513f5b7fa7e45
                               at /checkout/src/libstd/sys_common/backtrace.rs:60
                               at /checkout/src/libstd/panicking.rs:381
   3:     0x560a6c308d52 - std::panicking::default_hook::h92972e21fe795ab1
                               at /checkout/src/libstd/panicking.rs:397
   4:     0x560a6c309447 - std::panicking::rust_panic_with_hook::h8231d9bc11839b47
                               at /checkout/src/libstd/panicking.rs:577
   5:     0x560a6c198f2a - std::panicking::begin_panic::h527cec84396e91a6
   6:     0x560a6c1b4e43 - cargo_make::logger::init::{{closure}}::h47bedaf674e30241
   7:     0x560a6c2e861c - <fern::log_impl::Dispatch as fern::FernLog>::log_args::h632e7f5f8ffa61f3
   8:     0x560a6c2f3f1a - log::__log::h70c54316b85ca3db
   9:     0x560a6c1b8c94 - cargo_make::command::validate_exit_code::h1aeb6ec528c2e2c5
  10:     0x560a6c1ba24a - cargo_make::command::run_command::hea93f14a5edab934
  11:     0x560a6c1bb498 - cargo_make::runner::run_task::hb7027958db09b457
  12:     0x560a6c1bd56b - cargo_make::runner::run_flow::h6ce16b508ef6d43c
  13:     0x560a6c1bd68f - cargo_make::runner::run::hcb7541bc671237da
  14:     0x560a6c1a98db - cargo_make::main::he7241edaf43a5955
  15:     0x560a6c31024c - __rust_maybe_catch_panic
                               at /checkout/src/libpanic_unwind/lib.rs:99
  16:     0x560a6c309c6b - std::rt::lang_start::hb98200139e7807ed
                               at /checkout/src/libstd/panicking.rs:459
                               at /checkout/src/libstd/panic.rs:361
                               at /checkout/src/libstd/rt.rs:59
  17:     0x7fc8c99404c9 - __libc_start_main
  18:     0x560a6c182719 - _start
  19:                0x0 - <unknown>

correct. if a task fails, the entire build fails (unless you defined force=true for that specific task). the build fails with an error and than panics with the stack. I could prevent the panic for that specific case and just stop if it will look better.

Yeah I think the panic is ugly, panics should only occur on abnormal conditions.
Just a nice error output and then exit the process with a non-zero exit code is much cleaner, imo.

done

I was it.
I love how responsive you are here, how quickly you incorporate feedback and how good the documentation is.
Great job!
Just two notes:
I don't think you need to release a new version with every small change, that adds a lot of noise for users.
I'd let changes accumulate for a little bit and then release a new version when appropriate.
Also, you need to be careful with changes that affect users.
For example, https://github.com/sagiegurari/cargo-make/commit/1cf0bd5dda07a9e83a84a2a4892ae61bba554062 definitely was a breaking change: it could easily cause builds to fail that worked fine before (as I saw with Juniper).
The included default tasks are basically part of the public API, so changes there that can change/affect builds are a breaking change, imo.

I bump the minor version on breaking changes, that's why I am at 0.3
which would result in fixes getting stuck. I should try to plan here but that is the main issue with open source I guess, you work on it when you can.

Yeah the rust convention is below 1.0, 0.3 to 0.4 is a breaking change.
What I'm saying is that https://github.com/sagiegurari/cargo-make/commit/1cf0bd5dda07a9e83a84a2a4892ae61bba554062 would technically have required bumping to 0.4.

Agree, but like I said, didn't think it would break anything so didn't bump and it's probably my mistake there.


[Bug] Invalid scroll position when hiding all comments by default

When the user settings option 'Hide all link's comments by default' is enabled clicking notification sends user to given link activity but scrolls to a random place.
I proposed a solution in #173

Solved in #173


Clean up unnecessary crumbs

Commit Message: Clean up unnecessary crumbs
Additional Description:

mop up nohup.out crumb left over from PR 15374
clean up noop flags from macos build per lizan from PR 15877

Risk Level: N/A
Testing: CI
Docs Changes: N/A
Release Notes: N/A
Platform Specific Features: N/A

/retest

Looking good-to-merge, @lizan - the skipped macos test presubmit ran to completion.


Enable horizontal stretch

Presently the display doesn't stretch horizontally. This was done when I added LH or RH view. Just setting the Anchor property on the group boxes doesn't work for both cases.
Default screen size is 1159x768 for now
Low priority.

Won't fix/implement


Add key option to sort methods

One feature that I am missing from dataframes is to sort with a custom key function, similar to the builtin sorted or list.sort. I see there is some effort to unify sorting in issue #8239, so it might be a nice to add this powerful functionality to pandas while the sorting API is being overhauled.

pls show an example of what/how this would be used as generally you can simply pass in the column name.

dupe of #3942
(you can add an example to that issue)

I have added the specific example to the dupe.  Thanks!


Npm cache (NodeJS) folder on Windows may also be %LocalAppData%\npm-cache

If you have already installed NodeJS on your machine, move the contents of %AppData%\npm-cache to this directory.

On my computer, it's not %AppData%\npm-cache but %LocalAppData%\npm-cache, probably it's good to mention this folder as well.

Document Details
⚠ Do not edit this section. It is required for learn.microsoft.com ➟ GitHub issue linking.

ID: bfda7965-bc34-ab88-fdc9-efef4a5d8a9e
Version Independent ID: bfda7965-bc34-ab88-fdc9-efef4a5d8a9e
Content: Set up a Dev Drive on Windows 11
Content Source: hub/dev-drive/index.md
Product: dev-environment
Technology: windows-devhome
GitHub Login: @mattwojo
Microsoft Alias: mattwoj

Thanks for contributing this issue @RickyLin! I added that directory location for NPM to the doc in https://github.com/MicrosoftDocs/windows-dev-docs/commit/0a053fc99d2eeadc2f5b15c87e989b49f73bf26b.