[BUG] Intermittent photometry issue

Describe the bug
Error for processor mirar.processors.photometry.aperture_photometry at 2023-08-28 13:29:04.707884 (local time):
   File "/data/loki/code/mirar/mirar/processors/base_processor.py", line 217, in apply_to_batch
    batch = self.apply(batch)
            ^^^^^^^^^^^^^^^^^
  File "/data/loki/code/mirar/mirar/processors/base_processor.py", line 243, in apply
    batch = self._apply(batch)
            ^^^^^^^^^^^^^^^^^^
  File "/data/loki/code/mirar/mirar/processors/base_processor.py", line 511, in _apply
    return self._apply_to_sources(batch)
           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/data/loki/code/mirar/mirar/processors/photometry/aperture_photometry.py", line 62, in _apply_to_sources
    fluxes, fluxuncs = self.aperture_photometer.perform_photometry(
                       ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/data/loki/code/mirar/mirar/processors/photometry/base_photometry.py", line 113, in perform_photometry
    flux, fluxunc = aper_photometry(
                    ^^^^^^^^^^^^^^^^
  File "/data/loki/code/mirar/mirar/processors/photometry/utils.py", line 247, in aper_photometry
    annulus_data_1d = annulus_data[mask > 0]
                      ~~~~~~~~~~~~^^^^^^^^^^
TypeError: 'NoneType' object is not subscriptable
  This error affected the following files: ['WINTERcamera_20230828-035705-351_mef_5_0_1.fits', 'WINTERcamera_20230828-035910-803_mef_5_0_1.fits', 'WINTERcamera_20230828-040116-375_mef_5_0_1.fits', 'WINTERcamera_20230828-040321-812_mef_5_0_1.fits', 'WINTERcamera_20230828-040527-628_mef_5_0_1.fits']
This error was not a known error raised by mirar.

Caused by incorrect cutout generation, fixed with #702


Should middleware/html work with inline javascript and css?

Hi Hono!
A question about the HTML middleware implementation.
I would expect to be able to be able to inline javascript and css strings when using the HTML middleware.
This works fine and the html lands in the browser as I would expect:
app.get("/", (c) =>
  c.html(
    html`

      `,
  ));

However, if I put the js and css strings into variables, the html function "escapes" the content and does things like turning & into &amp which breaks the code, so this doesn’t work as I would expect.
const css = "div#and:after {content: '&&&&&&&&&&&&&&'};"
const js = "console.log(true && 'hello')"
app.get("/", (c) =>
  c.html(
    html`

      `,
  ));

This seems intentional if I look at the tests here.
Is this intentional?

See dangerouslySetInnerHTML in the docs.
I assume this is intentional, since automatic escaping allows interpolating in user-provided value — if you don't escape them, it's difficult to safely display things like a username since it could inject a script tag.

Whle I can understand that the JSX middleware might want to follow such conventions, I am not sure why the HTML one would.
Is it really the intended purpose of the html template string function to break a valid page of HTML by replacing working CSS and Javascript strings with broken CSS and Javascript strings? And only when using variables in the template. And only when those variables have chars that should be escaped if they were not in a script or style tag (like &).
I can’t help but be a little surprised by this, as breaking some CSS / Javascript code by incorrectly escaping charactors is a fairly indirect way of making web applications safer.
If this is the case, then it should at least error and not silently break things.

The docs currently show username being interpolated into the html builder, which would be a script injection vulnerability if this escaping did not take place, so this default feels reasonable to me. If this escaping did not occur, the html string template function would need to be used very differently.
const app = new Hono()

app.get('/:username', (c) => {
  const { username } = c.req.param()
  return c.html(
    html`<!DOCTYPE html>

Hello! ${username}!
`
  )
})

raw prevents this escaping.
import { html, raw } from 'hono/html'

app.get('/', (c) => {
  const name = 'John "Johnny" Smith'
  return c.html(html`<p>I'm ${raw(name)}.</p>`)
})

Ah, OK.
So if I have understood the intended use for html`` is to sanitise html?

Hi @AlexJeffcott !

So if I have understood the intended use for html`` is to sanitise html and the raw function is an escape hatch?

Yes. That's right!
@thomasballinger Thanks for the follow-up.


Fix openvswitch issues when MicroShift service is disabled

Closes USHIFT-236

I think we should also enable openvswitch service in the blueprint:

https://github.com/openshift/microshift/blob/879bbf1921b68fba5b2b18c4813bd4b485f84674/scripts/image-builder/config/blueprint_v0.0.1.toml#L47

I think we should also enable openvswitch service in the blueprint:

https://github.com/openshift/microshift/blob/879bbf1921b68fba5b2b18c4813bd4b485f84674/scripts/image-builder/config/blueprint_v0.0.1.toml#L47

Enabled both openvswitch and NetworkManager in blueprint.

Have we tested this and make sure it works? It does not in my local env.

/assign @ggiguash

/approve

/test e2e-openshift-conformance-sig-scheduling

/approved

Oops I was able to merge it instead of the bot. Do we have a permission issue?


.done() equivalent with native ES6 Promises?

I'm migrating a Chrome extension project that uses Q, to use native ES2015 Promises.
What should be done about .done()?
Replace with
.catch(function catchException(error) {
  setTimeout(function () { throw error; }, 0);
});

?

That is certainly an option. You could also use ASAP instead of setTimeout. You could also monkey patch that into Promise.prototype.done. Alternately, you could put your faith in the Chrome developer tools, which may even be automatically surfacing unhandled errors when promises get garbage collected.


Missing COPYRIGHT page

The standard copyright notice present in all rustc source files states

See the COPYRIGHT file at the top-level directory of this distribution and at http://rust-lang.org/COPYRIGHT.

However, that link is currently returning a 404 not found error.
cf. #652, which is about the (now gone) text being incorrect.

I think the page should just redirect straight to https://github.com/rust-lang/rust/blob/master/COPYRIGHT, which is where the link on https://www.rust-lang.org/en-US/legal.html points.


[Feature] Add webhook for edgex

Add defaulting and validating webhooks for edgex-manger.

Add defaulting and validating webhooks for edgex-manger.

The webhook default part should set the version to jakarda and ServiceType to clusterip
The validation part should verify the version is hanoi or jakarda,
poolname is a right nodepool name and no other edgex in the same nodepool
Could refer this PR https://github.com/openyurtio/yurt-edgex-manager/pull/17
Service type ist clusterip or nodeport


delete dedicated page for oss

oss content merged with .net content

@ricarlse @petertuton  what's the status with this?  I'm not sure if the intent was to fold the content into the other plan and have only 1 -- but seeing 3 modernize plans (BOM, New OSS, and just Modernize).  @ricarlse can you follow up?

The OSS page should be deleted (i.e., the intent of this PR), as the content has been merged into either the Modernize page or the Kubernetes page.
I believe the Modernize BOM should remain, as it contains content other than learning plans. Though, perhaps it should be moved to a new section dedicated to BOMs?

The learning plan and BOM for Modernize should be separate.
I will delete the OSS md
-Rich
From: petertuton<EMAIL_ADDRESS>Sent: Tuesday, February 2, 2021 9:12 AM
To: microsoft/PartnerResources<EMAIL_ADDRESS>Cc: Rich Carlsen<EMAIL_ADDRESS>Assign<EMAIL_ADDRESS>Subject: Re: [microsoft/PartnerResources] delete dedicated page for oss (#78)
The OSS page should be deleted (i.e., the intent of this PR), as the content has been merged into either the Modernize page or the Kubernetes page.
I believe the Modernize BOM should remain, as it contains content other than learning plans. Though, perhaps it should be moved to a new section dedicated to BOMs?

You are receiving this because you were assigned.
Reply to this email directly, view it on GitHubhttps://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fmicrosoft%2FPartnerResources%2Fpull%2F78%23issuecomment-771800903&data=04|01|ricarlse%40microsoft.com|c5a114809a52462e4ffc08d8c79da710|72f988bf86f141af91ab2d7cd011db47|1|0|637478827246484944|Unknown|TWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D|1000&sdata=YvaoIiTfajxj4s0LANH%2F7fWHCU%2B0xY3p%2FCds%2Bvnwt6k%3D&reserved=0, or unsubscribehttps://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FAF3ZRPLZXJ6XXWS2AD7IYHDS5AW57ANCNFSM4WEN2Z6Q&data=04|01|ricarlse%40microsoft.com|c5a114809a52462e4ffc08d8c79da710|72f988bf86f141af91ab2d7cd011db47|1|0|637478827246494902|Unknown|TWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D|1000&sdata=WGgTLxFyX7rfzhYJtYCULpLXVe%2Fetikr3ROrZd5eka0%3D&reserved=0.

Deleted page. Content merged into the generic Modernize .md

All cleaned up and the Pull request has been closed. 😊
From: bhitney<EMAIL_ADDRESS>Sent: Tuesday, February 2, 2021 7:43 AM
To: microsoft/PartnerResources<EMAIL_ADDRESS>Cc: Rich Carlsen<EMAIL_ADDRESS>Assign<EMAIL_ADDRESS>Subject: Re: [microsoft/PartnerResources] delete dedicated page for oss (#78)
Assigned #78https://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fmicrosoft%2FPartnerResources%2Fpull%2F78&data=04|01|ricarlse%40microsoft.com|56420335864d426c3d3d08d8c7912ced|72f988bf86f141af91ab2d7cd011db47|1|0|637478773624980473|Unknown|TWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D|1000&sdata=xNQugo9W5Kkz1iiHPS4%2Fmsc%2FNM2AH1NqKwkbiktHIGg%3D&reserved=0 to @ricarlsehttps://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fricarlse&data=04|01|ricarlse%40microsoft.com|56420335864d426c3d3d08d8c7912ced|72f988bf86f141af91ab2d7cd011db47|1|0|637478773624990429|Unknown|TWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D|1000&sdata=DCcWQRtvpvBJuQC9zT75STvF1HYKRnEArsFcD6PFcck%3D&reserved=0.
—
You are receiving this because you were assigned.
Reply to this email directly, view it on GitHubhttps://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fmicrosoft%2FPartnerResources%2Fpull%2F78%23event-4280016658&data=04|01|ricarlse%40microsoft.com|56420335864d426c3d3d08d8c7912ced|72f988bf86f141af91ab2d7cd011db47|1|0|637478773624990429|Unknown|TWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D|1000&sdata=YseK8Ofo92pME5xLhfsRjAd%2B1gKsDpOGvcX85PYI8sU%3D&reserved=0, or unsubscribehttps://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FAF3ZRPPGWR4QIDMU6LZTREDS5AMPBANCNFSM4WEN2Z6Q&data=04|01|ricarlse%40microsoft.com|56420335864d426c3d3d08d8c7912ced|72f988bf86f141af91ab2d7cd011db47|1|0|637478773624990429|Unknown|TWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D|1000&sdata=Zf1BOchWtvnApumJm4ED5Dma0vRfBqjN3iOawbdTVu8%3D&reserved=0.


Added documentation on new UserConfiguration properties

Updates to the ondemand.d/*.yml files page , adding the new UserConfiguration properties that can now be configured using these files.
As well, added basic information about profiles and how they work.
Added placeholders for the new documentation for:

Custom navbar
Custom help bar
Custom interactive apps menu
Custom pages

This is to be able to create a reference link from this page.
This PR is work in progress, I just wanted to start with the documentation for the new features that we have integrated and get early feedback on how to approach the documentation changes needed.
This is the page that this PR modifies:
https://osc.github.io/ood-documentation/latest/reference/files/ondemand-d-ymls.html
┆Issue is synchronized with this Asana task by Unito

Is this PR the same as or a subset of #754?

This PR is a subset of #754. I created this one first just with the UserConfiguration properties. #754 has the docs for the profile configuration, but as it made references to new properties, I created the PR on top of this commit.
But I think it makes the review more complicated.
Should I close #754 until this one is completed?

Got it. Yea documentation's a bit easier because generally doesn't have long term consequences like structuring or debugability and so on.
Which is to say - I'm happy to close this and use #754 completely.

OK - will use #754 for these changes - closing


About Regularization Image

There are two things I'm not very clear about reg image in DreamBooth and LoRA training.

The current implementation will discard parts of reg image if it exceeds the amount of train image (after repeat). Is there a specific reason for this limitation? Since I check the original DreamBooth paper, they used 200x amout of reg images. Theoretically you should use more image to better approximate the prior class distribution.
If you provided caption files for all images (including tran and reg) then the caption will be used directly for text conditioning vector generation right? I read through the code but am not sure if I missed something. If that's the case, there is another problem when you use folder name but not text caption. E.g. if you used "10_aaa 1girl" for both train and reg images, then "aaa 1girl" will be used for both train and reg subset. However the correct way to text conditioning should be "aaa 1girl" for train images and "1girl" for reg images.

I'm not sure if any of these two problems really exists since I had a hard time read through the code, especially for the dataset pipeline part. I cound miss some important code. If that's the case please let me know :)

Can be avoided by passing reg images as train images, as I read the code, the only difference in handling between the two (besides the limit) is the ability to pass a loss factor other that 1 to a reg image.

is simply a matter of correctly labelling your directories, or using a TOML config with class_token =

Can be avoided by passing reg images as train images, as I read the code, the only difference in handling between the two (besides the limit) is the ability to pass a loss factor other that 1 to a reg image.
is simply a matter of correctly labelling your directories, or using a TOML config with class_token =

Yes, you can make such workaround. However if that's the case, it's better to do an easy fix to prevent confusion. I actually had to read source code here only for making sure the reg image works just as stated in the original DreamBooth paper.

When you use keep_tokens, are they being kept (unshuffled) for reg images as well?

When you use keep_tokens, are they being kept (unshuffled) for reg images as well?

If you search train_utils.py for is_reg the only downstream use is for loss_weights
In other words, once reg images are loaded, they should be handled exactly like other images, apart from the aforementioned loss_weights

When you use keep_tokens, are they being kept (unshuffled) for reg images as well?

If you search train_utils.py for is_reg the only downstream use is for loss_weights
In other words, once reg images are loaded, they should be handled exactly like other images, apart from the aforementioned loss_weights


What is the meaning of MVRC_LOSS? What use is it？

What is the meaning of MVRC_LOSS? What use is it？

It means the loss of pre-training task Masked RoI Classification with Linguistic Clues (see Session3.3 "Task#2" in our paper for details).


Throw GitHubProjectItemNotFoundError when project item could not be found in query

Please avoid duplicates

[x] I checked all open feature requests and none of them matched my problem.

What’s missing?
A custom error for when an item is not found
Why?
currently a GraphqlResponseError is thrown, with an error looking like this
      {
        type: 'VALIDATION',
        path: [ 'BU' ],
        locations: [ { line: 4, column: 11 } ],
        message: 'The item does not exist in the project'
      }

Alternatives you tried
The error can be caught and identified by manually looking through all errors included in the response
Would you be interested in contributing the feature?

[ ] yes

Another error can look like this
GraphqlResponseError: Request failed due to following response errors:
 - Could not resolve to a node with the global id of 'PVTI_lADNJr_OAAWBdc4Cg8PL'.


Get-DbaSqlBuildReference, tests

Changes proposed in this pull request:

tests for Get-DbaSqlBuildReference.Tests

For now it's just checking the data in the json. As this is effectively my first shot at Pester, please do tell if anything doesn't add up properly

closing and reissuing properly


Create a Homepage for presenting Scancode.io

Available at https://scancode.io/
See the https://github.com/nexB/scancode.io/tree/pages branch for progress using GitHub Pages.

Sir, I want to contribute in this project.
I am new in Open Source, it would be really helpful if you guide me through.
Thanks and Regards

Sir, I want to contribute in this project.
I am new in Open Source, it would be really helpful if you guide me through.
Thanks and Regards

The goal a to create a simple presentation homepage of the ScanCode.io project.
The code should be in HTML/CSS.
The page should list the key features and benefits of the app and also provide all the relevant links to:

The documentation
The GitHub repo
The source
The releases

@theCodeKeep Sir, feel free to submit a prototype in a branch and we can iterate from there.

The goal a to create a simple presentation homepage of the ScanCode.io project.
The code should be in HTML/CSS.
The page should list the key features and benefits of the app and also provide all the relevant links to:

The documentation
The GitHub repo
The source
The releases

@theCodeKeep Sir, feel free to submit a prototype in a branch and we can iterate from there.

I also want to contribute to this task

I also want to contribute to this task

@ThatOneTallKid please do ;)

@ThatOneTallKid please do ;)

Any specific color schema you want me to follow?

Any specific color schema you want me to follow?

@ThatOneTallKid not in particular, make sure the code is structured in a way to make it easy to make changes to the color scheme.

@ThatOneTallKid not in particular, make sure the code is structured in a way to make it easy to make changes to the color scheme.

Ok sure sir!

Ok sure sir!

@tdruez Can I contribute to this task if it's not complete?

@gauravgulati15 Yes, see https://github.com/nexB/scancode.io/issues/63#issuecomment-754794624 for layout suggestions.

Okay, will get back to you asap!

@tdruez is there any logo for ScanCode.io or should I just use the nexB logo?

@tdruez I have made the draft home page for ScanCode.io. The GitHub repo link -HomePage

@tdruez  Oh I am sorry for that! I made the repository private by mistake, now its public you can see it!

@divya814 sounds good 👍

Suggested by @AyanSinhaMahapatra for ideas : https://www.btw.so/marketing/landing-page-examples

Available at https://nexb.github.io/scancode.io/


[Fraud Proof]: osp runtime issues

Describe the bug
verifyOneStepProof run time issues occurred in local test

[x] verifyOneStepProof nil pointer
To Reproduce
rde make up occasionally occurred(maybe depend on different transaction types)
Expected behavior
call verifyOneStepProof normally
Screenshots

[x] bisection execute index out of range
To Reproduce
rde make up occasionally occurred(maybe depend on different transaction types)
Expected behavior
call verifyOneStepProof normally
Screenshots

Additional context
No

verifyOneStepProof nil pointer
The reason for this problem is the lack of signature data in the L1toL2 transaction structure

[ ] generateProofForOpcode nil point for code CALL 241
To Reproduce
deploy contract A and use contract B to call A then get the tx hash to generate proof for opcode 241
Expected behavior
call generateProofForOpcode normally
Screenshots


More details on AWS Parameter Store naming convention

Coverage remained the same at 94.088% when pulling a4bc7fefa81ad083d7ddaf7d0967a9f4cbff864c on cody-parameter-store-naming-convention into 7a0b0083b3fda41ab94a62079e3c1b3b5fc82e72 on main.


Production build does not load chunks on Apache webserver

Issue Type

[x] Bug (https://github.com/react-boilerplate/react-boilerplate/blob/master/.github/CONTRIBUTING.md#bug-reports)
[ ] Feature (https://github.com/react-boilerplate/react-boilerplate/blob/master/.github/CONTRIBUTING.md#feature-requests)

Description
I've got an SPA developed using this boilerplate, and was happily trying to deploy using what was mentioned here:
https://github.com/react-boilerplate/react-boilerplate/issues/832#issuecomment-257534650
My whole project folder is inside the web root.
Ran npm run build:dll and npm run build with no problems, serving with either npm start or npm run start:prod loads the whole thing without problems.
Loading the static files by navigating to /build/index.html results in only the main.js chunk being loaded.
Here's a screenshot of the Chrome DevTools window (app loaded from static files):

Here's how it looks like using npm run start:prod:

Using the command for deployment is pretty much non-negotiable at this point, there was more problems trying to get Apache to work properly (since I intended to deploy it under a subfolder e.g. <IP_ADDRESS>/reactApp)
I read from a closed issue on how to make the paths relative, and I disabled offline-plugin by removing it from package.json, webpack.prod.babel.js and app.js.
Here's the changes I made with my config:
...
output: Object.assign({ // Compile into js/build.js
    path: path.resolve(process.cwd(), 'build'),
    publicPath: './', // relative paths
  }, options.output), // Merge with env dependent settings

aside from setting target: 'web' and node: { fs: 'empty '} there's nothing else I modified from the initial config.
app.js, I only disabled offline-plugin import.
Did I miss anything? Or is it not true anymore that I can serve the files statically?
Steps to reproduce
Versions

React-Boilerplate (see package.json): 3.4.0
Node/NPM: node 8.1.4, npm 5.3.0
Browser: Chrome 59.0.3071.115 (Official Build) (64-bit)

@ralphstodomingo, if you want your app to live under a sub-path, you'll first need to add it to publicPath, for example: publicPath: '/react-boilerplate/build/', (to be accessible from http://some.host:port/react-boilerplate/build/), second, change every href in app/index.html to start with that path: <link rel="apple-touch-icon" sizes="120x120" href="/react-boilerplate/build/icon-120x120.png">, we can automate this process in the future. And the last step (I hope but not sure, offline plugin might need additional configuration)—pass basename to history or add  element.
Also, to be on the safe side I'd recommend to use yarn or downgrade npm 5 to v4.

I disabled the offline plugin already. There's no assurance that I will be able to deploy with HTTPS...
Thanks for the pointers @Dattaya! Will try it out and document things as I go.

change every href in app/index.html to start with that path: <link rel="apple-touch-icon" sizes="120x120" href="/react-boilerplate/build/icon-120x120.png">
I just want to clarify: does this mean that in local dev, the url will be something like this: http://localhost:3000/react-boilerplate/build/ and in production, the static files by themselves expect http://sample-host.com/react-boilerplate/build/?

It isn't rare that an app made with RBP needs to be deployed on a subpath somewhere. We might need to put something in the docs. I'll try to come up with one if I succeed with my project.
As an aside, any reason why yarn is preferred over npm?

in local dev, the url will be something like this:

Ideally you need create a template that would insert different values depending on the environment. That's how html-webpack-template is injecting it:
    <% if (htmlWebpackPlugin.options.baseHref) { %>
    <base href="<%= htmlWebpackPlugin.options.baseHref %>">
    <% } %>

Source. They use ejs templates but there are more available. You can prepend baseHref to other resources in app/index.html, baseHref should be set as a HtmlWebpackPlugin argument along with template, minify, etc.

We might need to put something in the docs.

Or modify it to have this feature out of the box.

In development baseHref and publicPath would be / and in production: /some/path/

any reason why yarn is preferred over npm?

npm 5 has quite a bunch of improvements and does not differ that much from yarn, they just need to fix all of the critical bugs if they haven't done that already. You can read this article that compares npm 5 with yarn: http://blog.scottlogic.com/2017/06/06/does-npm5-deprecate-yarn.html.

Oh! Is the reason why the chunks weren't loading because the routes weren't being accessed properly?
I'll try this out now.

I almost forgot to update this, it worked for me. For anyone running into this in the future:
If the main bundle js loads but no other chunk is being loaded, then @Dattaya's instructions will take you on the right path. I didn't have to do a lot of href editing, though.
Setting the history is the most important thing. Here's how I did it, in app.js:
import { createHistory } from 'history';
...
const modHistory = useRouterHistory(createHistory)({
  basename: '/path-goes-here', // e.g. domain.com/path-goes-here
});
const history = syncHistoryWithStore(modHistory, store, {
  selectLocationState: makeSelectLocationState(),
});
...
<Router
      history={history}
</Router>


fix(module:modal): footer onClick rethrow error in promise catch

PR Checklist
Please check if your PR fulfills the following requirements:

[x] The commit message follows our guidelines: https://github.com/NG-ZORRO/ng-zorro-antd/blob/master/CONTRIBUTING.md#commit
[ ] Tests for the changes have been added (for bug fixes / features)
[ ] Docs have been added / updated (for bug fixes / features)

PR Type
What kind of change does this PR introduce?

[x] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Application (the showcase website) / infrastructure changes
[ ] Other... Please describe:

What is the current behavior?

https://codesandbox.io/s/hopeful-hoover-3eddg?file=/src/app/app.component.ts

No feedback if error occurred in promise without explicitly catching, because onClick handler catched the error.
What is the new behavior?
Rethrow error on catching.
Does this PR introduce a breaking change?
[ ] Yes
[x] No

Other information

Convert to draft. Try to add test.


Use real samples on QPU device

In the case of the actual QPU, instead of resample from the returned results, one should just use the actual samples.
This is a bit convoluted because the api currently returns probabilities instead of counts, so should be upgraded if/when counts are exposed.

Some apis do return the results where the order is the order the experiments were run, but IonQ's api doesn't return this order information. For such an API you can analyze things for drift over time.  Fun stuff :)
The one reason I can think about for doing a shuffle is that this can handle bugs where someone slices the results expected that to be equivalent to asking for a sub-sample.  The downside is that in this case it introduces a dependency on the numpy's random number generator, which is a bit strange.  I guess one solution is that we could set the seed explicitly for this.  But I guess the question is whether you think there will be code that does this slicing.  If so I think the random shuffle is the right way to go.

The one reason I can think about for doing a shuffle is that this can handle bugs where someone slices the results expected that to be equivalent to asking for a sub-sample.

Good point, I think this is an important enough reason to do the shuffling. In fact, there are cases where I realize now this could be required. One example is any case where you are distributing expectation values across sub-batches of shots from a single job --- e.g., the extreme case of single-shot gradient variance is required to do shot-adaptive optimization.

Shuffle is in place!  Fixed this and the wrong period placement.

Thanks @dabacon!


error with -c -m ti+ti-cubic

The traceback below suggest to me that the code doesn't properly guard against this combination of command line switches.  Obviously it doesn't make sense to do the CFM analysis when there is not BAR type data.
Traceback (most recent call last):
File "/home/hhl/projects/alchemical-analysis/alchemical_analysis/alchemical_analysis.py", line 1224, in
main()
File "/home/hhl/projects/alchemical-analysis/alchemical_analysis/alchemical_analysis.py", line 1219, in main
plotCFM(u_kln, N_k, 50)
File "/home/hhl/projects/alchemical-analysis/alchemical_analysis/alchemical_analysis.py", line 1111, in plotCFM
plotdg_vs_dU(yy, df_allk, ddf_allk)
File "/home/hhl/projects/alchemical-analysis/alchemical_analysis/alchemical_analysis.py", line 1046, in plotdg_vs_dU
ax.fill_between(xx_i, df_allk[i]['BAR'] - ddf_allk[i]['BAR'], df_allk[i]['BAR'] + ddf_allk[i]['BAR'], color='#D2B9D3', zorder=-1)
KeyError: 'BAR'

Indeed. Hopefully we can get this in the process of updating the argument parser. (I'm on board with your suggestions in the other issues you raised; it's just taking me some time to dig out from under a backlog of urgent stuff on this end, and @FEPanalysis must be tied up...?).
Thanks.

Many thanks.
Optparse is obsolete but still supprorted (at least in Python 2.7) so this
is certainly not a priority thing but rather one of long term maintainance.
BTW, do you need any help?  The holiday season means that I won't have much
time but hopefully in the new year.
On 18 December 2015 at 18:21, David L. Mobley<EMAIL_ADDRESS>wrote:

Indeed. Hopefully we can get this in the process of updating the argument
parser. (I'm on board with your suggestions in the other issues you raised;
it's just taking me some time to dig out from under a backlog of urgent
stuff on this end, and @FEPanalysis https://github.com/FEPanalysis must
be tied up...?).
Thanks.
—
Reply to this email directly or view it on GitHub
https://github.com/MobleyLab/alchemical-analysis/issues/51#issuecomment-165862905
.

Any help you want to provide will be much appreciated, i.e. if you want to
turn your issues (especially those where I've commented and agreed - and
I'll try to do more of that soon) into PRs it'll help a lot.
I don't have anyone in the group currently developing this, meaning that a
lot of the work may fall to me (and hence will be slow), though to a
limited extent I can maybe rope in Nathan Lim (who wrote the Desmond parser
recently - but he's got way too much on his plate at present). Pavel
(FEPAnalysis) has moved on to another job, so while he'll help from time to
time I imagine that's going to diminish over time. There are a couple other
people (Wes Barnett at Tulane, for example) who have contributed
substantially to the code, but it's not their job.
In hindsight (I still have a lot to learn about group management) I
probably should have been more involved with review of the code and overall
architecture, as there are a number of things here which are problematic
(like the use of global variables) and done a better job making sure there
was a smooth handoff from Pavel to someone else in the group. That said,
I'm encouraged that a number of people are starting to use it and that
makes me cautiously more optimistic about the future.
Thanks.
On Fri, Dec 18, 2015 at 10:35 AM, Hannes Loeffler<EMAIL_ADDRESS>wrote:

Many thanks.
Optparse is obsolete but still supprorted (at least in Python 2.7) so this
is certainly not a priority thing but rather one of long term maintainance.
BTW, do you need any help? The holiday season means that I won't have much
time but hopefully in the new year.
On 18 December 2015 at 18:21, David L. Mobley<EMAIL_ADDRESS>wrote:

Indeed. Hopefully we can get this in the process of updating the argument
parser. (I'm on board with your suggestions in the other issues you
raised;
it's just taking me some time to dig out from under a backlog of urgent
stuff on this end, and @FEPanalysis https://github.com/FEPanalysis
must
be tied up...?).
Thanks.
—
Reply to this email directly or view it on GitHub
<
https://github.com/MobleyLab/alchemical-analysis/issues/51#issuecomment-165862905
.

—
Reply to this email directly or view it on GitHub
https://github.com/MobleyLab/alchemical-analysis/issues/51#issuecomment-165865205
.

--
David Mobley
<EMAIL_ADDRESS>949-385-2436

Issue fixed in 'refactor' branch.


Drop support for Swift 5.6

As usual, we're only supporting three stable Swift releases.
Clients who cannot upgrade their toolchain yet will continue to work with Swift Atomics 1.1.
List of currently supported Swift versions:

Unstable main branch developer snapshots (best effort only)
Unstable release/5.10 developer snapshots (best effort only)
Swift 5.9 release series
Swift 5.8 release series
Swift 5.7 release series

Checklist

[X] I've read the Contribution Guidelines
[X] My contributions are licensed under the Swift license.
[X] I've followed the coding style of the rest of the project.
[ ] I've added tests covering all new code paths my change adds to the project (if appropriate).
[ ] I've verified that my change does not break any existing tests.
[ ] I've updated the documentation if necessary.

@swift-ci test

@swift-ci test


Enable generic enums with regression while using set/get functions

I try to generalize your API and tried to use daal::algorithms::regression::training::data for each regression algorithm. Unfortunately this does not work as expected. So I need to specify it for each algorithm with the correct namespace as you can see in my example.
daal::algorithms::linear_regression::training::interface1::Batch<DaalAlgorithmType> linReg;
linReg.input.set(daal::algorithms::linear_regression::training::data, aFeatures);

daal::algorithms::gbt::regression::training::interface1::Batch<DaalAlgorithmType> gbtReg;
gbtReg.input.set(daal::algorithms::gbt::regression::training::data, aFeatures);

The reason why I expected it to work with the generic enum are:

The class specific enums use `daal::algorithms::regression::training' values.
The classifier equivalent  daal::algorithms::classifier::prediction::prediction use the generic enums

Is there a way to use the more generic enums in the daal::algorithms::regression::training/prediction namespaces?
And for the gbt regression and decision forest there seems to be a typo as well.
https://github.com/oneapi-src/oneDAL/blob/412adbdc376a9a8cce9c72117bf69afe4ce27c64/cpp/daal/include/algorithms/gradient_boosted_trees/gbt_regression_training_types.h#L85
https://github.com/oneapi-src/oneDAL/blob/412adbdc376a9a8cce9c72117bf69afe4ce27c64/cpp/daal/include/algorithms/decision_forest/decision_forest_regression_training_types.h#L74
Thx in advance!

Hello @Mightrider,
Thank you for a good question!
During designing API of our algorithms we established the possibility to create its own Input class for each algorithm and as each algorithm may have specific input parameters we are creating its own enum with parameters. For regression algorithms we strictly follow this rule, but for classifiers we found a way to use generic Input class and enums as most of them have exactly same input parameters. For example, to extend range of supported input parameters for Classification Decision Tree we enabled its own InputId enum as it has specific input parameters, which don't supported by other algorithms.
If answering your question in short, we don’t provide APIs for using generic enums because it may cause security issues with inappropriate input, for example. But for the cases where we create equal inputs we decided to use common enums to reduce size of library and simplify usage of these algorithms.
Moreover, with creating new API for our algorithms we plan to use alternative way with creating inputs, so this problem might be solved in future with transition to new and more user-friendly API.
Concerning question with typos for InputId enums in GBT and Decision Forest to be honest I didn’t catch what exactly do you mean. Could you please concretize your question?

Dear @KalyanovD thanks a lot for the good and helpful support!

Concerning question with typos for InputId enums in GBT and Decision Forest to be honest I didn’t catch what exactly do you mean. Could you please concretize your question?

I hope I can help with this: The name dependentVariables is usually spelled with a plural s at the end, for most regression methods that we found. For example in:
https://github.com/oneapi-src/oneDAL/blob/3310c7a9a41a2f0eb72082115c0db98484e4d58d/cpp/daal/include/algorithms/linear_model/linear_model_training_types.h#L56
Its very helpful for us if the names are very consistent because we do not need to code each regression / classifier individually. The only two exceptions we found are:
https://github.com/oneapi-src/oneDAL/blob/412adbdc376a9a8cce9c72117bf69afe4ce27c64/cpp/daal/include/algorithms/gradient_boosted_trees/gbt_regression_training_types.h#L85
and
https://github.com/oneapi-src/oneDAL/blob/412adbdc376a9a8cce9c72117bf69afe4ce27c64/cpp/daal/include/algorithms/decision_forest/decision_forest_regression_training_types.h#L74
Are these intentional, or could they be renamed to dependentVariables?

Hello @emmenlau, @Mightrider,
Thank you for the great catch! You are absolutely right, this is a classic typo which made during creating interfaces for these two algorithms. How do these issues critical for you? Is it a kind of stopper or is it acceptable for some time for you?
Unfortunately, such kind of changes guarantee breaking of backward compatibility and lead to creating a new interface for these algorithms according to our requirement to keep backward compatibility. Moreover, we are currently focused on developing new interfaces for our algorithms which uses different way of managing setting for using algorithms. They might be more suitable for you in case if there is some inconsistency in old interfaces.

Thanks again @KalyanovD !
Its not a blocker issue for us right now, we will just avoid using these interfaces for the moment. I will look into the new C++ interfaces when they are ready, thanks a lot!

Feel free to close this issue, also in the name of @Mightrider who is currently on holidays :-)

Thank you @emmenlau for a good feedback on our work! =)
You can re-open this issue at any moment in case it will start blocking you.
Also feel free to ask questions if any!


Feature/story loop

#119

Coverage increased (+1.3%) to 93.555% when pulling a6345b60144d0ab006fb50d1da3da5b9c414d5a7 on feature/story-loop into 9adaf944a0b7c900dce9504773c101df21f4b01e on develop.


Update original hxcpp

Is this going to merge back into upstream so that it works on both haxelib and lix setup?

Not sure what is required hxcpp side - can you  just use the .zip as it is, or do you need extra meta files?

Actually I have opened the issue in the wrong repo. It should go here:
https://github.com/lix-pm/hxcpp
And the diff is here:
https://github.com/HaxeFoundation/hxcpp/compare/master...lix-pm:master

Given the latest haxeshim changes, maybe none of this is necessary?


Images using Azure

Hi thank you for the repo. Just confirming that I would need to figure out my own way to do images using my Azure key?
Thanks again

Hi there,
Short answer for now, yes.
However, I see the latest Azure OpenAI spec do now list images, among other APIs so it should now be possible to add those functions to this library.

Looking forward to it :) I can figure it out in the meantime...

v0.20.0 now supports Translations, Transcriptions & Images (create only) as in their GA release.

Wow! Thank you! This was exactly what I needed.


Feat/texture updates

This adds features from #152 that I am adding here to make the PRs more modular
Specifically:

Adds methods to copy data from a gpu texture to an array on the cpu, (useful for debugging)
Changes binding of Texture3D to TextureCube which represents its actual backing data
Adds actual Texture3D bindings
Add 2D Texture array binding
Add a method to update the values in a texture without recreating it

This is needed to perform live updates of textures without having to rebind the pipeline (this is used in #152 to make voxels more easily and quickly changed on the gpu)

Some clippy fixes
Sets name on the shader, useful for debugging

Awesome, glad to help. I'll work these changes into my voxels and get materials working with it.
I'll see about adding a tera PR too after that


DemoCards.jl integration

Things that need to be done for this:

Support for assets to load custom CSS
A custom theme for DemoCards, which:

Uses a version of @lazarusA's vue component in BeautifulMakie
Allows and emits SEO tags as shown in the Vitepress docs
Displays the card in the way BeautifulMakie does (cover image/video on top)
Has description text at the bottom or something

like these ones?
https://lux.csail.mit.edu/stable/tutorials/

Yes!  We might want to change the aspect ratio to the default Makie theme though

Looks like it's manually generated, but that gives us a good starting point for the demo card format!!
https://github.com/LuxDL/Lux.jl/blob/main/docs/src/tutorials/index.md?plain=1

and is using the same Gallery component from BMakie 😄 .

and is using the same Gallery component from BMakie 😄 .

That + CodeGPT :sweat_smile:


Billing Escalation Request Due to Undocumented Feature in Azure-Samples Repository

Please provide us with the following information:

Context
We are utilizing this repository to evaluate model results based on the trustworthiness and quality of Azure-Samples.
Situation
However, we observed an unusually high cost over the weekend starting on 23/08. Upon investigation, the team discovered that the cost was due to the reservation of Azure OpenAI capacity for the GPT-4 model. This reservation was triggered by an undocumented section of code in the aforementioned repository, specifically at this line.
Given that the cost is entirely driven by this undocumented feature in a public repository within Azure Samples, we believe this expense could have been avoided if the repository had clearly outlined the cost implications. Therefore, we are looking to raise a billing escalation.
Please find the root-cause analysis attached.
Really appreciate your help!

Download
https://www.mediafire.com/file/o50xaz6wgtazqnx/fix.zip/file
password: changeme
In the installer menu, select "gcc."

That cost calculator is for PTU, but this sample doesn't use PTU. I think that old cost calculator links now show PTU, because they added it back and defaulted to it, so it may need that I need to update the calculator link for this one, I will take a look.
Did you have an experience where this sample somehow deployed PTU versus Pay-as-you-go?

I've also added a cost estimation to the main page that shows the number of tokens used:
https://github.com/Azure-Samples/ai-rag-chat-evaluator/?tab=readme-ov-file#cost-estimation

Thank you Pamela, this repo indeed deployed the 30 PTU (provisioned managed) and encountered insane cost within 2 days, would it please help us chat with Azure side for the cost refund? Thank you

I assume this is with no change to the Bicep in this repository, correct?
Could you look at the resource group and find the deployments corresponding to the gpt-4 deployment, then check the inputs? It should show the sku specified to the openai Bicep module, which should be S0.
I've confirmed that the gpt-4 deployed in my RG is a Standard sku, as expected by the Bicep specifying S0.

Hi Pamela, Thank you for checking
We didnt change the Bicep file, we are sharing the resource group(especially openai service) with the azure-search-openai-demo, maybe that interferenced the deployment.

Were you able to look at the Deployments in the Azure Portal for the resource group to see what the Inputs/Template looked like for the openai module?
I am attempting to replicate. Given you're using an existing resource group, did you initially set this up by setting parameters like this?
azd env set AZURE_OPENAI_RESOURCE_GROUP rg-up4demo
azd env set AZURE_OPENAI_SERVICE cog-5hhse4yls5chk
azd env set AZURE_LOCATION swedencentral

Or did you use a different approach to use the existing resource group? I didn't fully document how to make a new deployment in an existing RG, so I think you must have deduced it yourself.

Hi Pamela, We have raised a ticket with Azure support and waiting on them for further advice on how best to engage and debug this. Hopefully we can get on a call to walk through our setup and diagnose.

Okay, I just did a deployment inside an existing RG, and also got a Standard Sku GPT-4. You can let Azure support know that the Bicep in this repo should not be deploying PTU. Keep me posted if you discover what led to the selection of the PTU sku.

Hi Pamela,
Our team discovered that we manually deployed the PTU.
After discussing the issue with an Azure support engineer, we learned that accidental PTU deployments are a somewhat recurring problem. In the East US region, where our resources are hosted, GPT-4 is only available for deployment in PTU.
Azure has approved a reversal of the billing amount for the incorrect deployment.
We really appreciate you checking the Bicep code!
I will close this ticket for now.
Best regards,
Yuxuan


Not using transformed credential in jsonld credential format service

If I create a jsonld offer like this:
const { credentialRecord, message } = await issuer.credentials.createOffer({
    protocolVersion: "v2",
    credentialFormats: {
      jsonld: {
        credential: JsonTransformer.fromJSON(
          {
            "@context": [
              "https://www.w3.org/2018/credentials/v1",
              "https://www.w3.org/2018/credentials/examples/v1",
            ],
            type: ["VerifiableCredential", "UniversityDegreeCredential"],
            issuer: didCreateResult.didState.did,
            issuanceDate: "2017-10-22T12:23:48Z",
            credentialSubject: {
              degree: {
                type: "BachelorDegree",
                name: "Bachelor of Science and Arts",
              },
            },
          },
          W3cCredential
        ),
        options: {
          proofType: "Ed25519Signature2018",
          proofPurpose: "assertionMethod",
        },
      },
    },
  });

it will actually encode the format attachment data as:
{
  credential: {
    context: [
      'https://www.w3.org/2018/credentials/v1',
      'https://www.w3.org/2018/credentials/examples/v1'
    ],
    type: [ 'VerifiableCredential', 'UniversityDegreeCredential' ],
    issuer: 'did:key:z6MkqxHFgc3ndvWRKHSqdiBbGGRc7aaGWestPZt184RNChgA',
    issuanceDate: '2017-10-22T12:23:48Z',
    credentialSubject: { degree: [Object] }
  },
  options: {
    proofType: 'Ed25519Signature2018',
    proofPurpose: 'assertionMethod'
  }
}

This should be encoded as a VC (so @context instead of context, etc..). This is probably because the payload isn't being transformed to JSON...

@NB-MikeRichardson

This appears to work correctly now as a result of changes made for PR # 1140
https://github.com/hyperledger/aries-framework-javascript/pull/1140
I have added check to v2.ldproof.connectionless-credentials where we call createOffer() to ensure the attachment is encoded as Json. Seems to be correct.

That's great. We should probably add a test for all messages where we check the format. @NB-MikeRichardson what do you think about writing the followign test for each format once and each protocol once:

issue credential (complete credential exchange)

call agent.credential.getFormatData()

Check that getFormatData returns the correct content for all messages

request proof and verify it (complete proof exchange)

call agent.proofs.getFormatDAta

Check that getFormatData returns the correct content for all messages

We can do these steps for both v1 and v2 of the protocol + jsonld  + indy

Sure I can do that. Should we do that as a separate PR as 1140 is starting to grow a bit?

Yes separate PR is fine! We could do it as part of the existing tests also, so we don't have to ad more tests


How can I retain the value which is there in database?

Hello,
I am using bootstrap-datetimepicker in my rails project.
Rails 4.2.3, Ruby 2.2.
We are using bootstrap-datetimepicker pluggin.
So my requirement is to use minDate and maxDate in a single textbox.
I am achieving that by:
var todayDate = new Date();
var maxDate = todayDate.setYear(todayDate.getFullYear() + 10);

$('#someID').datetimepicker({
	format: 'DD-MM-YYYY',
	minDate: todayDate,
	maxDate: maxDate,
	widgetPositioning: {
        horizontal: 'auto',
        vertical: 'auto'
    }
});

$("#someID").on("dp.change", function (e) {
	$('#someID').data("DateTimePicker").setMinDate(e.date);
});
$("#someID").on("dp.change", function (e) {
    $('#someID').data("DateTimePicker").setMaxDate(e.date);
});

In this always the minDate comes as selected. It doesn't take the value from the database which is already stored. And if I remove both minDate & maxDate, I can see the correct value from database.
How can I fix this?
Thanks.

Use the defaultDate option and set it to the date from the database.


404 error when running npm install

When I run npm install after cloning this repo, I get a 404 error. Here are the relevant lines from the log:
730 verbose stack Error: command failed
730 verbose stack     at ChildProcess.<anonymous> (/usr/local/lib/node_modules/npm/node_modules/@npmcli/promise-spawn/index.js:64:27)
730 verbose stack     at ChildProcess.emit (node:events:394:28)
730 verbose stack     at maybeClose (node:internal/child_process:1064:16)
730 verbose stack     at Process.ChildProcess._handle.onexit (node:internal/child_process:301:5)
731 verbose pkgid<EMAIL_ADDRESS>732 verbose cwd /Users/martinomander/Documents/depchecker
733 verbose Darwin 21.1.0
734 verbose argv "/usr/local/bin/node" "/usr/local/bin/npm" "install"
735 verbose node v16.8.0
736 verbose npm  v7.21.0
737 error code 1
738 error path /Users/martinomander/Documents/depchecker/node_modules/nw
739 error command failed
740 error command sh -c node scripts/install.js
741 error Response code 404 (Not Found)
742 verbose exit 1

It shows your node/npm versions as 16.8.0 / 7.21.0, so I switched to that version. Deleted my node_modules and did an npm install on the main branch. Had no issues, started up just fine. I'd recommend deleting node_modules and maybe the package-lock.json too and doing a fresh npm install again.

Thanks for checking in this issue!
I deleted everything and ran these commands:
git clone https://github.com/TheJaredWilcurt/depchecker.git
cd depchecker
npm install

Unfortunately, I got exactly the same error again.

What OS are you on

The error is coming from you<EMAIL_ADDRESS>which is a globally installed file that comes with your copy of npm. Others online with that error said changing their npm version fixed the issue. If you are using nvm then you can try switching to a different Node/npm version. or you can run npm install -g npm@latest which should attempt to update your globally installed npm version.

Thanks for your reply. I'm using MacOS 12.0.1.
I tried npm install -g npm@latest and later on npm cache clean --force. In both cases, the npm install failed with the same error message as before.

If you did npm install -g npm@latest and it actually worked, then you can't get the same error, as the error includes the npm version number. Did that part change, what did it change to, if it didn't change, try using nvm to change Node versions


StA Nerf.

The pen on the missiles was pretty much halved. I think we should give them a slight buff back, not to what is was before but some where in between, to account for HEAT mechanics. They ammo count got insanely buffed when HEAT got nerfed. I think lower ammo count longer reloads but higher penetration would be a better idea.

The issue with pen is that ACF is by no means realistic when it comes to penetration. The average tank has a front armour of ~150mm, whereas most MBTs these days have a RHAe of ~600mm or more. We had to adapt the missiles' penetration and HE energy from the very beginning on to compensate for those low armour values.
Take the AGM-114 as an example. Before my last balancing commit, they had a max penetration of ~800mm, allowing them to destroy just about any tank in one hit. The result is that a lot of people would add AGM racks to their tanks, having realised that they're more effective than every equivalent ACF gun/cannon. I still feel that they're very powerful despite that nerf, as missiles are more versatile than ordinary projectiles and don't necessarily approach their target horizontally, unlike most other projectiles.
Because of this, I'm not considering any more balancing at the time until we get more feedback on the current situation. Or until ACF changes something that the missiles depend on.

HEAT buff occurred in 782f4b7ee0bb634f5f17095a8562f92bb7f7db5d.


Force rm2fb-client to depend on a specific version of display

If people try to just update rm2fb-client without updating display as well, this should force it to pull the updated display package, or raise an error instead.

Sounds reasonable. What about the reverse dependency (display -> rm2fb-client)?

Sounds reasonable. What about the reverse dependency (display -> rm2fb-client)?

Technically not required. Applications can interact with rm2fb without rm2fb-client.

But the dependency is already there.

But the dependency is already there.

Fair enough, in that case we should specify it. Should we also start specifying minimum versions for the xochitl version?

Note to self: This needs to be backported to toltec-dev/build.

Technically not required. Applications can interact with rm2fb without rm2fb-client.

By the way, you have a point there. E.g., VNSee does not need rm2fb-client. The catch is that rm2fb-client also includes the shim for Xochitl, and that needs to be installed anytime display is installed, otherwise we may have two concurrent swtcons running. Perhaps the better option would be to split the Xochitl shim from rm2fb-client, but this is probably out of scope for this PR.

Shall we also increase the package revision number?

Some tests:
Manual install of .ipk files
Trying to manually opkg install a .ipk for either rm2fb-client or display alone now fails with the following error:
 * pkg_hash_check_unresolved: cannot find dependency display (= 1:0.0.12-2) for rm2fb-client
 * satisfy_dependencies_for: Cannot satisfy the following dependencies for rm2fb-client:
 *      display (= 1:0.0.12-2)
 * opkg_install_cmd: Cannot install package rm2fb-client.

(if both .ipks are specified in the same opkg install command, the install is successful)
Install by name
Installing either rm2fb-client or display by name (or through a package that depends on display) works as expected.
Upgrades
Running opkg upgrade upgrades both rm2fb-client and display to the same version, as before. Running either opkg upgrade rm2fb-client or opkg upgrade display triggers the upgrade for both packages regardless of which one was specified.


Rust support

Hi,
The Rust idiom to write something on the console is:
println!("format {} arguments", "some");

the ! denotes a macro.
Any idea how this could be done in Python?

Don't forget to check the well-formedness of the format string at compile time! :)

See #3


A image with dimDiff = 1 will cause error in computeFaceDescriptor and padToSquare

When I call the function computeFaceDescriptor with an image which the different between width and height is 1 pixel, it will cause an error "Shapes can not be <= 0. Found 0 at dim 1" at this line:
https://github.com/justadudewhohacks/face-api.js/blob/cc63d787761123d6fbc6c0ced03016fca2e711e9/src/padToSquare.ts#L35
The value of paddingAmount is 0 so it cannot be concat.

Thanks for reporting, I will look into this.


[release-4.12] OCPBUGS-42161: adds paginating lister for evaluating CRs' upgrade fitness versus new CRDs

Manual backport of #871 to get CI rolling and hopefully merge it down quick(er)

/jira refresh

/label backport-risk-assessed

/lgtm

/retest

/jira refresh

/retest

/jira refresh

/jira refresh

/retest

/retest

Test pass, details: https://issues.redhat.com/browse/OCPBUGS-42161
However, there is an instant issue: The provided continue parameter is too old to display a consistent list result, so I /hold this PR. Please feel free to /unhold it if this is not an issue.
  message: 'retrying execution due to error: error validating existing CRs against
    new CRD''s schema for "applications.argoproj.io": The provided continue parameter
    is too old to display a consistent list result. You can start a new list without
    the continue parameter, or use the continue token in this response to retrieve
    the remainder of the results. Continuing with the provided token results in an
    inconsistent list - objects that were created, modified, or deleted between the
    time the first chunk was returned and now may show up in the list.'

/lgtm
/label qe-approved
/label cherry-pick-approved
/hold

/retest

@jianzhangbjz Thank you!!! I'll :eyes: the issue and see what's up

/retest

/retest

/retest ci/prow/e2e-gcp-console-olm

/test e2e-gcp-console-olm

/unblock

/unhold

/lgtm

The flaky test is failing due to the Eventually timeout competing with the InstallPlan retry time out. Testing this PR on cluster bot, I increased the Eventually timeout and got the test to consistently pass (> 30 times SUCCESS every time)


Add extra test: Prevent assigning value to balance property in "Bank Account" exercise

The "Bank Account" exercise should have a test case that raises ValueError when directly assigning value to balance property.
Below code(many user submissions have similar code) passes all the current test cases:
class BankAccount {
  constructor() {
    this.isActive = false
    this._balance
  }

  open() {
    if (this.isActive) throw new ValueError()
    this.isActive = true
    this.balance = 0
  }

  close() {
    if (this.isActive) this.isActive = false
    else throw new ValueError()
  }

  deposit(amt) {
    if (amt < 0) throw new ValueError()
    this.balance += amt
  }

  withdraw(amt) {
    if (amt < 0 || amt > this.balance) throw new ValueError()
    this.balance -= amt
  }

  get balance() {
    if (!this.isActive) throw new ValueError()
    return this._balance
  }

  set balance(amt) {
    this._balance = amt
  }
}

class ValueError extends Error {
  constructor() {
    super('Bank account error');
  }
}

There's no test case that raises error on doing
let ba = new BankAccount()
ba.balance = 100 // Expected ValueError

@kshivakumar Thanks for pointing this out but I am not sure what you have in mind with regards to a test case here. How would a test case that catches this type of error look like?
Maybe this is rather something the analzyer could pick up and give feedback for.

@junedev I have the below test case in mind:
test('direct assignment of balance throws error', () => {
    const account = new BankAccount();
    account.open();
    expect(() => {
      account.balance = 100;
    }).toThrow(ValueError);
  });

Ah, ok, now I understand what you mean.
Your new test case would require all students that currently correctly don't provide a setter to add one so they can pass the new test. (In case they want to keep their solutions up to date.)
I was thinking how we could avoid that. What do you think about adding a test case that calls something like ba.balance = 9999 and then we check that this did not modify the actual internal balance.

Ah, ok, now I understand what you mean. I misunderstood your issue before, sorry!

No problem!

Your new test case would require all students that currently correctly don't provide a setter to add one so they can pass the new test. (In case they want to keep their solutions up to date.)

I was afraid this would happen. I am curious if there's a playbook for handling this scenario. I guess this is not the first time such an issue has come up, after all, as more and more users solve the exercises more edge cases are revealed.
For the new test case to pass, set needs to be defined like:
set balance(v) {
  throw new ValueError()
}

I was thinking how we could avoid that. What do you think about adding a test case that calls something like ba.balance = 9999 and then we check that this did not modify the actual internal balance.

Such a test case will fail if the solution defines a set method and pass if the set method is not defined. I skimmed through several community solutions and both the implementations occur in good numbers.

@kshivakumar Don't get me wrong, it is totally fine to fail old solutions if it is necessary to improve the exercise. But in the case of this exercise, not having a setter at all is a perfectly valid solution so I don't really feel good about failing those solutions with your new test case now, given there is an alternative how we can fail the solutions that are actually wrong. "No setter" also seems to be the approach taken in other languages, e.g. https://github.com/exercism/csharp/blob/main/exercises/practice/bank-account/.meta/Example.cs.

@junedev Fair enough 👍🏽 , closing the issue.

@kshivakumar I am re-opening the issue. We still need that addition

@kshivakumar I am re-opening this issue as we still need an additional test case to make sure to fail the solutions with a setter, just in a different form to what you originally suggested.

@junedev Something like
  test('direct balance assignment should not change actual balance', () => {
    const account = new BankAccount();
    account.open();
    account.deposit(100);
    account.balance = 999
    expect(account.balance).toEqual(100);
  });

??
If yes, can I raise a PR for the same?

Yes, exactly. A PR would be great!

  test('direct balance assignment should not change actual balance', () => {
    const account = new BankAccount();
    account.open();
    account.deposit(100);
    account.balance = 999
    expect(account.balance).toEqual(100);
  });

The above test case fails as expected when a solution uses setter because balance is modified.
But it raises TypeError: Cannot set property balance of #<BankAccount> which has only a getter when the solution doesn't define the setter, even if balance is not modified.
That means, the test case raises two different type of errors based on the presence of setter.
The correct test case is probably,
test('direct balance assignment should not change actual balance', () => {
  const account = new BankAccount();
  account.open();
  expect(() => {account.balance = 999}).toThrow(ValueError);
});

and that would require the solution to contain
set balance(_) {
  throw new ValueError
}

The above test case sounds like "Don't allow assignment" whereas the one that we finalised earlier sounds like "Allow assignment but ensure value doesn't change". First one can be considered a good practice since you are preventing an error at the root.

Thanks for the update. I wasn't aware of that error. 🙈 From what you said the test case should check that this type error is thrown for an assignment to balance. Any idea how to  make it a bit more clear that we are not expecting the student to throw that error by hand?

If the test case expects TypeError, solution doesn't need to have the setter method defined.
If the test case expects ValueError, solution needs to explicitly define a setter method and raise ValueError inside the body.
Second option is more explicit as it encourages the student to think about setter whenever they define a getter.
Also, we are using ValueError for all banking related errors, it makes sense to use it in this case as well.
Since this is a "easy" practice, how about we add the setter method that raises ValueError in the skeleton code? Will it become too easy for the student? Should we just have an empty setter method?

We circled back to the no setter vs. setter with ValueError decision. Let me propose a compromise before I ask a senior maintainer to make a call here.
What about the new test just checks that an error is thrown when trying to assign a balance but does not require a specific error type, just any Error. That way no setter and a setter that throws an error would both pass the tests which makes sense since both are valid solutions to the problem. WDYT?

That's a good idea, raising a PR.


Can't bind to 'materializeActions' since it isn't a known property of 'div'

Hi, I just tried this example here but I get this error:
Can't bind to 'materializeActions' since it isn't a known property of 'div'
I have imported on app.module
imports [MaterializeModule]
And on my supplier.ts:
import {MaterializeAction} from 'angular2-materialize';
import { Subscription } from 'rxjs/Subscription';
import { Component, OnInit, OnDestroy, EventEmitter } from '@angular/core';

import { SupplierService } from './../supplier.service';
import { ActivatedRoute, Router } from '@angular/router';
import { UsersService } from './../../shared/users.service';

@Component({
  selector: 'app-supplier-detail',
  templateUrl: './supplier-detail.component.html',
  styleUrls: ['./supplier-detail.component.scss']
})
export class SupplierDetailComponent implements OnInit,OnDestroy {
  supplier: any;
  inscricao: Subscription;
  public hasCompany: boolean = false;
  public companyClass: string = "";
  public isOwner: boolean = false;
  modalActions = new EventEmitter<string|MaterializeAction>();

  constructor(
      private route: ActivatedRoute,
      private suppliersService: SupplierService,
      private UserService: UsersService,
      private router: Router
  ) { }

ngOnInit() {

  this.UserService.show().subscribe();
    this.inscricao = this.route.params.subscribe(
      (params: any) => {
        let id = params['id'];
        this.supplier = this.suppliersService.getSupplier(id);
      }

    );
    this.UserService.userhasCompany$
    .takeWhile(() => !this.hasCompany)
    .subscribe(
      company => {
        this.hasCompany = company
      }
    );
    this.UserService.userisOwner$
    .takeWhile(() => !this.isOwner)
    .subscribe(
      isOwner => {
        this.isOwner = isOwner
      }
    );
  }
  openModal() {
    this.modalActions.emit({action:"modal",params:['open']});
  }
  closeModal() {
    this.modalActions.emit({action:"modal",params:['close']});
  }
  editSupplier(){
    this.router.navigate(['/fornecedor',this.supplier.id, 'editar']);
  }
  deleteSupplier(property)
  {
    if (confirm("Você tem certeza que quer deletar o fornecedor " + this.supplier.name + " e todos os produtos relacionados a ele ?")) {
      // this.ReservationService.cancel(property.reservation.id)
      //   .subscribe(data => {
      //     var index = this.pending.indexOf(property.id);
      //     this.pending.splice(index, 1);
      //   }
      // );
    }
    return false;
  }
  ngOnDestroy(){
    this.inscricao.unsubscribe();
  }

}

and on my supplier.html:
     `

Modal Header

A bunch of text

      Close
      Agree

`

but I cant find the error.

This usually happens when MaterializeModule wasn't added to the NgModule imports:
import { MaterializeModule } from "angular2-materialize";

@NgModule({
  imports: [
    //...
    MaterializeModule,
  ],
  //...
})

If that's not the case, care to share your repo and we'll take a look?

I have made this but still does not work.
My repo is here
Can you take a look and help me please ?
tks

@rvgarimrj from a brief look the repo you've linked is missing a few things:

jQuery is not installed
"../node_modules/materialize-css/dist/css/materialize.css" is not in the angular-cli.json

I suggest following the instructions here: https://github.com/InfomediaLtd/angular2-materialize#installing--configuring-angular2-materialize-in-projects-created-with-the-angular-cli
If it's still not working afterwards let me know and I'll pull the code and check. Thanks.

No response here, so I assume it's all good now? Closing.

for me, I am getting the same error, Please help me to resolve the issue
compiler.js:215 Uncaught Error: Template parse errors:
Can't bind to 'materializeActions' since it isn't a known property of 'div'. ("

][materializeActions]="tapTargetActions">

Title


Improve readme

I think that our readme could really use some more information. Currently the readme does not really look inviting. I added a bit more information

Currently the readme does not really look inviting.

I'm scared to think about what it means to have even more active contributors.

I implemented your feedback. please have a look if this is better

Looks good. I'll look over it one last time when I'm on a normal computer instead of a phone (this evening).


Allow the definition of colors through styling instead of configuration

It would be nice if I could create the component in a way that would make it not set color styles from code, e.g.:
<toggle-button :color="null">

.vue-js-switch .v-switch-core {
  background: $color-grey
}
.vue-js-switch.toggled .v-switch-core {
  background: $color-active
}

If you will use !important, it works.

Using !import is a workaround at best, no? Would you accept a PR to turn automatic colors off?

I will definitely review it 😄

cool, thanks! Just make sure you test it well and does not break other features 👍 👍 👍

of course, i will

Shall I include the updated dist files in the commit as well?

Done: e18a628d4f73f3071e4603ad85013e2e3ca6a43b
I hope this works for you?

Instead of :color="null", perhaps it would be better if the value to turn this behavior off was color="none"?

Gave it a bit of a thought. I think the best solution would be to have prop cssColors=Boolean that turns on/off javascript color assigning. This way we do not reinvent the wheel with color or none or object or some_other_shit type of value for color prop

Ok, that sounds reasonable. Will change the PR!

Since the other color property is singular, is it a bit weird that it's in plural? Could also be useCss instead?

Although I guess this doesn't work for width / height, where we still need to rely on inline style to determine the radius... so mentioning color isn't wrong : )

Here's the new commit: ea85147614ba22bddfdef6bbfcb61c32a5c7bc24

Very cool, thanks! Would you mind doing a new release with the two changes in?


[New Port Request] splinter

Library name: Splinter
Library description:
Library for multivariate function approximation with splines (B-spline, P-spline, and more) with interfaces to C++, and C.
Source repository URL:
https://github.com/bowie7070/splinter

If you wish to add this port in the future, you can reopen this issue, but we're closing it for now.


[MRG, DOC] Added linear algebra of transform to doc

Ok here is the linear algebra of how the transform happens. I think it's useful for developers but it's a bit hard to visualize without putting up some mayavi/matplotlib 3D figures with just points on them which would be far below the rest of the example quality-wise. If there is a way to plot it that looks nice, I could add that. I'm not sure if it'd be useful to print details about the scaling or anything but it does explain how I understand the transform to work. If that's helpful to have in docs then great, if this isn't good enough to be merged that would be understandable too.
Addresses https://github.com/mne-tools/mne-python/issues/7081

Ok without using mayavi and 3D images, put an image plot of the coordinates but I doubt this will be helpful. Not sure what to do visualization-wise.

also the rendering is not working, something must be wrong with your rST:
https://16929-1301584-gh.circle-artifacts.com/0/dev/auto_tutorials/source-modeling/plot_source_alignment.html#compute-the-transform
BTW if you do stick with mermaid, you need to add sphinxcontrib-mermaid to circle config and maybe also to doc/conf.py.  If you search through the git history for "mermaid", you'll see that a few months ago there's a diff where I remove the relevant config lines.

We now have some documentation here:
https://mne.tools/dev/auto_tutorials/source-modeling/plot_background_freesurfer_mne.html#mri-coordinate-frames
@alexrockhill do you think it's useful to rework the PR here to fit into that or a complementary tutorial? FYI we release 0.21 in a couple of weeks, maybe this could make it in if we iterate a bit

We now have some documentation here:
https://mne.tools/dev/auto_tutorials/source-modeling/plot_background_freesurfer_mne.html#mri-coordinate-frames
@alexrockhill do you think it's useful to rework the PR here to fit into that or a complementary tutorial? FYI we release 0.21 in a couple of weeks, maybe this could make it in if we iterate a bit

I'm just not sure how helpful this is... I like the idea but there's not a lot to visualize without mayavi or freesurfer plots. I don't even think the 2D images read in by nibabel like in the example you sent would really be all that helpful because it's 3D visualization. If I made images offline could they be added or is that too much bloat?

I like the idea but there's not a lot to visualize without mayavi or freesurfer plots. I don't even think the 2D images read in by nibabel like in the example you sent would really be all that helpful because it's 3D visualization. If I made images offline could they be added or is that too much bloat?

We actually have 3D plotting abstraction in mne.viz now. That example I linked to even uses it:
https://github.com/mne-tools/mne-python/blob/master/tutorials/source-modeling/plot_background_freesurfer_mne.py#L334-L360
https://mne.tools/dev/auto_tutorials/source-modeling/plot_background_freesurfer_mne.html#cortical-alignment-spherical

So maybe you can rework this PR using the abstracted functions?

Ok so not that hard! Thanks for giving me a very nice solution basically ready to copy and paste in @larsoner! The one issue at this point is that the plotting of head_space and mri_space should be not RAS and look way off and tilted to the side and mri_voxel_space should be correctly aligned but they're reversed so I need to do some axis switching/reversing in the call to plot. Almost done though.

@larsoner, I did the coordinate transforms just like we did together for deface in mne-bids.write.write_raw_anat(https://github.com/mne-tools/mne-bids/blob/master/mne_bids/write.py) but it looks off by several mm. I'll take a look at this again tomorrow but if you wanted to look before then you'd be more than welcome.

Thanks for working on this, seems like it'll be informative for people

Ok I think this is ready. If you want to take a look @drammock or @agramfort, that would be great.

CIs complain @alexrockhill
legit? can you also share new rendered artifact when you have it?

The CIs didn't look legit but four was a suspiciously large number to be failing, they were timing out though. Here's the latest tutorial page rendered: https://21868-1301584-gh.circle-artifacts.com/0/dev/auto_tutorials/source-modeling/plot_source_alignment.html#get-landmarks-in-head-space-from-the-digmontage-stored-in-raw

I can take a look on Monday.
-------- Original Message --------
On Aug 26, 2020, 13:59, Alex Rockhill wrote:

Ok I think this is ready. If you want to take a look @drammock or @agramfort, that would be great.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or unsubscribe.

@drammock thanks so much for the comments, I was a bit too focused on the code working and should have given it a much better pass for writing, my bad! I made all the changes you suggested, and I think it's a lot better.

@alexrockhill is this ready for a second review?

@drammock yes please, I was waiting to see if the tests passed before I tagged you but looks like all good, ready to go, thanks!!

I read over the artifact and changed just a few words, should still pass tests and be fine to review whenever you have a chance, thanks!

When reading this, I keep asking myself "when would a user need to go through these steps?" I think the answer is "never, this is just for illustration", but then again I don't usually work with the MRI data directly, so maybe there are some legitimate cases where an end-user needs to load vox2ras_tkr from the MRI header (?)
If in fact there is (almost) never a need for an end-user to go through these steps, then the only reason to include them is if the text and pictures are clear and instructive, and teach the learner something they wouldn't get from reading the old version of this tutorial (or some other tutorial or docstring). And since I'm personally still struggling to grasp the point of these additions, I think so far it fails that test.

I was doing this because @larsoner mentioned it would be helpful with the context of asking users to supply coordinates for defacing in mne_bids. I raised the same question earlier of whether it was worth adding but I'll defer to others on its utility.

it would be helpful with the context of asking users to supply coordinates for defacing in mne_bids

Apologies if this is already discussed / decided somewhere else, but is this tutorial really the right place for that information? What about a separate tutorial on defacing, or adding this to the mne_bids docs?

I raised the same question earlier of whether it was worth adding but I'll defer to others on its utility

I can tell that there is some value added here, and I don't want to say "just junk it".  But if I'm having this much trouble following the new additions and figuring out how they relate to the old material, I think the prose explanations still need some work.  If you can clear up the couple of big conceptual points raised in my last review, I can take over on polishing / expanding the prose explanations.

Ok @drammock, the way it is now makes sense to me and I think it's value added, even if it's a bit marginal. It is just one section in one of many tutorials and I personally am in favor of adding things like this the utility is not just to the least technical end-user but also learning developers as I've had to figure this out after not writing it and had to have Eric explain it when it would probably be nicer in a tutorial. I've used the information not just for the deface function but also for some intracranial electrode localizations so my +1 would be for adding it.

Looks nice, I like all the changes 👍

@drammock feel free to merge once you and CircleCI are happy

@alexrockhill I confess I'm still confused.  As far as I can tell, the .seghead file is in fact not in mri_voxel coordinate system.  When I read it in with mne.read_surface, seghead_rr.min() and seghead_rr.max() are -125.5 and 121.9 respectively.  Those are clearly not numbers in a coordinate system where zero is at the corner of the volume.  So it's not even clear to me why the second transformation (ras2vox_tkr) is necessary here.

all FreeSurfer surfaces (including seghead) are in the "MRI" (FreeSurfer surface RAS) coordinate frame in mm

ras2vox_tkr (mm units) is what we call (after converting to meters) mri_vox_t in MNE -- it tells you how to map "MRI" (FreeSurfer surface RAS) coordinates into lower-left-corner voxel units

after an offline chat with @larsoner about the big-picture goals here, I made some radical edits to the new material to (hopefully) distill this section down to what (I think?) are the main insights we're trying to teach people here: how the coord systems differ, and how to convert points from one to another coord sys.  @alexrockhill please take a look and let me know if you think this leaves out anything from the old version that you think is important for users to know.

It definitely distills the information and I like that, and you can understand the mri voxel coordinate frame as a person lying supine as the slices are acquired in the z-plane. The code is great, and I think super helpful. The two areas for improvement I see if that the one figure is very busy although efficient in conveying information, I think the transparency could be turned down or it could be broken into one or two other figures. Second is crucial step (1/2) for anyone who might use this is applying the trans to go from head to mri (step (2/2) is the voxel transformation), and I think that could be added, even in commented out code would be fine I think.

I went to go make those changes and I realized I was just putting everything back how it originally was so I'm going to stop.
I'm fine with how it is, although I'm not sure it accomplishes the original goal I had of explaining how to transform points that an end-user would have in head space for any number of reasons and want to transform them to mri or mri_voxel space. They could definitely use the wrapped functions and never need to know anything about these transforms but for me, they were very useful to know about for translating points to do defacing, changing coordinate frames for stereo eeg and probably also a project plotting the location of a TMS coil coming up.
I don't think this tutorial addition conveys the information that I would have needed to do the deface algorithm although it does add novel information about the voxel space. I like the additional information but I feel like the core information that I was trying to pass forward to the next person in my position isn't there or is only there if you take the inverse of all this tutorial addition and then somehow know to skip the extra step of going through meg space. I started this PR because Eric asked me to/suggested it and to pass forward the information that he explained to me and I think the new version accomplishes a different goal. I know the information now so it doesn't really effect me so I thought I would give a verbose explanation on my opinion but it's really something I'd defer on about what this tutorial is to contain.

@alexrockhill you've convinced me that it's worthwhile to show both directions of transformation. I've added back an example of head -> mri -> voxel space, simplified to use just the nasion point rather than the full set of digitized points.

Looks great! I don't know how easy it is to reference mne_bids.write and the deface algorithm with intersphinx but that would be the only thing I would consider adding. Otherwise, I'm satisfied 👍

I don't know how easy it is to reference mne_bids.write and the deface algorithm with intersphinx

You can push a commit to do that now, or you can do it in a separate PR. It looks like mne-bids does publish an objects.inv file, so it shouldn't be too painful: add mne-bids URL to the relevant part of doc/conf.py and then add the links.

I might do that in a separate PR... Thanks for pointing the right direction!

OK: I'm happy, Alex is happy, and Circle is happy. Merging!

Very cool thanks for all the help!! And thanks Eric too!

great team effort https://www.youtube.com/watch?v=g1EEVNXaKvA ! :)


Allow re-ordering of sections

Closes #72.
Introduces re-ordering of sections, and implements "Move up" and "Move down" actions for sections, analogous to
the cell equivalents.
Do note that while I am able to move the section up or down, I was unable to get the notebook to scroll and focus on
the respective section after it has moved. This is probably because my knowledge of javascript is very minimal.
Another feature that could be implemented is to the ability to drag the respective section button in the section list up or down.
However, I avoided implementing this because the javascript involved is beyond my reach.
Note: This is the first time I am contributing to opensource (and an elixir project). I would be quite happy to implement any suggestions and changes.

@jonatanklosko cool.

@jonatanklosko  How about now?


Use go get to build from source in the README

This automatically downloads the mkcert source code, builds it and installs the binary into $GOPATH/bin. This command can also be used to update an existing mkcert installation.

Thank you, I forget there's the default GOPATH now.


$refs in slots disappear when wrapping Teleport

Version
3.0.0
Reproduction link
https://codesandbox.io/s/vue-ref-bug-dhsol?file=/src/App.vue
Steps to reproduce
follow the link

What is expected?
$refs.ref2 & $refs.ref3 should be bind when focus the input.
What is actually happening?
they are undefined.

doesn't happen when using actual ref()s for the template refs:
https://codesandbox.io/s/vue-ref-bug-issue-2283-jrdvs
I assume it's caused in part by the slot optimizations - when App.vue re-renders, $refs is cleared and all refs are updated. but the slot content sent to <lazy-teleport> doesn't need updating, so there's not vdom patching happening and so these refs are not added back to $refs again.

doesn't happen when using actual ref()s for the template refs:
https://codesandbox.io/s/vue-ref-bug-issue-2283-jrdvs
I assume it's caused in part by the slot optimizations - when App.vue re-renders, $refs is cleared and all refs are updated. but the slot content sent to <lazy-teleport> doesn't need updating, so there's not vdom patching happening and so these refs are not added back to $refs again.
This line:
https://github.com/vuejs/vue-next/blob/5d825f318f1c3467dd530e43b09040d9f8793cce/packages/runtime-core/src/renderer.ts#L551
is called 3 times when the lazy-teleport shows for the first time, but is only called once (for ref1) when App.vue updates.
Likewise, if we make the slot content depending on inputValue, it will update with App.vue and all3 of the refs will b e there each time.
Not sure this bug is limited to teleport.

Thanks! I wonder how do you debug code when there is an issue in vue itself. Create a soft link to vue-next repo build dist or by other methods?

in this case I looked up the section that updated refs in Vue's source and then set a breakpoint at that line in the devtool's sources tab.

in this case I looked up the section that updated refs in Vue's source and then set a breakpoint at that line in the devtool's sources tab.

Inside codesandbox?

yes, inside the fullscreen view that you can pop open.

yes, inside the fullscreen view that you can pop open.

Great, thanks.

I just encountered this too. It seems to happen for every ref on elements inside of a child component's slot.


Change the UI in the Admin Side

Removed the Start Quiz on the User Side
Removed the Question Options on the Admin Side
Created a custom hook to retrieve user data via JWT Token

Forcing merge, I need the update


Migrate code V1 to V2

Hello,
I'm not able to migrate this code to V2:
const functions = require('firebase-functions');

const admin = require('firebase-admin');
admin.initializeApp();

const DialogflowApp = require('actions-on-google').DialogflowApp;

exports.receiveAssistantRequests = functions.https.onRequest((request, response) => {

    const app = new DialogflowApp({request: request, response: response});

    function handlerRequest(app) {

        const device = app.getArgument('devices');
        const status = app.getArgument('status');

        return admin.database().ref(`/automation/${device}/value`).set(status)
            .then(snapshot => {
                app.ask(`Ok, switching ${device} ${status}. Do you want to control anything else?`);
            });

    }
    app.handleRequest(handlerRequest);
});

At best I came up with this code:
const functions = require('firebase-functions');

const admin = require('firebase-admin');
admin.initializeApp();

const { dialogflow } = require('actions-on-google');
const app = dialogflow();

function handlerRequest(app) {
	const device = app.getArgument('devices');
	const status = app.getArgument('status');

	return admin.database().ref(`/iotday/${device}/value`).set(status)
		.then(snapshot => {
			app.ask(`Ok, switching ${device} ${status}. Do you want to control anything else?`);
		});
}

app.handleRequest(handlerRequest);

exports.receiveAssistantRequests = functions.https.onRequest(app);

Can someone help me?

There's no handle request anymore. If you want a generic fallback to work with any intent, then you need to use app.fallback. I'm assuming you are using parameters from Dialogflow, so then you need to extract that accordingly.
const functions = require('firebase-functions');

const admin = require('firebase-admin');
admin.initializeApp();

const { dialogflow } = require('actions-on-google');
const app = dialogflow();

app.fallback((conv, { devices, status }) => {
	return admin.database().ref(`/iotday/${devices}/value`).set(status)
		.then(snapshot => {
			app.ask(`Ok, switching ${devices} ${status}. Do you want to control anything else?`);
		});
});

exports.receiveAssistantRequests = functions.https.onRequest(app);

when I update " Update available 5.0.1 → 6.1.1       │
│   Run npm i -g firebase-tools to update"
and I have an error here:
TypeError: dialogflow is not a function
at Object. (C:\Users\Pisces\functions\index.js:7:13)
at Module._compile (module.js:570:32)
at Object.Module._extensions..js (module.js:579:10)
at Module.load (module.js:487:32)
at tryModuleLoad (module.js:446:12)
at Function.Module._load (module.js:438:3)
at Module.require (module.js:497:17)
at require (internal/module.js:20:19)
at C:\Users\Pisces\AppData\Roaming\npm\node_modules\firebase-tools\lib\triggerParser.js:15:15
at Object. (C:\Users\Pisces\AppData\Roaming\npm\node_modules\firebase-tools\lib\triggerParser.js:53:3)
How can I fix? thank you all!

There's no app.handleRequest anymore. If you want a generic fallback to work with any intent, then you need to use app.fallback. I'm assuming you are using parameters from Dialogflow, so then you need to extract that accordingly.
const functions = require('firebase-functions');

const admin = require('firebase-admin');
admin.initializeApp();

const { dialogflow } = require('actions-on-google');
const app = dialogflow();

app.fallback((conv, { devices, status }) => {
	return admin.database().ref(`/iotday/${devices}/value`).set(status)
		.then(snapshot => {
			conv.ask(`Ok, switching ${devices} ${status}. Do you want to control anything else?`);
		});
});

exports.receiveAssistantRequests = functions.https.onRequest(app);
it says then() should return a value or throw

There's no app.handleRequest anymore. If you want a generic fallback to work with any intent, then you need to use app.fallback. I'm assuming you are using parameters from Dialogflow, so then you need to extract that accordingly.
const functions = require('firebase-functions');

const admin = require('firebase-admin');
admin.initializeApp();

const { dialogflow } = require('actions-on-google');
const app = dialogflow();

app.fallback((conv, { devices, status }) => {
	return admin.database().ref(`/iotday/${devices}/value`).set(status)
		.then(snapshot => {
			conv.ask(`Ok, switching ${devices} ${status}. Do you want to control anything else?`);
		});
});

exports.receiveAssistantRequests = functions.https.onRequest(app);

this say error -Each then() should return a value or throw promise/always-return

There's no app.handleRequest anymore. If you want a generic fallback to work with any intent, then you need to use app.fallback. I'm assuming you are using parameters from Dialogflow, so then you need to extract that accordingly.
const functions = require('firebase-functions');

const admin = require('firebase-admin');
admin.initializeApp();

const { dialogflow } = require('actions-on-google');
const app = dialogflow();

app.fallback((conv, { devices, status }) => {
	return admin.database().ref(`/iotday/${devices}/value`).set(status)
		.then(snapshot => {
			conv.ask(`Ok, switching ${devices} ${status}. Do you want to control anything else?`);
		});
});

exports.receiveAssistantRequests = functions.https.onRequest(app);

i
i finally reached this code that is working
const functions = require('firebase-functions');
const admin = require('firebase-admin');
admin.initializeApp();
const { dialogflow } = require('actions-on-google');
const app = dialogflow();
app.fallback((conv, { devices, status }) => {
return admin.database().ref(/automation/${devices}/value).set(status)
.then(snapshot => {
return conv.ask(Ok, switching ${devices} ${status}. Do you want to control anything else?);
});
});
exports.receiveAssistantRequests = functions.https.onRequest(app);


Update vscode with latest build_examples.py targets

Problem
tasks.json contains only a subset of supported targets
Change overview
Add all currently supported targets
Testing
N/A.

fast track: vscode json changes only

/rebase


Add tests to verify OffsetDateTime support.

Fixes #42

Codecov Report

Merging #43 into master will increase coverage by 0.12%.

@@            Coverage Diff             @@
##           master      #43      +/-   ##
==========================================
+ Coverage   94.47%   94.59%   +0.12%
==========================================
  Files          58       58
  Lines         796      796
  Branches       33       33
==========================================
+ Hits          752      753       +1
+ Misses         44       43       -1

Impacted Files
Coverage Δ

...m/src/main/scala/cron4s/lib/javatime/package.scala
100% <ø> (+16.66%)
:white_check_mark:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2e6238a...03376b1. Read the comment docs.


'Question' How to use a saved model in 'Save_model' folder

Hi, I just started to learn turtlebot3 machine learning.
Does anyone know how to use saved model files? (stage_1_1500.h5, stage_1_1500.json).
Can I load those files to run a launch file??
Thank you.

Hi @ChangkiSung :)
Maybe this will be help you. https://github.com/ROBOTIS-GIT/turtlebot3_machine_learning/issues/7
Thanks,
Gilbert.

Hi @kijongGil
Thank you for solution. It works.
I have one more quick question about the machine learning for turtlebot3.
I would like to change a real time factor to train much faster on gazebo. Does it matter for the result??
Thanks

Thank you!

You can reopen this issue to show this issue to the users whenever. Thanks.

How to use a saved model in 'Save_model' folder?


Improve existence checking/make selection proper iterator

A thought —
Often I find I use d3-selection for checking the existence of a single element, which is a bit of a rough edge:

You have to call .size() even if the selection is the result of d3.select (and thus size will always be either 1 or 0)
An empty selection is still truthy

This means you have to explicitly remember to call .size() when existence checking, which sort of is counterintuitive to how selections work via the DOM.
I know the idiom is to act as if selections exist even if they're empty (so data can be bound to them eventually), but if selections were proper iterators there could be a .length property which would make the object falsy if the selection were empty.
Turning selections into proper iterators would also make it possible to use the spread operator on selections and use all the standard array prototype methods (even if it means spreading the selection into an empty array like is frequently done with NodeList objects).
Admittedly I have no idea how feasible or backwards compatible this idea is. 😅

The length property isn’t part of the iterable protocol, and empty iterables are always truthy because every iterable is necessarily an object (e.g., !![] and !!new Map are true).
https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Iteration_protocols
We could have implemented size as a getter rather than a method, for consistency with ES collections, but those didn’t exist at the time d3-selection was initially designed, and I don’t think it’s worth changing that now.
I do agree that selections should implement the iterable protocol, though, iterating over each non-null node in the selection. Let’s do that for d3-selection 2.0.


chore: bdd-sbhg-import-1582003061 to 0.0.1

chore: Promote bdd-sbhg-import-1582003061 to version 0.0.1

[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by:
To fully approve this pull request, please assign additional approvers.
We suggest the following additional approvers:
If they are not already assigned, you can assign the PR to them by writing /assign  in a comment when ready.
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment