[$2000] DEV - Sending a PDF file for the very first time throws a console error “Warning: Failed prop type: The prop isKeyboardShown is marked as required in PDFView, but its value is undefined ”

If you haven’t already, check out our contributing guidelines for onboarding and email<EMAIL_ADDRESS>to request to join our Slack channel!

Action Performed:

Log in any account
Navigate to any chat
Send a PDF file
Notice a console warning shows

Expected Result:
Console warning/error should not shown
Actual Result:
Console warning/error shows
Workaround:
unknown
Platforms:

Which of our officially supported platforms is this issue occurring on?

[ ] MacOS / Chrome / Safari
[ ] MacOS / Desktop

Version Number: 1.2.44-0
Reproducible in staging?: Need reproduction
Reproducible in production?: Need reproduction
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos:

Expensify/Expensify Issue URL:
Issue reported by: @dhairyasenjaliya
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1672205164459619
View all open jobs on GitHub
Upwork Automation - Do Not Edit

Upwork Job URL: https://www.upwork.com/jobs/~016924f68b3e2db67d
Upwork Job ID:<PHONE_NUMBER>453559296
Last Price Increase: 2023-01-06

I'm not able to reproduce, though I notice that in the title it says "very first time" and then in the reproduction steps, that isn't featured. Does that explain the difference?

Oh actually, I just realized that based on the title, this is only happening DEV, is that right? I'm not sure if I'd consider this a bug then, as we're focused on staging and production bugs. Going to float internally to get more thoughts before moving forward.

Alright, we're good here. While I can't reproduce a DEV issues, I'm going to triage and keep the process moving.

Proposal

https://github.com/Expensify/App/blob/9108ef8ae63c836aa6427f42139d7651868913b7/src/components/PDFView/index.js#L168-L170
we have to add withKeyboardState to PDFView
+ withKeyboardState

Before adding withKeyboardState
https://user-images.githubusercontent.com/35371050/210002869-348ea7aa-7a2e-4391-8235-395b4766a184.mov
After adding withKeyboardState
https://user-images.githubusercontent.com/35371050/210002940-f8105343-4a80-41aa-9f53-c1240533b19c.mov

Proposal
Since we only need isKeyboardShown prop in the native file, I think we should define the PropTypes to specific files.
So define all PropTypes from pdfViewPropTypes in  index.js  and index.native.js just don't add  ...keyboardStatePropTypes and for index.js file and it will fix the issue
https://github.com/Expensify/App/blob/9108ef8ae63c836aa6427f42139d7651868913b7/src/components/PDFView/pdfViewPropTypes.js#L17

Proposal

Here we need to define defaultProps by default isKeyboardShown to false in pdfViewPropTypes.js since this file is not platform specific by default setting false makes more sense as also we need isKeyboardShown on the native platform only setting false by default removes undefined values warning on Web platform as it will never find keyboard events

const defaultProps = {
    sourceURL: '',
    style: {},
    onToggleKeyboard: () => {},
+    isKeyboardShown: false,
};

https://github.com/Expensify/App/blob/9108ef8ae63c836aa6427f42139d7651868913b7/src/components/PDFView/pdfViewPropTypes.js#L20-L24
Result with default props
https://user-images.githubusercontent.com/47522946/210029842-9a6e9078-9689-4503-9368-a1668d4d5a26.mp4
Result without default props
https://user-images.githubusercontent.com/47522946/210029895-5bd37df1-17c8-4bd0-8a77-4298a84bca37.mp4

Proposal
We don't need the keyboard the state in web, in this case we can create 2 proptype  variable for native and web, with web proptype we need to remove the keyboardStatePropTypes.
diff --git a/src/components/PDFView/index.native.js b/src/components/PDFView/index.native.js
index 1029750b9..08a444f83 100644
--- a/src/components/PDFView/index.native.js
+++ b/src/components/PDFView/index.native.js
@@ -174,7 +174,7 @@ class PDFView extends Component {
     }
 }

-PDFView.propTypes = pdfViewPropTypes.propTypes;
+PDFView.propTypes = pdfViewPropTypes.nativePropTypes;
 PDFView.defaultProps = pdfViewPropTypes.defaultProps;

 export default compose(
diff --git a/src/components/PDFView/pdfViewPropTypes.js b/src/components/PDFView/pdfViewPropTypes.js
index 5f2c7e381..29334d5db 100644
--- a/src/components/PDFView/pdfViewPropTypes.js
+++ b/src/components/PDFView/pdfViewPropTypes.js
@@ -3,7 +3,7 @@ import stylePropTypes from '../../styles/stylePropTypes';
 import {windowDimensionsPropTypes} from '../withWindowDimensions';
 import {keyboardStatePropTypes} from '../withKeyboardState';

-const propTypes = {
+const nativePropTypes = {
     /** URL to full-sized image */
     sourceURL: PropTypes.string,

@@ -17,10 +17,23 @@ const propTypes = {
     ...keyboardStatePropTypes,
 };

+const propTypes = {
+    /** URL to full-sized image */
+    sourceURL: PropTypes.string,
+
+    /** Additional style props */
+    style: stylePropTypes,
+
+    /** Notify parent that the keyboard has opened or closed */
+    onToggleKeyboard: PropTypes.func,
+
+    ...windowDimensionsPropTypes,
+};
+
 const defaultProps = {
     sourceURL: '',
     style: {},
     onToggleKeyboard: () => {},
 };

-export {propTypes, defaultProps};
+export {propTypes, defaultProps, nativePropTypes};

@rushatgabhane Mind taking the first pass on the proposals above? Thank you! 🙌🏼

Proposal
Problem
This console warning is showing due to isKeyboardShown prop in <PDFView>. <PDFView> expecting prop default value because isKeyboardShown is marked as required prop and we are not passing any default value in <PDFView>.
Solution
To fix this issue, we just have to pass isKeyboardShown prop with default value to <PDFView> default props.
diff --git a/src/components/PDFView/pdfViewPropTypes.js b/src/components/PDFView/pdfViewPropTypes.js
index 5f2c7e381..6991a6da2 100644
--- a/src/components/PDFView/pdfViewPropTypes.js
+++ b/src/components/PDFView/pdfViewPropTypes.js
@@ -21,6 +21,7 @@ const defaultProps = {
     sourceURL: '',
     style: {},
     onToggleKeyboard: () => {},
+    isKeyboardShown: false,
 };

Result
https://user-images.githubusercontent.com/79830748/211007786-84108941-1b53-4d8a-a4f4-e5cc12407172.mov

@rushatgabhane  I have one question here, can you please notify me what's wrong with my proposal I took reference from the ReportActionCompose file as it is used in all platforms and we are passing withKeyboardState for web and desktop too as a file that is common
https://github.com/Expensify/App/blob/f355ee1294cca2f11c1d61bf7e60c3e0f3e3703c/src/pages/home/report/ReportActionCompose.js#L745

@rushatgabhane rather than adding different props for platforms specific files I do think making isKeyboardShown bydefault false makes more sense since we are creating props file to define all props at once for particular component as we do in all components

That's a fair point. There are multiple ways to solve a problem.
I just think that it'll be confusing for someone reading the code that a HOC is being consumed, but it's props are just being ignored. Also, the component might update unnecessarily

we can mention in the comment regarding code readability, and also I dont think the component will get an update since the keyboard event will be only triggered on the native platform

All yours @Puneet-here!

Thanks @grgia @rushatgabhane! PR is ready

Woo! Thanks for the quick work.

Well shoot. Did our GH automation fail? I just noticed this PR hit production several hours ago.

Regression period is over @JmillsExpensify

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

[ ] [@rushatgabhane  / @grgia] The PR that introduced the bug has been identified. Link to the PR:
[ ] [@rushatgabhane  / @grgia] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
[ ] [@rushatgabhane  / @grgia] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
[ ] [@JmillsExpensify] A regression test has been added or updated so that the same bug will not reach production again. Link to the GH issue for creating the test here:

All contributors invited/hired.
@rushatgabhane @grgia can you get complete the first several items on the BZ checklist? I'll get on the regression test. Thanks!

hey @JmillsExpensify can you also invite me for reporting the bug

Nice, yeah let's get that list crossed off!

@dhairyasenjaliya Thanks sorry for missing that! Invited you to the job. While we work on the checklist items, I'll circle back on the regression test as well.

No issue accepted now thanks @JmillsExpensify

Great thanks. Offer sent. Payments are as follows:

Issue reporter: @dhairyasenjaliya $250
Contributor: @Puneet-here $2,000
Contributor+: @rushatgabhane $2,000

C/C+ have been paid out, so at this point our todos are:

@grgia @rushatgabhane complete first three items on BZ checklist
@JmillsExpensify complete regression test
@dhairyasenjaliya accept offer

Thanks everyone!

@JmillsExpensify, it is also eligible for 50% bonus.

Well shoot. Sorry about that. Just sent you/Rushat another offer for $1k to make up the difference.

Accepted, thanks @JmillsExpensify

Alright cool. We're back to these next steps

@grgia @rushatgabhane complete first three items on BZ checklist
@JmillsExpensify complete regression test
@dhairyasenjaliya accept offer

Perfect, thank you! I'm last up, and I'll have to cross that off the list tomorrow.

Alrighty! I came back to this one and looked into the PR and testing steps. I'm not recommending we create an regression issue given the console error focus/nature of the issue. Closing!


Move gevv_vvv_vari out of src/stan/agrad/rev/matrix/Eigen_NumTraits.hpp

src/stan/agrad/rev/matrix/Eigen_NumTraits.hpp should not be defining a class in the namespace stan::agrad. That class should be moved out of this file.

This issue was moved to stan-dev/math#26


Update geojson_measurements.R

Should line 16 be part of the sentence on line 15?

You're right. Solved


Set cache line size in thread pool to 128 bytes on ARM64

Mirrors dotnet/coreclr#12801.
@kouvel

@jkoritzinsky,
Thanks for having already signed the Contribution License Agreement. Your agreement was validated by .NET Foundation. We will now review your pull request.
Thanks,
.NET Foundation Pull Request Bot


region page

we can not see more than 3 countries in region page while there are more countries

@aghpr  Done

Done @ehsan-g


Adding pprof collection

Previous runs where missing pprof

this can be closed in favor of #131 and the following prs that'll enable pprof collection through conprof for all the workloads


API: set Source and Origin

Source and Origin need to start getting set on post creation via the API.

Leaving off on the API portion of this for now. We are not caching posts and expect those connecting with us to set source/origin. Our posts however now have source/origin set on creation.


Analysis module

Hey there Synthetic team,
Would it be possible to have access to the "analysis" module you reference in the Synthea COVID-19 Module Analysis notebook?
Thank you for your work

@eq1234 apologies for this oversight.
The file is now a part of the repo: https://github.com/synthetichealth/module-validation/blob/master/notebooks/analysis.py


Bug in driver or in my code?

Hi! Could anybody help me? I can't fix issue in my code for one week, and begin to think that it's some issue in driver. Because now I do not see any problem in code.
Here is my question on SO. https://stackoverflow.com/questions/69041494/timeoutexception-on-query-cache-class
Here is my full class https://gist.github.com/bubnenkoff/65fa684a3de218bab6102453df3f79fe
I really can't understand why I am getting timeout exception :(
Could anybody at least give any ideas what can be wrong?

what's the exception stack trace?

Only: Future not completed
Сб, 4 сент. 2021 г. в 12:34, István Soós @.***>:

what's the exception stack trace?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/stablekernel/postgresql-dart/issues/166#issuecomment-912942615,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/ABRWNFUU7EPFJOG3BVQB4VTUAHRZJANCNFSM5DM7EDOQ
.
Triage notifications on the go with GitHub Mobile for iOS
https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675
or Android
https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.

Closed because bug is found: https://github.com/stablekernel/postgresql-dart/issues/167


How can I get errors fields provided by server from response when !response.ok ?

How can I get errors fields provided by server from response when !response.ok ?
I need to get those error messages in order to proceed to specific code when I get status 4xx
Your Environment

software
version

node-fetch
2.6.1

node
14

yarn
2.4.1

Thanks for your help

You can still use it as normal
res.ok is only a boolean for if status code was 2xx
const res = await fetch(url)
if (res.ok) {
  console.log(await res.json())
} else {
  console.log(await res.text())
}

Thx for your feedback.
I've tried your advice but cannot catch ctx.body from server :
server code :
const msg = 'Provided date is wrong'
ctx.body = msg;
ctx.status = 404;
return;

server log :
DEBUG: Provided date is wrong

client code :
fetchResult = await fetch(url, {
  method: 'post', body: JSON.stringify(request.body), headers: { Authorization: etlInnerToken, 'Content-Type': 'application/json'}
});
if (!fetchResult .ok) {
  logger.debug(fetchResult );
  logger.debug(fetchResult .text());
  const error = `[fetch KO] ${fetchResult .status}: ${fetchResult .statusText}`;
  logger.debug(error);
  (....)
}

client log :
DEBUG:   (size=0, timeout=0)
DEBUG:
DEBUG:  [fetch KO] 404: Not Found

Can you recommand something here to make it operational ?

Sorry for duplicate issue, I understand but I thought you did not see my comment on previous node after your closed it

I get notified.
It seems like there is a problem with how you are dealing with the server code (cuz fetch works as intended)
i can't really help you with that little context or no sample url

can you even POST anything to the right url endpoint?
are you only accepting a GET request
app.get('something', function(req, res){
  ...
})

Sorry could not earlier (business priority).
I use as backend a koa library (nodejs / express like) for my REST controller.
In this context, ctx object is the one containing everything I Need to get headers, params, body as well as response status, etc...
My POST url works very well actually for a successfull case (ctx.status = 200 and cts.body contains required json which I can properly fetch with your lib)
Now I am trying to get error details provided by backend because I need to process something.
so actually ctx.body = msg fill up body of response and ctx.status = 404 set the response status, very easy
This works very well for standard angular http client for instance (where I usually provide an errors json object in the body).
Anyway . I found the error in my code and fixed it :
logger.debug(await fetchResult .text());
Sorry for holding your time and thx for your answers


--engine-src-path should blow up if --debug or --release are not specified

flutter --engine-src-path=/src/engine/src start for instance.

@mmclenna hit this this morning.

This is obsolete now. The arguments all changed.


Add the TodoTemplate and Bit BlazorUI demo applications (Android, iOS, Windows) to their corresponding stores

Add the TodoTemplate and Bit BlazorUI demo applications (Android, iOS, Windows) to their corresponding stores.

It is resolved now, so I'm closing this issue.


Update siwe to v2

Updates siwe to v2. I had to update the tests to use a valid address since the address is now validated when you create a  SiweMessage, and siwe started using ethers.utils.getAddress so I had to add that to the ethers mock module.
This PR contains the changes from #111 as well since that or another solution to providing a uri to SiweMessage is needed.
Closes https://github.com/tablelandnetwork/js-tableland/issues/106
Blocked by https://github.com/tablelandnetwork/js-tableland/pull/111

This is great. I'm pretty happy with the minimal updates required to get this going. You could even just merge #111 into this PR if you'd like, because it is unlikely one is going in without the other.

Sweet! Ok, this PR contains all commits from #111 so I can just close that one and mark this as ready.

This has some widespread implications in the Validator as well as the Go client, so before we commit to anything it would be good to get an opinion from @jsign and/or @brunocalza
TL;DR; I think we might have got this wrong (my fault) when we built the siwe functionality originally, and we should probably triple check we are following the spec correctly.
Details:
From the spec https://eips.ethereum.org/EIPS/eip-4361:

Sign-In with Ethereum works as follows:

The wallet presents the user with a structured plaintext message or equivalent interface for signing with the EIP-191 signed data format. Before signing, the message is prefixed with \x19Ethereum Signed Message:\n as defined in EIP-191. The message MUST incorporate an Ethereum address, domain requesting the signing, version of the message, a chain identifier chain-id, uri for scoping, nonce acceptable to the relying party, and issued-at timestamp.
...

Specifically there are two fields, domain and uri.  Both are required.

domain is: "the RFC 3986 authority that is requesting the signing".  Reading the spec again, I'm interpreting this as the website https://example.xyz is requesting that you sign this message.  I think we want to set this based on document.location.origin, or let it be specified during connection for the cases of node.js env.  This is currently "Tableland", which is not a valid RFC 3986 so definitely need to change this.
uri is: "an RFC 3986 URI referring to the resource that is the subject of the signing (as in the subject of a claim)."  This would be the value of host, which defaults based on the Tableland Network in utils.ts or can be set during connection if there is a custom Validator/Gateway being used.

If we implement changes here they will also have to be implemented in the validator, i.e. https://github.com/tablelandnetwork/go-tableland/blob/main/internal/router/middlewares/authentication.go#L77 and https://github.com/tablelandnetwork/go-tableland/blob/main/pkg/siwe/siwe.go#L25-L27
For the authentication maybe we could get the URI of the Gateway being served in the context of the request as the value of uri.  Then instead of checking domain we check that the siwe tokenuri value matches the Gateway URI.
@jsign @brunocalza double checking, I am thinking about this right?
cc: @sanderpick @carsonfarmer Does this all make sense to you as well?

This has some widespread implications in the Validator as well as the Go client, so before we commit to anything it would be good to get an opinion from @jsign and/or @brunocalza
TL;DR; I think we might have got this wrong (my fault) when we built the siwe functionality originally, and we should probably triple check we are following the spec correctly.
Details: From the spec https://eips.ethereum.org/EIPS/eip-4361:

Sign-In with Ethereum works as follows:

The wallet presents the user with a structured plaintext message or equivalent interface for signing with the EIP-191 signed data format. Before signing, the message is prefixed with \x19Ethereum Signed Message:\n as defined in EIP-191. The message MUST incorporate an Ethereum address, domain requesting the signing, version of the message, a chain identifier chain-id, uri for scoping, nonce acceptable to the relying party, and issued-at timestamp.
...

Specifically there are two fields that I think we should update, domain and uri. Both are required.

domain is: "the RFC 3986 authority that is requesting the signing".  Reading the spec again, I'm interpreting this as the website https://example.xyz is requesting that you sign this message.  I think we want to set this based on document.location.origin, or let it be specified during connection for the cases of node.js env.  This is currently "Tableland", which is not a valid RFC 3986 so definitely need to change this.
uri is: "an RFC 3986 URI referring to the resource that is the subject of the signing (as in the subject of a claim)."  This would be the value of host, which defaults based on the Tableland Network in utils.ts or can be set during connection if there is a custom Validator/Gateway being used.

If we implement changes here they will also have to be implemented in the validator, i.e. https://github.com/tablelandnetwork/go-tableland/blob/main/internal/router/middlewares/authentication.go#L77 and https://github.com/tablelandnetwork/go-tableland/blob/main/pkg/siwe/siwe.go#L25-L27 For the authentication maybe we could get the URI of the Gateway being served in the context of the request as the value of uri. Then instead of checking domain we check that the siwe tokenuri value matches the Gateway URI. @jsign @brunocalza double checking, I am thinking about this right?
cc: @sanderpick @carsonfarmer Does this all make sense to you as well?

Makes sense to me. Any of these changes in the validator are simple. We already have a config attribute in the validator with the DNS where the gateway is served; so we can validate with that.
What I think we might need to think a bit more about is how all this makes sense when there're more validators and gateways.

These values would have defaults that users can change with SDK options?
What does it mean to validate a DNS in uri if a validator doesn't have a DNS?
We should make optional the uri checking in the validator to solve the above bullet?

Finally, doing this kind of change in a single version will force people to immediately update to the latest SDK version which might be a bit violent. We could do the change in the validator to support "both formats/validations" for a while to at least give people a week or similar before their requests start being rejected.

These values would have defaults that users can change with SDK options?

That's a good question. It feels natural to allow an SDK user (and downstream CLI user) to specify their validator of choice. I suspect we'll hit this need as soon as we have multiple validators (soon!) cc @joewagner, could you create an issue for this where we can discuss it?

What does it mean to validate a DNS in uri if a validator doesn't have a DNS?

Good question. We could use IP address but that might look scary to the user. We could use a "nickname" that the user gives their validator of choice in the case where it doesn't have a DNS. At least this way it would look familiar and be easy to cross check visually.

We should make optional the uri checking in the validator to solve the above bullet?

Sounds right

Finally, doing this kind of change in a single version will force people to immediately update to the latest SDK version, which might be a bit violent. We could do the change in the validator to support "both formats/validations" for a while to at least give people a week or similar before their requests start being rejected. After a ~week, we can remove the old rules and only leave the new ones.

Nice, sounds right!

It feels natural to allow an SDK user (and downstream CLI user) to specify their validator of choice. I suspect we'll hit this need as soon as we have multiple validators (soon!) cc @joewagner, could you create an issue for this where we can discuss it?

@sanderpick I created #117 and included some of the outstanding questions from the above discussion.

Perfect, thank you
On Aug 21, 2022, 3:59 PM -0700, Joe Wagner @.***>, wrote:

It feels natural to allow an SDK user (and downstream CLI user) to specify their validator of choice. I suspect we'll hit this need as soon as we have multiple validators (soon!) cc @joewagner, could you create an issue for this where we can discuss it?
@sanderpick I created #117 and included some of the outstanding questions from the above discussion.
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you were mentioned.Message ID: @.***>

How we doing here guys? Any open questions that need addressing?

I'm actually not sure what changes are needed elsewhere. @joewagner / @carsonfarmer probably has the best bird's eye view of it. can you guys create some issues on other repos that this PR can be blocked by?

I'm going to defer to @joewagner on this one as he is most aware of the work required here. @joewagner I can support you if you want to tag me on stuff.

From a birds eye view, I think we can separate this into two issues.

Our SIWE message is not being constructed and validated in a way that matches the spec.  I don't know if anything is really broken because of this, but it feels to me like something we should fix soon for the sake of following best practices.
Our npm siwe dependency version needs to be updated to enable running npm install in this repo without the force flag.

@datadanne has an excellent PR to fix number 2. I ran all the integration tests and this can be merged without breaking anything or making any changes in the validator.
@sanderpick @jsign @carsonfarmer If everyone is on board, I'll suggest we merge this then I can create issues that describe what we need to do to fix number 1 here and in go-validator.  Give a 👍 if this makes sense.
Alternatively, we could make a plan to follow the siwe spec more closely and create blocking issues for this PR. Give a 👎  if this makes sense.

Agreed, let's go for it.

TL;DR: Users of the SDK will have to make sure that an implementation of Buffer is available in the global scope, which it isn't in browsers by default

@datadanne Thanks for the reminder. Would you be able to create an issue for this and assign me?  Sounds like an easy fix, but I don't want to forget about it since this is already merged

Ok, good to know. Thanks!


DNM: test pre-adoption-validation change

Depends-On: https://github.com/openstack-k8s-operators/edpm-ansible/pull/631

check run looks good https://logserver.rdoproject.org/16/416/68bc6460149a064a1b2356247cef407910aa16e9/github-check/data-plane-adoption-osp-17-to-extracted-crc-minimal-no-ceph/34e3bf1/controller/ci-framework-data/logs/openstack-k8s-operators-openstack-must-gather/namespaces/openstack/pods/pre-adoption-validation-openstack-pre-adoption-openstack-cmzgn/logs/openstackansibleee.log


Add sample tasks

Add starter tasks on initialisation

Codecov Report

Merging #187 (aedd732) into master (5249c38) will decrease coverage by 0.31%.
The diff coverage is 0.00%.

@@             Coverage Diff              @@
##             master     #187      +/-   ##
============================================
- Coverage     58.23%   57.91%   -0.32%
  Complexity      647      647
============================================
  Files           125      125
  Lines          2715     2730      +15
  Branches        261      262       +1
============================================
  Hits           1581     1581
- Misses         1033     1048      +15
  Partials        101      101

Impacted Files
Coverage Δ

src/main/java/seedu/address/MainApp.java
0.00% <0.00%> (ø)

.../java/seedu/address/model/util/SampleDataUtil.java
18.18% <0.00%> (-15.16%)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5249c38...aedd732. Read the comment docs.


Bootstrap Problem with Pagination

Version: 3.3.7 (newest)
CMS: Wordpress
Hello guys, I have followed your tutorial of how to set up a bootsrap pagination and wrote a wordpress function to add classes and html tags. But there is a problem. Even though the pagination breaks after every item. So f.e. page 2 is one line under page 1 etc.
URL: https://www.weeabow.de
I don't get what I did wrong

remove
a {
/*! clear:both; */
}
from style.css

I just see that you have changed to navigations markup...
It is not very useful to post bug reports when fiddling around with the code.
Thanks for wasting my time!

However it was just a test for pagination if the articles for my client get too much, the pagination will be needed. Thanks for help, I changed some things too and working fine.

Bootstrap 3 is no longer officially supported. Please use the community forums linked in the README, e.g. StackOverflow, for further assistance. Thanks.

Thanks,
bugs filed...
for BS4 demo see
http://www.codeply.com/go/GjrVfpcyEv
scroll down to select and watch the navbar disappear
Gordon Suchomski
Senior Manager EFB & Flight Documentation
IT-Systementwicklung - Luftfahrtsysteme
Air Berlin PLC & Co. Luftverkehrs KG
Saatwinkler Damm 42-43
13627 Berlin
airberlin group
Tel: +49 (0)30 3434 4017
Fax: +49 (0)30 3434 4449
gsuchomski<EMAIL_ADDRESS>http://www.airberlin.com
Von: Chris Rebert<EMAIL_ADDRESS>Gesendet: Donnerstag, 22. September 2016 00:52
An: twbs/bootstrap
Cc: Suchomski, Gordon; Comment
Betreff: Re: [twbs/bootstrap] Bootstrap Problem with Pagination (#20761)
Bootstrap 3 is no longer officially supported. Please use the community forums linked in the README, e.g. StackOverflow, for further assistance. Thanks.
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHubhttps://github.com/twbs/bootstrap/issues/20761#issuecomment-248765239, or mute the threadhttps://github.com/notifications/unsubscribe-auth/ADzRZw0iczvC2C7eeR3FCQV-T4NJTA0Xks5qsbUogaJpZM4KDMwj.


Added Pig Latin Novelty Language

got bored, wanted to add pig latin

please follow the proper pattern for commit messages (💡TIP: you can use yarn commit or yarn commit:signed and answer the questions asked to generate a properly formatted one for you!)
to fix your most recent commit you can run the command git commit --amend -m "properly formatted commit message here"
to fix your older/multiple commits please take a look at this article

please follow the proper pattern for commit messages (💡TIP: you can use yarn commit or yarn commit:signed and answer the questions asked to generate a properly formatted one for you!)
to fix your most recent commit you can run the command git commit --amend -m "properly formatted commit message here"
to fix your older/multiple commits please take a look at this article

I attempted to fix the commit but instead it just added a new one instead of overwriting

Nevermind, realized my mistake

@Hypercoded you messed the commits up again

@Hypercoded you messed the commits up again

Should I just close this PR, copy the code over to a different one and then open a new PR?


Goerli indexer stuck but node seems to be indexing

Our Goerli node seems to be syncing correctly (see https://safe-transaction.goerli.gnosis.io/api/v1/about/ethereum-tracing-rpc/)
However the indexer seems to be stuck (or moving really slowly) see – https://safe-transaction.goerli.gnosis.io/api/v1/about/master-copies/
We should check if there's any issue that causes this big difference in our indexing.

Looks like we were using the wrong node. Service looks up to date now


Final capston project

We are a group of four members which are (@binodbhusal , @rahimialijan , @Tshobohwa , @dieum512 )
These are the tasks that we have done in this project
Core features - Required for every team size

The user logs in to the website, only by typing the username (a proper authenticated login is a requirement if your group is made of 5 people).

In the navigation panel, the user can see links to:

Motorcycles/doctors/classes/items that you selected as a theme.
"Reserve" form.
"My reservations".
"Add motorcycle/doctor/class/item that you selected as a theme" (the link is visible to everybody).
"Delete motorcycle/doctor/class/item that you selected as a theme" (the link is visible to everybody).

On the main page, the user can see a list of motorcycles/doctors/classes/items that you selected as a theme.

When the user selects a specific item, they can see the details page with its full description (skip the "Rotate image" button).

In the details page, the user can click the "Reserve" button (in the design you can see the "Configure" button - please replace it with the "Reserve" button).

When the user clicks the "Add item" link in the navigation panel they can see a form for adding a new item.

Make the app responsive, creating both mobile and desktop versions.

When the user clicks the "Delete item" link in the navigation panel they can see a list of all items with title and "Delete" button.

When the user clicks the "Delete" button, the selected item is marked as removed and does not show on the main list anymore.

To reserve an appointment, the user has to select a date and city (username and selected item are autofilled).

Use the design based on the "Book a vespa test-ride" and add all necessary inputs.
The user can also access the "Reserve" page from the navigation panel. In that case only username is autofilled.

When the user clicks the "My reservations" link in the navigation panel they can see a list of their reservations (with information about item name, date and city).
Add full documentation for your API.

Here is the link to the frontend project
Here is the link to the Kanban board
Thank you so much for taking the time to review this project :hugs:

Front-end Review
Hi Team,
Good job so far!
There are some issues that you still need to work on to go to the next project but you are almost there!
Highlights

You have tests 👍
Meet functional requirements 👍
Routes, store and reducers look good 👍
Good separation of concerns with API logic and reducers 👍

Required Changes ♻

Don't forget that the application needs to look exactly like design with exception of photos, titles and descriptions

Optional suggestions
Every comment with the [OPTIONAL] prefix is not crucial enough to stop the approval of this PR. However, I strongly recommend you to take them into account as they can make your code better.
You can also consider:

There are some candidates to make some of these html components reusable. Some that may benefit:

MotorDetails
AddMotor

Hope all is well, and that my comments were helpful. 😸
Cheers and Happy coding!👏👏👏
Feel free to leave any questions or comments in the PR thread if something is not 100% clear.
Please, remember to tag me in your question so I can receive the notification.
Please, do not open a new Pull Request for re-reviews. You should use the same Pull Request submitted for the first review, either valid or invalid unless it is requested otherwise.

As described in the Code reviews limits policy you have a limited number of reviews per project (check the exact number in your Dashboard). If you think that the code review was not fair, you can request a second opinion using this form.
Also, you do not have to implement all requested changes, as this is up to you in the end, but I strongly recommend you implement them.


typscript error logger.stream write function

Please tell us about your environment:

winston version?

[ ] winston@2
[X] winston@3

node -v outputs: v9.8.0
Operating System? MacOS
Language? typescript: Version 2.9.1

What is the problem?
I have a typescript error when trying to create a write function in the logger.stream object.
error TS2322: Type '{ write(message: any, encoding: any): void; }' is not assignable to type '(options?: any) => ReadableStream'.
  Object literal may only specify known properties, and 'write' does not exist in type '(options?: any) => ReadableStream'.

39             write(message: any, encoding: any) {
               ~~~~~

What do you expect to happen instead?
No error
###Other
const options = {
            file: {
                level: "info",
                filename: `${appRoot}/logs/app.log`,
                handleExceptions: true,
                json: true,
                maxsize: 5242880, // 5MB
                maxFiles: 5,
                colorize: false,
            },
            console: {
                level: "debug",
                handleExceptions: true,
                json: false,
                colorize: true,
            },
        };

        this.logger = winston.createLogger({
            transports: [
                new winston.transports.File(options.file),
                new winston.transports.Console(options.console),
            ],
            exitOnError: false, // do not exit on handled exceptions
        });

        // create a stream object with a 'write' function that will be used by `morgan`
        this.logger.stream = {

            write(message: any, encoding: any) {
                // use the 'info' log level so the output will be picked up by both transports (file and console)
                this.logger.info(message);
            },
        };

I am following this tutorial:
https://www.digitalocean.com/community/tutorials/how-to-use-winston-to-log-node-js-applications

have same error

At first glance it looks like the issue is in the type definitions: stream(options?: any): NodeJS.ReadableStream; It needs to be duplex I suspect.

This is an issue because you're adding stream directly into your logger try this instead:
// At the bottom of your winston config add

export const stream = {
  write: (message) => {
    logger.info(message);
  },
};

Then change your logging in express like this:
import { stream } from 'config/winston.ts';
import * as morgan from 'morgan';

app.use(morgan('combined', { stream }));

Because of the error you posted I'm assuming that you're using typescript, hence my example is written in typescript. One small gotcha, you may be tempted to write your stream like this:
export const stream = {
  write: logger.info,
};

This however will throw an exception as the second argument of the stream function is not what your logger info function is expecting. Let me know if this helps.


Why is react not a dev dependency?

Thanks for sharing this template and the accompanying article.
Could you dive into a little bit more detail about why react is only a peer dependency, and not a dev dependency, too?
https://github.com/Timonwa/demo-ui-library/blob/main/package.json#L62-L65
It looks like React is imported in the actual code - doesn't this mean that it should be a dev dependency?
https://github.com/Timonwa/demo-ui-library/blob/d5fee046af2d0975830be54962bc20fc5a35400d/src/components/Button/Button.tsx#L1
Based on this StackOverflow answer, I would be inclined to believe that react should be added in devDependencies.
Side note: would you like to enable GitHub Discussions in this repository? I would have created a discussion instead of a repo.

Hi @PaulRBerg. Thanks for your feedback! React is listed as a peer dependency in the package.json because the library assumes the consuming project already has React installed. This allows flexibility in choosing the React version. The import statement in the code doesn't necessarily mean React should be a dev dependency. Regarding GitHub Discussions, it's a great idea to enable it for more interactive discussions. Please let me know if you have further questions. Thanks!

Thanks for confirming @Timonwa. I'll close this issue.


imports NIOWebSocket and then shows "No such module NIOWebSocket" error message

Description
Issue: In an Xcode SwiftUI file, when I write "import NW" or "import Net", it suggests "NIOWebSocket". When I finally import it (NIOWebSocket), the error message shows "No such module NIOWebSocket"
Suggestion: If a library is unavailable to import on Xcode, it should not be suggested when a developer writes "import".
Tested On: Xcode Version 15.2 (15C500b), OS: macOS Sonoma 14.3.1, Swift 5.9
Screenshot has been attached for clarification.

Reproduction
import NIOWebSocket

Expected behavior
I expect that if NIOWebSocket is unavailable, it should not be suggested to import in a SwiftUI file or in any Xcode file.
Environment
swift-driver version: 1.87.3 Apple Swift version 5.9.2 (swiftlang-<IP_ADDRESS>.56 clang-15<IP_ADDRESS>.5)
Additional information
No response

The error is likely somewhere else in your project.    Had the same issue, but it was simply something went afowl in my other project files.
.library(name: "NIOWebSocket", targets: ["NIOWebSocket"]), the namespace should exist as it's defined in the package.


AUI-1873

Hey @mairatma,
Attached is an update for http://issues.liferay.com/browse/AUI-1873.
Please let me know if you have any questions.
Thanks!

As I mentioned on https://github.com/mairatma/yui3/pull/3, we should move the changes that were going to be made on yui side to AlloyUI's button, so this pull request should be updated with them.

I'll close this for now, since it's pending changes.


Colin.hillis/doc 4942/convert md links to hugo links ent4.10

Approx 400 links updated to Hugo links in Enterprise 4.10 - consisting of links starting with ./ and ../ and ending in .md
Approx 25-30 broken links fixed.

Although there were 21 links discovered by new hugo refs build checks, 4-8 others were manually found during process beforehand.


Added PCI interface recovery check for EEH

Added a function to return the count of PCI interfaces, and
through that, checking if all PCI interfaces recovered after EEH.
Signed-off-by: Narasimhan V<EMAIL_ADDRESS>

This change is

@pridhiviraj I have addressed your comments. Please verify


missing  sources when uri is not just a file

Describe the bug
Missing sources warnings when the uri is not a file:

https://github.com/unocss/unocss/issues/3636
https://github.com/vuetifyjs/vuetify-loader/issues/290

The fix should be easy (import fsPathFromUrl and use it when decoding source path in injectSourcesContent):
// packages/vite/src/node/server/sourcemap.ts
import { blankReplacer, createDebugger, fsPathFromUrl } from '../utils'
...
// L56
let resolvedSourcePath = fsPathFromUrl(decodeURI(sourcePath))

Reproduction
https://stackblitz.com/edit/nuxt-starter-w4dvxu?file=nuxt.config.ts,brand%2Fnuxt.config.ts
Steps to reproduce
The warning on console once  dev server started.
System Info
System:
    OS: Windows 10 10.0.19045
    CPU: (20) x64 12th Gen Intel(R) Core(TM) i7-12700H
    Memory: 29.27 GB / 63.71 GB
  Binaries:
    Node: 20.10.0 - C:\Program Files\nodejs\node.EXE
    Yarn: 1.22.19 - C:\Program Files\nodejs\yarn.CMD
    npm: 10.2.3 - C:\Program Files\nodejs\npm.CMD
    pnpm: 8.15.4 - C:\Program Files\nodejs\pnpm.CMD
  Browsers:
    Edge: Chromium (122.0.2365.80)
    Internet Explorer: 11.0.19041.3636

Used Package Manager
npm
Logs
Writing to console the error (L63 and L64 in packages/vite/src/node/server/sourcemap.ts):
[16:15:40]  ERROR  D:\work\issues-repos\unocss-issue-3636\brand\components\dialog\test\Test.vue?nuxt_component=async&nuxt_component_name=DialogTest ENOENT: no such fil
e or directory, open 'D:\work\issues-repos\unocss-issue-3636\brand\components\dialog\test\Test.vue?nuxt_component=async&nuxt_component_name=DialogTest'

Validations

[X] Follow our Code of Conduct
[X] Read the Contributing Guidelines.
[X] Read the docs.
[X] Check that there isn't already an issue that reports the same bug to avoid creating a duplicate.
[X] Make sure this is a Vite issue and not a framework-specific issue. For example, if it's a Vue SFC related bug, it should likely be reported to vuejs/core instead.
[X] Check that this is a concrete bug. For Q&A open a GitHub Discussion or join our Discord Chat Server.
[X] The provided reproduction is a minimal reproducible example of the bug.

Seems to be a problem for some Storybook setups that generate source maps. https://github.com/storybookjs/storybook/issues/28567#issuecomment-2241307873

It reproduced but after adding
"overrides": {
    "vite": "^5.4.0"
  }

the warning didn't happen.
I guess it was fixed somewhere between 5.1.5 and 5.4.3


Cannot properly build a simple sqlite application

Hey everyone!
I must first state that I have never used this package before, but I had some experience with SQLite in other languages.
I am working on my MacOS (Sequoia - M3 Pro), using VsCode. Everything is up to date, always.
I wrote my very simple code:
package main

import (
	"log"

	_ "github.com/mattn/go-sqlite3"
)

func main() {
	log.Println("Hello, World!")
}

I am unable to debug my app in VsCode with the following lauch.json:
{
    "version": "0.2.0",
    "configurations": [
        {
            "type": "go",
            "name": "Start hello",
            "request": "launch",
            "mode": "auto",
            "cwd": "${workspaceFolder}",
            "program": "${workspaceFolder}/cmd/hello"
        }
    ]
}

I went and tried to debug manually, but then I had issues when trying to create an executable from it 😢
I am able to run this code with the go run ./cmd/hello command, however, I have difficulties when I try to create executable from it. I tried the following commands:
go build ./cmd/hello
CGO_ENABLED=1 go build ./cmd/hello
CGO_ENABLED=1 go build -tags "darwin arm64"  ./cmd/hello
CGO_ENABLED=1 go build -tags "darwin arm64 libsqlite3"  ./cmd/hello

None of that seems to result an executable that works.
If I try to run the executable from the vs-code integrated command line, the executable hangs, won't respond to ctrl+c, in separate terminals, the executable crashes.
Crash report attached.
I think i will have other issues once I need to dockerize my app, but that's for another day I think (cross platform builds for amd64/arm64 linux).
Do you have any good tips on this?
crashreport.txt

What version of Go are you using? What version of this library are you using? What version of which C compiler are you using?
Are you saying that go build itself hangs, or the binary that it produces hangs?

Versions:
go version go1.22.5 darwin/arm64
github.com/mattn/go-sqlite3 v1.14.23
gcc -v                                                                                668ms
Apple clang version 16.0.0 (clang-16<IP_ADDRESS>)
Target: arm64-apple-darwin24.0.0
Thread model: posix
InstalledDir: /Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin

The produced binary hangs when trying to start it.

Your crash report suggests it is getting killed because the code was not signed. That seems like a macos configuration issue of some kind?

+1
I'm having exactly same issue, also on MacOS, did you was able to work around this @IceBjerg

No workaround unfortunately.

And I am also being able to build the app without the import being in it, so I don't think it's MacOS configuration issue.

I encountered a similar issue and resolved it temporarily by manually code signing with codesign --sign - ./main. However, I have to repeat this process every time I build, which doesn't seem like a proper solution.

I had this same problem (specifically, binaries where I had included go-sqlite3 were being killed for codesigning reason). Doing things like clearing the go module and build cache did not help.
I ended up resolving it by uninstalling and reinstalling go from brew (brew uninstall go and brew install go).
That's an unfortunately superstitious thing to have to do, but I haven't had this since. Given what feels like a recent spike in these reports for mac users here, I wonder if there's something weird that happened to brew installs of go and clang interacting with each other.

I recently updated to Mac OS 15.0.1 Sequoia and started experience this issue as well. Running codesign --sign - ./main does make it run. Doing go run main.go also works.
I did not install go from homebrew but instead manually installed it in /usr/local/go.


add badge next to github PR and issues

This PR updates the generate-book.sh to find all github issue and PR links in the output and add beautiful shields.io badges to show the status (merged/open etc.).
(Note: shields.io has updated to use GitHub's purple color for "closed". The screenshots below have not been updated.)

Open Questions

Should it replace the text and be a link itself?
any other type of badges?
Should it handle github links that are not clickable? example is RFC 2528 - i can give it try if this PR gets approved.
This currently handles all github issue and PR link (second image above is a PR in mozilla/rust repo) should it be restricted to links in rust-lang/* repos only?
OR should this script just update the source files (from text/ folder) to bring the changes under source control?

Why?
Being an absolute noob in Rust and due to lack of understanding of the lifecycle of RFCs, I recently spent a lot of time trying to get something working. Just to realise the RFC wasn't incorporated in the language. A badge next to these links would probably make it easier to me to spot this.
Feel free to approve this if you think this will be useful for other. You may also have good reason to not load resources from external site. Thank you either way. 🙏

I think this is an interesting idea, although also speaking as a maintainer of the Shields.io service, I'm wondering if the fact that we still use a red color for closed issues on the badges (GitHub semi-recently switched this to purple) might be problematic in this context give the typical connotations associated with red. I.e. what's the potential for some folks to be confused/misinterpret a red badge as the issue having been rejected/declined/etc.

might be problematic in this context give the typical connotations associated with red. I.e. what's the potential for some folks to be confused/misinterpret a red badge as the issue having been rejected/declined/etc.

This is a good point, sheilds.io could match the colour used in github. However in this context, either colour could be a visual cue to for the folks to go and have a look at the issue itself.
It would be great if there was a reliable way to determine if an rfc has been implemented. I see a label B-RFC-approved used but not sure if this gets removed once the work is done.

might be problematic in this context give the typical connotations associated with red. I.e. what's the potential for some folks to be confused/misinterpret a red badge as the issue having been rejected/declined/etc.

This is a good point, sheilds.io could match the colour used in github. However in this context, either colour could be a visual cue to for the folks to go and have a look at the issue itself.
It would be great if there was a reliable way to determine if an rfc has been implemented. I see a label B-RFC-approved used but not sure if this gets removed once the work is done.

https://github.com/badges/shields/issues/7372

Just a heads up that I've updated Shields so probably a good idea to update the screenshots in the description too whenever you get a chance.
https://img.shields.io/github/issues/detail/state/rust-lang/rust/13885

Afterwards it may be worth having this thread of comments hidden since it was a tangential topic that's subsequently been resolved (though will differ that to those with access)

@mustakimali If you can rebase this to apply again, I'd be happy to see it merged.


Error: Circular Reference Detected on Table Display

So this may appear to be similar to #7935 is is actually different. I was running a Dataframe into a BeakerX table and saw that I had some int64 columns and assumed they were the issue. They were not.
However, I had two columns that were of type bool in df.dtypes. When I converted these two to type object, then the dataframe was displayed correctly. Thus what ever caused an issue with int64 probably needs to be looked at for type bool as well.
This is on Pandas version 0.24.2 and BeakerX 1.4.0

Example Code:
import pandas as pd
from beakerx import *
from beakerx.object import beakerx
#Display mode: TableDisplay Widget
beakerx.pandas_display_table()
df = pd.DataFrame(data=np.zeros((5,5)), index=pd.Int64Index([0, 1, 2, 3, 4], dtype='int64'))
df # Displays properly

df.dtypes

0    float64
1    float64
2    float64
3    float64
4    float64
dtype: object
df[2] = df[2].astype(bool)
df.dtypes

0    float64
1    float64
2       bool
3    float64
4    float64
dtype: object
df # Errors out

---------------------------------------------------------------------------
ValueError                                Traceback (most recent call last)
/opt/conda/lib/python3.7/site-packages/IPython/core/formatters.py in __call__(self, obj)
    916             method = get_real_method(obj, self.print_method)
    917             if method is not None:
--> 918                 method()
    919                 return True
    920

/opt/conda/lib/python3.7/site-packages/beakerx/runtime.py in f()
    467     def __get__(self, model_instance, model_class):
    468         def f():
--> 469             display_html(TableDisplay(model_instance))
    470
    471         return f

/opt/conda/lib/python3.7/site-packages/beakerx/tabledisplay/tabledisplay.py in __init__(self, *args, **kwargs)
    211         super(TableDisplay, self).__init__(**kwargs)
    212         self.chart = Table(*args, **kwargs)
--> 213         self.model = self.chart.transform()
    214         self.on_msg(self.handle_msg)
    215         self.details = None

/opt/conda/lib/python3.7/site-packages/beakerx/utils.py in transform(self)
     53
     54     def transform(self):
---> 55         model = json.dumps(self, cls=ObjectEncoder)
     56         return json.loads(model)
     57

/opt/conda/lib/python3.7/json/__init__.py in dumps(obj, skipkeys, ensure_ascii, check_circular, allow_nan, cls, indent, separators, default, sort_keys, **kw)
    236         check_circular=check_circular, allow_nan=allow_nan, indent=indent,
    237         separators=separators, default=default, sort_keys=sort_keys,
--> 238         **kw).encode(obj)
    239
    240

/opt/conda/lib/python3.7/json/encoder.py in encode(self, o)
    197         # exceptions aren't as detailed.  The list call should be roughly
    198         # equivalent to the PySequence_Fast that ''.join() would do.
--> 199         chunks = self.iterencode(o, _one_shot=True)
    200         if not isinstance(chunks, (list, tuple)):
    201             chunks = list(chunks)

/opt/conda/lib/python3.7/json/encoder.py in iterencode(self, o, _one_shot)
    255                 self.key_separator, self.item_separator, self.sort_keys,
    256                 self.skipkeys, _one_shot)
--> 257         return _iterencode(o, 0)
    258
    259 def _make_iterencode(markers, _default, _encoder, _indent, _floatstr,

ValueError: Circular reference detected

I just ran into the same problem with Pandas 0.24.2 and BeakerX 1.4.1

Had the same bug with all of float16, float32, int8, int16, int32, ... for TableDisplay(pd.DataFrame(np.array([[1]], dtype="float32")))

Hi all,
I recently saw this issue, I have been able to fix it for me using the following changes:
In beakerx_base\util.py, Line 188, replace the function with the following code:
class ObjectEncoder(json.JSONEncoder):     def default(self, obj):         if isinstance(obj, datetime):             return date_time_2_millis(obj)         elif isinstance(obj, Enum):             return obj.value         elif isinstance(obj, Color):             return obj.hex()         elif isinstance(obj, pd.Series):             return obj.tolist()         elif isinstance(obj, np.ndarray):             return obj.tolist()         elif isinstance(obj, np.generic):             return obj.item()         elif hasattr(obj, "__dict__"):             d = dict(                 (key, value)                 for key, value in inspect.getmembers(obj)                 if value is not None                 and not key == "Position"                 and not key == "colorProvider"                 and not key == "toolTipBuilder"                 and not key == "parent"                 and not key.startswith("__")                 and not inspect.isabstract(value)                 and not inspect.isbuiltin(value)                 and not inspect.isfunction(value)                 and not inspect.isgenerator(value)                 and not inspect.isgeneratorfunction(value)                 and not inspect.ismethod(value)                 and not inspect.ismethoddescriptor(value)                 and not inspect.isroutine(value)             )             return d         return json.JSONEncoder.default(self,obj)


planner: 0.14.6 -> 20170422

Motivation for this change
Numerous minor fixes since the release.
Things done

[X] Tested using sandboxing
(nix.useSandbox on NixOS,
or option build-use-sandbox in nix.conf
on non-NixOS)
Built on platform(s)

[X] NixOS
[ ] macOS
[ ] Linux

[X] Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
[X] Tested execution of all binary files (usually in ./result/bin/)
[ ] Fits CONTRIBUTING.md.

Have you suggested to upstream developers to make a release? I find it very wrong when downstreams like Nixpkgs have to use unreleased software. Making a release can be as simple as "git tag && git push" (although many have projects have some more steps). Unless planner is dead upstream, they should make a release!

@bjornfor No, but I was told that "No release planned in the
foreseeable future so it may take a while to reach distributions, but
at least it’s upstreamed now." -- So I doubt I should suggest it.

@amiloradovsky: I don't understand that quote at all. (If they don't make releases, the releases will never reach distributions. What is upstreamed?)

@bjornfor Sorry, here's some context:

https://github.com/NixOS/nixpkgs/pull/21012
https://github.com/GNOME/planner/pulls?q=is%3Apr+is%3Aclosed
and a recent discussion in the mailing list [looking for an archive link...]

@amiloradovsky: Ok, I see now. So you first proposed some patches to planner in Nixpkgs, to fix some bugs. It was suggested instead to apply those patches upstream. You proposed the patches upstream and they integrated them.
Now upstream has 5+ years of features and bug fixes since the latest release, but still have no plans of a release? That's crazy. You should definitely suggest they make a release :-)

https://mail.gnome.org/archives/planner-dev-list/2017-April/thread.htm

"The requested URL /archives/planner-dev-list/2017-April/thread.htm was not found on this server."

@bjornfor Ah, it must be html. I probably accidentally deleted the last character.

The last patch has just been merged, fixed the revision.
Referencing a release would be fine too, contacted about it here:

https://mail.gnome.org/archives/planner-dev-list/2017-April/msg00019.html

Waiting...

Hash check failed due to a redirect, fixed.


Make it easy to see which modules have already been "cloned"

A fast ipfs files ls /npm-registry would take care of this enhancement
@whyrusleeping, you had some ideas? :)

This would be really good!

Once this is merged, we can make it a feature of the CLI! :) https://github.com/ipfs/go-ipfs/pull/2007

@diasdavid the referenced issue has been merged what else do you want to do here, add a search command? or just a registry-mirror ls ?

oh good idea! having search would be very helpful to identify if something is there already

on https://github.com/diasdavid/registry-mirror/pull/15


Cleanup references to ADS in SQL Bindings Readme

Just noticed this when installing the extension in VS Code. Removing references to ADS, since we're not shipping the extension there.

https://github.com/microsoft/azuredatastudio/issues/19103 FYI

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

0 of 0   changed or added relevant lines in 0 files are covered.
6 unchanged lines in 2 files lost coverage.
Overall coverage decreased (-0.01%) to 42.199%

Files with Coverage Reduction
New Missed Lines
%

extensions/notebook/src/book/bookTreeView.ts
2
38.21%

extensions/notebook/src/jupyter/serverInstance.ts
4
75.13%

Totals

Change from base Build<PHONE_NUMBER>:
-0.01%

Covered Lines:
27752

Relevant Lines:
61529

💛  - Coveralls


Can't get simple site to work...

I'm trying to get the simple quickstart site to work.
I posted here on the Hugo forum.
I'm missing something obvious I think.  Any suggestions on why I can't just render the basic quickstart single page site would be appreciated!

Hey @adamb
The only thing I see that could cause an issue would be an invalid configuration. For a simple test, you can copy-paste the config.toml from the docs you can find here:
https://github.com/wildhaber/gohugo-amp#configuration
You can find an actual working example here:
https://github.com/wildhaber/gohugo-amp.gohugohq.com
It's actually the underlaying live project that runs https://gohugo-amp.gohugohq.com
Hope this helped you any further :-)

Thanks!  I did copy the toml and it still gives me a blank page.  I noticed
in the example site there is a content/index.md and if I copy that it gets
created. But my content in content/posts/my-first-post.md doesn't create a
page.
In other themes it automatically generated the index page.  Maybe that's
part of what I'm missing.  I was expecting that behavior here too.
Any idea why I don't get a page generated from
content/posts/my-first-post.md?  I'm just following the quickstart and
choosing gohugo-amp as my theme.  If use other themes it generates the main
index.html page and the posts/my-first-post.html page too.
Sorry I must be missing something that is obvious.
Regards,
Adam

On Fri, Aug 24, 2018 at 8:39 AM Raphael<EMAIL_ADDRESS>wrote:

Hey @adamb https://github.com/adamb
The only thing I see that could cause an issue would be an invalid
configuration. For a simple test, you can copy-paste the config.toml from
the docs you can find here:
https://github.com/wildhaber/gohugo-amp#configuration
You can find an actual working example here:
https://github.com/wildhaber/gohugo-amp.gohugohq.com
It's actually the underlaying live project that runs
https://gohugo-amp.gohugohq.com
Hope this helped you any further :-)
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/wildhaber/gohugo-amp/issues/40#issuecomment-415746660,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAARWRtZdPCw828ev-22G3n9M7PnFj_pks5uT_QOgaJpZM4WGLr8
.

Actually, the exampleSite has a couple pages like content/articles/article-one.md but when I run hugo there with the gohugo-amp theme those pages don't seem to get generated either.

$ find public -name art*
$ # nada

Any clues as to what I'm missing would be apprecaited.

I'm also getting intermittent blank page rendering from the gohugo local server 🤔

FYI I was able to get consistent rendering by modifying gohugo-amp/layouts/index.html - commenting out {{if eq .Params.index true }} as {{/* if eq .Params.index true */}}. I'm not sure if this breaks something else, still new to Hugo.

^ my fix wasn't a good one. There is definitely some combination of things that results in hugo producing non-deterministic results.

^ my fix wasn't a good one. There is definitely some combination of things that results in hugo producing non-deterministic results.

I was able to get something to work by doing as @wildhaber  recommended above and copying the config.toml file.

@wiroy I've had the same issue described above and solved it by copying the whole content of the exampleSite folder into the site project folder. The exampleSite folder contains all the content files that the whole thing can not run without. It is not just the config.toml.

@slavkodd can you give more information about how you do


Reset song statistics

primarily for development, but also could be used in production.

closed by pull request #253


GSE52583 High throughput quantitative whole transcriptome analysis of distal mouse lung epithelial cells from various developmental stages (E14.5, E16.5, E18.5 and adult)

Primary Wrangler:
Marion
Secondary Wrangler:
TBD

Associated files:
Google Drive: Folder
s3 bucket: TBC
Geo page:
Paper:
Key Events

[x] Assign the Primary Wrangler
[ ] Fill spreadsheet (to a sufficient standard to submit dataset)
[ ] Get CellType annotation (To a sufficient standard to submit to SCEA)
[ ] Upload data (to a sufficient standard to submit dataset)
[ ] Curate metadata spreadsheet with ontologies
[ ] Upload sheet to validate metadata (most likely in staging)
[ ] Check linking
[ ] Validate data files
[ ] Ask the Secondary Wrangler for an end-to-end review of the project. Ask the Expertise Wrangler to review specific tabs if needed
[ ] Get final approval of submission from SCEA
[ ] Submit dataset to Production?

Please track the below as well as the key events:

Track date first spreadsheet received and final spreadsheet sent by editing ticket to include
date next to event.
Track spreadsheet iterations by placing asterisks next to receive spreadsheet event.
Track any metadata issues/tickets made for dataset with a bulleted list of links under
received spreadsheet event. Links should be to the ticket in the metadata repo.

This is copied from https://github.com/HumanCellAtlas/hca-data-wrangling/issues/447
It is confirmed that SCEA can accept SMARTER C1 data

@lauraclarke From what I remember, we had a discussion about this dataset between the wranglers, and we decided to not move forward with wrangling this dataset for HCA. We agreed it was unsuitable for the HCA, due to the samples being obtained from genetically-modified mice. Also, the organ type is the Lung, for which (I believe) primary human tissue is not so challenging to get hold of that experimental designs involving mouse samples are necessary. We didn't have a stringent way of determining dataset suitability at this point, so this particular dataset made it in to the ZenHub board and then from what I remember @mshadbolt didn't continue with it due to unsuitability. Does this sound accurate to you, @mshadbolt, I may have remembered incorrectly ? If it is suitable for SCEA (I will ask Anja when we meet with her next week) then I'll move this ticket to the SCEA Zenhub column, and if not, I will close this ticket.

i think it is best to close it, we can reopen it in future if we decide something different.


Merge helm-update-organization-reporting-service-1.0.1-SNAPSHOT.d2e00e8 into main

Created by Github action in refs/heads/CNDIT-1511-initial-repo-commit

Closing this PR. This was opened automatically as part of testing.


Relative parent paths crash FSWatch

./reloaded-vibes --watch=../ --webserver=<IP_ADDRESS>:3002 --htdocs=test
core.exception.AssertError@../../.dub/packages/fswatch-0.4.0/fswatch/source/fswatch.d(307): inotify_add_watch returned invalid watch descriptor. Error code 28
----------------
??:? _d_assert_msg
../../.dub/packages/fswatch-0.4.0/fswatch/source/fswatch.d:308 void fswatch.FileWatch.addWatch(immutable(char)[])
../../.dub/packages/fswatch-0.4.0/fswatch/source/fswatch.d:331 fswatch.FileChangeEvent[] fswatch.FileWatch.getEvents()
../../.dub/packages/fswatch-0.4.0/fswatch/source/fswatch.d:288 ref fswatch.FileWatch fswatch.FileWatch.__ctor(immutable(char)[], bool, bool)
source/reloadedvibes/watcher.d:26 reloadedvibes.watcher.Watcher reloadedvibes.watcher.Watcher.__ctor(immutable(char)[][])
source/reloadedvibes/app.d:101 _Dmain

Seems to be related to the directory that ../ resolved in this case.

errno -l | grep 28
ENOSPC 28 No space left on device

Fix: https://github.com/guard/listen/wiki/Increasing-the-amount-of-inotify-watchers
Note: https://github.com/WebFreak001/FSWatch/issues/20

Why did I keep this open anyway?


Revert latest changes, bump to v0.6.1, deprecate this fork

FYI @aginzberg

For context, reverting because some emojis weren't being rendered properly:

Pushed to https://www.npmjs.com/package/emoji-mart-lite/v/0.6.1.


'No data' messages is displayed when all rows are deleted with scrollV: true option

I'm submitting a ...  (check one with "x")
[ x] bug report => search github for a similar issue or PR before submitting
[ ] feature request
[ ] support request => Please do not submit support request here

Current behavior
'No data' messages is displayed when all rows are deleted with scrollV: true option
Expected behavior

Reproduction of the problem
https://plnkr.co/edit/JM7bYwBx1EO2Gkbdseb7?p=preview
Click on 'Remove All' button
What is the motivation / use case for changing the behavior?

Please tell us about your environment:

Table version: 0.7.x

Angular version: 2.0.x

Browser: [all | Chrome XX | Firefox XX | IE XX | Safari XX | Mobile Chrome XX | Android X.X Web Browser | iOS XX Safari | iOS XX UIWebView | iOS XX WKWebView ]

Language: [all | TypeScript X.X | ES6/7 | ES5]

Is there a typo in the bug? Should it be " 'No data' message is NOT displayed when all rows are deleted"?
If that is the case, I can reproduce it also and it seems the issue is caused by the state.service 'get indexes()' method. In case you have scrollbarV enabled, first =0 and last = 1 even if the rows list is empty.


Make code field final

The code field in the ValidationErrorCode enum was public but not final. This could lead to a user accidentally changing the value of this field.

Thanks!


adorners zindex

plz how i can control the zindex of the adorners, placeholder

I don't understand the question, adorners are drawn in the adorner layer so they will be above anything else. Do you mean z-index of adorners relative to other adorners?

yes i mean how i can modify the z-index of adorners


save downloaded arff file as artifact

Codecov Report

Merging #8 (00bb922) into dev (14c7da5) will increase coverage by 3.18%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##              dev       #8      +/-   ##
==========================================
+ Coverage   31.96%   35.15%   +3.18%
==========================================
  Files           1        1
  Lines         122      128       +6
==========================================
+ Hits           39       45       +6
  Misses         83       83

Impacted Files
Coverage Δ

src/data.jl
35.15% <100.00%> (+3.18%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 14c7da5...00bb922. Read the comment docs.

I think this is ready to be merged, although the compatibility with v1.0 is a bit ugly...


Link for downloading the model is unavailable

Hi,
The link for download :  https://bethgelab.org/media/uploads/pytorch_models/vgg_conv.pth is currently unavailable. In fact, I think the whole webpage http://bethgelab.org/ itself is unavailable.
Could you kindly solve the issue, or is there another way to download it?
Thanks!

Hi @mesahwi, this is the same file: https://github.com/qiuxiaqing/vgg

Hi! I am executing your great code in Colab. I have the same issue with missing VGG path.
I have replace the original link with the above link , but the file download in the link is unusually small (132 KB):
mkdir: cannot create directory ‘Models’: File exists
--2022-05-17 07:03:59--  http://-/
Resolving - (-)... failed: Name or service not known.
wget: unable to resolve host address ‘-’
--2022-05-17 07:03:59--  https://github.com/qiuxiaqing/vgg
Resolving github.com (github.com)... <IP_ADDRESS>
Connecting to github.com (github.com)|<IP_ADDRESS>|:443... connected.
HTTP request sent, awaiting response... 200 OK
Length: unspecified [text/html]
Saving to: ‘vgg’
vgg                     [ <=>                ] 131.76K  --.-KB/s    in 0.04s
2022-05-17 07:03:59 (3.55 MB/s) - ‘vgg’ saved [134921]
FINISHED --2022-05-17 07:03:59--
Total wall clock time: 0.3s
Downloaded: 1 files, 132K in 0.04s (3.55 MB/s)
Could you kindly help me with this issue?
Thanks!

Hi, I have uploaded an archived copy here:
https://huggingface.co/fdan/neural_style_transfer_vgg/resolve/main/vgg_conv.pth


CosmosClient  Raise "Status code: 404" exception when create database

azure.cosmos.CosmosClient:
4.3.1:
centos 7:
Python 3.10.6:

Describe the bug
A clear and concise description of what the bug is.
always raise "Status code: 404" exception
it's weird!!!
To Reproduce
Steps to reproduce the behavior:
client = CosmosClient("https://mongodb-tiger-esaosp.mongo.cosmos.azure.com:443/",credential=COSMOS_ACCOUNT_KEY,consistency_level='Session')
   #cosmos_db = client.get_database_client(DATABASENAME)
   #db_offer = cosmos_db.read_offer()
   database_name = "testDatabase"
   try:
           database = client.create_database(id=database_name)
   except exceptions.CosmosResourceExistsError:
           database = client.get_database_client(database=database_name)

Expected behavior
A clear and concise description of what you expected to happen.
Create the database successfully
Screenshots
If applicable, add screenshots to help explain your problem.

Additional context
Add any other context about the problem here.

Hi @tengfei86 , thank you for the feedback. We will investigate and get back to you asap.

@simorenoh
i think there should me some misunderstandings.
i want to use cosmos client not just to create database, also i want to get the RU of exist database.

@tengfei86 from the information you shared in your image, you are using an account endpoint finishing in mongo.cosmos.azure.com - this is a MongoDB account and not an SQL API account, and as such cannot be used with our cosmos client.
If you'd like to use an SQL API account, here is a link showing how to get started: https://learn.microsoft.com/en-us/azure/cosmos-db/nosql/how-to-python-get-started?tabs=env-virtual%2Cazure-cli%2Cwindows
I am not a Mongo developer, and as such cannot help you out if you are trying to use Mongo. Please open another issue with Mongo in the title if you'd like to get help from a developer who can help you there. Thanks!

Thank you ,this is very helpful for me


While trying to run compiler unit tests, got "java.lang.NoClassDefFoundError: Could not initialize class com.redhat.ceylon.compiler.java.test.CompilerTests"

[@lukehutch] I followed the instructions in ceylon-compiler/README.eclipse exactly (I think), but I get the following for most of the unit tests, with the exception of TopLevelToolTests, which succeed. Any idea what went wrong?
java.lang.NoClassDefFoundError: Could not initialize class com.redhat.ceylon.compiler.java.test.CompilerTests
at sun.reflect.NativeConstructorAccessorImpl.newInstance0(Native Method)
at sun.reflect.NativeConstructorAccessorImpl.newInstance(NativeConstructorAccessorImpl.java:62)
at sun.reflect.DelegatingConstructorAccessorImpl.newInstance(DelegatingConstructorAccessorImpl.java:45)
at java.lang.reflect.Constructor.newInstance(Constructor.java:408)
at org.junit.runners.BlockJUnit4ClassRunner.createTest(BlockJUnit4ClassRunner.java:195)
at org.junit.runners.BlockJUnit4ClassRunner$1.runReflectiveCall(BlockJUnit4ClassRunner.java:244)
at org.junit.internal.runners.model.ReflectiveCallable.run(ReflectiveCallable.java:12)
at org.junit.runners.BlockJUnit4ClassRunner.methodBlock(BlockJUnit4ClassRunner.java:241)
at org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:70)
at org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:50)
at org.junit.runners.ParentRunner$3.run(ParentRunner.java:238)
at org.junit.runners.ParentRunner$1.schedule(ParentRunner.java:63)
at org.junit.runners.ParentRunner.runChildren(ParentRunner.java:236)
at org.junit.runners.ParentRunner.access$000(ParentRunner.java:53)
at org.junit.runners.ParentRunner$2.evaluate(ParentRunner.java:229)
at org.junit.runners.ParentRunner.run(ParentRunner.java:309)
at org.junit.runners.Suite.runChild(Suite.java:127)
at org.junit.runners.Suite.runChild(Suite.java:26)
at org.junit.runners.ParentRunner$3.run(ParentRunner.java:238)
at org.junit.runners.ParentRunner$1.schedule(ParentRunner.java:63)
at org.junit.runners.ParentRunner.runChildren(ParentRunner.java:236)
at org.junit.runners.ParentRunner.access$000(ParentRunner.java:53)
at org.junit.runners.ParentRunner$2.evaluate(ParentRunner.java:229)
at org.junit.runners.ParentRunner.run(ParentRunner.java:309)
at org.eclipse.jdt.internal.junit4.runner.JUnit4TestReference.run(JUnit4TestReference.java:50)
at org.eclipse.jdt.internal.junit.runner.TestExecution.run(TestExecution.java:38)
at org.eclipse.jdt.internal.junit.runner.RemoteTestRunner.runTests(RemoteTestRunner.java:459)
at org.eclipse.jdt.internal.junit.runner.RemoteTestRunner.runTests(RemoteTestRunner.java:675)
at org.eclipse.jdt.internal.junit.runner.RemoteTestRunner.run(RemoteTestRunner.java:382)
at org.eclipse.jdt.internal.junit.runner.RemoteTestRunner.main(RemoteTestRunner.java:192)
[Migrated from ceylon/ceylon-compiler#2431]

Sorry for the late answer @lukehutch. We have modified our build layout quite a lot. Could you try with the new layout and project root?  If that's still the case with the new project layout, could you give us the output of the problems view?

Hi Stéphane, I gave this another shot. I'm following the instructions at https://github.com/ceylon/ceylon/blob/master/dist/README.md#building-the-distribution, and got as far as ant clean publish, but got:
BUILD FAILED
Target "publish" does not exist in the project "ceylon".

I'll dig deeper, I'm sure it's easy to fix, but figured I should let you know the build instructions are not in sync with the repo for this step.

I did git clone https://github.com/ceylon/ceylon.git ; cd ceylon ; ant clean dist and then tried following the instructions at https://github.com/ceylon/ceylon-compiler/blob/master/README.eclipse.
I can't run the tests currently, because I get the following build errors:
Description	Resource	Path	Location	Type
Project 'ceylon-compiler' is missing required library: '/ceylon/lib/ant-1.8.2.jar'	ceylon-compiler		Build path	Build Path Problem
Project 'ceylon-compiler' is missing required library: '/ceylon/lib/hamcrest-core-1.3.0.v201303031735.jar'	ceylon-compiler		Build path	Build Path Problem
Project 'ceylon-compiler' is missing required library: '/ceylon/lib/junit-4.11.0.jar'	ceylon-compiler		Build path	Build Path Problem
Project 'ceylon-js' is missing required library: '/ceylon/lib/ant-1.8.2.jar'	ceylon-js		Build path	Build Path Problem
Project 'ceylon-js' is missing required library: '/ceylon/lib/antlr-3.4-complete.jar'	ceylon-js		Build path	Build Path Problem
Project 'ceylon-runtime' is missing required library: '/ceylon/lib/shrinkwrap-api-1.0.0-cr-1.jar'	ceylon-runtime		Build path	Build Path Problem
Project 'ceylon-runtime' is missing required library: '/ceylon/lib/shrinkwrap-impl-base-1.0.0-cr-1.jar'	ceylon-runtime		Build path	Build Path Problem
Project 'ceylon-runtime' is missing required library: '/ceylon/lib/shrinkwrap-spi-1.0.0-cr-1.jar'	ceylon-runtime		Build path	Build Path Problem
Project 'ceylon-typechecker' is missing required library: '/ceylon/lib/antlr-3.4-complete.jar'	ceylon-typechecker		Build path	Build Path Problem

Luke, the "ceylon--*" projects aren't used anymore, please follow the
instructions in https://github.com/ceylon/ceylon or on the website
http://www.ceylon-lang.org/code/contribute/
-Tako
On 17 January 2016 at 07:51, Luke Hutchison<EMAIL_ADDRESS>wrote:

I did git clone https://github.com/ceylon/ceylon.git ; cd ceylon ; ant
clean dist and then tried following the instructions at
https://github.com/ceylon/ceylon-compiler/blob/master/README.eclipse.
I can't run the tests currently, because I get the following build errors:
Description Resource    Path    Location    Type
Project 'ceylon-compiler' is missing required library: '/ceylon/lib/ant-1.8.2.jar'  ceylon-compiler     Build path  Build Path Problem
Project 'ceylon-compiler' is missing required library: '/ceylon/lib/hamcrest-core-1.3.0.v201303031735.jar'  ceylon-compiler     Build path  Build Path Problem
Project 'ceylon-compiler' is missing required library: '/ceylon/lib/junit-4.11.0.jar'   ceylon-compiler     Build path  Build Path Problem
Project 'ceylon-js' is missing required library: '/ceylon/lib/ant-1.8.2.jar'    ceylon-js       Build path  Build Path Problem
Project 'ceylon-js' is missing required library: '/ceylon/lib/antlr-3.4-complete.jar'   ceylon-js       Build path  Build Path Problem
Project 'ceylon-runtime' is missing required library: '/ceylon/lib/shrinkwrap-api-1.0.0-cr-1.jar'   ceylon-runtime      Build path  Build Path Problem
Project 'ceylon-runtime' is missing required library: '/ceylon/lib/shrinkwrap-impl-base-1.0.0-cr-1.jar' ceylon-runtime      Build path  Build Path Problem
Project 'ceylon-runtime' is missing required library: '/ceylon/lib/shrinkwrap-spi-1.0.0-cr-1.jar'   ceylon-runtime      Build path  Build Path Problem
Project 'ceylon-typechecker' is missing required library: '/ceylon/lib/antlr-3.4-complete.jar'  ceylon-typechecker      Build path  Build Path Problem
—
Reply to this email directly or view it on GitHub
https://github.com/ceylon/ceylon/issues/2431#issuecomment-172296224.

That's exactly what I did: the second link you posted above says: Import all projects you find in the ceylon folder into Eclipse (see README.eclipse in ceylon-compiler)
"All projects you find in the ceylon folder" is ambiguous. If you just include that folder, there is only one project named "ceylon". But there are several sub-folders that are themselves Eclipse projects. They can only be imported one at a time, unless you check "Search for nested projects", then you see them all (as well as a bunch of templates that are also Eclipse projects, e.g. in ceylon/dist/templates, and also in ceylon/dist/dist/templates -- incidentally, that looks like an accidental duplication in the git repo).

PS there are all sorts of build instructions scattered all over the place, between ceylon-lang.org and the various git projects. It would be nice to have one canonical set of instructions that is kept up to date with the source.

Well the only build instructions you should be following are the ones on the website ;)
Or the ones in the Ceylon repo once you've cloned it.
I've at least changed the READMEs in all the deprecated projects to really make it obvious you shouldn't be using them.

You should probably change the wording too to remove "Import all the projects you find in the ceylon folder", and remove the Eclipse .project files from the sub-directories. If "Search for nested projects" is selected (and it's a persistent setting, so if you selected it before it will come up by default), then you get a bunch of sub-projects listed during the import step. If you select them all, you get:
Some projects cannot be imported because they already exist in the workspace or their project description file is corrupted
  Resource<EMAIL_ADDRESS>already exists.
  Resource<EMAIL_ADDRESS>already exists.
  Resource<EMAIL_ADDRESS>already exists.
  Resource<EMAIL_ADDRESS>already exists.
  Resource<EMAIL_ADDRESS>already exists.

(there are six sub-projects of this name listed in the import dialog.)

Also, if I import the single project "ceylon", and then continue to follow the instructions in README.eclipse, I can't run the JUnit tests: nothing comes up when clicking "Search..." next to "Test class", so the "Run" button is never enabled.

OK my bad, sorry, I thought we kept those README up-to-date, but it seems the website instructions are the way to go. @quintesse could you remove those README entirely or make them empty except for pointing to the website instructions?
@lukehutch do you have better luck with the website instructions?

@FroMage was already done : https://github.com/ceylon/ceylon/issues/2431#issuecomment-172303444 ;)

Well, I saw no comment linked to this issue :(

Well that's because the changes didn't really seem to have anything to do with the issue.
Anyway. I also added a new, fixed, README.eclipse to the Ceylon project and fixed the link on the website that pointed to it.

Great, thanks!

@quintesse: I tried following the new README.eclipse instructions, and they still seem not quite right:

In addition to deselecting projects that start with "@" and "ceylon-dist-", I think the root "ceylon" project needs to be deselected too, because the other projects are nested within it. (The root "ceylon" project doesn't even set up the classpath properly, so you can't browse the sub-directories as Java source trees.)
What are the projects prefixed with<EMAIL_ADDRESS>The fact that the names are prefixed with that seems to indicate a typo in the project files for those projects?
There is still a duplication between projects in dist/ and in dist/dist/ . I think someone accidentally made a copy of dist inside itself at some point. (I'd create a separate bug report for that, but it's minor, and I already have your attention :-) )

Is there any simpler way of setting this up that doesn't require the de-selecting of a bunch of sub-projects? That seems a bit weird. I think a better solution would be to set up a single root project, inside ceylon/ceylon, and add the src/ directories of each of the sub-projects as classpath entries in the root project. Then in the instructions, tell people to disable "Search for nested projects", or remove the sub-projects' Eclipse .project files entirely. Sub-projects that need standalone Eclipse .project files, e.g. the demos in dist/ , should maybe not be a sub-directory of ceylon/ceylon, but instead in their own repo.

nope, the root project is there so you can access the files that are located there. Otherwise it would be difficult for people to open/edit things like the build.xml file.

They are templates

Nope that duplication is correct, the dist/dist folder is generated by the build

Is there any simpler way

Right now there isn't. And I don't think it's very complex to be honest. Things can certainly be improved. But all in time :)

I manually combined all the .project and .classpath files into a single
file for the root ceylon project, just as an exercise. Is this useful, or
do you want to keep them separate?
N.B. tons of unit tests are broken, is this expected?
I keep coming across things that don't work out of the box, but go ahead
and close this bug if you would like, my ongoing comments are no longer
relevant to the original bug!
On Mon, Jan 18, 2016 at 4:19 AM, Tako Schotanus<EMAIL_ADDRESS>wrote:

nope, the root project is there so you can access the files that are
located there. Otherwise it would be difficult for people to open/edit
things like the build.xml file.
2.
They are templates
3.
Nope that duplication is correct, the dist/dist folder is generated by
the build
Is there any simpler way
Right now there isn't. And I don't think it's very complex to be
honest. Things can certainly be improved. But all in time :)
—
Reply to this email directly or view it on GitHub
https://github.com/ceylon/ceylon/issues/2431#issuecomment-172513371.

They should remain separate projects because that forces us to make module dependencies explicit and not add dependencies by accident.
And no, unit tests are supposed to pass. Which tests are you running?

Is this useful, or do you want to keep them separate?

It's useful and is what I had done before when switching from several projects to a single one. But it was decided that people wanted stricter separation between the projects. (It's too easy to start using a class from project A in project B even if project B doesn't actually depend on project A. In the current setup that will result in a compile error)

N.B. tons of unit tests are broken, is this expected?

I think this was of some missing information in the README.eclipse. Take another look, I just added a new option "ii." in the beginning of the file. I guess that's what you were seeing.
You should be getting only a handful of errors+failures.
Btw I really appreciate you sharing all these problems with us. After our recent switch to a single repository it's obvious we should have been more careful in going over the docs again with a completely clean environment.

You're welcome, I'm a big fan of the ideas behind Ceylon, and I would love to see it really succeed!
It's possible I screwed something up with all my previous tinkering, so I just blew away my install and started from scratch, following the instructions (including the "ii" step to add the -ea switch).
However, with a fresh install, now I get:
Description	Resource	Path	Location	Type
Project 'ceylon-compiler' is missing required library: '/ceylon.language/ide-dist/ceylon.language-1.2.1.car'	ceylon-compiler		Build path	Build Path Problem
The project cannot be built until build path errors are resolved	ceylon-compiler		Unknown	Java Problem
The project was not built since it depends on ceylon-typechecker, which has build path errors	ceylon-js		Unknown	Java Problem
The project was not built since it depends on ceylon.language, which has build path errors	ceylon-runtime		Unknown	Java Problem
Project 'ceylon-tool-provider' is missing required library: '/ceylon.language/ide-dist/ceylon.language-1.2.1.car'	ceylon-tool-provider		Build path	Build Path Problem
The project cannot be built until build path errors are resolved	ceylon-tool-provider		Unknown	Java Problem
Project 'ceylon-typechecker' is missing required source folder: 'gensrc'	ceylon-typechecker		Build path	Build Path Problem
The project cannot be built until build path errors are resolved	ceylon-typechecker		Unknown	Java Problem
Project 'ceylon.language' is missing required library: 'ide-dist/ceylon.language-1.2.1.car'	ceylon.language		Build path	Build Path Problem
The project cannot be built until build path errors are resolved	ceylon.language		Unknown	Java Problem

@lukehutch did you do a build first? You must have done an Ant build first according to the instructions in the README.md file before you can start with the Eclipse stuff.
(Well it's not 100% necessary, if you do the build now and refresh your Eclipse projects things should be fine)

Yes, to be clear, this is due to parts of Ceylon being written in Java that need to access the Ceylon language module, which is written in Ceylon and not every IDE understands Ceylon so we need to compile that one first, so it can be loaded from its jar file by the IDE.

@quintesse: oops, you're right, I forgot the Ant build step this time. That does fix the errors in my previous comment, sorry about that. (I had to remove the projects and re-import them after the build though..)
It was the compiler tests I was trying to run. The tests do appear to mostly be passing now, so I'm not sure what was broken before. A few tests are failing still though:

One set of tests is complaining about ANT_HOME not being set, so maybe README.eclipse also needs to describe how to install and set up Ant support?
These tests fail:

java.lang.AssertionError: Compilation failed
ERROR: frontend: 1: package not found in imported modules: 'org.antlr.runtime' (add module import to module descriptor of 'com.redhat.ceylon.compiler.java.test.issues.bug14xx.bug1465')
ERROR: frontend: 4: type declaration does not exist: 'Token' (did you mean 'Nothing'?)
NOTE: backend: -1: Created module com.redhat.ceylon.compiler.java.test.issues.bug14xx.bug1465/1
	at org.junit.Assert.fail(Assert.java:88)
	at com.redhat.ceylon.compiler.java.test.CompilerTests.assertCompilesOk(CompilerTests.java:542)
	at com.redhat.ceylon.compiler.java.test.CompilerTests.compile(CompilerTests.java:594)
	at com.redhat.ceylon.compiler.java.test.issues.IssuesTests_1000_1499.testBug1465(IssuesTests_1000_1499.java:774)

java.lang.AssertionError: Ceylon script execution failed
	at org.junit.Assert.fail(Assert.java:88)
	at com.redhat.ceylon.compiler.java.test.misc.MiscTests.launchCeylon(MiscTests.java:516)
	at com.redhat.ceylon.compiler.java.test.misc.MiscTests.testLaunchDistCeylon(MiscTests.java:463)
	at com.redhat.ceylon.compiler.java.test.misc.MiscTests.testDistSampleWithModule(MiscTests.java:505)

The tests are still running, will update if I see any more breakage.

so I'm not sure what was broken before

The missing Eclipse setting that I added to the README caused all those errors

maybe README.eclipse also needs to describe how to install and set up Ant support?

The README.md points you to the Ant home page and tells you to make sure it works. I don't think it would be a good idea to duplicate what they have. It's bound to be more extensive and correct. (If we some reason people tend to forget to set the ANT_HOME even after reading those docs we could perhaps add some reminder to check, but so far you're the first)

These tests fail:

Well like I said, you can expect a handful of errors

I did set up Ant already, following the instructions in README.md. For some reason, the ANT_HOME variable is not visible to the JUnit test. I'm not sure why, because I just tried putting <echo>${ant.home}</echo> into a build rule in build.xml, and ran the equivalent of ant dist in Eclipse, and it does show that ANT_HOME is set, at least during an actual Ant build.
Anyway, things look good now, other than the handful of failing tests -- thanks for your responsiveness!


Celotool --helmdryrun improvements

Description
This PR includes a refactoring around the option celotool option --helmdryrun. In particular the PR includes:

Disable the --helmdryrun for all the commands where it does not fit or include operations outside the dry-run: for any destroy operation, and for any command in packages blockchain-api, contracts, forno (terraform stuff), komenci, notification-service, verify-contracts, vm-testnet, all,
Skipped some logic from run and execute helm diff with that package: for blockscout, celostats, fullnodes (forno nodes), tracer-tool, leaderboard, load-test, voting-bot
Refactored to use the generic helm functions (and thus being able to run with --heldryrun if allowed) the packages: attestation-bot, attestation-service, eksportisto, leaderboard, tracer-tool, transaction-metric-exporter,

Other changes
Some refactor in the celotool package libraries to use the general patters from the other packages.
Tested
Some of the commands. Need more testing yet.
Related issues

Fixes celo-org/celo-labs#789

Backwards compatibility
It should not impact.

One nit: There's a minor lint issue somewhere about an await that's blocking the merge.

I didn't notice the lint failure, thanks.  I did notice that await in the code, and it's true that it's unnecessary, but the await does have an effect (e.g. if the promise fails the stacktrace will show the exception coming from that function rather than its caller).  So I guess what I'm saying is I'm not a fan of that lint rule.  But so be it.


Implement Multi image picker view in image picker plugin

There is currently another library for multi image picker:
https://github.com/Sh1d0w/multi_image_picker

We could improve the official flutter image picker library with the same mosaic view which is a lot better on Android that the files view.
Is this on the roadmap?

There's already a similar open proposal describing this issue, https://github.com/flutter/flutter/issues/16054
Closing this as duplicate.


✨ Support Umami Analytics

support umami
https://github.com/nunocoracao/blowfish/issues/933

Documentation missing, still good stuff, merging. Created https://github.com/nunocoracao/blowfish/issues/1373 to track adding docs - can you help @Weaxs ?

This is great, thanks @Weaxs and @nunocoracao.