Allow exclusion of files / folders from being watched by @angular-devkit/build-angular:application (ESBuild + Vite)

Command
serve
Description
According to https://angular.io/guide/esbuild it says:
The usage of Vite, much like the Webpack-based development server, is encapsulated within the Angular CLI dev-server builder and currently cannot be directly configured.
Webpack previously allowed a customWebpackConfig and therefore it was possible to exclude certain files and folders from the "watch" mechanism. With Vite this option is completely gone. In bigger setups with lots of libraries and Cypress/Jest tests residing in the folder of each library, the app gets rebuilt every time an irrelevant file (i.e. my-test.e2e.spec.ts, my-test.spec.ts or my-test.cy.ts) was changed.
Especially creating and editing Cypress tests becomes a real an absolute struggle because you have to wait for the build to be completed before you can run a test properly.
What I also find strange is this line: https://github.com/angular/angular-cli/blob/main/packages/angular_devkit/build_angular/src/builders/dev-server/vite-server.ts#L483
So where is the actual "watching" done, if not by Vite itself? Haven't found other hints..
Describe the solution you'd like
Ideas

Provide a bundler-agnostic solution for excluding files to watch :D
Use the Vite watcher internally and expose the configuration ( see https://github.com/vitejs/vite/blob/main/packages/vite/src/node/watch.ts#L18 )
Give me a hint to where the code for the watcher lies, so I can find a workaround to make ESBuild + Vite viable for us

Describe alternatives you've considered
No response

The watching is indeed not done by Vite, but this is done as part of the application builder implementation, a rebuild only happens when a file that is referenced in the application is modified.
Can you provide the output of ng version?

Thanks, sure:
Angular CLI: 17.0.0
Node: 18.14.0
Package Manager: npm 9.3.1
OS: win32 x64

Angular: 17.0.2
... animations, common, compiler, compiler-cli, core, elements
... forms, language-service, platform-browser
... platform-browser-dynamic, router

Package                          Version
----------------------------------------------------------
@angular-devkit/architect        0.1700.0
@angular-devkit/build-angular    17.0.0
@angular-devkit/core             17.0.0
@angular-devkit/schematics       17.0.0
@angular-devkit/schematics-cli   16.0.4
@angular/cdk                     17.0.0
@angular/cli                     17.0.0
@angular/material                16.2.12 <--- i'm aware of this one :D 🙏
@schematics/angular              17.0.0
ng-packagr                       17.0.0
rxjs                             7.8.1
typescript                       5.2.2
zone.js                          0.14.2

To give you a clearer view:
We have 170+ buildable libraries and each library has a folder "src" with the actual code and a folder "cypress" which contains e2e-tests, pageobjects, and so on. Then we have Jest- and Cypress-Component-Tests that are within the "src" folder, right besides each specific component or util.
Everytime I change a pageobject, e2e-test, jest-test or one of the Cypress-tests generates an output within that library (i.e. "my-lib/reports"), a rebuild was triggered with webpack (and also with vite).

In the past, we didn't offer support for excluding files from the watcher, and it's not a feature we intend to introduce. However, it does seems there might be a bug in ng-packagr causing a library rebuild when a non-compilation file like my-lib/reports is modified, resulting in an unnecessary application build.
If this is the case, I recommend filing an issue on https://github.com/ng-packagr/ng-packagr/.

I'm trying to figure out how the files are marked as files to consider in the build with ESBuild.
In build-action.js, I added some code to log the files that triggered a change:
const packageWatchFiles = [
            // manifest can affect module resolution
            'package.json',
            // npm lock file
            'package-lock.json',
            // pnpm lock file
            'pnpm-lock.yaml',
            // yarn lock file including Yarn PnP manifest files (https://yarnpkg.com/advanced/pnp-spec/)
            'yarn.lock',
            '.pnp.cjs',
            '.pnp.data.json',
        ];
        watcher.add(packageWatchFiles.map((file) => node_path_1.default.join(workspaceRoot, file)));
>>>>>
        result.watchFiles.forEach((f) => {
            if(/.*\.spec.ts/.test(f)) {
                console.log(f);
            }
        });
>>>>>

I see that spec-Files and totally unrelated files show up here. Using --verbose on the serve command I also see that unrelated HTML-files trigger a rebuild (they were stored within a libs-folder there other Angular libs reside).
The search led me to https://github.com/angular/angular-cli/blob/main/packages/angular_devkit/build_angular/src/tools/esbuild/bundler-execution-result.ts#L91 and codeBundleCache here https://github.com/angular/angular-cli/blob/main/packages/angular_devkit/build_angular/src/builders/application/execute-build.ts#L69
But then it gets blurry. I see the reference to the evn variable NG_BUILD_WATCH_ROOT, but I didn't set this variable.
From the side of ESBuild I didn't find out anything.. I see that you can give ESBuild entrypoints, but that's it. I don't see how other files are included in the watched files..

Likely this is caused by some misconfiguration in your project:

If you are using tailwinds css make sure that the content glob is not picking up the spec files.
In your tsconfig file make sure that you don't include the spec files.

We have TSConfigs that necessarily reference spec files and Cypress tests. The setup is done with NX:
tsconfig.json in the root folder of the library:
{
  "extends": "../../../../tsconfig.base.json",
  "include": [],
  "files": [],
  "references": [
    {
      "path": "./tsconfig.lib.json"
    },
    {
      "path": "./tsconfig.spec.json"
    },
    {
      "path": "./cypress/tsconfig.json"
    }
  ]
}

and then tsconfig.spec.json and cypress/tsconfig.json include Jest- and Cypress-Tests but have different settings for the types, (for cypress/tsconfig.json ->  "types": ["cypress", "node", "cypress-axe"],).
When I running nx/ng serve it seems that only the main "tsconfig.app.json" is respected anyways (I saw this because in one library there was a problem with an import using require, so I switched it to CommonJS (because there seem to be no alternatives for https://github.com/nx-js/compiler-util -> I fixed it with import { compileCode, expose } from '@nx-js/compiler-util/dist/cjs.es6.js';). When doing a build, it would respect the tsconfig.json of that very library and when running serve it would respect tsconfig.app.json. I had to add esModuleInterop to both configs.
So I don't understand how the TSConfigs would affect the file watcher and how I could check how it is affecting the watcher.
But thanks to your hints I found the culprit: The Tailwind configuration.
It not documented very well on their website and according to some older issues, it seems that exclusions are not possible:

https://github.com/tailwindlabs/tailwindcss/issues/8477
https://github.com/tailwindlabs/tailwindcss/issues/10544
https://github.com/tailwindlabs/tailwindcss/issues/8828

But NX, with its default setup, generates globPatterns that have some sort of exclusion: **/!(*.stories|*.spec).{ts,html}
Not I can extend this glob pattern and possibly create an MR for NX to extend these exclusions per default (to also match cypress.config.ts, my-util.test.ts, my-other-test.cy.ts).
As for now I'll ignore my huge ignore list for webpack and go on with the fixed Tailwind content globs and observe how the new watcher behaves with other files (as you see code-coverage output generated by Cypress was also a problem).
Last problem to solve now is using @media screens(xs) {..} or the old @screens xs {..} in SCSS-files with angular plugin-sass:

.twscreentest {
    background-color: red;
    font-size:40px;
    // @screen xs {
    //  background-color: blue;
    // }

    @media screen (sm)  {
        font-size:80px;
      }
  }

Previously we used @screen which still is supported (but not documented anymore) and it works just fine with the Webpack bundler. Maybe it works because of some very well hidden configuration in that setup.
In a new setup I tried it with Tailwind 3.0.2, 3.3.5 and 3.3.6 and none of these options work..
Possibly yet another misconfiguration.. :-(

Glad to hear that you managed to fix the watching issues. The sass error is expected and valid in this case and is being thrown by the Sass compiler.
echo ".twscreentest { @media screen (sm){ font-size:80px;}}" | npx sass --stdin
Error: expected "{".
  ╷
1 │ .twscreentest { @media screen (sm){ font-size:80px;}}
  │                               ^
  ╵
  - 1:31  root stylesheet

Is this a fundamental misunderstanding from my side? I thought I could use @screen within SCSS. But I guess I need to study https://tailwindcss.com/docs/using-with-preprocessors#nesting and see what should actually work and what shouldn't.
But still, it is very confusing because our setup works with Webpack and Tailwind (I don't know why it works) and it doesn't work with ESBuild. So something in the bundler must have changed too, since I didn't update Tailwind in my real project. Any ideas/hints other than to delete everything Tailwind-related and start from scratch? 😅

This should not work when when using SCSS with both webpack and esbuild based builder. This is because the Sass compiler runs before Tailwind and the latter is only invoked if the Sass compilation is successfully.
Example of the error with Webpack when using Angular CLI version 17
$ ng build
✔ Browser application bundle generation complete.

./src/styles.scss - Error: Module build failed (from ./node_modules/sass-loader/dist/cjs.js):
expected "{".
  ╷
6 │   @media screen (sm)  {
  │                 ^
  ╵
  src/styles.scss 6:17  root stylesheet

./src/styles.scss?ngGlobalStyle - Error: Module build failed (from ./node_modules/mini-css-extract-plugin/dist/loader.js):
HookWebpackError: Module build failed (from ./node_modules/sass-loader/dist/cjs.js):
expected "{".
  ╷
6 │   @media screen (sm)  {
  │                 ^
  ╵
  src/styles.scss 6:17  root stylesheet

The fact that it worked, was likely a bug in the Sass compiler that was fixed.

I've reproduced the issue successfully with the old, but still valid directive @screen (even if not documented). If this isn't supposed to work the ESBuild, then I wonder what the upgrade path (from @screen to @media screen (xy) would be. It seems like nothing is mentioned anywhere? 😅
See https://github.com/mirobo/nx-angular-tailwind/tree/main and (maybe you need to run npm install it with legacy peer deps). Then npm run start (it starts both variants).
Resize the window to see colors of the h1 with "TAILWIND SCREENS TEST" change (the variant with ESBuild won't work)
I see that both executors do something with postcss and autoprefixer internally (which are both added as dependencies in this test project), but only the Webpack executor seems to have a "sass-loader" webpack/configs/styles.ts while in esbuild..sass-language.ts and esbuild..stylesheet-plugin-factory.ts I didn't find it.
The styles.css produced by both bundlers is pretty much identical: https://github.com/mirobo/nx-angular-tailwind/tree/main/style-css-output

In the generated main.js I see that some processing was not done:
ESBuild

Webpack


Build docs in tests

This PR should make Travis build docs, failing if a change introduces an error or a warning.

This should fix issue #218.


Promise ponyfill

Feature request

What is the expected behavior?
I need some webpack internals to use a Promise ponyfill instead of the global Promise.
What is motivation or use case for adding/changing the behavior?
I'm bundling a web app that runs on 3rd party websites and I must not pollute their global namespace with polyfills.
How should this be implemented in your opinion?
No idea, but I guess Promise is the only thing that needs a polyfill for IE11.
Are you willing to work on this yourself?
yes

Duplicate #3531


add label to all CPO managed deployments in the HCP

What this PR does / why we need it:
In service to adding a Degraded condition to the HCP
https://issues.redhat.com/browse/HOSTEDCP-495
This will allow us to easily list and check the status of all CPO managed deployments in the HCP.
Which issue(s) this PR fixes (optional, use fixes #<issue_number>(, fixes #<issue_number>, ...) format, where issue_number might be a GitHub issue, or a Jira story:
Fixes #
Checklist

[ ] Subject and description added to both, commit and PR.
[ ] Relevant issues have been referenced.
[ ] This change includes docs.
[ ] This change includes unit tests.

/retest-required

/lgtm


TypeScript intellisense broken

VSCode Version: 1.36.1
OS Version: MacOS Mojave 10.14.6

Steps to Reproduce:

Open up a particular TypeScript project
Intellisense doesn't work

Does this issue occur when all extensions are disabled?: Yes
I tried the same project in VSCode Insiders with a clean install and no extensions as well. Tried different TypeScript versions as well.
This is the output:
[2019-08-02 12:55:15.862] [exthost] [error] [vscode.typescript-language-features] provider FAILED
[2019-08-02 12:55:15.862] [exthost] [error] Error: <main> TypeScript Server Error (3.5.2)
Debug Failure.
Error: Debug Failure.
    at Object.assertDefined (tsserver.js:2080:24)
    at getDefaultExportInfoWorker (tsserver.js:115542:80)
    at getDefaultLikeExportInfo (tsserver.js:115523:24)
    at tsserver.js:115320:35
    at forEachExternalModule (tsserver.js:115663:21)
    at getAllReExportingModules (tsserver.js:115315:13)
    at Object.getImportCompletionAction (tsserver.js:115301:31)
    at getCompletionEntryCodeActionsAndSourceDisplay (tsserver.js:99848:33)
    at Object.getCompletionEntryDetails (tsserver.js:99812:30)
    at Object.getCompletionEntryDetails (tsserver.js:122110:35)
    at tsserver.js:131177:57
    at Object.mapDefined (tsserver.js:670:30)
    at IOSession.Session.getCompletionEntryDetails (tsserver.js:131175:33)
    at Session.handlers.ts.createMapFromTemplate._a.(anonymous function) (tsserver.js:130106:61)
    at tsserver.js:131665:88
    at IOSession.Session.executeWithRequestId (tsserver.js:131656:28)
    at IOSession.Session.executeCommand (tsserver.js:131665:33)
    at IOSession.Session.onMessage (tsserver.js:131687:35)
    at Interface.<anonymous> (tsserver.js:132978:27)
    at Interface.emit (events.js:182:13)
    at Interface._onLine (readline.js:290:10)
    at Interface._normalWrite (readline.js:433:12)
    at Socket.ondata (readline.js:149:10)
    at Socket.emit (events.js:182:13)
    at addChunk (_stream_readable.js:283:12)
    at readableAddChunk (_stream_readable.js:264:11)
    at Socket.Readable.push (_stream_readable.js:219:10)
    at Pipe.onStreamRead [as onread] (internal/stream_base_commons.js:94:17)
	at Function.create (/Applications/Visual Studio Code.app/Contents/Resources/app/extensions/typescript-language-features/dist/extension.js:53:63436)
	at h.dispatchResponse (/Applications/Visual Studio Code.app/Contents/Resources/app/extensions/typescript-language-features/dist/extension.js:53:56618)
	at h.dispatchMessage (/Applications/Visual Studio Code.app/Contents/Resources/app/extensions/typescript-language-features/dist/extension.js:53:55516)
	at constructor._reader.onData.e (/Applications/Visual Studio Code.app/Contents/Resources/app/extensions/typescript-language-features/dist/extension.js:53:54992)
	at u.fire (/Applications/Visual Studio Code.app/Contents/Resources/app/out/vs/workbench/services/extensions/node/extensionHostProcess.js:48:468)
	at t.Reader.onLengthData (/Applications/Visual Studio Code.app/Contents/Resources/app/extensions/typescript-language-features/dist/extension.js:53:61656)
	at Socket.t.Reader.constructor.e.on.e (/Applications/Visual Studio Code.app/Contents/Resources/app/extensions/typescript-language-features/dist/extension.js:53:61304)
	at Socket.emit (events.js:182:13)
	at addChunk (_stream_readable.js:283:12)
	at readableAddChunk (_stream_readable.js:264:11)
	at Socket.Readable.push (_stream_readable.js:219:10)
	at Pipe.onStreamRead [as onread] (internal/stream_base_commons.js:94:17)

If I remove the node_modules folder Intellisense starts working again (for this particular project). I'm not sure on how to debug this further, any suggestions? It seems it crashes when it's parsing/loading some file in node_modules but I'm not sure.

In my case;

VS code Version: 1.36.1 (1.36.1)
OS Version: MacOS Mojave 10.14.6

Steps to Reproduce:

Open up a non-typescript project
clg does not autocomplete to console.log()

Output was like:
[renderer1] [error] <main> TypeScript Server Error (3.5.2)
This may be subject to another issue but after reading @johanbaath 's comment about removing node_modules; I did the same and removed node_modules in /Applications/Visual Studio Code.app/Contents/Resources/app/extensions/typescript-language-features and npm install again; problem solved.

Duplicate of https://github.com/microsoft/TypeScript/issues/31465 based on callstack


Move existing Kafka metrics to a JMX specific namespace

Problem
The Kafka metrics in the messaging semantic conventions are based on metrics as they are reported by the JMX reporter. Although the JMX reporter is the default reporter, different reporters can be configured.
In their current form, the definition of those metrics causes confusion, as they suggest being an authoritative definition of metrics as they are reported by Kafka. However, they look different from the metrics in the official Kafka documentation, and they are different from the OTLP metrics defined in KIP-714.
Based on feedback from @AndrewJSchofield, people involved in the Kafka project currently don't have an interest in defining and maintaining a definition of Kafka metrics as part of the OTel semantic conventions.
Desired solution
The semantic conventions should make it clear that the existing metrics are JMX specific, ideally in the metric name. This allows support for conventions for Kafka metrics that are sent via a different reporter.
Even more importantly, this avoids confusion, as it makes clear that the OTel semantic conventions are not the place that provides an authoritative definition of Kafka metrics.

The lack of mapping to semantic conventions doesn't mean this data is not useful.

I fully agree, .NET runtime metrics are a great example of this.
The conception that telemetry data needs to be covered by OTel semantic conventions in order to be useful leads to unwanted side effects:

Semantic conventions are written to comply with existing instrumentation, whereas it should be the other way round.
As a consequence of the point above, we end up with a bunch of experimental semantic conventions with no clearly defined ownership.

My take is that telemetry conventions referring to a specific component (e. g. Kafka broker, or .NET runtime) can be part of OTel semantic conventions, but can as well live apart of them. In any case, they should be maintained by people working on that specific component, and not by the wider community.

My take is that telemetry conventions referring to a specific component (e. g. Kafka broker, or .NET runtime) can be part of OTel semantic conventions, but can as well live apart of them. In any case, they should be maintained by people working on that specific component, and not by the wider community.

I agree as well. For me, what is a bit unclear is: If I specify such conventions outside OTel, should they follow the OTel guidelines? For ex, metrics names, instrument types and etc?
To me it makes sense that if such library/framework etc uses OTel components to record such data (tracer, meter) they must follow the OTel guidelines.

Discussed in the semantic conventions SIG meeting on September 18th.
There was an agreement to remove experimental Kafka metrics from the semantic conventions. If a definition or reference of those metric is needed, it should be provided by the documentation of the package that synthesizes those metrics. It seems this documentation is already available in the kafkametricsreceiver collector component.


ASCII Key Detector by Griffpatch

Using some of the scripts in this project for one I'm going to run in phosphorus. When I press a key, instead of detecting it correctly like when run in Scratch, it does an uppercase and lowercase. If I press the a key, with or without shift, it comes back with "Aa." I understand the scripts used were wrote for Scratch, and that's why it only works with that. The scripts go beyond just the normal <key (a) pressed?>, and that's the only reason it isn't working. I'm fine if you don't fix this, as it isn't really a problem, it's just a difference between the Scratch player and phosphorus. It would just help me in the program that I'm making.
Thanks for reading! Here are the links:
https://scratch.mit.edu/projects/19204741/
http://phosphorus.github.io/#19204741

Keypress sensing in Scratch works ONLY for lowercase letters.
In phosphorus works for lower and uppercase letter at the same time because of the<EMAIL_ADDRESS>(line 1409) implementation.
The easiest fix will be to return 0 when keyName.charCodeAt(0) is in range <65, 90>.
There is also another problem. Meta keys in Scratch are reported as 128. Phosphorous ignores meta keys ( keyDown handler , line 1009).


Assembly does not have a strong name

Error CS8002: Referenced assembly 'TRex.Metadata, Version=<IP_ADDRESS>, Culture=neutral, PublicKeyToken=null' does not have a strong name.

All our assemblies have strong names, which in turn requires that all libraries have strong names. I know I can compile TRex myself with a strong name, and I'm willing to do so, but am wondering if you'd be willing to distribute it with a strong name.
Thanks :-)

I'll do that in the pre-release "powerapps" branch.
It looks like it's possible against that branch for sure after all projects are signed and the public key is added to the friend assembly declarations in the TRex.Metadata.Attributes project.
I have a release planned for next week, so it's likely to incorporate that change.

Thanks @nihaue :-)

This is resolved in v2.0.1-alpha (available on nuget). You can see sample usage here.

Do you have any kind of roadmap for when the powerapps branch will be released (i.e. stable)? I'm trying it out now as we definitely need the dynamic extensions, but need to ease management's minds about using an alpha. Thanks for the great work :-)

Once the features hit the Logic App designer (instead of just Microsoft Flow) I will be removing "alpha" from the version number. It is unlikely that the code itself will change at that time, unless there is some sort of breaking change in the designer that requires it.


Name of CSRF token header

I'm currently working on the TCK tests for the CSRF protection and noticed something strange. The spec states:

MVC implementations are REQUIRED to support CSRF tokens [...] as HTTP headers.

Any other value than CsrfOptions.OFF will automatically inject a CSRF token as an HTTP header. The actual name of this header is implementation dependent.

Automatic validation is enabled by setting this property to CsrfOptions.IMPLICIT, in which case all
post requests must include either an HTTP header or a hidden field with the correct token.

So to sum up: If you want to send the CSRF token with a hidden field, you simply render a HTML hidden element like this:
<input type="hidden" name="${mvc.csrf.name}" value="${mvc.csrf.token}"/>

This means you get the name of the hidden field from the MVC Csrf instance.
If you want to use the HTTP header method of communicating the token, you must lookup the token from the HTTP response header (most likely on the client side in JavaScript). But the name of the header is implementation dependent. Then you have to send this token with an HTTP request header back to the server, but this name of this header is also not specified and therefore varies between implementations.
Sounds like you cannot use the HTTP header method in a portable way at all. Or am I missing something?

Fixed via #209


Update to FontAwesome V4.5

Hi JaiQ,
John Ranger here again :-)
I would like to use some of the new Icons which are provided within fontAwesome 4.5 (e.g. the USB icon).
I have seen that Serenity (V1.9.5) currently uses FA V4.4.0. Is there any specific reason why Serenity stays on V4.4.0 or could you include FA V4.5 in one of your next Serenity updates?
(I don't like to update this on my own because then I am out of the Serenity Standard packages versions).
Thanks again for your great work.
With Kind regards,
John.

You can update manually. It wont cause any problems. I updated last week, will do it with next version too.

https://www.nuget.org/packages/FontAwesome/
This is the package i'm using and it's latest version is 4.4.0 unfortunately.

Hi JaiQ,
thanks for your valuable Feedback.
with Kind regards,
John


Bump autorest version to 3.4.0

@AlexanderSher CI was failed because of the generated code is not up to date, please update code


Replace Linkedin with LinkedIn

[x] I have read freeCodeCamp's contribution guidelines.
[x] My pull request has a descriptive title (not a vague title like Update index.md)
[x] My pull request targets the master branch of freeCodeCamp.
[x] None of my changes are plagiarized from another source without proper attribution.
[ ] All the files I changed are in the same world language (for example: only English changes, or only Chinese changes, etc.)
[x] My changes do not use shortened URLs or affiliate links.

@RandellDawson this PR is a bit too small and easily reviewable.. do you still want me to split it in 6 different ones?

Since there are no other PRs with changes to these same files, this will be fine.
The changes look fine to me.


Store Last Accessed Date in Northstar and Expose via API

Analagus to last_accessed date in Phoenix. This will help track user activity in the system and MAU metric.

This makes sense – we can set this property on the user document whenever granting them a new access token (so it'll be "last accessed" with about an hour window). That seems like a fair trade-off between performance & data accuracy.

 As a data analyst, I want Northstar to collect and add fields for last_logged_in and last_accessed

 As a data analyst, I want Northstar to collect and add the field for 'last_accessed` - next quarter

Closed by #591.


Adding some szip tests and extra documentation for nc_inq_var_szip

This PR contains the non-controversial parts of yesterday's PR. This includes some tests for szip behavior and some extra documentation for nc_inq_var_szip(), but no code changes.
Part of #1620
Part of #1616

I'm going to take this PR down, since it's included in #1623.


onChange arguments not in docs

Hello!
I was reading docs for the first time and it was unclear what arguments onChange receive. I had to open examples and get idea from them, or I could open src files.
I suppose, we should add this information to documentation, for better dev. experience. If you are agree, I can do it :)

@dmitrika you're right, it could be more explicit. I already wanted to update the options' format to a more concise block of text, I'll include your request alongside my changes.

Ok, I've update the options section in the README file, let me know if that works ;)
https://github.com/researchgate/react-intersection-observer#options


Fixing logic for finding iprange. Will add logic to find sqlcmd.exe l…

…ocation in next sprint.

https://github.com/Microsoft/vsts-tasks/issues/3993


BUG Can't link existing member to group

GridFieldAddExistingAutocompleter seems to show "Object" instead of the actual item.
Currently affecting master branch.

Jira: https://silverstripe.atlassian.net/browse/OSS-1728

Possibly fixed by https://github.com/silverstripe/silverstripe-framework/pull/5426. Test by porting this to master. :)

Fix at https://github.com/silverstripe/silverstripe-framework/pull/5437


Sync fix for <IP_ADDRESS>

<IP_ADDRESS> nodes refuse to sync properly past block 328798 because of a duplicate key in the Prime Keys database. Block 328799 occurs in the 14 week window, but the duplicate key means it's not valid until 15 weeks, causing the node to reject all blocks with that key, preventing it from syncing.
This PR removes the second duplicate, ensuring that the key is valid at the timestamp on block 328799.

Nice1


Add shortcut to requestId and sessionId

The TraceeBackend-Class provides two helper methods. One to retrieve the request-id, one for the session-id. -- of course only if present in the backend.
For example: Tracee.getBackend().getSessionId() is just a shortcut for Tracee.getBackend().get(TraceeConstants.SESSION_ID_KEY)

I am not a fan of this PR - but if you insist :)


Israel region (new) is missing

Is it possible to add it ?

Hi @thesourcerer ,
Thanks for reaching out, the new region Israel Central has been added.


Add LICM pass and enable it for DateAdd call

Running TPC-H benchmark queries on Omnisci we found that for some queries generated row_func functions have datetime computations (using DateAdd function call) on literals. When row_func is inlined these computations become loop invariant but are not moved out from the loop. In some cases DateAdd call leads to gmtime_r_newlib call which is quite expensive.
This patch add Loop Invariant Code Motion pass to pass manager and add function attributes for DateAdd declaration to correctly identify it as a loop invariant.
This patch gives ~3x speed-up for TPC-H queries Q5, Q10 and ~20x speed-up for Q6, Q12. Actually I could only run 11 of 22 queries of the benchmark so other queries also might be affected.
LICM pass seems to be quite useful and not expensive (it should be linear to total number of statements in loops), so I propose to always use it.

We used to have LICM for hoisting literal loads, glad it's making such a strong comeback. Thanks, I'll have a look later today.

@ienkovich,
Amazing job. I also noticed that looking at llvm code generated by optimizer


Using the Acceleration upgrade in Gendustry Apiary crashes server

https://gist.github.com/dmodoomsirius/a5a34b6ba009c2152288b4bb54bd26cd
using a normal Forestry Apiary does not crash the server. Also reporting this to bdew on the gendustry issue tracker.
Effect is from Career bees.
https://github.com/bdew/gendustry/issues/243

For the record, a normal career bee (temporal queen), with the same effect works just fine when using gendustry.
Same with using standart (no acceleration effect) magic bee with gendustry.

Hm is there something i can do about this on my side?
From the crash it looks like effectData is null, but that is managed by forestry itself and i don't think i can do anything about that?
@mezz any idea?

Also i've compared AlleleEffectThrottled between magic bees and forestry and it looks like MB version is missing this part that would ensure the data is valid i think: https://github.com/ForestryMC/ForestryMC/blob/mc-1.12/src/main/java/forestry/apiculture/genetics/alleles/AlleleEffectThrottled.java#L36-L42

Nope, it's present

I think/hope the fix for #40 also fixed this. Please re-open if it didn't.


Guidance: how to handle storage in Azure regions that add Zone support?

Is your feature request related to a problem? Please describe.
We have dozens of storage accounts in an Azure region.
At the time they were created, there was no Zone support, so they are Standard_LRS.
We detect if the region supports zones at runtime and pass the LRS vs ZRS to the ARM template as a parameter.
Now the region has added zone support.
All of our ARM and Bicep templates fail because they try to update existing storage accounts to ZRS:
StorageAccountTypeConversionNotAllowed - Storage account type Standard_LRS cannot be changed to Standard_ZRS.

What is a clean way to handle this in Bicep without having to list the regions and storage accounts that need to make exceptions?
We are constantly expanding as the region grow and our code needs to be region-independent.
Describe the solution you'd like
If I could tell ARM or Bicep to ignore specific changes on existing resources or even avoid touching specific resources if they exist it would solve my problem.
This is easy with az cli: if az exists then skip else az create ..
Wonder how I can achieve the same result with declarative.

One work around for this is to open a support ticket/ICM and ask the storage team to move all of your storage accounts from LRS to ZRS. The other option is to delete and re-create if you have transient data.

@stephaniezyen - I think @MaurGi  here is not looking for the solution provided, my understanding of this ticket is that @MaurGi  would like to request a feature that enables him to conditionally express an update on the given resource by inspecting the existence of the resource. In other words:
If the storage account exists, then don't try to apply the PUT request to change its account type from Standard_LRS to Standard_ZRS.
Do we have a capability to express the above in a Bicep file already?

I think we can close this as a duplicate of #4023. @maurgi, can you take a look and see if that capability would cover it?
FWIW, terraform has something similar via ignore_changes:
https://developer.hashicorp.com/terraform/language/meta-arguments/lifecycle

Closing as a duplicate and no response.


your code sucks

+1

+1 To clarify why your code sucks,

First of all, why do you need a (function () {})(); in the first place? Also, you could've simplified that into (() => { codehere; })();?
 They are global variables, and "use strict"; is made sure you don't accidentally do that. You could've used a ton of consts and lets on your code.
You used a ton of unnecessary "===".
if () { } else if () { } else if () { }  else if () { }  else if () { }  else if () { }  else if () { }  else if () { }  else if () { }  else if () { }  else if () { } else {}; I don't think I need to explain this.
etc I gtg


Merged

parse-zoneinfo was originally forked from zoneinfo-parse in 2017 (presumably at the latest released version, https://github.com/rust-datetime/zoneinfo-parse/commit/d533d0a64c51507aa5f7c3b0b4d19ae5b0568ca3). This brings the original history back into this repo and merges both branches (zoneinfo-parse had some additional changes after the fork).

I will push this without relying on the web UI so we can get a clean merge commit in the commit history. Then we can work from there -- I suggest we tackle https://github.com/chronotope/chrono-tz/pull/166 next.

We seem to have done almost the same thing. How did you do the merge?

git merge --allow-unrelated-histories
Went through all the changes, accepted mostly our side for minor API changes but tests/docs from the other side
Fixed compilation errors
Fixed tests

Ah, you went for a proper merge!

Maybe compare with my commit in https://github.com/chronotope/parse-zoneinfo/pull/12 to port the documentation to avoid more duplicate work?

Brought over more of the docstrings. I think we should merge this and then work from there.

Compliments on the merge.


Add Purgatori (speedymule cover) start at 2:44 for the yt video

Song Name
Purgatori (speedymule cover dont use this it sucks lol)
Artist Name
savorybaconbits
Source
Youtube
Youtube Link
https://youtu.be/96d_d2oaQ78?si=nHviVFEZKDzfd0e3
Direct File Link
No response
Song ID
895791
Start Offset [ms]
0
Extra
used in con greg demon map wowzers!!!!111!

its a bad mashup on purpose lol (speedymule is my friend btw)


fix(osc): fix i18n hint when user started swap table

What type of PR is this?

type-bug
module-online schema change
What this PR does / why we need it:

Which issue(s) this PR fixes:

When user has click swap table button, and click aggin, return hint Swap table has started
Special notes for your reviewer:

Additional documentation e.g., usage docs, etc.:

your submodule is deprecated

your submodule is deprecated

okey, submodule has updated


I'm getting an Error after clicking Start Game Please Help

This is the error i get. If anyone knows a permanent solution please let me know i will be appreciated.

You can try the newer release of 2.1.1

You can try the newer release of 2.1.1

Thank you for the advice

I have to say there are still same bugs when I used the newer version, however 4.0 is coming, let's see what genshin will change in their graphics.

I have to say there are still same bugs when I used the newer version, however 4.0 is coming, let's see what genshin will change in their graphics.
I guess 4.0 will be an issue for modders as well as fps unlockers. The version will be very huge and complex.

can be ignored


Compilation fails on Windows with C:\\MinGW\\bin\\gcc.exe' failed with exit status 1\n

Compilation fails on Windows with C:\\MinGW\\bin\\gcc.exe' failed with exit status 1\n

I have added a pure Python version of AfterImage. Change the netStat.py file to import AfterImage_NDSS.py instead. It will be slower since it is not Cython.


Update hive-watcher to lighthive, add unix timestamp and json output support

Adds the following extra command line options:
-e/--unix-epoch to start the search with a unix timestamp
-j/--json to print the raw json of the podping payload (be sure to account for both version 0.3 and 1.0)
--start_date now accepts any ISO 8601 or RFC 3339 string

This is fantastic. Thank you!!


arch: riscv: remove unneeded context switch to gp register

RISC-V global pointer (GP) register is neither caller nor callee register and it's a constant value in the single ELF file.
Thus, we don't need to save/restore GP register at ISR enter/exit. Remove it to optimize context switch performance.
Also, this patch can simply the RISC-V GP support to Zephyr. We could only initialize gp value at program start, w/o initializing it again at each thread init because GP register isn't saved.
I saw #36180 is going to add GP support so this patch will affect it.

Add another reference:
FreeRTOS RISC-V doesn't save GP/TP register because they are constants in it.
https://github.com/FreeRTOS/FreeRTOS-Kernel/blob/V10.4.4/portable/GCC/RISC-V/portASM.S#L380
Zephyr RISC-V will set TP register to the TLS of thread, but GP register is still a constant so it doesn't need context switch.

Sorry for asking, but could anyone help review this patch? It still needs one approval review.
@cfriedt @galak

Sorry for asking, but could anyone help review this patch? It still needs one approval review.
@cfriedt @galak

I think I will defer to someone else who has touched this file in the past.

Revert commit 7b09d031fae3969fbe8647a57190f1fa21fabd8e from #36180 because GP initialization at each thread init is NOT needed after this PR removes the context save/restore of GP register.
Depends on the discussion with @uLipe in #36180, reverting this commit still works and is tested on esp32c3 soc.


Feature Request: Functionality to view or filter whether a pull request (PR) has been created for an issue

Issue:
Currently, there is no functionality available to view or filter whether a pull request (PR) has been created for an issue.
Problem:
There are numerous issues that meet the following criteria: labeled as "help wanted," in the state of "OPEN," unassigned, and updated within the last year. However, many of these issues have been resolved by PRs that have not yet been merged. Consequently, these issues remain open without an assignee. Additionally, some issues have PRs linked to them, indicating that work is in progress.
This issue arises due to contributors opening PRs without assigning the related issues to themselves.
Desired Outcome:
It would be beneficial to have an option to filter the results and determine whether a PR has been linked to an issue. This addition would greatly assist in identifying unresolved issues and enhance the filtering capabilities.

hey @tegioz @cynthia-sg @nitishchauhan0022
I would like to work on this one
can you assign this to me
also there are not installation steps mentioned
so can you please give me the steps to install and test project in local Environment.

Hi @Naresh-chandanbatve
This is probably not a good first issue on this project, so @cynthia-sg and I will take care of it. When an interesting good first issue that we need help with comes up, we'll add the labels help wanted and good first issue to it 🙂
I would recommend you to take a look at https://clotributor.dev. It lists ~1k issues from Cloud Native projects that are looking for help (all issues on it are labelled as help wanted!), and you can use the filters to find the ones that best suit your interests and skillset.

okay no problem.


Update to include multiple IPs per NIC limit update

@anavinahar,
Thanks for your contribution as a Microsoft full-time employee or intern. You do not need to sign a CLA.
Thanks,
Microsoft Pull Request Bot


Update dashboard signal documentation

Make markdown table at https://github.com/cmu-delphi/delphi-epidata/blob/08de322948ac6d55ad394d7c2fab62cbd257372b/docs/api/covidcast_signals.md?plain=1#L33-L41 match the current state in https://github.com/cmu-delphi/delphi-epidata/blob/dev/src/server/endpoints/covidcast_utils/descriptions.raw.txt, after recent changes to it in #1334 and #1335, and probably older modifications as well.

@melange396  could you pls describe a bit more detail this task

@BrainIsDead There is a table in docs/api/covidcast_signals.md that has (or at least is supposed to have) information for the signals shown on the public COVIDcast dashboard.  The signals shown are actually controlled by the contents of src/server/endpoints/covidcast_utils/descriptions.raw.txt.  Changes have been made to descriptions.raw.txt (signals have been added and removed as in #1334 and #1335) but the list of signals in covidcast_signals.md was not updated to match.

Update: more changes to the referenced signals were done in https://github.com/cmu-delphi/www-covidcast/pull/1264#issuecomment-2515490060


Add .gitignore

Ignore posts.json, temp.json, and newspaper.html.
Since they will be generated daily, they can be safely ignored.

Awesome, thank you!


Passwords dump update

This PR aims to implement new secrets looting. For now :

Google Refresh Token
SCCM
VNC

Now support also mRemoteNG password dump

And now support MobaXterm password dump

@zblurx can you add these commands to the e2e tests?

mremoteng working 🚀

First run (with registry) works, second one (using config file as storage method) doesn't @zblurx

I also tried extracting a password which was set with RealVNC but couldn't get any output. I also could not find the password in the registry. Anything that i might have done wrong, or is it a bug in the module?

Got vnc setup working now. Added a check for realvnc's proxy credentials. There is bug with the password decryption only showing 8 characters though.

Got vnc setup working now. Added a check for realvnc's proxy credentials. There is bug with the password decryption only showing 8 characters though.
EDIT: UltraVNC only supports passwords up to 8 characters yikes. The rest is just cut off without any warning

Fixed the decryption now:

SCCM working flawless now 🚀

Tomorrow i will test the googleRefreshToken stuff and we should be good2go 🎉

Fixed the conflict that occurred because of my arg parse refactor, should be good now, it was just the --sccm flag needed to be added with the other cred options


Switch to github Actions to use the latest Zola build

Preview url can be found in action log, it would be great to publish it here in a comment/append to description: https://github.com/organicmaps/organicmaps.github.io/actions/runs/4271070846/jobs/7435282832#step:4:48

Added name, added environment: production
@rtsisyk PTAL

Rebased it on the top of the master branch.


[pipelining] Documented response message not related to pipelines/templates/

Response message with '404 not found' is not possible for this request.
Implementation Notes
Returns all visible pipelining templates
it just returns emty array if no pipelene template available.
This possible message is releted for request with id
GET /pipelining/templates/{id}

This is correct.
Can the API documentation be updated for
GET /pipelining/templates/

Please remove the 404 Not found response, as it is never returned.


Disc number?

It seems like previous versions added the disc number to the file name or put different discs in different folders, I can't remember exactly. I just downloaded an album that had multiple songs with the same name on different discs that were then skipped when downloading. It would be nice to be able to add the disc number before the track number (for example 101 for disc 1 track 1, 201 for disc 2 track 1, etc.) or put each disc in a separate folder. Thanks.

I completely agree that each disk must be saved in a separate folder, with the names CD1, CD2 ...

fixed


Compilation problems on MSVS 2015

According to one report, the project won't compile on MSVS 2015 (or, tons of warnings are generated, at least). This should be resloved.

The problem shoud now be resolved.


cuda_setup is not defined

recently started getting this error on new version:
2023-02-05T10:29:54Z [job]     import bitsandbytes as bnb
2023-02-05T10:29:54Z [job]   File "/app/env/lib/python3.8/site-packages/bitsandbytes/__init__.py", line 7, in <module>
2023-02-05T10:29:54Z [job]     from .autograd._functions import (
2023-02-05T10:29:54Z [job]   File "/app/env/lib/python3.8/site-packages/bitsandbytes/autograd/__init__.py", line 1, in <module>
2023-02-05T10:29:54Z [job]     from ._functions import undo_layout, get_inverse_transform_indices
2023-02-05T10:29:54Z [job]   File "/app/env/lib/python3.8/site-packages/bitsandbytes/autograd/_functions.py", line 9, in <module>
2023-02-05T10:29:54Z [job]     import bitsandbytes.functional as F
2023-02-05T10:29:54Z [job]   File "/app/env/lib/python3.8/site-packages/bitsandbytes/functional.py", line 17, in <module>
2023-02-05T10:29:54Z [job]     from .cextension import COMPILED_WITH_CUDA, lib
2023-02-05T10:29:54Z [job]   File "/app/env/lib/python3.8/site-packages/bitsandbytes/cextension.py", line 13, in <module>
2023-02-05T10:29:54Z [job]     setup.run_cuda_setup()
2023-02-05T10:29:54Z [job]   File "/app/env/lib/python3.8/site-packages/bitsandbytes/cuda_setup/main.py", line 92, in run_cuda_setup
2023-02-05T10:29:54Z [job]     binary_name, cudart_path, cuda, cc, cuda_version_string = evaluate_cuda_setup()
2023-02-05T10:29:54Z [job]   File "/app/env/lib/python3.8/site-packages/bitsandbytes/cuda_setup/main.py", line 395, in evaluate_cuda_setup
2023-02-05T10:29:54Z [job]     has_cublaslt = is_cublasLt_compatible(cc)
2023-02-05T10:29:54Z [job]   File "/app/env/lib/python3.8/site-packages/bitsandbytes/cuda_setup/main.py", line 153, in is_cublasLt_compatible
2023-02-05T10:29:54Z [job]     cuda_setup.add_log_entry("WARNING: Compute capability < 7.5 detected! Only slow 8-bit matmul is supported for your GPU!", is_warning=True)
2023-02-05T10:29:54Z [job] NameError: name 'cuda_setup' is not defined

Getting the same error!

import bitsandbytes

===================================BUG REPORT===================================
Welcome to bitsandbytes. For bug reports, please submit your error trace to: https://github.com/TimDettmers/bitsandbytes/issues
Traceback (most recent call last):
File "", line 1, in
File "/home/siddhesh/anaconda3/envs/textgen/lib/python3.10/site-packages/bitsandbytes/init.py", line 7, in
from .autograd._functions import (
File "/home/siddhesh/anaconda3/envs/textgen/lib/python3.10/site-packages/bitsandbytes/autograd/init.py", line 1, in
from ._functions import undo_layout, get_inverse_transform_indices
File "/home/siddhesh/anaconda3/envs/textgen/lib/python3.10/site-packages/bitsandbytes/autograd/_functions.py", line 9, in
import bitsandbytes.functional as F
File "/home/siddhesh/anaconda3/envs/textgen/lib/python3.10/site-packages/bitsandbytes/functional.py", line 17, in
from .cextension import COMPILED_WITH_CUDA, lib
File "/home/siddhesh/anaconda3/envs/textgen/lib/python3.10/site-packages/bitsandbytes/cextension.py", line 13, in
setup.run_cuda_setup()
File "/home/siddhesh/anaconda3/envs/textgen/lib/python3.10/site-packages/bitsandbytes/cuda_setup/main.py", line 92, in run_cuda_setup
binary_name, cudart_path, cuda, cc, cuda_version_string = evaluate_cuda_setup()
File "/home/siddhesh/anaconda3/envs/textgen/lib/python3.10/site-packages/bitsandbytes/cuda_setup/main.py", line 395, in evaluate_cuda_setup
has_cublaslt = is_cublasLt_compatible(cc)
File "/home/siddhesh/anaconda3/envs/textgen/lib/python3.10/site-packages/bitsandbytes/cuda_setup/main.py", line 153, in is_cublasLt_compatible
cuda_setup.add_log_entry("WARNING: Compute capability < 7.5 detected! Only slow 8-bit matmul is supported for your GPU!", is_warning=True)
NameError: name 'cuda_setup' is not defined. Did you mean: 'CUDASetup'?

This will get you through the error but it still won't generate text.
def is_cublasLt_compatible(cc):
    has_cublaslt = False
    if cc is not None:
        cc_major, cc_minor = cc.split('.')
        #if int(cc_major) < 7 or (int(cc_major) == 7 and int(cc_minor) < 5):
            #CUDASetup.add_log_entry("WARNING: Compute capability < 7.5 detected! Only slow 8-bit matmul is supported for your GPU!", is_warning=True)
        #else:
         #   has_cublaslt = True
    return has_cublaslt

@Ph0rk0z
This comment works for Compute capability < 7.5 (Pascal, Maxwell GPUs)
I just tested on a 1080ti, bitsandbytes will load correctly if you use this fix.

@JohnnyRacer
It will help that - https://github.com/huggingface/peft/issues/79 as well?

@JohnnyRacer
It will help that - huggingface/peft#79 as well?

@shon-otmazgin
Yes. You will need to change that line everytime you reinstall the bitsandbytes package for the error to go away however.

The PR's are more elegant.
https://github.com/TimDettmers/bitsandbytes/pull/117/commits/70a36dcd537ed0b5b8e775a9b613d816b9879861
https://github.com/TimDettmers/bitsandbytes/pull/132/commits/1238d1842bdebf9c89925bdd5712c9f5ffe4c206

when I used bitsandbytes==0.37.0
File "/opt/conda/lib/python3.8/site-packages/bitsandbytes/cuda_setup/main.py", line 153, in is_cublasLt_compatible
    cuda_setup.add_log_entry("WARNING: Compute capability < 7.5 detected! Only slow 8-bit matmul is supported for your GPU!", is_warning=True)
NameError: name 'cuda_setup' is not defined

I fixed it by pip install bitsandbytes==0.35.0

+1, same error
cuda_setup.add_log_entry("WARNING: Compute capability < 7.5 detected! Only slow 8-bit matmul is supported for your GPU!", is_warning=True)
NameError: name 'cuda_setup' is not defined

when I used bitsandbytes==0.37.0
File "/opt/conda/lib/python3.8/site-packages/bitsandbytes/cuda_setup/main.py", line 153, in is_cublasLt_compatible
    cuda_setup.add_log_entry("WARNING: Compute capability < 7.5 detected! Only slow 8-bit matmul is supported for your GPU!", is_warning=True)
NameError: name 'cuda_setup' is not defined

I fixed it by pip install bitsandbytes==0.35.0

+1 on this - got the same issue with bitsandbytes == 0.36.0 but fixed it with 0.35.0

AFAIK this error is now fixed in newer BnB

Bitsandbytes was not supported windows before, but my method can support windows.（yuhuang）
1  open folder J:\StableDiffusion\sdwebui，Click the address bar of the folder and enter CMD
or WIN+R, CMD  。enter，cd /d J:\StableDiffusion\sdwebui
2  J:\StableDiffusion\sdwebui\py310\python.exe -m pip uninstall bitsandbytes
3 J:\StableDiffusion\sdwebui\py310\python.exe -m pip uninstall bitsandbytes-windows
4 J:\StableDiffusion\sdwebui\py310\python.exe -m pip install https://github.com/jllllll/bitsandbytes-windows-webui/releases/download/wheels/bitsandbytes-0.41.1-py3-none-win_amd64.whl
Replace your SD venv directory file（python.exe Folder） here（J:\StableDiffusion\sdwebui\py310）


Trust which folder?

Upon installing the latest version I get prompted whether I trust "this folder".
However, the message doesn't indicate which folder it is referring to. I am assuming it is the base folder of the current project. However, there is no indication about this whatsoever.

Here is a screenshot of the message.

Does this issue occur when all extensions are disabled?: Yes/No

VS Code Version: 1.57
OS Version: MacOS 11.3.1 (20E241)

Steps to Reproduce:

Open VSCode after updating

duplicate https://github.com/microsoft/vscode/issues/125984


[integration_test] Cannot run on iOS (please run "pub get" again)

Problem
I am really confused as to why the flutter_driver run integration_tests will not start on iOS.
You can find a complete reproducible sample (exact state of the Flutter project can be found in the file tree of this commit). This should run on CI, so you can even exactly follow logs.
Steps to Reproduce
You can check this GitHub Actions run for the full steps.

Do the integration_test setup (already done in the linked project).
Run flutter drive --driver=test_driver/integration_test.dart --target=integration_test/wakelock_test.dart --no-sound-null-safety

Expected results: it should run the integration tests.
Actual results:
Running "flutter pub get" in example...                          1,169ms
Running pod install...                                              5.1s
Running Xcode build...
Xcode build done.                                           132.9s
The pubspec.yaml file has changed since the pubspec.lock file was generated, please run "pub get" again.
Failed to stop app

The pubspec.yaml file has changed since the pubspec.lock file was generated, please run "pub get" again.

Full logs
You can find the full raw logs here.
They were run on https://github.com/creativecreatorormaybenot/wakelock/tree/b62a023cd00264018668a6ad47f67dadedc029f02/wakelock/example.
Note
The same integration tests ran before, so I am not sure why the "please run 'pub get' again" message is popping up now (example run that succeeded).
I can also reproduce this on my local machine.

I think this should have been fixed with https://github.com/flutter/flutter/pull/70999 , but I can't tell what version you are on.

@jonahwilliams You can see it in the raw logs, but I should have included it:
It happens on both 1.24.0-10.2.pre-beta and 1.24.0-10.2.pre-dev in CI.
Locally, it also happens with 1.24.0-10.2.pre dev channel.
→ the PR is not on these versions yet because dev and beta have not received updates in quite a while.

@jonahwilliams The Pub issue seems to be resolved on master 🎉  (see https://github.com/creativecreatorormaybenot/wakelock/pull/66/checks?check_run_id=1483575046).
I am now just having issues with null safety and Flutter driver, but that has nothing to do with this issue.
→ you can close this now if you want. I will certainly do it once the fix lands on a channel.

Awesome!  🎊


fix(ci): change token to env

Pull Request Test Coverage Report for Build 674758885

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 100.0%

Totals

Change from base Build 674740520:
0.0%

Covered Lines:
699

Relevant Lines:
699

💛  - Coveralls


START_RUNNER and END_RUNNER events should be emitted through emitAndWait

/cc @j0tunn @sipayRT

Coverage remained the same at 83.901% when pulling 0409a09adfc97231b3e09c439b76040d2d6cb612 on fix/emitting-start-end-runner-events into 63bdf049834f2f92680d76964c147c7a5e729290 on master.


How to save videos through videosource, instead of using output.render

@lofyol --input-save=file.mp4 , it only applies to streams that are already compressed though.
https://github.com/dusty-nv/jetson-inference/blob/master/docs/aux-streaming.md#input-options


Support Aarch64 (ARM64 V8), ARM v7, and AMD64

Is your feature request related to a problem? Please describe. (Optional)
Right now (as mentioned in #13) the current implementation of the Master, Server, and Debug images only support amd64. This has to do with the images being backed by a JDK implementation running on Alpine which is only available in amd64.
In order to fully support all clouds we want to support ARM64v8 and ARMv7 for both 32 and 64 bit.
Describe the solution you'd like
Multi arch support using Alpine and other distributions available through the Eclipse Temurin project.
Describe alternatives you've considered
Not supporting ARM64v8 and ARMv7.
Additional context
None.

For the Debian Slim port only ARM64v8 will be supported as there currently are some issues with the ARMv7 distribution. We'll update this issue as we find out more about this.


Cucumber instrumentation not creating spans

[x] This only affects the JavaScript OpenTelemetry library
[ ] This may affect other libraries, but I would like to get opinions here first

I am trying to instrument my cucumber tests in NodeJS but I can't make it trace anything at all.
I tried using both
import { getNodeAutoInstrumentations } from '@opentelemetry/auto-instrumentations-node'
and
import { CucumberInstrumentation } from '@opentelemetry/instrumentation-cucumber'
but had no luck with either.
This is the file I have that sets up the telemetry:
/* eslint-disable @typescript-eslint/no-unused-vars */
import { After, Before, BeforeStep, AfterStep, Status, BeforeAll } from '@cucumber/cucumber'
import { NodeSDK } from '@opentelemetry/sdk-node'
import { CucumberInstrumentation } from '@opentelemetry/instrumentation-cucumber'
import { Resource } from '@opentelemetry/resources'
import { ATTR_SERVICE_NAME } from '@opentelemetry/semantic-conventions'
import * as api from '@opentelemetry/api'
import { AsyncHooksContextManager } from '@opentelemetry/context-async-hooks'
import * as grpc from '@grpc/grpc-js'
import { OTLPTraceExporter } from '@opentelemetry/exporter-trace-otlp-grpc'

const collectorOptions = {
    url: 'localhost:4317',
    credentials: grpc.credentials.createInsecure(),
}

const sdk = new NodeSDK({
    resource: new Resource({
        [ATTR_SERVICE_NAME]: 'E2E System Tests'
    }),
    traceExporter: new OTLPTraceExporter(collectorOptions),
    instrumentations: [new CucumberInstrumentation()],
})

const contextManager = new AsyncHooksContextManager().enable()
api.context.setGlobalContextManager(contextManager)

try {
    sdk.start()
    console.log('Tracing initialized')
} catch (error) {
    console.log('Error initializing tracing', error)
}

// Executed after all scenarios
AfterAll(function () {
    sdk.shutdown()
        .then(() => console.log('Tracing terminated'))
        .catch((error) => console.log('Error terminating tracing', error))
})

It gets called and if I create spans manually they show up in the OTELCollector, so telemetry seems to be properly set up.
Does anyone have a real example of to set it up for a real cucumber project?

do you compile your code to ESM or commonjs? :thinking:
There's an extra step for ESM users that needs to be followed, because we only hook require calls by default but they don't exist in ESM, so we need a loader hook  - details here https://github.com/open-telemetry/opentelemetry-js/blob/main/doc/esm-support.md


build(all): switch website hosting from Netlify to AWS

I have already changed the DNS setup and tested the deployment locally. So https://feature-hub.io/ is now hosted on AWS. This PR adds the necessary aws-simple config and GitHub Actions workflows to set up the deployment for the CI (including PR deployments). I also had to change the API docs path from @feature-hub to api because AWS does not allow an @ in an API Gateway route.
Note: The command actions can not be tested in this PR, because they must be available in master first.

The Netlify jobs are expected to fail. We can ignore those. I've now deactivated the builds on netlify.com, so I think they won't appear in future PRs. If they do, we need to remove the Netlify GitHub integration for this repo at the org level.


[V3] Update bootstrap to version "3.4.1" in  CSharp/Blog-LUISActionBinding/LuisActions.Samples.Web

V3 issue
CSharp/Blog-LUISActionBinding/LuisActions.Samples.Web/packages.config needs to be updated to use the following version of bootstrap:

[bug]

Created a PR for this.  However, we should consider removing this sample from this repository entirely since it is also maintained here now: https://github.com/Microsoft/BotBuilder-CognitiveServices/tree/master/CSharp/Samples/LuisActions and the node version here: https://github.com/Microsoft/BotBuilder-CognitiveServices/tree/master/Node/samples/LuisActionBinding

@EricDahlvang RE:  removing it.  Yes.  Please do that instead.

Closing (PR removing the V3 Action Binding samples has been merged)


Authorization Violation when creating a client.

AsyncErrorEvent, Connection: 352, Error: 'Authorization Violation'
AsyncErrorEvent, Connection: 352, Error: 'Authorization Violation'
ClosedEvent, Connection: 352
Exception: error occured, when connecting memphis
Memphis.Client.Exception.MemphisConnectionException: error occured, when connecting memphis
 ---> NATS.Client.NATSConnectionException: 'Authorization Violation'
   at NATS.Client.Connection.connect()
   at NATS.Client.ConnectionFactory.CreateConnection(Options opts)
   at Memphis.Client.MemphisClientFactory.CreateClient(ClientOptions opts) in D:\ChatGPT_projects\Mempis_test\memphis.net\src\Memphis.Client\MemphisClientFactory.cs:line 70
   --- End of inner exception stack trace ---
   at Memphis.Client.MemphisClientFactory.CreateClient(ClientOptions opts) in D:\ChatGPT_projects\Mempis_test\memphis.net\src\Memphis.Client\MemphisClientFactory.cs:line 80
   at Producer.ProducerApp.Main(String[] args) in D:\ChatGPT_projects\Mempis_test\Mempis_test\Program.cs:line 17

The application type token and user name created in the dashboard are correct.
Steps to reproduce:
Run code snippet from:
examples/Producer/Program.cs
Memphis instance is running locally from docker-compose file.
This is what container logs:
memphis-memphis-cluster-1       | [1] 2023/04/01 00:01:13.333282 [ERR] <IP_ADDRESS>:49530 - cid:232 - "v<IP_ADDRESS>:.NET:d0e60e3d-ca85-48d4-887a-5cf7665b1b21::REDUCTED" - handleConnectMessage: User REDUCTED: the provided hex string is not a valid ObjectID

Might be an issue with mongo db driver...


CoordinatorLayout is missing

Hey,
The CoordinatorLayout has no extension function to ViewManager.
When I search the GitHub Repo I find this as generated, but it is not packed in the 0.10.0 jcenter jar (anko-sdk25-0.10.0-sources.jar).
Greetings,

CoordinatorLayout is a part of the design support library.
Please add compile "org.jetbrains.anko:anko-design:$anko_version" to your project dependencies (https://github.com/Kotlin/anko#gradle-based-project).

Ah. Thanks. I missunderstood the README, as I thought the meta package includes the support libraries too.


Update SQLitePCL to SQLitePCL.raw

Fixes #191

Hi @pragnagopa, I'm your friendly neighborhood Azure Pull Request Bot (You can call me AZPRBOT). Thanks for your contribution!

It looks like you're working at Microsoft (pgopa). If you're full-time, we DON'T require a contribution license agreement.

If you are a vendor, DO please sign the electronic contribution license agreement. It will take 2 minutes and there's no faxing! https://cla.azure.com.

TTYL, AZPRBOT;

@fabiocav @paulbatum  - Please review. @dhei - Please verify csproj changes to E2E test projects

  <HintPath>..\..\packages\Microsoft.Azure.Mobile.Client.2.1.0\lib\monoandroid\Microsoft.WindowsAzure.Mobile.dll</HintPath>

As you have updated reference to Microsoft.Azure.Mobile.Client nuget 2.1.1 all across the repo, I'd suggest update this project as well.

Refers to: e2etest/Android.E2ETest/Android.E2ETest.csproj:58 in c12ede3. [](commit_id = c12ede30daa78863419168858a7a25b520da1efb, deletion_comment = False)

The rest of the .csproj & packages.config change looks really good to me.

@pragnagopa: In your last commit, is UWP.E2ETest sharing login tests with WindowsStore.E2ETest?

@dhei  yes. UWP project is now updated to share code with WindowsStore E2E project

@fabiocav is added to the review. #Closed

@paulbatum is added to the review. #Closed

@pragnagopa took a firs pass primarily focused on the SDK (as opposed to tests) and left a few small comments. This looks good. Looks like the migration is pretty straight forward.


Whitelist openuserjs.org

Hi! openuserjs.org is listed on the hosts file but it's not a porn site. It's an alternative to Greasy Fork

Just merged the PR! Thanks for your help, really appreciated!


Feature/indent

This request is regarding the issue #90 .
Requesting for comment.

Are you satisfied with it all? If so please fix the conflict and target your PR for the development-v1.3.0 branch!

Not yet ':). I feel i need to do a bit more testing

This PR addresses:

[ ] Replace tab with 4 spaces
[ ] Move block of code on select and tab

Thanks :)


To show AV_PIX_FMT_BGR24 format (format in FFmpeg context) image

Is there any way to show AV_PIX_FMT_BGR24 format (format in FFmpeg context) image in Avalonia App

Should following code work:
using Avalonia.Controls;
using Avalonia.Media.Imaging;
using SIPSorceryMedia.Abstractions;
public static Bitmap Convert_AV_PIX_FMT_BGR24(RawImage rawImage)
{
// Create a new Bitmap from the raw image.
var bitmap = new Bitmap(
PixelFormat.Bgra8888,
AlphaFormat.Premul,
rawImage.Sample,
new PixelSize(rawImage.Width, rawImage.Height),
new Vector(96, 96),
rawImage.Stride
);
return bitmap;
}

@mail2mhossain No sadly you need to at least get AV_PIX_FMT_BGRA format from ffmpeg so that it maps with Avalonia's Bgra8888 format.

Solution:
First, you need to install the SixLabors.ImageSharp NuGet package to your project
Then, you can use the following code to convert the RawImage object to a SixLabors.ImageSharp.Image:

public static unsafe Image ConvertRawImageToImageSharp (SIPSorceryMedia.Abstractions.RawImage rawImage)
{
int expectedStride = rawImage.Width * 3; // 3 bytes per pixel for Bgr24 format
if (rawImage.Stride != expectedStride)
{
throw new InvalidOperationException("Stride of the raw image does not match the expected stride for ImageSharp Bgr24 format.");
}
	// Create a new memory span from the rawImage Sample pointer
	var pixelDataSpan = new Span<byte>(rawImage.Sample.ToPointer(), rawImage.Height * rawImage.Stride);

	// Load the pixel data from the span
	var image = Image.LoadPixelData<Bgr24>(pixelDataSpan, rawImage.Width, rawImage.Height);

	return image;
}

Now convert the ImageSharp Image to an Avalonia Bitmap:
public static Bitmap ConvertImageSharpToAvaloniaBitmap (Image image)
{
// Create a new WriteableBitmap with the same dimensions as the ImageSharp image
var writeableBitmap = new WriteableBitmap(new PixelSize(image.Width, image.Height), new Vector(96, 96), Avalonia.Platform.PixelFormat.Rgba8888, Avalonia.Platform.AlphaFormat.Opaque);

 	// Lock the WriteableBitmap's pixel buffer for direct access
 	using (var buffer = writeableBitmap.Lock())
 	{
 		// Copy the pixel data from the ImageSharp image to the WriteableBitmap
 		for (int y = 0; y < image.Height; y++)
 		{
 			Span<Bgr24> pixelRowSpan = image.GetPixelRowSpan(y);
 			IntPtr pixelRowPtr = buffer.Address + y * buffer.RowBytes;

 			for (int x = 0; x < pixelRowSpan.Length; x++)
 			{
 				Bgr24 pixel = pixelRowSpan[x];
 				byte[] rgbaPixel = { pixel.R, pixel.G, pixel.B, 255 };
 				Marshal.Copy(rgbaPixel, 0, pixelRowPtr + x * 4, 4);
 			}
 		}
 	}

 	return writeableBitmap;
 }

Thanks to GPT-4


Fix the sample set label

move to fstream
add ios:trunc to create the file

@meijin007,
Thanks for your contribution as a Microsoft full-time employee or intern. You do not need to sign a CLA.
Thanks,
Microsoft Pull Request Bot


Install Wizard - Gmail helper URL - 404

Cannot find helper page
[nix-shell:~]$ himalaya
Cannot find existing configuration at "/home/jcbevns/.config/himalaya/config.toml".
Would you like to create one with the wizard? yes

Configuring your first account:

✔ Email address ·<EMAIL_ADDRESS>✔ Account name · gmail
✔ Full display name · xxxx
✔ Downloads directory · ~/Downloads

Warning: Google passwords cannot be used directly, see:
https://pimalaya.org/himalaya/cli/latest/configuration/gmail.html

gives...

Indeed, broken link. Thank you for pointing it out. The equivalent doc is in the README, configuration section, gmail subsection.


added addittionall LazyLoader-information to Readme

as WebP works with small changes with the Available LazyLoader from the community-store i added inforamtion on this.
The Plugin uses lazysize ( https://github.com/aFarkas/lazysizes ) and looks good so far, so i saw no need to do the same ;-D

I would suggest a Wiki entry for that instead a Readme entry

Where can I contribute to the wiki?


pac commands not working properly after recent version upgrade of the pac tool

Discussed in https://github.com/microsoft/powerplatform-build-tools/discussions/801

Originally posted by gituseranh April  3, 2024
Hi!
I recently upgraded pac to version 1.31.6 (Latest) on two systems. It is working fine on one but not on the other!  Not sure how the discrepancy happened! Apparently, I need to force the system to use pac.cmd instead of pac.exe but I do not know how to do that - would appreciate any suggestions or help with this issue.  Thanks in advance. [More details provided below]
[On the system where it Does Not Work properly]

Get-Command pac | Format-List
Name            : pac.exe
CommandType     : Application
Definition      : F:\build_apps\powerapps-cli\Microsoft.PowerApps.CLI.1.31.6\tools\pac.exe
Extension       : .exe
Path            : F:\build_apps\powerapps-cli\Microsoft.PowerApps.CLI.1.31.6\tools\pac.exe
FileVersionInfo : File: F:\build_apps\powerapps-cli\Microsoft.PowerApps.CLI.1.31.6\tools\pac.exe

              InternalName:     pac.exe
              OriginalFilename: pac.exe
              FileVersion:      1.31.6
              FileDescription:  Microsoft Power Platform CLI
              Product:          Microsoft Power Platform©
              ProductVersion:   1.31.6+g9147a23

[On the system where it Works]

Get-Command pac | Format-List
Name            : pac.cmd
CommandType     : Application
Definition      : F:\build_apps\powerapps-cli\pac.cmd
Extension       : .cmd
Path            : F:\build_apps\powerapps-cli\pac.cmd
FileVersionInfo : File:             F:\build_apps\powerapps-cli\pac.cmd
InternalName:
OriginalFilename:
FileVersion:
FileDescription:
Product:
ProductVersion:

This issue has been resolved. petrochuk provided the solution and pointed out that:
pac.cmd is just a text file with two lines in it:
@echo off
"%~dp0pac.launcher.exe" %*
if you want to you can create it anywhere on your system and add to %PATH%
That did the trick!!   Ref: https://github.com/microsoft/powerplatform-build-tools/discussions/801


Remove Cipher logo (it's no longer maintained)

Remove Cipher logo from Mobile Wallets section, as it's no longer maintained

#82


Tekken 3 (SLPS-01300) Black Screen only

Before opening this kind of issue, please ensure:

Are you using a compatible console version? Yes
Are you using CD-R media, and not CD-RW? I am using my original/authentic black disc
Did you copy all the files in the expected format to the memory card? Yes

tonyhax version: Which version are you running? Please ensure you are running the latest stable, or a newer beta.
Tonyhax v1.4.5
Installation method: How did you get tonyhax on the memory card? PS2 console and MCA v2
Entry point game: Which game are you using to launch tonyhax? FreePSXBoot Slot2
Console model: Console product code, written on the bottom of the unit, such as "SCPH-7502" I am using SCPH-9001
Integrity check: If it boots, does the built-in integrity check succeed? Yes
BIOS version: If you can get to boot, which version of the BIOS does it report? v4.1
Target game: If the bug happens when launching a game, what's its name and game code? Example: "Spyro 3 (SCES-02835)"
Tekken 3 (SLPS-01300)
Bug explanation:
Please write a detailed explanation on which issue are you experiencing.
After the Tonyhax v1.4.5 loads and after passing the "Starting" message it should play the Namco Screen but instead only black screen.  After Tonyhax v1.4.5 loads/boots, remove the memorycard on slot 2 then put the Tekken 3 Japan (SLPS-01300) game disc and play with no problems. I tried another game Sangoku Musou Japan (SLPS-00731) original black disc after Tonyhax v1.4.5 boots and I would not remove the memorycard on slot 2 and load the game it will hangs on the "Starting" log screen, but removing the memorycard on slot 2 after it boots it will load the game with no problems. Possible for now this will a work around that games with black screen or hangs on Starting log screen.

I discovered my workaround to play this game. After Tonyhax v1.4.5 loads/boots, remove the memorycard on slot 2 then put the Tekken 3 Japan (SLPS-01300) game disc and play with no problems. I tried another game Sangoku Musou Japan (SLPS-00731) original black disc after Tonyhax v1.4.5 boots and I would not remove the memorycard on slot 2 and load the game it will hangs on the "Starting" log screen, but removing the memorycard on slot 2 after it boots it will load the game with no problems. Possible for now this will a work around that games with black screen or hangs on Starting log screen.
Edit: Actually not really "I discovered" it was the idea of @alex-free and I myself try it if it applies on this original fork Tonyhax and test on latest as of this writing v1.4.5 and it does that would be the work around for games with black screen after booting or hangs when "Starting" log screen appears. Sorry for that.

Oh wow this is super interesting that it also happens in the original tonyhax. Socram8888 has a debugger he can use to actually figure out why this issue happens and why my workaround works.
Again, this issue only happens with the FreePSXBoot exploit. The even more interesting bit is that the original Tonyhax is using a patch to disable slot 2 by Socram8888 himself.
The first issue with the Socram8888 patch is that it doesn't work on BIOS v1.0, BIOS v1.1, and BIOS v2.0 due to what I think is kernel differences in the older versions compared to BIOS v2.1 and above which due work as expected. BIOS v2.0 is found in the oldest USA consoles and therefore is affected even in the original Tonyhax. Meanwhile BIOS v1.0 and v1.1 are only found in the launch Japanese consoles and are not relevant here.
The second issue with the Socram8888 patch is that it doesn't work on all games. If you check the release notes to the FreePSXBoot exploit builder program, the original exploit author realized that the way the patches were originally disabling slot 2 by simulating a corrupted memory card was preventing some games from working correctly at all. The exploit author devised a new method which simulated a timeout with reading from the memory card in slot 2. This new method resulted in a patch which also for the first time worked on all PSX BIOS versions, including v1.0, v1.1, and v2.0. This new patch is automatically applied before starting the PS-EXE during the exploit. This is all apart of how the FreePSXBoot builder program generates the exploit memory card images.
The original Tonyhax resets the BIOS and all the tables/exception handler/all the stuff that the FreePSXBoot exploit changes right before starting the Tonyhax PS-EXE using the exploit. This is kind of redundant IMO (that stuff is not in a weird state after using the FreePSXBoot exploit like say a save game exploit would leave it as) but is also why Socram8888 has his own patch in Tonyhax that gets applied.
My idea with Tonyhax International was to only for the FreePSXBoot exploit boot method, not to reset the exception handler and BIOS tables (but still reset interrupts and clear kernel stack memory as well as other things from the original reset bios function). This way the original FreePSXBoot builder patch for the slot 2 memory card would remain intact and indeed effective).
I was thinking it was the patch causing this issue with the stuck on starting text but that doesn't actually seem to be the case. My fork and the original are extremely different in regard to the FreePSXBoot exploit yet the same issue and workaround work.
I really look forward to socram8888 looking into this with the debugger that I don't have access to.

Wait I have an idea. Maybe if for the FreePSXBoot method immediately at load the stopcard() BIOS function could be called and maybe it will unscrew up whatever state unreliably occurs that causes this issue. Might have to startcard() before stopcard() too I'll check this out.

Tekken 3 (SLPS-01300) Import Disc test results
SCPH-101 v4.4
Official Release v1.1.9 FreePSXBoot slot 2 no remove = plays with no problem
Test Build (Mar 15, 2023) FreePSXBoot slot 2 no remove = plays with no problem
SCPH-9001
Official Release v1.1.9 FreePSXBoot slot 2 no remove = black screen
Test Build (Mar 15, 2023) FreePSXBoot slot 2 no remove = black screen
Official Release v1.1.9 FreePSXBoot slot 2 remove = plays with no problem
Test Build (Mar 15, 2023) FreePSXBoot slot 2 remove = plays with no problem
SCPH-5501
Official Release v1.1.9 FreePSXBoot slot 2 no remove = black screen
Test Build (Mar 15, 2023) FreePSXBoot slot 2 no remove = after almost a second horizontal glitch screen then black screen
Official Release v1.1.9 FreePSXBoot slot 2 remove = plays with no problem
Test Build (Mar 15, 2023) FreePSXBoot slot 2 remove = plays with no problem
Sangoku Musou Japan (SLPS-00731) Import Disc test results
SCPH-101 v4.4
Official Release v1.1.9 FreePSXBoot slot 2 no remove = plays with no problem
Test Build (Mar 15, 2023) FreePSXBoot slot 2 no remove = plays with no problem
SCPH-9001
Official Release v1.1.9 FreePSXBoot slot 2 no remove = hangs after word "Starting" on log screen
Test Build (Mar 15, 2023) FreePSXBoot slot 2 no remove = hangs after word "Starting" on log screen
Official Release v1.1.9 FreePSXBoot slot 2 remove = plays with no problem
Test Build (Mar 15, 2023) FreePSXBoot slot 2 remove = plays with no problem
SCPH-5501
Official Release v1.1.9 FreePSXBoot slot 2 no remove = hangs after word "Starting" on log screen
Test Build (Mar 15, 2023) FreePSXBoot slot 2 no remove = hangs after word "Starting" on log screen
Official Release v1.1.9 FreePSXBoot slot 2 remove = plays with no problem
Test Build (Mar 15, 2023) FreePSXBoot slot 2 remove =plays with no problem
No remove means after Tonyhax International boots, the memorycard on slot 2 stay as is
Remove means after Tonyhax International boots, remove the memorcyard on slot 2
On remove memorycard on slot 2 then load the game then while the intro screen is playing, you can put back the memorycard on slot 2 and still the game won't recognize the memorycard insterted. Test this only Sangoku Musou game.

Tekken 3 (SLPS-01300) Import Disc test results SCPH-101 v4.4 Official Release v1.1.9 FreePSXBoot slot 2 no remove = plays with no problem Test Build (Mar 15, 2023) FreePSXBoot slot 2 no remove = plays with no problem SCPH-9001 Official Release v1.1.9 FreePSXBoot slot 2 no remove = black screen Test Build (Mar 15, 2023) FreePSXBoot slot 2 no remove = black screen Official Release v1.1.9 FreePSXBoot slot 2 remove = plays with no problem Test Build (Mar 15, 2023) FreePSXBoot slot 2 remove = plays with no problem SCPH-5501 Official Release v1.1.9 FreePSXBoot slot 2 no remove = black screen Test Build (Mar 15, 2023) FreePSXBoot slot 2 no remove = after almost a second horizontal glitch screen then black screen Official Release v1.1.9 FreePSXBoot slot 2 remove = plays with no problem Test Build (Mar 15, 2023) FreePSXBoot slot 2 remove = plays with no problem
Sangoku Musou Japan (SLPS-00731) Import Disc test results SCPH-101 v4.4 Official Release v1.1.9 FreePSXBoot slot 2 no remove = plays with no problem Test Build (Mar 15, 2023) FreePSXBoot slot 2 no remove = plays with no problem SCPH-9001 Official Release v1.1.9 FreePSXBoot slot 2 no remove = hangs after word "Starting" on log screen Test Build (Mar 15, 2023) FreePSXBoot slot 2 no remove = hangs after word "Starting" on log screen Official Release v1.1.9 FreePSXBoot slot 2 remove = plays with no problem Test Build (Mar 15, 2023) FreePSXBoot slot 2 remove = plays with no problem SCPH-5501 Official Release v1.1.9 FreePSXBoot slot 2 no remove = hangs after word "Starting" on log screen Test Build (Mar 15, 2023) FreePSXBoot slot 2 no remove = hangs after word "Starting" on log screen Official Release v1.1.9 FreePSXBoot slot 2 remove = plays with no problem Test Build (Mar 15, 2023) FreePSXBoot slot 2 remove =plays with no problem
No remove means after Tonyhax International boots, the memorycard on slot 2 stay as is Remove means after Tonyhax International boots, remove the memorcyard on slot 2
On remove memorycard on slot 2 then load the game then while the intro screen is playing, you can put back the memorycard on slot 2 and still the game won't recognize the memorycard insterted. Test this only Sangoku Musou game.

It is completely intended that slot 2 is disabled throughout the game. That is what is supposed to happen.
The original Tonyhax v1.4.3 had none of these issues and works everytime without removing the memory card?

tonyhax does allow to use memory cards after removing the FPB card, it's why the patching code is different and I'm not using the FPB patch that @alex-free 's fork is using, which entirely disables the slot

tonyhax does allow to use memory cards after removing the FPB card, it's why the patching code is different and I'm not using the FPB patch that @alex-free 's fork is using, which entirely disables the slot

Good to know.
I'm considering just removing all the patching and requiring users remove it in my fork for the moment since I can't figure out what's going on with FreePSXBoot builder v2.1.

It is completely intended that slot 2 is disabled throughout the game. That is what is supposed to happen.
The original Tonyhax v1.4.3 had none of these issues and works everytime without removing the memory card?

Yes the original Tonyhax v1.4.3 only had none of these issues and works everytime without removing the memorycard. In line with it the same also on Tonyhax International v1.0.8 only playing without issues without removing the memorycard.

It is completely intended that slot 2 is disabled throughout the game. That is what is supposed to happen.

The original Tonyhax v1.4.3 had none of these issues and works everytime without removing the memory card?

Yes the original Tonyhax v1.4.3 only had none of these issues and works everytime without removing the memorycard. In line with it the same also on Tonyhax International v1.0.8 only playing without issues without removing the memorycard.

Everything supports the theory then. FreePSXBoot builder v2.1 is the cause...

I'm not that sure really. I'm not using the FPB stage 2, but only the first stage payload that fits in a single memory card sector and that has stood the same afaik since the exploit's inception. Also I clear the entire consoles' RAM.
I've not changed the anti-FPB patch since I added it in 1.3.3, so that code is probably not to blame either.
The only changes I made between 1.4.3 and 1.4.5 if my memory serves me right are related to the antipiracy patch that hijacks the EnterCriticalSection, but your AP code is entirely different.

I'm not that sure really. I'm not using the FPB stage 2, but only the first stage payload that fits in a single memory card sector and that has stood the same afaik since the exploit's inception. Also I clear the entire consoles' RAM.
I've not changed the anti-FPB patch since I added it in 1.3.3, so that code is probably not to blame either.
The only changes I made between 1.4.3 and 1.4.5 if my memory serves me right are related to the antipiracy patch that hijacks the EnterCriticalSection, but your AP code is entirely different.

In v1.4.4, you updated to FreePSXBoot builder v2.1 from v2.0.
In v1.0.9 of my fork, I updated to v2.1 from v2.0.
This is the same exact time that this issue began popping up for specific games. I think the FreePSXBoot exploit since v2.1 now causes some kind of lingering issue that affects some games. And by removing the memory card it prevents that lingering issue.

This is the commit that Tonyhax v1.4.3 and v1.0.8 used for FreePSXBoot: https://github.com/brad-lin/FreePSXBoot/commit/4888a9aa5852a60163798552bb3668f739484d2e
I just reverted to it and rebuilt Tonyhax International using the old version of FreePSXBoot from that commit. I am  still not resetting the RAM so that the original FreePSXBoot builder patches remain working.
test2.zip

This is the commit that Tonyhax v1.4.3 and International v1.0.8 used for FreePSXBoot: brad-lin/FreePSXBoot@4888a9a
I just reverted to it and rebuilt Tonyhax International using the old version of FreePSXBoot from that commit. I am still not resetting the RAM so that the original FreePSXBoot builder patches remain working. Should work, haven't tested yet.
test2.zip

Will test again when I get home... am at work for now.

Hmm, I maybe fixed it for real this time.
Before I tested on a SCPH-101, which apparently doesn't show the bug according to the test results above.
I just tried a SCPH-5501 using this new build and it works for Tekken 3.
I added these arguments to the FreePSXBuilder v2.1: -fastload -restore -nogp -bw
So although a regression occured with the default behavior in the v2.1 update, maybe these args can really fix it. I'll test out more of my consoles (It's just such an involved process to test each and every model unfortunately). I do not have a 9001 though.
test3.zip

https://github.com/brad-lin/FreePSXBoot/issues/76 shows what I was talking about with the issue of the original FreePSXBoot patch/your patch Socram8888.
For now I'm just requiring the user to remove any FreePSXBoot memory card, for many reasons: https://github.com/alex-free/tonyhax/issues/15#issuecomment-1473128126

The results are all the same. Best method for now is removing the memorycard after booting.

I think that the only way it worked before was that specific FreePSXBoot v2.0 commit + Socram8888 patch. I could try compiling the original Tonyhax (current version) with the old version of FreePSXBoot at that commit to prove the theory.

The results are all the same. Best method for now is removing the memorycard after booting.

I think that the only way it worked before was that specific FreePSXBoot v2.0 commit + Socram8888 patch. I could try compiling the original Tonyhax (current version) with the old version of FreePSXBoot at that commit to prove the theory.

ok will wait no probs.


Sound stops when opening inspector in Firefox

We've found that when a sound is playing in Firefox and you open the inspector (either with a keyboard shortcut, through the hamburger drawer menu in the top right or right clicking to inspect an element), the sound stops playing and any subsequent sound will not play. If you close the inspector and open it again, sounds play again. For instance, on the SoundJS home page, if you click the middle sound in the second from the top row in the demo grid and then inspect, the sound will stop. I mention that sound in particular because it has a longer duration, which allows you to start it and inspect before it ends.
I've tested this using a normal embedded html audio element and the issue does not seem to happen, which is why I've posted this here. I'm not sure if this is a browser bug or a bug in the framework, but I couldn't find any mention of it either here or on Mozilla's Firefox bug tracker.

It does appear to be a browser bug: https://bugzilla.mozilla.org/show_bug.cgi?id=1259831

Thanks @michaelwoods
Closing this bug.

Thanks @michaelwoods
Closing this bug.


Update some verbiage to make clear the concepts in each paragraph which…

… was updated, also updated .gitignore to ignore netbrain's ides' files.

Correction Jetbrains' ides

:+1:

It would be better to put that in your user's global gitgnore. We should probably do the same with DS_Store.


"There were errors loading some mods" message

Geode Issue

[X] I confirm that this bug is NOT related to a mod but directly to Geode Loader itself.

Steps to Reproduce
Idk i can give you my AnyDesk so you could understand why this thing happens.
Additional Information
Firstly i did a backup of .geode files and for some reason decided to delete the .geode files manually instead of deleting them in game. Then I saw this issue and deleted folders in unzipped folder. Still saw the message and then I placed .geode files back in the folder and deleted every uncompatible mod in the game. And still got this message.

This error occured because the mods were unported. Maybe if you went to the Geode page like it told you to, you wouldn't be posting this issue.

This error occured because the mods were not ported. Maybe if you went to the Geode page like it told you to, you wouldn't be posting this issue.

You understood it wrong. I have DELETED all this uncompatible this mods and still this message appears. The funny thing is if I press Show errors only button it says it didn't find any mods.

Okay, my apologies. This is actually a bug I encountered myself.

I wrote from my phone previously so here's images to be sure.

Try deleting the unzipped ones too maybe?

try looking at the logs


Dimensional Transceiver can't transmit/receive power directly

I'm using dimensional transceivers to transmit power from four Big Reactor turbines to my vibrant capacitor bank.  With builds 377 and 378 I've noticed that my dimensional transceivers don't connect directly to the power taps or my capacitor bank anymore (although the turbines are generating power, the capacitor bank wasn't receiving it). I had to connect energy conduit to the transceiver in order to get it to work again.  Is this intended?

-- System Details --
Details:
Minecraft Version: 1.7.10
Operating System: Windows 8.1 (amd64) version 6.3
Java Version: 1.8.0_45, Oracle Corporation
Java VM Version: Java HotSpot(TM) 64-Bit Server VM (mixed mode), Oracle Corporation
Memory: 279397416 bytes (266 MB) / 898613248 bytes (856 MB) up to<PHONE_NUMBER> bytes (1902 MB)
JVM Flags: 8 total; -XX:HeapDumpPath=MojangTricksIntelDriversForPerformance_javaw.exe_minecraft.exe.heapdump -XX:NewSize=512M -XX:SurvivorRatio=2 -XX:+DisableExplicitGC -XX:ParallelGCThreads=4 -XX:+UseConcMarkSweepGC -XX:+CMSIncrementalPacing -XX:+AggressiveOpts
AABB Pool Size: 0 (0 bytes; 0 MB) allocated, 0 (0 bytes; 0 MB) used
IntCache: cache: 0, tcache: 0, allocated: 12, tallocated: 94
FML: MCP v9.05 FML v<IP_ADDRESS>1 Minecraft Forge <IP_ADDRESS>1 26 mods loaded, 26 mods active
mcp{9.05} [Minecraft Coder Pack] (minecraft.jar) Unloaded->Constructed->Pre-initialized->Initialized->Post-initialized->Available->Available->Available->Available
FML{<IP_ADDRESS>1} [Forge Mod Loader] (forge-1.7.10-<IP_ADDRESS>1-1710ls.jar) Unloaded->Constructed->Pre-initialized->Initialized->Post-initialized->Available->Available->Available->Available
Forge{<IP_ADDRESS>1} [Minecraft Forge] (forge-1.7.10-<IP_ADDRESS>1-1710ls.jar) Unloaded->Constructed->Pre-initialized->Initialized->Post-initialized->Available->Available->Available->Available
appliedenergistics2-core{rv2-beta-33} [AppliedEnergistics2 Core] (minecraft.jar) Unloaded->Constructed->Pre-initialized->Initialized->Post-initialized->Available->Available->Available->Available
CodeChickenCore{<IP_ADDRESS>} [CodeChicken Core] (minecraft.jar) Unloaded->Constructed->Pre-initialized->Initialized->Post-initialized->Available->Available->Available->Available
NotEnoughItems{<IP_ADDRESS>} [Not Enough Items] (NotEnoughItems-1.7.10-<IP_ADDRESS>-universal.jar) Unloaded->Constructed->Pre-initialized->Initialized->Post-initialized->Available->Available->Available->Available
{000} [CoFH ASM] (minecraft.jar) Unloaded->Constructed->Pre-initialized->Initialized->Post-initialized->Available->Available->Available->Available
appliedenergistics2{rv2-beta-33} [Applied Energistics 2] (appliedenergistics2-rv2-beta-33.jar) Unloaded->Constructed->Pre-initialized->Initialized->Post-initialized->Available->Available->Available->Available
CoFHCore{1.7.10R3.0.2} [CoFH Core] (CoFHCore-[1.7.10]3.0.2-262.jar) Unloaded->Constructed->Pre-initialized->Initialized->Post-initialized->Available->Available->Available->Available
asielib{0.3.13} [asielib] (AsieLib-1.7.10-0.3.13.jar) Unloaded->Constructed->Pre-initialized->Initialized->Post-initialized->Available->Available->Available->Available
Baubles{<IP_ADDRESS>} [Baubles] (Baubles-1.7.10-<IP_ADDRESS>.jar) Unloaded->Constructed->Pre-initialized->Initialized->Post-initialized->Available->Available->Available->Available
BigReactors{0.4.3A} [Big Reactors] (BigReactors-0.4.3A.jar) Unloaded->Constructed->Pre-initialized->Initialized->Post-initialized->Available->Available->Available->Available
CarpentersBlocks{3.3.6} [Carpenter's Blocks] (Carpenter's Blocks v3.3.6 - MC 1.7.10.jar) Unloaded->Constructed->Pre-initialized->Initialized->Post-initialized->Available->Available->Available->Available
ChickenChunks{<IP_ADDRESS>} [ChickenChunks] (ChickenChunks-1.7.10-<IP_ADDRESS>-universal.jar) Unloaded->Constructed->Pre-initialized->Initialized->Post-initialized->Available->Available->Available->Available
ComputerCraft{1.73} [ComputerCraft] (ComputerCraft1.73.jar) Unloaded->Constructed->Pre-initialized->Initialized->Post-initialized->Available->Available->Available->Available
Waila{1.5.10} [Waila] (Waila-1.5.10_1.7.10.jar) Unloaded->Constructed->Pre-initialized->Initialized->Post-initialized->Available->Available->Available->Available
EnderIO{1.7.10-<IP_ADDRESS>8_beta} [Ender IO] (EnderIO-1.7.10-<IP_ADDRESS>8_beta.jar) Unloaded->Constructed->Pre-initialized->Initialized->Post-initialized->Available->Available->Available->Available
computronics{1.4.3} [Computronics] (Computronics-1.7.10-1.4.3.jar) Unloaded->Constructed->Pre-initialized->Initialized->Post-initialized->Available->Available->Available->Available
ExtraUtilities{1.2.4b} [Extra Utilities] (extrautilities-1.2.4b.jar) Unloaded->Constructed->Pre-initialized->Initialized->Post-initialized->Available->Available->Available->Available
FastCraft{1.21} [FastCraft] (fastcraft-1.21.jar) Unloaded->Constructed->Pre-initialized->Initialized->Post-initialized->Available->Available->Available->Available
IronChest{<IP_ADDRESS>2} [Iron Chest] (Iron-Chests-Mod-1.7.10.jar) Unloaded->Constructed->Pre-initialized->Initialized->Post-initialized->Available->Available->Available->Available
journeymap{5.0.1} [JourneyMap] (JourneyMap5.0.1_Unlimited_MC1.7.10.jar) Unloaded->Constructed->Pre-initialized->Initialized->Post-initialized->Available->Available->Available->Available
Mantle{1.7.10-0.3.2.jenkins184} [Mantle] (Mantle-1.7.10-0.3.2.jar) Unloaded->Constructed->Pre-initialized->Initialized->Post-initialized->Available->Available->Available->Available
StevesFactoryManager{A93} [Steve's Factory Manager] (StevesFactoryManagerA93.jar) Unloaded->Constructed->Pre-initialized->Initialized->Post-initialized->Available->Available->Available->Available
TConstruct{1.7.10-1.8.4.build937} [Tinkers' Construct] (TConstruct-1.7.10-1.8.4.jar) Unloaded->Constructed->Pre-initialized->Initialized->Post-initialized->Available->Available->Available->Available
aobd{2.4.0} [Another One Bites The Dust] (AOBD-2.4.0.jar) Unloaded->Constructed->Pre-initialized->Initialized->Post-initialized->Available->Available->Available->Available
GL info: ERROR RuntimeException: No OpenGL context found in the current thread.
AE2 Version: beta rv2-beta-28 for Forge <IP_ADDRESS>1
CoFHCore: -[1.7.10]3.0.2-262
Mantle Environment: Environment healthy.
TConstruct Environment: Environment healthy.
AE2 Integration: IC2:OFF, RotaryCraft:OFF, RC:OFF, BC:OFF, MJ6:OFF, MJ5:OFF, RF:ON, RFItem:ON, MFR:OFF, DSU:ON, FZ:OFF, FMP:OFF, RB:OFF, CLApi:OFF, Waila:ON, InvTweaks:OFF, NEI:ON, CraftGuide:OFF, Mekanism:OFF, ImmibisMicroblocks:OFF, BetterStorage:OFF

Behavior not reported properly, closing.  I'll submit a new bug after more testing to determine the actual issue.


The model produces untranslatable actions

I try to reproduce evalution only results using the checkpoints you provided.
The actions generated by the model (general-off2on-digirl) cannot be decoded.
Copying the AVD folder from /home/xyz/.android/avd/test_Android.avd to /home/xyz/.android/avd/test1.avd
Starting the Emulator
executing command /home/xyz/.android/emulator/emulator -avd test1 "-no-audio" "-skip-adb-auth" "-no-boot-anim" "-gpu" "auto" "-no-snapshot-save" -port 5554
connected!
Saving observation!
history: []
prompt: Previous Actions: Goal: What's a good restaurant in Seattle?
Getting observation from emulator 0: {'prompt': "Previous Actions: Goal: What's a good restaurant in Seattle?", 'image_feature': tensor([-0.3622,  2.5739, -0.0125,  ...,  0.2995,  1.8789, -0.5472]), 'task': "What's a good restaurant in Seattle?", 'image_path': '/home/xyz/logs/ckpts/general-off2on-digirl/images/test1/1723621834.599621_0.png', 'video_path': None}
Environment stpes 1
getting actions!
raw action: foloseste cauta incadr solutie incadr diferenta diferenta multumescgardinenbouchage expoziți insotit rosii foloseste ediți incadrprezinta senzati rosii gasest ediți expoziți Craciun Craciun edițiDatoritaDatorita tarziu duhovnic Clickfunnel Clickfunnelbouchage incalzirebouchage edițisuntetimunicipiul clientii duhovnic psiho duhovnic placut psiho serrurier foloseste Clickfunnel inregistrat folosestesunteti Clickfunnel diferenta rosii multumescDatorita senzatisunteti clientii duhovnic serrurier senzati solutieinformatiile inregistrat placut Clickfunnel inregistrat
list index out of range
Failed to translate action: foloseste cauta incadr solutie incadr diferenta diferenta multumescgardinenbouchage expoziți insotit rosii foloseste ediți incadrprezinta senzati rosii gasest ediți expoziți Craciun Craciun edițiDatoritaDatorita tarziu duhovnic Clickfunnel Clickfunnelbouchage incalzirebouchage edițisuntetimunicipiul clientii duhovnic psiho duhovnic placut psiho serrurier foloseste Clickfunnel inregistrat folosestesunteti Clickfunnel diferenta rosii multumescDatorita senzatisunteti clientii duhovnic serrurier senzati solutieinformatiile inregistrat placut Clickfunnel inregistrat, terminating the environment
Saving observation!
history: [AndroidAction(action_type=<ActionType.TaskImpossible: 7>, touch_point=None, lift_point=None, typed_text=None)]
prompt: Previous Actions: "action_type": "STATUS_TASK_COMPLETE", "touch_point": "[-1.0, -1.0]", "lift_point": "[-1.0, -1.0]", "typed_text": "" Goal: What's a good restaurant in Seattle?
skipping evaluation due to same images
Previous Actions: "action_type": "STATUS_TASK_COMPLETE", "touch_point": "[-1.0, -1.0]", "lift_point": "[-1.0, -1.0]", "typed_text": "" Goal: What's a good restaurant in Seattle?

The previous action is already STATUS_TASK_COMPLETE, so your process should already be ended. Did you modify this logic?

Closed due to inactivity.

There might be some problems with the config.json file and I just deleted it. I did not observe strange things using the checkpoints stored on Google Drive. Would you like to delete the config.json file and try again? @mousewu
This issue might be a relevant one with #16 .

Solution update:
Please don't use the configuration above. Instead, to load existing checkpoints, modify save_path instead of policy_lm. Solution thread can be found in https://github.com/DigiRL-agent/digirl/issues/16.
Checkpoint from HF/Google Drive shouldn't matter.
Closing due to inactivity.