Does not work in SystemJS and nodewebkit from 2.9.15 onwards

Since upgrading from 2.9.14 to 2.9.15, bluebird throws an invalid invocation error when performing Promise.all() (possibly others, Promise.resolve() works fine). This is only an error when run through System JS and nwjs (nodewebkit). 2.9.15 seems to be when it adds the browser version of bluebird.
Loading it through nodewebkit with a direct CDN link seemed to work fine.
See this for reproduction steps: https://github.com/NervosaX/bluebird-nw-bug
The stack trace is:
TypeError: Illegal invocation
    at n.2.n._queueTick (https://npm.jspm.io/bluebird@2.9.15/js/browser/bluebird.js:2:2630)
    at n.2.n.invoke (https://npm.jspm.io/bluebird@2.9.15/js/browser/bluebird.js:2:2165)
    at e.23.e.exports.e._then (https://npm.jspm.io/bluebird@2.9.15/js/browser/bluebird.js:4:3618)
    at e.23.e.exports.e.then (https://npm.jspm.io/bluebird@2.9.15/js/browser/bluebird.js:4:1997)
    at file:///home/adam/Programming/js/bluebirdnw/dist/index.html:17:14
    at D (https://jspm.io/es6-module-loader@0.16.5.js:1:7439)
    at I (https://jspm.io/es6-module-loader@0.16.5.js:1:7071)
    at O.7.O.when (https://jspm.io/es6-module-loader@0.16.5.js:1:10745)
    at w.7.w.run (https://jspm.io/es6-module-loader@0.16.5.js:1:9781)
    at e.3.e._drain (https://jspm.io/es6-module-loader@0.16.5.js:1:1740)
    at 3.e.drain (https://jspm.io/es6-module-loader@0.16.5.js:1:1394)
    at process._tickCallback (node.js:375:11)

@NervosaX just to be clear - this fails in 2.9.25 too right?

Nevermind, verified failure on 2.9.25

This does not reproduce when doing <script src="./bluebird.js"></script> instead of using SystemJS in nw and also works correctly when using SystemJS in the browser http://jsfiddle.net/0voy1u7L/ , the suspect is detecting the scheduler mechanism.

Wonderful, glad my ticket was thorough enough! Will use your workaround in the meantime.

@NervosaX thanks for the detailed issue - can you please verify it worked for you?

@benjamingr
I seem to be getting the following error now:
Uncaught TypeError: undefined is not a functionbluebird.js:3422 31.schedulebluebird.js:248 2.Async._queueTickbluebird.js:186 AsyncSettlePromisesbluebird.js:2486 23.module.exports.Promise._queueSettlePromisesbluebird.js:2499 23.module.exports.Promise._fulfillUncheckedbluebird.js:2422 23.module.exports.Promise._fulfillbluebird.js:2325 23.module.exports.Promise._resolveCallbackbluebird.js:3729 resolveFromThenable

Which is here:
          var version = process.versions.node.split(".").map(Number);
          schedule = (version[0] === 0 && version[1] > 10) || (version[0] > 0) ? function(fn) {
            global.setImmediate(fn); <-------------
          } : process.nextTick;

It is complaining that global.setImmediate does not exist. There is global.setTimeout. I would say this is an incompatability with node webkit now.

I would say this is related to ticket #525

@benjamingr pls fix

I'll look into it tomorrow, I think we can just explicitly detect node webkit and use process.nextTick there.

@NervosaX  does it work for you in 2.9.27? I added capability to run tests in nw and they pass. It also changed scheduler to be used in nw to MutationObserver since it's faster than setImmediate and not as buggy as nextTick.

@petkaantonov Seems to be working as normal in 2.9.27, both in browser and through nw. Thanks heaps for the fix.


Regex Cleanup

Regex is not needed for a static hexadecimal string.
https://yara.readthedocs.io/en/stable/writingrules.html#hexadecimal-strings
This signature still slows down scanning, and will fail if you have --fail-on-warnings enabled.
I would need the full sample to make a PR to fix the whole signature.

This signature matches up to 4 variants of SLOWPULSE which in general has very different patches applied across the name. This is why the rule is so lax and 'slow'. Your change here appears a valid improvement, will likely merge.


df Ignores Vendor Prefix Preference

Atom 1.0.19 / emmet-atom 2.3.13
In Atom, if i set "css.autoInsertVendorPrefixes": false in my preferences.json, df (display: flex) will still try to expand with prefixes but d:f (with a colon) will expand unprefixed as expected.

Other flex properties like fxwn expand correctly with & without the colon:

It might be related to https://github.com/emmetio/emmet/issues/401.

The same issue for Stylus.

this is driving me crazy

Same

Try to disable Can I Use in preferences as well:
"caniuse.enabled": false

Thanks, that's fixed it!
I had "caniuse.vendors": "" but not "caniuse.enabled": false

This is driving me insane. Where do I insert "caniuse.enabled": false?

Why do caniuse.vendors and caniuse.enabled have to be disabled for this to work as expected?


[Off-Chain] Add EventsReplayClient Generic Event Listener for BlockClient and DelegationClient

Summary
Human Summary
This PR converts the existing BlockClient into an implenentation of the generic EventsReplayClient which subscribes to and listens for on chain events and maps them into the desired type of the implemented EventsReplayClient
BlockClient -> EventsReplayClient[Block]
DelegationClient -> EventsReplayClient[DelegateeChange]
These new client interfaces have their own methods which wrap those exposed by the EventsReplayClient
AI Summary

Summary generated by Reviewpad on 07 Dec 23 00:21 UTC
This pull request includes the following changes:

The file errors.go has been deleted. It contained error definitions for the events query client.

The file relay_verifier.go has been modified to update the assignment of the currentBlock variable.

The file suppliers.go has been modified to move the function hostToWebsocketURL to the end of the file and update import paths.

The file event.proto has been added to define a protocol buffer message for an application's delegatee gateway changes.

A comment in a file was updated to change the word "serialised" to "serialized".

The Makefile was updated to change the URL in the go_docs target.

A comment in a file was updated to rename a variable from blocksClient to blockClient.

The file session.go has been modified to change how the LastNBlocks function is called.

A new file called replay_client.go has been added to handle event replay functionality.

A new file called godoc.go has been added to provide documentation for the pkg/client/block package.

The file msg_server_delegate_to_gateway.go has been updated to add a new function and update import paths.

The file msg_server_undelegate_from_gateway_test.go has been modified to update import paths and add event assertions.

A new file called replay_client_example_test.go has been added to demonstrate the usage of the EventsReplayClient.

The file pkg/client/events/websocket/errors.go has been deleted.

The file testclient/testeventsquery/client.go has been modified to update import paths.

A new file called replay_client_example_test.go has been added to demonstrate the usage of the EventsReplayClient.

The file events_query.md has been deleted.

The file replay_client_example_test.go has been modified to change how the latest block is retrieved.

The file in the pkg/client/block package has been modified to update an initialization comment.

A new line has been added to a function declaration in a file.

The file query_supplier.go has been modified to remove a line.

Comments in file(s) have been updated to correct a typo.

A new file called godoc.go has been added to provide documentation for the pkg/client/delegation package.

The file block.go has been modified to update import paths and functionality related to block events.

The file application.go has been modified to rename a variable and add new functions.

The file pkg/relayer/cmd/cmd.go has been modified to update comments and add new flags.

A comment in a file has been updated to correct a typo.

A comment in a file has been updated to correct a typo.

The file pkg/client/events_query/websocket/connection.go has been renamed to pkg/client/events/websocket/connection.go.

Please review these changes and let me know if there's anything specific you'd like me to check in more detail.

Issue

Fixes N/A

Type of change
Select one or more:

[x] New feature, functionality or library
[ ] Bug fix
[ ] Code health or cleanup
[ ] Documentation
[ ] Other (specify)

Testing

[x] Run all unit tests: make go_develop_and_test
[x] Verify Localnet manually: See the instructions [here](TODO: add link to instructions)

Sanity Checklist

[x] I have tested my changes using the available tooling
[x] I have performed a self-review of my own code
[x] I have commented my code, updated documentation and left TODOs throughout the codebase

@h5law Skipping this over for now but please request a review when we should take look.

@h5law Leaving a comment just to avoid miscommunication. Re-request a review once this is ready for another look.

@Olshansk @bryanchriswhite Should be good to go now <3


Use lazy pools instead of lifo pools

Amazing, thank you! I'll test this out in the morning and let you know how it goes


Use newer dockerfile for build

Using the current docker-based build doc, i.e. with ubuntu_18.04-build-tools.dockerfile, I get:
src/view.cpp:7:10: fatal error: curses.h: No such file or directory
 #include <curses.h>
          ^~~~~~~~~~
compilation terminated.

So I tried with the newer ubuntu_20.10-build-tools.dockerfile, and it works better:
docker build --tag=newsboat-build-tools --file=docker/ubuntu_20.10-build-tools.dockerfile docker

docker run --rm --mount type=bind,source=$(pwd),target=/home/builder/src --user $(id -u):$(id -g) newsboat-build-tools make -j

docker run --rm -it --mount type=bind,source=$(pwd),target=/home/builder/src newsboat-build-tools ./newsboat

Coverage remained the same at 58.234% when pulling 365461f04c4e48ebabb9adf707ab313400b400d9 on Alkarex:patch-1 into f5fdd5425df65a8b65a8fc3f05d116da8fbf809f on newsboat:master.

Thanks! 18.04 is supposed to work, though.
I'm currently trying to reproduce this locally. The first attempt failed, probably because I have the old ubuntu:18.04 image cached; I removed that and retrying.
In principle I'm okay with merging this, I just want to figure out what went wrong with the 18.04 dockerfile.

Nope, can't reproduce no matter how I try. I deleted all the images I ever had, I pulled down ubuntu:18.04@sha256:122f506735a26c0a1aff2363335412cfc4f84de38326356d31ee00c2cbe52171 which is precisely the image that's currently on Docker Hub for amd64 — and still it all compiles fine, with no errors related to curses.h. @Alkarex, perhaps you got an old ubuntu image in docker? Can you please run docker images --digests | grep ubuntu | grep 18.04 and show the output? I'll get the exact same image (if it's still on the Hub) and see if I can reproduce then.

It might be a false alert, sorry, as it looks like running make clean first also solves the problem (maybe some wrong make rules somewhere).

docker images --digests | grep ubuntu | grep 18.04
ubuntu                 18.04               sha256:122f506735a26c0a1aff2363335412cfc4f84de38326356d31ee00c2cbe52171   3339fde08fc3        13 days ago         63.3MB

I tried a few things, so I might have build first with 20.10 and then with 18.04, and got the error. But I would expect the make clean to revert to a clean state.

Okay, that's the same base image as I have.
Did you run make outside of Docker prior to building inside Docker?
Does it work if you run make distclean and retry? (distclean is stronger than clean).
(Sorry, Newsboat's build system is a bit baroque, closer to autotools than to modern stuff like CMake and package managers like Cargo and NPM.)

It indeed seems to work after:
docker run --rm --mount type=bind,source=$(pwd),target=/home/builder/src --user $(id -u):$(id -g) newsboat-build-tools make distclean

I think I tried to build first with 20.10, then make clean from Docker, then build with 18.04, which gave the error.

I think I tried to build first with 20.10, then make clean from Docker, then build with 18.04, which gave the error.

Thanks! I reproduced the failure now. It's caused by the fact that make clean doesn't remove config.mk, which contains include paths for Ncurses headers. Ubuntu 18.04 needs them while 20.10 doesn't.
I'm verifying the fix and will submit a separate PR adjusting clean to do the right thing. And I'll merge this PR anyway since it's 2021 and we should probably encourage people to use the latest LTS for their experiments.
Thanks for helping me debug this!

P.S. The latest LTS is 20.04, while 20.10 is the latest "normal"


Feature Request: Support for other graphviz layout engines

Would it be possible to add support for the layout engines other than dot for the preview and export functionality?

Here my PR:
https://github.com/joaompinto/vscode-graphviz/pull/33


vm-operator pod cannot get resource lock

K8s: v1.17.8
Operator: 0.8.0
After fresh installation there are many logs entries about getting resource lock.
I tried to add permissions to the Role leader-election-role, but with no luck.
- apiGroups:
  - coordination.k8s.io
  resources:
  - leases
  verbs:
  - get
  - list
  - watch
  - create
  - update
  - patch
  - delete

The error messages:
{
  "level": "error",
  "ts":<PHONE_NUMBER>.2926767,
  "msg": "error retrieving resource lock monitoring-system/57410f0d.victoriametrics.com: leases.coordination.k8s.io \"57410f0d.victoriametrics.com\" is forbidden: User \"system:serviceaccount:monitoring-system:vm-operator\" cannot get resource \"leases\" in API group \"coordination.k8s.io\" in the namespace \"monitoring-system\"\n",
  "stacktrace": "github.com/go-logr/zapr.(*zapLogger).Error\n\tgithub.com/go-logr/zapr@v0.2.0/zapr.go:132\nk8s.io/klog/v2.(*loggingT).output\n\tk8s.io/klog/v2@v2.4.0/klog.go:919\nk8s.io/klog/v2.(*loggingT).printf\n\tk8s.io/klog/v2@v2.4.0/klog.go:750\nk8s.io/klog/v2.Errorf\n\tk8s.io/klog/v2@v2.4.0/klog.go:1462\nk8s.io/client-go/tools/leaderelection.(*LeaderElector).tryAcquireOrRenew\n\tk8s.io/client-go@v12.0.0+incompatible/tools/leaderelection/leaderelection.go:325\nk8s.io/client-go/tools/leaderelection.(*LeaderElector).acquire.func1\n\tk8s.io/client-go@v12.0.0+incompatible/tools/leaderelection/leaderelection.go:245\nk8s.io/apimachinery/pkg/util/wait.BackoffUntil.func1\n\tk8s.io/apimachinery@v0.20.2/pkg/util/wait/wait.go:155\nk8s.io/apimachinery/pkg/util/wait.BackoffUntil\n\tk8s.io/apimachinery@v0.20.2/pkg/util/wait/wait.go:156\nk8s.io/apimachinery/pkg/util/wait.JitterUntil\n\tk8s.io/apimachinery@v0.20.2/pkg/util/wait/wait.go:133\nk8s.io/client-go/tools/leaderelection.(*LeaderElector).acquire\n\tk8s.io/client-go@v12.0.0+incompatible/tools/leaderelection/leaderelection.go:244\nk8s.io/client-go/tools/leaderelection.(*LeaderElector).Run\n\tk8s.io/client-go@v12.0.0+incompatible/tools/leaderelection/leaderelection.go:202"
}

Hello, i've tested version from helm chart repository and master branch and it seems to be ok.
Can you specify your deployment method?
I hope, new release will be build soon with those fixes.

I followed this instruction.

I experience the same issue, installed the operator using the Kustomize approach. It's my impression that the Kustomization is missing the role.
Applying this manually solved the issue:
apiVersion: rbac.authorization.k8s.io/v1
kind: Role
metadata:
  name: vm-operator-leader-election-role-2
  namespace: monitoring-system
rules:
- apiGroups:
  - coordination.k8s.io
  resources:
  - leases
  verbs:
  - get
  - list
  - watch
  - create
  - update
  - patch
  - delete
---
apiVersion: rbac.authorization.k8s.io/v1
kind: RoleBinding
metadata:
  name: vm-operator-leader-election-rolebinding-2
  namespace: monitoring-system
roleRef:
  apiGroup: rbac.authorization.k8s.io
  kind: Role
  name: vm-operator-leader-election-role-2
subjects:
- kind: ServiceAccount
  name: vm-operator-vm-operator
  namespace: monitoring-system

I've tagged new release. It must contain fix for this issue.

@f41gh7 0.9.0 works. thanks!
A question out of the issue scope: should the leader-election-role be in the monitoring-system namespace? Now it in the default namespace.

@f41gh7 0.9.0 works. thanks!
A question out of the issue scope: should the leader-election-role be in the monitoring-system namespace? Now it in the default namespace.

it should be at the same namespace with operator deployment, fixed it at master branch, soon will tag patch release.


Interactive website for useful Git commands

What does this PR do?
Add an interactive website link to learn useful commands using git in English.
For resources
Description
Why is this valuable (or not)?
How do we know it's free?
It's a link to a webpage.
For book lists, is it a book? For course lists, is it a course? etc.
It's an interactive resource
Checklist:

[x] Read our contributing guidelines.
[x] Search for duplicates.
[x] Include author(s) and platform where appropriate.
[x] Put lists in alphabetical order, correct spacing.
[x] Add needed indications (PDF, access notes, under construction).
[x] Used an informative name for this pull request.

Follow-up

Check the status of GitHub Actions and resolve any reported warnings!

I wouldn't consider this an interactive tutorial. Not 100% sure if there is a place for cheat sheets or not.

@Thenlie Could you suggest what changes you need, please?

yes we have a list of cheatsheets!

I wouldn't consider this an interactive tutorial. Not 100% sure if there is a place for cheat sheets or not.

@Thenlie Could you suggest what changes you need, please?

Yes sorry I didn't know at the time, try https://github.com/EbookFoundation/free-programming-books/blob/main/more/free-programming-cheatsheets.md


Black screen on Android (Firefox and Chrome)

I'm working on some creation using three-gpu-pathtracer, and it works flawlessly on desktop. But then I wanted to try it on my android mobile and only got a black screen (no render, but the GUI loads ok). After some remote debugging I tried to display your demo files (Material Test Orb, Physically Based Materials, Lego Models, etc.) on my mobile to compare, but I got the same result: black screen... Anyone can confirm?
First thing I could think of was testing if WebGL2 is enabled = YES.
I'm running the 0.04 npm version.
(should I try the latest files to see if the M1 fix works here?)
Platform:

Device: MOBILE (Huawei Mate 20 Pro)
OS: Android
Browser: Chrome and Firefox
Three.js version: 0.139.2
Library version: 0.0.4

Here are the logs from the "Material Test Orb" demo scene:

Here are the logs from my scene:
(I'm not sure why I'm getting the extra IOR error here... Have to look at it.)

Thanks in advance!

Without the device it's hard to recommend too much - we might need some help understanding the issue. If you could narrow down the issue by comment out some of the shader code - ie just reading one texture since that seems to be the core of the issue - that would help.
One thing that might help - from this page is the OES_texture_float_linear extension supported?

halfloat type


⚠ Bofrost.at has degraded performance

In 8253e9a, Bofrost.at (https://www.bofrost.at) experienced degraded performance:

HTTP code: 200
Response time: 1766 ms

Resolved: Bofrost.at performance has improved in 44ffb56.


Exception when using Azurite HTTPS with Storage Explorer

v3.7.0
Create cert with mkcert
choco install mkcert
mkcert -install
mkcert <IP_ADDRESS>

Start Azurite with cert:
azurite --oauth basic --cert c:\temp\<IP_ADDRESS>.pem --key c:\temp\<IP_ADDRESS>-key.pem
Open Storage Explorer
Create a new connection to Azurite with this connection string:
DefaultEndpointsProtocol=https;AccountName=devstoreaccount1;AccountKey=Eby8vdM02xNOcqFlqUwJPLlmEtlCDXJ1OUzFT50uSRZ6IFsuFq2UVErCz4I6tq/K1SZFPTOtr/KBHBeksoGMGw==;BlobEndpoint=https://<IP_ADDRESS>:10000/devstoreaccount1;QueueEndpoint=https://<IP_ADDRESS>:10001/devstoreaccount1;
When you navigate to Blob containers in storage explorer, you'll see this:

Apparently, this can be solved with:
https://www.npmjs.com/package/ssl-root-cas
The current guidance of setting NODE_TLS_REJECT_UNAUTHORIZED=0 is not secure because it disables it for every Node app on the user's machine.
I researched using NODE_OPTIONS and NODE_EXTRA_CA_CERTS, but neither worked for me.
I also tried creating a chain using these steps, https://github.com/FiloSottile/mkcert/issues/76#issuecomment-546054007
But it looks like Storage Explorer rejects any chain with a self-signed cert.

This was resolved by importing the SSL cert.  See comment here: https://github.com/microsoft/AzureStorageExplorer/issues/2598#issuecomment-616765993


[SPARK-7996] Deprecate the developer api SparkEnv.actorSystem

Changed SparkEnv.actorSystem to be a function such that we can use the deprecated flag with it and added a deprecated message.

Merged build triggered.

Merged build started.

Test build #34537 has started for   PR 6731 at commit 9610b08.

Test build #34537 has finished for   PR 6731 at commit 9610b08.

This patch fails Scala style tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Merged build triggered.

Merged build started.

Test build #34538 has started for   PR 6731 at commit 9ed89e7.

Test build #34538 has finished for   PR 6731 at commit 9ed89e7.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Changed SparkEnv.actorSystem to be a function such that we can use the deprecated flag with it and added a deprecated message.

I can add @deprecated flat to a val. See

Merged build triggered.

Merged build started.

Test build #34614 has started for   PR 6731 at commit be43817.

Test build #34614 has finished for   PR 6731 at commit be43817.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Thanks - merging this in.


Updating Payment Methods in Bolt Card Factory doesn't work

It's very easy to replicate the issue. Here is the video demonstrating the problem:
https://github.com/NicolasDorier/boltcards-plugin/assets/5191402/89168ad4-6fc6-4506-a35d-96d7242cf58d

In addition, if only one payment method was initially allowed, there is no choice to add in more when editing a bolt card factory:

Also, any newly created boltcard factories will have the same single choice.
Also, unticking the single choice and saving the factory gives an exception:
An unhandled exception occurred while processing the request.
InvalidOperationException: The view 'UpdateBoltcardFactory' was not found. The following locations were searched:
/Views/UIBoltcardFactory/UpdateBoltcardFactory.cshtml
/Views/Shared/UpdateBoltcardFactory.cshtml
/Pages/Shared/UpdateBoltcardFactory.cshtml
/UpdateBoltcardFactory.cshtml

Correction, to add in more payment methods I need to add in a new payment method for the store first. However, still buggy
This save change is successful:

This save change fails (goes back to above)

This save change results in an exception instead of an invalid state notice and goes back to top state:


Various build fixes for FreeBSD

This PR incorporates changes from https://github.com/freedomtan/tensorflow/commit/ffd86f605bfdbe6f209c1fa707089d6010f0b719, https://github.com/tensorflow/tensorflow/pull/25471 and my own.
This is not ready to be merged yet, as there is a problematic change in last commit. In third_party/hwloc/BUILD.bazel file we only need to have _INCLUDE_PRIVATE_HWLOC_AUTOIGEN_CONFIG_H_LINUX_SUBS items in _INCLUDE_PRIVATE_HWLOC_AUTOIGEN_CONFIG_H_COMMON_SUBS when we are building on Linux. I wasn't able to express that in Bazel, though. Nested selects, as well as ifs in BUILD files are prohibited. How do I go about this change?
Fixes https://github.com/tensorflow/tensorflow/issues/28113
Obsoletes https://github.com/tensorflow/tensorflow/pull/25471

Signed CLA.

@arrowd please let us know if this is still WIP ?

@arrowd please let us know if this is still WIP ?

Yes, I still need help with including _INCLUDE_PRIVATE_HWLOC_AUTOIGEN_CONFIG_H_LINUX_SUBS into
template_rule(
name = "include_private_hwloc_autogen__config_h",
...

in third_party/hwloc/BUILD.bazel

Let's just omit that hwloc change from the PR for now and get this merged?

Let's just omit that hwloc change from the PR for now and get this merged?

can you please push changes again after removing 'hwloc'

Ping. Can we get this in?

Another bump.

I take it, this didn't make it into beta1 release?

Unfortunately did not. But it will be definitely in 2.0 release candidates, and any other release we do.


Use a queue and do actual Fisher-Yates shuffling for the Study view.

Fixed with commit 14cf32d4fb17c53b4bea882c9069eb77221a88b2


Request: @mentions

@mention similar to functionality in github @SachaG

Hey folks, I created a new issue with some guidelines on how we could do this for Nova : #1457
This issue is a good oldie, if someone wants to get their hands dirty on this, I guess it can be a lot of fun!
Closing this (oldest Telescope) issue, happy hacking 🔥


what is m gate?

https://github.com/microsoft/qiskit-qir/blob/89505330aabb5216b5565b677f46d468c87ce786/src/qiskit_qir/visitor.py#L20
I don't think Qiskit  has a gate QuantumCircuit.m...

@qci-amos It is a alias for measure which maps to mz or measure depending on allocation mode. This is no longer used in the latest pyqir release.


Deploy and configure Coder for developers within this GitHub organization

Deploy and configure Coder for all developers in the organization, providing them with a personal and configurable work environment.

Should we be closing issues providing functionalities to developers before developers have had a chance to test it and accept the functionality?

Totally agree. Also, before closing a pull request, documentation and training should be provided it the content of it impact developers directly.


Azure CLI version not updated to latest in pipeline

Note
Issues in this repo are for tracking bugs, feature requests and questions for the tasks in this repo
For a list:
https://github.com/Microsoft/azure-pipelines-tasks/tree/master/Tasks
If you have an issue or request for the Azure Pipelines service, use developer community instead:
https://developercommunity.visualstudio.com/spaces/21/index.html )
Required Information
Entering this information will route you directly to the right team and expedite traction.
Question, Bug, or Feature?
Type: Bug
Enter Task Name: Azure CLI V2.0
list here (V# not needed):
https://github.com/Microsoft/azure-pipelines-tasks/tree/master/Tasks
Azure CLI V2.0
Environment

Server - Azure Pipelines or TFS on-premises?

If using TFS on-premises, provide the version:

If using Azure Pipelines, provide the account name, team project name, build definition name/build number:
Release pipeline: Azure Connection Pipeline
Team: MSN OneService

Agent - Hosted or Private:

If using Hosted agent, provide agent queue name:

If using private agent, provide the OS of the machine running the agent and the agent version:

Issue Description
[Include task name(s), screenshots and any other relevant details]
I have an Azure CLI V2.0 task set up in my pipeline, but in the log I see the version is not updated to latest. How can I updated it to latest version? Please see attached:

Task logs
2020-03-25T04:15:31.4193028Z ##[section]Starting: Azure CLI
2020-03-25T04:15:31.4311832Z ==============================================================================
2020-03-25T04:15:31.4312176Z Task         : Azure CLI
2020-03-25T04:15:31.4312707Z Description  : Run Azure CLI commands against an Azure subscription in a PowerShell Core/Shell script when running on Linux agent or PowerShell/Powershell Core/Batch script when running on Windows agent.
2020-03-25T04:15:31.4313217Z Version      : 2.0.7
2020-03-25T04:15:31.4313470Z Author       : Microsoft Corporation
2020-03-25T04:15:31.4313839Z Help         : https://docs.microsoft.com/azure/devops/pipelines/tasks/deploy/azure-cli
2020-03-25T04:15:31.4314368Z ==============================================================================
2020-03-25T04:15:31.7101784Z [command]C:\Windows\system32\cmd.exe /D /S /C ""C:\Program Files (x86)\Microsoft SDKs\Azure\CLI2\wbin\az.cmd" --version"
2020-03-25T04:15:37.4339722Z azure-cli                         2.0.80 *
2020-03-25T04:15:37.4340657Z WARNING: You have 2 updates available. Consider updating your CLI installation. Instructions can be found at https://docs.microsoft.com/en-us/cli/azure/install-azure-cli
2020-03-25T04:15:37.4341128Z
2020-03-25T04:15:37.4341349Z command-modules-nspkg              2.0.3
2020-03-25T04:15:37.4341634Z core                              2.0.80 *
2020-03-25T04:15:37.4341928Z nspkg                              3.0.4
2020-03-25T04:15:37.4342212Z telemetry                          1.0.4
2020-03-25T04:15:37.4342389Z
2020-03-25T04:15:37.4342685Z Python location 'C:\Program Files (x86)\Microsoft SDKs\Azure\CLI2\python.exe'
2020-03-25T04:15:37.4343091Z Extensions directory 'C:\Users\svccbld.azure\cliextensions'
2020-03-25T04:15:37.4343335Z
2020-03-25T04:15:37.4343676Z Python (Windows) 3.6.6 (v3.6.6:4cf1f54eb7, Jun 27 2018, 02:47:15) [MSC v.1900 32 bit (Intel)]
2020-03-25T04:15:37.4343983Z
2020-03-25T04:15:37.4344228Z Legal docs and information: aka.ms/AzureCliLegal
2020-03-25T04:15:37.4344436Z
2020-03-25T04:15:37.4344542Z
2020-03-25T04:15:37.4344663Z
2020-03-25T04:15:37.4344765Z
2020-03-25T04:15:37.4345025Z Please let us know how we are doing: https://aka.ms/clihats
2020-03-25T04:15:37.4393662Z Setting AZURE_CONFIG_DIR env variable to: E:\agent_work_temp.azclitask
2020-03-25T04:15:37.4398411Z Setting active cloud to: AzureCloud
2020-03-25T04:15:37.4455016Z [command]C:\Windows\system32\cmd.exe /D /S /C ""C:\Program Files (x86)\Microsoft SDKs\Azure\CLI2\wbin\az.cmd" cloud set -n AzureCloud"
2020-03-25T04:15:38.7234110Z [command]C:\Windows\system32\cmd.exe /D /S /C ""C:\Program Files (x86)\Microsoft SDKs\Azure\CLI2\wbin\az.cmd" login --service-principal -u *** -p *** --tenant "
2020-03-25T04:15:41.8270647Z [
2020-03-25T04:15:41.8270957Z   {
2020-03-25T04:15:41.8271192Z     "cloudName": "AzureCloud",
2020-03-25T04:15:41.8271484Z     "id": "b17533a7-6c17-4384-9860-92f87f5debde",
2020-03-25T04:15:41.8271776Z     "isDefault": true,
2020-03-25T04:15:41.8272032Z     "name": "Storefronts OneService Prod",
2020-03-25T04:15:41.8272334Z     "state": "Enabled",
2020-03-25T04:15:41.8273062Z     "tenantId": "",
2020-03-25T04:15:41.8273301Z     "user": {
2020-03-25T04:15:41.8273682Z       "name": "***",
2020-03-25T04:15:41.8273935Z       "type": "servicePrincipal"
2020-03-25T04:15:41.8274136Z     }
2020-03-25T04:15:41.8274292Z   }
2020-03-25T04:15:41.8274424Z ]
2020-03-25T04:15:41.8356920Z [command]C:\Windows\system32\cmd.exe /D /S /C ""C:\Program Files (x86)\Microsoft SDKs\Azure\CLI2\wbin\az.cmd" account set --subscription b17533a7-6c17-4384-9860-92f87f5debde"
2020-03-25T04:15:43.0584658Z [command]C:\Windows\system32\cmd.exe /D /S /C "E:\agent_work_temp\azureclitaskscript1585109731691.bat"
2020-03-25T04:15:43.0790779Z
2020-03-25T04:15:43.0792506Z E:\agent_work\r125\a>az appconfig kv export --connection-string Endpoint=https://oneservice-appconfig-feedflight.azconfig.io;Id=jUL7-l1-s0:05CW4gOS4LFzmBchHyKF;Secret=Ix/RXcGXTIOE4gXuQhSw2asJP1EzUbEdBW+pmy2yMk8= -d file --label EUS --path E:\agent_work\r125\a/Msn.OneService.msn/SF.Artifacts/Service/release/localConfiguration --format json -y
2020-03-25T04:15:44.2498052Z Command group 'appconfig' is in preview. It may be changed/removed in a future release.
2020-03-25T04:15:45.0966762Z [command]C:\Windows\system32\cmd.exe /D /S /C ""C:\Program Files (x86)\Microsoft SDKs\Azure\CLI2\wbin\az.cmd" account clear"
2020-03-25T04:15:46.3512219Z ##[section]Finishing: Azure CLI
Troubleshooting
Checkout how to troubleshoot failures and collect debug logs: https://docs.microsoft.com/en-us/vsts/build-release/actions/troubleshooting
Error logs
2020-03-25T04:15:37.4340657Z WARNING: You have 2 updates available. Consider updating your CLI installation. Instructions can be found at https://docs.microsoft.com/en-us/cli/azure/install-azure-cli
2020-03-25T04:15:37.4341128Z
2020-03-25T04:15:37.4341349Z command-modules-nspkg              2.0.3
2020-03-25T04:15:37.4341634Z core                              2.0.80 *
2020-03-25T04:15:37.4341928Z nspkg                              3.0.4
2020-03-25T04:15:37.4342212Z telemetry                          1.0.4

Are you using private or hosted agent?

Ping. If you are using hosted agent, can you please paste complete debug logs and the agent name and version.

@Astersss
Feel free to reopen and provide required information if you are still facing the issue.


Date is not correctly saved

Issues are used to track bugs and feature requests.
Need help or have a general question? Ask on Stack Overflow (tag sqlite.swift).

Build Information

Include the SQLite.swift version, commit or branch experiencing the issue.
Mention Xcode and OS X versions affected.
How do do you integrate SQLite.swift in your project?

manual
CocoaPods
Carthage
Swift Package manager

SQLite.swift version = 0.92
Xcode version =  14.1
macOS version = 13.2.1
General guidelines

Be as descriptive as possible.
Provide as much information needed to reliably reproduce the issue.
Attach screenshots if possible.
Better yet: attach GIFs or link to video.
Even better: link to a sample project exhibiting the issue.

I use touch to create a new file ,zero bytes , like touch abcd.
then I read the modificationDate by using
 let modifyDate = try FileManager.default.attributesOfItem(atPath: wholePath)[.modificationDate] as? Date
its description like this
`▿ 2023-06-07 02:14:52 +0000

timeIntervalSinceReferenceDate : 707796892.7651631`

but after I fetch it from the db.sqlite, it turns out to be:
▿ 2023-06-07 02:14:52 +0000

timeIntervalSinceReferenceDate : 707796892.7650001

Other files which is larger than zero bytes are fine. Just this one. I am really sure before I save it in the db, it is 707796892.7651631
Don't know why

Precision is lost from the date formatter that is used internally to store the date.
If you need perfect precision you need to store dates as a double. Otherwise you cannot guarantee equality.

Precision is lost from the date formatter that is used internally to store the date.
If you need perfect precision you need to store dates as a double. Otherwise you cannot guarantee equality.

OK. I got it. I solved this by saving timestamp. Thanks for the reason.


Intregration into WordPress plugin

Hi,
I am looking to integrate Formeo into a plugin we are building for a client.  The builder will be in the admin area with the rendering of the form visible to frontend users.
I have enqueued the required scripts and have the form builder visible in the admin area but whenever I click on any Formeo buttons (such as edit field etc) the page reloads....any idea what is causing this?
Thanks in advance,
Will

Hey Will,
This is a bug I will address today. Thank you for catching this.
Kevin

That's great Kevin, thanks!


RFC: Force "dev" output in case of static builds

Static builds propagate all buildInputs resulting in a
nix-support/propagated-build-inputs for nearly every package,
retaining references to the entire build-closure. To avoid this, one
needs to add "dev" outputs to the package.
This commit forces "dev" outputs in case of static builds. That is,
static builds will fail to build without a functioning "dev" output.
This will break packages that require the propagated-build-inputs file
in the main output. An example here are Python packages.
https://github.com/NixOS/nixpkgs/issues/83667
Note I don't immediately intend to merge this, its just to further the discussion.

Motivation for this change
Things done

[x] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
Built on platform(s)

[x] NixOS
[ ] macOS
[ ] other Linux distributions

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
[ ] Tested execution of all binary files (usually in ./result/bin/)
[ ] Determined the impact on package closure size (by running nix path-info -S before and after)
[ ] Ensured that relevant documentation is up to date
[ ] Fits CONTRIBUTING.md.

Yes I think this is the natural and correct solution---if a big pill to swallow---for this. If we only do it when there are propagated deps, I think it will be safer, and something we can eventually do in all of nixpkgs.

This will break packages that require the propagated-build-inputs file
in the main output. An example here are Python packages.

This is interesting. We can in fact put the file in the out output and it will still work. In general, I am not aware of how much "building" happen in the average python derivation vs just downloading some source---maybe it makes sense the same (deduplicated, e.g. with content-addressed derivation outputs or just hard links inside)  out would be referred to by different dev depending on what the chosen dependencies are.

How to handle cases where different packages propagate different versions of a library, e.g. openssl?

@FRidh I am not sure that is a new problem: if you depend on an exe that link openssl, you shouldn't be getting that package's dev output anyways. If you really do depend on two libraries that use two different versions, that is already a potential problem---and a fundamental static linking headache all things Nixpkgs aside.

 Then if foo depends on bar which depends on baz, a static build of foo could depend on bar.staticLibs which would propagate the appropriate things.

@michaelpj to be clear, that file does go in dev. I suppose we could have dev and staticLibs but I am not sure why we'd want that, to be honest. It is a good to be more precise on intent of course, but all of this (dev vs out, the propagation mechanism, etc.) is pretty loose on intent---I rather just not use propagated dependencies than some half-way thing.

This whole nix-support/propagated-build-inputs is not necessarily needed, because at eval time it is already known what dependencies are needed; the file just reduces unnecessary garbage collection.

If we do this, I'd like to do a run of static-haskell-nix builds against it before we merge.

It might be nice to still do this?

Ping @FRidh, would be nice to have, if you have any appetite to pick this up.


Move dependencies

fixes #16, #10

Test is failing... :-/
node node_modules/jest/bin/jest.js
 FAIL  ./App.test.js
  ● Test suite failed to run

    Cannot find module 'react-native/packager/src/Resolver/polyfills/babelHelpers.js' from 'setup.js'

      at Resolver.resolveModule (node_modules/jest-resolve/build/index.js:169:17)
      at Object.<anonymous> (node_modules/jest-expo/src/setup.js:5:9)

Can this be published on npm registry?

@piranna yes working on it. I think that it didn't published because I had an emoji in the semantic commit message 😅

I think that it didn't published because I had an emoji in the semantic commit message

Lol X-D Just before publishing I do npm version <whatever> to upgrade the version number, and it also do a commit just for that version upgrade and creates a tag for it, that later becames a release on Github. Very convenient command :-)

In this case, you could do npm version patch or npm version minor.

1.1.1 is published. I use semantic-release for publishing the package.

I use semantic-release for publishing the package.

Good idea :-) Thanks! :-D

Please publish


iALS tuning strategy of doubling dimensions

Codecov Report

Merging #95 (495514c) into main (2e7fd31) will increase coverage by 0.45%.
The diff coverage is 94.82%.

@@            Coverage Diff             @@
##             main      #95      +/-   ##
==========================================
+ Coverage   95.72%   96.17%   +0.45%
==========================================
  Files          55       56       +1
  Lines        3366     3403      +37
==========================================
+ Hits         3222     3273      +51
+ Misses        144      130      -14


Does not work Skin Changer

When you choose a skin for weapons, then instead of the name of the skin simply "?????????"

Skinchanger does work.


Javascript error on SharePoint Framework webparts in classic pages

Category
[x] Bug
Observed Behavior
Since yesterday, multiple javascript errors are ocurring in all classic pages that contains SPFx webparts on my tenant.

These errors occurs in a file called "https://spoprod-a.akamaihd.net/files/sp-client-prod_2018-04-27.028/sp-classic-page-assembly_pt-br_2b70de5aeec66500455fe2dbb40e063f.js" and only happens on classic pages. The same webparts works well on modern pages...
Anyone know how to solve it? Thanks!

Sorry for the long delay - I'm assuming that this has been addressed for a long time.  If you are still running into issues, please open a new issue.


source_id native_nominal_resolution corrections

I have reviewed the native_nominal_resolution recorded for each model.  I could only check models with latxlon grids with approximately even-spacing (i.e., gaussian or regular cartesian latxlon grids) and models using an icosahedral grid (with cells of uniform size).
"nominal resolution" is defined in Appendix 2 of the metadata specifications document.  For these grids I think the following models need correcting:
BCC_AGCM3_LR  (128x64 lonxlat) has mean resolution = 402 km. nominal_resolution should be 500 km (not 250 km).
CAS-ESM1-0 (256x128 lonxlat) has mean resolution = 201 km.  nominal_resolution should be 250 km (not 100 km).
CMCC-CM2-VHR4 (1152x768) has a mean resolution = 38 km.  nominal_resolution should be 50 km (not 25 km).
NorESM2-HH (1152x768) has a mean resolution = 38 km.  nominal_resolution should be 50 km (not 25 km).
INM-CM4-8INM-CM5-0 (180x120) has a mean resolution = 245 km.  nominal_resolution should be 250 km (not 100 km).
INM-CM5-H 50 (540x360) has a mean resolution = 81 km.  nominal_resolution should be 100 km (not 50 km).
IPSL-CM6A-ATM-HR (512x360) has a mean resolution = 84 km.  nominal_resolution should be 100 km (not 50 km).
MCM-UA-1-0 (96x80) has a mean resolution = 417 km.  nominal_resolution should be 500 km (not 250 km).
MRI-AGCM3-2-H (640x320) has a mean resolution = 80 km.  nominal_resolution should be 100 km (not 50 km).
MRI-AGCM3-2-H (640x320) has a mean resolution = 80 km.  nominal_resolution should be 100 km (not 50 km).
BCC_AGCM3_MR (320x180) has mean-resolution of 160.8, which just missed the upper bound for a 100 km nominal_resolution, so they fall in the 250 km category (not 100 km)  This is not seriously misleading, but I would like it corrected.
CAMS-CSM1-0 (320x180) has mean-resolution of 160.8, which just missed the upper bound for a 100 km nominal_resolution, so they fall in the 250 km category (not 100 km)  This is not seriously misleading, but I would like it corrected.
MRI-ESM2.0 (320x180) has mean-resolution of 160.8, which just missed the upper bound for a 100 km nominal_resolution, so they fall in the 250 km category (not 100 km)  This is not seriously misleading, but I would like it corrected.
NICAM16-7S icosahedral should probably be 50 km (not 100 km)
NICAM15-8S icosahedral should probably be 25 km (not 50 km)
NICAM16-9D-L78 and NICAM16-9S icosahedral should probably be 10 km (not 25 km)
FIO-ESM-2-0  report a "0.9x1.25 finite volume grid; 192 x 288 longitude/latitude ...", but I suspect the order of lon and lat have been reversed.  Check this and make consistent with ordering in other models: probably should read "1.25x0.9 finite volume grid; 288 x 192 longitude/latitude ..."
NorCPM1, NorESM1-F, NorESM2-LM, NorESM2-LME, NorESM2-LMEC, NorESM2-MM model components and check that the grid dimensions (360 x 384) are in longitude x latitude order (and not reversed).
GISS-E2-1-G(atmos and ocean) and the ocean component of GISS-E2-1-G-CC GISS-E2-1-H GISS-E2-2-G GISS-E3-G are labeled 100 km, which is not misleading, but they can be more precisely labeled "1x1 degree" (which is a special designation provided for the "standard grid").

@taylor13 chat about this next week, not 100% sure how to proceed as many groups will already have written this information into their files using the pre-configured cmip6-cmor-table inputs

The cmip6_CV.json file only contains a list of the allowed "nominal_resolutions", which we are not changing.  We don't transfer for each model the native_nominal_resolution to cmip6-CV.json.
I'm not suggesting that we correct the already written files (or ask groups to change the resolution recorded for a run that is in the process of being written), but I don't think there is any harm in correcting the source_id.json file.  We might as well enable users to retrieve the native_nominal_resolutions that are correct.
Not sure whether ES-DOC records native_nominal_resolution.  We should check on that.

@taylor13 you're right, we no longer include resolution info, see cmip6-cmor-tables/Tables/CMIP6_CV.json

@taylor13 for NICAM-* models, we calculated grid resolution from using grid point data according to the "Algorithm for defining the nominal_resolution".
NICAM16-7S icosahedral: avg(d_max) = 72.8km -> 100 km
NICAM15-8S icosahedral: avg(d_max) = 36.4km -> 50 km
NICAM16-9D-L78 and NICAM16-9S: avg(d_max) = 18.2km -> 25 km
The distribution of the grid point is not uniform. A standard icosahedral grid system has two polygons: hexagon and pentagon. The size difference between these two polygons causes crucial errors in atmospheric simulations (Tomita et al., 2002). To reduce the noise, we apply the grid point modification with a spring-dynamics approach (Tomita et al. 2001, 2002). As a result, distances between each grid and the neighboring grid is not uniform and d_max is larger than we expected.

thanks, @tinoue70, for checking the resolutions.  I'm confident your numbers are correct, so I went back to see why mine were different.  Mine were wrong for at least 2 reasons:

I assumed grid cells were circles and divided the global surface area by the number of cells to get the area of individual cells.  I then calculated grid cell diameters consistent with the area (yielding an estimate of d_max).

Even if I had used the area of regular hexagons to compute d_max, I would have found the following:
NICAM16-7S icosahedral: avg(d_max) = 69.2 km
NICAM15-8S icosahedral: avg(d_max) = 34.6 km
NICAM16-9D-L78 and NICAM16-9S: avg(d_max) = 17.3 km

In the first two cases, these put you in different nominal resolution categories from the correct ones you calculated (because your resolutions are near the cutoff between two categories).  It seems that the spring-dynamics distortion of the grid cells from regular hexagons slightly increases d_max (but only by about 5%).
Thanks again for checking the nominal resolution.  We'll retain the values you originally registered with your models.

to be sure, @tinoue70  .... in calculating d_max, did you measure the distances between the triangle vertices (the "P" points in fig. 3 of Tomita et al. (2001)) or the hexagon vertices (the "G" points in that same figure)?  I think it's the max distance between "G" points that we want (which I think is somewhat shorter than the distance between "P" points.

I will answer on behalf of @tinoue70. We used "G" points. Specifically, we calculated the great circle distance between neighboring vertices of each hexagon or pentagon.

Excellent! Thanks again @tinoue70 and @hisashiyashiro for clarifying and for your participation in CMIP6.  I'll edit the first comment at the top of this thread to summarize.


Solution for container to container communication dns resolution

As we got traefik in and removed registrator now we can handle the discovery for the "front-end" apps by mapping the host ip and host port on traeffik but the internal apps deployed trough marathon (with label traefik.enable=false) won't register on consul its SDN ip anymore so we need to put a solution in place for container to container communication.
We could consider mesos-dns / docker-overlay and docke-dns / weave dns

weave dns ties us to much to weave. mesos-dns is used in a lot of places but docker is the core of the platform and what we are trying to solve, so Im with docker-overlay or docker-dns

For now we restore registrator and rely on consul as dns server.
Looking at docker overlay/consul-mesos for CoreOS beta with docker 1.9


Layout View Style align bug

If a style dict with an align field is used in a layout View, then the align field will be removed from the style dict.

This is also true for padding in a layout View.

Published v2.6.1 which fixes this.

Really we should re-work the style align prop so that instead of a string it takes a https://doc.qt.io/qtforpython-6/PySide6/QtCore/Qt.html#PySide6.QtCore.Qt.AlignmentFlag


Describe what each field means in "docker stack ps"

File: engine/reference/commandline/stack_ps.md, CC @mstanleyjones
It will be helpful if the doc contained description about each field listed in docker stack ps. All of them except ID and Name are obvious. I am always confused between container ID and task ID. Please describe the difference between the two if possible. I also had trouble figuring out what the numerical suffix in Name meant. I am assuming it is replica number.

Issue moved to docker/cli #503 via ZenHub


GiftEvent triggered twice for one gift

I've noticed when one gift is sent, the gift event is triggered twice. This happens about 90% of the time.
Here's my code:
from TikTokLive.client.client import TikTokLiveClient
from TikTokLive.client.logger import LogLevel
from TikTokLive.events import ConnectEvent, GiftEvent
client: TikTokLiveClient = TikTokLiveClient(
unique_id="@username"
)
@client.on(ConnectEvent)
async def on_connect(event: ConnectEvent):
client.logger.info(f"Connected to @{event.unique_id}!")
@client.on(GiftEvent)
async def on_gift(event: GiftEvent):
client.logger.info(f"Recieved gift ID = {event.gift.id}!")
if name == 'main':
# Enable debug info
client.logger.setLevel(LogLevel.INFO.value)
# Connect
client.run()

This doesn't really sound like a bug, but rather how streaking is handled by TikTok. Please confirm you are not referring to streakable gifts, like Rose, which always fire a minimum of twice (once to start, once to let you know the streak is over).

Right now "Cap" is a streakable gift, but why is the value of {event.gift.streakable} False?

Is there any way to fix it? When they send a rose, the action is done twice

It is not a bug. There is no "fix". Listen for the streak to finish!


Color mismatched on Android in Xamarin.Forms

If I follow Creating A Splash Screen In Xamarin Forms >Creating A Splash Screen Android>Better Approach ,the content in SKGLView's color will be mismatched
demo: https://github.com/moespirit/skiademo

English is not my native language; please excuse typing errors.
Thanks

I had a look at this, and I can repro this in your sample. However, this may be a Xamarin.Forms or most probably an Android bug.
I have re-attached your sample, but this time using the Xamarin.Forms OpenGLView instead:
Archive.zip
The same thing occurs. When I "disabled" the splash screen style, the problem went away. This may have to do with either Xamarin.Forms or the way Android works with OpenGL.
It might be better to ask on the forums.

@mattleibow Thanks

I will close this issue as it appears to be a issue relating to Xamarin.Forms and OpenGL. If you have created a new issue somewhere, feel free to link that here.

I found the issue to the problem. There is a specific attribute that is set in the splash screen style, but is not unset (for some reason) when the style is changed.
In the splashscreen style, note this:
<item name="android:backgroundDimEnabled">true</item>

Docs: https://developer.xamarin.com/api/field/Android.Resource+Attribute.BackgroundDimEnabled/
This is not unset when the style is switched. So, to fix this, just set it to false:
<item name="android:backgroundDimEnabled">false</item>

Here is a repository that demonstrates this: https://github.com/mattleibow/AndroidGLSurfaceViewTests


[web] TailwindCSS + UI Library

Add TailwindCSS to the Next app. UI Library could be Mantine or daisyUI or something else.
(edit by @realjoshuau: chakra is also very good!)

ShadCN is the goat


change embed_file variable name

change emb_file to embed_file because embed_file is not defined

I signed it!

Thanks! The change has been merged into master.


Is segmentation necessary for keypoint r-cnn custom data training

I am trying to train with a custom dataset which has boxes, labels and keypoints. As far as I can tell from keypoint_rcnn.py this is all I need.
  During training, the model expects both the input tensors, as well as a targets (list of dictionary),
   containing:
       - boxes (FloatTensor[N, 4]): the ground-truth boxes in [x1, y1, x2, y2] format, with values of x
         between 0 and W and values of y between 0 and H
       - labels (Int64Tensor[N]): the class label for each ground-truth box
       - keypoints (FloatTensor[N, K, 3]): the K keypoints location for each of the N instances, in the
         format [x, y, visibility], where visibility=0 means that the keypoint is not visible.

However, when I try to train using train.py I receive the following error
(I am using Colab and coco_utils.py and transforms.py path was at default directory)
KeyError: Caught KeyError in DataLoader worker process 0.
Original Traceback (most recent call last):
  File "/usr/local/lib/python3.6/dist-packages/torch/utils/data/_utils/worker.py", line 178, in _worker_loop
    data = fetcher.fetch(index)
  File "/usr/local/lib/python3.6/dist-packages/torch/utils/data/_utils/fetch.py", line 44, in fetch
    data = [self.dataset[idx] for idx in possibly_batched_index]
  File "/usr/local/lib/python3.6/dist-packages/torch/utils/data/_utils/fetch.py", line 44, in <listcomp>
    data = [self.dataset[idx] for idx in possibly_batched_index]
  File "/usr/local/lib/python3.6/dist-packages/torch/utils/data/dataset.py", line 257, in __getitem__
    return self.dataset[self.indices[idx]]
  File "/content/coco_utils.py", line 219, in __getitem__
    img, target = self._transforms(img, target)
  File "/content/transforms.py", line 23, in __call__
    image, target = t(image, target)
  File "/content/coco_utils.py", line 59, in __call__
    anno = [obj for obj in anno if obj['iscrowd'] == 0]
  File "/content/coco_utils.py", line 59, in <listcomp>
    anno = [obj for obj in anno if obj['iscrowd'] == 0]
KeyError: 'iscrowd'

I added iscrowd and it threw error on segmentation.
My question:
Do we really need segmentation and iscrowd to train? Is it ok to just remove parts related to those features?

The model doesn't require segmentation maps, but the rest of the training code makes the assumption that it is present, see https://github.com/pytorch/vision/blob/7ffc9520a847bd94a61247f1bdc19a00e4165440/references/detection/coco_utils.py#L71-L72
You can safely remove those for your use-case.


feat(@angular-devkit/build-optimizer): don't import tslib on cjs

There's no real guarantee of what require() is. Some bundlers override it in scope to provide a module loader.
Fix #8442

It's been 2 days since the submission. I just wanted to BUMP it as I need this for production ASAP.

We plan to switch to TS helpers entirely for 7.1. See https://github.com/angular/angular-cli/pull/12598


Geometry buffer renderer: Fix normals not transformed by the world matrix when using normal maps

See https://forum.babylonjs.com/t/world-normals-dont-account-for-right-handed-coord-system/54625

Snapshot stored with reference name:
refs/pull/15805/merge
Test environment:
https://snapshots-cvgtc2eugrd3cgfd.z01.azurefd.net/refs/pull/15805/merge/index.html
To test a playground add it to the URL, for example:
https://snapshots-cvgtc2eugrd3cgfd.z01.azurefd.net/refs/pull/15805/merge/index.html#WGZLGJ#4600
Links to test babylon tools with this snapshot:
https://playground.babylonjs.com/?snapshot=refs/pull/15805/merge
https://sandbox.babylonjs.com/?snapshot=refs/pull/15805/merge
https://gui.babylonjs.com/?snapshot=refs/pull/15805/merge
https://nme.babylonjs.com/?snapshot=refs/pull/15805/merge
To test the snapshot in the playground with a playground ID add it after the snapshot query string:
https://playground.babylonjs.com/?snapshot=refs/pull/15805/merge#BCU1XR#0

WebGL2 visualization test reporter:
https://snapshots-cvgtc2eugrd3cgfd.z01.azurefd.net/refs/pull/15805/merge/testResults/webgl2playwright/index.html

Visualization tests for WebGPU (Experimental)
https://snapshots-cvgtc2eugrd3cgfd.z01.azurefd.net/refs/pull/15805/merge/testResults/webgpuplaywright/index.html

Crazy we never saw it

The problem occurred only when bump textures were used, that may be the reason why we didn't spot it earlier.


Make generated AMQPProperties type serializable with serde

Hello!
This PR makes the AMQPProperties type in the amq-protocol crate serializable with serde. All the fields of that struct were already serializable and the serde crate was already pulled in by amq-protocol-types.
Thank you!

Hello!
Thanks for the PR.
Out of curiosity, why do you need this for?

Also, could you use serde::{Deserialize, Serialize} in protocol/src/protocol.rs and use those directly in your derive?

Sure!
I'm building an implementation of a transactional outbox for a service and I need to persist Rabbit messages to a database before attempting to actually send them. Having AMQPProperties serializable would help a lot in persisting the messages correctly.

Should be ok with latest lapin release


fix to use the script pass-in args save_dir

Traceback (most recent call last):
File "compare.py", line 160, in
format(save_dir))
NameError: name 'save_dir' is not defined
此为PR说明模版
如提交的为部署C++代码，请确认以下自测点是否完成（完成勾选即可），并保留以下的自测点列表，便于Reviewer知晓。

[ ] Linux下测试通过

[ ] batch = 1 预测

[ ] batch > 1预测

[ ] 多GPU卡预测

[ ] TensorRT预测

[ ] Triton预测

[ ] Windows下测试通过

[ ] batch = 1预测

[ ] batch > 1预测

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.


adds a "view all questions" button to FAQ page

fixes #722

Can you left align all top level headers in the sidebar menu with the FAQ text in the gray box? That is, remove the indentation.
Sent from my iPhone

On Jan 2, 2019, at 9:47 PM, Hank Tadeusiak<EMAIL_ADDRESS>wrote:
fixes #722
You can view, comment on, or merge this pull request online at:
https://github.com/jonfroehlich/makeabilitylabwebsite/pull/725
Commit Summary
adds an view all questions button to FAQ page
File Changes
M website/static/website/js/faq.js (27)
M website/templates/website/faq.html (7)
Patch Links:
https://github.com/jonfroehlich/makeabilitylabwebsite/pull/725.patch
https://github.com/jonfroehlich/makeabilitylabwebsite/pull/725.diff
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub, or mute the thread.

Can we merge and open a new issue?


APIv2: Figure out duplex server-client communication protocol

I'm working on this

Ok, I've kinda figured out how we can do thing right. Ping me tomorrow, pls

Handling page error

Send about:page-error and add pending error (this is blocking on DevExpress/testcafe-hammerhead#339)
Then if error was not handled use standard done mechanism

Client driver

Create src/client/driver lib.
Driver waits page ready event and sends ready hanging message to test run
Once it get's message it executes appropriate automation/assertion
Save executingCommand flag to true and run automation
Set xhr/page load barrier
If page not unloaded then send ready with the success status, set  executingCommand flag to false
If we have a new page load, check executingCommand flag, if it's true, repeat actions from the step above.

Processing commands

Commands should be defined as classes for the clarity, so we will have defined set of fields
On client we will need to get elements from selectors contained in command, for this we should use our querying mechanism (try to obtain element within 10 seconds).
For client errors create declarative classes in src/client/driver/errors.

First steps

Start implementing driver
Start implementing click action in both raw and v2 format (implement options validation, etc.)
Figure out minimal required assertions mechanims and implement it.
Create functional tests for click

Closed in #263


fix: multiple puppeteer process is spawned

Codecov Report

Merging #33 (98dc04e) into master (45742e8) will decrease coverage by 0.28%.
The diff coverage is 25.00%.

@@            Coverage Diff             @@
##           master      #33      +/-   ##
==========================================
- Coverage   87.08%   86.79%   -0.29%
==========================================
  Files          13       13
  Lines         302      303       +1
  Branches       53       55       +2
==========================================
  Hits          263      263
- Misses         39       40       +1

Flag
Coverage Δ

unittests
86.79% <25.00%> (-0.29%)
:arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files
Coverage Δ

src/command/email.ts
36.17% <25.00%> (-0.79%)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 45742e8...98dc04e. Read the comment docs.


Transceiver required?

Does it work without any RS485 transceiver? I have an ESP32+RS485 module. Can an RP2040 communicate to the module just by connecting the RX/TX pins?

Hi,
No you actually need a transceiver to do rs485, to manage direction and differential voltage levels.


Cache files between form submits without the input

When you submit a file and a validation error is presented, if you don't call attachment_field the file is lost.
I believe it is the hidden field generated by this method which keeps the cache between submits but I don't want to show the input again to the user if the file is already there, see the image.

What I've done is this:

    <%= f.input :id, as: :hidden %>

    <% if f.object.file %>

        <%= f.attachment_field :file %>

      <%= link_to f.object.file_filename, attachment_url(f.object, :file) %>
    <% else %>
      <%= f.attachment_field :file %>
    <% end %>

    <%= link_to_remove_association "Remover", f, class: 'btn btn-sm btn-danger' %>

Would be nice to have some kind of helper like f.attachment_cache :file to be able to keep the cache without rendering the file input itself.
Makes sense?

I think this would be sensible. Basically we should add a public API for the hidden field.

Great, I will try a patch at the end of the day.


Support reversing multiple selected lines at once

It's a real time-saver to run operations on all selected features at once. We already support this for Square—Reverse should be similar and somewhat easier.

Agree

Thanks Quincy


chore: enable system js build

Updates the Nebula dependency and enables the systemJS build artifact.

Had to leave nebula/cli-build at 3.0.3 due to an update to @rollup/plugin-node-resolve v14 which somehow breaks the table in particular.
The Nebula PR is this: https://github.com/qlik-oss/nebula.js/pull/946
The change in @rollup/plugin-node-resolve is https://github.com/rollup/plugins/pull/1245
I have yet to determine what actually happens and how to resolve it.


Fix MTLS configuration in spring boot autoconfiguration

What was changed

Added tests to ensure ServiceStubs is loaded properly.
Moved applying MTLS properties and building SSLContext to within the try-with-resource block.

Why?

MTLS configuration fails to load certificates due to input stream already closed. The read from the stream happens within the SSLContextBuilder::build method (specifically when calling sslContextBuilder.keyManager) which is outside the try-with-resource.

Thank you for the contribution! This looks great.


feat: Add option to display related posts

Description
New feature: Display related posts after page content
Discussion
#283 Feature: Add related posts to footer of post

Aditional Information (Optional)

Using built in Hugo functionality
Possibly needs some css styling?

Checklist
Yes, I included all necessary artefacts, including:

[ ] Tests
[x] Documentation
[x] Implementation (Code and Ressources)
[x] Example (Screenshot)

Testing Checklist
Yes, I ensured that all of the following scenarios were tested:

[x] Desktop Light Mode (Default)
[x] Desktop Dark Mode
[ ] Desktop Light RTL Mode
[ ] Desktop Dark RTL Mode
[x] Mobile Light Mode
[x] Mobile Dark Mode
[ ] Mobile Light RTL Mode
[ ] Mobile Dark RTL Mode

Notify the following users

@gummigroda Thanks for your PR for one of the outstanding feature requests!
I agree, a bit of styling might improve the appearance even further. Do you need help with the CSS or do you want to create it yourself and have me look over it?
One other thing that would be really cool is the ability to preview the post thumbnails. What do you think?

Hi,
Regarding the CSS, I don't really have any idea of what to do. If you or anyone else have the time, please style it as you think it fits.
I totally agree with you, thumbnails would be awesome as seen on other websites and has been the inspiration to this PR. I'm just not sure how to do it as I believe it's tightly connected to the styling?

@gummigroda Thanks for your response. I can take of the Styling. It might take a bit though, as I am currently quite busy porting all the CSS to SCSS. So please bare with me. :)

@gummigroda Just want to let you know that I'll work on this one, as soon as I've merged #292.

@lxndrblz, No worries.
Looked into the thumbnail possibility and found out that Hugo supports image processing.
And as I understand it, to get the images of a related post they need to be in the same "Page Resources". I'm totally new to Hugo and this is a bit beyond me a.t.m.

@gummigroda I wanted to inform you that I didn't go with the card style I had envisioned earlier as I could not find a viable way to make this work for sites that had both posts with a thumbnail and ones without. Furthermore, is the current approach more inline with the style of the series.


Integrals of dot products of gradients -- which intor string?

A quick question. I need to calculate one-electron integrals of the form \int \nabla\chi_i \dot \nabla\chi_j dr -- that is, the integral of the dot product of the gradients of the (contracted Gaussian) AOs \chi_i and \chi_j -- and I'm not entirely sure which intor specifier to use.
I see that there is 'ipovlpip', which according to the libcint documentation should be something of the form <nabla | nabla>. Are the components of the output of this of the form < d/dr_i | d/dr_j >, i.e. integrals of products of partial derivatives over the two input AOs, or are the derivatives mixed or otherwise not what I expect?
Phrasing it differently, am I correct in thinking that I can achieve the integral form specified above by, e.g.,
> ao_cross_grad = mol.intor('int1e_ipovlpip')

and then calculating the full integrals of the dot products as
> ao_dot_grads = ao_cross_grad[[0, 4, 8]].sum(axis=0)

Yes, your code is right.


multiSchema: migrate dev fails to apply cleanly to shadow database after custom migration renames table in secondary schema

Bug description
Observed using 4.8.0-dev.41 - this issue becomes visible now #16561 is resolved (thanks for fixing that one!)
Update: this issue only occurs when specifying shadowDatabaseUrl manually in schema.prisma - it works as expected when this is removed.
The fix to #16561 means migrate reset is now successful. However, subsequent attempts to run migrate dev immediately after migrate reset (i.e. no schema drift) and a migration history containing a `ALTER TABLE "second.table1" RENAME TO "table2" fails with error:
Error: P3006

Migration `<migration_name>` failed to apply cleanly to the shadow database.
Error:
db error: ERROR: relation "table2" already exists
   0: sql_migration_connector::validate_migrations
           with namespaces=None
             at migration-engine/connectors/sql-migration-connector/src/lib.rs:295
   1: migration_core::state::DevDiagnostic
             at migration-engine/core/src/state.rs:264

I'm not sure what's going wrong here - via psql I can see the table now exists in the shadow database second under both names table1 and table2 - as if the rename migration is successful but then somehow the original table has been recreated. Perhaps a similar reset logic bug not resetting secondary schemas correctly during work on the shadow database? But I'm just speculating here (I don't know the full implementation details for how migrate dev interacts with the shadow database).
How to reproduce
previewFeatures = ["multiSchema"]

datasource db {
  provider          = "postgresql"
  url               = env("DATABASE_URL")
  shadowDatabaseUrl = env("DATABASE_URL_SHADOW")
  schemas  = ["first", "second"]
}

model Example {
  @@schema("second")
  ...
}

migration.sql:
ALTER TABLE "second"."table1" RENAME TO "table2";

Expected behavior
No response
Prisma information
% npx prisma -v
prisma                  : 4.8.0-dev.41
@prisma/client          : 4.8.0-dev.41
Current platform        : darwin-arm64
Query Engine (Node-API) : libquery-engine ddfde0aabd6544e4740cc1b4ef9a682c02b813d2 (at<EMAIL_ADDRESS>Migration Engine        : migration-engine-cli ddfde0aabd6544e4740cc1b4ef9a682c02b813d2 (at ../../node_modules/@prisma/engines/migration-engine-darwin-arm64)
Introspection Engine    : introspection-core ddfde0aabd6544e4740cc1b4ef9a682c02b813d2 (at ../../node_modules/@prisma/engines/introspection-engine-darwin-arm64)
Format Binary           : prisma-fmt ddfde0aabd6544e4740cc1b4ef9a682c02b813d2 (at ../../node_modules/@prisma/engines/prisma-fmt-darwin-arm64)
Format Wasm             : @prisma/prisma-fmt-wasm 4.8.0-28.ddfde0aabd6544e4740cc1b4ef9a682c02b813d2
Default Engines Hash    : ddfde0aabd6544e4740cc1b4ef9a682c02b813d2
Studio                  : 0.479.0

Environment & setup

OS: macOS
Database: PostgreSQL 14
Node.js version: v16.15.1

Prisma Version
4.8.0-dev.41

Is your shadow database URL pointing to a different logical database, or to a different schema in the same database?

Interesting, we should definitely dig deeper. Thanks for reporting the issue!

Can confirm. You have to reset first, then migrate dev two times in a row to get the error.

Sorry but what's the solution for this?
I'm baselining a new database so I've done a migrate diff to generate the original SQL file and marked it as resolved. The next migrate dev still creates a migration (Not sure, might be something wrong with my DB but its just changing some FK ID's). The next migrate dev however fails with the same error as OP. I'm specifying a shadow database on the same host but different logical database

The bug was closed, so we assume it was fixed. If it is not fixed for you, please open a new bug issue and include all the information the bug issue template asks for. Thanks.


Keep autocomplete generated display names for DMs

Summary
When you get the channels by autocompleteChannels api, it returns a
generated display name Private channels, because they doesn't have it by
default (normally is the other user username, which depends on caller of
the API).
But when you load channels in any other way, or receive channels updates
from the websocket, this is overriden. This simply do not override it
with an empty value.
Checklist

[x] Ran make check-style to check for style errors (required for all pull requests)
[x] Ran make test to ensure unit tests passed
[x] Ran make flow to ensure type checking passed

Yes, you are right, i change it in the last second and it was wrong. (Copy pasting). Yes, the idea is DMs. Fixed with a push -f.

@jespino this is fine now BUT I do believe the selectors will try and complete the display_name anyway, can you please take a look at that as it is totally related to this PR

@enahum yes, but it relays in the fact that you must have all the users data which have some conversation with you in the store. and that is not necessarily true during the autocomplete.

Doesn't matter, because that display name (private channel display name for the search autocomplete) is the username. That is not reflected in real time, but at least solve the problem of "removing the name" when you are autocompleting and for some reason you receive an update of the channels from the server.
The point is to not remove the visual data from the channel autocomplete (on search). Maybe the information (in some corner cases) can be out of date, but is not a big deal. I can explain it better if you want or you need.


Signing errors can lead to increased CPU usage

I found that parsing the wrong zip resulted in increased CPU usage, and I found a problem after debug：
Parse.prototype._flush = function (callback) {
  if (!this._streamEnd || !this._streamFinish) {
    return setImmediate(this._flush.bind(this, callback));
  }

  this.emit('close');
  return callback();
};

Here _streamEnd and _streamFinish variables has been meet the conditions, so constantly registered setImmediate to the event loop

+1

use unzip.Extract, Cpu soars from 4% to 50% and does not recover.


fix wrapper script shebang

seems python.subprocess fails if it's not on the first line, and nvcc fails if it's #!/usr/bin/env bash instead of #!/bin/bash.

https://github.com/oliverlee/bazel_bootlin/commit/3f5ad2018c4a6fc0afdb9a674aec828e910e93ff

Should I be using unstable and not use the bleeding toolchain?

unstable is the default branch but i didn't bother to update it since I didn't realize anyone else was using it
I can rename it to main or master if you prefer


NPS surveys in app

Put delighted questionnaires in the app to start collecting net promoter scores and feedback

 General refinement


VisionTransformerAdapter vs VisionTransformerLadder

Hi Shuming,
I used VisionTransformerAdapter on my own dataset, and the results are great!
But when I use VisionTransformerLadder there's a big drop in the results.
Do you have any suggestions what might cause this issue?
Thanks :)

Thanks for your question!
Compared to the standard adapter architecture, the ladder network can save more memory, however, with the cost of poorer visual representation. Therefore, VisionTransformerAdapter is expected to perform better than VisionTransformerLadder.
The advantage of the ladder network usually becomes visible only if the backbone is very, very large, such as 1B or even 6B. In the meantime, the architecture design of the ladder network may also be improved for stronger performance.
Therefore, I recommend that you can simplely stick to the VisionTransformerAdapter, which is usually more effective.

Thanks!


Whats startup command?

Hi whats the start-up command?

https://github.com/finlaysawyer/discord-uptime#running-the-bot
python -m bot
Please read my answer to the previous issues before opening another


Tidy up the plugin v1 conversion code

Some organization and re-structuring would be good for our plugin v1 conversion code.
Main points to address:

schema conversion functions (both from JMX and Python) should be moved into src/utils folder
Consider opportunities for reducing duplication between JMX & Python conversions:

Either merging the flows with additional parameters
Or, given we plan to enhance python conversion, extract more of the flow into utility functions to be moved into src/utils

@dlopes7 I'm trying to organise work based on releases.
Should I include this in upcoming release (1 month ish) or next one (2 months ish)?

1 monthish


Thanks to your work! I train CLIP with this project. I have some problems.

Do you design the a sampler for your project?
I train CLIP and realize that we can not duplicate sampling though sub iterations. Or it will get a wrong optimization goal. So we need a
no duplicate sampler though sub iterations.
I know we could set a big BATCHSIZE, and use torch.chunk() to spilt them into sub batch. But this gives too much pressure to CPU, This way also limits a big BATCHSIZE.

I was over thinking. Default option is replacement=False


Frame length arg

Addresses #37. It's a little messy, but it works.
Example usage: python stammer.py hams.mp4 song.mp3 hamsong.mp4 -f 0.1 will use frame lengths of 0.1 seconds.

Thanks for your work! The audio works great, but I'm not sure it quite handles video correctly yet? You call build_output_video(frames_dir, outframes_dir, matcher, 1/real_frame_length, output_path) which sticks the frames from the matcher (at the custom frame rate) together at the source frame rate. This means that the audio and video gets out of sync, or even truncated, especially at high frame-rates. Instead, I think we'll need to do something a bit cleverer involving skipping or duplicating video frames.

I can give it a shot in a sec, unless you want to.

i'm working on it now

I still want to tidy up the math some, but I think i solved it. Any thoughts?


Feature Request: Show link when hover over hyperlink

If you haven’t already, check out our contributing guidelines for onboarding and email<EMAIL_ADDRESS>to request to join our Slack channel!

Action Performed:

Navigate to chat
Send any text hyperlinked
Hover over or hard press over link

Expected Result:
Some tool tip displayed so that, when the hyperlink is hovered over, the destination link shows.
Actual Result:
Nothing happens on hover
Problem:
Currently users can use markdown to add hyperlinks to chats.  The person who receives the link can't easily view the link to know where goes (inc. potential phishing links)
Solution:
Add a tool tip so that, when the hyperlink is hovered over, the destination link shows.
Workaround:
unknown
Platform:

Where is this issue occurring?

Web
iOS
Android
Desktop App
Mobile Web

Version Number: 1.1.39-1
Reproducible in staging?: Y
Reproducible in production?: Y
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation

Expensify/Expensify Issue URL:
Issue reported by: @mallenexpensify
Slack conversation: https://expensify.slack.com/archives/C01GTK53T8Q/p1644366109776009
View all open jobs on GitHub

Triggered auto assignment to @kadiealexander (AutoAssignerTriage), see https://stackoverflow.com/c/expensify/questions/4749 for more details.

PROPOSAL
To achieve this we need to make some changes in src/components/HTMLEngineProvider/HTMLRenderers/AnchorRenderer.js
https://github.com/Expensify/App/blob/d9355db0e9685021c3be1debca3c43751ad2d759/src/components/HTMLEngineProvider/HTMLRenderers/AnchorRenderer.js#L54-L70
<Tooltip text={attrHref}>
    <AnchorForCommentsOnly
        href={attrHref}
        isAuthTokenRequired={isAttachment}

        // Unless otherwise specified open all links in
        // a new window. On Desktop this means that we will
        // skip the default Save As... download prompt
        // and defer to whatever browser the user has.
        // eslint-disable-next-line react/jsx-props-no-multi-spaces
        target={htmlAttribs.target || '_blank'}
        rel={htmlAttribs.rel || 'noopener noreferrer'}
        style={{...props.style, ...parentStyle}}
        key={props.key}
        fileName={fileName}
    >
        <TNodeChildrenRenderer tnode={props.tnode} />
    </AnchorForCommentsOnly>
</Tooltip>

Output:

This is an extra feature. it could be good to have but I don't it is needed at this stage.

Agree, but if it's an easy fix I say we go for it. @mallenexpensify is right that it poses a small security risk to click on a link when you're not sure of the destination.

Triggered auto assignment to @sketchydroide (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

Then I don't think a tooltip is best suited bfor this. Like other websites, hovering over the link the browser should show the link address on the cornor of the browser.
But this is not happening in our app so we should do that even though we are planning to show tooltip.

Then I don't think a tooltip is best suited bfor this. Like other websites, hovering over the link the browser should show the link address on the cornor of the browser.
But this is not happening in our app so we should do that even though we are planning to show tooltip.

I think for now let's show the tooltip, this is what slack seems to do, and for the rest of the none web based platforms I think it makes more sense.

Triggered auto assignment to @mallenexpensify (External), see https://stackoverflow.com/c/expensify/questions/8582 for more details.

😄 @mallenexpensify you have been chosen I was goint to tag you, but seems like it is no longer necessary

But still Tooltips are only web thing.

Full circle!  @parasharrajat is there another term we should use to denote what we're calling/considering a tooltip on Desktop?

We definitely want a mobile/app option too, right now there is no way to know where a hyperlink will send you.

How about, when someone taps then holds any link (hyperlinks and other domain links) we show the destination link  above or below 'copy URL to clipboard`? Reasoning is because it's possible to use markdown to have a visible link go to a different site

Alt option would be to never allow links to go to other sites.

Sorry for the confusion @mallenexpensify. Tooltip works on both web and desktop but not on the native apps (Android|IOS).

Triggered auto assignment to Contributor-plus team member for initial proposal review - @parasharrajat (Exported)

Triggered auto assignment to @tgolen (Exported), see https://stackoverflow.com/c/expensify/questions/7972 for more details.

Job posted - https://www.upwork.com/jobs/~01f57f9d1472302ddc
@tgolen , can you review @sobitneupane 's proposal above https://github.com/Expensify/App/issues/7844#issuecomment-1046194797
Also, for the lower part of this comment, do you think we should address that here?

@sobitneupane Can we please drill down in the AnchorForCommentsOnly to show the tooltip? AnchorForCommentsOnly is multipurpose. The tooltip should be added to the closest native node.
@mallenexpensify I agree, we if we want to show the URL on mobile, we can show that over the Copy to clipboard context item in the popup menu.

@tgolen , can you review @sobitneupane 's proposal above https://github.com/Expensify/App/issues/7844#issuecomment-1046194797

sorry @parasharrajat , forgot you were assigned as C+ :ohnothing:   Let's see if we can tackle both mobile and web/desktop via this issue

Do you prefer the tooltip on Mobile or fine with showing the link on the popup menu ?

@sobitneupane Can we please drill down in the AnchorForCommentsOnly to show the tooltip? AnchorForCommentsOnly is multipurpose. The tooltip should be added to the closest native node.

If we want to show tooltip both in desktop and web app, we should add <Tooltip> around
https://github.com/Expensify/App/blob/87230549a3d9c299f7abbc98012f4143383c2c19/src/components/AnchorForCommentsOnly/BaseAnchorForCommentsOnly/index.js#L72-L85
If we want to show tooltip only in desktop, we should add a new file index.desktop.js with the codes in index.js with above change.
Showing url in popover can be quite tricky. Length of url (even only domain) can be an issue.

Do you see any other way to show the URL on Mobile @sobitneupane ?  Holding proposal review until we finalize the changes that need to be done for

Native?
Web & Desktop ( Tooltip)

Bump questions :arrow_up:

@mallenexpensify https://github.com/Expensify/App/issues/7844#issuecomment-1048975682

Do you prefer the tooltip on Mobile or fine with showing the link on the popup menu? But the link could be very big and we may have to trim it. But I think most important part is the domain so it should be properly visible.

I think we'd use iOS and Android defaults, if there is such a thing.  ie. I think long-pressing the link would open the popup from the bottom on iOS where you'd be able to see the link at the top of the pop up then have options below that for sharing/copying.  Not sure about Android

Android will have the same effect. Got it, Thanks.
@sobitneupane Could you please share an updated proposal with the new requirements?

Does everyone agree that what I proposed is the best? I'm not an expert in UI/UX...

I'm OK with that proposal given the feature request. Tooltips are hard cross-platform and so I think trying to stick close to native platform functionality is OK.
However, I can't shake the feeling it just feels like this feature a bit much and I would actually vote that I don't want the feature because I don't see the problem (or haven't experienced it).

I think that not being able to know the destination of links your clicking is a security issue. Phishing 101 is to spoof an email and link to get people to click it.  Isn't that the same, or similar, to what we're wanting to fix/update here?

Yeah, you're right. It makes sense from a security perspective. I forgot about that.

@sobitneupane I think we are still waiting on this from you:

@sobitneupane Could you please share an updated proposal with the new requirements?

@sobitneupane any updates?

Doubled price (should have done a while ago...)
https://www.upwork.com/jobs/~018bbb25aad73a12f4

Doubled price to $1000
https://www.upwork.com/jobs/~018bbb25aad73a12f4

Since there is no hover on mobile, show the link URL in the context menu for a long press.

Just dropping in a possible solution for mobile, from slack.

Since there is no hover on mobile, show the link URL in the context menu for a long press.

Just dropping in a possible solution for mobile, from slack.

Proposal for native:
Making use of the MenuItem's description prop, the result looks like this:
https://user-images.githubusercontent.com/9059945/163721970-b29c5b98-3d53-4b40-a8cd-18b21d2797dd.mp4
Implementation:

Pass an additional description prop through ReportActionContextMenu -> PopoverReportActionContextMenu -> BaseReportActionContextMenu -> ContextMenuItem -> to the  MenuItem
In BaseAnchorForCommentsOnly/index.native.js pass the link (displayName) to ReportActionContextMenu.showContextMenu and check that it's not an email:

ReportActionContextMenu.showContextMenu(
    Str.isValidEmail(this.props.displayName) ? ContextMenuActions.CONTEXT_MENU_TYPES.EMAIL : ContextMenuActions.CONTEXT_MENU_TYPES.LINK,
    event,
    this.props.href,
    lodashGet(linkRef, 'current'),
    null,
    null,
    null,
    () => {},
    () => {},
    !Str.isValidEmail(this.props.displayName) && this.props.displayName
);

Im guessing the same should also be implemented for mWeb?

We don't need to pass the additional data from actions. The link value is available in the selection already.
Rest seems fine to fine.
@Expensify/design Does the video here look good?

Looks good. Can we see an example of the desktop tooltip version with an incredibly long link?

Looks good. Can we see an example of the desktop tooltip version with an incredibly long link?

https://user-images.githubusercontent.com/9059945/163836319-f0bece44-a669-4445-8602-706704997154.mp4
I'm guessing the Tooltip component should me modified.
How should it look like?

We could limit the length of the link
We could add maxWidth: Dimensions.get('window').width to the tooltipWrapperStyle, which would look like this:

https://user-images.githubusercontent.com/9059945/163852410-e1370b57-5f57-416c-b852-c8f8e1d609e9.mp4
But as you can see, pointer is calculated to be at the center of the link, which looks odd, because it is not at the center of the tooltip.
3. Possibly another approach (limit tooltip only to the left part of the screen, the one with chat)?
And what should we do with the native tooltip in browsers? The one that appears at the bottom left when you hover over a link

I think we can ignore the native tooltip and just let it be.
I agree that we want some kind of max-width on the tooltip itself. Perhaps if the max-width is just the total width of the message width then the pointer will always be center-aligned.

There is another issue which is setting the tooltip maxWidth so we don't have to worry about it here.
@eVoloshchak 's proposal looks good to me. The proposal discussion starts from here.
cc: @tgolen
:ribbon: :eyes: :ribbon:  C+ reviewed

@tgolen bumping to daily, @eVoloshchak 's proposal needs review

Ah, sorry I missed this one. The proposal looks OK. 🟢  to hire @eVoloshchak

Hired @eVoloshchak and assigned to GH!

@parasharrajat
I've encountered a problem on Android (haven't tested on iOS yet, but pretty sure it is present there too).
When we have a message with text and a link, long pressing on text will pop up the context menu for the message (which is correct), but long pressing on the link will also pop up the context menu for the message (which is not correct, it should be a context message with Copy URL to clipboard). While if you have a message with just a link, It works correctly.
Here's a video to illustrate
https://user-images.githubusercontent.com/9059945/165731370-3611fef1-7fac-4802-8afa-83da6b37501c.mp4
The issue occurs because if PressableWithSecondaryInteraction is inline, we use Text instead of Pressable and it somehow interferes with LongPressGestureHandler
const Node = props.inline ? Text : Pressable;

I tried to fix this and found out, that if we completely remove LongPressGestureHandler and add onLongPress handler to Node, it works just fine
https://user-images.githubusercontent.com/9059945/165732994-886ed14f-da26-409b-9bba-0a0a689dcde9.mp4
So this file would look like
const PressableWithSecondaryInteraction = (props) => {
    // Use Text node for inline mode to prevent content overflow.
    const Node = props.inline ? Text : Pressable;
    return (
        <Node
            ref={props.forwardedRef}
            onPress={props.onPress}
            onPressIn={props.onPressIn}
            onPressOut={props.onPressOut}
            onLongPress={(e) => {
                e.preventDefault();
                HapticFeedback.trigger();
                props.onSecondaryInteraction(e);
            }}
            {...props}
        >
            {props.children}
        </Node>
    );
};

Since you were the author of the PR that introduced this change, I thought you might know more.
Is approach I proposed acceptable?
Do we need LongPressGestureHandler?
I poked around the app and it doesn't seem to break anything, but maybe you have more context
Thanks!

Hey, @eVoloshchak Thanks for looking into it. It is a different issue than the one we are trying to solve here. So you don't have to fix that in this PR.
we need to use Text for inline mode and we also need the LongPressGestureHandler as it fixes one of the old issues.
but we have a separate logged issue for the problem you mentioned and if you want to solve it, head over to https://github.com/Expensify/App/issues/8311.

Hey, @eVoloshchak Thanks for looking into it. It is a different issue than the one we are trying to solve here. So you don't have to fix that in this PR.

Thanks, go it.
I'm ready to submit the PR, but it's gonna be impossible for the QA to test it for mWeb due to https://github.com/Expensify/App/issues/8311.
Should I submit it or wait for this issue to be resolved?

PR under review

no update

👋 looks like this didn't quite work completely, issue reported with mWeb: https://github.com/Expensify/App/issues/8960#issue-1233333508

Issue isn't caused by this PR, more details here.

Paid @eVoloshchak , it's working on web and desktop (Version 1.1.64-0). No comments on the PR the past week.
@parasharrajat , hired you for C+ payment, can you accept the offer?

@mallenexpensify Done.

Thanks @parasharrajat , paid $1000 for C+.


WasmPlugin: my wasm file does not shown in Envoy config dump result

(This is used to request new product features, please visit https://discuss.istio.io for questions on using Istio)
Describe the feature request
I tried a WasmPlugin demo
apiVersion: extensions.istio.io/v1alpha1
kind: WasmPlugin
metadata:
  name: httpbin-rate-limiting
  namespace: demo
spec:
  selector:
    matchLabels:
      app: httpbin
  url: oci://ghcr.io/tetratelabs/wasm-rate-limiting:v1

and it works. But I cannot found where is the configuration in Envoy config dump corresponding to the istio wasmplugin shown above. I only found the config

I wonder how Envoy known where is my .wasm？The config dump output seems have no information about this.
Describe alternatives you've considered
Affected product area (please put an X in all that apply)
[ ] Docs
[ ] Installation
[X] Networking
[ ] Performance and Scalability
[ ] Extensions and Telemetry
[ ] Security
[ ] Test and Release
[ ] User Experience
[ ] Developer Infrastructure
Affected features (please put an X in all that apply)
[ ] Multi Cluster
[ ] Virtual Machine
[ ] Multi Control Plane
Additional context

It requests it over XDS from the istio-agent component which pulls from the registry

wasmplugin is send to envoy via ECDS, you can check it out by running kubectl exec -it kubectl get po -nistio-system| grep istiod | grep Running | awk '{print $1}' -nistio-system -- pilot-discovery request get '/debug/ecdsz?proxyID=<httpbin-74fb669cc6-htg48>'
you wasm will renamed and placed here
https://github.com/istio/istio/blob/c548d8dbf1b5286d29fe77ef4b83848756cf048c/pkg/config/constants/constants.go#L46

@zirain Thank you very much. I found it in /var/lib/istio/data
istio-proxy@httpbin-85d76b4bb6-mldkn:/var/lib/istio/data$ ls
d8ef3957b4cf09da9ed25e88bc75ac397ea875d88c5cbed356872f936a86d928.wasm

But I still confused how envoy found it? It's name looks like an radom hash string, and I found nothing about it from envoy's config dump.

@howardjohn Thank you for your reply.  I wonder what envoy's config dump looks like after I use istio's WasmPlugin. I cannot found any information, including filename and path of the .wasm from envoy's config dump output.

Envoy has the name, it requests the name over XDS. The istio-agent knows
the mapping of name->hash (since it creates the hash)
On Sun, Jul 31, 2022 at 8:17 AM masquee @.***> wrote:

@howardjohn https://github.com/howardjohn Thank you for your reply. I
wonder what envoy's config dump looks like after I use istio's WasmPlugin.
I cannot found any information, including filename and path of the .wasm
from envoy's config dump output.
—
Reply to this email directly, view it on GitHub
https://github.com/istio/istio/issues/40172#issuecomment-1200444841, or
unsubscribe
https://github.com/notifications/unsubscribe-auth/AAEYGXJ7P2YTEX6ZHWA7MDDVW2KJPANCNFSM55AQQK6Q
.
You are receiving this because you were mentioned.Message ID:
@.***>

But I still confused how envoy found it? It's name looks like a hash string, and I found nothing about it from envoy's config dump.

envoy do not support ECDS via configdump
you can get this by running kubectl exec -it kubectl get po -nistio-system| grep istiod | grep Running | awk '{print $1}' -nistio-system -- pilot-discovery request get '/debug/ecdsz?proxyID=<your_pod_name>'


Suggestion: Expose Connector Interfaces for Databases and Queues

Hi Tork team! 👋
First off, I want to say that I really appreciate the work you're doing on this project. It's great to see support for in-memory and PostgreSQL databases, as well as in-memory and RabbitMQ queues.
Current Situation
Currently, Tork supports:

Databases: in-memory and PostgreSQL
Queues: in-memory and RabbitMQ

Suggestion
I think it would be beneficial to expose the connector interfaces for both databases and queues. This could pave the way for easier integration of additional connectors in the future.
Benefits
By exposing these interfaces, we could:

Make it easier for the community to contribute new connectors (e.g., SQLite for databases or SQS for queues)
Increase the flexibility of the project, allowing users to implement connectors for their specific needs
Potentially broaden the use cases for Tork without significantly increasing the core maintenance burden

Potential Implementation
This could involve creating abstract interfaces for database and queue connectors, which the current implementations would then implement. New connectors could simply implement these interfaces to be compatible with Tork.
Questions

What are your thoughts on this approach?
Are there any potential drawbacks or challenges you foresee?
Would you be open to a PR that implements this change?

Thank you for considering this suggestion. I'm excited to see how Tork continues to evolve!

Hi @mrchypark. Thank you for the kind words and for your suggestions.
Tork actually does already expose the Datastore and Broker as interfaces.
Furthermore, it's quite easy to register new ones when extending Tork.
See: https://www.tork.run/datastore and https://www.tork.run/broker
Does this handle these use cases?

Here's a friendly English translation of the given Korean text:
Oh, it was really well done! I feel a bit embarrassed for having written the issue. I've confirmed that both are working perfectly. Thank you so much for letting me know. In my case, I needed to add SQLite and SQS, which I think I'll be able to do now.
Thank you once again for your guidance. I really appreciate it.