Respect JSON property order

The classToJsonSchema doesn't preserve the order of fields when generating the schema. This can be significant when calling functions for the LLM to operate correctly. For example, order matters here:
{
  "instruction": ...,
  "action_based_on_instruction": ...
}

This can be done by adding an option to the JacksonModule initialization in JsonSchemaUtil.
From:
var jacksonModule = new JacksonModule(JacksonOption.RESPECT_JSONPROPERTY_REQUIRED);

To:
var jacksonModule = new JacksonModule(JacksonOption.RESPECT_JSONPROPERTY_REQUIRED,
            JacksonOption.RESPECT_JSONPROPERTY_ORDER);

@sashirestela if you're OK with it, I can open a PR.

Please, could you give us an example where the schema was not generated in the canonical order? In general I don't think the order of a function's arguments could be an issue if they are named.
Regarding your example, I think you should redesign it and split it into two or more functions. The library can handle many function calls in one shot.

This was actually a feature I wanted.

In that regard, models mostly respect the order of arguments defined in the schema when generating its answers.
In the above example we have, LLMs seems to better values for action_based_on_instruction by reflecting on the previously generated instruction parameter. If the orders of arguments were reversed, it performs very poorly.
As to @sashirestela 's inquiry about separating this into two separate function call, we had generally a better success rate with single function call specified by being explicit with tool_choice parameter. Relying on multiple function call tends to be less reliable based on our observation.
We can kind of avoid this by doing two separate LLM dispatch, but our context input for LLM calls are rather large, so want to avoid that due to cost reasons.
Changes required to enable explicit ordering of parameters for json-schema should be rather minimal, and could be done with providing JacksonOption.RESPECT_JSONPROPERTY_ORDER to the jackson module initialization to respect JsonPropertyOrder annotation, and should be non-intrusive.

@onhachoe the change seems somewhat reasonable after reading your explanation. I'm not entirely convinced, but if this is helpful for both of you, go for it. On the other hand, if you find this project valuable there are a few ways you can show us your love, preferably all of them 🙂:

Letting your friends know about this project 🗣📢.
Writing a brief review on your social networks ✍🌐.
Giving us a star on Github ⭐.

@the-gigi you could proceed with this specific change (don't touch any other part, please, because I'm working on a big refactoring for a new major release). Take in account that you will have to add more annotations to your  function's definition, as per this paragraph extracted from the library's documentation:

Optionally: sort an object's properties according to its @JsonPropertyOrder annotation, if the JacksonOption.RESPECT_JSONPROPERTY_ORDER was provided (i.e. this is an "opt-in").

@onhachoe @the-gigi New release 2.3.3 was uploaded to Maven repositories.


Support parsing of more content-types to string

Apify SDK now uses a full list of content-type headers when running locally. We should review the list and add more stringifiable types to the parseBody() function. Supposedly, all text/* types should be stringifiable, but we should double check first.

Done.


(spike) LLM integration (prototype)

Code committed to add LLM in Slashbot. Please use /summary command in telebot to generate output using LLM.

Ok cool. do update the readme with this new feature.


fix type object 'MissingValues' has no attribute '_impute_missing'

function _impute_missing() is not defined and code throw an error if param missing_categ is set to one of ['mean', 'median', 'most_frequent']

Dear @tayor,
Thanks a lot for your contribution and for adjusting the issue you encountered! PR is now merged.
All the best,
Elise


Broken links not detected in Markdown

Hey 👋 firstly wanted to say THANK YOU for this tool. It's really been a great help!
Asking for a bit of help to figure out why a broken link isn't being detected inside a Markdown file which, according to the logs, is being scanned. Using the Action with the following inputs:
          fail: true
          debug: false
          args: --verbose --no-progress './**/*.md' './**/*.html'

I have also played around with those globs to force it to pick up any Markdown file anywhere but it doesn't seem to make a difference.
See latest run here. Have a test PR being used to troubleshoot where the issue lies but so far still scratching my head. The file here has a broken link in both the /foo.md path and the /foo/bin/bar.md.  I see two instances where this is being scanned yet it's not detecting broken links. I know it has picked up on these before. These aren't excluded in the .lycheeignore file. What could possibly account for this? Any suggestions on what to troubleshoot next?

Hi, try to set --base .:
args: --verbose --no-progress --base . './**/*.md' './**/*.html'
For a more general discussion on the topic, check out https://github.com/lycheeverse/lychee/issues/1265.
I'd love to get your input on this matter in the linked issue.
Curious to hear your thoughts on what should be sane defaults for lychee around checking root-relative links.

Thanks very much, that seems to have done the trick. And thanks for referring me to another issue. I see there's a PR filed there so I'll add my two cents.
Closing as this has been resolved by adding the --base . argument to lychee.


Build: do not ship jdk when no-jdk option set

Description
When using package distribution
./gradlew :distribution:packages:no-jdk-deb:assemble

When true this include jdk switch the boolean to the correct value
Issues Resolved
fix https://github.com/opensearch-project/OpenSearch/issues/3024
Check List

[ ] New functionality includes testing.

[ ] All tests pass

[ ] New functionality has been documented.

[ ] New functionality has javadoc added

[x] Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Gradle check look to fail since https://github.com/opensearch-project/OpenSearch/pull/2924 so don't think its related to this change

Let's rebase over https://github.com/opensearch-project/OpenSearch/pull/3042 once that's merged.

org.opensearch.cluster.remote.test.RemoteClustersIT > testHAProxyModeConnectionWorks FAILED
    java.lang.AssertionError
        at __randomizedtesting.SeedInfo.seed([C65F074C70047C63:C129D2874B820A3E]:0)
        at org.junit.Assert.fail(Assert.java:87)
        at org.junit.Assert.assertTrue(Assert.java:42)
        at org.junit.Assert.assertTrue(Assert.java:53)
        at org.opensearch.cluster.remote.test.RemoteClustersIT.testHAProxyModeConnectionWorks(RemoteClustersIT.java:125)
WARNING: A terminally deprecated method in java.lang.System has been called
WARNING: System::setSecurityManager has been called by org.gradle.api.internal.tasks.testing.worker.TestWorker (file:/home/ubuntu/.gradle/wrapper/dists/gradle-7.4.2-all/9uukhhbclvbegdvsww0j0cr3p/gradle-7.4.2/lib/plugins/gradle-testing-base-7.4.2.jar)
WARNING: Please consider reporting this to the maintainers of org.gradle.api.internal.tasks.testing.worker.TestWorker
WARNING: System::setSecurityManager will be removed in a future release

start gradle check

@dblock yay all green!


Select all Filtered search result is not even working on the website

This is selecting the complete result rather than the filtered result.
Settings:-
multiselect, group by

@karangoyal2592 Issue resolved with v5.0.0. Please refer to https://cuppalabs.github.io/angular2-multiselect-dropdown/#/groupby

Thanks ..


Deliver doesn't submit for review even though it said it did.

New Issue Checklist

[x] Updated fastlane to the latest version
[x] I have read the Contribution Guidelines

Issue Description
Deliver says it successfully submitted application for review when it really didn't. We use encryption in our app as well as advertisement ID. I did not specify a config for these arguments so I imagine that it failed at that point when submitting the application for review. However, in the logs it still shows it was successfully submitted for review. I had to manually login to itunes connect and submit the application.
The deliver should return an error if it is unable to properly submit for review if that option is set to true.
Complete output when running fastlane, including the stack trace and command used

You can use: --capture_output as the last commandline argument to get that collected for you

[16:32:44]: Loading './fastlane/metadata/en-US/description.txt'...
[16:32:44]: Loading './fastlane/metadata/en-US/keywords.txt'...
[16:32:44]: Loading './fastlane/metadata/en-US/release_notes.txt'...
[16:32:44]: Loading './fastlane/metadata/en-US/support_url.txt'...
[16:32:44]: Loading './fastlane/metadata/en-US/marketing_url.txt'...
[16:32:44]: Loading './fastlane/metadata/en-US/name.txt'...
[16:32:44]: Loading './fastlane/metadata/en-US/privacy_url.txt'...
[16:32:44]: Loading './fastlane/metadata/copyright.txt'...
[16:32:44]: Loading './fastlane/metadata/primary_category.txt'...
[16:32:44]: Loading './fastlane/metadata/secondary_category.txt'...
[16:32:44]: Loading './fastlane/metadata/primary_first_sub_category.txt'...
[16:32:44]: Loading './fastlane/metadata/primary_second_sub_category.txt'...
[16:32:44]: Loading './fastlane/metadata/secondary_first_sub_category.txt'...
[16:32:44]: Loading './fastlane/metadata/secondary_second_sub_category.txt'...
[16:32:45]: Activating language en-US...
[16:32:49]: Uploading metadata to iTunes Connect
[16:32:51]: Successfully uploaded set of metadata to iTunes Connect
[16:32:51]: Starting with the upload of screenshots...
[16:32:51]: Successfully uploaded screenshots to iTunes Connect
[16:32:54]: Uploading binary to iTunes Connect
[16:32:59]: Going to upload updated app to iTunes Connect
[16:32:59]: This might take a few minutes. Please don't interrupt the script.
[16:36:19]: iTunes Transporter successfully finished its job
[16:36:19]: --------------------------------------------------------------------
[16:36:19]: Successfully uploaded package to iTunes Connect. It might take a few minutes until it's visible online.
[16:36:19]: --------------------------------------------------------------------
[16:36:19]: Finished the upload to iTunes Connect
[16:36:22]: Selecting the latest build...
[16:36:24]: Waiting iTunes Connect processing for build 2.3.3 (344.87)... this might take a while...
[16:36:56]: Waiting iTunes Connect processing for build 2.3.3 (344.87)... this might take a while...
[16:37:30]: Waiting iTunes Connect processing for build 2.3.3 (344.87)... this might take a while...
[16:38:01]: Waiting iTunes Connect processing for build 2.3.3 (344.87)... this might take a while...
[16:38:32]: Waiting iTunes Connect processing for build 2.3.3 (344.87)... this might take a while...
[16:39:04]: Waiting iTunes Connect processing for build 2.3.3 (344.87)... this might take a while...
[16:39:36]: Waiting iTunes Connect processing for build 2.3.3 (344.87)... this might take a while...
[16:40:09]: Waiting iTunes Connect processing for build 2.3.3 (344.87)... this might take a while...
[16:40:42]: Selecting build 2.3.3 (344.87)...
[16:40:43]: Successfully selected build
[16:40:43]: Submitting the app for review...
[16:40:55]: Successfully submitted the app for review!

Environment
Please run fastlane env and copy the output below. This will help us help you :+1:
If you used --capture_output option please remove this block - as it is already included there.
✅ fastlane environment ✅

### Stack

| Key                 | Value                                                          |
| ------------------- | -------------------------------------------------------------- |
| OS                  | 10.12.3                                                        |
| Ruby                | 2.0.0                                                          |
| Bundler?            | false                                                          |
| Git                 | git version 2.10.1 (Apple Git-78)                              |
| Installation Source | /usr/local/bin/fastlane                                        |
| Host                | Mac OS X 10.12.3 (16D32)                                       |
| Ruby Lib Dir        | /System/Library/Frameworks/Ruby.framework/Versions/2.0/usr/lib |
| OpenSSL Version     | OpenSSL 0.9.8zc 19 Mar 2015                                    |
| Is contained        | false                                                          |
| Is homebrew         | false                                                          |
| Xcode Path          | /Applications/Xcode.app/Contents/Developer/                    |
| Xcode Version       | 8.2.1                                                          |

### System Locale

| Variable | Value       |   |
| -------- | ----------- | - |
| LANG     | en_US.UTF-8 | ✅ |
| LC_ALL   |             |   |
| LANGUAGE |             |   |

### fastlane files:

**No Fastfile found**

**No Appfile found**

### fastlane gems

| Gem      | Version | Update-Status |
| -------- | ------- | ------------- |
| fastlane | 2.17.0  | ✅ Up-To-Date  |

### Loaded fastlane plugins:

**No plugins Loaded**

Loaded gems

| Gem                       | Version      |
| ------------------------- | ------------ |
| slack-notifier            | 1.5.1        |
| i18n                      | 0.7.0        |
| json                      | 1.7.7        |
| thread_safe               | 0.3.5        |
| tzinfo                    | 1.2.2        |
| minitest                  | 5.10.1       |
| activesupport             | <IP_ADDRESS>      |
| CFPropertyList            | 2.3.4        |
| claide                    | 1.0.1        |
| colored                   | 1.2          |
| nanaimo                   | 0.2.3        |
| xcodeproj                 | 1.4.2        |
| rouge                     | 1.11.1       |
| xcpretty                  | 0.2.4        |
| terminal-notifier         | 1.7.1        |
| unicode-display_width     | 1.1.3        |
| terminal-table            | 1.7.3        |
| plist                     | 3.2.0        |
| public_suffix             | 2.0.5        |
| addressable               | 2.5.0        |
| multipart-post            | 2.0.0        |
| word_wrap                 | 1.0.0        |
| tty-screen                | 0.5.0        |
| babosa                    | 1.0.2        |
| highline                  | 1.7.8        |
| commander                 | 4.4.3        |
| excon                     | 0.55.0       |
| faraday                   | 0.11.0       |
| unf_ext                   | <IP_ADDRESS>      |
| unf                       | 0.1.4        |
| domain_name               | 0.5.20161129 |
| http-cookie               | 1.0.3        |
| faraday-cookie_jar        | 0.0.6        |
| fastimage                 | 2.0.1        |
| gh_inspector              | 1.0.3        |
| uber                      | 0.0.15       |
| representable             | 2.3.0        |
| retriable                 | 2.1.0        |
| mime-types-data           | 3.2016.0521  |
| mime-types                | 3.1          |
| hurley                    | 0.2          |
| little-plugger            | 1.1.4        |
| multi_json                | 1.12.1       |
| logging                   | 2.1.0        |
| jwt                       | 1.5.6        |
| memoist                   | 0.15.0       |
| os                        | 0.9.6        |
| signet                    | 0.7.3        |
| googleauth                | 0.5.1        |
| httpclient                | 2.8.3        |
| google-api-client         | 0.9.28       |
| mini_magick               | 4.5.1        |
| multi_xml                 | 0.6.0        |
| rubyzip                   | 1.2.1        |
| security                  | 0.1.3        |
| xcpretty-travis-formatter | 0.0.4        |
| dotenv                    | 2.2.0        |
| bundler                   | 1.14.4       |
| faraday_middleware        | <IP_ADDRESS>     |

*generated on:* **2017-02-15**

Same problem here but without the advertisement ID. My account uses 2FA and it's not the main account for the company (but I have elevated rights at the moment).
🚫 fastlane environment 🚫

### Stack

| Key                 | Value                                                          |
| ------------------- | -------------------------------------------------------------- |
| OS                  | 10.12                                                          |
| Ruby                | 2.0.0                                                          |
| Bundler?            | false                                                          |
| Git                 | git version 2.10.1 (Apple Git-78)                              |
| Installation Source | /usr/local/bin/fastlane                                        |
| Host                | Mac OS X 10.12 (16A323)                                        |
| Ruby Lib Dir        | /System/Library/Frameworks/Ruby.framework/Versions/2.0/usr/lib |
| OpenSSL Version     | OpenSSL 0.9.8zc 19 Mar 2015                                    |
| Is contained        | false                                                          |
| Is homebrew         | false                                                          |
| Xcode Path          | /Applications/Xcode.app/Contents/Developer/                    |
| Xcode Version       | 8.2.1                                                          |

### System Locale

| Error                       |
| --------------------------- |
| No Locale with UTF8 found 🚫 |

### fastlane files:

`./fastlane/Fastfile`

```ruby
fastlane_version "1.106.2"

default_platform :ios

platform :ios do
  before_all do
    cocoapods
  end

  desc "Runs all the tests"
  lane :test do
    ensure_git_branch(
      branch: "develop"
    )
    #scan
  end

  #desc "Make screenshots"
  #lane :screenshots do
  #  snapshot
    #frameit(white: true)
  #end

  desc "Push"
  lane :push do
    #ensure_git_branch(
    #  branch: "master"
    #)
    #snapshot
    deliver(
      force: true
    )
  end
end```

`./fastlane/Appfile`

```ruby
app_identifier "REDACTED" # The bundle identifier of your app
apple_id "REDACTED" # Your Apple email address

team_id "REDACTED"  # Developer Portal Team ID

# you can even provide different app identifiers, Apple IDs and team names per lane:
# More information: https://github.com/fastlane/fastlane/blob/master/fastlane/docs/Appfile.md

fastlane gems

Gem
Version
Update-Status

fastlane
2.18.0
✅ Up-To-Date

Loaded fastlane plugins:
No plugins Loaded
Loaded gems

Gem
Version

slack-notifier
1.5.1

i18n
0.7.0

thread_safe
0.3.5

tzinfo
1.2.2

minitest
5.9.0

activesupport
4.2.6

CFPropertyList
2.3.3

claide
1.0.1

colored
1.2

nanaimo
0.2.3

xcodeproj
1.4.2

rouge
1.10.1

xcpretty
0.2.4

terminal-notifier
1.6.3

terminal-table
1.4.5

plist
3.1.0

multipart-post
2.0.0

word_wrap
1.0.0

tty-screen
0.5.0

babosa
1.0.2

highline
1.7.8

commander
4.4.0

excon
0.45.4

faraday
0.9.2

unf_ext
<IP_ADDRESS>

unf
0.1.4

domain_name
0.5.20160310

http-cookie
1.0.2

faraday-cookie_jar
0.0.6

fastimage
1.6.8

gh_inspector
1.0.2

uber
0.0.15

representable
2.3.0

retriable
2.1.0

hurley
0.2

little-plugger
1.1.4

multi_json
1.12.1

logging
2.1.0

jwt
1.5.4

memoist
0.14.0

os
0.9.6

signet
0.7.2

googleauth
0.5.1

thor
0.19.1

httpclient
2.8.0

google-api-client
0.9.8

mini_magick
4.5.1

multi_xml
0.5.5

rubyzip
1.1.7

security
0.1.3

xcpretty-travis-formatter
0.0.4

dotenv
2.1.1

bundler
1.12.5

faraday_middleware
0.10.0

json
1.8.3

generated on: 2017-02-21

```

please try to set the answers via options (submission_information in deliver:

adopt to your settings.

deliver(submission_information: {
      add_id_info_limits_tracking: true,
      add_id_info_serves_ads: true,
      add_id_info_tracks_action: true,
      add_id_info_tracks_install: true,
      add_id_info_uses_idfa: true,
      content_rights_has_rights: true,
      content_rights_contains_third_party_content: true,
      export_compliance_platform: 'ios',
      export_compliance_compliance_required: false,
      export_compliance_encryption_updated: false,
      export_compliance_app_type: nil,
      export_compliance_uses_encryption: false,
      export_compliance_is_exempt: false,
      export_compliance_contains_third_party_cryptography: false,
      export_compliance_contains_proprietary_cryptography: false,
      export_compliance_available_on_french_store: false
    })

At first it gave me an unknown error, something I considered hopeful. But after some careful massaging of the settings I'm now back at the same problem. Happy confetti yet nothing in the store. The settings are as follows:
    deliver(
      force: true,
      submission_information: {
        add_id_info_limits_tracking: false,
        add_id_info_serves_ads: false,
        add_id_info_tracks_action: false,
        add_id_info_tracks_install: false,
        add_id_info_uses_idfa: false,
        content_rights_has_rights: false,
        content_rights_contains_third_party_content: false,
        export_compliance_platform: 'ios',
        export_compliance_compliance_required: false,
        export_compliance_encryption_updated: true,
        export_compliance_app_type: nil,
        export_compliance_uses_encryption: true,
        export_compliance_is_exempt: false,
        export_compliance_contains_third_party_cryptography: true,
        export_compliance_contains_proprietary_cryptography: true,
        export_compliance_available_on_french_store: false
      },
      app_review_information: {
        first_name: 'Lucas',
        last_name: 'van Dongen',
        phone_number: '+43 11111',
        email_address<EMAIL_ADDRESS>        demo_user: 'test1234',
        demo_password: 'test1234',
        notes: ''
      }
    )

The app does use a lot of encryption but won't be used outside of the US AppStore.

Yes when using the subission_information param it works, but this task was more created for the false status of it saying it was submitted when it wasn't. This could leave people with CI to believe their application was submitted if they don't go in and check the itunes connect status after each deliver.

@jostster it still behaves the same here with the submission_information

Same issue here with fastlane 2.18.3. Deliver says success for review submission and it never submitted. Manually submitting using iTunesConnect site works fine. @jostster to answer your question it asks about 3 things: crypto usage, third party content usage, and Advertising ID usage.

@jostster and @LucasVanDongen - did this work for you in previous versions of fastlane? This is personally my first go of it and so far the only issue I've encountered.

I hadn't tried it in previous version. However, I did submit today and it went through fine. Here is my lane that worked. I only do encryption and ad tracking. I haven't tried a version yet where the encryption has changed but with these values when I submit when my encryption hasn't changed works.
lane :deploy_appstore do |values|
  	app_submission_info = {
		add_id_info_uses_idfa: true,
		add_id_info_tracks_install: true,
		add_id_info_tracks_action: true,
		add_id_info_limits_tracking: true,
		export_compliance_encryption_updated: false
	}
    deliver(ipa:"app.ipa", submit_for_review: true, submission_information: app_submission_info)
    slack(message: "Successfully submitted to appstore!", success: true)
  end

my recommendation is deliver should return a value if it was successful or not. the only way it is successful is if it succeeds based on the params. This task was created because with the app_submission_info not set but submit_for_review: true, it would say it was submitted for review but it really errored out because it didn't pass the submission_information which is required before submission.

Interesting because @LucasVanDongen, like me, is saying his still wasn't working even after adding all that submission info. I am currently only setting the following
submission_information({   add_id_info_serves_ads: false,   export_compliance_contains_third_party_cryptography: false })
and mine is succeeding but not being submitted for review. I will try your settings, with them obviously set to false since we don't use Ads or crypto and see if that combo gets it to actually submit. I definitely have submit_for_review:true because without it you don't even get the log about it being submitted for review (even though it actually is not submitting)

Just attempted it with info I had above plus the properties from @jostster as submission info and this time it worked! So does this mean fastlane/ITC requires some of those properties?

@stonedauwg if you go into ITC and attempt to submit manually does it prompt you with some check boxes to check? if so then those are the fields that you will need to specify in fastlane.

@jostster That's the strange thing, manually it asks about: export crypto, 3rd party content and Ad IDs. I only specified 2 of those 3 in the submission info above as you can see. I did not specify the content_rights_contains_third_party_content property, so it can't be as simple as just have the ones it asks for on the web portal. Must be something else that ITC requires that fastlane deliver doesn't warn about not providing

so if you specify content_rights_contains_third_party_content then it wont submit? because in your previous post you said submission_information({ add_id_info_serves_ads: false, export_compliance_contains_third_party_cryptography: false }) which is different.

@jostster I tried those two plus the third option of content_rights_contains_third_party_content and it did not work. So its definitely one of the other settings it requires. If I had to guess maybe add_id_info_uses_idfa but I'd have to try them one at a time to be sure

Got it work again, this time only with these minimal settings:
submission_information({
  add_id_info_serves_ads: false,
  export_compliance_contains_third_party_cryptography: false,
  export_compliance_encryption_updated: false,
  add_id_info_uses_idfa: false,
  content_rights_contains_third_party_content: false
})

Previous to that I had sent the 4 above minus export_compliance_encryption_updated, so that was defineitely key. That said, I'm not sure if some of those above I know arent necessary, but that is the 5 I seem to need to get it to submit

issue seems to be resolved - going to close it, feel free to reopen or file a new one at any time

@hjanuschka I dont think this is resolved. The issue was originally created as the deliver says it WAS submitted for review when it really wasn't. Submit is not checking for a proper response it seems before relaying it was submitted.

I agree with @jostster
After iterating over a few variations I ended up with this:
    deliver(
      force: true,
      app_review_information: {
        #redacted out
      },
      submission_information: {
        add_id_info_serves_ads: false,
        export_compliance_contains_third_party_cryptography: false
      },
      app_version: "3.4.2"
    )

I was actually surprised to see it appear in iTunes Connect all of a sudden!

This does not seem to be resolved:
INFO [2017-04-21 10:27:42.76]: Submitting the app for review...
INFO [2017-04-21 10:28:11.07]: Successfully submitted the app for review!
app not submitted for review.
Just to be clear, this issue is with the reporting of success when not successful, not the failure - I assume that if I correct the problem in the deliver call (thanks @LucasVanDongen for the info) it should work.

Same for me
[17:52:22]: Successfully selected build
[17:52:22]: Submitting the app for review...
[17:52:33]: Setting 'add_id_info_serves_ads' to 'false'...
[17:52:33]: Setting 'export_compliance_contains_third_party_cryptography' to 'false'...
[17:52:33]: Setting 'export_compliance_encryption_updated' to 'false'...
[17:52:33]: Setting 'add_id_info_uses_idfa' to 'false'...
[17:52:33]: Setting 'content_rights_contains_third_party_content' to 'false'...
[17:52:35]: Successfully submitted the app for review!
Build was selected, but app is still in Prepare for sumbittion status

How do I specify submission_information through Shell. I'm using fastlane deliver command through bash on Mac server. Here goes the command. I'm not sure how do I pass export_compliance and idfa information through this.
fastlane deliver --skip_binary_upload --submit_for_review -x false -f true  -u<EMAIL_ADDRESS>

Still having this issue with Fastlane 2.61.0. Deliver is reporting success although it failed to submit the app for review.

@DMAPro I think the best approach is uploading it manually, note all the things that are asked and what you answered and add only that information and nothing else. This tool automates that process and if you are adding stuff that is not required (like answering a question never asked in your path) you might trigger unexpected problems.

@LucasVanDongen, thanks. That's understood. The issue isn't that Fastlane doesn't do something. The issue is exactly that Fastlane says it did something when it didn't. So, in any case with any release we've got to go to iTunesConnect and manually verify that it was actually submitted, or verify that we received a confirmation e-mail from Apple.
If deliver said, that it was able to upload metadata, but not to submit the app for review, it would be a valid behavior.
In any case, deliver is still extremely helpful, since all I have to do now is just press "Submit for review". But if it was possible to trust the "success" message that it returns again, it would be great :)

@DMAPro that's right, Fastlane should either ignore incompatible sets of parameters, show a warning or even stop with an error. All would be better than getting a positive confirmation while it fails.

@LucasVanDongen True. Do you know if there's anything we need to do to get this issue reopened? Or is activity in the comments enough? Maybe we should @-mention anyone from the Fastlane team?

@DMAPro @LucasVanDongen I'm taking a look at this today.

Oh boy. I found the root cause of this. Looks like Apple started returning errors in different places. Working on a fix.


broken downloads link

The interactions tsv download appears to be broken.
http://www.dgidb.org/downloads/data/interactions.tsv

The URL has changed. The download is now: http://dgidb.org/data/interactions.tsv

I don't see this update on the live site ...

Actually what is happening is that I get the old version of the site here:
http://www.dgidb.org/downloads/
But the new version here:
http://www.dgidb.org/downloads
Interesting.

Yeah, the trailing slash seems to make a difference. Problem is likely in config/routes.

I haven't been able to find out much. This url does not get resolved through config/routes but instead has a static page at app/views/static/downloads.html.haml that gets served directly. Interestingly, the staging environment behavior is as expected and both pages contain the correct links. I'm really not sure what is going on here.

This was an issue with passing relative paths to link_to. Changed to absolute paths, now resolves correctly regardless of dgidb.org/downloads or dgidb.org/downloads/ view.


Use uSOE for battery level to match car display

Updates the can signal to use uSOE which more accurately reflects what the car shows.
Pictures taken at same time:

Watched it drop at the same time as my main display.


High RAM consumption during "parsing story ..."

I work on a Toshiba 2 Swanky Chromebook, with ubuntu 16.04 64 bits, I do not know if that influences. I have 4 gigabytes of RAM and 1 of SWAP. I realized that the more scenes I put, the consumption of the increased alarmingly. I have about 20 interconnected scenes with some 10 variables. Compiling swallows the entire ram and almost the entire swap.

Even eliminating all uses of [] (?) [] (&) [] (#) Consumes an exorbitant amount of RAM. It is only a file with several sections ## and links with nothing of mathematics. There must be some bug, because pandoc compiles it in seconds and with very few resources.

@ByFernanz is there a chance you could share a story file with me that exhibits this behavior?
It is possible for the number of scenes to increase exponentially depending on the various possible variable configurations. The calculation for most pages needed would be scenes * 2 ^ variables. In the case of ten variables and twenty scenes you get 20 * 2 ^ 10 = 20 * 1,024 = 20,480, so assuming that all ten of your variables come into play at the final scene(s) of your story, it may have to resolve and generate over 20 thousand pages.
Even so, I wouldn't expect that to saturate 5gb of RAM, so it is possible there is a bug or inefficiency going on that I haven't been able to reproduce.

Of course! There I share it with you. The file must have more than 70 sections. I attach the version for ficdown as the one of pandoc. In Pandoc only consumes 50mb of ram and with low processor consumption and produces the html in a few seconds. Ficdown stays compiling, devoting more and more ram, I consume 50% of the processor, until I have to kill the process.
test-ficdown-pandoc.zip

This may be fixed in v1.1.1 now.


Add e2e test for multiple APIServices on a pod

This commit introduces a test that ensures that a single pod can support
multiple APIServices.

/retest

/retest

/retest

/retest

/retest


Feature Request: extract promote in code as a profile, can change customly or provide officially

extract promote in code as a profile, can change customly or provide officially

Can you please explain what it is you are requesting? thanks.


HBASE-24718 : Generic NamedQueue framework for multiple use-cases (Refactor SlowLog responses)

Closes #2052
Signed-off-by: Wellington Chevreuil<EMAIL_ADDRESS>

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
0m 33s
Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  1s
No case conflicting files found.

+0 :ok:
prototool
0m  1s
prototool was not available.

+1 :green_heart:
hbaseanti
0m  0s
Patch does not have any anti-patterns.

+1 :green_heart:
@author
0m  0s
The patch does not contain any @author tags.

_ master Compile Tests _

+0 :ok:
mvndep
0m 22s
Maven dependency ordering for branch

+1 :green_heart:
mvninstall
3m 35s
master passed

+1 :green_heart:
checkstyle
3m 20s
master passed

+0 :ok:
refguide
4m 52s
branch has no errors when building the reference guide. See footer for rendered docs, which you should manually inspect.

+1 :green_heart:
spotbugs
8m 17s
master passed

-0 :warning:
patch
2m  4s
Used diff version of patch file. Binary files and potentially other changes not applied. Please rebase and squash commits if necessary.

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 14s
Maven dependency ordering for patch

+1 :green_heart:
mvninstall
3m 17s
the patch passed

-0 :warning:
checkstyle
1m  7s
hbase-server: The patch generated 18 new + 113 unchanged - 4 fixed = 131 total (was 117)

+1 :green_heart:
rubocop
0m  7s
There were no new rubocop issues.

+1 :green_heart:
whitespace
0m  0s
The patch has no whitespace issues.

+1 :green_heart:
xml
0m  2s
The patch has no ill-formed XML file.

+0 :ok:
refguide
4m 56s
patch has no errors when building the reference guide. See footer for rendered docs, which you should manually inspect.

+1 :green_heart:
hadoopcheck
11m  9s
Patch does not cause any errors with Hadoop 3.1.2 3.2.1.

+1 :green_heart:
hbaseprotoc
3m 17s
the patch passed

+1 :green_heart:
spotbugs
9m 37s
the patch passed

_ Other Tests _

+1 :green_heart:
asflicense
1m  5s
The patch does not generate ASF License warnings.

66m 35s

Subsystem
Report/Notes

Docker
Client=19.03.12 Server=19.03.12 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-2109/1/artifact/yetus-general-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/2109

Optional Tests
dupname asflicense spotbugs hadoopcheck hbaseanti checkstyle refguide xml cc hbaseprotoc prototool rubocop

uname
Linux e5143171e9fc 4.15.0-60-generic #67-Ubuntu SMP Thu Aug 22 16:55:30 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
master / fccd03ffa2

refguide
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-2109/1/artifact/yetus-general-check/output/branch-site/book.html

checkstyle
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-2109/1/artifact/yetus-general-check/output/diff-checkstyle-hbase-server.txt

refguide
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-2109/1/artifact/yetus-general-check/output/patch-site/book.html

Max. process+thread count
94 (vs. ulimit of 12500)

modules
C: hbase-protocol-shaded hbase-common hbase-client hbase-server hbase-thrift hbase-shell U: .

Console output
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-2109/1/console

versions
git=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f) spotbugs=3.1.12 rubocop=0.80.0

Powered by
Apache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
0m 29s
Docker mode activated.

-0 :warning:
yetus
0m  3s
Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck

_ Prechecks _

_ master Compile Tests _

+0 :ok:
mvndep
0m 23s
Maven dependency ordering for branch

+1 :green_heart:
mvninstall
3m 40s
master passed

+1 :green_heart:
compile
3m 21s
master passed

+1 :green_heart:
shadedjars
5m 37s
branch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
2m 23s
master passed

-0 :warning:
patch
9m  4s
Used diff version of patch file. Binary files and potentially other changes not applied. Please rebase and squash commits if necessary.

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 16s
Maven dependency ordering for patch

+1 :green_heart:
mvninstall
3m 24s
the patch passed

+1 :green_heart:
compile
3m 23s
the patch passed

+1 :green_heart:
javac
3m 23s
the patch passed

+1 :green_heart:
shadedjars
5m 36s
patch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
2m 19s
the patch passed

_ Other Tests _

+1 :green_heart:
unit
0m 47s
hbase-protocol-shaded in the patch passed.

+1 :green_heart:
unit
1m 25s
hbase-common in the patch passed.

+1 :green_heart:
unit
1m  1s
hbase-client in the patch passed.

+1 :green_heart:
unit
138m 32s
hbase-server in the patch passed.

+1 :green_heart:
unit
4m 53s
hbase-thrift in the patch passed.

-1 :x:
unit
11m 25s
hbase-shell in the patch failed.

191m 44s

Subsystem
Report/Notes

Docker
Client=19.03.12 Server=19.03.12 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-2109/1/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/2109

Optional Tests
javac javadoc unit shadedjars compile

uname
Linux 3a8a552db09f 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
master / fccd03ffa2

Default Java
1.8.0_232

unit
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-2109/1/artifact/yetus-jdk8-hadoop3-check/output/patch-unit-hbase-shell.txt

Test Results
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-2109/1/testReport/

Max. process+thread count
4415 (vs. ulimit of 12500)

modules
C: hbase-protocol-shaded hbase-common hbase-client hbase-server hbase-thrift hbase-shell U: .

 Binary files and potentially other changes not applied. Please rebase and squash commits if necessary.

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 14s
Maven dependency ordering for patch

+1 :green_heart:
mvninstall
4m  4s
the patch passed

+1 :green_heart:
compile
3m 55s
the patch passed

+1 :green_heart:
javac
3m 55s
the patch passed

+1 :green_heart:
shadedjars
6m  2s
patch has no errors when building our shaded downstream artifacts.

-0 :warning:
javadoc
0m 17s
hbase-common in the patch failed.

-0 :warning:
javadoc
0m 28s
hbase-client in the patch failed.

-0 :warning:
javadoc
0m 43s
hbase-server in the patch failed.

-0 :warning:
javadoc
0m 53s
hbase-thrift in the patch failed.

_ Other Tests _

+1 :green_heart:
unit
1m  2s
hbase-protocol-shaded in the patch passed.

+1 :green_heart:
unit
1m 39s
hbase-common in the patch passed.

+1 :green_heart:
unit
1m 10s
hbase-client in the patch passed.

+1 :green_heart:
unit
136m 21s
hbase-server in the patch passed.

+1 :green_heart:
unit
3m 38s
hbase-thrift in the patch passed.

-1 :x:
unit
10m 54s
hbase-shell in the patch failed.

192m 11s

Subsystem
Report/Notes

Docker
Client=19.03.12 Server=19.03.12 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-2109/1/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/2109

Optional Tests
javac javadoc unit shadedjars compile

uname
Linux 935a5ee4812a 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
master / fccd03ffa2

Default Java
2020-01-14

javadoc
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-2109/1/artifact/yetus-jdk11-hadoop3-check/output/branch-javadoc-hbase-client.txt

javadoc
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-2109/1/artifact/yetus-jdk11-hadoop3-check/output/branch-javadoc-hbase-common.txt

javadoc
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-2109/1/artifact/yetus-jdk11-hadoop3-check/output/branch-javadoc-hbase-server.txt

javadoc
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-2109/1/artifact/yetus-jdk11-hadoop3-check/output/branch-javadoc-hbase-thrift.txt

javadoc
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-2109/1/artifact/yetus-jdk11-hadoop3-check/output/patch-javadoc-hbase-common.txt

javadoc
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-2109/1/artifact/yetus-jdk11-hadoop3-check/output/patch-javadoc-hbase-client.txt

javadoc
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-2109/1/artifact/yetus-jdk11-hadoop3-check/output/patch-javadoc-hbase-server.txt

javadoc
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-2109/1/artifact/yetus-jdk11-hadoop3-check/output/patch-javadoc-hbase-thrift.txt

unit
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-2109/1/artifact/yetus-jdk11-hadoop3-check/output/patch-unit-hbase-shell.txt

Test Results
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-2109/1/testReport/

Max. process+thread count
4394 (vs. ulimit of 12500)

modules
C: hbase-protocol-shaded hbase-common hbase-client hbase-server hbase-thrift hbase-shell U: .

Console output
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-2109/1/console

versions
git=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f)

Powered by
Apache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.


Incorrect documentation - Create ExpressRoute Gateway (classic)

Configure a virtual network gateway for ExpressRoute using PowerShell (classic)
https://docs.microsoft.com/en-us/azure/expressroute/expressroute-howto-add-gateway-classic
Scenario #1:

Classic VNET without a Gateway
When I try to create a new Gateway following the documentation, I get this error:
New-AzureVNetGateway : BadRequest: The specified virtual network name 'test456' is not valid or could not be found.

Scenario #2:

Classic VNET with an existing Gateway
After deleting the Gateway, I try to run the same command, but get the same error

I've been able to create the Gateway by editing the network profile via resources.azure.com where I changed the LocalNetworkSite / ConnectionType from "IpSec" to "Dedicated", but I was not able to replicate the steps.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: ce2237de-0e49-0038-ce36-3e1d2858cd40
Version Independent ID: b225d087-ec76-2614-7eb8-9129c8c7d831
Content: Configure a VNet gateway for ExpressRoute using PowerShell: classic: Azure
Content Source: articles/expressroute/expressroute-howto-add-gateway-classic.md
Service: expressroute
GitHub Login: @charwen
Microsoft Alias: charwen

@carteixeira The error you describe in Scenario #1 states that it was unable to find a VNET in your subscription with the given name.
This is usually due to a classic VNET not existing in your subscription with the name 'test456', or you are in the wrong subscription in Azure PowerShell. Make sure you are using Azure Classic Powershell and have selected your subscription using Select-AzureSubscription -subscriptionID "your subscription ID here".

Travis, if you try to follow the article, you will see that it does not work.
Here is from a different subscription:
PS C:\Users\carte> New-AzureVNetGateway -VNetName Local4 -GatewayType DynamicRouting -GatewaySKU  Standard
New-AzureVNetGateway : BadRequest: A gateway is not specified in the network configuration file for the specified virtual network name: Local4. Make sure that a gateway which references a local network site is specified.
At line:1 char:1

New-AzureVNetGateway -VNetName Local4 -GatewayType DynamicRouting -Ga ...

  + CategoryInfo          : CloseError: (:) [New-AzureVNetGateway], CloudException
  + FullyQualifiedErrorId : Microsoft.WindowsAzure.Commands.ServiceManagement.Network.Gateway.NewAzureVNetGatewayCommand

To solve this, I had to first create a GatewaySubnet, go to resources.azure.com and add the following (for the scenario where there is currently no GW):
],
"gatewayProfile": {
  "size": "Medium",
  "localNetworkSites": [
    {
      "localNetworkSiteName": "to-ARM-vpn",
      "addressSpace": [
        "<IP_ADDRESS>/24"
      ],
      "vpnGatewayIpAddress": "<IP_ADDRESS>",
      "connectionTypes": [
        "**Dedicated**"
      ]
    }
  ]

When a GW was present in the past, the GatewaySubnet is usually there and the connection type needs to be changed from IpSec to Dedicated.
After that, it allowed me to run the PowerShell command successfully.

@carteixeira Thanks for the feedback! I have assigned the issue to the content author to evaluate and update as appropriate.

I'll update the article to show the steps to add in the required values for the network configuration file. Because the virtual network was not previously associated with a local network site or a gateway, it was missing some values that I will call out.

#please-close

@carteixeira We will now proceed to close this thread. If there are further questions regarding this matter, please reopen it and we will gladly continue the discussion.


Doesn't work on Linux at all

With both default key binding (which is problematic due super) or other one.

If the default key binding isn't working (window + alt + n), are there any errors in the ST log? If there are not any errors, it's possible another plugin is also using the same key binding. You can enter sublime.log_commands(True) in the ST console, followed by the key binding to see what is being executed.
You may also try manually running the command from the ST console by entering window.run_command("advanced_new_file_new").  This would verify that the plugin is loaded properly.
Please let me know the results of the above action as it will help in narrowing down the issue.

window + alt + n causes unity bar to appear, nothing happens in sublime, nothing logged even with sublime.log_commands(True). This is expected as unity doesn't allow rebinding anything with super in it.
I added this to my user keybindings:
    { "keys": ["ctrl+alt+n"], "command": "advanced_new_file_new"},

But when I press ctrl+alt+n nothing happens, no error in sublime console.
This is console log with logging turned on:
>>> sublime.log_commands(True)
command: drag_select {"event": {"button": 1, "x": 707.5, "y": 580.5}}
command: advanced_new_file_new # I pressed ctrl+alt+n here
command: advanced_new_file_new # and here
command: drag_select {"event": {"button": 1, "x": 551.5, "y": 1012.5}}
command: paste
>>> window.run_command("advanced_new_file_new")

After last call nothing happened and nothing was printed to console.
I am on Ubuntu 14.10, Sublime Text 3 Build 3065.

Hmm interesting, how did you install the plugin? It's possible something went wrong during the install process.
When you start ST, you should see something similar to the following in the ST console. reloading plugin AdvancedNewFile.AdvancedNewFile. It should be in the list of all the plugins being loaded. Do you see such an entry? If not, it's possible that AdvancedNewFile did not get installed, or was installed improperly. You may also see error messages following the command. If you do, please post those.
If you use Package Control to install the plugin, you can also look for the "Package Control: List Packages" command to see what is installed on your system.

Hmm, during startup Sublime Text 3 says:
ignored packages updated to: [..., AdvancedNewFile, ...]

So, it ended up ignored. I probably disabled it by accident, since I can't remember doing. Many thanks for walking me through this and sorry for filing this issue.
For anyone, who googled this:

Hit Ctrl+Shift+P.
Type "enable" and choose "Package Control: Enable Package".
Select "AdvancedNewFile".

Interesting, it's possible package control did something in the background and hit some sort of error. Anyways, glad the issue is resolved. Thanks for using AdvancedNewFile.

I got this figured out (I think). The issue is that for some reason 'super+alt' is misinterpreted by ubuntu.
What I did was change 'super' to 'ctrl' in Preferences -> Package Settings -> AdvancedFileNew-> key binding -user :
[
{ "keys": ["ctrl+alt+n"], "command": "advanced_new_file_new"},
{ "keys": ["shift+ctrl+alt+n"], "command": "advanced_new_file_new", "args": {"is_python": true}},
{
"keys": ["tab"],
"command": "insert",
"args": {"characters": "\t"},
"context": [{
"key": "setting.anf_panel"
}]
}
]

You can't use Super as part of user-defined key bindings in Ubuntu, it's use is reserved for system.

@sour when one installs AdvancedNewFile the default key bindings are:
{ "keys": ["super+alt+n"], "command": "advanced_new_file_new"} and
{ "keys": ["shift+super+alt+n"], "command": "advanced_new_file_new", "args": {"is_python": true}}.....
thats why one needs to change it in the user defined key nindings


Code Blocks (Listings)

For the documentation we will need code blocks.

New ideas:
Thingy name: #CODE#,
with options:

src: The source file to read code from
caption: Caption for the code/listing
label: Internal document reference label (We don't have to implement it, as this works for all Thingys already)
language: May be used for syntax highlighting (Not to be developed now, as this will be a lot of work, we have to find a good library in the best case). If the src file is an *.rtf (Rich Text Format) file we can try to use the formatting from that file?

Code block specific styles should be entered in the Thaw document style file:

Show line numbers
Line numbering style
Background color
Font size and settings (what monospaced font to use)
Alternating line background colors
...

For syntax highlighting we could use something like Pygments which requires a python interpreter.
But we can call it from Java (https://pygments.org/docs/java/).
The resulting HTML could be parsed and typeset properly.

Created branch codeblocks

After researching quite a bit I found out that Pygments does no more support Python 2.x, thus we cannot use Jython if we want to be able to update Pygments (new languages, ...).
Therefore the following plan:

Either provide the code in an preformatted RTF-file (For example by copying code from your favorite IDE and pasting it in word and then saving it as RTF file). The file will be read by Thaw and displayed as listing without any syntax highlighting needed.
When wanting to syntax highlight code files, the user should be prompted to install python first (when not installed) as well as a instructions to install pygments. Afterwards pygments will be called from Thaw to do syntax highlighting. Advantage is that we don't have to care for updating pygments. Although breaking changes in pygments updates might break our logic.

If python is not installed on the machine print:
In order to syntax highlight code blocks you need to install python on your machine (https://www.python.org/).
Afterwards you will need to install Pygments using `pip install pygments`.

If only Pygments is not installed print:
In order to syntax highlight code blocks you need to install Pygments using `pip install pygments`.
Afterwards please try again.

TODO

[ ] Call Pygments pygmentize over the command line using Java

[ ] Print 'please install' messages (see last comment) when either Python or Pygments is not installed
[ ] Output Pygments result as RTF (Rich-Text-Format) to a temporary file (For example pygmentize -f rtf -l java -o test.rtf MyClass.java) - File should be deleted after use

[ ] Parse RTF file to a code block (DocumentNode), that can be directly typeset by Thaw

[ ] Should use the code font (monospaced font) set in the style file
[ ] Honor new settings in style file (to be created) - code style block

[ ] Show line numbers - "linenumbers": "true" (Default = true)

[ ] Create #CODE# thingy

[ ] Create Options:

[ ] src - Path to the source file that contains the code to show (Required) - Either first argument or src-option!

[ ] Can be a RTF file directly -> No syntax highlighting -> lang option will be ignored (if specified)
[ ] Other file (*.java, *.c, ...) -> any file ending -> Pygments will be used to syntax highlight

[ ] lang - Name of the language to use (Optional - when not specified will be guessed)
[ ] style - Style to use (See pygmentize -L for a full list or https://help.farbox.com/pygments.html for an overview) - User will be able to specify the style name that should be used

[ ] (To be reconsidered when all the above things are done) Cache already processed (unchanged - based on hash) syntax highlighting results in the ~/.thaw/cache directory to save some time while rebuilding the document

Captions will be done in #19

codeblocks branch has been merged. Done.


V2 - Company Not Found - Organization exists message is not displayed even if organization exists when searched by partial text

Prerequisite

Create a CLA group with CCLA enabled
Add github repository for the CLA group
Generate template

Steps to Follow

Login to Github as corporate contributor
Navigate to the repository used in prerequisite
Create PR
CLA check fails
Click on CLA NOT SIGNED
Contributor is redirected to Contributor Console
Click on Proceed as a Corporate Contributor
Click on building icon
Click on Organization not listed? + Click Here
Enter value BlackBean in Enter Organization Name field
Observed that Organization exists message is not displayed
NOTE: Observed the same issue with Organization website

When complete name is provided it works fine

@nirupamav Now this ticket is deprecated due to change in workflow mentioned in ticket #1613


Floating label doesn't work properly with events

I am having issue with FloatingLabel, whenever I use onChangeText event, my floating label floats at his starting position when I write something. But it works perfectly when I don't use onChangeText , onBlur and other events. Please help!
    <FloatingLabel
              labelStyle={Styles.labelInput}
              inputStyle={Styles.input}
              style={Styles.formInput}
              underlineColorAndroid="transparent"
              secureTextEntry={true}
              onChangeText={(password) => this.setState({password})}
          >Password</FloatingLabel>

Styles:
 labelInput: {
    fontSize: 16,
  },

  formInput: {
    borderBottomWidth: 1,
    borderColor: '#e6e6e6',
  },
  input: {
    fontSize: 14,
    borderWidth: 0
  }

Please help!

@AhsanAk I had to dig into code and finally found a solution - just pass value prop (as you do for regular TextInput) and it should work.


Merge: Release 0.0.1 into Develop

Description

Type of Change

[ ] ✨ New feature (non-breaking change which adds functionality)
[ ] 🛠 Bug fix (non-breaking change which fixes an issue)
[ ] ❌ Breaking change (fix or feature that would cause existing functionality to change)
[ ] 🧹 Code refactor (restructuring and optimizing existing code without changing its external behavior)
[ ] ✅ Build configuration change (changes to build configurations or project dependencies)
[ ] 📝 Documentation (updates or additions to project documentation)
[ ] 🗑 Chore (maintenance tasks or small fixes that don't fall into the other categories, such as updating build scripts, etc.)

4 test failed


Update pom to Major Development Version

Get latest changes from master and update pom to 2.0.0 major version for IPK.

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.5 out of 6 committers have signed the CLA.:white_check_mark: ShanChathusanda93:white_check_mark: piraveena:white_check_mark: Anandi-K:white_check_mark: ThaminduDilshan:white_check_mark: ImalshaG:x: wso2-jenkins-botYou have signed the CLA already but the status is still pending? Let us recheck it.


TODO: Export all stored keys

Generate a backup file (.json or .toml or .txt) all keys stored.

@waldirborbajr i am interested in your project. Can you attach some getting started guide, more info and assign it to me?

implemented to release v0.2.1


The last row in the monitoring screen gets hidden

Describe the bug
The details in the last row of the table in the monitoring screen gets hidden.
To Reproduce
Steps to reproduce the behaviour:

Go to the monitoring screen in the UI
Scroll down to the bottom of the page

Expected behaviour
The details in the last row should be clearly visible.
Screenshots

Desktop (please complete the following information):

OS: Mac OS
Version: 6c35419

I have fixed this issue kindly dont work on it pushing the commit but some error is there due to husky discussiong on it


client_secret like "Abc123++" get token failed

ClientSecretBasicAuthenticationConverter line 88-89
"Abc123++" after URLDecoder.decode change to "Abc123  "
###############
Basic Authentication set client_id and client_secret in the header. So no need to URLDecoder.decode again!

Hi @funs690. The converter is implemented to spec, per RFC 6749, Section 2.3.1. You can provide your own converter if you wish to deviate from the url encoding/decoding specified by the spec. For example:
OAuth2AuthorizationServerConfigurer<HttpSecurity> authorizationServerConfigurer =
		new OAuth2AuthorizationServerConfigurer<>();
authorizationServerConfigurer.clientAuthentication(clientAuthentication -> clientAuthentication
		.authenticationConverter(new MyClientSecretBasicAuthenticationConverter()));

If you are interested in learning more about customizing client authentication, please up-vote #540, as we are currently prioritizing what guides we work on for our reference documentation based on community feedback.
I'm going to close this issue, as the implementation is working according to the specification.

.authenticationConverter

Hi @sjohnr, I am facing the same issue and I tried to implement my own AuthenticationConverter with the changes as you suggested
    @Bean
    @Order(HIGHEST_PRECEDENCE)
    fun defaultSecurityFilterChain(http: HttpSecurity): SecurityFilterChain {
        val authorizationServerConfigurer = OAuth2AuthorizationServerConfigurer<HttpSecurity>()
            .clientAuthentication { clientAuthentication: OAuth2ClientAuthenticationConfigurer ->
                clientAuthentication.authenticationConverter(CustomClientSecretBasicAuthenticationConverter())
            }

        http.authorizeRequests { authorizeRequests ->
            authorizeRequests.antMatchers(
                ACTUATOR_PATH,
                TOKEN_VALIDATION_PATH
            ).permitAll()
            authorizeRequests.anyRequest().authenticated()
        }.apply(authorizationServerConfigurer)
        return http.build()
    }

However, it always defaults to ClientSecretBasicAuthenticationConverter.
Any feedback on this is appreciated. Thanks!

@shmonika, did you intend to put this code in the defaultSecurityFilterChain() method? In our samples, there are two filter chains, and the one you want to be modifying would be authorizationServerSecurityFilterChain().

@shmonika, did you intend to put this code in the defaultSecurityFilterChain() method? In our samples, there are two filter chains, and the one you want to be modifying would be authorizationServerSecurityFilterChain().

@sjohnr Yeah, that was it. Thank you for your quick response :)


include io-blksize parameter

Closes #2864

Is there something I need to do to close this pull request?

No, I should've merged this 8 days ago :)

FYI I noticed this test failure today:
failures:

---- test_split::test_split_number_with_io_blksize stdout ----
current_directory_resolved:
run: /home/alex/code/rust/coreutils/target/debug/coreutils split -n 5 asciilowercase.txt ---io-blksize 1024
open: /tmp/user/1000/.tmpM2oq8D/xaa
open: /tmp/user/1000/.tmpM2oq8D/xab
open: /tmp/user/1000/.tmpM2oq8D/xac
open: /tmp/user/1000/.tmpM2oq8D/xad
open: /tmp/user/1000/.tmpM2oq8D/xae
thread 'test_split::test_split_number_with_io_blksize' panicked at 'assertion failed: `(left == right)`
  left: `"uvwxyz\n"`,
 right: `"uvwxyz"`', /home/alex/code/rust/coreutils/tests/by-util/test_split.rs:466:5

Running my system split manually it looks like the behavior is correct, so the expectation should be updated to include the \n.

@alextibbles Good catch. Looks like one of the previous commit changes lost during this merge.
@tertsdiepraam Should I just repush the changes as a commit?

@alextibbles Good catch. I have to update a newly introduced test case to incorporate some changes between the commit and the merge.

I created a pull request #3140. Please take a look.


create a data source that vends multiple cell types?

Checklist

[x] Reviewed the README and documents.
[x] Searched existing issues for ensure not duplicated.

Expected Behavior
I'd like to use DiffableDataSources with different cell types.
Current Behavior
I'm able to create a single data source and single cell type and apply the changes. I'm obviously missing something because I cannot figure out how to create a data source that vends multiple object types. (I tried creating multiple data sources, but then ended up with the dreaded UICollectionView exceptions about attempt to delete item 2 from section 0 which only contains 2 items before the update.)
Detailed Description (Include Screenshots)
Here is how I'm creating "article" cells. I'm not sure how to create another cell type.

enum Section: Int, CaseIterable {
    case trends = 0
    case articles

    var cellIdentifier: String {
        switch self {
        case .trends:
            return "trendCell"
        case .articles:
            return "articleCell"
        }
    }
}

lazy var dataSource = CollectionViewDiffableDataSource<Section, Article> (collectionView: collectionView) { collectionView, indexPath, _ /*identifier*/ in
    if let cell = collectionView.dequeueReusableCell(withReuseIdentifier: Section.articles.cellIdentifier, for: indexPath) as? ArticleCollectionViewCell {
        cell.article = self.articles[indexPath.item]
        return cell
    }

    fatalError()
}

var articles: [Article] = [] {
    didSet {

            let snapshot = DiffableDataSourceSnapshot<Section, Article>()
            snapshot.appendSections([.articles])
            snapshot.appendItems(articles, toSection: .articles)
            dataSource.apply(snapshot, animatingDifferences: true)
        }
    }
}

Environment

version: 0.1.0

Swift version: 5.0

iOS version: 12.2

Xcode version: 10.2.1

Devices/Simulators: iPhone X

CocoaPods/Carthage version: 0.33.0

I think i figured it out. :)
Creating the data source to produce a more generic AnyHashable allows any type of object to be created. So, you just need to cast the AnyHashable to your specific class. For example:
    lazy var dataSource = CollectionViewDiffableDataSource<Section, AnyHashable> (collectionView: collectionView) { collectionView, indexPath, item in

        if let article = item as? Article, let cell = collectionView.dequeueReusableCell(withReuseIdentifier: Section.articles.cellIdentifier, for: indexPath) as? ArticleCollectionViewCell {
            cell.article = article
            return cell
        }

        if let trend = item as? Trend, let cell = collectionView.dequeueReusableCell(withReuseIdentifier: Section.trends.cellIdentifier, for: indexPath) as? TrendSummaryCell {
            cell.trend = trend
            return cell
        }

        fatalError()
    }

I also found it useful to have a function to create the snapshot, and can then call it when my arrays are updated.
    func buildSnapshot() -> DiffableDataSourceSnapshot<Section, AnyHashable> {
        let snapshot = DiffableDataSourceSnapshot<Section, AnyHashable>()
        snapshot.appendSections([.trends, .articles])
        snapshot.appendItems(trends, toSection: .trends)
        snapshot.appendItems(articles, toSection: .articles)
        return snapshot
    }

    var articles: [Article] = [] {
        didSet {
            let snapshot = buildSnapshot()
            dataSource.apply(snapshot, animatingDifferences: true)
        }
    }

    var trends: [Trend] = [] {
        didSet {
            let snapshot = buildSnapshot()
            dataSource.apply(snapshot, animatingDifferences: true)
        }
    }

Hi @xinsight .
You can use enum for multiple type data source items.
e.g:
enum Item: Hashable {
    case article(Article)
    case trend(Trend)
}

func viewDidLoad()  {
    super.viewDidLoad()

    let snapshot = DiffableDataSourceSnapshot<Section, Item>()
    snapshot.appendSections([.trends, .articles])
    dataSource.apply(snapshot)
}

func appendArticles(_ articles: [Article]) {
     let snapshot = dataSource.snapshot()
     snapshot.appendItems(articles.map { .article($0) }, toSection: .articles)
     dataSource.apply(snapshot)
}

func appendTrends(_ trends: [Trend]) {
     let snapshot = dataSource.snapshot()
     snapshot.appendItems(trends.map { .trend($0) }, toSection: .trends)
     dataSource.apply(snapshot)
}


/swagger/ endpoint not rendering the swagger ui

Describe the bug
after running swag init and get the auto generated files into docs folder, when Im growing to /swagger I see a list of the folder's files instead of rendering a swagger UI page
Expected behavior
Getting Swagger UI page
Screenshots

Your swag version
1.8.3
Your go version
go1.18.3 darwin/arm64
Desktop (please complete the following information):

macOS
Browser: chrome

How are you trying to serve the Swagger UI: from a static, standalone web server (e.g., Caddy, nginx); or from within your Go application?
If you're trying to expose the Swagger documentation through your application, you need to include the swaggo/http-swagger library, and route all URLs under your desired URL prefix to the handler returned by httpSwagger.Handler. See that library's README for details.


[SPARK-10618] [Mesos] Refactoring scheduling condition and adding test for same

This commit just refactored a scheduling condition into the method and added test for the same.

Can one of the admins verify this patch?

@andrewor14 Can you please take a look at it?

I think this is a good idea, can you do this for fine grain mode too?

Not a bad idea, though I don't think this should go in before #8639, which it conflicts with (and which adds real functionality, and is reviewed).

I agree with @dragos. After #8639 is merged in master. I will update this pull request.
@tnachen I am a fan of small changes and hence will it be ok if i open another pull request for fine-grained mode ?

Refactored and added test for fine grained mode too. Waiting for #8639 to be merged in master.

Actually I'm thinking what could be better is that if we can log what's the exact condition that didn't pass which made us skip the offer. It becomes a bit hard for users to guess why no jobs are running.
How about making each testing condition a rule, and whenever any of them wasn't matched we also have a corresponding message saying why the offer was rejected with the exact reason?

@tnachen Its really a great idea. But we should log these things in debug mode, rather than info log otherwise it will screw up the logs.

Yes please log debug :) But at least the information is available.

Yes please log debug :) But at least the information is available.

Can one of the admins verify this patch?

@SleepyThread #8639 is merged into master now. Can you update this?

Just took another pass of this review, besides the naming suggestions and style fixes overall it LGTM.
Also please update the title of this PR since it's updating both coarse grain and fine grain mode.

@SleepyThread have you had the chance to address the comments? Are you still working on this?

@andrewor14 I have addressed all the comments. Please review the commit.

Can you rebase to master? Then @dragos or @tnachen can do another pass.

@andrewor14 @dragos @tnachen i screwed up the merge. I will open up a new pull request which is sync with master.

Please refer new pull request #10326. Closing this pull request.


System settings do not open iOS

Description
The "open settings for permissions" button does not work on the iOS
Plugin version
0.4.8

iOS
13.3

Your phone info
iPhone X

Now, you can use 0.5.0-dev.1.
There are still some changes to photo_manager, waiting for the release of photo_manager, I will update the photo to the stable version.


Language choice in search navigation

Original report on BitBucket by Taina Jääskeläinen.

Determine what language choices remain. The default is English but the user can choose another language from the dropdown list beside the search box. This dropdown language choice is kept when navigating with arrows.
However, when the user changes the vocabulary language from the two-letter language box in the results list or detailed study view, this choice disappears when navigating and the search language choice overrides it.
Is this how we want the system to work? Determine with other users and put an issue if needed.

To be discussed sometime in the future with the user group.


TagBot trigger issue

This issue is used to trigger TagBot; feel free to unsubscribe.
If you haven't already, you should update your TagBot.yml to include issue comment triggers.
Please see this post on Discourse for instructions and more details.
If you'd like for me to do this for you, comment TagBot fix on this issue.
I'll open a PR within a few hours, please be patient!

Triggering TagBot for merged registry pull request: https://github.com/JuliaRegistries/General/pull/75292

Triggering TagBot for merged registry pull request: https://github.com/JuliaRegistries/General/pull/117879


Update windows-update-installation-capacity.md

fix https://github.com/MicrosoftDocs/SupportArticles-docs/issues/209

@genlin : Thanks for your contribution! The author(s) have been notified to review your proposed change.


disable webapps automatically redirect

the automatically redirect for the camunda webapps cant be diasbled with "camunda.bpm.webapp.index-redirect-enabled=false"

you are right, we read the wrong property name in CamundaBpmWebappAutoConfiguration.


setError() from submit handler not working

Describe the bug
Basically, if you trying set error with setError(field, code, msg) from submit handler you couldn't do that. Common case when server validation fails and you wanna show error accordingly
To Reproduce
I got codesandbox example, if try email<EMAIL_ADDRESS>you should get error "Email already taken", but you don't 😔
Expected behavior
Appearing error in errors object
Versions

<EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS>

fixed :) thanks heaps for reporting
https://github.com/bluebill1049/react-hook-form/releases/tag/v3.11.5


Documentation of smart-scale function is not accurate

In /scss/util/_color.scss, the documentation for the function smart-scale says that it "Scales a color to be lighter if it's light, or darker if it's dark." Actually, as the function is written, it does the opposite: it scales a color to be darker if it's light and lighter if it's dark.

Corrected in PR#9330.

Fixed by #9330.


Use dockerd ns instead of pid 1 ns

If it can be merged, then update longhorn-manager and longhorn-engine.
Test cases:

ubuntu console in RancherOS (Done)
ubuntu OS (Done)
default console in RancherOS

https://github.com/rancher/longhorn/issues/10

LGTM. Merged, thanks.


friend

Thank you for your answers to my questions. Could you please give me your contact information? I like program development very much and hope to get your help. My E-mail address is<EMAIL_ADDRESS>

sure, here is my contact<EMAIL_ADDRESS>


Can we just double click the .apk file to install app to WSA?

Is your feature request related to a problem? Please describe
No response
Describe the solution you'd like
Double click the .apk file to install app.
Describe alternatives you've considered
No response
Please specify the version of Windows Subsystem for Android
2209.40000.26.0

Hi, this is something on our radar already for new feature requests, we appreciate the feedback here!

Great to hear this feature is on the radar.  The ability to easily install an APK outside of the Amazon Appstore would be a useful for evaluating new features and working with beta testers.
Jake Brown

Product Engineer

Esri

We're monitoring this feedback but there's nothing on the immediate roadmap in this space.

@nieubank is there an alternative plan for an WSA/App install solution that does not rely on the app stores?

@nieubank is there an alternative plan for an WSA/App install solution that does not rely on the app stores?

We have nothing to share at this time. Today the recommend way to sideload apps is via "adb install" in developer mode.

The latest WSA preview update has support for browsing files stored in Windows via the files app and other Android apps, so you will be able to install an APK via the files app.


Update create-network-azure-monitor-sap-solutions.md

added one new entry in service tag option to allow traffic to azure functions

Microsoft authors of articles need to make updates through the private repository, so the updates can be staged and validated by current validation rules. After you review staging and fix all validation issues, you can add the sign-off comment to let the PR reviewers know the updates are ready to be merged.
It's easy to access the private repo version of your articles in GitHub. Just add -pr to the URL, as follows:
 Public repo URL: https://github.com/MicrosoftDocs/{docs-repo}
 Private repo URL: https://github.com/MicrosoftDocs/{docs-repo-pr}
We have closed this pull request. Please resubmit the updates through the private repo. For more information, see the contributor guide.


Move the clock exercise later in fetch order

moves the clock exercise later (down) in the exercise suite

Great first step on the way to improve the clock exercise. Could you rewrite your commit message to follow the mentioned format from the README and so that it states what actually is done and not just copy-paste the issue title.

@behrtam thanks for the feedback, made changes to the commit message. I added more detail there.

It is convention to prefix the commit message with the exercise name: https://github.com/exercism/xpython#pull-requests
So, if could change it again we might be able to merge this right away.

@behrtam done. The CI operations are running now

Thanks, for your work!

Welcome. Enjoyed being a part of the project. I will keep involved.


Feature/issue 571 replace deprecated function calls

Can do a rebase later, once 564 and 568 are merged into develop.
Fix #571

@g3rb3n everything is merged :tada:


use .bower.json manifest instead of bower.json manifest

not all bower dependencies have bower.json but they all have .bower.json
closes #29

great:)!

i edited to add "closes #29" is that true?

Is true


WET CODE!!!

https://github.com/DeepMotionEditing/deep-motion-editing/blob/36f97fe32cc874b2818c42904e7a117886b7740c/retargeting/datasets/bvh_parser.py#L129
You're repeating yourself from L72

Oh, thanks for the reminding. L130 is indeed redundant. If you like, you can create a pull request.

Request submitted.


Run async eval?

[STAThread]
		static async void Uwu()
		{
			using (var webview = new Webview())
			{
				webview
					.SetTitle("test")
					.SetSize(1024, 768, WebviewHint.None)
					.SetSize(800, 600, WebviewHint.Min)

					.Bind("evaltest", (id, req) =>
					{
						Thread.Sleep(5000);
						Console.WriteLine(req);
						// Executes the javascript on the webview
						webview.Evaluate("console.log('The anwser is ' + window.x);");
						// And returns a successful promise result to the javascript function, which executed the 'evalTest'
						webview.Return(id, RPCResult.Success, "{ result: 'We always knew it!' }");
					})
					.Navigate(new UrlContent("http://<IP_ADDRESS>:5500/test.html"))
					.Run();
			}
		}

I'm trying to what features working or not.
Since it is Single Threaded, The Thread.Sleep(5000) will just froze the window.
how can we wait a few seconds and give result like Thread.Sleep(5000);?

At least two solutions I can think of:

Use a Task inside your Bind delegate
Run webview in an extra thread

I would say this is more a question of your architecture then a question about what you are able to do with webview.

At least two solutions I can think of:

Use a Task inside your Bind delegate
Run webview in an extra thread

I would say this is more a question of your architecture then a question about what you are able to do with webview.

I selected 2, as run extra thread on bind
.Bind("evaltest", (id, req) =>
					{
						new Thread(() =>
						{
							Thread.Sleep(5000);
							Console.WriteLine(req);
							// Executes the javascript on the webview
							webview.Evaluate("console.log('The anwser is ' + window.x);");
							// And returns a successful promise result to the javascript function, which executed the 'evalTest'
							webview.Return(id, RPCResult.Success, "{ result: 'We always knew it!' }");
						}).Start();
					})

whatever I used thread for just testing, I will use thread pool whatever thanks for helping me!


Hide policy #47

Implements hiding policy stats (#47).
This allows the player(s) to play a game of Twixt without being influenced/distracted by the Alpha Zero bot input.

will have a look a.s.a.p (weekend).
Makes sense to me.
Thanks again!

Implemented in PR#58


Using the Gradle Plugin analyzes files sequentially

Expected Behavior
Analysis of the source files should be done in parallel
Observed Behavior
When using the gradle plugin each source file is analyzed sequentially.
Steps to Reproduce
time java -jar ./detekt-cli/build/libs/detekt-cli-*-all.jar -i detekt-rules/src/main/kotlin

On my machine this takes about 3.9s
Then run ./gradlew detekt-rules:detekt --rerun-tasks to identify the input files that are effectively processed and replace detekt-rules/src/main/kotlin with the list of those files. For me that took about 4.5s
Context
#1505 introduced support for source sets and determines all files that should be analyzed within the gradle plugin. The cli code historically seems to assume that an element in the input parameter list consists of multiple files and processes those files in parallel. (See DetektFacade:34 and Detektor:56)
I don't know if this is such a big deal but so assume it is an unintended consequence of the use of source sets and I wanted to point it out. Is there a reason the parallel processing is done in the Detektor instead of the DetektFacade?

This seems reasonably. Thanks for bringing up this issue.
I am linking #1295 here.
@dimsuz could this be the reason for experiencing slower static code analysis with detekt in your project?

@schalkms perhaps! I don't know that much about gradle parallel workers, but I can help by testing and measuring time it takes, if someone submits a PR which addresses this issue.

Thanks for the investigation!
That's a huge thing needs to get fixed asap.
I was also thinking about removing the process call in the gradle plugin to speed up the things.
Will try to find a better solution.

@arturbosch would you mind please waiting a few days? I'm working on an update of #1220 which I'm sure will touch some of the same code. I think it would be good to land that feature first if that's ok?

#1597 should result in fairly consistent performance for this case, would be great if that could be verified.

Thank you @3flex .
Your branch looks great, I test it on some of my projects.

Only please make sure detekt works on Android after/when merging it. I suspect that many of us use detekt on Android projects.

@dimsuz are you referring to #1597? If so, there's no change to behaviour on Android projects (other than fixing the performance problem raised in this issue). If you have the time it will be worth testing that branch to identify any other issues, as soon as I can rebased the build.

@3flex yeah, I got a bit worried because of this:

No Android support. Will investigate, but may not include support for now.

it wasn't clear if this means that "no android support" means breaking something, or simply missing performance improvements on Android.
I will try to test it if I find some time, yes.

Sorry for the confusion - #1597 introduces new functionality, but that new functionality only supports projects using kotlin-jvm (not JS, native or Android). Fixing this issue with that PR is just a bonus and not the primary intent.
There are no changes to existing behaviour introduced in that PR. The new functionality should support Android in future depending on when I or someone else gets to it. Hopefully that makes sense.

Yes, this clears things up, thank you!


style: increase code-block font size to 14px

What is it?

[ ] Feature / enhancement
[ ] Bug
[ ] Docs / tests

Description
The font size for code blocks is very small. I just made it a little bigger.
Use cases and why

One use case

Another use case

Checklist:

[ ] My code follows the developer guidelines of this project
[ ] I have performed a self-review of my own code
[ ] I have made corresponding changes to the documentation
[ ] Added new tests to cover the fix / functionality

Thanks


all flytekit plugins use lazy module loading

Tracking issue
Fixes https://github.com/flyteorg/flyte/issues/4401
Why are the changes needed?
This change is primarily to simplify the dependencies needed for things like generating API reference documentation for flytekit. Before one needed all dependencies of all plugins to render API docs.
What changes were proposed in this pull request?
Use flytekit.lazy_module to lazily load modules in the plugin packages.
How was this patch tested?
Run tests locally with pytest

The offending file in the failing lint test isn't changed in this PR, not sure what's going on.:
Fixed 1 error:
- flytekit/models/literals.py:
    1 × I001 (unsorted-imports)


[Relay][Pass] Add ExtractOperators pass

Adds helper pass to extract unique operator names from a module.

lgtm, will let @comaniac own this one.


fix: [#39] Hide hamburger menu on bigger screens.

Scope of change:

The hamburger menu is hidden on larger screens using media query.

Screenshots

Notes
This closes #39

Welcome @Chris5613 :)


Drift Range

With the current PoW, the hashing power is used to determine the block reward.   Because of this implementation, I suspect the drift range logic was removed.   The resulting code is that nMasternodeCountDrift isn't actually used.
This will pose a problem in PoS; as the staker is the entity that defines the rewards in the block; and the other nodes validate the result.  Without nMasternodeCountDrift; there will not be any built in tolerance to variations in the masternode counts between the miner and the full nodes.
The code (currently) requires the rewards to match (tier 1 = 3% of the reward, etc) for the block to be accepted.  This is fine when the reward is fixed; but when the reward starts adjusting based on the numbers of masternodes via seesaw; these numbers need a little more tolerance; especially when the locked percentage gets very close to a seesaw balance change.  (e.g. when one masternode either way would swing it to a different reward balance).
So we need to implement nMasternodeCountDrift back in.  However, the logic isn't going to work well with the tiered masternodes; because it's not going to know how many of each masternode to use.  And that logic is a little messed up anyway; since "3" when you have 10000 masternodes is a whole different amount of wiggle then if it's "20" and there's 20 masternodes.
I've been toying with converting it from number of masternodes; to a percentage of locked supply.  E.g. instead of a value of "3" being the number of masternodes that a full node would accept it didn't see... have the "3" be a percentage...
Here's the code that I've started writing; which probably explains it better:
Old Code:
int64_t GetMasternodePayment(int nHeight, int64_t blockValue, int nMasternodeCount)
{
    int64_t ret = 0;

    // No masternode payments for first 200 blocks on testnet
    if (Params().NetworkID() == CBaseChainParams::TESTNET) {
        if (nHeight < 200)
            return 0;
    }

    int64_t nMoneySupply = chainActive.Tip()->nMoneySupply;

    //if a mn count is inserted into the function we are looking for a specific result for a masternode count
    if (nMasternodeCount < 1){
        if (IsSporkActive(SPORK_8_MASTERNODE_PAYMENT_ENFORCEMENT))
            nMasternodeCount = mnodeman.stable_size();
        else
            nMasternodeCount = mnodeman.size();
    }

    int64_t mNodeCoins = nMasternodeCount * 10000 * COIN;

    // Use this log to compare the masternode count for different clients
    LogPrintf("Adjusting seesaw at height %d with %d masternodes (without drift: %d) at %ld\n", nHeight, nMasternodeCount, nMasternodeCount - Params().MasternodeCountDrift(), GetTime());

New Code:
int64_t GetMasternodePayment(int nHeight, int64_t blockValue, int nMasternodePercentDrift)
{
    int64_t ret = 0;

    // No masternode payments for first 200 blocks on testnet
    if (Params().NetworkID() == CBaseChainParams::TESTNET) {
        if (nHeight < 200)
            return 0;
    }

    int64_t nMoneySupply = chainActive.Tip()->nMoneySupply;
    int nMasternodeCount;

    if (IsSporkActive(SPORK_8_MASTERNODE_PAYMENT_ENFORCEMENT))
        nMasternodeCount = mnodeman.stable_size();
    else
        nMasternodeCount = mnodeman.size();
    }
    int64_t mNodeCoins = nMasternodeCount * 10000 * COIN;

    //if a nMasternodePercentDrift is inserted into the function, we are validating the
    //miner is not trying to short change the masternode; but providing a little wiggle
    //room in case if we have a slightly different count then the miner.
    if (nMasternodePercentDrift >= 0) {
        mNodeCoins += mNodeCoins * ( nMasternodePercentDrift / 100 );
        // Use this log to compare the masternode count for different clients
        LogPrintf("Calculating seesaw at height %d with %d masternodes +%d% at %ld\n", nHeight, nMasternodeCount, Params().MasternodePercentDrift(), GetTime());
    } else {
        // Use this log to compare the masternode count for different clients
        LogPrintf("Adjusting seesaw at height %d with %d masternodes at %ld\n", nHeight, nMasternodeCount, GetTime());
    }

i will have a look into it but it sounds reasonable.

@CaveSpectre11 do you have a solution for this problem? We can get for each tier the number of masternodes. It should then be possible to use the nMasternodeCountDrift to establish the needed tolerance. What do you think?

I think the percentage method is a lot better then basing it on a fixed number of masternodes; since the meaning of "20" masternode wiggle room is a lot different when you have 100 masternodes, vs. 2000.  Likewise, in our situation, "3" masternodes is a lot different when you're looking at tier 1s (10%) vs. tier 3s (somewhere around 2.5-3%).
By using a percentage, you control it a bit better; and it can grow with the growth of the coin.
There is also another factor that I won't get into here; I will discuss privately when I can type in discord; but in a nutshell, we definitely want to minimize the opportunities for the drift amount to push the result into a higher seesaw class.
I think it will fold easily into the UCC Base.

Yea; since the logic is the same (calculating mNodeCoins); it will fold in easily
    mNodeCoins = nMasternodeCountLevel1 * 1000 * COIN;
    mNodeCoins += nMasternodeCountLevel2 * 3000 * COIN;
    mNodeCoins += nMasternodeCountLevel3 * 5000 * COIN;
    //if a nMasternodePercentDrift is inserted into the function, we are validating the
    //miner is not trying to short change the masternode; but providing a little wiggle
    //room in case if we have a slightly different count then the miner.
    if (nMasternodePercentDrift >= 0) {
        mNodeCoins += mNodeCoins * ( nMasternodePercentDrift / 100 );
    }

    if (fDebug)
        LogPrintf("GetMasternodePayment(): moneysupply=%s, overall nodecoins=%s\n", FormatMoney(nMoneySupply).c_str(),
                  FormatMoney(mNodeCoins).c_str());

Then it's just a matter of changing nMasternodeCountDrift to nMasternodePercentDrift and passing it through GetMasternodePayment() to GetSeeSaw(); when the payment is being verified, but not when the block is being written.

perfect :)

@CaveSpectre11 are you able to implement it in next time? if yes, i will wait with the next testnet reset so that we can test it with the fix. Thanks.

Closing with PR #17


Bug in mpsc channel

Step to reproduce:

Run the example/ring.rs with RUST_BACKTRACE=1 cargo run --example ring -- 10 10 4

You would see one coroutine is panicked with message thread 'Processor #0' panicked at 'No coroutine is running yet', src/runtime/processor.rs:189

Stack trace:
stack backtrace:
   1:        0x10fc3c238 - sys::backtrace::tracing::imp::write::ha0f40157033dab87T8t
   2:        0x10fc3dbd5 - panicking::default_handler::_<closure>::closure.42228
   3:        0x10fc3d734 - panicking::default_handler::hfa48369cd11de99dKcy
   4:        0x10fc347e4 - sys_common::unwind::begin_unwind_inner::h1122abee381015baUbt
   5:        0x10fba5127 - sys_common::unwind::begin_unwind::h4158147814178406820
   6:        0x10fbbea24 - runtime::processor::Processor::take_current_coroutine::h4936822716245698684
   7:        0x10fbbb868 - sync::mpsc::Receiver<T>::recv::h2915722332526574509
   8:        0x10fbb7402 - create_node::_<closure>::closure.7216
   9:        0x10fbb6dea - coio::scheduler::Scheduler::spawn_opts::_<closure>::_<closure>::closure.7206
  10:        0x10fbb6cac - coio::try::_<closure>::closure.7202
  11:        0x10fbb6a67 - std::panic::recover::_<closure>::closure.7197
  12:        0x10fbb6a49 - sys_common::unwind::try::try_fn::h15552624096057116699
  13:        0x10fc3b7d8 - __rust_try
  14:        0x10fc3957e - sys_common::unwind::try::inner_try::h7ecee3e4b8b6ef00s8s
  15:        0x10fbb6a00 - sys_common::unwind::try::h17979100537356221247
  16:        0x10fbb685d - panic::recover::h3181483393315964186
  17:        0x10fbb67a7 - try::h9948958839926392203
  18:        0x10fbb65fa - coio::scheduler::Scheduler::spawn_opts::_<closure>::closure.7147
  19:        0x10fbbb265 - boxed::F.FnBox<A>::call_box::h13651452381535119350
  20:        0x10fc1283b - boxed::Box<FnBox<A, Output $u3d$$u20$R$GT$$u2b$$u20$$u27$a$GT$.FnOnce$LT$A$GT$::call_once::h9628849924945103469
  21:        0x10fc124fd - coroutine::coroutine_initialize::__rust_abi
  22:        0x10fc1247c - coroutine::coroutine_initialize::hfedf290f1e2da700O6c

As we can see, the Receiver::recv calls Processor::take_current_coroutine, which will panic because of Processor::current_coro is None.
This bug can only be reproduced with more than 1 processor.

I found the bug. This is because the function haven't got the correct Processor instance. When the coroutine is waken up, the Processor::current() may not be the one that yielding him out. So you have to call Processor::current() again to get the correct Processor instance.


Be able to pass remote URL on command line

It would be really nice if you could pass the URL of the remote app.xml to the Launcher. This would be much easier than trying to replace the app.xml in the fxlauncher.jar file.

Also, of course you'd have to remove this argument from the ones passed to the application that you're launching.

This is actually how it used to work before the embedded manifest support was introdused :) Sure, I'll put it back in, slightly modified. I'm away this weekend, will get to it early next week.

That would be great! Thanks.

This feature is now available in FXLauncher 1.0.9, which should be in Maven Central within the hour. Usage:
java -jar fxlauncher.jar --app=http://remote/location/app.xml

Please let me know how it works out for you!

OK, will do. Thanks for the fast turnaround.

My pleasure. I'll close the issue now, feel free to open it again if needed.

This works great now, thank you. One little thing I noticed is that if the url in the app.xml doesn't end with /, it doesn't work. Perhaps I'll file an issue for this.

Great, thanks :)


Performance Degradation with Incremental Pipeline Runs When Capturing load_info

Feature description
Slack thread: here
When capturing load_info data within the destination database, there is a significant performance drop in pipeline execution over time. Initially, the job runs at a normal pace (approx. 1.5 minutes) but gradually slows down to over 10 minutes after several hundred runs, potentially due to the creation of new tables with single records for each run, named in the format load_info__metrics__[timestamp]_[id]. This issue persists even after the load_info_metrics__ tables are deleted, suggesting it may not be related to the database's handling of the tables.

Yes, I'm already a dlt user.
Use case
The user is using dlt for sourcing data from REST APIs and capturing it in MotherDuck.
Proposed solution
The issue with load_info.metrics is that it's structured inefficiently for dlt processing. It contains a list of dictionaries keyed by load IDs, which causes the database schema to expand unnecessarily with each pipeline execution. To address this, consider the following options before loading the load_info data:

Remove the load ID key from the dictionary.
Either pop the key before loading the load info. Or json dumps it.
Encapsulate load_info within its own source, setting a maximum table nesting level to control schema expansion.

It is advised to revise the dlt's loading strategy for load_info to avoid using keys that are not deterministic, thereby enhancing performance and preventing schema bloating.
Related issues
No response

So this has been fixed in 0.4.6 https://github.com/dlt-hub/dlt/pull/1051

@dat-a-man I will drop a message w/ explanation about the fix.


ability to support X Java style long args (-example)

I would not want single dash long flags (e.g. -props rather than --props) to be default supported, because it precludes clean POSIX-style short flag combining.
However, I would love to be able to turn on support for single dash long arguments.

I don't think I'd like Kingpin to support this as a) it would make the code much more complex and b) Kingpin tries to adhere closely to POSIX/GNU-style flags as closely as possible.


small update proposal

Hi Herod.
Thanks for your contribution.
Given that SeleniumDriver is an optionnal dependency of this library, it's possible to use it in a project that doesn't have SeleniumDriver.
So we couldn't accept your MR.


Add serviceAccountAnnotations to piped chart

What this PR does / why we need it:
Want to add annotations to associate AWS IRSA etc. with ServiceAccount.
Which issue(s) this PR fixes:
Fixes #
Does this PR introduce a user-facing change?:

NONE

/cla sign

@gotyoooo Thanks for your PR. I have just left a nit.

Thank you. 🚀
/approve


Open LinkedIn pages on a new tab

When LinkedIn icons are clicked here, direct the user to a new tab rather than directing them out of our website.

Hello!
I would like to take on this issue, please!

I have created a Pull Request with my fix to this issue.


unable to run the examples

I am running python3.7 with everything installed and when running the examples I get the following error:
Traceback (most recent call last):
File "duplicate_points.py", line 111, in
points_markersize=np.array(count_per_pt)*10)
File "/Users/dianacrisan/Library/Python/3.7/lib/python/site-packages/geovoronoi/plotting.py", line 137, in plot_voronoi_polys_with_points_in_area
_plot_polygon_collection_with_color(ax, [area_shape], color=area_color, edgecolor=area_edgecolor, **plot_area_opts)
File "/Users/dianacrisan/Library/Python/3.7/lib/python/site-packages/geovoronoi/plotting.py", line 204, in _plot_polygon_collection_with_color
geoms, _ = _flatten_multi_geoms(geoms)
File "/Users/dianacrisan/Library/Python/3.7/lib/python/site-packages/geopandas/plotting.py", line 30, in _flatten_multi_geoms
if not geoms.geom_type.str.startswith('Multi').any():
AttributeError: 'list' object has no attribute 'geom_type'

Thanks for reporting this. It was a compatibility issue related to the latest release of GeoPandas. Update to the new geovoronoi version 0.1.1 and it should work.


port: Register missingProperties custom function to get all variables the template contains

Fixes #3849
Description
Register a new custom function: missingProperties, which could get all the variables the template contains.

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

73 of 85 (85.88%)  changed or added relevant lines in 8 files are covered.
1 unchanged line in 1 file lost coverage.
Overall coverage increased (+0.04%) to 84.366%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

libraries/botbuilder-dialogs-adaptive/src/languageGeneratorExtensions.ts
3
4
75.0%

libraries/botbuilder-dialogs-adaptive/src/functions/missingPropertiesFunction.ts
13
15
86.67%

libraries/botbuilder-dialogs-adaptive/src/generators/multiLanguageGeneratorBase.ts
42
51
82.35%

Files with Coverage Reduction
New Missed Lines
%

libraries/botbuilder-lg/src/templateExtensions.ts
1
86.21%

Totals

Change from base Build<PHONE_NUMBER>:
0.04%

Covered Lines:
19745

Relevant Lines:
22204

💛  - Coveralls