remove duplicate code in decorators

Motivation

Clean up

Changes

Removes duplicate code from missing_feature, incomplete_test_app, irrelevant, and flaky decorators
Removes _get_skipped_item .  _get_expected_failure_item can be used in all decorators.
Simplifies the first if statement in _should_skip

Workflow

⚠ Create your PR as draft ⚠
Work on you PR until the CI passes (if something not related to your task is failing, you can ignore it)
Mark it as ready for review

Test logic is modified? -> Get a review from RFC owner. We're working on refining the codeowners file quickly.
Framework is modified, or non obvious usage of it -> get a review from R&P team

:rocket: Once your PR is reviewed, you can merge it!
🛟 #apm-shared-testing 🛟
Reviewer checklist

[ ] If PR title starts with [<language>], double-check that only <language> is impacted by the change
[ ] No system-tests internal is modified. Otherwise, I have the approval from R&P team
[ ] CI is green, or failing jobs are not related to this change (and you are 100% sure about this statement)
[ ] A docker base image is modified?

[ ] the relevant build-XXX-image label is present

[ ] A scenario is added (or removed)?

[ ] Get a review from R&P team

rebasing to fix issue on python

CI is failing

The java parametric test failure was due to a flaky test. After one rerun that scenario is now green.
The php failures seem unrelated to this PR.  The same tests are also failing on the main branch: https://github.com/DataDog/system-tests/actions/runs/12257217102/job/34195001337.

For PHP : #3658


Add Forms

I implemented the following in this PR;
Created a method called current_user in the ApplicationController to make current user data available to all controllers.
It returns the first user from the database.
Created forms to perform the following functions:
Create a Post on behalf of the current_user (use the method that you created in your ApplicationController).
Create a comment on behalf of the current_user (use the method that you created in your ApplicationController).
Allow Users to add likes to Posts.

Status: Invalid 🔴
Hi @danielmatama 🙋♀,
While you made a great effort in this project, I can't review your code.
Invalid Code Review Request
You have submitted a project that has a README that is not professional. Here are key points to consider when documenting your README.

Each section description should be removed and replaced with their custom content. The section descriptions are meant to guide you in documenting your README. They are not meant to be part of the final documentation. ✖

For example:

There should not be any blank sections that do not have content. ✖

Kindly document the Show your support section.

Your Code Review Request will be marked as invalid in your Dashboard, so please submit a new one once you are ready 🙏
Cheers 🥂  and Happy coding!!! 👯
Feel free to leave any questions or comments in the PR thread if something is not 100% clear.
Remember to tag me @KDlamini  in your question so I can receive the notification.
Please, do not open a new Pull Request for re-reviews. You should use the same Pull Request submitted for the first review, either valid or invalid unless it is requested otherwise.

Invalid Code Review Request does not count into the code reviews limit.


Add Fedora 39 as valid version

Fedora 39 can be resolved in CentosRedhatPackageFinder

@bernermic as most of this code is generated, i will defer this pull request until the other change is released..

@bernermic thanks for this pull request and the inspiration that there is a change needed.. as you can see, there is now a conflict because of my changes, so i will close this without merging.. i am sorry that i do not use your change despite the effort you had put into it. But maybe my change makes future pull request easier.. :)


Improve the UI/Ux of the page

I have designed a new UI for Cogniguard to improve user experience and visual appeal. The new design includes updated layout, colors, typography, and interactive elements to enhance functionality and aesthetics.
Observations
I have also noticed that the logo has a misspelling for "Cogniguard." If you suggest, I can redesign the logo to correct this and align it with the new UI design.
Proposal
Here is the UI design I propose. I have tried to keep the elements and the content the same, making changes only to the layout. However, I can propose more design variations if requested.
Attachments

@Amishachoudhary22 designs looks nice,
but there is already an issue for ui/ux you can give you design samples there i'll assign upon viewing the designs,
navbar position is fine on the RHS , just change the rest design and make it look more professional


MaskFormatWatcher argument constructor

Now it used MaskImpl for constructor argument. Why not Mask?

Because MaskFormatWatcher users copy constructor of MaskImpl.

@meandnano Your example (from habrahabr\readme) is wrong
Mask mask = MaskImpl.createTerminated(PredefinedSlots.CARD_NUMBER_USUAL);
FormatWatcher watcher = new MaskFormatWatcher(mask);
watcher.installOn(editText); // install on any TextView

mask not instanceof MaskImpl ( second line )
Why do not you use an abstraction l for MaskFormatWatcher  constructor argument? Depend on the specific implementation of mistaken.
maybe need rename  MaskFormatWatcher ->  MaskImplFormatWatcher ?

We've corrected our example. Thanks for this notice.
But MaskFormatWatcher will stay the same yet.


Remove deprecated project field from JacocoPluginExtension

Summary

Checklist

[ ] Validate whether we should remove the API in the 7.0 release

If the removal is not possible then create a follow-up issue and link it in the overview spreadsheet

[ ] Update the upgrade guide
[ ] Check User Manual for dangling references and outdated documentation
[ ] Mark the story as done in the overview spreadsheet.

@bot-gradle test qF

@bot-gradle test qF

OK, I've already triggered QuickFeedback build for you.

OK, I've already triggered QuickFeedback build for you.

Will be removed later. Replacement was just introduced.

Will be removed later. Replacement was just introduced.


adapt to PHP code

Hi I creat a table from my database using PHP but i don't know exactly the terms i shuld modify;
The table showd perfect but "sortby" and filtring options don't work .
There is a possibility to work this application with PHP?

It should definitely be possible to get this to work with PHP, but unfortunately I cannot help you with that.


Media requiring login authentication

Which media files require the user to login to view? Is this information present in the PBCore?

In the PBCore it's expressed as:
  <pbcoreAnnotation annotationType="Password">YES</pbcoreAnnotation>

In the UI it looks like this

Is this good enough, or do you need some tweaks? (rhetorical question.) Note that this is completely client side: is that acceptable? Since I don't think we're going to implement security on the actual media delivery, just adding a server-side check wouldn't actually give us that much.

@mccalluc: We need to present this to legal to make sure it is sufficient. More soon.

@caseyedavis12 : when is that meeting scheduled for?

@mccalluc: Our next meeting with legal counsel is on Thursday at 2pm.

@caseyedavis12 : what was the outcome?

@mccalluc: still in review by legal counsel. I will definitely let you know when they offer their opinion...this is one of about 9 items on their plate for MLA currently.

From: mccalluc<EMAIL_ADDRESS>Sent: Thursday, March 3, 2016 5:19:29 PM
To: WGBH/openvault3
Cc: Casey Davis
Subject: Re: [openvault3] Media requiring login authentication (#233)
@caseyedavis12https://github.com/caseyedavis12 : what was the outcome?

Reply to this email directly or view it on GitHubhttps://github.com/WGBH/openvault3/issues/233#issuecomment-191992212.

Done.


Install lsb-release on Ubuntu 16/18 docker images

lsb_release tools is now missing from Ubuntu 16/18 docker images causing acceptance puppet 6 tests to fail.
Facter 3.x utilizes lsb_release tool for obtaining os.distro fact.
Some PRs that are failing due to this:

https://github.com/voxpupuli/puppet-zabbix/pull/813
https://github.com/voxpupuli/puppet-cvmfs/pull/148 (workaround on this specific module)
https://github.com/voxpupuli/puppet-nginx/pull/1496

And probably all of the modules that use os.distro fact will fail on Ubuntu 16/18 platforms.
P.S it's the first time touching this utility so any help is appreciated it :smile:

Wouldn't the rest docker_image_commands get overridden by that as well? E.g
https://github.com/voxpupuli/beaker-hostgenerator/blob/08f607482950966e80b76eedbe303c7d0351502f/lib/beaker-hostgenerator/data.rb#L660-#L664

IMO these facts on Puppet 7 are supposed to be always present like os.family because their value is based on /etc/os-release unlike with Puppet 6 which is based on lsb_release.
I agree, though, that accessing facts in a more secure way should become a coding guideline here in Voxpupuli. E.g we already have the "no topscope variables for facts" maybe we should enforce fact() or dig, as you said, as well.
I still believe this PR still has its value since multiple modules' PRs are failing due to this right now and migrating away from these facts or accessing them with fact() is time consuming.

That's a good point actually. I believe that lsb-release should be a recommended package for puppet-agent since os.distro facts are not legacy and Facter 3 needs lsb-release to resolve them. But I don't think that's gonna happen.
Linting this is a good idea for Voxpupuli. Puppet Inc. uses these facts on some their modules as well:

puppetlabs-apt
puppetlabs-postgresql

So some our workflows will still fail because of external modules.

Soooooo, what's the recommended solution for this? :) puppet-prometheus is running into this as well.
For me it sounds totally valid that hostgenerator adds lsb-release for Ubuntu 16.04/18.04 as those Docker images contained it before.

I'm still :-1: on this. If a module needs lsb-release, it should clearly state this and deal with it. It's not something you can count on. I don't have lsb-release installed on my actual systems (VMs) either.


Allow 0 valued traits

The current set_trait implementation don't allow to set traits with the value 0 (e.g. a trait storing an user's purchase count)

👍 thanks for this

version 1.0.5 now available in PyPi


How to start the program which named in Chinese?

I have installed Pywinauto and tried to test the client. but I'm failed . I don't know how to use Pywinauto test a client in Chinese。
The details as follows:
Python 2.7.12 (v2.7.12  [MSC v.1500 32 bit (Intel)] on win32)
Pywinauto 0.6.1,
I run the following codes,but the program had no response.
#!/usr/bin/env python
#coding=gbk
from pywinauto.application import Application
app = Application()
app.start("C:\文件\平台.exe".decode('gb2312'))

Can someone  help me?

Hi @tianhaiyao this is a typical encoding problem for Python (not pywinauto specific). Try something like this (#!/usr/bin/env python is not needed on Windows):
# encoding: gbk
from pywinauto.application import Application
app = Application()
app.start(u"C:\\文件\平台.exe")

If it's a Unicode string in correct encoding (mentioned in the first comment) there is no need to decode byte string to Unicode. The statement can be in Unicode using u literal.

     Thank you very much for your details. I tried but it was failed .Then,I found that Our R & D products can't support this ,so I have to give up this tool and look for other tools for our products.


training code

Thank you for your greate work,I would like to ask further, could you provide me the training code?
sorry to trouble

The related paper is not yet accepted now

Thank you for your reply
wish your paper will be accepted successfully！

Would the training code release?


Mismatch shape for f0 prediction and KL divergence

Hi, I recently found your VISinger implementation (this is awesome) but I ran into a few problems.
The first problem is that the shape is mismatched for f0 predictions as well as KL divergence calculations (logs_p & logs_q).
x: torch.Size([6, 192, 40])
x_frame: torch.Size([6, 192, 581])
ground truth f0: torch.Size([6, 558])
pred f0: torch.Size([6, 581])

I am also curious about how you choose hyperparameters. For instance, I understand 2595 & 700 are for mel conversion, but how do you decide 500 here?
featur_pit = 2595.0 * np.log10(1.0 + featur_pit / 700.0) / 500

The mel length mismatch problem (581 and 558) should be solved during preprocessing. Be sure that the script is python prepare/data_vits_phn.py not python prepare/data_vits.py which is from the original repo.
For the hyperparameters I chose, I just simply emailed the original author and asked him about how he calculated the pitch. I think the reason that he divided 500 is to balance the pitch loss so that it won't be too large.

Thank you so much for your reply!  I resample wav files to 24k explicitly, and it works well now!


Jest mock onLayout

Description
Testing FlashList currently is not ideal. Users tend to test the items in the list but FlashList does not render anything until onLayout is called from the underlying scroll component (or when estimatedListSize is defined). It leads to boilerplate code like this.
We should make testing the FlashList component easier by triggering the onLayout event ourselves. With this PR, users can include require("@shopify/flash-list/jestSetup"); in their setup-jest.js file and then test the component the same way they would have FlatList.
The drawback of the current solution is that the list size is hardcoded. We can either make it configurable by:

providing global values in the new setupJest.js file
making it easier to trigger a new onLayout event

I prefer the latter solution but doing so will be easier once we implement getNativeScrollRef method. For now, providing a sensible default is good enough IMHO.
Reviewers’ hat-rack :tophat:
I have tried creating a test case in the fixture app but unfortunately, it turns out to be not that simple since we link the library instead of using it as an external dependency.
I have prepared a branch that is the same as the one for this PR with the exception of this commit.
To test out that the mock works, you can run:
yarn
cp ../jestSetup.js node_modules/@shopify/flash-list/
yarn jest
// comment out the single line in `setup.js` file
yarn jest // tests should fail because we are not autotriggerin onLayout event

I had two issues with using the @shopify/flash-list library as a link.
When I used the setupJest.js that is in the root, I was getting the following error:
 FAIL  src/__tests__/Twitter.test.tsx
  ● Test suite failed to run

    Cannot find module '@shopify/flash-list' from '../jestSetup.js'

    Require stack:
      /Users/marekfort/src/github.com/Shopify/flash-list/jestSetup.js
      setup.js

    > 1 | jest.mock("@shopify/flash-list", () => {
        |                                                                                ^
      2 |   const ActualFlashList = jest.requireActual("@shopify/flash-list").FlashList;
      3 |   class MockFlashList extends ActualFlashList {
      4 |     componentDidMount() {

      at Resolver.resolveModule (node_modules/jest-resolve/build/resolver.js:324:11)
      at Object.<anonymous> (../jestSetup.js:1:97)

But even when I moved setupJest.js file contents to fixture/setup.js, I still got the following error:
 FAIL  src/__tests__/Twitter.test.tsx
  ● Test suite failed to run

    Invariant Violation: __fbBatchedBridgeConfig is not set, cannot invoke native modules

      at invariant (../node_modules/invariant/invariant.js:40:15)
      at Object.<anonymous> (../node_modules/react-native/Libraries/BatchedBridge/NativeModules.js:181:3)
      at Object.<anonymous> (../node_modules/react-native/Libraries/TurboModule/TurboModuleRegistry.js:11:23)

I don't want to spend more time with setting up the test in the fixture but if you have any ideas how to resolve any of those issues above, let me know.
Checklist

[x] I have added a changelog entry following the Keep a Changelog guidelines.

any progress on an easy way to trigger a different rect in tests? the fixed height in the mock makes testing the rendered contents of the scroll view with a large initialScrollIndex pretty challenging.


Screenshots will not print

My screenshots will not print. All I get on preview is a blank page.

Please test the last version, it should be fixed.


Failure processing application bundle

On several machines, including Azure VM's and a VPS hosted with another party, I get the following error when starting Win ACME:
Failure processing application bundle.
Failed to determine location for extracting embedded files
DOTNET_BUNDLE_EXTRACT_BASE_DIR is not set, and temp-directory doesn't exist or is not readable/writable.
A fatal error was encountered. Could not extract contents of the bundle

I found the following possibly related issue on GitHub: dotnet/runtime issue3812
We run the wacs.exe file from C:\Program Files\LetsEncrypt on all these machines. They are running Windows 2019 Datacenter with the latest Windows updates applied. I've updated one of the machines to the latest version 2.1.9 but it still happens. We also experience this issue with versions 2.1.7 and 2.1.8.

It will try to extract files to %localappdata%\Temp\.net\wacs, but it sounds like there is a permissions issue on your system(s), which you may be able to confirm using a tool like Process Monitor. Before diving in too deeply though, you may just want to try deleting the temp folder. If the temp folder is blocked off by design then you can set the mentioned DOTNET_BUNDLE_EXTRACT_BASE_DIR as an environment variable and that should make it extract to another directory.
The issue that you linked has already been fixed in the version of .NET that win-acme is currently using. Further improvements to the single file publising mechanism will be released in .NET5 but that might take another couple of months to materialize.

The folder %localappdata%\Temp exists but there is no .net folder in that directory. I run under the Administrator account and that account and the Administrators group has Full Control to the directory.  It calls CreateFile with only read permission on the folder C:\Users\Administrator\AppData\Local\Temp\2 which obviously results in a NAME NOT FOUND as it doesn't exist. When I try to launch wacs.exe multiple times it every time results in the same single call to CreateFile.
When I manually create the folder 2 in C:\Users\Administrator\AppData\Local\Temp and execute wacs.exe again it works and it creates the full directory structure C:\Users\Administrator\AppData\Local\Temp\2\.net\wacs and this contains a folder with a temporary name which contains the extracted DLL's.

Thanks for your investigation, very clearly proves where it falls apart, nice work. Now the question becomes why is it looking for that "2" folder. I'm tempted to take a look at Microsofts code for this, I think it's supposed to be open source.

This is due to the policy that says create temp directories based on session number. See this article.

Very interesting @tsimmons !  I couldn't find the group policy mentioned in that article but did find it under Administrative Templates -> Windows Components -> Remote Desktop Services -> Remote Desktop Session Host -> Temporary Folders -> Do not use temporary folders per session. It's state is Not configured though which according to the description should mean that per-session temporary folders are created unless the administrator specifies otherwise. Don't know what other way there is to specify it?!?
But apparently Windows sometimes does and sometimes doesn't create that per-session directory when you log on. Now when I log on it works fine and the directory is created. But recently we've had problems on several machines. I would say this problem has started only fairly recently and could be due to a change/bug in Windows due to Windows updates. I don't think Win ACME is at fault here. I think it just asks the system for the temporary folder and tries to open it. But Windows failed to create it (sometimes).

I think by the first release of 2021 we can switch to .NET5


Recent issues with master branch

I've been using 2.3.2 locally for a while, but my Travis-CI script was simply cloning this repo's master branch so always getting the latest code. Today, all of my builds started failing with errors such as:
/home/travis/.local/lib/python2.7/site-packages/ccm-2.4.4-py2.7.egg/ccmlib/node.py:509: UserWarning: Binary interface <IP_ADDRESS>:9042 is not listening after 10 seconds, node may have failed to start.

This is my last successful build 3 days ago: https://travis-ci.org/thibaultcha/lua-cassandra/builds/164163446
It would appear that in the last 3 days, something got broken? The only commit I see in this lapse of time is 833f7894ecb4cfc0afceaa07342e85fcbd003e35, which, although I did not investigate the issue, appears like a good candidate.

That commit was merged today. I don't think anything was merged ~three days ago. Can you see if that node actually failed to start, or if the warning is being incorrectly triggered?

Indeed, nothing for 3 days (but also, no builds on my side), and 3 days ago, the last build worked fine. But as of today (which includes this new commit), the builds stopped working with this error all over the place.
I will investigate the warning.

PS: temporarily reverting to 18a50dfde2069e64a3124e2300ad1f0c1e08f908 fixed my builds: https://github.com/thibaultcha/lua-cassandra/blob/master/.ci/setup_env.sh#L22

That is interesting


Add Ability to Change Number of Items Per Page

Looking through all the projects 5-at-a-time is annoying. It'd be awesome if we added a dropdown that let's us modify the pageSize field of the model(and update the URL, now that #104 is merged).

@prikhi you don't need to make PRs for changes like this, just go ahead and commit to master

@lukewestby Thanks, just dunno when I'll have the time so I figured I'd put it up here as low-hanging fruit.

@prikhi oh lol i am not with it today, i thought this was a PR. right on, well if you get to it or want to do anything else yeah just push it directly

This is now live!


Bullet-proof report left recursion

How it works: main idea in what for sequence it is insufficiently simple to check the first element of sequence because exist cases described in #190, that also have left recursion. Grammars
S = a? S
S = a* S

it is possible to present in the equivalent form
S = S / a S
S = S / a + S

As you see, that is classical left recursion. In general, any production, which doesn't consume an input, can lead to the left recursion.
Therefore, if we walk through AST of the rule and we will consume the smallest theoretically possible input, we will be able to define, whether it can lead to the left recursion. We need check all sequence elements while one not consume some input. After that any left recursion is inpossible. So, main advantages in checking not only first element of sequence node, but all, while some input won't be consumed.

@Mingun Thanks for your pull request. I looked at your code but ultimately I decided to implement the fix for #190 little bit differently myself.
Few notes:

Implement one task at a time. Issues #190 are #26 related, but they have a distinct status (bug vs. feature) and thus a different priority. This suggests they should be fixed separately. Changing the error message is also a separate thing.
Make implemented algorithms descriptive and readable. For example, your code uses one visitor for two tasks (reporting left recursion and detecting whether an expression may not consume any input), conflating them unnecessarily.
Follow existing code style. For example, you used different commenting density & style, used too few empty lines (e.g. no empty lines between functions or after var statements), and style of your tests also differs from current code.
Use one commit per logical change. The #190 fix should have been just one commit fixing both code and tests. Also, no “fixup” commits please.
Avoid incorrectness. Your code assumes an empty character class ([]) doesn’t consume any input, which is not true — it just never matches.

If you avoid issues like this it’s much more likely I’ll review your PRs faster and actually accept them.

Implement one task at a time. Issues #190 are #26 related, but they have a distinct status (bug vs. feature) and thus a different priority. This suggests they should be fixed separately. Changing the error message is also a separate thing.

I am inclined to consider both tasks as a bug, and same. I definitely don't remember, but in my opinion, Feature label at #26 appeared later, than this PR was created.

Make implemented algorithms descriptive and readable. For example, your code uses one visitor for two tasks (reporting left recursion and detecting whether an expression may not consume any input), conflating them unnecessarily.

How you found left recursion if you don't check, consume the parser an input or not? Therefore, I don't consider that it was two tasks. Your decision seems to me unreasonably non-optimal, though.

Follow existing code style. For example, you used different commenting density & style, used too few empty lines (e.g. no empty lines between functions or after  var  statements), and style of your tests also differs from current code.

I tried to adhere to your style. Though as in a code there are no comments, it is difficult to be guided by something here. In tests I didn't notice any divergences in style, you can specify more precisely, where that I could consider it further?

Use one commit per logical change. The #190 fix should have been just one commit fixing both code and tests. Also, no “fixup” commits please.

I did different сommits for fix and for tests consciously. It seems to me that it is so easier to review them. As you didn't mention anywhere that you don't like such approach, I did as it seemed to me more conveniently.

Avoid incorrectness. Your code assumes an empty character class ([]) doesn’t consume any input, which is not true — it just never matches.

You aren't right. You can create such parser. Besides, API allows to create the AST parser manually therefore you shouldn't rely on AST from the PEG parser. By the way, same concerns an order of run of passes. Now many passes rely that will be executed in a certain order. However API allows you to change it. I consider it a problem.
Example of grammar, that freeze parser and create left recursion, that will:
freeze = (![])*;
leftRecursion = !(![] leftRecursion);

In your implementation you won't notice it because it is hided by other bug in your implementation.
You don't come into expressions of the optional, one_or_more, zero_or_more, simple_and and simple_not nodes. On this example your pass won't work:
// Must be detected, as recursive. You implementation fail. My pass
start1 = ('' (start1/start1))?;
// Must be detected, as non-recursive. You implementation pass. My pass
start2 = ('a' (start2/start2))?;

Having a little more thought, I understood that -- it isn't pleasant to me in your implementation. The matter is that you used the wrong predicate for determination of, whether there can be the left recursion or not. The problem is aggravated with that in implementation of this predicate have bugs, as a result it doesn't even work as it is possible to assume from its name (because there is no the comment describing how it shall work. In this case names of function insufficiently, please, comment on a code! From you won't decrease).
Your assumption is that if expression matches an empty input, the left recursion is possible. It is wrong. This sufficient condition but not necessary. The necessary condition that expression doesn't consume any input. It not the same that !matchesEmpty(). As you noted, expression [] doesn't match empty input, however it doesn't consume an input and therefore, leads to the left recursion in what you can will be convinced (see my example above).
The bug is in implementation of matchesEmpty that the following grammars will be erraticly considered, as matches to an empty input though it not so (you can it will be convinced). I assume that the matchesEmpty function shall do that tells it name: for any expression to determine, it can be matched with an empty input or not:
start = !''// not matches anything, but matchesEmpty() == true
start = ![]// not matches anything, but matchesEmpty() == true
start = !. // not matches anything, but matchesEmpty() == true
start = &. // never matches empty, but matchesEmpty() == true

Implement one task at a time. Issues #190 are #26 related, but they have a distinct status (bug vs. feature) and thus a different priority. This suggests they should be fixed separately. Changing the error message is also a separate thing.

I am inclined to consider both tasks as a bug, and same.

One was a bug because existing functionality was misbehaving (not doing what it was supposed to do, that is prevent all left recursion). The other was a feature because PEG.js wasn’t originally designed to  prevent infinite loops via + and *. But I understand my view can be contested e.g. on the basis that both left recursion and infinite loop detection are just different factes of the same thing (preventing parsers to hang).

I definitely don't remember, but in my opinion, Feature label at #26 appeared later, than this PR was created.

May be, GitHub doesn’t tell.

Your implementation seems to me unreasonably non-optimal, though.

I optimize for primarily for readability and simplicity.

Follow existing code style. For example, you used different commenting density & style, used too few empty lines (e.g. no empty lines between functions or after  var  statements), and style of your tests also differs from current code.

I tried to adhere to your style. Though as in a code there are no comments, it is difficult to be guided by something here. In tests I didn't notice any divergences in style, you can specify more precisely, where that I could consider it further?

You loop through all the expressions several times, which is not necessary for testing some “facets”, e.g. indirect recursion. But this is a minor point and there were few examples you could have followed. I was probably too strict on you on this point, sorry.

Use one commit per logical change. The #190 fix should have been just one commit fixing both code and tests. Also, no “fixup” commits please.

I did different сommits for fix and for tests consciously. It seems to me that it is so easier to review them. As you didn't mention anywhere that you don't like such approach, I did as it seemed to me more conveniently.

I never mentioned this anywhere because I consider atomic commits and clean history an elementary software engineering practice. Although I guess I should spell these things out somewhere because the amount of people who don’t follow things I consider elementary is way too big.

Avoid incorrectness. Your code assumes an empty character class ([]) doesn’t consume any input, which is not true — it just never matches.

You aren't right. You can create such parser.

You can, but the point is that the [] expression will always fail. It matches exactly one character which has to belong into an empty set — an impossible condition.

Besides, API allows to create the AST parser manually therefore you shouldn't rely on AST from the PEG parser.

No. If you use the API to supply the compiler with an AST that doesn’t correspond to any valid PEG.js grammar, and it explodes, it’s your problem. The compiler is (and always will be) designed to accept only certain inputs.

By the way, same concerns an order of run of passes. Now many passes rely that will be executed in a certain order. However API allows you to change it. I consider it a problem.

I don’t. Granular passes allow separation of concerns, which is very important. There will likely be more passes in the future, not less. Plugin writers must just live with that and avoid messing up with pass ordering.

As for the implementation bugs you found, I’m still investigating.

Example of grammar, that freeze parser and create left recursion, that will:
freeze = (![])*;
leftRecursion = !(![] leftRecursion);

These are both correctly detected.

In your implementation you won't notice it because it is hided by other bug in your implementation.
You don't come into expressions of the optional, one_or_more, zero_or_more, simple_and and simple_not nodes. On this example your pass won't work:
// Must be detected, as recursive. You implementation fail. My pass
start1 = ('' (start1/start1))?;
// Must be detected, as non-recursive. You implementation pass. My pass
start2 = ('a' (start2/start2))?;

Right, thanks for spotting that. Filed #359, will fix soon.

Your assumption is that if expression matches an empty input, the left recursion is possible. It is wrong. This sufficient condition but not necessary. The necessary condition that expression doesn't consume any input. It not the same that !matchesEmpty(). As you noted, expression [] doesn't match empty input, however it doesn't consume an input and therefore, leads to the left recursion in what you can will be convinced (see my example above).

I think the whole confusion here originated in that I used the word “matches” in the sense “consumes”, which was misleading. I’ll rename the matchesEmpty function.

The bug is in implementation of matchesEmpty that the following grammars will be erraticly considered, as matches to an empty input though it not so (you can it will be convinced). I assume that the matchesEmpty function shall do that tells it name: for any expression to determine, it can be matched with an empty input or not:
start = !''// not matches anything, but matchesEmpty() == true
start = ![]// not matches anything, but matchesEmpty() == true
start = !. // not matches anything, but matchesEmpty() == true
start = &. // never matches empty, but matchesEmpty() == true

Not sure if that’s what you had in mind but your examples made me file #360.

OK, I renamed matchesEmpty to alwaysAdvancesOnSuccess and negated it.


⚠ Fortnite has degraded performance

In e09a63d, Fortnite (https://fortnite.com) experienced degraded performance:

HTTP code: 200
Response time: 1541 ms

Resolved: Fortnite performance has improved in 2838ce0.


Implement Host header bypassing

This pull request adds the ability to bypass the Host header in Reproxy for compatibility with services like Grafana as mentioned in #133.
It includes the following changes:

A global option has been added to enable bypassing the Host header for the entire Reproxy instance.
A per-container trigger has been added to enable or disable bypassing the Host header on a per-container basis.

It hasn't been tested with a consul catalog as me don't' have access to one.
I'm not familiar with the coding standards of this project, so I would appreciate any comments or fixes.

Is there any chance of being added? Still waiting for being able to use grafana :)

@ffix - I have updated your branch with all the current changes from the master. It had a lot of conflicts, but hopefully, I have them adequately resolved. Pls, take a look and let me know if everything is fine

@ffix @umputun any progress with this? tried to run Grafana behind reproxy and failed with same problem. Any help needed?


Unknown tag 'link'

Hi, I am trying to install this theme on my computer, but it is giving me an error: jekyll 3.0.1 | Error:  Liquid syntax error: Unknown tag 'link'
I believe have installed all prerequested things in the tutorial. I didn't find many info about this on the internet. How do I install this tag? Many thanks in advance.

by the way, I am using windows bash.

There's a suggestion here that the link tag was introduced in Jekyll 3.2 ... if you can get up to that version, it might help a lot? https://www.bountysource.com/issues/51385971-failure-on-make-serve-unknown-tag-link

Oh! thank you for the tips. I finally managed to work it out on ubuntu16.04, it was caused by the version. This is really a neat and nice theme.
And for others who may want to use this theme, I tried gem update and gem update jekyll, it didn't really help for windows bash, I was still on jekyll 3.0.1. So maybe you would like to try something else.

Great - glad you are up and running.


Fix ISO code of Île-de-France in france_regions.geojson

SUMMARY
Change the value of ISO for Île-de-France from "FR-IDF\t" to "FR-IDF"

Thank you for this, but if you don't make a change in the jupyter notebook, the geojson you've changed here will be overwritten next time someone runs the notebook.
Hopefully this helps, but if not, I'd be happy to update it:
https://preset.io/blog/how-and-when-and-why-to-update-apache-supersets-country-maps/

Oops disregard my approval I had not seen @rusackas ' comment

Thanks, I will have a look!


EIP-4844 support?

https://github.com/ethereum/EIPs/blob/master/EIPS/eip-4844.md

Not planned for now


Transproc processor refactoring

This PR doesn't add any new features it's just refactoring making Transporc processor class "A" on code climate. I used it as a refactoring practice.
Few things:

sometimes it doesn't do exactly the same (e.g. visit_combined method - but the specs passes :/
I'm not sure about so many delegates on Transproc::Attribute class
sometimes it is less explicit (e.g. process_postprocessed method)
I'm not sure about introducing CombineProcessor, AttributesProcessor, Preprocessor. I wanted all processors' to accept header in the initializer. But on the other hand they seems to be not necessary addition.

Please let me know what you think about it.
Codeclimate analyze: https://codeclimate.com/github/martinciu/rom/compare/transproc-processor-refactoring#ratings

Sorry for not coming with any feedback for so long. rom-mapper was extracted already into a separate repo so I can't merge this here. But I gotta say I'm not sure if it's a good idea to refactor it now. We're still trying to figure out how the DSL should work exactly and also we need cleaner test coverage in rom-mapper before we can make a huge refactoring.
Let's figure things out in rom-mapper repo :) Thanks for the PR, I hope you at least got some insights into how that part of ROM works.


Drain channel immediately after last receiver is dropped

After the last receiver is dropped, all the items in the channel are effectively abandoned and can never be accessed. In this scenario, I think it's appropriate to drain the channel and drop all the items. One use case where this is relevant is a dispatch mechanism that uses oneshot channels:
let (req_s, req_r) = bounded(10);

// dispatch
for i in 0.. {
    let (s, r) = oneshot();
    req_s.send((i, s)).await.unwrap();
    let res = r.recv().await.unwrap();
}

// worker
while let Ok((i, s)) = req_r.recv().await {
    s.send(do_work(i));
}

Here, if worker terminates while there are still requests in the channel, dispatch can end up waiting for the response forever. This can be addressed with timeouts, but I think automatically draining the channel is a better solution.

This should be relatively easy to do by applying a patch similar to https://github.com/crossbeam-rs/crossbeam/commit/06d77d35ce7165f04d7027608a99331a2e3e0f9c to concurrent-queue.

Hi @taiki-e, is there any plan to resolve this issue? we have also encountered the abovementioned issue (with a similar usage).


Merge branch 'bugfix/report_params' into 'master' (MEGH-2023)

Bugfix in reporting params
See merge request app-frameworks/esp-rainmaker!233

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.1 out of 5 committers have signed the CLA.:white_check_mark: bbinet:x: chiragatal:x: shahpiyushv:x: shubhamdp:x: shivani-tipnisYou have signed the CLA already but the status is still pending? Let us recheck it.

This PR seems to be added mistakenly. Closing it.


Akas Rai

nice

Due we close new issues on PR merge and voting is still possible on closed issues I will close this one.

cooll!


Error when trying to retrieve list out of a box after hot-restart

Steps to Reproduce
I am trying to store a complete list of objects in a box. I want to try and do that instead of iterating through all elements out of the box with box.values.toList().cast<MyObject>();. I would like to see if it would be better performance-wise at least.
So if I initially do the following:

Open the box
store a list inside the box
Directly afterwards try to retrieve the list out of the box
Print it

everything works and I get the expected result.
Now if I comment out step number 2 and hot reload, i.e. if I do the following:

Open the box
Retrieve the previously stored list out of the box
Print it

I get the following error:
E/flutter ( 7584): [ERROR:flutter/lib/ui/ui_dart_state.cc(148)] Unhandled Exception: type 'List<dynamic>' is not a subtype of type 'List<Foo>' in type cast
E/flutter ( 7584): #0      BoxImpl.get (package:hive/src/box/box_impl.dart:34:26)
E/flutter ( 7584): #1      initializeHive (package:[omitted]/main.dart:45:25)
E/flutter ( 7584): <asynchronous suspension>
E/flutter ( 7584): #2      main (package:[omitted]/main.dart:22:9)
E/flutter ( 7584): <asynchronous suspension>
E/flutter ( 7584): #3      _runMainZoned.<anonymous closure>.<anonymous closure> (dart:ui/hooks.dart:229:25)
E/flutter ( 7584): #4      _rootRun (dart:async/zone.dart:1124:13)
E/flutter ( 7584): #5      _CustomZone.run (dart:async/zone.dart:1021:19)
E/flutter ( 7584): #6      _runZoned (dart:async/zone.dart:1516:10)
E/flutter ( 7584): #7      runZoned (dart:async/zone.dart:1500:12)
E/flutter ( 7584): #8      _runMainZoned.<anonymous closure> (dart:ui/hooks.dart:221:5)
E/flutter ( 7584): #9      _startIsolate.<anonymous closure> (dart:isolate-patch/isolate_patch.dart:305:19)
E/flutter ( 7584): #10     _RawReceivePortImpl._handleMessage (dart:isolate-patch/isolate_patch.dart:172:12)

Code sample
Here is the Foo object:
import 'package:hive/hive.dart';
part 'foo.g.dart';
@HiveType()
class Foo extends HiveObject {
  @HiveField(0) final String id;
  Foo(this.id);
  @override
  String toString() {
    return 'Foo{id: $id}';
  }
}

The code for the storing:
 var fooBox = await Hive.openBox<List<Foo>>("Foo");
  var foos = [Foo("1"), Foo("2")];
  fooBox.put("foos", foos);
  var foosList = fooBox.get("foos", defaultValue: []);
  print(foosList);

and the code that throws the error
 var fooBox = await Hive.openBox<List<Foo>>("Foo");

  var foosList = fooBox.get("foos", defaultValue: []);
  print(foosList);

Version

Platform: Android Emulator, Linux
Flutter version: v1.9.1+hotfix.6 (Channel stable)
Hive version: 1.1.1
Hive Flutter version: 0.2.1
Hive Generator version: 0.5.2

This is a limitation of Dart. Use the following:
var fooBox = await Hive.openBox<List<Foo>>("Foo");

var foosList = fooBox.get("foos", defaultValue: []).cast<Foo>();
print(foosList);

I still get the same errors if I use the code you provided.

Sorry:
var fooBox = await Hive.openBox<List>("Foo");

var foosList = fooBox.get("foos", defaultValue: []).cast<Foo>();
print(foosList);

That did the trick! Thanks for the info... I wouldn't have guessed that that was the case

I spent half a day trying to figure this bug out, solved thanks to this issue. @leisim Do the docs say anything about this?

@MaskyS

Do the docs say anything about this?

Yes, at the very bottom of this page. Maybe I should mention it at other places too...


feat(keynote): Add slido link to keynote info

Types of changes
Thanks for sending a pull request! Please fill in the following content to let us know better about this change.
Please put an x in the box that applies

[ ] Bugfix
[x] New feature
[ ] Refactoring
[ ] Breaking change (any change that would cause existing functionality to not work as expected)
[ ] Documentation Update
[ ] Other (please describe)

Description
Describe what the change is
Add slido link to keynote infomation
Steps to Test This Pull Request
Steps to reproduce the behavior:

Go to keynote page
Click on Slido tab

Expected behavior
A clear and concise description of what you expected to happen.
You will see your view like following screenshot

Related Issue
If applicable, refernce to the issue related to this pull request.
More Information
Screenshots
If applicable, add screenshots to help explain your problem.
Additional context
Add any other context about the problem here. You may also want to refer
to how to wirte the perfect pull request

Codecov Report

Merging #934 into master will increase coverage by 0.03%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master     #934      +/-   ##
==========================================
+ Coverage   75.00%   75.04%   +0.03%
==========================================
  Files          80       80
  Lines        3081     3081
==========================================
+ Hits         2311     2312       +1
+ Misses        770      769       -1

Impacted Files
Coverage Δ

.../proposals/management/commands/recent_proposals.py
98.76% <0.00%> (+1.23%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6ab963c...c7aeed6. Read the comment docs.


Adding video preview

What kind of change does this PR introduce?

Does this PR introduce a breaking change?

What needs to be documented once your changes are merged?

👷 Deploy Preview for blogwowzer processing.

Name
Link

🔨 Latest commit
17e181f2ff891c8788d7f2f8c5a9348d7ec81a93

🔍 Latest deploy log
https://app.netlify.com/sites/blogwowzer/deploys/64cf5f560a954500088e23fe


ctrl++ is not working

Im trying to use ctrl and + in the same time and its not working..
ctrl+- works but ctrl++ doesn't work..

I think it's a mousetrap thing. It was just updated to 1.5.x where it says it improved the handling of the + key. Let's see what the answer for https://github.com/chieffancypants/angular-hotkeys/issues/139 is

It's just an idea, but maybe the problem comes from this line:
https://github.com/chieffancypants/angular-hotkeys/blob/master/src/hotkeys.js#L104

@RomFouq yup.. i think your'e right..

After looking closer at the code, I think this is not the problem... This function symbolize seems to be called only to format the string, for the cheat-sheet, at line:
https://github.com/chieffancypants/angular-hotkeys/blob/master/src/hotkeys.js#L53.

This should be handled by the latest mousetrap


Feat/http response unknown error

Alternative to #1146

Good to know I was so close in my other attempt. 😆 This is similar to what I had in mind as an end state.
I'm booked solid for the next week and change, so if folks find this works for them no need to wait up on me. 👍

@bluejekyll Thanks for your feedback! Have you been able to give this branch a shot to see if it helps with your problem, or whether there are any issues (e.g. ergonomics) that you encounter?
I'll try to run the integration tests tomorrow so that we're ready to merge once we're sure that this is what we want in the short-term.

No. I haven’t. I’ll try and do that when I have some time, but this week will be tough.

I'll go ahead and merge this in for now. If you do find the time, any feedback is appreciated!


Config to allow budding crystals to be silk-touch mined

Add config options for every type of budding crystal whether to allow silk-touch enchanted tools to mine them.

Thanks for your idea and codes, this could be great but we have removed budding crystal blocks in the last major update. If you are into modding and coding, let me know! ❤

oh okay. And yes I'm into modding. I've made several mods myself


CIMI sensor resource definition

The sensor manager requires a CIMI resource that lists categorised sensors. See mF2C/mF2C#115 for my thoughts on what should be included.

Will definitely change the CIMI resource scheme, when the automatic sensor categorization module will be ready.

Can we at least agree on the fields this resource will have in advance? It would help me get at least a general interface going.
What I would like it to contain:

hardware identifier (e.g. am2032, bmp180)
a list of SI dimensions each hardware identifier provides (e.g. ["temperature", "humidity"] for am2302)
connection parameters: not the protocol the hardware is connected through (this is determined by the hardware type), but the details of the connection, e.g. "GPIO12" for am2302, which is a single-data-wire sensor

Yes, I also agree with you that, if we agree on the fields, it would really good for both of us. But dear, I think it would be great if we make a short telco....and then fix the list of fields, what do you think?? By the way, just for your information, tomorrow I'll be not available and Monday also, so if you want we can discuss it after Monday...

I'd much prefer a Slack chat, if that's okay with you, so we get the added benefit of having notes right there. Is Tuesday okay? I'll just ping you then.

To summarise online offline discussions we've had between our teams: this will be done by creating a simple interface to all of the values, hardcoded. This will allow further development on both sides to progress independently.

mF2C/cimi#115 Added the sensor information in CIMI resource (schema)

Blocked by #57.

Finalised through #57.


Convert to block

Summary

Relevant Issue(s)

Checklist

[ ] Summarized PR's changes in CHANGELOG.md

Can you add an entry to the change log for the update?

Should I pin 2.0b9 to this PR, or in a separate PR?


Error during run of ./src/catkin/bin/catkin_make_isolated --install -DCMAKE_BUILD_TYPE=Release

I have been following the below link for instructions for installing ROS on OSX
http://wiki.ros.org/indigo/Installation/OSX/Homebrew/Source
When on running the command,

rosdep install --from-paths src --ignore-src --rosdistro indigo -y

I got the error that many people have reported:
"could not find successful installation of gazebo" (even though I relinked it just to be sure)
I did a brew install of gazebo(gazebo1), and added in  --skip-geys gazebo at the end and it ran successfully.
Upon further running:

./src/catkin/bin/catkin_make_isolated --install -DCMAKE_BUILD_TYPE=Release

The process stops with the error:

[ 44%] Built target gazebo_os_joint_state_publisher
[ 44%] Built target gazebo_os_block_laser
make: *** [all] Error 2
<== Failed to process package 'gazebo_plugins':
Command '['/Users/gunshigupta/ros_catkin_ws/install_isolated/env.sh', 'make', '-j4', '-l4']' returned non-zero exit status 2
Reproduce this error by running:
==> cd /Users/gunshigupta/ros_catkin_ws/build_isolated/gazebo_plugins && /Users/gunshigupta/ros_catkin_ws/install_isolated/env.sh make -j4 -l4
Command failed, exiting.

So when i run the command:

cd /Users/gunshigupta/ros_catkin_ws/build_isolated/gazebo_plugins && /Users/gunshigupta/ros_catkin_ws/install_isolated/env.sh make -j4 -l4

to reproduce the error, I get the errors:

In file included from /Users/gunshigupta/ros_catkin_ws/src/gazebo_ros_pkgs/gazebo_plugins/src/MultiCameraPlugin.cpp:19:
/Users/gunshigupta/ros_catkin_ws/src/gazebo_ros_pkgs/gazebo_plugins/include/gazebo_plugins/MultiCameraPlugin.h:46:25: error: no
type named 'MultiCameraSensorPtr' in namespace 'gazebo::sensors'; did you mean 'MultiCameraSensor'?
protected: sensors::MultiCameraSensorPtr parentSensor;
~^~~~~~~~~~~~
MultiCameraSensor
/usr/local/Cellar/gazebo1/1.9.7/include/gazebo-1.9/gazebo/sensors/MultiCameraSensor.hh:40:11: note: 'MultiCameraSensor' declared
here
class MultiCameraSensor : public Sensor
^
[ 47%] Linking CXX executable /Users/gunshigupta/ros_catkin_ws/devel_isolated/gazebo_plugins/lib/gazebo_plugins/pub_joint_trajectory_test
/Users/gunshigupta/ros_catkin_ws/src/gazebo_ros_pkgs/gazebo_plugins/src/MultiCameraPlugin.cpp:33:22: error: no member named
'reset' in 'gazebo::sensors::MultiCameraSensor'
this->parentSensor.reset();
/Users/gunshigupta/ros_catkin_ws/src/gazebo_ros_pkgs/gazebo_plugins/src/MultiCameraPlugin.cpp:45:22: error: no viable overloaded
    '='
this->parentSensor =
~~~~~~~~~~~~~~~~~~ ^
/usr/local/Cellar/gazebo1/1.9.7/include/gazebo-1.9/gazebo/sensors/MultiCameraSensor.hh:40:11: note: candidate function
    (the implicit copy assignment operator) not viable: no known conversion from
    'shared_ptr<gazebo::sensors::MultiCameraSensor>' to 'gazebo::sensors::MultiCameraSensor &' for 1st argument
  class MultiCameraSensor : public Sensor
        ^
/Users/gunshigupta/ros_catkin_ws/src/gazebo_ros_pkgs/gazebo_plugins/src/MultiCameraPlugin.cpp:48:7: error: invalid argument type
    'sensors::MultiCameraSensor' to unary expression
if (!this->parentSensor)
    ^~~~~~~~~~~~~~~~~~~
/Users/gunshigupta/ros_catkin_ws/src/gazebo_ros_pkgs/gazebo_plugins/src/MultiCameraPlugin.cpp:57:7: error: invalid argument type
    'sensors::MultiCameraSensor' to unary expression
if (!this->parentSensor)
    ^~~~~~~~~~~~~~~~~~~
/Users/gunshigupta/ros_catkin_ws/src/gazebo_ros_pkgs/gazebo_plugins/src/MultiCameraPlugin.cpp:63:50: error: member reference type
    'sensors::MultiCameraSensor' is not a pointer; maybe you meant to use '.'?
for (unsigned int i = 0; i < this->parentSensor->GetCameraCount(); ++i)
                             ~~~~~~~~~~~~~~~~~~^~
                                               .
/Users/gunshigupta/ros_catkin_ws/src/gazebo_ros_pkgs/gazebo_plugins/src/MultiCameraPlugin.cpp:65:46: error: member reference type
    'sensors::MultiCameraSensor' is not a pointer; maybe you meant to use '.'?
  this->camera.push_back(this->parentSensor->GetCamera(i));
                         ~~~~~~~~~~~~~~~~~~^~
                                           .
/Users/gunshigupta/ros_catkin_ws/src/gazebo_ros_pkgs/gazebo_plugins/src/MultiCameraPlugin.cpp:73:48: error: member reference type
    'sensors::MultiCameraSensor' is not a pointer; maybe you meant to use '.'?
  std::string cameraName = this->parentSensor->GetCamera(i)->GetName();
                           ~~~~~~~~~~~~~~~~~~^~
                                             .
/Users/gunshigupta/ros_catkin_ws/src/gazebo_ros_pkgs/gazebo_plugins/src/MultiCameraPlugin.cpp:91:21: error: member reference type
    'sensors::MultiCameraSensor' is not a pointer; maybe you meant to use '.'?
this->parentSensor->SetActive(true);
~~~~~~~~~~~~~~~~~~^~
                  .
9 warnings and 9 errors generated.

Can anyone help me with what needs to be modified, (and if this is not the right page for this question, then where i should ask for help).
Thanks!

If building a workspace with catkin fails it is commonly no the fault of catkin but the package failing to build. in this case: gazebo_plugins / gazebo_ros_pkgs.
You can either open a ticket in that repo or better ask your question on answers.ros.org. Please see http://wiki.ros.org/Support for general guidelines for support.


GCS uses wrong bucket for database storage

There is a typo in the tpl/deis-objectstorage-secret.yaml file in workflow-dev (and workflow-rc1): the GCS database bucket has the same value as the registry bucket.

Closed by #271 and inline changes to the RC1 PR.


Routing seems broken in Express 4.13.3

Having this app:
var express = require('express');
var app = express();
var router = express.Router();
app.use('/api', router);
router.use('/test', function(req, res){
  res.send("BaseUrl: "+req.baseUrl+"\nPath: "+req.path);
});
app.listen(8081, "<IP_ADDRESS>");

I get these results:

http://localhost:8081/api/test/

BaseUrl: /api/test
Path: /

http://localhost:8081/api/test/extra/

BaseUrl: /api/test
Path: /extra/

But I would expect these results:

http://localhost:8081/api/test/

BaseUrl: /api
Path: /test

http://localhost:8081/api/test/extra/

Cannot GET /api/test/extra/

Seems like the express router tries to match the patterns only on the beginning of the given path instead of matching against the whole path when dealing with middleware that it is not a router.

Hi! From reading your description, I think you may be confused on how app.use actually works. For example, your example has the line router.use('/test', function(req, res){, but you are expecting it to behave like router.all('/test', function(req, res){.
If you think there is opportunity to expand on our API documentation, please feel free to open an issue or even pull request at https://github.com/strongloop/expressjs.com :)

You are right about this.
The documentation might use a bit of love in this case to maybe explain the difference.
Thank you for the quick response on this.


Build issue with other Package

I am trying to use a database library with Kitura. 🤖💡
I tried :

https://github.com/OpenKitten/MongoKitten
https://github.com/Zewo/PostgreSQL

For both of them I got this issue 🤕👉 :
error: The dependency graph could not be satisfied because an update to ...

This is the Package.swift I am using for running PostgreSQL:
import PackageDescription

let package = Package(
    name: "SignalAnalyserServer",
    dependencies: [
        .Package(url: "https://github.com/IBM-Swift/Kitura.git", majorVersion: 0, minor: 24),
	.Package(url: "https://github.com/IBM-Swift/HeliumLogger", majorVersion: 0, minor: 13),
	.Package(url: "https://github.com/Zewo/PostgreSQL", majorVersion: 0, minor: 8)
    ]
)

The ** PostgreSQL** has the same swift toolchain than my current Kitura version.
So the problem is coming from this library ?

@rfdickerson this looks like your sort of area!

Hi @remirobert , first of all, you should try either removing Packages directory and/or running swift package update to force fetching the packages again from scratch.
Secondly, I worry about some versioning issues with any toolchain other than 6/20 and Kitura version 0.22. We have only tested and developed on that stack.

@rfdickerson ok thanks. Kitura sounds like an awesome framework, but I feel like there is a lot of versioning issue, maybe due to swift 3, which is coming soon.
But unlikely, I even can't build the mongo db example.😸

Yeah, I feel like things are sort of coming together as of the 8/04 snapshot. Soon we'll have something that will developing on ground that is not constantly shifting. Feel free to try our todolist-mongodb framework, and make sure you set your PATH to point to the correct swift compiler (6-20-DEVELOPMENT).

Oh, yeah! I just remembered. There is a bug in the Mongokitten driver that it won't work on 6/20- but we were able to get it to work on 6/06.

@rfdickerson thanks for you help ! 👍


Array uses error handling which is not supported on an embedded platform

Maybe make an global error handling function which you can optionally override?

Documentation within array.h must be updated

Different proposal:
For now, scrap the error handling within Array altogether. The MqttMessageParser should get pushed to a release ASAP. As the libarary is still in early development the error handling can be added later.


QueryError component does not wrap long messages

Describe the bug
I am developing a new driver to be used with SQLTools and I noticed that when an error message is too long it is not formatted correctly and prevents the error from being read.
When observing, I noticed that this happens because the component uses a pre element to display the messages, which by default does not actually wrap the messages. See reference.
However, I understand the use of pre, but I believe it would also be valid to have a line break when messages exceed the maximum width of the view used.
To Reproduce
Steps to reproduce the behavior:

Execute any query whose error has a long description

Expected behavior
Show the error message with line breaks if necessary so that it can be read
Screenshots
How the error screen is displayed if the pre element does not have the style to perform the line break

What could the error screen be like if the pre element is configured to perform line wrapping

Desktop (please complete the following information):

SQLTools Version: 0.28.1
VS Code Version: 1.87.2
OS: Ubuntu 22.04.2 LTS
Driver:

[ ] PostgreSQL/Redshift
[ ] MySQL/MariaDB
[ ] MSSQL/Azure
[ ] SQLite
[X] Other? Developing JDBC Driver

Database version: Apache Impala 4.2.0

Additional context

@joaoguilhermeall please update to 0.28.2 (released today) and see if we've fixed this correctly.


Reduce allocations

Codecov Report

Merging #183 (d14c234) into main (f895f11) will increase coverage by 0.07%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main     #183      +/-   ##
==========================================
+ Coverage   90.25%   90.32%   +0.07%
==========================================
  Files          24       24
  Lines         965      972       +7
==========================================
+ Hits          871      878       +7
  Misses         94       94

Impacted Files
Coverage Δ

src/ProbNumDiffEq.jl
61.11% <ø> (-2.05%)
:arrow_down:

src/diffusions.jl
98.50% <100.00%> (ø)

src/filtering/predict.jl
100.00% <100.00%> (ø)

src/filtering/update.jl
76.47% <100.00%> (+3.13%)
:arrow_up:

src/initialization/classicsolverinit.jl
97.29% <100.00%> (+0.03%)
:arrow_up:

src/perform_step.jl
74.35% <100.00%> (+0.67%)
:arrow_up:

src/initialization/common.jl
95.83% <0.00%> (-0.17%)
:arrow_down:

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more


m1

I tried installing the ARM kext, after setting "Reduced Security" at the Startup Options.
Then running (src):
kmutil load -p ~/Library/Extensions/GCAdapterDriver.kext

fails with
Error Domain=KMErrorDomain Code=30 "Validating extension failed: Kext com.secretkeys.driver.GCAdapterDriver v1 in executable kext bundle com.secretkeys.driver.GCAdapterDriver at /private/var/db/KernelExtensionManagement/Staging/com.secretkeys.driver.GCAdapterDriver.ohkpcD/GCAdapterDriver.kext:

Filesystem error: Invalid ownership (501:20) should be (0:0) on /private/var/db/KernelExtensionManagement/Staging/com.secretkeys.driver.GCAdapterDriver.ohkpcD/GCAdapterDriver.kext/Contents
Filesystem error: Invalid ownership (501:20) should be (0:0) on /private/var/db/KernelExtensionManagement/Staging/com.secretkeys.driver.GCAdapterDriver.ohkpcD/GCAdapterDriver.kext/Contents/_CodeSignature
Filesystem error: Invalid ownership (501:20) should be (0:0) on /private/var/db/KernelExtensionManagement/Staging/com.secretkeys.driver.GCAdapterDriver.ohkpcD/GCAdapterDriver.kext/Contents/_CodeSignature/CodeResources
Filesystem error: Invalid ownership (501:20) should be (0:0) on /private/var/db/KernelExtensionManagement/Staging/com.secretkeys.driver.GCAdapterDriver.ohkpcD/GCAdapterDriver.kext/Contents/MacOS
Filesystem error: Invalid ownership (501:20) should be (0:0) on /private/var/db/KernelExtensionManagement/Staging/com.secretkeys.driver.GCAdapterDriver.ohkpcD/GCAdapterDriver.kext/Contents/MacOS/GCAdapterDriver
Filesystem error: Invalid ownership (501:20) should be (0:0) on /private/var/db/KernelExtensionManagement/Staging/com.secretkeys.driver.GCAdapterDriver.ohkpcD/GCAdapterDriver.kext/Contents/Info.plist
Authenticating extension failed: Bad code signature" UserInfo={NSLocalizedDescription=Validating extension failed: Kext com.secretkeys.driver.GCAdapterDriver v1 in executable kext bundle com.secretkeys.driver.GCAdapterDriver at /private/var/db/KernelExtensionManagement/Staging/com.secretkeys.driver.GCAdapterDriver.ohkpcD/GCAdapterDriver.kext:

Filesystem error: Invalid ownership (501:20) should be (0:0) on /private/var/db/KernelExtensionManagement/Staging/com.secretkeys.driver.GCAdapterDriver.ohkpcD/GCAdapterDriver.kext/Contents
Filesystem error: Invalid ownership (501:20) should be (0:0) on /private/var/db/KernelExtensionManagement/Staging/com.secretkeys.driver.GCAdapterDriver.ohkpcD/GCAdapterDriver.kext/Contents/_CodeSignature
Filesystem error: Invalid ownership (501:20) should be (0:0) on /private/var/db/KernelExtensionManagement/Staging/com.secretkeys.driver.GCAdapterDriver.ohkpcD/GCAdapterDriver.kext/Contents/_CodeSignature/CodeResources
Filesystem error: Invalid ownership (501:20) should be (0:0) on /private/var/db/KernelExtensionManagement/Staging/com.secretkeys.driver.GCAdapterDriver.ohkpcD/GCAdapterDriver.kext/Contents/MacOS
Filesystem error: Invalid ownership (501:20) should be (0:0) on /private/var/db/KernelExtensionManagement/Staging/com.secretkeys.driver.GCAdapterDriver.ohkpcD/GCAdapterDriver.kext/Contents/MacOS/GCAdapterDriver
Filesystem error: Invalid ownership (501:20) should be (0:0) on /private/var/db/KernelExtensionManagement/Staging/com.secretkeys.driver.GCAdapterDriver.ohkpcD/GCAdapterDriver.kext/Contents/Info.plist
Authenticating extension failed: Bad code signature}

Am I doing something wrong or is this kext not signed correctly? Why does DriverKit not work on M1? Simply no time to update it yet, or fundamentally impossible?

DriverKit works on M1; you shouldn't be using a kext for that, you should be using GCAdapterDriver.app: https://secretkeys.io/gcadapterdriver/
If you're after overclocking, that is not currently supported on DriverKit (so Big Sur/Monterey) due to a bug in DriverKit that I reported to Apple some time ago regarding polling-rate changes not taking effect. Catalina has DriverKit, however it has numerous other bugs and in general a kext is used there for sanity.
If you want to overclock on Big Sur or Monterey, there's a separately maintained guide over here: https://github.com/project-slippi/Ishiiruka/wiki/Overclocking-Controllers-on-macOS-Big-Sur-or-Monterey
If Apple does not fix the bug at some point here I will likely sign the kext for tinkerers who know what they're doing and can install themselves, but I don't expect there to be a signed PKG installer for it. I would absolutely prefer to just do it in DriverKit though and keep a clean separation of drivers here, as kexts are increasingly annoying to deal with.
Going to close this as it's not a bug (at least not with GCAdapterDriver).

I also tried installing the app. Unless my controller is DOA… I’m not sure it is working.
The releases text was a bit vague about whether M1 users could use the driverkit app. After rereading it I still thought that.

Eh? The website has M1 for DriverKit, top right:

On the releases page, I tweaked the verbage to make it clear it's solely a paragraph about M1 kext support. I figured it was originally clear as the paragraph contains:

Note that kernel extensions are different

But regardless that should be updated. In general I don't use the Releases page as anything other than notable code bumps - the website is the source for working products.
If you installed the .app, look for the icon in your menubar that looks like a port. It has a dropdown with a switch to activate the driver. The DMG download on the page should pop open a guide explaining this.

 I missed the M1 on the website. The fact it ain’t working is probably caused by my controller.
Thanks for your hard work and thanks for taking the time to move to the User Space (DriverKit) future! ❤

Heh, not stupid - it's not exactly clear where to go to get support.
Regardless, I hope the driver works for you. If you do find a bug or something definitely feel free to open another issue here. :)


fix: openapi-validation test for fabric plugin

Includes tests for endpoints deployContractGoSourceV1,
deployContractV1 and runTransactionV1, each of them with
test cases:

Right request
Request including an invalid parameter
Request without a required parameter

Closes: #1295
Relationed with #847
Signed-off-by: Elena Izaguirre<EMAIL_ADDRESS>

@petermetz Validation is failing because FabricTestLedgerV1, in method getConnectionProfileOrg1, returns an object that does not match with openapi document (it has not description field). Should I remove this field from the required ones?

@elenaizaguirre Something doesn't sound right about that. The Fabric connection profile is something completely unrelated to OpenAPI specs/documents. I need some more context to understand the problem. Where in the code do you need to use the two in conjunction and how?

@petermetz Sorry, you're right, context is missing.
Test which failed was fabric-v2-2-x/run-transaction-endpoint-v1.test.ts. This test failed because calling runTransactionEndpointV1 (line 258) it uses, inside gatewayOptions parameter, the field 'connectionProfile'. The value of this field is obtained from Fabric Test Ledger (method getConnectionProfileOrg1), which does not include field 'description' inside 'connectionProfile', but this field is required by the endpoint specs in openapi document.
const res = await apiClient.runTransactionV1({
  gatewayOptions: {
    connectionProfile: {
      description: "some relevant description",
      ...
    },
    ...
  },
  ...
});

This happened when validation was inside each connector, so now I think that it won't happen because this test does not calling installOpenapiValidationMiddleware and does not check openapi specs.
On the other hand, I'm thinking about that, Should I force each old test to call installOpenapiValidationMiddleware to ensure that each test fulfill openapi specs?

@elenaizaguirre Ah, everything makes perfect sense now, sorry for the time it took! To answer the original question: Yes, in this case I agree as well that the best we can do is remove the field from the list of required fields because the connection profile we get back from the test ledger class is the one Fabric gives us so if the field is not present there then it doesn't matter what the documentation says about it being mandatory or not, we must not validate it as mandatory.

Should I remove this field from the required ones?

Yup, thank you for explaining it in detail!

@petermetz I prepared two test files for this issue. One of them (packages/cactus-plugin-ledger-connector-fabric/src/test/typescript/integration/openapi/openapi-validation-go.test.ts) is continually giving a timeout. Is possible to increase the timeout for that file? I can skip the test which returns a 200 code to make this test able to pass checks

Codecov Report

Merging #1296 (ec690ef) into main (18979fb) will increase coverage by 0.14%.
The diff coverage is n/a.

:exclamation: Current head ec690ef differs from pull request most recent head acf96ca. Consider uploading reports for the commit acf96ca to get more accurate results

@@            Coverage Diff             @@
##             main    #1296      +/-   ##
==========================================
+ Coverage   70.39%   70.53%   +0.14%
==========================================
  Files         302      302
  Lines       10902    10902
  Branches     1332     1332
==========================================
+ Hits         7674     7690      +16
+ Misses       2526     2508      -18
- Partials      702      704       +2

Impacted Files
Coverage Δ

...pescript/generated/openapi/typescript-axios/api.ts
86.53% <ø> (+14.42%)
:arrow_up:

...enerated/openapi/typescript-axios/configuration.ts
90.90% <0.00%> (+9.09%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 18979fb...acf96ca. Read the comment docs.


Decouple branch dependencies

@aaustin @derrickstaten @qinweigong @Sarkar
Making it possible to inject the several items into the Branch initializer, primarily for the sake of testing.
Removing as much Nocilla as possible to prevent bugs with CircleCI.
The only actual code changes are in the Branch.h and .m files. The rest is tests and CocoaPods.

Looks great :+1:


Differentiate between unhandled exception and first chance exception in Azure ApplicationInsights portal

I have the below code,
        try
        {
            await _repo.Add(new SomeClass
            {
            });
        }
        catch(DbUpdateException dbEx)
        {
           // handled
        }

The exception is handled but I am seeing the exception is logged in Azure portal in ApplicationInsights service.
Do ApplicationInsights log first chance exceptions? If yes how can we differentiate/filter first-chance and unhandled exceptions in the portal?

Any update from the team?

Is there is a way to disable first chance exceptions?

I do not think ApplicationInsights automatically captures First Chance exceptions.
The SQL Example you have might be a bug - could you share a minimal repro app, so we can suggest a fix/workaround?

@cijothomas We are daily seeing the same exception in Azure Portal (in Failures tab).
Also, we are seeing exceptions are logged twice in the portal which also shows that both first-chance and un-handled exception are getting logged.

Please share a minimal repro app. Its not possible to figure out this without a repro.

Do you need repro just with try catch block?

No. Fully Self-contained repro, showing the SDK configuration, and the code which triggers exception collection.
https://stackoverflow.com/help/minimal-reproducible-example

@cijothomas just created a simple app deployed into Azure,
using Microsoft.AspNetCore.Mvc;
using Microsoft.AspNetCore.Hosting;
using Microsoft.Extensions.Hosting;
using Microsoft.AspNetCore.Builder;
using Microsoft.Extensions.DependencyInjection;
using Microsoft.EntityFrameworkCore;
using System.Threading.Tasks;

namespace AppInsights.FirstChanceException.MinimalRepo
{
    public class Program
    {
        public static void Main(string[] args)
        {
            CreateHostBuilder(args).Build().Run();
        }

        public static IHostBuilder CreateHostBuilder(string[] args) =>
            Host.CreateDefaultBuilder(args)
                .ConfigureWebHostDefaults(webBuilder =>
                {
                    webBuilder.UseStartup<Startup>();
                });
    }

    public class Startup
    {
        public void ConfigureServices(IServiceCollection services) {
            services.AddApplicationInsightsTelemetry().AddMvc();
            services.AddDbContext<MyContext>(options =>
            {
                options.UseSqlServer("Server=tcp:DBName.database.windows.net,1433;Initial Catalog=DB;Persist Security Info=False;User ID=i1;Password=DbPass;MultipleActiveResultSets=False;Encrypt=True;TrustServerCertificate=False;Connection Timeout=30;");
            });
            }

        public void Configure(IApplicationBuilder app, IWebHostEnvironment env, MyContext contex) =>
            app.UseRouting().UseEndpoints(endpoints =>
            {
                endpoints.MapControllers();
                contex.Database.EnsureCreated();
            });
    }

    [Route("")]
    public class HomeController : ControllerBase
    {
        private readonly MyContext context;

        public HomeController(MyContext context)
        {
            this.context = context;
        }

        public async Task<IActionResult> Index()
        {
            try
            {
                await context.AddAsync(new Model
                {
                    UserId = 1,
                    Id = 1,
                });
                await context.SaveChangesAsync();
            }
            catch (DbUpdateException dbEx)
            {
                return Ok("Error Caught");
            }

            return Ok("Error Not Caught");
        }
    }

    public class MyContext : DbContext
    {
        public MyContext(DbContextOptions<MyContext> options) : base(options)
        {
        }
        public DbSet<Model> Models { get; set; }
        protected override void OnModelCreating(ModelBuilder modelBuilder)
        {
            modelBuilder.Entity<Model>().HasKey(m => new { m.Id, m.UserId });
        }
    }
    public class Model
    {
        public int Id { get; set; }

        public int UserId { get; set; }
    }
}

<Project Sdk="Microsoft.NET.Sdk.Web">

  <PropertyGroup>
    <TargetFramework>net5.0</TargetFramework>
  </PropertyGroup>
	<ItemGroup>
		<PackageReference Include="Microsoft.ApplicationInsights.AspNetCore" Version="2.20.0" />
		<PackageReference Include="Microsoft.EntityFrameworkCore.SqlServer" Version="5.0.2" />
	</ItemGroup>
</Project>

Thanks for sharing the repro. Could you also share the sdkverison field value from the collected ExceptionTelemetry?

What do you mean sdkverison from the collected ExceptionTelemetry? I have only reference Microsoft.ApplicationInsights.AspNetCore (see above) and enable application insights from Azure portal/

Ah you mean from the portal? This is SDK version | il:2.20.0-103

The category name is Microsoft.EntityFrameworkCore.Update which means Microsoft.EntityFrameworkCore is sending this exception to ApplicationInsight (even though exception is handled). This look like issue is from EF team side.


vault backend fix

Tiny little fix.
At the moment vault backend doesn't implement backend.Backend.

YassineE's changes applied. Something else?

Thank for your contribution @eliastor! 🎉


Integrating Text message service

The factors which we can consider are

[ ] responsiveness of customer care
[ ] price
[ ] data integrity
[ ] transparency
[ ] data security

Text Local

Pricing

10 Messages
FREE
FREE

1,000 Messages
₹295
29.5 paisa

2,000 Messages
₹590
29.5 paisa

5,000 Messages
₹1,375
27.5 paisa

10,000 Messages
₹2,750
27.5 paisa

25,000 Messages
₹6,250
25.0 paisa

50,000 Messages
₹10,750
21.5 paisa

1,00,000 Messages
₹19,500
19.5 paisa

2,50,000 Messages
₹46,250
18.5 paisa

5,00,000 Messages
₹87,500
17.5 paisa

10,00,000 Messages
₹1,70,000
17.0 paisa

Gupshup

Pricing

United States
₹0.672

2Factor

Pricing

Exotel

Pricing

Twilio

Pricing US

NUMBER USED
TEXT MESSAGES
PICTURE MESSAGES
MESSAGING SERVICE FEATURES*

LOCAL NUMBERS
$ 0.0079
$ 0.0079
$ 0.0200

TOLL‑FREE NUMBERS
$ 0.0079
$ 0.0079
$ 0.0200

SHORT CODES
$ 0.0079
$ 0.0079
$ 0.0200


[BUG]

Describe the bug
When I export my resume to PDF, everything besides for the intro heading (photo, contact info) is blank
Product Flavor

[x] Managed (https://rxresu.me)

To Reproduce

Updated my resume after several months away
Modify previous entries.
Ensure no sections are marked as hidden
Export resume to PDF
PDF is empty except for intro heading (photo, contact info).
Add new entry
Export resume to PDF
Resume exports perfectly. But this new entry is spurious. If I delete an entry and re-enter it, the PDF is still blank in the same manner shown.

Expected behavior
I am expecting my resume to export with all the details visible, as it does when i add a new entry.
Screenshots

Export resume, empty PDF. Add new entry, export PDF, everything appears.
video: https://nimb.ws/PcyMxs

Desktop (please complete the following information):

OS: Mac Catalina
Browser Brave
Version:
Release Notes v1.52.129 (Jun 28, 2023)
Upgraded Chromium to 114.0.5735.198. (#31309) (Changelog for 114.0.5735.198)

Hey @mrcn,
Could you please provide some video or screenshots as the video link mentioned in the description gives 404 ?
Thanks!

Hey @mrcn, Could you please provide some video or screenshots as the video link mentioned in the description gives 404 ? Thanks!

That link works @Jubair70 ... The video is still hosted. I use Nimbus for exactly this purpose.
However, I downloaded it and re-uploaded it with this comment as well, just in case there are some permission issues at play.
resumex.webm

I see, I thought this issue happened only on the Leafish template but it seems as though you are on Onyx. Will look into it as soon as I can :) Apologies for the bugs.


Allow [target.'cfg(...)'] syntax in .cargo/config

In Cargo.toml there are two ways to specify target-specific dependencies:

[target.$triple.dependencies]
[target.'cfg(...)'.dependencies] (added by #2328)

But in .cargo/config there is only one way to specify target-specific rustc flags:

[target.$triple] rustflags = [...] (added by #3153)

It would be useful if [target.'cfg(...)'] was supported here too, for use cases like:
[target.'cfg(target_arch = "x86")']
rustflags = ["-C", "target-feature=+ssse3"]

Seems reasonable to me!


Frontend

Electron scripts and screenshots added

[x] Scripts for maintaining the repostory (building project, linting code and etc.)
[x] Materials and references from Figma for app's design
[ ] Dependencies in devDependencies and dependencies in package.json:

As if you written the required scripts in package.json (ref: L17), there is no dependencies in L52, please, be informed that the project itself needs the references for the packages, instruments and libraries which will be used in project.
Add into your package.json required context, so if any contributor wanted to check its maintance, he could download the everything which is required for project via:
npm i

More about it:

https://www.geeksforgeeks.org/what-are-the-different-types-of-dependencies-in-node-js/
https://docs.npmjs.com/specifying-dependencies-and-devdependencies-in-a-package-json-file


use regolibrary v2

Overview

From now on we will use regolibrary v2 version which introduces some controls that break previous versions of kubescape.

is it still draft?

not anymore :)


needs for predict demo

Good job !
would you please release a predict demo ?
thanks !

Hi, you can checkout demo.ipynb

What about this demo?
Integrated into Huggingface Spaces 🤗 using Gradio. Try out the demo


NOT BUG something missed

Explain the bug
Write a clear description of what the bug is.
To reproduce

Go to '....'
Click on '....'
Scroll down to '....'
See the error

Expected behavior
Write a clear description of what you expected.
Logfile
Upload the log file here for us to understand your issue better.

You can access it from Settings->About->Open log location.
or
Copy the debug.log and debug_fulltrust.log from the following directory, and upload the files here.
%localappdata%\Packages\49306atecsolution.FilesUWP_et10x9a9vyk8t\LocalState

Screenshots
Add screenshots to help explain your problem if needed.
System Information

OS Version: [e.g. Windows 10 20H2 19042.804] (Press WIN + PAUSE/BREAK, use the copy button at the bottom)
App version: [e.g. v1.0] (In the app, go to Settings -> About, the version is shown at the top)

Additional comment
Add any other comment about the problem here. Does this problem happen again after restarting the app?

just if you add column view (similar to mac os ). OR  files tree (like windows explorer)

Column view is already implemented.

I mean something like this
https://i.stack.imgur.com/GiecU.jpg

Column view is already implemented.

I mean something like that

or

Like this =)


@graphql-codegen/typescript-rtk-query to allow import name different to api

Is your feature request related to a problem? Please describe.
If I for example I name my api as something besides api e.g
export const graphqlApi = createApi({
  baseQuery: graphqlBaseQueryWithAuth,
  endpoints: () => ({}),
})

the codegen will create:
import { api } from '../baseApi'

and I would need to edit the import manually to the correct import of
import { graphqlApi } from '../baseApi'

Describe the solution you'd like
Allow the import to be editable.
So in my example, I would like some functionality to allow me to edit the import name used to be editable from api to graphqlApi

Made a PR for this https://github.com/dotansimha/graphql-code-generator-community/pull/75

https://github.com/dotansimha/graphql-code-generator-community/releases/tag/release-1675282344073

https://github.com/dotansimha/graphql-code-generator-community/releases/tag/release-1676403866049


Buffers in chat mode are too small for a decent experience and are much smaller than the context window

fixed in recent commit today


Issues fixed

Issues Fixed with NavBar, Responsiveness , UI , Folder Structure

Managed The Entire code base's folder structure and re arranged it for a cleaner look and easy navigation throughout the project
Made changes to almost every code file in accordance to the folder structure
Fixed issues in responsiveness of UI in navbar
Provided responsiveness to almost every CSS file
Refractored , provided proper formatting in all code files following good coding standards and clean code practices

Kindly Review the changes , Merge the code into main and mark this as completed under GSSOC 24

There have some conflict issues check it once and then make a new PR

Conflicts can only be viewed/resolved from your side, I don't have the
permission to do so !!
On Fri, May 31, 2024, 11:01 AM Arghadip Manna @.***>
wrote:

There have some conflict issues check it once and then make a new PR
—
Reply to this email directly, view it on GitHub
https://github.com/arghadipmanna101/Flipkart_Clone/pull/844#issuecomment-2141259920,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AT5T55G6Q7UMS6RPGRHPGFTZFADKXAVCNFSM6AAAAABIRLEI7CVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDCNBRGI2TSOJSGA
.
You are receiving this because you authored the thread.Message ID:
@.***>

There have some conflict issue check it once and then make a new PR. ok


Validator for Lenght, MinLneght and Maxlenght, still not work in ASP.NET core 2.2 v8.4

I already try all of then Lenght, MinLneght and Maxlenght, and all incorrect result.
For example:
Password = 1234567
RuleFor(x => x.Password).NotNull().Length(6,10).WithMessage("min 6 and max 10 character");
return saying should be more than 6 character, when i put 7.
i mean, seems that not detected size string to check and compare
same result when use  MinLneght and  Maxlenght

i was wrong


build: update gyp repo location

gyp has moved.

Oh, I saw https://github.com/libuv/libuv/pull/240 before and landed that one, sorry about that Alexis :-/


fix(db) blue/green migration for route regex path

The migration steps should happen in the up phase, not the teardown phase.
Notice this PR needs cooperation from 2.8.x.x.
fix FT-3293

@Suika-Kong could you please adapt the commit message so that it is compliant to https://www.conventionalcommits.org/en/v1.0.0/

@Suika-Kong could you please adapt the commit message so that it is compliant to https://www.conventionalcommits.org/en/v1.0.0/

I think this is our format:
https://github.com/Kong/kong/blob/master/CONTRIBUTING.md#commit-message-format

If I remember correctly, the original idea of migrations was to do:

schema changes in up
data changes in finish

We have done data changes in finish before, and sometimes they work, and sometimes they cause huge issues. Especially if there are both schema changes and data changes. This is especially problematic in Cassandra clusters, if I remember correctly.

Is this one still target 3.0? Trying to decide if needed cherrypick

We decided to only support blue/green migration from <IP_ADDRESS> where we support both ~ and auto-detection(but users are not allowed to create ~ regex path).


Should sourceMappingURL comments be included in bower distributions?

Hi Team!
First off, thanks for Showdown - it's a really useful package. :+1:
I'm having a bit of trouble when integrating the bower package into my workflow though, specifically with the sourceMappingURL comments (see my comment on the ember-cli-uglify package for more detail).
In short, the bower package doesn't include any of the src/ files, but the files in dist/ have generated source maps that point to those files (and the comments that in turn point to those map files).
Would you folks be open to a change to the gruntfile in order to not generate source maps when building a package for distribution? Or would you prefer an alternate solution?
Thanks!
Nik

Hey @nikz. Thank you for your kind words.
It seems the best way is not to include a src map for the concatenated files in the bower package (it does not make much sense since it points to non existent files).
The regular package would keep them.

@tivie: OK, great - would you like me to make the grunt modifications to exclude the map files? I can potentially handle that. :)

@nikz No grunt modifications needed. The only thing needed is to make bower ignore map files. Although I'm kind of conflicted about it since map files are extremely useful for debugging.

@tivie definitely agree, but without the files in src they aren't so useful? So we should either exclude the map files or include the source files?

@nikz If we remove the map files from bower but keep the sourcemap comments, would it fix the problem?

@tivie I'm not 100% sure - I've just been removing the comments :) Let me give that a go today and get back to you?

@tivie I just end up getting a message like the following:
Warning: ignoring input sourcemap for bower_components/showdown/dist/showdown.js because ENOENT, no such file or directory '/Users/nik/Projects/gelato/ember/tmp/concat_with_maps-input_base_path-WJdhcaUE.tmp/0/bower_components/showdown/dist/showdown.js.map
But everything works! :+1:

OK, so after some thought I think it might be better to include the src files in bower distributions. It increases download size a bit but, apart from that, I don't see any inconveniente.
@nikz What do you think?!

@tivie I think that would be fine, so long as they aren't getting built for distribution or anything like that. Means that the source map URLs have something to point to!

Should be fixed now.


Update the game over message

Update the game over message so people know how to play again!

Nice pull request!


Update Docker images with TF 2.6 and pyxir update

Updates docker image with tlcpackstaging 20220404-055909-fcdf4636d to update TensorFlow to 2.6 and solve Vitis-AI build fixes caused by an allocation error from TensorFlow 2.6.
Also updates Keras, h5py and pyxir.
Validation results with this images: https://ci.tlcpack.ai/blue/organizations/jenkins/docker-images-ci%2Fdocker-image-run-tests/detail/docker-image-run-tests/82/pipeline
ci_hexagon is intentionally left out of this update due to https://github.com/tlc-pack/tlcpack/issues/103 (cc @mehrdadh)
cc @driazati @areusch @manupa-arm @Mousius @jtuyls

Closes #10696


Update request: google-chrome 116.0.5845.179 → 116.0.5845.187

Package name: google-chrome
Latest released version: 116.0.5845.187
Current version on the unstable channel: 116.0.5845.179
Current version on the stable/release channel: 116.0.5845.179
[x] Checked the nixpkgs pull requests

Notify maintainers

@primeos
Please note a new version of Chrome is now available to address an exploited-in-the-wild zero-day vulnerability in the WebP image parsing code in the Chrome browser. This vulnerability could allow arbitrary code execution when a specially crafted image is viewed. Please update as soon as possible. For more information on the vulnerability, tracked as CVE-2023-4863, refer to this disclosure from Google: https://chromereleases.googleblog.com/2023/09/stable-channel-update-for-desktop_11.html

Note for maintainers: Please tag this issue in your PR.

I'm seeing 116.0.5845.187 on both 23.05 and unstable.
Per https://github.com/NixOS/nixpkgs/issues/254798 chromium/google-chrome was one of the first things that was patched.

Those versions are released on both channels but on stable updates for google-chrome-dev and google-chrome-beta are missing


Fix minor corrections.

Q
A

Is bugfix?
✔

New feature?
❌

Breaks BC?
❌

Fixed issues
https://github.com/yiisoft/active-record/issues/101

[x] Fix phpdocs.
[x] Rework workflows.

👍


Add config support

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

2 of 56 (3.57%)  changed or added relevant lines in 2 files are covered.
1 unchanged line in 1 file lost coverage.
Overall coverage decreased (-28.2%) to 30.0%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

main.go
2
18
11.11%

config.go
0
38
0.0%

Files with Coverage Reduction
New Missed Lines
%

main.go
1
35.29%

Totals

Change from base Build 908896409:
-28.2%

Covered Lines:
33

Relevant Lines:
110

💛  - Coveralls


Support for rack 3.1.0

Hello Zipmark,
we are Team Nautilus, and we would like to report an issue related to the rspec_api_documentation gem.
We are using Ruby 3.1.1 with the following Gemfile:
gem 'rails', '7.1.3'
gem 'rack', '3.0.11'
gem 'rspec_api_documentation', git: 'https://github.com/zipmark/rspec_api_documentation.git'

GIT
  remote: https://github.com/zipmark/rspec_api_documentation.git
  revision: d32bf17932a379052e8bb7540fc29ce7e72712ae
  specs:
    rspec_api_documentation (6.1.0)

and when we run the command rake docs:generate, everything works fine.
However, after updating the rack gem to version 3.1.0, we encounter the following error:
NoMethodError:
    undefined method 'rewind' for nil:NilClass
        input.rewind

at rspec_api_documentation-d32bf17932a3/lib/rspec_api_documentation/client_base.rb#48.
Can you help us resolve this issue?
Thank you.

I'm running into this as well with rspec_api_documentation 6.1.0, ruby 3.2.5, rails <IP_ADDRESS> and rack 3.1.7.

In rack 3.0.11 last_request.env["rack.input"] has a value. After that it does not.
https://github.com/rack/rack/blob/main/UPGRADE-GUIDE.md#rackinput-is-no-longer-required-to-be-rewindable

Switching forks fixed the problem: gem 'rspec_api_documentation', github: 'SchoolKeep/rspec_api_documentation', ref: '13df1ac'
It works also for us, thank you!


Lock screen orientation

Hi is there anyway to lock the screen orientation on scanner plugin or at least inherit those properties from the app itself?
Currently rotates the scanner and the dimensions are not always fit to screen (on tablet) even if the application it is a part of has a locked orientation.
Thank you.

I’m pretty sure it’s set to lock to portrait regardless of orientation on iOS and Android. What OS are you experiencing the issue on for tablets?
On Mon, Feb 11, 2019 at 10:50 AM, Paul Lee<EMAIL_ADDRESS>wrote:
Hi is there anyway to lock the screen orientation on scanner plugin or at least inherit those properties from the app itself?
Currently rotates the scanner and the dimensions are not always fit to screen (on tablet) even if the application it is a part of has a locked orientation.
Thank you.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub [https://github.com/dealrinc/cordova-gmv-barcode-scanner/issues/18] , or mute the thread [https://github.com/notifications/unsubscribe-auth/AHvidQhwqMcU8kScLGQsmX6GoBoL_a3kks5vMa1ZgaJpZM4a0uMg] .

Thanks for getting back to me.
We are experience the rotation on both Android 8.0 and 8.1 OS.

On Feb 11, 2019, at 11:33, forrestmid<EMAIL_ADDRESS>wrote:
I’m pretty sure it’s set to lock to portrait regardless of orientation on iOS and Android. What OS are you experiencing the issue on for tablets?
On Mon, Feb 11, 2019 at 10:50 AM, Paul Lee<EMAIL_ADDRESS>wrote:
Hi is there anyway to lock the screen orientation on scanner plugin or at least inherit those properties from the app itself?
Currently rotates the scanner and the dimensions are not always fit to screen (on tablet) even if the application it is a part of has a locked orientation.
Thank you.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub [https://github.com/dealrinc/cordova-gmv-barcode-scanner/issues/18] , or mute the thread [https://github.com/notifications/unsubscribe-auth/AHvidQhwqMcU8kScLGQsmX6GoBoL_a3kks5vMa1ZgaJpZM4a0uMg] .
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub https://github.com/dealrinc/cordova-gmv-barcode-scanner/issues/18#issuecomment-462463039, or mute the thread https://github.com/notifications/unsubscribe-auth/AEeZdPrMCWyINnwIIsRuwIbxPnDM1G6aks5vMcWUgaJpZM4a0uMg.

Looks like the code on android that is supposed to be handling this and forcing it to portrait is here. I did a couple searches and found some StackOverflow answers indicating that the only time you need to do anything special for tablets is when you want to allow the tablet into landscape mode but not allow the phone, so this code should be functioning properly as-is.
I'd start playing with the code around that link above and see if it can be adjusted to fix this landscape orientation issue for Android tablets.

Thank you very much for looking into this!
** Sent from a tiny computer in my big ol' hands. Please excuse any errors **

On Feb 12, 2019, at 11:09, forrestmid<EMAIL_ADDRESS>wrote:
Looks like the code on android that is supposed to be handling this and forcing it to portrait is here. I did a couple searches and found some StackOverflow answers indicating that the only time you need to do anything special for tablets is when you want to allow the tablet into landscape mode but not allow the phone, so this code should be functioning properly as-is.
I'd start playing with the code around that link above and see if it can be adjusted to fix this landscape orientation issue for Android tablets.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub, or mute the thread.


[DCO_Diagram] Flow chart of Veterinary Clinic process

Create a flow chart that shows Sahagun's full business process.

Updated Flowchart.


Fix progress observer for courses and info commands

Coverage remained the same at 64.848% when pulling 5265af5dfdcb222ccea19a8bed51f8e611b1a7d2 on observer-fix-mikko into 1c73a2228f0396788614e6b0aa65292a2565eda0 on master.

Coverage remained the same at 65.068% when pulling ed0681430160609479e373460d3e7b6353a33926 on observer-fix-mikko into f58a41c889d6f306e83a4150320ce6588c84befc on master.

LGTM


About battery 'hotpatch'

Hi. I very supprise about your efi because of your patched ssdt. How can you create a patched for battery. I've read Rehabman's guide but i don't know how to create it. Can you help me to make a 'hotpatch' for my system? Thank you! Sorry about bad english. I'm not good at it.

Wow I certainly didn't expect someone to actually find this repo lmao.
Rehab man guide is hard to understand I know. It took me a couple of days with the help of other people explaining to me to understand how it worked. But it was 3 years ago and I have forgotten a little (i can remember if I look through it again)
But today patching isn't necessary, you should try the ECenabler kext that replace the battery patch action to have a working battery %
https://dortania.github.io/OpenCore-Post-Install/laptop-specific/battery.html#dual-battery

@Cimmerian-Iter  I tried ECEnabler.kext for 2 week ago. It working but it had a delay. When i booting to macOS for the first time, the icon appear and no issues found. But when i boot for the second time, the icon disappeared. At the moment, i think that the kext didn't working anymore, but after 15 minutes using mac, the battery icon appeared again. I don't have no idea with it. If i using DSDT with rehabman's battery patched, the battery display perfect. I've read about the way to convert from DSDT to SSDT but i didn't understanded how to make it.

Oh then if the DSDT patch works fine then it should be easy to convert as DSDT, once I'm out of holiday I'll explain how to do the SSDT

@Cimmerian-Iter I waiting for you!^.^ I can wait for you until you have free time after your holiday. I hope that to convert from DSDT to SSDT would be easier when someone help me to do that:)