fix: STONE-442 Temporarily increase timeout for 'pipeline' SA creation.

Description
STONE-442 - Recently we've seen too many failures in CI related to this issue.
Given the issue is tracked in upstream and given the rate of flakiness of this issue I'm proposing to temporarliy increase the timeout to 1 minute from original 30 seconds.
Issue ticket number and link
Type of change

[x] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[ ] This change requires a documentation update

How Has This Been Tested?
It hasn't :-D
Checklist:

[ ] I have performed a self-review of my code
[ ] I have commented my code, particularly in hard-to-understand areas
[ ] I have made corresponding changes to the documentation
[ ] I have added meaningful description with JIRA/GitHub issue key(if applicable), for example HASSuiteDescribe("[test_id:01] DEVHAS-62 devfile source")
[ ] I have updated labels (if needed)

CI failed on timeout
  [FAILED] in [AfterAll] - /tmp/tmp.xMpAMjHlpm/tests/integration-service/integration.go:85 @ 01/30/23 16:20:16.436
  << Timeline
  [FAILED] Timed out after 600.000s.
  timed out when waiting for the PipelineRun to finish
...
  [FAILED] in [It] - /tmp/tmp.xMpAMjHlpm/tests/build/build.go:491 @ 01/30/23 16:24:39.491
  << Timeline
  [FAILED] Timed out after 900.000s.
  timed out when waiting for the PipelineRun to finish

This is an issue related to https://issues.redhat.com/browse/STONE-455

@rhopp I added a commit that gives some extra time to those 2 problematic PRs. Hopefully we can hit 2 birds with 1 stone like that


chore (EMI-1966): create feature flags for collector signals

This PR relates to EMI-1966
#minor #squashongreen
Description
This PR creates the following feature flags for collector signals:

AREnablePartnerOfferSignals
AREnableAuctionImprovementsSignals

PR Checklist

[x] I have tested my changes on iOS and Android.
[x] I hid my changes behind a feature flag, or they don't need one.
[x] I have included screenshots or videos, or I have not changed the UI.
[x] I have added tests, or my changes don't require any.
[x] I added an app state migration, or my changes do not require one.
[x] I have documented any follow-up work that this PR will require, or it does not require any.
[x] I have added a changelog entry below, or my changes do not require one.

To the reviewers 👀

[ ] I would like at least one of the reviewers to run this PR on the simulator or device.

Changelog updates
Changelog updates

Dev changes

New feature flags for collector signals

Need help with something? Have a look at our docs, or get in touch with us.

This PR contains the following changes:

Dev changes (New feature flags for collector signals)

  Generated by :no_entry_sign: dangerJS against a839669981f01fcb33dc44b70b906d6128e70d1c


Unity / Mono V1 with cattrs

There are 2 sets of monoclass offsets possible within V1: without cattrs and with cattrs.
This looks at the monoclass_image to see if it points back to the image that the class came from, to decide which of those sets of offsets to use.

Closing in favor of https://github.com/LiveSplit/asr/pull/92


Pass down props for getting extra field from expo.json

https://github.com/react-community/create-react-native-app/blob/master/react-native-scripts/src/bin/crna-entry.js#L16
I think this line should be fix to:
// we don't want this to require transformation
class AwakeInDevApp extends React.Component {
  render() {
    return React.createElement(
      View,
      {
        style: {
          flex: 1,
        },
      },
      React.createElement(App, this.props),
      React.createElement(process.env.NODE_ENV === 'development' ? Expo.KeepAwake : View)
    );
  }
}

This is tricky. We probably want to think about what this impacts a little bit more. For one thing, people using CRNA should generally be encouraged to write code that can eject to "raw" RN very cleanly, and adding more Expo-specific stuff here concerns me as a result. This is one reason why I exposed the REACT_NATIVE_* environment variables in process.env -- it allows you to pass configuration in an implementation-independent way that you can easily reproduce if you were to eject.
That said, this could be very nice to have, just want to think about it more.

By the way, thanks so much for sending this PR and great catch!


Log forwarding issues

At current moment we are running load tests against our Cloud Foundry deployment. During tests our system can produce around 12000 logs/sec. We have configured syslog_daemon_config to forward all logs to ELK. At some moment we stop to get any logs and only monit restart metron_agent for each Cloud Foundry instance helps to resume logs forward process.
I believe that the bottleneck is somewhere between metron_agent and doppler. But also as i understand with syslog_daemon_config property enabled metron_agent only adds rsyslog template to /etc/rsyslog.d folder and all components logs must be forwarded via rsyslog daemon. So for me it is not clear how monit restart metron_agent can solve logs forwarding issue.

rsyslog does not forward component VM logs to the Loggregator system. Resetting Metron will also restart rsyslogd.
Metron is (was) used to configure the rsyslogd, but does not do anything with the data.


When the plan to support the JavaRMI Client Plugins?

Please answer these questions before submitting your issue.

Why do you submit this issue?
[x] Feature or performance improvement

Requirement or improvement

Please describe about your requirements or improvement suggestions.
when the pan to support javarmi client plugins

There is no support plan in the SkyWalking community. Anyone wants to add new plugin, we are welcome the contribution and be happy to help with review. But no committer will be responsible to provide a new one, unless he needs it by himself.

@wu-sheng  thanks

@vipsql I didn't ask to trace the original RMI API, and a lot of that information wasn't available, so I did the tracing directly based on Spring RMI.

@vipsql Because Java RMI does not support passing trace information through headers or attachments, I closed the issue


Fix Alt-text cannot be an image file name #217

Fixes #217, by adding a regex to check for most common file formats in use.
Can use some feedback on the error text and any additional formats that might have been missed

 Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.:x: Dgaduin sign nowYou have signed the CLA already but the status is still pending? Let us recheck it.

Can use some feedback on the error text and any additional formats that might have been missed

To be more clear: I think they're good as is.


Enable default cache locally based on env var

This change enables our default cache locally based on an environment variable. This will enable us to use the default cache in local development more easily.
How to test this PR
Set ENABLE_DEFAULT_CACHE in .env (see .env_SAMPLE in this PR).
Run ./cfgov/manage.py createcachetable
Run ./cfgov/manage.py shell and:
from django.core.cache import cache
cache.set('my_key', 'hello, world!', 10)
cache.get('my_key')

You should get hello, world! back.
Then wait 10 seconds and try again:
cache.get('my_key')

And you should get nothing.
Notes and todos

We should settle on use cases of the Django cache and document them, along with this env var to enable the cache locally.

Checklist

[ ] PR has an informative and human-readable title
[ ] Changes are limited to a single goal (no scope creep)

Any risk in having that env var exported by default?

You mean always enabled? I think it could result in some unexpected frustration if, for example, I was to use the Django cache to store authors, topics, and categories that we use in the filterable lists, and someone expects that to change locally when they add or edit a page and it doesn't.
For local development, I think making turning on the cache intentional makes more sense than having it on by default.

Is "default cache" the clearest name for this? What do you think about ENABLE_DJANGO_DEFAULT_CACHE?

It's consistent with the ENABLE_POST_PREVIEW_CACHE variable. Both of those could certainly have ENABLE_DJANGO_ prefixed, but I think I'd want to maintain that consistency if we're going to be explicit about it. I don't have strong feelings beyond that though.

Any risk in having that env var exported by default?

You mean always enabled? I think it could result in some unexpected frustration if, for example, I was to use the Django cache to store authors, topics, and categories that we use in the filterable lists, and someone expects that to change locally when they add or edit a page and it doesn't.
For local development, I think making turning on the cache intentional makes more sense than having it on by default.

Makes sense :+1:

Is "default cache" the clearest name for this? What do you think about ENABLE_DJANGO_DEFAULT_CACHE?

It's consistent with the ENABLE_POST_PREVIEW_CACHE variable. Both of those could certainly have ENABLE_DJANGO_ prefixed, but I think I'd want to maintain that consistency if we're going to be explicit about it. I don't have strong feelings beyond that though.

I considered that but wasn't sure if changing an established env var was going to cause too many headaches, and POST_PREVIEW_CACHE is considerably more specific and descriptive than DEFAULT_CACHE, so one is not likely to not know (or need to know) that it's also a Django cache, but I don't feel strongly about it. Still approved, either way.

I would like to document how to use the Django cache, once we have some use cases. I think that might be a good time to revisit the naming question? I'm going to merge this one for now.


Tracking Issue for v0.9

Hello!
I am titling this v0.8.1, but I expect this will actually end up describing v0.9.0 (we love to make breaking changes around here).
Here are my personal two goals for this release (which should happen much faster than v0.8.0) and one stretch goal.

Documentation. Documentation EVERYWHERE.
Eagle-eyed repo watchers may have notied that #![deny(missing_docs)] was added to the repo, commented out. I would like to release the next version of this crate with that lint enabled. Currently, we have an even 300 missing pieces of documentation. That's a lot, and to a degree, we need to solve that by...writing docs. However, on a deeper level, we have kinds of code which is almost purpose built to be annoying to document. Many of our builders attempt to hide bitflags with bit_flag_name(&mut self, bool) kinds of methods (for example, collapsible on the WindowBuilder struct). These create tons of functions and bad namespacing -- instead, I wish we just had a .flags method that users provided bitflags to.
Additionally, I'd like to have more examples for the most used widgets. We have a lot of that covered already, but I'll make a list soon of those that are lacking.
This might not be done fully in time for release, but I'd like us to make the effort. However, unless you're sure that the code you're going to document won't be edited in this release (if it's on Ui for example, it's probably okay), then let's hold off on this till the other points are addressed.

Make alternatives to the Builder pattern.
This one is a big complex because we have several approaches we can take. First, the problem itself: builders are annoying to use because the builder struct itself needs to be pulled into scope, and it makes it so that many basic widgets (buttons, input_text, etc) are on the Ui object, but more interesting widgets (like Window) are in some builder that you need to find. Ideally, everything which Ui can build, Ui should have a method to build it.
I see us approaching this with a few methods:

Ui can create the requisite Builder with a method, and we maintain the builder syntax. So to create a window, for example, you could do ui.begin_window("name", REQUIRED_PARAM).build();. I think this is a fine idea, and involves probably the least code deletion.
Ui uses with_x style "overloads" to allow for extra parameters to be passed in. This works, and is quite nice for many, perhaps even the majority, of functions, but really has a tough time for something like Window, where there are a LOT of things that can be given to Window, and the russian doll of with_x gets difficult.
We use a simple x and x_with pattern, where x takes the core required data, and x_with passes in an additional paramter of some Struct of Optional data. Carefully use of Default and allowing users to ..Default::default() can make this, possibly, ergonomic. I'd like to take a swing at this in a few weeks. It's worth pointing out that this method is compatible with the second as well (complicated structs get just the with, simpler ones get with_flags).

Okay, big stretch goal: I'd like us to work on our xtask and build system such that we can have features which differentiate the kind of dear imgui we're binding to. The big goal would be, of course, the docking branch (and then people will stop PRing the docking branch at me), and the string-view branch. On its face, that's ALREADY a mis-use of cargo features, which should always be additive, but I am miscreant who does crimes, so maybe we do it anyway. Otherwise, other ways to handle the docking branch (without moving the repo entirely to tracking the docking branch -- we are always going to track the mainline dear imgui versions) would interest me!

If you have any ideas for this release cycle, please list them out! I'd like to figure out a todo list so I can track what we need to get done in a more organized way for this cycle.

string-view can be an internal implementation detail, so having both docking and string-view features enabled can just use docking. Ofc, this doesn't really work for the -sys crate, but that's probably fairly minor, I doubt it has that many direct consumers who would be concerned about feature collisions.
Unfortunately, I think the only way forward for docking and string-view is to vendor all three (either as submodules or subtrees or something). Note that given the way cargo works, we can't do things like switch branches in the build.rs of the sys crate.

...released! https://github.com/imgui-rs/imgui-rs/releases/tag/v0.9.0

Note the docs.rs queue seems massively backlogged currently (currently about 4413 builds queued), but seems to slowly be getting through it


Develop

What kind of change does this PR introduce?

Does this PR introduce a breaking change?

What needs to be documented once your changes are merged?

👷 Deploy Preview for betsweatwin processing.

Name
Link

🔨 Latest commit
65345be45b0a4b2426c9f10ab517f92d43e07336

🔍 Latest deploy log
https://app.netlify.com/sites/betsweatwin/deploys/654e8a9012f8fd00084ee4fa


Documentation for default element styles

Description
Hello,
Getting started with Typst has been great and having the default values for style functions and the effect of other syntactic elements in the docs has been very useful. However, the heading styling behavior (and caveats) are missing from the docs.
Use Case
This info would facilitate the customization or even a 'style reset' of headings. Explainers like the one on typst#2919 bring a lot insight into a slightly obscure behavior.
Thank you!

Closing in favor of https://github.com/typst/typst/issues/5095, which has more details.


version_iter: IndexError: tuple index out of range

breaks on any package, eg.:
$ pytoport /tmp/x requests
[-] Generating files for requests...
[-] Generating Makefile
PySocks has extra info: extra == 'socks'
pyOpenSSL has extra info: extra == 'security'
idna has extra info: extra == 'security'
cryptography has extra info: extra == 'security'
Traceback (most recent call last):
File "/usr/local/bin/pytoport", line 11, in
load_entry_point('pytoport==0.4.1', 'console_scripts', 'pytoport')()
File "/usr/local/lib/python3.5/site-packages/pytoport/init.py", line 319, in main
generate_makefile(data, path, **user)
File "/usr/local/lib/python3.5/site-packages/pytoport/init.py", line 202, in generate_makefile
min_py = get_minimum(data)
File "/usr/local/lib/python3.5/site-packages/pytoport/init.py", line 109, in get_minimum
supported = list(version_iter(data))
File "/usr/local/lib/python3.5/site-packages/pytoport/init.py", line 99, in version_iter
raw = parts[2].split('.')
IndexError: tuple index out of range

This is fixed now.


Question: Tel format masking?

Anyone using https://www.npmjs.com/package/react-text-mask to mask a field like a phone number?  I am trying to figure out how to best handle a phone number field that needs to filled out with an int'l number format.
It would be super powerful if I could figure out how to integrate this hook with this capability: https://text-mask.github.io/text-mask/
Any ideas/suggestions?

Hi @dstroot - sorry for the late response.
I hope you found a way around this issue, but if you're still looking for help, I'd suggest looking into utilizing raw which allows you to build custom controls with different interfaces (it's sort of an adapter).
I'm not really familiar with that component you linked above, but perhaps you could build a wrapper component around your masked input and let this hook communicate with it using the raw type.
Something along these lines:
function MyMaskedInput({ onChange, onBlur, value, name }) {
  return (
    <MaskedInput
      name={name}
      mask={[/* ... */]}
      onChange={/* ... */}
      onBlur={/* ... */}
    />
  )
}

function Form() {
  const [formState, { raw }] = useFormState();
  return (
    <div>
      <MaskedInput {...raw('phone')} />
    </div>
  )
}

Actually seems even easier new that I am trying it -  can be used as a direct replacement for


A Question...

Why we call it "Azure Monitoring single pipeline"? I would like to know why it's single pipeline?

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 3aa2f48e-a8f8-fb03-753b-9e3b76075b96
Version Independent ID: 2554dcd1-27a2-3a32-4097-b17dd261a1ad
Content: Integrate security solutions in Azure Security Center
Content Source: articles/security-center/security-center-partner-integration.md
Service: security-center
GitHub Login: @rkarlin
Microsoft Alias: rkarlin

@ParisaMousavi Thank you for your feedback! We will review and provide an update as appropriate.

@ManojReddy-MSFT please assign  to @monhaber

It is a "single pipeline" because it is the integration point for Azure Monitor.


RakeArguments helper

This has the advantage of drying the code and makes using it easier.

I think this is no longer a valid PR @tommyschaefer but the idea does fit still, I think.

Agreed :+1: I will work naming / removing duplication of argument handling


Fix when there are a lot of GitLab users

Fix #25
Note that technically the commit in that changes get_active_users() is not necessary to fix the bug.

It does not seem to work yet...
With these changes, I get:
$ tsrc push --assignee 'Real User'
=> Running git push
Branch toto set up to track remote branch toto from origin.
Everything up-to-date
[ERROR]: No user found matching: Real User
Note that 'Real User' is a real active user of this repository

Found it. It seems users can come both from the group and the project.
So basically we should make two requests instead of just one.
Also, just in case, I stopped filtering by access level.

@arnaudgelas Should be working now. Can you please check ?

@dmerejkowsky same as before:
$ tsrc push --assignee 'Real User'
=> Running git push
Branch toto set up to track remote branch toto from origin.
Everything up-to-date
[ERROR]: No user found matching: Real User

@dmerejkowsky I may know what's wrong: your query is on a given projects (you query all members of a given project), but we do use groups...
Note that I have been printing all_members in get_developers, and in our case it is empty...

Now, I wonder if your solution to get all active users was not the easiest and best solution?

I can confirm that f00aa6e9ac9141f23c6376371e20c27c9a182026 works for me!

I can confirm that f00aa6e works for me!

Yeah, but that's because you have less than 100 users :stuck_out_tongue:
Did you check this commit: 83eebeacd9aa82e22be820723be8446c620c7d6c ?
It's getting both the project members and the group members

    Now, I wonder if your solution to get all active users was not the easiest and best solution?

Nope. Won't work on gitlab.com where there's thousands of active users

Right :smile:
    I can confirm that f00aa6e works for me!

Yeah, but that's because you have less than 100 users :stuck_out_tongue:

indeed :stuck_out_tongue:
Did you check this commit: 83eebea ?

It's getting both the project members and the group members

I have just checked it, it works fine for me.
I do not really get why it was not working before (it seems you have not made any new commit)???
Anyway, thank you very much for this one!!
:beers:

I do not really get why it was not working before (it seems you have not made any new commit)?
That was a forced push. It can make things confusing.
Thanks for the report anyway. As soon as the code is reviewed, we'll make a new release.
Cheers!

ok, got it!
Awesome: I look forward to testing more the upcoming release :+1:

@arnaudgelas tsrc 0.2.4 is out :)


Translation not found

Translation key 'Scheduled timestamp must be in the future' not found in library 'common' for default language
Traceback (most recent call last):
  File "/base/data/home/apps/e~rogerthat-server/6.402130754863793752/mcfw/restapi.py", line 282, in run
    result = run(f, args, kwargs)
  File "/base/data/home/apps/e~rogerthat-server/6.402130754863793752/mcfw/rpc.py", line 180, in run
    result = function(*args, **kwargs)
  File "/base/data/home/apps/e~rogerthat-server/6.402130754863793752/mcfw/restapi.py", line 92, in wrapped
    return f(*args, **kwargs)
  File "/base/data/home/apps/e~rogerthat-server/6.402130754863793752/mcfw/rpc.py", line 164, in typechecked_return
    result = f(*args, **kwargs)
  File "/base/data/home/apps/e~rogerthat-server/6.402130754863793752/mcfw/rpc.py", line 142, in typechecked_f
    return f(**kwargs)
  File "/base/data/home/apps/e~rogerthat-server/6.402130754863793752/solutions/common/restapi/news.py", line 110, in rest_put_news_item
    message = common_translate(sln_settings.main_language, SOLUTION_COMMON, e.message)
  File "/base/data/home/apps/e~rogerthat-server/6.402130754863793752/solutions/__init__.py", line 64, in translate
    raise ValueError("Translation key '%s' not found in library '%s' for default language" % (key, lib))
ValueError: Translation key 'Scheduled timestamp must be in the future' not found in library 'common' for default language```

catch the InvalidScheduledTimestamp exception and return a translated error message

@bart-at-mobicage As no extra arguments is passed to this exception, i just added the translation.
And i have no idea how this exception is raised, the scheduling timestamp is double-checked at the client side :laughing:


Problems with pnpm monorepo

I tried upgrading from Nestia 2.x to 3.x ( latest ) but could not make it work. After trying a lot of stuff it turns out the problem was caused due to pnpm hoisting. Adding the following to the workspace-root .npmrc file fixed it for me. Creating this issue because it  might help someone facing a similar problem
public-hoist-pattern[]=typia

I'm not suffering any problem with pnpm.
Will you provide a reproducible repo?


Moved request templating to a separate module

Moved request templating library to this module
Added support for default and merge functions
Refactored tests
4 Added coverage
Added jshint

Proposal: let's rename this module to request-template, the name is free on npmjs.
Some comments about new code are inlined.

/cc @gwicke @eevans @d00rman

Why $$.default and $$.merge ? Seems a bit odd

@d00rman $$.default is needed to be able to distinguish the global method call from a local variable / global variable. They all come from different contexts and as I understand there's no other way to distinguish them in the parser.


Add HDFS Support and RFC 5655

Ability to write Vflow json data directly to HDFS.
Ability to write capture and store IPfix messages in RFC 5655 file format(https://tools.ietf.org/html/rfc5655).

What do you think about adding these new features? Do you think these features are within the context and scope of this repo? I may be able to contribute on this front.

I like both and I think they should be developed under vflow/consumers
Already we have clickhouse, memsql and spark sample consumers.
Any help would be appreciated


Add Marshmallow support

Pydantic solves only a small part of what APIs need.
Marshmallow and co solve everything.
Pydantic only validates, Marshmallow serializes and deserializes.
My usecases require the api request and response to be different from the actual python object, Marshmallow allows this, but pydantic would require me to create even more classes purely for the openapi generation.
FastApi looks awesome, and it looks like the best project for working building an api with asyncio, but this is a blocker for our team.
Edit: additional info, we currently use flask-smorest which uses marshmallow for validation, serialization and openapi generation.

Wouldn't be better to use this as an external package?

Wouldn't be better to use this as an external package?

There are other Starlette based frameworks that solve this need like Flama
It probably doesn't make sense for FastAPI to add Marshmallow support.

There are other Starlette based frameworks that solve this need like Flama
It probably doesn't make sense for FastAPI to add Marshmallow support.

Thanks for the help here @ycd ! 👏  🙇
Thanks for reporting back and closing the issue @mvanderlee  👍
Marshmallow is great! It was the best thing I had available until I discovered Pydantic.
BTW, Pydantic is used to validate, serialize, deserialize, filter, document, etc. 🤓

Sorry for the long delay! 🙈  I wanted to personally address each issue/PR and they piled up through time, but now I'm checking each one in order.


Add nice feedback to website :)

"I feel like a data witch now! I just say poof and the data looks the way I want"
"OK - this is getting to be too much fun now"

"Thanks all for a wonderful course! I feel super confident in R now and I am excited to apply what we learned to future projects. Cheers !!"


Fix pending matches bug

Overview
During confirm/reject analysis of a list, the following bug was noticed.
When an entry had multiple potential matches, names and address of the
multiple facilities were not broken by line items. The links were
linked to an incorrect address. Additionally, the confirm and reject
button showed only for the top-most potential match.
When facilities have multiple potential matches, the matches show in
individual line items with a Confirm and Reject option for each
potential match.
There were a minor propType warning and key warning which have also
been corrected.
Connects #1185
Demo

Notes
The line items aren't currently perfectly aligned. This PR fixes the functionality issue, but additional styling might be desired in the future.
Testing Instructions

Checkout this branch.
Run vagrant ssh and ./scripts/server
Navigate to a list item with two pending matches
The matches should be rendered as distinct items.
The Facility Match Name link should lead to the correct facilities.
Selecting 'confirm' or 'reject' should confirm or reject the correct facility.

Checklist

[ ] fixup! commits have been squashed
[ ] CI passes after rebase
[ ] CHANGELOG.md updated with summary of features or fixes, following Keep a Changelog guidelines

CI caught some lint
/usr/local/src/src/components/FacilityListItemsConfirmationTableRow.jsx
  158:31  error  Curly braces are unnecessary here  react/jsx-curly-brace-presence
  172:31  error  Curly braces are unnecessary here  react/jsx-curly-brace-presence
  184:31  error  Curly braces are unnecessary here  react/jsx-curly-brace-presence

Looking at this now.


Update react, update to new react-side-effect api

Is anybody here? )
@goldensunliu

hi @avanes ! thank you for your PR. unfortunately this project is no longer actively maintained. we'll update the readme to state this. internally we found that react-router already had all the functionality we needed, especially after we stopped using SSR.


add parsing of cik_lookup_data file url embedded here

https://www.sec.gov/os/accessing-edgar-data
https://www.sec.gov/Archives/edgar/cik-lookup-data.txt

Thanks, I will take a look.
If this adds Person lookup then it's functionality that's needed .. there's already company lookup

Merge cis_lookup contribution


[FEATURE] More frequent releases of puppetlabs-dsc

Hi all.
If possible, I would love to have more frequent releases of puppetlabs-dsc, including newer releases from modules. Currently we are behind schedule with at least 2 major versions, where a lots of features were added and bugs removed.
Yes, we can compile it on our own, but for majority of us this step is a really big issue that shoudn't be taken lightly.
Maybe once a month - no new features/bug fixes, only newer DSC Resources?

Hi @marcinbojko thanks for the feedback, this helps us prioritize our work.
As a policy we try to stay in sync with the major DSC Resource Kit releases from Microsoft. We generally also wait a few days to ensure there aren't any hotfixs that need to be included as well. This is in sync with our supported modules policy of trying to have the most stable code released at any one point in time.
We last released on Nov 2nd, which had the November release. The December 14th release only added the AuditPolicyDsc resource, so we decided to wait thinking more resources would be updated soon, and soon enough on December 16th there were several more updated.  Unfortunately the holidays hit after that and we are now into the new year. While we were scheduling the release with our other module release schedules, the January release was released.
Unfortunately I can't yet comment on a date, but expect a release soon. We are also in the planning stages for making building DSC Resources into our module a much easier process. Stay tuned

Thanks, @jpogran , as usuall you 're helpful.
But, please notice, than even if'we are talking about major DSC releases, there is stiil plenty of changes in dependend resources like (you know it much better than I am): https://github.com/puppetlabs/puppetlabs-dsc/blob/master/types.md
I would say that puppetlabs-dsc as aggregator for those resources is EXTREMLY important.

We recently met and made short term goals to do a point release soon with updated resources (one ticket being https://tickets.puppetlabs.com/browse/MODULES-4371) and a longer term goal of addressing building this yourself more easily. Our progress can be tracked there, so I'm closing this issue out.


Added sbt-riotctl

RIoT Control is meant to detect a Raspberry Pi or similar through Bonjour/mDNS, SCP your archive to it, and set it up as a systemd service. It probably could be used to similarly deploy to other Linux hosts.

Hi @fauberso,
Thank you for your contribution! We really value the time you've taken to put this together.
Before we proceed with reviewing this pull request, please sign the Lightbend Contributors License Agreement:
http://www.lightbend.com/contribute/cla


MongoDb Client for CosmosDb

Change checked into Dev. This provides a convenience layer by auth to Azure through MSI, SP Token, Credentials and Connection String and getting back a mgo.Session pointer. ( https://github.com/go-mgo/mgo )


Add start/end timestamps for timecop/profiling

Keep the old variables for backwards compatibility, but store the Date.now() timestamps in [variable]Start [variable]End for measured durations.
Adds:

atom.getLoadSettings().shellLoadTimeStart
atom.getLoadSettings().shellLoadTimeEnd
atom.loadTimeStart
atom.loadTimeEnd
Package.loadTimeStart
Package.loadTimeEnd
Package.activateTimeStart
Package.activateTimeEnd

With this I was able to generate a timeline graph that you might be interested in seeing.

It confirmed what I suspected (that shellLoadTime + windowLoadTime != totalLoadTime).
There's still the overhead of actually getting to src/browser/main.js to map out though.

Any progress on this?

Looks like this pr has conflicts now. I wouldn't mind fixing them if there's a change it can be merged. I should note that this just adds ___Start and ____End variables. It doesn't include any of the profiling graphs (that can be another package or timecop).

This seems legit. cc @maxbrunsfeld

@Zren Sorry for taking so long to get back to you on this :disappointed: If you're still interested, I'd love to merge this after the merge conflicts are resolved.

STOPPPPPPPPPPPP SENDING THIS CRAP OR I WILL REPORT YOU
On Wed, Mar 16, 2016 at 1:25 PM, Josh Abernathy<EMAIL_ADDRESS>wrote:

@Zren https://github.com/Zren Sorry for taking so long to get back to
you on this [image: :disappointed:] If you're still interested, I'd love
to merge this after the merge conflicts are resolved.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub
https://github.com/atom/atom/pull/3327#issuecomment-197470861

No response, closing.


Firefox: focus rectangle in the navbar missing its top border

The rectangle seems cropped.
Looking at elements heights, these seem inconsistent: multi 67px height, background 63px, extent 61px, which could be related.

Similarly, in Chrome the bottom line is missing:

Thanks for raising this, but is this still relevant now that the navigator handles have been added in #388?

It's even less urgent than before, but the current appearence of the navigator could make us forget that there is something off here, and it'd be nice to know why.

Now that #428 has been merged, can this be closed?

I think there won't be any focus rectangle anymore from now on, so it should be ok to cancel this issue.
To be safe, we can wait until I merged the highlight branch and see what it looks like together.

Ok, no problem happy to wait for #418 :)

Confirmation: it's irrelevant after merging branches.


Use NullabilityInfoContext to determine dictionary value nullability

A follow-up of #3022 (issue) and #3023 (PR).
The #3023 PR broke the behavior for many of our IReadOnlyDictionary<string, string> (and similar) members.
The reason is that the logic for reading and interpreting NullableAttribute and NullableContextAttribute flags is too simplified and is incorrect for several cases. It just happens to pass the current test cases because of the layout of the test type and its members.
Too simplified
For example, it ignores the optimization of the flags array into a single byte if they are all the same value. An optimized Dictionary<string, string> has a single [1] flag, not two or three flags as the current logic expects.
It also does a lot of assumptions related to reference vs value types. An IDictionary itself can be a value type, as can the key, both of which would affect the length of the flag array. It should be checking the number of value types and the number of flags together.
It also doesn't seem to fully respect the NullableContextAttribute that's placed on the type containing the member. And the tests did not account for differences in the context value, as the testing type always only has a single flag. So the other flag value is not tested.
My suggested change
For NET 6 and onwards we should rely on the official NullabilityInfoContext to tell us what is and isn't nullable. For earlier versions we can still have custom logic, which we can try to improve on if we want to put in the effort. But it will require a lot of effort to make it fully compliant and flexible.
The tests I added do not pass with the custom flag logic, but they do pass with the NullabilityInfoContext code.
The tests could be more flexible or enumerated in other more dynamic ways if you would like, to get the number of lines down, but I tried to follow the existing pattern of laying them all out in-line.

:warning: Please install the  to ensure uploads and comments are reliably processed by Codecov.
Codecov Report
Attention: Patch coverage is 85.71429% with 1 line in your changes missing coverage. Please review.

Project coverage is 90.59%. Comparing base (7a7230d) to head (575ddc6).

Files
Patch %
Lines

...SwaggerGen/SchemaGenerator/MemberInfoExtensions.cs
85.71%
1 Missing :warning:

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3041      +/-   ##
==========================================
- Coverage   90.59%   90.59%   -0.01%
==========================================
  Files          74       74
  Lines        2988     2976      -12
  Branches      478      470       -8
==========================================
- Hits         2707     2696      -11
+ Misses        281      280       -1

Flag
Coverage Δ

Linux
90.59% <85.71%> (-0.01%)
:arrow_down:

Windows
?

macOS
?

Flags with carried forward coverage won't be shown. Click here to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

Thanks for fixing this - the fix is now available in NuGet as version 6.7.2.


Tool running but crashes after certain domains

Hello when running the tool its fine, but after certain domains it gives this error
Traceback (most recent call last):
File "/usr/local/lib/python3.8/dist-packages/urllib3/connectionpool.py", line 670, in urlopen
httplib_response = self._make_request(
File "/usr/local/lib/python3.8/dist-packages/urllib3/connectionpool.py", line 381, in _make_request
self._validate_conn(conn)
File "/usr/local/lib/python3.8/dist-packages/urllib3/connectionpool.py", line 978, in validate_conn
conn.connect()
File "/usr/local/lib/python3.8/dist-packages/urllib3/connection.py", line 362, in connect
self.sock = ssl_wrap_socket(
File "/usr/local/lib/python3.8/dist-packages/urllib3/util/ssl.py", line 386, in ssl_wrap_socket
return context.wrap_socket(sock, server_hostname=server_hostname)
File "/usr/lib/python3.8/ssl.py", line 500, in wrap_socket
return self.sslsocket_class._create(
File "/usr/lib/python3.8/ssl.py", line 1040, in _create
self.do_handshake()
File "/usr/lib/python3.8/ssl.py", line 1309, in do_handshake
self._sslobj.do_handshake()
ConnectionResetError: [Errno 104] Connection reset by peer
During handling of the above exception, another exception occurred:
Traceback (most recent call last):
File "/usr/local/lib/python3.8/dist-packages/requests/adapters.py", line 439, in send
resp = conn.urlopen(
File "/usr/local/lib/python3.8/dist-packages/urllib3/connectionpool.py", line 726, in urlopen
retries = retries.increment(
File "/usr/local/lib/python3.8/dist-packages/urllib3/util/retry.py", line 410, in increment
raise six.reraise(type(error), error, _stacktrace)
File "/usr/local/lib/python3.8/dist-packages/urllib3/packages/six.py", line 734, in reraise
raise value.with_traceback(tb)
File "/usr/local/lib/python3.8/dist-packages/urllib3/connectionpool.py", line 670, in urlopen
httplib_response = self._make_request(
File "/usr/local/lib/python3.8/dist-packages/urllib3/connectionpool.py", line 381, in _make_request
self._validate_conn(conn)
File "/usr/local/lib/python3.8/dist-packages/urllib3/connectionpool.py", line 978, in validate_conn
conn.connect()
File "/usr/local/lib/python3.8/dist-packages/urllib3/connection.py", line 362, in connect
self.sock = ssl_wrap_socket(
File "/usr/local/lib/python3.8/dist-packages/urllib3/util/ssl.py", line 386, in ssl_wrap_socket
return context.wrap_socket(sock, server_hostname=server_hostname)
File "/usr/lib/python3.8/ssl.py", line 500, in wrap_socket
return self.sslsocket_class._create(
File "/usr/lib/python3.8/ssl.py", line 1040, in _create
self.do_handshake()
File "/usr/lib/python3.8/ssl.py", line 1309, in do_handshake
self._sslobj.do_handshake()
urllib3.exceptions.ProtocolError: ('Connection aborted.', ConnectionResetError(104, 'Connection reset by peer'))
During handling of the above exception, another exception occurred:
Traceback (most recent call last):
File "clickjacker.py", line 21, in
response = requests.get(i, verify=False)
File "/usr/local/lib/python3.8/dist-packages/requests/api.py", line 75, in get
return request('get', url, params=params, **kwargs)
File "/usr/local/lib/python3.8/dist-packages/requests/api.py", line 60, in request
return session.request(method=method, url=url, **kwargs)
File "/usr/local/lib/python3.8/dist-packages/requests/sessions.py", line 533, in request
resp = self.send(prep, **send_kwargs)
File "/usr/local/lib/python3.8/dist-packages/requests/sessions.py", line 668, in send
history = [resp for resp in gen] if allow_redirects else []
File "/usr/local/lib/python3.8/dist-packages/requests/sessions.py", line 668, in
history = [resp for resp in gen] if allow_redirects else []
File "/usr/local/lib/python3.8/dist-packages/requests/sessions.py", line 239, in resolve_redirects
resp = self.send(
File "/usr/local/lib/python3.8/dist-packages/requests/sessions.py", line 646, in send
r = adapter.send(request, **kwargs)
File "/usr/local/lib/python3.8/dist-packages/requests/adapters.py", line 498, in send
raise ConnectionError(err, request=request)
requests.exceptions.ConnectionError: ('Connection aborted.', ConnectionResetError(104, 'Connection reset by peer'))

Hi,
Sorry for the late response, seems like one of the Domains was unreachable hence the program Crashed and I didn't create a proper exception for that, let me work on it

Hi, I have added the Exception, requesting you to check again


chore: release main

:robot: I have created a release beep boop
create-node: 1.0.0
1.0.0 (2024-03-31)
Bug Fixes

release atempt - 2 (a59ea0c)

create: 1.0.1
1.0.1 (2024-03-31)
Bug Fixes

release atempt - 2 (a59ea0c)

This PR was generated with Release Please. See documentation.

:robot: Release is at https://github.com/templ-project/create/releases/tag/create-node-v1.0.0 :sunflower:

:robot: Release is at https://github.com/templ-project/create/releases/tag/create-v1.0.1 :sunflower:


Invoice Upload Feed does not work

rif. #116
Describe the bug
Document upload does not work
please reopen #116

A clear and concise description of what the bug is.

the url is wrong. The api reply user not allowed. See #116

Which Amazon MWS Marketplace are you using?
All

Most Important, Is this working with the Amazon Scratchpad?
not testable.

Add you Amazon MWS Request
What Response are you receiving?
nothing

I found a way.
First of all the host must be setted, and currently documentation does not provide any details about amazonMws.setHost() call
There is no information about setContentType() also ...
There are a lot of set[thing]() method, but there is no setSocket() function, I would like to use amazonMws.setSocket(http), or amazonMws.setSocket(httpmock), and provide some mock for testing. I found something good in this code, but unit tests are not real unit test, the .spec.js test everything from request to the end of handling of response, that is generally called functional tests.
To split those parts the code should be splitted from AmazonMwsResource.js, and really that source file is too much big.
@bhushankumarl , You ask to contributor to run all tests before making a pull request, but the tests must be ran against a real alive amazon api, and this is a real problem if you want the tests to be automatic (you should inject SellerId, auth key, private key, ... and where does the automatic test get this data?)
Tests must be automatic, so tests as of now are not usable.
There are a number of option to mock http, like nock, https://github.com/nock/nock, I do not know it, but maybe there are other things that could be used.
OK. I Stop here the code review. I come back to "how to submit document":
        let host = hostbycountry(PlatformCountry);
        amazonMws.setHost(host);
        amazonMws.setContentType('application/octet-stream');
        const mwsRequestData = {
            Version: '2009-01-01',
            Action: 'SubmitFeed',
            FeedType: '_UPLOAD_VAT_INVOICE_',
            PurgeAndReplace: 'false',
            FeedContent: docData,
            SellerId: 'merchantid',
            MWSAuthToken: 'mws_auth_token',
            'MarketplaceIdList.Id.1': 'marketplaceid',
            FeedOptions: 'metadata:orderid=....'
        };
        return amazonMws.feeds.submit(mwsRequestData)

Something to note:

SellerId and Merchant are synonyms.
PurgeAndReplace is a string
FeedOptions is a string in the format specified in https://m.media-amazon.com/images/G/03/B2B/invoice-uploader-developer-documentation.pdf
hostbycountry() here is a function that return the host as listed in https://docs.developer.amazonservices.com/en_US/dev_guide/DG_Endpoints.html , by the country code of the merchant (the sellerId), not the marketplace! this means that the SellerId and AuthToken is paired with the platform, even if the merchant is selling in another country, but MarketplaceIdList.Id.1 is the marketplace where the order is placed (where the good was sold).
amazonMws.setContentType('application/octet-stream'), because it is not an 'x-www-form-urlencoded', it is an upload instead, this should be automatic, maybe, but I solved it without touching the code


(Android) Enhanced camera/audio and geolocation permissions

Summary
Issue tackled: Currently, Android permissions have to be requested before the instantiation of the webview. In this new implementation, Android permissions are requested "on the fly" when the webview needs it. It is, in some ways, a mapping of the webview permissions to the native Android permissions.
Test Plan
What's required for testing (prerequisites)?
A react native webview with following code:
navigator.getUserMedia({ video: true, audio: true }, () => { console.log('video/audio success') }, console.error);
navigator.geolocation.getCurrentPosition(console.log, console.error);

And in the AndroidManifest.xml:
<uses-permission android:name="android.permission.ACCESS_FINE_LOCATION" />
<uses-permission android:name="android.permission.CAMERA" />
<uses-permission android:name="android.permission.RECORD_AUDIO" />
<uses-permission android:name="android.permission.MODIFY_AUDIO_SETTINGS"/>

What are the steps to reproduce (after prerequisites)?
To test, accept or refuse the following permissions: geolocation, audio, video.
Compatibility

OS
Implemented

iOS
❌

Android
✅

Checklist

[x] I have tested this on a device and a simulator
[ ] I added the documentation in README.md
[ ] I mentioned this change in CHANGELOG.md
[ ] I updated the typed files (TS and Flow)
[ ] I added a sample use of the API in the example project (example/App.js)

Do you need more info? @jamonholmgren @Titozzz

This looks good to me. @safaiyeh ?

@ThibaudM
Do we need to update the documentation before releasing this? I feel like this should be documented.
https://github.com/react-native-community/react-native-webview/blob/89886c820d4812e8806ac5801660aff317b8f5b2/docs/Guide.md#camera-option-availability-in-uploading-for-android
(Ignore the Windows CI failures)

@ThibaudM
Do we need to update the documentation before releasing this? I feel like this should be documented.
https://github.com/react-native-community/react-native-webview/blob/89886c820d4812e8806ac5801660aff317b8f5b2/docs/Guide.md#camera-option-availability-in-uploading-for-android
(Ignore the Windows CI failures)

I just tested this part and it seems that image/video upload is not impacted by this PR.

Tested here, works great for audio recording (without this PR, navigator.mediaDevices.getUserMedia() throw a "Permission denied" error, it request the permission with this patch).
Updated patch here, with conflicts resolved: https://gist.github.com/TPXP/5ec918850dd40bd46203c41e98e61003

@ThibaudM I meant the documentation, does anything need to be update there?

I think not. Adding the permissions in Manifest.xml seems too obvious to be added in the doc.

Can I do something? The PR seems to be approved but not yet merged.

Hello, this PR trigger permissions at the good time for my current project. Can we merge this ?
I have to use patch-package for now.

The last commit is to fix the "always ask permission" for geolocation: https://stackoverflow.com/questions/10305145/webchromeclient-ongeolocationpermissionsshowprompt-never-called-if-locations-a/63519151#63519151

...

👋🏻  hello there I'm back to give some love to pull requests, I'll look at that asap

👋🏻  hello there I'm back to give some love to pull requests, I'll look at that asap

I've successfully tested the camera permission on a Samsung S10 with Android 11. Anything else I could do to help?

I squashed my commits and adapted the message in order to be merged.
@Titozzz Any news from your side? or an estimated time to review this work?

Hello 👋, this PR has been opened for more than 2 months with no activity on it. If you think this is a mistake please comment and ping a maintainer to get this merged ASAP! Thanks for contributing! You have 7 days until this gets closed automatically

@Titozzz

There is some conflicts with the DRM feature added in a recent PR ... 😭

I have updated the PR, can you try if the DRM part is broken?

We've been using this code in production for a while. What's keeping react-native-webview from merging this?

Awesome @ThibaudM, "merci pour la patience ❤ "

@Titozzz Since onPermissionRequest is defined twice in RNCWebViewManager, this merging does not work.
onPermissionRequest #1
onPermissionRequest #2
Before publishing, it seems necessary to check if the build is working properly.

I have updated the PR, can you try if the DRM part is broken?

It seems the last merge with DRM failed and duplicated onPermissionRequest.
I am working on the fix.
Anyway, why did the CI not fail on the build?


limited retryCommit/retryRollback in TCC/AT/SAGA mode

Why you need it?
Is your feature request related to a problem? Please describe in details
经过实际测试和源码阅读，都没有发现TCC的commit重试会因为某个参数（次数、超时）而停止，也就是分支事务不会进入PhaseTwo_CommitFailed_Unretryable状态，全局事务不会进入CommitFailed状态。而是会无限重试。
How it could be?
A clear and concise description of what you want to happen. You can explain more about input of the feature, and output of it.
希望有配置可以对重试的次数进行约束。
Other related information
Add any other context or screenshots about the feature request here.

sorry 我找到了，是有的，MAX_COMMIT_RETRY_TIMEOUT，只不过默认是-1 所以一直重试。


Values in library subcharts are ignored

Output of helm version:
version.BuildInfo{Version:"v3.8.2", GitCommit:"6e3701edea09e5d55a8ca2aae03a68917630e91b", GitTreeState:"clean", GoVersion:"go1.17.5"}

Output of kubectl version:
Client Version: version.Info{Major:"1", Minor:"23", GitVersion:"v1.23.1", GitCommit:"86ec240af8cbd1b60bcc4c03c20da9b98005b92e", GitTreeState:"clean", BuildDate:"2021-12-16T11:41:01Z", GoVersion:"go1.17.5", Compiler:"gc", Platform:"linux/amd64"}
Server Version: version.Info{Major:"1", Minor:"22", GitVersion:"v1.22.7+k3s1", GitCommit:"8432d7f239676dfe8f748c0c2a3fabf8cf40a826", GitTreeState:"clean", BuildDate:"2022-02-24T23:03:47Z", GoVersion:"go1.16.10", Compiler:"gc", Platform:"linux/amd64"}

Cloud Provider/Platform (AKS, GKE, Minikube etc.): N/A
Description
Starting from helm v3.8.2 a NBC change has been included, changing the precedence of imported values from library charts via imported-values in Chart.yaml. The following commit introduced that change: https://github.com/helm/helm/commit/5d017e11f1f47345a3559bf70f63d81a7edc981a.
An illustration for this behavior change can be seen in the following repository https://github.com/albgp22/helm-values-issue but can be stated simply as follows: when we import a value from a given library via imported-values in Chart.yaml file in our application chart, the value gets ignored if it is already present in the values.yaml file.
As this precedence change potentially breaks compatibility of existing charts with newer helm versions, I wonder if it will be reverted in future helm versions. As I see it, imported values from libraries overriding the ones in the application values.yaml file was the expected and logical behavior.

We are facing the issue. Is there any update on this bug?
The current behavior conflict with the documented behavior - https://helm.sh/docs/topics/charts/#importing-child-values-via-dependencies

@albgp22 any reason why you closed #10940?

Hi @bacongobbler. It did address this issue, but then I saw that this fix would introduce the bug reported in #9940 again. I will try to come up with a solution as soon as I have time, but in the meantime any help from helm contributors is really appreciated.

We had the same suprise as well regarding the change. Would be great to hear from the maintainers if as you @albgp22  stated: "Imported values from libraries overriding the ones in the application values.yaml file was the expected and logical behavior." In any case this should not be changed in a patch version.

@mattfarina what is your opinion on this?

We are actually enjoying that https://github.com/helm/helm/issues/9940 is finally fixed. When considering a fix, please ensure that this does not return.

Any updates on this? This change broke the deployment of our charts so we cannot upgrade to the latest helm. As previously mentioned, it would be best to revert the behavior to prevent breakages and then maybe look into introducing a new feature that behaves like https://github.com/helm/helm/issues/9940.
A bit more context about my use case, I'm importing values conditionally into the parent chart when a certain feature is enabled, the parent chart (and other subcharts) contain the defaults which can no longer be overridden using imports.

There are so many cases in which a strange/odd behavior has not been considered a bug as if doing like that the new Helm release would introduce a non-backward compatible change (so breaking those deployment workflows expecting the current behavior) and so, in those cases, it was proposed to solve it as a new feature (e.g. proposing to add some new input param to the helm command in order to get the new desired behavior without breaking compatibility).
I think not following this approach for #9440  was a mistake and so it would be good to solve it in a coming release, doing as @Cybermaxke  comments above (i.e., to get the behavior implemented by #9440 as a new feature to be triggered by some additional input param passed to the helm install/upgrade command and/or additional Chart.yaml field asking for it).

It looks PR #11162 is waiting for being accepted/merged to "main" for some long time.
Is there anything preventing it to happen?
We are not able to upgrade Helm from 3.8.1 to any newer release due to the NBC introduced by 3.8.2 on imported-values behavior; it looks we are not the only ones "suffering" this problem.
Asking in order to understand if not accepting (yet) that PR #11162 is only because Helm guys allowed to accept it are overloaded ... or is it because they see some "issues/problems" on accepting this PR (?).
Thanks in advance.

Responded in the PR.
PS. I'm not a core maintainer, I just help with issues.

@bacongobbler , @mattfarina could you comment?
I think we should revert the non-backward-compatible change introduced in Helm behavior from 3.8.2 onwards (because of the merged PR closing #9940) as soon as possible.
The proposed PR #1162 for that is still providing a solution for the people asking for a different behavior, so when this PR being merged we will

get again the previous behavior (so solving the NBC introduced from 3.8.2)
giving a solution (based on a new helm input param) for the people asking for a new behavior

We (and some others) are blocking the upgrade (in our deployment pipelines) to newer Helm versions because of this introduced NBC from 3.8.2

Anything specific that needs to be done to get https://github.com/helm/helm/pull/11162 in? At this point it's probably already too late to revert back to the old behavior.

we are still stuck with Helm 3.8.1. would be nice to have https://github.com/helm/helm/pull/11162 merged in 3.12

@gusyag we changed all our charts to the new behavior. It's kind of sad how this was done in a patch and then handled but the effort is not that huge depending on what you have and Helm 3.11.3 is latest by now.

Sadly enough, in our case it's not that easy to change to the latest version because of this, and would require some big workarounds.
I don't think that the new default behavior should be changed at this point, because that would break charts that already depend on this change, but I would like to see the import strategy being added. And that these changes are properly reflected in the documentation, because they are still not up-to-date.
Some input from the devs about this would be appreciated, because I don't know how to proceed at this point.

Note, I have been working on this. I just tested my fix against the chart from the initial description and the bug is fixed. Note, there are tests in the coming PR for this case so a change should be caught in the future.

Hope this fixes soon via either PR. Just wanted to clarify something: there are things which cannot be done at all if the old behavior is changed (Although, those are themselves workarounds for other limitations of Helm), because you'll lose the possibility of overriding some existing values based on a condition/tag.
Thanks!

Note, I have been working on this. I just tested my fix against the chart from the initial description and the bug is fixed. Note, there are tests in the coming PR for this case so a change should be caught in the future.

can we combine this with https://github.com/helm/helm/pull/11162?

Hi Guys is it really solved? I Observe the same behaviour as stated here in v3.12.3:
version.BuildInfo{Version:"v3.12.3", GitCommit:"3a31588ad33fe3b89af5a2a54ee1d25bfe6eaa5e", GitTreeState:"clean", GoVersion:"go1.20.7"}

@rtarasov Yes, we have tried it out using helm canary releases and it works :). We are eager to have it in helm 3.13!
Thanks @mattfarina

@rvilleng Thank you for the info! Do you plan to have 3.13.0 on time i.e. 13.09.2023 or you will postpone? as completeness is 37% for now.
Thank you in advance!

This issue is back, was fixed https://github.com/helm/helm/pull/12162, but then this issue was returned in https://github.com/helm/helm/pull/12162 to fix https://github.com/helm/helm/issues/12460

That's ridiculous! Helm 3.12 (and IIRC helm from 3.9 to 3.12) were the ones that were incompatible with older Helm versions.


unable to clone jimmdd/node-oracle-layers-serverless's contents

We're sorry, something went wrong.
We were unable to clone jimmdd/node-oracle-layers-serverless's contents into hosamshahin/node-oracle-layers-serverless. The template you used includes files that are larger than 10 megabytes. Please ask jimmdd to remove those files from the template and try again.

Hi, I wasn't aware that GitHub has this size limit on template. Please clone or download it directly.  it's required to have the compiled oracle driver in the repo which is the large files that cause the issue. I'll remove the template option on this repo. Thanks for reporting the problem.


1st entry may not have a space in the name

Bootloader crashes while booting it if so. Extras > Normal boot works.


Slider movement in RTL

Home and End keys should move slider to End and Home respectively in RTL
EXamples: http://keith-wood.name/rtlSliders.html

This is supported already.


Module 3 exercises [Silas Achidago]

Please "drag & drop" exercise 3 file below.

WS2_M3E1_SilasAchidago.docx
2. Please UPDATE THE TITLE of this "Issue" in the title bar above with your name.

If you haven't done so, please go back to Module 3 and make sure to take
the post-training survey.

Well done, Silas. You clearly grasped the material outlined in Module 3 and successfully applied it to these exercises. Thank you for your participation! Please be sure to fill out the post-Module survey before you begin the next Module.


Verify Liquidity Mining history is working

Once #1120 has been deployed to testnet, verify this issue is resolved:
https://github.com/DistributedCollective/Sovryn-frontend/issues/994

Confirmed working on latest version


Helpful error message in P12 factory in absence of pyOpenSSL.

Fixes #417.
@nathanielmanistaatgoogle I'm not sure why this didn't make it in the re-write. I definitely had tests for this and an if crypt.Signer check.
Sorry @ddoskind that I absent-mindedly let it slip in #398 (it was in #392 but I dropped the _get_signer helper since only the factories need to make a signer now rather than the constructor back then)

Looks good; merge when you please.

Hi,
this seems to have introduced a bug. You can no longer use any other signer as the OpenSSL one.
This seems strange, is that intended behavior?
Cheers,
Joe

The rsa library (and the ASN.1 helpers) were never able to parse P12 keys, but they work just fine with JSON keys.

Did you actually have them working with P12?
Do you have a need for P12 keys instead of JSON?

I use Django on Heroku. On Heroku you can't store files except in your repository. Adding a private key to the repository is not the best idea I guess ;)
That's why I added it to the environment.
I wrote that little bit of code that worked for me until this change:
def build_googleapiclient(service_email=None, private_key=None,
                          user_email=None):
    service_email = service_email or settings.GOOGLE_DRIVE_STORAGE_SERVICE_EMAIL
    key = private_key or settings.GOOGLE_DRIVE_STORAGE_KEY

    credentials = ServiceAccountCredentials._from_p12_keyfile_contents(
        service_email,
        key,
        scopes="https://www.googleapis.com/auth/drive",
    )
    credentials = credentials.create_delegated(user_email)
    http = httplib2.Http()
    http = credentials.authorize(http)

    return build('drive', 'v2', http=http)

I know it's not nice to use a private API and than complain, but hey ;)
Since my private key start with -----BEGIN RSA PRIVATE KEY----- I naturally assumed it's an RSA key and not P12.

-----BEGIN RSA PRIVATE KEY----- is not a P12 key, it is likely a PCKS#1 key in PEM format (and if it's from Google you probably got it by converting a P12 key to it).
rsa and crypt.RsaSigner are just libraries, they don't (necessarily) relate to the key type. Any of the three possible signers will work with that key.
I'd first and foremost just recommend getting a JSON key file from Google, since it's unclear where you got the PKCS#1 key from. (A JSON keyfile is a JSON-ified dict, with a field that holds a PKCS#8 key in PEM format.)
If you want to proceed "as-is" by just constructing any old signer:
signer = crypt.Signer.from_string(settings.GOOGLE_DRIVE_STORAGE_KEY)
creds = ServiceAccountCredentials(
    settings.GOOGLE_DRIVE_STORAGE_SERVICE_EMAIL, signer,
    scopes='https://www.googleapis.com/auth/drive',
    sub=user_email)
# OPTIONAL HACKY SNIPPET FOR SERIALIZATION
creds._private_key_pkcs8_pem = settings.GOOGLE_DRIVE_STORAGE_KEY
# DEFINITELY A LIE SINCE YOUR STORAGE KEY IS PKCS#1, NOT PKCS#8

Can you give an idea / snippet of what you were doing before (with SignedJwtAssertionCredentials, before the 2.0.0 release)?

@dhermes: sure, reversion says we used this one :)
Is the JSON key file available now for server2server communication? We needed a user that can modify out Drive regardless of the current user.
def build_googleapiclient(service_email=None, private_key=None,
                          user_email=None):
    service_email = service_email or settings.GOOGLE_DRIVE_STORAGE_SERVICE_EMAIL
    key = private_key or settings.GOOGLE_DRIVE_STORAGE_KEY

    kwargs = {}
    if user_email:
        kwargs['sub'] = user_email
    credentials = SignedJwtAssertionCredentials(
        service_email,
        key,
        scope="https://www.googleapis.com/auth/drive",
        **kwargs
    )
    http = httplib2.Http()
    http = credentials.authorize(http)

    return build('drive', 'v2', http=http)

The key you have is fine. Yes a JSON keyfile is  a keyfile for a Google service account.
The snippets I mentioned above will work for you (I'm 99.9% sure your PKCS#1 key is just converted from an original P12 key downloaded from Google).

@dhermes thanks! I just saw that you can now create json files for service accounts. I just created new creds for the account in json:
def build_googleapiclient(user_email=None):
    key = json.loads(settings.GOOGLE_DRIVE_STORAGE_KEYP)

    credentials = ServiceAccountCredentials._from_parsed_json_keyfile(
        key,
        scopes="https://www.googleapis.com/auth/drive",
    )
    if user_email is not None:
        credentials = credentials.create_delegated(user_email)
    http = httplib2.Http()
    http = credentials.authorize(http)

    return build('drive', 'v2', http=http)

This works fine for me. Forget the rest ;)

Good deal! I strongly encourage you just use
ServiceAccountCredentials.from_json_keyfile_name(
    settings.GOOGLE_DRIVE_STORAGE_KEYP,
    scopes='https://www.googleapis.com/auth/drive')

instead of using a non-public interface.

@dhermes that is a nice Idea, but again, I can't store files on Heroku that are not in the git repository.
You're not encouraging me to put a PK in my repo are ;)

Sorry I misread the json.loads as json.load. I wasn't thinking about your environment.
Still, you don't need the non-public method. Use http://oauth2client.readthedocs.org/en/latest/source/oauth2client.service_account.html#oauth2client.service_account.ServiceAccountCredentials.from_json_keyfile_dict

Good point, thx!


Beam NameError in weather-dl: save_main_session not applied

When running the weather downloader as usual on the main branch:
weather-dl ./configs/era5_example_config_local_run.cfg --local-run

The following error occurs:
...
File "/Users/alxrsngrtn/homebrew/Caskroom/miniconda/base/lib/python3.8/site-packages/future/utils/__init__.py", line 446, in raise_with_traceback
    raise exc.with_traceback(traceback)
  File "apache_beam/runners/common.py", line 1213, in apache_beam.runners.common.DoFnRunner.process
  File "apache_beam/runners/common.py", line 570, in apache_beam.runners.common.SimpleInvoker.invoke_process
  File "/Users/alxrsngrtn/homebrew/Caskroom/miniconda/base/lib/python3.8/site-packages/apache_beam/transforms/core.py", line 1544, in <lambda>
    wrapper = lambda x: [fn(x)]
  File "/Users/alxrsngrtn/homebrew/Caskroom/miniconda/base/lib/python3.8/site-packages/apache_beam/transforms/core.py", line 2385, in <lambda>
    return pcoll | Map(lambda x: (self._key_func()(x), x)) | GroupByKey()
  File "/Users/alxrsngrtn/Github/weather-tools/weather_dl/download_pipeline/pipeline.py", line 86, in subsection_and_request
    subsection = t.cast(str, it.get('parameters', {}).get('__subsection__', 'default'))
NameError: name 't' is not defined [while running 'GroupBy request limits/Map(<lambda at core.py:2385>)'

Troubleshooting this bug is documented here: https://cloud.google.com/dataflow/docs/resources/faq#how_do_i_handle_nameerrors
PR #120 attempted to fix this; however, the error seems to have persisted.

I've tested the fix in #124 both on a local and remote run. It seems to have fixed the issue.


RFC: Split out bindings into un-opinionated core

This library does two distinct things:

Provides bindings to Semantic UI JS API
Provides a very specific type-driven API for interacting with Semantic UI's styles and JS

I'd like to propose that these be split into two libraries. I found the API for styles is abstracting along the wrong axis for my use case so I don't use them (e.g. styles and colors are implementations of larger goals that often change depending on the application, so the abstractions will need to be per-app to make the most sense). However, the bindings are still useful, but many of them don't work well.
I pulled much of the binding out to here: https://github.com/3noch/reflex-dom-semantic-ui-core

This sounds like a reasonable idea to me.  Any ideas on repo names, etc?  I'm thinking we should leave this library as-is for people who are using it and set up the other two independently as you're describing.


configure predictable providers' SA for crossplane providers

Currently, when we install a provider like upbound-provider-aws, this creates Deployment and Pods that use a 'randomized' ServiceAccount name, like
k -n crossplane get po upbound-provider-aws-30b1a6158012-5c5f56d67f-vrjnw -o jsonpath={.spec.serviceAccount}
upbound-provider-aws-30b1a6158012

This creates a problem, as for IRSA config the SA has to be known and configured on AWS IAM side, so it can't change. We have to make providers use predictable names for SA. We should be able to do that using ControllerConfig's ServiceAccount property.

done


Crash on Ruff config

I have a pyproject.toml file which had one arguably out of order block:
[tool.ruff.isort]
known-first-party = ["myapp"]

[tool.ruff]
line-length = 88
target-version = "py310"

select = [
    "A", # flake8-builtins
    "B", # flake8-bugbear
    "C4", # flake8-comprehensions
    "E",
    "ERA", # flake8-eradicate
    "EXE", # flake8-executable
    "F",
    "G", # flake8-logging-format
    "I", # isort
    "PIE", # flake8-pie
    "RUF", # Ruff
    "TRY", # tryceratops
    "UP", # pyupgrade
    "W",
]

ignore = [
    "TRY003",
    "RUF001", # See https://github.com/charliermarsh/ruff/issues/3947
]

This caused pyproject-fmt 0.10.0 to crash:
Traceback (most recent call last):
  File "/Users/cadams/.local/bin/pyproject-fmt", line 8, in <module>
    sys.exit(run())
             ^^^^^
  File "/Users/cadams/.local/pipx/venvs/pyproject-fmt/lib/python3.11/site-packages/pyproject_fmt/__main__.py", line 55, in run
    results = [_handle_one(config, opts) for config in opts.configs]
              ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/Users/cadams/.local/pipx/venvs/pyproject-fmt/lib/python3.11/site-packages/pyproject_fmt/__main__.py", line 55, in <listcomp>
    results = [_handle_one(config, opts) for config in opts.configs]
               ^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/Users/cadams/.local/pipx/venvs/pyproject-fmt/lib/python3.11/site-packages/pyproject_fmt/__main__.py", line 28, in _handle_one
    formatted = format_pyproject(config)
                ^^^^^^^^^^^^^^^^^^^^^^^^
  File "/Users/cadams/.local/pipx/venvs/pyproject-fmt/lib/python3.11/site-packages/pyproject_fmt/formatter/__init__.py", line 26, in format_pyproject
    _perform(parsed, conf)
  File "/Users/cadams/.local/pipx/venvs/pyproject-fmt/lib/python3.11/site-packages/pyproject_fmt/formatter/__init__.py", line 15, in _perform
    fmt_tools(parsed, conf)
  File "/Users/cadams/.local/pipx/venvs/pyproject-fmt/lib/python3.11/site-packages/pyproject_fmt/formatter/tools.py", line 18, in fmt_tools
    ensure_newline_at_end(cast(Table, table))
  File "/Users/cadams/.local/pipx/venvs/pyproject-fmt/lib/python3.11/site-packages/pyproject_fmt/formatter/util.py", line 139, in ensure_newline_at_end
    insert_body = content.value.body
                  ^^^^^^^^^^^^^^^^^^
AttributeError: 'dict' object has no attribute 'body'

(at that point content.value is the ruff tool block)
If I move the tool.ruff.isort section below tool.ruff, it runs successfully.

PR welcome 👍

Please check with https://github.com/tox-dev/pyproject-fmt/releases/tag/2.0.0 and report if still a problem.


KAFKA-13709: Add docs for exactly-once support in Connect

Jira
Adds administrator- and developer-facing documentation on the features introduced in KIP-618.
Rebased on top of https://github.com/apache/kafka/pull/12938 to fix recently-introduced compilation failures on trunk.

@joel-hamill would you be interested in taking a look at this?

@joel-hamill would you be interested in taking a look at this?

Hi @C0urante :) I spoke with @joel-hamill. I can take a look if you like. 👍

That'd be great! Thanks @tikimims

Hi @C0urante I took a first pass. :) Let me know if you'd like me to take another pass after any updates. 👍

Thanks @tikimims! I've accepted all but one of the suggestions and asked for clarification on the other. I didn't realize how common usage of "you" and "your" in the docs were; switching to that wording really helps tidy things up!

Hi @mimaison @tombentley would either of you have time to take a look at this?


Run extractPacks all

Let's sit on doing this next time until there's a more substantial reformatting.

Let's sit on doing this next time until there's a more substantial reformatting.

Sounds reasonable. Is the prototypeToken anything to worry about?

No


WebView will not start render if the page/tab it is on is not the active tab of a bottomTabNavigator

Bug description:
The WebView does not launch until the page it is rendered on is "active".
For example:
I use react-navigation to create a bottomTabNavigator. When I set lazy to false, it renders all tabs, both the one currently focused, and all the other tabs in the background.
On some of these pages, I render a WebView. However, despite the components still loading and rendering the background, the WebView does not launch (onLoadStart doesn't even start) until I navigate to the page it is contained on.
To Reproduce:
From a StackOverflow with the same issue:
Tab

const Tab = () => {
    console.log('render') // this is being called right away

    return (<WebView
             onLoadStart={() => console.log('on load start') // this is being called only when tab becomes active (clicking on it) }
             source={{uri:'linkgoes.here'}} />)
}

  const TabNavigator = createBottomTabNavigator(
  {
    TabOne: {
      screen: Tab
    },
    TabTwo: {
      screen: Tab
    }
  },
  {
    initialRouteName: 'TabOne',
    lazy: false,
  }
)

You will see that the WebView does not start until the page gains focus.
Expected behavior:
The WebVIew renders in the background, and should be loaded by the time I actually navigate to the page.
Environment:

OS: iOS
OS version: iOS 13.1
react-native version: https://github.com/expo/react-native/archive/sdk-35.0.0.tar.gz
react-native-webview version: 7.0.5

Other notes
Looks like it's a bug where it returns early if no window is present
This SO user had a similar experience: https://stackoverflow.com/questions/56923273/react-native-webview-only-starts-loading-when-on-active-tab-in-react-navigation
There is PR out to solve the issue, but it looks like it comes with a bunch of bad side effects: https://github.com/react-native-community/react-native-webview/pull/813

Any updates or possible workarounds for this issue?

Please fix it! Our users have bad experience because of this!

Did we find the solution or any patch
?


mkdir failures in nipype nodes

What happened?
Getting some odd failures in nipype nodes. I'm running a dataset with only func and T1w outputs, and it's complaining about difficulty in MNI-specific workflows. We may be making connections we shouldn't be.
Noting it here. Unclear if it will prevent otherwise successful runs, or whether it occurs when template spaces are specified. Will debug as time permits.
What command did you use?
$ fmriprep-docker sourcedata/raw . participant \
  -u $UID --output-space func T1w -w /data/scratch/multirun \
  --skip-bids-validation --nprocs 10 --use-syn-sdc
RUNNING: docker run --rm -e DOCKER_VERSION_8395080871=20.10.18 -it -u 1000 -v /home/chris/Documents/freesurfer_license.txt:/opt/freesurfer/license.txt:ro -v /data/tests/multirun/sourcedata/raw:/data:ro -v /data/tests/multirun:/out -v /data/scratch/multirun:/scratch nipreps/fmriprep:22.0.2 /data /out participant --skip-bids-validation --nprocs 10 --use-syn-sdc -w /scratch --output-spaces func T1w

What version of fMRIPrep are you running?
22.0.2
How are you running fMRIPrep?
Docker
Is your data BIDS valid?
Yes
Are you reusing any previously computed results?
No
Please copy and paste any relevant log output.
221007-17:21:26,647 nipype.workflow ERROR:
         Node split_target.a0 failed to run on host b91f075cc9d9.
221007-17:21:26,655 nipype.workflow ERROR:
         Saving crash info to /out/sub-EB/log/20221007-172015_d96db50c-5152-4dcc-a480-649bdbd5d241/crash-20221007-172126-fmriprep-split_target.a0-3ba7bfcb-1cf5-4a9b-847d-2f12855e2057.txt
Traceback (most recent call last):
  File "/opt/conda/lib/python3.9/site-packages/nipype/pipeline/plugins/multiproc.py", line 344, in _send_procs_to_workers
    self.procs[jobid].run(updatehash=updatehash)
  File "/opt/conda/lib/python3.9/site-packages/nipype/pipeline/engine/nodes.py", line 518, in run
    os.makedirs(outdir, exist_ok=True)
  File "/opt/conda/lib/python3.9/os.py", line 215, in makedirs
    makedirs(head, exist_ok=exist_ok)
  File "/opt/conda/lib/python3.9/os.py", line 225, in makedirs
    mkdir(name, mode)
OSError: [Errno 22] Invalid argument: '/scratch/fmriprep_22_0_wf/single_subject_EB_wf/func_preproc_ses_x20220401_task_resting4_wf/bold_std_trans_wf/_std_target_MNI152NLin2009cAsym.'

When creating this crashfile, the results file corresponding
to the node could not be found.
221007-17:21:26,780 nipype.workflow ERROR:
         Node select_tpl.a0 failed to run on host b91f075cc9d9.
221007-17:21:26,787 nipype.workflow ERROR:
         Saving crash info to /out/sub-EB/log/20221007-172015_d96db50c-5152-4dcc-a480-649bdbd5d241/crash-20221007-172126-fmriprep-select_tpl.a0-829bc14e-aafc-468f-80db-84bf6b674095.txt
Traceback (most recent call last):
  File "/opt/conda/lib/python3.9/site-packages/nipype/pipeline/plugins/multiproc.py", line 344, in _send_procs_to_workers
    self.procs[jobid].run(updatehash=updatehash)
  File "/opt/conda/lib/python3.9/site-packages/nipype/pipeline/engine/nodes.py", line 518, in run
    os.makedirs(outdir, exist_ok=True)
  File "/opt/conda/lib/python3.9/os.py", line 215, in makedirs
    makedirs(head, exist_ok=exist_ok)
  File "/opt/conda/lib/python3.9/os.py", line 225, in makedirs
    mkdir(name, mode)
OSError: [Errno 22] Invalid argument: '/scratch/fmriprep_22_0_wf/single_subject_EB_wf/func_preproc_ses_x20220401_task_resting4_wf/bold_std_trans_wf/_std_target_MNI152NLin2009cAsym.'

When creating this crashfile, the results file corresponding
to the node could not be found.

Additional information / screenshots
No response

I believe this is related to using --use-syn-sdc without --output-space MNI152NLin2009cAsym.

TODO: Verify that running --use-syn-sdc without --output-space MNI152NLin2009cAsym and without fieldmaps runs cleanly.

I can no longer reproduce this error.


rename 'autosomal dominant polycystic liver disease'

The  Kidney Disease CDWG noticed the nomenclature and ontology of kidney diseases needs systemic review. There are many kidney groups involved in doing this and hopefully being part of ClinGen will spur them on!
Our Cystic and Ciliopathy GCEP started with some genes involved in cystic liver disease and immediately ran into issues with finding the most appropriate MONDO term for the following genes:
SEC61B MONDO:0008265 (isolated polycystic liver disease); Preferred term = Autosomal dominant polycystic liver disease (ADPLD)
ALG8     MONDO:0008265 (isolated polycystic liver disease); Preferred term = Autosomal dominant polycystic liver disease (ADPLD)
PRKCSH MONDO:0008265 (isolated polycystic liver disease); Preferred term = Autosomal dominant polycystic liver disease (ADPLD)
SEC63    MONDO:0008265 (isolated polycystic liver disease); Preferred term = Autosomal dominant polycystic liver disease (ADPLD)
The Kidney Disease CDWG has a gene list of >700 genes.

Note - on 06/12/20
renamed MONDO:0008265 isolated polycystic liver disease to Polycystic liver disease 1 and renamed the parent/grouping term MONDO_0000447 to 'autosomal dominant polycystic liver disease' (with the synonym ADPLD).


Adding auth tests for all operations

Currently, we only have a set of basic tests that cover authentication (pub/sub)
It would be good to add more test coverage of MewbaseAuthProvider, namely for all operations and not just the pub/sub scenario

Security is now in the domain of ...
The web server providing the REST Adapter
The security protocol of the EventSource and EventSink implementations


Add a "default" option

Needs a default option, that simply clears all custom CSS.

Thanks for the suggestion, I've updated the JSON file, a default option should now be available in the plugin. There's no need to update


Command installer

Make a command installable.

Convert typescript files to javascript and move them to the dist folder


Roll engine 5f61056946ef..9b297b3b5122 (6 commits)

https://github.com/flutter/engine/compare/5f61056946ef...9b297b3b5122
git log 5f61056946ef..9b297b3b5122 --no-merges --oneline
9b297b3b5 Roll src/third_party/skia a9564d6dae1c..106d04e907c1 (7 commits) (flutter/engine#6190)
e70d0e1b7 Always serialize fonts during skp capturing (flutter/engine#6160)
bd7593b2a [fuchsia] Plumb root_surface_transformation in scene_update_context (flutter/engine#6187)
30c8da8ab Pull $flutter_root:config into shell/engine/version:version (flutter/engine#6186)
a14686252 Roll src/third_party/skia 33d3d31a7e28..a9564d6dae1c (5 commits) (flutter/engine#6185)
058edef8f Fix LibTxt/minikin text shifiting when breaking into multiple runs (flutter/engine#6184)
The AutoRoll server is located here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

@rmistry @liyuqian : New roll has been created by https://autoroll.skia.org/r/flutter-engine-flutter-autoroll

Trybots failed. These were the failed builds: https://flutter-dashboard.appspot.com/build.html

Commit queue failed; closing this roll.


Metadata queries broken in Windows

Story details: https://app.clubhouse.io/cartoteam/story/69476
There are other ways of solving this. For a full discussion see https://stackoverflow.com/questions/1793261/how-to-join-components-of-a-path-when-you-are-constructing-a-url-in-python
but IMHO not worth the complexity, plus format is clear and kind of standard throughout the code.

Tests have failed, so we should review them before the release.


Corrected some colors

Pull Request Template

Please provide all of the details below. Pull requests missing any of the information below will be closed!
Providing the issue number/url helps us identify the problem being solved and keep the issues tab clean and tidy

Summarize what this PR fixes:-
Some colors on hover and focus states were not exactly according to Figma Designs
Fixes #751
Checklist
(Add an x between the brackets to check the items)

[x] I have summarize what this PR fixes above
[x] I have provided the issue ID/URL above
[x] I have not added Bootstrap or jQuery and used correct styling guide.
[x] This PR fixes only the issue mentioned above (create separate PRs for separate issues)
[x] I was the first one to claim the issue or I created the issue - I created the issue

These are not the correct colors. The ones that were there were right, I put them in global.css to be used.


Add AllocationHandler

We should think about adding support for an AllocationHandler in a similar fashion like we already have for the PermissionHandler.
My motiviation behind it is the following:
We could use such a AllocationHandler to redirect clients via a ALTERNATE-SERVER response to other TURN servers.
However, we should give some flexibility to the user when and which alternate servers are signaled to the client.
This allows the user to define its own schemes to detect an overloaded server, or cycle through different available alternate servers.

Seems like a useful thing to add. Can you be a bit more specific though? What's the API? Where would we call the allocation handler, inside server.CreateAllocation? What would our allocation handler receive as argument and what to return?

Where would we call the allocation handler, inside server.CreateAllocation?

This would be in internal/server.Server.handleAllocate().
Actually, the function already contains a comment:
https://github.com/pion/turn/blob/f880e55089ad0e0cdb53c5a0e6b89954512dada6/internal/server/turn.go#L112-L122

What would our allocation handler receive as argument and what to return?

Good question. What about the following (just a first proposal):
// AllocationHandler is a callback to ...
type AllocationHandler func(clientAddr net.Addr) (alternateServer *net.UDPAddr, stun.ErrorCode)

Do you also want to handle the allocation quota case (as per point 7 above) in the same AllocationHandler callback, or it is intended only for signaling the ALTERNATE-SERVER response?
Why I'm asking this is that every now and then our users complain about the lack of allocation quotas. So far, I failed to find sane API to support this: should we limit allocations per source IP? Or per TURN username/credential? Total allocations?
I guess coturn implements the first approach and the third one:
# consider whether you want to limit the quota of relayed streams per user (or total) to avoid risk of DoS.
user-quota=12 # 4 streams per video call, so 12 streams = 3 simultaneous relayed calls per user.
total-quota=1200

If we follow this course then I think your AllocationHandler API could also be used to support user quotas and total quotas. Wdyt?

Hi @rg0now,
yes this was my plan to also cover quotas with this handler. The whole logic about which quotas are enforced should be user customizable with the handler. We could event provide a few generic handlers for covering the easy cases like you mentioned.
It would also be nice to have the TURN credentials as an argument for the handler to cover per-user quotas.
Hence, we must probably include the TURN credentials as an argument.
I initially also thought about using the handler for implementing custom authentication logic. However we already have the AuthHandler for this..


String interpolation without args

Issue #1683

✅ No public API change.

Can you add a test for this scenario?

✅ No public API change.

✅ No public API change.


Question about the compressor library

Hi,
I have used and then studied in details how GPT_researcher works, and I am impressed about the great job ! The architecture et the sequencing are really smart. Congratulations, this is SMART !!!
Now, I want to use GPT Researcher to establish a very precise market study, and to do so, I intend to increase the number of subqueries, et the number or scrapped_content_results coming from the scrape_sites_by_query. I already made a few tests, it works fine, it costs more API money, but that is understandable when you seek for accuracy (and better quality). Yet, there are some generated context that I do not understand well, especially when it comes to the langchain compression library (I am not familiar with langchain, and even if I tried to read the lanchain.retrievers.document_compressors doc, I must admit that I did not understand anything more !!!). If I am not mistaken, this compressor implementation is not really RAG; it is close to it but scrapped websites are not actually stored into a vector database. And the generated context is not made out of a RAG questioning, but it is made thanks to a vectorization of the scrapped_websites, which is then questioned by the Search API Retriever (Tavily in my case), and Tavily is then creating the output. Is that right ?
Why did you choose to go for that direction ? I mean, I don't think the search API Retriever is not a good option (and it seems to work fine), but wouldn't it make sense to implement a real RAG architecture, which would enable us to enlarge the scope of scrapped websites, and get very precise context coming from each subqueries based on RAG ?
That is a simple questions. Maybe there are obvious answers, and sorry for asking then. Maybe the reason is that each "Reseach" is supposed to be made on totally different topics, and in that case, implementing RAG maye have been considered as pointless because it  is just a "one-time" use for the purpose of each research, and then it can be deleted.
Anyway, this compression thing seems for me to be the only concern in this whole project because it may reduce the accuracy of the final report in the end.
PS : having a vector DB could also be used at the same time to load proprietary document, as already mentioned here #379 .
Thanks in advance for your answers,

Hey @djuillard, thanks for bringing this up! Just to clarify, this IS a RAG architecture. And the compressor does use a vector DB logic. Basically we chunk all documents -> embed them -> retrieve only the relevant ones to the query. This is done to optimize for context with only the most relevant content. I do agree though that retrieval hit rate might be lower than simply passing most of the scraped content, and definitely requires more refinement. Happy to hear suggestions or PRs that can improve it! As for local documents, we're actually working on one here by the one and only @proy9714 : https://github.com/assafelovic/gpt-researcher/pull/429

Thanks for your answer and for the clarification. OK, I understand better. This IS RAG, with vector logics, but not based on vector db at this stage, because not immediately necessary.
I will check whether I can contribute, maybe while adding a vector DB like qdrant with asynchronous capabilities.


Enable setting various types of sourcemaps.

On certain platforms (for eg. Tizen TVs) we need the ability to enable a specific type of sourcemap (eval-source-map). True/false is too limiting.
I verified this minor change by running yarn build with different values for the GENERATE_SOURCEMAP environment variable then inspecting the resulting main..js under build/static/js/
Setting the env var to false preserves existing behavior. Setting it to other allowed sourcemap values correctly changes the resulting output JS bundle.

I realized, after testing again locally, that expanding the env variable only makes sense in the top level of the webpack config file. Prior I was attempting to use the expanded value everywhere not realizing the different loaders will not accept values other than true/false. This recent change actually does properly address the concern amnd maintains earlier behavior.

If you want to propose a configuration option you should create a backwards-compatible change. Introduce a new variable because you can't use existing one for this case.

We appreciate the pull request but do not plan on allowing this to be configurable. Please see my response in the issue you opened.


Improve handling AND argument in IndentNestedKeywords

Closes #319

Codecov Report

Merging #339 (c73e965) into main (003599d) will decrease coverage by 0.02%.
The diff coverage is 93.33%.

@@            Coverage Diff             @@
##             main     #339      +/-   ##
==========================================
- Coverage   97.17%   97.15%   -0.03%
==========================================
  Files          43       43
  Lines        3257     3267      +10
==========================================
+ Hits         3165     3174       +9
- Misses         92       93       +1

Impacted Files
Coverage Δ

robotidy/transformers/IndentNestedKeywords.py
97.14% <93.33%> (-0.55%)
:arrow_down:

robotidy/cli.py
98.19% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 003599d...c73e965. Read the comment docs.


fix: Fixes different form field background in forms

Description
Partially fixes Issue #7003
Type of change

Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?
Tested manually
Checklist:

[x] My code follows the style guidelines of this project
[x] I have performed a self-review of my own code
[ ] I have commented my code, particularly in hard-to-understand areas
[ ] I have made corresponding changes to the documentation
[x] My changes generate no new warnings
[ ] I have added tests that prove my fix is effective or that my feature works
[ ] New and existing unit tests pass locally with my changes

Test coverage results :test_tube:
:white_circle: Total coverage has not changed
// Code coverage diff between base branch:release and head branch: fix/7003-form-field

Status
File
% Stmts
% Branch
% Funcs
% Lines

:green_circle:
app/client/src/components/formControls/DynamicInputTextControl.tsx
95.45 (0.1)
71.43 (0)
83.33 (0)
95.35 (0.11)

/ok-to-test sha=51dcedc


ClientHelper.isServerContext returns false in singleplayer worlds

Version
Confirmed on 1.19.x/forge aece46ed, buildscript 1.19.x/forge e4f58032
Not yet confirmed on 1.20.x/forge, as this relates to an internal Minecraft change.
Problem
When in singleplayer, the RegistryAccess used by the internal server appears to be obtained from RegistryAccess.BUILTIN. The code in ClientHelper.isServerContext assumes that this is not the case, and thus always returns false. This can cause datapack reloads in singleplayer to unexpectedly fail as the server will attempt to send the client's registries to the client.
Potential Solutions
Aside from one instance in origins-architectury:PartialOrigin.Builder.powers, the access argument is always null. As such, it may be possible to remove the comparison to RegistryAccess.BUILTIN and just use the null check. This may have some regressions, and I suspect that a better solution exists.

Confirmed that this does not occur on 1.20.1. Seems this is limited to 1.19 (or even that specific version of Forge). Leaving this open for now in case you want to take another look at it anyway.


Dimensional error while running example_gymnast.py

While attempting to run example_gymnast.py. I encounter this error:
PyMuJoCoBase/PyMuJoCoBase/examples/example_gymnast.py", line 42, in controller
    J = data.efc_J[:3, :3]
IndexError: too many indices for array: array is 1-dimensional, but 2 were indexed

I attempted to debug, it seems data.efc_J is actually a 1D array - [ 1.  0. -0.  0.  0.  0.  0.  0.  0.  0.  0.  0.  0.  1.  0.  0.  0.  0.], aligning with the API reference here.

In this case, probably the API was updated too. Feel free to do a PR!

@BolunDai0216 made a PR (#3)


Rule proposal: indentation of closing jsx tag

Not to be confused with the closing bracket, I would like to enforce the location of a closing jsx tag when its children also live on a new line.
For example, the following would fail:
<MyComponent
  prop1="foo"
  prop2="bar">
  {content}</MyComponent>

The following would pass:
<MyComponent
  prop1="foo"
  prop2="bar">
  {content}
</MyComponent>

This would also pass:
<MyComponent prop1="foo">{content}</MyComponent>

This sounds great - essentially, "must be on the same line, or must be on its own line that matches the indentation of the opening tag"?
jsx-closing-tag-location, perhaps.

(Done in #1215)


Fix python versions for Travis build

 Ben broke the v3 travis build 🎉

Turns out this is due to flake8-tuple 0.3.1 having been deleted: https://github.com/ar4s/flake8_tuple/issues/24
Will address in a new branch


Implement Random for BigInt

Fixes #5647
cc @iSarCasm @jzakiya

Yeah this is ready, as long as there are no merge conflicts


[theme] Correct augmentColor TypeScript definition

[x] I have followed (at least) the PR section of the contributing guide.

Actually, shade parameters are useless with a SimplePaletteColorOption which does not include color variations… So I made an override, at last, as @eps1lon suggested. I also added Typescript tests.

I have another suggestion. As you defined the type PartialColor, and as it seems this partial color should at least have a [500] entry, shouldn't we write:
export type ColorPartial = Partial<Color> & {500: string};