Cannot build FSharp.sln from commandline with MSBuild

I'm having trouble building FSharp.sln using MSBuild on Windows. When I follow the instruction at DEVGUIDE.md I receive the following errors when using msbuild FSharp.sln
C:\Users\jovarty\Documents\GitHub\visualfsharp [master ≡]> msbuild .\FSharp.sln
Microsoft (R) Build Engine version 14.0.25420.1
Copyright (C) Microsoft Corporation. All rights reserved.

Building the projects in this solution one at a time. To enable parallel build, please add the "/m" switch.
Build started 12/6/2016 1:19:15 PM.

C:\Users\jovarty\Documents\GitHub\visualfsharp\FSharp.sln(248): Solution file error MSB5023: Error parsing the nested project section in solution file. A project with the GUID "{BF5C6
D92-D053-4216-9C42-B62F5F5C5E91}" is listed as being nested under project "{CFE3259A-2D30-4EB0-80D5-E8B5F3D01449}", but does not exist in the solution.

Build FAILED.

  C:\Users\jovarty\Documents\GitHub\visualfsharp\FSharp.sln(248): Solution file error MSB5023: Error parsing the nested project section in solution file. A project with the GUID "{BF5
C6D92-D053-4216-9C42-B62F5F5C5E91}" is listed as being nested under project "{CFE3259A-2D30-4EB0-80D5-E8B5F3D01449}", but does not exist in the solution.

    0 Warning(s)
    1 Error(s)

Please provide a succinct description of the issue.
Repro steps

Clone visualfsharp repo

Run build.cmd

Run msbuild FSharp.sln

Expected behavior
The solution and its projects compile properly.
Actual behavior
I receive the above errors regarding missing projects.

I performed a quick sanity check and confirmed I still see this issue when I use MSBuild v 15.1.371.0 (The version that ships with VS2017 RC)

Install:
Dev15 rc2
Select:
C++/Managed Languages and VSIX workloads
Open A VS 2017 Command Window as admin
Cd root of the repo
Build all
Should do it.
From: Josh Varty<EMAIL_ADDRESS>Sent: Tuesday, December 6, 2016 1:31 PM
To: Microsoft/visualfsharp<EMAIL_ADDRESS>Subject: [Microsoft/visualfsharp] Cannot build FSharp.sln from commandline with MSBuild (#1954)
I'm having trouble building FSharp.sln using MSBuild on Windows. When I follow the instruction at DEVGUIDE.mdhttps://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2FMicrosoft%2Fvisualfsharp%2Fblob%2Fmaster%2FDEVGUIDE.md%23f-compiler-windows&data=02|01|Kevin.Ransom%40microsoft.com|3918bdfd07a44087ee5908d41e1f2820|72f988bf86f141af91ab2d7cd011db47|1|0|636166566548067246&sdata=t6u4lTqrg0lPBTCyYf1mm0GQ77GGUHkuvRp17BOZqOQ%3D&reserved=0 I receive the following errors when using msbuild FSharp.sln
C:\Users\jovarty\Documents\GitHub\visualfsharp [master ≡]> msbuild .\FSharp.sln
Microsoft (R) Build Engine version 14.0.25420.1
Copyright (C) Microsoft Corporation. All rights reserved.
Building the projects in this solution one at a time. To enable parallel build, please add the "/m" switch.
Build started 12/6/2016 1:19:15 PM.
C:\Users\jovarty\Documents\GitHub\visualfsharp\FSharp.sln(248): Solution file error MSB5023: Error parsing the nested project section in solution file. A project with the GUID "{BF5C6
D92-D053-4216-9C42-B62F5F5C5E91}" is listed as being nested under project "{CFE3259A-2D30-4EB0-80D5-E8B5F3D01449}", but does not exist in the solution.
Build FAILED.
C:\Users\jovarty\Documents\GitHub\visualfsharp\FSharp.sln(248): Solution file error MSB5023: Error parsing the nested project section in solution file. A project with the GUID "{BF5
C6D92-D053-4216-9C42-B62F5F5C5E91}" is listed as being nested under project "{CFE3259A-2D30-4EB0-80D5-E8B5F3D01449}", but does not exist in the solution.
0 Warning(s)

1 Error(s)

Please provide a succinct description of the issue.
Repro steps

Clone visualfsharp repo
Run build.cmd
Run msbuild FSharp.sln

Expected behavior
The solution and its projects compiles properly.
Actual behavior
I receive the above errors regarding missing projects.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHubhttps://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2FMicrosoft%2Fvisualfsharp%2Fissues%2F1954&data=02|01|Kevin.Ransom%40microsoft.com|3918bdfd07a44087ee5908d41e1f2820|72f988bf86f141af91ab2d7cd011db47|1|0|636166566548067246&sdata=OXcVlWFJVD8Rhxe%2F8RATlMYJBBZAkTe7AD2XgYz6vtg%3D&reserved=0, or mute the threadhttps://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FAE76FtUK7XzXAjCAIJQTCAw2tq8pomCJks5rFdQJgaJpZM4LF6DM&data=02|01|Kevin.Ransom%40microsoft.com|3918bdfd07a44087ee5908d41e1f2820|72f988bf86f141af91ab2d7cd011db47|1|0|636166566548067246&sdata=sswZgemBX%2Ff3deUAiGS4nEWMtNJZWNhJgJf6AU2SHTo%3D&reserved=0.

I installed the C++ workload as I hadn't previously had it installed but I am still getting this error.
The GUID BF5C6D92-D053-4216-9C42-B62F5F5C5E91 is only found in FSharp.sln and I can't tell what it's supposed to refer to.
The GUID CFE3259A-2D30-4EB0-80D5-E8B5F3D01449 is found in both FSharp.sln and VisualFSharp.sln. It apparently points to "Tests" as indicated in:
Project("{2150E333-8FDC-42A3-9474-1A3956D46DE8}") = "Tests", "Tests", "{CFE3259A-2D30-4EB0-80D5-E8B5F3D01449}"
EndProject

So just to confirm, you're actually able to build FSharp.sln using the Developer Command Prompt?

Use build all.
fsharp.sln is an artifact that Don uses probably for source colouring and intellisense. I have no idea if it builds or not.
visualfsharp.sln should build the compiler and ide tooling but is not a tool I regularly use
build net40   to build the desktop compiler
build coreclr to build the coreclr compiler
build proto to build the proto compiler
build vs to be the vs addins
build all to build everything including the installers
Kevin
From: Josh Varty<EMAIL_ADDRESS>Sent: Tuesday, December 6, 2016 1:59 PM
To: Microsoft/visualfsharp<EMAIL_ADDRESS>Cc: Kevin Ransom<EMAIL_ADDRESS>Comment<EMAIL_ADDRESS>Subject: Re: [Microsoft/visualfsharp] Cannot build FSharp.sln from commandline with MSBuild (#1954)
I installed the C++ workload as I hadn't previously had it installed but I am still getting this error.
The GUID BF5C6D92-D053-4216-9C42-B62F5F5C5E91 is only found in FSharp.slnhttps://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2FMicrosoft%2Fvisualfsharp%2Fblob%2F12213cea55748f05d95b005032839e10501cfba2%2FFSharp.sln&data=02|01|Kevin.Ransom%40microsoft.com|cde55b74557442b2e6d008d41e230ad0|72f988bf86f141af91ab2d7cd011db47|1|0|636166583239851083&sdata=WkZHDMFrLUwCJfuOjp%2BT198tKz7pdn6ihTaPLFuNNhc%3D&reserved=0 and I can't tell what it's supposed to refer to.
The GUID CFE3259A-2D30-4EB0-80D5-E8B5F3D01449 is found in both FSharp.slnhttps://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2FMicrosoft%2Fvisualfsharp%2Fblob%2F12213cea55748f05d95b005032839e10501cfba2%2FFSharp.sln&data=02|01|Kevin.Ransom%40microsoft.com|cde55b74557442b2e6d008d41e230ad0|72f988bf86f141af91ab2d7cd011db47|1|0|636166583239851083&sdata=WkZHDMFrLUwCJfuOjp%2BT198tKz7pdn6ihTaPLFuNNhc%3D&reserved=0 and VisualFSharp.slnhttps://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2FMicrosoft%2Fvisualfsharp%2Fblob%2F12213cea55748f05d95b005032839e10501cfba2%2FVisualFSharp.sln&data=02|01|Kevin.Ransom%40microsoft.com|cde55b74557442b2e6d008d41e230ad0|72f988bf86f141af91ab2d7cd011db47|1|0|636166583239851083&sdata=I12hszPo5VibvQXFG0%2BB0yevqYS39TgxBEcenucgp0k%3D&reserved=0. It apparently points to "Tests" as indicated in:
Project("{2150E333-8FDC-42A3-9474-1A3956D46DE8}") = "Tests", "Tests", "{CFE3259A-2D30-4EB0-80D5-E8B5F3D01449}"
EndProject
So just to confirm, you're actually able to build FSharp.sln using the Developer Command Prompt?
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHubhttps://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2FMicrosoft%2Fvisualfsharp%2Fissues%2F1954%23issuecomment-265285936&data=02|01|Kevin.Ransom%40microsoft.com|cde55b74557442b2e6d008d41e230ad0|72f988bf86f141af91ab2d7cd011db47|1|0|636166583239851083&sdata=x%2BS9Ey1jRaZ3sr3VxHKwEdGzZWOSLSVUGxgc7mR4fZk%3D&reserved=0, or mute the threadhttps://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FAE76Fof62LtOlTeTpFd1BkXXZBxAWs-Kks5rFdqRgaJpZM4LF6DM&data=02|01|Kevin.Ransom%40microsoft.com|cde55b74557442b2e6d008d41e230ad0|72f988bf86f141af91ab2d7cd011db47|1|0|636166583239851083&sdata=71akbU7xQ%2Bt%2F2gSxLUZdVjWFJERozdZ2YOYqMcqiuIc%3D&reserved=0.

Thanks Kevin, I'll use build all for now. Going forward I think we should either:

Fix FSharp.sln and make it buildable.
Remove FSharp.sln.
At least update the documentation so it doesn't tell people to run msbuild FSharp.sln

Maybe @dsyme can clarify the purpose of FSharp.sln and it'll make it easier to understand how to go forward here.

Sounds like a plan.
From: Josh Varty<EMAIL_ADDRESS>Sent: Tuesday, December 6, 2016 2:40 PM
To: Microsoft/visualfsharp<EMAIL_ADDRESS>Cc: Kevin Ransom<EMAIL_ADDRESS>Comment<EMAIL_ADDRESS>Subject: Re: [Microsoft/visualfsharp] Cannot build FSharp.sln from commandline with MSBuild (#1954)
Thanks Kevin, I'll use build all for now. Going forward I think we should either:

Fix FSharp.sln and make it buildable.
Remove FSharp.sln.
At least update the documentation so it doesn't tell people to run msbuild FSharp.sln

Maybe @dsymehttps://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fdsyme&data=02|01|Kevin.Ransom%40microsoft.com|a6010e57e1dc40a793b008d41e28e025|72f988bf86f141af91ab2d7cd011db47|1|0|636166608289140525&sdata=BaeYXlTjeHUMsSKJwI03vsPYXH27bAQxeX7X7UmU0y8%3D&reserved=0 can clarify the purpose of FSharp.sln and it'll make it easier to understand how to go forward here.
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHubhttps://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2FMicrosoft%2Fvisualfsharp%2Fissues%2F1954%23issuecomment-265296379&data=02|01|Kevin.Ransom%40microsoft.com|a6010e57e1dc40a793b008d41e28e025|72f988bf86f141af91ab2d7cd011db47|1|0|636166608289140525&sdata=7eT4z%2FTUsMlVMy9qY9cfU5FOdTqxsSTxfIjfOYOZaMk%3D&reserved=0, or mute the threadhttps://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FAE76FjY4C_Hafk-C8PTRT-iK4q8eEVq6ks5rFeRZgaJpZM4LF6DM&data=02|01|Kevin.Ransom%40microsoft.com|a6010e57e1dc40a793b008d41e28e025|72f988bf86f141af91ab2d7cd011db47|1|0|636166608289140525&sdata=iQBJI8GrjkYQZsADo9g70TH4kXcEY%2FQldfTK%2B5IUmuU%3D&reserved=0.

Please leave FSharp.sln and lets somehow make sure it compiles.  Set up another CI if necessary, or reuse the non-VS one.
Many people coming to this repo are uninterested in the Visual F# IDE tools, or lack the experience and knowledge to understand them. For them, FSharp.sln is a much, much simpler entry point to contributing.  It will also eventually open in Xamarin Studio and elsewhere to allow cross-platform development of the compiler (though not yet CoreCLR).
It's also what we tell people to open in the main compiler section of DEVGUIDE.md.


Update bundlesize version and cleanup of warnings during installation

Reference issue: #ISSUEID
N/A
What changed in this PR:
Updates bundlesize dependency
Removes warnings during normal installation

I moved it to a branch that's directly on this repo, instead of a fork. See #65


##Added CSS

What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)

What is the current behavior? (You can also link to an open issue here)

What is the new behavior (if this is a feature change)?

Other information:

same changes as priyas pull request


Stacked area charts in time series view

Is your feature request related to a problem? Please describe.
I want to visualize self-profiling performance data (that is: how long various parts of a calculation took, per frame) in concert with other logged data (the result of the calculation). Right now, the only structure offered for displaying TimeSeriesScalars is many lines drawn independently on the same axes, which, for a large number of time series entities, produces a mess of overlapping lines.
Another problem I don't have, but which the proposed feature would be applicable to, is visualization of mutually-exclusive rates/proportions, like "X% of the points in the data set are currently class A, Y% are class B, and (100-X-Y)% are class C", or crates.io's download count chart.
Describe the solution you'd like
I would like to be able to cause the descendants of some entity, when they are time series, to be displayed as a stacked area chart — that is, if at some instant timings/a has scalar value 10 and timings/b has scalar value 20, I'd like a to be rendered as a filled region from 0 to 10 and b to be rendered as a filled region from 10 to 30 (offset upward to avoid overlapping a).
Describe alternatives you've considered
It would be possible for the data source to perform additions to create the boundary edges of such a chart. However, this would be nonlocal/fragile to implement, and would not create filled areas nor accurately display the original data values.
Additional context
#2852 and #1732 are other requests for doing more things with time series, which might be interesting to consider simultaneously.

A couple of complexities to consider when investigating this:

Need a way to order stacked elements. Right now the only option would be to sort based on something like entity-path-order, but this should probably have a dedicated component.
Data-interpolation when stacking non-aligned time-series. As the data sources would be separate entities, there is no guarantee they have data records at the same time-points. This might mean stacking one line on top of interpolated results from lower in the stack. A  linear interpolation is probably a good starting point for lines, but things like bar-charts might need a different kind of span/aggregation function for alignment.


Error: Metadata version mismatch for module found version 4, expected 3

On ng-build --prod getting following error
ERROR in Error: Metadata version mismatch for module /node_modules/ng-click-outside/lib/index.d.ts, found version 4, expected 3
at StaticSymbolResolver.getModuleMetadata (\node_modules@angular\compiler\bundles\compiler.umd.js:25616:34)
at StaticSymbolResolver._createSymbolsOf (\node_modules@angular\compiler\bundles\compiler.umd.js:25404:46)
at StaticSymbolResolver.getSymbolsOf (\node_modules@angular\compiler\bundles\compiler.umd.js:25385:14)
at \node_modules@angular\compiler\bundles\compiler.umd.js:24241:30
at Array.forEach (native)
at extractProgramSymbols (\node_modules@angular\compiler\bundles\compiler.umd.js:24240:79)
at AotCompiler.analyzeModulesAsync (\node_modules@angular\compiler\bundles\compiler.umd.js:23796:47)
at CodeGenerator.codegen (\node_modules@angular\compiler-cli\src\codegen.js:32:14)
at Function.NgTools_InternalApi_NG_2.codeGen (\node_modules@angular\compiler-cli\src\ngtools_api.js:73:30)
at _donePromise.Promise.resolve.then (\node_modules@ngtools\webpack\src\plugin.js:391:44)

Try updating Angular CLI.

Ah nevermind, it actually requires Angular 5 since they made breaking changes in their AOT compiler again.

Published v3.1.1 which is compiled with Angular 4. Might release a major revision later on that's built for Angular 5.

I find it very difficult to maintain compatibility with versions that theoretically should be more stable.
I hope that with each "major release" of the angular, do not generate a rework for the community in the way it is happening.

Yes, I'm not a fan of how Angular releases have been going, but I didn't have high expectations when they released huge breaking changes in I think Angular 2 RC4 or RC5.
That said, I don't actually use Angular anymore beyond maintaining whatever libraries I made before so I'll only continue doing so if it's reasonably easy to do so.


admin.env not loaded by m4

File admin.env is not loaded.
docker-*.m4 defines ADMIN_SECRET_AVAILABLE if file adminsecret.env is present.
readme adapted

SOrry for the other PR - I thought this was an issue ;)


Evaluate StableCoder

https://huggingface.co/stabilityai/stablecode-completion-alpha-3b-4k
https://huggingface.co/stabilityai/stablecode-instruct-alpha-3b
https://huggingface.co/stabilityai/stablecode-completion-alpha-3b
❤ the can-ai-code project!

Interested in these models so taking a look.
First issue I hit is the generation_config.json in all 3 models seems to have a problem:
ValueError: If eos_token_id is defined, make sure that pad_token_id is defined.
It doesn't seem this model has any concept of pad_token_id so going to try to set it to 0 like all the other tokens.

Loading stabilityai/stablecode-completion-alpha-3b model in fp16 with accelerate (device_map='auto', torch_dtype='fp16') seems to produce absolute nonsense:
3/28 FactorialZeroShot python

def factorial(n):
        fact = 1;

 for i in range (2, int((math.sqrt)(float(((factor * fact) + ((4*i)*(5*(6+7))))/8)))-3 ):
         if (((int)((0+(9*(((-((-((((-(j)+k))^l))+m)^p)*o)/q))*r))/t)%u)==v and j<w:
                 return v

         elif k>z or l==y :
                 break

 else
 print "The number is not valid"

This model seems to have no concept of EOS or BOS so I dont think there's any way it will never stop generating.  This wouldn't be so bad if what it generated was in some kind of consitent format but its just absolute trash..
Think accelerate may be causing this so I tried to fall back to their recommended way to load the model looks like it's trying to do fp32 even though the actual model itself is fp16 but it OOMed a 24GB host during loading.  I am not clear how does a 6GB model need over 24GB to load, but I'll need a bigger host to revisit the completion model.
The stabilityai/stablecode-instruct-alpha-3b flavor works totally fine:
13/28 GCDMisnamed python

def gcd(a, b):
    if a == 0:
        return b

    return gcd(b % a, a)

# Driver code
print("GCD of", 8, "and", 12,"is")
print(gcd(8, 12))

This one performs as expected for a model of this size, I am giving it a sweep over some prompt formats and I'll update results with the best ones.

Instruct results are up.  I'll leave this issue open until I can loop back around to trying the code-complete with their exact recommened settings to see if that makes it behave.

Final version of stable-code-completion is now out: https://huggingface.co/stabilityai/stable-code-3b
Performed eval for code completion and fim tasks it gets 70-80% on junior-v2 about what you'd expect from an OK-ish 3b.


WHY IS THERE NO GAEM!!!!?????

I SEEING THE CODE THERE NO GAME!! FIX RN!!!
:trollface:

wait until the mod's done

ok that fixed everything tanhk you!

On a unrelated note, did you ever find your dad?

On a unrelated note, did you ever find your dad?

lmfao


Size optimizations

Hi. I've come across a couple of size optimizations, which may sound interesting. By default, Alpine Linux builds packages with -Os GCC flag, which optimizes compiled binaries for size. By setting CFLAGS="-Os", I was able to reduce size of 3.8-alpine3.11 image from 112 MB to 83.9 MB (25% smaller). Also, Alpine Linux runs strip on all compiled binaries. AFAIK we can imitate that by setting LDFLAGS="-Wl,--strip-all", which strips all symbols from compiled binaries. After setting it, the image size was further reduced to 67.3 MB (40% smaller). Any thoughts?

Interesting!  I'm a bit wary of sacrificing performance for size (as -Os might), but I think stripping is probably very reasonable.

I've stumbled upon GCC Compiler Tests At A Variety Of Optimization Levels Using Clear Linux. Although it was done on Clear Linux, I'd guess the performance ratios are roughly the same on Alpine. As you can see, one size doesn't fit all, but -Os does IMO pretty well.

Any chance this change might make it in? This could be a big benefit for users of this image. Is there any reason NOT to do either CFLAGS="-Os" or LDFLAGS="-Wl,--strip-all"?

-Os overwrites --enable-optimizations and has a significant impact on performance: https://gitlab.alpinelinux.org/alpine/aports/-/issues/11129

Thanks @J0WI for pointing that out. But isn't this phenomenon specific to Python? Could we still considered it for other apps like PHP? Also, LDFLAGS="-Wl,--strip-all" should be safe in this case.

That makes sense. I tested the LDFLAGS locally and worked well for building. I made PR #483 for this in case we want to implement it.

Fixed via https://github.com/docker-library/python/pull/483 :+1:


Write Installation Tests

I no longer think that these are necessary since TravisCI installs funky (using python setup.py install) in order to setup the appropriate environment for testing the funky.sh shell integration script.


fix: remove inbound ssh traffic authorization

Summary
This commit removes all ingress traffic authorizations from the security group attached to the TRE execution
instances to reduce the attack surface of the TRE execution instances.

Removes the ingress rule that previously authorized inbound connections to port tcp/22
from unrestricted networks (e.g., <IP_ADDRESS>/0) by default.

Replaces the egress rule that permitted all outbound traffic to any destination with rules
that limit egress traffic to http/80 and https/443 to <IP_ADDRESS>/0.

Testing
These changes were successfully deployed to both a pre-existing TRE environment and a completely
new TRE environment. All AWS Service Catalog operations related to the TRE components
(e.g., CreateProvisionedProduct, UpdateProvisionedProduct, and TerminateProvisionedProduct)
were successfully tested in a multi-account AWS Control Tower environment, to include portfolios
shared directly with account principals and through AWS Organizations.
See V945951784 for additional testing details.

@zipengw27,
It is a known limitation with VPC and related resources that updating or deleting will often be blocked by that error, and that manual steps must be taken. There's no way around this right now, and it has existed for a long time.
It is discussed here, for example, when deleting a VPC. But the same applies to updating VPC-related resources.
https://repost.aws/knowledge-center/troubleshoot-dependency-error-delete-vpc


Experiment tracking code - common for all models

Add code for tracking experiments
Aceptance Criteria - Code and Tests

Expected Date of Finish - 18/01/2023


Ran pep257 on find.py.

Working on #742.

[Current coverage][cc-pull] is 100%

Merging [#761][cc-pull] into [master][cc-base-branch] will not change coverage

@@           master   #761   diff @@
====================================
  Files          13     13
  Lines         584    584
  Methods         0      0
  Messages        0      0
  Branches        0      0
====================================
  Hits          584    584
  Misses          0      0
  Partials        0      0

[][cc-pull]

Powered by Codecov. Last updated by [736f8db...0d3ebd3][cc-compare]
[cc-base-branch]: https://codecov.io/gh/audreyr/cookiecutter/branch/master?src=pr
[cc-compare]: https://codecov.io/gh/audreyr/cookiecutter/compare/736f8dba4f02344f302584932d4187d58866f3da...0d3ebd3abbfb4b41c52c11a4f6d3c2ce11bc304b
[cc-pull]: https://codecov.io/gh/audreyr/cookiecutter/pull/761?src=pr


fix(app): parse old server options in request

/deploy #persist

You can access the deployment of this PR at https://renku-ci-nb-1570.dev.renku.ch


query type 65 is invalid - unparsed HTTPS query_type

There's a new(?) qtype of 'HTTPS' (code is 65) that causes this great package to give up on parsing the packet.  I'm happy to put up a PR to fix it, but it would be great to know if this project was still alive or if there's a better replacement I should be looking at.  The code here hasn't been touched in a while.
Please let me know and thank you.

PR is up... seems to work.  I'll continue to use it in my private fork but it would be nice to see it merged or at least commented on.


Support MacOS catalyst

Hello, now we are supporting iOS and MacOS, we are also missing the macCatalyst version.
I suppose it shouldn’t be that difficult to compile.
Cheers.

+1


Finalhandler production stacktrace fix

@weierophinney this addresses #45 and makes it possible to create the FinalHandler in a factory and worry about the original response later.
One thing I wasn't sure about was whether error details should be in the case of 'env' !== 'production' vs. 'env' === 'development'. Production is surely "NO" and development is surely "YES", but other environments like staging, qa, etc. may depend on the implementor. Perhaps a boolean display_error_details option would be better than env? If so, what would you do with the original env? Remove it completely? Or automatically set display_error_details to true if env != production and false otherwise for BC?

Addendum is a tiny bonus to fix another FinalHandler glitch.

Just ran into this issue myself and then I remembered you mentioning this PR. This is a huge issue in my opinion, so hopefully it gets merged in soon.

I'd do $env !== 'production', and the default will be production; that way you can override the value in local environments, but it defaults to "safe for production". I can make that change on merge.

I can make that change on merge.

Never mind; that's how it already reads. :smile:

Marking as 1.2.0, as it introduces new functionality.

Merged to develop for release with 1.2.0.

:+1: thanks!!


Add Spanner Plugin

Signed-off-by: Sandeep Kumar Verma1<EMAIL_ADDRESS>

Sandeep, could you also add the resources the JS file before build/compilation?

This pull Request is very old, We have to build a new parser base. So dropping this PR as this is outdated now.


parallel is misspelled in query.py

Describe the bug
parallel is mis-spelled - false is the default, so this would probably work as intended.
{batchsize: 1000, paralell: false, retries: 3, params: {batched_parameter_sets: $batched_parameter_sets}}
Expected behavior
should be
{batchsize: 1000, parallel: false, retries: 3, params: {batched_parameter_sets: $batched_parameter_sets}}

Thanks for catching that @davidlrosenblum. We've correct it 👍


Problems with tsx template

Reporting a bug?
After upgrading @nuxtjs/i18n from 8.5.3 to v9, I encountered several pre-transform errors. In my main project, it was the following error message: Pre-transform error: '>' expected. I tracked this down to an issue with parsing TSX templates.
While stripping down the project to identify the root cause, I also encountered the following errors:
ERROR  Internal server error: ',' expected.
   10:26:17 AM
  Plugin: unplugin-vue-i18n:directive

and
Pre-transform error: Type expected.

The last one is present in the minimal reproduction linked below.
This issue wasn’t present in<EMAIL_ADDRESS>This seems to work fine:

I hope this reproduction is usable, even though it doesn’t directly use unplugin-vue-i18n, as it’s minimal enough to demonstrate the issue and doesn't use any @nuxtjs/i18n features.
Expected behavior
Tsx templates to work.
Reproduction
https://stackblitz.com/edit/github-ffpcjt?file=nuxt.config.ts,components%2FTestComponent.vue,app.vue
Issue Package
unplugin-vue-i18n
System Info
System:
    OS: macOS 15.1
    CPU: (12) arm64 Apple M2 Max
    Memory: 5.24 GB / 96.00 GB
    Shell: 5.9 - /bin/zsh
  Binaries:
    Node: 20.9.0 - ~/.nvm/versions/node/v20.9.0/bin/node
    Yarn: 1.22.19 - /opt/homebrew/bin/yarn
    npm: 10.1.0 - ~/.nvm/versions/node/v20.9.0/bin/npm
    pnpm: 9.9.0 - ~/Library/pnpm/pnpm
    bun: 1.0.25 - ~/.bun/bin/bun
  Browsers:
    Chrome: 130.0.6723.116
    Safari: 18.1

Screenshot
No response
Additional context
No response
Validations

[X] Read the Contributing Guidelines.
[X] Read the README
[X] Check that there isn't already an issue that reports the same bug to avoid creating a duplicate.
[X] Check that this is a concrete bug. For Q&A open a GitHub Discussion.

Thank you for your reporting!

Pre-transform error: Type expected.

Unfortunately, I could not reproduce the about error in my stackblitz environment 😿
Could you try to reproduce with CONSOLA_LEVEL=999 nuxt dev 🙏
That log level is able to output stack error on nuxt log (consola)
And I have a favor to ask. Two type of your github issues have been reported.
Please separate them as separate issues. It makes it easier for us to work on the issue. 🙏

@kazupon Hi, please try this reproduction, I think this is another similar issue, when using jsx/tsx in setup mode, the error message shows [plugin:unplugin-vue-i18n:directive] Unterminated regular expression literal.
https://stackblitz.com/edit/github-ffpcjt-6wnhlw?file=components%2FTestComponent.vue
and if you try to reference a variable in node like this:
<template>
const foo = 'foo';
const Test = () =>
Test{foo}
;
</template>

the error message shows [plugin:unplugin-vue-i18n:directive] ',' expected. which @CernyMatej mentioned above.

Oh, I'm sorry, I only attached the working reproduction.
The error message should be present here: https://stackblitz.com/edit/github-ffpcjt-qcfsie?file=components%2FTestComponent.vue
(I cannot verify that the error message is still present at the moment, since I have only my iPad on me right now, and it cannot start the dev server on StackBlitz. I have written the component code from memory. I'll be able to check it in about 4 hours.)

Btw. could you please help me understand what two types of issues you mean? I thought that this is all related to the same parsing issue.

@cernymatej this is another problem with vite directive plugin and vite vue plugin: https://github.com/intlify/bundle-tools/issues/420

@userquin I see, but when you download the reproduction and try to build it locally, does it build for you?
I can still see the Pre-transform error:

uhmm, I get this error in your repro:

Yes, this is on Stackblitz and should be related to https://github.com/intlify/bundle-tools/issues/420 as you said, but try to build it locally on your computer.

@userquin sorry for the ping but were you able to reproduce it? Should I raise a new issue?


Add shaders and examples from beta  Acid Glitch contributions

https://vvvv.org/contribution/acid-glitch-shaders

[ ] angularFlow
[ ] FFtBuffer
[ ] FFTDistort
[ ] stripedFlow
[x] transition_colorDistance
[ ] transition_dispersionBlur.tfx
[ ] transition_flyeye.tfx
[ ] transition_Morph.tfx
[ ] transition_randSquares.tfx
[ ] transition_waveScrawler.tfx
[x] verticalFlow.tfx


Duplicate JEI overlays in multiplayer.

When on the server, I get duplicate JEI overlays. One is stuck on some random page, the other I can interact with. The non-functional one hides the search bar and makes it difficult to click on things.
Gennie also reported having the same issue.

This issue needs to goto JEI's bug reporting, especially since I cant reproduce it to provide mezz more info

please followup on this issue with anymore info you can provide https://github.com/mezz/JustEnoughItems/issues/607

Mezz pushed a fix. We need to update to build 373 or newer.


updating needed for priority queue

Here
Check CLRS for priority queue inserting.

Two methods are needed :

delete(key_iterator) Check here.
substitute(old_key_iterator, new_key_iterator). Essentially, delete the old_key first and afterwards push the new_key_iterator

added. unit test needed.

Implemented from 33146b7655377276ce048fe5d608bef69676a02c to 5592779ab5de2796a1889e27e5e4d5ceaabd7c68


No Footer module

in this commit
https://github.com/abaykan/53R3N17Y/commit/88bc0d9e0edb23792a45897446651a1e4bd4d3af
you removed compiled files but there is no footer.py anymore which throw an error in execution.

Sorry, my bad. I uploaded it. Thanks


🔁 lucet-runtime-internals: Refactor Context backstop

:warning: :construction: :warning:
:movie_camera: This PR coming soon to an issue tracker near you! :popcorn:

This PR was closed as a byproduct of deleting the branch named master. If this is still an active PR, re-open as a new PR against main.

@iximeow expressed interest in working on this. Because my attention has been elsewhere, I'll close this now.


Nullpointer exception in Priam.Cassandra not starting up.

Good morning,
I am struggling to get Priam working with Cassandra and after hacking at it for two past two weeks, am finally reaching out to you all with hopes that you might be able to help.
I have the following installed:

Java 7 (openJDK)
Cassandra 2.0.17
Priam 2.x (says 2.8.0-SNAPSHOT)

I followed the Wiki to a tee but keep seeing the following with no other relevant information in any log files:
cassand+ 18663 18621  0 03:26 ?        00:00:00 grep -q Error: Exception thrown by the agent : java.lang.NullPointerException
We then attached a java debugger (jdb) to get to the source of the error and this what we see:
Cassandra running in the debugger, and discovered it's stuck in
com.netflix.priam.cassandra.extensions.PriamStartupAgent.setPriamProperties (PriamStartupAgent.java:75)
It tries to load configuration with the following code, and then if it fails, it sleeps for 5 seconds and tries again.
            token = DataFetcher.fetchData("http://<IP_ADDRESS>:8080/Priam/REST/v1/cassconfig/get_token");
            seeds = DataFetcher.fetchData("http://<IP_ADDRESS>:8080/Priam/REST/v1/cassconfig/get_seeds");
            isReplace = Boolean.parseBoolean(DataFetcher.fetchData("http://<IP_ADDRESS>:8080/Priam/REST/v1/cassconfig/is_replace_token"));
            replacedIp = DataFetcher.fetchData("http://<IP_ADDRESS>:8080/Priam/REST/v1/cassconfig/get_replaced_ip");
            extraEnvParams = DataFetcher.fetchData("http://<IP_ADDRESS>:8080/Priam/REST/v1/cassconfig/get_extra_env_params");

Obviously, it wasn't able to load the config via the REST API running in Tomcat. Tomcat had been shutdown, so I restarted it. The curl command (using the first "get_token" URL above) then got stuck waiting. Checked catalina.out log file from tomcat, and discovered this line repeated over and over again:
INFO 04:44:10,453 Fail wrting cassandra.yml file. Retry again!
INFO 04:44:10,453 Fail wrting cassandra.yml file. Retry again!
INFO 04:44:10,453 Fail wrting cassandra.yml file. Retry again!
We've been running tomcat as root, and also set up a link from "cassnadra.yml" to "cassandra.yaml":
$ ip-xx-xx-xx-xx:~$ ls -l /etc/cassandra/
total 92
-rw-r--r-- 1 root root 10837 May  8 03:09 cassandra-env.sh
-rw-r--r-- 1 root root  1199 Sep 18  2015 cassandra-rackdc.properties
-rw-r--r-- 1 root root  1358 Sep 18  2015 cassandra-topology.properties
-rw-r--r-- 1 root root   916 Sep 18  2015 cassandra-topology.yaml
-rw-r--r-- 1 root root 33360 Sep 18  2015 cassandra.yaml
lrwxrwxrwx 1 root root    14 May  9 14:41 cassandra.yml -> cassandra.yaml
-rw-r--r-- 1 root root  2374 Sep 18  2015 commitlog_archiving.properties
-rw-r--r-- 1 root root  1850 Sep 18  2015 log4j-server.properties
-rw-r--r-- 1 root root  1228 Sep 18  2015 log4j-tools.properties
drwxr-xr-x 2 root root  4096 May  8 02:28 triggers

Turns out Priam was looking for the yaml file in /mnt/cassandra/conf for some reason, instead of /etc/cassandra.yaml. Rather than trying to track down where in the world it got that value, we simply created a symbolic link with that path and pointed it to /etc/cassandra.yaml.
main[1] stop at com.netflix.priam.utils.TuneCassandra:50
Deferring breakpoint com.netflix.priam.utils.TuneCassandra:50.
It will be set after the class is loaded.
main[1] cont

Set deferred breakpoint com.netflix.priam.utils.TuneCassandra:50

Breakpoint hit: "thread=localhost-startStop-1", com.netflix.priam.utils.TuneCassandra.execute(), line=50 bci=6
50                  tuner.writeAllProperties(config.getYamlLocation(), null, config.getSeedProviderName());
localhost-startStop-1[1] print config.getYamlLocation()
config.getYamlLocation() = "/mnt/cassandra/conf/cassandra.yaml"
localhost-startStop-1[1] print config.getSeedProviderName()
config.getSeedProviderName() = "com.netflix.priam.cassandra.extensions.NFSeedProvider"
localhost-startStop-1[1] cont
That prevented the error message, but still not able to use the REST API.
ubuntu@ip-xx-xx-xx-xx:~$ curl http://<IP_ADDRESS>:8080/Priam/REST/v1/cassconfig/get_token
Apache Tomcat/8.0.33 - Error report HTTP Status 404 - /Priam/REST/v1/cassconfig/get_tokentype Status reportmessage /Priam/REST/v1/cassconfig/get_tokendescription The requested resource is not available.Apache Tomcat/8.0.33

There is no way that the install instructions for Priam are correct, as I have shown by all the issues that it is running into. Why is Netflix open sourcing software without correct install instructions?

Is anyone able to help with this?

To answer some of your questions:

"Turns out Priam was looking for the yaml file in /mnt/cassandra/conf for some reason, instead of /etc/cassandra.yaml. Rather than trying to track down where in the world it got that value,..." --- Priam fetches it from properties (see PriamConfiguration.getYamlLocation()).

/Priam/REST/v1/cassconfig/get_token 404 -- this could be a myriad of reasaons.  404 usually means that Tomcat is rejecting your request, possibly due to incorrect web.xml of your Tomcat instance.  Is any http request working to Priam?

@calicartel any other issues, if not, I will close this ticket.


feat/activations: add in-place activations

Activations can now be calculated in-place, requiring less memory. To use it, the same blob name should be supplied as input and output to a activation layer.
Example:
// set up linear1 layer
let linear1_cfg = LinearConfig { output_size: 1568 };
let mut lnr1_cfg = LayerConfig::new("linear1", LayerType::Linear(linear1_cfg));
lnr1_cfg.add_input("data");
lnr1_cfg.add_output("linear1_out");
net_cfg.add_layer(lnr1_cfg);
// set up sigmoid layer
let mut sigmoid_cfg = LayerConfig::new("sigmoid", LayerType::Sigmoid);
sigmoid_cfg.add_input("linear1_out"); // same input and output
sigmoid_cfg.add_output("linear1_out"); // same input and output
net_cfg.add_layer(sigmoid_cfg);

Yes, we should do that.

commit message: "implace" -> "in-place"

The in-place activation layers bring the memory usage down. For the Alexnet from 3GB to 2.5GB and for the Overfeat Network from 8.2GB to 7.4GB.
The .to_string() method calls couldn't be removed, because that caused unresolvable issues with the collection String from env.

@homu r+

:pushpin: Commit 223eaa4 has been approved by MichaelHirn

:zap: Test exempted - status


"We do not support pirated minecrafts" quote

Issue Description:
Note: If this bug occurs in a modpack, please report this to the modpack author. Otherwise, delete this line and add your description here. If you are using an unreleased version of Ender IO (e.g. for 1.8.9), please don't open an issue for features that have not been announced as "finished" or "working".
What happens:
I sent a issue about a start up crash and I got this quote
"We do not support pirated minecrafts"
I wonder if this means the mod does not support pirated minecrafts or the issue page does not help bugs for pirated minecarft users? I want to use this useful mod for an private mod pack. Please, if the case is the mod doesn't support pirated minecrafts, please, make it so the mod supports pirated minecrafts, I don't really want to spend 100+ ringgit for a mod. :(
What you expected to happen:
Steps to reproduce:

...

Affected Versions (Do not use "latest"):

EnderIO:
EnderCore:
Minecraft: 1.7.10
Forge:

Your most recent log file where the issue was present:
[pastebin/gist/etc link here]

This's a 1.10.2 version of minecraft. I forgot to add that

@MyBigFan2 AFAIK it is against the EULA to make a mod that supports pirated minecraft. Also, what do you mean "I don't really want to spend 100+ ringgit for a mod"? The mod is free and open source.

I don't want to spend 100+ ringgit to buy minecraft and use the mod. Because I am just a kid and I have to collect money to buy the game . I use pirated minecraft.

how old are you? to be a kid is no excuse, but maybe your parents need a lesson to tell their kid to not steal stuff

Stop stealing. 'Nuff said.


Feature Request: Support more certificate formats [other than .pem] for TrustStore

Describe the bug
SAP BTP subaccount has a destination which is of authentication type Basic authentication. Destination also has a trust store certificate uploaded in it. When this destination is used for making API calls, server is returning the error "unable to verify the first certificate"
Expected behavior
I have been using both cloud-sdk-java and cloud-sdk-js for fetching destination details and for API execution. When destination has truststore certificate in .crt format, API call was executing successfully.
But cloud-sdk-js throws the error 'unable to verify the first certificate' when the destination has truststore certificate in .crt format
Upon debugging I found out that cloud-sdk-js supports only pem format for certificates. When I used the certificate in pem format in the destination,  cloud-sdk-js still throws the same error.
Can you please check if the trust store certificate from any destination is getting used correctly while making API calls?
Few more things observed:
For certificates in destination, cloud-sdk-java supports formats [jks, crt, cer and der] but cloud-sdk-js supports only pem format.
Cloud-sdk-java throws exception when certificate format isn't a supported one but cloud-sdk-js doesn't.
When destination has truststore certificate in .pem format, cloud-sdk-js uses the certificate to form httpsAgent. The certificate would be added to ca attribute of httpsAgent. Before putting the certificate into this ca attribute, cloud-sdk-js is decoding the certificate content using the statement
Buffer.from(destination.trustStoreCertificate.content, 'base64').toString('utf8');
is this conversion from base64 to utf-8 needed?
Screenshots
If applicable, add screenshots to help explain your problem.
Used Versions:
3.13.0

node version via node -v 20.11.0
npm version via npm -v
SAP Cloud SDK version you used as dependency 3.13.0

Code Examples
If applicable, add code snippets as examples to help explain your problem. Please remove sensitive information.
Log file
If applicable, add your log file or related error message. Again, please remove your sensitive information.
Impact / Priority
High

Code has already been live and customer is unable to use the destination that has certificates in it.
Affected development phase: e.g. Getting Started, Development, Release, Production
Production
Impact: e.g.  Go-Live is in 12 weeks.
Additional context
Add any other context about the problem here.

Hi @HemanthShettyM,
thanks for raising this feature request.
Looking at our documentation and code, we don't support these file formats yet because there was no demand for them, though technically supporting them should be possible.
Looking at our current priorities, it is unlikely that we will be adding this feature soon.
I have created a backlog item in our project to reflect and review this feature request in the future.
If this feature request is urgent, feel free to create a contribution.
In the meantime, you should be able to change the format in your local CLI to follow the pem format.

Hi @tomfrenken,
pem format certificate was used, but it was still resulting in the error "unable to verify the first certificate".
Whenever pem format certificate is read by cloud-sdk-js, the certificate content is getting modified using the statement
Buffer.from(destination.trustStoreCertificate.content, 'base64').toString('utf8');
Is this conversion needed? will the server be able recognise the modified certificate content?

Hi @HemanthShettyM,
The type string matches the required type by the HTTP client. The conversion here is to toString, and utf8 is the default. We are simply explicit about the encoding and not making any major changes.
The reason it's read from base64 is because Cloud Foundry encodes the certificate when you upload it.
If you get an "unable to verify the first certificate" error with a .pem file, your setup is likely the cause. Please make sure that your certificate is valid and properly uploaded/set up in the destination.


Tooltip position

https://nanopay.atlassian.net/browse/CPF-3055

What does this do? Does the tooltip move around with the mouse?

What does this do? Does the tooltip move around with the mouse?

This makes tooltips move around with the mouse. Yes.


[NPU] Add case to improve coverage

1.补充部分适配ut
2.修正fa命名错误
3.修复适配aclnn算子名称错误
4.expand增加double类型注册

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.


Use case for "dist.repo" ?

I'm failing to understand the use case for dist.repo. The script will push my compiled sources to some repository other than the origin?
I know bower commonly pulls from github. Is that the inspiration?
Could you provide a real-world use case (with examples)? I just want to understand it, so I can see how to properly leverage the functionality in my own project.

The script will push my compiled sources to some repository other than the origin?

Exactly. To sum up the majority of the reasons: it's a good practice to leave generated files out of the source code repository. Also see: https://github.com/webpro/release-it#distribution-repository.
Real-world example: rsvp.js, DOMtastic. This project itself is using a branch of its own repo to release documentation at Github Pages.

Feel free to re-open and discuss further, but I'm closing this due to inactivity.

Thanks for the response. :beers:


Reintroduce image Kogito Base Builder for Web Tools

Many thanks for submitting your Pull Request :heart:!
In this PR, we introduce a missing image that we mistakenly removed here: https://github.com/apache/incubator-kie-kogito-images/pull/1748
See context: https://github.com/apache/incubator-kie-tools/pull/2229
The image has been modified in order to follow the patterns for reproducible containers and pass the ASF Release process. @paulovmr we need some tests from the tooling side.
Please make sure your PR meets the following requirements:

[ ] You have read the contributors guide
[ ] Pull Request title is properly formatted: [Issue XXXX] Subject
[ ] Pull Request contains link to the JIRA issue
[ ] Pull Request contains description of the issue
[ ] Pull Request does not include fixes for issues other than the main ticket
[ ] Your feature/bug fix has a testcase that verifies it
[ ] You've tested the new feature/bug fix in an actual OpenShift cluster
[ ] You've added a RELEASE_NOTES.md entry regarding this change

How to retest this PR or trigger a specific build:

(Re)run Jenkins tests
Please add comment: Jenkins [test|retest] this

How to backport a pull request to a different branch?

In order to automatically create a backporting pull request please add one or more labels having the following format backport-<branch-name>, where <branch-name> is the name of the branch where the pull request must be backported to (e.g., backport-7.67.x to backport the original PR to the 7.67.x branch).

NOTE: backporting is an action aiming to move a change (usually a commit) from a branch (usually the main one) to another one, which is generally referring to a still maintained release branch. Keeping it simple: it is about to move a specific change or a set of them from one branch to another.

Once the original pull request is successfully merged, the automated action will create one backporting pull request per each label (with the previous format) that has been added.
If something goes wrong, the author will be notified and at this point a manual backporting is needed.

NOTE: this automated backporting is triggered whenever a pull request on main branch is labeled or closed, but both conditions must be satisfied to get the new PR created.

PR job #146 was: FAILURE
Possible explanation: Pipeline failure or project build failure
Please look here: https://ci-builds.apache.org/job/KIE/job/kogito/job/main/job/pullrequest/job/kogito-images.build-and-test/146/display/redirect
See console log:

Console Logs
[Pipeline] }[Pipeline] // stage[Pipeline] }Build KIE » kogito » main » pullrequest » kogito-images.build-image PR #1754 - kogito-jit-runner: https://github.com/apache/incubator-kie-kogito-images/pull/1754 completed: SUCCESS[Pipeline] }[Pipeline] // stage[Pipeline] }Build KIE » kogito » main » pullrequest » kogito-images.build-image PR #1754 - kogito-jobs-service-postgresql: https://github.com/apache/incubator-kie-kogito-images/pull/1754 completed: SUCCESS[Pipeline] }[Pipeline] // stage[Pipeline] }Build KIE » kogito » main » pullrequest » kogito-images.build-image PR #1754 - kogito-jobs-service-ephemeral: https://github.com/apache/incubator-kie-kogito-images/pull/1754 completed: SUCCESS[Pipeline] }[Pipeline] // stage[Pipeline] }Build KIE » kogito » main » pullrequest » kogito-images.build-image PR #1754 - kogito-jobs-service-allinone: https://github.com/apache/incubator-kie-kogito-images/pull/1754 completed: SUCCESS[Pipeline] }[Pipeline] // stage[Pipeline] }Build KIE » kogito » main » pullrequest » kogito-images.build-image PR #1754 - kogito-management-console: https://github.com/apache/incubator-kie-kogito-images/pull/1754 completed: SUCCESS[Pipeline] }[Pipeline] // stage[Pipeline] }Build KIE » kogito » main » pullrequest » kogito-images.build-image PR #1754 - kogito-swf-builder: https://github.com/apache/incubator-kie-kogito-images/pull/1754 completed: UNSTABLE[Pipeline] unstableWARNING: Tests on kogito-swf-builder seems to have failed[Pipeline] }[Pipeline] // stage[Pipeline] }Build KIE » kogito » main » pullrequest » kogito-images.build-image PR #1754 - kogito-swf-devmode: https://github.com/apache/incubator-kie-kogito-images/pull/1754 completed: FAILURE[Pipeline] error[Pipeline] }[Pipeline] // stage[Pipeline] }Failed in branch kogito-swf-devmode[Pipeline] // parallel[Pipeline] }[Pipeline] // dir[Pipeline] }[Pipeline] // script[Pipeline] }[Pipeline] // stage[Pipeline] stage[Pipeline] { (Declarative: Post Actions)[Pipeline] script[Pipeline] {[Pipeline] sh+ wget --no-check-certificate -qO - 'https://ci-builds.apache.org/job/KIE/job/kogito/job/main/job/pullrequest/job/kogito-images.build-and-test/146/api/json?depth=0'[Pipeline] readJSON[Pipeline] sh

PR job #149 was: UNSTABLE
Possible explanation: This should be test failures
Please look here: https://ci-builds.apache.org/job/KIE/job/kogito/job/main/job/pullrequest/job/kogito-images.build-and-test/149/display/redirect
See console log:

Console Logs
[Pipeline] }[Pipeline] // stage[Pipeline] }Build KIE » kogito » main » pullrequest » kogito-images.build-image PR #1754 - kogito-data-index-postgresql: https://github.com/apache/incubator-kie-kogito-images/pull/1754 completed: SUCCESS[Pipeline] }[Pipeline] // stage[Pipeline] }Build KIE » kogito » main » pullrequest » kogito-images.build-image PR #1754 - kogito-jobs-service-allinone: https://github.com/apache/incubator-kie-kogito-images/pull/1754 completed: SUCCESS[Pipeline] }[Pipeline] // stage[Pipeline] }Build KIE » kogito » main » pullrequest » kogito-images.build-image PR #1754 - kogito-jobs-service-postgresql: https://github.com/apache/incubator-kie-kogito-images/pull/1754 completed: SUCCESS[Pipeline] }[Pipeline] // stage[Pipeline] }Build KIE » kogito » main » pullrequest » kogito-images.build-image PR #1754 - kogito-management-console: https://github.com/apache/incubator-kie-kogito-images/pull/1754 completed: SUCCESS[Pipeline] }[Pipeline] // stage[Pipeline] }Build KIE » kogito » main » pullrequest » kogito-images.build-image PR #1754 - kogito-task-console: https://github.com/apache/incubator-kie-kogito-images/pull/1754 completed: SUCCESS[Pipeline] }[Pipeline] // stage[Pipeline] }Build KIE » kogito » main » pullrequest » kogito-images.build-image PR #1754 - kogito-swf-builder: https://github.com/apache/incubator-kie-kogito-images/pull/1754 completed: UNSTABLE[Pipeline] unstableWARNING: Tests on kogito-swf-builder seems to have failed[Pipeline] }[Pipeline] // stage[Pipeline] }Build KIE » kogito » main » pullrequest » kogito-images.build-image PR #1754 - kogito-swf-devmode: https://github.com/apache/incubator-kie-kogito-images/pull/1754 completed: UNSTABLE[Pipeline] unstableWARNING: Tests on kogito-swf-devmode seems to have failed[Pipeline] }[Pipeline] // stage[Pipeline] }[Pipeline] // parallel[Pipeline] }[Pipeline] // dir[Pipeline] }[Pipeline] // script[Pipeline] }[Pipeline] // stage[Pipeline] stage[Pipeline] { (Declarative: Post Actions)[Pipeline] script[Pipeline] {[Pipeline] sh+ wget --no-check-certificate -qO - 'https://ci-builds.apache.org/job/KIE/job/kogito/job/main/job/pullrequest/job/kogito-images.build-and-test/149/api/json?depth=0'[Pipeline] readJSON[Pipeline] sh

I've restarted and now we are getting the usual timeout problem. @jakubschwan @tiagobento @yesamer can you please take a look so we can move forward? @paulovmr have you tested the snapshot image I sent you yesterday?


demo.noms.io datasets duplicated?

I think the first group is not supposed to be present - the few that are not under the cli-tour path.
$ noms ds https://demo.noms.io
ny-vehicle-registrations
ny-vehicle-registrations/raw

$ noms ds https://demo.noms.io/cli-tour
chi-building-violations
chi-building-violations/backup
chi-building-violations/raw
ny-vehicle-registrations
ny-vehicle-registrations/raw
nyc-parking-violations-2016
nyc-parking-violations-2016/raw
nyvr-model-year-index
sf-bicycle-parking
sf-bicycle-parking/raw
sf-bike-parking
sf-bike-parking/raw
sf-crime
sf-crime/raw
sf-film-locations
sf-film-locations/raw
sf-fire-inspections
sf-fire-inspections/raw
sf-registered-business
sf-registered-business/raw
sf-registered-businesses
sf-registered-businesses/raw

@aboodman or @kalman, not sure if it is because of the crontab imports or other.

I just accidentally imported there one time, manually from the command
line. You can delete them.
On Tue, Aug 9, 2016 at 6:28 AM, Mike Gray<EMAIL_ADDRESS>wrote:

@aboodman https://github.com/aboodman or @kalman
https://github.com/kalman, not sure if it is because of the crontab
imports or other.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/attic-labs/noms/issues/2319#issuecomment-238552571,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAE6BOJ7lr5PrpjenwgzlAwTnTpMt6ipks5qeIB-gaJpZM4JgEuz
.

deleted.


Generic JDBC Support

OpenRefine needs a Generic JDBC Connector for binding to any JDBC Driver. This isn't the case right now and the closed status of the original issue relating to this matter obscures the current state of affairs.
I am reopening this as a new feature request.
Naturally, opening this case doesn't mean that I won't consider engaging the services of @OpenLinkSoftware regarding issue resolution contribution.
We already made a new OpenRefine fork.
Additional Linked Data URIs for tracking this item:

http://linkeddata.uriburner.com/about/id/entity/https/github.com/OpenRefine/OpenRefine/issues/1277

http://linkeddata.uriburner.com/about/id/entity/https/github.com/OpenRefine/OpenRefine/issues/1909

/cc @thadguidry

Little note to self, re connecting these JDBC threads.
{
http://linkeddata.uriburner.com/about/id/entity/https/github.com/OpenRefine/OpenRefine/issues/1277
skos:related http://linkeddata.uriburner.com/about/id/entity/https/github.com/OpenRefine/OpenRefine/issues/1909 .
}

@kidehen
OK, so, my vote, SURE, let's have a way to hook in a Generic JDBC connector.
On other Enterprise applications (Pentaho, Talend, etc), I have seen this handled fairly easily with forms that let's you specify the .jar file path of the driver you intend to use, along with configuring Options and Advanced settings.
Example info & pics here: https://help.pentaho.com/Documentation/6.1/0P0/0U0/010/000
But we'd need a sponsor to pickup the bill for doing the work, or would welcome contributions !

@kidehen I think it would make sense to have a generic JDBC support as you hinted at.
Do you have an idea of what this would look like as a user? How would I supply a JDBC driver to OpenRefine?
Also, in case your fork is public, it would be interesting to see how you implemented the feature there, so that we can take inspiration from it.

We haven't done anything bar add support for our Virtuoso platform which has built-in bridging to ODBC or JDBC data sources.
JDBC integration simply boils down to a JAR location and a JDBC Connection URL.
SeeAlso:
https://github.com/OpenRefine/OpenRefine/issues/1909#issuecomment-447607838  -- earlier comment from @thadguidry .


GPIO Interrupts do not appear to work

Hi,
I am setting up an interrupt to trigger on GPIO 2.  This is for the Arduino 101, Zephyr 1.6.
Calling mraa_gpio_isr() succeeds (no error is returned), however interrupts fail to be triggered.
mraa_gpio_isr(dev->gpio, MRAA_GPIO_EDGE_RISING, &wfs_flow_isr, dev)
wfs_flow_dev is the interrupt function, and dev is the device context I am supplying.
Any clues?

I ran a test with GPIO #4 on Arduino 101, Zephyr 1.7 and it worked as expected.

Yes, once I updated to Zephyr 1.7 and new SDK, it all worked as expected.  I'll close this.


Controlling a servo motor (SG90) direct from Home assistant #23167

Home Assistant release with the issue:
0.91.3
Last working Home Assistant release (if known):
not known
Operating environment :
hassbian running on a RPi 3B
Description of problem:
I want to control a servo motor direct from Home assistant . It connected direct to GPIO , After searching, I think the good way to do it is using MQTT cover, I know the code that could be written in config.yaml, the problem that I don’t know what to write in python code, or how to control the motor through MQTT, any help is hugely appreciated.
This is my configuration.yaml and I don’t know what is the python code to use with that one
configuration.yaml
cover:
  - platform: mqtt
    name: "MQTT Cover"
    command_topic: "home-assistant/cover/set"
    state_topic: "home-assistant/cover/state"
    availability_topic: "home-assistant/cover/availability"
    qos: 0
    retain: true
    payload_open: "OPEN"
    payload_close: "CLOSE"
    payload_stop: "STOP"
    state_open: "open"
    state_closed: "closed"
    payload_available: "online"
    payload_not_available: "offline"
    optimistic: false
    value_template: '{{ value.x }}'
    tilt_command_topic: 'home-assistant/cover/tilt'
    tilt_status_topic: 'home-assistant/cover/tilt-state'
    tilt_min: 0
    tilt_max: 180
    tilt_closed_value: 70
    tilt_opened_value: 180

Uhm, beside that I think it's pretty strange that you think MQTT is the right way to control a servomotor that has absolutely no MQTT capabilities, this is not a "problem". I would ask your questions in the Forum.

Thanks @pattyland for taking your time to answer to this , I'm closing this as it is a non-issue.


Please add 'css-nested-elements' rule.

Hi guys,
Your plugin is great. I'm using it for my projects.
However, I think you should add this rule to the plugin: http://getbem.com/faq/#css-nested-elements
Thanks

Hi @Maxvien
the initial version of our internal bem code styleguide and the corresponding stylelint-bem-namics project did not allow nested elements.
However in our project we realised that there are many cases where elements need child elements to structure the css code well.
One example would be the following:
accordion
accordion__head
accordion__body

Here it is very easy to see that title and body are isolated elements which have to be placed inside an accordion wrapper element.
Ofcause you could use - instead of __ e.g. accordion-head or accordion-body.
But actually you just replace one separator with another but would keep the same structure.
How do you solve thoses cases?

Hi @jantimon
I' think about your solution.
Thanks for your response. 👍

Closing due to lack of activity


Modification Pages Plugin

Hide sub menu for pages plugin. I think is good idea.
Thank you. )

Hi,
the plural for a child, is children (without the s), anyway, on the form, it's better Show children instance of "Show submenu"
Thanks


More ways of making the settings window appear

By mistake we often launch multiple copies of the app just because we want to change mob settings. It would be great if the app detected that an instance is already running if you launch it from the dock, and if so, bring up the settings window. Also cmd-tabbing to the mobster app when a session is already running should bring up the settings window. Pressing the show/hide keyboard shortcut is not as intuitive.

We use OSX

I have experience this same problem. An alternative solution is that the big "Continue" button just checks for an existing session, and if one is running, functions as the "hide" button does. It's easy to accidentally alt-tab to the program and then mistakenly hit "continue," launching multiple sessions.


Changes between v2.0.0 and v2.1.0 break integration with Browserless

x-posting https://github.com/browserless/chrome/issues/548

I think this is the related Chrome bug.


Labels does not work well the German language

The package is awesome and and want to thank you @aertmann for sharing it.
We add this actually to a German project and the backend users mostly use German as language.
The package now uses neos language labels and not some own labels. That maybe makes it harder to adopt it for "special" languages like German.

We have some smaller issues in our language:

The node type names are nouns in German so we write them in uppercase, but the package uses always lcfirst
We use different words for the term "you have done something" or "Foo has done something" ... so when you are logged in and see your changes the word hat should be haben

I am not sure if I can change it that easy ... but hope to fine a solution and provide a PR as well :)
Understand that you choose the neos labels and don't create own ones :)

Hey sorry didn't get notified of this, so didn't see until now sorry.
If you manage to find a good solution, feel free to open a PR.


⚠ Processors has degraded performance

In 14e351e, Processors ($STATUS_URL) experienced degraded performance:

HTTP code: 200
Response time: 88 ms

Resolved: Processors performance has improved in 9c5991b.


Error when trying to slim Qwen2VL vision encoder: ValueError: list.remove(x): x not in list

When trying to run onnxslim on this model, I get the following error ValueError: list.remove(x): x not in list.
Version: onnxslim-0.1.41
Code to reproduce:
wget https://huggingface.co/hf-internal-testing/tiny-random-Qwen2VLForConditionalGeneration/resolve/main/onnx/vision_encoder.onnx
onnxslim vision_encoder.onnx slimmed.onnx

Error message:
Onnx Runtime version 1.20 has no specified compatible ONNX version.
Traceback (most recent call last):
  File "/usr/local/bin/onnxslim", line 8, in <module>
    sys.exit(main())
  File "/usr/local/lib/python3.10/dist-packages/onnxslim/cli/_main.py", line 147, in main
    slim(
  File "/usr/local/lib/python3.10/dist-packages/onnxslim/cli/_main.py", line 89, in slim
    model = optimize(model, skip_fusion_patterns)
  File "/usr/local/lib/python3.10/dist-packages/onnxslim/core/__init__.py", line 154, in optimize
    model = optimize_model(graph, skip_fusion_patterns)
  File "/usr/local/lib/python3.10/dist-packages/onnxslim/core/optimization/__init__.py", line 27, in optimize_model
    dead_node_elimination(graph)
  File "/usr/local/lib/python3.10/dist-packages/onnxslim/core/optimization/dead_node_elimination.py", line 18, in dead_node_elimination
    dead_node_elimination(subgraph, is_subgraph=True)
  File "/usr/local/lib/python3.10/dist-packages/onnxslim/core/optimization/dead_node_elimination.py", line 35, in dead_node_elimination
    delete_node(node)
  File "/usr/local/lib/python3.10/dist-packages/onnxslim/core/utils.py", line 21, in delete_node
    feed.outputs.remove(node.inputs[input_var_idx])
  File "/usr/local/lib/python3.10/dist-packages/onnxslim/third_party/onnx_graphsurgeon/util/misc.py", line 210, in remove
    super().remove(x)
ValueError: list.remove(x): x not in list

Thanks for your findings, I will check this very soon.

Hi @xenova do you have scripts to test if the model works, onnxslim will generate random data if inputs are in fixed shape but not dynamic one.

Adding a simple check to see if the list contains the node seems to fix it, but maybe there are other places to change this too.
Onnx Runtime version 1.20 has no specified compatible ONNX version.
unable to remove list.remove(x): x not in list
+---------------------+-----------------------------------------+-----------------------------------------+
|     Model Name      |           vision_encoder.onnx           |              slimmed.onnx               |
+---------------------+-----------------------------------------+-----------------------------------------+
|     Model Info      |       Op Set: 14 / IR Version: 7        |       Op Set: 14 / IR Version: 7        |
+---------------------+-----------------------------------------+-----------------------------------------+
|  IN: pixel_values   | float32: ('batch_size * grid_t * grid_h | float32: ('batch_size * grid_t * grid_h |
|                     |          * grid_w', 'channel *          |          * grid_w', 'channel *          |
|                     |   temporal_patch_size * patch_size *    |   temporal_patch_size * patch_size *    |
|                     |              patch_size')               |              patch_size')               |
|    IN: grid_thw     |        int64: ('batch_size', 3)         |        int64: ('batch_size', 3)         |
| OUT: image_features | float32: ('batch_size * grid_t * grid_h | float32: ('batch_size * grid_t * grid_h |
|                     |             * grid_w', 16)              |             * grid_w', 16)              |
+---------------------+-----------------------------------------+-----------------------------------------+
|         Add         |                   25                    |                   25                    |
|        Cast         |                   39                    |                    3                    |
|       Concat        |                   26                    |                   19                    |
| ConcatFromSequence  |                    1                    |                    1                    |
|      Constant       |                   262                   |                    0                    |
|   ConstantOfShape   |                   18                    |                   18                    |
|        Conv         |                    1                    |                    1                    |
|         Cos         |                    1                    |                    1                    |
|       CumSum        |                    1                    |                    1                    |
|         Div         |                   14                    |                   14                    |
|       Einsum        |                    1                    |                    1                    |
|        Equal        |                   12                    |                   12                    |
|         Erf         |                    1                    |                    1                    |
|       Expand        |                   15                    |                   15                    |
|       Flatten       |                    1                    |                    1                    |
|       Gather        |                   22                    |                   22                    |
|        Gemm         |                   10                    |                   10                    |
|      Identity       |                    2                    |                    2                    |
|         If          |                    2                    |                    2                    |
|        Loop         |                    1                    |                    1                    |
|       MatMul        |                    4                    |                    4                    |
|         Mul         |                   33                    |                   33                    |
|         Neg         |                    4                    |                    4                    |
|         Pad         |                    1                    |                    1                    |
|         Pow         |                    5                    |                    5                    |
|        Range        |                    9                    |                    9                    |
|      ReduceMax      |                    1                    |                    1                    |
|     ReduceMean      |                   10                    |                   10                    |
|       Reshape       |                   23                    |                   20                    |
|      ScatterND      |                    2                    |                    2                    |
|     SequenceAt      |                    2                    |                    2                    |
|    SequenceEmpty    |                    1                    |                    1                    |
|   SequenceInsert    |                    1                    |                    1                    |
|        Shape        |                   39                    |                   20                    |
|       Sigmoid       |                    2                    |                    2                    |
|         Sin         |                    1                    |                    1                    |
|        Slice        |                   24                    |                   20                    |
|       Softmax       |                    2                    |                    2                    |
|        Split        |                    4                    |                    4                    |
|   SplitToSequence   |                    2                    |                    2                    |
|        Sqrt         |                   11                    |                    9                    |
|       Squeeze       |                   14                    |                   14                    |
|         Sub         |                    5                    |                    5                    |
|        Tile         |                    3                    |                    3                    |
|      Transpose      |                   13                    |                   13                    |
|      Unsqueeze      |                   60                    |                   33                    |
|        Where        |                   12                    |                   12                    |
+---------------------+-----------------------------------------+-----------------------------------------+
|     Model Size      |                203.76 KB                |                192.46 KB                |
+---------------------+-----------------------------------------+-----------------------------------------+
|    Elapsed Time     |                                      0.68 s                                       |
+---------------------+-----------------------------------------+-----------------------------------------+

@xenova I think this slimmed model is invalid, you can use patch here https://github.com/inisis/OnnxSlim/pull/50

That fixes it! Thanks! If possible, could you put out a new release for this? I'm releasing Transformers.js v3.1 soon and would be nice to have this ready by then.

Ah spoke too soon, looks like the error still persists.
pip install --upgrade git+https://github.com/inisis/OnnxSlim.git@dev
wget https://huggingface.co/hf-internal-testing/tiny-random-Qwen2VLForConditionalGeneration/resolve/main/onnx/vision_encoder.onnx
onnxslim vision_encoder.onnx

produces:
Traceback (most recent call last):
  File "/usr/local/bin/onnxslim", line 8, in <module>
    sys.exit(main())
  File "/usr/local/lib/python3.10/dist-packages/onnxslim/cli/_main.py", line 158, in main
    slim(
  File "/usr/local/lib/python3.10/dist-packages/onnxslim/cli/_main.py", line 102, in slim
    model = optimize(model, skip_fusion_patterns)
  File "/usr/local/lib/python3.10/dist-packages/onnxslim/core/__init__.py", line 155, in optimize
    model = optimize_model(graph, skip_fusion_patterns)
  File "/usr/local/lib/python3.10/dist-packages/onnxslim/core/optimization/__init__.py", line 27, in optimize_model
    dead_node_elimination(graph)
  File "/usr/local/lib/python3.10/dist-packages/onnxslim/core/optimization/dead_node_elimination.py", line 18, in dead_node_elimination
    dead_node_elimination(subgraph, is_subgraph=True)
  File "/usr/local/lib/python3.10/dist-packages/onnxslim/core/optimization/dead_node_elimination.py", line 35, in dead_node_elimination
    delete_node(node)
  File "/usr/local/lib/python3.10/dist-packages/onnxslim/core/utils.py", line 21, in delete_node
    feed.outputs.remove(node.inputs[input_var_idx])
  File "/usr/local/lib/python3.10/dist-packages/onnxslim/third_party/onnx_graphsurgeon/util/misc.py", line 210, in remove
    super().remove(x)
ValueError: list.remove(x): x not in list

I think it works for me.

Hmm, weird. Which versions of onnx/onnxruntime are you using? 👀

@xenova Hi, I watched your video https://www.youtube.com/watch?v=n18Lrbo8VU8, very impressive work, btw, can I get one HF T-shirt 😀

Here is my version info

A clean install fixed it! ❤ Thank you!

btw, can I get one HF T-shirt 😀

I'm sure we can organize something!  Thank you!


Sync settings to file on each change

This seems like an extension to https://github.com/probot/settings/issues/1
The proposal would address the concern that enabling this plugin would confuse the process of changing repo settings for people who don't yet know about probot:settings. This is perhaps more important for large organizations who might want to introduce the plugin without "breaking" things for people who aren't yet aware.
Sample painful conversation
bob: I've just set up probot:settings!
alice: ok great, what happens when someone now makes a change from the UI?
bob: good question. I'll assume that we'll have to update the file manually.
alice: ok, how will we know when someone changed via UI? And what will be the consequence if we don't notice?
bob: good point. We'll have to stay vigilant. If we don't, I assume that the next time the file is changed, it will override the change made via UI. But I'm not sure, I'll have to do some testing, and then we can document the edge-cases.
alice: Hm, ok. Given the caveats, is this really worth the process gains?
bob: i'm not sure anymore...
Suggested Feature
To negate these concerns, it would be rad if changes made via the UI were automatically submitted either 1) as updates on default branch, or 2) as a PR to default branch.
(2) seems safer, although might be a little awkward to deal with multiple changes to repo settings, via multiple form saves -- would this involve a specially-named patch branch that is appended to?
Also, there is the outstanding question of whether this requires the addition of a new action to the RepositoryEvent type, so that the plugin can know when something has changed:
https://developer.github.com/v3/activity/events/types/#repositoryevent

@patcon yes! I think it would be awesome to have 2-way sync. I don't think it would be that difficult because we already have to fetch the current settings and diff them against the file to see what changes to make. The hardest part, as you suggest, is just watching for all the right events.

I would LOVE to. Thanks so much for using your valuable time to read. I really really appreciate the invitation into the appropriate place ;)


Opening Firefox opens Librewolf (if installed)

Describe the bug
When you install both Firefox and Librewolf, launching Firefox will cause Librewolf to be opened instead.
Steps To Reproduce
Steps to reproduce the behavior:

Enable both Firefox and Librewolf (This happened with both the module and adding it to systemPackages)
Launch Firefox
See that Librewolf actually opens

Expected behavior
Firefox actually opens instead of Librewolf
Additional context
I am not sure how much this helps, but I went through the Firefox wrapper and ran the binary manually, and it does launch Firefox, and after a bit more tinkering, it seems to be caused by this variable MOZ_LEGACY_PROFILES='1' as setting it and running the executable causes Librewolf to open, and not setting it launches regular Firefox.
Notify maintainers
@lovesegfault @mweinelt
Metadata
Please run nix-shell -p nix-info --run "nix-info -m" and paste the result.
[user@system:~]$ nix-shell -p nix-info --run "nix-info -m"
 - system: `"x86_64-linux"`
 - host os: `Linux 6.6.47, NixOS, 24.11 (Vicuna), 24.11.20240828.71e91c4`
 - multi-user?: `yes`
 - sandbox: `yes`
 - version: `nix-env (Nix) 2.18.5`
 - channels(galaxy): `"home-manager-23.05.tar.gz"`
 - nixpkgs: `/nix/store/887hpp8a2i99n9jjwcvz6qkhhhqsvzkg-source`

Add a :+1: reaction to issues you find important.

How exactly are you launching firefox?

How exactly are you launching firefox?

Happens when launching via krunner and just typing Firefox into the terminal. I assume it happens with everything though.

I think I have the same problem, I think whatever was started first is started: When starting Librewolf, then starting firefox will open a new librewolf window, when first starting firefox, then starting librewolf will open a ff window.

Then session disambiguation doesn't work. Something to fix for Librewolf, not Firefox.

Can reproduce that it launches another window of whatever is open, but not that launching Firefox is impossible like the author of the issue described.
Running on unstable, last updated a few days ago.


Add comments UI

We need to render comments for each ticket.
Since rendering all comments into one paragraph block isn't feasible, we should build a table of all comments.  Then use popup method to render each individual comment accordingly.

Added comments UI with popup


Fixes error in Firefox when coordinate is not available for elementFromPoint

Test 43 succeeds in Chrome but fails in Firefox, due to a call to doc.elementFromPoint where the arguments are undefined. In Firefox, an error is thrown when undefined is passed as an argument to elementFromPoint, but in Chrome it is treated as a 0. This change causes getCoord to return 0 when it would otherwise return undefined.

This change seems to introduce its own set of problems in github's running of the test suite... canceling for now until I can sort out what's going on. Sorry for the pull-request spam.


add AnuragThePathak

resolve #874

Do I need to commit and send pull request from main branch?

Do I need to commit and send pull request from main branch?

nope.

nope.

Then can you please tell me where did I go wrong?
I can see this only  Error: A branch or tag with the name 'AnuragPathak' could not be found

nope.

Then can you please tell me where did I go wrong? I can see this only Error: A branch or tag with the name 'AnuragPathak' could not be found

That is a known error, is being fixed upon 🙂


ZXCapture initing blocks the main theard?

ZXCapture initing blocks the main theard? Why ?

Old example.


Add array.of via new third party install method

New polyfill is about 3x the size of the current one.  Good to delegate maintenance to someone else but is that necessary?

It is necessary as ours is not fully spec compliant. Our polyfill would not let a user pass a different constructor to the function which is defined in step 4a


Training loss function

Can you please share the code for the loss used in the training. Also, in the code you have not used the cts mask, can you explain how is it used during the training?

Hi, @prach6i. The CTS mask is employed exclusively during the training, and it is not utilized during inference. You can find the pseudocode for the CTS mask in our paper, which should help you implement it. Please feel free to share any specific issues or questions you encounter. We're here to help.

Hi @prach6i
We have recently released the training pipeline for our repo. The code for the loss function can be found in the src/vdr/training/loss.py here.


Move benchmarks to cicero [WIP]

Commenting to test issue_comment webhook

/benchmark

/benchmark nofib

/benchmark nofib

/benchmark nofib

FYI it should be the component name, e.g. https://github.com/input-output-hk/plutus/pull/4330#issuecomment-1042916848

/benchmark nofib

FYI it should be the component name, e.g. #4330 (comment)

I think @zeme-iohk may have changed the benchmark script, to just take the benchmark name.

/benchmark nofib

/benchmark nofib

/benchmark nofib

/benchmark nofib

/benchmark nofib

/benchmark nofib

/benchmark nofib

Pretty sure it's still taking a component name: https://github.com/input-output-hk/plutus/pull/4957/files#diff-e6a0334d313629a99c5dcd944408ebef5538f58420d2772889baea43c4129726R67

/benchmark nofib

/benchmark nofib

/benchmark nofib

/benchmark nofib

Hmm, I don't see any jobs appearing in the action? But the comment reaction is appearing :thinking:

/benchmark nofib

/benchmark

/benchmark later

/benchmark no fib

/benchmark no fib

/benchmark please

/benchmark nofib

/benchmark no fib

/benchmark nofib

/benchmark nofib

/benchmark nofib

/benchmark nofib

/benchmark nofib

Comparing benchmark results of 'nofib' on 'a1d030b47' (base) and '54ff5d4' (PR)

Results table

Comparing benchmark results of 'nofib' on 'a1d030b47' (base) and '54ff5d4' (PR)

Results table

Comparing benchmark results of 'nofib' on 'a1d030b47' (base) and '38d0e7a' (PR)

Results table

/benchmark no fib

/benchmark nofib

Comparing benchmark results of 'nofib' on 'a1d030b47' (base) and 'f9238ad' (PR)

Results table

/benchmark nofib

@zeme-iohk great job!

How did this end up posting on a different PR?? https://github.com/input-output-hk/plutus/pull/4982#issuecomment-1331099879

Anyway, it now seems to be failing on the benchmark comparison script... apparently /usr/bin/env bash doesn't work???

/benchmark nofib

Comparing benchmark results of 'nofib' on 'a1d030b47' (base) and '0ecc85a' (PR)

Results table

/benchmark nofib

Comparing benchmark results of 'nofib' on 'a1d030b47' (base) and '3712a19' (PR)

Results table

/benchmark nofib

/benchmark nofib

Comparing benchmark results of 'nofib' on 'a1d030b47' (base) and '9fe5f08' (PR)

Results table

/benchmark nofib

/benchmark nofib

Comparing benchmark results of 'nofib' on 'a1d030b47' (base) and 'a5d1cf1' (PR)

Results table

Script
a1d030b
a5d1cf1
Change

/benchmark nofib

/benchmark nofib

Comparing benchmark results of 'nofib' on 'a1d030b47' (base) and '6a059b0' (PR)

Results table

Script
a1d030b
6a059b0
Change

clausify/formula1
28.90 ms
28.74 ms
-0.6%

clausify/formula2
35.59 ms
35.60 ms
+0.0%

clausify/formula3
97.70 ms
96.20 ms
-1.5%

clausify/formula4
141.2 ms
137.7 ms
-2.5%

clausify/formula5
622.7 ms
598.4 ms
-3.9%

knights/4x4
80.62 ms
79.44 ms
-1.5%

knights/6x6
215.9 ms
215.2 ms
-0.3%

knights/8x8
362.3 ms
357.4 ms
-1.4%

primetest/05digits
43.85 ms
43.54 ms
-0.7%

primetest/08digits
79.60 ms
79.31 ms
-0.4%

primetest/10digits
112.2 ms
111.3 ms
-0.8%

primetest/20digits
224.8 ms
224.2 ms
-0.3%

primetest/30digits
325.5 ms
325.7 ms
+0.1%

primetest/40digits
437.4 ms
438.2 ms
+0.2%

primetest/50digits
427.5 ms
428.2 ms
+0.2%

queens4x4/bt
13.64 ms
13.54 ms
-0.7%

queens4x4/bm
19.04 ms
19.10 ms
+0.3%

queens4x4/bjbt1
17.12 ms
17.11 ms
-0.1%

queens4x4/bjbt2
18.09 ms
18.13 ms
+0.2%

queens4x4/fc
44.08 ms
43.70 ms
-0.9%

queens5x5/bt
179.8 ms
180.7 ms
+0.5%

queens5x5/bm
222.8 ms
223.3 ms
+0.2%

queens5x5/bjbt1
215.7 ms
217.2 ms
+0.7%

queens5x5/bjbt2
232.1 ms
227.7 ms
-1.9%

queens5x5/fc
558.4 ms
557.9 ms
-0.1%

Hooray!

I think that noise threshold is higher than we used to have, I think our noise was <1% before and that looks like <2%, but that might be tolerable.


Implement RFC0005: Add vsdbg buildpack to each order group

Context
RFC 0005 outlines a plan for enabling Remote Debug support in the Paketo Buildpack for .NET Core. As part of the implementation, the vsdbg buildpack must be added to each order group in this buildpack's buildpack.toml.
Required Changes
In this buildpack, the vsdbg buildpack should be added to each order group. The buildpack should be specified as optional = true and must appear in the order prior to the dotnet-execute buildpack.

I think it’d be valuable to test out actually using the remote debugger with buildpack-built images as part of completing this issue. While we may not be able to test the Visual Studio integration in an automated test, I think it’d be a useful exercise to do it by hand and document the process. This can be a starting point for remote debugging docs.

Resolved in https://github.com/paketo-buildpacks/dotnet-core/pull/770


external-scaler spams log due to missing HTTPSO for dummy keda-add-ons-http-interceptor

Report
The logs of the interceptor are spammed because keda-add-ons-http-interceptor only has a ScaledObject and no accompanying HTTPSO which the external-scaler tries to get
Expected Behavior
This error should be ignored.
Actual Behavior
The error is spamming the logs
Steps to Reproduce the Problem

Install the keda-http-addon
Query the external-scaler logs

Logs from KEDA HTTP operator
{"level":"error","ts":1687362513.545272,"logger":"GetMetricSpec","caller":"scaler/handlers.go:117","msg":"unable to get HTTPScaledObject","name":"keda-add-ons-http-interceptor","namespace":"keda","error":"httpscaledobject.http.keda.sh \"keda-add-ons-http-interceptor\" not found","stacktrace":"main.(*impl).GetMetricSpec\n\tgithub.com/kedacore/http-add-on/scaler/handlers.go:117\ngithub.com/kedacore/keda/v2/pkg/scalers/externalscaler._ExternalScaler_GetMetricSpec_Handler\n\tgithub.com/kedacore/keda/v2@v2.10.1-0.20230601160236-b5de66fe3857/pkg/scalers/externalscaler/externalscaler_grpc.pb.go:190\ngoogle.golang.org/grpc.(*Server).processUnaryRPC\n\tgoogle.golang.org/grpc@v1.54.0/server.go:1345\ngoogle.golang.org/grpc.(*Server).handleStream\n\tgoogle.golang.org/grpc@v1.54.0/server.go:1722\ngoogle.golang.org/grpc.(*Server).serveStreams.func1.2\n\tgoogle.golang.org/grpc@v1.54.0/server.go:966"}

HTTP Add-on Version
0.5.0
Kubernetes Version
1.25
Platform
None
Anything else?
No response

Not sure if
{"level":"error","ts":1687361393.8690586,"logger":"Probe","caller":"handler/probe.go:63","msg":"health check function failed","error":"table has not synced","errorVerbose":"table has not synced\ngithub.com/kedacore/http-add-on/pkg/routing.init\n\tgithub.com/kedacore/http-add-on/pkg/routing/table.go:25\nruntime.doInit\n\truntime/proc.go:6506\nruntime.doInit\n\truntime/proc.go:6483\nruntime.doInit\n\truntime/proc.go:6483\nruntime.main\n\truntime/proc.go:233\nruntime.goexit\n\truntime/asm_amd64.s:1598","stacktrace":"github.com/kedacore/http-add-on/interceptor/handler.(*Probe).check\n\tgithub.com/kedacore/http-add-on/interceptor/handler/probe.go:63\ngithub.com/kedacore/http-add-on/interceptor/handler.(*Probe).Start\n\tgithub.com/kedacore/http-add-on/interceptor/handler/probe.go:44"}

is also related to this.

This is a regression I introduced when implementing the new routing table caused by a mismatch between the manifests we have on this repo and the ones from the charts repo that made me believe the interceptor scaling was not being used. Sorry about that! I'm working on a fix.


Tap/Swipe actions are not working in application which operates in landscape mode as intended for iOS

Click/Swipe actions are clicking at random places for application which operates in landscape mode.
In portrait application actions are smooth.
Also if possible please handle the screen resolution/viewport in landscape mode for better usability :)
To provide more context it is an unity application
please let me know if you need further information
[Video Link]

Yeah, that is expected because landscape is not handled at all :D This will require some work because it will be hard to automatically find out the current mode when you switch it on the device - I will look into it though, the easiest solution will probably be to add a button with which you will manually tell the UI that you are currently on landscape/portrait

yes having a button for landscape/portrait works :)

I'll create a release with this later today

@Gnanaprakash22 v2.3.0. Let me know if something ain't right, also try to use your device landscape to your left(device right) :D

@shamanec awesome !!! thanks will test it out

@shamanec it is working fine but one lil problem the page is not responsive/scrollable to see Landscape/Portrait button

I guess I have to reduce the responsive sizes even more, I am used to having a high resolution monitor and I forget about that 😅

speed is slow when accessing remotely through other system using the hub link

I don't think there is anything I can do about that as stated in the FAQ - I use WebDriverAgent for both the interaction and streaming so it is as good as they provide it. I might add an option to reduce the FPS and quality even more but I can't guarantee this will help over remote access :(

@shamanec could you please implement long tap & drag and drop in landscape mode it is not working

I'll check about the long tap but I can't make any promises on drag&drop - it doesn't exist right now, its not only on landscape

swipe is also not working for the app which i was checking

Do you think you can create some sample Unity app I can use for testing the swipe? I see no reason why swipes would work in some apps and not in others, I am just using coordinates :|

please share me your gmail id

<EMAIL_ADDRESS>

shared please check

The buttons are now moved to the right of the stream canvas so this should be fine - I will need more time to go over the tap/swipe actions because it seems its more complex than I anticipated :)

@Gnanaprakash22 you can check out the latest 2.4.1 release - swipe and tap should work better, also touch&hold. You still can't drag n drop though, or maybe you can if the element accepts swiping action

sure thanks for the update @shamanec will check this

@shamanec swipe and tap works better in this build thanks


Resolve race condition in transfer queue error collection

This was causing the intermittent batch error test failures under go 1.5. It was possible that the queue's Wait() function returned before all of the errors had been collected. This PR ensures error collection has finished.

:metal:

You rock!


Backport 16224 18922 18907 and more

~based on https://github.com/dashpay/dash/pull/4735~
Added a few additional commits from @kittywhiskers after reviewing them

IMO https://github.com/UdjinM6/dash/commit/2a5a1db763f34a0abb134ab826bdcd95b027e07b should be it's own PR. Applied the other commits


GH-38542: [C++][Parquet] Faster scalar BYTE_STREAM_SPLIT

Rationale for this change
BYTE_STREAM_SPLIT encoding and decoding benefit from SIMD accelerations on x86, but scalar implementations are used otherwise.
What changes are included in this PR?
Improve the speed of scalar implementations of BYTE_STREAM_SPLIT by using a blocked algorithm.
Benchmark numbers on the author's machine (AMD Ryzen 9 3900X):

before:

-------------------------------------------------------------------------------------------------------
Benchmark                                             Time             CPU   Iterations UserCounters...

Yes, though the scalar implementations are unfortunately only exercised on non-x86 by default (see added comment in the PR).
Are there any user-facing changes?
No.

Closes: #38542

@cyb70289 Do you want to take a look at how this performs on ARM?

Note that one reason for this work is that we might want to generalize BYTE_STREAM_SPLIT for more datatypes.

Big performance improvement observed on Arm Neoverse-N2 CPU.  For BM_ByteStreamSplitEncode_Double_Scalar/65536` test, instructions per iteration drops from 5,478,109 to 1,915,403.
Estimated roughly the total instructions to process 32 doubles.
Original code executes 1760 instructions, but optimized code only need 783 instructions.

Original:

BM_ByteStreamSplitEncode_Double_Scalar -> DoSplitStreams(num_values)
kNumStreams=sizeof(double)=8

  +--->19f78:       8b0200e1        add     x1, x7, x2
  |    19f7c:       8b050266        add     x6, x19, x5
  |    19f80:       d2800000        mov     x0, #0x0                        // #0
  | +->19f84:       386068c3        ldrb    w3, [x6, x0]
  | |  19f88:       91000400        add     x0, x0, #0x1
  | |  19f8c:       39000023        strb    w3, [x1]
  | |  19f90:       8b040021        add     x1, x1, x4
  | |  19f94:       f100201f        cmp     x0, #0x8  // for (size_t j = 0U; j < kNumStreams=8; ++j)
  | +--19f98:       54ffff61        b.ne    19f84 <parquet::BM_ByteStreamSplitEncode_Double_Scalar(benchmark::State&)+0x224>  // b.any
  |    19f9c:       91000442        add     x2, x2, #0x1
  |    19fa0:       910020a5        add     x5, x5, #0x8
  |    19fa4:       eb02009f        cmp     x4, x2    // for (size_t i = 0U; i < num_values; ++i)
  +----19fa8:       54fffe81        b.ne    19f78 <parquet::BM_ByteStreamSplitEncode_Double_Scalar(benchmark::State&)+0x218>  // b.any

Assume num_values = 32, calculate total instructions as below:
outer loop: count = 32,   instructions = 732 = 224 (exclude inner loop)
inner loop: count = 328, instructions = 8326 = 1536
Total instructions = 224+1536 = 1760

Optimized:

BM_ByteStreamSplitEncode_Double_Scalar -> DoSplitStreams(nvalues, width=sizeof(double)=8)

+----->19cb8:       aa1303ef        mov     x15, x19
|      19cbc:       aa0003ee        mov     x14, x0
|      19cc0:       5280000c        mov     w12, #0x0                       // #0
| +--->19cc4:       f94001f0        ldr     x16, [x15]
| |    19cc8:       aa0e03e4        mov     x4, x14
| |    19ccc:       d2800005        mov     x5, #0x0                        // #0
| | +->19cd0:       39404086        ldrb    w6, [x4, #16]
| | |  19cd4:       3940808b        ldrb    w11, [x4, #32]
| | |  19cd8:       39402082        ldrb    w2, [x4, #8]
| | |  19cdc:       3940608a        ldrb    w10, [x4, #24]
| | |  19ce0:       d370bcc6        lsl     x6, x6, #16
| | |  19ce4:       3940c088        ldrb    w8, [x4, #48]
| | |  19ce8:       d3607d6b        lsl     x11, x11, #32
| | |  19cec:       3940a087        ldrb    w7, [x4, #40]
| | |  19cf0:       aa0220c2        orr     x2, x6, x2, lsl #8
| | |  19cf4:       aa0a616a        orr     x10, x11, x10, lsl #24
| | |  19cf8:       3940e086        ldrb    w6, [x4, #56]
| | |  19cfc:       3844048b        ldrb    w11, [x4], #64
| | |  19d00:       d3503d08        lsl     x8, x8, #48
| | |  19d04:       aa0a0042        orr     x2, x2, x10
| | |  19d08:       aa07a107        orr     x7, x8, x7, lsl #40
| | |  19d0c:       aa070042        orr     x2, x2, x7
| | |  19d10:       aa06e166        orr     x6, x11, x6, lsl #56
| | |  19d14:       aa060042        orr     x2, x2, x6
| | |  19d18:       f8256a02        str     x2, [x16, x5]
| | |  19d1c:       910020a5        add     x5, x5, #0x8
| | |  19d20:       f10080bf        cmp     x5, #0x20  // for (int i = 0; i < kBlockSize=32; i += 8)
| | +--19d24:       54fffd61        b.ne    19cd0 <parquet::BM_ByteStreamSplitEncode_Double_Scalar(benchmark::State&)+0x260>  // b.any
| |    19d28:       91008210        add     x16, x16, #0x20
| |    19d2c:       1100058c        add     w12, w12, #0x1
| |    19d30:       f80085f0        str     x16, [x15], #8
| |    19d34:       910005ce        add     x14, x14, #0x1
| |    19d38:       7100219f        cmp     w12, #0x8  // for (int stream = 0; stream < width=8; ++stream)
| +----19d3c:       54fffc41        b.ne    19cc4 <parquet::BM_ByteStreamSplitEncode_Double_Scalar(benchmark::State&)+0x254>  // b.any
|      19d40:       d1008021        sub     x1, x1, #0x20
|      19d44:       91040000        add     x0, x0, #0x100
|      19d48:       f1007c3f        cmp     x1, #0x1f  // while (nvalues >= kBlockSize=32)
+------19d4c:       54fffb6c        b.gt    19cb8 <parquet::BM_ByteStreamSplitEncode_Double_Scalar(benchmark::State&)+0x248>

Assume nvalues = 32, calculate total instructions as below:
outer loop:  count = 1,   instructions = 7 (exclude middle and inner loops)
middle loop: count = 8,   instructions = 89 = 72 (exclude inner loop)
inner loop:  count = 84, instructions = 8422 = 704
Total instructions = 7+72+704 = 783

(What about decoding?)

(What about decoding?)

Should be similar. Instructions per iteration drop significantly (5,213,354 -> 1,703,533).
Be careful about the value, I just divided total instructions (from perf) by iterations shown in the benchmark report. I guess warmup time is not included in the reported iteration.

Another improvement I see is the better CPU pipeline parallelism from the optimized code.
IPC (instructions per cycle) increases from 4.06 to 4.83. This is amazing as the highest IPC of neoverse-n2, in theory, is 5.
Topdown metric "retiring" increases from 67.7% to 92.6%, which means 92.6% CPU cycles are doing useful works, a very high value.

I've added some more extensive tests for the various implementations and this is now ready for re-review. @wgtmac @mapleFU @cyb70289

Also, if src in DoSplit* doesn't fit in L1 Cache, would it get much slower?

It's also already out of L1 cache when num_values = 65536.

It's also already out of L1 cache when num_values = 65536.

Oh finally I got it. It might benefits from CPU prefetch? Thanks for the great code here

It might benefits from CPU prefetch?

Yes, I think it should. Though to be honest I haven't tried to check it. But 64k double values is already 512kB, so 1MB with both the input and output buffer, which is more than L2 cache size on my CPU...

I compared L1 and L2 missing events. L1 data cache MPKI (misses per kilo instructions) drops significantly from 49.6 to 10.2, L2 MPKI increases from 0.062 to 0.236.
The optimized code is also better for L1 data cache. My understanding is as below:

Original code loads data sequentially: offset 0,1,2,3,.....
Optimized code loads data by block in interleave:

1st outer loop: offset 0,  8, 16, 24, ..., 120
2nd outer loop: offset 1,  9, 17, 25, ..., 121
...
8th outer loop: offset 7, 15, 23, 31, ..., 127

For the optimized code, the 1st loop will populate L1 data cache with all necessary data for the next 7 loops.
Original code may be better for L2 prefetcher as the pattern is quite easy to predict, but optimized code reduces L1 misses which is a big win.

Haven't read through the discussion here, but from the release performance report, I noticed that the BM_ByteStreamSplitDecode_xx_Scalar benchmarks showed a regression apparently for this commit. See for example https://conbench.ursa.dev/benchmark-results/06543cccc43d719180005886ca3643dd/
Not sure why the conbench report above didn't say anything about that though. The speedups of this PR might also be hardware related?

The speedups of this PR might also be hardware related?

Maybe it's compiler related🤔 Auto-Vectorize might optimizing code like this

It can be hardware- or compiler-related indeed.

OK, completely ignore my comment. The benchmark is expressed in "bytes per second", so higher is better ... Thus the correct conclusion is: the benchmarks nicely captured the significant improvement from this PR! ;)

Aha...