Improve revert reason when assuming interface compliance

As discussed in this review comment, it'd be interesting to wrap calls to unknown contracts for which an interface is assumed in a low-level call that returns a custom revert reason on error, to better describe what went wrong.

A concrete example where whoever works on this should begin is this line in ERC721:
https://github.com/OpenZeppelin/openzeppelin-solidity/blob/af55a843e3e2d9c941712788a3e0318988f2bd06/contracts/token/ERC721/ERC721.sol#L284
This line can revert if the receiver doesn't implement the onERC721Received function. It can also revert if it does implement it but something in the implementation like a require causes a revert.
This issue is about ensuring there is a nice error message in those cases.
The way in we can achieve it is by performing a low-level call which allows us to revert with a custom revert reason.
(bool success, bytes returndata) = to.call( ... );
if (!success) {
    // revert with custom reason (or use `returndata` if non-empty)
} else ...

@nventuro I have started to look into it

Hi @nventuro @frangio,
I have added below piece of code in ERC721.sol:
bytes memory payload = abi.encodeWithSignature(
          "onERC721Received(address,address,uint256,bytes)",
          msg.sender,
          from,
          tokenId,
          _data
        );

(bool success, bytes memory returndata) = to.call(payload);

if (!success) {
    revert("ERC721: to address does not implement ERC721Received interface");
} else {
          return true;
   }

While running the test cases it fails:

Any help on this will be much appreciated.

Hi Team,
I went through the specified issue. I have added the following code in ERC721.sol.
bytes memory payload = abi.encodeWithSignature(
        "onERC721Received(address,address,uint256,bytes)",
        msg.sender,
        from,
        tokenId,
        _data
        );

        (bool success, ) = to.call(payload);

        if (!success) {
            revert("ERC721: to address does not implement ERC721Received interface");
        } else {
                return true;
        }

I have created a dummy contract which does not implement the IERC721Receiver interface and have updated test cases for the same in ERC721.behavior.js
Please do let me know if this is the correct approach used or do I need to think of some other way to solve the issue.

That's pretty good @NoopurShinde!
It's also a possibility that the recipient does implement ERC721Received and has reverted to reject the transaction. In that case, we should bubble the revert reason up. We can account for this case by checking in the case of success == false whether the length of the returndata is greater than zero, and if so, bubbling that instead up of reverting with our own revert reason.

I have updated the code in ERC721.sol and ERC721Behavior.test.js as suggested by @frangio to solve the specified issues.
Whenever I run the test cases for ERC721, all the test cases are passed. But when I try to run the  test suite, test cases result in failure. Is GSN causing the testcases to fail? I tried running test suite using truffle test and npm test. Please do let me know if this scenario is normal or is there something I am missing on.

Does someone want to pick up https://github.com/OpenZeppelin/openzeppelin-contracts/pull/1943 and continue the work?


Staking live metrics

Hello,
I am wondering if to the frontend someone could add a LIVE view of staking in two aspects:

volume of staked/un-staked  time
volume of addresses staking/unstaking

This would provide a bit more transparency to the project which is still a bit on the shadows.
Many folks still have unaswered questions:
What is the famed threshold after which Wonderland transforms itself into a VC firm like some people suspect should happen.
Explain to people why normal inflationary pressure and other principles of mainstream economics do not apply or apply differently to Time and the Wonderland project as a whole.
Provide constant investors relation material and fundamental analysis of projects leaders decide to invest in.
Salut

Hello, I think your Idea is great, but in the wrong Forum. wonderland governance happens here: https://www.wonderlandforum.xyz/
Note that some of your parameters are already visible on the App/Dashboard. I can highly advise you to look at this: https://docs.wonderland.money/basics/faq as it explains almost everything number related.
Cheers


test: code coverage

Codecov Report

:exclamation: No coverage uploaded for pull request base (main@c58bbde). Click here to learn what that means.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main       #3   +/-   ##
=======================================
  Coverage        ?   42.03%
=======================================
  Files           ?       22
  Lines           ?      590
  Branches        ?        0
=======================================
  Hits            ?      248
  Misses          ?      342
  Partials        ?        0

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.


⚠ Bofrost.be has degraded performance

In e965bd4, Bofrost.be (https://www.bofrost.be) experienced degraded performance:

HTTP code: 200
Response time: 1874 ms

Resolved: Bofrost.be performance has improved in 65705fd.


hcloud discovery: Add testcase for key only labels

This adds a test case for the hcloud discovery with key only labels.
Key Only Labels should already be possible as they are returned from the hcloud API {"key":""}
Fixes https://github.com/prometheus/prometheus/issues/9023

This should be a new label, which is there for all the labels.

(the new label should have  labelpresent instead of label), see kubernetes_sd doc.

(the new label should have labelpresent instead of label), see kubernetes_sd doc.

@roidelapluie i changed it, thank you!

@roidelapluie changed :)

I guess the tests should fail and you will need to rebase to fix the DCO.
Thanks!

@roidelapluie i added this case :)

Thanks!


Spark dataset replaceName config parameter

There is a common scenario for Spark jobs to write datasets to external paths like:
s3://my-whatever-path/year=2023/month=04/day=24

which breaks lineage graph, as each day's datasets are different. This is related to partitioning, but supporting partitioning in a way that Openlineage understands partitioning logic of the job is non-trivial issue. However, the broken lineage problem can be solved with implementing a simple feature that gets rid of unwanted path subdirectories.
This can be done with config parameters like:
spark.openlineage.dataset.replaceName.pattern=(.*)\/.*\/.*\/.*
spark.openlineage.dataset.replaceName.replacement=$1

which should solve the problem for s3://my-whatever-path/year=2023/month=04/day=24.
The feature would run Java replaceAll on all dataset names contained within emitted events.

@pawel-big-lebowski what do you think about using regex named groups for that purpose? This way you could match all the dataset name and replace just the group you want to replace, instead of making sure to not match what you don't want to match. I think it's more explicit then too.


Store ms byte as string

What changes are proposed in this pull request?
for bin/alluxio getConf backward compatibility, store duration and data size
properties as string for now.
Why are the changes needed?
Backward compatibility requirement for 2.8

alluxio-bot, merge this please


Log RSSI from scan results.

To help with signal issues (perhaps related to #134), add the target RSSI to the scan results.

To help with signal issues (perhaps related to #134), add the target RSSI to the scan results.

For now, it is far, far easier to just log the RSSI.


can not install daliy-python

when I install daily-python
pip3 install daily-python
ERROR: Could not find a version that satisfies the requirement daily-python (from versions: none)
ERROR: No matching distribution found for daily-python
Can You Help Me

same error

See #7

os : ubuntu18.04， python==3.10,
Could not find a version that satisfies the requirement daily-python

Can you provide the installation package in .whl format?

My dear I received your email, what do you want me to do for you?🥰🥰🥰
On Wed, Aug 14, 2024 at 9:53 AM ouyangshaoxia @.***>
wrote:

Can you provide the installation package in .whl format?
—
Reply to this email directly, view it on GitHub
https://github.com/daily-co/daily-python/issues/24#issuecomment-2287683210,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/BJOQK7CATOFQIYI3CWJQSCTZRK2BVAVCNFSM6AAAAABMNJL6DWVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDEOBXGY4DGMRRGA
.
You are receiving this because you commented.Message ID:
@.***>

same error on "CentOS Linux 7 (Core)"

My dear, I can't see your message🥹🥹🥹
On Fri, Aug 23, 2024 at 4:24 PM Menglong Xu @.***>
wrote:

same error on "CentOS Linux 7 (Core)"
—
Reply to this email directly, view it on GitHub
https://github.com/daily-co/daily-python/issues/24#issuecomment-2306566333,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/BJOQK7FYDXQ37CELS3KVFCTZS3WTRAVCNFSM6AAAAABMNJL6DWVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDGMBWGU3DMMZTGM
.
You are receiving this because you commented.Message ID:
@.***>

I'm experiencing the same issue. Unable to install the package on:
Operating System: CentOS Linux 7 (Core)
Kernel: Linux 3.10.0-1160.102.1.el7.x86_64
Architecture: x86-64

I'm experiencing the same issue. Unable to install the package on:
Operating System: CentOS Linux 7 (Core) Kernel: Linux 3.10.0-1160.102.1.el7.x86_64 Architecture: x86-64

Yep, same problem. CentOS 7 has a very old glibc (2.17, released in 2012) and it's actually already EOL. Unfortunately, CentOS 8 also has an old glibc.

Closing as duplicate of #7


Add release notes and/or changelog to the repo

It would be very useful to have some release notes and a changelog to give a quick overview of all the changes between each version. This would be especially useful for dependabot PR's, since they fetch release notes and changelogs automatically and show them in the PR.
Here's an example from a dependabot PR updating "ruff" in one of my repos: https://github.com/Snailedlt/Markdown-Videos/pull/588
Preview:

In order to get release notes added to every dependabot PR you only need to create a release on github with some text. Examples from "ruff": https://github.com/astral-sh/ruff/releases
In order to add changelog to the dependabot PR's you'll need to add a CHANGELOG.md to your repo. Se for example this one by "ruff": https://github.com/astral-sh/ruff/blob/main/CHANGELOG.md
Knowing what's released in each PR will make it easier to find out why something goes wrong when it does go wrong. See for example #45, where it's very hard to know which commits are a part of that release. If you make releases, a set of commits will also be associated with that release, giving you this neat commit overview in dependabot PR's aswell:

For reference this is how the dependabot PR looks for your package:

Noted! Release notes have been a challenge supporting 17 different web frameworks so far, but required releases have slowed down. It may be better to bundle them into a single release. I'll follow this for future releases.

If you do end up adding release notes, you can just copy that over to a changelog file too. That way we can see the entire release not history without clicking through each release.
I think there's some github actions that can automate this for you


linode-cli: Fix sha256 hash for openapi spec

Replaced the has for the openapi spec with a working hash, as
attempting to install linode-cli was failing, with the following
message:
hash mismatch in fixed-output derivation '/nix/store/px3cdbcb84bvw6xslr1k6hszyxpdis6j-openapi.yaml':
wanted: sha256:1l2fahdcmv7sp1qkwr5nv2vls8fypvlybwylqfzhyjmn7jqkw4hq
got:    sha256:03ngzbq24zazfqmfd7xjmxixkcb9vv1jgamplsj633j7sjj708s0
cannot build derivation '/nix/store/49xrq47id66kwszyaqg1qapknc3i8mmx-linode-cli-2.14.1.drv': 1 dependencies couldn't be built

Motivation for this change
Wanting to be able to install linode-cli properly.
Things done

[x] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
Built on platform(s)

[x] NixOS
[ ] macOS
[ ] other Linux distributions

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
[x] Tested execution of all binary files (usually in ./result/bin/)
[x] Determined the impact on package closure size (by running nix path-info -S before and after)
[x] Ensured that relevant documentation is up to date
[x] Fits CONTRIBUTING.md.

Thanks @srhb ,
That makes a lot of sense. I changed the file to fetch from the current release (4.63.1) of the openapi spec from github, and tested the install and basic functionality.

Beautiful, thank you. :smile_cat:


Master -> develop after 2.4.1 hotfix

Pull Request Checklist:

[ ] Positive Test Case Written by Dev

[ ] Automated Testing

[ ] Sufficient User and Developer Documentation

[ ] Passing Jenkins Build

[ ] Peer Code review and approval

Positive Test Case

[Enter positive test case here]

METRIC
VALUE

https://sonarqube.cuahsi-workstation.com:9000/dashboard?id=hydroshare-5010


Podspec

Please add a podspec for CocoaPods.

Any time soon.

i'm waiting too

Use pod 'AFNetworking+RetryPolicy', '~> 1.0'


[WIP]: icm20602 fifo

32 kHz gyro
4 kHz accel
DLPF completely disabled
emptying FIFO at 1 kHz

Doesn't seem to actually be possible to enable the data ready interrupt on FIFO watermark.

Existing PX4 integrator with coning compensation is expensive at 32 kHz (> 20% of the pixracer cpu). Is simple trapezoidal integration on raw int16s with constant FIFO dt sufficient if sampling at 32 kHz?


bam2cns error: Odd number of elements in hash assignment at bam2cns line 67

I've been testing proovread on PBSim simulated long reads and ART simulated short reads of a tuberculosis genome and I've encountered this error when running the tool on the data:
...
[Wed Jun 15 10:32:34 2016] Batch 4/20
perl -I/home/seanla/Software/proovread/bin/../lib/ /home/seanla/Software/proovr\
ead/bin/bam2cns --append 1 --bam proovread/bwa-sr-1/proovread.bam --bin-size 20\
 --cfg ../proovread.cfg --coverage 11.25 --ignore-weak-reads 0 --mask-weak-read\
s 0 --max-ins-length 0 --max-ref-seqs 100 --prefix proovread/bwa-sr-1/proovread\
.3 --qv-offset 33 --ref proovread/read-long/proovread.fq --ref-offset 7022806
#------------------------------------------------------------------------------#
Odd number of elements in hash assignment at /home/seanla/Software/proovread/bi\
n/bam2cns line 67.
#------------------------------------------------------------------------------#
[Wed Jun 15 10:32:34 2016] bam2cns unexpectedly returned
	Exited at 'main'
	'./proovread', line 1634
	Last call 'main::correct_sr_mt'
	'./proovread', line 868

I've attached a text file containing the output from stdout, the configuration file, and files containing a few reads from my short reads and long reads files.
ecoli-long-d5_0001-sample.fastq.txt
ecoli-short-single-d50-sample.fq.txt
proovread-out.txt
proovread.cfg.txt
Any ideas on how I can fix this? Thanks.

The command I used is ./proovread -c ../proovread.cfg in the proovread/bin folder

I changed deleted the paths for blast and samtools from my configuration file and added the paths to the binaries to PATH as suggested in my previous issue and running the program again yielded the same error. The output and my new config file are attached below:
proovread_out.txt
proovread.cfg.txt

I ran your .cfg on my installation without problems. There is, however,
something odd about your usage. If I am correct, you modified the
proovread.cfg file in the proovread installation folder? That file
ideally should not be changed - it is used in any run kind of as the
default config and is read without being specified by -c.
To create your own config, run proovread --create-cfg my.cfg, change
my.cfg and than run proovread -c my.cfg ...
Let me know if using the original proovread.cfg + a customized my.cfg
fixes your problem. And sorry about the inconvenience!
Cheers
Thomas
On 15.06.2016 14:29, Sean La wrote:

I changed deleted the paths for blast and samtools from my configuration
file and added the paths to the binaries to PATH as suggested in my
previous issue and running the program again yielded the same error. The
output and my new config file are attached below:
proovread_out.txt
https://github.com/BioInf-Wuerzburg/proovread/files/316878/proovread_out.txt
proovread.cfg.txt
https://github.com/BioInf-Wuerzburg/proovread/files/316879/proovread.cfg.txt
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/BioInf-Wuerzburg/proovread/issues/67#issuecomment-226277537,
or mute the thread
https://github.com/notifications/unsubscribe/AI7ej69roVCsb3ow8PLNl2PcJiQ0staGks5qMER2gaJpZM4I2kaK.

Hi Thomas,
Thanks for letting me know, I generated my own config file as you suggested and ran my tests using it. Unfortunately I encountered the same error. I have attached a copy of my output and my config file.
my.cfg.txt
proovread-out.txt

Did you restore the original config file?
On 15.06.2016 16:13, Sean La wrote:

Hi Thomas,
Thanks for letting me know, I generated my own config file as you
suggested and ran my tests using it. Unfortunately I encountered the
same error. I have attached a copy of my output and my config file.
my.cfg.txt
https://github.com/BioInf-Wuerzburg/proovread/files/317101/my.cfg.txt
proovread-out.txt
https://github.com/BioInf-Wuerzburg/proovread/files/317102/proovread-out.txt
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/BioInf-Wuerzburg/proovread/issues/67#issuecomment-226305972,
or mute the thread
https://github.com/notifications/unsubscribe/AI7ejxM82Qd5rSNOPRXp3QEwOzMiKFKGks5qMFz9gaJpZM4I2kaK.

Yes, I did.

weird. To possible fixes:

try using a full path to your config file -c /full/path/to/config
if 1) fails, try to avoid using a custom config and just supply
everything on command line -l long_reads.fq -s short_reads.fq -p prefix

On 15.06.2016 16:21, Sean La wrote:

Yes, I did.
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/BioInf-Wuerzburg/proovread/issues/67#issuecomment-226308034,
or mute the thread
https://github.com/notifications/unsubscribe/AI7ej5_r05l3syGjhYyVeNSbqTSHhOZ5ks5qMF7CgaJpZM4I2kaK.

Providing the full path to the config file worked! Thank you so much!


Add lgtm.co config

not sure why lgtm is not yet running like in https://github.com/crowbar/crowbar-ha/pull/132 and https://github.com/crowbar/crowbar-ceph/pull/57?
but +1


Datepicker crashes on Android

When select the date picker field it crashes the app on Android devices.
Any workaround?

My app doesn't crash, but the datepicker does not show up at all on android.

I just use DatePickerAndroid api directly in Android when press the picker, so you can try the native api to find the problem.


Neomake does not work in non english locale

Hi,
I tried to use Neomake inside Neovim but it failed inside GetSigns functions saying it can't find variable fname. It turns out that inside signs_txt variable you are searching for specific english string: 'Signs for (.*):', and also depend on line being called "line" in result dictionary. As it turns out this is not the case if the locale is set to non english value. I made this quick workaround to change vim language of messages to english and then return back to previous locale:
diff --git a/autoload/neomake/signs.vim b/autoload/neomake/signs.vim
index 7e593aa..f016dae 100644
--- a/autoload/neomake/signs.vim
+++ b/autoload/neomake/signs.vim
@@ -29,7 +29,10 @@ function! neomake#signs#GetSigns(...) abort
         endif
     endfor
     call neomake#utils#DebugMessage('executing: '.place_cmd)
+    let curlang=v:lang
+    language en_US.utf8
     redir => signs_txt | silent exe place_cmd | redir END
+    silent exe "language ".curlang
     let fname_pattern = 'Signs for \(.*\):'
     for s in split(signs_txt, '\n')
         if s =~# fname_pattern

Unfortunately I am not experienced in VimScript nor in writing Vim plugins so I do not know if this is acceptable solution.

This looks good to me. Would you mind submitting this as a pull request?


"Ticket #X" is displayed instead of ticket title in "CURRENT TICKETS" list

my ticket title was "matt's first ticket" but "Ticket #0" is displayed. bug?

We really need to change this to create ticket numbers on the db

or just define display # based on some existing db field

changed it to display as whatever position in the list it is


Registered Furnace Message Issue

Description of issue: Registed Furnaces message stays at either 0/20 or 1/20. Players can place as much furnace as they want and register it but the registered furnace message in the action bar will remain 0/20 or 1/20.

Plugins: Jobs (I tried this on a fresh server)
Server Type (Spigot/Paperspigot/etc): Tuinity
**Server Version (using /ver): 1.16.1 git-Tuinity-"598986c" **
More information: This only occurs on Jobs 4.16.1. I made a test server and only put Jobs as the one and only plugin and this issue still seems to exist. I replaced the Jobs jar with the downgraded 4.16.0 and the issue seemed to have been fixed. I guess this is an issue with the 4.16.1 version? I haven't tried launching it on a 1.16.2 server though.
EDIT: I tried this on a Paper 1.16.2 Build 91 and the issue still seems to exist.

You probably not enabled furnace exploit protection in generalConfig

It is enabled
ExploitProtections:
Furnaces:
Reassign: true
MaxDefaultAvailable: 20

Same problem here.
Jobs version: 4.16.1
Server version: paper 1.16.2

Also having this issue, though it seems like the furnace/brewstand registering/ownership isn't working at all. When using one it always says 0/ in the actionbar message and players are being paid from any furnace/brewstand they access and take a finished product out of, not specifically ones they've used before (even though this feature is enabled in the config)

This was not an issue last update (4.16.0) and seems to be an issue only on 4.16.1

also awaiting on an update, keep getting it told it is my fault.

To also add - even with this feature off in the config so players always have to actively remove items from the furnaces/brew stands to get paid for them, it still triggers the actionbar message which is still stuck on 0/MAX#

Confirmed same issue. Wasn't a thing until 4.16.1

Is a fix for this going to be pushed to a public release any time soon? It's been broken for a fair while now

When will it be fixed?


Changing issuedAt from optional to required breaks semver and downstream consumers

Specifically, removing this check would indicate a major version bump i believe.
Related issue: https://github.com/tablelandnetwork/js-tableland/pull/225

Hi @joewagner, this check was reinstated in https://github.com/spruceid/siwe/pull/134, published as 2.1.3, and 2.1.2 was deprecated accordingly. I'm also noting that the release is still tagged as beta on npm as we work through issues like this. Your input is much appreciated, thanks.
These changes were the result of recommended improvements from a recent security audit, and we will be publishing a complete release process for this library shortly (including maturity of beta releases, and promotion criteria to exit beta).
Thanks for your vigilance and patience, and apologies for the inconvenience. Please let us know if this worked for you.

Awesome!! Thanks for creating and managing this excellent resource for the community 🙏 🙏


[IOTDB-267]reduce IO operations in deserializing chunk header

Currently, deserializing the chunk header requires 2 disk read operations. One is reading chunkheader length, the other is reading chunkheader content. So this pr is for reducing IO operations in  chunk header deserialization.

Sounds good +1

One more push: If we record the total chunk size in the ChunkMetadata, we do not have to split the read of ChunkHeader and chunk data into 2 reads.

I've thought about it, but there are two other things to consider.

This will change the tsfile structure. I think it's best to change the file structure when upgrading a large version.
Although the granularity of data read by iotdb is chunk, we have been discussing whether we should change the granularity of data read by iotdb to page, especially in the case of insufficient memory.

One more push: If we record the total chunk size in the ChunkMetadata, we do not have to split the read of ChunkHeader and chunk data into 2 reads.

I've thought about it, but there are two other things to consider.

This will change the tsfile structure. I think it's best to change the file structure when upgrading a large version.
Although the granularity of data read by iotdb is chunk, we have been discussing whether we should change the granularity of data read by iotdb to page, especially in the case of insufficient memory.

That is okay, this change could be listed in the change list of 0.9.0. Fear not the changes.

Reading page by page will surely induce more IO, considering current read performance, I do think it is much beneficial. Moreover, you can adaptively choose to cache a page or a chunk depending on your available memory, which has no conflicts with the current code. And, in my opinion,  trade one IO for only another 8 bytes is so charming.

One more push: If we record the total chunk size in the ChunkMetadata, we do not have to split the read of ChunkHeader and chunk data into 2 reads.

I've thought about it, but there are two other things to consider.

This will change the tsfile structure. I think it's best to change the file structure when upgrading a large version.
Although the granularity of data read by iotdb is chunk, we have been discussing whether we should change the granularity of data read by iotdb to page, especially in the case of insufficient memory.

That is okay, this change could be listed in the change list of 0.9.0. Fear not the changes.
Reading page by page will surely induce more IO, considering current read performance, I do think it is much beneficial. Moreover, you can adaptively choose to cache a page or a chunk depending on your available memory, which has no conflicts with the current code. And, in my opinion,  trade one IO for only another 8 bytes is so charming.

I can't get the second point. By induce you mean reduce or increase?

One more push: If we record the total chunk size in the ChunkMetadata, we do not have to split the read of ChunkHeader and chunk data into 2 reads.

I've thought about it, but there are two other things to consider.

This will change the tsfile structure. I think it's best to change the file structure when upgrading a large version.
Although the granularity of data read by iotdb is chunk, we have been discussing whether we should change the granularity of data read by iotdb to page, especially in the case of insufficient memory.

That is okay, this change could be listed in the change list of 0.9.0. Fear not the changes.
Reading page by page will surely induce more IO, considering current read performance, I do think it is much beneficial. Moreover, you can adaptively choose to cache a page or a chunk depending on your available memory, which has no conflicts with the current code. And, in my opinion,  trade one IO for only another 8 bytes is so charming.

I can't get the second point. By induce you mean reduce or increase?

Increase, of course. Assuming we have 5 pages in a chunk, you will probably do 6 IOs (plus reading the header) to read the chunk if you read pages one by one.

One more push: If we record the total chunk size in the ChunkMetadata, we do not have to split the read of ChunkHeader and chunk data into 2 reads.

I've thought about it, but there are two other things to consider.

This will change the tsfile structure. I think it's best to change the file structure when upgrading a large version.
Although the granularity of data read by iotdb is chunk, we have been discussing whether we should change the granularity of data read by iotdb to page, especially in the case of insufficient memory.

That is okay, this change could be listed in the change list of 0.9.0. Fear not the changes.
Reading page by page will surely induce more IO, considering current read performance, I do think it is much beneficial. Moreover, you can adaptively choose to cache a page or a chunk depending on your available memory, which has no conflicts with the current code. And, in my opinion,  trade one IO for only another 8 bytes is so charming.

I can't get the second point. By induce you mean reduce or increase?

Increase, of course. Assuming we have 5 pages in a chunk, you will probably do 6 IOs (plus reading the header) to read the chunk if you read pages one by one.

As far as I know, we do read a Chunk into memory in one IO and then deserialize page one by one in memory.

According to my experiment on this pr, the time cost ratio of readChunkHeader to readChunk is still 2:1, which overturns our former assumption that it is because readChunkHeader calls the read operation twice that the ratio is 2:1.

I discussed this result with @little-emotion yesterday. And we plan to do more experiments on this to find out what really causes 2:1.


Fix invalid references for /server/solr

…a documentation
https://issues.apache.org/jira/browse/SOLR-XXXXX

Description
NOTE - I'm not sure if this fix is correct. This is tightly related to https://github.com/apache/solr/pull/1109.
This part references that Solr's data is kept in the path of /server/solr, which isn't mentioned in any other place I've found. I think that this is a mistake and the author meant /opt/solr/server/solr. If I'm correct, this path is no longer used in favor of /var/solr/data.
Solution
Understanding what is the correct path that the author meant, and fixing it if it is needed.
Tests
Checklist
Please review the following and check all that apply:

[x] I have reviewed the guidelines for How to Contribute and my code conforms to the standards described there to the best of my ability.
[x] I have created a Jira issue and added the issue ID to my pull request title.
[x] I have given Solr maintainers access to contribute to my PR branch. (optional but recommended)
[x] I have developed this patch against the main branch.
[x] I have run ./gradlew check.
[x] I have added tests for my changes.
[x] I have added documentation for the Reference Guide

@jebnix I'm sorry that some of these great doc improvements fell by the wayside...    Let's get them over the finish line!

I'm removing the entire sub chapter How can I mount a host directory as a data volume (which this PR touches) in #2277 since I.M.O. that it is a good practice at all for an application like solr. It just confuses. So I'll close this one.
@jebnix Really appreciate all your doc patches and I also apologise they fell behind. The "stale" bot brought new attention to them. Hope you are not discouraged from contributing again.


Update lua_filter.rst

Description: adding missing " in documentation code block for improved formatting
Risk Level: Low
Testing: doc regeneration
Docs Changes: yes, this is a fix for docs
Release Notes: N/A

Thank you. Can you potentially fix DCO? See the contributing guide.
/wait


Add ActiveRecord 7 and Ruby 3.1 to CI

This PR adds Ruby 3.1 and ActiveRecord 7.0 to the CI matrix in the following combinations:

Ruby 3.0 / ActiveRecord 7.0
Ruby 3.1 / ActiveRecord 6.1
Ruby 3.1 / ActiveRecord 7.0

With the additional changes below, the new branches all run green.
In addition to the CI configuration updates, this PR includes the following changes:

Explicitly adding the net-imap, net-pop, and net-smtp gems to the Rails 6.1 gemfile when Ruby is 3.1 or higher
Tweaking a few requires so that class loading works correctly in Rails 7

I didn't add a CHANGELOG entry because I'm not sure if the maintainers would want to treat this PR as an expansion of the officially supported Ruby and ActiveRecord versions.

Before submitting the PR make sure the following are checked:

[X] The PR relates to only one subject with a clear title and description in grammatically correct, complete sentences.
[X] Wrote good commit messages.
[X] Feature branch is up-to-date with master (if not - rebase it).
[X] Squashed related commits together.
[ ] Added an entry to the changelog if the new code introduces user-observable changes. See changelog entry format for details.

@tindron I've removed those lines and everything is green on my end,

Hey @petergoldstein 👋 !
Thanks, done in https://github.com/toptal/chewy/pull/834.


Facing Kurento Exception Issue after compilation

I am using this project as a POC but facing some issue with this project. getting KurentoClient Exception :
========================================
2020-05-11 15:32:22.937  WARN 5796 --- [rbeatExec-e1-t0] o.kurento.jsonrpc.client.JsonRpcClient   : [KurentoClient]  Error sending heartbeat to server. Exception: [KurentoClient]  Exception connecting to WebSocket server ws://<IP_ADDRESS>:8888/kurento
2020-05-11 15:32:22.938  WARN 5796 --- [rbeatExec-e1-t0] o.kurento.jsonrpc.client.JsonRpcClient   : [KurentoClient]  Stopping heartbeat and closing client: failure during heartbeat mechanism
2020-05-11 15:32:22.950  INFO 5796 --- [ntLoopGroup-3-1] o.k.j.c.JsonRpcClientNettyWebSocket      : [KurentoClient]  Inititating new Netty channel. Will create new handler too!
2020-05-11 15:32:24.955  WARN 5796 --- [           main] o.k.j.c.JsonRpcClientNettyWebSocket      : [KurentoClient]  Trying to close a JsonRpcClientNettyWebSocket with channel == null
2020-05-11 15:32:24.960  WARN 5796 --- [           main] ConfigServletWebServerApplicationContext : Exception encountered during context initialization - cancelling refresh attempt: org.springframework.beans.factory.BeanCreationException: Error creating bean with name 'webSocketHandlerMapping' defined in org.springframework.web.socket.config.annotation.DelegatingWebSocketConfiguration: Bean instantiation via factory method failed; nested exception is org.springframework.beans.BeanInstantiationException: Failed to instantiate [org.springframework.web.servlet.HandlerMapping]: Factory method 'webSocketHandlerMapping' threw exception; nested exception is org.springframework.beans.factory.UnsatisfiedDependencyException: Error creating bean with name 'groupCallHandler': Unsatisfied dependency expressed through field 'roomManager'; nested exception is org.springframework.beans.factory.UnsatisfiedDependencyException: Error creating bean with name 'roomManager': Unsatisfied dependency expressed through field 'kurento'; nested exception is org.springframework.beans.factory.BeanCreationException: Error creating bean with name 'kurentoClient' defined in com.example.spring.ws.api.SpringBootVideoConferencingApplication: Bean instantiation via factory method failed; nested exception is org.springframework.beans.BeanInstantiationException: Failed to instantiate [org.kurento.client.KurentoClient]: Factory method 'kurentoClient' threw exception; nested exception is org.kurento.commons.exception.KurentoException: Exception connecting to KMS
2020-05-11 15:32:24.964  INFO 5796 --- [           main] o.apache.catalina.core.StandardService   : Stopping service [Tomcat]
2

is there any problem when you have to import the project in Eclipse in pom.xml file if you have solve this problem please share


fix(iterationpanel): repaired the iteration panel.

Several fixes:

selected iteration (or backlog) is now highlighted.
backlog item count is not fake anymore.
backlog item numbers and iteration item numbers get properly updated on work item actions.
cursor is now a pointer over the iteration entries.
the whole cell is clickable, not only the title.

[test]


Testing the minimum node setup for Automate HA

Descriptions
This story will cover the testing and feasibility confirmation for all below use-cases:
Testing for chef backend customer use case - Customer with very less number of nodes
Uses to be tested

Existing HA --> 10 nodes
Mini HA --> 5 nodes
Mini non-HA --> 4 nodes
Micro non-HA --> 2 nodes
Regular Automate - 1 node

Note will do just to test the feasibility
And once the performance issues are fixed by the Automate team, we will test again for benchmarking.
Acceptance criteria:
Report all the above use-cases and their fesibility.

Document : https://progresssoftware-my.sharepoint.com/:w:/g/personal/ffulara_progress_com/EdbTd6BicE5Hrv64IFpiAhYBUZn41nl38XtOLP6JiptE7Q?e=8Xdf3o

Closing this story as per the above document. There are some more config driven use case, Which we need to cover as part of other story.


Screenshare broken since v0.35.0 (on NVIDIA?)

Hyprland Version
 System/Version info
Hyprland, built from branch  at commit<PHONE_NUMBER>4d0ccd87b198b63459497e63887f35  ().
Date: 2024-03-28
Tag:

flags: (if any)

System Information:
System name: Linux
Node name: nixos
Release: 6.8.1
Version: #1-NixOS SMP PREEMPT_DYNAMIC Fri Mar 15 18:19:29 UTC 2024

GPU information:
2b:00.0 VGA compatible controller [0300]: NVIDIA Corporation AD103 [GeForce RTX 4080] [10de:2704] (rev a1) (prog-if 00 [VGA controller])

os-release: BUG_REPORT_URL="https://github.com/NixOS/nixpkgs/issues"
BUILD_ID="23.11.20240322.56528ee"
DOCUMENTATION_URL="https://nixos.org/learn.html"
HOME_URL="https://nixos.org/"
ID=nixos
LOGO="nix-snowflake"
NAME=NixOS
PRETTY_NAME="NixOS 23.11 (Tapir)"
SUPPORT_END="2024-06-30"
SUPPORT_URL="https://nixos.org/community.html"
VERSION="23.11 (Tapir)"
VERSION_CODENAME=tapir
VERSION_ID="23.11"

plugins:

Bug or Regression?
Regression
Description
When trying to share my screen (tested with Firefox and OBS Studio), I don't get any prompt to select the monitor/window/area I want to share (I think that prompt is from XDPH?). So effectively, I can not share my screen.
0.34.0 of Hyprland is the last version that works for me, I also just tested 0.35.0, 0.36.0, 0.37.1 and latest git<PHONE_NUMBER>4d0ccd87b198b63459497e63887f35), they all behave the same.
Could have to do with my proprietary NVIDIA GPU drivers or NixOS, not sure.
#4735 seems kind of similar.
How to reproduce

Use NVIDIA proprietary drivers and be on NixOS (not sure if relevant)
Try to share your screen with a version newer than 0.34.0

Crash reports, logs, images, videos
No response

Using Hyprland on ArchLinux, same thing. Also, have an NVIDIA video card, but I don't think it matters for some reason.

Using Hyprland v0.37.1 on Nixos and having the same issue also with an NVIDIA GTX 1070 card.

bisect

Using both Hyprland v0.36.0 and v0.37.1 works on my NixOS setup. I currently have a NVIDIA GeForce GTX 1080 Ti card.

and that was fixed on -git ffs

#4791
if using 10-bit, this is an nv issue

When trying to share my screen (tested with Firefox and OBS Studio), I don't get any prompt to select the monitor/window/area I want to share (I think that prompt is from XDPH?).

means XDPH is not running. Likely crashed. Check the unit (systemctl --user xdg-desktop-portal-hyprland) update it.

After upgrading from 0.35.0 to 0.37.1 on Arch pipewire screenshare broke for me too, but I was able to """fix""" it by deleting my custom xdg-desktop-portal config.
Curious enough, it wasn't, as far as I could tell, wrong, and it only set my preferred filechooser to kde's one, like on the wiki.
After that portal started working fine.

#4791
if using 10-bit, this is an nv issue

Yeah that was the issue, disabling 10-bit in my hyprland config works as a workaround


Fix typo for 'southafricawest' region

Hi,
This is a tiny PR to fix the following issue :
https://github.com/gruntwork-io/terratest/issues/375

https://github.com/gruntwork-io/terratest/releases/tag/v0.19.4


tutorials: use L.geoJSON new syntax

for consistency with recommended factory new syntax (L.geoJSON instead of legacy L.geoJson).
As done in PR #4933 for docstrings.
Note 1: updated only .md files, assuming the .html files are generated?
Note 2: this PR target branch is tutorials-cleanup, not master <= sorry last time I did not include the note soon enough… :-S

updated only .md files, assuming the .html files are generated?

@ghybs  Yes, jekyll takes care of building the static HTML.


Schema PostgreSQL

I have a question, maybe i don't really understand that part but in PostgreSQL how can i create a new Schema with Knex and if i actually run a create table how can i select that schema on the transaction?
Thanks, great library!

With raw queries. There is no support for schema creation methods currently. When doing queries, there is .withSchema builder method to tell which schema to use.


Suggestion: Allow for any URL to be input

I am developing a site locally and have an entry in my Hosts file for it so that I can access it via sitename.local (for example). This allows me to test authentication locally with how the project is setup.
<IP_ADDRESS> sitename.local

Right now the autoCorrectURL.js mixin will prepend https:// so the url becomes https://sitename.local.
Suggestion: Don't auto correct urls.  I see this as a dev tool so it would be nice to not have it modify the url.  Thoughts?

Hey, Will! This is definitely worth looking into.
To give you some background into the autoCorrectURL.js file, check out https://github.com/nwittwer/reflex/issues/73. The need for it comes from the UX in Chrome, where you can just type in a domain name (i.e. "google.com", and you expect Chrome to figure out the rest for you (append http/https://). Otherwise, the browser would just sit there, since there's not a correct URL. And manually typing it can feel a bit tedious compared to what users might expect.
I would imagine these to be the main use cases, in regards to protocols:

http/https://
file://
custom

In your case, there doesn't need to be a protocol specified, right? sitename.local would be exactly where you want the browser to navigate to?
Not sure if this is the right solution, but one possibility would be to add an auto-suggest menu, also similar to what Chrome does when you start typing in the URL bar. It displays a list of Google search results, your recent history results, and a static option if you just want to search for the term. Similarly, maybe when you type in URL, like sitename.local, you could select whether to go directly to that URL or have it auto-append a protocol?

The protocol for my case is http as it's in local development.
A way around this would be to check first if there is a protocol specified.  If a protocol is specified, don't auto correct. If a protocol is not specified, then auto correct to attempt to resolve.

Sounds good, I think it's way better to default to http instead of https.
FYI I've added a test for autoCorrectURL.js here. Accessible by running npm run test.

@bigredwill Made a PR for this here: https://github.com/nwittwer/reflex/pull/132/files, will merge in the next 1-2 weeks if there's no concerns


Using Nylas Python v3 SDK, create a code sample to read calendar

Using Nylas Python v3 SDK, create a code sample to read calendar

Sup! I'm ready to tackle Python-related issues. But here's the deal: do you prefer samples that are tied to a specific framework, or are you good with a straightforward Python script? I'm asking because the official example is built with Flask.

@wiseaidev - Python scripts are solid 👍
Assigned ! Connect if you have questions. We will get you setup with our new dashboard for testing purposes.
Send your email over to devrel at nylas.com with the subject: hacktoberfest23, and we'll quickly send account details 👍

@wiseaidev - just following up on this ticket, are you blocked by the issues you raised on the SDK?
These are the open issues I see that you raised.

Sup @relaxedtomato, I am currently busy doing other things. Besides, I am going to knock off all Python-related issues we have here during this weekend, starting today/tomorrow. Have a nice day, ma fren!

@wiseaidev, just realized we just got your email, so haven't completed this task:
Send your email over to devrel at nylas.com with the subject: hacktoberfest23, and we'll quickly send account details 👍
Will have @atejada follow up with you with an account setup so you can test your code sample #84

Done!

Done!

Resolved by PR #89


KServe VLLM cpu image

What this PR does / why we need it:
This PR enhances the kserve/huggingfaceserver image support by introducing compatibility for both GPU and CPU workloads with the vllm engine. Key changes include:

New Dockerfile for CPU support: Adds a Dockerfile to build a CPU-compatible huggingfaceserver image that supports the vllm engine powered by OpenVINO on non-GPU environments.
Image Tagging for GPU Deployments: Updates the predictor controller to append the -gpu suffix to the huggingfaceserver image tag specifically for GPU-based deployments.
Enhanced GitHub Workflows:

Modifies existing workflow to tag images with -gpu for GPU deployments.
Introduces a new workflow for building and publishing the CPU-compatible huggingfaceserver image.

This allows seamless deployment of huggingfaceserver on both CPU and GPU environments, improving flexibility and resource optimization.
Using vLLM powered by OpenVINO for its compatibility and performance advantages on x86-64 CPUs with AVX2 support. Unlike the standard vLLM for CPU, which requires separate builds for AVX2 and AVX512 due to differing package requirements, OpenVINO's solution is universally compatible. Additionally, it offers superior token throughput performance compared to the standard CPU implementation. Another significant benefit is its ability to run models like Gemma 2, which rely on logit soft-capping and fail to load with the standard vLLM CPU package
Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes kserve/kserve#3997
Type of changes
Please delete options that are not relevant.

[x] New feature (non-breaking change which adds functionality)

Feature/Issue validation/testing:
Please describe the tests that you ran to verify your changes and relevant result summary. Provide instructions so it can be reproduced.
Please also list any relevant details for your test configuration.

[x] Completed sanity checks by running an inference service using the Hugging Face vLLM Runtime CPU image on an x86 CPU platform that supports the AVX512 ISA.
[x] Verified changes in the predictor controller to select the appropriate runtime image based on whether the InferenceService specifies nvidia.com/gpu in its resource requirements.

Special notes for your reviewer:

Please confirm that if this PR changes any image versions, then that's the sole change this PR makes.

Checklist:

[x] Have you added unit/e2e tests that prove your fix is effective or that this feature works?
[x] Has code been commented, particularly in hard-to-understand areas?
[x] Have you made corresponding changes to the documentation?

Release note:

NONE

@AyushSawant18588 Would it be possible to include an end to end test in this PR ?

@AyushSawant18588 Would it be possible to include an end to end test in this PR ?

yeah sure I will add an e2e test in this PR

/rerun-all

/rerun-all

/rerun-all

/rerun-all

/rerun-all

/rerun-all

/rerun-all

/rerun-all

/rerun-all

/rerun-workflow explainer-runtime-build

/rerun-workflow E2E Tests

Thanks @AyushSawant18588 ! great work on this!
/lgtm
/approve


Fixed an inefficient nearestNode and nearestLink implementation where…

In target.js, a full sorted array, the full size of the nodes or links was being spliced. Instead, only an array is kept sorted for the expected count of nodes or links.
For a 20k set of nodes and many links, this was taking 2+ minutes with the Chrome performance regression of Array.splice: https://bugs.chromium.org/p/chromium/issues/detail?id=835558
With this optimization, the Chrome performance regression is not a factor.

DuoJS is not working correctly for development in grapher-target. @cixzhang removed component.json from grapher which I think is the culprit. The workaround is to change grapher-target/build/build.js to: Grapher = require('../components/ayasdi-grapher@v1.3.2/build/grapher.js');
This is after DuoJS installs Grapher in it's components directory.

Looks like Chrome fix is on 68.0.3418.0.
Can we add a comment with link to chromium bug?
We may as well test the performance (timestamps?) in the spec as well.

Oh and don't forget to build :)

Merge #7 to fix test issues relating to duo.

Bummer, Travis CI build is having trouble. I can't reproduce it locally by following the Node 4.1.0 Travis CI steps. It works fine.
>> Error caught from PhantomJS. More info can be found by opening the Spec Runner in a browser.
Warning: SyntaxError: Parse error Use --force to continue.

@cixzhang, any suggestions?

Woo hoo, it's working in Travis. @cixzhang, please review.
I just added comments referring to the Chrome performance bug.


Fix for ObsidianOpen not working with links

Potential fix for #107
Summary
This change modifies the ObsidianOpen command to additionally check if Plenary's make_relative method fails by attempting to find the vault root directory in the path after the call to make_relative. If the vault root directory is found, the new implementation simply substitutes out everything up to and including the root directory in an attempt to make the path work.
Limitations

This method will not work if the link which the vault is behind is directly to the vault and the name of the link does not match the name of the vault. In this case, both make_relative and my proposed fix will fail. To fix this would require actually detecting if the vault is behind a link and following it in order to initialize the vault path as its absolute version from the get go. The only way I could find to accomplish this was to use an external library for Lua, which I figured might not be ideal to require as a dependency for what is really a bit of a niche bug.
This will also fail if the user happens to keep their note in a subfolder of their vault which shares the same name as the vault itself. This seemed like a more unlikely scenario than someone wanting their vault directory to be behind a link, which would justify the change.
I believe I have accounted for Windows paths as well, though I imagine that links will look and function differently in Windows. This change may not work for Windows users as a result. That said, it shouldn't break any existing instances that were already working.

I was toying with the idea of mentioning the issue somewhere in the README, but wasn't sure how to phrase it given that it should work properly for most everyone now.

I like the idea of adding a "## Known issues" section, and I think saying something like "this is edge case that won't affect most people" is fine.

@epwalsh Went ahead and added the README section


Add highlighting group gitrebaseDrop

Not sure why it's missing; all the other commands are there.

Please discuss this with the current syntax file maintainer. See the header of the file for the contact address. See also Contributing.md

/cc @tpope

Looks good; submit at vim-git.


Fix global partial aggregation state reset and output row counting is…

This PR fixes two issues: (1) current code doesn't reset the global intermediate aggregation state on partial full flush such as the case found in production query replay a single aggregation state could be very large; (2) the current output flush counting runtime stats is not reliable. It doesn't handle global case so that the actual count value is always zero. Also the table has already been cleared on the last output. This PR add a counter in HashAggregation to track the output rows explicitly.

@xiaoxmeng PR title and description become commit messages. Here is what these look like for this PR:
879dbcb3 Fix global partial aggregation state reset and output row counting is… (#2085)

Notice the commit title is not quite right.
The commit message is a single-line which makes it hard to read. Next time, please, wrap it at 80 characters.
% git show 879dbcb3

commit 879dbcb38757df96c0e8b44fab6a97f5a31fc3e1
Author: Xiaoxuan Meng<EMAIL_ADDRESS>Date:   Fri Jul 22 15:34:00 2022 -0700

    Fix global partial aggregation state reset and output row counting is… (#2085)

    Summary:
    This PR fixes two issues: (1) current code doesn't reset the global intermediate aggregation state on partial full flush such as the case found in production query replay a single aggregation state could be very large; (2) the current output flush counting runtime stats is not reliable. It doesn't handle global case so that the actual count value is always zero. Also the table has already been cleared on the last output. This PR add a counter in HashAggregation to track the output rows explicitly.

    Pull Request resolved: https://github.com/facebookincubator/velox/pull/2085

CC: @Yuhta


fix(atomic-storybook): add missing dependency to target dev when runn…

…ing atomic-storybook:dev
"dev" target was missing a dependency. When running npx nx run atomic-storybook:dev before every building, assets.json was never created.
Since "dev" and "build" are basically the same except for the command, I wonder if there is a way to refactor the two so they use the same dependencies.
https://coveord.atlassian.net/browse/KIT-2457

@aprudhomme-coveo , looks like your PR name might've been a bit long, try to make it concise ;)

LGTM! @btaillon , I wonder do you know if there'd be a way to refactor the 'dependsOn' between the build task and this one? 🤔

Could extract the common dependencies in a nx:noop target. It could be named something like prepare-and-validate.


nixos/hyprland: adds programs.hyprland.withUWSM option

Upstream recommends using UWSM for better compatibility with systemd integration.
https://wiki.hyprland.org/Useful-Utilities/Systemd-start/
Things done

Built on platform(s)

[ ] x86_64-linux
[ ] aarch64-linux

[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[ ] Fits CONTRIBUTING.md.

Add a :+1: reaction to pull requests you find important.

Oof, so if... else does not work under mkMerge?

Oof, so if... else does not work under mkMerge?

Try using mkIf. I assume if else causes an infinite recursion here?

Try using mkIf. I assume if else causes an infinite recursion here?

Done, and it works. Not really happy with the look though, condition and its inverted condition.


Event doesn't exist message

i will do it, assign me  the issue

I assign it to you thank you for the help


Deepcast Translation API

Extension – Deepcast Translation API
Author: @mooxl
Description
The extension for translating a selected word into a determined language does not work and leads to an error indication. Even though, the clipboard history shows the selected word. In contrast, the "translate" extension works perfectly well.
Steps To Reproduce

Copy a word
check if it's in the clipboard history
start the deepcast extension for a single language (e.g. "translate into German")

The current behavior
error indication:

please select the text to be translated

The expected behavior
Translating the word into the chosen language
Raycast version
Version: 1.35.2

I faced the same issue.
I'm sure we should copy any sentence before using commands (e.g. Translate Into XXX)
https://github.com/raycast/extensions/pull/947
However, It's not working (Showed the error, "Please select the text to be translated"). My version is 1.43.2.
Any idea? @mooxl @pernielsentikaer @sxn

Do you have the possibility to look into this @mooxl

Will rework this in the coming weeks:) @pernielsentikaer


Mzmlframe merging

A simple tool to merge mobility scans into a summed frame spectrum.
For now, i have decided to not use the original raw data file and the original frames to store the merged data. However, this is debatable. Nevertheless, since there is no data in those frames prior to merging and the bruker library merging does the merge on request, too, i decided to implement it this way for now.

Sounds great to me, at least this approach is universal and doesn't depend on the bruker library.


Ability to change the format of history_date in admin view

Problem Statement
Is there any way to change the format of history_date in admin?
e.g: I want to display history_date with the precise up to milliseconds in the admin views:

Describe the solution you'd like
It will be pleasure to have a config using for change the format of history_date
Describe alternatives you've considered
It can also be achieved by adding parameters in the body of HistoryView
Additional context
None

Happy to accept this if you want to submit a PR


[WIP] chore: Upgrade React Native CLI to 2.0.0-alpha.4

Summary
Upgrade React Native CLI to latest version that has a nice configuration interface so that we can avoid passing reactNativePath all the time.
This fixes Metro not starting when running runAndroid for RNTester.
This is WIP. Need to release 2.0.0-alpha.5 and then, update again.

This reverts temporary workaround shipped with https://github.com/facebook/react-native/commit/5558333c60c75b1ac68f3e248d2d393ec09e8c8a

Let me know once it is ready to be shipped.

Will reopen.


clang 3.7.1

Clang 3.7.1 on my laptop (and another to be specified later on JUQUEEN) seems to have a couple of problems in the code.
One is that the printers use in cprinter and cudaprinter the follow template instantation:
/home/apeyser/Code/eth-cscs/nestmc-proto/modcc/cprinter.cpp:308:16: error: no matching function for call to 'is_in'
       return is_in(k, {procedureKind::normal, procedureKind::api, procedureKind::net_receive});
              ^~~~~
/home/apeyser/Code/eth-cscs/nestmc-proto/modcc/modccutil.hpp:10:6: note: candidate template ignored: couldn't infer template argument 'N'
bool is_in(T thing, const T (&list)[N]) {
    ^
/home/apeyser/Code/eth-cscs/nestmc-proto/modcc/cprinter.cpp:315:16: error: value of type 'void' is not contextually convertible to 'bool'
           if(proctest(proc->kind())) {
              ^~~~~~~~~~~~~~~~~~~~~~

Changing it to static const procedureKinds[] ks = {} and using that in the is_in call works for both.
The following causes a clang segment violation:
    std::transform(ps.begin(),ps.end(),qs.begin(),rs.begin(),
        [](int p,int q) { return *( provided(q!=0) >> [=]() { return p/q; } | -1 ); });

I'm not sure what's causing that, but the report is:
1.	/home/apeyser/Code/eth-cscs/nestmc-proto/tests/unit/test_optional.cpp:345:77: current parser token '|'
2.	/home/apeyser/Code/eth-cscs/nestmc-proto/tests/unit/test_optional.cpp:339:790: parsing function body 'TestBody'
3.	/home/apeyser/Code/eth-cscs/nestmc-proto/tests/unit/test_optional.cpp:339:790: in compound statement ('{}')
4.	/home/apeyser/Code/eth-cscs/nestmc-proto/tests/unit/test_optional.cpp:345:9: lambda expression parsing
5.	/home/apeyser/Code/eth-cscs/nestmc-proto/tests/unit/test_optional.cpp:345:25: in compound statement ('{}')
6.	/usr/bin/../lib/gcc/x86_64-redhat-linux/5.3.1/../../../../include/c++/5.3.1/bits/move.h:76:5: LLVM IR generation of declaration 'std::forward'
7.	/usr/bin/../lib/gcc/x86_64-redhat-linux/5.3.1/../../../../include/c++/5.3.1/bits/move.h:76:5: Mangling declaration 'std::forward'
clang: error: unable to execute command: Segmentation fault (core dumped)
clang: error: clang frontend command failed due to signal (use -v to see invocation)
clang version 3.7.1 (tags/RELEASE_371/final)

It's buried somewhere inside the Haskell like optional definition. The definition is much too complex for me to see where in the mangling there could be an ambiguity that clang can't handle.

Yup -- if I transform it to a trinary operator, no problem.

Merged PR #122 addressing first part of this issue.

I'm not yet able to recreate the clang-3.7.1 issue locally; would you be able to give the CMake options, and perhaps the compilation log entry for test_optional.cpp?

Now I'm on 3.8.1, problem is gone, and is no longer reproducible. Thus can't even investigate.


New tokenization & integer parsing helpers

Reading through our existing patterns for integer parsing, I noticed
that we'd be better off returning them as optionals.
This also allowed me to improve the implementation to support integers
all the way up to their absolute maximum/minimum.
Furthermore, I noticed that prefix_split was unsound:
If the last needle character was the last character in the remaining
text, the remaining text would be updated to an empty string view.
The caller would then have no idea if there's 1 more token left
or if the string is truly empty.
To solve this, this PR introduces an iterator class. This will allow
it to be used in our VT parser code.

CI passed but ARM64 is being a drama queen. 😅

/azp run


[Grid] setting spacing to 0 by default

Related to https://github.com/callemall/material-ui/issues/7549
BREAKING CHANGE

[x] PR has tests / docs demo, and is linted.
[x] Commit and PR titles begin with [ComponentName], and are in imperative form: "[Component] Fix leaky abstraction".
[x] Description explains the issue / use-case resolved, and auto-closes the related issue(s) (http://tr.im/vFqem).

Following my comment, https://github.com/callemall/material-ui/issues/7549#issuecomment-323570560. I think the default value best cover 80% of the use cases.

Instead, I would rather wait to see more people suggesting to change the default value. If a majority think that way, we can move forward. Thanks for the suggestion!

oops sorry, I misread your comment, I thought you were suggesting to change it.
it is fine for me as it is now.

:)


Improve s3 backend for DigitalOcean Spaces

This PR implements the improvements for DO Spaces discussed in #1457

Codecov Report

Merging #1459 into master will increase coverage by 0.97%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master    #1459      +/-   ##
==========================================
+ Coverage   51.62%   52.59%   +0.97%
==========================================
  Files         136      136
  Lines       13783    10859    -2924
==========================================
- Hits         7115     5711    -1404
+ Misses       5799     4279    -1520
  Partials      869      869

Impacted Files
Coverage Δ

cmd/restic/cleanup.go
34.28% <ø> (-0.5%)
:arrow_down:

internal/backend/backend_retry.go
43.75% <100%> (+11.09%)
:arrow_up:

internal/backend/layout_rest.go
68.42% <0%> (-5.5%)
:arrow_down:

internal/backend/layout_default.go
73.91% <0%> (-4.66%)
:arrow_down:

internal/backend/layout_s3legacy.go
77.77% <0%> (-4.05%)
:arrow_down:

internal/crypto/crypto.go
57.85% <0%> (-3.19%)
:arrow_down:

internal/walk/walk.go
75.82% <0%> (-3.13%)
:arrow_down:

cmd/restic/main.go
5.55% <0%> (-2.45%)
:arrow_down:

internal/pipe/pipe.go
70.19% <0%> (-2.22%)
:arrow_down:

internal/options/options.go
81.63% <0%> (-1.84%)
:arrow_down:

... and 121 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 812ce4b...0b44c62. Read the comment docs.


Update structure

Remove application folder in root

Directory structure:

root
|-- src
|--|-- application
|--|--|-- model
|--|--|-- controller
|--|--|-- view
|--|-- core
|-- public
|-- config
|-- bootsrtap
composer.json
README.md
LICENSE.md

root is not root folder


Fixed issue #14

Fixed this issue

This pull request leads in upside down preview in landscape mode at nexus 5x in the Demo app


Video in -> images -> video out

Includes:

Multi-stage ffmpeg build with cuda support
MediaMTX for video in and out + config
Python listener to handle ffmpeg / video (frames2video.py)
Runtime dockerfile using multiprocess (can not shut this down cleanly)
README updates explaining how to set up and run the containers

Probably should be merged with the other WIP PR - #212
There is not much of an interface yet for the python parts
given an input <stream-name> transcoded outputs will be available under <stream-name>/out
Also see https://github.com/livepeer/ai-worker/pull/209 for more details on how to use / test this

Superseded by https://github.com/livepeer/ai-worker/pull/253


feat: adaptations for leanprover/lean4#3159

Adaptations for leanprover/lean4#3159, written by @mhuisi. These changes have already landed in nightly-testing: this is a PR to bump/v4.6.0.

Thumbs up from @mhuisi on zulip, so hitting merge.


ElectronNET.CLI does not contain an inclusive lower bound

This is my .csproj:
<Project Sdk="Microsoft.NET.Sdk.Web">

  <PropertyGroup>
    <TargetFramework>netcoreapp2.0</TargetFramework>
  </PropertyGroup>

  <ItemGroup>
    <PackageReference Include="ElectronNET.API" Version="0.0.7" />
    <PackageReference Include="Microsoft.AspNetCore.All" Version="2.0.3" />
  </ItemGroup>

  <ItemGroup>
    <DotNetCliToolReference Include="Microsoft.VisualStudio.Web.CodeGeneration.Tools" Version="2.0.1" />
  </ItemGroup>

  <ItemGroup>
    <DotNetCliToolReference Include="ElectronNET.CLI" Version="*" />
  </ItemGroup>

</Project>

My error:
NU1604: Project dependency ElectronNET.CLI does not contain an inclusive lower bound. Include a lower bound in the dependency version to ensure consistent restore results.
What dependency do I have to upgrade? I do not understand
I follow readme installation guide and I got stuck when I added this piece of code to .csproj
<ItemGroup>
         <DotNetCliToolReference Include="ElectronNET.CLI" Version="*" />
</ItemGroup>

Thanks
Andrea

Hi Andrea,
did you type the "dotnet restore" command after you edited the .csproj file?
When and where did you get the error message?

I create new project in another machine.
After execute:
dotnet electronize start
There is an error:

After that I clear .\obj folder but without success.
This example work very well.

Do you use first the dotnet electronize init command?

Yep

Can you share your project?

Project

I will update the documentation - thanks for sharing!

My .csproj file contents are these.

But when I enter this command-
dotnet electronize start
Then I got this error. What is the solution?


Tunnel not reaching rest of Tunnel

Sometimes the tunnel paths do not reach the other parts, see screenshot
Image bellow is using a seed of 100

Another example is


CDD-2123: New simplified line chart

Description
This PR includes a new simplified ChartType for displaying Timeseries data. The chart provides a single line chart with 4 axis labels. The metric value (y-axis) for the top of the chart is rounded and displayed as a short string. Eg: 1400 = 1k
Fixes #CDD-2123

Type of change
Please select the options that are relevant.

[ ] Bug fix (non-breaking change which fixes an issue)
[x] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[ ] Tech debt item (this is focused solely on addressing any relevant technical debt)

Checklist:

[x] I have commented my code, particularly in hard-to-understand areas
[ ] I have made corresponding changes to the documentation
[x] I have added tests at the right levels to prove my change is effective
[x] I have added screenshots or screen grabs where appropriate
[x] I have added docstrings in the correct style (google)

Have you checked what the alt_text chart output looks like for these new chart types?

Good call, this needs an update. The detail is now much more than is presented with the simplified chart so it doesn't feel like it represents whats being displayed. I've broken this out into its own ticket CDD-2204.


Jenkins upgrade to latest LTS:2.440.2

Is your feature request related to a problem? Please describe
We are currently running Jenkins 2.387.1, and are planning to upgrade it to the latest LTS version, 2.440.2.
There are CVEs and bugs pending to be fixed by upgrading Jenkins core to higher version
https://github.com/opensearch-project/opensearch-build/issues/3727
Describe the solution you'd like
Upgrade Jenkins version to the latest LTS version.
At the time this issue is created, the latest LTS version is 2.440.2
https://www.jenkins.io/doc/upgrade-guide/
Ref to the previous upgrade, here are the steps to follow:

[ ] 1. Upgrade docker image: Docker is the source of jenkins in this setup. Sample PR https://github.com/opensearch-project/opensearch-ci/pull/278
[ ] 2. Upgrade Java (current Java 11): We should also consider upgrading Java version to 17 or 21 as the Jenkins will require Java 17 or 21 and drop support for Java 11 ETA in Fall 2024
https://www.jenkins.io/blog/2023/11/06/introducing-2-2-2-java-support-plan/#:~:text=Jenkins 2.426.,releases at any given time.
[ ] 3. Bump jenkins core version in build.gradle: Associated repos https://github.com/opensearch-project/opensearch-build, https://github.com/opensearch-project/opensearch-build-libraries
[ ] 4. Add documentation on how to upgrade. Documentation should mention EBS backing up as well.

Describe alternatives you've considered
N/A
Additional context
N/A

Regarding the update of Java of our Jenkins nodes, we have the option to upgrade to either JDK17 or JDK21. Docker Hub currently provides support for both versions on the LTS 2.426.3:
For JDK21: 2.426.3-lts-jdk21
For JDK17: 2.426.3-lts-jdk17
Given that JDK21 is relatively recent, and taking into account Jenkins' commitment to maintaining support for JDK17 until the early 2026, would it be ok for us to proceed with the upgrade to JDK17 for now?

We decided to move on with using JDK17

We have decided to move on with using JDK21 becasue it will be officially supported until 2029

Related windows issues:
https://issues.jenkins.io/browse/JENKINS-73202

We are changing to use jenkins:2.426.3-lts-jdk21.

Jenkins  is successfully upgraded to 2.426.3


[wallet] UX fixes for native phone number

Description

Changed logging from error to info to prevent red screen when user dismiss the modal
Don't trigger the modal if there's text in the input
Differentiate between US and Canada phone numbers to show the right country.

Tested

Manually and added tests.

Other changes

Related issues

Fixes #1699
Fixes #1703
Fixes #1701

Backwards compatibility

Removing automerge, see @annakaz 's comment

Thanks to @jeanregisser I figured out a way to differentiate USA vs Canada and should be working fine now.

Should be good to go! @annakaz


Mob Damage

Depend on #9

Add data for mob life
When player hit the mob lower the life of the mob
Play effect for mob damage
Play sound for mob damage

oups

oups


Transparency broken after recent update

Description
I've been publishing some 3D models to IPFS using model-viewer called externally to display them

Up until about a couple of hours back the model was visible as in the above image, but if I go to it now via Mobile or desktop it is distorted, zoomed out and seems to contain an additional transparent artefact

With IPFS there should not have been any change to my file from when it was working until when it wasn't - so I'm wondering if something might have changed in a recent update.
Live Demo
https://bafybeibcu6a7vj47jfpjnv763wue2vdkrkpylrggknmwkssj2uumjc77gm.ipfs.infura-ipfs.io/
Version

model-viewer: v1.7.0

Browser

[x ] Chrome, version: xx.x.xxxx.xx
[x ] Edge
[x ] Firefox
[ ] IE
[ x] Safari

OS

[ x] Android
[ x] iOS
[ ] Linux
[ ] MacOS
[ x] Windows

Please don't cross-post.


feat: backup SLOs

What
Add SLOs as a resource to backup in code.
Why
We're starting to rely on Datadog's implementation of Service Level Objectives pretty heavily. We also use the backups we take of our monitors and dashboards to determine whether custom metrics are being used (or not). We'd like to be able to find out if metrics/tags are also being used in any SLOs.
Docs
https://github.com/scribd/datadog_backup/issues/154

It occurs to me that it would be more consistent with the other resource types if what was stored on disk was in the same schema as necessary for updating the resource. Therefore, I think it could make sense to dig one level deeper and capture the elements inside the data key. What do you think about this approach, @lewhit?


Can't find the feature under feature management that is mentioned in the docs site

[I can't find the below feature under feature management:
To view summary data from the general journal account entry, enable the Amount details from the General journal account entry are displayed on the Trial balance with transactional detail report feature.
I have the following platform version installed:
Installed product version : 10.0.25 (10.0.1149.131)
Installed platform version : Update49 (7.0.6316.102)
]

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 73deae8d-c248-76f5-8772-ae716556357f
Version Independent ID: 2b2fe1f0-b294-20e2-78ab-f7c3533cb334
Content: Trial balance with transactional detail report - Finance | Dynamics 365
Content Source: articles/finance/public-sector/general-ledger-public-sector-trial-balance.md
Service: dynamics-365-finance
Product: ****
Technology: ****
GitHub Login: @v-kiarnd
Microsoft Alias: v-kiarnd

@sbaber82 , all three of the mentioned features appear in 10.0.28 (see below). The feature you are asking about looks to have been added in March 2022, so that probably means you need version 10.0.26 or later to see it.

Thank you for contacting us regarding this help topic. I have forwarded your comment to the topic author for further consideration.

Thanks for the confirmation.I think it would be good to mention, under which build the feature has become available, just to avoid any confusion.

Thanks @sbaber82 . We don't usually mention version requirements for features in feature management because each version goes to auto-update 2-3 months after release, so this info goes quickly out of date. However, you are right that it is important info during that period. I will discuss our policy with the publishing group, but I will close this issue for now.


error: failed to run custom build command for libudev-sys v0.1.4

Greetings,
I am new to rust and trying to do cross compilation. However while doing that I am getting an error error: failed to run custom build command for libudev-sys v0.1.4 . I tried following the solution at
https://github.com/dcuddeback/libudev-sys/issues/7
However, I was not able to resolve the issue. I am using Ubuntu 20.04 and want to cross compile for raspberry pi.
It would be great if someone can provide me an insight to what should I include in the
build script.
#!/bin/sh

SYSROOT=/build/root

export PKG_CONFIG_DIR=
export PKG_CONFIG_LIBDIR=${SYSROOT}/usr/lib/pkgconfig:${SYSROOT}/usr/share/pkgconfig
export PKG_CONFIG_SYSROOT_DIR=${SYSROOT}
export PKG_CONFIG_ALLOW_CROSS=1
# tell pkg-config where to find libudev.pc
export PKG_CONFIG_PATH=/usr/lib/arm-linux-gnueabihf/pkgconfig
# tell cargo to link with an armhf compatible linker
export CARGO_TARGET_ARMV7_UNKNOWN_LINUX_GNUEABIHF_LINKER=arm-linux-gnueabihf-gcc

cargo build --release --target=armv7-unknown-linux-gnueabihf

Any help would be much appreciated

I got the similar error message in rust docker container:
error: failed to run custom build command for `libudev-sys v0.1.4`
Caused by:
  process didn't exit successfully: `/builds/zhangruihuai/playground-rust/tci-linux/target/debug/build/libudev-sys-d387404a27cfd86d/build-script-build` (exit status: 101)
  --- stdout
  cargo:rerun-if-env-changed=LIBUDEV_NO_PKG_CONFIG
  cargo:rerun-if-env-changed=PKG_CONFIG_x86_64-unknown-linux-gnu
  cargo:rerun-if-env-changed=PKG_CONFIG_x86_64_unknown_linux_gnu
  cargo:rerun-if-env-changed=HOST_PKG_CONFIG
  cargo:rerun-if-env-changed=PKG_CONFIG
  cargo:rerun-if-env-changed=LIBUDEV_STATIC
  cargo:rerun-if-env-changed=LIBUDEV_DYNAMIC
  cargo:rerun-if-env-changed=PKG_CONFIG_ALL_STATIC
  cargo:rerun-if-env-changed=PKG_CONFIG_ALL_DYNAMIC
  cargo:rerun-if-env-changed=PKG_CONFIG_PATH_x86_64-unknown-linux-gnu
  cargo:rerun-if-env-changed=PKG_CONFIG_PATH_x86_64_unknown_linux_gnu
  cargo:rerun-if-env-changed=HOST_PKG_CONFIG_PATH
  cargo:rerun-if-env-changed=PKG_CONFIG_PATH
  cargo:rerun-if-env-changed=PKG_CONFIG_LIBDIR_x86_64-unknown-linux-gnu
  cargo:rerun-if-env-changed=PKG_CONFIG_LIBDIR_x86_64_unknown_linux_gnu
  cargo:rerun-if-env-changed=HOST_PKG_CONFIG_LIBDIR
  cargo:rerun-if-env-changed=PKG_CONFIG_LIBDIR
  cargo:rerun-if-env-changed=PKG_CONFIG_SYSROOT_DIR_x86_64-unknown-linux-gnu
  cargo:rerun-if-env-changed=PKG_CONFIG_SYSROOT_DIR_x86_64_unknown_linux_gnu
  cargo:rerun-if-env-changed=HOST_PKG_CONFIG_SYSROOT_DIR
  cargo:rerun-if-env-changed=PKG_CONFIG_SYSROOT_DIR
  --- stderr
  thread 'main' panicked at 'called `Result::unwrap()` on an `Err` value: "`\"pkg-config\" \"--libs\" \"--cflags\" \"libudev\"` did not exit successfully: exit status: 1\nerror: could not find system library 'libudev' required by the 'libudev-sys' crate\n\n--- stderr\nPackage libudev was not found in the pkg-config search path.\nPerhaps you should add the directory containing `libudev.pc'\nto the PKG_CONFIG_PATH environment variable\nNo package 'libudev' found\n"', /usr/local/cargo/registry/src/github.com-1ecc6299db9ec823/libudev-sys-0.1.4/build.rs:38:41
  note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace
warning: build failed, waiting for other jobs to finish...
ERROR: Job failed: exit code 1


fix(Client): Ensure fetch method is uppercase

I'm using the Notion SDK in a somewhat unusual environment—a plugin for Zotero. Zotero is built on the Firefox platform and thus provides a browser-like environment.
I ran into an obscure issue where retrieve and create methods worked just fine, but update methods failed with an unknown network error. I eventually determined the issue was that the method passed to fetch() needed to be uppercase—PATCH instead of patch.
I'm not sure why this isn't an issue for the lowercase get and post requests used by the retrieve and create methods. I'm also not sure why the conversion to uppercase performed by node-fetch isn't working. Perhaps the fetch() call is bypassing the node-fetch version and using the environment's built-in fetch() method?
Whatever the cause may be, this PR contains a simple fix for the issue.
While waiting for this to get merged into the official package, I've published my own version that I'm currently using in my project.

using this library in a chrome plugin also results into patch being lowercase
following response is recevied

<title>400 Bad Request</title>

400 Bad Request

cloudflare

@wcauchois I see you're the most recent person to push to main. Any chance we could get a review on this bug fix PR? Thanks!


[BUG]: Documentation - RWOP mode has been GAd and it does not need alpha gates anymore

Bug Description
Documentation - RWOP mode has been GAd and it does not need alpha gates anymore
Logs

Screenshots
No response
Additional Environment Information
No response
Steps to Reproduce

Expected Behavior
Doc update
CSM Driver(s)
All
Installation Type
No response
Container Storage Modules Enabled
No response
Container Orchestrator
NA
Operating System
NA

/sync


Don't validate arguments if help or version is used and exitProcess=false

Currently if exitProcess=false and the help or version options are given the arguments will be validated anyhow.
I'd argue that this is never the desired behavior. For example, if there are required arguments then if the users enters node . --help he would get errors for every required arguments missing.
This PR fixes this.

Awesome! LGTM at first blush. :+1:

@bcoe See any problems with this PR? It looks good to me. I'd like to land this and publish a new release.

@nexdrew this seems great to me, if you sign off I sign off :+1:

@bcoe Merged. What do you think, publish 3.27.0 now or wait until the wrap-ansi -> cliui enhancements are released?

@nexdrew no need to block on wrap-ansi, might take a bit longer to make all those ducks line up.

@bcoe Ok, I'll go ahead and publish 3.27.0. Thanks!


'AmpOptimizerState' object has no attribute 'all_fp16_params' when Trainer amp_level

Problem
I encounter some questions when using Trainer.
Because I used precision=16 and amp_backend='apex' and amp_level='O2' in Trainer class.
But ger some error. Hope someone can help.
Traniner code
import pytorch_lightning as pl

trainer = pl.Trainer(gpus=1,
                     precision=16,
                     amp_backend='apex',
                     amp_level='O2',
                     max_epochs=2,
                     logger=logger,
                     callbacks=[checkpoint_callback])

trainer.fit(model, train_dataloader, valid_dataloader)

Error Message
/usr/local/lib/python3.6/dist-packages/pytorch_lightning/utilities/distributed.py:45: UserWarning: You have set progress_bar_refresh_rate < 20 on Google Colab. This may crash. Consider using progress_bar_refresh_rate >= 20 in Trainer.
  warnings.warn(*args, **kwargs)
GPU available: True, used: True
TPU available: False, using: 0 TPU cores
LOCAL_RANK: 0 - CUDA_VISIBLE_DEVICES: [0]
Using APEX 16bit precision.
Selected optimization level O2:  FP16 training with FP32 batchnorm and FP32 master weights.

Defaults for this optimization level are:
enabled                : True
opt_level              : O2
cast_model_type        : torch.float16
patch_torch_functions  : False
keep_batchnorm_fp32    : True
master_weights         : True
loss_scale             : dynamic
Processing user overrides (additional kwargs that are not None)...
After processing overrides, optimization options are:
enabled                : True
opt_level              : O2
cast_model_type        : torch.float16
patch_torch_functions  : False
keep_batchnorm_fp32    : True
master_weights         : True
loss_scale             : dynamic

| Name  | Type                            | Params
----------------------------------------------------------
0 | model | AlbertForSequenceClassification | 4.1 M
/usr/local/lib/python3.6/dist-packages/datasets/arrow_dataset.py:850: UserWarning: The given NumPy array is not writeable, and PyTorch does not support non-writeable tensors. This means you can write to the underlying (supposedly non-writeable) NumPy array using the tensor. You may want to copy the array to protect its data or make it writeable before converting it to a tensor. This type of warning will be suppressed for the rest of this program. (Triggered internally at  /pytorch/torch/csrc/utils/tensor_numpy.cpp:141.)
  return torch.tensor(x, **format_kwargs)
Epoch 0: 0%
0/873 [00:00<?, ?it/s]
/usr/local/lib/python3.6/dist-packages/pytorch_lightning/utilities/distributed.py:45: UserWarning: training_step returned None if it was on purpose, ignore this warning...
  warnings.warn(*args, **kwargs)
---------------------------------------------------------------------------
AttributeError                            Traceback (most recent call last)
<ipython-input-9-73afea14b588> in <module>()
     11 trainer.fit(sms_model,
     12             train_sms_ds_dataloader,
---> 13             valid_sms_ds_dataloader)

10 frames
/usr/local/lib/python3.6/dist-packages/apex/amp/_process_optimizer.py in _master_params_to_model_params(self)
     15     stash = self._amp_stash
     16     if multi_tensor_applier.available:
---> 17         if len(stash.all_fp16_params) > 0:
     18             multi_tensor_applier(
     19                 stash.multi_tensor_scale,

AttributeError: 'AmpOptimizerState' object has no attribute 'all_fp16_params'

Reference link
https://github.com/NVIDIA/apex/issues/341
I found the same problem in torch train loop. So, i not sure whether it is lib problem.
Hope someone can help and answer. I will thanks a lot.

BTW, if i change amp_level to O1, the error message is be changed. As Follows:
---------------------------------------------------------------------------
PicklingError                             Traceback (most recent call last)
<ipython-input-9-b1f016bd9c81> in <module>()
     11 trainer.fit(sms_model,
     12             train_sms_ds_dataloader,
---> 13             valid_sms_ds_dataloader)

18 frames
/usr/local/lib/python3.6/dist-packages/torch/serialization.py in _save(obj, zip_file, pickle_module, pickle_protocol)
    474     pickler = pickle_module.Pickler(data_buf, protocol=pickle_protocol)
    475     pickler.persistent_id = persistent_id
--> 476     pickler.dump(obj)
    477     data_value = data_buf.getvalue()
    478     zip_file.write_record('data.pkl', data_value, len(data_value))

PicklingError: Can't pickle <function gelu at 0x7f7243aa7ea0>: it's not the same object as torch.nn.functional.gelu


fabo/force recover ibc txs

because of the wrong ack bug txs get stuck in the queue. we need to force recover those transactions or they will be stuck in the contract. forced recovery should only be done by an admin

Will need a version bump of the contract too


Adding ESLint

I split this PR in 3 commits:

The rules
The changes eslint was able to automatically do.
Manual changes I had to make to remove the final errors (mostly unused variables)

Happy to make changes to the rules if there's anything you don't like about the style it decided on, and also happy to elaborate on why I made certain choices. Some are obviously stylistic, but there's also a few that help reduce bugs.

Looks good, merge when ready.


Add vim setting for ISO layout compatibility (sdl2)

As discussed in #388, I have created a new vim setting to differentiate between ANSI and ISO layout to handle the Right Alt/Alt Gr key properly. I added an optional setting neovide_iso_layout that can be set to true when necessary.
At the moment, the fix only applies to sdl2. Winit doesn't differentiate between left and right Alt and I don't know how to fix this problem without heavily modifying how the input is handled.
Because this is potentially affecting many users, I opened a PR with only the sdl2 fix. That way, at least, will be solved for some people.
Let me know if you have any suggestion.

@ref209 would you be willing to make a documentation change in the wiki to fix document what this setting does?


https://nuxtjs.org/ SSL Connection

https://nuxtjs.org/ is having SSL Connection Issues
Cloudflare is unable to establish an SSL connection to the origin server.
This page (https://nuxtjs.org/) is currently offline. However, because the site uses Cloudflare's Always Online™ technology you can continue to surf a snapshot of the site. We will keep checking in the background and, as soon as the site comes back, you will automatically be served the live version. Always Online™ is powered by Cloudflare | Hide this Alert
Error 525 Ray ID: ... • 2017-11-14 23:05:55 UTC
SSL handshake failed
nuxtjs.org/issues/87

https://github.com/nuxt/nuxtjs.org/issues/87

Archive.org has a reasonable back-up at https://web.archive.org/web/20170610090431/https://nuxtjs.org/guide/installation/

Fixed now :)
https://nuxtjs.org/
Sorry for inconveniences.


showSaveIcon: true, adds some space in table rows, but not in table headers.

showSaveIcon: true, adds one column in table rows, but not in table headers.
And as Flex: 1 is used in headers, if there are 4 headers, each will take total 1/4th of the space, but in rows, some space will go for the save icon.
Result:

Thank you @Amitbhave this issue is fixed temporarily in the new release v1.0.4. hence closed


Importing from server exports local files back to the server

Brackets v1.3
AEM Brackets Extension v0.0.12
Windows 7 64bit
AEM 6.0 (This issue was noticed on an Adaptive Forms only project)
Issue:
When importing from server, locally held files get pushed to the server.
Steps to reproduce:
Have an AEM project already imported on a local machine.
Make a change in CRXDE or in the form designer.
Attempt to update local files with ones on the server by right clicking "jcr_root" and doing "import from server".
Expected outcome
Clicking "import from server" on root folder updates locally held files with latest files that are on the server.
Actual outcome
Local files get uploaded to the server instead of being updated with the new version from the server.
If I do the above steps but do the import on the .content.xml of the form, everything in that file disappears and the form is totally broken!
Context
After working in CRXDE, making styling changes etc or making changes to forms, doing "import from server" on the jcr_root folder, it will actually export the local files to the server.
The project is effectively rolled back to an earlier version.
Deleting the files and re importing allows you to get the files locally to submit to version control but it still doesnt fix the issue where if you change something on the form, the changes get reverted on import.
This problem comes and goes and its very hard to pin down exactly what's causing it. If anyone has suggestions on how to track it down more effectively, I'd love to hear them.

This happens because automatic sync/exports is triggered by filesystem changes. When the import happens the filesystem will fire change events and trigger exports to server. This could be fixed if we disable automatic sync/exports during import phase.

That does sound familiar :-) In the Eclipse plugin we associate a timestamp property with each imported file. When exporting we check the last modified date ; if it's older or equal to the import timestamp we skip the export, otherwise we perform the export and clear the import timestamp.

Thanks for the replies. It would be great if you could separate the sync and import/export functions.
Maybe there could be an extra option in the AEM dropdown where you can turn on or off automatic sync.

I'm working on some improvements related to sync, I'll consider both
suggestions.
Thanks,
Vlad
On Monday, June 15, 2015, paullh<EMAIL_ADDRESS>wrote:

Thanks for the replies. It would be great if you could separate the sync
and import/export functions.
Maybe there could be an extra option in the AEM dropdown where you can
turn on or off automatic sync.
—
Reply to this email directly or view it on GitHub
https://github.com/Adobe-Marketing-Cloud/aem-sightly-brackets-extension/issues/44#issuecomment-112118818
.

--
Sent from mobile


update docker-ce install page with details about releases

Proposed changes

Update the docker-ce install landing page with details about the release process and cadence.
Unreleased project version (optional)

Related issues (optional)

Deploy preview for modest-edison-79d82e ready!
Built with commit 15e0f11c9a5d154637a861b9b8d85b34c64a8494
https://deploy-preview-7048--modest-edison-79d82e.netlify.com


[AutoRelease] t2-containerservice-2021-03-11-62611(Do not merge)

Please Add the link issue

/check-enforcer override


Saving object with modified primary key

I've tried searching for a similar issue but couldn't find any (here at least, I did find something similar but with no clear solution on the forums).
How can I save an object if the PK has been modified ? The log shows that new PK is used in the WHERE clause (e.g: Original PK was 25)

[2015-08-09 07:20:43] defaultLogger.INFO: UPDATE author SET ID=55 WHERE author.ID=55 [] []

Sandbox: http://sandbox.propelorm.org/486a545
The only solutions I could think of were:

Deleting the old object and saving a new one with the new PK
Use a SQL query instead of set... and save()

Thanks :wink:

I think this issue explain another weird behavior with cross-ref and primary keys that cannot be updated once the record has been created.

I think a possible (and the easiest) solution would be to store the Pk when the object is created in another variable called originalPK or something.

Is someone able to make a PR here with suggested changes?

Is anyone on this behaviour? Otherwise, I would try.
Meanwhile: A workaround could be copying the object.

Go for it

I created a pull request for that. https://github.com/propelorm/Propel2/pull/1896


invoke fails on windows

invoke runtests
You indicated pty=True, but your platform doesn't support the 'pty' module!
Unfortunately pseudo terminal handling is not available for Windows, and the pty=true flag prevents you from invoking runtests. Most people are probably not doing the frustrating thing of trying to run things in Windows like I am, but just case, I know one solution mentioned was to put in an os check.

I looked around a bit and you should be able to do something like:
import sys
# ...
pty = sys.platform != 'win32'

I'm also wondering whether or not to file something against invoke ... I feel like it should warn and skip the pseudo terminal rather than bailing out, but I can see the case for how it works now.

I ran into similar/other issues with using windows directly. It may or may not be worth it to stub out an issue regarding Windows support/issues?
@bonfirefan were you able to get up and running? Alternative, if you're familiar with using Docker I recently added a Dockerfile that you could use to run on Windows instead

Hey there! I would love to test out the dockerfile - I ended up switching completely to Linux, though!

@bonfirefan, btw, when i started using pipenv to manage dependencies this problem completely went away, even on windows!


Feature Proposal: Implement Pandas Profiling column statistics extractor

Pandas profiling (https://github.com/pandas-profiling/pandas-profiling) is a tool widely used for calculating reports on tables. It returns parsable json reports with quantile/descriptive statistics on column level. This PR proposes to develop PandasProfilingColumnStatsExtractor to populate TableColumnStats entities.
Expected Behavior or Use Case

new extractor exists parsing pandas-profiling reports to TableColumnStats

Service or Ingestion ETL

databuilder

Possible Implementation

rely on pandas profiling json report to collect metadata

cc @sbrugman


Empty editor scrollup after splitting

Requirements

Filling out the template is required. Any pull request that does not include enough information to be reviewed in a timely manner may be closed at the maintainers' discretion.
All new code requires tests to ensure against regressions

Description of the Change

Fix #15584. Our change consisted of the editor's resolution being empty when dividing a page and scrolling up. For this, we did an if that checks the file extension. If the extension is ".md" (type "Markdown"), we make the extension ".txt" (type "Plane Text").  The changes are in the file tokenized-buffer.js, in the function setGrammar(grammar).

Alternate Designs

None.
Why Should This Be In Core?

This changes fixed bug #15584. Editor isn’t empty if you scroll up after splitting already.
Benefits

Atom’s users can already scroll by dividing the page and the editor is not empty.
Possible Drawbacks

The file is no longer of the "Markdown" type and always becomes a "Plain Text".
Applicable Issues

Editor is empty if you scroll up after splitting #15584.

@luismsaraiva I know this has been open for a while now. I will have to close this for now on 2 grounds

This PR doesn't fix the scrollbar position after splitting. And the approach taken would not work when splitting other file types.
The cloned repo used to open this PR has long been deleted which signals the author doesn't have time to work on it.

Let me know If you are still interested to work on this. Happy to reopen this.
Thank you for your contribution.