theme: update header and navigation according to the new grav learn theme

The "upstream" grav learn theme has updated it's design and is now based on https://github.com/getgrav/grav-theme-learn4.
What I like about it is that the header now more cleanly sticks to the top of the page and extends to both sides.
This is fairly simple to achieve by just moving the #top-bar div element into the #body div.
However what I like even more about their updated theme is that the navigation buttons are now nicely positioned in the top right of the header. I find this to be a lot more subtle than the gigantic navigation bars (less "in your face"), but also functionally better since you do not need to move your mouse left and right as much:

I have kinda hacked it together on my part (without media queries yet), but I am also not a 100% satisfied with my code changes, so I thought I would leave this here as a feature reuqest, because @McShelby you are probably more into the code than I am at this point and maybe you will find it trivial to make this change.
I am in general more routined in using flex(which grave learn theme actually uses) than using floats everywhere.
If you want me to show the code let me know, or if you can implement it easily I would be very happy :)
EDIT:
In general what I did was to move <div id="navigation"> from footer.html to header.html
Then you "just" need to adjust the css, so in my case I added this to theme.css:
#navigation {
    position: relative;
    top: 23%;
    float: right;
}

In #body .navI removed position:fixedand I change font-size to 25px in there.
That's basically all I did and it semi-works :)

Interesting change.
I haven't found a demo site for grav-theme-learn4, so I can only make assumptions from your image.
I agreee, navigation is a topic in need of improvement. There are a lot of moving parts involved and all must be taken into account in their entirety.
So it's not just the header bar and its content, but also their visuals:

TOC
breadcrumb nav
GitHub edit link
prev/next nav
shadow on header bar while scrolling
prev/next changes on resolution change

Making changes to this would change some iconic visuals of the theme. As a dropin replacement for the hugo-theme-learn, this is a really difficult one to decide. As I think, the hugo-theme-learn theme has become independent to its grav counterpart, we don't necessarily need to go the same lane as they did.
What I don't want is to support a "second skin" inside of the theme. Other themes tried that in the past and haven't had much love for all their supported skins.
Also, adding this to the existing CSS and hiding it behind a config parameter is also a hassle to test.
At this point, I still concentrate on bug fixes of the original theme and some smaller, easier to handle improvements. Your proposed change would be something to be considerd in the near future.

I haven't found a demo site for grav-theme-learn4, so I can only make assumptions from your image.

Sorry I forgot to put in the link, but I pretty sure they simply use it on their main documentation: https://learn.getgrav.org/17/basics/what-is-grav
In contrast, hugo-theme-lean seems to have been based on their older theme: https://github.com/getgrav/grav-theme-learn2 (look at the screenshot in the readme and you will know why^^).

So it's not just the header bar and its content, but also their visuals:

TOC
breadcrumb nav
GitHub edit link
prev/next nav
shadow on header bar while scrolling
prev/next changes on resolution change

TOC

Yes and no. While the TOC does not appear in their new theme (not sure if it did before, or if that was simply smth the hugo-theme-learn team decided to do), I think it is ok for it to stay where its at currently!

breadcrumb nav

Hm I am not sure how the breadcrumb nav would be influenced by this change?

GitHub edit link

Yes I did not take the GH Edit Link into account in my changes at all, simply because I did not have it active on my local build before. Personally, I do find the new one more visually pleasing, but I would be ok with it if it stays as it is.

prev/next nav

This would obviously need to change :D

shadow on header bar while scrolling

While I understand the concern, on my part it has been working flawlessly. The header modifications was one of the first things I did and I have never had issues with this particular change.

prev/next changes on resolution change

Yeah that's probably something to take into account, and it it why I decided against implementing this whole thing myself because I do not want to break your site obviously :)

So it's not just the header bar and its content, but also their visuals

Making changes to this would change some iconic visuals of the theme. As a dropin replacement for the hugo-theme-learn, this is a really difficult one to decide. As I think, the hugo-theme-learn theme has become independent to its grav counterpart, we don't necessarily need to go the same lane as they did.

I understand that completely switching to everything that grav did would be nonsensical. Which is why I focused myself on just those two aspects, which seem to be an actual visual and functional improvement (at least to me), while still being quite viable to implement without rearranging the whole look.
It seems more like a tweak to me, that does a lot to its visual appearance in positive way.
I agree, and I also see hugo-theme-learn as an independent counterpart of the grav theme. However I also see your relearn theme that way :) I see you have made a lot of small usability improvements which do a whole lot for the end-user - which is why I definitely will stay with your version of the theme :)
In the same spirit I suggested this feature request right here; as a hopefully (even visually) quite non-intrusive change, but still a decent Quality of Life improvement over the existing.
Obviously you should decide for yourself what feels right to you :)

Hey @McShelby I wish you a belated happy new year! :tada:
I would like to let you know that I would be still interested in the change, since we will definitely keep this style in our gobolinux documentation.
Since the new grav learn theme uses this style, I think it is justified for hugo-relearn-theme to follow it. The hugo-learn-theme is not really maintained, so sticking to their decisions should not be the deciding factor imo.
But I'd be happy to have this even just as an option.
Anyways if you consider this, I'm here to test this regularly and give you feedback if anything should break. Our organization is going to keep this style so we have an interest to keep it in a good shape.
Once you implement it on your side, I have a reference implementation and can even PR little improvements or bug fixes if necessary. But without a reference implementation I do not feel comfortable to make a PR about this. My code is really hacky and not mobile friendly at all. However all in all it was not that difficult of a change.
I hope that's understandable.
Either way, we will continue to use your theme  :stuck_out_tongue:

I see some advantages in the grav-learn4 design and still considering how to do it best. This is not a simple change and - as mentioned above - has a lot of moving parts.
I'ld really like to change the TOC handling with this change, too, as it is not usable on a touch device at the moment. The main UX degration with grav-learn4 in comparision to relearn is, that the TOC in grav-learn4 scrolls out of view. One solution would be to let it stay at a fixed position to the left, which comes with its own set of issues (like: what happens if the TOC is longer than screen height).
There was a PR in the hugo-theme-learn which may be a good starting point.

Hi @McShelby thank you for looking into this.

The main UX degration with grav-learn4 in comparision to relearn is, that the TOC in grav-learn4 scrolls out of view.

Can you explain what you mean here? How does it scroll out of view? The header is still fixed to the top when scrolling down, so the TOC icon stays at the top left corner.

I plan to get rid of the current TOC icon (and its MouseOver functionality) entirly. Instead I am thinking of implementing it as an aside as in the current grav-learn4.

I agree, personally I do not like the "mouse-over" TOC either.

(like: what happens if the TOC is longer than screen height)

How about being able to scroll the TOC in such instances?

As I thought this over, it's better to keep TOC changes in a separate issue...

Yes I agree, better to do one thing at a time.
And for this issue right here, the TOC design is irelevant as it works fine with both versions.

@McShelby btw if you want to check out my terrible implementation of this, be free to check out https://wiki.gobolinux.org/ :)
Also you can add us to your "Showcases" page if you think we deserve it :)

Definetly a starting point.
The arrows are in need for position adjustment but that shouldn't be to hard.
The edit button should be left of the arrows (as in grav-learn4) because on a mobile device the often used actions should be positioned near screen borders.
Offtopic: Nice color scheme. Did you need to hack the theme in order to achieve the "dark mode" look? I remember there was an open issue in the Learn theme for this. Just curious.

The arrows are in need for position adjustment but that shouldn't be to hard.

 However at that time I figured my time would be better spent on porting the actual documentation from a mix of mediawiki and md files ugh :)

The edit button should be left of the arrows (as in grav-learn4) because on a mobile device the often used actions should be positioned near screen borders.

Absolutely. I think what what demotivated me to fix it is that the design uses floats instead of flexbox to position the elements. So I came again back to my priorities.

Offtopic: Nice color scheme. Did you need to hack the theme in order to achieve the "dark mode" look? I remember there was an open issue in the Learn theme for this. Just curious.

Thank you. Absolutely, I just made my own theme-gobolinux.css. A dark/light mode button would be nice, but for now Im just sticking to the dark theme.
I will admit that I let myself being inspired by the https://darkreader.org/ extension to choose the right color balance, since it is doing a great job (in dynamic mode).

@McShelby Call me blind, but I cannot figure out what triggers the animation when hovering over the nav buttons:

Just can't find it.


disappearing colors on resourcing vimrc in neovim

In neovim terminals this happens sometimes only in 'terminal' or 'insert' mode.

Here it is in the same buffer but in normal mode.

No clue what's wrong.

I cannot reproduce the bug with the following step.
Save the following file as .nvimrc.test
set nocompatible
filetype off
set rtp+=/path/to/lightline.vim
filetype plugin indent on
set laststatus=2

Open neovim with nvim -u .nvimrc.test
Go to insert mode or execute :terminal.

I'll try figuring out how to reproduce it. I'm not sure right now.

@itchyny figured it out. It has to do with sourcing vimrc again.
https://www.youtube.com/watch?v=y2H0-5H7JVo&feature=youtu.be
I also tested with default vim-airline and it doesn't seem to affect them.

Please paste the minimal vimrc (which is under 20 lines at most) to reproduce the bug. Otherwise I cannot investigate the reason what causes the bug or even I do not know this is a bug of lightline or of other plugin or of Vim itself.

@itchyny were you able to watch the video?
I'll post a vimrc soon just give me a few.

Yes but I found no clue to reproduce. I close this issue because the issue report is less informative.

@itchyny sorry I didn't post the vimrc but did you watch the video?

Yes

filetype off
set rtp+=/usr/local/etc/dotfiles/nvim/plugged/lightline.vim
set rtp+=/usr/local/etc/dotfiles/nvim/plugged/Apprentice
filetype plugin indent on
set laststatus=2
colorscheme apprentice

It only happens if a colorscheme is set (I tried apprentice and solarized etc.
Steps to reproduce

Open neovim with the above as init.vim or use the -u option
Open a terminal with ':term'
Now type <c-> to leave terminal mode and then source the init.vim file with ':source pathtoinit.vim'
Now reenter terminal mode by pressing 'i'. Bam the colours should disappear.

I still cannot reproduce because I don't see what init.vim is.

@itchyny in neovim, the vimrc is called init.vim and its under $XDG_CONFIG_HOME/nvim/init.vim. This is a neovim problem.

I still cannot reproduce with the following steps.
 $ cat > ./vimrc
filetype off
set rtp+=/path/to/lightline.vim
set rtp+=/path/to/Apprentice
filetype plugin indent on
set laststatus=2
colorscheme apprentice
^D
 $ nvim -u ./vimrc<CR>
:terminal<CR>
^D<CR>
:so ./vimrc<CR>
:terminal<CR>

Am I doing incorrectly?

Ah, OK. It seems to be appeared on my environment.

great. hopefully you can figure out whats going on.

@itchyny forgot to reopen the issue, its still closed even though you could reproduce it.

@itchyny any updates on this? its still closed even though you managed to reproduce.

I don't want be bothered by the behaviour which occurs only in neovim, the editor which has different architecture of rendering compared to Vim.

@itchyny in that case i'll take a stab and see if I can fix it.

@itchyny it has to do with running hi clear in the colorscheme file. This resets the highlighting groups. For some reason lightline then doesn't then reset the terminal highlight groups. Do you know exactly how to fix this?

I fixed it, i'll create a PR

I'm having this issue on Vim 8 on OSX. Is it related? I saw that the PR changed a block that was in has('win32'), so could this fix be applied for osx, too?

@Billy- Please create a new issue if there's some trouble with environment info, precise steps expected behavior and minimal vimrc if possible.

I hope I'll be able to find the spare time to do that..


Dungeon World Official: add french translation ; add data-i18n for 'R…

Dungeon World Official: add french translation ; add data-i18n for 'Roll 1d6+1d8 for Moves'

Hey, thanks for the translation!
As a heads up for the future, you don't need to update all the other individual translation files for them to show on the site.  The important part is adding the "base" translation (which is usually in English, as it is with this sheet, though it can vary; the keys are the really important part) in translation.json.  You didn't do that here, so I'll do it manually.  The translation.json is then used by a script to add missing keys with no valid translation in those files or on crowdin (to which you should consider joining!).

Hello Jeffrey,
Ok, thanks for the explanations about translation.json.
I will look into crowdin. I created a python script with regex to create
the json from the html file, but I understand that using crowdin allows
for easier checks to make sure all the keys are added to all json files.
Do I need to create an account on crowdin and ask for joining at
<EMAIL_ADDRESS>?
Guy
Le 2018-05-29 15:52, Jeffrey Lamb a écrit :

Hey, thanks for the translation!
As a heads up for the future, you don't need to update all the other individual translation files for them to show on the site. The important part is adding the "base" translation (which is usually in English, as it is with this sheet, though it can vary; the keys are the really important part) in translation.json. You didn't do that here, so I'll do it manually. The translation.json is then used by a script to add missing keys with no valid translation in those files or on crowdin (to which you should consider joining! [1]).
--
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub [2], or mute the thread [3].

Links:
[1]
https://wiki.roll20.net/Building_Character_Sheets#Translating_Character_Sheets
[2]
https://github.com/Roll20/roll20-character-sheets/pull/3795#issuecomment-392784599
[3]
https://github.com/notifications/unsubscribe-auth/ACBcsO3QlcGjXuyKxhfj32Pek07omDpaks5t3VKxgaJpZM4UMG9P

Hello Jeffrey,
Thanks for the corrections on my pull request.
I have made a python script using regex to extract the i18n key/value
information from the html data.
I don't understand how crowdin integrates with github, but if I
understand correctly, by joining crowdin it would be easier for me to
detect which character sheets need translation and work directly from
there ?
Guy
Le 2018-05-29 15:52, Jeffrey Lamb a écrit :

Hey, thanks for the translation!
As a heads up for the future, you don't need to update all the other individual translation files for them to show on the site. The important part is adding the "base" translation (which is usually in English, as it is with this sheet, though it can vary; the keys are the really important part) in translation.json. You didn't do that here, so I'll do it manually. The translation.json is then used by a script to add missing keys with no valid translation in those files or on crowdin (to which you should consider joining! [1]).
--
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub [2], or mute the thread [3].

Links:
[1]
https://wiki.roll20.net/Building_Character_Sheets#Translating_Character_Sheets
[2]
https://github.com/Roll20/roll20-character-sheets/pull/3795#issuecomment-392784599
[3]
https://github.com/notifications/unsubscribe-auth/ACBcsO3QlcGjXuyKxhfj32Pek07omDpaks5t3VKxgaJpZM4UMG9P


fix collide_aabb

Objective
It says in comments, "If the collision occurs on multiple sides, the side with the deepest penetration is returned." But it did the opposite: when x_depth is more than y_depth, it chooses y_collision.  And the unit test did the same.
Solution
Choose y_collision when y_depth is more than y_depth.

I don't know if the breakout example is relying on this wrong behavior or if something else has gone wrong, but with this PR it is broken (ball escapes).

breakout example DID go wrong. My fault.

I think that is ok if it returns the most shallow collision. But its docs says:

The return value is the side of B that A has collided with. Left means that A collided with B's left side. Top means that A collided with B's top side. If the collision occurs on multiple sides, the side with the deepest penetration is returned. If all sides are involved, Inside is returned.

I think the docs should be updated and the collide method should be left as it was.
Currently on this PR, the breakout ball behaves incorrectly when it hits a corner of a block or the paddle.

Yes, I saw the incorrect behavior. Maybe the doc should be updated. If so, this PR should be cancelled .

I'd be happy to see the docs updated in this PR instead :)

o(╥﹏╥)o... the improvement is not bad, is it

Closing in favor of the linked issue.


How to make an interactable dial

Show how to use an angular drive to make a dial that can be turned to control the gradual value of something.

https://www.youtube.com/watch?v=S0eGtKMyiO8


cmake: use GNUInstallDirs to autodetect installation directories (Linux only)

This PR satisfies requirements regarding installation directories from GNU Coding Standards (https://www.gnu.org/prep/standards/html_node/Directory-Variables.html).
Signed-off-by: Artur Wojcik<EMAIL_ADDRESS>

The change allows address correctly installation to directories which names depend on Linux distribution - i.e. /usr/lib/ vs /usr/lib64/ for CentOS, SLES, and releated; and /usr/lib/x86_64-linux-gnu/ for Ubuntu/Debian.


Add version checking to data format validation

Prerequisites:

~~https://github.com/abraker-osu/osu_aim_tool/issues/11~~

In addition to checking number of columns, check the data version as well.

done


Remove git_root from Commands

This PR is part of a series of PRs to remove git_root from Mentat, and allow Sessions to be run anywhere on the filesystem.

Is there a reason this PR isn't merged? Seems better to merge as we go to avoid a bunch of merge conflicts when you're done with the series.

Is there a reason this PR isn't merged? Seems better to merge as we go to avoid a bunch of merge conflicts when you're done with the series.

Yeah this could have been merged sooner


qemu: replace private migration patch with the upstream one

Then we can use x-ignore-shared to do migration and drop the
extra patch once we move to qemu 4.1.0 or later.
Fixes: #640
Depends-on: github.com/kata-containers/runtime#1799
Signed-off-by: Peng Tao<EMAIL_ADDRESS>

/test

@chavafg How can I kick off ci here? Looks like /test command is not working.

/AzurePipelines run


Scope reusing & smaller scopes

This pull request, is experiment, If you like the idea, we can improve the readability and the quality of the code
For each expression we are creating "scope pool", which is object pool of scopes - with some extra magic.
By doing quick analysis on the node AST I know which tags and fields he requires. so we put only the required ones.
For example: "value" > 10, I fill only "value" from field or tag.
name                     old time/op    new time/op    delta
_T10_P500_AlertTask-4       133ms ± 4%     123ms ± 4%   -7.58%  (p=0.008 n=5+5)
_T10_P50000_AlertTask-4     13.4s ± 8%     12.3s ± 7%     ~     (p=0.056 n=5+5)
_T1000_P500_AlertTask-4     13.5s ± 4%     12.1s ± 3%  -10.46%  (p=0.008 n=5+5)

name                     old alloc/op   new alloc/op   delta
_T10_P500_AlertTask-4      32.2MB ± 0%    26.0MB ± 0%  -19.32%  (p=0.008 n=5+5)
_T10_P50000_AlertTask-4    3.26GB ± 0%    2.62GB ± 0%  -19.71%  (p=0.008 n=5+5)
_T1000_P500_AlertTask-4    3.21GB ± 0%    2.61GB ± 0%  -18.56%  (p=0.008 n=5+5)

name                     old allocs/op  new allocs/op  delta
_T10_P500_AlertTask-4        408k ± 0%      335k ± 0%  -17.85%  (p=0.008 n=5+5)
_T10_P50000_AlertTask-4     41.5M ± 0%     34.1M ± 0%  -17.98%  (p=0.008 n=5+5)
_T1000_P500_AlertTask-4     40.2M ± 0%     33.1M ± 0%  -17.61%  (p=0.008 n=5+5)

I thought about this idea while researching the performance of alerts, but before that I wanted to implement "compiled stateful expression" ( #491 ).
If we combine this pull request with #491 , we will have great performance and low memory usage while evaluating predicates.

@yosiat Thanks! I was hoping this would also get done. At a quick glance it looks good to go once #491 gets merged.

@nathanielc I think we need to define how it will be used.
I currently stuck in StatefulExpression but it might be more clean and ok to be it in it's own struct that StatefulExpression will own?

I currently stuck in StatefulExpression but it might be more clean and ok to be it in it's own struct that StatefulExpression will own?

I think having it on its own would be good.

@nathanielc I will fix that tomorrow and this PR will be ready to merge; I am going to sleep 💤

@yosiat yes, please get some rest :sleeping:

@nathanielc I finished this PR 😄

Refactored the code and the tests
Rebased with the new expressions

Benchmarks (compared to master with new stateful expressions)
I updated the benchmarks in the pull request as well
Ran with count=5
name                     old time/op    new time/op    delta
_T10_P500_AlertTask-4       133ms ± 4%     123ms ± 4%   -7.58%  (p=0.008 n=5+5)
_T10_P50000_AlertTask-4     13.4s ± 8%     12.3s ± 7%     ~     (p=0.056 n=5+5)
_T1000_P500_AlertTask-4     13.5s ± 4%     12.1s ± 3%  -10.46%  (p=0.008 n=5+5)

name                     old alloc/op   new alloc/op   delta
_T10_P500_AlertTask-4      32.2MB ± 0%    26.0MB ± 0%  -19.32%  (p=0.008 n=5+5)
_T10_P50000_AlertTask-4    3.26GB ± 0%    2.62GB ± 0%  -19.71%  (p=0.008 n=5+5)
_T1000_P500_AlertTask-4    3.21GB ± 0%    2.61GB ± 0%  -18.56%  (p=0.008 n=5+5)

name                     old allocs/op  new allocs/op  delta
_T10_P500_AlertTask-4        408k ± 0%      335k ± 0%  -17.85%  (p=0.008 n=5+5)
_T10_P50000_AlertTask-4     41.5M ± 0%     34.1M ± 0%  -17.98%  (p=0.008 n=5+5)
_T1000_P500_AlertTask-4     40.2M ± 0%     33.1M ± 0%  -17.61%  (p=0.008 n=5+5)

I think we can do the same for eval.go using some pooling their, what do you think? do we have good test coverage for what's happening there?

@yosiat Looks good. Can we also update the eval.go usage to use the scope pool? Basically any place that use mergeFieldsAndTags should be updated and then I think we can remove the mergeFieldsAndTags function.

@nathanielc It's a bit problematic there because we have multiple expressions, we can create at startup "combined reference variables" set and use it, what do you think?

@yosiat I don't believe the scope is shared across the expressions, so they should all be able to operate independently.

@nathanielc Looking at the code, looks like they use the same "vars", and after evaluation you are updating the scope..
It looks like the second expression is using the result of the first expression, etc.

@yosiat Yes, the scope cascades across expressions but the state is independent, and the set of referenced values is constant as well.
You should be able to use ScopePool.Get and check if the next expression even wants the result of the previous expression.  In other words create a scope for each expression and then only cascade needed values. The currently implementation is lazy and just reuses the same scope.

umpf, so why not simply on upstart get the reference variables used in all scopes and merge them to one set? so the initial scope will be the merged? in term of performance your approach will win, but this approach will be much simpler.

Go with the simpler approach :) The biggest win is to remove allocations for each evaluation of the expression. Other than that lets keep it simple.

What do you think about creating "MergedScopePool" which will accept list of nodes and and create scope pool for them?

I would rather not create another type.
What if the NewScope method took a list of names []string instead of a node. Then you could easily create ScopePools for difference use cases. You would need to expose a way to get the referencedVariables still. I think adding a method ReferencedVariables to the StatefulExpression would work as it has a reference to the node already. Then remove the ScopePool method from the StatefulExpression, in other words let the caller use the pool but don't require it. Then in eval.go on upstart you would call ReferencedVariable for each expression and merge them and create a single ScopePool for all the expressions. Does that makes sense? Basically instead of pushing the merge logic down into the stateful package leave it in the eval.go code since its the code that needs it.

@nathanielc liked your idea, I will start to play with it and update ~

@nathanielc I will make "findReferenceVariables" a function on top of Node and will put under "tick/reflect.go"

@nathanielc after thinking a bit, if the StatefulExpression won't own the scope pool, it means that:

alert: will need to contain a symmetric array for holding the scope pools
EvalPredicate: will need to accept the scope pool

Are we ok with those changes?

@yosiat +1

@nathanielc This is getting some what tedious, In where, alert and eval we have to "maintain" symmetric array for holding the scope pools. I think it might hear readability.

@yosiat Then maybe you can supply the ScopePool to the StatefulExpression and it does the maintaining? But it still allows for the use case of the pool to be different.

@nathanielc I thought about it, but then it will be too much weird, because they will some dependency.
In order to create ScopePool you will need reference variables, which you get by calling "ReferenceVariables" on StatefulExpression.

@yosiat OK, you are more in the details at this point. Do what makes sense...

@nathanielc What do you think? I haven't integrated it in eval.go yet..

@yosiat

In order to create ScopePool you will need reference variables, which you get by calling "ReferenceVariables" on StatefulExpression.

This is essentially the only difference between alert/where and eval, is how the scope is created. It is used in the same manner. So either have a little duplicate code in alert and where or add helper functions to the stateful package. Something like CreateScopePoolForExpressions and it takes a list of expressions. Then eval passes in a list and where/alert pass in a list of one.

@nathanielc do we want "CreateScopePoolForExpressions" to replace "NewScope" or to be helper method in stateful/scope_pool.go? (I think the latter)

@yosiat  The later, if something wants to create a scope in yet another different way it is still possible if we leave NewScope as is. Also that is why I called it Create... because there is implied logic happening not simply instantiating a new object.

@nathanielc I started implementing the CreateScopePoolForExpressions in eval.go, and it looks like we have another problem.
We need ReferenceVariables for fillScopePool (in expr.go) and in eval.go we will need to have another list for it.
I think instead of CreateScopePoolForExpressions we will create: FindReferenceVariablesForNodes and remove it from Expression.
So the usage will be something like:
var node tick.Node // let's say we have node
refVariables := stateful.FindReferenceVariablesForNodes(node)
stateful.NewScopePool(refVariables)

and in eval.go, it will something like this:
refVariables := stateful.FindReferenceVariablesForNodes(n.Expressions...)
stateful.NewScopePool(refVariables)

@nathanielc It's finished, squashed & updated benchmarks.

@yosiat :+1:  I'll merge on green. Since nothing user facing changes no need to write a CHANGELOG.


Minor spelling correction

Fixed a minor typo / spelling mistake.

@wyckster can you DCO sign your git commit? (git commit -s --amend .)

@vbatts What's wrong with the checks?  Is there something I need to do to move this along?

Thanks for the PR @wyckster !


how to reuse part of path (v4)

I have next routes
<Route path="sales/customers/new" component={ SalesCustomersNew } />
<Route path="sales/customers/profile" component={ SalesCustomersProfile } />

I want to reuse 'sales' part of route, so it will be like in v3. I have tried next but it's not working
<Route path="/sales">
  <Switch>
    <Route path="customers/new" component={ SalesCustomersNew } />
    <Route path="customers/profile" component={ SalesCustomersProfile } />
  </Switch>
</Route>

You nested routes don't match like that. You need to include the full pathname in the path prop.

@timdorr could you please provide a code snippet?

  <Switch>
    <Route path="/sales/customers/new" component={ SalesCustomersNew } />
    <Route path="/sales/customers/profile" component={ SalesCustomersProfile } />
  </Switch>

@timdorr is there any other way to reuse a part of the path? I guess repeating the path could become a mess in bigger applications with large nestings?


error reporting in if-elif-end

When an error occurs in an elif part then the line number of the if part is used for error reporting.  this is very confusing in large if-elif constructs.  We need to generate lineinfo nodes for elif and else parts for error reporting.

Fixed with #109

Fixed with #119


Fix pre-collapsed nav group feature

This PR fixes the ->collapsed() feature on nav groups.
The filament JS runs on the login page which will initialize the persisted collapsedGroups setting as an empty array causing if (localStorage.getItem('collapsedGroups') === null) to always come out as false.

Thanks


provide nonce

Provices a nonce used for content security policy to match other SSR handlers

@benwis @raskyld I appreciate reviews, super short PR

Isn't the nonce usually behind a feature flag in leptos integrations?

I didn't see any feature flag here for the Axum integration, but we can add that if preferred in leptos_wasi?

Looks like we moved that off the integration, so this should be good


Stackblitz preview not working - graphql package missing

Hi,
I just tested the preview on Stackblitz and the graphql package is missing. I get the following error:
 ERROR  Cannot start nuxt:  Cannot find package 'graphql' imported from<EMAIL_ADDRESS>I was able to solve the problem with npm i graphl in the terminal but I hope you can fix this problem so that we don't have to do it manually.
Thanks for this new module. Keep going on !

@mickasmt Thank you for pointing that error.
This problem appears to be specific to the Stackblitz environment. In your local development nuxt-graphql-client is the only package you need to install

Thank you for this return.


Insert picture

Codecov Report

:exclamation: No coverage uploaded for pull request base (master@45802a6). Click here to learn what that means.
 Consider uploading reports for the commit b735c7e to get more accurate results

Additional details and impacted files
@@            Coverage Diff            @@
##             master       #5   +/-   ##
=========================================
  Coverage          ?   72.15%
  Complexity        ?      399
=========================================
  Files             ?       70
  Lines             ?     1232
  Branches          ?      125
=========================================
  Hits              ?      889
  Misses            ?      311
  Partials          ?       32

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.


PTG: Added READY and STOP registers for ME12, ME18, and ME55.

/clang-format-run

ptg_reva_regs.h will have the new register map as well (READY_ and STOP_ interrupt registers). The register map of the old PT is a subset of the register map of the new PT. The parts with the old IP will not have the new stop/ready functions defined on the chip-specific PT libraries. Also note: the mxc_ptg_regs_t *MXC_PTG instance on the chip-specific level is type-casted with mxc_ptg_reva_regs_t.


replace sudo package with including sudo puppet module

this one could be used https://github.com/example42/puppet-sudo

thought the module to go is https://forge.puppetlabs.com/saz/sudo at the moment?


⚠ Bofrost.lu has degraded performance

In a670fb1, Bofrost.lu (https://www.bofrost.lu) experienced degraded performance:

HTTP code: 200
Response time: 2358 ms

Resolved: Bofrost.lu performance has improved in 0357ada after 6 minutes.


Publishing custom functions in this sample on AppSource

Note: This repo is only for questions related to its samples. If you have questions about how to use office.js or the Office developer platform, please post your question on https://stackoverflow.com. Tag your question with office-js or outlook-web-addins

Question
Hi there,
Thanks for the great documentation and samples for Excel custom functions.
However, I can't find any section regarding  publishing of the custom Excel function on AppSource (as part of an add-in).
My custom functions work great locally but are not recognised on the published app.
Thanks for help
T

Hi @t-lm,
Thanks for reporting this. I'm not sure what part of the process would be different for custom functions. I'm going to transfer this issue to the office-js repo where someone in the feature crew can assist you.


issue #657 refactors and improves gulp tasks; updates README files to…

… better explain project structure

I was able to pull down the latest from this branch and build it with no issues after npm install.
skimmed through the code changes and it seemed ok.

@saadmhybris @xak
Remember to keep the Assignee and Reviewer of the PR up to date


Docker composer setup not working

it complains about port 5000 being in use, probably related to the OSC io module (?)

fixed this one


Want to add character : p to font : boomer

i want

assign this to me sir

Hey @monicknog you want to work on this?


YangExtensions getMainModule(EObject obj) will throw out unexpected exception

In the following method, if obj.eContainer is null, this method will throw out unexpected exception.
def dispatch Module getMainModule(EObject obj) {
return obj.eContainer.mainModule
}
In fact this happens when we are trying to fetch an inexist extension's main module.
This getMainModule should be more robust.

Would this work? https://github.com/theia-ide/yang-lsp/pull/84

PR merged.

HI Jan,
Sorry to say that your fix seems not works fine.
I mentioned in my description. The obj.eContainer is null, but not only obj.
So maybe this statement would be better,  obj?.eContainer?.mainModule
What do you think?

Yes, I test the new method.
It works fine now to just return null.


Improve tracing

More visibility into tasks of the pipelined executor: among other details, trace queue puts, as they can take a bit of time for larger values
Fix execution plan tracing event - can't have an OrderedDict as value, so format as List[str]

Contributor Checklist:

[ ] I have added or updated my entry in the creators.json file
[ ] I have added a changelog entry for my contribution
[ ] I have added/updated documentation for all user-facing changes
[ ] I have added/updated test cases
[ ] I have included the rebuilt production build of the client (only if changes were made to the GUI)

Reviewer Checklist:

[ ] /azp run libertem.libertem-data passed
[ ] No import of GPL code from MIT code

/azp run libertem.libertem-data

Oof, test_scatter_update is still (again?) flaky. One solution I see is to increase the number of tasks (by a lot) - if this then takes too much time, I guess it needs to be marked as slow.

/azp run libertem.libertem-data


make *.handlebars, *.hbs or *.mustache  as default file extension instead of .html

if we use the correct file extensions it can be better recognized by IDE's for syntax highlightning and other features (helpers i.e).
i.e for the jetbrain products: https://github.com/dmarcotte/idea-handlebars
at least make it configurable via config.

It is configurable.
{
  'nitro': {
    'view_file_extension': 'hbs'
  }
}

It's implemented analogue to how Terrific Micro handles this but using the nitro identifier rather than terrific. I think for historic reasons we should keep the html file extensions as default. Also I'm not sure how Magnolia/.NET/CQ integrations handle different extensions.
Therefore I'll close this issue. If I'm mistaken or anyone insists on changing the default value please reopen the ticket for discussion.
/cc @ernscht


Aborts on macOS 13.2.1 with couldn't recognize data in image file iconmonstr-location-27-32.png

After installing on macOS 13.2.1 with
python3 -m pip install --upgrade PyGPSClient
and then launching with
python3 -m pygpsclient
the program aborts immediately with following output:
Me@Mac-Studio ~ % python3 -m pygpsclient
DEPRECATION WARNING: The system version of Tk is deprecated and may be removed in a future release. Please don't rely on it. Set TK_SILENCE_DEPRECATION=1 to suppress this warning.
Traceback (most recent call last):
  File "/Library/Developer/CommandLineTools/Library/Frameworks/Python3.framework/Versions/3.9/lib/python3.9/runpy.py", line 197, in _run_module_as_main
    return _run_code(code, main_globals, None,
  File "/Library/Developer/CommandLineTools/Library/Frameworks/Python3.framework/Versions/3.9/lib/python3.9/runpy.py", line 87, in _run_code
    exec(code, run_globals)
  File "/Users/klingler/Library/Python/3.9/lib/python/site-packages/pygpsclient/__main__.py", line 43, in <module>
    main()
  File "/Users/klingler/Library/Python/3.9/lib/python/site-packages/pygpsclient/__main__.py", line 37, in main
    App(root, **kwargs)
  File "/Users/klingler/Library/Python/3.9/lib/python/site-packages/pygpsclient/app.py", line 118, in __init__
    self.__master.iconphoto(True, PhotoImage(file=ICON_APP))
  File "/Library/Developer/CommandLineTools/Library/Frameworks/Python3.framework/Versions/3.9/lib/python3.9/tkinter/__init__.py", line 4064, in __init__
    Image.__init__(self, 'photo', name, cnf, master, **kw)
  File "/Library/Developer/CommandLineTools/Library/Frameworks/Python3.framework/Versions/3.9/lib/python3.9/tkinter/__init__.py", line 4009, in __init__
    self.tk.call(('image', 'create', imgtype, name,) + options)
_tkinter.TclError: couldn't recognize data in image file "/Users/Me/Library/Python/3.9/lib/python/site-packages/pygpsclient/resources/iconmonstr-location-27-32.png"

Hi @richardklingler
Sorry you're having difficulties, but I can only imagine you have a corrupeted installation somehow.
PyGPSClient runs fine under MacOS 13.2.* on both Intel and M1/M2 platforms and Python versions >=3.7, <=3.11. The image file in question appears in the About dialog - see screen shots below.
I've not come across that 'Tk deprecation' warning before on a Mac - there may be something odd about your Python installation. It may be worth upgrading to the latest Python 3.11 (alongside 3.9 if necessary) to see if that resolves the problem.

Fiddled around a bit and tried installing 3.11.2 via pyenv...no joy...
Only this helped:
brew install python-tk

Hi @richardklingler
Glad you got it sorted, but I'm surprised you had to do a brew install of python-tk on MacOS - this is typically only necessary on some Linux platforms.
The standard universal Python installation package for MacOS (from python.org, not the App Store) includes all the necessary tkinter runtimes and environment configuration. I've never needed to install brew or macports on any of my Mac workstations.
https://www.python.org/ftp/python/3.11.2/python-3.11.2-macos11.pkg

 $ python3 -m pip install --upgrade pygpsclient
Defaulting to user installation because normal site-packages is not writeable
Requirement already satisfied: pygpsclient in ./Library/Python/3.9/lib/python/site-packages (1.3.30)
Requirement already satisfied: requests>=2.28.0 in ./Library/Python/3.9/lib/python/site-packages (from pygpsclient) (2.31.0)
Requirement already satisfied: Pillow>=9.0.0 in ./Library/Python/3.9/lib/python/site-packages (from pygpsclient) (10.0.0)
Requirement already satisfied: pygnssutils>=1.0.11 in ./Library/Python/3.9/lib/python/site-packages (from pygpsclient) (1.0.11)
Requirement already satisfied: pyserial>=3.5 in ./Library/Python/3.9/lib/python/site-packages (from pygpsclient) (3.5)
Requirement already satisfied: pyspartn>=0.1.10 in ./Library/Python/3.9/lib/python/site-packages (from pygpsclient) (0.1.10)
Requirement already satisfied: paho-mqtt>=1.6.1 in ./Library/Python/3.9/lib/python/site-packages (from pygnssutils>=1.0.11->pygpsclient) (1.6.1)
Requirement already satisfied: pyubx2>=1.2.28 in ./Library/Python/3.9/lib/python/site-packages (from pygnssutils>=1.0.11->pygpsclient) (1.2.28)
Requirement already satisfied: cryptography>=39.0.2 in ./Library/Python/3.9/lib/python/site-packages (from pyspartn>=0.1.10->pygpsclient) (41.0.2)
Requirement already satisfied: charset-normalizer<4,>=2 in ./Library/Python/3.9/lib/python/site-packages (from requests>=2.28.0->pygpsclient) (3.2.0)
Requirement already satisfied: idna<4,>=2.5 in ./Library/Python/3.9/lib/python/site-packages (from requests>=2.28.0->pygpsclient) (3.4)
Requirement already satisfied: urllib3<3,>=1.21.1 in ./Library/Python/3.9/lib/python/site-packages (from requests>=2.28.0->pygpsclient) (2.0.4)
Requirement already satisfied: certifi>=2017.4.17 in ./Library/Python/3.9/lib/python/site-packages (from requests>=2.28.0->pygpsclient) (2023.5.7)
Requirement already satisfied: cffi>=1.12 in ./Library/Python/3.9/lib/python/site-packages (from cryptography>=39.0.2->pyspartn>=0.1.10->pygpsclient) (1.15.1)
Requirement already satisfied: pynmeagps>=1.0.27 in ./Library/Python/3.9/lib/python/site-packages (from pyubx2>=1.2.28->pygnssutils>=1.0.11->pygpsclient) (1.0.27)
Requirement already satisfied: pyrtcm>=1.0.11 in ./Library/Python/3.9/lib/python/site-packages (from pyubx2>=1.2.28->pygnssutils>=1.0.11->pygpsclient) (1.0.11)
Requirement already satisfied: pycparser in ./Library/Python/3.9/lib/python/site-packages (from cffi>=1.12->cryptography>=39.0.2->pyspartn>=0.1.10->pygpsclient) (2.21)
MacBook-Air:~ brandon 2023-07-28 14:52:43 $ pygpsclient
/Users/brandon/Library/Python/3.9/lib/python/site-packages/urllib3/__init__.py:34: NotOpenSSLWarning: urllib3 v2.0 only supports OpenSSL 1.1.1+, currently the 'ssl' module is compiled with 'LibreSSL 2.8.3'. See: https://github.com/urllib3/urllib3/issues/3020
  warnings.warn(
DEPRECATION WARNING: The system version of Tk is deprecated and may be removed in a future release. Please don't rely on it. Set TK_SILENCE_DEPRECATION=1 to suppress this warning.
Traceback (most recent call last):
  File "/Users/brandon/Library/Python/3.9/bin/pygpsclient", line 8, in <module>
    sys.exit(main())
  File "/Users/brandon/Library/Python/3.9/lib/python/site-packages/pygpsclient/__main__.py", line 47, in main
    App(root, **kwargs)
  File "/Users/brandon/Library/Python/3.9/lib/python/site-packages/pygpsclient/app.py", line 130, in __init__
    self.__master.iconphoto(True, PhotoImage(file=ICON_APP))
  File "/Library/Developer/CommandLineTools/Library/Frameworks/Python3.framework/Versions/3.9/lib/python3.9/tkinter/__init__.py", line 4064, in __init__
    Image.__init__(self, 'photo', name, cnf, master, **kw)
  File "/Library/Developer/CommandLineTools/Library/Frameworks/Python3.framework/Versions/3.9/lib/python3.9/tkinter/__init__.py", line 4009, in __init__
    self.tk.call(('image', 'create', imgtype, name,) + options)
_tkinter.TclError: couldn't recognize data in image file "/Users/brandon/Library/Python/3.9/lib/python/site-packages/pygpsclient/resources/iconmonstr-location-27-32.png"

Hi @brandonros
The clue is in the error message:
DEPRECATION WARNING: The system version of Tk is deprecated and may be removed in a future release. Please don't rely on it. Set TK_SILENCE_DEPRECATION=1 to suppress this warning.
As is mentioned in the README.md, the version of Python that is preinstalled on MacOS includes a deprecated version of tkinter (8.5). God only knows why - it's been deprecated for nearly 10 years now. You'll need to upgrade this to the latest version 8.6, and by far the easiest way to do this is to simply install Python using the official Python MacOS installer, which works for both Intel and Apple Silicon:
https://www.python.org/downloads/release/python-3114/
I STRONGLY RECOMMEND against using brew or macports to install python or tkinter - that will almost certainly lead to a corrupted installation.
If you want to check the version of tkinter you're running, you can run the following script:
import tkinter
tkinter.TkVersion

To find the low level version, use:
import tkinter
tcl = tkinter.Tcl()
print(tcl.call("info", "patchlevel"))

Hope this helps


Aves doesn't recognise Picasa Face tags

I have lots of photos that have been tagged by Picasa (I still use Picasa as it is one of fastest ways to tag faces) and it stores the face names using the following tags
[XMP-mwg-rs]    RegionName
https://exiftool.org/forum/index.php?topic=11472.0
Would it be possible to allow Aves to index these face names as it would make finding photos so much better?

I intend to do it (and present faces in a similar way to countries and tags), but it's not going to happen in the short term.
By the way, I also still use Picasa. Great software.


restore original window title when exiting vim.

use xterm title stack feature for save/restore window title.
save title string to stack when starting vim, and restore title string
from stack when exiting vim.

Isn't this already the xterm_save feature, which defaults to off (-xterm_save) but can be enabled (+xterm_save) at compile-time by uncommenting a #define at line 834 of src/feature.h? (AFAIK there is no configure parameter for it.) Or does that feature restore the screen but not the title?
Best regards,
Tony.

Or does that feature restore the screen but not the title?

xterm_save feature restores the screen (and cursor position) only.

use xterm title stack feature for save/restore window title.
save title string to stack when starting vim, and restore title string
from stack when exiting vim.

There is a todo item for another solution:
8   For xterm need to open a connection to the X server to get the window
title, which can be slow.  Can also get the title with "[21t", no
need to use X11 calls.  This returns "]l{title}".
Does using the stack work better?  If not for xterm, then for
xterm-compatible terminals.  And how about tmux?
I don't think libvterm supports any of this.
--
I AM THANKFUL...
...for the mess to clean after a party because it means I have
been surrounded by friends.
/// Bram Moolenaar --<EMAIL_ADDRESS>-- http://www.Moolenaar.net   \
///        sponsor Vim, vote for features -- http://www.Vim.org/sponsor/ \
\\  an exciting new programming language -- http://www.Zimbu.org        ///
\\            help me help AIDS victims -- http://ICCF-Holland.org    ///

[21t (title reporting) has a security issue.
c.f.
https://marc.info/?l=bugtraq&m=104612710031920&w=2
https://nvd.nist.gov/vuln/detail/CVE-2003-0064
Most terminal emulators disable title reporting by default setting, or do not support title reporting.
Title stack is supported by following terminals.

xterm
mlterm
mintty
Tera Term
RLogin
iTerm2
VTE based terminal emulators (*1)
tmux

*1: VTE supported "title stack" in recently, and it does not distributed widely. https://bugzilla.gnome.org/show_bug.cgi?id=699819

I like this patch :+1:. I hope this to be merged soon.


Retrieve schema records

fixes #10

added in retrieve_schema_records function
added optional collection and databse argument for _get_records and _count_records
created helper function _creat_url to sreate correct url from collection and database arguments

Hi @helen-m-lin I was wondering if you could help me with the unit tests? I just copied the ones you used for retrieve_docdb_records and replaced with the schema call function. I don't know if that's right or if I need to test more functionality since we can pass in the schema type. Thanks for any help!

no prob! I'll provide an example offline. Overall, yes please pass in any params. You can also assert the calls of mock_get_record and mock_count_record. expected_response can be a (simplified) mock schema record.


Tree feature

Hi, could you please add free axe(gas) claim in the missions tab?

It could be done just by clicking on the task. There is no need to perform any other actions.
It can be claimed every hour, so it will be perfect to claim it every time before points claim

Hi,
The script was already set to automatically claim the axes, although it seems they wording from ❤, RT and Tag 3 Friends to ❤, 🔄 & Tag 3 Friends. I'll update the XPATH.
Thanks

It seems that it doesn't work. I've just restarted Tree and in the logs it shows that it couldn't claim axe

if it is helpful, this is how this button is written in html view (❤, 🔄 & Tag 3 Friends)

Thanks, we're out of time for this month, but will look at modifying next month when I have more days off.


Fix filter-comments-by-you link on PR list page

Closes #2647

Test

Go to the PR list page and click on the caret to the left of the input text (i.e. https://github.com/sindresorhus/refined-github/pulls?q=is%3Apr+is%3Aopen+sort%3Aupdated-desc)
--> See that a link to Everything commented by you is added just before the very last link in the list (View advanced search syntax)
Click on the link Everything commented by you
--> See that the url you're redirected to contains issues?q=is%3Aopen+commenter:YOUR_USERNAME
Repeat steps 1-2 but go to the issues page instead (i.e. https://github.com/sindresorhus/refined-github/issues?q=is%3Aissue+is%3Aopen+sort%3Aupdated-desc)

Thank you for these PRs! I’ll test them and merge them in a couple of weeks, unless someone else does it first.

And Happy Holidays!


Can't start when using Populus 1.6.8

config.py has
from populus.utils.wait import (
    Wait,
)

That fails in Python REPL:
>>> from populus.utils.wait import ( Wait, )
Traceback (most recent call last):
  File "<stdin>", line 1, in <module>
ImportError: cannot import name 'Wait'

There has probably been some change in a (recent) release, still investigating. Release notes don't mention any, it seems. :/
For ref, the wait API has been added in PR pipermerriam/populus#173 (Sep 6, 2016), which means it's been part of Populus since v1.0.0.
EAC's setup.py specifies "populus>=1.2.1" as dep.

If using populus==1.2.2, there seems to have been an incompatible API change in web3, a dependency of populus:
>>> from populus.utils.wait import ( Wait, )
Traceback (most recent call last):
  File "<stdin>", line 1, in <module>
  File "/home/veox/.local/lib/python3.5/site-packages/populus/__init__.py", line 3, in <module>
    from .project import Project
  File "/home/veox/.local/lib/python3.5/site-packages/populus/project.py", line 4, in <module>
    from web3.utils.string import (
ImportError: No module named 'web3.utils.string'

So "pinning" to an earlier version of populus in EAC wouldn't work. Seems easier to update for incompatibility in OP.

Looks like populus.wait is the correct module name now, not populus.utils.wait - has been moved.

These are fun to catch up with, sorry I've not had the time to dive in and help at the PR level.  Working through these now.


How can I set post permalink?

Hi! I am trying to set a post permalink on the posts I'm publishing, and setting the value of "post.link" is not working. Can you help me out?

post.link is a read-only field, it comes back from GetPost or GetPosts but NewPost and EditPost will ignore it. Instead you should be able to use post.slug which corresponds to the post_name field in WordPress' database. You can find more details about how the permalink is generated based on your WP settings and post_name here: https://codex.wordpress.org/Using_Permalinks


Update

History

Add betamax_recorder pytest fixture
Change default behaviour to allow duplicate interactions to be recorded in single cassette
Add allow_playback_repeats to allow an interaction to be used more than once from a single cassette
Always return a new Response object from an Interaction to allow for a streaming response to be usable multiple times
Remove CI support for Pythons 2.6 and 3.2

Hi! This is the friendly automated conda-forge-linting service.
I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.


Move TLB setup to UMD from compiler runtime

Problem
Currently we don't setup the TLBs inside UMD, just provide the API for compiler runtimes to be able to do it. It looks like we could move this logic to UMD, since we already have layout of TLBs and mapping of TLBs that all of compiler runtimes are following (Buda and Metal), which come mostly from syseng guide. It seems that there is no much room to map TLBs differently, since the layout we are using seems to be working fine and there is no clear more optimal mapping (for example 4GB TLBs on BH can't really be used for something else, 2MB TLBs are also fixed at certain positions)
It also leads to code duplicates like in tlb_config files in Buda and Metal. If someone wants to write some simple tests using only UMD and some runtime code it also needs to setup TLBs manually outside of UMD, which can be a bit tiring.
Proposed solution
Basically it would be nice to move the TLB setup inside UMD, something similar to tlb_config.cpp files in compilers. We can still do few things in order to keep flexibility:

keep the API to setup the TLBs manually
provide an option to not do the setup inside UMD

For example we could have something like

// functions inside some class like tt_SiliconDevice
void setup_tlbs();

void setup_hugepages();

void setup_device_communication() {

   setup_tlbs();

   setup_hugepages();
}

So we can allow runtime to call setup_device_communication and UMD is going to setup the TLBs (and everything else) or runtime can do it like in tlb_config.cpp through already existing API if it wants to do something different.
The proposed API is not 100% exact since we probably first need to make more high level plan of how UMD code is going to be organized, but I think the point is clear

Thanks for raising this and proposing a solution.  Moving static TLB assignment into UMD could indeed reduce code duplication and reduce the burden of writing standalone tests.  However, I'd like to explore some additional considerations that might impact this approach.

How does static assignment address the challenge of chips having more addressable memory than what can be covered by the windows?  It seems dynamic assignment is necessary.
How can we account for scenarios where multiple applications need to access the device simultaneously?  For instance, gathering telemetry across a chip topology while an ML workload is active.
Given that some of the tools we've shipped do not use UMD (and thus lack knowledge of both the ML application's static allocation scheme and UMD's dynamic TLB synchronization mechanism), how can we ensure cooperation between such tools and user workloads?

Considering these points, I'd like to propose an alternative approach that might address both the original concerns and these additional considerations:

Have KMD administer TLB windows as a resource, allowing user processes to request windows and map them into their address space.
Provide a UMD mechanism for ML applications to establish long-lived TLB window mappings for performance-critical MMIO.
For non-performance critical MMIO, have UMD offer an interface for IO to arbitrary NOC endpoints, dynamically reassigning windows as needed.

I've written about 2 here.

Hey, thanks for the detailed response. As a general comment, the attached doc looks super nice, it looks like you put a lot of thought into it, the proposed design makes a lot of sense.
Just to give few minor comments and maybe we can start finalizing the proposed design and implement it.

How does static assignment address the challenge of chips having more addressable memory than what can be covered by the windows? It seems dynamic assignment is necessary.

Dynamic assignment would still be done through already existing API, when I said static I was thinking more about already mapping TLBs that are usually used for some purpose (tensix L1, DRAM etc...)

Provide a UMD mechanism for ML applications to establish long-lived TLB window mappings for performance-critical MMIO.
For non-performance critical MMIO, have UMD offer an interface for IO to arbitrary NOC endpoints, dynamically reassigning windows as needed.

This is something I wanted to point out as well, that we should prepare TLBs in advance, but just do it through UMD. I see you have proposed the same with TlbWindow class, so we can focus on that design later on.

Given that some of the tools we've shipped do not use UMD (and thus lack knowledge of both the ML application's static allocation scheme and UMD's dynamic TLB synchronization mechanism), how can we ensure cooperation between such tools and user workloads?

Didn't know this, thanks for pointing it out. One question about this. So we will need a way to manage resources at one TlbWindow granularity? For example, if the workload wants to use the TLB just for some time, and then free it up, we need to somehow return just one TLB as a resource back to kmd, if I understand it correctly. Am I seeing this right? This should not be the problem for us?
Regarding the doc, not really much to add, we will probably sync at some time in the future to work out the details of it, the proposed design looks nice


New Block: Table

Create a new block to easily create a table (row by row, column by column).

duplicated #242


Cross build for Scala 2.13: Putting the finishing touches

Hey there! It's yet another attempt to get closer to releasing the Scala 2.13 support for this great tool. This PR is built on top of the https://github.com/scalacenter/scalac-profiling/pull/32.
What this PR does/aims:

Restores the work done by @tanishiking — I didn't even manage to start SBT :sad_pepe:
Adds support for the following Scala versions 2.12.16, 2.12.17, 2.12.18, 2.13.9, 2.13.10, 2.13.11, 2.13.12.
Migrates the SBT plugin to 1.x. Support for the 0.13 version was expunged — it's been 5+ years since the SBT 1.0 release 🎉
Fixes the integration tests. Honestly, I had to prune most of the underlying projects (but add a new one). I am almost confident that the problem lies within the SBT plane, not the scalac-profiling itself. I faced weird errors like this one — some projects use sbt-git from com.typesafe artefacts but scalac-profiling uses ones from com.github, which leads to this Some keys were defined with the same name but different types: 'gitReader' (com.github.sbt.git.ReadableGit, com.typesafe.sbt.git.ReadableGit), 'gitRunner' (sbt.Task[com.github.sbt.git.GitRunner], sbt.Task[com.typesafe.sbt.git.GitRunner]). The key is that we still have some foreign projects plugged into the integration tests. And one could do follow-up work on bringing more of them. In short, I don't think we have to backport support of all of them. And it's neither a blocker for moving on.
Sets up the release plugin in a way it's done in other Scala Center projects. Probably, the settings of this git repo have to be reviewed on the eligibility of the sbt-ci-release plugin.
Tweaks some tiny things here and there.

What's out of the scope of this PR:

Adding support for the vscode. If one argues that it is mandatory to be done to get this work released, I will give it a try. Or maybe someone from the Scala Center/community could do that.

Tagging people from the original PR for better visibility @tanishiking @sjrd @SethTisue 🙏🏻

Hey @tanishiking @sjrd! May I ask you to check this repo's settings for enabling the Read and write permission to the GA workflow? I predict this should fix the CI.
<EMAIL_ADDRESS>Permission denied (publickey).
fatal: Could not read from remote repository.

Please make sure you have the correct access rights
and the repository exists.

Secrets are never provided to workflows coming from pull requests, for security reasons.
Use a git or https protocol to clone external git repositories, instead of ssh.

@sjrd thank you for the advice. Now we have a "green CI". Hopefully, this is ready for the review.

Maybe one solution here would just be to merge it, roll a milestone or RC release, and invite people to test it?

Most of the changes have been reviewed already in another PR. But in any case, it's better to review this before merging.
But publishing just a milestone would be the right approach in moving further :+1:

The release script apparently successfully published version 0-0.0.0+424-33b59cb6-SNAPSHOT. You might want to give it a try.

At least it publishes artefacts, hooray! Also, I'd like to bring the baseVersion to fix snapshot versioning. After fixing, it's going to be 1.0.0-711bf78-SNAPSHOT. @sjrd wdyt?

All I had to do for that was to actually back-publish a v1.0.0 tag corresponding (as best I could tell) to the actually release 1.0.0. I reran the publishing job and it now published as 1.0.0+41-33b59cb6-SNAPSHOT.

So, we have to wait for the artefacts to appear in Maven Central. I will return with some results of testing in projects which are near at hand. Although, I tested the plugin by publishing it locally.

Ah, yes. Perhaps I encountered some flaky on the first try. As of now, adding the snapshot resolver to the plugins.sbt (resolvers += Resolver.sonatypeRepo("snapshots")) makes it work well.

Good. Thanks for checking. Shall I release it as a true version, then?

Also, I managed to perform e2e testing on a Scala 2.13 project, everything appears to be in order.

Shall I release it as a true version, then?

As we agreed with @SethTisue, it should be fine to publish a milestone release (or an RC) and ask the community for testing if they are interested. Does it work for you? On the opposite, I can draft a small how-to with the snapshot version, and we can wait for the feedback from the community.

1.1.0-RC1 is on its way to Maven Central.

I gave 1.1.0-RC1 a try and besides https://github.com/scalacenter/scalac-profiling/pull/34 it worked fine


Add menu to quickly switch accounts

Fixes #35
I had to do this slightly hacky, since the way BottomMenuItem works, does not allow it to be wrapped in a gesturerecognizer. So I wrapped the icon and text widgets individually. This does seem to work pretty well though.
As described in the issue, this PR adds a long-press gesture to the "Me" tabbar item. It brings up a bottom modal where you can quickly choose a different account. Choosing the currently active one doesn't reload the app but instead just closes the modal. I also added a "Manage" link, that opens the regular login view where the user can also add new accounts or delete existing ones.

Thanks for your contribution! I'll review it ASAP

Hi, @phillipthelen , sorry for the late review. This feature is really helpful!
Perhaps there is a point that can be improved that the entry is a bit hidden(long press Me tab item). Most users may not notice this behavior.
If you don't mind I'd like to add some commits to this PR to give users some tips for this feature.

I 100% agree with you! Do you have an idea for how to better surface this feature? Are there other places in the app where tutorials/hints are shown?

Hi, @phillipthelen , sorry for the long wait.
I still don't figure out how to add the hints. Instead of that, my new proposal is to add a 'switch accounts' button to the Me screen's header. It also works for quick account switch. The only drawback is that it would appear a bit slowly (waiting for user data fetching), and not work offline.
The code base has changed significantly after 8 months, which would cause lots of conflicts on merge/rebase, so I'm going to rewrite these code and force push to this PR's branch.

Thank you for all your efforts!
Feel free to ping me if there are other ideas


minify-simplify + minify-guarded-expressions incorrectly transform a switch statement

I've distilled my repro case to this:
function foo(bar) {
	bar = bar || 'baz';

	switch (bar) {
		case 'spam':
			return true;
		case 'ham':
		case 'eggs':
			return false;
	}
	return false;
}

Notice that the function only returns true if bar == 'spam'.
When I run it through minify-simplify plugin (babel --plugins=minify-simplify) it produces a correct result:
function foo(bar) {
	return bar = bar || 'baz', bar === 'spam' || (bar === 'ham' || bar === 'eggs') && false;
}

When I run the source through minify-guarded-expressions separately (babel --plugins=minify-guarded-expressions) it has no effect.
However when I run minify-simplify and minify-guarded-expressions at the same time (babel --plugins=minify-guarded-expressions,minify-simplify) I get this:
function foo(bar) {
	return bar = bar || 'baz', bar === 'spam' || bar === 'ham' || bar === 'eggs';
}

Notice that the function now returns true for all the cases, not just 'spam'.
Here's a REPL

I guess this can be further simplified to:
foo === 'bar' || foo === 'baz' && false

Running babel --plugins=minify-guarded-expressions produces:
foo === 'bar' || foo === 'baz';

Which is clearly incorrect, since the right branch is effectively dead code. Here's a REPL

Yeah, we should be smarter here. If the value is utilized (passed to function, assigned, returned, etc.) probably need to ignore this optimization entirely.


Expand BreastCancerDetectionVS to include other methods of observation

Noted in review with @markkramerus - Commented in latest branch of shimi-mlt-tumorx.

@mlterryMitre do you know where did the codes that are currently there come from?

fixed in shimi.


Feature/devicon

Hey,
I needed icons from different programming languages for my project. I found DevIcons, where they are all in one icon pack, because otherwise they are just scattered.
I have added this, would be happy about a merge ;)
added:

devicon/line
devicon/original (colorized)
devicon/plain (not colorized)

updated:

readme

Thanks very much for your contribution! Great work!

Now published in v29.3.0 🎉


Refactor rename file urigo:angular.js -> angular-meteor.js as to allow this file to be used on Windows also

It seems that this notation is no longer needed as long as the developer points the name of the package in package.js

Yes you are right.
it is also nicer looking.
Merging

@Urigo I have not tested how this would fit with atmospherejs.com and ability to publish the package via meteor but taking iron:router and collection2 as example, this should be all good.

it's ok, I've done it in another packages of mine


Variant names with spaces end up with error

Describe the bug
When using the cli, if you create a variant name with a space, you get an error.
Expected behavior
The CLI should not allow the usage of variant names with spaces. The same logic we use to the app name should be used

I want to take this up.
I would take the same approach as app_name in agenta-cli/agenta/cli/main.py
i.e. '^[a-zA-Z0-9_]+$'


[Backport 1.x] Match Rest Path registry with RestController using SDKMethodHandlers

Backport 94618e06c5dde526f009f11d43a0d61259be2626 from #658

Why is the backport workflow failing though?

Codecov Report

Merging #664 (bd8b8c6) into 1.x (a18fa9f) will increase coverage by 0.00%.
The diff coverage is 73.68%.

:mega: This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more
@@            Coverage Diff            @@
##                1.x     #664   +/-   ##
=========================================
  Coverage     63.83%   63.84%
- Complexity      268      273    +5
=========================================
  Files            54       55    +1
  Lines          1142     1156   +14
  Branches         35       38    +3
=========================================
+ Hits            729      738    +9
- Misses          402      405    +3
- Partials         11       13    +2

Impacted Files
Coverage Δ

...main/java/org/opensearch/sdk/ExtensionsRunner.java
77.22% <ø> (ø)

...rch/sdk/handlers/ExtensionsRestRequestHandler.java
40.00% <ø> (ø)

...ava/org/opensearch/sdk/rest/SDKMethodHandlers.java
69.23% <69.23%> (ø)

...opensearch/sdk/rest/ExtensionRestPathRegistry.java
90.90% <83.33%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.


Replace comparator function by a recursive type constraint

Hi @bboreham. I'm opening this PR, not in the hope that you will merge it, but just to demonstrate that generics are powerful enough indeed to express the following type constraint:

any type E that has a Less(E) bool method

More details at https://stackoverflow.com/questions/64468241/recursive-type-constraint-using-a-defined-type-rather-than-a-type-literal/68868092#68868092

Hi, thanks for this.  You're absolutely right that this code solves the problem I spoke about in the talk.
However, when I looked at using your change, e.g. in Loki, I realised that it's already using the flexibility of passing in a less function to reverse the order of sorting.
(Loki is using a copy of the Loser Tree which is closer to the any branch in this repo; I was thinking to create another alternative branch using your PR, but if I can't actually use it I'm less inclined).

No worries. Thanks for giving me more context. I'll close this PR now.


Google Assistant with Yeelight

Make sure you are running the latest version of Home Assistant before reporting an issue.
You should only file an issue if you found a bug. Feature and enhancement requests should go in the Feature Requests section of our community forum:
Home Assistant release (hass --version):
0.57
Python release (python3 --version):
python:3.6
Component/platform:
Docker
Description of problem:
When asking Google Assistant to change a light to a certain color, "change bed light to purple", the assistant confirms this "Sure, changing bed light to purple". But instead of changing to purple the light turns off.
Simple commands like on/off. And dimming do work as expected
Expected:
When asked to change to a certain color the light is expected to change to that color, not off.
Problem-relevant configuration.yaml entries and steps to reproduce:
- platform: yeelight
  devices:
    yeelink-light-[REDACTED]:
      name: Bed
      transition: 1000
      use_music_mode: False

Setup Light
Setup Google Assistant
Ask to change color of light

Traceback (if applicable):
2017-11-04 12:58:34 INFO (MainThread) [homeassistant.components.http] Serving /api/google_assistant to <IP_ADDRESS> (auth: False)
2017-11-04 12:58:34 INFO (MainThread) [homeassistant.core] Bus:Handling <Event call_service[L]: domain=light, service=turn_off, service_data=entity_id=light.bed, service_call_id=23224702856944-20>
2017-11-04 12:58:34 INFO (MainThread) [homeassistant.core] Bus:Handling <Event service_executed[L]: service_call_id=23224702856944-20>

Additional info:
No additional info

This is being handled here: https://github.com/home-assistant/home-assistant/pull/10039 😉

@marvinroger Thanks for that :)


Duplicate syntaxs are not judged when parsing

Search before asking

[X] I had searched in the issues and found no similar issues.

Version
unstable branch.
Minimal reproduce step
<IP_ADDRESS>:6666> cas key old new ex 1 ex 10
(integer) 0

What did you expect to see?
(error) ERR syntax error
What did you see instead?
Executed successfully.
Anything Else?
Maybe other commands have this problem too. I'll fix them after double-checking. Even if the command was coded to prevent this issue (such as CommandSet), the code was written with no generality. I will provide a more general parsing function in this pr.
Are you willing to submit a PR?

[X] I'm willing to submit a PR!

I notice that actually it is ok in redis to repeat the same keyword and arguments, e.g.
<IP_ADDRESS>:6379> set key value ex 22 ex 333
OK
<IP_ADDRESS>:6379> ttl key
(integer) 331

I notice that actually it is ok in redis to repeat the same keyword and arguments, e.g.
<IP_ADDRESS>:6379> set key value ex 22 ex 333
OK
<IP_ADDRESS>:6379> ttl key
(integer) 331

Yes, I've tested redis too, but I think duplication is a very confusing behavior. I think this is also a bug of redis, because in redis, theset key value ex 10 ex 1 will get ERR syntax error
<IP_ADDRESS>:6379> set key value px 1
OK
<IP_ADDRESS>:6379> set key value ex 10 px 1
(error) ERR syntax error
<IP_ADDRESS>:6379> set key value ex 10 ex 1
OK

It can't tell whether it's a bug or not from the Redis code. But I guess if Redis won't regard this behavior as a bug then many places need to be fixed since most arguments like LIMIT and COUNT are allowed duplicate.

It can't tell whether it's a bug or not from the Redis code. But I guess if Redis won't regard this behavior as a bug then many places need to be fixed since most arguments like LIMIT and COUNT are allowed duplicate. Perhaps can raise an issue to ask the Redis community.

If aligning redis is the starting point, we should at least guarantee cas key old new ex 1 px 10 will throw an error. And the current CommandSet logic does not support repeated commands.

Yes, you're right that Redis also don't allow using ex|px|exat at the same time.

+1. There should be a syntax error while different options in same functionality is encountered.

@tanruixiang shall we close this issue as #1017 merged?

@tanruixiang shall we close this issue as #1017 merged?

Ok. There are still some unresolved discussions that will be resolved after twice proposes a parsing-design's issue.


parser: add enable field for mutliSchemaInfo in job

Signed-off-by: ailinkid<EMAIL_ADDRESS>
What problem does this PR solve?
add a enable field to mutliSchemaInfo in job
What is changed and how it works?
add a enable field to mutliSchemaInfo in job
Check List
Tests

No code
it will be tested in the latter TiDB pull request

Related changes

Need to update the documentation

Since the MultiSchemaInfo is a pointer in the Job, can we check job.MultiSchemaInfo != nil to determine whether it is enabled?

for this case, we can


[Key Vault] Remove direct uses of asyncio.sleep

Description
Resolves https://github.com/Azure/azure-sdk-for-python/issues/33748. Key Vault uses a handful of custom polling methods, which currently use asyncio.sleep directly. This PR refactors them to instead use the client transport's own sleep method. To make this easier, base KV clients now have a ._transport attribute that points directly to the client's transport, and this transport is passed along to each polling method's constructor.
asyncio is still imported and used directly in tests and samples; a separate PR will follow this one to remove test instances (to keep this PR as simple as possible).
All SDK Contribution checklist:

[x] The pull request does not introduce [breaking changes]
[x] CHANGELOG is updated for new features, bug fixes or other significant changes.
[x] I have read the contribution guidelines.

General Guidelines and Best Practices

[x] Title of the pull request is clear and informative.
[x] There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For more information on cleaning up the commits in your PR, see this page.

Testing Guidelines

[x] Pull request includes test coverage for the included changes.

/azp run python - keyvault - tests

API change check
API changes are not detected in this pull request.

/azp run python - keyvault - tests

/azp run python - keyvault - tests


high severity vulnerability in cross-spawn

# npm audit report

cross-spawn  <7.0.5
Severity: high
Regular Expression Denial of Service (ReDoS) in cross-spawn - https://github.com/advisories/GHSA-3xgq-45jj-v275

"npm-run-all": "^4.1.5"

"overrides": {
  "cross-spawn": "~7.0.5"
}

Not a long-term fix by any means but the above will address the issue in absence of a change.

Is this project still maintained

Is this project still maintained?

Wondering the same thing


Daniil: Watch sexypuss.com

Daniil requests the watch of the watch_keyword sexypuss\.com. See the MS search here and the Stack Exchange search here.

sexypuss\.com has been seen in 1 true positive, 0 false positives, and 0 NAAs.

Approved by Makyen in Charcoal HQ


add alexeystar.com

This PR is:

[x] Adding a new domain
[ ] Updating existing domain size
[ ] Changing domain name
[ ] Removing existing domain from list
[ ] Website code changes (512kb.club site)
[ ] Other not listed

[x] I used the uncompressed size of the site
[x] I have included a link to the Cloudflare report
[x] This site is not an ultra lightweight site
[x] The following information is filled identical to the data file

I confirm that I have read the FAQ section, particularly the two red items around minimal pages and inappropriate content and I attest that this site is neither of these things.

[x] Check to confirm

- domain: alexeystar.com
  url: https://alexeystar.com/
  size: 41.95
  last_checked: 2024-02-07

Cloudflare Report:
https://radar.cloudflare.com/scan/e300e4e1-471e-4b09-9c18-5966e074893d/summary

Thanks!


Reduce letter spacing in message content

It's currently 0.25px, a default we inherited from Material (for the bodyMedium style). That's too wide for reading prose, at least with the font we're using.
Likely we want letterSpacing: 0 instead; that's pending confirmation from @terpimost.
We might adjust some other letter spacings at the same time. In any case we can always file follow-up issues as we see other places to adjust.
Chat thread

Two other areas, from further discussion on the chat thread:

Let's set letter spacing in the compose box the same way (i.e. to 0px).
Let's set letter spacing to 1% (that is, .01 times the font size) for buttons.


Add words section

Description

Showing a words can remind a person a lot of things, this sentence can be inspirational, cherish the time, or a memo
Screenshot

I love this. This opens up extremely awesome potential to add essentially ANYTHING you want.

Thank you for the PR @lmfuture-ma.
But personally this doesn't provided any value to prompt as it stays same. Also see CONTRIBUTING.md#is-it-worth-to-be-aware-of-it. This might be better suited to our external sections wiki?

I totally agree with @salmanulfarzy. This seems like a great example of the external section.
Having a single word in a prompt is pretty straightforward to do. Anyone who needs this can create a custom section. Closing this since this will no be merged.
@lmfuture-ma please, ask any question if you need help with External section docs.
BTW, @salmanulfarzy I'm wondering about creating some kind of external package registry where users can find and easily install custom sections. Any thoughts about it?

BTW, @salmanulfarzy I'm wondering about creating some kind of external package registry where users can find and easily install custom sections. Any thoughts about it?

That would be great. Currently there are multiple new section PR pending and we can't accommodate most of them by default. So this could serve as single point to search for custom sections along with better handling of custom sections.

Closing this now, Feel free to create new issue if you face any issues with custom sections.


clkern.c::launchClKernel()::clWaitForEvents() never called

Hi,
In solution_seq.c::enqueueKernel() lines 186-188,  where nowait = 1 and needExecTime = 0, then
we got two if-conditions in clkern.c::launchClKernel() lines 104-120 to call the clWaitForEvents() function.
The problem is the (nowait, needExecTime) values set above seems make the execution not to
jump to any of these two if-condition, hence the event is never waited and may cause race-condition.
status = clEnqueueNDRangeKernel(...);
if ((status == CL_SUCCESS) && !kernDesc->nowait) {
       status = clWaitForEvents(1, kernDesc->event);
}
...
if ((status == CL_SUCCESS) && kernDesc->needExecTime && kernDesc->event) {
       if (kernDesc->nowait) {
            status = clWaitForEvents(1, kernDesc->event);
             ...
       }
}

Furthermore, I don't quiet understand the semantic of 'nowait' here, when we run kernels in sequence,
they may need to be synchronized sometimes (even often) to update results ?
Regards
Quan

Hi,
By design, clBLAS API are asynchronous. If you look at clBLAS.h you can see it is up to the user to pass in an event pointer to the library. Thus it is up to the user to "wait" for the event after the API call if needed.
When running kernels in sequence, if "CL_QUEUE_OUT_OF_ORDER_EXEC_MODE_ENABLE" is not set at clCreateCommandQueue (https://www.khronos.org/registry/cl/sdk/1.2/docs/man/xhtml/clCreateCommandQueue.html), each kernel will wait until previous kernels are finished before being executed.

Hi,
Thanks for your response.
Topic closed


E2E example with persistentVolumeReclaimPolicy: Delete doesn't work

PV create with persistentVolumeReclaimPolicy: Delete is failing with the error
Error getting deleter volume plugin for volume "pv-blobfuse": no volume plugin matched
What you expected to happen:
PV should get deleted and the backing container should also get deleted.
How to reproduce it:

Use the E2E example with SAS token.
Create PV with persistentVolumeReclaimPolicy: Delete
Delete the PVC.

Anything else we need to know?:
SAS token has all the RBAC permission
Environment:

CSI Driver version: Master
Kubernetes version (use kubectl version): v1.15.10
OS (e.g. from /etc/os-release):
Kernel (e.g. uname -a): Linux my-nginx-f969cff84-2qprc 4.15.0-1071-azure #76-Ubuntu SMP Wed Feb 12 03:02:44 UTC 2020 x86_64 GNU/Linux
Install tools:
Others:

@raushan2016 are you using static provioning: https://github.com/kubernetes-sigs/blobfuse-csi-driver/blob/master/deploy/example/e2e_usage.md#static-provisioninguse-an-existing-storage-account
We don't support delete volume if it's static provioning since the container is brought by user, it's user's responsibility to delete container.
We only support persistentVolumeReclaimPolicy: Delete in dynamic provisioning(by using storage class)


Update README.md

Q
A

Bug fix?
No

New feature?
No

BC breaks?
No

Deprecations?
No

Fixed tickets
N/A

Spelling correction.

Thank you!

I know it is not much, but every little bit helps right :). I can tell the team put a lot of work into deployer, just glad to be able to return something. :)


Move proxies migration

This PR moves the time delayed proxy migration from on_runtime_upgrade to a freestanding function in order to not trigger the migration on every runtime upgrade that uses this pallet.

thanks for the docs Shawn!

bot merge

Note: If using the introduced migration function, you should use storage guards to make sure it
only runs once.


container refresher added

For the developers to be able to use updated config parameters in notebook without clearing notebook state

Closed in favor of https://github.com/daipe-ai/daipe-core/pull/14


use mutex to protect mysql_real_query

This fixes https://github.com/duckdb/duckdb_mysql/issues/97. I suspect it may also fix https://github.com/duckdb/duckdb_mysql/issues/90

Thanks!


New gpt4 omni model is cheaper

https://x.com/simonw/status/1820886987982987413?t=6bZ-X7ApX-RtBDeBSfllow&s=19
We should consider making it default

The DEFAULT_MODEL and DEFAULT_VISION_MODEL are defined in _machinery.py . We should update both constants in this file to "gpt-4o-2024-08-06".
git-bob solve

git-bob solve


chore: bdd-sbhg-1584528340 to 0.0.1

chore: Promote bdd-sbhg-1584528340 to version 0.0.1

[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by:
To fully approve this pull request, please assign additional approvers.
We suggest the following additional approvers:
If they are not already assigned, you can assign the PR to them by writing /assign  in a comment when ready.
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment


refactor: reorder files and update sponsors

Fixes #33

Yeah, we won't cover the README for now, it's on Razvan

Will merge after the dark mode one


inference failed

when eval the model ! has a  error！
RuntimeError                              Traceback (most recent call last)
 in ()
5 except:
6     pass
----> 7 model.load_state_dict({k.replace('module.',''):v for k,v in torch.load(checkpoint_path)['state_dict'].items()})
8 _ = model.eval()
/home/btows/anaconda3/lib/python3.6/site-packages/torch/nn/modules/module.py in load_state_dict(self, state_dict, strict)
719         if len(error_msgs) > 0:
720             raise RuntimeError('Error(s) in loading state_dict for {}:\n\t{}'.format(
--> 721                                self.class.name, "\n\t".join(error_msgs)))
722
723     def parameters(self):
RuntimeError: Error(s) in loading state_dict for Tacotron2:
Unexpected key(s) in state_dict: "encoder.convolutions.0.1.num_batches_tracked", "encoder.convolutions.1.1.num_batches_tracked", "encoder.convolutions.2.1.num_batches_tracked", "postnet.convolutions.0.1.num_batches_tracked", "postnet.convolutions.1.1.num_batches_tracked", "postnet.convolutions.2.1.num_batches_tracked", "postnet.convolutions.3.1.num_batches_tracked", "postnet.convolutions.4.1.num_batches_tracked".

I think this is a pytorch version related problem.
What is your pytorch version?
Are you running the code from master without modifications?

I compiled with the latest Pytorch ! the code is master  without modifications!

@raulpuric any thoughts on this error?

That's strange behavior.
Can you print(model.state_dict()['keys']).
Is there any chance you are running BatchNorm with track_running_stats=False?

..../tacotron2/layers.py:35: UserWarning: nn.init.xavier_uniform is now deprecated in favor of nn.init.xavier_uniform_.
self.conv.weight, gain=torch.nn.init.calculate_gain(w_init_gain))
.../tacotron2/layers.py:15: UserWarning: nn.init.xavier_uniform is now deprecated in favor of nn.init.xavier_uniform_.
gain=torch.nn.init.calculate_gain(w_init_gain))
KeyError                                  Traceback (most recent call last)
 in ()
5 except:
6     pass
----> 7 print(model.state_dict()['keys'])
8 model.load_state_dict({k.replace('module.',''):v for k,v in torch.load(checkpoint_path)['state_dict'].items()})
9 _ = model.eval()
KeyError: 'keys'

sorry I meant model.state_dict().keys()

I'm facing the same problem. What was the solution?


Reduce size of initially loaded data

To increase the initial loading speed split the initially loaded DOM into components which are loaded separately and are cached client-side for the current version.


Add vlang icon

Adds vlang logo
SVG is optimized

Thanks for the PR! Might I suggest a slight tweak to the logo, we're trying to add our own color palette and slight modifications to make it fit with the rest of the icon set. What do you think about this:

@miguelsolorio that looks great! Lets go with that 👍🏼


Added i18n support for Thai

Checklist

[ ] All new and existing tests are passing
[ ] (If adding features:) I have added tests to cover my changes
[ ] (If docs changes needed:) I have updated the documentation accordingly.
[ ] I have added an entry to CHANGES.rst because this is a user-facing change or an important bugfix
[ ] I have written proper commit message(s)

What changes does this Pull Request introduce?

...
Why is this necessary?

...

Hey, thank you for contributing! You may have noticed that your code currently does nothing.
You have to add the Thai translation .js file to the translation list inside i18n.js and state which kind of plural form describes the Thai language most accurately.
By plural form we mean that depending on the count of a thing, the grammar also slightly changes.
For English, this would be:

0 apples
One apple
2 apples
3 apples
... and so forth

Meaning that for a count of 0 and everything above 1, we say "apples", and only for 1, we say "apple". In code, this would be n !== 1 for the plural form and n === 1 for the singular form.
Here are two resources which might help:

https://docs.translatehouse.org/projects/localization-guide/en/latest/l10n/pluralforms.html
https://groups.drupal.org/node/5216

Here is my suggestion for you (you need to figure out where the correct pluralforms yourself):
diff --git a/isso/js/app/i18n.js b/isso/js/app/i18n.js
index 2579408..30a1632 100644
--- a/isso/js/app/i18n.js
+++ b/isso/js/app/i18n.js
@@ -28,6 +28,7 @@ var catalogue = {
     ru:      require("app/i18n/ru"),
     sk:      require("app/i18n/sk"),
     sv:      require("app/i18n/sv"),
+    th:      require("app/i18n/th"),
     tr:      require("app/i18n/tr"),
     uk:      require("app/i18n/uk"),
     vi:      require("app/i18n/vi"),
@@ -58,6 +59,7 @@ var pluralforms = function(lang) {
     case "nl":
     case "pt":
     case "sv":
+    case "th":
     case "tr":
     case "vi":
     case "zh":

For testing:
diff --git a/isso/demo/index.html b/isso/demo/index.html
index 1577253..cb4788d 100644
--- a/isso/demo/index.html
+++ b/isso/demo/index.html
@@ -11,6 +11,7 @@

    <script src="../js/embed.dev.js"
            data-isso="../"
+           data-isso-lang="th"
            ></script>
    <!-- Uncomment to only test count functionality: -->
    <!-- <script src="../js/count.dev.js"></script> -->


Installation issue

My environment:
$ ruby --version
ruby 2.4.0p0 (2016-12-24 revision 57164) [x86_64-linux]

$ uname --all
Linux snowball 4.9.6-1-ARCH #1 SMP PREEMPT Thu Jan 26 09:22:26 CET 2017 x86_64 GNU/Linux

So,
$ gem install softcover

Building native extensions.  This could take a while...
Successfully installed nokogiri-<IP_ADDRESS>
Fetching: yajl-ruby-1.2.1.gem (100%)
Building native extensions.  This could take a while...
ERROR:  Error installing softcover:
	ERROR: Failed to build gem native extension.

    current directory: /home/o3o/.gem/ruby/2.4.0/gems/yajl-ruby-1.2.1/ext/yajl
/usr/bin/ruby -r ./siteconf20170304-4967-cqddp.rb extconf.rb
creating Makefile

current directory: /home/o3o/.gem/ruby/2.4.0/gems/yajl-ruby-1.2.1/ext/yajl
make "DESTDIR=" clean

current directory: /home/o3o/.gem/ruby/2.4.0/gems/yajl-ruby-1.2.1/ext/yajl
make "DESTDIR="
compiling yajl.c
compiling yajl_alloc.c
compiling yajl_buf.c
compiling yajl_encode.c
compiling yajl_ext.c
yajl_ext.c: In function ‘rb_yajl_parser_parse’:
yajl_ext.c:471:17: warning: variable ‘stat’ set but not used [-Wunused-but-set-variable]
     yajl_status stat;
                 ^~~~
yajl_ext.c: In function ‘rb_yajl_encoder_enable_json_gem_ext’:
yajl_ext.c:881:22: error: ‘rb_cFixnum’ undeclared (first use in this function)
     rb_define_method(rb_cFixnum, "to_json", rb_yajl_json_ext_fixnum_to_json, -1);
                      ^~~~~~~~~~
yajl_ext.c:881:22: note: each undeclared identifier is reported only once for each function it appears in
make: *** [Makefile:242: yajl_ext.o] Error 1

I think the problem is  here,  solved in yajl rel 1.3.0

It looks like the yajl-ruby dependency hasn't been updated for Ruby 2.4
yet, which isn't all that surprising given how new 2.4 is.
I tried updating the polytexnic gem to yajl-ruby 1.3, but it isn't
compatible with pygments.rb 0.6. I tried upgrading to pygments.rb 1.1, but
that broke the polytexnic test suite.
Unfortunately, upgrading to pygments 1.1 is very low on my current priority
list. I'm open to pull requests, though. Just make sure any diffs preserve
the current syntax highlighting.
I've updated the Softcover manual indicating that the softcover gem doesn't
currently work with Ruby 2.4. In the meantime, I suggest using an earlier
version of Ruby, as the system works fine with Ruby 2.3 or earlier.
Hope this helps,
Michael
On Sat, Mar 4, 2017 at 1:51 AM, o3o<EMAIL_ADDRESS>wrote:

My environment:
$ ruby --version
ruby 2.4.0p0 (2016-12-24 revision 57164) [x86_64-linux]
$ uname --all
Linux snowball 4.9.6-1-ARCH #1 SMP PREEMPT Thu Jan 26 09:22:26 CET 2017 x86_64 GNU/Linux
So,
$ gem install softcover
Building native extensions.  This could take a while...
Successfully installed nokogiri-<IP_ADDRESS>
Fetching: yajl-ruby-1.2.1.gem (100%)
Building native extensions.  This could take a while...
ERROR:  Error installing softcover:
ERROR: Failed to build gem native extension.
current directory: /home/o3o/.gem/ruby/2.4.0/gems/yajl-ruby-1.2.1/ext/yajl

/usr/bin/ruby -r ./siteconf20170304-4967-cqddp.rb extconf.rb
creating Makefile
current directory: /home/o3o/.gem/ruby/2.4.0/gems/yajl-ruby-1.2.1/ext/yajl
make "DESTDIR=" clean
current directory: /home/o3o/.gem/ruby/2.4.0/gems/yajl-ruby-1.2.1/ext/yajl
make "DESTDIR="
compiling yajl.c
compiling yajl_alloc.c
compiling yajl_buf.c
compiling yajl_encode.c
compiling yajl_ext.c
yajl_ext.c: In function ‘rb_yajl_parser_parse’:
yajl_ext.c:471:17: warning: variable ‘stat’ set but not used [-Wunused-but-set-variable]
yajl_status stat;
^~~~
yajl_ext.c: In function ‘rb_yajl_encoder_enable_json_gem_ext’:
yajl_ext.c:881:22: error: ‘rb_cFixnum’ undeclared (first use in this function)
rb_define_method(rb_cFixnum, "to_json", rb_yajl_json_ext_fixnum_to_json, -1);
^~~~~~~~~~
yajl_ext.c:881:22: note: each undeclared identifier is reported only once for each function it appears in
make: *** [Makefile:242: yajl_ext.o] Error 1
http://url
I think the problem is here
https://github.com/brianmario/yajl-ruby/issues/170, solved in yajl rel
1.3.0
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/softcover/softcover/issues/180, or mute the thread
https://github.com/notifications/unsubscribe-auth/AAAYWLBtMdkbJM4AXYigNroKt3rkD3KFks5riTQ1gaJpZM4MTCfV
.

--
Michael Hartl
michaelhartl.com

Thank you very much Michael, I will try with Ruby 2.3