Crash on start: Non-browser selected

Describe the bug
While the default system browser (where any link opens by default) is set to an actual browser (Brave, also tried setting to Chrome), for some reason an app that is not a browser and does not appear in the system browser selection (Revolut) is selected as TWA provider which causes a crash on start.
To Reproduce
Launching the app on my phone in debug mode returns these logs before the app crashes:
D/TWALauncherActivity: Using URL from Manifest (https://travelfeed.io/?utm_source=pwa).
D/TWAProviderPicker: Found browser: com.revolut.revolut
    Found browser: com.revolut.revolut
D/TWAProviderPicker: Found no TWA providers, using first browser: com.revolut.revolut
D/AndroidRuntime: Shutting down VM
E/AndroidRuntime: FATAL EXCEPTION: main
    Process: io.travelfeed.twa, PID: 14612
    java.lang.RuntimeException: Unable to start activity ComponentInfo{io.travelfeed.twa/com.google.androidbrowserhelper.trusted.LauncherActivity}: android.content.ActivityNotFoundException: No Activity found to handle Intent { act=android.intent.action.VIEW dat=https://travelfeed.io/... pkg=com.revolut.revolut (has extras) }
        at android.app.ActivityThread.performLaunchActivity(ActivityThread.java:3114)
        at android.app.ActivityThread.handleLaunchActivity(ActivityThread.java:3257)
        at android.app.servertransaction.LaunchActivityItem.execute(LaunchActivityItem.java:78)
        at android.app.servertransaction.TransactionExecutor.executeCallbacks(TransactionExecutor.java:108)
        at android.app.servertransaction.TransactionExecutor.execute(TransactionExecutor.java:68)
        at android.app.ActivityThread$H.handleMessage(ActivityThread.java:1948)
        at android.os.Handler.dispatchMessage(Handler.java:106)
        at android.os.Looper.loop(Looper.java:214)
        at android.app.ActivityThread.main(ActivityThread.java:7050)
        at java.lang.reflect.Method.invoke(Native Method)
        at com.android.internal.os.RuntimeInit$MethodAndArgsCaller.run(RuntimeInit.java:494)
        at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:965)
     Caused by: android.content.ActivityNotFoundException: No Activity found to handle Intent { act=android.intent.action.VIEW dat=https://travelfeed.io/... pkg=com.revolut.revolut (has extras) }
        at android.app.Instrumentation.checkStartActivityResult(Instrumentation.java:2018)
        at android.app.Instrumentation.execStartActivity(Instrumentation.java:1673)
        at android.app.Activity.startActivityForResult(Activity.java:4689)
        at androidx.fragment.app.FragmentActivity.startActivityForResult(FragmentActivity.java:767)
        at android.app.Activity.startActivityForResult(Activity.java:4647)
        at androidx.fragment.app.FragmentActivity.startActivityForResult(FragmentActivity.java:754)
        at android.app.Activity.startActivity(Activity.java:5008)
        at androidx.core.content.ContextCompat.startActivity(ContextCompat.java:251)
        at androidx.browser.customtabs.CustomTabsIntent.launchUrl(CustomTabsIntent.java:331)
        at com.google.androidbrowserhelper.trusted.TwaLauncher.lambda$static$0(TwaLauncher.java:51)
        at com.google.androidbrowserhelper.trusted.-$$Lambda$TwaLauncher$yiLzsm37NbSon1-dZ2dCvDJv8wU.launch(Unknown Source:0)
        at com.google.androidbrowserhelper.trusted.TwaLauncher.launch(TwaLauncher.java:166)
        at com.google.androidbrowserhelper.trusted.LauncherActivity.onCreate(LauncherActivity.java:158)
        at android.app.Activity.performCreate(Activity.java:7327)
        at android.app.Activity.performCreate(Activity.java:7318)
        at android.app.Instrumentation.callActivityOnCreate(Instrumentation.java:1271)
        at android.app.ActivityThread.performLaunchActivity(ActivityThread.java:3094)
        at android.app.ActivityThread.handleLaunchActivity(ActivityThread.java:3257)
        at android.app.servertransaction.LaunchActivityItem.execute(LaunchActivityItem.java:78)
        at android.app.servertransaction.TransactionExecutor.executeCallbacks(TransactionExecutor.java:108)
        at android.app.servertransaction.TransactionExecutor.execute(TransactionExecutor.java:68)
        at android.app.ActivityThread$H.handleMessage(ActivityThread.java:1948)
        at android.os.Handler.dispatchMessage(Handler.java:106)
        at android.os.Looper.loop(Looper.java:214)
        at android.app.ActivityThread.main(ActivityThread.java:7050)
        at java.lang.reflect.Method.invoke(Native Method)
        at com.android.internal.os.RuntimeInit$MethodAndArgsCaller.run(RuntimeInit.java:494)
        at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:965)

Expected behavior
The app should not crash
Smartphone (please complete the following information):

Device: SM-G950F
OS: Android 9 on newest patch (April 1 2020)
Browser: Brave Browser

Originally posted at https://github.com/GoogleChromeLabs/bubblewrap/issues/143
@tiotdev FYI

The library retrieves a list of browsers from PackageManager to check applications that can handle the following Intent:
Intent queryBrowsersIntent = new Intent()
                .setAction(Intent.ACTION_VIEW)
                .addCategory(Intent.CATEGORY_BROWSABLE)
                .setData(Uri.parse("http://"));

It seems com.revolut.revolut is returned by the PackageManager (unexpected), but doesn't handle  https://travelfeed.io/?utm_source=pwa (expected).  I'll take a look at how com.revolut.revolut is configured to understand why it's being returned by the PackageManager.
@PEConn FYI

I reproduced this by uninstalling / disabling all browsers on the device, installing Revolut and opening a Trusted Web Activity. I get the same stacktrace on logcat.
Running
adb shell query-activities -a android.intent.action.VIEW -c android.intent.category.BROWSABLE -d http://

outputs:
1 activities found:
  Activity #0:
    priority=0 preferredOrder=0 match=0x308000 specificIndex=-1 isDefault=true
    ActivityInfo:
      name=com.revolut.ui.deeplink.ExternalDeeplinkRoutingActivity
      packageName=com.revolut.revolut
      enabled=true exported=true directBootAware=false
      taskAffinity=com.revolut.revolut targetActivity=null persistableMode=PERSIST_ROOT_ONLY
      launchMode=3 flags=0x300200 privateFlags=0x0 theme=0x0
      screenOrientation=1 configChanges=0x3 softInputMode=0x0
      lockTaskLaunchMode=LOCK_TASK_LAUNCH_MODE_DEFAULT
      resizeMode=RESIZE_MODE_UNRESIZEABLE
      ApplicationInfo:
        name=com.revolut.RevolutApplication
        packageName=com.revolut.revolut
        labelRes=0x7f120173 nonLocalizedLabel=null icon=0x7f0f0000 banner=0x0
        className=com.revolut.RevolutApplication
        processName=com.revolut.revolut
        taskAffinity=com.revolut.revolut
        uid=10428 flags=0x20983e44 privateFlags=0x2c000910 theme=0x7f130010
        requiresSmallestWidthDp=0 compatibleWidthLimitDp=0 largestWidthLimitDp=0
        sourceDir=/data/app/com.revolut.revolut-7N-EPJjTnQuxe9Ki1Iov0g==/base.apk
        splitSourceDirs=[/data/app/com.revolut.revolut-7N-EPJjTnQuxe9Ki1Iov0g==/split_config.arm64_v8a.apk, /data/app/com.revolut.revolut-7N-EPJjTnQuxe9Ki1Iov0g==/split_config.en.apk, /data/app/com.revolut.revolut-7N-EPJjTnQuxe9Ki1Iov0g==/split_config.pt.apk, /data/app/com.revolut.revolut-7N-EPJjTnQuxe9Ki1Iov0g==/split_config.xxxhdpi.apk]
        resourceDirs=[/product/overlay/NavigationBarMode2Button/NavigationBarMode2ButtonOverlay.apk]
        seinfo=default:targetSdkVersion=29
        seinfoUser=:complete
        dataDir=/data/user/0/com.revolut.revolut
        deviceProtectedDataDir=/data/user_de/0/com.revolut.revolut
        credentialProtectedDataDir=/data/user/0/com.revolut.revolut
        splitClassLoaderNames=[null, null, null, null]
        enabled=true minSdkVersion=21 targetSdkVersion=29 versionCode=603701241 targetSandboxVersion=1
        supportsRtl=false
        fullBackupContent=true
        networkSecurityConfigRes=0x7f150004
        HiddenApiEnforcementPolicy=2
        usesNonSdkApi=false
        allowsPlaybackCapture=true

The intent-filter that seems to be matching the query in Revolut's APK is the following:
<intent-filter>
        <action
                android:name="android.intent.action.VIEW" />

        <category
                android:name="android.intent.category.DEFAULT" />

        <category
                android:name="android.intent.category.BROWSABLE" />

        <data
                android:scheme="http"
                android:host="@string/0x2f" />

         <data
                android:scheme="https"
                android:host="@string/0x2f" />

        <data
                android:scheme="http"
                android:host="@string/0x2f" />

        <data
                android:scheme="https"
                android:host="@string/0x2f" />
</intent-filter>

I'm not sure what @string/0x2f matches in their APK yet.
CC @PEConn

I am seeing a similar issue using the TWA repository to submit my app to the Play Store
ava.lang.RuntimeException:
at android.app.ActivityThread.performLaunchActivity (ActivityThread.java:3555)
at android.app.ActivityThread.handleLaunchActivity (ActivityThread.java:3707)
at android.app.servertransaction.LaunchActivityItem.execute (LaunchActivityItem.java:83)
at android.app.servertransaction.TransactionExecutor.executeCallbacks (TransactionExecutor.java:135)
at android.app.servertransaction.TransactionExecutor.execute (TransactionExecutor.java:95)
at android.app.ActivityThread$H.handleMessage (ActivityThread.java:2220)
at android.os.Handler.dispatchMessage (Handler.java:107)
at android.os.Looper.loop (Looper.java:237)
at android.app.ActivityThread.main (ActivityThread.java:8016)
at java.lang.reflect.Method.invoke (Method.java)
at com.android.internal.os.RuntimeInit$MethodAndArgsCaller.run (RuntimeInit.java:493)
at com.android.internal.os.ZygoteInit.main (ZygoteInit.java:1076)
Caused by: android.content.ActivityNotFoundException:
at android.app.Instrumentation.checkStartActivityResult (Instrumentation.java:2071)
at android.app.Instrumentation.execStartActivity (Instrumentation.java:1717)
at android.app.Activity.startActivityForResult (Activity.java:5252)
at androidx.fragment.app.FragmentActivity.startActivityForResult (FragmentActivity.java:10)
at android.app.Activity.startActivityForResult (Activity.java:5203)
at androidx.fragment.app.FragmentActivity.startActivityForResult (FragmentActivity.java:10)
at android.app.Activity.startActivity (Activity.java:5581)
at androidx.core.content.ContextCompat.a (ContextCompat.java:6)
at androidx.browser.customtabs.CustomTabsIntent.a (CustomTabsIntent.java:9)
at com.google.androidbrowserhelper.trusted.TwaLauncher.a (TwaLauncher.java:15)
at com.google.androidbrowserhelper.trusted.TwaLauncher.lambda$DcoyqNl3MYmlYZ4RwM3iIQA9ag4 (TwaLauncher.java)
at com.google.androidbrowserhelper.trusted.-$$Lambda$e$DcoyqNl3MYmlYZ4RwM3iIQA9ag4.launch (Unknown Source)
at com.google.androidbrowserhelper.trusted.TwaLauncher.a (TwaLauncher.java:16)
at com.google.androidbrowserhelper.trusted.LauncherActivity.onCreate (LauncherActivity.java:185)
at android.app.Activity.performCreate (Activity.java:7957)
at android.app.Activity.performCreate (Activity.java:7946)
at android.app.Instrumentation.callActivityOnCreate (Instrumentation.java:1307)
at android.app.ActivityThread.performLaunchActivity (ActivityThread.java:3530)
at android.app.ActivityThread.handleLaunchActivity (ActivityThread.java:3707)
at android.app.servertransaction.LaunchActivityItem.execute (LaunchActivityItem.java:83)
at android.app.servertransaction.TransactionExecutor.executeCallbacks (TransactionExecutor.java:135)
at android.app.servertransaction.TransactionExecutor.execute (TransactionExecutor.java:95)
at android.app.ActivityThread$H.handleMessage (ActivityThread.java:2220)
at android.os.Handler.dispatchMessage (Handler.java:107)
at android.os.Looper.loop (Looper.java:237)
at android.app.ActivityThread.main (ActivityThread.java:8016)
at java.lang.reflect.Method.invoke (Method.java)
at com.android.internal.os.RuntimeInit$MethodAndArgsCaller.run (RuntimeInit.java:493)
at com.android.internal.os.ZygoteInit.main (ZygoteInit.java:1076)

The issue started showing up in the crash logs April 19th even though nothing was updated on our side.

Also started to get this same error on the 16th April, and it is still ongoing:

This error seems similar to one when we first created our TWA, but google released an updated custom tabs version to rectify the error. So to be explicit, our implementation is set to:
 implementation 'com.github.GoogleChrome:custom-tabs-client:809a55cfa2'

Also started to get this same error on the 16th April, and it is still ongoing:

This error seems similar to one when we first created our TWA, but google released an updated custom tabs version to rectify the error. So to be explicit, our implementation is set to:
 implementation 'com.github.GoogleChrome:custom-tabs-client:809a55cfa2'

@dazbradbury a bit unrelated to this issue, but the recommended way of using Trusted Web Activity is via android-browser-helper currently: https://developers.google.com/web/android/trusted-web-activity/android-browser-helper-migration

@andreban Thanks - happy to update now. Would I be able to tell users this will fix the issue we're seeing, or is this issue present in both the latest and old versions of how the TWA libraries are accessed?

Sounds like it's unrelated from the way he phrased it. But please update us if it by any chance fixes the issue.

For this particular error, unlikely - But there are other issues fixed in the new library, and many other features.
This comment https://github.com/GoogleChrome/android-browser-helper/issues/89#issuecomment-619984167 describes what I could understand from the issue - It's about PackageManager returning an app that doesn't actually handle the URL we're trying to launch. So, when we actually try to launch we get an ActvityNotFoundException. The logic for picking the provider is here.
In the case of TrustedWebActivity, we know the URL that's going to be launched beforehand. I'm wondering if it's worth running the PackageManager against startUrl - This may return the app itself as a handler, but we know the package and can ignore it.
@PEConn, thoughts?

Just to confirm - having updated the app, we're still seeing exceptions on the latest version:

`java.lang.RuntimeException` --> `Caused by: android.content.ActivityNotFoundException: `

java.lang.RuntimeException:
  at android.app.ActivityThread.performLaunchActivity (ActivityThread.java:3447)
  at android.app.ActivityThread.handleLaunchActivity (ActivityThread.java:3594)
  at android.app.servertransaction.LaunchActivityItem.execute (LaunchActivityItem.java:83)
  at android.app.servertransaction.TransactionExecutor.executeCallbacks (TransactionExecutor.java:135)
  at android.app.servertransaction.TransactionExecutor.execute (TransactionExecutor.java:95)
  at android.app.ActivityThread$H.handleMessage (ActivityThread.java:2146)
  at android.os.Handler.dispatchMessage (Handler.java:107)
  at android.os.Looper.loop (Looper.java:237)
  at android.app.ActivityThread.main (ActivityThread.java:7777)
  at java.lang.reflect.Method.invoke (Native Method)
  at com.android.internal.os.RuntimeInit$MethodAndArgsCaller.run (RuntimeInit.java:493)
  at com.android.internal.os.ZygoteInit.main (ZygoteInit.java:1047)
Caused by: android.content.ActivityNotFoundException:
  at android.app.Instrumentation.checkStartActivityResult (Instrumentation.java:2071)
  at android.app.Instrumentation.execStartActivity (Instrumentation.java:1717)
  at android.app.Activity.startActivityForResult (Activity.java:5276)
  at androidx.fragment.app.FragmentActivity.startActivityForResult (FragmentActivity.java:767)
  at android.app.Activity.startActivityForResult (Activity.java:5234)
  at androidx.fragment.app.FragmentActivity.startActivityForResult (FragmentActivity.java:754)
  at android.app.Activity.startActivity (Activity.java:5605)
  at androidx.core.content.ContextCompat.startActivity (ContextCompat.java:251)
  at androidx.browser.customtabs.CustomTabsIntent.launchUrl (CustomTabsIntent.java:331)
  at com.google.androidbrowserhelper.trusted.TwaLauncher.lambda$static$0 (TwaLauncher.java:51)
  at com.google.androidbrowserhelper.trusted.-$$Lambda$TwaLauncher$yiLzsm37NbSon1-dZ2dCvDJv8wU.launch (Unknown Source)
  at com.google.androidbrowserhelper.trusted.TwaLauncher.launch (TwaLauncher.java:166)
  at com.google.androidbrowserhelper.trusted.LauncherActivity.onCreate (LauncherActivity.java:158)
  at android.app.Activity.performCreate (Activity.java:7981)
  at android.app.Activity.performCreate (Activity.java:7970)
  at android.app.Instrumentation.callActivityOnCreate (Instrumentation.java:1307)
  at android.app.ActivityThread.performLaunchActivity (ActivityThread.java:3422)

Seems to be effecting new devices. Let me know if I can provide any more insight / examples, otherwise thanks for the work and look forward to a fix!

Can you reproduce on a dev device? I'd be interested to know if there's another app other than com.revolut.revolut causing the issue.

Apologies - I've not had a chance to run further tests on this.
I did notice this thread: https://news.ycombinator.com/item?id=23277594
And wonder if there is any correlation between this app accidentally appearing as a browser, and Revolut doing the same.

I've not been able to reproduce. I can see that we've had 322 reports in the last 7 days (not huge, but not insignificant).

Error is:

If I simply install Revolut on a device, and try opening a TWA, I don't get the issue. I'm not sure if having a Revolut account would make a difference, but if it does, I only tested with the app installed (no account logged into).

Can you check if any of those exceptions include information on the Intent?
eg:
Caused by: android.content.ActivityNotFoundException: No Activity found to handle Intent { act=android.intent.action.VIEW dat=https://travelfeed.io/... pkg=com.revolut.revolut (has extras) }

I'm afraid it doesn't seem the google play console provides that information (unless I'm missing something?). There is a second similar exception though that is logged as a second "crash cluster":

But I'm not sure if that's helpful at all.

In response to this comment, what we probably want to do is look for the intersection of the two groups.
If we just look for apps that can handle "https://", apparently from this bug we get some apps that pretend to be browsers but aren't. If we just look for apps that can handle the start url, we'll get the TWA app and any other native apps for that site (eg, say your website also has a native app, it will trigger that).
So we should look for apps that can handle "https://" and the start url.

A couple other options:

providerPicker to not send a package when the result is BROWSER: https://github.com/GoogleChrome/android-browser-helper/blob/master/androidbrowserhelper/src/main/java/com/google/androidbrowserhelper/trusted/TwaProviderPicker.java#L170-L171
or do a similar thing in the TwaLauncher: https://github.com/GoogleChrome/android-browser-helper/blob/master/androidbrowserhelper/src/main/java/com/google/androidbrowserhelper/trusted/TwaLauncher.java#L165-L169

#104 should fix this

Awesome - just to clarify for myself (and potentially others reading), what's the release process in terms of getting this fix from being merged to our actual users?

I have prepared a package (1.3.1-alpha01) today. The plan is to make it available to use tomorrow via the Google Maven. I'll update the the issue once available. When we have some apps using it and we can confirm the issue is indeed fixed, we'll release 1.3.1.

We have released version 1.3.1-alpha01 with the fix:
 implementation 'com.google.androidbrowserhelper:androidbrowserhelper:1.3.1-alpha01'

The problem seems to be that some apps advertise to handle http:// Intents, but for other URLs, so we detected them as browsers and used them as a fallback when a browser that supports Custom Tabs and Trusted Web Activity weren't available.
Here's how to reproduce the issue with version 1.3.0:
1. Disable Chrome from the settings
2. Uninstall any other browser
3. Install Revolut
4. Install DuckduckGo or any browser that doesn't support custom tabs or twas
5 start the app

Expected result:
We'd expect the URL to open in DuckDuckGo,

Actual result
It tries to open Revolut and crashes.

This is not reproducible anymore with 1.3.1-alpha01.
One interesting point is that given we fallback to Custom Tabs first, I'd expect this to be happening to a small number of users.
Besides the crashes, have you seen any user reports from reviews, etc? It'd be interesting if you are able to reach out to those users and understand which browser / versions combination they are using.

Besides the crashes, have you seen any user reports from reviews, etc? It'd be interesting if you are able to reach out to those users and understand which browser / versions combination they are using.

I will ask users if they're willing to help with this - but yes, we've had a number of reviews reporting crashes and this is the only error in the Play Console, so have to assume is the cause.
If users do respond, will ask them what browsers (and versions) they have installed. Would you like to know if they use Revolut / other apps explicitly?

I head some confirmations that this indeed fixed the issue. Please, re-open if someone still sees it after updating to 1.3.1-alpha01.

Can confirm after the update I stopped seeing this error.

1.3.1 stable has released.


Add MSRV upgrade policy

Taken from embedded-hal. Should be suitable here as well.

ugh, the check names in bors are broken due to the changes in #22 and I didn't notice because I force-merged it :sweat:


Energized is nearly dead and it's going on only with automatisms

Hi,
I thank dev(s) for their time and the project, but I am afraid to state that Energized is nearly dead and it's going on only with automatisms.
Main developer @AdroitAdorKhan does not reply to emails or fix issues. If you search for the closed issues, they have been closed by the same author who posted them and the last involvement by dev is 29 October 2021 (https://github.com/EnergizedProtection/block/issues/821)
List issues (whitelist or blacklist) had been fixed only by the owner of the original list, for instance I contacted 1hosts to solve this  https://github.com/EnergizedProtection/block/issues/914.
However, due to how Energized list have been built, searching for the origin of a list issue by an average user is really time consuming since you have to go to https://github.com/EnergizedProtection/block#sources and manually check every source (and they are a lot if you are not lucky)
As far as I learnt:
Energized had huge problems with unresponsive admin(s) ever since 2020, as well as voluntary project team members not being given sufficient GitHub rights to handle all those issues.
Energized have been removed from Blokada (the most prominent adblocker it was included in) for these reasons.
If devs are really reading this, please take actions solving opened issues. Using Energized as it is now, it's deleterious since many sites are just broken and end-users are left at their own.
For users that have no idea where to go now, please have a look at GoodbyeAds, OISD (basic or full) or just find what you like
Best regards
Luca

Unfortunately, GoodbyeAds and OISD Full are both too large causing high CPU usage with Unbound. OISD Basic is great but doesn’t include any malicious domains…

Unfortunately, GoodbyeAds and OISD Full are both too large causing high CPU usage with Unbound. OISD Basic is great but doesn’t include any malicious domains…

Try:
https://o0.pages.dev/Pro/unbound.conf
https://o0.pages.dev/Pro/rpz.txt

Unfortunately, GoodbyeAds and OISD Full are both too large causing high CPU usage with Unbound. OISD Basic is great but doesn’t include any malicious domains…

lists
you could try The BlockList Project since it is modular
programs
data based on today:
Energized Basic | 360,119
OISD full | 339,980
Energized Blu | 228,291
GoodbyeAds | 213,266
as you can see in terms of entries number, there are not many differences
on OISD they states
list might be too big for your adblocker and could cause problems. Use at your own risk! That said: It's known to work flawlessly in Pi-hole
Pi-hole is meant to run in a Raspberry system, which has not a lot of resources. I advise you to

try Pi-hole
open a bug with unbound since it is made to be "fast and lean". But check you had chosen the right OISD format list for your program

@badmojr thanks, I’ll have a look at your project and these lists.

Unfortunately, GoodbyeAds and OISD Full are both too large causing high CPU usage with Unbound. OISD Basic is great but doesn’t include any malicious domains…

If you are not stuck with Unbound and can use another DNS resolved consider using Knot Resolver with RPZ blocklists. OISD Full list takes 0ms to resolve. It's very fast.
Check this blog post for more info.

@lucamp thanks for your suggestions. Energized Pro Spark should come to about 70k entries total and covers quite a bit. Rarely breaks something genuine despite the project status. As for the Unbound issue, it seems to be a common complaint with reports across different Unbound-based projects going years back. Interestingly, Unbound works with absolutely no issues as long as you don't go 'overboard' with DNSBLs. Pi-hole being a common suggestion, I suppose it either uses a different Unbound (Python-based?) or uses something else altogether? Will look into switching off of Unbound at some point either way.
@2brownc very interesting info, thanks!


librscalibrationapi not not available on jetson xavier

Issue Description
I am attempting to build our software stack that uses librealsense for the xavier. I was able to get the librealsense to build. i can get realsense-viewer and other tools working fine (using the jetsonhacks blog). However i am stuck because the librscalibrationapi package source code is not avaialble for me to build it directly on the platform. It basically is a show stopper because our application requires access to that library.
a) Is the source code avaialable somewhere?
b) If not, what are the plans for providing a version for
Linux jetson-0423018054170 4.9.108-tegra #1 SMP PREEMPT Wed Oct 31 15:17:21 PDT 2018 aarch64 aarch64 aarch64 GNU/Linux

Hi @kgrtr,
We are working on to improve and expand the supports for the Dynamic Calibration tool and the Calibration API libraries support on other platforms. It is currently a closed source library.
Just out of curiosity. are you using the calibration api for integration of your custom calibration process? Thank you.
Regards,
Yusheng

we do not use factory Calibration and use this to retrieve and modify. This is really a show stopper

@RealSenseCustomerSupport It also appears that librscalibrationapi in unavailable for Ubuntu Bionic 18.04.
Can we please get this packaged for the latest Ubunutu LTS release?
(Should I open a new issue for this?)

See also #3730.

@RealSenseCustomerSupport  We need librscalibrationapi on Ubuntu 18.04 Bionic as well. Is there any progress?
We are unable to use the 16.04 version as suggested in #3730 due to dependencies on libraries (libpng12-dev and libpng12-0) that have been removed in 18.04.


Remove the Player Reporting and Telemetry Data Buttons

Idea
You should make it an option to remove the Player Reporting and Telemetry Data Buttons in the config.
Reasoning
The Player Reporting and Telemetry Data Buttons serve no purpose with the mod installed, and should be removed, or at least a toggle in the config.
The addition of the Telemetry Data button adds a new row for buttons on the menu. This shifts the placement of the Done button and can mess with players who are used to the positioning in 1.19.2 and below.
Other Information
This is possible. There is a mod that does this but it isn't supported anymore. https://modrinth.com/mod/nrb

Player Reporting has its use of showing the Social Interactions view though, which was previously very much hidden. And from there players can hide others' messages or block them on Xbox.

Well, you should be able to have a toggle in the config for the people that don't want it there, such as myself.

I would rather have #322 and #154 separately as they are different concerns. Will close this and reopen those two.


Modal Focus

The Modal element does not focus on a select, checkbox, radio, or switch element if it's the first element in the modal form.

Fixed in #128


v1.9 backports 2021-04-13

#15540 -- bpf: Extend datapath options for K8sVerifier test (@pchaigno)

Dropped d380acf ("bpf/Makefile: Disable custom calls on 4.19")
Removed ENABLE_CUSTOM_CALLS, ENABLE_DSR_ICMP_ERRORS and ENABLE_EGRESS_GATEWAY references from 0ad05db ("bpf/Makefile: Move global config options to MAX_BASE_OPTIONS") and 68ba5d4 ("bpf/Makefile: Disable Maglev for bpf_host and bpf_lxc")

#15590 -- ctmap: do not call InitMapInfo() in init() (@kkourt)
#15622 -- Fix ethtool issues (@tklauser)
#15260 -- mtu: Switch to v/netlink for querying netdevs (@brb)
#15589 -- Kata: Mention incompatibility with host-reachable services or strict KPR in documentation (@qmonnet)

Once this PR is merged, you can update the PR labels via:
$ for pr in 15540 15590 15622 15260 15589; do contrib/backporting/set-labels.py $pr done 1.9; done

test-backport-1.9

Compilation fails with
# github.com/cilium/cilium/pkg/datapath/linux/ethtool
../pkg/datapath/linux/ethtool/ethtool.go:66:8: undefined: unix.ETHTOOL_GDRVINFO

I may just need to update golang.org/x/sys/unix

test-backport-1.9

test-backport-1.9

retest-gke

retest-gke

Complexity issue on 4.19, looking into it
BPF program is too large. Processed 131073 insn

My commit looks good! Thanks!

test-backport-1.9


include VERSION for godep

Recently when using godep we have inconsistent behavior between our development machines. Though the godep help had the same output there was definitely difference in its execution.
It would have been useful to have a godep version to see that we were using different versions. In the end the way we figured out was by doing shasum godep on each workstation to find there was a difference in the compiled binaries.
Can this be added with a pull request?

Please PR if you are still interested in this. I think it's becoming increasingly important.

Resolved in b6a021fcf062a94ce1248fc29c49414739c171b4.


hide the compose completion page until it's available for v2

Proposed changes
Hide the completion.md page until we have a completion script available for Compose v2
Related issues (optional)
fix #14692 and https://github.com/docker/compose/issues/8550

a fix should be available soon-ish :P https://github.com/docker/compose/pull/9462


Performance on Vanilla GAN ?

Did you trying using the Vanilla GAN before using W-GAN ? I tried your approach using Vanilla GAN on toy 2D data and it does not work and wanted to ask whether you faced similar problems.

I did try it. It did work for my toy problem but did not perform well on
VGG Faces for example. LS-GAN and standard GANs worked very well on
Omniglot.
On Fri, 2 Nov 2018 at 20:36, Debasmit Das<EMAIL_ADDRESS>wrote:

Did you trying using the Vanilla GAN before using W-GAN ? I tried your
approach using Vanilla GAN on toy 2D data and it does not work and wanted
to ask whether you faced similar problems.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/AntreasAntoniou/DAGAN/issues/10, or mute the thread
https://github.com/notifications/unsubscribe-auth/AKSuNo9oRWV62B7jN3TUjTsCWY_Fz0Dwks5urKyzgaJpZM4YMSwm
.

Thanks for the quick response. I am trying on 2D data with gaussian classes. I am trying to learn from 3 classes and trying generate samples for the 4th class for which only a single sample exists. The results look something like this -


Request new version for cocoapods

Hi. I'm working download heavy images so I need not caching on memory. There was a commit for this but it has not been available in pod yet. I can't install by dragging to project because I'm using MWPhotoBrowser which include SDWebImage as subspec. So could you put a new version to pod contains this commit?
https://github.com/rs/SDWebImage/commit/df751e737b0236c942a3f9e10f63c968b2d54fdd
Thank you.

Version 3.7.4 is out.


New issue button bug

When I hover the New issue button a little rectangle appear in the background.

If it is not a bug, maybe will be more prettier to change the button color when hovered.

I'll do something about this.

 What do you think?

Yeah sure man! And thanks for the compliment 😄


docs: fix a few simple typos

There are small typos in:

CONTRIBUTING.md
docs/development.rst
docs/index.rst
docs/logging.rst
docs/pubsub.rst
docs/upgrading.rst
rediscluster/client.py
rediscluster/connection.py
tests/test_cluster_node_manager.py
tests/test_commands.py
tests/test_encoding_cluster.py

Fixes:

Should read specified rather than specefied.
Should read implementation rather than impelmentation.
Should read upstream rather than uptream.
Should read iterate rather than itterate.
Should read recommended rather than reccommended.
Should read received rather than recieved.
Should read preferred rather than preffered.
Should read possibility rather than posiblity.
Should read interval rather than intervall.
Should read examples rather than exmaples.
Should read documentation rather than documentaion.

Closes #461

Nice contribution!

@timgates42 Thank you for these fixes :)


I need to always show the title of the textField even if it's empty

ℹ Please fill out this template when filing an issue.
All lines beginning with an ℹ symbol instruct you with
what info we expect.
Please remove this line and all above before submitting.

Before you start, are you using the latest SkyFloatingLabelTextField release?
Issues are for feature requests, and bugs; questions should go to Stack Overflow with
the tag skyfloatinglabeltextfield.

Report
What did you do?
ℹ Please replace this with what you did.
What did you expect to happen?
ℹ Please replace this with what you expected to happen.
What happened instead?
ℹ Please replace this with of what happened instead.
Environment
ℹ Please fill in this section with information about your environment
Xcode Version:
SkyFloatingLabelTextField Version:
Deployment Target:
Base SDK:
Method of Integration: CocoaPods | Carthage | Manual
Project that demonstrates the issue
ℹ Please link to a project we can download that reproduces the issue if applicable.

self.setTitleVisible(true)
Use this function


Shipment notifications seemingly not supported for in JSON API?  Say what?!

For years I've populated buyer email notifications via  in the XML API.  This triggers an immediate email to the package recipients email address.
Inexplicably, the same container in JSON references this is only for "Receiver Return Notification" (whatever that is).  If I include the container anyway, an erroneous error message {"code":"9120000","message":"Ship web service is currently unavailable." is returned.

It doesn't appear UPS are bothering to contribute to these threads, but should they do so, can someone let me know how this extremely basic function - shipment notifications - can be issued as before, and indeed the same as any other carrier in the globe.
Looking increasingly obvious this JSON API is a guaranteed downgrade - losing functionality.  It would appear nowhere near something they should be going live with.

Hi, thank you for your comment. The screenshot shown above is for package notifications tied to return shipments. Please reference Shipment Service Options -> Notifications for Shipment Notifications. We will look into updating the error message to be clearer.

Hi, we are closing this issue as completed. If there are any additional questions, please create a new issue.


scrape/scrape: Add log for label limits.

Add log for label limits to get the limit error details.
Signed-off-by: johncming<EMAIL_ADDRESS>

Examples that fail the check may or may not be printed.

I wanted to say that they should be truncated in length, not hidden. WDYT?

Discussed in the bug-scrub meeting; looks like no movement in nearly 2 years so closing to clean up.
If you come back to it, feel free to reopen or create a new PR.

Discussed in the bug-scrub meeting -- follow up. Still, this change is valid, just some limitation details are to be decided. Would happy to review/help if you want to get this done @johncming , so sorry for lack of response for so long!


Heapster API server init

Add an empty API server exposed on a separate port.
Also, changed flag "port" to "heapster-port" to avoid conflict with the generic API server flag.

This change is

Looks reasonable. @nikhiljindal could you please take a look? Our goal is to refactor Heapster to reuse genericapiserver library. This is the first step which creates apiserver without any resource.

What's the relationship between this, #1296 (which looks to be an extension of this), and #1294?

Should this have separate authorization, or just bounce off of the main API server use SARs, etc?

Separate authentication powered by the webhook authorizer.

Separate authentication powered by the webhook authorizer.

I think we're agreeing here -- my point was that you don't necessarily need/want the other auth mechanisms -- you just want the webhook one.

I think we're agreeing here -- my point was that you don't necessarily need/want the other auth mechanisms -- you just want the webhook one.

Yeah, your launch command probably doesn't need other options.

@DirectXMan12 about the other two PRs - they were the trials of different approaches to splitting this task into smaller parts. We ended up with this as the best solution, so those will be either closed or updated after this one is finished.

Didnt look too closely at the first Godeps commit.
The second commit mostly LGTM, apart from a comment regarding the port flag.

Also, what about tests?
Not sure what testing do you have around the heapster API server.

@DirectXMan12 @deads2k we are not sure how the current auth model in Heapster works, so to not break anything we are starting a new http server (using genericapiserver) library on a different port which uses exactly the same auth model that federated-apiserver uses. We will reach you to figure out the auth issues.

@nikhiljindal thanks for the review.
@mksalawa could you please flag-gate this change?

@nikhiljindal as for the tests - there are no resources registered yet, so once we have them, we'll reuse the existing tests for the Metrics API on a different endpoint. Would that be ok? As for now, we would actually check only if the endpoint is reachable.

LGTM

Tests on Travis passed, but Travis hangs forever.

Please file a bug or follow-up PR to discuss and/or fix the auth as per my comments and @deads2k's comments.


[WIP] Feat: Improve user thread title

Summary by Sourcery
Implement a feature to enhance the user's initial message as a thread title by leveraging AI models for text improvement, and introduce a utility function for consistent content extraction from response types.
New Features:

Introduce a feature to improve the user's initial message to serve as a thread title by correcting spelling and punctuation, and enhancing readability using AI models like OpenAI, Anthropic, and Perplexity.

Enhancements:

Add a utility function to extract string content from various response types, ensuring consistent handling of different content formats.

Summary by CodeRabbit
Summary by CodeRabbit

New Features

Enhanced message processing for chat actions, supporting a wider range of input types including text and images.
Added translation functionality to convert user messages into Spanish, improving accessibility for Spanish-speaking users.
Introduced a new ChatPanelHeader component for better management of chat interactions, including translation toggling.
Implemented a new TranslationProvider for centralized management of translation preferences across the application.
Added a dedicated translation icon to enhance the user interface.

Bug Fixes

Implemented error handling for title improvement failures, ensuring original message content is retained when necessary.

Chores

Updated session management to include authentication options for more flexible session retrieval.

Changelog

Added a new translateAndImproveTitle function that combines translation and title improvement.
Modified the existing improveTitle function to work with different AI clients.
Modified the ChatPanel component.
Added a translation toggle switch using the Switch component.
Implemented state for translateToSpanish.
Passed the translation state to the PromptForm component.
Updated the PromptForm component.
Added a visual indicator (green circle with translate icon) when translation is on.
Updated the Chat component.
Added state for translateToSpanish.
Modified the appendWithMbContextPrompts function to use translation when enabled.
Updated the call to ChatPanel to include translation-related props.
Integrated the translation feature into the existing chat flow.
Improve and translate the first message if translation is enabled.
Translate messages on-the-fly when the translation toggle is on.
Added a new file useTranslation.ts to handle the translation context.
Implemented useTranslation hook for easy access to translation state.

@Bran18 -- See these 3 prompts, they might help to get the translation and title improvement quickly.

Title Enhancer
Translator (In)
Translator (Out)

Alternatively, we can try with this one: The output would be the one that we send to our main AI call to have such context (Tool 1 and 2).
cc - @Nemunas @merivercap

Important Note:  This PR primarily serves as a reference for future enhancements. I'm closing this PR.
Related PR: https://github.com/bitcashorg/masterbots/pull/266


⚠ Bofrost.be has degraded performance

In 7471b11, Bofrost.be (https://www.bofrost.be) experienced degraded performance:

HTTP code: 200
Response time: 1506 ms

Resolved: Bofrost.be performance has improved in 3a3fae1.


[feature] Adding optional IDs as part of mutation API

From the discussion in slack around #594 , we discussed what the interface should be in creating links between multiple evidence tree nodes.
This brought up the question of how node inputs are done today, for example in IsDependency, PkgInputSpec is used to determine which pkg and depPkg to link.
This is usually implemented in the backend through making a look up to the node, and getting its ID to form the edge. Lookups during ingestion generally slow down the process (e.g. thus introducing the guacKey).
This proposal is to add an optional ID to each InputSpec so that, if provided the backend can use it to enable quick retrieval of the nodes that it needs to form edges around.
"Adds a dependency between two packages. The returned ID can be empty string."
  ingestDependency(
    pkg: PkgInputSpec!
    depPkg: PkgInputSpec!
    depPkgMatchType: MatchFlags!
    dependency: IsDependencyInputSpec!
  ): ID!

Would use the IDs provided in pkg and depPkg in:
"""
PkgInputSpec specifies a package for mutations.

This is different than PkgSpec because we want to encode mandatory fields:
type and name. All optional fields are given empty default values.
"""
input PkgInputSpec {
  ID: String               //Added optional field
  type: String!
  namespace: String = ""
  name: String!
  version: String = ""
  qualifiers: [PackageQualifierInputSpec!] = []
  subpath: String = ""
}

Based on the discussion in slack, the pkgInputSpec (and the other software tries: source and vulnerability) would need to contain all the IDs (for pkgType, pkgNamespace...etc) and not just the pkgVersion ID that the current pkgInputSpec returns.
So it would have to be:
input PkgInputSpec {
  typeID: ID               //Added optional field
  type: String!
  nameSpaceID: ID               //Added optional field
  namespace: String = ""
  nameID: ID               //Added optional field
  name: String!
  versionID: ID               //Added optional field
  version: String = ""
  qualifiers: [PackageQualifierInputSpec!] = []
  subpath: String = ""
}

similar for the other tries (source and vulnerability)

I will work on getting this completed to move forward with a more stable API for future releases

Based on discussions with @jeffmendoza  and thinking about this more, we would need to have some sort of union between the inputSpec and the ID. As it should be either and not require both. For example, for this usecase: https://github.com/guacsec/guac/pull/1367#discussion_r1370722663 we would want it to be either or and not both.

Based on discussion and experimentation, a union type cannot be created but a new inputType can be created similar to:
input IDorPkgInputSpec {
  packageID: ID
  pkg: PkgInputSpec
}

where the mutations would change to:
extend type Mutation {
  "Ingests a new package and returns a corresponding package hierarchy containing only the IDs. The returned ID can be empty string."
  ingestPackage(pkg: IDorPkgInputSpec!): PackageIDs!
  "Bulk ingests packages and returns the list of corresponding package hierarchies containing only the IDs. The returned array of IDs can be empty strings."
  ingestPackages(pkgs: [IDorPkgInputSpec!]!): [PackageIDs!]!
}

in this case, either the ID or the pkgInputSpec would have to be specified. In the case of pkgID, the ID can either be the pkgName ID or the pkgVersion ID and it is up to the backend to determine which it is.

closed via #1708


How to persist between requests?

Hey, following up per your tweet.
I'm a little confused on functionality here, and was hoping for some clarification! Is this lib meant to only authorize the first request after a twitter user signs in? When I run the example, if I visit / it says no auth. If you go to /auth/twitter it asks you to sign in with the app, and then redirects you to the callback with the relevant auth information. But then if you try to go back to / the auth is no longer present.
Is this intended? I'm unclear if the library is meant to authorize only the first request after you log in with Twitter (current behavior) or each request you make afterwards (maybe a bug?)

Hello Ian. Good question!

Is this lib meant to only authorize the first request after a twitter user signs in?
Yes, exactly.

The reason for that is very simple. Each project has a different from other way to keep authorization state. For example you can use jwt or just generate token and save it into the cookie. Also someone might want to keep tokens into redis for example or use own access and refresh tokens. So I can't force any of the listed methods :)
You need to implement this part manually according to your project approaches. Hope I explained clearly enough :)

Yup! Just making sure, thanks!


[feature request] Traces with Claude V3

Is your feature request related to a problem? Please describe.
When running evals with Claude v3, the OpenInference library doesn't support Anthropic's message api (it assumes "prompt" is in the invoke_model call, which is only true for Claude 2
Describe the solution you'd like

Ability to have traces with Claude 3

Describe alternatives you've considered

Currently reverted to using Claude 2 for now.

Additional context
Add any other context or screenshots about the feature request here.

Confirmed - access is via Bedrock.


Added description for buildCrossTargeting

Added description on how to add MSBuild props and targets files for the case that $(TargetFramework) is empty and the \buildCrossTargeting package folder must be used instead.
To clarify the difference, the description for generated imports from files in the \build package folder was extended with the information, that a separate import is added for each target framework.

:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

docs/create-packages/Creating-a-Package.md
:white_check_mark:Succeeded

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.

Thanks for the contribution! Much appreciated.


Timon name and icon is the same at the actual App name and Icon

The name and icon of the Bot is the same as the actuall app name and Icon, I tried to do a teams cache but nothing is still the same

Hey @sharlotlek!
Yes, the bot name and icon in Power Virtual Agents and in the Teams manifest (Teams app) are the same if you follow the guide.
(You can change the name and icon to whatever you want).
Could you please explain more about what your issue is?
Have an awesome day,
/E

Hi @Erithano
Yes, I changed the Bot name and Icon on PVA but Its not getting the Bot name and icon but rather the Teams app name. please see the below example.
The actual name of the bot is Timon and it has its own icon but in my case its getting the name and icon of the Teams app which is called the AdoptionHub. I know how to change the bot name and icon on PVA and the teams app on the menifest file.

Thanks for clarifying this @sharlotlek! I like the dark mode by the way 🙂
Didn't know if you were using Timon standalone or within Adoption Hub.
If standalone of course bot name and icon are the same.
But when used within another app (like Adoption Hub) it inherits that application's name and icon.
You're talking to Timon in the chat tab within AdoptionHub, right?

This is then the expected behavior (whether we like it or not 😉).
💡 Bonus:
I personally recommend having Timon installed as a standalone app as well. This means I have two apps using the same PVA-bot. They are always in perfect sync. It also enables you to search for the bot's name in the search bar for example.
For a very long time, when I have both AdoptionHub and Timon as two different apps, the bot name (Timon) would still show as AdoptionHub like in your screenshot.
And here's the fun part. It looks like my setup now finally honors the original bot name!
The profile picture is still associated with AdoptionHub though.
Standalone app for Timon:

in AdoptionHub:

@Erithano
ohhh yeah !!! , Makes sense.🙂
Thank you for the clarification. It would've been great for the bot to have its own name and icon within the app🙂


konnector-bootstrap

Current dependencies on/for this PR:

main

PR #2   👈

This stack of pull requests is managed by Graphite.


[TT-932] Fix recorder crash in NavigationURLLoaderImpl::OnReceiveRedirect

https://linear.app/replay/issue/TT-932/recorder-crash-in-urlloaderclientstubaccept-fetcheventrespondwith#comment-b41db005

hm, but url_ is updated after each redirect is processed, this at the end of OnReceiveRedirect:
  GURL previous_url = url_;
  url_ = redirect_info.new_url;

for a series of redirects I'm not sure where the ultimate original url is kept.  does that matter?

Yeah it kind of seems like keeping url_ if url_chain is empty, but otherwise using url_chain_[0] might be the right compromise?

so I did a lot of digging, and I think we can just drop originalUrl entirely.  nothing actually uses it.
The call to renderer->RecordReplayBrowserEvent("Network.NavigationRedirect", std::move(dict)); in NavigationURLLoaderImpl::OnReceiveRedirect finds its way (through v8 and our browser event callback) to HandleBrowserEvent here.
HandleNetworkNavigationRedirectEvent completely consumes the dictionary that contains originalUrl without doing anything with it - it copies specific keys into another value that is persisted in a global.  This code also assumes requestId can be used to to stitch together its own concept of a request chain.

Yeah it kind of seems like keeping url_ if url_chain is empty, but otherwise using url_chain_[0] might be the right compromise?

Yes, that was Chris' recommendation here as well (that I ignored).

so I did a lot of digging, and I think we can just drop originalUrl entirely. nothing actually uses it.
The call to renderer->RecordReplayBrowserEvent("Network.NavigationRedirect", std::move(dict)); in NavigationURLLoaderImpl::OnReceiveRedirect finds its way (through v8 and our browser event callback) to HandleBrowserEvent here.
HandleNetworkNavigationRedirectEvent completely consumes the dictionary that contains originalUrl without doing anything with it - it copies specific keys into another value that is persisted in a global. This code also assumes requestId can be used to to stitch together its own concept of a chain of requests from following redirects.
🪓 ?

Should we axe?
I guess we can. But the problem is that, despite having all this information, how sure can we be that this is the right decision?
How to approach these types of problems in the future?
In general, my recommendation for this type of problem is: Let's compartmentalize.

The main goal here is to eliminate a nasty P1 crash.
Once the crash is fixed, we can then leave a ticket or otherwise tackle correctness problems at a later point in time, according to priority.

I am suggesting this because fixing minor correctness problems can sometimes be a nice and easy win. But if its not trivial and, also, there are major P1 crashes still around, then it is also a lot of time and energy spent on something that is not a P1. E.g., in this particular case, it looks like there was no correctness problem, and, still, there was time and energy spent on it.
What do you think?
At the same time, I think that your willingness to go the extra mile is inspiring. I'll consider giving the correctness investigation at least some 10 minutes before moving on the next time around :laughing:


adding an lru cache for incoming getStream calls

I landed this https://github.com/river-build/river/pull/1519. Lets see if it makes a difference.


Activity bar dragging can be hard to see drop indicators

Refs: #93786

It might be nicer to just have the dragging be the icon rather then the whole box.

I tried just the icon, but it becomes very hard to see what you are dragging when you move out and I have pretty much no control over the opacity, its all or nothing it seems with native dnd. As a compromise, I've shifted the icon out from under the cursor to alleviate this.


Strange behavior of 'count'

I have totally no idea what was going on here. So I will just describe how I tried this and what did I see.
I was trying to calculate the cpu_load pre-CPU using the metrics exported by the node_expoter.
So I calculated as this:
{pre_cpu_load by instance}
= A/B
=  {load1 by instance}/{number of CPU by instance}
=  {load1 by instance}/{count of {all cpu} by instance}
# So the query is:
node_load1 / (count by(instance)(count by(instance, cpu)(node_cpu)))

What did I do?
In the prometheus web interface, exec
node_load1 / (count by(instance)(count by(instance, cpu)(node_cpu)))
'no data'
for debug I specific the instance id and tear this apart:
Here is some experiments:

label
query
expect
result

A
node_load1{instance="xxxxx"}
0.3
0.3

A'
node_load1
[0.3,0.3,0.3]
[0.3,0.3,0.3]

A+1
~
1.3
1.3

B
count by(instance)(count by(instance, cpu)(node_cpu{instance="xxxx"}))
4
4

B'
count by(instance)(count by(instance, cpu)(node_cpu))
[2,2,4]
[2,2,4]

B+1
~
5
5

A/B
node_load1{instance="xxxxx"}/(count by(instance)(count by(instance, cpu)(node_cpu{instance="xxxx"})))
0.075
no data

A'/B'
node_load1 / (count by(instance)(count by(instance, cpu)(node_cpu)))
[2,2,2,4]
no data

Environment

System information:
Linux 4.4.35-33.55.amzn1.x86_64 x86_64
Prometheus version:

prometheus, version 1.5.2 (branch: master, revision: bd1182d29f462c39544f94cc822830e1c64cf55b)
  build user:       root@a8af9200f95d
  build date:       20170210-14:41:22
  go version:       go1.7.5

Two more instersting things here may be helpful.
The incident of the result column is also 'broken'

There is a result of '4' in Query B but the graph did show it correctly. The line seemed to dorped off the graph.

For usage questions, https://groups.google.com/forum/#!aboutgroup/prometheus-users is the best place to get answers.

Well, I think this may be a bug. So I report it. Could you plz take another look?
In brief, I came across a situation where I got a query 'A' with result of a. And query 'B' with result of b.
But when I query 'A/B' I got no data

It is not a bug.
You need to understand label matching, see https://prometheus.io/docs/querying/operators/#vector-matching .
If you discuss this questions on the mailing list, other users can benefit from the answers.

Oh sorry, thank you for your reply.


CASMPET-6735 add step to add storage node to spire and wait for CFS to storage node upgrade

Description
After storage nodes are rebuilt, the do not automatically join spire. There is script that is run manually to fix spire on the storage nodes. This is now part of the storage node upgrade. This PR adds a step to make sure that the fix spire script is run and that CFS is then configured on the storage nodes.
Tested on Starlord.

Checklist

[x] If I added any command snippets, the steps they belong to follow the prompt conventions (see example).
[x] If I added a new directory, I also updated .github/CODEOWNERS with the corresponding team in Cray-HPE.
[x] My commits or Pull-Request Title contain my JIRA information, or I do not have a JIRA.

/backport release/1.5


minio-integration notebook fails with "KeyError: 'MINIO_ENDPOINT_URL'"

Bug Description
Running the minIO-integration UAT notebook from main branch on a self-hosted runner fails with KeyError: 'MINIO_ENDPOINT_URL'. It looks like the mentioned ENV variable is not set on the notebook's environment.
E           KeyError                                  Traceback (most recent call last)
E           Cell In[2], line 1
E           ----> 1 MINIO_HOST = os.environ["MINIO_ENDPOINT_URL"].split("http://")[1]
E                 3 # Initialize a MinIO client
E                 4 mc = Minio(
E                 5     endpoint=MINIO_HOST,
E                 6     access_key=os.environ["AWS_ACCESS_KEY_ID"],
E                 7     secret_key=os.environ["AWS_SECRET_ACCESS_KEY"],
E                 8     secure=False,
E                 9 )

To Reproduce
Run the Deploy CKF bundle and run UATs workflow with tests-bundle/1.7 as bundle tests, --file=releases/1.7/stable/kubeflow/bundle.yaml as bundle source and feature-orfeas-lightkube-trustenv as the uats branch.
Environment

Self-hosted runner
Microk8s 1.24
Juju 2.9
CKF 1.7/stable

Relevant Log Output

_ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _

self = <nbconvert.preprocessors.execute.ExecutePreprocessor object at 0x7fedb8919a60>
cell = {'cell_type': 'code', 'execution_count': 2, 'id': 'b773adce-883b-46f7-bc7a-b88ffe5e1165', 'metadata': {'execution': {'...ccess_key=os.environ["AWS_ACCESS_KEY_ID"],\n    secret_key=os.environ["AWS_SECRET_ACCESS_KEY"],\n    secure=False,\n)'}
cell_index = 5
exec_reply = {'buffers': [], 'content': {'ename': 'KeyError', 'engine_info': {'engine_id': -1, 'engine_uuid': '3e663fcf-86f2-43a8-a...e, 'engine': '3e663fcf-86f2-43a8-ab29-6316cece7179', 'started': '2023-11-14T11:40:45.625203Z', 'status': 'error'}, ...}

    async def _check_raise_for_error(
        self, cell: NotebookNode, cell_index: int, exec_reply: t.Optional[t.Dict]
    ) -> None:

        if exec_reply is None:
            return None

        exec_reply_content = exec_reply['content']
        if exec_reply_content['status'] != 'error':
            return None

        cell_allows_errors = (not self.force_raise_errors) and (
            self.allow_errors
            or exec_reply_content.get('ename') in self.allow_error_names
            or "raises-exception" in cell.metadata.get("tags", [])
        )
        await run_hook(
            self.on_cell_error, cell=cell, cell_index=cell_index, execute_reply=exec_reply
        )
        if not cell_allows_errors:
>           raise CellExecutionError.from_cell_and_msg(cell, exec_reply_content)
E           nbclient.exceptions.CellExecutionError: An error occurred while executing the following cell:
E           ------------------
E           MINIO_HOST = os.environ["MINIO_ENDPOINT_URL"].split("http://")[1]
E
E           # Initialize a MinIO client
E           mc = Minio(
E               endpoint=MINIO_HOST,
E               access_key=os.environ["AWS_ACCESS_KEY_ID"],
E               secret_key=os.environ["AWS_SECRET_ACCESS_KEY"],
E               secure=False,
E           )
E           ------------------
E
E           ---------------------------------------------------------------------------
E           KeyError                                  Traceback (most recent call last)
E           Cell In[2], line 1
E           ----> 1 MINIO_HOST = os.environ["MINIO_ENDPOINT_URL"].split("http://")[1]
E                 3 # Initialize a MinIO client
E                 4 mc = Minio(
E                 5     endpoint=MINIO_HOST,
E                 6     access_key=os.environ["AWS_ACCESS_KEY_ID"],
E                 7     secret_key=os.environ["AWS_SECRET_ACCESS_KEY"],
E                 8     secure=False,
E                 9 )
E
E           File /opt/conda/lib/python3.8/os.py:675, in _Environ.__getitem__(self, key)
E               672     value = self._data[self.encodekey(key)]
E               673 except KeyError:
E               674     # raise KeyError with the original key value
E           --> 675     raise KeyError(key) from None
E               676 return self.decodevalue(value)
E
E           KeyError: 'MINIO_ENDPOINT_URL'
E           KeyError: 'MINIO_ENDPOINT_URL'

/opt/conda/lib/python3.8/site-packages/nbclient/client.py:915: CellExecutionError

During handling of the above exception, another exception occurred:

test_notebook = '/tests/notebooks/minio/minio-integration.ipynb'

    @pytest.mark.ipynb
    @pytest.mark.parametrize(
        # notebook - ipynb file to execute
        "test_notebook",
        NOTEBOOKS.values(),
        ids=NOTEBOOKS.keys(),
    )
    def test_notebook(test_notebook):
        """Test Notebook Generic Wrapper."""
        os.chdir(os.path.dirname(test_notebook))

        with open(test_notebook) as nb:
            notebook = nbformat.read(nb, as_version=nbformat.NO_CONVERT)

        ep = ExecutePreprocessor(
            timeout=-1, kernel_name="python3", on_notebook_start=install_python_requirements
        )
        ep.skip_cells_with_tag = "pytest-skip"

        try:
            log.info(f"Running {os.path.basename(test_notebook)}...")
            output_notebook, _ = ep.preprocess(notebook, {"metadata": {"path": "./"}})
            # persist the notebook output to the original file for debugging purposes
            save_notebook(output_notebook, test_notebook)
        except CellExecutionError as e:
            # handle underlying error
>           pytest.fail(f"Notebook execution failed with {e.ename}: {e.evalue}")
E           Failed: Notebook execution failed with KeyError: 'MINIO_ENDPOINT_URL'

/tests/test_notebooks.py:50: Failed

Additional Context
No response

The same UAT failed also when deployed latest/edge bundle

Turns out that not having the aforementioned ENV variable is expected when there is no MLflow deployed. More specifically, notebooks aren't expeected to talk to MinIO out of the box. This functionality is only needed when MLFlow client needs to fetch/push models from MinIO. That's why we deploy another instance of MinIO as part of the MLflow bundle, which is the one notebooks need to have access to.
That being said, we 'll go ahead and rename the minio-integration notebook to mlflow-minio-integration notebook in order to make it explicit that this is part of the MLflow bundle UATs and also avoid run this during kubeflow uats.


Fix 7.1.x build

[approve ci autest]

Autest:
Test: deny0: Exception
    File: deny0.test.py
    Directory: /var/jenkins/workspace/autest-github/src/tests/gold_tests/basic
     Reason: Traceback (most recent call last):
       File "/usr/local/lib/python3.6/site-packages/autest/core/runtesttask.py", line 34, in __call__
         tl = self.__logic.Run(self.__test)
       File "/usr/local/lib/python3.6/site-packages/autest/runlogic/runlogic.py", line 18, in Run
         if not tmp.Start(obj):
       File "/usr/local/lib/python3.6/site-packages/autest/runlogic/test.py", line 89, in Start
         loadTest(self.__test)
       File "/usr/local/lib/python3.6/site-packages/autest/core/test.py", line 179, in loadTest
         execFile(fileName, locals, locals)
       File "/usr/local/lib/python3.6/site-packages/autest/common/execfile.py", line 15, in execFile
         exec (safeCompile(f.read(), fname), globals, locals)
       File "/var/jenkins/workspace/autest-github/src/tests/gold_tests/basic/deny0.test.py", line 32, in <module>
         dns = Test.MakeDNServer("dns")
     AttributeError: 'Test' object has no attribute 'MakeDNServer'

[approve ci autest]


Freezer.Freezer version 1.1.8

[ ] Have you signed the Contributor License Agreement?
[ ] Have you checked that there aren't other open pull requests for the same manifest update/change?
[ ] Have you validated your manifest locally with winget validate --manifest <path>?
[ ] Have you tested your manifest locally with winget install --manifest <path>?
[ ] Does your manifest conform to the 1.0 schema?

Note: <path> is the name of the directory containing the manifest you're submitting.

Microsoft Reviewers: Open in CodeFlow

For some reason this fails the first time trying to install but succeeds install the second time


Radios labels are full width - should be the width of the label text?

Radio labels extend to the full width of the container. This means the clicks apparently in space on the righthand side activate radios.
This was not the case with Elements where labels only extended as far as the text.

This regressed as of #616 and is now a thing again.


Prepare second importer cronjob for production

Increase run frequency to 3 hourly

FYI I added d8e9db57 create the CronJob suspended so it doesn't immediately run after the release (I want to supervise it closely)


Support additional use cases

Thank you for making this fork and upstreaming your changes 🎉
There’s a couple use cases I think would be wonderful to have:

cva array syntax
windstitch / stylemapper syntax
tw syntax

I think you already support the tw syntax via tailwindTaggedTemplates.  That’s already a really good escape hatch 😄 unfortunately, I couldn’t try it since I couldn’t get the fork to work locally
The cva array syntax could be an additional option named something like tailwindArrayTemplates and looks like:
import { cva } from "class-variance-authority";

const button = cva(["font-semibold", "border", "rounded"], {
  variants: {
    intent: {
      primary: [
        "bg-blue-500",
        "text-white",
        "border-transparent",
        "hover:bg-blue-600",
      ],
      // **or**
      // primary: "bg-blue-500 text-white border-transparent hover:bg-blue-600",
      secondary: [
        "bg-white",
        "text-gray-800",
        "border-gray-400",
        "hover:bg-gray-100",
      ],
    },
    size: {
      small: ["text-sm", "py-1", "px-2"],
      medium: ["text-base", "py-2", "px-4"],
    },
  },
  compoundVariants: [
    {
      intent: "primary",
      size: "medium",
      class: "uppercase",
      // **or** if you're a React.js user, `className` may feel more consistent:
      // className: "uppercase"
    },
  ],
  defaultVariants: {
    intent: "primary",
    size: "medium",
  },
});

The windstitch syntax with w.componentname doesn’t seem to be supported with tailwindCustomFunctions, and I was unable to get your fork with tailwindFunctionCalls working locally.  I think the same option name could be used, or another one like tailwindMethodCalls could be added.  The syntax looks like:
import { w } from '@wind/react';

const Button = w.button('text-sm', {
  variants: {
    color: {
      red: 'text-red-500',
      blue: 'text-blue-500',
    },
    size: {
      small: 'text-sm',
      large: 'text-lg',
    },
  },
  defaultVariants: {
    size: 'small',
  },
});

Thanks for your feedback and sorry for the late reply - somehow I wasn't subscribed to notifications for my own repo 😛

CVA array syntax

I'm not entirely sure, but I think this might require some updates to some of the deeper internals of the plugin. I don't know how easily I can decouple the sorting parts from the part that splits out or parses the classname string. Can't make any promises, but I will investigate it further.
String syntax should still work though:
const button = cva("font-semibold border rounded", {
  variants: {
    intent: {
      primary: "bg-blue-500 text-white border-transparenthover:bg-blue-600",
  // ...

tw tagged template syntax
I think you already support the tw syntax via tailwindTaggedTemplates. That’s already a really good escape hatch 😄 unfortunately, I couldn’t try it since I couldn’t get the fork to work locally

So far I've only implemented that feature in my PR to the upstream package - not here in the fork itself. I was optimistically hoping to be able to decommission this package in favor of moving these features upstream instead, so I hadn't prioritized it.
It's pretty easy to add though. I need to pull in the latest changes from the upstream package anyway, so I can add this feature when I do (should hopefully be soon)

windstitch / stylemapper syntax

Targeting method names makes sense to me, but I wonder whether or not it would be necessary to allow targeting based on the parent name too.
I'm not sure what the configuration should look like if, for example, we wanted to restrict it to methods named button but only when the parent is named w?
Maybe just the method name is enough though 🤔

Tagged template support is released in v0.2.1 (prettier setting tailwindCustomTaggedTemplates)


build(deps): audit dependencies and update lineup

prerequisites:

[x] branch is up-to-date with the branch to be merged with, i.e. develop
[x] build is successful
[x] code is cleaned up and formatted

Summary
run npm audit fix and also update LineUp version to most likely fix #67

Do you also want to update the other dependencies like TypeScript, etc.?


Add Mughees Hafeez to Contributors List

Hi
I hope you are fine, please check my commit.

Thanks
Mughees

I'm quite elated about your pull request. I wanna evolve this project to addresses various problems faced by first-time contributors. I'd love to learn about your journey in open source community, the problems, pain points you had etc.
Could you explain how you felt when you went through the tutorial, made a pull request and learned that I merged it?
We’ve recently added Facebook share and tweet feature to our web app. Could you please go to https://roshanjossey.github.io/first-contributions/#social-share and share your first contribution to open source?
Also, check out projects with easy issues while you’re there.


Request for Clearer Expanded/Collapsed Folder Indication

Hi,
Thanks for the great theme! I have a suggestion to improve it: could you make it easier to differentiate between expanded and collapsed folders in the file explorer? Maybe using color variations, shading, or visual indicators like arrows or plus/minus signs.
Looking forward to any enhancements. Appreciate your work!
Best,

Combining this wiht #49 since it is requesting the same thing

Thanks 😌


[Bug] Not possible to connect to a Ameli account

Describe the bug
When trying to connect to his Ameli account then the following error is shown:
"Service momentanément indisponible veuillez réessayer plus tard" --> "Service temporarily unavailable please try again later"
https://assure.ameli.fr/PortailAS/framework/skeletons/error/error.jsp
How to Reproduce
Go to: https://www.ameli.fr/oise/assure
Select the menu: "Compte Ameli" then enter both login/password
The following error is displayed:

Expected behavior
It should be possible to connect to a Ameli account because it works fine with other browsers as Chrome for instance.
Environment
- DDG App Version: 5.106.0
- Device: G one
- OS: Android 7.0

Please report those issues via "broken sites" in our app if you find that problem again. We have an specific team just to look into those issues :)
I personally don't have a login/password to test this, but our team will react if we see users report this site.

@cmonfortep Thanks for your response. I just sent comments with both menus "Broken site" and "Share your comments -> Issues loading Web sites"
For information, you can check the issue without to have login/password because the error occurs now before the login/password form page is displayed.


Jav 431 conditional transaction demo

Coverage remained the same at 94.645% when pulling 64d82c276c5fe2bd3f97a1f85fcbc4d763f63122 on JAV-431_conditional_transaction_demo into 90dd7135466eab233959d34c1ba6564387b8ea2e on master.

@zhengyangyong @WillemJiang please review if the readme and conditional transaction handling is reasonable

Coverage remained the same at 94.645% when pulling 1d3ed8dad6d7c258af418a38fca80bddb471cfc4 on JAV-431_conditional_transaction_demo into 90dd7135466eab233959d34c1ba6564387b8ea2e on master.

Coverage remained the same at 94.645% when pulling 486381bc293fcb8eb35026e2feccae6e0c0d7cd4 on JAV-431_conditional_transaction_demo into 90dd7135466eab233959d34c1ba6564387b8ea2e on master.


Add simple version of chooseOverload for common case of single non-generic signature

This does change one baseline; I think the change is an improvement. I've added a simpler way to reproduce the change in the contextualTypingFunctionReturningFunction.ts test. Previously, the types baseline would have contained b: () => {}, while now it uses b : () => (n: number) => void. I think this change is related to #17586, so it won't be fully fixed until that is.
There was a 2% performance improvement in the Monaco baseline and no improvement in the TFS baseline. If you look at just the changes to check time (which is the only thing that should have changed) there is an average 1% improvement.
Monaco - node (v8.2.1, x64)

Project
Baseline
Current
Delta
Best
Worst

Memory used
356,878k (±  0.00%)
356,876k (±  0.00%)
-2k (-  0.00%)
356,847k
356,929k

Parse Time
2.13s (±  1.54%)
2.11s (±  0.56%)
-0.02s (-  0.99%)
2.09s
2.15s

Bind Time
0.83s (±  1.89%)
0.82s (±  1.35%)
-0.01s (-  1.21%)
0.80s
0.85s

Check Time
4.30s (±  1.57%)
4.22s (±  0.67%)
-0.08s (-  1.88%)
4.14s
4.30s

Emit Time
2.87s (±  3.28%)
2.73s (±  0.34%)
-0.14s (-  4.74%)
2.71s
2.75s

Total Time
10.13s (±  1.79%)
9.88s (±  0.36%)
-0.25s (-  2.45%)
9.79s
9.99s

TFS - node (v8.2.1, x64)

Project
Baseline
Current
Delta
Best
Worst

Memory used
309,614k (±  0.01%)
309,573k (±  0.01%)
-41k (-  0.01%)
309,510k
309,626k

Parse Time
1.55s (±  1.77%)
1.55s (±  1.69%)
+0.00s (+  0.13%)
1.45s
1.58s

Bind Time
0.68s (±  4.50%)
0.69s (±  4.55%)
+0.01s (+  1.03%)
0.66s
0.81s

Check Time
3.66s (±  0.32%)
3.64s (±  0.55%)
-0.02s (-  0.41%)
3.60s
3.69s

Emit Time
2.38s (±  0.52%)
2.41s (±  0.68%)
+0.03s (+  1.09%)
2.37s
2.45s

Total Time
8.27s (±  0.23%)
8.29s (±  0.36%)
+0.01s (+  0.17%)
8.22s
8.35s

Just to be sure, re-ran performance tests. Still seeing on average a 1% improvement in check time.
Monaco - node (v8.2.1, x64)

Project
Baseline
Current
Delta
Best
Worst

Memory used
356,863k (±  0.00%)
356,908k (±  0.01%)
+45k (+  0.01%)
356,844k
357,012k

Parse Time
2.10s (±  0.71%)
2.10s (±  0.60%)
-0.01s (-  0.29%)
2.07s
2.12s

Bind Time
0.81s (±  0.45%)
0.81s (±  0.92%)
-0.00s (-  0.12%)
0.79s
0.83s

Check Time
4.23s (±  0.46%)
4.25s (±  1.14%)
+0.02s (+  0.47%)
4.20s
4.44s

Emit Time
2.75s (±  0.57%)
2.74s (±  0.68%)
-0.01s (-  0.25%)
2.71s
2.79s

Total Time
9.89s (±  0.31%)
9.90s (±  0.58%)
+0.01s (+  0.06%)
9.78s
10.10s

Monaco - tsc (x86)

Project
Baseline
Current
Delta
Best
Worst

Parse Time
1.52s (±  1.61%)
1.51s (±  0.87%)
-0.01s (-  0.79%)
1.49s
1.54s

Bind Time
0.57s (±  2.05%)
0.57s (±  2.88%)
+0.00s (+  0.00%)
0.54s
0.61s

Check Time
4.01s (±  1.50%)
3.93s (±  1.06%)
-0.08s (-  1.87%)
3.86s
4.03s

Emit Time
7.04s (±  4.73%)
6.90s (±  1.21%)
-0.14s (-  1.93%)
6.67s
7.05s

Total Time
13.14s (±  2.75%)
12.92s (±  0.81%)
-0.22s (-  1.71%)
12.65s
13.15s

TFS - node (v8.2.1, x64)

Project
Baseline
Current
Delta
Best
Worst

Memory used
309,619k (±  0.01%)
309,565k (±  0.01%)
-54k (-  0.02%)
309,508k
309,605k

Parse Time
1.55s (±  1.42%)
1.54s (±  2.09%)
-0.02s (-  1.22%)
1.45s
1.57s

Bind Time
0.68s (±  4.40%)
0.70s (±  5.95%)
+0.02s (+  2.35%)
0.66s
0.81s

Check Time
3.68s (±  0.57%)
3.64s (±  0.59%)
-0.03s (-  0.84%)
3.60s
3.69s

Emit Time
2.38s (±  0.54%)
2.38s (±  0.65%)
+0.00s (+  0.21%)
2.35s
2.42s

Total Time
8.29s (±  0.25%)
8.26s (±  0.42%)
-0.03s (-  0.35%)
8.19s
8.35s

TFS - tsc (x86)

Project
Baseline
Current
Delta
Best
Worst

Parse Time
1.11s (±  3.33%)
1.08s (±  0.81%)
-0.02s (-  2.17%)
1.07s
1.11s

Bind Time
0.58s (±  6.03%)
0.58s (±  3.17%)
-0.00s (-  0.00%)
0.55s
0.64s

Check Time
3.32s (±  1.86%)
3.26s (±  2.22%)
-0.06s (-  1.84%)
3.11s
3.45s

Emit Time
4.23s (±  1.49%)
4.22s (±  0.66%)
-0.01s (-  0.28%)
4.16s
4.28s

Total Time
9.23s (±  1.32%)
9.15s (±  0.80%)
-0.09s (-  0.93%)
9.00s
9.29s


Match state does not update in table overview

The second process 'match type' status does not update after I updated the match.

This is also -partially- the case in the process details, where we now see both a proxy, but also the type No direct match available

When updating the match type, matchbox should overwrite the match type variable to reflect the new type.

Probably a silly question, but is the old (stale) state persisted after a page reload?

Unfortunately, yes ;)

Should be fixed in 08f0da5f9a831f09bb49dd513d9116aed6dd51b9


Rearranged type param order so that the Network param is the last

Motivation
To default Network parameters to Ethereum in alloy-provider and alloy-contract, they need to be moved to the last of the type params: https://github.com/alloy-rs/alloy/pull/356
According to those changes, we need to adjust the type param order in sol! as well.
from: https://github.com/alloy-rs/alloy/issues/263

Solution

PR Checklist

[ ] Added Tests
[ ] Added Documentation
[ ] Breaking changes

@onbjerg Thanks for your advice in https://github.com/alloy-rs/alloy/pull/356#issuecomment-2021855378. I've opened this PR to adjust the type param order in sol!

@mattsse

does this introduce more issues with patched alloy-core deps on alloy?

This PR will only affect alloy-contract and alloy-provider and it's already covered by the PR I created in alloy-rs/alloy.
(sol! is being used only for tests in the packages for now)

@DaniPopes Thanks! I've just fixed https://github.com/alloy-rs/alloy/pull/356 and it's ready now. Once this PR is merged, I'll update alloy dependencies to use the latest alloy-core


[Extension Bug]

Extension – Obsidian

Author: @marcjulianschwarz

Description
The description reads

Search, open, view, copy, paste and edit any note in Obsidian

but the extension only provides the search command

Steps To Reproduce

None

The current behavior
The expected behavior
Raycast version
Version: 1.26.3

This is expected behavior.
You can open, view, copy, paste and edit a specific note if you search for it in the search command and use actions which can be executed with keyboard shortcuts. You can view them with cmd+k.

ahhhhh, I see now. sorry for the confusion!
closing

No problem.


Decide on a server

We can probably start with the a very basic Digital Ocean droplet and we can always migrate to one with better specs later if the need arises.

Close this for now because we are going to use a serverless solution on AWS.
If we need to add some fancier feature which requires a server, we can re-open this.


Maximum depth of a binary tree

Description
A c++ code to find the maximum depth in a binary tree.

@vedant-jad99 Refer issue number in Description.


Exception is thrown in the code, but it works normally

when I create a native module in Android, throwing an exception , it is Method threw 'com.facebook.react.bridge.ObjectAlreadyConsumedException' exception. Cannot evaluate com.facebook.react.bridge.WritableNativeMap.toString()
my code is:
array=new WritableNativeArray();
for(int i=0;i<fileList.size();i++){
WritableMap map=new WritableNativeMap();
map.putString("uri","file://"+fileList.get(i).getAbsolutePath());
map.putString("fileName",fileList.get(i).getName());
map.putInt("size", (int) fileList.get(i).length());
array.pushMap(map);
}
callback.invoke(array);
React Native version: 0.39.0
Platform: Android
Development Operating System: Windows
Dev tools: Android Studio version 2.1.2,com.android.tools.build:gradle:2.2.3, buildToolsVersion "24.0.2"

when i >0; the exception is thrown, I guess it is to be caused by the code(WritableMap map=new WritableNativeMap() ), Thanks!
Although the error is appeared, but it is not crash, I want to be given a solution ,thanks

Hey, thanks for reporting this issue!
It looks like your description is missing some necessary information. Can you please add all the details specified in the template? This is necessary for people to be able to understand and reproduce the issue being reported.
I am going to close this, but feel free to open a new issue with the additional information provided. Thanks!


Bug: Database export produce syntax error

Describe the bug
The export method in Surrealist produces a invalid .surql-file when a table starts with table or is exactly table.
To Reproduce
Steps to reproduce the behavior:

Execute this query on a blank instance:

DEFINE TABLE table;
DEFINE FIELD name ON TABLE table TYPE string;

Export the database with the Surrealist export method.

Try to import the file into a new blank instance. A successful popup will appear but nothing happend in the background.

Expected behavior
Exporting and then importing work as expected.
Problem
The exported .surql-file contains a syntax error here:
-- ------------------------------
-- Export generated by Surrealist on 2024-08-12T09:37:51.128Z
-- ------------------------------

OPTION IMPORT;

-- ------------------------------
-- TABLE: table
-- ------------------------------

DEFINE TABLE table TYPE ANY SCHEMALESS PERMISSIONS NONE;

DEFINE FIELD name ON table TYPE string PERMISSIONS FULL;
--                         ^ - Here SurrealQL thinks "TYPE" is the table because
--                             `ON table` is interpreted as the keyword but only `ON`
--                             is the keyword and `table` is the actual table name.

Solution
Add an additional TABLE after ON (ON TABLE) in the export generator.
-DEFINE FIELD name ON table TYPE string PERMISSIONS FULL;
+DEFINE FIELD name ON TABLE table TYPE string PERMISSIONS FULL;

The syntax error occurs not only in the DEFINE FIELD statements but also in cases like DEFINE INDEX when using a table named table.
I don't know if it is a SurrealDB or Surrealist problem but this does not work with the latest stable (1.5.4 linux/aarch64) and the latest nightly (2.0.0+20240808.3f5ef43 linux/aarch64).
Environment:
Version: 2.1.6
Flags: feature_flags: false, models_view: true, apidocs_view: true, themes: false, newsfeed: true, database_version_check: true, highlight_tool: false, surreal_compat: v1, changelog: auto

Thanks for finding this issue! It actually appears to be caused by an issue within SurrealDB itself, namely the INFO FOR statement.
We will find a suitable solution for this as soon as possible
Thanks again!

This has now been fixed in SurrealDB. Thanks for the issue!


created the statistics page and and the line graph component using re…

…charts

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

I appreciate your interest and contribution proposal to the project. I suggest reading our docs and seeing some examples.
In big features like this, we usually don't accept them unless it is in our roadmap or mapped in a approve issue in our issues section.
While I'm giving you feedback in this issue, we're not expecting to implement anything like that anytime soon, so there's a big chance this PR won't be merged.
Either way, here is some feedback:

Make a concise and clear description about your PR's context, changes, features, etc
Mention any related GitHub issue (e.g. Closes #00)
Don't use mocked data outside tests
Keep exising coding patterns (e.g. tailwind, clean code)
Avoid changes to package.json unless it's part of the related github issue's. requirements.

While this might be frustating, I appreciate your effort and would love to see more contributions from you. There's of opportunity to contribute if you take a look at our issues section.


'additionalOptions' property added to AAChartModel

This new property allows it to extend the AAChartModel with a dicitionary of JavaScript options. This is extremely helpful for properties which are currently not supported by the AAChartModel.
        //Test for additionalOptions
        NSDictionary *additionalOptions = @{
                                                @"yAxis":@{
                                                        @"alternateGridColor":@"#5b3796"
                                                        }
                                                };

        _aaChartModel.additionalOptionsSet(additionalOptions);

Please note that options from the AAChartModel will be overwritten if they exist (and if set) in the AAChartModel. That means that the options contained in the 'additionalOptions' dictionary have priority.
See example in demo (SecondViewController.m), where we set the 'alternateGridColor' of the yAxis for the column or bar chart sample.

This is the solution of https://github.com/AAChartModel/AAChartKit/issues/191


Update utest to 0.8.1

Updates com.lihaoyi:utest from 0.8.0 to 0.8.1.
GitHub Release Notes - Version Diff
I'll automatically update this PR to resolve conflicts as long as you don't change it yourself.
If you'd like to skip this version, you can just close this PR. If you have any feedback, just mention me in the comments below.
Configure Scala Steward for your repository with a .scala-steward.conf file.
Have a fantastic day writing Scala!

Files still referring to the old version number
The following files still refer to the old version number (0.8.0).
You might want to review and update them manually.
build.sc

Adjust future updates
Add this to your .scala-steward.conf file to ignore future updates of this dependency:
updates.ignore = [ { groupId = "com.lihaoyi", artifactId = "utest" } ]

Or, add this to slow down future updates of this dependency:
dependencyOverrides = [{
  pullRequests = { frequency = "@monthly" },
  dependency = { groupId = "com.lihaoyi", artifactId = "utest" }
}]

labels: library-update, early-semver-minor, semver-spec-patch, old-version-remains, commit-count:1

Superseded by #119.


Adding a Login and Signup Page

Please describe.
Currently there is no Login and Signup routes in the application.
Describe the solution you'd like
Add login and Signup route , may be a page before the main page opens up.

@Muhammad-Owais-Warsi it should be functioning as well right? can we use next-auth with google oath provider for sign in?

Only oauth is also fine.1) Google 2) GitHub(if possible)

alright

I made it work for localhost but for some reason its not working on vercel,and since I'm busy with gssoc right now i wont be able to give more time to this and find out what the issue is,will have to pass it to someone else

I'm working on it now.


trigger ci build (testing)

this is to test whether the issue I was having on Friday is still around.
This is not intended to be merged (same as #133)

CI is still failing.  Let's see if backporting #133 on top of master fixes the issue.

Permalink (?) to the CI failure:
https://channable.semaphoreci.com/workflows/9a9ebc9e-0e13-446a-8189-910fc48dd4ed?pipeline_id=be2d9962-028c-4b90-96da-d804c6153d40


Some ideas about this extension

Hey,
Thanks for this great extension!
Here are some ideas you may consider:

Allow user to custom the model temperature
Automatic load the selected text as question (use getSelectedText api)
Use streaming mode to show the answer
Allow users to define custom prompts

I wanted to add that #2 would be very impactful. And Raycast makes it super easy to implement. I support the other bullets as well.

@jonathanlaniado @kale5195
PR #19 merged, allowing users to load the selected text automatically. Please let me know what's your experience with it!

Awesome, is there a way to install the extension permanently instead of running it with npm run dev in the background?

Awesome, is there a way to install the extension permanently instead of running it with npm run dev in the background?

For now, you need to run npm run dev first to be able to use it until it's released on the extension store (probably around late this week)

Amazing. Thank you!


[WIP] Add blueprints table and association to service_templates

Purpose or Intent
Schema changes for blueprint. A new table named blueprints is introduced. Column blueprint_id is added to service_templates.

cc @gmcculloug

@miq-bot rm_label wip


Image max size

Hi 👋,
I'd like to know if there's an option to limit the zoom of the image to 100% of its real size. When using huge resolution, images are excessively zoomed.
Thanks for the work 👍

Hi there!
There is no such option yet, but I’ll implement it ASAP. Thanks!

I did it. Please refer to an updated README for instructions (it basically works out of the box now).


[SPARK-46593][PS][TESTS] Refactor data_type_ops tests again

What changes were proposed in this pull request?
Refactor data_type_ops tests again (the previous pr https://github.com/apache/spark/pull/44592 has been reverted)
Why are the changes needed?
make OpsTestBase reusable and reuse it in the parity tests
Does this PR introduce any user-facing change?
no
How was this patch tested?
ci
Was this patch authored or co-authored using generative AI tooling?
no

Merged to master.


Webonyx v15

webonyx v15.0 is out.
https://github.com/webonyx/graphql-php/releases/tag/v15.0.0
Will be both v14 and v15 supported by graphqlite? At first glance there is backward-incompatible changes
Bumping a new major version of webonyx requires updating ecodev/graphql-upload first.

ecodev/graphql-upload doesn't support webonyx v15 yet.  So, we would need to wait for support there first.
Outside of that, their update notes don't make it very clear what's likely to be broken... I guess anything "changed".  But there is a lot of smaller things there that aren't likely to be a BC break.
We could start with a PR that updates the dep, see what's breaking and go from there.

ecodev/graphql-upload has been released with webonyx/graphql-php 15 support: https://github.com/Ecodev/graphql-upload/releases/tag/7.0.0

@PowerKiKi thanks for that!
@bladl want to give a PR a shot, updating the deps - see what we're looking at?

@PowerKiKi was there a specific reason for PHP 8.1 minimum support and not 8.0?

All my projects are on PHP 8.1, and I am not not keen of the extra mental burden to support multiple PHP versions. I don't even have PHP 8.0 installed anymore. And 8.0 will be EOL quite soon in 10 months, so I don't think it's doing anyone any favor to start using something that will soon be deprecated.
According to https://packagist.org/php-statistics, PHP 8.0 is "only" ~25% of all PHP 8+, and I expect it would go decrease even more with the adoption of the recent 8.2 in the coming months.

@bladl @PowerKiKi thanks guys!  It's been merged.


Migrate name style rules to regex

There are several "name style rules" and one more being developed (https://github.com/chipsalliance/verible/pull/1983) which have their rules hardcoded or with small configuration capabilities.
In the past, this motivated a PR that eventually didn't land but did the same thing (using std::regex which seemed to be the problem). The topic was raised again in https://github.com/chipsalliance/verible/pull/2017.
This is a "macro issue" to track the conversion of the existing rules to be regex-based (using re2). I'll keep this in mind and work on it on spare time, I don't know if I'll tackle this on a per-rule bases or I'll group various rules on the same PR.

[ ] constraint_name_style
[ ] enum_name_style
[ ] interface_name_style
[ ] macro_name_style
[ ] parameter_name_style
[ ] parameter_type_name_style
[ ] signal_name_style
[ ] struct_union_name_style
[ ] port_name_suffix
[ ] ¿dff_name_style? (if it lands)

If anyone comes by this issue and wants to help feel free to do so 😃

Can you add port_name_suffix to the list too. It's basically the same (checks style (snake_case) with some prefixes), and needs some configuration. Regex looks like a good answer.
Happy to with this one too.

Missed this one, thanks!

Happy to help out with any of these rules too.
I've already been playing with the port_name_suffix rule before I saw this issue, and added configuration to it. Just need to convert this over to regex (add tests, etc...).

Would be awesome. This has been implemented in svlint, if you're looking for inspiration.


Translations Update, please integrate

please merge. cc @rgeraght

:tada: This PR is included in version 6.49.1 :tada:
The release is available on:

GitHub release
v6.49.1

Your semantic-release bot :package::rocket:


Input radius and skin thickness

I've implemented basic changes such that you can give input values for the size/shape of the nucleus. The radius keyword takes the solid sphere equivalent radius (as was happening internally before) and the skin thickness changes 't' in the Fermi2 model.
These changes are mainly useful for the nuclear/particle physics side of the muonic atom community. With the radius, one can evaluate how precise one needs to determine the transition energy for a certain experimental radius precision. With the skin thickness, it's also possible to evaluate what systematics are induced by changes in the nuclear shape.

I've added the changes you requested. Besides that, I changed around some R to radius for clarity of use throughout the code. Let me know if there's anything else

I've added the changes you requested. Besides that, I changed around some R to radius for clarity of use throughout the code. Let me know if there's anything else

Hi currently some tests are failing, you may run the tests by make test command

**subindev-d ** requested changes

I'm trying to figure out why things are different. In principle they shouldn't be. I don't see any cases that would be treated differently with these changes here. Would you mind having a look?

**subindev-d ** requested changes

I'm trying to figure out why things are different. In principle they shouldn't be. I don't see any cases that would be treated differently with these changes here. Would you mind having a look?

It was becasue earlier there was only radius_model as an optional parameter, but now we added  the radius parameter as well, so while the test was running it was giving value of radius_model to radius .
I fixed the tests in in these commits: fixing line test, other testst.
Eventhough it works, I am looking into if there are any good practices to implement multiple optional parameters.


Use Array for node configuration warnings

Previously, the warnings were passed as a string and delimitation of which were hard coded at each implementation.

Rebased & Fixed formatting errors, should be fine as long as some weird build doesn't fail :sweat_smile:

Thanks!


Selecting all source languages and all target languages causes stack overflow (!)

Selecting all source languages and all target languages causes a stack overflow (!) or at least the CP to hang forever. Wild guess is, it is calling the TranslationService infinitely.

When will this be fixed??? Our production site is running on this and the marketing team can't update our translations!!! 😠


drill: 0.6.0 -> 0.7.0

Automatic update generated by nixpkgs-update tools. This update was made based on information from https://github.com/fcsonline/drill/releases.
meta.description for drill is: "HTTP load testing application inspired by Ansible syntax"
meta.homepage for drill is: "https://github.com/fcsonline/drill"
meta.changelog for drill is: ""
Updates performed

Rust version update

To inspect upstream changes

Release on GitHub

Compare changes on GitHub

Impact

Checks done (click to expand)

built on NixOS

The tests defined in passthru.tests, if any, passed

0 of 0 passed binary check by having a zero exit code.

0 of 0 passed binary check by having the new version present in output.

found 0.7.0 with grep in /nix/store/q9b4csgpdzm3ah6wggjpih245fmvshia-drill-0.7.0

directory tree listing: https://gist.github.com/aff678a39d8e79d117f12668a36be9a2

du listing: https://gist.github.com/e25caa38f890b07f5f830f34b7aede9f

Rebuild report (if merged into master) (click to expand)

130249 total rebuild path(s)

37965 package rebuild(s)

37817 x86_64-linux rebuild(s)
33481 i686-linux rebuild(s)
26155 x86_64-darwin rebuild(s)
32795 aarch64-linux rebuild(s)

First fifty rebuilds by attrpath

AMB-plugins
AusweisApp2
CoinMP
DisnixWebService
EBTKS
EmptyEpsilon
FIL-plugins
Fabric
LAStools
LASzip
LASzip2
Literate
MIDIVisualizer
MMA
NSPlist
OSCAR
OVMF
OVMF-CSM
OVMF-secureBoot
PlistCpp
QuadProgpp
R
SDL
SDL2
SDL2_gfx
SDL2_image
SDL2_mixer
SDL2_net
SDL2_ttf
SDL_Pango
SDL_gfx
SDL_gpu
SDL_image
SDL_mixer
SDL_net
SDL_sixel
SDL_sound
SDL_stretch
SDL_ttf
SPAdes
SkypeExport
Sylk
Xaw3d
_0x0
_1oom
_1password
_1password-gui
_2048-in-terminal
_20kly

Instructions to test this update (click to expand)

Either download from Cachix:
nix-store -r /nix/store/q9b4csgpdzm3ah6wggjpih245fmvshia-drill-0.7.0 \
  --option binary-caches 'https://cache.nixos.org/ https://nix-community.cachix.org/' \
  --option trusted-public-keys '
  nix-community.cachix.org-1:mB9FSh9qf2dCimDSUo8Zy7bkq5CX+/rkCWyvRCYg3Fs=
  cache.nixos.org-1:6NCHdD59X431o0gWypbMrAURkbJ16ZPMQFGspcDShjY=
  '

(The Cachix cache is only trusted for this store-path realization.)
For the Cachix download to work, your user must be in the trusted-users list or you can use sudo since root is effectively trusted.
Or, build yourself:
nix-build -A drill https://github.com/r-ryantm/nixpkgs/archive/308a20b39c12314702b2ba10f9bc60900218fb28.tar.gz

After you've downloaded or built it, look at the files and if there are any, run the binaries:
ls -la /nix/store/q9b4csgpdzm3ah6wggjpih245fmvshia-drill-0.7.0
ls -la /nix/store/q9b4csgpdzm3ah6wggjpih245fmvshia-drill-0.7.0/bin

Pre-merge build results
NixPkgs review skipped

Maintainer pings
cc @Br1ght0ne for testing.

Result of nixpkgs-review pr 105473 run on x86_64-linux 1

1 package built:

drill

@ryantm The nixpkgs-review and rebuild report seems wrong to me.


Merge docs/XBee-Implementation to main

Documentation on how to implement XBee radios into SystemReference.

@jwest115 I am more than happy to make this change!

Thanks! I will merge this issue and for future work, I'll add in flags for enabling the radio stuff, that way we can avoid referencing code snippets in docs.