Interpolation inside .terragrunt file

We have a bunch of different Terraform state files, each handling .tf files in different directories. There's a .terragrunt file in each directory that looks something like:
dynamoDbLock = { stateFileId = "my_project_terraform_db_lock" }

remoteState = {
  backend = "s3"
  backendConfigs = {
    encrypt = "true"
    bucket = "my-bucket"
    key = "terragrunt/<dirname>.tfstate"
    region = "us-east-1"
  }
}

I'd really like to be able to use a single .terragrunt file for all the directories and be able do something like:
# Skip a bunch of common code shown above
remoteState = {
  backendConfigs = {
    key = "terragrunt/${dirname()}.tfstate"
  }
}

That way, I can symlink to a common .terragrunt in the parent directory and be assured I'm not screwing anything up when I copy the .terragrunt file into a new directory.

Agreed this may be a good feature to have to reduce duplication. However, the tricky bit is figuring out what exactly would dirname() do? Apologies for the long reply, but here is a stream of consciousness to think through this question:

Does it return the absolute path? That obviously doesn't work since different developers on your team will check the code out into different directories on their computers.
Does it return the name of the parent directory of the .terragrunt file? This is likely to cause conflicts. For example, we have stage/vpc and prod/vpc folders, each with a .terragrunt file in them, so if we just used parent directory, they would both get vpc, which would cause the stage and prod VPCs to overwrite each other.
Does it navigate up the directory tree until it finds a version control root? For example, it could navigate up until it finds the first .git folder, indicating it's at the root of a git directory. That might work, but only for Git users.
Perhaps it can navigate up the directory tree until it finds another .terragrunt file, which indicates a root directory. I suppose that root .terragrunt file could even define some shared settings to reduce duplication further. But we still have another problem with all this directory climbing: if you refactor your folder structure in any way, you'll lose your Terraform state. Well, it'll obviously still be there in an S3 bucket, but Terragrunt will end up configuring it to look in the wrong folder, and it'll be as if you're starting with a blank slate. So after a refactor, you'd have to set these back to "manual" mode for a while, which just feels messy.
One final idea: perhaps we take a step back and reconsider the need to have .terragrunt in each folder. Instead, perhaps if there isn't such a file in the current directory, terragrunt should navigate up the folder structure to find one. Inside of that file could be the settings to use for all subfolders below that file that don't have their own .terragrunt config. That file could declare either a general purpose rule remoteState and dynamoDbLock rule to use for each folder (using dirname or similar helper function) or it could simply list the settings for each one while reusing common variables. This approach is more elegant, but still has the drawback that a simple folder move could break things and you'd have to remember to insert a custom .terragrunt file to work around that.

Having gone through this thought process, I'm honestly not convinced any of these options are inherently better than the simple, no-frills, no-magic, 100% declarative, WYSIWYG approach we have now. Yes, you have to do some copy/paste. But it's a one-time cost you do for each set of templates. Perhaps the real solution is to make even this act simpler by having terragrunt check for a .terragrunt file in the current folder, and if it doesn't find one, to interactively prompt you for the settings to create one, filling in lots of reasonable defaults automatically (e.g. by looking at the current folder path). That would largely automate the creation of these files, largely removing manual error from the equation.
Thoughts?

I've got the same terragrunt use case as @robkinyon.
Another option might be to make terragrunt capable of reading variables from a separate file (either its own, or *.tf) and interpolating them with the usual syntax, e.g.
remoteState = {
  backend = "s3"
  backendConfigs = {
    key = "terragrunt/${var.terragrunt_key}.tfstate"
    [...]
  }
}

That would allow symlinking a 'shared' config like the one below into each directory while keeping the per-directory settings in a separate non-linked file. There'd still be the need to create that regular file for each directory, but it would make things a bit simpler.

OK, I have a proposal. We add two new features to Terragrunt:

The ability to pass a new parameter, --templates-path, which specifies the path where Terragrunt should run the terraform command. This allows you to run Terragrunt from the root folder.
Add basic interpolation support to .terragrunt files. For now, just one interpolation function would be supported, relative_path(), which returns the relative path between the --templates-path parameter and the .terragrunt file in the directory where you are executing Terragrunt. This allows you to derive all the state_file_id and key configurations from the folder structure of your templates rather than having to duplicate it all by hand.

With the changes above, you could have the following folder structure:
my-terraform-repo
  └ .terragrunt
  └ qa
      └ my-app
          └ main.tf
  └ stage
      └ my-app
          └ main.tf
  └ prod
      └ my-app
          └ main.tf

Notice how there is only a single .terragrunt file for the whole repo, rather than one for each of the sets of Terraform folders. This .terragrunt file could contain the following:
# Configure Terragrunt to use DynamoDB for locking
lock = {
  backend = "dynamodb"
  config {
    state_file_id = "terragrunt-locks/${relative_path()}"
  }
}

# Configure Terragrunt to automatically store tfstate files in S3
remote_state = {
  backend = "s3"
  config {
    encrypt = "true"
    bucket = "(YOUR_BUCKET_NAME)"
    key = "terraform-state/${relative_path()}"
    region = "(YOUR_BUCKET_REGION)"
  }
}

Now, let's say you want to make a change in the stage/my-app folder. The Terragrunt command, which you would run from the root of the repo (which is where the .terragrunt file is) would look like this:
terragrunt apply --templates-path=stage/my-app

When you run this command, Terragrunt would go into the stage/my-app folder, configure remote state in S3 with the key set to terraform-state/stage/my-app, obtain a lock in DynamoDb with the name terragrunt-locks/stage/my-app, run terraform apply, and then release the lock. This way, the folder layout of your state files in S3, and the names of your locks in DynamoDB, will automatically match the folder layout of your Terraform templates. Of course, if you need to override it for some reason (e.g. you renamed a folder but want it to keep using the old state file), you could include a .terragrunt file in just that folder for those Terraform templates, and it would override the root .terragrunt file.
Thoughts?

First, it's great we're discussing this. This solves a real issue I've encountered with multiple software teams.
I generally like the idea but I have a few concerns. I'm going to think out loud here, so these thoughts might be a little messy:

One of the original goals of terragrunt was to create a dead-easy workflow that would ensure that users don't accidentally forget to configure terraform remote state. Today, the only rule the user has to remember is "use terragrunt on top of terraform," which seems pretty manageable.
But now we're adding another rule. "Only do a terraform apply using terragrunt from the root folder." That's not too onerous, but I can imagine an unsuspecting user going to a subfolder, running terragrunt apply, seeing an error that no .terragrunt file exists, and then being confused.
So my preference is still to have a .terragrunt file in each repo, but perhaps we can make the .terragrunt file copy-and-pasteable without having to change anything.

Following up on that last sentence, one alternative is to have a .terragrunt file in, say, /stage/my-app that looks like this:
# Define the root folder explicitly
root_folder = "/repos/infrastructure-live"

# Configure Terragrunt to use DynamoDB for locking
lock = {
   backend = "dynamodb"
   config {
    state_file_id = "terragrunt-locks/${path_relative_to_root_folder()}"
   }
}

# Configure Terragrunt to automatically store tfstate files in S3
remote_state = {
   backend = "s3"
   config {
      encrypt = "true"
      bucket = "my-terraform-bucket"
      key = "terraform-state/${path_relative_to_root_folder()}"
      region = "us-east-1"
  }
}

I'm not loving the name path_relative_to_root_folder and now we have a new problem where different users may have different root_folder values (although perhaps that's solved by using a relative value like root_folder = "../../../").
But at least now we have our guardrail in place that communicates to a user they have to use the explicitly declared terraform remote state.

Another possibility is to have a root .terragrunt file that specifies common settings, as you suggest (possibly called .terragrunt.root to further distinguish it), and a simplified .terragrunt file in each folder, similar to this:
lock = ${root.lock}
remote_state = ${root.remote_state}

This seems to be a pretty clean setup and solves the above problem.  Also as you suggested, we could enhance terragrunt to traverse parent directories until it finds a .terragrunt.root file (the first such one), where it can read these file settings.

In any of these approaches, we still have the problem you outlined above, which is how to handle moving folders? There are a few possibilities here:

Just let users manually manage this by leveraging the local .terraform state. For example, you could:

terragrunt apply in the old location
move the folder to the new location
terragrunt apply in the new folder.

I'm pretty sure Terraform will automatically write the local state to the remote state, though this needs to be verified.

We could actually build migration functionality directly into terragrunt. For example, maybe we add a feature where terragrunt will get the latest remote_state, and then automatically push it to a new location based on properties in a .terragrunt file.

Lots of ideas here, and still sorting through them myself, but right now I'm most attracted to .terragrunt.root with a simpler .terragrunt file, though even this feels a little complex.

Only do a terraform apply using terragrunt from the root folder

As I mentioned above, you can actually run Terragrunt from the terraform folders themselves. You just need to provide a --terragrunt-config parameter (or env var) that specifies where your .terragrunt file is.
In fact, since there is really only one .terragrunt file at the root of each project, if Terragrunt doesn't find one in the current folder, it would make sense to walk up the folder structure until you find one (and error out if you don't find one). That way, the usage pattern for Terragrunt would be identical to what it is today!

root_folder = "/repos/infrastructure-live"

This can't be an absolute path, and if it's a relative path, you have to tediously update it if you ever refactor your code and move files around.

but right now I'm most attracted to .terragrunt.root with a simpler .terragrunt file, though even this feels a little complex.

What's the purpose of the "local" .terragrunt files? Why create (and manage) this extra code?
I think it's a better idea to only have local .terragrunt files as overrides.

... if Terragrunt doesn't find one in the current folder, it would make sense to walk up the folder structure until you find one (and error out if you don't find one).

This sounds very good, especially when combined with relative_path().
I would change the --templates-path parameter to --workdir and it would default to pwd (preserving current behavior).
As for multiple .terragrunt files, I think that overriding is a bad idea unless you have specified some other .terragrunt file as a base. Then, Terragrunt would do a hash-merge, overriding values from base file with the current file. Overriding shouldn't happen as an automagical activity.
I do see a value in multiple .terragrunt files. For example, if I am managing a bunch of different things, including several DNS zones. I might want all the DNS zones to have the same lockfile so that all DNS changes are single-threaded. But, a DNS change could happen at the same time as a database change. So, my root .terragrunt file would use relative_path() to derive the lockfile key, but my DNS zones would have a .terragrunt file that would look something like:
basefile = "../.terragrunt"
lock = {
  config {
    state_file_id = "terragrunt-locks/dns"
  }
}

That said, if I don't set a basefile, then don't keep looking for .terragrunt files.
Also, I would terminate the .terragrunt parent-directory search once you find a .git directory.

Also, I would terminate the .terragrunt parent-directory search once you find a .git directory.

This is a great idea, but it makes me realize the end user may be left wondering when terragrunt stops searching for .terragrunt files.
Another concern is what if there's a non-root .terragrunt file in a parent folder. How would the template know it's not the root without a basefile attribute? Or should .terragrunt files be "hierarchical" so that the root .terragrunt sets the defaults, and any other .terragrunt file can override for his directory and his descendants?

This is a great idea, but it makes me realize the end user may be left wondering when terragrunt stops searching for .terragrunt files.

I think this is solved by two actions:

documentation
Adding a --debug option which outputs (among other things) which directories terragrunt searches for a .terragrunt file and why it stops searching when it stops.

... should .terragrunt files be "hierarchical" so that the root .terragrunt sets the defaults, and any other .terragrunt file can override for his directory and his descendants?

I think this is a very logical extension and is almost simpler to code than the parent-child-only option.

@josh-padnick and @robkinyon, please check out #59 and share your feedback!


Minor fixes to C SDK HTTPS Client

This is Ramsès from Silicon Labs Inc. We were unable to build HTTPS Client because of the following issues:

The source code of HTTPS Client includes a "C file" from the testing code, namely the access APIs C file ("iot_test_access_https_client.c"). Unfortunately this causes problems with our toolchain and automation tools, and it also doesn't align with our coding standards as we don't allow the inclusion of C files from other C files. This PR converts the file into a header.

Missing simicolon after a Unity macro causes problems with the most recent version of unity. This PR adds the missing semicolon.

Thanks!

Hello Ramsès,
You don't have to compile the test code. You can set IOT_BUILD_TESTS to 0  and .c file will not be included. Our tests will not work if you change .c to .h.
Have you tried our new coreHTTP library ? It does not have this problem.  Also please note, https library will not be available in main in a few days. ( but be still available though tag and old releases)
Thanks.

Hi @iocoder. Unfortunately, we won't be able to accept these changes because it will break our current test suite. If you'd like to compile the library without test code, you can set IOT_BUILD_TESTS to 0.


Update cuDF's assert_eq import

https://github.com/rapidsai/cudf/pull/16063 has updated the import location of assert_eq to the public cudf.testing.assert_eq, this change updates imports accordingly.

/merge


Develop

Under Review By James Okunlade

Under review by James

We used to work on local feature branch.


Test a small cargo-miri smoke test even in run_tests_minimal

This makes sure that cargo-miri works on all targets.
Implements the first step of https://github.com/rust-lang/miri/pull/2685#issuecomment-1325155967 to get that PR tested.

libtest needs std, right. So uh, how exactly should I do this test crate? It should be no_std, but how should I do this? no_std binaries are tricky and platform specific and this should work on all platforms (and the ones that don't support std are the more funky ones usually :D).

Yeah that's why I suggested a 'cargo run' smoketest, not 'cargo test'.
Or is that still too platform-specific?

Getting a no_std binary running is still platform specific. I tried getting one to work (just on x86_64-unknown-linux-gnu) and after adding panic = "abort" and a #[panic_handler] it still needs an entry point and I didn't quite figure out what the best way to do that would be. Adding a #[start] function yielded linker errors about mising libc symbols (since libc isn't linked anymore) and I assume fixing this would require platform specific code to link the right things.

This is Miri, no linking should be required...
We successfully do run https://github.com/rust-lang/miri/blob/master/tests/pass/no_std.rs on no_std targets in our test suite. Does that not also work with cargo miri run?

Oh yes, this is Miri, I forgot about that :D
The example you have looks good, I think I can use that.

@bors r+

:pushpin: Commit d9b7035ae819f97300570928a38851c543f55fa1 has been approved by RalfJung
It is now in the queue for this repository.

:hourglass: Testing commit d9b7035ae819f97300570928a38851c543f55fa1 with merge c2eac5810cf71b3c3901e4b5c6db48f668672dd6...

:sunny: Test successful - checks-actions
Approved by: RalfJung
Pushing c2eac5810cf71b3c3901e4b5c6db48f668672dd6 to master...


HDFS-17068. Datanode should record last directory scan time.

Description of PR
please see HDFS-17068.

The result likes below:

@ayushtkn @Hexiaoqiao . Hi, sir. Could you please help me review this PR when you have free time ? Thanks a lot~

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Logfile
Comment

+0 :ok:
reexec
0m 41s

Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s

No case conflicting files found.

+0 :ok:
codespell
0m  0s

codespell was not available.

+0 :ok:
detsecrets
0m  0s

detect-secrets was not available.

+1 :green_heart:
@author
0m  0s

The patch does not contain any @author tags.

+1 :green_heart:
test4tests
0m  0s

The patch appears to include 2 new or modified test files.

_ trunk Compile Tests _

+1 :green_heart:
mvninstall
49m 46s

trunk passed

+1 :green_heart:
compile
1m 28s

trunk passed with JDK Ubuntu-11.0.19+7-post-Ubuntu-0ubuntu120.04.1

+1 :green_heart:
compile
1m 21s

trunk passed with JDK Private Build-1.8.0_362-8u372-ga~us1-0ubuntu1~20.04-b09

+1 :green_heart:
checkstyle
1m 15s

trunk passed

+1 :green_heart:
mvnsite
1m 36s

trunk passed

+1 :green_heart:
javadoc
1m 13s

trunk passed with JDK Ubuntu-11.0.19+7-post-Ubuntu-0ubuntu120.04.1

+1 :green_heart:
javadoc
1m 40s

trunk passed with JDK Private Build-1.8.0_362-8u372-ga~us1-0ubuntu1~20.04-b09

+1 :green_heart:
spotbugs
3m 24s

trunk passed

+1 :green_heart:
shadedclient
41m 13s

branch has no errors when building and testing our client artifacts.

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
1m 22s

the patch passed

+1 :green_heart:
compile
1m 21s

the patch passed with JDK Ubuntu-11.0.19+7-post-Ubuntu-0ubuntu120.04.1

+1 :green_heart:
javac
1m 21s

the patch passed

+1 :green_heart:
compile
1m 16s

the patch passed with JDK Private Build-1.8.0_362-8u372-ga~us1-0ubuntu1~20.04-b09

+1 :green_heart:
javac
1m 16s

the patch passed

+1 :green_heart:
blanks
0m  0s

The patch has no blanks issues.

-0 :warning:
checkstyle
1m  4s
/results-checkstyle-hadoop-hdfs-project_hadoop-hdfs.txt
hadoop-hdfs-project/hadoop-hdfs: The patch generated 1 new + 143 unchanged - 0 fixed = 144 total (was 143)

+1 :green_heart:
mvnsite
1m 21s

the patch passed

+1 :green_heart:
javadoc
0m 58s

the patch passed with JDK Ubuntu-11.0.19+7-post-Ubuntu-0ubuntu120.04.1

+1 :green_heart:
javadoc
1m 34s

the patch passed with JDK Private Build-1.8.0_362-8u372-ga~us1-0ubuntu1~20.04-b09

+1 :green_heart:
spotbugs
3m 43s

the patch passed

+1 :green_heart:
shadedclient
42m  8s

patch has no errors when building and testing our client artifacts.

_ Other Tests _

+1 :green_heart:
unit
213m 55s

hadoop-hdfs in the patch passed.

+1 :green_heart:
asflicense
0m 55s

The patch does not generate ASF License warnings.

373m 40s

Subsystem
Report/Notes

Docker
ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5809/1/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/5809

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell detsecrets

uname
Linux ac34a57bd2ea 4.15.0-212-generic #223-Ubuntu SMP Tue May 23 13:09:22 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/bin/hadoop.sh

git revision
trunk / ff94d199624bd5fb099488309a7f52c39aa53eb1

Default Java
Private Build-1.8.0_362-8u372-ga~us1-0ubuntu1~20.04-b09

Multi-JDK versions
/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.19+7-post-Ubuntu-0ubuntu120.04.1 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_362-8u372-ga~us1-0ubuntu1~20.04-b09

Test Results
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5809/1/testReport/

Max. process+thread count
3647 (vs. ulimit of 5500)

modules
C: hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project/hadoop-hdfs

Console output
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5809/1/console

versions
git=2.25.1 maven=3.6.3 spotbugs=4.2.2

Powered by
Apache Yetus 0.14.0 https://yetus.apache.org

This message was automatically generated.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Logfile
Comment

+0 :ok:
reexec
0m 59s

Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s

No case conflicting files found.

+0 :ok:
codespell
0m  1s

codespell was not available.

+0 :ok:
detsecrets
0m  1s

detect-secrets was not available.

+1 :green_heart:
@author
0m  0s

The patch does not contain any @author tags.

+1 :green_heart:
test4tests
0m  0s

The patch appears to include 2 new or modified test files.

_ trunk Compile Tests _

+1 :green_heart:
mvninstall
45m 42s

trunk passed

+1 :green_heart:
compile
1m 21s

trunk passed with JDK Ubuntu-11.0.19+7-post-Ubuntu-0ubuntu120.04.1

+1 :green_heart:
compile
1m 21s

trunk passed with JDK Private Build-1.8.0_362-8u372-ga~us1-0ubuntu1~20.04-b09

+1 :green_heart:
checkstyle
1m 15s

trunk passed

+1 :green_heart:
mvnsite
1m 29s

trunk passed

+1 :green_heart:
javadoc
1m 10s

trunk passed with JDK Ubuntu-11.0.19+7-post-Ubuntu-0ubuntu120.04.1

+1 :green_heart:
javadoc
1m 36s

trunk passed with JDK Private Build-1.8.0_362-8u372-ga~us1-0ubuntu1~20.04-b09

+1 :green_heart:
spotbugs
3m 18s

trunk passed

+1 :green_heart:
shadedclient
36m 56s

branch has no errors when building and testing our client artifacts.

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
1m 17s

the patch passed

+1 :green_heart:
compile
1m 16s

the patch passed with JDK Ubuntu-11.0.19+7-post-Ubuntu-0ubuntu120.04.1

+1 :green_heart:
javac
1m 16s

the patch passed

+1 :green_heart:
compile
1m  6s

the patch passed with JDK Private Build-1.8.0_362-8u372-ga~us1-0ubuntu1~20.04-b09

+1 :green_heart:
javac
1m  6s

the patch passed

+1 :green_heart:
blanks
0m  0s

The patch has no blanks issues.

-0 :warning:
checkstyle
1m  1s
/results-checkstyle-hadoop-hdfs-project_hadoop-hdfs.txt
hadoop-hdfs-project/hadoop-hdfs: The patch generated 3 new + 159 unchanged - 1 fixed = 162 total (was 160)

+1 :green_heart:
mvnsite
1m 15s

the patch passed

+1 :green_heart:
javadoc
0m 54s

the patch passed with JDK Ubuntu-11.0.19+7-post-Ubuntu-0ubuntu120.04.1

+1 :green_heart:
javadoc
1m 27s

the patch passed with JDK Private Build-1.8.0_362-8u372-ga~us1-0ubuntu1~20.04-b09

+1 :green_heart:
spotbugs
3m 15s

the patch passed

+1 :green_heart:
shadedclient
35m 32s

patch has no errors when building and testing our client artifacts.

_ Other Tests _

-1 :x:
unit
253m  0s
/patch-unit-hadoop-hdfs-project_hadoop-hdfs.txt
hadoop-hdfs in the patch passed.

+1 :green_heart:
asflicense
0m 56s

The patch does not generate ASF License warnings.

396m 17s

Reason
Tests

Failed junit tests
hadoop.hdfs.TestRollingUpgrade

Subsystem
Report/Notes

Docker
ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5809/2/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/5809

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell detsecrets

uname
Linux a7d55faaa3d5 4.15.0-212-generic #223-Ubuntu SMP Tue May 23 13:09:22 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/bin/hadoop.sh

git revision
trunk / 0765c66559e9179fd0e6898468659ca8d1d235c3

Default Java
Private Build-1.8.0_362-8u372-ga~us1-0ubuntu1~20.04-b09

Multi-JDK versions
/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.19+7-post-Ubuntu-0ubuntu120.04.1 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_362-8u372-ga~us1-0ubuntu1~20.04-b09

Test Results
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5809/2/testReport/

Max. process+thread count
3223 (vs. ulimit of 5500)

modules
C: hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project/hadoop-hdfs

Console output
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5809/2/console

versions
git=2.25.1 maven=3.6.3 spotbugs=4.2.2

Powered by
Apache Yetus 0.14.0 https://yetus.apache.org

This message was automatically generated.

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Logfile
Comment

+0 :ok:
reexec
0m 42s

Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s

No case conflicting files found.

+0 :ok:
codespell
0m  0s

codespell was not available.

+0 :ok:
detsecrets
0m  0s

detect-secrets was not available.

+1 :green_heart:
@author
0m  0s

The patch does not contain any @author tags.

+1 :green_heart:
test4tests
0m  0s

The patch appears to include 2 new or modified test files.

_ trunk Compile Tests _

+1 :green_heart:
mvninstall
48m 38s

trunk passed

+1 :green_heart:
compile
1m 35s

trunk passed with JDK Ubuntu-11.0.19+7-post-Ubuntu-0ubuntu120.04.1

+1 :green_heart:
compile
1m 19s

trunk passed with JDK Private Build-1.8.0_362-8u372-ga~us1-0ubuntu1~20.04-b09

+1 :green_heart:
checkstyle
1m 22s

trunk passed

+1 :green_heart:
mvnsite
1m 35s

trunk passed

+1 :green_heart:
javadoc
1m 16s

trunk passed with JDK Ubuntu-11.0.19+7-post-Ubuntu-0ubuntu120.04.1

+1 :green_heart:
javadoc
1m 42s

trunk passed with JDK Private Build-1.8.0_362-8u372-ga~us1-0ubuntu1~20.04-b09

+1 :green_heart:
spotbugs
3m 39s

trunk passed

+1 :green_heart:
shadedclient
42m 21s

branch has no errors when building and testing our client artifacts.

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
1m 23s

the patch passed

+1 :green_heart:
compile
1m 22s

the patch passed with JDK Ubuntu-11.0.19+7-post-Ubuntu-0ubuntu120.04.1

+1 :green_heart:
javac
1m 22s

the patch passed

+1 :green_heart:
compile
1m 18s

the patch passed with JDK Private Build-1.8.0_362-8u372-ga~us1-0ubuntu1~20.04-b09

+1 :green_heart:
javac
1m 18s

the patch passed

+1 :green_heart:
blanks
0m  0s

The patch has no blanks issues.

-0 :warning:
checkstyle
1m  8s
/results-checkstyle-hadoop-hdfs-project_hadoop-hdfs.txt
hadoop-hdfs-project/hadoop-hdfs: The patch generated 3 new + 158 unchanged - 2 fixed = 161 total (was 160)

+1 :green_heart:
mvnsite
1m 23s

the patch passed

+1 :green_heart:
javadoc
1m  1s

the patch passed with JDK Ubuntu-11.0.19+7-post-Ubuntu-0ubuntu120.04.1

+1 :green_heart:
javadoc
1m 33s

the patch passed with JDK Private Build-1.8.0_362-8u372-ga~us1-0ubuntu1~20.04-b09

+1 :green_heart:
spotbugs
3m 37s

the patch passed

+1 :green_heart:
shadedclient
41m 40s

patch has no errors when building and testing our client artifacts.

_ Other Tests _

+1 :green_heart:
unit
212m 33s

hadoop-hdfs in the patch passed.

+1 :green_heart:
asflicense
0m 55s

The patch does not generate ASF License warnings.

371m 58s

Subsystem
Report/Notes

Docker
ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5809/3/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/5809

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell detsecrets

uname
Linux 279e1ae7faad 4.15.0-212-generic #223-Ubuntu SMP Tue May 23 13:09:22 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/bin/hadoop.sh

git revision
trunk / da069e1f3851bfdf827adc020b027d9cf0e06768

Default Java
Private Build-1.8.0_362-8u372-ga~us1-0ubuntu1~20.04-b09

Multi-JDK versions
/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.19+7-post-Ubuntu-0ubuntu120.04.1 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_362-8u372-ga~us1-0ubuntu1~20.04-b09

Test Results
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5809/3/testReport/

Max. process+thread count
3815 (vs. ulimit of 5500)

modules
C: hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project/hadoop-hdfs

Console output
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5809/3/console

versions
git=2.25.1 maven=3.6.3 spotbugs=4.2.2

Powered by
Apache Yetus 0.14.0 https://yetus.apache.org

This message was automatically generated.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Logfile
Comment

+0 :ok:
reexec
0m 58s

Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  1s

No case conflicting files found.

+0 :ok:
codespell
0m  0s

codespell was not available.

+0 :ok:
detsecrets
0m  0s

detect-secrets was not available.

+1 :green_heart:
@author
0m  0s

The patch does not contain any @author tags.

+1 :green_heart:
test4tests
0m  0s

The patch appears to include 2 new or modified test files.

_ trunk Compile Tests _

+1 :green_heart:
mvninstall
45m 40s

trunk passed

+1 :green_heart:
compile
1m 27s

trunk passed with JDK Ubuntu-11.0.19+7-post-Ubuntu-0ubuntu120.04.1

+1 :green_heart:
compile
1m 20s

trunk passed with JDK Private Build-1.8.0_362-8u372-ga~us1-0ubuntu1~20.04-b09

+1 :green_heart:
checkstyle
1m 15s

trunk passed

+1 :green_heart:
mvnsite
1m 28s

trunk passed

+1 :green_heart:
javadoc
1m 10s

trunk passed with JDK Ubuntu-11.0.19+7-post-Ubuntu-0ubuntu120.04.1

+1 :green_heart:
javadoc
1m 40s

trunk passed with JDK Private Build-1.8.0_362-8u372-ga~us1-0ubuntu1~20.04-b09

+1 :green_heart:
spotbugs
3m 15s

trunk passed

+1 :green_heart:
shadedclient
36m  0s

branch has no errors when building and testing our client artifacts.

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
1m 13s

the patch passed

+1 :green_heart:
compile
1m 15s

the patch passed with JDK Ubuntu-11.0.19+7-post-Ubuntu-0ubuntu120.04.1

+1 :green_heart:
javac
1m 15s

the patch passed

+1 :green_heart:
compile
1m 10s

the patch passed with JDK Private Build-1.8.0_362-8u372-ga~us1-0ubuntu1~20.04-b09

+1 :green_heart:
javac
1m 10s

the patch passed

+1 :green_heart:
blanks
0m  0s

The patch has no blanks issues.

-0 :warning:
checkstyle
0m 59s
/results-checkstyle-hadoop-hdfs-project_hadoop-hdfs.txt
hadoop-hdfs-project/hadoop-hdfs: The patch generated 3 new + 158 unchanged - 2 fixed = 161 total (was 160)

+1 :green_heart:
mvnsite
1m 15s

the patch passed

+1 :green_heart:
javadoc
0m 56s

the patch passed with JDK Ubuntu-11.0.19+7-post-Ubuntu-0ubuntu120.04.1

+1 :green_heart:
javadoc
1m 30s

the patch passed with JDK Private Build-1.8.0_362-8u372-ga~us1-0ubuntu1~20.04-b09

+1 :green_heart:
spotbugs
3m 13s

the patch passed

+1 :green_heart:
shadedclient
36m 21s

patch has no errors when building and testing our client artifacts.

_ Other Tests _

-1 :x:
unit
254m 43s
/patch-unit-hadoop-hdfs-project_hadoop-hdfs.txt
hadoop-hdfs in the patch passed.

+1 :green_heart:
asflicense
0m 56s

The patch does not generate ASF License warnings.

398m 21s

Reason
Tests

Failed junit tests
hadoop.hdfs.server.datanode.TestDirectoryScanner

Subsystem
Report/Notes

Docker
ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5809/4/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/5809

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell detsecrets

uname
Linux 95543c039e38 4.15.0-212-generic #223-Ubuntu SMP Tue May 23 13:09:22 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/bin/hadoop.sh

git revision
trunk / da069e1f3851bfdf827adc020b027d9cf0e06768

Default Java
Private Build-1.8.0_362-8u372-ga~us1-0ubuntu1~20.04-b09

Multi-JDK versions
/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.19+7-post-Ubuntu-0ubuntu120.04.1 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_362-8u372-ga~us1-0ubuntu1~20.04-b09

Test Results
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5809/4/testReport/

Max. process+thread count
3078 (vs. ulimit of 5500)

modules
C: hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project/hadoop-hdfs

Console output
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5809/4/console

versions
git=2.25.1 maven=3.6.3 spotbugs=4.2.2

Powered by
Apache Yetus 0.14.0 https://yetus.apache.org

This message was automatically generated.

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Logfile
Comment

+0 :ok:
reexec
0m 41s

Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s

No case conflicting files found.

+0 :ok:
codespell
0m  1s

codespell was not available.

+0 :ok:
detsecrets
0m  1s

detect-secrets was not available.

+1 :green_heart:
@author
0m  0s

The patch does not contain any @author tags.

+1 :green_heart:
test4tests
0m  0s

The patch appears to include 2 new or modified test files.

_ trunk Compile Tests _

+1 :green_heart:
mvninstall
48m 12s

trunk passed

+1 :green_heart:
compile
1m 25s

trunk passed with JDK Ubuntu-11.0.19+7-post-Ubuntu-0ubuntu120.04.1

+1 :green_heart:
compile
1m 22s

trunk passed with JDK Private Build-1.8.0_362-8u372-ga~us1-0ubuntu1~20.04-b09

+1 :green_heart:
checkstyle
1m 14s

trunk passed

+1 :green_heart:
mvnsite
1m 31s

trunk passed

+1 :green_heart:
javadoc
1m 13s

trunk passed with JDK Ubuntu-11.0.19+7-post-Ubuntu-0ubuntu120.04.1

+1 :green_heart:
javadoc
1m 44s

trunk passed with JDK Private Build-1.8.0_362-8u372-ga~us1-0ubuntu1~20.04-b09

+1 :green_heart:
spotbugs
3m 29s

trunk passed

+1 :green_heart:
shadedclient
38m 24s

branch has no errors when building and testing our client artifacts.

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
1m 19s

the patch passed

+1 :green_heart:
compile
1m 23s

the patch passed with JDK Ubuntu-11.0.19+7-post-Ubuntu-0ubuntu120.04.1

+1 :green_heart:
javac
1m 23s

the patch passed

+1 :green_heart:
compile
1m 11s

the patch passed with JDK Private Build-1.8.0_362-8u372-ga~us1-0ubuntu1~20.04-b09

+1 :green_heart:
javac
1m 11s

the patch passed

+1 :green_heart:
blanks
0m  0s

The patch has no blanks issues.

-0 :warning:
checkstyle
1m  8s
/results-checkstyle-hadoop-hdfs-project_hadoop-hdfs.txt
hadoop-hdfs-project/hadoop-hdfs: The patch generated 2 new + 158 unchanged - 2 fixed = 160 total (was 160)

+1 :green_heart:
mvnsite
1m 22s

the patch passed

+1 :green_heart:
javadoc
0m 59s

the patch passed with JDK Ubuntu-11.0.19+7-post-Ubuntu-0ubuntu120.04.1

+1 :green_heart:
javadoc
1m 34s

the patch passed with JDK Private Build-1.8.0_362-8u372-ga~us1-0ubuntu1~20.04-b09

+1 :green_heart:
spotbugs
3m 22s

the patch passed

+1 :green_heart:
shadedclient
41m 44s

patch has no errors when building and testing our client artifacts.

_ Other Tests _

+1 :green_heart:
unit
212m 59s

hadoop-hdfs in the patch passed.

+1 :green_heart:
asflicense
0m 57s

The patch does not generate ASF License warnings.

367m 25s

Subsystem
Report/Notes

Docker
ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5809/6/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/5809

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell detsecrets

uname
Linux 927f0a9ba344 4.15.0-212-generic #223-Ubuntu SMP Tue May 23 13:09:22 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/bin/hadoop.sh

git revision
trunk / 72b3693c06c66cfd3121a8434c0266f51e0ffe91

Default Java
Private Build-1.8.0_362-8u372-ga~us1-0ubuntu1~20.04-b09

Multi-JDK versions
/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.19+7-post-Ubuntu-0ubuntu120.04.1 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_362-8u372-ga~us1-0ubuntu1~20.04-b09

Test Results
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5809/6/testReport/

Max. process+thread count
3096 (vs. ulimit of 5500)

modules
C: hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project/hadoop-hdfs

Console output
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5809/6/console

versions
git=2.25.1 maven=3.6.3 spotbugs=4.2.2

Powered by
Apache Yetus 0.14.0 https://yetus.apache.org

This message was automatically generated.

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Logfile
Comment

+0 :ok:
reexec
0m 40s

Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s

No case conflicting files found.

+0 :ok:
codespell
0m  1s

codespell was not available.

+0 :ok:
detsecrets
0m  1s

detect-secrets was not available.

+1 :green_heart:
@author
0m  0s

The patch does not contain any @author tags.

+1 :green_heart:
test4tests
0m  0s

The patch appears to include 2 new or modified test files.

_ trunk Compile Tests _

+1 :green_heart:
mvninstall
48m 26s

trunk passed

+1 :green_heart:
compile
1m 26s

trunk passed with JDK Ubuntu-11.0.19+7-post-Ubuntu-0ubuntu120.04.1

+1 :green_heart:
compile
1m 19s

trunk passed with JDK Private Build-1.8.0_362-8u372-ga~us1-0ubuntu1~20.04-b09

+1 :green_heart:
checkstyle
1m 12s

trunk passed

+1 :green_heart:
mvnsite
1m 31s

trunk passed

+1 :green_heart:
javadoc
1m 11s

trunk passed with JDK Ubuntu-11.0.19+7-post-Ubuntu-0ubuntu120.04.1

+1 :green_heart:
javadoc
1m 35s

trunk passed with JDK Private Build-1.8.0_362-8u372-ga~us1-0ubuntu1~20.04-b09

+1 :green_heart:
spotbugs
3m 38s

trunk passed

+1 :green_heart:
shadedclient
39m 19s

branch has no errors when building and testing our client artifacts.

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
1m 22s

the patch passed

+1 :green_heart:
compile
1m 25s

the patch passed with JDK Ubuntu-11.0.19+7-post-Ubuntu-0ubuntu120.04.1

+1 :green_heart:
javac
1m 25s

the patch passed

+1 :green_heart:
compile
1m 17s

the patch passed with JDK Private Build-1.8.0_362-8u372-ga~us1-0ubuntu1~20.04-b09

+1 :green_heart:
javac
1m 17s

the patch passed

+1 :green_heart:
blanks
0m  0s

The patch has no blanks issues.

-0 :warning:
checkstyle
1m  4s
/results-checkstyle-hadoop-hdfs-project_hadoop-hdfs.txt
hadoop-hdfs-project/hadoop-hdfs: The patch generated 2 new + 159 unchanged - 1 fixed = 161 total (was 160)

+1 :green_heart:
mvnsite
1m 22s

the patch passed

+1 :green_heart:
javadoc
0m 57s

the patch passed with JDK Ubuntu-11.0.19+7-post-Ubuntu-0ubuntu120.04.1

+1 :green_heart:
javadoc
1m 27s

the patch passed with JDK Private Build-1.8.0_362-8u372-ga~us1-0ubuntu1~20.04-b09

+1 :green_heart:
spotbugs
3m 29s

the patch passed

+1 :green_heart:
shadedclient
40m  5s

patch has no errors when building and testing our client artifacts.

_ Other Tests _

+1 :green_heart:
unit
216m  4s

hadoop-hdfs in the patch passed.

+1 :green_heart:
asflicense
0m 55s

The patch does not generate ASF License warnings.

369m 31s

Subsystem
Report/Notes

Docker
ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5809/7/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/5809

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell detsecrets

uname
Linux ce1e2c77b12e 4.15.0-212-generic #223-Ubuntu SMP Tue May 23 13:09:22 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/bin/hadoop.sh

git revision
trunk / f08763bbe709a67046eac3e88fb7b10cbee19d38

Default Java
Private Build-1.8.0_362-8u372-ga~us1-0ubuntu1~20.04-b09

Multi-JDK versions
/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.19+7-post-Ubuntu-0ubuntu120.04.1 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_362-8u372-ga~us1-0ubuntu1~20.04-b09

Test Results
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5809/7/testReport/

Max. process+thread count
3631 (vs. ulimit of 5500)

modules
C: hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project/hadoop-hdfs

Console output
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5809/7/console

versions
git=2.25.1 maven=3.6.3 spotbugs=4.2.2

Powered by
Apache Yetus 0.14.0 https://yetus.apache.org

This message was automatically generated.

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Logfile
Comment

+0 :ok:
reexec
0m 57s

Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  1s

No case conflicting files found.

+0 :ok:
codespell
0m  0s

codespell was not available.

+0 :ok:
detsecrets
0m  0s

detect-secrets was not available.

+1 :green_heart:
@author
0m  0s

The patch does not contain any @author tags.

+1 :green_heart:
test4tests
0m  0s

The patch appears to include 2 new or modified test files.

_ trunk Compile Tests _

+1 :green_heart:
mvninstall
46m  6s

trunk passed

+1 :green_heart:
compile
1m 23s

trunk passed with JDK Ubuntu-11.0.19+7-post-Ubuntu-0ubuntu120.04.1

+1 :green_heart:
compile
1m 20s

trunk passed with JDK Private Build-1.8.0_362-8u372-ga~us1-0ubuntu1~20.04-b09

+1 :green_heart:
checkstyle
1m 16s

trunk passed

+1 :green_heart:
mvnsite
1m 29s

trunk passed

+1 :green_heart:
javadoc
1m 12s

trunk passed with JDK Ubuntu-11.0.19+7-post-Ubuntu-0ubuntu120.04.1

+1 :green_heart:
javadoc
1m 39s

trunk passed with JDK Private Build-1.8.0_362-8u372-ga~us1-0ubuntu1~20.04-b09

+1 :green_heart:
spotbugs
3m 20s

trunk passed

+1 :green_heart:
shadedclient
36m 45s

branch has no errors when building and testing our client artifacts.

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
1m 16s

the patch passed

+1 :green_heart:
compile
1m 15s

the patch passed with JDK Ubuntu-11.0.19+7-post-Ubuntu-0ubuntu120.04.1

+1 :green_heart:
javac
1m 15s

the patch passed

+1 :green_heart:
compile
1m  9s

the patch passed with JDK Private Build-1.8.0_362-8u372-ga~us1-0ubuntu1~20.04-b09

+1 :green_heart:
javac
1m  9s

the patch passed

+1 :green_heart:
blanks
0m  0s

The patch has no blanks issues.

-0 :warning:
checkstyle
1m  0s
/results-checkstyle-hadoop-hdfs-project_hadoop-hdfs.txt
hadoop-hdfs-project/hadoop-hdfs: The patch generated 2 new + 159 unchanged - 1 fixed = 161 total (was 160)

+1 :green_heart:
mvnsite
1m 15s

the patch passed

+1 :green_heart:
javadoc
0m 57s

the patch passed with JDK Ubuntu-11.0.19+7-post-Ubuntu-0ubuntu120.04.1

+1 :green_heart:
javadoc
1m 24s

the patch passed with JDK Private Build-1.8.0_362-8u372-ga~us1-0ubuntu1~20.04-b09

+1 :green_heart:
spotbugs
3m 10s

the patch passed

+1 :green_heart:
shadedclient
36m 44s

patch has no errors when building and testing our client artifacts.

_ Other Tests _

+1 :green_heart:
unit
261m 26s

hadoop-hdfs in the patch passed.

+1 :green_heart:
asflicense
0m 54s

The patch does not generate ASF License warnings.

406m 19s

Subsystem
Report/Notes

Docker
ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5809/8/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/5809

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell detsecrets

uname
Linux e94e5041aa70 4.15.0-212-generic #223-Ubuntu SMP Tue May 23 13:09:22 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/bin/hadoop.sh

git revision
trunk / 10a223d5930caf84399d7be00675131e9b85bb17

Default Java
Private Build-1.8.0_362-8u372-ga~us1-0ubuntu1~20.04-b09

Multi-JDK versions
/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.19+7-post-Ubuntu-0ubuntu120.04.1 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_362-8u372-ga~us1-0ubuntu1~20.04-b09

Test Results
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5809/8/testReport/

Max. process+thread count
2962 (vs. ulimit of 5500)

modules
C: hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project/hadoop-hdfs

Console output
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5809/8/console

versions
git=2.25.1 maven=3.6.3 spotbugs=4.2.2

Powered by
Apache Yetus 0.14.0 https://yetus.apache.org

This message was automatically generated.

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Logfile
Comment

+0 :ok:
reexec
0m 42s

Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s

No case conflicting files found.

+0 :ok:
codespell
0m  0s

codespell was not available.

+0 :ok:
detsecrets
0m  0s

detect-secrets was not available.

+1 :green_heart:
@author
0m  0s

The patch does not contain any @author tags.

+1 :green_heart:
test4tests
0m  0s

The patch appears to include 2 new or modified test files.

_ trunk Compile Tests _

+1 :green_heart:
mvninstall
50m 44s

trunk passed

+1 :green_heart:
compile
1m 28s

trunk passed with JDK Ubuntu-11.0.19+7-post-Ubuntu-0ubuntu120.04.1

+1 :green_heart:
compile
1m 19s

trunk passed with JDK Private Build-1.8.0_362-8u372-ga~us1-0ubuntu1~20.04-b09

+1 :green_heart:
checkstyle
1m 23s

trunk passed

+1 :green_heart:
mvnsite
1m 35s

trunk passed

+1 :green_heart:
javadoc
1m 13s

trunk passed with JDK Ubuntu-11.0.19+7-post-Ubuntu-0ubuntu120.04.1

+1 :green_heart:
javadoc
1m 44s

trunk passed with JDK Private Build-1.8.0_362-8u372-ga~us1-0ubuntu1~20.04-b09

+1 :green_heart:
spotbugs
3m 32s

trunk passed

+1 :green_heart:
shadedclient
37m 26s

branch has no errors when building and testing our client artifacts.

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
1m 16s

the patch passed

+1 :green_heart:
compile
1m 17s

the patch passed with JDK Ubuntu-11.0.19+7-post-Ubuntu-0ubuntu120.04.1

+1 :green_heart:
javac
1m 17s

the patch passed

+1 :green_heart:
compile
1m 11s

the patch passed with JDK Private Build-1.8.0_362-8u372-ga~us1-0ubuntu1~20.04-b09

+1 :green_heart:
javac
1m 11s

the patch passed

+1 :green_heart:
blanks
0m  0s

The patch has no blanks issues.

-0 :warning:
checkstyle
1m  1s
/results-checkstyle-hadoop-hdfs-project_hadoop-hdfs.txt
hadoop-hdfs-project/hadoop-hdfs: The patch generated 2 new + 159 unchanged - 1 fixed = 161 total (was 160)

+1 :green_heart:
mvnsite
1m 21s

the patch passed

+1 :green_heart:
javadoc
1m  0s

the patch passed with JDK Ubuntu-11.0.19+7-post-Ubuntu-0ubuntu120.04.1

+1 :green_heart:
javadoc
1m 27s

the patch passed with JDK Private Build-1.8.0_362-8u372-ga~us1-0ubuntu1~20.04-b09

+1 :green_heart:
spotbugs
3m 32s

the patch passed

+1 :green_heart:
shadedclient
37m 50s

patch has no errors when building and testing our client artifacts.

_ Other Tests _

+1 :green_heart:
unit
210m 53s

hadoop-hdfs in the patch passed.

+1 :green_heart:
asflicense
0m 51s

The patch does not generate ASF License warnings.

362m 47s

Subsystem
Report/Notes

Docker
ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5809/11/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/5809

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell detsecrets

uname
Linux bb128cb2619a 4.15.0-212-generic #223-Ubuntu SMP Tue May 23 13:09:22 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/bin/hadoop.sh

git revision
trunk / 9333981bd1aa20b141f97d55dc5c25b8253d1f3a

Default Java
Private Build-1.8.0_362-8u372-ga~us1-0ubuntu1~20.04-b09

Multi-JDK versions
/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.19+7-post-Ubuntu-0ubuntu120.04.1 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_362-8u372-ga~us1-0ubuntu1~20.04-b09

Test Results
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5809/11/testReport/

Max. process+thread count
2937 (vs. ulimit of 5500)

modules
C: hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project/hadoop-hdfs

Console output
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5809/11/console

versions
git=2.25.1 maven=3.6.3 spotbugs=4.2.2

Powered by
Apache Yetus 0.14.0 https://yetus.apache.org

This message was automatically generated.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Logfile
Comment

+0 :ok:
reexec
0m 41s

Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s

No case conflicting files found.

+0 :ok:
codespell
0m  0s

codespell was not available.

+0 :ok:
detsecrets
0m  0s

detect-secrets was not available.

+1 :green_heart:
@author
0m  0s

The patch does not contain any @author tags.

+1 :green_heart:
test4tests
0m  0s

The patch appears to include 2 new or modified test files.

_ trunk Compile Tests _

+1 :green_heart:
mvninstall
47m 41s

trunk passed

+1 :green_heart:
compile
1m 27s

trunk passed with JDK Ubuntu-11.0.19+7-post-Ubuntu-0ubuntu120.04.1

+1 :green_heart:
compile
1m 24s

trunk passed with JDK Private Build-1.8.0_362-8u372-ga~us1-0ubuntu1~20.04-b09

+1 :green_heart:
checkstyle
1m 21s

trunk passed

+1 :green_heart:
mvnsite
1m 38s

trunk passed

+1 :green_heart:
javadoc
1m 14s

trunk passed with JDK Ubuntu-11.0.19+7-post-Ubuntu-0ubuntu120.04.1

+1 :green_heart:
javadoc
1m 40s

trunk passed with JDK Private Build-1.8.0_362-8u372-ga~us1-0ubuntu1~20.04-b09

+1 :green_heart:
spotbugs
3m 27s

trunk passed

+1 :green_heart:
shadedclient
41m 15s

branch has no errors when building and testing our client artifacts.

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
1m 18s

the patch passed

+1 :green_heart:
compile
1m 26s

the patch passed with JDK Ubuntu-11.0.19+7-post-Ubuntu-0ubuntu120.04.1

+1 :green_heart:
javac
1m 26s

the patch passed

+1 :green_heart:
compile
1m 17s

the patch passed with JDK Private Build-1.8.0_362-8u372-ga~us1-0ubuntu1~20.04-b09

+1 :green_heart:
javac
1m 17s

the patch passed

+1 :green_heart:
blanks
0m  0s

The patch has no blanks issues.

-0 :warning:
checkstyle
1m  9s
/results-checkstyle-hadoop-hdfs-project_hadoop-hdfs.txt
hadoop-hdfs-project/hadoop-hdfs: The patch generated 2 new + 159 unchanged - 1 fixed = 161 total (was 160)

+1 :green_heart:
mvnsite
1m 21s

the patch passed

+1 :green_heart:
javadoc
0m 59s

the patch passed with JDK Ubuntu-11.0.19+7-post-Ubuntu-0ubuntu120.04.1

+1 :green_heart:
javadoc
1m 35s

the patch passed with JDK Private Build-1.8.0_362-8u372-ga~us1-0ubuntu1~20.04-b09

+1 :green_heart:
spotbugs
3m 20s

the patch passed

+1 :green_heart:
shadedclient
37m 58s

patch has no errors when building and testing our client artifacts.

_ Other Tests _

-1 :x:
unit
216m 10s
/patch-unit-hadoop-hdfs-project_hadoop-hdfs.txt
hadoop-hdfs in the patch passed.

+1 :green_heart:
asflicense
0m 55s

The patch does not generate ASF License warnings.

369m 42s

Reason
Tests

Failed junit tests
hadoop.hdfs.server.namenode.ha.TestObserverNode

Subsystem
Report/Notes

Docker
ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5809/14/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/5809

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell detsecrets

uname
Linux 2f2e63244515 4.15.0-212-generic #223-Ubuntu SMP Tue May 23 13:09:22 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/bin/hadoop.sh

git revision
trunk / 2b1902efb02d3f875cfd17d1f7ce45f8a30f9656

Default Java
Private Build-1.8.0_362-8u372-ga~us1-0ubuntu1~20.04-b09

Multi-JDK versions
/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.19+7-post-Ubuntu-0ubuntu120.04.1 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_362-8u372-ga~us1-0ubuntu1~20.04-b09

Test Results
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5809/14/testReport/

Max. process+thread count
3301 (vs. ulimit of 5500)

modules
C: hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project/hadoop-hdfs

Console output
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5809/14/console

versions
git=2.25.1 maven=3.6.3 spotbugs=4.2.2

Powered by
Apache Yetus 0.14.0 https://yetus.apache.org

This message was automatically generated.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Logfile
Comment

+0 :ok:
reexec
0m 42s

Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s

No case conflicting files found.

+0 :ok:
codespell
0m  0s

codespell was not available.

+0 :ok:
detsecrets
0m  0s

detect-secrets was not available.

+1 :green_heart:
@author
0m  0s

The patch does not contain any @author tags.

+1 :green_heart:
test4tests
0m  0s

The patch appears to include 2 new or modified test files.

_ trunk Compile Tests _

+1 :green_heart:
mvninstall
50m 24s

trunk passed

+1 :green_heart:
compile
1m 27s

trunk passed with JDK Ubuntu-11.0.19+7-post-Ubuntu-0ubuntu120.04.1

+1 :green_heart:
compile
1m 20s

trunk passed with JDK Private Build-1.8.0_362-8u372-ga~us1-0ubuntu1~20.04-b09

+1 :green_heart:
checkstyle
1m 21s

trunk passed

+1 :green_heart:
mvnsite
1m 30s

trunk passed

+1 :green_heart:
javadoc
1m 10s

trunk passed with JDK Ubuntu-11.0.19+7-post-Ubuntu-0ubuntu120.04.1

+1 :green_heart:
javadoc
1m 34s

trunk passed with JDK Private Build-1.8.0_362-8u372-ga~us1-0ubuntu1~20.04-b09

+1 :green_heart:
spotbugs
3m 33s

trunk passed

+1 :green_heart:
shadedclient
39m 25s

branch has no errors when building and testing our client artifacts.

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
1m 19s

the patch passed

+1 :green_heart:
compile
1m 22s

the patch passed with JDK Ubuntu-11.0.19+7-post-Ubuntu-0ubuntu120.04.1

+1 :green_heart:
javac
1m 22s

the patch passed

+1 :green_heart:
compile
1m 15s

the patch passed with JDK Private Build-1.8.0_362-8u372-ga~us1-0ubuntu1~20.04-b09

+1 :green_heart:
javac
1m 15s

the patch passed

+1 :green_heart:
blanks
0m  0s

The patch has no blanks issues.

+1 :green_heart:
checkstyle
1m  5s

hadoop-hdfs-project/hadoop-hdfs: The patch generated 0 new + 159 unchanged - 1 fixed = 159 total (was 160)

+1 :green_heart:
mvnsite
1m 19s

the patch passed

+1 :green_heart:
javadoc
0m 57s

the patch passed with JDK Ubuntu-11.0.19+7-post-Ubuntu-0ubuntu120.04.1

+1 :green_heart:
javadoc
1m 29s

the patch passed with JDK Private Build-1.8.0_362-8u372-ga~us1-0ubuntu1~20.04-b09

+1 :green_heart:
spotbugs
3m 18s

the patch passed

+1 :green_heart:
shadedclient
38m 45s

patch has no errors when building and testing our client artifacts.

_ Other Tests _

-1 :x:
unit
214m 14s
/patch-unit-hadoop-hdfs-project_hadoop-hdfs.txt
hadoop-hdfs in the patch passed.

+1 :green_heart:
asflicense
0m 53s

The patch does not generate ASF License warnings.

368m 19s

Reason
Tests

Failed junit tests
hadoop.hdfs.server.datanode.fsdataset.impl.TestFsDatasetImpl

Subsystem
Report/Notes

Docker
ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5809/15/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/5809

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell detsecrets

uname
Linux 4f8dba861412 4.15.0-212-generic #223-Ubuntu SMP Tue May 23 13:09:22 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/bin/hadoop.sh

git revision
trunk / 0bdff1c6b24d72ced5d5932070efffb04b2c4184

Default Java
Private Build-1.8.0_362-8u372-ga~us1-0ubuntu1~20.04-b09

Multi-JDK versions
/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.19+7-post-Ubuntu-0ubuntu120.04.1 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_362-8u372-ga~us1-0ubuntu1~20.04-b09

Test Results
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5809/15/testReport/

Max. process+thread count
3068 (vs. ulimit of 5500)

modules
C: hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project/hadoop-hdfs

Console output
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5809/15/console

versions
git=2.25.1 maven=3.6.3 spotbugs=4.2.2

Powered by
Apache Yetus 0.14.0 https://yetus.apache.org

This message was automatically generated.

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Logfile
Comment

+0 :ok:
reexec
0m 59s

Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s

No case conflicting files found.

+0 :ok:
codespell
0m  1s

codespell was not available.

+0 :ok:
detsecrets
0m  1s

detect-secrets was not available.

+1 :green_heart:
@author
0m  0s

The patch does not contain any @author tags.

+1 :green_heart:
test4tests
0m  0s

The patch appears to include 2 new or modified test files.

_ trunk Compile Tests _

+1 :green_heart:
mvninstall
46m 23s

trunk passed

+1 :green_heart:
compile
1m 24s

trunk passed with JDK Ubuntu-11.0.19+7-post-Ubuntu-0ubuntu120.04.1

+1 :green_heart:
compile
1m 17s

trunk passed with JDK Private Build-1.8.0_362-8u372-ga~us1-0ubuntu1~20.04-b09

+1 :green_heart:
checkstyle
1m 15s

trunk passed

+1 :green_heart:
mvnsite
1m 28s

trunk passed

+1 :green_heart:
javadoc
1m 13s

trunk passed with JDK Ubuntu-11.0.19+7-post-Ubuntu-0ubuntu120.04.1

+1 :green_heart:
javadoc
1m 39s

trunk passed with JDK Private Build-1.8.0_362-8u372-ga~us1-0ubuntu1~20.04-b09

+1 :green_heart:
spotbugs
3m 17s

trunk passed

+1 :green_heart:
shadedclient
36m 27s

branch has no errors when building and testing our client artifacts.

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
1m 11s

the patch passed

+1 :green_heart:
compile
1m 15s

the patch passed with JDK Ubuntu-11.0.19+7-post-Ubuntu-0ubuntu120.04.1

+1 :green_heart:
javac
1m 15s

the patch passed

+1 :green_heart:
compile
1m 11s

the patch passed with JDK Private Build-1.8.0_362-8u372-ga~us1-0ubuntu1~20.04-b09

+1 :green_heart:
javac
1m 11s

the patch passed

+1 :green_heart:
blanks
0m  0s

The patch has no blanks issues.

+1 :green_heart:
checkstyle
1m  1s

hadoop-hdfs-project/hadoop-hdfs: The patch generated 0 new + 159 unchanged - 1 fixed = 159 total (was 160)

+1 :green_heart:
mvnsite
1m 15s

the patch passed

+1 :green_heart:
javadoc
0m 56s

the patch passed with JDK Ubuntu-11.0.19+7-post-Ubuntu-0ubuntu120.04.1

+1 :green_heart:
javadoc
1m 28s

the patch passed with JDK Private Build-1.8.0_362-8u372-ga~us1-0ubuntu1~20.04-b09

+1 :green_heart:
spotbugs
3m 10s

the patch passed

+1 :green_heart:
shadedclient
35m 49s

patch has no errors when building and testing our client artifacts.

_ Other Tests _

+1 :green_heart:
unit
258m 10s

hadoop-hdfs in the patch passed.

+1 :green_heart:
asflicense
0m 57s

The patch does not generate ASF License warnings.

402m  7s

Subsystem
Report/Notes

Docker
ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5809/16/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/5809

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell detsecrets

uname
Linux b9d320a01392 4.15.0-212-generic #223-Ubuntu SMP Tue May 23 13:09:22 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/bin/hadoop.sh

git revision
trunk / 0bdff1c6b24d72ced5d5932070efffb04b2c4184

Default Java
Private Build-1.8.0_362-8u372-ga~us1-0ubuntu1~20.04-b09

Multi-JDK versions
/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.19+7-post-Ubuntu-0ubuntu120.04.1 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_362-8u372-ga~us1-0ubuntu1~20.04-b09

Test Results
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5809/16/testReport/

Max. process+thread count
3565 (vs. ulimit of 5500)

modules
C: hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project/hadoop-hdfs

Console output
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5809/16/console

versions
git=2.25.1 maven=3.6.3 spotbugs=4.2.2

Powered by
Apache Yetus 0.14.0 https://yetus.apache.org

This message was automatically generated.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Logfile
Comment

+0 :ok:
reexec
0m 47s

Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s

No case conflicting files found.

+0 :ok:
codespell
0m  0s

codespell was not available.

+0 :ok:
detsecrets
0m  0s

detect-secrets was not available.

+1 :green_heart:
@author
0m  0s

The patch does not contain any @author tags.

+1 :green_heart:
test4tests
0m  0s

The patch appears to include 3 new or modified test files.

_ trunk Compile Tests _

-1 :x:
mvninstall
55m 18s
/branch-mvninstall-root.txt
root in trunk failed.

+1 :green_heart:
compile
1m 32s

trunk passed with JDK Ubuntu-11.0.19+7-post-Ubuntu-0ubuntu120.04.1

+1 :green_heart:
compile
1m 23s

trunk passed with JDK Private Build-1.8.0_362-8u372-ga~us1-0ubuntu1~20.04-b09

+1 :green_heart:
checkstyle
1m 18s

trunk passed

+1 :green_heart:
mvnsite
1m 36s

trunk passed

+1 :green_heart:
javadoc
1m 20s

trunk passed with JDK Ubuntu-11.0.19+7-post-Ubuntu-0ubuntu120.04.1

+1 :green_heart:
javadoc
1m 43s

trunk passed with JDK Private Build-1.8.0_362-8u372-ga~us1-0ubuntu1~20.04-b09

+1 :green_heart:
spotbugs
3m 40s

trunk passed

+1 :green_heart:
shadedclient
41m 18s

branch has no errors when building and testing our client artifacts.

-0 :warning:
patch
41m 42s

Used diff version of patch file. Binary files and potentially other changes not applied. Please rebase and squash commits if necessary.

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
1m 22s

the patch passed

+1 :green_heart:
compile
1m 23s

the patch passed with JDK Ubuntu-11.0.19+7-post-Ubuntu-0ubuntu120.04.1

+1 :green_heart:
javac
1m 23s

the patch passed

+1 :green_heart:
compile
1m 16s

the patch passed with JDK Private Build-1.8.0_362-8u372-ga~us1-0ubuntu1~20.04-b09

+1 :green_heart:
javac
1m 16s

the patch passed

+1 :green_heart:
blanks
0m  0s

The patch has no blanks issues.

+1 :green_heart:
checkstyle
1m 11s

hadoop-hdfs-project/hadoop-hdfs: The patch generated 0 new + 193 unchanged - 1 fixed = 193 total (was 194)

+1 :green_heart:
mvnsite
1m 28s

the patch passed

+1 :green_heart:
javadoc
1m  5s

the patch passed with JDK Ubuntu-11.0.19+7-post-Ubuntu-0ubuntu120.04.1

+1 :green_heart:
javadoc
1m 26s

the patch passed with JDK Private Build-1.8.0_362-8u372-ga~us1-0ubuntu1~20.04-b09

+1 :green_heart:
spotbugs
3m 30s

the patch passed

+1 :green_heart:
shadedclient
42m 24s

patch has no errors when building and testing our client artifacts.

_ Other Tests _

-1 :x:
unit
217m 37s
/patch-unit-hadoop-hdfs-project_hadoop-hdfs.txt
hadoop-hdfs in the patch passed.

+1 :green_heart:
asflicense
0m 57s

The patch does not generate ASF License warnings.

383m 52s

Reason
Tests

Failed junit tests
hadoop.hdfs.server.datanode.fsdataset.impl.TestFsDatasetImpl

hadoop.hdfs.server.namenode.ha.TestObserverNode

Subsystem
Report/Notes

Docker
ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5809/17/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/5809

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell detsecrets

uname
Linux 11a9dfa656d1 4.15.0-212-generic #223-Ubuntu SMP Tue May 23 13:09:22 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/bin/hadoop.sh

git revision
trunk / 0e26dfd6a56a0523f360e3f2f05b1a089f95c209

Default Java
Private Build-1.8.0_362-8u372-ga~us1-0ubuntu1~20.04-b09

Multi-JDK versions
/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.19+7-post-Ubuntu-0ubuntu120.04.1 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_362-8u372-ga~us1-0ubuntu1~20.04-b09

Test Results
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5809/17/testReport/

Max. process+thread count
3688 (vs. ulimit of 5500)

modules
C: hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project/hadoop-hdfs

Console output
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5809/17/console

versions
git=2.25.1 maven=3.6.3 spotbugs=4.2.2

Powered by
Apache Yetus 0.14.0 https://yetus.apache.org

This message was automatically generated.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Logfile
Comment

+0 :ok:
reexec
0m 44s

Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s

No case conflicting files found.

+0 :ok:
codespell
0m  0s

codespell was not available.

+0 :ok:
detsecrets
0m  0s

detect-secrets was not available.

+1 :green_heart:
@author
0m  0s

The patch does not contain any @author tags.

+1 :green_heart:
test4tests
0m  0s

The patch appears to include 3 new or modified test files.

_ trunk Compile Tests _

-1 :x:
mvninstall
51m  5s
/branch-mvninstall-root.txt
root in trunk failed.

+1 :green_heart:
compile
1m 24s

trunk passed with JDK Ubuntu-11.0.19+7-post-Ubuntu-0ubuntu120.04.1

+1 :green_heart:
compile
1m 17s

trunk passed with JDK Private Build-1.8.0_362-8u372-ga~us1-0ubuntu1~20.04-b09

+1 :green_heart:
checkstyle
1m 12s

trunk passed

+1 :green_heart:
mvnsite
1m 31s

trunk passed

+1 :green_heart:
javadoc
1m 13s

trunk passed with JDK Ubuntu-11.0.19+7-post-Ubuntu-0ubuntu120.04.1

+1 :green_heart:
javadoc
1m 40s

trunk passed with JDK Private Build-1.8.0_362-8u372-ga~us1-0ubuntu1~20.04-b09

+1 :green_heart:
spotbugs
3m 29s

trunk passed

+1 :green_heart:
shadedclient
39m 21s

branch has no errors when building and testing our client artifacts.

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
1m 22s

the patch passed

+1 :green_heart:
compile
1m 21s

the patch passed with JDK Ubuntu-11.0.19+7-post-Ubuntu-0ubuntu120.04.1

+1 :green_heart:
javac
1m 21s

the patch passed

+1 :green_heart:
compile
1m 14s

the patch passed with JDK Private Build-1.8.0_362-8u372-ga~us1-0ubuntu1~20.04-b09

+1 :green_heart:
javac
1m 14s

the patch passed

+1 :green_heart:
blanks
0m  0s

The patch has no blanks issues.

-0 :warning:
checkstyle
1m  1s
/results-checkstyle-hadoop-hdfs-project_hadoop-hdfs.txt
hadoop-hdfs-project/hadoop-hdfs: The patch generated 1 new + 193 unchanged - 1 fixed = 194 total (was 194)

+1 :green_heart:
mvnsite
1m 26s

the patch passed

+1 :green_heart:
javadoc
1m  1s

the patch passed with JDK Ubuntu-11.0.19+7-post-Ubuntu-0ubuntu120.04.1

+1 :green_heart:
javadoc
1m 33s

the patch passed with JDK Private Build-1.8.0_362-8u372-ga~us1-0ubuntu1~20.04-b09

+1 :green_heart:
spotbugs
3m 40s

the patch passed

+1 :green_heart:
shadedclient
39m 55s

patch has no errors when building and testing our client artifacts.

_ Other Tests _

+1 :green_heart:
unit
216m 33s

hadoop-hdfs in the patch passed.

+1 :green_heart:
asflicense
0m 58s

The patch does not generate ASF License warnings.

372m 49s

Subsystem
Report/Notes

Docker
ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5809/18/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/5809

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell detsecrets

uname
Linux 53f5a1db5427 4.15.0-212-generic #223-Ubuntu SMP Tue May 23 13:09:22 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/bin/hadoop.sh

git revision
trunk / 4354b94e2438a2bc34025493eff325748612167f

Default Java
Private Build-1.8.0_362-8u372-ga~us1-0ubuntu1~20.04-b09

Multi-JDK versions
/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.19+7-post-Ubuntu-0ubuntu120.04.1 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_362-8u372-ga~us1-0ubuntu1~20.04-b09

Test Results
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5809/18/testReport/

Max. process+thread count
2981 (vs. ulimit of 5500)

modules
C: hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project/hadoop-hdfs

Console output
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5809/18/console

versions
git=2.25.1 maven=3.6.3 spotbugs=4.2.2

Powered by
Apache Yetus 0.14.0 https://yetus.apache.org

This message was automatically generated.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Logfile
Comment

+0 :ok:
reexec
0m 56s

Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s

No case conflicting files found.

+0 :ok:
codespell
0m  1s

codespell was not available.

+0 :ok:
detsecrets
0m  1s

detect-secrets was not available.

+1 :green_heart:
@author
0m  0s

The patch does not contain any @author tags.

+1 :green_heart:
test4tests
0m  0s

The patch appears to include 3 new or modified test files.

_ trunk Compile Tests _

+1 :green_heart:
mvninstall
44m 31s

trunk passed

+1 :green_heart:
compile
1m 25s

trunk passed with JDK Ubuntu-11.0.19+7-post-Ubuntu-0ubuntu120.04.1

+1 :green_heart:
compile
1m 17s

trunk passed with JDK Private Build-1.8.0_362-8u372-ga~us1-0ubuntu1~20.04-b09

+1 :green_heart:
checkstyle
1m 16s

trunk passed

+1 :green_heart:
mvnsite
1m 29s

trunk passed

+1 :green_heart:
javadoc
1m 12s

trunk passed with JDK Ubuntu-11.0.19+7-post-Ubuntu-0ubuntu120.04.1

+1 :green_heart:
javadoc
1m 43s

trunk passed with JDK Private Build-1.8.0_362-8u372-ga~us1-0ubuntu1~20.04-b09

+1 :green_heart:
spotbugs
3m 20s

trunk passed

+1 :green_heart:
shadedclient
35m 13s

branch has no errors when building and testing our client artifacts.

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
1m 10s

the patch passed

+1 :green_heart:
compile
1m 13s

the patch passed with JDK Ubuntu-11.0.19+7-post-Ubuntu-0ubuntu120.04.1

+1 :green_heart:
javac
1m 13s

the patch passed

+1 :green_heart:
compile
1m  9s

the patch passed with JDK Private Build-1.8.0_362-8u372-ga~us1-0ubuntu1~20.04-b09

+1 :green_heart:
javac
1m  9s

the patch passed

+1 :green_heart:
blanks
0m  0s

The patch has no blanks issues.

+1 :green_heart:
checkstyle
1m  2s

hadoop-hdfs-project/hadoop-hdfs: The patch generated 0 new + 193 unchanged - 1 fixed = 193 total (was 194)

+1 :green_heart:
mvnsite
1m 16s

the patch passed

+1 :green_heart:
javadoc
0m 56s

the patch passed with JDK Ubuntu-11.0.19+7-post-Ubuntu-0ubuntu120.04.1

+1 :green_heart:
javadoc
1m 26s

the patch passed with JDK Private Build-1.8.0_362-8u372-ga~us1-0ubuntu1~20.04-b09

+1 :green_heart:
spotbugs
3m 14s

the patch passed

+1 :green_heart:
shadedclient
35m 34s

patch has no errors when building and testing our client artifacts.

_ Other Tests _

-1 :x:
unit
254m 37s
/patch-unit-hadoop-hdfs-project_hadoop-hdfs.txt
hadoop-hdfs in the patch passed.

+1 :green_heart:
asflicense
0m 51s

The patch does not generate ASF License warnings.

395m 28s

Reason
Tests

Failed junit tests
hadoop.hdfs.TestRollingUpgrade

Subsystem
Report/Notes

Docker
ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5809/19/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/5809

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell detsecrets

uname
Linux 02221e1b504d 4.15.0-212-generic #223-Ubuntu SMP Tue May 23 13:09:22 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/bin/hadoop.sh

git revision
trunk / 73ec52bcdd27d295e3af34547245a50d285fad58

Default Java
Private Build-1.8.0_362-8u372-ga~us1-0ubuntu1~20.04-b09

Multi-JDK versions
/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.19+7-post-Ubuntu-0ubuntu120.04.1 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_362-8u372-ga~us1-0ubuntu1~20.04-b09

Test Results
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5809/19/testReport/

Max. process+thread count
3165 (vs. ulimit of 5500)

modules
C: hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project/hadoop-hdfs

Console output
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5809/19/console

versions
git=2.25.1 maven=3.6.3 spotbugs=4.2.2

Powered by
Apache Yetus 0.14.0 https://yetus.apache.org

This message was automatically generated.

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Logfile
Comment

+0 :ok:
reexec
0m 45s

Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s

No case conflicting files found.

+0 :ok:
codespell
0m  1s

codespell was not available.

+0 :ok:
detsecrets
0m  1s

detect-secrets was not available.

+1 :green_heart:
@author
0m  0s

The patch does not contain any @author tags.

+1 :green_heart:
test4tests
0m  0s

The patch appears to include 4 new or modified test files.

_ trunk Compile Tests _

+1 :green_heart:
mvninstall
55m 33s

trunk passed

+1 :green_heart:
compile
1m 21s

trunk passed with JDK Ubuntu-11.0.19+7-post-Ubuntu-0ubuntu120.04.1

+1 :green_heart:
compile
1m 21s

trunk passed with JDK Private Build-1.8.0_362-8u372-ga~us1-0ubuntu1~20.04-b09

+1 :green_heart:
checkstyle
1m 16s

trunk passed

+1 :green_heart:
mvnsite
1m 32s

trunk passed

+1 :green_heart:
javadoc
1m 12s

trunk passed with JDK Ubuntu-11.0.19+7-post-Ubuntu-0ubuntu120.04.1

+1 :green_heart:
javadoc
1m 39s

trunk passed with JDK Private Build-1.8.0_362-8u372-ga~us1-0ubuntu1~20.04-b09

+1 :green_heart:
spotbugs
3m 24s

trunk passed

+1 :green_heart:
shadedclient
37m 30s

branch has no errors when building and testing our client artifacts.

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
1m 17s

the patch passed

+1 :green_heart:
compile
1m 18s

the patch passed with JDK Ubuntu-11.0.19+7-post-Ubuntu-0ubuntu120.04.1

+1 :green_heart:
javac
1m 18s

the patch passed

+1 :green_heart:
compile
1m 11s

the patch passed with JDK Private Build-1.8.0_362-8u372-ga~us1-0ubuntu1~20.04-b09

+1 :green_heart:
javac
1m 11s

the patch passed

+1 :green_heart:
blanks
0m  0s

The patch has no blanks issues.

+1 :green_heart:
checkstyle
1m  9s

hadoop-hdfs-project/hadoop-hdfs: The patch generated 0 new + 200 unchanged - 1 fixed = 200 total (was 201)

+1 :green_heart:
mvnsite
1m 18s

the patch passed

+1 :green_heart:
javadoc
0m 55s

the patch passed with JDK Ubuntu-11.0.19+7-post-Ubuntu-0ubuntu120.04.1

+1 :green_heart:
javadoc
1m 30s

the patch passed with JDK Private Build-1.8.0_362-8u372-ga~us1-0ubuntu1~20.04-b09

+1 :green_heart:
spotbugs
3m 33s

the patch passed

+1 :green_heart:
shadedclient
37m  9s

patch has no errors when building and testing our client artifacts.

_ Other Tests _

+1 :green_heart:
unit
212m 49s

hadoop-hdfs in the patch passed.

+1 :green_heart:
asflicense
0m 55s

The patch does not generate ASF License warnings.

369m  0s

Subsystem
Report/Notes

Docker
ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5809/20/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/5809

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell detsecrets

uname
Linux 84d2bba733bf 4.15.0-212-generic #223-Ubuntu SMP Tue May 23 13:09:22 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/bin/hadoop.sh

git revision
trunk / b61bb60ae2b7f61106c08f2bdfd2c888b03f378f

Default Java
Private Build-1.8.0_362-8u372-ga~us1-0ubuntu1~20.04-b09

Multi-JDK versions
/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.19+7-post-Ubuntu-0ubuntu120.04.1 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_362-8u372-ga~us1-0ubuntu1~20.04-b09

Test Results
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5809/20/testReport/

Max. process+thread count
3076 (vs. ulimit of 5500)

modules
C: hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project/hadoop-hdfs

Console output
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5809/20/console

versions
git=2.25.1 maven=3.6.3 spotbugs=4.2.2

Powered by
Apache Yetus 0.14.0 https://yetus.apache.org

This message was automatically generated.

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Logfile
Comment

+0 :ok:
reexec
0m 43s

Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s

No case conflicting files found.

+0 :ok:
codespell
0m  0s

codespell was not available.

+0 :ok:
detsecrets
0m  0s

detect-secrets was not available.

+1 :green_heart:
@author
0m  0s

The patch does not contain any @author tags.

+1 :green_heart:
test4tests
0m  0s

The patch appears to include 4 new or modified test files.

_ trunk Compile Tests _

+1 :green_heart:
mvninstall
48m 12s

trunk passed

+1 :green_heart:
compile
1m 33s

trunk passed with JDK Ubuntu-11.0.19+7-post-Ubuntu-0ubuntu120.04.1

+1 :green_heart:
compile
1m 23s

trunk passed with JDK Private Build-1.8.0_362-8u372-ga~us1-0ubuntu1~20.04-b09

+1 :green_heart:
checkstyle
1m 15s

trunk passed

+1 :green_heart:
mvnsite
1m 29s

trunk passed

+1 :green_heart:
javadoc
1m 11s

trunk passed with JDK Ubuntu-11.0.19+7-post-Ubuntu-0ubuntu120.04.1

+1 :green_heart:
javadoc
1m 35s

trunk passed with JDK Private Build-1.8.0_362-8u372-ga~us1-0ubuntu1~20.04-b09

+1 :green_heart:
spotbugs
3m 29s

trunk passed

+1 :green_heart:
shadedclient
40m 14s

branch has no errors when building and testing our client artifacts.

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
1m 12s

the patch passed

+1 :green_heart:
compile
1m 16s

the patch passed with JDK Ubuntu-11.0.19+7-post-Ubuntu-0ubuntu120.04.1

+1 :green_heart:
javac
1m 16s

the patch passed

+1 :green_heart:
compile
1m  9s

the patch passed with JDK Private Build-1.8.0_362-8u372-ga~us1-0ubuntu1~20.04-b09

+1 :green_heart:
javac
1m  9s

the patch passed

+1 :green_heart:
blanks
0m  1s

The patch has no blanks issues.

+1 :green_heart:
checkstyle
1m  2s

hadoop-hdfs-project/hadoop-hdfs: The patch generated 0 new + 200 unchanged - 1 fixed = 200 total (was 201)

+1 :green_heart:
mvnsite
1m 18s

the patch passed

+1 :green_heart:
javadoc
0m 58s

the patch passed with JDK Ubuntu-11.0.19+7-post-Ubuntu-0ubuntu120.04.1

+1 :green_heart:
javadoc
1m 26s

the patch passed with JDK Private Build-1.8.0_362-8u372-ga~us1-0ubuntu1~20.04-b09

+1 :green_heart:
spotbugs
3m 21s

the patch passed

+1 :green_heart:
shadedclient
37m 29s

patch has no errors when building and testing our client artifacts.

_ Other Tests _

+1 :green_heart:
unit
216m 42s

hadoop-hdfs in the patch passed.

+1 :green_heart:
asflicense
0m 53s

The patch does not generate ASF License warnings.

367m 51s

Subsystem
Report/Notes

Docker
ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5809/22/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/5809

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell detsecrets

uname
Linux 9a563291821c 4.15.0-212-generic #223-Ubuntu SMP Tue May 23 13:09:22 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/bin/hadoop.sh

git revision
trunk / 2c497595ddac53325a67ed8db06e40085ea350d6

Default Java
Private Build-1.8.0_362-8u372-ga~us1-0ubuntu1~20.04-b09

Multi-JDK versions
/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.19+7-post-Ubuntu-0ubuntu120.04.1 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_362-8u372-ga~us1-0ubuntu1~20.04-b09

Test Results
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5809/22/testReport/

Max. process+thread count
3122 (vs. ulimit of 5500)

modules
C: hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project/hadoop-hdfs

Console output
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5809/22/console

versions
git=2.25.1 maven=3.6.3 spotbugs=4.2.2

Powered by
Apache Yetus 0.14.0 https://yetus.apache.org

This message was automatically generated.

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Logfile
Comment

+0 :ok:
reexec
0m 41s

Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s

No case conflicting files found.

+0 :ok:
codespell
0m  0s

codespell was not available.

+0 :ok:
detsecrets
0m  0s

detect-secrets was not available.

+1 :green_heart:
@author
0m  0s

The patch does not contain any @author tags.

+1 :green_heart:
test4tests
0m  0s

The patch appears to include 4 new or modified test files.

_ trunk Compile Tests _

+1 :green_heart:
mvninstall
46m 46s

trunk passed

+1 :green_heart:
compile
1m 34s

trunk passed with JDK Ubuntu-11.0.19+7-post-Ubuntu-0ubuntu120.04.1

+1 :green_heart:
compile
1m 19s

trunk passed with JDK Private Build-1.8.0_362-8u372-ga~us1-0ubuntu1~20.04-b09

+1 :green_heart:
checkstyle
1m 12s

trunk passed

+1 :green_heart:
mvnsite
1m 31s

trunk passed

+1 :green_heart:
javadoc
1m 15s

trunk passed with JDK Ubuntu-11.0.19+7-post-Ubuntu-0ubuntu120.04.1

+1 :green_heart:
javadoc
1m 43s

trunk passed with JDK Private Build-1.8.0_362-8u372-ga~us1-0ubuntu1~20.04-b09

+1 :green_heart:
spotbugs
3m 39s

trunk passed

+1 :green_heart:
shadedclient
42m 12s

branch has no errors when building and testing our client artifacts.

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
1m 25s

the patch passed

+1 :green_heart:
compile
1m 29s

the patch passed with JDK Ubuntu-11.0.19+7-post-Ubuntu-0ubuntu120.04.1

+1 :green_heart:
javac
1m 29s

the patch passed

+1 :green_heart:
compile
1m 23s

the patch passed with JDK Private Build-1.8.0_362-8u372-ga~us1-0ubuntu1~20.04-b09

+1 :green_heart:
javac
1m 23s

the patch passed

+1 :green_heart:
blanks
0m  0s

The patch has no blanks issues.

+1 :green_heart:
checkstyle
1m 11s

hadoop-hdfs-project/hadoop-hdfs: The patch generated 0 new + 200 unchanged - 1 fixed = 200 total (was 201)

+1 :green_heart:
mvnsite
1m 33s

the patch passed

+1 :green_heart:
javadoc
1m  5s

the patch passed with JDK Ubuntu-11.0.19+7-post-Ubuntu-0ubuntu120.04.1

+1 :green_heart:
javadoc
1m 36s

the patch passed with JDK Private Build-1.8.0_362-8u372-ga~us1-0ubuntu1~20.04-b09

+1 :green_heart:
spotbugs
3m 39s

the patch passed

+1 :green_heart:
shadedclient
41m 22s

patch has no errors when building and testing our client artifacts.

_ Other Tests _

+1 :green_heart:
unit
214m 52s

hadoop-hdfs in the patch passed.

+1 :green_heart:
asflicense
0m 58s

The patch does not generate ASF License warnings.

372m 16s

Subsystem
Report/Notes

Docker
ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5809/23/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/5809

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell detsecrets

uname
Linux bca59f26de4d 4.15.0-212-generic #223-Ubuntu SMP Tue May 23 13:09:22 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/bin/hadoop.sh

git revision
trunk / ccce291595efacd45f3967a19b68af10279fe8dc

Default Java
Private Build-1.8.0_362-8u372-ga~us1-0ubuntu1~20.04-b09

Multi-JDK versions
/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.19+7-post-Ubuntu-0ubuntu120.04.1 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_362-8u372-ga~us1-0ubuntu1~20.04-b09

Test Results
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5809/23/testReport/

Max. process+thread count
3427 (vs. ulimit of 5500)

modules
C: hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project/hadoop-hdfs

Console output
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5809/23/console

versions
git=2.25.1 maven=3.6.3 spotbugs=4.2.2

Powered by
Apache Yetus 0.14.0 https://yetus.apache.org

This message was automatically generated.

@Hexiaoqiao any further comments, planning to hold for you a couple of days


Feature suggestion: make it possible that the color picker can be zoomed in and out

Is your feature request related to a problem? Please describe.
I wanted the color picker to work when zoomed in (like 5 times). The issue with that is that I had to scale the color picker, making it smaller. This caused an issue, since the components are build at startup and getBoundingClientRect does not change dynamically.
Describe the solution you'd like
I want the color picker to function when you zoom in. I'm using a very minimal version of your color picker, so I hacked the following code together (but it might be broken with some other things that I don't use):
if (inst._recalc) {
  const zoom = document.documentElement.clientWidth / window.innerWidth;
  x = x * zoom;
  y = y * zoom;

  // Calculate saturation based on the position
  color.s = x * 100;

  // Calculate the value
  color.v = 100 - y * 100;

// Calculate hue
const zoom = document.documentElement.clientWidth / window.innerWidth;
if (inst._recalc) {
  color.h = v * zoom * 360;
}

const zoom = document.documentElement.clientWidth / window.innerWidth;
if (inst._recalc) {
  color.a = Math.round(v * zoom * 1e2) / 100;
}

Describe alternatives you've considered
I didn't consider any alternatives.
Additional context
I'm happy with my hack, but I just wanted to give you this as an idea.

Sorry, what do you mean if zoomed in? On both mobile and desktop it still works.
Do you mean the general layout (which could be changed with custom-css)?

Here is what I mean. The following gif is recorded on an ipad. When I zoom in, you get to see the color picker, because my hack is in place (see code above). If my hack wasn't in place, then I could not display my gif.
What you see is that the menu is constantly scaled down to the viewport. This means that I needed to scale down the color picker as well. When that happens, bugs started to appear.
Here's the video of it working (note: it wouldn't work without my applied hacky patch).

Closed due to inactivity.


Add a special release task to Procfile to run migrations before startup.

A task called release is treated differently from the rest. Both Heroku and dokku will run this just once before the container starts up.
See:

https://devcenter.heroku.com/articles/release-phase#specifying-release-phase-tasks
https://dokku.com/docs/advanced-usage/deployment-tasks/#procfile-release-command

Thanks!


Fixed logs and stats so they appear in applet instead of new tab

fixed the logs and stats page so it appears in the applet (with a back button going back to the page you were previously on) instead of in a new tab
you can call the logs from either the feedback page, or advanced settings page.

This change is

Looks really good! Only a few small things to fix. Great work!!!! :)

Review status: 0 of 6 files reviewed at latest revision, 7 unresolved discussions.

src/generic_ui/polymer/advanced-settings.html, line 138 [r3] (raw file):

    <core-signals on-core-signal-open-advanced-settings='{{ open }}'></core-signals>
    <uproxy-logs></uproxy-logs>

I think I'm missing something! Why are we adding logs to the advanced settings page?

src/generic_ui/polymer/feedback.ts, line 73 [r3] (raw file):

  },
  viewLogs: function() {
    //calls to logs.html to view logs

nit: can you add a space before calls?

src/generic_ui/polymer/logs.html, line 16 [r3] (raw file):

      #container {
        text-align: center;
        /*margin: 50px;*/

Can you remove this line if it's not needed? Thanks!

src/generic_ui/polymer/logs.html, line 22 [r3] (raw file):

      }
      #logsPanel {
      height: 100%;

Could you fix the indentation of the CSS so it's consistent?

src/generic_ui/polymer/logs.html, line 71 [r3] (raw file):

      <uproxy-app-bar on-go-back='{{ close }}'>
            {{ "LOGS_TITLE" | $$ }}

nit: could you also fix the indentation of this line and the line below?

src/generic_ui/polymer/logs.ts, line 30 [r3] (raw file):

  },
  openLogs: function() {
    //opens the logsPanel, which contains the logs

nit: space before "opens"

src/generic_ui/polymer/logs.ts, line 34 [r3] (raw file):

  },
  close: function() {
    //closes the logsPanel

nit: space before "closes"

Comments from Reviewable

Review status: 0 of 6 files reviewed at latest revision, 7 unresolved discussions.

src/generic_ui/polymer/advanced-settings.html, line 138 [r3] (raw file):
Previously, lucyhe wrote…
> I think I'm missing something! Why are we adding logs to the advanced settings page?

In advanced settings, there is a button called "analyze NAT" that previously also opened Logs in a new tab. We fixed it so that it opened in the applet itself, but only because it was opening in a new tab before that. If that's not what "analyze NAT" is supposed to do, we can get rid of that!

src/generic_ui/polymer/feedback.ts, line 73 [r3] (raw file):
Previously, lucyhe wrote…
> nit: can you add a space before calls?

Done.

src/generic_ui/polymer/logs.html, line 16 [r3] (raw file):
Previously, lucyhe wrote…
> Can you remove this line if it's not needed? Thanks!

Done.

src/generic_ui/polymer/logs.html, line 22 [r3] (raw file):
Previously, lucyhe wrote…
> Could you fix the indentation of the CSS so it's consistent?

Done.

src/generic_ui/polymer/logs.html, line 71 [r3] (raw file):
Previously, lucyhe wrote…
> nit: could you also fix the indentation of this line and the line below?

Done.

src/generic_ui/polymer/logs.ts, line 30 [r3] (raw file):
Previously, lucyhe wrote…
> nit: space before "opens"

Done.

src/generic_ui/polymer/logs.ts, line 34 [r3] (raw file):
Previously, lucyhe wrote…
> nit: space before "closes"

Done.

Comments from Reviewable

Ah, sorry, didn't notice this.  Jumping in now (sorry about some of the additional nits)

Reviewed 2 of 6 files at r3, 3 of 3 files at r4.
Review status: 5 of 6 files reviewed at latest revision, 9 unresolved discussions.

src/generic_ui/polymer/advanced-settings.html, line 138 [r3] (raw file):
Previously, shilpa10kumar9 wrote…
> In advanced settings, there is a button called "analyze NAT" that previously also opened Logs in a new tab. We fixed it so that it opened in the applet itself, but only because it was opening in a new tab before that. If that's not what "analyze NAT" is supposed to do, we can get rid of that!

So, the issue you're running into here is that, when you [fire the signal to open logs](https://github.com/uProxy/uproxy/blob/shilpakumar-feedback-stats/src/generic_ui/polymer/advanced-settings.ts#L72), it is [received by every instance of `uproxy-logs`](https://github.com/uProxy/uproxy/blob/shilpakumar-feedback-stats/src/generic_ui/polymer/logs.html#L66).  Since two of these elements exist, the logs page opens twice.  You can notice this by how you have to click the [back button](https://github.com/uProxy/uproxy/blob/shilpakumar-feedback-stats/src/generic_ui/polymer/logs.ts#L35) twice to actually get out of the logs page.
For the sake of convention, it would be better to have the element instantiated solely in root.html
Some examples of other elements like this:

uproxy-invite-user
uproxy-advanced-settings
Everything between those two lines :)

src/generic_ui/polymer/logs.html, line 66 [r4] (raw file):

      }
    </style>
    <core-signals on-core-signal-open-logs="{{ openLogs }}"></core-signals>

The indentation for all the lines in this file are a bit off.  In general, you want to increase indentation by one level when you open a tag or by two levels when you're doing something inside the tag.  Example below, let me know if that does not make sense to you.

    Text

    fooText

src/generic_ui/polymer/logs.ts, line 30 [r4] (raw file):

  },
  openLogs: function() {
    // opens the logsPanel, which contains the logs

(do not feel the need to change anything based on this comment, just click acknowledged): Just for future reference, comments like this where what they say should be able to be inferred from the function name and a line or two of code aren't always the most useful thing.  A good goal is to write code that does not require commenting to understand it and I think you did a good job of that here.

Comments from Reviewable

Review status: 3 of 7 files reviewed at latest revision, 9 unresolved discussions.

src/generic_ui/polymer/advanced-settings.html, line 138 [r3] (raw file):
Previously, jpevarnek (Jonathan Pevarnek) wrote…
> So, the issue you're running into here is that, when you [fire the signal to open logs](https://github.com/uProxy/uproxy/blob/shilpakumar-feedback-stats/src/generic_ui/polymer/advanced-settings.ts#L72), it is [received by every instance of `uproxy-logs`](https://github.com/uProxy/uproxy/blob/shilpakumar-feedback-stats/src/generic_ui/polymer/logs.html#L66).  Since two of these elements exist, the logs page opens twice.  You can notice this by how you have to click the [back button](https://github.com/uProxy/uproxy/blob/shilpakumar-feedback-stats/src/generic_ui/polymer/logs.ts#L35) twice to actually get out of the logs page.
>
> For the sake of convention, it would be better to have the element instantiated solely in `root.html`
>
> Some examples of other elements like this:
> * [`uproxy-invite-user`](https://github.com/uProxy/uproxy/blob/shilpakumar-feedback-stats/src/generic_ui/polymer/root.html#L301)
> * [`uproxy-advanced-settings`](https://github.com/uProxy/uproxy/blob/shilpakumar-feedback-stats/src/generic_ui/polymer/root.html#L305)
> * Everything between those two lines :)

Done.

src/generic_ui/polymer/logs.html, line 66 [r4] (raw file):
Previously, jpevarnek (Jonathan Pevarnek) wrote…
> The indentation for all the lines in this file are a bit off.  In general, you want to increase indentation by one level when you open a tag or by two levels when you're doing something inside the tag.  Example below, let me know if that does not make sense to you.
> ```
>
>
>     Text
>
>          class="foo">
>     fooText
>
>
> ```

I am not entirely sure I fixed it correctly, but I tried! Let me know if I did something wrong (which is def possible!)

Comments from Reviewable

Reviewed 4 of 4 files at r5.
Review status: all files reviewed at latest revision, 16 unresolved discussions.

src/generic_ui/polymer/feedback.html, line 11 [r5] (raw file):

<link rel='import' href='faq-link.html'>
<link rel='import' href='dialog.html'>
<link rel='import' href='logs.html'>

You can remove this now

src/generic_ui/polymer/feedback.html, line 150 [r5] (raw file):

    <core-signals on-core-signal-open-feedback="{{ open }}"></core-signals>

Remove comment please.

src/generic_ui/polymer/logs.html, line 70 [r5] (raw file):

        <uproxy-app-bar on-go-back='{{ close }}'>
            {{ "LOGS_TITLE" | $$ }}

This is indented two spaces too far

src/generic_ui/polymer/logs.html, line 73 [r5] (raw file):

        </uproxy-app-bar>

<bdi>
            {{ "LOGS_TITLE" | $$ }}

These were good the way you had them before (one-line)

src/generic_ui/polymer/logs.html, line 81 [r5] (raw file):

                {{ "RETRIEVING_LOGS" | $$ }}

Again, fine the way it was

src/generic_ui/polymer/logs.html, line 86 [r5] (raw file):

              {{ logs }}

Again, fine the way it was

src/generic_ui/polymer/root.html, line 301 [r5] (raw file):

    <uproxy-invite-user></uproxy-invite-user>
    <uproxy-google-invite></uproxy-google-invite>
    <uproxy-logs></uproxy-logs>

Should add the <link to the top of this file

Comments from Reviewable

Review status: 5 of 7 files reviewed at latest revision, 16 unresolved discussions.

src/generic_ui/polymer/feedback.html, line 11 [r5] (raw file):
Previously, jpevarnek (Jonathan Pevarnek) wrote…
> You can remove this now

Done.

src/generic_ui/polymer/feedback.html, line 150 [r5] (raw file):
Previously, jpevarnek (Jonathan Pevarnek) wrote…
> Remove comment please.

Done.

src/generic_ui/polymer/logs.html, line 70 [r5] (raw file):
Previously, jpevarnek (Jonathan Pevarnek) wrote…
> This is indented two spaces too far

Done.

src/generic_ui/polymer/logs.html, line 73 [r5] (raw file):
Previously, jpevarnek (Jonathan Pevarnek) wrote…
> These were good the way you had them before (one-line)

Done.

src/generic_ui/polymer/logs.html, line 81 [r5] (raw file):
Previously, jpevarnek (Jonathan Pevarnek) wrote…
> Again, fine the way it was

Done.

src/generic_ui/polymer/logs.html, line 86 [r5] (raw file):
Previously, jpevarnek (Jonathan Pevarnek) wrote…
> Again, fine the way it was

Done.

src/generic_ui/polymer/root.html, line 301 [r5] (raw file):
Previously, jpevarnek (Jonathan Pevarnek) wrote…
> Should add the `
Done.

Comments from Reviewable

:thumbsup:

Reviewed 2 of 2 files at r6.
Review status: all files reviewed at latest revision, 10 unresolved discussions, some commit checks broke.

src/generic_ui/polymer/logs.html, line 72 [r6] (raw file):

          {{ "LOGS_TITLE" | $$ }}
        </uproxy-app-bar>

<bdi> {{ "LOGS_TITLE" | $$ }} </bdi>

Final nit: this should be
<bdi>{{ "LOGS_TITLE" | $$ }}</bdi>

Similar change to the other lines.

Comments from Reviewable

(btw, me giving a thumbsup with a pending comment should be interpreted as "please fix the issue, but then feel free to merge without checking back with me")

Review status: all files reviewed at latest revision, 10 unresolved discussions, some commit checks broke.

Comments from Reviewable

Review status: 6 of 7 files reviewed at latest revision, 10 unresolved discussions, some commit checks pending.

src/generic_ui/polymer/logs.html, line 72 [r6] (raw file):
Previously, jpevarnek (Jonathan Pevarnek) wrote…
> Final nit: this should be `{{ "LOGS_TITLE" | $$ }}`
>
> Similar change to the other lines.

Done.

Comments from Reviewable