Problem with SequenceAdder and reverb adders test_utils

Hi there,
first of all thank you very much for sharing such a flexible and modular library for RL, it's really an excellent base for new projects and thus highly appreciated!
I've noticed a problem/possible bug with regard to the padding in SequenceAdder, which extends to the reverb adder package's test_utils.py: It seems to me that the padding in SequenceAdder actually does not happen. The problem is in this line:
padding = self._period - (self._step - self._max_sequence_length)

As soon as self._step >= self._max_sequence_length + self._period (which will eventually happen in most use-cases), padding becomes negative (or 0, in case of >=). As a result, the for loop in these lines
for _ in range(padding):
  self._buffer.append(zero_step)
  self._writer.append(zero_step)
  self._step += 1

is never entered, since range(x) returns an empty sequence for x <= 0.
Effectively, this results in SequenceAdder discarding any experience that should normally be padded, since self._step was never incremented in the for loop mentioned above and thus, calling self._maybe_add_priorities() in this line never actually results in creating an item in the reverb table.
The problem can be fixed by changing this line:
padding = self._period - (self._step - self._max_sequence_length)

to
padding = 0
if (self._step - self._max_sequence_length) % self._period != 0:
  padding = self._period - ((self._step - self._max_sequence_length) % self._period)

The reason the problem doesnt' pop up in the tests for SequenceAdder lies in adders/reverb/test_utils.py, in these lines:
observed_items = [p[1] for p in self.client.writers[0].priorities]
for expected_item, observed_item in zip(expected_items, observed_items):
  tree.map_structure(
      np.testing.assert_array_almost_equal,
      expected_item,
      observed_item,
      check_types=False)

When zip() encounters sequences of different length, it will zip according to the length of the sequence with the smaller length.
Therefore, whenever there are less observed_items than expected_items, test cases will pass even though they should fail.
This can be fixed by checking that there are as many observed items as expected items:
self.assertEqual(len(observed_items), len(expected_items))
for expected_item, observed_item in zip(expected_items, observed_items):
  ...

As a result of applying this fix to test_utils, the EarlyTerminationNoPadding test case in sequence_test will fail. In this testacse, pad_end_of_episode = False, and the testcase expects a non-padded, unfinished sequence. However, applying the padding fix  in SequenceAdder as mentioned above will still have the result of discarding unfinished sequences when pad_end_of_episode = False. So if the expected behaviour of SequenceAdder should be to write unfinished sequences when pad_end_of_episode = False, my fix mentioned above will not achieve this (although it could be implemented easily, e.g. by passing an argument to self._maybe_add_priorities() that indicates whether an unfinished sequence should be written to the buffer). On the other hand, if the fix suggested above is the behaviour you intended, this test case should expect an empty sequence.
I have implemented these suggested changes in my fork of acme. With regard to the EarlyTerminationNoPadding test case, I have assumed that an empty sequence should be the expected behaviour and have modified the test case accordingly. I have also tested all other tests in reverb/adders after adding the suggested change to test_utils.py and they all pass (after making the suggested changes to sequence_test.py).
If you want, I'm happy to issue a pull request.
Best regards.

Hi @RaoulDrake thanks for filing this issue and for the detailed writeup! Was this fixed by 67d320ff678bddcab2571dbd126a59b8b4ae8606?

I'm closing the issue as it seems stale. Please re-submit if you have further questions.


Installed the updated IOTA Firefly, which is linked to my Ledger Plus device, The Iota update app will not generate my account from the old app, I can't log into my account.

Task description
Installed the new updated IOTA Firefly, which is linked to my Ledger Plus device, The Iota update app will not generate my account from the old app, I can't log into my account.  App Name: Firefly
Please NOTE diagnostics Version 2.0.8
Language: en
Platform: win32
Platform Version: 10.0.22621
Platform Architecture: x64
CPU Count: 16
Total Memory: 15711.3 MB
Free Memory: 10978.5 MB

Did you update your iota ledger app? It has to be on the latest version 0.8.6 to work, if you cant see that version in ledger live you must update your ledger firmware first

I am also having the same issue, Ledger nano S , already have the latest firmware 2.1.
Both Firefly IOTA and Firelfy shimmer are showing the same error codes:
Fri, 08 Mar 2024 16:42:44 GMT wallet: local time<PHONE_NUMBER> doesn't match the time of the latest milestone timestamp:<PHONE_NUMBER>`
Fri, 08 Mar 2024 16:42:28 GMT
wallet: local time<PHONE_NUMBER> doesn't match the time of the latest milestone timestamp:<PHONE_NUMBER>
Fri, 08 Mar 2024 16:42:10 GMT
wallet: local time<PHONE_NUMBER> doesn't match the time of the latest milestone timestamp:<PHONE_NUMBER>
Fri, 08 Mar 2024 16:42:01 GMT
wallet: local time<PHONE_NUMBER> doesn't match the time of the latest milestone timestamp:<PHONE_NUMBER>
Fri, 08 Mar 2024 16:40:25 GMT
Generic: local time<PHONE_NUMBER> doesn't match the time of the latest milestone timestamp:<PHONE_NUMBER>
Fri, 08 Mar 2024 16:40:03 GMT
Generic: local time<PHONE_NUMBER> doesn't match the time of the latest milestone timestamp:<PHONE_NUMBER>
Fri, 08 Mar 2024 16:39:34 GMT
Generic: local time<PHONE_NUMBER> doesn't match the time of the latest milestone timestamp:<PHONE_NUMBER>
`
This was not an issue in the previous updates. tried going back a version (were IOTA NFTs were still visible), still could not access my account.
right after the log in password is correctly written, the wallet starts loading and right before the end of the loading, this error pops up

local time (numbers) doesn't match the time of the latest milestone timestamp: (numbers)

Please help!

The error is suggesting that your machine's clock is not in sync, just sync your clock or set it to automatic and it should work

Hello Begona,
Thank you for your reply.
It seems that this Error happens when the Ledger is connected before logging in Firefly account.
I can now access my account.
Thank you once again!


[🐛] IOS launchCamera not work

Description
launchCamera is not working on ios.
call function and nothing happened
No errors, nothing appear
How to repeat issue and example
launchCamera({
      mediaType: 'photo',
      quality: 0.7,
      maxWidth: 1920,
      maxHeight: 1080,
      cameraType: 'back',
      saveToPhotos: true
    })
      .then(response => {
        if (response.assets) {
          let formData = new FormData();
          response.assets.forEach(file => {
            const uri =
              Platform.OS === 'ios'
                ? file?.uri?.replace(/file:\/\//g, '')
                : file?.uri;
            formData.append('files', {
              name: file.fileName,
              type: file.type,
              uri: uri,
            });
          });
          uploadMutation.mutate(formData, {
            onSuccess: data => {
              room.sendFiles(data.map(v => v.url));
            },
          });
        }
      })
      .catch(e => console.warn(e));

Solution
.
Additional Information
{
  "name": "welinkor",
  "version": "0.0.1",
  "private": true,
  "scripts": {
    "android": "react-native run-android",
    "ios": "react-native run-ios",
    "lint": "eslint .",
    "start": "react-native start",
    "test": "jest",
    "pod": "npx pod-install ios",
    "postinstall": "patch-package"
  },
  "dependencies": {
    "@flyerhq/react-native-link-preview": "^1.6.0",
    "@react-native-async-storage/async-storage": "^1.17.12",
    "@react-native-community/push-notification-ios": "^1.11.0",
    "@react-native-firebase/app": "^17.4.2",
    "@react-native-firebase/messaging": "^17.4.2",
    "@react-navigation/material-top-tabs": "^6.6.2",
    "@react-navigation/native": "^6.1.6",
    "@react-navigation/native-stack": "^6.9.12",
    "@sendbird/chat": "^4.6.1",
    "@tanstack/react-query": "^4.28.0",
    "@types/lodash": "^4.14.192",
    "@types/qs": "^6.9.7",
    "@types/react-native-snap-carousel": "^3.8.5",
    "@types/react-native-vector-icons": "^6.4.13",
    "@types/react-native-video": "^5.0.14",
    "axios": "^1.3.4",
    "lodash": "^4.17.21",
    "moment": "^2.29.4",
    "moment-timezone": "^0.5.42",
    "native-base": "^3.4.28",
    "patch-package": "^6.5.1",
    "postinstall-postinstall": "^2.1.0",
    "qs": "^6.11.1",
    "react": "18.2.0",
    "react-hook-form": "^7.43.8",
    "react-native": "0.71.4",
    "react-native-channel-plugin": "^0.7.11",
    "react-native-collapsible-tab-view": "^6.0.0-rc.0",
    "react-native-datepicker": "^1.7.2",
    "react-native-dropdown-picker": "^5.4.6",
    "react-native-fast-image": "^8.6.3",
    "react-native-gesture-handler": "^2.9.0",
    "react-native-image-picker": "^5.3.1",
    "react-native-image-viewing": "^0.2.2",
    "react-native-linear-gradient": "^2.6.2",
    "react-native-pager-view": "^5.4.25",
    "react-native-push-notification": "^8.1.1",
    "react-native-reanimated": "^3.0.2",
    "react-native-safe-area-context": "^3.3.2",
    "react-native-safearea-height": "^1.0.6",
    "react-native-screens": "^3.20.0",
    "react-native-snap-carousel": "^3.9.1",
    "react-native-svg": "^12.1.1",
    "react-native-tab-view": "^3.5.1",
    "react-native-uuid": "^2.0.1",
    "react-native-vector-icons": "^9.2.0",
    "react-native-video": "^6.0.0-alpha.5",
    "react-native-view-more-text": "^2.2.0",
    "recoil": "^0.7.7"
  },
  "devDependencies": {
    "@babel/core": "^7.20.0",
    "@babel/preset-env": "^7.20.0",
    "@babel/runtime": "^7.20.0",
    "@react-native-community/eslint-config": "^3.2.0",
    "@tsconfig/react-native": "^2.0.3",
    "@types/jest": "^29.2.1",
    "@types/react": "^18.0.24",
    "@types/react-native-datepicker": "^1.7.1",
    "@types/react-native-vector-icons": "^6.4.13",
    "@types/react-test-renderer": "^18.0.0",
    "babel-jest": "^29.2.1",
    "eslint": "^8.19.0",
    "jest": "^29.2.1",
    "metro-react-native-babel-preset": "0.73.8",
    "prettier": "^2.4.1",
    "react-native-dotenv": "^3.4.8",
    "react-test-renderer": "18.2.0",
    "typescript": "4.8.4"
  },
  "jest": {
    "preset": "react-native"
  }
}

I have the same issue

check your Info.plist and add the permissions on xcode if you did not add them

I forgot to mention that it is not working with "pod install". W/o new architecture flag

I add plist, requesting permission even pod install without new arch tag
Noting work for me

iPhone14
iOS 16.3.1
ImagePicker.launchCamera  then crash
iPhone 11
iOS 16.0.3
&
iPhone XR
iOS 16.4.1
Both are working, only first crash, Idk why.

Oh so it's a known issue?

if you are opening any modal and then calling video function, need to close video modal first and then you can call ImagePicker.launchCamera.

iPhone14 iOS 16.3.1 ImagePicker.launchCamera  then crash
iPhone 11 iOS 16.0.3 & iPhone XR iOS 16.4.1
Both are working, only first crash, Idk why.

Recently version , I updated and  worked it.

Same issue


the version

I use the keras version 1.1.1 and tensorflow 0.10 is not fit to your new updated program, there is a problem:raise TypeError("List of Tensors when single Tensor expected") TypeError: List of Tensors when single Tensor expected.

Thanks for the feedback! Do you have a detailed error message? And actually I was testing on the latest tensorflow (0.11).

the detail error:
Traceback (most recent call last):
 File "src/launcher.py", line 136, in <module>
  main(sys.argv[1:], exp_config.ExpConfig)
 File "src/launcher.py", line 132, in main
  session = sess)
 File "/home/yanghang/Attention-OCR/src/model/model.py", line 167, in __init__
  self.keras_updates.append(tf.assign(old_value, new_value))
  File "~/anaconda2/lib/python2.7/site-packages/tensorflow/python       /ops/gen_state_ops.py", line 45, in assign
use_locking=use_locking, name=name)
 File "~/anaconda2/lib/python2.7/site-packages/tensorflow/python/framework/op_def_library.py", line 454, in apply_op
as_ref=input_arg.is_ref)
 File "~/anaconda2/lib/python2.7/site-packages/tensorflow/python/framework/ops.py", line 621, in convert_to_tensor
  ret = conversion_func(value, dtype=dtype, name=name, as_ref=as_ref)
 File "~/anaconda2/lib/python2.7/site-packages/tensorflow/python/framework/constant_op.py", line 180, in _constant_tensor_conversion_function
return constant(v, dtype=dtype, name=name)
File "~/anaconda2/lib/python2.7/site-packages/tensorflow/python/framework/constant_op.py", line 163, in constant
tensor_util.make_tensor_proto(value, dtype=dtype, shape=shape))
File "~/anaconda2/lib/python2.7/site-packages/tensorflow/python/framework/tensor_util.py", line 353, in make_tensor_proto
_AssertCompatible(values, dtype)
File "~/anaconda2/lib/python2.7/site-packages/tensorflow/python/framework/tensor_util.py", line 287, in _AssertCompatible
raise TypeError("List of Tensors when single Tensor expected")
TypeError: List of Tensors when single Tensor expected.

I hope this can help you!

I doubt whether is tensorflow's version problem, i don't want to upgrade tensorflow version to 11 now.

I used the keras version 1.0.4 and tensorflow 0.10, I run the old code(before you updated the code) and restart to train my data , but encountered a problem:
Traceback (most recent call last):   File "src/launcher.py", line 129, in <module>     main(sys.argv[1:], exp_config.ExpConfig)   File "src/launcher.py", line 126, in main     model.launch()   File "~/anaconda2/Attention-OCR-master/src/model/model.py", line 279, in launch     _, step_loss, step_logits, _ = self.step(encoder_masks, img_data, zero_paddings, decoder_inputs, target_weights, bucket_id, self.forward_only) UnboundLocalError: local variable 'img_data' referenced before assignment


graphql fix

I want to merge this change because...
my changes to app.json enable graphql to run on heroku,

Screenshots

Pull Request Checklist

[x] All visible strings are translated with proper context.
[x] All data-formatting is locale-aware (dates, numbers, and so on).
[x] The changes are tested.
[x] The code is documented (docstrings, project documentation).
[x] Changes are mentioned in the changelog.

my approach is documented in the issue comments


Support for adding templates in React

While using workflow-creator, I want to configure workflow so that if task is added, default startDate should be added by workflow.
When date is selected in workflow-creator, Input field is not appearing, while checking in angular(rakuten) code. A template map is passed to render particular template for particular cases which is date in this case.
I want to do the same with React, but I'm not able to figure out, how to render in React as there's no concept to templates in React or Vanilla JS

https://github.com/sourcefuse/rakuten-pms-ui/blob/ea085145934d14b65f7c03189c7d9d41d76f6cd1/src/app/main/workspace/main-view/main-board/components/workflows-dialog/workflow-editor-dialog/workflow-editor-dialog.component.ts#L182
Here it is configured in rakuten pms. @arpit1503khanna

Currently @arpit1503khanna added default date picker and current one is working.
But I believe we will be getting requirement to customise the input fields(text, date etc..)
So, it will be nice if there could be anyway to customise input elements in React, just like we do it angular with ng-templates.

Also referencing to this issue
https://github.com/sourcefuse/workflows-creator/issues/24

Hi @yeshamavani
This issue is not fixed yet


Update backend theme to Bootstrap 4.1 (or newer)

Currently the backend theme "Neoflow Backend" is using Bootstrap 4.0.0.
https://blog.getbootstrap.com/2018/04/09/bootstrap-4-1/

Fixed with latest commit 021bbf4


made get_lexer_list.py run under Python 2.6

filebin does not require a specific Python version, it only requires pygmentize.
pygmentize requires Python 2.6, so filebin should not use Python 2.7 features
in its scripts.

Please change the commit subject to me more in line with the other commits. I'd use "get_lexer_list.py: Support python 2.6". Especially please don't use past tense (it's longer and doesn't follow the messages generated by git-revert, git-merge).
Apart from that I'll merge it.

No reply


⚠ Secret Website 1 has degraded performance

In cb9764b, Secret Website 1 ($SECRET_WEBSITE_1) experienced degraded performance:

HTTP code: 200
Response time: 4124 ms

Resolved: Secret Website 1 performance has improved in eb5edbd.


script to get updated ship_traffic from MarineCadastre?

@jlstevens, I imagine there is a python script somewhere to download data from
https://marinecadastre.gov/ais/
and convert to the proper format for ingesting into the ship_track demo notebook?

It's been a while but I am fairly sure the data was already preprocessed by a third party: I don't ever remember running a script and I seem to remember having the data available from the very start of the project (unfortunately, I don't remember where from exactly!)
That said, the data isn't particularly hard to understand so I'm sure it wouldn't be too hard to write such a script.
Is there any particular reason you are trying to learn about how that data was generated?

Ah, and I see that issue mentions some of those details about where the data comes from that I had forgotten!

Hmm, actually that thread is just concerned with reading the already-existing parquet data files directly from cloud object storage rather than downloading them.  Still a mystery how the original data files were produced.   Which is a pity, since there is no data in those existing files from the Med.   :(


fix(react): CompositePanel type error

Before submitting a pull request, please make sure the following is done...

[x] Ensure the pull request title and commit message follow the Commit Specific in English.
[x] Fork the repo and create your branch from main.
[x] If you've added code that should be tested, add tests!
[x] If you've changed APIs, update the documentation.
[x] Ensure the test suite passes (npm test).
[x] Make sure your code lints (npm run lint) - we've done our best to make sure these rules match our internal linting guidelines.

使用 CompositePanel 会报这个错，因为Item 被标记了可选 Item?
参考 Ant.Design / Layout 修改了类型写法

感觉 commitlint 的规则不太合理。


Update Governor.sol: Fixed Errors and optimized code

Issues:

If you notice at line 569 and 1034 within this smart contract, there's a variable 'x' which overshadows a state variable (x) within the function. This creates a faulty smart contract.

Optimizations:
Some gas optimizations are made which can be referred below:

Struct Packing at line 67 onwards. Refer this -> https://gist.github.com/grGred/9bab8b9bad0cd42fc23d4e31e7347144#pack-structs-in-solidity
#8
Optimized 'For' Loops -> https://gist.github.com/grGred/9bab8b9bad0cd42fc23d4e31e7347144#for-loops-improvement

Thanks!

Sure @Aryan9592 , I will review it.

Reviewed!


Update scalafmt-core to 3.4.2

Updates org.scalameta:scalafmt-core from 3.4.1 to 3.4.2.
GitHub Release Notes - Version Diff
I'll automatically update this PR to resolve conflicts as long as you don't change it yourself.
If you'd like to skip this version, you can just close this PR. If you have any feedback, just mention me in the comments below.
Configure Scala Steward for your repository with a .scala-steward.conf file.
Have a fantastic day writing Scala!

Ignore future updates
Add this to your .scala-steward.conf file to ignore future updates of this dependency:
updates.ignore = [ { groupId = "org.scalameta", artifactId = "scalafmt-core" } ]

labels: library-update, early-semver-patch, semver-spec-patch, commit-count:1

Codecov Report

Merging #370 (1e775dc) into main (eec29a4) will decrease coverage by 0.08%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main     #370      +/-   ##
==========================================
- Coverage   96.63%   96.54%   -0.09%
==========================================
  Files           9        9
  Lines        1130     1130
  Branches      111      111
==========================================
- Hits         1092     1091       -1
- Misses         38       39       +1

Impacted Files
Coverage Δ

core/shared/src/main/scala/cats/parse/Parser.scala
96.59% <0.00%> (-0.11%)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update eec29a4...1e775dc. Read the comment docs.


Don't Merge! PR real time test for webhook case

Docs Build status updates of commit 7ae88e5:
:clock10: Pending: waiting for processors (17 builds ahead of you)
:warning: Docs Build is busy, currently there are 17 builds ahead of this one, for more information you can view the Build queue graph on the Docs Portal.

Docs Build status updates of commit 7ae88e5:
:clock10: Full build: the average full build time is 7 min(s) 20 sec(s), this is based on the last 30 build(s) for this repository.

Docs Build status updates of commit 7ae88e5:
:warning: Validation status: warnings

File
Status
Preview URL
Details

docs-ref-conceptual/testing.md
:warning:Warning
View (azure-cli-latest) View (azure-cli-2017-03-09-profile) View (azure-cli-2018-03-01-hybrid)
Details

docs-ref-conceptual/testing.md

[Warning] Missing attribute: either ms.prod or ms.service is required. Use ms.prod for on-premise products, or ms.service for cloud services.
[Warning] Missing attribute: title.
[Warning] Missing attribute: either ms.prod or ms.service is required. Use ms.prod for on-premise products, or ms.service for cloud services.
[Warning] Missing attribute: title.
[Warning] Missing attribute: either ms.prod or ms.service is required. Use ms.prod for on-premise products, or ms.service for cloud services.
[Warning] Missing attribute: title.

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.


New version: Bitwarden.Bitwarden version 2024.10.2

Pull request has been created with komac v2.6.0 :rocket:
Microsoft Reviewers: Open in CodeFlow

@wingetbot run

@wingetbot run


[FEATURE] Ability to rename feeds

Sometimes feed names carry some cruft that users might want to hide away or, for whatever reason, users might simply want to rename feeds to display as something else.
So I propose adding on to feed definitions with a name attribute, for example:
(setq elfeed-feeds
  '(("https://news.ycombinator.com/rss" software news
       :name "My Own Name For Hacker News")))

I like this idea. I need to think about how exactly I'd want it to work. Elfeed already supports arbitrary metadata, originally added in case anyone needed it for extensions, through the setf-able elfeed-meta function. It all persists in the database automatically. Each entry and feed object has a plist attached. Some keys could be treated as special by Elfeed, like :title metadata that overrides the feed or entry's actual title when being displayed.
(setf my-feed (elfeed-db-get-feed "http://example.com/feed/"))
(setf (elfeed-meta my-feed :title) "My Custom Title")
(elfeed-meta my-feed :title)
;; => "My Custom Title"

Currently there's no configuration mechanism for this, like in your example. Individual entries wouldn't make sense to configure in an init file, but feeds should be configurable at a high level.

Forgot to reference this issue from the commit, but bd2d99e makes Elfeed use the :title metadata for both entries and feeds when available. The only thing missing is a nice configuration interface. Right now you can achieve it via a setf call in your config.

My current setup. Just for info.

(defvar *feeds* '(("http://nullprogram.com/feed/" :tags (comp emacs) :title "Elfeed")))

(defvar *urls-titles* nil
  "URL-title list for feeds titles fixing.")

(defun elfeed/feeds-prepair (feeds)
  "Populate main `elfeed-feeds' list and aux `*urls-titles*' one."
  (setq elfeed-feeds)
  (mapc (lambda (feed)
		  (if (listp feed)
			  (let* ((url (first feed))
					 (meta (rest feed))
					 (tags (plist-get meta ':tags))
					 (title (plist-get meta ':title)))
				(cond ((null tags) (push url elfeed-feeds))
					  ((atom tags) (push (list url tags) elfeed-feeds))
					  (t (push (push url tags) elfeed-feeds)))
				(when title
				  (push (list url title) *urls-titles*)))
			(push feed elfeed-feeds)))
		feeds))

(defun elfeed/feeds-titles-fix (old-fun &rest args)
  "Advice titles fixing."
  (mapc (lambda (lst)
		  (let* ((url (first lst))
				 (title (second lst))
				 (feed (elfeed-db-get-feed url)))
			(setf (elfeed-feed-title feed) title)))
		*urls-titles*)
  (apply old-fun args))

(advice-add #'elfeed-search-update :around #'elfeed/feeds-titles-fix)

+10
It would be a very good functionality

+10
It would be a very good functionality

Closing since this was added in bd2d99e.


No directory "hibernate" in linux-surface

In setup.sh, "Copy config files from Jakeday's kernel to root?" and answering with "Y" errors with:
cp: cannot stat '.cache/linux-surface/root/lib/systemd/system-sleep/hibernate': No such file or directory
Making /lib/systemd/system-sleep/hibernate executable...
chmod: cannot access '/lib/systemd/system-sleep/hibernate': No such file or directory

Upon checking the linux-surface repo, there is no sub-directory in /lib/systemd/system-sleep/, only a file linux-surface/root/lib/systemd/system-sleep/sleep

Thanks for bringing this to my attention. It looks like jakeday swapped it out for the sleep executable. I've updated the setup script to reflect this.


Junk Indicator

Addon Version
v0.1.7
World of Warcraft Version
Retail
Describe the bug
When opening a vendor to sell with, the gold icon to indicate that an item is considered junk does not appear until manually triggering a bag redraw by buying/selling/equipping an item.

After closing the vendor window, the gold icon stays on the junk items until another redraw is triggered.
Default Blizzard bag behaviour has the gold icon shown only when the vendor's inventory is open.
Steps to reproduce
Speak with a vendor. No gold icon will appear on junk items.
Force a manual bag redraw. Gold icon will appear on junk items.
Close vendor inventory. Gold icon will stay on junk items.
Force a bag redraw. Gold icon will disappear.

This was fixed at some point.


Use ascii based map for captains locations

https://github.com/yaronn/blessed-contrib#map
Best of all it's nodejs based :D

See notes on https://github.com/alexellis/captains-list/pull/5
If we add a flag like --mode=json do you want to create an add-on image that can take the JSON list and create the ascii map?

@alexellis I believe that it's best to include the code in this image rather than creating a new one. You can do alexellis2/captains --map and instead of printing the captains list it can print a map.

Doug McIlroy’s Unix philosophy; small, sharp tools which combine to solve larger tasks, oftentimes tasks which were not envisioned by the original authors.

This is what I had in mind.


Convert DateTime to MongoDate within Hash types

Hello,
currently there isnt possiblity to store DateTime fields in Hash Type, cuz it always casts
to array. Would it make sense to be able to store DateTime fields in Hash?
If i could get liitle guidence how to change it, I would gladly do it.

Elaborating on previous comment, the hash and collection types are raw types that don't have specific mapping information and thus, don't attempt type conversion. This is not something i intend to change. If you need type conversion, use an embedded document.


Improve supported $PSDefaultParameterValues command types

This issue supersedes https://github.com/PowerShell/PowerShell/issues/24697, which was focused on the lack of support for aliases that target the path of a .ps1 script file.
Summary of the new feature / enhancement
The purpose of this issue is to improve $PSDefaultParameterValues command type support in general, which goes beyond the scope of the original issue.
To remove current inconsistencies and align with PowerShell's typical command calling semantics, $PSDefaultParameterValues should have support added for:

Command names with :.
.ps1 script files specified as a full or relative path (including as the target of an alias).
Module-qualified command names.
Non-advanced/simple commands.

May not be deemed worthwhile considering the technical differences between cmdlet and script parameter binding.

Current behavior
As of v7.5.0, commands specified in $PSDefaultParameterValues are limited to:

Cmdlets and advanced functions/filters:

Cannot be module-qualified.
Cannot include : in the name.

Advanced .ps1 script files:

Must be specified by name (with extension), as reported by (Get-Command -Name .\script.ps1).Name.
Cannot be a full or relative path.

Limits the usefulness considerably as script files currently must be $Env:PATH-discoverable.

Aliases:

The alias name:

Can be module-qualified (unlike with cmdlet/function names).
Cannot include : in the name.

The alias target (as reported by AliasInfo.Definition):

Can be a cmdlet or advanced function/filter name.
Can be an advanced script file name.
Can include : in the name.
Cannot be another alias name.
Cannot be module-qualified.
Cannot be a full or relative script file path.

In all cases, the command/target command:

Cannot be non-advanced/simple.

Must be a cmdlet or have CmdletBindingAttribute/ParameterAttribute decoration.

Can be Import-Module -Prefix-generated.
Can include uncommon characters such as spaces in the name (except : in the cases above).

As the above highlights, there are numerous limitations/inconsistencies, some of which are undocumented as of writing. See:

https://github.com/MicrosoftDocs/PowerShell-Docs/issues/11604

Example scenarios
Given the following example commands:
'param ([Parameter()] $Foo) $Foo' |
    Set-Content -LiteralPath Temp:\ScriptFile.ps1

function Func:tion { param ([Parameter()] $Foo) $Foo }

function SimpleFunction($Foo) { $Foo }

function AdvancedFunction { param ([Parameter()] $Foo) $Foo }

Set-Alias -Name ScriptFilePathAlias -Value Temp:\ScriptFile.ps1

Set-Alias -Name ScriptFileNameAlias -Value ScriptFile.ps1
$Env:PATH += "{0}{1}" -f [IO.Path]::PathSeparator, (Get-Item -LiteralPath Temp:).Fullname

Set-Alias -Name AdvancedFunctionAlias -Value AdvancedFunction

As of v7.5.0, no default value is supplied by the following $PSDefaultParameterValues usage. Support should be added for each of the scenarios outlined.
# Advanced script file by full path.
$PSDefaultParameterValues = @{ 'Temp:\ScriptFile.ps1:Foo' = 'Bar' }
Temp:\ScriptFile.ps1

# Advanced script file by relative path.
$PSDefaultParameterValues = @{ '.\ScriptFile.ps1:Foo' = 'Bar' }
Set-Location -LiteralPath Temp:
.\ScriptFile.ps1

# Alias whose target is an advanced script file by full/relative path.
$PSDefaultParameterValues = @{ 'ScriptFilePathAlias:Foo' = 'Bar' }
ScriptFilePathAlias

# Cmdlet or advanced function/filter with ":" in name.
$PSDefaultParameterValues = @{ 'Func:tion:Foo' = 'Bar' }
Func:tion

# Module-qualified cmdlet or advanced function/filter.
$PSDefaultParameterValues = @{ 'Microsoft.PowerShell.Utility\Write-Output:InputObject' = 'Bar' }
Microsoft.PowerShell.Utility\Write-Output
Write-Output

# Non-advanced/simple command.
# May be out-of-scope for this proposal.
$PSDefaultParameterValues = @{ 'SimpleFunction:Foo' = 'Bar' }
SimpleFunction

For reference, a default value is supplied in the following examples as of v7.5.0:
# Cmdlet without module-qualification.
$PSDefaultParameterValues = @{ 'Write-Output:InputObject' = 'Bar' }
Write-Output # Bar

# Advanced function/filter without module-qualification
$PSDefaultParameterValues = @{ 'AdvancedFunction:Foo' = 'Bar' }
AdvancedFunction # Bar

# Advanced script by name only.
$PSDefaultParameterValues = @{ 'ScriptFile.ps1:Foo' = 'Bar' }
Temp:\ScriptFile.ps1 # Bar

# Alias whose target is a cmdlet or advanced function/filter.
$PSDefaultParameterValues = @{ 'AdvancedFunctionAlias:Foo' = 'Bar' }
AdvancedFunctionAlias # Bar

# Alias whose target is an advanced script file by name.
# Note that the target script must be $Env:PATH-discoverable.
$PSDefaultParameterValues = @{ 'ScriptFileNameAlias:Foo' = 'Bar' }
ScriptFileNameAlias # Bar

Limits the usefulness considerably as script files currently must be $Env:PATH-discoverable.

Not exactly – the name is matched even if you invoke the script using an absolute/relative path:
$PSDefaultParameterValues["asdf.ps1:Arg"] = "Value"
D:\test\asdf.ps1 # this receives -Arg Value

Nevertheless, I agree that adding support for absolute paths to .ps1 scripts would be pretty useful.

the name is matched even if you invoke the script using an absolute/relative path:

Yes, you're absolutely correct. In fact, I have that covered at the bottom of the currently supported scenarios.
$PSDefaultParameterValues = @{ 'ScriptFile.ps1:Foo' = 'Bar' }
Temp:\ScriptFile.ps1 # Bar

The note regarding $Env:PATH discoverability was misplaced. It was intended to be under the alias section (now corrected - thank you!).
To clarify, adding an alias that targets a script file to $PSDefaultParameterValues is only supported if the target (AliasInfo.Definition) is a file name. This isn't particularly useful given calling the alias will only succeed if the target script file is $Env:PATH-discoverable.


TS-4624: use the server UUID in the Via header

If I correctly understood the task :smiley:

Almost, but not quite. :)  All APIs that are prefixed TS are the public APIs, and we don't use those in the internal code. Look at the log tags in logging that uses the internal APIs for the UUID. E.g.
const char *uuid = (char *)Machine::instance()->uuid.getString();

Makes sense?

Don't quite understand why public API can't be used in internal code, but ok, changed code to Machine::instance()->uuid.getString()

It's an inefficiency for starters (you go through a C-> C++ wrapper layer, for no good reason (remember, the public APIs are all C, whereas in the core, you can use all the C++ objects and methods directly).
In this case, it's marginal, but there are other places where it would be inefficient. And, it would add dependencies to the C-APIs in the C++ core which are undesirable in some cases.

[approve ci]

FreeBSD build successful! See https://ci.trafficserver.apache.org/job/Github-FreeBSD/439/ for details.

Linux build successful! See https://ci.trafficserver.apache.org/job/Github-Linux/333/ for details.

Thanks for explaining about API usage

[approve ci]

FreeBSD build failed! See https://ci.trafficserver.apache.org/job/Github-FreeBSD/441/ for details.

Linux build successful! See https://ci.trafficserver.apache.org/job/Github-Linux/335/ for details.

I suspect this failed for other reasons, trying again [approve ci].

I checked the core on this FreeBSD build, and it seems completely unrelated to pretty much anything :).
(gdb) bt
#0  0x0000000000000000 in ?? ()
#1  0x00000000006ec34a in EThread::process_event (this=0x804107000, e=0x803f2c880, calling_code=<value optimized out>) at I_Continuation.h:153
#2  0x00000000006ec8ec in EThread::execute (this=0x804107000) at ../../../iocore/eventsystem/UnixEThread.cc:245
#3  0x00000000006ebb82 in spawn_thread_internal (a=0x803ef5700) at ../../../iocore/eventsystem/Thread.cc:84
#4  0x00000008027514f5 in pthread_create () from /lib/libthr.so.3
#5  0x0000000000000000 in ?? ()

@yatsukhnenko What do you think of a future feature (config) to disable this Via checking completely? If I know there's not chance of a loop, why bother checking the Via header? I guess one could just nuke the Via header on the incoming request, but there might be other reasons to keep it?
This is completely unrelated to this PR though, just thinking out loud.

FreeBSD build successful! See https://ci.trafficserver.apache.org/job/Github-FreeBSD/443/ for details.

Linux build successful! See https://ci.trafficserver.apache.org/job/Github-Linux/337/ for details.

Did a quick test of this, and it looks good:
Via: http/1.1 fedora.ogre.com[f6f5162d-5a02-4d10-ac6e-35aede508fe5] (ApacheTrafficServer/7.0.0)

What do you think of a future feature (config) to disable this Via checking completely? If I know there's not chance of a loop, why bother checking the Via header?

@zwoop, makes sense. Should I create new jira for this?

Yeah, file a Jira probably. I could have sworn we've had issues before where loop detection kicked in when it shouldn't (e.g. you legitimately proxy to yourself). But I can find an issue on it, maybe you can take a look too.

This  one?


Change source of GitHub pages

Hi Sho,
@LucaCappelletti94 got the ball rolling on converting the travis CI to Github actions. (Thanks, Luca!) I've given it another push to get the documentation and benchmarks generated as well. In doing so it'll be helpful to adjust one setting on the trie-rs repository. We'd like to populate the trie-rs' pages from GitHub actions instead of the gh-pages branch. To change this, go to trie-rs Settings, then Pages, then set the source to Github Actions. That should be it. Thanks, Sho.
-Shane

Did it.

Thanks @shanecelis and @LucaCappelletti94 !

Thanks, Sho!


Without lodash

replaced lodash.omit with own implementation to reduce total file size

better?

Published as 1.1.0 - thanks


Initial Detox E2E iOS configuration to be run on RNTester

This PR adds initial setup for Detox E2E iOS and some tests for ButtonExample.
Test Plan:
Circle CI should run this as a separate job, boot a Simulator, build RNTester iOS and run e2e.
Release Notes:
TBA
[INTERNAL] [ENHANCEMENT] [CI] - MOAR TESTS!!!

Looks like circle failed with this error:
Build-agent version 0.0.7400-c4f46116 (2018-07-12T18:30:48+0000)
Configuration errors: 2 errors occurred:

* Error parsing config file: yaml: line 478: did not find expected key
* Cannot find a job named `build` to run in the `jobs:` section of your configuration file.
If you expected a workflow to run, check your config contains a top-level key called 'workflows:'

Thanks for sending the PR. I'll look at it more in detail tomorrow. As discussed today with Facebook, I plan on rebasing my existing PR on top of that one and finishing the "releases" part that I've been talking with you at Chain React.

Thanks for the guidance @hramos. Pushed changes, I'll make sure the config is valid and works.
@TheSavior, the jest-haste-map warning looks like local thing on your machine.
Regarding the error:
running "/usr/bin/xcrun simctl io 48EA356B-E67F-4329-B918-D2F5BE614297 screenshot "/dev/null"" returned 2 7: stderr: An error was encountered processing the command (domain=SimulatorKit.SimDisplayScreenshotWriter.ScreenshotError, code=2): Error creating the image
Did you run detox test with any of the artifacts flags ? --artifacts-location,  --record-logs,  --take-screenshots, etc ?

Warnings

:warning:

:lock: package.json - Changes were made to package.json. This will require a manual import by a Facebook employee.

  Generated by :no_entry_sign: dangerJS

@hramos I think I need help here, the original e2e suite failed, can you please direct me on what to do ?

Just saying:
https://circleci.com/gh/facebook/react-native/47581

It looks like in the log for the circle run you linked to, while it passed, it also had some warnings:
detox-server info 02:58:19: server listening on localhost:49308...
detox info 2: Searching for device matching iPhone 8...
detox info 5: Booting device 319048CF-6ECD-45DC-AD0D-8A74BDB896AB
detox ERR! 7: running "/usr/bin/xcrun simctl io 319048CF-6ECD-45DC-AD0D-8A74BDB896AB screenshot "/dev/null"" returned 2
detox ERR! 7: stderr: An error was encountered processing the command (domain=SimulatorKit.SimDisplayScreenshotWriter.ScreenshotError, code=2):
Error creating the image

Approving the Circle CI config changes. I agree with Eli, it would be nice to get a cleaner output where it's clearer whether the tests were fully successful or not.

Separated build phase from test phase for better visibility with 22788c0
Build react native  iOS produces a huge amount of warnings, even a -quiet flag on xcodebuild produces a super long build log, full of build warnings, this really needs to be addressed within React Native! :(
@noomorph, can you please advise on the warning Detox produces while running: this is a default detox test run, without specifying any configuration regarding artifacts.
This seems to be an issue with Detox, we will deal with it internally (https://github.com/wix/detox/issues/841)

@hramos , can you update me regarding your plan here please? Is there anything I can do?

Now that this PR has been merged, I am going to work on adding the tests that I have created in the past.


Set condition messages for "Provisioned" condition

Without this patch, the changes in how wrangler summarizes
conditions[1][2] causes the condition type, in this case "Provisioned",
to be rendered as the cluster transition message. Since this string
doesn't match the display state "Provisioning", the transition message
is displayed underneath the display state. Setting an non-empty message
on the condition makes this slightly less confusing.
[1] https://github.com/rancher/wrangler/commit/3eba78f45e7d61364efd11d73334641c17305b4c
[2] https://github.com/rancher/wrangler/commit/3533ace946aaf8cc64ae4be9ead3221c35975884
https://github.com/rancher/rancher/issues/32165

We could probably just revert the changes in wrangler. It was an attempt to derive some useful status from CAPI, but I don't think it's really worked out.

So I'm fine if you'd rather want to just revert the changes in pkg/summary/condition.go.

Cool https://github.com/rancher/wrangler/pull/162


A bunch of cleanup and tweaks

FYI: in many cases there were LOTS of duplicate entries in holding. This will help our output be smaller – and also improve diffs across builds.

...yes, this is many commits. Go commit-by-commit if you want to see the forest for the trees.


Delete old trips automatically

Currently, on the pending trips page, the app shows only trips with dates equal to or greater than today.
old trips are still saved in the database.
We should decide whether to delete or save for showcasing past trips of trip instructors.

moved issue to backend


Modify DataBox examples

ARM API Information (Control Plane)
MSFT employees can try out our new experience at OpenAPI Hub  - one location for using our validation tools and finding your workflow.

Azure 1st Party Service can try out the Shift Left experience to initiate API design review from ADO code repo.  If you are interested, may request engineering support by filling in with the form https://aka.ms/ShiftLeftSupportForm.
Changelog
Add a changelog entry for this PR by answering the following questions:

What's the purpose of the update?

[ ] new service onboarding
[ ] new API version
[ ] update existing version for new feature
[ ] update existing version to fix swagger quality issue in s360
[x] Other, please clarify - Modify examples

When are you targeting to deploy the new service/feature to public regions? Please provide the date or, if the date is not yet available, the month.
When do you expect to publish the swagger? Please provide date or, the the date is not yet available, the month.
By default, Azure SDKs of all languages (.NET/Python/Java/JavaScript for both management-plane SDK and data-plane SDK, Go for management-plane SDK only ) MUST be refreshed with/after swagger of new version is published. If you prefer NOT to refresh any specific SDK language upon swagger updates in the current PR, please leave details with justification here.

Contribution checklist (MS Employees Only):

[ ] I commit to follow the Breaking Change Policy of "no breaking changes"
[ ] I have reviewed the documentation for the workflow.
[ ] Validation tools were run on swagger spec(s) and errors have all been fixed in this PR. How to fix?

If any further question about AME onboarding or validation tools, please view the FAQ.
ARM API Review Checklist

Applicability: :warning:
If your changes encompass only the following scenarios, you should SKIP this section, as these scenarios do not require ARM review.

Change to data plane APIs
Adding new properties
All removals

Otherwise your PR may be subject to ARM review requirements. Complete the following:

[ ] Check this box if any of the following apply to the PR so that the label "ARMReview" and "WaitForARMFeedback" will be added by bot to kick off ARM API Review.  Missing to check this box in the following scenario may result in delays to the ARM manifest review and deployment.

Adding a new service
Adding new API(s)
Adding a new API version
-[ ] To review changes efficiently, ensure you copy the existing version into the new directory structure for first commit and then push new changes, including version updates, in separate commits. You can use OpenAPIHub to initialize the PR for adding a new version. For more details refer to the wiki.

[ ] Ensure you've reviewed following guidelines including ARM resource provider contract and REST guidelines. Estimated time (4 hours). This is required before you can request review from ARM API Review board.

[ ] If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.

Breaking Change Review Checklist
If you have any breaking changes as defined in the Breaking Change Policy, request approval from the Breaking Change Review Board.
Action: to initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Additional details on the process and office hours are on the Breaking Change Wiki.
NOTE: To update API(s) in public preview for over 1 year (refer to Retirement of Previews)
Please follow the link to find more details on PR review process.

/azp run

@qiaozha, all the required checks are passing for this PR.
This PR only contains changes to example files. Can you please review and merge the changes if it looks good?

/azp run

/azp run

@zedy-wj, can you review and merge this PR since all required checks are passing.

@raych1 - Please help review Go breaking change.
@msyyc - Please help review Python breaking change.


Enhancement: give friendly error message when non-image name passed to "docker save"

Output of docker version:
David@noe MINGW64 ~/extvol
$ docker version
Client:
 Version:      1.10.2
 API version:  1.22
 Go version:   go1.5.3
 Git commit:   c3959b1
 Built:        Mon Feb 22 22:37:33 2016
 OS/Arch:      windows/amd64

Server:
 Version:      1.10.2
 API version:  1.22
 Go version:   go1.5.3
 Git commit:   c3959b1
 Built:        Mon Feb 22 22:37:33 2016
 OS/Arch:      linux/amd64

David@noe MINGW64 ~/extvol
$

Output of docker info:
David@noe MINGW64 ~/extvol
$ docker info
Containers: 2
 Running: 1
 Paused: 0
 Stopped: 1
Images: 21
Server Version: 1.10.2
Storage Driver: aufs
 Root Dir: /mnt/sda1/var/lib/docker/aufs
 Backing Filesystem: extfs
 Dirs: 37
 Dirperm1 Supported: true
Execution Driver: native-0.2
Logging Driver: json-file
Plugins:
 Volume: local
 Network: null host bridge
Kernel Version: 4.1.18-boot2docker
Operating System: Boot2Docker 1.10.2 (TCL 6.4.1); master : 611be10 - Mon Feb 22 22:47:06 UTC 2016
OSType: linux
Architecture: x86_64
CPUs: 1
Total Memory: 996.1 MiB
Name: default
ID: 226R:TS6B:7ZBR:LRVK:UP2Y:HY6M:3L2N:XYK5:7QIH:4TIJ:AIO6:ULTN
Debug mode (server): true
 File Descriptors: 18
 Goroutines: 32
 System Time: 2016-02-25T22:45:17.889222018Z
 EventsListeners: 0
 Init SHA1:
 Init Path: /usr/local/bin/docker
 Docker Root Dir: /mnt/sda1/var/lib/docker
Labels:
 provider=virtualbox

David@noe MINGW64 ~/extvol
$

Provide additional environment details (AWS, VirtualBox, physical, etc.):

Recent installation using docker-machine on Windows 10.

List the steps to reproduce the issue:

created data volume /var/lib/postgresql/data  in container based on debian:8.2 for use by known working image based on postgres:9.4.5
tried to run docker save on container with data volume

Describe the results you received:
David@noe MINGW64 ~/extvol
$ docker save data_vlpd > data_vlpd.tar
Error response from daemon: digest not found

David@noe MINGW64 ~/extvol
$ docker save -o data_vlpd.tar data_vlpd
Error response from daemon: digest not found

David@noe MINGW64 ~/extvol
$

Describe the results you expected:

Friendly error message along lines of "data_vlpd" is not an image

Provide additional info you think is important:
Motivated by #20705 . Filed at suggestion of @thaJeztah

#dibs

I'd like to take a look at this. ping @thaJeztah

Thanks @HackToday!

hi @tonistiigi  I did some research and found that in
https://github.com/docker/docker/commit/eeb2d4c1adbe4e00f9fbcdc70f9ac31997968e1d
it add related logic, and that would cause non-exist image have no digest error output.
But I tried to add logic in daemon.go to check if image exist or not first before do save operation, but it is not fix, because save image accept general repo without tag, so GetImage can not work.
It may need some change in your commit change before.  I did not quite understand complicated content-address image logic there. Maybe you are more familiar with that. Could you take a look at that ?

@HackToday Repo without the tag means saving all tags for the image. The reason why there is so much logic there is the order of priority for different inputs. The order should be digest, digest prefix, repo:tag, repo, hex. For this specific error ErrDigestNotFound , it can only come if you search digest from imagestore and it cannot be found. So maybe just rewrite this specific error instead of trying to detect it before calling.

hi @tonistiigi

what do you think the error should be?  We should have  "Image can not be found" message, but I am not sure if ErrDigestNotFound here is right place to do changed with  "Image can not be found" message.

And also from https://docs.docker.com/engine/reference/commandline/save/ I did not it said related format for  digest, digest prefix, repo:tag, repo, hex it just have repo and repo:tag

ping @tonistiigi

what do you think the error should be? We should have "Image can not be found" message, but I am not sure if ErrDigestNotFound here is right place to do changed with "Image can not be found" message.

ErrDigestNotFound should not come from anywhere else so should be safe to replace. I'm not sure if all cases will fail with this error though. This should happen if every other method fails and we are trying to match the input as a part of an image ID. You should not replace the original error. Just detect that if you the imagestore returns ErrDigestNotFound you instead show some nice error to the user.

And also from https://docs.docker.com/engine/reference/commandline/save/ I did not it said related format for digest, digest prefix, repo:tag, repo, hex it just have repo and repo:tag

Image ID (+ partial) is also supported. The order is just a best effort to avoid collisions.


Add support for destructuring rest parameters

A change we missed to the spec, I noticed in the V8 change log:
https://github.com/v8/v8/commit/dfce900d64f2579607705fd2d94c13f28c2e996f
Here is the a repro case:
function f(...[a,b]) {}
http://closure-compiler-debugger.appspot.com/#input0%3Dfunction%2520f(...%255Ba%252Cb%255D)%2520%257B%257D%250A%250A%250Avar%2520%255Ba%252Cb%255D%2520%253D%2520%255B1%252C2%255D%26input1%26conformanceConfig%26externs%26refasterjs-template%26includeDefaultExterns%3D1%26CHECK_SYMBOLS%3D1%26CHECK_TYPES%3D1%26LANG_IN_IS_ES6%3D1%26MISSING_PROPERTIES%3D1%26PRESERVE_TYPE_ANNOTATIONS%3D1%26PRETTY_PRINT%3D1%26TRANSPILE%3D1

The final ES6 spec shows the behavior that is currently implemented in Closure Compiler. This is an upcoming change for ES7 if I'm not mistaken.
If we're sure this is going to made it to the ES7 final spec (it seems pretty likely) then we should probably make REST a one-child AST node so that this becomes easier when we start getting serious about ES7 features, but still disallow anything but a NAME as its first child.


Error when run model-analyzer in remote mode

I'm trying to run model-analyzer remotely for my custom model but it is failing with the following error:
2021-12-03 20:16:15.587 ERROR[entrypoint.py:214] Model Analyzer encountered an error: Failed to set the value for field "triton_server_path". Error: Either the binary 'tritonserver' is not on the PATH, or Model Analyzer does not have permissions to execute os.stat on this path.
I cannot specify the triton_server_path because I use remote mode model-analyzer and run tritonserver and model-analyzer in different containers.
I do next steps to reproduce the error:

Run tritonserver container on custom ports.
Run sdk container and then run command:

Singularity> model-analyzer profile --model-repository=/models --profile-models=detector_trt  --triton-launch-mode=remote --triton-http-endpoint=localhost:5000 --triton-grpc-endpoint=localhost:5001 --triton-metrics-url=localhost:5002
I use singularity to run containers but it does’t matter.

@badskeet This issue has been fixed in the main branch of Model Analyzer and will be available for 21.12. As a workaround, could you please set the triton_server_path field to a binary file that exists?

Since this issue is still open, I will add to it. After using the workaround, there is a similar error:
2021-12-11 12:47:36.814 ERROR[entrypoint.py:214] Model Analyzer encountered an error: Failed to set the value for field "triton_install_path". Error: Either '/opt/tritonserver' is a nonexistent path, or Model Analyzer does not have permissions to execute os.stat on this path

It can be worked around simply by
mkdir -p /opt/tritonserver


Allow setting array to undefined and null when using $each

https://jsfiddle.net/b5v4faqf/358/
It fails here: https://github.com/monterail/vuelidate/blob/master/src/index.js#L304
Since calling Object.keys on undefined or null throws.
 TypeError: Cannot convert undefined or null to object
      at Function.keys (<anonymous>)
      at VueComponent.keys (node_modules\vuelidate\lib\index.js:351:23)

Haven't been able to clone and test your code locally yet due to some computer problems, but in my code this solution behaves as expected. So just relying on circleci to run the tests for me.

Codecov Report

Merging #204 into master will decrease coverage by 0.22%.
The diff coverage is 75%.

@@            Coverage Diff            @@
##           master    #204      +/-   ##
=========================================
- Coverage   99.53%   99.3%   -0.23%
=========================================
  Files          24      24
  Lines         429     432       +3
=========================================
+ Hits          427     429       +2
- Misses          2       3       +1

Impacted Files
Coverage Δ

src/index.js
99.5% <75%> (-0.5%)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 901a8f0...82ad4d9. Read the comment docs.

Not sure why codecov reports the line as untouched https://codecov.io/gh/monterail/vuelidate/pull/204/diff#D1-306
It certainly get there for me in my tests. I created a dummy PR to run checks on circle CI etc. https://github.com/monterail/vuelidate/pull/204

Seems it didn't actually fail when I removed the fix. Realized I never called any computed so that the keys computed never got revaluated. Also discovered that chrome allows calling Object keys on all values but undefined and null, while phantomjs failed on some of the other values in the test. So added a more complete check for only objects. Same check lodash uses: https://github.com/lodash/lodash/blob/master/isObject.js#L26

Hi, thanks for that contribution! :)
Can you squash the changes? It's a whooping 8 commits that mostly overwrite each other.
Other than that, looks great!

Yeah I edited on github directly so became a lot of commits :) Thanks!


Add partition_offsets emitter metrics

name: kommitted_partition_offsets_poll_time_ms
labels: cluster_id
help: Time taken to fetch earliest/latest (watermark) offsets of all the topic partitions of the cluster.

name: kommitted_partition_offsets_emitter_channel_capacity
labels: cluster_id
help: Capacity of the internal channel used to send the fetched partition watermark offsets information to the rest of the system

Will also add a metric for the usage of the Partition Offsets Register that resides in Kommitted.


"Reset Feeds" on Calendar Feeds page

What is this button supposed to do?
When I click it, it sends me to /calendar_feeds/reset which says "the page you are looking for doesn't exist"

This button resets the hash, so if someone uses Google Calendar to get events from the ical url,  it invalidates the old one.

Fixed by PR #454


⚠ Bofrost.at has degraded performance

In 03e6563, Bofrost.at (https://www.bofrost.at) experienced degraded performance:

HTTP code: 200
Response time: 1322 ms

Resolved: Bofrost.at performance has improved in 9ecced4.


Intelrealsense D435i  No Camera feed

librealsense
2.54.2 RELEASE

OS
Linux

During the execution of a code with the camera, I encountered an error and subsequently checked the camera feed, only to find that it was not displaying. However, the error message indicated that the RealSense camera was detected.
please find image attached

Hi @Syedifthikar  I note that you are using a Raspberry Pi.
Does the camera appear in the Viewer if you unplug it from the USB port, wait a couple of seconds and then re-insert it?

Dear IntelRealSense/librealsense,
Same issue  after following the above.
I have attached the images for the same.
On Sat, Mar 9, 2024 at 5:06 PM MartyG-RealSense @.***>
wrote:

Hi @Syedifthikar https://github.com/Syedifthikar I note that you are
using a Raspberry Pi.
Does the camera appear in the Viewer if you unplug it from the USB port,
wait a couple of seconds and then re-insert it?
—
Reply to this email directly, view it on GitHub
https://github.com/IntelRealSense/librealsense/issues/12738#issuecomment-1986832522,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/A6KIT7QLA53KA3YG5TRWPE3YXLX4ZAVCNFSM6AAAAABEOAHCICVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTSOBWHAZTENJSGI
.
You are receiving this because you were mentioned.Message ID:
@.***>

Hi @Syedifthikar  Apologies for the delay in responding further.  Your images did not attach as images cannot be sent to this support forum by email.  They have to be pasted into the comment writing box on this web-page.

Hi @Syedifthikar  Do you require further assistance with this case, please?  Thanks!

Case closed due to no further comments received.


Add filesystems to partition patch

Closing pull request as project is being archived.

Closing pull request as project is being archived.

Closing pull request as project is being archived.


Getting exception in cart when remove one ticket from event booking from backend

Bug report
Title
Getting exception in cart when remove one ticket from event booking from backend
Issue Description
Getting exception in cart when remove one ticket from event booking from backend
Preconditions
1. framework Version- master

Steps to reproduce
1. step1- add event with two tickets
2. step2- move to cart by selecting one ticket
3. step3- delete that ticket from backend & reload the cart again

Actual result

fixed


forza horizon 4 is not getting detect

forza horizon 4 is not getting detect but forza horizon 3 does
i'll have to manually add everytime i play fh4

This sounds like a client issue, not an API issue. You probably want to visit and maybe contact Discord support at https://support.discordapp.com/hc/en-us. If you suspect that there is a client bug, try https://discord.gg/discord-testers


Introduce PTQ FastBC

Changes

Reason for changes

Related tickets

Tests

I am fine with merging this. The method will be enabled in a separate PR after extensive validation.

I am fine with merging this. The method will be enabled in a separate PR after extensive validation.

Sorry for the misleading with the PR's.
The main PR into NNCF https://github.com/openvinotoolkit/nncf/pull/1282


Cannot run tests, seems to be an internal issue: 1) "before all" hook   2) "after all" hook

I'm not sure from the title what the issue is. What is the expected behavior? What is the missing file start.sh?

@jubbens I am so sorry that I uploaded a wrong attachment by mistake, I just updated it now.

@amismailphp It looks like something is already listening on port 3000 so it can't lift the server. This is normal. Either free the port before testing, or if this is the server already running, you can alternatively pass null as the second argument so it doesn't try to lift the server before running the tests.


README: Add steps for VSCode as IDE

Add steps to use VSCode as IDE using an extension (still in preview)

Thank you!


Calculating the full logit for formality

@yangkevin2, really nice paper and code. I have a question regarding the calculation of the full logit in the predict_formality.py.
Seem like you're adding the raw logit top_logits with the condition_logits which is the log probability. Why it's so? I suppose we need to calculate log probability of top_logits before we can add the two together.
full_logits = top_logits + condition_lambda * condition_logits

I'm still trying to understand the code and I might likely be wrong. Thanks in advance!

Hi,
Mathematically, the logits are just log probabilities + an additive constant (since you log_softmax the logits to get log probabilities). You could calculate log probability of top_logits first but it shouldn't change the result, since the additive constant would just be "softmaxed away" later.

Hi,
Mathematically, the logits are just log probabilities + an additive constant (since you log_softmax the logits to get log probabilities). You could calculate log probability of top_logits first but it shouldn't change the result, since the additive constant would just be "softmaxed away" later.


 wont render when using HOC component

Bug Report
Describe the bug
I have a basic React + styled-components setup. Everything is working great until I use the withTheme HOC from styled-components. If I use any HOC's in my components the <PropsTable> no longer renders... Is there a solution to this?
To Reproduce
Docz versions:
docz v0.13.7
docz-theme-default v0.13.7
(I also tried with 0.14.0-alpha.68 on both but still doesn't work..
This is my component file Test.js
import React from 'react'
import PropTypes from 'prop-types'
import styled, { withTheme } from 'styled-components'

const Test = ({ name }) => (
  <Name>{name}</Name>
)

const Name = styled.div`
  display: inline-flex;
  padding: 15px 20px;
  margin: 10px;
  border-radius: 5px;
  background-color: yellowgreen;
  justify-content: center;
  align-items: center;
  color: white;
`
Test.propTypes = {
  name: PropTypes.string
}

Test.defaultProps = {
  name: 'John Deere'
}

export default withTheme(Test)

and my Test.mdx file
---
name: Test
menu: Components
---

import { Playground, PropsTable } from 'docz'
import Test from './'

# Test

<PropsTable of={Test} />

## Basic Usage

<Playground>
  <Test />
  <Test name="Jackson" />
</Playground>

Expected behavior
The props table should render like below:
(this only renders when I export the component without the HOC: export default Test)

Any kind of fix with using HOC's would be helpful...

There is a bug with the same issue with forwardRef : https://github.com/pedronauck/docz/issues/334#issuecomment-457510992
You have to use Test component to use <PropsTable>.

You can import Test and withTheme(Test). WithTheme would be the default export.

`import Test, {Test as TestWithPropTypes} from './MyComponent'

the other solution is to access to Test with render.type() :

This is a huge problem when wrapping components in React.memo.

You could type-cast it
export default (withTheme(Test) as unknown) as typeof Test


Stuck On 'Getting Ready' screen during Windows 11 Install.

I tried two different Windows 11 ISOs, never gets past the Getting Ready screen. An older version of the answer file I tried a few weeks ago worked just fine.

Which version of the file are you using?
I've used both the Core and LTSC like versions on three different computers in the past 2 days, didn't have any issues.

I use the newest LTSC like version answer file on a 10.0.22635.4005 IOT Enterprise ISO made from the UUP Dump website.

I used it on this kind of ISO before, but I think for some reason Github wasn't allowing me to properly download the answer file.
I downloaded it again and now it looks okay. I'll test it again.

Allright, hopefully all goes well.

@KedarWolf Is there a solution/conclusion?
I've had the same "stuck on Getting Ready" problem with Win11 setup, although not the original, but tempered with.
Interesting thing: the pre-latest standard xml installed in half an hour, windowse opened and running fine.
Not sure if the scripts were executed there bc there was Edge in toolbar.

I've used the unedited answer file to install Windows 11 on multiple different computers (laptops and desktops) without any issues since the creation of this issue. I don't believe there is any issue in the unedited file.