Re-order module functions so they appear in dependency order

Current Situation

Many of our modules are structured such that the highest-level function (e.g. main) is at the top of the file, and the functions it utilizes are below it.
 Example
def main():
    conn = get_conn()
    for letter in "abc":
        munged = munge_letter(letter)
        publish_text(munged, conn)

def get_conn():
    ...

def munge_letter(letter):
    obfuscated = _obfuscate_letter(letter)
    munged = (obfuscated + "salt") * 50
    return munged

def _obfuscate_letter(letter):
    ...

def publish_text(munged, conn):
    ...

Suggested Improvement

We should invert this order, so all of the lowest-level functions are at the top of the file, and get composed into the higher-level functions further down the file.
 Example
def _obfuscate_letter(letter):
    ...

def munge_letter(letter):
    obfuscated = _obfuscate_letter(letter)
    munged = (obfuscated + "salt") * 50
    return munged

def get_conn():
    ...

def publish_text(munged, conn):
    ...

def main():
    conn = get_conn()
    for letter in "abc":
        munged = munge_letter(letter)
        publish_text(munged, conn)

Benefit

This would help alleviate cognitive load when performing PR reviews or reading a module. There would be a clear "order" to the functions, and one could build up an understanding of each of the individual pieces before reaching the top-level function.
Additional context

I, personally, find it very helpful during review if I can read the file from top to bottom. I often find that having the top-level function first requires that I jump down to try and find where the dependent functions are defined.
See WordPress/openverse-catalog#357
Implementation

[ ] 🙋 I would be interested in implementing this feature.

This is a personal preference and would be tedious to change throughout the codebase and may even be detrimental to piecing apart git history. Closing this.


Doesn't run with latest cordova

after cloning and running cordova platform add android i see error:
Plugin doesn't support this project's cordova-android version. cordova-android: 8.1.0, failed version requirement:
      <6.3.0
Skipping 'cordova-plugin-compat' for android

and after that another one Cannot find module 'cordova-common'
The folder /platforms/android is created, but cordova run android is not working because of Error: Cannot find module 'q'
I'm on version cordova 9.0.0 and on macbook.
background: I wanted to run this example because I was couldn't get plugin darryncampbell-cordova-plugin-intent  running - on sharing plain text from other app I still cannot see my app in the share menu - So I wanted to see working example.

Hi, can you please try again with the master branch.  I just checked in a fix that works on my machine with Cordova 9.  Looks like Cordova changed the build system a while back to move from config.xml to package.json and I haven't updated this app for a while.

yep, now it works, thank you!


[notify.pushover] Fix 'NoneType' error on data retrieval

Description:
Previous code causes a 'NoneType' object is not iterable error when no data: config is provided to Pushover.
Related issue (if applicable): fixes #2309
Pull request in home-assistant.io with documentation (if applicable): home-assistant/home-assistant.io#
Example entry for configuration.yaml (if applicable):
automation:
  alias: Garage Door is Open
  trigger:
    platform: state
    entity_id: sensor.garage_door
    state: 'open'
  action:
    service: notify.pushover
    data:
      title: Garage Door
      message: The garage door is open.
      target: iPhone,MacBookPro
      data:
        url: https://home-assistant.io/
        url_title: Home Assistant
        priority: 1
        timestamp:<PHONE_NUMBER>
        sound: siren

Checklist:
If user exposed functionality or configuration variables are added/changed:

[ ] Documentation added/updated in home-assistant.io

If the code does not interact with devices:

[ ] Local tests with tox run successfully. Your PR cannot be merged unless tests pass
[ ] Tests have been added to verify that the new code works.

Looks good! :dolphin:


Run generic plugin Apply when no vender plugin loaded

Fix the issue that generic plugin Apply won't be invoked if no supported
vendor NICs in the host.
https://bugzilla.redhat.com/show_bug.cgi?id=1914414

/lgtm

/lgtm

with this change the intel plugin is no longer needed ?

with this change the intel plugin is no longer needed ?

with this change the intel plugin is no longer needed ?

With this change, generic_plugin is able to be applied no matter vendor plugins are loaded or not. This change is not specific to intel or mellanox. Previously, generic_plugin cannot be applied to other vendor NICs if none of intel or mellanox plugins are loaded.

I think adrian point was that you can also delete intel plugis as it does nothing today.
Get Outlook for Androidhttps://aka.ms/ghei36

From: zshi<EMAIL_ADDRESS>Sent: Monday, February 1, 2021 4:29:24 AM
To: k8snetworkplumbingwg/sriov-network-operator<EMAIL_ADDRESS>Cc: Subscribed<EMAIL_ADDRESS>Subject: Re: [k8snetworkplumbingwg/sriov-network-operator] Run generic plugin Apply when no vender plugin loaded (#50)
with this change the intel plugin is no longer needed ?
With this change, generic_plugin is able to be applied no matter vendor plugins are loaded or not. This change is not specific to intel or mellanox. Previously, generic_plugin cannot be applied to other vendor NICs if none of intel or mellanox plugins are loaded.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHubhttps://github.com/k8snetworkplumbingwg/sriov-network-operator/pull/50#issuecomment-770521653, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AAILLJMZVVCV2KY5RJBAPKLS4YGYJANCNFSM4WMMIBCA.

In generally LGTM on this one, I just wonder if intel plugin should be removed as it basically does nothing and generic plugin will always be invoked by the config daemon

Yes, the intel plugin does nothing today.
I think we can remove it for now, and add it back if there are any intel devices that require additional configuration. We can address this in a separate PR.


"argument of type 'datetime.date' is not iterable" error when passing date var

"argument of type 'datetime.date' is not iterable" error on passing date var when running dbt run --models ...
Issue description
I expected the date (2018-09-13) to be passed as date var to my model's query, but received an error. I noticed that when I pass it as a string (but only in double quotes, like "2018-09-13", it works fine.
Results
See above / below.
System information
The output of dbt --version:
installed version: 0.10.1
   latest version: 0.11.0

The operating system you're running on:
Mac OS High Sierra 10.13.4
The python version you're using (probably the output of python --version)
3.6.2
Steps to reproduce
In as much detail as possible, please provide steps to reproduce the issue. Sample data that triggers the issue, example models, etc are all very helpful here.
I spoke with Drew Bain on Slack group, and this info might be useful for anyone who tries to investigate this issue:
"
drew.banin [3 hours ago]
I’m trying to reproduce this locally but it actually fails for me with a different issue! I get:
datetime.date(2018, 1, 1) is not JSON serializable```

drew.banin [3 hours ago]
So, dbt definitely doesn’t like that this thing comes through as a date instead of a string. I think that conversion actually happens when yaml parses your `dbt_project.yml` file, not inside of dbt itself

drew.banin [3 hours ago]
One other idea comes to mind though — can you try something like this?
```{% set start_date = var('start_date').isoformat() %}```

tomek [3 hours ago]
didn’t work with the isoformat neither :disappointed:
"

thanks @tomekzbrozek! We'll take a look!

I get very different behavior here - I'm not saying it's good or desirable behavior, but:
$ cat models/x.sql
{% set start_date = var('start_date') %}
select {{ start_date }} as when
$ dbt run --vars "{start_date: '2018-09-13'}" # or '{start_date: "2018-09-13"}', or '{start_date: 2018-09-13}, etc
Running with dbt=0.13.0
Found 1 models, 0 tests, 1 archives, 0 analyses, 101 macros, 0 operations, 0 seed files, 1 sources

08:54:29 | Concurrency: 2 threads (target='default')
08:54:29 |
08:54:29 | 1 of 1 START view model dbt_postgres.x............................... [RUN]
08:54:29 | 1 of 1 OK created view model dbt_postgres.x.......................... [CREATE VIEW in 0.08s]
08:54:29 |
08:54:29 | Finished running 1 view models in 0.41s.
$ psql -c 'select * from dbt_postgres.x'
 when
------
 1996
(1 row)

So, what database is this? What do the models/macros in question actually look like to trigger this error? Is this even an issue anymore? We do serialize dates properly now, so maybe it's fixed?

@beckjake haha, i think the problem with your example is just that you're missing quotes in x.sql!
2018 - 09 - 13 = 1996

I gave this a spin too - it definitely looks like we're serializing dates correctly now. Closing this one as fixed :)


refactor(*): dev env setup, code cleanup

⚠ Don't merge yet! This PR is awaiting testing and review from @vladfrangu

What does this PR accomplish?

[x] ESLint & Prettier (and config)
[x] Husky Pre-commit hooks (in connection with lint-staged and commitlint)
[x] General "makeRequest" function that all fetch requests are abstracted to.
[x] Fully type all outgoing requests made so that the code is type-safe.
[x] Cleanup of the code (condensing variables, renaming, etc.)
[ ] Handle dAPI ratelimits/retry (?? is this needed? It's an oauth application so can we afford to wait/retry requests?)

That's cool, why?

API ratelimits are likely not necessary to handle. We won't hit them.


Getting 'en_US.UTF-8' instead of 'en'

When the browser sends a preference for 'en_US.UTF-8' and the provided locale list has 'en', I would expect the locale to be set to 'en', not the full string. Is that a wrong assumption?
I'm using express 4 and
import locale from 'locale'
const languages = ['en', 'nl']
app.use(locale(languages), (req, res, next) => {
		if (!languages.includes(req.locale)) {
			console.error(`!!! ${req.locale} was badly picked by locale`)
			req.locale = languages[0]
		}
		next()
})

to detect this situation.

You're probably getting the default locale which is automatically set to match the locale of the environment.

So… shouldn't that be tested against the list of allowed locales?
On Thu, Apr 6, 2017, 3:23 PM D. Stuart Freeman<EMAIL_ADDRESS>wrote:

You're probably getting the default locale which is automatically set to
match the locale of the environment.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/florrain/locale/issues/39#issuecomment-292173088, or mute
the thread
https://github.com/notifications/unsubscribe-auth/AADWlgZb54MwKNFj2mostVQ8ywFzP5W8ks5rtOdlgaJpZM4Mz7my
.

Hi @wmertens - Indeed, the lib doesn't know anything about the charset suffix right now. So the locale matching probably doesn't work at all if there's a charset. You can pass the default locale when you register the middleware: locale(languages, 'en') which should solve your issue.
Not an actual bug per se but input sanitization wouldn't hurt as it seems to be the common format to include the charset on UNIX environments. If someone is willing to hack this in a PR, it'd be very welcome.


Release automation replaces local chart ref with release chart ref

In the "Building your own Helm Chart" section of the README.md the release automation step that updates the README.md will replace the local reference to the chart to the release version.

Resolved in release 0.5.1


[Question] For what purpose in the function "Os:follow_link()" lines:

Hello.
It's just a question
For what purpose in the function "Os:follow_link()" lines:
857  [[ "$file_folder" != /* ]] && link_folder="$(cd -P "$file_folder" &> /dev/null && pwd)"
858  local symlink
859  symlink=$(readlink "$1")
860  link_folder=$(dirname "$symlink")

it looks pointless in the part concerning link_folder
Thanks for your feedback
Yury

Hi!
The main goal (if I recall correctly) is to resolve symbolic links to their real path. I use the basher package manager and it works with symbolic links for the scripts it installs.
E.g.
bashew  → $HOME/.basher/bin/bashew → $HOME/.basher/cellar/packages/pforret/bashew/bashew
so the 'real' installation path (where I could find the .env and other config files) is $HOME/.basher/cellar/packages/pforret/bashew and I would not find that if I just do dirname "$0"

Hello.

The main goal (if I recall correctly) is to resolve symbolic links to their real path. I use the basher package manager and it works with symbolic links for the scripts it installs.

That's clear.
But.
What is line 857 for? If we redefine the link_folder variable in line 860?

I think the technical term for that is "a bug" :-)
I fixed it now!

function Os:follow_link() {
  [[ ! -L "$1" ]] && echo "$1" && return 0 ## if it's not a symbolic link, return immediately
  local file_folder link_folder link_name symlink
  file_folder="$(dirname "$1")" ## check if file has absolute/relative/no path
  [[ "$file_folder" != /* ]] && file_folder="$(cd -P "$file_folder" &> /dev/null && pwd)" ## a relative path was given, resolve it
  symlink=$(readlink "$1") ## follow the link
  link_folder=$(dirname "$symlink") ## check if link has absolute/relative/no path
  [[ -z "$link_folder" ]] && link_folder="$file_folder" ## if no link path, stay in same folder
  [[ "$link_folder" == \.* ]] && link_folder="$(cd -P "$file_folder" && cd -P "$link_folder" &> /dev/null && pwd)" ## a relative link path was given, resolve it
  link_name=$(basename "$symlink")
  IO:debug "$info_icon Symbolic ln: $1 -> [$symlink]"
  Os:follow_link "$link_folder/$link_name" ## recurse
}

Thanks for the comments )

Thanks for the comments )

Thanks for pointing out the bug!!


"Property ... should be of type List or Parameter", when using a CommaDelimitedList

cfn-lint version: (cfn-lint --version)
cfn-lint 0.3.5
Description of issue.
Our CloudFormation template contains a CommaDelimitedList parameter:
"Aliases" : {
    "Type": "CommaDelimitedList",
    "Default": "foo.com, bar.com"
},

We reference this parameter under Aliases in our CloudFront distribution. The Aliases key accepts a list of string values - which our CommaDelimitedList provides - and the CloudFormation console correctly processes the template:
"Distribution" : {
    "Type" : "AWS::CloudFront::Distribution",
    "Properties" : {
        "DistributionConfig" : {
            "Aliases" : { "Ref" : "Aliases" },
            ...
        }
    }
}

However cfn-lint flags this as an error:
E3002 Property Aliases should be of type List or Parameter should be a list for resource Distribution
If we wrap the reference in a list, we can get a pass from cfn-lint:
"Distribution" : {
    "Type" : "AWS::CloudFront::Distribution",
    "Properties" : {
        "DistributionConfig" : {
            "Aliases" : [
                { "Ref" : "Aliases" }
            ]
            ...
        }
    }
}

However that property is now evaluating to a list of lists:
[ [ "foo.com", "bar.com" ] ]

This is an incorrect parameter and causes the CloudFormation console to fail with Value of property Aliases must be of type List of String.
It seems like cfn-lint may be interpreting the CommaDelimitedList type incorrectly? Possibly as a string, rather than a list of strings? Let me know if I can provide any more detail.

Thanks @kddejong, appreciate it.


I am getting a database error when running a simple chat bot with my own corpus

I have defined my own corpus which is being parsed successfully from what I can tell. However, when I run the bot, I am getting the following error.
   return connection._execute_clauseelement(self, multiparams, params)
  File "C:\Users\user\AppData\Local\Programs\Python\Python36-32\lib\site-package
s\sqlalchemy\engine\base.py", line 1053, in _execute_clauseelement
    compiled_sql, distilled_params
  File "C:\Users\user\AppData\Local\Programs\Python\Python36-32\lib\site-package
s\sqlalchemy\engine\base.py", line 1189, in _execute_context
    context)
  File "C:\Users\user\AppData\Local\Programs\Python\Python36-32\lib\site-package
s\sqlalchemy\engine\base.py", line 1402, in _handle_dbapi_exception
    exc_info
  File "C:\Users\user\AppData\Local\Programs\Python\Python36-32\lib\site-package
s\sqlalchemy\util\compat.py", line 203, in raise_from_cause
    reraise(type(exception), exception, tb=exc_tb, cause=cause)
  File "C:\Users\user\AppData\Local\Programs\Python\Python36-32\lib\site-package
s\sqlalchemy\util\compat.py", line 186, in reraise
    raise value.with_traceback(tb)
  File "C:\Users\user\AppData\Local\Programs\Python\Python36-32\lib\site-package
s\sqlalchemy\engine\base.py", line 1182, in _execute_context
    context)
  File "C:\Users\user\AppData\Local\Programs\Python\Python36-32\lib\site-package
s\sqlalchemy\engine\default.py", line 470, in do_execute
    cursor.execute(statement, parameters)
sqlalchemy.exc.InterfaceError: <exception str() failed>

I have sqlite3 installed. My code is below.
from chatterbot import ChatBot
import logging
logging.basicConfig(level=logging.INFO)
chatbot = ChatBot(
    'CISO',
    trainer='chatterbot.trainers.ChatterBotCorpusTrainer'
)

# Train based on the ciso corpus
chatbot.train("chatterbot.corpus.ciso")

# Get a response to an input statement
resp=chatbot.get_response("what is cyber security")
print(resp)

Hi all,
I have further tested the bot on Linux and am getting the same error message. How do I troubleshoot this? I can see the database file being created. Could the problem be with my corpus? I am attaching the file with this issue.
I am also pasting the code of my bot.
pi@raspberrypi:~ $ cat cb.py
from chatterbot import ChatBot
import logging
logging.basicConfig(level=logging.INFO)
chatbot = ChatBot(    'CISO',
storage_adapter='chatterbot.storage.SQLStorageAdapter',
database='./database.sqlite3',
trainer='chatterbot.trainers.ChatterBotCorpusTrainer'
)
Train based on the ciso corpus
chatbot.train("chatterbot.corpus.ciso")
Get a response to an input statement
resp=chatbot.get_response("what is cyber security")
print(resp)pi@raspberrypi:~ $
ciso_yml.txt

@pranavlal could you please post your Linux stack trace? So that will more idea on your failure?

Hi,
Sure. I am attaching the log to this message.
teraterm.log

@pranavlal Thanks, By looking error log, The error is
sqlite3.InterfaceError: Error binding parameter 0 - probably unsupported type.

I found this thread useful to you https://stackoverflow.com/a/12953027/358458
These are guesses
paramter 0, is unsupported means The Statement is Unicode text element, Instead your supplying other data type. Is it possible to share your corpus ciso.yml file?

Hi,
I have already shared my yml file. I will attach it again. I will keep it as a txt extension.
ciso.txt

Hi,
I have solved the problem in a strange way. My  file's encoding is set to US-ASCII which is a subset of UTF-8. There is one problem question which seems to be causing all the problems.

what is confidentiality
The need in information security for people to access only information they are authorized to view


implement rust ExternalLibrary

Merged in https://github.com/Vector35/binaryninja-api/commit/f90f8512135935a182cc805b5e7a3728529f3487, thank you!


Add Catalog to the Advanced Search

Right now we can search by Source, Table, Column, etc, but there is not a UI element for the Catalog. If I write a URL to filter by Catalog, it all works as expected.
Currently, the BigQuery loader puts the Project into the "Catalog" property. The "Schema" property contains the dataset. The Source is always BigQuery (which is helpful, since we have other kinds of databases too)
Service or Ingestion ETL
This seems like a Frontend only change.
Example Screenshots (if appropriate):

If there was Catalog in addition to Source, that would help us out a lot.
Context
We could see how many tables have an "email" column in a certain BigQuery Project. (Certain projects are not allowed to have certain kinds of data)

Currently we put BQ project ID(is it the catalog you referred to?) in the cluster field(https://github.com/lyft/amundsendatabuilder/blob/master/databuilder/extractor/bigquery_metadata_extractor.py#L77) . If I understand, we want to also use advanced search / filter for a given project ID?

will let @ttannis to comment. The search backend should already had the support for cluster(project in BQ) in https://github.com/lyft/amundsensearchlibrary/blob/master/search_service/proxy/elasticsearch.py#L37.

@lukelowery, Looking at https://github.com/lyft/amundsenfrontendlibrary/blob/master/amundsen_application/static/js/config/config-default.ts#L92-L122 the link you post, I think that only works for the case if you have different databases(bq, hive, presto) etc. One short term workaround would be put project id in the database field in your env.  But this needs to test it out and verify...

What's the context of "catalog"? I'm not familiar.
But the general idea is that folks should be able to customize their filters in their custom application configuration. The items we provide in the default configuration aren't expected to be updated for individual use cases, and are kept in sync with the categories supported byt the default ES implementation.

@ttannis ,Bigquery reuses the cluster field for catalog which is to represent BQ project per my understanding.
For hive, we have the same field for cluster currently, but for BQ,they could have different field for different tables depending on which catalog they belong to.

Is it implemented? We are having the same usecase, where we are using snowflake and BigQuery both and we wanted to enable the search by Schema Name (In Snowflake) & Project Name (in BQ) which is tied to Cluster field.


Ensure domovoi errors when there is no handler

This issue has been observed when a bucket that has no s3_subscribers registered with domovoi has SNS messages enabled on CreateObject. Under these circumstances, _find_sns_s3_event_sub returns no handler, domovoi tries to call None with args (event, context) and the following exception is thrown.
'NoneType' object is not callable: TypeError Traceback (most recent call last): File "/var/task/domovoi/app.py", line 137, in __call__ result = handler(event, context) TypeError: 'NoneType' object is not callable
'NoneType' object is not callable: TypeError
Traceback (most recent call last):
File "/var/task/domovoi/app.py", line 137, in __call__
result = handler(event, context)
TypeError: 'NoneType' object is not callable

This PR makes sure an informative error is thrown.

Thanks!

Released in v1.5.7.


Update README to instruct users to use a Node version that keeps up with the engine minimum verison

The engine version now expects a more recent Node version than what lts/hydrogen is pinned at, which is what we tell users to install in the readme.

Closing as a non-issue. The person that experienced this installed lts/hydrogen at a time before the required version was released, but installing lts/hydrogen now will install a compatible version.


Compiling with cpp causes application crash with no provided error

This is due to ✨ https://github.com/neroist/uing/issues/10 ✨


Impl dotnet tpk cache validation

This pr implements the functionality of repackaging tpks only when its necessary. Original implementation was https://github.com/flutter-tizen/flutter-tizen/pull/47,
but it couldn't handle packaging between different build modes.
As stated in https://github.com/flutter-tizen/flutter-tizen/pull/51, the FlutterBuildSystem cleans dirty files in directories that are shared by different build modes at the last step of FlutterBuildSystem.build. Packaging the tpk right after FlutterBuildSystem.build is simpler than writing code that find dirty files and delete them.
Summary of changes

created TizenPackager and PackageTpkDelegate constructs to separate packaging from the Target.build method
created TizenAssetsBundle class so that flutter_assets files are written directory to {PROJECT_DIR}/tizen/flutter/ephemeral/res/flutter_assets
added proper files as cache sources for TizenPlugins and DotnetTpk.

Correctness
The code was tested with a set of test cases in https://github.com/HakkyuKim/flutter-tizen/tree/dotnet-tpk-cache-validation-test.
To run the test, run the following command in the flutter-tizen project root directory.
./flutter/bin/cache/dart-sdk/bin/pub run test test/tizen_build_target_test.dart

Limitation

Validating cache for plugin packages with path dependencies is non-trivial. At the moment, TizenPlugins always rebuilds. when there is at least one plugin dependency, flutter always writes timestamp to .flutter-plugins-dependencies before building. Adding .flutter-plugins-dependencies file to input source will trigger rebuild everytime.
Currently doesn't support native projects.

Closing due to implementation changes in #61 and #63.
Contrary to the original plan, now plugins are rebuilt only when necessary, but tpk packages are always rebuilt on flutter-tizen run or flutter-tizen build. This feature will be added as a different PR.


pipeline fails in job release

[4:47:48 AM] [semantic-release] [@semantic-release/github] › ℹ  Verify GitHub authentication
[4:47:48 AM] [semantic-release] › ✔  Completed step "verifyConditions" of plugin "@semantic-release/github"
[4:47:48 AM] [semantic-release] › ℹ  Start step "verifyConditions" of plugin "@semantic-release/exec"
[4:47:48 AM] [semantic-release] › ✔  Completed step "verifyConditions" of plugin "@semantic-release/exec"
[4:47:48 AM] [semantic-release] › ℹ  Start step "verifyConditions" of plugin "semantic-release-docker"
[4:47:48 AM] [semantic-release] › ✖  Failed step "verifyConditions" of plugin "semantic-release-docker"
[4:47:48 AM] [semantic-release] › ✖  An error occurred while running semantic-release: Error: Environment variable DOCKER_USERNAME is not set
    at module.exports (/usr/local/lib/node_modules/semantic-release-docker/lib/verify.js:6:13)
    at validator (/usr/local/lib/node_modules/semantic-release/lib/plugins/normalize.js:34:30)
    at /usr/local/lib/node_modules/semantic-release/lib/plugins/pipeline.js:37:40
    at next (/usr/local/lib/node_modules/semantic-release/node_modules/p-reduce/index.js:17:9)
    at processTicksAndRejections (internal/process/task_queues.js:97:5) {
  pluginName: 'semantic-release-docker'
}
AggregateError:
    Error: Environment variable DOCKER_USERNAME is not set
        at module.exports (/usr/local/lib/node_modules/semantic-release-docker/lib/verify.js:6:13)
        at validator (/usr/local/lib/node_modules/semantic-release/lib/plugins/normalize.js:34:30)
        at /usr/local/lib/node_modules/semantic-release/lib/plugins/pipeline.js:37:40
        at next (/usr/local/lib/node_modules/semantic-release/node_modules/p-reduce/index.js:17:9)
    at /usr/local/lib/node_modules/semantic-release/lib/plugins/pipeline.js:54:11
    at processTicksAndRejections (internal/process/task_queues.js:97:5)
    at async Object.pluginsConf.<computed> [as verifyConditions] (/usr/local/lib/node_modules/semantic-release/lib/plugins/index.js:80:11)
    at async run (/usr/local/lib/node_modules/semantic-release/index.js:94:3)
    at async module.exports (/usr/local/lib/node_modules/semantic-release/index.js:259:22)
    at async module.exports (/usr/local/lib/node_modules/semantic-release/cli.js:55:5) {
  name: 'AggregateError'
}

I have a look into this

muss ich nochmals anschauen


Clean up updatePredicateNode

Description
Updates updatePredicateNode to updatePredicateNodeVersions for clarity and consistency with other sibling methods.
Remove default in switch handling for node types.  We should explicitly handle each type; currently all 3 are so removal has no effect and ErrorProne will detect new ones that aren't explicitly handled in MissingCasesInEnumSwitch
Release notes:
NA
Checklist
General

[x] Added the correct label: < feature | bug | dependencies | infrastructure | ignore-for-release >
[ ] Created tests which fail without the change (if possible)
[ ] Extended the README / documentation, if necessary

User visible changes

[ ] Wrote browser tests using the validateAccessibility method
[ ] Manually tested at 200% size
[ ] Manually evaluated tab order

New Features

[ ] Add new FeatureFlag env vars to server/conf/application.conf
[ ] Conditioned new functionality on a FeatureFlag
[ ] Wrote browser tests with the feature flag off and on, etc.

Issue(s) this completes
Fixes #<issue_number>; Fixes #<issue_number>...

Codecov Report

Merging #3730 (d6dc38c) into main (31f115d) will decrease coverage by 0.00%.
The diff coverage is 66.66%.

@@             Coverage Diff              @@
##               main    #3730      +/-   ##
============================================
- Coverage     80.54%   80.53%   -0.01%
  Complexity     2431     2431
============================================
  Files           295      295
  Lines          9621     9624       +3
  Branches        658      658
============================================
+ Hits           7749     7751       +2
- Misses         1619     1620       +1
  Partials        253      253

Impacted Files
Coverage Δ

server/app/repository/VersionRepository.java
84.07% <66.66%> (-0.34%)
:arrow_down:

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more


Replace and Update SASS build to use sass vs. node-sass

Expected Behaviour
Running npm runs start starts a proxy and a browser window shows the proxied content from AEM with styles applied from local development.
Actual Behaviour
Compilation process fails due to unsupported OS
Reproduce Scenario (including but not limited to)
Steps to Reproduce
Run npm run start from ui.frontend module on Mac Big Sur using NodeJS 15.7
Platform and Version
Mac OS Big Sur
NodeJS 15.7
Sample Code that illustrates the problem
None: created project and attempt to build module
Logs taken while reproducing problem
▶ npm run start

><EMAIL_ADDRESS>start
> webpack-dev-server --open --config ./webpack.dev.js

[HPM] Proxy created: [ '/content', '/etc.clientlibs' ]  ->  http://localhost:4502

ℹ ｢wds｣: Project is running at http://localhost:8080/
ℹ ｢wds｣: webpack output is served from /
ℹ ｢wds｣: Content not from webpack is served from /projects/aem/febuild/ui.frontend
ℹ ｢wdm｣: wait until bundle finished: /
✖ ｢wdm｣: Hash: 2ecd5507acf4f7ba3a50
Version: webpack 4.44.2
Time: 2656ms
Built at: 01/27/2021 9:14:22 AM
Asset     Size  Chunks  Chunk Names
clientlib-site/site.js  885 KiB    site  site
Entrypoint site = clientlib-site/site.js

WARNING in ./src/main/webpack/site/main.ts
Module Warning (from (webpack)-import-glob-loader/index.js):
(Emitted value instead of an instance of Error) Empty results for "import "./**/*.js""
NonErrorEmittedError: (Emitted value instead of an instance of Error) Empty results for "import "./**/*.js""
at Object.emitWarning (/projects/aem/febuild/ui.frontend/node_modules/webpack/lib/NormalModule.js:160:16)
at replacer (/projects/aem/febuild/ui.frontend/node_modules/webpack-import-glob-loader/index.js:85:12)
at String.replace (<anonymous>)
at Object.module.exports (/projects/aem/febuild/ui.frontend/node_modules/webpack-import-glob-loader/index.js:91:20)

ERROR in ./src/main/webpack/site/main.scss
Module build failed (from ./node_modules/mini-css-extract-plugin/dist/loader.js):
ModuleBuildError: Module build failed (from ./node_modules/sass-loader/dist/cjs.js):
Error: Node Sass does not yet support your current environment: OS X 64-bit with Unsupported runtime (88)
For more information on which environments are supported please see:
https://github.com/sass/node-sass/releases/tag/v4.14.1
at module.exports (/projects/aem/febuild/ui.frontend/node_modules/node-sass/lib/binding.js:13:13)
at Object.<anonymous> (/projects/aem/febuild/ui.frontend/node_modules/node-sass/lib/index.js:14:35)
at Module._compile (node:internal/modules/cjs/loader:1108:14)
at Object.Module._extensions..js (node:internal/modules/cjs/loader:1137:10)
at Module.load (node:internal/modules/cjs/loader:973:32)
at Function.Module._load (node:internal/modules/cjs/loader:813:14)
at Module.require (node:internal/modules/cjs/loader:997:19)
at require (node:internal/modules/cjs/helpers:92:18)
at getDefaultSassImpl (/projects/aem/febuild/ui.frontend/node_modules/sass-loader/dist/index.js:198:10)
at Object.loader (/projects/aem/febuild/ui.frontend/node_modules/sass-loader/dist/index.js:80:29)
at /projects/aem/febuild/ui.frontend/node_modules/webpack/lib/NormalModule.js:316:20
at /projects/aem/febuild/ui.frontend/node_modules/loader-runner/lib/LoaderRunner.js:367:11
at /projects/aem/febuild/ui.frontend/node_modules/loader-runner/lib/LoaderRunner.js:233:18
at runSyncOrAsync (/projects/aem/febuild/ui.frontend/node_modules/loader-runner/lib/LoaderRunner.js:143:3)
at iterateNormalLoaders (/projects/aem/febuild/ui.frontend/node_modules/loader-runner/lib/LoaderRunner.js:232:2)
at iterateNormalLoaders (/projects/aem/febuild/ui.frontend/node_modules/loader-runner/lib/LoaderRunner.js:221:10)
at /projects/aem/febuild/ui.frontend/node_modules/loader-runner/lib/LoaderRunner.js:236:3
at runSyncOrAsync (/projects/aem/febuild/ui.frontend/node_modules/loader-runner/lib/LoaderRunner.js:130:11)
at iterateNormalLoaders (/projects/aem/febuild/ui.frontend/node_modules/loader-runner/lib/LoaderRunner.js:232:2)
at Array.<anonymous> (/projects/aem/febuild/ui.frontend/node_modules/loader-runner/lib/LoaderRunner.js:205:4)
at Storage.finished (/projects/aem/febuild/ui.frontend/node_modules/enhanced-resolve/lib/CachedInputFileSystem.js:55:16)
at /projects/aem/febuild/ui.frontend/node_modules/enhanced-resolve/lib/CachedInputFileSystem.js:91:9
at /projects/aem/febuild/ui.frontend/node_modules/graceful-fs/graceful-fs.js:123:16
at FSReqCallback.readFileAfterClose [as oncomplete] (node:internal/fs/read_file_context:75:3)
@ ./src/main/webpack/site/main.ts 1:0-21
ℹ ｢wdm｣: Failed to compile.

Notes:
Researching this issue shows that node-sass and the corresponding LibSass is deprecated. The recommendation is to move to https://www.npmjs.com/package/sass

+1

+1


having problem with hasLaterality converting lh.aparc.stats

Here's the problem trace....not sure if this is related to InterLex scraping of anatomical CDEs or not...
Traceback (most recent call last):
File "/Applications/PyCharm 2.app/Contents/helpers/pydev/pydevd.py", line 2411, in
globals = debugger.run(setup['file'], None, None, is_module)
File "/Applications/PyCharm 2.app/Contents/helpers/pydev/pydevd.py", line 1802, in run
launch(file, globals, locals)  # execute the script
File "/Applications/PyCharm 2.app/Contents/helpers/pydev/_pydev_imps/_pydev_execfile.py", line 18, in execfile
exec(compile(contents+"\n", file, 'exec'), glob, loc)
File "/Users/dbkeator/Documents/Coding/segstats_jsonld/segstats_jsonld/fs_to_nidm.py", line 575, in
main(sys.argv[1:])
File "/Users/dbkeator/Documents/Coding/segstats_jsonld/segstats_jsonld/fs_to_nidm.py", line 559, in main
add_seg_data(nidmdoc=nidmdoc,measure=measures,header=header, json_map=json_map)
File "/Users/dbkeator/Documents/Coding/segstats_jsonld/segstats_jsonld/fs_to_nidm.py", line 135, in add_seg_data
QualifiedName(provNamespace("hasLaterality","http://uri.interlex.org/ilx_0381387#"),""):json_map['Anatomy'][measures["structure"]]['hasLaterality'],
KeyError: 'hasLaterality'

There was a space in the default label.  So edited that to match and added the label with a space to synonyms.

Thx, can we close this then?

Don’t know if that fixed what Dave saw...

On Jun 10, 2019, at 22:31, Adina Wagner<EMAIL_ADDRESS>wrote:
Thx, can we close this then?
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub https://urldefense.proofpoint.com/v2/url?u=https-3A__github.com_dbkeator_segstats-5Fjsonld_issues_5-3Femail-5Fsource-3Dnotifications-26email-5Ftoken-3DAAMPEZNDZ2WY2EOO2XCFV3LPZ42DFA5CNFSM4HWUQYYKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODXL7O2Y-23issuecomment-2D500692843&d=DwMCaQ&c=clK7kQUTWtAVEOVIgvi0NU5BOUHhpN0H8p7CSfnc_gI&r=VoBnXVyFWlbGZNrES22a2h0PqI4m1kGEUyTwLwBBYIQ&m=c42GE_UFYynW6_vFHwVgVMtd1754jFQ36JGOJaf2T5g&s=U0FWftlVPTRnkVKaPj0ORD0PcVOGu_0ovrxbHKB0M4E&e=, or mute the thread https://urldefense.proofpoint.com/v2/url?u=https-3A__github.com_notifications_unsubscribe-2Dauth_AAMPEZLHBGDAJMSHESVVT2LPZ42DFANCNFSM4HWUQYYA&d=DwMCaQ&c=clK7kQUTWtAVEOVIgvi0NU5BOUHhpN0H8p7CSfnc_gI&r=VoBnXVyFWlbGZNrES22a2h0PqI4m1kGEUyTwLwBBYIQ&m=c42GE_UFYynW6_vFHwVgVMtd1754jFQ36JGOJaf2T5g&s=GkA2IgpJge70DDRqb8bC63Gkuia28o6TxcOUQcG26MY&e=.

Jeffrey S. Grethe, Ph.D.                                              email<EMAIL_ADDRESS><EMAIL_ADDRESS>University of California, San Diego
9500 Gilman Drive, M/C 0608
La Jolla, CA 92093-0608
work:<PHONE_NUMBER> (
fax:<PHONE_NUMBER>
UCSD Profile: http://profiles.ucsd.edu/jeffrey.grethe http://profiles.ucsd.edu/jeffrey.grethe
ORCID: http://orcid.org/0000-0001-5212-7052 http://crbs.ucsd.edu/
LinkedIn: http://www.linkedin.com/in/jgrethe http://www.linkedin.com/in/jgrethe
This e-mail/fax message, including any attachments, is for the sole use of the intended recipient(s) and may contain confidential and privileged information. Any unauthorized review, use, disclosure or distribution is prohibited. If you are not the intended recipient, please contact the sender by reply e-mail/fax and destroy all copies of the original message.

Solved by checking whether anatomy CDE has a laterality designation...


ci: use npm v7 in the test images

Description of changes

Issue #, if available

Description of how you validated changes
Checklist

[ ] PR description included
[ ] yarn test passes
[ ] Tests are changed or added
[ ] Relevant documentation is changed or added (and PR referenced)
[ ] New AWS SDK calls or CloudFormation actions have been added to relevant test and service IAM policies

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Build: https://app.circleci.com/pipelines/github/yuth/amplify-cli/744/workflows/4bd9e6ac-34a7-4fbd-9f45-82527b02fd69/jobs/4533


babel-preset-env for node_modules conflicts with puppeteer

Is this a bug report?
Yes
Did you try recovering your dependencies?
Yes
Which terms did you search for in User Guide?
N/a
Environment
  System:
    OS: OS X El Capitan 10.11.6
    CPU: x64 Intel(R) Core(TM) i5-4288U CPU @ 2.60GHz
  Binaries:
    Node: 10.11.0 - /opt/boxen/nodenv/versions/10.11.0/bin/node
    Yarn: 1.9.4 - /opt/boxen/homebrew/bin/yarn
    npm: 6.4.1 - /opt/boxen/nodenv/versions/10.11.0/bin/npm
  Browsers:
    Chrome: 72.0.3626.119
    Firefox: 65.0.1
    Safari: 11.1.2
  npmPackages:
    react: ^16.8.2 => 16.8.3
    react-dom: ^16.8.2 => 16.8.3
    react-scripts: 2.1.5 => 2.1.5
  npmGlobalPackages:
    create-react-app: Not Found

Steps to Reproduce

yarn build

Expected Behavior
No error
Actual Behavior
yarn run v1.9.4
$ react-scripts build
Creating an optimized production build...
Failed to compile.

./node_modules/puppeteer/lib/WebSocketTransport.js
Cannot find module: 'ws'. Make sure this package is installed.

Reproducible Demo
https://codesandbox.io/s/lqryym71m
Related https://github.com/stereobooster/react-snap/issues/336

I figured it out. The error is in the code of application


Add webp nginx configuration for TYPO3 projects

The Problem/Issue/Bug:
There is possibility to provide webp support out of box, also with fallback to original file
How this PR Solves The Problem:
Nginx automatically matches .webp files if they exist and serves them instead of original file
Manual Testing Instructions:
Create TYPO3 project, generate .webp files for existing processed images (there are extensions which can be used for generating those files)
Release/Deployment notes:
This change is backward compatible.

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.Łukasz Uznański seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.You have signed the CLA already but the status is still pending? Let us recheck it.

Awesome. We'll see if we can get some community review on this and get it into an alpha. It should probably go into the other project types, but maybe it can sort things out in TYPO3 first.

@lukaszuznanski could you please do the CLA - thanks!

@rfay I already signed CLA with last PR, I can see that CLA is already signed when I try to sign it again.

@lukaszuznanski sometimes people use a different email for a commit, and it requires different CLA response.

Artifacts for testing are at https://circleci.com/gh/drud/ddev/23703#artifacts/containers/0 (expand the "artifacts" thingie just under "test summary"

Hi,
there is one thing, webp is not supported by TYPO3 by default, so I'm wondering if this should be included in configuration, on the other side, it's only few lines, and provides support for webp images with backward compatibility, there are no breaking changes

I'd like to see generic support for all CMS versions, and don't really see why it can't happen. Was hoping TYPO3 would be the guinea pig. But it will need a testbed example for at least manual testing.

Yea, sure, I can provide TYPO3 installation with sample webp implementation, it can be achieved with custom extension. I believe that TYPO3 will suport webp out of box with Image Initiative

@lukaszuznanski this is still waiting for you to sign the CLA, and it's still waiting for your testing with TYPO3. Thanks!

I'd like to see this support go in, but it seemed there was a fair bit of conversation that didn't get resolved, and no response from the OP even to sign the CLA.
Closing this for now, happy to continue the conversation here or elsewhere.
This will be vastly easier to test in the v1.15 series, as you can edit the config files directly, there's no need to bundle them into the docker image.


Activity Notification UI

This PR is adding the new full featured UI notification on top of Busy platform. This feature is a complementary feature to our browser notification feature.

If i click on a notification, i got redirected to the related comment but then, if i click to another notification, i will stay on the same page (the previous notification).
Counter should not be visible when "0"
When click notification icon the popover is open, when i click again on notification icon the popover should close. Actually its closing then opening another time if i click.
On the page /notifications :

Content frame should not be full-size, there should be a container div.
The notification description should not be limited to 250px width


MitarbeiterId field on PersonAbteilungenRow is read before assigned a value!

When saving a list, the following error message is displayed.
The field is specified as follows:
[DisplayName("Mitarbeiter"), NotNull, ForeignKey("[dbo].[NET_Mitarbeiter]", "MitarbeiterId"), LeftJoin("jMitarbeiter"), TextualField("MitarbeiterName")]
public Int32? MitarbeiterId
{
get { return Fields.MitarbeiterId[this]; }
set { Fields.MitarbeiterId[this] = value; }
}
Can someone help

You are trying to read it somewhere while it wasn't selected

Yes, it was.
I created in the automatic code generation, columns, forms and dialog.
After removing the classes, it works perfectly. Thank you.


Error while executing procudure with rollback in postgresql database

System information:

DBeaver version:dbeaver-ce-21.3.2-x86_64(windows)

Connection specification:

Additional extensions:postgresql13.3(centos7.9)
PostgreSQL JDBC Driver

Describe the problem you're observing:
Executing the following statement with DBeaver tool will cause PostgreSQL DB exception
CALL "TEST_A"();

DB log：the database system is in recovery mode
CREATE OR REPLACE PROCEDURE public."TEST_A"()
 LANGUAGE plpgsql
AS $procedure$
 DECLARE
	CCPG_SaiSeion$kanaReplaceArray_  varchar ARRAY[5];
	i numeric := 0;
	j numeric := 0;
	lsql varchar;
	lcsrToti refcursor := 'curs';
	a varchar;
	lProcCount integer := 0;
	lHjnHyokagak numeric;
	lHjnZenHyokagak numeric;
BEGIN

		    FOR i IN 1..10 LOOP
						BEGIN
		            INSERT INTO test values('qq','ww');
				        lProcCount := lProcCount + 1;
				    EXCEPTION
                WHEN NO_DATA_FOUND THEN
                   lHjnHyokagak    := 0;
                   lHjnZenHyokagak := 0;
									 WHEN OTHERS THEN
									     RAISE;
						END;

		        IF MOD(lProcCount, /*EEPG_Cnst.CMTCNT_EER02420*/2) = 0 THEN
		            j := j + 1;
				        raise notice'j%',j;
                ROLLBACK;
            END IF;
		END LOOP;
END;
$procedure$
;

the rollback statement will cause exceptions
However, other tools such as Navicat or pgadmin4 will not introduce exceptions
It won't work to execute commands directly with psql, so it is judged that it is a bug in the DBeaver. Please confirm and fix it
Steps to reproduce, if exist:
Include any warning/errors/backtraces from the logs

postgresql db log: *the database system is in recovery mode
2022-01-19 17:21:30.840 CST [29227] FATAL:  データベースシステムはリカバリモードです
2022-01-19 17:21:30.851 CST [29228] FATAL:  データベースシステムはリカバリモードです
2022-01-19 17:21:30.862 CST [29229] FATAL:  データベースシステムはリカバリモードです
2022-01-19 17:21:30.924 CST [29237] FATAL:  データベースシステムはリカバリモードです
2022-01-19 17:21:30.930 CST [29240] FATAL:  データベースシステムはリカバリモードです
2022-01-19 17:21:30.936 CST [29242] FATAL:  データベースシステムはリカバリモードです
2022-01-19 17:21:30.942 CST [29245] FATAL:  データベースシステムはリカバリモードです
2022-01-19 17:21:30.954 CST [29249] FATAL:  データベースシステムはリカバリモードです
2022-01-19 17:21:30.961 CST [29252] FATAL:  データベースシステムはリカバリモードです

Hello @93910676wangd
Unfortunately can't reproduce your issue.
And I can't look into this issue because the issue is in your database.
Database logs before the database system is in recovery mode can be helpful.
Maybe this topic can help: https://dba.stackexchange.com/questions/61650/postgres-is-stuck-in-recovery-mode

Hello @93910676wangd
Unfortunately can't reproduce your issue. And I can't look into this issue because the issue is in your database. Database logs before the database system is in recovery mode can be helpful.
Maybe this topic can help: https://dba.stackexchange.com/questions/61650/postgres-is-stuck-in-recovery-mode

why  Navicat or pgadmin4 tool is no problem
however DBeaver is error.. why???


feat: add timer on validate code action modal

Details

Implement a timer to prevent the user from requesting multiple magic code emails within a short period.
Fix an issue where no API call is made due to a condition added earlier, which prevents the API call if a magic code was recently sent, even when the function is called from a resend action.

Had to change the way we pass sendValidateCode removing the condition, which in result help us avoid writing repetitive code. cc @youssef-lr
Fixed Issues

$ https://github.com/Expensify/App/issues/49270
PROPOSAL:
Tests

Open the app
Navigate to Settings > Profile > Contact methods
Press on unverified contact method
Verify that there is a timer to request a new magic code
Wait for the 30 seconds and press on Didn't receive a magic code?
Verify that the 30 seconds timer starts again

[x] Verify that no errors appear in the JS console

Offline tests

N/a
QA Steps

Same as tests

[x] Verify that no errors appear in the JS console

PR Author Checklist

[x] I linked the correct issue in the ### Fixed Issues section above
[x] I wrote clear testing steps that cover the changes made in this PR

[x] I added steps for local testing in the Tests section
[x] I added steps for the expected offline behavior in the Offline steps section
[x] I added steps for Staging and/or Production testing in the QA steps section
[x] I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
[x] I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
[x] I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).

[x] I included screenshots or videos for tests on all platforms
[x] I ran the tests on all platforms & verified they passed on:

[x] Android: Native
[x] Android: mWeb Chrome
[x] iOS: Native
[x] iOS: mWeb Safari
[x] MacOS: Chrome / Safari
[x] MacOS: Desktop

[x] I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
[x] I followed proper code patterns (see Reviewing the code)

[x] I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
[x] I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
[x] I verified that comments were added to code that is not self explanatory
[x] I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
[x] I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method

[x] If any non-english text was added/modified, I verified the translation was requested/reviewed in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:

[x] I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
[x] I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
[x] I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
[x] I verified the JSDocs style guidelines (in STYLE.md) were followed

[x] If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
[x] I followed the guidelines as stated in the Review Guidelines
[x] I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
[x] I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
[x] I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
[x] I verified that if a function's arguments changed that all usages have also been updated correctly
[x] If any new file was added I verified that:

[x] The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory

[x] If a new CSS style is added I verified that:

[x] A similar style doesn't already exist
[x] The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))

[x] If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
[x] If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
[x] If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
[x] If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
[x] If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:

[x] I verified that all the inputs inside a form are aligned with each other.
[x] I added Design label and/or tagged @Expensify/design so the design team can review the changes.

[x] If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
[x] If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Android: Native

https://github.com/user-attachments/assets/3299dfd5-e238-4022-858a-02d2b44fa61f

Android: mWeb Chrome

https://github.com/user-attachments/assets/680d12dd-824e-4f36-b0a5-3366483ed086

iOS: Native

https://github.com/user-attachments/assets/d18122e1-62b4-427c-a846-13d8cb59dad2

iOS: mWeb Safari

https://github.com/user-attachments/assets/89a3a219-9a58-470e-8691-8bf069c5132d

MacOS: Chrome / Safari

https://github.com/user-attachments/assets/76cabd6b-f6cf-4e75-a110-682a08d6a2fe

MacOS: Desktop

https://github.com/user-attachments/assets/20284843-56f8-473c-aad2-64f4305078e3

Reviewer Checklist

[x] I have verified the author checklist is complete (all boxes are checked off).
[x] I verified the correct issue is linked in the ### Fixed Issues section above
[x] I verified testing steps are clear and they cover the changes made in this PR

[x] I verified the steps for local testing are in the Tests section
[x] I verified the steps for Staging and/or Production testing are in the QA steps section
[x] I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
[x] I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)

[x] I checked that screenshots or videos are included for tests on all platforms
[x] I included screenshots or videos for tests on all platforms
[x] I verified tests pass on all platforms & I tested again on:

[x] Android: Native
[x] Android: mWeb Chrome
[x] iOS: Native
[x] iOS: mWeb Safari
[x] MacOS: Chrome / Safari
[x] MacOS: Desktop

[x] If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
[x] I verified proper code patterns were followed (see Reviewing the code)

[x] I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
[x] I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
[x] I verified that comments were added to code that is not self explanatory
[x] I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
[x] I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
[x] I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
[x] I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
[x] I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
[x] I verified the JSDocs style guidelines (in STYLE.md) were followed

[x] If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
[x] I verified that this PR follows the guidelines as stated in the Review Guidelines
[x] I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
[x] I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
[x] I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
[x] If a new component is created I verified that:

[x] A similar component doesn't exist in the codebase
[x] All props are defined accurately and each prop has a /** comment above it */
[x] The file is named correctly
[x] The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
[x] The only data being stored in the state is data necessary for rendering and nothing else
[x] For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
[x] Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
[x] All JSX used for rendering exists in the render method
[x] The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions

[x] If any new file was added I verified that:

[x] The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory

[x] If a new CSS style is added I verified that:

[x] A similar style doesn't already exist
[x] The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)

[x] If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
[x] If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
[x] If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
[x] If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
[x] If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:

[x] I verified that all the inputs inside a form are aligned with each other.
[x] I added Design label and/or tagged @Expensify/design so the design team can review the changes.

[x] If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
[x] If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
[x] I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

https://github.com/user-attachments/assets/e437374c-bf62-43f9-a11c-328fe46c394c

iOS: mWeb Safari

https://github.com/user-attachments/assets/3c7a4556-6668-4ee4-b450-bad455ea9cfe

MacOS: Chrome / Safari

https://github.com/user-attachments/assets/35e6cc28-101b-4a95-bca7-681a9fdf22f6

MacOS: Desktop

https://github.com/user-attachments/assets/ab3f3d26-897d-40ae-8831-657e062fa18f

:hand: This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.


fix: Copy to clipboard misleading popover when clicking outside the corner

Description
AWSUI-60050
The root of this issue is that we have two trigger handlers for the copy-to-clipboard component: one attached to a custom trigger wrapper (within the popover component) and another to the trigger itself. Since these triggers have slightly different visual layouts - the outer wrapper lacks a border radius while the inner trigger has one, clicking just outside the inner button corners opens the popover but does not activate the copy-to-clipboard handler. This behavior led to the issue described in the ticket.
This PR resolves the issue by attaching the existing copy-to-clipboard handler to the popover trigger event.
Related links, issue #, if available: n/a
How has this been tested?

Review checklist
The following items are to be evaluated by the author(s) and the reviewer(s).
Correctness

Changes include appropriate documentation updates.
Changes are backward-compatible if not indicated, see CONTRIBUTING.md.
Changes do not include unsupported browser features, see CONTRIBUTING.md.
Changes were manually tested for accessibility, see accessibility guidelines.

Security

If the code handles URLs: all URLs are validated through the checkSafeUrl function.

Testing

Changes are covered with new/existing unit tests?
Changes are covered with new/existing integration tests?

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

On this deployed page I can still reproduce the issue.
I think what is happening now is that if I click on the corner, the text is not copied, but the popover is opened anyway, which is misleading.

On this deployed page I can still reproduce the issue.
I think what is happening now is that if I click on the corner, the text is not copied, but the popover is opened anyway, which is misleading.

The issue is that this click caused an unexpected behavior (showed the popover without actually copying) so this PR addresses it. Preventing click on the button's corners is much more tricky, because this wrapper is coming from popover component. I considered an option to prevent it from triggering, but it caused more problems than solved. If you have better suggestions, let's discuss them in this thread.

Would it help to apply border-radius to the trigger?

Unfortunately, no, because it might prevent clicking on it only in combination with overflow: hidden, which breaks the layout.

To me it seems to work: if I apply a 20px border radius to the button's immediate parent, the click does not do anything anymore.
The reason I'm insisting is that I don't see the fix makes things better as it currently stands, rather I'm afraid it makes things a bit worse:

In the current state, clicking on the corners of the popover trigger will show a popover which shows the "in-progress" state, without ever moving further. Confusing but nothing happened
After these changes, doing the same action (clicking on the corners) shows the success popover, indicating that the text was copied to the clipboard, but it is not true, it is misleading

After these changes, doing the same action (clicking on the corners) shows the success popover, indicating that the text was copied to the clipboard, but it is not true

Sorry I see that it does copy to clipboard. Then the change does things a bit better I guess, although ideally clicking on the corners would do nothing.

POC of the border-radius approach: https://github.com/cloudscape-design/components/pull/3059. Tested locally, clicking outside the borders does nothing.


can't mount ROOT folder of a drive to index & getting error.

Hi, Awesome tool for SD community. you are a hero.
I just found this and started using it but i am having a few problems and share some suggestions.

if i set my Ai drive (I have a VHD mounted as a separate drive for AI generations) root letter (Z:), i get this error.
"The calling thread cannot access this object because a ....."
so now i have to manually set each folder ONE by ONE.
there is no option to drag and drop folders or select multiple folders in the one go. which can be helped if we are allowed to select multiple folders. and I am assuming ROOT drive is not supported since it gives error of "can't access SYSTEM VOLUME INFORMATION"
so, help me here if there is a way to just put Z: in the database folder name and it indexes the subfolders from the main root of the drive.
or let us select multiple folders at the same time.
right now, if i have 100 folders, i will have to put each one over a 100 times!!!

when the app opens, it shows all the images on the front page instead of folders or something.
I think it should be an option to select what we want as an HOME screen when the app opens for the first time.

I can't select the images from the prompt search on shows thumbnails, which is such as shame.
plus, the negative prompt does not even show the thumbnails.

so looking forward for a solution or a tip if i am doing something wrong.
thanks again>
regards
Dan

I've never considered adding root as as folder, I'll see if I can fix System Volume Information error
Folders and albums are pretty new and folders is really just there upon request, so it is not fully featured or really consistent.  The main purpose of the app was to allow searching by prompt and other metadata, so folder support is mostly experimental. I'll consider adding the ability to set the home screen.
The prompt search is also quite new, especially the thumbnails.  I'm not quite sure what users need to do there.  It's also a bit separate in terms of code, and I don't want to duplicate code from the main thumbnail view.

Thanks for the reply,
you do know that there is no app like this for SD generative images? right?
your app is one and only database manager, image viewer and toolkit for prompts.
this app is legendary.
but as nothing is perfect there is always room for improvement and we can make anything near perfect.
you are the trailblazer, others will follow.
users would prefer if they see a thumbnail, they click on it and see the bigger image full resolution as in image viewer.
root folder as input is great so we dont have to put hundred folders into index manually.
check my comments and see if there is anything that can be done on these minor pain points.
so excited to use it fully functionally.
regards
Dan

See if this build has what you need
Diffusion.Toolkit.v1.6 beta.zip


BigQueryIO.read(SerializableFunction): Collect records that could not be parsed into the custom-typed object into a PCollection of TableRows

Just as org.apache.beam.sdk.io.gcp.bigquery.WriteResult.getFailedInserts() allows a user to collect failed writes for downstream processing (e.g., sinking the records into some kind of deadletter store), could the results of a BigQueryIO.read(SerializableFunction) be collected, allowing a user to access TableRows that were not able to be parsed by the provided function , for the purpose of downstream processing (e.g., some kind of deadletter handling).
In our use case, all data loaded into our Apache Beam pipeline must meet a specified schema, where certain fields are required to be non-null. It would be ideal to collect records that do not meet the schema to output them to some kind of deadletters store.
Our current implementation requires us to use the slower BigQueryIO.ReadTableRows() and then attempt, in a subsequent transform, to parse these TableRows into a custom typed object, outputting any failures to a side output for downstream processing. This isn't incredibly cumbersome, but it would be a nice feature of the connector itself.
Imported from Jira BEAM-11919. Original Jira may contain additional context.
Reported by: jacquelynwax.

@johnjcasey I'm triaging issues - is this still relevant?

Done in https://github.com/apache/beam/pull/30081 ?


GameMoveHistory does not contain historical moves

When the board is initialized with a fen string, it doesn't contain the historical moves.
I don't think it needs to be solved, but should be disclosed in the doc.

That's true, a fen string doesn't contain any move info so it cannot recreate the historical moves with that function. I'll think about adding it to the docs, thanks for the suggestion.


There are no numbers for axis on android

Before filing an issue please ensure the following boxes are checked, if applicable:
Hi I'm using react-native 0.32, and there are no numbers for axis on android, only one in top left corner.
I checked for bar graph... there are also no labels on axis...

We just updated the version of react-native-pathjs-charts and it now has updated versions of react-native and react-native-svg. These updates may address your issues. Try updating to this newer release and see if that helps. If it doesn't, could you include your sample code and data that produced the screenshot above?

I update to 0.37, the same thing... Here is my data:
stockLine: [[{"x":6,"y":58},{"x":7,"y":58},{"x":8,"y":83}]]; bar: [[{"name":"6","v":3},{"name":"7","v":3},{"name":"8","v":3}]]
Here is my Code:
export default class extends Component {
  constructor(props) {
    super(props);
    this.state = {
      stockLine: [[{
        "x": 0,
        "y": 0
      }, {
        "x": 1,
        "y": 1
      }, {
        "x": 2,
        "y": 2
      }]],
      bar: [[{
        "v": 0,
        "name": "0"
      }, {
        "v": 1,
        "name": "1"
      }, {
        "v": 2,
        "name": "2"
      }]]
    }
  }

  componentWillReceiveProps(nextProps) {
    /*... here some calculations*/
  }

  shouldComponentUpdate(nextProps, nextState) {
    /*... here some calculations*/
  }

  render() {
    return (
      <View style={styles.container}>
        <ScrollView style={{flex: 1}} contentContainerStyle={{justifyContent: 'center', alignItems: 'center'}}>
          <Text style={styles.graphTitle}>{I18n.t("graphTitleProgress")}</Text>
          {this.props.statisticalData.size < 3 ? <Text>{I18n.t("graphMinimum3Days")}</Text> :
            <StockLine data={this.state.stockLine} options={config.stockLine.options} xKey='x' yKey='y'/>}
          <Text style={styles.graphTitle}>{I18n.t("graphTitleActivity")}</Text>
          {this.props.statisticalData.size < 3 ? <Text>{I18n.t("graphMinimum3Days")}</Text> :
            <Bar data={this.state.bar} options={config.bar.options} accessorKey='v'/>}
          <Pie
            data={config.pie.data}
            options={config.pie.options}
            accessorKey="population" />
        </ScrollView>
      </View>
    );
  }
}

const styles = StyleSheet.create({
  container: {
    flex: 1,
    flexDirection: "row"
  },
  graphTitle: {
    fontSize: 14,
    padding: 10,
    fontWeight: "bold",
    color: "gray",
    textAlign: "center"
  },
  content: {
    flex: 1,
  }
});
```
`

Thanks for the example code and data. I am not seeing the same thing:

I got this screenshot by plugging in your MyNotesStatisticalPeriod.txt attachment into the example app for the project. I had to tweak your example slightly and hard code your example data above to make it work. My resulting tweaked file is here - index.android.js.txt
One obvious difference between my screenshot and yours is that you are using Genymotion and I'm not. Do you see other differences that may provide a clue to understanding the rendering difference?
Could you try using my tweaked file on your Genymotion-based setup and see if you see the same thing?  Do you have another example that may illustrate/reproduce the issue better?

I tried the real device android

... the same thing all numbers on the left top corner...

Would you be willing to embed/attach the Axis.js source you have? I'm not sure I understand what your "if in file Axis.js wrap tag with it" comment means.

I have a similar issue as SimchaShats again. The labels on the bar chart are not displaying at all. I have the latest version - 0.0.21 (downloaded today).
code:
export class ExpensesBarchart extends Component {
  render() {
    var data = [
        [{
          "amount": 700,
          "name": "1. week"
        }, {
          "amount": 1500,
          "name": "2. week"
        }, {
          "amount": 900,
          "name": "3. week"
        }, {
          "amount": 3000,
          "name": "4. week"
        }]
      ];

    var options = {
      width: 250,
      height: 250,
      color: '#2980B9',
      gutter: 20,
      animate: {
        type: 'oneByOne',
        duration: 200,
        fillTransition: 3
      },
      axisX: {
        showAxis: true,
        showLines: true,
        showLabels: true,
        showTicks: true,
        zeroAxis: false,
        orient: 'bottom',
        label: {
          fontFamily: 'Arial',
          fontSize: 8,
          fontWeight: true,
          fill: '#34495E'
        }
      },
      axisY: {
        showAxis: true,
        showLines: true,
        showLabels: true,
        showTicks: true,
        zeroAxis: false,
        orient: 'left',
        label: {
          fontFamily: 'Arial',
          fontSize: 8,
          fontWeight: true,
          fill: '#34495E'
        }
      }
    };

    return (
      <View style={ flex: 1, alignItems: "center", justifyContent: "center" }>
        <Bar
          data={data}
          options={options}
          accessorKey="amount" />
      </View>
    );
  }
}

result:

I am running it with Exponent (11.0.0) on Genymotion Android emulator (Google Nexus 5X - 6.0.0 - API 23).

@Jarda8 - I'm continuing to look at this issue, but for now I've found you can get the labels to display by setting the margin.left property at 25 or higher

@SimchaShats I am still unable to reproduce your issue with all the numbers squeezed in the top left corner along the y axis. The previous code and data samples you gave didn't match the screenshot you had previously, so I tried modifying the data to match your screenshot and I still couldn't reproduce it (but I did see another bug which I put in #18).
I'm guessing I'm missing something you have in the data/code you are working with, could you try including your code & data that produces the result above?
The code/data I am working with that displays labels along the y axis correctly is:
import React from 'react';
import { AppRegistry, View } from 'react-native';
import {StockLine} from 'react-native-pathjs-charts';

export class StockLineExample extends React.Component {
  render() {
    var data = [[{"x":3,"y":71},{"x":6,"y":75},{"x":7,"y":61}]];

    var options = {
      width: 275 ,
      height: 200,
      color: '#2980B9',
      margin: {
        top: 20,
        left: 20,
        bottom: 20,
        right: 15
      },
      animate: {
        type: 'delayed',
        duration: 200
      },
      axisX: {
        showAxis: false,
        showLines: true,
        showLabels: true,
        showTicks: true,
        zeroAxis: true,
        orient: 'bottom',
        tickValues: [],
        label: {
          fontFamily: 'Arial',
          fontSize: 8,
          fontWeight: true,
          fill: '#34495E'
        }
      },
      axisY: {
        showAxis: false,
        showLines: true,
        showLabels: true,
        showTicks: true,
        zeroAxis: true,
        orient: 'left',
        tickValues: [],
        label: {
          fontFamily: 'Arial',
          fontSize: 8,
          fontWeight: true,
          fill: '#34495E'
        }
      }
    };

    return (
      <View style={{flex:1,alignItems:"center",justifyContent:"center"}}>
        <StockLine
          data={data}
          options={options}
          xKey='x' yKey='y' />
      </View>
    );
  }
}

AppRegistry.registerComponent('example', () => StockLineExample);

Hmmm... I think it's not related to data set, because I tried different data and also other graphs like bars and pie have all numbers in the left top corner(pie has names in the left top corner)... May be it's related to parent container of my component, I think I'll need to try your code sample to run in separate file...

I had exactly the same problem with labels being displayed in the top left corner, but it changed after the update to version 0.0.21.

@Jarda8 Thanks, I did it last time but it didn't help... now I removed ALL node_modules, and cleaned project and now this helped(install new dependencies (0.0.21)

If we set margin left(for left labels visible) then axisX seems like have setted margin left too and it looks not as fine as we would like, it's not centered under each bar

@kasterlod I don't see the connection between your issue and this #11 issue you expanded on. Could you open a new issue?

yes, sorry


[MS Teams] How to configure Card action buttons in O365ConnectorCard to send reply to bot?

Bot Info

SDK Platform:  .NET
SDK Version:
Active Channels:

Issue Description
I have used "Microsoft.Bot.Connector.Teams.Shared" project to send O365ConnectorCard in MS teams but I not able to send card action button like  invoke, imBack, messageBack
.
Expected Behavior
I want to implement card action buttons in O365ConnectorCard
as mentioned in https://msdn.microsoft.com/en-us/microsoft-teams/botsmessages#buttons
because I want get reply to my Bot api endpoint using invoke card action buttons like messageBack, invoke etc
As in attached code when user insert comment and click on button it should send to bot API endpoint like  invoke, imBack, messageBack
Code
code.txt

Closing as the conversation has been taking place here  and this is not currently a feature in teams, but will be soon.


Remove python version from pyproject

This addresses the hatch issue with specifying the Python version - I get exactly the same error (on Python 3.11) as described here: https://github.com/pypa/hatch/issues/906
The workaround is to remove the Python version from the pyproject.toml

It's weired we had to return this line as it doesn't work without it. Let's wait for the upstream fix..


Change some pure compilation tests into runner tests

The code is easier to maintain when its not in C strings so we
decided to transition any that are only "does it compile" tests.
When moving these that previously stopped at a given pass, a decision
was made to add a stub actor Main to them. It was either this
or enhancing the runner to be able to only run through a specific pass.
I decided that the actor Main stub is better for testing as it
gives us continued coverage that things work even if changes come
in a later pass or the functionality tested moves to a later pass.

This transition is going to take a long time. I have done a bit of it in this PR and am stopping for now. I'm opening the PR so these changes can be integrated as soon as possible and we can hopefully avoid integration conflicts that would come from a long-lived branch.

Some of our "compilation only" tests are not valid pony code. 4 tests in this PR I had to change to be valid Pony code. Before this is merged, I want to make sure that we are comfortable with the change.

Thanks @EpicEric, those binaries have been removed.


SASsimulation popup and improvements

merge the changes from SASgame into SASsimulation, cleaning up duplicate code and unneeded blocks in the process, and various improvements to SASgame/SASsimulation

Major changes
SASsimulation

popup boxes added
seeds can be loaded from csv file
unused code removed
random generation user params
...

SASgame

random generation user params
...

information

updated to reflect current states of game and sim


Cannot find module "."      after the "npm run build"

This happen when  i running "run start" or "run package", but all is working if I work in DEV mode (yarn dev).
This happens using the node-iohook module, which is a C ++ addon. I have tried this on a clean electron-react-boilerplate, only with this module and it fails.
Also I tried to build a simple example with this module (without electron-react-boilerplate) and it works.
the addon installed inside /app/
Electron 1.6.10
electron-react-boilerplate recent update
Some Idea what is wrong?
Thanks in advance!!
App threw an error during load Error: Cannot find module "."     at E:\fress\app\main.prod.js:1:15322     at Object.<anonymous> (E:\fress\app\main.prod.js:1:15392)     at Object../app/node_modules/source-map/lib/source-map/source-map-generator.js (E:\fress\app\main.prod.js:1:19201)     at o (E:\fress\app\main.prod.js:1:270)     at Object../app/node_modules/source-map/lib/source-map.js (E:\fress\app\main.prod.js:1:9391)     at o (E:\fress\app\main.prod.js:1:270)     at Object../app/node_modules/source-map-support/source-map-support.js (E:\fress\app\main.prod.js:1:8539)     at o (E:\fress\app\main.prod.js:1:270)     at Object../app/main.dev.js (E:\fress\app\main.prod.js:1:1147)     at o (E:\fress\app\main.prod.js:1:270)

I have created a simple example to reproduce the error without many complications
Simple example
git clone https://github.com/soyFerrero/sampleTest
npm dev   >> ok
npm build >> ok
npm start >> doesn't work
npm package >> doesn work

I finally created my own boilerplate.  I'm with an eye on this project in the future.

@soyFerrero  What was your solution to overcome this issue ?


Error when running npm install

Hi team,
I've been struggling for days to be able to install the dependencies for this starter kit.
Whenever I run the "npm install" command right after successful unboxing I get the following error:
`npm ERR! code 128
npm ERR! command failed
npm ERR! command git ls-remote<EMAIL_ADDRESS>npm ERR! fatal: Could not read from remote repository.
npm ERR!
npm ERR! Please make sure you have the correct access rights
npm ERR! and the repository exists.
npm ERR!      C:\Users\Mariano Collarte\AppData\Local\npm-cache_logs\2021-05-12T01_02_24_897Z-debug.log
`
I've setup the ssh account in my github profile and checked connection. This repository seems to be deprecated so I'm not sure why it is pulling it however the npm install fails and the node_modules folder is not being created.
Any help you can provide would be awesome!
Thanks

Thanks for making this issue. Could you try:

Installing yarn and then running yarn instead of npm install? https://classic.yarnpkg.com/en/docs/install/#mac-stable
Could you run the following

mkdir new-project
cd new-project
truffle unbox smartcontractkit/box
yarn

Thanks Patrick for the quick response!
That seemed to work (though I got a lot of warnings and some errors in the process) however now I do see the node_modules folder in my project.
Also, I was getting a timeout error fetching packages which I was able to resolve with the following command:
yarn install --network-timeout<PHONE_NUMBER>
Any idea why the npm install failed? Would you recommend yarn going forward?
Thanks!

Awesome! Glad it worked!
I'm not sure...  I've found yarn to be much more reliable on average over npm.

Closing as this is all set.


Upgrade go to 1.22.4

so we’re already building with 1.22.4 (see workflows and actions with setupgo). but if you want to start using 1.22 features (like the new http match handler or the new loops) you’ll also need to fix the lints (about said loop var changes)


Add max_frame_size support to fake TSI handshaker and fake HS service

Fake TSI handshaker and HS services are used in envoy unit/integration tests. Recently we wanted to add the support of setting max_frame_size to envoy: https://github.com/envoyproxy/envoy/pull/15297#discussion_r587056089, which needs the changes in this PR to verify its behavior.

Thanks for the review, Jiangtao.


Clarification, where does data-sketch-colors appear in Sketch?

Tried to ask this in the html-sketchapp-cli-repo, but no luck yet. Maybe you can answer this for me:
With this code:

      ...

        Crème brûlée, #FFE49C

      ...

Where does the colors appear in sketch? The symbol Colors/Main appears, but I can't see to locate where the colors are at. If I check "document colors" in the right pane for an element, it is empty.
https://github.com/seek-oss/html-sketchapp-cli/issues/60

Hey! Sorry for a late response. This is more of a html-sketchapp-cli question, but the colors should appear under 'global colors' as shown in this gif: https://github.com/brainly/html-sketchapp-style-guide


Fix EXTENSION_HOMEPAGE URL

I've tried the Stereotaxia module. It runs fine. Thanks for your work.
Must I be aware of questions, requierements, changes ?

Thanks.
El sáb, 25 de jun. de 2022 00:38, Andras Lasso @.***>
escribió:

You can view, comment on, or merge this pull request online at:
https://github.com/JBeninca/SlicerStereotaxia/pull/2
Commit Summary

c2806f9
https://github.com/JBeninca/SlicerStereotaxia/pull/2/commits/c2806f9952361320590f9248fa6f52d299f4758e
Fix EXTENSION_HOMEPAGE URL

File Changes
(1 file https://github.com/JBeninca/SlicerStereotaxia/pull/2/files)

M CMakeLists.txt
https://github.com/JBeninca/SlicerStereotaxia/pull/2/files#diff-1e7de1ae2d059d21e1dd75d5812d5a34b0222cef273b7c3a2af62eb747f9d20a
(2)

Patch Links:

https://github.com/JBeninca/SlicerStereotaxia/pull/2.patch
https://github.com/JBeninca/SlicerStereotaxia/pull/2.diff

—
Reply to this email directly, view it on GitHub
https://github.com/JBeninca/SlicerStereotaxia/pull/2, or unsubscribe
https://github.com/notifications/unsubscribe-auth/AJCTFRGCAHMRTTVNIUKZR4LVQZ5KVANCNFSM5ZZSH7WQ
.
You are receiving this because you are subscribed to this thread.Message
ID: @.***>


Add module to process NetCDF datetimes

Description

Process NetCDF datetimes in the form of an integer span and a string, containing the time unit and start time, to an ESMF_Time (start time) and an ESMF_TimeInterval (time span), with optional output of the time unit (as a string) and the end time (ESMF_Time). The end time is the time expressed by the NetCDF integer and string
Motivation and Context

This functionality allow better parsing of datetimes in NetCDF files
How Has This Been Tested?

The MAPL base and shared test suites completed successfully. This is a new feature, so it doesn't affect existing MAPL.
Types of changes

[ ] Bug fix (non-breaking change which fixes an issue)
[x] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)
[ ] Trivial change (affects only documentation or cleanup)

Checklist:

[x] I have tested this change with a run of GEOSgcm (if non-trivial)
[x] I have added one of the required labels (0 diff, 0 diff trivial, 0 diff structural, non 0-diff)
[x] I have updated the CHANGELOG.md accordingly following the style of Keep a Changelog

Don't merge yet. Changing branch to merge to.

OK. develop is base branch.

Abort. New PR. #2121.


[Bug] some charactere can't be show

when i use character like (é,à,ù) in my referenve file (csv) ;they doesnt appear on a text and a formatted text

Have you tried saving the CSV file as UTF-8 as described here: https://github.com/nhmkdev/cardmaker/wiki/user-utf8

I am going to close this out. If this is still not functional please re-open it.


Implementation of OC-Agent Trace Service clients.

Fixes https://github.com/census-instrumentation/opencensus-java/issues/1408.
Equivalent to https://github.com/census-ecosystem/opencensus-go-exporter-ocagent/blob/master/ocagent.go.
This works similarly to Go Agent exporter:

Export will be handled in the main thread. OC library (SpanExporter) pushes SpanData to ExportClient, then ExportClient translates them to SpanProto and pushes to Agent.
Config will be handled in a daemon thread, since waiting and applying incoming Config will block the thread.

Codecov Report

Merging #1476 into master will decrease coverage by 0.77%.
The diff coverage is 31.57%.

@@             Coverage Diff             @@
##             master   #1476      +/-   ##
===========================================
- Coverage     82.17%   81.4%   -0.78%
- Complexity     1564    1572       +8
===========================================
  Files           240     241       +1
  Lines          7333    7447     +114
  Branches        687     700      +13
===========================================
+ Hits           6026    6062      +36
- Misses         1097    1171      +74
- Partials        210     214       +4

Impacted Files
Coverage Δ
Complexity Δ

...ter/trace/ocagent/OcAgentTraceExporterHandler.java
0% <0%> (ø)
0 <0> (ø)
:arrow_down:

...census/exporter/trace/ocagent/TraceProtoUtils.java
85.71% <33.33%> (-1.79%)
36 <1> (+4)

...rter/trace/ocagent/OcAgentTraceServiceClients.java
34.73% <34.73%> (ø)
4 <4> (?)

...census/implcore/trace/export/SpanExporterImpl.java
90.41% <0%> (-2.74%)
8% <0%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b9facf9...2da6e5d. Read the comment docs.

Please ping me when this is ready for review.

Updated, PTAL. This works as follows:

In OcAgentTraceExporter.createAndRegister(), a OcAgentTraceExporterHandler will be created and registered to SpanExporter.
By the time when OcAgentTraceExporterHandler is created, a daemon thread AgentConnectionWorker will be created and started. This thread will be kept running forever. Every 5 minutes (or a custom time interval), it will try to connect to remote Agent.
If connection succeeded, SpanData passed to OcAgentTraceExporterHandler will be exported to Agent via RPC. AgentConnectionWorker will handle the UpdatedLibraryConfig.
If connection failed or lost, SpanData passed to OcAgentTraceExporterHandler will be ignored.

Rebased, PTAL.


Github doesn't return private user repositories

We use GET /users/{username}/repos which only returns the user's public repositories.
It seems we can use the search API to get the private repositories too https://api.github.com/search/repositories?q=user:USERNAME

Hey I was having this same issue and fixed it by installing the GitHub app I created onto my own GitHub profile. Then both the public and private repos were returned using this method: https://docs.github.com/en/rest/repos/repos#list-repositories-for-the-authenticated-user

Hope this helps! 🤞 I was banging my head against the wall for a while on this one 😅


[Android] Use a last scan date for email scanning

Reason
To avoid returning duplicate receipts we can use last scan date to only scan new emails
Description
Unlike with the retailer scanning, there is no Microblink provided latestOrdersOnly property. Instead, we can re-create this functionality using the searchUntil(Date) functionality and locally storing the latest scan date.
This should NOT replace the daysCutOff parameter, instead it should be used WITH. Where it will try can scan to the daysCutOff number unless the searchUntil date is sooner, then it should stop at that date.
*NOTE: Use the key prefix: tiki-capture-receipt.<key-name> to avoid any potential key collisions from using the shared storage. *
Success Criteria

[ ] On successful completion of a scan, record the scan start date to local storage
[ ] When scanning, use the searchUntil(Date) property to only scan up to the latest date (if exists)

Additional Information
No response

done in #350

It is not working async. Reopening.

fixed in #397


⚠ ClamAV has degraded performance

In 7928883, ClamAV (https://spamassassin.apache.org/) experienced degraded performance:

HTTP code: 200
Response time: 213 ms

Resolved: ClamAV performance has improved in 93d6126.


Answer vectors are order agnostic

Since in preprocessing.py method _index_answer generates the answer vectors by summing up the one-hot vectors of the answer words  for multi-answer questions, there is no information about the order preserved. Isn't this a problem especially for the validity on the path-finding task?

Hello, @MMMMasterM.
It is not necessary to preserve the order especially for the path-finding task.
For example, if an answer is (w,n) then (n,w) also can be a right answer :)


Time scrape metrics

Motivation
Prometheus metrics show that the scrape time of an overloaded node is ~10 sec. However, I did a CPU profile of that exact same node on such a scrape and internally it only takes ~35ms.

Description
Measure the scrape time of metrics to understand the cost of running metrics without the huge extra time that's introduced somewhere else.
Next steps

[ ] Understand why a 35ms scrape, causes the curl :/metrics to take 10 sec.

Tested locally and works as expected :+1:


Rule Proposal: Enforce JSX Presence in .tsx Files (no-tsx-without-jsx)

Description:
I would like to propose a new rule for eslint-plugin-react that enforces the presence of JSX elements in files with a .tsx extension. This rule would help maintain consistency and clarity in TypeScript projects using React or other JSX-based libraries.
Problem Statement:
Currently, it’s possible to create .tsx files without any JSX elements. This can lead to:

Confusion: Developers might use the .tsx extension unnecessarily for files that do not contain any JSX, potentially causing confusion about the file's intended purpose.
Consistency Issues: Keeping .ts and .tsx file distinctions clear ensures that the purpose of each file is easily understood by other developers working on the project.

Proposed Rule: no-tsx-without-jsx

This rule would throw an error if a file with the .tsx extension does not contain any JSX elements.
The rule would suggest renaming the file to a .ts extension if JSX is not present.

Example Use Cases:

Valid (Contains JSX):
// myComponent.tsx
import React from 'react';

const MyComponent = () =>
Hello, World!
;

export default MyComponent;

Invalid (No JSX, should be .ts):
// utilityFunction.tsx
export function utilityFunction() {
    return 42;
}

Benefits:

Improves Code Clarity: By ensuring that .tsx files contain JSX, the codebase remains easier to navigate and understand.
Encourages Best Practices: This rule will encourage developers to use .tsx only when necessary, and .ts otherwise, maintaining clearer file distinctions.
Aligns with TypeScript-First Principles: This rule fits well within a TypeScript-specific plugin, helping developers make the best use of TypeScript’s features and extensions.

Similar Rules and Why This Is Unique:

The react/jsx-filename-extension rule in eslint-plugin-react allows configuring when JSX is allowed in certain extensions but does not specifically target .tsx files and their usage within TypeScript projects.

Additional Context:
I have developed a prototype version of this rule in a custom ESLint plugin. You can check that at https://github.com/HesamSe/eslint-plugin-recommended/blob/main/src/rules/noTsxWithoutJsx.ts

seems like jsx-filename-extension could just be extended via an option to cover tsx.

@ljharb So, should I open another proposal or would this one be enough?

This one is fine.


Update service/client construction/destruction API return codes.

Connected to https://github.com/ros2/rmw/pull/276. Precisely what the title says.

CI up to test_rmw_implementation and rcl:

Linux
Linux-aarch64
macOS
Windows

CI up to test_rmw_implementation and rcl:

Linux
Linux-aarch64
macOS
Windows


Any way to split clientBundle into smaller chunks?

My icons bundle size is 1008KB. Mostly because of using icons from the "flags" collection, which is quite heavy.
I don't know if it's feasible, but a way to automatically split the bundled icons into smaller chunk would be awesome. Example in nuxt.config.ts:
icon: {
    clientBundle: {
      icons: iconsToBundle,
      scan: false,
      sizeLimitKb: 1100,
      splitLimitKb: 500, // 500 by default
    }
  },

Technically we could do that, but in order to know which icon from which bundle, we have to import all the bundles anyway. How would that be helpful to split if they are going to be downloaded anyway?

Well, first off, I'm not an expert, but from what I read when I was trying to improve my Nuxt app, I think I understood there are a few advantages  that improve both performance and user experience, as well as positively impacting SEO:

Parallel Downloads: Browsers can download multiple smaller chunks simultaneously, making better use of network resources. This means 4 chunks of 500 KB can be downloaded faster than 2 chunks of 1000 KB.

Efficient Code Splitting and Lazy Loading: Smaller chunks allow to load only the code that's needed at any given moment, reducing the initial load time and speeding up the rendering of the page. This is crucial for improving the Time to Interactive (TTI) for users.

Better Caching: When we deploy updates, only the modified chunks need to be re-downloaded. This results in more efficient caching and less data usage for our users, as they can reuse the existing cached chunks.

Improved Error Recovery: If a network error occurs while loading a chunk, smaller chunks reduce the impact since only the affected chunk needs to be reloaded, instead of a large one.

Initial Page Load Performance: The user experience benefits from smaller chunks because the browser can start rendering and interacting with the page faster, reducing the initial load time.

SEO Advantages: Page speed is a crucial factor for search engine rankings. By reducing the size of our chunks, we can improve the overall loading speed of the page, which directly influences our SEO performance. Faster load times lead to higher rankings in search engines like Google, as they prioritize pages that provide a better user experience.

Disclaimer: I asked chatgpt to make that summary, so I apologize if it is inaccurate. At least it reflects the stuff I read in several articles about improving Nuxt performance for web vitals😅