when to use flatmap vs map

hi why do we use map instead of flatmap here? Is it because we are supposed to get Optional instead of PA, which is why we use map? in that case, why not use flatmap for the second map? thanks!

i think you're right that the first map is supposed to get a Optional. for the second map, its aim is to map a PA to a Optional, such that x will eventually become a Optional from a optional. it wouldnt make sense to use flatmap for the second map since its not right to say that you flatten a PA into an optional
this is my understanding, hope that helps!

ah i see thank you!


Rebuild avatar

Fixes #4
Signed-off-by: Elijah J. Passmore<EMAIL_ADDRESS>

Any chance we can get this merged? This is blocking my use of this framework

Hi, sorry for the delay! I'll check your PR tomorrow and eventually merge/publish a new version of the package.
Thanks for the feedback!


fix string to turn on auto close

this string in example will turn on github auto close functionality.

@abumami please take a look


Broken GitHub link displayed on user page when user hasn't linked their GitHub account

Fixed by d7bce7d


Document default-role and allowed roles for registration on the nhost-js-sdk.

Documented here: https://docs.nhost.io/platform/authentication/users#roles


siac host output should warn if wallet is locked

Can the output of siac host -v warn the user if they're accepting contracts but their wallet is locked? Currently, it prints out this:
$ siac host -v
General Info:
        Estimated Competitive Price: 8.728 KS

Host Internal Settings:
        acceptingcontracts:   Yes

This is misleading because if the host's wallet is locked, they're not really accepting contracts.

Yeah. In general I think Sia doesn't have enough warnings if the user is shooting themselves in the foot.
If your wallet is locked the renter can't replace dud hosts.
If your wallet is locked the host can't form new contracts.
You host may be set to 'acceptingcontracts: No' but you don't want it that way (maybe some misconfiguration happened or something),
etc.
We should be able to flag the user's attention if they are doing something that seems undesirable.


Enhancement: statically link Windows C++ runtime

I ran into a very strange issue when upgrading from<EMAIL_ADDRESS>to<EMAIL_ADDRESS>on Windows.
Error:
Something went wrong installing the "sharp" module

The specified module could not be found.
\\?\C:\...\node_modules\sharp\build\Release\sharp-win32-x64.node

But when I check the diorectory the module exists
ls node_modules\sharp\build\Release

    Directory:
C:\...\node_modules\sharp\build\Release

Mode                 LastWriteTime         Length Name
----                 -------------         ------ ----
-a---            2/1/2022 10:49 AM        1580544 libglib-2.0-0.dll
-a---            2/1/2022 10:49 AM         292352 libgobject-2.0-0.dll
-a---            2/1/2022 10:49 AM       20575232 libvips-42.dll
-a---            2/9/2022  5:47 PM         257024 libvips-cpp.dll
-a---            2/9/2022  5:47 PM         226304 sharp-win32-x64.node

I also check other Issues I found related to this

I don't have canvas installed
Deleting _prebuilds doesn't help
Installing with different flags doesn't help

The only thing that worked was downgrading to<EMAIL_ADDRESS>again.
System Info:
npx envinfo --binaries --system

  System:
    OS: Windows 10 10.0.19043
    CPU: (2) x64 Intel(R) Celeron(R) CPU G3900 @ 2.80GHz
    Memory: 7.34 GB / 11.87 GB
  Binaries:
    Node: 16.14.0 - C:\Program Files\nodejs\node.EXE
    Yarn: 1.22.15 - C:\Program Files\nodejs\yarn.CMD
    npm: 8.3.1 - C:\Program Files\nodejs\npm.CMD

Do you have any other dependencies in the same node_modules directory that use sharp? What's the output of npm ls sharp?

I have the same issue. Output for npm ls sharp is:
└──<EMAIL_ADDRESS>
No other module uses sharp.

FYI works for me on linux

any news on this?

I don't have the issue on my windows machine 🤔 - what about npm rebuild sharp

The two main reasons for seeing this error on Windows are:

canvas is also a dependency - see https://sharp.pixelplumbing.com/install#canvas-and-windows for why this won't work.
conflicts with older versions of sharp in the dependency tree - ensure npm ls sharp and npm ls -g sharp only shows the latest version.

The latest v0.30.1 now represents over 10% of downloads from npm so I'd expect a lot more noise if this affected everyone.
The classic manoeuvre of deleting the node_modules directory and running npm install again is, I believe, still a thing, so please try that too.

I'm on holiday right now and don't have access to the machine in question.
(I'm normally running Linux without any problems.)
But I also tired to delete the node_modules already, that was why I was confused the the file in question actually existed.
When I ran yarn why sharp it only showed the direct dependency.
Maybe it just works again when I try again when I'm back.
(For now downgrading also works for me, so no worries ☺)

thank you for your time @lovell
results from npm ls sharp and npm ls -g sharp are:

other things that I tried inclued:

removing node_modules
npm install --platform=win32 --arch=x64 sharp
npm install --ignore-scripts=false --verbose sharp
used diferent versions of node, tried with LTS 12, 14 and 16

"The specified module could not be found" error can usually be easily analyzed with the Dependencies program (a rewrite of the legacy Dependency Walker). Open node_modules/sharp/build/Release/sharp-win32-x64.node, you should see something like this:

Perhaps Microsoft C and C++ (MSVC) runtime libraries are not installed on your system (the msvcp140.dll, vcruntime140.dll and vcruntime140_1.dll DLLs)? Since commit https://github.com/lovell/sharp/commit/659cdabd8e8c284901a0ea17ccdcb13e17350a8e, these DLLs are dynamically linked (with the /MD option instead of /MT).

Thanks Kleis, I had thought Windows 10 now provides runtime libraries as standard, but it looks like that may be only for C and not C++. That would explain why this is only affecting a few people, as many Windows apps require/install the C++ runtime.
Do we lose the improved error handling introduced in https://github.com/lovell/sharp/commit/659cdabd8e8c284901a0ea17ccdcb13e17350a8e if we revert to static linking?

Indeed, when compiling with Visual Studio (and using the /MD option) it links against the non-universal Visual C++ CRT dependency that is not preinstalled on Windows 10.
The improved error handling disappears if we revert to static linkage, I had tested that at the time with this gist:
https://gist.github.com/kleisauke/6526f33f6ea77a1216ca3a1222417799
There may be another way to solve this though, by setting up an empty invalid parameter handler during vips_init() (guarded with defined(G_OS_WIN32) && defined(_UCRT)) it will set the handler local to that instance of the DLL (libvips-42.dll and dependencies), which should also ensure that the application does not abort on invalid parameter calls.
We might also consider reverting commit 659cdabd8e8c284901a0ea17ccdcb13e17350a8e altogether (except for the added test case) and try to fix any invalid parameter calls in libvips (if any, just like PR https://github.com/libvips/libvips/pull/2571). I think this policy is similar to GLib where they use an empty invalid parameter handler only when necessary, see for example:
https://github.com/GNOME/glib/blob/b3311e82ee04c90136ff231358d356e8e587f4da/glib/gmessages.c#L2117-L2122
https://github.com/GNOME/glib/blob/ebf64a5024e4cf10af94632aede32ea211efe700/glib/gspawn-win32-helper.c#L222-L225

thanks for the response @kleisauke, used Dependencies and it seems like it's missing one of the dlls you've mentioned.

will try to install missing dependencies in a couple of hours and report it later!

Ok, problem solved. MSVC was already installed so I had to download the dll separately.
Thanks!

Thanks all, let's revert https://github.com/lovell/sharp/commit/659cdabd8e8c284901a0ea17ccdcb13e17350a8e and if we need to add any new Windows-specific error handling, can do so in the C layer of libvips rather than C++ of sharp.

This did not fix it for me but the error did change since "0.30.1" from:
Something went wrong installing the "sharp" module The specified module could not be found.
to
Error: The specified procedure could not be found.    \\?\E:\...\Gatsby\...\node_modules\lmdb\build\Release\lmdb.node

@SergiOca87 When you say "This did not fix it", does "this" refer to you having installed the Windows C++ runtimes?

v0.30.2 now available, I'm going to close this.
Any remaining errors that look like this will probably be due to one of the two common problems detailed in https://github.com/lovell/sharp/issues/3086#issuecomment-1049154853

v0.30.2 now available, I'm going to close this.
Any remaining errors that look like this will probably be due to one of the two common problems detailed in #3086 (comment)

I am now getting:
Error: Cannot find module 'detect-libc' npm ERR! Require stack: npm ERR! - C:\Users\...\node_modules\gatsby-plugin-wpgraphql-seo\node_modules\sharp\install\libvips.js
After updating the Windows C++ runtimes

@SergiOca87 Please open a new installation issue and answer all of the questions if you still require help.

This error occurs when I want to run.

When I try: npm install --platform=win32 --arch=x64 sharp
The same error occurs again.
What shall I do?


2.3 Release Notes are missing some experimental features

There are several new experimental features in MRTK that would be good to mention in the release notes, especially because they contain new UX elements.

(Experimental) Non-native keyboard  #6492

(Experimental) Hand coach #6493

(Experimental) Follow solver (solver that matches HoloLens 2 shell behavior). #6981

(Experimental) ObjectManipulator #6924 (@thalbern can you add image please?)

(Experimental) BoundsControl #6924 (@thalbern  can you add image please?)

@thalbern  all good -- i got images for objectmanipulator from @MenelvagorMilsom


Add sample for analytics carousel tracking

Depends on #4292.
@camelburrito can you ping me once it's ready?

Done.


Add a description to CallBatch.push and related functions

CallBatch aggregates governance calls for cross-chain sending and produces JSON of it. but it's opaque and difficult to verify. Add an optional description arg to the push functions that stores a text description of the tx on the callbatch

Hi @prestwich, I know some devs who'd be interested in working on this. Is there a budget for fixing this issue, and if so, how much?
I'd put this issue up on OpenQ.
Thanks!


SVG text size out of order

Describe the bug
When I use SVG text in the slide, the text size is out of order.
To Reproduce
Steps to reproduce the behavior:

Insert an SVG with text in one page.
Refresh the page.
The text is extremely large.
After switching to another page and then back, the text size is normal.

Desktop (please complete the following information):

OS: MacOS 10.15.7
Browser: Chrome
Slidev version: 0.40.3

We temporarily close this due to the lack of enough information.
Please provide a minimal reproduction to reopen the issue.
Thanks.

Why reproduction is required

We temporarily close this due to the lack of enough information. Please provide a minimal reproduction to reopen the issue. Thanks.

Why reproduction is required

Apologies for the inconvenience. Here are the detailed steps to reproduce the issue:

Create a new slidev project using the command:

slidev

Edit slides.md file as shown below:

---

# Cover

---

# Page

<svg style="background: black">
        <text dominant-baseline="hanging" fill="white">Text</text>
</svg>

Open the second slide directly in Chrome (i.e., without going from the first slide to the second) by visiting http://localhost:3030/2. You will notice that the text size is extremely large.
If you go back to the first slide and then switch to the second slide again, the text size returns to normal.

This bug appears to occur in Chrome, but Safari appears to work correctly.
Please let me know if you need any further assistance.

We temporarily close this due to the lack of enough information. Please provide a minimal reproduction to reopen the issue. Thanks.

Why reproduction is required

It seems that I do not have permission to reopen the issue. May I ask if you can see my reply?

@AnnyTerfect  what do you mean with "the text size is out of order" ?
I try to reproduce using MDN example of dominant-baseline: https://developer.mozilla.org/en-US/docs/Web/SVG/Attribute/dominant-baseline
Slide:

# SVG

<svg viewBox="0 0 200 120" width="500">
  <path d="M20,20 L180,20 M20,50 L180,50 M20,80 L180,80" stroke="grey" />
  <text dominant-baseline="auto" x="30" y="20">Auto</text>
  <text dominant-baseline="middle" x="30" y="50">Middle</text>
  <text dominant-baseline="hanging" x="30" y="80">Hanging</text>
</svg>

Result:

Can you share a screenshot of what's wrong ?

@tonai  I apologize for not being clear in my previous message. Here are the screenshots that illustrate the issue:

In the first screenshot, you can see that when I visit http://localhost:3030/2 directly, the text size is disorderly much larger than normal.

In the second screenshot, I switched from the first page and then went back, and the text size returned to normal.

The code I used is as follows:
---

# Cover

---

# Page

<svg style="background: black">
        <text dominant-baseline="hanging" fill="white">Text</text>
</svg>

I hope that helps clarify the issue.

Ok, I didn't understand the problem because I am not able to reproduce it in fact.
The font size is always correct whether I refresh or change the page.
I am on Ubuntu 22.04 with Chrome 109.


changed the transaction/frequeny button for tab issues

tab-issue-fixed

Dowe really need this? I think RadioButton is fine

Dowe really need this? I think RadioButton is fine

YESSssss cause the radio button couldn’t be switched with the tab md hence we had accessibility problems


how do i make the glow in the note assets

for the normal note style

guys i figured it out
you need 3 layers, the bottom one is the strumline note and the other ones are the "to hit" note. make the 2 "to hit" note layers use additive blending, then blur them both, one slightly and the other a lot


Proposal to Create wasi-virt

Proposal to Create wasi-virt
This document is a proposal to create wasi-virt as a formal (Hosted) Project under the auspices of the TSC of the Bytecode Alliance, as specified in the TSC Charter.
Project Summary
WASI Virt is a project that provides many different adapters that are simply composed. Similar to the wasm-tools project, this project will be in a monorepository and contain many different implementations. Individual virtualization adapters may need to work in concert with others, e.g. a virtualized blobstore may use a virtualized filesystem.
A key feature of the proposed WebAssembly Component Model is virtualizability of components, see the link-time virtualization example. Virtualized components will aid the WebAssembly community in enhancing WebAssembly's key value propositions of embeddability and language neutrality.
Existing Resources

wasi-vfs

Governance Summary
This project will begin with maintainers from the wasi-vfs project and additionally add maintainers of two other Bytecode Alliance projects, @peterhuene (cargo component) and @guybedford (jco). This representation from multiple organizations and language ecosystems will be a key component of this project.
Software Development Process
The project will meet the passing criteria for the OpenSSF best practices badge. Pull requests, issues, CI, and release management will be performed via GitHub.
Alignment with Bytecode Alliance Mission and Goals
Bytecode Alliance projects represent the mission and goals of the Bytecode Alliance itself.
We understand that as a Bytecode Alliance project, our project must adhere to the TSC Charter and other governing documents (such as the Security Policies and IP Policy).
As a Bytecode Alliance project, our project's source code and other pieces of intellectual property will be assigned to the Bytecode Alliance.
We understand and agree that:

All code for this project must be under the Apache v2 License with the LLVM exception, unless an exception is required for compliance with existing licensing, and granted by the Bytecode Alliance's board of directors per IP Policy §4. If our code is not already licenses accordingly, we will take the necessary steps to correct this prior to becoming a Bytecode Alliance Project.
We will comply with the Security Policies.
Project name, trademarks, logos, wordmarks, and other intellectual property other than source code and documentation copyright is assigned to Bytecode Alliance per the IP Policy.
Social media handles, GitHub repository access, and other relevant communication and coordination platforms will be overseen by Bytecode Alliance. Administrative/Owner permissions will be granted to the Bytecode Alliance for all such accounts.
We will abide by the definition of a project as set forth in the TSC Charter.
This project must remain under active development or maintenance, or it may be archived by the Bytecode Alliance.
This project may be reviewed from time to time by the TSC, and project maintainers will assist with this review process.
Project members will be able to participate in Bytecode Alliance governance, as specified in the TSC Charter and other governing documents.

Supporting Members
The following individuals support the creation of wasi-virt:

Guy Bedford (Fastly)
Bailey Hayes (Cosmonic)
Peter Heune (Fastly)
Yuta Saito (GoodNotes)

Approved today by the TSC and the project repository has now been created. Bootstrapping the project is now underway.


Categories

Thinking we will need more categories... existing will get busy quickly.
Of the top of my head...
Control = Lighting/Motion/presencel/Locks
Convience = catch all
Intergrations =- devices/applications/services
Notifications = speakers/tts/music
Security = presence/camera/sensors
Ulitlity = Data/Button controllers/IR control
What's missing.... ?

I agree. Honestly I hate categories because people will never guess correctly, but I don't really have a better solution...
I think that's a good start though. Anyone else have any suggestions?


docs: add Zeno example to Docker Spaces examples

Add an entry to the Docker spaces examples for the Zeno evaluation framework: zenoml.com

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint.


docs: Document running via kubeconfig on EKS

We now support using any kubeconfig to run tests, similar to sshconfig.
More steps are required but they are not complex.

This change is

test-docs-please

Coverage decreased (-0.003%) to 46.061% when pulling 0ba1f4e1cb05c7709a7b1df90c513867b5c963c3 on raybejjani:ci-eks-instructions into f694b3ba28ac2936c413fddec7771ef14a2c8808 on cilium:master.

test-docs-please


Should accessURL be a mandatory attribute in the SP config?

Right now accessURL is mandatory if only the Service Provider is discoverable.
accessURL is required to avoid other issues like,

To avoid bookmark issue
To avoid browser back button issue
To avoid redirecting to dashboard\user-portal after self-registration with email validation.
etc.

Thus, IMO accessURL should be a mandatory attribute in Service Provider.
Along with that, for better UX, it can make imageURL also mandatory. So all related UIs can use SP logo in consistent way without depending whether application is discoverable or not.

+1. Better make this mandatory.

@darshanasbg What exactly meant by discoverable in this context?
Also, IMO keeping the imageURL should be kept optional and not a mandatory step in creating the SP.

It makes sense to make the accessURL mandatory.
But I am having an opinion on the ImageURL.

So all related UIs can use SP logo in consistent way without depending whether application is discoverable or not.
Can't we have a generic image if the application specifies one? That way all apps will have an image.

It makes sense to make the accessURL mandatory.
But it doesn't sound right to mandate the imageURL.

So all related UIs can use SP logo in consistent way without depending whether application is discoverable or not.

Can't we have a generic image if the application doesn't specify an imageURL? That way all apps will have an image.

We do have this support, from the places we show the application image..

This issue is being closed due to extended inactivity. Please feel free to reopen it if further attention is needed. Thank you for helping us keep the issue list relevant and focused!


polyglot text schema looks wrong

if I in-line define a param name like this:
"button": {
            "type":"INT32",
            "name": {"display_strings": {"en": "Button", "es": "Botón", "fr": "Bouton"}},
            "value": {"int32_value": 0}
        },

the validator fails:
applying: device schema to input file /Users/jnaylor/Projects/Catena/sdks/cpp/connections/gRPC/examples/status_update/device.status_update.json
must NOT have additional properties at /params/button/name/display_strings on lines 68-72
must have required property '$key' at /params/button/name/display_strings on lines 68-72
must match a schema in anyOf at /params/button/name/display_strings on lines 68-72
must NOT have additional properties at /params/button/name/display_strings on lines 68-72
must have required property '$key' at /params/button/name/display_strings on lines 68-72
must match a schema in anyOf at /params/button/name/display_strings on lines 68-72
must match exactly one schema in oneOf at /params/button on lines 65-77
I have to make add a $key like this:
"button": {
            "type":"INT32",
            "name": {"display_strings": {"en": "Button", "es": "Botón", "fr": "Bouton", "$key": "button"}},
            "value": {"int32_value": 0}
        },

weirdly, this validates ok:
        "button": {
            "type":"INT32",
            "name": {"display_strings": {"en": "Button"}},
            "value": {"int32_value": 0}
        },

The issue here is that "fr" hasn't been added to the regex of the language metadata table, so the schema instead interprets it as a language pack reference which requires a "$key"
Assuming this is the expected behavior for language pack references I will leave the schema as is. I will try make the error message more descriptive to avoid confusion in the future.

Good catch! Add fr
Get Outlook for iOShttps://aka.ms/o0ukef

From: johndanenRV @.>
Sent: Thursday, July 25, 2024 3:07:30 PM
To: rossvideo/Catena @.>
Cc: John Naylor @.>; Author @.>
Subject: [EXTERNAL] Re: [rossvideo/Catena] polyglot text schema looks wrong (Issue #216)
The issue here is that "fr" hasn't been added to the regex of the language metadata table, so the schema instead interprets it as a language pack reference which requires a "$key"
Assuming this is the expected behavior for language pack references I will leave the schema as is. I will try make the error message more descriptive to avoid confusion in the future.
—
Reply to this email directly, view it on GitHubhttps://github.com/rossvideo/Catena/issues/216#issuecomment-2251308063, or unsubscribehttps://github.com/notifications/unsubscribe-auth/A6R5EENFAHBOJ4UBGROZFWDZOFLIFAVCNFSM6AAAAABLPBHUDKVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDENJRGMYDQMBWGM.
You are receiving this because you authored the thread.Message ID: @.***>

This e-mail and any attachments may contain information that is confidential to Ross Video.
If you are not the intended recipient, please notify me immediately by replying to this message. Please also delete all copies. Thank you.

and language_pack_reference needs an "additional_properties": false in the schema.


Change the IDs used for registering modifier operations

This PR changes the identifier (more specifically, the namespace) of the modifier operations. This uses the https://github.com/apace100/calio/commit/bd127726bea8da5e1a17965d8667637106aacef3 build of Calio, which implements a new data type, SerializableDataType#defaultedRegistry, similar to SerializableDataType#registry but with a default namespace

This now uses the https://github.com/apace100/calio/commit/68f2f8a46c113a9d9bb9ffc8994de1baae582fdf build of Calio, which expanded the SerializableDataType#registry data type


Removed to migration to docs.instructlab.ai

Removed the files in progress to docs.instructlab.ai
This should not merge until https://github.com/instructlab/dns-zones/pull/4 is merged.

https://github.com/instructlab/docs.instructlab.ai/commit/1d03aa017fb8ab5e7be2915f950123dcca9fd442

@jjasghar is this good to go?

Not yet, I think @lhawthorn is waiting on some legal sign offs before we can do it "across the project"


Cannot contribute the Nov. 11 update using the instructions

The Wineskin links for the newest mandatory update  are not from Google Drive, but rather from Mega.nz and sync.com respectively.
Is it possible to edit the install script to support one of those instead?

Any place that supports direct downloads should be easy to add, sure.
Ill take a look at it soon :)

Hey, I added support for mega.nz links, also updated the direct url with the latest version. if you update it should just work (tm).
I don't know how to get sync.com working tho. Similarly to mega.nz they do some clever encryption but thats a bit over my head and couldn't find a reference for it.


Add n-ary typeclass constructor.

This adds n-ary typeclass constructors with an associated test.

Really not liking the dummy value in the quasiquote required for scala 2.10.6 but it doesn't work when I don't put it in.

@yilinwei Wow, this is awesome!


SQLBuilder parentheses management question

Hi,
I'm trying to use SQLBuilder to generate SQL like:
(col1 = 't1' OR col2 = 't2') AND (col3 = 't1' OR col4 = 't2')
Is there a way to deal with it without writing it as String?
Thanks!

How might you propose doing it?  SQL statement after all is a big string.

I agree that at the end, this will only be a big string and maybe the added complexity to support this simply not worth it.
Here is 2 ideas for brainstorming only:
Idea 1
Method public String ENCLOSED_OR(String ... conditions)
WHERE(ENCLOSED_OR("col1 = 't1'", "col2 = 't2'"))
WHERE(ENCLOSED_OR("col3 = 't1'", "col4 = 't2'"))

But, that might be confusing for users that could use it like the OR() method. At the end, the user (e.g. me) can always create that method.
Idea 2
ENCLOSED_OR operator
WHERE("col1 = 't1'")
ENCLOSED_OR();
WHERE("col2 = 't2'")
WHERE("col3 = 't1'")
ENCLOSED_OR();
WHERE("col4 = 't2'")

But, more difficult to implement.
Just ideas.


Gradle warning on build.

From @jonatasfreitasv on May 9, 2017 18:50
The Task.leftShift(Closure) method has been deprecated and is scheduled to be removed in Gradle 5.0. Please use Task.doLast(Action) instead.
Ionic version:  (check one with "x")
[ ] 1.x
[ ] 2.x
[X] 3.x
I'm submitting a ...  (check one with "x")
[X] bug report
[ ] feature request
[ ] support request => Please do not submit support requests here, use one of these channels: https://forum.ionicframework.com/ or http://ionicworldwide.herokuapp.com/
Current behavior:
On build.
Steps to reproduce:
ionic cordova run android --device --prod
Other information:

Ionic info:
global packages:

    @ionic/cli-utils : 1.0.0-rc.2
    Cordova CLI      : 7.0.0
    Ionic CLI        : 3.0.0-rc.2

local packages:

    @ionic/app-scripts              : 1.3.7
    @ionic/cli-plugin-cordova       : 1.0.0-rc.2
    @ionic/cli-plugin-ionic-angular : 1.0.0-rc.2
    Ionic Framework                 : ionic-angular 3.1.1

System:

    Node       : v7.5.0
    OS         : macOS Sierra
    Xcode      : Xcode 8.2 Build version 8C38
    ios-deploy : 1.9.1
    ios-sim    : 5.0.13

Copied from original issue: driftyco/ionic#11581

@jonatasfreitasv This seems to be an issue with your Cordova/Android environment. If you post the entire error, maybe I can help further.

@dwieeb still facing same

    ANDROID_HOME=d:\Software\adt-bundle-windows-x86-20130917\sdk
    JAVA_HOME=c:\Program Files\Java\jdk1.8.0_131
    Subproject Path: CordovaLib
    The Task.leftShift(Closure) method has been deprecated and is scheduled to be removed in Gradle 5.0. Please use
    Task.doLast(Action) instead.
            at build_4mfq1tb3xhauwqpc0r8whi73n.run(D:\malkiat\Jack\test\loginApiTest\platforms\android\build.gradle:137)
    The JavaCompile.setDependencyCacheDir() method has been deprecated and is scheduled to be removed in Gradle 4.0.
    Incremental java compilation is an incubating feature.
    The TaskInputs.source(Object) method has been deprecated and is scheduled to be removed in Gradle 4.0. Please
    use TaskInputs.file(Object).skipWhenEmpty() instead.
    :preBuild UP-TO-DATE
    :preDebugBuild UP-TO-DATE
    :checkDebugManifest
    :CordovaLib:preBuild UP-TO-DATE
    :CordovaLib:preDebugBuild UP-TO-DATE
    :CordovaLib:checkDebugManifest
    :CordovaLib:prepareDebugDependencies
    :CordovaLib:compileDebugAidl UP-TO-DATE
    :CordovaLib:compileDebugNdk UP-TO-DATE
    :CordovaLib:compileLint UP-TO-DATE
    :CordovaLib:copyDebugLint UP-TO-DATE
    :CordovaLib:mergeDebugShaders UP-TO-DATE
    :CordovaLib:compileDebugShaders UP-TO-DATE
    :CordovaLib:generateDebugAssets UP-TO-DATE
    :CordovaLib:mergeDebugAssets UP-TO-DATE
    :CordovaLib:mergeDebugProguardFiles UP-TO-DATE
    :CordovaLib:packageDebugRenderscript UP-TO-DATE
    :CordovaLib:compileDebugRenderscript UP-TO-DATE
    :CordovaLib:generateDebugResValues UP-TO-DATE
    :CordovaLib:generateDebugResources UP-TO-DATE
    :CordovaLib:packageDebugResources UP-TO-DATE
    :CordovaLib:processDebugManifest UP-TO-DATE
    :CordovaLib:generateDebugBuildConfig UP-TO-DATE
    :CordovaLib:processDebugResources UP-TO-DATE
    :CordovaLib:generateDebugSources UP-TO-DATE
    :CordovaLib:incrementalDebugJavaCompilationSafeguard UP-TO-DATE
    :CordovaLib:compileDebugJavaWithJavac UP-TO-DATE
    :CordovaLib:processDebugJavaRes UP-TO-DATE
    :CordovaLib:transformResourcesWithMergeJavaResForDebug UP-TO-DATE
    :CordovaLib:transformClassesAndResourcesWithSyncLibJarsForDebug UP-TO-DATE
    :CordovaLib:mergeDebugJniLibFolders UP-TO-DATE
    :CordovaLib:transformNative_libsWithMergeJniLibsForDebug UP-TO-DATE
    :CordovaLib:transformNative_libsWithSyncJniLibsForDebug UP-TO-DATE
    :CordovaLib:bundleDebug UP-TO-DATE
    :prepareOrgApacheCordovaCordovaLib623DebugLibrary UP-TO-DATE
    :prepareDebugDependencies
    :compileDebugAidl UP-TO-DATE
    :compileDebugRenderscript UP-TO-DATE
    :generateDebugBuildConfig UP-TO-DATE
    :generateDebugResValues UP-TO-DATE
    :generateDebugResources UP-TO-DATE
    :mergeDebugResources
    Error: java.util.concurrent.ExecutionException: com.android.ide.common.process.ProcessException:
    :mergeDebugResources FAILED

    FAILURE: Build failed with an exception.

    * What went wrong:
    Execution failed for task ':mergeDebugResources'.
    > Error: java.util.concurrent.ExecutionException: com.android.ide.common.process.ProcessException:

    * Try:
    Run with --stacktrace option to get the stack trace. Run with --info or --debug option to get more log output.

    BUILD FAILED

    Total time: 2.48 secs
    Error: cmd: Command failed with exit code 1 Error output:
    FAILURE: Build failed with an exception.

I also face same issue

someone solved this, I also have the same issue

I'm missing ionic info from everyone, so I'm going to guess that if you get this error, you should first try doing:
cordova clean android

And retrying the build.
If that doesn't work, try updating Android Studio (which should install the latest Android SDK & Gradle version).

@dwieeb  its resolved just removed the platform add and add platform again
Might be issue with status bar plugin which is resolved


Register ppc64le too

Hi and thanks for the awesome work!
I'm trying to build an image FROM ppc64le/debian:jessie that only installs iptables.
COPY qemu-ppc64le-static /usr/bin/ is there but docker run --rm --privileged multiarch/qemu-user-static:register --reset doesn't register ppc64le, only ppc which obviously doesn't work.
Is there any issues with registering ppc64le or could we do it?

Hi @luxas,
You can docker pull multiarch/qemu-user-static:register to refresh the image with ppc64le support
Successfully tested with
FROM ppc64le/debian:jessie
COPY qemu-ppc64le-static

And
moul@fwrz:~# docker run -it --rm multiarch/ubuntu-core:ppc64el-vivid
root@6b1f08a0a622:/# uname -a
Linux 6b1f08a0a622 4.2.0-23-generic #28-Ubuntu SMP Sun Dec 27 17:47:31 UTC 2015 ppc64le ppc64le ppc64le GNU/Linux

Thank you so much!


upd(bottles): 2022.5.28-trento-3 -> 2022.6.14-brescia

Bottles is now gtk4 + libadwaita! So the dependencies will probably be updated.

Dropping this pacscript may be done cause of https://usebottles.com/blog/an-open-letter/ @Mar0xy did you see this?

I think it's wrong to force Flatpak down people's throat and way to biased considering even ubuntu doesn't support flatpak out of the box but snap instead i myself use arch and also don't agree with them planning to remove the AUR package as I don't think Flatpak is the best solution.


#WHCS-2328 doc updates for Cfg Ed licensing id

one comment on the dedicated sandbox instance where we say it won't count but that is only if they select the right usage type when deploying that so we should tell them do that there.  other than that looks good to me


fix multiple decorator issue

When running, the end of logs wasn't showing up due to multiple decorator and optional inputs for solution decorator

Pytest failed because there were no pytest files. OK to merge.


Arithmetic INT instructions

Done with the latest commit https://github.com/RedGear-Studio/Reg-Lang/commit/481613676d4df48f098d54e4628a75afb9e1dab2


fix(gsoc'24): updates and bug fixes from the main simulator

Fixes #107
Updates and Bug fixes from the main Simulator

I think this will undo some of the optimizations made by @JoshVarga . Why was this PR delayed ? you mentioned that all the updates from the legacy simulator are already copied, right ?

@tachyons , I guess there was some miscommunication on my end. The PR was there way back but wasn't merged before

@niladrix719  Could you create separate PRs to copy changes. PR can't be reviewed in this form. Also give highest priority for this.

created Separate PRs - #345, #346, #347, #348, #349, #350, #351, #352, #353, #354, #355, #356


Tweak the email? predicate and use it.

I didn't find this used anywhere, though I expected it to apply
when validating a user, so added that.
I would get exceptions for nil values, so switched to a nil? check
in the method instead
Added a locale message for email?

I'm new to these libraries, so ran across this in the process.  I'm probably more interested in seeing if I got this right, than anything.

Some repl & db feedback from trying it out:
Before:
[6] pry(main)> r = c.call(email: "john", first_name: "John", last_name: "Doe")
=> Right(#<Admin::Entities::User id=1 first_name="John" last_name="Doe" email="john" encrypted_password=nil access_token="cb4e94935e2167fae6d9f3cbc910041b" access_token_expiration=2016-05-31 16:25:19 -0700 active=true>)

berg_development=# select email from users;
 email
-------
 john
(1 row)

After:
[2] pry(main)> r = c.call(email: "jane", first_name: "Jane", last_name: "Doe")
=> Left(#<Dry::Validation::Result output={:email=>"jane", :first_name=>"Jane", :last_name=>"Doe"} messages={:email=>["is not an email address"]}>)

Thanks @bemurphy!   Thanks so much to your team for making this repo public, it's been a fantastic learning resource on all the dry-* and rom-* libraries.


[examples] Update remix example's tsconfig with required values

Added required TS config values to the Remix example as it was failing without them (as per https://github.com/mui/material-ui/pull/32506#pullrequestreview-962953949)

Are these automatically added when new remix project is created?

baseUrl is added when creating the project with npx create-remix. allowJs, forceConsistentCasingInFileNames and isolatedModules are added on the first run.


Package request sdrangel

It is an sdr software, would be nice if the package also works with limesdr
here is the repo https://github.com/f4exb/sdrangel/releases
i'm not quite sure how to package that one ^

I already made this package, it is building and working with my limesdr
but it is also my first nix package so feel free to correct me, add libraries and hardware support
{stdenv, fetchFromGitHub,
cmake, gnumake, gcc, pkgconfig,glew,opencv3,libusb,libopus,
boost,qt5,
fftw,fftwFloat,fftwLongDouble,fftwSinglePrec,
limesuite,
ocl-icd,
pulseAudioSupport ? true,libpulseaudio
}:
# with import <nixpkgs> {};
let
  qtlibs = [
    qt5.qtbase qt5.qtwebsockets qt5.qtmultimedia
  ];
  fftwlibs = [
    fftw fftwFloat fftwLongDouble fftwSinglePrec
  ];

  codec2 = stdenv.mkDerivation {
    name = "codec2";
    src = fetchFromGitHub {
      owner = "drowe67";
      repo = "codec2";
      rev = "567346818c0d4d697773cf66d925fdb031e15668";
      sha256 = "0ngqlh2cw5grx2lg7xj8baz6p55gfhq4caggxkb4pxlg817pwbpa";
    };
    buildInputs = [ cmake gnumake ];
  };

  cm256cc = stdenv.mkDerivation {
    name = "cm256cc";
    src = fetchFromGitHub {
      owner = "f4exb";
      repo = "cm256cc";
      rev = "f21e8bc1e9afdb0b28672743dcec111aec1d32d9";
      sha256 = "1imxg9hxh92r8ip161980axavvx1sr321lw0g8rbza59s50sd17g";
    };
    buildInputs = [ cmake gnumake boost ];
  };

  serialdv = stdenv.mkDerivation {
    name = "serialdv";
    src = fetchFromGitHub {
      owner = "f4exb";
      repo = "serialdv";
      rev = "d5830fae715f4acffa2acec33539c3a11c17a1c9";
      sha256 = "0swalyp8cbs7if6gxbcl7wf83ml8ch3k7ww4hws89rzpjvf070fr";
    };
    buildInputs = [ cmake gnumake ];
  };

  fetchedDeps = [ codec2 cm256cc serialdv ];
in
  stdenv.mkDerivation rec {
    name = "sdrangel";
    src = fetchFromGitHub {
      owner = "f4exb";
      repo = "sdrangel";
      rev = "ec22056cbf43f1150c610fd14df447cdadeadd45";
      sha256 = "05vijflnydl10l0h7ib6pwi06fmg6k740vcbkm0g5293s2z85j14";
      fetchSubmodules = false;
    };
    buildInputs = [
      cmake gcc pkgconfig glew opencv3 libusb boost libopus limesuite
    ]
    ++qtlibs
    ++fftwlibs
    ++fetchedDeps
    ++ stdenv.lib.optionals pulseAudioSupport [ libpulseaudio ]
    ;
    cmakeFlags = [
      "-DLIBSERIALDV_INCLUDE_DIR:PATH=${serialdv}/include/serialdv"
      "-DLIMESUITE_INCLUDE_DIR:PATH=${limesuite}/include"
      "-DLIMESUITE_LIBRARY:FILEPATH=${limesuite}/lib/libLimeSuite.so"
    ];

    LD_LIBRARY_PATH= "${ocl-icd}/lib";
  }

I finished packaging it, it work with my limesdr, gonna make a PR

You can ping me when you open the PR. I can review it and I also have some SDR hardware to test it.

@markuskowa gonna do it tonight or tommorow
will be my first nixpkgs PR, do i add myself to the maintainers list ?

will be my first nixpkgs PR, do i add myself to the maintainers list ?

Yes, just put yourself on the list of  maintainers  in maintainers/maintainer-list.nix (make is separate commit).

made this PR
https://github.com/NixOS/nixpkgs/pull/67357

Package added by #67357

Package added by #67357


Feature/create store

Codecov Report

:exclamation: No coverage uploaded for pull request base (v5@e5eb5da). Click here to learn what that means.
Patch has no changes to coverable lines.

:exclamation: Current head 97d5c27 differs from pull request most recent head 8bf4b04. Consider uploading reports for the commit 8bf4b04 to get more accurate results

:mega: This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more
Additional details and impacted files
@@          Coverage Diff          @@
##             v5    #4999   +/-   ##
=====================================
  Coverage      ?   90.61%
=====================================
  Files         ?      104
  Lines         ?     3773
  Branches      ?      951
=====================================
  Hits          ?     3419
  Misses        ?      324
  Partials      ?       30

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.


[8.x] Add a phpunit comparator for models

This PR adds a phpunit comparator for models.
The comparator compares the models based on the model is method.
Phpunit comparators are used for the methods assertEquals and assertNotEquals.
I often encounter that I want to check if two models are the same, and then use the assertEquals, only to get an error about things not being identical. This is often caused by fields like the wasRecentlyCreated and so on.
To get around this I normally write assertTrue($model->is($otherModel)).
This solution might be BC and should have been submitted to L9, as it changes the current assertEquals result, however submitting it to L8 because it uses the official is method which is used for comparing models. If you consider this a BC i'll submit to L9 instead 👍
Another solution for this would be so instead of using the is method for comparison it uses the getAttributes arrays for comparison.

Hi, I merged https://github.com/laravel/framework/pull/38398 into 8.x to get the test suite passing again. I've put your PR in draft. Please rebase your PR against 8.x to make the tests of this PR pass. After you've done that and tests pass, mark this PR as ready for review. Thanks.

Yeah - not sure I want to do this on a patch release. Can't even decide if I want to do it at all atm 😅

Yeah, prob. shouldn't be patch 😄
Thought I would open a PR for hearing the teams thoughts about it 👍


test

class SeedtoolCli < Formula
desc "Cryptographic Seed Tool for the command line"
homepage ""
url "https://github.com/BlockchainCommons/seedtool-cli/archive/refs/tags/0.4.tar.gz"
sha256 "3986cf1b738cce09ae6d5f13e7986753e427403a9b0176684030d874814cf108"
license "NOASSERTION"
depends_on "cmake" => :build
def install
# ENV.deparallelize  # if your formula fails when building in parallel
# Remove unrecognized options if warned by configure
# https://rubydoc.brew.sh/Formula.html#std_configure_args-instance_method
system "./configure", *std_configure_args, "--disable-silent-rules"
# system "cmake", "-S", ".", "-B", "build", *std_cmake_args
end
test do
# test do will create, run in and delete a temporary directory.
#
# This test will fail and we won't accept that! For Homebrew/homebrew-core
# this will need to be a test that verifies the functionality of the
# software. Run the test with brew test seedtool-cli. Options passed
# to brew install such as --HEAD also need to be provided to brew test.
#
# The installed folder is not in the path, so use the entire path to any
# executables being tested: system "#{bin}/program", "do", "something".
system "false"
end
end

sha256 "a7f00a20eebe6abafd1db5305a9bd699a2a8e72497941f9be027a85f8489384d"

url "https://github.com/BlockchainCommons/seedtool-cli/archive/refs/tags/0.9.0.tar.gz"
sha256 "a7f00a20eebe6abafd1db5305a9bd699a2a8e72497941f9be027a85f8489384d"


Validation error for device extensions in Release Mode (Visual Studio)

Vulkan will issue a validation error when initializing a device. Specifically, the initialization error is about passing too big or badly formed extension names. This means that the Release version of dragonfly isn't able to render on-screen. The reason why this happen is not known yet.
This does not appear in Visual Studio's Debug Mode, only Release Mode. It's unknown -yet- if this is just for Visual Studio Release Mode or applies to other building tools' Release Modes. In the future, when multiple build methods are available, this will be checked.
Currently, the issue is not highly prioritized, as the Debug version of Dragonfly behaves fine. Albeit this is not ideal, it, at least, means that the library itself can be used.

Bug information

File
Dragonfly-C/Render/Device.c

Function
dflDeviceInit

Line(s) in File
232 - 237

Causes crash
No

Applies in
Release Mode

Status
Non-critical

Issue is now fixed. It was caused due to a scope error which was uncaught in the Debug build.


Proposal: Dockerfile QUESTION and ANSWER verbs

This proposal would add two verbs: QUESTION, for the purposes of issuing
questions to the user, and ANSWER, for the purpose of answering existing
questions.
In docker build we use several mechanisms to control input and output
including the environment, ADD and COPY, etc. What we do not have is a way
to get foreign input during docker build -- largely because it creates an
inconsistent build.
QUESTION solves this by keeping the build consistent outside of the input. This
allows Dockerfile builders to ask a question which may be presented to the user
if there is no ANSWER in the Dockerfile for it already. It also enforces the
reliability of the input to keep builds consistent; if there is no answer,
the question is asked before builds can proceed.
QUESTIONs can live in Dockerfiles or as ONBUILD statements to another
Dockerfile. QUESTIONs can always be answered by ANSWER statements and any
unanswered QUESTION is yielded to the builder as a query, expecting their
response.
QUESTIONs have an associated key and that is used to relate ANSWERs, as
well as provide a templating mechanism within the dockerfile. ANSWERs can be
used in Dockerfile variable interpolation, but not in the system environment,
making it ideal for secrets or other I/O that should not live in the running
container.
QUESTION and ANSWER never have any effect on docker run.
docker build could also have an --answer flag which could be used like
docker run -e to populate the environment, but just with build answers
instead, ensuring automated runs.
This would require the builder system to have more interactive properties in
the API, and this should be considered when deciding whether or not to accept
this proposal.
Examples:
Basics:
FROM busybox
QUESTION TODAY How are you today?
RUN echo ${TODAY}

docker build . will ask the building user, "How are you today?", prepping it
as an ANSWER for the rest of the run.
OnBuild Example:
FROM busybox
ONBUILD QUESTION TODAY How are you today?

docker build -t questioner .
FROM questioner
ANSWER TODAY Great! Thanks for asking!
RUN echo ${TODAY}

Will answer "How are you today?" with "Great! Thanks for asking!" and then echo
it in the RUN statement. Nothing will be asked of the user.
Real-World Example
FROM busybox
QUESTION SSH_AUTH_SOCK Enter the name of your SSH agent auth socket:
RUN SSH_AUTH_SOCK=${SSH_AUTH_SOCK} git clone<EMAIL_ADDRESS>
This would ask what the SSH auth socket is to the end user building the image.
Then, the auth socket is templated in on a once-run RUN command which clones
the source code of a repository. The auth socket is not persisted in the
environment and no prescience is necessary to build the image.
/cc @tiborvass @aanand @bfirsh @shykes

Hello!
We are no longer accepting patches to the Dockerfile syntax as you can read about here: https://github.com/docker/docker/blob/master/ROADMAP.md#22-dockerfile-syntax
Mainly:

Allowing the Builder to be implemented as a separate utility consuming the Engine's API will open the door for many possibilities, such as offering alternate syntaxes or DSL for existing languages without cluttering the Engine's codebase

Then from there, patches/features like this can be re-thought. Hope you can understand.


docs(R2): clarify resumablity / TUS support

Which Cloudflare product does this pertain to?
<IP_ADDRESS>
Existing documentation URL(s)
Your object storage docs  (R2) do not mention whether file upload resumable / TUS is supported. The only TUS mention is for the video 'stream' service. Resumable / TUS is elementary for large file uploads.
What changes are you suggesting?
Please indicate whether cloudflare R2 supports this and how.
Additional information
e.g. support for uppy (popular upload js client)

Are there any updates on this please?

R2 does not support TUS at the moment, though it should at least be implementable with a Worker.


Update to cf_units 2

The update to cf_units 2 breaks some of our unit tests, because in solving this issue https://github.com/SciTools/cf_units/issues/80, the cf_units developers 'standard' to be an alias for 'gregorian' instead of the other way around.
This PR updates esmvaltool so it works with cf_units 2.

It requires you to update the cf_units module to version 2. You can do this by running
pip install -e .[develop]
again, or by just updating the cf_units package:
pip install --upgrade cf_units


Workspace: Keyboard navigation in Grid View

Summary
Add keyboard navigation support to GridView
Relevant Technical Choices
The main change is the addition of the useGridViewKeys custom hook.  It takes inspiration and patterns from the useCarouselKeys hook.
To-do

Add tests for up/down arrow key navigation/arrangement. See https://github.com/puppeteer/puppeteer/issues/6195

User-facing changes
Users should now be able to navigate in the grid view using their keyboard.
Testing Instructions
Launch into the editor's grid view and test the following scenarios:

Use tab to jump between "Back" button, "Preview size" range control (three stops), and the page list.
When jumping to the page list the currently selected page should be focused instead. Not the whole list.
Use ↕ and ↔ keys to navigate through the grid horizontally and vertically, and with wrapping.
Use mod+↕ and mod+↔ to reorder pages.
Use Enter to select a page.
The focus should be trapped inside the dialog. E.g. if at any point the focus leaves the dialog while it's still open, the focus should be returned back to the dialog.
Use Esc to exit the dialog at any time.

Also validate that the edit-story karma tests pass for this build as integrations tests were added for the above 7 requirements.

#2717

Dillon, everything works great, but to focus on the grids, it's not obvious you have to tab three times. I know this is more of a product thing, but I think we should flag this with Omar and Sam. Some kind of better focus that makes it clear you are now on the grid.

Dillon, everything works great, but to focus on the grids, it's not obvious you have to tab three times. I know this is more of a product thing, but I think we should flag this with Omar and Sam. Some kind of better focus that makes it clear you are now on the grid.

@carlos-kelly @BrittanyIRL I'm going to push back a bit on the use of constants here, let me know what you think.

None of the other workspace/edit-story integration tests use constants for event keys, so it'd introduce an inconsistency
We'd have to declare two constants per key since the way the puppeteer/fixture api works is that it takes something like left and translates it to ArrowLeft.


Improve README text

HI! I noticed a couple of minor sentence flow issues in the README text and thought I'd provide patches for the issues I found. This PR is split into multiple commits so that you can cherry pick the changes as you wish. The first commit is a purely formatting change which is intended to make reading later diffs easier and hence make code review easier. In addition to the minor sentence flow changes, I've also added links to the license file and to the Catalyst website from the README so that accessing these resources is easier for the casual visitor to the project page.
If you would like anything changed, please don't hesitate to let me know and I'll be happy to update the PR and resubmit as necessary.

You are AWESOME! Thanks so much for all your help. This makes the site much better. Thanks! :tada:

I have added you to the list of Contributors in README.md. Please let me know if you rather not, or if you would like to spell it out differently. Thanks!

I have added you to the list of Contributors in README.md. Please let me know if you rather not, or if you would like to spell it out differently.

Yup, that's no problem, thanks for that!

Thanks!

My pleasure :-)


Add tabex

https://github.com/nodeca/tabex
Formaly, it's not pure node project, because it works in browser. But it's very "close" to all realtime buses. I don't know why, but none of existing buses allows to share single server connection between tabs, when user opens multiple pages. And i didn't found convenient extentions for that (inspected wormhole, IWC, crosstab and so on). Though problem of saving server resources & client traffic is very serious.
I think project is cool, but not sure if if fits to pocily of your list. Decide yourself.

Yup, looks nice, but as you said, not a node thing.
Would be a better fit here: https://github.com/sorrycc/awesome-javascript


fix: Catch Unauthorized error from Github

Description
Steps to Reproduce

Create a Personal Access Token
Login to New Relic
Visit the Entity Explorer
Select a specific Entity
Visit the Github Repo view from the left-hand side
Configure the app by setting your Personal Access Token and Github URL
Choose a repository for this entity
Delete the Personal Access Token from Github
Page errors out because a repository is set, but the token your using now generates an unauthorized message from Github

From this point, for this entity, you are stuck, unless you modify NerdStorage via the GraphiQL or the newrelic-cli. We aren't appropriately catching this specific error.
Expected Behaviour
Error should be caught, and you should be redirected to update your Personal Access Token.
Relevant Logs / Console output

401 Unauthorized

nr-loader-spa-current.min.js:1 Uncaught TypeError: r.map is not a function
    at u.value (nr3.nr-ext.net/artifact-index-production/4ee1cd5f-0f5e-4326-b153-5468c888ba8d/0.6.3/4ee1cd5f-0f5e-4326-b153-5468c888ba8d--github.js:1)
    at finishClassComponent (nr1.nr-assets.net/lib/react/16.6.3/react-dom.development.js:14425)
    at updateClassComponent (nr1.nr-assets.net/lib/react/16.6.3/react-dom.development.js:14388)
    at beginWork (nr1.nr-assets.net/lib/react/16.6.3/react-dom.development.js:15206)
    at performUnitOfWork (nr1.nr-assets.net/lib/react/16.6.3/react-dom.development.js:17944)
    at workLoop (nr1.nr-assets.net/lib/react/16.6.3/react-dom.development.js:17984)
    at renderRoot (nr1.nr-assets.net/lib/react/16.6.3/react-dom.development.js:18070)
    at performWorkOnRoot (nr1.nr-assets.net/lib/react/16.6.3/react-dom.development.js:18961)
    at performWork (nr1.nr-assets.net/lib/react/16.6.3/react-dom.development.js:18873)
    at performSyncWork (nr1.nr-assets.net/lib/react/16.6.3/react-dom.development.js:18847)

Error: Error code 401 when connecting to Github server (https://api.github.com). Response: {
  "message": "Bad credentials",
  "documentation_url": "https://docs.github.com/rest"
}

    at e.<anonymous> (nr3.nr-ext.net/artifact-index-production/4ee1cd5f-0f5e-4326-b153-5468c888ba8d/0.6.3/4ee1cd5f-0f5e-4326-b153-5468c888ba8d--github.js:1)
    at a (nr3.nr-ext.net/artifact-index-production/4ee1cd5f-0f5e-4326-b153-5468c888ba8d/0.6.3/vendors~4ee1cd5f-0f5e-4326-b153-5468c888ba8d--vendors.js:7)
    at Generator._invoke (nr3.nr-ext.net/artifact-index-production/4ee1cd5f-0f5e-4326-b153-5468c888ba8d/0.6.3/vendors~4ee1cd5f-0f5e-4326-b153-5468c888ba8d--vendors.js:7)
    at Generator.forEach.t.<computed> [as next] (nr3.nr-ext.net/artifact-index-production/4ee1cd5f-0f5e-4326-b153-5468c888ba8d/0.6.3/vendors~4ee1cd5f-0f5e-4326-b153-5468c888ba8d--vendors.js:7)
    at e (nr3.nr-ext.net/artifact-index-production/4ee1cd5f-0f5e-4326-b153-5468c888ba8d/0.6.3/vendors~4ee1cd5f-0f5e-4326-b153-5468c888ba8d--vendors.js:1)
    at c (nr3.nr-ext.net/artifact-index-production/4ee1cd5f-0f5e-4326-b153-5468c888ba8d/0.6.3/vendors~4ee1cd5f-0f5e-4326-b153-5468c888ba8d--vendors.js:1)

Your Environment

NR1 CLI version used:
Browser name and version:
Operating System and version:

Additional context

I added a fix as part of #72 that deletes the Repo URL from Storage when the PAT is deleted


CLI panics on unknown commands or error in commands

/meili_data # backup-restore-sidecar backup
Error: unknown command "backup" for "backup-restore-sidecar"
Run 'backup-restore-sidecar --help' for usage.
panic: unknown command "backup" for "backup-restore-sidecar"

goroutine 1 [running]:
main.main()
        /home/runner/work/backup-restore-sidecar/backup-restore-sidecar/cmd/main.go:263 +0xbf

Closed by #76.


Feat: Leaderboard system for high scores

Describe the feature
Feature
Added a leaderboard system for high scores to the Air Hockey game. Also the leaderboard will be updated after each game, and players can view it from the start screen or the end screen. The leaderboard data will be stored in a JSON file, so it persists between game sessions.
Should I move forward with creating a PR?
Add ScreenShots

Record

[X] I agree to follow this project's Contributing.md
[X] I'm a Hacktoberfest contributor
[X] I want to work on this issue

@yazdanhaider Issue assigned to you. Remember to follow the rules given in the Contributing.md file.


Postgres RDS creation fails

Trying to create a new CF stack using https://github.com/DataShades/ckan-aws-templates/blob/master/Datashades-OpsWorks-NFS-CKAN-Stack.json, I get the following error:
11:44:49 UTC+1000	CREATE_FAILED	AWS::RDS::DBInstance	PostgresRDS	MasterUsername pg_dba cannot be used because role names starting with "pg_" are reserved by the PostgreSQL engine
It looks like Postgres 9.6 introduced this restriction on pg_ names.
Aside from updating the template to use an allowed name, it might be worth adding an option to select the Postgres version for the RDS as it may not always be the newest version that is required.

Fixed in commit 98827cc which requires ckan-cookbook v1.1.2


version support

version support pls
termsrv.zip

https://github.com/anhkgg/SuperRDP/releases/tag/v<IP_ADDRESS>


Reformat Recommended boards section

Added tabled to join board images with board parameters

Hi
I decided to stick to the horizontal layout with photos, but I made some changes to the readme co I will merge this PR. Many people browse Github on a mobile phone and scrolling through a very long page is tiring and they miss the most important things. At least i think so.


[Feature] Allow Admins/Mods to seek the video

Mods and Admins should be allowed to seek position in a video that will be synced up to everybody else. This is good for videos that have a long intro that could be skipped and could also act as a potential fix for #98 (as you could just seek back to the point the server disconnected).

I'd say a feature for users to set up where a song starts / ends would be nifty aswell. But that would have to wait until #43


Thief!

https://github.com/dthree/cash
:smile:
Just kidding - this looks really cool!
Good luck!

Hah I love your cash. I wrote this like 2 years ago, no idea why it's trending on HN lol.

Hey, thanks!
Oh snap - all your files had recent updates, so it made it look new.
I guess that makes me the thief!

I think someone had it before us. We're both thieves!

That's what we get for picky such a good name. :smiling_imp:


eigen patch to enable gpu support on windows

compiling some kernels with nvcc on windows fails. A few minor changes to eigen to get pass this. I'll send a pull request to the eigen repo.
This change is required to make the following 2 work:
https://github.com/tensorflow/tensorflow/pull/5051
https://github.com/tensorflow/tensorflow/pull/5052

Can one of the admins verify this patch?

corporate cla: Microsoft

re-submitted with a different user to clear cla:
https://github.com/tensorflow/tensorflow/pull/5076


Close command?

I've been using a keyboard equivalent to open the preview. Would it be possible to create another for closing it?

Or potentially a toggle command to minimize the plugin's keybind footprint. It seems like at one point there might have been a "Toggle" palette command since the install.txt still includes it in the setup docs


Tweaks for PostConstruct/PreDestory changes

Allow PostConstruct/PreDestory annotations from other packages.
Remove javax.annotation-api dependency since it is no longer strictly required.

Excellent, thanks for that.


CDN seems broken.

https://npmcdn.com/react-motion/build/react-motion.js
shows
Not found: file "/build/react-motion.js" in package<EMAIL_ADDRESS>

It is not yet published to npm with build folder in it =)

Humm we should stop pushing readme changes to master, or put a notice, or something else. Not the first time people check master readme and get confused about unreleased stuff.

Yeah, README updates should probably go in a separate PR and merged right before the next release.

Related: #262 and #266.
Sorry for the delay. CDN now works for React-motion v0.4.1.


reducing triangle count using different meshing method

It looks like gmsh supports netgen meshing
Therefore it might be possible to reduce the mesh count and improve the overall surface representation
https://gitlab.onelab.info/gmsh/gmsh/tree/ed587d3307fdf8e677936edc0106ab7cfe49b10e/Netgen

Slide 5 of this presentation has a netgen mesh image next to the current mesh used https://files.salome-platform.org/Salome/Common/SUD2015/03_JUS2015-An_advanced_MC_modeling_and_multi_physics_coupling_system_for_fusion_applications-QIU.pdf

From Yuefengs thesis the approach of meshing/faceting a geoemtry there makes use of less triangles :+1:  and obtains smaller volume differences with the unmeshed geometry :+1:.

https://publikationen.bibliothek.kit.edu/1000056066/3861514


Fixed transport name in DepthCloud plugin

Fixed transport name in DepthCloud plugin
When setting the topic name the image_transport type is automatically detected based on the topic name. But is not correct for example: /camera/image_raw will set the  image_transport type to image_raw, but the correct type is raw.

@clalancette friendly ping

Linux
Linux-aarch64
Windows

https://github.com/Mergifyio backport humble iron


the value of subject in the data passed into processSend is not correct

I had to use:
const bodyData = JSON.parse(body);
const emailSubject = bodyData[1]?.[0]?.[0]?.[1]?.[1]?.[13]?.[0]?.[7];

It looks like the current path being returned is: [1][0][0][1][1][2][0][4][0][8]
which is from:
https://github.com/huksley/gmail-js/blob/79a18883343a55002f9010bca4dbca02d3349297/src/gmail.js#L1790
It looks like the subject line is contained in the parent object to what is passed to parse_sent_message_payload_new.

But what version are you using now?

1.1.3

I hate to be the guy who shrugs this off as "works on my machine", but I currently can't see any runtime-errors in my extension.
Can you still reproduce this?

Ok, so I don't depend on this property myself, but I can see how this could be annoying for those who does.
Can you make a PR for this, and I will try to get it merged? :smile:

There isn't any runtime errors here. You get garbage if you try to read the subject:
  gmail.observe.after(
    'send_message',
    async function (url, body, data, response, xhr): Promise<void> {
      const subject = data.subject;
      console.log('send_message...', subject);
    }
  );


How much space does this take? Can it reasonably run from USB drive?

Wondering how big to make the Linux partition, also is it HD read/write heavy or can I run it reasonably from a non high speed USB drive?

you're looking at multiple GB of storage space just to get everything up and running. The model snapshots are also rather large as well. ( ~ > 100 MB) Not saying it can't be done, but I don't think you will have much luck running this off of a flash drive.

No activity. Closing.

No activity. Closing.


[SAC-91] Spark Catalog PreEvent should be handled correctly

What changes were proposed in this pull request?
Currently, SAC is collecting some information at PreEvents like DropDatabasePreEvent. However, the database described in DropDatabasePreEvent might not exist and the main event DropDatabaseEvent will not arrive because it will fail. This PR fixes some PreEvent logic and handles explicitly as No-OPs for the others.
scala> sql("drop database sparkdb2")
2018-11-12 14:16:29 WARN  SparkCatalogEventProcessor:48 - Caught exception during parsing event
org.apache.spark.sql.catalyst.analysis.NoSuchDatabaseException: Database 'sparkdb2' not found;
...
at com.hortonworks.spark.atlas.AbstractEventProcessor$$anon$1.run(AbstractEventProcessor.scala:39)

How was this patch tested?
Manual with Apache Atlas 1.1.0 and Apache Spark 2.4.0

Would we be better to apply defensive programming, like applying the same to drop table?


Discussion: How to decide which aperture is selected

There is logic in ophyd to set aperture positions based on the GDA properties. There is also logic in EPICS to work out with aperture is selected for the the flux, based on different values that may be out of sync with the GDA properties:

We should come up with a unified way of doing this. I04 has the same issue so we should talk to @aragaod too

Scientists use the properties rather than this PV so can't change this now

@neil-i03, feel free to add some initial thoughts to this. I'm not too fussed about what the final solution except that keeping track of it in multiple places is going to trip us up at some point

Chicken and egg situation. Scientists (i04) would like to move to the PV but need to move on both the "old" GDA and the new ophyd devices at once. Maybe I create a Jira ticket for GDA to start the gda migration first....

The ophyd device is now using the PVs from the flux calculator to work out which position we're in. I think this is a good solution as it maintains one source of truth.


Error to install php on ubuntu 14.04

Hi,
I need to use php 5.3.XX on apache for example 5.4.0.
I tried:
phpbrew install 5.4.0 +default

noam@noam-Inspiron-5423:~$ phpbrew install 5.4.0 +default
===> Downloading from http://museum.php.net/php5/php-5.4.0.tar.bz2
--2014-06-16 16:00:10--  http://museum.php.net/php5/php-5.4.0.tar.bz2
Resolving museum.php.net (museum.php.net)... <IP_ADDRESS>
Connecting to museum.php.net (museum.php.net)|<IP_ADDRESS>|:80... connected.
HTTP request sent, awaiting response... 200 OK
Length: 11439508 (11M) [application/x-bzip2]
Saving to: ‘php-5.4.0.tar.bz2’

100%[=======================================================================================================>] 11,439,508  1.96MB/s   in 14s

2014-06-16 16:00:24 (818 KB/s) - ‘php-5.4.0.tar.bz2’ saved [11439508/11439508]

===> php-5.4.0.tar.bz2 downloaded.
===> Extracting php-5.4.0.tar.bz2...
===> Applying patch file for freetype include path bug...
patching file configure
Hunk #1 succeeded at 38802 (offset -411 lines).
patch unexpectedly ends in middle of line
Hunk #2 succeeded at 40984 with fuzz 1 (offset -411 lines).
===> Configuring 5.4.0...

Use tail command to see what's going on:
   $ tail -f /home/noam/.phpbrew/build/php-5.4.0/build.log

configure: WARNING: bison versions supported for regeneration of the Zend/PHP parsers: 1.28 1.35 1.75 1.875 2.0 2.1 2.2 2.3 2.4 2.4.1 2.4.2 2.4.3 2.5 (found: 3.0.2).
configure: WARNING: bison versions supported for regeneration of the Zend/PHP parsers: 1.28 1.35 1.75 1.875 2.0 2.1 2.2 2.3 2.4 2.4.1 2.4.2 2.4.3 2.5 (found: none).
===> Building...
/home/noam/.phpbrew/build/php-5.4.0/ext/dom/node.c: In function ‘dom_canonicalization’:
/home/noam/.phpbrew/build/php-5.4.0/ext/dom/node.c:1898:21: error: dereferencing pointer to incomplete type
    ret = buf->buffer->use;
                     ^
In file included from /home/noam/.phpbrew/build/php-5.4.0/main/php.h:38:0,
                 from /home/noam/.phpbrew/build/php-5.4.0/ext/dom/node.c:26:
/home/noam/.phpbrew/build/php-5.4.0/ext/dom/node.c:1900:40: error: dereferencing pointer to incomplete type
     RETVAL_STRINGL((char *) buf->buffer->content, ret, 1);
                                        ^
/home/noam/.phpbrew/build/php-5.4.0/Zend/zend_API.h:571:20: note: in definition of macro ‘ZVAL_STRINGL’
   const char *__s=(s); int __l=l;   \
                    ^
/home/noam/.phpbrew/build/php-5.4.0/ext/dom/node.c:1900:5: note: in expansion of macro ‘RETVAL_STRINGL’
     RETVAL_STRINGL((char *) buf->buffer->content, ret, 1);
     ^
make: *** [ext/dom/node.lo] Error 1
Errornoam@noam-Inspiron-5423:~$

I added the lines:
export PHPBREW_SET_PROMPT=1
source /home/noam/.phpbrew/bashrc

at the end of the file  ~/.bashrc
I tried to:
noam@noam-Inspiron-5423:~$ sudo apt-get install -y libicu48
[sudo] password for noam:
Reading package lists... Done
Building dependency tree
Reading state information... Done
Package libicu48 is not available, but is referred to by another package.
This may mean that the package is missing, has been obsoleted, or
is only available from another source

E: Package 'libicu48' has no installation candidate
noam@noam-Inspiron-5423:~$

Maybe this is really necessary?
Thanks

@noahwilliamsson Thx. Building php 5.3.10 in Ubuntu 14.04 works now for me. Maybe include this in the Troubleshooting section. https://github.com/phpbrew/phpbrew/wiki/TroubleShooting
Thanks again!!

:+1: Thanks @noahwilliamsson! I added some information about this in the troubleshooting section.

:+1: Thanks @noahwilliamsson, building PHP 5.4.4 on Ubuntu 14.04 works now.


Incorrect depth preception from Kinect2_bridge, but correct depth through ./Protonect

I am having a problem with the kinect2_bridge. For some reason it marks a door incorrectly in the middle of the hallway when it is actually at the end of the hallway. I have calibrated the kinect2 multiple times using the kinect2_calibration tutorial. Below are the images that show the problem that I am getting through multiple angles within rviz and image_view of the depth image. The weird part is that when I run ./Protonect the depth image seems to be correct and it doesn't show the problem that the kinect2_bridge has. The red circle indicates the object in all of the pictures.

Here are some real world pictures that were taken with a camera.

In the end the problem is that the depth image is not correct when running kinect2_bridge and I can't seem to fix it. If anyone has had this problem or knows how to fix it that would be very helpful.

It only uses the data that it gets from libfreenect2. If the door is seen, it must be seen by libfreenect2 too. The door seems to be very far away, much further than the kinect2 should see. Why it is happening I don't know. Maybe the distance is in a range, that the reflection from the light of a previous measurement is seen in the next measurement?
The easiest solution is to filter everything further away than a certain distance. Use the max_depth parameter for it.

Could you explain more on the "reflection from the light of a previous measurement" I'm not quite sure what you mean?
Also the error does not show up in libfreenect2 when I run ./Protonect shown in 6th image.
I have tried using the max_depth parameter, but the problem still shows up if the door is in view. The only way of removing the problem was to cover up the whole corridor so that the door wasn't seen at all.

To get a depth image, the sensor takes multiple images shortly after each other. For this it sends out a IR flash. maybe the door is in a distance that the reflection of the flash from a previous image shows up in one of the following. But I am not sure, that's just some random guess, so don't care.
As you can see, Protonect is only showing results until the door on the left, therefore you cannot see it there, but it is probably also seen by Protonect. If you set max_depth to 4.5 meters it should not be seen by kinect2_bridge. Look at the terminal output from kinect2_bridge to see if you specified max_depth value is used.

For the first part I'm not sure if that's what's happening because the problem is there at many different ranges. So if I move the robot close to the problem area it still shows up and even if i'm far away from it, the problem will stay in the same location.
Also I tried changing the max_depth and it still didn't fix the problem. Currently I haven't figured out a way to remove the problem unless I place something over the whole corridor so it doesn't see the door at all.


fix warn

-Delete DateTimePickerModal.defaultProps
-Add default props to arguments
-Rewrite areEqual function
Test Plan
I'm only replace the default props value to arguments DateTimePickerModal component and change the areEqual function

i hope this PR will be merged soon!, thank you so much!! ❤

@mmazzarolo can you merge this pls

Published! Thanks for the contribution and super sorry for the delay folks, just had another kid and I have basically 0 time to follow this repo 😅


Added rotate vector function and test

Added a function to rotate a 3D vector by a quaternion

Hi. Looks like a good idea. Your RotateVec3 function might also be implemented as a method of the Vec3 struct, i.e. func (v *Vec3) Rotate(q Quaternion).  Then rotations can be composed like V.Rotate(Q1).Rotate(Q2).  If you'd like to implement that, let me know; otherwise I'll go ahead and merge this and implement it myself.

That sounds like a great idea! I'll try to get that done this weekend.

Sorry about the delay, but I added the Rotate method to Vec3 as you suggested, great idea!

Looks great!  Merged.  Thank you!


atomic blob commands

Is there a way to do the blob set operation as part of an atomic operation ?

There is a problem in that the amount of operations in an atomic operations is limited, but a blob set operations breaks down the data into discreet chunks which can easily exceed the transaction limit of an atomic operations.
In implementation at the moment, a blob set actually sets that parts using batched atomic transactions. I suspect though what you are really asking for is to be able to have something like .setBlob() as part of an atomic transaction?
It is possible to add that method to the batch atomic API, but because blob currently depends on batch atomic it means that we would have to reorganise the code a bit so there isn't a cyclical dependency.

Correct - setBlob() as part of an atomic transaction.
Ok thank you for your reply.  The way I am doing it at the moment is setting the blob to a ulid key, then using an atomic transaction to update the key I want with the blob key, and rolling back if that fails.
Given how the set() function breaks up blobs into a set of keys, would it perhaps be simpler to implement a pointer key system as described rather than making the whole set() function be atomic ?  Same result, but no code reorg and no hitting the atomic operation count limit 🤷

Thank you kindly 🔥


GitHub Actions implementation for Azure OpenAI doesn't work as expected

I run the Codium PR agent via GitHub Actions, but the PR agent doesn't provide any suggestions, and there is no informative output in the GitHub Actions job log.
Here is the configuration of the GitHub Actions workflow:
on:
  pull_request:
  issue_comment:

jobs:
  pr_agent_job:
    runs-on: ubuntu-latest
    permissions:
      issues: write
      pull-requests: write
      contents: write
    name: Run pr agent on every pull request, respond to user comments
    steps:
      - name: PR Agent action step
        id: pragent
        uses: Codium-ai/pr-agent@main
        env:
          GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
          OPENAI_KEY: ${{ secrets.API_KEY }}
          OPENAI_API_TYPE: 'azure'
          OPENAI_API_VERSION: '2023-09-15-preview'
          OPENAI_API_BASE: 'https://<my-url>.openai.azure.com'
          OPENAI.DEPLOYMENT_ID: '<my-deployment-name>'
          OPENAI.CONFIG_MODEL: 'gpt-4'
          github_action.auto_review: "true"
          github_action.auto_describe: "true"
          github_action.auto_improve: "true"
          github_action.pr_description.use_description_markers: "true"

Here is the output of the GitHub Actions job:
Run Codium-ai/pr-agent@main
/usr/bin/docker run --name ea20f6bf1854a679b9b4d2757ec7c8f_1cd170 --label 203400 --workdir /github/workspace --rm -e "GITHUB_TOKEN" -e "OPENAI_KEY" -e "OPENAI_API_TYPE" -e "OPENAI_API_VERSION" -e "OPENAI_API_BASE" -e "OPENAI.DEPLOYMENT_ID" -e "OPENAI.CONFIG_MODEL" -e "github_action.auto_review" -e "github_action.auto_describe" -e "github_action.auto_improve" -e "github_action.pr_description.use_description_markers" -e "HOME" -e "GITHUB_JOB" -e "GITHUB_REF" -e "GITHUB_SHA" -e "GITHUB_REPOSITORY" -e "GITHUB_REPOSITORY_OWNER" -e "GITHUB_REPOSITORY_OWNER_ID" -e "GITHUB_RUN_ID" -e "GITHUB_RUN_NUMBER" -e "GITHUB_RETENTION_DAYS" -e "GITHUB_RUN_ATTEMPT" -e "GITHUB_REPOSITORY_ID" -e "GITHUB_ACTOR_ID" -e "GITHUB_ACTOR" -e "GITHUB_TRIGGERING_ACTOR" -e "GITHUB_WORKFLOW" -e "GITHUB_HEAD_REF" -e "GITHUB_BASE_REF" -e "GITHUB_EVENT_NAME" -e "GITHUB_SERVER_URL" -e "GITHUB_API_URL" -e "GITHUB_GRAPHQL_URL" -e "GITHUB_REF_NAME" -e "GITHUB_REF_PROTECTED" -e "GITHUB_REF_TYPE" -e "GITHUB_WORKFLOW_REF" -e "GITHUB_WORKFLOW_SHA" -e "GITHUB_WORKSPACE" -e "GITHUB_ACTION" -e "GITHUB_EVENT_PATH" -e "GITHUB_ACTION_REPOSITORY" -e "GITHUB_ACTION_REF" -e "GITHUB_PATH" -e "GITHUB_ENV" -e "GITHUB_STEP_SUMMARY" -e "GITHUB_STATE" -e "GITHUB_OUTPUT" -e "RUNNER_OS" -e "RUNNER_ARCH" -e "RUNNER_NAME" -e "RUNNER_ENVIRONMENT" -e "RUNNER_TOOL_CACHE" -e "RUNNER_TEMP" -e "RUNNER_WORKSPACE" -e "ACTIONS_RUNTIME_URL" -e "ACTIONS_RUNTIME_TOKEN" -e "ACTIONS_CACHE_URL" -e "ACTIONS_RESULTS_URL" -e GITHUB_ACTIONS=true -e CI=true -v "/var/run/docker.sock":"/var/run/docker.sock" -v "/home/runner/work/_temp/_github_home":"/github/home" -v "/home/runner/work/_temp/_github_workflow":"/github/workflow" -v "/home/runner/work/_temp/_runner_file_commands":"/github/file_commands" -v "/home/runner/work/<repo-name>/<repo-name>":"/github/workspace" 203400:3ea20f6bf1854a679b9b4d2757ec7c8f
WARNING ⚠ user config directory '/github/home/.config/lancedb' is not writeable, defaulting to '/tmp' or CWD.Alternatively you can define a LANCEDB_CONFIG_DIR environment variable for this path.
2024-01-23 19:07:16.980 | INFO     | __main__:run_action:71 - Applying repo settings
2024-01-23 19:07:18.[15](https://github.com/<org-name>/<repo-name>/actions/runs/7630627494/job/20786742048?pr=25#step:3:16)8 | INFO     | __main__:run_action:75 - enable_custom_labels: False

I'll appreciate your feedback, and please let me know if I need to provide more details.

@mrT23 thank you so much for your quick response!

Once I ran on my public repo, I didn't face this kind of issue.
In the case of my private repo, there are no suggestions from any command: review, describe, improve.
Initially, it was provided the full log, here is the screenshot:

I removed "use_description_markers=true", but it's the same result for the private repo.

Even though GitHub Actions implementation was run in the private repo, I suggest it's not expected behavior since according to the Readme PR Agent provides functionality for the private repos.

I detected if the suggestions are generated, it will be the corresponding output in the GitHub Actions log:
2024-01-23 21:40:01.059 | INFO     | __main__:run_action:71 - Applying repo settings
2024-01-23 21:40:01.782 | INFO     | __main__:run_action:75 - enable_custom_labels: False
2024-01-23 21:40:02.861 | INFO     | pr_agent.tools.pr_reviewer:run:105 - Reviewing PR: https://api.github.com/repos/PavelGural/fastapi-text-analysis/pulls/1 ...
2024-01-23 21:40:02.862 | DEBUG    | pr_agent.git_providers.github_provider:publish_comment:195 - Skipping publish_comment for temporary comment: Preparing review...
2024-01-23 21:40:02.865 | INFO     | pr_agent.tools.pr_reviewer:_prepare_prediction:140 - Getting PR diff...
2024-01-23 21:40:03.426 | INFO     | pr_agent.tools.pr_reviewer:_prepare_prediction:143 - Getting AI prediction...
2024-01-23 21:41:03.848 | INFO     | pr_agent.algo.ai_handlers.litellm_ai_handler:chat_completion:131 - AI response
2024-01-23 21:41:03.848 | INFO     | pr_agent.tools.pr_reviewer:run:115 - Preparing PR review...
2024-01-23 21:41:03.853 | INFO     | pr_agent.tools.pr_reviewer:run:1[19](https://github.com/PavelGural/fastapi-text-analysis/actions/runs/7632169959/job/20791769761?pr=1#step:3:20) - Pushing PR review...
....
[20](https://github.com/PavelGural/fastapi-text-analysis/actions/runs/7632169959/job/20791769761?pr=1#step:3:21)24-01-23 21:41:06.143 | INFO     | pr_agent.tools.pr_description:_prepare_prediction:145 - Getting AI prediction PavelGural/fastapi-text-analysis/1
2024-01-23 [21](https://github.com/PavelGural/fastapi-text-analysis/actions/runs/7632169959/job/20791769761?pr=1#step:3:22):41:27.373 | INFO     | pr_agent.algo.ai_handlers.litellm_ai_handler:chat_completion:131 - AI response
2024-01-23 21:41:27.375 | INFO     | pr_agent.tools.pr_description:run:85 - Preparing answer PavelGural/fastapi-text-analysis/1
2024-01-[23](https://github.com/PavelGural/fastapi-text-analysis/actions/runs/7632169959/job/20791769761?pr=1#step:3:24) 21:41:27.378 | DEBUG    | pr_agent.tools.pr_description:run:112 - full_markdown_description:
## Title

Add YAML Document Start Marker to Kubernetes Manifest
...
___

## **Description**
- Added the document start marker (`---`) to the Kubernetes manifest file for better YAML format compliance.

In my case, there are no suggestions and no respective logs.

@PavelGural
again, I cannot QA your private repo. There is something wrong with your setup there, completely unrelated to PR-Agent code. PR-Agent in general works well also on private repos.
For example, make sure you provide a valid GitHub key and stuff like that.
As a last resort, try running from CLI, catch breakpoints, and see what went wrong. 99% you will immediately see the problem
all the best

@mrT23 thank you for your time and answers!


How should angle coordinates be handled in nonstandard color spaces

Continuing a discussion started in #435
The hsluv, hpluv, lchuv and hct color spaces currently allow angle units for their angle coordinate. As mentioned here this isn't spec compliant.
Do we need to change the coordGrammar to only allow <number | percentage> for the angle coordinate?

Personally, I would at least like to see percentages of non-standard colors in the color() format support defined ranges for percentages. Non-standard colors are not all confined to  0 - 1, and with things like hues, I would think a percentage should cover 0 - 360. At least that is how I've implemented them in my own color library.

I would love to hear from @svgeesus on this.

Based on the recent HDR spec update by @svgeesus, it seems like JzCzhz will support full <hue> support for the angle property: https://drafts.csswg.org/css-color-hdr/#color-function. Unless I'm misunderstanding something.
It sounds like that would answer the question about angles. They will not support percentages and will instead support hues as done everywhere else. This probably makes the most sense for consistency, so I'm actually fine with this.

@facelessuser For predefined color spaces we can define whatever, the question is for custom color spaces, where the options are:

Either we allow <hue> for every coordinate
Or, we disallow <hue> more generally
Or, we give authors a way to specify a coord grammar (making the color() IACVT if it doesn't match it).

Neither of these are ideal, hence my question.

If predefined spaces in the color format have coord specific grammar, I think custom spaces should be able to tap into that as well. If not, it makes the interface confusing. That is my personal opinion though.

CSS may not allow custom polar systems or arbitrary, non rgb color spaces, but this library does, I think there should be consistency for the user. That is my main point.
If CSS were to extend the color format in the same way that this library does, then I'd probably argue the same for CSS, but it doesn't sound like there is intention to do that currently.
I don't think it helps that angles would be treated one way for a predefined space but not for others, I think it would just confuse users.
I also don't think that spaces that are not confined to ranges of 0 - 1 should have percentages that map to those ranges as it makes its functionality useless; it'd be better to just not allow percentages of their isn't some utility in them.

CSS may not allow custom polar systems or arbitrary, non rgb color spaces, but this library does, I think there should be consistency for the user. That is my main point.

This is my feeling as well.

I also don't think that spaces that are not confined to ranges of 0 - 1 should have percentages that map to those ranges as it makes its functionality useless; it'd be better to just not allow percentages if their isn't some utility in them.

<percentage>  does allow for ranges other than 0 - 1. For example luv has reference ranges of -215 - 215 and has this coordGrammar:
<number> | <percentage>", "<number> | <percentage>[-1,1]", "<number> | <percentage>[-1,1]

 does allow for ranges other than 0 - 1. For example luv has reference ranges of -215 - 215 and has this coordGrammar:

Okay, that's great then.

Based on the recent HDR spec update by @svgeesus, it seems like JzCzhz will support full <hue> support for the angle property: https://drafts.csswg.org/css-color-hdr/#color-function. Unless I'm misunderstanding something.
It sounds like that would answer the question about angles. They will not support percentages and will instead support hues as done everywhere else. This probably makes the most sense for consistency, so I'm actually fine with this.

That is correct (and is the main reason to add JzCzHz, as the only polar HDR color space) and thus forms a precedent to use for custom color spaces.
Currently in CSS Color 5, custom color spaces can only be defined by referencing an ICC.1 profile and thus, cannot use a polar form (they all relate to either XYZ-D50 or CIE Lab (D50) as profile connection space) so the grammar does not currently allow a hue angle. Also, to date that option is only of interest to the CSS-to-PDF market, (for CMYK and friends) the browsers seem content to ignore ICC profiles for custom colors although they use them in images.
It would be good to allow custom (additive) colorspaces in CSS Color 5 to be defined in terms of primary chromaticities, whitepoint and transfer function; and in that case it would also make sense to allow a polar form. But no-one seems in a rush to implement that. So a CSS-like setrialization of spaced supported by color.js is currently out of spec.


fix two bugs

In Packing.java, replaceAll method may throws InvalidArgumentException
In Console.java, replaceAll method may throws InvalidArgumentException
Hope to agree.

CodeQl build error,maybe syntax error


Metadata for Problem objects

Description
Implementation of the attributes qubo.metadata and qubo.problem_instance in the QUBO class.
Metadata
qubo.set_metadata(metadata={...})
This method adds the items of the input dictionary to qubo.metadata (which is a dictionary).
By default the metadata dictionary is empty, the users can fill it with any data that they want (data needs to be serializable).
Problem Instance
Problem class
The property problem_intance has been included in the Problem class:
class Problem(ABC):
...
    @property
    def problem_instance(self):
        ...
        return {**{"problem_type": self.__name__}, **dict(self)}

this property is a dictionary of the serialization of the object + the problem type name (e.g. for number partitoning problem_type='number_partitoning')
To get a good serialization of the object when calling dict(self), the following has been included:
class Problem(ABC):
...
    def __iter__(self):
        for key, value in self.__dict__.items():
            # remove "_" from the beginning of the key if it exists
            new_key = key[1:] if key.startswith("_") else key
            # convert networkx graphs to dictionaries
            new_value = nx.node_link_data(value) if isinstance(value, nx.Graph) else value

            yield (new_key, new_value)

And to get the correct name when calling self.__name__, the __name__ has been included in each problem class, example:
class NumberPartition(Problem):
...
    __name__ = "number_partition"
   ...

Then when the QUBO is created from the problem object the self.problem_instance is passed, example:
class NumberPartition(Problem):
...
    def get_qubo_problem(self):
        ...
        return QUBO(self.n_numbers, terms, weights, self.problem_instance)

QUBO class
The initialization of the QUBO class has now a new parameter problem_instance, and an attribute is created with the value:
class QUBO:
...
    def __init__(self, n, terms, weights,
                    problem_instance:dict={"problem_type": "generic_qubo"},
                    ...):
        ...
        self.problem_instance = problem_instance

therefore qubo.problem_instance will be {"problem_type": "generic_qubo"} if nothing is passed, but when wubo is created from one problem this dictionary will have the problem type name and the serialization of the problem.
Examples
Number Partitoning
NumberPartition_problem = NumberPartition.random_instance(n_numbers=3)
NumberPartition_qubo = NumberPartition_problem.get_qubo_problem()

dict(NumberPartition_qubo)

out:

{'terms': [[0, 1], [0, 2], [1, 2]],
'weights': [72.0, 12.0, 12.0],
'constant': 73,
'n': 3,
'problem_instance': {
          'problem_type': 'number_partition',
          'numbers': [6, 6, 1],
          'n_numbers': 3},
'metadata': {}}

Minimum Vertex Cover
MinimumVertexCover_problem = MinimumVertexCover.random_instance(n_nodes=3, edge_probability=0.5)
MinimumVertexCover_qubo = MinimumVertexCover_problem.get_qubo_problem()
MinimumVertexCover_qubo.set_metadata({'tag1': 'value1', 'tag2': 'value2'})

dict(MinimumVertexCover_qubo)

out:

{'terms': [[0, 2], [1, 2], [0], [1], [2]],
 'weights': [2.5, 2.5, 2.0, 2.0, 4.5],
 'constant': 6.5,
 'n': 3,
 'problem_instance': {
          'problem_type': 'minimum_vertex_cover',
          'G': {
                    'directed': False,
                    'multigraph': False,
                    'graph': {},
                    'nodes': [{'id': 0}, {'id': 1}, {'id': 2}],
                    'links': [{'source': 0, 'target': 2}, {'source': 1, 'target': 2}]},
          'field': 1.0,
          'penalty': 10},
 'metadata': {'tag1': 'value1', 'tag2': 'value2'}}

QUBO
qubo = QUBO.random_instance(3)

dict(qubo)

out:

{'terms': [[2], [0, 1], [0, 2]],
 'weights': [-0.833099253577807, 14.405500837522837, -1.0046728497563495],
 'constant': 0,
 'n': 3,
 'problem_instance': {'problem_type': 'generic_qubo'},
 'metadata': {}}

TO DO

[x] Have default keys and values?
[x] Have required keys?
[x] Write test

Since problem_instance will have varying length depending on the underlying problem, we need to change its data structure so that it is machine parsable.
So, if some of these fields are always present then then can be keys-values pairs in a dictionary. Otherwise, we need to turn them into lists. For example, "nodes": [{"id": 0}, {"id": 1}, {"id": 2}] is generated this way because you don't know a priory how many nodes we will have.


how does one predefine useRoute().path for storybook item?

I'm using a component like this one...
import { useRoute } from 'vue-router';
import { storeToRefs } from 'pinia';

export default {
  template: `<div>the template's route path {{ routePath }}</div>`,
  setup () {
    const route = storeToRefs(useRoute());
    const routePath = route.path;
    console.log('ROUTE', route.path); // ROUTE undefined
    return { routePath };
  }
}

and the associated stories.js file mounts the component using storybook-vue3-router with these options
NORMAL.decorators = [vueRouter([], {
  initialRoute: '/test',
  path: '/test'
})];

Am I doing something wrong? How does one define the router path for a component like this?

I think the issue is how your adding the decorator, you're passing an empty array of routes which at best will use the default routes (which doesn't include a /test route) and worst will not provide router with any routes to use.
If you want to use a custom starting route then you need to provide the routes/components for this.
Does it not work if you just use
NORMAL.decorators = [vueRouter()];

With that I'd expect route.path to be 'home'

NORMAL.decorators = [vueRouter()];

using the above decorator, route.path is undefined

probably a demo app would be needed to show the issue more effectively, but I don't have time now to make a demo

Ok, I've not tried this with Pina so wonder if something is going wrong when passing storeToRefs(useRoute())
If you can provide a demo/reproduction that would be very helpful. I'll also try to but unlikely to be until the weekend at the earliest.

useRoute() returns undefined

That's strange, useRoute definitely works in the examples I have, I suspect there must be some issue with your implementation, but if your using the default vueRouter() setup then I'm not sure what would cause this. If you can provide a demo this would help me debug the issue.

I took another quick look just now and believe to have found the problem and will explain.
The files I'm using look like this. Basically, storybook is not included in the project root but is instead found in a sub-directory. In a past experience, storybook's chaotic interface, version and plugin changes made another project difficult to work with, so for this project storybook is configured and contained in a separated place.
example-project
├── package.json
└── storybook
    └── package.json

both the" example-project" and "storybook node_modules" files have a "vue-router" package. Deleting "storybook/node_modules/vue-router" seems to have resolved the issue. I'm looking for a way to continue keeping storybook in a separated place while, at the same time, using the root project's node_modules/vue-router package from within storybook

a solution is to define this vue-router dependency inside "storybook/package.json"
+    "vue-router": "../node_modules/vue-router"

this solution would not work in a win32 environment but I am not using win32 so all is fine here


Fix Reader Type

ReaderType was implemented here: #23 but I think Reader type needs fixing.
We should read Char by Char and create the lines based on de CSVDefinition line delimiter

Nice catch, we should have tests to catch bugs tho!


Kaf Producer: Add Confluent Schema support

Add Confluent header support to produce command.
There exists a schema registry library that is used in pkg/avro/schema.go to support adding Confluent Headers to avro messages. It is github.com/Landoop/schema-registry, however, it looks like this package is no longer maintained so let's just import the package we use in backend
Sidenote: As we keep adding stuff to kaf, I wonder if we want to just invest some time into it and reorganize the code a bit. Might be an interesting hackathon project. Or see if we can make any of these additions suitable to merge upstream (not sure how open they are to contributions)
[ch89426]
Tested by doing the following:
Consume on topic to see that we are sending well formed messages:
kaf --cluster nonprod-ue1-confluent-01 consume dev-shield-stream-batch-v1  --proto-include ~/git/shared-protobuf/kafka/shield/ --proto-type shield.StreamBatch --confluent-header
kaf --cluster nonprod-ue1-confluent-01 produce dev-shield-stream-batch-v1 --key 10 --proto-include ~/git/shared-protobuf/kafka/shield/ --proto-type shield.StreamBatch --confluent-header --schema-registry-key $SRKEY --schema-registry-secret $SRSECRET --schema-registry-url https://psrc-knmwm.us-east-2.aws.confluent.cloud
message payload
{"batch_i_d":10, "stream_i_d":12, "name":"name1", "description":"description1", "agent_i_d":2, "is_active": true}
Output of consume command:
{
  "agentID": 2,
  "batchID": 10,
  "description": "description1",
  "isActive": true,
  "name": "name1",
  "streamID": 12
}

@helenhazelwood If you need this functionality sooner than it gets reviewed/merged, feel free to just install from branch

this lgtm Kevin. Thanks for figuring it out.


UX Assurance - Grey Bars on Side of Queue

Title of ticket: UX Assurance - Grey Bars on Side of Queue
Description
Grey Bars on side of Queue are thicker than the grey bars used throughout the rest of the app where the left nav bar is in play.
Dependencies
Are there any dependencies?
DOD

[ ] Decrease size of grey bar on either side of the queue to match the size elsewhere in the app
[ ] By decreasing size of grey bars on queue page this will allow for more spacing in queues

Screenshots for reference

fixed as part of 1076

@nkan-aot Thanks for flagging this duplication, I'll review. Wanted to ask did we increase the width of the queue with that? or is there just more white space around the queue?

reason being queue already matched the width of the navbar

@nkan-aot This ticket is basically highlighting to do the opposite to increase the size of the page and decrease the size of the grey bars. This is because we had a user in training who outlined they found things difficult to see as they had glasses, we also will be adding an additional column to the processing queues, and the additional space is really needed to make that more readable. So this is a dependency on the column change ticket so we have space for it before we add it

@nkan-aot Sounds good, feel free to add that here and increase the estimate based on the work

@JHarrietha-AOT how wide do you want the queue? currently it is 62% width (19% margin on both sides)

@nkan-aot Great work on this give everything more space and just feels easier to look at!