minesweeper: tests should expect ArgumentError

Expected Behavior

The Minesweeper tests should expect Board.transform to raise ArgumentError when the method is passed invalid data.
Current Behavior

The tests expect Board.transform to raise ValueError, which is different from all other Ruby exercises.
Possible Solution

Replace ValueError with ArgumentError.

Sounds reasonable 👍
Do you want to make a pull request for this?
The file to change would be: https://github.com/exercism/ruby/blob/master/exercises/minesweeper/minesweeper_test.rb

I've got the change in the hopper. I'll try to get to a PR today.

Submitted!

Resolved by #779


Enable usage of LDL_DISABLE_POINTONE in ldl_sm.h via include

Enable usage of LDL_DISABLE_POINTONE in ldl_sm.h via include in "ldl.platform.h".
Otherwise the symbol was not known in ldl_sm.c.
(Note: This is my 1st pull request, please excuse any errors I made.)

Thanks, I missed that one.
I'm still putting together a contribution guide which will help to define good pull requests.
This kind of pull request is fine. It has a comment suitable for master and is easy for me to review.


Switch destination repository from Shopify/stable to Shopify/public.

Part of the clean-up effort for https://github.com/Shopify/secops/issues/73.  Will be cleaned up once we are able to make Shopify/stable a private repository.
@burke @mutemule @JonPulsifer

LGTM

I'd give you a thumbs up but you're so fast! Have one anyway. 👍


Add helpers

I just tried to build and it failed due to the lack of the helpers.  This commit adds them.  I'm guessing this was just an oversight in #6, @mwcraig ?  If so, feel free to just hit merge here.

Huh pretty sure I saw Matt add some of those in one of the diff notifications... :thinking:
Oh... Was it pllim/astrowidgets#1 ?

Oh, I think Matt added them in #7 but it is not merged yet.

Ahh, gotcha. I won't merge now then since it might be a pain for @mwcraig to disentangle it from #7.  But if you think #7 will take a bit, maybe merge this and rebase @mwcraig ? (I'll leave it to you to make the final call.)

NOTE: this branch should be deleted when merged/closed - it's only in this repo because it was prior to the migration to astropy (and would normally have been in my fork)

I'm about to merge #7 once travis passes....

Closed by #7


Builder.load_file Fails to Locate .kv File

I placed my UI code into a ui package. When I attempt to load a .kv file which is next to the accompanying Python module it fails to do so (with an error of "OError: [Errno 2] No such file or directory: '{file name}.kv'"). To correct this I need to do Builder.load_file( "ui/{file name}.kv" ), so it appears the builder is not following the current directory to allow loading relative to the accompanying Python module.

It's not framework error (I thought the same with this error some time ago). The reason for this is that kivy docs do not tell a lot about its kivy.resources module. Try this, @FluxIX :+1:
import os.path
from kivy.resources import resource_add_path

KV_PATH = os.path.abspath(os.path.join(os.path.dirname(__file__), 'ui'))
'''Path of kv files.

"__file__" is the document where this code is located. I assume it's main.py.
'''

resource_add_path(KV_PATH)

You can add any dirs this way to kivy resource system, so you can load the files by simply specyfing their names.
Builder.load_file('myfile.kv')
background_normal: "image.png"
... and so on.
Happy coding!
@dessant seems resolved.

I could add modify the resource path to find the UI files.
Why isn't looking for a kv resource relative to the associated Python file standard behavior?

It seems your issue is resolved. Next time try to visit the #kivy IRC channel on freenode, so we can help you with programming issues.
Answering your question, resource management as that in Kivy is found in several gui toolkits. While many are allowing the programmer to place the files only in specific dirs, kivy is liberal in this topic. But...
When you are launching the kivy program (or any other python program) all paths hardcoded like 'somedir/somefile.txt' are relative to the script executed.  So that means that depending on the directories structure, your program may or may not work. Kivy resolves this issue: if you will be adding the paths with your custom files using kivy.resources.resource_add_path, you can achieve your expected behavior to load files in specific directories.
Secondly, I am not sure if from language point of view Builder can see from which script he was called to load_file. So your goal may be not possible simply from Python architecture reason.
While working with filesystem, os.path is the preferred way to resolve path names. Kivy does it for you most of the time, if you'll be nice to tell it, where the files may be placed :)
Believe me, I was struggling with the same problem for a lot of time. The day when I found kivy.resources module was my savior.
Use the wheel, do not reinvent it ;)
Cheers.

I think my issue with the adding the resource path is it potentially needs to be done in every *.py file associated with a *.kv file.
I'm already looking a patching some issues in Builder, so I'll check if it's possible for the *.kv file parsing to be aware of the directory the file came from.


Bigquery integration

I'd like to propose a new integration/decorator - bigquery. Remote functions are recently GA.
Basically, this would be similar to the app.post decorator, but also:

create a cloud_resource connection (if it doesn't exist), sharing the name of the goblet app
register the cloud function or cloud run as a remote function in bigquery
require the user to provide the name of the BQ remote function to create, as well as the function type signature

Interested in feedback on the idea!

@AdeelK93 we are working on adding this feature at the moment. Do you have a specific use case in mind already?

Awesome! My use-case: we store big data in BigQuery, but keep a lot of metadata in other systems, that are either only accessible via either API or a database flavor not yet supported by federated queries. This feature would allow me to correlate such data with metadata, joining SQL to the output of a Python function in a real-time manner.
Another related use-case would involve working with other real-time APIs, like economic data. Goblet let's us have reproducible and easy builds for such a pattern.
Let me know if there's anything else I can do to help with development!

@AdeelK93 this feature is out in the latest release of 0.10.0 . Let us know how it goes and if any changes/ improvements are needed!


Settings Sync with github cause excessive CPU usage and integrated terminal hang after VSCode lost focus

Issue Type: Bug
Does this issue occur when all extensions are disabled?: Yes
Steps to Reproduce:

Open procmon to monitor accessed files by VSCode
Open procexp to monitor CPU usage by VSCode
Enable Sync Settings in VSCode
Open Integrated Terminal in VSCode
Change focus to other application
Back to VSCode, try typing in Integrated Terminal
For some seconds the terminal becomes inoperative
Observe that during this terminal hang coincides at the same time that files are accessed and CPU usage
This always happens, is not the first load
Disable Sync Settings in VSCode
Repeat change focus
No files are accessed anymore and no more CPU usage

Details:
There are some months I'm faced with a strange behavior that causes the terminal to hang for some seconds. I noticed when this occurs the process of VSCode goes to 12% (a full thread usage). This "processing" starts when I change the focus to another application. But when I go back to VSCode the integrated terminal becomes inoperative for some seconds.
I disable all extensions and the problem continue. After a lot of time of investigation, I found the problem. Using procmon I realized a lot of files are accessed when I change the active application.
This includes manuy files in this dir:
C:\Users\user\AppData\Roaming\Code\User\sync\
And others of package.json in numerous directories (I have many extensions, I work with many languages):
C:\Users\user\AppData\Local\Programs\Microsoft VS Code\resources\app\extensions*
C:\Users\user\.vscode\extensions*
If I disable the github synchronization no more file are accessed and the terminal doesn’t freeze more.
VS Code version: Code 1.59.1 (3866c3553be8b268c8a7f8c0482c0c0177aa8bfa, 2021-08-19T11:56:46.957Z)
OS version: Windows_NT x64 10.0.19042
Restricted Mode: No

System Info

Item
Value

CPUs
Intel(R) Core(TM) i7-4790 CPU @ 3.60GHz (8 x 3600)

GPU Status
2d_canvas: enabledgpu_compositing: enabledmultiple_raster_threads: enabled_onoop_rasterization: enabledopengl: enabled_onrasterization: enabledskia_renderer: enabled_onvideo_decode: enabledvulkan: disabled_offwebgl: enabledwebgl2: enabled

Load (avg)
undefined

Memory (System)
31.91GB (14.32GB free)

Process Argv
. --crash-reporter-id 39e6c5ea-3b90-4eb4-8ac9-794f5bafee9e

Screen Reader
no

VM
0%

Extensions: none
A/B Experiments
vsliv368:30146709
vsreu685:30147344
python383cf:30185419
pythonvspyt602:30300191
vspor879:30202332
vspor708:30202333
vspor363:30204092
pythonvspyt639:30300192
pythontb:30283811
pythonptprofiler:30281270
vsdfh931cf:30280410
vshan820:30294714
vstes263:30335439
vscoreces:30358480
pythondataviewer:30285071
pythonvsuse255:30340121
vscod805cf:30301675
pythonvspyt200:30340761
vscextlangct:30333562
binariesv615:30325510
pythonvssor306:30344512
bridge0708:30335490
pygetstartedt2:30360495
bridge0723:30353136
pythonf5test824:30361777
vsdyn478:30356813
pythonvspyt187cf:30361754
pydsgst2:30361792
vscus224:30358039

It is because settings sync & terminal features are running in the same process ie., shared process. Can you please profile the shared process and share the information with us. You can do it by following this link - https://github.com/microsoft/vscode/wiki/Performance-Issues#profiling-the-shared-process

First, thank you very much for the reply! Did you try to reproduce the problem and observe the useless file access with procmon? Here is the requested file. I disabled all extensions and recorded the profile with the problem occurring 3 or 4 times. Thanks!
CPU-20210907T201732.zip

I do not reproduce the problem. I have settings sync on always and I do not see any perf issues. Let me investigate your profile and see what's happening.

@vaniusrb Looked at the profile and it seems sync is taking lot of time. Can you also provide settings sync log? You can get it using following command
F1 > Open View... > Log (Settings Sync)

Hi, @sandy081! Here:
[2021-09-28 21:11:54.370] [settingssync] [info] Auto Sync: Triggered by Activity
[2021-09-28 21:11:54.734] [settingssync] [info] Settings: No changes found during synchronizing settings.
[2021-09-28 21:11:54.738] [settingssync] [info] Keybindings: No changes found during synchronizing keybindings.
[2021-09-28 21:11:54.745] [settingssync] [info] Snippets: No changes found during synchronizing snippets.
[2021-09-28 21:12:03.164] [settingssync] [info] GlobalState: No changes found during synchronizing ui state.
[2021-09-28 21:12:03.341] [settingssync] [info] Extensions: No changes found during synchronizing extensions.
[2021-09-28 21:12:03.343] [settingssync] [info] Sync done. Took 8688ms
[2021-09-28 21:13:07.649] [settingssync] [info] Auto Sync: Triggered by Activity
[2021-09-28 21:13:08.021] [settingssync] [info] Settings: No changes found during synchronizing settings.
[2021-09-28 21:13:08.025] [settingssync] [info] Keybindings: No changes found during synchronizing keybindings.
[2021-09-28 21:13:08.034] [settingssync] [info] Snippets: No changes found during synchronizing snippets.
[2021-09-28 21:13:16.575] [settingssync] [info] GlobalState: No changes found during synchronizing ui state.
[2021-09-28 21:13:16.762] [settingssync] [info] Extensions: No changes found during synchronizing extensions.
[2021-09-28 21:13:16.766] [settingssync] [info] Sync done. Took 8822ms
[2021-09-28 21:13:40.945] [settingssync] [info] Auto Sync: Triggered by Activity
[2021-09-28 21:13:41.313] [settingssync] [info] Settings: No changes found during synchronizing settings.
[2021-09-28 21:13:41.319] [settingssync] [info] Keybindings: No changes found during synchronizing keybindings.
[2021-09-28 21:13:41.329] [settingssync] [info] Snippets: No changes found during synchronizing snippets.
[2021-09-28 21:13:49.866] [settingssync] [info] GlobalState: No changes found during synchronizing ui state.
[2021-09-28 21:13:50.047] [settingssync] [info] Extensions: No changes found during synchronizing extensions.
[2021-09-28 21:13:50.049] [settingssync] [info] Sync done. Took 8811ms

It looks like it takes 8 seconds checking for changes in "GlobalState" stage.

Here:
[2021-10-09 22:24:21.265] [settingssync] [trace] activity sources windowFocus
[2021-10-09 22:24:21.266] [settingssync] [info] Auto Sync: Triggered by Activity
[2021-10-09 22:24:21.266] [settingssync] [trace] Sending request to server {"url":"https://vscode-sync.trafficmanager.net/v1/manifest","type":"GET","headers":{"X-Execution-Id":"7d454331-7bb0-42de-9612-c3514ec64761","Content-Type":"application/json","If-None-Match":"W/\"171-UcE5eRXBrsdTiGCbs1McgMZ2Dlc\"","X-Client-Name":"code","X-Client-Version":"1.60.2","X-Machine-Id":"aa090f68-8d89-4c5d-87f0-85962136086f","X-Client-Commit":"7f6ab5485bbc008386c4386d08766667e155244e","X-Account-Type":"github","X-Machine-Session-Id":"f10857f4-895e-4c7f-82b0-6cf8024188a2","X-User-Session-Id":"b2d7ac5b-d51e-47cd-af7e-16b6c9a7877c"}}
[2021-10-09 22:24:21.573] [settingssync] [trace] Request succeeded {"url":"https://vscode-sync.trafficmanager.net/v1/manifest","status":200,"execution-id":"7d454331-7bb0-42de-9612-c3514ec64761"}
[2021-10-09 22:24:21.573] [settingssync] [trace] Sync started.
[2021-10-09 22:24:21.573] [settingssync] [trace] Settings: Started synchronizing settings...
[2021-10-09 22:24:21.632] [settingssync] [trace] Settings: Merging remote settings with local settings...
[2021-10-09 22:24:21.633] [settingssync] [info] Settings: No changes found during synchronizing settings.
[2021-10-09 22:24:21.634] [settingssync] [trace] Settings: Finished synchronizing settings.
[2021-10-09 22:24:21.634] [settingssync] [trace] Keybindings: Started synchronizing keybindings...
[2021-10-09 22:24:21.637] [settingssync] [info] Keybindings: No changes found during synchronizing keybindings.
[2021-10-09 22:24:21.638] [settingssync] [trace] Keybindings: Finished synchronizing keybindings.
[2021-10-09 22:24:21.638] [settingssync] [trace] Snippets: Started synchronizing snippets...
[2021-10-09 22:24:21.643] [settingssync] [trace] Snippets: Merging remote snippets with local snippets...
[2021-10-09 22:24:21.644] [settingssync] [info] Snippets: No changes found during synchronizing snippets.
[2021-10-09 22:24:21.646] [settingssync] [trace] Snippets: Finished synchronizing snippets.
[2021-10-09 22:24:21.646] [settingssync] [trace] GlobalState: Started synchronizing globalstate...
[2021-10-09 22:24:29.600] [settingssync] [trace] GlobalState: Merging remote ui state with local ui state...
[2021-10-09 22:24:29.601] [settingssync] [info] GlobalState: No changes found during synchronizing ui state.
[2021-10-09 22:24:29.604] [settingssync] [debug] Auto Sync: Skipped. Limited to once per 10 seconds.
[2021-10-09 22:24:29.612] [settingssync] [trace] GlobalState: Finished synchronizing globalstate.
[2021-10-09 22:24:29.612] [settingssync] [trace] Extensions: Started synchronizing extensions...
[2021-10-09 22:24:29.820] [settingssync] [trace] Extensions: Merging remote extensions with local extensions...
[2021-10-09 22:24:29.820] [settingssync] [info] Extensions: No changes found during synchronizing extensions.
[2021-10-09 22:24:29.823] [settingssync] [trace] Extensions: Finished synchronizing extensions.
[2021-10-09 22:24:29.823] [settingssync] [info] Sync done. Took 8249ms

Thanks again, @sandy081

I see, so you do not see this issue when settings sync is off?

If I uncheck "UI State" then became faster:
[2021-10-12 17:33:07.829] [settingssync] [trace] Sync started.
[2021-10-12 17:33:07.829] [settingssync] [trace] Settings: Started synchronizing settings...
[2021-10-12 17:33:07.925] [settingssync] [trace] Settings: Merging remote settings with local settings...
[2021-10-12 17:33:07.925] [settingssync] [info] Settings: No changes found during synchronizing settings.
[2021-10-12 17:33:07.926] [settingssync] [trace] Settings: Finished synchronizing settings.
[2021-10-12 17:33:07.926] [settingssync] [trace] Keybindings: Started synchronizing keybindings...
[2021-10-12 17:33:07.928] [settingssync] [info] Keybindings: No changes found during synchronizing keybindings.
[2021-10-12 17:33:07.929] [settingssync] [trace] Keybindings: Finished synchronizing keybindings.
[2021-10-12 17:33:07.929] [settingssync] [trace] Snippets: Started synchronizing snippets...
[2021-10-12 17:33:07.933] [settingssync] [trace] Snippets: Merging remote snippets with local snippets...
[2021-10-12 17:33:07.933] [settingssync] [info] Snippets: No changes found during synchronizing snippets.
[2021-10-12 17:33:07.935] [settingssync] [trace] Snippets: Finished synchronizing snippets.
[2021-10-12 17:33:07.935] [settingssync] [info] GlobalState: Skipped synchronizing globalstate as it is disabled.
[2021-10-12 17:33:07.935] [settingssync] [trace] Extensions: Started synchronizing extensions...
[2021-10-12 17:33:08.069] [settingssync] [trace] Extensions: Merging remote extensions with local extensions...
[2021-10-12 17:33:08.070] [settingssync] [info] Extensions: No changes found during synchronizing extensions.
[2021-10-12 17:33:08.080] [settingssync] [trace] Extensions: Finished synchronizing extensions.
[2021-10-12 17:33:08.080] [settingssync] [info] Sync done. Took 251ms

I am not aware of the file service "blocking" when reading a file from disk.

@sandy081 I understood your trace. But in the reality the file was always accessed very quickly, like this:

Is there no possibility that the "this.fileService.readFile" method is suffering from a blocking problem?

@bpasero Please check following log statements
[2021-10-16 16:44:23.182] [settingssync] [debug] GlobalStateSync#getLocalArgvContent {"$mid":1,"fsPath":"c:\\Users\\vaniu\\.vscode-insiders\\argv.json","_sep":1,"path":"/C:/Users/vaniu/.vscode-insiders/argv.json","scheme":"file"}
[2021-10-16 16:44:31.602] [settingssync] [debug] GlobalStateSync#getLocalArgvContent - Resolved {"$mid":1,"fsPath":"c:\\Users\\vaniu\\.vscode-insiders\\argv.json","_sep":1,"path":"/C:/Users/vaniu/.vscode-insiders/argv.json","scheme":"file"}

https://github.com/microsoft/vscode/blob/532f25c4ac5b2435f41050ebeafca3e98433fcac/src/vs/platform/userDataSync/common/globalStateSync.ts#L295
It seems fileService is taking 8s to read the file and somehow blocking the shared process may be which is causing slowness for user.
Can you please check why this is slow and blocking?


Bitbucket issue tracking for index suggestions

For getting ideas about new items that can be added to the documentation index, I have added a Python script that scrapes the Gazebo repository issues using Bitbucket's API and extracts important keywords from the issue's title, content and/or the comments.
By default the results are sorted based on the vote-count of the issue, but by using the --sort_by_updated parameter issues can be sorted based on the order of updation. More control can be performed on the results by using the other parameters, based on the requirements.
Pre-requisites:
pip3 install rake_nltk
python -c "import nltk; nltk.download('stopwords')"

How to run:
python3 bitbucket_issue_tracker.py

Example result ->

Next, need to work on linking index entries to these results.

Added code for Gazebo Answers scraping -

Scrapes the webpage to get ID and title of each question (currently sorted by number of votes).
Using this question-ID, get requests are made to the RSS feed of the specific question and from that the keywords of the question's and answers' content are extracted.
Currently only Q&A are used for keyword-extraction (comments of Q&A are not being used)
Parameters added for page-count, keyword-extraction configuration and for printing the Q&A content along with the keywords.
For better visibility of results, keywords' output are in bold format (can be made of different colors too.)

I have made a separate code for this (instead of adding this code to the bitbucket_issue_tracker.py file) just to demonstrate the results because the structure of Bitbucket issues and Gazebo Q&A is a little different (Bitbucket has Issues&comments vs Gazebo answers has Q&A&comments).
Both the codes can be merged if the Gazebo answers' scraping seems fine.

The parsing of answers looks good to me, although we will need to filter some obvious false positives (URLs, symbols, etc).
A great work to be the beginning of something interesting. Congrats Mukul!


AuthenticateSession and Cookie Encryption Error on Remember_web

Laravel Version: 7.11.0
PHP Version: 7.4.4
Database Driver & Version: Mysql 8

Description:
when the AuthenticateSession middleware runs his check on ($this->auth->viaRemember())  will get remember_web cookie as null  via  $request->cookies->get($this->auth->getRecallerName()) resulting in an Undefined offset: 2 ErrorException as soon the middleware tries to explode the null value.
I've already checked into SessionGuard.php to make sure the cookie is properly formed and queued, and it's work properly.
i'm not sure if the cookie get a new encryption, or if it dont get decrypted at all.
but i tryed to move  \Illuminate\Session\Middleware\AuthenticateSession::class on top of \App\Http\Middleware\EncryptCookies::class and this let the request get the cookie properly
Steps To Reproduce:
install the default scafolding login. enable the AuthenticateSession middleware and login with remember checked

Update: i've noticied that EncryptCookie middleware produce an error when trying to decrypt the remember_web cookie, so i've dumped it to debug and noticied that the information inside the cookie are not encrypted at all!
so it only normal it will fail and set it to null.
im still struggling to understand why SessionGuard wont encrypt it properly when using CookieJar

Unable to recreate. Works fine.


Update all components to use Rects

Each tool needs to have its components updated to work with new rect system

This has been fixed.


Add an option to the tmux plugin to force 256 colors.

Tmux has a command line option to force 256 colors wether tmux thinks the terminal supports it or not. For some reason tmux thinks gnome-terminal doesn't support 256 colors, so this option makes life a bit easier.
This pull request adds an option for the oh-my-zsh tmux plugin, so tmux can be called with the '-2' command line argument, forcing 256 colors.

As can be read in pull request #3128, this can be easily fixed by setting the TERM environment variable.


Which standard for defaultRegion string parameter?

Parsing a phone number requires a region code string.
public PhoneNumber parse(String numberToParse, String defaultRegion)
The documentation does not specify what standard is used for this region code.
RegionCode.java have correct contants that could be useful but this is a test class not exposed in the library. Why not expose it? Or is there an external standard I can use to make sure the input is correct?
Thanks

Agreed, the Javadoc / API docs should specify the identifier system used for regions. That's a bug.
To answer the question:
We use ISO 3166-1 alpha-2 country codes plus UN M.49 (3 digit) codes for higher level containers such as 001 for the world. The same system (combination of ISO and UN M.49) is used by Unicode / CLDR.
http://www.unicode.org/cldr/charts/latest/supplemental/territory_containment_un_m_49.html
Lots of functions that use a regionCode string that need better Javadoc:
PhoneNumberUtil.java :
public Set getSupportedRegions()
private boolean isValidRegionCode(String regionCode)
public String formatNumberForMobileDialing(PhoneNumber number, String regionCallingFrom,
boolean withFormatting)
...
public PhoneNumber getExampleNumber(String regionCode)
public boolean isValidNumberForRegion(PhoneNumber number, String regionCode)
...
public String getRegionCodeForCountryCode(int countryCallingCode)
...
public AsYouTypeFormatter getAsYouTypeFormatter(String regionCode)
...
public PhoneNumber parse(String numberToParse, String defaultRegion)

Thanks for the clarification!

For posterity: this is documented at the top of all our libraries, e.g. here:
https://github.com/googlei18n/libphonenumber/blob/master/java/libphonenumber/src/com/google/i18n/phonenumbers/PhoneNumberUtil.java#L47


Add - e2e tests for alcohol % calculations on DC RoW-GB/RoW-XI + Permutations conditions pop ups for declarable headings

[x] Add missing e2e tests for alcohol percentage calculations

[x] RoW-GB

[x] RoW-XI

[x] Extend tests for permutations for declarable headings

Nice!


Made keepEmptyLines optional

If one decides to only use something of TransformOptions (e.g. encoding), it wouldn't be possible to omit the keepEmptyLines option.

@nikeee thanks mate!

note
https://github.com/jahewson/node-byline/blob/af737e83cc50b87ed2204e8faf48695b2f1ec13f/lib/byline.js#L70


Different values are being shown in PointerLabelComponent using LineChart

Hi! 👋
I am using this package with these versions.

"react-native-gifted-charts": "^1.4.10"
"react": "18.2.0"
"react-native": "0.74.0",

I was trying to pass a data to LineChart and show it using PointerConfig. The graph was rendered with the correct values but the PointerConfig had different values. This is my code for rendering LineChart:
           <LineChart
              areaChart
              data={chartData}
              rotateLabel
              yAxisOffset={chartData[0]?.value - 20}
              width={widthToDp(100)}
              hideDataPoints
              color="#00ff83"
              thickness={2}
              startFillColor="rgba(20,105,81,0.3)"
              endFillColor="rgba(20,85,81,0.01)"
              startOpacity={0.9}
              endOpacity={0.2}
              initialSpacing={0}
              noOfSections={5}
              yAxisThickness={0}
              rulesColor="transparent"
              yAxisTextStyle={{color: Colors.white}}
              xAxisColor="lightgray"
              pointerConfig={{
                pointerStripHeight: widthToDp(15),
                pointerStripColor: 'lightgray',
                pointerStripWidth: 2,
                pointerStripHeight: widthToDp(40),
                pointerColor: 'lightgray',
                radius: 6,
                pointerLabelWidth: widthToDp(20),
                pointerLabelHeight: widthToDp(20),
                activatePointersOnLongPress: true,
                autoAdjustPointerLabelPosition: false,
                pointerLabelComponent: items => {
                  // console.log(items);
                 // The values inside the items were different to the data provided
                  return (
                    <View
                      style={{
                        height: 90,
                        width: 100,
                        justifyContent: 'center',
                        marginTop: -30,
                        marginLeft: -40,
                      }}>
                      <Text
                        style={{
                          color: 'white',
                          fontSize: 14,
                          marginBottom: 6,
                          textAlign: 'center',
                        }}>
                        {items[0].date}
                      </Text>

                      <View
                        style={{
                          paddingHorizontal: 14,
                          paddingVertical: 6,
                          borderRadius: 16,
                          backgroundColor: 'white',
                        }}>
                        <Text
                          style={{
                            fontWeight: 'bold',
                            textAlign: 'center',
                            color: 'black',
                          }}>
                          {'$' + items[0].value}
                        </Text>
                      </View>
                    </View>
                  );
                },
              }}
            />

Here is the diff that solved my problem:
// var data = useMemo(function () { return getSanitisedData(props.data, dataSanitisationProps); }, [yAxisOffset, props.data]);
    var data = useMemo(function () { return props.data; }, [yAxisOffset, props.data]);
    var data2 = useMemo(function () { return getSanitisedData(props.data2, dataSanitisationProps); }, [yAxisOffset, props.data2]);
    var data3 = useMemo(function () { return getSanitisedData(props.data3, dataSanitisationProps); }, [yAxisOffset, props.data3]);
    var data4 = useMemo(function () { return getSanitisedData(props.data4, dataSanitisationProps); }, [yAxisOffset, props.data4]);
    var data5 = useMemo(function () { return getSanitisedData(props.data5, dataSanitisationProps); }, [yAxisOffset, props.data5]);
    var secondaryData = (_e = getSecondaryDataWithOffsetIncluded(props.secondaryData, props.secondaryYAxis, showDataPointsForMissingValues, interpolateMissingValues, onlyPositive)) !== null && _e !== void 0 ? _e : [];

Original Data
[{"date": "2023-05-23", "time": "16:00:00", "value": 306.88}, {"date": "2023-06-09", "time": "16:00:00", "value": 387.7}, {"date": "2023-06-28", "time": "16:00:00", "value": 411.17}, {"date": "2023-07-17", "time": "16:00:00", "value": 464.61}, {"date": "2023-08-02", "time": "16:00:00", "value": 442.69}, {"date": "2023-08-18", "time": "16:00:00", "value": 432.99}, {"date": "2023-09-06", "time": "16:00:00", "value": 470.61}, {"date": "2023-09-22", "time": "16:00:00", "value": 416.1}, {"date": "2023-10-10", "time": "16:00:00", "value": 457.98}, {"date": "2023-10-26", "time": "16:00:00", "value": 403.26}, {"date": "2023-11-13", "time": "16:00:00", "value": 486.2}, {"date": "2023-11-30", "time": "16:00:00", "value": 467.7}, {"date": "2023-12-18", "time": "16:00:00", "value": 500.77}, {"date": "2024-01-05", "time": "16:00:00", "value": 490.97}, {"date": "2024-01-24", "time": "16:00:00", "value": 613.62}, {"date": "2024-02-09", "time": "16:00:00", "value": 721.33}, {"date": "2024-02-28", "time": "16:00:00", "value": 776.63}, {"date": "2024-03-15", "time": "16:00:00", "value": 878.37}, {"date": "2024-04-03", "time": "16:00:00", "value": 889.64}, {"date": "2024-04-19", "time": "16:00:00", "value": 762}, {"date": "2024-05-07", "time": "16:00:00", "value": 905.54}, {"date": "2024-05-23", "time": "16:00:00", "value": 1037.99}],
Data from Items Array before patching
 LOG  [{"date": "2023-08-02", "time": "16:00:00", "value": 155.81}]  LOG  [{"date": "2023-08-02", "time": "16:00:00", "value": 155.81}]  LOG  [{"date": "2023-06-28", "time": "16:00:00", "value":<PHONE_NUMBER>0000002}]  LOG  [{"date": "2023-06-09", "time": "16:00:00", "value": 100.82}]  LOG  [{"date": "2023-06-28", "time": "16:00:00", "value":<PHONE_NUMBER>0000002}]  LOG  [{"date": "2023-07-17", "time": "16:00:00", "value":<PHONE_NUMBER>0000002}]  LOG  [{"date": "2023-07-17", "time": "16:00:00", "value":<PHONE_NUMBER>0000002}]
To Reproduce this issue:
Pass the above original data with the given LineChart props

Hi @AbdulHadi1010 👋
Thanks for reporting this issue. It has been fixed in versions 1.4.17 onwards. 🎉
Please use the latest version of the library.


the text of next button has mistake

Prerequisites

[ ] Can you reproduce? Yes
[ ] Are you running the latest version of SoftEtherVPN? No

**SoftEther version: 5.02.5180
**Component: Setup
**Operating system: Windows
**Architecture: 64 bit
Description
The problem is, in chinese system environment, when running setup.exe, the "next" button is translated to "下一页", while the "prev" button is translated to "上一步"。
the right text should be "下一页"&“上一页”， or “下一步”&“上一步”。
I didn't find the place to modify this text, please tell me how to modify the text of this button, or just change the text to "下一页"&“上一页”。

please find "*.stb" in src/bin/hamcore folder. you are welcome to create PR.

I have search strtable_cn.stb and strtable_en.stb, and found nowhere related to this button.
Search for “prev” button, I tried "上一步"， and the result has only one place which is under * PREFIX D_TCP_MSG .
Search for "next" button, I tried "下一页", and the result still has nowhere under * PREFIX SW_ *

CentOS7版视频安装教程：https://youtu.be/fWGw6Qdh1pY
Windows版视频安装教程：https://youtu.be/lXb7FxxEcE0

The translation is correct, corresponding to Next and Back.

The translation is correct, corresponding to Next and Back.

it is correct, but not elegant


[Relax] Remove the legalization of cumsum/cumprob

Remove the legalization for cumsum/cumprob, DispatchSortScan in default pipeline should work for them

@tvm-bot rerun


RO-3814: V1.08 Update population of rcsb_entity_source_organism.provenance_source

Jira ticket: https://rcsbpdb.atlassian.net/browse/RO-3814
First, in DictMethodCompModelHelper.py:

If CSM and ma_target_ref_db_details.db_name is "UNP" -> set entity_src_nat.rcsb_provenance_source to UniProt
If CSM and ma_target_ref_db_details.db_name is "Other" -> set entity_src_nat.rcsb_provenance_source to NCBI

.
Then, in DictMethodEntityHelper.py:

If Experimental structure:

set _rcsb_entity_source_organism.provenance_source to "Primary Data"

Else if CSM and entity_src_nat.rcsb_provenance_source exists:

set _rcsb_entity_source_organism.provenance_source to the value of entity_src_nat.rcsb_provenance_source (i.e., UniProt or NCBI)

@brindakv Thanks for the review and feedback. I've adjusted the code to handle cases in such a manner. Can you please re-review?


BLE causes system sleep before main

Describe the bug
When the BLE subsystem is enabled (CONFIG_BT=y) then system enters idle thread (sleep) before main function is invoked.
Tested on blinky sample with CONFIG_BT=y and with small code changes as described below.
main.c
...
volatile uint32_t idle_counter = 0;

void main(void)
{
        if (idle_counter > 0) {
                printk("idle_entry: %u", idle_counter);
        }
...

idle.c
...
	while (true) {
	    extern volatile uint32_t idle_counter;
	    idle_counter++;
...

Target (board) is nucleo_wb55rg.
To Reproduce
Steps to reproduce the behavior:

Modify blinky sample and idle.c as described above.
west build --board=nucleo_wb55rg
west flash
See output on console: idle_entry: 2

Expected behavior
System should not sleep before entering main or this behavior should be documented.
Impact
annoyance
Environment (please complete the following information):

OS: Linux
Toolchain Zephyr SDK 0.13.1
Commit SHA: 44462723f59ddcc0786af0b5406122476c2addf9

It seems that this problem is not STM32 specific.
I had a try to prevent system to enter PM_STATE_SUSPEND_TO_IDLE during HCI driver init _bt_ipm_init, but this had no effect on the issue.
@jhedberg Would you mind having a look on BLE stack side?

@erwango there is no PM related code on the host side of the Bluetooth stack, so not sure what you’re requesting.

@erwango there is no PM related code on the host side of the Bluetooth stack, so not sure what you’re requesting.

Sure, but maybe the point is that there are sleep intervals during BLE stack initialization that let the PM subsystem going into PM state while it should prevent it (using pm_constraint_). This could also be a larger system issue, applicable to all stacks and in that case, this should be fixed directly by PM subsystem. I hope @ceolin may give directions.

From the pm subsystem there is nothing preventing it from put the system to sleep. We can ensure that the system does not go to sleep before reach the main, this seems very reasonable. Though, there is a thumb rule where anyone doing an operation that the system shouldn't sleep has to set constraints.

Though, there is a thumb rule where anyone doing an operation that the system shouldn't sleep has to set constraints.

This seems logical but:

would we be able to enforce that ?
how can this be technically applied? (how a driver or a subsystem would know that main was entered yet or not. In some cases (init functions), it is simple, but in some subroutines used widely, response is not that easy.

@r2r0 I just had a debug session in this use case here are my observations:

No k_sleep is done anywhere before main is reached
When going step by step into STM32 IPM HCI driver, the issue disappear > Root cause is around this

I think what we're seeing is normal here, and not a bug.
According to @andyross:

In a technical sense yes: on a SMP system the extra CPUs will likely reach idle (each has its own idle thread obviously) before system initialization is complete and the application main() function is entered.  But that's not your platform.

This is actually our case here. Well, this is not a SMP but we do have a second core (M0), which is initialized during main core boot process (as part of ipm hci driver init). During M0 initialization, main core is waiting (a semaphore to released by a message coming from M0) and then idle thread is entered. This seems actually normal to me and I don't see a specific bug to fix here.
What is strange is that I had a try to prevent to block idle entry (using pm_constraint_set around whole driver init), this had no effect. But this could be expected. @ceolin could you help clarifying this ?

Hi @erwango, constraints don't prevent the system to goes idle, they prevent the system of suspending, aka going to "deep" sleep.

Hi @erwango, constraints don't prevent the system to goes idle, they prevent the system of suspending, aka going to "deep" sleep.

Ok, so I think there is nothing that can be done and I'd say there is nothing to fix here.
@r2r0 is it fine with you ?

Reopening as https://github.com/zephyrproject-rtos/zephyr/pull/41935 doesn't solve issue reported.
Though, I think that there is no issue to be solved.
Waiting @r2r0 to confirm.

yep. I had removed the linkage between the pr and the issue, also removed the "fixes" from the commit message, but somehow the issue was automatically closed

Ok, it is clear now to me that system behaior is correct. Thanks a lot for fast proceeding.
I wonder if it should be somehow documented - mainly in context of PM notifiers.
I.e. what is the lowest system initialization level/priority when PM notifiers can be called.
User hooks usually will need some context initialization and it will help users to know when it should be done.

I wonder if it should be somehow documented - mainly in context of PM notifiers.

@ceolin @r2r0 please open an Enhancement issue for documenting this behaviour if you want to.


The hotspot ceased all the activity regarding beacons and witnesses

To whom who may concern,
I’m opening this post in order to put to the attention of who may concern, about a big issue Nebra devices are getting into really often.
The device is a Nebra 1st gen version, batch 3. The hotspot is connected via ethernet cable cat. 6. The internet connection is high speed FTTH 1 GB/s, dynamic IP. The hotspot has been successfully installed on September 20th and begin the operational activity with stock 3 dbi antenna until November 4th, when a 5.8 dbi fiberglass antenna has been installed. This improvement enhanced the rewards, reaching 0.3 HNT/day on 7 day moving average. Following the major outages the blockchain experienced on late November, beginning from November 26th the hotspot ceased all that part of activity related to sending beacons and making witnesses. The only activity is creating challenges and issuing challenges to other hotspots.
In order to address the cause of the issue, I did the following troubleshooting:
•	Checking TCP 44158 port to be open: OK
•	Ping the hotspot via Heliumstatus.io: OK
•	Check the internal diagnostic page via internal IP: Says “All OK”, hotspot block height same than actual block height.
•	Check the Nebra Dashboard: All ok, synced, all green.
•	Check the Helium Explorer status: Synced
•	Check the hotspot status via api.helium.io: here I noticed that the “last change block” can’t keep the pace of the “block height”. The hotspot after creating the challenge, start falling back behind the last block issued to the blockchain. Simply It can’t keep the pace. Every 6 hours catch up the blockchain and then It slides back.
•	Trying to reboot the hotspot multiple times: done. No improvements in PoC activity.
•	Trying to take the power off for 12 hours: done. No improvements in PoC activity.
As you can see from the attached pictures, besides the witness made on November 27th and December 6th, and the beacon sent on November 28th, no other activity than creating challenges has been one by the hotspot.

I opened a ticket regarding this issue few days ago, but beside the answer got on December 3rd asking to me to plug the power in, I didn’t get any feedback or instruction.
Right now the hotspot is connected to the electricity and with the stock 3 dbi antenna.
IMPORTANT: on November 26th at 00:38 UTC, the Internet Provider reset the internet router. With this event the IP changed, switching from dynamic IP to static IP since I required a static IP in order to avoid problems related to eventual power failures and consequantely IP changes at the router restarting.
I don’t know that this event may be part of the cause of the problem. I leave to verify this to you.
I did my best to put this case to your attention, because I believe It’s causing a lot of concern in many users who invested time and effort in order to start their Helium Project. I'm aware that Github may not be the right place to do this, but the question Is pretty serious and in my opinion, Nebra's costumers deserve better customer care.
Hoping you manage to address this situation and giving to the community a reliable fix. I’m available If you need further information.
Looking forward to hearing from you, best regards.

Good morning,
you can't be surprised If people is looking for other ways to explain their issues If the Nebra customer support fails to answer to open tickets. The problems are real. People paid a lot of money and In change received a poor quality device and zero customer support.
Kind regards


Lint progress

Can you spot the bugfix?

Pre-merge test assessment:

Basic Tests Linux: 9903.
Basic Tests Mac: 9804.
Bazel Full Build & Tests: not yet in effect.
gRPC_interop_pull_requests: 9937.
kokoro: not yet in effect.


Computed Property with wildcard not updated under certain conditions

Description:
Computed property with wildcard keypath does not update, if the only usage of this property is in the expression for a class-* directive and this expression is negated (starts with a exclamation mark).
See reproduction example for clarification.
Versions affected:
1.3.11
Reproduction:
https://jsfiddle.net/lejared/edc6gwn8/33/
There are two computed properties, which are perfectly the same and use the same internal value.
Both properties are only used in a class-* directive in the template.
The difference is, that the expression in the second class-* directive starts with a negation (exclamation mark). This prevents the computed property from being updated when the internal value changes. Remove the exclamation mark or output the computed property additionally in a mustache, then everything works fine.
Also it would be nice, if i did not have to put the dummy call this.get('boxes'); in the computed property getter. It should update automatically if the object in the watched wilcard keypath changes.

The issue here was the computation was getting stuck behind the expression !disabled. I believe I've got that issue resolved in edge now. This also pointed out another issue - nested computations should implicitly depend on their parent model so that they get recomputed when the parent changes. Here's the fiddle with the changes applied. Lemme know if that will resolve this issue.

The fiddle works well with<EMAIL_ADDRESS>I will test with our real world app in the next week.

Tested with our real world app and everything works just fine. Looking forward to the next release!
Thanks.


enable usb weak host workaround to improve android stability

Enable L515 android stability workaround. Current usb buffer settings in device require large number of small usb transactions from device to usb host controller, some hosts with relatively weak host cannot handle this many transactions quickly, results in stability issues, camera disappear from os enumeration or one of the streams dies during stream, etc. This workaround uses larger buffer settings to reduce the number of transaction and improve performance and stability.
Workaround is enabled by default for all android platforms. Requires additional firmware command support in new firmware release.
Tracked on: RS5-8011

@maloel thanks for review feedback. hope the changes addressed concerns.

Hi @gwen2018
The changes are fine. I'm a little hesitant about the FW version... can we delay the merge of this until they give a proper version? Or do you need it in right away?

Hi @gwen2018
The changes are fine. I'm a little hesitant about the FW version... can we delay the merge of this until they give a proper version? Or do you need it in right away?

Thanks. I will check with firmware team.

@ev-mp thanks for the review. refactored the option, included your suggestion, name is host performance mode, because it will be a generic option for future use as well, this time, only include the TRB settings.
at launch, on android platforms, low performance mode is turned on and larger TRB settings, on other platforms (windows, linux, etc.), device default setting is used at launch. user has the option to change the option later after viewer launch.
The option is only for L515, the conditional compilation is minimized (only the launch performance mode).
also added settings for the 4th endpoint (confidence stream). now the settings are complete.


Messy crash on missing key

Can you make the program return a special message if the google api key isn't set? Currently if it crashes, the user may not now what to do.

Solved


generation of DAVIS-training-mp4

Hi, Matias~I'm going to do my research in your FastDVDNet. I try to use other datasets together with the DAVIS-training-mp4 for training. However, when i generate my mp4 files and used them together with DAVIS-training-mp4 for training, error occured  'Assert on "codec_id_ == codec_id" failed: File MP4/train_little/bear.mp4 is not the same codec as previous files  Stacktrace', the reason must be  different codec used in my mp4 files with DAVIS-training-mp4. So i want to konw the codec used in generating DAVIS-training-mp4, or could you give me the codes for preprocessing the DAVIS-training-mp4 in your github from jpg files. Sincerely hope to receive your reply! Thanks very much~

Hi, MatiasI'm going to do my research in your FastDVDNet. I try to use other datasets together with the DAVIS-training-mp4 for training. However, when i generate my mp4 files and used them together with DAVIS-training-mp4 for training, error occured 'Assert on "codec_id_ == codec_id" failed: File MP4/train_little/bear.mp4 is not the same codec as previous files Stacktrace', the reason must be different codec used in my mp4 files with DAVIS-training-mp4. So i want to konw the codec used in generating DAVIS-training-mp4, or could you give me the codes for preprocessing the DAVIS-training-mp4 in your github from jpg files. Sincerely hope to receive your reply! Thanks very much

Hi @Rose0506 ,
You can have a look at https://gist.github.com/m-tassano/0536391eb79d63864e5005ea4da88243 and especially https://gist.github.com/m-tassano/2ec9ffa064484472de8ac7eaf66c2ed8 for the code used to generate the mp4.
Additionally, here you can find the list of Davis sequences in the trainset https://gist.github.com/m-tassano/27c1ef00ca42a8e50c2cee8a4205e559#file-davis_trainseq_list-txt
As for the codec used, I don't unfortunately have access to the machine on which I run the code, so I wouldn't be able to tell you specifically which codec was used.
Hope this helps.

Thanks very much! I also have another question about training details, how to divide the trainig-set and validation-set from the 90  mp4-files in The 2017 DAVIS? Thanks for your help again~

I used all the training videos in the list above for training only.
If you want, the Davis dataset has a separate validation set

By the way, could you recommend the code for generating the frame sequences from mp4? Just corresponding to the code you used to generate the DAVIS data mp4 from sequences.

I assume that you mean how to extract the frames from the mp4s. You can try something like
ffmpeg -skip_frame nokey -i input.mp4 -vsync vfr thumb%04d.png -hide_banner
(I haven't tried it but I believe it  works)


MudForm : Fix registering of form controls

Description

The MudForm keeps track of form controls (MudFormComponent) for validation purpose. Components register themselves with the CascadingParameter Form in the OnInitializedAsync only if they are the top level field (Standalone == true).
Some components were using a sub field component without deactivating the Standalone parameter causing sub components to be registered and crashing validations in my scenario. (I'm gonna open an other PR that need this fix)
Components having this problem are:

MudTextField
MudNumericField

How Has This Been Tested?

Unit tests has been written.
Types of changes

[x] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

[x] The PR is submitted to the correct branch (dev).
[x] My code follows the code style of this project.
[x] I've added relevant tests.

Thank you, very good commit


Can't Window share in Okadash[Enhancement]

Okadash open hangout(meets), I can join its. I can talk.
I can also view another's window sharing.
but if you enable share window, it says something error happens.

I think something permission or so on.
I hope this problem is solved. ( but not have to )

検証してみましたが、おそらく webview のセキュリティ上の制約な気がします 😢


[WIP] Backend Plugins (#38)

Continue work from #38

Since .metadata doesn't return the tiles key of the MosaicJSON, I don't think the /geojson endpoint provided by awspds-mosaic is possible with the current backends?

Since .metadata doesn't return the tiles key of the MosaicJSON, I don't think the /geojson endpoint provided by awspds-mosaic is possible with the current backends?

@kylebarron well this is still possible by using the self.mosaic_def

Oh right, it's just that the tiles key might not exist.

Alright, I'm just waiting for feedback on the read method and on https://github.com/developmentseed/cogeo-mosaic/pull/54. but when done, I'll merge this branch into master so we can merge all the other PR.
I've started some documentation but we'll need more.
cc @kylebarron @geospatial-jeff


wrap exceptions thrown in profile.map calls

this gives end developers the opportunity to setup logging to watch for specific ProfileMappingError, which provides more context when a model might change without Typescript being updated

@stackoverfloweth does this still show you the original error? I'm not familiar with ErrorOptions or what it does when passed to the Error constructor.

@stackoverfloweth does this still show you the original error? I'm not familiar with ErrorOptions or what it does when passed to the Error constructor.

That is my expectation. This is precisely what the property is for.

It is used when catching and re-throwing an error with a more-specific or useful error message in order to still have access to the original error.

https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/Error/cause


Implement application ID

Enable the marking of application IDs from within dmon. Afther the ID has been marked all further metrics should contain said ID.

Verified.


Budget-App | Deployment

PR Details
This pull request contains:

Splash screen

A simple page with the name of your app (yes, you need to choose one), and links to the sign up and log in pages.

Sign up and log in pages

The user should be able to register in the app with full name, email and password (all mandatory).
The user can log into the app using email and password.
If the user is not logged in, they can't access pages that require the user to be logged in (all the pages described below).

Home page (categories page)

When the user logs in, they are presented with the categories page.
For each category, the user can see their name, icon and the total amount of all the transactions that belongs to that category.
When the user clicks (or taps) on a category item, the application navigates to the transactions page for that category.
There is a button "add a new category" at the bottom that brings the user to the page to create a new category.

Transactions page

For a given category, the list of transactions is presented, ordered by the most recent.
At the top of the page the user could see the total amount for the category (sum of all of the amounts of the transactions in that category).
There is a button "add a new transaction" at the bottom that brings the user to the page to create a new transaction.
When the user clicks on the "Back" button (<), the user navigates to the home page.

"Add a new category" page

The user fills out a form to create a new category, indicating their name and icon (both mandatory).
The user clicks (or taps) the "Save" button to create the new category, and is taken to the home page on success.
When the user clicks on the "Back" button (<), the user navigates to the home page.

"Add a new transaction" page

The user fills out a form to create a new transaction with:

name (mandatory)
amount (mandatory)
categories (mandatory at least one)

The user click (or taps) the "Save" button to create the new transaction, and is taken to the transactions page for that category.
When the user clicks on the "Back" button (<), the user navigates to the transactions page for that category.

Hi @FrederickMih
Thank you for the review, however, I don't understand why you said it doesn't follow Gitflow.
Can you provide some clarifications here?

Hi @FrederickMih Thank you for the review, however, I don't understand why you said it doesn't follow Gitflow. Can you provide some clarifications here?

Hi @fezzopro, base on your flow, when your app will be approved, you'll merge from dev to main which is not correct. This is a solo project hence you should open a PR from feature to main branch

@FrederickMih
Thank you for the clarifications, I have created a new PR to correct my Gitflow.
The new PR is https://github.com/fezzopro/Budget-app/pull/14


FreeBSD 'platform_version_to_s'

The file helpers.rb has a typo on line 305.  The content platform_version_to_s should be platform_version.to_s.
    ================================================================================
    Error executing action `create` on resource 'mysql_service[default]'
    ================================================================================

    NameError
    ---------
    No resource, method, or local variable named `platform_version_to_s' for `Chef::Provider::MysqlService ""'

Oh... I see that FreeBSD support was dropped.  Back to 5.6.1.


suggestion: source berry crate ars nouveau

The source berries from ars nouveau have no way to be compacted so you end up with massive amounts of them quickly. If you could add a crate from them that would be amazing
forge 1.18.2

Ars Nouveau already adds a Sourceberry Sack. Also, I am not actively supporting 1.18.2.

no it doesnt? or at least on 1.18.2


[Feature request]: Flexible Screen Blocking Hours

Version

[X] I'm using version 1.14.0

Existing requests

[X] I've checked Existing requests

Advanced Preferences

[X] I've checked Advanced Preferences

What operating system are you using?
Other (specify below)
Operating System Version
Windows 11 and Linux
Problem description
Currently, the app blocks the screen at regular intervals that the user sets, but it does it all the time regardless of the time of day. I often work at odd hours or on weekends and I don't want to be interrupted during my off-hours.
Possible solution
So, my suggestion is to add a feature that allows users to set specific hours during which the screen-blocking feature is active. For instance, I would love to set the app to only block the screen between 9:00 am and 5:00 pm on weekdays, but not outside of those hours.
Alternative solutions
The alternative would be to simply close and turn on the app, but I would like to avoid having to remember to turn it on every time.
Additional information
I think this would be a great feature because it would give users more flexibility to tailor the app to their work schedule. Thanks for considering this feature, and keep up the great work!
Code of Conduct

[X] I agree to follow this project's Code of Conduct

Thanks for the feedback, please follow the updates here: #342


add list logos to result page

logo-buttons for the detail summary are implemented ... but the css does not do what it should do xD

for clean implementation logos with same size are required -> moved to backlog

Would be a nice addition for the "Übersicht" page instead of details view.
<img class='img-responsive' src='img/lists/$list_logo' title='$list_name_short Logo'>
Todo: Make the vars available in elements.php

resolved with revision bdd9519


MTU no longer returned from service

The MTU used to be read from the TUN properly but no longer seems to be. Investigate

fixed with https://github.com/openziti/desktop-edge-win/pull/89


Write a System Verilog code to implement a 10 bit carry look ahead adder

Write a code in final_adder.sv to implement a 10 bit CLA which is to be used for a 5x5 Multiplier.
Implementing adder+Working Test bench = 50 points

can you please assign

!assign @Ruchavw  45m

can u pls assign

!assign @Sami9692 60

!assign @Sami9692 15

I have PR ed alreadyy

checking now

@Sami9692 can you come to class 004?

sure..

can I get assigned?

can i get assigned

@aakanksha-p-3 please try #1 or #2, this has already been solved

#1 or #3*


Classes for default width page?

Hello
I have used classes: wide in my default front matter in config file
Can I change this behavior for custom posts? By default all should be wide unless I mention. How do I mention not to widen this post?

classes: false

classes: false

Thank you!


Chrome68.0.3440.106 native upload component is out of order

Chrome68.0.3440.106 native upload component is out of order.
After I select a pic from the upload input button , the web page crashed.

Unrelated to this project.


Restart tomcat8 failed

This PR add a /handler/main.yml which is missing to execute notify: restart tomcat8 from /tasks/config.yml

@DigitLib I believe I fixed this issue in #5, can you check?

@jonathangreen tested #5 on CentOS and work!

@DigitLib if #5 resolves this issue and the one in #3. Can we close those PRs?

@whikloj Yes.

👍  thanks @DigitLib I'll close this and #3 and test #5 for merging.


HashMap/HashSet optimization: fast modulo

This utilizes a technique researched by Daniel Lemire et al. (https://arxiv.org/abs/1902.01961) to calculate x mod d (where d is a constant) a lot faster than the regular expensive modulo operation %. Since the possible sizes of the hashtable are stored as constants in a lookup table we can precompute the required inverse elements and store them in a lookup table as well.
I came across this technique when I read about some optimizations of Boost's unordered_map for the upcoming 1.80 release.
The performance improvements are quite significant with up to 40% (int - insertion), especially when the hash function isn't the bottleneck.
Benchmark with 200.000 elements (average of 200 runs)
Linux-Notebook: (Intel i5-8250U) built with GCC 12.1:

int
insert
find
erase

HashMap
37.789645ms
6.06988ms
17.559695ms

HashMap (fastmod)
27.10462ms
4.26861ms
12.853815ms

Vector2i
insert
find
erase

HashMap
40.99277ms
7.48687ms
18.31907ms

HashMap (fastmod)
31.01118ms
5.6226ms
15.61076ms

Desktop PC (AMD Ryzen7 3700X) built with MinGW 10.0(GCC 12.1):

int key
insert
find
erase

HashMap
26ms
5.2735ms
15.616ms

HashMap (fastmod)
19.3191ms
4.4281ms
14.8263ms

Vector2i key
insert
find
erase

HashMap
26.224ms
7.1828ms
17.4173ms

HashMap (fastmod)
20.1043ms
6.5907ms
16.7279ms

The results on the same machine with MSVC 14.3 are slightly worse, but still faster than before:

int key
insert
find
erase

HashMap
26.2993ms
6.8913ms
15.9505ms

HashMap (fastmod)
20.5731ms
6.9024ms
15.7328ms

Vector2i key
insert
find
erase

HashMap
27.059ms
10.605ms
18.1936ms

HashMap (fastmod)
20.4513ms
9.6771ms
16.7354ms

Detailed changes:

Use fastmod for HashMap and HashSet (could also be applied to #61083)

Fallback to regular modulo if the required type/intrinsic isn't supported

Additional testing is always welcome :)

Thanks!


API endpoint filter

hi,
How would you pass parameters (from the filament filters) to the API endpoint URL/body?
thanks for your implementation btw :)

hi,
How would you pass parameters (from the filament filters) to the API endpoint URL/body?
thanks for your implementation btw :)

Hi! I haven't tried it before. I'll check it and I let you know 👍

Maybe i figured it out,

Thanks,

@dametts, how did you make it working? I implemented like the 2 previous screenshots but I get :
https://flareapp.io/share/V7j2kLk7
Many thanks for your help


Status of the plugin development?

First of all, thank you for the work you are doing in order to get a Capacitor's version of Sentry. While Cordova's version works for majority of Sentry features, there are few things the plugin just can't do.
I would like to ask you what is the current status on the repo. There hasn't been any development since February. The plugin is stuck in Android Alpha.
Can you please explain if there is some problem or what is stopping you from further development?
Thank you one more time, I understand that sometimes you must prioritise other work but I am certain there are many developers eagerly waiting for this plugin to became reality.

Looking forward to this plugin.
If it needs some help, I can send some PRs.

First of all, thank you for the work you are doing in order to get a Capacitor's version of Sentry. While Cordova's version works for majority of Sentry features, there are few things the plugin just can't do.

What features from Cordova are you missing? We've recently release version 1.0.0 with a lot of new features such as release health, native crash support, performance monitoring, etc.

I would like to ask you what is the current status on the repo. There hasn't been any development since February. The plugin is stuck in Android Alpha.

We're going to focus on it in Q2, so expect big changes and releases coming in the near future.

Can you please explain if there is some problem or what is stopping you from further development?

Mainly resourcing. Sentry has a lot of SDKs and things change quickly. The Cordova SDK didn't get fixes and updates for a long time so we wanted to take care of it before we could really focus on adding something new.

Thank you one more time, I understand that sometimes you must prioritise other work but I am certain there are many developers eagerly waiting for this plugin to became reality.

Thank you! We appreciate that and if you can, please help us test our alphas and beta releases (they'll come in the next weeks). Also give us feedback on Discord  if things work or not for you to help us drive development here. Your feedback really helps us.

Thank you very much for such a detailed answer!
The big problem with Cordova's plugin is the fact it can't understand source maps well. Capacitor uses different URL and Sentry can't connect an error to uploaded source maps. There are few ways how to get it work but I have been unsuccessful so far. So my hope is this new plugin will handle source maps better.
Thanks again for the work and looking forward to testing it in the future!

Thanks for bringing that to our attention. We'll make sure to take a look. I'll keep this open and pinned for now.

Then it that case I am sending this video from Ionic Sentry webinar where a hack is shown as to how recognize sourcemaps. (Didn't work for me fo some reason though).
Could be helpful for this project.


[ci] no-response bot is broken

Description
See, for example, #6311.
The original poster responded, but the awaiting response label wasn't automatically removed.
Failing build: https://github.com/microsoft/LightGBM/actions/runs/7901178460/job/21564224042
RequestError [HttpError]: Resource not accessible by integration
    at /home/runner/work/_actions/lee-dohm/no-response/v0.5.0/dist/index.js:3430:23
    at processTicksAndRejections (node:internal/process/task_queues:96:5) {
  status: 403,

full log (click me)
RequestError [HttpError]: Resource not accessible by integration
    at /home/runner/work/_actions/lee-dohm/no-response/v0.5.0/dist/index.js:3430:23
    at processTicksAndRejections (node:internal/process/task_queues:96:5) {
  status: 403,
  headers: {
    'access-control-allow-origin': '*',
    'access-control-expose-headers': 'ETag, Link, Location, Retry-After, X-GitHub-OTP, X-RateLimit-Limit, X-RateLimit-Remaining, X-RateLimit-Used, X-RateLimit-Resource, X-RateLimit-Reset, X-OAuth-Scopes, X-Accepted-OAuth-Scopes, X-Poll-Interval, X-GitHub-Media-Type, X-GitHub-SSO, X-GitHub-Request-Id, Deprecation, Sunset',
    connection: 'close',
    'content-encoding': 'gzip',
    'content-security-policy': "default-src 'none'",
    'content-type': 'application/json; charset=utf-8',
    date: 'Wed, 14 Feb 2024 12:28:16 GMT',
    'referrer-policy': 'origin-when-cross-origin, strict-origin-when-cross-origin',
    server: 'GitHub.com',
    'strict-transport-security': 'max-age=3[15](https://github.com/microsoft/LightGBM/actions/runs/7901178460/job/21564224042#step:2:16)36000; includeSubdomains; preload',
    'transfer-encoding': 'chunked',
    vary: 'Accept-Encoding, Accept, X-Requested-With',
    'x-accepted-github-permissions': 'issues=write; pull_requests=write',
    'x-content-type-options': 'nosniff',
    'x-frame-options': 'deny',
    'x-github-api-version-selected': '2022-11-28',
    'x-github-media-type': 'github.v3; format=json',
    'x-github-request-id': 'E483:41E6:2E9329C:5D717B8:65CCB1E0',
    'x-ratelimit-limit': '15000',
    'x-ratelimit-remaining': '14997',
    'x-ratelimit-reset': '1707917296',
    'x-ratelimit-resource': 'core',
    'x-ratelimit-used': '3',
    'x-xss-protection': '0'
  },
  request: {
    method: 'DELETE',
    url: 'https://api.github.com/repos/microsoft/LightGBM/issues/6311/labels/awaiting%20response',
    headers: {
      accept: 'application/vnd.github.v3+json',
      'user-agent': 'octokit-core.js/3.2.4 Node.js/[16](https://github.com/microsoft/LightGBM/actions/runs/7901178460/job/21564224042#step:2:17).[20](https://github.com/microsoft/LightGBM/actions/runs/7901178460/job/21564224042#step:2:21).2 (linux; x64)',
      authorization: 'token [REDACTED]',
      'content-length': 0
    },
    request: {
      agent: Agent {
        _events: [Object: null prototype] {
          free: [Function (anonymous)],
          newListener: [Function: maybeEnableKeylog]
        },
        _eventsCount: 2,
        _maxListeners: undefined,
        defaultPort: 443,
        protocol: 'https:',
        options: [Object: null prototype] { path: null },
        requests: [Object: null prototype] {},
        sockets: [Object: null prototype] {},
        freeSockets: [Object: null prototype] {},
        keepAliveMsecs: 1000,
        keepAlive: false,
        maxSockets: Infinity,
        maxFreeSockets: [25](https://github.com/microsoft/LightGBM/actions/runs/7901178460/job/21564224042#step:2:26)6,
        scheduling: 'lifo',
        maxTotalSockets: Infinity,
        totalSocketCount: 0,
        maxCachedSessions: 100,
        _sessionCache: {
          map: {
            'api.github.com:4[43](https://github.com/microsoft/LightGBM/actions/runs/7901178460/job/21564224042#step:2:44):::::::::::::::::::::': [Buffer [Uint8Array]]
          },
          list: [ 'api.github.com:[44](https://github.com/microsoft/LightGBM/actions/runs/7901178460/job/21564224042#step:2:45)3:::::::::::::::::::::' ]
        },
        [Symbol(kCapture)]: false
      },
      hook: [Function: bound bound register]
    }
  },
  documentation_url: 'https://docs.github.com/rest/issues/labels#remove-a-label-from-an-issue'
}

Reproducible example
Any recent No Response Bot runs trying to modify things in this repo: https://github.com/microsoft/LightGBM/actions/workflows/no-response.yml.
Additional Comments
It's been 3 years since that project last received a commit: https://github.com/lee-dohm/no-response
I believe it might just no longer work with GitHub's API.
Noticed that over in shap, they are using https://github.com/actions/stale: https://github.com/shap/shap/pull/3424.
That's a GitHub-official action, so we should probably move to that.

FWIW the closing of issues seems to be working still (comment, logs).

Oh interesting!
Since those are both from mlforecast.... maybe it's not that the app is broken? Maybe this is a permissions issue.
We don't have a dedicated token for that bot:
https://github.com/microsoft/LightGBM/blob/6330d6269c81dfd4c96e664b99239b8ff39ccf91/.github/workflows/no-response.yml#L23
The docs at https://github.com/lee-dohm/no-response?tab=readme-ov-file#inputs say

The default GitHub Actions token is sufficient.

And I see mlforecast is just using the default one: https://github.com/Nixtla/mlforecast/blob/main/.github/workflows/no-response.yaml#L21.
I strongly suspect that someone at Microsoft changed the default permissions for the default tokens... either for this repo specifically or organization-wide. From https://github.blog/changelog/2021-04-20-github-actions-control-permissions-for-github_token/#setting-the-default-permissions-for-the-organization-or-repository

A new admin setting lets you set the default permissions for the token in your organization or repository.
You can choose between two options:

Read/write for all scopes (current default)
Read repo contents

Setting the default to contents:read is sufficient for any workflows that simply need to clone and build. If you need additional permissions you will need to specify those in your workflow yaml.

I can try adding extra permissions to that workflow, as that blogpost suggests.

Just saw it remove the label as well in this issue (logs)

I strongly suspect that someone at Microsoft changed the default permissions for the default tokens

I agree. The error here is a 403 and this stackoverflow answer suggests that as well

I just merged #6323, then triggered this run of the no-response bot: https://github.com/microsoft/LightGBM/actions/runs/7964739283
It didn't like being run with workflow_dispatch 😭

Unrecognized event: workflow_dispatch

https://github.com/lee-dohm/no-response/blob/66174372c9c5576aa8a4287e33653f2fdd12d517/src/main.ts#L17-L19
Guess we'll have to wait until the next scheduled run about 8 hours from now.

It looks like the changes from #6323 partially worked.
I just saw the bot closed some issues and post comments:

https://github.com/microsoft/LightGBM/issues/6200#issuecomment-1953453914
https://github.com/microsoft/LightGBM/issues/6275#issuecomment-1953453913
https://github.com/microsoft/LightGBM/issues/6262#issuecomment-1953453912

But it failed to remove labels 🤔
I don't see any errors in the logs: https://github.com/microsoft/LightGBM/actions/runs/7968288344/job/21752319533
Or any meaningful difference between LightGBM's configuration
https://github.com/microsoft/LightGBM/blob/45a60a729986fb85eb2be2c6900f2da22e526034/.github/workflows/no-response.yml#L14-L27
And mlforecast's
https://github.com/Nixtla/mlforecast/blob/02a2a85496416f2d86ebc7694535929da39b3e2f/.github/workflows/no-response.yaml#L9-L21
Maybe it's a permissions issue, but I don't understand what. These examples suggest that issues: write (which we're already giving this workflow) should be sufficient to modify issue and pull request labels:

https://docs.github.com/en/actions/managing-issues-and-pull-requests/adding-labels-to-issues
https://docs.github.com/en/actions/managing-issues-and-pull-requests/removing-a-label-when-a-card-is-added-to-a-project-board-column

Maybe that's actually not ever worked in LightGBM?
I see 85 closed issues that still have the awaiting response label on them: https://github.com/microsoft/LightGBM/issues?q=is%3Aissue+label%3A"awaiting+response"+is%3Aclosed
And examples like #6029 where it seems that it's actually been lock-bot, not no-response bot, that removes that label:

@jmoralez do you see any differences between LightGBM's and mlforecast's configuration that might explain why no-response isn't dropping the awaiting response label?

ohhhh wait I see it! I think that example from https://github.com/Nixtla/mlforecast/issues/312 shows the bot closing it because the original author commented.
From https://github.com/lee-dohm/no-response?tab=readme-ov-file#issue_comment-event

issue_comment Event
When an issue_comment event is received, if all of the following are true:
- The author of the comment is the original author of the issue
- The issue has a label named the same as the responseRequiredLabel value in the configuration
It will:
- Remove the responseRequiredLabel
- Reopen the issue if it was closed by someone other than the original author of the issue

So I think this is all working as it's expected to. lock-bot should end up removing that awaiting response label when it eventually locks the issues.
I'm gonna close this. Thanks so much for the help!


[plugins] ☂ Swift migration for 1P plugins

Motivation
Here is just a few benefits of doing so:

Null safety baked into the language
Many new features in Swift like tuples and structs
More and more system APIs only support Swift
More and more iOS developers/contributors only know Swift (or prefer Swift)

For more details, please refer to Swift migration design doc
Instruction

IMPORTANT: Read the Swift migration section of the wiki

Pick a plugin that you are interested in:

[x] quick_actions
[ ] ios_platform_images
[ ] url_launcher
[ ] google_sign_in
[ ] local_auth
[ ] video_player
[ ] in_app_purchase
[ ] image_picker
[ ] google_maps_flutter
[ ] camera
[ ] webview_flutter

Note:

The above list is ordered by plugin size.
path_provider and shared_preferences is already done by reusing existing macOS implementation

@hellohuanlin Will this migration be carried out/initiated by the Flutter team, or can contributors start this migration and submit PRs?

@Mairramer Yes! PRs are welcome :)


Gestalt  should warn when using a special prop with the wrong/missing display/position/etc

Originally from @ryan953:
Some examples:
A  with the left prop, ie:  ..., should have the corresponding position="absolute" set. Without the correct position, right={true} is invalid.
A  with the alignItems prop, ie: ... should have the corresponding display="flex" set. Without the correct display, the alignItems flag could interact unexpectedly with other parent elements, or would not change the render.
It is safe to ignore props like left when position is not set, and know that the render will not be affected with the addition of an extra prop which we do today. This however breaks encapsulation. With this example the final layout of the component will be different depending on the container. This is not desirable, the container should bring it's own layout and place the component within it.
This task is about adding feedback to users of . Users, in development mode, should get big red boxes whenever required fields are missing. In production we should continue to render as we do today. Also in production we should emit logs so we can identify instances where a property like right was added, but position was not. This may be an extra prop, or it may be a visual bug.

@chrislloyd is this something we should warn or handle with flow?  this seems similar to the discussion we had before with Sticky where we decided against displaying a warning message

Yep! I remember trying to do this originally but flow's support for disjoint unions was pretty off. I think we could try again and it would be a good UX win.

Closing out. Feel free to re-open if still relevant.


feat(tokio): Implement literal support for ImapClientCodec.

The examples are not complete without support for literals on the sending side, i.e., when using framed.send() as a client.

We'll redesign the tokio part.


KCP Example server WithBlockCrypt unresolved reference

Exact code as shown in the KCP example -
s := server.NewServer(server.WithBlockCrypt(bc))
This line cannot be compiled as the .WithBlockCrypt is an unresolved reference (kcp is visble)

Did you use latest rpcx? Did you add kcp inbuildtags?
WithBlockCrypt   exists in  https://github.com/smallnest/rpcx/blob/master/server/kcp.go

Thanks - that fixed it..

Runs.. however - it now shows INFO "network is not tcp/tcp4/tcp6 so can not start gateway" - looking at the code, using value for s.Serve of kcp will always show this message so maybe does not matter.
The client successfully connects to the server and gets the response - but with packet inspection I see lots of 'unknown destination' packet errors, which keep coming in even after the client exits. Any thoughts?

You can ignore the INFO log . It only works for tcp transport.
For the second case, I think it should be the kcp-go issue.


[feat] sfpegActionBarCmp - Support Apex Form action

Is your feature request related to a problem? Please describe.
Support ability to call an apex method from a form action in addition to LDS/DML.
Describe the solution you'd like
The idea is to have the same feature as dmlForm but call a custom Apex method (implementing
a virtual class) instead of doing a DML.
This would enable to include callouts to external systems before executing a DML.
Describe alternatives you've considered
N/A
Additional context
Some legacy PEG components (callout form) was providing such a capability.
May be mutualised with Issue #17

Feature added and documented. Example (configuration & apex class) to follow


Add support to deploy verticles

Verticles are common in vertx applications, it is good to have a way to deploy them in this extension as well.
One possible approach can be introducing a vertx-deployment.json file within the jar or war deployment, so that the specified Vertx instance will be used to deploy the verticles. Annotations can be added later.

done in https://github.com/gaol/wildfly-vertx-extension/commit/075366e96e4d4e5069314c20fd4a6e5530abbb30


Warn for unused params and vars

It would be very nice to get told when I have params or vars that are unused. Could fit in the linter.
See:  https://github.com/Azure/bicep/issues/446#issuecomment-725032818

We should have a code fix that removes them easily. The code fix could also deal with simplifying loops with unused index variables.

Warnings from the Bicep extension in VS Code would be nice to have, similarly to what the ARM tools extensions offers.
If they are removed in transpiling it could be useful with a warning when running bicep build as well.

Yeah, automatic removal of unused variables would fit under the umbrella of optimizations, but definitely makes sense!

When refactoring complicated templates, I'm definitely missing the dimming of unused variables and parameters that we have in ARM tools.

This will be included in the MVP of the linter https://github.com/Azure/bicep/issues/428

Fixed by https://github.com/Azure/bicep/pull/2341


Split out each repo into its own page

Maybe make this a config thing so you can have all on one page or all on separate pages?

@mattstauffer can this be closed now?

yessir!


Make Next.js app template optional

Not all projects need the pre-build Next.js app.
One idea is to exclude the web app from fresh start and have a fresh generate next|vue|etc command.

On second thought, I think it may be more powerful to generate a web template by default, but add an option to disable it.
Something like: fresh start my-project --no-web

Deprioritizing this for now.


Automatically publish nightly versions?

Just encountered another issue (re-announce after subscription canceled by peer) and found already fixed in the code base but not yet released.
Maybe publish nightly versions automatically, consider the code base is now somewhat unstable?

We are already on that, as soon as I get some Github settings done by people with the matching rights we will have that ... see https://github.com/orgs/project-chip/projects/11?pane=issue&itemId=36578941 (will close because more a todo then an issue). Also 0.6 will come soon once the big MDNS PR is merged (ideally also automated) :-)

PS: "Somewhat unstable" is not really correct ;-) Honestly ... that reannounce is a "reality driven change" we added that are not covered by any specs or such, so in fact it should be the controllers to try from themself when such ancase happened and not rely on a re-announce ... but yes with this "feature" it works better. With the MDNS branch there willbe more improvements

docs will be added in https://github.com/project-chip/matter.js/pull/368/files#diff-b335630551682c19a781afebcf4d07bf978fb1f8ac04c6bf87428ed5106870f5

@Apollon77 Haha thanks. By "unstable" I mean actively evolving.
I just started learning Matter (by getting hands on Matter.js), so pardon me as I am certainly not clear about many details. 😃


Feature request: Right click -> Copy object

Hi, and thanks for a fantastic development tool.
While working with objects in console, I find it very useful to right click the object, and then "Store as global variable". The object typically becomes available as temp1. Pretty much as you do when sending the vue model you´re inspecting to console as $vm.
Some even more useful thing, is that running copy(temp1) allow me to copy the object. Copying an object and then pasting it somewhere is often so much faster than using the expand arrows etc., and typically makes me save quite a bit of time when working with data structures.
What would be totally awesome in vue devtools, is if it was possible to simply right click on a object and then copy it directly to the clipboard. Thanks in advance for considering to make this a feature.

I was browsing the feature requests in order in order to post this exact same one, if it wasn't already there.
So here it is. It would be awesome, indeed.


Multiple waybars appear after reloading the configuration

Issue Description:
Without an external monitor, use the command kill - sigusr2 waybar  to reload the configuration of waybar. Then plug in the external display and you will find that there are multiple waybars on the external display.
The screenshot is as follows:

Issue Recurrence:

No external display
Run command with killall -SIGUSR2 waybar
Plug in external diplay
Now, can find multiple 'waybar' in external monitor.

Environment:

OS System: Manjaro Linux x86_64
Host: Lenovo XiaoXinPro 16ACH 2021
WM: wayfire-lily-git <IP_ADDRESS>20807.101801.gb0a0cdb0-1
Other: wlroot:wlroots-lily-git <IP_ADDRESS>20807.100430-1

By the way, I don't think this is a wlroot problem.

Any update on this? The issue is still present in version 0.10.3

I have a similar issue with sway, but I'm not reloading the configuration. For me, it reproduces by:

External display plugged in, one waybar on laptop and external display.
Removing the external display; one waybar on laptop.
Plugging in the external display again; one waybar on laptop and ~5 on external display. Restarting sway or reloading the configuration of waybar removes the duplicates.


Remove composer.lock

At the moment the phpmd/phpmd package is stuck on the 2.10.1 version due to the composer lock being committed to the repository. Would it be possible to remove it or at least update it?
From my understanding the packages which are being distributed shouldn't have lock file committed and versions should be forced by composer.json

I can remove it if you want but why you close the request? Do you still need the change?

I closed the issue because I manage to go around this problem by adding the phpmd/phpmd to my own composer.json and then running an update on phpmd/phpmd and mi-schi/phpmd-extension in a single cmd.
composer update 'phpmd/phpmd:2.12' mi-schi/phpmd-extension

Okay, if you have any request feel free to write here :)


Backend source

There's some backend code on source? Like Cloud Functions or GAE

I don't think the reservation backend code is going to be released, as it's out of the scope of this project as an Android sample. There's also an endpoint to query if the user is an attendee. Both were Cloud Functions.
The rest is just Firestore, no logic there.


remove photon-capacitor-graviton from DSP recipes, closes #426

I can only fix the first problem in this issue #426. For the second problem, if I split the ice-giant recipe into 2, the solver gives me twice as many orbital collectors.

My apologize.
Please close this thread and ignore my silly modification, because this is caused by my misunderstanding of the photon-capacitor-graviton recipe. What you mean is that using gravity lens can increase the efficiency of the ray receiver, but I took it as produce critical photon with gravity lens.
I am so sorry for wasting you time.

My apologize.
Please close this thread and ignore my silly modification, because this is caused by my misunderstanding of the photon-capacitor-graviton recipe. What you mean is that using gravity lens can increase the efficiency of the ray receiver, but I took it as produce critical photon with gravity lens.
I am so sorry for wasting you time.

Aha! @JiangengDong thank you for following up. I wondered why they would remove it and had just confirmed that the recipe was in fact still in the game.
No need to apologize! Thanks for taking the time to try to improve the calculator, even if it was just a misunderstanding!


Fixed grammar

Changed "you" to "your"

Codecov Report

Merging #2938 into dev will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##              dev    #2938   +/-   ##
=======================================
  Coverage   99.91%   99.91%
=======================================
  Files          23       23
  Lines        1237     1237
=======================================
  Hits         1236     1236
  Misses          1        1

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 85b5846...7f6ed29. Read the comment docs.


Possible variable $l10n found in translation function

Hi
Issue description:
I have included kirki in my theme. Everything is almost done. I have checked the theme using theme checker. It's giving some recommended errors. here is how it looks like
Possible variable $l10n found in translation function
Line 446: <button type='button' class='button upload-button' data-label='<?php esc_attr_e( $l10n['add-file'] ); ?>' data-alt-label='<?php esc_attr_e( $l10n['change-file'],'upplanet' ); ?>' >
Actually, I can solve the problem by not using variable $l10n, but I want to know, will it not break my any of the code?. If I do that, will everything work fine?
thank's :)

Hey there!
That was a bug, I believe this has already been fixed in the develop branch here on github.
It should be esc_attr instead of esc_attr_e

Hey bro,
Thanks, The dev version is working perfectly, :)

Hello there. I use L10n.php for custom domain - Kirki for my theme, but i don't know how to load in theme. Can anyone help me?


Fix issue with domain Offensive check

isOffensive function didnt had a return statement.
Added trim and lowercase to make sure all yes are detected

LMAO I did too much Rust, thanks for catching it holy crap

I was getting triggered by two failed domain checks XD


DEVENV_ROOT is incorrect if project moves

Describe the bug
When a project moves, its .direnv cache still exists and has cached the old DEVENV_ROOT value. This breaks scripts that refer to DEVENV_ROOT (for instance Poetry activation in the Python language module).
To reproduce
Create a devenv project, activate direnv with direnv allow and cd into it. Then rename the project directory to something else, leave the directory and return to it. Run direnv allow and then echo $DEVENV_ROOT.
Version
devenv 1.1.0 (aarch64-darwin)

Maybe we can fix this by adding a file under .devenv whose contents are the last value of DEVENV_ROOT, and add it to our direnv watched files? I'd be happy to implement that if that solution is agreeable.


Compare LayoutKit with other layouting methods

Hi,
http://layoutkit.org/benchmarks is really really nice, and display clearly that LayoutKit is fast. I was just wondering what was the complexity of the UICollectionView's cell in the benchmark? How many views? Can you share a screenshot of the cell's content?
We would like to create a standard benchmark to compare all iOS layout frameworks, and your test is clearly really interesting.
Thanks to participates in the iOS open source community!
Regards

OK, I just found your benchmark in your app. Sorry

No worries.
We are using https://github.com/diwu/DWURecyclingAlert to benchmark the performance. Also, we have a stopwatch (Stopwatch.swift) that can record elapsed time and benchmark closures.


P0602R4 variant and optional should propagate copy/move triviality

https://www.open-std.org/jtc1/sc22/wg21/docs/papers/2018/p0602r4.html

完了


merge from konsum-frontend-svelte,template-svelte-app

package.json

chore(deps): add ^2.56.0 remove ^2.55.1 (devDependencies.rollup)

:tada: This PR is included in version 1.29.17 :tada:
The release is available on:

v1.29.17
npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


[cephfs-provisioner] PVC creation shouldn't fail if the ceph user secret already exists

[cephfs-provisioner] When using deterministicNames: true creating a PVC, deleting it and creating it afterwards may fail because the ceph user secret already exists.
This could be solved by just doing:
apierrors "k8s.io/apimachinery/pkg/api/errors"
[...]
if err != nil && !apierrors.IsAlreadyExists(err) {
                klog.Errorf("Cephfs Provisioner: create volume failed, err: %v", err)
                return nil, fmt.Errorf("failed to create secret")
 }

I'm glad to do a PR with this, I'm just having a hard time building the provisioner due to this:
https://github.com/kubernetes-incubator/external-storage/issues/1150
If you help me sort this out I could test it in my own clusters.

@humblec Did you finally take a look at this?

@fcgravalos you can try this PR https://github.com/kubernetes-incubator/external-storage/pull/1122 to resolve #1150 and then send a PR with the fix for this issue.

Thanks @humblec I'll try that out later and submit a PR if I manage to fix it

hey @humblec I merged your PR in my fork and I was able to test my changes :). It works! I'm moving forward with a PR :)

@humblec you were assigned to the PR :)
If we merge it, we'll merge your changes to fix the build too :)


Binary has CRLF endings,  doesn't work on unix platforms atm

This may not be an issue, seems to be working on macOS after a quick test just now.


pasting to a canvas doesn't trigger the plugin

Setup the plugin with default settings
Create a new canvas
Paste an image from the web

Expected result: image renamed to match the canvas
Actual result: plugin does not trigger

Will work on this issue in the next release. Two things worth noting:

when pasting an image in the Canvas, Error: No active file found. is prompted fromstartRenameProcess
when creating a Canvas, renaming modal is opened if "handleAllAttachments" is enabled

I have the same problem. Any news on this feature?


Support goto symbol for markdown files

VSCode Version: 1.0.0
OS Version: os x 10.11.4

Steps to Reproduce:
1.open a markdown file like this:
#aaa

###ddd

2.press "shift+cmd+o" to open Goto Symbol feature "@"
always says: "we have no symbol information for this file."

Is this also not working for Python??

I really need this feature!

I believe this was fixed by #16979
Please give it a try in the next insiders build.
Thanks


unmount scrollSpy when unmounting

Seems unmount() on the scrollSpy was never called? It gave errors in Safari when scrolling.

yes, you are correct, merged!

will publish later tonight


Fix paths to the views, fields and templates options

Discovered some issues with how the paths to the various resources are managed, and how they differ between test and service.
Still investigating

Will open a pr shortly with a fix.


Using commitizen-action with an older version of commitizen (v2.23.0) results in a failure

When I use the commitizen-action, it fails with a cz: error: invalid choice: '21' (choose from 'init', 'commit', 'c', 'ls', 'example', 'info', 'schema', 'bump', 'changelog', 'ch', 'check', 'version') for commitizen v2.23.0.
Github actions config
      - name: Create bump and changelog
        id: cz
        uses: commitizen-tools/commitizen-action@master
        with:
          github_token: ${{ secrets.G_ACCESS_TOKEN }}
          branch: ${{ github.ref }}
          commitizen_version: v2.23.0
      - name: Print Version
        run: echo "Bumped to version ${{ steps.cz.outputs.version }}"

I also use a git pre-commit hook that looks like this
  - repo: https://github.com/commitizen-tools/commitizen
    rev: v2.23.0
    hooks:
      - id: commitizen
        stages: [commit-msg]

The pre-commit check works as expected but when the code runs in GA, it fails with the above error. I've also attached a screenshot

To solve the issue use v2.24.0, sorry for the inconvenience

Thanks a lot for the help, this seems to have worked just fine


Handle rejected promises

I must be missing something here.
If I return a rejected promise from the loader of a component, nothing seems to work as expected.
On the server side, loadOnServer itself is not rejected but rather it continues to resolve the promise and so the component tree gets rendered without the required data. I then get other exceptions due to the missing data which does reject the entire promise. (as expected).
loadOnServer({ ...renderProps, store }).then(() => {
  // Even when the loader promise is rejected this code runs..
})
.catch(err => {
 // this would run eventually when something breaks in a component due to the missing data..
})

On the client side, I am not even sure what to expect - clearly there is no extension point where I can change the routing and redirect to an error page. How should that be handled on the client?
<ReactReduxProvider store={store}>
  <Router  {...renderProps}
    render={(props) => <ReduxAsyncConnect {...props}
                        render={applyRouterMiddleware(useScroll(cusotmScrollBehaviour))}
                   />}
    routes={getRoutes(context)}/>
</ReactReduxProvider>

Any insights on this would be great (I was digging in the sources for a while, but I don't think there is any special handling for this situation)
Thanks!!

I think you can populate your state with something like error: true or loaded: false. Then check the state in the component and redirect before it mounts. I've been struggling with the exact same problem for the last 3 days. This also has been discussed in Issue #16 .

@vpanjganj I was trying to avoid the approach you suggested. I think rendering of the component should not be aware of a data load failure. Duplication of the error handling code at every container component hints at that.
loadOnServer can easily give back an indication of any rejected promises (requires a code change of course). It's the client side rendering which poses a challenge since react router's approach is not inherently callback based and so one would have to re-implement the data loading code in the onEnter callbacks.. that means abandoning redux-connect and re-implementing it. I think I might do just that :/

@yoadsn ,I think if a component (UI) has to visually respond to a data load failure, it is enough reason to include that in the state and implement the behaviour in the component. To address your concern about redundant code to handle data errors; you can use Higher-ordered components to reuse the logic anywhere necessary.

Thats correct ;)

If someone is looking for a catch behaviour, you can pull out the error from state and throw if it exists.... something like the following should work.  This tosses the first error encountered, but could easily be reworked into aggregating all the errors into an array.
loadOnServer({ ...renderProps, store }).then(() => {
  const {loadState} = store.getState().reduxAsyncConnect
  const err = Object.keys(loadState).reduce((memo, key) => memo || loadState[key].error, null)
  if (err) { throw error }
  // whatever else
})
.catch(err => {
  // a wild error handler appeared!
  next(err)
})

I'd much prefer if it automagically went into the catch block myself, but can appreciate the reasoning / breaking changes / potential for multiple errors, etc. for not doing it like that.


Urgent: Copyright infringement

Hi Luke,
this is Cedric from TorAlarm. We just stumbled upon your source code and noticed you were using our servers for displaying football scores. We would kindly ask you to stop using our private APIs as their not intended for public use nor did we gave you any legal right of using them.
Therefore the following information needs to be removed from this repository and you must stop using the plugin while relying on our data to display the live scores:

The URLs to our servers (https://www.ta4-data.de/*)
The IDs of the leagues/competitions written in README
Reverse-engineered technical information about protocols used by us (headers, HTTP verbs, etc.)

Thank you for your cooperation.
Cheers,
Cedric

Hi Cedric,
sure I will delete this repo.
It was not my plan to annoy you. This was just some demo project while I was learning to code :) I‘m not using it anyway.
Sorry for any inconvenience.
Cheers
Luke


Fix terminal locale handling

Fixes #166936

Candidate PR version of #169068
This PR breaks language pack recommendation in order to get the terminal working again on macOS with non-ASCII characters.

Can this just be disabled for macOS to keep the candidate change minimal ?