Build fails in lib core tests

Doing a build is failing on my machine, running on stock Fedora 34 -
Checking the environment:

20210728 13:29:28 INF Environment passes all checks!

Environment looks good, you are ready to go!

Done. Made 1120 targets from 175 files in 146ms
ninja: Entering directory `out/host'
[56/518] c++ obj/src/lib/core/tests/libCoreTests.TestCHIPTLV.cpp.o
FAILED: obj/src/lib/core/tests/libCoreTests.TestCHIPTLV.cpp.o
g++ -MMD -MF obj/src/lib/core/tests/libCoreTests.TestCHIPTLV.cpp.o.d -Wconversion -O0 -g2 -fno-common -ffunction-sections -fdata-sections -fno-exceptions -fno-unwind-tables -fno-asynchronous-unwind-tables -fPIC -Wall -Werror -Wextra -Wshadow -Wunreachable-code -Wno-deprecated-declarations -Wno-unknown-warning-option -Wno-missing-field-initializers -Wno-unused-parameter -Wno-psabi -Wno-cast-function-type -fdiagnostics-color -fno-strict-aliasing -std=gnu++14 -fno-rtti -Wnon-virtual-dtor -DCHIP_HAVE_CONFIG_H=1 -I../../src/include -I../../src -Igen/include -I../../src/lib -I../../config/standalone -I../../third_party/nlassert/repo/include -I../../third_party/nlio/repo/include -I../../third_party/nlfaultinjection/repo/include -I../../third_party/nlunit-test/repo/src -c ../../src/lib/core/tests/TestCHIPTLV.cpp -o obj/src/lib/core/tests/libCoreTests.TestCHIPTLV.cpp.o
../../src/lib/core/tests/TestCHIPTLV.cpp: In function ‘void TestCHIPTLVReaderErrorHandling(nlTestSuite*)’:
../../src/lib/core/tests/TestCHIPTLV.cpp:2989:16: error: ‘buf’ may be used uninitialized [-Werror=maybe-uninitialized]
 2989 |     reader.Init(buf, sizeof(buf));
      |     ~~~~~~~~~~~^~~~~~~~~~~~~~~~~~
In file included from ../../src/lib/core/CHIPCircularTLVBuffer.h:33,
                 from ../../src/lib/core/tests/TestCHIPTLV.cpp:29:
../../src/lib/core/CHIPTLV.h:117:10: note: by argument 2 of type ‘const uint8_t*’ {aka ‘const unsigned char*’} to ‘void chip::TLV::TLVReader::Init(const uint8_t*, uint32_t)’ declared here
  117 |     void Init(const uint8_t * data, uint32_t dataLen);
      |          ^~~~
../../src/lib/core/tests/TestCHIPTLV.cpp:2986:13: note: ‘buf’ declared here
 2986 |     uint8_t buf[2048];
      |             ^~~
At global scope:
cc1plus: note: unrecognized command-line option ‘-Wno-unknown-warning-option’ may have been intended to silence earlier diagnostics
cc1plus: all warnings being treated as errors
[77/518] c++ obj/src/messaging/tests/echo/chip-echo-responder.echo_responder.cpp.o
ninja: build stopped: subcommand failed.

Fixed now as part of issue #8979 work looks like.


Unable to download/install dApps

After creating a new password & new wallet, I tried downloading/installing a mainframe dApp ("CDP Pro"). There was an error message (something like "unable to download" in red) and then when I switched back to the Applications tab, the app is shown as installed, but clicking on it opens a blank window.
I tried to install a 2nd app ("uniswap" this time) and the main window seems to be in a "forever loading" state, with mainframe logo spinner spinning. When I click away from Applications and then go back, it shows a spinner on top of the "uniswap" logo, but no spinner on "CDP Pro."
Neither dApp seems to work (but each fails in a different way).
Possibly related context: I installed version 0.2 of Mainframe OS as soon as it came out, but did not install any apps at that time. I recently installed 0.3.

Thanks @canadaduane!
We have had a few teething issues with the reliability of our swarm gateway, but our next point release should address this.

Should be working now as of v0.3.1


[Android] White blank screen when load file in a webview

[x] Review the documentation: https://facebook.github.io/react-native
[x] Search for existing issues: https://github.com/facebook/react-native/issues
[x] Use the latest React Native release: https://github.com/facebook/react-native/releases

Environment
react-native info
React Native Environment Info:
    System:
      OS: macOS 10.14
      CPU: x64 Intel(R) Core(TM) i5-7400 CPU @ 3.00GHz
      Memory: 30.62 MB / 16.00 GB
      Shell: 5.3 - /bin/zsh
    Binaries:
      Node: 8.12.0 - /usr/local/bin/node
      Yarn: 1.10.1 - /usr/local/bin/yarn
      npm: 6.4.1 - /usr/local/bin/npm
      Watchman: 4.9.0 - /usr/local/bin/watchman
    SDKs:
      iOS SDK:
        Platforms: iOS 12.0, macOS 10.14, tvOS 12.0, watchOS 5.0
      Android SDK:
        Build Tools: 26.0.3, 27.0.3, 28.0.3
        API Levels: 26, 27, 28
    IDEs:
      Android Studio: 3.2 AI-181.55<IP_ADDRESS>56338
      Xcode: 10.0/10A255 - /usr/bin/xcodebuild
    npmPackages:
      react: 16.6.0-alpha.8af6728 => 16.6.0-alpha.8af6728
      react-native: 0.57.3 => 0.57.3
    npmGlobalPackages:
      react-native-cli: 2.0.1

my package.json
{
  "name": "TemReactNative",
  "version": "0.0.1",
  "private": true,
  "scripts": {
    "start": "node node_modules/react-native/local-cli/cli.js start",
    "test": "jest"
  },
  "dependencies": {
    "react": "16.6.0-alpha.8af6728",
    "react-native": "0.57.3"
  },
  "devDependencies": {
    "babel-jest": "23.6.0",
    "jest": "23.6.0",
    "metro-react-native-babel-preset": "0.48.1",
    "react-test-renderer": "16.6.0-alpha.8af6728"
  },
  "jest": {
    "preset": "react-native"
  }
}

Description
「Android」White blank screen when load file in a webview

Reproducible Demo
you can repeat it with the code
react-native init AwesomeProject
cd AwesomeProject
react-native run-android

&& my code
import React, { Component } from 'react'
import { View, Text, TouchableOpacity, WebView } from 'react-native'

class TestWebView extends Component {
  constructor(props) {
    super(props)
    this.state = { visible: false }
  }
  onChange = () => {
    this.setState(preState => ({ visible: !preState.visible }))
  }

  render() {
    const { visible } = this.state
    return (
      <View
        style={{
          flex: 1,
          justifyContent: 'center',
          alignItems: 'center',
          backgroundColor: '#CCCCFF'
        }}
      >
        <TouchableOpacity
          style={{ backgroundColor: '#E3C07B', height: 50, width: 100 }}
          onPress={this.onChange}
        >
          <Text>Show WebView</Text>
        </TouchableOpacity>
        {visible ? (
          <View style={{ height: 150, width: 150 }}>
            <WebView
              source={{ uri: 'https://github.com/facebook/react-native' }}
              scalesPageToFit={true}
            />
          </View>
        ) : null}
      </View>
    )
  }
}

export default TestWebView

Try adding overflow: 'hidden' to your view with 150 150 please

oh，yeah,It runs successfully, thanks so much @Titozzz
<View style={{ height: 150, width: 150,overflow:'hidden' }}>
            <WebView
              source={{ uri: 'https://github.com/facebook/react-native' }}
              scalesPageToFit={true}
            />
</View>

It's related? https://github.com/facebook/react-native/issues/21789

Please use https://github.com/react-native-community/react-native-webview and file a bug there if you have issues. Thank you

thanks.. fixed for me <3

Try adding overflow: 'hidden' to your view with 150 150 please

you are best!)

thanks so much  @Titozzz

why overflow can works？


Bugfix/issue 1003

fix the issue that build environment is affected by requires (which is supposed to only affect runtime environment). For instance this issue will block you from building a python-3 oriented package using python-2 or vice versa, which seems unintentional. See more in here.
fix a typo in src/rez/resolved_context.py : package_orders -> package_orderers

Closing, please see comment at https://github.com/nerdvegas/rez/issues/1003
As an aside, tests aren't passing - PRs to be merged must have passing tests.

Closing, please see comment at https://github.com/nerdvegas/rez/issues/1003
As an aside, tests aren't passing - PRs to be merged must have passing tests.


probes: use veth device for probing managed neighbor support

Some distributions don't ship with dummy device support/module, leading to the following error when probing for managed neighbors:
level=fatal msg="failed to probe managed neighbor support"
error="failed to add dummy link: operation not supported" subsys=probes

This patch uses a veth device instead, which should be available on nodes running Cilium, if it's not already loaded.
Use veth device for probing managed neighbor support

/test

/test-1.26-net-next

/test

/test

/test

/test-1.26-net-next


Given Match ID and Player ID return statistics of Player in that match

Given a particular Match ID in the Player class, it should return the batting and bowling statistics for that player in that match.
If the player hasn't played that match, it should return a different values rather than default 0/0 - bowling and 0(0) - batting

To Decide:

How should the format of the output be like?
Any clues as to how to start this?

@salman-bhai I'd love to do this. I think we can using the match JSON (example). We should first decide on the output. I agree that if a player hasn't played in a match the output should indicate that somehow, maybe with boolean values for batted and bowled. What else should we have?

@salman-bhai I've taken a run at this with 42238c98b186fa3e18e2e7f006f5dc53c0a8d774. Check it out - the Player class now has batting_for_match and bowling_for_match methods where you supply a match ID.

I think this looks amazing as of now


Detection seems to fail when AdBlock is initially paused an then un-paused after page load

Hey guys, so I'm testing this on Chrome with the standard AdBlock extension from https://getadblock.com/. Using your test page, if I pause the ad blocker before loading the page and then un-pause it after loading has finished, clicking on the "Check Again" button tells me that AdBlock is not enabled.
Is this a known issue or is it something new? Thanks

Indeed, I managed to do the same again.
But one can not say that this is a bug or dysfunction because AdBlock really reactivates at page reload.
You can try this on other site with the pub (the true) and you will see that advertising is still displayed, so this proves that AdBlock is not yet activated.
Well, nothing serious.

Yes it seems that AdBlock is unable to detect ad elements on the DOM after it's un-paused, however, it looks like it's still able to block http requests to ad servers (such as VAST requests for video ads). In the specific case of video ads, this means that a user could circumvent an AdBlock restriction by loading the page with AdBlock paused, and then un-pausing it afterwards in order to disable mid-roll ads (or any ad-related tracking), for example. This same behavior is also present with AdBlock Plus.
Anyway, I'm not sure whether this falls within the scope of your library, but it seems like an extra http check would be necessary in order to prevent this loophole.

Ok, I see. This requires nevertheless a lot of manipulation of the user.
Anyway, I'll watch it and see what I can do. Because the main problem is the creation of http request that consumes bandwidth and client resources.
In short, I look at that and I'll let you know.
I'd probably do a "beta" branch, and we will test this together.

Here is a small example: https://jsfiddle.net/sitexw/m8puceja/
Called me if you find it correct.

Check V4 (# 34)


Create cpp17.cpp for problem 1001

Issue Number :
#8

Sure, I will make the changes and thanks for the quick feedback.

Awesome!

Merged.


texmacs: 1.99.11 -> 1.99.13

Motivation for this change
Update texmacs to latest release, now build against qt5
Things done

[x] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
Built on platform(s)

[x] NixOS
[ ] macOS (not relevant, has own derivation)
[ ] other Linux distributions

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[x] Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
[x] Tested execution of all binary files (usually in ./result/bin/)
[x] Determined the impact on package closure size (by running nix path-info -S before and after)
[x] Ensured that relevant documentation is up to date
[ ] Fits CONTRIBUTING.md.

@roconnor This is a pretty straight forward update. Can I do anything to move this along?

Rebased on latest master and bumped version update to 1.99.13.

Result of nixpkgs-review pr 84816 1

1 package built:
- texmacs

Appears to work for me. NixOS unstable, sway 1.4,
nix shell github:FlorianFranzen/nixpkgs/texmacs#texmacs -c texmacs

Opens a window with TexMacs, all the editing works. However, for some reason it shows

Welcome to GNU TeXmacs 1.99.12

Which doesn't seem to match the version in the PR's title.

@balsoft: Title does not match because upstream forgot to update the version string used by CMake before tagging the release. And the fix is only in master.
Also it should be noted that @das-g was able to resolve his issues by installing qt5.qtwayland, which is necessary to run Qt application natively under Wayland.

Result of nixpkgs-review pr 84816 1

1 package failed to build:

texmacs

Build fails for me:
/build/TeXmacs-1.99.13/src/Plugins/Qt/QTMPipeLink.cpp: In member function 'bool QTMPipeLink::launchCmd()':
/build/TeXmacs-1.99.13/src/Plugins/Qt/QTMPipeLink.cpp:52:39: warning: 'void QProcess::start(const QString&, QIODevice::OpenMode)' is deprecated: Use QProcess::start(const QString &program, const QStringList &arguments,OpenMode mode = ReadWrite) instead [-Wdeprecated-declarations]
   52 |   QProcess::start(utf8_to_qstring(cmd));
      |                                       ^
In file included from /nix/store/njywy8s62w93ymr822sc9cl03nv72q7r-qtbase-5.15.0-dev/include/QtCore/QProcess:1,
                 from /build/TeXmacs-1.99.13/src/Plugins/Qt/QTMPipeLink.hpp:17,
                 from /build/TeXmacs-1.99.13/src/Plugins/Qt/QTMPipeLink.cpp:15:
/nix/store/njywy8s62w93ymr822sc9cl03nv72q7r-qtbase-5.15.0-dev/include/QtCore/qprocess.h:168:10: note: declared here
  168 |     void start(const QString &command, OpenMode mode = ReadWrite);
      |          ^~~~~
[ 96%] Building CXX object src/CMakeFiles/texmacs_body.dir/Plugins/Qt/QTMWindow.cpp.o
[ 96%] Building CXX object src/CMakeFiles/texmacs_body.dir/Plugins/Qt/qt_chooser_widget.cpp.o
[ 96%] Building CXX object src/CMakeFiles/texmacs_body.dir/Plugins/Qt/qt_color_picker_widget.cpp.o
[ 96%] Building CXX object src/CMakeFiles/texmacs_body.dir/Plugins/Qt/qt_dialogues.cpp.o
/build/TeXmacs-1.99.13/src/Plugins/Qt/QTMStyle.cpp: In function 'void qtmDrawRoundedRect(QPainter*, const QRectF&, qreal, qreal, Qt::SizeMode)':
/build/TeXmacs-1.99.13/src/Plugins/Qt/QTMStyle.cpp:194:16: error: aggregate 'QPainterPath path' has incomplete type and cannot be defined
  194 |   QPainterPath path;
      |                ^~~~
make[2]: *** [src/CMakeFiles/texmacs_body.dir/build.make:6946: src/CMakeFiles/texmacs_body.dir/Plugins/Qt/QTMStyle.cpp.o] Error 1
make[2]: *** Waiting for unfinished jobs....
/build/TeXmacs-1.99.13/src/Plugins/Qt/QTMWidget.cpp: In member function 'virtual void QTMWidget::paintEvent(QPaintEvent*)':
/build/TeXmacs-1.99.13/src/Plugins/Qt/QTMWidget.cpp:240:48: warning: 'QVector<QRect> QRegion::rects() const' is deprecated: Use begin()/end() instead [-Wdeprecated-declarations]
  240 |   QVector<QRect> rects = event->region().rects();
      |                                                ^
In file included from /nix/store/njywy8s62w93ymr822sc9cl03nv72q7r-qtbase-5.15.0-dev/include/QtGui/qmatrix.h:45,
                 from /nix/store/njywy8s62w93ymr822sc9cl03nv72q7r-qtbase-5.15.0-dev/include/QtGui/qbrush.h:49,
                 from /nix/store/njywy8s62w93ymr822sc9cl03nv72q7r-qtbase-5.15.0-dev/include/QtGui/qpalette.h:46,
                 from /nix/store/njywy8s62w93ymr822sc9cl03nv72q7r-qtbase-5.15.0-dev/include/QtWidgets/qwidget.h:48,
                 from /nix/store/njywy8s62w93ymr822sc9cl03nv72q7r-qtbase-5.15.0-dev/include/QtWidgets/qframe.h:44,
                 from /nix/store/njywy8s62w93ymr822sc9cl03nv72q7r-qtbase-5.15.0-dev/include/QtWidgets/qabstractscrollarea.h:44,
                 from /nix/store/njywy8s62w93ymr822sc9cl03nv72q7r-qtbase-5.15.0-dev/include/QtWidgets/QAbstractScrollArea:1,
                 from /build/TeXmacs-1.99.13/src/Plugins/Qt/QTMScrollView.hpp:15,
                 from /build/TeXmacs-1.99.13/src/Plugins/Qt/QTMWidget.hpp:16,
                 from /build/TeXmacs-1.99.13/src/Plugins/Qt/QTMWidget.cpp:12:
/nix/store/njywy8s62w93ymr822sc9cl03nv72q7r-qtbase-5.15.0-dev/include/QtGui/qregion.h:125:20: note: declared here
  125 |     QVector<QRect> rects() const;
      |                    ^~~~~
make[1]: *** [CMakeFiles/Makefile2:317: src/CMakeFiles/texmacs_body.dir/all] Error 2
make: *** [Makefile:149: all] Error 2

@doronbehar Thank you for your feedback. It indeed requires some minor backward-compatible patching with Qt 5.15, which hopefully will be included in the next release (texmacs/texmacs#43).
I included the patch and rebased everything on master.

builder for '/nix/store/qvhx713b8hl2qx7y4h39qvs24p6y8dr0-3cf56af92326b74538f5e943928199ba6e963d0b.patch.drv' failed with exit code 1; last 7 log lines:

  trying https://github.com/texmacs/texmacs/commits/3cf56af92326b74538f5e943928199ba6e963d0b.patch
    % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                   Dload  Upload   Total   Spent    Left  Speed
    0     0    0     0    0     0      0      0 --:--:-- --:--:-- --:--:--     0
  curl: (22) The requested URL returned error: 404 Not Found
  error: cannot download 3cf56af92326b74538f5e943928199ba6e963d0b.patch from any mirror

@doronbehar I am terribly sorry for wasting your time. Somehow snuck in a minor typo hidden by caching. Fixed now.

Should I also include da5b670 to fix the returned version as well?

I'm surprised upstream didn't commit that before they tagged the release.. Yes, I think you should.

I was just as surprised. But they do not use CMake for the official release and this only effect CMake builds. Anyhow, I included aforementioned commit/patch as well.

Result of nixpkgs-review pr 84816 1

1 package built:

texmacs

@doronbehar: Thanks again for the feedback. That seemed to have been the issue indeed. Switched to Qt5's mkDerivation and replaced makeWrapper with qtWrapperArgs instead.

Result of nixpkgs-review pr 84816 1

1 package built:

texmacs

@FlorianFranzen is this launching for you without qt errors? It doesn't for me, and it won't create a wrapper. I suspect that it's because upstream's bin/texmacs is a shell script. So:
diff --git i/pkgs/applications/editors/texmacs/default.nix w/pkgs/applications/editors/texmacs/default.nix
index 8e985711213..aeef43e3f0b 100644
--- i/pkgs/applications/editors/texmacs/default.nix
+++ w/pkgs/applications/editors/texmacs/default.nix
@@ -69,6 +69,10 @@ mkDerivation {
     ])
   ];

+  postFixup = ''
+    wrapQtApp $out/bin/texmacs
+  '';
+
   inherit (common) postPatch;

   meta = common.meta // {

Forgot that nix-build, nix-env and nix-shell all work slightly different and that resulted in me overriding the shell incorrectly. :facepalm:
With your fix it now also works in a pure nix-shell (i.e. without impure access to my systems qtwayland). Thank you for all your input.

(i.e. without impure access to my systems qtwayland). Thank you for all your input.

You should never need that. Current wrapQtAppsHook implementation wraps executables with env vars for wayland users as well. However, you may want:
export QT_QPA_PLATFORM=wayland

Credit: https://wiki.archlinux.org/index.php/Wayland#GUI_libraries

Result of nixpkgs-review pr 84816 1

1 package built:

texmacs


Namespaced prefixes — next step for resolving name clashes

So #92 was somewhat resolved with this PR #120
The next step is to eventually publish a version of fantasy-land npm package with namespaced prefixed names.
There are some questions to discuss though:

When do we release the new version? Should we wait until majority of libs migrate to the new approach, or should we release it right away so two versions will coexist allowing everyone to choose on which versions to depend in each particular case?
How the prefixed names should look like?

Maybe there more questions, these two is what came to my mind.

I've faced a couple of problems with the new approach. Not sure where better to document them, hopefully this issue is fine.

of is a reserved word, we can't use it for a variable name. Workarounds are:

- import {map, of} from 'fantasy-land'
+ import {map, of as just} from 'fantasy-land'

- const {map, of} = require('fantasy-land')
+ const {map, of: just} = require('fantasy-land')

// Alternatively just import whole object to a variable
import fl from 'fantasy-land'
foo[fl.of](1)

Maybe we could add an alias for of in index.js (e.g. just)

Flow doesn't support dynamic names for methods (neither via class syntax nor via .prototype):

src/fantasy.js:34
 34:   [concat]( other:Stream<T> ): Stream<T> {
        ^ computed property keys not supported

src/fantasy.js:147
147: Stream.prototype[concat] = Stream.prototype.concat
     ^^^^^^^^^^^^^^^^^^^^^^^^ assignment of computed property/element. Indexable signature not found in
147: Stream.prototype[concat] = Stream.prototype.concat
     ^^^^^^ Stream

A workaround I found so far looks like this:
addFLmethods(Stream.prototype)

function addFLmethods( proto:any ): void {
  proto[concat] = proto.concat
}

But this is only a workaround for adding methods to a class, in any case we bypass Flow type checking when will use those class instances. And in general dynamic names can be a problem for any static analysis tools like Flow/TypeScript/etc.

I was thinking, maybe in the future we could start treating all this as a temporal measure for the transition period and go back to using hardcoded names but with prefixes.

Another issue: how to use FL compatible libraries in the browser (e.g. in jsfiddle)?
Options I see so far:

We could make fantasy-land package UMD compatible. Consumers then could load in browser two UMD libs (FL itself, and the FL compatible lib) and they should work fine together (not sure though, I'm not really sure how dependencies work in UMD).
Bundle fantasy-land as part of the browser build of the library. This is not a great idea, but still could work for things like jsfiddle as long as all FL libs that are used bundled the same version of FL.
Fallback to hardcoded unprefixed names in browser build of the library (basically same as 2. with backward compat version of FL).

hardcoded names but with prefixes

I'm still not convinced by this, because I don't use ramda or alternatives, so if we do prefix things it just means it's more of a pain for me and an extra barrier for using fantasy-land, the great thing about the spec is that it can be used in both!
Functor.prototype['fl/map'] = function(f) {};
// As an example.
const f = ...
f['fl/map'](x => x);

I wonder if there is a way to have both without sacrificing anything?

of is a reserved word, we can't use it for a variable name

But this is a tooling/linting issue not actual code issue, because running this doesn't cause any issues. So either we create an alias to solve the tooling/linting issue or we just change the name completely. I'm not a fan of just, I'd rather have pure.

@rpominov of is not a reserved word. Did some tool fail or did you just make that assumption?

@SimonRichardson @michaelficarra Yeah, you are right about of. Seems like only Flow has problems with it:
src/fantasy.js:4
  4: import {of} from 'fantasy-land'
             ^^ Unexpected token of

I'll open an issue in Flow repo...

Thanks @rpominov. Please link it here when you do. I'm very interested.

https://github.com/facebook/flow/issues/1340

:+1:

One thing, you're right that Flow doesn't currently support computed keys in a number of scenarios, and can't in general, but in the specific cases where the string literal information can be known statically it's possible. We already support string literal types, which enable this feature. I'll take a look to see if we can easily support this use case.

@samwgoldman That would be great! So yeah computed names are just strings that comes from this file index.js I think it could be statically analysed, at least theoretically :)

I wonder if there is a way to have both without sacrificing anything?

In Fluture I did this thing where I create keys for both 'map' and FL.map on my type, so when FL adds namespaces, my API won't change, and FL dispatchers will still work.

I think this the best way to do it, create normal methods in your API like with "old" FL, and then do something like:
Type.prototype[FL.map] = Type.prototype.map
Type.prototype[FL.ap] = Type.prototype.ap
...

We could even provide a helper that does this automatically:
import {makeFantasyLandCompatible} from 'fantasy-land/compat-helper'

makeFantasyLandCompatible(Type)

Just a curious question: why isn't Symbol.for being used? I feel something like exporting Symbol.for("fantasy-land/ap") may work fairly well, since Symbol.for is required to work cross-realm per ES2015+ spec.

Symbols may cause some pain in legacy JS environments. Also Flow doesn't currently support Symbols for instance.
On the other hand it's not clear how Symbol.for("fantasy-land/ap") better than just "fantasy-land/ap" for our use-case.

More discussion on the subject of Symbol.for('fantasy-land/x') can be found here

@rpominov I came up with a possible solution to that here.
But I'm still trying to see why namespacing is even necessary at all. Reading the previous discussion on namespacing the methods hasn't really convinced me.

This is done.

@samwgoldman We now have switched to constant prefixed names, which Flow can support but unfortunately doesn't yet.

Opened an issue in Flow repo https://github.com/facebook/flow/issues/2482


Create 1 PR for the same update across update configs

We have a monorepo for some microservices and have config something like this:
version: 1
update_configs:
- package_manager: "javascript"
  directory: "/path/to/project1"
  update_schedule: "daily"

- package_manager: "javascript"
  directory: "/path/to/project2"
  update_schedule: "daily"

- package_manager: "dotnet:nuget"
  directory: "/path/to/project3"
  update_schedule: "daily"

- package_manager: "dotnet:nuget"
  directory: "/path/to/project4"
  update_schedule: "daily"

So if for example Typescript gets updated we end up with two PRs, 1 each for project1 and project2.
Its worse with dotnet because we have common assemblies between the two projects, so if a dependency in one of them changes, we end up with two PRs for the same project.  This obviously resolves and dependabot closes the second one when we merge the first one but it is still extra noise.
Perhaps you could support multiple folders per configuration so they can be easily grouped?
version: 1
update_configs:
- package_manager: "javascript"
  directory:
  - "/path/to/project1"
  - "/path/to/project2"
  update_schedule: "daily"

- package_manager: "dotnet:nuget"
  directory:
  - "/path/to/project3"
  - "/path/to/project4"
  update_schedule: "daily"

Bump

Similar to #1190

This would be awesome for us.

Update: We've started doing some grouped updates work! This particular issue might not be part of the first ship but if you want to track our updates, do follow #1190.

Following up; we've started doing some exploration for allow multiple directories to be grouped together.

tagging @Nishnha and @honeyankit

I have been finding this increasingly problematic with interdependencies within a python monorepo.
if package1 depends on package2 and a dep is bumped in package2 then the poetry lock file in package1 still depends on the older version of the transient dependency.
this will fail the build, so we end up having to manually untangle that.
updating across the entire repo would prevent this.

I have been finding this increasingly problematic with local interdependencies within a python monorepo.
if package1 depends on package2 and a dep is bumped in package2 then the poetry lock file in package1 still depends on the older version of the transitive dependency.
this will fail the build, as the lock file for package1 contains the old version of dep1, which does not meet the new transitive requirement from package2, so we end up having to manually untangle that.
updating across the entire repo would prevent this.

I ignore how other ecosystems work, but can your Python package manager store and share version definitions across projects?
In the Java world, this is easily solved defining the version in the parent project and letting the children projects inherit the version

I have been finding this increasingly problematic with local interdependencies within a python monorepo.
if package1 depends on package2 and a dep is bumped in package2 then the poetry lock file in package1 still depends on the older version of the transitive dependency.
this will fail the build, as the lock file for package1 contains the old version of dep1, which does not meet the new transitive requirement from package2, so we end up having to manually untangle that.
updating across the entire repo would prevent this.

I ignore how other ecosystems work, but can your Python package manager store and share version definitions across projects?
In the Java world, this is easily solved defining the version in the parent project and letting the children projects inherit the version.
When this happens, not only dependabot but any tool or developer can update the version in a single place

no, this is not supported by the tooling at the moment.

I have been finding this increasingly problematic with local interdependencies within a python monorepo.
if package1 depends on package2 and a dep is bumped in package2 then the poetry lock file in package1 still depends on the older version of the transitive dependency.
this will fail the build, as the lock file for package1 contains the old version of dep1, which does not meet the new transitive requirement from package2, so we end up having to manually untangle that.
updating across the entire repo would prevent this.

I ignore how other ecosystems work, but can your Python package manager store and share version definitions across projects?
In the Java world, this is easily solved defining the version in the parent project and letting the children projects inherit the version.
When this happens, not only dependabot but any tool or developer can update the version in a single place

no, this is not supported by the tooling at the moment.

Relevant https://github.com/python-poetry/poetry/issues/2270

Relevant python-poetry/poetry#2270

I don't see that ticket being realistically touched in the foreseeable future, it's just an unnecessary distraction from the issue here.

Relevant python-poetry/poetry#2270

I don't see that ticket being realistically touched in the foreseeable future, it's just an unnecessary distraction from the issue here.

Apologies, I did not mean to suggest that that issue would solve the problem here.
It just answered my question and could help others with a similar curiosity. Dependabot can definitely support this independently even if poetry never does

Is this now supported given this recent PR: https://github.com/dependabot/dependabot-core/pull/8541 ?

@magnusjtvisma Not sure but I opened #8808 because I can't read Ruby well enough to know how to configure whatever it is 8541 is doing.

Multi-dir configuration is now in public beta; open to hearing your thoughts as you try out the beta!
Tagging @carlincherry

You should be able to configure the limit.
open-pull-requests-limit: 10
The use case to limit it is that sometimes it can be overbearing to review a bunch of dependencies.

For me, the annoying part so far testing out the beta is that I can't seem to get dependabot to update existing incorrect PRs.  I tried @dependabot recreate and it told me that it was previously created with a different config. It then suggested I close the PR: "The dependabot.yml entry that created this PR has been deleted so this PR can't be recreated. Please close the PR so Dependabot can create a new one with the current dependabot.yml." I did so. It then responded with "OK, I won't notify you again about this release, but will get in touch when a new version is available. [...]" - is this message incorrect?

This worked great in the repo I tested it in. I had 3 outstanding PRs and after changing the config these were closed and replaced with a single PR.

For me, the annoying part so far testing out the beta is that I can't seem to get dependabot to update existing incorrect PRs. I tried @dependabot recreate and it told me that it was previously created with a different config. It then suggested I close the PR: "The dependabot.yml entry that created this PR has been deleted so this PR can't be recreated. Please close the PR so Dependabot can create a new one with the current dependabot.yml." I did so. It then responded with "OK, I won't notify you again about this release, but will get in touch when a new version is available. [...]" - is this message incorrect?
Edit: If I go to Insights -> Dependency Graph -> Dependabot, I can see the dependabot logs that one of the directories was a top-level directory, and so dependabot failed to unify the directories to find csproj files to consider. So, the message may be incorrect.

Hi @jzabroski I also replied in another issue but wanted to add here too in case folks are reading this thread. I'm sorry you experienced this behavior; this is a known issue; our team is actively investigating and we'll update here as we investigate.

Thanks for working on this!

Multi-dir configuration is now in public beta; open to hearing your thoughts as you try out the beta!

We tried this in the freedomofpress/securedrop-client repository (dependabot.yml) but it is timing out:

Is our repository/dependency tree too big to combine like this? Or something else we can tweak? Let me know if more information is useful or if I should leave this comment elsewhere.

Is our repository/dependency tree too big to combine like this? Or something else we can tweak? Let me know if more information is useful or if I should leave this comment elsewhere.

Possibly -- a couple thoughts:

Maybe try a more specific grouping pattern(s) than *?
If you're experiencing timeouts, one option to try could be larger GitHub-hosted (unfortunately, larger GH-hosted runners cost $, but you might get rid of the timeouts) or self-hosted runners (configure yourself to give more compute power to avoid the timeouts 😄). Check out these docs to see if either larger GitHub-hosted or self-hosted runners might be of interest to you!

Hi folks, this feature is now live! 🎉
https://github.blog/changelog/2024-06-25-simplified-dependabot-yml-configuration-with-multi-directory-key-directories-and-wildcard-glob-support/
If you encounter any issues with this please reach out to GitHub support.


[ML-10008] make_spark_converter() takes dtype to use double -> float conversion

Add param precision to make_spark_converter(), converting floating-point type to the desired precision at saving time.
Tested in a unit test.
Latest API:

make_spark_converter(
        df,
        cache_dir_url=None,
        parquet_row_group_size_bytes=DEFAULT_ROW_GROUP_SIZE_BYTES,
        compression=None,
        precision='float32')

Codecov Report

:exclamation: No coverage uploaded for pull request base (master@2e57291). Click here to learn what that means.
The diff coverage is 100%.

@@            Coverage Diff            @@
##             master      #19   +/-   ##
=========================================
  Coverage          ?   82.17%
=========================================
  Files             ?       80
  Lines             ?     4325
  Branches          ?      685
=========================================
  Hits              ?     3554
  Misses            ?      667
  Partials          ?      104

Impacted Files
Coverage Δ

petastorm/spark/spark_dataset_converter.py
88.05% <100%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2e57291...5dad3dc. Read the comment docs.


revert import

[!WARNING]
This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more

#5  👈
#4
#3
master

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @Sunandadadi and the rest of your teammates on  Graphite


OutOfMemoryError: Java heap space

Hello, I ran into a problem. There is a server with 4GB of RAM. I want to check LRS on https://lrstest.adlnet.gov /, however, after a small number of requests, the Java heap space error appears. Can you help, what could be the problem
log.txt

Hello @HotsHom!
I attempted to reproduce your error on a Docker image that used only 2 GB of RAM, using the LRS conformance test suite, yet we did not get any error. Can you please tell us the following information?

Your Java heap size (most important)
The version of SQL LRS you are using
The log file of the LRS conformance test suite (not SQL LRS itself) (you can create a log file by running the test suite in the CLI and then finding it in the log directory)

I've looked into this with your given info and I am still unable to reproduce your error, even with manually setting -Xms64m -Xmx256m (which correspond to the initial and max heap sizes you listed, respectively). As such I have a few more questions:

Does the OOM error go away if you increase the maximum heap size?
Does this error occur if you run SQL LRS on any machines besides your server? If not, that may indicate that the issue stems from a particular configuration of that server.
Are you using Docker or downloading SQL LRS directly?
Just to clarify, are the underscores and asterisks in the URLs in your configuration just for obfuscation and not part of the actual URLs you're using?

I apologize for the late response. I tried to run on another system (still Window), attached java parameters. The error is still the same when performing tests on lrstest.adlnet.gov .
There may be a problem, of course, in the size of the heap, but I can no longer imagine where else it can be changed. I tried using Windows environment variables, tried adding parameters to the file bin/run_sqlite.sh

So it appears that you are running SQL LRS on Windows, is that correct? Given that SQL LRS on Windows has a unique startup procedure*, can you describe the steps you went through to start SQL LRS?
* Most notably you need to run the Windows executable and not the shell file, so I am not sure why you were adding parameters to bin/run_sqlite.sh.

I download the latest version of the release from git
Unpack
it and run it sqlrs.exe
The problem was not reproduced on the Linux system, everything went smoothly there and everything works

So we were finally able to reproduce the OOM error on Windows, indicating that it's a problem specific to that platform. We are still not sure why this is the case, but we will continue looking into it.

Hello @HotsHom,
Apologies for the very long wait, but we are currently working on addressing this bug, which we have also now encountered on certain Linux systems. It appears that this bug relates to encoding - in environments where the default charset is not set to UTF-8, Unicode strings will be improperly encoded/decoded, which will not only cause OOM errors, but also (if we increase the memory cap) cause the conformance tests to fail anyways.
We currently have a PR aimed at addressing this: https://github.com/yetanalytics/lrsql/pull/260

Our fix has been applied to version v0.4.0.


[CI] substraTEE-M6-master_nightly has undetected panics

Worker2 currently panics with
thread 'main' panicked at 'called `Result::unwrap()` on an `Err` value: SGX_ERROR_ENCLAVE_FILE_ACCESS', worker/src/main.rs:153:23
note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace

but this is undetected by Jenkins.

I think this was caused by calling worker2 from root worker2/bin/substratee-worker which set the wrong working dir.
Should be fixed with #195
The panic doesn't occur. But I'm not certain that the test would fail if it would

found it. We missed catching errors for worker2 startup:
catchError(buildResult: 'UNSTABLE', stageResult: 'FAILURE') {


[Dist][Pass] ZeRO optimization

Description
This PR performs all ZeRO related optimizations. There are two main optimizations and two passes are impacted. May changes are listed below:

Modify the partition gradient pass: after modification, the reduce_scatters are grouped and issued together for ZeRO-2. ZeRO-1 is remain the same
Implement a new pass, i.e., group_allgather. This pass detect the computation pattern in ZeRO and group the corresponding ops. Including cast and allgather. The group_allgather updates the parameter in-placed. So no extra add zero will be launched.
A new field is added to distributed context: group_bucket_size. This is an hyper parameter to  control the group size in group communications. The default value is<PHONE_NUMBER>, which is in consistent with DeepSpeed. It can be set to 0 or 1 so as to not group any communications at all.

Checklist

[x] PR's title starts with a category (e.g. [BUGFIX], [MODEL], [TUTORIAL], [FEATURE], [DOC], etc)
[x] Changes are complete (i.e. I finished coding on this PR)
[x] All changes have test coverage
[x] Code is well-documented

cc @awslabs/raf-reviewer

Got it, Thanks! Will modify accordingly.

Overall LGTM. One insight I got from this PR is that we really need an ANF pattern matcher...
Other than the comments I left, there are two points

Please be ware of #20 that changes dist_context and will result in conflicts (please also help review that PR and get it merged).
@hzfan @zachzzc @whbldhwj @hgt312 @yzhliu please help review this PR as well.

Thanks @zhen-jia


Display success rate rather than latency in main linkerd dashboard

Replace the per-client latency graph (which updates once per minute, making it somewhat confusing) with a success rate graph.
Possibly we should show two success rates: what we see from the client, and what we return from linkerd. Since linkerd can retry, this should be >= the raw client success rate.
(As a result of this, we may need to tweak the visual treatment of client colors--right now the latency graphs are the easiest way of identifying what color a client is. But I would save that for a followup ticket once we can see what this looks like.)

retries don't occur at the client level, so it would be difficult to display the serverside successrate in the client graph.

I see. As a starting point, maybe we show a per-server success rate in the UI--that will capture retries, and we have some space for it visually on the page. That's not a perfect solution, but should be useful in the common case of one server per router.

Things I will do:

Add back the horizontal client colour line
Have the graph scaling be "downward" ie we want to compare against 100%

Updated the description with the latest Product Vision. This ticket is scoped to changes to the client section. I'll make another ticket to capture changes to the server section.


Help - Tracker connection

Hello,
thank you for this integration. Unfortnatly I was not succesfull to connect the tracker. Mabey I'm doing something wrong.
In the package I have a leaflet with the following information:
Seriennummer - Serialnumber (9 digit numeric)
Schlüsselnummer - "key number" (8 digit numeric)
QR code with 24 digit only letters
I tried both the numbers and letters for either the device and auth token. Both seem not to work. I will always get following error in the log.
Error while setting up fressnapf_tracker platform for device_tracker

Traceback (most recent call last):
  File "/usr/src/homeassistant/homeassistant/helpers/entity_platform.py", line 362, in _async_setup_platform
    await asyncio.shield(task)
  File "/config/custom_components/fressnapf_tracker/device_tracker.py", line 27, in async_setup_entry
    FressnapfTrackerDeviceTracker(
  File "/config/custom_components/fressnapf_tracker/device_tracker.py", line 44, in __init__
    super().__init__(coordinator, tracker_id)
  File "/config/custom_components/fressnapf_tracker/entity.py", line 22, in __init__
    name=str(self.coordinator.data["name"]),
             ~~~~~~~~~~~~~~~~~~~~~^^^^^^^^
KeyError: 'name'

Most proberly I'm doing something wrone. I would appreciate your help. Thank you.

Thank you for the feedback. That might be beyond my capabilities :wink:
But I would be very intrested in using it, If you ever find the time and effort to document or integrate it.

Ive had those same questions and decided to put this project aside for now as I'm quite busy with other stuff right now. I hover accidentally came across a super helpful app for iOS that allows you to install a local proxy right on your device and receive a very comfortable overview over all http-calls that are made from your phone.. long story short: this is a rather easy way to determine the needed values for this integration (if you're on iOS).
check out https://apps.apple.com/us/app/proxyman-network-debug-tool/id1551292695
hope that helps

There won't be any help in this repository with getting the tokens. There are guides in other places like the home assistant forum


bootstrap4 HerbariaController

Turn HerbariaControllerTest green (when the PR is ready for review).

Coverage increased (+0.02%) to 82.285% when pulling d98dc668501ea2c5ab06e0b789f877abd39c8226 on 173432657-jdc-bootstrap4-herbaria_controller into 66da1e5d629eb55acdc6c5dc1e71dc3ec31cd46a on bootstrap-4.

All tests green. Now fo some refactoring.

I'm making this "ready for review" because all tests are green and I've done the easy refactoring.
I should spend lots more time on it, but don't want to do so now. I created Pivotal Story #173480416 covering these issues:

Overall design: :show can be called with either GET or POST. The POST stuff should be moved, maybe to its own action :add_curator. Or maybe all the curator modification stuff should be part of :edit/:update
Class Size. Maybe divide into (a) actions that just display stuff; (b) CRUD actions.
Other metrics violations: ABC, perceived complexity, method size

I'm also surprised that post :show works. I don't see a corresponding route in the output of rails route. But note:

"By default, Rails creates routes for the seven default actions (index, show, new, create, edit, update, and destroy) for every RESTful route in your application." https://guides.rubyonrails.org/routing.html#restricting-the-routes-created

Oh no! Travis pr build aborts. I need to look into this, so turning it back to a Draft PR.

Travis was fixed, thanks to @mo-nathan!

This is fantastic, Joe.

Thanks. I'll merge it.
I'd like to get the pending PR's merged in order to minimize conflicts. (Conflicts with others people's branches are inevitable and reasonable, but conflicts with my own stuff is wasteful and annoying.)


Fixed newline issues with generated code

Schemas with structure groups (like below) would generate incorrect code. Compiling this schema:

using Go = import "/go.capnp";
@0x83c2b5818e83ab19;

$Go.package("template_fix");

struct SomeMisguidedStruct {

    someGroup :group {

        someGroupField @0 :UInt64;
    }
}

... would result in the following erroneous code being generated (snipped for relevant part):
func (s SomeMisguidedStruct) SomeGroup() SomeMisguidedStruct_someGroup { return SomeMisguidedStruct_someGroup(s) }func (s SomeMisguidedStruct_someGroup) SomeGroupField() uint64 {
    return s.Struct.Uint64(0)
}

After modification of the structGroup template (and re-generation of templates.go), the above is corrected and proper, compiling code is generated.

Changed templates to inject newlines after struct ReadRoot* and list At (which previously had no newlines between themselves and the following line). This is just a pedantic fix - the generated code compiled fine (as opposed to the above)

Tested manually and made sure that the differences in templates.go are only \n.

:+1: Thanks! I've added the snippet you gave as a test case for capnpc-go.

Cool, at an initial glance I thought this portion wasn't covered by unit tests. Was obviously wrong :P

They're more integration test-y than anything else.. I have some spot unit tests here and there, but in general I use integration_test.go in the root package to test the generated code functionality, and then the test I modified is useful for checking that generated code is still parseable (usually for Travis builds).


Fix: 'File.exists?' don't work on Ruby 3.2

'File.exists?' don't work on Ruby 3.2. So change to 'File.exist?' in image.rb

Please apply this change to the whole codebase (spec_helper.rb) for example.

Thank you for advice. I did grep whole files, there are only 2 files.  image.rb, spec_helper.rb

Thanks! Release 4.1.0 with these changes.


09.01.01

As a claimant, I want to make and work on expense claims and items while offline, and push application and expense information online once I get connectivity.

Will require getting android connectivity. Nothing to test as of now 2/12/2015


Add a unique ID to Rayo resource identifier

The current identifier uses the PID for uniqueness, but this isn't enough under certain conditions - for example, when containerizing Adhearsion.
If the machine name is the same across containers (e.g. by using --net=host on Docker) and Adhearsion is the only process running in each container, the likelyhood of a PID conflict is quite high (as the PIDs assigned to a process inside a container start from 1 again and so are usually quite low -- < 10.)

@emcgee Like the idea in theory, but contemplating the implementation. Is there some other unique container ID we could inject instead? Also, were you aware that the XMPP resource can be specified by<EMAIL_ADDRESS>What do you think about pushing the responsibility for constructing a unique resource to the application?

I wasn't aware when I pushed this yesterday that it could be specified as such, but I just so happen to have seen that this morning. :book: :eyes:
It was a touch confusing since ahn just blocks at the Adhearsion::PunchblockPlugin::Initializer: Starting connection to server stage -- only in FS does it report a JID conflict. The containers don't necessarily have any inherent unique identifying features, specifically if they're running as (again, using Docker terminology since it's the most fashionable atm) --privileged or --net=host -- otherwise the machine name is unique and it's a non-issue.
My thinking was that adding a uuid to the resource seemed like one way to avoid this issue transparently without burdening folks with somewhat subtle configuration step. If we did decide to make it the application responsibility, we'd probably want to call out the JID conflict in ahn more explicitly.

I agree completely that if we are getting an XMPP error regarding the JID conflict, we should be raising/logging that. Can you confirm (trace logs probably) whether we're being told about the conflict?

Yep - ran it at trace and it just sits receiving and incrementing the blather id:
[2015-10-31 20:44:28.693] TRACE Punchblock::Connection::XMPP: RECEIVING (iq) <iq type="result" from="<IP_ADDRESS>"<EMAIL_ADDRESS>id="blather0017"/>
Gist of a full run: https://gist.github.com/emcgee/97e42e2177f0380235ff

Hm, strange. If we're not getting any notice from the XMPP server that there's a problem, it'll be hard for us to do anything about it. @crienzo @benlangfeld is this a limitation of FreeSWITCH's XMPP?

It would be nice to see FreeSWITCH logs of this to be sure.

FreeSWITCH debug logs of JID conflict: https://gist.github.com/emcgee/c50f602cd9ea8b63055b

Confirm, @emcgee, this needs to be fixed in FreeSWITCH. From RFC3921:

If there is already an active resource of the same name, the server MUST either (1) terminate the active resource and allow the newly-requested session, or (2) disallow the newly-requested session and maintain the active resource. Which of these the server does is up to the implementation, although it is RECOMMENDED to implement case #1. In case #1, the server SHOULD send a  stream error to the active resource, terminate the XML stream and underlying TCP connection for the active resource, and return a IQ stanza of type "result" (indicating success) to the newly-requested session. In case #2, the server SHOULD send a  stanza error to the newly-requested session but maintain the XML stream for that connection so that the newly-requested session has an opportunity to negotiate a non-conflicting resource identifier before sending another request for session establishment.

Step 2 (alt): Server informs existing active resource of resource conflict (case #1):

stream:error

</stream:error>
</stream:stream>

> Step 2 (alt): Server informs newly-requested session of resource conflict (case #2):

> ```xml
<iq from='example.com' type='error' id='sess_1'>
  <session xmlns='urn:ietf:params:xml:ns:xmpp-session'/>
  <error type='cancel'>
    <conflict xmlns='urn:ietf:params:xml:ns:xmpp-stanzas'/>
  </error>
</iq>

Freeswitch does send the resource conflict.

I don't see that in the above log. Is that new, @crienzo?

oops... i guess the conflict is detected, just not communicated to adhearsion.  I can fix that.

https://freeswitch.org/jira/browse/FS-8619 created

Thanks @crienzo

Try latest v1.4 or master code.  Looks OK from my quick test of happy scenario.


WL-5319 SAK-43568

Can one of the admins verify this patch?

@nicholaswilson100 this is ready to go.


fix #587

query for synonyms and get the corresponding mainTagIds.
add ID in condition to the main query statement.

I noticed you changed the code, but there are still some issues. You can test it by following steps.

Add two tags a and b
Set b to be a synonym for a
Use b for querying via api

You'll notice that the a tag still doesn't appear in the query result. It doesn't solve the issue of #587 .

ok, I'll try to debug it.

I noticed you changed the code, but there are still some issues. You can test it by following steps.

Add two tags a and b
Set b to be a synonym for a
Use b for querying via api

You'll notice that the a tag still doesn't appear in the query result. It doesn't solve the issue of #587 .

I followed your three steps to test, and there was no problem. As shown below:

Strange, where is the problem?


Add sentence splitter

It would be useful to add a sentence splitter, for instance, possibilities could be,

Puntk sentence tokenizer from NLTK (needs pre-trained model)
Unicode sentence boundaries from https://github.com/unicode-rs/unicode-segmentation/pull/24 (doesn't need a pre-trained model)
investigate spacy implementation (likely needs pre-trained model)

spaCy has two sentence segmentation implementations. The default is based on the dependency parser which requires a statistical model. The second implementation is a simpler splitter based on punctuation (default is ".", "!", "?"). (https://spacy.io/usage/linguistic-features#sbd)
On another note it looks like the Unicode sentence boundaries from unicode-rs/unicode-segmentation#24 has been implemented. I could look at how to incorporate this into this library?

The second implementation is a simpler splitter based on punctuation (default is ".", "!", "?").

I think you can do this already with the RegexpTokenizer using something like,
let tokenizer = RegexpTokenizerParams:default()
    .pattern(r"[^\.!?]".to_string())
    .build()
    .unwrap();
tokenizer.tokenize("some string. another one").collect();

(haven't checked that the regexp is correct) so I'm not sure we need a separate object for it. Maybe just indicating the appropriate regexp for sentence tokenization could be enough?
For the sentence boundaries from the unicode_segmentation crate, yes that would be great if you are interested to look into it! I would also be interested to know how it compares to the Spacy tokenizer that uses a language model.

I have just done a comparison between the different methods: splitting based on punctuation, Unicode segmentation, NLTK's Punkt model and spaCy. I used the Brown corpus as the benchmarking dataset.
Here are my results:

Method
Precision
Recall
F1

Punctuation spliter
0.896
0.915
0.906

Unicode segmentation
0.938
0.912
0.925

NLTK Punkt
0.907
0.875
0.891

spaCy
0.924
0.908
0.916

Jupyter notebook with full analysis
Interestingly each model scores very similarly. Presumably because most sentences are quite easy (with a full stop and then a space) and you get very few which are more difficult (for example quotes, colons etc.). The Unicode segmentation surprisingly has the best score (F1) and has the added benefit that it's language independent (as previously suggested by @jbowles in #52).
I will do a PR on incorporating UnicodeSegmentation in the coming days.

Thanks! Sounds great. It's interesting indeed that Unicode segmentation is competitive even compared to spacy, and I imagine it's much faster.

PR #66 implements the thin wrapper around the Unicode sentence segmentation.
Regarding the "simple punctuation splitter": using a regex like [^\.!\?] doesn't work as you would loose the punctuation at the end of each sentence. I also tried (.*?[\.\?!]\s?) but here you would loose the trailing sentence if it didn't include a punctuation. For example:
Input = ["Here is one. Here is another! This trailing text is one more"]
Desired Output = ["Here is one.", "Here is another!", "This trailing text is one more"]

I don't think it's possible with Regex. Do you have any ideas?
Another tactic would be to create a itterator similar to how to spaCy and what I did in the Jupyter notebook. For example:

def split_on_punct(doc: str):
    """ Split document by sentences using punctuation ".", "!", "?". """
    punct_set = {'.', '!', '?'}

    start = 0
    seen_period = False

    for i, token in enumerate(doc):
        is_punct = token in punct_set
        if seen_period and not is_punct:
            if re.match('\s', token):
                yield doc[start : i+1]
                start = i+1
            else:
                yield doc[start : i]
                start = i
            seen_period = False
        elif is_punct:
            seen_period = True
    if start < len(doc):
        yield doc[start : len(doc)]

FYI I'm going to look into implementing the "simple punctuation splitter" using a Rust iterator.

FYI I'm going to look into implementing the "simple punctuation splitter" using a Rust iterator.

Thanks, that would be great!

Regarding the "simple punctuation splitter": using a regex like [^.!?] doesn't work as you would loose the punctuation at the end of each sentence.

I think using the regexp crate would still work but using split instead of find_iter to avoid the issue of the last sentence. Though I agree you would have to do a separate tokenizer for it.

Closing as resolved in https://github.com/rth/vtext/pull/66 and https://github.com/rth/vtext/pull/70, thanks again @joshlk !


Customer Account API

Hi Team,
When can we expect Customer Account API integration in checkout-sheet-kit or mobile-buy-sdk-ios?
Also, will it be passwordless login functionality?

Hi @harishvitta we have a couple of dependencies on other teams completing projects before we can start this work. So I don't think we have a timeline just yet.
It'd be passwordless for shops using new customer accounts, via the customer account API where customers will likely be redirected to the login page in a WebView for the first step.

@kiftio Thanks for the update.


Problem about 'placeholder' function

I installed Tensorflow using Pip in Vmware Simulation Machine Ubuntu Operation System with only CPU Evn.
When I used tensorflow in python 2.7:

import tensorflow as tf
x = tf.placeholder(name="x")

I met one error:
Traceback (most recent call last):
File "", line 1, in
TypeError: placeholder() takes at least 1 argument (1 given)
This code is an instance in http://download.tensorflow.org/paper/whitepaper2015.pdf

The whitepaper is probably out of date / incorrect.  See https://www.tensorflow.org/versions/r0.8/api_docs/python/io_ops.html#placeholder for up to date documentation.

x = tf.placeholder(tf.string, name="x")
Thanks!


Check to see if photoData exists before using

A fix for issue CB-5698: https://issues.apache.org/jira/browse/CB-5698
Image files that for one reason cannot be copied will crash. Returning
when photoData returns nil prevents the crash.

Thanks for the pull request! However, this repository is outdated and no longer the canonical source. I've updated the README.md to explain where the main projects now live.


add artifacted plugin

Codecov Report

Merging #31 (b9de105) into master (7ee77ef) will decrease coverage by 0.51%.
The diff coverage is 61.53%.

@@            Coverage Diff             @@
##           master      #31      +/-   ##
==========================================
- Coverage   84.31%   83.79%   -0.52%
==========================================
  Files          73       75       +2
  Lines        1868     1907      +39
  Branches      193      195       +2
==========================================
+ Hits         1575     1598      +23
- Misses        269      284      +15
- Partials       24       25       +1

Impacted Files
Coverage Δ

vedro/plugins/artifacted/_artifacted.py
54.54% <54.54%> (ø)

vedro/_config.py
100.00% <100.00%> (ø)

vedro/plugins/artifacted/__init__.py
100.00% <100.00%> (ø)

.../core/_scenario_discoverer/_scenario_discoverer.py
91.42% <0.00%> (-2.86%)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7ee77ef...b9de105. Read the comment docs.


Packet loss only using ethernet on GearVR

Hello there
ALVR works great for me through wifi but my router is old and shitty and 2.4ghz so the image is choppy and laggy but it's consistent as hell with almost no packet loss.
I have the S8 though so I thought I'd try it through an ethernet cable after hearing all sorts of good things about it. I bought an adapter which seems to work perfectly, i got the same speed test numbers as I do on my desktop. Using it for ALVR though is impossible, I get huge packet loss and the image is OK when I'm not moving but once I load up a game or move my head a bit, I get crazy visual artifacts that I can barely see through.
All my settings are at default except I'm on H.264 and for resolution whatever the option just under the recommended one is. I tried to play around with the settings but it didn't help
Any help would be hugely appreciated if anyone else has had the same problem

I have a similar issue. When I use USB ether adapter on my S8, I could see enormous packet "re-ordering", and which lead to many packet losses.
I don't know actual cause of the problem. Can the bad USB ether chip or the driver be the problem?
I wonder if there is anyone can use ether without problem on ALVR.

I have a similar issue. When I use USB ether adapter on my S8, I could see enormous packet "re-ordering", and which lead to many packet losses.
I don't know actual cause of the problem. Can the bad USB ether chip or the driver be the problem?
I wonder if there is anyone can use ether without problem on ALVR.

Thank you so much for the reply. I know very little about computers so I can't really contribute but I did read on reddit that people were having huge success using an ethernet adapter on the S8 with the GearVR which inspired me to try it

You could try to find a higher quality cable.  They have categories on them  (CAT5,  CAT5E and CAT6)  You should have a CAT5E or 6 cable.  And if it is all twisted up,  then maybe replace it.


libscrap_ffi.so not found

══╡ EXCEPTION CAUGHT BY WIDGETS LIBRARY
╞═══════════════════════════════════════════════════════════
The following ArgumentError was thrown building Builder:
Invalid argument(s): Failed to load dynamic library 'libscrap_ffi.so': dlopen
failed: library
"libscrap_ffi.so" not found
The relevant error-causing widget was:
MaterialApp
MaterialApp:file:///home/StudioProjects/rust_flutter_app/flutterust/lib/
main.dart:10:12

Hello, trying to create an app that uses rust as a backend and flutter as a front. I cloned your repo and ran the command for android, and then ran flutter run. I am running this on a linux ubuntu. Thanks!

Hey, did you compile the code using cargo make?

hello sorry for not getting back sooner, I complied the code using cargo android build.

No worries though, CLI and the web versions are working great, and that's all I need for now. thanks

Glad to hear that!
Also, you may want to take a look into more user-friendly solutions like https://github.com/fzyzcjy/flutter_rust_bridge

Ok cool thanks!


Fix remove_expired_responses deprecation suggestion

Fairly straightforward? I don't think remove even exists, and I assume it means to say delete.

Yes, definitely a typo. Thanks!


How I can use it for disk cache? And When cache is has cleared?

For example, I need download image to disk and then will clear cache.

Please read the Cheat Sheet wiki to know how to use a feature. And refer to the docs for more detail of ImageCache.


Add strictMode config option for non-fuzzy license checking

Example: by default simply adding "BSD" to the "allowedLicenses" matches "BSD", "BSD*", "BSD-3-Clause", "BSD-4-Clause", etc.
strictMode does a non-fuzzy check so you would, if you choose, be able to allow for BSD-3-Clause in "allowedLicenses" but not BSD-4-Clause.

I guess we should setup some tests after this 😛

@hzoo not a bad idea :)  Let me know how you want to proceed. I can either add some in a separate PR or along with this one.

@hzoo I modified the code a bit so it's more testable (at least the parts I wanted to test) and created some jest tests for strictMode.

This is great! dono about 0.10 I guess I forgot I didn't mean to support that (would be breaking change) but will just drop it.
Also realized we can't use jest (via PATENTs/license) lol.. irony.
You cool with switching to mocha/ava/jasmine? I can do it later too.

@hzoo sure I can switch it to mocha or ava. If you get to it before me then feel free - other wise I'll ping you when it's done :)

@hzoo ok I converted it to ava instead of jest

@hzoo let me know if there is anything else you need me to change. Thanks!

Cool will plan to merge/release tomorrow

@hzoo think we'll merge this soon?  :)

Ah totally forgot about this and on break so haven't being doing much oss, sorry

Can do it when I get my on computer later

sorry bout that @palmerj3, taking a break from oss stuff this holiday but should of did this earlier


Update top navigation in docs inline with new site

Fixes FLOC-2145

The links don't quite match up with ones on preview site, but that's just a preview for now so maybe doesn't match final links? Fix that if necessary, otherwise looks fine. Merge when ready.

Thanks Itamar, the links in the document provided are correct. If they don't align with the new site, then that wont pass website review


Fix issue 6664 - oEmbed cache_age

Fixes #6664

I have a minor code cleanup PR that would clash with the changes proposed here: #6922
Any chance that mine could get merged before or rolled into this one?

Merged in 3c6ac4b5026a8cd4ed8d979a701699389c417e7d - thanks @thenewguy!


Fix release

Coverage remained the same at 100.0% when pulling bca8d2ede213005cdd007be102a04f89a402d676 on fix-release into 70ea8cfb3e214fdf82574eb852f1314bcbe26483 on main.


(Refactor) Mobx state management

This is a huge commit that will require significant time dedicated to testing and resolving merge conflicts. It is a work in progress and is planned to be updated often until it is finally merged in.
High Level Changes

Mobx state management
removal of component state management
some small cleanup and refactoring where appropriate
pricing strategy integrated into the relevant information of its corresponding tier

More Detailed Changes
Ejected create-react-app for access to babel, which allows us to use decorators.
Babel file was based upon current mobx documentation.
Updated naming convention of all stores. Each store's name should ideally have 'store' within it to draw less confusion when importing stores into components.
I updated the initialized item name and the class itself.
Added an index.js files for all stores, and imported the stores into App.js. Stores are passed into the Provider method of 'mobx-react'.
Added a build_scripts folder that will hold build, start, and test files.
Things to test
Ensure that the ejection from create-react-app will not obstruct our build process.
Check to see that the provider component has access to the stores. This can be easily done through react-devtools, by checking that the props contain an object of stores.

@15chrjef use this package.json for Mobx PR

@15chrjef you can merge my PR to your branch to make deployment stage of Wizard working

Thanks @vbaranov. It works with the crowdsale through Kovan on the Invest and crowdsale page.

@15chrjef  one bug still exists: for [Tier name]: is lost.
From the downloaded at step 4 file:

Crowdsale contract address0xB1FF1C4D7BfaF3aeFe4eF1e3aB604b7F2b28410f -> Crowdsale contract address for [Tier name]: 0xB1FF1C4D7BfaF3aeFe4eF1e3aB604b7F2b28410f
Pricing strategy contract address0x3D8E0Fa030a44e77F9C4738AEE843752d79bA1FD -> Pricing strategy contract address for [Tier name]: 0x3D8E0Fa030a44e77F9C4738AEE843752d79bA1FD
Finalize agent contract address0x2Aeb492CEEA0aF88E1EAf681f0578886eBaA7372 -> Finalize agent contract address for [Tier name]: 0x2Aeb492CEEA0aF88E1EAf681f0578886eBaA7372

Where do you get these errors? What prompts it?

@15chrjef It is from downloaded file at step 4. Try to download and compare with that from master branch

I looked into this PR and here's what I thing we should do:

Merge the other 3 open PRs first, otherwise is going to be extra hard. #199 and #358 are ready IMO; #341 depends on #199 and needs a proper review when this is merged, but it's only view layer stuff so it shouldn't take long. Any non-critical problems with those PRs should go to open issues and be taken care of after this MobX PR is merged.
Solve the conflicting files very carefully. Probably @15chrjef is the best person to do it, but if he's busy, I can give it a try. What I'd do is to use the files with conflicts and re-apply the MobX changes by hand, because several things have changed since the last commit in the merged branch, and because solving each conflict by hand is very error prone.

I think this PR is very important for improving the codebase, and the longer we wait, the harder it will be to do it. If there's nothing of much higher priority, I'd focus our efforts this week in getting this merge out of the way.


app crashed while listening for Orderbook Notifications

i just had the app running in the background and came back to this crash
panic: runtime error: invalid memory address or nil pointer dereference
[signal SIGSEGV: segmentation violation code=0x2 addr=0x28 pc=0x105cfb3c8]

goroutine 2373 [running]:
github.com/crypto-power/cryptopower/ui/page/dcrdex.(*DEXMarketPage).listenForOrderbookNotifications(0x14006066000)
        /Users/user/go/src/github.com/crypto-power/cryptopower/ui/page/dcrdex/market.go:454 +0x78
github.com/crypto-power/cryptopower/ui/page/dcrdex.(*DEXMarketPage).fetchOrderBook.func1()
        /Users/user/go/src/github.com/crypto-power/cryptopower/ui/page/dcrdex/market.go:432 +0x174
created by github.com/crypto-power/cryptopower/ui/page/dcrdex.(*DEXMarketPage).fetchOrderBook in goroutine 1798
        /Users/user/go/src/github.com/crypto-power/cryptopower/ui/page/dcrdex/market.go:423 +0x2b8
exit status 2

resolved by https://github.com/crypto-power/cryptopower/pull/692


fix: Empty Sitemap.xml

Closes: #7341
A similar fix for the various sitemap-resources was merged previously, reference: #7320
This fix replicates the functionality for the root sitemap.xml file.

Hey @disordinary Thanks for the fix. Could you please check the frontend_spec.js?Why was the sitemap.xml test not failing without this fix?Thanks!
If we improve our tests, bugs like this might not happen.

On it.

All of our frontend_spec tests can probably be improved, in every case we're just checking the HTTP status code and a couple of header variables match what we expect, we don't test that the body contains content let alone that it matches what we expect.
I'll address the sitemap tests here and raise an issue.

cool 👍

I've added simple checks to make sure the returned text has the keyword of the root node for each site-map pages. It's not perfect but I also didn't want to add an xml-parser to the dev dependencies without broader discussion on how best to test content.
I've also raised issue #7361 to further improve these tests.


LNC import does not work on browser build

Currently I changed it to import dynamically so at least it doesn't break the whole component. But maybe we could show a better error message there, if we can't somehow fix it.

Ideally we should just be able to import the package without requiring a build pipeline.
Ideally we do not use esbuild.

Example: (works in codepen)
<script type="module">
  import confetti from 'https://cdn.skypack.dev/canvas-confetti';
confetti();
</script>


feat(package_info_plus)!: Add information about the installer store

Description
Adds the store through which the application was installed to the package info class.
This currently supports Android, iOS and macOS.
On web, it could make sense to return the URL, but I'm not too sure about that. Let me know what you think.
I'm also not sure what to do with Linux and Windows. It might be possible but I don't have a Windows machine nor a linux machine to test and figure it out. For now, both return just null for the installer store.
I'm not sure whether this is considered a breaking change, so I'd like to hear from you guys. Edit: It's a breaking change now.
Related Issues
Fixes https://github.com/fluttercommunity/plus_plugins/issues/570
Checklist
Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes ([x]).
This will ensure a smooth and quick review process.

[x] I read the Contributor Guide and followed the process outlined there for submitting PRs.
[x] My PR includes unit or integration tests for all changed/updated/fixed behaviors (See Contributor Guide).
[x] All existing and new tests are passing.
[x] I updated the version in pubspec.yaml and CHANGELOG.md.
[x] I updated/added relevant documentation (doc comments with ///).
[x] The analyzer (flutter analyze) does not report any problems on my PR.
[x] I read and followed the Flutter Style Guide.
[x] I am willing to follow-up on review comments in a timely manner.

Breaking Change
Does your PR require plugin users to manually update their apps to accommodate your change?

[x] Yes, this is a breaking change (please indicate a breaking change in CHANGELOG.md and increment major revision).
[ ] No, this is not a breaking change.

I think it is not completely a breaking change, but since you are changing the platform interface now all versions need to be bumped to major version so dependencies are resolved correctly.

I think it is not completely a breaking change, but since you are changing the platform interface now all versions need to be bumped to major version so dependencies are resolved correctly.

Thanks, will do so 👍

Could you update the integration_test as well to include this new property?
I expect it will be null always when running integration_tests, right?

Could you update the integration_test as well to include this new property?

Yes, sure.

I expect it will be null always when running integration_tests, right?

I'll figure it out and you'll be going to see when I update this PR :D

After some more investigation, the implementation on macOS made no sense and I changed it to just return null. I've also squashed all commits into one and addressed the remaining feedback.

After some more investigation, the implementation on macOS made no sense and I changed it to just return null. I've also squashed all commits into one and addressed the remaining feedback.

During my review I suggested to make the parameter optional and you did it, but I don't get it why still return null on platforms which don't provide the info about the installer. If the parameter is optional in the platform interface just skip it on platforms which don't have the info.

Hey! Due to changes in our contributor guidelines, all PRs should now:

Have a title that follows the Conventional Commits format. e.g. feat(package_name)!: feature description
DO NOT modify the CHANGELOG.md or the version in the pubspec.yaml. This is going to be an automated process now.

We would ask you kindly to update the PR following these changes.
Thanks!

I will take care of updating this PR later today.

Assigned it to you, so we remember :)

Looks like @ueman returned earlier when I :)

Looks good to me now. Thanks a lot for your contribution @ueman
I will merge as soon as tests finish.

It was a pleasure

After some more investigation, the implementation on macOS made no sense and I changed it to just return null. I've also squashed all commits into one and addressed the remaining feedback.

Thank you for adding this.
Though I'm curious what was the issue with macos? Mac apps can be distributed through testflight or the app store and the docs for appStoreReceiptURL say it is supported on MacOS 10.7+
https://developer.apple.com/documentation/foundation/nsbundle/1407276-appstorereceipturl?language=objc

After some more investigation, the implementation on macOS made no sense and I changed it to just return null. I've also squashed all commits into one and addressed the remaining feedback.

Thank you for adding this.
Though I'm curious what was the issue with macos? Mac apps can be distributed through testflight or the app store and the docs for appStoreReceiptURL say it is supported on MacOS 10.7+
https://developer.apple.com/documentation/foundation/nsbundle/1407276-appstorereceipturl?language=objc

Yeah, but the path doesn't follow the same schema, so the same trick as in iOS doesn't work. Feel free to improve the code though, if you find a way to get some information out of it.

Can the README be updated? I still don't know how to use this feature? Thanks!

Guys just coming to THANK YOU for this PR. This is going to hugely help our growth and analytics team and simplify our testing processes. Kudos!


Cannot create Windows Service

Issue description
Following the documentation here, I get an error message I don't understand. So for me, the complete instructions are not usable and I cannot complete my task to install the ASP.NET Core app as a Windows service. I'll have to recommend my customer to use Linux instead of Windows, I know how it works there. It's really easy. And fully scriptable in Bash, instead of multiple GUI installers, GUI configs and interleaved PowerShell commands.
I could create the user and assign it the privilege to logon as service. But the next step fails.
PS C:\Windows\system32> $acl = Get-Acl "C:\Demo\WebApplication1.exe"
PS C:\Windows\system32> $aclRuleArgs = "my-pc\Demo", "Read,Write,ReadAndExecute", "ContainerInherit,ObjectInherit", "None", "Allow"
PS C:\Windows\system32> $accessRule = New-Object System.Security.AccessControl.FileSystemAccessRule($aclRuleArgs)
PS C:\Windows\system32> $acl.SetAccessRule($accessRule)
Ausnahme beim Aufrufen von "SetAccessRule" mit 1 Argument(en):  "Es können keine Flags gesetzt werden.
Parametername: inheritanceFlags"
In Zeile:1 Zeichen:1
+ $acl.SetAccessRule($accessRule)
+ ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
    + CategoryInfo          : NotSpecified: (:) [], MethodInvocationException
    + FullyQualifiedErrorId : ArgumentException

PS C:\Windows\system32>

Target framework
.NET Core 3.1 (may not apply here)
Windows 10.20H2 x64 (not Server)

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: b0bd8cb8-7e28-8c4d-a550-3aea8f3ab4dd
Version Independent ID: 4b60d24e-ef05-15e5-10b4-483094081bf3
Content: Host ASP.NET Core in a Windows Service
Content Source: aspnetcore/host-and-deploy/windows-service.md
Product: aspnet-core
Technology: aspnetcore-hostdeploy
GitHub Login: @Rick-Anderson
Microsoft Alias: riande

Ausnahme beim Aufrufen von "SetAccessRule" mit 1 Argument(en):  "Es können keine Flags gesetzt werden.
Parametername: inheritanceFlags"
MT to English:
Exception when calling "SetAccessRule" with 1 argument (s): "No flags can be set.
Parameter name: inheritanceFlags "

I'm working this one as a crossover issue for Blazor, too. I'll investigate the reported error as I work through the updates. Updates include removing the 2.x pieces and adding bits for 5.x and 6.x. I'll deal with PS script updates. Note that the PS updates move all guidance to working PS 7 commands. We don't document old tooling.

@Rick-Anderson Please don't edit in questions, I don't see them.
Here's the value of the requested variable:
FileSystemRights  : Write, ReadAndExecute, Synchronize
AccessControlType : Allow
IdentityReference : mypc\myuser
IsInherited       : False
InheritanceFlags  : ContainerInherit, ObjectInherit
PropagationFlags  : None

Sorry folks! Change of plans. One of the docs team members will take care of the general updates first (3/4 open issues), then I'll come in later and address the Blazor-specific issue later.

Thank you for contacting us. Due to a lack of activity on this discussion issue we're closing it in an effort to keep our backlog manageable. If you believe there is a concern which hasn't been addressed, please file a new issue.


ic-include multilevel JSON

Hi,
excellent library.
Is it multilevel JSON supported like ic-include parameter?
For example:
ic-include='{"data":"action","param1":false,"obj":[{"name": "test1"}, {"name": "test2"}]}'

I get something like this in request:
ic-request=true&&ic-id=2&data=action&param1=false&obj=%5Bobject+Object%5D%2C%5Bobject+Object%5D&ic-current-url=%2Fadmin%2Fuser&_method=POST

Deeper levels as just an Object.
It is possible to use a multidimensional JSON in any way?
Thanks

Hmmm.  We should probably serialize an object for inclusion, shouldn't we?
Cheers,
Carson
On January 7, 2017 at 6:01:57 AM, Djordje Dimitrijev (
<EMAIL_ADDRESS>wrote:
Hi,
excellent library.
Is it multilevel JSON supported like ic-include parameter?
For example:
ic-include='{"data":"action","param1":false,"obj":[{"name": "test1"},
{"name": "test2"}]}'
I get something like this in request:
ic-request=true&&ic-id=2&data=action&param1=false&obj=%5Bobject+Object%5D%2C%5Bobject+Object%5D&ic-current-url=%2Fadmin%2Fuser&_method=POST
Deeper levels as just an Object.
It is possible to use a multidimensional JSON in any way?
Thanks
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/LeadDyno/intercooler-js/issues/155, or mute the thread
https://github.com/notifications/unsubscribe-auth/AAcov0zl8W0-hB1ujd8xAaGaaPJ4q6v-ks5rP5rTgaJpZM4LdbYI
.


Remove taxon constructor

Fixes #48 (by removing taxon constructor, since users should never use it)

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 51.92%. Comparing base (0ff0e0c) to head (abfae68).
Report is 6 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff             @@
##             main      #76       +/-   ##
===========================================
- Coverage   74.04%   51.92%   -22.12%
===========================================
  Files           5       15       +10
  Lines        1256     3058     +1802
  Branches        0      137      +137
===========================================
+ Hits          930     1588      +658
- Misses        326     1425     +1099
- Partials        0       45       +45

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


Request change: the example in the main README.md file is not clear

Before I start, I really thank you so much for this package.

I request to make a change:
The example at the README.md file in the main page of the package is not clear.
At first, I thought that the package was not working correctly.
I kept working, and sending requests till finally worked after about 15 minutes of trying.

For this reason:
The example is very advanced, and for someone who wanna learn the package for the first time, the learning curve of the example is very hard to learn.
This is dangerous for someone who wants to learn about the package for the first time.

So I would like to solve this problem by doing this.
Create 3 separate endpoints:

To read the GET request only, and above it the pydantic class of it.
To read the JSON request body only, and above it the pydantic class of it.
To read both the JSON request and the GET request together, using the old pydantic classes.

If God willed, I can make this change.
I will make these changes, If you give the permission.
Thank you!

Hello Omar,
feel free to modify README to give it more clarity and submit a PR. Any contribution is welcome!
Jirka

Hello Omar,
feel free to modify README to give it more clarity and submit a PR. Any contribution is welcome!
Jirka

Okay.
If God willed, I will do my best.
Thank you so much for giving me this opportunity.
👍 💯 🥇

Okay.
If God willed, I will do my best.
Thank you so much for giving me this opportunity.
👍 💯 🥇

released in version 0.6.0

released in version 0.6.0


Add placeholders for loading data

Where possible (at least the coverage track and variants tracks/table), use fixed height placeholders when loading data to reduce layout shift.

Done for coverage tracks. Variants tracks/tables are ok since they're the last thing on the page. Not much can be done for the genes track on region pages since its height is unknown until data is loaded.

Done for coverage tracks. Variants tracks/tables are ok since they're the last thing on the page. Not much can be done for the genes track on region pages since its height is unknown until data is loaded.


Fails in compilation of rpmsg application

Below is the error message.
| echo_test.c:26:25: fatal error: linux/rpmsg.h: No such file or directory
|  #include <linux/rpmsg.h>
|                          ^
| compilation terminated.
| Makefile:17: recipe for target 'echo_test.o' failed
| make: *** [echo_test.o] Error 1
| WARNING: exit code 1 from a shell command.

You will need to enable RPMsg in Linux kernel as this example uses RPMsg in kernel space implementation


feat: add option to override schema

@ChintanpatelTH  Thanks for the PR.
Could you dive into your usecase a bit more. I could kinda tease it out from the PR that you want to provide a schema file manually that has your schema for the files you're going to pull. What is the file type you're having issues with? Would a better sampling strategy do the trick better/easier for you?


website is not responsive in all devices

when the website is opnened in mobiles or tabs other than laptops it looks weird with no proper allignment i can make it responsive plz assign hacktoberfest and gssoc extended labels and also add level 3

Plz assign level
On Sat, 5 Oct, 2024, 9:38 pm github-actions[bot], @.***>
wrote:

Assigned #315 https://github.com/ANSHIKA-26/WordWise/issues/315 to
@keerthana2-005 https://github.com/keerthana2-005.
—
Reply to this email directly, view it on GitHub
https://github.com/ANSHIKA-26/WordWise/issues/315#event-14528330879, or
unsubscribe
https://github.com/notifications/unsubscribe-auth/BEQZONAJDK5NIEGBPLA7SILZ2AFGDAVCNFSM6AAAAABPNOXQOCVHI2DSMVQWIX3LMV45UABCJFZXG5LFIV3GK3TUJZXXI2LGNFRWC5DJN5XDWMJUGUZDQMZTGA4DOOI
.
You are receiving this because you were assigned.Message ID:
@.***>

Share a video of resizing how it is not responsive

@hiteashgupta1

this is how it looks like in mobile

Firstly you have to add slider feature to these photos
And then work on responsiveness
But make sure it doesn't affect alignment of images

issue #257 exists , ask to be assigned on that


[Can you provide the environment for python=3.9.18？]

Motivation
When I was researching the torchquantum framework, I found that it is based on python 3.7 ~ pthon 3.9, but I only have a working environment version of python 3.11 for rl4co that you provided earlier. I want to solve the CO problem with the quantum transformer module under the torchquantum framework.
Solution
If you have a previous version of Python 3.9 that can run RL4CO, could you please provide us with python=? RL4CO=? pyTorch=? What is the version number of Torch Geometric=?? Thank you.

Hi there! We should be pretty flexible, so you may try installing RL4CO inside your python environment and should work out of the box without restrictions on specific versions

Okay, I'll try it, thanks

Closing now as it should be resolved. Feel free to re-open or file a new issue if something is still not working!


Plugin sets laststatus=2

Hello,
for some reason, the plugin sets laststatus to 2 every time a csv buffer is focused. Why is it like that? Could we have an option to disable that?

It's the behavior of the original rainbow_csv plugin. The statusline becomes a reference for shorthand column names when writing RBQL queries using :Select, :Update, or :RbSelect.
It looks like this when active:

I understand that setting statusline=2 might be disruptive. If you don't mind losing the feature above, I just added g:disable_rainbow_statusline in a520dab to disable it.

Thanks!


DO NOT APPROVE, security testing.  xiqvbg

DO NOT APPROVE, security testing.  xiqvbg

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.


ENH: Add MRIQC's custom multiproc runner that allows passing the pool

This is useful to minimize the workers' fingerprint.

Is there a reason not to contribute this upstream to nipype?

None - just my laziness and reducing the maintenance effort of nipype.
There's a quasi-reason in the sense that I had the plan to write a plugin based on asyncio and test it with MRIQC, and this was like the first tiny test of a drop-in plugin implementation.
Can we merge this in here to speed up the deployment of sdcflows (which uses this, so we can test), and at the same time I'll send a PR to nipype?


update dependency for newer libdisplay-info possibe?

I haven't been able to update libdisplay-info for 2-3 weeks.
Is it possible wlroots-nvidia's dependency can be updated ?
error: failed to prepare transaction (could not satisfy dependencies)
:: installing libdisplay-info (0.2.0-1) breaks dependency 'libdisplay-info.so=1-64' required by wlroots-nvidia

Hello,
Unfortunately, this fork is unmaintained (I forgot about its existence).
You might find some useful information here:
https://aur.archlinux.org/packages/wlroots-nvidia


Allow tests to skip dumping resources on failure

This is useful for GitHub Actions that has it's own
method of diagnostics
/assign @kvmware

/lgtm


13 New Languages added

ASP, Swift, Objective C, Modula3, Oracle, QWERTY, XBasic, Arduino, LiveScript, JScript, BuddyScript, VB.net, XHTML these languages have been added.

Just removed few languages which we had. Otherwise, your contributions are monumental. Thank you. We are merging this.
PS: Sorry for the extremely late response.


feat: Add preview presentation Page

closes #78

This pr also includes the latest credentailRequest -> credentialRequestOpts change for both ios and android plugins
Moving the pages to view folder
Add presentation page

Signed-off-by: Talwinder kaur<EMAIL_ADDRESS>

Codecov Report
Base: 88.83% // Head: 88.83% // No change to project coverage :thumbsup:

Coverage data is based on head (e6014e6) compared to base (6bd9f4d).
 Consider uploading reports for the commit fa16d92 to get more accurate results

Additional details and impacted files
@@           Coverage Diff           @@
##             main      #84   +/-   ##
=======================================
  Coverage   88.83%   88.83%
=======================================
  Files          21       21
  Lines         609      609
=======================================
  Hits          541      541
  Misses         38       38
  Partials       30       30

Impacted Files
Coverage Δ

cmd/wallet-sdk-gomobile/openid4ci/openid4ci.go
81.81% <ø> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.


Unable to retrieve upload information for destination server

jamfcpr 2.0.0. returns "Unable to retrieve upload information for destination server" regardless of options set uploading from local SMB:8443 to Jamf CDP.
jamfcpr 1.0.2 with same configuration and user account uploads successfully.

What version of Jamf Pro is the destination server.  Anything interesting in the log (~/Library/Logs/jamfcpr/...)?

From 10.15.7 device inside the JLL network.
From: Leslie Helou @.>
Date: Friday, May 21, 2021 at 6:34 AM
To: BIG-RAT/jamfcpr @.>
Cc: Curtner, Pete @.>, Author @.>
Subject: [EXTERNAL] Re: [BIG-RAT/jamfcpr] Unable to retrieve upload information for destination server (#6)
What version of Jamf Pro is the destination server. Anything interesting in the log (~/Library/Logs/jamfcpr/...)?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHubhttps://nam02.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2FBIG-RAT%2Fjamfcpr%2Fissues%2F6%23issuecomment-845887343&data=04|01|pete.curtner%40am.jll.com|08d53afb1b904bea7b0508d91c4c5357|bfef2b06d2564f8ebd038d3687987063|0|0|637571936413237875|Unknown|TWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D|1000&sdata=6CrZRmEss1P2OH6efW70wCr5BMjJrzF3cSnST3%2BGgQQ%3D&reserved=0, or unsubscribehttps://nam02.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FATS6VUL4XPA7Q6VS3CBOT6LTOZAKLANCNFSM45HXPIYQ&data=04|01|pete.curtner%40am.jll.com|08d53afb1b904bea7b0508d91c4c5357|bfef2b06d2564f8ebd038d3687987063|0|0|637571936413247829|Unknown|TWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D|1000&sdata=q9lPVaPXJjUIpas31c5lmwv870lMG5oqjClZ6nI5VjQ%3D&reserved=0.
One of the 2021 World’s Most Ethical Companies® http://www.jll.com/WME2021
Jones Lang LaSalle
For more information about how JLL processes your personal data, please click here http://www.jll.com/privacy-statement.
This email is for the use of the intended recipient(s) only. If you have received this email in error, please notify the sender immediately and then delete it. If you are not the intended recipient, you must not keep, use, disclose, copy or distribute this email without the author's prior permission. We have taken precautions to minimize the risk of transmitting software viruses, but we advise you to carry out your own virus checks on any attachment to this message. We cannot accept liability for any loss or damage caused by software viruses. The information contained in this communication may be confidential and may be subject to the attorney-client privilege. If you are the intended recipient and you do not wish to receive similar electronic messages from us in the future then please respond to the sender to this effect.


Fix the documentation

Some documentation left from the old function parameters
https://github.com/indyfree/CARLA/blob/406d5f03a16edb8c03d90ba926f5a7b583fe4603/carla/recourse_methods/catalog/dice/model.py#L46

For an issue like this is it better to push a fix myself on main?

For an issue like this is it better to push a fix myself on main?

I have an open PR for a dice fix, I'll add it there

Fixed in PR #30
You could also put such bugs into the PR


Issue #104 fixed, now properly generating getter/setter names for boolean fields that start with a prefix

Issue #104 fixed, now properly generating getter/setter names for boolean fields that start with a prefix followed by "is".

Coverage increased (+0.008%) to 94.064% when pulling 07cc9cad6aab71836cec0956c59bab7f2959ce8b on bangoker:master into 8f09082a3936b3463f87dbbd524758edf6fb8851 on oshoukry:master.


Log statements don't have different colors

Environment:

Swift 5
Xcode 11.3.1

Problem:
I implement the logger using the various levels of severity however all the log statements in the console are still white. I have tried changing themes and yet I still cannot have TRACE, DEBUG, INFO, WARNING, or ERROR to appear in the console with the proper colors.
Example Logger Setup:
    // MARK: Logging

    private lazy var log = Logger(formatter: .default, theme: .tomorrowNightEighties, minLevel: .trace)

Example Console Output:

@adamscout162  you need to install https://github.com/robbiehanson/XcodeColors as stated in the description of Log


ARROW-12477: [Release] Download aarch64 miniforge

Travis CI is green https://travis-ci.org/github/cyb70289/arrow/builds/767705246

Thanks @cyb70289 for this PR! Have you managed to successfully verify the release on arm64?

Thanks @cyb70289 for this PR! Have you managed to successfully verify the release on arm64?

Yes. I verified C++ and Python on Ubuntu-18.04 AArch64. It works correctly.


Unexpected EOF when uploading firmware.bin

Cannot get Platform.io to upload to M5Stack Core2
Using "Hello world" sketch
Upload works fine via Arduino IDE
Cannot get past the unexpected EOF when using platform.io
Advanced Memory Usage is available via "PlatformIO Home > Project Inspect"
RAM:   [          ]   0.4% (used 17352 bytes from 4521984 bytes)
Flash: [=         ]   6.7% (used 438907 bytes from 6553600 bytes)
Building .pio/build/m5stack-core2/firmware.bin
esptool.py v3.1
Merged 1 ELF section
Configuring upload protocol...
AVAILABLE: esp-prog, espota, esptool, iot-bus-jtag, jlink, minimodule, olimex-arm-usb-ocd, olimex-arm-usb-ocd-h, olimex-arm-usb-tiny-h, olimex-jtag-tiny, tumpa
CURRENT: upload_protocol = esptool
Looking for upload port...
Use manually specified:
/dev/tty.wchusbserial53810043471
Uploading .pio/build/m5stack-core2/firmware.bin
sh: -c: line 0: unexpected EOF while looking for matching `"'
sh: -c: line 1: syntax error: unexpected end of file
*** [upload] Error 2

I've been using platform.io and have had no problems, can you provide more details?