Cannot locate rosdep definition for example_interfaces (eloquent)

2020-12-28T01:55:33.4109429Z ##[group]Run sed -e 's/^\(ROS_DISTRO=.*\)/#\1\nROS_DISTRO=eloquent/g' -i tutorial.sh
2020-12-28T01:55:33.4110399Z sed -e 's/^\(ROS_DISTRO=.*\)/#\1\nROS_DISTRO=eloquent/g' -i tutorial.sh
2020-12-28T01:55:33.4111140Z sed -e 's/^\(source \/opt.*bash\)$/\1\nrosdep install -r -y -i --from-paths ./g' -i tutorial.sh
2020-12-28T01:55:33.4111772Z bash <(head -n -2 ./tutorial.sh)
2020-12-28T01:55:33.4156440Z shell: /bin/bash -e {0}
2020-12-28T01:55:33.4156895Z ##[endgroup]
2020-12-28T01:55:33.4301261Z Cloning into 'src/examples'...
2020-12-28T01:55:34.4985435Z ERROR: the following packages/stacks could not have their rosdep keys resolved
2020-12-28T01:55:34.4986504Z to system dependencies:
2020-12-28T01:55:34.4987406Z examples_rclcpp_minimal_client: Cannot locate rosdep definition for [example_interfaces]
2020-12-28T01:55:34.4988471Z examples_rclpy_minimal_service: Cannot locate rosdep definition for [example_interfaces]
2020-12-28T01:55:34.4990007Z examples_rclcpp_minimal_action_client: Cannot locate rosdep definition for [example_interfaces]
2020-12-28T01:55:34.4991354Z examples_rclpy_minimal_client: Cannot locate rosdep definition for [example_interfaces]
2020-12-28T01:55:34.4992525Z examples_rclcpp_minimal_service: Cannot locate rosdep definition for [example_interfaces]
2020-12-28T01:55:34.4993725Z examples_rclpy_minimal_action_client: Cannot locate rosdep definition for [example_interfaces]
2020-12-28T01:55:34.4994924Z examples_rclpy_minimal_action_server: Cannot locate rosdep definition for [example_interfaces]
2020-12-28T01:55:34.4996171Z examples_rclcpp_minimal_action_server: Cannot locate rosdep definition for [example_interfaces]
2020-12-28T01:55:34.5056629Z Continuing to install resolvable dependencies...
2020-12-28T01:55:34.5057958Z #All required rosdeps installed successfully
2020-12-28T01:55:35.2903228Z Starting >>> examples_rclcpp_minimal_action_client
2020-12-28T01:55:37.5569477Z --- stderr: examples_rclcpp_minimal_action_client
2020-12-28T01:55:37.5570964Z CMake Error at CMakeLists.txt:14 (find_package):
2020-12-28T01:55:37.5572097Z   By not providing "Findexample_interfaces.cmake" in CMAKE_MODULE_PATH this
2020-12-28T01:55:37.5573076Z   project has asked CMake to find a package configuration file provided by
2020-12-28T01:55:37.5573921Z   "example_interfaces", but CMake did not find one.
2020-12-28T01:55:37.5574335Z
2020-12-28T01:55:37.5574948Z   Could not find a package configuration file provided by
2020-12-28T01:55:37.5575656Z   "example_interfaces" with any of the following names:
2020-12-28T01:55:37.5576047Z
2020-12-28T01:55:37.5576533Z     example_interfacesConfig.cmake
2020-12-28T01:55:37.5577642Z     example_interfaces-config.cmake
2020-12-28T01:55:37.5578060Z
2020-12-28T01:55:37.5578626Z   Add the installation prefix of "example_interfaces" to CMAKE_PREFIX_PATH or
2020-12-28T01:55:37.5579472Z   set "example_interfaces_DIR" to a directory containing one of the above
2020-12-28T01:55:37.5580331Z   files.  If "example_interfaces" provides a separate development package or
2020-12-28T01:55:37.5581052Z   SDK, be sure it has been installed.
2020-12-28T01:55:37.5581376Z
2020-12-28T01:55:37.5581569Z
2020-12-28T01:55:37.5581983Z ---
2020-12-28T01:55:37.5582523Z Failed   <<< examples_rclcpp_minimal_action_client [2.27s, exited with code 1]
2020-12-28T01:55:37.5889737Z
2020-12-28T01:55:37.5890849Z Summary: 0 packages finished [2.62s]
2020-12-28T01:55:37.5891560Z   1 package failed: examples_rclcpp_minimal_action_client
2020-12-28T01:55:37.5892335Z   1 package had stderr output: examples_rclcpp_minimal_action_client
2020-12-28T01:55:37.5892971Z   15 packages not processed
2020-12-28T01:55:37.6365226Z ##[error]Process completed with exit code 1.

Full log: 1_eloquent-ros-base-main.txt

Eloquent has been EOL.
https://index.ros.org/doc/ros2/Releases/
There are no update on rosdep for eloquent.
ubuntu@03ff695f54d9:~/ros2_example_ws/src/examples [eloquent]
$ rosdep update
reading in sources list data from /etc/ros/rosdep/sources.list.d
Hit https://raw.githubusercontent.com/ros/rosdistro/master/rosdep/osx-homebrew.yaml
Hit https://raw.githubusercontent.com/ros/rosdistro/master/rosdep/base.yaml
Hit https://raw.githubusercontent.com/ros/rosdistro/master/rosdep/python.yaml
Hit https://raw.githubusercontent.com/ros/rosdistro/master/rosdep/ruby.yaml
Hit https://raw.githubusercontent.com/ros/rosdistro/master/releases/fuerte.yaml
Query rosdistro index https://raw.githubusercontent.com/ros/rosdistro/master/index-v4.yaml
Skip end-of-life distro "ardent"
Skip end-of-life distro "bouncy"
Skip end-of-life distro "crystal"
Add distro "dashing"
Skip end-of-life distro "eloquent"
Add distro "foxy"
Skip end-of-life distro "groovy"
Skip end-of-life distro "hydro"
Skip end-of-life distro "indigo"
Skip end-of-life distro "jade"
Add distro "kinetic"
Skip end-of-life distro "lunar"
Add distro "melodic"
Add distro "noetic"
Add distro "rolling"
updated cache in /home/ubuntu/.ros/rosdep/sources.cache

Eloquent has been EOL.
https://index.ros.org/doc/ros2/Releases/
There are no update on rosdep for eloquent.
ubuntu@03ff695f54d9:~/ros2_example_ws/src/examples [eloquent]
$ rosdep update
reading in sources list data from /etc/ros/rosdep/sources.list.d
Hit https://raw.githubusercontent.com/ros/rosdistro/master/rosdep/osx-homebrew.yaml
Hit https://raw.githubusercontent.com/ros/rosdistro/master/rosdep/base.yaml
Hit https://raw.githubusercontent.com/ros/rosdistro/master/rosdep/python.yaml
Hit https://raw.githubusercontent.com/ros/rosdistro/master/rosdep/ruby.yaml
Hit https://raw.githubusercontent.com/ros/rosdistro/master/releases/fuerte.yaml
Query rosdistro index https://raw.githubusercontent.com/ros/rosdistro/master/index-v4.yaml
Skip end-of-life distro "ardent"
Skip end-of-life distro "bouncy"
Skip end-of-life distro "crystal"
Add distro "dashing"
Skip end-of-life distro "eloquent"
Add distro "foxy"
Skip end-of-life distro "groovy"
Skip end-of-life distro "hydro"
Skip end-of-life distro "indigo"
Skip end-of-life distro "jade"
Add distro "kinetic"
Skip end-of-life distro "lunar"
Add distro "melodic"
Add distro "noetic"
Add distro "rolling"
updated cache in /home/ubuntu/.ros/rosdep/sources.cache


Hospital Department concept for an Encounter

Is there a concept of a department for an Encounter? I see that there's an EncounterClass but I'm looking for values like "Cardiology", "Anaesthetics", "Gastroenterology" etc.

We haven't modeled individual specialists [yet?].
One approach, which you hint at, could be to add an optional "specialty" attribute on Encounter.
If that was done, all the modules would need to be reviewed and updated as appropriate to account for that information. The exporters would also need to be updated to export that data appropriately in the various supported formats.

Yeah makes sense. A bit of background why we want this is that a basic use case for us is
A researcher wants to search for observations that happened in a particular department, e.g Cardiology.

Makes perfect sense. I'm not sure where this fits into my priorities, but I'd be happy to consider a pull request on the topic.

Great, we'll try and put something together.


Find 2.0 fusion

This adds core fusion functionality to find 2.0. Currently only Convolution+activation fusions are implemented, but the rest are easy to add in separate PRs.
Current progress:

development done
test added to validate correctness

Removal of some code with duplicated functionality is not done in this PR, so removed lines are relatively low. In future it is possible to replace most of fusion internals with simple find 2.0 calls as they map extremely well.
The test is basically a copy of another fusion test with calls replaced to find 2.0 versions.

@DrizztDoUrden
/var/jenkins/workspace/Libs_MIOpen_ddu_find2_fused_find/src/problem.cpp:416:29: error: no viable conversion from 'const miopen::Problem' to 'ProblemContainer'

        solution.SetProblem(*this);

                            ^~~~~

@DrizztDoUrden Please fix, update from recent develop and let me know: I'll run performance tests.

@DrizztDoUrden Should I begin testing?

Yes, I think it should pass now, you can try.

@JehandadKhan ping

Ping @JehandadKhan


Add search keyword endpoint

Adding this endpoint will enable work on removing current UI views in favor of UI application consuming REST API. All functionalities of current UI views are available through REST API.

Codecov Report

Merging #14 into master will increase coverage by 0.12%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master      #14      +/-   ##
==========================================
+ Coverage   95.94%   96.07%   +0.12%
==========================================
  Files          38       38
  Lines         765      790      +25
==========================================
+ Hits          734      759      +25
  Misses         31       31

Impacted Files
Coverage Δ

rfhub2/api/endpoints/keywords.py
100% <100%> (ø)
:arrow_up:

rfhub2/tests/api/endpoints/keywords_tests.py
100% <100%> (ø)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 29d858c...a8809ab. Read the comment docs.


use pipenv for development dependencies and running tests

e.g. see Pipfile and Makefile in https://github.com/requests/requests

https://chriswarrick.com/blog/2018/07/17/pipenv-promises-a-lot-delivers-very-little/
virtualenvwrapper and pip-tools may be a better approach

Re. Sphinx, how about keeping extras in requirements-extra.txt instead of setup.py?  read docs must support it, e.g. trio does this.

I'm trying out pip-tools this morning. I like it, but its author recommends Pipenv instead:

Note: While the principles outlined in this blog post still very much apply, your tool of choice these days should be Pipenv.

But PyPA still recommends pip-tools as an alternative to Pipenv:

If you find this particular approach to managing application dependencies isn’t working well for you or your use case, you may want to explore … pip-tools to build your own custom workflow from lower level pieces like pip-compile and pip-sync

Anyway… I have a working setup that I will commit in a few minutes.

Closed via #78.


Granular Resolution

Hi,
I have a csv ~1000x1000 cells that I would like to transform. With the code I am running now it accepts image files. So i convert my csv into an image first and then into the CV.imread...:
src = cv.imread(cv.samples.findFile(filename), cv.IMREAD_COLOR)
kernel = np.ones((10,10),np.float32)/100
dst = cv.filter2D(src,-1,kernel)
src_gray = cv.cvtColor(dst, cv.COLOR_BGR2GRAY)  # converts to grayscale

then I do the transforms.
Can I transform the data directly from a csv?
The data is from a plasma jet projection taken by an interferometer, so I use the inverse transform to recreate the profile. The first plot is the raw data in PNG form which is granular. The second plot is the inverse transform. The third plot is the forward transform performed on the second plot.
Thanks for the help.
Cameron

You can load a csv directly into a numpy array. There are a few ways to do it, but I like using
data = np.loadtxt(‘file.csv’, delimiter=‘,’)
see if that works for you.

I'm closing this. Feel free to reopen if further discussion is needed.


Add successful proposal submission

Please update the tests/README.md to check the test which is now done
btw, still not done: Re-applying a proposal that has already passed : make sure the contract rejects the submission of a proposal that has expired in the past
Otherwise LGTM


Changing muting algorithm to throttle first before muting

NOTE: In theory, this PR should help with #2980 (and possibly even resolve it). I've only done some limited testing and everything seems to work correctly (i.e. no deadlocks) but more extensive testing is required to confirm that I didn't miss something. Additionally, I did not run any performance tests so it would be ideal if someone is able to double check performance.

Prior to this commit, the muting algorithm would mute actors as soon
as they sent a message to a muted/overloaded/under pressure actor.
This would result in not ideal behavior in the case of fan in actor
topologies.
This commit changes the algorithm to throttle the sending actor based
on the number of messages sent to a muted/overloaded/under pressure
actor eventually leading to muting the sending actor after a
sufficient number of messages have been sent. The throttling is
implemented as a temporary reduction of the batch size. Additionally,
actors that are overloaded or under pressure have their batch size
temporarily doubled to allow them to hopefully catch up quicker.
This allows for a more gradual muting process across an actor
topology resulting in better behavior for fan in type scenarios.
The changes include:

adding logic to mute only if the throttled batch size == 0
adding logic to throttle batch size based on # of messages sent
to muted/overloaded/under pressure actors (stored in two variables:
extra_throttled_msgs_sent and mute_map_count)
adding logic to double batch size for overloaded/under pressure
actors
changing how an overloaded actor gets marked as not overloaded
to ensure that only occurs if the actor processes less than the
default batch size
renaming muting related functions to throttling there appropriate
changing atomic operations to be a single add/sub since actors
can now be in multiple mute maps

This PR also includes minor muting/overload related cleanups and bug fixes

Change actor->muted to be size_t
Reorganize some muting/overload related checks/actions into
functions (maybe_mute and batch_limit_reached)
Use the new functions for both normal message processing
and continuations (these checks were missing prior to this commit)
Change ponyint_actor_run signature to have a boolean if it is
being run in polling mode or not and remove batch size. Batch size
is now set from a constant at the top of the function.
Change logic related to how overload is set to ensure it is not
set when polling to avoid overload/mute getting set unnecessarily
due to polling using batch size == 1 (previously; now, batch
size is always the default).

TODO/OPEN ITEM: pony_poll can currently result in a muted actor
getting run via ponyint_actor_run when it shouldn't be. Resolving
this might require public API changes.

I've added a commit with the following enhancement:
Add new `--ponymsgstilmute` argument to control throttling/muting

This commit add a new command line argument to control the speed of
throttling/muting called `--ponymsgstilmute`. This option is
specifically added for power users who want to have more control
over how the runtime handles backpressure. Using a value of `1`
for `--ponymsgstilmute` will result in actors getting muted after
sending a single message to a muted/overloaded/under pressure
actor and be functionally equivalent to the previous backpressure
implementation that did not employ gradual throttling.

This commit also includes some code cleanup and a minor bugfix. The
code cleanup takes the formula for determining the throttled batch
and puts it in a static function (which I'm assuming will get
inlined) to avoid potential inconsistencies between the different
places it is used. The minor bugfix is to increment
`extra_throttled_msgs_sent` in `ponyint_maybe_throttle` as the
comment indicated should be happening (instead of
`mute_map_count`).

There's a path forward for this PR, I'll handle shepherding all of the tests and review.

Just added a new commit to help with performance (some very unreliable performance numbers below):
Switch to a single atomic bitfield for mute/throttle bookkeeping

Prior to this commit, the updated muting/throttling logic relied
on three different atomic variables to keep track of all the state
needed for throttling and muting. This resulted in unnecessary
contention across different threads due to the multiple atomic
operations required.

This commit changes things to store the three pieces of information
(`is_muted`, `mute_map_count`, and `extra_throttled_msgs_sent`) in
a single `uint64_t` bitfield (for the current implementation and
constraints it is possible to fit everything into a single `uint32_t`
bitfield if desired). This adds a bit of complexity to the atomic
operations (we have to use compare and exchange now instead of
simpler fetch add/sub) but it ensure we only have to have a single
atomic operation for all the bookkeeping. This also results in
keeping track of `is_muted` status simpler because it removes a
race condition between the `is_muted` and the other bookkeeping
variables used to determine `batch_size` due to all of them now
being stored in a single variable.

This commit also moves the atomic fields in `pony_actor_t` to
separate cache line because they are accessed by other actors and
scheduler threads along with the other items accessed by other
actors.

I ran examples/overload to gauge performance. Unfortunately, I'm running in a linux VM with any sort of process isolation, on an OS where I have no control over processor frequency scaling so these number are very unreliable but seem to give a general indication of things.
master:
vagrant@ubuntu-bionic:~/dhp$ ./examples/overload/overload
Starting 10000 senders.
Single receiver started.
50000000 messages received in<PHONE_NUMBER>2 nanos.
100000000 messages received in<PHONE_NUMBER>5 nanos.
150000000 messages received in<PHONE_NUMBER>1 nanos.
200000000 messages received in<PHONE_NUMBER>6 nanos.
250000000 messages received in<PHONE_NUMBER>0 nanos.

before bitfield/atomics change but with all throttling logic:
vagrant@ubuntu-bionic:~/dhp$ ./examples/overload/overload --ponymsgstilmute=1
Starting 10000 senders.
Single receiver started.
50000000 messages received in<PHONE_NUMBER>7 nanos.
100000000 messages received in<PHONE_NUMBER>1 nanos.
150000000 messages received in<PHONE_NUMBER>7 nanos.
200000000 messages received in<PHONE_NUMBER>6 nanos.
250000000 messages received in<PHONE_NUMBER>0 nanos.

vagrant@ubuntu-bionic:~/dhp$ ./examples/overload/overload
Starting 10000 senders.
Single receiver started.
50000000 messages received in<PHONE_NUMBER>6 nanos.
100000000 messages received in<PHONE_NUMBER>7 nanos.
150000000 messages received in<PHONE_NUMBER>2 nanos.
200000000 messages received in<PHONE_NUMBER>8 nanos.
250000000 messages received in<PHONE_NUMBER>9 nanos.

vagrant@ubuntu-bionic:~/dhp$ ./examples/overload/overload --ponymsgstilmute=100
Starting 10000 senders.
Single receiver started.
50000000 messages received in<PHONE_NUMBER>1 nanos.
100000000 messages received in<PHONE_NUMBER>1 nanos.
150000000 messages received in<PHONE_NUMBER>7 nanos.
200000000 messages received in<PHONE_NUMBER>2 nanos.
250000000 messages received in<PHONE_NUMBER>9 nanos.

after bitfield/atomics change:
vagrant@ubuntu-bionic:~/dhp$ ./examples/overload/overload --ponymsgstilmute=1
Starting 10000 senders.
Single receiver started.
50000000 messages received in<PHONE_NUMBER>5 nanos.
100000000 messages received in<PHONE_NUMBER>8 nanos.
150000000 messages received in<PHONE_NUMBER>4 nanos.
200000000 messages received in<PHONE_NUMBER>4 nanos.
250000000 messages received in<PHONE_NUMBER>9 nanos.

vagrant@ubuntu-bionic:~/dhp$ ./examples/overload/overload
Starting 10000 senders.
Single receiver started.
50000000 messages received in<PHONE_NUMBER>4 nanos.
100000000 messages received in<PHONE_NUMBER>2 nanos.
150000000 messages received in<PHONE_NUMBER>2 nanos.
200000000 messages received in<PHONE_NUMBER>7 nanos.
250000000 messages received in<PHONE_NUMBER>6 nanos.

vagrant@ubuntu-bionic:~/dhp$ ./examples/overload/overload --ponymsgstilmute=100
Starting 10000 senders.
Single receiver started.
50000000 messages received in<PHONE_NUMBER>2 nanos.
100000000 messages received in<PHONE_NUMBER>3 nanos.
150000000 messages received in<PHONE_NUMBER>7 nanos.
200000000 messages received in<PHONE_NUMBER>8 nanos.
250000000 messages received in<PHONE_NUMBER>4 nanos.

Rebased onto current master to fix merge conflict.

This is waiting for @slfritchie to test and verify it solves the problem.

Did you intend to close this @dipinhora?
On Sun, May 19, 2019, 15:09 Dipin Hora<EMAIL_ADDRESS>wrote:

Closed #3009 https://github.com/ponylang/ponyc/pull/3009.
—
You are receiving this because your review was requested.
Reply to this email directly, view it on GitHub
https://github.com/ponylang/ponyc/pull/3009?email_source=notifications&email_token=AABPIPBOSVPAZHPHWZAXR4TPWGXYXA5CNFSM4GX3KT2KYY3PNVWWK3TUL52HS4DFWZEXG43VMVCXMZLOORHG65DJMZUWGYLUNFXW5KTDN5WW2ZLOORPWSZGORQVMASA#event-2351611976,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AABPIPHDSVOBKJBWG3ZWKGLPWGXYXANCNFSM4GX3KT2A
.

@SeanTAllen yes, it doesn't work correctly. Might get reopened or a new one created at some point in the future if I figure out the issue and how to fix it.

What was the test you used to determine it didn't work? I'd love to know as
it might help others if they wanted to tackle in the future.
On Mon, May 20, 2019, 01:47 Dipin Hora<EMAIL_ADDRESS>wrote:

@SeanTAllen https://github.com/SeanTAllen yes, it doesn't work
correctly. Might get reopened or a new one created at some point in the
future if I figure out the issue and how to fix it.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/ponylang/ponyc/pull/3009?email_source=notifications&email_token=AABPIPEIRLYJKS2DNYW345TPWJCPLA5CNFSM4GX3KT2KYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODVX3ARA#issuecomment-493858884,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AABPIPGNKT5PRVSRBO7VS2LPWJCPLANCNFSM4GX3KT2A
.

I created a fan-in example application to roughly mimic the scenario that Scott described in the issue. The solution in this PR results in runaway memory growth when --ponymsgstilmute >= 3 that I haven't been able to track down.
Given that it's unlikely that I will find the root cause or a solution to the runaway memory growth in the near future, it seemed better to close this PR rather than leave it open.


Why can't plotter write to a shared network drive/folder?

I get error using shared network drive as final dir.
Plotter is Ubuntu and writing to another Ubuntu shared drive (smb://IPAddress/folder) as final dir.
Plotter says cannot write to drive. I can write. I can copy/paste anything to the shared folder.

Did you try to mount your  smb share and use the mounted drive as your destination?
sudo mount -t cifs //<ip_address>/<export_share> /mnt/<local_share>

Did you try to mount your smb share and use the mounted drive as your destination?
sudo mount -t cifs //<ip_address>/<export_share> /mnt/<local_share>

Ohh how odd. Still need to be mounted huh? Why can't it be like windows and mac, sigh.
I will try.

I'm writing ok from one Ubuntu to another. You can see if the remote drive is mounted by running 'df'. I have had to first (one-time thing) chown [username] /mnt/samba_dir (for example) on the plotting machine to be able to write to the remote samba share.


Parameter highlight group doesn't capture references in body

I use a highlighting color for parameters to help with readability. Rust and many other languages will highlight the parameter inside the parentheses the same color as when it is referenced in the body of the function. This doesn't seem to work with Python. Maybe you know of a quick fix to this issue since you've written the code and know how it all works. I thought it would be worth asking as some people might find this useful. Thank you for your time and work you've put in on this. I know people in open source don't hear that enough.

Locals can accomplish this, but you're likely looking for semantic highlighting anyways which an LSP provides

pyright doesn't provide semantic tokens

who knows, it's closed source, you could use semshi


fix(orchestrator): fix dynamodb client definition

@Sc0ra we could open an issue on dyn db toolbox and link back to here to keep track


How can I get a video frame?

I tried using while world_state.number_of_video_frames_since_last_state < 1  waiting for frame, but after 40s it's still nothing. I can easily get other variables like world_state.observations, but not for video_frame,it's always empty. Is there anything special that I need to do before I try to get video_frame? Maybe like start recording video or something?  I'm new to this and it stuck me for days.
Thank you

The mission XML needs to include a  element in the / . One example would be the render_speed_test.py in Malmo/samples/Python_examples.


[Vulnerabilites]Add IVulnerabilityWriter

Update the Github Vulnerability interaction library to support IVulnerabilityWriters for writing vulnerabilities.
This is in preparation for use by the new v3 vulnerability resource updater.
Spec for Vulnerabilities in V3: https://github.com/NuGet/Engineering/pull/4940

Could you please add link to tracking issue and spec in description? And give little more description of exactly what part of spec being implemented here.

I have included a link the Spec for Vulnerabilities in V3 to the description.
This is a prerequisite change to the existing code to enable a different write target for the vulnerabilities (this library was previously part of another job that was extracted in https://github.com/NuGet/NuGetGallery/pull/9657

Thanks for addressing the feedback! I suggest throwing NotImplementedException() for unused implementations.


#71 Add Avro exception handling to spring messaging

:tada: This PR is included in version 4.3.16 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


can't find builder method for PurchaseRequest

I have this class similar to this:

import org.mashad.jbsbe.annotation.Iso8583;
import org.mashad.jbsbe.annotation.IsoField;

import lombok.Builder;

@Iso8583(type=0x200)
@Builder
public class PurchaseRequest {
	@IsoField(index=10)
	public Date date;
	@IsoField(index=4)
	public Long amount;
	@IsoField(index=11)
	public Integer stan;
	@IsoField(index=35)
	public String cardNumber;
}

from which taken from your UnitTest.
However, when i'm trying access the builder, like in your example,
PurchaseRequest purchaseRequest = PurchaseRequest.builder()
i couldn't use the .builder() method as its not available (no content assist, manual type resulted in compile error.
Tried to remove the @Builder like in your readme file also is not working.

@Builder is lombok annotation, so you need the lombok jar. look at: https://projectlombok.org/ for how it works. Remember that you have to install its plugin on the IDE you use, it is all described in the link.


Evidence slashing

This PR adds an endpoint which allows someone to submit a batch, valset, or logic call, (the "subject") and the signature of a validator.
It checks the subject's checkpoint against a stored set of all past checkpoints, and if it cannot find the checkpoint, the validator who made the signature is slashed. This is intended to deter validators from signing fake batches, valsets, or logic calls, for example if they wanted to steal money from the bridge with a fake transaction.

This feature has been specified multiple times

Those aren't specifications, but audit findings and an issue. I'm talking about implementation specifications and architecture decision records. See the SDK ADRs and the module specification.
As I said, this PR is increasing technical debt in its current state and not specified, which will lead us to more calls to know the rationale of the decisions behind this implementation instead of documenting/spec'ing it from the beginning.

Delaying this feature in order to make micro-optimizations, is IMO not worth it.

You can ignore my review and merge this PR if you want, but it will not have my approval nor my blessing to be eventually integrated into the Hub

@jtremback do you want to collab on an ADR? I will add the template to this repo shortly


API job failed with error "Could not set platform of the test run"

Set up zebrunner from develop branch, ZEBRUNNER_VERSION=develop
Steps:

Setup zebrunner
Run API demo test via Jenkins
Actual result: API job failed with error "Could not set platform of the test run"
Expected result: API job passed without errors

Verified on develop branch with carina core version 7.3.15, fixed


'metrics' might not be present in params

Usually I fit my models without any metrics. So params['metrics'] drops KeyError in my case.
Also some variables are using only under show_inner clause, but initialized in outer scope.

I also see that it might be pretty well fixed by #39


Add stream with custom notification settings from Personal settings > Notifications

At present, the Personal settings > Notifications menu lists the streams that have custom notifications assigned. However, there is currently no way to customize notifications for an additional stream from that menu. This can be annoying to the user, as they would have to navigate to the appropriate tab in the streams menu in order to add another stream to the custom notifications list.
In order to address this, we should make it possible to customize notifications for an additional stream directly from the Personal settings > Notifications menu.
To do so, we should add another row to the bottom. In this row:

The left cell should be a dropdown of all the streams the user is subscribed to that currently use default notification settings. The first (selected) cell should say: "Customize another stream" (wording may be adjusted later).
The rest of the row should have checkboxes matching default stream settings. Before a stream is selected, it should not be possible to edit these checkboxes.

Once a stream is selected from the dropdown, the checkboxes for it should be editable in the same way as for other streams. Another "Customize another stream" row should appear below.
Muted streams can be treated in the same way as other streams; implementing #19780 will make this work well.
CZO discussion thread

@zulipbot claim

@zulipbot claim


Clarification on blocking of unverified 3rd party apps.

The document states that

Starting in November 2020, end-users will no longer be able to grant consent to most newly registered multi-tenant apps without verified publishers. This will apply to apps that are registered after November 8th 2020, use OAuth2.0 to request permissions beyond basic sign-in and read user profile, and request consent from users in different tenants than the one the app is registered in. A warning will be displayed on the consent screen informing users that these apps are risky and are from unverified publishers.

Let us call the affected apps "unverified 3rd party apps" for the sake of brevity
However, our tests show that this behavior only applies if risk-based step-up consent is active (https://docs.microsoft.com/en-us/azure/active-directory/manage-apps/configure-user-consent?tabs=azure-portal#risk-based-step-up-consent)
Please clarify whether this is intended behavior and disallowing user consent for unverified 3rd party apps only takes place if risk-based step-up consent is active.
If so, please update the referenced document accordingly and add the information that unverified 3rd party apps are considered risky to the documentation of risk-based step-up consent.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: f83478f0-0faa-2e10-37f2-819ad2351445
Version Independent ID: 3ffd5b35-a3d7-5dca-dc8b-acec1d85ec3c
Content: Publisher verification overview - Microsoft identity platform
Content Source: articles/active-directory/develop/publisher-verification-overview.md
Service: active-directory
Sub-service: develop
GitHub Login: @rwike77
Microsoft Alias: ryanwi

@commakoerschgen
Thanks for your feedback! We will investigate and update as appropriate.

I've reached out to ask for confirmation around the intended behavior.

As you rightly said this behavior only applies if risk-based step-up consent is active, and risk-based step-up consent is enabled by default.
This document says, "If Microsoft detects a risky end-user consent request, the request will require a 'step-up' to admin consent instead. This capability is enabled by default, but it will only result in a behavior change when end-user consent is enabled."
If end user consent is disabled, in any case, the user will not be able to grant consent and admin consent will be required.
Can you please clarify your statement, "disallowing user consent for unverified 3rd party apps only takes place if risk-based step-up consent is active"?

Yes. My point is that the cited statement from https://docs.microsoft.com/en-us/azure/active-directory/develop/publisher-verification-overview is misleading because it says that "[...] end-users will no longer be able to grant consent to most newly registered multi-tenant apps without verified publishers. [...]". It does not clearly state that this is only the case if the feature "risk-based step-up consent" is activated.
So, judging from the documentation, it seems that

there is absolutely no way to allow end-user consent for newly registered multi-tenant apps without verified publishers and non-basic permissions, and
there is an independent feature "risk-based step-up consent" that classifies certain consents as risky, and one can choose whether to escalate to admin consent in these cases.

However, the actual situation is that

there is a feature called "risk-based step-up consent" that classifies certain consents as risky,
consents for newly registered multi-tenant apps without verified publishers and non-basic permissions are always risky (there may be other risky consents),
enabling "risk-based step-up consent" (or not disabling it, since it is enabled by default) has the effect that consents for newly registered multi-tenant apps (...) always require admin consent

My suggestions would be to

add 2. from above to the documentation for risk-based step-up consent
improve the statement cited in the issue by adding "if risk-based step-up consent is active" or "this behavior can be deactivated by disabling risk-based step-up consent"


Add custom Kudu deployment script

Context
Hopefully will lead to Azure recognising this app as a Rails app instead of a Node.js app.
deploy.sh is copied from the support app, autogenerated by Kudu.

This ended up being a dead end.


ListPayments: filter out non-succeeded payments, include payment status

Earlier versions of ListPayments only included completed payments. We
return to this behavior by ignore all other payments if the nonSucceeded
boolean is not set in the request

Fails existing integration tests:
    --- FAIL: TestLightningNetworkDaemon/hold_invoice_sender_persistence (22.03s)
        lnd_test.go:88: Failed: (hold invoice sender persistence): exited with error:
            *errors.errorString predicate not satisfied: payhash not found in response
            /home/travis/gopath/src/github.com/lightningnetwork/lnd/lntest/itest/lnd_test.go:13328 (0xd3ab63)
            	testHoldInvoicePersistence: t.Fatalf("predicate not satisfied: %v", err)
            /home/travis/gopath/src/github.com/lightningnetwork/lnd/lntest/itest/lnd_test.go:113 (0xced806)
            	(*harnessTest).RunTestCase: testCase.test(net, h)
            /home/travis/gopath/src/github.com/lightningnetwork/lnd/lntest/itest/lnd_test.go:13866 (0xd541f5)
            	TestLightningNetworkDaemon.func4: ht.RunTestCase(testCase, lndHarness)
            /home/travis/.gimme/versions/go1.12.6.linux.amd64/src/testing/testing.go:865 (0x4fbeb0)
            	tRunner: fn(t)
            /home/travis/.gimme/versions/go1.12.6.linux.amd64/src/runtime/asm_amd64.s:1337 (0x45e6d1)
            	goexit: BYTE	$0x90	// NOP


404 on deploy-with-ICP.md

The "here" link for IBM Cloud Private was not found.

Good catch, remove this link since it's probably better for the user to find the info on the official Cloud Private page.

Fixed in e500024122cb749a054ac283b19eeda383910ac3


Base release For Client and PM review

This is a pre-release / beta

Sweet !
El jue., 27 jun. 2019 a las 0:00, Maria Camila Gomez Restrepo (<
<EMAIL_ADDRESS>escribió:

Merged #42 https://github.com/rtsc8/hostal_donde_las_paisas/pull/42
into master.
—
You are receiving this because your review was requested.
Reply to this email directly, view it on GitHub
https://github.com/rtsc8/hostal_donde_las_paisas/pull/42?email_source=notifications&email_token=ABTNCXNE247T74HFAG7NHSDP4RCQPA5CNFSM4H3WZGPKYY3PNVWWK3TUL52HS4DFWZEXG43VMVCXMZLOORHG65DJMZUWGYLUNFXW5KTDN5WW2ZLOORPWSZGOSGON6MQ#event-2442977074,
or mute the thread
https://github.com/notifications/unsubscribe-auth/ABTNCXNY4JPKCK7WWUZSIYTP4RCQPANCNFSM4H3WZGPA
.


Fourway component should allow setting normalize and other options

player.fourway(200)
When moving sideways in fourway. It does not actually move 200px a second distance.
It moves 200px horizontally and 200px vertically.
In order to move 200px distance it should be.
200px * sqrt(2)/2 horizontally and vertically.
It is possibke to do it manually    with bind and change speed but I think it should be incorporated.

The underlying component Multiway allows this -- you can set the normalize option to true, and it will do as you suggest.  Just call it with the same keybindings that Fourway uses, and the additional options argument.
Fourway should provide a way to pass in the options more easily, so I'll edit the title of this issue accordingly.

ahh. I didnt see that. thanks for putting links.


[WIP]Auto plot gender by country

Now the plot will be updated everytime nikola build is run
fixes #4

@vivekiitkgp


Moving to newer version of ExDocs?

There is a newer version of ex_docs available and I believe there is only one breaking change from the version 0.7 used here (the changelog can be found here) so I wonder if we could bump the version of it?

Done: http://hexdocs.pm/ex_aws/0.4.16/

The link doesn't seem to work, it leads to the 404 page and there seems to be only 0.4.15 and 0.4.17 old-style versions on the hexdocs. It's either me being foolish and not understanding something or something went wrong there.

Ah sorry there was a bug in the 0.4.16 release so I pulled it right after
pushing. In any case all future releases are on the new doc UI
On Sunday, February 21, 2016, Michael<EMAIL_ADDRESS>wrote:

The link doesn't seem to work, it leads to the 404 page and there seems to
be only 0.4.15 and 0.4.17 old-style versions on the hexdocs. It's either me
being foolish and not understanding something or something went wrong there.
—
Reply to this email directly or view it on GitHub
https://github.com/CargoSense/ex_aws/issues/118#issuecomment-186855973.

Oh okay, I apologize for bothering, thank you :)


Support for WPF (via Xamarin Forms)

We're wondering if you have any plans to support WPF now that Xamarin Forms is in preview for this platform (as of XF 3.0.0)? We're looking to extend our app which currently runs on iOS, Android, Mac & UWP and makes heavy use of FFImageLoading.
Thanks for putting together such a wonderful library, I can't even imagine how much time it's saved us so far :-)

Thank you. That would be nice, but I'll need to have some time for this first. Meanwhile, any PR (also partially working) welcome :)

I would love to have WF version too

There is any news regard suppport of WPF, please

There is any news regard suppport of WPF, please


Invalid JSX for slot snippets

I do a lot of work with slots and really like the a-frag-slot-func and a-slot-tern snippets but I have noticed a few problems with both of these snippets that make them unusable so I have a few suggestions
a-frag-slot-func
When using a-frag-slot-func it currently outputs

Note: | indicates cursor position

<Fragment slot=| >
{

()=>

}
</Fragment>

But this does not work, you can't wrap a named slot function with <Fragment /> and instead have to use a valid HTML tag like:
<f slot="">, <fragment  slot=""> , <{slot-name} slot="">
I think the snippet should instead look something like:
<f slot="|" >
    {() => (

    )}
</f>

// or

<fragment slot="|" >
    {() => (

    )}
</fragment>

// or

<| slot="|" >
    {() => (

    )}
</|>

a-slot-tern
Currently a-slot-tern renders like this:
const slot = Astro.slots.has(slot)
? await Astro.slots.render(slot)
: '
 This slot is  required
'

But this is not valid JSX and I think it should instead be something like

Note: | indicates cursor position

{ Astro.slots.has("|")
    ? <slot name="|"/>
    :

}

// or

{ Astro.slots.has("default")
    ? <slot />
    : |
}

But also this style of ternary is the same as using fallbacks inside slots which is a bit of an anti-pattern so it could instead be something like this too
{ Astro.slots.has("default")
    ? <slot />
    : <slot name="|"/>
}

I do a lot of work with slots and really like the a-frag-slot-func and a-slot-tern snippets but I have noticed a few problems with both of these snippets that make them unusable so I have a few suggestions
a-frag-slot-func
When using a-frag-slot-func it currently outputs

Note: | indicates cursor position

<Fragment slot=| >
{

()=>

}
</Fragment>

But this does not work, you can't wrap a named slot function with <Fragment /> and instead have to use a valid HTML tag like:
<f slot="">, <fragment slot=""> , <{slot-name} slot="">
I think the snippet should instead look something like:
<f slot="|" >
    {() => (

    )}
</f>

// or

<fragment slot="|" >
    {() => (

    )}
</fragment>

// or

<| slot="|" >
    {() => (

    )}
</|>

a-slot-tern
Currently a-slot-tern renders like this:
const slot = Astro.slots.has(slot)
? await Astro.slots.render(slot)
: '
 This slot is  required
'

But this is not valid JSX and I think it should instead be something like

Note: | indicates cursor position

{ Astro.slots.has("|")
    ? <slot name="|"/>
    :

}

// or

{ Astro.slots.has("default")
    ? <slot />
    : |
}

But also this style of ternary is the same as using fallbacks inside slots which is a bit of an anti-pattern so it could instead be something like this too
{ Astro.slots.has("default")
    ? <slot />
    : <slot name="|"/>
}

I'll fix the fragment slot problem. But I did the slot tern thing to incentivize people to write code the forces people to put an element inside of the right slot. Do I do that or am I supposed to just put null there. I think there are sometimes where a slot must be used.

I'm sorry, I'm having trouble understanding your question about the slot tern do you mind explaining a bit more

I'm sorry, I'm having trouble understanding your question about the slot tern do you mind explaining a bit more

I'm trying to say that I'm not supposed to use default slots. What should I do? Do I throw an error or do I just do nothing?

I am still confused on why an error would be thrown, if you want to avoid using default slot maybe it could be something like this?
{ Astro.slots.has("${1}")
    ? ${2}
    : ${3}
}

This would be the most flexible

I am still confused on why an error would be thrown, if you want to avoid using default slot maybe it could be something like this?
{ Astro.slots.has("${1}")
    ? ${2}
    : ${3}
}

This would be the most flexible

This issue will be closed now I decided to publish a new version of the snippets.


Validate the existence of MediaSource before check MediaSource.isTypeSupported in MediaCapabilities polyfill

Issue #1391

@michellezhuogg

Hello @avelad ,
Thank you for catching this!
If window.MediaSource doesn't exist, are we returning the wrong decodingInfo result? It may seem like the variant is not supported, but actually it's because of MediaSource is not there.
Shall we make sure that window.MediaSource exists before installing the MediaCapabilities polyfill?

iOS actually supports Media Capabilities, but it doesn't support MediaSource. Since this case is rare and can only happen on some TVs, I think we can live with this, because on those TVs we would only use the src = mode.
If this convinces you too, I close this PR.

I can add a log for this case, and we can close the PR. Thank you!


QueryFilterManager.Filter not working for related entity

Hi, everyone.I have a problem with QueryFilterManager.Filter when I to want include related entity.
 QueryFilterManager.Filter<Report>(q => q.Where(e => !e.IsDeleted));
 QueryFilterManager.Filter<Event>(q => q.Where(e => !e.IsDeleted));

Report has Event.

Can you help me. Workaround for me.I use Ef core 1.1.2

Hello @sergeu90 ,
Unlike EF6, EF Core doesn't have interceptor yet which make "impossible" to support included entities.
There is nothing we can really do until interceptor is implemented.
I recommend you to upgrade to EF Core 2.x which has their own filter feature now.
Let me know if that answer successfully to the issue even if no fix is provided.
Best Regards,
Jonathan

@JonathanMagnan  Thanks.I understood you

Hello @JonathanMagnan ,
I am facing the same issue. Is there a way to solve this using the EF Core 1.x and your library?

Hello @amit-kumar2 ,
A fix will probably be soon available but only for EF Core 2.x
There is an issue in EF Core 1.x with Cast that make it not possible for us to code this features.
Best Regards,
Jonathan

Is there an alternative for me to use? Something as a workaround using the IncludeFilter etc.?

The only way I know in EF Core 1.x is currently using projection but you will end with the N+1 queries issue. This issue will dramatically affect your application performance so I cannot recommend it.


Support running overlay networking on top of dynamic IP addresses

Work is underway in SwarmKit to support dynamic IP addresses for managers in the Raft implementation: https://github.com/docker/swarmkit/pull/1579
For dynamic IP addresses to be fully supported in SwarmKit, libnetwork will need to be updated to handle address changes in overlay networking.
This could support some interesting use-cases, like running swarm clusters of laptops attached to WiFi networks. Since developers often run these tools on their laptops, it would be very nice to support this use case smoothly.
cc @mrjana @mavenugo

Servers running in DHCP environment may also change IP on reboot.

Any progress about this feature?

@aaronlehmann It has been detected that this issue has not received any activity in over 6 months. Can you please let us know if it is still relevant:

For a bug: do you still experience the issue with the latest version?
For a feature request: was your request appropriately answered in a later version?

Thank you!
This issue will be automatically closed in 1 week unless it is commented on.
For more information please refer to https://github.com/docker/libnetwork/issues/1926

Let's keep this open. cc @abhinandanpb


Portability issues

If you are compiling with GCC, it doesn't allow anonymous unions to have static data members, these structs need to be declared outside of the anonymous union https://github.com/GPUOpen-LibrariesAndSDKs/VulkanMemoryAllocator/blob/master/src/vk_mem_alloc.h#L2303-L2316 .
Also on 64bit linux, uint64_t is an unsigned long int not a unsigned long long int so you get a warning here https://github.com/GPUOpen-LibrariesAndSDKs/VulkanMemoryAllocator/blob/master/src/vk_mem_alloc.h#L843

Do you mean that this would solve the problem?
struct BlockAllocation
{
	VmaBlock* m_Block;
	VkDeviceSize m_Offset;
};

// Allocation for an object that has its own private VkDeviceMemory.
struct OwnAllocation
{
	uint32_t m_MemoryTypeIndex;
	VkDeviceMemory m_hMemory;
	bool m_PersistentMap;
	void* m_pMappedData;
};

union
{
	// Allocation out of VmaBlock.
	BlockAllocation m_BlockAllocation;
	// Allocation for an object that has its own private VkDeviceMemory.
	OwnAllocation m_OwnAllocation;
};

Yep exactly

Fixed. Thank you for your help.

No worries, tested and working perfectly on linux with gcc.


fixed 2 memory leaks

1. Editor::kill_current_buffer
   pointer had bean "erased" from vector, but memory remains
2. Editor::delete_char
   merging 2 rows did not free the "erased" row

Good catches, thank-you :)


JavaScript: Add query for identifying information leak through postMessage.

This adds a new query that flags calls of the form w.postMessage(msg, '*') where msg may contain sensitive data.
There are two questions I would particularly appreciate feedback on:

Is CWE-359 an appropriate classification?
Does the set of sources make sense? I went beyond just SensitiveExpr to also include credential-like information, using a predicate I found in the C# library. This gives us our only results on the default suite, but I'm not sure they are good results.

For evaluation, I ran the query (in isolation) on our default suite, and then measured the time it took to compute just the query stage; results are here (internal link). The numbers towards the bottom of the table look a little high, so I'll re-run the full security suite for those.
There are only two results (internal link). Both are on gecko-dev in very similar code, which sends a certificate without origin restriction. I'm not sure whether that's really an interesting result, hence my second question above.

(Still waiting for doc review.)

@xiemaisi - LGTM from an editorial point of view.

Thanks, @mc-semmle! @asger-semmle / @esben-semmle, anything else you want me to address?


VBD integration

Description
This (draft) PR integrates a trained VBD model with the simulator.
Open todo's

[x] Add support for a "warmup period"
[x] Construct a sample (main input to the model) with the following pieces of info in global coordinates:

dict_keys(['agents_history', 'agents_interested', 'agents_type', 'agents_future', 'traffic_light_points', 'polylines', 'polylines_valid', 'relations', 'agents_id', 'anchors'])

[ ] Integrate StateDynamics model for the actions
[ ] Feed predicted action back into simulator
[ ] Make videos to test VBD model

Notes

Missing global vehicle height and global yaw.
Confusion: agent_history vs. agent_futures?
Compare: construction of polylines vs. our self.sim.agent_roadmap_tensor().to_torch()
What is the anchors datatype (converting ints to vectors of floats) and is it essential?

Usage
for i in range(current_state.remaining_timesteps):
    t = i % replan_freq
    if t == 0:
        print("Replan at ", current_state.timestep)
        sample = dataset.process_scenario(
          current_state,
          current_index = current_state.timestep,
          use_log=False,
          selected_agents=selected_agents, # override the agent selection by distance to the ego
        )
        batch = dataset.__collate_fn__([sample])
        pred = model.sample_denoiser(batch)#, x_t=x_t)
        traj_pred = pred['denoised_trajs'].cpu().numpy()[0]

    action_sample = traj_pred[:, t, :]
    action = sample_to_action(action_sample, is_controlled, agents_id=selected_agents)
    current_state = env.step_sim_agent(current_state, [action])
    state_logs.append(current_state)

I know this is a WIP but one comment is that we should probably move the VBD folder into something like an "extensions" folder or something to separate it out from the main functionality

I know this is a WIP but one comment is that we should probably move the VBD folder into something like an "extensions" folder or something to separate it out from the main functionality

Good point! Yeah, something along the lines of extensions or integrations sounds good. Will discuss with Zixu tomorrow


GDR copy visibility order guarantees on GPU

Say I have two set of gdr buffers A and B, each with its own memory handle mh_A, mh_B on which host to device copy is performed.
Now, if I do gdr_copy_to_mapping(mh_A,... ) followed by gdr_copy_to_mapping(mh_B, ...), is there a guarantee of the visibility order in the CUDA kernel if it monitors these buffers? If not does something like _mm_sfence() help here?
The usage is that I will prepare data on A to be consumed by GPU and then signal it via B.

Hi @sitecao,
If you need the visibility ordering, please use cuFlushGPUDirectRDMAWrites (https://docs.nvidia.com/cuda/cuda-driver-api/group__CUDA__DEVICE.html#group__CUDA__DEVICE_1g265e3c82ef0f0fe035f85c4c45a8fbdf). For example,
gdr_copy_to_mapping(mh_A, ...);
cuFlushGPUDirectRDMAWrites(...);
gdr_copy_to_mapping(mh_B, ...);

It will guarantee that when your CUDA kernel observes B, that kernel can safely consume A.

Hi @sitecao,
If you need the visibility ordering, please use cuFlushGPUDirectRDMAWrites (https://docs.nvidia.com/cuda/cuda-driver-api/group__CUDA__DEVICE.html#group__CUDA__DEVICE_1g265e3c82ef0f0fe035f85c4c45a8fbdf). For example,
gdr_copy_to_mapping(mh_A, ...);
cuFlushGPUDirectRDMAWrites(...);
gdr_copy_to_mapping(mh_B, ...);

It will guarantee that when your CUDA kernel observes B, that kernel can safely consume A.

sweet! thank you


http://<IP_ADDRESS>/cgi-bin/luci/admin/network/syncdial

/usr/lib/lua/luci/dispatcher.lua:487: Failed to execute cbi dispatcher target for entry '/admin/network/syncdial'. The called action terminated with an exception: /usr/lib/lua/luci/model/cbi/syncdial.lua:20: attempt to index field 'webadmin' (a nil value) stack traceback: 	[C]: in function 'assert' 	/usr/lib/lua/luci/dispatcher.lua:487: in function 'dispatch' 	/usr/lib/lua/luci/dispatcher.lua:121: in function </usr/lib/lua/luci/dispatcher.lua:120>

These files are not part of the official LuCI repository.


Fix developer list

vocuh good defender

This won't compile, when you fix the issue you can ammend the commit

Beaner


current_period isn't recalculated upon restart

Current Behavior
After not having started renterd for a few months, I found out that the contracts are not formed because "the end height is in the past". After digging into the issue, it turned out that current_period in the autopilots table still contained the value from the past, when I last started renterd.
Expected Behavior
Current Period should be recalculated every time renterd starts.
Steps to Reproduce
No response
Version
Latest master merged into a custom fork
What operating system did the problem occur on (e.g. Ubuntu 22.04, macOS 12.0, Windows 11)?

No response

In theory it should update but you are right it would not happen immediately upon being synced again. Instead it would probably update the current period by 1 period every 30 minutes.


Secrets provider - Support OC4.3

We want to add support to OC4.3 in addition to what we have today (OC3.11, GKE).
To support another environment we have to be aligned to k8s-conjur-deploy master.
Today we are working with specific branch on k8s-conjur-deploy  repo which make it difficult to add changes under infra. Need to make sure we are working with updated branch on k8s-conjur-deploy and than add some fix there including OC4.3
DOD:

[x] Working with master branch on k8s-conjur-deploy
[ ] Improve our infra and make this repo more stable
[ ] Support OC4.3

We will continue with an advanced version of ocp
closing this


Set user password and retrieve a details result

Set user password and retrieve a details result

Hi @lvermeulen , @bruegth , @JTOne123  thank you for maintaining and contributing on the such good and important project. We'd like to give our contribution on the project. This is the first in the serie of PRs. I hope it won't be that difficult to review our PRs in the order in which I created them.

Thanks, @slavko-vega !


AttributeError: 'pg_engine' object has no attribute 'pgsql_cur'

Hi there!
I'm trying to configure replica from MySQL to Postgres with docker-compose. I created two db images and separate image for chameleon
FROM python:3.7-alpine

RUN \
 apk add --no-cache postgresql-libs && \
 apk add --no-cache --virtual .build-deps gcc musl-dev postgresql-dev && \
 pip install pg_chameleon --no-cache-dir && \
 apk --purge del .build-deps && \
 chameleon set_configuration_files

COPY wait-for.sh /bin
VOLUME /root/.pg_chameleon

ENTRYPOINT sh -c '/bin/wait-for.sh db:3306 -- /bin/wait-for.sh pg:5432 -- chameleon init_replica --config default --source mysql --debug'

When I run it I get this error: AttributeError: 'pg_engine' object has no attribute 'pgsql_cur'.
My guess is that I need to install chameleon inside Postgres image instead of separate image. Do you have any instructions/advices on how to use chameleon with Docker?
Source code is here https://github.com/stereobooster/headless-cms-comparison/tree/master/directus-chameleon-hasura

the error means the connection to postgresql is not successfuly. did you enable postgres to accept the connections from other hosts? what the postgresql log says?

@stereobooster I had the same issue and from the repo you linked it appears to be for identical reasons:
  File "/usr/local/lib/python3.7/site-packages/pg_chameleon/lib/global_lib.py", line 115, in __init__
    self.pg_engine.type_override = self.config["type_override"]
KeyError: 'type_override'

It appears to me that you have to specify an empty list in the yaml file when you do not want to have type override. The same goes for limit_tables, skip_tables and grant_select_to.
@the4thdoctor Maybe a check for the key or retrieval of the key with a default value on nonexistence would help avoid this kind of error?

@the4thdoctor
Hi there!
I'm trying to configure replica from MySQL to Postgres.
"chameleon add_source --config default  --debug"
I got error:
"You must specify a source name with the argument --source"
I thought my source already in the default config file ???

I updated the config file correct the schema mapping and it works

I'm actually having the same issue, and I've tried it with the empty dicts, but nothing. I think it may be related to how the source schema in the schema mappings needs to be escaped (contains a -)
How would one properly escape that?

can you provide an example for your schema_mappings?
I'll try to reproduce the issue.
Thanks

I want everything in the database, so I just put it in as
    schema_mappings:
      miner-hosting: miner_hosting
    limit_tables: {}
    skip_tables: {}
    grant_select_to:
      - usr_readonly
    lock_timeout: "120s"
    my_server_id: 100
    replica_batch_size: 10000
    replay_max_rows: 10000
    batch_retention: '1 day'
    copy_max_memory: "300M"
    copy_mode: 'file'
    out_dir: /tmp
    sleep_loop: 1
    on_error_replay: continue
    on_error_read: continue
    auto_maintenance: "disabled"
    gtid_enable: false
    type: mysql
    skip_events: {}
    keep_existing_schema: Yes

I read earlier if I wanted to not have limits and skips, to provide an empty dictionary.

Thanks. Will try to reproduce the error.


Add support for 5-strike move calculation

Add support for 5-strike move calculation.

Five Strike: Whenever a Move with Five Strike is used, roll 1d8. On a result of 1, the attack hits one time. On a result of 2 or 3, the attack hits two times. On a result of 4, 5, or 6, the attack hits three times. On a result of 7, the attack hits four times. On a roll of 8, the attack hits five times. Multiply the Move’s Damage Base by the number of times hit; that becomes its new Damage Base. You may always apply Technician to Moves with Five Strike. Apply STAB and all other effects that raise Damage Base only after the Move’s final Damage Base has been calculated.

Implemented in build: https://github.com/caffyn/PTUMoveMaster/commit/dac858cb07a97361f9080cc308ff715df3de2abf


Submit training code error

I'm sorry to bother you, but I ran pythonpython bin/train.py config_jsons/cath_full_angles_cosine.json --dryrun in foldingdiff_main The error is as follows:
from foldingdiff import datasets
ModuleNotFoundError: No module named 'foldingdiff'
Looking forward to your reply

Did you run the pip install command?


core: handle promise rejection in state

Existing code attempts to ignore failures opening LED file paths in
safeWrite(). However, there's an unhandled promise rejection in a couple
of places as a result of mishandling the rejection. Catch the error to
prevent this warning.
Change-type: patch
Signed-off-by: Joseph Kogut<EMAIL_ADDRESS>

@balena-ci rebase


Rename GDTCORStorage to GDTCORFlatFileStorage

Renames GDTCORStorage to GDTCORFlatFileStorage to be more descriptive of the actual functionality and because of potential confusion due to the creation of GDTCORStorageProtocol.

Please add reason for rename to PR description.

Done.


Update dependencies

Codecov Report

Merging #870 (044b69e) into main (1d54b49) will increase coverage by 0.69%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main     #870      +/-   ##
==========================================
+ Coverage   62.90%   63.59%   +0.69%
==========================================
  Files         148      148
  Lines        7251     7235      -16
  Branches     1410     1354      -56
==========================================
+ Hits         4561     4601      +40
+ Misses       1789     1788       -1
+ Partials      901      846      -55

see 28 files with indirect coverage changes
:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more


Some Luca QR codes show "undefined" as location name after being scanned

Avoid duplicates

[x] Bug is not mentioned in the FAQ
[ ] Bug is specific for Android only, for general issues / questions that apply to iOS and Android please raise them in the documentation repository
[x] Bug is not already reported in another issue

Technical details

Device name: Google Pixel 6 Pro
Android version: 12
App version: 2.14.1

Describe the bug
Some QR codes for the Luca app when scanned with CWA display "undefined" as location. The same code scanned with the Luca app displays the correct location name. I cannot test if this is specific to the Android version or if it affects iOS too. I will post a QR code later today if it's needed.

@smares
There are some other postings relating to this issue.

https://github.com/corona-warn-app/cwa-documentation/issues/741
https://github.com/corona-warn-app/cwa-wishlist/issues/679

Sorry, you're right. Closing then.


[FEAT]: Create Organization Invitation Link -Backend

Issue: Implement an API for creating Organization invite link
Description
Create an API endpoint to generate invitation links for inviting users to join an organization. This endpoint will validate the input data and generate a unique invitation link for the specified organization.
Acceptance Criteria
API Endpoint Implementation:

The endpoint should be accessible at /api/v1/invite/create.
The endpoint should accept HTTP POST requests.

Data Validation and Sanitization:

The API should validate the request payload to ensure the required fields (organizationId, email) are present and valid.

Invitation Link Generation:

Upon successful validation, the API should generate a unique invitation link for the specified organization.
The generated invitation link should be stored in the database with an expiration date.

Email Sending:

The API should send an email containing the invitation link to the specified email address.
The email should contain a clear and concise message with the invitation link.

Response:

On success, the API should return a 201 Created status code with the invitation link and a success message.
On failure, the API should return a 400 Bad Request status code with appropriate error messages.

Request Example:
POST  /api/v1/invite/create
{
  "organizationId": "string",
  "email": "string"
}

Successful Response:
{
  "message": "Invitation link created and sent successfully",
  "data": {
    "invitationLink": "string"
  },
  "status_code": 201
}

Error Response:
{
  "message": "Failed to create invitation link",
  "errors": [
    "Invalid organization ID",
    "Email format is incorrect"
  ],
  "status_code": 400
}

Purpose
Provides a backend service to generate unique invitation links for inviting users to join an organization, ensuring the data is valid, storing the invitation link with an expiration date, and sending the invitation link via email.
Requirements

Develop server-side logic to handle invitation link creation.
Validate and sanitize incoming data.
Generate and store unique invitation links with expiration dates.
Send the generated invitation link via email to the specified address.

Expected Outcome
The API endpoint allows administrators to generate invitation links for inviting users to join an organization, ensuring the links are valid and stored with expiration dates.
status_code

201: Invitation link was successfully created.
400:

Invalid organization ID
Email format is incorrect

500: A server error occurred

Testing

Write unit tests to ensure the invitation link creation endpoint validates input correctly and generates unique invitation links.
Perform load testing to ensure the endpoint can handle multiple requests.
Test various scenarios for generating invitation links (e.g., valid organization ID, invalid organization ID, invalid email format, etc.).
Test email delivery to ensure the invitation link is correctly sent to the specified email address.

slack ID: @Goldyn


end to end test PR

Thank you for submitting a pull request on this HMRC repository. A member of the HMRC team will review your changes and action accordingly.
HMRC reviewer: please reference this runbook for guidance on how to proceed.


[Addons] Extend SemanticUI themeing from addons

meta issue: #1433

See https://github.com/eea/volto-slate/blob/2e79e0438faed4c7728dd38d79bc2a54d9c9136d/src/editor/less/globals.less and https://gist.github.com/tiberiuichim/eb20c6c18210c384e57028f94d9f4b18 for implementation and docs.

Done.

@sneridagh there's still a piece missing from that story, how to make addon provide the same theming story as the core, basically including .loadAddonOverrides() + friends in core.

@tiberiuichim does this works already?


Dodata stranica za VDL - MD Touristic

👷 Deploy Preview for balkantransport processing.
🔨 Explore the source changes: 85bcbfecf4d62b806afc02817975be276b3eed04
🔍 Inspect the deploy log: https://app.netlify.com/sites/balkantransport/deploys/61bcd5f0cf5a54000a011497


[release-1.4] Add analyzers for Sidecar workload selectors

This is an automated cherry-pick of #18600

@istio-testing: The following test failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

integ-istioio-k8s-tests_istio_release-1.4
81715cccada553b4d734b087022f5ee4eec7e5cc
link
/test integ-istioio-k8s-tests_istio_release-1.4

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.


Requirements.txt NOT FOUND

Please push some requirements.txt so it will be easy for someone to install it from pip
or
I see you're using setup.py but the required module are still lack of it e.g. Pillow for the extract_pixels.py

The tool directory is not part of the module; its purpose is to make it easier to decrypt the costumer key from the native app.
Having a README on the dir to include more information about what this tool does is not a bad idea.
Let me know if you want to open a pull request.

I've added some instruction on how to use the tool.
e4365e5ba0a37649744fca87a29ffc190a3ffa60


[FEAT] Is it possible to display pane with horizontal offset by default

I would like to know if there is an option to display the pane horizontally offset-ed at the start instead of in the middle of the screen?
Example:

Hi @garj
Right now you can hardcode with css, like so:
.pane {
    left: 15px !important;
    margin-left: unset !important;
 }

I know this not a best way, but might fill your need as a quick solution.

works great! thanks!

works great! thanks!


[Wishlist] allow updating of CloudFront certificates too

From an API perspective, what's involved in updating a cloudfront cert? If
you can point me to the API, I think it'd be straigthforward.
On Tue, Apr 5, 2016 at 3:47 PM, Guillaume Rischard<EMAIL_ADDRESS>
wrote:

—
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub
https://github.com/alex/letsencrypt-aws/issues/41

--
"I disapprove of what you say, but I will defend to the death your right to
say it." -- Evelyn Beatrice Hall (summarizing Voltaire)
"The people's good is the highest law." -- Cicero
GPG Key fingerprint: D1B3 ADC0 E023 8CA6

It looks like you need to update the ViewerCertificate part of the CloudFront distribution config:
https://docs.aws.amazon.com/AWSCloudFormation/latest/UserGuide/aws-properties-cloudfront-distributionconfig-viewercertificate.html
Maybe
https://boto3.readthedocs.org/en/latest/reference/services/cloudfront.html#CloudFront.Client.get_distribution_config to get the config object, get the IamCertificateId to check for expiration, then update the object to set CloudFrontDefaultCertificate to false and IamCertificateId to the new one, then https://boto3.readthedocs.org/en/latest/reference/services/cloudfront.html#CloudFront.Client.update_distribution to set the new config.
The port is irrelevant for cloudfront, there's only one certificate per distribution.

PR #44 covers this, but it needs a bunch of testing, I don't have CF distribution set up to make sure this works.


support old version NetBox

now, migration files use utilities.json.
This module is added more NetBox v3.4.0
https://github.com/netbox-community/netbox/issues/10348
we have to change migration definition for support older version for.

old version is not used for people.
so, close it


member Registeration failed

peeradmincard created successfully through command $ ./createPeerAdminCard.sh  also i got the following output when run [ $ composer card list ] command
composer card list
The following Business Network Cards are available:
Connection Profile: hlfv1
┌─────────────────┬───────────┬──────────────────┐
│ Card Name       │ UserId    │ Business Network │
├─────────────────┼───────────┼──────────────────┤
│ PeerAdmin@hlfv1 │ PeerAdmin │                  │
└─────────────────┴───────────┴──────────────────┘
Issue composer card list --card  to get details a specific card
Command succeeded
My problem is : when i opened the application at address [ http://localhost:8000/registerMember ] and entered everything like userid ..etc  i got the following error [ Card not found: admin@clp-network ]
any advise please ?

@aazzim did you try running composer card list --card to see if the card was present

@aazzim - curious if you ran the command Raheel suggested - as it worked for me. tx


fix #277, bad exception handle

Remove a except Exception as e: which will catch all exception in the view function, add stack_info=True to other loggers.

Sadly stack_info not available in python 2.7, should I change to log.exception ?

@guyskk log.exception would be ok.


React: Masthead -  search open by default - when we tries to activate the user profile button the button is not operable

Detailed description
Issue: When the search popup is displayed,  when we tries to activate the user profile button the button is not operable. instead the search popup is getting closed when we tries to activate it. Note: user profile button is not operable only when the search popup is  displayed.
Expected : User profile button should be operable.
Additional information

The only team that has search open by default is the IBM Search team.  Their configuration does not have the profile icon active.  No teams are using this configuration option currently.

@RobertaJHahn Let's move to Jan release.


[Discussion] Naming scheme and namespaces

I am still not sure about the naming scheme in the ViennaCore library.
I have now prefixed all files with vt (ViennaTools) and used the namespace vieTools, but I don't really like it that much. The issue I have with these prefixes is that the functions are going to be used all over the ViennaTools libraries and especially in ViennaPS, where everything is combined; a user then has to know whether a particular function is from ViennaPS, LS or Core, and use the according prefix.
One option could be to alias the most important functions (SmartPointer in particular) in all libraries, so you have a vtSmartPointer, lsSmartPointer, and psSmartPointer, which are all the same.
Another option I could think of is to use a global namespace for all libraries, or maybe one can alias a namespace (not sure if this is possible)?

Another option I could think of is to use a global namespace for all libraries, or maybe one can alias a namespace (not sure if this is possible)?

namespace x = y;

You could also add a using namespace inside the respective ViennaLS/PS... namespace


ad sharing question

this plugin is free 100% or we are sharing ads with you ?

100% free

As @erperejildo said, it is 100% free.

Trust, but verify


stream reconnection

@nacx Do you agree to add in a future PR the exponential back off interval and the exception in reconnection fail?

@nacx Do you agree to add in a future PR the exponential back off interval and the exception in reconnection fail?

ok

Added by this other pull https://github.com/abiquo/api-java-client/pull/40


Change the text of the second question

Expected Behavior
Users can clearly know the range they should identify is the space inside the red box.
Current Behavior
Users are confused about the new building outside the box.
Possible Solution
Change the text of second question of "建物" to "承上，你覺得after的方框內有擴建嗎？"
Change the text of second question of "農地" to "承上，你覺得after的方框內有建物嗎？"
Screenshots

resolved by d620da7


ES6 installation?

I'm trying to import sticky-js as an ES6 module.
import Sticky from 'sticky-js';

var sticky = new Sticky('.foo');

but it doesn't work. Any suggestions?

Solved. I had some other JS conflicts.


zfsUnstable: 2.1.0-rc6 -> 2.1.0-rc7

Motivation for this change
https://github.com/openzfs/zfs/releases/tag/zfs-2.1.0-rc7
Things done

[x] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
Built on platform(s)

[x] NixOS

[x] Tested execution of all binary files (usually in ./result/bin/)
[x] Fits CONTRIBUTING.md.

Result of nixpkgs-review pr 126570 run on x86_64-linux 1

4 packages marked as broken and skipped:

linuxPackages-libre.zfsUnstable
linuxPackages_hardkernel_4_14.zfsUnstable
linuxPackages_hardkernel_latest.zfsUnstable
linuxPackages_latest-libre.zfsUnstable

14 packages built:

linuxPackages.zfsUnstable (linuxPackages_5_10.zfsUnstable)
linuxPackages_4_14.zfsUnstable
linuxPackages_4_19.zfsUnstable
linuxPackages_4_4.zfsUnstable
linuxPackages_4_9.zfsUnstable
linuxPackages_5_12.zfsUnstable (linuxPackages_latest.zfsUnstable)
linuxPackages_5_4.zfsUnstable
linuxPackages_hardened.zfsUnstable
linuxPackages_latest_hardened.zfsUnstable
linuxPackages_lqx.zfsUnstable
linuxPackages_testing_bcachefs.zfsUnstable
linuxPackages_xanmod.zfsUnstable
linuxPackages_zen.zfsUnstable
zfsUnstable

Result of nixpkgs-review pr 126570 at a9ee2c94 run on aarch64-linux 1

3 packages marked as broken and skipped:

linuxPackages_hardkernel_4_14.zfsUnstable
linuxPackages_hardkernel_latest.zfsUnstable
linuxPackages_testing_bcachefs.zfsUnstable

1 package failed to build:

linuxPackages_zen.zfsUnstable

6 packages skipped due to time constraints:

linuxPackages-libre.zfsUnstable
linuxPackages_4_4.zfsUnstable
linuxPackages_4_9.zfsUnstable
linuxPackages_latest-libre.zfsUnstable
linuxPackages_lqx.zfsUnstable
linuxPackages_xanmod.zfsUnstable

8 packages built successfully:

linuxPackages.zfsUnstable (linuxPackages_5_10.zfsUnstable)
linuxPackages_4_14.zfsUnstable
linuxPackages_4_19.zfsUnstable
linuxPackages_5_12.zfsUnstable (linuxPackages_latest.zfsUnstable)
linuxPackages_5_4.zfsUnstable
linuxPackages_hardened.zfsUnstable
linuxPackages_latest_hardened.zfsUnstable
zfsUnstable

Note that build failures may predate this PR, and could be nondeterministic or hardware dependent.
Please exercise your independent judgement. Does something look off? Please file an issue or reach out on IRC.

@GrahamcOfBorg test zfs.unstable

tests passed on aarch and x86


Add additional services - Netflix etc

How can I reference Netflix or a specific plugin OLM-FNC, as shown in the picture above?

Sorry but this is not possible, openWebIf interface doesn’t contain this in its api.

What about if you assign a plugin to a coloured button i.e. blue can that be called as a reference?
http:///web/remotecontrol?command=401

I will look on this possibility.

That would be great - thank you

Right now this not be added.


Is there a way to change a subscriber's plan?

I don't see any documentation for changing a subscriber's plan. The method would be change_subscription_plan.xml, documented here:
https://www.spreedly.com/manual/integration-reference/change-subscriber-subscription-plan
I'm happy to fork and add if this isn't already a feature, but I wanted to make sure I didn't miss something before digging in.
Thanks!

I think you used to have to go through "update subscriber" to change their plan, so I haven't implemented that specific API.
That makes a lot more sense than having to update the subscriber though, so it would be great to have support for it.
Thanks!


Needs python to run!

I have vim compiled with the option --with-python. Now you check the available version with has("python2") but this does not return true, even my version vim was compiled with is 2.7.10. I tried it with has("python") and that yields true.

@Townk, may be you can participate?

has("python2") is not a thing in Vim.

has("python") is the correct way to check for Python 2 support.
has("python3") is the correct way to check for Python 3 support.

So this line should be fixed: https://github.com/artur-shaik/vim-javacomplete2/blob/2f11a7becc10e68134a35130a0d8a158c11d56eb/autoload/javacomplete.vim#L11

@justinmk , thanks.
@andiderp , please can you try again?

It works fine.

Double apologies guys for this. First for the lack of response on the past week and second for the stupid python2 check. I used that to guarantee I would load python 2.x by accident and I completely forgot to changed it. Thanks for fixing it.


Explore subset of TFD bins

From Mike Gilson:

I'm wondering whether you would in fact see an increase in the standard deviation of ddE in "TFD slices" of the data that move to the right. That is, maybe bin the data by TFD (0-0.05, 0.05-0.10, 0.10-0.15, etc), and compute the standard deviation of ddE within each slice.

Also make a histogram of the ddE values within different TFD ranges.

This was explored independently (June 2020), and no strong correlation was found in ddE by smaller TFD slices.
See results:
https://docs.google.com/presentation/d/1TZRyAw9QAq-rdHRTchqILysTeg2zMuyS2S5G7-2x1A4/edit#slide=id.g81dd0a5dcb_0_0


[FEATURE] Github recursive scan

Describe the feature you'd like
Since the current Github document loader isn't recursive scanning repos, I would like to add this feature as option.
Additional context
The recursive flag is already implemented, but the UI doesn't have the form for that.
I've already implemented it locally - it works on my machine.

there is a PR - https://github.com/FlowiseAI/Flowise/pull/251


Project > Language Engagement > Language name is not displayed for consultant user

Roles: Consultant
Describe the bug
Project > Language Engagement > Language name is not displayed for consultant user
Steps to Reproduce

Login as Admin user
Create a new project and assigned team member consultant
Add Language engagement
Login as consultant user
Open Project created by an admin user
Click on created Language engagement

Expected Result
Language name should be displayed
Actual Result
Language name is not displayed for consultant user
See video - https://drive.google.com/file/d/1V77jrlG37fkG8grDIYiewzSftefBOAnw/view?usp=drivesdk
cord-field# 89ee57a1

@sethmcknight @CarsonF @parashara1
Tested with latest develop d49b012 and it's working fine now. Attaching a screenshot for reference. Closing the issue. Thanks!
See screenshot :


Pause GitHub actions

Automated GitHub Action has thrown an error since 20:05 UTC

Commits 4b7348fc9bbd8d711bcb219bd168a6eec8fa6acc, 53cf2941925f94da30c50e0f2a9b622fa86e051c and 7123fd8b48035ffc25f8263f5d3a80902a7f37d4 are the fixes