chore(weave): consistent font color for manage columns popup

Description

Fixes WB-NNNNN
Fixes #NNNN

What does the PR do? Include a concise description of the PR contents.
After

Testing
How was this PR tested?

I think i was color blinded or hallucinated that it was using pitch black for fonts. not true so no fix needed.


+gearstats mage unexpected error

Getting a reply from Old School Bot that an unexpected error occured when trying to check my mage gear stats.

what gear are you wearing in your mage set

command no longer exists, all stats is shown in +gear setup

command no longer exists, all stats is shown in +gear setup


feat: Added support for including form block in a 2 column layout

Please always provide the GitHub issue(s) your PR is for, as well as test URLs where your change can be observed (before and after):
Fix #333 #329
Test URLs:

Before:

https://main--shredit--stericycle.aem.page/en-us/secure-shredding-services/drafts/one-off-shredding-service

After:

https://form-col--shredit--stericycle.aem.page/en-us/secure-shredding-services/drafts/one-off-shredding-service

@ravise5 solution seems to make sense but rendering is off

The content (text and form should fit within the margins of the site. Currently it expands while past and doesn't align with the content.
The gray background should fill the entire space - there should be no white around it.
There is too much padding on the top and bottom of this section
It should look exactly like: https://www.shredit.com/en-us/secure-shredding-services/one-off-shredding-service

@colinvlasak addressed these comments. Please review.

@colinvlasak all issue addressed.

@ravise5 Overall looks good. 2 notes below.
The text is bleeding into the toggle on smaller screen sizes. Can you have it stack like it does on mobile once there isn't enough space to show the label and toggle on one line?

This may be more for @MarquiseRosier but the page is still missing the ecomm box and CTA below the form. Please see that it is added.

@colinvlasak it does stack, let me tweak the media query width to do this earlier then


Remove evaluation report violations when observed violations is 'no'

Jira ticket for this change
Summary
This adds a check in the services layer that will remove reportViolations when the observedViolations value is false. That condition happens when the user selects 'No' for the observed violations option on the first page of the evaluation report flow.
Setup to Run Your Code

💻 You will need to use three separate terminals to test this locally.
Terminal 1
Start the Storybook locally.
make storybook

Terminal 2
Start the UI locally.
make client_run

Terminal 3
Start the Go server locally.
make server_run

Additional steps

Access the
Login as a

Verification Steps for Author
These are to be checked by the author.

[ ] Tested in the Experimental environment (for changes to containers, app startup, or connection to data stores)
[ ] Request review from a member of a different team.
[ ] Have the Jira acceptance criteria been met for this change?

Verification Steps for Reviewers
These are to be checked by a reviewer.

Frontend

[ ] User facing changes have been reviewed by design.
[ ] There are no aXe warnings for UI.
[ ] This works in Supported Browsers and their phone views (Chrome, Firefox, IE, Edge).
[ ] There are no new console errors in the browser devtools
[ ] There are no new console errors in the test output
[ ] If this PR adds a new component to Storybook, it ensures the component is fully responsive, OR if it is intentionally not, a wrapping div using the officeApp class or custom min-width styling is used to hide any states the would not be visible to the user.

Backend

[ ] Code follows the guidelines for Logging
[ ] The requirements listed in Querying the Database Safely have been satisfied.

Database
Any new migrations/schema changes:

[ ] Follows our guidelines for Zero-Downtime Deploys
[ ] Have been communicated to #g-database
[ ] Secure migrations have been tested following the instructions in our docs

Screenshots

Warnings

:warning:
Please add the JIRA issue key to the PR title (e.g. MB-123)

  Generated by :no_entry_sign: dangerJS against d55270ef47d0c969813549654647e53711d3fcc7


Select All

Hi, is there any way to have a button that selects all the photos in an album?

I don't think it's a feature I'll do in the future. Because it will suffer a very long wait if using iCloud Photo in iOS.


DateTime constructor does not throw when given impossible date input

The deck sample is pretty much self-explainatory I think. In normal C# the constructor throws System.ArgumentOutOfRangeException given the absurd parameters. In bridge it builds incorrect date instead.
Steps To Reproduce
https://deck.net/cac7fb31aa9a0198b07c8efa82a57985
public class Program
{
    public static void Main()
    {
        var date = new DateTime(2017, 1, 0);
        Console.WriteLine(date);
    }
}

Expected Result
Unhandled Exception: System.ArgumentOutOfRangeException: Year, Month, and Day parameters describe an un-representable DateTime.

Actual Result
12/31/2017 00:00:00

Just for completion, I stumbled upon this when experimenting with this gem:
https://stackoverflow.com/a/8619946


SPIKE: running propose-downstream in action

After migrating building SRPMs for Copr builds in Copr, the sandcastle will be used only for propose-downstream execution.
However, we could get rid of sandcastle fully if we utilised the GH actions instead.
The expectation here would be that we would trigger a GH action that would run the propose downstream, wait for its completion (see) and report the state/do additional handling.
The outcome of this card should be the requirements for implementation of this and possible problems so that we can decide whether we want to do this.
This came up when discussing #1662

Still valid, we still want to get rid of sandcastle.


Split CMS.js file in to smaller parts

I think it would be great if we would split up the "large" file into smaller chunks so it's more readable.
Is there any interest in it?

Hey @wasnlosdu yes I’m definitely on board with that. I actually have a working branch already started splitting out the code. I’ll push it up and let you know when it’s up.

Was going to propose this myself, but @wasnlisdu beat me to it.  A big plus would be that end users could (possibly) swap out parts.  For example, if they want to use Mustache for templates, GitLab or Bitbucket for hosting, etc..

@chrisdiana - that sounds awesome if you need any help just ask :)
I f think I like the idea @MorganConrad but I'm concerned we might overcomplicate things. What do you think?

@wasnlosdu I agree my ideas might overcomplicate.  They are more of a version 3 or 4 thing.  But good to keep in mind as you split up and modularize CMS.js.

@MorganConrad let's try to remember that.
@chrisdiana do you have an opinion about the feature idea?

Yeah I agree with you @wasnlosdu as we might fall into the trap of over-complicating things. We can maybe leverage plugin extending or config extending similar to how the markdown engine works. This way we can keep the core clean while not limiting features. Once I get a chance to push up the split code maybe you all can take a look and see if we missed anything.

Hey @wasnlosdu @MorganConrad so I split up the code into smaller modules so it's easier to maintain. While I was at it, I also just figured I'd move the code to ES6/Babel since we would be combining files anyway at that point. So now it's using rollup with a few plugins for building but the source is still dependency free...keeping it nice and small. I'm sure I missed a few things in the migration so feel free to PR if you find any lingering items or any suggestions as well!
One more thing, also added a development setup wiki page too which will probably need some development but at least a good starting point.


Fixed removing of Mouse and Key Listeners that have not been added yet.

It fixes issue with Nifty GUI, where the listeners are being removed before the addition.

Sounds good, would you mind updating CHANGELOG.md with your changes? Cheers.

@nguillaumin Done.

Thanks!


Create http rest calls to start / stop the service

Use express to create some simple rest calls that'll start and stop the mining process (including passing in the search terms).
Super simple post to start and delete to stop would be good, ensuring a lock to ensure only one instance can run at any time. This is mostly just for the miner to use so they can slap it on some box somewhere and tell it to start and stop at will. A child process may be a method to look at?
It would be a good idea to log a "session" in the database with an ID and link all mined results from that session to that ID.
We want to be somewhat cautious about security so I'd probably have a password field that needs passing up as well. It can look to a password in the plain text config.js for now. We'll look at an account system later on.

We could wrap the miner into a service, start it using a child process, save the pid do the database as a "session" and when we're given the kill command by another rest call, we look up the pid and issue a normal command to the OS to terminate the process using it's pid, then report the status once it's shut down.
This doesn't seem very... correct? Part of me would rather we're able to store it in memory and access it again using the ChildProcess object.
Any suggestions on an approach to this would be great, otherwise I'll do some research.

Resolved by PR #5


Make pullrequest title and description is wrongly escaped in Jenkins

Using ghprb v1.14-7 on Jenkins ver. 1.577, in the left hand side "Build History" of a job I'm seeing:
Aug 28, 2014 12:21:11 PM
   PR #2: UI configuration for MultiG...

as in it's displaying HTML source, escaped - instead if a clickabled link as you probably intended.
If this worked before, maybe some Jenkins API changed meanwhile and you have to tell it you're giving HTML so that it does not escape it? (I do NOT know Jenkins internals, just guessing from having dealt with similar problems in other systems in the past.)
I don't know if this has anything to do with https://github.com/janinko/ghprb/issues/144 ?

hi. i'm using jenkins 2.55 and ghprb 1.32 and i still have this issue... could it be something on my config? thanks!

I have the same issue still. I'm using Jenkins 2.11 and ghprb 1.38.0.
Can this be configured?

Manage Jenkins > Configure Global Security.  Select "Safe HTML" as the Markup Formatter.


Start bringing Variation Live Resources back

Galaxy EU WFs have been refactored so that they are in a usable state once more.
Switched to FlatShields like elsewhere and hope I did it right.

https://usegalaxy.eu/u/wolfgang-maier/w/covid-19-variation-analysis-on-pe-data treats paired input as 2 times single end. Did you check how this affects trimmed output ?

@mvdbeek as discussed offline just now the fastp step is still running in PE mode. It justs gets each pair of reads from two separate collections. So we should be fine.
Thanks for checking the WF though :+1:

Thanks! We need to fix that performance issue as well :/


fix(node): tls allocation issue by updating linux gnu build image

Fix https://github.com/swc-project/swc/issues/4107
https://github.com/Brooooooklyn/swc/runs/6286599487?check_suite_focus=true passed

@kdy1 ready

Seems like the integration test is failing? https://github.com/swc-project/swc/runs/6285669053?check_suite_focus=true

I'm not sure why it's faiiling, though

Hmmm, maybe because I upgrade the node@14 to node@16 in the integration test. Should we revert the upgrade?

I think it's better to update integration test (if it uses node 16 in recent version)
I'll modify this PR


do not show two screens at once

Summary
While tweaking the self-hosted purchase flow, I discovered that if CWS sends license successfully but mattermost-server fails to apply it (I originally was creating a license with no seats on accident), we would show both the success screen and the failure screen at the same time because of how. We are unlikely to see this happen in production, but should cover the case nonetheless.
Ticket Link
https://mattermost.atlassian.net/browse/MM-47423
Related Pull Requests
N/A
Screenshots
N/A
Release Note
NONE

E2E tests not automatically triggered, because PR has no approval yet. Please ask a developer to review and then try again to attach the QA label.

/cc @amyblais we would like to cherry-pick this in the cloud branch so that it will be included with the 7.7 release.

/cc @amyblais we would like to cherry-pick this in the cloud branch so that it will be included with the 7.7 release.

@amyblais Is the 7.7 release branch going to be cut from master? Maybe we don't need to cherrypick yet

v7.7 branch is planned to be cut tomorrow based off master.

Cherry pick is scheduled.


Configurable logging

Problem
Logging cannot be configured. We ran into a situation where logs became very verbose to the point of causing issues with our logging cloud provider (Datadog).
Changes

Added dependency to tslog
Added an instance of logger in logger.ts and removed the logging functions
Replace every use of the previous logger functions with calls to the logger exposed from logger.ts

The logger is configured with the following environment variabbles:

LOG_LEVEL (default is info)
LOG_TYPE (default is pretty; tslog also supports json)

Main branch dependencies

Hey. Thanks for the contribution!

looks like some functional tests fail..

Something is messed up with error logging from knex I think

Also when I do try to fix that knex-to-logger integration.. seems like it affects API output as well, it starts to include deep stacktraces, which I think it shouldn't

Thanks for checking @tot-ra ; it does look like tslog was interfering with some things like functional tests and knex. Considering that, I switched from it to winston since you mentioned it. Things look a lot more stable with it.
Like you mentioned, Winston supports defining custom transports but I configured it to use console output with either json or pretty formats. That allows us to filter by log level and also get structured json logs which is what we needed in the short term. Anyway, let me know!

Thanks again @francoislarochelle , released in 3.1.0


Typescript backticks color highlighting inside

I have noticed that when using this with Angular 2 and i write inline templates, there is not syntax coloring everything is in the same color, is there a way to enable coloring inside backticks?

@Component({
  selector: "ng2-app",
  template: `

      <top-navigation></top-navigation>

        <router-outlet></router-outlet>

  `,
  directives: [TopNavigationComponent, ArcListComponent]
})

Backticks are purely a template string, there is no inherent language that is used between backticks. Maybe there is a solution to detecting the language between the ticks, but that may not be desirable to have as an added process.

I think that may be very very desirable to have that feature. I have tried IntelliJ IDEA, that support that feature, and is fantastic. I hope that Atom supported too in the near future.

@ZombieHippie  As @albtdd presented, for angular 2 devs it will become a very desirable feature and its frustrating to not have a solution, when phpstorm/webstorm/intelli j idea have it out of the box already. I do not really like those programs as they are more memory heavy and the likes and it would be a very welcome feature if i want to stay with atom. So i hope someone does it a reality.

Very interesting, and cool! It would be neat to have a toggleable syntax
highlighting.
On Thu, 7 Apr 2016, 6:47 AM Petros Kyriakou<EMAIL_ADDRESS>wrote:

@ZombieHippie https://github.com/ZombieHippie As @albtdd
https://github.com/albtdd presented, for angular 2 devs it will become
a very desirable feature and its frustrating to not have a solution, when
phpstorm/webstorm/intelli j idea have it out of the box already. I do not
really like those programs as they are more memory heavy and the likes and
it would be a very welcome feature if i want to stay with atom. So i hope
someone does it a reality.
—
You are receiving this because you were mentioned.
Reply to this email directly or view it on GitHub
https://github.com/TypeStrong/atom-typescript/issues/892#issuecomment-206829976

Still waiting for this.

Hey @Deviad , I took a swing at this for you as it was an incredibly easy fix, my update is one commit ahead of the latest release tag and I have published my alternative version on atom.
https://atom.io/packages/atom-typescript-zh-backticks
If you use this version, you may need to rename your config keys. I don't very much wish to create a pull request for this, as I'm not entirely sure the way I did it is the "best way".

@ZombieHippie can you make this a standalone addon?

@pitops it's possible to release as a language, but I don't have time, and I don't actually know if it would work separated from the main package.

@ZombieHippie Hello, thank you very much for the time you've dedicated to this modification. I really appreciate it. Thank you!

You're welcome, I hope it works without issues. Otherwise, you can probably
patch the original package manually with that comparison I mentioned.
On Tue, 19 Apr 2016, 1:28 PM Davide Pugliese<EMAIL_ADDRESS>wrote:

@ZombieHippie https://github.com/ZombieHippie Hello, thank you very
much for the time you've dedicated to this modification. I really
appreciate it. Thank you!
—
You are receiving this because you were mentioned.
Reply to this email directly or view it on GitHub
https://github.com/TypeStrong/atom-typescript/issues/892#issuecomment-212057582

Hi,
https://github.com/TypeStrong/atom-typescript/pull/948 has added html-syntax-highlighting in Angular 2 Components.
Is this solution suitable for you?
Kinds
Greg

yep this can be closed now, at last official support cheers!

I am using atom-typescript v12 and it does not appear to have html-sytax-highlighting in components. Has this feature been removed since it was added in v8?

We currently lack resources to support our own grammar fork, and it created conflicts with Atom's bundled typescript grammar. So we ultimately opted to discontinue our grammar and let Atom team handle the grammar on their end. Sorry.
See https://github.com/TypeStrong/atom-typescript/blob/master/docs/faq.md#syntax-highlighting-is-bad


inconvenient handling of enums by bindgen

The following C header:
typedef enum {
  FOO = 1,
} my_enum;

void callWithEnum(my_enum e);

gets generated as:
/* automatically generated by clay-bindgen */

alias Enum_Unnamed1 = UInt;
alias FOO = 1;

alias my_enum = Opaque /* unknown EnumDecl  */;

external (cdecl) callWithEnum(arg0:my_enum) : ;

The problem is that callWithEnum expects a my_enum value as input. This is an alias to Opaque which is a Byte. The generated enums on the other hand are Ints, so type checking fails. It's of course possible to cast all enum values by hand, but it's very inconvenient.
How about something like:
alias Enum_Unnamed1 = UInt;
alias FOO = Enum_Unnamed1(1);
alias my_enum = Enum_Unnamed1;

Oh, I just saw that this is a duplicate of #21. Sorry about that.

It looks like a real bug in there. my_enum shouldn't be getting generated as Opaque, it should be aliased to the unnamed enum.


Fix the log2 function to return values

The passed in argument wasn't correct so it always returned null instead
of the appropriate value.
Fixes #9850.

Is there a test that should be added or updated here?

Are you saying you will add tests to this PR or a separate PR?
If it's this PR, I'll wait to approve. If it's a different PR that will happen later, I can approve this PR if you link back with an issue tracking the missing tests.

During a run of megacheck the following issues were discovered:

@mark-rushakoff I've added the unit tests. I found an issue with asin() and acos() in the current implementation so I've updated those too and updated the description.

During a run of megacheck the following issues were discovered:


SalesChannelMappingException when starting on port other than 80

version: "3"

services:

  shopware:
    # use either tag "latest" or any other version like "<IP_ADDRESS>", ...
    image: dockware/dev:latest
    container_name: shopware
    ports:
      - "180:80"
      - "13306:3306"
      - "122:22"
      - "18888:8888"
      - "19999:9999"
    volumes:
      - "db_volume:/var/lib/mysql"
      - "shop_volume:/var/www/html"
    networks:
      - web
    environment:
      # default = 0, recommended to be OFF for frontend devs
      - XDEBUG_ENABLED=1
      # default = latest PHP, optional = specific version
      - PHP_VERSION=8.1

volumes:
  db_volume:
    driver: local
  shop_volume:
    driver: local

networks:
  web:
    external: false

Unable to find a matching sales channel for the request: "http://localhost:180/". Please make sure the domain mapping is correct.

Shopware\Storefront\Framework\Routing\Exception\SalesChannelMappingException:
Unable to find a matching sales channel for the request: "http://localhost:180/". Please make sure the domain mapping is correct.

  at /var/www/html/vendor/shopware/storefront/Framework/Routing/RequestTransformer.php:113
  at Shopware\Storefront\Framework\Routing\RequestTransformer->transform()
     (/var/www/html/vendor/shopware/core/HttpKernel.php:123)
  at Shopware\Core\HttpKernel->doHandle()
     (/var/www/html/vendor/shopware/core/HttpKernel.php:65)
  at Shopware\Core\HttpKernel->handle()
     (/var/www/html/public/index.php:71)
  at Symfony\Component\HttpKernel\HttpKernelInterface@anonymous/var/www/html/public/index.php:61$0->handle()
     (/var/www/html/vendor/symfony/runtime/Runner/Symfony/HttpKernelRunner.php:35)
  at Symfony\Component\Runtime\Runner\Symfony\HttpKernelRunner->run()
     (/var/www/html/vendor/autoload_runtime.php:29)
  at require_once('/var/www/html/vendor/autoload_runtime.php')
     (/var/www/html/public/index.php:14)

The "dockware" project is heavily buggy and outdated...

Hi
there
so I think you have a bit of a different understanding of dockware as it is
so dockware is an environment for Shopware
Shopware comes with a default setting of port 80 HTTP
if you switch to another port, you need to change the domain and scheme in the administration,
thats not something dockware does for you, its only about running it, but we are not shopware
still, there is indeed an environment variable that does this for you (i think its SHOP_URL or SHOP_DOMAIN from the documentation)
maybe this helps you to understand the project a bit more

Thanks for your help!
Adding the env SHOP_DOMAIN did the trick - docs accordingly: https://docs.dockware.io/features/environment-variables

perfect
yes that one automates the manual step in shopware itself to adjust domains :) thanks for letting me know it works now


[C#] Fix Encloses failing on shared upper bound for AABB and Rect2(I)

C# version of:

https://github.com/godotengine/godot/pull/87118
https://github.com/godotengine/godot/pull/32478
https://github.com/godotengine/godot/pull/57469

3.x version:

#87265

Thanks!

Thank you!

Cherry-picked for 4.2.2.


Add methods to edit files with webhooks

Adds file and payload_json to UpdateWebhookMessage
ref: https://github.com/discord/discord-api-docs/pull/2720

The start method needs to be changed to handle payload json properly on this PR, similar to how message create does it. It's not ready

Eek, I forgot about this. It also seems that it's not handled under ExecuteWebhook. If I'm right, does this comes under the scope of this PR or a different PR?

I replaced "use file instead" and "use files instead" with "use `file` instead" and "use `files` instead" due to the former being ambiguous and reading as though a std::fs::File instance was somehow required.

I've re-targeted your PR to main, which is the new trunk and includes the 0.4 release. It looks like conflicts have been introduced.


Conversations not showing in Mac desktop app

Conversations are not showing in the Mac desktop app, I can see the preview on the feed, but when I click on any of them the post page appears blank, and I cannot read the message, even if I post a new conversation it won't apper.  It also happens if I go directly to the channel conversation tab It appears that there are no messages.   If I use the web version of the app everything is working correctly.
Attached is a screen shot with both desktop app and web app showing the error.

@JesusPenafiel - Could you please confirm if your issue has resolved or still looking for any help?


[main] Upgrade to latest dependencies

Cron -knative-prow-robot
/cc knative-sandbox/networking-wg-leads
/assign knative-sandbox/networking-wg-leads
Produced by: knative-sandbox/knobots/actions/update-deps
Details:
bumping knative.dev/networking 48ac02f...27525df:
  > 27525df upgrade to latest dependencies (# 624)
  > 1da6545 Update community files (# 625)
  > c8279cb Update actions (# 623)
  > 1934422 upgrade to latest dependencies (# 622)
  > 17e1877 upgrade to latest dependencies (# 621)
bumping golang.org/x/crypto 84f3576...8634188:
  > 8634188 acme/autocert: skip renewal tests broken on windows/arm64
  > 1e6e349 crypto/ssh: don't send the last auth failure message if disconnecting
  > f4118a5 acme/autocert: fix races in renewal tests
  > db63837 ssh: accept WSAECONNABORTED in TestClientAuthMaxAuthTriesPublicKey
  > dad3315 acme/autocert: include email in example
  > 2f5cac0 acme, sha3, ssh: fix the typos
  > 65fa2f7 acme: remove support for pre-RFC 8555 ACME spec
  > bba287d ocsp: fix typo
  > 20e1d8d ed25519: drop Go 1.12 compatibility
  > 30dcbda acme: expose Client KID field
  > 198e437 acme/autocert: replace all ACME server stubs with acmetest
  > aa10faf acme/autocert: renew Let's Encrypt certificates likely to get revoked
  > e04a857 ssh/agent: fix TestMalformedRequests
  > 5e0467b acme: in TestFetchCertCancel, do not reply before the cancellation propagates
  > e495a2d cryptobyte: fix parsing of large ASN.1 OIDs
  > 4570a08 internal/wycheproof: skip on builders with flaky network connections
  > 5770296 ssh: don't assume packet plaintext size
  > ae814b3 all: upgrade x/net to latest
  > b4de73f ssh: support RSA SHA-2 (RFC8332) signatures
  > ceb1ce7 ocsp: rewrite tests that rely on SHA1-RSA
  > 089bfa5 acme: implement Client.ListCertAlternates
bumping knative.dev/hack 0456e8b...e178598:
  > e178598 Update community files (# 157)
  > cf8cbc0 Fix the regex used for matching GitHub Actions files (# 156)
  > a8ef7b6 Skip presubmit tests for .github updates (# 154)
bumping knative.dev/pkg d481724...fe26417:
  > fe26417 Allow overriding lease name for a reconciler (# 2435)
  > 9b5c411 allow overriding the default grace period of 45 seconds (# 2423)
  > 4c2331f Bump golang.org/x/crypto (# 2444)
  > 708dc1c Update community files (# 2443)
  > 062ca30 upgrade to latest dependencies (# 2433)
  > 4fcbc1b Update actions (# 2434)
  > 80c511a Wait for reconciler/controllers to return prior to exiting the process (# 2437)

/lgtm
/approve

/lgtm
/approve


Native node modules from extensions

I’m looking to build an extension but one of the packages I need to depend on is a native module. When I do an npm install it installs the package just fine, I can launch a node shell and interact with it, etc. But when I go to use the package from within my plugin I get an error as it’s trying to load the ia32 build of the native module not the x64 which was compiled by node-gyp.
A quick bit of debugging indicates that the problem stems by process.arch returning ia32 when running in VS Code when my machine is a x64 machine (Win10 x64).
So is there some way to either:

Have VS Code run an x64 process
Have VS Code’s ia32 process do my npm restore (and subsequent compile with node-gyp)

Otherwise I fear that my extension might be dead in the water :frowning:

I'm doing some more investigation on this to see if I can unblock myself by getting an ia32 version of the module loaded, so I installed the x86 version of node.js, installed the native module (which in turned got the right binary).
Now I get the following error:

Are native modules not supported in extensions?

The good: Nothing really.
The bad: Code extensions unfortunately don't support native extensions.
The ugly: There is a workaround. Bear with me:

The extension package must contain the binaries for all platforms Code supports: win32-ia32, darwin, linux-ia32 and linux-x64.
It must also dynamically require the correct binary for the running platform at runtime. bindings might help you there.
You must find a way to compile all those platforms into your extension package and they must be compiled against the exact same version of node and v8 that Code is. Specifically:

npm_config_disturl=https://atom.io/download/atom-shell
npm_config_target= whatever value is there on electronVersion
HOME= something other that ~, like ~/.electron-gyp, so node-gyp and npm don't confuse themselves.

Yeah I just came across this walkthrough which somewhat outlines the "ugly" side of things :stuck_out_tongue:.
Native modules are a pain, but I might keep at it and see where I can get to (or see if the native module can be reimplemented in "plain ol' JavaScript", but somehow I don't expect it to be possible.

We use the npm way in our build scripts, btw.

I've been playing around with the easy way and got this far:

electron-rebuild generated a binary output
My extension still failed as the path was not matching the generated output
Modified the folder of the generated output and it worked

So - I now have a "working" native node package running in a VSCode extension. But I was curious as to why it wanted a folder of node-v46... to load the binary. It seems that the logic to load the binary uses the node-gyp build/versioning lookup which might be somewhat broken in VSCode. The failure is that internally it does some checks to whether it's node, node-wekbit or electron, but process.versions.electron is undefined in the VSCode plugin. My guess is that because the extension is running out-of-process it's not getting that passed through, which in turn makes it a little unhappy.
Anyway I can at least get the extension launched, so chalk that up to success number 1 :grin:.

I've hit another problem that I'm not sure if it's related to it being a native module or if it's another bug, the native module is being reported as not found by VSCode's editor and the TypeScript compiler (when running the package step).
If I run from the debugger it works just fine, the native module is loaded, executed, etc, so I know it's there, but tsc doesn't seem to locate it. I think it's a TypeScript issue than a VSCode issue, but I can't find any info on it. Is it known at the VSCode end?

It seems that you just need TypeScript typings to go along your native module. Try placing a file in your extension similar to this:
mylib.d.ts
declare module 'mylib' {
    export function foo(arg: number): void;
}

Then, both VSCode and TypeScript would drop the errors when you'd import the module:
import * as mylib from 'mylib';

ah, I didn't realise you need to have everything with a .d.ts. All sorted and now it's on the marketplace - https://marketplace.visualstudio.com/items/aaronpowell.vscode-espruino (although I'm not sure it'll be installable for anyone else yet).
Is there any way (easy or ugly) to work out the version of Electron when installing a plugin?

You must always compile it against the version of Electron that VSCode depends on, considering the VSCode version you're targeting against. So, for 0.10.3 it is 0.34.1.

Yeah I found that out, I'm just trying to avoid shipping a precompiled version of serialport and instead compile it as an install step, but I need to work out what version of VSCode is running (and that tells me what version of Electron)

Very tricky and it's exactly the reason why we haven't tackled this yet: every user that would install your extension would need the build tooling installed in their system (VS, gcc, etc.).

Yeah that's a fair point, I guess shipping the compiled module in my extension is probably a good idea (or at least the binary) and get it done for each platform.
I might be able to make an assumption of the build tools (given that it's work working with microprocessors) but it's solid assumption.

Is there a mechanism for downloading precompiled binaries as part of the build process, such that extension creators could use a tool to pre-compile an array binaries for different platform and node version targets - and the build process would bring down the appropriate binary and link it?

node-pre-gyp exists for that purpose when dealing with node modules. But upon installation, we don't call npm install on an extension.

So Atom's apm 1.10 beta seems to ship with node and npm now, likely to avoid these exact issues http://blog.atom.io/2016/08/01/atom-1-9-and-1-10-beta.html

Yep... it's starting to feel inevitable by now.

I haven't done much with this for a while but my current thinking is that instead of trying to load the native module within the electron shell I think it'll be better to use spawn and uxe the native module from the default node.js install (which obviously requires there to be a node.js install).
I'm thinking this because it seems that the electron-rebuild module no longer works on Windows or with the version of electron being used.

Is there anyway to see the error messages upon faulty loading?
I am trying to make a language server that makes use of a native module. I've followed the steps outlined here and here and have arrived at a module that can be loaded from the extension. So far so good.
However, when my extension starts the server that tries to reference the same native module I get "The Swift server crashed 5 times in the last 3 minutes. The server will not be restarted."
This does not exactly give me a lot to go on to try and resolve where it is going wrong. And the process is dead before I have a chance to attach a debugger to it. If I could just get some messaging about what/why the server is dying that may help me crack the case.

@RLovelett the problem is now that the version of Electron used in VSCode is a bit out of date (0.37.6 in the insider build of 2016-08-17 that I'm running). It seems that electron-rebuild no longer works with that version (the problem is with nslog dependency) and I'm not sure if it's being maintained.
This is why, for me, I'm thinking of running node in a separate process and passing messages back and forth so I can use a "standard" version of node, rather than the forked version used by electron. Not sure if that'd work in your scenario though.

Is this thread still up to date or have things changed since 2016? I see the mention of Atom shipping with Node and NPM, has VS Code started doing the same or is depending on native modules still cumbersome?

I'm maintaining a debugger which requires several native libraries. It requires me to push a new version everytime VSCode updates its Electron runtime (which 1.29 did again, from 2.0.5 to 2.0.12, which was preventing my precompiled extensions to load).
This is far from ideal, and while I understand this only concern a few extensions, maybe there should be a standard way to trigger an installation script so we can deal with it ourselves?

While I can't promise adding any support to make it easier to use native modules, we can add some documentations for the current state: https://github.com/Microsoft/vscode-docs/issues/2211

The Extension Authors section of Roadmap 2019 includes:

:runner: Enable extensions to install additional platform specific components at extension installation time.

would this address this issue?

I recently tried compiling a Node.js native extension, Edge.JS.
VSCode version was 1.36.1.
Node.JS version inside VSCode was 10.11.0.
I built edge.js from src using node.exe 10.11.0 for target node version 10.11.0.
Edge.js native extension is used in a "hello world" type vscode extension.  VSCode Extension Host could not load my built edge.js bits.  The error was " not a valid Win32 Application".
Any help would be greatly appreciated, thanks.

Has any progress been made on the subject ? I have an extension that communicate over Bluetooth communication with an IoT device, using the   @abandonware/noble module, which partly relies on native modules. Everything works fine in the debug extension host, because I can npm install everything, which will take care of compiling the native modules, but no such thing occurs when installing the extension from the marketplace in a plain VS Code session.
If I wanted to explicitely provide the pre-compiled modules, how would I do that with my extension package ? Any help appreciated. Thanks.

Regarding Bluetooth low energy specifically, I wonder if it could be possible to use Web Bluetooth via a webview (probably worth opening a new issue for that).

Any updates for this?

I switched my native dependencies such as ffi to ffi-napi which uses NodeJS API, which seems to be forward compatible so new electron versions no longer breaks the plugin.

I am also dealing with this issue, and there is one thing I do not quite understand why: wouldn't it be easy and perfectly acceptable for vscode to just rebuild all extensions while installing using
npm rebuild --nodedir=/path/to/electron/vendor/node

just as recommended in https://github.com/electron/electron/blob/master/docs/tutorial/using-native-node-modules.md, as this command would do nothing for packages without native node modules, and fix all the issues with the others? I believe it is natural to expect for vscode to fix the node dependency issues since it does not provide access for electron's node to the extension developers, so it should act as a black box.

hi moderators,
I could rebuild locally and test out my extension. But if I pack and publish it, it doesn't work in the client's machine. Please do let me know if you guys have any solution for publishing.
Thanks!

@ganezdragon for what it's worth, I ask my users to go to the extension folder (~/.vscode/extensions/your-extensions-name-and-version on my Windows machine) after installation/updated, open a terminal there, and type npm install at the command prompt. This will fully rebuild the extension, including compiling the native parts. You have to redo this with every update, but so far it has worked for me every time. You just have to make sure the version of electron you reference tracks the Node.js ABI version, but if you can compile your extension locally, that is normally taken care of.
Good luck...

@pythoulon thanks for the approach. Yea then I would have to go with this, and hope the users have necessary gcc also to compile it. Or  I would have to look at some web bindings (but that has its problem of its own).
But thanks for the quick response pythoulon.

@ganezdragon @pythoulon - Have either of you tried prebuilding your native node module with prebuildify and then including the binaries in the published npm package? You can use this approach to avoid making your users run npm install inside your extension folder. Make sure you are publishing prebuilds for all platforms and architectures that VS Code supports.

@bmealhouse, nope I haven't tried it. Let me try it out today and see how that works! Much thanks for telling us about the library.

@bmealhouse Will try it as soon as I get a chance. @ganezdragon please report here on your experience, if you can... Thanks.

@bmealhouse Finally got a chance to take a look at prebuildify. The problem I have is that my extension module is not native per se, but it depends on a couple of native modules. I'm not sure how to use prebuildify in that context. Ideally I would like to deliver my module with the prebuilt versions of those modules (which, as far as I understand, do not come with prebuilt binaries).
Anybody has experience on the matter ? Thanks.

@pythoulon - You could fork those native modules and prebuildify them for VS code.

@bmealhouse Thanks for the hint. Hadn't thought of it... Will try that.

I'm running into this issue currently. In particular, I'm trying to use nodegit which has a native dependency on libgit2. At first I was seeing some NODE_MODULE_VERSION mismatch errors. Those were resolved by downgrading my node version to 15.x.
But now I'm seeing an error:
Module did not self-register: '/Users/skainswo/dev/cuddlefish/vscode-extension/node_modules/nodegit/build/Release/nodegit.node'..

Is there a plan for a more robust native dependency solution for VSCode extensions?

I need help implementing this in a sane manner over at vscode-textmate. For some reason, even vscode-test and the getCoreNodeModule snippet refuse to work.

I found a solution:
'use strict';

import vscode from 'vscode';

/**
 * Returns a node module installed with VSCode, or undefined if it fails.
 */
export default function<T>(id: string): T | null {
	try {
	  return require(`${vscode.env.appRoot}/node_modules.asar/${id}`);
	} catch (err) {
		// ignore
	}

	try {
	  return require(`${vscode.env.appRoot}/node_modules/${id}`);
	} catch (err) {
		// ignore
	}

	return null;
}


fix(paeckchen-core): error during rebundle must be thrown

Coverage remained the same at 100.0% when pulling<PHONE_NUMBER>772e87a5b9627c637c2fa2001bc61e on core/rebundle-error into 4a4f37240258ef32affed279cae3b6d0edbcbd5a on master.


Add method constants to request options

This solves feature suggestion in #2145

There are no benefits added by merging this. See #2145.


v2.8.1 fails to deploy SCPs

Describe the bug
When deploying an manifest with SCP resources using v2.8.1 the SCP deploy stage fails with the following:
********************************************************
--
1441 | State Machine Execution(s) Failed.
1442 | Navigate to the AWS Step Functions console
1443 | and review the following State Machine Executions.
1444 | ARN List:
1445 | ['arn:aws:states:us-east-2:<ecnsored>:execution:CustomControlTowerServiceControlPolicyMachine:Create-enforce-mfa-2024-12-17T03-17-44']
1446 | ********************************************************}

The corresponding Step Function log for CustomControlTowerServiceControlPolicyMachine is:
{
  "errorMessage": "Unable to import module 'state_machine_router': cannot import name 'ResourceControlPolicy' from 'cfct.state_machine_handler' (/var/task/cfct/state_machine_handler.py)",
  "errorType": "Runtime.ImportModuleError",
  "requestId": "",
  "stackTrace": []
}

The stack was built and uploaded per the README. I thought it might be line-ending related so I ran dos2unix on the source .py and .sh files just in case that was the issue (I'm on a Mac), then re-ran the build command and tore down and rebuilt the stack (to ensure a clean slate), but it made no difference.
To Reproduce
Deploy any CfCT manifest that includes an SCP resource.
Expected behavior
The SCP should deploy successfully (as it did under v2.7.3).
Please complete the following information about the solution:

[ ] Version: v2.8.1
[ ] Region: us-east-2
[ ] Was the solution modified from the version published on this repository?  - Initially no, but even after adjusting for line endings, the issue still persisted
[ ] If the answer to the previous question was yes, are the changes available on GitHub? - no
[ ] Have you checked your service quotas for the sevices this solution uses? - n/a
[ ] Were there any errors in the CloudWatch Logs? - see report above re: step function logs

Additional context
This prevents any manifest including SCPs from deploying. A major blocker!

User error. It was line endings. I ran dos2unix on all .py and .sh files in the repo before doing another rebuild and this time it worked.


Add simulation statistics for load and store

Currently the processor does not update its statistics counter for Load/Store count, idle cycles and cache miss count.
On a load/store instruction AND the current state is Nothing --> INCREMENT l/s counter
On ANY non load/store --> increment the IDLE cycles
If we receive load/store AND we are on a Nothing state --> increment the cache miss count

Completed in 577bad7


Version
4.5.11
Environment info
System:
    OS: Windows 10 10.0.19041
    CPU: (4) x64 Intel(R) Core(TM) i5-6600K CPU @ 3.50GHz
  Binaries:
    Node: 15.7.0 - C:\Program Files\nodejs\node.EXE
    Yarn: Not Found
    npm: 7.4.3 - C:\Program Files\nodejs\npm.CMD
  Browsers:
    Chrome: Not Found
    Edge: Spartan (44.19041.423.0), Chromium (88.0.705.68)
  npmGlobalPackages:
    @vue/cli: Not Found

Steps to reproduce
Create new project with vue create testing (select vue3)
In App.vue change <script></script> block to
<script setup>
/* eslint-disable */
import HelloWorld from "./components/HelloWorld.vue";
</script>

works:
Run: npm run serve   -> Everything works as expected;
does not work:
Run: npm run build
Serve dist directory (e.g. http-server)  -> nothing gets rendered
What is expected?
Render App
What is actually happening?
App does not get rendered

I somehow have the feeling, that this was working before. This is only happening on the root App component.
When I look the imported object, I don't see any render function.
Cheers!

me too
when i use

一样的问题

Downgrade from 3.0.11 to vue 3.0.0 and adding code above solved problem in my case.

Just got stuck on this issue for hours, trying to reproduce it locally, where I usually only do development builds. I guess that is what you get for using experimental features :disappointed:
The reason, it is so hard to pin-point, is that after a local development build the node_modules/.cache is primed with correct compilation results. Then in the production build, some of these are reused and yield a correct build. Only when you delete the cache (or run npm ci) and directly start the production build, will you get the error locally.

I have the same problem, I try the following way, works for me
Using Vue 3.1.4:
<script lang='ts' setup>
  ...
</script>

<template>
  ...
</template>

But I don't know why the following way can be used to build successfully in vite, but in Vue cli, the value of template refs is undefined after build
<template>
  <Header ref="header"></Header>
</template>

<script lang='ts' setup>
  import Header from<EMAIL_ADDRESS>  const header = ref(); // header.value is undefined
</script>

@XHalso: Your question seems offtopic. My guess would be, that the ref is only available after the component was mounted, not during setup(). If you have further question please come join us in discord!

@XHalso: Your question seems offtopic. My guess would be, that the ref is only available after the component was mounted, not during setup(). If you have further question please come join us in discord!

There is something wrong with the above example code, but I did build it, and in onmounted, template refs is undefined

run:
$ yarn add vue-loader --dev

can solve.
https://github.com/vuejs/vue-loader/issues/1838

run:
$ yarn add vue-loader --dev

can solve.
vuejs/vue-loader#1838

this works for me.

I think this issue is fixed since<EMAIL_ADDRESS>if it's indeed caused by the thread-loader bug mentioned above.

I can confirm that it was fixed for me, but the relevant commit is only included since<EMAIL_ADDRESS>

run:
$ yarn add vue-loader --dev

can solve.
vuejs/vue-loader#1838

run:
$ yarn add vue-loader --dev

can solve.
vuejs/vue-loader#1838

work for<EMAIL_ADDRESS>when using setup script.

its not working

@sodatea its not working

For anyone still having the issue. I am working with yarn and Vue CLI, and I solved the problem by adding the following snippet to my package.json :
"resolutions": {
  "vue-loader": "^16.8.1"
}

I believe this is necessary because @vue/cli-service is using its own vue-loader version.

After failing with vue-loader@latest instalation i decided to update everything to the latest and it worked. By everything i mean:
vue, @vue/cli-service, @vue/comiler-sfc, vue-loader


[html] support imports in embedded JavaScript

VSCode Version: 1.52.1
OS Version: Windows 10.0.19042.685

Steps to Reproduce:

Create a HTML File with <script type="module">...</script>
Add // @ts-check and import any npm package
No intellisense

Does this issue occur when all extensions are disabled?: Yes
If we would do the same steps with a .js file, IntelliSense will work:

It is not working in .html however:

Error:
Cannot find module 'hydro-js'. Did you mean to set the 'moduleResolution' option to 'node', or to add aliases to the 'paths' option?javascript
Tried troubleshooting:

Created a jsconfig.json file
Tried the above error suggestions.

There's currently no plan to add cross-file support for HTML editing.
https://github.com/microsoft/vscode/issues/47331 is the main issue

There's currently no plan to add cross-file support for HTML editing.
https://github.com/microsoft/vscode/issues/47331 is the main issue

The principle of JSDoc is to document JavaScript code and help developers in the IDE. It doesn't matter where the JavaScript is located. Not supporting import in HTML files is a HUGE ISSUE. The HTML file is the originator of the JavaScript. Please plan to add this functionality, or let me contact the person who has it in its power and I may be able to change your priorities.
Thank you

vscode

webstorm

Window is the default type that does not compute?

There's currently no plan to add cross-file support for HTML editing.

is that still true?
if it is - I assume it's because it's hard to support... anyone got any hints why it's hard? I feels like it could "just" be a virtual js file (at the same file location) and then let the "normal" JS completion "handle it".
but yeah that doesn't work... I tried with embedded request forwarding
but even for the "simplest case"
👉 foo.js
export const foo = { on: 'foo', off: 'baz' }

👉 index.html
<script type="module">
   import { foo } from './foo.js';
   foo.o // no autocomplete for on/off
</script>

it won't follow imports 🙈
here is the relevant code for the request forwarding... am I doing something wrong? (I hope I do - or is it not supposed to work)
	workspace.registerTextDocumentContentProvider('embedded-content', {
		provideTextDocumentContent: uri => {
			const originalUri = uri.path.slice(1).slice(0, -3);
			const decodedUri = decodeURIComponent(originalUri);
			return virtualDocumentContents.get(decodedUri);
		}
	});

	const clientOptions: LanguageClientOptions = {
		documentSelector: [{ scheme: 'file', language: 'html1' }],
		middleware: {
			provideCompletionItem: async (document, position, context, token, next) => {
				const region = getDocumentRegions(htmlLanguageService, document);
				const type = region.getLanguageAtPosition(position);
				if (type === 'javascript') {
					const js = region.getEmbeddedDocument('javascript');
					const originalUri = document.uri.toString(true);
					virtualDocumentContents.set(originalUri, js.getText());
					const vdocUriString = `embedded-content://js/${encodeURIComponent(
						originalUri
					)}.js`;
					const vdocUri = Uri.parse(vdocUriString);
					return await commands.executeCommand<CompletionList>(
						'vscode.executeCompletionItemProvider',
						vdocUri,
						position,
						context.triggerCharacter
					);
				}


CLOUD-763 more detailed logging for the azure image creation

@keyki

Jenkins build finished, all tests passed.
Refer to this link for build results: http://ci.sequenceiq.com/job/cloudbreak-pull-request/1178/

Jenkins build finished, all tests passed.
Refer to this link for build results: http://ci.sequenceiq.com/job/cloudbreak-pull-request/1180/

Jenkins build finished, all tests passed.
Refer to this link for build results: http://ci.sequenceiq.com/job/cloudbreak-pull-request/1181/


Communication with IoT hub stops after some hours.

Hello,
I'm using the OpcPublisher with my IoT hub as a standalone application and the Mqtt protocol.
My problem is that after a few hours of operation I'm receiving the following error:
Connection status changed to 'Disconnected', reason 'Retry_Expired'
After this, the communication with IoT hub is completely lost and the msg send failures counter in the OpcPublisher status output starts to increase.
Before there were also several messages (repeated almost hourly) like this:
Connection status changed to 'Disconnected_Retrying', reason 'Communication_Error'
What could be reason for this? There were no such problems occurring in former versions of the publisher (half a year ago).
Any help appreciated.
Thanks
Hartmut

are you using the code of the latest tag 2.3.3? this issue is bubbling up from IoT SDK. First thing i would try if you use the latest code is try to switch to Amqp_Websocket_Only

Yes, I'm using the latest version 2.3.3. I switched to Amqp_Websocket_Only and it seems to be better (still receiving [ERR] Connection status changed to 'Disconnected_Retrying', reason 'Communication_Error', but not that frequently as before (one or two per day). So I guess I will finally run into the same problem, but only later... ?

Let it run and update the issue if you hit the problem again.

We discovered the same issue with Amqp_WebSocket_Only as well. It just doesn't happens as frequently as when using MQTT.
2019-03-11 01:28:46.512 +01:00 [INF] ==========================================================================
2019-03-11 01:30:56.320 +01:00 [ERR] Connection status changed to 'Disconnected', reason 'Retry_Expired'
2019-03-11 01:33:46.510 +01:00 [INF] ==========================================================================
Anyhow, is it really necessary to stop the communication after a certain number of unsuccessful retries?

With Devices.Client version 1.20.1 there is a slightly different behavior, it first reports the following for several times:
2019-06-13 23:24:22.941 +02:00 [ERR] Connection status changed to 'Disconnected_Retrying', reason 'Communication_Error'
2019-06-13 23:24:51.081 +02:00 [INF] Connection status changed to 'Connected', reason 'Connection_Ok'
After about 60 disconnected/retries which take place over time, there is one final status changed message:
2019-06-13 23:58:59.972 +02:00 [ERR] Connection status changed to 'Disconnected_Retrying', reason 'Communication_Error'
2019-06-13 23:59:19.722 +02:00 [ERR] Connection status changed to 'Disconnected', reason 'Communication_Error'
After this, the communication won't be established again and I do have to restart the opc publisher.
What can be causing this and how could it be solved?
Any help appreciated!


[SPARK-49351] Add publish_snapshot_chart.yml GitHub Action job

What changes were proposed in this pull request?
This PR aims to add publish_snapshot_chart.yml GitHub Action job.
ASF INFRA Reference.

https://github.com/apache/infrastructure-test/blob/master/.github/workflows/nightlies.yml

Why are the changes needed?
To provide a daily snapshot of HelmChart.
Does this PR introduce any user-facing change?
No.
How was this patch tested?
Manual review. We need to merge and test because the credentials work only inside commit environment.
Was this patch authored or co-authored using generative AI tooling?
No.

Let me merge this~ Thank you!

I verified this pipeline and filed INFRA JIRA. Currently, this is blocked by https://issues.apache.org/jira/browse/INFRA-26062
/INFRA-26062: Add `NIGHTLIES_USER` and `NIGHTLIES_TOKEN` to `spark-kubernetes-operator` repo


[SSL: CERTIFICATE_VERIFY_FAILED] certificate verify failed (_ssl.c:749)

It keeps giving me this error even when I just pass a url in the Youtube class constructer.
from pytube import YouTube
yt = YouTube("http://www.youtube.com/watch?v=Ik-RsDGPI5Y")

i getting this exceptions also.
pytube: Version-9.0.6
OS: macOS 10.12.6 (16G1114)
Kernal Version: Kernel Version:	Darwin 16.7.0

#metoo. I guess it's an python or os error.

The solution is: use python 3.5 not python 3.6.
I created a full example here


Remove browserify build

browserify is no longer actively maintained
TODO: why can we not just use microbundle on its own? ideally the index.modern.js just works, but from my tests I need to put that through esbuild in order to generate a script that I can include directly in the browser

Ideally we can do:
<script type="module">
      import {LightningAddress} from 'https://cdn.skypack.dev/@getalby/lightning-tools';
      // use LightningAddress normally...
</script>

Currently we get an error:
node:crypto?from=crypto-js:14 Uncaught Error: [Package Error] "crypto" does not exist. (Imported by "crypto-js").
at node:crypto?from=crypto-js:14:7
(anonymous) @ node:crypto?from=crypto-js:14

Done - updated example in the README!


Allowing dynamic max value

If max was changed after the progress bar was created, the value of max in the progress bar was not updated.
This update will allow the user to dynamically change the max value and update the progress bar correctly.

Will reopen after running further tests.


Simulator cURL command gets pushed off the screen if the payload is too long

if you enter a sample payload that is long enough, the curl command section gets pushed off the screen and you can not scroll to it.

This is fixed :)


Linter stopped working unexpectedly.

Linter was working two days ago and stopped unexpectedly.  I checked all output items for errors and couldn't find any issues reported.
Today I uninstalled all of the Code for IBM i extensions and reinstalled.  No effect.
Finally found when I hovered over the gear to to get the version of RPGLE language tools to report this, 13 of these messages:
Activation time : 4ms
Uncaught Errors (13)
Cannot read property 'procedures' of undefined
My RPGLINT.JSON file.  FYI, I deleted it and let the program recreate it.
{
"BlankStructNamesCheck": true,
"QualifiedCheck": true,
"PrototypeCheck": true,
"ForceOptionalParens": true,
"NoOCCURS": true,
"NoSELECTAll": true,
"UppercaseConstants": true,
"IncorrectVariableCase": true,
"StringLiteralDupe": true,
"NoSQLJoins": true,
"NoCTDATA": true,
"PrettyComments": true,
"NoGlobalSubroutines": true,
"NoLocalSubroutines": true,
"UppercaseDirectives": true
}
version v0.6.1 for the RPGLE Language tools extension
version v0.9.1 for Code for IBM i extension
Thanks,
Howard

Strange. So it crashes even before you open any code? Does it crash when you open a specific member? Are you able to share the code it crashed with?

I think I may have found the issue.  But it is weird that it worked before.  If I comment out "/COPY" code that is not written as **FREE, the linter kicks in with no problems.  So I guess I just need to convert the copy code and all will be right in the world.
Thanks for prompting me to dig deeper.  I gave up trying to figure it out too soon.
Howard

Strange! The linter should continue working even if you have a copybook that is not free format. I will see if I can find something out too later.

Well now I am completely confused.  I put the copy books back in one at a time just to test which one kills the process.  The linter continued to work, but it is getting the uncaught exceptions again.

@Hadkins2 Would you be willing to share the code? Sharing privately is an option too.

I think I have found the issue.
In each of the copybooks, it appears the original programmer included comments in the copybook code, but didn't want to that carry into the source code of the program using it and used the /EOF compiler directive to make it stop reading the copybook.
Here is the offending copybook.
D UPPERCASE       PR          4096    Varying
D   String                    4096    Const Varying
D   Escaped                       n   Const Options(*NoPass)
 /EoF
       Converts all of the letters in String to their
       UPPER CASE equivalents.  Non-alphabetic characters
       remain unchanged.

       Escaped = *ON = converts characters that would crash iPDF and
                       HTML to approximately equivalent characters.
                       For example, translate " and ' to ` .
                       (Default)
                 *OFF= Do not convert any characters other than A-Z.

H BNDDIR('WVWEB/COMMON')
 /Copy WVPROT/format,UPPERCASE

Some of the other copy books have /IF directives in them as well.  I put an asterisk in column 7 in this copybook and the linter was happy.
Howard

@Hadkins2 Ha, great find! I will work on the /EOF support right now.

Fix coming out in just a few minutes :)

@Hadkins2 GIve it a go in 0.6.2 and let me know.

Hey @Hadkins2
Did you get to try this out yet?
Thanks!

Apologies for the delay.  I did get the update the next morning and it didn't resolve the issue.  There has to be something wrong with the copybooks and not the linter.  I made copies of the copybooks and removed everything but the actual code and it still was giving me issues.  I got in a sort of a time crunch and couldn't spend more time on it now.  I resolved my issue by copying the code from the two offending copybooks into the copybook I use for Data Structure Templates in this program (a nice tip I learned from your YT videos) and converted them to **FREE.  They are working just fine now.  I will circle back to this once I have met the deadline on this project.
I will keep you updated.
Howard


Dependency on ethabi code

There is a dependency on ethabi that is not documented. The code uses it to provide context for the 'function' field which unpacks or de-compiles the 'input' field.

Moved to https://github.com/Great-Hill-Corporation/quickBlocks/issues/75


macOS branch remastering

Thanks @vasily-v-ryabov ! What is remaining in order for this to be merged?

First conflicts should be resolved, also Circle CI should be used with SIP-disabled image to enable accessibility programmatically, then setup.py review is necessary to update actual pyobjc versions that work on the vast majority of macOS versions.


Mutex debug

experimental test to see if we can have a test mode that verifies
mutexes lock in the order we want, while having no hit on production
performance. Since this uses a build tag, it should all compile out
during the build process and be a no-op unless the tag is set.
This ensures that all locks are grabbed in this order:
- hostinfo
- pending hostmap
- main hostmap

If the locks are grabbed in a different order than this, the debug mutex will panic.

It looks like the test is finding a case where we have two hostinfo locks at the same time, during a relay flow:
We need to decide if this is okay, or if there is the potential for deadlock.
panic: grabbing hostinfo lock and already have a hostinfo lock: state=map[{hostinfo  176160770}:true {hostmap main 0}:false {hostmap pending 0}:false] add={hostinfo  176160896}

goroutine 69 [running]:
github.com/slackhq/nebula.checkMutex(0xc00039f7a0, {{0xc8da0f, 0x8}, {0x0, 0x0}, 0xa800080})
	/home/runner/work/nebula/nebula/mutex_debug.go:38 +0x433
github.com/slackhq/nebula.(*syncRWMutex).Lock(0xc0004974a0)
	/home/runner/work/nebula/nebula/mutex_debug.go:56 +0x90
github.com/slackhq/nebula.(*Interface).getOrHandshake(0xc000295b00, 0x20?)
	/home/runner/work/nebula/nebula/inside.go:140 +0x10b
github.com/slackhq/nebula.(*Interface).Handshake(0xc0005292d0?, 0x4?)
	/home/runner/work/nebula/nebula/inside.go:113 +0x19
github.com/slackhq/nebula.(*HandshakeManager).handleOutbound(0xc0000f0fc0, 0xa800002, {0xde3370, 0xc000295b00}, 0x0)
	/home/runner/work/nebula/nebula/handshake_manager.go:210 +0x163f
github.com/slackhq/nebula.(*HandshakeManager).NextOutboundHandshakeTimerTick(0xc0000f0fc0, {0xc0003f5f24?, 0x0?, 0x12d62e0?}, {0xde3370, 0xc000295b00})
	/home/runner/work/nebula/nebula/handshake_manager.go:99 +0x6b
github.com/slackhq/nebula.(*HandshakeManager).Run(0xc0000f0fc0, {0xde2810, 0xc000264ff0}, {0xde3370, 0xc000295b00})
	/home/runner/work/nebula/nebula/handshake_manager.go:87 +0x1a5
created by github.com/slackhq/nebula.Main
	/home/runner/work/nebula/nebula/main.go:323 +0x263d
FAIL	github.com/slackhq/nebula/e2e	24.670s
FAIL
make: *** [Makefile:58: e2e-mutex-debug] Error 1


Which version of mysql does this app use?

I use mysql 5.6, and got some error while migrating database.
[[Illuminate\Database\QueryException]
  SQLSTATE[42000]: Syntax error or access violation: 1064 You have an error in your SQL syntax; check the manual that corresponds to your
  MySQL server version for the right syntax to use near 'json not null, `custom_properties` json not null, `order_column` int unsigned nu'
   at line 1 (SQL: create table `media` (`id` int unsigned not null auto_increment primary key, `model_id` int unsigned not null, `model_t
  ype` varchar(191) not null, `collection_name` varchar(191) not null, `name` varchar(191) not null, `file_name` varchar(191) not null, `m
  ime_type` varchar(191) null, `disk` varchar(191) not null, `size` int unsigned not null, `manipulations` json not null, `custom_properti
  es` json not null, `order_column` int unsigned null, `created_at` timestamp null, `updated_at` timestamp null) default character set utf
  8mb4 collate utf8mb4_unicode_ci)

  [PDOException]
  SQLSTATE[42000]: Syntax error or access violation: 1064 You have an error in your SQL syntax; check the manual that corresponds to your
  MySQL server version for the right syntax to use near 'json not null, `custom_properties` json not null, `order_column` int unsigned nu'
   at line 1

The app creates a database table with the json-type. That type is only available on MySQL 5.7+
https://dev.mysql.com/doc/refman/5.7/en/json.html
You would need to update your database server to use the app.
(Note: The app is quite old and was just an example project for a blog post of mine. I don't have any plans to update the code to run on latest PHP or MySQL or fix any open issues. The end-to-end encryption is also not perfect and has many flaws. So use the app with caution.)


Updates from 2.22 ECMPS PD meeting

Please make the following updates to the existing prototype:

Remove the Import button from Mobile and Tablet screens
Remove the Export button from Mobile and Tablet screens

Provide xd links for:
Export-Import Buttons - Shared Xd Link
https://xd.adobe.com/view/723aace9-e677-4706-9cb2-ad9600ebf883-2769/
Import Monitoring plan pop-up modal - Shared Xd Link
https://xd.adobe.com/view/a6e86bca-668f-4047-b9e6-b2dfab8210aa-f3bb/

Export-Import Buttons - shared xd document link/WFs
https://xd.adobe.com/view/723aace9-e677-4706-9cb2-ad9600ebf883-2769/


mqtt.Bridge can't setup connection to mqtt.EMQX

Versions
Nucleus                                                       2.11.3
aws.greengrass.clientdevices.mqtt.Bridge  2.3.0
aws.greengrass.clientdevices.mqtt.EMQX   2.0.0
aws.greengrass.clientdevices.mqtt.Bridge error
2023-11-07T11:39:21.870Z [ERROR] (Thread-9) com.aws.greengrass.mqtt.bridge.clients.LocalMqtt5Client: Failed to connect to broker. {clientId=mqtt-bridge-yms46rfm5e3, brokerUri=ssl://ip-10-158-15-230:1225, error=TLS (SSL) negotiation failed}
aws.greengrass.clientdevices.mqtt.EMQX error
2023-11-07T11:39:21.871Z [INFO] (Copier) aws.greengrass.clientdevices.mqtt.EMQX: stdout. 2023-11-07T11:39:21.871094+00:00 [error] supervisor: 'esockd_connection_sup - <0.2372.0>', errorContext: connection_shutdown, reason: {ssl_error,{tls_alert,{bad_record_mac,"TLS server: In state wait_cert at tls_record_1_3.erl:204 generated SERVER ALERT: Fatal - Bad Record MAC\n {record_type_mismatch,21}"}}}, offender: [{pid,<0.2593.0>},{name,connection},{mfargs,{emqx_connection,start_link,[#{enable_authn => true,limiter => undefined,listener => {ssl,default},zone => default}]}}]. {scriptName=services.aws.greengrass.clientdevices.mqtt.EMQX.lifecycle.startup.script, serviceName=aws.greengrass.clientdevices.mqtt.EMQX, currentState=RUNNING}
Environment
Greengrass running inside pod in K3s on Ubuntu
aws.greengrass.clientdevices.mqtt.Bridge running inside Greengrass pod
aws.greengrass.clientdevices.mqtt.Bridge started as a separate docker container mounted to K3 but runnign as a Docker container in Ubuntu
It works fine if
If we a starting Greengrass as a Java process on Ubuntu and mqtt.EMQX start as Docker container - everything works fine.

Hello,
It looks like you have configured the Bridge to connect to an unusual hostname and port ip-10-158-15-230:1225. Typically this should be localhost since Bridge and EMQX are should be on the same device.
You are not going to be able to connect Bridge from one Greengrass instance to a different Greengrass instance running EMQX. You must run only one instance of Greengrass with both EMQX and Bridge.

Our Greengrass in running as Docker container on the basis https://github.com/aws-greengrass/aws-greengrass-docker .
localhost was our first configuration attempt and it connection wasn't even setup between  Bridge and EMQX.
Because Greengrass trying to start EMQX as Docker in Docker, it started, but EMQX can't be reached via localhost but only via hostname of Ubuntu server where all stuff (K3s and separate Docker EMQX container) are running.
What solution you can advice in our case?

@MikeDombo
Thanks for your help!

Is the problem resolved? What did you do to resolve it?


Allow static configuration of NTP and DNS in DHCP mode

Before this fix we don't allow the static DNS or NTP configuration
this fix is removing that limitation and allow the static NTP
and DNS configuration in DHCP mode.
Change-Id: I5a909373ee1eaff850cf96622451af6acfaddcc3
Signed-off-by: Ratan Gupta<EMAIL_ADDRESS>

@rfrandse Changes for this commit has been merged today.
https://gerrit.openbmc-project.xyz/c/openbmc/phosphor-networkd/+/25410


Ref timesereis - new validation for json file

Pull Request Checklist:

[x] Positive Test Case Written by Dev

[x] Automated Testing

[ ] Sufficient User and Developer Documentation

[x] Passing Jenkins Build

[ ] Peer Code review and approval

Positive Test Case (Use testservices.hydroshare.org)

unknown methodLink: Use a timeseries json file that has methoLink set to 'unknown' (methodLink:"unknown") to create a ref timeseries aggregation. You should be able to create this aggregation.
UNKNOWN methodLink: Use a timeseries json file that has methoLink set to 'UNKNOWN' (methodLink:"UNKNOWN") to create a ref timeseries aggregation. You should be able to create this aggregation.
null value: Use a timeseries json file that has any of the following keys/attributes set to null to create a ref timeseries aggregation. You should be able to create this aggregation.

title
abstract
fileVersion
keyWords
symbol
siteName
variableName
methodLink
methodDescription
sampleMedium
valueCount

@sblack-usu Can you take another look at this?


v2 tables broken when column is hidden

Expected behavior and actual behavior:
Previously it was possible to hide a column by setting the hide property. That caused the header- as well as the body-column to be hidden (in sync). It seems to me that a recent change has broken that.
Steps to reproduce the problem:
use any v2.x.x version of  and set a column to be hidden
Environment (component version number, Browser (including version), operating system, hardware, etc):
any version >= v2.0.0
Screenshots (optional, but very helpful):

Code examples
https://github.build.ge.com/105042697/px-data-table-114.git

Interesting. I didn't think altering hide ever worked correctly, per #94 - none of the column sub-property changes are observed. Martin and I tried switching to a mutation observer, but it was causing flickering of all of the values. You can still use the aha-table.hideColumn('first') method, which is the same way the column chooser does it.

The reason why I created that ticket was that until v1.15.21 a static (not data-bound) hide-property worked fine for us. So the behavior is slightly different than described in #94.
I haven't looked into the root-cause yet, but it's most probably b/c of the sub-property changes. Isn't that a big issue on it's own? E.g. I see no way to properly localize a table right now, like:
<px-data-table-column name="name" label="[[localize('name')]]"></px-data-table-column

Should there be a separate issue to track that?

A static "hide" is working fine for me in both my local and on CodePen. http://codepen.io/randyaskin/pen/EWEyab?&editors=1001
I noticed in your screenshot that the "first" column seems to be duplicated. Is that after hiding and re-showing it? I did see some of that while I was iterating on the 2.0.0 version, but I thought I fixed that. I did see some duplicate column behavior on CodePen just now with include-all-columns which I'm going to look into.

Yes, I also experienced that kind of duplication. I never know what version codepen pulls, so I created a small repo that replicates the issue here. Did u try that (simply run bower install && python -m SimpleHTTPServer)?

I'm trying to run it. The bower install went fine, I see all the dependencies.  Any ideas?

Fixed in v2.0.4 - thanks again for your help.


seccomp: do not add empty named syscalls

if you pass this seccomp json:
{
    "defaultAction": "SCMP_ACT_ALLOW",
    "syscalls": [
        {
            "action": "SCMP_ACT_ERRNO"
        },
	{
	    "name": "chmod",
            "action": "SCMP_ACT_ERRNO"
	}
    ]
}

you'll get:
docker run --security-opt seccomp:test.json busybox chmod 777 .
docker: Error response from daemon: oci runtime error: empty string is not a valid syscall.

I don't know if it's ok to skip empty named syscalls in the profile, in doubt, I opened this and I'm going to fix https://github.com/docker/docker/pull/24510 as well if we don't want them.
/cc @justincormack
Signed-off-by: Antonio Murdaca<EMAIL_ADDRESS>

I think this should be considered invalid - the user probably made a mistake.

@justincormack I'll close this then - that was my guess as well but wasn't entirely sure, thanks


--max-line-length detect the error but does not format the file.

Hello and thank you for your work on this support for autopep8.
I have the following logs when trying to format a file with a line longer than the parameter provided:
2023-09-06 18:59:35.654 [info] Server: Start requested.
2023-09-06 18:59:36.044 [info] CWD Server: /home/vincent/project
2023-09-06 18:59:36.044 [info] sys.path used to run Server:
   /home/vincent/.vscode-server/extensions/ms-python.autopep8-2023.7.12271005/bundled/libs
   /home/vincent/.vscode-server/extensions/ms-python.autopep8-2023.7.12271005/bundled/tool
   /home/vincent/.conda/envs/project/lib/python39.zip
   /home/vincent/.conda/envs/project/lib/python3.9
   /home/vincent/.conda/envs/project/lib/python3.9/lib-dynload
   /home/vincent/.conda/envs/project/lib/python3.9/site-packages
   /home/vincent/project/src
2023-09-06 18:59:36.044 [info] PYTHONPATH env variable used to run Server:
   /home/vincent/.vscode-server/extensions/ms-python.autopep8-2023.7.12271005/bundled/libs:
2023-09-06 18:59:36.044 [info] Settings used to run Server:
[
    {
        "cwd": "/home/vincent/project",
        "workspace": "file:///home/vincent/project",
        "args": [
            "-v",
            "--experimental",
            "--max-line-length",
            "120"
        ],
        "path": [],
        "interpreter": [
            "/home/vincent/.conda/envs/project/bin/python"
        ],
        "importStrategy": "useBundled",
        "showNotifications": "off"
    }
]

2023-09-06 18:59:36.044 [info] Global settings:
{
    "cwd": "/home/vincent",
    "workspace": "/home/vincent",
    "args": [],
    "path": [],
    "interpreter": [],
    "importStrategy": "useBundled",
    "showNotifications": "off"
}

2023-09-06 18:59:36.046 [info] /home/vincent/.conda/envs/project/bin/python -m autopep8 --version
2023-09-06 18:59:36.046 [info] CWD Server: /home/vincent/project
2023-09-06 18:59:36.088 [info] Version info for formatter running for /home/vincent/project:
autopep8 2.0.2 (pycodestyle: 2.10.0)

2023-09-06 18:59:36.089 [info] SUPPORTED autopep8>=1.7.0
FOUND autopep8==2.0.2

2023-09-06 18:59:36.089 [info] /home/vincent/.conda/envs/project/bin/python -m autopep8 --version
2023-09-06 18:59:36.089 [info] CWD Server: /home/vincent/project
2023-09-06 18:59:36.131 [info] Version info for formatter running for /home/vincent/project:
autopep8 2.0.2 (pycodestyle: 2.10.0)

2023-09-06 18:59:36.131 [info] SUPPORTED autopep8>=1.7.0
FOUND autopep8==2.0.2

2023-09-06 18:59:36.472 [info] [Trace - 6:59:36 PM] Sending notification 'textDocument/didOpen'.
2023-09-06 18:59:36.472 [info] [Trace - 6:59:36 PM] Sending notification 'textDocument/didClose'.
2023-09-06 18:59:42.428 [info] [Trace - 6:59:42 PM] Sending request 'textDocument/formatting - (1)'.
2023-09-06 18:59:42.433 [info] [Trace - 6:59:42 PM] Received notification 'window/logMessage'.
2023-09-06 18:59:42.433 [info] /home/vincent/.conda/envs/project/bin/python -m autopep8 -v --experimental --max-line-length 120 -
2023-09-06 18:59:42.433 [info] [Trace - 6:59:42 PM] Received notification 'window/logMessage'.
2023-09-06 18:59:42.433 [info] CWD Server: /home/vincent/project
2023-09-06 18:59:42.494 [info] [Trace - 6:59:42 PM] Received notification 'window/logMessage'.
2023-09-06 18:59:42.494 [info] --->  1 issue(s) to fix {'E501': {24}}

2023-09-06 18:59:42.495 [info] [Trace - 6:59:42 PM] Received response 'textDocument/formatting - (1)' in 66ms.
2023-09-06 18:59:42.758 [info] [Trace - 6:59:42 PM] Sending notification 'textDocument/didChange'.
2023-09-06 19:00:02.883 [info] [Trace - 7:00:02 PM] Sending notification 'textDocument/didChange'.
2023-09-06 19:00:03.493 [info] [Trace - 7:00:03 PM] Sending notification 'textDocument/didChange'.
2023-09-06 19:00:05.735 [info] [Trace - 7:00:05 PM] Sending request 'textDocument/formatting - (2)'.
2023-09-06 19:00:05.738 [info] [Trace - 7:00:05 PM] Received notification 'window/logMessage'.
2023-09-06 19:00:05.738 [info] /home/vincent/.conda/envs/project/bin/python -m autopep8 -v --experimental --max-line-length 120 -
2023-09-06 19:00:05.738 [info] [Trace - 7:00:05 PM] Received notification 'window/logMessage'.
2023-09-06 19:00:05.738 [info] CWD Server: /home/vincent/project
2023-09-06 19:00:05.797 [info] [Trace - 7:00:05 PM] Received notification 'window/logMessage'.
2023-09-06 19:00:05.797 [info] --->  1 issue(s) to fix {'E501': {24}}

2023-09-06 19:00:05.799 [info] [Trace - 7:00:05 PM] Received response 'textDocument/formatting - (2)' in 64ms.
2023-09-06 19:00:06.080 [info] [Trace - 7:00:06 PM] Sending notification 'textDocument/didChange'.
2023-09-06 19:00:18.261 [info] [Trace - 7:00:18 PM] Sending notification 'textDocument/didChange'.
2023-09-06 19:00:18.691 [info] [Trace - 7:00:18 PM] Sending notification 'textDocument/didChange'.
2023-09-06 19:00:26.749 [info] No interpreter found from setting autopep8.interpreter
2023-09-06 19:00:26.749 [info] Getting interpreter from ms-python.python extension for workspace /home/vincent/project
2023-09-06 19:00:26.754 [info] Interpreter from ms-python.python extension for /home/vincent/project: /home/vincent/.conda/envs/project/bin/python
2023-09-06 19:00:26.755 [info] Server: Stop requested
2023-09-06 19:00:26.767 [info] No interpreter found from setting autopep8.interpreter
2023-09-06 19:00:26.767 [info] Getting interpreter from ms-python.python extension for workspace /home/vincent/project
2023-09-06 19:00:26.768 [info] Interpreter from ms-python.python extension for /home/vincent/project: /home/vincent/.conda/envs/project/bin/python
2023-09-06 19:00:26.775 [info] Server run command: /home/vincent/.conda/envs/project/bin/python /home/vincent/.vscode-server/extensions/ms-python.autopep8-2023.7.12271005/bundled/tool/lsp_server.py

However the formatting issue is not being fix. Other issue like removing additional space works correctly.
Am I doing something wrong with the settings ? I tried various set up and could not make it work.

@karthiknadig
This gives me the following output:
read config path: /home/vincent/elix-ziggurat/setup.cfg
read config path: /home/vincent/elix-ziggurat/.flake8
enable config: section=flake8, key=max-line-length, value=120
enable config: section=flake8, key=exclude, value=
__pycache__,
other directory in workspace...
--->  1 issue(s) to fix {'E501': {24}}
Code of the file without any modification (at least on the line lenght)
...

Not sure what you meant by id things? But the line with a length longer than max-line-length is the 24th line so that's why it seems to detect it.

Not sure what you meant by id things?

Sorry, that was a typo.

Code of the file without any modification (at least on the line lenght)

You need to file this on autopep8, looks like when using stdin mode it is not fixing all the issues. This extension just runs autopep8 in stdin mode.

Thank you! I will try over there ?


Add preset for shop=sewing

Fixes #5244

Thanks, I've now amended my commit. Worth noting the build added some other lines to dist/locales/en.json which I manually removed since they're unrelated to this PR (looks like they're imagery related).

Thanks @SilentSpike 👍


Computed properties function set on sub object properties add double quotes when displayed

Version
3.2.33
Reproduction link
sfc.vuejs.org/
Steps to reproduce
Execute the following code

What is expected?
the string 'test content advanced' should not be display between double quotes
What is actually happening?
Today it display the string between double quotes.

This happens when the computed function, is set on a sub-object property

That would mean you could no longer purposely use a  object in the template.l without it being unwrapped.
That would break valid use cases.
So i don't think so, no.


chore(deps): update dependency ts-jest to v26

This PR contains the following updates:

Package
Type
Update
Change

ts-jest (source)
devDependencies
major
22.4.6 -> 26.0.0

Release Notes

kulshekhar/ts-jest
v26.0.0
Compare Source
Bug Fixes

compiler: return undefined for getScriptVersion when a file doesn't exist in memory cache (#1641) (6851b8e)

Features

support Jest v26 (#1602) (23b7741)

BREAKING CHANGES

Requires a minimum of TypeScript v3.8
Drop support for Node 8

25.5.1 (2020-05-09)
Bug Fixes

compiler: don't resolve files from build folder for projectReferences (#1614) (74b92d3)
config: don't set include value of tsconfig to empty array (#1606) (8a29aaa)

v25.5.1
Compare Source
Bug Fixes

compiler: return undefined for getScriptVersion when a file doesn't exist in memory cache (#1641) (6851b8e)

Features

support Jest v26 (#1602) (23b7741)

BREAKING CHANGES

Requires a minimum of TypeScript v3.8
Drop support for Node 8

25.5.1 (2020-05-09)
Bug Fixes

compiler: don't resolve files from build folder for projectReferences (#1614) (74b92d3)
config: don't set include value of tsconfig to empty array (#1606) (8a29aaa)

v25.5.0
Compare Source
Bug Fixes

compiler: make projectReferences work with isolatedModules: false (#1541) (3e8efbe)
compiler: allow using files provided by tsconfig (#1562) (a9f02bd)
config: verify testMatchPatterns contain RegExp instance or string type values (#1569) (7f85bab)

Features

config: add tsconfig alias to tsConfig option (#1565) (c10eb6d)
config: define 'ts-jest' on ConfigGlobals interface of @jest/types (#1592) (4526392)

Performance Improvements

compiler: don’t write compile output to file system but rely on jest cache (#1561) (d11a4ea)
compiler: improve performance for isolatedModules: false (#1558) (85c09e3)

BREAKING CHANGES

Any custom typing files or files which are needed to be compiled and intended to use with jest need to be defined in files option of tsconfig.

For example:
// tsconfig.json
{
   // ...other configs
   "files": [
       "my-custom-typings.d.ts",
       "my-global-module.ts"
   ]
}

compiler: incremental and compilerHost options are no longer available. Please remove it from your ts-jest config.

v25.4.0
Compare Source
Bug Fixes

compiler: make projectReferences work with isolatedModules: false (#1541) (3e8efbe)
compiler: allow using files provided by tsconfig (#1562) (a9f02bd)
config: verify testMatchPatterns contain RegExp instance or string type values (#1569) (7f85bab)

Features

config: add tsconfig alias to tsConfig option (#1565) (c10eb6d)
config: define 'ts-jest' on ConfigGlobals interface of @jest/types (#1592) (4526392)

Performance Improvements

compiler: don’t write compile output to file system but rely on jest cache (#1561) (d11a4ea)
compiler: improve performance for isolatedModules: false (#1558) (85c09e3)

BREAKING CHANGES

Any custom typing files or files which are needed to be compiled and intended to use with jest need to be defined in files option of tsconfig.

For example:
// tsconfig.json
{
   // ...other configs
   "files": [
       "my-custom-typings.d.ts",
       "my-global-module.ts"
   ]
}

compiler: incremental and compilerHost options are no longer available. Please remove it from your ts-jest config.

v25.3.1
Compare Source
Bug Fixes

compiler: make projectReferences work with isolatedModules: true (#1527) (aa6b74c)
compiler: make sure LanguageService updated with test file information before getting diagnostics for test file (#1507) (311eaeb)
config: set default outDir when allowJs is true and no outDir in tsconfig (#1502) (1a287ad)
config: use original jest config object instead of stringified config (#1511) (4f0bb33)

25.3.1 (2020-04-03)
Bug Fixes

only do type checking while compiling file (#1483) (dbc0a08)
config: set default outDir for enabled allowJs without outDir (#1472) (57c7af0)

v25.3.0
Compare Source
Bug Fixes

add jest-config to dependencies list (6d9e0d8)
always do type check for all files provided to ts-jest transformer for non-watch mode (#1450) (107e062)

Chores

docs: add TROUBLESHOOTING (96cd9b3)

Features

compiler: expose internal ts Program via ConfigSet TsCompiler (#1433) (7153246)
config: add incremental option (#1418) (5a69bce)

BREAKING CHANGES

config: improve diagnostics message (#1444) (96cd9b3). This will affect to any snapshots or assertion against diagnostics messages

v25.2.1
Compare Source
Bug Fixes

add jest-config to dependencies list (6d9e0d8)
always do type check for all files provided to ts-jest transformer for non-watch mode (#1450) (107e062)

Chores

docs: add TROUBLESHOOTING (96cd9b3)

Features

compiler: expose internal ts Program via ConfigSet TsCompiler (#1433) (7153246)
config: add incremental option (#1418) (5a69bce)

BREAKING CHANGES

config: improve diagnostics message (#1444) (96cd9b3). This will affect to any snapshots or assertion against diagnostics messages

v25.2.0
Compare Source
Bug Fixes

compiler: allow transformation of typescript files in node_modules (#1385) (814405e)
docs: fixing slack link and some minor typos in documenation (#1404) (3e2e008)
transformer: add deepUnmock to hoist method list (#1372) (0fbbc00)
util: use resolve package typescript package in yarn workspaces (#1377) (a63808c)

v25.1.0
Compare Source
Bug Fixes

config: let babel-jest handle loading babel config (#1370)

v25.0.0
Compare Source
Bug Fixes

jest 25 type definitions (#1363) (ba82a9e)

v24.3.0
Compare Source
Features

support Jest 25 (#1355)

v24.2.0
Compare Source
Bug Fixes

config: support babel config file path as string (#1332) (78a53c2)

v24.1.0
Compare Source
Bug Fixes

compiler: pass filename to sha function instead of file extension (ac1ac97)
transformers: hoist jest.enableAutomock and jest.disableAutomock (ac50bc3)
typescript serviceHost cache miss on Windows operating systems (26ee731)

v24.0.2
Compare Source
Bug Fixes

perf: add cache for fs calls (#908) (3dada81)
#825 handle symlinked modules (ala pnpm) correctly (e190b23)
handle tsBuildInfoFile option (f9583e9), closes #1095
types: unforce esModuleInterop in tsconfig.json (c2d39b6)

24.0.2 (2019-04-05)
24.0.1 (2019-03-30)
Bug Fixes

update call to globIgnore (#1002) (#1003) (05b63af)

Features

config: specify package.json location (#823) (#1013) (fb7dd55)

v24.0.1
Compare Source
24.0.2 (2019-04-05)
v24.0.0
Compare Source
Bug Fixes

cli test (1d67101)
module tests and some snapshots (999f889)
remove unused snapshots (108b08b)
some tests (d0f2231)
test command (8372b5e)
test path for windows (attempt 1) (6824ac4)
test path for windows (attempt 2) (eb2fc8a)

Features

jest: bump to 24 (defcb77)

23.10.4 (2018-10-06)
Bug Fixes

cache: adds project's dep versions to cache key (6cacbea), closes #785
cli: change options to better reflect the new presets (68abcfb)
helpers: deprecate import from ts-jest, now ts-jest/utils (33ff29f), closes #782
typings: typo in presets definition file (53767ab)
typings: wrong import in preset typings + test (94dc4e7)

23.10.3 (2018-09-30)
Bug Fixes

compiler: do not force module kind if piping babel (acebc8c), closes #767

Features

helpers: adds a mocked test helper for mock typings (f976135), closes #576

23.10.2 (2018-09-26)
Bug Fixes

cache: resolved tsconfig in cache key + pkg digest (e891608), closes #749
cli: resets testMatch if using testRegex option (31ad0aa), closes #756
diagnostics: throws only for category warning and error (bb28849), closes #748
import: wrong error message when a module exists but fails (e0d6c57)
preset: createJestPreset fails with base and no array (3c325e8)

Features

cli: CLI 'config:migrate' now detects best preset (febd8d3)
preset: adds 2 presets along the default one (9f3d759)
preset: adds presets typings and export all presets (f55d895)
typings: emit declaration files, filtering out internals (4f10f7e), closes #745

23.10.1 (2018-09-20)
Bug Fixes

compile: js files were never transpiled thru TS (374dca1), closes #740
config: warn instead of forcing ESM interoperability (a2a4be2)
windows: normalize paths (c12dfff)

v23.10.5
Compare Source
Bug Fixes

cli test (1d67101)
module tests and some snapshots (999f889)
remove unused snapshots (108b08b)
some tests (d0f2231)
test command (8372b5e)
test path for windows (attempt 1) (6824ac4)
test path for windows (attempt 2) (eb2fc8a)

Features

jest: bump to 24 (defcb77)

23.10.4 (2018-10-06)
Bug Fixes

cache: adds project's dep versions to cache key (6cacbea), closes #785
cli: change options to better reflect the new presets (68abcfb)
helpers: deprecate import from ts-jest, now ts-jest/utils (33ff29f), closes #782
typings: typo in presets definition file (53767ab)
typings: wrong import in preset typings + test (94dc4e7)

23.10.3 (2018-09-30)
Bug Fixes

compiler: do not force module kind if piping babel (acebc8c), closes #767

Features

helpers: adds a mocked test helper for mock typings (f976135), closes #576

23.10.2 (2018-09-26)
Bug Fixes

cache: resolved tsconfig in cache key + pkg digest (e891608), closes #749
cli: resets testMatch if using testRegex option (31ad0aa), closes #756
diagnostics: throws only for category warning and error (bb28849), closes #748
import: wrong error message when a module exists but fails (e0d6c57)
preset: createJestPreset fails with base and no array (3c325e8)

Features

cli: CLI 'config:migrate' now detects best preset (febd8d3)
preset: adds 2 presets along the default one (9f3d759)
preset: adds presets typings and export all presets (f55d895)
typings: emit declaration files, filtering out internals (4f10f7e), closes #745

23.10.1 (2018-09-20)
Bug Fixes

compile: js files were never transpiled thru TS (374dca1), closes #740
config: warn instead of forcing ESM interoperability (a2a4be2)
windows: normalize paths (c12dfff)

v23.10.4
Compare Source
Bug Fixes

cache: adds project's dep versions to cache key (6cacbea), closes #785
cli: change options to better reflect the new presets (68abcfb)
helpers: deprecate import from ts-jest, now ts-jest/utils (33ff29f), closes #782
typings: typo in presets definition file (53767ab)
typings: wrong import in preset typings + test (94dc4e7)

v23.10.3
Compare Source
Bug Fixes

cache: adds project's dep versions to cache key (6cacbea), closes #785
cli: change options to better reflect the new presets (68abcfb)
helpers: deprecate import from ts-jest, now ts-jest/utils (33ff29f), closes #782
typings: typo in presets definition file (53767ab)
typings: wrong import in preset typings + test (94dc4e7)

v23.10.2
Compare Source
Bug Fixes

compiler: do not force module kind if piping babel (acebc8c), closes #767

Features

helpers: adds a mocked test helper for mock typings (f976135), closes #576

v23.10.1
Compare Source
Bug Fixes

cache: resolved tsconfig in cache key + pkg digest (e891608), closes #749
cli: resets testMatch if using testRegex option (31ad0aa), closes #756
diagnostics: throws only for category warning and error (bb28849), closes #748
import: wrong error message when a module exists but fails (e0d6c57)
preset: createJestPreset fails with base and no array (3c325e8)

Features

cli: CLI 'config:migrate' now detects best preset (febd8d3)
preset: adds 2 presets along the default one (9f3d759)
preset: adds presets typings and export all presets (f55d895)
typings: emit declaration files, filtering out internals (4f10f7e), closes #745

v23.10.0
Compare Source
Bug Fixes

babel: fixes the babel 6 hack (c8d51cf)
config: jsx should also be considered as js files (6c32a93)

Features

hints: warns if transform matches js without allowJs (952cc87)

v23.1.4
Compare Source
Bug Fixes

ci: can't use runInBand for e2e: cache collision (db650f4)
ci: do not run e2e sub-tests in band (18ad865)
ci: ensure npm is present with ci (edb6eda)
logger: removes cyclic imports (5ef980f)
babel-config + adds test (12146c3)
fixes js style to be node < 10 compatible (83d7517)
hoisting per level + memoize fix (31847b0)
jest 22 did not have default config (cbaddc3)
makes node 6 happy (f6f82b8)
makes node6 happy (f170285)
makes window happy (36fbebe)
node 6 unhappy again... (703ad0b)
normalizes bundle hash on any node version (ce7afaf)
npm coming with node 6 doesn't talk ci (b87198d)
source maps (89a30c9)
typos + node 6 compat (0ed1587)
updates templates (f2e1da2)
uses cross-platform spawn + fix pkg versions (ac1599c)
we are not writing files, use normalized EOL (47fff43)
tests: CI fixes (34a41ea)
tests: detect npm version to use or not ci (683a1e5)
tests: do not use babel in our tests + new API for simple (3e4de3e)
tests: more sanitizing for windows compat (faae274)

Features

config: adds a helper to build moduleNameMapper from paths (7b8598e), closes #364
logging: improves log messages + tests (5d03c4d)
adds logging + better hashing (4322701)
allow env var to add diagnostic codes to ignore (777edf5)
cache key + tests (bd55448)
diagnostics, different compilers, ... (f26ebf0)
directly writes to stdio so jest does not swallow (6a7f01f)
handles stringifyContentPathRegex (3fcb4bd)
hoisting + tests + many other things (6186e84)
io serializer + other test utils (d03e0e7)
jest preset (beb50b5)
warn about unsupported versions (1103071)
test: jest serializers (dfa9c0f)
tests: more test tools + adds test related to debuggin issues (8dcafca)

Performance Improvements

babel: uses babel-jest cache key as part of ours (f51c4a7)
cache: share config-sets for parallel test running (090ca7b)
tests: run e2e tests in band (b3e94ff)
detects changes in templates and bundle (2a3da21)
do not type check if fileName doesn't match (cc45adc)
faster tests (37a0187)
improves speed of local test after 1st run (cc04021)
more cleaning (c48f7b8)
trying to improve travis-ci conf (e4b4d95)

23.1.3 (2018-08-06)
Bug Fixes

allow (but deprecate) use of old preprocessor.js (a65079f)
big refactor + fixes (mainly cache key + coverage) (e46caae)
fixes coverage and tests (09500c2)
gracefully load @babel/core or babel-core (98b2410)
hack for babel < 6 so that breakpoints do work (90c74ef), closes #627
resolves correctly config file path (fix #636) (5ab100c)
test rootDir to handle preset-angular (8a6a8f7)
wrong error message (c955083)
html: correctly transforms html source when needed (9a2d74f)
lint: fixes tslint script & lint issues (60ab36e)
package: update fs-extra to version 6.0.1 (7e73536)
package: update pkg-dir to version 3.0.0 (3fb8f9f)
package: update yargs to version 12.0.1 (390ffcd)
source-maps: fix source maps options/calls (76e27c1)
Typo in utils.ts (#534) (a650260)

Performance Improvements

do not hash cache key, jest does it underneath (fbe4f1f)

22.4.5 (2018-05-05)
22.4.1 (2018-03-02)
Bug Fixes

package: update source-map-support to version 0.5.0 (f0aab12)
package: update yargs to version 10.0.3 (5cdf969)
package: update yargs to version 11.0.0 (7e9ce40)
add startDir to if-clause (eed5311)
package: update yargs to version 9.0.1 (#326) (8bf9924)

Features

add option to run TypeScript diagnostics (13b77d9)

21.0.1 (2017-09-14)
v23.1.3
Compare Source
Bug Fixes

allow (but deprecate) use of old preprocessor.js (a65079f)
big refactor + fixes (mainly cache key + coverage) (e46caae)
fixes coverage and tests (09500c2)
gracefully load @babel/core or babel-core (98b2410)
hack for babel < 6 so that breakpoints do work (90c74ef), closes #627
resolves correctly config file path (fix #636) (5ab100c)
test rootDir to handle preset-angular (8a6a8f7)
wrong error message (c955083)
html: correctly transforms html source when needed (9a2d74f)
lint: fixes tslint script & lint issues (60ab36e)
package: update fs-extra to version 6.0.1 (7e73536)
package: update pkg-dir to version 3.0.0 (3fb8f9f)
package: update yargs to version 12.0.1 (390ffcd)
source-maps: fix source maps options/calls (76e27c1)
Typo in utils.ts (#534) (a650260)

Performance Improvements

do not hash cache key, jest does it underneath (fbe4f1f)

v23.1.2
Compare Source
Bug Fixes

allow (but deprecate) use of old preprocessor.js (a65079f)
big refactor + fixes (mainly cache key + coverage) (e46caae)
fixes coverage and tests (09500c2)
gracefully load @babel/core or babel-core (98b2410)
hack for babel < 6 so that breakpoints do work (90c74ef), closes #627
resolves correctly config file path (fix #636) (5ab100c)
test rootDir to handle preset-angular (8a6a8f7)
wrong error message (c955083)
html: correctly transforms html source when needed (9a2d74f)
lint: fixes tslint script & lint issues (60ab36e)
package: update fs-extra to version 6.0.1 (7e73536)
package: update pkg-dir to version 3.0.0 (3fb8f9f)
package: update yargs to version 12.0.1 (390ffcd)
source-maps: fix source maps options/calls (76e27c1)
Typo in utils.ts (#534) (a650260)

Performance Improvements

do not hash cache key, jest does it underneath (fbe4f1f)

v23.1.1
Compare Source
v23.1.0
Compare Source
v23.0.1
Compare Source
v23.0.0
Compare Source

Renovate configuration
:date: Schedule: At any time (no schedule defined).
:vertical_traffic_light: Automerge: Disabled by config. Please merge this manually once you are satisfied.
:recycle: Rebasing: Whenever PR becomes conflicted, or if you modify the PR title to begin with "rebase!".
:no_bell: Ignore: Close this PR and you won't be reminded about this update again.

[ ] If you want to rebase/retry this PR, check this box

Available now for Enterprise: Renovate Pro with real-time webhook handling and priority job queue.

Renovate Ignore Notification
As this PR has been closed unmerged, Renovate will ignore this upgrade and you will not receive PRs for any future 26.x releases. However, if you upgrade to 26.x manually then Renovate will then reenable updates for minor and patch updates automatically.
If this PR was closed by mistake or you changed your mind, you can simply rename this PR and you will soon get a fresh replacement PR opened.