Replace inline "add X" in settings with modals

As discussed on CZO, we have ~5 different formats for adding or editing something in the settings menus.
We should aim to standardize on a smaller set of approaches. In particular, we should start by replacing the inline format for adding something where we have multiple fields on the same line. That layout is especially inconsistent with others, and is prone to responsiveness bugs (cf. https://github.com/zulip/zulip/pull/20118).
The following parts of the settings should thus be replaced with a modal:

[x] SETTINGS / CUSTOM EMOJI > Add a new emoji. The modal should be opened via an "Add emoji" button on the same line as the "Filter emojis" field.
[x] SETTINGS / USER GROUPS > Add a new user group
[x] SETTINGS / DEFAULT STREAMS > Add new default stream. The modal should be opened via an "Add default stream" button on the same line as the "Filter streams" field.

It is helpful to submit a PR addressing one or more of the above.

@zulipbot claim

@NerdyLucifer plans to work on the user groups part of this issue as part of https://github.com/zulip/zulip/pull/20954.
@somesh202 could you guys collaborate if you have something in progress for it, or otherwise focus on the other two parts?

I have implemented the modal for editing user groups in #20954.
Please give your feedbacks.

@NerdyLucifer I noticed that #20954 is closed. Is there a current PR?

@alya I have created a new PR at #21454 to address the issue.

SETTINGS / USER GROUPS > Add a new user group

@alya #21689

SETTINGS / DEFAULT STREAMS > Add new default stream. The modal should be opened via an "Add default stream" button on the same line as the "Filter streams" field.

#21688

Adding a note here that we may want to add confirmation banners for adding and removing default streams once the default streams part of this issue has been resolved.

Looks like we forgot to close this issue when it was resolved.


Offsets Question

I Try to find all the blood tests which were drawn to a patient when they were still in the emergency department (prior to their arrival to ICU). Surprisingly, I found out that in about 50% of the cases the
patients.hospitalAdmitOffset (=number of minutes from unit admit time that the patient was admitted to the hospital) is bigger  than the lab.labResultOffset (=number of minutes from unit admit time that the lab value was drawn).
Which means that the lab test was taken before the patient was admitted to the hospital, I would appreciate if anyone can help me to figure out how it can happen.
An Example: PatientUnitStayId 1797991 was admitted to hospital 204 minutes before arriving to the ICU, while is labtest was taken 266 minute before arriving to ICU, namely 62 minutes before his admission to hospital..
Thanks a lot!!
Dan

When pts are in the ED they may not yet be admitted to the hospital. The ED is considered an outpatient clinic. Many patients will go home and never be admitted as inpatients!
RGM

On Feb 16, 2019 at 10:42 AM,    wrote:
I Try to find all the blood tests which were drawn to a patient when they were still in the emergency department (prior to their arrival to ICU). Surprisingly, I found out that in about 50% of the cases the
patients.hospitalAdmitOffset (=number of minutes from unit admit time that the patient was admitted to the hospital) is  bigger  than the lab.labResultOffset (=number of minutes from unit admit time that the lab value was drawn).
Which means that the lab test was taken before the patient was admitted to the hospital, I would appreciate if anyone can help me to figure out how it can happen.
An Example: PatientUnitStayId 1797991 was admitted to hospital 204 minutes before arriving to the ICU, while is labtest was taken 266 minute before arriving to ICU, namely 62 minutes before his admission to hospital..
Thanks a lot!!
Dan
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly,  view it on GitHub, or   mute the thread.

Thanks a lot!


BRPOP doesn't actually work

Hi,
Sorry if I'm missing something obvious but BRPOP does not seem to actually resolve when a queued item becomes available. If something is present when BRPOP is initiated it immediately resolves otherwise it 'blocks' until timeout and resolves with null.
Example:
import { Redis } from 'ioredis';

(async () => {
    const redis = new Redis();

    setTimeout(() => {
        redis.lpush('some-queue', 'a queued thing');
    }, 1000);

    const start = Date.now();

    do {
        const queuedThing = await redis.brpop('some-queue', 10);
        if (!queuedThing) {
            console.log('Timeout waiting for queue, elapsed:', Date.now() - start);
            continue;
        }

        console.log('Got thing from queue:', queuedThing, 'elapsed:', Date.now() - start);
        process.exit(0);
    } while (true);

})();

Output:
ts-node example.ts
Timeout waiting for queue, elapsed: 10041
Got thing from queue: [ 'some-queue', 'a queued thing' ] elapsed: 10043

A timeout should not occur right? The loop should block for 1 second and then process the LPUSHed event and then exit.
redis-server 7.4.1
ioredis 5.4.1
node 20.15.1
edit-- I tested directly w/ redis-cli and it works as expected.

In this case you need a second connection:
import { Redis } from 'ioredis';

(async () => {
    const producer = new Redis();
    const consumer = new Redis();

    setTimeout(() => {
        producer.lpush('some-queue', 'a queued thing');
    }, 1000);

    const start = Date.now();

    do {
        const queuedThing = await consumer.brpop('some-queue', 10);
        if (!queuedThing) {
            console.log('Timeout waiting for queue, elapsed:', Date.now() - start);
            continue;
        }

        console.log('Got thing from queue:', queuedThing, 'elapsed:', Date.now() - start);
        process.exit(0);
    } while (true);

})();

thx that works


[WIP] Typings definitions

WIP PR to add typescript definitions
References #447

Awesome, LMK when it's ready to merge!

Is it ready? :) @oblador @iRoachie ?

@pietrasiak It's basically done in terms of the definitions themselves. However because the library imports files directly import Icon from 'react-native-vector-icons/MaterialIcons(refers to MaterialIcons.js), typescript will look for MaterialIcons.d.ts definition. I don't want to just duplicate the same code for all the font files. So I'm checking with some guys from the typescript team, if there's anyway to go around it

@oblador I think the code itself for the library could be simplified since all the 'fontFile.js' files are the exact same except the glyphMap is different. The index.js file could export all the Icons. The only thing is that this would be a breaking change as it would change how the imports are done.

@iRoachie It's an intentional design so that bundles won't be unnecessarily bloated.

@pietrasiak Could you test it for me? I want to make sure everything's good. You can use:
npm install --save https://github.com/iRoachie/react-native-vector-icons.git\#typings

Hey @oblador the typings are complete. While talking with a guy from the microsoft team he had suggested I put the typings on DefinitelyTyped instead in that way would be maintained easier since the maintainers there are from the typescript team. He told me to ask you if you're comfortable updating the files when new changes are made.

Adding to DefinitelyTyped instead. https://github.com/DefinitelyTyped/DefinitelyTyped/pull/17506

Types are live! npm i @types/react-native-vector-icons


feat(wrapper/service): Add subscriber wrapper

Add a matching option provided for clients/handlers to add the service into the context for subscribers, to allow subscription handlers to access the service and configured components.

The only reason a Call wrapper existed was for convenience but if we have wrappers for all methods its messy. Wrappers should likely be an external construct, not one baked into the client.

https://github.com/asim/go-micro/pull/2385

Hmm, well in this case this isn't a wrapper for publishing but rather subscribing, where the framework is the one that invokes the subscription handler with parameters.
Currently there's no good way to get access to the service in a subscription handler without making it a global or something, from what I can tell. Is there a good way around this without adding this wrapper?

Sorry, I misunderstood your issue.

Thanks!


AIMA4e implement Fig  23.5 CYK-Parse from AIMA3e branch

I would like to work on this. Is it still open?


[Feature] Add option for adding columns to the table

Create a form on templates/table_view.html which will send a post request to a route which will add a column to a particular table.
The form should also have options available when adding columns like Primary Key, DataType, Not null etc.
The name of the table can be taken from the url params.
steps:

Create a method for the above task on the db package.
Then create a handler in the routes package which will call method from the db package.
Create a route for the above handler.
Create form on templates/table_view.html and send the post request to the above route.

Please assign this issue to me 🥷

@VanTekken assigned :+1:


New class loader

Changes the plugin-manager so that it uses the current version of class_loader. In a ROS setup it means that the class loader from ROS' apt-packages can be used.

In a Rock-workspace class_loader is not found via CMake, it appears.
The first errors are:
CMake Error at /home/dfki.uni-bremen.de/chertzberg/workspace/terrain_exploration/install/share/rock/cmake/Rock.cmake:498 (get_property):
  get_property could not find TARGET class_loader::class_loader.  Perhaps it
  has not yet been created.
Call Stack (most recent call first):
  /home/dfki.uni-bremen.de/chertzberg/workspace/terrain_exploration/install/share/rock/cmake/Rock.cmake:938 (rock_target_definition)
  /home/dfki.uni-bremen.de/chertzberg/workspace/terrain_exploration/install/share/rock/cmake/Rock.cmake:1036 (rock_library_common)
  src/CMakeLists.txt:6 (rock_library)

According to the CMakeCache class_loader_DIR points to /usr/share/class_loader/cmake (which I assume is wrong for a rock workspace).
Do we first need to patch Rock's version of the class_loader to be found correctly by CMake?

We could try upgrading rock's version of tools/class_loader. It is currently set to indigo-devel tag 0.3.8 in rock.core with a patch added.
Just removing the patch and going to rolling currently fails because rcpputils is not found (after enabling CLASS_LOADER_IGNORE_AMENT and removing console_bridge_vendor from the CMakeLists)
I did not continue trying.

I am confused about console_bridge. What is it? Is the console_bridge from https://github.com/rock-core/base-console_bridge the same that is installed via libconsole-bridge-dev? I would guess not, but how are they related?

https://github.com/rock-core/base-console_bridge fakes the ros console bridge api to be able to use those packages witout dependency to roscpp/rclcpp

It looks like the plugin_manager is mostly used by envire, where it is actually optional. Do we know, if this envire::ClassLoader (which seems to be a rather thin wrapper around plugin_manager) is actually used in our stack? Maybe in mars (@malter )? Maybe we can just safely remove it, else I would suggest to look for another Plugin implementation or see if we can implement this here to work without the class_loader, which is in its current form a part of the ROS eco system.

We could compile classlaoder with a differnet libname so the plugin_manager can specifically link to that version, like "libclass_loader_envire.so"? Wehn we also adapt the cmake config and pkg-config, we shouldn't ha an issue with having both installed

What does base/console_bridge achieve in its current state?

I think base/console_bridge does exactly what you describe, i.e. it provides the CONSOLE_BRIDGE_LOG_<LEVEL> macros and calls (RoCK) base-logging functions with it.

We could compile classlaoder with a differnet libname so the plugin_manager can specifically link to that version, like "libclass_loader_envire.so"? Wehn we also adapt the cmake config and pkg-config, we shouldn't ha an issue with having both installed

If I understand @skasperski  correctly the main issue is to get (a current version of) https://github.com/ros/class_loader/ compile (and install) properly without pulling in lots of ROS dependencies.

Shall we file an issue at https://github.com/ros/class_loader/tree/rolling whether it is possible to remove the dependency to rcpputils and rcutils?
class_loader claims to be ROS-independent, while the latter libraries are core ROS libraries. The remaining dependencies are really easy to resolve, I assume.

Shall we file an issue at https://github.com/ros/class_loader/tree/rolling whether it is possible to remove the dependency to rcpputils and rcutils?

--> https://github.com/ros/class_loader/issues/211


Fixing Issue 1571 & Partial fix for 1174

Q
A

Bug fix?
[x]

New feature?
[ ]

New sample?
[ ]

Related issues?
fixes #1571, partially #1174, mentioned in #Z

What's in this Pull Request?
Problem statement
When a column in list of type number, is configured with minimum and maximum value, the validation works fine on the list form but not in the Dynamic form. On dynamic form, user can enter any value and submit as mentioned in the issue 1571
Solution
Fixing the ability to validate the number field when minimum and maximum value is defined in the list.
I have added three field properties minimumValue, maximumValue, showAsPercentage

(These properties are only available for Number field)
These properties are added to the fieldCollection and validates in the dynamic form according to the changedValue/newValue accordingly.
Thanks,
Nishkalank Bezawada

@NishkalankBezawada The text you have added to the German locale file is Dansk.
The German text is "Der Wert dieses Feldes muss zwischen {0} und {1} liegen."
Translations into other languages seem to be missing too.

Der Wert dieses Feldes muss zwischen {0} und {1} liegen.

Thanks @IRRDC I will correct those.

@NishkalankBezawada - thanks for the changes. I have merged it but left few comments for you as FYI.
I will make these changes but in future please take them into consideration.

@NishkalankBezawada - thanks for the changes. I have merged it but left few comments for you as FYI.
I will make these changes but in future please take them into consideration.

Thanks Alex, have you added any comments here? I can't able to find those.


why txn Begin() interface does not support context param which be used to set timeout

problems
when my program call the Begin function, it would stalls if tikv services not working, how can I set the timeout.
file<EMAIL_ADDRESS>// Begin a global transaction.
func (s *KVStore) Begin() (*KVTxn, error) {
return s.BeginWithOption(DefaultStartTSOption())
}
Anyone know how to solve the problem.

Hi @luohaixiannz we are working on it. Please wait for v2.0.0 GA version :)

ok, thank you

How is this feature going on? We need this timeout configuration when use Begin().


Can you toggle Guest Mode on SSID2 on Nokia Gateway

Attached is a screenshot showing the grayed out Guest Mode toggle in the Network -> 2.4 GHz  using SSID2.
Can HINT  toggle this function ?
I am asking because I when I try to log in to Nokia Gateway with HINT, I get a socket timeout error.
My gateway PW has  total of 8 LC, and Numbers . No special characters
If HINT can not toggle Guest Mode, I do not need to solve login problem.
I can include all the various methods I have tried in a new issue if desired

As far as I know, it isn't possible to toggle guest mode on the Nokia, so the switch is disabled.


Implement regular expressions

The syntax still needs to be defined.
Delimiting with slashes (like in JavaScript) causes syntax ambiguities (like in JavaScript).
On the other hand there aren't many other available symbols to use as delimiters, most have been used for operators (and that design is not going to change).

Valid option for the delimiters: the dollar symbol ($).
Example: $foo$.test "is this foo?"

The "at" symbol (@) would be another option but it is going to be used for annotations.

Now that #73 is fixed, more symbols has become available by the way.


npm run build - do I need to serve index.html from a web server?

After running npm run build, do I need to host index.html from a web server? Shouldn't I be able to open /public/index.html in a web browser and see 'It Works!'? All that appears is 'Loading...'. If I don't want to use a web sever, how can I reconfigure webpack?

Cloned the project
npm i
npm run dev (works great)
npm run build
opened /public/index.html in web browser but only 'Loading...' appears

Hi,
The problem here is probably how you are using webserver to serve these static files. I just ran npm run build then cd public to the directory and use python -m SimpleHTTPServer 8000 and was able to see the page with the proper stylesheet here.

Hi Ali, I am pushing up a merge request now.

@alicoding, let me know what you think... I'm not using a webserver. I just want to host the static index.html which cannot find the bundled css and js file. Perhaps it should be publicPath: './',


Fixes #2865. Unknown character sequence while resizing terminal.

Fixes #2865 - On macOS Ansi escape sequences are send after the terminal resizing but they are corrupted. Thus is needed to restore them correctly. Also this fix includes some keys that aren't handled on macOS if a Wiindows numeric keyboard is used, like the Home, End, PgUp, PgDn, etc.... Another issue is that macOS doesn't rely on the curses lines_ptr and cols_ptr pointers to return the current size on resizing and now it's needed to use ioctl and resizeterm to get and set the current size. The better way to wait a Esc or an Ansi escape sequence, is use the nodelay method. I also added a new scenario to test the Terminal.Gui doesn't freeze while resizing.
Pull Request checklist:

[x] I've named my PR in the form of "Fixes #issue. Terse description."
[x] My code follows the style guidelines of Terminal.Gui - if you use Visual Studio, hit CTRL-K-D to automatically reformat your files before committing.
[x] My code follows the Terminal.Gui library design guidelines
[x] I ran dotnet test before commit
[ ] I have made corresponding changes to the API documentation (using /// style comments)
[x] My changes generate no new warnings
[x] I have checked my code and corrected any poor grammar or misspellings
[x] I conducted basic QA to assure all features are working

When running on MacBook M2 the application crashes immediately.
When I revert changes inconsole_sharp_get_dims (out int lines, out int cols) the problem disappears and I see no more issues.

Thanks. The problem is when I resize the terminal the app doesn't resize. It seem that some method is missing. Can you find what? Maybe ioctl or resizeterm.

I added a definition for toggle the use of ioctl and now it's using the previous behavior. I now see that the issue on resizing isn't happening anymore. Maybe was other code that was causing the issue but I already fixed. Please confirm if it's allright now. Thanks.

I can't make it work with c#
using System.Runtime.InteropServices;

namespace Playground {
	class Program {
		[DllImport ("libc", SetLastError = true)]
		internal static extern int ioctl (int fd, ulong cmd, out winsize argp);

		public static ulong TIOCGWINSZ = 0x40087468;

		public struct winsize {
			public ushort ws_row;
			public ushort ws_col;
			public ushort ws_xpixel;
			public ushort ws_ypixel;
		}

		static void Main (string [] args)
		{
			var result = ioctl (1, TIOCGWINSZ, out winsize ws);

			Console.WriteLine (result);
			if (result == 0) {
				Console.WriteLine ($"Rows: {ws.ws_xpixel}, Columns: {ws.ws_ypixel}");

			} else {
				Console.WriteLine ($"Error code: {Marshal.GetLastWin32Error ()}");
			}

			Console.ReadKey ();
		}
	}
}

https://github.com/gui-cs/Terminal.Gui/assets/76921244/db1c00a9-36ad-4357-87d9-e9ee095a8567
But C++ will always print correct size.
#include <iostream>
#include <sys/ioctl.h>
#include <unistd.h>

int main() {
    struct winsize w;
    if (ioctl(STDOUT_FILENO, TIOCGWINSZ, &w) == 0) {

        std::cout << STDOUT_FILENO << std::endl;
        std::cout << TIOCGWINSZ << std::endl;
        std::cout << "Terminal size: " << w.ws_row << " rows x " << w.ws_col << " columns" << std::endl;
    } else {
        std::cerr << "Failed to get terminal size." << std::endl;
        return 1;
    }

    return 0;
}

I added a definition for toggle the use of ioctl and now it's using the previous behavior. I now see that the issue on resizing isn't happening anymore. Maybe was other code that was causing the issue but I already fixed. Please confirm if it's allright now. Thanks.

 No more issues.

Try with this value TIOCGWINSZ = 0x5413 on c# please. Thanks.

Try with this value TIOCGWINSZ = 0x5413 on c# please. Thanks.
Edit: If that not works, please see what value TIOCGWINSZ has on C++ please.

Now ioctl returns -1, and win32error is 0.
C++ using 0x40087468

Now ioctl returns -1, and win32error is 0.
C++ using 0x40087468

Do you know why you're having the issue before?

Now ioctl returns -1, and win32error is 0.

In this situation you still have used TIOCGWINSZ = 0x40087468 right?

@BDisp  you are chasing your tail here.
Please see my fix to #2610. You'll note that the Chinese.cs scenario works fine:

Conhost

NetDriver
ANSIDriver

WT

NetDriver
ANSIDriver

Please stop trying to hack WindowsDriver to fix this; it's not worth it IMO. If people want to use conhost, they should use netdriver.
Note ANSIDriver is a LONG way from being finished, but it is the right long term architecture. I plan on making it the basis for an updated curses driver too!

Now ioctl returns -1, and win32error is 0.
C++ using 0x40087468

Do you know why you're having the error before?

Before https://github.com/gui-cs/Terminal.Gui/pull/2951/commits/2411b8a32e2c8b3895792dee5c7bc522ff608d04 ioctl was enabled but always return empty winsize and somehow it leaded to EntryPointNotFoundException.

Now ioctl returns -1, and win32error is 0.
C++ using 0x40087468

Do you know why you're having the error before?

Before 2411b8a ioctl was enabled but always return empty winsize and somehow it leaded to EntryPointNotFoundException.
The correct TIOCGWINSZ for my Mac M2 is 0x4008746 (c++ code print this value with correct terminal size)

Now I'm confused. You said before C++ using 0x40087468 and now you are saying it return 0x4008746. Did you forgot to include the 8 at final?

@BDisp


Add user status endpoint

Add the endpoint mentioned in #649

Get the status of a user

I'll close this PR due to this repository isn't maintained anymore. Thanks!


muliple navbar-right elements and their order

right now I am playing around with some navbar styles and I noticed that when I put navbar-right elements (signed-in text and sign out button) I noticed that the order is reversed (which seems legit for CSS float reasons), but when you turn to mobile view, you have then in the right order (which is in fact legit as well) but it isnt expected bahavior of a page when elements suddenly switch order.

I don't think the idea with .navbar-right is to have multiple containers with that class (at least in the docs, there's no such example, which admittedly leaves this as an implied assumption). The solution would be to have an overarching container like a
 and have individual elements, like the signed-in text and sign out button, as inline elements inside it...

I already tried solutions with a span and a p a div was not tried up to now and I see 2 problems. it isnt right and the margins are broken.
This is my code as it is now. any wrappers around it break everything. I guess that the CSS might use the direct descendant operator > for navbar-text and navbar-btn being directly descending after navbar-nav or something similar that will immediately break the layout.
it uses a FontAwesome icon, but I checked that isnt the point of the discussion.

          <button type="button" class="navbar-toggle collapsed" data-toggle="collapse" data-target="#navbar" aria-expanded="false" aria-controls="navbar">
            Toggle navigation

          </button>
          admin

Users

Presentations

Config

Eingeloggt als My1

<button class="btn btn-primary"> Back to Main</button>

Yeah, probably no good way to fix this in v3. An option is wrapping things to be floated in a parent element and manually ordering things within that.

well I got it to work, remove the p around the button and make the text p a span, then a navbar-right span around and it works, even with an a.btn which I think is awesome, okay in mobile layout you get both on one line unless they dont fit, but better than you get them on different lines or similar even on desktop layout.

Yeah, the navbar is a little finicky like that. Hopefully things will be better in v4 :).

but the good thing is that .btn a elements work this way (also you can make them work inside a p if you dont need them wrapped extra (nice little addition for the docs; i use them I can say that).


java: fallback on JAVA_OPTS env variable

Java port is not found when port is not included in the process invocation text
In such cases, it may be possible to get the needed text through the JAVA_PORT environment variable.
from slack discussion
{"level":"fatal","ts":1554974286.446306,"caller":"plank/main.go:27","msg":"debug failed!","error":"Can't find port in java command line arguments for PID: 7825, args: [/bin/sh -c /usr/start_tomcat_with_ddagent.sh ]","stacktrace":"main.main\n\t/workspace/gopath/src/github.com/solo-io/squash/cmd/plank/main.go:27\nruntime.main\n\t/usr/local/go/src/runtime/proc.go:201"}
note that the port is not included, just /bin/sh -c /usr/start_tomcat_with_ddagent.sh
however, the port is included in the JAVA_OPTS:
JAVA_OPTS: -javaagent:/usr/local/aspectjweaver-1.8.11.jar -Dcom.sun.management.jmxremote
    -Dcom.sun.management.jmxremote.local.only=false -Dcom.sun.management.jmxremote.port=9000
    -Dcom.sun.management.jmxremote.rmi.port=9000 -Dcom.sun.management.jmxremote.authenticate=false
    -Dcom.sun.management.jmxremote.ssl=false -Djava.rmi.server.hostname=<IP_ADDRESS>
    -agentlib:jdwp=transport=dt_socket,server=y,suspend=n,address=8000 -Djava.net.useSystemProxies=true
    -Xmx3g

if this strategy does not work, fallback to https://github.com/solo-io/squash/issues/172


US-2024 Updated onSocketChangeEmitted.ts to dispatch the prices in th…

…e init event as implemented in the rif wallet services version 1.2.0
NOTE: This PR should only be merged after the libs have been approved and merged
https://github.com/rsksmart/rif-wallet-libs/pull/105

@Freshenext can you rebase this one? @sleyter93 has finished up refactoring the init event so this should be good but I would like to retest. Thanks!

@Freshenext can you rebase this one? @sleyter93 has finished up refactoring the init event so this should be good but I would like to retest. Thanks!

Will proceed to close this PR as, after rebase, the changes are already there:

Only minor differences, like the name of the property of the object changed, but I saw the current implementation and it changed since I did it.


feat: expmod with variable modulus

Description
This PR implements subset of non-native arithmetic which allows to use non-default modulus for multiplication and subtraction. This is achieved by using non-default modulus in the multiplication checks and reimplementing subtraction padding computation to use non-constant modulus to avoid underflows. Using the implementations, we additionally implement variable-input expmod.
Necessary for implementing expmod precompile.
For witness allocation, we have to still define some upper limit on the modulus which in this case will be 4096 bits i.e. any 64 limb element.
Closes #573
Type of change

[x] New feature (non-breaking change which adds functionality)

How has this been tested?

[x] Variable modulus addition
[x] Variable modulus multiplication
[x] Variable modulus subtraction
[x] Variable modulus equality assertion

How has this been benchmarked?

PLONK variable modulus expmod with 512-bit elements: 967_995
R1CS variable modulus expmod with 512-bit elements: 246_777
PLONK variable modulus expmod with 4k-bit elements: 44_214_331
R1CS variable modulus expmod with 4k-bit elements: 11_675_777
PLONK fixed modulus expmod with 512-bit elements: 673_554
R1CS fixed modulus expmod with 512-bit elements: 172_645
PLONK fixed modulus expmod with 4k-bit elements: 30_052_625
R1CS fixed modulus expmod with 4k-bit elements: 7_997_133

The approx 50% performance penalty comes due to that we're not able to estimate the length of the quotient k in the multiplication check a*b = r + k*p, as when actual value of p decreases then k increases. For fixed-modulus, we know exactly the length of p and can bound the length for k. As k comes from the hint, then this requires more range checking.
Checklist:

[x] I have performed a self-review of my code
[x] I have commented my code, particularly in hard-to-understand areas
[x] I have made corresponding changes to the documentation
[x] I have added tests that prove my fix is effective or that my feature works
[x] I did not modify files generated from templates
[x] golangci-lint does not output errors locally
[x] New and existing unit tests pass locally with my changes
[x] Any dependent changes have been merged and published in downstream modules

cc @yelhousni. FYI the implementation for variable-mod expmod. Maybe there is an approach which uses NAF-decomposition instead of binary for reducing the number of loops in square-and-mul.

cc @yelhousni. FYI the implementation for variable-mod expmod. Maybe there is an approach which uses NAF-decomposition instead of binary for reducing the number of loops in square-and-mul.

@ivokub I couldn't make the 2-NAF approach work with less constraints that the current approach. It's mainly because we need a size-3 Mux and do a multiplication per iteration anyway regardless of the bits representation.
However, this simple edit saves 10k scs:
diff --git a/std/math/emulated/custommod.go b/std/math/emulated/custommod.go
index 2c982228..2f5cbaca 100644
--- a/std/math/emulated/custommod.go
+++ b/std/math/emulated/custommod.go
@@ -87,10 +87,13 @@ func (f *Field[T]) ModAssertIsEqual(a, b *Element[T], modulus *Element[T]) {
 // NB! circuit complexity depends on T rather on the actual length of the modulus.
 func (f *Field[T]) ModExp(base, exp, modulus *Element[T]) *Element[T] {
        expBts := f.ToBits(exp)
-       res := f.One()
-       for i := range expBts {
+       n := len(expBts)
+       res := f.Select(expBts[0], base, f.One())
+       base = f.ModMul(base, base, modulus)
+       for i := 1; i < n-1; i++ {
                res = f.Select(expBts[i], f.ModMul(base, res, modulus), res)
                base = f.ModMul(base, base, modulus)
        }
+       res = f.Select(expBts[n-1], f.ModMul(base, res, modulus), res)
        return res
 }

cc @yelhousni. FYI the implementation for variable-mod expmod. Maybe there is an approach which uses NAF-decomposition instead of binary for reducing the number of loops in square-and-mul.

@ivokub I couldn't make the 2-NAF approach work with less constraints that the current approach. It's mainly because we need a size-3 Mux and do a multiplication per iteration anyway regardless of the bits representation.
However, this simple edit saves 10k scs:
diff --git a/std/math/emulated/custommod.go b/std/math/emulated/custommod.go
index 2c982228..2f5cbaca 100644
--- a/std/math/emulated/custommod.go
+++ b/std/math/emulated/custommod.go
@@ -87,10 +87,13 @@ func (f *Field[T]) ModAssertIsEqual(a, b *Element[T], modulus *Element[T]) {
 // NB! circuit complexity depends on T rather on the actual length of the modulus.
 func (f *Field[T]) ModExp(base, exp, modulus *Element[T]) *Element[T] {
        expBts := f.ToBits(exp)
-       res := f.One()
-       for i := range expBts {
+       n := len(expBts)
+       res := f.Select(expBts[0], base, f.One())
+       base = f.ModMul(base, base, modulus)
+       for i := 1; i < n-1; i++ {
                res = f.Select(expBts[i], f.ModMul(base, res, modulus), res)
                base = f.ModMul(base, base, modulus)
        }
+       res = f.Select(expBts[n-1], f.ModMul(base, res, modulus), res)
        return res
 }

Good catch! Indeed this helps. I also implemented for the fixed-modulus case.


Allow split of watch namespaces

Is your feature request related to a problem? Please describe.
As we want to minimize the rights we'd like to only allow grafana-operator rights to secrets, deployments etc to it's own namespace but be able to read GrafanaDashboards from all namespaces.
Describe the solution you'd like
The environment WATCH_NAMESPACE specifies what namespaces should be watch.
Perhaps we could have optional WATCH_NAMESPACE_DASHBOARD which would override the namespace for watching for GrafanaDashboards, where "*" would be cluster-wide.
Describe alternatives you've considered
Additional context
Existing solutions

We probably shouldn't call it WATCH_NAMESPACE_DASHBOARD. I guess this is interesting for all grafana resources. Including folders and datasources.

I think I'd like to keep more complicated RBAC outside of grafana-operator, as in our case that would simplify maintenance of such RBAC internally.
I see two scenarios:

Namespaced installation, watching cluster scope for grafana CRDs
Namespaced installation, watching specified NS for grafana CRDs

I'll give it a try, perhaps even during this week.
What do you think about WATCH_NAMESPACE_CRDS?

Agreed.
Hmm it's not a perfect name, but I can't come up with any better right now.
Start with WATCH_NAMESPACE_CRD it's easy enough to change after :)
Thanks @smuda , looking forward to the PR.

I have seen other controllers watch namespaces with a certain label. That way you don't need to reconfigure the controller, instead label the new namespace.

@smuda the proposed solution sounds good and is similar to the way the Prometheus Operator solves this (a list of namespaces where resources can be located). The user would have to provide the rbac for the operator service account for the permissions to those namespaces.

@smuda have you had any time to look into this issue?
I think many people would love to see this feature.

Yes, I've started to implement with a label-based approach (therefor multi-namespace), but keeping the specified konfiguration for a specific namespace. I'm not finished yet though and it will probably take a few more weeks since I'm on vacation and the weather is nice. 😀 After that I'll have PR ready for discussion.


Bug Fix in many Calculators

I want to fix some bugs like in a few calculators
like--Integration, Derivation, Complex Modulo/argument, Standard Deviation , Complex number calculators
reset buttons are not present in this calculator so I want to add a reset button .
and in the pythogorous theorem Calculator CSS is not loading you can check it.

I want to fix all these bugs under JWOC.

@LuckySingh9897 Go for it.


 In these cases, we reads from specific instance then writes to another instance, but these both instance must have exactly same responsibility for assined hash slots. We can do that dirtily (i.e. maching class name of model) but mixed_guage can support these cases by having that mapping internally and offering interface to get mapped model class.

👍


farmer dashboard

I think that the farmer dashboard should say the correlation between farm code on the field ID and the numerical sequential order, because it would be hard for the grower to know which farm is which on the water tab.

Yep, that's a bug that needs to be fixed. I'm trying to move away from
having the three-letter codes be visible at all, and just show the
numerical order.
On Tue, Jul 7, 2020 at 11:04 AM elhenriq<EMAIL_ADDRESS>wrote:

I think that the farmer dashboard should say the correlation between farm
code on the field ID and the numerical sequential order, because it would
be hard for the grower to know which farm is which on the water tab.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/precision-sustainable-ag/On-farm-Protocols/issues/13,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/ADFYPQFG3HCUV3BB4F4WVW3R2M2P5ANCNFSM4OS5CVFA
.


Adding mark command

Codecov Report

Merging #54 (6e0897e) into master (02a9e70) will decrease coverage by 2.51%.
The diff coverage is 0.00%.

@@             Coverage Diff              @@
##             master      #54      +/-   ##
============================================
- Coverage     54.60%   52.08%   -2.52%
  Complexity      369      369
============================================
  Files            93       97       +4
  Lines          1531     1605      +74
  Branches        155      161       +6
============================================
  Hits            836      836
- Misses          652      726      +74
  Partials         43       43

Impacted Files
Coverage Δ

...main/java/seedu/address/commons/core/Messages.java
0.00% <ø> (ø)

...java/seedu/address/logic/commands/MarkCommand.java
0.00% <0.00%> (ø)

.../seedu/address/logic/parser/AddressBookParser.java
72.72% <0.00%> (-3.47%)
:arrow_down:

.../seedu/address/logic/parser/MarkCommandParser.java
0.00% <0.00%> (ø)

src/main/java/seedu/address/model/AddressBook.java
53.33% <0.00%> (-3.81%)
:arrow_down:

src/main/java/seedu/address/model/Model.java
100.00% <ø> (ø)

...rc/main/java/seedu/address/model/ModelManager.java
58.62% <0.00%> (-3.20%)
:arrow_down:

...ava/seedu/address/model/task/DistinctTaskList.java
30.76% <0.00%> (-13.68%)
:arrow_down:

src/main/java/seedu/address/model/task/Task.java
0.00% <0.00%> (ø)

...main/java/seedu/address/model/task/TaskStatus.java
0.00% <0.00%> (ø)

... and 3 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.


Dependency conflict with tensorflow 2.12 because of numpy>=1.24.2 requirement

Hi, on colab tensorflow 2.12 is default. And Gym-Trading-Env has a numpy>=1.24.2 requirement.  But this end in a dependency conflicts:
ERROR: pip's dependency resolver does not currently take into account all the packages that are installed. This behaviour is the source of the following dependency conflicts.
tensorflow 2.12.0 requires numpy<1.24,>=1.22, but you have numpy 1.24.3 which is incompatible.
numba 0.56.4 requires numpy<1.24,>=1.18, but you have numpy 1.24.3 which is incompatible.

Question: Is numpy>=1.24.2 mandatory for Gym-Trading-Env?

Hi, for now, you can try to update pip using:
pip install --upgrade pip
Then !pip install gym-trading-env should work (it works for me at least)

A pip upgrade does not change the issue. But the dependency conflict with numpy 1.24.3 is more a less just unpleasant. You can import gym-trading-env
But colab behaves odd when looping the observation space. It get stuck in:
while not done and not truncated:
    print(info)
    print(observation)
    action = env.action_space.sample()
    observation, reward, done, truncated, info = env.step(action)
print(info)

You can check: https://colab.research.google.com/drive/12AxChYkE-I1Q1JqC_eThQzGMP3wStqEb?usp=sharing

Maybe i just run out of "compute units" on colab... If it works fine for you in this colab? Then close this issue. But the dependency conflict with numpy is unpleasant if you share code samples in colab. Therefore the original question / suggestion if numpy>=1.24.2 is mandatory.

Hi thank you for the reply. Indeed, I am sorry, I misunderstood the issue. I fixed the conflict by lower the version of Numpy needed ;)


Quick Start via docker-compose is not working

Hello,
I would like to use docker-redmine 3.0.3 (f7e679395bdf11f653cfeb32b54e93fdcd671000) on an ArchLinux host (Linux 4.0.5-1-ARCH and Docker v1.6.2), but apparently it is not working properly.
I am using the docker-compose.yml that you provide in this repository and these are the last lines:

redmine_1    | 2015-06-11 17:27:45,030 INFO success: unicorn entered RUNNING state, process has stayed up for > than 1 seconds (startsecs)
redmine_1    | 2015-06-11 17:27:45,030 INFO success: cron entered RUNNING state, process has stayed up for > than 1 seconds (startsecs)
redmine_1    | 2015-06-11 17:27:45,030 INFO success: nginx entered RUNNING state, process has stayed up for > than 1 seconds (startsecs)

Unfortunately pointing the browser to http://localhost:10083 shows nothing. Is there anything more I could try?

@jokogr the output looks fine to me. If your docker host is a virtual machine, then you will not be able to access the redmine application using http://localhost:10083, you should rather use the ip address of the docker host.

@sameersbn you were right, it was an issue with iptables. Everything is working as intended now.


[Incomplete/Bug in documentation] samples folder missing

Greetings Team,
The official documentation mention samples folder that is not available in the repository.
The samples I found so far are here https://github.com/microsoft/BotBuilder-Samples/tree/master/generators/python
https://github.com/microsoft/BotBuilder-Samples/tree/master/samples/python/01.console-echo

@Maijin Where is the reference in the docs to that?  There is a 01.console-echo sample, but not in the path ("generators") you list.

@tracyboehrer - The documentation claims that https://github.com/microsoft/botbuilder-python/ contains a samples folder which doesn't exist - that's the problem.
The references I posted may be what is this samples/ supposed to be. I don't work at microsoft so I have no idea :/ but that official documentation is definitely incomplete/wrong and should be fixed as samples are essentials to get a grasp on how to use botbuilder-python 👍

@Maijin I see what you are saying. That document is out of date. All of the Python samples exist in the BotBuilder-Samples repository.
You can find them at:
https://github.com/microsoft/BotBuilder-Samples
We will correct the document with the outdated link.

thanks!

Closing.  Docs issue opened at: https://github.com/MicrosoftDocs/bot-docs/issues/1705


Support integration tests

Closes  #66
The approach took is really similar to one suggested in the issue.
I also considered a allowance mechanism similar to what ecto and mox do, but IMO we can accomplish a similar result with a much simpler solution. For the use case of swoosh, just making sure that the messages are sent to the test process seems to be enough to allow users to do integration tests.

Hi @thiamsantos, thanks for another great PR. I made a couple changes. Could you take a look?

Hi @thiamsantos, thanks for another great PR. I made a couple changes. Could you take a look?

@princemaple The documentation is much better now after your changes, thanks :)

@princemaple The documentation is much better now after your changes, thanks :)

Thanks for taking another look! I'll make a release next week.

Thanks for taking another look! I'll make a release next week.


failure to authenticate?

when i attempt to connect to the multiplayer it says that there was a failure to authenticate. i was able to play for like 4 hours without issue before this happened.

specifically says "disconnect. authentication failed"

This issue is effecting everyone check up on #announcements on discord for updates about this stuff

thanks man

could i get an invite? the link on here doesnt work.

https://discord.gg/r2northstar


NoMethodError: undefined method `provider' for #<User

I am facing this error
 > a=User.create
   (3.0ms)  BEGIN
   (0.1ms)  ROLLBACK
NoMethodError: undefined method `provider' for #<User:0x0000000008433390>

I don't have uid and provider fields in users table. However, I have moved these fields to auth_identities table.
can I make devise_token_auth not to search for the fields uid, provider?

@shivabhusal Yeah you can.

in config/initializers/devise_token_auth.rb uncomment this line and make it false

  config.change_headers_on_each_request = false

search for config.other_uid and set it to whatever field you want.
Create app/controllers/devise_token_auth/concerns/resource_finder.rb file with

module DeviseTokenAuth::Concerns::ResourceFinder
  extend ActiveSupport::Concern
  include DeviseTokenAuth::Controllers::Helpers

  def provider
    "${new_attribute_name}"
  end
end


AWS S3 Select compatible feature underway

this seems an error.

@chrislusf Yes, there is. It's only partial. Work is underway.


JBPM-5315 RHBPMS-4251 Removed usage of IOUtils.closeQuietly when closing Scanner instance.

Substituted use of IOUtils.closeQuietly with scanner.close() so it works on JDK 1.6.

No master PR, because jdk 1.6 currently not relevant there.

+1


Closure compiler support (missing java)

Hi,
we're setting --closure 1 to optimize the wrapper code.
It causes the following error:
WARNING:root:java does not seem to exist, required for closure compiler, which is optional (define JAVA in /root/.emscripten if you want it)
ERROR:root:fatal: closure compiler is not configured correctly

Maybe we should add java to the Docker images?

Hi, I think that this will be reasonable to pull it into the image, since Emscripten uses java.
Since #2 is fixed, but I haven't recompiled remaining images, I'll put Java and then push missing containers.

Unfortunately it's another 90MB added to this image :(

Unfortunately it's another 90MB added to this image :(

Yes. But downloading 90MB once will be faster than installing Java every time we create a new container with this image.

Hi, It's not so bad. I managed to keep size ~300MB, and it includes: java, nodejs, python, make, cmake.
I've triggered compilation process, it will take ~1d to push every tag. Cheers!

Done, please let me know if you see any other tool useful to have within the image.

Just tried trzeci/emscripten:sdk-tag-1.37.3-64bit and it didn't work:
WARNING:root:java does not seem to exist, required for closure compiler, which is optional (define JAVA in /root/.emscripten if you want it)

I tried trzeci/emscripten:sdk-tag-1.37.16-64bit and it won't work because of #4.

Hi, java was added from 1.37.10 and further. About wget, let's continue on #4


Jan after trial with marcel

Here are the five questions that I have for the changes:

Do you agree that we should delete the effort question? I disagree (maybe specify it), because I think it is nicer to have a measure on a scale than just their comments throughout the interview.
Please think about the definition of a fabricated data set (Marcel suggested something like "data that is not generated for the experiment itself")
Please include the definition here at the very top under background information for the interviewer or text me and I will include it
I am not very sure about the blocks: Are the when and why questions really when and why questions? How are the "What" and "How" questions different? I tried to give labels to the blocks but please check whether you think this is fine.
Do you think that I should include one section at the beginning in which I explain that I am a stutterer. During the interview, participants may realize that I stutter without really knowing what is going on.

Changed How much effort did you invest to fabricate the data on a scale from 1(no effort at all) to 7 (a lot of effort)? to How much effort do you feel you invested in fabricating the data on a scale from 1 (no effort at all) to 7 (a lot of effort)?. This will be an exploratory measure and we can decide what to do with it after.

Incorporated. Definition of data fabrication: data that is not collected for the experiment in question, but data that is reused from another experiment or artificially created

See 2.

I think your descriptions are apt. When and why are most different, but I agree that what and how are similar --- the differentiation you makes it clearer what the difference is between what and how.

Maybe it is best to announce that when you arrive and meet the person. I think it is most important that if you feel it needs to be addressed, that you do --- but if you feel it is irrelevant I also think there is no specific need to mention it. In other words, what you are more comfortable with.

Sounds good! Looking forward to tomorrow!
On Thu, Jan 5, 2017 at 1:22 PM, Chris Hartgerink<EMAIL_ADDRESS>wrote:

Changed How much effort did you invest to fabricate the data on a
scale from 1(no effort at all) to 7 (a lot of effort)? to How much
effort do you feel you invested in fabricating the data on a scale from 1
(no effort at all) to 7 (a lot of effort)?. This will be an
exploratory measure and we can decide what to do with it after.
2.
Incorporated. Definition of data fabrication: data that is not
collected for the experiment in question, but data that is reused from
another experiment or artificially created
3.
See 2.
4.
I think your descriptions are apt. When and why are most different,
but I agree that what and how are similar --- the differentiation you
makes it clearer what the difference is between what and how.
5.
Maybe it is best to announce that when you arrive and meet the person.
I think it is most important that if you feel it needs to be addressed,
that you do --- but if you feel it is irrelevant I also think there is no
specific need to mention it. In other words, what you are more comfortable
with.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/chartgerink/2015ori/pull/25#issuecomment-270632334,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AU80_VvGjeFquxsY6MmexJ1avbFeIRVfks5rPOCAgaJpZM4LMKC6
.


request help: Unable to enable Apisix plugins on ingress resource using ApisixPluginConfig

Issue description
I have setup apisix on kubernetes and deployed a test pod. I was then following Annotation guide to enable plugins on my ingress resources which I deployed using the following yaml:
apiVersion: networking.k8s.io/v1
kind: Ingress
metadata:
  name: hello-world2
  namespace: demo
  annotations:
    k8s.apisix.apache.org/plugin-config-name: demo
    k8s.apisix.apache.org/plugin_config_name: demo
    kubernetes.io/ingress.class: apisix
spec:
  rules:
    - host: demo2.k8s.example.com
      http:
        paths:
          - backend:
              service:
                name: hello-kubernetes-hello-world
                port:
                  name: http
            path: /*
            pathType: ImplementationSpecific
---
apiVersion: apisix.apache.org/v2
kind: ApisixPluginConfig
metadata:
  name: demo
  namespace: ingress-apisix
spec:
  plugins:
  - name: echo
    enable: true
    config:
      before_body: "This is the preface"
      after_body: "This is the epilogue"
      headers:
        X-Foo: v1
        X-Foo2: v2
  - name: response-rewrite
    config:
      headers:
        XXX: tribleX

Apisix is setup in the "ingress-apisix" namespace. I believe the "ApisixPluginConfig" should be in the same namespace as noted in here: https://github.com/apache/apisix-ingress-controller/blob/master/docs/en/latest/concepts/annotations.md#use-apisixpluginconfig

When I access the route, I get the content of the deployed pod however I cannot see any Apisix plugins taking effect. Namely there are no additional response headers.

I took the additional step to use the Apisix Api to overwrite the auto generated routes by the ingress controller to add the plugin configuration.
This immediately worked but the goal is to use the plugins on the routes defined in the ingress definition.
Appreciate your feedback.
Environment

apisix-ingress-controller version: apache/apisix-ingress-controller:1.4.1
your Kubernetes cluster version (output of kubectl version): v1.21.14

This feature was implemented in version v1.5 #1139
You can use the v1.5.0-rc1 version for testing.
Now we have entered the v1.5.0 release window. Expected to be available next week

@tao12345666333 thank you for your feedback.
I didn't see this was just released. I appreciate the feedback and will test it with the newer release soon.

thanks, please follow #1351 for detail

I will close this one.


unable to download full soundcloud playlist

https://soundcloud.com/skeewiff/sets/i-got-soul-1
There are 10 track total. All tracks can be downloaded on by one, but only 6 will be downloaded by
$ youtube-dl https://soundcloud.com/skeewiff/sets/i-got-soul-1

same problem whit downloading all tracks of specific user.

@c-e-p-x-u-o there are only 6 tracks now on this page, all of them downloaded fine.

@skiddie9 open new issue.

21 Sep 2015 there were 10 tracks. I've downloaded them all!
And now, 8 month later, when you've decided to check it, there are only 6 tracks.
Thank you for prompt response!

And few years later I have the same problem with a playlist with more than 100 tracks. The download stop after 5 downloaded songs.


[Task]: BEAM INPUT - BEAM OUTPUT instead of Beam File Input - Beam File Output

What needs to happen?
Correct transform page name
Beam File Input - Beam File Output
Issue Priority
Priority: 3
Issue Component
Component: Documentation

.take-issue


Quarantine flaky sig-operator test that dynamically detects DV support

What this PR does / why we need it:
The following test appears to be very flaky and impacting across the 1.25 and 1.26 lanes[1][2]
[Serial][sig-operator]Operator [rfe_id:2897][crit:medium][vendor:cnv-qe@redhat.com][level:component]Dynamic feature detection [test_id:3153]Ensure infra can handle dynamically detecting DataVolume Support
[1] https://search.ci.kubevirt.io/?search=test_id%3A3153&maxAge=48h&context=1&type=bug%2Bissue%2Bjunit&name=&excludeName=&maxMatches=5&maxBytes=20971520&groupBy=job
[2] https://storage.googleapis.com/kubevirt-prow/reports/flakefinder/kubevirt/kubevirt/flakefinder-2023-06-13-024h.html#row0
Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #
Special notes for your reviewer:
/cc @dhiller @maya-r @xpivarc
Release note:
NONE

@maya-r would it make sense to quarantine this one for release-1.0 also?

if you find it to be too flaky, go for it


Be stricter when extracting HTTP/S hrefs

Change HtmlPage.getAllHttpHrefStringsAsSet to also include the scheme
separator when matching the hrefs.
Update test to cover hrefs with local files that start with http and
https.
Fix #206 - Extraction of external links is too lenient

(The build is failing because of a previous change.)

I'll have a look at this proposal asap - want to investigate why travis build fails

That's because of this assertion:
https://github.com/aim42/htmlSanityCheck/blob/9ddf7668a02b30a2fd93415df8c8ac44bc1754bd/src/test/groovy/org/aim42/htmlsanitycheck/check/CheckerCreatorSpec.groovy#L150
the path is null by default for that checker.


Disable generating man pages

The share/man/ directory is still produced with this change, but it remains empty

Looks like BinaryBuilder's "sf/bb8" branch was merged to master. Will update the CI

@nicoleepp can you rebase these changes?

@omus Rebased


refactor faqs; update gpu faq with MPS.

add informative ending to each FAQ file name.
format to line length 88
add information about MPS as GPU device.

Let's wait for #946 to be merged and then fix the conflict here.


tests: kernel: alert: Add testcases

Add testcases for following scenario
Test to check alert_recv(timeout) against the following cases

The current task times out while waiting for the event.
There is already an event waiting (signalled from a task).
The current task must wait on the event until it is signalled
from either another task or an ISR

Test to check alert_recv(K_FOREVER) against the following cases:

There is already an event waiting (signalled from a task and ISR).
The current task must wait on the event until it is signalled
from either another task or an ISR

Test to checks that the event handler is set up properly when
alert_event_handler_set() is called.  It shows that event handlers
are tied to the specified event and that the return value from the
handler affects whether the event wakes a task waiting upon that
event
Signed-off-by: Savinay Dharmappa<EMAIL_ADDRESS>

Codecov Report

Merging #6606 into master will increase coverage by 0.06%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master    #6606      +/-   ##
==========================================
+ Coverage   53.51%   53.57%   +0.06%
==========================================
  Files         437      437
  Lines       41420    41478      +58
  Branches     7935     7937       +2
==========================================
+ Hits        22165    22223      +58
  Misses      16038    16038
  Partials     3217     3217

Impacted Files
Coverage Δ

...s/kernel/alert/alert_api/src/test_alert_contexts.c
98.23% <100%> (+0.91%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fa57ebd...453d3b4. Read the comment docs.


How to invoke subrequests?

I would like to perform subrequests in the route "controller". For example if I have payload that contains a single entry I will process it but in case it is a batch I would like to call the server internally for each of those entries so they can be a) processed separately and b) avoid having to write conditions and loops in order to process the batch in the same controller.
Is this possible?

This is currently not that easy I guess. The best way would be calling your controller for each sub-request, instead of invoking the Aerys dispatch process.


SQS Redrive policy - fix included.

Hello,
In order to create an SQS Redrive policy I had to first make a change to aws/types.yaml.
-   DeadLetterTargetArn: String
-   MaxReceiveCount: Integer
+   deadLetterTargetArn: String
+   maxReceiveCount: Integer

This is my first public contribution to another persons code.  If you give me access to submit new branches I will gladly create a PR and, future PR's for any other things I find.
I have created a new project based on yours as I am using your project at a Fortune 100 company.  I have created an SQS template that will build multiple stacks.  I plan to create more useful templates using cfndsl in the future.  You can find my repo at: https://github.com/devops-dude/cfndsl-useful

I realized I could probably just fork and then create a PR.  Done.


Feature to allow moving custom sounds folder

We're going to be implementing automatic sound pack installations via our website soon. So accessing your custom sounds folder will become less important, so I'll close this as not-planned. Alongside the update to install from our website, we'll also move the sounds folder so that it's not polluting your home folder.


Merge GO:0039650 suppression by virus of host cysteine-type endopeptidase activity involved in apoptotic process

Merge into parent GO:0019050 suppression by virus of host apoptotic process
1 keyword
UniProtKB-KW:KW-1085 Inhibition of host caspases by virus
Can move to  GO:0019050 suppression by virus of host apoptotic process
Thanks, Pascale

Likewise for GO:0039651

[ ] induction by virus of host cysteine-type endopeptidase activity involved in apoptotic process  -> merge into GO:0019051 induction by virus of host apoptotic process

[ ] @Antonialock Please replace KW-1073 for GO:0019051 induction by virus of host apoptotic process

In the same branch:
changed labels:

[ ]  GO:0033668 negative regulation by symbiont of host apoptotic process
+name: suppression by symbiont of host apoptotic process

[ ] GO:0052041 negative regulation by symbiont of host programmed cell death
+name: suppression by symbiont of host programmed cell death

[ ] GO:0052042  positive regulation by symbiont of host programmed cell death
+name: induction by symbiont of host programmed cell death


no workaround for  minikube start up on win 10 home

Error: [VBOX_VTX_DISABLED] create: precreate: This computer doesn't have VT-X/AMD-v enabled. Enabling it in the BIOS is mandatory
C:>minikube start

minikube v1.6.2 on Microsoft Windows 10 Home Single Language 10.0.18362 Build 18362
Selecting 'virtualbox' driver from existing profile (alternates: [])
Creating virtualbox VM (CPUs=2, Memory=2000MB, Disk=20000MB) ...

X Unable to start VM. Please investigate and run 'minikube delete' if possible

Error: [VBOX_VTX_DISABLED] create: precreate: This computer doesn't have VT-X/AMD-v enabled. Enabling it in the BIOS is mandatory
Suggestion: Virtualization support is disabled on your computer. If you are running minikube within a VM, try '--vm-driver=none'. Otherwise, consult your systems BIOS manual for how to enable virtualization.
Related issues:

https://github.com/kubernetes/minikube/issues/3900
https://github.com/kubernetes/minikube/issues/4730

If the above advice does not help, please let us know:

https://github.com/kubernetes/minikube/issues/new/choose

It sounds like you need a computer with hardware virtualization enabled @atanu2531
Are you able to try enabling that and see if it helps?
/triage support

Facing same issue and i don't have access to BIOS password.
I disabled it by mistake by running one command( though it still shows Virtualization enabled in Task Manager, Performance Tab). Now minikube start is giving errors in win 10 and does not see any work around.


Text Field doesn't resize on setState + linked state.

If you use valueLink and update the value in code and not through input into the text field, it doesn't update its height, causing text to sometimes overflow. The solution is probably to recalculate on render in EnhancedTextArea, but I'm not sure that's the problem.

@quadrupleslap : Do you still have this issue?This seems to be more of a use-case related issue rather than that to do with the library. Hence i am closing this for now.
Do let me know if you need any further help with this let me know I will reopen this issue for you.

Uh, yes, this issue is still present. On the other hand, this is a pretty niche case, so I guess that's fair. I solved it anyway, by copying most of the code and changing a couple of lines.

@quadrupleslap : Thanks for your response. Appreciate it.
Also, we did away with valueLink anyway now.


[ENTESB-21851] Support Elytron in Wildfly Camel security

Issue: https://issues.redhat.com/browse/ENTESB-21851
DomainAuthenticationPolicy doesn't work with Elytron (it doesn't even work with JDK 17). I've added a ElytronAuthorizationPolicy that is an alternative that mimics DomainAuthenticationPolicy as much as possible.

If client code provides UsernamePasswordPrincipal just as before, it will authenticate the provided user and checks his roles
If no UsernamePasswordPrincipal is provided, it will check currently logged user. This is a new feature that I believe will be very helpful since it doesn't need a password to be provided in a plain text (security leak!). Legacy Wildfly security wasn't able to provide currently logged user, but Elytron is able to do so.
Domains (DomainPrincipal) are no longer taken into account since Elytron doesn't use named ones.

This project is archived


Update 'Removing RSSMii' entry in the site navigation page.

Description
The Removing RSSMii page does not exist. Removal instructions have been moved to the main RSSMii page. This commit updates the entry to point to the removal instructions on that page.

test

I think it would be better to just link to RSSMii instead of the removal section. It's a site-navigation for a reason.

Alright, I'll remove the entry then!


Lenses in favour of Kagi Search bangs

Currently there are 166 Kagi Search bangs for kagi.com using site:[url] filters, such as /search?q={{{s}}}+site%3Atv.apple.com. These bangs can be replaced with Lenses, should they be removed?

I think they're fine as-is for now. It could be possible to replace these with lenses where the bang activates the lens, but this would require creating 166 new lenses for everyone (when there's currently only ~7 default ones).

Personally I don't think most of these are needed as they can be replaced with the website search instead of relying on site:[url].
Lookg at the first few results, /search?q={{{s}}}+site%3Atv.apple.com could be replaced with https://tv.apple.com/search?term={{{s}}}, I see little value in using Kagi for searching Apple TV. The !aeris bang seems to search for open source projects of a user named "aeris" and should probably be removed. The !agdl bang doesn't support https. The !ang bang can be replaced with search inside angluar.io.
Personally I think if a user really wants to filter for a site, they can add their own lens. Kagi already supports assigning shortcuts (bangs) to a lens.

That's completely fair, and if there are on-site searches that are quality enough, I think we should move to those instead. If you wanted to open a PR for these, that would be appreciated, otherwise I can take a look at migrating them soon.
Until we add more metrics about how often bangs are used, I don't want to remove bangs people could be relying on even if they're site search ones.

Until we add more metrics about how often bangs are used, I don't want to remove bangs people could be relying on even if they're site search ones.

That's fair. I can work on cleaning up some of the existing bangs. Personally, I feel that many of the existing bangs violate the listed contribution guidelines, such as low traffic sites. I would prefer less bangs in favor of more quality, after all users still have the ability to add their own bangs if they need it. But I understand that these decisions are very opionated and hard to judge without metrics.


avoid possible fk constraint violations

https://vizzuality.atlassian.net/browse/MARXAN-1367
using BullMQ job ids to assemble externalId values for API events may lead to FK constraint violations as these job ids cannot be guaranteed to be forever monotonic.
This PR removes the use of externalId altogether for one kind of API events where this should not be needed, and adds @todo annotations to remove the dependency on job ids in other relevant code paths.

@aciddaute I would appreciate some help from the AT crew on this: I started this PR from the related Jira task (https://vizzuality.atlassian.net/browse/MARXAN-1367) to fix a potential issue with possible clashes of externalId values for the API_EVENT_KINDS.scenario__protectedAreas__submitted__v1__alpha events (see diff) but in general, the same issue may affect other parts of the codebase where we fire events that include a externalId based on sources that are not guaranteed to be monotonic or unique.
In most of the cases we assemble externalId from UUIDs (for example, all the instances that you and the AT crew added using  ApiEventsService.composeExternalId(), IIRC), however I would be keen to try to actually remove dependencies on externalId being set where this is not strictly necessary.
For context, this property was introduced by Dominik (IIRC) when working on the geoprocessing of geofeatures (split, stratification and so on) in order to make sure we would not try to process events twice when they originate from external sources, combining a unique constraint on the column with handling conflicts via ApiEventsService.createIfNotExists().
tl;dr I would like to make sure we try to use externalId only when strictly necessary for the purposes it was created for, and in any case that we don't rely on BullMQ job ids or other "external" ids that cannot be guaranteed not to lead to unnecessary constraint violations (because the duplication would come from a reset of the external source of "uniqueness", for example, as in the case with BullMQ job ids) - would you mind reviewing the uses of externalId you and the AT crew added, to confirm if they are all needed and guaranteed to be unique (unless we're genuinely trying to pick up an event from an external source more than once, for whatever reason)? I can take care of the rest.

Sure! I'll review them 👍

The only justified use of externalId property within the api events that we've worked with is in MarkExportAsFailedHandler (here) . When a export-piece job fails a ExportPieceFailed event is emitted. ExportPieceFailedSaga handles that event and sends a MarkExportAsFailed command which is handled by MarkExportAsFailedHandler. In case N jobs fails before they are cancelled this command handler will be called N times, creating N "export-failed" api events. In any case, generated externalIds will be unique since they are composed by a uuid (export identifier).
List of unnecessary externalIds:

Export piece finished event in ExportPieceEventsHandler
Export piece failed event in ExportPieceEventsHandler
Export piece failed event in MarkExportPiecesAsFailed command handler
Import piece finished event in ImportPieceEventsHandler
Import piece failed event in ImportPieceEventsHandler
Blm calibration finished event in BlmCalibrationEventsService
Blm calibration failed event in BlmCalibrationEventsService
Blm calibration submitted event in StartBlmCalibrationHandler

The only justified use of externalId property within the api events that we've worked with is in MarkExportAsFailedHandler (here) . When a export-piece job fails a ExportPieceFailed event is emitted. ExportPieceFailedSaga handles that event and sends a MarkExportAsFailed command which is handled by MarkExportAsFailedHandler. In case N jobs fails before they are cancelled this command handler will be called N times, creating N "export-failed" api events. In any case, generated externalIds will be unique since they are composed by a uuid (export identifier).
List of unnecessary externalIds:

ok, understood - thanks for cross-checking! I'll remove them when I get back to this PR on Monday.


Add logic for self-selected game type

What Issue Are You Seeing or What Feature Needs To Be Added?

[x] write a function to initiate a Self-Selected game ( See create_session_games)
. -- We will eventually incorporate this into the session creation process, but not now.

A self-selected game has GameType with network=NETWORK_TYPE_SELF_SELECTED, name_hidden=False (default)
The players must be initiated into the game as well such that game.players returns the 6 players.
(Reuse this function:)

[x] add a new table or update game player table to capture the network.

Probably best to have three columns Game id (FK) Player id (FK) and Neighbor id (FK). (Each row is a single directional relationship)

1 player from each language group gets to choose 3 partners, the others get to chose 2 (you can use the players position to determine if they get 3 or 2  (e.g. position 1 and 4 get 3 neighbors).

We use GameUtil class access the network. We need to add code so that If the network type is NETWORK_TYPE_SELF_SELECTED, we go and pull the network

[ ] make a GET route that allows students to pick partners (see language / layout in UX document)

[ ] make a POST route that updates the network and then sends the player to the round route.

Are There Any Links That Would Be Helpful?

Progress Update @anisfeld @pepipandi:
I have created a route to allow students to choose who they want to see, along with the new required table in the DB

Still to go:

When chosen, post request to add those neighbors to the new table
Extract those positions to game_util
Adjust round router logic for self-selected


ENH: Base implementation for our GP kernels

Follows scikit-learn's PairwiseKernel implementation to integrate Andersson's kernels in the original eddy papers.

Only missing the derivative of the kernel :P -- will look at that next week.
Fixed the test with the DotProduct + WhiteKernel
Seems to be pointing at the right direction :)

Okay, moving on - the plot looks very reasonable and I think this is in good shape. Bear with me @jhlegarreta :)


fix: Fix the case issue that would block the building in linux system

#minor
Small fix.
Change Microsoft.Bot.Builder.AI.Luis folder name to Microsoft.Bot.Builder.AI.LUIS

Pull Request Test Coverage Report for Build 257700

0 of 0   changed or added relevant lines in 0 files are covered.
2 unchanged lines in 2 files lost coverage.
Overall coverage remained the same at 76.128%

Files with Coverage Reduction
New Missed Lines
%

/libraries/AdaptiveExpressions/BuiltinFunctions/GetNextViableTime.cs
1
90.91%

/libraries/AdaptiveExpressions/BuiltinFunctions/GetPreviousViableTime.cs
1
90.91%

Totals

Change from base Build 257660:
0.0%

Covered Lines:
23120

Relevant Lines:
30370

💛  - Coveralls

Could you paste the build errors in linux system as well?


Nice catch :)


Fixing last access time on Windows to unblock python.

@jstarks @jhowardmsft @darrenstahlmsft @tiborvass
Last access time is not included in the tar header created by the GO language on Windows.  To avoid setting the last access time to the beginning of the Linux epoch, we will use last modified time instead (since last access time should always be at least last modified time, if not later).  This fix is required for python in Windows containers, since python will refuse to load any files with invalid last access times.
Confirmed the fix by testing python in a Windows container, which works with this change.
Signed-off-by: Stefan J. Wernli<EMAIL_ADDRESS>

@thaJeztah windows TP4 please :)

Yay, green - hit rebuild enough times and you hit a good Windows CI machine :)

ping @duglin @tiborvass PTAL it's green \o/

LGTM

LGTM


Corrected Pocket redirection URL

This one fixes a 404 during access token generation.

Coverage remained the same at 28.16% when pulling ec82fa1354808f8c5771149892287086fbb1f9ae on vaygr:pocket-rdr into 2b818888a654b673feaaf1f281e43bdebe50da89 on akrennmair:master.

Coverage remained the same at 28.16% when pulling ec82fa1354808f8c5771149892287086fbb1f9ae on vaygr:pocket-rdr into 2b818888a654b673feaaf1f281e43bdebe50da89 on akrennmair:master.

Coverage remained the same at 28.16% when pulling ec82fa1354808f8c5771149892287086fbb1f9ae on vaygr:pocket-rdr into 2b818888a654b673feaaf1f281e43bdebe50da89 on akrennmair:master.

I'd rather see this referencing specific commit rather than master branch. This way we can have version-specific messages, and also perform refactorings without breaking anything for existing users.

How'd we get the commit that hasn't been made yet?

Use the one that most recently changed the file, i.e. c8c92a17.

Oh, not just the latest one, got it. Good point.

Coverage remained the same at 28.16% when pulling 7314ab86f4496c3ac57d69efc96b4c8f71aeb306 on vaygr:pocket-rdr into 2b818888a654b673feaaf1f281e43bdebe50da89 on akrennmair:master.

Thanks!


[AIRFLOW-6038] AWS DataSync example_dags added

Make sure you have checked all steps below.
Jira

[ ] My PR addresses the following Airflow Jira issues and references them in the PR title. For example, "[AIRFLOW-XXX] My Airflow PR"

https://issues.apache.org/jira/browse/AIRFLOW-XXX
In case you are fixing a typo in the documentation you can prepend your commit with [AIRFLOW-XXX], code changes always need a Jira issue.
In case you are proposing a fundamental code change, you need to create an Airflow Improvement Proposal (AIP).
In case you are adding a dependency, check if the license complies with the ASF 3rd Party License Policy.

Description

[ ] Here are some details about my PR, including screenshots of any UI changes:

Tests

[ ] My PR adds the following unit tests OR does not need testing for this extremely good reason:

Commits

[ ] My commits all reference Jira issues in their subject lines, and I have squashed multiple commits if they address the same issue. In addition, my commits follow the guidelines from "How to write a good git commit message":

Subject is separated from body by a blank line
Subject is limited to 50 characters (not including Jira issue reference)
Subject does not end with a period
Subject uses the imperative mood ("add", not "adding")
Body wraps at 72 characters
Body explains "what" and "why", not "how"

Documentation

[ ] In case of new functionality, my PR adds documentation that describes how to use it.

All the public functions and the classes in the PR contain docstrings that explain what it does
If you implement backwards incompatible changes, please leave a note in the Updating.md so we can assign it to a appropriate release

Codecov Report

:exclamation: No coverage uploaded for pull request base (master@4d44d19). Click here to learn what that means.
The diff coverage is 8.67%.

@@            Coverage Diff            @@
##             master      #14   +/-   ##
=========================================
  Coverage          ?   83.85%
=========================================
  Files             ?      671
  Lines             ?    37934
  Branches          ?        0
=========================================
  Hits              ?    31810
  Misses            ?     6124
  Partials          ?        0

Impacted Files
Coverage Δ

...mazon/aws/example_dags/example_datasync_complex.py
0% <0%> (ø)

...amazon/aws/example_dags/example_datasync_simple.py
0% <0%> (ø)

airflow/providers/amazon/aws/operators/datasync.py
14.28% <10.57%> (ø)

airflow/providers/amazon/aws/hooks/datasync.py
16.78% <9.83%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4d44d19...f79acff. Read the comment docs.


MacOS compile dlib library compile after executing the following code prompt: illegal instructions: 4!

Machine: 2010
System: masOS: 10.13.6
Python version: 3.7.6 ~ 3.6.5
Error executing the following code! Never found a solution!
Find the problem：face_descriptor = face_rec.compute_face_descriptor(img_gray, shape)
Test code:
import dlib
import cv2
from skimage import io
Use dlib model
detector = dlib.get_frontal_face_detector()
predictor = dlib.shape_predictor("data/data_dlib/shape_predictor_5_face_landmarks.dat")
face_rec=dlib.face_recognition_model_v1("data/data_dlib/dlib_face_recognition_resnet_model_v1.dat")
img_rd = io.imread("test.jpg")
img_gray = cv2.cvtColor(img_rd, cv2.COLOR_BGR2RGB)
faces = detector(img_gray, 1)
shape = predictor(img_gray, faces[0])
face_descriptor = face_rec.compute_face_descriptor(img_gray, shape)
print(face_descriptor)

I have referred to the official installation steps!
1, I download the source code in the official: http://dlib.net/
2. Extract the package and compile it:
cd dlib;cd examples;mkdir build;cd build;cmake ..;cmake --build . --config Release
Some code problems occurred during the compilation process:
[ 25%] Building C object dlib_build/CMakeFiles/dlib.dir/external/zlib/inflate.c.o
/Users/mac/dlib/dlib/external/zlib/inflate.c:1507:61: warning: shifting a negative signed value is
undefined [-Wshift-negative-value]
if (strm == Z_NULL || strm->state == Z_NULL) return -1L << 16;
1 warning generated.

[ 74%] Building CXX object CMakeFiles/train_object_detector.dir/train_object_detector.cpp.o
/Users/mac/dlib/examples/train_object_detector.cpp:65:45: warning: '/' within block comment
[-Wcomment]
./train_object_detector examples/faces/.jpg -u1
^
1 warning generated.

[ 86%] Building CXX object CMakeFiles/face_detection_ex.dir/face_detection_ex.cpp.o
/Users/mac/dlib/examples/face_detection_ex.cpp:11:34: warning: '/' within block comment [-Wcomment]
./face_detection_ex faces/.jpg
^
1 warning generated.

Problem specification：
This is where the compilation went wrong! From compile progress 1 to 100% nothing else goes wrong! I looked at the source code error! Have a plenty of annotation not standard bring about! There are some places where there is a lack of space

I ignored the previous error to install: python setup.py install
Installation progress to 50% error!
Explanation: this is one of the nice places! The basic error is the same

/Users/mac/dlib/dlib/external/pybind11/include/pybind11/detail/internals.h:169:33: warning:
'PyThread_create_key' is deprecated [-Wdeprecated-declarations]
internals_ptr->tstate = PyThread_create_key();
^
/Users/mac/.pyenv/versions/3.7.3/include/python3.7m/pythread.h:95:43: note: 'PyThread_create_key'
has been explicitly marked deprecated here
PyAPI_FUNC(int) PyThread_create_key(void) Py_DEPRECATED(3.7);
^
/Users/mac/.pyenv/versions/3.7.3/include/python3.7m/pyport.h:493:54: note: expanded from macro
'Py_DEPRECATED'
#define Py_DEPRECATED(VERSION_UNUSED) attribute((deprecated))

Use pip3 list to see if dlib was installed successfully:

Python 3.7.3 (default, Apr 19 2019, 11:27:39)
[Clang 9.1.0 (clang-9<IP_ADDRESS>)] on darwin
Type "help", "copyright", "credits" or "license" for more information.

import dlib
dlib.DLIB_USE_CUDA
False
print(dlib)
<module 'dlib' from '/Users/mac/.pyenv/versions/3.7.3/lib/python3.7/site-packages/dlib-19.17.0-py3.7-macosx-10.13-x86_64.egg/dlib.cpython-37m-darwin.so'>

Still prompt: illegal instruction: 4 when executing the following code
eer: face_descriptor = face_rec.compute_face_descriptor(img_gray, shape)
import dlib
import cv2
from skimage import io

Use dlib model
detector = dlib.get_frontal_face_detector()
predictor = dlib.shape_predictor("data/data_dlib/shape_predictor_5_face_landmarks.dat")
face_rec = dlib.face_recognition_model_v1("data/data_dlib/dlib_face_recognition_resnet_model_v1.dat")

img_rd = io.imread("test.jpg")
img_gray = cv2.cvtColor(img_rd, cv2.COLOR_BGR2RGB)
faces = detector(img_gray, 1)

shape = predictor(img_gray, faces[0])
face_descriptor = face_rec.compute_face_descriptor(img_gray, shape)

print(face_descriptor)

Important: I have installed x11 and cmake, this is to view the online MAC installation dlib method

That's not how you install dlib in python. You run python setup.py install, as per the instructions http://dlib.net/compile.html

This is how I installed it: if you know, please tell me the correct installation steps! Thank you very much! I had tried countless ways before without success!


Bank tag issue

Some of my bank tags are not working/partially working. My "vorkath" tag seems to bring up all of the relevant gear, but when I type "zulrah", it only brings up 4 items, similar thing happens when I type "gorillas" or "raids". I have checked the other items and they have the tag assigned to them. I tried deleting all tags for an item, then re-adding them, didn't work.  Nothing seems to be working.

Are you sure you are separating tags with commas and not spaces? That is common mistake people do

Yeah. I didn't even know that was a thing. I never had an issue with spaces before>.< Appears to have fixed it. I will post again if it pops up again in some way.


Testing - do not merge

As of this PR, CI is working again

Build triggered. sha1 is merged.

Build started sha1 is merged.

Build finished.

Build triggered. sha1 is merged.

Build started sha1 is merged.

Build finished.


Avoid unwanted behaviour when splits from script and metadata are not matching because of outdated metadata

will fix  #5315

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint.


Bump wheels to latest versions

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 74.04%. Comparing base (d9f91a9) to head (d6d9db5).
Report is 3 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main      #74   +/-   ##
=======================================
  Coverage   74.04%   74.04%
=======================================
  Files           5        5
  Lines        1256     1256
=======================================
  Hits          930      930
  Misses        326      326

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


add API data enrichment to diff command

It looks like this:
DevCycle Variable Changes:
⚠   1 Variable With Notices
✅  1 Variable Added
❌  1 Variable Removed
🧹  1 Variable Cleaned up
⚠  Notices
The following variables were added but do not yet exist on DevCycle.

no-exists
Location: test/utils/diff/sampleDiff.js:L2

✅  Added

exists
Type: String
Location: test/utils/diff/sampleDiff.js:L1

❌ Removed

exists2
Type: String
Location: test/utils/diff/sampleDiff.js:L1

🧹 Cleaned Up

no-exists2
Location: test/utils/diff/sampleDiff.js:L2

It's not immediately obvious what the "cleaned up" list means

It's not immediately obvious what the "cleaned up" list means

should i add a single sentence explainer to that section as well? Maybe at that point I could just add one to all sections?

It's not immediately obvious what the "cleaned up" list means

should i add a single sentence explainer to that section as well? Maybe at that point I could just add one to all sections?

What if all variables are contained in added/removed, but Notices calls out any potential issues.
Something like:
DevCycle Variable Changes:
⚠ 2 Variables With Notices
✅ 2 Variables Added
❌ 2 Variables Removed
⚠ Notices

Variable no-exists does not exist in DevCycle
Unable to identify the variable associated with VARIABLE.RANDOM

✅ Added

exists
Type: String
Location: test/utils/diff/sampleDiff.js:L1
no-exists ⚠
Location: test/utils/diff/sampleDiff.js:L2

❌ Removed

exists2
Type: String
Location: test/utils/diff/sampleDiff.js:L1
VARIABLE.RANDOM ⚠
Location: test/utils/diff/sampleDiff.js:L2

It's not immediately obvious what the "cleaned up" list means

should i add a single sentence explainer to that section as well? Maybe at that point I could just add one to all sections?

What if all variables are contained in added/removed, but Notices calls out any potential issues. Something like:
DevCycle Variable Changes: ⚠ 2 Variables With Notices ✅ 2 Variables Added ❌ 2 Variables Removed
⚠ Notices

Variable no-exists does not exist in DevCycle
Unable to identify the variable associated with VARIABLE.RANDOM

✅ Added

exists
Type: String
Location: test/utils/diff/sampleDiff.js:L1
no-exists ⚠
Location: test/utils/diff/sampleDiff.js:L2

❌ Removed

exists2
Type: String
Location: test/utils/diff/sampleDiff.js:L1
VARIABLE.RANDOM ⚠
Location: test/utils/diff/sampleDiff.js:L2

that could work, would we not have a cleanup section in that case?

It's not immediately obvious what the "cleaned up" list means

should i add a single sentence explainer to that section as well? Maybe at that point I could just add one to all sections?

What if all variables are contained in added/removed, but Notices calls out any potential issues. Something like:
DevCycle Variable Changes: ⚠ 2 Variables With Notices ✅ 2 Variables Added ❌ 2 Variables Removed
⚠ Notices

Variable no-exists does not exist in DevCycle
Unable to identify the variable associated with VARIABLE.RANDOM

✅ Added

exists
Type: String
Location: test/utils/diff/sampleDiff.js:L1
no-exists ⚠
Location: test/utils/diff/sampleDiff.js:L2

❌ Removed

exists2
Type: String
Location: test/utils/diff/sampleDiff.js:L1
VARIABLE.RANDOM ⚠
Location: test/utils/diff/sampleDiff.js:L2

that could work, would we not have a cleanup section in that case?

I don't think we need a separate section for it — what do you think? We could use a different icon rather than a warning in that case, but I also wouldn't want to over complicate the comment


Added clone of Byjus

This PR fixes the issue UI of Byjus #377. Please review it sir/mam.

Wonderfull @eswarbhageerath

Thank you sir.

@AyushSingh22 Please merge PR sir

Wait for our PA @Jaideep25-tech

@AyushSingh22 Please merge PR sir


Taskcat not able to access S3 buckets

Describe the bug
Taskcat not able to access S3 buckets
For Example:
This is how the TemplateURL is given in CloudFormation Template:
https://github.com/awslabs/aws-centralized-logging/blob/master/deployment/centralized-logging-primary.template
 TemplateURL: !Join
        - ''
        - - 'https://'
          - !Join ["-", [!FindInMap ["SourceCode", "General", "S3Bucket"], "reference"]]
          - '.s3.amazonaws.com/'
          - !Join ["/", [!FindInMap ["SourceCode", "General", "KeyPrefix"],  "centralized-logging-demo.template"]]

Taskcat Error:
[WARN   ] : Failed to discover path for {'Fn::Join': ['', ['https://', {'Fn::Join': ['-', [{'Fn::FindInMap': ['SourceCode', 'General', 'S3Bucket']}, 'reference']]}, '.s3.amazonaws.com/', {'Fn::Join': ['/', [{'Fn::FindInMap': ['SourceCode', 'General', 'KeyPrefix']}, 'centralized-logging-demo.template']]}]]}, path {'Fn::Join': ['/', [{'Fn::FindInMap': ['SourceCode', 'General', 'KeyPrefix']}, 'centralized-logging-demo.template']]} does not exist
[ERROR  ] : Lint detected issues for test test1us on template /Users/dadmukta/Centralized_logging_taskcat/centralized-logging-primary.template:
[ERROR  ] :     line 338 [3030] [Check if properties have a valid value] You must specify a valid value for Runtime (nodejs12.x). Valid
                                                               values are ['dotnetcore1.0', 'dotnetcore2.0', 'dotnetcore2.1',
                                                               'go1.x', 'java8', 'nodejs', 'nodejs4.3-edge', 'nodejs4.3',
                                                               'nodejs6.10', 'nodejs8.10', 'nodejs10.x', 'provided', 'python2.7',
                                                               'python3.6', 'python3.7', 'ruby2.5']
[ERROR  ] :     line 447 [3012] [Check resource properties values] Property Resources/ElasticsearchAWSLogs/Properties/SnapshotOptions/Autom
                                                         atedSnapshotStartHour should be of type Integer
[ERROR  ] :     line 467 [3012] [Check resource properties values] Property Resources/ElasticsearchAWSLogs/Properties/AdvancedOptions/indic
                                                         es.fielddata.cache.size should be of type String
[ERROR  ] :     line 788 [3030] [Check if properties have a valid value] You must specify a valid value for Runtime (nodejs12.x). Valid
                                                               values are ['dotnetcore1.0', 'dotnetcore2.0', 'dotnetcore2.1',
                                                               'go1.x', 'java8', 'nodejs', 'nodejs4.3-edge', 'nodejs4.3',
                                                               'nodejs6.10', 'nodejs8.10', 'nodejs10.x', 'provided', 'python2.7',
                                                               'python3.6', 'python3.7', 'ruby2.5']
[ERROR  ] : Lint failed with errors
Traceback (most recent call last):
  File "/usr/local/lib/python3.7/site-packages/taskcat/_cli.py", line 70, in main
    cli.run()
  File "/usr/local/lib/python3.7/site-packages/taskcat/_cli_core.py", line 235, in run
    return getattr(command(), subcommand)(**args)
  File "/usr/local/lib/python3.7/site-packages/taskcat/_cli_modules/test.py", line 67, in run
    raise TaskCatException("Lint failed with errors")
taskcat.exceptions.TaskCatException: Lint failed with errors

To Reproduce
Steps to reproduce the behavior:

Are you testing a QuickStart or Custom template? - Custom Template
Attach or link a copy of the template if possible (remove any sensitive info) - cannot share template
Provide the parameters that you passed. (remove any sensitive info) - Provided above
How did you install taskcat? (docker or pip3) - pip3
Are you using a profile, an instance role or  access keys to run taskcat? - access keys
Is your AWS environment configured via aws configure? - yes

Expected behavior
Taskcat should be able to access S3 files. We do not want to save all the files locally.
Screenshots
If applicable, add screenshots to help explain your problem.
**Version (Please make sure you are running the latest version of taskcat)

Taskcat Version (ex: [2018.817.210357])

Note: Python Version (python3 required)
To find versions:
Via taskcat: taskcat -V
Via pip3: pip3 show taskcat
Note: both version should match
To update taskcat run:
for docker : docker pull taskcat/taskcat
for pip3: pip3 install --upgrade taskcat
Additional context
Add any other context about the problem here.

This looks like a duplicate (or very similar to) #446.

/cc @gargana - FYI

Hello everyone! What about this issue? How can I solve this problem?
13:01:15 boto3.exceptions.S3UploadFailedError: Failed to upload /home/user/workspace/quickstart-amazon-eks-test/output/build/NOTICE.txt to mybucket/quickstart-amazon-eks-test-versions/NOTICE.txt: An error occurred (AccessDenied) when calling the PutObject operation: Access Denied
13:01:15 taskcat.exceptions.TaskCatException: Failed to upload to S3

Hello everyone! What about this issue? How can I solve this problem?
13:01:15 boto3.exceptions.S3UploadFailedError: Failed to upload /home/user/workspace/quickstart-amazon-eks-test/output/build/NOTICE.txt to mybucket/quickstart-amazon-eks-test-versions/NOTICE.txt: An error occurred (AccessDenied) when calling the PutObject operation: Access Denied
13:01:15 taskcat.exceptions.TaskCatException: Failed to upload to S3