Cert-manager account cannot create resource regru-dns at the cluster scope

Cluster was obtained using Yandex.Cloud Managed Kubernetes solution.
Any modifications of RBAC roles didn't work.
kubectl get challenge letsencrypt-jvzb2-2152256332-2670382356 -o yaml
apiVersion: acme.cert-manager.io/v1
kind: Challenge
metadata:
  creationTimestamp: "2023-02-16T06:07:51Z"
  finalizers:
  - finalizer.acme.cert-manager.io
  generation: 1
  name: letsencrypt-jvzb2-2152256332-2670382356
  namespace: quickclick-prod
  ownerReferences:
  - apiVersion: acme.cert-manager.io/v1
    blockOwnerDeletion: true
    controller: true
    kind: Order
    name: letsencrypt-jvzb2-2152256332
    uid: f5b3b927-e3ff-4f09-b92a-cb7521949d21
  resourceVersion: "1634916"
  uid: 6182c5bc-8c09-4d26-be53-60c45578b3b8
spec:
  authorizationURL: https://acme-v02.api.letsencrypt.org/acme/authz-v3/203731144196
  dnsName: quickclick.online
  issuerRef:
    group: cert-manager.io
    kind: ClusterIssuer
    name: letsencrypt
  key: dDlzkoMWZo5NLYFs8-XpPvEmEGdikSbIOfVu3WNJW84
  solver:
    dns01:
      webhook:
        config:
          regruPasswordSecretRef:
            key: REGRU_PASSWORD
            name: regru-password
        groupName: acme.regru.ru
        solverName: regru-dns
  token: O8lRYSJ9eiWHWXUT0DR00EQxRt8RRmvsT5QbznbKqTc
  type: DNS-01
  url: https://acme-v02.api.letsencrypt.org/acme/chall-v3/203731144196/Y_IJnA
  wildcard: true
status:
  presented: false
  processing: true
  reason: 'regru-dns.acme.regru.ru is forbidden: User "system:serviceaccount:cert-manager:cert-manager"
    cannot create resource "regru-dns" in API group "acme.regru.ru" at the cluster
    scope'
  state: pending

Chunk of web hook pod logs:
W0216 14:36:52.248111       1 reflector.go:324] pkg/mod/k8s.io/client-go@v0.23.1/tools/cache/reflector.go:167: failed to list *v1beta2.FlowSchema: flowschemas.flowcontrol.apiserver.k8s.io is forbidden: User "system:serviceaccount:cert-manager:regru-webhook-regru-cluster-issuer" cannot list resource "flowschemas" in API group "flowcontrol.apiserver.k8s.io" at the cluster scope
E0216 14:36:52.248146       1 reflector.go:138] pkg/mod/k8s.io/client-go@v0.23.1/tools/cache/reflector.go:167: Failed to watch *v1beta2.FlowSchema: failed to list *v1beta2.FlowSchema: flowschemas.flowcontrol.apiserver.k8s.io is forbidden: User "system:serviceaccount:cert-manager:regru-webhook-regru-cluster-issuer" cannot list resource "flowschemas" in API group "flowcontrol.apiserver.k8s.io" at the cluster scope
W0216 14:37:12.841566       1 reflector.go:324] pkg/mod/k8s.io/client-go@v0.23.1/tools/cache/reflector.go:167: failed to list *v1beta2.PriorityLevelConfiguration: prioritylevelconfigurations.flowcontrol.apiserver.k8s.io is forbidden: User "system:serviceaccount:cert-manager:regru-webhook-regru-cluster-issuer" cannot list resource "prioritylevelconfigurations" in API group "flowcontrol.apiserver.k8s.io" at the cluster scope
E0216 14:37:12.841599       1 reflector.go:138] pkg/mod/k8s.io/client-go@v0.23.1/tools/cache/reflector.go:167: Failed to watch *v1beta2.PriorityLevelConfiguration: failed to list *v1beta2.PriorityLevelConfiguration: prioritylevelconfigurations.flowcontrol.apiserver.k8s.io is forbidden: User "system:serviceaccount:cert-manager:regru-webhook-regru-cluster-issuer" cannot list resource "prioritylevelconfigurations" in API group "flowcontrol.apiserver.k8s.io" at the cluster scope
W0216 14:37:36.658052       1 reflector.go:324] pkg/mod/k8s.io/client-go@v0.23.1/tools/cache/reflector.go:167: failed to list *v1beta2.FlowSchema: flowschemas.flowcontrol.apiserver.k8s.io is forbidden: User "system:serviceaccount:cert-manager:regru-webhook-regru-cluster-issuer" cannot list resource "flowschemas" in API group "flowcontrol.apiserver.k8s.io" at the cluster scope
E0216 14:37:36.658085       1 reflector.go:138] pkg/mod/k8s.io/client-go@v0.23.1/tools/cache/reflector.go:167: Failed to watch *v1beta2.FlowSchema: failed to list *v1beta2.FlowSchema: flowschemas.flowcontrol.apiserver.k8s.io is forbidden: User "system:serviceaccount:cert-manager:regru-webhook-regru-cluster-issuer" cannot list resource "flowschemas" in API group "flowcontrol.apiserver.k8s.io" at the cluster scope
W0216 14:37:50.056745       1 reflector.go:324] pkg/mod/k8s.io/client-go@v0.23.1/tools/cache/reflector.go:167: failed to list *v1beta2.PriorityLevelConfiguration: prioritylevelconfigurations.flowcontrol.apiserver.k8s.io is forbidden: User "system:serviceaccount:cert-manager:regru-webhook-regru-cluster-issuer" cannot list resource "prioritylevelconfigurations" in API group "flowcontrol.apiserver.k8s.io" at the cluster scope
E0216 14:37:50.056784       1 reflector.go:138] pkg/mod/k8s.io/client-go@v0.23.1/tools/cache/reflector.go:167: Failed to watch *v1beta2.PriorityLevelConfiguration: failed to list *v1beta2.PriorityLevelConfiguration: prioritylevelconfigurations.flowcontrol.apiserver.k8s.io is forbidden: User "system:serviceaccount:cert-manager:regru-webhook-regru-cluster-issuer" cannot list resource "prioritylevelconfigurations" in API group "flowcontrol.apiserver.k8s.io" at the cluster scope
W0216 14:38:11.480925       1 reflector.go:324] pkg/mod/k8s.io/client-go@v0.23.1/tools/cache/reflector.go:167: failed to list *v1beta2.FlowSchema: flowschemas.flowcontrol.apiserver.k8s.io is forbidden: User "system:serviceaccount:cert-manager:regru-webhook-regru-cluster-issuer" cannot list resource "flowschemas" in API group "flowcontrol.apiserver.k8s.io" at the cluster scope
E0216 14:38:11.480971       1 reflector.go:138] pkg/mod/k8s.io/client-go@v0.23.1/tools/cache/reflector.go:167: Failed to watch *v1beta2.FlowSchema: failed to list *v1beta2.FlowSchema: flowschemas.flowcontrol.apiserver.k8s.io is forbidden: User "system:serviceaccount:cert-manager:regru-webhook-regru-cluster-issuer" cannot list resource "flowschemas" in API group "flowcontrol.apiserver.k8s.io" at the cluster scope
W0216 14:38:30.946739       1 reflector.go:324] pkg/mod/k8s.io/client-go@v0.23.1/tools/cache/reflector.go:167: failed to list *v1beta2.PriorityLevelConfiguration: prioritylevelconfigurations.flowcontrol.apiserver.k8s.io is forbidden: User "system:serviceaccount:cert-manager:regru-webhook-regru-cluster-issuer" cannot list resource "prioritylevelconfigurations" in API group "flowcontrol.apiserver.k8s.io" at the cluster scope
E0216 14:38:30.946771       1 reflector.go:138] pkg/mod/k8s.io/client-go@v0.23.1/tools/cache/reflector.go:167: Failed to watch *v1beta2.PriorityLevelConfiguration: failed to list *v1beta2.PriorityLevelConfiguration: prioritylevelconfigurations.flowcontrol.apiserver.k8s.io is forbidden: User "system:serviceaccount:cert-manager:regru-webhook-regru-cluster-issuer" cannot list resource "prioritylevelconfigurations" in API group "flowcontrol.apiserver.k8s.io" at the cluster scope
W0216 14:38:59.318790       1 reflector.go:324] pkg/mod/k8s.io/client-go@v0.23.1/tools/cache/reflector.go:167: failed to list *v1beta2.FlowSchema: flowschemas.flowcontrol.apiserver.k8s.io is forbidden: User "system:serviceaccount:cert-manager:regru-webhook-regru-cluster-issuer" cannot list resource "flowschemas" in API group "flowcontrol.apiserver.k8s.io" at the cluster scope
E0216 14:38:59.318823       1 reflector.go:138] pkg/mod/k8s.io/client-go@v0.23.1/tools/cache/reflector.go:167: Failed to watch *v1beta2.FlowSchema: failed to list *v1beta2.FlowSchema: flowschemas.flowcontrol.apiserver.k8s.io is forbidden: User "system:serviceaccount:cert-manager:regru-webhook-regru-cluster-issuer" cannot list resource "flowschemas" in API group "flowcontrol.apiserver.k8s.io" at the cluster scope
W0216 14:39:06.331360       1 reflector.go:324] pkg/mod/k8s.io/client-go@v0.23.1/tools/cache/reflector.go:167: failed to list *v1beta2.PriorityLevelConfiguration: prioritylevelconfigurations.flowcontrol.apiserver.k8s.io is forbidden: User "system:serviceaccount:cert-manager:regru-webhook-regru-cluster-issuer" cannot list resource "prioritylevelconfigurations" in API group "flowcontrol.apiserver.k8s.io" at the cluster scope
E0216 14:39:06.331395       1 reflector.go:138] pkg/mod/k8s.io/client-go@v0.23.1/tools/cache/reflector.go:167: Failed to watch *v1beta2.PriorityLevelConfiguration: failed to list *v1beta2.PriorityLevelConfiguration: prioritylevelconfigurations.flowcontrol.apiserver.k8s.io is forbidden: User "system:serviceaccount:cert-manager:regru-webhook-regru-cluster-issuer" cannot list resource "prioritylevelconfigurations" in API group "flowcontrol.apiserver.k8s.io" at the cluster scope
W0216 14:39:41.699617       1 reflector.go:324] pkg/mod/k8s.io/client-go@v0.23.1/tools/cache/reflector.go:167: failed to list *v1beta2.PriorityLevelConfiguration: prioritylevelconfigurations.flowcontrol.apiserver.k8s.io is forbidden: User "system:serviceaccount:cert-manager:regru-webhook-regru-cluster-issuer" cannot list resource "prioritylevelconfigurations" in API group "flowcontrol.apiserver.k8s.io" at the cluster scope
E0216 14:39:41.699647       1 reflector.go:138] pkg/mod/k8s.io/client-go@v0.23.1/tools/cache/reflector.go:167: Failed to watch *v1beta2.PriorityLevelConfiguration: failed to list *v1beta2.PriorityLevelConfiguration: prioritylevelconfigurations.flowcontrol.apiserver.k8s.io is forbidden: User "system:serviceaccount:cert-manager:regru-webhook-regru-cluster-issuer" cannot list resource "prioritylevelconfigurations" in API group "flowcontrol.apiserver.k8s.io" at the cluster scope
W0216 14:39:53.112315       1 reflector.go:324] pkg/mod/k8s.io/client-go@v0.23.1/tools/cache/reflector.go:167: failed to list *v1beta2.FlowSchema: flowschemas.flowcontrol.apiserver.k8s.io is forbidden: User "system:serviceaccount:cert-manager:regru-webhook-regru-cluster-issuer" cannot list resource "flowschemas" in API group "flowcontrol.apiserver.k8s.io" at the cluster scope
E0216 14:39:53.112346       1 reflector.go:138] pkg/mod/k8s.io/client-go@v0.23.1/tools/cache/reflector.go:167: Failed to watch *v1beta2.FlowSchema: failed to list *v1beta2.FlowSchema: flowschemas.flowcontrol.apiserver.k8s.io is forbidden: User "system:serviceaccount:cert-manager:regru-webhook-regru-cluster-issuer" cannot list resource "flowschemas" in API group "flowcontrol.apiserver.k8s.io" at the cluster scope
W0216 14:40:14.262299       1 reflector.go:324] pkg/mod/k8s.io/client-go@v0.23.1/tools/cache/reflector.go:167: failed to list *v1beta2.PriorityLevelConfiguration: prioritylevelconfigurations.flowcontrol.apiserver.k8s.io is forbidden: User "system:serviceaccount:cert-manager:regru-webhook-regru-cluster-issuer" cannot list resource "prioritylevelconfigurations" in API group "flowcontrol.apiserver.k8s.io" at the cluster scope
E0216 14:40:14.262335       1 reflector.go:138] pkg/mod/k8s.io/client-go@v0.23.1/tools/cache/reflector.go:167: Failed to watch *v1beta2.PriorityLevelConfiguration: failed to list *v1beta2.PriorityLevelConfiguration: prioritylevelconfigurations.flowcontrol.apiserver.k8s.io is forbidden: User "system:serviceaccount:cert-manager:regru-webhook-regru-cluster-issuer" cannot list resource "prioritylevelconfigurations" in API group "flowcontrol.apiserver.k8s.io" at the cluster scope
W0216 14:40:44.408353       1 reflector.go:324] pkg/mod/k8s.io/client-go@v0.23.1/tools/cache/reflector.go:167: failed to list *v1beta2.FlowSchema: flowschemas.flowcontrol.apiserver.k8s.io is forbidden: User "system:serviceaccount:cert-manager:regru-webhook-regru-cluster-issuer" cannot list resource "flowschemas" in API group "flowcontrol.apiserver.k8s.io" at the cluster scope
E0216 14:40:44.408388       1 reflector.go:138] pkg/mod/k8s.io/client-go@v0.23.1/tools/cache/reflector.go:167: Failed to watch *v1beta2.FlowSchema: failed to list *v1beta2.FlowSchema: flowschemas.flowcontrol.apiserver.k8s.io is forbidden: User "system:serviceaccount:cert-manager:regru-webhook-regru-cluster-issuer" cannot list resource "flowschemas" in API group "flowcontrol.apiserver.k8s.io" at the cluster scope
W0216 14:40:56.726358       1 reflector.go:324] pkg/mod/k8s.io/client-go@v0.23.1/tools/cache/reflector.go:167: failed to list *v1beta2.PriorityLevelConfiguration: prioritylevelconfigurations.flowcontrol.apiserver.k8s.io is forbidden: User "system:serviceaccount:cert-manager:regru-webhook-regru-cluster-issuer" cannot list resource "prioritylevelconfigurations" in API group "flowcontrol.apiserver.k8s.io" at the cluster scope
E0216 14:40:56.726393       1 reflector.go:138] pkg/mod/k8s.io/client-go@v0.23.1/tools/cache/reflector.go:167: Failed to watch *v1beta2.PriorityLevelConfiguration: failed to list *v1beta2.PriorityLevelConfiguration: prioritylevelconfigurations.flowcontrol.apiserver.k8s.io is forbidden: User "system:serviceaccount:cert-manager:regru-webhook-regru-cluster-issuer" cannot list resource "prioritylevelconfigurations" in API group "flowcontrol.apiserver.k8s.io" at the cluster scope
W0216 14:41:31.558256       1 reflector.go:324] pkg/mod/k8s.io/client-go@v0.23.1/tools/cache/reflector.go:167: failed to list *v1beta2.FlowSchema: flowschemas.flowcontrol.apiserver.k8s.io is forbidden: User "system:serviceaccount:cert-manager:regru-webhook-regru-cluster-issuer" cannot list resource "flowschemas" in API group "flowcontrol.apiserver.k8s.io" at the cluster scope
E0216 14:41:31.558295       1 reflector.go:138] pkg/mod/k8s.io/client-go@v0.23.1/tools/cache/reflector.go:167: Failed to watch *v1beta2.FlowSchema: failed to list *v1beta2.FlowSchema: flowschemas.flowcontrol.apiserver.k8s.io is forbidden: User "system:serviceaccount:cert-manager:regru-webhook-regru-cluster-issuer" cannot list resource "flowschemas" in API group "flowcontrol.apiserver.k8s.io" at the cluster scope
W0216 14:41:49.052948       1 reflector.go:324] pkg/mod/k8s.io/client-go@v0.23.1/tools/cache/reflector.go:167: failed to list *v1beta2.PriorityLevelConfiguration: prioritylevelconfigurations.flowcontrol.apiserver.k8s.io is forbidden: User "system:serviceaccount:cert-manager:regru-webhook-regru-cluster-issuer" cannot list resource "prioritylevelconfigurations" in API group "flowcontrol.apiserver.k8s.io" at the cluster scope
E0216 14:41:49.052976       1 reflector.go:138] pkg/mod/k8s.io/client-go@v0.23.1/tools/cache/reflector.go:167: Failed to watch *v1beta2.PriorityLevelConfiguration: failed to list *v1beta2.PriorityLevelConfiguration: prioritylevelconfigurations.flowcontrol.apiserver.k8s.io is forbidden: User "system:serviceaccount:cert-manager:regru-webhook-regru-cluster-issuer" cannot list resource "prioritylevelconfigurations" in API group "flowcontrol.apiserver.k8s.io" at the cluster scope
W0216 14:42:19.766463       1 reflector.go:324] pkg/mod/k8s.io/client-go@v0.23.1/tools/cache/reflector.go:167: failed to list *v1beta2.FlowSchema: flowschemas.flowcontrol.apiserver.k8s.io is forbidden: User "system:serviceaccount:cert-manager:regru-webhook-regru-cluster-issuer" cannot list resource "flowschemas" in API group "flowcontrol.apiserver.k8s.io" at the cluster scope
E0216 14:42:19.766503       1 reflector.go:138] pkg/mod/k8s.io/client-go@v0.23.1/tools/cache/reflector.go:167: Failed to watch *v1beta2.FlowSchema: failed to list *v1beta2.FlowSchema: flowschemas.flowcontrol.apiserver.k8s.io is forbidden: User "system:serviceaccount:cert-manager:regru-webhook-regru-cluster-issuer" cannot list resource "flowschemas" in API group "flowcontrol.apiserver.k8s.io" at the cluster scope
W0216 14:42:45.955955       1 reflector.go:324] pkg/mod/k8s.io/client-go@v0.23.1/tools/cache/reflector.go:167: failed to list *v1beta2.PriorityLevelConfiguration: prioritylevelconfigurations.flowcontrol.apiserver.k8s.io is forbidden: User "system:serviceaccount:cert-manager:regru-webhook-regru-cluster-issuer" cannot list resource "prioritylevelconfigurations" in API group "flowcontrol.apiserver.k8s.io" at the cluster scope
E0216 14:42:45.955983       1 reflector.go:138] pkg/mod/k8s.io/client-go@v0.23.1/tools/cache/reflector.go:167: Failed to watch *v1beta2.PriorityLevelConfiguration: failed to list *v1beta2.PriorityLevelConfiguration: prioritylevelconfigurations.flowcontrol.apiserver.k8s.io is forbidden: User "system:serviceaccount:cert-manager:regru-webhook-regru-cluster-issuer" cannot list resource "prioritylevelconfigurations" in API group "flowcontrol.apiserver.k8s.io" at the cluster scope

I've faced the same issue on k3s cluster running inside multipass VM (Ubuntu 22.04)
The was able to fix it by editing secrets-reader ClusterRole resource in rbac.yaml like this:

apiVersion: rbac.authorization.k8s.io/v1
kind: ClusterRole
metadata:
  name: {{ include \"cert-manager-webhook-regru.fullname\" . }}:secrets-reader
  labels:
    app: {{ include \"cert-manager-webhook-regru.name\" . }}
    chart: {{ include \"cert-manager-webhook-regru.chart\" . }}
    release: {{ .Release.Name }}
    heritage: {{ .Release.Service }}
rules:
  - apiGroups:
      - ''
      - 'flowcontrol.apiserver.k8s.io'
    resources:
      - '*'
    verbs:
      - 'get'
      - 'list'
      - 'watch'

So I've just added here flowcontrol.apiserver.k8s.io item inside apiGroups
I'm not sure if it is supposed to work like this, so I prefer to consider it as a temporarily workaround and it would be cool if someone could explain this incident

Thank you for your advice. After editing this cluster role, error logs from pod was gone. But problem with creating resource regru-dns still remains.

I can't see any error logs here, also I'm not sure about what you meant by regru-dns resource, I don't remember any resource with that name, tbh
Personally I've faced some errors after editing rbac rules as well, I've had some errors like this:
Failed to watch *v1beta3.PriorityLevelConfiguration: failed to list *v1beta3.PriorityLevelConfiguration: the server could not find the requested resource

But this errors didn't affect anything, my certificate was successfully created after some time (Also, perhaps, these errors may be caused by k3s distribution in my case, as I'm not using "vanilla k8s")
Also I may advice you to check out the spec.acme.server field in ClusterIssuer resource you're creating. Personally I was using staging url for tests (https://acme-v02-staging.api.letsencrypt.org/directory) and with that url your ACME challenge won't complete. You should try it on production url (https://acme-v02.api.letsencrypt.org/directory) if you want to see your flow fully completed

I think my error may be related to cluster issuer solverName, what solverName did you set?
ClusterIssuer.yaml
apiVersion: cert-manager.io/v1
kind: ClusterIssuer
metadata:
  name: qk-issuer
  namespace: cert-manager
spec:
  acme:
    server: https://acme-v02.api.letsencrypt.org/directory
    email<EMAIL_ADDRESS>    privateKeySecretRef:
      name: quickclick.online.cert
    solvers:
    - http01:
        ingress:
          class: nginx
    - dns01:
        webhook:
          config:
            regruPasswordSecretRef:
              name: regru-password
              key: REGRU_PASSWORD
          solverName: regru-dns
          groupName: acme.regru.ru

Same as you did:

apiVersion: cert-manager.io/v1
kind: ClusterIssuer
metadata:
  creationTimestamp: "2023-02-19T21:17:10Z"
  generation: 1
  name: regru-dns
  resourceVersion: "933"
  uid: 8654a09f-8ce0-4cdb-a419-92f10e463de5
spec:
  acme:
    email<EMAIL_ADDRESS>    preferredChain: ""
    privateKeySecretRef:
      name: cert-manager-letsencrypt-private-key
    server: https://acme-v02.api.letsencrypt.org/directory
    solvers:
    - dns01:
        webhook:
          config:
            regruPasswordSecretRef:
              key: REGRU_PASSWORD
              name: regru-password
          groupName: acme.regru.ru
          solverName: regru-dns

But I can see that we have different values for privateKeySecretRef

@Voldemat, hello! What is quickclick.online.cert? You need set value cert-manager-letsencrypt-private-key

The following RBAC configuration resolved this permission issues.
# I have found the same problem in cert-manager issuer
# https://github.com/vadimkim/cert-manager-webhook-hetzner/pull/37/files

---
apiVersion: rbac.authorization.k8s.io/v1
kind: ClusterRole
metadata:
  name: regru-webhook-regru-cluster-issuer:flowcontrol-solver
  labels:
    app: regru-cluster-issuer
rules:
  - apiGroups:
      - "flowcontrol.apiserver.k8s.io"
    resources:
      - 'prioritylevelconfigurations'
      - 'flowschemas'
    verbs:
      - 'list'
      - 'watch'

---
apiVersion: rbac.authorization.k8s.io/v1
kind: ClusterRoleBinding
metadata:
  name: regru-webhook-regru-cluster-issuer:flowcontrol-solver
  labels:
    app: regru-cluster-issuer
roleRef:
  apiGroup: rbac.authorization.k8s.io
  kind: ClusterRole
  name: regru-webhook-regru-cluster-issuer:flowcontrol-solver
subjects:
  - apiGroup: ""
    kind: ServiceAccount
    name: regru-webhook-regru-cluster-issuer
    namespace: cert-manager


Zone parse fails if RRSIG does not have host label

Parsing of zonefile fails with "Fatal error: Uncaught InvalidArgumentException:" if RRSIG record does not have host label. Following seems to be valid zone for named-checkzone:
poose.eu.		3600	IN SOA	ns.zone.eu. hostmaster.zone.eu. (
<PHONE_NUMBER> ; serial
					10800      ; refresh (3 hours)
					3600       ; retry (1 hour)
					2419200    ; expire (4 weeks)
					3600       ; minimum (1 hour)
					)
			3600	RRSIG	SOA 14 2 3600 (
<PHONE_NUMBER>3532<PHONE_NUMBER>3101 55179 poose.eu.
					utZQyR9wDynN8JE8DCVwYxix9eXpx45c4kDR
					ZqwzZnNVbz8UQv8Mt/AAqyqiKq4kHvGeczSp
					jj2fR8UIra3/eEowfeJzzPPuKmUsYO0WLuFy
					Ef8PJut23NefeEWo+1F7 )
			3600	NS	ns.zone.eu.
			3600	NS	ns2.zone.ee.
			3600	NS	ns3.zonedata.net.
			3600	RRSIG	NS 14 2 3600 (
<PHONE_NUMBER>3532<PHONE_NUMBER>3101 55179 poose.eu.
					bpGJmk6mA55QvkYejr33387hvWkg9z4pyhw4
					OLcw4NxTSVe8yna81Ey6jpbkkTTJxPBjo5fI
					kVNX3+12qG4fw4kswDzmzRvlTqXmujoLMbxx
					aAGW2YMATNJXM1d7PG77 )
			3600	A	<IP_ADDRESS>
			3600	RRSIG	A 14 2 3600 (
<PHONE_NUMBER>3532<PHONE_NUMBER>3101 55179 poose.eu.
					bDts/7a5qbal6s3ZYzS5puPSjEfys5yI6R/k
					prBBRDEfVcT6YwPaDT3VkVjKXdvpKX2/Dwpi
					jNAWkjpfsewCLmeImx3RgkzfuxfipRKtBUgu
					iPTBhkj/ft2halJziVXl )

RRSIG records appear to be interpreted as SOA, NS, A records when parsed as Badcow\DNS\Parser\Parser::parse( "poose.eu.", $zonefile )
Providing them with host label (or @) produces expected result.
And thanks for excellent library!

Hi @petskratt
Thanks for raising this issue.
I have found the root of the issue and have made a fix with tests on a new branch.
When determining if something is a resource name or some other element, it does a look ahead and sees what the next word is. In RRSIG's case, the next word is A so the parser thought that the resource name is RRSIG. This was simple enough to fix once the root cause was found.
Checkout branch Issue60 and make sure that it is working for you.
Thank you very much for raising this issue!

Now it parses correctly, thanks!
Just one remark - AlignedBuilder::build( $zone ) groups A, CNAME etc nicely together, but NSEC3 & RRSIG are in order found in source zone file with comments inserted whenever type changes (and it does change repeatedly). Result is valid, but could look better.
Source: poose.eu.zone.txt
Output:

Awesome!
I have pushed the second point you raised into Issue #61
I will merge the branch into master and produce a bugfix release shortly.
Thanks for the issue!

Merged.


How to display toolbar in singlepage viewer

singlepageviewer.html
how to adapt  window size without scrolling?
display toolbar in singlepage viewer?

The single page viewer is not a complete viewer in the sense that it has a toolbar and the other default viewer features. It's just an example that shows how to make a minimal viewer yourself. If you want more advanced features like the toolbar, you'll have to make a variation of the viewer in the web folder.


no_std support?

no_std support would be useful for making an executable music entry for a demo competition.
The size limit is 32kb, so I have to use no_std, like this example.

I think this should be possible. From the top of my head, there is only a Vec to support SampleWriter16, which is an optimisation. I’ll look into it.


[android] Preferences to AndroidX, Gson deprecation warning, Build Tools Update

The last one corrects the xml preferences, as the old way is not correct (as documented by Android's coding docs).

For further contributions
Create a branch with a descriptive name of the issue you are solving

please next time submit changes to a feature branch.
Now I'll have to cherry-pick each one of these on a temp branch in order to test.

when you build, don't you get this Warning after bumping the tools?
Daemon will be stopped at the end of the build stopping after processing
WARNING: The specified Android SDK Build Tools version (28.0.3) is ignored, as it is below the minimum supported version (29.0.2) for Android Gradle Plugin 4.0.1.
Android SDK Build Tools 29.0.2 will be used.

Left a comment, can't yet upgrade build tools
https://github.com/frostwire/frostwire/commit/cadfa85dec55440e5abb01b06cc1a1d281ebd8be

These two have been merged

[x] Fix a Gson deprecation
[x] Build tools update

Merged by cherry-picking, and put the 2 commits of preferences as a single one.

Thank you for these patches, please send newer patches in separate feature branches, a lot easier to work with on my end when reviewing and testing.

Ah, ok, thank you.


Reconnect terminated streams

does this update require a patch number change?
how can I tell if it's in the build and ready to test?

It has been merged but not released. I'm not quite sure what the procedure is, it looks like Alex has done the last few.

@digikata we may need a checklist doc with instructions on how to release a connector.

For this connector the procedure to push a tag to the repository that is formatted vX.Y.Z

I added a release instruction template.  @crajcan Can you try it out and see if it makes sense to you?


Coder: Exemplify class actions

Exemplify actions that are next available on the top right part of the coder:

Some examples:


Add nativelink remote execution to github actions

Enabling testing of remote execution on github actions

Create github action that generates .buckconfig.local using NATIVELINK_HEADER_RW_KEY from gha secrets.
Set container-image used for remote execution specific to setup of buck2.
Update .gitignore to include .buckconfig.local.

cc: @JakobDegen

This fails CI, is that to be expected?

@iguridi it shouldn't fail, says unauthorized, have the secrets been applied to this repo?

Sorry, I see the error, let me fix that real quick.

@KapJI @iguridi have you had a chance to apply the secrets?


Implement built-in CRDTs: LWW Register

Background
Register types are useful for CRO to specify a single value that can be updated concurrently by multiple nodes. LWW (Last-Write-Win) Register is a basic type for this purpose.
Task

implement
test
document how this type works and its usage

Resources

https://lars.hupel.info/topics/crdt/07-deletion/
https://jsonjoy.com/specs/json-crdt/model-document/crdt-algorithms see the section on "Last-Write-Wins (LWW) CRDT Algorithm"
https://www.bartoszsypytkowski.com/operation-based-crdts-registers-and-sets/

I got this.


Keycloak sync "error 1146: Table 'keycloak.user_entity' "doesn't exist"

Keycloak synchronization "error 1146: Table 'keycloak.user_entity' "doesn't exist" occurs because the table name of Keycloak is capitalized "USER_ENTITY", and when the synchronization type of the synchronizer is selected as Keycloak, the table name is forced to be lowercase and cannot be changed. MySQL data is case-sensitive, so the lowercase "user_entity" table name cannot be found

@chung1912 what do you want? Can you provide PR?

@chung1912 what do you want? Can you provide PR?
A simple solution is to select keycloak and then edit it, instead of locking it so that users can enter the uppercase text themselves.I can't submit a PR, I'm not familiar with this programming language.

Fixed by: https://github.com/casdoor/casdoor/commit/0d02b5e768f5737c6b38fde73c83fbb69e08f3f6


[Bug] "Argument list too long" when using Kotlin-based step

Component

[X] github-workflows-kt (library with the DSL)
[ ] bindings server (https://bindings.krzeminski.it)
[ ] I don't know

Action
Use a step where I can use Kotlin to implement the logic:
https://github.com/typesafegithub/github-workflows-kt/blob/1924c49452950dc51774d2958d62c57e91577134/.github/workflows/bindings-server.main.kts#L60
Expected
It just works as expected.
Actual
Error: An error occurred trying to start process '/usr/bin/bash' with working directory '/home/runner/work/github-workflows-kt/github-workflows-kt'. Argument list too long

https://github.com/typesafegithub/github-workflows-kt/actions/runs/12392429613/job/34591760569
Workaround, if exists
Unknown yet.
Version
Noticed in 3.0.2-SNAPSHOT so far.

On the next commit, it works: https://github.com/typesafegithub/github-workflows-kt/actions/runs/12392517116
As if the problem was caused by not having this change: https://github.com/typesafegithub/github-workflows-kt/commit/1924c49452950dc51774d2958d62c57e91577134
which is possible given that this package relies on a strict version of Kotlin.
Let me resolve.


cannot install langchain-milvus

PS C:\Work> pip install -qU langchain-milvus
ERROR: Could not find a version that satisfies the requirement milvus-lite<2.5.0,>=2.4.0 (from pymilvus) (from versions: none)
ERROR: No matching distribution found for milvus-lite<2.5.0,>=2.4.0
Can you help me? I uninstall all packages dependencies, and install them again and still got the above error.
What packages and which versions I have to install?
Please, help me

@zc277584121 can you help check if LangChain dependency conflicts with pymilvus requirement?

@PavlinaYordanova meanwhile can you try pip uninstall both milvus-lite and pymilvus?

miluvs-lite currently does not support Windows


openalSoft: workaround a cross-compilation issue

openalSoft: workaround a cross-compilation issue
it is a issue openal-soft's FindOSS.cmake https://github.com/kcat/openal-soft/blob/master/cmake/FindOSS.cmake
trofi> Looking at the build failure (if I remove libc from buildInputs) I think the problem here is that it tries to pull in build's headers, not host's headers:
trofi> These unexpected headers are injected from OSS headers: openal-soft-aarch64-unknown-linux-gnu> -- Found OSS: /nix/store/xy6ngc2gxqcypczxbahrqz31xr97m6gg-glibc-2.35-163-dev/include.
trofi> The header path detection comes from cmake/FindOSS.cmake:
trofi> Apparently glibc headers do provide sys/soundcard.h and confuse cmake.
see nixpkgs issue: https://github.com/NixOS/nixpkgs/issues/183774
Description of changes

Things done

Built on platform(s)

[ ] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
22.11 Release Notes (or backporting 22.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module
[ ] (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes

[x] Fits CONTRIBUTING.md.

I like this a lot better


uncaughtException: fix recovery when current test is still running

Description
describe('uncaught', function() {
  this.timeout(3000);
  it('throw delayed error', () => {
    setTimeout(() => {
      throw new Error('Whoops!');
    }, 1000)
  });
  it('should wait 2 seconds', (done) => {
    setTimeout(done, 2000);
  });
  it('test 3', () => { });
});

Description of the Change
Applicable issues

Coverage decreased (-0.1%) to 92.75% when pulling fd6886404924e7b196ee6ab05bd2b697669006e8 on juergba/recover-uncaught into 0e1ccbb915ba8c2f73134af5bebd357f3329b9b7 on master.


Sqlite MDS "No coercion operator" exception

Not sure if you really consider this a bug. I've tried using the sample from this #437 issue and have switched to MDS in the sample:
using (var connection = new SqliteConnection("Data Source=:memory:"))
By running the sample the following exception is being thrown:
No coercion operator is defined between types 'System.String' and 'System.DateTime'.'
Using the default provider does not result in an exception. If I enable Automatic conversion, everything works. I'm merely reporting this as a secondary issue I discovered while trying to figure out my main problem.

There are difference when it comes to DataTime in MDS and SDS, this is a part of the upgrades of MDS. Even in our Integration Tests, we purposely did it.

MdsCompleteTable.cs
SdsCompleteTable.cs

There is no way we can do this, but to use the 'Automatic' conversion. Would you be able to that?
FYI: We are assessing whether we should enable the 'Automatic' conversion by default, same as the other ORM. We guess, being a strict in RepoDb is good, but it may trigger a lot of coercion problem to all systems that tries to move to this ORM (like your use-case).

It's not a problem for me to use that, hence the reason why I mentioned that you might not be considering this as a bug. Feel free to close.

@bcssov - we will as well place a section on README pertaining to COERCION if we end-up not enabling the Automatic conversion by default. Will close this ticket now. Thanks for reporting.


v6 - warnings with failed prop types for borderTop, borderBottom...

My project after upgrade to v6 throws warnings:
Warning: Failed prop type: Invalid prop `borderBottom` of type `boolean` supplied to `Box`, expected `string`.
    in Box (created by ForwardRef(Pane))
    in ForwardRef(Pane)
    in ForwardRef(Pane) (created by ForwardRef(Card))
    in ForwardRef(Card)
    in ForwardRef(Card) (created by OfferEdit)

same thing for all 4 border types.

Interesting - I just tried to repro that here, but not seeing it: https://codesandbox.io/s/eloquent-johnson-597k9?file=/src/App.tsx
Are you looking in a dev environment? What does a minimal repro-able example look like?

Yes, dev environment. Ill try to setup an example. Will take me a day or two as I'm on a very tight schedule this week.
Basically I just updated evergreen to v6 and reported differences from v5 on my project in progress.
Will get back to you soon.

All good - going to keep this open and hopefully see what you're seeing. 👍

Ok, iI found out where it is comming from. It's in this line and property border={false} causes it:
<Card {...cardStyle} border={false} background="transparent" display="flex" justifyContent="space-between">
border={true} does not cause it and works properly. I'm pretty sure I was not getting this in v5. I'm building a project in typescript and was relying on my editor to describe props. For card prop border I get: (JSX attribute) PaneOwnProps.border?: string | boolean | undefined
... so I guess either there's a problem with typings or in code. For now, it's easy to get around this by using border="0" instead.

So, the typings and the run-time behavior are actually correct, it's just a matter of how these props get generated that ends up pretty noisy.
Under the hood, we use ui-box. You can see the prop types declarations are probably incorrect here: https://github.com/segmentio/ui-box/blob/master/src/enhancers/border-radius.ts#L6. Happy to accept a PR over there, but for now going to close this out as the actual behavior is as expected.


CF-1136 Make tflint happy

When running tflint with terraform plugin configured as preset = "all", we get several warnings. Hence,
fix all the reports. This involves changes in resource names, requiring some "moved" statement to avoid issues with existing resources. The "moved" statements will disappear in V3 release.
Please refer to the moved-v2.tf file for a list of resources with changed name and update your code accordingly.

Although tflint does not bother, shouldn't we also change project-cfg to project_cfg e.g. here in all the files of the repository to generate snake_case naming convention compliant code when bootstrapping?

This does not seems to be the case. The convention of snake case is for resources and other entities of the module, not for the module name, see here for examples: https://registry.terraform.io/browse/modules

Aha, I overlooked this. the dash is for repo name, not for the module name.


Make dev-kit independent of the library

dev-kit currently just delegates to the "standard" utility functions inside the library itself. That was a mistake: the dev-kit build scaffolding should work with arbitrary libraries dumped in Mcode, in case you want to use this template with a library that doesn't include our special utility functions.
dev-kit should be independent. Make it WET instead.

Mostly done in https://github.com/janklab/MatlabProjectTemplate/commit/cc2ec5d527de7331742c8d8fd648ea31467d323d. There's probably a few more bits hanging around to clean up.


i have a problem

[WARN] Cannot find rule for <class 'main.hsigmoid'>. Treat it as zero Macs and zero Params.
it means that hsigmoid module don't be included in total params and mac？

If you implement / load 3rd party module not in pytorch nn, then you should write the rules for counting flops


Blog plugin hangs with multiple post - doesn't save

https://www.wondercms.com/community/viewtopic.php?f=23&t=2243

Reported by Ulf and TheDane.

Issue fixed with latest blog update (3.1.0.

Issue fixed with latest blog update (3.1.0.


Monkey patch socket.

Love the API you have (very similar to Ruby's VRC) and very nice code!
Another project I was toying around with (recently on HN, I believe I saw you comment) does something similar: https://github.com/gabrielfalcao/HTTPretty/
I've opened an issue over there with the idea of adding a record and playback context manager, almost exactly like your implementation. But, of course, patching at the lib level (httplib or urllib or whatever) is almost guaranteed to leave some higher level libraries out. Instead, maybe we could monkey patch sockit and ssl?
The HTTPretty implementation is fairly complex but it looks doable.
This is a pretty big pain point for us, so its definitely something we want to do. Not sure whether to invest the time in your lib or theirs!

@kevin1024 I know that this could take a ridiculous amount of work, and what essentially amounts ot a complete refactor, but have you ever thought about trying to use httppretty as the patching backend for vcrpy?

Yup that would be amazing.  I would love for vcrpy to work at a lower level instead of patching httplib.  It would certainly make the maintenance easier!
Of course patching at the socket layer means we need to parse HTTP to support some features.  There are some nice HTTP parsing libraries out there these days.

As a heads up, we took a different approach and made a vcrpy-based dynamic callback to use on HTTPretty in #224.

A lot of changes have happened to VCRpy since this ticket was opened. As this ticket has become stale, would you mind closing it if it is no longer needed / relevant?
If I haven't heard anything in a week I'll mark it as closed as we have a lot of old tickets that need to be groomed to make it easier to see what is still relevant.
However if it is still needed, please feel free to re-open or create a new ticket.
Thanks! 🙏


refactor(core,accountsdb,bincode,net): Fixes, improvements, renames + discuss

This PR is mainly comprised of refactors, but also contains some slight deviations from a specific naming convention we follow implicitly: blanket screaming snake case constants.
Note: by implicitly, I mean that it isn't recommended by the zig style guide, nor do we outline it in our style guide.
In this PR I propose that we move to replace superfluous init methods with "init constants", which we could then also take advantage of when upgrading to zig 0.14 with the advent of Decl Literals. This was also in part prompted by a discussion we had on the logger PR. And of course, I am also proposing that we make these init constants normal snake case, instead of screaming snake case.
Also, after we decide on this, we should outline this in our style guide - I can also add that to this change set.
Of course review of any of the other changes in this PR is welcome.

This PR is mainly comprised of refactors, but also contains some slight deviations from a specific naming convention we follow implicitly: blanket screaming snake case constants.
Note: by implicitly, I mean that it isn't recommended by the zig style guide, nor do we outline it in our style guide.

I think this was just an oversight. My understanding is that it was an explicit style choice. To conform to the convention, I've been trying to use uppercase for file-scoped consts, unless they are imports. But I think I typically use lowercase for struct-scoped consts. I understand that files are structs but you know what I mean.
I don't have a very strong opinion about it personally. If I had to choose, my vote would probably be to use lowercase for all constants.

In this PR I propose that we move to replace superfluous init methods with "init constants"

If all the function does is return a const, then I agree with removing the function. But I think we should distinguish between two situations:

If there is clearly one most sensible and obvious default approach to initialize the struct, then we probably don't even need a decl. Can't we just set defaults for the fields? Especially if it's already called "init" and all it does is return a constant. I'm curious to hear other opinions about this specifically.
If there are a handful of reasonable alternative initialization states for a struct, and they are needed in multiple places, then I agree with using const decls to represent them.

we could then also take advantage of when upgrading to zig 0.14 with the advent of Decl Literals.

Presumably the same idea applies to init functions right?

but also contains some slight deviations from a specific naming convention we follow implicitly: blanket screaming snake case constants.

I don't have a very strong opinion about it personally. If I had to choose, my vote would probably be to use lowercase for all constants.

I don't have a strong opinion either, but I do like the current "screaming snake case", it's pretty easy to visually see which identifiers are constants. That's just my preference, I do not mind other solutions.

If there is clearly one most sensible and obvious default approach to initialize the struct, then we probably don't even need a decl. Can't we just set defaults for the fields? Especially if it's already called "init" and all it does is return a constant. I'm curious to hear other opinions about this specifically.

I agree that could be moved to using default field values. For example, an init function that takes no parameters and doesn't do any side-effect like computations inside of itself (incrementing some external counter or something), also doesn't do any extensive pure computation to initialize values (compute some key?), is superfluous.

If there are a handful of reasonable alternative initialization states for a struct, and they are needed in multiple places, then I agree with using const decls to represent them.

In agreement!

This also works with init functions right?

Yep,
const S = struct {
    ... some fields
    fn init(x: u32) S {
       ... returns S
    }
};

const x: S = .init(10);

is a valid usage of decl literals. To add to that, init could be a create style function that returns a *S and that would work as well.

@0xNineteen

const x: S = .init(10);

idk about you guys, but thats so hard to read relative to x = S.init(10)

I would say that's more a matter of familiarity, but the former provides strictly more information to the reader, in the least verbose way:

const x = S.init(y); doesn't guarantee that S.init actually returns S, that's merely convention, and conventions sometimes are broken, for better or worse.
const x: S = S.init(y); guarantees us that either it will compile because S.init returns S, or it will fail because it doesn't (ie perhaps it returns *S, or something else entirely), but can become very verbose (ie : std.ArrayList(T) = std.ArrayList(T).init(allocator)).
const x: S = .init(y); guarantees us that x is of type S, whilst utilizing its namespaced initialization method. It is also trivially applicable to more complex initializations:

var list: std.ArrayList(T) = .init(allocator);
const ptr: *PinnedType = try .create(allocator);
It also comes with the benefit that it unifies all initialization (much nicer in the case of std.ArrayListUnmanaged - I don't know about you, but std.ArrayListUnmanaged(T){} looks horrid)

There's also the point that, const x: T = init in general is the style zig is moving towards:

https://github.com/ziglang/zig/issues/5909 - this essentially makes const foo: T = @cast(x); the first class citizen, in-expression casts are only given second consideration.
https://github.com/ziglang/zig/issues/9938 - plus all of the PRs to replace default field values with descriptive decl literal inits (ie for std.ArrayListUnmanaged: .{} -> .empty).
https://github.com/ziglang/zig/issues/5038 - not accepted, but based on discussions it at the very least seems extremely plausible.

With all that considered, I think it would be along the path of least resistance to embrace this style.

If there is clearly one most sensible and obvious default approach to initialize the struct, then we probably don't even need a decl. Can't we just set defaults for the fields?

i feel like this is more dangerous, because it might allow you to initialize some fields, forget some others and everything compile fine -- with the decls, youre explicit that you want all fields as the default which is less error prone and more clear what you are doing

100%. In many cases setting defaults for fields is subtly a really bad idea, because people will feel safe partially-initialising structs in invalid ways which will cause big problems later.

If there is clearly one most sensible and obvious default approach to initialize the struct, then we probably don't even need a decl. Can't we just set defaults for the fields?

i feel like this is more dangerous, because it might allow you to initialize some fields, forget some others and everything compile fine -- with the decls, youre explicit that you want all fields as the default which is less error prone and more clear what you are doing

100%. In many cases setting defaults for fields is subtly a really bad idea, because people will feel safe partially-initialising structs in invalid ways which will cause big problems later.

So would you advocate completely against using defaults for fields in any situation?

If there is clearly one most sensible and obvious default approach to initialize the struct, then we probably don't even need a decl. Can't we just set defaults for the fields?

i feel like this is more dangerous, because it might allow you to initialize some fields, forget some others and everything compile fine -- with the decls, youre explicit that you want all fields as the default which is less error prone and more clear what you are doing

100%. In many cases setting defaults for fields is subtly a really bad idea, because people will feel safe partially-initialising structs in invalid ways which will cause big problems later.

So would you advocate completely against using defaults for fields in any situation?

For my part, I would heed the recommendation of the zig documentation itself:
https://ziglang.org/documentation/master/#toc-Faulty-Default-Field-Values

Default field values are only appropriate when the data invariants of a struct cannot be violated by omitting that field from an initialization.

Though besides that, there's also just the point of what it means for a value to be a good "default". I like using specifically named initialization values/procedures for types which are purely data, whose data the programmer will have to directly interface with in some way (as is the case of Pubkey, Hash, Signature, and a myriad of other types).


Spring warning "Using deprecated '-debug' fallback for parameter name resolution."

We see the following warning log on all apps during startup:
Using deprecated '-debug' fallback for parameter name resolution. Compile the affected code with '-parameters' instead or avoid its introspection: io.allune.quickfixj.spring.boot.starter.configuration.client.QuickFixJClientAutoConfiguration$SocketInitiatorConfiguration

Internets tell me this warning is usually seen with usage of annotations such as @PathVariable if you don't specify the parameter name, but I can't see anything in the source of SocketInitiatorConfiguration that would explain this.

Hi @esanchezros
We're using qfj starter 2.15.2 and spring boot 3.0.2


Historical view of lightbulb accessory is working?

Hi simont77 and everyone,
Thanks for providing this very useful library. Very helpful to visualize the data history. However, after the updating of EVE app in April (I guess), historical view of 'switch' accessory (acctually lightbulb) stopped working, and shows 'No data available'.
Are there anyone facing the same issue? And anyone know the solution?
Thansk in advance.

Same here, also for the original Eve light switch.

Thanks ebaauw. I'm very happy to have your replay.
Now I understand that this is common issue.
I hope future EVE update resolves the issue.

Thanks ebaauw. I'm very happy to have your replay.
Now I understand that this is common issue.
I hope future EVE update resolves the issue.


How can we get the gradient of the density about xyz?

Wonderfull project! Is it possible to get the gradient of the density about xyz, just like the normal of sdf. I guess the normal is helpful to get smoother meshes.

Hi @seekever  did you manage to achieve this? Can you please share your code?


Idea - Accounts?

Heyo, me again ^^ I am having a ton of fun using your site and want to help by giving you ideas for the site. I was wondering if it was possible to have accounts on the site so you could access all of your homebrew pages without having to write down the edit link and not all of your homebrews together. for example: I'm on my PC and have 10-20 homebrews and i want to take my laptop out of town and keep working on my homebrews but it does not carry them over so i would have to send an edit link for each homebrew to my laptop.
Sorry for any Grammar/Mechanical errors in my typing.

I'm glad you are enjoying the site. However building an account system would be as complex, if not more so, than the Homebrewery itself. I've built several account system for other projects and I have no interest in building it again.
To solve your problem, I suggest just bookmarking the edit links and chrome should sync your bookmarks between machines. That's what I do.

Hey, there are accounts now! see wasn't so after all (I have no clue how hard it was) lol


Docs: Layout guidelines

Summary
Added layout guidelines for mobile and tablet
What changed?
Added layout guidelines.

Moved Form layout code to the Forms section.

Why?
Designers ask for guidance on layout. We direct them to Lego guidelines in Dropbox. But Dropbox will soon be deprecated and many people already don't have access. So, we've moved them to Gestalt. The existing "layouts" page only had one layout for Forms, which makes more sense to include in the Forms section. We can revisit once we have sample code/templates for multiple layouts.
Links

Jira
[TDD](link to Paper doc)
TDD update
Figma

Checklist

[x] Added unit and Flow Tests
[x] Added documentation + accessibility tests
[x] Verified accessibility: keyboard & screen reader interaction
[x] Checked dark mode, responsiveness, and right-to-left support
[ ] Checked stakeholder feedback (e.g. Gestalt designers)

LGTM

@hectoid  - can you also add a redirect in this file since we're removing the other link

@hectoid - can you also add a redirect in this file since we're removing the other link

good catch @rlingineni ! added. also fixed the settings.js issues. I got a lot of errors locally this time around, so hopefully it's just an issue with vs code again. I'm not sure why that settings file keeps changing.


Fix typo

Absolution means a "formal release from guilt, obligation, or punishment."

Doah, thank you for the fix! Looks like autocorrect in my markdown editor got a little too creative. :)


replaced line 56 of CYRKeyboardButtonView.m

replaced line 56 of CYRKeyboardButtonView.m
changed from: if (UIInterfaceOrientationIsLandscape([UIApplication sharedApplication].statusBarOrientation)) {
to : if ([UIScreen mainScreen].bounds.size.width > [UIScreen
mainScreen].bounds.size.height) {
When used in an iOS keyboard extension, the original line causes an error on compiling:
'sharedApplication' is unavailable: not available on iOS (App Extension) - Use view controller based solutions where appropriate instead.
The new line still checks if the orientation is landscape, but sharedApplication is not used and compiles with no errors.

keyboard is crashed due to memory issue when we use CRKeyboardButton


python310Packages.filelock: 3.9.0 -> 3.12.0

Changelog: https://github.com/tox-dev/py-filelock/releases/tag/3.12.0
Description of changes

Things done

Built on platform(s)

[ ] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
23.05 Release Notes (or backporting 22.11 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[ ] Fits CONTRIBUTING.md.

This PR rebuild 261 packages I use and no breakage so far. LGTM

Maybe staging because it cause many rebuild


Not building on OSX 10.11.3

make ran just fine but when I tried make osx-release64 i received the error:
/System/Library/Frameworks/Foundation.framework/Headers/NSEnumerator.h:7:15: fatal error: expected ';' after @class
@class NSArray;
^
1 error generated.
I am unable to edit that file even with sudo.

I don't see that error. Can you make sure it's not corrupted file?

How should I check for that? I re-cloned the repo and tried to make again and I am getting the same error.

Check if
/System/Library/Frameworks/Foundation.framework/Headers/NSEnumerator.h
is valid.

The file is exists and seems to be valid

Are you using XCode 7 beta?

No, gcc --version returned the following:
shell-init: error retrieving current directory: getcwd: cannot access parent directories: No such file or directory
Configured with: --prefix=/Applications/Xcode.app/Contents/Developer/usr --with-gxx-include-dir=/usr/include/c++/4.2.1
Apple LLVM version 6.1.0 (clang-602.0.53) (based on LLVM 3.6.0svn)
Target: x86_64-apple-darwin15.3.0
Thread model: posix


Depth issue -- Can't find files

I'm finding that silver searcher can't find files after a particular depth (and seems to be less that the default max 25)
This has bit me a few times now, to the point where I've made a few critical errors (assuming things didn't exist)
Eg:
From this level I can find what I'm looking for:
[jnlance@lslcmac84D6H03Q src]$ ag createNugetConfig
io/dtdms/utils/ConfigUtils.groovy
11:    void createNugetConfig(){

io/dtdms/custom/pipeline/deploy/shared/DotnetCoreIntegrationTestStep.groovy
74:                steps.createNugetConfig()

io/dtdms/custom/pipeline/build/DotnetCoreNugetBuildStep.groovy
39:                steps.createNugetConfig()

io/dtdms/custom/pipeline/build/DotnetLambdaVersion.groovy
28:                steps.createNugetConfig()

io/dtdms/custom/pipeline/build/DotnetCoreBuildStep.groovy
29:                steps.createNugetConfig()

io/dtdms/custom/pipeline/build/DotnetCoreNugetPublishStep.groovy
20:                    steps.createNugetConfig()

If I step back one more directory, then I get different results:
[jnlance@lslcmac84D6H03Q src]$ cd ..
[jnlance@lslcmac84D6H03Q summit-jenkins-pipeline-library]$ pwd
/Users/jnlance/Projects/summit-jenkins-pipeline-library
[jnlance@lslcmac84D6H03Q summit-jenkins-pipeline-library]$ ag createNugetConfig
vars/createNugetConfig.groovy
2:*createNugetConfig
7:*createNugetConfig()

src/io/dtdms/utils/ConfigUtils.groovy
11:    void createNugetConfig(){

src/io/dtdms/custom/pipeline/deploy/shared/DotnetCoreIntegrationTestStep.groovy
74:                steps.createNugetConfig()

passing --depth $n doesn't seem to make any difference
I'm using silver searcher on a mac (high sierra) installed from brew
[jnlance@lslcmac84D6H03Q summit-jenkins-pipeline-library]$ ag --version
ag version 2.1.0

Features:
  +jit +lzma +zlib

I've run into this several times as well on linux.
$> ag --version
ag version 2.2.0

Features:
  +jit +lzma +zlib
$> ag "class BaseCommand"
$> ag --depth 99 "class BaseCommand"
$> cd lib
$> ag "class BaseCommand"
python3.9/site-packages/django/core/management/base.py
158:class BaseCommand:

@neybar I realize that my 'me too' isn't valid and all of my issues were probably related to not using 'ag -U' while I was in directories which had .gitignore files (which by defaults prevents subdirectories from being searched). Perhaps this is part of the issue you are facing?


Some problems with master branch composer.json

➜  /tmp composer create-project symfony/skeleton example dev-master
Installing symfony/skeleton (dev-master 80fd07101966c69c345e1f2f8a1cf02a38f15800)
  - Installing symfony/skeleton (dev-master master): Cloning master from cache
Created project in example
Loading composer repositories with package information
Updating dependencies (including require-dev)
Your requirements could not be resolved to an installable set of packages.

  Problem 1
    - Installation request for symfony/framework-bundle ^4.1 -> satisfiable by symfony/framework-bundle[4.1.x-dev].
    - symfony/framework-bundle dev-master conflicts with symfony/lts[4.x-dev].
    - don't install symfony/framework-bundle 4.1.x-dev|install symfony/framework-bundle dev-master
    - Installation request for symfony/lts ^4@dev -> satisfiable by symfony/lts[4.x-dev].

That's right, this is a composer issue, reported as #6852


Error message at startup with Snap package

Describe the bug
Error message: app-update.yml not found. Notice that i couldn't update Altair via Snap, i removed v2.3.8 to got v2.4.0
To Reproduce
Steps to reproduce the behavior:

Launch Altair

Expected behavior
No error message
Screenshots

Desktop (please complete the following information):

OS: Ubuntu
Version: 18.04.3 LTS

This seems to be specific to snap. Unfortunately I don't use a Linux so can't really debug this. Could you help with this?

VSCode head the same issue on linux
https://github.com/microsoft/vscode/issues/65095#issuecomment-457832886

@larsroettig I don't think the issues are the same though.

Turns out snap doesn't support auto update via the github provider, since Snapcraft would manage the auto updates itself.


Where should we hang out?

Our team is now bigger than ever :) Where should we hang out and chat? Slack? gitter? whatsapp?

I vote gitter but would also be ok with Slack.

I started to create a room on gitter but then thought maybe we should transfer the repo to an organisation instead of using my personal GH account. I have 2 orgs we can use, Devrex Labs and Memstate. Devrex Labs is the host of OrigoDB, an in-memory "database" for .NET Framework and memstate, a similar in-memory database for .NET Core. See:
http://origodb.com/
https://github.com/devrexlabs/origodb
https://github.com/devrexlabs/memstate
I'd like to use Fig with both of these projects and so moving to the Devrex Labs repo seems natural.
Tagging @Venom0us

moving to the Devrex Labs repo seems natural
👍Sounds good to me.

Transferred after a majority vote!

Gitter sounds fine, I usually hang out on discord channels

See you all on https://gitter.im/DevrexLabs/Fig then!


Missing delete function for recorded streams?

Hi,
I cannot find anything about deleting a recorded stream from the server.
I can only find functions for start recording, stop recording and playing a recorded stream.
There should be some function to  delete a recorded file from the server.
Giving a recorded stream a date of expiry after which it is deleted automatically would be even more perfect. Is there a function for that?  How can that be achieved?
Best regards,
Matthias

Hi Matthias,
Licode does not implement any management of the videos after the recording, it just places them in a folder you can specify in licode_config.js.
Moving video files, tagging, listing or deleting  should be implemented in your application.
Best,
Pedro Rodriguez

On 08 Sep 2016, at 17:25, Vidmeet1<EMAIL_ADDRESS>wrote:
Hi,
I cannot find anything about deleting a recorded stream from the server.
I can only find functions for start recording, stop recording and playing a recorded stream.
There should be some function to delete a recorded file from the server.
Giving a recorded stream a date of expiry after which it is deleted automatically would be even more perfect. Is there a function for that? How can that be achieved?
Best regards,
Matthias
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub https://github.com/ging/licode/issues/523, or mute the thread https://github.com/notifications/unsubscribe-auth/AA48O2hE5PB_3RnqSwsZNjDMieDk668Sks5qoCkBgaJpZM4J4H50.


Wrapped unions

The following issue comes when trying to implement wrapped unions.
I need to produce the following query:
(select `user_id` from `someTableName` where `user_id` = ?  limit 1 )
UNION
(select `user_id` from `anotherTableName` where `user_id` = ? limit 1 )

i.e. create unions that are wrapped from the beginning.
The union and unionAll methods, can wrap the subsequent queries, if the second parameter is set as true, but since the entrypoint to any queries in Objection is through the model.query method, it's hard to wrap anything before (please, I have tried with having a raw query in the beginning, but it looks hacky and it does not follow the same syntax of the subsequent queries.
It's a known issue on knex, and it might be related to https://github.com/Vincit/objection.js/issues/842.
How to reproduce:
class AModel extends Model {
  static get tableName() {
    return 'someTableName';
  }
}

class AnotherModel extends Model {
  static get tableName() {
    return 'anotherTableName';
  }
}

AModel.query()
  .select('user_id')
  .where('user_id', '=', 1)
  .limit(1)
  .union(
    AnotherModel.query()
      .select('user_id')
      .where('user_id', '=', 1)
      .limit(1),
    true,
  )
  .debug()
  .then(r => r);

Generates the following sql statement:
select `user_id` from `someTableName` where `user_id` = ? union (select `user_id` from `anotherTableName` where `user_id` = ? limit ?) limit ?'

* so it puts the limit outside the union

I'd appreciate any help on how to implement this.
Objection-code-wise, I think that there could be an solution like a wrappedQuery perhaps? Not sure.
Cheers! 🙂

So far, this works. I wonder if we can stay with objection methods.
const queries = [
  AModel.query()
    .select('user_id')
    .where('user_id', '=', 1)
    .limit(1),
  AnotherModel.query()
    .select('user_id')
    .where('user_id', '=', 1)
    .limit(1),
];

knex.raw(queries.map(q => q.toSql()).join(' UNION ')).then(r => console.log(r));

Do you really need to use union in this case? How about just two queries, and then combine the results? This should be fixed in knex, not objection.

@koskimas, thanks for your answer! sure that sounds way easier 😄
I need to do that with 10 tables though, and at some point thought it would perform better with the union.
Whether to achieve performance by running single queries, all of them in a transaction, or within a UNION statement is a question I still have to go through.
Nonetheless, I was wondering how to achieve wrapped unions, since it is quite a plausible scenario, and maybe some people are also struggling to achieve that.
Thanks for your feedback!

@nicosierra May be that could help you:
YourModel.knex()
  .unionAll(YourModel.knexQuery().limit(1), true)
  .unionAll(YourModel.knexQuery().where(...), true)

@nicosierra With 10 tables you are probably better off with a union :smile: Unfortunately there is no way to currently do this and adding support would mean exposing a way to build a knex query from an objection query, which will currently have the same problems as toString and toSQL methods. This may be fixed in 2.0, but until then, you need to find some other way to achieve this.


Is an IExecuteSystem instanciated 2 times?

When i create a system using IExecuteSystem with the following code:
    public void Execute() {
        if (Input.GetMouseButtonUp(0)){
            Debug.Log("Up");
        }
  }

after one click, the debug.log is called twice (and all other input detection). After searching in the unity docs, it seems that error occur when a script is attached twice in an object.
Thx!

Try steeping through frames and also check, if you call Execute twice

Was a bug from my code and not from the framework!

great :)


zoom-us fixes

Motivation for this change
Fix some issues for zoom-us. In particular,

https://github.com/NixOS/nixpkgs/pull/26446#issuecomment-306904224 for not working SSO (cc @kamilchm )
crash with Facebook
warnings about /home/levi/... (by fixing qt.conf)
black screen from webcam (my Logitech C270). This change, however, isn't as straightforward as others, so I extracted it to separate commit. If you guys ( @shlevy @k0001 @kamilchm ) have webcam working currently, and that commit breaks it for you, i'll revert it.

Things done

[ ] Tested using sandboxing
(nix.useSandbox on NixOS,
or option build-use-sandbox in nix.conf
on non-NixOS)
Built on platform(s)

[X] NixOS
[ ] macOS
[ ] Linux

[X] Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
[X] Tested execution of all binary files (usually in ./result/bin/)
[X] Fits CONTRIBUTING.md.

@danbst I did have webcam working, so I'll test this.

SSO and webcam fixed. Thx!

How exactly does zoom-us work? We're now using zoom.us at work, and I'd like to be able to connect from my NixOS machine, but when I run $(nix-build . -A zoom-us)/bin/zoom-us, all I see is this in my terminal:
zoom started.
libGL error: unable to load driver: swrast_dri.so
libGL error: failed to load driver: swrast
Unrecognized OpenGL version
Unrecognized OpenGL version

No GUI or system dock icon appears.

@cstrahan you may want to check that OpenGL is working for you with other applications. Running that same command works fine for me.

Hm... glxgears works just fine.

I'm running xmonad without a desktop environment... Maybe that has something to do with it?

@cstrahan unlikely. I was using xmonad without a desktop environment myself until some weeks ago, and even then zoom-us worked fine.

@k0001 I'm using the closed source nvidia driver; may I ask what you're using?

@cstrahan I'm using the radeon drivers.  Maybe you need to add something to opengl.extraPackages in configuration.nix?

@k0001 Ah, I wasn't aware of that option. I see with pkgs; [ vaapiIntel libvdpau-va-gl vaapiVdpau ] is suggested as an example setting, and I see that "vdpau" is in the binary when I grep the tree.
Out of curriousity, what do you have set for opengl.extraPackages?

@cstrahan I have [ vaapiIntel ] that apparently i forgot to comment out since I'm not using an Intel video card anymore 😄
I'd expect enabling vaapiVdpau in a Nvidia system makes sense.

Ah, if I export LIBGL_DEBUG=verbose:
zoom started.
libGL: screen 0 does not appear to be DRI2 capable
libGL: OpenDriver: trying /run/opengl-driver/lib/dri/tls/swrast_dri.so
libGL: OpenDriver: trying /run/opengl-driver/lib/dri/swrast_dri.so
libGL: dlopen /run/opengl-driver/lib/dri/swrast_dri.so failed (/run/opengl-driver/lib/dri/swrast_dri.so: cannot open shared object file: No such file or directory)
libGL error: unable to load driver: swrast_dri.so
libGL error: failed to load driver: swrast
function is no-op
Unrecognized OpenGL version
Unrecognized OpenGL version

Still not sure what all I'm missing...

In my case swrast_dri.so seems to come from mesa. Maybe you need to get that installed?
[k@z1:~]$ readlink -f /run/opengl-driver/lib/dri/swrast_dri.so
/nix/store/zh6v7amxyws1y6pfa7hcwhb3wph90yqc-mesa-noglu-17.0.7-drivers/lib/dri/gallium_dri.so

Also, I'm not sure if this is necessary, but with NVidia I never know: Maybe the 32 bit versions of some of these libs are required?
hardware.opengl.driSupport32Bit = true;
hardware.opengl.extraPackages = with pkgs; [ vaapiIntel libvdpau-va-gl vaapiVdpau ];
hardware.opengl.extraPackages32 = with (pkgs.pkgsi686Linux); [ vaapiIntel libvdpau-va-gl vaapiVdpau ];

(I'm guessing, I don't really know what's going on here)

Hmmm... So here's where the /run/opengl-drivers env is created (in nixos/modules/hardware/opengl.nix):
  makePackage = p: pkgs.buildEnv {
    name = "mesa-drivers+txc-${p.mesa_drivers.version}";
    paths =
      [ p.mesa_drivers
        p.mesa_drivers.out # mainly for libGL
        (if cfg.s3tcSupport then p.libtxc_dxtn else p.libtxc_dxtn_s2tc)
      ];
  };

  // As I'll note below, `cfg.package` defaults to the above expression,
  // but enabling the "nvidia" driver will result in `cfg.package` being overriden,
  // and that cfg.package doesn't include `p.mesa_drivers` etc.
  package = pkgs.buildEnv {
    name = "opengl-drivers";
    paths = [ cfg.package ] ++ cfg.extraPackages;
  };

And here's what I get when I don't enable the "nvidia" driver:
/nix/store/imwpn4dkyz7wypgm9nnl0b533q9yw8n1-opengl-drivers/lib/dri
├── gallium_dri.so -> /nix/store/9rwhmb7l66sf0dxgc2rnj5f85j5payg0-mesa-drivers+txc-17.1.1/lib/dri/gallium_dri.so
├── gallium_drv_video.so -> /nix/store/9rwhmb7l66sf0dxgc2rnj5f85j5payg0-mesa-drivers+txc-17.1.1/lib/dri/gallium_drv_video.so
├── i915_dri.so -> /nix/store/9rwhmb7l66sf0dxgc2rnj5f85j5payg0-mesa-drivers+txc-17.1.1/lib/dri/i915_dri.so
├── i965_dri.so -> /nix/store/9rwhmb7l66sf0dxgc2rnj5f85j5payg0-mesa-drivers+txc-17.1.1/lib/dri/i965_dri.so
├── i965_drv_video.la -> /nix/store/nzwazgrr6lwsx6xaysj7xdrs42rv7rhj-libva-intel-driver-1.7.3/lib/dri/i965_drv_video.la
├── i965_drv_video.so -> /nix/store/nzwazgrr6lwsx6xaysj7xdrs42rv7rhj-libva-intel-driver-1.7.3/lib/dri/i965_drv_video.so
├── kms_swrast_dri.so -> /nix/store/9rwhmb7l66sf0dxgc2rnj5f85j5payg0-mesa-drivers+txc-17.1.1/lib/dri/kms_swrast_dri.so
├── mesa_dri_drivers.so -> /nix/store/9rwhmb7l66sf0dxgc2rnj5f85j5payg0-mesa-drivers+txc-17.1.1/lib/dri/mesa_dri_drivers.so
├── nouveau_dri.so -> /nix/store/9rwhmb7l66sf0dxgc2rnj5f85j5payg0-mesa-drivers+txc-17.1.1/lib/dri/nouveau_dri.so
├── nouveau_drv_video.so -> /nix/store/9rwhmb7l66sf0dxgc2rnj5f85j5payg0-mesa-drivers+txc-17.1.1/lib/dri/nouveau_drv_video.so
├── nouveau_vieux_dri.so -> /nix/store/9rwhmb7l66sf0dxgc2rnj5f85j5payg0-mesa-drivers+txc-17.1.1/lib/dri/nouveau_vieux_dri.so
├── nvidia_drv_video.so -> /nix/store/cjahl0i6zr50rd2lap5yvif9gdfjw5d0-libva-vdpau-driver-0.7.4/lib/dri/nvidia_drv_video.so
├── r200_dri.so -> /nix/store/9rwhmb7l66sf0dxgc2rnj5f85j5payg0-mesa-drivers+txc-17.1.1/lib/dri/r200_dri.so
├── r300_dri.so -> /nix/store/9rwhmb7l66sf0dxgc2rnj5f85j5payg0-mesa-drivers+txc-17.1.1/lib/dri/r300_dri.so
├── r600_dri.so -> /nix/store/9rwhmb7l66sf0dxgc2rnj5f85j5payg0-mesa-drivers+txc-17.1.1/lib/dri/r600_dri.so
├── r600_drv_video.so -> /nix/store/9rwhmb7l66sf0dxgc2rnj5f85j5payg0-mesa-drivers+txc-17.1.1/lib/dri/r600_drv_video.so
├── radeon_dri.so -> /nix/store/9rwhmb7l66sf0dxgc2rnj5f85j5payg0-mesa-drivers+txc-17.1.1/lib/dri/radeon_dri.so
├── radeonsi_dri.so -> /nix/store/9rwhmb7l66sf0dxgc2rnj5f85j5payg0-mesa-drivers+txc-17.1.1/lib/dri/radeonsi_dri.so
├── radeonsi_drv_video.so -> /nix/store/9rwhmb7l66sf0dxgc2rnj5f85j5payg0-mesa-drivers+txc-17.1.1/lib/dri/radeonsi_drv_video.so
├── s3g_drv_video.so -> /nix/store/cjahl0i6zr50rd2lap5yvif9gdfjw5d0-libva-vdpau-driver-0.7.4/lib/dri/s3g_drv_video.so
├── swrast_dri.so -> /nix/store/9rwhmb7l66sf0dxgc2rnj5f85j5payg0-mesa-drivers+txc-17.1.1/lib/dri/swrast_dri.so
├── vdpau_drv_video.la -> /nix/store/cjahl0i6zr50rd2lap5yvif9gdfjw5d0-libva-vdpau-driver-0.7.4/lib/dri/vdpau_drv_video.la
├── vdpau_drv_video.so -> /nix/store/cjahl0i6zr50rd2lap5yvif9gdfjw5d0-libva-vdpau-driver-0.7.4/lib/dri/vdpau_drv_video.so
└── vmwgfx_dri.so -> /nix/store/9rwhmb7l66sf0dxgc2rnj5f85j5payg0-mesa-drivers+txc-17.1.1/lib/dri/vmwgfx_dri.so

But, interestingly, when the "nvidia" drver is enabled, the opengl-driver env is overridden with (in nixos/modules/hardware/video/nvidia.nix):
  nvidiaPackage = nvidia: pkgs:
    if !nvidia.useGLVND then nvidia.out
    else pkgs.buildEnv {
      name = "nvidia-libs";
      paths = [ pkgs.libglvnd nvidia.out ];
    };

So mesa_drivers is no longer in the env, and now I'm left with this:
/nix/store/a2mb7pg6qjk1xh9alp3wlskv54h6ff38-opengl-drivers/lib/dri
├── i965_drv_video.la -> /nix/store/nzwazgrr6lwsx6xaysj7xdrs42rv7rhj-libva-intel-driver-1.7.3/lib/dri/i965_drv_video.la
├── i965_drv_video.so -> /nix/store/nzwazgrr6lwsx6xaysj7xdrs42rv7rhj-libva-intel-driver-1.7.3/lib/dri/i965_drv_video.so
├── nvidia_drv_video.so -> /nix/store/cjahl0i6zr50rd2lap5yvif9gdfjw5d0-libva-vdpau-driver-0.7.4/lib/dri/nvidia_drv_video.so
├── s3g_drv_video.so -> /nix/store/cjahl0i6zr50rd2lap5yvif9gdfjw5d0-libva-vdpau-driver-0.7.4/lib/dri/s3g_drv_video.so
├── vdpau_drv_video.la -> /nix/store/cjahl0i6zr50rd2lap5yvif9gdfjw5d0-libva-vdpau-driver-0.7.4/lib/dri/vdpau_drv_video.la
└── vdpau_drv_video.so -> /nix/store/cjahl0i6zr50rd2lap5yvif9gdfjw5d0-libva-vdpau-driver-0.7.4/lib/dri/vdpau_drv_video.so

Also interesting (from journalctl -u display-manager):
Jan 18 02:28:02 cstrahan-mbp-nixos display-manager[2871]: (II) Loading sub module "dri2"
Jan 18 02:28:02 cstrahan-mbp-nixos display-manager[2871]: (II) LoadModule: "dri2"
Jan 18 02:28:02 cstrahan-mbp-nixos display-manager[2871]: (II) Module "dri2" already built-in
Jan 18 02:28:02 cstrahan-mbp-nixos display-manager[2871]: (II) NVIDIA(0): [DRI2] Setup complete
Jan 18 02:28:02 cstrahan-mbp-nixos display-manager[2871]: (II) NVIDIA(0): [DRI2]   VDPAU driver: nvidia
So I'm surprised by the libGL: screen 0 does not appear to be DRI2 capable message from zoom-us...
I might try the "nouveau" driver and see if things look any different. If so, perhaps we need to tweak the way the proprietary nvidia drivers are handled.

Rebooting with "nouveau" results in zoom-us launching successfully:
zoom started.
libGL: screen 0 does not appear to be DRI2 capable
libGL: OpenDriver: trying /run/opengl-driver/lib/dri/tls/swrast_dri.so
libGL: OpenDriver: trying /run/opengl-driver/lib/dri/swrast_dri.so
libGL: Can't open configuration file /etc/drirc: No such file or directory.
libGL: Can't open configuration file /home/cstrahan/.drirc: No such file or directory.
libGL: Can't open configuration file /etc/drirc: No such file or directory.
libGL: Can't open configuration file /home/cstrahan/.drirc: No such file or directory.
[CZPClientLogMgr::LogClientEnvironment] [MacAddr: F0:03:8C:3B:A5:E7][client: Linux][OS: NixOS 17.09.git.f3aa499 (Hummingbird)][Hardware: CPU Core:6 Frenquency:3.79995 G Memory size:128856MB CPU Brand:Intel(R) Core(TM) i7-6850K CPU @ 3.60GHz][Req ID: ]
Linux Client Version is 2.0.91373.0502
QSG_RENDER_LOOP is
Graphics Card Info:: 01:00.0 VGA compatible controller: NVIDIA Corporation GP104 [GeForce GTX 1080] (rev a1)
Zoom package arch is 64bit, runing OS arch is x86_64
AppIconMgr::systemDesktopName log Desktop Name:

@danbst @k0001 @shlevy @kamilchm Would one of you (anyone using something other than the proprietary nvidia driver) mind testing #26916, please? Removing mesa from the LD_LIBRARY_PATH fixes my problems, but I want to make sure that doesn't introduce problems for everyone else.

@cstrahan I was able to start zoom-us and the video is still working even after your change! I'm glad you were able to get this working!

@k0001 Awesome -- thanks!


Unable to train the model, there is an issue with the dataset

After running "python train_model.py," I encountered the following issue. When I directly access this URL, it returns "Entry not found.
#python train_model.py
CUDA available: True
CUDA version: 11.8
Traceback (most recent call last):
  File "train_model.py", line 31, in <module>
    raw_datasets = {
  File "train_model.py", line 32, in <dictcomp>
    prefix: load_dataset(data, split="train") for prefix, data in dataset_names.items()
  File "/root/miniconda3/lib/python3.8/site-packages/datasets/load.py", line 2129, in load_dataset
    builder_instance = load_dataset_builder(
  File "/root/miniconda3/lib/python3.8/site-packages/datasets/load.py", line 1815, in load_dataset_builder
    dataset_module = dataset_module_factory(
  File "/root/miniconda3/lib/python3.8/site-packages/datasets/load.py", line 1512, in dataset_module_factory
    raise e1 from None
  File "/root/miniconda3/lib/python3.8/site-packages/datasets/load.py", line 1489, in dataset_module_factory
    return HubDatasetModuleFactoryWithoutScript(
  File "/root/miniconda3/lib/python3.8/site-packages/datasets/load.py", line 1031, in get_module
    dataset_readme_path = cached_path(
  File "/root/miniconda3/lib/python3.8/site-packages/datasets/utils/file_utils.py", line 182, in cached_path
    output_path = get_from_cache(
  File "/root/miniconda3/lib/python3.8/site-packages/datasets/utils/file_utils.py", line 601, in get_from_cache
    raise ConnectionError(f"Couldn't reach {url} (error {response.status_code})")
ConnectionError: Couldn't reach https://huggingface.co/datasets/h4iku/coconut_java2006_preprocessed/resolve/76a94c2ccfd933177a62d8d5a5eea4ce4b84af34/README.md (error 503)

sorry for the disturbance, it's just due to network issues.


Quick Alchemy Dedication Feat

Expected Behaviour: The Quick Alchemy feat obtained through the Alchemist Dedication should provide the Quick Alchemy toggle on the Crafting page.
Current Behaviour: Said feat does not provide the Quick Alchemy toggle
Workaround: Adding the Quick Alchemy Feature adds the toggle correctly

Alchemist Dedication is not supposed to grant Quick Alchemy
https://2e.aonprd.com/Feats.aspx?ID=665
If you mean the base class, it seems to work for a new character
Is Alchemist Dedication feat somehow granting you Quick Alchemy?

Nope, mean the Quick Alchemy level 4 feat within the Alchemist Dedication.
https://2e.aonprd.com/Feats.aspx?ID=667

Ah I think I understand now. The feat doesn't grant but the class feature does.
Root cause is that the check on the crafting tab only checks for the class feature roll option and not for the feat.


AKNodeOutputPlot stops working when app is used as sender in inter-app audio.

I recently added support for Audiobus and inter-app audio to my app. However, when I go to GarageBand and add my app as the instrument, although it does show up and sounds perfectly fine, the AKNodeOutputPlot view does not show any waveforms. It simply shows a flat line.

Audiobus steals the output so you have to make the plot tap at a point earlier in the signal chain.  So, just create a fake mixer one step ahead of the output and use that as your source for the node output instead. This probably should have been asked on StackOverflow instead so that it could seen by others.

Okay, thanks for the quick reply!


Use password type for inputs

Resolves https://github.com/mprimi/portable-secret/issues/25

Just a comment, instead of comparing the raw bufs, why not compare the strings directly?

Just a comment, instead of comparing the raw bufs, why not compare the strings directly?

I tried to follow the existing code's usage of raw bufs over strings. Presumably it's a security thing related to Why is char[] preferred over String for passwords?](https://stackoverflow.com/q/8881291/6243352) although OP would have to confirm their intent.

Just a comment, instead of comparing the raw bufs, why not compare the strings directly?

I tried to follow the existing code's usage of raw bufs over strings. Presumably it's a security thing related to Why is char[] preferred over String for passwords? although OP would have to confirm their intent.

Crypto APIs work with byte arrays (Uint8Array), for obvious reasons (if not obvious let me know, I can explain why).
You could compare the two values as string, before turning them into byte arrays. That should be good enough.
(is there really no built-in to compare two arrays by value in JS...?)
Also, this PR is one commit that does 2 things:

Add a second "confirmation" password box
Change the password type field to 'password'

If you could split that into 2 commits, that increases the chances I'll review and merge this PR (no promises).


Simplify the way we pass around Contributor data

I was getting confused about why there are seemingly two sources of description:

Contributor.description, and
Contributor.contributor.description

but if you look at where this type is transformed from the Prismic model, you see they always contain the same value!  This implies two different bits of data when really they're the same, so I've removed one copy to avoid more confusion.

I also spotted that the ContentPage component has a contributorTitle property which is never used, so I removed that.
And while tugging on this thread, I cleaned up various other small bits along the way.

Looking at this with Raphaëlle, I think this is just flat-out wrong.


Plugin duplicating in the bar

This plugin seems to duplicate itself and I havent pinned down why.
# <bitbar.title>Weather</bitbar.title>
# <bitbar.version>v2.0.4</bitbar.version>
# <bitbar.author>Daniel Seripap</bitbar.author>
# <bitbar.author.github>seripap</bitbar.author.github>
# <bitbar.desc>Detailed weather plugin powered by forecast.io with auto location lookup. Supports metric and imperial units. Needs API key from http://developer.forecast.io.</bitbar.desc>
# <bitbar.image>https://daniel.seripap.com/content/images/2016/01/bb-weather_v1-3-5-1.png</bitbar.image>
# <bitbar.dependencies>python</bitbar.dependencies>

Which version of BitBar do you use (you can check under Preferences)?

I was on 1.5beta and I just noticed there is an update to 1.9. Trying that to see if it fixes it. It usually takes a day or so to happen.

v1.5 is really old. Please update.

I am having this issue with BitBar 1.9.2.

I am seeing this as well..  I can reproduce on my Macbook Air pretty reliably.  It happens whenever an icon gets hidden due to the application window taking up too much space.  When I switch to an application with a smaller menubar footprint, then I have a second icon for whatever was hidden.  It's as if Bitbar thinks it was destroyed, re-creates it when it's told the menubar has visibility.

This stopped when I updated to the latest version and hasn't happened since.

I wonder if you were hitting #21 .  Sounds like @fenhl and I may be having a different issue then you then.


Update msnodesqlv8 to 0.3.2

Hi,
I think version 0.3.1 is not support for Electron 1.7.5.
Please update to 0.3.2.

msnodesqlv8 dependency was updated in 0.2.6-beta.5.


Add color diff for small dataframe comparison

Hi! I am always annoyed that I have to diff go to text compare website and  compare the actual and expected version when using dataframes. That's why I've created this PR.
Before

After

WDYT?

@happytomatoe May you take a look on the failed tests, please?

@SemyonSinchenko Now tests are completing successfully. Could you please take a look?

@SemyonSinchenko Do you plan for a release?


Add roles and aria-levels to site description on the homepage

Added role="heading" and aria-level="2" to both the <p> tag and the <span> tag used within the homepage. I used the following resources to determine the values for these, however will confirm with the accessibility checker if I have implemented correctly.
Resources:

W3C Aria Standard

Passes checker


Same lvar name in then and else clause

I got this error

ProgramError: cannot reassign to right' (Hint: declare it with var')

but this program does not reassign to right.

Lvar scoping rule (draft)

If a local variable newly appears in a if/match clause, its scope is the clause.

Example
x = 1
if foo
  p x # OK, of course
  x = 1  # NG because this is the same variable as the previous `x` which is not declared with `var`
  y = 1  # OK
else
  y = true # OK because this is a different variable from the above `y`
end
y  # NG because the previous `y`s are only accessible in the if clauses
y = "test" # OK (Declaring a new variable)


New :on-request handler

Allow dispatchers to keep track of raw xhrio objects, as per #3

I just took a stab at this as mental exercise. I'm busy wiring this up in a real life app to see how it performs in both cases mentioned in #3 (debouncing duplicate requests and cancelling long/slow requests)

As with all things non-deterministic, this is tricky. That said, my first refactorings for both cases held up quite nicely. Although it is more verbose than it was, it is very clear and has the same shape as all the other handlers in the app. Being able to place the requests in the app-db and later recall it to cancel is quite neat.
Wondering if @deepxg & @flexsurfer have any thoughts on if this implementation could solve their needs?

👋
Any feedback on this PR?

As noted in cljs-ajax changelogs:

It is intended that the default implementation for JavaScript uses XmlHttpRequest directly and XhrIO is deprecated in 0.8. Be warned.

Thanks for the feature @kennethkalmer  👍
http-fx is probably going to be superseded at some point in the not too distant future. Exploration of that has already been underway since last year in http-fx-alpha and re-frame-fetch-fx.
But in the meantime I don't see any disadvantage to merging this improvement and its got a reasonable use case of being able to cancel long running requests.


fix: change grid rows template, update and add note.less to registration

Closes: https://github.com/exadel-inc/ui-playground/issues/715

:tada: This PR is included in version 2.1.0-beta.5 :tada:
The release is available on:

npm package (@beta dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


The problem with Omit utility type

🔍 Search Terms
When we use Omit utility type we don't get auto-completion like we have in pick.
✅ Viability Checklist

[X] This wouldn't be a breaking change in existing TypeScript/JavaScript code
[X] This wouldn't change the runtime behavior of existing JavaScript code
[X] This could be implemented without emitting different JS based on the types of the expressions
[X] This isn't a runtime feature (e.g. library functionality, non-ECMAScript syntax with JavaScript output, new syntax sugar for JS, etc.)
[X] This feature would agree with the rest of our Design Goals: https://github.com/Microsoft/TypeScript/wiki/TypeScript-Design-Goals

⭐ Suggestion
I just created my own utility type called OmitKeys

type OmitKeys<Type, K extends keyof Type> = Omit<Type, K>

📃 Motivating Example

type A = {
    name: string,
    age: number,
    class: string
}

type OmitKeys<Type, K extends keyof Type> = Omit<Type, K>

type a = OmitKeys<A, "age" | "name">

💻 Use Cases

What do you want to use this for?
What shortcomings exist with current approaches?
What workarounds are you using in the meantime?

🔍 Search Terms
When we use Omit utility type we don't get auto-completion like we have in pick.

Try using keywords as search terms, then you might have better luck finding the duplicates.

You didn't fill out the issue template, so it's unclear what you're actually suggesting. Under "Suggestion" you just wrote "I created my own type", nothing more.
If you're suggesting to change Omit<> to use keyof T, then it's a duplicate of #30825 (and many many others). If you're suggesting to add the OmitKeys<> type to the standard library, then it's out of scope as the team decided to not add further utility types unless they're needed for emit purposes.

Also see https://github.com/microsoft/TypeScript/issues/54451

Duplicate #56135? But it's hard to tell what you want here without filling out the template more concretely.


"make test" fails with go 1.14

make test fails with the error message fatal error: checkptr: unsafe pointer conversion which appears related to an issue with packr and go 1.14. The -d=checkptr compile time check is enabled by default as part of go 1.14 on non-Windows platforms. I don't think there's anything we can change, but opened this for tracking purposes until it's fixed.
Related:
https://github.com/gobuffalo/packr/issues/261
https://golang.org/doc/go1.14#compiler

We should probably look into upgrading to https://github.com/markbates/pkger

There's also a proposal to natively support embedding static assets: https://github.com/golang/go/issues/35950, though it seems pkger will be more immediately available.


Feature/issue 2814 warmup auto

Submisison Checklist

[ ] Run tests: ./runCmdStanTests.py src/test
[x] Declare copyright holder and open-source license: see below

Summary:
This is the interface component to https://github.com/stan-dev/stan/issues/2814
Intended Effect:
Make the automatically chosen metric work with cmdstan!
How to Verify:
Any model built with this cmdstan can now use the 'auto_e' metric.
./model sample algorithm=hmc metric=auto_e

And that'll run and print some stuff out. Currently your output might look something like this:
Iteration:    1 / 2000 [  0%]  (Warmup)
Iteration:  100 / 2000 [  5%]  (Warmup)
adapt: 99, which: dense, max: 12.7748
adapt: 99, which: diag, max: 999.44
adapt: 149, which: dense, max: 15.916
adapt: 149, which: diag, max: 752.325
Iteration:  200 / 2000 [ 10%]  (Warmup)
adapt: 249, which: dense, max: 11.4019
adapt: 249, which: diag, max: 587.708
Iteration:  300 / 2000 [ 15%]  (Warmup)
Iteration:  400 / 2000 [ 20%]  (Warmup)
adapt: 449, which: dense, max: 12.8718
adapt: 449, which: diag, max: 1072.26
Iteration:  500 / 2000 [ 25%]  (Warmup)
Iteration:  600 / 2000 [ 30%]  (Warmup)
Iteration:  700 / 2000 [ 35%]  (Warmup)
Iteration:  800 / 2000 [ 40%]  (Warmup)
Iteration:  900 / 2000 [ 45%]  (Warmup)
adapt: 949, which: dense, max: 11.2085
adapt: 949, which: diag, max: 1235.64
Iteration: 1000 / 2000 [ 50%]  (Warmup)
Iteration: 1001 / 2000 [ 50%]  (Sampling)
Iteration: 1100 / 2000 [ 55%]  (Sampling)
Iteration: 1200 / 2000 [ 60%]  (Sampling)
Iteration: 1300 / 2000 [ 65%]  (Sampling)
Iteration: 1400 / 2000 [ 70%]  (Sampling)
Iteration: 1500 / 2000 [ 75%]  (Sampling)
Iteration: 1600 / 2000 [ 80%]  (Sampling)
Iteration: 1700 / 2000 [ 85%]  (Sampling)
Iteration: 1800 / 2000 [ 90%]  (Sampling)
Iteration: 1900 / 2000 [ 95%]  (Sampling)
Iteration: 2000 / 2000 [100%]  (Sampling)

The extra output (stuff starting with "adapt") is something I want to talk to the reviewer about (do we need any extra output? Is this the right output). Right now the results of computing the selection criteria from the paper are being printed. Smaller is better, and the adaptation will use for the next sampling stage whichever of the two metrics had a lower value.
Side Effects:
Hopefully none
Documentation:
None yet!
Copyright and Licensing
Please list the copyright holder for the work you are submitting (this will be you or your assignee, such as a university or company): Columbia University
By submitting this pull request, the copyright holder is agreeing to license the submitted work under the following licenses:

Code: BSD 3-clause (https://opensource.org/licenses/BSD-3-Clause)
Documentation: CC-BY 4.0 (https://creativecommons.org/licenses/by/4.0/)

@bbbales2 does this branch work? I could test this via cmdstanr

as I recall there is a corresponding cmdstan branch. With that it should work, but let's wait for @bbbales2 .

as I recall there is a corresponding cmdstan branch. With that it should work

@wds15 I guess you missed that this specific pull request is for merging that specific cmdstan branch. Based on this pull request this branch has not been touched since early September, so I doubt that this works. I decided to ask Ben here since even git clone for the branch associated to the pull request wasn't able to do recursive cloning.

@avehtari whoops, looks like I put the Stan branch on my fork of Stan
This should get you what you need:
git clone --recursive https://github.com/stan-dev/cmdstan.git cmdstan-auto
cd cmdstan-auto
git checkout feature/issue-2814-warmup-auto
cd stan
git remote add bbbales2 https://github.com/bbbales2/stan.git
git fetch bbbales2
cd ../
make stan-update


teatArea nzAutosize may get scroll bar

Reproduction link
https://stackblitz.com/run
Steps to reproduce

set a textarea with nzAutosize which does't have maxRows
insert 10  new lines

What is expected?
The height should change automatically without scrollbar
What is actually happening?
The scrollbar appears sometime

Environment
Info

ng-zorro-antd
9.3.0

Browser
All

I did some search on autosize directive. I think this is caused by the height calculate logic:
let height = Math.round((textarea.scrollHeight - this.inputGap) / this.cachedLineHeight) * this.cachedLineHeight   this.inputGap;

https://stackblitz.com/edit/angular-9y7rqz?file=src/app/app.component.ts
Please provide a valid reproduction


standardize the comments that reference the consensus-specs

Currently there are functions that reference functions in the specs to let the reader know what function this is supposed to match.
This is a tracking issue to check those comments and ensure that they are standardized for folks who want to grep the codebase

Closed by #218


add Hellō provider

Summary
Adds Hellō (https://issuer.hello.coop) as an IdP for email
#1683
Release Note
Adding issuer.hello.coop to Fulcio
Hellō meets the requirements defined in  https://github.com/sigstore/fulcio/blob/main/docs/new-idp-requirements.md

Issuer keys are managed by KMS, rotated automatically every 30 days.
'sigstore' client is configured, and works with localhost redirect and device flow
all emails are verified
sub is a GUID generated on each new user

Documentation
Not at this time

@bobcallaway @haydentherapper  -- next steps for this PR?
This would increase the options developers have if they want to opt into using Hellō.

@bobcallaway @haydentherapper -- it has been a month since my last bump. While the docs encourage PRs -- this has not been a great experience as a contributor. :(

@dickhardt As mentioned at the conference, we'll be discussing adding new providers in the next TSC meeting. There has not been a TSC meeting since the conference due to the 4th being a holiday, it'll be discussed in the next.

@haydentherapper  ... and the next one is when?

Thursday, the 18th.

You’ll just need to update where you declare the new provider, it’s under a new yaml config.


Plugin process lifecycle

The process for an executable plugin are currently started after each keystroke, this has quite a few drawbacks imo. The main problem is that the process is stateless, we can not store variables between queries, and any contstructor/init method has to be re-run for each query.
This may be fine for most plugins, but if our plugin for example needs to read a file it would be very excessive to read it on each keystroke, instead of storing its content between queries. If the process was keept alive we could instead use a more event driven approach and continuously listen for input and handle them accordingly, without having to re-read the file.
What if we was able to specify the process lifecycle of our plugin in plugin.json?
Ideas:

Always: Keep the process alive, as long as wox.exe is running.
Keyword: Keep the process alive as long as our ActionKeyword is matched.
Open: Keep the process alive as long as Wox is open.
Query: Spawn for each query, the current solution.

One downside to keeping it alive would be that the plugin itself would have to handle the cancellation of async functions whenever the search query changes. But even if the plugin didn't, it should still be a non-issue for Wox to filter out "old" results if the JSONRPC spec was followed and an id (#113) was included.
relevant: #47

nodejs (psuedo) examples of stateless vs event driven plugins
// stateless (current)
const settings = readFile("%APPDATA%/Wox/Settings/Plugins/xx/Settings.json");
const { method, parameters } = parseStdin();

if (method == "query") {
  stdout(/* my result.. */);
}

// event driven
const settings = readFile("%APPDATA%/Wox/Settings/Plugins/xx/Settings.json");
const events = new EventEmitter(); // https://nodejs.org/api/events.html

events.on("query", function(parameters) {
  stdout(/* my result.. */);
});

// listen for stdin
process.stdin.on("data", function(data) {
  const { method, parameters } = parseStdin(data);
  events.emit(method, parameters); // trigger the `method` event
});

Just going to close this as this repo is no longer maintained, feel free to open the issue in Flow if this is still a problem


[BUG]  Timestamp  of iGotfy is always 0s ago

Describe the bug
Notify & iGotify are working fine only the time of the message is always 0s ago (see picture)
Expected behavior
The time should change
Smartphone (please complete the following information):

Device: iPhone 14 Pro Max
OS: 17.6.1
app version 1.3.2 (25)
Server version 2.5.0
API version <IP_ADDRESS>
running in docker on an Unraid system.

Additional context
-I am using cloudflare. ( issue exists with local IPs too)
-The log files have correct timestamps.

Hi did you take a look at some closed issues #88 #86 for example?
You need to remove the TZ Variable from the container. This change stands in the latest changelog of the App and the container release!

Hello,
Thank you for your fast reply.
Gotify needs TZ=UTC  as timezone if you are using Unraid.
Thank you for the hint. This bug can be closed.

gotity and igotity  TZ env all need to delete

i have same issue, if you use unraid you can use portainer to edit env,and delete TZ. then deploy again. it's works for me


⚠ Secret-Cinema has degraded performance

In 4bd7e2d, Secret-Cinema ($SC) experienced degraded performance:

HTTP code: 200
Response time: 16583 ms

Resolved: Secret-Cinema performance has improved in 350bf4e after 5 minutes.


[build-script] Disable watchpoint testing in lldb

These tests appear to be flaky on Linux:
https://ci.swift.org/job/oss-lldb-incremental-linux-ubuntu-16_10/3177

@swift-ci smoke test and merge

There's an unrelated test failure here that https://github.com/apple/swift/pull/15317 addresses.

@swift-ci smoke test and merge