fix: add linux node selector to deployments

When KEDA is deployed to a mixed Kubernetes cluster with linux and windows nodes, the deployments did not select the linux nodes explicitly and could not be started on windows nodes.
Checklist

[x] I have verified that my change is according to the deprecations & breaking changes policy
[x] Commits are signed with Developer Certificate of Origin (DCO - learn more)
[-] README is updated with new configuration values (if applicable) learn more
[-] A PR is opened to update KEDA core (repo) (if applicable, ie. when deployment manifests are modified)

Hi
Have you faced with KEDA or with the HTTP Add-on chart? KEDA chart already has the node selector

We are cutting a release of the HTTP add-on right now, so I have just included the missing node selector within
https://github.com/kedacore/charts/pull/543

Hi,I actually added it to both, but maybe I missed something in keda core.Thanks for adding it to the html-add-on release!Philipp Am 2023. 10. 05. um 15:02 schrieb Jorge Turrado Ferrero @.***>:
Hi
Have you faced with KEDA or with the HTTP Add-on chart? KEDA chart already has the node selector
—Reply to this email directly, view it on GitHub, or unsubscribe.You are receiving this because you authored the thread.Message ID: @.***>

I close this as I have included your changes in that PR in progress (it's faster than fix your PR, merge it and update the other). Thanks for the PR in any case


npm peer dependency warning

npm WARN peerDependencies The peer dependency<EMAIL_ADDRESS>included from coffee-loader will no
npm WARN peerDependencies longer be automatically installed to fulfill the peerDependency
npm WARN peerDependencies in npm 3+. Your application will need to depend on it explicitly.

It's a warning for your project. Add coffee-script as dependency.

coffee-script is already a dependency in my project. It's a warning for coffee-loader that peer dependencies will not be automatically installed in the future. coffee-loader needs to move coffee-script from a peer dependency to a normal dependency.


Marketing email without Survey button

Hello,
When I send marketing email with a survey button, the email is received without the button.
It doesn't matter if I send directly the email or if I use a customer journey to send it, the email is received without the button.
The button appears when it's linked to an URL but not appears when it's linked to a survey.
Could you help to figure it out please?

@Guillaumeperson63 We do not provide support here. This is for documentation related issues and questions. If you have questions about the documentation, please provide a link to the related topic so that we may assign the correct writer to respond.

Please find bellow the link to this related topic on the Microsoft documentation :
https://learn.microsoft.com/en-us/dynamics365/marketing/customer-voice#dynamics-365-customer-voice-survey-links-in-email-messages

Thanks for your question! The best place for product requests or troubleshooting is the Dynamics 365 Marketing forum at https://community.dynamics.com/365/marketing/f/dynamics-365-for-marketing-forum - repost your question there and a developer will be able to help you.


⚠ Cioos Pacific ERDDAP has degraded performance

In 549cf76, Cioos Pacific ERDDAP (https://data.cioospacific.ca/erddap/index.html) experienced degraded performance:

HTTP code: 200
Response time: 10065 ms

Resolved: Cioos Pacific ERDDAP performance has improved in 13adb71.


Fix detection of default docker machine in OSX

While running through he procedure, the script did not detect the default docker machine on my laptop (running OSX). Adapting the grep command fixed it for me.

Thanks for the fix.

BTW, this won't work on linux!


[Polling Station] If we store the log history and how to make it if yes

As the subject, Crane is supporting real-time logs. If we add the log history feature? AFAIK, the ElasticSearch or other distributed FS have to be integrated into, which will heavy the crane project much. But the FeatureFlag logHistory can light it maybe.
So we are looking for your advice?

Implement it? yes or no
how to solve it? ElasticSearch or others?

we need have a ability to integration with another tools, not add ES to crane technical stack.

@vitan have you consider pipe Crane SSE log into ES or some other log collecting system.


Ignore deps

Ignore dependencies by specifying a glob, as outlined in Issue #71.
$ npm-check --ignore babel-* --ignore chalk will ignore all dependencies starting with 'babel-' and named 'chalk'.
Used Minimatch instead of globby for String matching instead of relative (cwd) file matching.
Didn't update API section of README.md

$ npm run readme won't work for me, edited both templates/ and README.md manually.

@dylang This would be a very welcome addition. What is the state of this PR?

@dylang Hi! Can you provide any updates for this PR? Why is it still not released?

@amilajack @StyleT  Just updated the minimatch's version, so let's see what happens.

👍

:+1:

:+1:

Merged 🎉

👍  this is awesome. Thanks for getting this added, merged, and deployed. 👏

Unfortunately I don't have permission to publish with npm 😢

Cutting a release now :)

Released as 5.4.0

@amilajack I don't think I have permissions to add you on npm sadly :(


v2 Tweet, unable to unpickle using dill, max recursion reached

Using the new v2 twitter API and version 4.5.0 of Tweepy, with version 0.3.4 of dill, the following code results in a RecursionError: maximum recursion depth exceeded:
query = 'your search here'

import tweepy
from twitter_credentials import bearer_token
client = tweepy.Client(bearer_token=bearer_token, return_type = tweepy.Response)

search_result = client.search_recent_tweets(query = query, max_results=10)

t = search_result.data[0]

import dill
serialized = dill.dumps(t)

u = dill.loads(serialized)

The problem seems to be in __getattr__:
  File "/Users/username/opt/anaconda3/lib/python3.8/site-packages/tweepy/mixins.py", line 30, in __getattr__
    return self.data[name]
  [Previous line repeated 992 more times]

It sure would be dandy to be able to serialize using dill!

What's the use case for this? Is there a reason you're trying to pickle the Tweet object rather than just storing the JSON data?

Great question.  I teach a course on Python for Data Science, and I like teaching pickling/unpickling as a component of the second part of our project.  In particular, I like that unpickling (hypothetically) keeps Tweet objects as Tweet objects, so there's no conversion from JSON back to tweepy.Tweet necessary.  Just unpickle.
A secondary lesson I teach related to this is to collect data once, and process it as-needed.  That way we have a stable data set when developing analysis code, and we're not wasting our search credits (since they're a finite resource).  So I really want my students to be able to save the results of a search, and load those results back into Tweepy objects at a later time.
If you feel this use case is silly and JSON is superior in every way, I'm all ears.  Or, if conversion back to Tweet is a one-liner, I'm open to that, too.

I do feel like my request is reasonable, as I was able to pickle Status objects coming from the v1 Twitter API.  So this feels like a regression to me.

I'm not completely adverse to adding support for pickling. As you pointed out, Twitter API v1 models/objects can be pickled (although that's not a regression, as the Twitter API v2 models/objects are a new interface). However it's worth noting that right now, it's already very simple to get the JSON data dictionary from an API v2 object and/or use it to (re-)create the object, e.g.:
data = tweet.data
tweet = tweepy.Tweet(data)

Currently, this is the best way to retrieve the data from an API v2 object and be able to save it (e.g. as a JSON file) and load it back into a Tweepy object.
I actually think this is an interesting use case, and I'm inspired that Tweepy is being used educationally. However, I'm not sure about the practical application or necessity of pickling in this case, beyond as a way of teaching pickling/unpickling. I don't think JSON is superior in every way, but as I'm sure you know, there are definitely advantages over pickling.
Both are serialization formats, so I don't think it makes too much sense to say that pickle keeps objects as themselves more so than JSON does, at least in cases like this where the objects can be represented in their entirety as JSON data (and are in fact parsed from JSON data). In both cases, you're serializing and unserializing the data. In fact, efficiency-wise, I think JSON is generally a lot faster.
Tweepy already makes the process simple for JSON because the API returns the data as JSON. I don't think there would be any advantages to using pickle over JSON for API v2 objects, but I think the fix for this error would be relatively simple.

I also got this error while trying to pickle Response objects. I ended up saving out each part of Response objects (.data, .includes, .errors) as JSON lines files, but it would have saved me time to simply be able to pickle them all.

Would also love seeing support for this, mostly for the reasons mentioned in the OP.

@michaelmilleryoder Is there any reason you couldn't set the return_type to dict and save the response as JSON directly?
@harshil21 I still don't see a particular need or use case for this over storing the data as JSON, besides a specific desire to teach pickling.

@Harmon758 Setting return_type=dict when I initialize the tweepy Client should work! I didn't know about that option--thanks.

I personally prefer plain JSON format for storing and transporting data.
JSON is the default for, say, "web", and Twitter APIs provide data encoded using JSON too. I would say pickling in Tweepy reduce the interoperability/readability and security. Use pickle only if you are sure it brings more benefits.
(I hope I didn't misunderstand the Request For Comments (RFC) label)

PR #2060 fixes this issue as well.
Changing the unittest accordingly verifies that. (I have not added this, as it would add a new code dependency.)
import dill
import unittest

from tweepy.tweet import Tweet

class TweepyTweetTests(unittest.TestCase):
    def test_tweet(self):
        t = Tweet(
            data={
                "edit_history_tweet_ids": ["16213149247090909"],
                "id": "16213149247090909",
                "text": "We're super excited to not only welcome the Flamingo Janes in...",
            }
        )

        pickled_tweet = dill.dumps(t)
        t2 = dill.loads(pickled_tweet)

        self.assertDictEqual(t.data, t2.data)

Ni! Thanks @achimgaedke , that worked for me.
My use case was quite straightforward: it allowed me to recover a large dataset that a colleague had (unthoughtfully, yet conveniently for them) stored as a pickle.
@Harmon758 : I think it is a problem that things can be pickled but not unpickled. If you don't plan to support unpickling, then please make it so that pickling doesn't give the false impression that the data was properly stored and can be recovered. There are quite a few people who are used to pickling stuff for quick storage and will fall into the trap, possibly losing their work.
Best!


Athena, Presto, Trino Extension

is there any plan to create AWS Athena Extension, it has jdbc driver and its supporting insert queries, it should be possible to run liquibase by looking at last record.
and similar technologies Presto and Trino having update features now
┆Issue is synchronized with this Jira Bug by Unito

Hi @ismailsimsek .  There is currently not a plan to write an Athena, Presto or Trino extension. You are welcome to write one and/or create a test harness update to see what does and what does not work out of the box with those databases.  Great idea though.

Maybe it is a bit late but I have created my own extension (alvsanand/liquibase-athena). It is in early stages but it is functional.

Started Trino extension but its still WIP, if anyone interested please feel free send PR. https://github.com/ismailsimsek/liquibase-trino


(Question) How to sync underlying file correctly?

I have a GzipEncoder<File> and I need to finalize it.
I'd like to call sync_all() on it. But before I do that I think I need to finalize encoding first. As far as I understand it is done by calling .shutdown() on the encoder. But the problem is that it will also call .shutdown() on the underlying writer's .shutdown() (link)
I believe it's incorrect to call anything that potentially writes to a file  after it was shutdown, so I'm in an egg vs chicken kind of situation right here.
Sorry for posting this as an issue, I just don't see any Discussions/forum to ask questions.

You can call poll_flush to flush the data, then sync_all to sync the data and metadata before shutting it down.

Either I'm missing something or what you're proposing is incorrect.
In order to sync the file properly everything has to be written to it before calling sync_all - it means that encoder needs to be finished (not just flushed).
From what I see in public API the only way to finish encoding is to call .shutdown(), but it will also call shutdown on the underlying file (which might be a problem).
For files specifically this might not be a problem, because tokio::fs::File::shutdown is essentially the same as flush link.
It just seems like the API forces to break shutdown contract "do not read/write after shutdown".

You could have an intermediate wrapper that doesn't forward shutdown to the underlying file, just flushes it and reports that it has been shutdown.
GzipEncoder<NoShutdown<File>>

Nice, this seems like an actual solution.

Or you can change it to sync_all on shutdown
struct SyncOnShutdownFile {
    file: File,
    // JoinHandle is fused internally
    sync_all: Option<JoinHandle<io::Result<()>>>,
}

impl AsyncWrite {
    fn poll_shutdown(
        self: Pin<&mut Self>,
        cx: &mut Context<'_>,
    ) -> Poll<io::Result<()>> {
        let Self { file, sync_all } = Pin::into_inner(self);
        ready!(file.poll_flush(cx));

        if sync_all.is_none() {
            let file = file.try_clone()?.into_std();
            // currently tokio internally spawns, if io-uring is used then it's a different story
            *sync_all = tokio::task::spawn_blocking(|| f.sync_all());
        }
        ready!(Pin::new(sync_all.as_mut().unwrap())).map_err(io::Error::from)??;

        file.poll_shutdown(cx)
    }
}


submenu.toggle() is not a function

BUG:
document.querySelector('#submenuelement').toggle() is not a function

Can you post a reproducible example with jsbin?
This should also be posted to the paper-menu repo

This issue was moved to PolymerElements/paper-menu#81


Aggregate data

Fixes #4
Hi @haesleinhuepf ,
this PR attempts to start on expanding the functionality of the time-slicer to more Layer types and hopefully allow other functions that use the time-slicer to be a bit more agnostic to whether something is 4D or 3D or 2D +t or whatever.
Summary
In short, I brought the TimelapseConverter class from napari-stress (originally here) to the time-slicer and re-factored it a bit to be cleaner and better readable.
The class has two major methods: convert_4d_data_to_list and convert_list_to_4d_data which convert 4D to a list of 3D data or vice versa. The methods only require the to-be-converted data and the type of the input layer. The correct conversion function is then looked up from a dictionary that holds the respective conversion function for each kind of layer.
In the time-slicer, I created a new function aggregate, which basically drags the slider and aggregates all the data in memory. The aggregation only requires the convert_list_to_4d_data from the TimelapseConverter, but maybe the other step may also be helpful somewhere in the future if the first step in a workflow is a 4D surface or whatever.
Tests
I wrote unit tests and tested the aggregation from the napari viewer, which worked well. The only use case I didn't get to work was to get some measurements with regionprops aggregate those for all timeframes, which is probably because regionprops is currently not decorated (compatible?) with the time slicer.
This is probably not complete but maybe a step in the right direction :)
Future talk

I would love to somehow submit the execution of a workflow step to a dask client rather than having to wait for each frame's computation.
If the measurement functions would be compatible with the time-slicer, this would make the existence of multiple measurement functions (measurement vs meansurement_of_all_frames) redundant.

Hi Johannes @jo-mueller ,
awesome, thanks for working on this!
I presume the function you're proposing here does the tecnically same as this one:
https://github.com/haesleinhuepf/napari-time-slicer/blob/90797a79fedfb0353c3fe5e8daf38455f3e6a5b8/src/napari_time_slicer/_function.py#L31-L74
Do you think it would be possible to merge both functions?

I would love to somehow submit the execution of a workflow step to a dask client rather than having to wait for each frame's computation.

I've started working on this here:

https://github.com/haesleinhuepf/napari-time-slicer/pull/6

Feel free to try it out and see if this in compatible wit points and surfaces. Feedback is very welcome.
Best,
Robery

@haesleinhuepf thanks for looking into it.

Do you think it would be possible to merge both functions?

I could simply merge my code into that function, jup. They are pretty identical, that's true ^^ I'll update the PR.

@haesleinhuepf I merged the two functions with identical scope into a single function (the one that already existed).


Error: Input is not a transformation.

Hi,
I hope this is the right place to raise this issue. I'm not an experienced programmer but i believe I've found an issue.
I wrote a script that receives XY-coordinates and a PROJCS parameter in ESRI WKT / PRJ format as input (downloaded from https://epsg.io). Using PyProj, I transform these coordinates from the local coordinate system to WGS84.
The following error appears when providing the parameters for EPSG code 31466:
Traceback (most recent call last):
  File "xxx\017 Python\PRJ to WGS84\prj_to_wgs84.py", line 21, in <module>
    proj = pyproj.Transformer.from_crs(prj_parameters, 4326, always_xy=True)
  File "pyproj\transformer.py", line 625, in from_crs
  File "pyproj\transformer.py", line 337, in __init__
  File "pyproj\transformer.py", line 105, in __call__
  File "pyproj\\_transformer.pyx", line 583, in pyproj._transformer._Transformer.from_crs
  File "pyproj\\_transformer.pyx", line 653, in pyproj._transformer._Transformer._init_from_crs
  File "pyproj\\_transformer.pyx", line 359, in pyproj._transformer._Transformer._initialize_from_projobj
pyproj.exceptions.ProjError: Input is not a transformation.: (Internal Proj Error: pipeline: Pipeline: Bad step definition: proj=hgridshift (File not found or invalid))
[PYI-3356:ERROR] Failed to execute script 'prj_to_wgs84' due to unhandled exception!

Been looking all over the internet for a solution and after some time i found that the PROJCS string contains a parameter called "EXTENSION". If I remove this parameter from the string, my program works.
I can check if the string contains this parameter and then remove it, but that is not the cleanest option.
Is this a bug or am i doing something wrong here?
code:
# import libraries
import pyproj, csv, sys, pathlib, numpy as np

prj_parameters = 'PROJCS["DHDN_3_Degree_Gauss_Zone_2",GEOGCS["GCS_Deutsches_Hauptdreiecksnetz",DATUM["D_Deutsches_Hauptdreiecksnetz",SPHEROID["Bessel_1841",6377397.155,299.1528128],EXTENSION["PROJ4_GRIDS","BETA2007.gsb"]],PRIMEM["Greenwich",0.0],UNIT["Degree",0.0174532925199433]],PROJECTION["Gauss_Kruger"],PARAMETER["False_Easting",2500000.0],PARAMETER["False_Northing",0.0],PARAMETER["Central_Meridian",6.0],PARAMETER["Scale_Factor",1.0],PARAMETER["Latitude_Of_Origin",0.0],UNIT["Meter",1.0]]'
coordinates = np.asarray([
	[2570512.975,5647780.839],
	[2570546.938,5648022.633]])
proj = pyproj.Transformer.from_crs(prj_parameters, 4326, always_xy=True)
fx, fy = proj.transform(coordinates[:,0],coordinates[:,1])
result = np.dstack([fy, fx])[0]
result = result.tolist()
print("\n".join(",".join(str(el) for el in row) for row in result))

Looking forward to a response.
Daan.
Sidenote: I load the actual parameters instead of using the EPSG code lookup, because that way I do not have to maintain the EPSG parameters. If a systems is updated, the user just loads these new parameters and I do not have to recompile with a new version of pyproj/EPSG list.
For example, in Maylasia, they use new versions of their coordinate system, but the ones that you find online are all old versions.
Environment Information
pyproj info:
    pyproj: 3.6.1
      PROJ: 9.3.0
  data dir: c:\users\daant.reduct\appdata\local\programs\python\python39\lib\site-packages\pyproj\proj_dir\share\proj
user_data_dir: C:\Users\DaanT.REDUCT\AppData\Local/proj
PROJ DATA (recommended version): 1.15
PROJ Database: 1.2
EPSG Database: v10.094 [2023-08-08]
ESRI Database: ArcGIS Pro 3.1 [2023-19-01]
IGNF Database: 3.1.0 [2019-05-24]

System:
    python: 3.9.5 (tags/v3.9.5:0a7dcbd, May  3 2021, 17:27:52) [MSC v.1928 64 bit (AMD64)]
executable: c:\users\daant.reduct\appdata\local\programs\python\python39\python.exe
   machine: Windows-10-10.0.26100-SP0

Python deps:
   certifi: 2021.5.30
    Cython: None
setuptools: 56.0.0
       pip: 24.2

Installation method
I use pyinstaller to create an exe, runing that to verify the program.
Conda environment information (if you installed with conda):
No Conda

epsg dot io is not an official reference.
I suggest using https://spatialreference.org/ as a better reference, because it is based on PROJ.
That CRS https://spatialreference.org/ref/epsg/31466/ in particular is using a grid file. It is available in PROJ-data, and used automatically when it is found.
You should enable the network functionality via https://pyproj4.github.io/pyproj/stable/api/network.html , PROJ_NETWORK, or install the grid files locally.

Thank you for your reply, noted that https://spatialreference.org/ is preferred. I use the epsg dot io website because it's more visually pleasing and and also allows for manual point conversion. A good way to verify that the CRS found is indeed the correct one. When I receive coordinates, I never get a clear answer about the coordinate system and when I ask for the ESPG code, they always look at me like I'm speaking some foreign language.
Network functionality can not be used as it must work offline as well.
Besides all the above, shouldn't this package be able to work even is their is an unexpected extra parameter in the PROJCS string?
I'm now going to handle it manually.
Daan.

Network functionality can not be used as it must work offline as well.

You can install the grid files in your computer

Besides all the above, shouldn't this package be able to work even if their is an unexpected extra parameter in the PROJCS string? I'm now going to handle it manually.

The message says (File not found or invalid). Using that "extension" is forcing the usage of the file, that is not found. You can either install it or remove the extension.
Even better you can use just the id EPSG:31466, and PROJ will automatically try to use the file if it is installed.


Could not find a declaration file for module '@vueuse/sound'

I have the following compilation error when running npm run build in a fresh Vue app:
src/App.vue:21:26 - error TS7016: Could not find a declaration file for module '@vueuse/sound'. <EMAIL_ADDRESS>implicitly has an 'any' type.
  There are types at<EMAIL_ADDRESS>but this result could not be resolved when respecting package.json "exports". The '@vueuse/sound' library may need to update its package.json or typings.

21 import { useSound } from '@vueuse/sound';
                            ~~~~~~~~~~~~~~~

Found 1 error in src/App.vue:21

ERROR: "type-check" exited with 2.

The error goes away if I manually delete the exports key in package.json:
  "exports": {
    ".": {
      "require": "./dist/index.cjs",
      "import": "./dist/index.mjs"
    },
    "./nuxt": {
      "require": "./dist/nuxt.cjs",
      "import": "./dist/nuxt.mjs"
    }
  },

Do you have any clue to solve it?

In the meantime we waiting for the PR to be merged, this may be a workaround?
import { useSound } from "node_modules/@vueuse/sound";

If it works for you it's a valid workaround. Otherwise I published a forked build:
https://www.npmjs.com/package/@raffaelesgarro/vue-use-sound

Oops, mine is not working and thanks for your build!


The clustername is already part of the basedomain

Towards https://github.com/giantswarm/giantswarm/issues/26001

This PR:

adds/changes/removes etc

Testing
Description on how default-apps-azure can be tested.

[ ] fresh install works

[ ] AWS
[ ] Azure
[ ] KVM

[ ] upgrade from previous version works

[ ] AWS
[ ] Azure
[ ] KVM

Other testing
Description of features to additionally test for default-apps-azure installations.

[ ] check reconciliation of existing resources after upgrading
[ ] X still works after upgrade
[ ] Y is installed correctly

Checklist

[ ] Update changelog in CHANGELOG.md.
[ ] Make sure values.yaml and values.schema.json are valid.

Trigger e2e tests

/run cluster-test-suites

@bavarianbidi i will double check this becuase for WC you actually need the clustername section ( it was required during testing that's why i added it in the first place ) but it seems for MC is not ... which of course is a bit of a conflict and we should resolve it so cilium works on both
i will look at it after i finish deploying cuckoo

if you want me i can take a look as well

Sure if you have time :+1:
but how does it work for other Providers like CAPA ?
if we can't make it consistent i guess we'll need to make it work for WC by default and override in mc-bootstrap for MCs when the default apps configmap is created , we already set the values when we install the cni https://github.com/giantswarm/mc-bootstrap/pull/467/files#diff-6d248729ba9826f43d395533df7b87fd7054a688fafea13608d2e435cf973e35R51 so we could make that persistent for MC

we are reverting the cilium proxy change, so we don't need this anymore


connectInfiniteHits: Fix fetch the first page

Because first page index is 0

The state that is here is the state we "Expose". When doing queries to algolia we then do page - 1 because algolia is 0 based.
But inside the state, state.page = 1 means we will query page 0 on Algolia.
Could you walk us through your usecase/struggle with this maybe? How did you encounter a bug, how can we reproduce it? Thanks

I found this behavior playing in windtoday.co with facets.
Currently is monkey patched on production, but basically in the results:

I see the page 1.
When I click in load more it injects the results of the page 1 again.

@vvo I revert my production build to make more easy reproduce the issue.
Enter in this url.
Now check the title of the results and click in Load More. You can find duplicate titles.

Hmm I need to investigate more because after this change I still see duplicate fetch pages 🤔

I updated the PR, for me have more sense and resolve the problem.
What do you think, @vvo @bobylito ?

nope, looks weird. xD

Currently just resolved adding
searchParameters={{hitsPerPage: 15}}

without modify the code.

@Kikobeats Do you think you could either:

write a unit test
create a simple example

Using this repository? So that we reduce the test case to the only parts that are relevant?

@Kikobeats I fail at seeing if we have a real bug here or what? Having a simple example could help, otherwise we'll close this untill someone find a simple example to reproduce it

Sorry currently I fixed following the searchParameter setup, I need to investigate more for open a new issue

Thanks @Kikobeats for taking the time!


Add --network-dataplane to AKS cluster create

The --network-dataplane flag is used to enable Cilium dataplane.
This deprecates the existing --enable-cilium-dataplane flag, but for now keep both since the docs still refer to the old flag

This checklist is used to make sure that common guidelines for a pull request are followed.

For new extensions:
- [ ] My extension description/summary conforms to the Extension Summary Guidelines.
About Extension Publish
There is a pipeline to automatically build, upload and publish extension wheels.
Once your pull request is merged into main branch, a new pull request will be created to update src/index.json automatically.
You only need to update the version information in file setup.py and historical information in file HISTORY.rst in your PR but do not modify src/index.json.

aks

keeping as draft until #6062 merges (those commits included in this branch)

rebased to resolve merge conflict


hie-wrapper (via coc.nvim) continually crashes

I'm using coc.nvim as my LSP client (within neovim) -- it works with other languages. I have removed Setup.hs, installed hspec-discover globally to fix problems with HIE, but now I'm at the stage where the server just continually dies and gets restarted.
I have tried a basic hie.yaml in the project root (the project is gfarrell/random-puzzles-hs):
cradle:
  stack:

But this also doesn't work.
> stack ide packages --cabal-files --stdout
/Users/gideon/projects/challenges/random-puzzles/random-puzzles.cabal

When I look at the output of hie-wrapper (via CocList > output > languageserver.haskell) I get the following (repeated ad nauseam, so I just took a selection):
hie.log
I can't work out why it's continually restarted. I tried hie-wrapper --debug in the project root and got the following output which seems to imply that nothing is wrong with the project:
hie-debug.log

I think you are missing the --lsp flag for hie.

Ah finally, thank you. That worked!
Some commentary about this:

I was previously using the config in the Coc Wiki but this wasn't working for me because of the following other issues:
a. stack new creates Setup.hs which seems to break hie.
b. I'm using hspec for tests, and hspec-discover has to be globally installed, but this error wasn't showing for me. I found it after solving some other issues.
c. I kept seeing cabal-install is not installed, even though I'm using stack not cabal (although this is no-longer happening to me even if I remove hie.yaml).
d. Maybe other issues?
I found this error super hard to debug.

stack new creates Setup.hs which seems to break hie

No, it just cant be loaded, HIE should continue to work.

I'm using hspec for tests, and hspec-discover has to be globally installed,

Yeah, for now it gotta be like that. Until we have abstracted build-tools and have a way to query the path for each tool.

I found this error super hard to debug.

Reasonable, we should add a message to the beginning of the output in HieMain.hs


Add proxy, keep_alive, file_detector, options to SauceOptions constructor

Some background: The Python Remote WebDriver implementation documentation can be found here:
https://selenium.dev/selenium/docs/api/py/webdriver_remote/selenium.webdriver.remote.webdriver.html#module-selenium.webdriver.remote.webdriver
Based on this document and the philosophy that users of the Sauce Bindings should be able to pass in remote webdriver options for Sauce Labs instances similar to a standard Selenium instance, the constructor values should be handled appropriately.
In the case of proxy, file_detector and options, these options may not be useful or even possible to use with Sauce Labs in a meaningful way. If they can be used, these options should be implemented in the SauceSession class as needed.

FYI I created #136.  Just to make sure everyone was aware of the proxy issue.  If this is a duplicate (didn't see anything) you can close comment. I assume you may have run into this before.

@joshmgrant so I think this one is accomplished, right?


Use log level WARNING/ERROR where needed for BNG

BNG output is now parsed for the strings 'ERROR:' and 'WARNING:'.
When encountered, the PySB log level is upgraded to ERROR/WARNING
for all future log output during that execute() call.
This applies to the BngFileInterface only. BngConsole already has
error and warning detection.
Fixes: #362

Coverage increased (+0.005%) to 75.559% when pulling 61547602b1f4e157f28edcbac94af1f169e8da63 on alubbock:bng_error_extraction into 50f1d812526679d9a83209a78a0bbdc2d735f122 on pysb:master.

Note that the iteration over p.stdout consumes the data from the stream, so p_out is always empty and doesn't contain any ERROR: ... text from BNG. This needs a little thinking on what content actually belongs in logging vs. the exception message, anyway. I can only find one use of logger.error in all of pysb, in the cupsoda simulator, and that case also raises the same text in an exception right away. Is ERROR-level logging really useful for us?
Proposal for consideration: We keep using logger.debug for the BNG output as before. If ERROR: appears then that line and the ones after it would be added to a list. If that list is non-empty or the returncode is non-zero, those error lines and p_err get joined with \n and used as the exception message. I'm not sure if WARNING: lines from BNG need any special treatment. If we could pull out individual messages I'd say warnings.warn them, but I am guessing that would be fragile due to the way BNG formats and line-wraps them.

Is ERROR-level logging really useful for us?

It might be, for recoverable errors, but those cases seem rare. One hypothetical scenario is a parallel simulator running a large number of simulations and one of them fails - you probably don't want to generate an Exception and lose all the other results, but you definitely want to know about the failure.

Proposal for consideration...

Your proposal is close to the behaviour in the PR, except that logging is used rather than an Exception. All remaining lines after an error or warning are logged as errors or warnings. It should be easy enough to implement the error processing as you suggest (it seems a good approach).
I've spoken with @lh64 and BNG hasn't fully standardized its format for warnings, so parsing would be tricky to do reliably. I'll make this PR focus on errors only and we can tackle warnings in a future PR.


Change function returns from BValue[] to BValue

Description:
Currently the function return types and the return values are arrays.
Since multi-return is not supported now, we should be able to change the return type/value accordingly.

In JBallerina runtime, function returns are implemented as stated in this issue. Hence removing the label.

Old issue, No longer applies for Swan Lake.


Before after date filters

Add before_date and after_date filters to filter topics by date in 'yyyy-mm-dd' format.

https://github.com/discourse/discourse-url-filters/pull/1 should be merged in first


Fleet enhancements.

Synchronisation log output for git jobs

Dashboard should show the cluster tab

Workspace > Cluster

Assign cluster > Dialog fix the padding.

Representative git repositories

rancher/dashboard#5407 - UX improvements for ResourceSummary counters in git repo details view

Bundle type icon

Resource view - after clicking on Fleet resource

Deployment does not have minimum availability. - Shows info in Deployments, in fleet this is yellow

Annotation - Can’t see if this is managed by fleet or not.

Backend error message handling

 "message": "ErrApplied(1) [Bundle schf-single-cluster-helm: another operation (install/upgrade/rollback) is in progress]",

 "message": "another operation (install/upgrade/rollback) is in progress",

Diagnostic tools:

Closing as stale


[Unix / DirAccess] Fix removing directory symlinks with remove, ensure erase_contents_recursive is not following directory symlinks.

Fix removing directory symlinks with remove.
Ensure erase_contents_recursive is not following directory symlinks.

Thanks!


Rewrite to use Discord webhooks instead of Slack-compatible Discord webhooks

As said in the title, currently we use the /slack endpoint since when I created this library this is what I was most knowledgable with. We should now migrate this to use Discord webhook formatting.

What would be the best way to start this ?
I assume we would use
https://discordjs.guide/popular-topics/embeds.html#embed-preview

Not necessarily, the Discord docs are sufficient for this.

https://discordapp.com/developers/docs/resources/webhook#create-webhook, this one?

https://discordapp.com/developers/docs/resources/channel#embed-object this will be the most useful.

Does it make sense to rewrite the library if can use Discord.js and its WebhookClient.
WebhookClient also supports working with the inner Discord.js MessageEmbed class.
Yes, the library will be less in size, but it seems to me that this is not a particularly weighty argument.

I think it makes sense to rewrite it, yes.
This library serves as an independent way to work with webhooks without discord.js, it gets used and has thousands of downloads on NPM.
We should continue development of this library irrelevant of the external situation with webhook libraries on NPM.


Fuzz - Timeout in FuzzUnmarshalPEMToPublicKey

Description
The  FuzzUnmarshalPEMToPublicKey exceeds the time limit in oss-fuzz
clusterfuzz-testcase-minimized-FuzzUnmarshalPEMToPublicKey-6640464978116608.log

The root cause of this issue is in Go Standard library https://github.com/golang/go/issues/50116

Closing as outdated


multirun: propagate the entire runfiles of dependencies

runfiles can include more than just transitive_files, such as empty_filenames.  The best way to ensure all parts of runfiles are propagated is to use merge so Bazel takes care of every property.
This fixes commands that call out to py_binary, for instance, which relies on empty_filenames.

This stuff is so poorly documented... Thanks for fixing it! So with this fix it works for some use case that you have?
Can you sign the CLA please? https://github.com/atlassian/bazel-tools#contributing

Yeah, this fixes a case where command points to a py_binary, which uses the empty_filenames list to create __init__.py files (https://docs.bazel.build/versions/master/be/python.html#py_binary.legacy_create_init).  If those runfiles aren't propagated, the command won't work right.
CLA signed!

thank you!


No download progress while downloading

I have tried to get the download progress but nothing works. Instead of getting real-time responses, they block and send the progress once done.
I tried with:

DoChannel
Do

Code is the examples under each method.
Download link: http://ipv4.download.thinkbroadband.com/5MB.zip
Edit: I  tested again with the example on the readme and it works perfectly. I'll be reviewing all my code.

From further testing, I seem to have found my problem.
Closing


5.1 AudioStreams not playing all channels

Godot version:
b0eca5828
OS/device including version:
Windows/Linux
Issue description:
Trying to play a 5.1 ogg file in godot causes it to only play a few channels, this results in the audio playback not being what it should be.
Steps to reproduce:
Use a 5.1 ogg audio file and try to play it through AudioStreamPlayer
I do not have any 5.1 vorbis audio file that I can share on me, so if anyone could provide it for testing that would be great.

I confirm, randomly get audio from single channel on my headphones.

@EIREXE @IllusiveS Please upload a minimal reproduction project to make this easier to troubleshoot.
Also, note that there's a proposal to address this for stereo sounds: https://github.com/godotengine/godot-proposals/issues/3384

Hello everyone,
Sorry for resurrecting an old topic, but I also have questions regarding spatial sound in Godot.
I understood that unfortunately only mono and stereo sounds are usable in 4.2.1?
But then what are the three 'Mix Target' options for the 'AudioStreamPlayer' node for? No matter which one I choose between 'Stereo', 'Surround', or 'Center', the loaded file is played the same way: I hear channel 0 in my left ear and channel 1 in my right ear. The other channels are ignored.
I also noticed that while the 'AudioStreamPlayer' node still allows using the audio file by only using 2 channels out of 8, the 'VideoStreamPlayer' node allows using the video but none of the 8 audio channels are played. The following error appears in the debugger in the editor when I assign a video with 8 audio channels:
E 0:00:02:0301 setup: Condition "p_channels != 1 && p_channels != 2 && p_channels != 4 && p_channels != 6" is true. Returning: ERR_INVALID_PARAMETER
<Source C++> servers/audio/audio_rb_resampler.cpp:162 @ setup()

And the following error multiple times when the video is played:
E 0:00:04:0264 main.gd:26 @ _playButton_pressed(): Condition "p_frames >= rb_len" is true.
<Source C++> ./servers/audio/audio_rb_resampler.h:119 @ write()
<Call Stack>main.gd:26 @ _playButton_pressed()

The audio file is in ogg format, created from Audacity.
The channel order seems to be as follows: c0 = front left, c1 = center forward, c2 = front right, c3 = back left, c4 = back right, c5 = left side, c6 = right side, c7 = low frequency.
Each channel is correctly played in VLC, but in Godot I always hear channel 1 in my right ear instead of in the center. The other channels (from c2 to c7) are ignored.
The video file is in ogv format created from ffmpeg from images and the previous ogg audio file.
Attached are the audio and video files as well as a minimal Godot Engine 4.2.1 project.
MRP_Surround.zip


[WIP] Modifying ChordKeybinding to support multiple chords

Hi! I'm very interested in getting support for keychords of more than two keys (see #6966), so here's a PR to kick off my interest.
I think a see a general strategy to get there, but before I get too deep, I wanted to get a quick review on my approach.
In general, it looks like many parts of the code base are built on the concept of a "firstPart" and a "chordPart" for key chords. I think the first step is modifying all of these to support an arbitrary number of parts. Once that is done, the logic needs to be modified slightly to iteratively run through each part rather than stop at the first two.
As a start to support key chords of longer than two parts,
modifying the internal structure of ChordKeybinding to not specifically
call out two parts.
@alexandrudima you are the assignee of the ticket mentioned. Would you mind giving me some feedback on this approach?
Thank you!

 Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.:x: toumorokoshi sign nowYou have signed the CLA already but the status is still pending? Let us recheck it.

@alexandrudima if you have a chance can you take a look at this PR? I've gone as far as I feel comfortable at this point, as I've seen giant prs become harder and harder to merge.

@toumorokoshi, I agree this PR has grown large enough.
I've only found a couple of bugs where some map invocations were not properly bound to this in WindowsNativeResolvedKeybinding.getParts and WindowsNativeResolvedKeybinding.getDispatchParts, but other than that this was very high quality, and I thank you for that!
I've also tweaked a bit the label calls and having done so, I plan to further refactor those classes and raise some methods to their abstract parent class.
I've left TODO@chords in two places:

where user bindings are parsed (i.e. allow users to write keybindings with N chords in their keybindings.json)
where bindings are converted for dispatching (i.e. allow dispatching of N chords)

The first one is rather easy to tackle, the second one is a bit more work, as the KeybindingResolver needs to change a bit.

Awesome, thanks so much! Darn, I thought I caught all the bound errors... I'll be more careful.
Thanks for the TODOs! I'll take a look at those next.


Investigate getting the assembly strongly-named

Please refer to tonerdo/pose#52

From what I can see this is not needed from .NET 5 and onwards.

We're not pursuing this for now. If it becomes relevant again, we'll look into it.


Ship built-in profiles in a well-known module path

We'd like to ship a couple profiles (e.g. Style, Minimal, Full) in a well-known path (e.g. $PSModulePath\PSScriptAnalzyer\Profiles\Minimal.PssaProfile.psd1). That way we have built-in examples, and we can also modify -Profile to pick up profiles form that location (e.g. Invoke-ScriptAnalyzer foo.ps1 -Profile Minimal).

Create Profiles based on the best practices category from here:
https://github.com/PowerShell/PSScriptAnalyzer/blob/development/PowerShellBestPractices.md
Cmdlet Design Rules
Script Functions
Scripting Style
Script Security
DSC Related Rules

Is it too late to use something other than Profile for this?  I'd much
prefer Configuration, since it would be inline with remoting
(*-SessionConfiguration) and Profile has a different meaning in PowerShell
already.
--
*Kirk Munro *
Poshoholic, Microsoft MVP
Blog http://poshoholic.com/ | Twitter http://twitter.com/poshoholic |
LinkedIn http://ca.linkedin.com/in/kirkmunro | GitHub
http://github.com/KirkMunro | Facebook
http://www.facebook.com/#!/kirk.munro
Need a PowerShell SME for a project at work? Contact me
http://poshoholic.com/contact-me/!
On Mon, Nov 23, 2015 at 2:19 PM, Raghu Shantha [MSFT] <
<EMAIL_ADDRESS>wrote:

Create Profiles based on the best practices category from here:
https://github.com/PowerShell/PSScriptAnalyzer/blob/development/PowerShellBestPractices.md
Cmdlet Design Rules
Script Functions
Scripting Style
Script Security
DSC Related Rules
—
Reply to this email directly or view it on GitHub
https://github.com/PowerShell/PSScriptAnalyzer/issues/354#issuecomment-159017639
.

Kirk+1. I filed an issue about overloading this already very overloaded term: https://github.com/PowerShell/PSScriptAnalyzer/issues/350
BTW, I love the idea of canned profiles, but I wouldn't call them profiles.

https://github.com/PowerShell/PSScriptAnalyzer/pull/369


Feature request - color indication of priority (or some other custom rule)

I am sure it might not be the most elegant solution everyone else is seeking when they use pepper-theme, but the visual clue you can get from glimpse of the issues list when they do not look all the same is still very useful, and is available in many themes out there.
I am not sure why I can not compass compile the sass source cloned from github (maybe some other bug all together), but it would be nice to offer the possibility of color coding the list of issues according to some rule (usually issue priority)
It could be still done in a discreet matter, like an icon or a little color coded square box, ... or it could be done more loudly (like I have seen before in some other themes) such as painting the entire issue description line with a background color (not mandatory, but I have seen white for usual/normal, blue or green for low, pink/light red for high...) and/or in combination of changing the font style (such as red when urgent, bold and red when immediate action required)
The thing is, right now you got to really read what is going on to understand and react.

The big problem with doing any styling based on issue priority or status is the fact that they can be customized. New ones can be added, and we have no way of knowing what priority or status is more or less important.
Do you know of any themes that already do this well?

Okay, I lied, Turns out priorities can be styled. I have pushed a version with a red'ish gradient. Not sure I like it, though, it does seem a bit invasive.
Check it out and let me know you how you like it.

Perfect and elegant, really not invasive... ;)
Thanx


Player bug with Lollipop (and Kitkat?)

There's a bug with starting and stopping the player (and mediaplayer in general?) that has appeared with Lollipop and Kitkat.   Please try the example aia file here.  Both Taifun and I have verified this broken behavior.
https://groups.google.com/forum/#!topic/mitappinventortest/eQqqvwSdc1Y
It looks like the bug and the solution are discussed here:
http://stackoverflow.com/questions/21790824/mediaplayer-should-have-subtitle-controller-already-set-kitkat

What's the status of this bug?
I've tested the example app in the forum, on a One Plus One running android 5.0.2 and it works fine.

All I know is what's in the issue report on the forum.
Is it possible that this was fixed with Android 5.1?
Can someone check?
== Hal Abelson
<EMAIL_ADDRESS>Prof. of Comp. Sci. and Eng.
MIT Dept. of Elec. Eng. and Comp. Sci.
MIT Media Lab, Second Class Faculty
On Fri, May 29, 2015 at 10:25 AM, Mouhamadou Oumar Sall <
<EMAIL_ADDRESS>wrote:

What's the status of this bug?
I've tested the example app in the forum, on a One Plus One running
android 5.0.2 and it works fine.
—
Reply to this email directly or view it on GitHub
https://github.com/mit-cml/appinventor-sources/issues/213#issuecomment-106827179
.

This works in 5.1.1.   Closing the issue.


Static site with Azure authentication

Describe the feature
Hi, I am building a static Nuxt 3 site with Azure authentication feature.
I am using sidebase/nuxt-auth 0.6.0-beta.2, and implemented following this document https://sidebase.io/nuxt-auth/recipes/azure-ad-example
It runs ok with npm run dev, but when I generate static site with npm run generate then npm run start, it show errors

I know the server do not work with static site, how can I implement in this case ?
Additional information
No response

Sadly, using authjs, does not work with static deplopyments. The only static solution we currently support is a credentials based one. Any OAuth solution, will not work with a static deployment.


Allow multipart PUT

Haven't looked too much into this, but it looks like you can POST multipart form data, but not PUT it.
Can we just change the Replacement class to accept AbstractContent instead of Content and the put method in Resty to accept AbstractContent instead of Content?

@beders , any feedback? Also, would you mind doing a release for 0.3.3 as we want to rely on the new exception handling (don't throw exceptions on failed responses). Thanks!


Preserve backslash in raw string literal

Summary

Fix #5941
Test Plan

Existing tests

Thanks for implementing Raw-strings. Something I entirely overlooked.

The formatter ecosystem checks are currently failing in CI. You can run the script locally (scripts/formatter_progress.sh). You can also merge main where to get the fix from https://github.com/astral-sh/ruff/pull/6187 that will print the ecosystem check results in CI also.

@MichaReiser @konstin Thanks for reviewing this PR :)

Fixed the end-of-string unescaped quote in https://github.com/astral-sh/ruff/pull/6202


@Royce551 Want to help with format specs for SyncedLyrics-.lrc_v2?

https://github.com/marz1877/SyncedLyrics-.lrc_v2
@Royce551

This seems interesting, I'm not interested in helping at this time, however, you are more than welcome to fork my code if you need a WYSIWYG editor.


Windows Commands/robocopy: wildcard MD format

Description:
As discussed in issue ticket #3707 (Default <File> value), the File parameter description contains a backslash as part of the default file wildcard parameter, but this notation is erroneous and causes an error message when tested with the robocopy command.
This unexpected backslash is caused by incorrect use of the escape character backslash ( \ ) by placing 2 more backslashes than needed in the affected wildcard *.* in the description.
Thanks to @tdillon for reporting this issue and confirming the solution.
Changes proposed:

remove 2 surplus backslashes from the wildcard representation
reduce the total width of the table accordingly, 2 spaces / dashes

issue ticket closure or reference:
Closes #3707

#sign-off

CC: @coreyp-at-msft , @lizap


Update has_inputs_and_outputs to check V5 transactions

Motivation

For Network Update 5, the consensus checks will have to consider the new V5 transaction and Orchard transactions. A few things needs to be changed to support this, but this PR focuses on the transaction::check::has_inputs_and_outputs() function.
Solution

The solution implemented follows the solution outlined in #1980.
To test the solution, two test vectors were written to find transactions in the mainnet and check that they fail the check as expected. I'm not sure if I did the right thing, or if the refactor to support the test vectors was optimal, so feedback is more than welcome!
I'm also not sure how to generate an orchard::Action in order to try to test the success scenario when there's at least one action.
The code in this pull request has:

[x] Documentation Comments
[x] Unit Tests and Property Tests

Review

@teor2345 outlined the solution, and @oxarbitrage helped with some test planning.
Related Issues

Part of #1980.
Follow Up Work

[ ] Proptests?
[ ] Test if check::has_inputs_and_outputs with V4 transactions?

Related Issues
Part of #1980.

Hey @mpguerra this PR is only part of #1980


Add scope to redirects

~alternative to #831 #832~

inject Scope everywhere (Entity, Resolver) using factories
always a scope parameter in api

What would you say, is this a breaking change or not?

no, the default behaviour is (as it was before) to have no scope support.


Remove non-existing scheduling-disabled label from ReservedMetadata allow list

The label doesn't exist anymore. No need to allow it.

/lgtm
/approve

/retest

/retest

/test e2e-multiple-runs

/retest

/test e2e-multiple-runs


Update app to be compatible with https-proxy-agent 7.0.0

Description
Currently, the https-proxy-agent package is on v5.0.1. Dependabot opened a PR (https://github.com/slackapi/slack-github-action/pull/212) to bump this up two major versions to 7.0.0 - however, this version bump fails the HTTP Proxy unit test that was added to the Slack Send unit tests. It would be great to update this package to the most recent version for security purposes and also adjust the code's use of the package so that it's compatible with the latest version, 7.0.0, and the unit tests pass.
What type of issue is this? (place an x in one of the [ ])

[ ] bug
[x] enhancement (feature request) - dependency
[ ] question
[ ] documentation related
[ ] example code related
[ ] testing related
[ ] discussion

Requirements (place an x in each of the [ ])

[x] I've read and understood the Contributing guidelines and have done my best effort to follow them.
[x] I've read and agree to the Code of Conduct.
[x] I've searched for any related issues and avoided creating a duplicate issue.

Thanks for tracking this, and thank you @dependabot! Closing with the fix in #241 🚀


Env var / dynamic way to determine the preview hidden state within a transformer

Checklist

[X] I have read through the manual page (man fzf)
[X] I have searched through the existing issues
[X] For bug reports, I have checked if the bug is reproducible in the latest version of fzf

Output of fzf --version
0.56.2
OS

[X] Linux
[ ] macOS
[ ] Windows
[ ] Etc.

Shell

[ ] bash
[ ] zsh
[ ] fish

Problem / Steps to reproduce
Context: https://github.com/junegunn/fzf/issues/3817#issuecomment-2134248352.
Consider the example (from the above link):
TRANSFORMER='
  echo -n change-preview-window:
  if ((100 * FZF_COLUMNS / FZF_LINES >= 150)) && ((FZF_COLUMNS >= 120)); then
    echo "right,50%,border-left"
  elif ((FZF_LINES >= 40)); then
    echo "up,30%,border-bottom"
  else
    echo "hidden"
  fi
'

fzf --bind "start:transform($TRANSFORMER),resize:transform($TRANSFORMER)" --preview 'cat {}' --preview-window=hidden

There are a couple of issues with this:

When running the above the transfomer doesn't take into account the preview hidden state, due to the transform running on start, the previewer opens in a visible state even though we specify hidden
Hiding the previewer with a keybind and resizing the terminal causes the previewer to unhide

I tried the below  transformer (using FZF_PREVIEW_COLUMNS) but the previewer opens hidden and also hides itself when triggering resize:
TRANSFORMER='
  echo -n change-preview-window:
  if ((FZF_PREVIEW_COLUMNS == 0)) then
      echo "hidden"
  elif ((100 * FZF_COLUMNS / FZF_LINES >= 150)) && ((FZF_COLUMNS >= 120)); then
    echo "right,50%,border-left"
  elif ((FZF_LINES >= 40)); then
    echo "up,30%,border-bottom"
  else
    echo "hidden"
  fi
'

Am I missing something? Is there an env var I can use to determine if the previewer is hidden?

No, there currently isn't a way. FZF_PREVIEW_* env vars are only exported to preview processes.

No, there currently isn't a way. FZF_PREVIEW_* env vars are only exported to preview processes.

Would you consider exporting these to the transform process? Could there be any downside?

Will do. No downsides. The overhead for adding environment variables to other processes is going to be negligible.

Ty @junegunn!


Adding modify tab, renaming old tabs

Editing existing symbol feature functionality using the selection tool in pro, and fixed issue #71

I got this warning on startup:
System.Windows.Data Error: 40 : BindingExpression path error: 'Name' property not found on 'object' ''SelectedFeature' (HashCode=61628039)'. BindingExpression:Path=Name; DataItem='SelectedFeature' (HashCode=61628039); target element is 'Grid' (Name=''); target property is 'ToolTip' (type 'Object')
System.Windows.Data Error: 40 : BindingExpression path error: 'PreviewImage' property not found on 'object' ''SelectedFeature' (HashCode=61628039)'. BindingExpression:Path=PreviewImage; DataItem='SelectedFeature' (HashCode=61628039); target element is 'Image' (Name=''); target property is 'Source' (type 'ImageSource')

I don't know if it is related to this PR, but it seems to be taking a long time to add features to the map now if I set the "Content" attribute - can you see if you can repro this odd behavior?

Finished reviewing - looks good - my last comments/suggestions pertain to the new Modify tab - to see if it would be readily/easily possible to change any of these items with PR before end of sprint (if not, I can just write issues for).
1. Can we add the select tool to this tab? If not, can we add text to tell the user to use the select tool to select a symbol (I think for now users might be confused about how to "pick" a symbol)

2. Can we auto-select the first selection/list-item so the Modify UI shows this symbol without having to then select the list item
3. Can we add more description to the picked symbols (ex. Layer : Symbol Set(Name) : Entity(Name) ) to make this name more user-friendly

I doubt we can do all of these before the end of the sprint, since it ends today and you've mentioned some other items to look at.

Should be possible, but will require a bit of work.
Again, should be possible.
Possible, but we'll have to see how it impacts performance as I'll have to query the data in each selected feature layer to get that data.

No biggie - for now (as part of PR), can you at least add static text to Modify Tab to let the user know to "use the select tool to select a feature to modify (or something along these lines)" - I'll issues for other enhancements

Updated the code with the issues discussed above (Besides those 3 items - which I'll start looking at now).  I tested the Context attribute (and the other ones) but never saw a slow down of editing the database.  Maybe something else going on?

@csmoore If I can change it to what you suggested above:

Can we add more description to the picked symbols (ex. Layer : Symbol Set(Name) : Entity(Name) ) to make this name more user-friendly

Then the user would not know which feature is which, since their is no differentiation between different features if they're the same symbolset.  Is that okay?  Or should I still include Object Id in there?

Including the OID at the end sounds fine - mainly just wanted something human readable included to give a user a better hint at what they had picked

@tlauver - sorry I haven't merged btw - I had been waiting to get a chance to writeup the issues above before I merged/closed

Alright, those three issues are now fixed.  Added a new selection button (that mimics the one in Pro), auto selected first item when selection is done, and updated the description of each item.  Also added that if a user clicks on a result item, the feature will flash on the map - hopefully helping to locate it.

Cool (good idea on the flash) - Many thanks - I test out first thing tomorrow

Modify additions look/test good. Thanks for adding that & updated doc also.


[SPARK-37674][SQL] Reduce the output partition of output stage to avoid producing small files.

What changes were proposed in this pull request?
Reduce the output partition of output stage to avoid producing small files.
Why are the changes needed?
The partition size of the finalStage with DataWritingCommand or V2TableWriteExec  may use the ADVISORY_PARTITION_SIZE_IN_BYTES which is smaller one, and  may produce some small files, it is bad for production.
Sometime, we may adjust ADVISORY_PARTITION_SIZE_IN_BYTES to a big one to avoid above , but it is NOT a good idea, it may take effect other Jobs or stages to  coalesce small shuffle partitions or split skewed shuffle partition.
So we should introduce a new partition size instead of  ADVISORY_PARTITION_SIZE_IN_BYTES  for  the finalStage with DataWritingCommand or V2TableWriteExec  to avoid small files.
Does this PR introduce any user-facing change?
NO
How was this patch tested?
Added unittests.

Can one of the admins verify this patch?

cc @yaooqinn @ulysses-you

I see the requirement but there are some potential issue if we only use a new config for writing's final stage.

if the final stage is heavy it will cause regression if we make partition size big, e.g. the final stage is join even multi-join
the input shuffle size is not equal to the output size. if the plan of final stage changes the data size, this config is less meaning
not all query contains shuffle, then the semantics of this config is broken since the config is not used
it's not enough for dynamic partition writing that just increase the partition size. we should cluster the same partition value in several partitions as far as possible
and this config should also affect the rebalance

I think it's a good idea to add a RebalancePartitions node for all writing command as  @wangyum working on SPARK-31264. And then we can consider adding a special partition size config for the added shuffle which is from  RebalancePartitions.

@ulysses-you thank you for your review，i got your point. This PR  just gives users more choice to  avoid producing small files, the original logic is kept by default.

OK let's make a call here. I think it's not a good idea to add a new config for the final stage to tune the advisory size. The final stage may not be a simple table writing, it can contain other operators to do heavy computing. We should not reduce its parallelism which can slow down the computing or even cause OOM. That's why I think adding an extra shuffle is actually more robust: we do not reduce the parallelism of computing, but only reduce the number of output files.


Add Java 18 EA to build workflow

I think now we can start testing with Java 18:
https://adoptium.net/nightly.html?variant=openjdk18&jvmVariant=hotspot

Go for it!


Views give errors when using proper namespaces according to the XSD files

OpenUI5 version:
1.54.6
For example, this view:
https://openui5.hana.ondemand.com/#/sample/sap.tnt.sample.ToolPage/code
works. However, all the aggregations layoutData inside the Buttons in the toolHeader, should have the namespace core to be a valid XML file according to the XSD schema. However, if you change them to
<core:layoutData>
...
</core:layoutData>

it gives the following error:
Uncaught (in promise) Error: Cannot add direct child without default aggregation defined for control sap.m.Button
Because there is a check in XMLTemplateProcessor about the aggregations having the same namespace as the child nodes. I can understand that you relax the validation rules in order to avoid writing the namespace in the child nodes. However, IMHO, if you have a valid XML document that validates against the XSD schema because it has the proper namespace for the aggregation, it should work too.

I disagree.
It was no relaxation of the validation, but it was a conscious decision that the aggregation nodes must have the same namespace as the containing control, not the namespace of the class that defines the aggregation.
P'lease note that the schemas are not officially supported. The runtime and documentation describe the supported functionality.


Fix QLoRA recipe, add CI

Context

As reported by https://github.com/pytorch/torchtune/issues/570 and by @ebsmothers, QLoRA recently broke due to torchao nightly update. In this PR, I pin torchao-nightly to the last known working version which contains all features we need, re-enable the unittests, and add a recipe test for QLoRA.

Changelog

See above

Test plan

Unit:  pytest tests/recipes/test_lora_finetune_single_device.py -v -k test_loss
Fresh install, verify expected ao nightly. Run QLoRA: tune lora_finetune_single_device --config recipes/configs/qlora_finetune_single_device.yaml

Follow up

We need to establish a process for regularly upgrading deps for libraries which we use nightlies for. The simplest thing to do is what I've done now - pin the version and bump it whenever a new feature/bugfix we need is released. Though if there's a large gap in time between these, the upgrade process could be time consuming and cumbersome to resolve all issues. I could see a process where we upgrade ~weekly to avoid this and more regularly deal with the issues. Unfortunately since we're using nightlies of a library that doesn't provide BC guarantee at the moment, its tricky to think of a more robust upgrade process.

We need to establish a process for regularly upgrading deps for libraries which we use nightlies for. The simplest thing to do is what I've done now - pin the version and bump it whenever a new feature/bugfix we need is released. Though if there's a large gap in time between these, the upgrade process could be time consuming and cumbersome to resolve all issues. I could see a process where we upgrade ~weekly to avoid this and more regularly deal with the issues. Unfortunately since we're using nightlies of a library that doesn't provide BC guarantee at the moment, its tricky to think of a more robust upgrade process.

For MMF we use a CI bot that automatically creates a PR to update the pinned version whenever the dependency is updated. This allows it to be tested before it's merged into main while keeping the dependencies up to date at the same time.


Encryption?

Hello! Thank you for this awesome work. Just wondering what the status of encryption is in this library? Is it already part of it or on the roadmap?

Hi! Yes, I've thought about adding support for Encryption, but I'd like to change the API for that (reason being cleaner to read, better to understand, and performance).
So I've imagined it like this:
const storage = new MMKV({
  encryptionKey: 'my-encryption-key'
})

storage.set('password', '12345') // <-- gets encrypted
const password = storage.get('password')

Then we need support for multiple MMKV instances as well, since the default one can't be encrypted. And if we already have multiple instances, we also need to be able to configure it's process-mode.
const storage = new MMKV({
  name: 'secret-storage', // any name/id for the instance
  encryptionKey: 'my-encryption-key', // (optional) key used for encrypting/decrypting
  processMode: 'single-process', // (optional) 'single-process' or 'multi-process'
})

And to access the API as it is now:
const storage = MMKV.default
storage.set('username', 'Marc')

So all of that requires a lot of work, since it has to be natively implemented using TurboModules. That's the main blocker here, so I'll have to wait until TurboModules are released.

Would this library help?
@mrousavy @ammarahm-ed I'm not sure if the two are related or if you can merge them into one for less react native js fatigue and more community open source :)
https://github.com/ammarahm-ed/react-native-mmkv-storage

@mrousavy do we really need to change the API?
We could always have something like
MMKV.createInstance() that accepts props for a new instance. The instance can have .set and .get
MMKV.set() could internally map to MMKV.default instance, so no breaking change either for anyone.

I would suggest that you don't want to add this into MMKV itself.
Iv used redux-persist extensively the last 4/5 years and have had to encrypt in most cases. If you encrypt at the JS level then something like CryptoJS gives what's need to encrypt. The downside to this is that you have overhead encrypting and decrypting.
Taking a larger redux store (for example) and encrypting it and saving (via redux-persist or otherwise) is going to cause the app to appear laggy to the user as the overhead of the decryption/encryption is not tiny.
My suggestion (tho obvs each app is different) would be you either encrypt certain values and not everything. If you need to encrypt everything then CryptoJS as a wrapper around .set and .get gives you encryption. Where you store encryptions keys etc libs like https://github.com/pradeep1991singh/react-native-secure-key-store give you a drop in solution.

Hey! I will implement this in https://github.com/mrousavy/react-native-mmkv/pull/127 🚀


Unpublishing an agent removes user tools

All of these steps are taken from the admin UI.

Create a new agent.
Add any bundle under the "User tools" section
Publish the agent under any available name
Unpublish this agent
Refresh the page

The bundle added under "User tools" will be removed.

@thedadams @sangee2004 - I'm not able to reproduce this. Are you still seeing this issue?

I have not been able to reproduce the issue mentioned in the bug when testing with latest build.
I continue to see the tool bundle added under "User tools" to be present even after unpublish.


Rocks Shown Like A White Block on Journeymap

i know it is so little thing but need to be fixed for mappers :D
thanks a lot.

using game 1.11.2 forge 2223

Isn't this something you should report to journeymap? I have no clue what journeymap even does to calculate that visual

hmmmgmmhm okay then, sorry.


python311Packages.aioairzone: 0.6.9 -> 0.7.2

Diff: https://github.com/Noltari/aioairzone/compare/refs/tags/0.6.9...0.7.2
Changelog: https://github.com/Noltari/aioairzone/releases/tag/0.7.2
Description of changes

Things done

Built on platform(s)

[ ] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)

[ ] sandbox = relaxed
[ ] sandbox = true

[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
24.05 Release Notes (or backporting 23.05 and 23.11 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[ ] Fits CONTRIBUTING.md.

Add a :+1: reaction to pull requests you find important.

Result of nixpkgs-review pr 274674 run on x86_64-linux 1

2 packages built:

python311Packages.aioairzone
python311Packages.aioairzone.dist


Feature request: Text to speech

You should consider adding TTS using either NovelAI's own TTS system which I did see someone else use on some other project here or using like Google's TTS system which is pretty affordable mostly free that I've seen working in another project. You could also use some other TTS system if there is one.

I took it on board. I think it will be implemented in the future.

There's also a variety of open source AI-based TTS systems now

Tortoise TTS Fast is decent. On its fastest setting, it synthesizes a typical chat response in about 6 seconds with everything running simultaneously on a 3090. I hope we can integrate it programmatically.

Fast tortoise on my RTX 3060 Ti takes about 40-70 seconds on the fastest settings to generate the example text "The expressiveness of autoregressive transformers is literally nuts! I absolutely adore them." also there's no way I'd be able to run both things at the same time, unless you use one of the APIs.

I was using this, it's very fast at inference but requires previous finetuning for copying the voices.
https://github.com/Plachtaa/VITS-fast-fine-tuning

VITS is pretty good, though I'm still playing around it to see if I can make it sound better. But as mentioned before the inference is very fast compared to tortoise-tts (this also seems to work on your cpu).

It would be even cooler if you could use https://huggingface.co/camenduru/one-shot-talking-face to generate videos of the characters talking like I do here: https://github.com/nagolinc/AnimeBuilder/blob/main/animeCreator.py#L565-L603

I think Azure Text-To-Speech might be a pretty good option for users who lack their own hardware, or enough hardware to do both language ai and TTS. It's got a generous free tier, and is pay-go after that. It also does realtime processing of short text strings and has a JS SDK. I'd be interested in trying to wire something like that up.


Add BangPatterns to foldEffects

Tuples are lazy so without this change the model will never actually
be forced in the foldl' (foldEffects …) which could lead to spaceleaks.

Can you confirm this indeed does cause a space leak. Or create a scenario where this behavior is exhibited. I'd rather be lazy (no pun intended) and not add additional computation if we can't confirm it's a leak.

 Then you’ll have a spaceleak in https://github.com/haskell-miso/miso/blob/43ffd43830f24f6506f1a5d2e358c9d0ea5eb3f0/ghcjs-src/Miso.hs#L82 despite the foldl' which is probably meant to prevent this exact thing from happening. If you really want to be lazy in this case (I don’t see what you gain by that, if your model has a field that you want to compute lazily you’ll just not make that field strict) then that should be at least a foldr. A foldl' that is not sufficiently strict is not useful.


fix(test): fix integration tests for Ali, chroot, OpenStack, KVM

How to categorize this PR?
This fixes the broken integration tests for ALI, chroot, OpenStack and KVM that resulted from #724.

/kind test
/area os
/os garden-linux
What this PR does / why we need it:
Integration tests for  ALI, chroot, OpenStack and KVM are currently not usable.
Special notes for your reviewer:
@MrBatschner, please take a short look. Thanks.
Release note:
NONE

Oh shoot, should have thought about that in PR #724. Thank you.
/lgtm


Clarify language specifying array mutation is an error

The use of a hyphen/dash with this sentence structure makes it possible to first read the sentence as:

"We use concat to create a new array [i.e.] mutating this._data [...]".

Replacing the hyphen with "because" (or "since" or "as" or an em-dash) makes the meaning more obvious and reduces likelihood of an initial misreading.
Test plan (required)
Read the new sentence and notice you are less confused about its meaning.
NOTE: I'm not going to sign the CLA for this change.

We can't look at PRs if the CLA is not signed.

Hey, that's your prerogative but I fail to see how requiring a CLA for a one-word documentation change is making the world a better place.


Add EKS Cluster Processor and Kubernetes Catalog Collector

Porting this functionality from our internal backstage.
There are two major pieces of functionality that we are introducing here.

A new processor in the Catalog AWS plugin to ingest EKS clusters into the Catalog.
A new locator in the kubernetes-backend plugin that allows sourcing Kubernetes cluster information from the catalog.

Tests to follow on this PR, but we'd like some initial validation on the approach and usefulness here before we land those.
Hey, I just made a Pull Request!

:heavy_check_mark: Checklist

[x] A changeset describing the change and affected packages. (more info)
[x] Added or updated documentation
[x] Tests for new functionality and regression tests for bug fixes
[X] Screenshots attached (for UI changes)
[X] All your commits have a Signed-off-by line in the message. (more info)

Hi @jhaals !
While I agree that generally infrastructure should be fairly ephemeral, I think there's probably a case to be made for ingesting some level of infrastructure into the catalog. The fact that the existing Kubernetes plugin is configured out of the box with static cluster information points to K8S clusters being generally long-lived pieces of infrastructure. Also - I believe the existing S3 and Cloud Account processors fall into the same category as this processor - both can also be long lived or more ephemeral as well, depending on the use case and user.
Just to add an additional use case - we leverage this catalog data heavily internally to provide Scaffolder actions around provisioning kubernetes namespaces and other resources, not just to enable the Kubernetes plugin.
Happy to close this and manage our own plugin / keep it internal if it's not directionally aligned with the Catalog, but I do feel that having this in the core would provide benefit to end users. At the end of the day, I'd expect it to be up to the end user to decide if it makes sense to enable this processor and ingest this information.

I really like the idea of having clusters as entities in the catalog. This opens up a lot of possibilities of where we could go (k8s cluster management through Backstage).
This might also be a replacement for the clusterLocator interface in the kubernetes plugin as maybe we could just rely on the catalog processors to define the cluster configuration.

Sweet! Let me go ahead and tidy up the PR with the docs/tests/etc so we're closer to a reviewable/merge ready state.

@jhaals @mclarke47 tidied this up a bit - would appreciate a review when you have some time!

Just a quick initial look to begin with.
Could this have been an entity provider instead of a processor? That does have benefits, and is the main method of ingesting data these days.
https://backstage.io/docs/features/software-catalog/external-integrations

@freben will rely on your expertise here - the reason we chose to go with a processor is that we extend the AwsCloudOrganizationProcessor internally to emit locations for every cloud account - which then gives this processor the information it needs to go and fetch potential entities from those accounts.

LGTM Just one comment to discuss :)

@backjo sorry a small conflict has popped itself in here, could you fix it up? pray

Addressed!

@backjo or anyone else who was part of getting this PR merged, can someone provide an example of how the app config needs to look and the packages/backend/src/plugins/catalog.ts needs to look to get this working? I would love to get this working but am having trouble trying to figure it out since there is zero documentation or online open source examples to look at.
The closing thing I suspect to it is the s3 discovery / AwsS3EntityProvider which is also part of the same plugin. That one has documentation https://backstage.io/docs/integrations/aws-s3/discovery and https://backstage.io/docs/integrations/aws-s3/locations but the interface is different for AwsEKSClusterProcessor in the code.
Thank you and very much appreciate this contribution,
-Asaf

Created a github issue with a problem I had trying to get this working: https://github.com/backstage/backstage/issues/13191 . It does contain some example configuration details. If I get help getting that resolved and working I can also contribute the missing documentation.

I came across this trying to get Kubernetes data into backstage. If I understand this functionality correctly, it simply uses aws-eks as a location store for catalog-info.yaml files? I added a location type and target to my app-config.yaml, but don't see anything in the UI relating to autodiscovery of clusters, etc. Hoping to understand what the purpose of this is- it doesn't seem to show kubernetes cluster for the kubernetes integration of services.

@mhamrah I think the clusters show up in the catalog as type resource. In my local fork I added logging since there's no indication it works if you don't know where to look. If you look at my linked github issue above it includes a working configuration example.

Hi @backjo ,
could you please point me, how to configure this:

I have autodiscovered eks clusters
every cluster has dedicated role to access k8s(logs, list of pods etc)

So in backstage I would like to have main role, which can assume roles from another clusters. Currently I've configured that role from 1st cluster can assume role from the second.
right now I have:
aws:
  mainAccount:
    roleName: ${MAIN_ROLE_AWS_ARN}
    region: ${AWS_REGION}
    accounts:
      -  roleName: ${DOWNSTREAM_ROLE_AWS_ARN}
          region: ${AWS_REGION}

but it does not work. Any help highly appreciated :)

on the screenshot:

first cluster - info about pods is avaiable
second - UNAUTHORIZED_ERROR when accessing info about pods


Laravel 5.5

hello,
can you please make this package Laravel 5.5 ready, thanks..
sleimanx2/plastic v0.3.0 requires illuminate/pagination 5.2.*|5.3.*|5.4.*

we use this and upgrading our app to 5.5 and this breaks it.. could definitely use that.

+1

Does anybody know what source code part would break from upgrading?

Install this forked repo:
composer require mypharmabr/plastic
Then change your calls to Sleimanx2 namespace to MyPharmaBr namespace (including your config/app.php file).
https://packagist.org/packages/mypharmabr/plastic


CDAP-15516: Support Record type for BigQuery Source and Sink plugins

Also, can we merge this to the release/0.12 branch instead of develop

@albertshau addressed code review comments, please take a look.

@albertshau made final changes and squashed the commits.


Add origin field to HTTP requests logger

Summary
This PR adds an origin field to all the logs generated by HTTP requests (RouteLoggerInterceptor).
Changes

Adds an origin field to RouteLoggerInterceptor.

Pull Request Test Coverage Report for Build<PHONE_NUMBER>
Details

2 of 2 (100.0%)  changed or added relevant lines in 1 file are covered.
1 unchanged line in 1 file lost coverage.
Overall coverage decreased (-0.08%) to 92.957%

Files with Coverage Reduction
New Missed Lines
%

src/routes/transactions/entities/tests/human-description.builder.ts
1
90.0%

Totals

Change from base Build<PHONE_NUMBER>:
-0.08%

Covered Lines:
6995

Relevant Lines:
7245

💛  - Coveralls


Uncaught Error: ENOENT: no such file or directory, mkdir ''

[Enter steps to reproduce below:]

Started Minifying to minified file

Atom Version: 1.0.7
System: Mac OS X 10.10.5
Thrown From: atom-minify package, v0.3.0
Stack Trace
Uncaught Error: ENOENT: no such file or directory, mkdir ''
At fs.js:791

Error: ENOENT: no such file or directory, mkdir ''
  at Error (native)
  at Object.fs.mkdirSync (fs.js:791:18)
  at AtomMinifier.module.exports.AtomMinifier.ensureTargetDirectoryExists (/Users/exampleuser/.atom/packages/atom-minify/lib/minifier.coffee:166:24)
  at /Users/exampleuser/.atom/packages/atom-minify/lib/minifier.coffee:56:18
  at /Users/exampleuser/.atom/packages/atom-minify/lib/minifier.coffee:256:13
  at /Users/exampleuser/.atom/packages/atom-minify/lib/inline-parameters.coffee:16:21
  at ReadStream.<anonymous> (/Users/exampleuser/.atom/packages/atom-minify/lib/inline-parameters.coffee:39:21)
  at emitOne (events.js:77:13)
  at ReadStream.emit (events.js:166:7)
  at readableAddChunk (_stream_readable.js:146:16)
  at ReadStream.Readable.push (_stream_readable.js:109:10)
  at onread (fs.js:1734:12)
  at FSReqWrap.wrapper [as oncomplete] (fs.js:571:17)

Commands
     -6:55.6.0 core:move-down (atom-text-editor.editor.is-focused)
     -6:55.4.0 core:move-left (atom-text-editor.editor.is-focused)
  2x -6:55.1.0 core:backspace (atom-text-editor.editor.is-focused)
     -6:54.5.0 snippets:next-tab-stop (atom-text-editor.editor.is-focused)
     -6:54.5.0 snippets:expand (atom-text-editor.editor.is-focused)
     -6:54.5.0 editor:indent (atom-text-editor.editor.is-focused)
     -6:53.8.0 core:save (atom-text-editor.editor.is-focused)
     -5:38.6.0 core:close (atom-text-editor.editor.is-focused)
     -5:36.7.0 core:save (atom-text-editor.editor.is-focused)
     -4:55.7.0 core:confirm (atom-text-editor.editor.mini.is-focused)
     -2:37 core:save (atom-text-editor.editor.is-focused)
     -2:13.2.0 atom-minify:minify-to-min-file (atom-text-editor.editor.is-focused)
     -1:54.1.0 atom-minify:minify-direct (atom-text-editor.editor.is-focused)
     -1:47.4.0 core:undo (atom-text-editor.editor.is-focused)
     -1:45.4.0 core:save (atom-text-editor.editor.is-focused)
     -0:05.6.0 atom-minify:minify-to-min-file (atom-text-editor.editor.is-focused)

Config
{
  "core": {
    "themes": [
      "atom-dark-ui",
      "atom-dark-syntax"
    ],
    "disabledPackages": [
      "metrics",
      "welcome"
    ]
  },
  "atom-minify": {
    "checkOutputFileAlreadyExists": true
  }
}

Installed Packages
# User
atom-beautify, v0.28.11
atom-minify, v0.3.0
autoclose-html, v0.18.0
color-picker, v2.0.11
csslint, v1.1.4
highlight-line, v0.11.0
minimap, v4.13.1

# Dev
No dev packages

Fixed with version 0.3.1
Thanks for you report!


Query all existing keys

Hi there, I am trying to query all existing keys from a database. As I found no documentation, I looked at the source code and found this file where a query on a range of keys should be possible. I thought using an empty start and end key should make sense to just get all keys, especially as the admin, but no luck so far.
I am working to REST requests, so e.g.,:
key = "node_1"
# key = ""
enc_key = base64.urlsafe_b64encode(bytes(key, encoding="utf-8")).decode()
payload = {
    "user_id": self.__username,
    "db_name": db_name,
    "start_key": key,
    "end_key": key,
    "limit": 10,
}
signature = self.__sign_tx(payload)
response = await self.__client_session.get(
    url=f"{self.__orion_db_url}/data/{db_name}/?startkey={enc_key}&endkey={enc_key}&limit=10",
    headers={"UserID": self.__username, "Signature": signature},
)

But I get the error 404 and if I remove the ?query limit or the whole query part:
// Returned with 400
  {
    "error": "Failed to decode base64 URL key: key: illegal base64 data at input byte 8"
  }

I don't think this should happen, right?
I also saw a json query method, although I am unsure how to apply it, doing something like in the tests didn't work for me where the value had an attribute "status" with a value "valid" e.g.,
{"selector": {"status": {"$eq": "valid"}}}

I was able to solve it through removing a backslash  url=f"{self.__orion_db_url}/data/{db_name}?startkey={enc_key}&endkey={enc_key}&limit=10" and specifying the start and end keys as a and z. Further the header sent to Orion needs to contain the limit as a string.


Fix broken build

Build is failing due to improper identation, fixing with this PR

Apparently this CI workflow should be on the frontend part as there is no node in overall project ( i think )


Undefined symbols for architecture arm64

Hi, thank you for this package - it's just exactly what I need 👏
I'm using it in a swift package and found one minor issue:
Undefined symbols for architecture arm64:
  "___llvm_profile_runtime", referenced from:
      ___llvm_profile_runtime_user in SpyableDiagnostic.o
      ___llvm_profile_runtime_user in Extractor.o
      ___llvm_profile_runtime_user in CalledFactory.o
      ___llvm_profile_runtime_user in CallsCountFactory.o
      ___llvm_profile_runtime_user in ClosureFactory.o
      ___llvm_profile_runtime_user in FunctionImplementationFactory.o
      ___llvm_profile_runtime_user in ReceivedArgumentsFactory.o
      ...
     (maybe you meant: ___llvm_profile_runtime_user)
ld: symbol(s) not found for architecture arm64

It occurs only when code coverage is enabled - not a deal-breaker - but I'd be glad if you could help me resolve it.
I'm using Xcode 15.0 beta (15A5160n).

Seems to be resolved with the newest beta 5.


Inconsistent behavior with buttons when viewed in editor vs after exporting

Godot version
4.0.2 Stable
System information
Windows 10; AMD Ryzen 7 3700X 8-Core Processor 3.60 GHz
Issue description
Buttons with a text followed by a new line character do not show the newline in-editor, but does show it after exporting.
Steps to reproduce
1.) Create a new project with a button control node.
2.) In the text attribute of the control node, put "play" followed by clicking the enter key (new line)
3.) Click play to view the project in-editor. Observe how the button reads "play", and pay attention to the height of the button.
4.) Export the project using a windows template. Run the exported project. Observe how the button reads "play" but renders the new line, making the button twice as tall as it was in the editor.
Minimal reproduction project
N/A

Duplicate of https://github.com/godotengine/godot/issues/74351


Implement decomposition from onnx.Sum to sequence of onnx.Add

Can one of the admins verify this patch?

I can't find any current lowering path for onnx.Sum. I figured it would be best to add decomposition pattern here rather than do a direct conversion to stablehlo.  I'm open to suggestions if this is not a desirable change.

Can one of the admins verify this patch?

Can one of the admins verify this patch?

just realized i messsed up the one input case. fixing now

Can one of the admins verify this patch?

not sure what's up with the jenkins failures though

Starting a new batch of CI, let me look at the PR soon.

Starting a new batch of CI, let me look at the PR soon.

Thanks. I still need to figure out the test failure too. I thought fixing the one input case woud have resolved it but it didn't. I'm unfamiliar with the test that's failing so will have to dig.

@srcarroll here is the log of the error for Linux amd64
/usr/lib/python3.10/subprocess.py:526: CalledProcessError
----------------------------- Captured stdout call -----------------------------
[1/6] Thu Oct  3 09:08:26 2024 (0s) Importing ONNX Model to MLIR Module from "test_sum_one_input.onnx"
[2/6] Thu Oct  3 09:08:26 2024 (0s) Compiling and Optimizing MLIR Module
----------------------------- Captured stderr call -----------------------------
error: failed to legalize unresolved materialization from ('tensor<?xf32>') to 'tensor<*xf32>' that remained live after conversion
=========================== short test summary info ============================
 Debug/test.py::OnnxBackendNodeModelTest::test_sum_one_input_cpu - subprocess...
1 failed, 521 passed, 2344 skipped in 84.49s (0:01:24)
make[3]: *** [test/backend/CMakeFiles/check-onnx-backend-dynamic.dir/build.make:71: test/backend/CMakeFiles/check-onnx-backend-dynamic] Error 1
make[2]: *** [CMakeFiles/Makefile2:14510: test/backend/CMakeFiles/check-onnx-backend-dynamic.dir/all] Error 2
make[2]: *** Waiting for unfinished jobs....
bringing up nodes...
bringing up nodes...

It feels like something is missing for the shape inference. If you convert the sum into a series of add before shape infrence, then shape inference should be able to operate normally. Maybe you need to put it earlier than currently placed.
You can run the test directly in your env
TEST_CASE_BY_USER=test_sum_one_input_cpu make -j 12 check-onnx-backend-dynamic

You can add compiler options (for debugging) by defining the ONNX_MLIR_FLAGS env var
Hope this helps.

@AlexandreEichenberger thanks for the pointers. I'm actually having a hard time setting up my environment to run python tests and haven't had time to look into fixing it. so i'm just guessing based on the error what the problem is. i think this error would happen any time the result type of onnx.Sum is an unranked tensor. hence why it complains about unrealized cast from tensor<?xf32> -> tensor<*xf32>. so one solution i can think of is to just cast the result of the final onnx.Add to the original onnx.Sum result type when they don't match. i'll push soon

Can one of the admins verify this patch?

@jenkins-droid  test this please

Yes, setting up is a bit tricky, to get ONNX installed (I do a pip install -e third_party/onnx, protobuf sometimes cause problems). That is why you can also develop on docker images that we publish, where all should be working smoothly.

@jenkins-droid test this please

(I think our Jenkins is having problems, folks are working on this)

@Sunny-Anand mind doing a "test this please" on this PR once the Jenkins issue is fixed, thanks

All checks have passed.

@AlexandreEichenberger thanks! yes please do merge.

@srcarroll thanks for your contributions, much appreciated

Jenkins Linux amd64 Build #15775 [push] Implement decomposition ... started at 18:50

Jenkins Linux s390x Build #15778 [push] Implement decomposition ... started at 19:50

Jenkins Linux ppc64le Build #14805 [push] Implement decomposition ... started at 20:02

Jenkins Linux amd64 Build #15775 [push] Implement decomposition ... passed after 1 hr 18 min

Jenkins Linux s390x Build #15778 [push] Implement decomposition ... passed after 1 hr 42 min

Jenkins Linux ppc64le Build #14805 [push] Implement decomposition ... passed after 2 hr 17 min


STAR-725 Bloom false positive rate includes true negatives

This is a port of CASSANDRA-15384 that was partially ported in the
last oss -> dse-db port. Only the corresponding dtest was ported
and now it constantly fails without the actual fix in dse-db code.
Patch by Jaroslaw Grabowski; reviewed by brandonwilliams and paulo for
CASSANDRA-15384
Before this change the bloom filter false positive rate was calculated
without true negatives which resulted in high rates. In an extreme case,
where all queries return no data, the false positive rate could go up to
1.0.
This change includes true negatives in [recent] bloom filter false ratio.

still waiting on pr-gate

still waiting on pr-gate

Now sonarcloud is complaining about duplicate code.

@jacek-lewandowski could you please merge this? I doesn't make sense to refactor this code as this comes from OSS C*. It could be refactored on OSS side but for now let's just unblock PR merges (this fix is needed for FastCI).


(Breaking Change) Generate update ID at call time if not set

Current the SDK generates an Update ID, if not is set, when UpdateOptionsBuilder.build is called. This PR changes the behaviour so the Update ID is generated when the update request is made. This is done to:

Match the behaviour of WorkflowID in WorkflowOptions
Match other SDK's behaviour
Prevent the confusing case where reusing an option without an ID set causes one one update request when the customer tried to make two, see the test updateWorkflowReuseOptions.

@cretz I set the ID before the interceptor so the interceptor has access to the ID, this is important for things like tracing interceptors . This is also consistent with the rest of the Java SDK.

Hrmm, ok. Some other SDKs do differently, but I agree it's more important to be intra-SDK consistent here than inter-SDK consistent.


Android automatic refactor - ObsoleteLayoutParam

Hi,
I am developing a tool to automatically refactor Android applications with the goal of improving energy efficiency.
This pull request has the changes generated while applying the rule "ObsoleteLayoutParam".
While developing your application's views you might be specifying attributes in a view's artefact that are not necessary due to the nature of its parent. In this PR, those attributes were replaced by a comment.
I have made a previous validation of the changes and they seem correct.
Unfortunately, this tool is not able keep the original whitespace of the files, so comparison without ignoring whitespace might be confusing.
Please consider the changes and let me know if you agree with them.
Best,
Luis

this pr only removes  android:layout_alignParentBottom="true" from  java/res/layout/input_stone_popup.xml and java/res/layout/keyboard_popup.xml .
It also add </org.pocketworkstation.pckeyboard.LatinKeyboardBaseView> but maybe that is something that got removed in meantime and is added back because of whitespace issues

Indeed it only removes android:layout_alignParentBottom="true" from java/res/layout/input_stone_popup.xml and java/res/layout/keyboard_popup.xml. Does tags are supposed to be meaningless in the given context.
The </org.pocketworkstation.pckeyboard.LatinKeyboardBaseView> is not part of this PR. I think it is a legacy tag since this PR was done back in 2017.
Feel free to close this PR if it no longer makes sense.


Remove the cursor_column mechanism

Is your feature request related to a problem? Please describe.
A clear and concise description of what the problem is. Ex. I'm always frustrated when [...]
Describe the solution you'd like
A clear and concise description of what you want to happen.
Describe alternatives you've considered
A clear and concise description of any alternative solutions or features you've considered.
Additional context
Add any other context or screenshots about the feature request here.

Removing this component, as it won't be necessary with the new log_info changes coming in #1246.


Create im/exporter MPS <-> LIonWeb

This has been done in the lioncore-mps project. I think in this project there is nothing we should do, correct?

I agree.


Add deny attributes

Codecov Report

Merging #172 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #172   +/-   ##
=======================================
  Coverage   82.90%   82.90%
=======================================
  Files          12       12
  Lines         433      433
=======================================
  Hits          359      359
  Misses         74       74

Impacted Files
Coverage Δ

cli/src/main.rs
0.00% <ø> (ø)

os_info/src/lib.rs
100.00% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5cc4230...d85da83. Read the comment docs.