wails: 2.8.2 -> 2.9.1

Description of changes
Update Wails from v2.8.2 to v2.9.1.
Changelogs:
https://github.com/wailsapp/wails/releases/tag/v2.9.0
https://github.com/wailsapp/wails/releases/tag/v2.9.1
Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[x] x86_64-darwin
[ ] aarch64-darwin

For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)

[ ] sandbox = relaxed
[x] sandbox = true

[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[x] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[x] Tested basic functionality of all binary files (usually in ./result/bin/)
24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[x] Fits CONTRIBUTING.md.

Add a :+1: reaction to pull requests you find important.

Result of nixpkgs-review pr 321555 run on x86_64-linux 1

2 packages built:

snippetexpandergui
wails

Result of nixpkgs-review pr 321555 run on x86_64-darwin 1

1 package built:

wails


[Question] Route marker

Hi,
Is there a way to have one draggable marker and one fixed marker for route?
I want to prevent destination marker to be moved.

The draggable setting is managed at the main google.maps.DirectionsRenderer AFAIK Google doesn't allow that.


loadCells then getRows?

I have an issue, lets say I have a sheet with two tables of data, for example, something like this:

I just want to get A2:B3 data, so what im making is sheet.loadCells("A2:B3"), but how can I loop over each row cell? I see the only way is to use getCell or getCellByA1 manually... there is no other method that can return like an array of arrays? for example, something like
[
  [123, 345],
  [asd, rgt]
]

Sounds like you may want to use the row-based API - https://theoephraim.github.io/node-google-spreadsheet/#/classes/google-spreadsheet-worksheet?id=working-with-rows


...would not inline the sourceMap in the vendor files #typo

Max Klenk published this wish on stomt.

The type has been fixed in the new release, now everything works as expected again.


g8 templates for version 0.19.0-x fail compie

Here are the steps:

sbt -sbt-version 0.13.15 new http4s/http4s.g8
select 0.19
cd quickstart
sbt compile
quickstart/src/main/scala/com/example/quickstart/HelloWorldServer.scala:19:18: IO takes no type parameters, expected: one [error]     BlazeBuilder[IO] [error]                  ^ [error] /home/kayvan/tmp/quickstart/src/main/scala/com/example/quickstart/HelloWorldServer.scala:21:21: diverging implicit expansion for type cats.effect.Effect[F] [error] starting with method catsWriterTEffect in object Effect [error]       .mountService(helloWorldService, "/") [error]                     ^ [error] /home/kayvan/tmp/quickstart/src/main/scala/com/example/quickstart/HelloWorldServer.scala:11:83: class IO takes type parameters [error]   def stream(args: List[String], requestShutdown: IO[Unit]) = ServerStream.stream[IO] [error]                                                                                ^ [error] three errors found [error] (Compile / compileIncremental) Compilation failed [error] Total time: 1 s, completed Aug 23, 2018 6:40:43 PM

Would you mind, instead, raising this issue in the g8 repo?

moved the issue to http4s/g8 repo.
See issue-73  for detail


Request email after use

Browser Version
Chorme
Exension Version
1.4.2
Actual behaviour
Request to send to email after I use the plugin
Reproduction steps
No response
Expected behaviour
No response

We are working on it on #450


Implemented to_le and to_be

Implemented to_le and to_be

This one looks super clean and nice, thank you very much !


Custom JSON Serializer

Please provide an option to pass a custom json serializer while inserting documents.

Hi @apurvNfer,
Right. I will consider adding it in the next release. Keeping this open for any updates.

Hi @apurvNfer,
Python-arango version 5.0.0 is now up! This release provides support for custom JSON serialization.
But please note that this version only works with ArangoDB 3.5+ and breaks backwards-compatibility (you will need to update your application code when you upgrade). Please see the release notes for details.
Thanks!


changes necessary for cloudera cdh 5

Thanks for the effort on RImpala. I have been using it fine with CDH 4.x.x. But recently we switched to CDH 5.1.0 and current RImpala is not compatible. I found that the problem is from dependency. In this pull request, I modified pom.xml and added the zip file containing latest jar files. It has been tested with no problem from our end.
Please test it and let me know if you have any concern.

Hi yinghua,
              Thanks for sending out the patch. We tested the same against CDH 5.x.x and the patch seems to work fine. I have merged the pull request .

Regards,
Vijay Raajaa G S


MongoDB Authentication

For the MongoDB package, I need to be able to set an initial Username and Password to enable authentication.
This can be done by using MONGO_INITDB_ROOT_USERNAME and MONGO_INITDB_ROOT_PASSWORD environment variables.
This parameter must also be passed to mongo-express and used in the connection string.

This isn't supported today for mongo, but if you're interested feel free to send a PR with this support. You can model it after the postgres resource.

PR request build failed, but I can see why here: https://dev.azure.com/dnceng-public/public/_build/results?buildId=696252&view=logs&j=22fea640-1099-5f32-ec5d-316ad83f359a&t=25461519-4e76-58ab-2938-2b66c09712e4&l=23
Aspire.Azure.Data.Tables are not touched by my commit, so this test failed for probably a good reason, but I don't see which one :(


fix: Add support for passing authorization_scopes on routes with JWT authorizer

Description
Make it possible to pass the authorization_scopes as a comma separated string on the integration level. Passing it as a set of string like the AWS resource expects makes the variable validation fail with a " attribute types must all match for conversion to map" as also described here
Motivation and Context
Due to missing documentation on the AWS provider the authorization_scopes parameter was being ignored. The docs have been updated as seen here
This fixes issue
Breaking Changes
No. This is an optional parameter
How Has This Been Tested?

[x] I have updated at least one of the examples/* to demonstrate and validate my change(s)
[x] I have tested and validated these changes using one or more of the provided examples/* projects

[x] I have executed pre-commit run -a on my pull request

This PR is included in version 1.6.1 :tada:

Amazing work, works like a dream! Thank you all.


brew install fbsimctl fails with: Code signing is required for product type 'Command-line Tool' in SDK 'macOS 10.12'

I am using macOS 10.12.2 beta 3 and Xcode 8.2 beta 3. Running either brew install fbsimctl or brew install fbsimctl --head fails with the following error:

Leo-Natans-Wix-MPB:detox lnatan$ brew install fbsimctl
==> Installing fbsimctl from facebook/fb
==> Downloading https://github.com/facebook/FBSimulatorControl/tarball/v0.2.2
==> Downloading from https://codeload.github.com/facebook/FBSimulatorControl/legacy.tar.gz/v0.2.2
######################################################################## 100.0%
==> ./build.sh fbsimctl build /usr/local/Cellar/fbsimctl/0.2.2
Last 15 lines from /Users/lnatan/Library/Logs/Homebrew/fbsimctl/01.build.sh:
    cd /tmp/fbsimctl-20161130-48922-km8ocr/facebook-FBSimulatorControl-f41dec3/fbsimctl
    /usr/bin/touch -c /tmp/fbsimctl-20161130-48922-km8ocr/facebook-FBSimulatorControl-f41dec3/build/Build/Products/Debug/FBSimulatorControlKit.framework

=== BUILD TARGET fbsimctl OF PROJECT fbsimctl WITH CONFIGURATION Debug ≡

Check dependencies
"fbsimctl" isn't code signed but requires entitlements. It is not possible to add entitlements to a binary without signing it.
Code signing is required for product type 'Command-line Tool' in SDK 'macOS 10.12'

** BUILD FAILED **

The following build commands failed:
	Check dependencies
(1 failure)

If reporting this issue please do so at (not Homebrew/brew or Homebrew/core):
https://github.com/facebook/homebrew-fb/issues

Error: You are using a pre-release version of Xcode.
You may encounter build failures or other breakages.
Please create pull-requests instead of filing issues.Leo-Natans-Wix-MPB:detox lnatan$ brew install fbsimctl
==> Installing fbsimctl from facebook/fb
==> Downloading https://github.com/facebook/FBSimulatorControl/tarball/v0.2.2
==> Downloading from https://codeload.github.com/facebook/FBSimulatorControl/legacy.tar.gz/v0.2.2
######################################################################## 100.0%
==> ./build.sh fbsimctl build /usr/local/Cellar/fbsimctl/0.2.2
Last 15 lines from /Users/lnatan/Library/Logs/Homebrew/fbsimctl/01.build.sh:
    cd /tmp/fbsimctl-20161130-48922-km8ocr/facebook-FBSimulatorControl-f41dec3/fbsimctl
    /usr/bin/touch -c /tmp/fbsimctl-20161130-48922-km8ocr/facebook-FBSimulatorControl-f41dec3/build/Build/Products/Debug/FBSimulatorControlKit.framework

=== BUILD TARGET fbsimctl OF PROJECT fbsimctl WITH CONFIGURATION Debug ≡

Check dependencies
"fbsimctl" isn't code signed but requires entitlements. It is not possible to add entitlements to a binary without signing it.
Code signing is required for product type 'Command-line Tool' in SDK 'macOS 10.12'

** BUILD FAILED **

The following build commands failed:
	Check dependencies
(1 failure)

If reporting this issue please do so at (not Homebrew/brew or Homebrew/core):
https://github.com/facebook/homebrew-fb/issues

Error: You are using a pre-release version of Xcode.
You may encounter build failures or other breakages.
Please create pull-requests instead of filing issues.

Building the project from Xcode works, but from cmd fails with the error above.

Hmm, with Xcode 8.1 this issue does not reproduce. I will open a but report with Apple tomorrow.

@LeoNatan it might also be worth checking in with homebrew here. I'm not sure if Apple added a codesign requirement for all builds in Xcode 8.2, but it wasn't a requirement for Mac binaries in Xcode 8.0.
Re-open if there's anything that fbsimctl needs to do here around codesigning.

Thanks
Let's wait for the a newer beta and see. I might also test on a different machine with Xcode 8.2 to see if a special combination of circumstances. Since the project built within Xcode itself, to me it looks like bug in the command line tools.

@lawrencelomax Issue persists.
brew tap facebook/fb
brew install fbsimctl --HEAD

==> Installing fbsimctl from facebook/fb
==> Cloning https://github.com/facebook/FBSimulatorControl.git
Updating /Users/lnatan/Library/Caches/Homebrew/fbsimctl--git
==> Checking out branch master
==> ./build.sh fbsimctl build /usr/local/Cellar/fbsimctl/HEAD-244a622
Last 15 lines from /Users/lnatan/Library/Logs/Homebrew/fbsimctl/01.build.sh:
cd /tmp/fbsimctl-20170118-36571-pwc8nx/fbsimctl
/usr/bin/touch -c /tmp/fbsimctl-20170118-36571-pwc8nx/build/Build/Products/Debug/FBSimulatorControlKit.framework
=== BUILD TARGET fbsimctl OF PROJECT fbsimctl WITH CONFIGURATION Debug ≡
Check dependencies
"fbsimctl" isn't code signed but requires entitlements. It is not possible to add entitlements to a binary without signing it.
Code signing is required for product type 'Command-line Tool' in SDK 'macOS 10.12'
** BUILD FAILED **
The following build commands failed:
Check dependencies
(1 failure)
If reporting this issue please do so at (not Homebrew/brew or Homebrew/core):
https://github.com/facebook/homebrew-fb/issues

This is unrelated to homebrew. Building from command line fails with the same error, while building from Xcode succeeds.

Using export CODE_SIGNING_REQUIRED=NO && brew install fbsimctl --HEAD is a workaround for this issue, however the root cause remains unclear.

I think this is just the case of adding this project setting to the scheme used to build fbsimctl.

@lawrencelomax Any news on fixing this on your end? More and more people are hitting this. We use fbsimctl as a prerequisite of https://github.com/wix/detox and people with newer Xcode are hitting this issue.

Any solution ?

Any solution?

We use export CODE_SIGNING_REQUIRED=NO && brew install fbsimctl --HEAD command as a workaround.

it's work !!!

This seems to be fixed in the latest HEAD version. I can do brew install fbsimctl --HEAD without needing to do export CODE_SIGNING_REQUIRED=NO.


[DSP] - Fix fractionator recipe, speed and power usage of certain machines, icon invertLight

Ok, this should address #1311 and #1314


added article and authors md file with images

added index.md file with images under content->article and content->authors.

@rajendraprasadp
If you delete these two files - we can merge and your EngEd author profile will be live on our site 🚀

Ok I'll do that..If you guys have access you please continue by deleting
those.
On Mon 9 May, 2022, 9:40 PM hectorkambow, @.***> wrote:

@rajendraprasadp https://github.com/rajendraprasadp
If you delete these two files - we can merge and your EngEd author profile
will be live on our site 🚀
[image: image]
https://user-images.githubusercontent.com/60800358/167451892-b8cc1dff-7ea5-49f0-a587-d60d2714acbd.png
—
Reply to this email directly, view it on GitHub
https://github.com/section-engineering-education/engineering-education/pull/7648#issuecomment-1121298445,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AVH7RDSN6JPUM54R6TMKFYLVJE2HTANCNFSM5VMKKETA
.
You are receiving this because you were mentioned.Message ID:
<section-engineering-education/engineering-education/pull/7648/c1121298445
@github.com>

deleted the 2 files

🚀


FileHandle::read_async()/FileHandle::write_async() CUstream and StreamFuture

TL;DR: Is it possible to expose a fire-and-forget-like version of the async read/write functions if a CUstream functions are given?

FileHandle::read_async() (and write_async()) state that these functions return a StreamFuture which

must be kept alive until all data has been read to disk

Ostensibly this is so that stream synchronization can be RAII-ified (StreamFuture indeed synchronizes the stream in its dtor).
But, if I pass a non-null CUstream then why must I keep the StreamFuture alive? If I have given kvikio a stream, then surely kvikio may assume that I will perform other things on the same stream.
For reference, I am thinking of the following possible workflow:
void *read_gpu_data(std::size_t nbytes, CUstream stream)
{
  auto f = kvikio::FileHandle{"data.txt", "r"};

  void *dev_ptr = allocate_gpu_pointer(nbytes);
  f.read_async(dev_ptr, nbytes, 0, stream);
  return dev_ptr;
}

void do_work()
{
  std::size_t nbytes = 1234;

  auto *dev_ptr = read_gpu_data(nbytes, stream);
  my_kernel<<<..., stream>>>(dev_ptr, ...);
}

In this example, if I want to keep the GPU pipeline alive, I also need to ferry around the StreamFuture object...
The other overload taking pointers is also not ergonomic, because it requires that bytes_read_p is non-NULL. I know the values of all my parameters right now, and I don't care about how many bytes were read by the GPU task (because I'm passing the pointer on to the kernel).

The other overload taking pointers is also not ergonomic, because it requires that bytes_read_p is non-NULL.

This is the reason why KvikIO introduce the StreamFuture object. The only async API cuFile provides takes the arguments as pointers. There is no way to provide the arguments by value :/

This is the reason why KvikIO introduce the StreamFuture object. The only async API cuFile provides takes the arguments as pointers. There is no way to provide the arguments by value :/

Hmmm, perhaps kvikio could provide a "default" pointer to use here in that case. Some kind of internal static pointer that kvikio registers appropriately with cuFile which can be used as a default if this pointer is NULL.


I wish /docs/user-guide/deployment/ existed

I wish /docs/user-guide/deployment/ existed.  It is linked from http://kubernetes.io/docs/user-guide/walkthrough/k8s201/ under the Deployments section

Looks like the link is just missing an "s" at the end since http://kubernetes.io/docs/user-guide/deployments/ does exist.


Change notifications UI

I have an issue with popup notifications containing compilation errors. They overlaying some of ui elements.
I think that it will be nice to replace popup notifications with some kind of notifications tray.
I've drew some example as i think it should to look like:

All messages should be stored in some local cache until session ends ( page reloaded ).

We planned to display everything in a log window in the coming milestone and try to reduce the use of notification popups.

@Hid-K We've developed a logger window that effectively displays all logs in one place.

Yeah, i see. But is it possible to make console.log displayed in it, while running unit tests?

Yes, I had similar thoughts as well. Would you mind creating a separate issue for this?

All the logs have been moved to the logger window at the bottom of the screen.

All the logs have been moved to the logger window at the bottom of the screen.


Bluetooth: audio: ascs: Fix handling zero Number_of_ASEs parameter

As per ASCS_v1.0
"A client-initiated ASE Control operation shall be defined as an
invalid length operation if the Number_of_ASEs parameter value is
less than 1".
Fixes: ASCS/SR/SPE/BI-{02,03,04,05,06}-C
Signed-off-by: Mariusz Skamra<EMAIL_ADDRESS>

@szymon-czapracki FYI

@MariuszSkamra do you want to update the else if branches as well (perhaps a separate commit in this PR)? You now have a mix of BT_WARN/BT_ERR which is not ideal..

@MariuszSkamra do you want to update the else if branches as well (perhaps a separate commit in this PR)? You now have a mix of BT_WARN/BT_ERR which is not ideal..

I've pushed it as separate commit


Does this repo have a license?

Hey, nice work!
I'm just wondering what license the code is released under? I'd like to borrow some of your code for a bevy project but don't want to do the wrong thing!

Added the MIT license file to the repo.


Use one Box to store both, the local and remote address.

Motivation:
We should just use one Box to store both, the local and the remote address. This will remove some heap allocations. And reduce memory overhead.
Modifications:
Use a tuple which holds the local and remote address and so only use one Box for the cached addresses.
Result:
Less heap allocations and less memory usage.

@Lukasa PTAL again


Add a command which gets the System Lockdown mode information

Summary of the new feature / enhancement
We should have a command which gets all the Lockdown mode information.  The Lockdown Policy.  The current language module and the startup language mode of the session.

A module may not want to support lockdown mode, it would need to know the policy to implement that as the customer may mark the script as trusted and cause it to run in FLM.  Perhaps because it cannot be implemented without arbitrary code execution issues.
Although the current language mode can be gotten, it would be good to have all the information from one place.
The initial language mode can be anything in a hosted environment.  I don't have a use for this right now, but I don't see any reason to exclude it right now.  It might be useful for testing that hosted environments in lockdown machines are created correctly.

> get-lockdowninfo
LockdownPolicy CurrentLanguageMode InitialLanguageMode
-------------- ------------------- -------------------
None           FullLanguage        FullLanguage

Proposed technical implementation details (optional)
Here is a script which gets the information, but the actual one should be in C#, in PowerShell, so that it works when in lockdown mode.
class LockdownInfo {
	[string]$LockdownPolicy
	[string]$CurrentLanguageMode
	[string]$InitialLanguageMode
	LockdownInfo([string]$policy, [string]$clm, [string]$ilm) {
		$this.LockdownPolicy = $policy
		$this.CurrentLanguageMode = $clm
		$this.InitialLanguageMode = $ilm
	}
}
$spType = [psobject].assembly.GetType("System.Management.Automation.Security.SystemPolicy")
$slpMethod = $spType.GetMethod("GetSystemLockdownPolicy")
$lockdownPolicySetting = $slpMethod.Invoke($null, $null)
$currentLM = $ExecutionContext.Host.Runspace.LanguageMode
$initialLM = $ExecutionContext.Host.Runspace.InitialSessionState.LanguageMode
[LockdownInfo]::new($lockdownPolicySetting, $currentLM, $initialLM)

If the language modes are unrelated to the system lockdown mode
SystemEnforcementMode
GetSystemLockdownPolicy
then I don't see why they should be returned.

Submitted for Working Group review

I have made a minimalist package for PSGallery from github.

@rhubarb-geek-nz
https://github.com/PowerShell/PowerShell/issues/23799#issuecomment-2111441608
as the type is internal, this suggestion will not work

as the type is internal, this suggestion will not work

In what way? SystemPolicy.GetSystemLockdownPolicy is a documented public method.

as the type is internal, this suggestion will not work

In what way? SystemPolicy.GetSystemLockdownPolicy is a documented public method. So is SystemEnforcementMode Enum

That method only gets a piece of the total information

@PowerShell/wg-powershell-cmdlets reviewed this and agrees that Get-SystemLockdownPolicy should be exposed as part of PowerShell 7.


From Text : Proposal for adding new functionality

I would like to add more features to the "From Text" option since I need to use this feature for a project and the current system doesn't offer enough functionality.
Basically I want to be able to import a diagram similar to this [https://d2slcw3kip6qmk.cloudfront.net/marketing/pages/chart/seo/ERD/discovery/erd-example.svg]
I was thinking of going based off of PlantUML's format [ http://plantuml.com/object-diagram ] as a basis. But I will probably modify it slightly. I need to actually modify the objects afterwards so the current import of PlantUML is not sufficient.
Any thoughts or comments ?

Please send PR as plugin like https://github.com/jgraph/drawio/blob/master/src/main/webapp/plugins/sql.js


Update Japanese translation

Thank a lot, looks great.
One note: could you remove lines with original English values? If these strings cannot be translated or they are not translated yet then it will make further translation difficult.
Eclipse can automatically find all "untranslated" strings. It won't find them because they already have values.

The remaining "untranslated" parts will be translated later.
I want to check the difference, so I added it as "English". Is that a problem?
I am not using Eclipse.

It is a problem because automatic translation software (any software, not just Eclipse) won't be able to find untranslated strings.
Although generally it will work.

Thanks!


[BUG] typer.main.get_group should return a click.Group

Describe the bug
The function typer.main.get_group is annotated as returning a click.Command which isn't wrong because a click.Group is a click.Command, but means I have to cast to group when trying to integrate with existing Click applications.
To Reproduce
Steps to reproduce the behavior with a minimum self-contained file.
Replace each part with your own scenario:

Create a file main.py with:

import typer

app = typer.Typer()

@app.callback()
def callback():
    """ My partially-upgraded-to-Typer app """

# insert some fancy new Typer commands here

click_group = typer.main.get_group(app)

@click_group.command()
def some_old_click_function():
      """ I need to rewrite this somday """

Run mypy on this script with mypy main.py and it will output something like

main.py:16: error: "Command" has no attribute "command"

Expected behavior
Able to drop in Typer at the top level to start slowly converting an existing Click app.
Screenshots
If applicable, add screenshots to help explain your problem.
Environment

OS: macOS
Typer Version: 0.2.1
Python version: 3.8.2
mypy version: 0.770

@tiangolo could i take this up?

Thank you! This should be solved in https://github.com/tiangolo/typer/pull/430 , and will be available in the next release. :nerd_face:


Windows 7 viewer.exe crash (and driver install issues)

Before opening a new issue, we wanted to provide you with some useful suggestions (Click "Preview" above for a better view):

Consider checking out SDK examples.
Have you looked in our documentations?
Is you question a frequently asked one?
Try searching our GitHub Issues (open and closed) for a similar issue.

All users are welcomed to report bugs, ask questions, suggest or request enhancements and generally feel free to open new issue, even if they haven't followed any of the suggestions above :)

Required Info

Camera Model
{ R200 / F200 / SR300 / ZR300 / D400 }

Firmware Version
(Open RealSense Viewer --> Click info)

Operating System & Version
{Win (8.1/10) / Linux (Ubuntu 14/16/17) / MacOS

Kernel Version (Linux Only)
(e.g. 4.14.13)

Platform
PC/Raspberry Pi/ NVIDIA Jetson / etc..

SDK Version
{ legacy / 2.. }

Issue Description
<Describe your issue / question / feature request / etc..>

Required Info
Version

Camera Model
D435

Firmware Version
<IP_ADDRESS>

Operating System & Version
Win 10

Platform
PC

SDK Version
v2.10.1

Intel.RealSense.Viewer.exe application crash
Faulting application name: Intel.RealSense.Viewer.exe, version: <IP_ADDRESS>, time stamp: 0x59be0e69 Faulting module name: ntdll.dll, version: 10.0.14393.1715, time stamp: 0x59b0d8f3 Exception code: 0xc0000005 Fault offset: 0x000709eb Faulting process id: 0x24c4 Faulting application start time: 0x01d3b6b393c34df1 Faulting application path: C:\Users\mdauphin\Downloads\Intel.RealSense.Viewer.exe Faulting module path: C:\WINDOWS\SYSTEM32\ntdll.dll Report Id: 771ae2a5-a6af-4f49-9933-ccf152ef498c Faulting package full name:  Faulting package-relative application ID:

Hello @kwcooper , it is not clear whether you were trying to run Windows 7 (headline) or Windows 10 (template) .
Librealsense SDK is supported on Windows 8.1/10 with MS MediaFoundation driver.
While there is no official support for Windows7 , you may review a related #1243 for alternatives

[Realsense Customer Engineering Team Comment]
@kwcooper Did you get the issue on Windows 7 or Windows 10? Please note that there is no official support for Windows 7.
Seen from the log, the SDK version you used seems to be v2.7.9 and not the specified v2.10.1 in the template. If you're trying on Windows 10, please try the latest v2.10.1 in https://github.com/IntelRealSense/librealsense/tree/v2.10.1

[Realsense Customer Engineering Team Comment]
@kwcooper Please update if you need more support. Thanks!


hey -n 5 -c 2 sends 870 requests?

I'm using hey installed via homebrew.
Using -n 5 -c 2 sends 870 requests.
$ hey -n 5 -c 2 -z 30s -t 9 http://<IP_ADDRESS>:8000/

Summary:
  Total:	30.0324 secs

...

Status code distribution:
  [200]	870 responses

My naive assumption after seeing the help string and Work.N ("N is the total number of requests to make") is that this hey invocation would send a total of 5 requests.
Clearly I am misunderstanding -n. If it's not the number of requests, what is it?

Brew info:
$ brew info hey
Warning: Treating hey as a formula. For the cask, use homebrew/cask/hey
hey: stable 0.1.4 (bottled)
HTTP load generator, ApacheBench (ab) replacement
https://github.com/rakyll/hey
/usr/local/Cellar/hey/0.1.4 (5 files, 9.6MB) *
  Poured from bottle on 2020-12-21 at 22:26:22
From: https://github.com/Homebrew/homebrew-core/blob/HEAD/Formula/hey.rb
License: Apache-2.0
==> Dependencies
Build: go ✘
==> Analytics
install: 723 (30 days), 2,359 (90 days), 9,503 (365 days)
install-on-request: 725 (30 days), 2,360 (90 days), 9,496 (365 days)
build-error: 0 (30 days)

In readme it explained,
  -z  Duration of application to send requests. When duration is reached,
      application stops and exits. If duration is specified, n is ignored.

So your requests will be ignored due to given specified duration parameter.
Similar to issue: https://github.com/rakyll/hey/issues/197
What if you remove -z 30s and execute it again?

Yep, that's what I was missing. Thanks @namidairo777 !
$ hey -n 5 -c 1 -t 9 http://<IP_ADDRESS>:8000/

...

  [200]	5 responses


added trackResize to default options map

see #62 .
my first contribution, so please advice if anything missing.

@behboud why close?

this is all new to me. thought I need to start a new pull request. also: angular.merge causes errors. so I need to revert and add trackResize as property

k


Fix missing /internal path to offsets.json and in README.md

Quick fix to path on offsets.json in the Makefile, which was causing the update-offsets action to start from scratch and go back through many golang versions.

Codecov Report

Merging #220 (01c6216) into main (b0bb692) will decrease coverage by 40.49%.
The diff coverage is n/a.

:exclamation: Current head 01c6216 differs from pull request most recent head 83a1f67. Consider uploading reports for the commit 83a1f67 to get more accurate results

@@             Coverage Diff             @@
##             main     #220       +/-   ##
===========================================
- Coverage   81.23%   40.75%   -40.49%
===========================================
  Files          35       33        -2
  Lines        2809     2694      -115
===========================================
- Hits         2282     1098     -1184
- Misses        387     1533     +1146
+ Partials      140       63       -77

Flag
Coverage Δ

integration-test
?

unittests
40.75% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.
see 28 files with indirect coverage changes

Yes, looks like test failure is not related to this change, will try to handle that in another PR.


First check auth token

Will read api token from request header - this is an incompatible change. it'll avoid touching untrusted data without a valid api token though.

auth token check could be improved in an more general way e.g.
https://jwt.io
https://tools.ietf.org/html/rfc7519
closed: maybe issue and further investigation?


chore: update changeset description

What/Why/How?
Updating changeset description for the upcoming release: https://github.com/Redocly/redocly-cli/pull/1218
Reference
Testing
Screenshots (optional)
Check yourself

[ ] Code is linted
[ ] Tested with redoc/reference-docs/workflows (internal)
[ ] All new/updated code is covered with tests

Security

[ ] Security impact of change has been considered
[ ] Code follows company security practices and guidelines

Can we add the improvement to the tags-alphabetical rule to this release? #1258

@adamaltman already added in the release PR: https://github.com/Redocly/redocly-cli/pull/1218/files#diff-77f023b99d3d58008351d3e82fc06e6d06ba1bc2da9e41be6329b7fa4f419f05R15


Update boot list to include sed, grep and gawk. Also print out the boot list on help

Lgtm. I see you didn’t end up adding man ?

Added!


Port to typescript

(Do not merge until https://github.com/blockstack/key-encoder-js/pull/11 is merged and the key-encoder npm dependency can be updated)
Github shows a scarier diff than it actually is.

Code is compiled to es6.
Code coverage is generated and uploaded to codeCov.
eslint rules intact.
Restored the ecdsa-sig-formatter dependency and removed the copied code.
Tested that browserify still works using npm i -D browserify tsify && npx browserify src/index.ts -p [ tsify ] -o bundle.js.

Codecov Report

:exclamation: No coverage uploaded for pull request base (develop@9a3417c). Click here to learn what that means.
The diff coverage is 82.35%.

@@            Coverage Diff            @@
##             develop     #38   +/-   ##
=========================================
  Coverage           ?   78.4%
=========================================
  Files              ?       7
  Lines              ?     125
  Branches           ?       6
=========================================
  Hits               ?      98
  Misses             ?      26
  Partials           ?       1

Impacted Files
Coverage Δ

src/index.ts
100% <ø> (ø)

src/cryptoClients/index.ts
100% <ø> (ø)

src/errors.ts
50% <ø> (ø)

src/verifier.ts
82.14% <100%> (ø)

src/cryptoClients/secp256k1.ts
77.14% <100%> (ø)

src/decode.ts
50% <50%> (ø)

src/signer.ts
90.62% <60%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9a3417c...b5ec16e. Read the comment docs.


Publish md5 hashes of datasets

Description
Is it possible to publish file hashes and directory layouts for all datasets, post processing. I would like to run some checks to ensure that there are no discrepancies with the data my team has downloaded and processed.

The dataset layouts and final sizes are documented in datasets/README.md in the dropdown items saying "The final directory structure should look like this:".

Thanks, that's useful. Would it be possible to publish hashes of the files as well?

@chandramouli-sastry could you help close this request?
I have all the data from the setup scripts downloaded in kasimbeg-8 in /home/kasimbeg/data.
The remaining work is to:

Check the README for data setup to make sure the file structure matches and there are no additional files left from the download.
Get the hashes for all of the datasets and add them to the data setup README.


Android build error Expo 51 - Plugin ... was not found in any of the following sources

Describe what happened
After upgrading to Expo 51, it's not possible to build the Android app.
It appears this may be related to the version of Gradle being updated to 8.6
Steps to reproduce the issue:

Upgrade an app that uses expo-datadog from Expo 50 to Expo 51
Build the Android app
Get build error (below)

FAILURE: Build failed with an exception.

* Where:
Build file '<REDACTED>/android/app/build.gradle' line: 2

* What went wrong:
Plugin [id: 'com.datadoghq.dd-sdk-android-gradle-plugin', version: '1.+'] was not found in any of the following sources:

- Gradle Core Plugins (plugin is not in 'org.gradle' namespace)
- Included Builds (None of the included builds contain this plugin)
- Plugin Repositories (could not resolve plugin artifact 'com.datadoghq.dd-sdk-android-gradle-plugin:com.datadoghq.dd-sdk-android-gradle-plugin.gradle.plugin:1.+')
  Searched in the following repositories:
    Gradle Central Plugin Repository

I've resolved this issue by setting an explicit datadogGradlePluginVersion version of 1.13.0, which allows the build to complete, but it would be great if that was not required.
Example plugin config to get the build working again
expo: {
  ...
  plugins: [
    ...
    [
        'expo-datadog',
        {
          errorTracking: {
            datadogGradlePluginVersion: '1.13.0',
          },
        },
      ],
  ]
}

Describe what you expected:
The build should complete
Additional context
"@datadog/mobile-react-native": "^2.3.2",
"@datadog/mobile-react-navigation": "^2.3.2",
"expo": "^51.0.1",
"expo-datadog": "^50.2.0",
"react-native": "0.74.1",
...

Hey @robwalkerco,
The update to Expo 51 is in our roadmap, and we will grant support soon with<EMAIL_ADDRESS>I will keep you posted here as soon as we have an open PR.
Thank you for your valuable feedback!

Subscribing - we'd like to switch our company to Datadog and this is blocking us at the moment.

I work at a company that's a new Datadog customer and we are also blocked by this. Is there a timeline that you can share for supporting expo 51?

@marcato15
The delay was mainly caused by the fact that one of our engineers, responsible for the Expo updates, recently left the company. There has been a period of knowledge transfer and onboarding for the new engineer, and an unusual amount of critical issues to solve in our React Native SDK.
Future updates will be quicker, we apologise for the inconvenience 🙏

@robwalkerco @raghavsethi @panasenco @marcato15
Sorry for the long wait!
We have released<EMAIL_ADDRESS>which solves the build issue on Android and grants support for Expo 51.

@robwalkerco @raghavsethi @panasenco @marcato15
Sorry for the long wait!
We have released<EMAIL_ADDRESS>which solves the build issue on Android and grants support for Expo 51.

Thank you for the explanation. That is very helpful.

Thank you, much appreciated!


Split ball state think into pre-think and think to handle shield positioning better

On second thought there would be little benefit in doing that.


debug.hoverWidget closes when hovering over debug console panel

@alexandrudima the issue I have here is that the mouseLeave event does not have a target, so I can not use something like this
Because content widgets can now go outside the editor sometimes the mouseLeave event should still have a target, right?
Locally I tried changing the mouseHandler however with my simple change (to handle it similar to _onMouseUp()) I would still get my hover as the target even when it is not a target. Maybe some tips on how to solve this properly?

I think this bug is not properly solved. Now, the "debug variable overlay" does not disappear anymore, but whenever the mouse cursor is above the "debug console resizing handle", we see the vertical resizing icon. When at the same time an expandable variable/tree item is rendered in the debug variable overlay, this cannot be expanded anymore, since the mouse thinks it should handle the debug console resizing.

Nice find, reopening to investigate

After looking into it I distilled it into a new bug https://github.com/Microsoft/vscode/issues/9678


Makefile enhancements

I added data download targets for gatk & object detection so they're built with one command.
Added a clean target so that you can redownload the data if needed.
Updated gatk so it creates the reference repo and adds the reference data.
Now you can just type "make hyperparameter" or "make gatk_demo" and they'll build with that one command.

  I fixed it here by reverting that one file, so this just contains the makefile now.


[hotfix] Improve CI trigger and cancel strategy

Avoid main branch CI jobs being canceled.

Thanks @tisonkun, the explanation of the Concurrency strategy in this PR is very useful 👍

Merging...
It seems the daily CI always failed on compilation now. Let me take a look..


Incorrect number of rows and columns read when using an Excel file with multiple sheets

We have detected a problem with Excel files that have multiple sheets, in the UI you can choose the sheet you want to take the data from, however the number of rows and columns is always of the first sheet, regardless if you choose a different one.
In this example Plantilla de registros 4.0.xlsx we have an Excel document with additional information in several sheets, the data goes in the second one, you can choose that without problems:

But after you choose the data, it only reads 62 rows and 14 columns (the ones used in the first sheet) and it should read 497 rows and 76 columns:

The IPT read the info from the correct sheet but only the number of rows and columns from the first one. It should read the number of rows and columns from the selected sheet and not always the first.

Thanks for the help,

Thank you @EstebanMH-SiB for reporting this issue

@EstebanMH-SiB You need to hit Analyze button every time you change excel pages.

Thanks @mike-podolskiy90, using the Analyze button worked perfectly. We should like to see that information included in the manual or maybe a information button in the IPT when you are uploading an Excel, because is not 100% intuitive to use that option instead of just saving.


Second retry skip

Current behavior
The second retry is systematically considered OK even when it should be KO.

Desired behavior
I expect the second retrie to work the same as the first one.
Test code to reproduce
https://github.com/Clement398/Bug
Versions

Cypress version: 10.2.0
Preprocessor version: 11.3.0
Node version: 16.15.1

Hey, @Clement398, thanks for reporting the issue. I've fixed it with v11.3.1.


Issue with Train the automatic regression model

If we run it as per suggested in this doc. it is failing with "azureml-defaults" related package error.
Then I ran pip install azureml-defaults.
After that I ran it again and this time it is creating two run.
one is run type "script" and it is failing with below error.
UserError: User program failed with AttributeError: 'str' object has no attribute 'name'
Then simultaneously another run with run type "Automated ML"  is in "preparing" state but it is not ending at all.
Can any one please help here.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 68a3df81-6871-c443-c413-16bb97982bd4
Version Independent ID: 5030fc51-ec28-d96e-fe85-a06a8fa1ce6f
Content: Regression tutorial: Automated ML - Azure Machine Learning
Content Source: articles/machine-learning/tutorial-auto-train-models.md
Service: machine-learning
Sub-service: core
GitHub Login: @trevorbye
Microsoft Alias: trbye

If we run it as per suggested in this doc. it is failing with "azureml-defaults" related package error.
Error: User error: Incompatible/Missing packages found: azureml-defaults requires flask==1.0.3 but has Flask 1.1.2.
Then I ran pip install azureml-defaults.
After that I ran it again and this time it is creating two run.
one is run type "script" and it is failing with below error.
UserError: User program failed with AttributeError: 'str' object has no attribute 'name'
Then simultaneously another run with run type "Automated ML" is in "preparing" state but it is not ending at all.
Can any one please help here.

@AmitavaHazra Are you using a notebook on Azure to run this tutorial? This is most likely an issue with the initial failure that is causing another run to be stuck. Could you please submit your run details along with the error from Azure ML portal from the top right hand corner by clicking the smiley? This would help our team to lookup the issue and contact you on steps to fix the same.

@RohitMungi-MSFT, I am running this from jupyter notebook.
I have attached feedback as per you suggested.
Awaiting for response.

@AmitavaHazra Thanks for providing the feedback as suggested. Our team should reach out to you to fix this. If necessary, we can also provide a one time free support request for this issue if you do not have a support plan for your subscription.
We will now proceed to close this thread. If there are further questions regarding this matter, please tag @RohitMungi-MSFT in your reply.

@RohitMungi-MSFT facing exact same issue as @AmitavaHazra, when executed in Jupyter server.
In AzureML studio editor, it's working fine.
I have also installed flask=1.0.3 in the notebook in runtime and enabled 'enable_local_managed' in AutoMLConfig, still no success.

I am having same issue @RohitMungi-MSFT

@RutujaWanjari , @protzetter how did you create your local conda environments?
Have you tried following the steps described here ?


Add redirects to frontmatter

This PR attempts to add the Jekyll redirect plugin to change an outdated link reported here: https://github.com/kubernetes/kubernetes.github.io/issues/486.
I created a new Gemfile with the GitHub Pages & the Jekyll redirect gems and added an old link to the new article's front matter but unfortunately it's not working for me locally.
I wonder if it has something to do with the way URLs are processed for the site or that several of the articles aren't using the front matter.

I am going to close this PR until I can get it working on my local fork here: https://github.com/jmarlena/kubernetes.github.io/pull/2.


GHSA-cqhr-jqvc-qw9p has an invalid CVE id and appears to be a duplicate of GHSA-g66q-grxc-64j3

GHSA-cqhr-jqvc-qw9p has the CVE id CVE-2016-1000273 but this id does not exist at NVD. On the other hand, the vulnerability appears to be the same as GHSA-g66q-grxc-64j3 although the severity is different and the latter is missing the fix version.

Hi @warkentyne, I think you'll need to reach out to the cve org to see about that cve id.
https://cveform.mitre.org/


Add to app fails integrating Podfile into abstract target: [!] Invalid Podfile file: [!] Script phases cannot be added to abstract targets

Hi, I Add Flutter to existing iOS app, My project is  abstract target, I use this way of "Embed with CocoaPods and the Flutter SDK", it's error 。 For abstract target，how to use "Embed with CocoaPods and the Flutter SDK"?
profile
source "https://github.com/CocoaPods/Specs.git"

flutter_application_path = 'my_flutter'
load File.join(flutter_application_path, '.ios', 'Flutter', 'podhelper.rb')

platform :ios,'9.0'
abstract_target 'CommonVVHealth' do
inhibit_all_warnings!

target 'XXXHealth'
install_all_flutter_pods(flutter_application_path)
end

Logs
[!] Invalid `Podfile` file: [!] Script phases cannot be added to abstract targets

 #  from /myPath/Podfile:86
 #  -------------------------------------------
 #
 >  install_all_flutter_pods(flutter_application_path)
 #
 #  -------------------------------------------

[✓] Flutter (Channel stable, v1.12.13+hotfix.9, on Mac OS X 10.14.6 18G95, locale zh-Hans-CN)
    • Flutter version 1.12.13+hotfix.9 at /Users/guoxiaomin/development/flutter
    • Framework revision f139b11009 (3 weeks ago), 2020-03-30 13:57:30 -0700
    • Engine revision af51afceb8
    • Dart version 2.7.2

[✓] Android toolchain - develop for Android devices (Android SDK version 29.0.2)
    • Android SDK at /Users/guoxiaomin/Library/Android/sdk
    • Android NDK location not configured (optional; useful for native profiling support)
    • Platform android-29, build-tools 29.0.2
    • Java binary at: /Applications/Android Studio.app/Contents/jre/jdk/Contents/Home/bin/java
    • Java version OpenJDK Runtime Environment (build 1.8.0_202-release-1483-b49-5587405)
    • All Android licenses accepted.

[✓] Xcode - develop for iOS and macOS (Xcode 11.2.1)
    • Xcode at /Applications/Xcode.app/Contents/Developer
    • Xcode 11.2.1, Build version 11B500
    • CocoaPods version 1.7.5

[✓] Android Studio (version 3.5)
    • Android Studio at /Applications/Android Studio.app/Contents
    • Flutter plugin version 44.0.1
    • Dart plugin version 191.8593
    • Java version OpenJDK Runtime Environment (build 1.8.0_202-release-1483-b49-5587405)

[✓] VS Code (version 1.43.0)
    • VS Code at /Applications/Visual Studio Code.app/Contents
    • Flutter extension version 3.8.1

[✓] Connected device (1 available)
    • iPhone 8 • 2BBAF8F4-D1B3-4880-8148-6DC434150447 • ios •
      com.apple.CoreSimulator.SimRuntime.iOS-13-2 (simulator)

• No issues found!

The frameworks should be added to the app target, not an abstract target.


Feature: Define domains for caddy and add them to /etc/hosts

Describe the Feature
It would be great to be able to use domain names as virtual hosts in caddy. Devenv could handle the /etc/hosts changes (or dnsmasq configuration).

https://github.com/numtide/devshell/pull/75
https://github.com/numtide/devshell/pull/74

@blaggacao do you want to make a PR to devenv if you are already familar with that

We need a solution that works for macOS and linux and ideally is scoped to the environment.

Yes please: https://guumaster.github.io/hostctl/docs/guides/basic_profiles/

It has been literally years. And we're not using devenv (yet). But considering.
Iirc, during all the time past there where also ideas about a HOSTFILE variable to define project hosts files.
It might be at least worth it to do a quick research to see where these ideas are currently at (and if they have sufficiently progressed).

I guess this would require some kind of pre- and post-scripts to devenv up to be able to execute the hostctl 🤔


Can now do this through the PowerApps Maker UI

As of July 2019 you can now create an AutoNumber field with the UI when utilising the new solution configuration experience at make.powerapps.com. When you create a new field on an entity one of the choices under Text is AutoNumber and you can then define the details.

@crharveymsft The customization content for Dynamics 365 for Customer Engagement on-premises, for which the PowerApps maker portral does not apply. For all things customization Dynamics 365 for Customer Engagement (online), see https://docs.microsoft.com/en-us/powerapps/maker/common-data-service/ and https://docs.microsoft.com/en-us/powerapps/maker/model-driven-apps/
Specifically for autonumber fields, see:

https://docs.microsoft.com/en-us/powerapps/maker/common-data-service/create-edit-field-portal#field-data-types (overview)
https://docs.microsoft.com/en-us/powerapps/maker/common-data-service/autonumber-fields (detailed information)

Closing issue.


Feature/dispose cut

Current Problem
Right now there is no way to test what happens when we navigate away from a page. Blazor normally disposes  all the components from top-down (parent first, then children, then children of children and so on). We can't simulate this behavior.
Possible Solution
The draft describes that we extend the IRenderFragment and offer a Detach method. To make this work we have to tell the TestRenderer that we want to "detach" us from the active render tree. The renderer knows which component-id the parent has and we can remove us from there.
Advantages
Very fine grained control of what we want to detach. Also the API speaks "more" than the TestContext.Detach approach.
Drawbacks
The shown solution is more like an idea, which has its limit and is rather complex.
Still the second added test is failing due to the fact, that not every <Child/> is defined as RenderFragment ChildContent. So if we just compose a Parent with arbitrary children like that:
Parent.razor

Hej, hvordan går det

<Child></Child>
<AnotherComponent></AnotherComponent>

It's kinda hard to detach Parent.
Also from a personal point of view I don't think we need this use case, because this is nothing you would see "in the wild".
PS: The name of the branch does not reflect the behavior. This was my first try and I went with Dispose instead of Detach.

I guess we’ll close this PR as we both want to go with the other approach :)


Fix tap gestures detection

I was having trouble using the tapToClose props, and noticed this code used to detect if the user touch is a tap gestures or a swipe gesture.
It believe there's been a mixup here between the gestureState attributes moveX and dx.
According to the PanResponder documentation, moveX is the latest screen coordinates of the recently-moved touch, whereas dx is the accumulated distance of the gesture since the touch started
I got tapToClose to perform as I expected it to after this change.

+99 many thanks


allow custom get_field_config

fix #159, by adding get_field_config classmethod to Config, also improves the way inheritance works for Config classes.

@dnp1 hasn't responded about this after requesting it sadly.
However I think it would be useful so I'll merge in a few days unless anyone has any problems or improvement suggestions?

Does the documentation reflect this? Would be nice to have an example.

@samuelcolvin There is no mention for get_field_config in the document other than in changelog section. Its been almost 2 years since this feature has been published.


Add expansion packs

Bonjour.
First of all, I want to say GREAT JOB so far.
As a 7 wonders fan and player, I really enjoyed playing this.
As a developer I really enjoyed digging through the code even if my Kotlin knowledge is pretty close to zero.
How about taking this a step further and including some expansion packs in this app?
In my opinion, the easiest to start would be to add Cities.
This would require the least changes in the code

extra black cards: 1 for each player from a pool of cards (similar to the n+2 rule for guilds)
one extra turn each age if playing 3 to 7 players. or same number of turns but the ability to play in 8. (initially it can be just one extra turn and don't allow 8 players)
Embassy tokens and card actions
spy cards (copy a science symbol from the neighbors) . this may complicate the wildcard science score calculation a bit
coin loss card actions and coin tokens.
one extra wonder that can be played only with this expansion pack

If you like the idea and are willing to try it, I'm more than happy to help with card and token images because I'm incompetent of helping with the code.
And if all goes well, other expansion packs can be added but these are subject to other user stories.

leaders
armada
babel
wonder pack

Hi @tzyganu, thanks a lot for your feedback!
I always had the expansions in the back of my mind, to be honest, but so far I preferred to focus on usability issues, tests, and bugs, before moving forward.
The code is mostly generic as far as the cards, boards and effects are concerned, so this part would be easily extensible.
One of the things I want to deal with before adding expansion packs is creating a proper and more generic state machine for the general game state (which will be also the main thing to change in the backend when adding expansions, like new turns etc.).
Last but not least, the UI. Depending on the expansions, the real estate of the screen may become really scarce (I'm thinking about you Babel).
But some expansions may indeed be very easy in terms of UI. Cities may indeed be the simplest. Leaders simply adds one turn per age (and maybe a place where we can see the leaders cards on the board), so it would also be pretty easy for the UI.

I'm more than happy to help with cards and token images

Honestly that would be awesome. It's quite a challenge to find nice assets that blend with the rest. I think I have all expansions of the actual board game at home, so a last resort can be scanning everything 😁
Don't hesitate to make a PR adding images to the img-archive folder. It's where I keep potential images that I don't use yet.
Again thanks for the feedback!

Hi @tzyganu, thanks a lot for your feedback!
I always had the expansions in the back of my mind, to be honest, but so far I preferred to focus on usability issues, tests, and bugs, before moving forward.
The code is mostly generic as far as the cards, boards and effects are concerned, so this part would be easily extensible.
One of the things I want to deal with before adding expansion packs is creating a proper and more generic state machine for the general game state (which will be also the main thing to change in the backend when adding expansions, like new turns etc.).
Last but not least, the UI. Depending on the expansions, the real estate of the screen may become really scarce (I'm thinking about you Babel).
But some expansions may indeed be very easy in terms of UI. Cities may indeed be the simplest. Leaders simply adds one turn per age (and maybe a place where we can see the leaders cards on the board), so it would also be pretty easy for the UI.

I'm more than happy to help with cards and token images

Honestly that would be awesome. It's quite a challenge to find nice assets that blend with the rest. I think I have all expansions of the actual board game at home, so a last resort can be scanning everything 😁
Don't hesitate to make a PR adding images to the img-archive folder. It's where I keep potential images that I don't use yet.
Again thanks for the feedback!

by helping with the images I was trying to say...scan or take photos of the cards and tokens :). Will try that when I have some spare time and make a PR if I get good results.
Side note: After playing this on heroku , I'm trying to install this locally on ubuntu 18.04 and getting this warning

For Jackson Kotlin classes support please add "com.fasterxml.jackson.module:jackson-module-kotlin" to the classpath

and this error

org.springframework.beans.factory.BeanDefinitionStoreException: Failed to process import candidates for configuration class [org.luxons.sevenwonders.server.SevenWonders]; nested exception is java.lang.IllegalStateException: Error processing condition on org.springframework.boot.actuate.autoconfigure.web.server.ManagementContextAutoConfiguration$DifferentManagementContextConfiguration
at org.springframework.context.annotation.ConfigurationClassParser.processImports(ConfigurationClassParser.java:610) ~[spring-context-5.3.1.jar!/:5.3.1]
at org.springframework.context.annotation.ConfigurationClassParser.access$800(ConfigurationClassParser.java:111) ~[spring-context-5.3.1.jar!/:5.3.1]
at org.springframework.context.annotation.ConfigurationClassParser$DeferredImportSelectorGroupingHandler.lambda$processGroupImports$1(ConfigurationClassParser.java:812) ~[spring-context-5.3.1.jar!/:5.3.1]

I'm not very familiar with java development, but since this runs on a dockerized environment, I assume the docker image needs some changes? Or do I need some other prerequisites before installing this? or is ubuntu not supported?
Should I raise a separate issue for this?

by helping with the images I was trying to say...scan or take photos of the cards and tokens :). Will try that when I have some spare time and make a PR if I get good results.
Side note: After playing this on heroku , I'm trying to install this locally on ubuntu 18.04 and getting this warning

For Jackson Kotlin classes support please add "com.fasterxml.jackson.module:jackson-module-kotlin" to the classpath

and this error

org.springframework.beans.factory.BeanDefinitionStoreException: Failed to process import candidates for configuration class [org.luxons.sevenwonders.server.SevenWonders]; nested exception is java.lang.IllegalStateException: Error processing condition on org.springframework.boot.actuate.autoconfigure.web.server.ManagementContextAutoConfiguration$DifferentManagementContextConfiguration
at org.springframework.context.annotation.ConfigurationClassParser.processImports(ConfigurationClassParser.java:610) ~[spring-context-5.3.1.jar!/:5.3.1]
at org.springframework.context.annotation.ConfigurationClassParser.access$800(ConfigurationClassParser.java:111) ~[spring-context-5.3.1.jar!/:5.3.1]
at org.springframework.context.annotation.ConfigurationClassParser$DeferredImportSelectorGroupingHandler.lambda$processGroupImports$1(ConfigurationClassParser.java:812) ~[spring-context-5.3.1.jar!/:5.3.1]

I'm not very familiar with java development, but since this runs on a dockerized environment, I assume the docker image needs some changes? Or do I need some other prerequisites before installing this? or is ubuntu not supported?
Should I raise a separate issue for this?


UVI Request

--- UVI JSON ---
{
  "vendor_name": "Linux",
  "product_name": "Kernel",
  "product_version": "versions from v2.6.19 to before v4.19.194",
  "vulnerability_type": "unspecified",
  "affected_component": "unspecified",
  "attack_vector": "unspecified",
  "impact": "unspecified",
  "credit": "",
  "references": [
    "https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git/commit/?id=9ec52099e4b8678a60e9f93e41ad87885d64f3e6",
    "https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git/commit/?id=d106f05432e60f9f62d456ef017687f5c73cb414"
  ],
  "extended_references": [
    {
      "type": "commit",
      "value": "9ec52099e4b8678a60e9f93e41ad87885d64f3e6",
      "note": "introduced"
    },
    {
      "type": "commit",
      "value": "d106f05432e60f9f62d456ef017687f5c73cb414",
      "note": "fixed"
    }
  ],
  "reporter": "joshbressers",
  "reporter_id": 1692786,
  "notes": "",
  "description": "pid: take a reference when initializing `cad_pid`\n\nThis is an automated ID intended to aid in discovery of potential security vulnerabilities. The actual impact and attack plausibility have not yet been proven.\nThis ID is fixed in Linux Kernel version v4.19.194 by commit d106f05432e60f9f62d456ef017687f5c73cb414, it was introduced in version v2.6.19 by commit 9ec52099e4b8678a60e9f93e41ad87885d64f3e6. For more details please see the references link."
}
--- UVI JSON ---

This issue has been assigned UVI-2021-1000741


Wronk_JNE_2015

Moved all files from Wronkiewicz_JNE_2014 to Wronkiewicz_JNE_2015 because the current year is hard to remember sometimes.

@drammock or @Eric89GXL

This is in a crapload of deletes and adds, much better to be moves. Please squash the two commits.

Okay, it should be all file moves now.


Add SimpleMDE and Fix Image Paste for Issue/Comment Editor

This PR update #9132 and #8834. Since the paste event should bind with SimpleMDE, I decide to update two issues in this PR.
This PR does not implement user option to enable/disable SimpleMDE. I'm not sure if it's a good idea to enable this feature with this PR because it requires to add a new column into database.  Need some discussions. 🤔

Issue menu cannot popup now.

Issue menu cannot popup now.

Oh... I forget to attache issue menu 😓 . I'll fix it.

Codecov Report

Merging #9197 into master will decrease coverage by 0.02%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master    #9197      +/-   ##
==========================================
- Coverage   41.08%   41.05%   -0.03%
==========================================
  Files         553      553
  Lines       72041    72042       +1
==========================================
- Hits        29596    29579      -17
- Misses      38718    38732      +14
- Partials     3727     3731       +4

Impacted Files
Coverage Δ

routers/repo/issue.go
34.41% <100%> (+0.04%)
:arrow_up:

modules/indexer/indexer.go
44.73% <0%> (-10.53%)
:arrow_down:

models/pull_list.go
57.74% <0%> (-4.23%)
:arrow_down:

modules/migrations/migrate.go
23.78% <0%> (-1.63%)
:arrow_down:

routers/repo/view.go
38.59% <0%> (-0.88%)
:arrow_down:

modules/migrations/gitea.go
8.82% <0%> (-0.64%)
:arrow_down:

models/pull.go
55.26% <0%> (-0.44%)
:arrow_down:

models/repo.go
47.17% <0%> (-0.05%)
:arrow_down:

models/error.go
33.86% <0%> (+0.59%)
:arrow_up:

modules/task/migrate.go
28.94% <0%> (+3.94%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ef9a037...d707d1f. Read the comment docs.

Update the extraKeys for simpleMDE. It's because simpleMDE does not trigger input event when backspace press down. It cause tribute fails to update it's current cursor index and fail to update menu when keywords changing.

Please resolve the conflicts

Please resolve the conflicts

No problem 😄


Long process names can lead to tables overflowing in 2-table layout

@lilliputten Has done some work in https://github.com/lilliputten/bw_matchbox/tree/dev-230729-two-tables-layout-bug already.

- All columns, except for the name, are fixed in width.
- Text inside the cells clipping with ellipsises, if possible.
- Adjusted (reduced, where it was possible) table paddings.

I think it is also possible to reduce the width of the space between the two tables (didn't touched it at all -- this is still the skeleton's area of responsibility). (It seems to be too wide now.)

I agree, let's create a custom copy of the table and reduce some of this unnecessary white space.

This has already been done in the latest fixes. The space between tables was reduced to 15px.

If the PR isn't merged it isn't fixed :) But nice to know that it is on the way!

Fixed in #11


Runtime exception from gampleman/elm-visualization

I am not sure what this has anything to do with particular library. It happened when I'm using gampleman/elm-visualization pkg. It seems to have something to do with Date converted from Unix timestamp or overwhelming amount of DOM element(I'm using it to render a line chart with data sent through Phoenix Channel).

@gampleman - any ideas on how to narrow this down?

This should reproduce the error:
module LineChart exposing (..)

import Visualization.Scale as Scale exposing (ContinuousScale, ContinuousTimeScale)
import Visualization.Axis as Axis
import Visualization.List as List
import Visualization.Shape as Shape
import Date
import Date.Extra exposing (..)
import Svg exposing (..)
import Svg.Attributes exposing (..)
import Date exposing (Date)
import String

w : Float
w =
    900

h : Float
h =
    450

padding : Float
padding =
    30

view : List ( Date, Float ) -> Svg msg
view model =
    let
        _ =
            Debug.log "data breaks line chart" model

        xScale : ContinuousTimeScale
        xScale =
            let
                start =
                    Date.fromTime<PHONE_NUMBER>000

                end =
                    Date.fromTime<PHONE_NUMBER>000

                ( start_, _ ) =
                    Maybe.withDefault ( start, 0 ) (List.head model)

                ( end_, _ ) =
                    Maybe.withDefault ( start, 0 ) (List.reverse model |> List.head)
            in
                Scale.time ( add Day -1 start_, add Day 1 end_ ) ( 0, w - 2 * padding )

        yScale : ContinuousScale
        yScale =
            Scale.linear ( 0, 5 ) ( h - 2 * padding, 0 )

        opts : Axis.Options a
        opts =
            Axis.defaultOptions

        xAxis : Svg msg
        xAxis =
            Axis.axis { opts | orientation = Axis.Bottom, tickCount = List.length model } xScale

        yAxis : Svg msg
        yAxis =
            Axis.axis { opts | orientation = Axis.Left, tickCount = 5 } yScale

        areaGenerator : ( Date, Float ) -> Maybe ( ( Float, Float ), ( Float, Float ) )
        areaGenerator ( x, y ) =
            Just ( ( Scale.convert xScale x, Tuple.first (Scale.rangeExtent yScale) ), ( Scale.convert xScale x, Scale.convert yScale y ) )

        lineGenerator : ( Date, Float ) -> Maybe ( Float, Float )
        lineGenerator ( x, y ) =
            Just ( Scale.convert xScale x, Scale.convert yScale y )

        area : String
        area =
            List.map areaGenerator model
                |> Shape.area Shape.monotoneInXCurve

        line : String
        line =
            List.map lineGenerator model
                |> Shape.line Shape.monotoneInXCurve
    in
        svg [ width (toString w ++ "px"), height (toString h ++ "px") ]
            [ g [ transform ("translate(" ++ toString (padding - 1) ++ ", " ++ toString (h - padding) ++ ")") ]
                [ xAxis ]
            , g [ transform ("translate(" ++ toString (padding - 1) ++ ", " ++ toString padding ++ ")") ]
                [ yAxis ]
            , g [ transform ("translate(" ++ toString padding ++ ", " ++ toString padding ++ ")"), class "series" ]
                [ Svg.path [ d area, stroke "none", strokeWidth "3px", fill "rgba(255, 0, 0, 0.54)" ] []
                , Svg.path [ d line, stroke "red", strokeWidth "3px", fill "none" ] []
                ]
            ]

-- From here onwards this is simply example boilerplate.
-- In a real app you would load the data from a server and parse it, perhaps in
-- a separate module.

main =
    view model

-- Here we simply define the data inline. The examples don't include logic for fetching and parsing this data.

model =
    [ ( Date.fromTime<PHONE_NUMBER>, 0.107 )
    , ( Date.fromTime<PHONE_NUMBER>, 0.266 )
    , ( Date.fromTime<PHONE_NUMBER>, 0.285 )
    , ( Date.fromTime<PHONE_NUMBER>, 0.084 )
    , ( Date.fromTime<PHONE_NUMBER>, 0.081 )
    , ( Date.fromTime<PHONE_NUMBER>, 0.073 )
    , ( Date.fromTime<PHONE_NUMBER>, 0.049 )
    , ( Date.fromTime<PHONE_NUMBER>, 0.359 )
    , ( Date.fromTime<PHONE_NUMBER>, 0.089 )
    , ( Date.fromTime<PHONE_NUMBER>, 0.146 )
    , ( Date.fromTime<PHONE_NUMBER>, 0.112 )
    , ( Date.fromTime<PHONE_NUMBER>, 0.055 )
    , ( Date.fromTime<PHONE_NUMBER>, 0.069 )
    , ( Date.fromTime<PHONE_NUMBER>, 0.049 )
    , ( Date.fromTime<PHONE_NUMBER>, 0.126 )
    , ( Date.fromTime<PHONE_NUMBER>, 0.1 )
    , ( Date.fromTime<PHONE_NUMBER>, 0.132 )
    , ( Date.fromTime<PHONE_NUMBER>, 0.063 )
    , ( Date.fromTime<PHONE_NUMBER>, 0.059 )
    , ( Date.fromTime<PHONE_NUMBER>, 0.078 )
    , ( Date.fromTime<PHONE_NUMBER>, 0.054 )
    , ( Date.fromTime<PHONE_NUMBER>, 0.057 )
    , ( Date.fromTime<PHONE_NUMBER>, 0.167 )
    , ( Date.fromTime<PHONE_NUMBER>, 0.063 )
    , ( Date.fromTime<PHONE_NUMBER>, 0.057 )
    , ( Date.fromTime<PHONE_NUMBER>, 0.061 )
    , ( Date.fromTime<PHONE_NUMBER>, 0.07 )
    , ( Date.fromTime<PHONE_NUMBER>, 0.126 )
    , ( Date.fromTime<PHONE_NUMBER>, 0.126 )
    , ( Date.fromTime<PHONE_NUMBER>, 0.436 )
    , ( Date.fromTime<PHONE_NUMBER>, 0.068 )
    , ( Date.fromTime<PHONE_NUMBER>, 0.067 )
    ]

Yikes, that's...a lot. 😅
Could you get that down to a SSCCE?

The SVG path says it's expecting a number but given a string. This is odd, because paths are supposed to be strings. But what's even more interesting is that NaN appears in the string. I've gotten DOM errors in D3 (a JS library) when doing the same thing, so that's likely something to focus on. You can obtain NaN is Elm with 0/0 (verify with isNaN).

@rtfeldman Sorry, probably not. Because this is based on the example @gampleman wrote. So to reproduce the error it require the boilerplate of the visualization library. The only difference between his and mine is the model = [...] part. Anyway I would try to downsize it for you.

@mgold I found that the exception seems to appear when there are three same dates back to back in a row.  Like this one:
 ( Date.fromTime<PHONE_NUMBER>, 0.107 )
    , ( Date.fromTime<PHONE_NUMBER>, 0.266 )
    , ( Date.fromTime<PHONE_NUMBER>, 0.285 )

So there are three things going on here:

The SVG library throws a runtime exception when passed an invalid parameter to the d attribute. This violates the "no-runtime exceptions" promise. AFAIK there is no easy solution to this problem, but I'm trying to get some momentum going for a more type safe SVG library (see elm-dev for that, although the current proposal wouldn't solve this problem).

elm-visualization produces this invalid data. Let's tackle that in gampleman/elm-visualization#3.

The underlying cause is that float math is unsafe for this purpose and can produce NaN values. Some of this is tracked in https://github.com/elm-lang/core/issues/721.

Thank you @gampleman . I'm going to close this issue since elm-visualization produces the invalid data.


[WIP] luci-app-ddns: rework with new ddns changes

This commit rework the app with the new ddns changes. DDns services are now stored in a dedicated list and the service specific data is stored in a dedicated json. This json can both preinstalled with a companion package or be downloaded on demand. The new app now check if the script is present and give a button to install it if not present in the system.
The app now reset the ddns rule settings on service change.
Also rework the app to drop any global function and rework the function to use more default way to get data.
@feckert this should be the changes needed. Can you check and give some suggestion about variable naming (it's a mess) and if i miss something of the new feature?
(in short, I added

the global ca_cert and url option
in status a way to get last modified services list
button to update the list by calling your script

A button with switch service will show up when you change service name or ip addres
When the button is click the app check if the json is present
If it's not present a button with install service show up (and call your script if pressed)
If the downloaded script doesn't support ipv6 and ipv6 is selected, a message is shown and nothing can be set
)

If i miss something tell me.
Changes to do would be drop the services cacert and use directly the global option and test the new app.
Also this lacks of the custom_list file that we still need to introduce in the makefile in some way. (adding this feature will be straightforward since it will be the same function used the standard list)
This depends on P/R openwrt/packages#13509
Signed-off-by: Ansuel Smith<EMAIL_ADDRESS>

This commit rework the app with the new ddns changes. DDns services are now stored in a dedicated list and the service specific data is stored in a dedicated json. This json can both preinstalled with a companion package or be downloaded on demand. The new app now check if the script is present and give a button to install it if not present in the system.

I would suggest that we check in the new ddns shell script if we have installed the ddns-scripts_service package with opkg and if so we show a message that we could not install services on demand. If you want to install new services you have to remove with opkg the ddns-scripts_service first. (By the way as mentioned by @jow- we should rename the package to ddns-scripts-services)

* the global ca_cert and url option

Yes this are the new option I have added to the globals section to download the service list with the new ddns script.

* in status a way to get last modified services list

I think this is not needed.

* button to update the list by calling your script

Only available if we have not installed the ddns-scripts_service with opkg.

1. A button with switch service will show up when you change service name or ip addres

I think we should change the /etc/init.d/ddns to procd, so the services gets restarted if the config has changed. So we do not need this handling. Or do I get something wrong.

2. When the button is click the app check if the json is present

Can you please describe exactly what you mean. If this is a about installing custom services, then this button should only visible if we have not installed the ddns-scripts_service package. If the package is not installed then we could download the list file from github.

3. If it's not present a button with install service show up (and call your script if pressed)

Can you please describe exactly what you mean.

4. If the downloaded script doesn't support ipv6 and ipv6 is selected, a message is shown and nothing can be set

As I can see in the current LuCI source of luci-app-ddns we have one drop-down for ipv4 and one ipv6 services. So we should parse the json files on load and add the service to the individual service list for ipv4 and ipv6

If i miss something tell me.
Changes to do would be drop the services cacert and use directly the global option and test the new app.

I am not sure this is applicable for the whole ddns service the ca_cert and url option are only for the custom ddns service load.
The individual uci service section need there own ca_cert and url options I think.

Also this lacks of the custom_list file that we still need to introduce in the makefile in some way. (adding this feature will be straightforward since it will be the same function used the standard list)

If we check that the ipkg package ddns-scripts_service is installed we do not need the custom_list.
Now the only question is what to do with the special services that come with a script. Either we delete the packages and move the files into the ddns-sciprts_service package, so that we only have ddns-scripts and ddns-script-service or we change the list file in a preinst hook to add them to this list, so they could be selected.

I would suggest that we check in the new ddns shell script if we have installed the ddns-scripts_service package with opkg and if so we show a message that we could not install services on demand. If you want to install new services you have to remove with opkg the ddns-scripts_service first. (By the way as mentioned by @jow- we should rename the package to ddns-scripts-services)

Mh yes I should add some check about the "all service" script. But do we really need it? If all it does is preinstall all the script for the luci-app it won't change anything since it will notice that the script is already available.

I think this is not needed.

Just a debug info...  ok will remove (was usefull to check how old was the script)

Only available if we have not installed the ddns-scripts_service with opkg.

I can add this check but again is it a problem if the list gets updated with the service package installed?

I think we should change the /etc/init.d/ddns to procd, so the services gets restarted if the config has changed. So we do not need this handling. Or do I get something wrong.

Was talking to something else... think a gif is better to answer also the other question.

(the dropdown list is not showed...)

As I can see in the current LuCI source of luci-app-ddns we have one drop-down for ipv4 and one ipv6 services. So we should parse the json files on load and add the service to the individual service list for ipv4 and ipv6

I removed all the complexity (by adding others ....) and the app now have one list and check if the service supports ipv6.

I am not sure this is applicable for the whole ddns service the ca_cert and url option are only for the custom ddns service load.
The individual uci service section need there own ca_cert and url options I think.

I think it's redundant to have one global option for cacerts and every service section has their own. But yes can be useful if someone for some reason wants to skip cert validation for a specific service

If we check that the ipkg package ddns-scripts_service is installed we do not need the custom_list.

Think the custom_list is a must. Since we have scripts that can replace the normal list, a simple post-inst script is not enough since the changes can be erased by the ddns script.

Now the only question is what to do with the special services that come with a script. Either we delete the packages and move the files into the ddns-sciprts_service package, so that we only have ddns-scripts and ddns-script-service or we change the list file in a preinst hook to add them to this list, so they could be selected.

I still think that they should be separated (since they can't be downloaded on demand since an additional script is needed). This is why we need a custom_list to handle this special case. (The special pkg will execute a postinst on the custom_list that will not be touched by any script)

@Ansuel There were already some comments and complaints on the mailing list!

https://lists.openwrt.org/pipermail/openwrt-devel/2020-September/031507.html
https://github.com/openwrt/packages/issues/13495

We should fix the ddns-scripts package for the next stable release.
I would suggest that I rename the package ddns-scripts_service to ddns-scripts-services as suggested by jow- .
For now we should not concentrate on loading providers on demand.
We should concentrate to make the luci-app-ddns working again so that if the ddns-scripts-service package is installed then the services could selected again.
The way I see it many people use the master branch!!
And it is broken now.
Next time I think I should not merge anything before we have updated the LuCI as well.
But that was my mistake!

@feckert give me a sec

@feckert Was thinking can we keep the list file? I know it will be redundant, since we will install all the services but having a list will be very useful when we will enable the "service on demand" feature in the future.

I changed the app to not depend on the presence of the service list.
(the app will enumerate the services based on the json present in the services directory and then optionally on the services in the list, if present).
The button to download the list is still present but will complain about not find the list. (clicking on it will simply download the list and add the missing services if any)
I think for the future we will need to add a feature to autodownload the json if is not present and a config exist for it.

This depends on P/R https://github.com/openwrt/packages/pull/13509

@feckert I updated the app with the new directory scheme. Should I squash the 3 commits to one?

Looks pretty good already.
But if we create a new service and select ipv4 or ipv6, can we not offer only those drop-down services that support it.
Now I can choose IPv6 and then select a service that does not support ipv6?

Problem is that since we merged ipv4 and ipv6 service in one json file, for optimization reason and to not scan 50+ json file by the webui, the service support for both ipv4 and ipv6 is evaluated only when is selected and saved. I can try to find a workaround for this, but I find the use of the 'switch service' button cleaner and easier to implement.
Anyway as I showed in the gif, selecting a ipv6 + a service not supported, results in an alert and the hide of all the required option to configure the ddns rule.
(to sum up. the service list is generated only on the json it does find, it doesn't actually opens it and check the contents)

Problem is that since we merged ipv4 and ipv6 service in one json file, for optimization reason and to not scan 50+ json file by the webui, the service support for both ipv4 and ipv6 is evaluated only when is selected and saved. I can try to find a workaround for this, but I find the use of the 'switch service' button cleaner and easier to implement.

Have you ever looked to see if this really has such a big impact on the performance?

Anyway as I showed in the gif, selecting a ipv6 + a service not supported, results in an alert and the hide of all the required option to configure the ddns rule.

I use the new openwrt-theme-2020 and I have to look twice to see the hint.
The other option would be if this could not be validated at runtime, we could check it during creation and then issue an error message that this service does not support this proto. The advantage would be that the service is not created.

Have you ever looked to see if this really has such a big impact on the performance?

Nope but I see it as a waste.

I use the new openwrt-theme-2020 and I have to look twice to see the hint.

Strange. What should happen is, select a new service, click switch service, then the ui tells you if the service is not supported or show more option.

The other option would be if this could not be validated at runtime, we could check it during creation and then issue an error message that this service does not support this proto. The advantage would be that the service is not created.

Yes for the creation I should be able to add this check and stop the save of the rule.

@feckert ok... done some magic... I added some type of promise validation...
Anyway when the user change the ip or the service, the service is set invalid. When the service check is done a new validation is fired with the new data.
The result is that if the service doesn't support ipv6, the ddns rule can't be created. (If the service is not installed, the service is valid by default). The same logic applies for ddns rule already created, if someone try to change the service and ipv6 is not supported, the service button is disabled.

Very nice :+1:
But I found out that if no default service is installed and I press the download button the services are not displayed. Only when I clear my browser cache. @Ansuel could you also seed this on your setup?

@feckert think I undestrand what you mean... And I already notice that.
If no default service is installed and no list is downloaded, pressing the 'update services list' doesn't change anything and a reload is needed to show the new services. Is this what you mean?
Anyway I changes how the app gets services list and now it's updated when you press the 'update services list' and when the service is installed...
Tell me if I got this wrong.

@Ansuel I have merged the depended pullrequest.
@jow- I am not sure what the policy is. Should with stash the commit to one? Because it is a big change or leave it as it is.

Personally I'm from the stash since the other commits are here just to show progress since they can't be applied individually...

@Ansuel could you please fixup your commits?
I have already merged the ddns changes.
To get back to a working state for LuCI also we should merge your changes as fast as possible.

What changes should I do?

What changes should I do?

I don't want to do anything wrong when I click the webbutton to squash and merge.
I have not done that yet.
Which commit message does he use then if all commits are squashed into one if I use the button?
So I thought you could squash them.

If i remember correctly, It will tell what commits message to set. Give me a sec and I squash them and force push.

@feckert done


cmd/go: Cross-compilation static library from Windows to ARM64 Linux fails to recognize AR environment variable

Go version
go version go1.22.4 windows/amd64
Output of go env in your module/workspace:
set GO111MODULE=
set GOARCH=amd64
set GOBIN=
set GOCACHE=C:\Users\wukeke\AppData\Local\go-build
set GOENV=C:\Users\wukeke\AppData\Roaming\go\env
set GOEXE=.exe
set GOEXPERIMENT=
set GOFLAGS=
set GOHOSTARCH=amd64
set GOHOSTOS=windows
set GOINSECURE=<IP_ADDRESS>
set GOMODCACHE=C:\Users\wukeke\go\pkg\mod
set GONOPROXY=<IP_ADDRESS>
set GONOSUMDB=<IP_ADDRESS>
set GOOS=windows
set GOPATH=C:\Users\wukeke\go
set GOPRIVATE=<IP_ADDRESS>
set GOPROXY=https://goproxy.cn,direct
set GOROOT=C:\Program Files\Go
set GOSUMDB=sum.golang.org
set GOTMPDIR=
set GOTOOLCHAIN=auto
set GOTOOLDIR=C:\Program Files\Go\pkg\tool\windows_amd64
set GOVCS=
set GOVERSION=go1.22.4
set GCCGO=gccgo
set GOAMD64=v1
set AR=ar
set CC=gcc
set CXX=g++
set CGO_ENABLED=1
set GOMOD=NUL
set GOWORK=
set CGO_CFLAGS=-O2 -g
set CGO_CPPFLAGS=
set CGO_CXXFLAGS=-O2 -g
set CGO_FFLAGS=-O2 -g
set CGO_LDFLAGS=-O2 -g
set PKG_CONFIG=pkg-config
set GOGCCFLAGS=-m64 -mthreads -fno-caret-diagnostics -Qunused-arguments -Wl,--no-gc-sections -fmessage-length=0 -ffile-prefix-map=C:\Users\wukeke\AppData\Local\Temp\go-build3614417178=/tmp/go-build -gno-record-gcc-switches

What did you do?
test code
$ cat test.go
package main

import "C"
import "fmt"

//export test
func test() {
        fmt.Println("just test")
}

func main() {

}

cross-tools
$ aarch64-linux-gnu-ar -V
GNU ar (Linaro_Binutils-2019.12) <IP_ADDRESS>70706
Copyright (C) 2017 Free Software Foundation, Inc.
This program is free software; you may redistribute it under the terms of
the GNU General Public License version 3 or (at your option) any later version.
This program has absolutely no warranty.

build command
$ CC=aarch64-linux-gnu-gcc CXX=aarch64-linux-gnu-g++ AR=aarch64-linux-gnu-ar CGO_ENABLED=1 GOOS=linux GOARCH=arm64 GOARM=7 go build -ldflags "-s -w" -buildmode=c-archive -o test.a test.go
What did you see happen?

command-line-arguments
C:\Program Files\Go\pkg\tool\windows_amd64\link.exe: running ar failed: exec: "ar": executable file not found in %PATH%

What did you expect to see?
The go build command should successfully use the aarch64-linux-gnu-ar tool as specified by the AR environment variable.

by the way
If I copy aarch64-linux-gnu-ar.exe to ar.exe, then the compilation can succeed.

Related Issues and Documentation

cross compile dynamic library for arm on linux/amd64 #39106 (closed)
Error building a simple program with GOOS=darwin GOARCH=arm64 environment variables #39033 (closed)
cmd/link: add internal linking support for pie build mode on arm #50405
cmd/link: cross compile from MacOS to Windows with CGO_ENABLED=1 and -buildmode=c-archive not working #59221 (closed)
GOARCH error #64264 (closed)
In arm64 environment, c# calls go dll exception #66833 (closed)
cmd/compile: cross compiled arm64 binary can not execute and no response, the program seem to be hung #65361
cmd/go: get ignores GOARCH environment variable #36022 (closed)
GOOS=android GOARCH=arm doesn't compile on amd64 #17736 (closed)
cmd/go: error: unrecognized command line option '-rdynamic' when cross-compiling to ARM with -pie #36633

(Emoji vote if this was helpful or unhelpful; more detailed feedback welcome in this discussion.)

  Maybe they should.
You can do what you want using -ldflags=-extar=$AR.

Does it look at AR only for gccgo? https://go.googlesource.com/go/+/b3040679ad0eccaaadb825ed8c0704086ecc23eb/src/cmd/go/internal/work/gccgo.go#50

Yes, that is how it works today.  Which does seem odd.  I think it happened because gccgo has needed to run ar from the start, but the gc toolchain only started using ar later on as part of supporting -buildmode=c-archive.

At tip, specifically after CL 592375, the linker now uses $CC --print-prog-name ar to find the ar command (if the -extar flag is not explicitly set). So setting CC=aarch64-linux-gnu-gcc should be enough for it to find the right ar. Could you try the tip of the master branch, or Go 1.23rc1? Thanks.


🐛 Bug: Accessibility issue on mochajs.org: scrollable region missing keyboard focus

Bug Report Checklist

[X] I have read and agree to Mocha's Code of Conduct and Contributing Guidelines
[X] I have searched for related issues and issues with the faq label, but none matched my issue.
[X] I have 'smoke tested' the code to be tested by running it outside the real test suite to get a better sense of whether the problem is in the code under test, my usage of Mocha, or Mocha itself.
[X] I want to provide a PR to resolve this

Expected
The website should not have any accessibility issues - including ones detectable by the axe browser devtools.
Actual
Several code blocks, such as the const assert = require('assert'); code block under https://mochajs.org/#delayed-root-suite, are a scrollable region without keyboard focus. That makes them unusable for users who scroll with non-mouse devices - such as keyboards.
Minimal, Reproducible Example

Visit https://mochajs.org
Wait for the page to load & fade in
Run the axe browser devtools

Versions
n/a
Additional Info
https://web.dev/explore/accessible explains more around web accessibility.
I first ran a Lighthouse accessibility audits but it didn't wait for the page to fade in and reported many false negatives as a result.

The site's tooling is a little old and I'm not sure that it'll be straightforward to fix this until #5071 bumps our site-related devDependencies to latest. Removing good first issue and unassigning myself for now.
If someone is familiar with markdown-it and prism, and knows that there's an easy fix in the older versions we use, please do go ahead and fix it in the meantime! But otherwise I'll wait to take action till #5071 is in.


fix:log_spam

Summary by CodeRabbit

New Features

Introduced logging for deprecated properties in the IntentService, enhancing user awareness of upcoming changes.

Bug Fixes

Restructured import statements for better organization and clarity.

Documentation

Added comments regarding future changes related to locale management in skills.

All good.


About  amorphous polyphenylene calculation

Dear Prof. Minamitani,
Currently, I am calculating the thermal conductivity of amorphous polyphenylene using the pyAF software you developed. I have prepared the structure file and performed the calculation with reference to the case you provided. The difference with the case you provided is that my Lammps file is in real units, so I have post-processed the output dynamic matrix (i.e. multiplied by 0.042 to convert Kcal/mol to eV  in energy unit). However, I got an unusually high thermal conductivity result (above 9000 W/mK). I would appreciate any guidance you can give me.  Thank you for your time.
Xiang Huang
25 October 2023

Thank you,Prof. Minamitani. I've sorted this problem.

Thank you for your information. Could you let me know how you solved the issue?  (another user may faced the same problem)

Mostly following your provided case. I just tightened the convergence criterion for structural relaxation and turned off the "symmetrize_fc" option. Thank you.

Thank you so much for your information!


Fix 404 error on Serve Static Middleware

There will be a 404 error when non-standard characters appear in URL. Add decodeURI() to fix it.

Hi @BioniCosmos !
Thanks! It's a good fix. I'll merge it.


d2 support

I'm finding Terrastruct's D2 to be really useful for architecture diagrams and I'd love for it to be better integrated into slidev.
https://github.com/terrastruct/d2
Describe the solution you'd like
Ideally, I'd be able to have the D2 diagram code in the slidev project, and it would be updated automatically, like mermaid.js
Describe alternatives you've considered
At the moment, to use it, I create diagrams in /diagrams, e.g. /diagrams/08-dead-letter.d2
style: {
  fill: transparent
}

direction: right

lambda: Lambda
lambda: {
  icon: https://icons.terrastruct.com/aws%2FCompute%2FAWS-Lambda.svg
}
sqs: SQS DLQ
sqs: {
  icon: https://icons.terrastruct.com/aws%2FApplication%20Integration%2FAmazon-Simple-Queue-Service-SQS.svg
}
eb: "EventBridge"
eb: {
  icon: https://icons.terrastruct.com/aws%2FApplication%20Integration%2FAmazon-EventBridge.svg
}
cloudwatch: CloudWatch Alarm
cloudwatch: {
  icon: https://icons.terrastruct.com/aws%2FManagement%20&%20Governance%2FAmazon-CloudWatch.svg
}
sns: SNS
sns: {
  icon: https://icons.terrastruct.com/aws%2FApplication%20Integration%2FAmazon-Simple-Notification-Service-SNS.svg
}
eb -> lambda: event
lambda -> sqs: onFailure
sqs <- cloudwatch: Check depth
cloudwatch -> sns: Notify OpsGenie

Then run a script in that directory to generate everything and move it to public.
ls *.d2 | xargs -I {} ~/go/bin/d2 --layout=elk --theme=200 {}
mv *.svg ../public

I then have to put a link to the SVG diagram in my presentation.
<img src="/01-static.svg" style="width: 100%; height: 100%;" />

It's OK, but native support would be ideal.

Very interesting.
There seem to already be a browser (WASM) build of d2, used for the playground (and currently being improved https://github.com/terrastruct/d2/pull/436 ) so it could be directly integrated in the browser, like mermaid, without running external tools.

Can this be re-opened?

Can this be re-opened?

Markdown transformer is now supported. Making an addon that renders D2 diagrams in your slides is possible.


core dump

Dear author, I will report an error when I use the following command, if you know the relevant solution, please let me know, thank you very much！
./Examples/Monocular/mono_euroc ./Vocabulary/ORBvoc.txt ./Examples/Monocular/EuRoC.yaml /home/xt/project/dataset/MH_02_easy ./Examples/Monocular/EuRoC_TimeStamps/MH01.txt dataset-MH01_mono
num_seq = 1
file name: dataset-MH01_mono
Loading images for sequence 0...LOADED!

ORB-SLAM3 Copyright (C) 2017-2020 Carlos Campos, Richard Elvira, Juan J. Gómez, José M.M. Montiel and Juan D. Tardós, University of Zaragoza.
ORB-SLAM2 Copyright (C) 2014-2016 Raúl Mur-Artal, José M.M. Montiel and Juan D. Tardós, University of Zaragoza.
This program comes with ABSOLUTELY NO WARRANTY;
This is free software, and you are welcome to redistribute it
under certain conditions. See LICENSE.txt.
Input sensor was set to: Monocular
Loading ORB Vocabulary. This could take a while...
Vocabulary loaded!
Creation of new map with id: 0
Creation of new map with last KF id: 0
Seq. Name:
Camera Parameters:

Camera: Pinhole
fx:<PHONE_NUMBER>9921875
fy:<PHONE_NUMBER>9023438
cx:<PHONE_NUMBER>3789062
cy: 248.375
k1: -0.28340810537338257
k2: 0.073959067463874817
p1: 0.00019359000725671649
p2: 1.7618711353861727e-05
fps: 20
color order: RGB (ignored if grayscale)

ORB Extractor Parameters:

Number of Features: 1000
Scale Levels: 8
Scale Factor: 1.2000000476837158
Initial Fast Threshold: 20
Minimum Fast Threshold: 7

Failed to load image at: /home/xt/project/dataset/MH_02_easy/mav0/cam0/data/1403636579763555584.png
core dump

dear @Xuheyi
You have imported the dataset MH_02_easy while you have imported the Timestamp file equal to MH01.txt dataset-MH01_mono. These two files must belong to the same dataset.

sorry,it is my error,It should be this follow:
./Examples/Monocular/mono_euroc ./Vocabulary/ORBvoc.txt ./Examples/Monocular/EuRoC.yaml ./dataset/MH01 ./Examples/Monocular/EuRoC_TimeStamps/MH01.txt dataset-MH01_mono
num_seq = 1
file name: dataset-MH01_mono
Loading images for sequence 0...LOADED!

ORB-SLAM3 Copyright (C) 2017-2020 Carlos Campos, Richard Elvira, Juan J. Gómez, José M.M. Montiel and Juan D. Tardós, University of Zaragoza.
ORB-SLAM2 Copyright (C) 2014-2016 Raúl Mur-Artal, José M.M. Montiel and Juan D. Tardós, University of Zaragoza.
This program comes with ABSOLUTELY NO WARRANTY;
This is free software, and you are welcome to redistribute it
under certain conditions. See LICENSE.txt.
Input sensor was set to: Monocular
Loading ORB Vocabulary. This could take a while...
Vocabulary loaded!
Creation of new map with id: 0
Creation of new map with last KF id: 0
Seq. Name:
Camera Parameters:

Camera: Pinhole
fx:<PHONE_NUMBER>9921875
fy:<PHONE_NUMBER>9023438
cx:<PHONE_NUMBER>3789062
cy: 248.375
k1: -0.28340810537338257
k2: 0.073959067463874817
p1: 0.00019359000725671649
p2: 1.7618711353861727e-05
fps: 20
color order: RGB (ignored if grayscale)

ORB Extractor Parameters:

Number of Features: 1000
Scale Levels: 8
Scale Factor: 1.2000000476837158
Initial Fast Threshold: 20
Minimum Fast Threshold: 7
First KF:0; Map init KF:0
New Map created with 103 points
Point distribution in KeyFrame: left-> 103 --- right-> 0
core dump

But when I make :
./Examples/Monocular-Inertial/mono_inertial_euroc ./Vocabulary/ORBvoc.txt ./Examples/Monocular-Inertial/EuRoC.yaml ./dataset/MH01 ./Examples/Monocular-Inertial/EuRoC_TimeStamps/MH01.txt dataset-MH01_monoi
It can work,do you konw why?thank you

Unfortunately, I have no idea about this problem. I have developed only a part of this algorithm.
It is better to ask your question on the main page of this algorithm
https://github.com/UZ-SLAMLab/ORB_SLAM3