locale bundling problem

I implement locales as es6 modules in my application. Each locale module imports locale information from any 3rd party libraries used along with message translations etc. Activating a locale is done by importing the locale module (using systemjs) at runtime.
An example locale module (fr.ts):
import {IntlLocaleData} from '../services/intl-service'; // my locale data interface
import ng2IntlData from 'ng2-intl/locale-data/fr'; // locale data for ng2-intl library
import 'moment/locale/fr'; // moment's locale data (fr)
import messages from '../../../src/i18n/fr.json'; // my application messages (fr)

export default <IntlLocaleData>{
    // data for ng2-intl
    ng2Intl: {
        locale: "fr-FR",
        data: ng2IntlData
    },
    // moment locale name (data is auto defined by importing the moment locale)
    moment: {
        locale: "fr"
    },
    // my messages
    messages: messages
};

The problem I have is with the moment locale automatically calling moment.defineLocale when loaded. When I bundle my locale (using rollup) I make moment an external (I don't want to bundle an instance of moment with each locale) but then the call to defineLocale is problematic. I have worked around this by using rollup's ability to inject code into the generated bundle and creating a fake moment but it's pretty messy.
A big ask I know, but I wonder whether you would consider shipping an alternative version of the locale data which doesn't import moment and just returns the data? Something like this (eg locale-data/fr.js):
export default locale(moment) {
    return { // same object as is passed to defineLocale
        months : 'janvier_février_mars_avril_mai_juin_juillet_août_septembre_octobre_novembre_décembre'.split('_'),
        monthsShort : 'janv._févr._mars_avr._mai_juin_juil._août_sept._oct._nov._déc.'.split('_'),
        // etc...
    };
};

Files like these could be shipped next in a separate folder (eg locale-data) next to the current locale folder. To use you would do something like this:
import moment from 'moment';
import localeData from 'moment/locale-data/fr';

moment.defineLocale('fr', localeData(moment));

moment is passed in as a parameter to the locale function to allow access to moment. (The zh-cn locale uses moment in calendar.nextWeek/lastWeek.)
As I say, it's not a blocker for me, but I think there's merit to the approach?

I understand what you are saying, and I think we would take a pull for this. I don't think it will be a development priority for our core team unless there were quite a bit more interest.

Funny - over 2 years on, but I just ran into precisely this same scenario with my own codebase. We're using webpack and I'm finding I'm having to explore similar workarounds.
Having the locale data exported just as data would solve it for me too.

Would there still be any interest in a pull request for this? I'd be happy to put something in.
The source code for the locales appears to be in this folder, e.g. Afrikaans:
https://github.com/moment/moment/blob/develop/src/locale/af.js
What we could do was create a new folder to house the standalone locale data, e.g.
moment/locale-data/
That would contain af.js, fe.js files etc in es6 format, with a default export like so:
export default {
    months : 'Januarie_Februarie_Maart_April_Mei_Junie_Julie_Augustus_September_Oktober_November_Desember'.split('_'),
    monthsShort : 'Jan_Feb_Mrt_Apr_Mei_Jun_Jul_Aug_Sep_Okt_Nov_Des'.split('_'),
    weekdays : 'Sondag_Maandag_Dinsdag_Woensdag_Donderdag_Vrydag_Saterdag'.split('_'),
   ...
}

Then the original source file (https://github.com/moment/moment/blob/develop/src/locale/af.js) would be changed to simply import the data from that source.
import moment from '../moment';
import af from '../locale-es6';

export default moment.defineLocale('af', af);

That'll allow people to import the locale data in plain es6 format and shouldn't affect any of the existing build code for moment.

See https://momentjs.com/docs/#/-project-status/


Allow markdown in Intros and Outros as an alternate to plain text

Should (at least partly) solve #17.

All fields markdown support will be awesome.

Hey guys, is there a reason why this still hasn't been merged ? It's a pain to only have plaintext in intros and outros :(

@PetitCassoulet @ruqqq
I have forked this repo to: https://github.com/go-hermes/hermes
I have implemented this PR here https://github.com/go-hermes/hermes/pull/6


Cleaning $KONG_PREFIX/worker_events.sock file

What this PR does / why we need it:
Fix for Kong pod is getting crashloopback after abrupt shutdown #836
Which issue this PR fixes
Kong pod is getting crashloopback after abrupt shutdown #836
Special notes for your reviewer:
Checklist
[Place an '[x]' (no spaces) in all applicable fields. Please remove unrelated fields.]

[ ] PR is based off the current tip of the main branch.
[ ] Changes are documented under the "Unreleased" header in CHANGELOG.md
[ ] New or modified sections of values.yaml are documented in the README.md
[ ] Commits follow the Kong commit message guidelines

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.


Add option to group fragments into a fewer number of files

Currently Pagefind outputs a unique result fragment for every html page indexed, which provides the lowest possible bandwidth for loading a result.
In some scenarios, number of individual files might pose an issue. For these environments, Pagefind should have an option to group fragments by N. This would (very slightly) increase bandwidth usage, as to load a result you would need to load a file containing N results (these files are typically <1KB as it stands, so not too dramatic). The benefit of this option would be that the number of fragment files output would be divided by N.
An example with usage:
npx pagefind --source "public"
ls public/_pagefind/fragment/ | wc -l # 6000 files

npx pagefind --source "public" --group-fragments 3
ls public/_pagefind/fragment/ | wc -l # 2000 files

:+1:


kitchen driver command gives bad help message

Description
kitchen driver command gives bad help message
ChefDK Version
1.3.40
Platform Version
Ubuntu 16.04
Replication Case
Just type kitchen driver

Says  kitchen driver driver create [NAME]. Has two drivers, only needs 1.
NOTE: CHEFDK BUGS ONLY
This issue tracker is for the code contained within this repo -- chefdk.

Server issues
Chef-client issues
Cookbook Issues (see the https://github.com/chef-cookbooks repos or search Supermarket or GitHub/Google)

This issue already exists on test-kitchen and isn't a ChefDK specific issue. Closing as dupe of https://github.com/test-kitchen/test-kitchen/issues/540


DBZ 6408 Add docs on how to extend channels and notification

closes: https://issues.redhat.com/browse/DBZ-6408

@roldanbob let me know if you need details on this

@roldanbob adresses your suggestions. Do you think we are now in a good point?

@roldanbob your suggestions addressed. Do you think we are now in a good point?

Yes, @mfvitale, I think you're good to go now! Thanks for your patience!

@mfvitale @roldanbob Applied, thanks!


Reliable build

Is there a way how to reliably build a version of this program?
I tried with the following script:
cd "path/to-source"
GOPATH="path" go get -fix -v -x github.com/prasmussen/gdrive
GOPATH="path" go build -o "path/bin/gdrive"

It worked a while but then it failed with:
./drive.go:98: not enough arguments in call to cli.List
./drive.go:101: not enough arguments in call to cli.Info
./drive.go:124: not enough arguments in call to cli.DownloadLatest
./drive.go:126: not enough arguments in call to cli.Download
````
I think this is related with the lacking dependency management in go.

The `build-all.sh` script is no help at all, since it seems to presume that specific binaries (no, `go-linux-386` is not part of the official go tarball) and scripts (like `/Users/pii/scripts/golang-crosscompile/crosscompile.bash` exist. Why is this checked in at all?

So, how can I specify the versions needed for a reliable build (of a tag) and which version do I need?

The reason for this request is that I want to provide a PKGBUILD for Arch Linux (so that Arch users can install this program via their package manager). ([Repeo](https://github.com/kleinph/gdrive-pgkbuild) | [Package](https://aur.archlinux.org/packages/gdrive)).

Thanks

gdrive 2 should be easier to build. I've added compile instructions to the readme (it assumes you have GOPATH set though).


The mui/styles peer dependency used in this package is deprecated and can't be used for React v18

The latest package is not compatible with React v18 as the dependency mui/styles used here is deprecated according to the mui documentation here https://mui.com/system/styles/basics .
Can we get the new version compatible with react v18 without using mui/styles which is deprecated without causing peer dependency conflicts?

I have the same issue

Same here

same issue here :(

same here

same


Update the parser to quote 1.0

This updates the parser from using quote 0.3 to using quote 1.0 and
proc_macro2.

@Erk- please rebase over master branch, it appears that one of the merged PRs broke this one.

@patrickelectric Rebased it


Here's some errors when yarn

1. The problem when I met

this is a question when I run the project on my pc

2. Describe Problem

when I download this project and run the code, it's reporting some errors, I just want to run its example correctly

3. what I have done

I just do this codes

cd draggable-master/examples
yarn start

it's just a little wrong, but I can't drag anything...
I have tried anything I can do, but these elements don't respond anything no matter how I drag or click

here's some pictures

@tsov

@tsov


[Service Bus] Update CI to delete/create resources before each tests

Now that we have #1164 merged, we should update our CI as well
This basically involves

Follow the set up in the description of #1164 to register new application in AAD
Grant access to the test subscription
Store all the secrets in Keyvault and use env variables in CI to fetch them

ARM_SERVICEBUS_CLIENT_ID
ARM_SERVICEBUS_SECRET
ARM_SERVICEBUS_TENANT_ID
RESOURCE_GROUP
SERVICEBUS_NAMESPACE
AZURE_SUBSCRIPTION_ID

Set an environment variable CLEAN_NAMESPACE to true when we are ready to do the delete/create

cc @mikeharder

The names ARM_SERVICEBUS_CLIENT_ID, ARM_SERVICEBUS_TENANT_ID, ARM_SERVICEBUS_SECRET are misleading.
AAD_CLIENT_ID, AAD_TENANT_ID, AAD_SERVICEBUS_SECRET are the new env vars.

Populate the following variables in the .env.

AAD_CLIENT_ID=""
AAD_SERVICEBUS_SECRET=""
AAD_TENANT_ID=""
RESOURCE_GROUP=""
SERVICEBUS_NAMESPACE=""
AZURE_SUBSCRIPTION_ID=""

@HarshaNalluru We don't need SERVICEBUS_NAMESPACE right? We can get this information from the connection string that we already have

1a1821c

That looks good, can you send a PR?

Done as part of https://github.com/Azure/azure-sdk-for-js/pull/1202

@mikeharder  Final variables.
AAD_CLIENT_ID=""
AAD_SERVICEBUS_SECRET=""
AAD_TENANT_ID=""
RESOURCE_GROUP=""
AZURE_SUBSCRIPTION_ID=""
CLEAN_NAMESPACE="true"

Note:

CLEAN_NAMESPACE env variable is used it in testUtils.
If this variable is undefined, then the deletion/creation thing won't happen.


Automatically generate documentation for supported languages and builtin entities

Description:
This will allow to maintain automatically the documentation of:

supported languages
supported builtin entities

Checklist:

[x] My PR is ready for code review
[x] I have added some tests, if applicable, and run the whole test suite, including linting tests
[x] I have updated the documentation, if applicable

Codecov Report

Merging #841 into master will increase coverage by 0.03%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master     #841      +/-   ##
==========================================
+ Coverage   88.86%   88.89%   +0.03%
==========================================
  Files          79       79
  Lines        5108     5108
  Branches      970      970
==========================================
+ Hits         4539     4541       +2
+ Misses        424      423       -1
+ Partials      145      144       -1

Codecov Report

Merging #841 into master will increase coverage by 0.03%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master     #841      +/-   ##
==========================================
+ Coverage   88.86%   88.89%   +0.03%
==========================================
  Files          79       79
  Lines        5108     5108
  Branches      970      970
==========================================
+ Hits         4539     4541       +2
+ Misses        424      423       -1
+ Partials      145      144       -1


PG federated tables listing

This implements listing of remote schemas and tables, from a federated server, registered or not.
A few important remarks:

It does not depend on any extra extension (e.g dblink nor patches in postgres_fdw)
It imports a couple foreign views into the local schema given by __CDB_User_FDW_Object_Names(). The target schema may be changed to avoid conflicts.
Potentially they may return more info, such as the the table_type. I stuck to the essence until we clear out some doubts
IMO there should be functions to list registered tables and to list ALL foreign tables (registered or not). API-wise this may be solved by adding a column registered bool IF we have a solid convention to place federated objects and at the expense of complexity.

@Algunenano at this point I'm more concerned about the interface and the relations between the functions than in the implementation. What do you think?
Thanks!

It does not depend on any extra extension (e.g dblink nor patches in postgres_fdw)
This is great.

@Algunenano at this point I'm more concerned about the interface and the relations between the functions than in the implementation. What do you think?

Agreed. This is going to break against the conventions I'm using for the other functions. Do you mind if I take these functions and incorporate them into my branch / PR in a consistent way?

IMO there should be functions to list registered tables and to list ALL foreign tables (registered or not). API-wise this may be solved by adding a column registered bool IF we have a solid convention to place federated objects and at the expense of complexity.

I'm going to keep them separated for now, we can join them before merge / release.

Do you mind if I take these functions and incorporate them into my branch / PR in a consistent way?

Not at all! On the contrary, I really appreciate it :heart:  Glad we're not stepping too much on each other's toes too.

Closing in favor of Raul's branch


Track local file history across deletions

Type: Bug

Create file foo.txt with some content. Save it
Delete foo.txt
Create bar.txt
Rename bar.txt to foo.txt
Look at TIMELINE
See no history for foo.txt created in step 1.

Normally when one recreates foo.txt you can still see history for it. But in the case where a file is renamed to foo.txt, the history is loss.
VS Code version: Code 1.89.1
OS version: Windows_NT x64 10.0.22631
Modes:

System Info

Item
Value

CPUs
AMD Ryzen 7 5800X3D 8-Core Processor            (16 x 3400)

GPU Status
2d_canvas: enabledcanvas_oop_rasterization: enabled_ondirect_rendering_display_compositor: disabled_off_okgpu_compositing: enabledmultiple_raster_threads: enabled_onopengl: enabled_onrasterization: enabledraw_draw: disabled_off_okskia_graphite: disabled_offvideo_decode: enabledvideo_encode: enabledvulkan: disabled_offwebgl: enabledwebgl2: enabledwebgpu: enabled

Load (avg)
undefined

Memory (System)
31.92GB (16.35GB free)

Process Argv
--crash-reporter-id cca6ff05-6383-4d91-895f-0091516fe9b0

Screen Reader
no

VM
0%

Extensions: none

Thanks for creating this issue! It looks like you may be using an old version of VS Code, the latest stable release is 1.89.1. Please try upgrading to the latest version and checking whether this issue remains.
Happy Coding!

Still an issue in 1.89.1

This feature request is now a candidate for our backlog. The community has 60 days to upvote the issue. If it receives 20 upvotes we will move it to our backlog. If not, we will close it. To learn more about how we handle feature requests, please see our documentation.
Happy Coding!

This is likely just not implemented: a file that is moved to a name that was previously tracked will overwrite said history.
Fair feature request though, as such moving to Backlog.

Hm, something fishy is going on. We already preserve local history across renames but I can see that we seem to replace the last entry after rename, loosing the last edit that was made. Maybe we can preserve it, needs more investigation.

Good catch, we are indeed just dropping previous entries for a file if a file is moved to that file:
https://github.com/microsoft/vscode/blob/70e10d604e1939e9d98f3970f6f19604bfe2852c/src/vs/workbench/services/workingCopy/common/workingCopyHistoryService.ts#L373
A better approach here would be to read the metadata of the entries at the location that is being moved to and merge it with the current entries.

One consequence of this change is that the history for a file entry will be a merge of all changes applied to the previous name(s) and the current name. Since entries are all sorted by time stamp, its harder to follow over a set of changes if you go from oldest to newest entry.

This bug has been fixed in the latest release of VS Code Insiders!
@Pyrolistical, you can help us out by commenting /verified if things are now working as expected.
If things still don't seem right, please ensure you're on version 5e68ffd760038bb156894a87f896910be510accd of Insiders (today's or later - you can use Help: About in the command palette to check), and leave a comment letting us know what isn't working as expected.
Happy Coding!


KAFKA-14852: Propagate Topic Ids to the Group Coordinator for Offset Fetch

This task is the sibling of PR-13378 which propagates topic ids in the group coordinator on the offset commit (write) path. The purpose of this PR is to change the interfaces of the group coordinator and its adapter to propagate topic ids in a similar way on the offset fetch path.
KAFKA-14691 will add the topic ids to the OffsetFetch API itself so that topic ids are propagated from clients to the coordinator on the offset fetch path.
Changes to the persisted data model (group metadata and keys) are out of scope.
There is no functional change in this PR.
Committer Checklist (excluded from commit message)

[ ] Verify design and implementation
[ ] Verify test coverage and CI build status
[ ] Verify documentation (including upgrade notes)

Closing this PR for now as the topic id work will be done later. We can re-open it when we resume the work.


[docs] Add interoperability section for Portal

This PR adds back the interoperability section for the Portal component. It also updates the demos to use the experimentalStyled utility.
Consideration: Once we have the components and componentsProps props on the components we may consider adding a demo for showing how those can be used too for styling the portals inside the other components.
Preview: https://deploy-preview-25575--material-ui.netlify.app/guides/interoperability/#portals

Colors updated


Tenant admin

Category

[x ] Question

Question
I am trying to provision any templates found in the lookbook site and it requires a user to be a tenant admin. Does anyone know how to add a user to become a tenant admin? I have looked as much as I could but drawing blank so far. Thank you.
Environment details
SharePoint Online

https://docs.microsoft.com/en-us/office365/admin/add-users/assign-admin-roles?view=o365-worldwide

I know how to add a user to a role. My question was more specific to the tenant admin role. What is that role name equivalent to?

Global admin / SharePoint admin


Potential perf improvements to result batching

I'm still new to Go and I don't really know what I'm doing but I'll add actual measurements soon.

Benchmark needs cleanup but
+benchcmp master.bench current.bench
benchmark                 old ns/op     new ns/op     delta
BenchmarkBasicQuery-2     53447989      31190472      -41.64%
benchmark                 old allocs     new allocs     delta
BenchmarkBasicQuery-2     145639         138370         -4.99%
benchmark                 old bytes     new bytes     delta
BenchmarkBasicQuery-2     4491280       4392140       -2.21%

@huebnerr same as #47

rebased


Rename Windows script

Rename Windows script Start.ps1 as Start-AntreaAgent.ps1, and rename
Stop.ps1 as Stop-AntreaAgent.ps1.
Signed-off-by: wenyingd<EMAIL_ADDRESS>

/skip-all
/test-windows-all

Let me check them and modify in this change.

Codecov Report

Merging #3904 (dabf823) into main (59fc30a) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main    #3904   +/-   ##
=======================================
  Coverage   35.16%   35.16%
=======================================
  Files         122      122
  Lines       17123    17123
=======================================
  Hits         6022     6022
  Misses      10602    10602
  Partials      499      499

Flag
Coverage Δ

integration-tests
35.16% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Should we name "PrepareNode.ps1" to "Prepare-Node.ps1" to be consistent with other files? I did not check all files to know any other inconsistence.

Checked code, only Start.ps1 ( Start-AntreaAgent.ps1) is uploaded in Antrea assets. All powershell provided by Antrea uses "-" to connect the verb and subject. The "PrepareNode.ps1" you mentioned in windows.md is not the script provided by Antrea, but downloaded from https://github.com/kubernetes-sigs/sig-windows-tools, so is StartKubelet.ps1 which is automatically generated by PrepareNode.ps1. Our own Prepare-Node.ps1 is not referrenced in the documentations or CI scripts, it can be downloaded by delevopers or users only from the code branches.


Lecture 4 Slide 33 Misspelling

The sentence appears to say "To classifier" instead of "To classify" on bullet point #2.

Yep, thanks. 1 point


我怎么同时使用send_static_file函数和jinjia2语法来获得后端传递的数据呢？

我怎么同时使用send_static_file函数和jinjia2语法来获得后端传递的数据呢？

Why do you think we speak Chinese? Please edit your issue to use english.

How do I use the send_static_file function and jinjia2 syntax at the same time to get the data passed by the backend?

Actually, google translate indicates that this is a question about using flask and not about an issue/feature request, so please ask this in another place (Stack Overflow, Discord, etc).


Some Enum value characters are changed to lowercase

Is there an existing issue for this?

[X] I have searched the existing issues

Describe the bug
Some enum values are generated with lower case characters in C#, i.e.
In the graphql schema the enum will look like this:
enum PorMaa {
VA003
VA009
}
But in C# the second character is in lower case, a instead of A
public enum PorMaa
{
Va003,
Va009
}
Bug: The case should be the same.
Steps to reproduce

Relevant log output
No response
Additional Context?
No response
Product
Strawberry Shake
Version
12.6.1

It’s not a bug. We essentially apply naming conventions on top of the types. You override these with directives in the schema.extensions.graphql file.


Live migrator not working after the last checkin

Please provide us with the following information:

This issue is for a: (mark with an x)
- [ ] bug report -> please search issues before submitting
- [ ] feature request
- [ ] documentation issue or request
- [ ] regression (a behavior that used to work and stopped in a new release)

Minimal steps to reproduce

specify source db details, target db details, and lease db details (not used optional field) after specifying the details click on start

No migration start for cosmosdb  and wait for 1 hrs
leasedb created in the target environment, its not take lease specified settings.
I am also using the old migrator(setup 2 months back) it's working fine.

Any log messages given by the failure

no error is shown by after starting the migration, it will be on the same stage, just show source records count, target count always show 0 and no migration start

Expected/desired behavior

new leasedb created on the target database environment, it does not take the setting of specified settings of lease db

Migration did not start for the database

OS and Version?

Windows 7, 8 or 10. Linux (which distribution). macOS (Yosemite? El Capitan? Sierra?)
any version doesn't matter

Versions

not matter

Mention any other details that might be useful

Thanks! We'll be in touch soon.

I have the same issue with the latest.

closing this as the root of this issue is described in issue 8 (leaving issue open it so it is clearer for other users).


⚠ Bofrost.at has degraded performance

In 33029e0, Bofrost.at (https://www.bofrost.at) experienced degraded performance:

HTTP code: 200
Response time: 1775 ms

Resolved: Bofrost.at performance has improved in e013957 after 13 minutes.


Sidekick Bookmarklet RC

This PR has been auto-generated from https://github.com/adobe/helix-sidekick-extension/.

Changes in this release:

https://github.com/adobe/helix-sidekick-extension/pull/439
https://github.com/adobe/helix-sidekick-extension/pull/436


Regression: no longer support the substring function

Describe the bug
Found while working on #10013.
An error was reported stating, This feature is not implemented: Unsupported ast node in sqltorel: Substring.
It worked prior to #10137, but it stopped working after upgrading sqlparser to 0.45.0.
Related to https://github.com/sqlparser-rs/sqlparser-rs/pull/1173
To Reproduce
DataFusion CLI v37.1.0
> select substring('xxxx', 1, 2);
This feature is not implemented: Unsupported ast node in sqltorel: Substring { expr: Value(SingleQuotedString("xxxx")), substring_from: Some(Value(Number("1", false))), substring_for: Some(Value(Number("2", false))), special: true }

Expected behavior
No response
Additional context
No response

take


Will not return the right extension for tar.gz files

I'm sorry, but I'd say this is working as intended. From Wikipedia:

usually the extension is the substring which follows the last occurrence, if any, of the dot character

Matching the first dot would likely result in false matches, like file-v1.2.txt or index.en.html.


Implement parametrized rawquery

How do you thing about spaces in the context of using the templates? SHould we support this?
<< template_name: param1 = value1 || param2 = value2 >>?
I think allowing spaces here and trimming values / params helps for better readability.


Add custom cloud-init script option to cloud-init settings

@andybraren we need to allow user to add his own cloud-init yaml script see https://bugzilla.redhat.com/show_bug.cgi?id=1648317 can you please design something ? User should be able to choose if he wants to use his own script and copy/paste into some text area or use already existing basic hostname/ssh-key config. He cannot use both.

Here's what can be built quickly into the existing wizard:

A new "Use custom script" checkbox should put above Hostname and Authenticated SSH Keys. It is off by default and has an info button next to its label (to assist users who may be unfamiliar).

If the user turns it on, the Hostname and Authenticated SSH Keys fields are hidden entirely and replaced with a resizable "Custom Script" text field for the user to copy/paste their script into.

I should also mention that we have a work-in-progress "Advanced" Step 4 for the Create VM wizard that would contain settings for Cloud-Init/Sysprep and other future features.
This idea is still rough so some fields may not be applicable if "Use custom script" is enabled, but here's what that flow might look like:

This is great! Moving some logic from the first tab will make it less cluttered and more organized.


Update rocksdbjni to 8.11.3

About this PR
📦 Updates org.rocksdb:rocksdbjni from <IP_ADDRESS> to 8.11.3
Usage
✅ Please merge!
I'll automatically update this PR to resolve conflicts as long as you don't change it yourself.
If you'd like to skip this version, you can just close this PR. If you have any feedback, just mention me in the comments below.
Configure Scala Steward for your repository with a .scala-steward.conf file.
Have a fantastic day writing Scala!

⚙ Adjust future updates
Add this to your .scala-steward.conf file to ignore future updates of this dependency:
updates.ignore = [ { groupId = "org.rocksdb", artifactId = "rocksdbjni" } ]

Or, add this to slow down future updates of this dependency:
dependencyOverrides = [{
  pullRequests = { frequency = "30 days" },
  dependency = { groupId = "org.rocksdb", artifactId = "rocksdbjni" }
}]

labels: library-update, commit-count:1

Superseded by #741.


Unable to run takeout enable or any other takeout command.

Hi,
I've just installed this package on my MacOs.
Every time I try to run takeout enable, I'm getting the following error.

Please share your version of PHP and your version of Takeout.

Hello, I think that I'm experiencing the same issue.
My output is the following:
Deprecated: Return type of HumbugBox3130\KevinGH\RequirementChecker\RequirementCollection::getIterator() should either be compatible with IteratorAggregate::getIterator(): Traversable, or the #[\ReturnTypeWillChange] attribute should be used to temporarily suppress the notice in phar:///Users/simo/.composer/vendor/tightenco/takeout/builds/takeout/.box/src/RequirementCollection.php on line 12

Call Stack:
    0.0002     415096   1. {main}() /Users/simo/.composer/vendor/bin/takeout:0
    0.0031     416344   2. include('/Users/simo/.composer/vendor/tightenco/takeout/builds/takeout') /Users/simo/.composer/vendor/bin/takeout:119
    0.0176    3545768   3. require('phar:///Users/simo/.composer/vendor/tightenco/takeout/builds/takeout/.box/bin/check-requirements.php') /Users/simo/.composer/vendor/tightenco/takeout/builds/takeout:12
    0.0182    3631672   4. HumbugBox3130\KevinGH\RequirementChecker\Checker::checkRequirements() phar:///Users/simo/.composer/vendor/tightenco/takeout/builds/takeout/.box/bin/check-requirements.php:10
    0.0182    3631672   5. HumbugBox3130\KevinGH\RequirementChecker\Checker::retrieveRequirements() phar:///Users/simo/.composer/vendor/tightenco/takeout/builds/takeout/.box/src/Checker.php:10
    0.0182    3634704   6. Composer\Autoload\ClassLoader->loadClass($class = 'HumbugBox3130\\KevinGH\\RequirementChecker\\RequirementCollection') phar:///Users/simo/.composer/vendor/tightenco/takeout/builds/takeout/.box/src/Checker.php:79
    0.0182    3634704   7. Composer\Autoload\includeFile($file = 'phar:///Users/simo/.composer/vendor/tightenco/takeout/builds/takeout/.box/vendor/composer/../../src/RequirementCollection.php') phar:///Users/simo/.composer/vendor/tightenco/takeout/builds/takeout/.box/vendor/composer/ClassLoader.php:346
    0.0183    3640952   8. include('phar:///Users/simo/.composer/vendor/tightenco/takeout/builds/takeout/.box/src/RequirementCollection.php') phar:///Users/simo/.composer/vendor/tightenco/takeout/builds/takeout/.box/vendor/composer/ClassLoader.php:478

Deprecated: Return type of HumbugBox3130\KevinGH\RequirementChecker\RequirementCollection::count() should either be compatible with Countable::count(): int, or the #[\ReturnTypeWillChange] attribute should be used to temporarily suppress the notice in phar:///Users/simo/.composer/vendor/tightenco/takeout/builds/takeout/.box/src/RequirementCollection.php on line 16

Call Stack:
    0.0002     415096   1. {main}() /Users/simo/.composer/vendor/bin/takeout:0
    0.0031     416344   2. include('/Users/simo/.composer/vendor/tightenco/takeout/builds/takeout') /Users/simo/.composer/vendor/bin/takeout:119
    0.0176    3545768   3. require('phar:///Users/simo/.composer/vendor/tightenco/takeout/builds/takeout/.box/bin/check-requirements.php') /Users/simo/.composer/vendor/tightenco/takeout/builds/takeout:12
    0.0182    3631672   4. HumbugBox3130\KevinGH\RequirementChecker\Checker::checkRequirements() phar:///Users/simo/.composer/vendor/tightenco/takeout/builds/takeout/.box/bin/check-requirements.php:10
    0.0182    3631672   5. HumbugBox3130\KevinGH\RequirementChecker\Checker::retrieveRequirements() phar:///Users/simo/.composer/vendor/tightenco/takeout/builds/takeout/.box/src/Checker.php:10
    0.0182    3634704   6. Composer\Autoload\ClassLoader->loadClass($class = 'HumbugBox3130\\KevinGH\\RequirementChecker\\RequirementCollection') phar:///Users/simo/.composer/vendor/tightenco/takeout/builds/takeout/.box/src/Checker.php:79
    0.0182    3634704   7. Composer\Autoload\includeFile($file = 'phar:///Users/simo/.composer/vendor/tightenco/takeout/builds/takeout/.box/vendor/composer/../../src/RequirementCollection.php') phar:///Users/simo/.composer/vendor/tightenco/takeout/builds/takeout/.box/vendor/composer/ClassLoader.php:346
    0.0183    3640952   8. include('phar:///Users/simo/.composer/vendor/tightenco/takeout/builds/takeout/.box/src/RequirementCollection.php') phar:///Users/simo/.composer/vendor/tightenco/takeout/builds/takeout/.box/vendor/composer/ClassLoader.php:478

In HandleExceptions.php line 97:

  Call to undefined method Psr\Log\NullLogger::channel()

I'm on PHP 8.2.11 and my version of takeout is 1.8.13.

Never mind, I found the issue reading this #314.
It’s weird cause I've installed takeout through Composer without specifying the version and it has installed the v1 when the latest is the v2.

@speniti ahh, good catch. I'll update the install instructions to force v2 from now on.
@scaabel can you try installing it again but with this command composer global require tightenco/takeout:~2.5?

The v1 version is still installed by default, instructions are yet to be updated

sorry for the delay, I've just merged the docs fix.


Unable to switch to L2 network when wallet is not connected

Description:
Unable to switch to L2 network when wallet is not connected.
Prerequisites:

connected to L1 mainnet in metamask
wallet not connected with staking dapp

Reproduction steps:

Go to staking "Home" page (https://dev.staking.synthetix.io/)
Click on "Switch to L2" button
Confirm request to add new network in metamask
Confirm request to switch to new network in metamask

Current behavior:

after confirming requests in metamask, nothing happens in the dapp
if you click on "Switch to L2" button again, you will see "Network not supported on Layer 2" error (which is not true because you're already on "optimism mainnet" network in metamask)
if you refresh the page, everything works as it should ("Switch to L2" button is gone)

Expected behavior:

User should be properly switched to L2 network.
"Switch to L2" button should disappear.

Screenshots:

Desktop (please complete the following information):

OS: macOS Big Sur 11.2.2
Browser: Chrome 89.0.4389.95

Good find. It's actually an issue for L1 as well. When you disconnect a wallet it kinda messes things up.


Switch ststus is not correctly updated after host reboot

Hi  Developer,
I config a GPIO in Raspberry CM4 as switch, this switch can correctly control GPIO's high or low states.
But it can not display correct status after system reboot. For example:
If GPIO is high after reboot, the switch componment still show off even though I do not set invert_logic or active_low.
Thanks.

You are aiming to keep the gpio's state even over a system reboot?
Currently it's not keeping state over a system reboot. At reboot al gpio's return to off for what I've seen, and at initialization the gpio state is read from the board, therefore should always be off. Only way to keep the state over a reboot is to initialize from a stored state from hass, Is something I could look into to add, offcourse, could be a useful feature indeed ..

In my board, there are two gpios with external pull-up resistors. After reboot, the pin is tied to high due to the resistor even though gpio is not driven by raspberry at this period.
Shortly, I would like to know if switch element can show real IO status rather than the driven status?

I think I found something. Initialization requires either active or inactive as output_value, defaulting to inactive, so for every initialization all of the gpio's are always initialized with inactive. I might have found a workaround getting the gpio before initialization and using that value as input .. aiming for an update next weekend if this works

This seems to be a workaround, but I think it is better to regularly check
IO status by reading. In this method IO status will reflect its real logic
level If this IO is changed by other software or external excitations.
Thanks.
J de Neef @.***> 于2024年8月21日周三 15:45写道：

I think I found something. Initialization requires either active or
inactive as output_value, defaulting to inactive, so for every
initialization all of the gpio's are always initialized with inactive. I
might have found a workaround getting the gpio before initialization and
using that value as input .. aiming for an update next weekend if this works
—
Reply to this email directly, view it on GitHub
https://github.com/jdeneef/ha_gpiod/issues/13#issuecomment-2301366802,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AAZKTWPSWOFR2PULYWZ6BQ3ZSRAPZAVCNFSM6AAAAABMXQLS42VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDGMBRGM3DMOBQGI
.
You are receiving this because you authored the thread.Message ID:
@.***>

not sure if I understand correctly, are you switching via rpi gpio or do you want the gpio to reflect the status as from an external source (eg external switch)? If the latter, that's what the binary_sensor is for, that sensor is listening for edge_events, and reading the status at edge changes (eg high->low or low->high).

I added logic to read the initial state of a gpio at start in 1.2.5 pre-release. GPIO states and switches should survive homeassistant restarts now. Should also fix reboots if gpio is externally powered/triggered. Please test.
Note that there is 1 potential issue , for eg floating issues reading the initial state can return active, en thereby set the switch to active potentially triggering a connected device. Setting  bias: PULL_DOWN for inactive switch fixed it for me


Create distinct redirect for banner

Also added a redirect rule to the main site corresponding to indiegogo-banner-redirect which leads to this url: https://www.generosity.com/fundraisers/kolibri-free-offline-app-for-universal-education

@aronasorman take a peek?

Could do -- might be easier to extract than via Google Analytics, so let's merge!


Add flag to enable writing results to a file

This change adds a flag that enables writing results directly to a file, rather than needing to pipe the output.
The motivation for this is that we have a large series of tests that print debugging information to stdout, and this output gets mixed in with the result JSON, making it unparseable.
Changing the opt.Output property doesn't work in our case, because we use the --output flag to generate a binary and then run the binary in a separate environment.

Codecov Report

Merging #109 into master will decrease coverage by 0.18%.
The diff coverage is 25%.

@@            Coverage Diff             @@
##           master     #109      +/-   ##
==========================================
- Coverage    79.7%   79.52%   -0.19%
==========================================
  Files          16       16
  Lines        2341     2349       +8
==========================================
+ Hits         1866     1868       +2
- Misses        360      365       +5
- Partials      115      116       +1

Impacted Files
Coverage Δ

run.go
52.5% <0%> (-2.77%)
:arrow_down:

flags.go
94.62% <100%> (+0.11%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 272624a...18ade1e. Read the comment docs.

hi @darwish sadly I cannot accept it because it would force to cause a BC break in the future. original cucumber implementation in ruby allows to specify various outputs with different formatters like cucumber<EMAIL_ADDRESS><EMAIL_ADDRESS>--format=pretty@stdout. And I'm thinking to implement something like this in the future, just not yet decided how.
So as a solution I suggest you to compile test executable which runs godog by overriding TestMain, you can compile tests executable the same way as binary go test -c -o tests

@l3pp4rd No worries, thanks for the pointer.


compile a shared object, make test_runner depend on it, allow in tree…

… check depends
Heyya, Armon.
We are going to use libart for a new project here at Circonus but we have some build tweaks to auto-create a shared object and to be able to use check in-tree.
Let me know what you think about merging this or if you think there should be another approach.
Thanks,

@rileyberton It seems to be failing the Travis checks. Anything we need to change to make that pass? If that is passing, I'd be happy to merge it!

I believe this is an LD_LIBRARY_PATH problem.  The Travis job does this:
$ CK_TIMEOUT_MULTIPLIER=3 ./test_runner
Which fails with:
./test_runner: error while loading shared libraries: libart.so: cannot open shared object file: No such file or directory
I think if we change the test_runner invocation to:
$ CK_TIMEOUT_MULTIPLIER=3 LD_LIBRARY_PATH=pwd ./test_runner
It will pass.

I fixed the Travis job.  Apologies for the oversight.

Thanks!


Implementing other thermostats (e.g. Andersen or Langevin)

Hi all, thank you for the really great work.
I was curious if people have considered adding the Andersen or Langevin thermostats. The Berendsen thermostat is known to not generate a canonical ensemble, because energy fluctuations are not captured correctly.
If there's broader interest in this, I'd like to help out with the efforts. However, I'm a bit newer to the PySCF code and could use some pointers on how to best implement such a thermostat.
Cheers!

I think it would be nice to have other thermostats. You can checkout the integrators file to see how things are currently coded up. Specifically, you should just need to derive a new integrator from _Integrator and override the necessary methods, namely: _next which returns the next Frame with the new geometry, velocity, time step, and energy.
For example, the Velocity Verlet _next and the Berendson _next do basically the same thing, but the Berendson also scales the velocity.
The main thing is verifying the implementation of new thermostats to existing codes (namely ASE would be a good one if the thermostat exists within it).

I suggest improving interfaciability with MD codes over reimplementing MD in PySCF...

Thanks for the notes -- I saw that ASE has a langevin integrator, will try to get that working.

Hi all, could I get some pointers on how PySCF integrates with ASE?
ASE doesn't have PySCF listed as a supported calculator, and this PySCF doc uses another package, Siesta, instead to interface with ASE.
Is this generally the case that PySCF has to integrate ASE via Siesta, or is there a more direct integration?

Is this generally the case that PySCF has to integrate ASE via Siesta, or is there a more direct integration?

No, you should be able to directly integrate PySCF with ASE without Siesta.
There is no official interface between ASE and PySCF that I am aware of (hence why PySCF is not a supported calculator for ASE). There is a possible script/framework in #624 but it might be broken (or only broken for the GPU implementation in gpu4pyscf repo).


modified the gemlock file of the ruby sdk to support ruby version 3.1.2

modified the gemlock file of the ruby sdk to support ruby version 3.1.2 and also updated the dependencies

Hi @harasunu-narayan
Request to review this upgraded-related changes


Table Rendering Bug

When a table thead is split across pages, the second page runs into some rendering issues. I've attached an example HTML file and the output I receive. See the top of page 2 of the PDF.

Hello @natewiebe13 👋
It’s not really an issue with Gotenberg but more how Chrome renders the HTML to PDF.  I think adding the following CSS could solve your problem:
thead { display: table-header-group }
tfoot { display: table-row-group }
tr { page-break-inside: avoid

Unfortunately that CSS made no difference. I've attached updated input/output to this comment.
index2.txt
output2.pdf

@natewiebe13 it seems to be a recurring issue when converting HTML tables to PDF. There are some solutions listed in the following links:

https://github.com/wkhtmltopdf/wkhtmltopdf/issues/2367
https://www.api2pdf.com/solution-for-overlapping-content-when-generating-pdfs-with-table-headers-and-footers/

As this is not really an issue with Gotenberg, I’m moving this to the discussion space ^^
Let me know if you find a solution to your problem 😊


Potentially delete some dead namer code

Motivation

This might be dead code
Test plan

See included automated tests.

We have a policy of testing changes to Sorbet against Stripe's codebase before
merging them. I've kicked off a test run for the current PR.  When the build
finishes, I'll share with you whether or how it failed. Thanks!
Stripe employees can see the build results here:
→ https://go/builds/bui_LLAE6KNTA0cjY0
→ https://go/builds/bui_LLAEZU31ohdFZ5

Does this same sort of logic also apply in handleAssignment a couple hundred lines later?

Not sure, but I will definitely look at it! Thanks for the callout.


perf: increase size limit

Tracking actual work in #983
Signed-off-by: Jose Nino<EMAIL_ADDRESS>

Merging so new PRs can be green

Thanks!


Add plastic and metal materials

Hi,
I've added metal and plastic material plugins. I'm not sure about UI and about some parameters, should they float textures or just float parameters (specular and diffuse weights in Plastic for example). Also not sure about proper naming of some parameters (Normal Reflectance on metal).
Thanks for review,
Sergo.
Shaders are added in this pr

@usakhelo usually, the weights are just floats, and non texturable, since they are basic scaling factors to existing color textures for the diffuse and specular term. Allowing one to map a diffuse, specular weight, when one already allows mapping diffuse, specular color would be overkill.
Normal reflectance: perhaps it's best to keep consistency and name it Facing Tint or similar? This is part of the Artist Friendly Fresnel mapping to get the complex ior eta+k for the F term in the BRDF. It does so by getting the reflectance at normal incidence, and the reflectance at grazing incidence to compute eta+k. Perhaps it's more user friendly to just name it Facing Tint and Edge Tint.


Deal with Invalid Stage Name in Import and existing JSON file

ICYMI, the sample data class have to be updated too.


onedb fsck check fails on the vrouter

Description
onedb fsck check fails on the vrouter
To Reproduce
I have two vrouters created, but not instantiated, this one causes an error during fsck:
NAME=dev-ip
NIC=[
  AR_ID="0",
  BRIDGE="vmbr0",
  FLOATING_IP="YES",
  NETWORK="int-ip",
  NETWORK_ID="2",
  NIC_ID="0",
  VROUTER_IP="<IP_ADDRESS>",
  VROUTER_MAC="02:00:0a:1c:24:50" ]
NIC=[
  AR_ID="0",
  FLOATING_IP="YES",
  NETWORK="dev-ip-gw",
  NETWORK_ID="137",
  NIC_ID="1",
  VROUTER_IP="<IP_ADDRESS>",
  VROUTER_MAC="02:00:ac:10:00:01" ]
TEMPLATE_ID="26"

fsck is working fine when I remove it and until I create it again
Expected behavior
A c checkomplete fsck
Details

Affected Component: onedb
Hypervisor: KVM
Version: 5.8.1

Additional context
Trace log:
undefined method `empty?' for nil:NilClass
/usr/lib/one/ruby/onedb/fsck.rb:530:in `mac_s_to_i'
/usr/lib/one/ruby/onedb/fsck/vrouter.rb:56:in `block (2 levels) in check_vrouter'
/usr/lib/ruby/vendor_ruby/nokogiri/xml/node_set.rb:190:in `block in each'
/usr/lib/ruby/vendor_ruby/nokogiri/xml/node_set.rb:189:in `upto'
/usr/lib/ruby/vendor_ruby/nokogiri/xml/node_set.rb:189:in `each'
/usr/lib/one/ruby/onedb/fsck/vrouter.rb:11:in `block in check_vrouter'
/usr/lib/ruby/vendor_ruby/sequel/dataset/actions.rb:151:in `block in each'
/usr/lib/ruby/vendor_ruby/sequel/adapters/mysql2.rb:238:in `block (2 levels) in fetch_rows'
/usr/lib/ruby/vendor_ruby/sequel/adapters/mysql2.rb:238:in `each'
/usr/lib/ruby/vendor_ruby/sequel/adapters/mysql2.rb:238:in `block in fetch_rows'
/usr/lib/ruby/vendor_ruby/sequel/adapters/mysql2.rb:152:in `_execute'
/usr/lib/ruby/vendor_ruby/sequel/adapters/utils/mysql_mysql2.rb:38:in `block in execute'
/usr/lib/ruby/vendor_ruby/sequel/connection_pool/threaded.rb:91:in `hold'
/usr/lib/ruby/vendor_ruby/sequel/database/connecting.rb:269:in `synchronize'
/usr/lib/ruby/vendor_ruby/sequel/adapters/utils/mysql_mysql2.rb:38:in `execute'
/usr/lib/ruby/vendor_ruby/sequel/dataset/actions.rb:1085:in `execute'
/usr/lib/ruby/vendor_ruby/sequel/adapters/mysql2.rb:273:in `execute'
/usr/lib/ruby/vendor_ruby/sequel/adapters/mysql2.rb:236:in `fetch_rows'
/usr/lib/ruby/vendor_ruby/sequel/dataset/actions.rb:151:in `each'
/usr/lib/ruby/vendor_ruby/sequel/database/dataset.rb:51:in `fetch'
/usr/lib/one/ruby/onedb/fsck/vrouter.rb:7:in `check_vrouter'
/usr/lib/one/ruby/onedb/fsck.rb:382:in `fsck'
/usr/lib/one/ruby/onedb/onedb.rb:280:in `fsck'
/usr/bin/onedb:405:in `block (2 levels) in <main>'
/usr/lib/one/ruby/cli/command_parser.rb:470:in `run'
/usr/lib/one/ruby/cli/command_parser.rb:84:in `initialize'
/usr/bin/onedb:294:in `new'
/usr/bin/onedb:294:in `<main>'

Progress Status

[ ] Branch created
[ ] Code committed to development branch
[ ] Testing - QA
[ ] Documentation
[ ] Release notes - resolved issues, compatibility, known issues
[ ] Code committed to upstream release/hotfix branches
[ ] Documentation committed to upstream release/hotfix branches

The bug was fixed here: https://github.com/OpenNebula/one/commit/b11c8a55660fc953219ef1baea558011807164f1


Accordion Not Collapsing When Hide Button Clicked

Issue:
closes: #9
This PR does:

When the "Hide" button is clicked, the content hide
When the "Show" button is clicked, the content show

Screenshot:
By default looks like

when click show button, content show

when click hide button, content hide

@Anandsg I accidentally closed this pull request. Should I create a new one?

yes please i will review @ronisarkarexe


3-node HA possible?

Great effort, thank you for this!
This is more of a question - is there a way to have 3 nodes in a HA config, with each node performing both server and agent duties? If yes, how would one set it up using hashi-up?

Hi @veyalla
Yes indeed, Nomad can be started in both server and client mode, although it might not be the recommended way to build a Nomad cluster.
With hashi-up you just have to add both the --server and the --client flags when provisioning the server nodes, e.g:
export SERVER_1_IP=<IP_ADDRESS>
export SERVER_2_IP=<IP_ADDRESS>
export SERVER_3_IP=<IP_ADDRESS>

hashi-up nomad install --ip $SERVER_1_IP --server --client --bootstrap-expect 3 --retry-join $SERVER_1_IP --retry-join $SERVER_2_IP --retry-join $SERVER_3_IP
hashi-up nomad install --ip $SERVER_2_IP --server --client --bootstrap-expect 3 --retry-join $SERVER_1_IP --retry-join $SERVER_2_IP --retry-join $SERVER_3_IP
hashi-up nomad install --ip $SERVER_3_IP --server --client --bootstrap-expect 3 --retry-join $SERVER_1_IP --retry-join $SERVER_2_IP --retry-join $SERVER_3_IP

Thank you, keep up the great project!


Placing Note Crash

Describe your bug here. If you are modding, try testing your bug in a clean version of the engine instead. Also, if you're using an older version of JSE, please try the latest version/action build. Also, be sure to check the pinned 'JS Engine: Known Issues' issue, to check if your issue hasn't already been found!
this happens randomly for some reaason, and its getting pretty annoying
Command Prompt/Terminal/Crash logs (if existing)
Uncaught Error: Null Object Reference
Note.updateRGBColors() [line 536]
editors/ChartingState.addNote() [line 4036]
editors/ChartingState.update() [line 2551]
flixel/FlxState.tryUpdate() [line 239]
flixel/FlxGame.update() [line 749]
flixel/FlxGame.step() [line 679]
flixel/FlxGame.onEnterFrame() [line 558]
openfl/events/EventDispatcher.__dispatchEvent() [line 426]
openfl/display/DisplayObject.__dispatch() [line 1398]
Please report this error to the GitHub page: https://github.com/JordanSantiagoYT/FNF-JS-Engine
The engine has saved a crash log inside the crash folder, If you're making a GitHub issue you might want to send that!

Have you identified any steps to reproduce the bug? If so, please describe them below in as much detail as possible. Use images if possible.
opening chart editor
and placing note

Are you modding a build from source or with Lua?
Lua
What is your build target?
Windows
Did you edit anything in this build? If so, mention or summarize your changes.
Not really, just copied scripts from nusm (credited btw)
If you use 1.12.0 or earlier, did you have Optimized Chart Loading turned on?
No
Did you check for any similar issues to what you're reporting? Check, then come back here. If there is a similar issue, then do not report the issue, otherwise it will be marked as a duplicate.
Yes

forgot to add it, theres no similar issues just that one

mb i didnt know what that was

duplicate of #555

also already fixed in latest commit


fix: calling get_secrets in setup code fails

All tests passed (locally) before merging main - need to figure out what broke.

Superseded by #321.


Error TS2339

I am getting the error TS2339: Property 'endsWith' does not exist on type [insert a string variable here] when I build a TypeScript file using the below example:
console.log( "myString".endsWith("g") );
The TypeScript autocomplete also does not list ES6 methods (such as the above endsWith).
This error does not happen in VS Code (and the autocomplete also works correctly with ES6 methods in VS Code).

make sure your configuration either have --target ES6 or --lib es6, dom


Changed the rules page

Changed the rules page to be an accordion and added it to the sidebar

|--|--|

Consider adding padding-left with a small amount of pixels to the 'Help' header so that it is not as close to the edge of the screen on mobile


Draft on adding multiple strategies to hydrate Node Secure's payload vulnerabilities using npm's audit strategy.

Hello everyone,
Following the proposal made by @fraxken, I made a draft about adding a way to select one of the multiple vulnerabilities providers which are for now :

security-wg's DB (already implemented)
npm's audit remote analysis

The npm's audit only works with "cwd" cmd for now because it uses @npmcli/arborist which requires package-lock.json file.
About this, @fraxken  started an issue https://github.com/npm/arborist/issues/246.
Let me know your thoughts about this.
To test it directly from CLI (draft feature to directly test it) :
nsecure cwd -s db_npm => using npm audit strategy
nsecure cwd uses the default strategy so equivalent as nsecure cwd -s db_security_wg

Codecov Report

Merging #75 (d3bb84f) into master (cb38008) will decrease coverage by 0.48%.
The diff coverage is 62.26%.

@@            Coverage Diff             @@
##           master      #75      +/-   ##
==========================================
- Coverage   87.94%   87.46%   -0.49%
==========================================
  Files           8       11       +3
  Lines         614      646      +32
  Branches      108      110       +2
==========================================
+ Hits          540      565      +25
- Misses         62       69       +7
  Partials       12       12

Impacted Files
Coverage Δ

src/vulnerabilities/strategies/security-wg.js
75.47% <40.90%> (ø)

src/vulnerabilities/strategies/npm-audit.js
63.15% <63.15%> (ø)

src/depWalker.js
82.29% <100.00%> (ø)

src/vulnerabilities/strategies.js
100.00% <100.00%> (ø)

src/vulnerabilities/vulnerabilitiesSource.js
100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cb38008...d3bb84f. Read the comment docs.

Sorry guys for my silence I was a bit busy those days.
Thanks for the job 👏 @antoine-coulon

Sorry guys for my silence I was a bit busy those days.
Thanks for the job 👏 @antoine-coulon

All good, thanks for reviewing


TSX not compiling when changed, but compileOnSave is enabled

TypeScript Version:  3.2.0-dev.20181017
Search Terms:
TSX not compiling when changed, but compileOnSave is enabled
Code
Just any .tsx file
{
    "compileOnSave": true,
    "compilerOptions": {
        "target": "es5",
        "sourceMap": true,
        "jsx": "react",
        "jsxFactory": "BDOM.createElement",
        "outFile": "./client/build-out.js"
    }
}

Expected behavior:
When saving the TSX file, the compiler should recompile the tsx file (I have the compileOnSave enabled)
Actual behavior:
The files are not recompiled
Playground Link:
Not Applicable
Related Issues:
Didnt find any

In what editor?

VS 2017
Microsoft Visual Studio Enterprise 2017
Version 15.8.1
VisualStudio.15.Release/15.8.1+28010.2003
Microsoft .NET Framework
Version 4.7.02046
and
VSCode
Version: 1.28.1 (user setup)
Commit: 3368db6750222d319c851f6d90eb619d886e08f5
Date: 2018-10-11T18:13:53.910Z
Electron: 2.0.9
Chrome: 61.0.3163.100
Node.js: 8.9.3
V8: 6.1.534.41
Architecture: x64

This has been fixed in newer version of VS


chore: add relations for TERMINATED in state diagrams

I know this makes it less clear, but actually more correct. WDYT?
Closes #42

Another option for better readability could be to not add the state changes to the picture, but only to the text, like "all states can transition to terminated" (or similar...). I think it is easier to read the picture without all the "terminated" transitions.

Agreed on 30.03.: At the beginning, both parties can transition to TERMINATED, towards the end, it becomes stricter

@ssteinbuss This needs your approval.


feat(build): output rules for flat config in dts file

~On Hold at the moment.~
~Waiting for a new prettier release, see https://github.com/prettier/prettier/issues/1665~
Solved my creating an object.

Question: Should we export them too in a namespace? See: https://github.com/oxc-project/eslint-plugin-oxlint/blob/main/package.json#L7-L25

Should we export them too in a namespace? See: https://github.com/oxc-project/eslint-plugin-oxlint/blob/main/package.json#L7-L25

Seems complicated, I don't think we need it.


Titles Colour

How do you change the light blue colour of the icons and titles?

I was wondering the same thing, so I starting diging through the theme code. I found the theme's colors defined in the folder assets/sass/_{dark,light}-variables.sass.
The color you want to change is primary.

Ah, thanks Jonathon, that is terrific


left hand navigation doesn't keep scroll position on page load

If you scroll to a link far down the left hand navigation and click to visit a page, the nav scrolls back to the top, losing your position and making navigation confusing.
The nav should remember its scroll position from page to page.

Fixed


fix: add null checks before removing parent refs

One of our projects has a dependency to newrelic module, currently to version 1.40.0. The newrelic module code, attaches a property to the require.cache object, see https://github.com/newrelic/node-newrelic/blob/master/index.js#L114.
When calling the disable method on mockery, version 2.0.0, it will break, because the code on https://github.com/mfncooper/mockery/pull/57 assumes that anything on the require.cache object will be a module with a parent property. This is not the case with this newrelic module, and potentially with another ones attaching stuff to the rquire.cache.

Published in<EMAIL_ADDRESS>


Issue 186: Set up preliminary benchmarking

WIP
This PR closes #186. What it does:

Sets up performance benchmarking for all forecast date locations in the evaluation pipeline (all_forecasts.yaml), designed to run in targets. Current results from<EMAIL_ADDRESS>are included here
Set up a targets pipeline and create an eval config to benchmark only a subset of locations/forecast dates. I chose these somewhat vibes based, feel free to leave alternative suggestions
manually include wwinference version.

Open question:

Is there a way to automate adding the commit hash/version of wwinference to this metadata. @dylanhmorris Do you know a good way to do this? I guess I could parse through the DESCRIPTION file in wweval?

Is there a way to automate adding the commit hash/version of wwinference to this metadata. @dylanhmorris Do you know a good way to do this? I guess I could parse through the DESCRIPTION file in wweval?

Could use the package_info() function from the sessioninfo package:
Try
sessioninfo::package_info("wwinference", dependencies=FALSE)$source
sessioninfo::package_info("wwinference", dependencies=FALSE)$ondiskversion
sessioninfo::package_info("wweval", dependencies=FALSE)$source
sessioninfo::package_info("wweval", dependencies=FALSE)$ondiskversion

It isn't the prettiest logic but heres the latest and stacked tables


CI?

Travis? Circle? any preferences get logged here.

I think Travis is the easier path and the one that most devs will be familiar with. That said I prefer to use Circle CI.
Circle CI let us configure more than just unit and integration tests. We can also interface with other services if we wanted to.
Another thing to consider is that by November GitHub Actions will be out of beta and we could use that for better integration with GitHub itself.

@mkalish reports that Circle is set up


Persist ThreatMatches into the Spec11ThreatMatch table

Create Spec11ThreatMatches from Subdomains and ThreatMatches in the Spec11Pipeline, persist them, and test their persistence. This is so we can begin populating the database with the new ThreatMatches in addition to the usual JSON files, for future data analysis and advanced reporting.

This change is

PTAL @gbrodman @sarahcaseybot


Add entrypoint

Description

Related Issues

Solution and Design

Test Plan

Type of change

[ ] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)
[ ] Docs update

Checklist

[ ] My pull request is atomic and focuses on a single change.
[ ] I have read the contributing guide and my code conforms to the guidelines.
[ ] I have documented my changes clearly and comprehensively.
[ ] I have added the required tests.

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.4 out of 6 committers have signed the CLA.:white_check_mark: NishantBorthakur:white_check_mark: TransformerOptimus:white_check_mark: luciferlinx101:white_check_mark: Fluder-Paradyne:x: boundless-asura:x: TarraannTarraann seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.You have signed the CLA already but the status is still pending? Let us recheck it.


P2P - Create SyncPayload class for P2P Sync data transfer

Payload
A new class is needed to encapsulate the data which is exchanged between the sender and receiver during sync.
The class needs to be serializable so that it can be sent over different communication channels such as a socket.
It will need to include:

The locally updated version of resource.
The list of local changes which have been made to the resource. The list could be empty for newly created resources, or resources which have not been updated since they were synced from the server. A new class containing only the relevant fields from the LocalChangeEntity should probably be used instead of the LocalChangeEntity class itself since fields other than type and payload are not relevant, but this can be decided during development.

data class SyncPayload(val resource: Resource, val patches: List<LocalChangeEntity>)

This should get all data tied to a Patient with the referenced resources
Data to be synced should be from the same Location Hierarchy i.e.

A CHA can only sync to a CHA of the same location
A CHA can only sync to a  CHS of the same location

The patient data can be sent as FHIR Bundles
NB. The Practitioner details will help to query which jurisdiction they belong too, but this can be made to be configurable

@dubdabasoduba Check this out

Shell of SyncPayload class here
Update the SyncPayload class to handle json data as modeled here . Rename highestRecordId param to  highestValue (could either be a timestamp or rowId).
LOE 1 - 2 hours


[CARBONDATA-2908]the option of sort_scope don't effects while creatin…

…g table by data frame
Be sure to do all of the following checklist to help us incorporate
your contribution quickly and easily:

[ ] Any interfaces changed?

[ ] Any backward compatibility impacted?

[ ] Document update required?

[ ] Testing done
Please provide details on
- Whether new unit test cases have been added or why no new tests are required?
- How it is tested? Please attach test report.
- Is it a performance related change? Please attach the performance test report.
- Any additional information to help reviewers in testing this change.

[ ] For large changes, please consider breaking it into sub-tasks under an umbrella JIRA.

Build Success with Spark 2.1.0, Please check CI http://<IP_ADDRESS>:8080/job/ApacheCarbonPRBuilder1/8232/

Build Success with Spark 2.2.1, Please check CI http://<IP_ADDRESS>:8080/job/ApacheCarbonPRBuilder1/161/

@jackylk  properties of table can be add to TableProperty in schema.thrift

Build Success with Spark 2.1.0, Please check CI http://<IP_ADDRESS>:8080/job/ApacheCarbonPRBuilder1/8306/

Build Success with Spark 2.2.1, Please check CI http://<IP_ADDRESS>:8080/job/ApacheCarbonPRBuilder1/236/

Build Failed  with Spark 2.1.0, Please check CI http://<IP_ADDRESS>:8080/job/ApacheCarbonPRBuilder2.1/8/

@jackylk  revert the change of thrift, only solve sortScope

Build Failed with Spark 2.2.1, Please check CI http://<IP_ADDRESS>:8080/job/ApacheCarbonPRBuilder1/266/

Build Failed  with Spark 2.3.1, Please check CI http://<IP_ADDRESS>:8080/job/ApacheCarbonPRBuilder2.3/8335/

Build Success with Spark 2.1.0, Please check CI http://<IP_ADDRESS>:8080/job/ApacheCarbonPRBuilder2.1/97/

retest this please

Build Success with Spark 2.1.0, Please check CI http://<IP_ADDRESS>:8080/job/ApacheCarbonPRBuilder2.1/101/

Build Success with Spark 2.2.1, Please check CI http://<IP_ADDRESS>:8080/job/ApacheCarbonPRBuilder1/269/

Build Failed  with Spark 2.3.1, Please check CI http://<IP_ADDRESS>:8080/job/ApacheCarbonPRBuilder2.3/8339/

@qiuchenjian  please update the pr's title, doesn't display completely.

LGTM

merged, thanks for working on this


Build Page for Baklava Launch Part 1

Description
Implements the changes in design and content needed on build page for Baklava launch.
HighLights

Transceive an animation showing communication between a gold coin and a green coin representing a validator and an application.
Scroll based highlighting of the stack from top to bottom in sync with a little animated vector of it
More amazing things like the leaderboard

This PR contains work in progress for the Leaderboard and as such omits the leaderboard from showing on the page at all. follow up will make it show for dev.celo.org per conversation with @cmcewen as for the intent is not to show leaderboard on main site until there is some real action in there but on dev we want it for the mini stake off.
Tested

Other changes
better handling of #links and scrolling to them nicely
A new Layout system called BookLayout which uses the left column for titles and the center for main content.
Related issues
see also https://github.com/celo-org/celo-monorepo/pull/1864 which is based on this branch
Backwards compatibility
contains some big differences in content and layout

That jump is unfortunate. I wasn't able to find a way for it to stick at the exact right spot every time.


save and restore last cursor position in vim

This sets vim to save the cursor position on close/write and restores it on re-opening.

The set viminfo part is to unify and explicitly declare the .viminfo file (~/.viminfo is the default though)

The augroup cursor part restores the cursor
The additional check is to ensure, that the restoring works properly on files with only one line

@mathiasbynens Four and a half years is a long time to think about something 😉


⚠ Fortnite has degraded performance

In 1cb2663, Fortnite (https://fortnite.com) experienced degraded performance:

HTTP code: 200
Response time: 1618 ms

Resolved: Fortnite performance has improved in 3d1b9ec.


Facebook social login only relaying a bare minimum of values

Following issue #20, which is awesome to have, it would be preferable to have more of the Core fields which should be returned by the Facebook API and available to the Ionic backend. For the particular app that I'm working on now, first_name and last_name would be helpful; we want to display profile pages for users where we refer to them by their first names. Splitting the full_name isn't really reliable for this as some users have two first names, and for others the first/last names in full_name are in reverse order. There are also several other Core fields which I could imagine might be useful to some.

Hey @jaspervanveghel, we actually provide the full facebook response object in the raw_data field that gets returned to you. If you are using the cloud client, it would just be this.user.social.facebook.data.raw_data.PROPERTY_YOU_WANT, we just provide the most basic details inside of that data object for convenience. Check out http://docs.ionic.io/services/users/facebook-auth.html#data for more details there.
Additionally, I'll add the first_name and last_name properties to our required data scope that gets sent to Facebook, to make sure they get added to that raw_data object (along with the base name property that they send by default).

p.s. @jaspervanveghel The change is now live, you should be able to receive first_name and last_name inside of the raw_data attribute in our response object. If you are using the cloud client then you could do...
// Assign to a variable for DRY
const raw = this.user.social.facebook.data.raw_data;
const first = raw.first_name;
const last = raw.last_name;

Very cool. Thank you for the super fast response :)

On 06 Sep 2016, at 16:43, Bryan Oliver<EMAIL_ADDRESS>wrote:
p.s. @jaspervanveghel The change is now live, you should be able to receive first_name and last_name inside of the raw_data attribute in our response object. If you are using the cloud client then you could do...
// Assign to a variable for DRY
const raw = this.user.social.facebook.data.raw_data;
const first = raw.first_name;
const last = raw.last_name;
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or mute the thread.


[@typespec/http-specs] Add Installation Scripts to typespec repository

This is one of the required steps to get the dashboards released.
Please review and approve the PR. Thanks

:x: There is undocummented changes. Run chronus add to add a changeset or click here.
The following packages have changes but are not documented.

:x:@typespec/http-specs
:x:@typespec/spector

Show changes

You can try these changes here

🛝 Playground
🌐 Website
📚 Next docs


ios 64-bit support

Since Apple seems to drop support for 32-bit apps (http://www.cultofmac.com/464817/apple-prepares-drop-support-32-bit-ios-apps/), i was wondering if there is any update for supporting arm64.
I've read about patching openSSL (#2685), yet maybe there's an update on the way?

freerdp support for openssl 1.1 has been merged, the android version builds for all supported platforms. looks like somebody should just give it a try ;)

/However, the view found no 64-bit support, is my compilation problem? /mac/Downloads/FreeRDP-2.0.0-rc1/client/common/Debug-iphoneos/libfreerdp-client2.a are: armv7 armv7s

@l937928908 Someone needs to create a decent toolchain file for iOS that uses the 64bit compiler...
the core is 64bit compatible, but nobody stepped up writing the necessary howto and testing that.
Pull requests welcome!


nilaway doesn't acknowledge adding a guard check for a slice of a map value without a temporary

First off: great project, thanks for open sourcing it.
Error message:
Code:
	rules[state][rule].Mutator = Push(name)

Error:
chroma/mutators.go:147:2: index of a map of type `CompiledRules` lacking guarding; sliced into

Added guard check, but nilaway still complains.
	if rule >= len(rules[state]) {
		return fmt.Errorf("invalid rule %d for state %q", rule, state)
	}
	rules[state][rule].Mutator = Push(name)

Assigning to a temporary placates it:
	ruleState := rules[state]
	if rule >= len(ruleState) {
		return fmt.Errorf("invalid rule %d for state %q", rule, state)
	}
	ruleState[rule].Mutator = Push(name)

Please provide a self-contained example. Here it is not clear how type CompiledRules is defined.

ACK! NilAway indeed does not handle deep slices and maps very well (cases like you mentioned m[key1][key2][key3]). This bits need more love and we have a few PRs that move toward that direction, e.g., #60 (won't exactly solve this, but we are working on this 😃 )

BTW this is a duplicate of #111 , so I'm closing this one. Let's continue the discussion there!


Added global configurations

Adde global configurations #6

@netoxico thanks for the update! I missed this in the mass of my notifications!


Dialog resizing lags above PDFViewer

OpenUI5 version: 1.108.14
Browser/version (+device/version): Chrome 15.0.5790.171
Any other tested browsers/devices(OK/FAIL): Edge 116.0.1938.69 (FAIL)
URL (minimal example if possible): https://plnkr.co/edit/pLBlYCucJt6aW8uN
User/password (if required and possible - do not post any confidential information here): -
Steps to reproduce the problem:

Display a PDFViewer control
Open a Dialog with draggable=true and resizable=true and setModal(false)
Drag the Dialog on top of the PDFViewer
Try to resize the Dialog

What is the expected result?
The Dialog should resize.
What happens instead?
The Dialog size starts jumping and flickering around or does not follow the mouse pointer at all.
As soon as I drag the Dialog away from the PDFViewer, the resizing again works as expexted.
Any other information? (attach screenshot if possible)
https://github.com/SAP/openui5/assets/43701845/067fe546-fe07-4ce3-ad1c-2db1966576bb

Hello @BenjyTec ,
Please provide an URL to the live sample that demonstrates the issue, for example in jsBin or similar.
Best Regards,
Nikolay Hristov

I linked a Plunker, see the updated post. If the PDF file is blocked by the browser ("This page was blocked by Microsoft Edge"), the behaviour still can be reproduced.
I meanwhile found out that this behavior only occurs for non-modal Dialogs.

Hi @BenjyTec ,
I have reviewed your issue with the collegagues from Dialog team, and we found that you are using private/internal object modification (oDialog.oPopup.setModal(false);) which is not acceptable.
You can use oDialog.setResizable(true); in order to achieve dialog resizing, but that way it is always modal (as it is by design); you can see it even in the overview of the control, where it is stated: A popup that interrupts the current processing and prompts the user for an action or an input in a modal mode.
So your scenario is not a valid one, and I am closing this issue.
Best Regards,
Nikolay Hristov


various changes for Windows support

http://ci.ros2.org/job/ci_windows/1772/

I updated the AppVeyor and Travis configuration and they pass except for OS X:
3.5 is not installed; attempting download
tar: Unrecognized archive format
tar: Error exit delayed from previous errors.
The command "sudo tar xjf python-3.5.tar.bz2 --directory /" failed and exited with 1 during .

I don't think it makes sense to spend more time on that. Now requiring various new versions from Xenial it becomes increasingly difficult to run anything on Travis (on Trusty). Also our Jenkins builds have thoroughly covered that this works.

Waiting for review.

LGTM:
Passing CI on windows for reference:


Publish page mixes the messages order

I often experienced the bug in which publish page sends wrong message ( not one I clicked, but some other). I tried to make this bug reproducible, so I added 3 messages. One message is totally empty, and I think it may be important. Below are the examples to reproduce issue.
First case:
I try to send  second non empty message, but it says topic is empty. I think it tried to send first message which is indeed empty.
Then when I resubscribe to the topic, this for same reason change how publish tab works, but it still totally mixes the order of message.
https://github.com/chkr1011/mqttMultimeter/assets/6557983/4ce6699c-32fc-46e9-9cf0-194ac4489517
I attached below saved settings
mqtt-multimeter_case1.zip
Second:
There are only two messages and it still sends wrong one in the second try.
https://github.com/chkr1011/mqttMultimeter/assets/6557983/e8aa78db-2773-4618-9cff-49f3b9682120
mqtt-multimetercase3.zip
Version v<IP_ADDRESS>2,  windows 11 22631, mosquitto 2.0.14.
I don't remember such bug when I was using [v<IP_ADDRESS>] previously.

Please add file content in ticket. I will not download any files to my PC.

@chkr1011 Thank you for reply! You're right. I updated original post with file contents instead of .zip files.

To me it looks like that this is an issue in Avalonia. I will wait for version 11 and hopefully the issue is gone.

There are a few factors that lead to this bug.
One is the combination of CompiledBinding and the Mode=OneTime of the Command of the Publish button in PublishItemView.axaml
https://github.com/chkr1011/mqttMultimeter/blob/6980cbccdbd102735eb399e9ad4f75a743e86386/Source/Pages/Publish/PublishItemView.axaml#L26
Remove Mode=OneTime and the button acts on the currently selected publish item rather than always acting on the first publish item in the list.
However, this fix smelled so I investigated further and checked the difference between the Publish page and Connection page (where the connect button binding works correctly) and found that the Connection page does not use CompiledBindings and can confirm that removing the x:DataType="publish:PublishItemViewModel" attribute from the UserControl element and converting all CompiledBindings to Binding results in the publish button acting on the currently selected publish item whilst retaining Mode=OneTime.
This still seemed suspicious to me though because the OneTime binding modes in the connections page work properly.
It turns out that the publish page item view is hooked up to the publish page view differently to how the connection item view is hooked up to the connection page view:
https://github.com/chkr1011/mqttMultimeter/blob/6980cbccdbd102735eb399e9ad4f75a743e86386/Source/Pages/Connection/ConnectionPageView.axaml#L57-L59
vs
https://github.com/chkr1011/mqttMultimeter/blob/6980cbccdbd102735eb399e9ad4f75a743e86386/Source/Pages/Publish/PublishPageView.axaml#L58-L60
Bind the PublishItemView as the content of a ContentPresenter and the selected item applies to the item view correctly.

Ah great, I thought it was related to the Avalonia version...


Add a function that can build an EdgePartition faster.

If user can make sure every edge add by the order, use this function to build an EdgePartition will be faster.

This PR has gone stale. Through the discussion here, it seems like we want this change, contingent on some updates.
@ankurdave @lianhuiwang Do we want to update this PR or close and revisit it later?

@ankurdave If this patch possibly merged, I'll refactor it.

@ankurdave @lianhuiwang @nchammas @maropu I will close this PR。

@ankurdave @lianhuiwang @nchammas @maropu I will close this PR。


Better handling of one dataloader failing

Current Status
At the moment the default behavior of motherlode is to cancel the whole import process if one dataloader fails (return code != 0)
Desired Status
It would be better to only cancel dependending following dataloders( dependencies are defined in defined in https://github.com/covidgraph/motherlode/blob/master/motherlode/data_sources_registry.py)
All independent dataloader tracks should just go on.
Profit
Unattended failing import processes would advance in progress and the rerun after fixing the failed dataloader would take less time.

I'll take a stab at this. Stay tuned :-)

@motey I've created a PR for this. Would you like to review it, or should I merge it myself?

Pretty cool :)  i will give it a test later or tomorrow

just tested and looks good to me :)
Thanks Frank!


strange .dll not found problem

Hi,
I'm using msys2/setup-msys2 action to set up msys2 shell on my CI build. Recently I started having a strange problem when one of the test apps which tests the library being built on the CI is unable to load the library .dll.
I asked about what could be the possible problem here: https://github.com/msys2/MINGW-packages/issues/8370
But it looks like they have no idea.
Since the problem only occurs on the CI machine (locally all works fine), I thought that there might be some difference in how the environment is configured by the msys2/setup-msys2 action, so, posting the problem here.
Here goes the copy of the problem description from the link above.
===================================================
Hi,
I have a strange problem of a DLL being not found. I'm posting the issue here as I don't have any ideas of what else I can try to fix it.
I have an open source library project svgdom which I build for windows in msys2 environment.
I have github actions based CI configured in the github repo. The CI process first builds the library, producing the DLL, then it builds and runs test applications. To run a test application I have to copy the library DLL to the same directory as the test app's executable to make the test app load and link to the dll when it is run.
One can see the failed CI run here: for mingw64 and for mingw32
The strange thing is that it fails in the CI build, but on my local machine all passes successfully.
From the build log we can see that all test apps worked successfully except the one called tst.
The error when trying to run the tst app is as follows:
For mingw64:
D:/a/svgdom/svgdom/tests/tst/out/rel/tests.exe: error while loading shared libraries: libsvgdom.dll: cannot open shared object file: No such file or directory

For mingw32:
D:/a/svgdom/svgdom/tests/tst/out/rel/tests.exe: error while loading shared libraries: ?: cannot open shared object file: No such file or directory

The libsvgdom.dll file is there right next to tests.exe, that is 100% sure. I have checked that explicitly listing the dir contents on CI machine.
The only difference of the tst application from other test apps (which pass) I can think of is that the main() function in the tst app is provided by another DLL (libtst), not by the main executable. But again, all works fine on my local machine. And, similar tests are working fine for the libtst itself.
And I'll repeat again, the build (and those tests of course) passes successfully on my local machine in msys2 environment.
Any idea of what else can I try?
Thanks in advance!

My guess is that the issue is not related to libsvgdom.dll being not found. Instead, you need some other DLL, or libsvgdom depends on some other DLL which is missing. So, libsvgdom.dll: cannot open shared object file: No such file or directory does not mean it cannot find that specific file, but it found some error while trying to do so. Can you try it locally in a clean environment? You can extract the tarballs from https://github.com/msys2/msys2-installer/releases/tag/nightly-x86_64, in order to preserve your current installation untouched.

I'm glad it worked! I've been hit by that several times... Unfortunately, I'm not sure what's the underlying issue. I.e. which is the tool under the hood responsible for generating a better error message .

I think the code responsible is here: https://github.com/msys2/msys2-runtime/blob/0eee28b4ad46bcf4ed60d6bb612dc1e477b639b1/winsup/cygwin/pinfo.cc#L115
In particular find_first_notloaded_dll() seems to not give good results in many cases..


PlayerData and secondary save slots should be upgraded on startup

When the game is loaded, the SystemData with the player's settings is loaded and immediately saved it's detected to be out of date. The player's active save slot is scheduled to be saved as well, which is probably enough for most cases. But the secondary save slots are not saved. This can result in some minor ineffficiences in some common and uncommon edge-cases, as well as some gross code:

The player has two save slots, one which they last used several months ago. This secondary save slot keeps getting upgraded to obtain its playtime (see #2905)
GameplaySettings has a legacy_properties field which is a clumsy way of ensuring PlayerData can copy the difficulty settings and line piece settings months after the fields were removed.

When we start up, we should upgrade the player's data if it is out of date, and persist the new data to disk.

This issue is also called out in project/src/main/settings/gameplay-settings.gd so make sure to update the comments (and delete the unnecessary code) if the issue is resolved.