Fix flake in TestController_ServiceWithChangingDiscoveryNamespaces

Fixes #30877
The flake was caused by a race between the discovery namespace event handlers and the assertion of the registry's services. Specifically, the creation of the test namespaces triggers this discovery namespace event handler, which is required for this assertion to pass. On failed runs, debug logs show that the namespace events have not yet been processed at the time of assertion.
To address this I've exposed a GetMembers() method on DiscoveryNamespacesFilter, and allow it to be injected into the controller. This allows the test to ensure that the discovery namespace membership has updated (i.e. the event handlers triggered) before asserting that the registry's services have updated.

Hi @harveyxia. Thanks for your PR.
I'm waiting for a istio member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.
Once the patch is verified, the new status will be reflected by the ok-to-test label.
I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

/ok-to-test

@harveyxia: The following test failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

release-notes_istio
ddd7ae27c5fe19b0479d6b8fa94cfa895a7e15c8
link
/test release-notes_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

/retest

@harveyxia: The following test failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

integ-telemetry-k8s-tests_istio
ddd7ae27c5fe19b0479d6b8fa94cfa895a7e15c8
link
/test integ-telemetry-k8s-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@harveyxia: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

integ-telemetry-k8s-tests_istio
ddd7ae27c5fe19b0479d6b8fa94cfa895a7e15c8
link
/test integ-telemetry-k8s-tests_istio

integ-pilot-k8s-tests_istio
ddd7ae27c5fe19b0479d6b8fa94cfa895a7e15c8
link
/test integ-pilot-k8s-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

/retest

@harveyxia: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

integ-telemetry-k8s-tests_istio
ddd7ae27c5fe19b0479d6b8fa94cfa895a7e15c8
link
/test integ-telemetry-k8s-tests_istio

integ-pilot-k8s-tests_istio
ddd7ae27c5fe19b0479d6b8fa94cfa895a7e15c8
link
/test integ-pilot-k8s-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

/retest

@harveyxia: The following test failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

release-test_istio
ddd7ae27c5fe19b0479d6b8fa94cfa895a7e15c8
link
/test release-test_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

/retest


Add letters A-Z for moving 10-35 items down in the menu list

An addition to https://github.com/NationalSecurityAgency/ghidra/issues/2811 that simply enables letters A-Z to be used to move the current menu selection down 10-35 items.  (Ghidra has some long menus!!)

The problem I see with this is that the letter usage would interfere with any mnemonic accelerator set by on the menu item.   The way the system is wired now, the code in this PR would be processed first, which would prevent the existing mnemonic from working.
If the existing set of values is insufficient, then perhaps there is another solution we can find.   Can you describe the use case that is not working with the current MenuKeyProcessor values?

The problem I see with this is that the letter usage would interfere with any mnemonic accelerator set by on the menu item. The way the system is wired now, the code in this PR would be processed first, which would prevent the existing mnemonic from working.
If the existing set of values is insufficient, then perhaps there is another solution we can find. Can you describe the use case that is not working with the current MenuKeyProcessor values?

Oops, hadn't noticed it overrode any existing accelerators sorry.  I was just trying to speed up going to other options.  If more had accelerators I probably wouldn't have suggested this at all.

@ryanmkurtz fair enough you've closed this, but here's a thought.  If all dropdown menu accelerators were removed and replaced by a list element lke:

...
...
.
.
.

you could then use A..Z as well to directly jump to that menu item.
Btw, the Graph main menu is missing its accelerator.  The line below requires an & added to the new MenuData(...) call within method  GraphSelectionAction(...) of class GraphDisplayBrokerPlugin as shown:
			setMenuBarData(
				new MenuData(new String[] { "&Graph", "Graph Output", provider.getName() }, "z"));

@dragonmacher please see @Wall-AF's last comment.

I see the issue.  Will fix.


lr_partner_rendition_apis

Hello, our test client needs access to lr_partner_rendition_apis scope
Sometimes we notice api performance issues. Whenever we need to GET an image. We first post to the rendition endpoint to make sure the image has fullsize or 2560 available. Sometimes the get image returns 404, even though the post succeeds. We suspect there might be a rate limit? Our app is in beta, and we call the api thousands of times a day. When the app is released this will probably be hundreds of thousands/day.
I can email you our api keys

@calebmitcler Thanks for your interest. lr_partner_rendition_apis scope was granted to one of your client_ids earlier. Can you please explain us the use case to have it enabled on the second client id. Thanks.

We would like to have separate keys for development and production. In case there is a rate limit, we don't want development to interfere with production

@calebmitcler Can you please refer to this Doc to understand the rendition flow -https://www.adobe.io/apis/creativecloud/lightroom/docs.html#!quickstart/renditions.md
By default when an image is uploaded, the below renditions are being generated automatically.

thumbnail2x (320 pixels constraint on either edge)
640 (640 pixels on long edge)
1280 (1280 pixels on long edge)
2048 (2048 pixels on long edge)

Above renditions will serve all the usecases. 2560 and fullsize renditions are only meant for print purposes and are generated asynchronously that is why you get a 404. Please refer to the diagram at this link to understand how you need to poll and wait for these renditions to get genearted.

Also can you please share the other api-key for which you want to lr_partner_rendition_apis scope.

Thank you!! Our test api key is d31406efa36741c791b30fa2a44b0a84

@calebmitcler Can you check now. Also did you check the link related to renditions which I shared. Are there any doubts?

Sorry for late response. everything looks good. Thank you for your help!


Add collection flag for postman ECS agent

Adds collection flag

It looks like "Akita" still appears a bunch of times in prompts or log messages, I assume that is TBD in OBS-365?

It looks like "Akita" still appears a bunch of times in prompts or log messages, I assume that is TBD in OBS-365?

Yeah I tried removing it wherever I saw it. Will scan more closely as a part of OBS-365


gley, azotising (logical-conflict)

This pull request was generated by the 'mq' tool

/trunk merge


During deeply nested group-by execution, the merge buffer for the inner group-by result should be held during the outer group-by execution

For deeply nested group-by execution, at most two merge buffers should be acquired on the broker side for the currently accumulating sequence and the underlying input sequence which is already accumulated. With the group-by strategy v2, this intermediate result is stored on a merge buffer.
Obviously, the merge buffer needs to be held until the current sequence accumulation is completed. However, in the current implementation (see CombiningSequence), the input sequence (CombiningSequence.baseSequence) is first accumulated, and then the current sequence is accumulated. The merge buffer for the input sequence is released immediately once it's accumulation is completed (BaseSequence.IteratorMaker.cleanup()), so it is not guaranteed to hold the intermediate result stored on that merge buffer until the current sequence is completely accumulated.

looking into this

I found that this rarely happens only when nested queries have a simple count aggregation like select count(*) from (select d1, sum(m1) from foo group by d1) t. And in this case, it seems normal because the simple count aggregation needs just merging inputs instead of accumulating them.
I'll close this issue.

@jihoonson are you saying the behavior you saw is not actually a bug?

Yes, it seems normal.
More precisely speaking, in CombiningSequence.accumulation(), baseSequence.accumulate(null, combiningAccumulator) consumes only a single row because the simple count aggregation always produces a single row. And in this case, CombiningAccumulator.accumulate() always executes the below code which doesn't have to acquire a merge buffer.
if (prevValue == null) {
  return mergeFn.apply(t, null);
}

Thus, even though the merge buffer of the input sequence is released before the current sequence is accumulated, the intermediate result of the input sequence accumulation is kept as lastValue which is the result of baseSequence.accumulate(null, combiningAccumulator) in CombiningSequence.accumulation().

You can reproduce this by checking out https://github.com/jihoonson/druid/tree/merge-buffer-debug and running GroupByQueryMergeBufferTest. The tests in this class of this branch emit some logs which show what happens in sequence.


Unable to sync the blockchain

Description
Unable to sync the blockchain in Testnet at block 35861. Restarting the node won't fix the issue.
WRN committing block failed, removing block from the cache error="invalid public key: public key is not set" _sync="{☍ 30 ⛃ 240}" height=35861

What Happened
Fixing #869 has backfired. Block 35861 contains a Bond transaction for a bootstrap validator. The bootstrap validator has a public key, but at the same time, the LastBondingHeight for the bootstrap validator has been set to zero.
We can fix this by adding a new method to the Sandbox to determine if the Validator is sandboxed or not. However, this will add more complexity to the code. The issue #869 is rare and occurs only once in Testnet. This issue is not permanent; for example, after one day (once the first transaction expires), it will be fixed, or users can broadcast the transaction to other nodes. Fixing both issues will increase the code complexity and make the code harder to understand.
It's better to revert the fix for #869.

We can monitor the Testnet and if the issue #869 occures more, we can decide for a better fix.


Single core 1T test

Run 1T test single core first to prevent numba compilation issues during compilation

seems to be the issue in https://github.com/XENONnT/base_environment/pull/1116

Coverage increased (+0.04%) to 93.982% when pulling 140e40823165328f27fee5166c1047f466d62882 on JoranAngevaare-patch-2 into 49b26578dfc9b1c6934304406e14ce66ced8046c on master.


(b)ack audit functionality not present when secret not found

The (b) option disappears when a secret is not found, unfortunately, making it 'a point of no return' when auditing.
Secret:      3 of 5
Filename:    foobar.yaml
Secret Type: Base64 High Entropy String
----------
ERROR: Secret not found on line 3!
Try recreating your baseline to fix this issue.
----------
What would you like to do? (s)kip, (q)uit: b
Invalid input.

(Also I think there is another yaml-specific bug where it says Secrets not found on line N! on a freshly created baseline, but I'll make a different issue for that.)

As a first time-watch-look analysis, seems like (b) option only appears if can_step_back is passed as True in _get_user_decision() [0] and the same logic is used both in audit_baseline [1] and compare_baseline [2] so the same fix should fit both cases!
Actually,  can_step_back flag is toggled if secret_iterator.can_step_back() condition if verified (we check on the secret_iterator if we can return) so maybe one way to fix this if I'm not missing any edge case, would be to add this verification as an argument when no secret was found (when SecretNotFoundOnSpecifiedLineError exception is thrown) [3] and we call _get_user_decision().
Something like this (well, just the same we do with a regular secret!):
_get_user_decision(
                can_step_back=secret_iterator.can_step_back(),
                prompt_secret_decision=False,
            )


Persistent Connections and Streaming

The change boils down to replacing RestClient with HTTPClient [1] which adds support for:

Persistent HTTP connections
Built-in streaming

As a consequence, I've added CouchRest's own exception models for response errors, instead of relying on RestClient. Timeout or Connection errors are still handled directly by HTTPClient. This may or may not be a good idea.
Most of the API remains the same, but the recommended approach now is to send requests via a CouchRest::Server instance instead of the less efficient CouchRest#get and related class methods.
Persistent connections are a big win for performance, especially with SSL, and results with our own system have been positive so far.

Using my own github account for pull request instead of this branch.


Add View container on input label

Added View container to add some styles like borders on the label.

Hi @michel-p,
Thanks for the awesome PR!
I added a doc on contributing.
New versions are automatically published based on the commit messages.
Can you update your commits? Also the merge commit doesn't seem useful, maybe you can do the PR from your custom branch directly?


issue while running

server didnt respond

I can't be certain, but I think the issue might be with the websocket server implementation. I don't see anything in what was posted that indicates a possible error in ChatterBot.


Revert "corner cases for wait.Wait"

This reverts commit b69b5d9343d5d386e2280bb627ac1966015be459.
I hereby agree to the terms of the CLA available at: https://yandex.ru/legal/cla/?lang=en

Pull request type

Please check the type of change your PR introduces:

[x] Bugfix
[ ] Feature
[ ] Code style update (formatting, renaming)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] Documentation content changes
[ ] Other (please describe):

Codecov Report
Base: 52.27% // Head: 44.37% // Decreases project coverage by -7.91% :warning:

Coverage data is based on head (7a14ffe) compared to base (b69b5d9).
Patch has no changes to coverable lines.

:mega: This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #547      +/-   ##
==========================================
- Coverage   52.27%   44.37%   -7.91%
==========================================
  Files         220      146      -74
  Lines       21430    15310    -6120
==========================================
- Hits        11203     6794    -4409
+ Misses       9520     8210    -1310
+ Partials      707      306     -401

Flag
Coverage Δ

1.16.x
44.00% <ø> (-7.73%)
:arrow_down:

1.18.x
44.32% <ø> (-7.83%)
:arrow_down:

1.19.x
44.43% <ø> (-7.60%)
:arrow_down:

integration
?

ubuntu-latest
44.37% <ø> (-7.91%)
:arrow_down:

unit
44.37% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

 Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.


Fix randomization in bucketization algorithm

Minters using non-sequential templates use a number of containers with an equal number of identifiers as a way to split up the identifier space into manageable chunks (or "buckets") and to increase the appearance of randomness in the identifiers.
As an example, let's assume a non-sequential identifier template that has 100 possible values. It might have 10 buckets each with 10 identifiers.  You would expect sequential calls to #mint not to continually spit out identifiers that look the same, and yet this is precisely the behavior that we now see with stateful minters.
Stateful minters with non-sequential templates are currently spitting out very similar-looking identifiers because every call to #mint reuses the same random number (for replayability purposes) and fails to take into account how far into the sequence it is (despite that being part of its saved state). As a result, these minters will choose one bucket and keep using it until it is exhausted. This can and has been causing problems upstream (see: https://github.com/projecthydra-labs/active_fedora-noid/issues/5 and https://github.com/projecthydra/sufia/pull/1037).
Thus, stateful minters ought to consider position in the sequence when grabbing a random bucket. This PR uses the value of the seq param (from the passed-in state) and the #next_random method to accomplish this, which has the benefit of not breaking current minters that are already into their sequence, but has a potential downside of needing to run #next_random many (possibly thousands) of times to advance the minter in its sequence.  I did this to respect current minters and not break their state.
Another solution might be to completely rethink how we handle random number generation -- for instance, my first pass at this PR changed the seed on every call to mint by seeding the random number generator with the original seed value (persisted by the #dump method) plus the sequence value. With that scheme, every call to #mint only needs to generate a single random number rather than manually replay it.

Not satisfied with some of the choices I made. Gonna rework this tomorrow.
Please do not merge.

@mjgiarlo thanks so much for taking this on. I assume you have a pretty good understanding of this minting algorithm now; a general overview-type comment would be a great addition.

It'd also be good if you could disentangle the functional changes from the style changes (into separate commits)

@cbeer Those are exactly some of the choices I was talking about.  Hope to have another PR ready in a couple hours.
@hackmastera I can add some YARD docs too. If I space on that, let me know again. ;)

@mjgiarlo cool -- and, for the record, I fully support bringing the code quality up to current standards.

@mjgiarlo I wrote a bunch of stuff when I went through and figured out how it worked. Feel free to lift any or as much as you'd like. There are a few differences from the ruby one, but they are marked as extensions.
https://github.com/ndlib/noids/blob/master/noid-service.md#noid-template-format
https://github.com/ndlib/noids/blob/master/noid/noid.go#L228-L238
in that implementation i removed the randomness all together and took ids from each bucket in turn to make sure ids were more equally scattered throughout the identifer-space.

@hackmastera Check out the comment I left up above and let me know how far that gets us down the road of documenting how randomization/bucketization/minting work. Let me know if there are any gaps and I can address those.

@mjgiarlo your comment is quite helpful. This sentence is a little confusing:
"a number of containers with an equal number of identifiers" -- I thought at first you meant the number of containers == the number of identifiers in each, which didn't seem possible.
Should probably be "a number of containers, each with an equal number of identifiers"
I think if you remove the part about how it used to work, it would be helpful to put this comment at the top of minter.rb.
Can you elaborate on "potential downside of needing to run #next_random many (possibly thousands) of times to advance the minter in its sequence"? Do you know anything about the scenario in which this would happen? Are there ways to make it less likely?
Thank you!

@hackmastera ++
OK, will clarify that sentence and paste it into minter.rb.  Thanks!
Re: the potential downside, this happens every single time you call #mint with a stateful minter (a minter initialized with state passed in as a param) and a non-sequential template. This is what we have in Sufia. So if you have an app with 1,000 identifiers, and you mint another, the first thing the minter does is fast-forward the random number sequence 1,000 spots. It should be a speedy operation because it's the kind of thing computers are good at, but it will degrade at some point.
I believe @cbeer is working on a PR that may address this. Fixing the prior bug without touching lots of other code and refactoring things, and possibly breaking minters with existing state, was my first priority, and now I'd like to have another go at improving things efficiency/performancewise, though until someone says they're seeing performance-related issues with 0.7.2, I'd be content to backburner this work.

@hackmastera PR added: https://github.com/microservices/noid/pull/18 I'd be much obliged if you could review it for clarity and substance!

FWIW, I'm not seeing a very large performance penalty after benchmarking into the 100s of 1000s. The benchmarking code and results are here:
https://gist.github.com/mjgiarlo/1b09f710a625ffb92a8f


Drawable-Left image vanishes after clicking on edit text

<com.scottyab.showhidepasswordedittext.ShowHidePasswordEditText
       android:layout_width="match_parent"
       android:layout_height="wrap_content"
       android:inputType="textPassword"
       android:id="@+id/password_editText"
       android:hint="Type your Password"
       android:drawableLeft="@drawable/key"
       android:drawablePadding="15dp" />

The Left-Drawable image vanishes after we start typing in the edit text

Thanks for reporting, this could be related to our support of RTL, we should probably include a example of using left drawable in the sample app.

@himanshubabal this is fixed and will be in 0.8 thanks again for raising it


fix(module:dropdown): fix unsubscribe undefined bug

close #269
PR Checklist
Please check if your PR fulfills the following requirements:

[x] The commit message follows our guidelines: https://github.com/NG-ZORRO/ng-zorro-antd/blob/master/CONTRIBUTING.md#commit
[ ] Tests for the changes have been added (for bug fixes / features)
[ ] Docs have been added / updated (for bug fixes / features)

PR Type
What kind of change does this PR introduce?

[x] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Application (the showcase website) / infrastructure changes
[ ] Other... Please describe:

What is the current behavior?

Issue Number: N/A
What is the new behavior?
Does this PR introduce a breaking change?
[ ] Yes
[x] No

Other information

Coverage decreased (-0.01%) to 41.255% when pulling e2ec88fbae4560b6d5e4a83f75c953b9ad365d0e on vthinkxie:fix-dropdown-unsubscribe into 704aa45b941308c63e70f0c7db032e8e7e394feb on NG-ZORRO:master.


a2v中Evaluate出来的pvp和verb的ap很低。

a2v中Evaluate出来的pvp和verb的ap很低。请问作者训练后的ap在测试集上能达到多少？

Sorry for the late reply but we are developing a newer version of this project, with stronger pretrained model and more concise code. Please stay concerned.


Update jQuery to v3.6.0.

@rohit2sharma95 this is a tricky one and not sure yet if it's a regression in jQuery or just a change due to the fix for https://github.com/jquery/jquery/issues/4382. Maybe we need to adapt these 2 tests? The breakage seems to occur only on IE, though.

It seems to be a bug in jQuery v3.6.0, see https://github.com/jquery/jquery/issues/4859. Closing this for now.

Do you know if the jQuery 3.6.1 update fixes the issue?

Judging by the linked issue milestone, this isn't fixed in 3.6.1...


Simplify instantiation of generic-bound union members

Consider the following union:
[Union]
public partial record Option<T>
{
    public partial record Some(T Value);
    public partial record None;
}

Currently, to instantiate the Some variant, we must write the following:
var some = new Option<int>.Some(42);

Since the generic type parameter is bound to the union, we must define the type parameter every time since it cannot be inferred from the type passed to the union member. It would be nicer to be able to do the following:
// Inferred as `Option<int>.Some` since `42` is an integer.
var some = Option.Some(42);

For backward compatibility, we probably want to expose this through a generated XPrelude static class where X is the union name (minus generic type parameters.
using static OptionPrelude;

var some = Option.Some(42);


Typo: Removes an extra bracket (>)

 Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

Hello @sodevious,
thank you for submitting this typo fix. I've merged your contribution as  https://github.com/gohugoio/hugoDocs/commit/4e14071e7b1d693ba98b6120f93285699a861a1b. Please note that pull request, that affect only the documentation, shall be send to the hugoDocs directory instead :wink:
Cheers,
Digitalcraftsman


[android] Fix some tests and a doc flag

Use off_t for a recently failing stdlib test, hack the Python script for some tests so that it works with newer Python, and correct build flag in the docs.
@CodaFi, normally I'd ask @drodriguez but I haven't been able to get a hold of him lately, so would you review?

@swift-ci smoke test

@swift-ci python lint

Rebased and fixed the Python formatting issue the linter is complaining about, Distributed test failure is unrelated.

@swift-ci please test

@MaxDesiatov, would you run the CI on this?

@swift-ci please smoke test

@buttaface I highly recommend requesting CI access, sending that request shouldn't take much of your time.

@MaxDesiatov, I know, you recommended that before but I'm winding down submitting my Android patches (this is the last patch I apply locally when building trunk on my phone for testing that is worth submitting), and I think it's better not to have CI access once I go into a low-commit mode from here on out (I'm down to only four trunk pulls pending, with plans to submit only one of my remaining patches), for security and other reasons.

I don't see much problem in requesting CI access, and then requesting it to be revoked after you're done with your contributions.

I'm almost out the door, probably not worth the hassle for all involved.


Added new repository from devSouvik

New repository named personality-tracker added

@devSouvik Can you add a few more issues that are easy picking? Also, make sure the setup docs are written.

Within this same repositary ?

@jai-deepsource I made a few changes, as recommended. Is there anything else to be done?

Closed due to inactivity. Please open a new PR. Thanks!


Support for flexible forms of authentication we need support for generic oauth

Closes https://github.com/Quansight/qhub-cloud/issues/450

Will also add support for generic authenticator support


VLAZ: Watch (?-i:8k3swo1)(?#rebrand.ly)

VLAZ requests the watch of the watch_keyword (?-i:8k3swo1)(?#rebrand.ly). See the MS search here and the Stack Exchange search in text, in URLs, and in code.

Approved by Jeff Schaller in Charcoal HQ


[RFC] Support for interval (continuous) series

In addition to supporting single-point Date drops (depicting a time when an event took place), I think support for interval (e.g. continuous events) would add some needed functionality to this component
I suppose the use cases range widely (and there are too many to count) but the most basic ones include:

Scheduling
Historical records / TImeline (membership / "activation time")
Schematic view of recordings (e.g. go-pro / live feed / home cameras / etc)

I propose something of the sorts:

A line/series is composed of either singular drops or intervals - specified as a boolean in the data object
intervals are presented the same as drops, only 'circle' is replaced with a 'rect'

Open questions:

Should meatball-ing appear the same for these two types?
What is to be done with crossing intervals (unlike drops, they may contain dissimilar data)

That's indeed a good idea. :)
Yet, I think we should be able to mix drops and intervals together. I don't think it would add too much overhead, and it would bring more flexibility. Each item would then be object with either date or begin and end times.
I don't think metaballs make sense anymore with intervals. But that need to be discussed.
Indeed, crossing intervals may be an issue. Yet, for now, I think we can address it later.
Yet, this addition would need a lot of work. So let's postpone it for a later version. Meanwhile, feel free to start a PR about it. :)

I'd like to add a use case as well.
Say you are tracking an online order. Currently, as I zoom in, I start to see individual dots representing various destinations my package has reached. However, the journey of my package is really a single thing. One use case is to see a 'blob' with start time and end time. The other use case, obviously, is to represent each destination as a single point.
It becomes much more interesting if I can display two rows, one showing the whole journey as a single, connected blob and the second line showing individual destinations within that journey. As I zoom out, the journey blob turns into a circle with no detail. Zooming in reveals individual destinations.
The same metaphor can be used to describe any process involving state transitions. Zoom out and you see a single dot representing some process. As you zoom in, you see the details of which state you are in. This way, you can represent a large number of processes (and that is just in a one or two rows).
Earlier I described two rows, one of overview and the second for detail. Those two rows could be combined so EventDrops natively understands this overview/detail metaphor and has a cleaner UI, rather than using two explicit rows.
If EventDrops does natively understand such a relationship, then specific colors could be used to describe specific state.
Any way, this is not a request for a huge set of features, just an idea that this could be a very interesting direction for this project.


Add linter to CI

Fixes #28
Motivation
This'll do a lot to keep style consistent, and flake8 will also catch a whole lot of stupid mistakes.
Changes
See commit messages. Note that I removed a bunch of boilerplate code that hasn't been used yet - I'm personally okay with this on YAGNI, but we can also address this using # noqa comments.
Testing
Run flake8 on your local and see that it comes back clean. Review tox.ini and see the exceptions that I've made to the standard configuration.

@tstirrat15 did you see my comment about adding MyPy to check typing on build?  We could move that to a different ticket if that makes more sense.

See #43. I forgot to link it in #28 :P


Pin protobuf version to 3.4

cc @dwsupplee @jdpedrie @bshaffer @teboring
This is in response to https://github.com/google/protobuf/issues/3881

Codecov Report

Merging #124 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #124   +/-   ##
=======================================
  Coverage   90.08%   90.08%
=======================================
  Files          32       32
  Lines        2238     2238
=======================================
  Hits         2016     2016
  Misses        222      222

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7d2e506...c28ea61. Read the comment docs.


could not access admin-ui

Recently I pushed spring-cloud-dataflow-server-cloudfoundry-1.0.0.M2 version on PCF. It starts well with embedded tomcat listening on 8080. I am trying access admin-UI url as http://host:8080/admin-ui. it does not recognize the url. Here the host is the value from SPRING_CLOUD_DEPLOYER_CLOUDFOUNDRY_DOMAIN. Is this something with URL?

In 1.0.0.M2, the dashboard is accessible at http://<APP_URL>/admin-ui. The APP_URL can be found when you issue cf apps command in CF CLI and port routing is handled by CF, so you don't need 8080.
Example:
→ cf apps
Getting apps in org some-org / space development as someone...
OK

name                    requested state   instances   memory   disk   urls
dataflow-server    started                 1/1             3G            1G    dataflow-server.test.io

Dashboard can be accessed at: http://dataflow-server.test.io/admin-ui


issue#94 change include file directives

change source code base to v0.3.5

Looks good!
Sorry if you had any trouble while trying to make these changes. I wasn't expecting any new contributors. I'll try to make it easier for ppl to contribute in the future.
Thanks for the changes!


Registration not working

'primenet.py: send_progress: Tue 02 Nov 2021 03:40:48 AM CET     Cannot update, the registration is not done'
which parameters needed for registration ?

which parameters needed for registration ?

You can run the --help option to see all of the registering parameters, although they are all optional. It automatically registers the computer with PrimeNet if the user does NOT provide a password.
I believe the issue is that you provided your password, which restricts the script to manual testing, the default behavior for old versions of this script. To fix the issue, just open your local.ini file and delete the password = line.

which parameters needed for registration ?

You can run the --help option to see all of the registering parameters, although they are all optional. It automatically registers the computer with PrimeNet if the user does NOT provide a password.
I believe the issue is that you provided your password, which restricts the script to manual testing, the default behavior for old versions of this script. To fix the issue, just open your local.ini file and delete the password = line.

Yes this worked, thank you.


link-to-external targetRouteName is undefined

Within an engine the link-to-external component is throwing an error when attempting to get the external route. After stepping into the code it looks like the targetRouteName is undefined on the component. So this causes the _getExternalRoute to fail the external route lookup on the provided dependencies.

This is likely not a bug, but a configuration problem in your application. We know this to work because it's used in production at LI.
Please stop by #-ember-engines in the Ember Community Slack and seek help from the wonderful people in our community!
I'm closing this issue for now. In the mean time we will still continue to receive notifications from any followup comments on this issue; being closed doesn't mean that we're ignoring the thread.

(Or, if it is a bug, get us a reproduction!)

@nathanhammond Yeah that could be it, not ruling that out. I did noticed changing this line to the willRender hook worked. Not sure if something changed with the link-to component ember upstream. I'll get a repro up asap. My work's proxy blocks pushing up to github 👎

@nathanhammond
It's a bug, because ember-glimmer expects of glimmer-2 availability in 2.9 ember version, but glimmer-2 not included in 2.9 ember.
https://github.com/dgeb/ember-engines/commit/136f62c5fe79baf88a397af7c68ea748eca5add6
http://emberjs.com/blog/2016/10/17/ember-2-9-released.html#toc_ember-js-2-9

Agreed, submitted https://github.com/dgeb/ember-engines/pull/270 to address. Thanks for tracking it down!
Robert Jackson
-- twitter: rwjblue
-- github: rjackson

On Nov 21, 2016, at 7:49 AM, Nuzsk<EMAIL_ADDRESS>wrote:
@nathanhammond
It's a bug, because ember-glimmer expects of glimmer-2 availability in 2.9 ember version, but glimmer-2 not included in 2.9 ember.
136f62c
http://emberjs.com/blog/2016/10/17/ember-2-9-released.html#toc_ember-js-2-9
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub, or mute the thread.

Ah, damn. That whole Glimmer release switcheroo. 😜 Thanks for getting this right.

@jbailey4 Hm, I'm seeing this with 2.13. Am I not configuring properly in app.js? It seems as though there aren't any external routes registered.

@jbailey4 Actually, I can see the dependencies registered on the mount point, so config must be fine. Separately, the component hook seems fine for the post glimmer world.   I'll dig in to see if I can't find some other cause.

@jbailey4  I'll just keep documenting what I find. If it turns out to be unhelpful, I'll delete all this.  Here's what I found (and its really weird).
// Using Ember.get => undefined
get(this, 'targetRouteName')

// Using plain old property access => MyTargetRoute
this.targetRouteName

https://github.com/ember-engines/ember-engines/blob/da05713bfbd7ca5d415623b1bb4160c34c842be0/addon/components/link-to-external-component.js#L18
Has anything changed about Ember.get? Going there next.
cc/ @nathanhammond @rwjblue

@jbailey4 Okay, well i don't know what changed, but I have a solution.
import get from 'ember-metal/get';  then get(this, 'targetRouteName') works fine.
Not entirely sure why. @nathanhammond  @rwjblue Let me know if I should submit a PR, or I'll also settle for the consolation prize of know why this broke.

@jbailey4 Okay, here's the final piece (it combination with above) and now it works without throwing.
It seems that, in the engine instance, _externalRoutes is just not a thing here
When you dig down to dependencies.externalRoutes, then you're good.
  _getExternalRoute(routeName) {
    const route = this.dependencies.externalRoutes[routeName];

  // etc.
  }

@crodriguez1a what version of ember-engines are you using with<EMAIL_ADDRESS>You shouldn't need to dig that far into the code.

@trentmwillis  I'm using 0.5.4. Yeah, my first instinct was just a bad configuration. I'm probably missing something obvious here.

Interesting, since the root cause is likely different from this issue, if you could open a new issue with a reproduction it would be appreciated.

@trentmwillis 👍 Will do.

@trentmwillis Reproducing lead me to the issue. I was simply missing the config in engine.js. If you miss the app.js config, it throws A dependency mapping for 'externalRoutes.home' must be declared on this engine's parent.. Conversely, missing the engine.js config surfaces as Cannot read property 'MyTargetRoute' of undefined     at Class._getExternalRoute. I'll go ahead and clean up this thread.

Hey @trentmwillis, one I thing I did find is that it does seem possible to have a single dependency declaration, and have the engine instance be aware. Any reason not to have just the one config at the consuming app? Just curious.


setup repo

Docs Build status updates of commit d3eaab9:
:warning: Validation status: warnings

File
Status
Preview URL
Details

secmgmt/secmgmtopenps-1.0/SecMgmt/Connect-SecMgmtAccount.md
:warning:Warning

Details

secmgmt/secmgmtopenps-1.0/SecMgmt/Disconnect-SecMgmtAccount.md
:warning:Warning

Details

secmgmt/secmgmtopenps-1.0/SecMgmt/Initialize-SecMgmtHybirdDeviceEnrollment.md
:warning:Warning

Details

secmgmt/secmgmtopenps-1.0/SecMgmt/Install-SecMgmtInsightsConnector.md
:warning:Warning

Details

secmgmt/secmgmtopenps-1.0/SecMgmt/New-SecMgmtAccessToken.md
:warning:Warning

Details

secmgmt/secmgmtopenps-1.0/SecMgmt/Register-SecMgmtDeviceWithManagement.md
:warning:Warning

Details

secmgmt/secmgmtopenps-1.0/SecMgmt/Resolve-SecMgmtError.md
:warning:Warning

Details

secmgmt/secmgmtopenps-1.0/SecMgmt/SecMgmt.md
:warning:Warning

Details

secmgmt/secmgmtopenps-1.0/SecMgmt/Unregister-SecMgmtDeviceWithManagement.md
:warning:Warning

Details

.openpublishing.publish.config.json
:white_check_mark:Succeeded

secmgmt/breadcrumb/toc.yml
:white_check_mark:Succeeded

secmgmt/docfx.json
:white_check_mark:Succeeded

secmgmt/docs-conceptual/overview.md
:white_check_mark:Succeeded

secmgmt/mapping/monikerMapping.json
:white_check_mark:Succeeded

secmgmt/secmgmtopenps-1.0/SecMgmt/Connect-SecMgmtAccount.md

Line 2, Column 1: [Warning-attribute-reserved] Attribute content_git_url is reserved for use by Docs.
Line 2, Column 1: [Warning-title-missing] Missing required attribute: 'title'. Add a title string to show in search engine results.
Line 6, Column 1: [Warning-attribute-reserved] Attribute original_content_git_url is reserved for use by Docs.
Line 308, Column 0: [Warning-insecure-link] Link 'http://go.microsoft.com/fwlink/?LinkID=113216' is insecure. Links to Microsoft sites must use 'https' instead of 'http'.

secmgmt/secmgmtopenps-1.0/SecMgmt/Disconnect-SecMgmtAccount.md

Line 2, Column 1: [Warning-attribute-reserved] Attribute content_git_url is reserved for use by Docs.
Line 2, Column 1: [Warning-title-missing] Missing required attribute: 'title'. Add a title string to show in search engine results.
Line 6, Column 1: [Warning-attribute-reserved] Attribute original_content_git_url is reserved for use by Docs.
Line 67, Column 0: [Warning-insecure-link] Link 'http://go.microsoft.com/fwlink/?LinkID=113216' is insecure. Links to Microsoft sites must use 'https' instead of 'http'.

secmgmt/secmgmtopenps-1.0/SecMgmt/Initialize-SecMgmtHybirdDeviceEnrollment.md

Line 2, Column 1: [Warning-attribute-reserved] Attribute content_git_url is reserved for use by Docs.
Line 2, Column 1: [Warning-title-missing] Missing required attribute: 'title'. Add a title string to show in search engine results.
Line 6, Column 1: [Warning-attribute-reserved] Attribute original_content_git_url is reserved for use by Docs.
Line 121, Column 0: [Warning-insecure-link] Link 'http://go.microsoft.com/fwlink/?LinkID=113216' is insecure. Links to Microsoft sites must use 'https' instead of 'http'.

secmgmt/secmgmtopenps-1.0/SecMgmt/Install-SecMgmtInsightsConnector.md

Line 2, Column 1: [Warning-attribute-reserved] Attribute content_git_url is reserved for use by Docs.
Line 2, Column 1: [Warning-title-missing] Missing required attribute: 'title'. Add a title string to show in search engine results.
Line 6, Column 1: [Warning-attribute-reserved] Attribute original_content_git_url is reserved for use by Docs.
Line 127, Column 0: [Warning-insecure-link] Link 'http://go.microsoft.com/fwlink/?LinkID=113216' is insecure. Links to Microsoft sites must use 'https' instead of 'http'.

secmgmt/secmgmtopenps-1.0/SecMgmt/New-SecMgmtAccessToken.md

Line 2, Column 1: [Warning-attribute-reserved] Attribute content_git_url is reserved for use by Docs.
Line 2, Column 1: [Warning-title-missing] Missing required attribute: 'title'. Add a title string to show in search engine results.
Line 6, Column 1: [Warning-attribute-reserved] Attribute original_content_git_url is reserved for use by Docs.
Line 278, Column 0: [Warning-insecure-link] Link 'http://go.microsoft.com/fwlink/?LinkID=113216' is insecure. Links to Microsoft sites must use 'https' instead of 'http'.

secmgmt/secmgmtopenps-1.0/SecMgmt/Register-SecMgmtDeviceWithManagement.md

Line 2, Column 1: [Warning-attribute-reserved] Attribute content_git_url is reserved for use by Docs.
Line 2, Column 1: [Warning-title-missing] Missing required attribute: 'title'. Add a title string to show in search engine results.
Line 6, Column 1: [Warning-attribute-reserved] Attribute original_content_git_url is reserved for use by Docs.
Line 155, Column 0: [Warning-insecure-link] Link 'http://go.microsoft.com/fwlink/?LinkID=113216' is insecure. Links to Microsoft sites must use 'https' instead of 'http'.

secmgmt/secmgmtopenps-1.0/SecMgmt/Resolve-SecMgmtError.md

Line 2, Column 1: [Warning-attribute-reserved] Attribute content_git_url is reserved for use by Docs.
Line 2, Column 1: [Warning-title-missing] Missing required attribute: 'title'. Add a title string to show in search engine results.
Line 6, Column 1: [Warning-attribute-reserved] Attribute original_content_git_url is reserved for use by Docs.
Line 86, Column 0: [Warning-insecure-link] Link 'http://go.microsoft.com/fwlink/?LinkID=113216' is insecure. Links to Microsoft sites must use 'https' instead of 'http'.

secmgmt/secmgmtopenps-1.0/SecMgmt/SecMgmt.md

Line 2, Column 1: [Warning-title-missing] Missing required attribute: 'title'. Add a title string to show in search engine results.

secmgmt/secmgmtopenps-1.0/SecMgmt/Unregister-SecMgmtDeviceWithManagement.md

Line 2, Column 1: [Warning-attribute-reserved] Attribute content_git_url is reserved for use by Docs.
Line 2, Column 1: [Warning-title-missing] Missing required attribute: 'title'. Add a title string to show in search engine results.
Line 6, Column 1: [Warning-attribute-reserved] Attribute original_content_git_url is reserved for use by Docs.
Line 67, Column 0: [Warning-insecure-link] Link 'http://go.microsoft.com/fwlink/?LinkID=113216' is insecure. Links to Microsoft sites must use 'https' instead of 'http'.

For more details, please refer to the build report.
If you see build warnings/errors with permission issues, it might be due to single sign-on (SSO) enabled on Microsoft's GitHub organizations. Please follow instructions here to re-authorize your GitHub account to Docs Build.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
Note: Your PR may contain errors or warnings unrelated to the files you changed. This happens when external dependencies like GitHub alias, Microsoft alias, cross repo links are updated. Please use these instructions to resolve them.
For any questions, please:Try searching in the Docs contributor and Admin GuideSee the frequently asked questionsPost your question in the Docs support channel

Docs Build status updates of commit d3eaab9:
:warning: Validation status: warnings

File
Status
Preview URL
Details

secmgmt/secmgmtopenps-1.0/SecMgmt/Connect-SecMgmtAccount.md
:warning:Warning

Details

secmgmt/secmgmtopenps-1.0/SecMgmt/Disconnect-SecMgmtAccount.md
:warning:Warning

Details

secmgmt/secmgmtopenps-1.0/SecMgmt/Initialize-SecMgmtHybirdDeviceEnrollment.md
:warning:Warning

Details

secmgmt/secmgmtopenps-1.0/SecMgmt/Install-SecMgmtInsightsConnector.md
:warning:Warning

Details

secmgmt/secmgmtopenps-1.0/SecMgmt/New-SecMgmtAccessToken.md
:warning:Warning

Details

secmgmt/secmgmtopenps-1.0/SecMgmt/Register-SecMgmtDeviceWithManagement.md
:warning:Warning

Details

secmgmt/secmgmtopenps-1.0/SecMgmt/Resolve-SecMgmtError.md
:warning:Warning

Details

secmgmt/secmgmtopenps-1.0/SecMgmt/SecMgmt.md
:warning:Warning

Details

secmgmt/secmgmtopenps-1.0/SecMgmt/Unregister-SecMgmtDeviceWithManagement.md
:warning:Warning

Details

.openpublishing.publish.config.json
:white_check_mark:Succeeded

secmgmt/breadcrumb/toc.yml
:white_check_mark:Succeeded

secmgmt/docfx.json
:white_check_mark:Succeeded

secmgmt/docs-conceptual/overview.md
:white_check_mark:Succeeded

secmgmt/mapping/monikerMapping.json
:white_check_mark:Succeeded

secmgmt/secmgmtopenps-1.0/SecMgmt/Connect-SecMgmtAccount.md

Line 2, Column 1: [Warning-attribute-reserved] Attribute content_git_url is reserved for use by Docs.
Line 2, Column 1: [Warning-title-missing] Missing required attribute: 'title'. Add a title string to show in search engine results.
Line 6, Column 1: [Warning-attribute-reserved] Attribute original_content_git_url is reserved for use by Docs.
Line 308, Column 0: [Warning-insecure-link] Link 'http://go.microsoft.com/fwlink/?LinkID=113216' is insecure. Links to Microsoft sites must use 'https' instead of 'http'.

secmgmt/secmgmtopenps-1.0/SecMgmt/Disconnect-SecMgmtAccount.md

Line 2, Column 1: [Warning-attribute-reserved] Attribute content_git_url is reserved for use by Docs.
Line 2, Column 1: [Warning-title-missing] Missing required attribute: 'title'. Add a title string to show in search engine results.
Line 6, Column 1: [Warning-attribute-reserved] Attribute original_content_git_url is reserved for use by Docs.
Line 67, Column 0: [Warning-insecure-link] Link 'http://go.microsoft.com/fwlink/?LinkID=113216' is insecure. Links to Microsoft sites must use 'https' instead of 'http'.

secmgmt/secmgmtopenps-1.0/SecMgmt/Initialize-SecMgmtHybirdDeviceEnrollment.md

Line 2, Column 1: [Warning-attribute-reserved] Attribute content_git_url is reserved for use by Docs.
Line 2, Column 1: [Warning-title-missing] Missing required attribute: 'title'. Add a title string to show in search engine results.
Line 6, Column 1: [Warning-attribute-reserved] Attribute original_content_git_url is reserved for use by Docs.
Line 121, Column 0: [Warning-insecure-link] Link 'http://go.microsoft.com/fwlink/?LinkID=113216' is insecure. Links to Microsoft sites must use 'https' instead of 'http'.

secmgmt/secmgmtopenps-1.0/SecMgmt/Install-SecMgmtInsightsConnector.md

Line 2, Column 1: [Warning-attribute-reserved] Attribute content_git_url is reserved for use by Docs.
Line 2, Column 1: [Warning-title-missing] Missing required attribute: 'title'. Add a title string to show in search engine results.
Line 6, Column 1: [Warning-attribute-reserved] Attribute original_content_git_url is reserved for use by Docs.
Line 127, Column 0: [Warning-insecure-link] Link 'http://go.microsoft.com/fwlink/?LinkID=113216' is insecure. Links to Microsoft sites must use 'https' instead of 'http'.

secmgmt/secmgmtopenps-1.0/SecMgmt/New-SecMgmtAccessToken.md

Line 2, Column 1: [Warning-attribute-reserved] Attribute content_git_url is reserved for use by Docs.
Line 2, Column 1: [Warning-title-missing] Missing required attribute: 'title'. Add a title string to show in search engine results.
Line 6, Column 1: [Warning-attribute-reserved] Attribute original_content_git_url is reserved for use by Docs.
Line 278, Column 0: [Warning-insecure-link] Link 'http://go.microsoft.com/fwlink/?LinkID=113216' is insecure. Links to Microsoft sites must use 'https' instead of 'http'.

secmgmt/secmgmtopenps-1.0/SecMgmt/Register-SecMgmtDeviceWithManagement.md

Line 2, Column 1: [Warning-attribute-reserved] Attribute content_git_url is reserved for use by Docs.
Line 2, Column 1: [Warning-title-missing] Missing required attribute: 'title'. Add a title string to show in search engine results.
Line 6, Column 1: [Warning-attribute-reserved] Attribute original_content_git_url is reserved for use by Docs.
Line 155, Column 0: [Warning-insecure-link] Link 'http://go.microsoft.com/fwlink/?LinkID=113216' is insecure. Links to Microsoft sites must use 'https' instead of 'http'.

secmgmt/secmgmtopenps-1.0/SecMgmt/Resolve-SecMgmtError.md

Line 2, Column 1: [Warning-attribute-reserved] Attribute content_git_url is reserved for use by Docs.
Line 2, Column 1: [Warning-title-missing] Missing required attribute: 'title'. Add a title string to show in search engine results.
Line 6, Column 1: [Warning-attribute-reserved] Attribute original_content_git_url is reserved for use by Docs.
Line 86, Column 0: [Warning-insecure-link] Link 'http://go.microsoft.com/fwlink/?LinkID=113216' is insecure. Links to Microsoft sites must use 'https' instead of 'http'.

secmgmt/secmgmtopenps-1.0/SecMgmt/SecMgmt.md

Line 2, Column 1: [Warning-title-missing] Missing required attribute: 'title'. Add a title string to show in search engine results.

secmgmt/secmgmtopenps-1.0/SecMgmt/Unregister-SecMgmtDeviceWithManagement.md

Line 2, Column 1: [Warning-attribute-reserved] Attribute content_git_url is reserved for use by Docs.
Line 2, Column 1: [Warning-title-missing] Missing required attribute: 'title'. Add a title string to show in search engine results.
Line 6, Column 1: [Warning-attribute-reserved] Attribute original_content_git_url is reserved for use by Docs.
Line 67, Column 0: [Warning-insecure-link] Link 'http://go.microsoft.com/fwlink/?LinkID=113216' is insecure. Links to Microsoft sites must use 'https' instead of 'http'.

For more details, please refer to the build report.
If you see build warnings/errors with permission issues, it might be due to single sign-on (SSO) enabled on Microsoft's GitHub organizations. Please follow instructions here to re-authorize your GitHub account to Docs Build.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
Note: Your PR may contain errors or warnings unrelated to the files you changed. This happens when external dependencies like GitHub alias, Microsoft alias, cross repo links are updated. Please use these instructions to resolve them.
For any questions, please:Try searching in the Docs contributor and Admin GuideSee the frequently asked questionsPost your question in the Docs support channel

Docs Build status updates of commit 94ebfbf:
:warning: Validation status: warnings

File
Status
Preview URL
Details

secmgmt/secmgmtopenps-1.0/SecMgmt/Connect-SecMgmtAccount.md
:warning:Warning

Details

secmgmt/secmgmtopenps-1.0/SecMgmt/Disconnect-SecMgmtAccount.md
:warning:Warning

Details

secmgmt/secmgmtopenps-1.0/SecMgmt/Initialize-SecMgmtHybirdDeviceEnrollment.md
:warning:Warning

Details

secmgmt/secmgmtopenps-1.0/SecMgmt/Install-SecMgmtInsightsConnector.md
:warning:Warning

Details

secmgmt/secmgmtopenps-1.0/SecMgmt/New-SecMgmtAccessToken.md
:warning:Warning

Details

secmgmt/secmgmtopenps-1.0/SecMgmt/Register-SecMgmtDeviceWithManagement.md
:warning:Warning

Details

secmgmt/secmgmtopenps-1.0/SecMgmt/Resolve-SecMgmtError.md
:warning:Warning

Details

secmgmt/secmgmtopenps-1.0/SecMgmt/SecMgmt.md
:warning:Warning

Details

secmgmt/secmgmtopenps-1.0/SecMgmt/Unregister-SecMgmtDeviceWithManagement.md
:warning:Warning

Details

.openpublishing.publish.config.json
:white_check_mark:Succeeded

secmgmt/breadcrumb/toc.yml
:white_check_mark:Succeeded

secmgmt/docfx.json
:white_check_mark:Succeeded

secmgmt/docs-conceptual/overview.md
:white_check_mark:Succeeded

secmgmt/mapping/monikerMapping.json
:white_check_mark:Succeeded

secmgmt/secmgmtopenps-1.0/SecMgmt/Connect-SecMgmtAccount.md

Line 2, Column 1: [Warning-attribute-reserved] Attribute content_git_url is reserved for use by Docs.
Line 2, Column 1: [Warning-title-missing] Missing required attribute: 'title'. Add a title string to show in search engine results.
Line 6, Column 1: [Warning-attribute-reserved] Attribute original_content_git_url is reserved for use by Docs.
Line 308, Column 0: [Warning-insecure-link] Link 'http://go.microsoft.com/fwlink/?LinkID=113216' is insecure. Links to Microsoft sites must use 'https' instead of 'http'.

secmgmt/secmgmtopenps-1.0/SecMgmt/Disconnect-SecMgmtAccount.md

Line 2, Column 1: [Warning-attribute-reserved] Attribute content_git_url is reserved for use by Docs.
Line 2, Column 1: [Warning-title-missing] Missing required attribute: 'title'. Add a title string to show in search engine results.
Line 6, Column 1: [Warning-attribute-reserved] Attribute original_content_git_url is reserved for use by Docs.
Line 67, Column 0: [Warning-insecure-link] Link 'http://go.microsoft.com/fwlink/?LinkID=113216' is insecure. Links to Microsoft sites must use 'https' instead of 'http'.

secmgmt/secmgmtopenps-1.0/SecMgmt/Initialize-SecMgmtHybirdDeviceEnrollment.md

Line 2, Column 1: [Warning-attribute-reserved] Attribute content_git_url is reserved for use by Docs.
Line 2, Column 1: [Warning-title-missing] Missing required attribute: 'title'. Add a title string to show in search engine results.
Line 6, Column 1: [Warning-attribute-reserved] Attribute original_content_git_url is reserved for use by Docs.
Line 121, Column 0: [Warning-insecure-link] Link 'http://go.microsoft.com/fwlink/?LinkID=113216' is insecure. Links to Microsoft sites must use 'https' instead of 'http'.

secmgmt/secmgmtopenps-1.0/SecMgmt/Install-SecMgmtInsightsConnector.md

Line 2, Column 1: [Warning-attribute-reserved] Attribute content_git_url is reserved for use by Docs.
Line 2, Column 1: [Warning-title-missing] Missing required attribute: 'title'. Add a title string to show in search engine results.
Line 6, Column 1: [Warning-attribute-reserved] Attribute original_content_git_url is reserved for use by Docs.
Line 127, Column 0: [Warning-insecure-link] Link 'http://go.microsoft.com/fwlink/?LinkID=113216' is insecure. Links to Microsoft sites must use 'https' instead of 'http'.

secmgmt/secmgmtopenps-1.0/SecMgmt/New-SecMgmtAccessToken.md

Line 2, Column 1: [Warning-attribute-reserved] Attribute content_git_url is reserved for use by Docs.
Line 2, Column 1: [Warning-title-missing] Missing required attribute: 'title'. Add a title string to show in search engine results.
Line 6, Column 1: [Warning-attribute-reserved] Attribute original_content_git_url is reserved for use by Docs.
Line 278, Column 0: [Warning-insecure-link] Link 'http://go.microsoft.com/fwlink/?LinkID=113216' is insecure. Links to Microsoft sites must use 'https' instead of 'http'.

secmgmt/secmgmtopenps-1.0/SecMgmt/Register-SecMgmtDeviceWithManagement.md

Line 2, Column 1: [Warning-attribute-reserved] Attribute content_git_url is reserved for use by Docs.
Line 2, Column 1: [Warning-title-missing] Missing required attribute: 'title'. Add a title string to show in search engine results.
Line 6, Column 1: [Warning-attribute-reserved] Attribute original_content_git_url is reserved for use by Docs.
Line 155, Column 0: [Warning-insecure-link] Link 'http://go.microsoft.com/fwlink/?LinkID=113216' is insecure. Links to Microsoft sites must use 'https' instead of 'http'.

secmgmt/secmgmtopenps-1.0/SecMgmt/Resolve-SecMgmtError.md

Line 2, Column 1: [Warning-attribute-reserved] Attribute content_git_url is reserved for use by Docs.
Line 2, Column 1: [Warning-title-missing] Missing required attribute: 'title'. Add a title string to show in search engine results.
Line 6, Column 1: [Warning-attribute-reserved] Attribute original_content_git_url is reserved for use by Docs.
Line 86, Column 0: [Warning-insecure-link] Link 'http://go.microsoft.com/fwlink/?LinkID=113216' is insecure. Links to Microsoft sites must use 'https' instead of 'http'.

secmgmt/secmgmtopenps-1.0/SecMgmt/SecMgmt.md

Line 2, Column 1: [Warning-title-missing] Missing required attribute: 'title'. Add a title string to show in search engine results.

secmgmt/secmgmtopenps-1.0/SecMgmt/Unregister-SecMgmtDeviceWithManagement.md

Line 2, Column 1: [Warning-attribute-reserved] Attribute content_git_url is reserved for use by Docs.
Line 2, Column 1: [Warning-title-missing] Missing required attribute: 'title'. Add a title string to show in search engine results.
Line 6, Column 1: [Warning-attribute-reserved] Attribute original_content_git_url is reserved for use by Docs.
Line 67, Column 0: [Warning-insecure-link] Link 'http://go.microsoft.com/fwlink/?LinkID=113216' is insecure. Links to Microsoft sites must use 'https' instead of 'http'.

For more details, please refer to the build report.
If you see build warnings/errors with permission issues, it might be due to single sign-on (SSO) enabled on Microsoft's GitHub organizations. Please follow instructions here to re-authorize your GitHub account to Docs Build.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
Note: Your PR may contain errors or warnings unrelated to the files you changed. This happens when external dependencies like GitHub alias, Microsoft alias, cross repo links are updated. Please use these instructions to resolve them.
For any questions, please:Try searching in the Docs contributor and Admin GuideSee the frequently asked questionsPost your question in the Docs support channel

Docs Build status updates of commit e238c45:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

.openpublishing.publish.config.json
:white_check_mark:Succeeded

secmgmt/breadcrumb/toc.yml
:white_check_mark:Succeeded

secmgmt/docfx.json
:white_check_mark:Succeeded

secmgmt/docs-conceptual/overview.md
:white_check_mark:Succeeded

secmgmt/mapping/monikerMapping.json
:white_check_mark:Succeeded

secmgmt/secmgmtopenps-1.0/SecMgmt/Connect-SecMgmtAccount.md
:white_check_mark:Succeeded

secmgmt/secmgmtopenps-1.0/SecMgmt/Disconnect-SecMgmtAccount.md
:white_check_mark:Succeeded

secmgmt/secmgmtopenps-1.0/SecMgmt/Initialize-SecMgmtHybirdDeviceEnrollment.md
:white_check_mark:Succeeded

secmgmt/secmgmtopenps-1.0/SecMgmt/Install-SecMgmtInsightsConnector.md
:white_check_mark:Succeeded

secmgmt/secmgmtopenps-1.0/SecMgmt/New-SecMgmtAccessToken.md
:white_check_mark:Succeeded

secmgmt/secmgmtopenps-1.0/SecMgmt/Register-SecMgmtDeviceWithManagement.md
:white_check_mark:Succeeded

secmgmt/secmgmtopenps-1.0/SecMgmt/Resolve-SecMgmtError.md
:white_check_mark:Succeeded

secmgmt/secmgmtopenps-1.0/SecMgmt/SecMgmt.md
:white_check_mark:Succeeded

secmgmt/secmgmtopenps-1.0/SecMgmt/Unregister-SecMgmtDeviceWithManagement.md
:white_check_mark:Succeeded

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching in the Docs contributor and Admin GuideSee the frequently asked questionsPost your question in the Docs support channel

Docs Build status updates of commit 50ed0c0:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

.openpublishing.publish.config.json
:white_check_mark:Succeeded

secmgmt/breadcrumb/toc.yml
:white_check_mark:Succeeded

secmgmt/docfx.json
:white_check_mark:Succeeded

secmgmt/docs-conceptual/overview.md
:white_check_mark:Succeeded

secmgmt/docs-conceptual/toc.yml
:white_check_mark:Succeeded

secmgmt/mapping/monikerMapping.json
:white_check_mark:Succeeded

secmgmt/secmgmtopenps-1.0/SecMgmt/Connect-SecMgmtAccount.md
:white_check_mark:Succeeded

secmgmt/secmgmtopenps-1.0/SecMgmt/Disconnect-SecMgmtAccount.md
:white_check_mark:Succeeded

secmgmt/secmgmtopenps-1.0/SecMgmt/Initialize-SecMgmtHybirdDeviceEnrollment.md
:white_check_mark:Succeeded

secmgmt/secmgmtopenps-1.0/SecMgmt/Install-SecMgmtInsightsConnector.md
:white_check_mark:Succeeded

secmgmt/secmgmtopenps-1.0/SecMgmt/New-SecMgmtAccessToken.md
:white_check_mark:Succeeded

secmgmt/secmgmtopenps-1.0/SecMgmt/Register-SecMgmtDeviceWithManagement.md
:white_check_mark:Succeeded

secmgmt/secmgmtopenps-1.0/SecMgmt/Resolve-SecMgmtError.md
:white_check_mark:Succeeded

secmgmt/secmgmtopenps-1.0/SecMgmt/SecMgmt.md
:white_check_mark:Succeeded

secmgmt/secmgmtopenps-1.0/SecMgmt/Unregister-SecMgmtDeviceWithManagement.md
:white_check_mark:Succeeded

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching in the Docs contributor and Admin GuideSee the frequently asked questionsPost your question in the Docs support channel


Connect a bluetooth transmitter to balenasound pi3b?

Forgive me if this sounds very obvious, but am wondering if the following would be feasible...
I want to stream my vinyl records in a mutliroom setup.
Turntable is connected to an amp with a phono pre-amp and a tape out RCA
If I connect a Bluetooth transmitter to the tape out RCA on the amp, I should be able to transmit the analogue signal over Bluetooth
My question is how would I pair the pi3b with Balenasound?  Given that there is no display to choose the device (as there is on a phone pairing)...
Once this is connected, am I right to assume that a multiple room streaming solution could be setup with extra pi3B units.... The master unit connected to source via bluetooth, and transmitting to the other rooms?
Any help much appreciated!
Cheers,
James

Hi @Sharpey79, balenaSound relies on the devices that connect to it to establish the bluetooth connection (i.e: choose the appropriate balenaSound bluetooth device, enter PIN code if required, etc). This works the same way it would if you had a bluetooth speaker: the speaker creates the bluetooth connection for others to connect to.
I'm curious about this bluetooth transmitter, it should have capabilities to achieve this. Do you have a link or model/make I can check out?

Hey, thanks for your reply.  I was thinking of one of the miccus products... the one I'm linking to here works with the headphone jack..   Do you reckon it would work?
https://cdn.shopify.com/s/files/1/0019/0486/9449/files/Swivel_Jack_User_Manual-120118.pdf?93
Thanks for taking the time. I do appreciate it!

Hi, I'm checking the manual for the Swivel and it doesn't appear to allow headless connections, you need the other device to initiate the connection. This unfortunately wont work with balenaSound as it will also expect the other device to initiate the connection. We could theoretically add a UI sort of interface to allow this but it's quite outside the scope of this project unfortunately.
As an alternative, you could get an RCA to 3.5mm cable and send the audio from the preamp to the Pi, right? Would that work for you?

@tmigone wouldnt bluetoothctl work? He Sharpey access to the terminal.

Yes I think with bluetoothctl it could be done. But it would require user input for sure (to run the commands, identify the target connection, and pair with it, basically everything you do with your phone but on the device).
Unless I'm missing something I don't see how we could achieve this to be done automatically and in a generic way. If you have any ideas we can try!

@tmigone didnt you implement auto reconnection?

Yep, but I don't think it helps here. My main concern is how do you tell balenaSound which bluetooth it should connect to initially?
Usually you have the device (smartphone) telling balenaSound that it wants to connect via bluetooth. balenaSound only accepts the connection.
Here the Swivel thing can't tell balenaSound that it wants to connect because it has no physical interface to do so. So balenaSound could theoretically initiate the connection, but there is two questions:

How does sound know it has to scan for bluetooth networks instead of expecting an incoming connection?
How does sound know which bluetooth it has to connect to?

I guess you could hack something with env vars and bluetoothctl, is that what you are thinking?

Yes. Deleting some lines of code and setting the bluetooth reconnect volume to the mac of the Swivel would get it reconnecting to the Swivel on every boot.

Deleting some lines and paring once via terminal
Get the mac adress of the Swivel (We can use nano to edit the reconnect entry)

For point 1, the fact that you depend on pairing via terminal once is what I don't like too much as it's not very user friendly. But you are right that it could work. If you want to give it a shot when you have free cycles let's do it! Probably hard to test since you won't have the Swivel, but if @Sharpey79 also helps you guys could make it work!

Yeah, I'd need to buy the swivel first, which I'm happy to do since I can use it with Bluetooth speakers as a backup.

Also, yes I could just connect the preamp to the pi 3.5 jack... But will balena sound broadcast the signal to other pi units in a multiroom setup? My assumption was that balena sound was only configured to do audio out via the 3.5jack.

Also, thanks guys. Really appreciate your help.

Update, I bought a bluetooth emitter/receiver and will be trying this out soon.

Yeah, I'd need to buy the swivel first, which I'm happy to do since I can use it with Bluetooth speakers as a backup.

Did you get it to work?


rosetta: ethiopian_multiplication

Signed-off-by: Renata Carvalho<EMAIL_ADDRESS>

There seems to be several indentations problems in your code, mostly a mix of tabs and spaces, can you uniformize it all ?
Other than that, I'd say :shipit:


Remove FrameCount in favor of Bevy counterpart

Issues
Fixes https://github.com/Leafwing-Studios/leafwing_input_playback/issues/29 - Use built-in frame count
Changes

Replaces FrameCount with bevy counterpart in all places
Updates system scheduling constraints based on new FrameCount behavior -- this crate's FrameCount was updated in First rather than Last
Update tests to account for changes in behavior due to system scheduling differences

Notes
Previous FrameCount implementation uses saturating_ add/sub operations, but based on the documentation for FrameCount, it seems that wrapping_ would be more appropriate. I changed any + operators to use wrapping_ functions to be specific for now.
Also, let me know if I have removed any intended effects of the playback tests. I tried to reflect the original intent to the best of my ability.

@alice-i-cecile I don't see a CHANGELOG.md in this project. Would you like me to start one, or should I draft my notes in RELEASES.md for a future release?

Also, thanks for jumping in to help out! Sorry for the random burst of noise from my end!

Ah sorry, I meant RELEASES.md! And no worries at all; it's very welcome.

OK -- I added a section for v0.6 and included release notes for this PR and #37 since I didn't follow suit there

Awesome. Ping me on Discord when you think that we're ready for the release of 0.6?


Build the Pop-up Screen using the pre-built components

We want to build the pop-up for the extension as designed.

Acceptance Criteria

The pop-up should look like the design
All the buttons and UI elements should be visible on the pop-up
The settings icon should navigate to the options page with the text "extension settings page" on it.

NB: Beyond navigating to a blank, no other functionality is required. i.e. Do not add the block functionality for now.

Can I go ahead to do this?

Oh! Sorry this has been assigned to someone, my bad!

Yeah@Riri202 is doing it already

Yes. I'm done with it but since we agreed there'll be styling changes, I'm waiting for the final design so I can implement that.


Couldn't start the Hello World example. [.Net Hello World tutorial]

Problem encountered on https://dotnet.microsoft.com/learn/dotnet/hello-world-tutorial/create
Operating System: windows
Provide details about the problem you're experiencing. Include your operating system version, exact error message, code sample, and anything else that is relevant.
OS: Windows 10 home single language, ver 1909, compilation: 18363.900
Error: En línea: 1 Carácter: 6 (line: 1 Character: 6)

using System;

 ~

Falta la directiva using (Misses directive using)
En línea: 7 Carácter: 20 (line: 7 Character: 20

    static void Main(string[] args)

               ~

Falta '(' en la lista de parámetros del método de la clase. (Misses '(' in the list of class methods parameters)
En línea: 7 Carácter: 20

    static void Main(string[] args)

               ~

Falta el cuerpo de función en la declaración function . (Misses in the function body declaration of function)
+ CategoryInfo          : ParserError: (:) [], ParentContainsErrorRecordException
+ FullyQualifiedErrorId : MissingUsingStatementDirective

You don't need to type that. We were just showing the contents of the Program.cs file created by the command in that step.
I'll see if I can improve that so it's more clear. You should be able to go to the next step and run dotnet run and continue with the tutorial.
I'd also recommend that you don't create your apps under the C:\Windows\system32 path.

Thank you for the response.
Actually figured that out after two hours (LOL) and managed to understand that the .cs was a CSharp file.
Also got away from the system32, do not want to "make my computer faster" or "download more RAM" with the modification of that folder...
(Jokes...)


Call super correctly to avoid uncaught exceptions during error handling

One-line summary
Fixes error message displayed to user when the config file does not contain required fields.
Description
When the user tries to apply a manifest file with invalid format (eg. that doesn't contain required field kind), following output is returned:
$ clin apply -e staging --token "$TOKEN" ./manifest-without-kind.yaml
super() argument 1 must be type, not PosixPath
Traceback (most recent call last):
  File "/home/dlippok/.local/lib/python3.8/site-packages/clin/yamlops.py", line 164, in load_manifest
    return Envelope.from_manifest(manifest)
  File "/home/dlippok/.local/lib/python3.8/site-packages/clin/models/shared.py", line 137, in from_manifest
    raise ValueError("Required field `kind` not found")
ValueError: Required field `kind` not found

During handling of the above exception, another exception occurred:

Traceback (most recent call last):
  File "/home/dlippok/.local/lib/python3.8/site-packages/clin/run.py", line 88, in apply
    envelope = load_manifest(Path(file), DEFAULT_YAML_LOADER, os.environ)
  File "/home/dlippok/.local/lib/python3.8/site-packages/clin/yamlops.py", line 166, in load_manifest
    raise YamlInvalidFormatError(file_path, str(e))
  File "/home/dlippok/.local/lib/python3.8/site-packages/clin/yamlops.py", line 150, in __init__
    super(file)
TypeError: super() argument 1 must be type, not PosixPath

This PR fixes the exception handling, so that no uncaught exception is thrown. This results in following output:
$ clin apply -e staging --token "$TOKEN" ./manifest-without-kind.yaml
Required field `kind` not found in ./manifest-without-kind.yaml

Types of Changes

Bug fix (non-breaking change which fixes an issue)

👍


Inaccessable Dimention

I created a mining world and set up an alternate teleportation system to get me there.  I should have left RFTools teleport system in place, but I didn't, and my alternate system broke.  How can I get back into my dimension?!?  If I can just get back in there once, I can fix everything!

Never mind!  I just found out about using the dimension editor to send over a mater transporter!


Some ads loop

Script: Ver 3.2
PC: Windows 10, Chrome
As the ad begins, it pauses and restarts. Keeps looping very fast. Fix by refreshing the page.
Developer tool revealed loop in script line 165 and 214

Check out 3.3, This should now be fixed.
(Closed as duplicate issue)


Editable accordion title

@nileshgulia1 Please check CI

I think this will over complicate things. Let's keep it simple using a Input instead.


refactor exchange restore to use interfaces

refactors exchange restore from near-duplicate per-category functions and switch-based process trees with interfaces.
At the top of restoring all collections, each category creates a categoryRestoreHandler to supply the necessary restore behavior.  The appropriate handler gets passed in to the collection restore, and all restore code after that takes a single path using a common restore interface to switch between categorical behavior.

Does this PR need a docs update or release note?

[x] :no_entry: No

Type of change

[x] :broom: Tech Debt/Cleanup

Issue(s)

#1996

Test Plan

[x] :zap: Unit test
[x] :green_heart: E2E

@ashmrtn @meain this PR and the next (1996-exchange-2) are ready for review, please and thank you.

@meain @ashmrtn  okay, wow, getting those tests to work again was a headache.  This (and the part 2 PR, please), should be ready for review.

@ashmrtn Updated and ready for final review.


Fix refresh token behavior

Fixes https://github.com/workos/authkit-remix/issues/7 while ensuring the burden is not put on the consumer to commit the session in every application endpoint.

🙏 appreciate the effort, closing this since we rolled out a fix and some other major changes.


Add passthrough argument for add-host

docker run has an argument --add-host which adds a line to /etc/hosts. This PR adds a pass-through argument to iam-docker-run to utilize that feature.

This is to address issue #5


Recursive type shouldn't typecheck but it does

TypeScript Version:  3.5.1

Search Terms: Recursive Type Indexer
Code
type RecursiveType =
  | { [x: number]: string }
  | { [x: string]: RecursiveType };

const X: RecursiveType = {a:1};

Expected behavior:
This should fail to typecheck. 1 is not a subtype of { [x:number]: string}, or if it is then const X: RecursiveType = 1; should typecheck, but it doesn't
Actual behavior:
The code typechecks
Playground Link:
http://www.typescriptlang.org/play/#code/C4TwDgpgBAShDGBXATgZwJYDcIBVzQF4AoKKAHygG8oBtADwC4oA7RAWwCMJkBdJ1YMnTMA5lAC+JclVqMoAoaL6wEKDNjyQJAbiJF4Ae2YCoADSZwkaLLnxQCVAIYMAjOO1A
and equivalent code in flow which does the expected thing:
https://flow.org/try/#0C4TwDgpgBAShDGBXATgZwJYDcIBVzQF4AoKKAHygG8oBtAO0QFsAjCZAXQC4pVhl06AcygBfEuSq1e-IV1gIUGbHkiiA3ESLwA9nV5QAGtzhI0WXPigEqAQ04BGEWqA

Correctly errors now


Add code coverage report service

Codecov Report

:exclamation: No coverage uploaded for pull request base (main@8f4c5e6). Click here to learn what that means.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main      #53   +/-   ##
=======================================
  Coverage        ?   98.72%
=======================================
  Files           ?        7
  Lines           ?      629
  Branches        ?       17
=======================================
  Hits            ?      621
  Misses          ?        8
  Partials        ?        0

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.


Why Beatify JSX crashed?

Description
The results of beautification are not what I expect.
Expected Results
The beautified code should have looked like:
  class DateField extends React.Component {
            render() {
                return ( <
                    div className = "App-searchForm-dateField" >
                    <
                    p > Дата отправления < /p> <
                    input type = "date"
                    name = "date" / >
                    <
                    /div>
                )
            }
        }

Steps to Reproduce

Add code to Atom editor
Run command Atom Beautify: Beautify Editor
This beautified code does not look right!

Debug
Here is a link to the debug.md Gist: https://gist.github.com/09cbf5ad714732e0ebd9c6f0bc8cc074
Checklist

[ ] I have tried uninstalling and reinstalling Atom Beautify to ensure it installed properly
[ ] I have reloaded (or restarted) Atom to ensure it is not a caching issue
[ ] Searched for existing Atom Beautify Issues at https://github.com/Glavin001/atom-beautify/issues
so I know this is not a duplicate issue
[ ] Generated debugging information and added link for debug.md Gist to this issue

In the code sample from the gist class CitySelect appears to be missing a closing curly brace.  I entered the code sample into the web tools for Pretty Diff and JSBeautify and neither crashed.  I would have to attempt to reproduce later in Atom using the inspector.
Adding @bitwiseman in case he is aware of anything.

I'm not aware of anything, but it looks like the "expected output" above looks like e4x is not turned on.

I got what it was. This happens when i try beatify * .js file containing syntax *.jsx

I would be happy to review and merge someone's Pull Request for Atom-Beautify's JS-Beautify beautifier changing JSX case to set e4x option at https://github.com/Glavin001/atom-beautify/blob/master/src/beautifiers/js-beautify.coffee#L36

I would be happy to review and merge someone's Pull Request for Atom-Beautify's JS-Beautify beautifier changing JSX case to set e4x option at https://github.com/Glavin001/atom-beautify/blob/master/src/beautifiers/js-beautify.coffee#L36

I may not get this issue correctly, but I also have the problem that AtomBeautify completely "destroys" JSX files if they have the extension .js instead of .jsx. Unfortunately, this is the case in many React tutorials and also in the scaffolds Create React App is producing. I would love to see this supported in Atom, but unfortunately I am not deep enough into Atom to provide a PR for that.

@derwaldgeist The problem in that case is that jsbeautify requires an option setting to make JSX work correctly, which is not triggered if it doesn't have to be.

Ok, thanks for the info.

I just looked at this and the problem appears unchanged.


[Ref] Remove unaligned constructors

Closes #1720

@jswrenn Feel free to review, but I'm going to hold off on merging until the Fuchsia vendor CL passes all of its CQ tests.

Codecov Report
Attention: Patch coverage is 0% with 6 lines in your changes missing coverage. Please review.

Project coverage is 88.11%. Comparing base (4426bb2) to head (376dab3).
Report is 2 commits behind head on main.

Files with missing lines
Patch %
Lines

src/deprecated.rs
0.00%
6 Missing :warning:

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1723      +/-   ##
==========================================
- Coverage   88.61%   88.11%   -0.51%
==========================================
  Files          16       16
  Lines        5858     5720     -138
==========================================
- Hits         5191     5040     -151
- Misses        667      680      +13

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

@jswrenn Feel free to review, but I'm going to hold off on merging until the Fuchsia vendor CL passes all of its CQ tests.

Okay everything is passing other than asan tests, which are always flaky. I'm comfortable merging this. I'll mark as "merge when ready".


Enhancing Support for Sentence and WORD Delimiters in Chinese and Japanese

Chinese and Japanese, unlike English which relies on spaces for separation, use distinct punctuation marks such as full stops (。), exclamation marks (！), and question marks (？) to denote the end of sentences. Additionally, within sentences, smaller units are marked by punctuation such as commas (，), enumeration commas (、), and semicolons (；).
I propose the incorporation of additional options for Sentence Delimiters and WORD Separators to improve Vim's command responsiveness, including W, E, B, (, and ), within environments utilizing Chinese, Japanese, and similar languages.
Is implementing this feature challenging?
Two relevant plugins have been assessed:

fuenor/jpmoveword.vim enhances W, E, B command functionality in Chinese and Japanese scripts. While it doesn't fully manage Chinese and Japanese WORDs, it enables user-defined separators like '、，；：。！？', significantly enhancing Vim's default capabilities.
Preservim/vim-textobj-sentence aimed to "Allow users to specify additional sentence terminators," yet has seen no fruition despite years of effort.

A comprehensive solution remains elusive. As a layperson without programming expertise, the technical intricacies of this problem are beyond me. I urge the Vim official team to commit resources to address this issue.
Desired Solution

For Sentence Segmentation: Recognizing the challenge of solving all issues given the complexity of real-world scenarios, my aim is to tackle the most frequent cases. A simple method can include using full stops (。), exclamation marks (！), and question marks (？) for straightforward sentence segmentation.

Challenging Scenarios:

Punctuation within quotes does not always signal sentence end.
Punctuation in book titles does not conclude sentences.
Brand name punctuation (like Yahoo!) does not signify sentence end.
Addressing unmatched quotes in the face of hard line breaks.
Dealing with bilingual texts, particularly combinations like Chinese+German or German+French.

For WORD Segmentation: A perfect, highly intelligent solution is unrealistic without semantic comprehension. A pragmatic approach, utilizing enumeration commas (、), commas (，), and semicolons (；) as temporary WORD separators, is preferred.

Overall: Aim to provide users with numerous choices to maximize Vim's efficiency in managing Chinese and other multilingual settings.

this is more like a spec but not a bug, :smile:
// you may need to find a right place to discuss it.
// BTW: i've see some similar before, and you should be know chinese word is different like english word.
--
shane.xb.qian

this is more like a spec but not a bug, 😄

This is a Feature request, not Bug report.

AFAIK the lowercased w already recognizes these punctuation marks.


tsplot: add to notebooks

I rebased this for a cleaner commit history.

perfect, thanks. I dont think we want to commit the image though

Just pushed an amended commit without the image.


Add ids to commands

We need a way to associate responses with requests since the communication is supposed to be async. We already have a counter internally but we don’t put that in the responses. Also I think the id should be provided by the IDE in the request instead of provided by us.
I propose that we wrap each response in something like
{"id": 1234,
  "content": {},
  "type": "typeresponse"}

The type can be used by the IDE to dispatch to the correct handler. It’s not essential since it could store the response it expects when it makes a request, but I imagine that for a lot of commands this would be the only thing it would need to store, so it’s nice to remove that burden by providing it on our side.

The dispatcher is put together to use an id.
It is up to the individual transport whether it manages the ids internally or exposes them to the IDE.
If the transport only ever operates in sync mode then there is no need to expose it.
But it could easily be added to WireRequest / WireResponse for the JsonStdio transport.


Method not found when calling chain_getRuntimeVersion

chain_getRuntimeVersion no longer exists, possibly related to #1679
curl -H 'Content-Type: application/json' -d '{ "jsonrpc": "2.0", "method":"chain_getRuntimeVersion", "params":[], "id": 1 }' http://localhost:9933/
{"jsonrpc":"2.0","error":{"code":-32601,"message":"Method not found"},"id":1}

@jacogr Maybe should fix it on polkadot.js side to use state_getRuntimeVersion and remove chain_getRuntimeVersion? but state.getRuntimeVersion is missing anyway

Ok, this is problematic. Since the APIs needs to support both old and new chains and this is not detectable without a call. (If moved and not just deprecated with new version)
If this was a move of endpoints, will look at it a bit later to try and find a solution for this ASAP since we seem to have broken apps out there.

Probably a bug in jsonrpc-derive. Investigating.

@ascjones Tested, does the trick for me on latest master, thank you.


Improve formating, sectioning, etc in general edit of docs

In recent version we have built up the online docs: https://contributor.r-project.org/r-dev-env/.
The quality could be improved with a general edit. Some particular issues I have noticed:

Inconsistency in list/section style
Some sections use enumerated lists, e.g. creating codespace, some use 1) style numbering which is not recognised as a markdown list, e.g. Running R, some use this style in subsection headers, e.g. updating source code. It would be good to have more consistency, using proper markdown enumerated lists or unnumbered sections where appropriate. Note that subsections get added to the navigation - not sure what the limit is, but even level 4 headers are added - and these allow you to use anchored links, which can be helpful, e.g. Close R terminal. It would also be good to add permalinks to the section headers, perhaps with a link symbol.

Issues in page/section headers
Sometimes page headers are (effectively) duplicated, e.g. Start Workspace, other times they need separating out from list/sub-section headers, e.g.
1. Example Contribution Workflow using the R Dev Container: in the R Contribution Workflow section is really a title for the whole page, not just item 1 of the list.

Incorrect indentation
We mostly caught this in the initial PR review, but there are still some stray examples, e.g. the > Before edit paragraph in the Editing Source Code section needs to be indented so that it aligns under point 2 in the list.

Having some fresh eyes review and edit the documentation as a whole would be very helpful!

Taking advantage of further features of mkdocs could also come into this general edit, e.g. can we add search to the docs?


[Question] Cluster Consul

Hey folks,
I'd like to ask if there is any intention to revive the consul branch and add consul to the supported technologies?
BTW: I tried to integrate the branch in the state of the current master, but failed in doing so (due to some dependency errors that I cannot really get sorted).
Regards,
Mario

From the first line of the README:

This project is now superseded by code in Spring Integration. All the interfaces here have counterparts in the main Spring libraries, and the implementations are mostly parallel too (etcd is an exception because of the lack of support for v3 in third party libraries). The 1.0.1 release deprecates everything in favour of Spring Integration.

Anything in this project is now deprecated. There would need to be code in spring-integration similar to this https://github.com/spring-projects/spring-integration/tree/master/spring-integration-zookeeper


Propose code separation for serverless in modularized environment

Description
Changes proposed in this pull request:

...
...
...

Related issue(s)

@m00g3n pls move to a separate file ( not in the root readme file ) and merge it


HLM-1551

@neel-tw @saiprakash-eGov

Requires a mapping update in the index. Have requested to make this change cc: @bhanuprakash-egov

Done @neel-tw


Failed to launch Tamper

Hi, an error occurs when trying to launch Tamper:
Failed to attach to https://chrome.google.com/webstore/detail/tamper-dev/mdemppnhjflbejfbnlddahjbpdbeejnn/related - probably because of enterprise policies.

Environments:
Linux x86_64
Chrome Version 89.0.4389.90 (Official Build) (64-bit)

Yes, chrome.google.com is not allowed to have chrome extensions :-(

OMEGALOL, my bad. But it same when try on another sites.

Which sites? Maybe it's due to another Chrome Extension. See #199 for example.

Which sites? Maybe it's due to another Chrome Extension. See #199 for example.

Like youtube.com. I've read that related issue, but I can't identify which extension has an enterprise policy.
Workaround
Browse to chrome://policy, see which extensions have enterprise policies, uninstall them (GNOME Shell integration in my case), finally restarting Chrome. It should be working!


UserFriendly Exceptions on Login don't throw

In the Login View, the userfriendly exceptions are not displayed. Even in the example of the project on GitHub. But on the project (demo online) it works.
The post are made by jquery with abp.ajax, how can i handle the messages errors like user/pass invalid and display them ?

Hi Diego,
Here's how I was able to get access to the success and error callbacks. This may not be the optimal way, but one that I could make work.  Also in this example I'm using mvc razor views and I'm not logged into my Angular SPA application.  My public facing website is MVC using ABP and then once authenticated and logged in, I'm using Angular SPA views/controllers, etc.
I did lots of trial and error attempting to get access to the deferred and promise objects from abp.ui.setBusy(), but wasn't able to for some reason.
Noticed in the code below I named "onSuccess" and "onError" callback functions, but those could have easily just been in-lined.
Here's the code I'm using in the login.js file.  For some reason the mvc account control is returning a 500 response code.

var deferred = null;
    abp.ui.setBusy(
        $('#LoginArea'),
        deferred = abp.ajax({
            url: '/Account/Login',
            type: 'POST',
            success: onSuccess,
            error: onError,
                data: JSON.stringify({
                    usernameOrEmailAddress: $('#EmailAddressInput').val(),
                    password: $('#PasswordInput').val(),
                    rememberMe: $('#RememberMeInput').is(':checked'),
                    tenancyName: 'Default'
                })
            })
    );

    function onSuccess(data) {
        console.log('onSuccess');
    }

    function onError(data) {
        if (data && data.status === 500) {
            console.log('500 error code');
        }
        console.log('onError');
        abp.notify.error('We were unable to login using credentials provided.');

        $('#login-message-area').css('display', '');
        $('#login-message').text('We were unable to login you in.');

    }

Hope this helps,
Chris

If you use the login method code from example project, you get a 500 error because the login method threw exception when login failed, you may change this by returning a result with success of fail with additional info instead of threwing exeption, and use the return result to show a friendly message with respect to it

"Update with code"
If you use the login method code from example project, you get a 500 error because the login method threw exception when login failed, you have two solutions.
Solution: The error callback should accept three parameters, the third parameter will be your friendly message so the function from Chris will be
function onError(xhr, foo, friendlyError) {
        console.log('onError');
        abp.notify.error(friendlyError);

        $('#login-message-area').css('display', '');
        $('#login-message').text(friendlyError);
   }

Second Solution: you may change the login method to return a result with fail status with additional info instead of throwing exception, the will call abp function HandleData and will also call your error callback this can be done as following
return Json(new MvcAjaxResponse { Success = false, Error = new Abp.Web.Models.ErrorInfo(0, "Invalid user name or password") }); // 0 is the error code

but in this case you will use error call back with one parameter only, and Chris function will be
function onError(data) {
        console.log('onError');
        abp.notify.error(data.message);

        $('#login-message-area').css('display', '');
        $('#login-message').text(data.message);
    }

Thanks Emaish for providing that additional guidance. This makes more sense to me now and I've changed my approach on Login and Registration to return MvcAjaxResponse.

Guys, thanks 4 reply ! I tried to customize the error with friendly message, but it didn't work ! Now it's clear, thanks Emaish for the tip !
I just don't understand because on the demo online it seems to work natively with UFexception.

I'm glad it helped you :+1:  :)

Thanks, this really helped.

@fireheadbr @brendan-rice @langman66 @emaish You guys don't need to do this at all. The UserFriendlyException generates a proper MvcAjaxResponse through the HandleException class inside Abp.
The reason you guys are not seeing anything is due to line 44. To resolve this, turn customErrors on in your web.config and then it'll start alerting instead of just throwing to the log!

close the issue please


Limits

Hey,
To the best of your knowledge, do all endpoints have limits? I know login has limits and if the limit is reached, it's necessary to wait 24-48 hours, is this the same for all endpoints? Or other endpoints have a different refresh time, for example?

I confirm Instagram all end points have rate limits.

Hey,
But do we have information about the limit and reset time of any endpoints?

Hey,
But do we have information about the limit and reset time of any endpoints?

I believe its dependent on previous rate limits


refactor(@schematics/angular): move codelyzer rules to app & lib schematics

Proposed solution for #14130
Relocated codelyzer recommended rules to the tslint.json.template in the application and library schematics.
Open to suggestions on how to create a covering spec for this kind of change.

Hi, thanks for your contribution, however we are closing this as per https://github.com/angular/angular-cli/issues/14130#issuecomment-484635089


feat: add ignore projects and languages files

Description
Add option ignore for projects and languages files
Close #5
Check List

[x] The commit message is formatted
[x] New functionality includes testing
[ ] New functionality has been documented
[ ] All user-facing changes accompanied by the correspondent documentation
[x] All tests pass
[x] PR include resolved issues
[x] PR include description

:tada: This PR is included in version 1.1.0 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


Fleet Analytics Report Followup

User Story
We want to view more information about the fleet and see specific reports on Google Data Studio.
Notes
We currently have the following data displayed on our Fleet Report in Google Data Studios:

What's the average uptime of all our hotspots. What's the longest a hotspot has been up for?
What percentage of all our hotspots are synced
What percentage of all hotspots are online (Balena)
What version are hotspots that are down running?
Firmware version across the fleet with the variation + frequency
Number of devices online/offline/synced/unsynced over time

We want to add some more data to the report to show more information about our fleet and create some more graphs/charts to display this data.
List of potential charts we can add:

More detailed charts that drill down deeper into the specifics of the data present
(Add More)

Copying my features requests from the other thread in here:

time since last PoC activity (might be a bit more complex)
storage used(less than 20%, 40%, 60%,... , full)
earnings per day (amount of hotspots earning 0,1HNT, 0,2HNT, ... per day)
split between sub frequencies (AS923, AU915, etc)
miners connected to blockchain
Lora status by sub frequency
ECC detected
Wifi detected


infra: Make comments in Paginate.tsx only describe their own line of code

This is a really small change. It just deletes one character in a code comment to rectify a typo.

Thank you!

Thank you!