Use the background image on every screen

This requires too much passing around of the background_image variable,
but good enough for now till the settings system has been reworked

As far as i can see this would obscure the view on the world when in-game, you should handle the in-game scenario differently.

I'm going to rebase this on #139, as it's relevant for how to retrieve the background image from the settings.

@terrarier2111 fixed.

Fixed by https://github.com/Lea-fish/Leafish/pull/198/commits/88ab33d19c42b63762bece4d90c3e3b92976a0b0


Add --delete flag to aid trimming worlds

When a new version of the game comes along, it is useful to be able to delete chunks based on some criteria, like InhabitedTime being 0.
This change adds a --delete flag to NBTUtil that deletes the node or nodes specified by --path. It also restructures how the nodes were iterated over to allow them to be deleted.
NBTUtil can then be wrapped in a script that reads the data from each chunk and calls NBTUtil --delete on the chunk if the criteria are met.

I wrote a script to leverage this feature, but it's really slow (something like 1s/chunk):
https://gist.github.com/jkunkee/71847e1565e2152cf4c1e42b6aa6cd9e


Unable to get token

Issue Type: Bug

Click on sign in to github.com.
Click on continue in the new browser tab.
"Oh no! An error occurred!"

Extension version: 0.8.0
VS Code version: Code 1.35.0 (553cfb2c2205db5f15f3ee8395bbd5cf066d357d, 2019-06-04T01:16:40.241Z)
OS version: Darwin x64 18.6.0

Closing as a duplicate of https://github.com/microsoft/vscode-pull-request-github/issues/1221


fix:  LSDV-E-135: Dependabot updates

PR fulfills these requirements

[ ] Commit message(s) and PR title follows the format [fix|feat|ci|chore|doc]: TICKET-ID: Short description of change made ex. fix: DEV-XXXX: Removed inconsistent code usage causing intermittent errors
[ ] Tests for the changes have been added/updated (for bug fixes/features)
[ ] Docs have been added/updated (for bug fixes/features)
[ ] Best efforts were made to ensure docs/code are concise and coherent (checked for spelling/grammatical errors, commented out code, debug logs etc.)
[ ] Self-reviewed and ran all changes on a local instance (for bug fixes/features)

Change has impacts in these area(s)
(check all that apply)

[ ] Product design
[ ] Frontend

Describe the reason for change
(link to issue, supportive screenshots etc.)
What does this fix?
(if this is a bug fix)
What is the new behavior?
(if this is a breaking or feature change)
What is the current behavior?
(if this is a breaking or feature change)
What libraries were added/updated?
(list all with version changes)
Does this change affect performance?
(if so describe the impacts positive or negative)
Does this change affect security?
(if so describe the impacts positive or negative)
What alternative approaches were there?
(briefly list any if applicable)
What feature flags were used to cover this change?
(briefly list any if applicable)
Does this PR introduce a breaking change?
(check only one)

[ ] Yes, and covered entirely by feature flag(s)
[ ] Yes, and covered partially by feature flag(s)
[ ] No
[ ] Not sure (briefly explain the situation below)

What level of testing was included in the change?
(check all that apply)

[ ] e2e
[ ] integration
[ ] unit

Which logical domain(s) does this change affect?
(for bug fixes/features, be as precise as possible. ex. Authentication, Annotation History, Review Stream etc.)

Codecov Report
Patch coverage has no change and project coverage change: -0.12 :warning:

Comparison is base (e45dea2) 65.56% compared to head (02015ca) 65.45%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1430      +/-   ##
==========================================
- Coverage   65.56%   65.45%   -0.12%
==========================================
  Files         436      436
  Lines       27303    27303
  Branches     7243     7246       +3
==========================================
- Hits        17901    17870      -31
- Misses       8079     8102      +23
- Partials     1323     1331       +8

see 6 files with indirect coverage changes

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.


Is it possible to specify a schema for CUD events so that neo4j has properties correctly typed?

From https://neo4j.com/labs/kafka/4.0/consumer/ it seems that CUD format does not support schemas as CDC does.
{
  "op": "merge",
  "properties": {
    "foo": "value",
    "key": 1
  },
  "ids": {"key": 1, "otherKey":  "foo"},
  "labels": ["Foo","Bar"],
  "type": "node",
  "detach": true
}

What I'd like to achieve is specifiying property type (e.g. "birthDate": "2020-01-01" should be considered a neo4j date and not a string). Is this possible using CUD-formatted events?

Hi @andreagentili,
currently there's no way to define a specific data type of a property (e.g. date or geospatial coordinate). At the moment the data type is implicitly defined. I mean:

"key": "100" is a String
"key": 100 is an integer.

Hope this helps,
Mauro

Thank you for the answer!


How to "ZeroCopy" from source to destination ?

Hi there,
Great job with the lib.
Let's say I have A >> B >> C. Is it possible to allocate data on A and just release it on C ?
I don't seem to understand how to do it ..
Thanks..
PS: in a different post I provided a "poc.cpp" where I show (more or less) what I want to do ..

This one probably needs more documentation. So for primitive types (e.g., int) the memory for allocate is allocated directly on the outbound queue vs. creating on the local stack and copying to the output queue as in most frameworks. Depending on the size of the object, determined by the template (https://github.com/RaftLib/RaftLib/blob/dev/raftinc/alloc_traits.tcc) the allocation occurs in a few different ways. The simplest way to explain is if its a primitive type it is allocated directly on the output queue. If it's bigger than a cache line then it's allocated externally (right now using malloc). For large objects the pointer should be passed no matter what from a->b->c. There's a garbage collector that operates on these to ensure that a pushed object isn't deallocated if it's still in use.
The main reason the data is allocated directly on the output queue is that we can also vectorize operations on the primitive types when possible. I haven't yet implemented all the classes needed to do so....unfortunately the compiler can't figure out that the data coming off the port will be aligned, so these have to be hand coded either using intrinsics or asm direct.
So for the example you gave, if we have an object bigger than a cache line, it can be passed all the way through to C. If the object is smaller, it'll go from a->b, then b->c. There will be no actual allocations since the memory is dedicated to the FIFO. For all objects with constructors and all others, the in place constructor is called or the data is ready to use in-place. Does that help a bit? I'll try to update the docs, but feedback on the explanation would be useful.
Thanks!

Here's a complete example using the code you sent. I did find a but in the "allocate_s" function enable_if's. I'll fix that shortly. In the interim, the allocate functions is just fine. Compile with
clang++ `pkg-config --libs raftlib` -DZEROCPY=1 poc.cpp `pkg-config --cflags raftlib`

If you've manually installed the .pc file (assuming linux or mac) for zero copy or no "-DZEROCPY=1 " if you want to get the standard templates for inline allocation. All this is doing is changing the size and then that specifies the type of handling the FIFO does at compile time for the type.
/**
 *
 * Proof of concept Raftlib
 *
 * Want to have a 3 kernels stream which produces and sends 10 numbers down the stream.
 * The 10 numbers should be created by the first kernel and destroyed by the last.
 *
 */
#include <raft>
#include <raftio>

struct big_t
{
    int i;
    std::uintptr_t start;
#ifdef ZEROCPY
    char padding[ 100 ];
#else
    char padding[ 32 ];
#endif
};

/**
 * Producer: sends down the stream numbers from 1 to 10
 */
class A : public raft::kernel
{
private:
    int i   = 0;
    int cnt = 0;

public:
    A() : raft::kernel()
    {
        output.addPort< big_t >("out");
    }

    virtual raft::kstatus run()
    {
        i++;

        if ( i <= 10 )
        {
            auto &c( output["out"].allocate< big_t >() );
            c.i = i;
            c.start = reinterpret_cast< std::uintptr_t >( &(c.i) );
            output["out"].send();
        }

        if ( i > 20 )
        {
            return (raft::stop);
        }
        return (raft::proceed);
    };
};

/**
 * Processor: It simmulates a process with the input numbers
 */
class B : public raft::kernel
{
private:
    int cnt = 0;
public:
    B() : raft::kernel()
    {
        input.addPort<big_t>("in");
        output.addPort<big_t>("out");
    }

    virtual raft::kstatus run()
    {
        auto &a( input[ "in" ].peek< big_t >());
        input[ "in" ].recycle( 1 );
        output[ "out" ].push( a );
        return (raft::proceed);
    }
};

/**
 * Consumer: takes the number from input and dumps it to the console
 */
class C : public raft::kernel
{
private:
    int cnt = 0;
public:
    C() : raft::kernel()
    {
        input.addPort< big_t >("in");
    }

    virtual raft::kstatus run()
    {
        auto &a( input[ "in" ].peek< big_t >() );
        std::cout << a.i << " - " << std::hex << a.start << " - " << std::hex <<
            reinterpret_cast< std::uintptr_t >( &a.i ) << "\n";
        input[ "in" ].recycle(1);
        return (raft::proceed);
    }
};

int main()
{
    A a;
    B b;
    C c;

    raft::map m;

    // m += a >> b; // Core dump
    m += a >> b >> c;

    m.exe();

    return( EXIT_SUCCESS );
}

Output with zero copy looks like this (iteration - start addy - end addy):
1 - 7ff157e00460 - 7ff157e00460
2 - 7ff157e004e0 - 7ff157e004e0
3 - 7ff157e00560 - 7ff157e00560
4 - 7ff157e005e0 - 7ff157e005e0
5 - 7ff157e00660 - 7ff157e00660
6 - 7ff157e006e0 - 7ff157e006e0
7 - 7ff157e00760 - 7ff157e00760
8 - 7ff157e007e0 - 7ff157e007e0
9 - 7ff157e00860 - 7ff157e00860
a - 7ff157e008e0 - 7ff157e008e0

Fixed "allocate_s" for external allocate.
Added this definition to fifo.hpp
   template < class T,
              class ... Args,
              typename std::enable_if< ext_alloc< T >::value >::type* = nullptr >
   auto allocate_s( Args&&... params ) -> autorelease< T, allocatetype >
   {
      T **ptr( nullptr );
      /** call blocks till an element is available **/
      local_allocate( (void**) &ptr );
      *ptr = new T( std::forward< Args >( params )... );
      return( autorelease< T, allocatetype >(
         reinterpret_cast< T* >( *ptr ), (*this) ) );
   }

Will push tomorrow if it passes regression. Also adding a test case to the regression suite to make sure this doesn't get broken again. Thanks for the catch!

Just committed "9001d480305843ad51e4a1cb7ed9dee2a73978ff" to fix the bug I found while responding to this one. Also considering bulk zero copy for primitive types...will write up in wiki and send around for comment.

Thanks Jonathan for the explanation and for the example. I have updated the library and tested the examples. Everything is clear now..

Not quite....I'd love your opinion on if zero copy for primitive times
would be worth it, and an example. I can see in the example you gave if I
can determine bulk windows that will remain live that it could be made
efficient to pass elements through, I just haven't found a case where that
was general enough to code up.
On Mon, Jul 10, 2017 at 10:42 AM, mr-j0nes<EMAIL_ADDRESS>wrote:

Thanks Jonathan for the explanation and for the example. I have updated
the library and tested the examples. Everything is clear now..
—
You are receiving this because you modified the open/close state.
Reply to this email directly, view it on GitHub
https://github.com/RaftLib/RaftLib/issues/32#issuecomment-314146140, or mute
the thread
https://github.com/notifications/unsubscribe-auth/ABHm7rCoFOZkdLAS9865oqLpQXgvAPLJks5sMkZPgaJpZM4OGuwu
.


Move the tflint, shfmt, shellcheck, and markdownlint to super-linter

Move the tflint, shfmt, shellcheck, and markdownlint to super-linter (that issue could possibly include--or be dependent on--adding tfsec support to super-linter).

We could also look into using the bespoke actions for most of these. Markdownlint is especially frustrating right now as vscode wants to use the javascript based markdownlint config format while our pre-commit github action uses the ruby based markdownlint config format, meaning your vscode will complain about issues we've disabled in the github side's config.


⚠ Bofrost.lu has degraded performance

In 4c70f36, Bofrost.lu (https://www.bofrost.lu) experienced degraded performance:

HTTP code: 200
Response time: 978 ms

Resolved: Bofrost.lu performance has improved in f73b074 after 6 minutes.


Fix 1.66 clippy lints

One more left unfixed:
    Checking tokio-tar v0.3.0 (/Users/someonetoignore/work/other/tokio-tar)
error: calls to `std::mem::drop` with a reference instead of an owned value. Dropping a reference does nothing
   --> src/archive.rs:429:5
    |
429 |     drop(header);
    |     ^^^^^^^^^^^^
    |
note: argument has type `&mut header::Header`
   --> src/archive.rs:429:10
    |
429 |     drop(header);
    |          ^^^^^^
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#drop_ref
    = note: `#[deny(clippy::drop_ref)]` on by default

Superseded by https://github.com/vorot93/tokio-tar/pull/21


Entitlements in :Base Image

In the past, a w1 image did not contain any data. instead there was the base image which contained some data for testing. I have gotten into the habit of always using the base image when I want to develop something for several countries or appsource.
But now I found out that there are no entitlements in the base image.
Tested with mcr.microsoft.com/businesscentral/sandbox:base-ltsc2019
Is this on purpose and there a special reason?

the base image is really onprem w1 image - and the local images are then replacements of the databases (which is why we have a w1 vs. base).
It has always been like this and it isn't anything I can change.

I think it's a pity that there is no image that doesn't include country customizations, but still behaves like SaaS. So we always need the symbols of w1 or base when we are developing and for testing we have to use a localized image.
Thanks for the clarification.

Yeah, I tried for pushing to have demo data in the w1 image - but that has been declined.
Only option really is w1 + a rapidstart package


i think it will be nice if we had a separate connections to the database...

i think it will be nice if we had a separate connections to the database based on the environment type so that changing the environment will connect to the correspond database server ..

The fact that this is such a tiny change means that it is really easy for anyone to do, but is not assumed by default.
Documenting this would be nice however.
I'll close this as it's been voted against before. Sorry!

no problem .. thanks phil ..


Add calendar widget

A calendar widget that with some display options and styling for individual dates.
This widget displays the month provided to it in the constructor. (see docs and the example for more info).
One thing to note: This pulls in a new dependency, the time crate. Since this adds a dependency, it might be worth putting the widget behind a feature flag - I'm happy to do so if that's desired.

Should we put calendar and other similar new-dependency-introducing widgets behind feature flags? @orhun @mindoodoo

Hmm, what would you name the feature ?

widget-calendar?

I put in the machinery for the feature and named it widget-calendar. It's easy to change if something else is decided.

I didn't understand why you went with dep:time instead of time, why that is required?

why is that required?

Apparently it isn't :). I'm still learning about some of these Cargo directives and I think I misunderstood some of what I read.
Pushed a fixup

Just tested and it works well. GJ! 🎉
One question though, is it possible to add tests for this?

I can add tests (i think). I'll see what I can get in place over the weekend.

I've added some tests for the widget, as well as for the date styler.
One thing to note, I'm not sure if CI will actually run the tests, because I don't know if it builds with default features or does something "smart". I added a feature all-widgets in my latest commit, which currently just specs widget-calendar, but as we add other widgets behind feature flags, I presume it will get more entries. It also allows for a simpler testing with cargo test --features all-widgets

I think you can update Makefile.toml like this for running tests for all-widgets feature:
diff --git a/Makefile.toml b/Makefile.toml
index 8afba0a..db9354f 100644
--- a/Makefile.toml
+++ b/Makefile.toml
@@ -100,11 +100,11 @@ args = [
 ]

 [tasks.test-crossterm]
-env = { TUI_FEATURES = "serde,crossterm" }
+env = { TUI_FEATURES = "serde,crossterm,all-widgets" }
 run_task = "test"

 [tasks.test-termion]
-env = { TUI_FEATURES = "serde,termion" }
+env = { TUI_FEATURES = "serde,termion,all-widgets" }
 run_task = "test"

 [tasks.test]

Thanks @orhun - that looks like it did the trick, I can calendar tests being run now.


why golang expects import "modernc.org/sqlite"?

➜  sqlite go run main.go
main.go:9:2: code in directory /Users/zhangyuan/go/src/github.com/glebarez/go-sqlite expects import "modernc.org/sqlite"
➜  sqlite go version
go version go1.21.5 darwin/arm64

similar situation here, when I was cross compile the code:
        imports github.com/glebarez/sqlite
        imports github.com/glebarez/go-sqlite
        imports modernc.org/libc
        imports modernc.org/libc/unistd: build constraints exclude all Go files in<EMAIL_ADDRESS>


L7 Envoy service mesh - Cannot reach the service with multiple ports

Is there an existing issue for this?

[X] I have searched the existing issues

What happened?

Having a deployment echo-server serving echo on both REST and gRPC: REST port is 3000 and gRPC is port is 4000

Create a service with annotation: service.cilium.io/lb-l7: enabled
apiVersion: v1
kind: Service
metadata:
  labels:
    name: echo-server
  annotations:
    service.cilium.io/lb-l7: enabled
  name: echo-server
  namespace: default
spec:
  ports:
    - name: grpc
      port: 4000
      protocol: TCP
      targetPort: 4000
    - name: http
      port: 3000
      protocol: TCP
      targetPort: 3000
  selector:
    name: echo-server

Only the gRPC request can reach the service. The REST request return with error code 502.
Cilium Version
1.15.3
Kernel Version
5.10.198-187.748.amzn2.x86_64
Kubernetes Version
EKS v1.29
Regression
No response
Sysdump
No response
Relevant log output
No response
Anything else?
No response
Cilium Users Document

[X] Are you a user of Cilium? Please add yourself to the Users doc

Code of Conduct

[X] I agree to follow this project's Code of Conduct

hi @lmb,
I revert the order of the ports and received the same result

+1

@lmb, please remove the stale

remove the stale

I have the same issue with version 1.16.1
@lmb please remove the stale

.


Issue 48551: remove explicit declaration of properties for exp data/materials

Rationale
This PR addresses Issue 48551 by removing explicit declaration of the properties passed to ExperimentJSONConverter.serializeExpObject() and passes null instead. The reason for this is that ExperimentJSONConverter.serializeOntologyProperties() processes the value any explicitly provided properties against the experiment object/property store and subsequently ignores values from the provisioned tables since those properties have already been "seen". This regression was introduced with #4430 where I had made the change to hand in explicit props unknowingly changing how the values for these properties would be sourced.
Changes

Update serialization of experiment data and materials to pass null properties rather than fetching properties from the data type's domain.
Regression coverage added in LineageTest
Updated JavaDoc comment to a buyer beware.

serializeRunGroup and serializeRun are also passing in explicit domainproperties, do they need to be updated as well?

Thanks. I purposely left those as they were before my most recent changes.

Can you add some JavaDoc comments to help capture the current behavior for serializeOntologyProperties(), which isn't at all intuitive

Added with 47e522b.


investigating cause of ReactViewManager returning null

Summary: Throws and captures the overloading class as well as the component name to help us track.
Reviewed By: cortinico
Differential Revision: D45185598

Merged in 14b2b1ce50fc59ffbfbe35dee417c28bded94d69


SVGTransform doens't working on v2.1.2

I'm using this import statement
import KUTE from "kute.js"
when I run this code
KUTE.allTo(
      "rect, circle",
      { svgTransform: { rotate: 360 } },
      { repeat: 1, yoyo: true }
    ).start();

over this SVG
<svg id="morph-example" xmlns="http://www.w3.org/2000/svg">
    <rect x="100" y="100" width="100" height="100" fill="blue" />
    <circle r="50" cx="400" cy="150" fill="red" />
  </svg>

Literally, nothing is happening, whats happening?
"kute.js": "^2.1.2",
Codepen
https://codepen.io/joao_nogueira/pen/BaRxqjN

The KUTE.js works fine on version 2.0.2, but 2.1.2 dont

SVGTransform is not included in the default distribution file anymore. You can use the kute-extra.js file for that.

@thednp Thanks for reply


Code Review for adding dynamically loaded DLL support

This is tested and works (on my machine, Windows 64-bit, not profiling GPU), but nonetheless this pull request is primarily so you can provide feedback on the design. I tried to make my changes as non-disruptive (to the design and performance) and rewindable as possible. The result is macro-heavy and somewhat messy.
I think it wouldn't be too harmful to turn the static variables into globals, and have their declarations be consolidated right at the same place as the MicroProfileGlobalState struct.
Renaming static depending on its context was just for me to find the globals more quickly, so that change can be blasted if you like.
The usage code could be simplified if I made it so that everything that is global is TLS. Or got rid of the TLS and used a hashtable to find logs. Again, I wanted to be non-disruptive.
Sorry about the # of commits.
Let me know what you think.

This seems to add support for statically linking microprofile into dlls and not break everything when doing that, or do I get this wrong?
I wanted to use microprofile too and here is what I did:
I just compiled microprofile as a dll, by just defining the MICROPROFILE_API on windows with either __declspec(dllexport) or __declspec(dllimport), and then linking the resulting .lib to all the dlls that use microprofile, that is a really easy way to get it to work with multiple dlls. I got this to work with like 10 lines of code. This is the patch I have for that, https://gist.github.com/xforce/2dc98e9b23bcf0e3da2971338f045d47

@xforce What you suggest is actually what MICROPROFILE_API is inteded for. However - instead of adding it directly in microprofile, you should make your own microprofile.config.h, and add it there.

@jonasmr ye true, I should probably change that.

closing, old


[docs] critical API documentation is missing

It looks like things kind of work, except not quite right, and there are a lot of subtle nuances that are so hard to know about when integrating DeepSpeed. I think all these should be made loud and clear - and perhaps a simple full example of a training loop would help, including showing commented out code where the original training code is removed to do it the DeepSpeed-way.
As I am trying to figure out how to make gradient_accumulation_steps work correctly I'm finding all kinds of things I have missed when integrating DeepSpeed into HF Trainer. I will post them here as I find such things:

engine's backward returns loss, which it modifies under gradient_accumulation_steps > 1 but this is undocumented.

neither in the API docstring https://github.com/microsoft/DeepSpeed/blob/e60e92eb0a06673748c4cb63fbcf713ddd12fc22/deepspeed/runtime/engine.py#L852-L858
nor main docs: https://www.deepspeed.ai/getting-started/#training

Also it's not documented that the "client" shouldn't scale loss by gradient_accumulation_steps since Deepspeed does it in backward.

the fact that lr_scheduler.step happens inside engine's step is not documented in the API

https://github.com/microsoft/DeepSpeed/blob/e60e92eb0a06673748c4cb63fbcf713ddd12fc22/deepspeed/runtime/engine.py#L993-L996
but is documented in https://www.deepspeed.ai/getting-started/#training
it might be a good idea to also add an explicit - make sure to remove lr_scheduler.step() from your code if using DeepSpeed's scheduler.

the "client" must not skip engine.step() when gradient_accumulation_steps > 1, and since this is an integration of many methods this leads to a complicated brittle code:

                if self.deepspeed:
                    self.deepspeed.step()

                if (step + 1) % self.args.gradient_accumulation_steps == 0 or (
                    # last step in epoch but step is always smaller than gradient_accumulation_steps
                    steps_in_epoch <= self.args.gradient_accumulation_steps
                    and (step + 1) == steps_in_epoch
                ):
                    # Gradient clipping
                    if self.args.max_grad_norm is not None and self.args.max_grad_norm > 0 and not self.deepspeed:
                        # deepspeed does its own clipping
                        if self.use_amp:
                            # AMP: gradients need unscaling
                            self.scaler.unscale_(self.optimizer)
                        [...]
                        else:
                            # Revert to normal clipping otherwise, handling Apex or full precision
                            torch.nn.utils.clip_grad_norm_(
                                amp.master_params(self.optimizer) if self.use_apex else model.parameters(),
                                self.args.max_grad_norm,
                            )

                    # Optimizer step
                    if self.deepspeed:
                        pass # called outside the loop
                    [...]
                    else:
                        self.optimizer.step()

                    if not self.deepspeed:
                        self.lr_scheduler.step()

                    model.zero_grad()
                    [...]

After fixing the above 4 I managed to get the same weights and loss with bs=8/grad_accum=1 and bs=4/grad_accum=2. Yay!

Adding to this:
5. Remove model = model.cuda() and model = model.half() calls.
6. Do keep data = data.cuda() and optionally add data = data.half() calls.
7. Substitute torch.nn.utils.clip_grad_norm_(params, X) with "gradient_clipping": X in the DeepSpeed config.
8. Guard parallel I/O using parallel primitives (except DeepSpeed checkpointing which is already nicely documented in the code and at deepspeed.ai).
9. Use torch.distributed methods for parallel primitives (e.g. torch.distributed.get_world_size(), torch.distributed.get_rank(), int(os.environ['LOCAL_RANK']), ...).
And a bit less interesting (though one of these should probably be adjusted instead of documented):
10. In deepspeed.initialize, the optimizer kwarg has precedence over the "optimizer" key in the DeepSpeed config.
11. In deepspeed.initialize, the "scheduler" key in the DeepSpeed config has precedence over the lr_scheduler kwarg.

Thank you for the additions, @janEbert!

Do keep data = data.cuda() and optionally add data = data.half() calls.

And since fp32 is being worked on https://github.com/microsoft/DeepSpeed/pull/1004, this could be dynamic.
inputs = inputs.to(dtype=next(iter(model.parameters())).dtype)

so it can automatically handle the case of model.half() (fp16) or not (fp32) down the road.

Oh nice, that input conversion is even better! Happy to hear FP32 ZeRO 3 is getting PRed as well. :)

Actually I just noticed, so long as the device is set correctly (that is, with torch.cuda.set_device(local_rank)), model = model.cuda() can be left in and model = model.half() can be left in either way.
See device setup and model conversion code.

Based on my understanding this is all taken care of internally by DeepSpeed, so you want to skip both of those calls if your training loop is running under Deepspeed - this is what we do in HF Trainer.
model = model.cuda() will OOM anyway if your model is larger than gpu0.

Yea I guess it's better to just give your concrete advice; who knows how the internals will change with the speed this is moving at. :)


Add more database constraints to prevent erroneous data scenarios

Add several CHECK statements to verify int and text fields are cannot be
negative or empty.
Add many NOT NULL constraints on fields that are not supposed to be
nullable.

If anyone spots more of these possible issues, please comment on them here so they can be addressed. These sort of issues have already caused bugged (see issue #96 ).


Make use of Hacktoberfest!

DigitalOcean and GitHub is running Hacktoberfest, a contest where participants can win a t-shirt and other goodies by contributing to open source projects.
This might be a good chance to get help with some low hanging fruit, documentation or what not. You just need to tag issues with "Hacktoberfest" to make them findable. Don't know how many issues would be a good fit, but thought I'd let you know :)

Did not know about this!  I'll give it a go!


Add first model from silero stt models

Hi,
My name is Alexander, I am with Silero, we are a small independent self-financed company making speech related products.
Please kindly review our Speech-To-Text models.
I believe if this PR is ok, in future we will follow with other languages and tf-js versions as well.

@googlebot I signed it!


gdal_trace_outline ignores alpha layer

I branched the code and modified ndv.cc to handle alpha layers. Mind taking a look? I'm not sure my approach was right, though it does work for me in my situation.
Also in my branch: some changes to use C++11 to avoid Boost references, changes to make the major ring and holes parameters work simultaneously, and an attempt to make erosion parameterizable.
Link: https://github.com/BrannonKing/dans-gdal-scripts/commits/master

Brannon,
Thanks for the patch.  I haven't touched this project in years, so it is
nice to at the very least have some of it updated to C++11. I think the
patches need some work though before being merged.
Do the added VC files serve some purpose that will be of use to others?
If so, are you willing to be a contact for people who are trying to
build on Windows?  I know nothing about Windows development, and so
can't support this myself and can't judge whether these files really
should be included.
In common.h, the #include "config.h" has to be up top.  In particular,
it can't be inside of " #if HAVE_INTTYPES_H" since that symbol comes
from config.h.
Bring back boost::lexical_cast.  It has better error handling than stoi
and its ilk in cases of improperly formatted strings.
Outputting donuts by default when -major-ring is specified is definitely
a change in behavior.  Probably it's the right thing to do, because the
user can also specify the -no-donuts option if they want.  But you need
to remove this check:
if(major_ring_only && output_no_donuts) fatal_error(
"-major-ring and -no-donuts options cannot both be used at the
same time");
Please also test that it does the right thing with and without
-no-donuts in the case where -major-ring is specified.  You can use the
images under src/tests to test this.
In take_largest_ring, it needs to be " if(mp_in.rings[i].is_hole &&
mp_in.rings[i].parent_id == best_idx)".  And the "if(i==best_idx)
continue" is not needed.
For consistency, remove spaces before parentheses in "if (" and "for (".
Bring back "include " in ndv.h and polygon-rasterizer.cc.  These
use std::string.
Bring back boost::format in raster_features.cc.  I think it's clearer
than the hexmap[] stuff.  The ones that have at most one std::to_string
per line are probably more clear with std::to_string though.
I don't understand the alpha band logic.  Why is it multiplied by 0.25?
Shouldn't only full transparency be considered non-data? If the user
wants a more fuzzy match, they can specify this with the -ndv option.
Is it good to add an NdvSlab when GDALGetRasterNoDataValue fails for
some of the bands?  I don't have much opinion either way on this, but it
should be consistent.  As it stands with your current patch, if this
call fails for one band then there will be an NdvSlab added only if one
of the other channels is alpha.  Either it should always add NdvSlab if
at least one band has GDALGetRasterNoDataValue, or it should not
(regardless of whether another band is alpha).
Also, I'm not so sure the logic is sound here.  If the file lists
[-1,-1,-1] as being NDV (for example), wouldn't you want two NdvSlabs?
One for the listed NDV value and another for transparent pixels.  As it
is now, it'd only be NDV if the pixels were equal to [-1,-1,-1] and also
transparent.
Instead of the modified line " if(!got_error || alpha_idx >= 0)", it
would be better to not set got_error in cases where the slab should be
added.
Thanks,
Dan
On 01/23/2017 04:11 PM, Brannon King wrote:

I branched the code and modified ndv.cc to handle alpha layers. Mind
taking a look? I'm not sure my approach was right, though it does work
for me in my situation.
Also in my branch: some changes to use C++11 to avoid Boost
references, changes to make the major ring and holes parameters work
simultaneously, and an attempt to make erosion parameterizable.
Link: https://github.com/BrannonKing/dans-gdal-scripts/commits/master
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/gina-alaska/dans-gdal-scripts/issues/11, or mute
the thread
https://github.com/notifications/unsubscribe-auth/AATHcOs2-Lw43WrYQxayTTDMF-KWSwskks5rVUGWgaJpZM4LrtXH.

Thanks for the thorough review. I'm aware more work would need to be done for a full merge.
The Visual Studio files are an okay example of how to do it. I was using those in conjunction with prebuilt binaries from http://www.gisinternals.com/ . A lot of modern projects have switched from autoconf to CMake because CMake will generate Visual Studio build files on demand. Using CMake would allow us to leave the Visual Studio project files out of the repository.
I wasn't sure what to do on the config.h reference. I suppose I could have done something like wrap it in #ifndef _WINDOWS...
I had intended to use std::stoi, not the old stdlib version. The newer conversion methods do throw errors on malformatted input. I was concerned about getting the right version of Boost to match whatever GISinternals used on their build, which wasn't obvious. It seemed easier to just ditch it. It might be nice, though, to utilize newer build chain features for referencing individual Boost features straight from Github -- some kind of auto external dependency.
On the alpha, I did wonder if any alpha meant "keep it". I also wondered if 50% was a good cutoff. A zero alpha threshold would probably work fine in all me test data.
Concerning simultaneous NDV entries, I had expected that your code would OR them. You're saying it's an AND, so my logic there is definitely not quite right.

On 01/24/2017 06:48 AM, Brannon King wrote:

Thanks for the thorough review. I'm aware more work would need to be
done for a full merge.
The Visual Studio files are an okay example of how to do it. I was
using those in conjunction with prebuilt binaries from
http://www.gisinternals.com/ . A lot of modern projects have switched
from autoconf to CMake because CMake will generate Visual Studio build
files on demand. Using CMake would allow us to leave the Visual Studio
project files out of the repository.

Feel free to write up some CMake scripts if you'd like.  I'm not
particularly tied to autoconf.  As long as it still compiles on Linux,
it's fine.

I wasn't sure what to do on the config.h reference. I suppose I could
have done something like wrap it in |#ifndef _WINDOWS...|

config.h comes from autoconf.  You can look at config.h.in to see the
sorts of things it defines.  If all references to these are removed from
the code, then config.h will not be needed.  A lot of it just detects
the existence of headers which pretty much exist on all systems nowadays.

I had intended to use |std::stoi|, not the old stdlib version. The
newer conversion methods do throw errors on malformatted input. I was
concerned about getting the right version of Boost to match whatever
GISinternals used on their build, which wasn't obvious. It seemed
easier to just ditch it. It might be nice, though, to utilize newer
build chain features for referencing individual Boost features
straight from Github -- some kind of auto external dependency.

std::stoi also has pretty crummy error detection, unless you pass the
pos parameter, and manually check its result.  For instance
std::stoi("1O1") will return 1 rather than throwing an error.  Since
we're only using boost headers, and not the compiled libraries, it is
probably okay to mix versions.

On the alpha, I did wonder if any alpha meant "keep it". I also
wondered if 50% was a good cutoff. A zero alpha threshold would
probably work fine in all me test data.
Concerning simultaneous NDV entries, I had expected that your code
would OR them. You're saying it's an AND, so my logic there is
definitely not quite right.

Yes, if my memory serves, it operates like an AND between the bands.
Imagine it as a box in color space.  You can review the code to be sure
though.  It's been several years since I've looked at it.
And I'd say by default semi-transparent pixels should be considered
valid data.  It seems that would be in line with the principle of least
surprise.  This can always be configured on the command line with the
-ndv option.

—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/gina-alaska/dans-gdal-scripts/issues/11#issuecomment-274824070,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AATHcHyYeG59H3qyFFIqT1Z9OE83t5rYks5rVg9YgaJpZM4LrtXH.

Adding an update that I no longer use the MS Build files in my branch.


Include CDI manifests too

https://github.com/kubevirt/containerized-data-importer

Will look into this on the next repo refactor, target to work on it is next week earliest.

3 weeks has passed, ping @JJGadgets ;)


[BUG] v2.1.4 Cannot override variables - NPM

Describe the bug
Cannot override variables
To Reproduce
I triedn enabling the Override Config, yet nothing worked

Go to 'Settings on a chatflow'
Enable 'Global override and specific for each nodde parameters'
I tried with postman to upsert a vector with a different text in the textarea:

{
"stopNodeId": "redis_2",
"overrideConfig": {
"text": {
"plainText_2": "Jane Smith is a project manager with expertise in agile methodologies and over 8 years of experience..."
}
}
}
Yet only the default character in the node ( # ) was upserted
Expected behavior
See this in the redis store:
Jane Smith is a project manager with expertise in agile methodologies and over 8 years of experience
Screenshots

Setup

npx flowise start
Flowise Version [2.1.4]
OS: [Linux - Debian]
Browser [I am using curl mostly for now since i need to debug, but i made the flow in chrome]

Additional context
I updated [npm install flowise@latest] since i've seen that this has been merged to main branch but it sill doesnt work

Temporary fix for my issue:
npm install<EMAIL_ADDRESS>

Fix is merged to main, will be pushing to new release soon


Encoding problem when visiting 404 page

Encoding is fine when accessing the 404 page directly from /404.
When actually typing in a random url, 404 page doesn't display correctly (non-English parts).

Hi,
Can you please explain what you mean by doesn't display correctly (non-English parts).? Can you provide a screenshot?

Apparently it's alright on github. When I tried it on cloud9, this was what it looked like.

@ouvek-kostiva Does the remaining pages render properly on cloud9?

No response, closing.


support keys limit size and allow keys

Avoid "hash algorithm collision" http://www.ocert.org/advisories/ocert-2011-003.html

@visionmedia
Out security member has just implement the "hash algorithm collision" in V8.
And test success in our nodejs web application using Express.
I will send the test codes to your email later, you can check it out.

@visionmedia
Out security member has just implement the "hash algorithm collision" in V8.
And test success in our nodejs web application using Express.
I will send the test codes to your email later, you can check it out.

im not saying it cant be done, there are many other attacks as well, im just saying they never even found it performed in practice

im not saying it cant be done, there are many other attacks as well, im just saying they never even found it performed in practice


Ry/profiles list

Changes implemented:

We can now get avatars from public in the backend by using the endpoint/src: /api/avatars/${avatarImgName}
We now have a List of users in profiles, that we can, block/unblock, friend/unfriend, it routes to chat and singleProfileView with the id of the user clicked, passed as a param.
If a user is blocked, other options are now greyed out, if other implementation is needed we can open a ticket for that.

Possible things that still need to be thought about:

Saving the current relationship somehow, I played around with it a bit, but it is deceptively complicated (ticket).
Find a better way to collect blocked user, or friends or to check if someone isBlocked or a friend.

closes #98

Okey incoming updates:

Removed 666 api calls for relationship. now getting the relationshipType once or each user.
Tried removing the index.html with specific settings which should allow that, buuuuuuut no luck on that yet, so re-added it with no body.
Removed unused styles in listRow


Gallery example doesnt work

I have installed extended_image version 0.9.0, tried to add this code:
ExtendedImageGesturePageView.builder(
  itemBuilder: (BuildContext context, int index) {
    var item = widget.pics[index].picUrl;
    Widget image = ExtendedImage.network(
      item,
      fit: BoxFit.contain,
      mode: ExtendedImageMode.gesture,
      gestureConfig: GestureConfig(
        inPageView: true, initialScale: 1.0,
        //you can cache gesture state even though page view page change.
        //remember call clearGestureDetailsCache() method at the right time.(for example,this page dispose)
        cacheGesture: false
      ),
    );
    image = Container(
      child: image,
      padding: EdgeInsets.all(5.0),
    );
    if (index == currentIndex) {
      return Hero(
        tag: item + index.toString(),
        child: image,
      );
    } else {
      return image;
    }
  },
  itemCount: widget.pics.length,
  onPageChanged: (int index) {
    currentIndex = index;
    rebuild.add(index);
  },
  controller: PageController(
    initialPage: currentIndex,
  ),
  scrollDirection: Axis.horizontal,
),

But got an error:

Undefined name 'rebuild'.

How can I fix it?

rebuild is a stream, you can find it in demo

rebuild is a stream, you can find it in demo

Sorry. How can I find the demo? There is no "rebuild" on the example page http://smlll.com/packages/extended_image/example


Replace all the print statements with a logger

Instead of printing stuff everywhere we should have a logger that outputs it based on a desired verbosity
I also die every time I see the tensorflow device reg

hi @dan-garvey , no need to die everytime you see tensorflow device reg. Could you let me know how I can take care of this issue for you? I would love to contribute here.

Thanks for your interest. There is a python library called logging: https://docs.python.org/3/library/logging.html
It would be great if you could find all instances of print in the shark codebase and replace them with an appropriate level
of logging call.
If you want to get fancy you could make a custom shark logger class but any switch is a good one at this point. Happy to answer any questions, and feel free to elect me as a reviewer
I think the tensorflow device init issue has already been addressed iirc. (At least, I haven't died recently)

Thanks for the detailed answer @dan-garvey, I will probably work on this later this weekend.

@dan-garvey Hi, I tried running the main branch locally, but it is struck at :
Obtaining file://.../SHARK
  Installing build dependencies ... |

It should take anywhere up to 20min for the setup, does it hang longer than that?

Hi @monorimet, yeah sadly, it is still like that. I don't know, probably my device or something else. Here's what the logs from my terminal looks like now.

@dan-garvey @monorimet, Any idea guys?

sorry didnt see this, thanks for the ping. Does your htop/top show the process consuming and cpu resource?

Yup finally it worked, I am playing around with the Web UI for now. Just getting the hang of it. Thanks!


Support different Kafka client versions

fixes: https://github.com/creek-service/creek-kafka/issues/27
Reviewer checklist

[ ] Ensure relevant issues are linked (description should include text like "Fixes #")
[ ] Ensure any appropriate documentation has been added or amended

Coverage decreased (-0.2%) to 99.295% when pulling a37af90e2d6b22d841bf456ccd158c18b267eda4 on kafka_versions into 18e51d08ff9c6dc55a6777ef77681b1685ae97eb on main.


In MobileServiceHttpClient class, remove the AssemblyFileVersion from the building of user agent string

In Xamarin.iOS, (where I believe this library is very commonly used) the linker strips away some AssemblyInfo attributes, including AssemblyFileVersionInfo. The value from this attribute is used in the bowels of the MobileServiceHttpClient, where it's used to buildup the user agent string; I presume so that MSFT can measure what versions of their client SDK are hitting their endpoints.
The problem is that when linking is enabled in a Xamarin.iOS solution (and presumably in other linkers as well), the AssemblyFileVersionInfo attribute is stripped off. So the result of the LINQ statement on line 695 is null. And then on the very next line, the method attempts to access the Version  property on the null fileVersionAttribute local variable.
I understand the reason for trying to grab the value: to track client SDK versions. But basing it on an attribute that gets stripped off with linking probably isn't a very good way to achieve it. Just my two cents! Thanks!

@jsauvexamarin thank you for reporting this! We're working on a fix and some enhancements to prevent linker related issues from happening in the future.

@fabiocav will we only do the fix on the Apps side?  Or do you plan on doing it as well for services?

@phvannor we'll be doing this for Mobile Services as well.


Concurrent  security

Q
A

Is bugfix?
❌

New feature?
✔

Breaks BC?
❌

Fixed issues
#41

@jiaweipan seems the pull request breaks tests.

has already fixed it.@samdark

@samdark @vjik @terabytesoftw @arogachev  Please help me review the code and give some suggestions.

thank you, I have updated according to your suggestion.@samdark

Seems it fails tests now :(

thanks, I have updated. @vjik

thanks, I have updated according to your suggestions. @vjik

@jiaweipan what you think about this suggestions: https://github.com/yiisoft/rate-limiter/compare/fffb221...d8b2a89 ?

These codes are even more beautiful because of your suggestions, thanks.@vjik

@vjik Thanks! I have merged your suggestion.

@jiaweipan thank you very much for working on it!

@samdark @vjik @xepozz thanks for your suggestions, I enjoy working with you.


Changing the type to string changes the column value

Describe the bug
Depending on the column value, changing the type to string changes the column value.
To Reproduce
Changed column with very small value to string type
Expected behavior
A clear and concise description of what you expected to happen.
Screenshots

Desktop (please complete the following information):

OS: [e.g. iOS]
Browser [e.g. chrome, safari]
Version [e.g. 22]

Additional context
Add any other context about the problem here.

@jeongeunkwon We have a similar (but a little different) issue on this behavior. (https://github.com/metatron-app/metatron-discovery/issues/1365)
Both are related to number formatting, but this issue shows another case.
I'm going to resolve this before 3.3.0 release.


Test compute quarantine tests inter-dependencies

What this PR does / why we need it:
I merged a bunch of stability improvements for test_id:5004.
In every PR the presubmit lanes (which I always ran for at least 5 times in a row) passed in a near to 100% pass rate. In periodic lanes though the test passed for about 30-40% of the times.
After talking to @fgimenez about this issue, he suggested that the different results may occur from the fact that periodics run all quarantines tests, therefore it could be that one of the tests causes the whole lane for instability. If this is the case, finding this problematic test will have much value, as now it is pretty much impossible to further debug the test and know where the problem is coming from (the test? other test? some inter-dependency between them?).
P.S. We can also discuss if there's a better way to isolate tests from one another so this won't happen in the future, as it causes a waste of time and prevents from performing a meaningful debug.
Release note:

NONE

/hold

/cc @fgimenez

/test pull-kubevirt-e2e-k8s-1.20-sig-storage
Not what I was looking for.

Another try
/test pull-kubevirt-e2e-k8s-1.20-sig-storage
/test pull-kubevirt-e2e-k8s-1.19-sig-compute pull-kubevirt-e2e-k8s-1.20-sig-compute pull-kubevirt-e2e-k8s-1.21-sig-compute

Failed as expected :)
Trying again:
/test pull-kubevirt-e2e-k8s-1.20-sig-storage
/test pull-kubevirt-e2e-k8s-1.19-sig-compute pull-kubevirt-e2e-k8s-1.20-sig-compute pull-kubevirt-e2e-k8s-1.21-sig-compute
If we see more failures than I'll start quarantining tests one by one until we find the problematic one.

Passed this time. Seems it's flakie. Periodics failed for about 50% of the times.
I'm running for a few more times so we're sure this is really the case here.
/test pull-kubevirt-e2e-k8s-1.20-sig-storage
/test pull-kubevirt-e2e-k8s-1.19-sig-compute pull-kubevirt-e2e-k8s-1.20-sig-compute pull-kubevirt-e2e-k8s-1.21-sig-compute

Passed this time. Seems it's flakie. Periodics failed for about 50% of the times.
I'm running for a few more times so we're sure this is really the case here.

Trying again
/test pull-kubevirt-e2e-k8s-1.20-sig-storage
/test pull-kubevirt-e2e-k8s-1.19-sig-compute pull-kubevirt-e2e-k8s-1.20-sig-compute pull-kubevirt-e2e-k8s-1.21-sig-compute

Passed this time. Seems it's flakie. Periodics failed for about 50% of the times.
I'm running for a few more times so we're sure this is really the case here.

Trying again

/test pull-kubevirt-e2e-k8s-1.19-sig-compute pull-kubevirt-e2e-k8s-1.20-sig-compute pull-kubevirt-e2e-k8s-1.21-sig-compute

Results here aren't good enough.
Trying this instead: https://github.com/kubevirt/kubevirt/pull/6324

This work is postponed until this PR merged: https://github.com/kubevirt/kubevirt/pull/6323

This https://github.com/kubevirt/kubevirt/pull/6323 is now merged. Let's see if it helps.
/test pull-kubevirt-e2e-k8s-1.19-sig-compute pull-kubevirt-e2e-k8s-1.20-sig-compute pull-kubevirt-e2e-k8s-1.21-sig-compute

Issue seems to be fixed here: https://github.com/kubevirt/kubevirt/pull/6641.
/close


SHA1 is deprecated

# Brewfile
tap 'kevinsjoberg/formulas'
brew 'kevinsjoberg/formulas/m'

❯ brew bundle dump
Warning: Calling Formula.sha1 is deprecated!
Use Formula.sha256 instead.
/usr/local/Homebrew/Library/Taps/kevinsjoberg/homebrew-formulas/m.rb:6:in `<class:M>'
Please report this to the kevinsjoberg/formulas tap!

Homebrew 1.0.8
OSX 10.11.2
Seems to work just fine™ on my machine, but them warnings!

Thanks @kasperlewau. I'll take a look at this weekend. Feel free to give it a shot yourself. 👍


Startup issue and probably wrong interface

Hello,
with your built image i get
--------------------------------------------------
o")~   Snort++ <IP_ADDRESS>
--------------------------------------------------
--------------------------------------------------
pcap DAQ configured to passive.

Snort successfully validated the configuration (with 0 warnings).
o")~   Snort exiting

i saw that you are using eth0 but in my case the laptop has not such interface.
So i /bin/bash'ed in and tried
/snort/bin/snort -T -i wlp3s0
but got the same error

The way around for me was at least to add
user: root
network_mode: host

when using your built image

Hello, thanks for your feedback.
Great idea to add the network interface in the docker-compose.yml, thanks. It's done.
For the startup issue is normal. The -T argument is for testing, that's why you got this output.
I need to add classic feature, like https://github.com/snort3/snort3?tab=readme-ov-file#run-snort


feat: Implement Withdrawal event

Resolves #237

@Mystic-Nayy Please, sync with master

@Mystic-Nayy Please, fix merge conflict
And please, don't run black for all files, only for files which was changed by you


Broken removeEventListener

https://github.com/zzarcon/default-passive-events/blob/f34ad7222aaa4be088de79b59f81d1b997ad00dc/src/index.js#L42
import 'default-passive-events'
const listener = ()=> console.log('This listener is removed and should not be called')
window.addEventListener('mousemove', listener)
window.removeEventListener('mousemove', listener)

Connected with #19 and already started progress on this in #23


[BUG] Improve the click accuracy

There is an issue with the click.When I click on the lower part of the thumbnail it takes me to channel information. As a user I would prefer it should redirect to the video and only when I am specifically clicking the channel name it should take to channel info page.
Let me know do you want to fix this
Please assign me this issue under GSSOC'23

thanks for your feedback.
you can start working on this bug.


I want to use Parler tts for as the base model, is it possible?

OpenVoice is amazing and I like it a lot. However, I wanted to experiment with different TTS models like Parler tts from huggingface as the base model instead of the melotts.
How to achieve that?
thanks

Does this help in better voice cloning?

@meet1919 I am not sure. I wanted to experiment with it.


Spyder very slow when working on large python files

Description
What steps will reproduce the problem?

A few things in spyder are slowing down spyder considerably, mostly whrn working with big files. The functions that take most of the time are:

the paintEvent from spyder/plugins/editor/panels/scrollflag.py

Mostly computing the flags and adding all the painters

__mark_occurences in spyder/plugins/editor/widgets/codeeditor.py

Versions

Spyder version: 5.0.0.dev0 acb3dbff4
Python version: 3.7.5
Qt version: 5.12.6
PyQt5 version: 5.12.3
Operating System: Darwin 19.0.0

Dependencies
cloudpickle >=0.5.0          :  1.2.2 (OK)
pygments >=2.0               :  2.4.2 (OK)
qtconsole >=4.6.0            :  4.7.0.dev0 (OK)
nbconvert >=4.0              :  5.6.1 (OK)
sphinx >=0.6.6               :  2.2.1 (OK)
pylint >=0.25                :  2.4.4 (OK)
psutil >=0.3                 :  5.6.5 (OK)
qtawesome >=0.5.7            :  0.6.0 (OK)
qtpy >=1.5.0                 :  1.9.0 (OK)
pickleshare >=0.4            :  0.7.5 (OK)
zmq >=17                     :  18.1.1 (OK)
chardet >=2.0.0              :  3.0.4 (OK)
numpydoc >=0.6.0             :  0.9.1 (OK)
spyder_kernels >=1.8.1;<2.0.0:  1.9.0.dev0 (OK)
qdarkstyle >=2.7             :  2.7 (OK)
atomicwrites >=1.2.0         :  1.3.0 (OK)
diff_match_patch >=20181111  :  20181111 (OK)
intervaltree                 :  None (OK)
watchdog                     :  None (OK)
keyring                      :  None (OK)
pexpect >=4.4.0              :  4.7.0 (OK)
sympy >=0.7.3                :  1.4 (OK)
cython >=0.21                :  None (NOK)
IPython >=4.0                :  7.11.0.dev (OK)
matplotlib >=2.0.0           :  3.1.2 (OK)
pandas >=0.13.1              :  0.25.3 (OK)
numpy >=1.7                  :  1.17.4 (OK)
scipy >=0.17.0               :  1.3.3 (OK)
pyls >=0.31.2;<0.32.0        :  0.31.1 (NOK)
applaunchservices >=0.1.7    :  0.2.1 (OK)

An example: (rename to .py)
pdc_lib copy.py.txt

Could you help us with this one @impact27?

I think I can help with optimizing the scrollflag paintEvent if you need help with it.

That'd be really appreciated, thanks!

That'd be really appreciated, thanks!

Ok I'm on it. I won't touch the __mark_occurences in spyder/plugins/editor/widgets/codeeditor.py though.

This would be related to #10992

I opened https://github.com/spyder-ide/spyder/pull/11036 for __mark_occurences
I go from taking 33s for __mark_occurences to 1.2s (mostly taken by __find_next)

so this issue still persists for me, even when deactivating code folding, and it only stops when I deactivate the LSP altogether. symptoms are that whenever I add or modify code to large files, my input is being evaluated, and the the editor freezes for about 2 secs before I can do something again.
do you want me to open a new issue?

Hey @mluerig, we're aware of this problem (see issue #21637). Some changes to improve the situation will arrive in Spyder 6.0 and we'll continue working on it in 6.1 (to be released at the end of the year).
To give you more context about this: it's not an easy problem to solve because we're not able to run the most expensive computations needed for the LSP in threads due to Python's GIL (Global Interpreter Lock). So we have to find clever ways to do it and that takes time and effort.

hey, thanks for the update - ok, I'll be patient 😄


Performance

I have an exported CSV file here with 2.5 bln rows in it, each row at the moment contains only one column of length about 10 symbols.
When I stream it through fs.createReadStream, the entire stream finishes processing in 2.4 seconds.
When I redirect the stream into your library, using .pipe(csv()), well, I hit Ctrl+Break after 10 mins of it still trying to finish. It is just that slow.
UPDATE: I am processing the stream in paused mode, and I noticed that once I'm getting readable event, the following read always returns just one row. This is what seems to create the major bottleneck.
Is it possible to make this library buffer more than one row at a time, so we can make multiple read-s on each readable to get many rows at once?

@vitaly-t you should try c++

@maxogden I think that paying a PC game and then drinking a pint will help me better. But thanks for trying :)

@vitaly-t according to the number in the readme (90,000 rows/second) it would take 7.7 hours to parse 2.5 billion rows

@maxogden , that figures. I have updated my question above, pointing at the performance issue.

@maxogden on the exact performance figures, I'm getting 43 million rows processed in 1 minute, which isn't as bad as you described, but still, it will take about 1 hour to process the entire file. Next to 2.4 seconds when processing it directly makes you think to use your own CSV parser :)

Let's consider this a #wontfix unless someone wants to look into it :)

@emilbayes have you tried to reproduce the issue described?


add setting for customize http method when querying timestamp

Currently, the Downloader will use HEAD as HTTP request method to query timestamp, it works most of the time, but it will prevent user from updating if user is behind a strict proxy which only allow GET and POST method.
So I introduced a setting item:
downloader.quick.query.timestamp=true
The default value is true, so the Downloader will use HEAD in getLastModified(), and this is the current behavior, won't affect existing users. The user then could change the value to false and in this way, the Downloader will use GET as HTTP method to query timestamp.

Hi Jeremy, do you have any comments about this change? would you please approve it?

I plan on merging this - however, there are a lot of other tasks that need to be performed (updating the other interfaces (Maven, CLI, Ant) and updating the related documentation. I should be able to do this soon but I am in the middle of debugging a build issue that only shows up in some linux environments using JDK8.
--Jeremy

Got it, thank you very much.

This change has been merged.


{alttpr-opentracker,am2rlauncher,avalonia-ilspy,clr-loader,dafny,formula,gh-gei,ilspycmd,inklecate,knossosnet}: update from .NET 6/7 to .NET 8

Patches the following packages to point to .NET 8.0:

alttpr-opentracker (issue upstream: https://github.com/trippsc2/OpenTracker/issues/93)
am2rlauncher (issue upstream: https://github.com/AM2R-Community-Developers/AM2RLauncher/issues/93)
avalonia-ilspy: (issue upstream: https://github.com/icsharpcode/AvaloniaILSpy/issues/151)
clr-loader (no issue upstream because they're just sample projects and not actually built)
dafny (issue upstream: https://github.com/dafny-lang/dafny/issues/4948)
formula (issue upstream: https://github.com/VUISIS/formula-dotnet/issues/42)
inklecate (issue upstream: https://github.com/inkle/ink/issues/922)
knossosnet (issue upstream: https://github.com/KnossosNET/Knossos.NET/issues/259)

The following have been upgraded to a new version that has support for a newer .NET:

gh-gei (first version with .NET 8 support is v1.10.1, but might as well upgrade to latest while I'm at it):

https://github.com/github/gh-gei/releases/tag/v1.10.0
https://github.com/github/gh-gei/releases/tag/v1.10.1
https://github.com/github/gh-gei/releases/tag/v1.11.0

ilspycmd (upgrade to preview version was needed because it's the only one that has .NET 8 support):

https://github.com/icsharpcode/ILSpy/releases/tag/v8.1
https://github.com/icsharpcode/ILSpy/releases/tag/v8.1.1
https://github.com/icsharpcode/ILSpy/releases/tag/v8.2
https://github.com/icsharpcode/ILSpy/releases/tag/v9.0-preview1
https://github.com/icsharpcode/ILSpy/releases/tag/v9.0-preview2
https://github.com/icsharpcode/ILSpy/releases/tag/v9.0-preview3

Part of #326335.
Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)

[ ] sandbox = relaxed
[ ] sandbox = true

[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[x] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[x] Tested basic functionality of all binary files (usually in ./result/bin/)
25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[x] Fits CONTRIBUTING.md.

Add a :+1: reaction to pull requests you find important.

nixpkgs-review result
Generated using nixpkgs-review.
Command: nixpkgs-review pr 366067

x86_64-linux

:white_check_mark: 13 packages built:

alttpr-opentracker
am2rlauncher
avalonia-ilspy
dafny
formula
gh-gei
ilspycmd
inklecate
knossosnet
python311Packages.clr-loader
python311Packages.clr-loader.dist
python312Packages.clr-loader
python312Packages.clr-loader.dist

nixpkgs-review result
Generated using nixpkgs-review.
Command: nixpkgs-review pr 366067

x86_64-linux

:white_check_mark: 13 packages built:

alttpr-opentracker
am2rlauncher
avalonia-ilspy
dafny
formula
gh-gei
ilspycmd
inklecate
knossosnet
python311Packages.clr-loader
python311Packages.clr-loader.dist
python312Packages.clr-loader
python312Packages.clr-loader.dist

gh-gei was updated to .NET 8 (and latest version of the individual package) in https://github.com/NixOS/nixpkgs/pull/366482.

Removed gh-gei from PR and rebased on latest master to fix merge issues.

nixpkgs-review result
Generated using nixpkgs-review.
Command: nixpkgs-review pr 366067

x86_64-linux

:white_check_mark: 12 packages built:

alttpr-opentracker
am2rlauncher
avalonia-ilspy
dafny
formula
ilspycmd
inklecate
knossosnet
python311Packages.clr-loader
python311Packages.clr-loader.dist
python312Packages.clr-loader
python312Packages.clr-loader.dist

In the interest of not having another entry to https://github.com/NixOS/nixpkgs/issues/310373, I'll be undoing a few of the finalAttrs changes that are in this PR.

nixpkgs-review result
Generated using nixpkgs-review.
Command: nixpkgs-review pr 366067

x86_64-linux

:white_check_mark: 12 packages built:

alttpr-opentracker
am2rlauncher
avalonia-ilspy
dafny
formula
ilspycmd
inklecate
knossosnet
python312Packages.clr-loader
python312Packages.clr-loader.dist
python313Packages.clr-loader
python313Packages.clr-loader.dist


Add GH Actions CI support

This adds GH Actions CI as a replacement for AZP, per the ASWF decision to switch, and in preparation for adding GPU CI support.
Some notes to help in reviewing the changes:

GH Actions currently has no support for templates like AZP had, so everything exists in the one yml workflow file. I could have moved some of the commands into .sh scripts, but opted to leverage the dynamic nature of the job matrices, so the workflow is mostly self-contained. The benefit is that it is easier to see what's going on at a glance.
GH Actions matrices are quite different in design from AZP. In theory their approach is quite nice, as you get the cross product of one or more sequences of options, but I found in practice that it makes it harder to keep the job budget down while running CI. It's easy to end up having 16 jobs when trying to test a number of different configurations. My approach to solving this was to force an AZP style matrix by having the only matrix sequence be a list of build indices, and then using the include feature (designed for tacking additional variables onto specific matrix builds) to define each of the index builds independently. The result is fewer builds, but still good representation of OCIO build options.
Each platform has Release, Debug, Python 3, Python 2, SSE, no SSE, static, shared, and on Linux GCC and Clang. Some commented workarounds are present which will be removed after a ci-ocio:2020 image is added to the aswf-docker project. I will submit issues/PRs there for needed changes and patch our workflow in later PR(s).
I have disabled CI when the only changes are .md files to ease PRs for TSC notes and documentation which does not need to be built. Hopefully that will not cause issues with required checks for these PRs. We can easily change that if it does.
I tested all the builds in my fork successfully, including the latest and SonarCloud builds. Having CI directly in GH is quite nice!

Signed-off-by: Michael Dolan<EMAIL_ADDRESS>

Here is the successful full GH Actions build for reference, since it will not trigger in this PR:
https://github.com/michdolan/OpenColorIO/actions/runs/80819230

GH Actions build status: https://github.com/michdolan/OpenColorIO/runs/610888635?check_suite_focus=true

I am now going to test a full build again by temporarily enabling the scheduled jobs. I will disable them in a follow up commit.

All jobs completed with new changes: https://github.com/michdolan/OpenColorIO/actions/runs/85424974

[Question] The current build image is the ASWF 2019 one, and you plan to transition the build system to the 2020 one. However, I think that the build system must support the latest VFX Platform recommandation plus 1 or 2 older ones.
[Comment] The new build description is better. It would be nice to have the compiler version if that's possible.

When I add CY2020 my plan was to keep CY2019 as well. We could add CY2018, but in terms of OCIO dependencies there is not a difference (compilers have not changed between the three years). Even between 2019/2020 the major difference for us is only the Python version.
I could re-add  compiler version, but it will need to be hard-coded since there is no way to inspect it from the docker container. As a counter argument, if you really want to know the specific compiler version, the job is broken up into really granular steps and within the top lines of the "Configure" step you can see the exact compiler version reported by CMake. But I can add it back in.

Also, I just remembered why I was using C++14. It's because VFX ref platform mandates it since CY2018. We can keep with C++11, but  just mentioning it.

When I add CY2020 my plan was to keep CY2019 as well. We could add CY2018, but in terms of OCIO dependencies there is not a difference [...]

Right, and CY2019 & CY2018 are for OCIOv1.

Also, I just remembered why I was using C++14. [...]

So, one build per compiler with C++14 is then needed.

Compiler version in the description

If that's not easy, then forget.

GH actions test of new changes:
https://github.com/michdolan/OpenColorIO/runs/614244105?check_suite_focus=true

Few comments using the latest CI build:

The cxx is empty in the build title
Linux CentOS 7 latest ext packages <Clang 7, config=Release, shared=ON, sse=ON, cxx=, python=3.7, docs=OFF>.
The docs build cost is about 3 mins per build so one docs build per platform is enough.
The Python 3 install cost is almost 3 mins so it would be great to have it by default in the ASWF docker image (Python 2 & 3 in the ASWF docker images).
In the 'latest' builds, there are issues:

eXpat problems are: builds tests & tools & examples, build type is unknown and builds a shared library.
OpenEXR problems are: builds tests & examples, and PYILMBASE_ENABLE is enabled (it's causing trouble between boost & python3 but that's known OpenEXR issue 684)

Most recent GH Actions build:
https://github.com/michdolan/OpenColorIO/actions/runs/86938211

The most recent commit responds to all comments except resolving the Python 3 install in the aswf-docker container. That will be done in a future PR since it will take time to submit that change and roll it into available containers.


Development

Fossil island agility shortcut
Add moonlight potions to fighter

sorry new to all this, is it normal for there to be so many commits even if they were things i reverted? is there any way to clean that up or is it normal/required?


Leverage docker cache

Test name
Status

auto-config
passed

demand-backup
failed

init-deploy
passed

gr-init-deploy
passed

monitoring
passed

config
passed

scaling
passed

semi-sync
passed

users
passed

service-per-pod
passed

sidecars
passed

limits
passed

We run 12 out of 12

commit: https://github.com/percona/percona-server-mysql-operator/pull/160/commits/0673fb68f3948ea77092ed5624c189f09eb64300
image: perconalab/percona-server-mysql-operator:PR-160-0673fb6

@hors @inelpandzic it was not about the size but time. since we use multi stage builds final image size won't be changed.

@hors @inelpandzic it was not about the size but time. since we use multi stage builds final image size won't be changed.

Yeah, makes sense. This is timed with a time command, like time make:
Without cache: make  2.99s user 3.00s system 1% cpu 6:58.85 total
With cache: make 2.84s user 2.40s system 1% cpu 5:24.40 total

@hors can we delete /usr/lib/debug/usr/bin folder in this PR until DISTMYSQL-190 is done?

@hors can we delete /usr/lib/debug/usr/bin folder in this PR until DISTMYSQL-190 is done?

@pooknull yes, we can do it as a workaround

Test name
Status

auto-config
passed

config
passed

demand-backup
passed

init-deploy
passed

gr-init-deploy
passed

monitoring
passed

scaling
passed

semi-sync
passed

service-per-pod
passed

users
passed

sidecars
passed

limits
passed

We run 12 out of 12

commit: https://github.com/percona/percona-server-mysql-operator/pull/160/commits/87de71b70bf35dfb74e738405c7285832521e5cf
image: perconalab/percona-server-mysql-operator:PR-160-87de71b

@pooknull wow thank you

Test name
Status

auto-config
passed

config
passed

We run 2 out of 12

commit: https://github.com/percona/percona-server-mysql-operator/pull/160/commits/5881e12257c0b27a7866d4e43019c19287f4372e
image: perconalab/percona-server-mysql-operator:PR-160-5881e12


docker swarm restart-condtion is not adpated

Description
After creation docker service with option which is '--restart-condition any'. If I kill dockerd after running the service, the container should be restarted if I start dockerd again. --restart-condition is only for service abstraction that I create? every time service which is created re create container again. Therefore the containers are still in the list with exited(137) code. Is it right behavior or a bug?

Steps to reproduce the issue:

Create service
$ docker service create --name test --restart-condition any busybox tail -f /dev/null
Check service and container whether it runs or not
Kill dockerd
Start dockerd
Check container

CONTAINER ID        IMAGE                                                                             COMMAND               CREATED             STATUS                       PORTS               NAMES
b7f05b1d1c05        busybox@sha256:32f093055929dbc23dec4d03e09dfe971f5973a9ca5cf059cbfb644c206aa83f   "tail -f /dev/null"   6 minutes ago       Up 6 minutes                                     test.1.pra8lelu4szo9do8ch8gmjgtk
3f0282124045        busybox@sha256:32f093055929dbc23dec4d03e09dfe971f5973a9ca5cf059cbfb644c206aa83f   "tail -f /dev/null"   7 minutes ago       Exited (137) 6 minutes ago                       test.1.rk9f49fi7rxuyzcf4pl4emhx6
Describe the results you received:
Describe the results you expected:
Additional information you deem important (e.g. issue happens only occasionally):
Output of docker version:
Client:
 Version:      1.13.1
 API version:  1.26
 Go version:   go1.7.5
 Git commit:   092cba3
 Built:        Wed Feb  8 06:42:29 2017
 OS/Arch:      linux/amd64

Server:
 Version:      1.13.1
 API version:  1.26 (minimum version 1.12)
 Go version:   go1.7.5
 Git commit:   092cba3
 Built:        Wed Feb  8 06:42:29 2017
 OS/Arch:      linux/amd64
 Experimental: false

Output of docker info:
Containers: 2
 Running: 1
 Paused: 0
 Stopped: 1
Images: 29
Server Version: 1.13.1
Storage Driver: aufs
 Root Dir: /var/lib/docker/aufs
 Backing Filesystem: extfs
 Dirs: 30
 Dirperm1 Supported: true
Logging Driver: json-file
Cgroup Driver: cgroupfs
Plugins:
 Volume: local
 Network: bridge host macvlan null overlay
Swarm: active
 NodeID: u3alux6p8rvzqwt0ugcs3a2if
 Is Manager: true
 ClusterID: sjp6h4vgfa457rcfojvpcmy1s
 Managers: 1
 Nodes: 1
 Orchestration:
  Task History Retention Limit: 5
 Raft:
  Snapshot Interval: 10000
  Number of Old Snapshots to Retain: 0
  Heartbeat Tick: 1
  Election Tick: 3
 Dispatcher:
  Heartbeat Period: 5 seconds
 CA Configuration:
  Expiry Duration: 3 months
 Node Address: <IP_ADDRESS>
 Manager Addresses:
  <IP_ADDRESS>:2377
Runtimes: runc
Default Runtime: runc
Init Binary: docker-init
containerd version: aa8187dbd3b7ad67d8e5e3a15115d3eef43a7ed1
runc version: 9df8b306d01f59d3a8029be411de015b7304dd8f
init version: 949e6fa
Security Options:
 apparmor
Kernel Version: 4.4.0-62-generic
Operating System: Ubuntu 14.04.5 LTS
OSType: linux
Architecture: x86_64
CPUs: 2
Total Memory: 1.763 GiB
Name: namsu-H81H3-M4
ID: 6VSX:3RD6:BYDG:HGXJ:YINK:RADA:E6K7:RPVV:SGXV:LI56:OEDH:7JTI
Docker Root Dir: /var/lib/docker
Debug Mode (client): false
Debug Mode (server): false
Username: namsulee
Registry: https://index.docker.io/v1/
WARNING: No swap limit support
Experimental: false
Insecure Registries:
 <IP_ADDRESS>:80
 <IP_ADDRESS>/8
Live Restore Enabled: false

Additional environment details (AWS, VirtualBox, physical, etc.):

This is by design; in swarm mode, docker manages services, not individual "containers" (tasks). When you define a service, docker will make sure that the specified number of instances of that service are running. If one of those tasks fails, docker creates a new one to replace it. The "old" (failed) task is kept around to allow you to investigate why the task failed. The number of "old" tasks to preserve is configurable through the --task-history-limit option on docker swarm update. Once there are more than "--task-history-limit" tasks, older tasks (containers) are removed.
I'll close this issue, because this is not a bug, but feel free to continue the conversation


bug: ion-option-button in ion-list strange effect - v.1.0.0 beta 14

Type: bug
Platform: android 4.4 webview
In beta 13 didn't cause this strange effect. Look this video!
https://www.dropbox.com/s/z288muqb8dk8g1g/IMG_0228.MOV?dl=0
Android 4.4.4 Nexus 4.
<ion-view title="Events">
  <ion-nav-buttons side="left">
    <button menu-toggle="left"class="button button-icon icon ion-navicon"></button>
  </ion-nav-buttons>
  <ion-content>
	<ion-refresher
		pulling-text="Pull to refresh..."
		on-refresh="doRefresh()"
		refreshing-text="Refreshing!"
        refreshing-icon="ion-loading-c">
	</ion-refresher>
	<ion-list>
	  <ion-item
	  collection-repeat="row in rows"
	  collection-item-height="160"
	  ng-class="rowClass(row)"
	  ng-click="navigate(row)" ng-style="{'width':'100%', 'height':'160px'}">

Id: {{row.id}} Subject: {{row.subject}}

Customer: {{row.customercontact}} {{row.customerlocation.customer.name}} {{row.customerlocation.fulladdress}}

Creation: {{row.date}}

Assigned: {{row.assigneduser.username}}

Status: {{row.eventstatus.name}} Level: {{row.eventlevel.name}}

Tracks: {{row.trackscount}}

		<ion-option-button class="button-assertive" ng-click="edit(row)">Edit</ion-option-button>
		<ion-option-button class="button-positive" ng-click="delete(row)">Delete</ion-delete-button>
	  </ion-item>
	</ion-list>
	<ion-infinite-scroll
    on-infinite="loadMore()"
    distance="10%">
  </ion-infinite-scroll>
  </ion-content>
</ion-view>

$scope.delete = function(item) {
		$ionicListDelegate.closeOptionButtons();
		angular.forEach($scope.rows, function(obj, index){
			if(obj.id == item.id) {
				$scope.rows.splice(index, 1);
				return;
			}
		});
	};

Greetings, @danicomas!
We are now requiring all issues to be submitted through our custom issue form so that we have all of the information necessary to fix them as quickly as possible.
Your progress on this issue has been saved at the following url:
link to Ionic issue form
This issue will be closed if not resubmitted through the form. Please fill out the rest of the form so that we may assist you.
Thank you for allowing me to assist you.

Haven't had a chance to look into this yet, but can't you just pass the index to the delete function? This would remove the need for the inner loop, which can be a performance hit and might be causing the flickering:
  $scope.delete = function(item) {
    $scope.items.splice($scope.items.indexOf(item), 1);
  }

This is not the solution. Look this with your code (option buttons is not closed)

If I try
$scope.delete = function(item) {
		$scope.rows.splice($scope.rows.indexOf(item), 1);
		$ionicListDelegate.closeOptionButtons();
	};

The options are closed but sometimes cause a strange effect (open and close options of another row list)

@drewrygh @mhartington my code pen:
http://codepen.io/danicomas/pen/ByWoRP
Open in a new browser. Scroll, swipe, and delete an item. Delete some items because sometimes works good.

Duplicate of https://github.com/driftyco/ionic/issues/1811

ng-class not working when combined with ion-option-button inside ion-item tag.
Here is my snippet:
HTML:
<ion-list class="list">
<ion-item ng-repeat="task in tasks | filter:searchText" class="item item-text-wrap item-icon-left"
 ng-click="onEditTask(task)"  ng-class="{'grey_background': task.status != 'Pending' && task.status != 'Overdue'}">

 	<ion-option-button class="button-assertive"  ng-click = "onDeleteTask(task)">

    </ion-option-button>

Description: {{task.description}}

Status: {{task.status}}

</ion-item>
</ion-list>

CSS:
.grey_background {
	background-color: #dfdfdf;
}

This code should change background color to grey if ion-item having task.status other than Pending or Overdue but it does not.
If I remove ion-option-button tag it works as expected.


Update to v9.1.0946

Checklist

[x] Used a personal fork of the feedstock to propose changes
[x] Bumped the build number (if the version is unchanged)
[x] Reset the build number to 0 (if the version changed)
[x] Re-rendered with the latest conda-smithy (Use the phrase @conda-forge-admin, please rerender in a comment in this PR for automated rerendering)
[x] Ensured the license file is being packaged.

Hi! This is the friendly automated conda-forge-linting service.
I just wanted to let you know that I linted all conda-recipes in your PR (recipe/meta.yaml) and found it was in an excellent condition.

Thank you for the PR @blmaier! Would you like to add yourself as a maintainer here?


Inheritance and compilation

I can't understand why this oversimplified snippet doesn't compile, while IMO it should:
abstract class BaseGenericClass<T> {
  final T _arg;

  BaseGenericClass(this._arg);
}

class GenericClass<T extends AbstractArgClass> extends BaseGenericClass<T> {
  GenericClass() : super(ArgClass());
}

abstract class AbstractArgClass {}

class ArgClass extends AbstractArgClass {}

Introducing an otherwise useless class between GenericClass and BaseGenericClass solves the problem:
abstract class BaseGenericClass<T> {
  final T _arg;

  BaseGenericClass(this._arg);
}

class IntermediateClass<T extends AbstractArgClass> extends BaseGenericClass<T> {
  IntermediateClass(T arg) : super(arg);
}

class GenericClass extends IntermediateClass {
  GenericClass() : super(ArgClass());
}

abstract class AbstractArgClass {}

class ArgClass extends AbstractArgClass {}

Your problem is that you cannot guarantee the following is valid for all kinds of T which extends AbstractArgClass:
class GenericClass<T extends AbstractArgClass> extends BaseGenericClass<T> {
  GenericClass() : super(ArgClass());
}

E.g. if we have another class that extends AbstractArgClass like:
class AlternativeArgClass extends AbstractArgClass {}

And then we try use GenericClass with our own provided generic argument:
GenericClass<AlternativeArgClass>()

It would not be valid since GenericClass would then need to extend from BaseGenericClass<AlternativeArgClass> which require its parameter to be of the type AlternativeArgClass. But the default constructor for GenericClass will try do super(ArgClass()) which fails since ArgClass is not compatible with AlternativeArgClass.

Thank you, didn't think of that!


[Feature Request] Implement usage of Refresh Token

Tell us about your feature request
It would be great to see an implementation to get the possibility to use the Refresh Token for authorization of a user access.
Currently I only see the possibility to take an existing Access Token and verify it.
If this existing token is no longer valid we can not use the Refresh Token to generate a new Access Token but instead the current user has to deal with a browser popup.
I'm thinking of something like this:
twitch token -r {RefreshToken} or twitch token --refresh {RefreshToken}
If refreshing is possible I would then expect that the new properties are stored and the CLI gives back a valid result like when calling twitch token -v {AccessToken}.
Disclaimer

[X] I agree

Can be implemented as twitch token --refresh <refresh token> with optional flags --client-id and --secret.
Currently there is no --secret flag so this will have to be implemented similar to --client-id
If --client-id is not specified, the value will be stored in the CLI's config file.


Use random name for manager semaphore

Fixes #56.

Please be sure to sign your commit for the DCO checker.

DCO fixed.


fix Fix right join pull output block memory overflow

Proposed changes
Issue Number: close #xxx
Problem summary
For outer join / right outer join / right semi join, when HashJoinNode::pull->process_data_in_hashtable outputs a block, it will output all rows of a key in the hash table into a block, and the output of a key is completed After that, it will check whether the block size exceeds the batch size, and if it exceeds, the output will be terminated.
If a key has 2000w+ rows, memory overflow will occur when the subsequent block operations on the 2000w+ rows are performed.
#0 0x00007f97a9cfab91 in __memset_avx2_erms () from /lib64/libc.so.6
#1 0x000055ada0b43234 in __asan_memset ()
#2 0x000055adabe97750 in doris::vectorized::FunctionCase<false, true>::execute_impl<doris::vectorized::ColumnString, false, true> (this=0x606001744290, data_type=...,
block=..., result=8, column_holder=...) at /projects/doris/be/src/vec/functions/function_case.h:190
#3 0x000055adabe94713 in doris::vectorized::FunctionCase<false, true>::execute_get_then_null<doris::vectorized::ColumnString, false> (this=0x606001744290, data_type=...,
block=..., arguments=..., result=8, input_rows_count=11273387) at /projects/doris/be/src/vec/functions/function_case.h:321
#4 0x000055adabe48cc8 in doris::vectorized::FunctionCase<false, true>::execute_get_when_null<doris::vectorized::ColumnString> (this=0x606001744290, data_type=...,
block=..., arguments=..., result=8, input_rows_count=11273387) at /projects/doris/be/src/vec/functions/function_case.h:351
#5 0x000055adabe4576a in doris::vectorized::FunctionCase<false, true>::execute_get_type (this=0x606001744290, data_type=..., block=..., arguments=..., result=8,
input_rows_count=11273387) at /projects/doris/be/src/vec/functions/function_case.h:367
#6 0x000055adabe44cbc in doris::vectorized::FunctionCase<false, true>::execute_impl (this=0x606001744290, context=0x6020007e3b30, block=..., arguments=..., result=8,
input_rows_count=11273387) at /projects/doris/be/src/vec/functions/function_case.h:374
#7 0x000055ada9b1c7a6 in doris::vectorized::DefaultExecutable::execute_impl (this=0x6040003db860, context=0x6020007e3b30, block=..., arguments=..., result=8,
input_rows_count=11273387) at /projects/doris/be/src/vec/functions/function.h:465
#8 0x000055adabc9ecdd in doris::vectorized::PreparedFunctionImpl::execute_without_low_cardinality_columns (this=0x6040003db860, context=0x6020007e3b30, block=...,
args=..., result=8, input_rows_count=11273387, dry_run=false) at /projects/doris/be/src/vec/functions/function.cpp:251
#9 0x000055adabc9fe80 in doris::vectorized::PreparedFunctionImpl::execute (this=0x6040003db860, context=0x6020007e3b30, block=..., args=..., result=8,input_rows_count=11273387, dry_run=false) at /projects/doris/be/src/vec/functions/function.cpp:272
#10 0x000055ada9b199eb in doris::vectorized::IFunctionBase::execute (this=0x6070006546e0, context=0x6020007e3b30, block=..., arguments=..., result=8, input_rows_count=11273387, dry_run=false) at /projects/doris/be/src/vec/functions/function.h:136
#11 0x000055ada9ae9c0d in doris::vectorized::VCaseExpr::execute (this=0x619003fb5b80, context=0x606001641500, block=0x7f9522dfe620, result_column_id=0x7f9522dfe720) at /projects/doris/be/src/vec/exprs/vcase_expr.cpp:90
#12 0x000055ada9aa3224 in doris::vectorized::VExprContext::execute (this=0x606001641500, block=0x7f9522dfe620, result_column_id=0x7f9522dfe720) at /projects/doris/be/src/vec/exprs/vexpr_context.cpp:43
#13 0x000055ada9aa5f7c in doris::vectorized::VExprContext::get_output_block_after_execute_exprs (output_vexpr_ctxs=..., input_block=..., status=...) at /projects/doris/be/src/vec/exprs/vexpr_context.cpp:143
#14 0x000055adb143bc25 in doris::vectorized::VMysqlResultWriter::append_block (this=0x60d000dbd130, input_block=...) at /projects/doris/be/src/vec/sink/vmysql_result_writer.cpp:425
#15 0x000055adb14318e4 in doris::vectorized::VResultSink::send (this=0x6110007e10c0, state=0x61c000356080, block=0x7f9522e98d70, eos=false) at /projects/doris/be/src/vec/sink/vresult_sink.cpp:91
#16 0x000055ada2baecd3 in doris::PlanFragmentExecutor::open_vectorized_internal (this=0x617000098870) at /projects/doris/be/src/runtime/plan_fragment_executor.cpp:304
#17 0x000055ada2bab8cf in doris::PlanFragmentExecutor::open (this=0x617000098870) at /projects/doris/be/src/runtime/plan_fragment_executor.cpp:244
#18 0x000055ada2b11295 in doris::FragmentExecState::execute (this=0x617000098800) at /projects/doris/be/src/runtime/fragment_mgr.cpp:250
#19 0x000055ada2b15b57 in doris::FragmentMgr::_exec_actual(std::shared_ptr<doris::FragmentExecState>, std::function<void (doris::RuntimeState*, doris::Status*)>) (this=0x627000003900, exec_state=..., cb=...) at /projects/doris/be/src/runtime/fragment_mgr.cpp:490
#20 0x000055ada2b2addc in doris::FragmentMgr::exec_plan_fragment(doris::TExecPlanFragmentParams const&, std::function<void (doris::RuntimeState*, doris::Status*)>)::$_3::operator()() const (this=0x6080005be5a0) at /projects/doris/be/src/runtime/fragment_mgr.cpp:725

Checklist(Required)

Does it affect the original behavior:

[x] Yes
[ ] No
[ ] I don't know

Has unit tests been added:

[ ] Yes
[x] No
[ ] No Need

Has document been added or modified:

[ ] Yes
[x] No
[ ] No Need

Does it need to update dependencies:

[ ] Yes
[x] No

Are there any changes that cannot be rolled back:

[ ] Yes (If Yes, please explain WHY)
[x] No

Further comments
If this is a relatively large or complex change, kick off the discussion at<EMAIL_ADDRESS>by explaining why you chose the solution you did and what alternatives you considered, etc...

TeamCity pipeline, clickbench performance test result:
the sum of best hot time: 34.91 seconds
load time: 671 seconds
storage size:<PHONE_NUMBER>3 Bytes
https://doris-community-test-1308700295.cos.ap-hongkong.myqcloud.com/tmp/20221228140622_clickbench_pr_70171.html


Monk Way of survival - lvl 11 feature "unmoving strength" adding double con modifier

The level 11 feature for Way of Survival Monk (unmoving strength) is adding twice the con modifier to damage with the mod installed instead of just the con modifier.
With Mod active -Unmoving strength adds +4 damage with a +2 con modifier

Without Mod active -Unmoving strength adds +2 damage with a +2 con modifier

I can confirm we have one patch on method that calculates these additions. Indeed when this patch is disabled it works correctly. Still haven’t found a fix.

Issue was found. To be fixed in dev.


Table in ast-node-types

What version of textlint are you using?
@textlint/ast-node-types 4.4.1
What file type (Markdown, plain text, etc.) are you using?
Anything
What did you do? Please include the actual source code causing the issue.
I imported type definitions like Table.
What did you expect to happen?
We should define actual node types in ast-node-types.
What actually happened? Please include the actual, raw output from textlint.
import {Table, TableRow, TableCell} from "@textlint/ast-node-types"

ref: https://github.com/textlint/textlint-plugin-latex2e/issues/69

FYI, the developers of textlint-plugin-review also pointed out that there is no definition of table nodes.
https://github.com/orangain/textlint-plugin-review/pull/6
They used a workaround that uses ListItem nodes to represent table cells.

FYI, the developers of textlint-plugin-review also pointed out that there is no definition of table nodes.
https://github.com/orangain/textlint-plugin-review/pull/6
They used a workaround that uses ListItem nodes to represent table cells.

markdown parser in texltint defined Table, TableRow, TableCell as extensions.
https://github.com/textlint/textlint/blob/a088520447cf557ccbc5d08bb481f5b8bc33d2dd/packages/%40textlint/markdown-to-ast/src/mapping/markdown-syntax-map.ts#L26-L31
The reason is that They are not defined in CommonMark Spec. (They are gfm extension)
However, various parser parse table syntax actually.
So, it may be reasonable that @textlint/ast-node-types defined Table, TableRow, TableCell
I'm ok that we add  Table, TableRow, TableCell to "@textlint/ast-node-types".
📝 I have never written a rule that uses Table, TableRow, TableCell directoly.

Oh, this is an extension. I got it. Thank you for replying.
I have never thought the textlint allows other node types as extensions.
It's interesting. CommonMark is also one dialect of Markdown.
As you know, there is a so long history about Markdown dialect. Covering various syntax is a nice feature for working on Markdown. Please consider it.

textlint just pass through an unknown node's type.
For example, a parser creates Example type, and textlint pass the Example node to each rule.
// A rule can treat Example node
export default () => {
  return {
    ["Example"](node){
    }
  }
}

"@textlint/ast-node-types" just define constant value for basic node types.
Probably, it is not related to processing logic in textlint.
In other words, textlint does not drop unknown node type.


If you press cancel button after successful purchase, IabHelper.OnIabPurchaseFinishedListener returns Failure

If you press cancel button after successful purchase (on the screenshot), IabHelper.OnIabPurchaseFinishedListener returns Failure.
I'm using openiab-<IP_ADDRESS> version.

However queryInventoryAsync returns purchase, and this is the only chance to process the purchase...

Hi @trimf
it is a known YS issue. They promised to fix it.

We can't make a workaround.

Ок. Will be waiting for update.


.visibility() can't detect scroll event to switch the menus

This prevents .sidebar() from interaction and blocks .pusher menu

Fixed by adopting a fixed menu


OpenAI new embedding models

Description
Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.
Fixes # (issue)
Type of Change
Please delete options that are not relevant.

[ ] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[ ] This change requires a documentation update

How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

[ ] Added new unit/integration tests
[ ] Added new notebook (that tests end-to-end)
[ ] I stared at the code and made sure it makes sense

Suggested Checklist:

[ ] I have performed a self-review of my own code
[ ] I have commented my code, particularly in hard-to-understand areas
[ ] I have made corresponding changes to the documentation
[ ] I have added Google Colab support for the newly added notebooks.
[ ] My changes generate no new warnings
[ ] I have added tests that prove my fix is effective or that my feature works
[ ] New and existing unit tests pass locally with my changes
[ ] I ran make format; make lint to appease the lint gods

@hatianzhang We probably have to include dimensions parameter to get different dimension embeddings. reference

I'm kind of surprised this works, since the new model isn't mentioned I'm the model dicts?

@logan-markewich I am passing by model_name

@hatianzhang ah I see. That code is way more confusing than it needs to be lol, cleanup for another pr though

@logan-markewich now changed to model instead of model_name

are the new embedding models available via Azure OpenAI with the dimensions parameter for text-embedding-3-large?

@farzad528 as far as I know yes. They inherit from the normal openai embeddings class


Misc backlinks suggestions

🚀 The feature, motivation and pitch
I like this project very much, it covers a lot of my needs. I'd like to propose some suggestions and my current workarounds (I'm a vim newbie AND a boomer (a vimooer?), so they're pretty rough):
Suggestion: Wrap the backlinks
Custom workaround: create a generic wrap remap and use it when you're inside the backlink pane:
nnoremap <F1> :set wrap<cr>
nnoremap <F2> :set nowrap<cr>

Suggestion: Resize the height of the backlinks pane
Custom workaround: None that I know of. I tried adding "20" to the backlinks command, like in ":copen 20", but it doesn't work.
Suggestion: Sort the backlinks pane
Custom workaround: None that I know of.
Suggestion: Mimick Obsidian's "Toggle backlinks in document"
Custom workaround: This is partially achieved by combining commands, for example:
nnoremap <Enter> :ObsidianFollowLink<CR>:ObsidianBacklinks<CR>:wincmd k<CR>

The above means: press enter to follow a link, the linked file will open, its backlink pane will open, the cursor will move back up to the opened file.
Alternatives
No response
Additional context
No response

thanks, I'm superhappy with these changes, they take usability up a notch.


Update build.gradle

Hello,
This fixes the following error during build:
A problem occurred configuring root project 'vortaro'.
> Could not resolve all files for configuration ':classpath'.
   > Could not find com.android.tools.build:gradle:3.0.1.
     Searched in the following locations:
         https://jcenter.bintray.com/com/android/tools/build/gradle/3.0.1/gradle-3.0.1.pom
         https://jcenter.bintray.com/com/android/tools/build/gradle/3.0.1/gradle-3.0.1.jar
     Required by:
         project :

It's also probably what broke the F-Droid build (#6).

Cool, thanks


[SMALLFIX] Removed redundant initializer in FileSystemUtils

Removed a redundant initializer in the FileSystemUtils class.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Alluxio-Pull-Request-Builder/9635/
Test PASSed.

Thanks for the improvement! I left one comment

@aaudiber Thanks for the comment. I updated the PR accordingly.

LGTM

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Alluxio-Pull-Request-Builder/9662/
Test PASSed.


Introduce interpolator to render BOSH manifests by operations files

Introduce interpolator to render BOSH manifests by operations files:

Brought bosh-cli template code to achieve interpolator function.
Refactored the Resolver implementation to add ops configmap operation.

Best,
@edwardstudy && @zhangtbj, IBM

@zhangtbj will request a CLA.