[WASI] Should we overlook or restrict the access modes for stdin/stdout/stderr?

We've observed that in certain situations, the access modes for STDIN, STDOUT and STDERR do not behave as anticipated. For example, STDOUT may be read-only, while STDIN may be write-only.
It's important that we look into why these unexpected access modes are occurring. However, I'm wondering if we need to take steps to block these incorrect settings in core/iwasm/libraries/libc-wasi
Specifically, when determining file descriptor rights in the function fd_determine_type_rights(), should we assign fixed and unchangeable rights to STDIN, STDOUT and STDERR?

I saw the PR #3694 sets the STDIN rights with:
(__WASI_RIGHT_FD_ADVISE | __WASI_RIGHT_FD_FILESTAT_GET | \
  __WASI_RIGHT_FD_READ | __WASI_RIGHT_POLL_FD_READWRITE)

not sure will it disable the write right for STDIN and disable the read right for STDOUT? It seems the similar issues were reported before, but after discussion with @yamt, we decided not to change the code:
https://github.com/bytecodealliance/wasm-micro-runtime/issues/2645#issuecomment-1790387978
https://github.com/bytecodealliance/wasm-micro-runtime/pull/2606

We've observed that in certain situations, the access modes for STDIN, STDOUT and STDERR do not behave as anticipated. For example, STDOUT may be read-only, while STDIN may be write-only.
It's important that we look into why these unexpected access modes are occurring. However, I'm wondering if we need to take steps to block these incorrect settings in core/iwasm/libraries/libc-wasi

yes, please investigate the situation further before making changes to libc-wasi.

The problem originated from integrating WAMR with runwasi, which aims to run a WebAssembly runtime within containerd. I haven't pinpointed the exact issue yet, but there are some unanticipated behaviors occurring within their sandbox environment. Like, fcntl(STDOUT, F_GETFL, 0) returns O_RDONLY. The unusual result will strip off write bits.
Then I made an trial on linux.
$ cat demo.c
int main() {
    int ret;

    ret = fcntl(STDOUT_FILENO, F_GETFL);
    printf("fcntl(stdout, F_GETFL)=%d\n", ret);

    ret = fcntl(STDOUT_FILENO, F_SETFL, O_RDONLY);
    perror("fcntl(stdout, F_SETFL, O_RDONLY)");

    ret = fcntl(STDOUT_FILENO, F_GETFL);
    printf("fcntl(stdout, F_GETFL)=%d\n", ret);

    return EXIT_SUCCESS;
}
$ clang -o demo demo.c
$ demo
fcntl(stdout, F_GETFL)=2
fcntl(stdout, F_SETFL, O_RDONLY): Success
fcntl(stdout, F_GETFL)=2

IIUC, this suggests that the access mode for STDOUT cannot be altered. As a result, it appears that the access mode for STDOUT ought to remain fixed, making any previous removal of write permissions unnecessary.
If everyone is in consensus that the access modes for STDIN, STDOUT, and STDERR are fixed and cannot be altered, then we can begin to discuss the suitable combinations of permissions for these three streams.

Agree that the access modes for STDIN, STDOUT and STDERR should be fixed, and suggest adding __WASI_RIGHT_FD_READ | __WASI_RIGHT_FD_WRITE to the rights of them all.


Character Builder, Marcos missing

I am using a fresh world with System Added, unless this has a dependency I am missing or add on module I cant see any reason why these are missing from compendium. Roll Tables, Classes, and GM journels, etc are listed in compendiums, yet none of the macros are in any folder inside of it. I also don't see any mention on the side bar.

Ops. wrong github


Allow building executor on v1.82 xtensa toolchains

This is a followup for #3508 that does not rely on the compiler build date, since the Xtensa toolchain's build dates don't match the official ones. In particular, the Xtensa 1.82 releases were built in late October, but still have the old api.

Eh yeah I forgot that our compiler is built as a nightly, from the stable branch, so I guess it worked for 1.81 because it was built on the 3rd of September, before the change landed - but 1.82 was already branched off at that point.
I'd prefer this PR over WakerHack as I think safety: OK because WakerHack has the same layout as Waker is incidental and not guaranteed to not change randomly.

Fixed in #3528


Publish with nonexistent name throws error

If you run wrangler publish --name xyz, and xyz does not exist, the following error will be thrown:
Failed to fetch /accounts/{}/workers/scripts/xyz?available_on_subdomain=true - 400: Bad Request

No stack trace is shown.

That's... weird. I'll prioritise fixing this one.

ugh https://twitter.com/brianleroux/status/1480905580873072643?s=21


Using in another projects

can it be used inside a diferent project that has already using a docker-compose.yml and no dockerfile ?

I don't work on Drizzle / Drizzle Studio, I would check out https://orm.drizzle.team/drizzle-studio/overview, it's pretty easy to use without modifying an existing project. But… if you want to have it run in Docker, then you'll need a Dockerfile for it, because Drizzle doesn't publish one (yet?).


Msp addon

Description
[Describe what this change achieves]
Issues Resolved
[List any existing issues this PR resolves]
Contribution Check List

[ ] All tests pass.
[ ] New functionality includes testing.
[ ] New functionality has been documented in the README if applicable
[ ] New functionality has been documented in CHANGELOG.MD

Dunno if the code works as written, but the concept is good


Support/Document the prefix for rds postgres logs streamed from cloudwatch

Hello ,
I am able to run pgbadger successfully with rds postgres logs with '%t:%r:%u@%d:[%p]:' prefix.  I download postgres log using  aws console. Now same logs if I download from cloudwatch, have different prefix .
Here is sample without clodwatch ,
2019-08-09 18:00:00 UTC:<IP_ADDRESS>(33436):lmn@lmn_db:[26802]:LOG:  duration: 13.817 ms  statement: SELECT id,name from abc

Now same line with cloudwatch ,
2019-08-09T18:00:00.000Z 2019-08-09 18:00:00 UTC:<IP_ADDRESS>(33436):lmn@lmn_db:[26802]:LOG:  duration: 13.817 ms  statement: SELECT id,name from abc

With cloudwatch there is an additional timestamp, and I don't what prefix could be supported /needed here? Since this is the common case, documenting it would help for additional pgbadger adoption across the community.

Logs from cloudwatch are streamed logs and hence it might require special processing. PbBadger throws the "DEBUG: Unknown stderr line format:" error .
----- here is sample sql query from log file
2019-08-08T00:49:34.000Z 2019-08-08 00:49:34 UTC:<IP_ADDRESS>(56266):xyz@xyz_db:[20474]:LOG:  duration: 5.076 ms  statement: SELECT col1, col2
FROM sample1 JOIN sample2 ON sample1.id = sample2.id
WHERE sample1.col3 = 'xyzxyz-1234-xyzw-abcd-abcd1abcd2abcd'
ORDER BY 1 DESC
-- Please note the sql is spanned over few lines because streaming .
And here is output from pgbadger,
pgbadger --prefix  '%t:%r:%u@%d:[%p]:' -f stderr --verbose t2.log DEBUG: timezone not specified, using 25200 seconds DEBUG: Output 'html' reports will be written to out.html DEBUG: Autodetected log format 'stderr' from t2.log DEBUG: pgBadger will use log format stderr to parse t2.log. DEBUG: Starting progressbar writer process DEBUG: Processing log file: t2.log DEBUG: Starting reading file t2.log... DEBUG: Start parsing postgresql log at offset 0 of file t2.log to 299 DEBUG: Unknown stderr line format:   0 bFROM sample1 JOIN sample2 ON sample1.id = sample2.id DEBUG: Unknown stderr line format: 	WHERE sample1.col3 = 'xyzxyz-1234-xyzw-abcd-abcd1abcd2abcd' DEBUG: Unknown stderr line format:         ORDER BY 1 DESC [========================>] Parsed 299 bytes of 299 (100.00%), queries: 1, events: 0 DEBUG: the log statistics gathering took: 2 wallclock secs ( 0.00 usr +  0.01 sys =  0.01 CPU) DEBUG: Output 'html' reports will be written to out.html LOG: Ok, generating html report... DEBUG: building reports took:  0 wallclock secs ( 0.02 usr +  0.01 sys =  0.03 CPU) DEBUG: the total execution time took:  2 wallclock secs ( 0.02 usr +  0.02 sys =  0.04 CPU)

Thanks for the report, this require a specific development to support cloudwatch logs.

Commit f76dbf9 adds support to RDS and CloudWatch format, they should be auto detected and your don't have to set any prefix.

Thank you very much for adding support for this feature, much appreciated.


Long company names should shrink and wrap in cards

As a user, I want to be clear about who is sending me the emails
Long names of email lists - think about the UI

Change the font size and wrap to keep using the same vertical space.


SEVERE!!! This library kills all touch input to my phone

I tried the example app on my Galaxy Note 10 and after about 10 seconds all touch input stops working making my phone completely unusable and I have to do a  hard reboot. This is 100% reproducible and only happens on Note 10. There is no discernible error messages, but looking at my logcat there appears to be some crashes with the Navigation bar.
https://imgur.com/a/0ga77P9
D/SurfaceView(31501): surfaceCreated 1 #8 io.flutter.embedding.android.FlutterSurfaceView{6801d1e V.E...... ........ 0,0-1080,2280}
D/SurfaceView(31501): surfaceChanged (1080,2280) 1 #8 io.flutter.embedding.android.FlutterSurfaceView{6801d1e V.E...... ........ 0,0-1080,2280}
I/CameraManagerGlobal(31501): Camera 91 facing CAMERA_FACING_FRONT state now CAMERA_STATE_IDLE for client com.samsung.android.bio.face.service API Level 2
D/ViewRootImpl@64bda0[MainActivity](31501): MSG_WINDOW_FOCUS_CHANGED 1 1
D/InputMethodManager(31501): prepareNavigationBarInfo() DecorView@f14b234[MainActivity]
D/InputMethodManager(31501): getNavigationBarColor() -855310
D/InputMethodManager(31501): prepareNavigationBarInfo() DecorView@f14b234[MainActivity]
D/InputMethodManager(31501): getNavigationBarColor() -855310
V/InputMethodManager(31501): Starting input: tba=com.example.agora_test ic=null mNaviBarColor -855310 mIsGetNaviBarColorSuccess true , NavVisible : true , NavTrans : false
D/InputMethodManager(31501): startInputInner - Id : 0
I/InputMethodManager(31501): startInputInner - mService.startInputOrWindowGainedFocus
D/InputTransport(31501): Input channel destroyed: 'ClientS', fd=103
I/CameraManagerGlobal(31501): Camera 91 facing CAMERA_FACING_FRONT state now CAMERA_STATE_CLOSED for client com.samsung.android.bio.face.service API Level 2

we will try looking for a device and reproduce

it's also reproduced on galaxy s10 5g, s10e (android 10)

we providing a chat component in the consultation screen.
After using another camera app for attaching. it reproduced.
we call AgoraRtcEngine.muteLocalVideoStream(true); before open another camera app.
and call AgoraRtcEngine.muteLocalVideoStream(false); after came back.
Then I/CameraManagerGlobal( 3692): postSingleUpdate device: camera id 1 status STATUS_PRESENT I/CameraManagerGlobal( 3692): Camera 1 facing CAMERA_FACING_FRONT state now CAMERA_STATE_CLOSED for client com.lawfully.lawfully_ai_tracker.dev API Level 2 I/CameraManagerGlobal( 3692): postSingleUpdate device: camera id 1 status STATUS_NOT_AVAILABLE I/CameraManagerGlobal( 3692): Camera 1 facing CAMERA_FACING_FRONT state now CAMERA_STATE_OPEN for client com.lawfully.lawfully_ai_tracker.dev API Level 2 I/CameraManagerGlobal( 3692): postSingleUpdate device: camera id 1 status STATUS_PRESENT I/CameraManagerGlobal( 3692): Camera 1 facing CAMERA_FACING_FRONT state now CAMERA_STATE_CLOSED for client com.lawfully.lawfully_ai_tracker.dev API Level 2 I/CameraManagerGlobal( 3692): postSingleUpdate device: camera id 1 status STATUS_NOT_AVAILABLE I/CameraManagerGlobal( 3692): Camera 1 facing CAMERA_FACING_FRONT state now CAMERA_STATE_OPEN for client com.lawfully.lawfully_ai_tracker.dev API Level 2
this log is reproduced infinitely.
please fix this bug

I found something.

use agora with front camera.
open camera with imagePicker using rear camera.
comeback to agora with front camera.
error like stackoverflow is reproduced.
use AgoraRTCengine.switchCamera().
the error disappear and everything came back to normal.

we don't have the device to test, is it causes ANR? or other problems?

@LichKing-2234 it causes exactly same proplem as @edTheGuy00 has.
The application and, os system become frozen.
However, when I call AgoraRTCengine.switchCamera(). it came back to normal.
So, in our service. When we came back to the application again we forcely

@BansookNam i think a more proper approach is to disableVideo when app goes to background, and enable when it comes back to foreground. wait 300ms sounds bit tricky.

you can reopen this issue if the problem still exists.


Fix csrf_detect error with concurrent authorisations

Right now, if multiple authorisations are started in different tabs, only the latest will succeed since session's state is overridden each time an authorisation starts.
This fixes that issue by having multiple states within a session rather than just one.
Note: there could still be race conditions when the session information is store is a cookie and a second authorisation is started before the browser has stored the cookie from the first one.

@sferik CI fails because one of the gems is not installing in Ruby 1.8.7 and JRuby 18 mode
An error occurred while installing addressable (2.4.0), and Bundler cannot continue.
Make sure that `gem install addressable -v '2.4.0'` succeeds before bundling.
The command "eval bundle install --jobs=3 --retry=3" failed. Retrying, 2 of 3.


fix: enable correct suite through suite collection api

If there are 2 suites with equal names suiteCollection.enable will enable first suite

/ok


Features/jackson codec ng integration with the client

NetflixOSS » eureka » eureka-pull-requests #370 SUCCESS
This pull request looks good


nautobot_config.py is evaluated twice

Environment

Nautobot version (Docker tag too if applicable): 1.5.1
Python version: 3.10
Database platform, version: pgsql
Middleware(s):

Steps to Reproduce

Add this content to nautobot_config.py (appending to the initial file, like you might do in a custom docker build):

PLUGINS += ["myplugin"]
import traceback
print('exec')
traceback.print_stack()

Start Nautobot // type from django.conf import settings; settings.PLUGINS in nautobot-server nbshell

Expected Behavior
Nautobot starts without warnings, settings.PLUGINS contains myplugin just once

Observed Behavior
The log displays:
System check identified some issues:

WARNINGS:
?: (urls.W005) URL namespace 'plugins:myplugin' isn't unique. You may not be able to reverse all URLs in this namespace
[..]

The above nbshell command reports: ["myplugin", "myplugin"]
Additional informations
The traceback code above display the code is loaded twice:
exec
  File "/usr/local/bin/nautobot-server", line 8, in <module>
    sys.exit(main())
  File "/usr/local/lib/python3.10/site-packages/nautobot/core/cli.py", line 54, in main
    run_app(
  File "/usr/local/lib/python3.10/site-packages/nautobot/core/runner/runner.py", line 258, in run_app
    configure_app(config_path=config_path, **kwargs)
  File "/usr/local/lib/python3.10/site-packages/nautobot/core/runner/runner.py", line 130, in configure_app
    importer.install(
  File "/usr/local/lib/python3.10/site-packages/nautobot/core/runner/importer.py", line 37, in install
    sys.meta_path.insert(0, LoganImporter(name, config_path, default_settings, **kwargs))
  File "/usr/local/lib/python3.10/site-packages/nautobot/core/runner/importer.py", line 63, in __init__
    self.validate()
  File "/usr/local/lib/python3.10/site-packages/nautobot/core/runner/importer.py", line 72, in validate
    execfile(self.config_path, {"__file__": self.config_path})
  File "/usr/local/lib/python3.10/site-packages/nautobot/core/runner/importer.py", line 17, in execfile
    exec(fh.read(), globalz, localz)
  File "<string>", line 9, in <module>

exec
  File "/usr/local/bin/nautobot-server", line 8, in <module>
    sys.exit(main())
  File "/usr/local/lib/python3.10/site-packages/nautobot/core/cli.py", line 54, in main
    run_app(
  File "/usr/local/lib/python3.10/site-packages/nautobot/core/runner/runner.py", line 258, in run_app
    configure_app(config_path=config_path, **kwargs)
  File "/usr/local/lib/python3.10/site-packages/nautobot/core/runner/runner.py", line 144, in configure_app
    hasattr(settings, "INSTALLED_APPS")
  File "/usr/local/lib/python3.10/site-packages/django/conf/__init__.py", line 82, in __getattr__
    self._setup(name)
  File "/usr/local/lib/python3.10/site-packages/django/conf/__init__.py", line 69, in _setup
    self._wrapped = Settings(settings_module)
  File "/usr/local/lib/python3.10/site-packages/django/conf/__init__.py", line 170, in __init__
    mod = importlib.import_module(self.SETTINGS_MODULE)
  File "/usr/local/lib/python3.10/importlib/__init__.py", line 126, in import_module
    return _bootstrap._gcd_import(name[level:], package, level)
  File "<frozen importlib._bootstrap>", line 1050, in _gcd_import
  File "<frozen importlib._bootstrap>", line 1027, in _find_and_load
  File "<frozen importlib._bootstrap>", line 1006, in _find_and_load_unlocked
  File "<frozen importlib._bootstrap>", line 672, in _load_unlocked
  File "<frozen importlib._bootstrap>", line 632, in _load_backward_compatible
  File "/usr/local/lib/python3.10/site-packages/nautobot/core/runner/importer.py", line 113, in load_module
    return self._load_module(fullname)
  File "/usr/local/lib/python3.10/site-packages/nautobot/core/runner/importer.py", line 137, in _load_module
    load_settings(self.config_path, allow_extras=self.allow_extras, settings=settings_mod)
  File "/usr/local/lib/python3.10/site-packages/nautobot/core/runner/settings.py", line 47, in load_settings
    spec.loader.exec_module(conf)
  File "<frozen importlib._bootstrap_external>", line 883, in exec_module
  File "<frozen importlib._bootstrap>", line 241, in _call_with_frames_removed
  File "/opt/nautobot/nautobot_config.py", line 9, in <module>
    traceback.print_stack()

The new default nautobot_config.py import PLUGINS from nautobot.core.settings (https://github.com/nautobot/nautobot/blob/v1.5.1/nautobot/core/templates/nautobot_config.py.j2#L4), and unlike previously, it doesn't set PLUGINS to an empty list after (https://github.com/nautobot/nautobot/commit/c6ba1f81abc047343c10d1bcb3ae25c3513538e8#diff-70d82b29016e9c2bd1c3e2c6f7c4a501ab1aecac1c246000930a0fdb8ede65d6L212), so nautobot.core.settings.PLUGINS might now effectively be extended twice.
This is not really a bug however, using PLUGINS += [..] is not what is documented, but I guess it's not what you would expect to happen. This issue is also to document for anyone else having this warning.

So first things first, there should never be PLUGINS defined in the core settings other than the default [] empty list, so appending to them isn't even accurate. So that means whatever gets importd from nautobot.core.settings is the same.
The only real change in the default template config is that the list is now imported into the namespace, but not being explicitly overwritten since it's already there. So therefore importing the empty list from nautobot.core.settings.PLUGINS and redefining PLUGINS in the config's module namespace is the same thing.
Do you have a current use-case where you're extending the list of PLUGINS from a nautobot_config.py? I'm not clear on how that would even work, since it has to be defined in either case here.

Do you have a current use-case where you're extending the list of PLUGINS from a nautobot_config.py? I'm not clear on how that would even work, since it has to be defined in either case here.

Not really an use case, just what I was doing before in my Dockerfile was like
RUN nautobot-server init
    && cat "/tmp/nautobot_config_add.py" \
      >> "/opt/nautobot/nautobot_config.py"

and since PLUGINS was set to an empty list in the initial file of older versions it worked. I adapted for the new version since.
It mainly was about reporting that situation (file is evaluated twice so don't append on nautobot.core.settings.PLUGINS or W005 might happen) for anyone else that could be affected, I won't mind if you want to close this :)

Yeah thanks for the context. Seems like a rare case, but I am actually surprised to learn that the config is being evaluated twice, so it's worth at least deciding if that's worth chasing down or not! 🥂

It doesn't seem like this is a critical issue and it is not immediately obvious how fixing it would work or what the consequences would be. I will close this for now, but this issue will still be around if we need to revisit it later.


[WIP] Make '%A' structured formatting be the default for F# plaintext

This extends over #689 to make '%A' formatting by the standard for plaintext rendering for F#
Addresses much of #642
It's work in progress

@jonsequitur asked this

I haven't noticed in your PRs any explicit separation of F# from C# plain text formatting. Is it something you've run into yet? The tricky piece here is that since they're in process together and currently formatters are not language-specific, which is by design. But I think we need to decide when and where it's appropriate to differ.

Yes, this is actively on my mind, and I'm trying to make as many improvements as possible which are language-independent. However F# box-layout plaintext formatting is a good mechanism we need to integrate, and there is no equivalent for C# as yet.
We could possible look at incorporating an adapted version of that mechanism into .NET Interactive for C# as well.  But that's further down the line.
I think the order is

improve the common basis (what I'm doing now)

incorporate F#-specific box layout plaintext formatting (basically https://github.com/dotnet/interactive/pull/705)

make some improvements to  F#-specific box layout plaintext formatting in dotnet/fsharp

think about whether to duplicate/generalise the mechanism or something similar for C#

So if we need F# plaintext formatting to be different (e.g. "1L" not "1"), then I guess that means we're going to have to start scoping the formatting settings to a particular kernel.
Currently everything is, well, very global....
In general how do we feel about this kind of thing?  e.g. a polyglot programmer can today register a formatter in C# and have it implicitly picked up by F#?  It seems likely better to avoid building in "global leakage" across kernels simply because C# and F# happen to be implemented using the same DLLs...

I'm going to close this out for now
When I looked at this I didn't appreciate that the defaults weren't specific to each language.  I may salvage parts of this when I next take notebooks for a long spin from the F# perspective

I'm going to close this out for now
When I looked at this I didn't appreciate that the defaults weren't specific to each language.  I may salvage parts of this when I next take notebooks for a long spin from the F# perspective


How to test the model inference time?

@songhan Hi, When I want to use the benchmark.py script to test the inference speed, I encountered the following error:

or

Can you provide a completed script to test inference time? Thank you very much!

Hi @zyl1336110861,
We did not use the benchmark script to test the inference time. Instead, we manually insert timers into this file to calculate the runtime of different parts of our model and sum the results up to get the final latency. In this process, we ignore the voxelization time because we assume it to be a pipeline-able procedure and is very fast after the dynamic voxelization optimization proposed in MVF. The way to add a timer to one module is:
torch.cuda.synchronize()
st = time.time()

# run the module
x = module(x)

torch.cuda.synchronize()
ed = time.time()

And ed-st will be the time you want. For results reported in the paper, they are averaged across the entire validation set, because the runtime of SparseConv modules can vary for different samples.
Best,
Haotian

@kentang-mit Thanks for your patience. I just test the inference use the v1.0-mini dataset at a single RTX3090. The inference time is 230ms which is much slower than your paper. Maybe the  test data is small or the voxelization is slow.

Yes. The current voxelization implementation can take ~100ms. As I have mentioned, this procedure can be replaced with dynamic voxelization, and it can be pipelined (so there is no cost).

OK! Thank you very much!

 I'll close this issue temporarily, feel free to reopen if you have further questions.

This error may due to the wrong use of mmcv.Config.
I replace the Line27 as below and import necessary modules. Then I can run benchmark.py successfully.
...

from torchpack.utils.config import configs
from mmdet3d.utils import recursive_eval

...

configs.load(args.config, recursive=True)
cfg = Config(recursive_eval(configs), filename=args.config)

# set cudnn_benchmark
...


[hi] Localizing Case Studies Page

This is a Bug Report
It is seen that the Case Studies page is written in english we need to translate each and every components of case studies. As in other localization language like in  chinese we did

Problem:
Translate each and every components of Case studies in hindi
Proposed Solution:
Translate in simple hindi localization.
Page to Update:
https://kubernetes.io/hi/case-studies/

/language hi
/sig docs

/triage accepted

/priority backlog
IMO
Other work should come first.

/assign

@sftim Can be connected for this issue and @Adarsh-verma-14 are you still working on it .

@sftim Can be connected for this issue and @Adarsh-verma-14 are you still working on it .

I don't understand what you meant there @aryasoni98. Just so you know, I don't speak Hindi.

It looks like this request might already be covered by existing issue https://github.com/kubernetes/website/issues/43271, and maybe even https://github.com/kubernetes/website/issues/46085, which touches on similar aspects. This could potentially be a duplicate issue.

dipesh-rawat

Thank you for pointing that out, @dipesh-rawat. I'll take a closer look at issues #43271 and #46085 to see if they cover the same scope or overlap with this one. If this is indeed a duplicate, we can consolidate the efforts to avoid redundancy. I'll follow up after reviewing those issues.
Thanks again for the heads-up!


Update remaining deprecated links in docs

Most of the links in docs at this moment are correct HTTPS links.
This PR updates the remaining deprecated HTTP links with correct HTTPS links for consistency and security.

Thanks!


add temporalRangeStart/end & Ma

implement temporalRangeStart and temporalRangeEnd according to
https://github.com/Sp2000/colplus/issues/54 and https://github.com/Sp2000/coldp/issues/17
Create new GeoTime class and GeoUnit enumeration and a parser for GeoTime

Data wise we'll start with the 2017 ISC edition from GeoSciML which also contains many other language translations useful for parsing values.
Adding others on top of those could make sense to understand alternative concepts. Looking into that next, see  Sp2000/coldp#17

https://github.com/Sp2000/colplus-backend/commit/3e0c4ab0aa4abc96fd01229bfbac779137faa89e


Increasing the FontSize of AutoSuggestBox does not increase the size of the QueryIcon

Describe the bug
Increasing the font size of AutoSuggestBox increases the size of the Cancel (X) icon, however the QueryIcon size is not changed.

Steps to reproduce the bug
<AutoSuggestBox FontSize="32" QueryIcon="Find"/>

Expected behavior
QueryIcon should also scale up

Screenshots

Version Info

NuGet package version: Microsoft.UI.Xaml 2.5.0

Windows app type:

UWP
Win32

Windows 10 version
Saw the problem?

Insider Build (xxxxx)

May 2020 Update (19041)

November 2019 Update (18363)

May 2019 Update (18362)

October 2018 Update (17763)

April 2018 Update (17134)

Fall Creators Update (16299)

Creators Update (15063)

Device form factor
Saw the problem?

Desktop

Xbox

Surface Hub

IoT

Additional context

I think by design the system does not automatically scale icons in line with text sizes.
So adjusting the font sizes in system settings doesn't make all icons bigger.
You may need to adjust the lightweight style for the Glyph to match the font size you are changing

I think by design the system does not automatically scale icons in line with text sizes.
So adjusting the font sizes in system settings doesn't make all icons bigger.
You may need to adjust the lightweight style for the Glyph to match the font size you are changing

@mdtauk is correct, icons are usually not scaled with text scale changes but rather stay the same size (e.g. TabView or NavigationView exhibit the same behavior).

@mdtauk is correct, icons are usually not scaled with text scale changes but rather stay the same size (e.g. TabView or NavigationView exhibit the same behavior).

It is correct that by design icon's do not scale. So I think the issue here is that the x button scales with font size not that the search button doesn't.

It is correct that by design icon's do not scale. So I think the issue here is that the x button scales with font size not that the search button doesn't.

@StephenLPeters Bit of a context, I am developing application for kids and hence I would like to increase the font size. In my use case I would like the icon size to increase as it helps kids click the find button with ease.
If I take my use case for other controls like navigation button, I think for kids the icon size should increase. I think, it is more of accessibility issue, if you consider for kids and elderlies. I don't fully understand the reasoning behind not scaling the icons, yes the behaviour is consistent across the controls but in my opinion it is not the right call. For the elderlies and kids, for worst there should be a workaround and at best icons should scale up.

You may need to adjust the lightweight style for the Glyph to match the font size you are changing
@mdtauk Could you send me a link so that I can explore it.

Reducing the cross button is worse result considering my use case, because today I can opt to not show the icon and place a button with icon next to it (or try @mdtauk's suggestion) to achieve my objectives.

@StephenLPeters Bit of a context, I am developing application for kids and hence I would like to increase the font size. In my use case I would like the icon size to increase as it helps kids click the find button with ease.
If I take my use case for other controls like navigation button, I think for kids the icon size should increase. I think, it is more of accessibility issue, if you consider for kids and elderlies. I don't fully understand the reasoning behind not scaling the icons, yes the behaviour is consistent across the controls but in my opinion it is not the right call. For the elderlies and kids, for worst there should be a workaround and at best icons should scale up.

You may need to adjust the lightweight style for the Glyph to match the font size you are changing
@mdtauk Could you send me a link so that I can explore it.

Reducing the cross button is worse result considering my use case, because today I can opt to not show the icon and place a button with icon next to it (or try @mdtauk's suggestion) to achieve my objectives.

There are light weight styles you can override if you wish to increase the sizes of these things.
I don't believe the TextBox currently uses light weight style values for it's glyphs, which is probably an oversight that should be fixed @StephenLPeters
Would there be any issues with putting the UI you wish to resize in a ViewBox and scaling/zooming?

There are light weight styles you can override if you wish to increase the sizes of these things.
I don't believe the TextBox currently uses light weight style values for it's glyphs, which is probably an oversight that should be fixed @StephenLPeters
Would there be any issues with putting the UI you wish to resize in a ViewBox and scaling/zooming?

@harvinders I understand your concern, the issue that we frequently run into when Icon's do scale up is that Icon's are usually placed in locations with limited space.  There is a windows setting to increase font scaling across the system that frequently causes our font icon's to scale but past their bounding box size and get clipped (when we forget to disable text scaling on the font icon).  We do want to allow these things to be customizable though which is why we tie their size to a resource.  For your scenario here you can override the AutoSuggestBoxIconFontSize resource (at a page or more local scope) to adjust the query icon size.
I think that this template part should get its font size property set to a light weight style for consistency. @chingucoding interested in trying this out?

@harvinders I understand your concern, the issue that we frequently run into when Icon's do scale up is that Icon's are usually placed in locations with limited space.  There is a windows setting to increase font scaling across the system that frequently causes our font icon's to scale but past their bounding box size and get clipped (when we forget to disable text scaling on the font icon).  We do want to allow these things to be customizable though which is why we tie their size to a resource.  For your scenario here you can override the AutoSuggestBoxIconFontSize resource (at a page or more local scope) to adjust the query icon size.
I think that this template part should get its font size property set to a light weight style for consistency. @chingucoding interested in trying this out?

@StephenLPeters Thanks, that was helpful

@StephenLPeters Thanks, that was helpful

I think that this template part should get its font size property set to a light weight style for consistency. @chingucoding interested in trying this out?

Sure thing, PR's out.

I think that this template part should get its font size property set to a light weight style for consistency. @chingucoding interested in trying this out?

Sure thing, PR's out.


Add cache control for static assets

Context
One of the performance opportunities put forth by Google Lighthouse was to implement Cache-Control for static assets.
Once implemented, I can get a performance score of 100 (And hopefully better performance).
Current Behavior/Workaround
No cache control
Ideal behavior
Static assets all have a cache control policy.
Things to consider
My understanding is that cache control will allow clients to hold on to static assets (images, fonts, etc) instead of having to keep fetching them. One danger is that they might not get up-to-date static content after an update...but it looks like this can be mitigated by using hashing on all the assets.
If the hashes don't match, the client will ask for the resource again!
Resources:
https://www.youtube.com/watch?v=TgZnpp5wJWU
https://jakearchibald.com/2016/caching-best-practices/
https://www.youtube.com/watch?v=ZDftZcgEEZo
https://www.youtube.com/watch?v=usN-tbrQynA&list=PLrFzFX2lgkuy79RYoQHekuqnHDRrkUgXx&index=13
This is blocked by https://github.com/jsolly/blogthedata/issues/63

Might make sense to tackle this later. Cache is a HUGE topic and I want to make sure I am doing the most effective things first. See Django's doc on caching.
https://docs.djangoproject.com/en/dev/topics/cache/
Taking out of the active backlog

I am no longer getting docked by Google with this since CloudFlare sets all these things in the headers for me.


ProcessHacker v3 DisplayVersion should display the actual build version instead of 3.x

Description of the feature, modification, idea or suggestion
For example, what would display here should be 3.0.4953 instead of 3.x.

Proposed implementation details (optional)
No response

But why? You will have only one version installed anyway

Two different build versions are two different builds. Winget also gets the version info from here, so it would allow for Process Hacker v3 to be added in Winget; the other problem that would need to be resolved would be #759.

This is due to the display version here: https://github.com/winsiderss/systeminformer/blob/master/tools/CustomSetupTool/util.c#L53
This is likely to be resolved as we approach an official 3.x release. For the time being, for the nightly, this is unlikely to change. I'm unsure if the upgrade path handles changing the display version when we do change this to display the actual version that path will need to update too.

I'll wrap this into #759

Um, they aren't related?

@itsmeboy0
They'll both be addressed in the same commit.


docs: add tsconfig setup info to esbuild-plugin docs

What changed / motivation ?
This PR adds additional information on how to configure esbuild projects with TypeScript to properly run StyleX esbuild plugin. It also adds an extra test case for bundling TS files with esbuild plugin.
By default, esbuild TS compiler will drop any imports that are unused in the body of the importing module. esbuild traverses modules based on the entry module imports, meaning that dropped imports will never be visited by esbuild. This causes issues with defineVars, as the babel transformation will remove any references of the variables in the body of the module leading to uncompiled imported modules that are necessary to correctly bundle the CSS. esbuild TS compiler respects the tsconfig file, and the solution is to enable verbatimModuleSyntax compiler option.
Linked PR/Issues
Fixes #454
Pre-flight checklist

[x] I have read the contributing guidelines
Contribution Guidelines
[x] Performed a self-review of my code

Thanks for the quick fix to documentation, but could you instead setting treeshakeCompensation: true in the ESBuild plugin instead? That should fix this problem without needing an extra option for devs to configure.

@nmn will add. thanks for letting me know 👍

updated the PR


Sample Demo for VK_EXT_shader_object

It would be nice to have a full example for the VK_EXT_shader_object extension, which removes the need to create VkPipeline objects.
There already are nvidia beta drivers available which support this extension.

That'd be super usefull to have, +1

Thanks for your suggestion. We'll be doing a sample on this.

See #717

The sample has been merged.


Grid multi-select to select all records in dataset based onheaderCheckboxToggleAllPages attribute in @Grid

Description
Providing support for multi-select header checkbox to select all records in the dataset (including all pages in a paginated datatable) and also retain the individual record selection across pages.
Merging original PR for 1.2.x to 1.1.11
https://github.com/openanthem/nimbus-core/pull/322
Overview of Changes
Please see https://github.com/openanthem/nimbus-core/pull/322 for details
Type of Change

[ ] New feature
[ ] Documentation Update
[ ] This change requires a documentation update

N/A
Test Details
Additional Notes

You did it @swethavemuri-anthem!
Thank you for signing the Anthem Opensource Software CLA.


[WIP/RFC] Parallel Categories trace type for multi dimensional categorical data

@alexcjohnson @etpinard @monfera @chriddyp @jackparmer
Introduction
This PR is a proposal and an implementation of a new trace type for the interactive exploration of multi-dimensional categorical data sets.  My working name for the trace is "Parallel Categories" or parcats for short.
The concept of this trace has been discussed previously in the following plotly.js issues:

https://github.com/plotly/plotly.js/issues/2221#issuecomment-354560667
https://github.com/plotly/plotly.js/issues/2229

I also briefly showed a prototype of this diagram to @chriddyp over screenshare several months ago.
Related work
The closest prior art to the Parallel Categories Diagram is the Parallel Sets Diagram by Robert Kosara and Caroline Ziemkiewicz.
Parallel Sets implementations / descriptions
Here are a collection of existing implementations / descriptions of the Parallel Sets Diagram
Parallel Sets Java Program
https://eagereyes.org/parallel-sets
This is a stand-alone Java program by Kosara that implements a Parallel Sets Diagram

Parallel Sets from the DataViz catalog
https://datavizcatalogue.com/methods/parallel_sets.html

D3 implementation of Parallel Sets
https://www.jasondavies.com/parallel-sets/

What's different about the Parallel Categories Diagram?
The primary difference between this Parallel Categories Diagram (parcats from here on) and the Parallel Sets Diagram (parsets from each on) is that the parcats diagram supports a more flexible path coloring scheme.
In all of the examples of parsets diagrams that I have found, the colors of the paths correspond to states in the left-most (or top-most) dimension. In contrast, for the parcats diagram, color may correspond to a column in the dataset that may or may not be present as a dimensions in the diagram.
This, admittedly modest, extension has several advantages. Path colors may be set using a numeric array and a color map just like many other plotly.js trace types (scatter, parcoords, etc.).  This makes it possible to use the parcats diagram combined with other traces in brushing/crossfiltering configurations.
Dragging and Brushing example
Here is an example of visualizing a 5-dimensional data set with two continuous dimensions and 3 categorical dimensions.  This is accomplished by displaying the two continuous dimensions in a 2D scatter plot and the 3 categorical dimensions using the parcats diagram.
I created this example using a branch of plotly.py version 3 built against this branch of plotly.js.
First I show the drag interactions supported by the diagram. Categories (the rectangles) and dimensions labels (dimensions are the columns of rectangles) can be dragged to reorder categories and dimensions. Upon release, the diagram animates to a relaxed state with equal spacing between dimensions and categories.
Selection events in the scatter plot are use to update the colors of both the selected points in the scatter plot, and the corresponding paths in the parcats diagram.  Similarly, click events on categories and paths in the parcats diagram are used to update the colors in both diagrams.

As far as I'm aware, this is the only visualization of multi-dimensional categorical data that supports this kind of two-way data brushing. And, combined with plotly.py version 3, it is certainly the only visualization of this type that would be easily accessible to Python users.
Color bundling
There are two modes for how the colors of paths are arranged.
In the example above, color is not considered when sorting the paths. This is desirable in a brushing scenario so that the paths remain stable as the colors change during interactions. This behavior is specified by setting the bundlecolors property to false.
Setting the bundlecolors property to true causes paths with like colors to be bundled together as they pass through each category.  This results in a cleaner looking diagram and is preferable in cases where the positions of paths do not need to remain stable as colors change.
For example:

Mocks
Several simple mocks have been added as a part of the current test suite.
parcats_basic

parcats_bundled

parcats_unbundled

API notes
I tried to model the API as closely as possible after existing trace conventions. There is a top-level dimensions property with label and values sub-properties just as with the parcats trace. Path colors/colorscales are specified under a dimension.marker parent property.
Alternative approach
In the issues cited at the beginning of this PR there was some discussion on the possibility of adding categorical support to the existing Parallel Coordinates Diagram.  This diagram was already well under development for our internal needs at the time of these discussions, so I did not pursue this approach.
TODO
Some items that I know still need to be done

[ ] Font styling support
[ ] Complete attribute descriptions
[ ] Complete the test suite. In terms of my personal testing standards I'd estimate that the test suite is about 50% complete.
[ ] Examples!

Request for comments
So the top-level question for the plotly.js team is, are you all interested in having this diagram be part of plotly.js? It's not the most common use-case, but I think it would be another differentiating feature for the plotly ecosystem.
If you all are interested, I have internal funding to put a bunch more time into this through September. And if we can get it merged in during that time, I can continue helping out with basic maintenance after that.
Let me know what you think!

(Adding @nicolaskruchten as well!)

Thanks very much for the PR @jonmmease :tada: :rocket: :trophy:
Unfortunately, i'm a little backed up in my own TODO list, so I probably won't have time to look at your work until v1.40.0 is out in ~ 2 weeks time.

Omg! So cool :) ... more professional feedback on Monday ;)

Thanks @etpinard and @nicolaskruchten , I know reviewing a new trace type is no small task!

Very nice work @jonmmease! Looking at what you've got here, I'm happy to start this way (as a separate trace type). At some point we still may want to fold this into parcoords, as there would be significant value in being able to combine categorical and continuous dimensions side-by-side, but parcoords code is not so accessible and I wouldn't want that to constrain the features we can include here. Presumably in the meantime users can use the two trace types side-by-side with coupled selection, to get the same result with just a bit more manual plumbing.
I'll look at the code in a moment, but a few comments on the display and behavior:

Dragging: I think it'd be preferable to keep vertical and horizontal reordering distinct: dragging a category only moves it vertically, and only dragging the dimension label will reorder dimensions.
Sorting: we may need more than 3 dimensions to hit all cases, but in the existing mocks I see some clear opportunities to reduce crossings. This isn't a blocker but would be nice to take a look at what's possible. In parcats_bundled, B->11 and C->11 both have two blue paths that could stay adjacent, and the red 2->A->11 could be at the top of 2 and could be the highest red in 11. I guess these all fall into a class of optimizations based on pairs of adjacent dimensions, and perhaps a separate sort order per dimension? It also means the ordering could change as you reorder dimensions, and reorder categories within a dimension, which seems to happen just a little bit right now, but mostly these operations don't affect sorting.

This is really neat, and the cross-filtering example is very compelling. Even without the crossfiltering the standalone interaction in the GIF you posted looks really useful from an exploration perspective! +1 from me for inclusion into plotly.js in principle :) Would be great to see some examples in the documentation when it comes out for how to easily do parcoors+parcats in one plot with the filtering like you have here :)

Thanks for your thoughts and detailed feedback @alexcjohnson and @nicolaskruchten!  I'm super excited to work on  getting this in 🙂
I'll do a deep pass through your comments and push an update in a couple of days.

@nicolaskruchten Yeah. What I've found to work well from the Python side is to run continuous columns through pandas.cut first. This results in category names like (0.994, 3.0], (5.0, 7.0], etc.
This raises a really interesting question. What's the best way to discretize a continuous dimension so as to make this diagram as informative as possible?  To be informative, you want the observations in each interval to tend to behave similarly across the rest of the dimensions.  And you want adjacent intervals to tend to behave differently from each other.
One technique I've played around with works pretty well is Minimum Description Length Principle (MDLP) discretization. Paper: https://trs.jpl.nasa.gov/handle/2014/35171, a Python implementation: https://github.com/hlin117/mdlp-discretization.

I could see multiple binning modes:

N bins of equal size across the range containing variable number of rows
N bins of variable size containing the same number of rows
Enumerated bins with an automatic 'other' category
Various kinds of adaptive modes that depend on the other categories as well (much more complex to implement in JS and document!)

As a separate comment/question: could/do we support a vertical layout where the boxes are laid out horizontally?

@nicolaskruchten

Enumerated bins with an automatic 'other' category

What would the 'other' category mean in this case?

As a separate comment/question: could/do we support a vertical layout where the boxes are laid out horizontally?

To this point I've not put any thought/effort into supporting a vertical layout.  So I'm not sure what it would take to do so.  Do you have any use-cases in mind where you think this would be helpful?

could/do we support a vertical layout

Do you have any use-cases in mind where you think this would be helpful?

To me, vertical layout implies hierarchy - and it's interesting to think about using this chart type for hierarchical data, but it's not the main focus here. Lets keep it horizontal-only in the first iteration.

What would the 'other' category mean in this case?

If you enumerate bins and you have data that doesn't fit into any of the bins :)

To me, vertical layout implies hierarchy

I'm not sure the Titanic example implies hierarchy to me... What I like about a vertical layout is that the category boxes are horizontal so rendering long-ish category names will look good as they could live in or along the boxes and be readable without head-rotation :)

I'm not sure the Titanic example implies hierarchy to me...

Exactly, that example is not hierarchical but when it’s laid out vertically my instinct is to try and interpret it that way and look for patterns that aren’t there. Maybe I’m alone in that, but to me that makes vertical seem less appropriate. I see your point about label length though, and I’m not averse to eventually adding it.
For now I guess the only implication is if there are attribute names and values that imply an orientation (I haven’t looked) we should try to find alternatives that don’t.

One trouble with vertical orientation, though, is that only prominent categories can have long names. In the titanic dataset, for example, if there was only one observation in both "First Class" and "Third Class" then the labels would overlap (Unless you add the kind of label placement magic that the pie trace has!).
What I like about the horizontal orientation is that the max label length is determined by the number of dimensions and size of the plot, not the dataset itself. So as long as everything fits using your initial data set, future data sets will look good also.

shrug ok :)

I just added a mock that demonstrates the color hovermode (parcats_hovermode_color).
The basic idea here is that when you hover on a category, only the paths of a single color are highlighted. What's really useful about this is that the tooltip can then display the absolute probability of the paths of that color that pass through a given category. You can also display the conditional probabilities (Probability of blue given category A, probability of category A given blue).

Does hovermode of being an enumeration of none, category, or color seem like a reasonable way to specify this?

@alexcjohnson
Regarding dragging, I went ahead and added a sankey style arrangement property to control the dragging behavior. There are three modes (names taken from sankey.arrangement)

perpendicular (now the default): categories only drag vertically,
dimension labels drag horizontally.
freeform: category labels can drag vertically and horizontally
(in which case they pull the dimension along with them). Here
dragging a category can reorder the categories and dimensions.
fixed: dragging of dimensions and categories is disabled.

@alexcjohnson
I took a look back through the multi-label hover logic, and added a new 'dimension' hover mode to show it off. This hover mode will display a label for each category in the current dimension (See parcats_hovermode_dimension mock).

If you notice the hover label on B, you can see how the label is pushed downward to keep it from overlapping with the label for C.  It might be nice in some cases to also push labels upward to avoid collisions, but at the moment this only pushes things down.
Now that there are multiple hovermodes and configurable hoverinfo I do like this mode as an option.

Thanks again for looking this over @alexcjohnson , I think I've worked through all of the recommendation from your first pass.
Until you or @etpinard have a chance to take another look, I'm going to work on adding font configuration for the dimension and category labels.  Font configuration is the last new feature that I have in mind at this point (for the initial version). After that I'll be working on filling out the test suite and improving the attribute descriptions.

Font support for dimension labels (labelfont) and category labels (categorylabelfont). labelfont matches the corresponding property name in parcoords.

Superseded by https://github.com/plotly/plotly.js/pull/2963


Line endings

This file had a mixture of LF and CRLF line endings. This makes it consistent so it's not so intimidating for people to contribute to obsidian.d.ts in the future.
This PR adds a file that hopefully fixes this for everyone contributing to this repo.
Looks like this was recognized as an issue before
But the inconsistent line endings were added later

I have reformatted the file with uniform line endings.

So you would rather do that work yourself than simply merge my PR that has that fix AND a permanent fix to the problem? Do you need this issue to keep recurring for your GitHub contributions chart, or do you have a policy of never merging PRs from new people?

The definition file is automatically generated - your PR simply fix the file as it is, but it will get overwritten by the next run of the generator.

I want to note that I am not against PRs in general, nor anything against you or new contributors. Given the nature of the build system (it's unfortunately quite finnicky with formatting) it is impractical to manually edit the output file.

The fact that inconsistent line endings were ever introduced means that my 2nd file, which wouldn't be overridden if only the definitions file is regenerated, would have been useful, at least in the past. Either this repo is totally closed to new PRs, or that file would have been useful.
Why don't you mention in the README that this whole repo is closed to PRs? I wouldn't have just spent an hour on these 2 PRs.

Apologies this was an oversight - I have added a note here: https://github.com/obsidianmd/obsidian-api/blob/master/obsidian.d.ts#L2


New domains for generator.email service

https://generator.email/ and https://email-fake.com/ generate random emails, they don't list their domains so I build a script and scraped them for 3 days straight.
There are probably more domains, but after 3 days this is the (deduped) list I got: https://kopy.io/20LAz it's almost 15.000 domains.

Could you please merge this? :-)


Upgrading to 4.0.3 results in sass-loader on npm run build

Trying to upgrade to @nuxtjs/tailwind 4.0.3 as especially the JIT feature is attractive! Howver, I keep getting errors when trying to build (npm run build) the solution. It works perfectly fine when when doing an npm run dev.
Any ideas as to what I'm missing here?
Package.json looks like this:

and nuxt.config.js relevant sections:
 buildModules: [     '@nuxtjs/tailwindcss',      '@nuxt/postcss8'   ],
The error looks like this:

Any ideas?

@jhhosbond did you find a workaround?


HTTP_TUNNEL_RESPONSE OptionalFields Capability flags have a different type than the official protocol spec

I'm trying to build a similar application in C# for ASP.net and while examining the protocol specifications and your code i've stumbled across the following:
According to the protocol specification, the Capability Flags of the HTTP_TUNNEL_RESPONSE should have the type uint16, but in your implementation uint32 is used. Is this intentional? Since the HTTP_TUNNEL_PACKET does indeed have a uint32 for Capability flags according to the specifications.
https://github.com/bolkedebruin/rdpgw/blob/6b32631434cf918abf6ea8755689e52590535311/cmd/rdpgw/protocol/client.go#L155-L177

Nevermind, i got confused while digging through the specifications and mixed up the types of the FieldsPresent and capsFlags. Should probably take a break now 😄


Systemctl failed services

Hi,
this is the only message I've managed to receive
Server - debiangnulinux10: Systemctl failed services: ● systemd-modules-load.service loaded failed failed Load Kernel Modules vedi il file log nel server
Thanks for your support in advance.

Hi, the script send an alert when there are one or more failed services.
The problem is the systemd-modules-load.service that fails to start.
Try with sudo systemctl restart systemd-modules-load.service or read here


Possible rotation issue with cones

So using MESS and Animated Spell Effects, when I use the automated effect config menu the cone effects are always rotated 90 degrees compared to the template

You need to use the "correct" cone there.  All are now rotated correct (to my knowledge), but on a quick check the red one has 2 versions, one rotated "wrong", one rotated correctly


Namespace list table is not correctly displayed

Description
This is a regression from an unclear commit (not https://github.com/rancher/dashboard/issues/12007), not exactly Vue3.

@cnotv can you include screenshots of the expected behaviour and list the items that are broken? This is primarily for QA but it will also assist whoever picks this up.
It looks like the header buttons, the project's create namespace button + project actions button wrap expanding the group header and the focus background of the action button might be different?
Could be related to https://github.com/rancher/dashboard/pull/12109

Validated on Rancher version: v2.10-5d66d49d7a72b4c439a33043007e9bb0223c8693-head
UI: master cf8c6d1
This is now rendered properly on this rancher version. No errors in the browser console. This was also compared to the latest 2.9-head to check it was still consistent.


Add IntesisHome Climate Platform

Description:
This pull request adds support for the IntesisHome climate platform, which a number of users have been using since 2016.
Pull request in home-assistant.io with documentation: home-assistant/home-assistant.io#8917
Example entry for configuration.yaml (if applicable):
climate:
  - platform: intesishome
    username: username
    password: password

Checklist:

[X] The code change is tested and works locally.
[X] Local tests pass with tox. Your PR cannot be merged unless tests pass
[X] There is no commented out code in this PR.

If user exposed functionality or configuration variables are added/changed:

[X] Documentation added/updated in home-assistant.io

If the code communicates with devices, web services, or third-party tools:

[X] The manifest file has all fields filled out correctly (example).
[X] New dependencies have been added to requirements in the manifest (example).
[X] New or updated dependencies have been added to requirements_all.txt by running script/gen_requirements_all.py.
[X] New files were added to .coveragerc.

Seems a bit racy. And you force a delay of 2 seconds on startup. Can't you poll the connection for completion? Loop a sleep.
Updated now - thanks

This PR is blocked until #23899 has been merged.

https://developers.home-assistant.io/blog/2019/07/03/climate-cleanup.html

https://developers.home-assistant.io/blog/2019/07/03/climate-cleanup.html

Thanks, I'll work on getting compliant with this

Agh, closed while I updated it, but now I'll have to create a new PR.


Example scripts for rule dst and policy raise AssertionError

I ran the example script in RuleDST and RulePolicy and got AssersionErrors.
It's just because those scripts are outdated, and can I ignore them? Thanks!

Thanks! I've update the example script of RuleDST
For RulePolicy, could you provide the error message? I am not sure which example is broken.

Sorry, it was all in my head. RulePolicy works fine.


OSX Support

Assuming the UIKit dependency gets resolved, this should work as-is with OSX as well. Maybe some @availability stuff to prevent usage of anything iOS or OSX-specific on the alternate platform.

Interesting idea. Will look into it over the weekend! 😀

Just added in 2.0.1! Thanks for the suggestion :). Please reopen or open a new issue if it doesn't work.


watch detects incorrect file change

/kind bug

What versions of software are you using?
Operating System:
supported
Output of odo version:
master
How did you run odo exactly?
$ odo project create test123

$ oc --request-timeout 5m import-image nodejs --namespace=test123 --from=registry.access.redhat.com/rhscl/nodejs-10-rhel7:latest --confirm

$ oc annotate istag/nodejs:latest --namespace=test123 tags=builder --overwrite

$ odo create nodejs nodejs-app --project test123 --context tests/examples/source/nodejs/

$ odo push --context tests/examples/source/nodejs/

Create a shell script check.sh and put it in the context dir tests/examples/source/nodejs/
$ cat check.sh
#!/bin/sh

# fail if some commands fails
set -e
# show commands
set -x

touch {a..z}.txt

$ odo watch nodejs-app --context tests/examples/source/nodejs/

// open another terminal. Go to the context dir and run check.sh from there
$ ./check.sh

// The files are detected in the watch terminal

Update check.sh
$ cat check.sh
#!/bin/sh

# fail if some commands fails
set -e
# show commands
set -x

rm {a..z}.txt

And run check.sh

// It detects the check.sh instead of file changes

Actual behavior
Waiting for something to change in /Users/amit/go/src/github.com/openshift/odo/tests/examples/source/nodejs
File /Users/amit/go/src/github.com/openshift/odo/tests/examples/source/nodejs/check.sh changed

Expected behavior
Waiting for something to change in /Users/amit/go/src/github.com/openshift/odo/tests/examples/source/nodejs
File /Users/amit/go/src/github.com/openshift/odo/tests/examples/source/nodejs/check.sh changed
File /Users/amit/go/src/github.com/openshift/odo/tests/examples/source/nodejs/a.txt changed
[...]

Any logs, error output, etc?

ping @mik-dass

Create a shell script check.sh and put it in the context dir tests/examples/source/nodejs/
$ cat check.sh
Since the file is in the component directory, it will be watched and pushed as well. Or am I missing something?

Create a shell script check.sh and put it in the context dir tests/examples/source/nodejs/
$ cat check.sh
Since the file is in the component directory, it will be watched and pushed as well. Or am I missing something?

yes, i would suggest please go through how to reproduce in the issue description.

yes, i would suggest please go through how to reproduce in the issue description.

That's what I did. The line
Create a shell script check.sh and put it in the context dir tests/examples/source/nodejs/
$ cat check.sh
#!/bin/sh

seems to suggest that script file was added in the context component directory. Thus it's getting pushed.

Waiting for something to change in /home/mrinaldas/che-nodejs
File /home/mrinaldas/che-nodejs/run.sh changed
Pushing files...

Validation
 ✓  Validating the devfile [34894ns]

Creating Kubernetes resources for component nodejs
 ✓  Waiting for component to start [409ms]

Applying URL changes
 ✓  URLs are synced with the cluster, no changes are required.

Syncing to component nodejs
 ✓  Syncing files to the component [7s]

Executing devfile commands for component nodejs
 ✓  Executing install command "npm install" [3s]
 ✓  Executing run command "npm start" [8s]
Waiting for something to change in /home/mrinaldas/che-nodejs
File /home/mrinaldas/che-nodejs/a.txt changed
File /home/mrinaldas/che-nodejs/b.txt changed
File /home/mrinaldas/che-nodejs/c.txt changed
File /home/mrinaldas/che-nodejs/d.txt changed
File /home/mrinaldas/che-nodejs/e.txt changed
File /home/mrinaldas/che-nodejs/f.txt changed
File /home/mrinaldas/che-nodejs/g.txt changed
File /home/mrinaldas/che-nodejs/h.txt changed
File /home/mrinaldas/che-nodejs/i.txt changed
File /home/mrinaldas/che-nodejs/j.txt changed
File /home/mrinaldas/che-nodejs/k.txt changed
File /home/mrinaldas/che-nodejs/l.txt changed
File /home/mrinaldas/che-nodejs/m.txt changed
File /home/mrinaldas/che-nodejs/n.txt changed
File /home/mrinaldas/che-nodejs/o.txt changed
File /home/mrinaldas/che-nodejs/p.txt changed
File /home/mrinaldas/che-nodejs/q.txt changed
File /home/mrinaldas/che-nodejs/r.txt changed
File /home/mrinaldas/che-nodejs/s.txt changed
File /home/mrinaldas/che-nodejs/t.txt changed
File /home/mrinaldas/che-nodejs/u.txt changed
File /home/mrinaldas/che-nodejs/v.txt changed
File /home/mrinaldas/che-nodejs/w.txt changed
File /home/mrinaldas/che-nodejs/x.txt changed
File /home/mrinaldas/che-nodejs/y.txt changed
File /home/mrinaldas/che-nodejs/z.txt changed
Pushing files...

Validation
 ✓  Validating the devfile [136115ns]

Creating Kubernetes resources for component nodejs
 ✓  Waiting for component to start [402ms]

Applying URL changes
 ✓  URLs are synced with the cluster, no changes are required.

Syncing to component nodejs
 ✓  Syncing files to the component [8s]

Executing devfile commands for component nodejs
 ✓  Executing install command "npm install" [5s]
 ✓  Executing run command "npm start" [8s]
Waiting for something to change in /home/mrinaldas/che-nodejs
File /home/mrinaldas/che-nodejs/run.sh changed
Pushing files...

Validation
 ✓  Validating the devfile [61768ns]

Creating Kubernetes resources for component nodejs
 ✓  Waiting for component to start [614ms]

Applying URL changes
 ✓  URLs are synced with the cluster, no changes are required.

Syncing to component nodejs
 ✓  Syncing files to the component [8s]

Executing devfile commands for component nodejs
 ✓  Executing install command "npm install" [5s]
 ✓  Executing run command "npm start" [9s]
Waiting for something to change in /home/mrinaldas/che-nodejs
Pushing files...

Validation
 ✓  Validating the devfile [108168ns]

Creating Kubernetes resources for component nodejs
 ✓  Waiting for component to start [409ms]

Applying URL changes
 ✓  URLs are synced with the cluster, no changes are required.

Syncing to component nodejs
 ✓  Syncing files to the component [8s]

Executing devfile commands for component nodejs
 ✓  Executing install command "npm install" [4s]
 ✓  Executing run command "npm start" [6s]
Waiting for something to change in /home/mrinaldas/che-nodejs

It seems to work for me.

I could reproduce the issue only if I perform the actions immediately one after the other without much delays. Also the touch actions doesn't get detected then.

I could reproduce the issue only if I perform the actions immediately one after the other without much delays. Also the touch actions doesn't get detected then.

This makes the issue same as https://github.com/openshift/odo/issues/3307

the PR https://github.com/openshift/odo/pull/3890 resolves this issue


Added compass Documentation.md

Please check if the PR fulfills these requirements

[x] The commit message follows our guidelines
[ ] Tests for the changes have been added (for bug fixes / features)
[x] Docs have been added / updated (for bug fixes / features)

What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)

[ ] Bug fix
[x] Feature implementation
[x] Doc updates

Related Issue

What changes have you introduced?

Does this PR introduce a breaking change?

Preview / Steps to verify your work:

Sir, In google codein task they have said"PSLab Compass: How to find directions with your Phone and the PSLab app? Propose an Experiment - FOSSASIA"
Shall I make experiment with compass again?
Sir,in my md. file the screenshots are original and it's mine only?

pslab-Compass
PSLab Documentation and Experiments https://docs.pslab.io
EXPERIMENT TO CHECK THAT Ps-lab COMPASS DEFLECTS WHEN IT COMES IN CONTACT WITH MAGNET.

1.REQUIREMENTS:
Android phone with a) compass sensor and b) PSLab app installed,magnet and a compass.
1.STEPS:
STEP 1:
Take the magnet near to the compass.You will see that compass has deflecting.
STEP 2:
Take the magnet near to the Ps-lab Compass.You will see that, there is no delection in it.
3.RESULT:
Thus through this experiment it shows that Magnets do interact with the magnet inside a normal but that show no effect on the PSLab compass.
4.CONCLUSION:
By this Experiment we can understand that the PSLab compass uses GPS and other sensors to provide us directions and Do not uses any magnet to find directions. It further examine the GPS and Sensor readings and then using this data calibrate the compass needles according to our phones calibration and general position.

Ps-lab compass near the magnet

Ps-lab compass normal

As per your request, I have made a new project on the Ps-lab compass. Hope You would like it.Thank You

Please add this data to the compass.md file

Hi bhaiya . How will I do this?Actually i am a beginner

https://github.com/abhrakantidubey/pslab-documentation/blob/master/tutorials/compass.md

https://github.com/abhrakantidubey/pslab-documentation/blob/master/tutorials/compass.md

This is what is required ...please create a PR from this branch.

ok bhaiya let me try

bhaiya pls check it if I am not wrong https://github.com/fossasia/pslab-documentation/pull/59

Please close this pr


Import structure inventory shapefile when saving. Get rid of geopackage tables in the DB

This is completed. The structure shapefile (and others with same name) are imported into the study directory.
This is completed in inventory_xml_refactor branch


Using face-api instead of opencv

Hi,
Face detection with OpenCV is not good for some photos but face-api is working perfectly. Is it possible to use face-api for face detection in smatcrop-cli?

It should be possible, someone just need to implement it. I guess the tensor flow dependency can't be worse than opencv. ;)
I'll give it a shot once I find some time - unless someone else does it first. :)

Thank you, Gald to hear from you
On Sun, Jun 30, 2019 at 9:50 PM Jonas Wagner<EMAIL_ADDRESS>wrote:

It should be possible, someone just need to implement it. I guess the
tensor flow dependency can't be worse than opencv. ;)
I'll give it a shot once I find some time - unless someone else does it
first. :)
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/jwagner/smartcrop-cli/issues/22?email_source=notifications&email_token=AFBMNPCZW5A6IVAN5S35IU3P5DMMVA5CNFSM4HZNV4PKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODY4PIBA#issuecomment-507048964,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AFBMNPADIJQKNNEGJC4VKKLP5DMMVANCNFSM4HZNV4PA
.

--
Regards,
Filmy Today
Website: filmy.today


Avoid needless config passing

The config contract only allows accessing the whole config, not individual fields. This means a lot of unnecessary data is passed around, especially if the keyper set is large. Fix this by adding getters for individual fields.

done


Test harness

Closes #53.

Okay, I have this working on Linux and macOS! Current output:
$ cd crates/
$ cargo test
   Compiling proc-macro2 v1.0.52
   Compiling unicode-ident v1.0.8
   Compiling quote v1.0.26
   Compiling syn v1.0.109
   Compiling ufmt-write v0.1.0
   Compiling flipperzero-rt v0.7.2 (/path/to/flipperzero/crates/rt)
   Compiling ufmt-macros v0.3.0
   Compiling flipperzero-test-macros v0.1.0 (/path/to/flipperzero/crates/test/macros)
   Compiling ufmt v0.2.0
   Compiling flipperzero-sys v0.7.2 (/path/to/flipperzero/crates/sys)
   Compiling flipperzero-test v0.1.0 (/path/to/flipperzero/crates/test)
   Compiling flipperzero-alloc v0.7.2 (/path/to/flipperzero/crates/alloc)
   Compiling flipperzero v0.7.2 (/path/to/flipperzero/crates/flipperzero)
    Finished test [optimized + debuginfo] target(s) in 4.73s
     Running unittests src/lib.rs (target/thumbv7em-none-eabihf/debug/deps/flipperzero-ec498257ef00abdb)

running 3 tests
test dolphin::tests::stats ... ok
test furi::message_queue::tests::capacity ... ok
test furi::sync::tests::unshared_mutex_does_not_block ... ok

test result: ok. 3 passed; 0 failed; 0 ignored; 0 measured; 0 filtered out; finished in 2ms
leaked: 88 bytes

$ # Unplug Flipper Zero
$ cargo test
    Finished test [optimized + debuginfo] target(s) in 0.01s
     Running unittests src/lib.rs (target/thumbv7em-none-eabihf/debug/deps/flipperzero-ec498257ef00abdb)
Error: unable to find Flipper Zero
error: test failed, to rerun pass `-p flipperzero --lib`

Caused by:
  process didn't exit successfully: `/path/to/flipperzero/crates/../tools/cargo-runner.sh /path/to/flipperzero/crates/target/thumbv7em-none-eabihf/debug/deps/flipperzero-ec498257ef00abdb` (exit status: 1)

And if I manually cause some tests to fail:
$ cargo test
   Compiling flipperzero v0.7.2 (/path/to/flipperzero/crates/flipperzero)
    Finished test [optimized + debuginfo] target(s) in 0.28s
     Running unittests src/lib.rs (target/thumbv7em-none-eabihf/debug/deps/flipperzero-ad4e99e6ec932a9a)

running 3 tests
test dolphin::tests::stats ... ok
test furi::message_queue::tests::capacity ... FAILED

---- furi::message_queue::tests::capacity stdout ----
assertion failed: queue.len() == 1

test furi::sync::tests::unshared_mutex_does_not_block ... FAILED

---- furi::sync::tests::unshared_mutex_does_not_block stdout ----
assertion failed: * value == 6

test result: FAILED. 1 passed; 2 failed; 0 ignored; 0 measured; 0 filtered out; finished in 5ms
leaked: 88 bytes

Currently the test failures are printed in-line, to avoid requiring alloc.

I've adjusted the test harness so it now also works for integration tests, and to allow the manifest arguments to be set (in particular, while adding more tests in subsequent local changes I need to bump the stack size).
There are probably more usability tweaks that could be made, but I think we'll discover those as the test harness is used, so I'm not planning to make any more changes to this PR other than in response to review.

Rebased on main to fix merge conflict with #59.

Force-pushed to replace cargo-runner.sh with cargo-runner.py. I've tested that this PR still works on Ubuntu and macOS; it should now also work on Windows (untested, but Windows can execute *.py files directly if their extension is associated correctly

@str4d It looks like the runner might be causing problems for GitHub Actions. Can you take a look?

it should now also work on Windows (untested, but Windows can execute *.py files directly if their extension is associated correctly).

Looks like runner must be an application, not just an associated file type:
PS> ./cargo-runner.py
usage: cargo-runner.py [-h] binary ...
cargo-runner.py: error: the following arguments are required: binary, arguments
PS> cargo test
    Finished test [optimized + debuginfo] target(s) in 0.03s
     Running unittests src\lib.rs (target\thumbv7em-none-eabihf\debug\deps\flipperzero-b5d0b378c3208e7a)
error: test failed, to rerun pass `-p flipperzero --lib`

Caused by:
  could not execute process `C:\Users\dcoles\workspace\flipperzero-rs\crates\./cargo-runner.py C:\Users\dcoles\workspace\flipperzero-rs\crates\target\thumbv7em-none-eabihf\debug\deps\flipperzero-b5d0b378c3208e7a` (never executed)

Caused by:
  %1 is not a valid Win32 application. (os error 193)

In this case, maybe we just go with the shell script and make this work for Windows in a future PR.

it should now also work on Windows (untested, but Windows can execute *.py files directly if their extension is associated correctly).

Looks like runner must be an application, not just an associated file type:

I've now found https://github.com/rust-lang/cargo/issues/8347 which indicates we just need to set the runner to python path/to/script.py. I'll update the PR to do that, and then you can retest on Windows.

@str4d It looks like the runner might be causing problems for GitHub Actions. Can you take a look?

I think what's going on here is that CI was configured to run all tests, but nothing had tests enabled so it did nothing. Now that we enable tests, CI tries to run them, but because the .cargo/config sets the default target to be not the host, they fail. I think the solution is to just not run any tests in CI, as there are no useful tests to be run outside the Flipper Zero.

Force-pushed to add missing package to CI, and hopefully fix cargo test on Windows.

Okay, confirmed that CI fails now because it can't find a Flipper Zero. I'll adjust CI to expect that failure, so we're still compiling everything and checking the runner.

I've now found https://github.com/rust-lang/cargo/issues/8347 which indicates we just need to set the runner to python path/to/script.py. I'll update the PR to do that, and then you can retest on Windows.

Looks like I hit python/cpython#99185 (Windows does not provide a python3.exe), which is totally dumb and bites me all the time. It would be possible to make the script compatible with both Python 2 and 3, but on my Ubuntu box there is no python binary unless I install the python-is-python3 package.
PEP-397 tries to resolve this situation by introducing a py.exe that can interpret the shbang line, but this isn't available on Ubuntu (not to be confused with pythonpy).
Not sure if there's an easy fix. There doesn't seem to be a cfg(host_os = "windows") and I can't figure out a way to get cmd.exe and bash to accept the same runner line.

Hmm. Now that I know we can have arguments inside runner, I wonder if we can just call cargo directly instead of using a wrapper script? The purpose of the script was to encapsulate the numerous arguments, but we also know that cargo should be available on the PATH. I'll give this a go.

The purpose of the script was to both encapsulate the numerous arguments and enable changing working directory so that the .cargo/config won't apply. If the latter can be worked around, then this might work.

I cannot figure out how to work around the latter inside target.<target>.runner without adding a cd ... &&, which is not cross-platform. However, reading a bunch of issues (around trying to unset build.target (https://github.com/rust-lang/cargo/issues/8112) or reset it to the host (https://github.com/rust-lang/cargo/issues/8687)) led me to discover per-package-target, which seems like it would also resolve the issue. We would set each of the crates under crates/ to have a package.forced-target, and then remove the build.target from crates/.cargo/config.toml. This would mean that calling cargo run --manifest-path ../tools/Cargo.toml from inside crates/ would then compile for the host instead of the Flipper Zero. However, it would block #58 on another unstable feature.

Sadly per-package-target doesn't work, because even though forced-target correctly causes the test binary to be compiled for the Flipper Zero, it doesn't cause the corresponding per-target runner to be used (so instead the binary runs directly on the host). I've asked about this in the tracking issue (https://github.com/rust-lang/cargo/issues/9406#issuecomment-1493318519).
However, I've figured out another solution: aliases! We remove the build.target (so by default we build for the host), and then add aliases that set the correct --target. I've pushed a commit that does this, providing *-flipper aliases for check, build, and test (happy to rename to something else / shorter if preferred). This does interfere with muscle memory though (so it's a trade-off between "need to remember separate commands" with this commit, and "need to make custom changes to my OS environment to get Python working" before), and it means that e.g. the rust-analyzer plugin for VSCode needs to be configured to use the correct target (I can commit that if you want).

@dcoles is there anything else I need to do before this can be merged? I'd love to get back on with my other PRs like #50 that are blocked on testing.

Over the weekend I got to see how a few other projects tackle this. Ferrus Systems has a tool called probe-run that can be used as a runner for a number of embedded platforms (though probably not compatible with Flipper apps). You can use the hf2-cli in a similar way via hf2 elf.

Yeah, those were what made me realize we could run tests and apps in this way. But we can't use any of the existing ones because they flash firmware, and I wanted this to be as easy to use as possible, so no need to install anything ideally. Didn't quite get there on all platforms, and if we end up having an installable FAP runner then I don't mind.

The other thing is that an installable FAP runner will be much nicer once upstream has implement proper RPC support for FAPs, so we don't have to do the hacky "write stdout to a file and then copy it off afterwards" that really is only suitable for one-shot FAPs.

The other thing is that an installable FAP runner will be much nicer once upstream has implement proper RPC support for FAPs, so we don't have to do the hacky "write stdout to a file and then copy it off afterwards" that really is only suitable for one-shot FAPs.

I'm very much looking forward to that. It's bit awful what you have to do when trying to use a serial CLI as a file transfer layer.


🐛 Bug Report: Reverse Proxy with Traefik limits uploads to 1 GB

👟 Reproduction steps
When I reverse proxy with Traefik, I get 1GB limitation on uploads
👍 Expected behavior
Should be limited by avaible space on mounted disk
👎 Actual Behavior
I get a warning that it can only handle 1GB files
🌐 Browser
Firefox

This isn't really related to Pingvin Share but Traefik. I don't use Traefik so you have to find a solution by your self :/ Just google something like "traefik increase body size".

It doesn't seem to be Traefik limit it.
For test I've put traefik limiting to 2 MB, and as expected bigger than 2mb will throw a 413 - Request too large.
But the website still advertises that files should not be any larger than 1GB

Is this a configurable parameter somewhere, or where does this value come from?

I've been browsing your code and it seems this value is obtain from
config.get("share.maxSize")
But I'm failing to understand where this value comes from, perhaps you could enlighten me a bit?
I would love to create a pull request where I make this configurable but I just need to understand how these configs work

Oh, okay. You can this on the admin page:
http://<your-domain>/admin/config/general

But there's no field on the page for this config

It's at the shares tab.
http://your-domain/admin/config/share

My deepest apologies, have noticed it there.


[BUG] 使用Zero3进行qwen72B 全参数训练报错

是否已有关于该错误的issue或讨论？ | Is there an existing issue / discussion for this?

[X] 我已经搜索过已有的issues和讨论 | I have searched the existing issues / discussions

该问题是否在FAQ中有解答？ | Is there an existing answer for this in FAQ?

[X] 我已经搜索过FAQ | I have searched FAQ

当前行为 | Current Behavior
在使用zero3进行全参数的qwen72Bsft时报错
Traceback (most recent call last):
  File "/code/xx/LLM_mine/llm-train/function_call/script/train_qwen/train.py", line 511, in <module>
    train()
  File "/code/xx/LLM_mine/llm-train/function_call/script/train_qwen/train.py", line 444, in train
    model = transformers.AutoModelForCausalLM.from_pretrained(
  File "/opt/conda/lib/python3.10/site-packages/transformers/models/auto/auto_factory.py", line 511, in from_pretrained
    return model_class.from_pretrained(
  File "/opt/conda/lib/python3.10/site-packages/transformers/modeling_utils.py", line 2875, in from_pretrained
    with ContextManagers(init_contexts):
  File "/opt/conda/lib/python3.10/site-packages/transformers/utils/generic.py", line 406, in __exit__
    self.stack.__exit__(*args, **kwargs)
  File "/opt/conda/lib/python3.10/contextlib.py", line 576, in __exit__
    raise exc_details[1]
  File "/opt/conda/lib/python3.10/contextlib.py", line 561, in __exit__
    if cb(*exc_details):
  File "/opt/conda/lib/python3.10/site-packages/deepspeed/runtime/zero/partition_parameters.py", line 447, in __exit__
    self.remove_wrappers()
  File "/opt/conda/lib/python3.10/site-packages/deepspeed/runtime/zero/partition_parameters.py", line 511, in remove_wrappers
Traceback (most recent call last):
  File "/code/xx/LLM_mine/llm-train/function_call/script/train_qwen/train.py", line 511, in <module>
    raise RuntimeError(msg)
RuntimeError: `<class 'flash_attn.layers.rotary.RotaryEmbedding'>' was not properly set up for sharding by zero.Init(). A subclass of torch.nn.Module must be defined before zero.Init() where an instance of the class is created.

在同样的环境下使用zero2进行7B的sft则不会报错
请教一下这个应该如何解决？
期望行为 | Expected Behavior
No response
复现方法 | Steps To Reproduce
No response
运行环境 | Environment
- OS: Ubuntu
- Python: 3.10
- Transformers: 4.32.0
- PyTorch: 2.0.0
- CUDA (`python -c 'import torch; print(torch.version.cuda)'`): 11.7
- Flash-attention: 2.5.0

备注 | Anything else?
No response

用的哪份代码？

用的哪份代码？

用的finetune.py，不过这个问题好像不是代码的问题，我把deepspeed版本升级以后就好了😅


MODELIX-458 Using generated enums leads to IllegalArgumentException

https://issues.modelix.org/issue/MODELIX-458

:tada: This PR is included in version 2.9.0 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


Low mAP on custom dataset

Hi,
I'm trying to fineture retinanet for a custom dataset. I have around 5000 annotated images.
I'm using a single GTX 1080ti with a batch size of 5.
Here is my mAP score after 50000 iterations.
Average Precision  (AP) @[ IoU=0.50:0.95 | area=   all | maxDets=100 ] = 0.00224
Average Precision  (AP) @[ IoU=0.50      | area=   all | maxDets=100 ] = 0.00437
Average Precision  (AP) @[ IoU=0.75      | area=   all | maxDets=100 ] = 0.00207
Average Precision  (AP) @[ IoU=0.50:0.95 | area= small | maxDets=100 ] = -1.00000
Average Precision  (AP) @[ IoU=0.50:0.95 | area=medium | maxDets=100 ] = 0.00126
Average Precision  (AP) @[ IoU=0.50:0.95 | area= large | maxDets=100 ] = 0.00276
Average Recall     (AR) @[ IoU=0.50:0.95 | area=   all | maxDets=  1 ] = 0.01714
Average Recall     (AR) @[ IoU=0.50:0.95 | area=   all | maxDets= 10 ] = 0.01969
Average Recall     (AR) @[ IoU=0.50:0.95 | area=   all | maxDets=100 ] = 0.01969
Average Recall     (AR) @[ IoU=0.50:0.95 | area= small | maxDets=100 ] = -1.00000
Average Recall     (AR) @[ IoU=0.50:0.95 | area=medium | maxDets=100 ] = 0.01031
Average Recall     (AR) @[ IoU=0.50:0.95 | area= large | maxDets=100 ] = 0.02279
I've been trying different backbones, learning rates, warmup steps etc. But the mAP score is not improving. Any suggestions?

Never mind. Was an issue with the dataset. Working well now.

I have the same problem. Can you share what issue you found in your dataset?


Draft gravity point spherical kernel

Draft gravity point spherical kernel
Working progress..

Relevant issues/PRs:

Plan to go back to this... Just noticed that https://github.com/fatiando/choclo/pull/58 will Restore kernels for point source. Will we do the same for spherical kernel? With one file include forward calculation and the other only do the kernel?

Hey @LL-Geo don't know if this was covered in a call but @santisoler brought this up in our lab meeting and I think it's not worth the effort of adding them now. If they're ever needed later, it will be easier to add them than to take them out if we find that they're not needed.

Also, really looking forward to these! I'll need to start implementing spherical gravity and magnetic equivalent sources in the near future 😉


[+] Template: BudgE, Duplicati, Jellyfin, phpMyAdmin, Vaultwarden, Whoogle and FileBrowser

🆕 New Templates:
-> ℹ BudgE: BudgE is an open-source 'budgeting with envelopes' personal finance app, helping you manage your finances effectively.
-> ℹ Duplicati: Duplicati is an open-source backup solution, allowing you to safeguard your data with ease through scheduled backups and encryption.
-> ℹ Jellyfin: Jellyfin is an open-source media server for hosting and streaming your media collection, providing an alternative to proprietary media platforms.
-> ℹ phpMyAdmin: phpMyAdmin is a web-based database management tool for administering your MySQL and MariaDB databases through a user-friendly interface.
-> ℹ Vaultwarden: Vaultwarden is an open-source password manager that allows you to securely store and manage your passwords, helping you stay organized and protected.
-> ℹ Whoogle: Whoogle is a self-hosted, privacy-focused search engine front-end for accessing Google search results without tracking and data collection.
-> ℹ FileBrowser: FileBrowser is a self-hosted, web-based file manager and file explorer with a user-friendly interface. It allows you to manage and organize your files and directories directly from your web browser.

Thank you!


nitpick: delete docker-tests.sh and just update pytests.ini

docker-tests.sh is only being used to store options which is done more conventionally by pytests.ini, which we already have. I think it'd be nice to move those options to the pytest.ini file in the name of centralizing all the pytest options to one place.

Sounds good

Fixed in https://github.com/opensyllabus/osp-pipeline/commit/1724a936dc18a4602a3c0bd44f4f7f5ead05d523


Update README.adoc

SolrRDD is an abstract class and cannot be instanciated. I updated README.adoc accordingly.

Looks good. Thanks!


[Content]: Klaviyo server side track properties mapping is missing

What article on segment.com/docs is affected?
https://segment.com/docs/connections/destinations/catalog/klaviyo/#server-side-track
What part(s) of the article would you like to see updated?
It looks like it's missing the properties after the line:
We will also map the following Segment spec’d properties to Klaviyo’s [special people properties](http://www.klaviyo.com/docs):
Additional information

Closing this one, as Segment is deprecating the Klaviyo destination at the end of the month.


docs: add examples for removing headers

What does this PR do?

Motivation

More

[ ] Added/updated tests
[x] Added/updated documentation

Additional Notes

Hello @SuperSandro2000, do you think that you could rebase this PR off of the 2.4 branch? Thanks!

Hello @SuperSandro2000, do you think that you could rebase this PR off of the 2.4 branch? Thanks!

Sure. I also changed the base branch to v2.4.

We have an issue with Travis, I will close then reopen the PR


ResetModel event

Question
I want to detect changes in every field and change its styling accordingly.
How do I know that form is in Reset mode when I have a notification in changeEvent? It got fired even if old value equals to a new value.

You should rely on formControl.valueChanges and check when the value is null or underfined:
{
  ...
  hooks: {
    onInit: (field) => field.formControl.valueChanges.pipe(tap(
      (value) => { ... },
    )),
  },
},

Another solution is to use expressionProperties.
To apply that for all fields you may consider using a custom extension  https://main.formly.dev/guide/custom-formly-extension

It does not work unfortunately if I do
this.options.resetModel?.(this.lastmodel);
Every field gets new value through fromControl event, but it is impossible to know if it is a "new default" or just another change during normal mode.
I had to introduce a Subject in form state this.options.formState!.resetState = new Subject<void>(); and then fire this event when user does "Submit" and listen to this event in every field (thx extensions) so it would know that current value of the field is a "new default".


Upgrade failure because of webhook certificate expired

We have observed an issue during upgrade. In case we use more than 1 replicas of spire-server pod that includes spire-controller-manager container besides spire-server and the deployment runs for more than 24 hours, the helm upgrade fails when it tries to patch the ClusterSPIFFEID custom resource:
[2024-11-27T17:00:26.181Z] Error: UPGRADE FAILED: cannot patch "spire-controller-manager" with kind ClusterSPIFFEID: Internal error occurred: failed calling webhook "spire-controller-manager-webhook-service.spire.svc": failed to call webhook: Post "https://spire-controller-manager-webhook-service.spire.svc:443/validate-spire-spiffe-io-v1alpha1-clusterspiffeid?timeout=10s": tls: failed to verify certificate: x509: certificate has expired or is not yet valid: current time 2024-11-27T17:00:25Z is after 2024-11-26T17:38:17Z

After some investigation I managed to reproduce the issue manually too.
I changed the x509SVIDTTL in the code to 10 minutes to be able to test it faster, then just created a ClusterSPIFFEID when the deployment was in idle status for a while.
I also added a printout in the log that shows when the webhook certificate was rotated and the expiration timestamp.
On the active spire-controller-manager the SVID is rotated properly, but on the standby it remains which was minted at initialization phase. It would not be a problem by default, but somehow during operation the standby spire-controller-manager's webhook gets requests, like my commands but the certificate has expired. It turned out from the printout that the certificate in question is the standby spire-controller-manager's (see the below expiration timestamp).
Rotated at: 2024-12-02 10:14:28.780845864 +0000 UTC m=+0.026239026
Expires at: 2024-12-02 10:24:28 +0000 UTC

$ kubectl apply -f clusterspiffeid-patch.yaml
Error from server (InternalError): error when creating "clusterspiffeid-patch.yaml": Internal error occurred: failed calling webhook "vclusterspiffeid.kb.io": failed to call webhook: Post "https://spire-controller-manager-webhook-service.spire.svc:443/validate-spire-spiffe-io-v1alpha1-clusterspiffeid?timeout=10s": tls: failed to verify certificate: x509: certificate has expired or is not yet valid: current time 2024-12-02T10:46:28Z is after 2024-12-02T10:24:28Z

$ kubectl apply -f clusterspiffeid-patch.yaml
Error from server (InternalError): error when creating "clusterspiffeid-patch.yaml": Internal error occurred: failed calling webhook "vclusterspiffeid.kb.io": failed to call webhook: Post "https://spire-controller-manager-webhook-service.spire.svc:443/validate-spire-spiffe-io-v1alpha1-clusterspiffeid?timeout=10s": tls: failed to verify certificate: x509: certificate has expired or is not yet valid: current time 2024-12-02T10:46:38Z is after 2024-12-02T10:24:28Z

In this case the third attempt was successful, sometimes the second is successful.
Below you can see that there are TLS handshake errors in the log of the standby spire-controller-manager the same time when the reproduction succeeded.
...
2024-12-02T10:14:28Z	INFO	controller-runtime.builder	Registering a validating webhook	{"GVK": "spire.spiffe.io/v1alpha1, Kind=ClusterSPIFFEID", "path": "/validate-spire-spiffe-io-v1alpha1-clusterspiffeid"}
2024-12-02T10:14:28Z	INFO	controller-runtime.webhook	Registering webhook	{"path": "/validate-spire-spiffe-io-v1alpha1-clusterspiffeid"}
2024-12-02T10:14:28Z	INFO	setup	starting manager
2024-12-02T10:14:28Z	INFO	controller-runtime.metrics	Starting metrics server
2024-12-02T10:14:28Z	INFO	starting server	{"name": "health probe", "addr": "[::]:8083"}
2024-12-02T10:14:28Z	INFO	controller-runtime.metrics	Serving metrics server	{"bindAddress": ":8080", "secure": false}
2024-12-02T10:14:28Z	INFO	controller-runtime.webhook	Starting webhook server
2024-12-02T10:14:28Z	INFO	controller-runtime.certwatcher	Updated current TLS certificate
2024-12-02T10:14:28Z	INFO	controller-runtime.webhook	Serving webhook server	{"host": "", "port": 9443}
2024-12-02T10:14:28Z	INFO	controller-runtime.certwatcher	Starting certificate watcher
I1202 10:14:28.884132      67 leaderelection.go:254] attempting to acquire leader lease spire/98c9c988.spiffe.io...
2024/12/02 10:46:28 http: TLS handshake error from <IP_ADDRESS>:64383: remote error: tls: bad certificate
2024/12/02 10:46:38 http: TLS handshake error from <IP_ADDRESS>:61149: remote error: tls: bad certificate

If I continuously sent requests then I haven't managed to reproduce the issue, but when I wait some time then repeat the same command it throws the error. I reproduced it with v0.6.0 and the latest version too.
Right now we use a workaround that before upgrading (within a day) we restart the spire-controller-manager container that will mint a new certificate for the webhook and the upgrade succeeds.
Do you have any idea how it could be fixed permanently?

I have experienced same issue when upgrading spire deployment through argoCD.
The cluster spiffe id pops up a sync error:

Background:
I have 3 replicas of spire server that running as statefulset.
The spire controller manager (v0.6.0) is running in the same pod as spire server.
The workaround in my case is to re-create the cluster spiffe id resource through argoCD.

Hi @yongdu,
Thanks for sharing your experience. The workaround you mentioned is also valid, but in our case it is not a way forward because the custom resource is created and handled by helm.

Are you using the https://github.com/spiffe/helm-charts-hardened chart or a different one?

A different one, an integration chart.

Have a look at the hardened chart then. It has some stuff in place to disable enforcement during the upgrade and then reenable it at the end.

Please assign this to me. I'd like to investigate the webhook issues further.

Looked into this today. I think this problem is caused by this block of code: https://github.com/spiffe/spire-controller-manager/blob/8481a0c0f2392ebdc934320704348678b2eb65f7/cmd/main.go#L435-L440
We are adding the webhookmanager to run under the controller runtime manager. If its not elected leader the controller runtime manager won't start the webhookmanager.
Simple fix is the run the webhookmanager not tied to controller runtime.


Key binding to show/hide log

It used to be possible to bind a key to show/hide the log, which I used very frequently. I don't remember if it was actually for the log specifically or for showing/hiding the entire global area. Whatever the case, after the recent sidebar changes (which are great btw!) it seems like there's no longer such a key binding. Would be nice to be able to do this again.

And just to be clear, Focus Log doesn't quite fulfill this need since it can't hide the log.

Hm, I actually have a similar ask for the types view, now that it's possible to put it on the right sidebar.
So maybe this ask could just generally extend to having a show/hide key bindings for every widget?

Added "Toggle" actions for any sidebar widget to replace the old actions in 4.0.4855.


RxReprint retry doesn't retry correct number of times

I found that if I use RxReprint.authenticate().retry(RxReprint.retryNonFatal(5)), onError() will usually be called on the 6th failure (but not always). Changing that to  RxReprint.authenticate().retry(RxReprint.retryNonFatal(2)) results in the same behavior, as does RxReprint.authenticate().retry(RxReprint.retryNonFatal(1)).
What I'm trying to go if give the user 3 tries, and tell the user on the 2nd try that if they do not succeed they will be logged out.

So retryNonFatal was behaving as intended, but the docs were poorly written. I've updated them to make it clear that the parameter only applies to timeout failures, which is typically the only fatal reason you'd want to restart for.
I also added RxReprint.retryLimitedAuthFailures that will help out with what you're trying to do. Keep in mind that there are a lot of failure reasons that will prevent you from restarting the sensor. The system can lock the sensor whenever it wants if it thinks you've had too many incorrect authentication attempts, which is why you onError can get called sooner than you'd like.