License scan issues from lf.ai

From https://lfscanning.org/reports/lfai/nnstreamer-2020-09-01-3d17e6bd-9a6c-4f43-8823-4ca171eb976f.html ...

Finding #7
Priority: High
I understand that LGPL-2.1 is the NNStreamer project's main license. Was it intentional for these other related projects to be under Apache-2.0?

NNTrainer is under Apache-2.0 license.

Finding #10
Priority: Low
The SPDX license identifier for these files is incorrect. The -only prefix is only used for the GPL family of licenses. If these are under Apache-2.0, this identifier for these files should read:SPDX-License-Identifier: Apache-2.0

A patch will be made

:octocat: cibot: Thank you for posting issue #598. The person in charge will reply soon.


Javascript error when using lookbook in a gem

I'm using lookbook in an admin gem that have a Rails engine. In dev environment, I use combustion.
Lookbook seems to works correctly but I noticed that when I open my browser dev tool, I've got the following errors:
Uncaught
Exception { name: "NS_ERROR_FAILURE", message: "", result:<PHONE_NUMBER>, filename: "http://localhost:5000/assets/madmin/application.debug-f4b00a…506709e018153472c1654fac6ebe8ef52c9131170148aae16953f89a7.js", lineNumber: 6576, columnNumber: 0, data: null, stack: "update@http://localhost:5000/assets/madmin/application.debug-f4b00af506709e018153472c1654fac6ebe8ef52c9131170148aae16953f89a7.js:6576:14\nreplace@http://localhost:5000/assets/madmin/application.debug-f4b00af506709e018153472c1654fac6ebe8ef52c9131170148aae16953f89a7.js:6572:12\nstart@http://localhost:5000/assets/madmin/application.debug-f4b00af506709e018153472c1654fac6ebe8ef52c9131170148aae16953f89a7.js:6558:14\nstart@http://localhost:5000/assets/madmin/application.debug-f4b00af506709e018153472c1654fac6ebe8ef52c9131170148aae16953f89a7.js:7145:22\nstart@http://localhost:5000/assets/madmin/application.debug-f4b00af506709e018153472c1654fac6ebe8ef52c9131170148aae16953f89a7.js:7386:13\n@http://localhost:5000/assets/madmin/application.debug-f4b00af506709e018153472c1654fac6ebe8ef52c9131170148aae16953f89a7.js:7921:3\n@http://localhost:5000/assets/madmin/application.debug-f4b00af506709e018153472c1654fac6ebe8ef52c9131170148aae16953f89a7.js:16091:3\n" }
application.debug-f4b00af506709e018153472c1654fac6ebe8ef52c9131170148aae16953f89a7.js:6576

And
Uncaught TypeError: can't access property "href", this.location is undefined
    notifyApplicationAfterPageLoad http://localhost:5000/assets/madmin/application.debug-f4b00af506709e018153472c1654fac6ebe8ef52c9131170148aae16953f89a7.js:7327
    pageBecameInteractive http://localhost:5000/assets/madmin/application.debug-f4b00af506709e018153472c1654fac6ebe8ef52c9131170148aae16953f89a7.js:7264
    pageIsInteractive http://localhost:5000/assets/madmin/application.debug-f4b00af506709e018153472c1654fac6ebe8ef52c9131170148aae16953f89a7.js:6810
    pageIsComplete http://localhost:5000/assets/madmin/application.debug-f4b00af506709e018153472c1654fac6ebe8ef52c9131170148aae16953f89a7.js:6814
    interpretReadyState http://localhost:5000/assets/madmin/application.debug-f4b00af506709e018153472c1654fac6ebe8ef52c9131170148aae16953f89a7.js:6782
application.debug-f4b00af506709e018153472c1654fac6ebe8ef52c9131170148aae16953f89a7.js:7327:49

I may try to create a small standalone app that reproduced this issue if this may help you.
Like I said it doesn't seems to brake the lookbook features.

@nicolas-brousse It's a little hard to tell what is going on there from those errors - although at first glance it doesn't appear to be to do with Lookbook. notifyApplicationAfterPageLoad is a turbolinks method, are you using that at all anywhere?
On a different note, I've not seen combustion before but that looks like exactly what I need to improve the testing on Lookbook :-) I've struggled to find a good way to run tests with different application configuration loaded and it seems like combustion will solve that. Hopefully will have some time soon to dig in a bit more!

@nicolas-brousse I'm going to close this now as I don't think that this is a Lookbook-specific issue. Feel free to reopen with more info if required of course :-)

@allmarkedup I am also experiencing a can't access property "href", this.location is undefined error on a clean Rails 7 project with the latest view_component and lookbook gems:
Uncaught TypeError: Cannot read properties of undefined (reading 'href')
    at Session.notifyApplicationAfterPageLoad (turbo.es2017-esm.js:2729:70)
    at Session.pageBecameInteractive (turbo.es2017-esm.js:2666:14)
    at PageObserver.pageIsInteractive (turbo.es2017-esm.js:2197:27)
    at PageObserver.pageIsComplete (turbo.es2017-esm.js:2201:14)
    at HTMLDocument.PageObserver.interpretReadyState (turbo.es2017-esm.js:2169:22)

It seems like this.location in this function of hotwire turbo is undefined:
notifyApplicationAfterPageLoad(timing = {}) {
     clearBusyState(document.documentElement);
     return dispatch("turbo:load", { detail: { url: this.location.href, timing } });
}

I generated a new project and added view_component + lookbook. I generated a new example view component with preview. When I start the server bin/dev and open the component in lookbook (http://localhost:3000/lookbook/example/test) I get the aforementioned error. However, when I open it in a new window (http://localhost:3000/lookbook/preview/example/test) I do not seem to get the error . Removing import "@hotwired/turbo-rails" from my app/javascript/application.js file and/or replacing it by legacy 'turbolinks' seems to prevent the error from occurring.

I'm experiencing the same issue.

Setting config.lookbook.preview_srcdoc = false in development.rb seems to prevent this issue from occurring.

Thanks all for the reports, reopening this now until I have a chance to look into it further 👍

I also see the same error, the suggestion @mauricebolhuis shared works here too.

Ok so I've looked into this a bit more. The issue is that when using the iframe with the srcdoc attribute, within the generated document there are some caveats to do with the fact that it effectively doesn't have a standard 'location' URL associated with it. Turbo seems to not play nicely without a standard location so it's throwing some errors in the component preview.
Lookbook uses the srcdoc attribute by default because it is a bit quicker than making another request for the iframe document. But as it seems to be causing issues in a few places I think the best thing to do here is to either remove the use of srcdoc on the preview iframe altogether or to change the default to using a regular iframe src attribute pointing at the preview URL.
I think I'll do the latter for now, so people who are not using Turbo still have the option of improving the page load performance by enabling the srcdoc option. However I suspect the performance benefits are pretty marginal anyway so I may just remove this in a later version.
Thanks again everyone for your help on this issue - I'll update this thread again when I've released a new version with this change in it.


Arrange update on Renal Development with SC

Have emailed SC to find out when available. Follow up with a confirmed date.

Meeting expected on Tues 5th Sept, after 12pm in CM Office


Astrometry fix

This updates how we do astrometry, by running scamp two times with MATCH=Y. This seems to improve the distortion corrections for cases where it would fail miserably previously. Additionally, Scamp processor now makes diagnostic checkplots.
Fixes bug with candidates that introduced one pixel offset.
Filters candidates with the bottom-most 10 percentile of stack weight values, to remove spurious sources that lie in regions where only some of the dithers overlap (near edges/outages). The goal is to remove the swiss-cheese like candidates that usually come from such sparse areas.

Pull Request Test Coverage Report for Build<PHONE_NUMBER>6
Details

23 of 24 (95.83%)  changed or added relevant lines in 5 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage increased (+0.05%) to 83.1%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

mirar/processors/astromatic/scamp/scamp.py
8
9
88.89%

Totals

Change from base Build<PHONE_NUMBER>1:
0.05%

Covered Lines:
11123

Relevant Lines:
13385

💛  - Coveralls


Fix inverted width and height in decodeSize method

Description
The decodeSize() method has width and height inverted on the Size() constructor

I appreciate this PR.  Rather than merging it, I applied the fix as part of the Null Safety update, because that required additional changes to the same lines.
If after updating to 2.0.0 you still have an issue, please re-submit, and I'll take another look.


wsl crashes windows!

Microsoft Windows [Version 10.0.17134.81]
What I did:  typed 'windows key wsl enter' OR clicked bash.exe in c:\Windows\System32
Result: windows crashes, blue screen, microsoft says it's not their problem, baloney.  Also cmd dir can't see bash.exe
c:\Windows\System32>dir bash.exe
Volume in drive C has no label.
Volume Serial Number is 025D-C2D0
Directory of c:\Windows\System32
File Not Found
Blue screen says 'STOP CODE: BAD_POOL_HEADER
I turned off wsl check box in control panel - windows rebooted. Re-checked it, rebooted. Installed Ubuntu. Same problem.
I can't run any linux programs 'cause it crashes before that.

Problem fixed by disabling Avira antivirus 'real time protection'

I suspect the issue is with their driver. I would suggest following with them to see if they are aware.

Problem is outside of WSL.

I contacted Avira about this and the suggested fix is to add the WSL files to the exception list in the real-time scanner options.

Hello,
thank you for your inquiry.
We would recommand to set the files of the WSL to the exceptions in the Antivirus-configuration.
File exceptions can be defined for both the “System Scanner” and the “Real-Time Protection”. A special feature of the “Real-Time Protection” is that processes may be excluded from the scan as well.
Exclude files or processes

Click the Avira icon in the taskbar to open Avira.
Search for Antivirus and click Open.
Click the settings symbol  in the lower left corner.
Click PC Protection → Exceptions.

Since the exceptions for the “System Scanner” and “Real-Time Protection” must be configured separately, please select the corresponding module in the left panel. Search and add files or processes you want to be skipped by the Real-Time Protection or System Scanner and Real-Time Protection.

Click OK to save the configuration.

I haven't had the time to research exactly what folders and/or processes need to be added to the exception list yet. So I haven't tested their fix yet. I will try to remember to update this post when I figure it out.


Make it possible to mark messages as unread

In zulip/zulip#2676, we are implementing a "mark message as unread" option in the webapp.
We should also add this option to the long-press message menu in the mobile UI.

It should be possible to mark just one message, or a message and all the messages below it in the current view.
When this feature is used, the view should not mark messages as read until the user navigates away from it. We should show the usual "messages are not being marked as read" banner when this happens.

Related issues: #5361, #5241, #4930

It should be possible to mark just one message, or a message and all the messages below it in the current view.

The version on web currently only supports the latter, so it's possible that's how it'll end up. Either way, we should match.

We should show the usual "messages are not being marked as read" banner when this happens.

We don't currently have a banner like this. We discussed a bit and concluded this issue will be fine without it -- when you've just marked something as unread, the fact that the screen doesn't immediately mark things read again should be intuitive enough.
We probably should have a banner to this effect for the sake of search and @-mention views. (Should file a separate issue for that.) When we do, it'd make sense to use it here too.

I looked into this and found that the existing server API doesn't provide a clean way to reliably implement the feature. @timabbott then found that in fact the web implementation has a bug here. Other aspects of the web app should make the bug somewhat uncommon to trigger, but if we were to do the same thing in mobile as in web, the same bug would show up fairly often.
So I think we're going to add something to the API to support this, rather than try to support it on mobile with the existing API.
See chat thread:
https://chat.zulip.org/#narrow/stream/378-api-design/topic/mark-as-unread.20request/near/1431167

https://github.com/zulip/zulip/issues/22893 tracks that API change mentioned above, which this is blocking on.

As noted in https://github.com/zulip/zulip/issues/22893#issuecomment-1255663659, we've been able to figure out how to unblock merging the feature in the webapp without that API being ready quite yet (basically, we don't offer the option in situations where it's behavior would be incorrect). That same strategy could be an option for mobile to get the feature mostly working in a beta channel to get UI feedback / work out any bugs, but I expect you'll still want to wait for @andersk to finish https://github.com/zulip/zulip/issues/22893 before releasing the feature.


can't using my mib file

Hello everybody:
I'm trying to simulate snmp agent so I've used snmpsim but I can't use my own mib file
here is my mib file
could any one help me on that
thanks for supporting
my mib.txt

Have you tried to use the mib2dev tool for building simulation data from your MIB? That should work I think.

when I ran mib2dev I get the following results but I'm stell net able to get values using snmpget for example

You should save this text into a .snmprec file so that snmpsimd could load it. Make sure that SNMP community name you use (snmpwalk -v2c -c  ...) is the same path to your new .snmprec file. The instructions are here.

thanks alot for helping it works for me


Simplifying implementation of ExpressibleByStringLiteral

Added default implementations for ExpressibleByUnicodeScalarLiteral and ExpressibleByExtendedGraphemeClusterLiteral
init(unicodeScalarLiteral value: UnicodeScalar)
init(extendedGraphemeClusterLiteral value: Character)

Now implementing ExpressibleByStringLiteral is as simple as:
extension Example: ExpressibleByStringLiteral {
    init(stringLiteral value: String) {
        self.string = value
    }
}

Previously you would have to implement something like this:
extension Example: ExpressibleByStringLiteral {
    init(stringLiteral value: String) {
        self.string = value
    }
    init(extendedGraphemeClusterLiteral value: Character) {
        self.string = String(describing: value)
    }
    init(unicodeScalarLiteral value: UnicodeScalar) {
        self.string = String(describing: Character(value))
    }
}

As well as understand what each of these meant, and which types can be used.
Changed Character's implementation of ExpressibleByUnicodeScalarLiteral
-  public init(unicodeScalarLiteral value: Character) {
+  public init(unicodeScalarLiteral value: UnicodeScalar) {

The documentation states:
/// Valid types for `UnicodeScalarLiteralType` are `UnicodeScalar`,
/// `String`, and `StaticString`.

@swift-ci Please smoke test

@swift-ci Please smoke test

thanks :)

This fails on source stability, this was expected, I've pushed a commit to remove the specific issue from the PR, although perhaps the documentation/test should be updated instead (See PR description).
swift/test/api-digester/tmp/source-stability.swift.expected
+Constructor Character.init(unicodeScalarLiteral:) has 1st parameter type change from Character to UnicodeScalar

Fixed by e8e5240 thanks @xwu

Also fixed indentation and where with d187c34, I left it indented after a search in stdlib for ^\s*where.

Is there documentation mentioning implementation requirements that requires updating here?

@CodaFi not that I can find, the documentation states:

To add ExpressibleByStringLiteral conformance to your custom type, implement the required initializer.

It already implies you only need to implement init(stringLiteral:).
There is a comment that could possibly be removed.
  // FIXME: when we have default function implementations in protocols, provide
  // an implementation of init(extendedGraphemeClusterLiteral:).

ping @dabrahams (as suggested by moiseev)

ping @dabrahams ("If it is not urgent, the common courtesy ping rate is one week." let me know if I'm pestering you, or I should be pestering someone else)

@airspeedswift let's discuss this.  It's clearly an improvement, barely squeaks by on not needing evolution review IMO, but we are planning to redesign everything in this space.  I guess I vote for merging if it passes tests.

@swift-ci Please smoke test

@dabrahams I agree, can go ahead w/o evolution, and may as well merge even if we end up redesigning just in case that misses 4.0 due to other higher-priority stuff

note: I haven't had a chance to run the tests locally yet
I believe I've addressed all the comments. I'm not 100% sure if the tests are in the right place though.
I had to make the protocol defaults slightly more generalised to remove redundant concrete implementations, the existing concrete implementations often used the same type for each protocol. I believe the generalisation improved the code overall though.
Implementing a valid associatedtype on one of these protocols will always produce a valid associatedtype in the default implementations. This is because the allowed types on each protocol is a subset of the types in its parent protocol.

protocol associatedtype
one of

UnicodeScalarLiteralType
String, StaticString, Character, UnicodeScalar

ExtendedGraphemeClusterLiteralType
String, StaticString, Character

StringLiteralType
String, StaticString

I'm getting an error trying to build master, I'll run tests locally once I've worked out what's going on there.
swift/include/swift/AST/TypeAlignments.h:104:21: error: no template named 'AlignOf' in namespace 'llvm'; did you mean 'AlignTo'?
static_assert(llvm::AlignOf<void*>::Alignment >= 2,
              ~~~~~~^~~~~~~
                    AlignTo

@swift-ci Please test

Build failed
Jenkins build - Swift Test Linux Platform
Git Commit - 4d3ca09dcbc299ccd92276856e9081cd938572ef
Test requested by - @airspeedswift

@airspeedswift Thanks for running CI.
The failing test seems to be in swift-package-manager, I don't see how this could be affected by this branch.
I've merged latest master into this branch (it was 20 days behind with no conflicts), it would be awesome if you could run CI again, unless you think it may be this branch at fault.

@swift-ci Please test

Build failed
Jenkins build - Swift Test OS X Platform
Git Commit - 4d3ca09dcbc299ccd92276856e9081cd938572ef
Test requested by - @airspeedswift

Build failed
Jenkins build - Swift Test Linux Platform
Git Commit - 4d3ca09dcbc299ccd92276856e9081cd938572ef
Test requested by - @airspeedswift

@airspeedswift sorry to pester you again, CI failed again, it claims "wrong sha", I suspect it's because it ran on 4d3ca09 and not 78c5df1...
I rebased on master, perhaps that will fix it...

@swift-ci Please test

c'mon @swift-ci you can do it...

@airspeedswift I'm not sure if that actually triggered a build, the currently running build was triggered half an hour ago, and this one was 7 hours ago...

@swift-ci Please test

Build failed
Jenkins build - Swift Test OS X Platform
Git Commit - 78c5df11250fc1fb1f44c087961bac742d9b1cb0
Test requested by - @airspeedswift

Hmm, it seems to have used the wrong commit again

Build failed
Jenkins build - Swift Test Linux Platform
Git Commit - 78c5df11250fc1fb1f44c087961bac742d9b1cb0
Test requested by - @airspeedswift

Ok it's down to an unrelated failure on the full macOS test suite that I think is also failing in master. We can smoke test then merge probably.

@swift-ci Please smoke test macOS platform

Thank @airpseedswift :)

Thanks @airspeedswift 🙂

Thank you everyone that helped review :)

Thank you @airspeedswift for your persistence with CI :)


It keeps increasing indent when I wrap lines in script block

When volar.format.initialIndent is set to true and editor.formatOnType is set to true, like:
{
	"volar.format.initialIndent": {
		"javascript": true,
		"typescript": true,
	},
	"editor.formatOnType": true,
}

Then when I wrap lines in script block, it keeps increasing indentation. Setting them false will work properly, but this will not match our code style.
As shown in the video:
https://user-images.githubusercontent.com/56647156/219363648-86a29d96-2071-4f21-ba75-05e45789c47b.mp4

Duplicate of #2394


"Adding external JAR" in simple Java project

VSCode Version: 1.36.0
OS Version: Windows 10 Pro 1903 build 18362.175

Steps to Reproduce:

Install latest Java Extension Pack
Follow doc Java Project Management in VS Code
2a. create simple project
2b. add source files with dependencies (VS Code shows errors in source "The import library.packege cannot be resolvedJava(268435846)"
2c. as written in chapter Adding external JAR create lib dir and put library jar files there
2d. in the doc at that moment source becomes valid, in reality errors stays

Does this issue occur when all extensions are disabled?: No (with extensions disabled Java project management functionality is missing)

found request in extension issues: Support to add Jar file or any other file/directory to classpath


VSCode should reopen when machine rebooted for updates

VSCode Version: 1.5.3
OS Version: Windows 7 Enterprise 64bit

Steps to Reproduce:

Have VSCode open with at least one workspace and open files
Restart your computer to apply updates, or simulate with shutdown /g

Expected Results: VSCode is reopened with workspaces (all of them) open
Actual Results: No VSCode running
According to my tool, https://james-ross.co.uk/projects/arr, VSCode does not register for being restarted at all. It should register at least for "reboot". This should be a simple thing to fix, although the quality of the restart behaviour will depend on issues like #101 and #12436 and others.

I'm interested in working on this

VSCode Version: 1.27.2
OS Version: Windows 10 Pro 64bit
Steps to Reproduce:

Have VSCode open with at least one workspace and open files
Restart your computer to apply updates, or simulate with shutdown /g
Expected Results: VSCode is reopened with workspaces (all of them) open

Expected Results: VSCode is reopened with workspaces (all of them) open
Actual Results: No VSCode running
I was able to repro this in the latest version of VSCode.

I can take a crack at this one - However, I am unsure as to how I would use Windows Native API calls within Javascript, I can't find other examples of this in the current codebase.

From what I have read on tech blogs and windows OS documentation, the feature to restart previous running programs is an Operating System feature that uses the registry (windows) or something like /proc in linux to know which programs where open at the time of shutdown.

Should this feature continue to be managed by the OS vice VS Code?
Does anyone know a pointer to the code that controls the logic for tracking open work spaces?
Is there a settings feature already in existence that does this?

I think answers to these questions will help to determine the viability of

The feature for VS Code to track both its own running state, the OS running state and
Track open work spaces "event loop" that updates on work space change (i.e., open close).
I know that for this to work though more overhead will be incurred in terms of performance when
opening and closing work spaces because of data being written to disk to make this work.

We need to use the RegisterApplicationRestart function as described here: https://docs.microsoft.com/en-us/windows/desktop/api/winbase/nf-winbase-registerapplicationrestart and here https://docs.microsoft.com/en-us/windows/desktop/recovery/registering-for-application-restart
However, I am unsure of how to use these from Electron/Javascript as well as where in the codebase to call from.

I scanned through the source this morning. I have to admit I am not that familiar with it yet. I did see a few places that relate to vs code's app state, app history, and win32 calls. It might be worth a deeper look.
Get Outlook for Androidhttps://aka.ms/ghei36

From: Frederik Bolding<EMAIL_ADDRESS>Sent: Wednesday, October 3, 2018 7:14:00 AM
To: Microsoft/vscode
Cc: vbraziel; Comment
Subject: Re: [Microsoft/vscode] VSCode should reopen when machine rebooted for updates (#12630)
We need to use the RegisterApplicationRestart function as described here: https://docs.microsoft.com/en-us/windows/desktop/api/winbase/nf-winbase-registerapplicationrestarthttps://nam03.safelinks.protection.outlook.com/?url=https%3A%2F%2Fdocs.microsoft.com%2Fen-us%2Fwindows%2Fdesktop%2Fapi%2Fwinbase%2Fnf-winbase-registerapplicationrestart&data=02|01||4dfe2c3b0bc547e9a42708d629215297|84df9e7fe9f640afb435aaaaaaaaaaaa|1|0|636741620420812991&sdata=NxMYyp4CGxdAJia5CFopaWzZFXe60lTmhafjOHUkUUg%3D&reserved=0 and here https://docs.microsoft.com/en-us/windows/desktop/recovery/registering-for-application-restarthttps://nam03.safelinks.protection.outlook.com/?url=https%3A%2F%2Fdocs.microsoft.com%2Fen-us%2Fwindows%2Fdesktop%2Frecovery%2Fregistering-for-application-restart&data=02|01||4dfe2c3b0bc547e9a42708d629215297|84df9e7fe9f640afb435aaaaaaaaaaaa|1|0|636741620420969238&sdata=dtYXWZ6gs0a14YrdWUNuXp3ojcpR8DiFX4EVGkLCd7o%3D&reserved=0
However, I am unsure of how to use these from Electron/Javascript as well as where in the codebase to call from.
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHubhttps://nam03.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2FMicrosoft%2Fvscode%2Fissues%2F12630%23issuecomment-426598464&data=02|01||4dfe2c3b0bc547e9a42708d629215297|84df9e7fe9f640afb435aaaaaaaaaaaa|1|0|636741620420969238&sdata=81Fvus%2Fumv37oCnXGkH%2FzXswWmI0fE2E9B1L3nsWcTI%3D&reserved=0, or mute the threadhttps://nam03.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FAKrQCKzrpO8I_gSj3D7rPcmr1N0KoL2uks5uhJv4gaJpZM4KGdYW&data=02|01||4dfe2c3b0bc547e9a42708d629215297|84df9e7fe9f640afb435aaaaaaaaaaaa|1|0|636741620420969238&sdata=x3s%2FTtBFNaVqR7Ik0HVz%2BQW2rwRg5%2B0sSDtZFkVEUxE%3D&reserved=0.

Is the node-auto-launch project (or it's source) of any help?

Since work seemed dead, I've gone ahead and started development on this issue. I have a prototype of it working. I'm using the RegisterApplicationRestart method from a Node extension I developed. Expect a PR soon, after I complete testing.


A confusing error message appears if your username is a duplicate when signing up

"An error occurred" doesn't cut it.

Closing this as an 0.5 issue we're unlikely to prioritize unless it comes up for a legacy client. There is as yet no equivalent 2.x feature.


How the wallet is stored if terminal device don't support file systems

The wallet is stored in a file,
Once the terminal device don't support file systems, How the wallet is stored?
In this way, It can be stored in the flash.
I think we can modify the following functions:
BOAT_RESULT  BoatReadFile( const BCHAR *fileName,
BUINT8 readBuf, BUINT32 readLen, void rsvd );
BOAT_RESULT  BoatWriteFile( const BCHAR fileName,
BUINT8 writeBuf, BUINT32 writeLen, void* rsvd );

Yes you are right.
This function is an abstraction for accessing EVM, and the default implementation is with a file system, this function needs to be rewritten when porting to platforms that do not support file systems.


Add support to show static toasts to specific viewcontroller

Fixes #543
Bonus track: also doesn't disable the send button after a failure when it shouldn't

Aha! Thanks for this!


Text not copied to clipboard in disabled textarea

I am using clipboard.js to copy text from a disabled textarea (the text is programmatically generated and I don't want the user to edit it before copying):
<button class="copyBtn" data-clipboard-target="#myTextArea">Copy</button>
<textarea id="myTextArea" rows="10" disabled>My text here</textarea>

With the disabled property the text is not copied to the clipboard, despite the clipboard success event indicating that it is:
var clipboard = new Clipboard('.copyBtn');

        clipboard.on('success', function(e) {
            console.info('Action:', e.action);
            console.info('Text:', e.text);
            console.info('Trigger:', e.trigger);

            e.clearSelection();
        });

        clipboard.on('error', function(e) {
            console.error('Action:', e.action);
            console.error('Trigger:', e.trigger);
        });

Action: copy
Text: My text here
Trigger: <button data-clipboard-target="#myTextArea" class="copyBtn">

Removing the disabled property on the textarea, clipboard functions as expected and text is copied.

Have you tried readonly instead of disabled?

Works fine with readonly, which makes more sense for my use-case. Thanks.

;D

I encountered this problem too.
Clipboard.js works with disabled on Chrome, but not on Firefox.
readonly is OK on both.
I think you should update the readme and the web site to mention about readonly, as I think many people may encounter this problem too, and they may give up this wonderful Clipboard.js because they think it's broken.

@ngocdaothanh is correct, disableddoesn't works on Firefox and yet it emits the success event.

@Damini25 your solution worked for me. Thanks a lot!


ESP Rainmaker Android  (MEGH-3838)

Hello,
I'm trying to use the ESP Rainmaker example as a core of my project, but i'm a very beginner in developing Android apps with Java language.
I want to add more functionalities to the app, but i'm confused how to modify the ESP Rainmaker android app to send a custom message (JSON format) to the ESP32.
Which function/method should i use to send custom messages to the ESP32?
It would be so appreciated if you can provide me with an example of it, or at least a starting point from where i can go.
Thank you.

@Halabdelkrim , what kind of custom data do you need to pass to the device? You can have custom boolean/integer/float/string parameter which you can control from the phone apps without requiring any change.

Thank you for your response.
I want to send a custom string.
Could you please guide me to the right method to use or if there is any example how to make it?

I'm developing a device that make an action based on a predefined temperature and humidity value. This why i want to make a little changes to app, so the users can control it using esp rainmaker app.

@Halabdelkrim , you can see here an example of a custom boolean parameter. Similarly, you can create a string parameter using something like this
esp_rmaker_param_t *str_param = esp_rmaker_param_create("MyString", NULL, esp_rmaker_str("my value"), PROP_FLAG_READ | PROP_FLAG_WRITE);

Hi,
Everything now works well.
Thank you so much.


wsdd: 0.6.2 -> 0.6.4

Motivation for this change
Update wsdd to version 0.6.4
Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
[x] Tested execution of all binary files (usually in ./result/bin/)
21.11 Release Notes (or backporting 21.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[ ] Fits CONTRIBUTING.md.

nixpkgs-review happy for me, macos 10.15 & nixos x86_64. nixosTests.samba-wsdd passes.


The arrow and search font icons aren't showing up in Manjaro Xfce for some reason.

Installing "qt6-svg" fixed the issue of SVG icons not showing up, but font icons still don't work.

This should be fixed now that I fixed the icon fonts more generally.


Qc fps

this PR changes qc_properties to False as the default. To reduce false positive merges in fingerprints, we should keep all fingerprint positions (total 2936)

Changes look good to me, I am a bit surprised that there's no tests failing after this changes any ideas? Or are we always specifying whether or not to do the qc filtering?

Currently, we are always specifying whether or not to QC in the tests & only checking if that filtering works correctly when specified. We can add another one that uses the default.

Got it, that makes a lot of sense.


PoC: Resource-group scoped deployment

Proof-of-concept of what a resource-group scoped OpenAI demo deployment would look like.

Does this not work? I notice you closed it.


Allow Custom Errors on any value?

Any reason not to allow defining the last argument for any value as an error message to allow overriding the error message for that property easily?  The current method is not really ideal, especially when you have many string props but need different errors.
A couple nice ways to handle it:
Allow Last Param to be Error Message

Would also accept a custom error that it would throw instead of ZodError (similar to Joi)

const TestSchema = z.object({
	three: z.literal('hi').optional(),
	one: z.number(),
	two: z.literal(3, 'that isnt 3 dummy'),
	four: z.string('string not whatever you gave!'),
	five: z.date()
})

Add a .error() option like Joi
const TestSchema = z.object({
	three: z.literal('hi').optional(),
	one: z.number(),
	two: z.literal(3).error(new Error('that isnt 3 dummy')),
	four: z.string().optional().error(new Error('string not whatever you gave!')),
	five: z.date()
})

For the VSCode extension I am working on, these styles add the benefit that jsdoc can be used to transfer over error messaging easily:

This is on the roadmap. Though it'll likely be an object instead of a string to leave room for future API additions.
z.string({ message: "That's not a string!" });

Agreed, good to know it's coming !

It is also a very useful feature to customize the error message of e.g. .union and .nullable.
Currently z.string().nullable().parse(undefined) would throw
Issue #0: invalid_union at
Invalid input

which is very confusing for the user. It would be great if something like z.string().nullable({ message: "This field can be a string or null, but not undefined." }).parse(undefined) could produce:
Issue #0: invalid_union at
This field can be a string or null, but not undefined.

What about yup#setLocale API? It seems to be easier to handle global translations for both primitives and their methods

I think hard-coding an error message should override the error map in this case. Based on my limited understanding of what you're trying to do, it sounds like an anti-pattern. Localization settings should be contextual, not baked into schemas. The recommended approach here is to create a separate error map for each language and either pass it as a parameter to .parse() or use z.setErrorMap() to set it globalls.

What if the schema is defined on a per-form basis (e.g react-hook-form) and I need to localize error messages (react-i18next).
// schema definition: notice the translation using t("...")
const ZMySchema = z.object({
  name: z.string().nonempty().regex(/^[A-Za-z ]$/, t("users:form.validNameRequired")),
});

// now registering the schema to the form
const form = useForm({ resolver: zodResolver(ZMySchema) });

Until I find a better solution, I implemented the following workaround in my code:
import i18n, { TFunction } from "i18next";

class TranslatedString extends String {
  toString(): string {
    return i18n.t(super.toString());
  }
}

/**
 * Use this for localization of zod messages.
 * The function has to be named `t` because it mimics the `t` function from `i18next`
 * thus our IDE provides code completion and static analysis of translation keys.
 */
export const t: TFunction = (key: string) => ({ message: new TranslatedString(key) });

The trick is to defer the evaluation of the t() function until the string is printed which could have also been achieved if zod accepted a function as a message.

I'm also looking forward to this - I'm using zod in forms, and if a user fails to enter a required field, i'd rather it say something like "X is required" instead of Expected number, received nan, but at the moment I don't see a good way to add that requiremnet.

@osdiab you can globally modify every error Zod creates with Error Maps: https://github.com/colinhacks/zod/blob/master/ERROR_HANDLING.md#customizing-errors-with-zoderrormap

That's an alright workaround! One thing though is that it's a little too imprecise for me to necessarily make a correct error message - for I have this number input field and if it's empty then what gets passed to Zod is NaN, which may happen for other invalid inputs; but I can't distinguish that from just an empty input based on the context object that's provided, where it's already been parsed, so it's possible for me to end up saying Required when really the issue is please enter a valid number. Can be worked around by clever copy or just some custom code but the hope is to minimize the custom code necessary for any situation, so it leaves a little precision to be desired.

I think the issue with ZodErrorMap is theres often cases where you want a certain schema to return a different error for that specific schema. The limit of having only a message object in the granular case precludes you from having error objects returned by zod, for later parsing by an application to react to those errors. E.g. being able to return an object of an arbitary shape.
Ultimately, only being able to return a message string in the non-global case precludes you from having custom errors for a schema where you want to do i18n later or if you need to react to those errors based on some key in your application for whatever reason.
I'd suggest what would solve this is something like:
const ZMySchema = z.object({
  name: z.string().nonempty().regex(/^[A-Za-z ]$/, ({path}) => ({code: MY_CUSTOM_CODE, path)),
});

In my case given that the error happens at the number() stage I just want to be able to do this:
z.number({ message: "Make it a number, doofus!" });

or alternatively for more complicated circumstances,
z.number({ message: ({ issue, ctx }) => makeErrorMessage({ issue, ctx }) })

I have created a PR #543 that your could set required or invalid messages to string, number and boolean. Would like to hear from you guys on ways to improve it.

Zod is really super cool, but I also stumbled upon this issue here while figuring out how to use React Hook Form resolvers together with localized error messages using i18next. The API with a message property (like z.string().min(5, { message: "Must be 5 or more characters long" }) is quite ok, but it must be possible to pass in an object as a message. Otherwise, it won't be possible to translate complex messages with interpolations in them. Is this still planned?

Zod brought me out of two days of depression after going through several other libraries.
At the moment this is the only problem I have encountered. Against the background of everything else, this is a mere trifle, but nevertheless I am also waiting for a solution to this problem.

Let me share my latest workaround for this (updated since May 17):
// file: zod-translation.ts
import i18n, { TOptions } from "i18next";

class TranslatedString extends String {
  private readonly restArgs: (TOptions | string)[];

  constructor(private readonly key: string, ...restArgs: (TOptions | string)[]) {
    // if we used something else than an empty string here,
    // we would see the string being transformed to an array of chars
    // (seen in IntelliJ debugger)
    super("");

    this.restArgs = restArgs;
  }

  toString(): string {
    return i18n.t(this.key, ...this.restArgs);
  }
}

/**
 * Use this for localization of zod messages.
 * The function has to be named `t` because it mimics the `t` function from `i18next`
 * thus our IDE provides code completion and static analysis of translation keys.
 */
export function t(
  key: string,
  options: { path: string | string[] } | Record<string, unknown> = {}
): { message: string; path?: string[] } {
  const message: string = (new TranslatedString(key, options) as unknown) as string;
  const { path } = options;

  if (path === undefined) return { message };

  return {
    message,
    path: typeof path === "string" ? [path] : (path as string[]),
  };
}

Example usage:
import { t } from "./zod-translation.ts";

export const ZValidEncryptionKey = z
  .string()
  .regex(/^[a-zA-Z0-9]*$/, t("error.ZValidEncryptionKey.noSpacesAllowed"))
  .nullable();

It would be cool if there were community translation files for common errors, where we would import 'zod/locale/pt'; and globally or on parse we would enter the language code. dayjs works like it.
They would be dicts from errorId to the translated message.
Similar for custom errors, loading them would register the errorIds to their messages. They could have the $x pattern for the values in the strings like $1 must be greater than $2!, and on the schemas, they would be selected and populated via ~ ('myError.invalidABC', [var1, var2])

Similar to yup which have a community driven package: yup-locales

Similar to yup which have a community driven package: yup-locales

This is really good. @colinhacks can you take a look?

Landed here while working on an issue today where my react app with i18next translated literals were not getting used. I tried @vsimko's solution, but found it didn't work with i18next-parser (which I'm using to extract translations). The root issue is that the schema is created before i18next gets initialized (I'm doing so in a hook in the root component). I found an easy alternative which is to just move the schema code and its type inside of the component:
//react functional component
export const LoginForm = () => {

    //zod schema with literal strings to be translated with i18next
    const schema = z.object({
    username: z.string()
      .nonempty(t`Email is required`)
      .email(),
    password: z.string()
      .nonempty(t`Password is required`)
      .min(8, t`Password must be at least 8 characters`)
  });

  type Schema = z.infer<typeof schema>;

  //react-hook-form useForm hook w/ zodResolver
  const {register, handleSubmit, formState: {errors}} = useForm<Schema>({
    resolver: zodResolver(schema)
  });
...rest of component
}

Previously, my schema object and type were above the LoginForm component itself and I only got the default messages. Now I have full type safety and localized validation messages, which is awesome. Hope this helps someone else.

Up

Up

Is there a solution?

Here is my (relatively simple) solution. Similar to @btebbens I build the schemas when I need them. But as I also use them in resolvers on the server (in my case Blitz.js, but tRPC works similarly) I put them in an own file where they can be built with and without the t function.
Simple example:
// app/core/validations.ts
const buildCreateProductSchema = (t?: TFunction) => z.object({
  name: z.string().regex(/^[a-zA-Z]*$/, t && { message: t("formErrors.invalid") })
})

up

Hmmm just stumbled upon a usecase where we need a custom error for invalid_literal values when checking literals. :/

I've trying to create schema with i18n error messages. Ended up on this solution:
const schemaFactory = (t: TFunction): z.ZodType<ApiLoginRequest> =>
  z.object({
    email: z.string().email({ message: t('Please enter valid email') }),
    password: z
      .string()
      .min(MIN_PASSWORD_LENGTH, t('Minimum {{chars}} characters', { chars: MIN_PASSWORD_LENGTH }))
      .max(MAX_PASSWORD_LENGTH, t('Maximum {{chars}} characters', { chars: MAX_PASSWORD_LENGTH })),
  });

export default function LoginFormContainer() {
  const { t } = useTranslation();
  // memoize the schema to prevent recreating on each render
  const schema = useMemo(() => schemaFactory(t), [t]);
  const { register, handleSubmit, reset } = useForm({ defaultValues, resolver: zodResolver(schema) });

  // ...rest of your component

Hope it might help someone

I've been trying to create schema with i18n error messages. Ended up on this solution:
const schemaFactory = (t: TFunction): z.ZodType<ApiLoginRequest> =>
  z.object({
    email: z.string().email({ message: t('Please enter valid email') }),
    password: z
      .string()
      .min(MIN_PASSWORD_LENGTH, t('Minimum {{chars}} characters', { chars: MIN_PASSWORD_LENGTH }))
      .max(MAX_PASSWORD_LENGTH, t('Maximum {{chars}} characters', { chars: MAX_PASSWORD_LENGTH })),
  });

export default function LoginFormContainer() {
  const { t } = useTranslation();
  // memoize the schema to prevent recreating on each render
  const schema = useMemo(() => schemaFactory(t), [t]);
  const { register, handleSubmit, reset } = useForm({ defaultValues, resolver: zodResolver(schema) });

  // ...rest of your component

Hope it might help someone

Main problem with such schemaFactory initiated in components is that you cannot export and reuse this schema outside of this component. This defeats the main "goal is to eliminate duplicative type declarations"

Hi all! This seems to be one of the oldest open issues in the repo, and the original header issue title seems to have been resolved some time ago with custom errors and errorMaps.
However there are some additional asks that seem very useful and probably merit their own issues. Would it be better to open separate issues on these topics and discuss/track progress there instead? I took a quick look but couldn't find a great home for the following:

i8n support for error messages (@vsimko / @SrBrahma )
catch-all per-call error customization for schema.parse() (@osdiab / @adam-thomas-privitar )

Let me know your thoughts! 🙏

As @maxArturo said, this has been mostly implemented for a long time now - whoops. Almost every schema creation function z.whatever supports an options object with the required_error and invalid_type_error options.
const name = z.string({
  required_error: "Name is required",
  invalid_type_error: "Name must be a string",
});

This is true for all schema types.
z.object({ asdf: z.string() }, { required_error: "asdf" });

You can set an error map globally with z.setErrorMap.
const myErrorMap: z.ZodErrorMap = (val, ctx) => {
  return { message: "whatever" };
};
z.setErrorMap(myErrorMap);

You can set an error map on a per-schema basis
z.string({ errorMap: myErrorMap })

And you can set a contextual error map in a particular call to .parse.
z.string().parse("tuna", {errorMap: myErrorMap})

i8n support for error messages

Tracked in other issues.
Closing.


migration.json

To follow along with your example, do I need a migration.json file?
The online doc appears to state this is only needed for moving tables from one extension to another - an AL to AL move - that C/Side tables and fields being moved to an extension - C/AL to AL - the migration.json fle is not used.
Am I misunderstanding your example?

I believe you have understood it right.
Migration.json file is needed for AL to AL upgrade. It supports moving a table from one extension to another and extracting table extensions. Once you extract table extensions it is not possible to change them, the platform does not support it.
For C/AL to AL upgrade migration.json is not supported. If you want to extract added fields to table extensions you have to upgrade from C/AL to AL first (intermediary step) an then you need to do another upgrade to extract table extensions with migration.json.
The problem is that it is hard to move fields up the dependency chain (e.g. from BaseApp to the app that depends on the BaseApp). Each time you need to do this you will have to upgrade with intermediary step (Applicable for OnPrem)
There are two examples:
15X - Business Central 2019 Wave 2 - this example is C/AL to AL, just moving tables, not extracting fields
Upgrade14To16ExtractFieldsToExtensions - this example is C/AL to AL (Tables Only), then AL (Tables Only) to AL System App, Base App + Extension on Top with table extensions.

In your example, it looks like it moves custom tables and custom fields in standard tables in the modified standard C/AL to an extension that has the same table numbers and fields. It looks like it does not care about name changes, so we can have our app use our assigned prefix.
Am I correct?

I am trying to follow the steps in:
https://docs.microsoft.com/en-us/dynamics365/business-central/dev-itpro/upgrade/upgrade-to-microsoft-base-app
which look like I first need to create an app with all tables including customizations.
This gets errors from the dropped product group table.
Should I rather use your PowerShell script (which is a lot more complicated than your PowerPoint)?
I have the additional challenge of cleaning up Classic tables that were not dropped after the previous conversion, so I am moving cautiously and trying to understand each step.
The desired end result is an ISV app and a dependent custom app.
My understanding is this process only looks at field and table numbers, so the new apps will use the new prefixed names when the table and field numbers match.

The PowerShell should be aligned with the docs, if it is not, please let me know and we should update one of them.
The rule is once you start AL upgrade, you should not have any SQL breaking changes. If you do, you need to force sync, which can do damage, thus I would not recommend it. If you are coming from C/AL do all breaking changes on 14. If you want to drop the tables, you can migrate them to the extension that you will uninstall.
Process looks at the SQL table definitions and it includes both table name and table number to compare the tables.
The process is as follows:
Code preparation:

You create Tables Only Base App extension and empty extensions for the final apps (Just with Json file)
You create Full extensions that you will use in the end and delete tables from Tables Only Base App creating Empty Tables Only Base App. Update version to be slightly higher and add migration json to Empty Tables Only BaseApp.

Upgrade:
3. You upgrade to Tables Only Base app from C/AL. This process must not contain any breaking changes. This will add guids to the end of the tables moving them from C/AL to AL. After this you publish blank apps so you can upgrade them in the next step.
4. Then upgrade intermediary solution to final solution - Publish Empty Tables Only Base app with migration json, then publish full apps. Syncing should be done top down, with Empty Tables Only Base app synced last.

I created the Tables Only Base app from C/AL - but I am getting compile errors because the Product Group table (5723) is not supported.
It is in your example base app.
Do I need to switch to an earlier version of AL or is there a setting I can use to enable or compiling or should I do a force delete in BC14?

Tables only base app should be created from your own installation. It could be that my example is old. You can do this by using Txt2AL tool.  There is a documentation topic on how to do this, just make sure you install the latest version.
Text 2 Al should be called like something like:
txt2al --source=C:\export2al\bc14tablesonly --target=C:\export2al\bc14tablesonly\al --tableDataOnly
It is present in version 14.17.
If you are on yammer you can find the info on this thread, if not we can add  you if you have issues joining.
https://www.yammer.com/dynamicsnavdev/#/Threads/show?threadId=879678586896384&search_origin=global&scoring=linear1Y-prankie-group-private-higher&match=any-exact&search_sort=relevance&page=1&group_ids=5059035&search=txt2al

I already did this thanks. All my BC14 tables are there.
When I did Ctrl-Shft-B to build it, got the error:
error AL0433: Table 'Product Group' is removed. Reason: Product Groups became first level children of Item Categories..
So I cannot create the base app.
I am using AL Language 6.1.352568

Is something referencing 'Product Group' in the code?
Have all references been removed/deleted?

I did not have any code, but there was one ISV table with a table relationship to Product Group that was giving an error instead of a warning.
I removed the table relationship, and it generated the app.
BTW - my sole purpose is data migration from NAV 2017 to BC 16/17 - we already have our BC apps running on premise and in the cloud.
Will BC17 on premise also support moving to the cloud or will we have to do it via BC16?

Super. The migration from 17 -> 17 cloud is already supported. Then you just need to migrate, select in the wizard Business Central. Upgrade Migration (select Business Central - Previous Version) is coming soon - hopefully this week.


TerminalParser forget's required argument(s)

Example: say --pitch 0.5 does not throw any error, although the required "text" argument is not present.
Expected: say --pitch 0.5 should throw the error: ParseError: argument "text" (string) is missing
Fix implementation:
Loop through all argOptions at the end of parsing and check if any required argument does not have the isManuallySetValue set to true.

fixed and uploaded.


Added JSON Datasets to Miscellaneous

Please read The awesome manifesto and make sure your list complies to it.

Generally looks good, but I think each item in this section could use a description: https://github.com/jdorfman/awesome-json-datasets#sources

@sindresorhus since all of the links go directly to the JSON endpoint I wanted to give credit to the sites hence the Sources section.  Since this is a unique case and not in the manifesto should I just remove that section?

A random list of links isn't very useful. I would either add a description to each item or remove the section.

I agree.  Removed the section all together.  Thanks for the feedback.

Ok, looks good. Can you fix the merge conflict?

@sindresorhus sure I will just close this PR and resubmit.


Changed direct user model import with get_user_model method.

It's better to show good practice in docs, isn't it?

I'm not completely convinced about the change as it could give the impression that the example works with any user model. It might work, but perhaps not if the custom user model doesn't have the is_staff/is_superuser fields (i.e. if it inherits AbstractBaseUser rather than AbstractUser. Also, custom user models might have some some different required fields. Perhaps at least some clarification could be added about those points.

What do you think @hendrikschneider?

Hey timgraham,
you are right. I will fix this :)

Closing due to inactivity.


Implemented basic bot command framework, and updated .gitignore

Fantastic stuff mate, well done. Approved.


[Bug]: Appwrite function domain is incorrect

Error Message and Logs
The function domain generated using the GitHub integration is not correct. As you can see, it adds the function id before the Appwrite domain.

Steps to Reproduce

Create a function in Appwrite using the GitHub integration
Build the function

Example Repository URL
No response
Coolify Version
4.0.0-beta.355
Are you using Coolify Cloud?
No (self-hosted)
Operating System and Version (self-hosted)
Ubuntu 22.4
Additional Information
I found this thread and this on discord that discusses this same issue. The issue happened to users who had the installation using Coolify.

This because the SERVICE_URL_ and SERVICE_FQDN_ are mixed up like that was with COOLIFY_URL AND COOLIFY_FQDN. But the COOLIFY one got fixed, see #2443.
But when this gets fixed the url wont be reachable because you need to add the url to the domains list in the coolify appwrite service. There is a way to not have to do this but that involves to setup a wildcard ssl certificate for your domain.

@kuzerno1 So I'm a little bit confused. I don't mind adding the urls to the domains list in the appwrite service, but which would be the solution to this problem? Do I need to update SERVICE_URL_  or SERVICE_FQDN_  in any specific way? Thank you in advance!

@mikelgmh you cant change these variables because they come from coolify. But you can change service_fqdn_appwrite to service_url_appwrite in the compose file.
This will work but soon as you add the function url I think it will break stuff in appwrite.
Because _APP_DOMAIN and a few other variables want only one domain if Im correctly. You will need to change these variables with your main domain.

Apologies if this is this the wrong place to post this, but I keep getting 404's on function domains.
Coolifyv4-beta.370
appwrite 1.6.0
Unchecked "Strip Prefixes" in both Appwrite Console and Realtime Services
Also have wildcard set up for appwrite.codeprojects in squarespace
Any ideas?

Exact same setup as uncle vesimir, the path is correct but the functions give 404s and hit what looks like trraefic instead of getting passed in.
I'm willing to help debug but basically latest coolify and appwrite from a blank install.

Can you guys check if you're running version 2 or 3 of Treafik? You can check this by Servers, choose your server and then Proxy.
The reason I ask this is because I got everything working but a few days back I saw a issue that someone could not get wildcard certificate to work. He was also getting 404 pages. But I saw in his issue that he was using Traefik version 3 and I'm using version 2.
And after some digging I found out that since version v4.0.0-beta.324 this has been changed to version 3 and I installed Coolify before that so that was de reason why I was running version 2 instead of version 3. Luckily there is a button reset default config and now I'm running version 3. But now I'm also getting 404 pages.
So I check the docs again about the wildcard certificates but that is still for Traefik version 2. And for Traefik 3, according to the docs of Traefik I needed to change HostRegexp(`{subdomain:[a-zA-Z0-9]+}.domain.com`) to HostRegexp(`^.+\.domain\.com$`) in my applications compose file and now everything is working again.

HostRegexp({subdomain:[a-zA-Z0-9]+}.domain.com) to HostRegexp(^.+\.domain\.com$) is what fixed it...
so steps for anyone else:
setup wildcard domain
add a dynamic proxy config to redirect wildcard traffic to the main appwrite instance


Drop our label-col width heuristic for less wasted col. space

The label column now flexes to the available space. (Old behaviour:
label width was a function of # of cols).
Most columns other than the label now have a fixed width specified
(some large ones are left to share the avaiable space w/ the label)

Fixes #1882

LGTM


gitops function -- when multiple files are deleted in one commit only one file is sync to chaosCenter

What happened:
When chaosCenter is sync to a github repo via gitops, and there are multiple scenario files deleted in one git commit to the repo, only one file is deleted from chaosCenter. The other files remain in chaosCenter. Subsequently when manually delete the file from chaosCenter, the log will shows an File not found in git error.
What you expected to happen:
When multiple scenario files are deleted from github repo, all the files be deleted from chaosCenter as well.
Where can this issue be corrected? (optional)

How to reproduce it (as minimally and precisely as possible):
Create multiple scenario files via chaosCenter, it will be sync to gitops repository in github. Use git to do multiple scenario files delete from the repo and commit the changes. Observe only one file is actually deleted from chaosCenter, even though multiple files already deleted from the repo.
Anything else we need to know?:

CC: @AmitKumarDas PTAL

@bingwei-hong-partior thanks for reporting this! We will take a look into this.


Allow for Tags not to be of class Tags

Hi,
This my not be a bug or anything but rather a question. Sorry about that. However, I have the following problem:
I am trying to define tags to resources, such as an S3 bucket, which can support in native CFN to have Tags and therefore, to use Tags={} in my template.
However, my tags key names are not python friendly:
'Key': '10-technical:usage',
'Value:'PoC'
}]

If I put that in, I get
TypeError: <class 'troposphere.s3.Bucket'>: SourceBucket.Tags is <class 'list'>, expected <class 'troposphere.Tags'>
I have tried many variations but basically at this point I can't find a way to make it work with my defined tagging convention using Troposphere.
Many thanks for your help

If I'm reading that correctly, you want something like this?
>>> from troposphere import Tags
>>> tags = Tags({'10-technical:usage': 'PoC'})
>>> type(tags)
<class 'troposphere.Tags'>
>>> tags.to_dict()
[{'Key': '10-technical:usage', 'Value': 'PoC'}]

Ha ! That might be the one variation I didn't try :man_facepalming:
Thank you very much for your help (and so quickly !) :+1:


build: set libtool min version to 2.4.6

As it's the one used in Ubuntu 22.04 LTS.
Got hit by this while preparing v1.45.0.

This file is autogenerated, to make sure you have the latest releases of everything when we make the release. It seems Ubuntu is behind?


add multiple packages

This adds packages from #1281, #1282, #1283, #1284, #1285, #1286, #1287, #1290


docs: Instruct users to return z.NEVER in .superRefine() when providing a type predicate

This resolves #1704.

Thanks @zetaraku . Feel free to update the tests to demonstrate this best practice.

I found that there is another README.md in deno/lib.
Why are there two README.md? I'm afraid it's out of sync.


Fixed issue with bar chart

If auto-sorting is on (as per default), the returned series object is sorted by values, i.e. for „male“ the not-survived category is reported first and for „female“ the survived. When summing over male and female, the categories get mixed up.

@metatier I don't see any difference in output:
Your update:

The original:

Can you explain this a little further?

the returned series object is sorted by values, i.e. for „male“ the not-survived category is reported first and for „female“ the survived ed. When summing over male and female, the categories get mixed up.

The result of df.Survived[df.Sex == 'male'] is a subset of the data frame where Survived was recorded as true and where Sex is recored as'male’.  This filters out all of the female observations.  value_counts() is used to the number of records of that resulting subset. Conceptually, it could be swapped out with size: df.Survived[df.Sex == 'male'].size. In hindsight, that would have been more succinct and easier to understand.
How do are categories getting mixed up? What is numeric error in the sorted value counts vs unsorted that you're getting?  Are you using the version of Pandas that this notebook is using?

hi. when i run In[23]
create a regression friendly dataframe using patsy's dmatrices function
y,x = dmatrices(formula, data=df, return_type='dataframe')
It always reminds me  that"ValueError: For numerical factors, num_columns must be an int"
can you tell me why?thx

Closing since this issue has gone stale. Happy to reopen!


Links open File Explorer instead of browser

This has been a long standing issue that hopefully can be resolved now that Station is open source. Often when clicking links, they open the File Explorer instead of opening in the default browser. I've never had a single link I want to open File Explorer, so hopefully that behavior can be changed.

Is it still an issue?

I'm closing the ticket. It's too old
We will create a new one if it is still an issue.


emmet-language-server: init at v2.2.0

Description of changes
Adding package https://github.com/olrtg/emmet-language-server

Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[x] Tested basic functionality of all binary files (usually in ./result/bin/)
23.11 Release Notes (or backporting 23.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[x] Fits CONTRIBUTING.md.

@t4ccer Thanks for the review. Should I squash those changes into 1 commit (with init message) then force push?

Yes please. You can see https://github.com/NixOS/nixpkgs/blob/master/CONTRIBUTING.md#commit-conventions for details, but all changes for one "unit" should be in a single commit

Resolved notes from review and pushed new commits.

@t4ccer Just checking to see if the new changes look good

Oh one more thing. The commit message should say emmet-language-server: init at 2.2.0 (without v)

@t4ccer Right! Fixed and pushed once again


.container-fluid inside .container

If I understand right http://getbootstrap.com/css/, there should be no nested .container or .container-fluid in the document. But the layout.html declares a .container, and the header.html a nested .container-fluid.
Also "Content should be placed within columns, and only columns may be immediate children of rows." Something like:
container
  row
    column
    column
  row
    column
    column

Is maybe Microscope not following exactly the Bootstrap way? (I'm not sure, still learning). I started a larger project based on Microscope, but it seems I have to change this part.

Looks like you're right, that .container-fluid div doesn't seem to be doing anything. We can probably remove it.
I don't think we use either .row or .column though.


indent level ignored

relevant piece of code here: https://github.com/NLeSC-Storyteller/query-builder-client/blob/0c9b59f14a78967d6ae1ce4ae020d31433367686/src/components/NodeRender.tsx#L44

looks like I just had an old version of data/entities, which did not have the (correct) level field.


Run Image as service on Docker UCP using VSTS docker compose task

Hello All,
Below is my requirement:

I have created a build definition in order to create and upload jar files to VSTS local machine
I have configured release definition task in VSTS to read the above jar file and build a docker image (using docker host service) and push the image to DTR (using docker registry service). I have been successful until this step. For docker host service i have used a build machine which has VSTS agent installed.
The main requirement is to connect to UCP machine from VSTS and run a docker compose file using docker compose task. I have created docker host service to UCP machine (On machine i have not installed VSTS agent)

Question:

For step3 to work should i install VSTS agent on UCP machine?
I tried an alternate of creating ssh service and then copying docker compose file over to UCP machine using "copy files over ssh task". But UCP doesn't seem to have docker-compose installed. So would this work if i install docker-compose on UCP machine?

Concerns:

Primary concern for installing VSTS agent or docker-compose on QA and later on in production is because it has docker images running. Until i am sure i cannot communicate the same to management :)

Is there any other alternative that people can suggest?  I need to run the image using docker compose file because i have some memory settings and java profiles set in docker-compose file
I know this is not an issue but any directions provided will help.
Sincerely,
Santosh

You should be able to set the Docker Host connection to use in the Docker Compose task. Then let the VSTS agent run the docker-compose CLI locally, but it targets the UCP machine.


wrong loop bound in ludcmp?

I was looking at the ludcmp implementation, and I don't understand this line:
https://github.com/wsmoses/Polygeist-Script/blob/d4aafd3e0c74967fdad11ee58cdd64aca9c84c61/polybench-c-4.2.1-beta/linear-algebra/solvers/ludcmp/ludcmp.polymer.in.mlir#L198
According to the map, the lower bound seems to correspond to %arg5 + %0, but in the C version instead it is for (j = i+1; j < _PB_N; j++) so it should just be %arg5 + 1 (or I am not able to read MLIR code, that is also possible).

Let's look at the broader context:
#map1 = affine_map<(d0)[s0] -> (-d0 + s0)>
    affine.for %arg5 = 0 to %0 {
      %2 = affine.load %arg4[-%arg5 + symbol(%0) - 1] : memref<?xf64>
      affine.store %2, %1[0] : memref<1xf64>
      affine.for %arg6 = #map1(%arg5)[%0] to %0 {

This corresponds to:
   for (i = _PB_N-1; i >=0; i--) {
     w = y[i];
     for (j = i+1; j < _PB_N; j++)

As MLIR doesn't support loops with negative step sizes, for the outermost loop, Polygeist iterates from the upper bound down to the lower bound.
We can see from the load in between the two for loops that this means that i corresponds to -%arg5 + symbol(%0) - 1 where %arg5 is between 0 to %0. At the first iteration, this means that i is equal to symbol(%0) - 1 and -(symbol(%0) - 1) + symbol(%0) - 1 = 0 at the final iteration, as intended.
Thus the lower bound of the inner loop should start at i+1 = (-%arg5 + symbol(%0) - 1) + 1 = -%arg5 + symbol(%0). If we loop at the lower bound map we see #map1 = affine_map<(d0)[s0] -> (-d0 + s0)> with d0=%arg5 and s0=%0. Plugging these in we find -%arg5+symbol(%0), which is indeed the correct answer!
Hope that helps!

Thank you! As I suspected, I am still not great at reading MLIR 😄


request: blacklist mode

I think it would be a good idea to add an optional blacklist mode instead of the current built-in whitelist mode. Basically, the addon would stop trying to look for possible redirects on every load except when the url matches a filter, and instead only look for a redirect on urls matching the given filters. This minimizes breakage on various sites (which are an unknown) and instead fixes redirects only on sites the (power)user decides to add to his list. The blacklist can simply be a list of the host sites' domains. The built-in whitelist that prevents known breakages could still be applied just to be sure.
I could try to write an implementation myself if you like.

I thought about this myself, but as I won't use it, I waited for a request before thinking about it.
But first of all, I think the notion is wrong, which was also one thing that confused me a lot with Redirect Cleaner. I consider the currently implemented mode as blacklist: skip for every page but the given exceptions. So to me it would be a whitelist mode you are suggesting: do not skip unless the url matches the given exceptions?
Would you agree that the choice between blacklist and whitelist mode is fundamental? I don't think it makes a lot of sense to switch often between the two as you could with Redirect Cleaner. I would start with the blacklist mode and when I see there are just too many problems/exceptions, I would switch over to whitelist mode. So I would not go the same way as redirect cleaner:

the toolbar button will always be enable/disable and not switching modes
the switch between blacklist/whitelist would be in the preferences
there would be only one list of exceptions that is used according to the mode

I would also not use the built in blacklist(login etc.). It's not a list of things that are certain to cause problems, but more of a guess. To me, the whitelist mode is about giving full control to the user. So whenever something doesn't work(as in it: redirects too much), it's the users problem.
What do you think?

But first of all, ...
Yes to this whole paragraph. The wording always gets me too, it's a matter of style really.

It doesn't make much sense to switch all the time indeed. You'd switch between modes very rarely or even only once.

the toolbar button will always be enable/disable and not switching modes
Yes
the switch between blacklist/whitelist would be in the preferences
Yes
there would be only one list of exceptions that is used according to the mode
Maybe, but rather not... I can see the point, but the user will essentially have 2 unrelated lists at hand: one for the current mode with exception filters, and the new one with a list of domains to work on. The two aren't interchangeable or similar at all, so it seems cleaner to keep them in different textboxes. When the user switches to the other mode to see if it works better, they don't have to lose their current list by replacing it with the other. Each mode just gets its own dedicated list so that switching back if need be is effortless.

I would also not use the built in blacklist(login etc.)
Yes and no. It is safer to leave it to the user entirely (what if one of your filters actually prevents it from working for them, for example?), but on the other hand it is convenient and saves time. The way I do this in one of my addons is to make a read-only pref field containing a built-in list the user can see and copy, with a switch to (de)activate it, and a second editable text field they can write their own filters in. They can either stick to default and enjoy no-frills "good enough" setup, or switch it off, copy the parts they need and customize to their liking. I made my own sdk module specifically for making this fancy pref field system easy.

I wished simple-prefs would just be a tiny bit more powerful(no way to reset to default value is really bugging me). If I could disable one of the lists depending on the mode, that would solve all my problems... This readonly field, how do you do that? Would you mind sharing this sdk module you mentioned?

A readonly pref is simply
prefs.on("prefName", pref => prefs.prefs[pref] = defaultValue);

The default value is also set on init by the code instead of package.json so it's all in one place with a const.
I use some "fancy"prefs in this addon:
https://addons.mozilla.org/en-US/firefox/addon/url-manager/
https://github.com/TheRealMarnes/url-manager
https://github.com/TheRealMarnes/url-manager/blob/master/src/lib/validate-prefs-1.0.2.js
https://github.com/TheRealMarnes/url-manager/blob/master/src/index.js#L60
usage:
const {validatePref} = require("./lib/validate-prefs-1.0.2.js");
// validatePref(x, y, z);
// x: pref name, y: true/false validity test, z: callback
validatePref("prefName", value => testValidity(value), (valid, value) => {
	if (valid) updateSettings(value);
});

It automatically sets a checkbox called <prefname>Valid to true and false based on the validity test on every edit.

```json
"preferences": [{
		"name": "removeValid",
		"title": "Valid removal list?",
		"type": "bool",
		"value": true
	},
	{
		"name": "remove",
		"title": "Removal list",
		"type": "string",
		"value": ""
	}]

I think just playing with that addon's prefs and reading the code will explain things a lot more than if I try to write it out :P

Now I remember what I felt like what I was forgetting in my last post: the callback for validatePref can also return a value that will overwrite the current pref. This lets you make a pref readonly as well:
validatePref("prefName", value => true, (valid, value) => defaultValue);

I just uploaded a new beta to https://addons.mozilla.org/en-US/firefox/addon/skip-redirect/ (Development Channel at the bottom). Would you mind having a look and letting me know how it goes?

Sorry, I stopped using firefox...

Fair enough. It's an embedded webextension today, but once released as a webextension, you should be able to use it in Chrome and others. I can let you know if you are interested...

Hmm, why not, thanks :)

Here you go: https://chrome.google.com/webstore/detail/skip-redirect/jaoafjdoijdconemdmodhbfpianehlon


Add JSON serialization target

The ability to write a protocol out at JSON could be useful for debugging, even if it is not well-suited for large streams of scientific data.

Implemented in #56


FAB-17943 Ch.Part.API: follower pulls blocks until join-block

Follower pulls blocks until join-block.
Type of change

New feature

Description
Join with a join-block number >0, onboarding is needed.
Start a follower that pulls blocks until the join-block, then mutates into an etcdraft.Chain or a follower.Chain.
The follower.Chain pulls blocks up to the join block, without inspecting intermediate config blocks.
After the join-block is pulled, the follower chain is stopped and either the CreateChain or CreateFollower function is invoked, depending on the channel membership indicated by the join-block.
Related issues
Task: FAB-17943
Epic: FAB-17712

I agree that opaque function pointers make it hard to read. I also prefer using well defined interfaces for the decoupling of cyclical dependencies. That is something I can easily improve. The reason I am using them right now is because I am mimicking some of the existing usage patterns, treating some of the components as "black boxes". As I learn the ropes around this area of the code more options come to mind and there is certainly room for improvement. Another area that I agree can be simplified is that the follower can transition from onboarding to following past the join-block with out recreating itself. It turned out this way because of the gradual layered approach to development - first add one functionality (onboarding) then the next (following past). I can harmonize between them for sure, but I prefer to do so after they are both in place. There is one additional PR following this one that completes the refactoring needed by the move from consensus/follower to common follower, and then refactoring the interaction patterns will be much easier.


FEAT_FAST_POLL explanation

I try to create a high throughput server, based on pool of io_uring instances. At some point, I realized that I need a better understanding of work io_uring with FEAT_FAST_POLL. I'm using perf and trying to read sources, but in fact that I'm a kernel newbie, so I don’t trust too much what I found out.
Would be great if some one validate my research, or maybe explain this mechanism (for example i try to call recv on socket):

Call io_uring_enter for submitting recv op
io_uring try to call nonblock recv:
2.1 if nonblock recv call successfull -> commit cqe
2.2 if result of nonblock recv is EAGAIN then try to poll events defined in io_op_defs. Go to io_uring_poll_arm and call vfs_poll:
2.2.1 if we immediately poll needed events we recreate sqe and submit cqe at next io_queue_sqes call
2.2.1 otherwise we put some poll-work at wait_queue, wait_queue handles by io_wq worker pool (at one of io_wqe_worker-x threads), and when we successfully poll events - we commit cqe.

Thanks!

It's correct up until that last one, which isn't:

2.2.1 otherwise we put some poll-work at wait_queue, wait_queue handles by io_wq worker pool (at one of io_wqe_worker-x threads), and when we successfully poll events - we commit cqe.

wait_queue is indeed armed, and when the event triggers, that issues the callback that will retry the operation. However, that is not handled by io-wq, it's handled by the original task itself, similar to how signals are processed. io-wq can come into play. That happens if we trigger this callback and the retry yet again gets -EAGAIN, we currently do not retry with the poll callback at that point. Instead the poll is not rearmed and the request is handed to io-wq.
That last part should be improved so we just retry with poll. Generally it shouldn't be a common occurrence, however.

Thanks! I.e. poll event handler is set on the thread that called io_uring_enter?

The poll handler runs directly from the context that triggers the event being "waited" on, and that callback handler in terms queues a task_work item with the task that called io_uring_enter to submit the original request.

It's correct up until that last one, which isn't:

2.2.1 otherwise we put some poll-work at wait_queue, wait_queue handles by io_wq worker pool (at one of io_wqe_worker-x threads), and when we successfully poll events - we commit cqe.

wait_queue is indeed armed, and when the event triggers, that issues the callback that will retry the operation. However, that is not handled by io-wq, it's handled by the original task itself, similar to how signals are processed. io-wq can come into play. That happens if we trigger this callback and the retry yet again gets -EAGAIN, we currently do not retry with the poll callback at that point. Instead the poll is not rearmed and the request is handed to io-wq.
That last part should be improved so we just retry with poll. Generally it shouldn't be a common occurrence, however.

Hi Jens, is there any concern that prevent us from the improvement?

Hi Jens, is there any concern that prevent us from the improvement?

Not really. The reason why I implemented it like that was to potentially avoid a case where we get repeated -EAGAIN when we retry, which would then just set us up for just doing repeated poll arm, poll trigger, retry loops. So I do think it needs to be gated somehow, but doing it on just the first retry failure after poll arm is most likely just a bit too cautious and will likely hit that condition for certain workloads.
Open to suggestions here. We do have a bit of space in io_poll_iocb so we could just add a counter for retries, using an unsigned char for that.

Another concern is thundering herd problem, IIRC as poll wakes all the queued callbacks, we don't want a scenario like:

enqueue N recv requests -> N goes to poll
poll triggers all N poll handlers, all N recvs retry, only 1 succeeds
we have N-1 requests polling
N=N-1, goto 1)

Certainly some implementation details to care about, thundering herd applies equally to once they have been io-wq offloaded.

I should be lighter I think, it's sitting blocking deeper in net stack, versus io_uring's poll+tw+retry etc., would be interesting to see what it is in reality. Anyway, queueing many recv requests for the same socket is probably not a common pattern, is it?

It's the same wakeup and io-wq are known to be sleeping, vs poll callback + tw trigger the task might already be running. So not sure I agree with it being less with io-wq, I'd think the opposite.

We also should be careful to not race. For example, make sure that __io_arm_poll_handler() would go to sleep right after vfs_poll() and following section under ->completion_lock doesn't see the second poll attempt.
                             | __io_arm_poll_handler()
                             | -> vfs_poll()
poll_callback()              |
retry io_recv()              |
another poll_callback()      |
                             | rest of __io_arm_poll_handler();

Sure, need to be careful about race and other problems. For this one, simply put the counter increment and counter check
at the beginning of io_arm_poll_handler() should be fine? Since io_arm_poll_handler() is called one by one:
                             | __io_arm_poll_handler()
                             | -> vfs_poll()
poll_callback()              |
retry io_recv()              |
->eagain?
-->arm_poll
--->counter overflow, failed
     |
                             | rest of __io_arm_poll_handler();

Certainly some implementation details to care about, thundering herd applies equally to once they have been io-wq offloaded.

Agree, and users should be able to know when to add EPOLLEXCLUSIVE to avoid it.
My question about this counter is how do we know the proper number of retry times, there is a great variety of use cases


Refresh v2 access token when email is removed from subscription

Task/Issue URL: https://app.asana.com/0/1205648422731273/1208883453990680/f
Description
This PR fixes a bug that puts subscription settings UI in an incorrect state after removing email from the subscription.
Steps to test this PR

[ ] Purchase (testing) subscription
[ ] Ensure there is an email added to the subscription
[ ] Go to app settings -> "Subscription Settings"
[ ] Tap "Remove Email"
[ ] Tap on the remove icon
[ ] Tap "Done" / go back to subscription settings
[ ] Verify that email address is no longer shown in settings

No UI changes

#5341  👈 (View in Graphite)
develop

This stack of pull requests is managed by Graphite. Learn more about stacking.


Fresh install will not play.

Will not play just sits and spins.

Screenshots of versions of relevant things.
This includes a screenshot showing RadiantPlayer failing to play and its version along with Yosemite and its version and Safari and its version.

If you need any more information please let me know and I can paste it.

Also note the strange white box in the first screenshot its not some strange method of me censoring something its just floating there.

Same problem here.

Same here. Floating white box and not playing.

Same here with OS X Yosemite 10.10.5.

Same here, OS X Yosemite 10.10.5

@chamunks, seems like that is probably due to #351. You'll either have to wait for @kbhomes to close #358 and/or release a new binary including the fix, or build it yourself from source (or trust someone else's build).

@ericnorris, you're right. thanks! I used the binary from @jacobwgillespie on #351 and that works fine. It's been merged in #358 so I guess compiling from that source should work too.

Yes I can confirm that one of the downloads from #351 linked works.  I am so happy to finally ditch having to run a browser 24/7 just to listen to music.  I really hope this gets merged asap.

I have the same exact issues on both 10.11 and 10.11.1. I have uninstalled and reinstalled both Flash and Radiant Player, but nothing seems to fix these issues.

Just switch to a fork thats maintained really.

Fixes for this and for El Capitan have landed in master but haven't been released yet.  I've pushed an update of my 1.4.0 build with the fixes to https://github.com/jacobwgillespie/radiant-player-mac/releases/tag/v1.4.0 if you're interested.  As before, update to 1.4.1 once it's out.  :)

Thanks for the help guys, Jacob I used your build and it works great. Good to be using this app again. Cheers.

1.4.1 has been released and should fix this issue - @chamunks, can you check and close if it's working?

Confirmed for me yes, it also works as promised on El Capitan.


South Migrations with PostgreSQLUUIDField Create CharField Incorrectly

The PostgreSQLUUIDField does not define it's own south_field_tripple() method and falls back to the one defined by UUIDField. Because of this, south migrations create these fields using a CharField type instead of a native UUID field type.

Django 1.6 support will be dropped in the next release so we can close this issue.


Develop

Merging the develop into master to update for the minimist fixes by Mikey.

Still have 4 low severity vulnerabilities according to npm audit on develop instance. Mike will look at and recommend next steps.

SO - this seemed to work - and at first glance, this seems like it really
isn't "Unsafe," it just fixes permissions issues when trying to run an
npx script.
root@MikesLaptop:/usr/src/Catalyst-AppVetting# npm install --unsafe-perm

<EMAIL_ADDRESS>preinstall /usr/src/Catalyst-AppVetting
npx npm-force-resolutions

npx: installed 5 in 5.583s
npm WARN optional SKIPPING OPTIONAL DEPENDENCY<EMAIL_ADDRESS>(node_modules/fsevents):
npm WARN notsup SKIPPING OPTIONAL DEPENDENCY: Unsupported platform for
<EMAIL_ADDRESS>wanted {"os":"darwin","arch":"any"} (current:
{"os":"linux","arch":"x64"})
added 3 packages from 1 contributor, updated 3 packages and audited 4945
packages in 15.057s
27 packages are looking for funding
run npm fund for details
found 0 vulnerabilities
root@MikesLaptop:/usr/src/Catalyst-AppVetting#
Mike Haines
503.781.1053
<EMAIL_ADDRESS>On Sat, Apr 18, 2020 at 12:49 PM Dan Dahle<EMAIL_ADDRESS>wrote:

Still have 4 low severity vulnerabilities according to npm audit on
develop instance. Mike will look at and recommend next steps.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/dandahle/Catalyst-AppVetting/pull/144#issuecomment-615934836,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AC4VDQKVBSUJPIZPOFF4XVLRNH753ANCNFSM4MLPHXXQ
.

Also this:
fsevents is always like this, I think....
root@MikesLaptop:/usr/src/Catalyst-AppVetting# npm ls minimist
<EMAIL_ADDRESS>/usr/src/Catalyst-AppVetting
├─┬<EMAIL_ADDRESS>│ ├─┬<EMAIL_ADDRESS>│ │ ├─┬<EMAIL_ADDRESS>│ │ │ ├──<EMAIL_ADDRESS>extraneous
│ │ │ └─┬<EMAIL_ADDRESS>│ │ │   └─┬<EMAIL_ADDRESS>│ │ │     └──<EMAIL_ADDRESS>invalid
│ │ ├──<EMAIL_ADDRESS>extraneous
│ │ └─┬<EMAIL_ADDRESS>│ │   └──<EMAIL_ADDRESS>invalid
│ ├─┬<EMAIL_ADDRESS>│ │ └─┬<EMAIL_ADDRESS>│ │   └─┬ UNMET OPTIONAL DEPENDENCY<EMAIL_ADDRESS>│ │     ├── UNMET DEPENDENCY<EMAIL_ADDRESS>│ │     └─┬ UNMET OPTIONAL DEPENDENCY<EMAIL_ADDRESS>│ │       ├─┬ UNMET OPTIONAL DEPENDENCY<EMAIL_ADDRESS>│ │       │ └── UNMET OPTIONAL DEPENDENCY<EMAIL_ADDRESS>│ │       └─┬ UNMET OPTIONAL DEPENDENCY<EMAIL_ADDRESS>│ │         └── UNMET OPTIONAL DEPENDENCY<EMAIL_ADDRESS>│ ├─┬<EMAIL_ADDRESS>│ │ └──<EMAIL_ADDRESS>│ ├─┬<EMAIL_ADDRESS>│ │ └──<EMAIL_ADDRESS>invalid
│ └─┬<EMAIL_ADDRESS>│   └──<EMAIL_ADDRESS>├─┬<EMAIL_ADDRESS>│ └─┬<EMAIL_ADDRESS>│   └──<EMAIL_ADDRESS>├──<EMAIL_ADDRESS>└─┬<EMAIL_ADDRESS>└─┬<EMAIL_ADDRESS>└─┬<EMAIL_ADDRESS>└─┬<EMAIL_ADDRESS>└──<EMAIL_ADDRESS>Mike Haines
503.781.1053
<EMAIL_ADDRESS>On Sat, Apr 18, 2020 at 4:42 PM Mike Haines<EMAIL_ADDRESS>wrote:

SO - this seemed to work - and at first glance, this seems like it really
isn't "Unsafe," it just fixes permissions issues when trying to run an
npx script.
root@MikesLaptop:/usr/src/Catalyst-AppVetting# npm install --unsafe-perm

<EMAIL_ADDRESS>preinstall /usr/src/Catalyst-AppVetting
npx npm-force-resolutions

npx: installed 5 in 5.583s
npm WARN optional SKIPPING OPTIONAL DEPENDENCY<EMAIL_ADDRESS>(node_modules/fsevents):
npm WARN notsup SKIPPING OPTIONAL DEPENDENCY: Unsupported platform for
<EMAIL_ADDRESS>wanted {"os":"darwin","arch":"any"} (current:
{"os":"linux","arch":"x64"})
added 3 packages from 1 contributor, updated 3 packages and audited 4945
packages in 15.057s
27 packages are looking for funding
run npm fund for details
found 0 vulnerabilities
root@MikesLaptop:/usr/src/Catalyst-AppVetting#
Mike Haines
503.781.1053
<EMAIL_ADDRESS>On Sat, Apr 18, 2020 at 12:49 PM Dan Dahle<EMAIL_ADDRESS>wrote:

Still have 4 low severity vulnerabilities according to npm audit on
develop instance. Mike will look at and recommend next steps.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/dandahle/Catalyst-AppVetting/pull/144#issuecomment-615934836,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AC4VDQKVBSUJPIZPOFF4XVLRNH753ANCNFSM4MLPHXXQ
.


fix: Fix browser search integration

Signed-off-by: Dmitriy Kunitskiy<EMAIL_ADDRESS>Summary of Changes
When testing https://github.com/amundsen-io/amundsen/pull/1746 from @kristenarmes, I made a mistake and did not verify it correctly. This PR fixes those earlier problems, namely:

opensearch.xml should come from a <link rel="search" ...> and not a script
the content-type should be set to application/xml
in XML, tags are case-sensitive. The webpack's asset minification lowercased all tags, which needed to be turned off.

Full admission: I got some help by following datahub.io/opensearch.xml. Thanks to our DataHub friends.
Tests

Documentation

CheckList
Make sure you have checked all steps below to ensure a timely review.

[ ] PR title addresses the issue accurately and concisely. Example: "Updates the version of Flask to v1.0.2"

In case you are adding a dependency, check if the license complies with the ASF 3rd Party License Policy.

[ ] PR includes a summary of changes.
[ ] PR adds unit tests, updates existing unit tests, OR documents why no test additions or modifications are needed.
[ ] In case of new functionality, my PR adds documentation that describes how to use it.

All the public functions and the classes in the PR contain docstrings that explain what it does

should update the doc on how to use it though

should update the doc on how to use it though

It should work OOTB if FRONTEND_BASE is set. I'll mention that somewhere though. Sec, I'll make a PR for that.


Not compelety show the attributes

Type: Performance Issue
Hi
When programing with HTML, writing an element, pressing enter, just the element will be written on my screen and not the attributes of that element.
EX:
what I get when writing img and pressing enter: <img
what I should get : <img scr="" alt="" >
P.S: I've just started coding as my very first experience.
VS Code version: Code 1.74.3 (97dec172d3256f8ca4bfb2143f3f76b503ca0534, 2023-01-09T16:59:02.252Z)
OS version: Windows_NT x64 10.0.19045
Modes:
Sandboxed: No

System Info

Item
Value

CPUs
Intel(R) Core(TM) i5-4210U CPU @ 1.70GHz (4 x 2394)

GPU Status
2d_canvas: enabledcanvas_oop_rasterization: disabled_offdirect_rendering_display_compositor: disabled_off_okgpu_compositing: enabledmultiple_raster_threads: enabled_onopengl: enabled_onrasterization: enabledraw_draw: disabled_off_okskia_renderer: enabled_onvideo_decode: enabledvideo_encode: enabledvulkan: disabled_offwebgl: enabledwebgl2: enabledwebgpu: disabled_off

Load (avg)
undefined

Memory (System)
15.94GB (12.24GB free)

Process Argv
--crash-reporter-id dd1ff4d0-5a46-441b-982b-23c70296bd62

Screen Reader
no

VM
0%

Process Info
CPU %	Mem MB	   PID	Process
    0	   103	  4856	code main
    0	   187	  1656	   window (● index.html - html - Visual Studio Code)
    2	    86	  6140	   issue-reporter
    0	   101	  6648	   shared-process
    0	    83	  8724	     fileWatcher
    0	    72	  8972	     ptyHost
    0	    39	  6768	   utility-network-service
    1	   139	  7000	   gpu-process
    0	   155	  8360	   extensionHost
    0	   110	  8272	     "C:\Users\Paniz\AppData\Local\Programs\Microsoft VS Code\Code.exe" --ms-enable-electron-run-as-node "c:\Users\Paniz\AppData\Local\Programs\Microsoft VS Code\resources\app\extensions\html-language-features\server\dist\node\htmlServerMain" --node-ipc --clientProcessId=8360
    0	    34	  9612	     C:\Users\Paniz\AppData\Local\Programs\Python\Python310\python.exe c:\Users\Paniz\.vscode\extensions\ms-python.python-2022.20.2\pythonFiles\run-jedi-language-server.py
    0	    10	  9620	       console-window-host (Windows internal process)
    0	    25	  9164	   crashpad-handler

Workspace Info
|  Window (● index.html - html - Visual Studio Code)
|    Folder (html): 5 files
|      File types: html(2) jpg(1)
|      Conf files:;

Extensions (12)

Extension
Author (truncated)
Version

vscode-html-css
ecm
1.13.1

prettier-vscode
esb
9.10.4

html-preview-vscode
geo
0.2.5

isort
ms-
2022.8.0

python
ms-
2022.20.2

jupyter
ms-
2022.11.1003412109

jupyter-keymap
ms-
1.0.0

jupyter-renderers
ms-
1.0.12

vscode-jupyter-cell-tags
ms-
0.1.6

vscode-jupyter-slideshow
ms-
0.1.5

LiveServer
rit
5.7.9

html5-boilerplate
sid
1.1.1

A/B Experiments
vsliv368:30146709
vsreu685:30147344
python383cf:30185419
vspor879:30202332
vspor708:30202333
vspor363:30204092
vslsvsres303:30308271
pythonvspyl392:30443607
vserr242:30382549
pythontb:30283811
vsjup518:30340749
pythonptprofiler:30281270
vshan820:30294714
vstes263:30335439
vscorecescf:30445987
pythondataviewer:30285071
vscod805cf:30301675
binariesv615:30325510
bridge0708:30335490
bridge0723:30353136
cmake_vspar411:30581797
vsaa593cf:30376535
pythonvs932:30410667
cppdebug:30492333
vsclangdc:30486549
c4g48928:30535728
dsvsc012:30540252
azure-dev_surveyone:30548225
vsccc:30610678
pyindex848cf:30577861
nodejswelcome1cf:30587006
282f8724:30602487
f6dab269:30613381
fim-prod:30623723
2i9eh265:30646982

It's not always clear which attributes should be added by default for a given element. That's why we leave this to the user.
Note that you can define snippets for common pattern.

This feature request is now a candidate for our backlog. The community has 60 days to upvote the issue. If it receives 20 upvotes we will move it to our backlog. If not, we will close it. To learn more about how we handle feature requests, please see our documentation.
Happy Coding!

This feature request has not yet received the 20 community upvotes it takes to make to our backlog. 10 days to go. To learn more about how we handle feature requests, please see our documentation.
Happy Coding!

:slightly_frowning_face: In the last 60 days, this feature request has received less than 20 community upvotes and we closed it. Still a big Thank You to you for taking the time to create this issue! To learn more about how we handle feature requests, please see our documentation.
Happy Coding!