Selfplay doesn't shutdown cleanly when remote model encounters an error

summary:
-- tpu trips
-- inference worker stops gracefully
-- pod remains running without resetting
inspecting the running pod reveals the process still running, perhaps waiting for a thread to join?
Expected behavior is for the cc binary to stop and let GKE take care of respawning the pod.

Oh... if the inference worker dies during inference, the c++ parent process
will just sit there waiting for a PutOutputs request. Probably the best
thing to do is to change the notification.WaitForNotification() call in
Inference client::RunMany to a WaitForNotificationWithTimeout. If the time
out triggers, we should kill the process. We should set the timeout quite
high (maybe 30s) because loading a new model takes some time.
On Fri, 13 Jul 2018, 12:50 Andrew Jackson<EMAIL_ADDRESS>wrote:

summary:
-- tpu trips
-- inference worker stops gracefully
-- pod remains running without resetting
inspecting the running pod reveals the process still running, perhaps
waiting for a thread to join?
Expected behavior is for the cc binary to stop and let GKE take care of
respawning the pod.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/tensorflow/minigo/issues/319, or mute the thread
https://github.com/notifications/unsubscribe-auth/AHPFxedPaDrsuSq3jbifZCwEcVhpMDaaks5uGPoKgaJpZM4VPbEa
.

Awesome, i'll do it!


null ref exception accessing results

We hit a null reference exception when we attempt to view results from the UI. I am moderately confident that the null reference exception takes place because we're returning a bunch of dummy objects when the compute was unsuccessful or one of the fancy getters can't find the requested object.
An optional class a la https://stackoverflow.com/questions/16199227/optional-return-in-c-net would probably be a permanent solution but require quite a bit of refactoring in the view model.
I think the solution appropriate for the rate at which we are developing would be to make sure that the dummy objects are populated with dummy data. I could not be sure precisely which object is causing this problem, so I'll do my best to configure all dummy objects.
We're going to need to make sure that the compute messaging is coming through clearly following this fix. It sounds like the bugs in Framework have been fixed? Results will be displayed though they will be nonsensical so it needs to be clear to the user that the results are nonsensical and why this is the case.

@codymccoy and I discussed not returning null impact area scenario results as part of the compute, but I don't think that will solve the problem. If get results is called on scenario results (and I think this is the case), a dummy impact area scenario results object will be returned, so we'd still hit the exception.

fleshing out the dummy results did not work.

FIXED!!!!!!


bump to encointer v0.8.0

[x] rename CoA fields: meetup_location_index -> meetup_index
[x] rename type: MeetupLocationIndex -> MeetupIndex`
[x] Implement logic to infer MeetupIndex client side.
[x] Option to claim issuance after meetup.

Closed by #268


Add more courses to the list of courses offered by a department

As of now the list of courses is not exhaustive. From what it shows, it only has the data on the courses offered in the current semester.

This sounds like a good idea!
While developing the DB, I was primarily concerned with the immediate requirements of the various apps and didn't find the motivation for storing the entire data.
Giving it a second thought, we can create new tables for storing semester based information such as courses, associated faculty members, and grades etc. We can populate these tables on a semester basis rather than pre-fetching them at once. It would be wonderful if we could use the data from the current semester for the new tables so that data integrity is maintained.
Do you have any particular requirements/suggestions/use-cases to share?


About Proxies

Can we use HTTPS ones also or only socks5 ? Thanks.

I'm sure you can, you need library that will create agent for you.
Google something like "nodejs https proxy agent" and look if it will work. It depends on libs.

http/https & socks4/5. they all work.


JSON files not found

Thank you for publishing a great job.
I am getting an error that the JSON files are not found. Where can I get these JSON files?

model_index.json

Traceback (most recent call last):
  File "/path/to/venv/vistadream/VistaDream/demo.py", line 7, in <module>
    vistadream()
  File "/path/to/venv/vistadream/VistaDream/pipe/c2f_recons.py", line 182, in __call__
    self._MCS_Refinement()
  File "/path/to/venv/vistadream/VistaDream/pipe/c2f_recons.py", line 149, in _MCS_Refinement
    refiner = HackSD_MCS(device='cuda',use_lcm=True,denoise_steps=self.mcs_iterations)
  File "/path/to/venv/vistadream/VistaDream/ops/mcs.py", line 33, in __init__
    self._load_model()
  File "/path/to/venv/vistadream/VistaDream/ops/mcs.py", line 39, in _load_model
    self.model = Hack_SDPipe_Stepwise.from_pretrained(self.sd_ckpt)
  File "/path/to/venv/vistadream/lib/python3.10/site-packages/huggingface_hub/utils/_validators.py", line 114, in _inner_fn
    return fn(*args, **kwargs)
  File "/path/to/venv/vistadream/lib/python3.10/site-packages/diffusers/pipelines/pipeline_utils.py", line 1117, in from_pretrained
    config_dict = cls.load_config(cached_folder)
  File "/path/to/venv/vistadream/lib/python3.10/site-packages/huggingface_hub/utils/_validators.py", line 114, in _inner_fn
    return fn(*args, **kwargs)
  File "/path/to/venv/vistadream/lib/python3.10/site-packages/diffusers/configuration_utils.py", line 370, in load_config
    raise EnvironmentError(
OSError: Error no file named model_index.json found in directory tools/StableDiffusion/ckpt.

preprocessor_config.json

Traceback (most recent call last):
  File "/path/to/venv/vistadream/VistaDream/demo.py", line 7, in <module>
    vistadream()
  File "/path/to/venv/vistadream/VistaDream/pipe/c2f_recons.py", line 182, in __call__
    self._MCS_Refinement()
  File "/path/to/venv/vistadream/VistaDream/pipe/c2f_recons.py", line 149, in _MCS_Refinement
    refiner = HackSD_MCS(device='cuda',use_lcm=True,denoise_steps=self.mcs_iterations)
  File "/path/to/venv/vistadream/VistaDream/ops/mcs.py", line 33, in __init__
    self._load_model()
  File "/path/to/venv/vistadream/VistaDream/ops/mcs.py", line 39, in _load_model
    self.model = Hack_SDPipe_Stepwise.from_pretrained(self.sd_ckpt)
  File "/path/to/venv/vistadream/lib/python3.10/site-packages/huggingface_hub/utils/_validators.py", line 114, in _inner_fn
    return fn(*args, **kwargs)
  File "/path/to/venv/vistadream/lib/python3.10/site-packages/diffusers/pipelines/pipeline_utils.py", line 1271, in from_pretrained
    loaded_sub_model = load_sub_model(
  File "/path/to/venv/vistadream/lib/python3.10/site-packages/diffusers/pipelines/pipeline_utils.py", line 528, in load_sub_model
    loaded_sub_model = load_method(cached_folder, **loading_kwargs)
  File "/path/to/venv/vistadream/lib/python3.10/site-packages/transformers/image_processing_base.py", line 206, in from_pretrained
    image_processor_dict, kwargs = cls.get_image_processor_dict(pretrained_model_name_or_path, **kwargs)
  File "/path/to/venv/vistadream/lib/python3.10/site-packages/transformers/image_processing_base.py", line 335, in get_image_processor_dict
    resolved_image_processor_file = cached_file(
  File "/path/to/venv/vistadream/lib/python3.10/site-packages/transformers/utils/hub.py", line 373, in cached_file
    raise EnvironmentError(
OSError: tools/StableDiffusion/ckpt does not appear to have a file named preprocessor_config.json. Checkout 'https://huggingface.co/tools/StableDiffusion/ckpt/tree/main' for available files.

Thank you for your quick response. I'll give it a try!

I did a git pull, placed the download file properly, and ran demo.py, which finished successfully and generated the following files!
$ find . -type f -ls | grep 'Oct 25'
 30160965     412 -rw-r--r--   1 users users     419478 Oct 25 00:13 ./data/sd_readingroom/video_dpt.mp4
 30160924  215928 -rw-r--r--   1 users users  221107092 Oct 25 00:12 ./data/sd_readingroom/scene.pth
 30160964     944 -rw-r--r--   1 users users     963279 Oct 25 00:13 ./data/sd_readingroom/video_rgb.mp4
$

Cool!

In order for demo.py to succeed, I had to execute the following command:
cd tools/DepthPro
pip install -e .
cd ..

pushd tools/OneFormer/oneformer/modeling/pixel_decoder/ops/
sh make.sh
popd


feat!: configurable concurrency per worker

This PR is a POC that introduce concurrency limitation per worker.
Instead of consuming & running all tasks in a queue, you can limit the number of fetched and thus concurrent running jobs. As we can found in celery
@geofmureithi Another way to achieve that is to change the Return of fn consume instead of returning JobStreamResult<T> we can return JobStreamResult<Vec<T>> this way we avoid the need for an extra parameter ie max_concurrent_jobs.
A worker will then fetch at most buffer_size jobs and run them directly and wait for all results thanks to fn join_all.

For short lived jobs you can then configure a high buffer_size, note today is theoretically infinite and may cause CPU/memory ressources issue
For long running jobs you can configure a buffer_size of 1 allowing to scale your application or the number of worker without starving them

Note: using a layer like GlobalConcurrencyLimitLayer or ConcurrencyLimitLayer is not enough:

since jobs are launched with fn spawn and are not awaited 1 job will be running BUT you'll continue to fetch the message queue.
So you'll have a worker running a job, and N fetched jobs waiting to be processed. This is not ideal when you want to scale the number of apps on a K8s cluster for instance, because your Scaler need to watch a message queue and it will be seen as empty because all jobs have been fetched then you Scaler will NOT trigger any scale up. :'(
Some situations requires to have a most 1 worker & 1 job running top per worker. For instance (this is my use case) you're using a GPU that cannot be shared accros workers of the same running app and you need to trigger a Gpu Node Scale up in order to scale your app on another machine etc etc ...

Hello @geofmureithi
any thoughts about this PR ? :)

@AzHicham Mark it as ready for review then I will review it before the end of the week.

Should be ready for review.
As said previously other implementation are possible this one comes with few code changes :)


bwDraco: Blacklist office-comsetup.com

bwDraco requests the blacklist of the keyword office-comsetup.com. See the Metasmoke search here

!!/approve


Add method and content options

This allows for example to support the POST method of CouchDB

As far as I can tell, these would be extensions, just like the headers extension.

To be explicit: the spec doesn't specify which method is used to request the event stream, so any method that returns text/event-stream would be valid in terms of the protocol.
However the API / interface does not seem to allow anything besides GET.

GET is the default one, so if it's not specified, then it will be GET only.

Why would you want to use an EventSource client to issue POST requests? It doesn't look like the CouchDB doc you linked to suggests using EventSource for anything else than consuming server-sent events. The POST part of the API should be used with a standard (non-EventSource) HTTP request (using a http client library such as fetch).

@aslakhellesoy The eventsource feed is data returned by the server, regardless of the method used to request it, the same way that you can get an HTML or a JSON response whether you use GET or POST to request it. In this specific case a selector-type request can only be submitted by using POST, and it will return an event-source stream if requested to do so.
@piranna I understand your viewpoint, thank you for your feedback!


How to exclude a website?

Hi,
I have a folder "./src/client/" which is an angular project.
I tried many ways to execute the dotnet test command but I always get the same error:

Solution file error MSB4249: Unable to build website project "client". The ASP.NET compiler is only available on the .NET Framework version of MSBuild.

Include only the test project.
dotnet test   /p:CollectCoverage=true   /p:CoverletOutputFormat=cobertura /p:Include="[My..tests?]"
Exclude folder client
dotnet test   /p:CollectCoverage=true   /p:CoverletOutputFormat=cobertura /p:ExcludeByFile="src/client/**"
How could I exclude the website project "client"?
Thanks

Hi Cedric,
I'm not sure that is an issue related to "coverlet". Coverlet doesn't build project but instrument artifacts generated by compilation(dlls) so I don't know if I can help, it seem something unrelated to instrumentation but related to build. Include/Exclude parameters are only used to include/skip file(dll) from instrumentation.
Let me know if I understood the problem or if you can provide a "small" repro with issue with and without coverlet(/p:CollectCoverage=true/false) could be very useful.

Close for stale conversation.
Feel free to re-open if needed.


Function to display authors + unit test

Function to display authors + unit test

Fixed in https://github.com/RedHatInsights/insights-results-aggregator-cleaner/pull/178


Does grid-item have to be a direct child of grid-layout?

My parent component:
            <grid-layout
                :layout.sync="layout"
                :col-num="12"
                :row-height="30"
                :is-draggable="true"
                :is-resizable="true"
                :is-mirrored="false"
                :vertical-compact="true"
                :margin="[10, 10]"
                :use-css-transforms="true"
            >
                <stats />
            </grid-layout>

Child component:
<template>
    <div>
        <grid-item
            :x="grid[0].x"
            :y="grid[0].y"
            :w="grid[0].w"
            :h="grid[0].h"
            :i="grid[0].i"
        >
            1
        </grid-item>
        <grid-item
            :x="grid[1].x"
            :y="grid[1].y"
            :w="grid[1].w"
            :h="grid[1].h"
            :i="grid[1].i"
        >
            2
        </grid-item>
   </div>
</template

This doesn't seem to be working though. Is this possible?

by default, it seems to be true due to the usage of this.$parent in GridItem.
In practice you should be able to get around it by implementing getters for all $parent occurences in GridItem.vue - basically passing them another level lower.
While this works from a technical perspective - it's very easy to break by small changes to this library, or by untested edge-cases - so i would not recommend using this in production.
  get colNum() {
    return this.$parent.colNum;
  }

  get rowHeight() {
    return this.$parent.rowHeight;
  }

  get maxRows() {
    return this.$parent.maxRows;
  }

  get isDraggable() {
    return this.$parent.isDraggable;
  }

  get isResizable() {
    return this.$parent.isResizable;
  }

  get useCssTransforms() {
    return this.$parent.useCssTransforms;
  }

  get isMirrored() {
    return this.$parent.isMirrored;
  }

grid-item needs to be a child of grid-layout


characters sliding when camera changes

Describe your problem here.
the characters are sliding whenever the camera switches and it doesnt look very good. this is only happening with the new stage i created, how would i fix this issue?
Are you modding a build from source or with Lua?
Lua
What is your build target?
Windows x64
Did you edit anything in this build? If so, mention or summarize your changes.
just added a custom stage

that's from the main game, maybe you'll need source to fix

i managed to solve it, i had to change the sprite scrolling to 1 on the ground sprite


i cant run

Hello, I added the code to the yaml file like in the document, but after restarting ha, I still have an error in the yaml file :)

You don’t need to add it from the UI. After adding it to the configuration.yaml and restarting, you should already have the service. To try it out go to the developer tools tab (or in any automation or script) search for the service gpt4vision.image_analyzer.
If it still doesn’t work, feel free to reopen this issue :)


capability to tell date type field and process accordingly

Hi @muriloecfaria,
This is a simple feature request, where same as in the inbuilt mongodb node, if we can declare the fields which should be considered as date type, it will be great.

Hi @muriloecfaria,
This is a simple feature request, where same as in the inbuilt mongodb node, if we can declare the fields which should be considered as date type, it will be great.

Hi @anantanandgupta,
Could you give me an example how this works in inbuilt mongodb node?

Hi @muriloecfaria,
This is a simple feature request, where same as in the inbuilt mongodb node, if we can declare the fields which should be considered as date type, it will be great.

Hi @anantanandgupta,
Could you give me an example how this works in inbuilt mongodb node?

Sure, give me tonight and in the morning will send you all the details you may need to implement this.
Thanks for responding i was about to start this from scratch as I was somehow found you code a bit unclear to enhance and create a pull request on top (sorry, please don't mind as everyone has a different way of coding).
give some time and I will be back.


null recommendation should be prioritized over nuint

Issue Description
nu suggestion defaults to nuint instead of null. This seems to have been fixed here giving it lower priority:
https://github.com/dotnet/roslyn/pull/44451
I cannot tell if that has made it into this extension or not yet, but it isn't working if it has. If it hasn't, when will it be brought over?
Steps to Reproduce
in C# code enter a statement like:
string foo = nu
Expected Behavior
null should be prioritized above nuint even though that would be alphabetically out of order.
Actual Behavior
autocomplete list pops up, nuint at the top and highlighted.
Environment information
VSCode version: 1.64.2
C# Extension: 1.24.0
Dotnet Information
.NET SDK (reflecting any global.json):
 Version:   6.0.101
 Commit:    ef49f6213a
Runtime Environment:
OS Name:     Windows
OS Version:  10.0.22000
OS Platform: Windows
RID:         win10-x64
Base Path:   C:\Program Files\dotnet\sdk\6.0.101\
Host (useful for support):
Version: 6.0.1
Commit:  3a25a7f1cc
.NET SDKs installed:
3.1.416 [C:\Program Files\dotnet\sdk]
5.0.211 [C:\Program Files\dotnet\sdk]
5.0.404 [C:\Program Files\dotnet\sdk]
5.0.405 [C:\Program Files\dotnet\sdk]
6.0.101 [C:\Program Files\dotnet\sdk]
.NET runtimes installed:
Microsoft.AspNetCore.All 2.1.30 [C:\Program Files\dotnet\shared\Microsoft.AspNetCore.All]
Microsoft.AspNetCore.App 2.1.30 [C:\Program Files\dotnet\shared\Microsoft.AspNetCore.App]
Microsoft.AspNetCore.App 3.1.22 [C:\Program Files\dotnet\shared\Microsoft.AspNetCore.App]
Microsoft.AspNetCore.App 5.0.13 [C:\Program Files\dotnet\shared\Microsoft.AspNetCore.App]
Microsoft.AspNetCore.App 5.0.14 [C:\Program Files\dotnet\shared\Microsoft.AspNetCore.App]
Microsoft.AspNetCore.App 6.0.1 [C:\Program Files\dotnet\shared\Microsoft.AspNetCore.App]
Microsoft.NETCore.App 2.1.30 [C:\Program Files\dotnet\shared\Microsoft.NETCore.App]
Microsoft.NETCore.App 3.1.22 [C:\Program Files\dotnet\shared\Microsoft.NETCore.App]
Microsoft.NETCore.App 5.0.8 [C:\Program Files\dotnet\shared\Microsoft.NETCore.App]
Microsoft.NETCore.App 5.0.13 [C:\Program Files\dotnet\shared\Microsoft.NETCore.App]
Microsoft.NETCore.App 5.0.14 [C:\Program Files\dotnet\shared\Microsoft.NETCore.App]
Microsoft.NETCore.App 6.0.1 [C:\Program Files\dotnet\shared\Microsoft.NETCore.App]
Microsoft.WindowsDesktop.App 3.1.22 [C:\Program Files\dotnet\shared\Microsoft.WindowsDesktop.App]
Microsoft.WindowsDesktop.App 5.0.8 [C:\Program Files\dotnet\shared\Microsoft.WindowsDesktop.App]
Microsoft.WindowsDesktop.App 5.0.13 [C:\Program Files\dotnet\shared\Microsoft.WindowsDesktop.App]
Microsoft.WindowsDesktop.App 5.0.14 [C:\Program Files\dotnet\shared\Microsoft.WindowsDesktop.App]
Microsoft.WindowsDesktop.App 6.0.1 [C:\Program Files\dotnet\shared\Microsoft.WindowsDesktop.App]
To install additional .NET runtimes or SDKs:
https://aka.ms/dotnet-download

Visual Studio Code Extensions

Extension
Author
Version

azure-account
ms-vscode
0.10.0

csharp
ms-dotnettools
1.24.0

hexeditor
ms-vscode
1.9.5

nsis
idleberg
3.48.0

remote-wsl
ms-vscode-remote
0.64.2

unity-debug
Unity
3.0.2

vscode-azureresourcegroups
ms-azuretools
0.4.0

vscode-azurestorage
ms-azuretools
0.13.0

vscode-eslint
dbaeumer
2.2.2

vscode-nuget-gallery
patcx
0.0.24

vscode-xml
redhat
0.19.1

It looks to me while Roslyn produces a MatchPriority for CompletionItems, OmniSharp-roslyn doesn't pass it on to OmniSharp-vscode. And vscode wouldn't be able to use it if OmniSharp-vscode had it as it only does sortText ordering? But that's just my naive looking at the pieces not understanding the codebase at all.

Added vscode feature request: https://github.com/microsoft/vscode/issues/144149

Added OmniSharp-roslyn feature request: https://github.com/OmniSharp/omnisharp-roslyn/issues/2350

Tag @CyrusNajmabadi in case the original roslyn author for nuint/null priority cares about this here.

Sounds reasonable to me for omnisharp to support this :)

This one really annoying me too. Most of the times I ended up with nuint instead of null.

Why does nuint even exist? If you need a platform specific integer type there's System.IntPtr and System.UIntPtr this alias -- given the fact that it always shows up before null -- is ultra annoying!

I've worked around it by adding this code snippet in File > Preferences > Configure user snippets, in the c# snippets add following:
	"null instead of nuint": {
		"prefix": "nu",
		"body": [
			"null"
		],
		"description": "fix nuint being selected when typing nu <tab> instead of much more popular null"
	}

Closing as this should be fixed in O#. See https://github.com/OmniSharp/omnisharp-roslyn/issues/2350


pico_add_extra_outputs doesn't follow RUNTIME_OUTPUT_DIRECTORY

I'm using a single CMake file for a multi-board project along with a libraries folder. This is what my main CMake File looks like:
cmake_minimum_required(VERSION 3.13)

# ---------- Setup  ----------
# to make sure stuff in the cmake folder can be located
set(CMAKE_MODULE_PATH ${CMAKE_MODULE_PATH} "${CMAKE_SOURCE_DIR}/cmake/")

# Importing the pico-sdk importer
set(PICO_SDK_FETCH_FROM_GIT on)
include(pico_sdk_import)

# General utility macros
include(util)

# Project
project(CMS_Avionics_Code)
pico_sdk_init()

set(stdlibs pico_stdlib hardware_gpio hardware_spi)

# To make sure build folder doesn't get cluttered
set(CMAKE_ARCHIVE_OUTPUT_DIRECTORY ${CMAKE_BINARY_DIR}/lib)
set(CMAKE_LIBRARY_OUTPUT_DIRECTORY ${CMAKE_BINARY_DIR}/lib)

# ---------- Libraries  ----------
subdirlist(libs ${CMAKE_SOURCE_DIR}/lib)

foreach(libname ${libs})
    file(GLOB_RECURSE srcs ${CMAKE_SOURCE_DIR}/lib/${libname}/*.c)
    file(GLOB_RECURSE hdrs ${CMAKE_SOURCE_DIR}/lib/${libname}/*.h)

    add_library(${libname} ${srcs} ${hdrs})
    target_link_libraries(${libname} ${stdlibs})

    target_include_directories(${libname} PUBLIC ${CMAKE_SOURCE_DIR}/lib/${libname})
endforeach()

# # ---------- Boards  ----------
set(boards
    emu
)

foreach(board ${boards})
    file(GLOB_RECURSE srcs ${CMAKE_SOURCE_DIR}/${board}/*.c)
    file(GLOB_RECURSE hdrs ${CMAKE_SOURCE_DIR}/${board}/*.h)

    add_executable(${board} ${srcs} ${hdrs})
    target_link_libraries(${board} ${stdlibs} ${libs})

    pico_enable_stdio_usb(${board} 1)
    pico_enable_stdio_uart(${board} 0)

    pico_add_extra_outputs(${board})

    set_target_properties(${board}
        PROPERTIES

        ARCHIVE_OUTPUT_DIRECTORY ${CMAKE_BINARY_DIR}/${board}
        LIBRARY_OUTPUT_DIRECTORY ${CMAKE_BINARY_DIR}/${board}
        RUNTIME_OUTPUT_DIRECTORY ${CMAKE_BINARY_DIR}/${board}
    )
endforeach()

Then I run the following commands to build
cd build
cmake ..
make

However, only the .elf file for emu is present in <project-root>/build/emu, and the rest of the extra output files(.hex, .uf2, etc.) are present in <project-root>/build/
I am new to CMake, so I am not sure if I am doing something wrong. I'm opening this issue because it seems to be specific to the pico_add_extra_outputs function.

@kilograham Saw you on the Git Blame so I'm pinging you here.

@lurch ? Is this the wrong place to ask this question

Nope, this is the right place to ask the question, but we're all very busy and so can't always reply immediately to every single GitHub issue.
For more "general" questions you can ask at https://forums.raspberrypi.com/viewforum.php?f=143 where you're more likely to get a quicker reply.

merged into develop


Create a performance guide

PR #130 adds an skeleton for a performance guide about how to write efficient code with the library.
This issue is for discussing anything related to it.

I'd personally like the performance guide to contain most of what one needs to know to write "resonably performant" code using this library. One advantage of it is that one doesn't necessarily need to use core::arch with it, so I would prefer if people wouldn't have to read the core::arch docs or the rustc book. I would prefer it to be self-contained, at least initially, although I think its a good idea to link to those resources when there is overlap.
Once we more or less have "everything we want to say" already written in some form, refactoring that across documentation sources and removing things from here is not that much extra work.

I also believe in a more Rust-by-example style.

I think that style is fine for some parts of the guide. As a reference, ISPC has a performance guide that follows this style in some places, but diverges into a different style in others.
https://ispc.github.io/perfguide.html
The parts about features that one needs to know (e.g. RUSTFLAGS, #[target_feature], etc.) I'd like to keep them as dry and short as possible, while still containing the most important bits that one must know, pointing people to the relevant documentation.

We shouldn't write its documentation, just use it in the sample code as a practical example.

Many people don't know that some things actually exist, particularly when they are not documented in the book, and their documentation is spread through the library. For example, this is currently a doc bug, but once its fixed, you will find run-time feature documentation in std::arch, but not in core::arch because there is no run-time feature detection in core (currently this part of the docs is incorrect, but oh well).
The parts that show how to use those to write performant code can follow a Rust-by-example style.

@GabrielMajeri do you want to be a co-maintainer of this crate ? (are you on IRC?)

Try to switch to something like mdBook, and try setting up publishing to rust-lang-nursery.github.io

Good idea. This is now merged and up :)

I've an idea of what to write in an introduction to people who haven't heard (a lot) about SIMD before but want to write performant Rust programs. The idea is to explain why SIMD is faster, and help determine when it isn't faster.

The RFC also has an introduction to this, maybe we can reuse some stuff from there. I'd rather focus on this section at the very end though. Let's assume for now that whoever is trying to use this library has determined that its problem is suited for SIMD and just wants to use this library "properly".

The current vertical vs horizontal operations could be greatly expanded by adding a section on "how to verticalize some algorithms". Examples such as

That's a great idea. Currently the examples we have are just code, but because we also use them for benchmarks, it can be pretty steep to dive in, if one wants to use them to learn the library. Maybe we could have some sections about the code explaining how the different algorithms in the examples were "verticalized".

I think we should also add a section to the perf-guide to at least point users to the tools and methodology that can help them know if "they have done things right". That is, basic roofline analysis for their particular CPU (e.g. how to do the calculation for the sum_slice kernel or dot_product), how to obtain a rough performance ball park for their algorithm. How to obtain the assembly or llvm-ir of their algorithm (e.g. cargo asm, cargo llvm-ir, godbolt, playground, etc.), how to estimate the performance of the assembly for a particular architecture (e.g. IACA, LLVM MCA, etc.). How to fill in a performance bug ? (e.g. which code they wrote, which assembly they would expect, which assembly and llvm-ir they got, etc.).


VS Code Extension Installation Action Run

Is there a specific GitHub action run you would currently recommend for installing the vs code extension?

Pre-built editors are downloadable from the artifacts section of each GitHub Action run

Yeah, good question, looks like we've got a problem here.
There's a large swath of commits that didn't get uploaded, because almost immediately upon claiming that in our README, I started getting these:

Dealing with this is now #28.

That said -
(a) The head of tree (main) is your best bet, now and for the near-term.
(b) Any action here https://github.com/Vlsir/Hdl21Schematics/actions that has a green check-mark, has the binaries built and uploaded. (Uploading them is one of the CI checks.)
(c) The current head https://github.com/Vlsir/Hdl21Schematics/actions/runs/3622679170 is one such commit!
But as noted at the end of #28, I'm also awfully suspicious that it's generating such a teeny-tiny VSIX extension-file. Downloading and installing from that artifacts page works on my system, but I worry it background-relies on other system-installed stuff.
Give that a spin, I'd love to hear how it goes. If it doesn't work you'll need to build from source, which I promise is not much harder.

Unfortunately, I couldn't find any artifacts attached to that.
If you can see them, maybe I just don't have permission to see the Action's artifacts.

When I get a chance I'll try building it myself.

OK yeah permissions, that's another good point. We'll see if we can open those up, or it'll effect the utility of the GitHub-based distribution.
Sorry the pre-built stuff hasn't been as advertised. Early days here. The from-source build should go as advertised, which is to say quite quickly.
Especially on MacOS, where all the web-folk work. And nearly as quickly on Ubuntu-ish Linuxes. And if it's Windows, well I don't have Windows, but they say it works well there too. On CI Windows it seems to work great.


Revert "add example for node."

Reverts chaosblade-io/chaosblade-operator#67
//Temporarily canceled for overall optimization and reconstruction.
先回撤，需要重新整理下。谢谢。

@tiny-x


Prepare for a pogrammatic interface

Right now, there's only a CLI tool. There should be a way to programmatically control api-pls.
For instance,
const apiPls = require('api-pls');

apiPls.doSomething();

These are the steps I need to do this:

[x] Make the CLI call out to things in "util"
[x] Rename "util" to "lib"
[ ] Update libs to emit custom events, so that the CLIs can log proper messages
[x] Move "index.js" into server
[x] Create a new "index.js" as the entryway to the programmatic interface

This has the added benefit of enabling me to more easily run migrations from within the tests.

Gonna mark as done.


ANSIBLE_ROLES_PATH path component relative to the previous one

Issue Type

Bug report

Molecule and Ansible details
ansible --version = ansible <IP_ADDRESS>
molecule --version =  version 2.3.1

Molecule installation method: pip
Ansible installation method: pip

Desired Behaviour
ANSIBLE_ROLES_PATH: roles:../../../infrastructure/roles:../../../postfix/roles:../../../bind/roles
Each path component is relative to a fixed directory
Actual Behaviour (Bug report only)
ANSIBLE_ROLES_PATH: roles:../../../infrastructure/roles:../postfix/roles:../bind/roles
When converted to absolute directory, each path component is evaluated relative to the directory name of the previous path component.

Thanks @dachary


Adding JCenter to resolvers doesn't work

steps
resolvers += Resolver.jcenterRepo

problem
externalResolvers doesn't contain JCenter:
> show externalResolvers
[info] ArrayBuffer(
  FileRepository(local,FileConfiguration(true,None),Patterns(ivyPatterns=List(${ivy.home}/local/[organisation]/[module]/(scala_[scalaVersion]/)(sbt_[sbtVersion]/)[revision]/[type]s/[artifact](-[classifier]).[ext]), artifactPatterns=List(${ivy.home}/local/[organisation]/[module]/(scala_[scalaVersion]/)(sbt_[sbtVersion]/)[revision]/[type]s/[artifact](-[classifier]).[ext]), isMavenCompatible=false, descriptorOptional=false, skipConsistencyCheck=false)),
  public: https://repo1.maven.org/maven2/,
  public: https://repo1.maven.org/maven2/
)

expectation
externalResolvers shouldn't remove from resolvers
notes

https://github.com/sbt/sbt/blob/v0.13.10/ivy/src/main/scala/sbt/Resolver.scala#L247-L249
#2335

The problem is that the JCenter can slip in from our launcher's repository list. So removing JCenter is intentional design unless your solution can distinguish between what's been added by the launcher vs human.

I'd be happy with a solution that does that distinction. Do you know how to do that?

https://github.com/sbt/sbt/blob/0.13.10/main/src/main/scala/sbt/Defaults.scala#L1148-L1153:
    externalResolvers <<= (externalResolvers.task.?, resolvers, appResolvers, useJCenter) {
      case (Some(delegated), Seq(), _, _) => delegated
      case (_, rs, Some(ars), uj)         => task { ars ++ Resolver.reorganizeAppResolvers(rs, uj, true) }
      case (_, rs, _, uj)                 => task { Resolver.withDefaultResolvers(rs, uj) }
    },
    appResolvers <<= appConfiguration apply appRepositories,

Doesn't appResolvers come from the launcher configuration? I think we need to filter things there.

Given that the method I added is called reorganizeAppResolvers maybe I was thinking about filtering things from ars, but somehow I messed up or forgot, it seems.

Solved in #2467


Add Asher college

Add Asher College, for asher.edu emails.

@jacksonlevine Thank you for your patience while waiting for a review and processing your request. Pull request merged. Please start applying for JetBrains educational subscription at https://www.jetbrains.com/shop/eform/students in an hour, to allow the changes to propagate through JetBrains systems.


Scrolling Object collection prefab Mask disabled by default

Describe the bug
The scrolling object prefab for MRTK v2.5 does not have Mask enabled by default
To reproduce
drag  the Assets/Samples/Mixed Reality Toolkit Examples/2.5.0/Demos - ScrollingObjectCollection/Prefabs/ScrollingOC_Objects_Plated32x32.prefab into the scene the clipping box will not be enable by default.
Expected behavior
have the prefab ready to go with the Mask enabled
Screenshots
If applicable, add screenshots to help explain your problem.
Your setup (please complete the following information)

Unity Version 2019.4.24f1
MRTK Version 2.5

Target platform (please complete the following information)

HoloLens 2

@MaxWang-MS Do you know the reason this setting is set this way by default, from your SOC investigations?

@keveleigh I don't see any obvious reason why the mask is disabled by default, and agree it should be on. But since changing the prefab affects existing projects, do you see us making this breaking change?

We appreciate your feedback and thank you for reporting this issue.
Microsoft Mixed Reality Toolkit version 2 (MRTK2) is currently in limited support. This means that Microsoft is only fixing high priority security issues. Unfortunately, this issue does not meet the necessary priority and will be closed. If you strongly feel that this issue deserves more attention, please open a new issue and explain why it is important.
Microsoft recommends that all new HoloLens 2 Unity applications use MRTK3 instead of MRTK2.
Please note that MRTK3 was released in August 2023. It features an all new architecture for developing rich mixed reality experiences and has a minimum requirement of Unity 2021.3 LTS. For more information about MRTK3, please visithttps://www.mixedrealitytoolkit.org.
Thank you for your continued support of the Mixed Reality Toolkit!


it is not possibel to remove pluvia on ubuntu using ubuntu software

It however is possible to install it using ubuntu software

fixed after ubuntu update


Refactor: remove global package vars

What type of PR is this?
/kind cleanup

What this PR does / why we need it:
Which issue(s) this PR fixes:
Fixes #288
Special notes for your reviewer:
This is a large patch remove all global package vars to make kmesh more golang authentic
Does this PR introduce a user-facing change?:

/lgtm
/approve


[Question] Video/ Custom data loading

Hi! Thank you so much for the nicely written paper and clean implementation!
I was wondering if there is a way to load a few frames without having any pre-existing gallery with its corresponding targets that contain the box coordinates and labels. Would the network be able to cut the people out of said frames and eventually re-identify them a few frames later?

I'm not sure what your question means. Do you mean you want to find a specific probe person appearing in the first frame among the later frames? If so, you just detect and extract embeddings for all persons within the later frames using these codes by changing the gallery loader. Then extract the embedding for the probe person using these codes and calculate the cosine similarity between probe embedding and detected embeddings.


fix(hermes): change logic in build scripts for Apple to use the right version

Summary

Within the hermes-engine.podspec contained in the RN repo (at react-native/main/sdks/hermes-engine/), there's a bit of logic that triggers ./utils/build-ios-framework.sh and ./utils/build-mac-framework.sh .
The issue is that we all thought that that  ./utils/build-ios-framework.sh would invoke the React native version of the scripts (since the podspec file lives right next to the utils folder) but, in reality, it doesn't. It just so happens that the Hermes repo has a root level utils folder which is (you guessed it) where the Hermes variation of those build scripts live.
So, when running the pod install command in a react-native project (build from source), it will go and download the hermes source code (since the source[:git] gets set) but then it will use the hermes variation of the build-*.sh scripts.
Read more here.
Changelog

[Fixed] [iOS] -  Change hermes logic in build scripts for Apple to use the correct files
Test Plan
Tested by @kudo in his work, and in my PR locally - see here.

Code looks fine on my end 👍 @cipolleschi has more context than me on this change

@kelset @Kudo I updated the script with your suggestions (and a bit of refactoring). Can you give it a shot and see if it works properly for you (hoping that the CI does not break!)

Thanks @Kudo, I should have fixed those! :D


Can't build on latest ArchLinux

yay -q -S --needed --noconfirm zeronsd
............
Compiling zeronsd v0.3.1 (/tmp/makepkg/zeronsd/src/zeronsd-0.3.1)
Finished release [optimized] target(s) in 2m 22s
==> Starting check()...
Compiling zeronsd v0.3.1 (/tmp/makepkg/zeronsd/src/zeronsd-0.3.1)
Finished release [optimized] target(s) in 30.55s
Running unittests (target/release/deps/zeronsd-bcc0a7999e667f66)
running 9 tests
test tests::test_domain_or_default ... ok
test tests::test_central_token_panic - should panic ... ok
test tests::test_central_token ... ok
test tests::test_parse_ip_from_cidr ... ok
test tests::test_supervise_systemd_green ... ok
test tests::test_supervise_systemd_red ... ok
test tests::test_parse_hosts_duplicate ... ok
test tests::test_parse_hosts ... ok
test tests::test_parse_member_name ... ok
test result: ok. 9 passed; 0 failed; 0 ignored; 0 measured; 0 filtered out; finished in 0.08s
Running unittests (target/release/deps/zeronsd-7c058f527eafd345)
running 0 tests
test result: ok. 0 passed; 0 failed; 0 ignored; 0 measured; 0 filtered out; finished in 0.00s
Running tests/integration.rs (target/release/deps/integration-122264a811ad5c18)
running 14 tests
test sixplane::test_battery_single_domain_named ... FAILED
test sixplane::test_battery_single_domain ... FAILED
test all::test_hosts_file_reloading ... FAILED
test ipv4::test_battery_single_domain_named ... FAILED
test sixplane::test_battery_multi_domain_hosts_file ... FAILED
test rfc4193::test_battery_single_domain_named ... FAILED
test rfc4193::test_wildcard_central ... FAILED
test ipv4::test_battery_single_domain ... FAILED
test rfc4193::test_battery_single_domain ... FAILED
test ipv4::test_wildcard_central ... FAILED
test test_get_listen_ip ... FAILED
test rfc4193::test_battery_multi_domain_hosts_file ... FAILED
test all::test_battery_multi_domain_hosts_file ... FAILED
test sixplane::test_wildcard_central ... FAILED
failures:
---- sixplane::test_battery_single_domain_named stdout ----
thread 'sixplane::test_battery_single_domain_named' panicked at 'Please provide TOKEN in the environment: NotPresent', tests/service.rs:189:44
note: run with RUST_BACKTRACE=1 environment variable to display a backtrace
---- sixplane::test_battery_single_domain stdout ----
thread 'sixplane::test_battery_single_domain' panicked at 'Please provide TOKEN in the environment: NotPresent', tests/service.rs:189:44
---- all::test_hosts_file_reloading stdout ----
thread 'all::test_hosts_file_reloading' panicked at 'Please provide TOKEN in the environment: NotPresent', tests/service.rs:189:44
---- ipv4::test_battery_single_domain_named stdout ----
thread 'ipv4::test_battery_single_domain_named' panicked at 'Please provide TOKEN in the environment: NotPresent', tests/service.rs:189:44
---- sixplane::test_battery_multi_domain_hosts_file stdout ----
thread 'sixplane::test_battery_multi_domain_hosts_file' panicked at 'Please provide TOKEN in the environment: NotPresent', tests/service.rs:189:44
---- rfc4193::test_battery_single_domain_named stdout ----
thread 'rfc4193::test_battery_single_domain_named' panicked at 'Please provide TOKEN in the environment: NotPresent', tests/service.rs:189:44
---- rfc4193::test_wildcard_central stdout ----
thread 'rfc4193::test_wildcard_central' panicked at 'Please provide TOKEN in the environment: NotPresent', tests/service.rs:189:44
---- ipv4::test_battery_single_domain stdout ----
thread 'ipv4::test_battery_single_domain' panicked at 'Please provide TOKEN in the environment: NotPresent', tests/service.rs:189:44
---- rfc4193::test_battery_single_domain stdout ----
thread 'rfc4193::test_battery_single_domain' panicked at 'Please provide TOKEN in the environment: NotPresent', tests/service.rs:189:44
---- ipv4::test_wildcard_central stdout ----
thread 'ipv4::test_wildcard_central' panicked at 'Please provide TOKEN in the environment: NotPresent', tests/service.rs:189:44
---- test_get_listen_ip stdout ----
thread 'test_get_listen_ip' panicked at 'Please provide TOKEN in the environment: NotPresent', tests/service.rs:189:44
---- rfc4193::test_battery_multi_domain_hosts_file stdout ----
thread 'rfc4193::test_battery_multi_domain_hosts_file' panicked at 'Please provide TOKEN in the environment: NotPresent', tests/service.rs:189:44
---- all::test_battery_multi_domain_hosts_file stdout ----
thread 'all::test_battery_multi_domain_hosts_file' panicked at 'Please provide TOKEN in the environment: NotPresent', tests/service.rs:189:44
---- sixplane::test_wildcard_central stdout ----
thread 'sixplane::test_wildcard_central' panicked at 'Please provide TOKEN in the environment: NotPresent', tests/service.rs:189:44
failures:
all::test_battery_multi_domain_hosts_file
all::test_hosts_file_reloading
ipv4::test_battery_single_domain
ipv4::test_battery_single_domain_named
ipv4::test_wildcard_central
rfc4193::test_battery_multi_domain_hosts_file
rfc4193::test_battery_single_domain
rfc4193::test_battery_single_domain_named
rfc4193::test_wildcard_central
sixplane::test_battery_multi_domain_hosts_file
sixplane::test_battery_single_domain
sixplane::test_battery_single_domain_named
sixplane::test_wildcard_central
test_get_listen_ip
test result: FAILED. 0 passed; 14 failed; 0 ignored; 0 measured; 0 filtered out; finished in 0.09s
error: test failed, to rerun pass '--test integration'
==> ERROR: A failure occurred in check().
Aborting...
-> error making: zeronsd
/pub/Linux/ArchLinux/zetis/bin/install/zeronsd 1465.86s user 49.19s system 808% cpu 3:07.45 total
1 stud@e0 ~ % cat /etc/os-release
NAME="Arch Linux"
PRETTY_NAME="Arch Linux"
ID=arch
BUILD_ID=rolling
ANSI_COLOR="38;2;23;147;209"
HOME_URL="https://archlinux.org/"
DOCUMENTATION_URL="https://wiki.archlinux.org/"
SUPPORT_URL="https://bbs.archlinux.org/"
BUG_REPORT_URL="https://bugs.archlinux.org/"
LOGO=archlinux-logo
IMAGE_ID=aui-console
IMAGE_VERSION=linux_5_16_15-0318
stud@e0 ~ % yay
:: Synchronizing package databases...
core is up to date
extra is up to date
community is up to date
:: Starting full system upgrade...
there is nothing to do
:: Searching databases for updates...
:: Searching AUR for updates...
-> Flagged Out Of Date AUR Packages: icdiff
there is nothing to d

Issue should probably be raised over here  as this is where the Arch AUR integration & scripting is done.

@devvick maintains these packages and may want to weigh in here; let's leave this open for now.

Nobody should need to run the integration tests on package build fwiw.

Build should be fixed now. Although I'm not an expert on Rust, so I'd appreciate any PRs if the PKGBUILD is still inadequate:
https://github.com/devvick/PKGBUILDs/blob/main/zeronsd/PKGBUILD

I'll be sure to look tonight. Thanks for looking into this!

should do it; just make sure it's not running the tests in the tests/ dir and you should be good.
@ato2 if you'd like to confirm, that'd be really great. I'll close this ticket tomorrow if I don't hear back.

closing this as I think it's resolved. Please feel free to open if you feel otherwise, @ato2.


Light and dark mode for user satisfaction

Currently the users can only use the web-app in light mode. To enhance user experience, we can add a night mode option.
Describe the solution you'd like
I want to add a light/dark mode toggle feature. This feature would allow users to switch between light and dark themes based on their preference or the ambient lighting conditions.
Additional context
This is under GSSOC'2024 Contribuition

The dark mode is present. Is it not working?
There is toggle button in the right bottom corner


Fix examples after naming convention change.

Naming convention for base class methods was corrected in recent PR. Old example files need to be updated to reflect this change.

This was addressed.


Update Tinkerbell favicon

tinkerbell.org has a favicon. docs.tinkerbell.org does not have a favicon.
I would like docs.tinkerbell.org to have the same favicon as tinkerbell.org.
Expected Behaviour
See above
Current Behaviour
See above
Possible Solution
See above
Steps to Reproduce (for bugs)

Open tinkerbell.org in a browser
Open docs.tinkerbell.org in a browser

Context
See above
Your Environment
n/a

@ronggur Can you assist with the above?

I guess this is for docs. right? I made the new issue here.
Since we're already here, can @geriadam update using the better one? (transparent, also same version as attached here)
Thanks.
16dfade641c40f1233385cc5b81b83ef.ico.zip

Yep, this is for docs "docs.tinkerbell.org does not have a favicon."


Fix/ugly

Coverage decreased (-0.8%) to 49.433% when pulling ca06c4c252c21f1e8d4d74fa91c39640d9e2a83b on fix/ugly into a16666ddac77316054bc720788a75f1339606d27 on master.


Better feedback when angular-templates get stuck

Relates to this closed issue: https://github.com/ericclemmons/grunt-angular-templates/issues/112
Please add better output information of what is happening. Now it is impossible to debugg.

@eduardoinnorway see my comment on #112 , we are outputting everything we have control over, but the hang occurs inside of html-minifier so we aren't able to provide more detail. Using --verbose along with https://github.com/praveenvijayan/grunt-html-validation or https://github.com/htmllint/grunt-htmllint should help you track down the problem.


entitlement.actions.(hosts/ports) from List to Set

both fields have unique element restrictions enforced by the API

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

Hi! this change wont work out-of-the-box, but I've cherry-picked your commit and added the necessary changes for this behavior in #110
I will close this PR, but these changes will be included in the next release.


Hello, what is the data storage period of apm?

Hi @shijg
Data retention period is dictated by Hbase's TTL.


Improve runtime

The runtime has increased quite a bi in the last few days. In order to check new results a bit faster, it would be good if we can speed it up a bit again.
I can see the following reasons / what we can do about it:

We run the analysis twice for IgG and IgA now. I don't think there's much we can do about this, apart from optimising the analysis code a bit.
The background computation got a bit more involved, and it looks like this actually takes quite some time now too, but I haven't measured it properly.
We still write the "summary images" in the CellLevelAnalysis job. I am not sure this is really necessary, if we can deactivate we can gain 2 x 15 minutes.

I can look into this once #94 is merged, but need to discuss with @imagirom first.

The background computation got a bit more involved, and it looks like this actually takes quite some time now too, but I haven't measured it properly.

Yeah, the median over all bg pixel values on the cpu is the expensive part here.

Another thing I noted is that there are a couple of results that are always recomputed, even if everything should be there already. @imagirom have you set force_recompute=True somewhere?
Otherwise the validation is not working properly ...

@imagirom have you set force_recompute=True somewhere?

Not knowingly, I will check in cell_analyis.py.
@constantinpape Could you later post the runtime of the individual jobs?

@constantinpape Could you later post the runtime of the individual jobs?

Yes, I will add this more explicitly to the logs and then post a log.


[e2e]: generic push main default slsa3

Repo: https://github.com/slsa-framework/example-package/tree/main
Run: https://github.com/slsa-framework/example-package/actions/runs/11511154159
Workflow file: https://github.com/slsa-framework/example-package/tree/main/.github/workflows/e2e.generic.push.main.default.slsa3.yml
Workflow runs: https://github.com/slsa-framework/example-package/actions/workflows/e2e.generic.push.main.default.slsa3.yml
Trigger: push
Branch: main
Date: Fri Oct 25 03:13:48 UTC 2024

Repo: https://github.com/slsa-framework/example-package/tree/main
Run: https://github.com/slsa-framework/example-package/actions/runs/11528380742
Workflow file: https://github.com/slsa-framework/example-package/tree/main/.github/workflows/e2e.generic.push.main.default.slsa3.yml
Workflow runs: https://github.com/slsa-framework/example-package/actions/workflows/e2e.generic.push.main.default.slsa3.yml
Trigger: push
Branch: main
Date: Sat Oct 26 03:10:24 UTC 2024
Tests are passing now. Closing this issue.


Add positions utilities class

I apologize if I'm wrong yet. #19289
Utility class features.
Inspiration #18476
Thanks

CC: @mdo for review

These classes are in the wrong place. If you want, please open a new PR against the _position.scss utility file.

@mdo Sure! I will create a new PR !
Thanks 🙂

@CVarisco @cvrebert @mdo
For completeness, I suggest considering breakpoint infixes as done in _display.scss. Use cases may be rare, but they do exist. It does feel a bit flunky since positioning is heavily reliant on top|right|bottom|left properties, so html and css seem a bit too coupled. What do you guys think?

Also to be consistent with _display.scss, I believe it should be .pos-static { position: static; }. Ideally it would just be a p, but that could be mistaken for padding.

@bryanbraun
I understand what you mean, I choosed .pos-X to don't write so much.
However, I will wait a little bit to get the best tip.
After that, I will create a PR 🙂

This was closed, but it doesn't look like the breakpoints classes were ever added.  Was there a reason this was left out, or was it just forgotten (or am I just missing something)


Status code and report in the Action output

Hey! Nice action, thanks for the great work.
I have two questions:

Does it fail action if there are any errors present? (returns non-zero exit code)
How to show output of the cppcheck to github action? I tried to cat cppcheck_report.txt, but it shows file not found.

Same issue.


kube3d: 5.3.0 -> 5.4.1

Description of changes

Bump kube3d to 5.4.1
Also:
Updated github location after the move
Fall back on default k3sVersion in the code - The k3d code regularly updates the default k3s version wihin the code. We can set it by hand when we need to if there's a certain version we should use but at the moment we seem to update it at random. k3d also has some capability to query the latest version via the network or have it overriden via the cli
Added some validation to the k3sVersion that can be overriden - prevent double v prefix
Added mainProgram to meta
Testing the validation:
λ nix-build -A kube3d
# or
λ nix-build -E 'with import ./. {}; kube3d'

# overrides
λ nix-build -E 'with import ./. {}; kube3d.override { k3sVersion = "1.23.4+k3s1"; }'

λ nix-build -E 'with import ./. {}; kube3d.override { k3sVersion = "v1.23.4+k3s1"; }'

Things done

Built on platform(s)

[X] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

[X] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[X] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[X] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[X] Tested basic functionality of all binary files (usually in ./result/bin/)
22.05 Release Notes (or backporting 21.11 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module
[ ] (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes

[X] Fits CONTRIBUTING.md.

Result of nixpkgs-review pr 166237 run on x86_64-linux 1

1 package built:

kube3d

This broke eval, fixed in https://github.com/NixOS/nixpkgs/commit/b283b64580d1872333a99af2b4cef91bb84580cf

Thanks. Yeah this was stuck open for ages so someone else added mainProgram in a separate PR


Format of JSON included in error responses isn't consistent

The JSON sent with Presentation's error responses should ideally be in the following format, using a 'type' that can be used to identify the error:
{
  title: 'Operation failed',
  detail: 'New slug exceeds 1000 records.  This could mean an item no longer belongs to the root collection.',
  instance: 'https://presentation-api.dlcs.digirati.io',
  type: 'https://presentation-api.dlcs.digirati.io/errors/ModifyCollectionType/PossibleCircularReference',
  status: 400
}

But this currently only applies to some of the errors that can potentially be sent back by Presentation. Others use the stock ASP.NET format, which doesn't include a type.
{
  type: 'https://tools.ietf.org/html/rfc9110#section-15.5.1',
  title: 'Bad request',
  status: 400,
  detail: "'slug' cannot be one of prohibited terms: 'collections'",
  traceId: '00-cb734dc737a9028b06fd03f57488d095-bb443009e03f6d22-00'
}

This means that the message in detail is used to check that the correct error was returned, which is much more subject to change!
Many of the endpoints that return the latter format are highlighted in the IIIF presentation tests code - check for usages of the PresentationErrorAssertions.expectedGenericErrorIsReturned() assertion helper (although it's worth mentioning that some of the older tests in t0001StorageCollection.spec.ts use standard playwright code, e.g expect(createResponseJson.detail).toBe("The collection could not be created due to a duplicate slug value") - to be resolved by #17 once the time is found for it)

some of this will be fixed by #199 which changes validation errors to use PresentationProblem


Add more log statements to Swift 3 runtime

The Swift 3 runtime does not print any log statements so it is difficult to debug if the runtime fails to execute, e.g. a timeout when running an action.  We should add some print statements to SwiftRunner (and maybe ActionRunner) so its easier to diagnose problems.

Closing, superseded by #1735


[Linux] desktop file does not pass desktop-file-validate

The desktop file is lacking a Categories= entry in the *.desktop file.
For example:
[Desktop Entry]
Name=Webpack Dashboard
Comment=Webpack Dashboard
Exec=AppRun
Terminal=false
Type=Application
Icon=webpack-dashboard-app
X-AppImage-Version=0.1.0-beta.2
X-AppImage-BuildId=7039a870-8362-11a7-13de-27f5aa0eed21

According to the menu spec, it should contain, for example:
Categories=Network;

Please test the result with desktop-file-validate and make sure it passes.
Reference: https://github.com/electron-userland/electron-builder/issues/1965

electron-builder has a fix for this available:
https://github.com/electron-userland/electron-builder/releases/tag/v19.22.1

@probonopd I have already sent PR to this project ;) https://github.com/FormidableLabs/electron-webpack-dashboard/pull/12

I hereby officially declare that you rock ;-)

Closing, will be in next release (today-ish)


OCPBUGS-42004: Set the Managed Identity client ID

HyperShift will pass a client ID through an environment variable, ARO_HCP_MI_CLIENT_ID, when it deploys the cluster-image-registry operator on a hosted control plane. This client ID will be used to create a new managed identity to authenticate with Azure on the hosted control plane.

/lgtm
I'll put it on hold because the e2e-azure-operator test isn't required for merging but I'd like to see it pass with the new code (I believe the current failures are flakes).
/hold
/retest

/retest

e2e-azure-operator failure (infra issue?):
unable to get custom resource openshift-image-registry/cluster: &fmt.wrapError{msg:"client rate limiter Wait returned an error: context deadline exceeded"

e2e-aws-operator failure (known flake):
tls: failed to verify certificate: x509: certificate signed by unknown authority

/retest

/test e2e-azure-operator

/retest

I think e2e-azure-operator is perma-failing - more specifically, TestPrivateStorageAccountVNetSubnetDiscovery is timing out because the operator can no longer find a vnet by tag. I've pinged the installer folks about it on slack and in the mean time am provisioning myself a cluster to do some more digging. This shouldn't be blocking this PR so I'll override the test.
Let's leave the hold on to give QE a chance to pre-merge test this.
/override ci/prow/e2e-azure-operator

Xiujuan, please help us pre-merge test this one.
/assign @xiuwang

/label qe-approved

PR was on hold waiting for QE, and now we got QE approval - removing hold.
/hold cancel

/jira cherry-pick release-4.17

/cherry-pick release-4.17


Support uint128_t as well on platforms/compilers that support it

I have a test failure that results from a hash that produces a number that is too long for an unsigned long long integer.
On platforms that provide the uint128_t we can provide an API that accepts those types.
Even on platforms that do not support it we can provide support since both GCC and Clang provide a compiler extension that supports uint_128_t.
On GCC it's unsigned __int128_t and on Clang it's __uint128_t.
I inspected the resulting assembly and it seems that both compilers cannot vectorize this type properly. We might be able to do this vectorization manually with AVX but I'm not sure.
What do you think?

Well, I know about __int128_t on GCC but I've always thought it's too much of an overkill. It's a non-standard compiler extension that's supported only on 64-bit systems, so it's a no-go.
AVX is an even more no-go on that matter.
For a real multi-bit support I'd personally go with GMP - I've done some research/work on it but it's gonna take me a few hours to actually implement it. You know, ./configure --with-gmp, etc...

We can #ifdef them quite easily. I tried to avoid GMP since it's another API to learn.


English Documentation

Any support for english documentation?

666

what do you mean 666? iam sorry i don't understand

I am sorry, I mean very good ~

@azzahrah  you can use the Google translation

@xuexb  This is very 666

finally we have international friends~！


modified Gen 4 (part 2) compute size from BC to GP

modified the General Purpose service tier: Generation 4 compute platform (part 2)
The compute size column has a typo. It was BC (Business Critical). So I'm changing it to GP (General Purpose)

@boga5 : Thanks for your contribution! The author, @oslake, has been notified to review your proposed change.

#sign-off

@CarlRabeler: I'm sorry - only the author of this article, @oslake, can sign off on your changes. But we do have an exception process - if you are on the Microsoft content or product team for this product area, you can ask the PR review team to review and merge it by sending mail to the techdocprs alias.


java.sql.Statement, PreparedStatement, and ResultSet implementation

In aceql-http-client-jdbc-driver, there are many unimplemented methods for java.sql.Statement, PreparedStatement, ResultSet, etc. that are not listed in Future Implementation, Limitations, and I would like to ask if they are not implemented because they are not needed.

Hi,
Some of them are not unimplemented because they are not very used by the industry.
We are open if you have any need?

Thank you for your response. If we have any further questions, we will open a separate issue.


Add web page scraping feature implemented by Playwright/Selenium

Support Selenium apis
Support Playwright apis
optional dependencies using extras_require: web_browser, playwright, selenium
tested on both Windows and Ubuntu systems

LGTM


docs(hooks): clarify useSelector re-runs on render

The documentation on useSelector was a little unclear as to when it re-runs on function component renders. It does not seem to re-run on re-renders when a selector reference doesn't change (as was hinted at below, but not above).

Thanks.  Unfortunately, due to how we version the docs, this will only show up in the "Next" version section, and not the "7.1" version section.  Can you update the matching file under versioned_docs as well?

Thanks. Unfortunately, due to how we version the docs, this will only show up in the "Next" version section, and not the "7.1" version section. Can you update the matching file under versioned_docs as well?

@markerikson Good call. Done in 579415c!

Yeah, I'm still really not happy with how versioning gets handled in Docusaurus, and I don't think it gets any better in v2.  This is exactly my concern with it - folks don't know to edit the versioned_docs files, and the /docs folder is actually "next" and not "current".
Thanks!


Timeout error for no apparent reason.

import asyncio
from dotenv import load_dotenv
import os
from opengsq.protocols import Source

load_dotenv()

async def main():
    source = Source(host=os.getenv("HOST_IP"), port=os.getenv("QUERY_PORT"))
    info = await source.get_info()
    print(info)

asyncio.run(main())

I keep getting timeout error for no reason, no matter what server. Tested on 4 machines with same results.

After 3 days of constant timeout errors for no reason, just now it decided to work again with no changes to the code or environment. I also want to add that querying the server worked fine when using JS.  The JS script was tested on 3 machines to make sure and worked fine on all 3.

Is the issue being resolved?

It's very inconsistent. It is no longer constantly timing out, but it will randomly stop working, and take anywhere between 1–5 tries to get a response.

This might be the problem of rate limiting issue. Your game server or firewall might rate-limit the query. You might need to whitelist the query server IP.

I doubt that because it works fine in JS and online query websites.

Can you please provide more info, like game server IP, and port if possible thanks.

<IP_ADDRESS>:29015

the server gets queried every 10 seconds.

Your server is unreachable sometimes.

The issue is either your server internet is unstable or the firewall rule is too strict.

How come when I query it in JS using gamedig and use a website like https://cmsminecraftshop.com/en/query/ it works fine? Do you know how I can fix this?

It is based on how your game server's internet is set up, it is hard to have an easy solution for that.

Alright, well, thank you for looking into it. I will keep looking for a fix.


Prepare Release 10.2.4

Description

Preparation

[x] Create a prepare-release-10.2.4 branch, based on the dev-v10 branch;
check out the prepare-release-10.2.4 branch
[x] Update the README.txt and WHATSNEW.txt in the packaging/common/khiops directory
[x] Update the technical repository [khiops-win-install-assets][win-install-assets]

Update SAMPLES_VERSION as soon as PR https://github.com/KhiopsML/khiops-samples/pull/6 is merged.

[x] Update Khiops version to 10.2.4-rc.1 in the src/Learning/KWUtils/KWKhiopsVersion.h` header
file
[x] Create PR on the prepare-release-10.2.4 branch and have it reviewed
[x] Once the PR is approved, merge it into the dev-v10 branch
[x] Create the 10.2.4-rc.1 pre-release tag on the dev-v10 branch
(see [Versioning][versioning])

Full Test Loop

[x] Push the 10.2.4-rc.1 pre-release tag

This will create a pre-release entry in the [release section][khiops-releases] with all the
the CICD generated packages

[x] Execute the end-to-end tests (aka. LearningTest) in Windows / Conda environments only

If there are major issues, fix them (making issues, PRs) and go back to "Create pre-release tag..."

[x] Execute the [manual tests for the GUI packages][manual-tests]: on Windows, Rocky 8, Debian 10, Ubuntu 24.04 only.

Finalize the Release

[x] Update src/Learning/KWUtils/KWKhiopsVersion.h to the final release tag 10.2.4
[x] Merge dev-v10 into main (via PR)
[x] Create the final release tag (see also [Versioning][versioning]):

Tag the main branch (git tag 10.2.4 main then git push origin tag 10.2.4)

[x] Copy and paste the release notes from packaging/common/khiops/WHATSNEW.txt to in the new
[github release entry][khiops-releases]
[x] Remove any packages that haven't been deemed to release

We create more packages than we release for testing purposes (viz. kni-transfer)

[x] Manually launch the conda.yml workflow on the 10.2.4 tag, while selecting khiops
as release channel
[x] Sign the Windows binaries, recreate the Windows package (see packaging/windows/nsis/README.md),
sign it and replace it in the release
[x] Set release as "latest"; unset its "pre-release" status
[x] Release enabler: khiops-python,
[x] Release enabler: khiops-notebook.

At this point the update of the website is unblocked

Final Git Manipulations

Update the main branch
[x] Make the dev-v10 branch point to main

Locally execute git fetch, then git switch main, git switch dev-v10 and
git reset --hard main
In the repository's [branch protecting settings][branch-settings] remove temporarily "Require a pull
request before merging"
Locally execute git push
Restore in the  [branch protecting settings][branch-settings] "Require a pull request before
merging"

Full LearningTest tests on Windows / Conda / Python 3.8 to 3.13: OK.
Manual GUI tests on Debian 10, Rocky 8, Ubuntu 24:

install: OK
GUI launching: OK
Adult training with khiops: OK
SpliceJunction coclustering with khiops_coclustering: OK.

All tasks have been completed.


DATA-5302: improve docs

@dobooth thank you for the review!! I've committed your changes and I added a link to Adobe Product Analytics in the readme
https://business.adobe.com/products/product-analytics/adobe-product-analytics.html


Access raw text

Provide a means to access the raw text content, including line breaks, as plain text. This could be stored in a backend.
This would be needed for text-processing applications, eg: Natural language processing applications.

The Editor has a text property which has the current raw text of the contents. getText(from, to) is also available for extracting part of that, though with the text string it is unnecessary and could be removed.

Awesome!


Remove margin on icon-only-button

Is your feature request related to a problem? Please describe.
Currently, the button includes a margin on the left side while using the icon. This is used probably for the default animation, which is not implemented here in the library.
Describe the solution you'd like
Remove the default margin. Maybe add the animation?
Describe alternatives you've considered

Make it toggleable via property
Only remove the margin while using icon only button

@FabianWilms any opinions? - speak now or remain silent forever 😈


chore: update to TypeScript 3.1

With TypeScript 3.1, several native DOM types have been updated. Notably, document.documentElement and document.activeElement are now nullable. APIs relating to matchMedia were also updated.
This change is necessary for v7 RC

Looks like there's an error in one of the unit tests.

Fixed unit test

I made one other change in breakpoint-observer.ts to make this build in Google, which isn't on TypeScript 3.1 yet


Add roadmap?

I would really like to contribute to this project, but other than TODO-s in the code, there is no way to know about tasks/ideas the community can pick up and experiment with.
Possible entries:

Increase code coverage
Update to latest core.async once it's released and implement purge-chan
etc...

An example:
https://github.com/jsbin/jsbin/blob/master/docs/roadmap.md

I hope I'm not speaking out of turn, but I don't think there is a specific roadmap for re-frame beyond any outstanding issues, PR's, or TODO's. Of course @mike-thompson-day8 has his secret plan for world domination where re-frame plays a big part but I'm not allowed to share that one :)


Use consistent variable names in PermissionTest

A few of the variables that keep track of the internal state of the test had names
that included "Id" (because they are entity IDs) but most didn't. Make them
consistent.

Current dependencies on/for this PR:

main

PR #1619   👈

This stack of pull requests is managed by Graphite.


Remove an unused field on the Contributors component

Might need more context around what this field was, but I've seen it a lot in events/exhibitons/some types (like WithContributors), should it be removed completely? Do we just use whatever is in contributor.role now?

The titleOverride field was only used for a Cardigan story here: https://github.com/wellcomecollection/wellcomecollection.org/commit/8a2eff5fac045c0086d9248b099318f8837afb39#diff-3b16452e101464635ab0a372057afc92935398f5a2b2f972455fec5368ceb755
It replaces the default About the contributors or About the authors text that usually appears at the top of the contributors list.
I don't think it's used anywhere else?

I meant about contributorTitle itself and its purpose? I don't think it's used anywhere?

I meant about contributorTitle itself and its purpose? I don't think it's used anywhere?

Ah yeah, I don't think so – I can't find it by searching, and I think the build would fail if it was used somewhere.

I’m going to close this for now, given our discussion in Slack – I’m not sure removing this from the component is the right move.


Implement as TUI

Now that the foundations have been coded, the next steps are to create a TUI with textual.
Tasks

[ ] Implement home screen
[x] Implement releases screen
[x] Implement starred repos screen

Remaining work for this initial TUI MVP includes tidying up the home screen and applying initial unified styling.


SigQ eventually gets full

Some signals appear to be getting held up somewhere, causing an eventual segfault.
cat /proc/5497/status | grep Sig                                                                                23cfdd722a8d: Sun Dec 24 20:04:39 2023

SigQ:   48523/63519 <-- this should be 0-ish when idle
SigPnd:<PHONE_NUMBER>000000
SigBlk:<PHONE_NUMBER>000000
SigIgn:<PHONE_NUMBER>000000
SigCgt: ffffffff7fc1feff

Once these are all used up, a segfault will be issued:
Could not create timer: Resource temporarily unavailable (11)

I haven't seen this in worker-mode, FWIW. Related to #366

I suspect these signals come in after the request is completed (thus, PHP has shutdown) but still need to be handled.

This is likely related to the memory leak. This means that the time created by PHP to handle timeout isn't cleaned properly. This code is quite new in PHP (I created it), I probably messed up something.
Would you be able to track where the code timer is created (eg using GDB) and why it isn't freed?

The timer is both created and destroyed @dunglas, I suspect this is important:

timer_delete() deletes the timer whose ID is given in timerid.
If the timer was armed at the time of this call, it is disarmed
before being deleted.  The treatment of any pending signal
generated by the deleted timer is unspecified.

From the looks of things, pending signals do not seem to be cleaned up (at least in my kernel) after the clock is deleted.

But what signals? Because calling timer_delete() should disarm the timer, so no signals should be send.
May https://github.com/php/php-src/pull/12539 help?

The signals in /proc/${ID}/timers... The timer is disarmed and not fired. However, pending signals are left hanging around (yay unspecified behavior).
To clear the timers, the signal must be ignored after the timer is deleted.
Opening a PR https://github.com/php/php-src/compare/master...bottledcode:php-src:fix/timers?expand=1
Just need to figure out how to get it backported to 8.2 + 8.3 + master.

So, I added some logic to that branch in php-src to detect if we create more than one timer per thread (because there was still a leak). It looks like ts_resource(0) creates a timer, as well as php_request_startup().
@dunglas any ideas on how we could fix this on the FrankenPHP side? Or perhaps in my branch, I just make it silently bail instead of emitting a warning?

I've no idea yet, but I'll be glad to take a look when I get back from vacation if you don't manage to find a fix before that (but I'm sure you will :D). Anyway, thanks for your research and commitment to fixing these issues, this is very promising!!

This is now fixed upstream and should be in the next patch release of 8.2 and 8.3.

The patch will land in PHP 8.3.3 and 8.2.1 (it is already available in the betas).


Lazy loading is implement

Resolves #123
Description

Screenshots

Checklist

[x] My code adheres to the established style guidelines of the project.
[x] I have included comments in areas that may be difficult to understand.
[x] My changes have not introduced any new warnings.
[x] I have conducted a self-review of my code.

@Abhijit25Mishra Please review my pr now

@shraddha761 try showing the difference with and without the changes you made, make note of the stats and observations and write in detail about it.
this will actually help the site (from what i know about lazy loading), just try and show some stats to prove it.

@J0SAL please review I have added loading to website

@Abhijit25Mishra can you review

@shraddha761 can you implement it such that only the first time the user visits this page, it will load this animation. you can try using caching for that.
also i see that the image gets loaded first then it appers to rotate, this makes it look bad, what you can do is add opacity changes, what i mean is that the start opacity should be zero and at 0.25 second also it should be zero then from 0.25 second to 3 sec, it should gradually increse to 100%. i know it sounds complicated, but its really simple.

@Abhijit25Mishra how to start opacity from 0.25 I tried using delay but it didn't work
and for loading for first time user i have used session storage

Yeah I saw that session storage thing in code, I didnt really get why it didn't work.
Please check online about opacity, try reading about keyframes. Search on gpt and llaama

@Abhijit25Mishra Please review I have solve bug of image which is visible before preloading

@Abhijit25Mishra I have done some changes please review

@J0SAL I didn't understand , you mean to do it from another way

@J0SAL Please review now

@shraddha761 there weren't any updates in the code


Rebuild with latest Gradle version. Reformat code. Fix build error in AndroidManifest.

Rebuild with latest Gradle version.
Reformat code.
Fix build error in AndroidManifest.

"Rebuild with latest Gradle version" -- there is nothing in your pull request that changes the Gradle version.
"Reformat code" -- I would prefer to maintain consistency with the rest of my samples.
"Fix build error in AndroidManifest" -- I fail to see what in this pull request would have this effect.

I changed  android:targetSdkVersion="21", which makes this Lollipop compatible.  Furthermore, I added Material theme in the  tag.  Lastly, I added:
<uses-sdk        android:targetSdkVersion="21"        android:minSdkVersion="16"         tools:overrideLibrary="com.commonsware.android.advservice.binding" />
In order to fix build error with support-v13 conflicts.

~" I would prefer to maintain consistency with the rest of my samples."
But your entire code samples are not formatted in Android Studio.  Wouldn't it be better to format it like the IDE says instead of free-styling it without adhering to standards?

"I changed android:targetSdkVersion="21", which makes this Lollipop compatible" -- the AdvServices/ samples are old, replaced by the ones in the Binding/ directory for the purposes of my book. These are left here for historical purposes (e.g., inbound links), with a README that explains this.
"Wouldn't it be better to format it like the IDE says instead of free-styling it without adhering to standards?" -- no, for any number of reasons, not the least of which that this code goes in a book, and books in print and PDF form have line length limitations.


fix: add Chaitanya

I have added my social media data to the public folder.

Hey folks! I have made the suggested changes. Could you please merge the branches now? Thanks for your suggestions!

Hey folks! I have made the suggested changes. Could you please merge the branches now? Thanks for your suggestions!

Thanks for your contribution @Chaitanya7666


WIP: deployments -> bundles

Todo:

[x] update documentation
[x] implement bundles and remove deployments in storage module
[x] adapt api-server module
[x] implement POST /deploy api
[x] adapt static-server module
[x] adapt sdk module
[x] adapt cli
[x] adapt app

Codecov Report

Merging #5 into master will increase coverage by 0.67%.
The diff coverage is 92.7%.

@@            Coverage Diff             @@
##           master       #5      +/-   ##
==========================================
+ Coverage   86.94%   87.61%   +0.67%
==========================================
  Files          61       76      +15
  Lines         720      856     +136
  Branches       99      119      +20
==========================================
+ Hits          626      750     +124
- Misses         78       88      +10
- Partials       16       18       +2

Impacted Files
Coverage Δ

...console/src/components/OperationsDropdown/Item.tsx
0% <ø> (ø)

...min-console/src/common/formWithValuesConverter.tsx
68.18% <ø> (ø)

...-console/src/components/EntrypointForm/validate.ts
84.61% <ø> (ø)

admin-console/src/components/LoginMask/index.tsx
100% <ø> (ø)

admin-console/src/common/emphasizeString.tsx
0% <ø> (ø)

admin-console/src/index.tsx
0% <ø> (ø)

...in-console/src/components/OperationModal/index.tsx
74.54% <ø> (ø)

admin-console/src/components/TextField/index.tsx
95.83% <ø> (ø)

admin-console/src/components/DataFetcher/index.tsx
95.23% <ø> (ø)

api-server/src/api/apps/{appId}/get.ts
100% <ø> (ø)
:arrow_up:

... and 68 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 64e1967...4d9c4d4. Read the comment docs.


Confirm optional selector is working in findByText

Error appears to happen on nested elements

Error also happening in findByText


merge_sorted script

create a new script that works just like mergepbcore.py, but works on the individual register.csv documents (e.g. register_2019-07-10T14_52_59.csv) that land on in the ifiscripts folder when individual accession.py or sipcreator.py -accession scripts are run.
Would be somethign like:
mergesorted.py (directory containing multiple individual register.csvs)
returns: Merged Sorted CSV is stored in /Users/edit/Desktop/ifiscripts_logs/2019-07-10T16_45_29_sorted.csv
this can then be used for accession_register.py along with pbcore_csv and folmo_csv
would be handy for radharc sd tape workflow
and potentially Gavin's also.

Added here - https://github.com/kieranjol/IFIscripts/commit/d520decc0faaa25a809b068672ee2e0f98039d26


Patch only valid configurations with existing platform

Description
Solves problem when a command contains configurations that is not object and / or doesn't have platform key
PR Checklist

[x ] Migrations have been added if necessary

Issue
https://github.com/nxtend-team/nxtend/issues/388
Resolves #
https://github.com/nxtend-team/nxtend/issues/388

Fixed via https://github.com/nxtend-team/nxtend/pull/390/files

Fixed via https://github.com/nxtend-team/nxtend/pull/390/files


OLS-271: Load vector db once

Description
As loading vector index takes time, load this once instead of with every query.
Type of change

[ ] Refactor
[ ] New feature
[ ] Bug fix
[ ] CVE fix
[ ] Optimization
[ ] Documentation Update
[ ] Configuration Update
[ ] Bump-up dependent library

Related Tickets & Documents

Related Issue # OLS-271
Closes #

Checklist before requesting a review

[ ] I have performed a self-review of my code.
[ ] PR has passed all pre-merge test jobs.
[ ] If it is a core feature, I have added thorough tests.

Testing

Please provide detailed steps to perform tests related to this code change.
How were the fix/results from this change verified? Please provide relevant screenshots or results.

Codecov Report
Attention: 7 lines in your changes are missing coverage. Please review.

Comparison is base (8f46f1d) 94.83% compared to head (dda40a6) 95.85%.
Report is 24 commits behind head on main.

Additional details and impacted files

@@            Coverage Diff             @@
##             main     #462      +/-   ##
==========================================
+ Coverage   94.83%   95.85%   +1.02%
==========================================
  Files          36       45       +9
  Lines        1181     1400     +219
==========================================
+ Hits         1120     1342     +222
+ Misses         61       58       -3

Files
Coverage Δ

ols/app/endpoints/ols.py
100.00% <100.00%> (ø)

ols/src/query_helpers/docs_summarizer.py
100.00% <100.00%> (+7.50%)
:arrow_up:

ols/src/rag_index/__init__.py
100.00% <100.00%> (ø)

ols/src/rag_index/index_loader.py
87.27% <87.27%> (ø)

/lgtm
/approve


Updated occurrences query schema.

PT-1050 PT-1106.
NOTE: This needs new API https://github.com/City-of-Helsinki/palvelutarjotin/pull/191

NOTE: Tests fails because API is not published yet

Codecov Report

Merging #200 (656a4ef) into master (592a07f) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #200   +/-   ##
=======================================
  Coverage   82.59%   82.59%
=======================================
  Files         207      207
  Lines        3671     3671
  Branches     1131     1131
=======================================
  Hits         3032     3032
  Misses        612      612
  Partials       27       27

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 592a07f...656a4ef. Read the comment docs.


store: reconsider design (go type vs json mode)

The added JSONMode has felt that some duplication was added in the store code.
The duplication was somewhat necessary since the same logic should have different implementations due to different types being around (reflect mode vs string mode).
I have the feeling that an ideal state of the implementation is leaving the JSON mode to be the only one, and the Go Typed one a wrapper. Despite this sounds good, JSON mode has some limitations regarding possible types of instance attributes (since Go types are more expressive than JSON). The most obvious case is ints and floats. In Go Type mode you can distinguish these two types for queries, but in JSON mode you can't.
Making the Go Type mode a thin wrapper of JSONMode to avoid duplication would mean adding these limitations to Go Type mode. Also, I don't have quite clear yet the performance implication of both modes... but that should be considered to (eventually benchmark it). On the other hand, doing it this way will wipe out all reflect code which is nice to our eyes.
If we convince ourselves that the real store should be JSONMode (and Go Type a wrapper), then I think I'd reconsider if some JSON library can give optimized and more capabilities to json handling (like path traversing, i.e: gson library) and more importantly the query engine.

Nice summary. The gjson result type handling (https://github.com/tidwall/gjson#result-type) could serve as some motivation, letting the user pull out the correct type, e.g., int vs. float. Though, these limitations may have deeper consequences at the db level, i.e., having to store all numbers as float64.

For now, just making json mode the only mode.


Adds a resources tab to the visualiser

This tab allows a quick view of resource utilization in the visualiser. It also
shows which jobs are running for each resource, but this information is
collapsed by default. This is very helpful when jobs for debugging/tracking when
jobs for a particular resource are getting backed up.

nice!

Ah, very nice. This handles decimal values too right?

I'm not sure, I've never tried decimal values for resources. Does that work for you? Wouldn't it be easier/safer to scale everything up to integers to avoid floating point errors?
If this doesn't handle decimal values, it should be an easy fix. Let me know.

Ok I'll test this out and let you know :)