Adding the accounts code to the sdk

I thought a good first thing to do would be to bring the accounts into the SDK.  I had to do some refactoring because this code doesn't have access to WAX inpage.
Some notes:

I didn't know how to set up the sym link that @voltrevo did in the inpage directory with hardhat. I think we may want to do that in the SDK directory as well so that we can build the contracts there.
For some of the functions I pass an admin account so we can deploy the contracts if they aren't deployed (see comments in the code).
I think the recovery logic needs to be updated with @JohnGuilding new changes for the contracts
Also, if we want to keep this name, we need to create a namespace in npm for @getwax I can't deploy it under this name until we do that.

Also, shout out to Andrew for making these account wrappers.  I just edited the existing code in the demo so that it can be used in an sdk.

@jacque006 Yup makes sense. I'll take a look at that symlink now.


MAXO:0035090	cholescintigraphy

MAXO:0035090	cholescintigraphy
def:An imaging procedure used to visualize liver, gallbladder and bile ducts following intravenous injection of iminodiacetic acid, a radioactive tracer that is taken up by gall-producing cells and secreted into the bile, following which imaging is performed by a gamma camera.
synonym: Hepatobiliary iminodiacetic acid scan; HIDA scan

hepatobiliary iminodiacetic acid (HIDA) scan seems to be the more common usage (NCI, mayo clinic, CPT). Should we use that as the label and cholescintigraphy as the synonym?


Do not allow enabling badges without any skills

Badges should not be allowed to be enabled if they do not contain any skills.  Likewise, once a badge is enabled, you should not be allowed to remove the last skill from the badge.

@cjmoses - I created a project badge, then added a skill and enabled it.  Then, I went to remove the skill from the badge and got a 400 error

@rmmayo - conversations with @sudo-may resulted in this ticket evolving to drop the "prevent deletion of last skill on badge" portion of the ticket. It looks like a server side check is still in place, I'll remove that. The only real capability this ticket should enforce, is preventing enabling of an empty badge.

verified!


t.$el.getBoundingClientRect is not a function [v2.0.0-rc.3] [BUG]

Vue.js & vue-router.js version
v2.0.0-rc.2 , v2.0.0-rc.3
Reproduction Link
Vue Component
https://jsfiddle.net/hvzcm89n/
Vue Pile Store
https://jsfiddle.net/2405e9Ln/
Vue UserTeam Store
https://jsfiddle.net/0pj8ogn8/
Steps to reproduce
Click on route : sometimes it triggers error. Not always. No request fails from the API. Not easy to replicate.
What is Expected?
Should go to page and show view / data
What is actually happening?

Probably cant be solved from what I've given, which happens once in 10-15 requests.

I've encountered this before, it's not a vue bug, but a vue-devtools bug
(you can see the error is coming from backend.js), when vue-devtools try to
call getClientBoundingRect on a component's $el which doesn't exist. Forgot
to file an issue on devtools repo, though. So perhaps you can close this
and file an issue there instead : )
A quick workaround is to replace some v-ifs with v-show.
On Mon, Aug 22, 2016, 00:10 Luke Policinski<EMAIL_ADDRESS>wrote:

Vue.js & vue-router.js version
v2.0.0-rc.2 , v2.0.0-rc.3
Reproduction Link
Vue Component
https://jsfiddle.net/hvzcm89n/
Vue Pile Store
https://jsfiddle.net/2405e9Ln/
Vue UserTeam Store
https://jsfiddle.net/0pj8ogn8/
Steps to reproduce
Click on route : sometimes it triggers error. Not always. No request fails
from the API. Not easy to replicate.
What is Expected?
Should go to page and show view / data
What is actually happening?
[image: image]
https://cloud.githubusercontent.com/assets/2066668/17838270/596b4122-6797-11e6-9b6b-4df0e7328acd.png
Probably cant be solved from what I've given, which happens once in 10-15
requests.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/vuejs/vue-router/issues/617, or mute the thread
https://github.com/notifications/unsubscribe-auth/AFTLl2jiOQ0zVEqnLAF2RaDFwU-c3F6vks5qiHiMgaJpZM4JpU_Q
.

Thanks for that, ill go ahead and do that.


Run AWS tests in a CI cron job

With this PR, Travis runs AWS tests once a day, and send emails to<EMAIL_ADDRESS>if the tests fail.

Does this mean that<EMAIL_ADDRESS>will get an email every time CI fails on a PR? That seems like it may be a lot of email

Per discussion with Derek: we'll see how much email this generates. If it turns out to be a lot we can always disable it.


chore: use latest major versions for actions

:tada: This PR is included in version 1.0.9 :tada:
The release is available on:

v1.0.9
GitHub release

Your semantic-release bot :package::rocket:


[Bug report] Uncaught TypeError: app.Logging.get_event is not a function

Date Seen:
17-05-2015
Version':
KC3 Kai v008 (git build) ID: jljpednjlkddlmahfoljfjlnbollampe
KC3 Kai v008 git revision: f89e960
Browser: Chromium 64bit (currently on: 42.0.2311.135 (Developer Build 575981d43c6dc74b1443ca77e015c218daf050dd Linux))
OS :Archlinux 64bit (currently on: Linux: 4.0.1-1-ARCH)
Bug Description:
Error found during event sortie.
Screenshots are provided below.
Severity:
Minor (?).
Steps to Reproduce:

Sortie your fleet to event maps. Ideally to E-6.

Actual Behavior:
Unknown. I do not know what is actually happened other than seeing the error.
Expected Behavior:
Unknown - possibly error to not show up.
Troubleshooting/Testing Steps Attempted:
Tried to play the game normally which appears to have impacted nothing.
Workaround:
None.
Attachments:

wait CT, seem the screenshot is different from the title XD
which error was it xD

Hi DJ, unfortunately I have no developer console trace of it. The bug hasn't resurfaced but also the event is over so I guess this is pretty much the end of the bug being visible.
The screenshot I do believe is the right one.

Yep I remember I removed app.Logging.get_event then pushed it in one of the commits which are not yet publish-ready. Switched to a different function call later on so should not be a problem now


Improve the UX of Timeline and Chart layouts

Example video for Timeline

working on this tm as part of akamatsu lab client


chore: add codecov

Add codecov to ShellJS
Partial fix for #671

Codecov Report

:exclamation: No coverage uploaded for pull request base (master@5318fdc). Click here to learn what that means.
The diff coverage is n/a.

@@            Coverage Diff            @@
##             master     #682   +/-   ##
=========================================
  Coverage          ?   89.96%
=========================================
  Files             ?       32
  Lines             ?     1216
  Branches          ?        0
=========================================
  Hits              ?     1094
  Misses            ?      122
  Partials          ?        0

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5318fdc...94132b4. Read the comment docs.

@freitagbr from this PR, it looks like codecov integration is a success! This should be safe to merge (it should immediately start tracking coverage on master branch).


Default express integration is outdated

Current version of nuxt works poorly with express as main entry point. It doesn't show  build progress, can't connect to dev websockets before full build of app. Maybe in future problems will be more severe.
How about using express as server middleware, or with nuxt express module? I can make PR if any of that is acceptable.

Hi @TrueCarry,
Indeed it has to be updated, using a module (adding a serverMiddleware) is the best approach at the moment before introducing Nuxt services (and avoiding sharing same process for Nuxt renderer and API).
Your PR is more than welcome :)


Make port range CLI flag tip dynamic from host port tracker

Currently says accepted values are 1024-65535, but these are hardcoded; we want them to bubble up from FreeHostPortTracker who actually enforces it

Closing in favor of https://github.com/kurtosis-tech/ava-e2e-tests/issues/25


.ts source files are copied in dist

this seems unneeded as we include the src folder in the NPM package as well

Sounds logical. Does this need discussion?

fixed in #936


Make C++ compatible

Precisely what the title says. This patch allows Mimick to be used in C++ tests for C API.
Depends on #11 and #12. Only https://github.com/Snaipe/Mimick/commit/31c6ce065f725adddcd83cfa2a36a3f810d4c6fe, https://github.com/Snaipe/Mimick/commit/8381645424541b8a7c2c972dbcb6d4a70fc47c84, and https://github.com/Snaipe/Mimick/commit/0b67235541b8d97541bf0d5da82c3e3ebef7a028 are specific to this patch.

Alright, @Snaipe PTAL!

This grew massive and hard to review. I'll close this now, and open smaller PRs with these and other fixes. Hope you can take a look @Snaipe.


Issue with symlinks

Thread for the symlink discussions we're having for the worker.
cc @ovflowd @targos

docs.txt
List of folders in /docs/ that are not symlinks.


Selectivity setup for index units > 30

The documentation says for an index with units > 30, selectivity parameters should not be specified (<IP_ADDRESS>). This makes it unclear if such an index should be specified at all in the selectivity setup table (I think it must), and if it should be specified, what pattern to use (0?).

@okenk Great question and I think you landed on the correct answer.  If you are using a species survey option >=30, the "index" for this fleet should be entered in the index section within the data file, a Q set-up line will be expected in the control file, and the a selectivity pattern line should be entered in the control file for both the age and length based selectivity setup.  Example:
#_Pattern	Discard	Male	Special
24	0	0	0	#_1 WA_Recreational
15	0	0	1	#_2 WA_Commercial
0	0	0	0	#_3 Special Survey

#_age_selex_patterns
#_Pattern	Discard	Male	Special
10	0	0	0	#_1 WA_Recreational
10	0	0	0	#_2 WA_Commercial
0	0	0	0	#_3 Special Survey
Since both of the selectivity patterns are set to 0, you do not need to enter any parameter lines for this fleet.  I think this applies to all special survey types and hopefully if I am incorrect @iantaylor-NOAA or @k-doering-NOAA can correct me.

Would it be helpful if I generated some text for the manual so that this is more clear?

That would be fantastic.  Feel free to post the draft text here and I will incorporate it into the manual.  Thank you

I am working on this. Is there a specific way that selectivity should be specified? Or does it depend on the index? Or maybe it is just ignored but needs to be there? @kellijohnson-NOAA

It needs to be there in the list of selectivity specifications for both age and length.
It is ignored because selectivity per se is not used for these "special" fleets
It is best to specify it as selectivity type 0 which takes no parameters.

Thanks! And how about Q?

More complex for Q because Q definitely is not ignored.   In most cases, Q for a special  survey type is identical to Q for a normal survey.  See the code beginning at line 295 in SS_expval.tpl

@chantelwetzel-noaa should this issue be closed? I'm not sure if @okenk 's changes were merged in or not!

@chantelwetzel-noaa, I'm guessing that this is the link to the commit right: 42c6ecbe98591940b69e1da4c90e8ab55b6dfdbb for @okenk to check, right? #88 just references this issue.

Correct. Thank you!

Yes, this looks great and is much clearer. Sorry for dropping the ball on it!

No worries.  Thank you!


Master fails 20-test_app.t

MacOS 10.15.5, Xcode-11.5, current master.
Test Summary Report
-------------------
20-test_app.t                    (Wstat: 256 Tests: 3 Failed: 1)
  Failed test:  1
  Non-zero exit status: 1
Files=203, Tests=2022, 567 wallclock secs ( 3.26 usr  0.61 sys + 243.44 cusr 65.14 csys = 312.45 CPU)
Result: FAIL
make[1]: *** [_tests] Error 1
make: *** [tests] Error 2

Output of perl configdata.pm --dump: config.dump.txt
$ make test TESTS="test_app" VF0=1 V=1
/Applications/Xcode.app/Contents/Developer/usr/bin/make depend && /Applications/Xcode.app/Contents/Developer/usr/bin/make _tests
( SRCTOP=. \
	  BLDTOP=. \
	  PERL="/opt/local/bin/perl5.26" \
	  EXE_EXT= \
	  /opt/local/bin/perl5.26 ./test/run_tests.pl test_app )
20-test_app.t ..
# The results of this test will end up in test-runs/test_app
1..3
Usage: help
../../util/wrap.pl ../../apps/openssl => 1
not ok 1 - Run openssl app with no args

#   Failed test 'Run openssl app with no args'
#   at test/recipes/20-test_app.t line 18.
Standard commands
asn1parse         ca                ciphers           cmp
cms               crl               crl2pkcs7         dgst
dhparam           dsa               dsaparam          ec
ecparam           enc               engine            errstr
fipsinstall       gendsa            genpkey           genrsa
help              info              kdf               list
mac               nseq              ocsp              passwd
pkcs12            pkcs7             pkcs8             pkey
pkeyparam         pkeyutl           prime             provider
rand              rehash            req               rsa
rsautl            s_client          s_server          s_time
sess_id           smime             speed             spkac
srp               storeutl          ts                verify
version           x509

Message Digest commands (see the `dgst' command for more details)
blake2b512        blake2s256        gost              md2
md4               md5               mdc2              rmd160
sha1              sha224            sha256            sha3-224
sha3-256          sha3-384          sha3-512          sha384
sha512            sha512-224        sha512-256        shake128
shake256          sm3

Cipher commands (see the `enc' command for more details)
aes-128-cbc       aes-128-ecb       aes-192-cbc       aes-192-ecb
aes-256-cbc       aes-256-ecb       aria-128-cbc      aria-128-cfb
aria-128-cfb1     aria-128-cfb8     aria-128-ctr      aria-128-ecb
aria-128-ofb      aria-192-cbc      aria-192-cfb      aria-192-cfb1
aria-192-cfb8     aria-192-ctr      aria-192-ecb      aria-192-ofb
aria-256-cbc      aria-256-cfb      aria-256-cfb1     aria-256-cfb8
aria-256-ctr      aria-256-ecb      aria-256-ofb      base64
bf                bf-cbc            bf-cfb            bf-ecb
bf-ofb            camellia-128-cbc  camellia-128-ecb  camellia-192-cbc
camellia-192-ecb  camellia-256-cbc  camellia-256-ecb  cast
cast-cbc          cast5-cbc         cast5-cfb         cast5-ecb
cast5-ofb         des               des-cbc           des-cfb
des-ecb           des-ede           des-ede-cbc       des-ede-cfb
des-ede-ofb       des-ede3          des-ede3-cbc      des-ede3-cfb
des-ede3-ofb      des-ofb           des3              desx
idea              idea-cbc          idea-cfb          idea-ecb
idea-ofb          rc2               rc2-40-cbc        rc2-64-cbc
rc2-cbc           rc2-cfb           rc2-ecb           rc2-ofb
rc4               rc4-40            rc5               rc5-cbc
rc5-cfb           rc5-ecb           rc5-ofb           seed
seed-cbc          seed-cfb          seed-ecb          seed-ofb
sm4-cbc           sm4-cfb           sm4-ctr           sm4-ecb
sm4-ofb           zlib

../../util/wrap.pl ../../apps/openssl help => 0
ok 2 - Run openssl app with help
Invalid command '-help'; type "help" for a list.
../../util/wrap.pl ../../apps/openssl -help => 1
ok 3 - Run openssl app with incorrect arg
# Looks like you failed 1 test of 3.
Dubious, test returned 1 (wstat 256, 0x100)
Failed 1/3 subtests

Test Summary Report
-------------------
20-test_app.t (Wstat: 256 Tests: 3 Failed: 1)
  Failed test:  1
  Non-zero exit status: 1
Files=1, Tests=3,  1 wallclock secs ( 0.01 usr  0.00 sys +  0.11 cusr  0.05 csys =  0.17 CPU)
Result: FAIL
make[1]: *** [_tests] Error 1
make: *** [tests] Error 2

I can confirm this issue.
BTW, @mouse07410, pleased to see that your are meanwhile also using VFO=1 .
Just note that if you use it together with V=1 like in
make test TESTS="test_app" VF0=1 V=1

it is silently ignored for backward compatibility.
Maybe I should change this to give a warning, or even to override V=1 (and VF=1)?

I've got a possible fix for this in #12258.  I didn't get the issue to reproduce locally so it's a it of a guess.

I can confirm that #12258 does fix the issue.  Tested with enable-asan

Maybe I should change this to give a warning, or even to override V=1 (and VF=1)?

@DDvO please don't. In my experience, VF0=1 was not verbose even on the failing tests, so I had to add V=1.
Could you explain what's the expected output of each (V=1, VF1=1, V=1) is? What kind of verbosity, and when/in what case?

I can confirm that #12258 does fix the issue. Tested with enable-asan

Great! When do we merge? ;-)

BTW, @mouse07410, pleased to see that your are meanwhile also using VFO=1 .
Just note that if you use it together with V=1 like in
make test TESTS="test_app" VF0=1 V=1

it is silently ignored for backward compatibility.

Maybe I should change this to give a warning, or even to override V=1 (and VF=1)?

@DDvO please don't. In my experience, VF0=1 was not verbose even on the failing tests, so I had to add V=1.

This is strange. Can you provide me a way to reproduce this?

Could you explain what's the expected output of each (V=1, VF1=1, V=1) is? What kind of verbosity, and when/in what case?

This has been done as part of #12175.
See the documentation in https://github.com/openssl/openssl/blob/master/INSTALL.md#test-failures
and some examples as part of the PR implementing it: https://github.com/openssl/openssl/pull/12088

@mouse07410, over here VFO=1 appears to work fine on the failing test_app -
maybe you have again some local merge inconsistency or the like?
See the output I got for make test TESTS=test_app VFO=1
( SRCTOP=. \
  BLDTOP=. \
  PERL="/usr/bin/perl" \
  EXE_EXT= \
  /usr/bin/perl ./test/run_tests.pl test_app )
20-test_app.t ..
=================================================================
==21498==ERROR: AddressSanitizer: global-buffer-overflow on address 0x0000005bbf88 at pc 0x0000004d46d3 bp 0x7ffdab8d7d40 sp 0x7ffdab8d7d38
READ of size 8 at 0x0000005bbf88 thread T0
    #0 0x4d46d2 in opt_next apps/lib/opt.c:679
    #1 0x465505 in help_main apps/openssl.c:322
    #2 0x465c4e in do_cmd apps/openssl.c:397
    #3 0x4652cf in main apps/openssl.c:273
    #4 0x7f9bd928209a in __libc_start_main ../csu/libc-start.c:308
    #5 0x422d39 in _start (/home/david/Siemens/proj/PKI/openssl/FdaSilvaYY/apps/openssl+0x422d39)
0x0000005bbf88 is located 0 bytes to the right of global variable 'help_argv' defined in 'apps/openssl.c:208:14' (0x5bbf80) of size 8
SUMMARY: AddressSanitizer: global-buffer-overflow apps/lib/opt.c:679 in opt_next
Shadow bytes around the buggy address:
  0x0000800af7a0: f9 f9 f9 f9 f9 f9 f9 f9 f9 f9 f9 f9 f9 f9 f9 f9
  0x0000800af7b0: f9 f9 f9 f9 f9 f9 f9 f9 f9 f9 f9 f9 f9 f9 f9 f9
  0x0000800af7c0: f9 f9 f9 f9 f9 f9 f9 f9 f9 f9 f9 f9 f9 f9 f9 f9
  0x0000800af7d0: f9 f9 f9 f9 f9 f9 f9 f9 f9 f9 f9 f9 f9 f9 f9 f9
  0x0000800af7e0: f9 f9 f9 f9 f9 f9 f9 f9 f9 f9 f9 f9 f9 f9 f9 f9
=>0x0000800af7f0: 00[f9]f9 f9 f9 f9 f9 f9 00 00 00 00 00 00 00 00
  0x0000800af800: 00 00 00 00 00 00 00 00 f9 f9 f9 f9 f9 f9 f9 f9
  0x0000800af810: f9 f9 f9 f9 f9 f9 f9 f9 f9 f9 f9 f9 f9 f9 f9 f9
  0x0000800af820: f9 f9 f9 f9 f9 f9 f9 f9 f9 f9 f9 f9 f9 f9 f9 f9
  0x0000800af830: f9 f9 f9 f9 f9 f9 f9 f9 f9 f9 f9 f9 f9 f9 f9 f9
  0x0000800af840: f9 f9 f9 f9 f9 f9 f9 f9 f9 f9 f9 f9 f9 f9 f9 f9
Shadow byte legend (one shadow byte represents 8 application bytes):
  Addressable:           00
  Partially addressable: 01 02 03 04 05 06 07
  Heap left redzone:       fa
  Freed heap region:       fd
  Stack left redzone:      f1
  Stack mid redzone:       f2
  Stack right redzone:     f3
  Stack after return:      f5
  Stack use after scope:   f8
  Global redzone:          f9
  Global init order:       f6
  Poisoned by user:        f7
  Container overflow:      fc
  Array cookie:            ac
  Intra object redzone:    bb
  ASan internal:           fe
  Left alloca redzone:     ca
  Right alloca redzone:    cb
  Shadow gap:              cc
==21498==ABORTING
../../util/wrap.pl ../../apps/openssl => 1
20-test_app.t .. 1/? l app with no args
20-test_app.t .. Dubious, test returned 1 (wstat 256, 0x100)
Failed 1/3 subtests

Test Summary Report
-------------------
20-test_app.t (Wstat: 256 Tests: 3 Failed: 1)
  Failed test:  1
  Non-zero exit status: 1
Files=1, Tests=3,  0 wallclock secs ( 0.02 usr  0.00 sys +  0.45 cusr  0.09 csys =  0.56 CPU)
Result: FAIL

When I was "debugging" (if I can call that "debugging") the last issue with test_cmp_cli, first I tried make test TESTS="test_cmp_cli" VF0=1 - but the output wasn't different from that without VF0=1, and added verbosity only after I also added V=1.

maybe you have again some local merge inconsistency or the like?

How can I say "no" after having one of those already? How can we check for it? I re-cloned since then, to make sure this (#12246) issue was not introduced by a faulty merge, so the likelihood isn't great - but it's possible.

Since your example of missing output in VFO=1 mode was based on that inconsistent merge state
that you had 1-2 days back: https://github.com/openssl/openssl/issues/12156#issuecomment-648217033
we likely cannot reproduce it and cannot take it as a witness for a flaw of VFO.
Whenever you come across a reproducible issue with it just let me know.

we likely cannot reproduce it and cannot take it as a witness for a flaw of VF0.
Whenever you come across a reproducible issue with it just let me know.

Sure.
In the meanwhile, are there any signs/lines of code in some file that I could look for, as a quick "smoke test"?

What I did for testing VFO=1 and VFP=1 was simply to take any test and locally change the expected outcome of (sub-)test cases.

$ make test TESTS="test_cmp_cli" VF0=1
/Applications/Xcode.app/Contents/Developer/usr/bin/make depend && /Applications/Xcode.app/Contents/Developer/usr/bin/make _tests
( SRCTOP=. \
	  BLDTOP=. \
	  PERL="/opt/local/bin/perl5.28" \
	  EXE_EXT= \
	  /opt/local/bin/perl5.28 ./test/run_tests.pl test_cmp_cli )
81-test_cmp_cli.t .. Dubious, test returned 1 (wstat 256, 0x100)
Failed 1/7 subtests

Test Summary Report
-------------------
81-test_cmp_cli.t (Wstat: 256 Tests: 7 Failed: 1)
  Failed test:  7
  Non-zero exit status: 1
Files=1, Tests=7, 29 wallclock secs ( 0.13 usr  0.02 sys +  8.69 cusr  4.93 csys = 13.77 CPU)
Result: FAIL
make[1]: *** [_tests] Error 1
make: *** [tests] Error 2

Will re-clone and repeat.

$ make test TESTS="test_cmp_cli" VF0=1

You've been using VF0=1 instead VFO=1 which stands for HARNESS_VERBOSE_FAILURES_ONLY.

Maybe we should go for less cryptic names :smile:
instead of VFO and VFP - suggestions welcome.

$ make test TESTS="test_app" VFO=1
/Applications/Xcode.app/Contents/Developer/usr/bin/make depend && /Applications/Xcode.app/Contents/Developer/usr/bin/make _tests
( SRCTOP=. \
	  BLDTOP=. \
	  PERL="/opt/local/bin/perl5.28" \
	  EXE_EXT= \
	  /opt/local/bin/perl5.28 ./test/run_tests.pl test_app )
20-test_app.t ..
Usage: help
../../util/wrap.pl ../../apps/openssl => 1
20-test_app.t .. 1/? l app with no args
20-test_app.t .. Dubious, test returned 1 (wstat 256, 0x100)
Failed 1/3 subtests

Test Summary Report
-------------------
20-test_app.t (Wstat: 256 Tests: 3 Failed: 1)
  Failed test:  1
  Non-zero exit status: 1
Files=1, Tests=3,  0 wallclock secs ( 0.02 usr  0.01 sys +  0.11 cusr  0.07 csys =  0.21 CPU)
Result: FAIL
make[1]: *** [_tests] Error 1

That's a known bug, fix in #12258

@richsalz OK, good to know.
@DDvO do you see the amount of output? I thought VFO=1 would tell more for the failing test?

Fixed.

@DDvO do you see the amount of output? I thought VFO=1 would tell more for the failing test?

@mouse07410, it does show all output of each failed (sub-)test case,
for instance (as long as the test_app contained that bug) the output I quoted above: https://github.com/openssl/openssl/issues/12246#issuecomment-648813603
I assume that in your case there is much less output because you did configure with enable-asan, which would show the bulky memory info.

it does show all output of each failed (sub-)test case,

Ah, so the provided output matches the expectations? In that case I'm OK.


Hotfix - Add Boosted Pool feature alert

Description
Adds a Boosted pool feature alert to the top of every page on mainnet linking to bb-a-USD.
Type of change

[ ] Bug fix (non-breaking change which fixes an issue)
[x] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[ ] Other

How should this be tested?

[ ] Test that the alert shows on mainnet but not other networks.

Checklist:

[x] I have performed a self-review of my own code
[x] I have commented my code where relevant, particularly in hard-to-understand areas
[x] My changes generate no new console warnings
[x] The base of this PR is master if hotfix, develop if not

@garethfuller I've pushed a small fix to the isMainnet check.


Not possible to get New York data (stop times) due 504 error

I'm integrating transitland feeds into own app and for New York state after offset=5784000 for stop times dataset I'm starting receiving 504 HTTP error. Is there a way how I can avoid this? API request that doesn't work for me is located below.
https://api.transit.land/api/v1/schedule_stop_pairs?offset=5784000&per_page=1&operator_onestop_id=o-dr5r-nyct
An image that explains the issue:

Hi @dmitrykinakh
For paging through large result sets, there is a sort_min_id query parameter that has better performance. When sort_min_id is used the pagination links will include the link to the next page.
https://api.transit.land/api/v1/schedule_stop_pairs?sort_min_id=3559561356&per_page=1&operator_onestop_id=o-dr5r-nyct
(this is the record with offset=5784000).


Routerstuff

REST

updated router
added resources:
AlgorithmResources
ExperimentResource
AnswerRatingResource

DB

updated DB-model & db.sql
new Experiments_Platform-Table
rename population -> calibration
added missing description to Algorithm_Answer_Quality & Algorithm_Rating_Quality
added missing insert-triggers for the algorithm tables
added new operations-classes:
AlgorithmOperations
CalibrationOperations
TagConstraintsOperations
updated most of the other operations-classes
added new transformation-classes:
AlgorithmsTransformation
AnswerRatingTransformation
CalibrationTransformation
ExperimentTransformation
TagConstraintTransformation

Protobuf

updated the generated protobuf-classes
rename population -> calibration
added algorithmOption & algorithmList
added RatingOptions in Template and Experiment

Protobuf renames need a commit in https://github.com/coolcrowd/spec.

i think i am roughy finished. Some improvements are still possible, but that can wait! @marcelhollerbach @kelunik

I am also done.

merge!

\o/


Have a way to regenerate the photo afterwards

Is your feature request related to a problem? Please describe.
Users want to have the possibility to rerun the picture generation from the raw image after changing the config.
Describe the solution you'd like
A dedicated command to rerun the whole generation/
Describe alternatives you've considered
I can't find one.

For me the development is finished in f9bc75a9d92f609c5af7479b55ae39b7ca7c8938. The only part missing is the effects, but they are done when the image is captured and not when the final image is generate there is no mean to remove them / add a new one.


Unexpected test results for Reock

Tests result scores running the Reock scores differ from the Reock scores calculated in Azavea's white paper. Potentially related to #3.

test district
CD_CA_24
CD_MA_9

expected
0.3009
0.3407

returned
0.1991
0.2714

closing this out as it doesn't seem to be a bug but an unintended consequence of how we are treating multi-polygons. feature request opened in #10


Maven plugins need to update maven-metadata.xml for the group

I tried to publish a release of maven-hpi-plugin but was stymied:
…
[INFO] [INFO] --- maven-deploy-plugin:2.6:deploy (default-deploy) @ maven-hpi-plugin ---
[INFO] [INFO] Uploading to maven.jenkins-ci.org: https://repo.jenkins-ci.org/releases/org/jenkins-ci/tools/maven-hpi-plugin/3.4/maven-hpi-plugin-3.4.jar
[INFO] [INFO] Uploaded to maven.jenkins-ci.org: https://repo.jenkins-ci.org/releases/org/jenkins-ci/tools/maven-hpi-plugin/3.4/maven-hpi-plugin-3.4.jar (141 kB at 108 kB/s)
[INFO] [INFO] Uploading to maven.jenkins-ci.org: https://repo.jenkins-ci.org/releases/org/jenkins-ci/tools/maven-hpi-plugin/3.4/maven-hpi-plugin-3.4.pom
[INFO] [INFO] Uploaded to maven.jenkins-ci.org: https://repo.jenkins-ci.org/releases/org/jenkins-ci/tools/maven-hpi-plugin/3.4/maven-hpi-plugin-3.4.pom (12 kB at 45 kB/s)
[INFO] [INFO] Downloading from maven.jenkins-ci.org: https://repo.jenkins-ci.org/releases/org/jenkins-ci/tools/maven-hpi-plugin/maven-metadata.xml
[INFO] [INFO] Downloaded from maven.jenkins-ci.org: https://repo.jenkins-ci.org/releases/org/jenkins-ci/tools/maven-hpi-plugin/maven-metadata.xml (2.7 kB at 25 kB/s)
[INFO] [INFO] Downloading from maven.jenkins-ci.org: https://repo.jenkins-ci.org/releases/org/jenkins-ci/tools/maven-metadata.xml
[INFO] [INFO] Downloaded from maven.jenkins-ci.org: https://repo.jenkins-ci.org/releases/org/jenkins-ci/tools/maven-metadata.xml (385 B at 5.0 kB/s)
[INFO] [INFO] Uploading to maven.jenkins-ci.org: https://repo.jenkins-ci.org/releases/org/jenkins-ci/tools/maven-hpi-plugin/maven-metadata.xml
[INFO] [INFO] Uploaded to maven.jenkins-ci.org: https://repo.jenkins-ci.org/releases/org/jenkins-ci/tools/maven-hpi-plugin/maven-metadata.xml (2.6 kB at 11 kB/s)
[INFO] [INFO] Uploading to maven.jenkins-ci.org: https://repo.jenkins-ci.org/releases/org/jenkins-ci/tools/maven-metadata.xml
[INFO] [INFO] ------------------------------------------------------------------------
[INFO] [INFO] BUILD FAILURE
[INFO] [INFO] ------------------------------------------------------------------------
[INFO] [INFO] Total time:  21.708 s
[INFO] [INFO] Finished at: 2019-03-28T11:54:03-04:00
[INFO] [INFO] ------------------------------------------------------------------------
[INFO] [ERROR] Failed to execute goal org.apache.maven.plugins:maven-deploy-plugin:2.6:deploy (default-deploy) on project maven-hpi-plugin: Failed to deploy metadata: Could not transfer metadata org.jenkins-ci.tools/maven-metadata.xml from/to maven.jenkins-ci.org (https://repo.jenkins-ci.org/releases/): Access denied to: https://repo.jenkins-ci.org/releases/org/jenkins-ci/tools/maven-metadata.xml -> [Help 1]

It seems this file gets uploaded, even though it is unchanged, to record
<plugin>
  <name>Maven Jenkins Plugin</name>
  <prefix>hpi</prefix>
  <artifactId>maven-hpi-plugin</artifactId>
</plugin>

so the publisher needs to have permission to the parent directory as well.
I assume from the lack of trailing /s that paths only lists directories, not individual file paths.
@daniel-beck @oleg-nenashev @batmat @olamy @stephenc

This will not work, it's not allowing arbitrary suffixes.

it's not allowing arbitrary suffixes

Sorry, can you explain what that means? What would I need to change?

Sorry, can you explain what that means? What would I need to change?

I would suggest adding the groupId containing the unexpected maven-metadata.xml, instead of replacing existing paths.
Run the tool in dry-run mode to see what paths in Artifactory are allowed, or check PR build: https://ci.jenkins.io/job/Infra/job/repository-permissions-updater/job/PR-1074/1/artifact/json/component-maven-hpi-plugin.json/view/
As you can see, paths you need (to actual artifacts) are now gone.

--- base.txt	2019-03-28 12:59:46.842535143 -0400
+++ amended.txt	2019-03-28 12:59:52.386520555 -0400
@@ -1,3 +1,10 @@
+org/jenkins-ci/tools/*/maven-hpi-plugin-*
+org/jenkins-ci/tools/*/maven-metadata.xml
+org/jenkins-ci/tools/*/maven-metadata.xml.sha1
+org/jenkins-ci/tools/*/maven-metadata.xml.md5
+org/jenkins-ci/tools/maven-metadata.xml
+org/jenkins-ci/tools/maven-metadata.xml.sha1
+org/jenkins-ci/tools/maven-metadata.xml.md5
 org/jenkins-ci/tools/maven-hpi-plugin/*/maven-hpi-plugin-*
 org/jenkins-ci/tools/maven-hpi-plugin/*/maven-metadata.xml
 org/jenkins-ci/tools/maven-hpi-plugin/*/maven-metadata.xml.sha1
@@ -5,10 +12,3 @@
 org/jenkins-ci/tools/maven-hpi-plugin/maven-metadata.xml
 org/jenkins-ci/tools/maven-hpi-plugin/maven-metadata.xml.sha1
 org/jenkins-ci/tools/maven-hpi-plugin/maven-metadata.xml.md5
-org/jvnet/hudson/tools/maven-hpi-plugin/*/maven-hpi-plugin-*
-org/jvnet/hudson/tools/maven-hpi-plugin/*/maven-metadata.xml
-org/jvnet/hudson/tools/maven-hpi-plugin/*/maven-metadata.xml.sha1
-org/jvnet/hudson/tools/maven-hpi-plugin/*/maven-metadata.xml.md5
-org/jvnet/hudson/tools/maven-hpi-plugin/maven-metadata.xml
-org/jvnet/hudson/tools/maven-hpi-plugin/maven-metadata.xml.sha1
-org/jvnet/hudson/tools/maven-hpi-plugin/maven-metadata.xml.md5

after getting JSON and processing with
jq -r '.includesPattern | split(",") | join("\n")'

So that looks right.


No docs generated by docs/CMakeLists.txt

following the instruction in INSTALL, and run:
mkdir build;cd $_;cmake .. -DCMAKE_INSTALL_PREFIX=./usr;make;cd -
There's no docs generated at all. Did I miss something?

Fixed in #48


Automerge/Score-Plugin Actions Skipped

Several recent web submission PRs (#781 #782 #783 #785 #788 #789) have passed all tests but the automerge and subsequent actions were skipped. Not sure if this is related to #689?
Thanks in advance for looking into this!

Fixed!

Seems to still be occurring, reopening until fixed completely.

Fixed!


Use default registry instead of default account for authorization token

Use default registry account for authorization token instead of the default registry associated with the authenticating AWS account.

/approve

/lgtm


Space in URL causes crash

I am testing master branch with Swift 1.2 on Xcode 6.4. When Url has space inside it crashes. Example usage
let url = "http://www.example.com/abc/def.asp?k=abc def"

self.mngr.request(.GET, url)

Crashing function:
// MARK: - Convenience
func URLRequest(method: Method, URLString: URLStringConvertible, headers: [String: String]? = nil) -> NSMutableURLRequest {
    let mutableURLRequest = NSMutableURLRequest(URL: NSURL(string: URLString.URLString)!) //crash!
    mutableURLRequest.HTTPMethod = method.rawValue

    if let headers = headers {
        for (headerField, headerValue) in headers {
            mutableURLRequest.setValue(headerValue, forHTTPHeaderField: headerField)
        }
    }
    return mutableURLRequest
}

If I use parameters and use it like below
let url = "http://www.example.com/abc/def.asp"
let parameters = ["k":"abc def"]
self.mngr.request(.GET, url,parameters:parameters)

It doesn't crash.

I think this crash comes from NSURL(string: URLString.URLString)! since you're passing in an invalid URL (URLs may not contain spaces).
URLs should be urlencoded and thus any spaces should be replaced with %20. The second example you have shown is properly encoding and escaping characters and thus doesn't crash.

Alamofire properly encodes if it is given as parameters. However it is not always possible to use parameters for every request. I believe that Alamofire should URL encode give string. Since Alamofire wants String as input and it converts to URL thanks to URLStringConvertible. If Alamofire required URL as input, then it was the responsibility of developer to give proper URL. Instead of implicitly unwrapped optional, simple check for URL can solve this problem.Just my 2 cents.

I agree with tosbaha.  This one caught me off guard as I was expecting Alamofire to follow the standards.  Maybe catch this and display an error message at the least.

@tosbaha If Alamofire URL encoded your input, it still wouldn't become a URL because the : and / would be escaped.
http%3A%2F%2Fwww.example.com%2Fabc%2Fdef.asp%3Fk%3Dabc%20def

What I mean is, Alamofire could check if URL is valid instead of implicitly unwrapping it. Another way is encoding URL with something like escape function in ParameterEncoding.swift. I refactored all my code to use either parameters and when there are no parameters I use string extension to escape.

@tosbaha the docs state:
public protocol URLStringConvertible {
    /**
        A URL that conforms to RFC 2396.

        Methods accepting a `URLStringConvertible` type parameter parse it according to RFCs 1738 and 1808.

        See https://tools.ietf.org/html/rfc2396
        See https://tools.ietf.org/html/rfc1738
        See https://tools.ietf.org/html/rfc1808
    */
    var URLString: String { get }
}

If you do not end up using the Alamofire ParameterEncoding, then you risk the possibility of certain characters not being escaped properly. This is exactly why we would recommend you always use the ParameterEncoding enumeration to do this. The URLStringConvertible protocol is merely convenience. It should not be used in cases where you are not confident that the URLString is valid.
We do not want to combine the concept of character escaping with the URLStringConvertible protocol because as @kylef mentioned, there can be some very strange behavior that causes way more harm then good.
Best of luck.

Thanks for the comment. I can understand that you don't want to increase complexity. However instead of implictly unwrapping we could check for correct URL and return error. I believe that failing is better than crashing. Best regards.


Add accounts index check (PR 1)

Acceptance Criteria

[x] a component/unit test (i.e. a core test) that injects higher than expected index
[x] a test that injects -1 as the index

fixes #332

At what point will the account index outside of bounds be checked? Has execution started?

@kanej yes, the very first step of execution, actually (init execution state in the engine)


Correction for raw affiliation CBGP, IRD, CIRAD, INRAE, Institut Agro, Univ Montpellier,; CBGP, IRD, INRAE, CIRAD, Montpellier SupAgro, Univ Montpellier, Montpellier, France

Correction needed for raw affiliation CBGP, IRD, CIRAD, INRAE, Institut Agro, Univ Montpellier,; CBGP, IRD, INRAE, CIRAD, Montpellier SupAgro, Univ Montpellier, Montpellier, France
raw_affiliation_name: CBGP, IRD, CIRAD, INRAE, Institut Agro, Univ Montpellier,; CBGP, IRD, INRAE, CIRAD, Montpellier SupAgro, Univ Montpellier, Montpellier, France
new_rors: 05q3vnk25;03rnk6m14;003vg9w96;05kpkpg04;051escj72;05h7ddb14
previous_rors: 05q3vnk25;03rnk6m14;003vg9w96;05kpkpg04;051escj72
works_examples: W4382862923
contact: 458ce553f5799e0bd563596a4c3b2708:ad5730b695d68da52238a85f3239c979ebad @ inrae.fr

This issue was accepted and ingested by the OpenAlex team on 2024-11-18. The new affiliations should be visible within the next 7 days.


Update secret key base configuration due to rails 5.2 changes

What happened
✅ Remove secret key base from env
Insight
Since Rails 5.2, the secret is changed. Right now if we create a new application, the secret key base is set in config/credentials.yml.enc where content is encrypted with the master.key.
The credentials.yml.enc

The initial content that comes with rails

To view/edit the credentials
EDITOR="<editor_cli> --wait" rails credentails:edit

# For example, I use vscode.
EDITOR="code --wait" rails credentails:edit
# But I cannot find a way for RubyMine because it is not support `--wait` option

To view/edit, it needs the config/master.key to decrypt the file. This file is not committed to the repository and should be kept+managed by ourself.
For production, we can place that key on the server or set by environment RAILS_MASTER_KEY.
To access the credentials in the code we can do
Rails.application.credentials.secret_key_base

More info on credentails: https://guides.rubyonrails.org/security.html#custom-credentials

@rosle this needs rebasing


y-websocket provider

coming from this issue https://github.com/y-crdt/ypy/issues/154
i don't find how to synchronize map changes between different python clients. using websocket.
can someone give me an example ?

You cannot modify a shared type inside the callback of an observer. What you could do is schedule the modification for after the callback is done, for instance using an asyncio task.


Unhelpful error message when trying to "Approve and pay" an invoice and you are not a host

You can't approve a transaction without linking your PayPal account
(and btw, I do have a PayPal account linked, or at least that's the impression I get when I look at my profile)

Same issue as this: https://github.com/OpenCollective/OpenCollective/issues/89


Modal AfterText assign to a DOM

myApp.app.modal({            title: '',            text: 'Enter number',            afterText:  DOM  ,        })
From the documentation, we can pass html String.
How can i assign AfterText param to Html DOM?

Dom element is not supported here, only string


[Security] Ability to logout user and more

Gitea version (or commit ref): all
Git version: not relevant
Operating system: not relevant
Database (use [x]):

[ ] PostgreSQL
[ ] MySQL
[ ] MSSQL
[ ] SQLite

Can you reproduce the bug at https://try.gitea.io:

[x] Yes (provide example URL)
[ ] No
[ ] Not relevant

Log gist:

Description
Screenshots
None

Quick fix could wrap all user content in iframe with sandbox attr set; all recent browsers support this.

Fixed by #10462, #10465


KAFKA-15391: Handle concurrent dir rename which makes log-dir to be offline unexpectedly

JIRA ticket: https://issues.apache.org/jira/browse/KAFKA-15391

As described in the ticket, local log directory might be renamed (with adding -delete) by topic deletion concurrently with async log-flush tasks for log-rolling, which may cause NoSuchFileException on flush timing and mark the log-dir offline unexpectedly
This PR adds a handling for NoSuchFileException on flush timing

Committer Checklist (excluded from commit message)

[ ] Verify design and implementation
[ ] Verify test coverage and CI build status
[ ] Verify documentation (including upgrade notes)

@divijvaidya Could you take a look?

Backporting this to 3.5 and merging to 3.6 branch.


Bad link to Ledger instructions

The link from the desktop wallet page with the Ledger instructions is broken. Looks like the correct link should be https://www.hiro.so/wallet-faq/how-can-i-use-my-ledger-device-with-stacks-wallet

Resolved in new web layout!


KAFKA-7047: Added SimpleHeaderConverter to plugin isolation whitelist

This was originally missed when headers were added as part of KIP-145 in AK 1.1. An additional unit test was added in line with the StringConverter.
This should be backported to the AK 1.1 branch so that it is included in the next bugfix release. The SimpleHeaderConverter class that we're referencing was first added in the 1.1.0 release, so there's no reason to backport earlier.
Committer Checklist (excluded from commit message)

[ ] Verify design and implementation
[ ] Verify test coverage and CI build status
[ ] Verify documentation (including upgrade notes)

@kkonstantine would you mind reviewing? Related to #5198, but this should be backported (see above).

@ewencp here's another PluginUtils change. This should be backported to 1.1 branch. Thanks!


@ionic/react: Add missing components

Thanks for the PR, but this is still under heavy development in a branch.  Once we have an alpha release we will be ready to start accepting PRs.

Thanks for the info.


[fix] regular expression of URL scalar type

resolve #17

If the tests passed (I wasn't able to see the results of Semaphoreci at this link), then I would say this is a great addition. Thanks, @igtm.


Update updeep dependency to latest version

There seems to be a problem with the currently used npm package<EMAIL_ADDRESS>which requires an old peer of lodash (v3.0.0).
Using gulp with Browserify and a newer version of lodash creates a lot of "Cannot find module lodash/collection/......" errors for me. The latest version of updeep requires at least<EMAIL_ADDRESS>so updating to the latest updeep version should fix that.
Installing the latest version 0.14.0 of updeep as a root dependency in my project fixed it for me.

@uneart Updated and published as 0.6.3. Thanks!


Bad interpreter on Ubuntu / WSL2

On Ubuntu / WSL2 i get this error Message:
~/mkp224o$ ./autogen.sh -bash: ./autogen.sh: /bin/sh^M: bad interpreter: No such file or directory
The file is untouched and should be correct.

Solved with:
sed -i -e 's/\r$//' autogen.sh


Chore/polish new block stream

Resolves #74

@honestbonsai is this branch ready for review?

@adrianmcli Yup it's ready now, tests are fixed! Sorry if it wasn't clear if the branch was ready to be reviewed.

@adrianmcli Resolved most of your comments, replied to another. It's ready to be reviewed again.

Have a look at my comment above and let's just merge this for now. I can add that new simplified cleanUp API in another PR.

Go ahead and merge when CI passes.


call clearAckInterval() on connection close event

This was causing my test suite to hang.

Hey @mikestaub , thanks for catching this. I'm merging this in but please have a look at rabbot.


Unable to list playlist and albums in Spotify.

I have a BMW 520D (2018) iDrive5 i believe.
Until last week everything was working fine but now, i can no longer browse any playlists or albums i have in Spotify.
I have checked all the settings in AAIdrive and Spotify itself and nothing has changed so I have no idea what the issue is.
I can still play Spotify via AAIdrive but i have to control is via the phone which obviously isnt going to happen when im driving.
Any help would be greatly appreciated
Sunil

I have the exact same problem, everything was working fine until a few days ago.
BMW F20 (2018) iDrive5 (iD6 Lite UI)

Glad im not the only one. Thought i was going mad....
Its been doing my head in. Ive also disconnected and reconnected my phone to the car, still nothing.

Same issue for me as well. In the last few days, the Spotify library is always empty. I have tried to reauthenticate "Ability to browser your Spotify library" in the AAIdrive app, but without any change.

Same here since this afternoon. This morning browsing was possible.

Very curious, thanks for letting me know!
Looking further, it looks like Spotify itself has changed, and is now returning exceptions when trying to browse the top level folder. Browsing a different folder seems to work perfectly.
I've posted to the Spotify Developer Forum and the Spotify Android SDK, hopefully they notice and fix it soon!
This is similar to when they broke the code to view the shuffle/repeat status a few years ago.

Spotify library was working back properly this morning.

Checked this morning and its still the same.
@Esco54 Did you do anything different to get yours to work?

@Wolfsbane1979 Not really. Disabled only one option that says something with IDrive 5 in the settings.

@Esco54 Any chance you could send a screen shot or description of what the setting is and where to find it on the AAiDrive app?
I can test it when i get to the car after work.

Hello! Just jumping in with the same issue, noticed it a couple days ago and today I confirmed it.
@Wolfsbane1979 I have found (I think I have at least) the setting that @Esco54  is mentioning. It's in the AAiDrive app, under "Settings", then you have to enable "Show Advanced Settings" and then appears an option that's "Always appear as Spotify app in IDrive5+".
Haven't tested it myself, but will do this evening and update in case there's any relevant change!

@r3dalk Thanks for that mate, ill have a crack after work too. Hopefully it gets things working till they fix it properly in the background :-)

No, that Always Appear As Spotify setting does not affect browsing, and also doesn't affect people who have Spotify installed. For people who don't have Spotify installed, AAIdrive will add itself as the old Audioplayer app to the car, but this old app doesn't support global coverart and doesn't fit in with the rest of IDrive5's UI. With this option, AAIdrive will add itself as a Spotify app to enable global coverart, but the car will show a Spotify app when there is no Spotify installed.
You can test for browse support by tapping into AAIdrive's Music tab on the phone, and tapping Spotify, and then the Browse tab. This uses the same browse connection that the car would be using, but conveniently without a car.
What version and region of Spotify does everyone have? My <IP_ADDRESS>2 from the US does not have working browsing, currently.

@hufman Thanks for clarifying. Guess we will just have to wait until the issue is resolved. Any idea when that might be?

Spotify is still working today.
<IP_ADDRESS>2 EU

Just open the library...do not click on anything else and wait. After 2-3 seconds the library starts to unfold.

@hufman Spotify Browse/Search not working either, version <IP_ADDRESS>2 EU on a Samsung S23 Ultra

I am having the same problem. Is it possible Spotify had a recent update that is causing the problem?

Spotify updated last on June 18th

I've been having the same issue for the last few days. I had thought it was android messing up permissions again, but testing in the spotify tool in android gave the same results as I saw in the car, and I played around making sure everything was authorised and that was all OK so I figure there must be some sort of api change. I've not really explored the apps code yet so I still need to get an understanding of how it works. I'll hopefully try and set up a test environment and also take a look at the spotify api's over the weekend.

@Esco54 I tried your approach, waited for an entire journey home (20mins) but it remained with an 'Empty' status.
@hufman  I've also noticed that recently, occasionally, when playing a playlist (From the phone), i am unable to browse to a manually selected track in that playlist from the car. All it does is start the current track again.
I too have version  <IP_ADDRESS>2 EU.

After new Spotify app update <IP_ADDRESS>2, the Browsing is working again!

My phone also updated to <IP_ADDRESS>2 and browsing works again!

Yes! Same here, Spotify <IP_ADDRESS>2 EU working!

I can also confirm the browsing is working again.
Thanks team for your help :-)

@hufman Apologies but this issue is not fully resolved. Whilst the playlist and albums are now available to select there is another problem i am experiencing. If i load a playlist, i cannot select another track from that playlist via the car.. If I do, the first song starts again. This is the same with albums too. The only option i have is to select next.
Again, i can only pick a song i want via the phone, any attempt from car results in the above issue.

That is a separate issue, as you've opened in #797


Input node is not  complete

Hi , I got this error when only using reshape and softmax. And I'm wondering why?
my input is
data (batch_size, time, dim)
label(batch_size, time)
time is changeable for different batch.
and net is like
rsdata= Reshape(data,shape=(0,dim))
rslabel= Reshape(label,shape=(0,))
out= softmaxoutput(rsdata,rslabel)
In order to call softmaxoutput, I reshaped them with (0,dim) and (0,) respectively. The reshaped ones are fed into softmax layer. I took dim here as label # to test infershape.
The C++ infershape function did compute the correct output size for both cases. But according the python code, sth is wrong when getting the shapes.

Could you post a minimal script that reproduces this error?

@piiswrong
I just checked #1569 and found that feed forward net doesn't support 2nd label with 2nd dim greater than 1. I need to rewrite my data iterator and check if that works. I think that will work.


entc/gen: allow skipping of format step

In the development cycle, sometimes it is needed to run Ent generate multiple times in a row (such as when rebasing), and this can be quite costly in terms of time (in my case, on the order of minutes for each generation). A large amount of the time is just spent running goimports on all the files, so this feature allows the user to skip that step for the sake of time.
For my particular use case, we would just be running goimports later in a CI step required before merging, so it just moves it out of the critical path of development iteration and into the "ready to merge" phase.

After some more usage, I am not so sure this will work since the goimports step removes some duplicated code. I guess my follow up question though is whether the call to goimports can possibly be removed by adding some extra logic to ent?


add default user/pw

add default user/pw

We actually rotate the password in the cloud-init scripts and would rather not have it exposed in docs in public domain. We include the password in the the Google Sheet we share with attendees.


HL-870 | Wrong number of applications on front page's tabs

Description :sparkles:
Application numbers were shown wrong. This whole thing was a bit of pricy earlier so I ended up refactoring the whole <ApplicationList>.
No longer does every instance of <ApplicationList> fetched data by it's own. Data flows now from parent to component which means there's less queries. If invalidation becomes an issue with the tabs then implement  onClick invalidation for <TabPanel> or refactor useApplicationQuery to useApplicationListQuery for single AND application query and apply where needed.

Codecov Report

Merging #2147 (72f0a5d) into develop (2e4d8c1) will decrease coverage by 8.85%.
The diff coverage is 20.51%.

@@             Coverage Diff             @@
##           develop    #2147      +/-   ##
===========================================
- Coverage    20.65%   11.80%   -8.85%
===========================================
  Files          577      160     -417
  Lines        11918     4463    -7455
  Branches      2887     1114    -1773
===========================================
- Hits          2462      527    -1935
+ Misses        9052     3767    -5285
+ Partials       404      169     -235

Impacted Files
Coverage Δ

...mponents/applicationList/useApplicationListData.ts
0.00% <0.00%> (ø)

...src/components/applicationList/ApplicationList.tsx
53.96% <85.71%> (-3.39%)
:arrow_down:

...c/components/applicationList/useApplicationList.ts
100.00% <100.00%> (+48.57%)
:arrow_up:

frontend/benefit/handler/src/constants.ts
100.00% <100.00%> (ø)

... and 444 files with indirect coverage changes
:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more


How you've got repository star history?

Great dashboards comparison. I especially like the first look at stars comparison, but chart with history of stars is awesome. Is it possible to find anywhere star history of any repo?
Do you know any services that help comparing repositories polarity etc?

Ok. Seems I've found it.
https://star-history.com/#bastienwirtz/homer&Date


Show reputation of contacts

Now that anyone can endorse, it would make sense to indicate who's a newbie in contacts. This way, the user can chose to endorse known newbies directly
Maybe the app could even show a little disturbance to draw attention to this action

For the beginning before we have UX we can simply show the following beneath the contact name in the list-tile.
Reputation: 3


Apply networkX library methods on graph

Use the adjacency matrix we already have and apply the networkX functions to display on the graph pages.

Duplicate of #115


Synchronous state machine

Depends on #7.

Represent the state machine as Property instead of SignalProducer.
self.state = Property(initial: State.initial,
                      reduce: State.reduce,
                      feedbacks: feedbacks)

Drop the mandatory scheduler requirement.
The state machine has now an unbound event queue that flattens recursive events.

Tweaked the implementation so that only one copy of the state is stored by the state machine.

The examples have been updated with the new API, and some minor visual tweaks.

Interesting =) Does it pass this test tho?

@sergdort No. Now that the system is a hot subject, the test constitutes an infinite feedback loop. It won't deadlock though, just spinning forever.

I see several issues with this approach:

We are no longer in control of the state machine. e.g we can no say take(first:) or takeUntill, replayLazyly and etc. Which means are not able to create composable System.
According to current implementation state machine is running before even Property initialized. This is very important IMO as somebody who would want to be interested in all changes of the state will lose it. And IMO it this wrong from Rx and ReactiveSwift idea as SignalProducer is deferred piece of work
If somebody would want to start the system again they would need to wire everything again. Instead of calling start on SignalProducer
I also feel like this implementation fits only MVVM but what if someone would want to do something similar to Elm and treat UI as another FeedbackLoop and wire everything in ViewController

P.S Also I feel like this approach is less elegant (Please don't get me wrong, I'm not defending my implementation as essentially I just translate it to ReactiveSwift)

I would not want to put any user of the library into "frames" - "This is only way you can use it"
I would like a users to decide what best fits their needs and architectural approach, so IMHO exposing SignalProducer is the best approach.

According to current implementation state machine is running before even Property initialized.

Even if it is created as a SignalProducer initially, as you drop it into Property(initial:then:) the side effects start immediately.

This is very important IMO as somebody who would want to be interested in all changes of the state will lose it.

Whenever you promote a stream to Property which has a stronger contract, one loses all values prior to the current state.
In most UI purposes, it doesn't really matter. Let's say why should I care if a screen was loading in the past if it is already loaded? Generally, only the present and the future is ever concerned.

And IMO it this wrong from Rx and ReactiveSwift idea as SignalProducer is deferred piece of work

Deferred until you start it. Promotion to Property starts it implicitly.

If somebody would want to start the system again they would need to wire everything again. Instead of calling start on SignalProducer

The actual question is perhaps why anybody would need to do it with finite state machine in mind. If one needs to restart, it smells like a bad design.

I also feel like this implementation fits only MVVM but what if someone would want to do something similar to Elm and treat UI as another FeedbackLoop and wire everything in ViewController

I would not want to put any user of the library into "frames"

We are no longer in control of the state machine. e.g we can not say take(first:) or takeUntill, replayLazyly etc. Which means are not able to create composable System.

A producer variant can always be introduced as needed. The fact is that we need only a Property variant for now, more or less evidenced by our two spikes.
Of course, the real question is what scenarios such capabilities are needed for. The system itself is already composable in terms of feedbacks.
Given existing examples of ours and RxFeedback, I have yet to be convinced why using Property is a problem. All examples start the state machine immediately after its creation.

@andersio  Something wrong is going on with the example

@sergdort The bug in the example was fixed. GIF updated. Guess I misunderstood how newMovies is supposed to interact with the VC. 💁♂

Adding property convenience initialiser would be raised as a separate PR. I would not proceed on tweaking the implementation since the time spent has exceeded the expectation, and it already works fairly well in the spikes.


Invalid argument supplied for foreach()

Hello,
I try to use this package and... it is good! very nice!
i found i little problem when i'm in the "site.app:8000/access/users/create".
I fill the fields and press "Save". The sistem create new user correctly, but then, i rest in the same page
and i see this error "Invalid argument supplied for foreach()".
Can you help me?
Other information : the "version" of my installation is "Installing rappasoft/vault (dev-master 7bf215c)" (readed during "composer update" command)

Hmm weird you shouldn't, even if you don't choose a role it will create the user and deactivate them, then return you to the edit user page for that user. If then you don't see the user, check the deactivated section. The only thing it should be looping over during creation are the roles and permissions.
I've made a bunch of users and cant replicate your problem :(

Hello, this is my screenshot (see link 1 and link 2)
Form step 1
Form step 2
If you want i have "debug bar".
Tnx for reply :+1:

Hey there. Sorry I have been busy the last few days. I will try to debug this for you soon.

I can't replicate this issue. If you send me the project maybe I can debug it.

I'm gonna push a fix right now.


Fix CanvasRenderer "translate" parameter behaviour

As I said in #5891, that's dangerous area.
Broken: https://www.pixiplayground.com/#/edit/xkHG6hYV_bu~NVmasKWZL
Fixed: https://www.pixiplayground.com/#/edit/yht49knRJxXSSZ_zBQ2iq

1 Test

Problem was discovered by @a-rasinski and @themoonrat

Codecov Report

Merging #6133 into dev will increase coverage by 0.04%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##              dev    #6133      +/-   ##
==========================================
+ Coverage   71.63%   71.67%   +0.04%
==========================================
  Files         213      213
  Lines       10736    10752      +16
==========================================
+ Hits         7691     7707      +16
  Misses       3045     3045

Impacted Files
Coverage Δ

...kages/canvas/canvas-renderer/src/CanvasRenderer.js
85.84% <100%> (+0.27%)
:arrow_up:

...ages/canvas/canvas-renderer/test/CanvasRenderer.js
100% <100%> (ø)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d4d0ee6...9162d5c. Read the comment docs.


Balanced accuracy comparison with sk-learn

In MLJBase tests (which pass) there is a score for the sk-learn implementation used for comparison that I cannot reproduce:
In [8]: from sklearn.metrics import balanced_accuracy_score

In [9]: y = [3, 4, 1, 1, 1, 4, 1, 3, 3, 1, 2, 3, 1, 3, 3, 3, 2, 4, 3, 2, 1, 3,
   ...:     3, 1, 1, 1, 2, 4, 1, 4, 4, 4, 1, 1, 4, 4, 3, 1, 2, 2, 3, 4, 2, 1,
   ...:     2, 2, 3, 2, 2, 3, 1, 2, 3, 4, 1, 2, 4, 2, 1, 4, 3, 2, 3, 3, 3, 1,
   ...:     3, 1, 4, 3, 1, 2, 3, 1, 2, 2, 4, 4, 1, 3, 2, 1, 4, 3, 3, 1, 3, 1,
   ...:     2, 2, 2, 2, 2, 3, 2, 1, 1, 4, 2, 2]

In [10]: ŷ = [2, 3, 2, 1, 2, 2, 3, 3, 2, 4, 2, 3, 2, 4, 3, 4, 4, 2, 1, 3, 3, 3,
   ...:     3, 3, 2, 4, 4, 3, 4, 4, 1, 2, 3, 2, 4, 1, 2, 3, 1, 4, 2, 2, 1, 2,
   ...:     3, 2, 2, 4, 3, 2, 2, 2, 1, 2, 2, 1, 3, 1, 4, 1, 2, 1, 2, 4, 3, 2,
   ...:     4, 3, 2, 4, 4, 2, 4, 3, 2, 3, 1, 2, 1, 2, 1, 2, 3, 1, 1, 3, 4, 2,
   ...:     4, 4, 2, 1, 3, 2, 2, 4, 1, 1, 4, 1]

In [11]: balanced_accuracy_score(ŷ, y)

Out[11]: 0.17544466403162054

In tests the claim is for 0.17493386243386244 which is ball-park close but not that close.
I got the same answer using a newer and mach older python/sklearn installation (2.7.13 / 0.18.1)
@tlienart Are you still able to reproduce this python result, or recall anything to explain the difference here?

The same issue exists for the weighted version, and (after an imminent PR), the adjusted version.

I think this should clarify it:
>>> balanced_accuracy_score(ŷ, y)
0.17544466403162054
>>> balanced_accuracy_score(y, ŷ)
0.17493386243386244

the standard in sklearn is to put the ground truth first (see: https://scikit-learn.org/stable/modules/generated/sklearn.metrics.balanced_accuracy_score.html)

Okay, I feel pretty stupid 🙄 . Thanks for this prompt resolution!

Haha no worries, glad I could help in this case!


[infra] attempt to fix timeout on blocking render

Currently GitHub actions timeout and thus never run integration tests.
This is an attempt at a quick fix, to unblock us cheaply so working on Lit 3.0 release can go smoothly.

Failed. But ruled out some options.


[#220] Enable string functions for XPathValue and BODY_XPATH.

Hi @amduser.
Thank you so much for your contribution. The changes looks great. However, before accepting them we require all contributors to sign our CLA: https://www.apache.org/licenses/icla.pdf.
Once sign, I will merge in the pull request.
Once again, thank you so much.
Best regards,
Karl Dahlgren


[Snyk] Security upgrade @backstage/errors from 0.0.0-use.local to 0.1.1

Snyk has created this PR to fix 1 vulnerabilities in the yarn dependencies of this project.
Snyk changed the following file(s):

package.json

Note for zero-installs users
If you are using the Yarn feature zero-installs that was introduced in Yarn V2, note that this PR does not update the .yarn/cache/ directory meaning this code cannot be pulled and immediately developed on as one would expect for a zero-install project - you will need to run yarn to update the contents of the ./yarn/cache directory.
If you are not using zero-install you can ignore this as your flow should likely be unchanged.

⚠ Warning
Failed to update the yarn.lock, please update manually before merging.

Vulnerabilities that will be fixed with an upgrade:

Issue
Score

Directory Traversal SNYK-JS-SOURCEMAPSUPPORT-6112477
  170

[!IMPORTANT]

Check the changes in this PR to ensure they won't cause issues with your project.
Max score is 1000. Note that the real score may have changed since the PR was raised.
This PR was automatically created by Snyk using the credentials of a real user.

Note: You are seeing this because you or someone else with access to this repository has authorized Snyk to open fix PRs.
For more information:
🧐 View latest project report
📜 Customise PR templates
🛠 Adjust project settings
📚 Read about Snyk's upgrade logic

Learn how to fix vulnerabilities with free interactive lessons:
🦉 Directory Traversal

:tada: Snyk checks have passed. No issues have been found so far.
:white_check_mark: security/snyk check is complete. No issues have been found. (View Details)
:white_check_mark: license/snyk check is complete. No issues have been found. (View Details)


e2e:chore - test for insecure skip verify flag

- What I did
E2e  test for --insecure-skip-verify flag
- How to verify it
Run test-e2e
- Description for the changelog
N/A

Signed-off-by: lucas.bruno<EMAIL_ADDRESS>

Please, resolve the conflicts @lucasbrunozup


Miniapp icons need to respond to dark mode/different sizes

Currently on dark mode, the Mini-app icons blend into the background. We should look at how other ecosystems deal with this - perhaps a light and dark property inside the image property? and different image sizes? (which)

I dealt with this issue in opencast by adding a white background. Perhaps an option to consider

looks pretty good actually

fixed


Net Worth Report - Initial Collapsible Sidebar Support

Make sure collapse sidebar button is first
Dynamically add buttons to collapsed menu

Thanks again!


PN532 Code?

Hi,
Am wondering if and how this can be adapted for the PN532 module. I cannot seem to find code for this anywhere and I am not advanced enough at coding to write my own code for this from scratch.
Any help is appreciated.
Thank you,

Why should this library be adapted for the PN532?? There are a lot of libraries for the PN532.

There are libraries or code that I can't find anywhere for the PN532 😕 like the change UID or recover a fried card 😕
But thanks for the help
Sent from my iPhone

On 16 Nov 2016, at 6:53 PM, Rotzbua<EMAIL_ADDRESS>wrote:
Closed #260.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub, or mute the thread.

Then you have to open an issue on their libraries. It is more difficult to adopt this library than extend an existing library.


Hotfix: Rename 'showVideo' in defaultConfig.js, so it matches with bot.js

currently videos are not played by default

I will turn it arround, so the parameter matches the readme and reopen this PR...


Incorect resolution

After the last two updates, I have problems uploading data to garmin, because after weighing, the data appears very large and it is not possible to see the whole screen, nor is it possible to scroll the window up. The data upload button is thus only visible at the very bottom and is very difficult to press (see screenshot).
I have a Realme GT2 phone (RMX3311) loaded with android 13 and the latest version of MiScale Exporter.
Otherwise the app works great!

Hi @PiaSara
I remember about your issue. I have a newborn at home, which involves a lack of time in recent days. As soon as I find a free moment I will try to fix it.
Do you have any scaling enabled, other apps are also zoomed in?

Thank you for your concern. Don't worry, I can wait. Children come first ;)
As for the error, I don't have zoom or scaling enabled in any app. Even in Mi scale exporter the whole app works normally until I press the "Go to scan" button. When the result is displayed, the image is out of scale (enlarged) as shown in the screenshot. Other screens in app are OK.

@PiaSara I couldn't reproduce it in other method than setting big values in Display Size, but I fixed the scroll so now you should be able to scroll down to buttons. Update in Google Play store should be available soon.
https://github.com/lswiderski/mi-scale-exporter/releases/tag/v2.0.10

I installed latest update.  After measuring results are still displayed big, but now I can scroll down and update normaly.
Thanks for fiksing it!


require dependent options

When using authentication, -a is required when using -c, at least when using BASIC (untested with cookie). If -c is included, exit if -a is not provided.

This should be fixed in the 2.x release of this utility. If not please reopen the issue.


storage: meta cache always miss when meta file is too large

Problem

we find that the barrier latency of tpch q13 is too high (more than 20 seconds), and the throughput of object storage is very large.
Root Cause
We split meta cache to 32 shards. And the default cache size of meta is only 64MB. It means that every shard could only hold a 2MB cache pool. If some meta block is more than 2MB, it may be evict after another small block inserted into.
Additional context
It seems that the compactor produced a large  file in L6 (more than 400MB), so its meta file is also very large, which is more than 5MB

Why would some meta files be too large? I think we have an estimated block size and sst size upper limit

It seems another bug and I will investigate it later....
But meta-cache can not assume that the meta block must less than 1MB or smaller size.

@wenym1 It seems to be a mistake caused by metrics algorithm. I can not understand....

Why would some meta files be too large? I think we have an estimated block size and sst size upper limit

fixed in https://github.com/singularity-data/risingwave/pull/2722/commits/7f8692326bff27690e6459d4ccc7c127524acc54


Visual Grounding

Is this model useful for visual grounding purposes? if so how should I change it?

Hi @prashan
Since we do not have regional features, ViLT is not directly applicable for visual grounding tasks.
Though, you can opt to use a method like Grad-CAM to perform visual grounding.
For example, ALBEF did a weakly-supervised visual grounding on RefCOCO+ with Grad-CAM even though the model did not use regional features as ViLT did.


Question: How can I include SystemMessage with RetrievalQA

I'd like to incorporate this 'system_message' with each whenever I call 'qa.run(prompt)'.
How is this possible. Can someone help?
Here is the code I wrote to initialize the LLM and the RetrievalQA:
from langchain.chains.conversation.memory import ConversationBufferWindowMemory
from langchain.prompts import ChatPromptTemplate
from langchain.chains import RetrievalQA, LLMChain
from langchain.schema import (
    AIMessage,
    HumanMessage,
    SystemMessage
)

llm = ChatOpenAI(
    openai_api_key=OPENAI_API_KEY,
    model_name = 'gpt-3.5-turbo',
    temperature=0.0
)

system_message = [SystemMessage(
    content='You are a Virtual Vet. '
    'You should help clients with their concerns about their pets and provide helpful solutions.'
    'You can ask questions to help you understand and diagnose the problem.'
    'You should only talk within the context of problem.'
    'If you are unsure of how to help, you can suggest the client to go to the nearest clink of their place.'
    'You should talk on German, unless the client talks in English.')]

conversational_memory = ConversationBufferWindowMemory(
    memory_key='chat_history',
    k=2,
    return_messages=True
)

qa = RetrievalQA.from_chain_type(
    llm=llm,
    chain_type='stuff',
    retriever=vectorstore.as_retriever(),
)

@Khalidzo let me see how can I help you.

If you want to use system message in this case then you will have to use a agent to instruct the agent its basic purpose.  Also since you want to make your retrival chain use the pass history as well when constructing a question, you should use ConversationalRetrievalChain rather than simple RetrievalQA which you are using.
Something like following should work for your use-case:

from langchain.chains.conversation.memory import ConversationBufferWindowMemory
from langchain.chains import ConversationalRetrievalChain
from langchain.chat_models import ChatOpenAI
from langchain.schema import SystemMessage
from langchain.agents.types import AgentType
from langchain.agents import initialize_agent
from langchain.tools import Tool
from langchain.prompts import MessagesPlaceholder

llm = ChatOpenAI(
    openai_api_key=OPENAI_API_KEY,
    model_name = 'gpt-3.5-turbo',
    temperature=0.0
)

conversational_memory = ConversationBufferWindowMemory(
    memory_key="chat_history", return_messages=True, k=2
)

qa = ConversationalRetrievalChain.from_llm(
    llm=ChatOpenAI(),
    chain_type="stuff",
    memory=conversational_memory,
    retriever=docsearch.as_retriever(),
)

agent_kwargs = {
    "system_message": SystemMessage(
        content="You are a Virtual Vet. "
        "You should help clients with their concerns about their pets and provide helpful solutions."
        "You can ask questions to help you understand and diagnose the problem."
        "You should only talk within the context of problem."
        "If you are unsure of how to help, you can suggest the client to go to the nearest clink of their place."
        "You should talk on German, unless the client talks in English."
    ),
    "extra_prompt_messages": [MessagesPlaceholder(variable_name="chat_history")],
}

tools = [Tool(
    name="qa-vet",
    func=qa.run,
    description="Useful when you need to answer vet questions",
)]
executor = initialize_agent(
    llm=llm,
    tools=tools,
    agent=AgentType.OPENAI_FUNCTIONS,
    agent_kwargs=agent_kwargs,
    memory=conversational_memory,
)
executor.run(input())

@keenborder786 Thanks a lot for the help it actually worked, but only for the first prompt.
So I'm facing another issue whenever I execute executor.run(prompt) which is "OutputParserException: Could not parse LLM output: {LLM reply gets printed here}".
Do you know how can I solve this issue?

@Khalidzo this will solve your issue: https://github.com/langchain-ai/langchain/issues/3750. Just catch this exception using try and except block. If you are happy then please do close the issue.

@keenborder786 thank you so much, the issue is solved.


Add telemetry for binary downloads

Which area/kind this issue is related to?

/area cli
/area releng
Issue Description

Once we have binary downloads available, metrics should be added to track the downloads.

closing in favor of https://github.com/devfile/api/issues/1168


Fixed regression: CSS entries were not picked up for storybook pages (e.g. when using exract-text-webpack-plugin)

Issue: CSS not displaying when using the exract-text-webpack-plugin, regression introduced in 38b9dfabfb1b8691c1f7b378f9dfff05b99603f5
What I did
Upgraded from<EMAIL_ADDRESS>and had the extract-text-webpack-plugin enabled.
Unfortunately my CSS didn't load, encountering the same issue as described in #1104 and most likely #388 and #708.
Using the extract-text-webpack-plugin creates a new entry point however, making the asset list look something like this:
{ manager: 'static/manager.02f732c9002a59214667.bundle.js',
  preview:
   [ 'static/preview.352040d027a7c22331ae.bundle.js',
     'static/preview.1f62768c19a65e75e4259a4c418d292d.css',
     'static/preview.1f62768c19a65e75e4259a4c418d292d.css.map' ] }

and due to https://github.com/storybooks/storybook/blob/34b96aae764a386c35d4db2a057e85236bd8ddfe/app/react/src/server/iframe.html.js#L33 only ever taking the very first asset, the CSS never makes it into iframe.html.
How to test
I added new tests :)
fixes #388
fixes #708
fixes #1104

@shilman I assigned you, as you seem to be quite active these days :-) Let me know if anything is unclear! Hoping to get the fix for this regression in asap to de-confuse our extract-text-webpack-plugin-users :)

@UsulPro I saw you were last active, would you mind having a look? I am blocked by this, but need a second pair of eyes on it :)

Tested in 3.1.7, works as expected:
➜  web git:(joscha/unfork-storybook) yarn build-storybook
yarn build-storybook v0.24.6
@storybook/react v3.1.7

=> Loading custom addons config.
=> Loading custom webpack config (extending mode).
Building storybook ...
ts-loader: Using<EMAIL_ADDRESS>and /Users/joscha/Development/canva/web/tsconfig.ts-loader.json
✨  Done in 382.09s.
➜  web git:(joscha/unfork-storybook) ✗ cat target/storybook/iframe.html | grep link
        <link rel='stylesheet' type='text/css' href='preview.89d82dfdc51e6aeaba00b6d8a4785cf3.css'>

@joscha do you happen to have a sample project you could point to? I'm on 3.1.7 and can't for the life of me get webpack to actually generate the CSS file. We haven't hit any issues with extract-text-plugin in other projects so I'm wondering if there's a storybook-specific step I'm missing here.

@danielmcgrath we use extension mode (e.g. we have an additional webpack.config.js in the conf/ folder and then we do:
  const extractCSS = new ExtractTextPlugin({
    // The filename does not contain a hash in dev and local such that conf/head.html used by
    // Storybook can refer directly to the static filename in Storybook.
    filename: options.hashOutputFileNames ? '[name].[contenthash].css' : '[name].css',
    allChunks: true,
    ignoreOrder: true,
  });

// ...
plugins: [
  extractCSS
]

that's all that is needed for a preview.c0ffee.css to be generated and picked up in the HTML.

Hi, @joscha , We very love storybook. But we got the error:
ERROR in ./src/core/view/style.sass
Module build failed: Error: "extract-text-webpack-plugin" loader is used without the corresponding plugin, refer to https://github.com/webpack/extract-text-webpack-plugin for the usage example
    at Object.module.exports.pitch (/Users/qiuwei/Workspace/rongcaptial-ui/node_modules/extract-text-webpack-plugin/loader.js:25:9)
 @ ./src/core/view/index.js 33:13-36
 @ ./src/core/index.js
 @ ./stories/view.story.js
 @ ./build/config.js
 @ multi<EMAIL_ADDRESS><EMAIL_ADDRESS>./~/webpack-hot-middleware/client.js?reload=true ./build/config.js

My custorm webconfig is:
rules: [
            {
                // use sass-loader for *.sass files
                test: /\.sass/i,
                use: ExtractTextPlugin.extract({
                    fallback: 'style-loader',
                    use: [
                        {
                            loader: `css-loader?modules&localIdentName=${ __DEV__ ? '[path][name]__[local]--[hash:base64:5]' : '[hash:base64]' }`,
                        },
                        {
                            loader: 'postcss-loader',
                            options: {
                                plugins: [
                                    precss,
                                    autoprefixer
                                ]
                            }
                        },
                        {
                            loader: "sass-loader",
                        },
                    ],
                }),
                exclude: /node_modules/
            },
]

"@storybook/react": "^3.1.7", from [here](https://storybook.js.org/basics/slow-start-guide/)
"webpack": "2.2.0",
"webpack-merge": "^4.1.0",

Any ideas, please

You need to add it to the plugins array as well.
On 30 Jun. 2017 13:26, "Nixon"<EMAIL_ADDRESS>wrote:

Hi, @joscha https://github.com/joscha , We very love storybook. But we
got the error:
ERROR in ./src/core/view/style.sass
Module build failed: Error: "extract-text-webpack-plugin" loader is used without the corresponding plugin, refer to https://github.com/webpack/extract-text-webpack-plugin for the usage example
at Object.module.exports.pitch (/Users/qiuwei/Workspace/rongcaptial-ui/node_modules/extract-text-webpack-plugin/loader.js:25:9)
@ ./src/core/view/index.js 33:13-36
@ ./src/core/index.js
@ ./stories/view.story.js
@ ./build/config.js
@ multi<EMAIL_ADDRESS><EMAIL_ADDRESS>./~/webpack-hot-middleware/client.js?reload=true ./build/config.js
My custorm webconfig is:
rules: [
{
// use sass-loader for *.sass files
test: /.sass/i,
use: ExtractTextPlugin.extract({
fallback: 'style-loader',
use: [
{
loader: css-loader?modules&localIdentName=${ __DEV__ ? '[path][name]__[local]--[hash:base64:5]' : '[hash:base64]' },
},
{
loader: 'postcss-loader',
options: {
plugins: [
precss,
autoprefixer
]
}
},
{
loader: "sass-loader",
},
],
}),
exclude: /node_modules/
},
]
"@storybook/react": "^3.1.7", from here
"webpack": "2.2.0",
"webpack-merge": "^4.1.0",
Any ideas, please
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/storybooks/storybook/pull/1363#issuecomment-312243581,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AALehr8UKS_TD8U5gIak-roW0lkufxcNks5sJNuAgaJpZM4OGBWL
.

@joscha Yes, you are right. I forgot it. It works now. Thanks.

@joscha I somehow cannot get extract styles to work with extending the config based on your example above. Could you expand on your example, or show a whole webpack config.? How do you get the env check into the webpack config when in "extending mode"?
when i run build-storybook there are no stylesheets in the output dir, nor is it added to index.html or iframe.html.
Can you see any oddities or tell me what I am missing?
const path = require('path');
const ExtractTextPlugin = require('extract-text-webpack-plugin');

const extractCSS = new ExtractTextPlugin({
  filename: '../build/static/[name].css',
  allChunks: true,
  ignoreOrder: true,
});

module.exports = {
  module: {
    rules: [
      {
        test: /\.md$/,
        use: 'raw-loader',
      },
      {
        test: /\.(jpg|png)$/,
        use: "file-loader"
      },
      {
        test: /\.css$/,
        include: path.resolve(__dirname, '../src/'),
        exclude: path.resolve(__dirname, '../node_modules/'),
        use: extractCSS.extract({
          fallback: 'style-loader',
          use: [
            {
              loader: 'css-loader',
              options: {
                importLoaders: 1,
                modules: true
              },
            },
            {
              loader: 'postcss-loader',
              options: {
                plugins: function(loader) {
                  return [require('autoprefixer')];
                },
              },
            },
          ],
        }),
      },
    ],
  },
  plugins: [
    extractCSS
  ],
};

@janusch Would you be able to try the 3.3 alpha release?
We have changed the way entry points are added there, and the issue you're having should be resolved. could you check it out?

@ndelangen Hey, thank you for getting back to me that quickly!
I have just run build-storybook with extract-text-webpack-plugin and it does now successfully create, copy and include the preview.css file.
However, there is another error related to webpack now. Maybe that is due to some other breaking change? It was the first issue in storybook that refers to the same error: https://github.com/storybook-eol/storybook-addons/issues/1 TypeError: Cannot read property 'emit' of null     at emitAddReadme
I am using the storybook-readme addon.
One more little thing is that as soon as I am wrapping the webpack config object in a function returning the object, to get the env var, storybook is changing from extended mode to full-control mode. Is there another way to work with an extended config and still make use of env for production development, etc. differentiation?
Thank you for working so hard on storybook, it is really becoming a complex product, with a lot of great features!

One more little thing is that as soon as I am wrapping the webpack config object in a function returning the object, to get the env var, storybook is changing from extended mode to full-control mode. Is there another way to work with an extended config and still make use of env for production development, etc. differentiation?

this one I got resolved!
I am still having the 'emit' error described above. I am running the latest version of the package<EMAIL_ADDRESS>Please let me know, if I should test something else, looking forward to get the latest alpha into a stable build asap.

I got the remaining issues fixed. Just had to upgrade everything else to 3.3.0-alpha.0 as well.
Thank you for the help, storybook rocks!

sorry I am bit lost as first time using storybook. Do I need a custom webpack conf to load css. I have an app based on CRA, and in stories/index.js, I am importing the main css file as import '../index.css';. I don't see any style applied.
Uses "@storybook/react": "^3.2.12".
Do I need to use 3.3.0-alpha.0? I could not see any html file where I can load css. I saw in some older code there was a header html file for customization, but didn't create any with my CRA based app.
thanks for any help.

@shilman  Same issue as @bsr203. I'm using full control mode and I could not find any plugin in default config passed so I added new config using config.plugins.push(new ExtractTextPlugin('component-styles.[contenthash].css')); and also update /\.css$/ to ExtractTextPlugin.extract.


Moved over some of Nick's design updates from Storybook

Summary | Résumé

Moved over some of Nick's design updates from Storybook
Lots more work remains :-)

Going to approve because there's a lot of awesome work there. The only comment I have is that the secondary button text is hardly visible anymore. Need to look at in the near future.

I can take a look into that for sure, noticed that when reviewing

Going to approve because there's a lot of awesome work there. The only comment I have is that the secondary button text is hardly visible anymore. Need to look at in the near future.

I can take a look into that for sure, noticed that when reviewing

Thanks a lot @bryan-robitaille and @nmakuch - I made some fixes for the secondary button and added the "Heading" component (updated the JSON viewer docs). Let's hope this is good for the demo :-)

Thanks a lot @bryan-robitaille and @nmakuch - I made some fixes for the secondary button and added the "Heading" component (updated the JSON viewer docs). Let's hope this is good for the demo :-)


Upgrade tracing dependencies

Do you want to request a feature or report a bug?
Feature
What did you expect to see?
We have a temporary fix in this PR #3878 and to be able to fix correctly we have to upgrade opentracing dependency and maybe jaeger and zipkin too.

These dependencies have been updated.
For this reason, I will be closing this issue.


Create variable code action not suggested for the base16 and base64 literals

Description:
Create variable code action not suggested for the base16 and base64 literals.
Steps to reproduce:
public function main2() {
    base16 `aeeecdefabcd12345567888822`;
    base64 `aGVsbG8gYmFsbGVyaW5hICEhIQ==`;
}

Affected Versions:
1.2.0

Fixed in the latest


[Feature] Please update gpt models

Is your feature request related to a problem? Please describe.
Maybe...

On June 27th, 2023, gpt-3.5-turbo will be updated to point from gpt-3.5-turbo-0301 to gpt-3.5-turbo-0613.

Describe the solution you'd like
Can you update gpt model to latest? The lastest models have more context and function! You can find more infomation in this website: Models

Describe alternatives you've considered
N/A
Additional context
N/A

We could opt to wait for a period of 12 days, which would allow for the automatic upgrade of the current Turbo model to 16k. Anyway it will be replaced completely in Sep.

Upgrade your code to latest version.


bug: Not updating cursor position while running keymap

Did you check docs and existing issues?

[X] I have read all the vscode-neovim docs
[X] I have searched the existing issues of vscode-neovim
[X] I can reproduce the issue with an empty init.vim/init.lua and no other vscode extensions (when applicable)

Neovim version (nvim -v)
0.9.1
Operating system/version
Ubuntu 20.04.6 LTS (through WSL 2 on Windows 10)
Describe the bug
This was supposed to be fixed by the 1358 pull request, but it didn't resolve the issue for me.
The following mapping is running the 'editor.action.reindentselectedlines' command on the line the cursor started on instead of the line it is on at the time the command is run. I am basing this conclusion on the fact that the cursor is left at the very start of the new line. Also, if I intentionally mess up the indention of the line the cursor is on before pressing o, the indentation of that line does get fixed. Here is the mapping I am using from my init.lua:
vim.keymap.set('n', 'o', "ocall VSCodeNotify('editor.action.reindentselectedlines')")
Steps To Reproduce

Add vim.keymap.set('n', 'o', "o<Cmd>call VSCodeNotify('editor.action.reindentselectedlines')<CR>") to init.lua
Place cursor on a line that is not indented properly (not really necessary, but helps illustrate problem better)
Press o while in normal mode

Expected Behavior
The wrongly indented line the cursor started on should not get changed, but it does because the cursor position is not being updated (educated guess). The cursor should be left properly indented on the next line, instead it is at the very beginning of the line because VSCodeNotify() is called against the old cursor position (educated guess).

I really need some way to get o working better for indenting the cursor at the new line. It had it working better when I was able to call VSCodeNotifyRange() and pass in specific line number.

Currently the easist way is add delay to execute command in the mapping. Of course, this is not the perfect solution, but the delay can indeed solve many problems.
vim.keymap.set('n', 'o', function ()
  vim.api.nvim_feedkeys('o', 'n', false)
  vim.defer_fn(function ()
    vim.fn.VSCodeNotify('editor.action.reindentselectedlines')
  end, 20)
end)

@xiyaowong thanks, I will try it out. I'm going to close this issue as it is a duplicate of my other issue https://github.com/vscode-neovim/vscode-neovim/pull/1358 which recently got re-opened.

@xiyaowong Actually that worked! Interestingly enough, even if I change the delay from 20 to 1, it still resolves my issue.


Compose navigation interop with fragment

do you plan to make support for fragments, so that you can smoothly transfer the project to compose

Hi @MakarenkoVlad 👋
I'm not sure what exactly you mean, but there are already official ways to use Fragments with Compose inside and Compose with Fragments inside 🙂
Take a look here:
https://developer.android.com/jetpack/compose/interop/interop-apis

It's okay, it happens to me and in ukrainian)) I meant are you planning to add support for navigation with fragments to your library for smooth transition from navigation on fragments to navigation on your library


SSVM downloader now handles redirects properly.

Previously it was using the HttpClient to make an initial request to an ISO. This would follow redirects. Then it would make another request using built-in Java URL and InputStream, which doesn't follow redirects. This results in the ISO getting stuck at 0% forever and also causing DOS effects.

LGTM @ProjectMoon can you push -f, the Jenkins build failed

changes looks good. It would be great if a test case can be added.

Indeed, looke good to me, is there a simple way to test this?

Testing is a bit difficult without running a local web server (which I think is overkill for a unit test). Maybe a test at the integration level (Marvin) would work?
Also, closed and reopened the PR to get it to build/validate again.

Yes, I agree, hard to test this one with a Unit Test.
Code changes look good to me. LGTM

Looks like all checks have passed successfully now.

Rebased to the latest master.

@ProjectMoon can you close/open the PR to re-kick Travis

Packaging result: ✖centos6 ✖centos7 ✖debian repo: http://packages.shapeblue.com/cloudstack/pr/1607

Nevermind @blueorangutan the jenkins job died due to git/github related errors:
error: index-pack died of signal 15
fatal: index-pack failed
I'll kick it again

Packaging result: ✔centos6 ✔centos7 ✔debian repo: http://packages.shapeblue.com/cloudstack/pr/1607

LGTM.
@blueorangutan package

@rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.

Packaging result: ✔centos6 ✔centos7 ✔debian. JID-75

This one hasn't been rebased in quite a while, so the packages produced will be rather old. Going to rebase this against latest master.

@ProjectMoon this seems like a really good fix for LTS users as well.  Could you please rebase and change the base branch to 4.9?

Closed in favor of #1746.