[BEAM-10169] - ParDo functions with correct output N in their error messages.

Previously, when a mismatch of the dimensions emitted by the DoFn and the dimensions emitted by the ParDo was encountered, a less than helpful message of  expected 1 output. Found: [] was returned. This caused some confusion especially when paired with ParDo and ParDo0 which may be counterintuitive arrangement to most.
In this patch, we provide a more helpful error message which correctly reference the DoFn which has the misalignment and the ParDo which the misalignment of dimensions were captured by. It also recommends a ParDo function which may be used by the DoFn in question.
We introduce two new functions to the pardo package as well as a new function to the reflectx package to help us construct this error message.

Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

[x] Choose reviewer(s) and mention them in a comment (R: @username).
[x] Format the pull request title like [BEAM-XXX] Fixes bug in ApproximateQuantiles, where you replace BEAM-XXX with the appropriate JIRA issue, if applicable. This will automatically link the pull request to the issue.
[ ] Update CHANGES.md with noteworthy changes.
[ ] If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.

R: @damondouglas

Address current comments, waiting for feedback.

Awesome! Exciting. Thanks, i'll take on another ticket from the backlog. Cheers, Aaron


Spell RFC3339 correctly

Let's at least spell RFC3339 correctly even if we can't get it working for any timezone but UTC (https://github.com/projectatomic/osbs-client/pull/232).

Merged, thanks:)


Sequence viewer is not rendering with FASTA input only

The sequence view is failing in the development branch when rendering sequences from a FASTA file. This can be replicated with the demo file.
The following error is thrown:

Note that this issue does not persist when rendering a CSV where sequences are embedded in the file. This can be demonstrated by using the 'experimental' menu to spin up random sequences at file-load.

alignment viewer library is expecting "id" property in the seq object but the supplied object has "_id"
if(s.id.length > offset) offset = s.id.length;
causing "undefined" error

added "id" property to the nodes array when preparing the argument for the alignment viewer library


Validation is not working in the "Message All Volunteers" modal

When you try to create an invalid message, without a subject and message, "nothing happens":

no error message
the modal stays open
the "Send Message" gets disabled

The following JS error is displayed in the console:
VM209:1 Uncaught SyntaxError: Unexpected token B in JSON at position 0(…)
error @ taskDetails.js:40

Repro Steps.

Log into Org admin That has an Event created.
Add volunteers to event task.
Navigate to Task Details /admin/task/details.
Click Message All Button.
Leave all inputs empty
Click Send Message Button

Doing this!

adam3039. Are you still working on this?

@dcbrewster it's been long enough that I would consider this not work in progress by @adam3039 and feel free to start working on it.  Thanks.

@dcbrewster - Did you start working on this in the end?

Yes. It is done. Just need the other pull request (#1676) to be implemented before I commit these changes\
Dave
From: Steve Gordon<EMAIL_ADDRESS>Sent: Tuesday, January 03, 2017 1:56 PM
To: HTBox/allReady<EMAIL_ADDRESS>Cc: Dave Brewster<EMAIL_ADDRESS>Mention<EMAIL_ADDRESS>Subject: Re: [HTBox/allReady] Validation is not working in the "Message All Volunteers" modal (#1411)
@dcbrewster https://github.com/dcbrewster  - Did you start working on this in the end?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub https://github.com/HTBox/allReady/issues/1411#issuecomment-270192752 , or mute the thread https://github.com/notifications/unsubscribe-auth/AKBQ_r79luqIVPuR36VcGxJVyBWEnXJHks5rOpmjgaJpZM4Kjyex .  https://github.com/notifications/beacon/AKBQ_t_bbkK1xFoHfbYMO9FdEWdCUqj6ks5rOpmjgaJpZM4Kjyex.gif

@dcbrewster - Great! Thanks for the swift reply too.

I've just submitted PR #1723 which adds a required attribute to the input elements which should stop an empty form being posted.
Looking into providing feedback to the user about what's gone wrong.

Fixed in PR #1723


Project Submission: cats-actors

Project Name
cats-actors (https://github.com/suprnation/cats-actors/)
Project Short Description
Cats-Actors is a functional programming library that leverages Cats and Cats-Effect to provide a robust actor system. Combining the concurrency model of actors with functional programming principles, it enables high scalability and fault tolerance. Features include dynamic actor creation, context-based state management using become and unbecome, supervision strategies, and seamless integration with streaming libraries like fs2. This library is a comprehensive and efficient framework for building concurrent, distributed applications in a purely functional way, actively maintained and used in production by SuprNation.
Project Type
In accordance with the Typelevel Charter, I am proposing the project be a:

[] Organization Project
[x ] Affiliate Project

Project Management
All Typelevel projects follow the Typelevel Code of Conduct.
Organization projects do not need a CODE_OF_CONDUCT.md file, as the Typelevel GitHub Organization one will automatically apply.
Affiliate Project Instructions

Affiliate projects should copy the following template into a CODE_OF_CONDUCT.md file in their repo:
# Code of Conduct

Every member of our community has the right to have their identity respected. The Typelevel community is dedicated to providing a positive experience for everyone, regardless of age, gender identity and expression, sexual orientation, disability, neurodivergence, physical appearance, body size, ethnicity, nationality, race, or religion (or lack thereof), education, or socio-economic status.

Everyone is expected to follow the [Typelevel Code of Conduct] when discussing the project on the available communication channels.

## Moderation

If you have any questions, concerns, or moderation requests, please contact a member of the [Typelevel Code of Conduct Committee].

[Typelevel Code of Conduct]: https://typelevel.org/code-of-conduct
[Typelevel Code of Conduct Committee]: https://typelevel.org/code-of-conduct#contact

If you would like to be an additionally point of contact for Code of Conduct reports, you can include your contact information in the Moderation section like so:
## Moderation

If you have any questions, concerns, or moderation requests, please contact a member of the [Typelevel Code of Conduct Committee] or reach out to a project moderator:

- [Mark<EMAIL_ADDRESS>
In the event of a Code of Conduct report, affiliate projects should follow the instructions outlined in the Enforcement Procedures Affiliate project processes section.

[x] I acknowledge that this project must follow the Typelevel Code of Conduct
[x] As an affiliate project, the CODE_OF_CONDUCT.md file can be found at CODE_OF_CONDUCT

Similarly, Typelevel projects must have an appropriate license, as specified in the Typelevel Charter.
Please make sure that the project's license is on the approved list.

[x] This project's license can be found at LICENCE

Additional Notes
Since Akka transitioned to a Business Source License, we sought alternatives but found none that met our needs. This led to the creation of Cats-Actors, which we now share with the functional programming community as a thank you for the projects that have contributed to our success. Cats-Actors is a functional implementation of the actor model using Cats-Effect and fibers, aligning with the actor specification commonly associated with Akka. This project is actively maintained and used in production by SuprNation. While Apache Pekko is another alternative, it does not approach the actor problem from a purely functional perspective, and we believe Cats-Actors fills this niche.

@typelevel/steering: please vote with reaction on the issue. 👍 for yes, 👎 for no, 👀 to abstain.
Voting open is open for five business days (through Friday, June 14th) and until quorum (6) is reached.

Very, very neat -- as the owner of a fairly antique Akka-based application that I have ambitions of eventually evolving towards cats-effect, I've been looking for a library like this for many years personally.
Does it handle cluster sharding?  (If not, do you have ambitions to do so?)  That has no bearing on bringing the project into TL, but I'm personally curious.

I appreciate your interest! Currently, Cats-Actors does not handle clustering, but the framework is designed to be extendable, with all actions managed via system mailbox messages (Create, Failure, etc.). At SuprNation, we manage sharding through an external upstream service, so clustering hasn't been a priority for us. However, if there is community interest, we are open to dedicating time and effort to implementing clustering features.

Makes sense!  Personally, I tend to describe cluster sharding as the killer app of Akka -- the one thing that it unambiguously does better than any other alternative I've found.  (I've managed event sourcing in other ways like Kafka, but they've all come out clumsier IMO.)

Thanks folks, the vote is approved!
Migration issue is here: https://github.com/typelevel/governance/issues/146


Step 2 - Account screen loading improvement

We have to make the following changes: https://github.com/bithyve/internal-docs/issues/31#issuecomment-716364536 in addition to the changes made as a part of issue https://github.com/bithyve/hexa/issues/1944.
These changes depend on database refactoring which is going to happen as a part of account management.

@Parsh @antuz123 I'm thinking this should be resolved by the new account details screen that has been built out in #1663.

@CypherPoet - this is more about the Wrapper improvement to fetch details faster from the backend. Correct @Parsh?

This is completed


bug fix: hue in sc.pl.violin

closses #1174
hue key is now added to keys if hue is in kwds. before obs_tidy did not include this keyword, so this resulted in an ValueError
an alternative would be to add hue as a function parameter to sc.pl.violin

Thanks for the PR.
I think if this is added it should be added as a function parameter. It should also get some tests, I'm a bit concerned how just passing hue will work with the groupby and palette parameters.

would it then make generally sense to add an optional hue parameter in seaborn based plotting functions? was checking if hue is anywhere used but does not seem to be the case.
will check behaviour for this wrt groupby and palette.

would it then make generally sense to add an optional hue parameter in seaborn based plotting functions? was checking if hue is anywhere used but does not seem to be the case.

I'm not sure. I don't know off the top of my head how well we can make current functions work with hue, since seaborn uses it to group observations in many cases.


do not index proj:geometry and proj:centroid as geo fields

Related Issue(s):

#154

Description:
Do not index proj:geometry and proj:centroid as geo fields.
PR Checklist:

[x] Code is formatted and linted (run pre-commit run --all-files)
[x] Tests pass (run make test)
[x] Documentation has been updated to reflect changes, if applicable
[x] Changes are added to the changelog

Could you describe more why this is a problem? We're doing this same thing in stac-server (where this was copied from) and it's working fine.

It could be better if fewer fields were being indexed.

That might be the case, but for these, eventually implementing the Aggregation Extension will allow geoaggregations like geohex to be done over proj:centroid and bucket aggregation over grid;code.

It makes sense to keep the indexing if it will be used. How do you feel about the point that was made saying that only WGS-84 is supported by es?

ah, good point. proj:geometry should not be indexed like this for that reason -- I'll fix that in stac-server also. However, proj:centroid is supposed to be WGS84 lat/lon, though neither the Projection Extension nor the Elasticsearch geo_point documentation state that it must be WGS84 :(

I restored the mapping of the proj:centroid field to geo_point according to your feedback.


Panel goes to background after few hours

Describe the bug
Panel goes to background after few hours. The icon in notification area shows that it's running, it's just not a foreground app. On foreground is whatever was there before WallPanel, so usually launcher.
To Reproduce
Steps to reproduce the behavior:

Run WallPanel
Wait a few hours (leave overnight is the simplest approach)
Wake the screen (I use wake on motion using front camera)
See panel not visible

Expected behavior
Panel still as a foreground app.
Smartphone (please complete the following information):

Device: TB Touch Ignis 8
OS: Android 4.2.2
Browser: stock browser

Additional context
I've tested few different applications on the same device and WallPanel was the only one that goes to background. Others app were foreground until I manually switched them, so there is something strange with this particular app.
I've tested different pages (even google.com) to make sure it's not a particular page causing this strange behavior.
I've also tested WallPanel on my phone (Samsung S5 with Android 5.0) and it was fine (left as foreground overnight), so in my case it's only this app on one device which makes it harder to debug and fix.
I understand you are not supporting such old Android (per my last issue when you created legacy fork) but maybe you could help with this one more time? This issue is quite frustrating as I have to bring back WallPanel few times a day to see displayed data.

The same is happening on Amazon Fire 7.

@vitalykorolev Amazon devices have no screen saver ability such as standard Android Daydream, so you would have to run the application with the option to prevent the screen to sleep or use another application to act as a screensaver.   By default the application does not keep the screen awake because this would burn the screen, so it relies on the screen saver to be in shallow sleep, but without that ability, Amazon devices go into deep sleep and kill applications.

@Marooned-MB Are you running the legacy version of the application, because you are reporting the issue on the current version.

@thanksmister I think I misunderstood the original report. I don't use the screensaver and I just keep the screen on all the time. I think in my case the issue is related to SSL handling.

Have you updated recently?  I added some logic to handle SSL.  I’m going to add a screen saver at some point to the app for Amazon tablets.

Are you running the legacy version of the application, because you are reporting the issue on the current version.

I'm running regular version, just stopped updating at the last working version v0.8.4 build 1

I have no crashes reported for the latest version of the application.

It's not crashing. It just goes into background as if I hit the home button or switch to the last running app.

@Marooned-MB it still might be crashing, but since that version is so old, I can't tell if I fixed it or not since then.   There is no way to address this issue because you are not on a version that I can test to duplicate the issue.   Plus, if I did fix the issue, you would still have to update to get the fix.  I am not able to work on the legacy version or do bug fixes without a lot of effort.   So... not sure how I can help other than recommend you run the legacy version by side-loading it.

But as I understand, legacy version is exactly as this version v0.8.4 build 1? It's more or less a frozen tag, so they do not differ?
Am I able to install a particular toolchain to compile recent code every time you do some fixes and produce .apk that will run on my machine? So containing working Crosswalk? Thanks to that I won't bother you with support you can't provide plus I can tell if the recent code has this particular issue.

The difference is that I can test the legacy version, verify the issue on my older tablet and if its something simple, I may be able to address it.  I can't fix an older version of the v0.8.4 build 1 and update it, I have only the possibility of updating legacy version.    You can install Android Studio (new version) and install legacy version.  It will work as long as you do not update the target SDK version in the gradle file.    Crosswalk is another library entirely, its no longer being worked on.  The only thing that happened is newer versions of the Google SDK or toolchain no longer work with Crosswalk because its so outdated.

Ok, got it. So I'll install legacy in a minute and leave it overnight to check if the issue exists. If so, I'll open the issue on legacy repo. Thanks for clarifications and your great work!
I'll also go with the Android studio as a side approach.

After almost 24h I can confirm that legacy version (v0.8.4 build 7) does not have this issue so it was either fixed between build 1 and 7 or different toolchain help solving this problem. Either way, I'm closing this issue.

I too have this or a similar issue. On my device (Lenovo 7 inch tablet with Android 5.0.1) it seems the WallPanel just will not stay active for more than a day or so, when I wake my device up the first thing I see is WallPanel settings page, so the app has somehow reverted back to the settings page and then the screen goes to sleep after a while.
I have looked at all settings I can find in the device, screensaver, sleep modes etc, and I have everything disabled as far as I can see.
WallPanel is set to always keep the screen active.

In case this helps someone else, the problem I described above seems to be solved by turning off automatic updates in google play (fingers crossed, but for now the app has been working for longer than ever before). Seems that every time that update process is run on the device wallpanel will for some reason go to the background or something similar.

Sadly my Amazon tablet doesn't have the Google Play store, but I'll try disabling updates for the Amazon Store (if possible) and report back if anything changes.

I seem to be having this issue on v0.8.5-beta.6 with a Kindle Fire 7 (7th generation, 2017) on Fire OS <IP_ADDRESS>.

Same here. I switched over to Fully Kiosk and its pretty decent. But I really like the mjpeg camera streaming of wall panel so I thought I would give it another go. I just installed the legacy version and have the browser selection set to automatic. Figured I'd give that a go, if it doesn't work then I'll try the crosswalk selection.

After testing for several weeks I have concluded that the camera on the Amazon Fire devices is the cause of the application going into the background.
This means that their is a limitation when using the application on those devices when using motion, face, QR or MJPEG streaming for long periods of time.
There is no fix or work around. FireOS is a custom build of Android and the tablets and I believe there is something that closes applications that use large resources at certain times.  This issue is already closed because it can not be addressed.

Yeah I figured it was the camera that was causing my issues.
Just out of curiosity, and I understand if it’s a no, but is there a way to implement using the camera to get around the fireos limitations?
I believe Fully Kiosk uses a snapshot method.
End state for me would be a method that would allow linking with something like motioneye.

On Mar 9, 2019, at 6:25 AM, Michael Ritchie<EMAIL_ADDRESS>wrote:
After testing for several weeks I have concluded that the camera on the Amazon Fire devices is the cause of the application going into the background.
This means that their is a limitation when using the application on those devices when using motion, face, QR or MJPEG streaming for long periods of time.
There is no fix or work around. FireOS is a custom build of Android and the tablets and I believe there is something that closes applications that use large resources at certain times. This issue is already closed because it can not be addressed.
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub, or mute the thread.

That makes sense @thanksmister, thanks for at least confirming the cause :+1:

Yeah, there is a possibility to use only a snapshot feature, but that takes some time to implement.  You are welcome to add a feature request.


Proposal: Add brew cask install/remove to travis script

What do you think about including a brew cask install/remove step after the audit/style check ci/travis/script.sh#L19 in travis?
(I don't see any security reasons, it is in a VM after all and creating other 'malicious' PRs wouldn't be that hard).
I think this could detect issues with wrong artifacts (example updates packages has now an additional subfolder).
After the install, travis could then also test the removal.
This wouldn't catch all possible issues, but maybe won't hurt either. If using sudo is a problem it could be limited to those artifacts which do not require sudo.

Closing in favor of #17424 (already has a discussion)


Node startup error

2020-06-09 23:58:57 UTC [Info] Coda daemon is now doing ledger catchup
2020-06-09 23:59:20 UTC [Info] Running async shutdown handler: "Close transition frontier, if exists"
(monitor.ml.Error
 (Sys_error
  "/home/user
/.coda-config/coda_crash_report_2020-06-09_23-58-57.894476/coda_status.json: No such file or directory")
 ("Raised by primitive operation at file \"stdlib.ml\", line 316, characters 29-55"
  "Called from file \"stdlib.ml\" (inlined), line 321, characters 2-74"
  "Called from file \"write.ml\", line 470, characters 11-24"
  "Called from file \"src/app/cli/src/init/coda_run.ml\", line 265, characters 2-40"
  "Called from file \"src/deferred1.ml\", line 17, characters 40-45"
  "Called from file \"src/job_queue.ml\" (inlined), line 131, characters 2-5"
  "Called from file \"src/job_queue.ml\", line 171, characters 6-47"))

coda_crash_report_2020-06-09_23-53-05.871026.tar.gz

{"timestamp":"2020-06-09 23:24:56.297259Z","level":"Fatal","source":{"module":"Init__Coda_run","location":"File \"src/app/cli/src/init/coda_run.ml\", line 621, characters 56-63"},"message":"Unhandled top-level exception: $exn\nGenerating crash report","metadata":{"exn":"(monitor.ml.Error\n  \"Assert_failure src/lib/block_producer/block_producer.ml:598:16\"\n  (\"Raised at file \\\"src/lib/block_producer/block_producer.ml\\\", line 598, characters 16-234\"\n    \"Called from file \\\"src/result.ml\\\", line 151, characters 9-15\"\n    \"Caught by monitor coda\"))","host":"<IP_ADDRESS>","peer_id":"12D3KooWDbzbkXpYizZQmn1YBDbdQBhfdyCABzE2fJ74t27Xvvjj","pid":27491,"port":8302}}

This is a dupe of #5079 . Thanks for reporting!


: todo list using context api

add items:

search :

incase of invalid search:

Drift video not added
<> these brackets was for the syntax not needed to add in the commit
The commit message must be in past


Using Pipeline

Trying to execute a basic pipeline using redis-py-cluster sample code.
from rediscluster import StrictRedisCluster as s
r = s(startup_nodes=[{"host": "<IP_ADDRESS>", "port": "7002"}])
r.connection_pool.nodes.slots[14226] = {'host': '<IP_ADDRESS>', 'server_type': 'master', 'port': 7001, 'name': '<IP_ADDRESS>:7001'}
p = r.pipeline()
p.command_stack = []
p.command_stack.append((["SET", "ert", "tre"], {}))
p.command_stack.append((["SET", "wer", "rew"], {}))
p.execute()

Getting the following error.
 File "<stdin>", line 1, in <module>
  File "/Library/Python/2.7/site-packages/rediscluster/pipeline.py", line 100, in execute
    return self.send_cluster_commands(stack, raise_on_error)
  File "/Library/Python/2.7/site-packages/rediscluster/utils.py", line 93, in inner
    return func(*args, **kwargs)
  File "/Library/Python/2.7/site-packages/rediscluster/pipeline.py", line 153, in send_cluster_commands
    attempt = sorted(stack, key=lambda x: x.position)
  File "/Library/Python/2.7/site-packages/rediscluster/pipeline.py", line 153, in <lambda>
    attempt = sorted(stack, key=lambda x: x.position)
AttributeError: 'tuple' object has no attribute 'position'

Please let me know if im missing anything.

@naveenpajjuri You are using pipelines completly wrong. You are not supposed to append commands to the command_stack manually. A pipeline object is almost the same object as the regular client and it has all the commands (set/get/mset...).
The correct way you should be using your pipeline is the following
from rediscluster import StrictRedisCluster as rc

r = rc(startup_nodes=[{"host": "<IP_ADDRESS>", "port": "7002"}])
p = r.pipeline()
p.set("ert", "tre")
p.set("wer", "rew")
p.execute()


Fix dispatch signature on SF > 4.3

This should resolve https://github.com/lexik/LexikJWTAuthenticationBundle/pull/669 as well.

@chalasr is it possible to release a fix for this?

Apologies for the delay @Webonaute.
We have an unrelated failure on the travis build which I'm looking into. Once I'm done, I will merge this one and release it right away.
Thank you for the patch.

Thank you @Webonaute.


⚠ AGEG website (prod) has degraded performance

In dc40032, AGEG website (prod) (https://www.ageg.ca/) experienced degraded performance:

HTTP code: 200
Response time: 5774 ms

Resolved: AGEG website (prod) performance has improved in 6a11529.


Add Denmark flag (css)

Create Denmark flag only with html/css

If it's not done, I can make it :-)


Push BBC iPlayer to stable repo

Requirements:

[x] WebKitGTK 2.16.0 - we have 2.16.1 in stable
[ ] GStreamer 1.12 - we have 1.12 in devel
[ ] MSE enabled - we have MSE enabled in devel
[x] No gstreamer errors

Building gstreamer 1.12

There are GStreamer errors in master flatpaks. Need to be investigated further.

It's necessary to set GST_PLUGIN_SYSTEM_PATH=/app/lib/gstreamer-1.0.

The stable runtime (not ye uploaded) now contains GStreamer 1.12 and MSE enabled.

Hello @a-m-s. BBC iPlayer is now in the stable repo branch ;-)


ResolveComposesPlugin allows to handle FROM-scratch image

CLOUDBLD-127

Signed-off-by: Chenxiong Qi<EMAIL_ADDRESS>Maintainers will complete the following section

[ ] Commit messages are descriptive enough
[ ] Code coverage from testing does not decrease and new code is covered
[ ] JSON/YAML configuration changes are updated in the relevant schema
[ ] Changes to metadata also update the documentation for the metadata
[ ] Pull request has a link to an osbs-docs PR for user documentation updates
[ ] New feature can be disabled from a configuration file

/packit copr-build

@athos-ribeiro
The comment inside InsideBuilder.__init__ mentions that if Dockerfile needs to be generated from container.yml, a plugin will create the dockerfile and set base image that sets workflow.builder.base_from_scratch. Which plugin does this job? Is this plugin optional to run for some cases before resolve_composes plugin?

@athos-ribeiro
The comment inside InsideBuilder.__init__ mentions that if Dockerfile needs to be generated from container.yml, a plugin will create the dockerfile and set base image that sets workflow.builder.base_from_scratch. Which plugin does this job? Is this plugin optional to run for some cases before resolve_composes plugin?

Currently, this is the case for Flatpak builds. There is a pre_create_flatpak_dokerfile plugin that does this. It rund before the resolve_composes plugin in the orchestrator build.

@athos-ribeiro PR is updated and using workflow.builder.base_from_scratch now. PTAL.

LGTM!
The tests are checking for calls to log.debug, but there are other calls to debug in those methods. Could we improve those tests to either check for the logged strings or to check that the plugin will skip in the desired cases?

@athos-ribeiro
Thanks for your review. I updated this PR by checking the logged strings.
BTW, I also moved the check of workflow.builder.base_from_scratch to the front of the check of self.plugin_result. This is not for making the tests pass. My understand is if an image is based on scratch, the code should be actually unnecessary to consider the result from previous plugin, the koji_parent, because the BASE_IMAGE_KOJI_BUILD is the only thing adjust_for_inherit and adjust_signing_intent_from_parent care about.

/packit copr-build

Waiving osbs-docs PR and feature toggling through configuration requirements. This is a fix for a bug in the OSBS build workflow.

@rcerven Thanks for your good points. All your comments are addressed. PTAL.

/packit copr-build

/packit copr-build

/packit copr-build

Release note: resolve_composes plugin will correctly handle FROM-scratch images


AuthInfo:Authentication information is updated with the cluster update

Signed-off-by: littlegreyzhang<EMAIL_ADDRESS>Commit Message: AuthInfo:Authentication information is updated with the cluster update
Additional Description:
This changes the authentication information code to update AuthInfo with the cluster update .
Fixes #15510
Risk Level: Low
Testing: New and existing tests
Docs Changes: N/A
Release Notes: N/A
Platform Specific Features: N/A

@mattklein123 @jmarantz
Please review this PR . Thank you !

@envoy-bot ok

@HenryYYang @msukalski would you be able to take a first pass?


Ability to request only advanced recommendations

Currently the recommendation report provides any basic recommendations for the dbt models. Advanced dbt developers might want more specific/advanced recommendations only.
Implement the ability for users to specify a flag to request only advanced recommendations. Design the prompt(s) as necessary to only receive advanced recommendations. This may require defining what classifies as advanced recommendations and include that in the prompt design

Completed in https://github.com/armalite/dbt-ai/pull/8


SNYK: github.com/docker/distribution Denial of Service (DoS) #2

Summary of issue

Severity: medium
Affected versions of this package are vulnerable to Denial of Service (DoS) due to improper validation of the value passed to the n parameter in the /v2/_catalog endpoint. Exploiting this vulnerability is possible by sending a crafted malicious request to the /v2/_catalog API endpoint, which results in an allocation of a massive string array and excessive use of memory.

Link to detailed description

Fixed in https://github.com/equinor/terraform-azurerm-service-bus/pull/26


Temporarily disable API 28 and 30

All tests are always failed on API 28
Job for API 30 is always cancelled.
I'm going to switch off these two jobs for investigation

This should be resolved in scope of issues #78 and #79

This should be resolved in scope of issues #78 and #79

I put back API 28 since after removing API 26 starts to fail in the same way. It looks like xamarin android issue, will leave it for further investigation our of scope of current PR

I put back API 28 since after removing API 26 starts to fail in the same way. It looks like xamarin android issue, will leave it for further investigation our of scope of current PR


Add printing support for Dim3s.

Also - at the moment I'm trying to exactly match the upstream Numba behaviour in the main branch and keep new development in the develop branch. Can you change the target of the PR on Github? I don't know if Github lets you do this, but if not, I'll manually apply this to develop once it's fixed up.

It turns out I was able to change this myself - please disregard the above.

/ok to test

I just merged develop so that CI can run on this PR.


How could I construct a neck structure similar to unet by the output of some feature extraction layer (conv2D)

How could I construct a neck structure similar to unet by the output of some feature extraction layer (conv2D)
my code :from efficientnet_pytorch import EfficientNet
model = EfficientNet.from_name('efficientnet-b0')
list(model.children())[2]
I found that all the extracts had been integrated under a large framework. How to extract them and put them into structures such as UNET and FPN

Check out https://github.com/zhoudaxia233/EfficientUnet-PyTorch, which is built on this repo

thank you ,i will try and learn it ,i have saw that ,it will helpful ,


Convert codebase to asynchronous code

The way that the async functions are currently implemented has a couple of issues.

Having both the synchronous and asyncronous versions of the same functions adds complexity to the codebase and makes flow.js more difficult to maintain and test.

For the cutting edge projects, that want to use async functions without a care about older browsers, and which don't transpile their own code, the transpiling of flow.js adds quite a lot of unnecessary weight.

For the projects that would like to implement the async functions and transpile the final code themselves, the way that the async-ness is detected with fn.constructor.name === "AsyncFunction", will not work (as mentioned already in #319) due to the way the async code usually ends up being transformed into regenerator functions.

In both of these imaginary projects, the alternative versions (synchronous in the first example, and async in the second) of the same functions are unnecessary to have.
What I would like to have is just the async set of functions (async addFile(s), async generateUniqueIdentifier, async initFileFn and async readFileFn without extra prefixes in their names), and async hooks and events. Async hooks would always be called with await, async events would not.
The most obvious breaking change for upgrading users is that addFile(s) would no longer return the added file or the list of files, but a Promise object containing them instead. For the higher level assignBrowse/assignDrop function users, the amount of changes needed to upgrade might actually be zero, since none of the hooked functions need await – now they just can have them.
I'm thinking that a third prepackaged version of flow.js would need to be distributed:

An unminified dev build with native async/await
A minified version of that
A Babel transpiled and minified version

Still missing from this PR is the unifying of readFileFn and asyncReadFileFn – the latter would need to be renamed into the former.
Also I'd like to get some feedback on the two lines of code marked with // TODO in Flow.js regarding the changed filtering behavior of addFiles between v2 and v3. Is this what the console warning in Eventizer.js was added for? Perhaps the old behavior can still be saved with a cleaner solution?

I know there's a lot to go through here – sorry to drop such a massive PR on you @drzraf and @AidasK 😅
In case this isn't the direction either of you want to go with, I'm happy to submit individual pull requests on the more minor changes that have nothing to do with async/await.

Welcome @ilessiivi to this project. I am totally on board with everything you have mentioned and this is the direction I would like to see this project going. You have deleted many lines and that’s awesome. Sync functions are a thing of the past and we should get rid of them.
I have reviewed your changes and it looks great, though @drzraf is more familiar with async changes, so let’s wait for his review too.

1. About backward (in)compatibility
I agree with your points 1 and 3.
About point 2, I doubt an hypothetical project which does not transpile its own code is significant. It's provided a second argument to drop backward compatibility. (If you assume bleeding-edge projects do transpile, they could import an hypothetical AsyncFlow class as well (and tree-shaking would remove all dependency upon older Flow.js code) that would allow keeping synchronous codebase as well.
Even though I went on great efforts to maintain compatibility, I add to break event names. So v2 users can't actually use v3.
But quoting https://github.com/flowjs/flow.js/issues/319#issuecomment-758639954
An async-only codebase force users handling regular files (the majority) to use a Promise-based approach with no gain:

Without an await / then they would have a surprising behavior
It force all hooks to be async (even if it was only needed for initFileFn)
It forces them to reorganize their code
It would sound tricky to use the library
async approach is mostly useful for streams (whether network or local) which don't represent the majority of cases

I'd agree with the voice of the majority (and understand all the possible evolution brought by such a cleanup), but I want to be sure these compatibility aspects are well understood/taken into account before synchronous behavior be totally dropped.
An alternative could have been to inherit / subclass Flow class, or similar code inheritance / mixins constructs to would more clearly separate both flavors. Don't you think there could be room for such a solution?
About the PR itself
It's a lot of nice individual commits, but bundled as a pretty big PR. Since it's already an deep functional change, it's best to not include anything not strictly related.
Do you mind creating the distinct PR for these individuals changes:

One about codestyle and gitignore (ff049101 148a524c 333896c c07a686 ff4d14b8 f2370bd43)
One about 6db3c90b2 (I'm pretty sure I had a good reason for introducing this clause but I can't remember)
One about existing bugs / small improvements (16cd4e35, f5679386)
About 64ab7fe5 could you just do the minimum possible change (The previous code-style about if () { return; } instead of if-else is generally considered superior by avoid overly nested code-paths + always calling emitCatchAll may not be adequate, in particular). At least I think it deserves its own PR (with or without above 16cd4e3)
One about 20bbf4c which could come last (after this one is merged)
About 35f02616 , I understand the simplification it brings in that context (dropping synchronous functions, but it's annoyingly add to the functional part diff)

Once merged, you could rebase on top of latest v3 branch (include #350) and squash 9d94015d, 682090 and 7906f7c with 6820906d.
The resulting list of commits (and overall diff) would be way more easier to review and test (from 20 down to 6 or 7 commits)

In my opinion code base has to be as simple as possible so that it would be easier to develop it and to ensure that it’s bug free. So dropping sync approach would make it much more simpler and understandable for us and for future users. We don’t have much development power anyway, so reducing our code base might be beneficial for us. Also, I think it’s fine to use await/wait/then in all the cases where this approach might be needed. Upgrade might be hard, but for new users it’s no brainer. It’s easier to force it async than to redo-it to async later. So providing both approaches also might be frustrating for our users as they would have read the docs about both of them.
Flow.js v2 is stable enough and handles all required features and there is no need to upgrade it to v3 if it works. So I don’t think we should think much about backward compatibility. From my experience legacy code only holds community back, so we should not fear upgrading this.
@drzraf I know you have spent a lot of time maintaining backward compatibility, so I am leaving this decision for you as you know better if it hard or easy to maintain it. Also, great review!

Thank you @drzraf, this is all very valuable feedback. Thanks @AidasK too for going through it!

About point 2, I doubt an hypothetical project which /does not transpile its own code/ is significant

I was thinking that a quick-and-dirty personal project or internal webpage might want this, but I suppose the file size wouldn't be a major consideration for them anyway and the transpiled and minified package will suffice, so fair enough.
Regarding how surprising certain behaviors are or how tricky the library sounds to use depends largely on the sample code provided, and granted, I did not document any of my changes yet in the readme or changelog. The documentation doesn't have to start with the complicated stuff though – the current simplest example with assignBrowse, assignDrop and hooks/events will work going forwards too.
I don't agree that there's no gain to awaiting in some of the hooks. The hooks become async only if the user decides to use async code in them, and I'm seeing just some new possibilities that this opens up: validating a single file in file-added or all at once in files-added, or pinging the server about a client-side filtered list that it can expect to receive soon in files-submitted.
I'm not saying that there are no downsides for upgrading users, but in my opinion those are manageable. When addFile or addFiles is called directly, it will need to have await or .then, and that code possibly needs to be transpiled, sure. Same for uploadNextChunk, later generateUniqueIdentifier, AsyncFlowFile's bootstrap and FlowChunk's uploadStreamChunk if the user needs their results after calling them manually. But that's all, isn't it? Everything else about async is opt-in.
That said, I don't want to make assumptions about the userbase of flow.js – I only heard of this project just two weeks ago and I've no idea what others are using it for. I can only speak for myself, my usage has been purely event-based in a web app where none of the async stuff could have a negative effect.
I wouldn't be opposed to having an AsyncFlow class (that in turn uses an AsyncEventizer) either, but it certainly wouldn't simplify the codebase. Switching to native async/await could reduce the amount of code and subclassing would mean rearranging what we currently have. For the flow.js user that ends up being just a different kind of an opt-in, albeit not a forced one.

On commit 64ab7fe and always emitting the catch-all event, that matches the behavior of v2, the synchronous hook of v3, and the way it's currently documented. I rewrote the function in the if-else way to avoid repeating the emitCatchAll() line, and to avoid changing the order in which the hook and event are fired: the hook's custom callback first and catch-all last. I've left it there for now as a duplicate call. (#359)
Let's leave 20bbf4c (async generateUniqueIdentifier) for later along with combining readFileFn/asyncReadFileFn since it's not an absolutely necessary change for the basic async functionality.
The rest of the PRs (#356, #357, #358, #360) are now submitted on the v3 branch. Thank you for laying them out so well!

I hope you the best for the rebase. I'm eager to review this PR in its purest new shape.

I went into the hurdle of rebasing your PR and ended up with #363
You'll find the substantial core of this PR inside 8ec1e55fdd on top of which I'm now polishing.
If it sounds satisfying we could close this one which got outdated and continue working there?
(I'll wait for your confirmation)


MedicationRequest and MedicationStatement

The current build for the IG specifies MedicationStatement as the base resource for each MedicationLine. However, I also see a couple issues raised related to MedicationRequest (see issues 213 and 216).

Do we have more details on how MedicationRequest will be used in this Medications IG?

Additional Context: For representing a patient’s medication list, the International Patient Summary (IPS) specification notes that both MedicationStatement and MedicationRequest resources can be used to document medication history. However, relying on both resources can hinder interoperability between systems. To improve consistency, IPS-aligned implementations should explicitly support one resource—preferably MedicationRequest, as it encompasses orders, administration instructions, and patient-reported medications. This approach aligns with frameworks like the US Core Implementation Guide and reduces the need for additional extensions. Considering MedicationRequest for this role helps ensure a more streamlined and interoperable representation of medication data.

The medication request is used in medication prescription (Recip-e) and is in the branch prescription.
MedicationRequest is used as a Request, an order. I think the relationship Prescription-MedicationLine is clear in the document in issue 216. Basically a prescription can then feed into an overview of a patient's medication (MedicationLine), or, as is planned, the MedicationLine would be the placeholder for a treatment, from which a Prescription can be administratively derived.
For a medication overview, we had some cross-country work that was started and of the several resources, we landed on MedicationStatement, also in alignment with IPS.
Looking at the US Core and IPS - and respective history and how the different resources were used and became supported, and the amount of discussions on that inconsistency - I don't see how MedicationRequest could be preferred, as it does not represent patient-reported medications. And does not represent medications that are dispensed and taken but never ordered.
Based on previous discussions, I am of the opinion that no, a MedicationRequest doesn't provide the necessary scope, improves consistency, or that it is more IPS-aligned, or reduce the need for additional extensions (which extensions?) or would help ensure a more streamlined and interoperable representation of medication data. I think it's the opposite - MedRequest is there for legacy.


unsymmetrical labeling of some button

I've noticed an unsymmetrical labeling of some buttons in the settings menu and i'm not sure if this is intended:

This is caused by the following style.css settings:
.sls-btn-left
.sls-btn-right

Thank you for pointing that out.
It looks had been corrupted a bit long ago. It has been fixed at version 0.17.7. Could your please check this version?

Thx for the fast response.
Yes, release 0.17.7 seems to fix the issue👍


RAC ComboBox option to select on item focus

Provide a general summary of the feature here
I'm building a search autocomplete and I want it ti behave similarly to Google/Amazon where highlighting an item to select it automatically.
I see that there's a SearchAutocomplete component in the works but it doesn't seem public yet. (And I assume it's Spectrum only so I have to wait for it to land to RAC.) The second easiest would be to have a prop that allows selection by focus. The third would be to expose an event handler that's called with highlighted key.
I'd go lower level with the hooks path but highlighted item doesn't seem to be exposed there either.
🤔 Expected Behavior?
There should be some way to use listbox highlighted item.
😯 Current Behavior
I couldn't find any way to access highlighted item.
💁 Possible Solution
No response
🔦 Context
Building a search autocomplete component.
💻 Examples
google.com
amazon.com
🧢 Your Company/Team
No response
🕷 Tracking Issue
No response

I think you could probably do this with the hooks right now. You would need to make it fully controlled and update the input value whenever the selection changes.
Search autocomplete is similar to a combobox, but it uses a search field and no trigger button. Those hooks are currently in alpha, but the docs can be previewed here. We should have a RAC SearchAutocomplete component once the hooks get a GA release.

Thanks for sharing the preview docs for the useSearchAutocomplete hook, I'm willing to give it a try!
About using fully controlled combobox, if I'm not mistaken the selection state is when the user picks an item from the listbox, but I want to customize it to populate the text field when it's focused with keyboard. I checked Google and Amazon for prior art and they both work this way, and it felt natural to me. (Amazon example doesn't seem accessible but Google is, AFAICT.)

Ahh yeah, you need the focus state. You would need to listen to focus events on the listbox (or items) to tell what is focused. Not ideal, but that is the only way I can think of.


Fix recursion in flake inputs.

hydra-eval-jobs seems to have trouble evaluating this flake.
error: cannot update flake input 'cardano-node-workbench/membench' in pure mode
Simplifying the recursion in the flake inputs seems to help.
Fixes #4525

I think this is good to go. Only the non-required fail, which have been failing for a while, and should be broken out in a separate PR to fix.

bors try

bors merge


Evaporation sensor not working

Version of home_assistant
2024.8.3
Version of the custom_component
2.1.10
Describe the bug
Error adding entity sensor.zu_hause_verdunstung_in_den_nachsten_24_stunden for domain sensor with platform dwd_weather
Traceback (most recent call last):
File "/usr/src/homeassistant/homeassistant/helpers/entity_platform.py", line 598, in _async_add_entities
await coro
File "/usr/src/homeassistant/homeassistant/helpers/entity_platform.py", line 912, in _async_add_entity
await entity.add_to_platform_finish()
File "/usr/src/homeassistant/homeassistant/helpers/entity.py", line 1366, in add_to_platform_finish
self.async_write_ha_state()
File "/usr/src/homeassistant/homeassistant/helpers/entity.py", line 1005, in async_write_ha_state
self._async_write_ha_state()
File "/usr/src/homeassistant/homeassistant/helpers/entity.py", line 1130, in _async_write_ha_state
self.__async_calculate_state()
File "/usr/src/homeassistant/homeassistant/helpers/entity.py", line 1071, in __async_calculate_state
if extra_state_attributes := self.extra_state_attributes:
^^^^^^^^^^^^^^^^^^^^^^^^^^^
File "/config/custom_components/dwd_weather/sensor.py", line 442, in extra_state_attributes
attributes["data"] = self._connector.get_evaporation_daily()
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
File "/config/custom_components/dwd_weather/connector.py", line 649, in get_evaporation_daily
timestamp = datetime(
^^^^^^^^^
ValueError: day is out of range for month
Debug log
home-assistant_dwd_weather_2024-09-24T12-40-39.836Z.log

Thanks for reporting, this is fixed now in version 2.1.11.

The error message is gone, but the sensor still does not have a value:

It might be, that your station doesn't provide these values. I'll check this

In 2.1.12, using hourly updates the attributes for the evaporation sensor are still null. For the "normal" update rate, the current value is still "unknown", but the values for the next days are not null.
Hourly:

Normal:

In the hourly data the evaporation data is not provided by DWD. I removed the sensor from the hourly data in v2.1.13 therefore.


Example does not compile

The example does not compile, lib/chat.dart has an issue line 84:
lib/chat.dart:84:25: Error: The argument type 'String?' can't be assigned to the parameter type 'String' because 'String?' is nullable and 'String' isn't.
final file = File(filePath);
Flutter environment:
Doctor summary (to see all details, run flutter doctor -v):
[✓] Flutter (Channel stable, 2.5.1, on macOS 11.6 20G165 darwin-x64, locale en-US)
[✓] Android toolchain - develop for Android devices (Android SDK version 30.0.3)
[✓] Xcode - develop for iOS and macOS
[✓] Chrome - develop for the web
[✓] Android Studio (version 4.2)
[✓] VS Code (version 1.60.1)
[✓] Connected device (1 available)
• No issues found!

Forgot to update dependencies, updated on main branch now :)


Syntax incompatibility with neo4j on querying edges by multiple labels

neo4j-gremlin-bolt: v0.4.3
neo4j: v4.1.1
When creating one of the following queries I get an exception from Neo4j noting that separating alternative relationships by colon is not supported anymore (afaik since 4.x):
graph.traversal().V().hasLabel("vLabel").in(List.of("label1","label2").toArray(new String[0]))
graph.traversal().V().hasLabel("vLabel").out(List.of("label1","label2").toArray(new String[0]))

the corresponding error message:
i.r.p.w.a.GlobalDefaultExceptionHandler  : Sending ErrorResponse (status: 500 INTERNAL_SERVER_ERROR, ClientException: The semantics of using colon in the separation of alternative relationship types in conjunction with the use of variable binding, inlined property predicates, or variable length is no longer supported.
Please separate the relationships types using `:A|B|C` instead (line 1, column 47 (offset: 46))
"MATCH (n:`vLabel`)<-[r:`label1`|:`label2`]-(m) WHERE ID(n) = $id RETURN m"

Is this known behaviour? I currently workaround by using one label at a time, but I'd very much like to do it in a single query.

The issue should be fixed, please try version 0.4.4 and close issue. Thanks for reporting it.

Works perfectly now without issues. Thanks a lot for the fast response!!!


cannot delete previous configs

premise
I already have configured globally a git account, for example:
user.name=Name Surname
<EMAIL_ADDRESS>issue
To try the extension I opened a folder with vs code and then added the local config through the extension with these parameters:
user.name=namesurname (different name)
<EMAIL_ADDRESS>(the same)
Then, I noticed the I wanted to use the same user.name both global and local.
I deleted the local configs through git config --local --unset user.name but everytime I re-open that folder, when I want to set the new (and correct) local config, the extension menu shows the previous config in the list.
I don't know where I have to touch to tell the extension that I want completely remove that old config.
Thanks for any help

I found the fix for this issue (that is not actually an issue):
Go to "Extension Settings" to edit the "settings.json" file.
Delete the item you find in this list:
"git-autoconfig.configList": [
         {
              "user.email"<EMAIL_ADDRESS>              "user.name": "namesurname"
         },
    ]


Update bugged get_root_hash_at_epoch function

The API does not function as intended - instead of getting the root hash at a specific epoch, it gets the root hash at the latest epoch.
As we no longer store all nodes from past epochs, we are unable to generate root hashes of past epochs with the directory. Therefore I update the function to get_root_hash_safe, which instead checks that the input epoch is equivalent to the latest epoch before returning the root hash (of the latest epoch). This gives callers a way to know if the root hash they are trying to retrieve is not from the epoch that they expect.

Please merge from main before pushing commit.

Rebased on main


comment:re sklearn -- integer encoding vs 1-hot (py)

(Your post popped up in my twitter feed)
I'm not sure why you said you needed to one-hot encode categorical variables for scikit's random forest; I'm fairly certain you do not need to(and probably shouldn't).  It's been awhile since I looked at the source, but I'm pretty sure it handles categorical variables encoded as a single vector of numbers just fine from empirical tests; performance is almost always worse if the features were one-hot encoded.

There is some discussion on this topic here https://stackoverflow.com/questions/15821751/how-to-use-dummy-variable-to-represent-categorical-data-in-python-scikit-learn-r So, I'm not sure the alternative is better, you are welcome to try it if you'd like by changing this https://github.com/szilard/benchm-ml/blob/master/2-rf/2.py and I would be happy to rerun/time it.

This thread is interesting read as well<EMAIL_ADDRESS>

I tried it out: 1. Generate integer-encoded categoricals https://gist.github.com/szilard/b2e97062025ac9347f84 2. https://gist.github.com/szilard/56706595b4594e297414
You get a >10x speedup, lower memory footprint and increase in AUC (n=1M):
1-hot:    Time: 900s RAM: 20G AUC: 73.2
int-enc:  Time:  60s RAM: 15G AUC: 75.0
I would expect faster, lower memory but decrease in AUC (or same in same cases). I think the increase in AUC is because 3 variables are actually ordinal (month, day of month and day of week). I should probably use 1-hot encoding to have a fair comparison with the previous results.

Same with mixed encoding (above 3 variables 1-hot, the rest integer encoding - so that I don't give an advantage in accuracy by mapping the ordinal variables to integers):
mixed:  Time: 200s  RAM: 16G AUC: 73.2
This make sense now, integer encoding vs 1-hot is faster (5x), lower memory footprint, same AUC (though not clear to me when to expect same AUC and when lower even after this excellent thread<EMAIL_ADDRESS>)
Any further thoughts @ogrisel @glouppe ?

Thanks for the benchmarks! Proper handling of categorical variables is not an easy issue anyway.

I would expect faster, lower memory but decrease in AUC (or same in some cases).

When the categories are ordered, it makes more sense indeed to handle them as numerical variables. I dont have a strong argument as to why it may be also better when there is no natural ordering. I guess it could boil down to the fact that one-hot encoding splits are often very unbalanced, while integer encoded splits may be less unbalanced.

Thanks @glouppe. I read somewhere a paper that AFAIR suggested to sort the (non-ordered) categoricals in order of their frequency in the data and encode them as integers as such. Any idea what that paper might be?

Yes, it is Breiman's book :) When your output is binary, this strategy is in fact optimal (it will find the best subset among the values of the categorical variables) and linear.
See section <IP_ADDRESS> of my thesis if you dont have the CART book.
http://orbi.ulg.ac.be/bitstream/2268/170309/1/thesis.pdf

Great, thanks :)

One-hot encoding could be helpful when the number of categories are small( in level of 10 to 100). In such case one-hot encoding can discover interesting interactions like   (gender=male) AND (job = teacher).
While ordering them makes it harder to be discovered(need two split on job). However, indeed there is not a unified way handling categorical features in trees, and usually what tree was really good at was ordered continuous features anyway..

Thanks @tqchen for comments

For n=10M the results with integer encoding (along with previous n=1M result):
n=10M Time: 1500s RAM: 120G AUC: 78.3
n=1M   Time: 60s     RAM: 15G   AUC: 75.0

@tqchen  Hi Tianqi, would you please explain more on why tree was better at ordered continuous features than discrete ones? is it because there are much more split points for continuous features? Thanks.


examples: add Jupyter notebook with beta-hairpin data analysis

Proposed changes
I propose to merge @wildromi branch where she added a new Jupyter notebook examples with a beta-hairpin data analysis using two different data representations.
Types of changes
What types of changes does your code introduce?
Put an x in the boxes that apply

[ ] Bugfix (non-breaking change which fixes an issue)
[x] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist
Put an x in the boxes that apply.

[x] Lint and unit tests pass locally with my changes
[ ] I have added tests that prove my fix is effective or that my feature works

I will add another commit that links the notebook to the documentation

Codecov Report

Merging #76 (f03ba9c) into main (33d150b) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main      #76   +/-   ##
=======================================
  Coverage   78.16%   78.16%
=======================================
  Files          10       10
  Lines        1177     1177
=======================================
  Hits          920      920
  Misses        257      257

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 33d150b...f03ba9c. Read the comment docs.


Endpoints are not being updated with new IP address of a pod.

Output of helm version:
Client: &version.Version{SemVer:"v2.12.3", GitCommit:"eecf22f77df5f65c823aacd2dbd30ae6c65f186e", GitTreeState:"clean"}
Server: &version.Version{SemVer:"v2.14.2", GitCommit:"a8b13cc5ab6a7dbef0a58f5061bcc7c0c61598e7", GitTreeState:"clean"}

Output of kubectl version:
Client Version: version.Info{Major:"1", Minor:"15", GitVersion:"v1.15.1", GitCommit:"4485c6f18cee9a5d3c3b4e523bd27972b1b53892", GitTreeState:"clean", BuildDate:"2019-07-18T09:18:22Z", GoVersion:"go1.12.5", Compiler:"gc", Platform:"darwin/amd64"}
Server Version: version.Info{Major:"1", Minor:"12+", GitVersion:"v1.12.10-eks-2e569f", GitCommit:"2e569fd887357952e506846ed47fc30cc385409a", GitTreeState:"clean", BuildDate:"2019-07-25T23:13:33Z", GoVersion:"go1.10.8", Compiler:"gc", Platform:"linux/amd64"}

Cloud Provider/Platform (AKS, GKE, Minikube etc.): AWS EKS
The problem:
After jenkins upgrade the Endpoints are no longer updated. Basically when the pod is restarted with a new IP the endpoints are no longer point to it. They are blank.
jenkins                                  <none>                                                                19h
jenkins-agent                            <none>                                                                19h

I have to then find jenkins pod IP address, delete both endpoints and create a new endpoints with a new IP address.
Is there a way to fix that so the endpoints will get updated automatically?

Transferring to helm/charts as at first glance this appears to be a chart usability issue rather than a core CLI issue.

This happened after helm failed to upgrade jenkins and then I rollback the release and it was succesful (apart from now not updating endpoints) I understand that Endpoints are updated by ReadinesProbe.
Current ReadinesProbe from deployment is:
        readinessProbe:
          failureThreshold: 3
          httpGet:
            path: /login
            port: http
            scheme: HTTP
          initialDelaySeconds: 60
          periodSeconds: 10
          successThreshold: 1
          timeoutSeconds: 1

Log from Jenkins pod is:
Events:
  Type     Reason                  Age    From                                                  Message
  ----     ------                  ----   ----                                                  -------
  Normal   Scheduled               8m13s  default-scheduler                                     Successfully assigned default/jenkins-pod-id to <ip>.<region>.compute.internal
  Normal   SuccessfulAttachVolume  8m6s   attachdetach-controller                               AttachVolume.Attach succeeded for volume "jenkins"
  Normal   Pulling                 8m4s   kubelet, <ip>.<region>.compute.internal  pulling image "jenkins/jenkins:2.176.2-alpine"
  Normal   Pulled                  7m57s  kubelet, <ip>.<region>.compute.internal  Successfully pulled image "jenkins/jenkins:2.176.2-alpine"
  Normal   Created                 7m56s  kubelet, <ip>.<region>.compute.internal  Created container
  Normal   Started                 7m56s  kubelet, <ip>.<region>.compute.internal  Started container
  Normal   Pulling                 7m43s  kubelet, <ip>.<region>.compute.internal  pulling image "jenkins/jenkins:2.176.2-alpine"
  Normal   Pulled                  7m42s  kubelet, <ip>.<region>.compute.internal  Successfully pulled image "jenkins/jenkins:2.176.2-alpine"
  Normal   Created                 7m42s  kubelet, <ip>.<region>.compute.internal  Created container
  Normal   Started                 7m42s  kubelet, <ip>.<region>.compute.internal  Started container
  Warning  Unhealthy               6m40s  kubelet, <ip>.<region>.compute.internal  Readiness probe failed: Get http://<IP_ADDRESS>:8080/login: net/http: request canceled (Client.Timeout exceeded while awaiting headers)

The pod got IP almost instantly but it takes a few minutes for the container to start. How can I get the ReadinesProbe to update Endpoints? As we are shutting down the platform every night, Jenkins IP address changes and I have to update endpoints manually.

Update: Just enabled EKS logs and got this:
deployment_controller.go:484] Error syncing deployment default/jenkins: Operation cannot be fulfilled on deployments.apps "jenkins": the object has been modified; please apply your changes to the latest version and try again

Below helped. The readinessProve is still failing but this is due to Jenkins taking 90s to start. I will update this.
helm delete jenkins
release "jenkins" deleted

helm rollback jenkins 25
Rollback was a success! Happy Helming!


application_launched action for Google Chrome

I've been managing yabai so that some applications that use small windows start as floating and upon launch they would automatically become tiled, so that the subsequent windows that said app creates are still floating, while the main one is tiled.
This is the case of Mail for me, which works like a charm, but I cannot make Google Chrome follow said pattern.
Here is the code I use which works for Mail but has no effect on Google Chrome, am I missing something or is this a known issue?
yabai -m signal --add event=application_launched app='^Mail$' action='yabai -m window --toggle float'
yabai -m signal --add event=application_launched app='^Google Chrome$' action='yabai -m window --toggle float'
If any extra info is neeeded I am more than happy to look for what is causing the issue!

I had a similar issue with Google Chrome. I had to quit google chrome with ⌘Q and relaunch sometimes.

The application_launched signal may trigger before the windows are restored. This looks like a timing issue in your signal to me, since you simply look for the active window (default selector).

The application_launched signal may trigger before the windows are restored. This looks like a timing issue in your signal to me, since you simply look for the active window (default selector).

You were absolutely right, it apparently triggers before there is a window to even be selected!
For future reference if anyone encounters this problem, I just solved it with a simple sleep command as such:
yabai -m signal --add event=application_launched app='^Google Chrome$' action='sleep 0.7 && yabai -m window --toggle float'
Issue closed!


python311Packages.pyunifiprotect: 4.22.0 -> 4.22.3

Diff: https://github.com/briis/pyunifiprotect/compare/refs/tags/v4.22.0...v4.22.3
Changelog: https://github.com/AngellusMortis/pyunifiprotect/releases/tag/v4.22.3
Description of changes

Things done

Built on platform(s)

[ ] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)

[ ] sandbox = relaxed
[ ] sandbox = true

[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
24.05 Release Notes (or backporting 23.05 and 23.11 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[ ] Fits CONTRIBUTING.md.

Add a :+1: reaction to pull requests you find important.

Result of nixpkgs-review pr 274679 run on x86_64-linux 1

6 packages built:

python310Packages.pyunifiprotect
python310Packages.pyunifiprotect.dist
python311Packages.pyunifiprotect
python311Packages.pyunifiprotect.dist
unifi-protect-backup
unifi-protect-backup.dist


CI builds Interfering with release build release notes

This issue may be more of a TFS question but I thought I'd ask in case there is a way to overcome this with this tool.  I installed the GenerateReleaseNotes build task (version 2.5.1) in our on-premises TFS system (TFS 2015 Update 3).  The extension is working quite well but I was wondering if there is a way to handle the following scenario:
We define two TFS build definitions, one for continuous integration builds (which don't use the GenerateReleaseNotes task) and a release build definition which does use the GenerateReleaseNotes task and ultimately creates a release candidate build with installers that the QA team can use to test.  In that scenario I am finding that when committing code to my repo, the CI build is triggered which is great, but later when I try to manually queue the release build the release notes won't show any associated changes because the CI build had already swallowed them up essentially.

This is not the extension problem, this is how TFS associate WI/Commits with builds.
Use different build definitions for CI and manual builds (or different branches, but this is a not a good idea).

Sorry, my first comment was wrong.
Extension uses TFS API to get associated WI with build. It should work with using different build for CI and Release bulds.
We have a similar situation with builds, but it works fine. Your release build shows WI?

Yes @insanity13 is correct, the way it works it the build knows its buildid, this is used to lookup the build details via the rest API which includes the associated work items and changesets.
The associated work items and changesets as linked based on the last successful build of the same build definition. So assuming you only run the release build when you release the product the associations should be correct, as you want.
If you want the release notes to span a number of build then this is possible if the task is used within a release pipeline as you can tell it to look for all builds since the last successful release (as opposed to build). In your case you could maybe add a release that just copies the installers (MSIs?) to a know folder for your QA team to pickup.
But fundamentally the release notes report should match the build summary report

Thanks to you both for your clarification!  It was clearly not working for me after several attempts, but once I recreated one of the build definitions from scratch (had created a clone of the other originally) and ensured that the non-CI build was creating a label (it had earlier been set to create a label on a successful build but this was failing because the label included the build definition name which had a space in it) then it started to work as expected.  Anyway, I think I am in a good state now and thanks for creating such a great tool and making it available!

Glad you are working now


[Linux] - Bad EOL for 6.7

https://endoflife.date/linux
EOL for Linux 6.7 is  03 Apr 2024, not 07 May 2024, see https://www.kernel.org/

Thanks @dr47 for raising this issue. I created the PR #4993 to update this.


Create Condition/Validator without creating/extending a type

Currently, adding a new Condition can be cumbersome, as it requires creating/extending an existing type and adding a function. This is in part because the build_condition method automatically extracts information from the method calling it, including method name, method arguments, and method class, and stores this along with the validator in the Condition. All this extra information is just stored for tracking purposes, and so that when someone looks at a report, they can see what the test is actually doing.
Even though in some cases, especially for built-in types, this may be desirable, we don't want to force people to create a new Value type just to define a validation/condition. Figure out how to handle this instead. One option is simply to ask the user to create a Condition instead of using build_condition, and passing the name and arguments manually, and allowing the class to be null. It also may be the case that a Condition per se is no longer needed, if all the data was was being shown here is basically serialized in the Validator inside, instead of being opaquely serialized as a pickle (see #507).
Maybe the "arguments" (actually thresholds) can be passed to the Validator, as also described in #507, and thus do not need to be stored at the Condition level at the same time. In this case, the only contribution of Condition on top of a Validator is 1) a name, 2) a class that contained a function the Condition came from, which doesn't exist if a Validator is created manually. If that is the case, it may be better to eliminate the concept of Condition, and just have a Validator, that can be created either manually by a person, or by calling build_validator(); and in the second case, it automatically adds extra metadata, including the method name, method arguments/thresholds, and class it came from; in the first one, the method name and class would not exist, and the argument/thresholds would have to be passed manually. It may end up looking something like this:
Old Validator model:
 "predicting memory": {
                        "name": "average_consumption_less_than",
                        "arguments": [512000.0],
                        "callback": "gASVz...",
                        "value_class": "mlte.measurement.memory.local_process_memory_consumption.MemoryStatistics"
                    }

New Validator model:
{
        "bool_exp": "lambda value: sum(g >= threshold for g in value.array) == len(value.array)",
        "thresholds": [512000.0],
        "success": "All accuracies are equal to or over threshold 512000.0",
        "failure": "One or more accuracies are below threshold 512000.0",
        "callback_bool_exp": "aDsada...",
        "from_class": "mlte.measurement.memory.local_process_memory_consumption.MemoryStatistics",
        "from_method: "average_consumption_less_than"
}

New Validator when there is no value type this came from:
{
        "bool_exp": "lambda value: sum(g >= threshold for g in value.array) == len(value.array)",
        "thresholds": [512000.0],
        "success": "All accuracies are equal to or over threshold 512000.0",
        "failure": "One or more accuracies are below threshold 512000.0",
        "callback_bool_exp": "aDsada...",
}

For now, the validator is only having its data, and the Condition is on top, but the other Condition values can be empty if someone was creating a condition from scratch, and not from build_condition.


customize camera margin

Sorry, I made a pull request by mistake.
I love this package because I can get the text read from the camera.
Sorry for the inconvenience.


Preserve python exceptions

Follow up on comment: https://github.com/wkentaro/gdown/pull/244#issuecomment-1437794404
Summary
Exceptions are printed only on cli (otherwise simply raised)

@Skitionek https://github.com/wkentaro/gdown/pull/260 will resolve this.


Can't update from 1.8 to 1.9 on Windows: could not rename component file

I'm not sure if this is related to #426 or different... but the error message is different, so I'll open a new issue ticket and you can close if desired.
I can't update from 1.8 to 1.9, using the MSVC stable branch:
C:\Users\Jacob> rustup self update
info: checking for self-updates
info: downloading self-update
info: rustup updated successfully

C:\Users\Jacob>rustup --version
rustup 0.1.12 (c6e430a 2016-05-12)

C:\Users\Jacob>rustup show
stable-i686-pc-windows-msvc (default)
rustc 1.8.0 (db2939409 2016-04-11)

C:\Users\Jacob>rustup update
info: syncing channel updates for 'stable-i686-pc-windows-msvc'
info: downloading component 'rustc'
 35.0 MiB /  35.0 MiB (100 %)   5.2 MiB/s ETA:   0 s
info: downloading component 'rust-std'
 46.6 MiB /  46.6 MiB (100 %)   5.5 MiB/s ETA:   0 s
info: downloading component 'rust-docs'
  5.6 MiB /   5.6 MiB (100 %)   4.9 MiB/s ETA:   0 s
info: downloading component 'cargo'
info: rolling back changes
error: could not rename component file from 'C:\Users\Jacob\.multirust\toolchains\stable-i686-pc-windows-msvc\bin/test-4fda350b.dll.lib' to 'C:\Users\Jacob\.multirust\tmp\hvxiy3mkmyzhkgdr_file'
info: checking for self-updates
info: rustup is up to date

  stable-i686-pc-windows-msvc update failed - rustc 1.8.0 (db2939409 2016-04-11)

I do have a .multirust\tmp folder.  I don't see anything in it that would block the creation of files in it.  If I try to move test-4fda350b.dll.lib by hand, I can move it by hand.

...but rustup update worked fine on a second computer of mine (again stable windows msvc).  I wonder what's up with my first computer.

It also worked flawlessly on my own test system.
On Thu, May 26, 2016 at 5:07 PM Jacob Morzinski<EMAIL_ADDRESS>wrote:

...but rustup update worked fine on a second computer of mine (again
stable windows msvc). I wonder what's up with my first computer.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/rust-lang-nursery/rustup.rs/issues/501#issuecomment-222028510,
or mute the thread
https://github.com/notifications/unsubscribe/AAEXkouw_yXSJtVSLZpJMUDmrtKBL2yAks5qFjW5gaJpZM4In7hQ
.

--
Jeremiah Peschka

I worked around the issue with rustup toolchain remove stable followed by rustup toolchain install stable.  (I was confused that the documented uninstall subcommand failed with an error entered unreachable code, but happily found the remove synonym in PR #477 .)
All set here.

Thanks for the report. I'm afraid I don't know what the issue is offhand.

Just ran into this issue upgrading x86_64 msvc rust 1.14 to 1.15 but after 3 fails next try succeed.

My original report is solved: it turns out that my anti-virus (Sophos) was blocking one of the file replacement actions that rustup was trying to perform.  Sorry for not catching this earlier.

I am also seeing this issue trying to upgrade from 1.16 to 1.17 (the first time I've attempted and update).
I'm on a company-provided Windows 7 laptop running McAfee antivirus (which AFAIK I can't disable, even temporarily), so I wouldn't be at all surprised if McAfee is somehow preventing file-access.
I tried eight times, and each time the file that could not be renamed was different. (The failure always came when attempting to install the rust-src component.)

I'm having the same issue with McAfee, specifically Endpoint Security as well.  I too cannot whitelist rustup or remove the program as I don't have admin rights entirely on my VM at work.  They may not have updated some of the virus definitions or maybe their fuzzer is over-eager but some of the files are being blocked.  This only seems to be affecting the stable channel but not the nightly one.  I've deleted everything and reinstalled rust via rustup at least 2 times and this still seems to be happening. Here's a snippet from powershell in my VM:

The stable channel hasn't been able to update for at least since I installed it February.  Let me know what I else I can do to help out!

McAfee explicitly reports rustup and/or rustc and/or cargo and deletes them every now and then. Reinstall is possible, but mcafee kicks in about every second day! This should be fixed in McAfee generally! Are there any negotiations already?

The best thing you can do is contacting your AV producent, even if they
know about it already more reports can increase priority of this bug.
23.12.2017 00:16 "emabee"<EMAIL_ADDRESS>napisał(a):

McAfee explicitly reports rustup and/or rustc and/or cargo and deletes
them every now and then. Reinstall is possible, but mcafee kicks in about
every second day! This should be fixed in McAfee generally! Are there any
negotiations already?
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/rust-lang-nursery/rustup.rs/issues/501#issuecomment-353689054,
or mute the thread
https://github.com/notifications/unsubscribe-auth/ABHsdhrebiSADZrpFrlVZB696ohU00Iuks5tDDg9gaJpZM4In7hQ
.


Add support for docfx.json

The .NET mapper will currently scan for project.json/MSBUILD files and add them to the command-line call. This becomes problematic for large projects because you can hit limits on the command-line length.
The docfx tool supports specifying which projects you want to generated api refs for using a docfx.json file. If this file is found it should be used instead of scanning specific project files.

Looks like the output folder can be specified in docfx.json. Not sure what the impact of that will be on https://github.com/rtfd/sphinx-autoapi/issues/45.

Actually, looks like I can use autoapi_file_patterns = [ 'docfx.json' ] and get this to work already.
Might be nice to have this supported by default though.


Static != Readonly

In the CardType class, those static members should be public static readonly CardType .... Otherwise, it's possible for someone to reassign something that everyone would assume to be unchanging.
Hate to pick nits, but I once read that "example code should be exemplary."

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: d118f070-8743-e905-2d08-dc725a4e8b5f
Version Independent ID: fae35cbd-75ae-4448-f066-7c91ccc35779
Content: Using Enumeration classes instead of enum types
Content Source: docs/architecture/microservices/microservice-ddd-cqrs-patterns/enumeration-classes-over-enum-types.md
Product: dotnet-architecture
Technology: microservices
GitHub Login: @nishanil
Microsoft Alias: nanil

The members are:
 public static CardType Amex = new CardType(1, "Amex");
 public static CardType Visa = new CardType(2, "Visa");
 public static CardType MasterCard = new CardType(3, "MasterCard");

Which allows one to do this:
void Main()
{
	Console.WriteLine($"{CardType.Amex.Id}: {CardType.Amex.Name}");

//	// These are compile-time errors
//	CardType.Amex.Name = "something totally different";
//	CardType.Amex.Id = 42;

	// However, this is completely legal.
	CardType.Amex = new CardType(42, "something totally different");
	Console.WriteLine($"{CardType.Amex.Id}: {CardType.Amex.Name}");
}

1: Amex
42: something totally different

Marking it as
public static readonly CardType Amex = new CardType(1, "Amex");

also makes the above change a compile-time error.
I will submit a PR shortly.

https://github.com/dotnet/docs/pull/16339


fix: 🐞 Full name formatting when length is passed

Fix issue where length value is passed to randFirstName and randLastName
meaning the formatting is broken
✅ Closes: #100
PR Checklist
Please check if your PR fulfills the following requirements:

[x] The commit message follows our guidelines: https://github.com/ngneat/falso/blob/master/CONTRIBUTING.md#commit
[x] Tests for the changes have been added (for bug fixes / features)
[ ] Docs have been added / updated (for bug fixes / features)

PR Type
What kind of change does this PR introduce?

[x] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Other... Please describe:

What is the current behavior?

Issue Number: N/A
What is the new behavior?
Does this PR introduce a breaking change?
[ ] Yes
[x] No

Other information

I'm adding a fix to this quick


Images smaller than lightbox container aren't centered.

Just a little tiny fix needed. PR incoming.

This is merged in and released in 0.2.1. Thanks Jack.


Print target kubeconfig

What this PR does / why we need it:
This PR adds the command target kubeconfig to print the kubeconfig for the current target.
This is especially useful to retrieve the gardenlogin kubeconfig for Shoot clusters, as these kubeconfigs will not be written anymore to the garden cluster as ConfigMaps, as the gardenlogin-controller-manager will be deprecated (ref #149)
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Release note:

You can now print the kubeconfig for the current target using `gardenctl target kubeconfig` command

/close in favor of https://github.com/gardener/gardenctl-v2/pull/152


Update popover position when keyboard is shown

I have an popover at the bottom of the screen with textField on it, how can i update popover position, when user taps on the textField and keyboard is shown?

same problem 😭

find a way?


structured output completion example

Purpose

Structured outputs allow you to enforce a specific JSON Schema definition when making an inference API call. This means you can dictate exactly what the output should look like, ensuring that it conforms to the structure you expect.
This feature is particularly beneficial for scenarios where you need to call specific functions based on the output. By using structured outputs, you can be confident that the necessary parameters and formats are adhered to, facilitating smoother integration with your applications.

Does this introduce a breaking change?

[ ] Yes
[X] No

Pull Request Type
What kind of change does this Pull Request introduce?

[ ] Bugfix
[X] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Documentation content changes
[ ] Other... Please describe:

How to Test

Get the code

git clone https://github.com/akshana-aravind/azureopenai.git
cd azureopenai
git checkout main
npm install

Test the code

@microsoft-github-policy-service agree

@colombod  can I please get a review on this when you get a chance. Thanks.


[bug fix] Load keys on set strategy on embed-many and reference-many

Currently, when loading "many" data using the set strategy, the key is lost when the data is loaded. This code corrects that problem.

Does this patch enable this sort of thing?
<?php

class Person
{
  /** @ReferenceMany */
  public $relations = array();
}

$me = new Person();
$mom = new Person();
$me->relations['mother'] = $mom;

Yes it does. The persisting side of it was patched a couple of months ago , sadly I'm just now getting to using the loading side of it.
It doesn't do anything with the inverse side mapping or repository method mapping, it just didn't make sense to me in this context.

:+1:

Fixed. @jwage, thanks for pointing those out.

I am getting a "Cannot apply $pull/$pullAll modifier to non-array" error when I remove an embedded document from an @EmbedMany(strategy="set") collection and flush. Any ideas?

From the trace:
MongoCollection->update(array('_id' => object(MongoId)), array('$pull' => array('socialProfiles' => null)), array('safe' => true))

I was getting that same error when I first started work on the first PR for this I can't remember off hand if handling the delete goes through there also or somewhere else. That's where I'd start looking.

@kriswallsmith, now that I actually look at the code, the problem must be with line https://github.com/doctrine/mongodb-odm/blob/master/lib/Doctrine/ODM/MongoDB/Persisters/CollectionPersister.php#L141 we probably need to do a check to see if we are using the set strategy and if we are, then don't execute line 141. Just a guess. I might have some time to look at it on Sunday

The $pull hack is necessary after an $unset query such as...
db.foo.update({ _id: id }, { $unset: { "favoriteColors.2": true }})

...but not after...
db.foo.update({ _id: id }, { $unset: { "socialIdentities.facebook": true }})

I think @IamPersistent is correct that we tell the difference by checking the strategy. I'll submit a PR.


Implement Deploy Tokens managed resource

Signed-off-by: Stanislav2017<EMAIL_ADDRESS>Description of your changes
Added ProjectDeployToken api, client side and controller side. Added referencers for relation ProjectDeployToken with Project without hardcoded IDs

Fixes https://github.com/crossplane-contrib/provider-gitlab/issues/20
I have:

[x] Read and followed Crossplane's contribution process.
[x] Run make reviewable test to ensure this PR is ready for review.

How has this code been tested
manually and tests

Max checked this PR, I accidentally deleted it after merging new changes #34


Should we implement eslint rule: import/no-default-export?

Maybe we should also consider this rule: import/no-default-export. I never worked with that rule enabled so I don't know the downsides, but sometimes I run into problems when refactoring in the IDE that names are not updated because of the default export. I don't know if there is an added value for default exports over named exports.
Originally posted by @hjeti in https://github.com/mediamonks/frontend-coding-standards/pull/6#discussion_r440180056

yes; can I add it now ? :)

I suggest looking at your codebases, and see how often this is still used.
Maybe not in the normal "components" that you write, but more in other supported files (often around tooling).

Especially files that are loaded as "configuration" dynamically are expected to have a single default export (like webpack, monck, plop, etc)
So do story files (their meta)

Are we okay with either manually configuring them all, or constantly disabling those linting rules there?

We use it often, because we are used to it. The vue-skeleton even has the opposite rule - prefer default export, when there's a single export.
We can enable this rule only for the /src directory, excluding *.stories.ts files. This would having to deal with it in configuration files.

We use it often, because we are used to it

Sorry, I meant to say; legitimate use (according to our proposed conventions)

We can enable this rule only for the /src directory, excluding *.stories.ts files.

That would be a sound option.
👿 Are we okay with "hardcoding" the src folder in our linting rules? File extensions are pretty universal, but folder names or their location in projects could change?

Default exports are used to export components in pages in the NextJS framework. I'm updating the configuration to disallow unnamed default exports, default exports will still be allowed.


Remove incorrect comment from Dispose pattern

In the Dispose pattern, if the base class doesn't have a finalizer, it shouldn't have any unmanaged objects, so it shouldn't have a comment showing where the non-existent unmanaged objects would be freed.

👍

@BillWagner
Then you might be interested in https://github.com/dotnet/docs/issues/5485, which proposes a more radical change.


Document eUPF performance

The target is  - 10Gbps and 1Mpps per core
Acceptance criterias:

[x] Document eUPF performance numbers (total throughput, pps per core)
[x] Document eUPF performance test description

Fix in #489


NDFS remove subsumed states

at least give a count of states

Count is given.
Let's reopen when we have another use case for WSTSs.


Add new constant called PROC_NAME_MAX

Previously we were using the value of C.PR_SET_NAME to limit the size of
the buffer used to write the process name into when calling
'nvmlSystemGetProcessName()'. While this technically wouldn't cause a
buffer overrun, it limited the length of the process name by a
(somewhat) arbitrary amount since C.PR_SET_NAME is not meant to indicate
a maximum length for a process name, but rather an arbitrary code for
telling 'prctl()' to set the name for a process (which has nothing to do
with its length).
It was a clear oversight to use this random value as the buffer length.
In the new implementation we simply hard code a new variable called
PROC_NAME_MAX to 256 (which is well more than the actual maximum process
name length on linux). Having a larger value won't hurt anything, and
will make it more portable if / when we decide to start supporting
windows.

I was actually trying to make it reminiscent of PATH_MAX on linux. However, now that you point it out, I actually think it should just be an internal variable and not exported at all. It’s definitely not something that should be namespaced with NVML since it’s not part of the original NVML namespace, and it’s just an internal implementation detail at this point.


Update Buildasaur to v0.6.4

Thank you for the contribution. It needed some fixes, so they were made in ff2607a5e49faa2f82b1c909fe773a8bcf875d79. Your contribution is still included (and still credited to you), with the appropriate modifications. Please feel free to ask about any of the changes.


Sync latest specs repo
Run generation script
Run profile builder once per profile

We need some kind of wrapper that handles the process end-to-end.

Closing as it's a dupe of 1064.


[ENHANCEMENT] [MER-1897] convert image hotspot questions

Adds conversion of image hotspot questions.

Example added.


check for newlines in test

We're going to need to fix this: it's too active in the files it chooses. It checks files ignored by .gitignore, including binary files, and files locally ignored in .git/info/exclude.


How do you use the SD3 model?

Seeing support for the SD3 model, how do I use it?

I have not implemented that feature, and I'm unsure if it's even worth it when we already have good SD3 support in ComfyUI.

The results of SD3 in comfyui are not satisfactory, and maybe a different implementation will have better results

The results of SD3 in comfyui are not satisfactory, and maybe a different implementation will have better results

That has nothing to do with the Comfy implementation, it's the best one there is, the model itself is the problem.

The results of SD3 in comfyui are not satisfactory, and maybe a different implementation will have better results

You're making an issue on the wrong github repo, this is an extension for ComfyUI for Lumina models support, SD3 is supported by the main ComfyUI repo
ComfyUI repo isn't responsible for the quality either, Stability AI are the ones who messed up creating the model itself


Added configuring enabled jmx/metrics options when building cluster

Summary
Added possibility to configure enabling jmx/metrics options when creating cluster object.

Thanks for your contribution @dinatomsk !


For php7.2

Overview
Issue https://github.com/apereo/phpCAS/issues/255
Pull Request OK?
This pull request works with php 7.2 or higher.
Please use ver.1.3.5 for PHP 7.1 and below.

Sorry, I was not reading the document
https://wiki.jasig.org/display/CASC/Developing+phpCAS
I will read it now.

Hi @okashitay , thanks for starting on this PR! One thing I'm a bit unclear about is which changes are 7.2-only and break usage on PHP 7.1. I know the latest Red Hat Enterprise Linux 7 and CentOS 7 are still shipping with PHP 7.1, so while it will be be worth breaking backward compatibility with PHP 5.x soon, I'd rather not break BC with PHP 7.1 unless there are significant demonstrable benefits.

Hi @adamfranco ,
thank you for the message.
We will respond so that it can operate even in PHP 7.1.
Please wait for a while.

Hey, firstly, thanks to all the contributors on this project. We've been using this library for years where I work.
If you don't mind me asking, what's the status for this PR? Has it been abandoned? We're migrating to PHP 7.2 soon and we're worried that phpCAS might be a blocker.

Hey, firstly, thanks to all the contributors on this project. We've been using this library for years where I work.
If you don't mind me asking, what's the status for this PR? Has it been abandoned? We're migrating to PHP 7.2 soon and we're worried that phpCAS might be a blocker. I couldn't find a mention of PHP7+ compatibility in the documentation. If anyone could give me some pointers I'd greatly appreciate.

Hi @doMynation are you experiencing issues in PHP 7.2? Please see #255 because it seems that compatibility issue has been resolved.

Hi @doMynation are you experiencing issues in PHP 7.2? Please see #255 because it seems that compatibility issue has been resolved.

Thank you for the prompt reply. I am not experiencing issues yet, I was mostly wondering (for my own peace of mind) if PHP 7.2 was officially supported.

Rather than maintaining Autoload.php, is there any interest by the project maintainers in moving towards the PSR-4 autoloading convention instead?
If there is, I could give it a shot and it would move the package towards modern PHP community idioms.


char2idx.pickle is not included in the directory

The char2idx.pickle, which is used in 03_preprocessing_musdb_audio_txt_char.py is missing. It is neither found on git or the provided links. It would be super kind of you to provide it! thank you!

Hi! Thanks a lot for pointing this out. I added the file in the 'dicts' folder and updated the path in the script. Don't hesitate to open a new issue if something else does not work. Cheers!

Thank you so much! Also, that paper was excellent, it was well written and I'm super impressed with the creative approach! Keep up the good work!

That's good to hear, thanks!


Details for cross datasets validation on the CARPK dataset

Hi @djukicn, thanks for your excellent work! While trying to follow your experiments, I found the code for cross-dataset validation missing. Could you please provide details about how to perform cross-dataset validation on the CARPK dataset?
You mentioned you used 12 exemplars (pre-cropped images) for all the test images in CARPK, which I guess are the ones provided by the authors of BMNet, I wonder how I could pass the pre-cropped exemplars into your current framework.
I would appreciate it if you could provide the code for it, thanks!

Thanks！ The result is reproducible.