Table 26 (comparison to previous assessment) not working

Chris knows why and will fix.
And next table (percentiles) has NA's - he's on it!

The NAs are caused by different names for quantities in SS 3.30 again, so I'm going to ask Ian for clarification (Issue #358 has 3 of them but there are 3 more):

Quantity
SS 3.24 quantity name

Unfished female spawning biomass (B0,   thousand t)
SSB_Unfished

Yield at B40% (thousand t)
TotYield_Btgt

MSY (thousand t)
TotYield_MSY

Here you go. Sorry for not going through all these things myself.

Quantity
SS 3.24   quantity name
SS 3.30   quantity name

Unfished   female spawning biomass (B0, thousand t)
SSB_Unfished
SSB_Virgin

Yield   at B40% (thousand t)
TotYield_Btgt
Dead_Catch_Btgt

MSY   (thousand t)
TotYield_MSY
Dead_Catch_MSY

Chris - you couldn't have guessed  "Dead_Catch_Btgt"? Come on ...... ;)

We need to run extra.mcmc for last year's base model to get $extra.mcmc$Q_vector for this table
See this around line 690 of tables-parameters.r
    if(q.choice == 1){
      q <- round(median(base.model$extra.mcmc$Q_vector), 3)
    }else{
      q <- round(median(last.yr.base.model$extra.mcmc$Q_vector), 3)
    }

It would be nice if we had a way around having to run the extra.mcmc

Oh wait, it's not used - forget it, problem solved. I just commented it out.

I did this and it's working now in commit a3b433b2d3601f6e26f554046159ecf936a8121f

Got it. I misunderstood that you were talking about last year's values, not this year. I think it totally makes sense to hardwire the value from the previous year and not run the extra-mcmc.


cabal function doesn't aggregate multiple entries of the same type

It would be great if cabal would aggregate multiple specifications of the same field into one (and possibly even filter out duplicates). For example:
λ> let lib = (ghcOptions ["-Wall"] : ghcOptions ["-Wall"] : []) :: [LibraryField]
λ> putStrLn $ renderIndented 0 $ cabal blank lib []
description:

Library
  ghc-options:
      -Wall
  ghc-options:
      -Wall

I'd rather keep a simple and direct correspondence between the Cartel types and what winds up in the generated Cabal text.  The programmer may always do this sort of aggregation herself.  It's only cosmetic; Cabal will aggregate these data fields.


[TASK] Update release scripts to pull latest base docker image

Description
Currently, we are not pulling the latest base images when building docker images and if there are local cache copies available, docker would be using it. This needs to be fixed.
Acceptance Criteria
Make sure release scripts pull the latest base images when building docker images.

Completed.


Add Getting Started section to README

README Update
Please add a__getting started__section to the README so folks know how to start with this project

Added Getting Started section in README file.


Increase Kotlin daemon default memory percentage from 50 to 55

@jstewart5000 since this is configurable via env flag, do we need to change the default here?

@jstewart5000 since this is configurable via env flag, do we need to change the default here?

I can add this as env. variable in our android_preflight.sh if we want to leave the default to 50% here. Let me know what you think.

yeah let's do that 👍


updates

-adds HoP door
-Fixes science->epi entities
-Fixes catalouger door

I don't know if this is something I need to worry about or not?

I'm not sure; both of my PRs are getting the same error. It seems to have something to do with Saltern, which hasn't been touched for ages?? Very confusing


Update inf-validation-errors-and-warnings.md

Added documentation for new universal checks in infverif

This will be live soon, sorry for the delay.  Thanks for the PR @jasminrajan


Unable to type accented characters as participant

After joining a session in VSCode, I'm unable to type accented characters in the editor. Works fine when editing local files.

Product and Version: VSCode 1.49.0-insider
OS Version: Ubuntu 20.04.1 (Linux 5.4.0) x64
Live Share Extension Version: v1.0.2708
Target Platform or Language: Web (HTML, CSS, JS)

Steps to Reproduce / Scenario:

Have your input language set to Brazilian Portuguese.
Join a live share session.
Open any shared file.
Try to type any accented character using accent key + character key combo (e.g., ~ + a).
Nothing happens, ã is not inserted into the file

Note: my input method system is set to XIM.

@daytonellwanger do you know if we allow accented characters while coediting as guest?

@wazybr I'm unable to reproduce this using alt key codes. Are you able to? Can you copy and paste accented characters?

Yes, I'm able to paste. I think the issue only occurs when typing using dedicated accent keys + character keys. AFAIK, those accent keys are specific to some layouts.

Unfortunately I'm not able to reproduce this using the international keyboard with accent keys

Are there any logs I can provide to help with this issue?

@wazybr the most helpful thing would be instructions on how I can reproduce this. How can I set my machine up to mimic yours? As I noted, I tried using the international keyboard with accent keys, and that doesn't have this issue. Also note that this issue may not be highly prioritized since you're the only person to report it so far 😟

Closing this out but if there's instructions on how we can try this out, that would be very helpful! Feel free to re-activate at that time!


Include integration testing against unreleased version

Description
Include integration testing against unreleased version
Issues Resolved
#47
Check List

[ ] New functionality includes testing.

[x] All tests pass

[ ] New functionality has been documented.

[ ] New functionality has documentation added

[x] Commits are signed as per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Codecov Report

Merging #53 (6beb227) into main (4e33131) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main      #53   +/-   ##
=======================================
  Coverage   67.26%   67.26%
=======================================
  Files          31       31
  Lines        1848     1848
=======================================
  Hits         1243     1243
  Misses        499      499
  Partials      106      106

Flag
Coverage Δ

opensearch-cli
67.26% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.


Cross domain issues in webrtc

Which version are you using?
v1.2.0
Which operating system are you using?

[ ] Linux amd64 standard
[ ] Linux amd64 Docker
[ ] Linux arm64 standard
[ ] Linux arm64 Docker
[ ] Linux arm7 standard
[ ] Linux arm7 Docker
[ ] Linux arm6 standard
[ ] Linux arm6 Docker
[x] Windows amd64 standard
[ ] Windows amd64 Docker (WSL backend)
[ ] macOS amd64 standard
[ ] macOS amd64 Docker
[ ] Other (please describe)

Describe the issue
Description
Describe how to replicate the issue

Webrtc public network access can be played through the js provided by mediaMTX, but there are cross domain issues embedded in the video tag that cannot be played. Do you have any solutions to cross domain issues
Did you attach the server logs?

yes / no
Did you attach a network dump?

yes / no

CORS options are in the configuration file. If you still have problems, open another issue and fill correctly all fields as explicitly told in the instructions.


tasks.runTask is missing from Keyboard Shortcuts GUI

Issue Type: Bug

Install Visual Studio Code
Open Keyboard Shortcuts GUI
In search box type: tasks.runtask
Observe that only workbench.action.tasks.reRunTask is listed, however workbench.action.tasks.runTask is missing.

If the user manually adds a shortcut via the JSON editor, then runTask will be listed in the GUI.
  When I introduce them to Visual Studio Code, assigning a keyboard shortcut to runTask is literally one of the first things we do.  This was pretty jarring when I experienced this bug with a client, and makes for a poor first impression.

I can reproduce this.

@alexr00 This is because Keybindings editor does not support showing commands with arguments. Looks like run task command takes a string argument.

Keyboard Shortcuts Editor should show all commands those appear in Command Pallette irrespective of having args or not. Because those commands gets executed without args when triggered from Command Pallette.


Incorrect material texture offset value on KTX2-based compressed GLB import

Hi @hybridherbst @pfcDorn
I'm trying to import a GLB using UnityGLTF. I've the latest version of it installed through a forked repo of mine. I've a GLB which I've compressed using gltf-transform. I've only compressed its textures to KTX2. This same GLB is perfectly working with GLTFast but it's UVs are not mapped correctly with UnityGLTF.
After some research, I found out that this issue is not with UVs import but it is the offset of the textures which was not imported correctly. As shown in pictures below.

I've also attached the GLB. Can you guys please guide me on what should be the possible quick fix for this issue. Really appreciate your response.
Santa_compressed.zip

Hi! Thanks for the test file!
Your are correct, the offset was wrong. Was only correct when there is a TextureTransform extension on it.

 :)


Fix unassign ds req bug

What does this PR (Pull Request) do?

[x] This PR fixes #4151

Which Traffic Control components are affected by this PR?

Traffic Ops

What is the best way to verify this PR?

Attempt to unassign ds request via the payload {id: 4, assigneeId: null}
If this is a bug fix, what versions of Traffic Control are affected?

The following criteria are ALL met by this PR

[x] This PR includes tests OR I have explained why tests are unnecessary
[x] This PR includes documentation OR I have explained why documentation is unnecessary
[x] This PR includes an update to CHANGELOG.md OR such an update is not necessary
[x] This PR includes any and all required license headers
[x] This PR ensures that database migration sequence is correct OR this PR does not include a database migration
[x] This PR DOES NOT FIX A SERIOUS SECURITY VULNERABILITY (see the Apache Software Foundation's security guidelines for details)

Additional Information

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/trafficcontrol-PR/4859/


TODOs on otel go launcher

some items to cover before finalizing launcher PR:

[ ] #423

https://github.com/honeycombio/opentelemetry-go-contrib/pull/400/commits/2b6fbcea1691b10a29fc9d83e542673b953f4f15

[ ] #417
[ ] #418
[ ] #419
[ ] #420
[ ] #421
[ ] #422

Notes:
header parsing might need to be more robust -- string trim, no equals, quoted values?

I think a simple implementation of header parsing is fine to start with. Trimming whitespace, must contains =, etc. I don't think we need to worry too much about quoted values. The OTel SDK only doesn't do that for now too.
Having a default error hander / logger is useful. Otherwise if you fail to parse env vars, or use a vendor package that has validation, you may not see the errors.

these are now tracked in individual issues, with the milestone https://github.com/honeycombio/opentelemetry-go-contrib/milestone/1


Throw an error if the required fields array is not given

Why don't you just tell me why my code is blowing up.

I don't want to throw an error here.

Can I ask why not? The code will not work if you do not pass in fields. At the very least fields should default to an empty array so when .length is called on fields it continues on happily with an empty array (although a validator with no fields is useless and probably a mistake). As a consumer of this code, this error is much more clear than the .length call blowing up because it relies on knowledge of the implementation.

If you switch it to be a console.warn, I will accept the PR


Cannot distinguish long track titles

Track titles like
Suite No. 1 in F major, HWV 348 "Water Music": IV. Andante - Allegro and
Suite No. 1 in F major, HWV 348 "Water Music": V. Passepied
are both displayed as Suite No. 1 in F major, H... and therefore indistinguishable.
I suggest removing the middle instead, to get
Suite No. 1...te - Allegro and Suite No. 1...V. Passepied.

Can't remove the middle. Might be able to scroll the title, but i'm not certain that this should be done everywhere. Where do you think this is most problematic?

I think it is most problematic in the playlist, because this uses narrow columns in landscape mode.
There, much wider columns (or just one column) would help.
On my 1280×720 phone, this also happens in landscape mode in the "remote control". Using two lines might help here. (And of course it happens everywhere in portrait mode.)

Fixed in da90f92ddcb6743249ca0387b88989c7b298524d


bug: cannot delete stored data

Delete button isn't deleting anything may be isn't not working properly

resolved


Typos? token_projection is not refered there.

Such as this line, token_embed will affect the choice of linear, linear_concat and conv.
https://github.com/ZhendongWang6/Uformer/blob/f96302885bb1734857c6f09032f8ddde073b103a/utils/model_utils.py#L64

Thanks. We have fixed it.


Work around gccgo bug (see golang.org/issue/15738)

github.com/golang/protobuf/proto having both internal and external tests
triggers a surprising bug in gccgo. As the bug only affects tests, it seems
reasonable to workaround it by not compiling the internal tests with gccgo.

Ping? My github account got flagged for a while so it's possible notifications for this PR didn't go out.

golang.org/issue/15738 is closed. Is the workaround still needed?

I'm not sure if that fix is in any released version of gccgo yet, but you have a point.


Configure rubygems_url from chef-client cookbook

Cookbook version
8.1
Chef-client version
12.19.36-1
Platform Details
Windows Server 2012 R2
Scenario:
Configure the rubygems_url list setting in the client.rb file from the chef-client cookbook.  This setting was updated in the documentation at https://github.com/chef/chef-web-docs/pull/647.  This would be a great benefit for air-gapped environments that must use an internal rubygems server. There could be an attribute that maps to this setting; such as:
default['chef_client']['rubygems_url'] = 'https://www.rubygems.org'

You can configure the rubygems_url by setting the node.default['chef_client']['config']['rubygems_url'] and including chef-client::config

I've updated the documentation in PR #505 so that this is more clear. @croffe thanks for responding!

The README is updated for this now.


#2875: Line chart, trellis plot: number of selected columns is not updated in properties panel immediately

v1.18.*

[ ] number of selected columns should be updated in opened column selector

Steps to reproduce:

Open a table
Line chart:

add line chart
open its properties
add split columns from the line chart itself, or remove some columns from line chart
check number of columns in properties

Trellis plot:

add trellis plot
open its properties
add X or Y column from the plot itself
check number of X or Y columns in properties

Expected results: number of selected columns in properties should be updated immediately on adding or removing a column.
Actual results: number of selected columns in properties is not updated immediately:

This issue has been mirrored in Jira: https://reddata.atlassian.net/browse/GROK-15828

1.20.0


How to update the apple id credentials associated with fastlane.?

New Issue Checklist

[x] Updated fastlane to the latest version
[x] I read the Contribution Guidelines
[x] I read docs.fastlane.tools
[x] I searched for existing GitHub issues

Issue Description

Command executed

Complete output when running fastlane, including the stack trace and command used

 [REPLACE THIS WITH YOUR INFORMATION]

Environment

 [REPLACE THIS WITH YOUR INFORMATION]

Simply delete the following folder containing any cookies: ~/Users/username/.fastlane


CB-10577: Android resolveLocalFileSystemURL should detect directory

@rakatyal or @riknoll please review
There were two places in the Android file plugin code that didn't do the right thing when resolving a URI whose trailing slash didn't match the directory vs file status.

In LocalFileSystem.toLocalUri(), the returned path should never have a terminating slash if the path does not point to a directory.

In FileUtils.resolveLocalFileSystemUri(), resolving a cdvfile:// (aka "local") URI now converts to native URI and back to a local URI (making use of the change above) in order to force resolution of whether the path points to a file or a directory and fix the terminating slash character accordingly. This is only done for local URIs, because for native URIs the resolveNativeUri() call would already have called toLocalUri() so doing it again would be redundant in that case.

I added automated test cases for resolving native URI files and directories using mismatched trailing slashes. As for cdvfile:// URIs, we currently only have manual test cases for those (at the bottom of tests.js) and they aren't very thorough. I manually tested this fix with cdvfile:// URIs.

LGTM

LGTM.


Any client crash while having a presence on will result in a crash loop

The crash loop starts with Discord now, even without a browser open.

Forgot to comment, seemed to be a Ubuntu-only issue (Ubuntu 21.10 x86_64 to be specific) because it was able to run fine on Windows. It fixed itself after a new Ubuntu update I got today. You can close this now, sorry for the inconvenience.


Azure AD Joined VM troubleshooting required

This needs updating for Azure AD joined VMs as we're having this issue with Azure Virtual Desktop when trying to log in with Azure AD credentials

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 377e7e7f-c07e-3c69-06b2-49af12f83cc3
Version Independent ID: 71b277ef-9f51-c926-f5cf-f41fce49b845
Content: Troubleshoot authentication errors when you use RDP to connect to Azure VM - Virtual Machines
Content Source: support/azure/virtual-machines/cannot-connect-rdp-azure-vm.md
Service: virtual-machines
GitHub Login: @genlin
Microsoft Alias: genli

@OffColour, Thanks for your comments. We will consider adding the topic about AAD joined VMs. If you still have issue with RDP, I suggest you contact Azure support to resolve the issue quickly.


Feature request: print unique random tags

I've come across your Docker image. It's very handy.
A feature request:
All the messages currently consist of very common words, and the entire sentence is fixed and repeated. When they are mixed with tons of other applications' logs in a data lake (e.g., in Elasticsearch, Datadog, Splunk, etc.), it is very hard to query for a particular message from your running container.
So, why not append each message with a dynamically generated random string -- each log line has a different, unique string. That will give the best of both worlds:

You can query for the fixed part of your current message in order to get all messages from your particular container.
You can also query for that random string to pinpoint a particular occurrence of a message.

Thank you for your interest, this sounds like a interesting feature to implement. if I understand correctly it would be nice to have something like this:
2018-03-02T22:33:27-06:00 ERROR <random-string>
2018-03-02T22:33:27-06:00 INFO <random-string>
2018-03-02T22:33:27-06:00 WARN <random-string>
2018-03-02T22:33:27-06:00 DEBUG <random-string>


Don't always connect to localhost in rails 3.1

redis_server is a redis URI which should be passed to the factory. The current implementation does not correctly parse the URI into redis client connect options, resulting in always connecting to localhost in the redis client.
The correct behaviour is present in prior commits, broken in last change to this file. This resolves that issue.

It looks like what happened is with Rails 3.1, the options passed to the session store initializer changed.  Previously, as you can see in RedisStore::Rack::Session::Rails, initialize took host, port, and db options.  With Rails 3.1, at least from what I can tell by looking at Rack::Session::Memcache, the new mechanism for setting the server is :memcache_server.
So, in my instance, this is working as expected.  I'm setting host, port, and db in the session_store initializer.  I had no idea this had changed until I noticed your pull request.  I'm not sure how to gracefully handle this -- and if I change to the new mechanism of :redis_server, my current production environment will break.

I'm not sure why this was changed to redis_server myself. It appears to have happened in a previous commit.
I will update the code to gracefully fallback to the host/port mechanism. As is, the existing branch head is broken (i.e. the redis_server option that is present does nothing).


Limit Orders/Stop-loss Support?

This project is great! Was wondering if there is any plan to add support for limit orders and stop-loss settings. Unless I am missing something, I only see the the possibility of placing market orders.

Hi David, there’s no active plans to implement any new features, though I’d be happy to review and approve pull requests from others!

I don't think this would be hard to do, but it would help us save time if you gave us a clue how you obtained those api urls.
I don't see them used anywhere else, that I can see. I haven't been able to find them in either the web source code or by capturing the mobile app traffic.

I am also very curious where these urls came from. It would help so much to be able to see some requests for different scenarios.
I figured out how to enter limit orders with some trial and error, but they fail if the limit is marketable (i.e. above ask for buy and below bid for sell). In the web interface, if the limit is marketable, it asks for a confirmation to be sure that's what you intended, so I presume the api also needs some verification key:value in the post to urls.order_confirmation(). I've tried a few things similar to the key:value that is passed in the browser trade interface ("OrderAffrmIn": True), but no luck.
Trades also fail if confirmation is needed for other reasons. For example, commodity related products (even basic ETFs like GLDM) require acknowledgement of the risks and therefore cannot be purchased with this package.

From what I recall, the APIs that I call in this library were publicly available through sniffing network requests on the website. If these requests are no longer visible, my guess is that Schwab stopped using these APIs on the client-side web app (even though the APIs remain functional).
I don't quite have as much time anymore to work on this, but I imagine there must be some API that's being called on the website, even if its a new URL.

Thanks for responding Jafer
The current web interface appears to be using ausgateway.schwab.com instead of client.schwab.com, and the requests look very different. I've tried replicating those requests, but haven't gotten anywhere (I'm remembering that everything was rejected by the server).
I was hoping you knew of some older url that was still accessible from a browser for entering orders with client.schwab.com, but thanks for clarifying that's not the case.

An update on this, I've managed to replicate the "new" requests and get past authorization errors. At a cursory glance, I believe adding this feature support would be straightforward and I'll do my best to document the API request/response so that you all can contribute features going forward!

That's great news!

Excellent! I look forward to seeing that, even if you only implement a few things. Assuming we just need to replicate what the web interface does, I should be able to add more to it.

Hi! I pushed version 0.3.0, which features a trade_v2() function. For now, I've hard coded it as a day only market order, but if you take a look, it is very simple to add limit orders and stop loss.
Please feel free to send me a PR to add the functionality if you're open to testing it!

Quick update, version 0.3.2 has Limit order and Stop loss order support, but will still require some investigation on your part to figure out the Schwab enum code mappings.


LEFT OUTER JOIN resolves to LEFT JOIN

Left outer join should provide only the data that does not have a match to the right table. Instead this seems to resolve to a left join.
import pandas as pd
from pandasql import PandaSQL

df_a = pd.DataFrame({'test': pd.Series([1., 2., 3., 4.])})
df_b = pd.DataFrame({'test': pd.Series([1., 2., 3.])})

pdsql = PandaSQL()
joined_df = pdsql("SELECT a.* FROM df_a a LEFT OUTER JOIN df_b b on a.test = b.test")
print(joined_df)

Outputs:
   test
0   1.0
1   2.0
2   3.0
3   4.0

Expected Output:
   test
3   4.0

@dreyco676 In SQL 'LEFT OUTER JOIN' and 'LEFT JOIN' is the same command, it's just 'OUTER' word often gets omitted.

You seem to be confusing INNER and OUTER. INNER JOIN will resolve to JOIN. Likewise LEFT INNER JOIN would resolve to LEFT JOIN.
LEFT OUTER JOIN is illustrated on this page and is not equivalent to LEFT JOIN:
http://blog.codinghorror.com/a-visual-explanation-of-sql-joins/

Crap you're right. According to this I forgot the WHERE clause.
http://blog.codinghorror.com/a-visual-explanation-of-sql-joins/


[BUG] RKRequest not retained

Hi all,
I'm using Xcode 4.2 with ARC enabled.
How to recreate the bug:

create a RKRequest and set a delegate

Send the request

done! the delegates methods will be never fired because ARC is freeing the request before (probably because it is not retained)!
if I declare a reference in the header of my view controller and I store the RKRequest there the delegates methods are fired!
That because I'm manually retaining the object.

Since you didn't provide any code to show what's going on, I'm going off a few assumptions.  But really, this isn't a bug because you're supposed to retain it yourself for the exact reasons you've outlined.  Moreover, the RestKit project isn't ARC-enabled yet.  That's on our TODO list.


Fix init

@jeff-regier I'm still waiting for the Travis tests, but if they pass, this should fix your problem, so I'm making the PR before going to my next meeting.

The tabs are fixed.


Turns off interpolation per default

As discussed in #6598, this MR turns off the interpolation by default.
This follows the idea behind #5939 to avoid potentially misleading charts per default.

This isn't being set in the right place. You can see by doing gulp build and then opening up the samples in the samples directory. They still have bezier curves on

It looks like it's set here: https://github.com/chartjs/Chart.js/blob/cfb5fba527cd93b596329fb05079e320b6586701/src/elements/element.line.js#L25

I think there are some tests that need to be updated. Hopefully that's not too hard

This isn't being set in the right place. You can see by doing gulp build and then opening up the samples in the samples directory. They still have bezier curves on

Thanks a lot for pointing this out 😃 I have just checked it and now its looking as intended.

I think there are some tests that need to be updated. Hopefully that's not too hard

Is this due to some pixel-based render testing? I am not really sure how to update this, and whether I can do it in a way for you to review it later on.

Yeah, it looks like most (or maybe all) are due to pixel matching. If you run the tests locally with gulp test --watch it will show the failing tests with the expected and actual images. You can save the actual in place of the expected and the test will start passing. We'll see the image diff in the PR. I don't know if there's a better way to update than clicking "Save as..." one-at-a-time on each. Maybe you could code a mode that automatically overwrites images for failing tests or for all tests. Not sure if that's faster or slower than the one-at-a-time method :-)

Not sure if this previously occurred. In order to run the tests, I also hat to add babel-eslint and eslint-plugin-import to the package.json. Otherwise, I would get some missing package errors.

Only thing that stood out is test/fixtures/controller.line/fill/order-default.png where the old test appears to have part of the line bleed through the green fill.

This also surprised me. Wasn't expecting this to be influenced by lineTension.

yarn.lock should be removed. If the new packages are needed, package-lock.json should be updated

Done

We should add a note about the default change the v3 migration docs

Is this also missing for beginAtZero?

For that image I suspect the issue was likely a bad initial image (we have a small tolerance for the comparisons because sometimes things shift a bit based on browser implementation) so i wouldn't worry about it.
It might be missing for beginAtZero as well. If so, I would support adding it (perhaps a new heading in that document for default config changes)

Thanks for this!
I would update the migration guide and elements config page
Also https://www.chartjs.org/docs/master/general/performance#automatic-data-decimation-during-draw says:

tension is 0, stepped is false (default) and borderDash is [] (default).`

You could change this now to state that these are all the default values. Also, it looks like maybe there's a stray backtick at the end of that sentence? Mind fixing while you're at it?

Looks like this needs a rebase.

@sebiniemann have you had a chance to look at the rebase for this? I'd love to get it in

Not yet, will look into it over the weekend

Should be fine now. Had chosen the wrong base branch.

We are developing in master (or 2.9), release branches are for release tooling.

I changed the base back to master since that's where dev code goes.

@sebiniemann sorry, but would you be able to rebase this PR? I think if you do that and add a note to the migration guide that should be about it before we can merge this unless @kurkle has any additional thoughts
Thanks again for this PR!

@etimberg
I am currently afk and only had enough time for the merge, resolving conflicts and new test screenshots.
If you want to merge soon, I can also open an new PR for the migration guide (and also adding a note about beginAtZero).

Agreed, I will send a PR fixing the docs after merging this


Translation added

Hi,
Here are the modifications that allow to have generalized translation.
I tested that everything seem to work (including on fqhe type of translations, examples not included here).
It is nonetheless not impossible that I missed something. There are a lot of small functions that assume some basic properties on the translation operator.
I am available for discussions, and of course all names can be changed.

Thanks for this! Definitely a pretty involved change to make, I guess it was quite ingrained in the code.
Glad to hear it works for FQHE-type calculations. We are interested in doing DMRG and VUMPS calculations on systems like that so I would definitely be interested in hearing about your experience and it's very helpful that you are pushing the code in that direction!
I have two comments about the notation:

What about translator instead of translater, since translater isn't a real word? I was considering something like translation_function but translator is nice and succinct.
I noticed the default function is still called translatecell. Maybe to distinguish it more from the general case we could call it translatecelltags? That emphasizes that it only translates the tags, instead of something more general. I'm talking about functions like:

function translatecell(ts::TagSet, n::Integer)
  ncell = getcell(ts)
  if isnothing(ncell)
    return ts
  end
  return replacetags(ts, celltags(ncell) => celltags(ncell + n))
end

function translatecell(i::Index, n::Integer)
  ts = tags(i)
  translated_ts = translatecell(ts, n)
  return replacetags(i, ts => translated_ts)
end

There was a lot of little changes to make. Nothing too bad, but it is easy to miss things.
1 -  Concerning the name: seems fine by me. Translater is a bastardized frenchified version, as translator translates in a different way. I will update that.
2 - Probably indeed better to avoid confusion on some pieces of the code.
So far, due to the symmetries (two site updates and expansion are not enough to be "ergodic"), I have some difficulties making VUMPS work on FQHE states. More precisely, there are still some issues with the subspace expansion steps.
I implemented a working adaptable iDMRG that is able to treat the FQHE states, and I will go back to VUMPS in a few days using this code as a basis to deal with dangling legs. In particular the unitarity constraint is harder to satisfy (one wants to add too many legs in order to guarantee a successful expansion), so having a few steps of n-site iDMRG at the beginning just to leave the product-state "manifold" might be required.
Except from that, the code work with the symmetries of the FQHE, so a temporary solution would be alternating iDMRG steps to generate the correct MPS links, and VUMPS steps for convergence.
Did you have any plan to include iDMRG codes in the package?

Interesting, yes I was wondering if the current subspace expansion would work with FQHE Hamiltonians.
I remember hearing that you need to use a 3-site update in DMRG/iDMRG for FQHE Hamiltonians or else it gets stuck ("non-ergodic" as you put it). Could it just be a matter of generalizing the subspace expansion to 3-sites? If so, that would be a relatively easy fix.
I would consider adding iDMRG, but I was hoping that VUMPS would be sufficient for most, if not all, use cases (with the advantage that it should be faster in general). In general it would be nicer to just maintain one algorithm/code. Of course, iDMRG is better tested and more widely used in general, with a long history of improvements to the algorithm, so VUMPS is less "battle tested" and may have corner cases like the FQHE that need to be worked out. However, if you already have a working version of iDMRG, it would be great to have, at the very least as a reference to check the performance and accuracy of VUMPS.

It does not work, and it is pretty simple to see: if you start from a product state, the non-physical legs of the two-site Hamiltonian entirely fix all quantum number within the two sites, such that no new subspace is generated/the local Hamiltonian is block-diagonal.
From what I have seen, even three sites can get stuck easily. I do not have any proof of that, but as an example, I have worked on a minimal model in a completely different context of the form c^d_1 c_2 c_3 c^d_4 (the first hopping which respect the FQHE symmetry). This model undergoes Hilbert space fragmentation.
In the 2012 paper of Mike Zaletel and Frank Pollmann, they had to go to 6 to 8-site DMRG for complex states (Pfaffian, 1/5, 2/5 etc...).
On paper it should not be too hard, but it seems to have some instabilities that I have not be fully able to solve. I need to go back to it.
In particular, left/right unitarity is extremely easy to break, especially if one goes to larger cylinders/bigger spheres. If it is broken, then VUMPS does not converge well.
My iDMRG code is pretty non-efficient (it has some "useless" features for my use case/that I did not bother improving) , but I can add it at some point for debugging purposes. The FQHE is also a good test bed for mixers/noise generators.

Yes, I think there are some interesting questions here, and it is an open research problem to come up with one good, efficient subspace expansion technique that can cover many cases, especially these tricky ones like FQHE. It may end up that there are tradeoffs in terms of performance and reliability and we will need to provide a variety of options which users will need to try in challenging cases. Having iTEBD and iDMRG implementations could fall into that category, for example I've heard a good way to run TDVP is by first running TEBD for some time to expand the bond dimension and then switch to TDVP (for example that is what is used here: https://arxiv.org/pdf/2009.10736.pdf). There are also global Krylov methods people have tried (https://arxiv.org/pdf/2005.06104.pdf) which could be adapted to the infinite case.
Interesting to hear about the polar decomposition issue. We can also use a positive QR decomposition (a QR decomposition with the diagonal of R fixed to positive) as an alternative if the polar fails.
By "mixer" do you mean the subspace expansion technique introduced in: https://arxiv.org/abs/1501.05504? I was wondering if that technique could be adapted to the translational invariant case but I didn't figure out how to do it.
It seems like the easiest thing to try for now is generalizing the current subspace expansion method in the VUMPS code to n-sites and see if that fixes most of the issues, and then investigate other options if not.

I guess the major change were #55 and #56.
There are now 3 versions of VUMPS:

InfiniteSum{ITensor}: The old version of VUMPS in terms of an infinite sum of ITensors, only works with 2-local Hamiltonians. Brought back in #55 mostly to try to debug the performance issues of InfiniteSum{MPO} but we probably should get rid of it again once we are sure InfiniteSum{MPO} works well.
InfiniteSum{MPO}: Your general version of VUMPS in terms of an infinite sum of MPOs. We saw performance issues with this version, but they were fixed in #56.
3.InfiniteMPOMatrix: Your version of VUMPS written in terms of a single infinite MPO.

Which version are you seeing issues with? We have someone who I believe is using versions 1. and 2. and hasn't reported any issues, but he is just using a 2-site unit cell with a 2-local Hamiltonian.

I was indeed talking about the third version.
Maybe a change in the dependencies then.
The test in the norm AL AL...C - C AR AR... is no longer passing.

By the way, could you specify the exact test you did to check for the regression ?
I guess it is part of the file examples/vumps/vumps_hubbard_extended.jl ? Or the full file?

EDIT: I fixed the problem, it was my fault mainly.
Do you want me to reinstate the multisite version of VUMPS using local Hamiltonians accessible here
We can put an if close such that it uses the current version when the Hamiltonian is two-local

Glad you figured out the problem.
I think I would rather just drop version 1. (InfiniteSum{ITensor}) entirely if possible in favor of 2. (InfiniteSum{MPO}) and 3. (InfiniteMPOMatrix), at least eventually. Is there any advantage of the version you link to above over the current InfiniteSum{MPO} we have already? If not I would say no, if anything we should be reducing the number of version of VUMPS that we have.
In fact I would hope that eventually InfiniteMPO/InfiniteMPOMatrix could supersede InfiniteSum{MPO} once we have a good AutoMPO-like system for infinite MPOs, like how for DMRG we only have an MPO version (though it is written generically so that in principle you can input any Hamiltonian representation that you want to).

By the way, could you specify the exact test you did to check for the regression ? I guess it is part of the file examples/vumps/vumps_hubbard_extended.jl ? Or the full file?

You mean the performance regression fixed in #56? That I was testing by running https://github.com/ITensor/ITensorInfiniteMPS.jl/blob/main/examples/vumps/vumps_hubbard_extended.jl.

Glad you figured out the problem.
I think I would rather just drop version 1. (InfiniteSum{ITensor}) entirely if possible in favor of 2. (InfiniteSum{MPO}) and 3. (InfiniteMPOMatrix), at least eventually. Is there any advantage of the version you link to above over the current InfiniteSum{MPO} we have already? If not I would say no, if anything we should be reducing the number of version of VUMPS that we have.
In fact I would hope that eventually InfiniteMPO/InfiniteMPOMatrix could supersede InfiniteSum{MPO} once we have a good AutoMPO-like system for infinite MPOs, like how for DMRG we only have an MPO version (though it is written generically so that in principle you can input any Hamiltonian representation that you want to).

Depending on the bond dimension of the MPO, I suspect the InfiniteSum{ITensor} is better than the InfiniteSum{MPO}. Not necessarily by much though.

Yeah, I imagine the difference won't be too much. In #56 for 2-local interactions I saw the time was nearly the same. I imagine the MPO version should be better for non-local interactions, which as you know was the point of implementing it in the first place. I'm not sure if it is worth keeping around both implementations since as we see already it is a challenge supporting many different versions (each can have their own bugs, performance optimizations, etc.).

@LHerviou is this ready to merge?

Ok, sounds good! Is the main reason it would not be fully functional because of the subspace expansion?

Exactly.
I had a prototype for the subspace expansion, but it was still failing. Following some playing with iDMRG (the subspace expansion is very close to doing one step of iDMRG after all), I might have an idea to help with that.
From memory, one of the key problems was that after expansion, AL... C - C AR... start to be very far from 0.
Another limitation was that it was hard (i.e. required really large bond dimensions and steps) to get a non-trivial, coherent expansion.

Interesting, thanks for the update. There are definitely some open questions remaining about how to best do subspace expansion for a variety of problems, and FQHE sounds particularly challenging. We will be adding some subspace expansion techniques to our finite TDVP code (https://github.com/ITensor/ITensorTDVP.jl). One of them will be essentially the same as the one from this package (with the goal of sharing the implementation as much as possible), and we will also add an implementation of the technique from this paper, however we will be exploring some new ones which would hopefully help with FQHE VUMPS as well.
Let me know how your experiments go, using iDMRG for subspace expansion sounds hopeful. Perhaps once your and our experiments get a bit farther along we can meet to discuss the different subspace expansion options. I'm hoping that our VUMPS/TDVP packages and the wider community can converge on one good subspace expansion technique that could work for a variety of techniques and problems (VUMPS, single-site DMRG, TDVP, FQHE, ladder systems, etc.) but that may be challenging since there will likely be tradeoffs between how robust the expansion is and how expensive it is.

If the tests are passing as on my computer, this is ready to ship.

Looks like the last test is taking a long time to run for some reason.
I'll go ahead and merge this. Thanks @LHerviou!


update docker README instructions with waypoint

Instructions weren't working because they forgot to include the required
waypoint info for the CLI.  This adds information on how to look that
up, general markdown cleanup, and some spelling mistake cleanup.

@bors-libra r=davidiw

:pushpin: Commit 707615c has been approved by davidiw

:hourglass: Testing commit 707615ce18aea10d6c15e257d565f91e607681f0 with merge a1c0cdd4b2136936f08ec56f46c7d6f2fc35c66a...

:sunny: Test successful - checks-actions_land_blocking_test, checks-circle_commit_workflow
Approved by: davidiw
Pushing a1c0cdd4b2136936f08ec56f46c7d6f2fc35c66a to master...


Problem on react-native project using flurry

I have a project react-native with Flurry but I cant to build this project..
The flurry is add on PodFile.
PodFile is on Linked Frameworks & Libraries.
Follow error:

PodFile

Linked Frameworks & Libraries

Hi. Sorry to hear that you're having issues with Flurry. Could you please provide more information like

Are you using react-native-flurry-sdk?
Did you run react-native link react-native-flurry-sdk and pod install?
How is React integrated in your project? CocoaPods or react-native init?

Also please make sure that

You are using the xcworkspace instead of xcodeproj
You can see Flurry-iOS-SDK under Pods directory
Pods directory is in the search paths of your project
The latest version of Flurry SDK (9.0.0) is suggested. A lower version may cause other problems in React Native projects

Fix this after delete "Pods" folder and run pod install.


Packages of 0.2.7-beta upwards specify exact versions of their dependencies

vs

I think this might prevent users from upgrading to a new hotfix of Npgsql for instance. Additionally, do we need the direct dependencies on FSharp.Core and System.ValueTuple?
@Swoorup

Ah this should probably be an easy fix.
The reason this came about was because I convert from nuget to paket using paket convert-from-nuget command, which puts the discovered dependencies into paket.dependencies. And locks the dependencies to the found version.
https://github.com/demetrixbio/FSharp.Data.Npgsql/blob/master/paket.dependencies
Should probably be able to remove FSharp and ValueTuple and change the others to greater than match.

Fixed in https://github.com/demetrixbio/FSharp.Data.Npgsql/pull/86


enable loading remote hdf5 files

Enable loading remote hdf5 files. Will require h5py>2.9.0 and some changes to https://github.com/shoyer/h5netcdf. I've current just made a quick hack change to backends/api.py, so further tests are needed. Pinging @jhamman, @mrocklin, and @rabernat for thoughts on this.
Here is a short notebook demonstrating how this works:
https://gist.github.com/scottyhq/790bf19c7811b5c6243ce37aae252ca1

[x] Closes #2781
[x] Tests added
[x] Fully documented, including whats-new.rst for all changes and api.rst for new API

I'm glad to see this.  I'll also be curious to see what the performance will look like.
cc @llllllllll

This looks great!
I'll note one minor extension: you could look at the first few bytes of the file (the "magic number") to determine if it's a netCDF3 or netCDF4 file, and hence whether it can be opened with scipy or h5netcdf:

CDF\001 or CDF\002 would indicate netCDF3 (use scipy)
\211HDF\r\n\032\n would indicate netCDF4/HDF5 (use h5netcdf)

@shoyer , it would be great to have your feedback on these recent changes now that h5netcdf 0.7 is out. There's a bit more logic required in api.py now that scipy isn't the only backend that is able to read file-like objects (and people may not specify engine= when opening datasets)
test_backends.py passes locally for me except for TestValidateAttrs.test_validating_attrs... not sure why.
Also, per your comment here: https://github.com/shoyer/h5netcdf/pull/51#issuecomment-467591446, I think it would be great to get a few small netcdf4/hdf test files in https://github.com/pydata/xarray-data.

Hello @scottyhq! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

In the file xarray/tests/__init__.py:

Line 85:17: E126 continuation line over-indented for hanging indent

I don't think it's essential to have an integration test doing real network
access in xarray, so I would consider just dropping that part instead.
On Tue, Mar 5, 2019 at 6:10 PM Ryan Abernathey<EMAIL_ADDRESS>wrote:

@rabernat commented on this pull request.
In xarray/tests/test_backends.py
https://github.com/pydata/xarray/pull/2782#discussion_r262767473:

@@ -1955,6 +1955,39 @@ def test_dump_encodings_h5py(self):
assert actual.x.encoding['compression_opts'] is None

+@requires_h5fileobj
+class TestH5NetCDFFileObject(TestH5NetCDFData):

h5py = pytest.importorskip('h5py', minversion='2.9.0')

engine = 'h5netcdf'

@network

def test_h5remote(self):

   # alternative: http://era5-pds.s3.amazonaws.com/2008/01/main.nc

   import requests

   url = ('https://www.unidata.ucar.edu/'

          'software/netcdf/examples/test_hgroups.nc')

Rather than going over the network, it might be quite easy to fire up a
http.server.SimpleHTTPRequestHandler
https://docs.python.org/3/library/http.server.html#http.server.SimpleHTTPRequestHandler
as part of a fixture. This would allow us to test the remote capability
without internet (and without depending on a third party to host a file.)
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/pydata/xarray/pull/2782#pullrequestreview-211014423,
or mute the thread
https://github.com/notifications/unsubscribe-auth/ABKS1puGwIDrvG3NGvfq5oXqwdtbHSIDks5vTyOkgaJpZM4bGMFq
.

thanks for the input @shoyer, i attempted to tidy up a bit and in the process re-ordered some things such as adding an 'engine' check at the top of open_dataset(). backend tests are passing locally on my machine. hopefully i didn't add too much here or overstep!

@scottyhq - can you add note to the what's new page?
From what I can tell, I don't think the failing tests are related to this PR.

I think we're good here. I made one minor tweak to the windows fix @scottyhq implemented. I plan to merge this on Monday if I don't hear any objections.

thanks @scottyhq !


IMU - roll can fluctuate between 10 degree difference. Is that normal?

Required Info

Camera Model
D435i

Firmware Version
5.14.0

Operating System & Version
Ubuntu 20.04

Platform
Laptop

ROS Version
Noetic

Language
{ROS, Python}

I run this imu filter madgwick (roslaunch imu_filter_madgwick imu_filter_madgwick.launch ) and convert them quaternion_to_euler: roll, pitch yaw.
The realsense camera sensor is mounted on a static place (no motion), but the roll value fluctuated a lot, it showed between 30 degree to 40 degree. The gap is like 10 degrees. Is that normal?
Thanks a lot for your help. :)

Hi @ok-kewei  Raw RealSense IMU data can be sensitive to change and 'noisy'.
The IMU can be calibrated using the Python tool at the link below.
https://github.com/IntelRealSense/librealsense/tree/master/tools/rs-imu-calibration
https://www.intelrealsense.com/wp-content/uploads/2020/07/IMU_Calibration_Tool_for_Intel_RealSense-Depth_Cameras_Whitepaper.pdf

ok, got it. Thanks. :)

Hi @ok-kewei  Do you require further assistance with this case, please?  Thanks!

Hi @MartyG-RealSense, thanks for your reply. You may close the case. :)

You are very welcome, @ok-kewei - thanks very much for the update!


build: auto update

This builds on https://github.com/LN-Zap/zap-desktop/pull/599 and adds support for auto updates using electron-updater.
I've tested this locally using the following steps:
Install minio
Minio is a private cloud storage solution with an API that is compatible with AWS. We use it to host update files that we will make available to electron-updater.
brew install minio/stable/minio

See https://www.minio.io/ for info about Mino.
Create minio data dir and test bucket
mkdir -p ~/minio-data/test-update

Start minio server
minio server ~/minio-data

Make bucket public
Open up the minio web UI and add a READ policy on the test-update bucket

Build and package the app to the minio bucket
Replace [YOUR_KEY] and [YOUR_SECRET] with your own keys from Minio.
DEBUG=electron-builder \
AWS_ACCESS_KEY_ID=[YOUR_KEY] \
AWS_SECRET_ACCESS_KEY=[YOUR_SECRET] \
yarn package \
--config.compression=store \
--config.publish.provider=s3 \
--config.publish.endpoint=http://<IP_ADDRESS>:9000 \
--config.publish.bucket=test-update \
--publish always

Backup update feed files so that we can use later for testing update process
cd ~/minio-data/test-update/
cp beta-mac.yml beta-mac.yml-LATEST

Downgrade the app version
vi package.json
vi app/package.json

Rebuild the app
Replace [YOUR_KEY] and [YOUR_SECRET] with your own keys from Minio.
DEBUG=electron-builder \
AWS_ACCESS_KEY_ID=[YOUR_KEY] \
AWS_SECRET_ACCESS_KEY=[YOUR_SECRET] \
yarn package \
--config.compression=store \
--config.publish.provider=s3 \
--config.publish.endpoint=http://<IP_ADDRESS>:9000 \
--config.publish.bucket=test-update \
--publish always

Replace update feed with newer version from first build
cd ~/minio-data/test-update/
cp beta-mac.yml-LATEST beta-mac.yml

Run packaged app with logging enabled
DEBUG=zap* DEBUG_LEVEL=debug release/mac/ZapDesktop.app/Contents/MacOS/ZapDesktop

... It will check for updates when the app is started. It will also check every hour thereafter. If an update is found it will be downloaded and installed automatically and you should be presented with an option to either restart the app now or later.

This can be improved later by adding progress indicators, menu items to check for updates manually, a nicer ui etc.

Pull Request Test Coverage Report for Build 1130

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage increased (+29.0%) to 63.636%

Totals

Change from base Build 1119:
29.0%

Covered Lines:
5

Relevant Lines:
7

💛  - Coveralls

utACK b5d70fa

Tested ACK b5d70fa 🎊


Limitations about ROS drivers for KUKA iiwa robot

The current interface for real-time control is called in the new Sunrise controller: Connectivity.
This one is divided to 2 main packages :

Soft real-time control (2ms --> 20 ms): Connectivity.SmartServo (used by IFL-CAMP/iiwa_stack)
Hard real-time control (1ms --> 4ms ): Connectivity.FRI 2.0 (Successor of FRI 1.0) will be there from November 2014 onward. (used by ahundt/grl)
—— From Kuka LBR iiwa - Realtime Control Interface

Reference

Kuka LBR iiwa - Realtime Control Interface
Stop using the KONI Ethernet interface #7
collaboration with grl #1
Position Control using ROS #152
V. Chawda and G. Niemeyer, “Toward torque control of a KUKA LBR IIWA for physical human-robot interaction,” in 2017 IEEE/RSJ International Conference on Intelligent Robots and Systems (IROS), 2017, pp. 6387–6392.
Sending command/JointTorque to the robot #47
ahundt/grl - Implements soft real time arm drivers for Kuka LBR iiwa
IFL-CAMP/iiwa_stack - ROS Indigo/Kinetic metapackage for the KUKA LBR IIWA R800/R820

wrong ttd
We use the TimeToDestinationService to get the time about the excutation, but the result seems not correct.
We need a script to test it.

TimeoutAfterGoalReach
Depending on our iiwa_stack version, when switching between different control mode, the setTimeoutAfterGoalReach will be called and then the controller will last such time to work. But if you just update the parameters of the current control mode, it will not work, because of the current iiwa_stack implement.

Switch control mode caused exception
Reference

PositionHold for compliant control mode

Plan to use grl and iiwa_stack
Difference

iiwa_stack is well documented, but some problems can't be solved by current version.
our sunrise os is 1.7, but the grl only support higher versions.

Why?

Teaching and Demonstration using KUKA LBR iiwa

HandGuiding mode
gravity compensation mode (joint impedance mode)

Control Robot with kuka-isir/rtt_lwr

Simple joint position control in joint stiffness mode #8


Create bths

for Tech!

@KenWayTheGod lib/domains/edu/bths: this request has an incorrect file path format, please ensure that you are familiar with     this repository rules located at the bottom of this page and change     your request accordingly. If you don't know how to change request, close it and open a new one.     If you are not able to make the pull request according the instructions, please send us an email to<EMAIL_ADDRESS>Please mention this request URL in the message.

@KenWayTheGod lib/domains/edu/bths: this request has an incorrect file path format, please ensure that you are familiar with     this repository rules located at the bottom of this page and change     your request accordingly. If you don't know how to change request, close it and open a new one.     If you are not able to make the pull request according the instructions, please send us an email to<EMAIL_ADDRESS>Please mention this request URL in the message.

@KenWayTheGod lib/domains/edu/bths: this request has an incorrect file path format, please ensure that you are familiar with     this repository rules located at the bottom of this page and change     your request accordingly. If you don't know how to change request, close it and open a new one.     If you are not able to make the pull request according the instructions, please send us an email to<EMAIL_ADDRESS>Please mention this request URL in the message.

@KenWayTheGod lib/domains/edu/bths: this request has an incorrect file path format, please ensure that you are familiar with     this repository rules located at the bottom of this page and change     your request accordingly. If you don't know how to change request, close it and open a new one.     If you are not able to make the pull request according the instructions, please send us an email to<EMAIL_ADDRESS>Please mention this request URL in the message.

@KenWayTheGod lib/domains/edu/bths: this request has an incorrect file path format, please ensure that you are familiar with     this repository rules located at the bottom of this page and change     your request accordingly. If you don't know how to change request, close it and open a new one.     If you are not able to make the pull request according the instructions, please send us an email to<EMAIL_ADDRESS>Please mention this request URL in the message.

@KenWayTheGod Pull request merged. Thank you! However you did not name the file in the request correctly, thus I'll do it for you in about two hours. Please wait at least two hours after this message is sent, before start requesting the licenses at https://jetbrains.com/student.


Hide backtrace from stderr files

fixes #2853
seems not very important to test in this detail. I could try to keep a few lines at the start around so we know what's going on (they should be fairly reliable)

@bors r+

:pushpin: Commit e55f7d92031e4dae719662369069e8660b848c26 has been approved by oli-obk
It is now in the queue for this repository.

:hourglass: Testing commit e55f7d92031e4dae719662369069e8660b848c26 with merge e46eb2eb685aa5de50a2c853990b2799a5957a91...


Errors compiling to the HL/C target (medium term issue)

In attempting to see if issue #120 would go faster if compiled, I tried to compile to HL/C, but had errors:
% haxe -lib go2hx -cp golibs --hl c/issue120.c  -m Main
Code generated in c/issue120.c automatic native compilation not yet implemented

% cd c

% gcc -O3 -o issue120 -std=c11  issue120.c -I . -I /Users/elliottstoneham/code/haxe/hashlink-1.12/src -lhl -L /usr/local/lib  -arch x86_64
n file included from issue120.c:29:
In file included from ./stdgo/reflect/Value.c:7:
./stdgo/reflect/_Reflect/Reflect_Fields_.h:86:6: error: cannot combine with previous 'int' declaration specifier
        int bool;
            ^
/Library/Developer/CommandLineTools/usr/lib/clang/13.1.6/include/stdbool.h:15:14: note: expanded from macro 'bool'
#define bool _Bool
             ^
In file included from issue120.c:29:
In file included from ./stdgo/reflect/Value.c:7:
./stdgo/reflect/_Reflect/Reflect_Fields_.h:86:2: warning: declaration does not declare anything [-Wmissing-declarations]
        int bool;
        ^~~~~~~~
./stdgo/reflect/_Reflect/Reflect_Fields_.h:87:6: error: duplicate member '_int'
        int _int;
            ^
./stdgo/reflect/_Reflect/Reflect_Fields_.h:60:6: note: previous declaration is here
        int _int;
            ^
./stdgo/reflect/_Reflect/Reflect_Fields_.h:110:6: error: duplicate member '_struct'
        int _struct;
            ^
./stdgo/reflect/_Reflect/Reflect_Fields_.h:83:6: note: previous declaration is here
        int _struct;
            ^
In file included from issue120.c:79:
./stdgo/reflect/_Type.c:450:15: error: expected identifier
                                        r4 = r8->bool;
                                                 ^
/Library/Developer/CommandLineTools/usr/lib/clang/13.1.6/include/stdbool.h:15:14: note: expanded from macro 'bool'
#define bool _Bool
             ^
In file included from issue120.c:79:
./stdgo/reflect/_Type.c:522:15: error: expected identifier
                                        r4 = r8->bool;
                                                 ^
/Library/Developer/CommandLineTools/usr/lib/clang/13.1.6/include/stdbool.h:15:14: note: expanded from macro 'bool'
#define bool _Bool
             ^
In file included from issue120.c:215:
./hl/init.c:103739:7: error: expected identifier
        r63->bool = r9;
             ^
/Library/Developer/CommandLineTools/usr/lib/clang/13.1.6/include/stdbool.h:15:14: note: expanded from macro 'bool'
#define bool _Bool
             ^
1 warning and 6 errors generated.

Most of these errors appear to be naming clashes, so will need to be resolved in order to target C in this way.

From the above, it would seem that if you use the name bool in your Haxe, HL/C does not alter the name so as not to clash with the C usage.

@elliott5 Don't know how to run the hl c code but it seems the error is no longer occurring after adding "bool" to the reserved list.

Unfortunately my retesting is currently hitting issue #132

Issue #132 is now resolved, so I tried again to find the pattern to these compilation failures.
In good news, the issues here are not within the go2hx generated code.
Rather they are name clashes from within the hand-written Haxe implementing:

reflect (bool as a field name; _bool , _int, _struct as identifiers)
syscall/js (_float)

@elliott5 very nice, I just pushed a commit to add these keywords as reserved and rewrite the keywords manually in reflect, hopefully now HL/C will compile the test code.
syscall/js is no longer handwritten but compiled with the extern keyword meaning it strips out all of the function exprs and a few other modifications to stop at that abstraction level. It's especially useful for the patch approach now, as code that references it, can compiles at runtime and throws with the "not yet implemented" message at runtime, allowing sequential patching, of the functions being used.

I can confirm this now works:
% ./c/issue120
elapsed: 17.040896ms

By comparison, the non compiled version is marginally slower:
% hl run.hl
elapsed: 17.988096ms

...so HL/C could be added to go2hx's targets!


Add canary stage to FRS stress tests runs

Currently, the FRS stress test runs against the prod tenants and service endpoint. We want to add a new canary state to our stress test which is basically an endpoint where FRS deploys their code before it goes to production.
Acceptance criteria:

The new tenant secrets and service endpoint is added to the key-vault
The FRS stress test succeeds after adding this new canary endpoint.

change the name to frs-canary or similar to avoid confusion later. Also, did you try to run stress tests on this branch as we discussed?

Canary pipeline run succeeded: https://dev.azure.com/fluidframework/internal/_build/results?buildId=152245&view=logs&s=3781c43d-9993-5962-e57e-cb19c0b97d45


Installation instructions should probably mention MALMO_XSD_PATH

In C#. attempting to create a new MissionSpec with an XML string will fail if MALMO_XSD_PATH doesn't point to the schemas.

Closed by 72d02cc


Ability to modify a single pixel after rendering a raster tiled tiff.

Is your feature request related to a problem? Please describe.
I'm frustrated when I change a single pixel value in the tile raster layer. e.g.,

haven't found any solution to do this.
Describe the solution you'd like
This layer receives geoserver wms service at backend. The only solution I have thought is to modify the pixel value at backend. However, is there any way to set a pixel with a specific value in frontend?

What are your criteria for selecting a pixel? (for example, coordinate or existing value)

I am trying to select a pixel by clicking to get coordinates for now.  I am trying this solution: First, get the tile grid and then get a tile. Second, get the canvas context of the selected tile. Then modify the pixel value by manipulating the canvas.


Regression prevention

Just realized that I could add a test to prevent to have to send other PRs like https://github.com/rust-lang/docs.rs/pull/1194 :)

I don't know why I didn't think of that earlier :laughing: great idea!

Arf hold on, seems like github didn't realize the first commit was already in.

After a rebase, github realized its mistake and made the commit disappear. :3


Issues with filtering and sorting using supabase-js

Note
This issue concerns the branch feature-improve-tables, until it is merged and removed

There are some problems when attempting to sort and filter using the supabase-js client, especially when referencing foreign tables:

sorting on foreign table appears unstable

order changes result, but is incorrect in my tests
order ignores the direction (ASC/DESC) in my tests
online recommended solution is creating a view (undesired solution)

https://github.com/supabase/supabase-flutter/issues/397 (& many more)

current approach is splitting the field by dot (.) and using the second term as foreignTable property, but does not adhere to order anymore.

searching/filtering on non-string (including ENUM's) values is difficult (with LIKE query),

seems to work ok on foreign tables when foreign tables are selected using !inner in the select statement.
solution in plain postgres is easy: a ::TEXT cast should be sufficient to solve execute the queries (not possible in supabase)
online recommended solution is creating a view/computed column (undesired solution)

(https://github.com/orgs/supabase/discussions/3836)

With new insight, there's multiple possible solution directions to allow for filtering on multiple columns, where we can tackle both filtering on non-text columns and on foreign table values:

Computed columns that concatenate all searched values. (Supabases recommended solution),

Source: https://supabase.com/docs/guides/database/full-text-search#search-multiple-columns
Pros:

We can keep using the supabase-js client in the backend,
We can cast enums and others with ::TEXT

Cons:

Searchable columns have to be defined in SQL and migrations,
Unsure at the moment if getting data from foreign tables is difficult using this approach.

View Table that directly contains the data that will visible to the end-user,

Pros:

We can keep using the supabase-js client in the backend,
We can cast enums and others with ::TEXT
The table contents the end-user sees better corresponds to the table definition in the View,
Probably faster response times, since View will be re-rendered on update (right?)

Cons:

Have to define the view in SQL, however I would prefer this over 1's cons.

Direct database-interaction from the backend, using a raw connection or a query-builder,

Pros:

We keep the business logic and searchable columns in one place: the backend,
We can write the queries more specifically and hence do joining and casting in the backend,

Cons:

Requires implementing the dependency of a good query-builder and loading it in the context for only limited use-cases,


fix error handling about rocksdb iterator

What have you changed?
Fix error handling about rocksdb iterator.
What is the type of the changes?
Bug fix.
How is the PR tested?
Unit tests.
Does this PR affect documentation (docs) or should it be mentioned in the release notes?
No.
Does this PR affect tidb-ansible?
No.
Refer to a related PR or issue link (optional)
Benchmark result if necessary (optional)
Any examples? (optional)

@Connor1996 @zhangjinpeng1987 PTAL thanks!

/run-all-tests


Practice Exam 11 Q43

Right Answer is A because application cannot be interrupted.

@PyFaNNy
The company should use Spot Instances to meet these requirements. Spot Instances provide the most cost-effective option for EC2 instances, and they can be interrupted with a two-minute notification when the market price exceeds the user's bid price. However, if the user sets the bid price at the current on-demand price, they have a high probability of maintaining their instances for as long as needed. This makes them ideal for workloads with flexible start and end times, or for short-term workloads that are resilient to interruptions. On-Demand Instances offer predictable pricing with no upfront commitment and can be launched at any time. Reserved Instances provide a discounted hourly rate compared to On-Demand Instances, but they require a one-year or three-year commitment upfront. Dedicated Hosts offer physical servers dedicated to a user's use, providing the most control and visibility, but with a significant cost premium over the other options. However, there is a risk of interruption if the spot price rises above the customer's bid. To mitigate this risk, customers can use a combination of On-Demand and Spot Instances.


iterate doesn't stop but keeps going till the very end

@rultor release, tag is 0.0.7

@rultor release, tag is 0.0.7

@yegor256 OK, I will release it now. Please check the progress here

@rultor release, tag is 0.0.7

@yegor256 Done! FYI, the full log is here (took me 8min)


release EKS Go 1.19 tracking upstream 1.19.3

Issue #, if available:
Description of changes:
Trigger a build of EKS Go tracking upstream 1.19.3
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

/approve


fix: formatting

I fixed the formatting of the README
See:

thanks @0xflotus 🚀  merging in

:tada: This PR is included in version 0.1.3 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


Incorrect report of error - UnsafeOptInUsageError

Expected Behavior
If build.gradle has kotlinOptions.freeCompilerArgs defined for opt-in experimental APIs, the @androidx.compose.material3.ExperimentalMaterial3Api is not required in the usage site in the code.
But, detekt still shows lint error for them.
Observed Behavior
Error

/Users/abhimanyu/Documents/projects/finance-manager/codebase/android/core/ui/src/main/java/com/makeappssimple/abhimanyu/financemanager/android/core/ui/common/CommonScreenUIState.kt: Error: This declaration is opt-in and its usage should be marked with @androidx.compose.material3.ExperimentalMaterial3Api or @OptIn(markerClass = androidx.compose.material3.ExperimentalMaterial3Api.class) [UnsafeOptInUsageError from androidx.annotation.experimental]

Steps to Reproduce

Can use any opt-in feature and use kotlinOptions.freeCompilerArgs in build.gradle instead of using annotation in the code.

Context

Your Environment

Version of detekt used:
Version of Gradle used (if applicable):
Gradle scan link (add --scan option when running the gradle task):
Operating System and version:
Link to your project (if it's a public repository): https://github.com/Abhimanyu14/finance-manager

This is covered under https://github.com/detekt/detekt/issues/4465

So, should we close this one as "dupe"?


fix: class name typo

Looks like there's a minor lint issue. Can you run pnpm lint? I can fix as well if pnpm lint is not working for you.

Sorry didn't mean to close this.

there are a few errors about the class order:
www:lint: ./app/sink/page.tsx
www:lint: 66:18  Error: Invalid Tailwind CSS classnames order  tailwindcss/classnames-order
www:lint: ./components/ui/command.tsx
www:lint: 48:18  Error: Invalid Tailwind CSS classnames order  tailwindcss/classnames-order

I suggest installing eslint-config-prettier and eslint-plugin-tailwindcss to enable automatic error fixing by ESLint.


Add numberOfLines and maximumNumberOfLines props to TextInput on iOS

Details

Fixed Issues

$ GH_LINK
PROPOSAL: GH_LINK_ISSUE(COMMENT)
Tests

[ ] Verify that no errors appear in the JS console

Offline tests

QA Steps

[ ] Verify that no errors appear in the JS console

PR Author Checklist

[ ] I linked the correct issue in the ### Fixed Issues section above
[ ] I wrote clear testing steps that cover the changes made in this PR

[ ] I added steps for local testing in the Tests section
[ ] I added steps for the expected offline behavior in the Offline steps section
[ ] I added steps for Staging and/or Production testing in the QA steps section
[ ] I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
[ ] I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
[ ] I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).

[ ] I included screenshots or videos for tests on all platforms
[ ] I ran the tests on all platforms & verified they passed on:

[ ] iOS / native
[ ] Android / native
[ ] iOS / Safari
[ ] Android / Chrome
[ ] MacOS / Chrome
[ ] MacOS / Desktop

[ ] I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
[ ] I followed proper code patterns (see Reviewing the code)

[ ] I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
[ ] I verified that comments were added to code that is not self explanatory
[ ] I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
[ ] I verified any copy / text shown in the product was added in all src/languages/* files
[ ] I verified any copy / text that was added to the app is correct English and approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
[ ] I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
[ ] I verified the JSDocs style guidelines (in STYLE.md) were followed

[ ] If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
[ ] I followed the guidelines as stated in the Review Guidelines
[ ] I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
[ ] I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
[ ] I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
[ ] I verified that if a function's arguments changed that all usages have also been updated correctly
[ ] If a new component is created I verified that:

[ ] A similar component doesn't exist in the codebase
[ ] All props are defined accurately and each prop has a /** comment above it */
[ ] The file is named correctly
[ ] The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
[ ] The only data being stored in the state is data necessary for rendering and nothing else
[ ] For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
[ ] Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
[ ] All JSX used for rendering exists in the render method
[ ] The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions

[ ] If a new CSS style is added I verified that:

[ ] A similar style doesn't already exist
[ ] The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG)

[ ] If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
[ ] If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
[ ] I have checked off every checkbox in the PR author checklist, including those that don't apply to this PR.

Screenshots/Videos

Web

Mobile Web - Chrome

Mobile Web - Safari

Desktop

iOS

Android

When also removing numberOfLines from the iOS implementation I get the following behaviour (it works but is a bit laggy):
https://user-images.githubusercontent.com/16821682/205988792-408ed988-97c0-430a-8135-53bde69016e1.mp4

I'm pretty sure it has to be as fast as the maxHeight props as it works in very similar way. Did you tap send button? It activates heavyWork on JSThread

Previous solution using maxHeight. The problem is how TextInput works in React-native.
Let's imagine a case when next character has to be placed at a new line. Then the following happens:

key is tapped.
a letter is added to the text input on UI thread and at the same time we send the event to JS
Js can modify value of the text input (if we don't provide onChangeListener the default one will be used)
Js rerenders
all changes are passed to UI Manager
UI Manager computes new layout on UI Manager thread
computed layout changes are scheduled on UI Thread

If Js thread is busy there will be a lag
https://user-images.githubusercontent.com/12784455/206129597-de30ff94-32d1-425f-9bd3-dc359009a50d.mp4

Does it work without the lag if you remove the value prop from the text input, e.g. making it an uncontrolled text input?


enable prompt tuning generate method

Hi @pacman100,
I have made improvements to the implementation of the generate method in the PeftModelForSeq2SeqLM class, building upon the contributions by @thomas-schillaci, #519. This commit introduces support for prompt tuning using encoder-decoders.

Hello @ZhengxiangShi, #519 has incorporated the suggestions you posted on that PR. I've requested them to add you as co-author there and we can mege that.

closing this as the PR #519 was merged.

Thanks for your help!


modified the ui

Hello, i modified the ui please review this and merge.
Thank you

Hey @devocoe
Can you please share some screenshots that you have changed?


Spatial audio volume does not respect the channel's volume

There's no way to scale the volume of a sound coming from an emitter.
I've linked the relevant line of code that needs to be updated if i understand it correctly.
https://github.com/NiklasEi/bevy_kira_audio/blob/main/src/spacial.rs#L44

The whole API is likely to change with #114 due to a switch to a more ECS-centric way of controlling audio.


Nuxt-speedkit try two

Thank you for your contribution to the KodaDot - One Stop Shop for Polkadot NFTs.
👇 __ Let's make a quick check before the contribution.
PR Type

[ ] Bugfix
[x] Feature
[ ] Refactoring

Context

[x] Related #5031

Copilot Summary

🤖 Generated by Copilot at 90af573
Added nuxt-speedkit module to improve website performance. Updated package.json file with the new dependency.

🤖 Generated by Copilot at 90af573

nuxt-speedkit added
to boost the Nuxt gallery
winter wind is swift

Yes, the module is not in nuxt.config.ts, yet it improves numbers.

https://github.com/kodadot/nft-gallery/pull/7805#issuecomment-1777264919
https://github.com/kodadot/nft-gallery/pull/7805#issuecomment-1777257269

Continue to

https://github.com/kodadot/nft-gallery/issues/7807

I think it's an improvement due @nuxt/image ?

sad noises 😞


dockerImage: better UX

creates a single docker image with a wrapper script
supports mainnet/testnet or a custom config from same image
alters nix/scripts to not need to cd into the state directory

To launch mainnet and keep state in a persistent docker volume run:
docker run -v /data -e ENV=mainnet inputoutput/cardano-node:<TAG>
To launch testnet and keep no state between launches run:
docker run -e ENV=testnet inputoutput/cardano-node:<TAG>
To launch with a custom config, volume mount /config and /data
docker run -v $PATH_TO/config:/config -v $PATH_TO/data:/data inputoutput/cardano-node:<TAG> --genesis-hash <GENESIS_HASH>
/config must contain config.json, genesis.json and topology.json
Issue

The UX design for how images are pushed is horrible. You have to pull a new image for every environment you want to run. You can't override any parameters to that environment if you want to build your own custom image. Also, you have to know what gitrev to run as the only image pushed for master is a blank image you have to provide your own custom config to. This design is much more elegant, and resulted in a 33 MB decrease in image size (605 MB -> 575 MB). It also means users only have to pull a single image. It also unifies the paths where DB/socket are in all images instead of having env names as part of the paths.

This PR results in breaking changes to upstream dependencies.

Checklist

[ ] This PR contains all the work required to resolve the linked issue.

[ ] The work contained has sufficient documentation to describe what it does and how to do it.

[ ] The work has sufficient tests and/or testing.

[ ] I have committed clear and descriptive commits. Be considerate as somebody else will have to read these.

[ ] I have added the appropriate labels to this PR.

bors r+

bors r-

bors r+


TrackingNet datasets?

I also need trackingnet datasets, but I always make mistakes when I download them. Can you provide download links like Baidu cloud drives?

We are uploading data to baiduyunpan now, Please keep tuned.

We are uploading data to baiduyunpan now, Please keep tuned.
Thank you for your quick reply and the baiduyunpan link you will provide soon.


W3MI: Sorting order changed in S/4HANA

The highlighted internal table has different sorting order in S/4HANA and results in diffs. It needs to be sorted immediately after function module call

Left Side: S/4HANA 2020
Right Side:  SAP_ABA	750

@yellappam
Can you update one of these test cases?
https://github.com/abapGit-tests/W3MI.git
https://github.com/abapGit-tests/W3MI_names.git

@christianguenter2 Do you mean to update the repo with my example?

Yes. Adding your example somewhere. I tried to reproduce the issue but wasn't able to do that.


[release-1.7] Drain listeners gracefully

This is an automated cherry-pick of #26528

a few of our users have reported ingress gw down time during upgrade.  This looks like would help w/ it.
cc @brian-avery @ericvn @fpesce

close this as it can't be applied to envoy in istio 1.7

Looks like this is ported back to istio's envoy in 1.7 - https://github.com/istio/envoy/pull/290


Support for Steam Controller

Tested an upload using the new .4.0 format for bindings file, and also one that I made for the Steam Controller. It seems EDRefCard doesn't have support for that controller; I got an error. "The error also suggested supplying the reference qyrnxs and we will attempt to add support for it."
Would it be possible to add support for the steam controller?

I'll second that. I don't use the controller for flying, but it's great for SRV control.
I think the Steam controller comes up with various device IDs depending on its mode of operation.
If it's emulating a 360 pad, it'll show up as VID: 28DE, PID: 11FF
But I think it's possible for other modes to come up as one of -

28de:1102
28de:1105
28de:1106
28de:1142
28de:11fc
28de:1201
28de:1202


Allow Caps-locked keys on CLI

Description:
Currently, is a capslock is selected, the CLI fails to work. This shouldn't be the case.
Steps to reproduce:

Run ./dev.sh
Press caps-lock
try to exit the CLI by pressing x

Expected behavior:
CLI should exit
Actual behavior:
Does nothing, just jitters

Does this needs to be handled for other keys also? Like q, w, e, a etc.

I think that should be case across all other keys.

Hi there @e-for-eshaan could you assign this ticket to me?

Sure @nisalikularatne !

@e-for-eshaan https://github.com/middlewarehq/middleware/pull/526 this is the PR for the above issue. Let me know if you have any concerns!


[feat!] Get lineProps, lineNumberProps, and lineNumberContainerProps back

[x] Initial peek
[ ] Fix tests and snapshots.
[ ] Add lineNumberContainerProps.
[ ] Update demos.

Fixes #311

Hey @simmerer. I got a rough version of what it would look like to bring back the missed props. Would need some help or guidance on how to fix the snapshots. Do you regenerate them from scratch? Also, have a look at the code and let me know if you find something weird or incorrect. Thanks!

@fmvilas If I'm confident that rendering changes are correct and the snapshots need to be updated, then I run jest -u locally to update the snapshots.
I'll take a look soon. Thanks for starting on this!

I'm getting this bug right now:
react-dom.development.js?61bb:88 Warning: React does not recognize the `lineNumberContainerProps` prop on a DOM element. If you intentionally want it to appear in the DOM as a custom attribute, spell it as lowercase `linenumbercontainerprops` instead. If you accidentally passed it from a parent component, remove it from the DOM element.
    in pre (created by SyntaxHighlighter)
    in SyntaxHighlighter (at content.js:58)
    in CodeBlock (created by ReactMarkdown)
    in Root (created by ReactMarkdown)
    in ReactMarkdown (at content.js:163)
    in Content (at body.js:26)
    in section (created by ForwardRef(Typography))
    in ForwardRef(Typography) (created by WithStyles(ForwardRef(Typography)))
    in WithStyles(ForwardRef(Typography)) (at body.js:18)
    in DynamicZone (at body.js:55)
    in Body (at [slug].js:98)
    in main (created by ForwardRef(Container))
    in ForwardRef(Container) (created by WithStyles(ForwardRef(Container)))
    in WithStyles(ForwardRef(Container)) (at layout.js:10)
    in Layout (at [slug].js:40)
    in Post (at _app.js:55)
    in ThemeProvider (at _app.js:52)
    in FolioApp (created by withI18nextSSR(FolioApp))
    in withI18nextSSR(FolioApp) (created by AppWithTranslation)
    in NextStaticProvider (created by withI18nextTranslation(NextStaticProvider))
    in withI18nextTranslation(NextStaticProvider) (created by AppWithTranslation)
    in I18nextProvider (created by AppWithTranslation)
    in AppWithTranslation (created by withRouter(AppWithTranslation))
    in withRouter(AppWithTranslation)
    in ErrorBoundary (created by ReactDevOverlay)
    in ReactDevOverlay (created by Container)
    in Container (created by AppContainer)
    in AppContainer
    in Root

Does this pull request to solve it?

@simmerer Any progress about this? Thanks.

@fmvilas what happened whit thi one?

Sorry got completely neck deep into AsyncAPI work. Don't have time to contribute to this one so feel free to take over it or close it.


Added filtered_input and constrained_decoding

Description
Brief Description of the PR:
We can have a common function for creating filtered_inputs used in crf_multitag_sequence_score
This function can be reused to modify the input to crf_decode to support constrained decoding.
Fixes #607
Type of change

[ ] Bug fix
[ ] New Tutorial
[x] Updated or additional documentation
[x] Additional Testing
[ ] New Activation and the changes conform to the activation contribution guidelines
[ ] New Callback and the changes conform to the callback contribution guidelines
[ ] New Image addition and the changes conform to the image op contribution guidelines
[ ] New Layer and the changes conform to the layer contribution guidelines
[ ] New Loss and the changes conform to the loss contribution guidelines
[ ] New Metric and the changes conform to the metric contribution guidelines
[ ] New Optimizer and the changes conform to the optimizer contribution guidelines
[ ] New RNN Cell and the changes conform to the rnn contribution guidelines
[ ] New Seq2seq addition and the changes conform to the seq2seq contribution guidelines
[x] New Text addition and the changes conform to the text op contribution guidelines

Checklist:

[x] I've properly formatted my code according to the guidelines

[x] By running Black + Flake8
[ ] By running pre-commit hooks

[x] This PR addresses an already submitted issue for TensorFlow Addons
[x] I have made corresponding changes to the documentation
[x] I have added tests that prove my fix is effective or that my feature works
[ ] This PR contains modifications to C++ custom-ops

How Has This Been Tested?
If you're adding a bugfix or new feature please describe the tests that you ran to verify your changes:

I ran pytest locally to test this PR. All tests passed.

@facaiy @Squadrick @seanpmorgan can you have a look at it?

@napsternxg Can you run the formatting tools again? I'd like to merge this after the tests pass. Thank you!

@WindQAQ Fixed it.

@Squadrick was removed by mistake when I clicked on request review.


Update office.js CDN URL to all lowercase letters

The CDN URL for office.js should be changed to all lowercase letters, because many of our tools and samples are referencing it that way. Furthermore, we are now prefetching the office.js using the lowercase URL in Office Online. Using uppercase O in the URL causes us to be unable to share the browser cache as the URLs are different.

Docs Build status updates of commit c32d2b2:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

docs/develop/referencing-the-javascript-api-for-office-library-from-its-cdn.md
:white_check_mark:Succeeded

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.


app.getUserLocale is not a function

Hello, I'm trying to use your library but as soon as I try to run it, I got this error:
TypeError: app.getUserLocale is not a function     at I18n.use (D:\GitHub\Coffee-Advisor\node_modules\@manekinekko\actions-on-google-i18n\index.js:50:22)     at Object.<anonymous> (D:\GitHub\Coffee-Advisor\functions\index.js:36:6)     at Module._compile (module.js:652:30)     at Object.Module._extensions..js (module.js:663:10)     at Module.load (module.js:565:32)     at tryModuleLoad (module.js:505:12)     at Function.Module._load (module.js:497:3)     at Module.require (module.js:596:17)     at require (internal/module.js:11:18)     at C:\Users\david\AppData\Roaming\npm\node_modules\firebase-tools\lib\triggerParser.js:21:11
That's how i wrote my webhook with V2 library:
const functions = require('firebase-functions');
const i18n = require('@manekinekko/actions-on-google-i18n');

const app = dialogflow();
i18n.use(app);

...

exports.myapp= functions.https.onRequest(app);

Hi, i'm planning to release a new version of this library that is compatible with the dialogflow v2 library. Stay tunned.


Revert "Replace the call to /hosts so we can get the exact device for ID"

Reverts RedHatInsights/edge-api#582

Hi @biancarosa, please explain why


BlockEntity::markDirty replacement names

The general consensus in Discord was that markDirty isn't great as it doesn't indicate what is marked as dirty. The method actually only indicates that the chunk containing the BE needs to be saved to disk, not that (contrary to common belief) update packets should be sent to clients.
The two proposed options so far:

scheduleSave
markChanged

I was going to open an issue for this, but realized this already exists. +1 for finding something better than markDirty, especially for block entities where it additionally fires a comparator update. Although we will have to use the same for Inventory as well.
Ideally the mapping would convey that we go from "no guaranteed save" to "guaranteed save".


file ID modifier is reset to value A after calling to flatten

ACH Version
moov/ach:v1.42.1
What were you trying to do?
I was trying to generate an outgoing file by increment fileIDModifier in fileHeader. I parsed fileIDModifier: 'B' to create a file and then call to /flatten endpoint however, got the value A instead.
What did you expect to see?
Value of fileIDModifier should be received whatever we sent.
What did you see?
fileIDModifier is 'A'
How can we reproduce the problem?

create a file along with fileHeader.fileIDModifier and set value to any alphabet
use the file id and send to /flatten
observe

Do you need a value other than "A" in your use-case? This is a bug but "A" is often used regardless of what the modifier should be.

I'm going to take a look at this issue. I haven't seen too many cases where the File Modifier isn't "A".  I worked with one bank that processed about 50 files a day (Not all went through the Fed, many were internal postings between their fintech partners), but if they sent multiple files to the Fed within a single day's processing window they would increment to the next Alpha character for each additional file.

Sounds good. We can defiantly support characters beyond A. The bug is probably from flattening creating a new FileHeader and forgetting to copy the ID Modifier.

Fixed in https://github.com/moov-io/ach/pull/1518


status line truncation when splits narrow width

Hi, thank you for awesome lightline!
NOTE: this is really a question and not an issue.
When I split windows vertically obviously the width is redcued by half.
Sometimes there is not enough space for all statusline parts and it seems the left-side mode gets truncated before other right-side parts.
Is there a way to have the truncation be from the right ?
I am reading this now:
https://github.com/itchyny/lightline.vim#can-i-trim-the-file-format-and-encoding-information-on-narrow-windows

Do I need to adjust the width of each part manually to try and make it fit better ?
thx,
-m

Can I make NORMAL -> N, INSERT -> I, REPLACE -> R, VISUAL -> V, etc. to make more room ?

This does help:
function! MyLightlineFilename()
    ....
    if winwidth(0) < 90
      return filename[-16:]
    else
      return filename
    endif

But am still curious about using a shorter mode word always.

To truncate from right hand side, include %< in some of the component on the right (a little bit hacky but it works).
let g:lightline = {
      \ 'component': {
      \   'lineinfo': '%3l:%-2v%<',
      \ },
      \ }

To use shorter mode names, specify the mode_map (see :h g:lightline.mode_map).

let g:lightline = {
      \ 'mode_map': {
        \ 'n' : 'N',
        \ 'i' : 'I',
        \ 'R' : 'R',
        \ 'v' : 'V',
        \ 'V' : 'VL',
        \ "\<C-v>": 'VB',
        \ 'c' : 'C',
        \ 's' : 'S',
        \ 'S' : 'SL',
        \ "\<C-s>": 'SB',
        \ 't': 'T',
        \ },
      \ }

@itchyny thanks always so much for your help and work.

@itchyny one more ques - if I have a split then the mode seems to not be displayed for the window that is not the current window.  Is there a way to have the mode still be there ?  I just want to keep the statusline spacing and display unchanged except for its brightness when switching windows.
thx again as always for awesome lightline. -m

I figured it out.  I had to make inactive the same as active:
    \ 'active': {
    \   'left': [ [ 'mymode', 'paste' ],
    \             [ 'gitbranch', 'myfilename', 'mymodified', 'mycolonkeyword' ] ]
    \ },
    \ 'inactive': {
    \   'left': [ [ 'mymode', 'paste' ],
    \             [ 'gitbranch', 'myfilename', 'mymodified', 'mycolonkeyword' ] ]
    \ },

thx again.


fix: removing touchableGetInitialState to fix rn 0.74 issue on ios

Following the discussion in GitHub issue #46 (specifically, comment #2073170951 ), this pull request proposes the removal of the touchableGetInitialState method. While it's uncertain if this is the optimal solution for the issue raised in React 0.74, but I hope this pr to be somewhat helpful
I tired to test the code but got couple of errors locally 😓 , but at least I made sure types are correct XD
One important note, this issue is also related to RN 0.74

Thanks! Released 0.12.0


Remove resolveExtension and validateExtension

Drop these two and simplify the decl validation state machine by removing the signature checking phase.
The first commit was supposed to be included in #27279, but it got lost - probably during the rebase before I pushed.

@swift-ci please smoke test

@swift-ci please test source compatibility

⛵


unhandled error

Describe the bug:

Expected behaviour:

Steps to reproduce the issue:

Technical details:

Workspace version :
Docker version :
Host Machine OS (Windows/Linux/Mac):
Command used to start the workspace :
Browser (Chrome/Firefox/Safari):

Possible Fix:

Additional context:

the terminal and python give me such  error


Address log messages in the Console

I'm going to avoid fixing the THREE.WebGLRenderer: WebGL 1 support was deprecated issue as this is due to the current version of mapbox gl using WebGL 1, but current pre-release mapbox gl versions use WebGL 2 and they plan on using it for the next release. I think the best solution here is just wait until mapbox gl is updated

Looks like the [Violation] Added non-passive event listener warning is a known issue (https://github.com/apache/echarts/issues/18255)

Is everything else that is reasonable closed out?

I've looked and I think this is good to close unless anyone has found some messages that I've missed


Use maliput's method for creating road network via plugin api.

Part of https://github.com/maliput/maliput/issues/509
Matches https://github.com/maliput/maliput/pull/512
Resolves #67

@ros-pull-request-builder retest this please

@ros-pull-request-builder retest this please

@ros-pull-request-builder retest this please

Now it is passing, going in!


[Internal] Binary Encoding: Adds performance tests with binary encoding enabled.

Description
Add performance tests for methods CreateItemAsync, CreateItemStreamAsync, ReadItemAsync, ReadItemStreamAsync, UpsertItemAsync, UpsertItemStreamAsync, ReplaceItemAsync, ReplaceItemStreamAsync, DeleteItemAsync, DeleteItemStreamAsync which have binary encoding support. These tests will run in the pipeline and help determine in determining regression when binary encoding feature is enabled.
https://cosmos-db-sdk-public.visualstudio.com/cosmos-db-sdk-public/_build/results?buildId=52826&view=logs&j=aa2fd561-a338-5537-45ee-49ae22aea958&t=65500a81-e1c7-5931-1116-cabb8c832591

Type of change

[x] New feature (non-breaking change which adds functionality)

Closing issues
To automatically close an issue: closes #IssueNumber

Please review this PR https://github.com/Azure/azure-cosmos-dotnet-v3/pull/4943 for performance tests.
The approach for adding performance tests for Binary encoding feature has changed and instead of adding a new test class, will be updating existing tests to run for scenarios when binary encoding is enabled.