Research sgconv

Pull Request Template
Description
Merging the research-sgconv branch back with main.
Please include a list of changes, relevant information, context and new dependencies.
Refactored sgconv related classes and functions to appropriate places in archai package.
Fixes: # (issue)
sgconv folder had wrong structure with respect to main branch.
Changes
Please delete options that are not relevant.

[x] Bug fix (non-breaking change which fixes an issue)
[x] New feature (non-breaking change which adds functionality)

Configuration:

Archai version:
Environment:
OS:

Final checks:

[ ] Follows guidelines of project
[ ] Self-review of code
[ ] Commented code in hard-to-understand areas
[ ] Corresponding changes to the documentation
[ ] Changes generate no new warnings
[ ] Dependent changes have already been merged
[ ] Checked code correction any misspellings

Even if not merged, a review of the current state of this branch will be useful.

Looks good to me.
I have only a few comments regarding where to put the codegen_sgconv model variants and how we can handle requirements in research projects.

One option would be to add them to research/sgconv/models. The only modification necessary would be to bring research/sgconv/scripts/main.py to the root directory and create a new directory to store experiment_runner:

archai/
  research/
    sgconv/
      training/
        __init__.py
        experiment_runner.py
      models/
        __init__.py
        modeling_codegen_sgconv.py
        modeling_codegen_hard_coded.py
        ...
      scripts/
        # Other scripts can still stay here if they don't depend on anything from models/ or training/
        prepare_datasets/
        miscellaneous/

      main.py
      requirements.txt

Import statements in main.py would have to change to something like from models.modeling_codegen_sgconv import xyz. And imports inside models, like models/modeling_codegen_sgconv.py importing something from models/sgconv.py, would also need to change to a relative import (i.e from .sgconv import xyz) in order to still work when you call python main.py.
For requirements, I would suggest adding a custom research/sgconv/requirements.txt file with any extra requirements your research needs (einops, for instance) and the archai version you are planning to use, (you can fix a version from PyPi for better stability/reproducibility, or just use the newest one adding something like "archai @ git+https://github.com/Microsoft/archai.git" to your requirements file).

If you feel that having to bring the entrypoint script (main.py) to the root sgconv directory will make the code organization significantly worse, a different option would be to make research/sgconv an installable module. We would have to add a setup.py script like I did here for TF++(https://github.com/microsoft/archai/tree/main/research/transformer_plus_plus). Then any import to the sgconv models from the scripts inside sgconv/scripts or other relative imports (like in sgconv/modeling_codegen_sgconv.py to sgconv/sgconv.py) can all be absolute imports (from sgconv.models import xyz). I would recommend creating a conda env to help isolate things better if using this approach. This option can be a bit annoying but is great for assuring reproducibility.

We can also keep stuff in archai directly. I'm not a big fan of this approach because we would mix research/experimental features and extra requirements with the main library, which can make merging things difficult later. One other disadvantage of this approach is that things from this research project can end up scattered throughout various parts of the library, and one may be tempted to change core archai library things during the project (i.e fix a core library bug) directly, which can be easy to forget about later, instead of doing a proper bug fix PR on the master branch.

I like approach 1 and 2 better because it makes collaborators who want to do research follow the same steps any other user would (without superpowers to change the main library), which I think is a good practice. And when a research project works, we can always add the new features to the main library so everyone can use them.
Sorry for the long answer and for the state the library is in right now (which must have hindered you during development). Feel free to keep the files as-is for now, I can help you make the change necessary once we have things in a more stable state. I hope once we find a good workflow this process will be much easier. Thanks


Union columns can never be NULL

Describe the bug
Maybe I'm doing something wrong with my union in datafusion-functions-json, but is null expressions never evaluate to true with the JsonUnion column.
They behave as expected when the function in question returns a scalar JsonUnion.
To Reproduce
See https://github.com/datafusion-contrib/datafusion-functions-json/pull/24
Expected behavior
When the value in every column of the union is null:

<union column> is null should evaluate to null
I guess it would also be nice if  the repr of null values in a union was an empty string same as everything else, not {<first column_name>=} (which I what I think it is now)

Additional context
No response

@alamb any idea on where I would start looking to try and fix this?

See #11314 as a demonstration of the problem for both dense and sparse unions.
After a bit of investigation, the issues lies in the first instance with
https://github.com/apache/datafusion/blob/08c5345e932f1c5c948751e0d06b1fd99e174efa/datafusion/physical-expr/src/expressions/is_null.rs#L74-L84
Then with this code in arrow-rs:
/// Returns a non-null [BooleanArray] with whether each value of the array is null.
/// # Error
/// This function never errors.
/// # Example
/// ...
pub fn is_null(input: &dyn Array) -> Result<BooleanArray, ArrowError> {
    let values = match input.logical_nulls() {
        None => BooleanBuffer::new_unset(input.len()),
        Some(nulls) => !nulls.inner(),
    };

    Ok(BooleanArray::new(values, None))
}

And then with this code
    /// Union types always return non null as there is no validity buffer.
    /// To check validity correctly you must check the underlying vector.
    fn is_null(&self, _index: usize) -> bool {
        false
    }

Ultimately with the spec

Unlike other data types, unions do not have their own validity bitmap. Instead,
the nullness of each slot is determined exclusively by the child arrays which
are composed to create the union.

Basically arrow is saying "we're not going to tell you if a union is null, you need to look in the child arrays", but datafusion isn't listening and is just asking the union if it's null in the naive way.
Two options to move forward as far as I can tell:

Decide unions in DF can never be null — I'll need to abandon unions in datafusion-functions-json and just return strings everywhere
Have custom logic for unions that looks up the child array to determine if the value is null

If (as I hope) we go for the second option, there's also the issue (as demonstrated by #11314) that the representation of  "null" union items doesn't match other types, it shows {A=} instead of an empty string.

Have custom logic for unions that looks up the child array to determine if the value is null
+1 for second option. I think we should check the children's nullability.

I suppose there's a third option of updating arrow-rs to correctly calculate if a UnionArray is null, but I presume that works take much longer

I've proposed a fix in #11321.

I suppose there's a third option of updating arrow-rs to correctly calculate if a UnionArray is null, but I presume that works take much longer

It would likely take longer
Note there is a method that takes into account child nullability that perhaps we could use instead of is_null:
https://docs.rs/arrow/latest/arrow/array/trait.Array.html#method.logical_nulls


Supporting custom containerd shim runtime

Currently docker doesn't support custom shim runtime when creating daemon and containers. Custom runtime shim configuration is also disabled.  This PR is mean to enable the support for custom shim runtime and shim config through docker configuration(as in daemon.json).
Related issues:

https://github.com/moby/moby/issues/42239

- What I did and How I did it

Make json struct tag of Shim field of api/types.Runtime public, so we can config it through daemon.json.
A modification to daemon/runtime_unix.(func initRuntimes), when runtime is being initializing, read the opts in the form of map[string]interface{} and convert it to a real struct implementation
- How to verify it
Run dockerd with the following configuration(you may need other custom containerd runtime if you are not meant to run with eru-containerd)

{
  "pidfile": "/run/eru/docker.pid",
  "data-root": "/var/lib/eru/docker",
  "exec-root": "/var/run/eru/docker",
  "live-restore": true,
  "containerd": "/run/eru/containerd.sock",
  "containerd-namespace": "io.containerd.eru.v2",
  "hosts": [
    "unix:///var/run/eru/docker.sock"
  ],
  "runtimes": {
    "io.containerd.eru.v2": {
      "path": "runc",
      "shim": {
        "binary": "io.containerd.eru.v2"
      }
    }
  }
}

- Verification

create a container with custom runtime, and you will find the container is successfully created and can be started

 docker -H unix:///var/run/eru/docker.sock container create --runtime io.containerd.eru.v2 nginx:latest

- Description for the changelog
api/types.go // add shim json struct tag
daemon/runtime_unix.go // add initializing logic for custom shim runtime

PR will merge to 20.10.7 instead of master


hotfix:ts-error-fetchprotocol

What kind of change does this PR introduce?
Fixes A spread argument must either have a tuple type or be passed to a rest parameter.ts(2556)
What is the current behavior?
Not explicitly typed, sometimes the compiler will interpret the type wrong.

Please link any relevant issues here.
What is the new behavior?
Explicit type specified.
Feel free to include screenshots if it includes visual changes.
Additional context
Add any other context or screenshots.

Pull Request Test Coverage Report for Build<PHONE_NUMBER>
Details

1 of 1 (100.0%)  changed or added relevant line in 1 file are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 65.55%

Totals

Change from base Build<PHONE_NUMBER>:
0.0%

Covered Lines:
89

Relevant Lines:
116

💛  - Coveralls


PR for #474

Issue #, if available: #474
Description of changes:
CheckList:
[ ] Commits are signed per the DCO using --signoff
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Make the PR merge for main instead of 2.0. Also rename the PR to be about the changes this PR brings.


BUG: Fix bug with example

Should fix https://app.circleci.com/pipelines/github/mne-tools/mne-python/24939/workflows/56cc382c-a845-4109-8d43-f2e54f79c483/jobs/67947. Basically the example assumes that there is exactly one good cluster, which is not best practice and seems to have been affected in this case by the random state somehow.

heh. https://github.com/CarinaFo/mne-python/pull/5#discussion_r1713871191


refactor: simplify init options for @volar/vue-langauge-server v1.0

languageFeatures and documentFeatures options have been deprecated since @volar/vue-langauge-server v1.0.0, you can check released information at:

https://github.com/johnsoncodehk/volar/pull/1916
https://github.com/johnsoncodehk/volar/issues/2046#issuecomment-1287825923

Thanks.


Accessing my Realm from an iOS extension when using Realm Mobile Platform

Goals
Access my Realm from an iOS extension, when using the Realm Mobile Platform
Expected Results
According to Apple guidelines I should be able to access Realm via App Group.
Actual Results
The local path is unavailable when using the Realm Mobile Platform.
I'm submitted this question following this stackoverflow: https://stackoverflow.com/questions/44786619/accessing-realm-from-an-ios-extension-while-using-realm-mobile-platform
And was answered this is a feature request and to open a ticket here.

Thanks for this issue, @gerbil802! This is something we're going to support in future updates.

What's the difference feature a Feature an an Enhancement? 😯

I'd say Enhancement is always a small Feature 😆 We actually have a support for working with sync'd realms from different process internally but it's not exposed to the users and some design needs to be done for that.

We're already tracking this as #4490, so I'm closing this ticket as a duplicate. Please subscribe to #4490 to be notified of any progress regarding this functionality.

any updates on this issue ?


getStore error in storybook v6 mdx

state machine error
probably some init error, cuz devtool loads ok if pages are switched/re-rendered (while in SPA context)

can you provide more details on all versions?

same problem..
    "@hookform/devtools": "^2.0.3",     "@roche/rdcp-design-system": "^0.3.3-dev.321",     "@testing-library/jest-dom": "^4.2.4",     "@testing-library/react": "^9.3.2",     "@testing-library/user-event": "^7.1.2",     "@types/jest": "^24.0.0",     "@types/node": "^12.0.0",     "@types/react": "^16.9.0",     "@types/react-dom": "^16.9.0",     "@types/styled-components": "^5.1.1",     "@typescript-eslint/eslint-plugin": "^3.7.1",     "@typescript-eslint/parser": "^3.7.0",     "eslint-config-prettier": "^6.11.0",     "eslint-plugin-prettier": "^3.1.4",     "eslint-plugin-react": "^7.20.4",     "husky": "^4.2.5",     "prettier": "^2.0.5",     "react": "^16.13.1",     "react-dom": "^16.13.1",     "react-hook-form": "^6.1.1",     "react-scripts": "3.4.1",     "styled-components": "^5.1.1",     "typescript": "^3.9.7"

where is devtool?

sorry here is my code:
I tried to put it also upper but no difference
function App(): React.ReactElement {
  const { register, handleSubmit, watch, errors, control } = useForm<Inputs>({
    mode: 'onChange'
  });
  const onSubmit = (data: any) => console.log(data);

  console.log(watch('example')); // watch input value by passing the name of it
  return (

      <form onSubmit={handleSubmit(onSubmit)}>
        <Input name="exampleRequired" ref={register({ required: true })} />
        {errors.exampleRequired && This field is required}
        <input type="submit" />
      </form>
      <DevTool control={control} />

  );
}

can you do a re-install? I think i have fixed this early this morning.

Is it published already? I see latest version "@hookform/devtools": "^2.0.3", that I installed yesterday

I think the issue it's due to little-state-machine.

can you check your node_module which version is your little-state-machine?

"little-state-machine": "^3.0.1",

I mean inside your node_module folder, 3.1.0 is the one having problem.

{
  "name": "little-state-machine",
  "sideEffects": false,
  "version": "3.1.0",

you are right

@bluebill1049 Last version where devtools are working for me is:
@hookform/devtools": "2.0.0"

are you using LSM? maybe you getting the latest version otherwise it's strange because devtool is only getting latest patch and shouldn't take minor version from there.
try remove the whole node modules and reinstall again, it should fix it.

always when I install 2.0.3 it automaticaly installs me to root folder 3.1.0
├─<EMAIL_ADDRESS>...
├─<EMAIL_ADDRESS>│  ├─<EMAIL_ADDRESS>│  ├─<EMAIL_ADDRESS>│  ├─<EMAIL_ADDRESS>│  ├─<EMAIL_ADDRESS>│  ├─<EMAIL_ADDRESS>│  └─<EMAIL_ADDRESS>

isnt is because "^" ?
├─<EMAIL_ADDRESS>│  ├─<EMAIL_ADDRESS>

so what I assume happened.. they released new minor version of lsm and thats why its installing use 3.1

This is fixed right?

sorry forgot to follow up.

Yes its not global issue it happens only for me cause I have abstraction in npm and because there is ^ before little-state-machine it installs wrong version:(. But if you will update package and remove ^ it would be perfect:)

I think that issue is patched with little-state-machine as well :) so going to close this issue.

thanks anyway!


[Event Request] codeunit 12179 "Export FatturaPA Document"

In Local procedure PopulateOrderData I need the event 'OnBeforePopulateOrderData'
local procedure PopulateOrderData(var TempFatturaLine: Record "Fattura Line" temporary; TempFatturaHeader: Record "Fattura Header" temporary)

Begin

//--Code to add
    IsHandled := false;
    OnBeforePopulateOrderData(TempFatturaLine, TempFatturaHeader, TempXMLBuffer, IsHandled);
    if IsHandled then
        exit;
//-- End Code to Add
...
end;

Thanks for reporting this. We agree, and we’ll publish a fix asap, either in an update for the current version or in the next major release. Please do not reply to this, as we do not monitor closed issues. If you have follow-up questions or requests, please create a new issue where you reference this one.


tryceratops sometimes fails to create .tryceratops-errors.log, raising FileNotFoundError when checking

Thanks for sharing this work. Interesting idea for a linter!

When ran from a pre-commit hook as a local hook:
repos:
  - repo: local
    hooks:
      - id: tryceratops
        name: tryceratops
        entry: tryceratops
        language: system
        types: [python]

and tryceratops-errors.log has not been created yet, this is raised at each check:
Traceback (most recent call last):
  File "/Users/pawlu/Documents/personal/nbpreview/.nox/pre-commit/bin/tryceratops", line 8, in <module>
    sys.exit(main())
  File "/Users/pawlu/Documents/personal/nbpreview/.nox/pre-commit/lib/python3.9/site-packages/tryceratops/__main__.py", line 62, in main
    entrypoint(prog_name="tryceratops")
  File "/Users/pawlu/Documents/personal/nbpreview/.nox/pre-commit/lib/python3.9/site-packages/click/core.py", line 829, in __call__
    return self.main(*args, **kwargs)
  File "/Users/pawlu/Documents/personal/nbpreview/.nox/pre-commit/lib/python3.9/site-packages/click/core.py", line 782, in main
    rv = self.invoke(ctx)
  File "/Users/pawlu/Documents/personal/nbpreview/.nox/pre-commit/lib/python3.9/site-packages/click/core.py", line 1066, in invoke
    return ctx.invoke(self.callback, **ctx.params)
  File "/Users/pawlu/Documents/personal/nbpreview/.nox/pre-commit/lib/python3.9/site-packages/click/core.py", line 610, in invoke
    return callback(*args, **kwargs)
  File "/Users/pawlu/Documents/personal/nbpreview/.nox/pre-commit/lib/python3.9/site-packages/tryceratops/__main__.py", line 57, in entrypoint
    interface.present_and_exit()
  File "/Users/pawlu/Documents/personal/nbpreview/.nox/pre-commit/lib/python3.9/site-packages/tryceratops/interfaces.py", line 95, in present_and_exit
    self._delete_empty_logs()
  File "/Users/pawlu/Documents/personal/nbpreview/.nox/pre-commit/lib/python3.9/site-packages/tryceratops/interfaces.py", line 86, in _delete_empty_logs
    is_log_empty = os.path.getsize(log_file_path) == 0
  File<EMAIL_ADDRESS>line 50, in getsize
    return os.stat(filename).st_size
FileNotFoundError: [Errno 2] No such file or directory: '/Users/pawlu/Documents/personal/nbpreview/.tryceratops-errors.log'

Things work fine if the command is invoked directly through the terminal.

Hi @paw-lu 👋
Thanks for trying Tryceratops :)
I'll investigate it as soon as possible. Let me know if you find any other edge cases that may help debugging this issue.

I guess I found the issue, try to add require_serial: true, so:
  - repo: local
    hooks:
      - id: tryceratops
        name: tryceratops
        entry: tryceratops
        language: system
        require_serial: true
        types: [python]

It worked for me :)

Full context
Based on pre commit docs:  https://pre-commit.com/#new-hooks

(optional: default false) if true this hook will execute using a single process instead of in parallel. new in 1.13.0.

So your pre-commit was launching several processes in parallel, and tryceratops was deleting the log file in the middle of process. By sticking to just one process, the deletion only happens at the end, so it's safe.

Yeah this fixed all issue reported.
Thanks for the fix, and thanks again for sharing your work here!


Capstone 1

HTML + basic JavaScript Capstone - day 3
Hi good reviewer,

These are the changes proposed to the Capstone project:
For more detail refer to the README.md file.
Project requirements

Personalize the content of the page. Choose a topic that is different than the one in the original design.
Follow these design guidelines:

Colors.
Typography: font face, size and weight (we suggest using Lato as it is a free font similar to the one used in the original design).
Layout: composition and space between elements.
The pages should look almost identical to the original design. Small adjustments like text or image changes are acceptable.

Build only these 2 pages:

The home page.
The about page.
Each of these pages should have versions for 2 different screen sizes:

Mobile: up to 768px wide.
Desktop: 768px or wider.
Interactions

Links

The home page should have a link in the menu to the about page.
The logo in the header links to the home page.

Mobile menu

When the user clicks (or taps) the hamburger button on the header, the mobile menu appears over the page.
There are no guidelines for the mobile menu in the docs, but you should implement it so it is consistent with the design (colors, typography, spacings, etc.).
The mobile menu should have a close (X) button that closes the menu.

Dynamic page

The section "Featured speakers" should be created dynamically in JavaScript.
Use a JavaScript variable with the data about the speakers and use it when the page loads to create the HTML for this section dynamically.

Original design idea by Cindy Shin in Behance.

The Creative Commons license of the design requires that you give appropriate credit to the author. Therefore, you must do it in the README of your project.

Thank you Sebastián @smunozmo,

Linter errors where corrected.

It was my mistake.
the issue was:

url, src, and href to different files had a slash in the begining and in css files need two dots and slash.

Hi @andersonlebon
There is nothing else to say other than...
Thank youuuuuuuuuuuuuuuuuuuuuu


Rename files (Very Important)

Merge #422 #436 #433 #432 before merging this. (VERY IMPORTANT)
Type of Change

[x] Refactoring

Description
A lot of PRs are adding onto the system-setup section and conflicting with eachother due to making more files with numbers in their name, merging this and requesting (yet another rebase for files being changed in this PR) a name change on the added files will solve these conflicts.

Closing this. But if you see this Chris, please implement the changes proposed in this PR, AFTER you've cleared out all pull requests. @ChrisTitusTech


Add nanosvg package

I've followed this guide
step by step carefully. [Yes]

I've tested this package remotely and have excluded all broken builds.
Here is the links to the Travis/AppVeyor with status "All passed":

https://ci.appveyor.com/project/bkotzz/hunter/builds/20852865
https://travis-ci.com/bkotzz/hunter/builds/94033477

I have submitted CI configs to https://github.com/ingenue/hunter targeting pkg.template branch,
see this merged pull request https://github.com/ingenue/hunter/pull/304

My change will resolve this "New package" request: https://github.com/ruslo/hunter/issues/1651

Uploading:

https://travis-ci.org/ingenue/hunter/builds/466244126?utm_source=github_status&utm_medium=notification
https://ci.appveyor.com/project/ingenue/hunter/builds/20912165

Released: https://github.com/ruslo/hunter/releases/tag/v0.23.69


Implements [Feature Request] CustomPaint for drawPath #31

fixes #31

@ikbendewilliam can you please check this PR.

Thank you for your PR!
Code looks good, can you add a description in the readme for the argument? The same one as you've written in the code is good

Thank you for your PR! Code looks good, can you add a description in the readme for the argument? The same one as you've written in the code is good

Done.

Your formatting seems to have failed. Please run dart format . (might also be my mistake in a previous push, but if you run this it should be fixed)

Your formatting seems to have failed. Please run dart format . (might also be my mistake in a previous push, but if you run this it should be fixed)

Just did. Could it be due to the commented code ?
That I kept as an example for users.
flutter-custom-image-crop % dart format .
Formatted 18 files (0 changed) in 0.20 seconds.

Your formatting seems to have failed. Please run dart format . (might also be my mistake in a previous push, but if you run this it should be fixed)

Done.

Ah so it was my bad. Apologies

Release in progress. New version is 0.0.8


Icons in Settings Don't Show

Describe the bug
In the settings page, every icon is not showing except when you click on it.
Screenshots

This also occurs in server settings, as shown below.

Only these three icons are visible to me

All the aria-controls and most of the aria-label tags were removed for whatever reason. I've disabled all the icons for now, since it's possible that at least the aira-label will be re-added later.


[Windows] Address status/fix various flaky_on_windows tests

Commit Message: [Windows] Address status/fix various flaky_on_windows tests
Additional Description:

Correct listener_impl_test, fixes
TcpListenerImplTest.SetListenerRejectFractionIntermediate
These fixes reflect that the timing on windows is often less
synchronous than linux observations, due to the design of the
underlying socket stack.
In QuicHttpIntegrationTest, the MultipleQuicConnectionsWithBPF is
never relevant to Windows or macOS (and took a not-insignificant
amount of time per test case.)
Enable no-longer-failing tests (no failure observed in RBE or locally)
//test/extensions/grpc_credentials/file_based_metadata:integration_test
//test/extensions/transport_sockets/alts:tsi_handshaker_test
//test/integration:http2_flood_integration_test
//test/integration:http2_upstream_integration_test
//test/integration:overload_integration_test
//test/server:guarddog_impl_test

Co-authored-by: Sunjay Bhatia<EMAIL_ADDRESS>Co-authored-by: William A Rowe Jr<EMAIL_ADDRESS>Risk Level: Low (test enablement only)
Testing: Windows msvc-cl and clang-cl RBE and locally
Docs Changes: n/a
Release Notes: n/a
Platform Specific Features: n/a

@envoyproxy/windows-dev

LGTM


Props in Docs?

It might be helpful to read and add the props to the documentation.
Would be nice to pull these dynamically. Not sure what the best solution would be for this. Can probably add a macro to the original components and expose a method through a Cargo feature?

I agree. So far, my strategy has been to keep this aligned with the ReactJS and/or HTML names/structs of PatternFly. So that reading the docs of PatternFly, should make it easy to translate this into the Rust world.
However, sometimes things work differently in Rust, or Yew, or I just did it differently. So some proper, generated documentation might be pretty useful.
I mean, there are the source docs to: https://docs.rs/patternfly-yew/0.1.2/patternfly_yew/struct.Toast.html
However, most of the components don't have much explanation: https://docs.rs/patternfly-yew/0.1.2/patternfly_yew/struct.TextInputProps.html
I guess the structure is mostly the same. There are yew components, which has a property type. Which should have source code level documentation. Maybe that way, there could be some trait that can be implemented using a macro, which describes the component and its properties, sourcing the information from the source code level docs. And with that, it should be easy to create some interactive docs.
Contributions welcome :grin:

There is an (unstable) feature in rust doc for outputting the docs in a json format
We might be able to use that.
I had a play but couldn't get it to work. rustdoc src/lib.rs fails with errors for me.


Modification for-> There is a vulnerability in Jetty: Java based HTTP…

Modified the version as mentioned in the issue --> There is a vulnerability in Jetty: Java based HTTP/1.x, HTTP/2, Servlet, WebSocket Server 9.4.8.v20171121,upgrade recommended #948

I have signed the CLA.. will this PR get merged now ?

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.rai31218 seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.You have signed the CLA already but the status is still pending? Let us recheck it.

Hi @rai31218 ,
I apologize for the delay on this.  We moved the repository over to a non-profit owner, the Data Transfer Initiative, and we're now slowly going through a backlog of PRs and issues.  Part of moving the repository was changing the license/CLA for the project.  Can you sign the new one?
FYI, even with this signed, the PR approved and merged, we will still not be able to close issue #1086 because fully addressing the jetty security vulnerabilities requires upgrading to 9.3.39 or later (this PR upgrades jetty to 9.3.35)

Closing due to time passed and CLA issues.


[2.1rc]SqlException: Each GROUP BY expression must contain at least one column that is not an external reference.(translated with google)

Describe what is not working as expected.

EF2.1-rc1 generate wrong SQL when group by with anonymous class mixed with db properties and constant.

If you are seeing an exception, include the full exceptions details (message and stack trace).
Exception message: System.Data.SqlClient.SqlException:“Each GROUP BY expression must contain at least one column that is not an external reference." (translated to English)
Stack trace:

Steps to reproduce
Include a complete code listing (or project/solution) that we can run to reproduce the issue.
Partial code listings, or multiple fragments of code, will slow down our response or cause us to push the issue back to you to provide code to reproduce the issue.
public class Device{ int DeviceId {get;set;} }

                var tmp = ctx.Device.GroupBy(z => new { z.DeviceId, PlaceHolder = 1 })
                    .Select(d => d.Sum(d1 => d1.DeviceId))
                    .ToList();

The SQL generated is wrong, and can not be executed.
      SELECT SUM([z].[Device_ID])
      FROM [Device] AS [z]
      GROUP BY [z].[Device_ID], 1

And it should be some thing like
      SELECT SUM([t].[DeviceId])
      FROM (
          SELECT [d].[Device_ID] AS [DeviceId], 1 AS [PlaceHolder]
          FROM [Device] AS [d]
      ) AS [t]
      GROUP BY [t].[DeviceId], [t].[PlaceHolder]

Further technical details
EF Core version: (found in project.csproj or packages.config) 2.1.0-rc1/2.2.0-preview1-34228(myget)
Database Provider: (e.g. Microsoft.EntityFrameworkCore.SqlServer)Microsoft.EntityFrameworkCore.SqlServer
Operating system: win10-x64
IDE: (e.g. Visual Studio 2017 15.4)

@yyjdelete What is the reason for using "PlaceHolder = 1" like this?

@smitpatel to reference this from the other more general issue. We will fix this as part of doing that work.

In 3.1 we don't add constant/parameters into GroupBy clause. If they are used in projection, we can add them into projection directly.
Generated SQL for above case.
      SELECT SUM([d].[DeviceId])
      FROM [Device] AS [d]
      GROUP BY [d].[DeviceId]


Access Java Enum .name() when a .name property is defined

When attempting to access a Java Enum that has a .name property, the .name() method appears to be overwritten when using JPype. Both .name and toString() return "none" for Slot.NONE. Is there anyway to return the Enum's name in this instance? ie. Slot.NONE -> "NONE". A simplified example of this is provided below (actual file available here).
public enum Slot {
  NONE("none");

  public final String name;

  Slot(String name) {
    this.name = name;
  }
}

from my.jar import Slot

Slot.NONE.name  # returns "none"
Slot.NONE.toString()  # returns "none"

Adapting the information I found on this SO post, I was able to fetch the desired method with the code below.
name_method = [method for method in Slot.class_.getMethods() if method.getName() == "name"][0]
name_method.invoke(Slot.NONE)  # returns "NONE"

There is something wrong with your example.  When I tested it with "toString()" I got "NONE".  Your class must be overrided both name() and toString().
Assuming that the issue is just that "name" is not currently accessible (because it was a method in parent and is a field in the child) you can just call the parent method directly.
import jpype
import jpype.imports
jpype.startJVM(classpath=".")
import java
import java.lang.Enum

# Get the misbehaving class
Slot = jpype.JClass("Slot")

# Get the parent class name method (we can do this by reflection if there were some horrible class with both fields and methods with the same symbol)
name = java.lang.Enum.name

# Call the method with an explicit "this"
print(Slot.NONE) # ==> prints "none"
print(str(Slot.NONE)) # ==> prints "none"
print(Slot.NONE.toString()) # ==> prints "none"
print(name(Slot.NONE))  #  ==> prints "NONE"

I guess we can look over the possibility of doing better on collisions between methods and fields in the class builder process.   In Java you can have fields that have the exact same identifier as methods.  In those cases the method should hide the method.
I did some testing and all the cases that I ran the method always hid the field.   But your case in which the parent declared the method but the child declared the field the conflict resolver failed to resolve it resulting in the method being hidden.   So there may be an issue with the conflict resolver failing to check the base classes before deciding to send a field to the Python type description.
Either way the solution I sent should work.


Allow system account chat to be listed in LHN, fix chat icons

Details
UI fixes for the system DM
Fixes the participants list, to make sure the title of the chat is just "Expensify" and the icon is only that of notifications@
Fixed Issues
$
PROPOSAL:
Tests / QA

Create a new account
When the onboarding modal opens, make sure that the report showing in the background is not the system DM
Choose any of the onboarding options
Find and open your system DM
Make sure it just shows the title as "Expensify", the text as "Welcome! Let's get you set up", without additional suggestions to create tasks and money requests
Make sure there is no "Join" button in the header

[x] Verify that no errors appear in the JS console

PR Author Checklist

[x] I linked the correct issue in the ### Fixed Issues section above
[x] I wrote clear testing steps that cover the changes made in this PR

[x] I added steps for local testing in the Tests section
[x] I added steps for the expected offline behavior in the Offline steps section
[x] I added steps for Staging and/or Production testing in the QA steps section
[x] I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
[x] I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
[x] I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).

[x] I included screenshots or videos for tests on all platforms
[x] I ran the tests on all platforms & verified they passed on:

[x] Android: Native
[x] Android: mWeb Chrome
[x] iOS: Native
[x] iOS: mWeb Safari
[x] MacOS: Chrome / Safari
[x] MacOS: Desktop

[x] I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
[x] I followed proper code patterns (see Reviewing the code)

[x] I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
[x] I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
[x] I verified that comments were added to code that is not self explanatory
[x] I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
[x] I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method

[x] If any non-english text was added/modified, I verified the translation was requested/reviewed in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:

[x] I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
[x] I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
[x] I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
[x] I verified the JSDocs style guidelines (in STYLE.md) were followed

[x] If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
[x] I followed the guidelines as stated in the Review Guidelines
[x] I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
[x] I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
[x] I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
[x] I verified that if a function's arguments changed that all usages have also been updated correctly
[x] If any new file was added I verified that:

[x] The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory

[x] If a new CSS style is added I verified that:

[x] A similar style doesn't already exist
[x] The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))

[x] If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
[x] If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
[x] If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
[x] If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
[x] If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:

[x] I verified that all the inputs inside a form are aligned with each other.
[x] I added Design label and/or tagged @Expensify/design so the design team can review the changes.

[x] If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
[x] If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari
https://github.com/Expensify/App/assets/16747822/b9129af7-902e-4c07-8ca5-80cf8e537d86

MacOS: Desktop

Popped a hold in the title as per here: https://expensify.slack.com/archives/C036QM0SLJK/p1715360388894099?thread_ts=1715336603.190319&cid=C036QM0SLJK

Reviewer Checklist

[ ] I have verified the author checklist is complete (all boxes are checked off).
[ ] I verified the correct issue is linked in the ### Fixed Issues section above
[ ] I verified testing steps are clear and they cover the changes made in this PR

[ ] I verified the steps for local testing are in the Tests section
[ ] I verified the steps for Staging and/or Production testing are in the QA steps section
[ ] I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
[ ] I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)

[ ] I checked that screenshots or videos are included for tests on all platforms
[ ] I included screenshots or videos for tests on all platforms
[ ] I verified tests pass on all platforms & I tested again on:

[ ] Android: Native
[ ] Android: mWeb Chrome
[ ] iOS: Native
[ ] iOS: mWeb Safari
[ ] MacOS: Chrome / Safari
[ ] MacOS: Desktop

[ ] If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
[ ] I verified proper code patterns were followed (see Reviewing the code)

[ ] I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
[ ] I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
[ ] I verified that comments were added to code that is not self explanatory
[ ] I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
[ ] I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
[ ] I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
[ ] I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
[ ] I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
[ ] I verified the JSDocs style guidelines (in STYLE.md) were followed

[ ] If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
[ ] I verified that this PR follows the guidelines as stated in the Review Guidelines
[ ] I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
[ ] I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
[ ] I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
[ ] If a new component is created I verified that:

[ ] A similar component doesn't exist in the codebase
[ ] All props are defined accurately and each prop has a /** comment above it */
[ ] The file is named correctly
[ ] The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
[ ] The only data being stored in the state is data necessary for rendering and nothing else
[ ] For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
[ ] Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
[ ] All JSX used for rendering exists in the render method
[ ] The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions

[ ] If any new file was added I verified that:

[ ] The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory

[ ] If a new CSS style is added I verified that:

[ ] A similar style doesn't already exist
[ ] The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)

[ ] If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
[ ] If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
[ ] If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
[ ] If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
[ ] If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:

[ ] I verified that all the inputs inside a form are aligned with each other.
[ ] I added Design label and/or tagged @Expensify/design so the design team can review the changes.

[ ] If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
[ ] If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
[ ] I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

MacOS: Desktop

Is there something I must do for the system chat to appear? I created a new account and can only see the following:
https://github.com/Expensify/App/assets/30054992/29df97e8-f5f8-46ec-be2a-71009c679708

Is https://github.com/Expensify/Auth/pull/10739 merged?

Clarified here.

** Bug **
System room name is missing in the RHN

Also, do we need private notes here?

BUG
Clicking on Expensify shows a not found error.
https://github.com/Expensify/App/assets/30054992/5132d4a6-80f5-4324-aeff-f1474a86030c

System room name is missing in the RHN
Clicking on Expensify shows a not found error.

Nice, thanks for catching those!

Also, do we need private notes here?

Hmm, I'm not sure, actually. @trjExpensify @francoisl, do you have thoughts about whether or not to include private notes in this chat?

Also, do we need private notes here?

Hmm, I'm not sure, actually. @trjExpensify @francoisl, do you have thoughts about whether or not to include private notes in this chat?

I don't have a strong opinion on this, though I don't see a reason to hide them.

Clicking on Expensify shows a not found error.

From this PR (https://github.com/Expensify/App/pull/35385/) it seems like we don't want to display the profile page for notifications@ so why don't we just update the report welcome text as follows?

Updated!

Is there something I must do for the system chat to appear? I created a new account and can only see the following:

It's intentional that it doesn't show up in the LHN immediately but is findable by search

do you have thoughts about whether or not to include private notes in this chat?

Yeah, we can skip for systems chats.

:hand: This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

🚀 Deployed to production by https://github.com/Julesssss in version: 1.4.79-11 🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
success ✅

🕸 web 🕸
success ✅

This Pr caused issue where restricted expensify accounts where able to be added to group chat.
More information here https://github.com/Expensify/App/issues/43841#issuecomment-2175304751


chore: Remove unused com.google.code.findbugs:jsr305

Checklist

[x] the contributor license agreement is signed
[x] commit message follows commit guidelines

Description of change

It would appear this may have just been added from conversion of the old
Ivy setup which didn't do transitive dependencies (so all had to be
managed explicitly in XML files). Having removed it, all still built and
ran via sbt cleanrun.
Done in response to https://github.com/openequella/openEQUELLA/pull/1892

Yes, it would be nice to get spotbugs in. :)


Redis executor for languages without support for the component model

The Redis trigger implemented in #155 can be used from languages with support for the WebAssembly component model.
Do we want to have another executor for languages without support for the component model?
This would be something similar to Wagi, where the request data would be passed through environment variables and standard input, and the response through the standard output.
This would enable all programming languages that compile to WASI to have support for building Redis triggered components.

We have not had traction for this issue, closing.


How do you initiate this?  I can't even replicate the demo

I am having a terrible time with this.  How do you properly initiate this to load?  the documentation is sparse.

Make sure you have all the javascript and css file paths called. Then it's as simple as adding .timepicker or .datepicker to a select input. Then call $('.timepicker').pickatime(); or $('.datepicker').pickadate(); This will initiate the input with the default settings.

I think there's a bug in 3.5.5 that could be causing your issues. Since updating to 3.5.5 from 3.5.4, the initializer is no longer working.

It looks like the check for transitions is causing issues for us.
https://github.com/amsul/pickadate.js/blob/master/lib/picker.js#L26. Maybe it has something to do with the compressed version?

I also have no clue, what are the javascript and css files I need to add in the . After downloading source, there is 100+ files. It would be just megastupid, if I need to call them all. Would be absolutely normal to add some simple lines of code as a boilerplate.

Replace [path to pickadate folder] with your path.
<!doctype html>
<html>
<head>
<meta charset="UTF-8">
<meta http-equiv="cache-control" content="no-cache">

<title>basic pickadate datepicker</title>
<link href="[path to pickadate folder]/lib/themes/default.css" rel="stylesheet" id="theme_base">
<link href="[path to pickadate folder]/lib/themes/default.date.css" rel="stylesheet" id="theme_date">

<!--[if lt IE 9]>
  <script>document.createElement('section')</script>
<![endif]-->
</head>

<body>
<label> input something here: </label>
<input
      id=""
      name=""
      class="datepicker"
      type="text"

        placeholder="Test"

      >
<script src="[path to jquery, change to match your version or use the google version]/jquery-1.11.2.min.js"></script><!-- latest available here: http://jquery.com/download/ -->
<script src="[path to pickadate folder]/lib/picker.js"></script>
<script src="[path to pickadate folder]/lib/picker.date.js"></script>
<script src="[path to pickadate folder]/lib/legacy.js"></script>

<script>
// Initialize the basic datepicker

$( '.datepicker' ).pickadate({

    // Work-around for some mobile browsers clipping off the picker.
    onOpen: function() { $('pre').css('overflow', 'hidden') },
    onClose: function() { $('pre').css('overflow', '') }
})
</script>

</body>
</html>

Such questions belong on StackOverflow: http://stackoverflow.com/search?q=pickadate
Guidelines.
Cheers.


Switching from code to Python Interactive window causes Copy text command to break

Bug: Notebook Editor, Interactive Window, Editor cells
Steps to cause the bug to occur

Create a Python file with one cell that outputs some text
Execute the cell
Select and copy the text from the Python Interactive window - paste it somewhere - it copied fine
Change the selection in the code window (preferable to a line with some content)
Select and copy other text from the Python Interactive window - paste it somewhere - it copied the text from the code window rather than the Python Interactive window

Actual behavior
Sometimes, when the active window is the Python Interactive window, the text selected in the code window gets copied when I hit Ctrl + C instead of the text in the active window.

Expected behavior
Text selected in the active window will be copied when I hit Ctrl + C.
Your Jupyter and/or Python environment

Jupyter server running: Local
Extension version: v2020.7.94776
VS Code version: 1.47.2 (system setup; commit: 17299e413d5590b14ab0340ea477cdd86ff13daf)
Setting python.jediEnabled: false
Setting python.languageServer: Microsoft
Python and/or Anaconda version: CPython 3.7.4
OS: Windows_NT x64 10.0.18362
Virtual environment: none (system install)

Developer Tools Console Output
No output

Thanks for the bug report! I was able to repro this. We'll discuss this at our upcoming triage.

Thanks for the reply. Note that this only when switching between window groups. If the Python Interactive Window is in the same window group as another plain code editor, the bug doesn't happen.
I'm pretty sure this bug only showed up after upgrading VS Code. I'm not sure what my previous version was.

Thanks for reporting this. I am not able to copy any text out of the Interactive Output Window. This is very annoying and a big showstopper while using VSCode for Data Science tasks. I hope you can prioritize this with a quick fix.

A partial workaround - put a regular code editor in the same window group. Once that is done, and the cursor is first placed in that code editor, you'll be able to copy. If you need, I can post a gif.

Dupe of #13017

This appears to be have been resolved in Insiders 1.48.0. Would you mind giving it a try there and letting us know if the bug persists? 😊

@joyceerhl I just tried weekly insiders version (can't find number) and it's fixed!


Terms Issue

The Terms and Conditions link just takes you right back to the login page.

Right, but you need to make the Terms and Conditions page or maybe a modal for it to work.


Material's ThemeData.scrollbarTheme is not applied when using CupertinoScrollBehavior for scrollable view

Steps to reproduce
My application is using MaterialApp. I want to have a customization scrollbar so I declared scrollbarTheme in ThemeData. Below are the minimal steps:

Wrap ListView or SingleChildScrollView by ScrollConfiguration with CupertinoScrollBehavior behavior
Apply scrollbarTheme in Material's ThemeData and see all custom theme data does not impact Scrollbar

The issue will not happen when ScrollConfiguration.behavior is MaterialScrollBehavior() or without declaring ScrollConfiguration.behavior.
Certain things I'm wondering about:

Is it considered unsuitable to utilize CupertinoScrollBehavior in Material Theme?
Should I suggest adding scrollbarTheme to CupertinoThemeData, then use CupertinoTheme instead of Material Theme?

Expected results
For this specific issue, I would expect we can use CupertinoScrollBehavior with scrollbarTheme.
If this is intentional behavior, perhaps should we add documentation for ScrollConfiguration.behavior so that users may be aware of it?
Actual results
Scrollbar is showing its default theme, scrollbarTheme is ignored.
Code sample
Code sample
import 'package:flutter/cupertino.dart';
import 'package:flutter/material.dart';

void main() {
  runApp(
    const MaterialApp(
      home: Home(),
    ),
  );
}

class Home extends StatelessWidget {
  const Home({
    super.key,
  });

  @override
  Widget build(BuildContext context) {
    return Scaffold(
      body: Theme(
        data: ThemeData(
          scrollbarTheme: ScrollbarThemeData(
            thumbColor: WidgetStateProperty.all(Colors.red),
            thickness: WidgetStateProperty.all(2.0),
            trackVisibility: WidgetStateProperty.all(true),
            thumbVisibility: WidgetStateProperty.all(true),
          ),
        ),
        child: ScrollConfiguration(
          behavior: const CupertinoScrollBehavior(),
          child: ListView(
            children: List.generate(
              100,
              (index) => SizedBox(
                height: 100,
                child: Center(
                  child: Text(
                    index.toString(),
                    style: const TextStyle(
                      color: Colors.black,
                      fontSize: 20,
                    ),
                  ),
                ),
              ),
            ),
          ),
        ),
      ),
    );
  }
}

Screenshots or Video

Screenshots / Video demonstration

actual result (with CupertinoScrollBehavior)
expected result (without CupertinoScrollBehavior)

Logs
Logs
[Paste your logs here]

Flutter Doctor output
Doctor output
[✓] Flutter (Channel stable, 3.24.3, on macOS 15.0 24A335 darwin-x64, locale en-VN)
    • Flutter version 3.24.3 on channel stable at /Users/huynq/Documents/GitHub/flutter
    • Upstream repository https://github.com/flutter/flutter.git
    • Framework revision 2663184aa7 (3 weeks ago), 2024-09-11 16:27:48 -0500
    • Engine revision 36335019a8
    • Dart version 3.5.3
    • DevTools version 2.37.3

[✓] Android toolchain - develop for Android devices (Android SDK version 35.0.0)
    • Android SDK at /Users/huynq/Library/Android/sdk
    • Platform android-35, build-tools 35.0.0
    • ANDROID_HOME = /Users/huynq/Library/Android/sdk
    • Java binary at: /Applications/Android Studio.app/Contents/jbr/Contents/Home/bin/java
    • Java version OpenJDK Runtime Environment (build 17.0.11+0-17.0.11b1207.24-11852314)
    • All Android licenses accepted.

[✓] Xcode - develop for iOS and macOS (Xcode 16.0)
    • Xcode at /Applications/Xcode.app/Contents/Developer
    • Build 16A242d
    • CocoaPods version 1.15.2

[✓] Chrome - develop for the web
    • Chrome at /Applications/Google Chrome.app/Contents/MacOS/Google Chrome

[✓] Android Studio (version 2024.1)
    • Android Studio at /Applications/Android Studio.app/Contents
    • Flutter plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/9212-flutter
    • Dart plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/6351-dart
    • android-studio-dir = /Applications/Android Studio.app/
    • Java version OpenJDK Runtime Environment (build 17.0.11+0-17.0.11b1207.24-11852314)

[✓] Android Studio (version 2024.2)
    • Android Studio at /Applications/Android Studio Ladybug.app/Contents
    • Flutter plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/9212-flutter
    • Dart plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/6351-dart
    • Java version OpenJDK Runtime Environment (build 21.0.3+-79915915-b509.11)

[✓] IntelliJ IDEA Community Edition (version 2024.2.3)
    • IntelliJ at /Applications/IntelliJ IDEA CE.app
    • Flutter plugin version 81.1.3
    • Dart plugin version 242.22855.32

[✓] VS Code (version 1.93.1)
    • VS Code at /Applications/Visual Studio Code.app/Contents
    • Flutter extension version 3.98.0

[✓] Connected device (2 available)
    • macOS (desktop) • macos  • darwin-x64     • macOS 15.0 24A335 darwin-x64
    • Chrome (web)    • chrome • web-javascript • Google Chrome 129.0.6668.89

[✓] Network resources
    • All expected network resources are available.

• No issues found!

[!] Flutter (Channel master, 3.26.0-1.0.pre.353, on macOS 15.0 24A335 darwin-x64, locale en-VN)
    • Flutter version 3.26.0-1.0.pre.353 on channel master at /Users/huynq/Documents/GitHub/flutter_master
    ! Warning: `flutter` on your path resolves to /Users/huynq/Documents/GitHub/flutter/bin/flutter, which is not inside your current Flutter SDK checkout at /Users/huynq/Documents/GitHub/flutter_master. Consider adding /Users/huynq/Documents/GitHub/flutter_master/bin to the front of your path.
    ! Warning: `dart` on your path resolves to /Users/huynq/Documents/GitHub/flutter/bin/dart, which is not inside your current Flutter SDK checkout at /Users/huynq/Documents/GitHub/flutter_master. Consider adding /Users/huynq/Documents/GitHub/flutter_master/bin to the front of your path.
    • Upstream repository https://github.com/flutter/flutter.git
    • Framework revision 389846308a (3 hours ago), 2024-10-03 21:52:22 -0400
    • Engine revision 66d397dff8
    • Dart version 3.6.0 (build 3.6.0-317.0.dev)
    • DevTools version 2.40.0-dev.2
    • If those were intentional, you can disregard the above warnings; however it is recommended to use "git" directly to perform update checks and upgrades.

[✓] Android toolchain - develop for Android devices (Android SDK version 35.0.0)
    • Android SDK at /Users/huynq/Library/Android/sdk
    • Platform android-35, build-tools 35.0.0
    • ANDROID_HOME = /Users/huynq/Library/Android/sdk
    • Java binary at: /Applications/Android Studio.app/Contents/jbr/Contents/Home/bin/java
    • Java version OpenJDK Runtime Environment (build 17.0.11+0-17.0.11b1207.24-11852314)
    • All Android licenses accepted.

[✓] Xcode - develop for iOS and macOS (Xcode 16.0)
    • Xcode at /Applications/Xcode.app/Contents/Developer
    • Build 16A242d
    • CocoaPods version 1.15.2

[✓] Chrome - develop for the web
    • Chrome at /Applications/Google Chrome.app/Contents/MacOS/Google Chrome

[✓] Android Studio (version 2024.1)
    • Android Studio at /Applications/Android Studio.app/Contents
    • Flutter plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/9212-flutter
    • Dart plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/6351-dart
    • android-studio-dir = /Applications/Android Studio.app
    • Java version OpenJDK Runtime Environment (build 17.0.11+0-17.0.11b1207.24-11852314)

[✓] Android Studio (version 2024.2)
    • Android Studio at /Applications/Android Studio Ladybug.app/Contents
    • Flutter plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/9212-flutter
    • Dart plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/6351-dart
    • Java version OpenJDK Runtime Environment (build 21.0.3+-79915915-b509.11)

[✓] IntelliJ IDEA Community Edition (version 2024.2.3)
    • IntelliJ at /Applications/IntelliJ IDEA CE.app
    • Flutter plugin version 81.1.3
    • Dart plugin version 242.22855.32

[✓] VS Code (version 1.93.1)
    • VS Code at /Applications/Visual Studio Code.app/Contents
    • Flutter extension version 3.98.0

[✓] Connected device (2 available)
    • macOS (desktop) • macos  • darwin-x64     • macOS 15.0 24A335 darwin-x64
    • Chrome (web)    • chrome • web-javascript • Google Chrome 129.0.6668.90

[✓] Network resources
    • All expected network resources are available.

! Doctor found issues in 1 category.

The CupertinoScrollBehavior creates a CupertinoScrollbar, which should not respond to Material themes.


4.x: Optimize Concat(IObservable<IObservable>)

This PR implements the Concat(IObservable<IObservable<T>>) directly in an inlined (less allocation and indirection) and lock-free fashion. (The original was delegated to Merge(sources, 1) which I'd assume has more overhead because dealing with an arbitrary max-concurrency requires a lot of work in Rx.NET too.)
I didn't add extra unit tests as this code is meant to be a drop-in replacement of the previous delegated version and is supposed to be well tested already on its own, right?
There is one scenario that I'm not sure about: where both the outer and the current inner sources signal an OnError, it is not expected the outer error to stop the inner sequence immediately, and whoever's error wins, that is signaled on the boundary between two inner sources. Either I happened to implement this replacement correctly, or the behavior is not verified or specified for this operator.

There are some slight improvements over the standard implementation:
Cross-map performance:

(milliseconds, smaller is better, green=improvement)
var outer = new int[100000 / times];
var inner = new int[times];

concat = outer.ToObservable().Select(v => inner.ToObservable()).Concat();

concatMany = outer.ToObservable().Select(v => inner.ToObservable()).ConcatMany();

BenchmarkDotNet=v0.10.14, OS=Windows 7 SP1 (6.1.7601.0)
Intel Core i7-4770K CPU 3.50GHz (Haswell), 1 CPU, 8 logical and 4 physical cores

Frequency=3418046 Hz, Resolution=292.5648 ns, Timer=TSC
  [Host]     : .NET Framework 4.6.1 (CLR 4.0.30319.42000), 32bit LegacyJIT-v4.7.2558.0
  Job-YSPJNA : .NET Framework 4.6.1 (CLR 4.0.30319.42000), 32bit LegacyJIT-v4.7.2558.0

IterationTime=1.0000 s  LaunchCount=1  TargetCount=5  WarmupCount=5

     Method |      N |      Mean |     Error |    StdDev |
----------- |------- |----------:|----------:|----------:|
     Concat |      1 | 301.05 ms | 1.6440 ms | 0.4270 ms |
 ConcatMany |      1 | 286.74 ms | 2.6475 ms | 0.6877 ms |
     Concat |     10 |  72.51 ms | 1.3039 ms | 0.3387 ms |
 ConcatMany |     10 |  72.86 ms | 0.9030 ms | 0.2345 ms |
     Concat |    100 |  50.71 ms | 0.6166 ms | 0.1602 ms |
 ConcatMany |    100 |  49.52 ms | 0.9418 ms | 0.2446 ms |
     Concat |   1000 |  47.70 ms | 0.6130 ms | 0.1592 ms |
 ConcatMany |   1000 |  46.84 ms | 0.2921 ms | 0.0759 ms |
     Concat |  10000 |  47.25 ms | 0.6051 ms | 0.1572 ms |
 ConcatMany |  10000 |  46.66 ms | 0.8227 ms | 0.2137 ms |
     Concat | 100000 |  48.09 ms | 1.0049 ms | 0.2610 ms |
 ConcatMany | 100000 |  46.61 ms | 0.6448 ms | 0.1675 ms |


Fix deprecation introduced in ActiveRecord 5.1.0.beta1. Closes #257

Added ruby 2.4 and Rails 5.1.0.beta1 to test matrix. All tests are passing. Also, the change was tested in a live application.
Thanks to @brendon for guidance! 😃

Looks good @CvX :) @swanandp, are you happy for me to merge this? (or you can if you want to) :)

Merged. Thanks @CvX !

Hi, have to dig up this PR because I've noticed that the code I committed and which ended up in the repository is incorrect.
Version conditional used here: https://github.com/swanandp/acts_as_list/pull/259/files#diff-708784f0c89e5cdbdd54e18d2b2243d1R406 is wrong for future AR versions: 6.0, 7.0, etc.
We can either correct the conditional (ActiveRecord::VERSION::MAJOR > 5 || (ActiveRecord::VERSION::MAJOR == 5 && ActiveRecord::VERSION::MINOR >= 1)) or we could use Gem::Version as mentioned before (like this  https://github.com/CvX/acts_as_list/commit/0e7f24f29df8003f42ddb29971c04e5a8b7081be)
Please let me know which way do you prefer and I'll submit a PR.
Sorry for the inconvenience.

Thanks @CvX, I've pushed a fix for that to master :) Thanks for picking it up! :)


Add 'leaving a column from export' form element

From @brodecva on September 2, 2016 11:25
Story at https://grips.semantic-web.at/x/sBZsB .
Copied from original issue: odalic/sti#139

@brodecva  Moved to 5th iter

Waits for https://github.com/odalic/sti/issues/142 .

Will not be implemented


Add the TLS struct support for service operators

The service operators will have TLS struct type to pass in the reference to the certificates secrets as well as the option to add multiple CA certs.
Jira: OSP-26846

Pending changes when #345  is merged.

I think we should also squash all the commits into one


Angular: Node/Link color tables appear/disappear in different views

When a new view is selected, the node color table appears in the new view. If you go back to the 2D network view, the link color table disappears. If you close the node color table and open a new view, it appears again in the opened views.
To Reproduce

Select "Continue with Sample Dataset" in the Angular launch page. The network renders correctly. Note the node and link color tables.

Select 'Table' (or any of the other views) and see the node color table.

Go back to the 2D network view and see that the link color table is missing.

Close the node color table in any of the views and select another view tab or open a new view. The node color table appears again.

Go to 'Settings' and select to show link color table but it will not show up.

Expected behavior

The link color table should appear in the 2D network after changing views unless the user closes it.
If user closes a color table, it shouldn't appear in any of the views unless the user selects to show the color table again.
Color tables are more useful for 2D network, map and phylogenetic tree views. It's ok if they show up automatically in those views. If user closes them, they shouldn't reappear.
Can we code for color tables to do not appear in table and alignment views?

Fixed bug that caused link table to not reappear in some situations. Also node color table and link color table automatically show and hide based on view selected and value of color node/links by.
Currently, if a user hides a table in 2D Network then clicks another view where the table is presents (such as going from 2D -> map, going from 2D -> table -> 2D) then the table reappears. May want to change this in the future.


rbac: add unified matcher for RBAC filters

Title: rbac: add unified matcher for RBAC filters
Description:
There are tons of issues marked as help wanted around RBAC. Some of them asking for new matchers (#4455, #6193, #15631), some of them requesting a unified, flexible and efficient matching mechanism for RBAC (#5569, #7918, #9376, #11832, #12285, #18064). Now, we already have a unified matching API, which can match network inputs (IP, port, SNI, protocol) and HTTP inputs (headers and trailers), almost everything what RBAC can handle now, with different matchers (list, map, trie) in any combinations.
There are some works to do:

Adapt connection/headers/stream info-based matcher. We currently do not have matchers for stream info like metadata and authentication, so we have to add one.
Add a custom matcher for CEL.
Add unified matcher for RBAC filters

I think it is a good first step to polish RBAC filters, we can merge connection/headers/stream info-based rules and CELs into an elegant and simple match tree, and we can also benefit from unified matcher and custom matchers, avoiding writing complex lengthy configurations and over and over again matching in the codes.

I may help to add unified matcher and there are still a lot of work to do in the future for RBAC like a flexible action.
cc @htuch

I have done some code works but I also have some comments on my exploration,

I would like to add a matcher in envoy.extensions.filters.network.rbac.v3.RBAC and envoy.extensions.filters.network.rbac.v3.RBAC, and the syntax of rules will be changed (see the code block below). It is obviously that the mapping relation action->policy name->policy will be changed to matcher->matcher name + action.
There will be no difference between permissions and principals (also see the code block below).
Action will be reconstructed, and there will be no LOG action. The LOG behavior allows matched requests to set dynamic metadata to true and unmatched to false, but in the unified matcher, an on_no_match field can catch all unmatched requests.
Not all network inputs can be supported in RBAC network filter. The network matching data and inputs require a ConnectionSocket while a network filter can only provide a Connection, SourceType, TransportProtocol and ApplicationProcol cannot be supported. @kyessenov do you have any workarounds?

May I ask for your thoughts on these changes? @htuch
http_filters:
- name: envoy.filters.http.rbac
  typed_config:
    "@type": type.googleapis.com/envoy.extensions.filters.http.rbac.v3.RBAC
    # rules:
    #   action: ALLOW
    #   policies:
    #     "deny-http":
    #       permissions:
    #       - destination_port: 80
    #       principals:
    #       - any: true
    matcher:
      matcher_tree:
        input:
          name: envoy.matching.inputs.source_port
          typed_config:
            "@type": type.googleapis.com/envoy.extensions.matching.common_inputs.network.v3.SourcePortInput
        exact_match_map:
          map:
            "80":
              action:
                name: action # This name is the registered name for registry factory lookup.
                typed_config:
                  "@type": type.googleapis.com/envoy.config.rbac.v3.Action
                  name: deny-http # Alternative of policy name.
      on_no_match: # If on_no_match is not set, deny all unmatched requests.
        action:
          name: action
          typed_config:
            "@type": type.googleapis.com/envoy.config.rbac.v3.Action
            name: allow-all
            allow: true
            log: true # LOG behavior change

Re: network inputs. Yes, I'm aware. We can implement those inputs for HTTP
context using StreamInfo. I'll take a stab at that soon-ish.
On Thu, Apr 7, 2022 at 11:22 PM Xie Zhihao @.***> wrote:

I have done some code works but I also have some comments on my
exploration,

I would like to add a matcher in
envoy.extensions.filters.network.rbac.v3.RBAC and
envoy.extensions.filters.network.rbac.v3.RBAC, and the syntax of rules
will be changed (see the code block below). It is obviously that the
mapping relation action->policy name->policy will be changed to matcher->matcher
name + action.
There will be no difference between permissions and principals
(also see the code block below).
Action will be reconstructed, and there will be no LOG action. The
LOG behavior allows matched requests to set dynamic metadata to true
and unmatched to false, but in the unified matcher, an on_no_match
field can catch all unmatched requests.
Not all network inputs can be supported in RBAC network filter. The
network matching data and inputs require a ConnectionSocket while a
network filter can only provide a Connection, SourceType,
TransportProtocol and ApplicationProcol cannot be supported. @kyessenov
https://github.com/kyessenov do you have any workarounds?

May I ask for your thoughts on these changes? @htuch
https://github.com/htuch
http_filters:

name: envoy.filters.http.rbac
typed_config:
@.***": type.googleapis.com/envoy.extensions.filters.http.rbac.v3.RBAC
rules:
action: ALLOW
policies:
"deny-http":
permissions:
- destination_port: 80
principals:
- any: true
matcher:
matcher_tree:
input:
name: envoy.matching.inputs.source_port
typed_config:
@.": type.googleapis.com/envoy.extensions.matching.common_inputs.network.v3.SourcePortInput
exact_match_map:
map:
"80":
action:
name: action # This name is the registered name for registry factory lookup.
typed_config:
@.": type.googleapis.com/envoy.config.rbac.v3.Action
name: deny-http # Alternative of policy name.
on_no_match: # If on_no_match is not set, deny all unmatched requests.
action:
name: action
typed_config:
@.***": type.googleapis.com/envoy.config.rbac.v3.Action
name: allow-all
allow: true
log: true # LOG behavior change

—
Reply to this email directly, view it on GitHub
https://github.com/envoyproxy/envoy/issues/20623#issuecomment-1092482040,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/ACIYRRQFOPIU4YCDRW7STODVD7GBHANCNFSM5SHXOYXQ
.
You are receiving this because you were mentioned.Message ID:
@.***>

@htuch shall we make a small change, adding a matcher to the policy to provide with an alternative choice for policy matching which will not affect the "single action" mechanism,
rules:
  action: ALLOW
  policies:
    "policy-name":
      # permissions:
      # - destination_port: 80
      # principals:
      # - any: true
      matcher:
        matcher_tree:
          input:
            name: destination_port
            typed_config:
              '@type': type.googleapis.com/envoy.type.matcher.v3.DestinationPortMatchInput
          exact_match_map:
            map:
              "80":
                action:
                  name: action
                  typed_config:
                    '@type': type.googleapis.com/envoy.config.rbac.v3.RBACAction

or shall we make a big change, replacing the whole rules with matcher to support "multiple action"?
matcher:
  matcher_tree:
    input:
      name: destination_port
      typed_config:
        '@type': type.googleapis.com/envoy.type.matcher.v3.DestinationPortMatchInput
    exact_match_map:
      map:
        "80":
          action:
            name: action
            typed_config:
              '@type': type.googleapis.com/envoy.config.rbac.v3.RBACAction
              name: allow-http
              action: ALLOW
  on_no_match:
    action:
      name: action
      typed_config:
        '@type': type.googleapis.com/envoy.config.rbac.v3.RBACAction
        name: deny-by-default
        action: DENY

I think the second model is more flexible. I think the first was the result of deliberative consideration, CC @qiwzhang, so I'll let those folks weigh in. Also CC @wjtracey


office and terms listing switched from 2 wide to 3

Coverage increased (+0.009%) to 93.055% when pulling 38acd61cf1ee3ddade5f103b7ecd79c3191b007d on o-t-list into cddba3dd960342d9f36361881ac7e0abe7b130d7 on dev.


[Grow] Fix scroll on entered

Continuation of https://github.com/mui-org/material-ui/pull/12003
I discovered that when upgrading my project that uses large menus with scrolling, that the original fix did not solve the issue in the project. The transform on the Grow component was overriding the Menu's translateZ declaration.

Anyone having to do a workaround on this, you will need to apply a custom class to Paper that includes transform: scale(1,1) translateZ(0) !Important

@stephenway It looks good to me 👍

Sweet, thanks @oliviertassinari


Vendor odoc-parser

This PR vendors odoc-parser into the repo. This helps prevent the use of mdx in odoc's tests. In this I've vendored the latest release of odoc-parser, but once ocaml/odoc#973 is merged we'll want to adjust the script to point at the odoc repo rather than the odoc-parser repo.

to make it point to the odoc repo since the parser has been merged back.

More modification would be needed since the new AST has changed the code block node.
Moreover, one would want to use the new syntax for "output of code blocks". Indeed, it would fix a bug where an error in the execution leads to:
{[
  let f = 1 + "2"
]}```mdx-error
An expression of type int was expected, but got a string
```

which is not valid odoc code.

I think we should merge this as-is, release a version of mdx, then do the work to upgrade to the new parser API.

I agree with this plan.

Moreover, one would want to use the new syntax for "output of code blocks". Indeed, it would fix a bug where an error in the execution leads to:
{[
  let f = 1 + "2"
]}```mdx-error
An expression of type int was expected, but got a string

I had a look at it, did I miss something regarding the new syntax for the output of code blocks? this is not mentioned in the docs

More info is available here: https://github.com/ocaml-doc/odoc-parser/pull/17
I don't know if the new syntax is documented in doco master's branch, but it's normal that it is not in the doc for the released version!


Add mask_auto_correlations field to rfi_mask ranges

It indicates whether autocorrelations should be masked if they're
covered by any of the ranges.

The test data file changes are all just to add the new field.


community: update QuipLoader to support return text instead of html format

Description:

By default, the quip API return doc as html format, this PR is to support parse html as text to stripe html format.
change quip-api pip package to quipclient, since quip-api cannot be found.

@baskaryan, @eyurtsev, @hwchase17 mind help to take a look this PR ? I close old one https://github.com/langchain-ai/langchain/pull/15136. look forward to seeing this can be merged, one of my task is pending on this changes. Thanks.

@baskaryan, @eyurtsev, @hwchase17 mind help to take a look this PR ?

@baskaryan, @eyurtsev, @hwchase17 can someone help to take a look this PR ?


Update FAQ grid links

Heyo, in the process of making sure information is up to speed and trying to reduce some surface area for maintenance. Also eliminating our reliance on Zendesk. More info here if desired: https://paper.dropbox.com/doc/FAQ-Adjustments--BEzQrtcRcVoEDRnhDL1S3nQbAg-jliXyUknD93Q73G9IiNaX, but I have pulled out concrete changes and mapped them below.
The following changes are good with leads/Ryan.

Corresponding updates:
1.
Title: General Information
Description: Learn more about the user-owned internet on Bitcoin and the Stacks ecosystem
Link: https://stacks.co

Title: Stacks Token
Description: Stacks fuel apps and smart contracts on Bitcoin
Link: https://stackstoken.com/faq (this page will resolve to a fresh page of FAQs soon, but switch can be made ahead of that)

Title: Stacks Network
Description: Learn more about the network behind the user-owned internet on Bitcoin
Link: https://docs.blockstack.org/understand-stacks/overview

Title: Stacks Wallet
Description: Download and find resources about the Stacks Wallet by Hiro
Link: https://www.hiro.so/wallet

Title: Apps and Smart Contracts
Description: Developer, get started building
https://www.stacks.co/developers
Once that's done, maybe move the tiles around so that the order is 1, 5, 3, 2, 4

what's the urgency on this? I just checked and this change requires more than just updating markdown/content. This touches the integration with zendesk it seems, cc @aulneau

We should not need to touch Zendesk. I purposely avoid using any content from there going forward. These panels are now linking to outside resources vs. internal pages populating from ZenDesk. The FAQs that are being pulled in should just go away, eliminating any reliance on ZD

Right, I understand. The implementation in the docs is integrated with Zendesk and would need to be changed to just show static links. We'd probably have to rely on @aulneau to help

Yes that is correct -- there is some dev work here. I can work on this next week if that works for the timing.

I see! Works for me, thank you both!

Checking if it'll still be possible to get to this during the week - no huge issue if not, just trying to plan, thank you!

Bump, it's Thursday of my last week and hoping to get ZD totally shut down. Will we be able to knock these tiles out in the next couple days?

I can't help here, unfortunately. we need @aulneau to help - not sure if he can prioritize in the next few days.
@aulneau could you chime in? 🙏🏼

Hey @aulneau - running low on days I have Ryan around to help me finish this up, can we re-link those tiles before end of week?

@cuevasm Sorry more pressing things have taken my time. I don't think I can get to this this week. CC @andresgalante for visibility

Alright, it's been a couple weeks now and this seems like something maybe we should open up such that more folks can help make these changes so we can move more quickly on public-facing resources.
Not trying to harp, but this is some light text updates and changing out hyperlinks and should immediately clear up a ton of confusion and support requests.

Hi @cuevasm I understand that this is an easy fix, unfortunately, this is not the only fix he has to deal with, and with the restructuring of the Engineering team, he is being pushed in all directions.
Since this issue was open he has release major performance improvements to the Explorer, helped release delegation, performed a complete PR review of the alfa branch of the web wallet, and lead a fix to a security vulnerability (just to mention a few).
We have an understaffed team and at the moment Docs is not on Thomas' hands anymore since he moved to UX.
Having said that I'll make to get this fix out early next week and @alexkeating let's sync on how we can handle requests to Docs moving forward so we don't end up with simple fixes open for 2 weeks.

let me how on it

To be clear, I'm not questioning that a bunch of important work was done and I very much understand how understaffed things are. I think vs. just letting that keep being the case, I am calling it out so hopefully, we can address on a resource level, because as much as we're pulled in lots of directions, I can't be convinced something like this should take over 2 weeks. I say all this with love and appreciation and in hopes we can get you more help.
I am also not the one that looped in Thomas, I just made the ticket, I always leave it to ya'll how you want to staff

100% agreed. This should not have taken 2 weeks. Lesson learned and let's improve our process for next time


data loss on 115200 baudrate

I was checking my uart code. I realized that I have data loss over my serial port, I decided to impl uart read using Interrupt. As I am going to make my changes as a PR. Any advices or tips or help ?

Here is some prior art that didn't get merged: https://github.com/esp-rs/esp-idf-hal/pull/84. I would also take a look at the discussion, you might not need interrupts to avoid data loss.

Because you can use the much simple blocking read that the UART driver is supporting in the meantime. Blocking read is buffered, so it should work quite OK at high speeds.


hbase input support

any plans to add hbase input support?

Not planned at the moment, if anyone wishes to help write this it can be very helpful.


Null Resolution in GlOverlayFilter

I am using ExoPlayerFilter to show filters and Mp4Composer for rendering. Thank you so much for your libraries. They are awesome!
I am trying to insert an image in a video.
The error I get is this:
Attempt to invoke virtual method 'int com.daasuu.mp4compose.Resolution.width()' on a null object reference
I have obtained the same error using GlWatermarkFilter and using this example class:
import android.graphics.Bitmap
import android.graphics.Canvas
import com.daasuu.mp4compose.filter.GlOverlayFilter

class GlSticker(private val bitmap: Bitmap) : GlOverlayFilter() {

    override fun drawCanvas(canvas: Canvas) {
        canvas.drawBitmap(bitmap, 0f, 0f, null)
    }
}

Any idea to resolve the null pointer?

I guess it is the same error as https://github.com/MasayukiSuda/Mp4Composer-android/issues/1

I have seen the problem... It is due to inputResolution was not correctly set. The only thing there is to take into account is to ensure this parameter is set.

@GabrielMorenoIbarra where do we should set this?

Hi, @khurana3192. I did a pull request: https://github.com/MasayukiSuda/Mp4Composer-android/pull/24

Thank @GabrielMorenoIbarra :)


docs:update README.zh-CN.md

Codecov Report

Merging #106 into master will not change coverage.
The diff coverage is n/a.

@@          Coverage Diff          @@
##           master   #106   +/-   ##
=====================================
  Coverage     100%   100%
=====================================
  Files         115    115
  Lines        2255   2255
  Branches      393    393
=====================================
  Hits         2255   2255

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6a3a4b8...4586c88. Read the comment docs.

Thank you for PR @liushuangbill


Release1.0 corrections anj - exemple with UUID as id and correct EAN No in sender and receiver

Reviewed and accepted

Reviewed and accepted


Feature Request: Descriptor Support

Perhaps a question for @farfromrefug, but I'm going to take a stab at building out support for Descriptors, largely by comparing it to cordova-ble (https://github.com/evothings/cordova-ble) where I had a fair degree of success in the past.
Any guidance, thoughts, or feedback is welcome. (Or if it's super quick and I shouldn't bother) let me know.

@farfromrefug just a quick update here, I'm a little tentative to jump in as there's quite a lot of churn right now (and rightfully so! great work).
If this is a no-brainer for you, please don't let me hold you up.
But Descriptor support would be amazing, as it really informs Characteristics (by providing units, format, and human readable description).
Thanks again for the amazing work this last month.

@drewcovi the support is almost there. Need to write the discoverDescriptors first.
If you look discoverServices and discoverChararcteristics is already there.
If you want to add it, glad to see a PR!
Don't really have time to work on this right now. Lot of other things to do ;) But i want to!


Add Mayfair in tokenlist

Site: https://www.mayfair.fund/
Please add Mayfair to balancer token list

@zekraken-bot Updated image file with lowercase 🙂


Getting source IP behind proxy

I have a .Net Core application running in a docker container as my backend service. Clients connect to the backend through HAProxy -> Kestrel -> .Net Core Service
I'm trying to capture the user's IP address, but am unable to get the true client IP.
startup.cs
public void ConfigureServices(IServiceCollection services)
        {
            // Proxy Forwarded Headers
            services.Configure<ForwardedHeadersOptions>(options =>
            {
                options.ForwardedHeaders = ForwardedHeaders.XForwardedFor | ForwardedHeaders.XForwardedProto;
                options.KnownNetworks.Add(new IPNetwork(IPAddress.Parse("::ffff:<IP_ADDRESS>"), 104));
            });
        }

---------------------------------------------

public void Configure(IApplicationBuilder app, IWebHostEnvironment env)
        {
            app.UseStaticFiles();
            app.UseForwardedHeaders(new ForwardedHeadersOptions
            {
                ForwardedHeaders = ForwardedHeaders.XForwardedFor | ForwardedHeaders.XForwardedProto,
                ForwardLimit = 2
            });
            app.UseRouting();
            app.UseCors("CorsPolicy");
            app.UseAuthentication();
            app.UseAuthorization();
       }

Getting the client IP (Signalr)
// Extract user IP
        public IPAddress getIp(HubCallerContext cntxt)
        {
            // Return the Context IP address
            if (cntxt != null)
            {
                HttpContext request = cntxt.GetHttpContext();
                if (request != null)
                {
                    return request.Connection.RemoteIpAddress;
                }
                else
                {
                    return IPAddress.Parse("<IP_ADDRESS>");
                }
            }
            else
            {
                return IPAddress.Parse("<IP_ADDRESS>");
            }

The IP address captured is ::ffff:XXX.XX.X.X (The X representing our HA Proxy server, not the client IP)
I've also tried manually setting the HAProxy forwarded IP to <IP_ADDRESS>:  http-request set-header X-Forwarded-For <IP_ADDRESS> but this still shows as the HAProxy's internal IP and not the forced <IP_ADDRESS>.
In HAProxy if I try to enable send-proxy I receive the following error:

Server example-backend/example_backend is DOWN, reason: Layer7 wrong status, code: 505, info: "HTTP Version Not Supported", check duration: 1ms. 0 active and 0 backup servers left. 0 sessions active, 0 requeued, 0 remaining in queue.

Any help is greatly appreciated!

@anurse @Pilchie

I'm tackling this myself, its a bit of a confusing mess -- try changing ForwardLimit to null (no limit) or increase to the number of valid hops in your proxy setup (eg try 3 or 4 or 5).
This has been very confusing because testing locally worked (even when I faked x-forwared-for) but once in production it still kept resolving to the proxy IP, even when it was just the one hop (1 proxy).
Bumping this to an arbitrary value for me (or null) fixed the issue.


feat(sdk): return JWK and JWK bytes from KMS APIs instead of raw keys.

Allows support for more key types, demonstrates ECDSA P-384 usage.
Signed-off-by: Filip Burlacu<EMAIL_ADDRESS>

Codecov Report
Base: 91.63% // Head: 91.03% // Decreases project coverage by -0.61% :warning:

Coverage data is based on head (a44e359) compared to base (e8d9f61).
Patch coverage: 75.36% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #250      +/-   ##
==========================================
- Coverage   91.63%   91.03%   -0.61%
==========================================
  Files          49       49
  Lines        1865     1896      +31
==========================================
+ Hits         1709     1726      +17
- Misses        111      118       +7
- Partials       45       52       +7

Impacted Files
Coverage Δ

cmd/wallet-sdk-gomobile/did/creator.go
83.33% <ø> (ø)

pkg/common/jwt_signer.go
89.28% <50.00%> (-10.72%)
:arrow_down:

cmd/wallet-sdk-gomobile/did/keywrapper.go
63.63% <62.50%> (-7.80%)
:arrow_down:

pkg/localkms/localkms.go
75.00% <66.66%> (-9.00%)
:arrow_down:

pkg/did/creator/creator.go
93.75% <88.23%> (-2.75%)
:arrow_down:

cmd/wallet-sdk-gomobile/localkms/localkms.go
75.00% <100.00%> (ø)

pkg/did/creator/ion/ion.go
88.88% <100.00%> (+4.27%)
:arrow_up:

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.


silx.io.nxdata: removed support of NXcanSAS signal @uncertainties

As discussed in PR #3657, this removes the support of @uncertainties on the signal as described in the NXcanSAS application definition, and instead stick to NXdata <signal>_errors.
Related to #3657

For reference @uncertainties is deprecated: https://www.nexusformat.org/NIAC2018Minutes.html

The "errors" field and uncertainties attribute in NXdata to be marked deprecated


Small text fix in custom-templates.mdx

Summary
I tried using the example code here and noticed that the docs still refer to tpl.ast which no longer exists on the template context argument.

Thanks!


Test lighthouse 1

Changes:

...

Type of change

[ ] Bug fix
[ ] New feature
[ ] Update feature
[ ] Refactor code
[ ] Translation to code
[ ] Translation to crowdin
[ ] Script configuration
[ ] Improve performance
[ ] Style only
[ ] Dependency update
[ ] Documentation update
[ ] Release

Name
Result

Build status
Building 🔨

Action URL
Visit Action

Preview Link: https://test-lighthouse-1.deriv-com-preview-links.pages.dev

Name
Result

Build status
Completed ✅

Preview URL
Visit Preview

Action URL
Visit Action

Name
Result

Build status
Building 🔨

Action URL
Visit Action

Preview Link: https://test-lighthouse-1.deriv-com-preview-links.pages.dev

Name
Result

Build status
Completed ✅

Preview URL
Visit Preview

Action URL
Visit Action

Name
Result

Build status
Building 🔨

Action URL
Visit Action

Preview Link: https://test-lighthouse-1.deriv-com-preview-links.pages.dev

Name
Result

Build status
Completed ✅

Preview URL
Visit Preview

Action URL
Visit Action

Name
Result

Build status
Building 🔨

Action URL
Visit Action

Preview Link: https://test-lighthouse-1.deriv-com-preview-links.pages.dev

Name
Result

Build status
Completed ✅

Preview URL
Visit Preview

Action URL
Visit Action

Name
Result

Build status
Building 🔨

Action URL
Visit Action

Name
Result

Build status
Failed ❌

Action URL
Visit Action