File upload plugin

Hello again,
following #125 I'm trying to create a plugin to make possible to upload a file thru this amazing library, based on GraphQL multipart request spec.
I'm using fastify-plugin and fastify-multipart. I have created this stub:
'use strict';

const fp = require('fastify-plugin');

function GQLUpload(fastify, opts, next) {
    if (!fastify.hasRequestDecorator('multipart')) {
        fastify.register(require('fastify-multipart'), opts);
    }

    fastify.addHook('onResponse', (request, reply, done) => {
        if (request && request.body) {
            console.log(request.body);
        }

        done();
    });

    next();
}

module.exports = fp(GQLUpload, {
    fastify: '>= 2.x',
    name: 'fastify-gql-upload',
    dependencies: ['fastify-multipart']
});

With this code, I'm able to see the body in the console, like this:
{
  '1': [
    {
      data: <Buffer 89 50 4e 47 0d 0a 1a 0a 00 00 00 0d 49 48 44 52 00 00 02 00 00 00 03 00 08 06 00 00 00 52 0f df 4e 00 00 00 04 73 42 49 54 08 08 08 08 7c 08 64 88 00 ... 35718 more bytes>,
      filename: 'no_image.png',
      encoding: '7bit',
      mimetype: 'image/png',
      limit: false
    }
  ],
  operations: '{"operationName":null,"variables":{"id":"F8JgzO4Wvp5TeicbO1mC","file":null},"query":"mutation ($id: ID!, $file: Upload!) {\\n  addNewsImage(newsId: $id, file: $file)\\n}\\n"}',
  map: '{"1":["variables.file"]}'
}

Now, the endpoint return this error with HTTP 400
Must provide Source. Received: undefined
and the resolver is not executing.
My question is: how to pass the data from the response.body to the resolver's function?
I'm very sorry to post such open and broad question with little code, but I'm really not understanding how to complete the flow.

You should be able to access that in your resolver as context.reply.request.body.

Ciao Matteo,
thanks for your reply.
The problem is the request never hit the resolver. the error
Must provide Source. Received: undefined
happens earlier in the fastify pipeline.

Well, I did it.
Thanks to the debugger and the ability to step upward during debug, I understood my mistakes.
Body was not compliant with fastifyGraphQl function in order to be parsed correctly.
I'll do some refinements now and then I'd love to share my work with you.
@mcollina Do you prefer that I send the code to you or I publish the plug in on my own?

@artecoop Nice one! Do you have a branch somewhere where I can look? I'm also digging into this issue :)

@bmullan working on it.
The code is now a bit of a mess, and for debugging purposes I've copied files from grapqhl-upload package that needs to be imported (as dependencies should work lmao)

Youu sent is to the wrong bmullan
The person you want is "bmullan91" not me "bmullan"
On Thu, Feb 20, 2020, 5:40 AM Art & Coop<EMAIL_ADDRESS>wrote:

@bmullan https://github.com/bmullan working on it.
The code is now a bit of a mess, and for debugging purposes I've copied
files from grapqhl-upload package that needs to be imported (as
dependencies should work lmao)
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/mcollina/fastify-gql/issues/126?email_source=notifications&email_token=AAM23J7CWGTW5S5ZJHB7OVDRDZMZJA5CNFSM4KXW7PDKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEMNG6UY#issuecomment-588934995,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AAM23J5AOQIK4KLXVRSPIG3RDZMZJANCNFSM4KXW7PDA
.

Yeah sorry for that!

@artecoop After a lot of head scratching and try and error... I got it working with this before registering the fastify-gql plugin:
 fastify.addContentTypeParser("multipart", (req, done) => {
    req.isMultipart = true;
    done();
  });

  fastify.addHook("preValidation", async function(request, reply) {
    if (!request.req.isMultipart) {
      return;
    }

    // processRequest from `graphql-upload`
    request.body = await processRequest(request.req, reply.res, options);
  });

Here's a codesandbox with the code https://codesandbox.io/s/fastify-gql-upload-eg-7gsz9 - note It fails to write the file on sandbox, not sure if that's possible on codesandbox.
When I moved the code into a separate plugin it no longer worked - not sure why tbh 😕

@bmullan91 how could this work? graphql-upload's processRequest uses, for example, request.once and response.once that aren't available in fastify's request/response.
I'm prepping a repo with my code to share with all of you.

@artecoop Im passing the raw req, and resp via:
await processRequest(request.req, reply.res, options);

@artecoop I've pushed up that sandbox into an actual repo: https://github.com/bmullan91/fastify-gql-upload-eg

@bmullan91 this is beatiful. Please publish it as npm package. It's way better than my implementation that rewrite the body.

@artecoop Will do, once I figure out why fastify doesn't like it when I put it inside its own plugin 😅

@bmullan91 check this out:
https://github.com/kennyrulez/fastify-gql-plugin
this is my implementation, maybe will help you

@artecoop https://www.npmjs.com/package/fastify-gql-upload - still need to write tests etc, but this should unblock you 😄

Thank you, it works like a charm

Made a fork of fastify-gql-upload with updated syntax for Fastify v3, updated dependencies + TypeScript support.
https://www.npmjs.com/package/fastify-gql-upload-ts
https://github.com/PabloSzx/fastify-gql-upload-ts

Brilliant work @PabloSzx !!!

Could this be something that should be documented in the README, with a reference to @PabloSzx npm package?
Once documented & accessible to everyone, we should be able to close this, I believe.

Should we support this natively?

Apollo Server has out of the box support for File Uploads using graphql-upload, I think it would be nice to support it too, and it's not much code needed anyways, but there are some gotchas, like node version compatibility.

Should we support this natively?

IMHO, no. Keep going with the single responsibility principle, and let other packages, yours or made by other developers, plugs extra features.
Dont waste the "pluggable" effort you did with fastify

Should we support this natively?

Might be a good idea to do a quick Pro/Con list (please complete it, if I miss something important)
Pro

Be compatible with apollo-server, which supports this out of the box (https://www.apollographql.com/docs/apollo-server/data/file-uploads/)
Necessary changes are minimal, judging from https://github.com/PabloSzx/fastify-gql-upload-ts/blob/master/index.ts

Neutral

Might have a (minimal) performance impact due to the fact that each request needs to pass an async preValidation hook, which could be mitigated using a config option to disable the feature in case it's not needed: https://github.com/PabloSzx/fastify-gql-upload-ts/blob/master/index.ts#L22

Con

Additional 3rd party dependency graphql-upload, which itself has 5 more first level dependencies adding quite a bit of weight
As per @artecoop definition, it violates the single responsibility principle (I'm personally undecided on this fact)
Has been/Can be solved by a 3rd party module already

My subjective opinion, leave it out of core, but a note should be added to the README with a link to the npm module by @PabloSzx & a quick integration/usage example.

My vote goes to not adding it in the core and leaving it as a plugin (and yes, I'm new to fastify-gql and my 2 cents probably isn't worth much). 😊
Thing is, how one handles uploading files with a GraphQL server can differ depending on needs and nailing down one way into the core is sub-optimal for everyone else not needing that method. The upload feature is then just bloat. Using plugins means a developer makes the conscious decision to add that feature, and at that point it isn't bloat.
Scott

closing, I think we have some sort of conclusion :).

btw, the package was renamed to mercurius-upload following the rebranding
https://github.com/PabloSzx/mercurius-upload
https://www.npmjs.com/package/mercurius-upload

@PabloSzx would you like to move it inside the org to give it an official blessing?

@PabloSzx would you like to move it inside the org to give it an official blessing?

Sure 😁 I added you (matteo.collina) as a mantainer in the npm package, but when I try to "Transfer ownership" of the GitHub repository, this error comes up:

I just added you as a collaborator of the repo and maybe then you can transfer it 🤷♂

Could you add me as an owner on npm as well?

Could you add me as an owner on npm as well? I am https://www.npmjs.com/~matteo.collina

Done 👌

Great!!!!

Maybe we can link the plugin from this project README as well?


[Refactor] config/ to lib/constants

Currently, we store a lot of information in the config folder, but much of it is actually project constants. We can improve the file structure by reorganizing these constants and limiting the config folder to environment variables only.

closed
We no longer need it. We'll leave the config/ folder for users to configure, as it serves as the interface for using this portfolio template. We'll also ensure that the constants are clearly defined to only store variables used in this project.


org.jkiss.dbeaver.ui.navigator.database.load.TreeNodeLazyExpander cannot be cast to

Hello,
I'm exporting a result from an oracle database to another oracle database and at the time of choosing the existing table the system displays the following message:
An error has occurred. See error log for more details.
org.jkiss.dbeaver.ui.navigator.database.load.TreeNodeLazyExpander can not be cast to org.jkiss.dbeaver.model.navigator.DBNNode
I have more than 21000 tables in the database.

Thanks for the bug report


remove unused function patterns

removes 2 function patterns which are never used. not sure why these were searched  though.

Those were used in older versions. For more info:
https://github.com/crosire/scripthookvdotnet/blob/b5a3df89fac4840391e81222bb7be3285527bef7/source/core/NativeMemory.cs#L982
https://github.com/crosire/scripthookvdotnet/blob/b20775794b0c1496de4214df928b4e530eef8606/source/core/NativeMemory.cpp#L42


Fix pp generation

This should fix generation + eval tasks for pipeline parallel sizes > 1 in conjunction with model parallel > 1
I haven't yet compared 20B outputs when generating to the main branch, since I don't have access to any A100 pods rn. Would appreciate if someone could do that, but eval results remain the same.
main:
{
    "results": {
        "lambada": {
            "ppl": 3.677788098948207,
            "ppl_stderr": 0.07588756650708797,
            "acc": 0.715311469047157,
            "acc_stderr": 0.006287017261279481
        }
    },
    "versions": {
        "lambada": 0
    }
}

PR:
{
    "results": {
        "lambada": {
            "ppl": 3.6760727055431444,
            "ppl_stderr": 0.07584380001242345,
            "acc": 0.715311469047157,
            "acc_stderr": 0.006287017261279481
        }
    },
    "versions": {
        "lambada": 0
    }
}

Changes:

removes layernorm test in test_fused_kernels.py (dead code)
layer pasts / presents are no longer passed around the model, instead they're cached to the ParallelTransformerLayer class.
I've renamed get_key_value to use_cache, since I found that naming very confusing

Just verified outputs are the same across branches:
Main (pp1):
{
    "context": "",
    "text": "Q:\n\nHow to get the value of a variable in a function in a different file?\n\nI have a file called \"main.py\" and a file called \"functions.py\".\nIn \"main.py\" I have:\nimport functions\n\ndef main():\n    print(functions",
    "length": 64,
    "finished": false,
    "message": null,
    "duration_seconds": 10.974509716033936
}

fix_pp_generation (pp1):
{
    "context": "",
    "text": "Q:\n\nHow to get the value of a variable in a function in a different file?\n\nI have a file called \"main.py\" and a file called \"functions.py\".\nIn \"main.py\" I have:\nimport functions\n\ndef main():\n    print(functions",
    "length": 64,
    "finished": false,
    "message": null,
    "duration_seconds": 16.59027099609375
}

fix_pp_generation (pp4):
{
    "context": "",
    "text": "Q:\n\nHow to get the value of a variable in a function in a different file?\n\nI have a file called \"main.py\" and a file called \"functions.py\".\nIn \"main.py\" I have:\nimport functions\n\ndef main():\n    print(functions",
    "length": 64,
    "finished": false,
    "message": null,
    "duration_seconds": 25.938984632492065
}


nix: clean up flake and ignore nix build artifact

Changes made

result/ is only a symlink to the store, which serves zero purpose on a git repeository - added to .gitignore
renamed hyprlandSystems function to a little more descriptive forHyprlandSystems
added nix-filter to scrub source directory before build
added BUILT_WITH_NOXWAYLAND = false to the derivation in order to make it overridable with .overrideAttrs
formatting via alejandra because nixpkgs-fmt sucks 👍🏻

Looks good, I'm not a Nix user but these improvements seem useful


Creating model matrix columns from a PooledDataVector

I feel rather dumb for having done this in such an awkward way in some examples in the Glm code.  The way that a factor is incorporated in a model matrix in R is through indexing the rows of a constrasts matrix.  The default contrasts in R are the treatment contrasts defined by contr.treatment.  The contr_treatment generic in the Glm package is patterned on the R function.  To generate the columns of a model matrix for a PooledDataVector use
contrasts(vv::PooledDataVector) = contr_treatment(length(vv.pool))[vv.refs,:]

Enhancements would take into account dropping unused levels and situations where you don't need contrasts but instead need the indicators (which can also be simplified), switching to other forms of contrasts, etc.

Closing given the big improvements in contrasts handling that have happened since then.


Optimal Ordering Issue (Beneath Cursed Sands / Contact!)

Under 'Optimal' Ordering, the quest Beneath Cursed Sands is before Contact! even though Contact! is required to start Beneath Cursed Sands.

This was fixed in 20a8817bb5ba940607cf08c395e3a481caccef61 but has not been released yet.


Failure 1.0.0 release plans

I saw some activity on 1.x version, when it is intended to be released?

Targeting March 15, hoping to post a blog post about it very soon :)

Great. Thanks for all the work :-)


restart required before step 16

Thanks for the guide, this (eventually) worked perfectly for me, However, I had to restart my TrueNAS host system before the webui and smb would work properly. I'm not sure exactly which step needs the restart (my guess is step 14/15), but maybe it's worth adding a note before or in step 16 that A restart of the host system may be required.

Fixed in 954a372.


Sync my list of proxied sites

I use different computers, for many years I have been using the Chrome browser and it is very convenient when everything is synchronized, is it possible to add FTP or another tool to synchronize with the file automatically

I'm closing this issue, since I've created a new one with more details. See #706.


WildPokemon always seems blank for me.

Results differ from the wildpokemon spawning in https://github.com/AHAAAAAAA/PokemonGo-Map. WildPokemon always seem to be a blank array for me.
Nearby Pokemon on both seem to be the same.
Maybe because the prototype is different? The wild pokemon on that app also gives a latitude and longitude. Would be awesome if this project can have that. #

This is being looked into - https://github.com/Armax/Pokemon-GO-node-api/issues/57

We are working on fixing it, the problem is with the s2 lib


Fixed Grammar, Wordiness, and Professionalism

Made cardboard more grammatically correct, less wordy, and more professional!

Oh whoops, I forgot it's not kilobytes per second lol

lgtm 👍


fix:  ServiceBinding is not yet initialized

Description

This happens when the application needs to communicate with native OS in order to activate some services.
For convention solution to tackle this problem, we usually place WidgetsFlutterBinding.ensureInitialize() before runApp() function
However, this convention solution is not applicable for our library, since this will cause us binding the services in different zone.

Future<void> main() async {
  WidgetsFlutterBinding.ensureInitialized();

  final runner = Runner(
    defineBoot: defineBoot,
    extensions: [
      // _BootExtension(),
      // firebaseCoreExtension(),
      appExtension(),
    ],
  );

  await runner.run();
}

flutter: \^[[38;5;196m│ \^[[0m\^[[39m\^[[48;5;196mZone mismatch.<…>
flutter: \^[[38;5;196m│ \^[[0m\^[[39m\^[[48;5;196mThe Flutter bindings were initialized in a different zone than is now being used. This will likely cause confusion and bugs as any zone-specific configuration will inconsistently use the configuration of the original binding initialization zone or this zone based on hard-to-predict factors such as which zone was active when a particular callback was set.<…>
flutter: \^[[38;5;196m│ \^[[0m\^[[39m\^[[48;5;196mIt is important to use the same zone when calling `ensureInitialized` on the binding as when calling `runApp` later.<…>
flutter: \^[[38;5;196m│ \^[[0m\^[[39m\^[[48;5;196mTo make this warning fatal, set BindingBase.debugZoneErrorsAreFatal to true before the bindings are initialized (i.e. as the first statement in `void main() { }`).<…>

Steps To Reproduce
Take run-time theming initialization of Google Fonts package as an example:
We declare our custom theme settings then plug into MaterialAppSettings
FlutterAppExtension appExtension() {
  return FlutterAppExtension(
    materialAppSettings: MaterialAppSettings(
      debugShowCheckedModeBanner: false,
      theme: AppTheme.basic().themeData,
    ),
    routerSettings: RouterSettings(
      navigatorKey: navigationKey,
      screenFactories: [
        (c) => HomeScreen(),
        (_) => AppointmentDetail(),
        (_) => CommingSoon(),
      ],
    ),
  );
}

Expected Behavior
Complains of Zone mismatch should be gone, and the ability of init any services which require to communicate to native OS

Solution Proposal:
Notice this solution is temporary, applying this solution might break the current pattern
Since the Google Fonts package is required WidgetsFlutterBinding.ensureInitialize() called in advance using any functions that google_fonts package provided.
Current solution is to lately initialize any MaterialAppSettings or CupertinoAppSettings by providing a callback
FlutterAppExtension({
    required RouterSettings routerSettings,
    Map<AppWidgetWrapper, int>? wrappers,
    CupertinoAppSettings? cupertinoAppSettings,
    MaterialAppSettings? materialAppSettings,
    MaterialAppSettings Function()? callBack,
  })  : _routerSettings = routerSettings,
        _wrappers = {...wrappers ?? {}},
        _callBack = callBack;

Then in _onRun function we will assign local _materialAppSettings after WidgetsFlutterBinding.ensureInitialize() get called
Future<void> _onRun(RunEvent event) async {
    WidgetsFlutterBinding.ensureInitialized();
    _forwardsFlutterErrorsToRunningZone(event.zone);

    final router = await _getRouter(event.container);

    **_materialAppSettings = _callBack?.call();**

    var app = _appWidget(router);

    for (final wrapper in _sortedWrappers) {
      app = wrapper(app);
    }

    if (app is! ProviderScope || app.parent != event.container) {
      app = ProviderScope(
        parent: event.container,
        child: app,
      );
    }
    runApp(app);
  }


[Theming] Use color names in props

Description

Checklist

[ ] For UI or styling changes, I have added a screenshot or gif showing before & after
[ ] I have added a changeset
[ ] I have added to the docs where applicable
[ ] I have added to the VS Code extension where applicable

Main thing left is figuring out what to do with the existing color aliasing in Column and Reference* components


implement python type hinting

seems like type hinting would be pretty valuable in this package (esp. since we should support comparing to standard datetime objects when we can, but should be explicit about it)
https://docs.python.org/3.9/library/typing.html
https://peps.python.org/pep-0483/

Definitely agree on this. 3.10 has better support than 3.9 for generic types. Probably a different question, but is there a Python version we should keep in mind when developing?
I've used type hints in a couple projects, but haven't used something like mypy to enforce them. Probably a two-step process but that would be a good goal.

I think type hinting was added in 3.5, f-strings in 3.6. Typing is part of the standard lib so I think to get newer typing features you have to use a newer version of Python. You can backport typing to pre-3.5 with a library install.
I have one project on 3.5, several on 3.8, and one each on 3.9 and 3.10.

I have a couple of projects still on 3.6 (hopefully will be able to update before too long, but you know how that goes...). 3.5 and 3.6 are already EOL ? Based on this python versions timeline it seems like we shouldn't be targeting 3.6 and maybe not bother with 3.7 either (unless community needs it).
What's the oldest project / version of pyhton you've got where you'd be interested in using undate ?

Probably 3.8, but I should update those to 3.10 soon anyway.

3.8 seems like a good minimum target to me! unless it's causes substantial extra effort for working with the code

completed in #16 — thanks @ColeDCrawford ! 🎉


Some files get corrupted after running through the pre-commit

When committing files like.pdf or .png, the file will become corrupted. If you commit the same files with --no-verify, skipping the pre-commit, the file will not be corrupted. Something in the pre-commit is causing these files to become corrupt.

The serializer pre-commit should skip any files that don't have extension .ttl or .owl. It's puzzling that it would then corrupt the file.

The problem is in the call to remove_skos_decls after serialize_all. This call is slated for removal in issue #934. I'm going to remove it here.


inserting row with value in primary key, value will be changed!

I have successfully implemented DBFlow in one of my apps, completly replacing the old database code - good work.. I wrote a process to copy the data from the old one to the new objects.
I had a crash at startup, rather weird, then found when inserting the old data into the new dbflow table, the "_id" primary key value was being changed..
Thus original table
_id  value
1     a
2    b
4    c
became
_id
1
2
3
which caused failures in lookups to this table from other tables. I had to implement a lookup list oldvalue->newvalue..
I would have expected that a value inserted into the primary key row will be kept, only updated if no value has been put in..
:)

@wintersandroid can you give me more insight into the issue. Such as the Model class you are inserting and what code your'e using to do so. It would help me. Thanks!

Ok, so I have table defined...
@Table
//@ContainerAdapter
public class AccountTable extends BaseModel {

  @Column(columnType = Column.PRIMARY_KEY_AUTO_INCREMENT)
  public long _id;

  @Column
  public String name;

  @Column
  public String username;

  @Column
  public String password;

  @Column
  public String provider;

  @Column
  public Date lastUpdate;

  public String getUsername()
  {
    return AccountInformation.decode(username);
  }

}

and it is written to using some basic code..
public void convertAccounts() {
//    new Delete().from(AccountTable.class).query();
    Cursor cursor = databaseHelper.db().query(DatabaseHelper.ACCOUNT_DATABASE_TABLE, null, null, null, null, null, DatabaseHelper.KEY_ROWID);
    try {
      cursor.moveToFirst();
      while (!cursor.isAfterLast()) {
        AccountTable tableRow = new AccountTable();
        long id = cursor.getInt(cursor.getColumnIndex(DatabaseHelper.KEY_ROWID));
        tableRow._id = id;
        tableRow.username = cursor.getString(cursor.getColumnIndex(DatabaseHelper.KEY_USERNAME));
        tableRow.password = cursor.getString(cursor.getColumnIndex(DatabaseHelper.KEY_PASSWORD));
        tableRow.provider = cursor.getString(cursor.getColumnIndex(DatabaseHelper.KEY_PROVIDER));
        Time lastupdate = new Time();
        lastupdate.parse(cursor.getString(cursor.getColumnIndex(DatabaseHelper.KEY_LAST_UPDATE)));
        tableRow.lastUpdate = new Date(lastupdate.toMillis(false));
        tableRow.name =  tableRow.getUsername();
        tableRow.save(false);

        if(tableRow._id != id)
        {
          accountIdChanges.put(id,tableRow._id);
        }

        cursor.moveToNext();
      }
    } finally {
      cursor.close();
    }
  }

@wintersandroid its an autoincrementing primary key. that value will not be kept when inserting data.

@wintersandroid just curious too, why you need to copy old data into new...wouldn't it make sense to keep it in the existing table?

I was not sure how to do that to start with, the documentation was not clear on how to keep existing tables and columns with the new classes.. I thought it best to start with fresh tables and namespace, probably a daft idea.. But I like the ORM model..

Its ok @wintersandroid. This library just wraps around the native calls to the database, so if the existing DB and table is there, you can use it!


logger is not used consistently across different layers

ContainerRuntime gets a logger during creation which it exposes to other layers. It internally creates a child logger under this._logger that it uses to log events.
DataStoreContext exposes container runtime's logger as this.logger. It creates a child logger under this.subLogger. However, it's event are logged via this.logger.
Data store runtime creates a child logger under this.logger from data store context's logger. It exposes this logger and also uses this logger to log events. It does not use a new name space for the child logger.
Remote channel context creates a child logger under this.subLogger and uses it to log events.

The intent behind having 2 loggers in these objects is:

It uses a base logger to create a child logger by adding its namespace and uses it to log events.
It passes the base logger to lower layers so that they can do 1 above without creating a big chain of child loggers.

However, these loggers are used as intended. There are a couple of solutions suggested:

Have two loggers in each object - baseLogger that is used to create a logger. baseLogger is the one that is exposed to lower layers and logger is used to log events for this object.
Have ChildLogger expose the baseLogger that was used to create it. Each object then only has to maintain one logger and can expose the baseLogger off of the logger to lower layers.

@andre4i @markfields @anthony-murphy @vladsud

We use monitor context now instead of logger so this issue is not relevant anymore.


Missing DJANGO_SETTINGS_MODULE

With empty .coveragerc:
$ coverage run foo/manage.py test bar
[...works...]

With django-coverage-plugin in .coveragerc:
[run]
plugins =
  django_coverage_plugin

$ coverage run foo/manage.py test bar
[...]
django.core.exceptions.ImproperlyConfigured: Requested setting TEMPLATES, but settings are not configured. You must either define the environment variable DJANGO_SETTINGS_MODULE or call settings.configure() before accessing settings.

manage.py is unmodified (generated by Django).

Can you show the complete error report with traceback?

Sure. Actually from the traceback it looks more like django-coverage-plugin wants the use settings before manage.py has loaded the environment variable; changing the title accordingly.
Traceback (most recent call last):
  File "/my/project/.tox/py35-django18/bin/coverage", line 11, in <module>
    sys.exit(main())
  File "/my/project/.tox/py35-django18/lib/python3.5/site-packages/coverage/cmdline.py", line 741, in main
    status = CoverageScript().command_line(argv)
  File "/my/project/.tox/py35-django18/lib/python3.5/site-packages/coverage/cmdline.py", line 481, in command_line
    return self.do_run(options, args)
  File "/my/project/.tox/py35-django18/lib/python3.5/site-packages/coverage/cmdline.py", line 610, in do_run
    self.coverage.erase()
  File "/my/project/.tox/py35-django18/lib/python3.5/site-packages/coverage/control.py", line 709, in erase
    self._init()
  File "/my/project/.tox/py35-django18/lib/python3.5/site-packages/coverage/control.py", line 218, in _init
    self.plugins = Plugins.load_plugins(self.config.plugins, self.config, self.debug)
  File "/my/project/.tox/py35-django18/lib/python3.5/site-packages/coverage/plugin_support.py", line 49, in load_plugins
    coverage_init(plugins, options)
  File "/my/project/.tox/py35-django18/lib/python3.5/site-packages/django_coverage_plugin/__init__.py", line 11, in coverage_init
    reg.add_file_tracer(DjangoTemplatePlugin())
  File "/my/project/.tox/py35-django18/lib/python3.5/site-packages/django_coverage_plugin/plugin.py", line 122, in __init__
    check_debug()
  File "/my/project/.tox/py35-django18/lib/python3.5/site-packages/django_coverage_plugin/plugin.py", line 52, in check_debug
    templates = getattr(settings, 'TEMPLATES', [])
  File "/my/project/.tox/py35-django18/lib/python3.5/site-packages/django/conf/__init__.py", line 48, in __getattr__
    self._setup(name)
  File "/my/project/.tox/py35-django18/lib/python3.5/site-packages/django/conf/__init__.py", line 42, in _setup
    % (desc, ENVIRONMENT_VARIABLE))
django.core.exceptions.ImproperlyConfigured: Requested setting TEMPLATES, but settings are not configured. You must either define the environment variable DJANGO_SETTINGS_MODULE or call settings.configure() before accessing settings.

Note that this worked in 1.1 and broke in 1.2, I can bisect the commit for you if you want

@jonashaag more details about how reproduce this, or which commit it was, would be great.

Just use startproject, startapp, and then the settings I show above.

Bump

@jonashaag Did you manage to identify the exact commit that causes the error?

@keimlink Yes but I don't remember which one it was, you can simply run git bisect to find it

bisect points at 0085fb83807b58863789d4fe3f92718322751b0a

I'll be able to jump into this more easily with a zipfile or specific instructions about how to reproduce it.

Steps to reproduce:
mkvirtualenv issue-18
pip install git+https://github.com/nedbat/django_coverage_plugin.git
django-admin startproject myprj
printf "[run]\nplugins = \n  django_coverage_plugin\n" > .coveragerc
coverage run myprj/manage.py test

Actually, it works fine if you run from the directory where manage.py is located. I think that is expected. You should always run manage.py from its direct parent directory. Otherwise,  DJANGO_SETTINGS_MODULE will point at the wrong target (unless you take some other measure to get your project into sys.path).
@jonashaag: does it work if you cd into foo and run ./manage.py test?

Eh, sorry. My comment above about having to run manage.py from its parent dir is wrong. DJANGO_SETTINGS_MODULE is relative to the location of manage.py. I really shouldn't debug things at this time of the day :-/
But at least I found out that the current directory has something to do with it. Happy debugging ;)

The working directory is a red herring: that's because there's no .coveragerc in the subdirectory. If you copy it there, the failure happens in either directory.
I think the fix is to move the plugin's access of settings to later, when it is actually needed.

Just chiming in to say I fixed this same bug when using pytest-cov by just commenting out check_debug():  https://github.com/emmalemma/django_coverage_plugin/commit/e083da1624831c9485ec44f569d0689a59249f36 True, I won't get the nice warning if the settings are wrong, just 0% coverage; on the upside, when the settings are correct, the plugin actually works.
If anyone's trying to find a better solution, I can tell you that you need to find a way to raise this error after __init__, since in this configuration that happens before settings have been loaded. Unfortunately coverage seems to like to swallow all errors after that point. Good luck.

This is fixed as of commit fdb0892966362e2ded39e4124d095a999a28543e

I'll make a new release.  If you could test it out, that would be great.

Thanks! With my config, fdb0892 works but still doesn't log the error when template debugging is off. Nothing in the coverage debug log either. For the record I'm using:
coverage (4.1)
pytest (2.9.1)
pytest-cov (2.2.1)
pytest-django (2.9.1)

I'm not sure which of these is responsible for eating the exception.

@emmalemma Can you show me some output?  When I run a project without a debug setting, I get this:
$ coverage run manage.py test
Coverage.py warning: Disabling plugin 'django_coverage_plugin.DjangoTemplatePlugin' due to an exception:
Traceback (most recent call last):
  File "/usr/local/virtualenvs/django_coverage/lib/python2.7/site-packages/coverage/control.py", line 499, in _should_trace_internal
    file_tracer = plugin.file_tracer(canonical)
  File "/Users/ned/coverage/django_coverage_plugin/django_coverage_plugin/plugin.py", line 154, in file_tracer
    check_debug()
  File "/Users/ned/coverage/django_coverage_plugin/django_coverage_plugin/plugin.py", line 69, in check_debug
    "Template debugging must be enabled in settings."
DjangoTemplatePluginException: Template debugging must be enabled in settings.
Creating test database for alias 'default'...
..........
----------------------------------------------------------------------
Ran 10 tests in 0.060s

OK
Destroying test database for alias 'default'...
$

Sure. I can reproduce this with a minimal pytest setup:
virtualenv -p python3 venv
source venv/bin/activate
pip install django pytest pytest-django pytest-cov
pip install -e "git+https://github.com/nedbat/django_coverage_plugin@fdb0892966362e2ded39e4124d095a999a28543e#egg=django_coverage_plugin"

django-admin startproject coverage_test
cd coverage_test
echo "[run]\nplugins=django_coverage_plugin" > .coveragerc

mkdir coverage_test/templates
echo "test" > coverage_test/templates/test.html

create tests.py:
from django.template.loader import render_to_string

def test():
	render_to_string('test.html')

edit settings.py:
INSTALLED_APPS.append('coverage_test')
TEMPLATES[0]['OPTIONS']['debug'] = True

Demonstrate it works:
> export DJANGO_SETTINGS_MODULE=coverage_test.settings
> py.test tests.py --cov coverage_test

====================================== test session starts =======================================
platform darwin -- Python 3.5.1, pytest-2.9.2, py-1.4.31, pluggy-0.3.1
django settings: coverage_test.settings (from environment variable)
rootdir: /Users/emma/Dropbox/Projects/coverage_test/coverage_test, inifile:
plugins: cov-2.2.1, django-2.9.1
collected 1 items

tests.py .
------------------------ coverage: platform darwin, python 3.5.1-final-0 -------------------------
Name                                Stmts   Miss  Cover
-------------------------------------------------------
coverage_test/__init__.py               0      0   100%
coverage_test/settings.py              20      0   100%
coverage_test/templates/test.html       1      0   100%
coverage_test/urls.py                   3      3     0%
coverage_test/wsgi.py                   4      4     0%
-------------------------------------------------------
TOTAL                                  28      7    75%

==================================== 1 passed in 0.32 seconds ====================================

Then set TEMPLATES[0]['OPTIONS']['debug'] = False, and demonstrate it fails silently:
> py.test tests.py --cov coverage_test

====================================== test session starts =======================================
platform darwin -- Python 3.5.1, pytest-2.9.2, py-1.4.31, pluggy-0.3.1
django settings: coverage_test.settings (from environment variable)
rootdir: /Users/emma/Dropbox/Projects/coverage_test/coverage_test, inifile:
plugins: cov-2.2.1, django-2.9.1
collected 1 items

tests.py .
------------------------ coverage: platform darwin, python 3.5.1-final-0 -------------------------
Name                        Stmts   Miss  Cover
-----------------------------------------------
coverage_test/__init__.py       0      0   100%
coverage_test/settings.py      20      0   100%
coverage_test/urls.py           3      3     0%
coverage_test/wsgi.py           4      4     0%
-----------------------------------------------
TOTAL                          27      7    74%

==================================== 1 passed in 0.27 seconds ====================================

If I run the same thing on emmalemma@e083da1, with check_debug disabled, it shows 0% coverage:
> py.test tests.py --cov coverage_test

====================================== test session starts =======================================
platform darwin -- Python 3.5.1, pytest-2.9.2, py-1.4.31, pluggy-0.3.1
django settings: coverage_test.settings (from environment variable)
rootdir: /Users/emma/Dropbox/Projects/coverage_test/coverage_test, inifile:
plugins: cov-2.2.1, django-2.9.1
collected 1 items

tests.py .
------------------------ coverage: platform darwin, python 3.5.1-final-0 -------------------------
Name                                Stmts   Miss  Cover
-------------------------------------------------------
coverage_test/__init__.py               0      0   100%
coverage_test/settings.py              20      0   100%
coverage_test/templates/test.html       1      0   100%
coverage_test/urls.py                   3      3     0%
coverage_test/wsgi.py                   4      4     0%
-------------------------------------------------------
TOTAL                                  28      7    75%

==================================== 1 passed in 0.23 seconds ====================================

Presumably, the check in fdb0892 is working properly, and killing the plugin; it's just not getting to stderr or stopping pytest.
The original issue is probably fixed by this patch. There might not be anything for the plugin to do about my problem, since it's probably something in pytest or pytest-cov. Or there might a configuration somewhere. I haven't spent much time hunting since the actual plugin is working just fine for me.

@emmalemma thanks for the detailed steps! I'm looking into what is hiding the exception.  BTW: echo "[run]\nplugins=django_coverage_plugin" > .coveragerc put a backslash-n into the rc file, but once I fixed that, the reproduction was easy. :)

Hah, whoops! I only use zsh, forgot that would happen in bash. I guess I need to use printf instead :)
Thanks for taking the time to look into this, and especially thanks for your work on the plugin in the first place.

I opened #25 to deal with the invisible exception.

I was getting the following error:

django_coverage_plugin.plugin.DjangoTemplatePluginException: Template debugging must be enabled in settings.

I thought I had the setting enabled, but here's the thing:

The TEMPLATE_DEBUG setting is deprecated in Django 1.8. The new way to do it is described here: stackoverflow.com/a/32446043/2319697

DEBUG = True

TEMPLATES = [
    {
        ...
        'OPTIONS': {
            'debug': DEBUG,
        },
    },
]

:tada:


Support verilog.

Add support verilog.
Show some import contexts which very convenient in my daily work.

Thanks!


[CI:DOCS] Finalize release notes for Podman v2.0.2

As the title says.

LGTM

/hold

/lgtm

/hold cancel


Add nav listener unregister on app unmount.

:droplet:

Codecov Report

Merging #513 (6140638) into master (5e1ebcd) will decrease coverage by 0.22%.
The diff coverage is 0.00%.

@@            Coverage Diff            @@
##           master    #513      +/-   ##
=========================================
- Coverage    6.89%   6.66%   -0.23%
=========================================
  Files          13      13
  Lines          58      60       +2
=========================================
  Hits            4       4
- Misses         54      56       +2

Impacted Files
Coverage Δ

src/App.js
0.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5e1ebcd...6140638. Read the comment docs.


Send to everyone errors out

Got company communicator setup and it is able to send to messages to teams.
When trying to send to everyone, it only seems to send to handful of users
The error message we get:
Warnings
Failed to sync all users.  Status Code: BadRequest Exception: Code: Request_UnsupportedQuery Message: DeltaLink older than 30 days is not supported. Inner error: AdditionalData: date: 2021-03-17T13:56:54
Any idea what could be causing this?  I found a previous thread that seems to point to a SyncAllUsersActivity.cs recommendation but I can't seem to find that setting anywhere.

Check by following below steps:
Open application storage account
Open "UserData" table
Remove last record which is having following values:

And then send new message which should populate deleted record and send messages.

Hello @work-kyo,
Please try what @SubbaReddi has mentioned. It sometime happens.
Please let us know if your issue still persists.
Thank you.


Default encoding - charset

Describe the bug
Default character encoding doesn't set to UTF-8.
No effect into servlet using: response.setContentType("application/json; charset=UTF-8");
Screenshots
If applicable, add screenshots to help explain your problem.
Intellij & SmartTomcat Version (Help -> About copy & paste below)
IntelliJ IDEA 2021.2.3 (Community Edition)
Build #IC-212.5457.46, built on October 12, 2021
Runtime version: 11.0.12+7-b1504.40 amd64
VM: OpenJDK 64-Bit Server VM by JetBrains s.r.o.
Windows 10 10.0
GC: G1 Young Generation, G1 Old Generation
Memory: 2048M
Cores: 12
Non-Bundled Plugins: de.docs_as_co.intellij.plugin.diagramsnet (0.1.11), net.seesharpsoft.intellij.plugins.csv (2.18.0), com.vermouthx.idea (1.12.2), Dart (212.5486), com.markskelton.one-dark-theme (5.4.0), uk.me.jeffsutton.restconsole (1.4), com.poratu.idea.plugins.tomcat (3.8.5), io.flutter (61.2.4), DBN (3.2.5713.0), com.caldonazzi.alessandro.uml (0.2.0), com.godwin.json.parser (1.4.2), org.jetbrains.kotlin (212-1.5.31-release-546-IJ4638.7), cn.cloud.auto.restful.tool (1.4.4)
Kotlin: 212-1.5.31-release-546-IJ4638.7

Working ok if you set in Java Servlet:
response.setContentType("text/html; charset=UTF-8");
and after
response.setContentType("application/json; charset=UTF-8");
but it fails if you type:
response.setContentType("text/html");
and after
response.setContentType("application/json; charset=UTF-8");


Component not found if render wrapped with Fragment

When I try to select component by react command:
cy.react('MyComponent')
I've got error error:

This happened when MyComponent is wrapped with React.Fragment:
class MyComponent extends React.Component {
  render (){
    return (
      <React.Fragment>

tested component

tested component

      </React.Fragment>
      )
  }
 }

Without React.Fragment is ok. Also there is no problem using cy.getReact('MyComponent')
version:
"cypress": "6.0.0",
"cypress-react-selector": "2.2.1",

Hi. Thanks for raising this issue. Will look into it.

Hi @WojtekMasiukiewicz . The fragment concept is already handled in the library. I am surprised that it is unable to determine the element. may I know what is the react version you are using?

I will check in few days.
sob., 26 gru 2020, 16:58 użytkownik Abhinaba Ghosh<EMAIL_ADDRESS>napisał:

Hi @WojtekMasiukiewicz https://github.com/WojtekMasiukiewicz . The
fragment concept is already handled in the library. I am surprised that it
is unable to determine the element. may I know what is the react version
you are using?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/abhinaba-ghosh/cypress-react-selector/issues/100#issuecomment-751369176,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AEVOZJTZQHQCB5WY724TEBTSWYB3BANCNFSM4UDVOBJQ
.

I have the same issue. Components with React.Fragment as first tag are not found by cy.react, and also all components inside it (recursively). I have one of the top level components in my app with React.Fragment, so basically no component can be found. On the other hand, App and any other component I put outside of it is found.

I have the same issue. Components with React.Fragment as first tag are not found by cy.react, and also all components inside it (recursively). I have one of the top level components in my app with React.Fragment, so basically no component can be found. On the other hand, App and any other component I put outside of it is found.

Hey, @matfer can you share a git repository where I can reproduce the error?

Hey, @matfer can you share a git repository where I can reproduce the error?

I tried to reproduce in a new project, but the bug does not occur (tried with React 17.0.1 and 16.13.1). I cannot figure out why it happens in my app (that unfortunately I cannot share).
However I found a workaround: if I call 'visit' twice, it works. E.g. in the following code cy.react succeedes, while leaving just one 'visit' call it fails.
describe('create_goal', () => {
  it('should create new goal', () => {
    cy.visit("http://localhost:3000")
    cy.visit("http://localhost:3000")
    cy.waitForReact()

    cy.react('ContentButton', {props: {label: LS('createGoal')}}).click()

I tried to reproduce in a new project, but the bug does not occur (tried with React 17.0.1 and 16.13.1). I cannot figure out why it happens in my app (that unfortunately I cannot share).
However I found a workaround: if I call 'visit' twice, it works. E.g. in the following code cy.react succeedes, while leaving just one 'visit' call it fails.
describe('create_goal', () => {
  it('should create new goal', () => {
    cy.visit("http://localhost:3000")
    cy.visit("http://localhost:3000")
    cy.waitForReact()

    cy.react('ContentButton', {props: {label: LS('createGoal')}}).click()

Maybe it is not relevant, but I forgot to mention I am using Typescript.

Maybe it is not relevant, but I forgot to mention I am using Typescript.

I tried to reproduce in a new project, but the bug does not occur (tried with React 17.0.1 and 16.13.1). I cannot figure out why it happens in my app (that unfortunately I cannot share).
However I found a workaround: if I call 'visit' twice, it works. E.g. in the following code cy.react succeedes, while leaving just one 'visit' call it fails.
describe('create_goal', () => {
  it('should create new goal', () => {
    cy.visit("http://localhost:3000")
    cy.visit("http://localhost:3000")
    cy.waitForReact()

    cy.react('ContentButton', {props: {label: LS('createGoal')}}).click()

That's good to know @matfer. As I said, the fragmented concept is handled internally already. The thing I want to highlight here is this library does not care about how the page is loaded. It only requires a stable loaded page to validate is react loaded by the root you provide. So, you need to check the page loading status when you call the visit only once. This is really interesting.

I tried to reproduce in a new project, but the bug does not occur (tried with React 17.0.1 and 16.13.1). I cannot figure out why it happens in my app (that unfortunately I cannot share).
However I found a workaround: if I call 'visit' twice, it works. E.g. in the following code cy.react succeedes, while leaving just one 'visit' call it fails.
describe('create_goal', () => {
  it('should create new goal', () => {
    cy.visit("http://localhost:3000")
    cy.visit("http://localhost:3000")
    cy.waitForReact()

    cy.react('ContentButton', {props: {label: LS('createGoal')}}).click()

That's good to know @matfer. As I said, the fragmented concept is handled internally already. The thing I want to highlight here is this library does not care about how the page is loaded. It only requires a stable loaded page to validate is react loaded by the root you provide. So, you need to check the page loading status when you call the visit only once. This is really interesting.

So, you need to check the page loading status when you call the visit only once.

How? Shouldn't waitForReact take care of that?

So, you need to check the page loading status when you call the visit only once.

How? Shouldn't waitForReact take care of that?

hey @matfer waitForReact tries to find out the react instance has established in a stable window. So, if your window getting refreshed (/ still loading) while waitForReact call going on, it won’t be successful. You can check out the code here

hey @matfer waitForReact tries to find out the react instance has established in a stable window. So, if your window getting refreshed (/ still loading) while waitForReact call going on, it won’t be successful. You can check out the code here

I think I'm having a problem that might be related to this issue. I have a component like this:
<Dashboard data-cy="dashboard" />

Which I try to select like this:
cy.react('*', { props: { 'data-cy': 'dashboard' } });

If Dashboard looks like this, it will not work:
const Dashboard = () => (<> ... </>);

But if it looks like one of the two cases below, it will work:
const Dashboard = () => (
 ...
);

or
const Dashboard = () => (<SomeComponent> ... </SomeComponent>);

I think I'm having a problem that might be related to this issue. I have a component like this:
<Dashboard data-cy="dashboard" />

Which I try to select like this:
cy.react('*', { props: { 'data-cy': 'dashboard' } });

If Dashboard looks like this, it will not work:
const Dashboard = () => (<> ... </>);

But if it looks like one of the two cases below, it will work:
const Dashboard = () => (
 ...
);

or
const Dashboard = () => (<SomeComponent> ... </SomeComponent>);


Relicense under dual MIT/Apache-2.0

The project maintainer explicitly asked for this issue to be opened.
TL;DR the Rust ecosystem is largely Apache-2.0. Being available under that
license is good for interoperation. The MIT license as an add-on can be nice
for GPLv2 projects to use your code.
Why?
The MIT license requires reproducing countless copies of the same copyright
header with different names in the copyright field, for every MIT library in
use. The Apache license does not have this drawback. However, this is not the
primary motivation for me creating these issues. The Apache license also has
protections from patent trolls and an explicit contribution licensing clause.
However, the Apache license is incompatible with GPLv2. This is why Rust is
dual-licensed as MIT/Apache (the "primary" license being Apache, MIT only for
GPLv2 compat), and doing so would be wise for this project. This also makes
this crate suitable for inclusion and unrestricted sharing in the Rust
standard distribution and other projects using dual MIT/Apache, such as my
personal ulterior motive, the Robigalia project.
Some ask, "Does this really apply to binary redistributions? Does MIT really
require reproducing the whole thing?" I'm not a lawyer, and I can't give legal
advice, but some Google Android apps include open source attributions using
this interpretation. Others also agree with
it.
But, again, the copyright notice redistribution is not the primary motivation
for the dual-licensing. It's stronger protections to licensees and better
interoperation with the wider Rust ecosystem.
How?
To do this, get explicit approval from each contributor of copyrightable work
(as not all contributions qualify for copyright, due to not being a "creative
work", e.g. a typo fix) and then add the following to your README:
## License

Licensed under either of

 * Apache License, Version 2.0, ([LICENSE-APACHE](LICENSE-APACHE) or http://www.apache.org/licenses/LICENSE-2.0)
 * MIT license ([LICENSE-MIT](LICENSE-MIT) or http://opensource.org/licenses/MIT)

at your option.

### Contribution

Unless you explicitly state otherwise, any contribution intentionally submitted
for inclusion in the work by you, as defined in the Apache-2.0 license, shall be dual licensed as above, without any
additional terms or conditions.

and in your license headers, if you have them, use the following boilerplate
(based on that used in Rust):
// Copyright 2016 collenchyma Developers
//
// Licensed under the Apache License, Version 2.0, <LICENSE-APACHE or
// http://apache.org/licenses/LICENSE-2.0> or the MIT license <LICENSE-MIT or
// http://opensource.org/licenses/MIT>, at your option. This file may not be
// copied, modified, or distributed except according to those terms.

It's commonly asked whether license headers are required. I'm not comfortable
making an official recommendation either way, but the Apache license
recommends it in their appendix on how to use the license.
Be sure to add the relevant LICENSE-{MIT,APACHE} files. You can copy these
from the Rust repo for a plain-text
version.
And don't forget to update the license metadata in your Cargo.toml to:
license = "MIT OR Apache-2.0"

I'll be going through projects which agree to be relicensed and have approval
by the necessary contributors and doing this changes, so feel free to leave
the heavy lifting to me!
Contributor checkoff
To agree to relicensing, comment with :
I license past and future contributions under the dual MIT/Apache-2.0 license, allowing licensees to chose either at their option.

Or, if you're a contributor, you can check the box in this repo next to your
name. My scripts will pick this exact phrase up and check your checkbox, but
I'll come through and manually review this issue later as well.

[x] @MichaelHirn
[ ] @hobofan
[x] @homu
[ ] @skade
[x] @pdib

I license past and future contributions under the dual MIT/Apache-2.0 license, allowing licensees to chose either at their option.

I license past and future contributions under the dual MIT/Apache-2.0 license, allowing licensees to chose either at their option.

I license past and future contributions under the dual MIT/Apache-2.0 license, allowing licensees to chose either at their option.

I agree with the re-licensing, as I'm just a minor contributor, but like to note that I don't see the move as useful. Further commentary here:
https://github.com/skade/leveldb/issues/18#issuecomment-170520139
I license past and future contributions under the dual MIT/Apache-2.0 license, allowing licensees to chose either at their option.


feat:  pr_evaluation.yml

Description
Since repos are interdependent, we might need to build the proj before being able to lint and test the PR.

@git-anurag-hub CI couldn't lint my #192, same is the case on my system when I remove the build file, but it does smoothly after I build design. This PR is just for information, if there is something missing I'll close the PR but yeah what are your opinions here.

Yep definetly @git-anurag-hub plus, make the yml cleaner and maitainable. If I'm right you are suggesting that we should have add a depends on here


fix gcc-7.3 warnings

This patch fixes various unused-but-set-variable and misleading-indentation warnings generated by -Wall on newer gcc. (Continued from PR#46)

Thanks!


KAFKA-3081: Non-windowed Table Aggregation

ping @ymatsuda for reviews.

@ymatsuda Addressed comments.

LGTM

@ymatsuda Also add the Getter support for KTableAggregate.

Jenkins failure seems not relevant.

Merged to trunk.


Fix IE10 error

How to reproduce
Stickyfill.kill();
$('.sticky').Stickyfill();
The error
SCRIPT5007: Unable to get property 'removeChild' of undefined or null reference

Can't reproduce it on this page. The check for existance of the parent node could be useful in case the DOM is changed by other scripts, but this doesn't seem to be IE specific bug.
Could you show me the page where I can reproduce this bug?

I also see this error but only via IE & Edge. Maybe the bug is MS specific but the fix is not, so why do we not merge the fix?


[UNDERTOW-2425] At ServletOutputStreamImpl synchronized workflow (lis…

…tener = null), prevent the buffer.flip() from not being cleared after an error during attempts to write. Also, at ServletPrintWriter, verify if no progress is being made when attempting to encode returns overflow after flushing, and mark error even if there are remaining bytes in the buffer.
Issue: https://issues.redhat.com/browse/UNDERTOW-2425

The release had to be postponed to today because of issues in UNDERTOW-2312. I'm looking how to fix the spotbugs report issues on this one, as this PR also blocks our release.


Animated 3D Objects are not working

Hai i downloaded 3D Animated object and i'am importing it using sceneForm successfully in my Android Studio, but i'am not getting Any animation Effect can u help me how to make that work in my app.(I'am trying to do like google demo App - scaring lion Animation )
Thanks.

Thanks for the question!
Sceneform 1.3 doesn't support fbx animation.  We're tracking the request in https://github.com/google-ar/sceneform-android-sdk/issues/11

https://developers.google.com/ar/develop/java/sceneform/animation/

That's Great and Thank you Very Much for your Information
On Wed, Feb 20, 2019 at 9:18 AM lynnmyatminn<EMAIL_ADDRESS>wrote:

https://developers.google.com/ar/develop/java/sceneform/animation/
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/google-ar/sceneform-android-sdk/issues/182#issuecomment-465410507,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AnADmbKiehBpQQYM0DdZTddf8b2Iyo2iks5vPMV4gaJpZM4VI3a0
.


Color doesn't change on paste value

Hello! Thank you for the Color Picker Plugin!
Is there any way change color when I type/paste color code in an input.

You need to attach all keyboard events to the input element to trigger the .set() method → https://tovic.github.io/color-picker/color-picker.value-update.html


怎么设置横向

麻烦问下怎么设置横向滑动

Thanks for your question.
This is "vertical scaling flow layout", therefore it does not support horizontal scaling officially.
If you want to use horizontal scaling, it might be effective way that rotate UICollectionView 90 degrees to use CGAffinetransform.
Please try it.

@songzhiming
I have supported horizontal mode at #5.
Please try version 2.1.0!

ok,3Q


Remove System.exit() calls in ufs journal catchup and propagate errors

What changes are proposed in this pull request?
The UfsJournalCheckpointThread calls System.exit(-1) when encountering journal corruption. This causes a deadlock between the UfsJournalCheckpointThread and the shutdown hook calling AlluxioMasterProcess.stop().
This PR removes the System.exit() calls in favor of propagating exceptions when the thread completes.
The net effect is that the master process completely releases its resources when shutting down and terminates without having to be issued kill -9.
Why are the changes needed?
For clean master process termination on errors.
Does this PR introduce any user facing changes?
No.

I assume this was manually tested, but is it possible to devise an automated test for this? to ensure resources are released

I assume this was manually tested, but is it possible to devise an automated test for this? to ensure resources are released

@yuzhu I've added some tests for HA and non HA.

alluxio-bot, merge this please

alluxio-bot, cherry-pick this to branch-2.6 please

alluxio-bot, cherry-pick this to branch-2.8 please


GET Invoice pdf from Odoo

Is this library smart enough to get the invoice pdf back on query ? I am not able to find any source for this. If anybody have an idea on this, that would be nice.

As far as I know, invoice has a file name or some identifier that you can use to build the url to download pdf from odoo


How to get original long value ?

Hi
Is there any approach to retain the original long value? I require the original long value and to convert it into a string.

Add a private property ?

Okay, I found it generated by grpc-tools, not nice-grpc.

Hey
This is configured in ts-proto using --ts_proto_opt=forceLong=long.
See all options here: https://github.com/stephenh/ts-proto?tab=readme-ov-file#supported-options

Thank you for your help.


still have problem with /v command after the update.

[uEssentials] [ERROR] An error ocurred while executing command: 'v 1'
[uEssentials] [ERROR] System.InvalidCastException: Specified cast is not valid.
at Essentials.Common.Util.VehicleUtil.GetVehicle (System.UInt16 id) [0x00008] in :0
at Essentials.Common.Util.VehicleUtil.GetVehicle (System.String name) [0x00025] in :0
at Essentials.Commands.MiscCommands.VehicleCommand (Essentials.Api.Command.Source.ICommandSource src, Essentials.Api.Command.ICommandArgs args, Essentials.Api.Command.ICommand cmd) [0x00049] in :0
at Essentials.Core.Command.MethodCommand.OnExecute (Essentials.Api.Command.Source.ICommandSource source, Essentials.Api.Command.ICommandArgs args) [0x00018] in :0
at Essentials.Core.Command.CommandAdapter.Execute (Rocket.API.IRocketPlayer caller, System.String[] args) [0x00115] in :0
I can's spawn any vanilla vehicle with name or id anymore. I could still spawn modded vehicle but has to be exact id.
And everytime i get a vanilla vehicle put it in the Virtual garage another error pop up.
Error while executing /GarageRetrieve
[RFGarage] Message: Object reference not set to an instance of an object
[RFGarage] Details: System.NullReferenceException: Object reference not set to an instance of an object
at RocketExtensions.Utilities.ThreadTool.RunOnGameThreadAsync (RocketExtensions.Utilities.ThreadTool+VoidPattern action) [0x0009c] in <475e0b7f57954ab0a214b2a1e64aca85>:0
at RFGarage.Commands.GarageRetrieveCommand.Execute (RocketExtensions.Models.CommandContext context) [0x004dd] in <52ea1d9933394db5a7c2f055238b96ce>:0
at RocketExtensions.Plugins.RocketCommand.Run (RocketExtensions.Models.CommandContext context) [0x001fc] in <475e0b7f57954ab0a214b2a1e64aca85>:0

If you already have the current rocket version, perhaps try to disable Uessential's /vehicle.
as for RFGarage, remember that plugin isn't mantained anymore.

I need to use that uEssentials because it could turn on and off pvp for my server to play RP.

I need to use that uEssentials because it could turn on and off pvp for my server to play RP.

You can disable only the vehicule one I think, on
/Servers/unturnedCommands.config.xml
Look for
<Command Name="Vehicle"
and the one that says Uessentials, put it on false.
then, search for this one:
<Command Name="vehicle" Enabled="true" Priority="Low">Rocket.Unturned.Commands.UnturnedCommands/vehicle</Command>
and put it on true
same for this one:
<Command Name="v" Enabled="true" Priority="Normal">Rocket.Unturned.Commands.CommandV/v</Command>

so i do this
Rocket.Unturned.Commands.CommandV/v
and
Rocket.Unturned.Commands.UnturnedCommands/vehicle

i didnt find any command with uEssentials in the command.config

Command Name="vehicle" Enabled="true" Priority="Low">Rocket.Unturned.Commands.UnturnedCommands/vehicle</Command
Command Name="v" Enabled="true" Priority="Normal">Rocket.Unturned.Commands.CommandV/v</Command
the 2 command you told me to put on true it always on. and i didnt see any uEssentials

ah rip lmao

so would Nelson gonna help fix this or all of this have to wait for the plugin to update?
Cause many server using these plugin for their server. Like Zaup Shop can't /buy v.id, uEssentials can't spawn vehicle, RFgarage can't put vanilla vehicle in garage.

so would Nelson gonna help fix this or all of this have to wait for the plugin to update? Cause many server using these plugin for their server. Like Zaup Shop can't /buy v.id, uEssentials can't spawn vehicle, RFgarage can't put vanilla vehicle in garage.

It's already fixed I think, it'd be the mantainers of these plugins who have to update their plugins tho

This isn't something the base game can fix, unfortunately, sorry. A plugin developer will need to update the command. I did patch the LDM /v command for the same issue: The reason for the problem is that it's expecting a vehicle asset but receiving a vehicle redirector asset. If we were lucky the plugin commands would have been using the vanilla vehicle spawning methods or not casting the result to vehicle asset, but it's also understandable why they were doing it the way they were for the time.


new: support for gzip in client v2

This patch adds support for gzip compression in the http client.
It can be enabled by using setting Query{Compressed: true}

I don't understand why the test failed. I can't find any failure in appveyor

I'm tired. This is done automatically by the http.Client


Unread count no longer passed to launcher

Expected behavior
Launcher via tesla unread (nova launcher) displays unread count
Actual behavior
It doesn't - it does work in 5.6
Environment
K-9 Mail version: 5.7xx
Android version: 9
Account type (IMAP, POP3, WebDAV/Exchange): IMAP

Duplicate of #4410


Cherry pick 46272c6 to fix cpuid

cherry-pick of https://github.com/sustainable-computing-io/kepler/commit/46272c6a585f788673953063724494e2089f46ca

/override ci/prow/security


Organizations repo list broken

Gitea version (or commit ref): master as of 2017-01-24
Git version: n/a
Operating system:
Database (use [x]):

[ ] PostgreSQL
[ ] MySQL
[x] SQLite

Can you reproduce the bug at https://try.gitea.io:

[ ] Yes (provide example URL)
[ ] No
[x] Not relevant

Log gist:
master: https://gist.github.com/plessbd/b5c6542cec4dd02a248c9af0a0d96807
release: https://gist.github.com/plessbd/938decf1c447bf586369aa4c1f249bcc

Description
Somewhere between the release and master when going to an organization view as a non admin the repositories seem to be "duplicated" with "empty" repositories.  they show up the same number of times as the actual repositories which show up below.  I have attached a screenshot, as well as xorm.log output from the release and master branches.
If there is anything else I can do please let me know.

---
Want to back this issue? **[Post a bounty on it!](https://www.bountysource.com/issues/41291610-organizations-repo-list-broken?utm_campaign=plugin&utm_content=tracker%2F47456670&utm_medium=issues&utm_source=github)** We accept bounties via [Bountysource](https://www.bountysource.com/?utm_campaign=plugin&utm_content=tracker%2F47456670&utm_medium=issues&utm_source=github).

#749 fixes this issue :smile:

I thought it would when I saw the pr :)

closed by #749


chore: added Suspended, Suspending and Resuming statuses to the request status count metric

Description

Verification Steps

Checklist (Definition of Done)

[ ] All acceptance criteria specified in JIRA have been completed
[ ] Unit and integration tests added that prove the fix is effective or the feature works (tested against emulated and non-emulated OCM environment)
[ ] Documentation added for the feature
[ ] CI and all relevant tests are passing
[ ] Code Review completed
[ ] Verified independently by reviewer
[ ] All PR comments are resolved either by addressing them or creating follow up tasks
[ ] Required metrics/dashboards/alerts have been added (or PR created).
[ ] Required Standard Operating Procedure (SOP) is added.
[ ] JIRA has been created for changes required on the client side

Thanks for adding the integration test @ziccardi
I've left two comments, the PR should be good to merge once they are addressed.


SDDS WatchPoint File

Changing the scale of the y-axis while plotting data from a watchpoint file results in this error:
ValueError: The truth value of an array with more than one element is ambiguous. Use a.any() or a.all()
from line 608 of rbdcp.py, currently commented it out

may cause other plots to not scale but have not so far run into this problem with the files on hand.


Multiple justfiles in same dir?

Is it possible to have multiple justfiles in the same dir? How to disambiguate them?

Just supports -f / --justfile for selecting which justfile should be used, which must be paired with --working-directory to set the working directory. So, if you have foo.justfile, you can invoke it with just -f foo.justfile -d .
I'm not entirely sure I made --justfile require --working-directory, so let me know if that's too annoying.

Thanks. Yeah, I think it should default to . as working directory if the arg is not specified.


live migration of encrypted volume fails with nfs

ISSUE TYPE

Bug Report

COMPONENT NAME

API

CLOUDSTACK VERSION

4.18.1

CONFIGURATION

NFS shared storage
OS / ENVIRONMENT

SUMMARY

When doing migration via 'migrateVMwithVolumes' API I get an exception for missing secret
STEPS TO REPRODUCE

1. deploy a VM
2. add a data disk which is encrypted
3. migrateVirtualMachineWithVolumes to another storage/host
4. Observe the error

EXPECTED RESULTS

migration should pass

ACTUAL RESULTS

fails

2023-11-21 06:35:03,397 INFO  [resource.wrapper.LibvirtMigrateCommandWrapper] (agentRequest-Handler-1:null) (logid:455553da) Migration thread of VM [i-2-3-VM] finished.
2023-11-21 06:35:03,397 DEBUG [agent.properties.AgentPropertiesFileHandler] (agentRequest-Handler-1:null) (logid:455553da) Property [vm.migrate.domain.retrieve.timeout] has empty or null value. Using default value [10].
2023-11-21 06:35:03,398 ERROR [resource.wrapper.LibvirtMigrateCommandWrapper] (agentRequest-Handler-1:null) (logid:455553da) Can't migrate domain [i-2-3-VM] due to: [org.libvirt.LibvirtException: Secret not found: no secret with matching uuid '06292cd0-349c-32d9-b0d4-bfaaf7844efa'].
java.util.concurrent.ExecutionException: org.libvirt.LibvirtException: Secret not found: no secret with matching uuid '06292cd0-349c-32d9-b0d4-bfaaf7844efa'
	at java.base/java.util.concurrent.FutureTask.report(FutureTask.java:122)
	at java.base/java.util.concurrent.FutureTask.get(FutureTask.java:205)
	at com.cloud.hypervisor.kvm.resource.wrapper.LibvirtMigrateCommandWrapper.execute(LibvirtMigrateCommandWrapper.java:296)
	at com.cloud.hypervisor.kvm.resource.wrapper.LibvirtMigrateCommandWrapper.execute(LibvirtMigrateCommandWrapper.java:86)
	at com.cloud.hypervisor.kvm.resource.wrapper.LibvirtRequestWrapper.execute(LibvirtRequestWrapper.java:78)
	at com.cloud.hypervisor.kvm.resource.LibvirtComputingResource.executeRequest(LibvirtComputingResource.java:1848)
	at com.cloud.agent.Agent.processRequest(Agent.java:662)
	at com.cloud.agent.Agent$AgentRequestHandler.doTask(Agent.java:1082)
	at com.cloud.utils.nio.Task.call(Task.java:83)
	at com.cloud.utils.nio.Task.call(Task.java:29)
	at java.base/java.util.concurrent.FutureTask.run(FutureTask.java:264)
	at java.base/java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1128)
	at java.base/java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:628)
	at java.base/java.lang.Thread.run(Thread.java:829)
Caused by: org.libvirt.LibvirtException: Secret not found: no secret with matching uuid '06292cd0-349c-32d9-b0d4-bfaaf7844efa'
	at org.libvirt.ErrorHandler.processError(Unknown Source)
	at org.libvirt.ErrorHandler.processError(Unknown Source)
	at org.libvirt.Domain.migrate(Unknown Source)
	at com.cloud.hypervisor.kvm.resource.MigrateKVMAsync.call(MigrateKVMAsync.java:124)
	at com.cloud.hypervisor.kvm.resource.MigrateKVMAsync.call(MigrateKVMAsync.java:27)
	... 4 more

Looks like, the same applies for powerflex storage as well, we are not allowing the migration at service layer itself.
if (srcStoragePoolVO.isManaged() && srcStoragePoolVO.getId() != destStoragePoolVO.getId()) {
    throw new CloudRuntimeException("Migrating a volume online with KVM from managed storage is not currently supported.");
}

We can consider this as an enhancement to allow "migrateVMwithVolumes" API to handle volume migration as well for both managed and NFS storages.

@borisstoyanov I think 4.18.0 version also has the same issue. Updated the version in description.

2023-11-21 06:35:03,397 INFO  [resource.wrapper.LibvirtMigrateCommandWrapper] (agentRequest-Handler-1:null) (logid:455553da) Migration thread of VM [i-2-3-VM] finished.
2023-11-21 06:35:03,397 DEBUG [agent.properties.AgentPropertiesFileHandler] (agentRequest-Handler-1:null) (logid:455553da) Property [vm.migrate.domain.retrieve.timeout] has empty or null value. Using default value [10].
2023-11-21 06:35:03,398 ERROR [resource.wrapper.LibvirtMigrateCommandWrapper] (agentRequest-Handler-1:null) (logid:455553da) Can't migrate domain [i-2-3-VM] due to: [org.libvirt.LibvirtException: Secret not found: no secret with matching uuid '06292cd0-349c-32d9-b0d4-bfaaf7844efa'].
java.util.concurrent.ExecutionException: org.libvirt.LibvirtException: Secret not foun

@harikrishna-patnala
do we need to set the milestone ?

@harikrishna-patnala setting 4.18.2 for now, please update

This happens when VM is live migrated along with migration of an encrypted data volume to a different pool. If the data volume is not moved to a different pool explicitly, the test case might pass.
StorageSystemDataMotionStrategy.copyAsync()

                if (isNonManagedNfsToNfsOrSharedMountPointToNfs) {
                    migrateDiskInfo = new MigrateCommand.MigrateDiskInfo(srcVolumeInfo.getPath(),
                            MigrateCommand.MigrateDiskInfo.DiskType.FILE,
                            MigrateCommand.MigrateDiskInfo.DriverType.QCOW2,
                            MigrateCommand.MigrateDiskInfo.Source.FILE,
                            connectHostToVolume(destHost, destVolumeInfo.getPoolId(), volumeIdentifier));
                } else {
                    migrateDiskInfo = configureMigrateDiskInfo(srcVolumeInfo, destPath);
                    migrateDiskInfo.setSourceDiskOnStorageFileSystem(isStoragePoolTypeOfFile(sourceStoragePool));
                    migrateDiskInfoList.add(migrateDiskInfo);
                    prepareDiskWithSecretConsumerDetail(vmTO, srcVolumeInfo, destVolumeInfo.getPath());
                }

prepareDiskWithSecretConsumerDetail(vmTO, srcVolumeInfo, destVolumeInfo.getPath()); needs to be called for NonManagedNfs.. also, otherwise the secret on the destination host will be configured with the source volume's path.
The code, it seems like, is present since vol encryption was first introduced in 4.18.0

isn't this considered a serious issue @sureshanaparti ?

isn't this considered a serious issue @sureshanaparti ?

@rohityadavcloud this is there since volume encryption feature (in 4.18.0), seems to be an improvement on top of current volume encryption functionality and it needs proper testing. moved to next milestone for now, any concerns?

Fixed in https://github.com/apache/cloudstack/pull/9222


(WIP) PR for experimental Vector work via hacked C-4.x (4.0.10-SNAPSHOT)

DO NOT MERGE!!!
What this PR does:
Branch/PR for verifying changes needed for Vector type/value support
Which issue(s) this PR fixes:
Checklist

[ ] Changes manually tested
[ ] Automated Tests added/updated
[ ] Documentation added/updated
[ ] CLA Signed: DataStax CLA

No longer needed, closing.


Fix CI regressions, make tests work with JupyterLab 3.4

Maintenance-only PR

@meeseeksdev please backport to 3.x


Unable to publish site, API return 503 and 504 errors

The job fails frequently.

Jobs list: https://github.com/hugomods/site/actions/workflows/cloudflare-page.yaml?query=is%3Afailure
503 fail job: https://github.com/hugomods/site/actions/runs/6453048076/job/17515963221
504 fail job: https://github.com/hugomods/site/actions/runs/6454073460/job/17518863187

https://www.cloudflarestatus.com/


Error during save

Dear Developers,
How can I save the file, I got this error:
Failed to save 'TextArea1.stories.jsx': Unable to write file '\\Kivitelezes2\VauStaff\vsm-frontend\src\comps\datasheet\mui\TextArea1.stories.jsx' (Unknown (FileSystemError): UNC host 'Kivitelezes2' access is not allowed. Please update the 'security.allowedUNCHosts' setting if you want to allow this host.)

https://code.visualstudio.com/docs/setup/windows#_working-with-unc-paths


docs: Drafts for new documentation

Here is a draft with the details on Jest configuration for new documentation. Inspired by recent questions from users and discussions around them. Somehow it all pulled together into a structure. Hope it makes sense. (It is assumed that #132 landed and brand new transformer was included in the preset.)
@ricardogobbosouza If I got it right, you were planing to rework the docs. Feel free to use this writing anyhow you like. I could also try to draft other parts of the docs. Let me know what would be the best.

@mrazauskas I had already started writing the documentation.
But I used yours too.
I'm closing, I opened a new PR #149


Benchmarks

I ran some performance tests locally using BenchmarkDotNet. Here's the results.
Mean   : Arithmetic mean of all measurements
Error  : Half of 99.9% confidence interval
StdDev : Standard deviation of all measurements
Median : Value separating the higher half of all measurements (50th percentile)
1 us   : 1 Microsecond (0.000001 sec)
Version 1 - Austin

Method
Mean
Error
StdDev

TryParseDocument
37.64 ms
2.538 ms
7.483 ms

ParseDocument
38.77 ms
2.549 ms
7.515 ms

ParseDocumentAsync
38.24 ms
2.157 ms
6.360 ms

Version 2

Method
Mean
Error
StdDev
Median

Render_Template_Amario_Beautified
1,170.1 us
52.85 us
154.18 us
1,103.5 us

Render_Template_Amario_Minified
1,065.5 us
21.23 us
54.03 us
1,053.5 us

Render_Template_ManyHeroes_Beautified
780.1 us
8.21 us
7.27 us
779.2 us

Render_Template_ManyHeroes_Minified
771.8 us
10.07 us
9.42 us
772.7 us

Nice :)...I hope you are going to submit that ;)

Nice :) ... I hope you are going to push that ;)
I have analyzed that with dotTrace, but the majority of time is spent with the StringBuilder. No idea how to optimize this further.

I've created PR now. I'm gonna create new branch for the xml entity issue.


Syntax error with GraphQL validation

Before opening, please confirm:

[X] I have installed the latest version of the Amplify CLI (see above), and confirmed that the issue still persists.
[X] I have searched for duplicate or closed issues.
[X] I have read the guide for submitting bug reports.
[X] I have done my best to include a minimal, self-contained set of instructions for consistently reproducing the issue.
[X] I have removed any sensitive information from my code snippets and submission.

How did you install the Amplify CLI?
No response
If applicable, what version of Node.js are you using?
No response
Amplify CLI Version
7.6.21
What operating system are you using?
Mac
Did you make any manual changes to the cloud resources managed by Amplify? Please describe the changes made.
No
Amplify Categories
api
Amplify Commands
Not applicable
Describe the bug
When you have a syntax error on a directive we get a stack trace. Example:
type Todo @model @auth(rules: [{ allow: owner }] {
  id: ID!
  name: String!
  description: String
}

Notice that a closing ) is missing. If I run amplify-dev api gql-compile I get the following:
clitestproj $amplify-dev api gql-compile
🛑 Syntax Error: Expected Name, found {
GraphQLError: Syntax Error: Expected Name, found {
    at syntaxError (.../amplify-cli/node_modules/graphql/error/syntaxError.js:15:10)

Expected behavior
Something friendly telling me what the error in the syntax is or at least something like "hey fix your syntax you might be missing a closing brace or something"
Reproduction steps
Run compile with a syntax error
GraphQL schema(s)

# Put schemas below this line

Log output

# Put your logs below this line

Additional information
No response

Hello! Could I work on this, please?


chore(release): v1.0.1 🎉

:robot: I have created a release *beep* *boop*
1.0.1 (2022-10-09)
Bug Fixes

exports: export the methods and types (ab247b1)

This PR was generated with Release Please. See documentation.

:robot: Release is at https://github.com/ehmpathy/google-trends-api-client/releases/tag/v1.0.1 :sunflower:


New Features

Under this issue, ask for new features you want. eg a web browser, etc.

you to get bitches


modify current gsa loader uri to fit network::uri

Current uri is bad for network::uri when delimiter=|

Will be fixed along with #125.

Will be fixed along with #125.

Close as fixed by #125.

Close as fixed by #125.


Adds proposed mandatory fields for brownfield-land

What type of PR is this? (check all applicable)

[ ] Refactor
[X] Feature
[ ] Bug Fix
[ ] Optimization
[ ] Documentation Update

Description
Adds the proposed mandatory fields for brownfield land. Subject to change as a result of a meeting between all planning data teams to
Related Tickets & Documents
https://trello.com/c/otLeEOAv/3565-brownfield-land-mandatory-fields
QA Instructions, Screenshots, Recordings
Can be tested by running the pipeline locally on the brownfield-land collection and checking for mandatory field issues generated
Added/updated tests?

[ ] Yes
[X] No, and this is why: "Specification" update
[ ] I need help with writing tests

[optional] Are there any dependencies on other PRs or Work?
Only to be merged after cross-team brownfield land meeting

Paul mentioned on #541 that we could populate OrganisationURI on an LPA's behalf. Adding this here for @CharliePatterson and @eveleighoj to consider.


First time sign in screens

What
First time Sign in screens all linked up
Refactor the forgotten password components slightly to reduce duplication. Large parts of it are used for the First time Sign in change password.
In addition have given the Sign in screen a bit of a refactor, aware that there are further improvements that can be done on this screen mind.
The user journeys for Authentication should be similar to the initial designs:
https://www.figma.com/file/TykOuMm6oKChMHw0pbmlkx/Sign-In?node-id=31%3A0
How to review

Check that the code looks ok
Give the new feature a spin ( First time sign in )
Check sign in still works
Check forgotten password journey still works

Check First time Sign in
To check fully there are a few steps that need to be jumped through, but these guided steps should give you all that you need.
If you already have a Cognito account for whichever user pool you are testing against and you wish to reuse that account, you can delete it via the AWS CLI command:
aws cognito-idp admin-delete-user --user-pool-id {user-pool-id} --username {email-address}
Startup the dp-identity-api by running: make debug ALLOWED_EMAIL_DOMAINS="@ons.gov.uk<EMAIL_ADDRESS>Please note that you will need to use an email for a latter step that you have access to the inbox of, please replace the ALLOWED_EMAIL_DOMAINS with an email domain you will later use for this.
In Florence run make node-modules and then proceed to start Florence server-side with the feature flag ENABLE_NEW_SIGN_IN=true (Via the usual make debug command)
Then create a new account with a REST client (e.g. ARC or POSTMAN)
Endpoint: http://localhost:25600/v1/users
Method: POST
Body: {
  "forename": "something",
  "lastname": "somethingElse",
  "email"<EMAIL_ADDRESS>}

(Note you must be able to access whatever email inbox you are using for this test and you will need to ensure the domain is valid, matching one you used to start the application with in the first step).
Once complete checkout your email account for that user. You should have an invitation email. Inside that email is a link to Florence (it will likely be pointing to publishing in develop, there is work to set this up for local dev which is WIP). Copy the password code from the email (note if you triple-click it to select all there will be an additional space at the beginning which is also copied - there is a task to adjust the email template to adjust for this).
Go to http://localhost:8081/florence/login enter your email and paste or type the password code from the email, removing any white space which might have been copied at the beginning of the password.
You should be then told to change your password. Go ahead and do this. You will need a Symbol character for the time being included in your password - a bug ticket has been raised on the backend to fix this issue (just a config issue). When complete you should see a screen saying so. This screen has a button 'start using florence' it makes a request to the permissions endpoint but currently, this endpoint is not functioning as expected there is a backend ticket to resolve this issue.
Test Sign in still works
Open the browsers developer tools and open the network tab
With your new password and email attempt to sign in, this will error saying failed to get permission - there is work on the backend to resolve this. But, in the network tab ensure you see a request to the /tokens endpoint that is a success.
Test the forgotten password journey
On the sign-in screen click the forgotten password link
Enter your email
Go to your inbox
Click the link (note it will likely take you to develop publishing (this is fine, the email template is a bit WIP in another task and will later be using a lambda) copy everything in the URL from /florence onwards and then go back to http://localhost:8081/florence/ and replace /florence with the contents of your clipboard. The URL now looks something like: https://publishing.develop.onsdigital.co.uk/florence/password-reset?vid=123456&uid=1234a56b-f0dc-478d-b065-9bfdac0000f0
Enter a new password, note like before this will require a symbol character in addition to the other validation rules listed (a change to the backend is planned to resolve this)
Who can review
Anyone except me

Git or concourse not updating the unit test passing.


[Feature]: Full File manager

Description
Add a full-featured file manager to coolify. 1 file manager in the settings tab where we can see and manage all files of the coolify instance and the reverse proxy. And a file manager at the service/application level, where we can easily manage all files of a container or service in a clean UI interface.
CC @DeVoresyah
Minimal Reproduction (if possible, example repository)

Exception or Error
No response
Version

Example image of how a full file manger could look like:

-> These would be the file manger for the WordPress container -> each container should have its own file manger

Has anybody came with a solution here?


Create LITE Regen meters

Provides an altered version of the regeneration meters plugin to fit the orbs in the RuneLITE theme pack.


Fixing Bucketing aggregations (#187)

Created a common Bucket class for all bucketting aggregations to return
Renamed TermsAggregation.Bucket to TermsAggregation.Entry to avoid
naming confusion as well as to remain consistent with TermsFacet.Entry
Created two distinct types of Aggregations:

MetricAggregations which can have nested sub-aggregations
BucketAggregations which cannot have nested sub-aggregations,
but do have a getBuckets() call which returns a list of buckets

Created a RootAggregation object as a filler to house an empty MetricAggregation
used in SearchResult
Updated tests to reflect changes

Coverage remained the same at 50.26% when pulling 9bf1538e3f6e371c25e727442cd372f98316f025 on cfstout:Fixing_bucketing_aggregation_187 into e959f0f37943e21b2c407df547f17688f208cb50 on searchbox-io:master.


simple-reminder: add initial version of the extension

Description

Add new Simple Reminder extension.
This extension lets the user set reminders by using natural language (in plain english only) and without having any dependency on third party applications. When the time for the reminder is reached then the extension will notify the user with a system notification.
Full features:

"Add-reminder" command to set a new reminder in the system by interpreting natural language
List of the existing reminders
Action to delete existing reminders
Background task to notify the user with a system notification when the reminders date and time is up

Screencast

Checklist

[x] I read the extension guidelines
[x] I read the documentation about publishing
[x] I ran npm run build and tested this distribution build in Raycast
[x] I checked that files in the assets folder are used by the extension itself
[x] I checked that assets used by the README are placed outside of the metadata folder

I'm not sure the "Set Reminder" list item is the best way, depending on how many items you have you could do something like it's done in this extension: https://www.raycast.com/maggie/todo-list

I'm not sure the "Set Reminder" list item is the best way, depending on how many items you have you could do something like it's done in this extension: https://www.raycast.com/maggie/todo-list

I’ll take a look at it, and try to spot the location where I can actually listen to an Enter event. Ty for the suggestion


Update uk.po

Thank you for your good tool.
Please accept these changes translation.

Please submit the updates at Crowdin — see the README.

Ok. The work is done.


Very strange bugs

I fired up this application and sat at my desk in eager anticipation. Lo and behold, upon starting, my computer BSOD'ed. I sighed and rebooted my machine. The second time I opened the program, green lines of code in some strange language began running down my laptop screen. All efforts to close the application failed, as all other processes began choking and breaking into spasms before being claimed by the reaper. Beads of sweat ran down my face as strange and terrible images began flashing, faster and faster. My eyes glazed over as all reason left mehailCthuluyogdoalboat1245v12049mv01246vnh0n

What kind of peripherals were plugged into your computer when this happened?


use monotonic clock

fixes #22

I like this change, but could getMilliseconds be made to work in the case where process or process.hrtime do not exist?

What about using Moment.js instead?

If anyone has interest in seeing this merged, can you modify the getMilliseconds method to fall back to +new Date() in the case of process or process.hrtime not being defined (i.e. browsers)?

Addressed by #44


Can not change version info of exe file

Dear all,
When I run sample source on help document to change version infor for a dll file (ex: C:\demo.dll),
i see that it was changed,
but if change file name to exe file ("C:\demo1.exe"), it could not changed.
Have got anyone tell me why ?
Can Resourcelib be change version infor for exe file ?
Pls help me.

Yes, ResourceLib can definitely change resources in executables, so something odd is going on. Often it's a locale problem where the resource in one language is read and another is written or something like that. It could be other things too. I suggest you compare the resources in the before and after versions and see what ResourceLib wrote and what the difference is.

Thank for your answer !
Sorry for my mistake. Executable file did i used to try can be wrong. I replaced other files and they have been changed correctly.

I'll close this. If you have a case where the written data is wrong into your executable, do open a bug.

Sorry, could you guide me how to change version information of exe which is created by .NET ( .NET assemblies). I've changed to ResourceUtil.NEUTRALLANGID in my source code but nothing changed.
Regards

I don't think there's anything special about .NET assemblies.

Thank you. I found solution for my issue.


Update System.Drawing.Common to v7

Breaking change (of a sort) due to new dependency

I'm...not sure why I noted that this was a breaking change with a new dependency. https://www.nuget.org/packages/System.Drawing.Common/#dependencies-body-tab clearly says that dependencies have not changed, nor have dependencies changed for Microsoft.Win32.SystemEvents.
So, um, fixed in 12f10ddc33738485e208f64964a9cb448007c393 && 2.2.2.