Autocompletion does not work

Issue Type: Bug
Update the VSCode to the latest version.
Try to type in keywords or paths inside the TS code.
Nothing happens, the formatting does not work properly too.
VS Code version: Code 1.33.0 (0dd516dd412d42323fc3464531b1c715d51c4c1a, 2019-04-04T15:14:28.026Z)
OS version: Windows_NT x64 10.0.17134

System Info

Item
Value

CPUs
Intel(R) Core(TM) i5-3470 CPU @ 3.20GHz (4 x 3203)

GPU Status
2d_canvas: enabledchecker_imaging: disabled_offflash_3d: enabledflash_stage3d: enabledflash_stage3d_baseline: enabledgpu_compositing: enabledmultiple_raster_threads: enabled_onnative_gpu_memory_buffers: disabled_softwarerasterization: enabledsurface_synchronization: enabled_onvideo_decode: enabledwebgl: enabledwebgl2: enabled

Memory (System)
15.89GB (7.06GB free)

Process Argv
D:\SierraGold\NetQuery-UI-ReactJS

Screen Reader
no

VM
0%

Extensions (4)

Extension
Author (truncated)
Version

vscode-styled-components
jpo
0.0.26

angelscript
ren
1.0.1

linter-xo
sam
2.3.2

quokka-vscode
Wal
1.0.205

same issue

also have been experiencing the same issue since the latest release has hit.

Likely a duplicate of #71751
See https://github.com/Microsoft/vscode/issues/71751#issuecomment-480126916 for possible workarounds
@rabinosona If that doesn't solve the issue for you, please let me know

This guide didn't help me out.
My current TS version (the workspace one):

My current package.json file:

{
"scripts": {
"test": "echo "Error: no test specified" && exit 1",
"start": "parcel ./public/index.html",
"dev": "NODE_ENV=development parcel ./public/index.html",
"build": "NODE_ENV=production parcel build --experimental-scope-hoisting ./public/index.html",
"pretty-quick": "pretty-quick",
"precommit": "pretty-quick --staged"
},
"devDependencies": {
"@babel/core": "^7.4.0",
"@babel/plugin-proposal-class-properties": "^7.4.0",
"@babel/plugin-transform-runtime": "^7.4.0",
"@babel/preset-env": "^7.4.2",
"@babel/preset-react": "^7.0.0",
"@types/react": "^16.8.10",
"@types/react-dom": "^16.8.3",
"@types/react-redux": "^7.0.6",
"@types/react-router-dom": "^4.3.1",
"@types/styled-components": "^4.1.12",
"@types/webpack-env": "^1.13.9",
"@typescript-eslint/eslint-plugin": "^1.5.0",
"@typescript-eslint/parser": "^1.5.0",
"babel-eslint": "^10.0.1",
"eslint": "^5.16.0",
"eslint-config-prettier": "^4.1.0",
"eslint-plugin-ava": "^6.0.0",
"eslint-plugin-import": "^2.16.0",
"eslint-plugin-no-use-extend-native": "^0.4.0",
"eslint-plugin-prettier": "^3.0.1",
"eslint-plugin-promise": "^4.1.1",
"eslint-plugin-react": "^7.12.4",
"eslint-plugin-react-hooks": "^1.6.0",
"eslint-plugin-unicorn": "^8.0.1",
"husky": "^1.3.1",
"parcel-bundler": "^1.12.3",
"parcel-plugin-bundle-visualiser": "^1.2.0",
"parcel-plugin-imagemin": "^2.1.3",
"postcss-modules": "^1.4.1",
"postcss-nested": "^4.1.2",
"prettier": "1.16.4",
"pretty-quick": "^1.10.0",
"react-dom": "^16.8.6",
"react-hot-loader": "^4.8.2",
"typescript": "^3.3.4000"
},
"dependencies": {
"@babel/polyfill": "^7.4.0",
"@babel/runtime": "^7.4.2",
"@babel/runtime-corejs2": "^7.4.2",
"@hot-loader/react-dom": "^16.8.6",
"@syncfusion/ej2-react-buttons": "^17.1.38",
"@syncfusion/ej2-react-grids": "^17.1.38",
"@syncfusion/ej2-react-inputs": "^17.1.38",
"@types/react-fontawesome": "^1.6.4",
"@types/react-redux": "^7.0.6",
"@types/react-router-dom": "^4.3.1",
"@types/styled-components": "^4.1.5",
"astroturf": "^0.9.2",
"connected-react-router": "^6.3.2",
"font-awesome": "^4.7.0",
"greenlet": "^1.0.1",
"history": "^4.9.0",
"immutable": "^4.0.0-rc.12",
"line-awesome": "^1.0.2",
"modern-normalize": "^0.5.0",
"parcel": "^1.12.3",
"react": "^16.8.6",
"react-animations": "^1.0.0",
"react-fontawesome": "^1.6.1",
"react-redux": "^6.0.1",
"react-router": "^5.0.0",
"react-router-dom": "^5.0.0",
"redux": "^4.0.1",
"redux-devtools-extension": "^2.13.8",
"redux-saga": "^1.0.2",
"reselect": "^4.0.0",
"semantic-ui-css": "^2.4.1",
"semantic-ui-react": "^0.86.0",
"styled-components": "^4.2.0"
},
"name": "NetQuery-UI-ReactJS",
"version": "1.0.0",
"main": "imagemin.config.js",
"repository": {
"type": "git",
"url": "git+https://github.com/saisierragold/NetQuery-UI-ReactJS.git"
},
"keywords": [],
"author": "",
"license": "ISC",
"bugs": {
"url": "https://github.com/saisierragold/NetQuery-UI-ReactJS/issues"
},
"homepage": "https://github.com/saisierragold/NetQuery-UI-ReactJS#readme",
"description": ""
}

The caches are cleared too.

@rabinosona  Can you share your project?

I am having issues with auto completion as well. It first noticed it sometime last week.
Expected: Pressing tab either tabs 4 spaces or auto completes inputed text.
Results: Tab key does not function at all. No spaces added. No auto complete. Instead I receive error:
command 'emmet.expandAbbreviation' not found
One note, if I set emmet.expandAbbreviation: false,  my tab key works again (adding spaces). I don't receive any errors but obviously there is no auto complete functionality in that case.
Also I am not seeing performance issues experienced in #71751.
These are my emmet settings:
{
"workbench.iconTheme": "material-icon-theme",
"workbench.colorTheme": "Atom One Dark",
"files.associations": {
"*.js": "javascript",
},
"emmet.showSuggestionsAsSnippets": true,
"eslint.autoFixOnSave": true,
"eslint.alwaysShowStatus": true,
"eslint.run": "onSave",
"diffEditor.ignoreTrimWhitespace": false,
"workbench.editor.enablePreviewFromQuickOpen": false,
"workbench.editor.enablePreview": false,
"gitlens.hovers.enabled": false,
"editor.minimap.enabled": false,
"window.zoomLevel": 0,
"emmet.triggerExpansionOnTab": true,
"emmet.expandAbbreviation": true,
"breadcrumbs.enabled": true,
"editor.wordWrap": "wordWrapColumn",
"editor.wordWrapColumn": 100,
"edge.format.enable": true,
}

@osogrizz Opened new issue for you: #72507

Closing as need more info to investigate
@rabinosona What specific version of @types/styled-components do you have installed? (the actual installed version, not just the version listed in the package.json) I suspect you are hitting this issue: https://github.com/DefinitelyTyped/DefinitelyTyped/issues/34391 and need to upgrade to the latest @types/styled-components


Dev/lillian/set dot net sdk v20200202 preview short term retention policy 2

Continue this Pull Request with live API running on Stage(Dogfood) cluster without issue.
Generate new version of .NET SDK for new API V2020-02-02-Preview ShortTermRetentionPolicy.

Which environment(cluster) are these cloud tests running on?

/azp run net - mgmt - ci


Add Custom Styles

Hi Brother @thespacemanatee  How are You? Hope are you...
Please add custome styles in this libray and also this will issue when mobile is in dark mode
Please as soon as possible
Thank You Brother

Hey, sorry for the long delay (holiday period), will try to look at this when I'm free!


upgrade to rxjs v6

CI is green because it doesn't run tests :-(

I also sent out https://github.com/angular/in-memory-web-api/pull/186 to test if the CI tests fail on master already... and the tests do pass there.


Add diagnostics count to statusbar

closes #186
CHANGED

changed the default value for auto_show_diagnostics_panel to false,
before auto_show_diagnostics_panel was responsible for automatically opening and closing the diagnostics panel,
now it is responsible only for opening, as the panel will automatically close when there are no errors(no need to show an empty panel),
updated the docs for the settings I changed and added.

ADDED

new setting for configuring the visibility of the count in the status bar show_diagnostics_count_in_view_status, defaults to true,
added diagnostics count to the status bar.

Waiting for feedback, if you have something you would change, or reject, please say so.. :)

Messed up the commit history, that's why I closed it. Tried to get it in order, but didn't succeed.
Sorry for the boder :-)

Ok Tom :)
Have you any suggestion on how to avoid looping over diagnostics?

Sorry, I really haven't had time to have a closer look. Tested it last night, merged it now, going to add some small fixes in master. Nicely done!

Thank you Tom :)


Reconsider Carbon

I chose Carbon as a Svelte component library pretty early on, after trying other options only very briefly. I have a few small complaints about it so far (the stylesheet makes regular HTML defaults look less usable, so for example in components/Instructions.svelte we had to switch to their OrderedList and ListItem components).
Also, will we be required to use https://design-system.service.gov.uk/, and if so, how soon?

Also, will we be required to use https://design-system.service.gov.uk/, and if so, how soon?

Depends how quickly we want to submit Alpha. Around July is a very rough estimate.

There's no documented way to tell a https://carbon-components-svelte.onrender.com/components/Modal to be larger?! If there's embedded content that expands/contracts, it's not smart at all about handling a max size.

There is no great reason for us to stick with Carbon, very eager to find something else

Aaaaand just noticing this beauty:

When we hide the sidebar, all the buttons and text and stuff correctly disappears and isn't interactive. But the Carbon accordions are still there and clickable

Another issue I just noticed: the Carbon package isn't hermetic; we're reaching out to the network:

If we can put together our own modal popup element, we're pretty much rid of this


FIX jwtpp::rsa::load_from file left key file open.

It leads to "I/O error: Too many open files" on production server.

will be merged as part of #42. your author has been preserved


y-axis title barely visible when using a labels formatter

Codepen
https://codepen.io/philfontaine/pen/dyPJjJE

I'm creating a chart that looks like the one in the codepen. For an obscure reason, the y-axis title is barely visible. If you replace the condition in the formatter to always show 'Yes', then the title is correctly visible.

I guess this can be fixed the same way as #1187. Closing.


Fetching as Arrow in batches

First off, turbodbc is fantastic 👍, thanks for building it!
Do you have any plans to implement fetching data as Arrow in batches?
My use case is similar to https://github.com/blue-yonder/turbodbc/issues/159, I want to fetch data and write out parquet, and holding the entire dataset in memory is inconvenient. So it would be really nice to have an Arrow equivalent of fetchnumpybatches.

Thanks! There are no concrete plans today, but I agree that it would be a useful feature.


chore: remove french gui

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.


Serialization works for PathBuf (which is built on OsString) but not for OsString itself

serde_json appears to handle PathBuf's just fine.   The output for OsString looks like some internal rust representation rather than an actual string.   Expected it to work for OsString because PathBuf is build on OsString
    #[test]
    fn test_osstr_ser() {
        #[derive(Serialize, Deserialize)]
        struct Foo {
            p: PathBuf,
            f: OsString
        }

        let foo = Foo {
            p: PathBuf::from("/etc/passwd"),
            f: OsString::from("passwd")
        };

        println!("output: {}", serde_json::to_string(&foo).unwrap());
    }

expected:
output: {"p":"/etc/passwd","f": "passwd"}

actual results:
output: {"p":"/etc/passwd","f":{"Unix":[112,97,115,115,119,100]}}

An OsString must represent bytes that a JSON String cannot represent.
PathBuf is actually broken in its current implementation in that it just pretends that all valid OsStrings are also valid Strings and, if you feed it POSIX paths which contain non-UTF8 bytes, serialization will fail. (See #465 for details.)
You're seeing the OsString encoded as an array of raw bytes because JSON has no bytestring type.
My workaround (which I provided code for linked from #465) is to use \0 as an escape character and store a byte that's invalid in UTF-8 strings, such as a lone \xe7, as \0\u{00e7}. Since \0 is the only character not allowed in paths but valid in JSON, paths which Serde currently successfully serializes will pass through unaltered. (And it's also valid as a way to encode OsString as long as you accept that, for non-paths which were valid before, the in-JSON representation of \0 will change from \0 to \0\0.)

https://github.com/dtolnay/request-for-implementation/issues/48 recommends how to control the bytestring JSON encoding. There are some incomplete implementations; someone would need to finish one up and publish to crates.io. But it gives the ability to serialize them in base64, or hex, or potentially utf8-with-escape-sequences.


revert use of upstream yaml parsing

We found that users have a dependency on an undocumented behavior of the permissive yaml library that was changed here.
Using a block like below caused the yaml parsing to fail the whole roleArn section. This is a contract change and should be done behind a feature flag . Any yaml value starting with { would cause the failure.
If not done, customers upgrading to the new server version would see mapping error when cache is lost on authenticato restart.
    - groups:
      - systems:master
      rolearn: arn:aws:iam::xxx:role/testrole
      username: {{SessionName}}

We were a customer affected by this during the 1.22 upgrade, and while it was frustrating, I'd argue that the change that this reverts would be fine if documented in the 1.22 upgrade notes.

We just had a production issue due to this. We are running 1.21 and a normal AWSWesleyClusterManagerLambda-Add-AddonManagerRole process ran against each cluster and generated the following error:
"There was an error parsing the config maps.  Only saving data that was good, error parsing config map: [yaml: invalid map key: map[interface {}]interface {}{"SessionName":interface {}(nil)}]"
This broke our aws-auth file and nodes were no longer bound to the control plane, and our user mappings were broken, preventing us from accessing the cluster.
Our aws-auth format using {{AccountID}} and {{SessionID}}has been in use since 2018 without issue.
This is a serious oversight and should be corrected before more orgs are impacted by it.

I would like to also note that the use of {{AccountID}} and {{SessionID}} is mentioned in the README, so that seems fairly well documented.


Compiles with errors when with adMod Free

I'm submitting a ...  (check one with "x")

[ ] question
[x] any problem or bug report

OS:  (check one with "x")

[x] Android
[ ] iOS
[ ] Browser

cordova information:  (run $> cordova plugin list)
c:\strony\www\ionic\myApp>cordova plugin list
cordova-admob-sdk 0.24.1 "AdMob SDK"
cordova-plugin-admob-free 0.27.0 "Cordova AdMob Plugin"
cordova-plugin-device 2.0.2 "Device"
cordova-plugin-googlemaps 2.6.2 "cordova-plugin-googlemaps"
cordova-plugin-ionic-keyboard 2.2.0 "cordova-plugin-ionic-keyboard"
cordova-plugin-ionic-webview 4.1.3 "cordova-plugin-ionic-webview"
cordova-plugin-splashscreen 5.0.2 "Splashscreen"
cordova-plugin-statusbar 2.4.2 "StatusBar"
cordova-plugin-whitelist 1.3.3 "Whitelist"
cordova-promise-polyfill 0.0.2 "cordova-promise-polyfill"

If you use @ionic-native/google-maps, please tell the package.json (only @ionic-native/core and @ionic-native/google-maps are fine mostly)
@ionic-native/core : ^5.0.0
@ionic-native/google-maps :

Current behavior:
With ionic clean sidemenu project I have both Your plugin and AdMob Free (https://github.com/ratson/cordova-plugin-admob-free).
It does not compile without errors.
Your plugin and AdMob Free have<EMAIL_ADDRESS>Here ares install commands:
ionic cordova plugin add cordova-plugin-admob-free --save --variable ADMOB_APP_ID="ca-app-pub-x~x" --variable PLAY_SERVICES_VERSION="15.0.1"
ionic cordova plugin add cordova-plugin-googlemaps --variable API_KEY_FOR_ANDROID="xxx" --variable PLAY_SERVICES_VERSION="15.0.1"

Expected behavior:
Should compile
Screen capture or video record:

I don't support the conflict with other plugins. Please ask to the AdmobFree developer, or give up to use this plugin.

Maybe from error description You could give me some clues how to solve it?

Only readable hint from the screen capture is there was a dex merge error.

Issue solved: https://github.com/ratson/cordova-plugin-admob-free/issues/405
Thanks


Change cluster prefix from Saturn to Terra

When a user spins up a new cluster from Terra, the prefix of the cluster is still saturn-. We should change it to Terra so that it is easier for users to know where the cluster originated.

Users never see the cluster name. I think Saturn is fine for now


[MRTK3] Updating Hand Menu & Near Menu prefabs and examples to Canvas

Overview
Updated Hand Menu and Near Menu prefabs and examples to canvas.
Known issue: In Near Menu, the Pin button's toggle state is not properly updated when the user uses manipulation bar to grab and place it in the space. This is due to missing SetToggled() function in PressableButton (MRTK2 parity)
Issue opened #10975
Changes

Fixes: #10930 #10931

Thanks @cre8ivepark for the PR! Overall looks good. Could you remove the missing events on the following three GameObjects?

Looks like the new sample menu here was built with non-Canvas controls @cre8ivepark; could we standardize on building new content with the Canvas tooling please?


Bug: thumbnailPath on iOS is always showing old thumbnail even if thumbnail is changed

Current behaviour:
On iOS, if you change the thumbnail/photo of contact from one thumbnail to another, and then use the function getAll the thumbnailPath will not change to the new thumbnail. Likewise if you remove the thumbnail of contact and use getAll the thumbnailPath will still show the old thumbnail.
Steps to reproduce:
On iOS:

Create a new contact without a thumbnail/photo (by using the Contacts app in iOS)
Use getAll to verify that thumbnailPath is empty on the new contact
Go to the contact again and add a thumbnail. Verify getAll will now show the thumbnailPath
Change contact thumbnail to another photo. Verify getAll will now NOT show the new thumbnailPath.
Remove contact thumbnail. Verify getAll will now NOT show an empty string in thumbnailPath, but still show the old thumbnail.

Expected behaviour:
I expected the thumbnailPath to always match the latest data on the contact (e.g. updated thumbnail, removed thumbnail). On Android it works as I expect.
Information:
Version: 0.8.1
Platform: iOS
Worked before: I can't confirm

I was wondering when this would be noticed.
The thumbnails are stored as files in the caches dir, and once written, aren't overwritten (unless the OS deletes them).  The reason for this was to improve performance.  Creating the thumbnails is incredibly slow, and for those address books that have thousands of contacts it just wasn't feasible to recreate the contact thumbnail each time.
So, I have though about some ideas that might work around the problem while keeping the performance as is.

Add a method to "refresh" the thumbnails (asynchronously so as not to block the ui)
Add option to getAll to force recreation of thumbnails (which would be slow)
Add option to getPhotoForId to force recreation of thumbnails (which would be slow)
Detect when contacts are changed and regenerate the thumbnail in demand (actually no idea if this is possible)

...any other ideas?

Hey @npomfret
That is some very good ideas. My thoughts are:

IMO if any function is just a bit "heavy" we should switch to an async approach / Promise-based in JS. Just so we can avoid the UI being blocked. This includes getAll.
A refresh method might be good, but then again - how would I know when to use it? I can't get a clue if the user has changed any thumbnails. A "force: true" to getAll to ensure all data is new might be better a way.
To your point 4: If we somehow very easily (read: non-heavy-action) could get some kind of hash of the contacts data, and then being able to compare if the data has changed, that would be good. Then one would be able to identify if a getAll with "force: true" is needed.

What do you think?

@npomfret any update?

Not yet, sorry.  I think adding a forceRecreateThumbnails option to the 2 methods might be the best way to go for now.  The UI shouldn't get blocked, as long as the work is done on the correct thread.  My worry was that it's just very very slow. But having the option I guess would allow the developer to make they own choice.  I guess we just need to be clear in the docs that it can be slow when the address book is large.  And the default behaviour should be not to force recreation.
There is of course a workaround already.  You could just delete the image files - the thumbnails will be created if they aren't there.  Using something like react-native-fetch-blob to access the file system and delete them is pretty easy.
Thoughts?

I think this is maybe solution for me:
-(NSString ) getFilePathForThumbnailImage:(CNContact) contact recordID:(NSString*) recordID
{
NSString *filepath = [self thumbnailFilePath:recordID];
//    if([[NSFileManager defaultManager] fileExistsAtPath:filepath]) {
//        return filepath;
//    }
if (contact.imageDataAvailable){
    NSData *contactImageData = contact.thumbnailImageData;

    BOOL success = [[NSFileManager defaultManager] createFileAtPath:filepath contents:contactImageData attributes:nil];

    if (!success) {
        NSLog(@"Unable to copy image");
        return @"";
    }

    return filepath;
}

return @"";

}

@jesperlndk any update?

Nope
tir. 18. dec. 2018 kl. 11.08 skrev Andrii<EMAIL_ADDRESS>
@jesperlndk https://github.com/jesperlndk any update?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/rt2zz/react-native-contacts/issues/169#issuecomment-448166735,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AFcXFpsC6TJyHMxm2k0bpqyoYczyD55Bks5u6L6egaJpZM4M5r35
.


Upgrade to Next 15 + React 19

Summary
Update Next.js to latest to ensure reliability and security of the forms app

Updates React 19
Improves app performance
Enhanced Security for Server Actions
Updates to use Turbopack by default

Faster initial compile of a route
Faster Fast Refresh
Less flakiness in compile times
Development builds that closely match production

PR
https://github.com/cds-snc/platform-forms-client/pull/4468
Preview url:  https://fe5xi5g32slhirpnfz3zkw2vpy0tdafc.lambda-url.ca-central-1.on.aws/

@Abi-Nada if we have any folks that can do some general click around testing for this one that would be very helpful.
I have testing the following ---

[x] Test login / out / reset / re-send code
[x] Test support form
[x] Test contact form
[x] Test request publishing
[x] Test invite a user to a form
[x]  Test create / submit
[x] Test download responses
[x] Test profile / security questions
[x] Test account sign-up
[x] Test admin - accounts, feature flags etc...
[x] Check static pages
[x] Test share


modify shaders

hello ,how can I modify globe`s shader without changing Source code

Please use the Cesium forum for asking questions. It would help if you post what you're trying to accomplish. You may find the discussion in this thread useful: https://community.cesium.com/t/how-to-create-aspect-map-in-cesium/7701.


Thanks to the author for sharing your very good work. I would like to ask the author where is the regularization method? i didn't find it

Thanks to the author for sharing your very good work. I would like to ask the author where is the regularization method? i didn't find it

Dear<PHONE_NUMBER>,
thanks for your interest. The regularization is in the hutil.py in both the folders. The loss is named "hype_triplet_losses".


Reached the limit on the maximum number of files in use:  100

We are using tail for path like
/var/log/*/*.app.*.log

Is it possible increase filesLimit in config?

open_files_limit do the job, closed


How to drop node when parent node is collapsed?

Hi Team,
Thanks for the great directive.
I need small help i.e. i have two trees. I can able to drag from tree1 to tree2 when parent node is expanded. Now I am unable drop child node when parent node is collapsed. Please help me on this issue.
Sample code would be more help.
Thanks in advance.

I've worked on expanding a collapsed node on hovering. See #539. Does that work for you?

Thanks for the reply Voles ... But it doesn't work...
If i can get parent on which child was dropped it will help...
To be clear if child1 is dropped on parent 1 , is there way to get parent 1?

I found a workaround:
Simply add a treeController.expandOnMouseHover($event, this)

+1. @Voles when it will be available in bower?

expand on hover is now a feature in this project


Use TSDX for bundling

I've suggested it in the past and now when conversion to TS is happening, this is a good opportunity.
Names of distribution files have changed. It matters for UMD only and I made a simple file copy so it's not a breaking change for now.
Fixes #820

I am noticing that we aren't building development and production version of the ES modules. Was that intentional? See screenshot below of modules in the distribution folder.

Yes, that's intentional because you cannot run ES anywhere without bundling it which means bundler will take care of creating appropriate version based on env.


Fix smokeTest artifact directory

smokeTest results were not being posted onto CircleCI's artifact listing.  The tests were being run, but results were not being posted.

@sgpearse the driver script, smokeTests.py, would be much more helpful if it echoed all of the commands that it invoked so that you can easily identify and rerun the executable with the appropriate arguments.

@clyne This PR fixes a bug that was preventing our tests on different grid shapes (1x1x1, 8x8x1, etc).  The test for 8x8x1 is currently failing due to an assertion in LayeredGrid.cpp:160, shown below.  I took a look at it but I'm not sure there is an obvious fix.  I'm not sure if this relates to #2197.
VAssert(indices[2] < nz - 1) failed in LayeredGrid.cpp, line 160

@sgpearse will remove problematic tests (dimension length = 1), convert PR from draft to read-for-review, and open a separate issue to address problem cases, which may be already fixed by #2439


Add VAT french format

Could you add a mention of the new formatter in the locale-specific section of the README file?

Good for you or missing details ? https://github.com/fzaninotto/Faker/pull/1241/commits/904d977d324108a6b346902a9738457dab18272e

Thanks!

ping @fzaninotto

Does not seem to work for me:
PHP Fatal error:  Call to undefined method Faker\Provider\fr_FR\Payment::siren() in /var/www/udboffice-app/vendor/fzaninotto/faker/src/Faker/Provider/fr_FR/Payment.php on line 24

Because the change wasn't already released


Updated retention period in cloud-recording.md

Closes https://github.com/MicrosoftDocs/OfficeDocs-SkypeForBusiness/issues/5981.

@JohanFreelancer9 Copy editing is needed for this PR. Thanks.

@tonysmit PR has been copyedited and is ready for final review, could you please check and merge? Thanks!


Background tracking is not working on (all) real devices

Your Environment

Plugin version: 0.3.1
Platform:  Android
OS version: All version
Device manufacturer and model: All devices and models
React Native version: 0.48.4
Plugin configuration options:

      BackgroundGeolocation.configure({
        desiredAccuracy: 10,
        stationaryRadius: 50,
        distanceFilter: 50,
        locationTimeout: 30,
        notificationTitle: 'Aurai ID',
        notificationText: 'Running',
        debug: false,
        startOnBoot: true,
        startForeground:true,
        stopOnTerminate:false,
        locationProvider: BackgroundGeolocation.provider.ANDROID_ACTIVITY_PROVIDER,
        interval: 900000,
        fastestInterval: 300000,
        activitiesInterval: 60000,
        stopOnStillActivity: false,
        url: publicUrl+"/test",
        syncUrl: publicUrl+"/test2",
        httpHeaders: {deviceid:device_id,key:key},
      });
BackgroundGeolocation.start();

<resources>
    <string moduleConfig="true" name="reactNativeCodePush_androidDeploymentKey">xxx-xxxx-xxx-xxxx</string>
    <string name="app_name">Aurai ID</string>
	<string name="account_type">com.auraiid.id</string>
    <string name="content_authority">com.auraiid.id</string>
</resources>

Context

Background tracking in not send any data to the url when app is running in background, get killed, or when device reboot. The notification still there, but no location was send.
Only working when app running in foreground
(Everything is working when on emulator)
Expected Behavior

The recorded locations should be send/post to the 'url' every 5 or 15 minutes when when app is running in background, get killed, or when device reboot.
Actual Behavior

No locations was send when app is in background or when  device reboot.

Same issue here. Is this an expected behaviour from the library ?

Can you guys check logs? https://github.com/mauron85/react-native-background-geolocation#debugging

Also keep in mind in android 6 and up has DOZE mode. If you're definitely sure there is no problem with your code. You can try to disable it for you apps and check if it helps.
https://lifehacker.com/how-android-doze-works-and-how-to-tweak-it-to-save-you-1785921957

Warning: this issue has been inactive for 20 days and will be automatically closed on 2017-12-26 if there is no further activity.

@mauron85, do you now how to disable DOZE mode programmatic ? It is possible ?

@mauron85 could DOZE MODE stop the background service?

@sandropoluan  @mauron85 @L3V147H4N @kholiavko-roman
I think you solved the background tracking issue.
I am facing the issue in background location tracking problem in android and iOS
Here are my issues:
iOS:
when i lock the device the background geolocation is not working. there in background i am calling some api calls. When i unlock the after 15 mints all the api calls are called at a time. But it should not happen like that
I want to call the all the apis in background only. i.e Even when the device is lock also.
Android:
In Android when the the app is open all are working fine but when the app closed, i wrote a code like setInterval inside the BackgroundGeolocation.on('background',
In iOS this function working fine but in android this not working when the app is in background, Is there any functionality need to change for android to this module.
Below is my code, Can you please check my code and give me some suggestions, Any suggestion must be helpful.
Here is the code:
https://www.dropbox.com/s/gax5hfkyps5qu9q/demo.js?dl=0

Encountered the same issue. On debugging mode the alert and the beeping occurs but the post is not done.
Any fix or a workaround for this so far ?


Update s3, sdk-core, sqs to 2.16.89

Updates

software.amazon.awssdk:s3
software.amazon.awssdk:sdk-core
software.amazon.awssdk:sqs

from 2.16.67 to 2.16.89.
I'll automatically update this PR to resolve conflicts as long as you don't change it yourself.
If you'd like to skip this version, you can just close this PR. If you have any feedback, just mention me in the comments below.
Configure Scala Steward for your repository with a .scala-steward.conf file.
Have a fantastic day writing Scala!

Ignore future updates
Add this to your .scala-steward.conf file to ignore future updates of this dependency:
updates.ignore = [ { groupId = "software.amazon.awssdk" } ]

labels: library-update, semver-patch

Superseded by #223.


DDRMenu, INodeManipulator error

Description of bug
The problem is linked to the "TabId" property of the NodeMenu class.  The TabId MUST be a valid page in DNN.  If not it drops the page from the menu.   You might think this sounds reasonable, but there is little point having a DDRMenu NodeManipulor if you can only use valid DNN pages.
If you try values of "-1, "0", "1".  The extra nodes are also dropped.  I assume that this is because the page in the DDRMenu takes on the settings of the real page and hence is hidden and does not appear on the menu.
If you use a Page that is displayed on the menu, then the extra MenuNodes will appear.  But this is little good.
Steps to reproduce
Use OpenStore and inject the categoies into the DDRMenu https://www.openstore-ecommerce.com/en-gb/
Current result
The categories will not appear.
Expected result
Categories appear in DDRMenu
Additional context
Add any other context about the bug that may be helpful for resolution.
Affected version

[x] 9.3.0
[x] 9.2.2
[x] 9.2.1  ??

If you reference Dnn 9.2.2 dll and try to compile, do you get errors or it compiles fine? I know the NodeManipulator is still there but I remember having some troubles with MenuNode or something else closely related to the nodes in another module (the gallery Core module) I tried to migrate to Dnn 9.2 and ran out of time to do it,

OK, thx for the advice Daniel.  But I have tried to compile against v9.3.0 and it compiles OK.
I can get a fix in OpenStore, because of the way we inject the menu, but I still need it fixing.

I am closing this issue in the spirit of cleaning the backlog because:

This would be risky to implement if a lot of other stuff expects the TabId to always be valid, this  could be a huge breaking change and a risk
This could have security implications regarding tab permissions
There is a way around the situation

I think we could reopen this issue only if we have an action plan and proof of concept and tests that ensure that points 1 and 2 are taken into account.

Hi Daniel, I disagree with the reasons.

What uses non existing tabs in the menu?  I doubt anything does, this was working in DNN8.  It's a bug introduced in DNN9.  Not many people compile their projects against DNN9.
Nothing on tab permissions is changed, I don't understand why you think there is a tab permissions issue?  We are simply adding links to a menu, nothing to do with security, unless you build it into the DDRMenu interface.
I found a way around in OpenStore, but not everyone would find a workaround.  Most modules that use this interface will not work in DNN9.  I suppose the only true workaround is to use another menu.

If you said, "too much time to fix", I could understand..
On the scale of what needs doing in DNN9, this is small potatoes.  I reported it because I do consider it a bug/breaking change and I think it does reflect a negative view for DNN9.  But, I'll not push anyone on this.
When DNN9 can compile, "out of the box".  I'll see if I can push the fix at you guys.
Have a good day.

You should put a "Won't fix" label on this, so people can understand without having to read it all.

Oh, I am happy to reopen for further discussions and even more if you are willing to offer something on it. I am just trying to clean stale issues and assign everything actionable to some milestone. I am setting this to the Dnn 10 milestone but it is not set in stone, let's call it a goal... :)

OK, Great. Thx. :-)

I am re-closing this issue since it was reopen for further discussion but nothing progresses since July. If there are any news, please comment or reopen.

Who's open for discussion??
I'm unsure of your approach to issues on github, but the DDRMenu Node Interface has been changed wrongly and now can not be used in many situations.  That in itself it reason to leave this issue open.
I hope closing this isn't a simple attempt to hide errors or to make stats look better?

@leedavi If an issue doesn't have any action, comment, or plan for fix after 90 days we are closing issues in an effort to keep the backlog manageable with regards to issues that have an active and tangible impact to users.
If you have a solution, that isn't breaking, we are all ears.  If you have one that is breaking, we can have ears in 10.x or 11.x

OK, I understand.  But I think closing issues gives the impression nothing needs doing or it is fixed.  If issues are like this and have a low priority, but are still an issue, I think they should go into a "low priority" category and not closed.
Having said that I do understand.  I'll see if I can get a solution.

@leedavi we are working very hard to streamline our GitHub Issue Management.  We just completed the first phase with a new Labels system (still some "clean up" to do, but all the new labels are now there) and a new Issue Triage project to help with the triage of issues.  I published a blog a month ago on the new strategy and I will be publishing a follow-up blog shortly on phase one of the new Issue Management system.  Long story short, I wanted to give you some quick insight into the fact that we are indeed trying to make improvements and to help educate on the what/why/how/etc.
Please be patient with us and help as you can.  It will be a bit of a paradigm shift, but given the number of contributing community resources, we must be more effective and efficient.  Having clear and actionable issues are a good first step.  Secondly, someone has to be willing to roll up their sleeves and contribute a fix.  Otherwise, issues just become "stale".
That said, I am happy to retroactively re-open this issue and put it through the new process.  Thanks so much and sorry for any confusion or misunderstanding.  Nobody is trying to sweep anything under the rug.  ;-)

@leedavi can you confirm this issue still exists in the latest release (9.4.4)?  Since this is a really old issue, the Affected Versions only references older versions and I'd like to verify it is still an issue before we move it into Status: Ready for Development.  Thanks.

OK, thx for the explaination David.
I think this kind of issue management is ideal.  Well done.
I'll make a note to check this exists still in 9.4.4 and post the result here.

Awesome - thanks @leedavi

@leedavi can you confirm this is still a valid issue?

Hi David,
The last I looked it did.  I've not checked DNN9.5.
I do have a work around, and am now avoiding using the iNodeManipulator for various reasons, including this one.
Can we  leave this open for a little longer please??  I'll try and find the time to investigate and get the code change required.  I remember looking and it was only a small change, but I'm unsure of the knock on effect.


Update to NB2 to add s3 file copies for custom component + IoTCore endpoint view

Issue #, if available:
Description of changes:
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

PR seems updated with the removal of "..."


process-compose: fix running processes with is_elevated

Fixes #1391.

@sandydoo is this or false actually required?

Nix's or isn't the usual boolean operator ||, in case that's your concern.

@sandydoo Thanks for the clarification!
And for the fix :tada:


[3.0] Use Container with autowire for factory/gateways

This tries to remove all new $class($client, $request) stuff and replace it with autowiring, based on the League Container.
Pros:

More flexible, gateways require what they need in the constructor (because autowiring)
Central place to register the defaults
No more new $class(..) (code smell?)

This alone shouldn't affect most usage, except that I also removed the shortnames (and register/all/replace)
Pros:

No collisions, gateways can have their own namespace if they want.
Both IDE + developer can easily see what the actual gateways

Cons:

Longer to type? (But IDE typehints/imports anyway usually)
No list of 'registered' gateways, but for this specific case, this is easily done outside Omnipay

So old:
use Omnipay\Omnipay;

$gateway = Omnipay::create('Stripe');

And new:
use League\Omnipay\Omnipay;
use League\Omnipay\Stripe\StripeGateway;

$gateway = \League\Omnipay\Omnipay::create(StripeGateway::class);

ping @delatbabel  because you opposed the use of class names before ( in #274). Would this still be okay for you, as you can still use string names, expect only longer ones..

I think that one of the good things with OmniPay 2.0 method, which is:
use Omnipay\Omnipay;
$gateway = Omnipay::create('Stripe');

... is that I don't have to specifically change my code to initialise the Stripe gateway.  As soon as I have to specifically use the Stripe gateway to initialise it that means a code change each time I want to add a new gateway (admittedly I have to change composer.json anyway but that's not the point).
When I'm working in a multi-gateway environment that's more maintenance for me.
I guess this still fulfils my main criterion of having a Gateway->initialisation parameter mapping stored somewhere in the database but I would prefer not to have the explicit use statement.

But you can still do this:
use League\Omnipay\Omnipay;
$gateway = \League\Omnipay\Omnipay::create('League\Omnipay\Stripe\StripeGateway');

The only thing that changes is that you store the class name instead of the short name?

Yes it would work, it's a bit more verbage but I'm OK with that.

Can anyone explain "autowire". What wires to what, and what part of that process happens automatically?

See http://container.thephpleague.com/auto-wiring/
The container has knowledge of some implementations (eg. which HttpClient there is etc), and instead of doen new $class, we ask the Container to resolve the class. With autowiring, it inspects the dependancies recursively, and tries to instantiate them as best as it can.
So it doesn't matter if the gateway requests HttpClient, ServerRequestFactory and some other class (or in which order), if the Container can resolve it, it instantiates them.

Ah, thanks. That makes it clearer. So it would not matter which [popular] PSR-7 client you happen to have installed, when you ask the container for a PSR-7 compatible client, that container (during its initialisation) has already got the installed client in there reader to do.

Yes, but we would have to think how to make this easily accessible to other frameworks/integrations.
In principe almost all containers support the container-interop interface, but we could create a GatewayFactory for Laravel for example, by providing a serviceprovider that uses the framework container instead of our own.
The main difference with before is that you just tell the container once which implementation you want to use for an interface, and it uses that for all instances.

Down the rabbit hole...in a good way :-) I can see where the two camps on container interop come from in the FIG - those that see an application having one container that all components use, vs a tree-like structure of containers that each component can bring along to the show as fragments.

The only caveat I can say about auto wiring and container resolution is that it's expensive in terms of processing time. Laravel uses container resolution extensively and profiling on the API components of our fairly large Laravel 5.1 application indicates that up to 30% of the total API round trip time is taken up in container resolution.

For php 5.4 you can use something like ClassNameTrait
// ClassNameTrait.php
trait ClassNameTrait
{
    public static function className()
    {
         return get_called_class();
    }
}

// Foo/Bar/PaymentGateway.php
class PaymentGateway
{
    use ClassNameTrait;
}

// example
use League\Omnipay\Omnipay;
use Foo\Bar\PaymentGateway;

$gateway = Omnipay::create(PaymentGateway::className());

Yeah but we're not supporting 5.4 in Omnipay v3, just 5.6+

Sorry, I didn't pay attention.

Updated this by PRs from @ed-fruty

A thing I'm not really happy about, is that the Gateway is actually also a factory, so the Omnipay factory creates a different factory, which also uses the Container.
Should we also have a 'MessageFactory', similar to GatewayFactory, to not depend on the Container directly?


Fix for nitro ebs volumes

This is a simple fix for issue #73
The mount_volume shell script in modules/couchbase-commons fails when the ec2 instance is based on nitro hypervisor.
This simple fix expects a unique ebs volume size, eg. 46731. It then finds the device name from lsblk.
I'm using this in our cluster but haven't run the tests.

Yes, it's possible. Waayyy less so then the current solution. ;)

Yes, it's possible. Waayyy less so then the current solution. ;)

Understood, but merging in a solution that depends on volume size will lead to a dozen more bugs filed when that doesn't work as expected! Or worse yet, overwrites a bunch of data on some volume we shouldn't be touching. I appreciate the attempt, but I'll close this PR for now. Thanks!

Understood, but merging in a solution that depends on volume size will lead to a dozen more bugs filed when that doesn't work as expected! Or worse yet, overwrites a bunch of data on some volume we shouldn't be touching. I appreciate the attempt, but I'll close this PR for now. Thanks!


Refactor class paths, addressing some differences in dev/prod

Related to https://github.com/studentinsights/studentinsights/commit/a28c61c7d462f885900096aafc9b776326c87203 and fixing up https://rollbar.com/somerville-teacher-tool/somerville-teacher-tool/items/252/?item_page=0&item_count=100&#instances.
Not sure why the precomputed job ever worked, give this setup and my current understanding of how constant autoloading works, but logs show it did until today.
Separately, this removes some duplicates classes related to PDF exports, and namespaces the classes in app/lib.

selfie


Integer overflow in getchar.c

In the file getchar.c, the function ins_typebuf relies on the following code to check for integer overflow (link):
newlen = typebuf.tb_len + addlen + newoff + 4 * (MAXMAPLEN + 4);
if (newlen < 0)		    // string is getting too long
{
    emsg(_(e_toocompl));    // also calls flush_buffers
    setcursor();
    return FAIL;
}

This assumes wrap-around behavior for signed integer overflow. However, since signed integer overflow is undefined behavior in C, I think the checking code needs to be modified. It should check for integer overflow before it happens.

Checking that the result is negative is undefined behavior, as signed overflows in C or C++ are undefined behavior (unlike unsigned overflow that wrap reliably).

This is the key point.  Any calculation that causes overflow, even temporarily, causes undefined behavior.  It's impossible to attempt to correct for this overflow case after-the-fact.
Range calculations like the one below are subject to overflow:
  if (untrusted_value + trusted_value > MAX_VALUE) {
      // untrusted_value was too large.
  }

Undefined behavior occurs if untrusted_value + trusted_value overflows.  The recommended approach for this pattern is to make comparisons only against untrusted_value directly (i.e., without doing any math on it) until the range has been verified.  This is done by subtracting trusted_value from both sides:
  if (untrusted_value > MAX_VALUE - trusted_value) {
      // untrusted_value was too large.
  }

This works because we know trusted_value does not exceed MAX_VALUE (either by design, or by previous range checking).
Here's the existing calculation from getchar.c which can overflow:
  addlen = (int)STRLEN(str);
  // ...
  newoff = MAXMAPLEN + 4;
  newlen = typebuf.tb_len + addlen + newoff + 4 * (MAXMAPLEN + 4);
  // ...
  typebuf.tb_buflen = newlen;

Here, addlen is the "untrusted" value we need to validate.  typebuf.tb_len is trusted to not exceed MAX_INT; additional invariants aren't obvious.
Given that newoff = MAXMAPLEN + 4, the subexpression newoff + 4 * (MAXMAPLEN + 4) reduces to 5 * (MAXMAPLEN + 4); this is a compile-time constant value that fits very comfortably in an int, given that MAXMAPLEN == 50 (even for 16-bit-int machines).  There is therefore no possibility of overflow during the calculation of this compile-time constant expression.  A static assertion validating that MAXMAPLEN is "small" could be added to cover the small likelihood that this value might eventually grow into the thousands.
Let OVERHEAD be this compile-time constant value:
  int OVERHEAD = 5 * (MAXMAPLEN + 4);
  // Or, equivalently:
  // int OVERHEAD = newoff + 4 * (MAXMAPLEN + 4);

The range check (without overflow consideration) is then:
  if (typebuf.tb_len + addlen + OVERHEAD > MAXINT) {
      // Overflow.
  }

Subtracting OVERHEAD from both sides:
  if (typebuf.tb_len + addlen > MAXINT - OVERHEAD) {
      // Overflow.
  }

If it's not guaranteed by Vim-wide invariants, a first check should be done to ensure that typebuf.tb_len + OVERHEAD does not overflow:
  if (typebuf.tb_len > MAXINT - OVERHEAD) {
      // typebuf.tb_len is already too large all by itself
  }

This check might well be unnecessary if typebuf.tb_len is never permitted to get that close to the limit.  (I didn't check whether other places in Vim are adjusting this value; if this is the only place, the above check would not be necessary.)
After the above check, we may subtract typebuf.tb_len from both sides to isolate the untrusted addlen value:
  if (addlen > MAXINT - OVERHEAD - typebuf.tb_len) {
      // addlen is too large.
  }

These two checks may be combined to avoid duplicating the body of the if statements:
  if (typebuf.tb_len > MAXINT - OVERHEAD ||
      addlen > MAXINT - OVERHEAD - typebuf.tb_len) {
      // Overflow.
  }

It could be useful to have a general-purpose safe_add() function for two int values, though as implemented in pull request #9067, there are some drawbacks:

A general-purpose safe_add() should accommodate any range of input values, but because of the sentinel value -1 reserved for signaling an error, it's not possible to return this otherwise-valid sum.  A signature such as the following would allow the full range of valid sums to be used:

    // Return 0 on success, -1 on overflow.
    int safe_add(int a, int b, int *sum)

The macros INT_MAX and INT_MIN are already defined in Standard C via the header limits.h, which is already included by vim.h.  It's not clear why they are being redefined in the pull request.  In addition, this definition of INT_MIN is incorrect for subtle reasons:

    #define INT_MIN -2147483648

On a two's-complement machine, the negative of INT_MIN can't be represented as an int value (it exceeds INT_MAX).  In C, there are no negative integer literals; instead, values such as -2147483648 comprise two tokens (unary negation, -, and integer literal,<PHONE_NUMBER>).  On a modern machine with 32-bit int values, the decimal literal value<PHONE_NUMBER> is too large for int, so it promotes to be of type long int; afterward, - is applied to create a negative long int constant (where an int constant is desired).
For this reason, these values are typically defined by limits.h as follows:
    #define INT_MAX<PHONE_NUMBER>
    #define INT_MIN       (-INT_MAX - 1)

Depending on what's known about the str argument for ins_typebuf(), there is still a possibility of overflow in the logic of 8.2.3595 (https://github.com/vim/vim/commit/0d5a12ea041c112b06b1aafde38846ae4cff8f4c).
The length of str is stored in int addlen; if that length can be close to MAX_INT, the calculation of extra below could overflow:
extra = addlen + newoff + 4 * (MAXMAPLEN + 4);

Is there code outside this function that ensures str is enough shorter than MAX_INT to prevent overflow in this calculation?
In the worst case, the length could possibly even be larger than MAX_INT because STRLEN() (a wrapper around strlen()) returns size_t; on 64-bit boxes, size_t is 64-bit.  I've been assuming strings are length-limited to a maximum of MAX_INT characters throughout Vim, based on the many occurrences of (int)STRLEN(); if that's not a good assumption, additional checks would be indicated to prevent strings from growing beyond MAX_INT characters.
When this function is called, if there is no guarantee that addlen <= MAX_INT - (newoff + 4 * (MAXMAPLEN + 4)), this bound must be checked to prevent overflow before computing the value of extra.

Depending on what's known about the str argument for
ins_typebuf(), there is still a possibility of overflow in the logic
of 8.2.3595
(https://github.com/vim/vim/commit/0d5a12ea041c112b06b1aafde38846ae4cff8f4c).
The length of str is stored in int addlen; if that length can be
close to MAX_INT, the calculation of extra below could overflow:
extra = addlen + newoff + 4 * (MAXMAPLEN + 4);

Is there code outside this function that ensures str is enough
shorter than MAX_INT to prevent overflow in this calculation?
In the worst case, the length could possibly even be larger than
MAX_INT because STRLEN() (a wrapper around strlen()) returns
size_t; on 64-bit boxes, size_t is 64-bit.  I've been assuming
strings are length-limited to a maximum of MAX_INT characters
throughout Vim, based on the many occurrences of (int)STRLEN(); if
that's not a good assumption, additional checks would be indicated to
prevent strings from growing beyond MAX_INT characters.
When this function is called, if there is no guarantee that addlen <= MAX_INT - (newoff + 4 * (MAXMAPLEN + 4)), this bound must be checked
to prevent overflow before computing the value of extra.

What we protect against here is a recursive mapping, adding a string
(which is unlikely to be very long) is added over and over again.
Eventually the result gets too long.  We can assume the string is not
extremely long itself.
It is close to impossible to have bound checks everywhere.  The
intention is to check where it might actually happen.
--
The question is:  What do you do with your life?
The wrong answer is: Become the richest guy in the graveyard.
(billionaire and Oracle founder Larry Ellison)
/// Bram Moolenaar -- @.*** -- http://www.Moolenaar.net   \
///                                                                      \
\\        sponsor Vim, vote for features -- http://www.Vim.org/sponsor/ ///
\\            help me help AIDS victims -- http://ICCF-Holland.org    ///

Thanks; this seems reasonable given your assumptions about the string.


Update the material plugin doc

Closes #600.

@Popov72 looks like you have a tiny conflict on this one ?


cheapify IN lookups on unsorted arrays

Scope & Purpose
Make IN lookups cheaper on unsorted VelocyPack arrays, especially those of type Compact

[x] Bug-Fix for devel-branch (i.e. no need for backports?)
[x] The behavior in this PR can be (and was) manually tested (support / qa / customers can test it)
[x] The behavior change can be verified via automatic tests

Testing & Verification
This change is already covered by existing tests, such as shell_server_aql.
http://<IP_ADDRESS>:8080/view/PR/job/arangodb-matrix-pr/9182/

http://<IP_ADDRESS>:8080/view/PR/job/arangodb-matrix-pr/9190/

http://<IP_ADDRESS>:8080/view/PR/job/arangodb-matrix-pr/9236/

http://<IP_ADDRESS>:8080/view/PR/job/arangodb-matrix-pr/9239/

Tests blue


windows / links with backslashes

Hey there,
all the cross-links are wrong inside the mdx-files if I run graphql-markdown at windows 10

and than the browser converts it to ...//...

after click you got a

thanks!!

I have to admit that I didn't test with Windows, but that will be fixed too.
Thank You for reporting the issue, it will get fixed this week, if I find enough time.

@crazyx13th - Good news! The big Windows fix PR is ready. I did some basic tests under Windows 10, but some more tests would be welcome.
If you have some time please look at #289 for more details.

This issue should be fixed with release 1.4.1.


Migrate to Amazon VPC

Amazon VPC enables complete control over your virtual networking environment, including selection of your own IP address range, creation of subnets, and configuration of route tables and network gateways.
As such it has always been the better platform from an operational perspective and a rolling update of Amazon EC2 in 2013 enabled Virtual Private Clouds for Everyone! as the default modus operandi accordingly (just completed as of December 4th).
Increasing demand suggest to tackle this now to gain the attached benefits (see https://github.com/cityindex/logsearch/issues/149#issuecomment-30306658), also, recent major CloudFormation improvements are making this much easier now (see #256).

Closed as Won't Fix due to project being retired to the CityIndex Attic.


numpy version warnings

 × python setup.py bdist_wheel did not run successfully.
  │ exit code: 1
  ╰─> [45 lines of output]

      A module that was compiled using NumPy 1.x cannot be run in
      NumPy 2.0.0 as it may crash. To support both 1.x and 2.x
      versions of NumPy, modules must be compiled with NumPy 2.0.
      Some module may need to rebuild instead e.g. with 'pybind11>=2.12'.

      If you are a user of the module, the easiest solution will be to
      downgrade to 'numpy<2' or try to upgrade the affected module.
      We expect that some modules will need time to support NumPy 2.

I think the easiest way is to limit the numpy version to <2?

otherwise got error like
Python 3.10.14 (main, May  6 2024, 19:42:50) [GCC 11.2.0] on linux
Type "help", "copyright", "credits" or "license" for more information.
>>> import torch

A module that was compiled using NumPy 1.x cannot be run in
NumPy 2.0.0 as it may crash. To support both 1.x and 2.x
versions of NumPy, modules must be compiled with NumPy 2.0.
Some module may need to rebuild instead e.g. with 'pybind11>=2.12'.

If you are a user of the module, the easiest solution will be to
downgrade to 'numpy<2' or try to upgrade the affected module.
We expect that some modules will need time to support NumPy 2.

Traceback (most recent call last):  File "<stdin>", line 1, in <module>
  File "/data/home/jun/miniconda3/envs/cuda121/lib/python3.10/site-packages/torch/__init__.py", line 1382, in <module>
    from .functional import *  # noqa: F403
  File "/data/home/jun/miniconda3/envs/cuda121/lib/python3.10/site-packages/torch/functional.py", line 7, in <module>
    import torch.nn.functional as F
  File "/data/home/jun/miniconda3/envs/cuda121/lib/python3.10/site-packages/torch/nn/__init__.py", line 1, in <module>
    from .modules import *  # noqa: F403
  File "/data/home/jun/miniconda3/envs/cuda121/lib/python3.10/site-packages/torch/nn/modules/__init__.py", line 35, in <module>
    from .transformer import TransformerEncoder, TransformerDecoder, \
  File "/data/home/jun/miniconda3/envs/cuda121/lib/python3.10/site-packages/torch/nn/modules/transformer.py", line 20, in <module>
    device: torch.device = torch.device(torch._C._get_default_device()),  # torch.device('cpu'),
/data/home/jun/miniconda3/envs/cuda121/lib/python3.10/site-packages/torch/nn/modules/transformer.py:20: UserWarning: Failed to initialize NumPy: _ARRAY_API not found (Triggered internally at ../torch/csrc/utils/tensor_numpy.cpp:84.)
  device: torch.device = torch.device(torch._C._get_default_device()),  # torch.device('cpu'),

>>>


Module parse failed: Unexpected character '#' (69:2) You may need an appropriate loader to handle this file type, currently no loaders are configured to process this file.

Environment
NUXT
"dependencies": {     "@nuxtjs/auth": "^4.9.1",     "@nuxtjs/axios": "^5.5.4",     "@nuxtjs/gtm": "^2.3.0",     "axios": "^0.19.2",     "cookie-parser": "^1.4.6",     "core-js": "^2.6.5",     "lodash": "^4.17.15",     "nuxt": "^2.13.3",     "nuxt-jsonld": "^1.4.5",     "nuxt-property-decorator": "2.3.0",     "postcss-import": "^15.1.0",     "stylus": "^0.54.5",     "stylus-loader": "^3.0.2",     "v-autocomplete": "^1.8.2",     "vue-affix": "^0.5.2",     "vue-count-to": "^1.0.13",     "vue-multiselect": "^2.1.6",     "vue-observe-visibility": "^0.4.6",     "vue-scrollto": "^2.15.0",     "vue-style-loader": "^4.1.2",     "vuex": "^3.5.1",     "vuex-class-modules": "^1.1.2"   },   "devDependencies": {     "@expo/webpack-config": "^18.0.1",     "@nuxt/types": "^2.15.8",     "@nuxt/typescript": "^2.8.1",     "@nuxt/typescript-build": "^2.1.0",     "@nuxt/typescript-runtime": "^0.3.8",     "@nuxtjs/imagemin": "^0.1.0",     "@types/node": "10.14.8",     "@types/webpack-env": "1.13.9",     "bootstrap": "^4.4.1",     "bootstrap-vue": "^2.2.2",     "nuxt-purgecss": "^0.2.1",     "sass-loader": "^7.1.0",     "webpack": "^4.39.0",     "webpack-cli": "^3.3.6",     "webpackbar": "^3.2.0"   },   "engines": {     "npm": "8.5.1",     "node": "12.13.1"   }
Reproduction
I have differents proyects with     "nuxt": "^2.13.3", but now all my projects not work.
Describe the bug
Before today All was working good, but when a installed all the dependencies again today I  had this kind of error.
Additional context
No response
Logs
Module parse failed: Unexpected character '#' (69:2) You may need an appropriate loader to handle this file type, currently no loaders are configured to process this file. See https://webpack.js.org/concepts#loaders | */ | class BlobDataItem { > #path | #start |
server.js
Missing stack frames
Js
./node_modules/node-fetch-native/dist/index.cjs@39118:7
server.js:39118:7
./node_modules/node-fetch-native/dist/index.cjs
webpack/bootstrap:25:
__webpack_require__
webpack/bootstrap:25:
__webpack_require__
.nuxt/server.js:1:
./.nuxt/server.js
webpack/bootstrap:25:
__webpack_require__
server.js:60516:18
0
webpack/bootstrap:25:
__webpack_require__
server.js:118:18
server.js:121:10

We can track in https://github.com/nuxt/nuxt/issues/10751.


Provide separate buffer size getter/setter

Much less magical than "zero value pointer gets, non-zero value pointer sets".

good simplification, like it


GroupIntoBatches transform for Python SDK

Add a PTransform that batches inputs to a desired batch size. Batches will contain only elements of a single key.
It should offer the same API as its Java counterpart: https://github.com/apache/beam/blob/11a977b8b26eff2274d706541127c19dc93131a2/sdks/java/core/src/main/java/org/apache/beam/sdk/transforms/GroupIntoBatches.java
Unlike BatchElements transform (https://github.com/apache/beam/blob/11a977b8b26eff2274d706541127c19dc93131a2/sdks/python/apache_beam/transforms/util.py#L461) GroupIntoBatches will use state to batch across bundles as well.
Imported from Jira BEAM-6696. Original Jira may contain additional context.
Reported by: altay.

already exists


Commit messages should be checked as part of the Pull Request

Is your feature request related to a problem? Please describe.
Many commits to main have been committed without any message or with a messy unreadable message. Prior to the fork, Elasticsearch's commit messages are normally helpful for understanding the reasons for a given commit. Recently I noticed a severe degradation in this respect, in the OpenSearch repo. For example, see commits #829, #712, #818 (there are many more across the project, in opensearch-dashboards and various plugin repositories as well).
Describe the solution you'd like
In CONTRIBUTING.md add the following:

Guidelines for writing good commit messages
Requirement that the commit message is provided by the pull request author as part of the review process.

Additional context
Discussion in OpenSearch forum - https://discuss.opendistrocommunity.dev/t/missing-commit-messages-and-changelogs/

We've been iterating on org-wide docs. I think I want to thin out the ones in this repo and start pointing to the ones in https://github.com/opensearch-project/.github like in https://github.com/opensearch-project/OpenSearch/pull/853. Let's see what @CEHENKLE says.

I propose the following to maintain a good code commit hygiene:

We can disable “Allow merge commits” in the (https://github.blog/changelog/2022-08-23-new-options-for-controlling-the-default-commit-message-when-merging-a-pull-request/) - I’m assuming individual commits will not matter for 90%+ cases. Only keep “Allow squash merging” with default to pull request title & description which can be editable.

Also, adding a ‘code merge guideline’ (please feel free to suggest alternate title) in maintainer responsibility to have meaningful title and description before merging, or within this section: https://github.com/opensearch-project/.github/blob/main/RESPONSIBILITIES.md#maintain-overall-health-of-the-repo

To uphold this, it may require some vigilantism (maintainers/contributors giving feedback to other maintainers) for some time, but we should be progressing in right direction.
I recommend we enforce the repo setting for all the repos in OpenSearch Project.

@sandeshkr419

Merge commits are already disabled, at least in this repo. Changing the default commit message to "pull request title & description" would be the change here, as currently it is set to "Default Message"
This seems reasonable.
If we use this suggestion along with "pull request title & description" then the default commit message would contain the "## Proposed commit message" heading text along with the checklist.

For me, personally, I try my best to write a good commit message (pretty much following everything described in this blog: https://tbaggery.com/2008/04/19/a-note-about-git-commit-messages.html) and then force push my PRs to contain a single commit so that the default squash will take my commit and message verbatim. I don't love the idea of using the PR description in the commit message as I see them as two different things: The PR is a proposal. It's editable and more conversational (e.g. "I don't love the way I solved x here, looking for feedback on better ideas"), whereas the actual commit and its message is what I'm proposing to commit to the permanent and immutable record.

@andrross
Maintainers responsibility should be added right away I guess irrespective of what we decide with PR templates and repo settings: https://github.com/opensearch-project/.github/pull/194
Also, I think that the idea of 1/ Proposed commit message in PR template + 2/ changing the default commit message to pull request title & description together makes sense. Can add the comment in PR template that it can be drafted after the code changes are finalized - of-course this is editable by maintainers.
This way, less chances of the commit trail being pushed as commit messages, but, but, but, we would still need some maintainers (can't enforce this, it can only be voluntarily) to provide feedback on any violations to uphold the good commit hygiene.

Also, I think that the idea of 1/ Proposed commit message in PR template + 2/ changing the default commit message to pull request title & description together makes sense.

@sandeshkr419 I guess the thing I don't love about this is that every PR merge will require hand-editing the commit message, because the maintainer doing the merge will have to delete everything from the PR description that wasn't in the "Proposed commit message" section. With the current configuration, assuming the contributor force pushes to their PR branch to keep the PR to a single commit and writes a good commit message, then the maintainer doesn't have to do anything except click merge.


fixed spacing in heading

Fixed issue #33

Could you please address the issue with the invalid link from the issue? I'm currently unable to assign it to you, and I'm not sure why.


Lifecycle Management in Azure storage

[Enter feedback here]
Looks like these compatibility matrix need be updated:

Link1
Link2

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 392e90a0-af77-999e-39a1-78f09ffe0d06
Version Independent ID: 411ca9a3-4370-f9ca-f14c-5385e13d9075
Content: Hot, Cool, and Archive access tiers for blob data - Azure Storage
Content Source: articles/storage/blobs/access-tiers-overview.md
Service: storage
Sub-service: blobs
GitHub Login: @tamram
Microsoft Alias: tamram

@albertoRamon Thanks for the feedback! I have assigned the issue to the content author to investigate further and update the document as appropriate.

@albertoRamon - Thanks for your feedback. The matrix has been updated.
#please-close


MacOS Support?

Steam VR still works and runs on MacOS, is there any possibility we'll get ALVR for Mac?
https://youtu.be/7wB7sf_Ez-E?si=1mjNPbdHCiIGW5EM

The supported SteamVR version is too old for ALVR. Apparently Monado can be compiled for macOS (with MoltenVK), and Monado support in ALVR is planned.

Ooo, I'll look into Monado

This would be awesome.

Monado support is currently in the works and once that's done someone will need to pick up porting the code to macos (shouldn't be that much work at that point).

@The-personified-devil exellent, thank you

Still hoping for VR and ALVR on MacOS)

Now that we are getting more and more performang macs for gaming, this is becoming increasingly relevant.

In most case people will play steam games by CrossOver,so may be ALVR Windows Launcher can run on CrossOver will fix this issue

@The-personified-devil do you know the state on this? I looked into the repo but I'm not sure if Monado supoprt has been completed or not?

It got stalled for a while on some blockers, but I'm working heavily on it currently, tho I can't give an eta when a first release for linux will come out.

@The-personified-devil no worries, not pushing for dates as I realize that's annoying to commit to. Was just curious, thanks for the quick response! :)


Adaptive streaming

I was looking at this code:
 mProfile.setVideoQuality(StreamingProfile.VIDEO_QUALITY_HIGH3)                 .setAudioQuality(StreamingProfile.AUDIO_QUALITY_MEDIUM2) //                .setPreferredVideoEncodingSize(960, 544)                 .setEncodingSizeLevel(Config.ENCODING_LEVEL)                 .setEncoderRCMode(StreamingProfile.EncoderRCModes.QUALITY_PRIORITY)                 .setAVProfile(avProfile)                 .setDnsManager(getMyDnsManager())                 .setStreamStatusConfig(new StreamingProfile.StreamStatusConfig(3)) //                .setEncodingOrientation(StreamingProfile.ENCODING_ORIENTATION.PORT)                 .setSendingBufferProfile(new StreamingProfile.SendingBufferProfile(0.2f, 0.8f, 3.0f, 20 * 1000));
And my questions is - is it possible to set some of those parameters during streaming? I would like to achieve adaptive streaming solution, so the streaming settings will adapt to current network conditions.

StreamingProfile.SendingBufferProfile(0.2f, 0.8f, 3.0f, 20 * 1000));
This line achieves exactly that, it notches up/down the bitrate depending on the buffer during streaming. Basically if the buffer is too full, then the bitrate goes down and vice versa.

@gouravd Thank you - this is now clear to me, but I cannot find how to modify framerate while streaming.


[BUG]make generate and make manifests commands do not work

What happened:
make generate and make manifests commands do not work
Environment:

KubeDL version: master branch

please go get latest controller-gen command tools via go get<EMAIL_ADDRESS>

You are right, I'll add this to the documentation


incorrect results / false positives

I guess there are some incorrect results. I use this php.ini and PHP 7.0 with iniscan version 3.6.4.
This is the output:
Status | Severity | PHP Version | Current Value | Key                           | Description
------------------------------------------------------------------------------------------
FAIL   | ERROR    | 5.2.0       | 1             | session.cookie_httponly       | Setting session cookies to 'http only' makes them only readable by the browser
FAIL   | ERROR    | 4.0.4       | 1             | session.cookie_secure         | Cookie secure specifies whether cookies should only be sent over secure connections.
FAIL   | WARNING  | 5.5.2       | 1             | session.use_strict_mode       | Strict mode prevents uninitialized session IDs in the built-in session handling.
FAIL   | ERROR    | 4.0.3       | 0             | allow_url_fopen               | Do not allow the opening of remote file resources ('Off' recommended)

As you can read in the php docs the current session settings are secure. allow_url_fopen is also disabled. Or is the column Current value the recommended value?
It seems the determination of default values is incorrect, because the value of session.cookie_httponly is "". Same for other values.
Do you check the values 1, 0, Off, On, "1", "0" or "" for specific settings?

Hmm, interesting - I'll have to look into this one further to see what's happening here. There's "casting" functionality in the Psecio\Iniscan\Cast class that tries to normalize out the 1/0/Off/On/etc values to the same result but maybe there's something getting lost in the shuffle there with some of the PHP 7 updates.

I encountered the same thing. +1 for fixing it.

@enygma The cast is correct. It seems more an error with the "current value" column.
See my example for "allow_url_fopen".
The real value:

The result of iniscan:

Current value shows "0" but is definitly 1 ("On").

The bug is here:
https://github.com/psecio/iniscan/blob/master/src/Psecio/Iniscan/Rule.php#L369
Instead of $test->value which returns
https://github.com/psecio/iniscan/blob/master/src/Psecio/Iniscan/rules.json#L148
should be $ini[$test->key] are set.

Hmm, trying to reproduce this one but it seems that things are reporting back correctly on a PHP 7.0 configuration file. I've tried:
allow_url_fopen = Off
allow_url_fopen = 0

Both seem to work as expected:
PASS   | ERROR    | 4.0.3       | 0             | allow_url_fopen               | Do not allow the opening of remote file resources ('Off' recommended)

Is there something I'm missing to reproduce this issue?

I think the same is happening with session.cookie_httponly.
Status | Severity | PHP Version | Current Value | Key                           | Description
------------------------------------------------------------------------------------------
FAIL   | ERROR    | 5.2.0       | 1             | session.cookie_httponly       | Setting session cookies to 'http only' makes them only readable by the browser

and yet my php.ini:
session.cookie_httponly = 1

phpinfo() reports:
session.cookie_httponly	On

(discard warning about session.cookie_httponly, it was my mistake, sorry about the noise)

@tommy-muehle any update on how to reproduce this?

@enygma
Sorry for the late response!
I tried it also with my iniscan Docker container and this ini file.
Here are the steps to reproduce:
cd /tmp
curl -o php.ini https://gist.githubusercontent.com/tommy-muehle/4a59294d1799c19254780788f1f6f1e6/raw/e6133995df411ecf158892d338512a11949863d6/php.ini
docker run --rm -ti -v $(pwd):/tmp dockerizedphp/iniscan scan --fail-only --path=/tmp/php.ini

Inside the container runs PHP 7.1 if this is necessary.

For upload_max_filesize (16M -> 2M), post_max_size (24M -> 8M) and memory_limit (256M -> 128M) it returns me the default value and not the current value. For allow_url_fopen it cast me On to 0. And for disable_functions it displays and empty value instead of pcntl_alarm,pcntl_fork,pcntl_waitpid,pcntl_wait,pcntl_wifexited,pcntl_wifstopped,pcntl_wifsignaled,pcntl_wifcontinued,pcntl_wexitstatus,pcntl_wtermsig,pcntl_wstopsig,pcntl_signal,pcntl_signal_get_handler,pcntl_signal_dispatch,pcntl_get_last_error,pcntl_strerror,pcntl_sigprocmask,pcntl_sigwaitinfo,pcntl_sigtimedwait,pcntl_exec,pcntl_getpriority,pcntl_setpriority,pcntl_async_signals,pcntl_unshare,.
Also for session.use_strict_mode the value is 0 but is displays 1, however it still detect it as failed so the cast occurs after.


fix: spotbugs plugin is not loaded from v5.0.15

I merged #925 to fix a known bug, but it introduced a regression.
We could not find this regression because functional test cases were not triggered during the CI workflow. So this PR contains two kinds of fixes:

Make functionalTest task running during our CI workflow
Set path of spotbugs plugins properly

I want to release this change to fix a known regression, so let me merge this for now. There is no additional test case nor new behavior then it should be OK I believe.


chore: Changed BASE URL for release build

Fixes #1322
Checklist:

[x] I have checked for PMD and check-style issues
[x] I have read the Contribution & Best practices Guide and my PR follows them.
[x] My branch is up-to-date with the Upstream development branch.

Changes:
Screenshots for the change:

Obtaining HTTP 404 on http://next.eventyay.com/.

@Masquerade0097 Could you please try api.eventyay.com ? I think next.eventyay.com is the frontend deployment. If it doesn't work, feel free to ping @Kreijstal on the server channel. He is handling the deployment.

@iamareebjamal Mario was insisting that we should use the latest API deployment in our master branch which is also being used in next.eventyay.com.
@srv-twry What API is frontend next.eventyay.com is using?

Backend guys should add SSL support to api.eventyay.com
@Kreijstal

@Masquerade0097

What API is frontend next.eventyay.com is using?

As I said, I am not aware of the deployment stuff. If my memory serves well, @maxlorenz @Kreijstal and @bhaveshAn were handling it. Feel free to ping them here or on the channel. Thanks.

What API is frontend next.eventyay.com is using?

As @srv-twry told it's http://api.eventyay.com

@iamareebjamal So I guess we can keep on using https://open-event-api-master.herokuapp.com/v1/ till SSL support is added for api.eventyay.com. Closing this.


Added keys to elements in iconNode map

Closes #2199
What is the purpose of this pull request?

[ ] New Icon
[x] Bug fix
[ ] New Feature
[ ] Documentation update
[ ] Other:

Description
Automatically assigns a key if no key is provided on the iconNode.
Before Submitting

[x] I've read the Contribution Guidelines.
[x] I've checked if there was an existing PR that solves the same issue.

React already does that.


Is this a mistake in writing?

static void event_thread_init(void *drcontext)
{
void **thread_data;
thread_data = (void **)dr_thread_alloc(drcontext, 2 * sizeof(void *));
thread_data[0] = 0;
if(options.thread_coverage) {
thread_data[1] = winafl_data.fake_afl_area;
} else {
thread_data[0] = 0;                     //Is this a mistake in writing? thread_data[0] or thread_data[1]
}
drmgr_set_tls_field(drcontext, winafl_tls_field, thread_data);
}

Yes, this is a mistake, but fortunately it doesn't have any negative effects on WinAFL execution since thread_data[1] (pointer to thread-specific afl area) isn't used if options.thread_coverage is false.
Thanks for pointing it out though, I can change it in the next update.

This should be fixed now.


Restart cluster-autoscaler on shoot maintenance

How to categorize this issue?

/area auto-scaling control-plane ops-productivity
/kind enhancement
What would you like to be added:
Restart cluster-autoscaler on shoot maintenance
Ref: https://github.com/gardener/gardener/blob/master/docs/extensions/shoot-maintenance.md#restart-control-plane-controllers
Why is this needed:
Avoid working on stale data.

/assign


CatmullRomSpline updated with Check

Worked on issue #4794 updated CatmullRomSpline.

Since this is branched off of #5555, you might need to rebase when it gets merged into master. Let's wait on this change until it is merged in.

Looks good!


Document relevance logic

Need a wiki or readme that documents in plain english how the relevance works in Samplestack (relative priority/weighting, etc), how it can be tuned (pointer to docs reference information?), and how it can be demonstrated and/or tested. See narrative for specific guidance on what should be more important. Also note search scope for search text is limited to Q title, Q text, A text, Comment text (not sure how that factors in).

Thanks for the reminder.  To get started here,
database/database-properties.json is where to find index and field configuration for the samplestack database.  The default search is tied to a field defined in this file:
{
            "field-name": "default-samplestack-search",
            "field-path": [
                {
                    "path": "/title",
                    "weight": 2
                },
                {
                    "path": "/text",
                    "weight": 2
                },
                {
                    "path": "/answers/text",
                    "weight": 1
                },
                {
                    "path": "//comment/text",
                    "weight": 0.5
                }
            ],
            "tokenizer-overrides": null
        }

This field includes the various parts of QnADocuments that are searched with bare (non-prefixed) searches.  If a term is found in the title of a question or the main body of a question, it's weighted twice as much as in an answer, and four times as much as in any text.
The actual scoring of search terms is adjusted with this weight.  To see how MarkLogic scores term searches, See the [Search Developer's Guide] (http://docs.marklogic.com/guide/search-dev/relevance#id_22791)

That's great, v helpful. Maybe add to a wiki?

Yes, agreed -- maybe part of a 'how searches work in Samplestack' topic?

edited example, had same bug as in #506

Yes sounds good.

Page about search config that includes a little on relevance.  Feedback/edits welcome @popzip @kcoleman-marklogic
https://github.com/marklogic/marklogic-samplestack/wiki/Samplestack-Search-Configuration

I saw a few typos that I just fixed directly, as threatened. I made a couple other minor phrasing tweaks, but nothing much. I'm afraid I got cheekier the farther into the page I went.
I have a couple terminology suggestions for you to contemplate. I didn't think it'd be fair to just muck about with them.

Don't say "so-called X", like "so-called fields". You do that in a couple places. It sounds like you're implying that's not really what X is. (Will the real X please stand up...) It's not a so-called X. It IS an X. You can explain what it is, if necessary.
Consider using "query options" instead of "search options". You guys decided "search options" was too narrow a term back when the REST and Java APIs first hit the streets. They're called query options throughout the documentation and the client API interfaces.

Lastly, I thought it got a bit confusing at the bottom where you were walking through rawSearch, mostly because of the 2nd bullet, where you create the query definition. You say "Create a query definition...from the structured query object.". What query object?
You're apparently reading in the structured query from "docNode", but the reader has no idea what's in there or where that came from. I think you need to either say more or say less ("Create a query definition.").

Good suggestions, thanks.  On this one

You're apparently reading in the structured query from "docNode", but the reader has no idea what's in there or where that came from. I think you need to either say more or say less ("Create a query definition.").

I definitely saw that before and swept it under my mental rug.  So much for that strategy!

OK I gave it another pass through.

Sending to @popzip for a final looksee.  Feel free to contact with questions, requests

Looks good to me for now, no further updates

It's pretty good as is, and definitely very informative.
I think there are some improvements we could consider for later:

Biggest remaining question is whether we only weight based on location (e.g. in title vs. text). See narrative for more on the relevance requirements. I would also expect to have weightings for other factors like term frequency (maybe that's built it?), recency, accepted or not. Can you confirm how its working today? The other things might be for future releases (if feasible/reasonable)? I think of it similarly to how this post describes the 'knobs' in action for MarkMail. I do see in the requirements that I had originally stated matching tag was most important, but we aren't matching tags anymore, so that part can be disregarded.
Although Samplestack provides controls for these states, you can also activate them in a search box.
How is this done? What is the prefix/syntax for indicating this in the search box
Is rawSearch something created for Samplestack or a MarkLogic-ism?
Would be good to add links to the docs for things like structured query, value/range indexes, etc. You had a link to Search Developer's guide above (in this comment thread) - is there a good place to move that into the wiki?
How about use of parse in searches, especially for interpreting the search constraints/tips like you mentioned at top of post?
There's one remaining mention of "Search Options" - not sure if that still stands or if it should also be updated to "Query Options" per Kim feedback above.

A lot of this can come later, but mostly want to see if there's anything else that's being factored into relevance search at the moment besides title/text.

Excellent feedback -- to answer the first question just here,
relevance in default samplestack searches is not affected by accepted/recency and such currently.
That could definitely be added in -- the browser right now is in charge of constructing queries (like the ones in markmail post) that could boost score based on accepted and recency and such -- or the middle tier could add in these queries.  It is currently a gap.
But that's all weights -- scoring is scaled by weights, and the scoring comes originally from what you hint at - the term frequency formula.
I'll get some more edits into the wiki today.

Created https://github.com/marklogic/marklogic-samplestack/issues/572 to track task of implementing the points I missed.  Mea Culpa on that, it's a gap to be sure.  I remember deferring it until we had some rich data available and then not coming back all the way during default search discussions with the group.

OK I did a bit more on that document -- one of your bullet points I think leads to a different (as yet unwritten) document, about the searches used in samplestack and how they're sent to the middle tier.  I'll set to test for now, assign to @popzip ,  -- feel free of course to edit the page


🐞 Prompts for the passé compose tense frequently fail

This is because there are several forms, and several ways for them to be returned by ChatGTP.
The existing prompts are outrageously huge, and adding more details has only raise the variance even against explicit cases it is instructed to correct.
A good way to handle this would be to stop trying to force all participles into a single field targeting only the past participle (which was originally done for simplicity), and just support all of them.  That a lot of prompt complexity gone right there.

This is no longer observed with better prompting.  It would have been to track which improvement did that.


refactor(form-field): remove 6.0.0 deletion targets

Removes the targets marked for 6.0.0 deletion from the material/form-field.
BREAKING CHANGES:

The dividerColor input has been removed. Use color instead.
The floatPlaceholder input has been renamed to floatLabel.
The MatFormFieldControl.shouldPlaceholderFloat property has been renamed to shouldLabelFloat.
The FloatPlaceholderType type has been renamed to FloatLabelType.
The PlaceholderOptions type has been renamed to LabelOptions.
The MAT_PLACEHOLDER_GLOBAL_OPTIONS token has been renamed to MAT_LABEL_GLOBAL_OPTIONS.
The mat-input-placeholder-wrapper and mat-form-field-placeholder-wrapper CSS classes have been removed from the form field template. The same element can be targeted using the mat-form-field-label-wrapper class.
The mat-input-placeholder and mat-form-field-placeholder CSS classes have been removed from the form field template. The same element can be targeted using the mat-form-field-label class.

Can you change the breaking notes to match that earlier PR where applicable (i.e. "Xxx, which was deprecated in 5.0.0, has been removed. Use yyy instead")

Done.

Caretaker note: we need to remove google usages of the old API. This might require a cleanup before syncing this PR.

closing since all shard PRs have been merged


UI documentation

Area
ui
Description
Add documentation of the current state of the UI. Describe each page accessible to these actors.

[x] admin
[x] login

Operator

[x] representatives
[ ] add pages to document

Location

[ ] add pages to document

Network user

[x] dashboard
[ ] add pages to document

Other

[x] meter
[ ] add pages to document

Oprators:

[ ] add pages to document

Structure:
For dashboards:
Navigation
{links to related sites}
Content
{image of dashboard}
{detailed explanation of image}
For normal pages:
Available to
{links to dashboards that can access this page}
Content
{image of page}
{general use of page and list of components}
{image of component}
{detailed explanation of componenet}


I think you have a mistake in the async plugin documentation

[Enter feedback here]
The text about async plugins made me thing that async plugins that make several changes to several records will do that without a transaction, but I think each plugin run has a single context and transaction, so if my async plugin creates a contact and an account but the account creation fails it will roll back the contact creation. The changes made by each async plugin execution are still an atomic unit.

Document Details
⚠ Do not edit this section. It is required for learn.microsoft.com ➟ GitHub issue linking.

ID: 75ddb79a-82d5-611f-787d-72a2294614ff
Version Independent ID: 876520c5-b0e2-4874-f815-f42d0e2fd611
Content: Scalable Customization Design: Database Transactions (Microsoft Dataverse) - Power Apps
Content Source: powerapps-docs/developer/data-platform/scalable-customization-design/database-transactions.md
Service: powerapps
Sub-service: dataverse-developer
GitHub Login: @rogergilchrist
Microsoft Alias: jdaly

@orshir
Hi Oren -
Thanks for your feedback.
Can you call out what specific part of the document you think is not correct?
And you can reach me via email too.

We have verified that the content is correct.


FormCell init(style: UITableViewCellStyle, reuseIdentifier: String?) not public

In swift 3, if I don't set this method to public, my custom (non xib) cell classes fall over when the rowFormer tries to create them
The same applies to FormHeaderFooterView

It is happening to me also, for the class FormCell.
When using it the app will crash with:
fatal error: use of unimplemented initializer 'init(style:reuseIdentifier:)'
making the initialiser public fix the problem

Can someone submit a PR with the fixes? Closing this issue as the solution has been found.


Bullets not rendered if there is no preceding newline

Sorry, not familiar with the spec, maybe this is expected?
https://s01.oss.sonatype.org/service/local/repositories/snapshots/archive/org/typelevel/sbt-typelevel-website_2.12/0.5-a953d7a-SNAPSHOT/sbt-typelevel-website_2.12-0.5-a953d7a-SNAPSHOT-javadoc.jar/!/customization.html#sbt-typelevel-mergify
Here's how it renders on GH.
https://github.com/typelevel/sbt-typelevel/blob/a953d7a/docs/customization.md#sbt-typelevel-mergify

Funnily the logic for not requiring a preceding blank line is there, but only for nested lists, not for root-level paragraphs. The logic was added in October 2020 and I have no memory why this design choice was made, but it was very explicit.
It's mostly a matter of changing the registration line if we want to enable this, so I probably just quickly verify "what other parsers do"

This use case is actually a perfect example for what a mess the zoo of existing markdown parsers does for unspecified cases. If you look at this (very useful tool in general):
https://babelmark.github.io/?text=A+paragraph+with+a+list
right+below+it
*+but+without+blank+lines
*+which+looks+really+weird
I get 10 results that do not see a list and 19 that do (numbers may vary since usually some servers don't respond).
So I think we should enable that for two reasons:

About two thirds of parsers do what you expected
The CommonMark parsers see a list, too - and in cases where classic Markdown is ambiguous it is more convenient to imitate CommonMark as it allows to share more code between the implementations once we support CommonMark officially.

Completed in #502.


increase hugeparam default size

The new linter version breaks unit test because of the hugeParam size

Let's instead use pointers in verticadb_conversion.go. Like in Cai's PR. Can you update it here?

Let's instead use pointers in verticadb_conversion.go. Like in Cai's PR. Can you update it here?

Yeah, updated in https://github.com/vertica/vertica-kubernetes/pull/965/commits/aca9bb9784b1c1ad960e3de06c6b25e25785b89f


drivers/ethernet/eth_gecko: auto-negotiate after link up

Move auto-negotiate sequence from driver initialization to link up event
Previously when booting without ethernet cable connected the
initialization would fail and never recover.
Now we can connect the ethernet cable any time and multiple times.
This also drastically reduces boot time to main.
Logging Link up and Link down events.
Logging speed and duplex from eth_gecko logger instead of eth_gecko_phy.
Signed-off-by: Luuk Bosma<EMAIL_ADDRESS>

Verified that it's working as intended! Great, thanks!


README: setup instructions

This issue is reserved for participants of Welcome to Open Source, Atlanta.
If it’s still available after April 2nd, it’s all yours :)

:bug: The Bug
In the setup section of this repository’s README we tell the user to clone the repository using git clone git@github.com:hoodiehq/hoodie-server-task.git. But GitHub itself recommends the https:// protocol instead of the git@ which is SSH (see which remote should I use).
:dart: The Goal
Replace the git clone git@github.com:hoodiehq/hoodie-server-task.git with https://github.com/hoodiehq/hoodie-server-task.git in the README
:clipboard: Step by Step
If this is your first, welcome :tada: :smile: Here is a great tutorial on how to send a pull request

[ ] claim this issue (comment below)
[ ] Clone the repository to your computer
[ ] Edit the README.md file.
[ ] Commit the change docs(README): fixed git clone URL
[ ] Start a Pull Request.  Mention closes #21 in the description of the pull request
[ ] Done :+1: Comment below to ask for a review :)

Ping us in the Hoodie Chat or on Twitter if you have any questions :)

claiming

pr ready for review


Update codeql-analysis.yml

The existing code-ql
PR summary
https://github.com/IBM/networking-python-sdk/security/code-scanning/tools/CodeQL/status/configurations/actions-FZTWS5DIOVRC653POJVWM3DPO5ZS6Y3PMRSXC3BNMFXGC3DZONUXGLTZNVWA/5b869ea5aa9e968c88615657bae5a6803649927a62c91a29e6e11750fcd24604

PR Checklist
Please make sure that your PR fulfills the following requirements:

[ ] The commit message follows the Angular Commit Message Guidelines.
[ ] Tests for the changes have been added (for bug fixes / features)
[ ] Docs have been added / updated (for bug fixes / features)

PR Type

[ ] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] New tests
[ ] Build/CI related changes
[ ] Documentation content changes
[ ] Other (please describe)

What is the current behavior?

What is the new behavior?

Does this PR introduce a breaking change?

[ ] Yes
[ ] No

Other information

:tada: This PR is included in version 0.26.0 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


keepass-keepassotpkeyprov: init at 2.6

Motivation for this change
From the Keepass plugin doc:

OtpKeyProv is a key provider based on one-time passwords. After protecting your database using this plugin, you need to generate and enter one-time passwords in order to open your database.
All generator tokens that follow the OATH HOTP standard (RFC 4226) are supported.

Template for this change was #23893
Things done

[x] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
Built on platform(s)

[x] NixOS
[ ] macOS
[ ] other Linux distributions

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
[x] Tested execution of all binary files (usually in ./result/bin/)
[ ] Determined the impact on package closure size (by running nix path-info -S before and after)
[x] Assured whether relevant documentation is up to date
[x] Fits CONTRIBUTING.md.

This pull request has been mentioned on Nix community. There might be relevant details there:
https://discourse.nixos.org/t/prs-ready-for-review-may-2019/3032/31

Here we go! :rocket:
Thanks @Enteee for your patience & availability to see this through.

Thank you @JohnAZoidberg , @c0bw3b  for reviewing & merging.


Disable service links (*_SERVICE_* env vars) on app pods.

Disable service links (the automatically-set environment variables with names like $service_SERVICE_{HOST,PORT}_*) in the govuk-rails-app chart. We're not using them and they create a lot of clutter in the environment which can be a pain when debugging.
Maybe someday we could use them in Router and Plek, but that's unlikely to happen soon.
Testing

Ran helm template . --set appImage.repository=foo --set workerEnabled=true and inspected the output.
Installed the chart (helm install frontend-test ../govuk-rails-app --values <(helm template . --values values-integration.yaml |yq e '.|select(.metadata.name=="frontend").spec.source.helm.values')), verified that pods come up healthy and the output of kubectl exec frontend-test-d56c666c4-t4jbb -c frontend-test -- env no longer contains dozens of unused *_SERVICE_{HOST,PORT} vars.

We're 100% not using these at the moment in the app charts so there's no reason not to turn them off. If we want to use them in future them we'd just enable them again for whichever apps we want to use them with.

I think what I'm meaning is:  We probably wouldn't want to enable this in the future, and if we spot someone trying to do it, persuade them otherwise.  My worry is if we start using the two ways it would be horrid.
Anyway, this is just all academic and worrying about a situation that might not ever occur; I think this change you propose is the right one, and I'll just shoosh about my unreasonable concerns that dont even and might not ever exist.  I was just thinking out loud really.

No worries - that's a good point about the risk of us growing yet another service discovery mechanism in the GOV.UK apps. I think that's a stronger reason for enableServiceLinks: false than my original one 😀


bug in extract_state_value_from_output

extract_state_value_from_output  function
这个函数会把-1处理成1，导致react模型无限循环

@better629 @garylin2099 noticed that this problem seems to be related to the code on both sides. Can you guys take a look?


Dashboard: Remove all DEPRECATED_THEME

Feature Description
Now that new designs are in, we should be able to gut everything old, this should surround the DEPRECATED_THEME instances in the dashboard codebase. Should also eliminate all dead old components that are now being used out of the design system instead.
Alternatives Considered

Additional Context

Do not alter or remove anything below. The following sections will be managed by moderators only.
Acceptance Criteria
Dashboard functions as it currently does. Entirely regression test based.
Implementation Brief

Verified in QA


Not booting in diag or purple mode in A10 devices

The programmer is genius hope to fix booting in diag mode or purple in A10 devices i tried iPhone 7plus not booting in diag mode

new magiccfg handle this even he use gaster, not related with gaster at all