How to unset quote_char?

I want not to designate quote_char. How can I do it?
I want to read tsv (tab separated values) format data using csv filter.
There is some fields including quote and double quote characters.
Therefore, I want to set no quote_char, but I cannot find how.
There is similar Q&A in stackoverflow:
http://stackoverflow.com/questions/23377475/how-can-i-read-csv-with-no-quote-char-in-ruby
But, since quote_char does not accept encoded character such as "\x00",
I must input control character in the logstash configuration file.
Is it intended to use logstash?
Related: There is similar issue in separator field
http://stackoverflow.com/questions/30915011/logstash-tab-separator-not-escaping

I have also had this  issue, for most normal data sets I can set a rare character that wont come up, but when working web logs in particular, many attacks(SQL injection/Directory traversal) use a lot different characters. I tried non common/standard characters like '¬' make logstash error on startup (illegal quoting character).
The two options i have at the moment are
use GROK with a simple NOT filter eg NOTSPACE
use GSUB to remove my quoting character and then maybe try and put it back in. (which itself generates many issues)

+1

quote_char=>"\x00" worked well for me

@IgorMedvedkov it doesn't seem to work with \x00. I do not know what exactly ruby is doing here, but if you try to use another \x## sequence (\x09) it gives "quote_char has to be a single character String"
Using my separator as the quote_char worked for me ;) I'm using tab as the column separator. Setting it also as the quote char yielded the wanted result for the one example I tried. But I will not rely on this.


Update MDN page: Limitations of the new debugger

Request type
Correction or update
Details
The following page should be updated:
https://developer.mozilla.org/en-US/docs/Tools/Debugger/Limitations_of_the_new_debugger

Broken link: Breaking on DOM events
Broken link: Highlighting and inspecting DOM nodes
The debugger is now enabled everywhere (text should be reworded)

But, the old debugger is gone and we only have the Debugger now, so perhaps the page can be removed entirely?
WDYT? @jasonLaster @darkwing @digitarald
Honza

I removed the reference from  https://developer.mozilla.org/en-US/docs/Tools/Debugger, removing the page would be the last remaining step.

The page has been deleted.


LinkedList from() static method

as the standard Array.from, we need method to convert any iterable object into LinkedList
Array.from() on MDN
console.log(Array.from('foo'));
// expected output: Array ["f", "o", "o"]

console.log(Array.from([1, 2, 3], x => x + x));
// expected output: Array [2, 4, 6]

already covered


createEmptyFiles option

Added createEmptyFiles option (default = true). If it is set to false, it prevents creating an empty file if

no src file is found
all src files are empty

Is the suggested solution for #157

Great solution, looking forward to see it merged!


fix(#1156): illegal reflective access on java 9

Hi,
This pull request allow to workaround the java 9 illegal access warning generated by mybatis.
When mybatis search for existing methods on objects, it goes to the object hierarchy including the top java.lang.Object class.
As there is no point to go to the java.lang.Object class as it didn't contains any getter/setter, a trivial workaround is to skip this class.
I tested this approach and with this patch there is no more illegall access warning on Java 9.
Regards,
Loïc

Hello,
I remove the comment.
Regards,
Loïc

Thank you, @loicmathieu !


Cannot install latest v4.0.0

It seems that the latest version of node (4.0.0) cannot be installed
nodist selftupdate
nodist update
nodist latest

Couldn't fetch nodev4.0.0: HTTP 404.
Sorry.

The 4.0.0 installation problem was fixed with nodist 0.6.1, released few days ago

AFAIU nodist selfupdate updates dependencies of nodist and not nodist itself (yeah this is confusing).

What does nodist update actually do?
For me the output is the following

$ nodist update
Version spec, "update", didn't match any available version.
Sorry.

When it comes to updating, I just do git pull --rebase origin master (however it's not easy to do it now, since if you updated npm or nodist deps, there'll be modified files in git repo and you can not easily checkout another commit. This is a pain I want to address in #87).

However if you took the zip from github instead of cloning a git repo, to update, you can just download the zip again and unpack it over the previous installation

I guess we should simplify stuff and/or update the README :)

I ran into the same issue. Thanks @jakub-g ;) Indeed the selfupdate command has a confusing name, I will simply do the update as usual: by manually grabbing the zip snapshot of master.


from scratch base image

Signed-off-by: Robert Cerven<EMAIL_ADDRESS>

nope this doesn't need any osbs-client change

Ok, I just expected that function adjust_for_custom_base_image(self) should drop some plugins for FROM scratch builds, because it is a base image build.

I've tried to build following image: https://github.com/MartinBasti/docker-hello-world/blob/multistage-from-scratch/Dockerfile
But I got following error:
atomic_reactor.plugin.PluginFailedException: {"x86_64": {"docker_api": "u'Error parsing reference: \"sha256:ded494ce3076e8f2d264235fdb09da5970921d8317f8fd024ab65821bf13e29f AS builder\" is not a valid repository/tag: invalid reference format'"}}

Is the multistage build supported? Or what I did wrong?

Previous issue was resolved by using imagebuilder instead of docker_api
But now I'm experiencing another issue:
atomic_reactor.inner - ERROR - image build failed: plugin 'koji_parent' raised an exception: NotFound(HTTPError('404 Client Error: Not Found',),)

rn updated:

Allow FROM scratch base image


How to save mutation code?

I need every mutation code,how to get it (source code).

This is currently not possible, but PRs welcome!

@zhangshoufeng97 Note that you could do that by copying your source at the time you are asked to build. So say your normal build command is make, you can write a script, something like this:
#!/bin/bash

cp -r . ../mutation-123/.
make

Then use that script instead of just make.
As for the number (123 above), it's up to you to come up with an algorithm to generate it. You could simply use a file:
COUNT=`cat count.txt`
COUNT=`expr $COUNT + 1`
echo $COUNT >count.txt

cp -r . ../mutation-${COUNT}/.

Anything that works for you.


ESign | Enabling Multiparty ESign

Details:
Multi party esign needs to be enabled for Case PDF, Witness Deposition.
Working:
For Case PDF (once templatised and created in the system without getting uploaded):

The lawyer/litigant has to choose physical sign or esign as a mode of signing. Once selected they will be promted with a message. "Kindly note that all the litigants and advocates signing this document will have to sign using the chosen method"
There are 2 options: Download and sign, E Sign.
For Download and Sign, the document is downloaded. Once downloaded, there will be an upload option enabled.
For E SIgn it proceeds as per current flow
If E Sign is chosen then the second party (lawyer of litigant) will have to sign on it again using CDAC service. The position of the sign on the document should not overlap the first signature.

For Witness Deposition:

Only download and Upload is permitted. (No ESign).
The document is downloaded. Signed on court by witness and judge. There should be an upload button to re upload. It should show signed.

- If E Sign is chosen then the second party (lawyer of litigant) will have to sign on it again using CDAC service. The position of the sign on the document should not overlap the first signature.

Research will require to avoid overlap on already signed doc

-  The lawyer/litigant has to choose physical sign or esign as a mode of signing. Once selected they will be promted with a message. "Kindly note that all the litigants and advocates signing this document will have to sign using the chosen method"

blocking was suggested by @suresh U  (advocate will sign first then litigant ), will require tech details how to implement this   @manimaarans
@anirudh-0  will require input on how ui can handle blocking for sign method on the basis of first signature

Since the scope got changed we ahave created new ticket please refer to #1964


new two scripts

copy_models script and gradual_selection_mesh script are published.

I'm just starting to study Git hub and python. I'm sorry for the inconvenience!

Great, thanks!


Stream quality low

Hello! How to define stream quality. Picture is very low.

@disono do you work as freelancer?


Read from both stderr and stdout to prevent buffer deadlock

Description
Fixes problems with the stderr buffer filling and leading to QCEngine stalling.
Changes popen() to pull from both stderr and stdout while the subprocess is running (using multithreading) and modified execute() so that it does not have its own "make sure buffer doesn't fill" code
Todos
None
Questions
Status

[x] Make sure test suite passes (only did a few of them locally)
[ ] Changelog updated
[ ] Ready to go

My it never hang and prompt my interference again, indeed 🤞
I was thinking about adding in an option to pass the stderr and stdout read by the subprocess forward to the systems' standard out. The plan would be to have threads that read from the buffer have an option to also write the out the buffer to the system's stdout. Should I go ahead and see if I can figure that out?

Thanks for the sysio forwarding! I look forward to trying it out.

@WardLT Can you fix merge conflicts then ready to go.

I've fixed the merge conflicts


Add ocs-client bundle to ocs-operator catalog

Install ocs-client operator while deploying ocs as we are going to use ocs-client API storageclient for reconciliation in provider mode.
Update relevant script files to inclue the ocs-client bundle image name and ocs-client bundle deployment script.
Part of [RHSTOR-5487]

followed d6b50f2

Testing
# make install-ocs-client
Ensuring operator-sdk
hack/ensure-operator-sdk.sh
Using operator-sdk CLI present at /root/toolbox/orc/ocs-operator/bin/operator-sdk-v1.25.4
Installing ocs-client operator
hack/install-ocs-client.sh
Namespace "openshift-storage" exists
WARN[0012] quay.io/ocs-dev/csi-addons-catalog:v0.7.0 is a SQLite index image. SQLite based index images are being deprecated and will be removed in a future release, please migrate your catalogs to the new File-Based Catalog format
INFO[0020] Created registry pod: quay-io-ocs-dev-ocs-client-operator-bundle-v4-15-0
INFO[0021] Created CatalogSource: ocs-client-operator-catalog
INFO[0022] OperatorGroup "operator-sdk-og" created
INFO[0022] Created Subscription: ocs-client-operator-v4-15-0-sub
INFO[0038] Approved InstallPlan install-lk6bl for the Subscription: ocs-client-operator-v4-15-0-sub
INFO[0038] Waiting for ClusterServiceVersion "openshift-storage/ocs-client-operator.v4.15.0" to reach 'Succeeded' phase
INFO[0038]   Found ClusterServiceVersion "openshift-storage/ocs-client-operator.v4.15.0" phase: Pending
INFO[0049]   Found ClusterServiceVersion "openshift-storage/ocs-client-operator.v4.15.0" phase: InstallReady
INFO[0051]   Found ClusterServiceVersion "openshift-storage/ocs-client-operator.v4.15.0" phase: Installing
INFO[0062]   Found ClusterServiceVersion "openshift-storage/ocs-client-operator.v4.15.0" phase: Succeeded
INFO[0062] OLM has successfully installed "ocs-client-operator.v4.15.0"
deployment.apps/ocs-client-operator-controller-manager condition met

@leelavg @iamniting why we are installing this with ocs-operator not with odf-operator like csi-addons?

why we are installing this with ocs-operato

this is only for u/s testing, we are installing csi-addons w/ odf only, ref https://github.com/red-hat-storage/odf-operator/pull/380

@leelavg @iamniting why we are installing this with ocs-operator not with odf-operator like csi-addons?

@Madhu-1 openshift-ci works a bit differently, Moreover, we do not have defined these deps in the ocs that's why we need to install them independently like this.

@leelavg Silly question, but wasn't the client operator supposed to be installed only in the client cluster?

@leelavg Silly question, but wasn't the client operator supposed to be installed only in the client cluster?

no, if we run in internal mode then we'll get storageclass by end of it but in provider mode we server storage via ocs-client and so it's required to be installed alongside odf.
client-op can be installed in standalone cluster to consumer storage from provider as well.

/hold
extended existing target to install ocs-client as well to just see new target works or not 🤞🏼

actually you will have to remove the temp changes

done.

/test ocs-operator-bundle-e2e-aws

/test ocs-operator-bundle-e2e-aws

/unhold


[TableBody] Don't set childrens' hoverable prop to false when showRow…

[x] PR has tests / docs demo, and is linted.
[x] Commit and PR titles begin with [ComponentName], and are in imperative form: "[Component] Fix leaky abstraction".
[x] Description explains the issue / use-case resolved, and auto-closes the related issue(s) (http://tr.im/vFqem).

…Hover is falsy
Hey, I was working on finishing the callback signatures for the Docs, and I noticed that the onCellHover callback of the Table component wasn't being called, even when hoverable was set to true on all the child elements.
The problem is that when showRowHover isn't specified on TableBody, it will render its child TableRow elements with hoverable set to false, even if I specify it as true.  For example,
 <TableBody>
        <TableRow hoverable={true} />
 </TableBody>

would be rendered as if hoverable was false.
I think onCellHover callbacks should still be able to fire regardless of the value of  showRowHover, and this PR allows that.

The Table component was partially / fully migrated on the next branch.
We are now focusing on releasing out the next branch.
We plan to stop the support of the migrated components.
I'm gonna close this PR. Thanks for your time.
Would be great if you check out the new component. Any PR is welcomed.


Observe policy is less useful than TF data resources

What happened?
I'd like to get the equivalent behaviour to data_google_tags_tag_key
The crossplane way to simulate this behaviour is to set the resource as observe-only and use external-name.
However, this isn't semantically the same. Instead it's converted into terraform import resource ${external_name} by upjet.
The problem with this is that imports often aren't as good at resolving resources as data resources. In this case, the data resource will resolve a namespacedName like ${org_id}/${short_name} but import will only resolve a name like tagKeys/${id} but this is much less portable as the number changes all the time.
Perhaps it would be better to make external-name optional for observe-only and use the data resources instead of import if they're available?
How can we reproduce it?
Using a resource which has multiple forms of ID and no support for these IDs in terrafrom import, like google_tags_tag_key we need an equivalent to:
data "google_tags_tag_key" "environment_tag_key"{
  parent = "organizations/567890"
  short_name = "myTagName"
}

This fails as namespacedName isn't supported for import by Terraform:
apiVersion: tags.gcp.upbound.io/v1beta1
kind: TagKey
metadata:
  name: with-namespaced-name
  annotations:
    crossplane.io/external-name: 567890/myTagName
spec:
  managementPolicies: [Observe]
  forProvider: {}

This succeeds because name is supported:
apiVersion: tags.gcp.upbound.io/v1beta1
kind: TagKey
metadata:
  name: with-name
  annotations:
    crossplane.io/external-name: tagKeys/123456
spec:
  managementPolicies: [Observe]
  forProvider: {}

Alternatively, it would be nice if this would work but it currently fails as observe-only only seems to work with an external-name:
apiVersion: tags.gcp.upbound.io/v1beta1
kind: TagKey
metadata:
  name: with-no-name
spec:
  managementPolicies: [Observe]
  forProvider:
    parent: organizations/567890
    short_name: myTagName

@jond3k thanks a lot for the feedback and well-written issue report 🙌
I agree that the Observe Only resources are not as useful as Terraform data sources primarily because they do not support/enable querying and filtering, which is being tracked by a dedicated issue: https://github.com/crossplane/crossplane/issues/4141
You can read more details on how we landed on the current implementation from the description of the above issue or from design document  but primary reason could be quoted as below:

We will not support querying and filtering at managed resources level since it violates a fundamental principle with the managed resources, that is, having a one-to-one relationship between a managed resource and the external resource that it represents. When it comes to querying and filtering, it is possible that:

There are more than one matching resources
There are no matching resources
The matching resource may change in time, e.g., most-recent AMI

Hence, we will leave implementing this functionality in an upper layer, which in turn will own managed resources with managementPolicy: ObserveOnly. In this model, it is totally fine if matching resources change in time, including having more than one or no matches where we would expect corresponding managed resources to come and go at runtime.

So, at the Managed Resource level, we need to uniquely identify the external resource, which is why we need a properly set  crossplane.io/external-name annotation. Your specific example is a little special since you still want to provide enough details to identify the external resource uniquely; however, this is not usually the case for common usage of Terraform data sources.

Thanks @turkenh,
Is there a way to make an exception for this resource?

Is there a way to make an exception for this resource?

I cannot think of an easy way to do this.

I've opened an issue with the TF provider to add the missing import syntax. This should make external-name work, right? hashicorp/terraform-provider-google#16075

Yes, it should.


Update README.md

Added a small description and snippets to help to understand what the priorities here mean, especially the Explicit one.
What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
Docs Update
What is the current behavior? (You can also link to an open issue here)
Missing information on how to use Explicit priority
What is the new behavior (if this is a feature change)?
A small description of the meaning of the priorities and a snippet to help to understand.
What might this PR break?
Nothing
Please check if the PR fulfills these requirements

[ ] Tests for the changes have been added (for bug fixes / features)
[ ] Docs have been added / updated (for bug fixes / features)

Other information:

 Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.:x: giusepe sign nowYou have signed the CLA already but the status is still pending? Let us recheck it.


(anonymous struct)::head' from module 'AudioKit.TPCircularBuffer' is not present in definition of 'TPCircularBuffer' in module 'MyProject.TPCircularBuffer'

We am using AudioKit since quite some time mainly for its midi implementations. At the same time we are using Michael Tysons TPCircularBuffer for our threaded audio processing in a static library way down in the dependency graph.
I just wanted to upgrade to the latest 4.x AudioKit upgrade and XCode 12 from XCode 11 and i see this error messages
.../XCFrameworkIntermediates/AudioKit/AudioKit.framework/Headers/TPCircularBuffer.h:68:23: '(anonymous struct)::head' from module 'AudioKit.TPCircularBuffer' is not present in definition of 'TPCircularBuffer' in module 'MirgaWrapper.TPCircularBuffer'
.../XCFrameworkIntermediates/AudioKit/AudioKit.framework/Headers/TPCircularBuffer.h:67:23: '(anonymous struct)::tail' from module 'AudioKit.TPCircularBuffer' is not present in definition of 'TPCircularBuffer' in module 'MirgaWrapper.TPCircularBuffer'
.../XCFrameworkIntermediates/AudioKit/AudioKit.framework/Headers/TPCircularBuffer.h:66:23: '(anonymous struct)::length' from module 'AudioKit.TPCircularBuffer' is not present in definition of 'TPCircularBuffer' in module 'MirgaWrapper.TPCircularBuffer'

When inspecting both TPCircularbuffer.h (from the c++ library and from AudioKit, both seem identical)
I am wondering how can i solve this problem without touching any of the TPCircularBuffer implementations? Both are not my code, so I would like to avoid forking their repos to make changes. On the other hand the library that is used by MyProject is a pure C/C++ implementation and cannot import AudioKit to use its TPCircularBuffer implementation.
To Reproduce
Steps to reproduce the behavior:

Create a c++ library that includes TPCircularBuffer via Submodule from https://github.com/michaeltyson/TPCircularBuffer
Create a host application that includes AudioKit and the c++ library from 1.
Try to compile the host application

Expected behavior
Compilation should pass
Details (please complete the following information):

Type: any
OS: ios14.4
AudioKit Version 4.11.2

Additional context
Add any other context about the problem here.

I'd rip TPCircularBuffer out of AudioKit 4 and make your own local copy. We will be removing it from AudioKit 5 shortly.

is it not required by audiokit?

No, not anymore.

well, it's not once we remove ezaudio, which is slated to happen soon.

well, i cant just rip it out. then audiokit wont compile anymore into a xcframework :/

Latest AK5 doesn't have TPCircularBuffer in it anymore. Not sure what else I can do. What's holding you onto AK4?


Stepify function problem with rounding

Godot version:
3.2.2 beta 3
OS/device including version:
GLES 3
Ubuntu 20.04
Issue description:
float stepify(s: float, step: float)

Snaps float value s to a given step. This can also be used to round a floating point number to an arbitrary number of decimals.

stepify(100, 32) # Returns 96
stepify(3.14159, 0.01) # Returns 3.14

This functions seems to not return 0 when needed. In my case I'm using it to change the float precision from: 1.512364 to 1.51 for player movement
func movement():
	velocity = move_and_slide(velocity,Vector3.UP,true,4,PI/3)
	velocity = vector_step(velocity,0.01)
	ScreenDebugger.dict["Velocity"] = velocity # prints (X.XX,X.XX,X.XX)

func vector_step(vector:Vector3,step:float):
	return Vector3(stepify(vector.x,step),stepify(vector.y,step),stepify(vector.z,step))

the problem comes where I use the player acceleration and deacceleration, the velocity never becomes 0:

Steps to reproduce:
Attach this code to a 3d object
var velocity:Vector3
var acc:float = 0
var speed:Vector3
const MAX_SPEED = 10
const ACC:float = 3.0
const DEACC:float = .9

func _physics_process(delta):
	velocity.y += delta * -5

	var input_forward = -int(Input.is_action_pressed("cmd_up")) + int(Input.is_action_pressed("cmd_down"))

	var hvel = velocity
	hvel.y = 0

	var target = global_transform.basis.z * input_forward * MAX_SPEED
	var acceleration = 0
	if input_forward < 0:
		acceleration = ACC
	else: acceleration = DEACC
	hvel = hvel.linear_interpolate(target, acceleration * delta)
	velocity.x = hvel.x
	velocity.z = hvel.z

	velocity = move_and_slide(velocity,Vector3.UP,true,4,PI/3)
	velocity = vector_step(velocity,0.01)
	print(str(velocity))

func vector_step(vector:Vector3,step:float):
	return Vector3(stepify(vector.x,step),stepify(vector.y,step),stepify(vector.z,step))

Minimal reproduction project:
N/A

Seems like the change in velocity gets small enough that it can't round smaller anymore. If the change in velocity is < 0.005 per frame, then stepify will continue to round up.
Can you create a minimal project that shows that there is in fact a problem with stepify?

This is likely a problem with your code. As @nisovin stated, your deceleration value becomes so low that stepify always return the same value. So this is very likely a problem with your implementation.
Please ask for help in the other community channels first. And if you find out a case where the stepify function does not return a correct number, please open another issue with a minimal example where it does not work.

@groud I know this could be a mistake of mine implementation, but my point here is the function behaviour
in this case: 1.123456789 -> stepify to X.XX -> 1.12
if the value reaches 0.001000000 the returning value should be 0 cuz it only considers the stepify chosen

No. If you do stepify(0.01, 0.01) the expected result in 0.01.
Stepify rounds to input to the closest number that is a multiple of the step value. So this result is perfectly expected.

if the value reaches 0.001000000 the returning value should be 0 cuz it only considers the stepify chosen

If you do stepify(0.001, 0.1) it will return 0. The issue is your code never reaches that point, you never pass in a value that small.


React Native 0.61 update with ugly kludge

This ugly kludge workaround resolves an issue that I encountered with symlink to .. starting with metro 0.55 / React Native 0.61 (was not needed with React Native 0.60 / metro 0.54):
  resolver: {
    get extraNodeModules () {
      return Object.assign(
        {},
        ...Object.keys(require('./package.json').dependencies).map(name => ({
          [name]: ['.', 'node_modules', name].join('/'),
        }))
      )
    }
  }

Without this ugly kludge, I encountered this error message in the generated example with the symlink on React Native 0.61:
error: bundling failed: Error: Unable to resolve module `react-native` from `../index.js`: react-native could not be found within the project.

I hope the issue can be resolved on metro within the near future.

Tested as follows:

[x] npm test
[x] able to create native library module with example on React Native 0.61 and run it on Android & iOS
[x] able to create native view with example on React Native 0.61 and run it on Android & iOS


fix invisible 'number of items' in search bar

This fixes invisible 'number of items' in search bar, in uchiwa-dark theme
uchiwa/issues/532

Since we are using SCSS for generating the CSS files, I went ahead and implemented this PR on the source file instead. Thank you anyway for this PR!


Exclude private modules

Fixes #52

thanks for taking care of this! I've published this as 1.8.0 and updated the readme. I forget if you also had admin rights to the npm package, but happy to add you there as well if you have an npm account - I don't want to become a blocker on getting new things in :)

Yeah that'd be sweet. Add me as cl0sey.

donezo! npm owner ls npm_lazy


Change the account associated with a project

As a program manager with OWNER permission to a project, I wish to change the account against which this project bills, so that I can maintain my workspaces, buckets, etc but shift them onto different funding. This is particularly important when my free credits have expired. In this case, I want to move my credits project from the credits account (which I do not have access to) to a new account that I control.
I need to select a new account from a list of multiple accounts that I have permissions on.
NOTES

FireCloud does not allow this today
We should push that this be considered a nice-to-have rather than a must-have in its impact on net new user on-boarding plans.
There is apparently a way to do this on the google project console. Since the Terra backend owns these projects, we should be able to do this. But we need to confirm that! Likely path is that this requires an endpoint in Rawls.

API https://cloud.google.com/billing/reference/rest/v1/projects/updateBillingInfo
Does FC have all the right permissions etc to do this? Can we do it without rawls? Or is it by the FC service account?


re-fetch silo profiles periodically to pick up new homepage links

...e.g. when users sign up for bridgy, then later add a link to their web site. this bit @dshanske recently: http://indiewebcamp.com/irc/2014-10-23#t1414072684397

this would also be useful for detecting when accounts go private/protected after signing up (#628).

also, we could do this for Twitter and Instagram as part of poll, since we get the full Twitter user object in each tweet, and we'll get most of the Instagram user too when we switch to scraping (#603).


Run/Debug unittest Method does not run setUpClass

Environment data

VS Code version: 1.28.2
Extension version (available under the Extensions sidebar): 2018.9.2
OS and version: macOS Mojave 10.14.1
Python version (& distribution if applicable, e.g. Anaconda): 2.7.15
Type of virtual environment used (N/A | venv | virtualenv | conda | ...): virtualenv
Relevant/affected Python packages and their versions: unittest

Actual behavior
Clicking the Run Test overlay for a unit test method (within a unittest.TestCase class) leads to the test class setUp method being called, but not its setUpClass method; the setUpClass method only gets run if you click the Run Test overlay above the entire test class.
Expected  behavior
Running a single test method should ensure that all proper setup gets executed.
Steps to reproduce:

mkvirtualenv vanilla
Open vscode and set interpreter to vanilla virtualenv's interpreter
Enable unittest as the testing framework
Create a module with the following test file:

import unittest

class Test(unittest.TestCase):
    @classmethod
    def setUpClass(cls):
        super(Test, cls).setUpClass()
        print('Setting up class\n')

    def setUp(self):
        super(Test, self).setUp()
        print('Setting up method\n')

    def test(self):
        return

Click the Run Test overlay over the Test class; in the Python Test Log output you can see both print statements.

Click the Run Test overlay over the test method; in the Python Test Log output you can only see the Setting up method statement.

Logs (Python Test Log)
Class Output
test_test.Test.test
Setting up class

Setting up method

test (test_test.Test) ... ok

----------------------------------------------------------------------
Ran 1 test in 0.001s

OK

Method Output
test (test_test.Test) ... Setting up method

ok

----------------------------------------------------------------------
Ran 1 test in 0.001s

OK

Experimenting a little more, seems like this isn't an issue if I'm using pytest; if pytest is enabled as the testing framework, then I see both print statements regardless of which Run Test I click on.

This might be a bug in Python 2 as our code simply asks unittest to run your specified test method (in other words nothing magical or tricky).

Looks like this is also the case in Python 3; looks like the unittest TextTestRunner (which is what the vscode Python extension calls) only runs the TestCase run method, which only calls setUp and not setUpClass. On the other hand, the TestSuite class (which is what probably gets called when running an entire test class) actually does call setUpClass in its run method, so this explains the discrepancy.
Maybe it's intended behavior; not sure.


Write log messages to files on Linux 🚥 #1410

Depends on #1410

Instead of logging to stderr, write log messages to files in /var/log/sourcekit-lsp/sourcekit-lsp-<pid>.log.
This allows us to retrieve the log messages from sourcekit-lsp diagnose.
We should be able to expand this to also write to log files on Windows but I still need to figure out what an appropriate log directory might be. That will be a follow-up PR.
Fixes #1286
rdar://127138318

@swift-ci Please test

I re-wrote the implementation quite a bit based on feedback from @bnbarham to roll through 10 log files of 5MB each instead of truncating one log file in place since it reduces the number of bytes that need to be written (in the old implementation we needed to write 4MB every time we trimmed the start of the log).

@swift-ci Please test

@swift-ci Please test Windows

@swift-ci Please test

@swift-ci Please test Windows


Add basic region, block, operation iteration

Start of a basic walk from operation to region to block to operation.

I was also considering just exposing a list return here, that may be more convenient Native side, could switch to that instead


Add "libzip" package

I'm interested in package libzip

Official GitHub repository: https://github.com/nih-at/libzip

Used build system: CMake

This package has next dependencies:

OpenSSL (required, available in Hunter: https://docs.hunter.sh/en/latest/packages/pkg/OpenSSL.html)
BZip2 (required, available in Hunter: https://docs.hunter.sh/en/latest/packages/pkg/BZip2.html)
ZLIB (required, available in Hunter: https://docs.hunter.sh/en/latest/packages/pkg/ZLIB.html)

@ruslo I have a working fork, need one to push to in hunter-packages.

I have a working fork, need one to push to in hunter-packages.

Done: https://github.com/hunter-packages/libzip

Fixed: https://github.com/ruslo/hunter/pull/1877


Improvements

Run named pod vs names deployment in Create the SSH Connection section
kubectl run -it --rm --image=debian --generator=run-pod/v1 aks-ssh -- sh -c "apt-get update && apt-get install openssh-client -y && sh"
This way container name will be aks-ssh
Some other improvements in my guide I use for Linux:
Connect with SSH to Azure Kubernetes Service (AKS) cluster nodes for maintenance or troubleshooting
Based on https://docs.microsoft.com/en-us/azure/aks/ssh
But improved for Bash with less manual steps
Steps:

[Terminal Session 1] Set convenience variables
Set cluster info SUB_ID, CLUSTER, RG_CLUSTER. Also locates 1st available NODE_IP and NODE_NAME.
If using non default SSH keys change: KEY_PUB_PATH, KEY_PRIV_PATH
SUB_ID=<subscription_id_with_resources> \
&& CLUSTER_NAME=<aks_cluster_name> \
&& RG_CLUSTER=<resource_group_where_aks_cluster_resource_is_located> \
&& NODE_NUMBER=0 \
&& RG_AKS=$(az aks show -g $RG_CLUSTER -n $CLUSTER_NAME --subscription $SUB_ID --query 'nodeResourceGroup' -otsv) \
&& KEY_PUB_PATH="$HOME/.ssh/id_rsa.pub" \
&& KEY_PRIV_PATH="$HOME/.ssh/id_rsa" \
&& NODE_IP=$(az vm list-ip-addresses --resource-group $RG_AKS --subscription $SUB_ID --query "[$NODE_NUMBER].virtualMachine.network.privateIpAddresses[0]" -otsv) \
&& NODE_NAME=$(az vm list-ip-addresses --resource-group $RG_AKS --subscription $SUB_ID --query "[$NODE_NUMBER].virtualMachine.name" -otsv)

[Terminal Session 1] (Optionally) Change desired cluster node
List all nodes
az vm list-ip-addresses --resource-group $RG_AKS --subscription $SUB_ID --query "[].virtualMachine.name"

Change node number from 0 to desired node position in the array (0 based)
NODE_NUMBER=<desired_node_index> \
  && NODE_IP=$(az vm list-ip-addresses --resource-group $RG_AKS --subscription $SUB_ID --query "[$NODE_NUMBER].virtualMachine.network.privateIpAddresses[0]" -otsv) \
  && NODE_NAME=$(az vm list-ip-addresses --resource-group $RG_AKS --subscription $SUB_ID --query "[$NODE_NUMBER].virtualMachine.name" -otsv)

[Terminal Session 1] (Optionally) add ssh public key to the node (if you don't have one from AKS creation)
az vm user update \
  --resource-group $RG_AKS \
  --name $NODE_NAME \
  --subscription $SUB_ID \
  --username azureuser \
  --ssh-key-value $KEY_PUB_PATH

[Terminal Session 2] In separate terminal window run debian pod with openssh-client
kubectl run -it --rm --image=debian --generator=run-pod/v1 aks-ssh -- sh -c "apt-get update && apt-get install openssh-client -y && sh"

[Terminal Session 1] After you are in the container shh session on Terminal Session 2, place SSH private key into container
kubectl cp $KEY_PRIV_PATH aks-ssh:/id_rsa

[Terminal Session 1] Print NODE_IP
echo $NODE_IP

[Terminal Session 2] Permission private key and ssh into node ip retrieved via the previous command in Terminal Session 1
chmod 0600 id_rsa && ssh -i id_rsa azureuser@<node_ip>

[Terminal Session 2] Finishing work
Run exit to end the session and pod will be automatically removed.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 3b81a147-db1c-b92f-88d1-6dd0991a72fe
Version Independent ID: f5a2c949-498f-5848-d89c-031d1a757120
Content: SSH into Azure Kubernetes Service (AKS) cluster nodes
Content Source: articles/aks/ssh.md
Service: container-service
GitHub Login: @iainfoulds
Microsoft Alias: iainfou

Thanks for the feedback! I have assigned the issue to the content author to investigate further and update the document as appropriate.

Thanks for the feedback, @choovick. Some of this feedback is already underway, such as setting convenience variables. The problem is that it makes it more dependent on a given shell, and abstracts a little too much what the user is doing.
When it comes to security of the nodes, we've found combining multiple commands like you propose is harder to understand what's happening and is being done with the cluster, but it's absolutely something you're welcome to script and combine like you propose once you understand what is being done.
As we already have some improvements in this doc lined up to help with readability, @MicahMcKittrick-MSFT #please-close

There even is a simpler solution if you want to update the user on all nodes, documented here:
az vm user update -u username --ssh-key-value "$(< ~/.ssh/id_rsa.pub)" --ids $(az vm list -g MyResourceGroup --query "[].id" -o tsv)
This doesn't work with CMD but thankfully there is WSL ;)


HIP make fails on roc-2.3.x branch

Checked out the roc-2.3.x branch of HIP source code since I am developing on the roc-2.3.x ROCK-Kernel.
Steps followed:
mkdir build; mkdir hip
cd build
cmake -DHSA_PATH=/path/to/hsa -DHCC_HOME=/path/to/hcc -CMAKE_INSTALL_PREFIX=../hip -DCMAKE_BUILD_TYPE=Release ..
make
cmake output:
-- The C compiler identification is GNU 7.4.0
-- The CXX compiler identification is GNU 7.4.0
-- Check for working C compiler: /usr/bin/cc
-- Check for working C compiler: /usr/bin/cc -- works
-- Detecting C compiler ABI info
-- Detecting C compiler ABI info - done
-- Detecting C compile features
-- Detecting C compile features - done
-- Check for working CXX compiler: /usr/bin/c++
-- Check for working CXX compiler: /usr/bin/c++ -- works
-- Detecting CXX compiler ABI info
-- Detecting CXX compiler ABI info - done
-- Detecting CXX compile features
-- Detecting CXX compile features - done
-- HIP Platform: hcc
-- HIP Compiler: hcc
-- Looking for HCC in: /opt/rocm/hcc. Found version: 1.2.18354-ec91fed-e2b51bf-009cb63
-- Looking for HSA runtime in: /opt/rocm/hsa
-- HIP will be installed in: /home/prateeks/HIP/hip
-- Generating profiling promitives: /home/prateeks/HIP/include/hip/hcc_detail/hip_prof_str.h
/home/prateeks/HIP/hip_prof_gen.py Warning: implementation not found: hipMemcpyToSymbolAsync
/home/prateeks/HIP/hip_prof_gen.py Warning: implementation not found: hipMemcpyFromSymbolAsync
/home/prateeks/HIP/hip_prof_gen.py Warning: implementation not found: hipMemcpyFromSymbol
/home/prateeks/HIP/hip_prof_gen.py Warning: implementation not found: hipModuleGetGlobal
/home/prateeks/HIP/hip_prof_gen.py Warning: implementation not found: hipGetSymbolAddress
/home/prateeks/HIP/hip_prof_gen.py Warning: implementation not found: hipGetSymbolSize
/home/prateeks/HIP/hip_prof_gen.py Warning: implementation not found: hipMemcpyToSymbol
/home/prateeks/HIP/hip_prof_gen.py Warning: 7 API calls missing in interception layer
-- Found HIP: /home/prateeks/HIP/hip (found version "1.5.19123")
-- Configuring done
-- Generating done
-- Build files have been written to: /home/prateeks/HIP/build
make output:
Scanning dependencies of target hip_hcc_static
[  0%] Building CXX object CMakeFiles/hip_hcc_static.dir/src/code_object_bundle.cpp.o
[  0%] Building CXX object CMakeFiles/hip_hcc_static.dir/src/hip_clang.cpp.o
[  9%] Building CXX object CMakeFiles/hip_hcc_static.dir/src/hip_hcc.cpp.o
/home/prateeks/HIP/src/hip_hcc.cpp:2175:19: error: no member named 'copy2d_ext' in 'hc::accelerator_view'
crit->_av.copy2d_ext(src, dst, width, height, srcPitch, dstPitch, hcCopyDir, srcPtrInfo, dstPtrInfo,
~~~~~~~~~ ^
/home/prateeks/HIP/src/hip_hcc.cpp:2398:28: error: no member named 'copy2d_ext' in 'hc::accelerator_view'
crit->_av.copy2d_ext(src, dst, width, height, srcPitch, dstPitch, hcCopyDir, srcPtrInfo, dstPtrInfo,
~~~~~~~~~ ^
/home/prateeks/HIP/src/hip_hcc.cpp:2404:49: error: no member named 'copy2d_async_ext' in 'hc::accelerator_view'
const auto& future = crit->_av.copy2d_async_ext(src, dst, width, height, srcPitch, dstPitch, hcCopyDir, srcPtrInfo, dstPtrInfo,
~~~~~~~~~ ^
/home/prateeks/HIP/src/hip_hcc.cpp:2432:20: error: no member named 'copy2d_ext' in 'hc::accelerator_view'
crit->_av.copy2d_ext(src, dst, width, height, srcPitch, dstPitch, hcCopyDir, srcPtrInfo, dstPtrInfo,
~~~~~~~~~ ^
4 errors generated.
/home/prateeks/HIP/src/hip_hcc.cpp:2175:19: error: no member named 'copy2d_ext' in 'hc::accelerator_view'
crit->_av.copy2d_ext(src, dst, width, height, srcPitch, dstPitch, hcCopyDir, srcPtrInfo, dstPtrInfo,
~~~~~~~~~ ^
/home/prateeks/HIP/src/hip_hcc.cpp:2398:28: error: no member named 'copy2d_ext' in 'hc::accelerator_view'
crit->_av.copy2d_ext(src, dst, width, height, srcPitch, dstPitch, hcCopyDir, srcPtrInfo, dstPtrInfo,
~~~~~~~~~ ^
/home/prateeks/HIP/src/hip_hcc.cpp:2404:49: error: no member named 'copy2d_async_ext' in 'hc::accelerator_view'
const auto& future = crit->_av.copy2d_async_ext(src, dst, width, height, srcPitch, dstPitch, hcCopyDir, srcPtrInfo, dstPtrInfo,
~~~~~~~~~ ^
/home/prateeks/HIP/src/hip_hcc.cpp:2432:20: error: no member named 'copy2d_ext' in 'hc::accelerator_view'
crit->_av.copy2d_ext(src, dst, width, height, srcPitch, dstPitch, hcCopyDir, srcPtrInfo, dstPtrInfo,
~~~~~~~~~ ^
4 errors generated.
CMakeFiles/hip_hcc_static.dir/build.make:110: recipe for target 'CMakeFiles/hip_hcc_static.dir/src/hip_hcc.cpp.o' failed
make[2]: *** [CMakeFiles/hip_hcc_static.dir/src/hip_hcc.cpp.o] Error 1
CMakeFiles/Makefile2:1822: recipe for target 'CMakeFiles/hip_hcc_static.dir/all' failed
make[1]: *** [CMakeFiles/hip_hcc_static.dir/all] Error 2
Makefile:140: recipe for target 'all' failed
make: *** [all] Error 2
the rock libraries, like hcc, hsa are on the latest versions -- hcc (1.2.18354), hip_hcc (1.5.18353), hsa-rocr-dev (1.1.9-8-g51c00c2), hsa-ext-rocr-dev (1.1.9-8-g51c00c2).
Any help will be appreciated.

Looks like you are not using recent HCC. copy2d_ext is defined here https://github.com/RadeonOpenCompute/hcc/blob/clang_tot_upgrade/include/hc.hpp#L379
Can you try by building latest hcc or using ROCm 2.3 released HCC packages?

Hi Rahul, can you please tell me if the apt packages for hcc not on the latest versions (ROCm 2.3)? I did think that the hcc version dependencies could have been an issue and updated my apt packages.
I did try to build hcc from the source as well and my make failed with an error as described by this GitHub issue (https://github.com/RadeonOpenCompute/hcc/issues/960).

Your ROCm stack looks quite old. You need to upgrade to the latest ROCm stack- including ROCr. Just building latest HCC may not be enough.  Please refer https://github.com/RadeonOpenCompute/ROCm#current-rocm-version-23
RadeonOpenCompute/hcc#960 would be resolved once you upgrade to the latest ROCr.


Table read option to include null values

For table read, we made the decision of not returning null column values.
So we need to have an option of let user override the default behavior.
This nullOption is originally included in https://github.com/stargate/data-api/pull/1633, @amorton wants to think on naming stuff, so separate out as an issue,
related issue
https://github.com/stargate/data-api/issues/1571

lets call the option enableVerboseData , the problem is this will be default to false for tables or true for collections. Does not matter what the flag is called, it will be diff for the two :(
the other choice we had was disableSparseData.
Lets get the feature ready and then see what the command looks like, the hard part will be how we make this make sense for tables and collections.

discussion - go with enableVerboseData as the name, defaults to false, and if set to true and it is a Collection throw an error. For collections we assume the user put NULLS into the document on purpose. Can revisit later.


Chain upgrade requirements for Hermes (meta issue)

Crate
ibc-relayer
Summary
Hermes requires some additional features to make chain upgrades more user-friendly.
Briefly, three features would be good to have:

[x] #1287

switch between /cosmos.upgrade.v1beta1.SoftwareUpgradeProposal and /ibc.core.client.v1.UpgradeProposal at runtime, based on a --legacy flag passed to the tx raw upgrade chain CLI

[ ]  #1148

listen and parse newBlockEvents to catch the upgraded consensus state event, and react on that by upgrading all counterparty clients

[ ] handle revision number changes upon chains upgrading: there are two sub-cases here:

[ ] correct client latest height upon chain id revision change
[ ] test that Hermes is able to re-establish connection to the chain post-upgrade, once the chain has a higher revision number, so for hermes these are new chains, e.g. ibc-0 node will be upgraded and restarted as ibc-1 (From @ancazamfir's comment)

These will be further documented in their own issue.
Problem Definition
The current workflow for upgrading a chain is:

submit chain upgrade proposal (either via hermes upgrade-chain or gaiad)

if the chain is on SDK 0.42.*, use Hermes (v0.6.0 works)

use Hermes to upgrade counterparty clients of all other chains (using #763)

If the chain is using SDK 0.43, we are now adding support for it (#948) but that should be backwards compatible with 0.42, so that users can use the same Hermes version to do chain upgrades regardless of the minor version; that is the first feature above.
Having the second feature "automatic client upgrade" will simplify the workflow and make the process more smooth. With this feature, Hermes will react on a specific event of the upgrading chain and trigger counterparty client upgrades.

For Admin Use

[ ] Not duplicate issue
[ ] Appropriate labels applied
[ ] Appropriate milestone (priority) applied
[ ] Appropriate contributors tagged
[ ] Contributor assigned/self-assigned

Sharing context here from a discussion in our IBC weekly call:

ideal timeline: anytime before ibc clients will need to be upgraded
IBC clients on mainnets will need to undergo an upgrade because the IAVL in the SDK is abandoned → proof specs need to be updated (which the client stores)

Chains doing the upgrade will store the new proof spec (client's 'upgrade_path')


Perform June crawl

@franciscawijaya will perform the crawl (with possible help from @katehausladen).

The crawler is in progress right now. Things to take note for me:

Routinely checks the crawler to make sure everything is going well and the crawler does not stop halfway (if it is, take steps to restart it from the point that it stops)
Familiarize myself with the Google Collab

As per our conversation on call, I have compared the result of some sites on the June crawl pt1 and April crawl pt1 and they looked similar -- the crawl is looking great, so far! Just to track the progress, I'm currently on the third set and in the meantime, I'm changing all the formats for the json files to be readable and also reading through the Google Collab.

Nice, @franciscawijaya!

Added to the 8th batch!

The last batch of the crawl is now done and everything looks great so far!
Next step: I will now begin to parse and analyze the crawl data which would be finished latest by our Thursday meeting.

Excellent! Great news!

Update: I have transferred all of the crawl data to the Google Drive and am starting to collate the redo_sites.csv using the Google Collab now that we have all the data. However, I'm currently facing an error when running one of the lines of code and have been struggling to figure out where it went wrong. But, I have reached out to labmates for output and I will continue on debugging.

Solved! I'm now running the redo sites (Google Collab collated 720 sites without subdomains to be crawled).

An update: I have crawled the redo sites and I also tried to run the well-known script. However, I faced a problem in which only the well-known-data.csv was updated and not the well-known-errors.csv once the code fully ran. Nevertheless, I think I found out what the problem was and am now re-running the script. Hopefully, I would have both the well-known-data and well-known-errors by tomorrow morning and can then start working on parsing and analyzing to get all the figures too.

As discussed, @franciscawijaya if you can do the following:

[ ] Create/update crawl release
[ ] Update crawl documentation as necessary

Then, feel free to close this issue.

As mentioned in the meeting, while I am done with the crawl, I am still figuring out the parsing/analyzing of the data and creating the figures which would be my task for this week. I will be closing this issue now as I'm done with the crawl and will make a new issue in gpc-web-crawler-paper to post the figures and data once I finish working out the analysis and figures.


1.5 istio backports 26 07 2019

Istio GSG updated to Istio release 1.2.2.

This change is

Wrong base, duh.


Add 'require' flag to preload JS modules

This PR contains a:

[ ] bugfix
[x] new feature
[ ] code refactor
[ ] test update
[ ] typo fix
[ ] metadata update

Motivation / Use-Case
Add --require flag (and its alias -r) to preload JS modules. The flag could be added multiple times to load multiple modules.
webpack-serve -r dotenv/env

Breaking Changes
none
Additional Info
The biggest wins with this flag is the possibility to use dotenv and esm packages. Unfortunately, esm does nothing because cosmiconfig uses require-from-string (track progress here https://github.com/davidtheclark/cosmiconfig/issues/109).

@ooflorent I wonder if we could mock require-from-string and intercept the requiring of that module with https://www.npmjs.com/package/mock-require.

That could work but it's hacky. Another option is to replace cosmiconfig by something else.

cosmiconfig really is the best at what it does. I'm not overly opposed to hacks for a development module when that hack is for somewhat-edge cases.

@shellscape If you PR something, I'll be glad to review it ;)


Q: is localDataChannel ever used?

Seems localDataChannel is initialized but never used?

Hi, Yes there is a usage of data channels in this demo app. It it used to send a message to the other peer via the UI. It is initialized together with the audio and video tracks in createMediaSenders()

@stasel Merry Christmas! Thanks your your prompt reply and thank you for WebRTC SPM package, it is great!
My question above was specifically about localDataChannel variable, it is private and it is initialized here, but it is never used.
The other "twin" channel remoteDataChannel is on the other hand used, here when sending data, it gets set when the callback peerConnection:didOpen is called here
I think it IS needed actually, but indeed "never used", it makes it so that the RTCOffer contains a DataChannel and it is needed as a "hook" for RTCDataChannelDelegate.
In my own code base I to not have the remoteDataCannel at all, I use the single one, i.e. I send data on the localDataChannel once it gets open.


set up a continuous integration process to maintain the quality of the code

We can reuse what I did for a personal project https://github.com/ccoVeille/golangci-lint-config-examples/pull/7

For records d260bbda42b97ffc05173d81647101f2f4370590 was merged with #39, and we miss the fact it broke the yaml

#43 implements the yamllint part

#44 implements the license checks

I think our current preference seems to be:

Follow GitHub preferences for landing page type files such as README.md and CODE_OF_CONDUCT.md
Use PascalCase in rules
Use snake_case in everything else.

Exactly


Outdated ref API throwing warnings

Expected behavior
We should move on to use ref={React.createRef()} API
Actual behavior
ref={(input) => { this.input = input; }}
Steps to reproduce

I'm happy to make a PR to address this


Wrap render method created using class properties.

Fixes https://github.com/zeit/next.js/issues/828
With this, we are wrapping the render method added using ES2016+ class properties.
It doesn't add the render method to class's prototype. So, that's why we need to do this.

alternate PR https://github.com/zeit/next.js/pull/856


Add: America TeVe [PR]

Channel Name
America TeVe
Alternative Names (optional)
América TeVé
Network (optional)
América CV Network
Owners (optional)
No response
Country
PR
Subdivision (optional)
No response
City (optional)
San Juan
Broadcast Area
c/PR
Languages
spa
Categories (optional)
General;entertainment
NSFW
FALSE
Launched (optional)
No response
Closed (optional)
No response
Replaced By (optional)
No response
Website (optional)
https://www.americatevepr.com/
Logo
https://www.americatevepr.com/css-custom/189/images/header-logo-sticky.svg
Notes
No response

Geo-blocked.

Added in https://github.com/iptv-org/database/commit/ce4b777abbffb06234bb5b79aa74cbd03d896e74


Unbreak the build

For some reason, BestEffortTastyWriter does not compile since PlainFile does not have a delete method, only File does.

I wonder: Why did the original failing code get through the CI?

I see now it's already handled in #20355. On the other hand, maybe the fix here is preferable. I see that lot's of files have unimplemented as a delete method. So maybe it's not such a good idea to add it, after all?

In any case, we should merge either this PR or #20355. I leave it to you to decide which.

It was an old PR, which had a passing CI run on top of old main without the changes. I didn't realize that when I was asked to review it earlier today. I prefer this fix, but I wanted to have the main fixed as soon as possible so I tried to revert after noticing. Seems like both CIs got stuck on test_windows, but I believe those errors to be spurious. I will try to restart the failed tasks, and I will merge the PR that will have a successful run (but preferably this one).

It was an old PR, which had a passing CI run on top of old main without the changes.

I see, that explains it. Maybe we should have a recommendation that old PRs are re-tested before merge. On the other hand, that would have added to the crazy build load we had today.


Revert "UI: Fix detail settings"

Reverts apache/cloudstack#6335 since it affects the template detail view - delete template

UI build: :heavy_check_mark:
Live QA URL: http://qa.cloudstack.cloud:8080/client/pr/6339 (SL-JID-1499)

@acs-robot a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.

UI build: :heavy_check_mark:
Live QA URL: http://qa.cloudstack.cloud:8080/client/pr/6339 (SL-JID-1500)


Navigating back does not work when clicking on 1-2-3 steps

When I click on, let's say, 2 - Distribution, and press Back (in the browser), nothing happens. It could work normally.

Still not working correctly:

Go to https://dev.nkod.opendata.cz/datové-sady and open Local catalog registration
Click on Step 2
Click on Step 1
Try to go back to DAV

That is catalog registration not dataset registration as in the issue - different component.


Bring _ClusterTaggableManager.add back in sync with django-taggit

This adds support for case-insensitive tags and validation of invalid types:
https://github.com/alex/django-taggit/commit/0c8013f580cae1b024fefb4439eda61738afdb57
https://github.com/alex/django-taggit/commit/bb3dc0a98d6d2c9efa87ef0a6fd79e172f7ed62e

Merged in 64337f2b0b0318350699168c4e9e4f29d4f65cbe


Updated the docs for the Adobe I/O CLI (v2.0)

See https://github.com/adobe/aio-cli/releases/tag/2.0.1-dev.0
The new version of the CLI hasn't been released yet.

@mcorlan I just published @adobe/aio-cli version 2.0.1 and it is live. Can we get this docs PR in?


Docker Compose container networking failing when logs show: Hosted Agent (hosted) vs GitHub Actions 3 (hosted)

Description
During our acceptance tests, curl commands time out when logs show:
2022-11-07T20:36:10.1215516Z Job is about to start running on the hosted runner: Hosted Agent (hosted)

The same jobs will succeed if the logs show:
2022-11-07T21:29:33.1122159Z Job is about to start running on the hosted runner: GitHub Actions 3 (hosted)

I'm not sure what the difference is between these runners, but I can consistently see our actions fail when the logs show Hosted Agent (hosted) and pass when they show GitHub Actions 3 (hosted)
Sample Failed Logs:
2022-11-07T20:36:06.2012642Z Requested labels: ubuntu-latest
2022-11-07T20:36:06.2012687Z Job defined at: xxx/xxx/.github/workflows/ci.yml@refs/pull/30/merge
2022-11-07T20:36:06.2012708Z Waiting for a runner to pick up this job...
2022-11-07T20:36:06.3959883Z Job is waiting for a hosted runner to come online.
2022-11-07T20:36:10.1215516Z Job is about to start running on the hosted runner: Hosted Agent (hosted)
2022-11-07T20:36:12.1476610Z Current runner version: '2.298.2'
2022-11-07T20:36:12.1506107Z ##[group]Operating System
2022-11-07T20:36:12.1506715Z Ubuntu
2022-11-07T20:36:12.1507050Z 20.04.5
2022-11-07T20:36:12.1507688Z LTS
2022-11-07T20:36:12.1508048Z ##[endgroup]
2022-11-07T20:36:12.1508412Z ##[group]Runner Image
2022-11-07T20:36:12.1508807Z Image: ubuntu-20.04
2022-11-07T20:36:12.1509207Z Version: 20221027.1
2022-11-07T20:36:12.1509778Z Included Software: https://github.com/actions/runner-images/blob/ubuntu20/20221027.1/images/linux/Ubuntu2004-Readme.md
2022-11-07T20:36:12.1510467Z Image Release: https://github.com/actions/runner-images/releases/tag/ubuntu20%2F20221027.1
2022-11-07T20:36:12.1511056Z ##[endgroup]
2022-11-07T20:36:12.1511454Z ##[group]Runner Image Provisioner
2022-11-07T20:36:12.1511835Z <IP_ADDRESS>
2022-11-07T20:36:12.1512170Z ##[endgroup]
2022-11-07T20:36:12.1513261Z ##[group]GITHUB_TOKEN Permissions
2022-11-07T20:36:12.1513949Z Actions: write
2022-11-07T20:36:12.1514313Z Checks: write
2022-11-07T20:36:12.1514916Z Contents: write
2022-11-07T20:36:12.1515359Z Deployments: write
2022-11-07T20:36:12.1515741Z Discussions: write
2022-11-07T20:36:12.1516129Z Issues: write
2022-11-07T20:36:12.1516489Z Metadata: read
2022-11-07T20:36:12.1516902Z Packages: write
2022-11-07T20:36:12.1517269Z Pages: write
2022-11-07T20:36:12.1517909Z PullRequests: write
2022-11-07T20:36:12.1518316Z RepositoryProjects: write
2022-11-07T20:36:12.1518725Z SecurityEvents: write
2022-11-07T20:36:12.1519118Z Statuses: write
2022-11-07T20:36:12.1519518Z ##[endgroup]
2022-11-07T20:36:12.1523152Z Secret source: Actions
2022-11-07T20:36:12.1523781Z Prepare workflow directory
2022-11-07T20:36:12.2463785Z Prepare all required actions
2022-11-07T20:36:12.2646192Z Getting action download info
2022-11-07T20:36:12.5800416Z Download action repository 'shivammathur/setup-php@v2' (SHA:1a18b2267f80291a81ca1d33e7c851fe09e7dfc4)
2022-11-07T20:36:12.9034275Z Download action repository 'actions/checkout@v2' (SHA:e2f20e631ae6d7dd3b768f56a5d2af784dd54791)
2022-11-07T20:36:13.1436548Z Download action repository 'actions/cache@v1' (SHA:70655ec8323daeeaa7ef06d7c56e1b9191396cbe)
2022-11-07T20:36:13.3369067Z Download action repository 'actions/setup-node@v2' (SHA:1f8c6b94b26d0feae1e387ca63ccbdc44d27b561)
2022-11-07T20:36:13.5789030Z Download action repository 'actions/upload-artifact@v2' (SHA:82c141cc518b40d92cc801eee768e7aafc9c2fa2)

Sample Success Logs
2022-11-07T21:29:28.2999705Z Requested labels: ubuntu-latest
2022-11-07T21:29:28.2999743Z Job defined at: moderntribe/home-run-inn-pizza-v2/.github/workflows/ci.yml@refs/pull/30/merge
2022-11-07T21:29:28.2999759Z Waiting for a runner to pick up this job...
2022-11-07T21:29:28.9036128Z Job is waiting for a hosted runner to come online.
2022-11-07T21:29:33.1122159Z Job is about to start running on the hosted runner: GitHub Actions 3 (hosted)
2022-11-07T21:29:35.2446528Z Current runner version: '2.298.2'
2022-11-07T21:29:35.2472405Z ##[group]Operating System
2022-11-07T21:29:35.2473036Z Ubuntu
2022-11-07T21:29:35.2473332Z 20.04.5
2022-11-07T21:29:35.2473697Z LTS
2022-11-07T21:29:35.2474012Z ##[endgroup]
2022-11-07T21:29:35.2474339Z ##[group]Runner Image
2022-11-07T21:29:35.2474702Z Image: ubuntu-20.04
2022-11-07T21:29:35.2475277Z Version: 20221027.1
2022-11-07T21:29:35.2475800Z Included Software: https://github.com/actions/runner-images/blob/ubuntu20/20221027.1/images/linux/Ubuntu2004-Readme.md
2022-11-07T21:29:35.2476482Z Image Release: https://github.com/actions/runner-images/releases/tag/ubuntu20%2F20221027.1
2022-11-07T21:29:35.2476931Z ##[endgroup]
2022-11-07T21:29:35.2477320Z ##[group]Runner Image Provisioner
2022-11-07T21:29:35.2477676Z <IP_ADDRESS>
2022-11-07T21:29:35.2477976Z ##[endgroup]
2022-11-07T21:29:35.2479013Z ##[group]GITHUB_TOKEN Permissions
2022-11-07T21:29:35.2479664Z Actions: write
2022-11-07T21:29:35.2479983Z Checks: write
2022-11-07T21:29:35.2480508Z Contents: write
2022-11-07T21:29:35.2480899Z Deployments: write
2022-11-07T21:29:35.2481240Z Discussions: write
2022-11-07T21:29:35.2481867Z Issues: write
2022-11-07T21:29:35.2482262Z Metadata: read
2022-11-07T21:29:35.2482581Z Packages: write
2022-11-07T21:29:35.2482913Z Pages: write
2022-11-07T21:29:35.2483270Z PullRequests: write
2022-11-07T21:29:35.2483631Z RepositoryProjects: write
2022-11-07T21:29:35.2484005Z SecurityEvents: write
2022-11-07T21:29:35.2484354Z Statuses: write
2022-11-07T21:29:35.2484696Z ##[endgroup]
2022-11-07T21:29:35.2488552Z Secret source: Actions
2022-11-07T21:29:35.2489067Z Prepare workflow directory
2022-11-07T21:29:35.3533594Z Prepare all required actions
2022-11-07T21:29:35.3724871Z Getting action download info
2022-11-07T21:29:35.7395693Z Download action repository 'shivammathur/setup-php@v2' (SHA:1a18b2267f80291a81ca1d33e7c851fe09e7dfc4)
2022-11-07T21:29:36.4023405Z Download action repository 'actions/checkout@v2' (SHA:e2f20e631ae6d7dd3b768f56a5d2af784dd54791)
2022-11-07T21:29:36.9785809Z Download action repository 'actions/cache@v1' (SHA:70655ec8323daeeaa7ef06d7c56e1b9191396cbe)
2022-11-07T21:29:37.4514692Z Download action repository 'actions/setup-node@v2' (SHA:1f8c6b94b26d0feae1e387ca63ccbdc44d27b561)
2022-11-07T21:29:38.0615389Z Download action repository 'actions/upload-artifact@v2' (SHA:82c141cc518b40d92cc801eee768e7aafc9c2fa2)

Platforms affected

[ ] Azure DevOps
[X] GitHub Actions - Standard Runners
[ ] GitHub Actions - Larger Runners

Runner images affected

[ ] Ubuntu 18.04
[X] Ubuntu 20.04
[ ] Ubuntu 22.04
[ ] macOS 10.15
[ ] macOS 11
[ ] macOS 12
[ ] Windows Server 2019
[ ] Windows Server 2022

Image version and build link
Version: 20221027.1
Is it regression?
I don't know
Expected behavior
I don't know the difference between the two stated runners, and I have no idea how they're assigned, but I'd expect them to function consistently.
Actual behavior
Networking or DNS appears to be broken inside docker containers brought up when the runner states Hosted Agent (hosted) .
Repro steps

Have a repo that has a docker-compose.yml that spins up any container.
Attempt to run a curl command in the container, e.g. `docker-compose exec -T container-name curl https://some.host

If the command fails, the top of the logs (via gear icon > View raw logs in the Github UI) will contain:
Job is about to start running on the hosted runner: Hosted Agent (hosted)

The same workflow will pass and the raw logs will contain:
Job is about to start running on the hosted runner: GitHub Actions 3 (hosted)

Hey @defunctl.
Could you please provide minimal steps to reproduce the issue?

@al-cheb Yes, I'll provide a better test case, may have to do with creating a docker network first.
Is there some way I can force the Hosted Agent (hosted) ?

@al-cheb under the hood, what is the difference between those two agents? Are there docs or anything I can check out to learn more?
It was the only difference I found between failing jobs, but I'll put together a repo to try to reproduce it in isolation.

@al-cheb under the hood, what is the difference between those two agents? Are there docs or anything I can check out to learn more?
It was the only difference I found between failing jobs, but I'll put together a repo to try to reproduce it in isolation.

We don't have such kind docs because it may be related to Azure datacenters.

Safe to say that Hosted Agent (hosted) agent vs GitHub Actions 3 (hosted) are on different infrastructure?

Apologies, things got really busy. Please give me a few days.

@al-cheb sorry for the delay. I was able to recreate this here https://github.com/moderntribe/actions-runner-debugging this run just failed: https://github.com/moderntribe/actions-runner-debugging/actions/runs/3517006693/jobs/5894268814
Let me know the best way to provide you with the raw logs?
Thanks


Reorganised vscode tasks

What does this PR do?

This reorganises VS Code setup tasks and adds a vscode.setup task that executes all of them.
Furthermore, this setup task may be executed from setup.setup.
Motivation

Additional Notes
#27508 will add the launch setup task.

Possible Drawbacks / Trade-offs

Describe how to test/QA your changes

/merge


Improvement on @Builder annotation

Could you guys automatically add @NoArgsConstructor when the annotation of @Builder is alone on class? As it is for example with @Data that already has @RequiredArgsContructor.

I was getting a problem in my application cause I was not using @NoArgsConstructor with @Builder. And reading https://projectlombok.org/features/Builder and others things about Builder patterns I thought that when you call YouClass.builder() the builder() method would instantiate a new class with no args.

@rafael-andrade

I thought that when you call YouClass.builder() the builder() method would instantiate a new class with no args.

Taken literally, yes. YouClass.builder() returns new YouClassBuilder()`, i.e., a new builder created using the no-args ctor.
That's probably not what you mean, but nobody knows what you mean. AFAIK @Builder needs an all-args ctor and it adds it, too.
If anything doesn't work for you, give us an example.


Prematurely Exiting Full Indexing

I was using this extension to index a couple hundred thousand documents from Firestore. The indexing job stopped after indexing around 20% of the documents.
Looks like the firestore query returned more documents then was requested by limit(DOCS_PER_INDEXING) 🤷. Because of this, the termination condition triggered and the job ended.
I attached a log showing records.length > DOCS_PER_INDEXING.
I think this can be fixed by just changing the termination condition to records.length < DOCS_PER_INDEXING.
downloaded-logs-20231206-104844.json

hey @LucasSwitz  how many documents are you trying to index?  check with Algolia support to make sure your Algolia application is under the right plan.

@LucasSwitz The extension v1.2.0 has been approved.  Can you check to see if you are running into the same issues.

I am closing this issue since I have not heard further comments.  I will assume the issue is resolved.


perf: use react router better

Description
We have a lot of low-hanging fruit to improve app-wide performance due to the way we are using react-router:

We use the Route's component prop extensively, which is not considered best practice because it creates a new component every render. This results in the existing component unmounting and the new component mounting every single render, and is likely causing some of the wired performance issues we get with routes. If we pass children instead it'll just update the existing component 📈
We unnecessarily wrap a lot of components in Switchs and Routes - this is not needed when there is only one component - I suspect some monkey see monkey do has gotten us here.

The app should be exactly the same, but a little speedier and more stable.
Notice

[x] Have you followed the guidelines in our Contributing guide?
[x] Have you checked to ensure there aren't other open Pull Requests for the same update/change?

Pull Request Type

[ ] :bug: Bug fix (Non-breaking Change: Fixes an issue)
[x] :hammer_and_wrench: Chore (Non-breaking Change: Doc updates, pkg upgrades, typos, etc..)
[ ] :nail_care: New Feature (Breaking/Non-breaking Change)

Issue (if applicable)
N/A
Risk
Medium to high - a lot of optimisations were made to routes, so we'll want to ensure that when navigating between pages and routes that everything still works as expected.
Testing
Do a smoke test navigating between both pages and routes.
Engineering
☝
All args that were passed via props should now be accessed using hooks.
Operations
☝
Screenshots (if applicable)
N/A

There is still a lot to do here to modernise our routes and conform to best-practice, but this is a reasonable start for now.


HBASE-28398 Make sure we close all the scanners in TestHRegion

@bbeaudreault This is for analyzing the memory leak problem for memstore.

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
0m 36s
Docker mode activated.


A better finder/searcher more like hit_forker

It's not an issue just suggestion. Is it possible to get a searcher like hit forker that keeps a log of the hits it finds?  It's hard to grab hits with an update rate less than 10. If so, this would be the best option out there.

Thanks for this suggestion @georgederr, I like this idea but since it'll be a big undertaking, it's not likely to come out until at least the next major version.


Add "isNamespaced" to Meshmodel components(after meshkit change)

Notes for Reviewers
This PR fixes is subsequent to https://github.com/meshery/meshkit/pull/290
Signed commits

[ ] Yes, I signed my commits.

Merge conflicts addressed.

Merge conflicts addressed.

@Revolyssup

@leecalcote Ready to go


Unified Build control update - source-build-reference-packages

This requires a previously SB update, so holding on it.

Completed with https://github.com/dotnet/source-build-reference-packages/pull/908


Savsjö, Sweden

Savsjö municipality, Sweden. This looks like a distant suburb of what you thought was remote. Cannot check the rest responses myself (QGIS cannot display results), but it is sufficiently similar to the previous sources that I think this should be fine.

Looks like an issue with ESRI downloader. Doing it via the web interface to the server works fine.

Curious: I thought all Esri layers had to have an ID column. This is the first one I've seen that doesn't.
This will need some work in machine to support this.

@iandees it's a broken service, it's really an fluke that it's even able to "appear" published as we do always (apparently not) require an ID field. Basic queries at REST do work,  but I'm not sure there's any way to have machine programatically go through 1000 rows at a time if there's no logical offset with id

Is it maybe possible to set the "order by" clause to order by for example "XKOORD, YKOORD"? If not, I can probably do this manually and cache it.

It looks like the FNR column is an ID-like thing that we could de-dupe on. It's just not specified as the Esri ID type so machine doesn't use it.

I tried ordering by FNR and got duplicates. I think FNR is a parcel ID, which I can imagine host multiple addresses, though I did not check


Update pyproject.toml

Added two dependencies with their appropriate version requirements. The package wouldn't work without them from the terminal in Python==3.10.2.
Adding these dependencies with the versions fixed the problem. Several of the required modules from the packages had either been renamed or removed in updates.

Hi there,
Apologies for not getting back to you sooner. I've gone through the dependencies in the pyproject.toml and brought them up to date. Could you please check if this error still persists with the latest package versions? For example i had trouble with jinja2 wrt mkdocs, but updating the mkdocs package version to be up to date solved the issue.
If so then i'll check and add those 2 pinned dependencies in straight away.
Thanks,
Mark


Remove dep support

we were maintaining support for the dep tool, but go mod has been in action for 18 months now, it's probably okay to drop support for this now. we also have and still have support for functions without any vendoring solution, I left a TODO that is a bit curious about this I guess, the use for it would be users that do not want to build with mod on but vendor their packages themselves, this use case is going away soon too as go mod becomes the default and we can change at that time. we also no longer need gopath if we exclusively use mod, which is enticing (inasmuch as it can be) - ie no more /go/src/func directory.
small change to change our test func to use mod
small change to update extension builder helper / remove dep references

bump @denismakogon could you review this one too, please?

can we document this change somehow? the upgrade path might not be clear.
I feel like this PR has to be very gentle with older go functions by showing an upgrade path.

hmm, could document it. where, though? can document here, for reference at least.
after looking, we've only been writing go.mod file for 2 months (defaulting functions to mod). so, probably we should leave support for it for a bit longer. users that need to migrate their funcs from dep to mod will do go mod init which migrates dependencies over from dep to mod, then they can delete the Gopkg.* files. we could facilitate, I'm not keen on automatically migrating on behalf of users, however.
i'll change this pr just to fix up the test func pretty much. originally, thought there was a bug here, but don't think so anymore.

ok @denismakogon i updated to only fix the builder to use mod and the test func to use mod, no compat issues now. thanks for the eyes

hmm, could document it. where, though?

short blogpost would be great, maybe @michael-w-williams can help with a short tutorial.

should we add some sort of a screamer/warning message saying "please use go mode!" ?

@denismakogon @rdallman If you blog about it, let me know and I can convert it into doc. If there isn't and obvious home for it, we will find one.


Implement Cursor-Based Pagination for Recent Circuits Using activerecord_cursor_paginate.

What This PR Does:

Fixes #5195
Replaces OFFSET-based pagination for recent circuits on the home page with cursor-based pagination using the activerecord_cursor_paginate gem.
Removes dependency on will_paginate for recent circuits.
Updates the "Next" and "Previous" pagination links to match the production styling (using Bootstrap’s pagination classes).

Why:

OFFSET-based pagination is inefficient and not performant for large datasets.
Cursor-based pagination provides consistent and reliable pagination that adjusts gracefully to data changes.
Ensures the pagination UI aligns with the existing style guide and user expectations.

Key Changes:

circuitverse_controller.rb:

Uses cursor_paginate(after: ..., before: ...) and fetch to get paginated results.
Sets @projects_page and @projects = @projects_page.records to handle pagination data cleanly.

app/views/circuitverse/index.html.erb:

Removes calls to will_paginate.
Introduces the new pagination links styled with
 and .

Testing Done:

Manually tested by creating multiple circuits locally.
Verified pagination forward and backward using the new cursor parameters.
Ensured no JavaScript errors or layout issues occur.
Checked behavior with no data, small datasets, and larger datasets.

Additional Notes:

No changes made outside the scope of pagination and styling.
This update is intended to improve performance and maintain a consistent UX.

Screenshots (If Applicable):

Summary by CodeRabbit

New Features

Introduced cursor-based pagination for project retrieval, enhancing efficiency.
Updated caching mechanism for recent projects to support new pagination method.

Bug Fixes

Improved navigation links for pagination, ensuring users can easily access previous and next project pages.

Chores

Updated project dependencies by adding activerecord_cursor_paginate gem.
Updated commit reference for the cv-frontend-vue project.

@tachyons please review when you get time, thankyou


Use new semconv artifact

Fixes #1444

Hmmm, it's unhappy about this:
OpenTelemetry Javaagent failed to start
java.lang.NoClassDefFoundError: io/opentelemetry/javaagent/shaded/io/opentelemetry/semconv/ResourceAttributes

Hmmm, it's unhappy about this:
OpenTelemetry Javaagent failed to start
java.lang.NoClassDefFoundError: io/opentelemetry/javaagent/shaded/io/opentelemetry/semconv/ResourceAttributes

Hmm, we might have to wait until the new module is used in the upstream. I'll make this PR a draft for the time being.

It's ready for review now; it should fix https://github.com/signalfx/splunk-otel-java/issues/1444 as well


Mavlink: Fix forwarding of messages with target system/component id

Mavlink does not correctly forward messages that have the target_system or target_component routing fields in the message.
Some investigation revealed that the Mavlink::forward_message function is incorrectly utilizing the mavlink_msg_entry_t.target_system_ofs and mavlink_msg_entry_t.target_component_ofs fields. These offsets are intended to be used relative to the start of the message payload. But, as implemented, these offsets are incorrectly being used relative to the start of the message. This pull-request corrects that problem.
I also correctly made use of the mavlink_msg_entry_t.flags field to determine if a message contains a target_system or target component field. The previous check incorrectly assumed that they would always be non-zero if present.
See here: https://mavlink.io/en/guide/routing.html#c-library-mavgen
Quote:

The MAVLink v2 generator for the C library has been updated to make it easier to get the destination system and component ID from the payload (when these are assigned). Specifically, the mavlink_msg_entry_t structure contains flags to tell you if the message contains target system/component information (FLAG_HAVE_TARGET_SYSTEM, FLAG_HAVE_TARGET_COMPONENT) and offsets into the payload that you can use to get these ids (target_system_ofs and target_system_ofs, respectively). The MAVLink helper method const mavlink_msg_entry_t* mavlink_get_msg_entry(uint32_t msgid) can be used to get this structure from the message id.

Test Configuration
All testing was performed on px4_fmu-v5 hardware. The following system setup was used:
Host PC (Custom Mavlink Utility) <--> PX4 TELEM1 (Mode: Normal, Forwarding: Y)
PX4 TELEM2 (Mode: Onboard, Fowarding: Y) <--> Companion Computer App (Custom Mavlink Utility)
Mavlink status

instance #1:
GCS heartbeat:        321687 us ago
mavlink chan: #1
type: 3DR RADIO
rssi: 200
remote rssi:        172
txbuf:        99
noise:        37
remote noise:        74
rx errors:        0
fixed:        0
flow control: ON
rates:
tx: 1.109 kB/s
txerr: 0.000 kB/s
tx rate mult: 0.399
tx rate max: 1200 B/s
rx: 0.062 kB/s
FTP enabled: YES, TX enabled: YES
mode: Normal
MAVLink version: 2
transport protocol: serial (/dev/ttyS1 @57600)
ping statistics:
last: 297.25 ms
mean: 242.86 ms
max: 345.41 ms
min: 86.83 ms
dropped packets: 0
instance #2:
GCS heartbeat:        378442 us ago
mavlink chan: #2
type: GENERIC LINK OR RADIO
flow control: ON
rates:
tx: 20.233 kB/s
txerr: 0.000 kB/s
tx rate mult: 1.000
tx rate max: 921600 B/s
rx: 0.286 kB/s
FTP enabled: YES, TX enabled: YES
mode: Onboard
MAVLink version: 2
transport protocol: serial (/dev/ttyS2 @921600)

@julianoes What needs to happen to get this merged?
Should I rebase by branch and do a force push to update the pull request? Or is it good enough to use the github "Update branch" button.

@maowen thanks for following up! I had not merged it immediately so others have a chance to review as well. Since no one had objections I can merge that now (and should have a while ago).


Add config setting for memo filepath format

Please allow to configure the memos filename format, and support creation of subdirectories.
For example, create directories for 'year-month/' and filename with 'day-slug.md':
filefmt = "%Y-%m/%d-${SLUG}.md"

💬 Notice the / in format.

Example of current default:
filefmt = "%Y-%m-%d-${SLUG}.md"

I keep my memos in this fashion:
├── 2016-10
│   └── 22-ipsum.md
├── 2016-12
│   ├── 11-foo-bar.md
│   ├── 13-bar-baz.md
│   └── 19-lorem.md
├── 2017-01
│   └── 05-foo.md
└── index.md

Thanks. memo is designed for serving files on http server. And the _posts directory can be used to jekyll. If you put _config.yml on the base directory of _posts, it should work blog entries. So if this directory structure works on jekyll, I will do the improvement.

Hi! I do not use Jekyll. But I keep several notebooks in Markdown format, and I find memo to be great to manage and write easily. In my honest opinion, your tool memo should not be tightly-coupled to Jekyll, as it can serve other use-cases as-well. Thank you for building this!
The default file-format can be what Jekyll expects, but user can customize it using config, that can be nice.

How about using Hugo? So that the app is end to end in Go? @mattn

I don't like Hugo because templates are not user friendly. I can use but I can't say that all of users like it. One of the choice will be jedie. https://github.com/mattn/jedie if I decide to use server in memo. But currently I won't.

I do not know the internal issues with Hugo but I feel that it is faster than Node or Ruby based Static site generators, at least I have found it faster than Hexo. We don't really need to use a server in memo, but maybe a config item for hugo?

It's not real point of this issue. And I'm not talking about which generator is faster.

I know that it isn't about the speed of the underlying static site generator, but  like @rafi I don't use jekyll! So as long as we are adding a config item, having one for an Hugo would be great! :-)


Camera Lags Hard

I tried my best (tick ,run without screen refresh) but the camera ext makes everything besides the player lag so hard that it hurts my eyes
Can someone help me?
https://github.com/TurboWarp/extensions/assets/134739700/882836a2-3867-4ef3-8815-428608ea25d9

Do you have interpolation enabled?

ofc not @LilyMakesThings

got any way?

Bro Camera Controls is a buggy mess :skull:

Likely its not lagging, however it is an issue with Camera Controls. Essentially, the extension cannot set Camera X/Camera Y to a decimal, and so it'll always round up to the nearest integer. This can make the camera quality look really choppy at times. Unfortunately it's not an easy fix, I'd suggest either just accepting the choppiness or making your own camera system.

i made my own camera system it worked! but i hate it since all the sprite collision detection stops working and it is annoying i fixed it adding another sprite but i think that it makes everything hard @NexusKitten

@CubesterYT indeed lol

I see the camera pull back a bit.

I will pass examples.
the method that I showed you does that.
https://github.com/TurboWarp/extensions/assets/134885702/06818c5b-456b-4919-99e2-3088f6a4d54a
code.

To get the camera to do the opposite and then you can use the following.

and that will give this result
https://github.com/TurboWarp/extensions/assets/134885702/2bc18f96-41d0-4242-a9d6-2203ca907340

Regarding the rest I read, the camera controls extension never gives me any problem.
And at least I see and have seen in my experiments that the position of the camera does accept decimals.

@NexusKitten but the cam values show me decimals

I am consolidating all the camera controls issues into https://github.com/TurboWarp/extensions/issues/930


What is the purpose of alias on a node?

Glimpsing on the code, I would assume it serves the purpose of a kind of primary/unique key or ID on a node -- which is what I am looking for desperately! But this does not seem to be the case and according to my research, it's also not something that RG natively would support.

An alias only exists within the context of a query, within it the alias is uniqued at any given scope, aliases are used to reference entities. As you've mentioned aliases aren't committed into the graph, once an entity has been committed it is assigned a unique entity ID which is generated by the database. RG supports aliases natively as they're defined by the query language

Ahh I see. Thank you very much for clarifying @swilly22 .


Scheduler container crash when restarted after account creation

Hi,
We installed Security Monkey on an AWS instance with a RDS instance using the Docker quickstart and the provided compose file.
When adding a new active AWS account through the web UI and restarting the scheduler container, the container crash with the following stack trace :
2017-11-27 09:14:43,963 DEBUG: Scheduler adding account my_account [in /usr/local/lib/python2.7/dist-packages/security_monkey-0.9.3-py2.7.egg/security_monkey/scheduler.py:211]
DEBUG:security_monkey:Scheduler adding account my_account
2017-11-27 09:14:44,036 ERROR: Scheduler Exception: must be type, not None [in /usr/local/lib/python2.7/dist-packages/security_monkey-0.9.3-py2.7.egg/security_monkey/scheduler.py:233]
ERROR:security_monkey:Scheduler Exception: must be type, not None
ERROR:security_monkey:Traceback (most recent call last):
  File "/usr/local/lib/python2.7/dist-packages/security_monkey-0.9.3-py2.7.egg/security_monkey/scheduler.py", line 212, in setup_scheduler
    rep = Reporter(account=account)
  File "/usr/local/lib/python2.7/dist-packages/security_monkey-0.9.3-py2.7.egg/security_monkey/reporter.py", line 38, in __init__
    self.all_monitors = all_monitors(account, debug)
  File "/usr/local/lib/python2.7/dist-packages/security_monkey-0.9.3-py2.7.egg/security_monkey/monitors.py", line 76, in all_monitors
    monitor = Monitor(watcher_class, account, debug)
  File "/usr/local/lib/python2.7/dist-packages/security_monkey-0.9.3-py2.7.egg/security_monkey/monitors.py", line 19, in __init__
    self.watcher = watcher_class(accounts=[account.name], debug=debug)
  File "/usr/local/lib/python2.7/dist-packages/security_monkey-0.9.3-py2.7.egg/security_monkey/watchers/vpc/subnet.py", line 34, in __init__
    super(Subnet, self).__init__(accounts=accounts, debug=debug)
TypeError: must be type, not None

2017-11-27 09:14:44,036 ERROR: Traceback (most recent call last):
  File "/usr/local/lib/python2.7/dist-packages/security_monkey-0.9.3-py2.7.egg/security_monkey/scheduler.py", line 212, in setup_scheduler
    rep = Reporter(account=account)
  File "/usr/local/lib/python2.7/dist-packages/security_monkey-0.9.3-py2.7.egg/security_monkey/reporter.py", line 38, in __init__
    self.all_monitors = all_monitors(account, debug)
  File "/usr/local/lib/python2.7/dist-packages/security_monkey-0.9.3-py2.7.egg/security_monkey/monitors.py", line 76, in all_monitors
    monitor = Monitor(watcher_class, account, debug)
  File "/usr/local/lib/python2.7/dist-packages/security_monkey-0.9.3-py2.7.egg/security_monkey/monitors.py", line 19, in __init__
    self.watcher = watcher_class(accounts=[account.name], debug=debug)
  File "/usr/local/lib/python2.7/dist-packages/security_monkey-0.9.3-py2.7.egg/security_monkey/watchers/vpc/subnet.py", line 34, in __init__
    super(Subnet, self).__init__(accounts=accounts, debug=debug)
TypeError: must be type, not None
 [in /usr/local/lib/python2.7/dist-packages/security_monkey-0.9.3-py2.7.egg/security_monkey/scheduler.py:234]
2017-11-27 09:14:44,036 DEBUG: Logging exception from scheduler with location: None to the database. [in /usr/local/lib/python2.7/dist-packages/security_monkey-0.9.3-py2.7.egg/security_monkey/datastore.py:726]
DEBUG:security_monkey:Logging exception from scheduler with location: None to the database.
2017-11-27 09:14:44,043 DEBUG: Completed logging exception to database. [in /usr/local/lib/python2.7/dist-packages/security_monkey-0.9.3-py2.7.egg/security_monkey/datastore.py:757]
DEBUG:security_monkey:Completed logging exception to database.
INFO:apscheduler.scheduler:Scheduler started
2017-11-27 09:14:44,043 INFO: Scheduler started [in /usr/local/lib/python2.7/dist-packages/APScheduler-2.1.2-py2.7.egg/apscheduler/scheduler.py:574]
2017-11-27 09:14:44,043 INFO: Scheduler has been shut down [in /usr/local/lib/python2.7/dist-packages/APScheduler-2.1.2-py2.7.egg/apscheduler/scheduler.py:606]
INFO:root:Shutting down thread pool
INFO:apscheduler.scheduler:Scheduler has been shut down

This behavior happens every time we set an active account.
Do you have a clue of what could be wrong ?
Thanks

Likely the same issue as https://github.com/Netflix/security_monkey/issues/862#issuecomment-343965895, just being observed with the watchers modules here (subnet has an OpenStack watcher defined).
I will rename all the OpenStack watchers to unique and submit a PR.

Just merged in #886 .  Can you check if that resolved your issue @Mallear ?

I've just rebuild the container and test again: everything works well !
Thanks for your quick reply.


Huggingface Demo

Hello @haha-lisa
Thanks for your work. Your huggingface demo is not working, please have a look on it

Hi, our huggingface demo was developed for free with the help of others, and it seems to be a common problem.
------------------ 原始邮件 ------------------
发件人:                                                                                "haha-lisa/RDM-Region-Aware-Diffusion-Model"                                                                                @.>;
发送时间: 2024年1月3日(星期三) 上午8:44
@.>;
<EMAIL_ADDRESS>主题: [haha-lisa/RDM-Region-Aware-Diffusion-Model] Huggingface Demo (Issue #6)
Hello @haha-lisa
Thanks for your work. Your huggingface demo is not working, please have a look on it
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you were mentioned.Message ID: @.***>


MapperService has to be passed in as null for EnginePlugins CodecService constructor

Signed-off-by: Andriy Redko<EMAIL_ADDRESS>Description
Introduces CodecServiceFactory and extends the EnginePlugin with new method (the existing getCustomCodecService is marked as @Deprecated).
    default Optional<CodecServiceFactory> getCustomCodecServiceFactory() {
        return Optional.empty();
    }

The factory accepts CodecServiceConfig instance which provides more context to the CodecService creators, including MapperService is available for the particular index.
Issues Resolved
Closes https://github.com/opensearch-project/OpenSearch/issues/1805
Check List

[X] New functionality includes testing.

[X] All tests pass

[X] New functionality has been documented.

[X] New functionality has javadoc added

[X] Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@jmazanec15 Can you take a look at this and confirm it will solve the problem you described in #1805?

@andrross Apologies, just saw this tag. Will take a look this week.

@jmazanec15 you're good with this?

If @jmazanec15 is good with this change we can merge.

Looks good @dblock


MSID: 88064 Version: 2 DOI: 2<IP_ADDRESS>3542

[PLACE MANUSCRIPT AND EDITOR DETAILS HERE WHEN AVAILABLE] See step 3
[PLACE PDF URL HERE WHEN AVAILABLE] See step 7
Step 1. Inform bioRxiv
Who can help: @QueenKraken, @nlisgo, @scottaubrey

[x] Manuscript is in data hub index (https://data-hub-api.elifesciences.org/enhanced-preprints/docmaps/v2/by-publisher/elife/get-by-manuscript-id?manuscript_id=88064)

Step 2. Create preview of manuscript
Who can help: @fred-atherden, @nlisgo, @scottaubrey

[ ] Manuscript is available for preview (https://prod--epp.elifesciences.org/preview/88064/v2)

[ ] Trigger import for staging: https://prod--epp.elifesciences.org/import
[ ] Sync data folder with s3://prod-elife-epp-data/data
[ ] Trigger import for staging: https://staging--epp.elifesciences.org/import
[ ] Sync data folder with s3://staging-elife-epp-data/data
[ ] Pull request created to enhanced-preprint-data
[ ] Post link to pull request below

Pull request: [PLACE LINK TO PULL REQUEST HERE]
Detailed instructions: https://github.com/elifesciences/enhanced-preprints-data#add-a-manuscript
Step 3: Awaiting public reviews and QC
Who can help: Production team

[ ] QC passed or QC not needed

Who can help: Editorial team

[x] Public reviews available on sciety (https://sciety.org/articles/activity/10.1101/2<IP_ADDRESS>3542)
[ ] Manuscript and editor details at the top of this issue (Supplied by Editorial team)
[x] Reviews returned by EPP - https://prod--epp.elifesciences.org/api/reviewed-preprints/88064/v2/reviews

Example
"msas": "Genetics and Genomics", "Neuroscience"
"msid": "84628"
"version": "1"
"preprintDoi": "10.1101/2<IP_ADDRESS>4241"
"articleType": "Reviewed Preprint"
"status": "Published from the original preprint after peer review and assessment by eLife."

"Reviewed Preprint posted": "2023-01-02"
"Sent for peer review": "2022-10-28"
"Posted to bioRxiv": "2022-11-21" (link: "Go to bioRxiv": "https://www.biorxiv.org/content/10.1101/2<IP_ADDRESS>4241v1")

Editors:
Reviewing Editor
Michael B Eisen
University of California, Berkeley, United States
Senior Editor
Michael B Eisen
University of California, Berkeley, United States

Step 4: Modify manuscripts.json (no PDF)

[ ] Reviewed preprint is published to EPP (https://elifesciences.org/reviewed-preprints/88064)

[ ] Pull request created to enhanced-preprint-client
[ ] Pull request switched to "Ready for review"
[ ] Post link to pull request below

[ ] Request that a doi be registered

[ ] Post link to #enhanced-preprint comment below

Pull request: [PLACE LINK TO PULL REQUEST HERE]
#enhanced-preprint comment thread: [PLACE LINK TO COMMENT HERE]

Instructions to modify manuscripts.json

Visit: https://github.com/elifesciences/enhanced-preprints-client/actions/workflows/publish-manuscript.yaml
Click: Run workflow
Complete the form and click "Run workflow"
A successful run should result in a new pull request at https://github.com/elifesciences/enhanced-preprints-client/pulls
Open the pull request and click the "Ready for review" button to trigger tests
Once the tests pass and you are happy with the changes the PR can be merged

Example pull request: https://github.com/elifesciences/enhanced-preprints-client/pull/334/files
Once the pull request is merged in it should be available a few minutes later.

Request that a doi
Post the following in #enhanced-preprint:
@Fred can you register a doi for https://elifesciences.org/reviewed-preprints/88064

Step 5: Awaiting search reindex

[ ] Reviewed preprint is avaliable on journal homepage (https://elifesciences.org)

The search reindex is triggered once an hour. We need the reviewed preprint to be indexed as the search application serves the journal homepage.

Additional info
If needed, the jenkins pipeline to reindex search can be triggered sooner.
https://alfred.elifesciences.org/job/process/job/process-reindex-reviewed-preprints/

Step 6: Published! Request PDF generation

[ ] Post the link to the PDF url at the top of the issue

[ ] Post link to #enhanced-preprint comment below

#enhanced-preprint comment thread: [PLACE LINK TO COMMENT HERE]
Post the following to the #enhanced-preprint on slack:
@Ryan Dix-Peek please can you generate a PDF for https://elifesciences.org/reviewed-preprints/88064

Step 7: Introduce PDF to data folder and git repo

[ ] PDF is avaliable at https://github.com/elifesciences/enhanced-preprints-data/raw/master/data/88064/v2/88064-v2.pdf

Detailed instructions: https://github.com/elifesciences/enhanced-preprints-data#add-a-pdf
Step 8: Add PDF url to manuscripts.json

[ ] Reviewed preprint PDF is available for download (https://prod--epp.elifesciences.org/reviewed-preprints/88064)

[ ] Pull request created to enhanced-preprint-client
[ ] Pull request switched to "Ready for review"
[ ] Post link to pull request below

[PLACE LINK TO PULL REQUEST HERE]

Instructions to add PDF url to manuscripts.json

Visit: https://github.com/elifesciences/enhanced-preprints-client/actions/workflows/add-pdf-url-to-manuscript.yaml
Click: Run workflow
Complete the form and click "Run workflow"
A successful run should result in a new pull request at https://github.com/elifesciences/enhanced-preprints-client/pulls
Open the pull request and click the "Ready for review" button to trigger tests
Once the tests pass and you are happy with the changes the PR can be merged

Example pull request: https://github.com/elifesciences/enhanced-preprints-client/pull/397/files
Once the pull request is merged in it should be available a few minutes later.

Step 9: Done!

[ ] Kettle is on!

I think we need to load v3 of this - there are typos in the affiliation (which match v2)

Nicely spotted @naushinthomson.
@acollings I think the hypothesis comments are on version 2 - please could you move them over to the v3?

V3 is now loaded, so this is ready to check.

@fred-atherden done!


Is it able to save and print?

Is it able to save and print?

In what format do you want to save to? Excel? text?

Excel

Hi @psxbox as you said you could use another library to save to excel. For printing, yes you could use the web browser to print. if you do I'd recommend setting Virtualise="false" on the datasheet component.


Use hermes from source + 0.69

Combined PR of :

https://github.com/mrousavy/react-native-vision-camera/pull/1116
https://github.com/mrousavy/react-native-vision-camera/pull/1168
https://github.com/software-mansion/react-native-reanimated/pull/3417

Test on 0.66 JSC/Hermes AND 0.69 JSC/Hermes/Monorepo

Thanks so much for your help on this @Titozzz and @tomekzaw ❤🙏
LGTM! 🚀


WIP: Update: added zip next steps

@edewit let me know what you think

resolves #419

LGTM

merged: b0591fe051d4c01fc801b57e1a88ff7fdcff86a8


Use explicit dependency versions

Is it a good idea in Java? I would probably not do that if the packages that we use follow semver, but if they don't I guess it's fine. For example, I wouldn't like my dependencies to bring two different versions of the same library because they are locked to a specific version.

Using concrete versions is a common approach. This notation also uses a specific one, but just pulling the latest. Changing this to avoid uncleanness.
Build tools won't pull 2 versions, they have strategies to choose one from the provided set.

Oh, I see, didn't know it works like this by default. I think it's ok to leave it as-is then if it's a common thing. :)


set git-conflict.nvim version = "*"

As recommended by the repo's README https://github.com/akinsho/git-conflict.nvim

Thanks!