Issue with Private Key processing on Azure ARM Provisioned VMSS VM's

Issue with Private Key on Azure VMSS VM's with certificate private keys provisioned by Azure KeyVault.
This is NOT a fault with IndentityServer4.
This is a significant operational issue using IdentityServer4 under Azure and Service Fabric.
Even though our provided workaround is a one-time per VM it is unsatisfactory, as scaling out additional VM's requires manual intervention.
We are contacting Microsoft on this issue but are posting here for three reasons;

Alert the community to record the issue details and workaround
Raise awareness with the IdentityServer team
Elicit any alternative workarounds from anyone

If we get a solution from Microsoft we will update this post.
Context
We have an Azure VMSS VM auto provisioned via ARM scripting / PowerShell for several Microservices running under Service Fabric on a secured cluster.
A vital service in the product is IdentitySever4 securing access to a pubic WebAPI scope, which otherwise works correctly, and all services are publicly secured using the company domain wildcard certificate;
We have three discrete environments;

WORKING: Local development (Workstation) cluster secured using self signed IISExpress generated localhost certificate
FAILED: Cloud Test cluster secured using domain wildcard certificate
PENDING: Cloud production cluster secured using domain wildcard certificate

Our SDK client logs the user in via the IdentityModel.OidcClient for a client configured to request Access tokens for our WebAPI.
Problem
On publishing to Cloud Test cluster and running test client it fails.
The failing workflow is; Client -> IDSRV -> Federated Identity -> Consent Screen -> JWT Token Creation -> Fatal
The Log showed the error;
2017-06-27 11:55:05.532 +00:00 [Verbose] Creating JWT identity token
2017-06-27 11:55:05.550 +00:00 [Fatal] Unhandled exception: "System.Security.Cryptography.CryptographicException: Keyset does not exist

   at System.Security.Cryptography.Utils.CreateProvHandle(CspParameters parameters, Boolean randomKeyContainer)
   at System.Security.Cryptography.Utils.GetKeyPairHelper(CspAlgorithmType keyType, CspParameters parameters, Boolean randomKeyContainer, Int32 dwKeySize, SafeProvHandle& safeProvHandle, SafeKeyHandle& safeKeyHandle)
   at System.Security.Cryptography.RSACryptoServiceProvider.GetKeyPair()
   at System.Security.Cryptography.RSACryptoServiceProvider..ctor(Int32 dwKeySize, CspParameters parameters, Boolean useDefaultKeySize)
   at System.Security.Cryptography.X509Certificates.X509Certificate2.get_PrivateKey()
   at Microsoft.IdentityModel.Tokens.X509SecurityKey.get_PrivateKey()
   at Microsoft.IdentityModel.Tokens.X509SecurityKey.get_HasPrivateKey()
   at Microsoft.IdentityModel.Tokens.AsymmetricSignatureProvider..ctor(SecurityKey key, String algorithm, Boolean willCreateSignatures)
   at Microsoft.IdentityModel.Tokens.CryptoProviderFactory.CreateSignatureProvider(SecurityKey key, String algorithm, Boolean willCreateSignatures)
   at System.IdentityModel.Tokens.Jwt.JwtSecurityTokenHandler.CreateEncodedSignature(String input, SigningCredentials signingCredentials)
   at System.IdentityModel.Tokens.Jwt.JwtSecurityTokenHandler.WriteToken(SecurityToken token)
   at IdentityServer4.Services.DefaultTokenCreationService.CreateJwtAsync(JwtSecurityToken jwt)
   at IdentityServer4.Services.DefaultTokenCreationService.<CreateTokenAsync>d__3.MoveNext()
... more removed for brevity

This is the method in the DefaultTokenCreationService
	/// <summary>
	///     Applies the signature to the JWT
	/// </summary>
	/// <param name="jwt">The JWT object.</param>
	/// <returns>The signed JWT</returns>
	protected virtual Task<string> CreateJwtAsync(JwtSecurityToken jwt)
	{
		var handler = new JwtSecurityTokenHandler();
		return Task.FromResult(handler.WriteToken(jwt));
	}

Investigation
Googling the exception suggested this was a permissions issue accessing the declared private key as specified in the Startup.cs of the service;
	identityServerBuilder.AddSigningCredential(_appSettings.Certificates.Thumbprint, StoreLocation.LocalMachine, NameType.Thumbprint);
The Thumbprint is configured to be that of the company wildcard domain certificate that is (Correctly) auto provisioned via Azure Key Vault.
The certificate works/worked fine with the web services in all other ways on all clients.
As the workaround fixed the issue and there were no log entries suggesting key configuration we can assume it was not an issue with configuring the private key via startup.
In other words IdentityServer found the private key but as you will see it just was not allowed to use it.
Cause
The provisioned certificate private key is not readable by the run time account of the IdentityServer service fabric Microservice.
The Microservice is by default running as "NT AUTHORITY\NETWORK SERVICE" and this has no permissions for the private key.
We are still establishing why it worked in local dev and not in the cloud.
Workaround
Grant Read permissions for Service Fabric run time account "NETWORK SERVICE" for the private key.
In order to do this you MUST first change the Ownership of the private key to an administrator account.
Remote onto the affected Azure VM instances (ones which run the IdentityServer4 service)
Find these using the Azure portal or PowerShell
As Administator account
Run the MMC then add the Certificates Snap-in for the LocalMachine
Locate the Personal store and select the certificate in question
Action -> All Tasks -> Manage Private Keys
Advanced -> Owner System - > Change
Change to Current Administrator Account -> OK
Add "NETWORK SERVICE" with Read Permission -> OK
Advanced -> Owner [Admin Account] - > Change
Change to System  -> OK
Done.

This worked and the system now operates as desired.

Just so I'm clear: The cert is in the windows certificate store on the local machine?

Sorry for the confusion, and please forgive me if this is not the best place to raise awareness of this.
The self signed cert  in question (localhost) is in the  My store of the LocalMachine on my workstation and works fine.
The commercially provided real certificate is in the My store of the LocalMachine  on the VM.
The environment settings switches correctly to look for (and find) the the required cert on both environments via the environment settings when publishing of the SF application and the service finds it ok on startup.
Basically IDSRV is told to look in the correct place for the correct certificate but the permissions associated with the Azure provisioning of that certificate to the VM make it unavailable for IDSRV to use it to sign JWT tokens.
However the certificate is available to sign the browser sessions on that VM.
When the permissions are corrected as per my OP on the VM, IDSRV works like a dream.
I have located an SF based potential workaround for this but it will take me a while to test it.
Its the 2nd answer to this SO post here. This answer seems to be a (useful) hack to automate what I did manually via the SF application configuration XML files, a batch file and a PowerShell script to force the SYSTEM account to do the job on publication to the VM.

The self signed cert in question (localhost) is in the My store of the LocalMachine on my workstation and works fine.
The commercially provided real certificate is in the My store of the LocalMachine on the VM.

I'm still a bit confused, so apologies. If the cert is in the windows certificate store, then yes, you always need to configure the worker process identity to access the private key. As for all the AWS stuff, I don't know any of that so perhaps that ignorance is clouding my ability to help here.

However the certificate is available to sign the browser sessions on that VM.

Does this mean you're using the HTTPS cert also for signing tokens? If so, don't do that. Use a separate cert for tokens (and it doesn't have to be from a CA -- use just a self-signed cert).

First of your points. As I have 'solved' the issue I just really wanted to log this somewhere that people coming along behind in this scenario have a chance of finding a solution quickly. To be sure, this is definitely a Windows/Service Fabric environmental problem. Rest assured I don't really need you to guys to work on this, just intending to make others aware its a headache for folks using IDRSV on Service Fabric. At the moment there just is not enough info out there on the net on this particular edge case problem.
The thing that caught me out was that the two environments behave differently wrt to private key permissions in windows and is a bit of a gotcha.  I wanted to make it obvious and public that its not an IDSRV issue even though it shows up when you place IDSRV in that environment.
Point two: I wondered about that (self signed cert for token signing) I can do that easily as I'm already doing that for intra-node security on the cluster anyway. I will just generate another one just for token signing
Thanks for the advice.

No problem -- opening an issue is about the best way we have now for raising concerns like this.

ACL for private key read on NETWORK SERVICE account should be done automatically when using VMSS ARM template to provision cert.
Although saying that, it is pretty flaky some times. Open an issue here https://github.com/Azure/service-fabric-issues/issues

Any update on the issue? closing for now - feel free to re-open if it needs further discussion.

Yep close it off, not a bug with IDSRV.
Here its on the work schedule. We will update when we have a concrete and working solution. Current work revolves around dynamically pulling the certificate out of KeyVault at service startup and injecting it into the .net services collection to avoid relying on Azure hosting to deliver certificate to m/c.


⚠ Bofrost.de has degraded performance

In e1acec3, Bofrost.de (https://www.bofrost.de) experienced degraded performance:

HTTP code: 200
Response time: 1109 ms

Resolved: Bofrost.de performance has improved in 16f3713 after 6 minutes.


websocket.recv() creating problem

Hi,
I am using websockets for receiving messages from a client which also uses websockets. My server which is hosting the connection is waiting for the message using websocket.recv(), this is the first anticipated message in my use case, for eg; "Start" .
After doing some operations below the receive command, I have put another websocket.recv() down there which waits for another message and then I do some other set of operations below it after receiving that command, for eg: "Stop".
What happens is, after receiving the 1st message that the client sends, the control of the program waits on the second recv() command as if its waiting for any message again, which is understandable since the command is blocking. but what's not understandable is the moment 2nd message is sent by the client there, the program control here goes to the 1st line of the function, and eventually the message is received by top most recv() command. which received the 1st message. I don't understand why the control has to go back all the way to the first line ditching the second recv() command on which it was waiting. I eventually get my message 2nd time as well but not from where I had expected it(2nd recv() command) and program comes down executing all the above statements again.
Isn't there a way I can receive my messages where ever I want in my code ? or there something I am missing ? I am putting down a snippet of code, Requesting to look into the concern.
async def foo(websocket, path):
// this is the 1st of the function foo
    message_1 = await websocket.recv()  # this is 1st recv() command
    // do something with the message

    message_2 = await websocket.recv()  # this is 2nd recv() command
    // do something with the message

websocket_server = websockets.serve(foo, host, port)
asyncio.get_event_loop().run_until_complete(websocket_server)
asyncio.get_event_loop().run_forever()

Thank You!

Indeed this is very unexpected. With the information you provided, I'm not able to reproduce.
Could you provide a minimal reproduction of this problem = a complete client script and a complete server script?

Closing because I don't have enough information to reproduce. There's a high chance you got your logic wrong.


KeyError When running python eval.py.

Traceback (most recent call last):
File "eval.py", line 427, in
net = build_ssd('test', 300, num_classes)            # initialize SSD
File "/home/ls/liushuai/code/ssd.pytorch-master/ssd.py", line 209, in build_ssd
return SSD(phase, size, base_, extras_, head_, num_classes)
File "/home/ls/liushuai/code/ssd.pytorch-master/ssd.py", line 33, in init
self.priorbox = PriorBox(self.cfg)
File "/home/ls/liushuai/code/ssd.pytorch-master/layers/functions/prior_box.py", line 15, in init
self.num_priors = len(cfg['aspect_ratios'])
KeyError: 'aspect_ratios'

It has been solved.

hello，when i run the eval.py, it like this
do you know how to solve it?


microbial annotation (start of)

many gaps in here, just getting start of it up so I can see if I am on the right track. no images/zenodo/docker yet.

Thats a great start!!! Can you please name this file .md at the end?

@AnnaSyme should me merge this as a good start or do you let us know when we should review this.

@bgruening I think I will add more to it first, thanks. I'll close this pull request and send a new one when I've added more.

You can leave it open, but let's label it as WIP (Work in progress) :)


darwin.stdenv: clean up portable libsystem hook

Description of changes
I noticed this while building #242316. The hook fails to find install_name_tool when sandboxing is enabled. I also cleaned up an install_name_tool failure due to trying to run it on $out/bin itself.
Things done

Built on platform(s)

[ ] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[x] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[x] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[x] Tested basic functionality of all binary files (usually in ./result/bin/)
23.11 Release Notes (or backporting 23.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[x] Fits CONTRIBUTING.md.

Result of nixpkgs-review pr 242399 run on aarch64-darwin 1

2 packages built:

nixStatic
nixStatic.dev


Fix NuGet package verification error

cc @anurse  \ @halter73

Looks good to me. But what I know ...

@davidfowl Should we just delete this now? a) We have source control and b) we have a slightly different plan for WebSockets near-term now.


[Feature] Add option to add deploy history to widget

Especially for use cases with only one site (which should be the majority?) there is a lot of free space to put to good use:

It would be wonderful to be able to:

see the history of past deploys
see what triggered those deploys
see how long the deploys took
..

Anymore ideas? :slightly_smiling_face:

https://github.com/robinpyon/sanity-plugin-dashboard-widget-vercel 🤤

We gotta get @robinpyon to start using Netlify :slightly_smiling_face:

The following plugin has a deeper integration with Netlify, using the Netlify API with a registered oauth application: https://github.com/dorelljames/sanity-plugin-netlify-deploy-status-badge
But in my case, I work for a web agency making websites for many clients, which do not have access to our Netlify account. But the only way to get access to the deploy logs (if they are set to private) is to login into Netlify within the Studio (oauth), which our clients cannot do (I could login for them, but then I don't know how long the login is valid). It's also a pain to register an oauth application for every website. And the whole thing is probably not very wise in terms of security.
That is why I came to the conclusion that the authentication required to access the deploys endpoint is an overkill compared to what is provided for my content editors.
The best would be for Netlify to allow for users to generate auth token scoped to websites and specific endpoints (like for the build token).
sanity-plugin-netlify-deploy-status-badge (and probably sanity-plugin-dashboard-widget-vercel) only make sense if the owner of the Sanity account and of the Netlify account is the same organisation.
@dorelljames sorry to ping you, but do you share the same opinion (especially about the last part)?

@mornir personally, I held back implementing using Personal Tokens which would solve everyone's problem especially in your case where your clients don't have access to your Netlify account. The primary reason why is that the generated token means overall access, and when I say overall, I mean everything, like e-v-e-r-y-t-h-i-n-g. In so many ways it could go so wrong. I'm not even 100% sure that the OAuth route is secure enough but at least upon careful consideration, I thought we could just go with it.
Anyhows, I sort of kinda agree that it's probably best if we could generate a token with scopes, much more like how we can create one in GitHub. But that's probably something that would require much time to develop and I don't think it's within Netlify's interest as of yet.
PS: This plugin never asked for any tokens or Oauth or anything that has to deal with authorization, and it is designed as it should be. Beyond the features that are implemented already, it's not possible yet.

I suppose that creating a thread in Netlify's community forum linking to this issue would be a good first step to get eyes on this use case and maybe even get it on the agenda at some point. Or there might come up a worthwhile workaround that allows for more details.
I will go ahead and create that thread. As soon as I have done so, I will link it here.
Thank you @dorelljames and @mornir for pointing out the security implications.

It seems that there is already a feature request that would fit that bill:
https://answers.netlify.com/t/restrict-auth-tokens-to-certain-actions-create-deploy/24098
Please add your support, if you consider the feature important.


undefined is not a function (evaluating 'React.createClass')

Hello,
Im trying to run my app and seemingly without reason it started to throw this error"
08-15 02:27:24.340 18745 18806 E ReactNativeJS: undefined is not a function (evaluating 'React.createClass')
in LightboxOverlay.js
I did update PropTypes to be used from prop-types library since it doesn't seem to work with React.PropTypes anymore (this problem did show up in other node_modules, but prop-types lib seems to have fixed it) but other than that everything is how it supposed to be.
EDIT: Rewriting classes in ES6 seemed to have done the trick

Fixed in 0.7.0


Code analyze dies on Redis connection

Larastan Version: 1.0.2
--level used: 0-5

Description
I have Laravel v8 and PHP 8 with predis. For some reason, code analyzes dies on every Redis connection call.
It just hangs for a while and then dies with the message: Killed
I tried to change facades on stub like here: https://github.com/nunomaduro/larastan/issues/907#issuecomment-895062233 but no changes. It "feels" like it tries actually connect and timeout, but there is no error and even if it does, I don't understand why it would try to do the actual connection. Any help if this is a possible bug in Larastan? Or what to check?
My config looks like this:
includes:
    - ./vendor/nunomaduro/larastan/extension.neon

parameters:

    paths:
        - app

    # The level 9 is the highest level
    level: 0

    ignoreErrors:
        - '#Unsafe usage of new static#'

    checkMissingIterableValueType: false

    parallel:
        maximumNumberOfProcesses: 1

And output:
root@f935f6c02e56:/laravel# ./vendor/bin/phpstan analyse  --debug --verbose
Note: Using configuration file /laravel/phpstan.neon.dist.
PHPStan crashed in the previous run probably because of excessive memory consumption.
It consumed around 57 MB of memory.

To avoid this issue, allow to use more memory with the --memory-limit option.
/laravel/app/Console/Commands/RedisTestJob.php
Killed

Laravel code where the issue was found
Redis::connection(); // or any other function, eg. Redis::get

Hello Sampsa! 👋
I think you are looking for #1064 Please let me know!

Hello Sampsa! 👋
I think you are looking for #1064 Please let me know!

Thanks, but doesn't look like the same issue.
I don't get any error, I just assumed it might be due to the Redis connection. And I run analyzer in the docker env where it has access to the Redis DB with correct env settings. Also, this code is not in the service provider, it is inside command tho the same issue if I try to analyze eg. controller code. It works, it removes the Redis connection. MySQL DB connection-related code works just fine.
Issue is with simple code like this:

<?php

namespace App\Console\Commands;

use Illuminate\Console\Command;
use Redis;

class TestCommand extends Command
{
    /**
     * The name and signature of the console command.
     *
     * @var string
     */
    protected $signature = 'test';

    /**
     * The console command description.
     *
     * @var string
     */
    protected $description = 'Test command';

    /**
     * Create a new command instance.
     */
    public function __construct()
    {
        parent::__construct();
    }

    public function handle()
    {
       Redis::connection(); // larastan/phpstan dies silently here, works if removed
    }
}

I'm sorry. All I can offer is that very dirty solution in #1064
if (! defined('__PHPSTAN_RUNNING__')) {
    Redis::connection();
}

I'm sorry. All I can offer is that very dirty solution in #1064
if (! defined('__PHPSTAN_RUNNING__')) {
    Redis::connection();
}

Unfortunately, that is not possible in this case. We have an old code base with a lot of code like $redis = Redis::connection() I cannot refactor everything for phpstan.

I only have bad ideas :)
Remove Redis PHP extension and a noop class.

class Redis
{
    public function __call(string $name, array $arguments)
    {
    }
}

I tried that, but no luck. Anyways, it seems to be related to alias.
I have this in my config.app
    'aliases' => [
        'Redis' => Illuminate\Support\Facades\Redis::class,
        ...
    ]

If I remove the alias from the config and point directly to the correct file in the code use Illuminate\Support\Facades\Redis instead of use Redis; it seems to work. Wondering if this is a common behavior and I cannot use an alias? Is my only option to stop using an alias and start using the full namespace path for Redis? Note that using a full path is not enough, also the alias needs to be removed.

If I remove the alias from the config and point directly to the correct file in the code use Illuminate\Support\Facades\Redis instead of use Redis; it seems to work. Wondering if this is a common behavior and I cannot use an alias?

Oh yes! It is not advised to write abbreviations and shortcuts: make your code disastrous.


Segfault when serializing and deserializing a SSETLBitMask

I found an issue on a machine which supports SSE2 instructions but not AVX and some issue with the serializer. Both  template inline void Deserializer::deserialize(T &element) and     template inline void Serializer::serialize(const T &element) segfault when trying to call SSETLBitMask<1024u>::operator=().  I'm assuming that an alignment issue is occuring when an array of char* is cast as an SSETLBitMask<1024u>*, which is causing the operator=() to fail.
I have performed a hack-ish fix by changing  ((T)(buffer+index)) = element; to    memcpy(buffer+index,&element,sizeof(T)); and vice-versa for the deserialize.

That change will break other things.  The code should never be invoking the general forms of serialize and deserialize for any of the bit mask types.  Notice the explicit specializations of the serialize and deserialize methods in legion_utilities.h.  Check to make sure that your compiler is picking them up.  Another thing to check is that your compiler is providing the SSE2 macro which protects the explicit specializations.  If it's not then we need to understand why (I'm guessing you're not using a very old processor that doesn't have SSE2 instructions).

Yeah I figured that the change would break other things, but it seemed to work for short term. I see a specialization of serialize and deserialize for SSEBitMask through a typedef of: "typedef SSEBitMask<MAX_FIELDS> FieldMask;", but there is no specialization for the two level bit mask, SSETLBitMask<size_t>. Yes the compiler is setting the SSE2 macro. It would appear that the appropriate fix would to be a specialization of serialize and deserialize for NodeMask, which is based on the two-level bit mask.

I'm not sure I know what you mean by a typedef.  Look at this template specialization:
https://github.com/StanfordLegion/legion/blob/master/runtime/legion_utilities.h#L1187
The compiler should be invoking that function whenever it needs to serialize a SSETLBitMask.

Also, where do you see NodeMask still be used.  I realize the typedefs are still there, but everything should have been switched over to NodeSets now (with the minor exception of one case in the low-level runtime which doesn't get serialized or deserialized anyway).

Ahh, my version of legion_utilities.h must be out of date, as that file
looks very different from the version I've got. The typedefs I am referring
to are found in legion_types.h, lines 386 - 449, where FieldMask and
NodeMask are set based on the instruction set. The version of
legion_utilities.h that I have has Serializer::serialize, and
Deserializer::deserialize specialized on FieldMask, but not NodeMask, and
does not include instruction-set-macro based specializations.
On Thu, May 14, 2015 at 12:45 PM, Mike Bauer<EMAIL_ADDRESS>wrote:

I'm not sure I know what you mean by a typedef. Look at this template
specialization:
https://github.com/StanfordLegion/legion/blob/master/runtime/legion_utilities.h#L1187
The compiler should be invoking that function whenever it needs to
serialize a SSETLBitMask.
—
Reply to this email directly or view it on GitHub
https://github.com/StanfordLegion/legion/issues/9#issuecomment-102132563
.

Ah, that makes sense.  I was pretty sure I fixed those issues a long time ago.

Ok, my bad.
On Thu, May 14, 2015 at 12:52 PM, Mike Bauer<EMAIL_ADDRESS>wrote:

Ah, that makes sense. I was pretty sure I fixed those issues a long time
ago.
—
Reply to this email directly or view it on GitHub
https://github.com/StanfordLegion/legion/issues/9#issuecomment-102133992
.


Add /foxpic command using RandomFox

Command Name
/foxpic
Public API Resource
https://randomfox.ca
Description
This command will respond with a random picture of a fox.
Implementation Details
No response
Code of Conduct

[x] I agree to follow this project's Code of Conduct

I am working on this .
Assign it to me

May I work on this?

Hey @MaestroDagan, thank you for opening this issue :)
I updated the Contribution Guidelines to only allow one pr/issue per person.
Since you already contributed in #21, I'm not going to assign this issue to you.
@satyamrs00 I'll assign you to this issue, but for the future, please wait until you get assigend, before raising a pr :)

I have already created a pr #51 for this

@satyamrs00 I reviewed your pr #51, approved and labeled it with the hacktoberfest-accepted label.
Great contribution ❤


[FEATURE] Register-PnPAzureADApp Permissions scope expansion

Hi Team,
Im looking at writing a sample for creating the equivalent app for PnP Management Shell, and noticed that the existing cmdlet doesn't cover all the permissions scope of the existing app for example:

Dataverse
PowerApps
Power BI
Windows Azure Active Directory
Windows Azure Service Management API.

I might temporarily look to cover this with the Azure CLI/SDK, or if I can specify the permissions manually via a additional cmdlets if possible.
Just thought id let you know.

I've got this published so far, https://www.toddklindt.com/blog/Lists/Posts/Post.aspx?ID=904 I'm not sure if you've already covered all of that yet or not. I'm working on the scopes and the UI bit next.

@ToddKlindt you are ahead of me, I'll read to ensure that I'm not duplicating effort. I was going to write a script sample and started a command with all the scopes that are used under delegated. With perhaps some variations for Azure SDK, graph etc so folks can prep in a few ways.
Also I found in the PnP PowerShell repo some json files with all the scopes and descriptions that I was thinking of explaining what each are.
Happy to slow down and let you run with this since you have a lot of info already maybe or I can pinch/credit for a script sample from your post. lol. What would you like to do?
I think def working together on this given the short time frame to get helpful resources available would be good.

I'm in the same boat as you. I have the list of Scopes needed, but Register-PnPAzureADApp won't let me register them all, so I'm having to do a handful by hand.
You're welcome to take whatever you want from my blog post and make a sample out of it. If there's a way to give me credit, please do. Gotta keep that next MVP renewal in mind. :) If there's not, it's no big deal. Like you said, we have a short time frame to get this out there, so the more places the better.

To the team,
Here is a list of the Scopes that I can't add with Register-PnPAzureADApp that are added by the existing Enterprise App:
"AllSites.FullControl",
"AppCatalog.ReadWrite.All"
"Directory.AccessAsUser.All",
"Tasks.ReadWrite",
"ChannelMessage.Send",
"TeamsAppInstallation.ReadWriteForUser",
"ServiceHealth.Read",
"ActivityFeed.Read",
"Directory.AccessAsUser.All",
"user_impersonation"
Pretty please with sugar on top add them to the validation sets. :) Or, just spitballing here, add a switch that does all the old Enterprise App scopes in one fell swoop.
Thanks

Isn't the whole point of the deprecation of the default Enterprise App that each permission will be added only as needed ?
I know it's all just delegated permissions, but still, if you recreate an exact copy of the current Enterprise App, then it's sort of missing the point.
I can imagine even having multiple app registrations with different granted permissions, different settings and different targeted users ("Assignment required" set to True limits who can use the app).
This is sort of the same process someone setting up an app registration with certificate or managed identity would have to go through: check which commands you will use, check which scopes are needed, pick the lowest possible ones.

Hi @jackpoz, of course, really good to call this out, from a security point of view following the principal of least privilege, your own registration would give you control and decision over the permissions you require or permitted to use by your organization policies.
In Entra, there are more permissions you could add, beyond what is needed by the cmdlets, once approach is to suggest a script to add them all (based on the original app), describe what they are and remove as needed e.g. if you don't need Teams Chat, just SharePoint. From a decisioning point of view its easier.
Multiple approaches here to help with the transition for a variety of audiences e.g. Dev/Prod, Skills, Knowledge, Security. So blogs, articles, examples are needed to be as supportive as possible, of course better practices on how these should be used is another great topic.
I believe there is an exercise on the cmdlets happening to map what minimum permissions are needed for each cmdlet which may take time.

Adding User.ReadBasic.All as another permission that can't be added.

It would be great to add ExchangeApplicationPermissions and ExchangeDelegatePermissions. My app uses both PnP.PowerShell and ExchangeOnlineManagement, and users have to manually add the Exchange.ManageAsApp permission afterward.


Remove enable/disable from all hocon sector.

Codecov Report
Patch coverage has no change and project coverage change: -0.31 :warning:

Comparison is base (c0f5ca0) 54.48% compared to head (34120ce) 54.17%.

:mega: This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #534      +/-   ##
==========================================
- Coverage   54.48%   54.17%   -0.31%
==========================================
  Files         120      120
  Lines       36455    36463       +8
==========================================
- Hits        19861    19755     -106
- Misses      16594    16708     +114

Impacted Files
Coverage Δ

src/supplemental/nanolib/acl_conf.c
0.00% <0.00%> (ø)

src/supplemental/nanolib/conf.c
8.81% <0.00%> (-0.03%)
:arrow_down:

src/supplemental/nanolib/conf_ver2.c
0.00% <0.00%> (ø)

... and 20 files with indirect coverage changes
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

Plz resubmit this PR next week


RuntimeError: unmatched '}' in format string

After executing the training, I get the following error:
Process Process-1:
Traceback (most recent call last):
  File "C:\Users\sohee\AppData\Local\Programs\Python\Python310\lib\multiprocessing\process.py", line 314, in _bootstrap
    self.run()
  File "C:\Users\sohee\AppData\Local\Programs\Python\Python310\lib\multiprocessing\process.py", line 108, in run
    self._target(*self._args, **self._kwargs)
  File "H:\RVC\Retrieval-based-Voice-Conversion-WebUI\train_nsf_sim_cache_sid_load_pretrain.py", line 100, in run
    dist.init_process_group(
  File "H:\RVC\Retrieval-based-Voice-Conversion-WebUI\venv\lib\site-packages\torch\distributed\distributed_c10d.py", line 900, in init_process_group
    store, rank, world_size = next(rendezvous_iterator)
  File "H:\RVC\Retrieval-based-Voice-Conversion-WebUI\venv\lib\site-packages\torch\distributed\rendezvous.py", line 245, in _env_rendezvous_handler
    store = _create_c10d_store(master_addr, master_port, rank, world_size, timeout)
  File "H:\RVC\Retrieval-based-Voice-Conversion-WebUI\venv\lib\site-packages\torch\distributed\rendezvous.py", line 176, in _create_c10d_store
    return TCPStore(
RuntimeError: unmatched '}' in format string

Help! I have tried to reinstall many times and update according to the requirements, and the same error occurs. My system is WIN10, please help!

I found same error on
https://github.com/pytorch/pytorch/issues/100185
Maybe, but I don't think this is an RVC issue.


Unit testing with go-sqlmock

Your Question

Hi, I wanted to know what the best strategy to write unit tests with GORM. I've read a couple different strategies that use go-sqlmock to write unit tests, however most of them are for GORM v1 and they seem to be using the gorm.open(dialect, args) which seems to have been changed. So I was wondering how I could open connections with v2. I'm still very new to Go and GORM so I would really appreciate, so the answer might have been really obvious but I wasn't able to find it after doing my research.
Thank you.

The document you expected this should be explained

Expected answer

A strategy that I can use to write unit tests with GORM (preferably using something like go-sqlmock.

I was able to find this answer on SO https://stackoverflow.com/a/71896490. I haven't tried it yet but it looks promising. Will update once I've tried it out.


[BUG]: Make payment for Submission Pending Tasks are not getting cleared

Once Payment is made by Nyayamitra for submissions, Pending tasks which is created for Make payment for Submission are not getting clear.
To Reproduce
Steps to reproduce the behavior:

Login as a Valid user
Make a Submission
Make a Payment for Submission by the Nyayamitra, as Online Payment is not working
Now we can see Pending task (Make payment for Submission) which is created for the case is not cleared

Expected behavior
Once the Payment is done Pending task should clear from the Pending tasks list

Tested in UAT environment, Working as expected


Fix unsafe interpolations

We now have puppet-lint-check_unsafe_interpolations and it detect some
issues.  Fix them.

Unfortunately due to https://github.com/puppetlabs/puppet-lint-check_unsafe_interpolations/issues/39 we are still required to disable the check.

I updated the PR to use stdlib::shell_escape() in favor of shell_escape() (deprecated).
I also removed the comments to disable the check to avoid the false positives because:

This check is not enabled by default;
I opened https://github.com/puppetlabs/puppet-lint-check_unsafe_interpolations/pull/47 to fix the bug.

When a version of puppet-lint-check_unsafe_interpolations that can spot shell_escaped interpolations is released, we will be able to consider its inclusion at the voxpupuli level and this module should not raise any warning when this happen.


[BUG] init including oidc imports wrong version

Information

Version: 4.2.6
Packages: oicd-provider

Initializing a project and including open id connect provider installs oicd-provider version 8.0.0 which is incompatible with the node version set. The error says I need to use node version 18 but when upgrading node to 18 the packages all install correctly however I get errors in that package when trying to yarn start. Errors that are in my node modules folder, and out of my control, because the new version is a breaking version for this project.
After some digging in the code I found the oicd-provider is set to ^7.11.1 in the tsed repo but looking for the "latest" in here
forcing the "oidc-provider": "^7.11.1", and "@types/oidc-provider": "^7.11.1", in my yarn file fixed this.
I believe setting the version instead of using latest in CliPluginOidcProviderModule.js will help. I can open up a PR but wasn't sure how you wanted to handle this considering that upgrading
Example
yarn install -g @tsed/cli
tsed init .

cli inputs
? Choose the target platform: Express.js
? Choose the architecture for your project: Ts.ED
? Choose the convention file styling: Ts.ED
? Check the features needed for your project Database, Passport.js, Swagger, OpenID Connect provider, Linter,
Bundler
? Choose a ORM manager Mongoose
? Choose linter tools framework EsLint
? Choose extra linter tools Prettier, Lint on commit
? Choose your bundler Babel
? Choose the OIDC base path server /oidc
? Choose the package manager: Yarn

yarn
  ❯ Install
    ✔ Write package.json
    ✔ Installing dependencies using Yarn
    ✖ Command failed with exit code 1: yarn add<EMAIL_ADDRESS>@react-navigation/bot…
      error<EMAIL_ADDRESS>The engine "node" is incompatible with this module. Expected version "18". Got "…
      error Found incompatible module.
      yarn add v1.22.19
      [1/4] Resolving packages...
      [2/4] Fetching packages...
      info Visit https://yarnpkg.com/en/docs/cli/add for documentation about this command.
    ◼ Add devDependencies using Yarn
    ◼ Clean
Error: Command failed with exit code 1: yarn add<EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS>passport oidc-provider @tsed/oidc-provider @tsed/jwks @tsed/adapters bcrypt<EMAIL_ADDRESS>mongoose
error<EMAIL_ADDRESS>The engine "node" is incompatible with this module. Expected version "18". Got "16.15.1"
error Found incompatible module.

Acceptance criteria

[ ] Setting the oicd-provider version to 7.11.1 or some other solution that's more stable (upgrading oicd-provider would mean also upgrading here which would be an easy miss and cause this bug to continue)

Hello @TomsOverBaghdad
In general I let latest flag to simplify installation. In most case it works, because maintaining each dependencies up to date is a pain point.
Right know, you can fix the version in the cli until the problem isn’t solved :)
Thanks for your help ;)
romain

Note: the author of oidc-provider exaggerates to fix such recent versions... ^^

Thanks for the quick reply!
Do we need to have "oidc-provider" here when we have the dependency already in "tsed/oidc-provider"? Could a solution be to change the peerDependency in tsed to be "7.11.1" and then remove the "oidc-provider" in this repo?

The CLI must be fixed, because peerDependency is resolved differently depending on the used packageManager. And the problem is temporary, until I haven't investigued on the OIDC v8 issue

U


Update connect-to-google-cloud-platform-gcp.md

Fixed invalid comment line in example
Harness Developer Pull Request
Thanks for helping us make the Developer Hub better. The PR will be looked at
by the maintainers.
What Type of PR is This?

[ ] Issue
[ ] Feature
[x] Maintenance/Chore

Please check the Execution Link of the Pipeline for the Website Draft URL. This is located in the Preview Step and also is available in #hdh_alerts. E.g Website Draft URL: https://unique-id--harness-developer.netlify.app


Fix typo missing space in country-avg-male-height

I found and fix missing space in country name in file src/country-avg-male-height.json.

Same as I say in #59 , it was not bug. It just CamelCased string.
But you can make clarification if I was wrong.

:+1:


Remove Media Queries

Media queries should be determined by your content, therefore, we should not
dictate them. This not only gives the developer more freedom, but also gives us
a more expansive library of patterns, as some may work in both contexts.
I modified the nav pattern to create two derivatives that are based on the wide
viewport nav implmentation: .horizontal-nav and .horizontal-nav--fit. Change
the naming as you see fit.

See https://github.com/ScalesCSS/scales/issues/9


Incompatibility with NoExpensive

The mod is incompatible with the mod NoExpensive and the game crashes on startup.

Known incompatibility, it's because NoExpensive uses an @Overwrite to change AnvilScreenHandler.updateResult(), so there is nothing I can do about it.
You can use Anvil Fix instead, that works without any issues.
I'm sure there are other mods out there which make Infinity and Mending compatible, not sure about Multishot and Piercing though.

Looks like this incompatibility was fixed in https://github.com/Enaium-FabricMC/NoExpensive/commit/837ea3c8fdd44584af64bc04e84f10fdbfa0294d (version 1.2.0 for 1.17)


Update domkit editor/viewer for domkit PR 55

Depends on https://github.com/HeapsIO/domkit/pull/55

I have commented a few lines on the PR


RFC: Project ID Detection

Adds Project ID Detection in this order:

Project ID from Application Default Credentials
Project ID from GCLOUD_CONFIG environment variable
Project ID from App Engine AppIdentity service
Project ID from Compute Engine metadata server
Project ID from gcloud default config file

As "Project ID" is only used for API calls to Google Cloud Platform, it makes more sense to put this in google/cloud as opposed to google/auth

I'm not sure if this makes a difference, but for Node, this logic went into the auth library (PR). Exposing this detection in a lower level for more libraries to take advantage of would probably be well received.
The other languages were going to put this behavior in the auth layer as well, though I haven't followed their conversations to confirm.

I agree with @stephenplusplus that I could see there being value in detecting the project ID from the auth layer.
Adding on to your point, it does look like ruby plans to add the same support to the auth library as well: https://github.com/google/google-auth-library-ruby/issues/90.
@bshaffer do you think given that we should follow suit?

We are having this conversation and trying to decide where best to place this. Since project ID is only used in cloud-based APIs, I am of the opinion it should be implemented here.

I don't know if I agree with that @bshaffer. There may not be many first-party libraries that need to determine project IDs, but there are some (the work done by @tomwalder comes to mind) that do interact with the cloud APIs and thus need project IDs. Surely more will come as time goes on, to fill in gaps which google-cloud-php doesn't cover. Easing project ID detection would surely make things simpler for more than just us. :smile:

Hey. It would certainly cause some problems for the PHP-GDS library if project ID detection got moved into this library.
What about a distinct library for Project ID detection, which can then be composed in?
e.g. google/google-cloud-project-detect-php
Or something less catchy? :)

@tomwalder I would prefer to keep things simple if possible. The consensus is in resounding favor of moving this to google/auth, and @jdpedrie brings up a good point.

closing because this will never ever be merged ever


zlib.net/<archive> only provides the latest download

Zlib 1.3 is out so the https://zlib.net/zlib-1.2.13.tar.gz link is dead.

Fixed by:

https://github.com/DaemonEngine/Daemon/pull/1008


[BUG] Negative ticket Price for an event

Description
In the Create event form, it is possible to set up a negative ticket price, which shouldn't be possible.
Screenshots

Additional information
I can work on this.

Good spot, thank you for raising 👍

I would like to work on this issue please 👍

I would like to work on this issue please 👍

@Fly0w I have assigned this to you

is this still open?

is this still open?

@EraKin575 please refer to the conversation just above your comment or alternatively the Assignee box at the top of the page - this has been assigned to someone else.


Automator: update<EMAIL_ADDRESS>in<EMAIL_ADDRESS>

Generated by Automator - 2024-10-31T16:21:18+00:00

@istio-testing: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

integ-basic-arm64_istio_release-1.23
978f808fb17462d640dc04350cf30c2a9be02d13
link
true
/test integ-basic-arm64

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

/retest


Scroll

Is there a way to cancel the zoom by doing scroll?

You can disable scroll zooming by passing in the scrollZoom control option when instantiating Viewer:
var viewer = new Marzipano.Viewer(element, { controls: { scrollZoom: false } });

You the best!!!!! TY


[MB-7971] Disable submit move when there are no shipments

Description
Disable Submit Move Details button when there are no shipments for the move
Reviewer Notes

also changed ListOrders method to not check for MTO Shipments because we still want to have moves in the queue even if it has no shipments because services counselor will be able to delete shipments in the future

Setup
make db_dev_e2e_populate
make server_run
make office_client_run

Log in to services counselor
Go into move with Move Code NOSHIP
Expected result: Submit Move Detail button should be disabled

Code Review Verification Steps

[ ] User facing changes have been reviewed by design.
[ ] Request review from a member of a different team.
[ ] Have the Jira acceptance criteria been met for this change?

References

Jira story for this change

Screenshots

Messages

:book:
:link: MB-7971

  Generated by :no_entry_sign: dangerJS against d69927becc13ca36299c35160323a67634501cda


Updating a message via REST does not trigger change event in query

websdk v3.4.0
Not sure if this is the right place to report this issue, but when I edit a message via REST the message is successfully updated, but there is no change event triggered in the message query.
I've tried both endpoints for updating message parts to see if it made a difference:
Replace all parts
Update message part
neither triggered the event. The query is otherwise fine.

Looking into this.  Might not get back until Monday.

Hey, this feature, while available on the server now, it should not have been published to our docs because its not yet supported by clients.  Expect support to role out in Q1 of next year.  You'll need to work around lack of Message Editing features until then.


Translatable not working together with barryvdh/laravel-debugbar

Hi guys,
First of all: great job on this package, works great!
I was trying to create a profile of the app I created, using barryvdh/laravel-debugbar. That one doesn't seem to work, because this package redirects all urls to /locale/*.
ex: en/_debugbar/assets/javascript
Is there anything I can do about that, so my debug-files won't throw a 404.
Working in L5.3, latest versions of both packages.
Thanks in advance.

Hi @janboden
I don't see how this package can be related to the 404 issue, since there is no http involved at all.
Also I haven't used debugbar so unfortunately I can't help you, sorry.

I've the same problem, it happens when using routes like /{locale} the whole app blanks and debugbar isn't working, would you please put an example of routing for your great package?

There are other packages to handle routing. For example: https://github.com/mcamara/laravel-localization


Add package name for CAPA proto

Having a package name is recommended in protobuf's style guide, to avoid naming conflicts.
The protobuf's generated python is also updated using libprotoc 3.21.12
It doesn't affect python packages: https://protobuf.dev/reference/python/python-generated/#package
closes #1960

Checklist

[ ] No CHANGELOG update needed

[x] No new tests needed

[x] No documentation update needed

continued in #1962


Background on the keys representing the vi mode

I've recently started to use hydro and I'm really enjoying it! One thing that is bothering me is the fact that there is a background on some vi modes, namely insert and normal:

I checked my config, but I couldn't find anything strange.
set -gx PNPM_HOME "$HOME/Library/pnpm"

# hydro
set -g hydro_multiline true
set -g fish_prompt_pwd_dir_length 0

fish_add_path /opt/homebrew/bin
fish_add_path PNPM_HOME

if status is-interactive
    set fish_greeting "🌸"
    fish_vi_key_bindings
end

Environment details:

Shell: fish, version 3.5.1
Terminal: kitty, version 0.26.1
Hydro: don't know how to check the version, but I ran fisher update few minutes ago

Vi mode colors and background colors are set here:
https://github.com/jorgebucaran/hydro/blob/d4c107a2c99d1066950a09f605bffea61fc0efab/functions/fish_mode_prompt.fish#L3-L19

Vi mode colors and background colors are set here:
https://github.com/jorgebucaran/hydro/blob/d4c107a2c99d1066950a09f605bffea61fc0efab/functions/fish_mode_prompt.fish#L3-L19

Oh ok, thanks for the info!

BTW, it seems that $fish_color_match is deprecated: https://github.com/fish-shell/fish-shell/commit/f94a6a74f0e826db862e9381e505a4024bf02691
I don't know if @guilhermedeandrade asked for this but would be nice to have those colors modifiable via $hydro_color_ variables. :)

@2-4601 that's really strange, because $fish_color_match totally fixed my issue 🤔
function fish_mode_prompt
    if test "$fish_key_bindings" != fish_default_key_bindings
        set --local vi_mode_color
        set --local vi_mode_symbol
        switch $fish_bind_mode
            case default
                set vi_mode_color (set_color $fish_color_match)
                set vi_mode_symbol N
            case insert
                set vi_mode_color (set_color $fish_color_match)
                set vi_mode_symbol I
            case replace replace_one
                set vi_mode_color (set_color $fish_color_match)
                set vi_mode_symbol R
            case visual
                set vi_mode_color (set_color $fish_color_match)
                set vi_mode_symbol V
        end
        echo -e "$vi_mode_color $vi_mode_symbol \x1b[0m "
    end
end

Perhaps you are using a theme that still uses that variable? Or if the variable is not set then it won't display any color which is perhaps what you want? In any case, Fish shell itself does not use that variable anymore.

Perhaps you are using a theme that still uses that variable? Or if the variable is not set then it won't display any color which is perhaps what you want? In any case, Fish shell itself does not use that variable anymore.
In a clean install of Fish
set --show fish_color_match

prints nothing.

It prints nothing here as well 😮


Bad syntax highlighting when using template strings in TypeScript

From @lukaseder on September 13, 2016 12:25

VSCode Version: Code 1.5.2 (66f37fd2a99eb9d628dd374d81d78835b410c39b, 2016-09-12T13:30:03.456Z)
OS Version: Windows_NT ia32 10.0.14393

Steps to Reproduce:
The following code
// (ironically, GitHub has the same issue as can be seen below)
let a = `a b ${(new Date).getFullYear()} c`
let b = 0;

... breaks syntax highlighting for TypeScript:

The problem appears as soon as the function call to getFullYear() has parentheses. Removing the parentheses partially "fixes" the problem:

Copied from original issue: Microsoft/vscode#11951

From @vilic on September 15, 2016 12:14
The TmLanguage file of TypeScript just does not work well, and the repository (TypeScript-TmLanguage) is lack of maintenance. Please let us know you are going to move to a better way of syntax highlighting like something based on language server.

@vilic a new grammar is being released soon (like very soon, could be today). Please stand by.

I believe this will be fixed with the next grammar update. @aeschli can you speak to this?

This is fixed by 0cab1cc


Collate Code (derickjw)

Coverage remained the same at 85.164% when pulling b21c774e1d53140dda1e7a73f49f9cff7b4d777e on DericKJW:master into cc6719f14724ff4690524a51297ab2f9c8f66493 on CS2103AUG2017-F10-B2:master.


Update Grand Final Public holiday for Victoria AU 2020.

This has been moved due to COVID-19.
Refer to: https://www.business.vic.gov.au/victorian-public-holidays-and-daylight-saving/victorian-public-holidays

Pull Request Test Coverage Report for Build 849

8 of 8 (100.0%)  changed or added relevant lines in 2 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 100.0%

Totals

Change from base Build 831:
0.0%

Covered Lines:
8790

Relevant Lines:
8790

💛  - Coveralls

Pull Request Test Coverage Report for Build 849

8 of 8 (100.0%)  changed or added relevant lines in 2 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 100.0%

Totals

Change from base Build 831:
0.0%

Covered Lines:
8790

Relevant Lines:
8790

💛  - Coveralls

Hi,
thanks a lot for your good work: I've just released it on beta branch.
Cheers
dr-p


Question: What are you using to make the models?

.stl files are great for being ready-to-print, but hard to edit. Would it be possible to get the original files so we can work on them?

Fusion 360 links in the readme. Web viewer can export several formats.

Ah, great. Thanks!


[RUM-5566] Added setSyntheticsAttribute in RumInternalProxy

What does this PR do?
Adds setSyntheticsAttribute in _RumInternalProxy for internal usage in cross-platform frameworks.
Review checklist (to be filled by reviewers)

[ ] Feature or bugfix MUST have appropriate tests (unit, integration, e2e)
[ ] Make sure you discussed the feature or bugfix with the maintaining team in an Issue
[ ] Make sure each commit and the PR mention the Issue number (cf the CONTRIBUTING doc)

I have added a check to verify that the lateinit variable sdkCore has been initialized in the ActivityLifecycleTrackingStrategy:
if (::sdkCore.isInitialized) {
/// ...
}

A test was failing because of this missing check, as the previous implementation would only use the sdkCore if the activity contained the synthetics attributes intent extras, that are not passed for that particular test.
@mariusc83 @xgouchet let me know if you prefer to modify the test instead, or if you think this approach is safer.

Codecov Report
Attention: Patch coverage is 75.00000% with 3 lines in your changes missing coverage. Please review.

Project coverage is 69.92%. Comparing base (54f5f12) to head (e33b3f2).
Report is 19 commits behind head on develop.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #2133      +/-   ##
===========================================
- Coverage    70.00%   69.92%   -0.08%
===========================================
  Files          726      726
  Lines        26970    26969       -1
  Branches      4521     4521
===========================================
- Hits         18879    18858      -21
- Misses        6817     6829      +12
- Partials      1274     1282       +8

Files
Coverage Δ

.../rum/tracking/ActivityLifecycleTrackingStrategy.kt
90.00% <75.00%> (+2.73%)
:arrow_up:

...otlin/com/datadog/android/rum/_RumInternalProxy.kt
78.57% <75.00%> (-4.76%)
:arrow_down:

... and 33 files with indirect coverage changes


Keep topic data order choice by session

the UI looses the selected sort order when one changes to a different tab or to view details.

It's normal, the state is not store for now.
As I understand, you want to have some session based sort order ?
The sort order is keep for the current session ?

that would be good. otherwise one has to repeat selecting the sort order all the time

Ok will look at this in a future release
in a mean time, you can set up default order in configuration files for all the user :
https://github.com/tchiotludo/kafkahq/blob/dev/application.example.yml#L47-L48


Remove "supports scaled test results" and freeze frame length from the list of SPNs that support test results.

For example, change...
SPN 5031 - Aftertreatment 1 Outlet NOx Sensor Heater Ratio: Supports Scaled Test Results with data length 0 bytes
...to...
SPN 5031 - Aftertreatment 1 Outlet NOx Sensor Heater Ratio

The test results type and data length was removed.  The report only prints the SPNs that support Scaled Tests Results now.


[2219] Apply draft confirm page invalid data validation

Context
Validate and display error styled components when a provider attempts to mark an apply draft trainee as reviewed, when they still have invalid data items that need to be adressed.
Information Summary

Error Summary

Changes proposed in this pull request
Add a new component ReviewSummary::View which chooses to show either the InformationSummary or ErrorSummary depending on the error state.
Ensure that the error state is trickled down to various components, which will enable them to have an error/info class.
Guidance to review

Given that an apply draft trainee exists, with invalid data, visit the Trainee Data page
Expect to see the summary, and a small inset against the invalid section.
Without changing any of the invalid entries, tick the "I have reviewed this section" checkbox and click Continue
Expect to see the same summary as earlier, but styled in an error summary component.

 [L] Apply draft confirm page invalid data validation

Essentially after they've marked this as reviewed and everything is valid, it will be completed so the invalid data summary shouldn't show

Thanks, had to tweak this a bit, since, on clicking continue, the user may or may not have marked the section as reviewed. This introduced a case where the data was no longer valid, but the information summary was still visible.
In the current change, we run a .valid? check within the ReviewSummary::View component, which determines if there are errors, and accordingly decides to render the summary.


Backup Autonomous

Re-create our old autonomous that just drove forward.

I made a new class and just copied the necessary stuff from our current one so it hopefully works but there's a good chance I did something wrong.

it works


[Bug] fix black tests

Describe the bug
Black tests are not passing
@ziv17 FYI, @BarVolunteering will take this one

Just FYI, it seems that currently the bin/black.sh runs black on a small subset of our .py sources.

@atalyaalon Is this done by someone else?

done


[GLUTEN-7264][VL] Rename module gluten-data to gluten-arrow

Closes https://github.com/apache/incubator-gluten/issues/7264

@zhztheplayer it seems gluten-arrow is not labelled by github action, can you help sync yaml file ? maybe a new label ARROW ? thank you


bug: npm install fails for tests

Bug Report
Madara version:

Current behavior:
When we shift to the tests folder, and do a npm install, it fails with the following error:
npm ERR! Invalid comparator: latest

Expected behavior:
The installation should work.
Steps to reproduce:
CD into tests, and do npm install

What node version do you use ?

@LucasLvy
Node -> v18.12.1
NPM -> 9.2.0

@LucasLvy , I guess we should add .nvmrc then!

Yep good idea, do you want to do it ?

Yep good idea, do you want to do it ?

Yes ser!
I will raise a PR doing so.


No way to easily parse the contents of (...) without much ceremony

I'm implementing a proc_macro_attribute for struct types, where I extract field attributes of the form #[inert::field(pub foo)] with the following code:
struct FieldAttr {
    vis: Visibility,
    name: Option<Ident>,
}

impl Parse for FieldAttr {
    fn parse(input: ParseStream) -> Result<Self, Error> {
        let vis = input.parse()?;
        let name = input.parse()?;
        Ok(Self { vis, name })
    }
}

There is no syn API to reproduce what rustc does itself with the first argument of a proc_macro_attribute function as described in the show_streams example in the documentation, where the delimiters are ignored and the function is passed only the contents of the token tree.

I ended up doing that:
struct AttrArgument<T> {
    argument: T,
}

impl<T> Parse for AttrArgument<T>
where
    T: Parse,
{
    fn parse(input: ParseStream) -> Result<Self, Error> {
        let content;
        if input.peek(Paren) {
            syn::parenthesized!(content in input);
        } else if input.peek(Brace) {
            syn::braced!(content in input);
        } else if input.peek(Bracket) {
            syn::bracketed!(content in input);
        } else {
            unreachable!()
        }
        let argument = T::parse(&content)?;
        Ok(Self { argument })
    }
}

Glad you got it working! That looks like a reasonable solution.
In my experience, it has been uncommon to want to parse any of (...) / {...} / [...] without caring which one is present, so I am okay with AttrArgument<T> living in your code rather than something provided by Syn.

The issue here is that there is no way to parse the contents of (…) in an attribute without going through an additional type. The snippet was just for my specific case, but even if I wanted to only parens I would need to either use syn::parenthesized! in the implementation of Parse for FieldAttr or go through a separate type.
I guess my point is that there should be some sort of Parenthesized<T> type that parses a T surrounded by parentheses, but if you think that's too niche, that's fine.

I would need to either use syn::parenthesized! in the implementation of Parse for FieldAttr

This also sounds like a fine solution, and does not require an additional type.

there is no way to parse the contents of (…) in an attribute without going through an additional type

I don't fully understand the opposition to an additional type, or what you consider to be an additional type, but if you are willing to use one then Group is also an option. Something like:
let group: Group= syn::parse2(input)?;
let content: T = syn::parse2(group.stream())?;

I am really confused theres a type called UseGroup however it does not implement parse for some reason

@dtolnay are we supposed to parse the groups character by character? Seems there's no way to peek into or parse Groups


Add KerbalPlanetaryExpansion

Created as a branch of the repo to allow others to edit if needed and delete once merged.

@Olympic1 would love your input on any conflicts in this pack.

I didn't knew this pack was released, I'll need to test it first

https://github.com/KSP-CKAN/CKAN-meta/issues/588

Removed from KS


SDL Window crashes sporadically

When closing. Tested using the snake tutorial.
[trace] [2022-08-12 14:46:50.916] [T-7604274] [runtime.cpp::602] Creating a variable, wire: main-wire name: GFX.MainWindow
[debug] [2022-08-12 14:46:50.916] [T-7604274] [runtime.cpp::2704] Ran warmup on wire: main-wire
[trace] [2022-08-12 14:46:50.917] [T-7604274] [runtime.hpp::500] Wire main-wire scheduled
[trace] [2022-08-12 14:46:50.917] [T-7604274] [runtime.cpp::1960] wire main-wire starting
[debug] [2022-08-12 14:47:21.069] [T-7604274] [runtime.cpp::1988] Wire main-wire stopped
[debug] [2022-08-12 14:47:21.069] [T-7604274] [runtime.cpp::2712] Running cleanup on wire: main-wire users count: 0
[error] [2022-08-12 14:47:21.070] [T-7604274] [runtime.cpp::1749] Fatal SIGSEGV
[error] [2022-08-12 14:47:21.207] [T-7604274] [runtime.cpp::1756]  0# shards::error_handler(int) in /Users/sugar/devel/shards/build/shards
 1# _sigtramp in /usr/lib/system/libsystem_platform.dylib
 2# SDL_UpdateFullscreenMode in /Users/sugar/devel/shards/build/shards
 3# SDL_HideWindow_REAL in /Users/sugar/devel/shards/build/shards
 4# SDL_DestroyWindow_REAL in /Users/sugar/devel/shards/build/shards
 5# SDL_DestroyWindow in /Users/sugar/devel/shards/build/shards
 6# gfx::Window::cleanup() in /Users/sugar/devel/shards/build/shards
 7# gfx::Window::~Window() in /Users/sugar/devel/shards/build/shards
 8# gfx::Window::~Window() in /Users/sugar/devel/shards/build/shards
 9# void std::__1::destroy_at<gfx::Window>(gfx::Window*) in /Users/sugar/devel/shards/build/shards
10# void std::__1::allocator_traits<std::__1::allocator<gfx::Window> >::destroy<gfx::Window, void, void>(std::__1::allocator<gfx::Window>&, gfx::Window*) in /Users/sugar/devel/shards/build/shards
11# std::__1::__shared_ptr_emplace<gfx::Window, std::__1::allocator<gfx::Window> >::__on_zero_shared() in /Users/sugar/devel/shards/build/shards
12# std::__1::__shared_count::__release_shared() in /Users/sugar/devel/shards/build/shards
13# std::__1::__shared_weak_count::__release_shared() in /Users/sugar/devel/shards/build/shards
14# std::__1::shared_ptr<SHFlow>::~shared_ptr() in /Users/sugar/devel/shards/build/shards
15# std::__1::shared_ptr<SHMesh>::~shared_ptr() in /Users/sugar/devel/shards/build/shards
16# gfx::MainWindowGlobals::~MainWindowGlobals() in /Users/sugar/devel/shards/build/shards
17# gfx::MainWindowGlobals::~MainWindowGlobals() in /Users/sugar/devel/shards/build/shards
18# void std::__1::destroy_at<gfx::MainWindowGlobals>(gfx::MainWindowGlobals*) in /Users/sugar/devel/shards/build/shards
19# void std::__1::allocator_traits<std::__1::allocator<gfx::MainWindowGlobals> >::destroy<gfx::MainWindowGlobals, void, void>(std::__1::allocator<gfx::MainWindowGlobals>&, gfx::MainWindowGlobals*) in /Users/sugar/devel/shards/build/shards
20# std::__1::__shared_ptr_emplace<gfx::MainWindowGlobals, std::__1::allocator<gfx::MainWindowGlobals> >::__on_zero_shared() in /Users/sugar/devel/shards/build/shards
21# std::__1::__shared_count::__release_shared() in /Users/sugar/devel/shards/build/shards
22# std::__1::__shared_weak_count::__release_shared() in /Users/sugar/devel/shards/build/shards
23# std::__1::shared_ptr<SHFlow>::~shared_ptr() in /Users/sugar/devel/shards/build/shards
24# std::__1::shared_ptr<SHMesh>::~shared_ptr() in /Users/sugar/devel/shards/build/shards
25# std::__1::shared_ptr<gfx::MainWindowGlobals>::reset() in /Users/sugar/devel/shards/build/shards
26# gfx::MainWindow::cleanup() in /Users/sugar/devel/shards/build/shards
27# shards::ShardWrapper<gfx::MainWindow>::create()::'lambda12'(Shard*)::operator()(Shard*) const in /Users/sugar/devel/shards/build/shards
28# shards::ShardWrapper<gfx::MainWindow>::create()::'lambda12'(Shard*)::__invoke(Shard*) in /Users/sugar/devel/shards/build/shards
29# SHWire::cleanup(bool) in /Users/sugar/devel/shards/build/shards
30# shards::run(SHWire*, SHFlow*, boost::context::continuation&&) in /Users/sugar/devel/shards/build/shards
31# shards::prepare(SHWire*, SHFlow*)::'lambda'(boost::context::continuation&&)::operator()(boost::context::continuation&&) const in /Users/sugar/devel/shards/build/shards
32# decltype(static_cast<shards::prepare(SHWire*, SHFlow*)::'lambda'(boost::context::continuation&&)&>(fp)(static_cast<boost::context::continuation>(fp0))) std::__1::__invoke<shards::prepare(SHWire*, SHFlow*)::'lambda'(boost::context::continuation&&)&, boost::context::continuation>(shards::prepare(SHWire*, SHFlow*)::'lambda'(boost::context::continuation&&)&, boost::context::continuation&&) in /Users/sugar/devel/shards/build/shards
33# std::__1::invoke_result<shards::prepare(SHWire*, SHFlow*)::'lambda'(boost::context::continuation&&)&, boost::context::continuation>::type std::__1::invoke<shards::prepare(SHWire*, SHFlow*)::'lambda'(boost::context::continuation&&)&, boost::context::continuation>(shards::prepare(SHWire*, SHFlow*)::'lambda'(boost::context::continuation&&)&, boost::context::continuation&&) in /Users/sugar/devel/shards/build/shards
34# boost::context::detail::record<boost::context::continuation, SHStackAllocator, shards::prepare(SHWire*, SHFlow*)::'lambda'(boost::context::continuation&&)>::run(void*) in /Users/sugar/devel/shards/build/shards
35# void boost::context::detail::context_entry<boost::context::detail::record<boost::context::continuation, SHStackAllocator, shards::prepare(SHWire*, SHFlow*)::'lambda'(boost::context::continuation&&)> >(boost::context::detail::transfer_t) in /Users/sugar/devel/shards/build/shards

../chainblocks/build/clang-13.0.0-arm64-apple-darwin21.2.0/Debug/shards ./tutorials/snake/full-game/snake.edn
I tried something like this but it doesn't crash when I close the window.
Do you have any more info (debug/release, configure flags)?

@sinkingsugar

It's sporadic @guusw
Debug mode no special config.

@guusw bump


Cannot install tensorflow-addons with python 3.10

System information

OS Platform and Distribution (e.g., Linux Ubuntu 16.04): Ubuntu 16.04
TensorFlow version and how it was installed (source or binary): pip install
TensorFlow-Addons version and how it was installed (source or binary):
Python version: 3.10
Is GPU used? (yes/no):

Describe the bug
Tensorflow-addons cannot be installed with python 3.10.
Code to reproduce the issue
conda create -n tf python=3.10
conda activate tf
pip install tensorflow
pip install tensorflow-addons

Other info / logs
The installation of tensorflow works fine but not the installation of tensorflow-addons.
It gives the following error:
ERROR: Could not find a version that satisfies the requirement tensorflow-addons (from versions: none)
ERROR: No matching distribution found for tensorflow-addons

https://discuss.tensorflow.org/t/support-python-3-10/

With Tensorflow 2.8 released, python 3.10 now is supported on that end

I have the exact same issue on Ubuntu 20.04.4 LTS

He's there a way to install tensorflow with conda using python 3.10 ?


merge

made parsimony faster; sequence coverage visualization

Coverage decreased (-1.8%) to 81.545% when pulling 4b65da9862c5dcfaf38262044e29db2102f09e02 on rmillikin:master into b28843719eaa3f049b88333d03d80b91d9c34519 on smith-chem-wisc:master.

Coverage decreased (-1.8%) to 81.509% when pulling 213b0618f2c3c15d6647c0e19c30efe39ffdd5aa on rmillikin:master into b28843719eaa3f049b88333d03d80b91d9c34519 on smith-chem-wisc:master.


[DOC] Troubleshooting document improvements

We should add some more sections to the troubleshooting document:

What to do if you OOM
Dealing with the cudf 2GB string limit

Re: OOMs in the example notebooks, the things that come to mind are adjusting batch sizes, embedding dimensions, and the TF memory fraction. I'm not actually sure which of those are recommended approaches. :sweat_smile:

Where to find the instructions for authenticating in order to pull containers from NGC might also be useful?

We should also add suggestions for debugging ImportError: TensorFlow is not configured for GPU (usually something like libcudart.so isn't symlinked etc)

It's also the error you get when your Tensorflow install has pulled a version that wasn't built with GPU support.

We should mention that we should use a dask cluster on OOM errors too


chmod does not work when on server

My local host is working fine, but I need to change the permissions for the img/ when it's uploaded to the server. chmod is not allowed when it's on the actual server. :(

How can we automatically change the directory permission for the img folder ? chmod seems to not work since it is not allowed.
It needs to be 0777 in order for people to upload images.


Bug fixed of a code example in readme.md

Modify the code example in readme.md.
You might have forgotten to comment out.

Hi @caron14,
Yes, it seems so.
Thanks for your fix.


Gradient is unnatural after v1.6.3

This seems to be the case because the gradation does not end with transparency. I think this is logically the correct result.
In my project, there was no problem with v1.6.2.
https://dninomiya.com
and v1.6.3 has issue.
gradientColor="hsl(--var(background))"

gradientColor="red"

Hi, this should be fixed in 1.6.4


Snippets : AI Powered (Brain)

Feature description

[ ]  Ability to suggest snippets commands from a sentence
[ ] Warn users : Never trust WebSSH Brain outputs and never use a generated snippet if you don't understand it. It's your own responsibility to use WebSSH Brain and generated snippets.

For @isontheline work :

Swift Messages Bubbles : https://github.com/jordansinger/messages-multiplatform-swiftui-sample


Exhibitor docker container

Does anyone have an updated docker container for exhibitor?  The old netflixoss/exhibitor:1.5.2 launches but uses pretty outdated versions of docker and exhibitor.
Locally I package zookeeper and exhibitor as rpms and create a base container that sets up Centos 7.4 with my local yum repo configured.  I use the following docker file:
FROM company/companybase:latest

RUN yum -y install zookeeper exhibitor &&\
    mkdir /exhibitor &&\
    chown zookeeper:zookeeper /exhibitor

EXPOSE 2181 2888 3888 8080

ENV ZOO_LOG_DIR=/var/log/zookeeper

WORKDIR /exhibitor

ADD --chown=zookeeper:zookeeper zoo.cfg /etc/zookeeper

ADD --chown=zookeeper:zookeeper exhibitor.properties /exhibitor/exhibitor.properties

USER zookeeper:zookeeper

RUN echo "com.netflix.servers-spec=S:1:$(hostname)" >> /exhibitor/exhibitor.properties

ENTRYPOINT ["java", "-jar", "/usr/share/java/exhibitor/exhibitor-1.6.0.jar", "-c", "file"]

and my exhibitor.properties looks like
com.netflix.exhibitor.zookeeper-data-directory=/var/lib/zookeeper/data
com.netflix.exhibitor.cleanup-period-ms=200000
com.netflix.exhibitor.zookeeper-install-directory=/usr/lib/zookeeper
com.netflix.exhibitor.check-ms=2000
com.netflix.exhibitor.client-port=2181
com.netflix.exhibitor.cleanup-max-files=10
com.netflix.exhibitor.connect-port=2888
com.netflix.exhibitor.observer-threshold=3
com.netflix.exhibitor.election-port=3888
com.netflix.exhibitor.zoo-cfg-extra=syncLimit\=5&tickTime\=2000&initLimit\=10
com.netflix.exhibitor.auto-manage-instances-settling-period-ms=10000
com.netflix.exhibitor.auto-manage-instances=0
com.netflix.exhibitor.log4j-properties=log4j.rootLogger=INFO, CONSOLE \
    log4j.appender.CONSOLE=org.apache.log4j.ConsoleAppender\n\
    log4j.appender.CONSOLE.Threshold=INFO \n\
    log4j.appender.CONSOLE.layout=org.apache.log4j.PatternLayout \n\
    log4j.appender.CONSOLE.layout.ConversionPattern=%d{ISO8601} - %-5p [%t:%C{1}@%L] - %m%n

I run the container via
docker run -d -p 8080:8080 -p 2181:2181 --name exhibitor company/zookeeper
It goes through a lengthy cycle of starting zookeeper, killing it, until it deems it running:
On the Control Panel it will show server id -1 and status serving for a brief period and then switch to
and in the docker image there is a zombie process for every zookeeper that was started and stopped.
While its cycling, the config tab always has an empty servers list.  When it finally decides that zookeeper is up, the server list is populated with the containers host name.
Any thoughts?

Can confirm --init fixed a lot of issues i had.  I couldn't work out why the initial startup worked fine but then any change would cause a cascading fail of all zk nodes.  It seems the zombie processes caused the running checks to fail and then in turn the start as it found it was still running.

run command in dockerfile is effective during image build only .   zookeeper  need explicitly server setting in zoo.cfg,  it is better to  have shell script  to inject dynamic parameter from env before exhibitor start


preserve field order in Data.Obj

This is just a simple switch to use ListMap in Data.Obj, as we do basically everywhere else in the code where we have maps of fields.
This fixes two planner tests which were marked with TODOs referring to this exact issue. Since it was so simple to make the switch, I'm not sure why we left those in and didn't just fix it.
I have not yet updated the regression tests. There are about 10 or so failures, some obviously for field order, but others also which I haven't looked at yet.
Any reason not to make this switch?

:+1:

Looks sensible to me.

Thanks. I'll take a look at the test later on and hopefully wrap this up.

Rebased so I could fix the new test @sellout added.

Current coverage is 80.12%

Merging #1138 into master will decrease coverage by -0.07% as of ebe8832

@@            master   #1138   diff @@
======================================
  Files          163     163
  Stmts         8917    8917
  Branches       283     281     -2
  Methods          0       0
======================================
- Hit           7151    7145     -6
  Partial          0       0
- Missed        1766    1772     +6

Review entire Coverage Diff as of ebe8832

Powered by Codecov. Updated on successful CI builds.

@sellout: This is ready for a look, finally.
With the ControlService tests skipped, all four builds passed on the first try in Travis, and I just kicked it off again to make sure.

@sellout: Built clean in Travis with that fix in objectConcat. Thanks!

This looks great. Glad to finally fix all the issues plaguing integration tests. And happy to see some arbitraries becoming more arbitrary.

This is in ready – which I should have set it to last week, but just did this morning.

Thanks!
I will revert the change to skip the ControlService tests, since I haven't noticed as many of those failures lately.

Merged as 5.0.7.


[stable/chartmuseum] allow for extraargs to be set

<!--
Thank you for contributing to helm/charts. Before you submit this PR we'd like to
make sure you are aware of our technical requirements and best practices:

* https://github.com/helm/charts/blob/master/CONTRIBUTING.md#technical-requirements
* https://github.com/helm/helm/tree/master/docs/chart_best_practices
#### Is this a new chart
no

#### What this PR does / why we need it:
allows for extraargs to take advantage of new features and customization in 0.12.0 chartmuseum

#### Special notes for your reviewer:
https://github.com/helm/chartmuseum/releases

#### Checklist
[Place an '[x]' (no spaces) in all applicable fields. Please remove unrelated fields.]
- [ ] [DCO](https://github.com/helm/charts/blob/master/CONTRIBUTING.md#sign-your-work) signed
- [x] Chart Version bumped
- [x] Variables are documented in the README.md
- [x] Title of the PR starts with chart name (e.g. `[stable/mychartname]`)

<!--
Thank you for contributing to helm/charts. Before you submit this PR we'd like to
make sure you are aware of our technical requirements and best practices:

* https://github.com/helm/charts/blob/master/CONTRIBUTING.md#technical-requirements
* https://github.com/helm/helm/tree/master/docs/chart_best_practices
#### Is this a new chart
no

#### What this PR does / why we need it:
allows for extraargs to take advantage of new features and customization in 0.12.0 chartmuseum

#### Special notes for your reviewer:
https://github.com/helm/chartmuseum/releases

#### Checklist
[Place an '[x]' (no spaces) in all applicable fields. Please remove unrelated fields.]
- [x] [DCO](https://github.com/helm/charts/blob/master/CONTRIBUTING.md#sign-your-work) signed
- [x] Chart Version bumped
- [x] Variables are documented in the README.md
- [x] Title of the PR starts with chart name (e.g. `[stable/mychartname]`)

/ok-to-test

/lgtm


lenovo: fix unstable wifi on Yoga laptops

Description of changes
Add extra modprobe options to fix unstable wifi on Yoga laptops.
Things done

[x] Tested the changes in your own NixOS Configuration
[x] Tested the changes end-to-end by using your fork of nixos-hardware and
importing it via <nixos-hardware> or Flake input

@mergify queue

Hello @Jdogzz
Is this change really needed? I also have this device and the wifi is stable.

@Jdogzz @me00001 I think you need to fight this out. I can't really verify this.

Hello @Jdogzz Is this change really needed? I also have this device and the wifi is stable.

Per the arch wiki this addresses common issues with wifi stability on these devices: https://wiki.archlinux.org/title/Network_configuration/Wireless#RTW89
Is there a more standard way of addressing issues like this?


ESP32 DAC Cosine Wave Output

The ESP32 is supposed to have a cosine wave generator that can output to the DACs as well.
Is it already possible to use this from esp-hal or how complicated would it be to add?
references:
https://docs.espressif.com/projects/esp-idf/en/v5.1.4/esp32/api-reference/peripherals/dac.html#continuous-wave-output-continuous-dma-mode
https://www.espressif.com/sites/default/files/documentation/esp32_technical_reference_manual_en.pdf 29.4.4

Currently, cosine wave generator is not supported in esp-hal, to add support for it, feel free to take a look at https://github.com/esp-rs/esp-hal/blob/main/esp-hal/src/analog/dac.rs, the TRM section that you shared and the ESP-IDF source code.

Thinking about it, I want to output raw audio on one of the DACs. It seems, I actually want to use the continuous mode with DMA for this. The bindings seem to be there in esp_idf_sys. I'll try to post the result as a PR when it works

Also, I probably want to (among other things) stream audio via a2dp. This currently requires ESP-IDP, right? I don't know of any Rust BT stack that can do a2dp with e.g. embassy.
Not sure what the relationship is, if I want to use the DAC from ESP-IDP, I need to add it to esp-idf-hal?

a2dp is classic Bluetooth which is only supported by the original ESP32 and not on bare metal - this is the repository of the bare metal HAL. You probably want to ask in https://github.com/esp-rs/esp-idf-hal


Unexpected generated result

Hi @jondot , need to confirm this issue
I have 3 templates like below in a generator folder:
Templates
a.ejs.t
---
to: ./a.js
---

// test one
// test two
// test three

// route_goes_here
app.get();
app.post();
app.put();

app.listen(5000, () => console.log('somehting'));

// something must be down here

c.ejs.t
---
to: ./a.js
inject: true
before: route_goes_here
---
app.options();

d.ejs.t
---
to: ./a.js
inject: true
after: route_goes_here
---
const {
  something,
  going,
  on,
  here,
} = require('someendpoints');
// end of injection d

What I expect to be generated
From previous set of templates, when i run the generator, I expect the output like this:
a.js
// test one
// test two
// test three

app.options();
// route_goes_here
const {
  something,
  going,
  on,
  here,
} = require('someendpoints');
// end of injection d
app.get();
app.post();
app.put();

app.listen(5000, () => console.log('somehting'));

// something must be down here

Hygen Result
Instead, when i ran the generator, i got
a.js
// test one
// test two
// test three

app.options();
// route_goes_here
app.get();
app.post();
app.put();

app.listen(5000, () => console.log('somehting'));

// something must be down here
const {
  something,
  going,
  on,
  here,
} = require('someendpoints');
// end of injection d

And when I ran it for the second time by not overwriting the existing file, i got
a.js
app.options();
// test one
// test two
// test three

app.options();
// route_goes_here
app.get();
app.post();
app.put();

app.listen(5000, () => console.log('somehting'));

// something must be down here
const {
  something,
  going,
  on,
  here,
} = require('someendpoints');
// end of injection d
const {
  something,
  going,
  on,
  here,
} = require('someendpoints');
// end of injection d

Questions

Is what I expected from the set of templates is wrong? If so, which one is wrong?
Can I obtain the expected result by adjusting the templates headers? If so, what should be changed?

Let me know if you need another information. Thanks

It appears this behaviour occured in latest version (6.0.4)
I found the solution by downgrading hygen to version 5.0.1
Closing this one out


Standalone not working

Hello, having issue with standalone/package - arcgis plugin not loading anything ins standalone or package, it only load map in editor, what I am missing? I am using apikey.  Using arcgis SDK 1.6 and unreal engine 5.3.2 in windows 11 64bit

Hi,
Is the level itself being loaded or do you see a black screen?
Does the application crash completely or is the window non-responsive (can't be closed)?
If the level can be loaded, could you add a View State Logging Component to the Map actor and review the log for possible errors and warnings?


[SPARK-9030] [STREAMING][HOTFIX] Make sure that no attempts to create Kinesis streams is made when no enabled

Problem: Even when the environment variable to enable tests are disabled, the beforeAll of the KinesisStreamSuite attempted to find AWS credentials to create Kinesis stream, and failed.
Solution: Made sure all accesses to KinesisTestUtils, that created streams, is under testOrIgnore

Merged build triggered.

Merged build started.

Jenkins test this please.

Merged build triggered.

Merged build started.

Merged build finished. Test FAILed.

Merged build finished. Test FAILed.

Fetches from github seems to be failing from within Jenkins. Will have to
try testing this later.
On Sun, Jul 19, 2015 at 7:28 PM, UCB AMPLab<EMAIL_ADDRESS>wrote:

Merged build finished. Test FAILed.
—
Reply to this email directly or view it on GitHub
https://github.com/apache/spark/pull/7519#issuecomment-122731982.

Test build #1114 has started for   PR 7519 at commit 64d6d06.

Test build #1114 has finished for   PR 7519 at commit 64d6d06.

This patch passes all tests.
This patch merges cleanly.
This patch adds the following public classes (experimental):
class IllegalArgumentException(Exception):
case class DayOfYear(child: Expression) extends UnaryExpression with ImplicitCastInputTypes
case class DayOfMonth(child: Expression) extends UnaryExpression with ImplicitCastInputTypes
case class ConcatWs(children: Seq[Expression])


API for attachments

I'm working on adding functionality for accessing attachments. So far I'm pushing my changes to the attachments branch.
Is this something you'd like to review, or should I just push to master when it's good enough for my needs?
Any opinion?
cc: @KartikTalwar

Feel free to push to master if its a feature that helps others as well :-)

Thanks. Consider it done :)


added my school

Added my school Slemish College

@ohaganodhran First stage of verification passed, official domain is slemishcollege.org.uk as far as I verified. This is just an informational note. Pull request is still in the review. I appreciate your patience while waiting for the final decision. Proof of domain ownership: https://slemishcollege.org.uk/remotelearning/

@ohaganodhran Thank you for your patience while waiting for a review and processing your request. Pull request merged.


BorderSide does not change border color

I'm trying to make the border of OutlineInputBorder go yellow, and for this I'm usingBorderSide (color: Colors.yellow)but the border does not turn yellow.
It is a simple effect but it is not possible to change the color of the OutlineInputBorder
Below is the code and the image:

import 'package:flutter/material.dart';

void main() => runApp(new MyApp());

class MyApp extends StatelessWidget {
  @override
  Widget build(BuildContext context) {
    return new MaterialApp(
      home: new HomePage(),
    );
  }
}

class HomePage extends StatefulWidget {
  @override
  _HomePageState createState() => new _HomePageState();
}

class _HomePageState extends State<HomePage> {
  String xp = '0';

  @override
  Widget build(BuildContext context) {
    return new Scaffold(
      appBar: new AppBar(),
      body: new Container(
        padding: new EdgeInsets.only(top: 16.0),
        child: new ListView(
          children: <Widget>[
            new InkWell(
              onTap: () {},
              child: new InputDecorator(
                decoration: new InputDecoration(
                  labelText: 'XP',
                  border: OutlineInputBorder(
                    borderSide: BorderSide(color: Colors.yellow)
                  )
                ),
                child: new Row(
                  mainAxisAlignment: MainAxisAlignment.spaceBetween,
                  mainAxisSize: MainAxisSize.min,
                  children: <Widget>[
                    new Text(this.xp),
                  ],
                ),
              ),
            )
          ],
        ),
      )
    );
  }
}

The attribute that must be changed is hintColor
BorderSide should not be used for this, you need to change Theme
import 'package:flutter/material.dart';

void main() => runApp(new MyApp());

ThemeData buildTheme() {
  final ThemeData base = ThemeData();
  return base.copyWith(
    hintColor: Colors.red,
    inputDecorationTheme: InputDecorationTheme(
      labelStyle: TextStyle(
        color: Colors.yellow,
        fontSize: 24.0
      ),
    ),
  );
}

class MyApp extends StatelessWidget {
  @override
  Widget build(BuildContext context) {
    return new MaterialApp(
      theme: buildTheme(),
      home: new HomePage(),
    );
  }
}

class HomePage extends StatefulWidget {
  @override
  _HomePageState createState() => new _HomePageState();
}

class _HomePageState extends State<HomePage> {
  String xp = '0';

  @override
  Widget build(BuildContext context) {
    return new Scaffold(
      appBar: new AppBar(),
      body: new Container(
        padding: new EdgeInsets.only(top: 16.0),
        child: new ListView(
          children: <Widget>[
            new InkWell(
              onTap: () {},
              child: new InputDecorator(
                decoration: new InputDecoration(
                  labelText: 'XP',
                  border: OutlineInputBorder()
                ),
                child: new Row(
                  mainAxisAlignment: MainAxisAlignment.spaceBetween,
                  mainAxisSize: MainAxisSize.min,
                  children: <Widget>[
                    new Text(this.xp),
                  ],
                ),
              ),
            )
          ],
        ),
      )
    );
  }
}

Or to make the red color default to put the theme in MaterialApp (theme: ...) and to change the theme of a specific widget, such as changing the default red color to the yellow color of the widget, surrounds the widget with :
new Theme(
   data: new ThemeData(
     hintColor: Colors.yellow
  ),
  child: ...
)

Below is the code:
Notice that the red color and label size were set to red and 24px only that the yellow color widget did not take any of these attributes because a theme was defined for it

import 'package:flutter/material.dart';

void main() => runApp(new MyApp());

ThemeData buildTheme() {
  final ThemeData base = ThemeData();
  return base.copyWith(
    hintColor: Colors.red,
    inputDecorationTheme: InputDecorationTheme(
      labelStyle: TextStyle(
        color: Colors.yellow,
        fontSize: 24.0
      ),
    ),
  );
}

class MyApp extends StatelessWidget {
  @override
  Widget build(BuildContext context) {
    return new MaterialApp(
      theme: buildTheme(),
      home: new HomePage(),
    );
  }
}

class HomePage extends StatefulWidget {
  @override
  _HomePageState createState() => new _HomePageState();
}

class _HomePageState extends State<HomePage> {
  String xp = '0';

  @override
  Widget build(BuildContext context) {
    return new Scaffold(
      appBar: new AppBar(),
      body: new Container(
        padding: new EdgeInsets.only(top: 16.0),
        child: new ListView(
          children: <Widget>[
            new InkWell(
              onTap: () {},
              child: new Theme(
                data: new ThemeData(
                  hintColor: Colors.yellow
                ),
                child: new InputDecorator(
                  decoration: new InputDecoration(
                    labelText: 'XP',
                    border: OutlineInputBorder()
                  ),
                  child: new Row(
                    mainAxisAlignment: MainAxisAlignment.spaceBetween,
                    mainAxisSize: MainAxisSize.min,
                    children: <Widget>[
                      new Text(this.xp),
                    ],
                  ),
                ),
              )
            ),
            new InkWell(
              onTap: () {},
              child: new InputDecorator(
                decoration: new InputDecoration(
                  labelText: 'XP',
                  border: OutlineInputBorder()
                ),
                child: new Row(
                  mainAxisAlignment: MainAxisAlignment.spaceBetween,
                  mainAxisSize: MainAxisSize.min,
                  children: <Widget>[
                    new Text(this.xp),
                  ],
                ),
              ),
            )
          ],
        ),
      )
    );
  }
}

I understood the 2 solutions but it doesn't change the fact that there is a parameter which is borderSide that contains a color attribute.  I assume that the issue is not fixed by it self. So why closing the issue?

Perhaps you could reopen this and rename the title, or file a new issue, that is about improving the documentation on what BorderSide does/doesn't do.

See https://github.com/flutter/flutter/issues/18751

I hope to land a fix for this problem next week. Sorry about the long delay.

try this...it's work for me
enabledBorder: OutlineInputBorder(
borderRadius: BorderRadius.circular(10.0),
borderSide: BorderSide(color: Colors.red)),

try this...it's work for me
enabledBorder: OutlineInputBorder(
borderRadius: BorderRadius.circular(10.0),
borderSide: BorderSide(color: Colors.red)),

But this solution works only when the field is enabled. In its normal state, color is still the default one.


added scrape meta for fremont pd

pr template
Description
Please provide a brief description of the changes made in this pull request. Include any relevant context or background information.
Summary of Changes

List the key changes made in this pull request.
Highlight any new features, bug fixes, or enhancements.

Related Issues

Link to any related issues or tickets.

How to Review
Examples include but are not limited to:

Review Code Changes: Examine the code changes and ask whether the changes are consistent with the codebase
Manual Testing: If applicable, provide steps for manual testing to ensure the changes work as expected.

Notes

Provide any useful context for reviewers.
Mention any potential impacts or considerations related to the changes.

@naumansharifwork i do not see your yt-dlp code? could you please push it up to gh when you have a moment?