Organization suggestions

consider using namespaces e.g. export namespace layer{} to group all types under one item. This helps with IntelliSense and knowing where the types came from
move fileReference from SmartObject.d.ts into Reference.d.ts since those are all same kind of references.
move PatternDescriptor from layerEffects.d.ts into Layer.d.ts since other layer descriptors are here and pattern descriptor is not used only in layerEffects

Thanks for the suggestions. I can definitely fix 2. and 3. later.
Regarding the namespaces, I've never used those before so I'll have to read the docs on it first.
In which case would you think it's helpful to have import XY from Layer instead of import XY from photoshop-types? Isn't it just important to know from which repo/module it's imported?
Also, I'm wondering how granular these namespaces should be. Patterns could be part of the Layer namespace, but you could also make a pattern namespace. There might also be some overlaps in some areas.

I have only suggestions and no answers regarding to 1. :-D
You could still do this if you want to:
import {layer, unit, geometry} from "photoshop-types"
And then you can do this:
	export interface PatternFillProperties {
		pattern: layer.PatternDescriptor
		angle: unit.AngleValue
		scale: unit.PercentValue
		align: boolean
		phase: geometry.PointDescriptor
	}

I changed it for my project because I already have too many types in here :-D
Regarding granularity... if something is shared in 2 classes then separate it. Otherwise, I would keep things together in something that looks like a class and separate it once it gets too big.
This could mean breaking changes so major version number would change often.

But wouldn't that be a lot easier:
import {PatternDescriptor, AngleValue, PercentValue, PointDescriptor} from "photoshop-types"

export interface PatternFillProperties {
       pattern: PatternDescriptor
	angle: AngleValue
	scale: PercentValue
	align: boolean
	phase: PointDescriptor
}

Then you're just importing what you really need and don't have to worry about where it comes from 🤔

Well, there are so many types... most of the time you won't be able to figure out what the name could be :-D Namespaces can help you to narrow it.
Also possibly if you would write Desc and hit Ctrl+Space then your IntelliSense could be polluted by 50 types from "photoshop-types" so it could take a while to find your own. :-D
But I agree this might be the subject of personal preference and pros and cons do not significantly overweight to one side.


fix: explicit termination in the post-step

Fixes #580 (hopefully)

Compared to the last CI run where the post-step was hanging for 2 minutes after all saves, CI on this branch looks promising with 8-15s in the post-step.


Acrolinx pass and added note about login to China cloud

@sdwheeler,
Thanks for your contribution as a Microsoft full-time employee or intern. You do not need to sign a CLA.
Thanks,
Microsoft Pull Request Bot


Can't see others pings [Bukkit Server, Fabric Client]

Installed the "Ping Wheel-Plugin" on the server, and installed "Ping Wheel" mod on fabric client.
Log into server, can see and hear my own pings, but no one can see my pings, and I can't see theres.
Server Logs: https://mclo.gs/OeyBOVk
Client Logs: https://mclo.gs/PHnGTRX
I tried giving both players OP but they still can't see each others pings, so I don't think its permission related.
They are both in the Global Channel (default).
Is there a port that needs to be opened on the server, similarly like how the Simple Voice Chat mod/plugin need to work together?
What am I missing?

Thank you for reporting this incident!
I fixed the mentioned bug with Release 1.0.1, please re-open the issue if you encounter issues related to this one.

Yes, its now working! Thanks for the quick fix


normalize axis in ScatterElements verify

Signed-off-by: Philip Lassen<EMAIL_ADDRESS>

@AlexandreEichenberger thanks for the review as always!

Jenkins Linux amd64 Build #8010 [push] normalize axis in Scatte... started at 12:22

Jenkins Linux s390x Build #8026 [push] normalize axis in Scatte... started at 13:22

Jenkins Linux ppc64le Build #7074 [push] normalize axis in Scatte... started at 13:25

Jenkins Linux amd64 Build #8010 [push] normalize axis in Scatte... passed after 1 hr 4 min

Jenkins Linux ppc64le Build #7074 [push] normalize axis in Scatte... passed after 1 hr 33 min


boot2docker on win7 64bit : Cannot start container : [8] System error: no such file or directory

After building the docker images successfully...
when docker run command initiated... getting same error for all containers.
It happens with all the docker images... :(
Error response from daemon: Cannot start container : [8] System error: no such file or directory

Sorry, this repository is long-since deprecated in favor of Docker Toolbox (whose usage is now also discouraged in favor of Docker for Windows and Docker for Mac).


Make Install Stage Skippable and Remove Source

Great module; very nicely setup Redis on my CentOS7 system. Much easier than writing it myself. However, I found myself wanting a couple features:

Don't rerun install if the correct version is already installed. (I realized there are pros and cons to always rerunning the install stage, but if Redis is already installed, I'd like to skip running download/make/etc.)
Remove source after installation.

My first pass looks like this for main.yml
---
- name: Check redis-server version
  command: "redis-server --version"
  register: redis_sever_version
  # May not be installed, or may be the wrong version
  # Version format is: Redis server v<version> sha=...
  # So [2][1:] is all of the second word except the leading 'v'
  changed_when: redis_sever_version.rc or redis_sever_version.stdout.split(' ')[2][1:]|version_compare(redis_version, '<')
  failed_when: False
  always_run: yes

- include: install.yml
  when: redis_sever_version.changed

- file: name=/usr/local/src/redis-{{ redis_version }} state=absent
  when: redis_sever_version.changed

- file: name=/usr/local/src/redis-{{ redis_version }}.tar.gz state=absent
  when: redis_sever_version.changed

- include: server.yml
  when: not redis_sentinel
  tags:
    - config

- include: sentinel.yml
  when: redis_sentinel
  tags:
    - config

- include: local_facts.yml

Thanks @rayalan... I like this idea. Instead of trying to be too magical, how about just a redis_upgrade variable which, if set, will trigger the install process? This way we give more control to the user and don't go unexpectedly upgrading Redis.
It can default to no, but will still install Redis if it doesn't already find a version in the redis_install_dir.

I like the idea of a redis_upgrade variable; that does seem like a cleaner approach.


update deps, fix role model

update npm and composer deps, fixed pagination import for updated dep, added spatie role since role model was removed.

permission model is missing and authserviceprovider check the permission model

I thought since we are using spatie that we just use the spatie permission and role models without having to create one?  Also, I couldn't get the role-permssion I added to work with composable so maybe you can take a look at it.  In the admin/roles/edit you can see the code I added in the setup just calling the axios directly and binding it to the listbox control.

You updated this 'casl/ability' plugin. So also you need to update the ability service. In the new version, a few things are deprecated.

Please also update the readme doc for how to visit the request-docs URL. Also if possible please update the URL '/api-docs' instead of '/request-docs'.

update ability changed api docs url

Also, I added a restriction where a user can only edit their own posts unless the role is admin.  Maybe it would be better to add a new permission for edit all posts and edit own posts instead of restricting by role.

In the posts, you added multiple categories of support. So, now you should also need to update the admin posts list page for the multiple category-wise filters & display the category name.

I am having trouble with the category search.  I think my relations are setup correctly but when I try to search by category the sql statement is wrong. Hardcoded as 1 for testing
PostController
$posts = Post::whereHas('categories')
->when(request('search_category'), function ($query) {
$query->where('categories.id',1);
})
sql error:
Column not found: 1054 Unknown column 'categories.id' in 'where clause' (Connection: mysql, SQL: select count(*) as aggregate from posts where exists (select * from categories inner join category_post on categories.id = category_post.category_id where posts.id = category_post.post_id) and categories.id = 1)"

So this works but I don't really know why or how to get it in the query syntax
$posts = Post::with('categories')
->whereHas('categories', function ($query) {
$query->where('categories.id', 'like', '%3%');
})
//            ->when(request('search_category'), function ($query) {
//                $query->where('categories.id',1);
//            })

This seems to work, let me know if it is ok
$posts = Post::whereHas('categories')
->whereHas('categories', function ($query) {
if(request('search_category')){
$query->where('categories.id',3);
}
})

ok I think I have everything working and updated.  Let me know.

I added spatie media for image upload, that works fine.  However, I can't retrieve the uploaded image related to the post model.  The file is saved on disk and the correct entry is added to the media table. But thumbnail just returns an empty array. Can you help?
PostController
$posts = Post::with('media')
PostResoure
'thumbnail' => $this->media
postman query result
 "data": [
        {
            "id": 37,
            "title": "dfgdfgsdfgdsgsdfgsdfg",
            "categories": [
                {
                    "id": 1,
                    "name": "Vue.js",
                    "created_at": "2023-10-02T17:44:52.000000Z",
                    "updated_at": "2023-10-02T17:44:52.000000Z",
                    "pivot": {
                        "post_id": 37,
                        "category_id": 1
                    }
                },
                {
                    "id": 2,
                    "name": "Cat 2",
                    "created_at": "2023-10-02T17:44:52.000000Z",
                    "updated_at": "2023-10-02T17:44:52.000000Z",
                    "pivot": {
                        "post_id": 37,
                        "category_id": 2
                    }
                }
            ],
            "content": "sdfsdfgsdfgdsfgsdfgsdfgsdfgsdfgsdfgsdfgsdfgsdfsdfg...",
            "thumbnail": [],
            "created_at": "2023-10-02"
        }

read this doc
https://spatie.be/docs/laravel-medialibrary/v10/basic-usage/retrieving-media


Hex Function

What type of PR is this?

[ ] API-change
[ ] BUG
[ ] Improvement
[ ] Documentation
[ ] Feature
[ ] Test and CI
[ ] Code Refactoring

Which issue(s) this PR fixes:
issue #
What this PR does / why we need it:

Please don't merge this PR. It is still WIP. I will add the UT.
I will update you when it is ready.

Please don't merge this PR. It is still WIP. I will add the UT.
I will update you when it is ready.

Thank you for your hard work

PR for hex.go is ready. Kindly review this PR.


add two more number formats, add number formats to table

Add option to change number formats to table view.
Add more suitable formats to number formats.

| 123456789
and
-, | 12,345.4321

Added images

@Pek1s can you fix the conflict?

Codecov Report

Merging #4545 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #4545   +/-   ##
=======================================
  Coverage   71.25%   71.25%
=======================================
  Files         190      190
  Lines       14916    14916
  Branches     1102     1102
=======================================
  Hits        10629    10629
  Misses       4284     4284
  Partials        3        3

Impacted Files
Coverage Δ

...rset/assets/javascripts/explore/stores/visTypes.js
70.58% <ø> (ø)
:arrow_up:

...set/assets/javascripts/explore/stores/controls.jsx
37.77% <ø> (ø)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fc47729...c9569e8. Read the comment docs.

LGTM, I checked out the PR, built, and tested the feature in the UI. No issues. Appreciate the fix for this @Pek1s


We have both a 'request.js' file, and including the request library, seemingly for the same reason

request is used in instrument.js and user-agent-client.js, while request.js is used in user-agent.js and ua.js. They seem to be serving the same purpose, although one uses the lib itself, and the other one uses fetch.
Why?

I think we should get rid of request and just use fetch if we can, and it seems that app/shared/request.js maybe should be renamed to user-agent-request or something, because it does seem useful for that to be a separate lib to easily call out to the UA service

Agreed. We should try using fetch as much as we can, and we already depend on isomorphic-fetch

So the task is to switch the request usage to isomorphic-fetch and to rename the file app/shared/request.js to `user-agent-request'?

@benjaminjs Yup! Although I don't think we actually need to use isomorphic-fetch, since HTML5 fetch is already available everywhere afaik. Basically wherever we import 'request', we shouldn't.

Awesome, I'll try to take a swing at it this evening. Thanks for the clarity, @victorporof

Nice, thanks @benjaminjs

The only place where this is still a problem is app/services/instrument.js which will probably get removed in https://github.com/mozilla/tofino/issues/1365

#1365 has landed, and I've checked that this is done.


Adjust to yiisoft/mailer's changes

Q
A

Is bugfix?
❌

New feature?
❌

Breaks BC?
✔

Tests pass?
✔

Fixed issues
yiisoft/mailer#1

Summary:

Mailer::registerPlugins and Message::attachSigners for mergeable configuration.
Scrutinizer code quality is not so good, it seems because of the Message class contains too many methods.
Mailer example - https://github.com/razonyang/yii-demo

php -S localhost:8080 -t public
http://localhost:8080/contact

Merged. Thank you very much!

@razonyang I think the mailer example should be pull requested/merged into yii-demo as well.

Ok, done.


Line icons for Setu AA consent manager

Line icons

Pause — pausing a consent
Play — reactivating a paused consent
Passbook

Priority
Required—

On Figma —by 12th Jan. Will use material icons until then.
On NPM package — by 19th Jan.

Added another icon to the list Passbook. Currently using Book, but an icon with a stronger metaphor will be helpful.


Dark mode text isn't always white

As the title suggests, I see half the text being black in dark mode. This doens't happen often, and I believe it specifically is for texts after code snippets.

Hello! Thanks for the report! Could you open your popup and inspect element and give me the JSON associated with the notification content.

Do you mean the array?
    "__typename": "ResponseFeedbackNotification",
    "authorAvatarUrl": "https://cdn.kastatic.org/images/avatars/svg/starky-sapling.svg",
    "authorNickname": "Eryn #TeamUmbra",
    "brandNew": false,
    "class_": [
        "BaseNotification",
        "ReadableNotification",
        "BaseFeedbackNotification",
        "ResponseFeedbackNotification"
    ],
    "content": "By that I mean it's not wrapping around like it was meant to, it was just  like this;\n```\nA\na\nB\nb\nect.\n```\nyeah, sorry for the vague wording, I didn't know how to explain it",
    "date": "2023-03-11T01:24:27.877949Z",
    "feedbackType": "REPLY",
    "focusTranslatedTitle": "New program",
    "kaid": "kaid_1007444411542956194078854",
    "read": true,
    "sumVotesIncremented": 1,
    "url": "/computer-programming/new-program/5570993740890112?qa_expand_key=ag5zfmtoYW4tYWNhZGVteXJBCxIIVXNlckRhdGEiHmthaWRfODUwMzM1NjkxMjIyNDM2ODgwMjM3MzQwMwwLEghGZWVkYmFjaxiAgJOX58TvCww&qa_expand_type=reply",
    "urlsafeKey": "ag5zfmtoYW4tYWNhZGVteXIdCxIQQmFzZU5vdGlmaWNhdGlvbhiAgJPrsIb2Cww"
}```

Yes, this is perfect. Thank you, we will have a fix within 48 hours.

The issue should be solved now, it was related to the HTML tags ✅


Disable md checks for shields and reuse links

Description
Changes proposed in this pull request:

as in the title

Related issue(s)

https://github.com/kyma-project/serverless/issues/848#issue-2222275134

/retest


bug fix for mlp_model init

 Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.


Custom analyzer not working as expected

Steps to reproduce:

Set up 03-expert.rb template

$ rails new searchapp --skip --skip-bundle --template https://raw.github.com/elasticsearch/elasticsearch-rails/master/elasticsearch-rails/lib/rails/templates/01-basic.rb
$ rails new searchapp --skip --skip-bundle --template https://raw.github.com/elasticsearch/elasticsearch-rails/master/elasticsearch-rails/lib/rails/templates/02-pretty.rb
$ rails new searchapp --skip --skip-bundle --template https://raw.github.com/elasticsearch/elasticsearch-rails/master/elasticsearch-rails/lib/rails/templates/03-expert.rb

Add a custom analyzer to article title:

-    settings index: { number_of_shards: 1, number_of_replicas: 0 } do
+    settings index: { number_of_shards: 1, number_of_replicas: 0, analysis: {
+               analyzer: {
+                 rubygem: {
+                   type: 'pattern',
+                   pattern: "[\s#{Regexp.escape('.-_')}]+"
+                 }
+               }
+             } } do
       mapping do
         indexes :title, type: 'text' do
-          indexes :title,     analyzer: 'snowball'
+          indexes :title,     analyzer: 'rubygem'
           indexes :tokenized, analyzer: 'simple'
         end

Reimport records

$ rake environment elasticsearch:import:model CLASS='Article' FORCE=y

Start rails server and create a few articles with title as: example_1, example_gem
Search for example.

I don't get any results back. My pattern analyzer seems to be working fine:
$ curl -XGET 'localhost:9200/searchapp_application_development/_analyze?analyzer=rubygem&pretty=true' -d 'example_1'
{
  "tokens" : [
    {
      "token" : "example",
      "start_offset" : 0,
      "end_offset" : 7,
      "type" : "word",
      "position" : 0
    },
    {
      "token" : "1",
      "start_offset" : 8,
      "end_offset" : 9,
      "type" : "word",
      "position" : 1
    }
  ]
}

Any kind of help or general guidance about debugging this would be really appreciated :) I am using elasticsearch 5.3.

Hi, is this in the context of search for Rubygems?
I think it's better to try this out with an isolated example, and then try to integrate it into the example application.
What I've come up with is this Ruby code, I'll add it to the examples folder of the repository later:
# Custom Analyzer for ActiveRecord integration with Elasticsearch
# ===============================================================

$LOAD_PATH.unshift File.expand_path('../../lib', __FILE__)

require 'ansi'
require 'logger'

require 'active_record'
require 'elasticsearch/model'

ActiveRecord::Base.logger = ActiveSupport::Logger.new(STDOUT)
ActiveRecord::Base.establish_connection( adapter: 'sqlite3', database: ":memory:" )

ActiveRecord::Schema.define(version: 1) do
  create_table :articles do |t|
    t.string :title
    t.date    :published_at
    t.timestamps
  end
end

Elasticsearch::Model.client.transport.logger = ActiveSupport::Logger.new(STDOUT)
Elasticsearch::Model.client.transport.logger.formatter = lambda { |s, d, p, m| "#{m.ansi(:faint)}\n" }

class Article < ActiveRecord::Base
  include Elasticsearch::Model

  settings index: {
    number_of_shards: 1,
    number_of_replicas: 0,
    analysis: {
      analyzer: {
        rubygem: {
          type: 'pattern',
          pattern: "_",
          lowercase: true
        }
      }
    } } do
    mapping do
      indexes :title, type: 'text' do
        indexes :keyword, analyzer: 'keyword'
        indexes :rubygem, analyzer: 'rubygem'
      end
    end
  end
end

# Create example records
#
Article.delete_all
Article.create title: 'Foo'
Article.create title: 'Foo_Bar_Baz'
Article.create title: 'Bar'

# Index records
#
errors = Article.import force: true, refresh: true, return: 'errors'
puts "[!] Errors importing records: #{errors.map { |d| d['index']['error'] }.join(', ')}".ansi(:red) && exit(1) unless errors.empty?

puts '', '-'*80

puts "Fulltext analyzer [Foo_Bar_1]:".ansi(:bold),
     Article.__elasticsearch__.client.indices
      .analyze(index: Article.index_name, field: 'title', text: 'Foo_Bar_1')['tokens']
      .map { |d| d['token'] }.join(', '),
    "\n"

puts "Keyword analyzer [Foo_Bar_1]:".ansi(:bold),
     Article.__elasticsearch__.client.indices
      .analyze(index: Article.index_name, field: 'title.keyword', text: 'Foo_Bar_1')['tokens']
      .map { |d| d['token'] }.join(', '),
     "\n"

puts "Rubygem analyzer [Foo_Bar_1]:".ansi(:bold),
     Article.__elasticsearch__.client.indices
      .analyze(index: Article.index_name, field: 'title.rubygem', text: 'Foo_Bar_1')['tokens']
      .map { |d| d['token'] }.join(', '),
     "\n"

puts '', '-'*80

response = Article.search 'foo';

puts "Simple search for 'foo':".ansi(:bold),
     response.records.map { |d| d.title }.inspect,
     "\n"

puts '', '-'*80

response = Article.search query: { match: { 'title.rubygem' => 'foo' } } ;

puts "Rubygem search for 'foo':".ansi(:bold),
     response.records.map { |d| d.title }.inspect,
     "\n"

puts '', '-'*80

require 'pry'; binding.pry;

is this in the context of search for Rubygems?

Yes. It is also my explaination for using [\s#{Regexp.escape('.-_')}]+ . I want to search rubygem name and  '.-_' is where the names split. For example, if I query elasticsearch, I should get back gems named elasticsearch_rails, elasticsearch-rails, elasticsearch_rails.rb etc.
Thank you so much for your example :blue_heart: . I have modified your script to better illustrate my point (See script.
I am miffed over following output (See complete output):
Fulltext analyzer [Foo_Bar_1]:
foo_bar_1
Fulltext analyzer [Foo-Bar-1]:
foo, bar, 1

Search `title` for 'foo':
["Foo", "Foo-Bar-Baz"]
Search `title.title` for 'foo':
["Foo", "Foo_Bar_Baz", "Foo-Bar-Baz"]

So, fulltext analyzer can tokenize over hyphens but not underscores? I was under the impression that if I use same index name (title) when specifying the analyzer, the analyzed field will be used in my query.
Apparently, title uses fulltext analyzer and I should be using title.title if I want use the analyzed field?

is this in the context of search for Rubygems?

Yes.

Right! Ping me if you'd like to get some help, preferably by opening an issue in the rubygems/rubygems.org repository, and mentioning me. In the past, we have been working with David Radcliffe on the initial implementation.

It is also my explaination for using [\s#{Regexp.escape('.-')}]+ . I want to search rubygem name and '.-' is where names split.

Yes, that's what I understood, I was confused by the escaping and the whitespace character there. I've checked it now, and it works the same as my example, though I like the "_|-|\\." version better, the | ("or") character seems to express the intent better to me. I'm not sure if whitespace is permitted in Rubygem names?, but it doesn't hurt to add it.

So, fulltext analyzer can tokenize over hyphens but not underscores?

Yes, correct, of course depends on the specific analyzer, the default one is "Standard Analyzer".

I was under the impression that if I use same index name (title) when specifying the analyzer
Apparently, title uses fulltext analyzer and I should be using title.title if I want to use the analyzed field?

Ha, that's actually a bug in the searchable.rb file, I think the intention there is to set the snowball analyzer as default for the title property. If so, it should be written like this:
indexes :title, type: 'text', analyzer: 'snowball' do
  indexes :tokenized, analyzer: 'simple'
end

That syntax is probably a left-over from the old "multi_field" type of mappings, I'll have to revisit that application template.
Please let me know if you have more questions.

Ping me if you'd like to get some help

Thanks. We just need to update ES 5 before we can enable it on rubygems.org.

Please let me know if you have more questions.

I would really appreciate it if you could go over our implementation and test when you can find some time.
Thanks again for helping me figure this out :relaxed: I think it is safe to close this.

I'll try to do that, do @-mention me whenever you would feel like getting some feedback on the Rubygems.org repo. I'll try to ping @dwradcliffe on the Slack channel we had back then, to see if we can continue expanding the search features.


I have 2x 1

It allowed me to create 2 upgrades to my existing 1Wallet  wallet, creating 2 wallets, which I didnt want,  and neither one has my orginal 1xOne.
harmonyoneincome.crazy.one

I don't understand what you meant by "allowed [you] to create 2 upgrades". Can you elaborate? I see a chain of upgrades and the latest address one14gsdzwce9cmaatvk90dnk2lyxpzaxrrjwvn000 has ~1 ONE, which you originally had

The upgrade to newer version screen  didnt go away after I completed it the first time, so I did it a second time, and ended up with 2 wallets. When I look at my harmonyincome.crazy.one  walles I see two wallets inside, neither of which contains any ONE. I dont even see the latest address.

I managed to find that wallet you mentioned using "About" and upon inspection I see that 1 x ONE, but then when I go to reclaim it it says 0 types tracked and it doesnt reclaim it. I guess I have to send it out?

You can send it out to your latest address. In the next version, The issue with upgrade is probably caused by network delay. I will fix it in the next version. I will also display aggregated assets in the next version, so it won't appear as if the assets were lost in any situation.

OK, I guess I'll wait till next version then to reclaim.


"Plot Dating" not working as intended

For some reason, plot dating now tries to align all data points diagonally, adjusting the axes as needed. Cf below:

Fixed in #114


Show keywords in EditorHelpSearch

EditorHelpSearch now shows the user the first keyword that matched the search term (only if the item's name did not already match the term).
A list of all keywords of the item is also included in the tooltip.

Search performance should be unaffected by these changes.

Not a fan of the text not being darkened a little compared to the item's name. But that's a limitation of TreeItem and it is not the only thing in the editor affected by this.
The way this is shown as of writing this may potentially be confusing, because of GDScript syntax:
(keyword: starts_with) looks like a function signature, where keyword is a parameter name and starts_with is a type.
I'm not sure if "keywords" should be explicitly called like this in the search, either.

Throwing suggestions until something sticks:

I think there should be a whole lot spacing between name and "keyword message".

The hacky yet functional solution would be to just pad   around 8 times.
The ideal solution would be to put it on a whole new column. Problem is, this would come at the cost of way too much spacing between the two, as well as a whole column that goes unused more often than not.

The "keyword message" should be something else.

The keyword itself (e.g. starts_with) needs to be surrounded in quotes.
The message could be prefixed with -,-- or something similar to distinguish it from a function signature.
The message could be less explicit (e.g. "Matches "starts_with".").
The message could be more explicit and human-readable (e.g. "Matches the "starts_with" keyword.").

The way all keywords is displayed in the tooltip could be tweaked:

The keywords need to be comma-separated and surrounded in quotes.
In a perfect world, this tooltip should be generated on the spot as you hover over the item instead of for everything.

This was not the case before I think, but because more effort is put when generating the tooltip this sounds important.

I updated it with some of your suggestions, not sure if I'm happy with it. See the screenshot on the PR.
Another idea would be to gray out items entirely if they matched due to keywords only, like so:

If they are grayed out they don't look like they even match the search. I am against that idea.

Current screenshot looks much nicer than the way this PR started, I feel. Unfortunately the padding with spaces does not feel enough especially with the font used by the EditorHelpSearch

Thanks!


Firebug like XHR logging in the Console panel

One of the features Firebug users are missing is Firebug-like XHR logging (aka XHR Spy)
Honza

I remember it has already been reported.
Florent

Ah, you are right, there is #180
Honza


Dockerize Nightly Environment to provide Selenium Support

Needed for reproducible Selenium env.
Selenium puts out docker images that already has Selenium installed and configured.
As a goal, we don't want to be in the business of creating our own AMIs, give that MCP has the concept of their own "golden" images we have to use.

complete

This has been done, the transition to Unity-DEV to Unity-CM went very well through this process.


Consider hiding empty workspaces in the menu

Summary
Version: AeroSpace v0.5.0-Beta 689fb92db5af7d3ccddf1899e0c00af5930c54dc
I don't think I'm ever going to be having 36 workspaces simultaneously. Others may, though. It would be nice if the workspaces listed in the menu bar were only the non-empty workspaces. An exception would be switching to an empty workspace to start opening some apps in. In this case, the solution could be to have the workspace shown in the label, and possibly also in the list of workspaces temporarily.
The arguments I could see against this consideration are:

Decreased visibility of what workspaces exist to choose from.
Difficulty opening a new workspace via point-and-click method.

One more argument for showing all workspaces:

Debug the config. Since 0.6.0, AeroSpace even shows the workspaces that are mentioned in the workspace-to-monitor-force-assignment to make mistakes in the config easier to debug

Difficulty opening a new workspace via point-and-click method

Yes, exactly. Keyboard users don't care about the menu. But mouse users can switch to all workspaces mentioned in the config

Yeah, that's fair. With the realization that I could remove the majority of the workspaces from the default configuration, I'm good with you closing this issue as well 👍


Cached pages in Get Started Sample

Ran through the get started sample. One thing I ran into was when I went to do the ToDo list portion I did not initially see the ToDo list nav link in the nav menu when I rendered the page. The browser was caching the first hit so removing the cached browser history allowed the todo list nav link to show up. I am using latest Chrome as the browser. I guess there is a question about cache busting here??

I see similar behaviour. Run counter component sample, then change the increase value step to i.e. 2 and run sample again. It will always go with += 1 and won't pick the changes unless the browser cache is disabled.

Is there any workaround for this? It is very annoying :( I have to stop the debugging and start over again in order for my changes to reflect on the screen. Ctrl+R is not working.

See: https://github.com/aspnet/Blazor/commit/b64218fa31cc2fce3825875e5dd4eb8995b00c3e

@miroslavp Why don't you simply disable browser caching for the time being?

Blazor currently does not supporting debugging and running under the debugger will actually cause issues when using Chrome. For now you should run without the debugger (Ctrl-F5) and refresh the browser as needed.

@MihaMarkic Which browser and version are you using?

@danroth27 Using current Firefox x64 59.0.2 on Windows. Currently, if I enable browser caching I get this error when refreshing:

Error: System.TypeLoadException: Could not find method due to a type load error

If I disable caching, then it works. So I can't even repro the original issue. I'm quite sure it wasn't updating the sample as well (without disabling cache).

So I can't even repro the original issue

Yeah, without a repro there's not much we can do here, but if you see this problem again, please do let us know.

@danroth27 While I can't repro the original issue, I can repro that it doesn't even load now when cache is enabled. Btw I'm using Release config and Ctrl+F5 to start.

@danroth27 Here, I've made a video for you. First refresh is with cache enabled, second is with cache disabled.

I think we need to look into why our static-file serving isn't producing the correct Etag headers, or if it is, what other cache-control headers are needed to get the correct cache invalidation behavior.

I'm not sure if my issue falls under the same category but I have to remove my bin/ and obj/ folder after each change and rebuild.
This is my setup:

.NET CLI 2.1.300-preview1-008174
Visual Studio Code Version 1.21.1
macOS 10.13.3

I tried the blazorhosted template

OK, it turns out we just weren't returning the correct cache-control header value.
This is now fixed in the code in dev, but if your browser has already cached old resources then you'll need to do a one-time manual clear of your browser cache to get rid of the old ones. After that, the caching should behave correctly. You should do this manual cache clearing after updating to the next version of Blazor of course. We intend to release 0.2.0 early next week.
Longer term, it would be good if our publishing process generated content-hashed URLs. Then we wouldn't need the browser to check for Etag-based modifications at all. It could just cache all compiled-file responses forever and not check with the server at all.


Could not find com.jakewharton:butterknife-gradle-plugin:9.0.0-20171223.061039-23

I'm trying to use ButterKnife in a library project.  I had been happily using the work around where we reference v9 snapshot.  After a new Android Studio update came down which also included an upgrade to gradle, a little cache clearing and a rebuild, now it doesn't work.
classpath 'com.jakewharton:butterknife-gradle-plugin:9.0.0-20171223.061039-23'

Could not find com.jakewharton:butterknife-gradle-plugin:9.0.0-20171223.061039-23.
Searched in the following locations:
    https://dl.google.com/dl/android/maven2/com/jakewharton/butterknife-gradle-plugin/9.0.0-SNAPSHOT/butterknife-gradle-plugin-9.0.0-20171223.061039-23.pom
    https://dl.google.com/dl/android/maven2/com/jakewharton/butterknife-gradle-plugin/9.0.0-SNAPSHOT/butterknife-gradle-plugin-9.0.0-20171223.061039-23.jar
    https://jcenter.bintray.com/com/jakewharton/butterknife-gradle-plugin/9.0.0-SNAPSHOT/butterknife-gradle-plugin-9.0.0-20171223.061039-23.pom
    https://jcenter.bintray.com/com/jakewharton/butterknife-gradle-plugin/9.0.0-SNAPSHOT/butterknife-gradle-plugin-9.0.0-20171223.061039-23.jar
    https://repo.maven.apache.org/maven2/com/jakewharton/butterknife-gradle-plugin/9.0.0-SNAPSHOT/butterknife-gradle-plugin-9.0.0-20171223.061039-23.pom
    https://repo.maven.apache.org/maven2/com/jakewharton/butterknife-gradle-plugin/9.0.0-SNAPSHOT/butterknife-gradle-plugin-9.0.0-20171223.061039-23.jar

I've tried to go to those https locations directly using the browser and there's no version 9.0 folder present.

You have to add the Sonatype snapshot repository. The link is in the README.
repositories {
  maven { url 'the url' }
}

The readme says:
To use Butter Knife in a library, add the plugin to your buildscript:

buildscript {
  repositories {
    mavenCentral()
   }
  dependencies {
    classpath 'com.jakewharton:butterknife-gradle-plugin:8.8.1'
  }
}

and then apply it in your module:

apply plugin: 'com.android.library'
apply plugin: 'com.jakewharton.butterknife'

You don't need the full number. Specifying 9.0.0-SNAPSHOT is enough and it
will auto-resolve the latest.
On Tue, Apr 10, 2018 at 4:23 AM Darryl T. Agostinelli <
<EMAIL_ADDRESS>wrote:

Ah! I see.
You have to go here in your browser to see what the full snapshot string
is:
https://oss.sonatype.org/content/repositories/snapshots/com/jakewharton/butterknife-gradle-plugin/
This works right now (but later if someone is reading this, you need to go
to the above URL and get the updated version number):
buildscript {
repositories {
google()
jcenter()
mavenCentral()
// TODO remove after butterknife 9 graduates to stable
maven {
name 'Sonatype SNAPSHOTs';
url 'https://oss.sonatype.org/content/repositories/snapshots/'
}
}
dependencies {
    classpath 'com.android.tools.build:gradle:3.1.0'
    classpath 'com.jakewharton:butterknife-gradle-plugin:9.0.0-20180329.192339-32'
}

}
—
You are receiving this because you modified the open/close state.
Reply to this email directly, view it on GitHub
https://github.com/JakeWharton/butterknife/issues/1243#issuecomment-379969554,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAEEEUSG92_1Xq4WGo483xDd7wMnwos5ks5tnDO9gaJpZM4TNkMo
.

Ah thanks. I see that now.  Like this:
buildscript {
    repositories {
        google()
        jcenter()
        mavenCentral()
        // TODO remove after butterknife 9 graduates to stable
        maven {
            name 'Sonatype SNAPSHOTs';
            url 'https://oss.sonatype.org/content/repositories/snapshots/'
        }

    }
    dependencies {
        classpath 'com.android.tools.build:gradle:3.1.0'
        classpath 'com.jakewharton:butterknife-gradle-plugin:9.0.0-SNAPSHOT'
    }
}

Yep!
On Tue, Apr 10, 2018 at 4:33 AM Darryl T. Agostinelli <
<EMAIL_ADDRESS>wrote:

Ah thanks. I see that now. Like this:
buildscript {
repositories {
google()
jcenter()
mavenCentral()
// TODO remove after butterknife 9 graduates to stable
maven {
name 'Sonatype SNAPSHOTs';
url 'https://oss.sonatype.org/content/repositories/snapshots/'
}
}
dependencies {
    classpath 'com.android.tools.build:

gradle:3.1.0'
classpath 'com.jakewharton:butterknife-gradle-plugin:9.0.0-SNAPSHOT'
}
}
—
You are receiving this because you modified the open/close state.
Reply to this email directly, view it on GitHub
https://github.com/JakeWharton/butterknife/issues/1243#issuecomment-379970761,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAEEESIUpOhhUrs7kAXVFbxKq2QVwDwZks5tnDYbgaJpZM4TNkMo
.

Could not find com.jakewharton:butterknife-gradle-plugin:9.0.0-SNAPSHOT.
Searched in the following locations:
https://plugins.gradle.org/m2/com/jakewharton/butterknife-gradle-plugin/9.0.0-SNAPSHOT/maven-metadata.xml
https://plugins.gradle.org/m2/com/jakewharton/butterknife-gradle-plugin/9.0.0-SNAPSHOT/butterknife-gradle-plugin-9.0.0-SNAPSHOT.pom
https://plugins.gradle.org/m2/com/jakewharton/butterknife-gradle-plugin/9.0.0-SNAPSHOT/butterknife-gradle-plugin-9.0.0-SNAPSHOT.jar
https://jcenter.bintray.com/com/jakewharton/butterknife-gradle-plugin/9.0.0-SNAPSHOT/maven-metadata.xml
https://jcenter.bintray.com/com/jakewharton/butterknife-gradle-plugin/9.0.0-SNAPSHOT/butterknife-gradle-plugin-9.0.0-SNAPSHOT.pom
https://jcenter.bintray.com/com/jakewharton/butterknife-gradle-plugin/9.0.0-SNAPSHOT/butterknife-gradle-plugin-9.0.0-SNAPSHOT.jar
https://repo.maven.apache.org/maven2/com/jakewharton/butterknife-gradle-plugin/9.0.0-SNAPSHOT/maven-metadata.xml
https://repo.maven.apache.org/maven2/com/jakewharton/butterknife-gradle-plugin/9.0.0-SNAPSHOT/butterknife-gradle-plugin-9.0.0-SNAPSHOT.pom
https://repo.maven.apache.org/maven2/com/jakewharton/butterknife-gradle-plugin/9.0.0-SNAPSHOT/butterknife-gradle-plugin-9.0.0-SNAPSHOT.jar
https://maven.google.com/com/jakewharton/butterknife-gradle-plugin/9.0.0-SNAPSHOT/maven-metadata.xml
https://maven.google.com/com/jakewharton/butterknife-gradle-plugin/9.0.0-SNAPSHOT/butterknife-gradle-plugin-9.0.0-SNAPSHOT.pom
https://maven.google.com/com/jakewharton/butterknife-gradle-plugin/9.0.0-SNAPSHOT/butterknife-gradle-plugin-9.0.0-SNAPSHOT.jar
https://dl.google.com/dl/android/maven2/com/jakewharton/butterknife-gradle-plugin/9.0.0-SNAPSHOT/maven-metadata.xml
https://dl.google.com/dl/android/maven2/com/jakewharton/butterknife-gradle-plugin/9.0.0-SNAPSHOT/butterknife-gradle-plugin-9.0.0-SNAPSHOT.pom
https://dl.google.com/dl/android/maven2/com/jakewharton/butterknife-gradle-plugin/9.0.0-SNAPSHOT/butterknife-gradle-plugin-9.0.0-SNAPSHOT.jar

@JakeWharton  When onLick the urls, The requested path was not found. shows on webpage

the plugin version is :         classpath 'com.android.tools.build:gradle:3.0.1'
and gradle is 4.4


fix(fmt): don't format shell files in .bootstrap

What this PR does / why we need it
I noticed that during make fmt, shfmt was formatting files in devbase, which is a waste of computing power since that folder gets regenerated every time the devbase version changes.
Jira ID
N/A
Notes for your reviewer
That being said, validate.sh should run on this repo in CI so that shfmt wouldn't rewrite the files to begin with.

:tada: This PR is included in version 1.27.2 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


React step 5

Closes #
{{short description}}
Changelog
New

Application deployed in IBM Cloud

Changed

Add deploy script in package.json file

Removed

Some needless styles import

http://carbon-tutorial-zoranyankov.mybluemix.net/


Client disconnects at 2 hours 4 minutes logged in

Type
Crash or hang
Operating System
Windows
OS Version
Microsoft Windows 11 Home 10.0.22631 Build 22631
Bug description
This issue does occur in safe mode.
Every time I reach exactly 2 hours and 4 minutes logged in, my game will disconnect. It looks like a network disconnect - all players and npcs stop moving, my inputs are not accepted, and the game eventually displays the "disconnected" icon on the top left. A few seconds after the disconnected icon shows up, it reconnects without kicking me to the login screen.
My computer has no network issues with other services during this time. Streaming and other new web requests work fine while runelite is disconnected.
There are other reports of this issue:

https://www.reddit.com/r/2007scape/comments/1bxv35r/anyone_elses_runelite_always_disconnects_after/
https://www.reddit.com/r/2007scape/comments/zawj8s/disconnecting_at_a_consistent_interval_and_need/
But no solutions.

Screenshots or videos
No response
RuneLite version
RuneLite version: 1.10.44
Launcher version: 2.6.9
Logs
client_logs.txt
launcher.log

Oh my god. Thank you. I do. Smartest man on the planet


We couldn't load Uchiwa configuration

Expected Behavior

Current Behavior

Possible Solution

Steps to Reproduce (for bugs)

curl -vk localhost:3000

Context

Your Environment

Uchiwa version used: 1:1.3.1-1
Sensu version used: 1:1.4.3-1.el7
Operating System and version (e.g. Ubuntu 14.04): centOS 7

Updated configuration.


Image size change between 2.2 & 2.3

Description
I use the Xamarin.Forms plugin and on iOS the size of all my images changed after the 2.3.1 update.
Here a sample before the update :
https://ibb.co/eJByGy
And after the update :
https://ibb.co/cyWLUJ
Steps to Reproduce
Install the 2.2.25 Xamarin.FFImageLoading.Forms plugin on your app.
Add an image in XAML to the main page :
<ffimageloading:CachedImage Source="..." HorizontalOptions="Center" HeightRequest="80" />
See the result.
Update the plugin to 2.3.1.
See the difference between the previous result.
Expected Behavior
The images size should stay the same the version between the versions without any release note explaining this kind of big changes.
Basic Information

Version with issue: 2.3.1
Last known good version: 2.2.25
Platform: iOS with Xamarin.Forms

See release note.


Write support double precision IDF files

In GitLab by @jc-hunink on Jan 11, 2022, 16:22
Reading of Double precision IDF files is supported. Saving an float64 xarray to idf, a single precision idf file is saved.
da64=imod.idf.open([DP_idf.IDF](https://gitlab.com/deltares/imod/imod-python/uploads/aa13a72fe6007dff5ef67ee3d50df670/DP_idf.IDF))
print(da64.dtype)
imod.idf.save('temp.idf',da64)

In GitLab by @Huite on Mar 24, 2022, 10:19
Added to the docstring, which indeed missed the description of the argument.
cf9d69d57ed201fcd646f969637557d80dc67eab

In GitLab by @Huite on Jan 11, 2022, 22:19
This is already possible by specifying the dtype argument in the save call:
imod.idf.save("temp", da, dtype=np.float64)

Automatically writing to 64bit IDF when the DataArray dtype is 64bit is a recipe for pain because of haphazard support of 64bit IDFs in general -- e.g. I ran into an issue with iMOD-WQ a while ago (which may have been fixed). Note that Python defaults to 64 bit floats on our machines, so changing it to respect the Python type will result in 64 bit IDFs almost exclusively.
Saving to a 64bit IDF is (in my opinion) a risky choice because IDF-IO is not consistent between all iMOD products (iMODFLOW/iMOD GUI/iMOD-WQ). These products can be relied on to work with 32bit IDF, so 32bit should remain the default.


[HB-3942] Toggle success/failure

oh also don't forget to update the version number (I'll leave it up to you if you want to do 1.1.0 or 1.0.2) and publish it when you're done with this


#N/A: Add git_bisect_usage rule

Coverage increased (+0.04%) to 92.937% when pulling c9264aff10a153ee7260840d1d69fdd5ab39cd73 on scorphus:git-bisect-usage into 9660ec7813a0e77ec3411682b0084d07b540084e on nvbn:master.

Thanks!


faulty reading hudi table after it has beed altered

Describe the bug
General Description
While reading data from a hudi table with daft.read_hudi() we are getting an error that is caused due to a miss-match of the columns.
Setup

Our Hudi COW table is hosted on S3.
After the initial setup, we modified the table by updating the Avro schema (.avsc file) and adding two new string columns in between our existing columns schema.
For new data, these columns started populating correctly, while for existing rows, these new columns are null.

When running
dfd = daft.read_hudi('s3://path/to/hudi')
dfd.columns   # this is Ok and returns correct column names
dfd.schema()  # this is OK and returns correct schema

dfd.show()  # we get an error
> ArrowTypeError: Expected XXXX, got a YYYY  object

# Or on a different altered hudi table
> ArrowInvalid: Could not convert 'Florida' with type str: tried to convert to double

In both cases the type it is trying to use is the one prior to the alteration of the table
When reading a hudi table that has not been altered there is no problem.
We are using

getdaft==0.3.3
hoodie.table.version=5

Any suggestions?

Hello! This might be a pyhudi error -- cc @xushiyan from the Hudi team for any thoughts
We are currently awaiting the Hudi team's implementation of Hudi-rs which would give us more robust support for Hudi

Just adding additional context
It seams to be an Avro vs. Arrow issue.
When trying to use  hudi-rs  we also get  an error:

ArrowInvalid: Schema at index X was different

this is an example of what we are running
from hudi import HudiTable  # pip install hudi
import pyarrow as pa

hudi_path=f's3://path/to/hudi/table'
hudi_table = HudiTable(hudi_path)
records = hudi_table.read_snapshot()
arrow_table = pa.Table.from_batches(records)

The schema of the records are not the same.

Ok yeah this might be a Hudi issue in general then. Do you mind filing an issue against hudi-rs and linking that issue here please @sephib ?


Tip: Use HMIP-BSM for controlling a HomeKit lamp

In my daughters room I have a HMIP-BSM (Light switch) and now she wanted a lamp that can change the color. The bulb is a VOCOLinc L3 bulb that can be fully controlled via HomeKit via Wifi and prefers to receive constant power. I wanted the BSM to deliver constant power but wanted to use it for controlling this lamp.
The BSM has the following setup:

Channel 1: Sensor for light off
Channel 2: Sensor for light on
Channel 3: Actor for the light

Channel 1,2 and 3 are coupled by default. They need to be decoupled. The actor is configured to be permanently on. Channel 1 and 2 are exposed as HomeMaticKeyAccessory:

They appear as programmable switches:

They now can be coupled with the actual HomeKit lamp. Upon light on you can configure the level (0-100%) and the color. The result is, that the switch behaves like expected and the lamp receives permanent color.

@thkl kann man diesen guten Beitrag ins Wiki verschieben?

Muss ich kopieren aber ja.  Bitte bei Bedarf verschieben!


osu!lazer gives error when game opens

When attempting to place the ruleset in the ruleset folder and open the game, the following error occurs:

Fixed in latest release
Thanks for reporting! :)


updates Coraza to v3.0.1-0.20230614023334-2fd87b892906

Notably:

Updates Coraza beyond v3.0.0
Includes SecArgumentsLimit directive implementation (https://github.com/corazawaf/coraza/pull/812)

I'd rather not use non releases at this point. Is there any specific feature or bugfix you want to pull in?


Issue in mapping existing nested objects

https://groups.google.com/forum/#!msg/modelmapper/WZM6lKUv6QA/on_pqeekBgAJ

This is similar to #224 and please reference my comment.
I will close this issue for now (As there is a similar issue and this issue had been pending for a long time). But please feel free to reopen it 😄

Sorry, it seems different to #217 or #224 after investigation...

This had been release at modelmapper v1.0.0!


bw2io.bw2setup() error on osx-arm64

Hello,
I am trying to run the ecoinvent import example from brightway documentation on my m2 mac
(https://docs.brightway.dev/en/latest/content/examples/brightway-examples/data_import/ecoinvent_import.html)
I am using this library: brightway25_nosolver version 1.0.6 build py_4 (following the installation instructions)
Calling bw2io.bw2setup() raises the following error:
"AttributeError: 'Config' object has no attribute 'is_test'"
(full error code is attached below)
It looks like the Config class indeed does not have
I have tested with previous builds and still have errors,
I have done a clean reinstall of my environments (including conda resinstalls through mambaforge since anaconda did not work out)
Many thanks in advance!
Adrien
Below the full error code:
AttributeError                            Traceback (most recent call last)
Cell In[14], line 3
(...)
----> 3 bw2io.bw2setup()
(...)
File /opt/homebrew/Caskroom/mambaforge/base/envs/bw25ns/lib/python3.11/site-packages/bw2io/init.py:150, in bw2setup()
148     return
149 print("Creating default biosphere\n")
--> 150 create_default_biosphere3()
151 print("Creating default LCIA methods\n")
152 create_default_lcia_methods()
File /opt/homebrew/Caskroom/mambaforge/base/envs/bw25ns/lib/python3.11/site-packages/bw2io/init.py:112, in create_default_biosphere3(overwrite)
110 eb = Ecospold2BiosphereImporter()
111 eb.apply_strategies()
--> 112 eb.write_database(overwrite=overwrite)
File /opt/homebrew/Caskroom/mambaforge/base/envs/bw25ns/lib/python3.11/site-packages/bw2io/importers/base_lci.py:278, in LCIImporter.write_database(self, data, delete_existing, backend, activate_parameters, db_name, searchable, **kwargs)
275 self.write_database_parameters(activate_parameters, delete_existing)
...
466         index, key, ds, exchanges, activities
467     )
469 if activities:

Reproduced on a windows machine on the latest build.

@Phurga , can you please give the exact version of bwio you have?
import bw2io as bi
print(bi.__version__)

(0, 9, 'DEV21')

Sorry about this, I prematurely merged code incorporating https://github.com/brightway-lca/bw_projects, but this was premature. Please install bw2data 4.0.dev29 from the conda channel cmutel or from pypi, this should fix things.

Excellent, I now have a working environment!! Many thanks @cmutel :)


iphone x 15.5 tips app crash

buntu@ubuntu:~/Downloads/palera1n$ sudo bash ./palera1n.sh --debug
palera1n | Version 1.0.0-9219d27
Written by Nebula | Some code and ramdisk from Nathan | Patching commands and help from Mineek | Loader app by Amy
Hello, iPhone10,3 on 15.5!
[] Switching device into recovery mode...
Telling device with udid 1e3b6f049dcc520a99a6d0d02925f6b31033a3b1 to enter recovery mode.
Device is successfully switching to recovery mode.
[] Waiting for device to reconnect in recovery mode
[] Getting device info...
[] Press any key when ready for DFU mode
Get ready (0)
Hold volume down + side button (0)
Keep holding (0)
Release side button, but keep holding volume down (0)
[] Device entered DFU!
[] Pwning device
usb_timeout: 10
[libusb] Waiting for the USB handle with VID: 0x5AC, PID: 0x1227
CPID: 0x8015
Found the USB handle.
Stage: RESET
ret: true
[libusb] Waiting for the USB handle with VID: 0x5AC, PID: 0x1227
CPID: 0x8015
Found the USB handle.
Stage: SPRAY
ret: true
[libusb] Waiting for the USB handle with VID: 0x5AC, PID: 0x1227
CPID: 0x8015
Found the USB handle.
Stage: SETUP
ret: true
[libusb] Waiting for the USB handle with VID: 0x5AC, PID: 0x1227
CPID: 0x8015
Found the USB handle.
Stage: PATCH
ret: true
[libusb] Waiting for the USB handle with VID: 0x5AC, PID: 0x1227
CPID: 0x8015
Found the USB handle.
Now you can boot untrusted images.
[] Converting blob
img4tool version: 0.197-aca6cf005c94caf135023263cbb5c61a0081804f-RELEASE
Compiled with plist: YES
Saved IM4M to work/IM4M
[] Downloading BuildManifest
Version: 3fc8c093f4660f6c6e07c0c9214618733da01ffc - 36
libfragmentzip version: 0.60-120447d0f410dffb49948fa155467fc5d91ca3c8
init pzb: https://updates.cdn-apple.com/2022SpringFCS/fullrestores/012-08019/9B77837B-6568-45E6-8C0F-3BC5B952371B/iPhone10,3,iPhone10,6_15.5_19F77_Restore.ipsw
init done
getting: BuildManifest.plist
100% [===================================================================================================>]
download succeeded
[] Downloading and decrypting iBSS
Version: 3fc8c093f4660f6c6e07c0c9214618733da01ffc - 36
libfragmentzip version: 0.60-120447d0f410dffb49948fa155467fc5d91ca3c8
init pzb: https://updates.cdn-apple.com/2022SpringFCS/fullrestores/012-08019/9B77837B-6568-45E6-8C0F-3BC5B952371B/iPhone10,3,iPhone10,6_15.5_19F77_Restore.ipsw
init done
getting: Firmware/dfu/iBSS.d22.RELEASE.im4p
100% [===================================================================================================>]
download succeeded
usb_timeout: 10
[libusb] Waiting for the USB handle with VID: 0x5AC, PID: 0x1227
CPID: 0x8015
Found the USB handle.
Now you can boot untrusted images.
[libusb] Waiting for the USB handle with VID: 0x5AC, PID: 0x1227
Found the USB handle.
[] Downloading and decrypting iBEC
Version: 3fc8c093f4660f6c6e07c0c9214618733da01ffc - 36
libfragmentzip version: 0.60-120447d0f410dffb49948fa155467fc5d91ca3c8
init pzb: https://updates.cdn-apple.com/2022SpringFCS/fullrestores/012-08019/9B77837B-6568-45E6-8C0F-3BC5B952371B/iPhone10,3,iPhone10,6_15.5_19F77_Restore.ipsw
init done
getting: Firmware/dfu/iBEC.d22.RELEASE.im4p
100% [===================================================================================================>]
download succeeded
usb_timeout: 10
[libusb] Waiting for the USB handle with VID: 0x5AC, PID: 0x1227
CPID: 0x8015
Found the USB handle.
Now you can boot untrusted images.
[libusb] Waiting for the USB handle with VID: 0x5AC, PID: 0x1227
Found the USB handle.
[] Downloading DeviceTree
Version: 3fc8c093f4660f6c6e07c0c9214618733da01ffc - 36
libfragmentzip version: 0.60-120447d0f410dffb49948fa155467fc5d91ca3c8
init pzb: https://updates.cdn-apple.com/2022SpringFCS/fullrestores/012-08019/9B77837B-6568-45E6-8C0F-3BC5B952371B/iPhone10,3,iPhone10,6_15.5_19F77_Restore.ipsw
init done
getting: Firmware/all_flash/DeviceTree.d22ap.im4p
100% [===================================================================================================>]
download succeeded
[] Downloading AOP
Version: 3fc8c093f4660f6c6e07c0c9214618733da01ffc - 36
libfragmentzip version: 0.60-120447d0f410dffb49948fa155467fc5d91ca3c8
init pzb: https://updates.cdn-apple.com/2022SpringFCS/fullrestores/012-08019/9B77837B-6568-45E6-8C0F-3BC5B952371B/iPhone10,3,iPhone10,6_15.5_19F77_Restore.ipsw
init done
getting: Firmware/AOP/aopfw-iphone10baop.im4p
100% [===================================================================================================>]
download succeeded
[] Downloading trustcache
Version: 3fc8c093f4660f6c6e07c0c9214618733da01ffc - 36
libfragmentzip version: 0.60-120447d0f410dffb49948fa155467fc5d91ca3c8
init pzb: https://updates.cdn-apple.com/2022SpringFCS/fullrestores/012-08019/9B77837B-6568-45E6-8C0F-3BC5B952371B/iPhone10,3,iPhone10,6_15.5_19F77_Restore.ipsw
init done
getting: Firmware/078-12315-101.dmg.trustcache
100% [===================================================================================================>]
download succeeded
[] Downloading kernelcache
Version: 3fc8c093f4660f6c6e07c0c9214618733da01ffc - 36
libfragmentzip version: 0.60-120447d0f410dffb49948fa155467fc5d91ca3c8
init pzb: https://updates.cdn-apple.com/2022SpringFCS/fullrestores/012-08019/9B77837B-6568-45E6-8C0F-3BC5B952371B/iPhone10,3,iPhone10,6_15.5_19F77_Restore.ipsw
init done
getting: kernelcache.release.iphone10b
100% [===================================================================================================>]
download succeeded
[] Patching and signing iBSS/iBEC
main: Starting...
iOS 15 iBoot detected!
getting get_debug_enabled_patch() patch
getting get_sigcheck_patch() patch
applying patch=0x180030ad0 : 000080d2
applying patch=0x180030b18 : 000080d2
applying patch=0x18003289c : 200080d2
main: Writing out patched file to iBSS.patched...
main: Quitting...
main: Starting...
iOS 15 iBoot detected!
getting get_boot_arg_patch(-v keepsyms=1 debug=0xfffffffe panic-wait-forever=1 wdt=-1) patch
getting get_debug_enabled_patch() patch
getting get_sigcheck_patch() patch
applying patch=0x180030ad0 : 000080d2
applying patch=0x180030b18 : 000080d2
applying patch=0x18003289c : 200080d2
applying patch=0x180033e14 : 78b80c10
applying patch=0x18004d520 : 2d76206b65657073796d733d312064656275673d307866666666666666652070616e69632d776169742d666f72657665723d31207764743d2d3100
main: Writing out patched file to iBEC.patched...
main: Quitting...
none
none
[] Patching and signing kernelcache
Reading work/kernelcache.release.iphone10b...
[NOTE] Image4 payload data is LZFSE compressed, decompressing...
Extracted Image4 payload data to: work/kcache.raw
main: Starting...
Kernel: Adding AMFI_get_out_of_my_way patch...
get_amfi_out_of_my_way_patch: Entering ...
get_amfi_out_of_my_way_patch: Kernel-8020 inputted
get_amfi_out_of_my_way_patch: Found Internal Error: No cdhash found. str loc at 0x39c685
get_amfi_out_of_my_way_patch: Found Internal Error: No cdhash found. str ref at 0x12ca924
get_amfi_out_of_my_way_patch: Patching AMFI at 0x12c7160
Kernel: Adding could_not_authenticate_personalized_root_hash patch...
get_could_not_authenticate_personalized_root_hash_patch: Entering ...
get_could_not_authenticate_personalized_root_hash_patch: Found "successfully validated on-disk root hash" str loc at 0x52474d
get_could_not_authenticate_personalized_root_hash_patch: Found "successfully validated on-disk root hash" xref at 0x1db4428
get_could_not_authenticate_personalized_root_hash_patch: Found previous cbz at 0x1db4404
get_could_not_authenticate_personalized_root_hash_patch: Found "could not authenticate personalized root hash!" str loc at 0x5246a2
get_could_not_authenticate_personalized_root_hash_patch: Found "could not authenticate personalized root hash!" xref at 0x1db4974
get_could_not_authenticate_personalized_root_hash_patch: Found cbz target at 0x1db4954
get_could_not_authenticate_personalized_root_hash_patch: Patching root hash check at 0x1db4954
main: Writing out patched file to work/kcache.patched...
main: Quitting...
Reading work/kcache.patched...
Compressing payload using LZSS...
IM4P outputted to: work/krnlboot.im4p
Reading work/krnlboot.im4p...
Reading work/IM4M...
Creating Image4...
Image4 file outputted to: boot-iPhone10,3/kernelcache.img4
[] Signing DeviceTree
dtre
[] Signing AOP
aopf
[] Patching and signing trustcache
trst
none
[] Booting device
[==================================================] 100.0%
[==================================================] 100.0%
[==================================================] 100.0%
[==================================================] 100.0%
[==================================================] 100.0%
[==================================================] 100.0%
[==================================================] 100.0%
Done!
The device should now boot to iOS
If you already have ran palera1n, click Do All in the tools section of Pogo
If not, Pogo should be installed to Tips
ubuntu@ubuntu:~/Downloads/palera1n$

after this when i open tips app it crashes

after this when i open tips app it crashes

Yes, I have the same problem as you.

Same

iPhone 7+ 15.2 here, same problem. sh told me to install the "Tips" app from the app store and try again. never installed pogo and it broke the tips app.

same, how to solve this?

maybe if u download my tips ipa on my profile and then install it with troll store and then delete it the Tips app will work


Adds deltaTime support and example

The current CMake-GLfw-OpenGL-Template does not show the use of deltaTime, the elapsed time between frames, for framerate independent calculations. This is a very commonly used functionality, and so I decided to make a fork of it.
This method uses a Getter method to retrieve deltaTime(). Other examples, such as Fwog, passes in deltaTime as a parameter to Update() type functions, but I chose a getter as inspired by Unity's Time.deltaTime.
Another option could be to have a static deltaTime variable or a protected one accessible by child members, but I figured a getter might be a better starting point despite the minor overhead due to being quite explict that deltaTime is managed by the parent library.

Example in scene was an elapsed time counter


Implemented Frame Size Negotiation in ALTS for gRPC C++.

gRPC C++ uses zero copy frame protectors, and hence are capable of handling larger frame size. Frame Size Negotiation support in ALTS, extends send frame size from 16KB to 128KB, and thereby improves performance. It also enables the propagation of user specified max frame size (set via channel argument), in which case we use this value for negotiation instead of default max frame size (=128KB).
Design Document: go/seal-frame-size-negotiation-alts

@ashithasantosh Please squash the commit once all tests has passed. I will merge.

Oops, I thought the commits are squashed.


New package: Crossterm v0.1.0

Registering package: Crossterm
Repository: https://github.com/kdheepak/Crossterm.jl
Created by: @kdheepak
Version: v0.1.0
Commit: c8624f18ab36e6a9c44e954a1f50c93a471513ac
Reviewed by: @kdheepak
Reference: https://github.com/kdheepak/Crossterm.jl/commit/c8624f18ab36e6a9c44e954a1f50c93a471513ac#commitcomment-122353939

Please make sure to add some documentation before registering, at least a description and basic usage information in the README

Thanks for the comment. I've added documentation. I'll close this PR and open a new one again.

It looks like I can't close this PR? I've made a new PR. This one can be closed.

In general, you can just re-trigger registration on the new commit. It’s not necessary to make a new PR or to bump the version number. Try it on the new PR for fixing the compat issue.
This PR will be closed automatically after 30 days.

@goerz can you edit your comments to have [noblock] in them?
[noblock]


feat(NODE-3728): Allow to pass authorizedCollections option to the db.listCollections method

Description
This patch allows to pass authorizedCollections option when using db.listCollections method
What is changing?
ListCollectionsOperation class now has authorizedCollections defined and handled in a similar fashion to the nameOnly option
Is there new documentation needed for these changes?
Not needed (I think)
What is the motivation for this change?
This adds support for a listCollections command option that is helpful when you want to fetch a list of collections for the user that might not have enough privileges to list them otherwise. A full description can be found in the listCollections command docs

Double check the following

[x] Ran npm run check:lint script
[x] Ran npm run test script
[x] Self-review completed using the steps outlined here
[x] PR title follows the correct format: <type>(NODE-xxxx)<!>: <description>
[x] Changes are covered by tests

@gribnoysup There was a CI issue that blocked all tests from running which necessitated a change to main for the fix, could you rebase your branch to pull them in here?

Thanks for the heads-up @dariakp! Rebased on main

@dariakp ty for the feedback! Applied suggestions in fa8a514


OutOfService Load Balancers

All 3 load balancers have a status of OutOfService with the error;
Instance has failed at least the UnhealthyThreshold number of health checks consecutively.
Here are the versions I'm using
awscli 1.14.20
cfssl 1.2.0_2
jq 1.5_2
kubernetes-cli 1.9.1
terraform 0.11.2
Any ideas on what is causing this or how to troubleshoot?
Thanks
Jeff

I tried changing the instance types to no avail in io.tf:
    bastion = "t2.micro"
    pki = "t2.micro"
    etcd = "m4.large"
    worker = "m4.large"

Same problem. Did you find a solution?

Finally found the solution:
add the line:
Environment="ETCD_IMAGE_TAG=v3.1.11"
to worker/cloud-config.yml and etcd/cloud-config.yml

I think this is due to the fact that the ELB is in the public subnet: tack/modules/etcd/elb.tf:24 but it tries to attach to the etcd nodes which run in the private subnet: tack/modules/etcd/ec2.tf:17

The same solution mentioned in @LucasR93's post worked for me; I tried with etcd v3.1.6 though. The existing deployment seems not compatible with etcd v3.2.0+. I am yet to dig into why deployment fails with latest etcd. In the meantime, the etcd version should be pinned down to v3.1.X to prevent users of this repo encountering a broken cluster deployment.
@wellsie would you like to get a PR with the etcd version pinned down until compatibility is restored for latest version?


feat: allow washover-time int

Codecov Report
Patch coverage: 83.33% and project coverage change: -0.14 :warning:

Comparison is base (e3f1d9b) 98.08% compared to head (a718a94) 97.95%.

:exclamation: Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #120      +/-   ##
==========================================
- Coverage   98.08%   97.95%   -0.14%
==========================================
  Files           9        9
  Lines         680      684       +4
==========================================
+ Hits          667      670       +3
- Misses         13       14       +1

Impacted Files
Coverage Δ

cluster_experiments/washover.py
96.96% <75.00%> (-3.04%)
:arrow_down:

cluster_experiments/power_config.py
100.00% <100.00%> (ø)

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

would you add a test for the int case? or is it too dummy?

Yes, I can. In which test file would you add it?

would you add a test for the int case? or is it too dummy?

Yes, I can. In which test file would you add it?

I guess in https://github.com/david26694/cluster-experiments/blob/main/tests/power_analysis/test_switchback_power.py
or https://github.com/david26694/cluster-experiments/blob/main/tests/splitter/test_washover.py, but perhaps a new one  in splitter/ makes sense too


implement Crone of Vaes Dothrak

[ reopening after inadvertent close due to branch reorganization on my fork ]
A few points worth noting:
I had to had a new game event "onCardDiscardedFromDraw", because apparently there isn't an event raised upon pillage and similar effects. I guess a better long-term solution for this situations would be a generic "onCardMove(source, target)" event, but I didn't feel like starting that journey. If I'm missing a better way to do this, please let me know.
I'm not sure how much automation should go into verifying the starting condition of this card. I've decided to be minimal for now, so for instance the player will be prompted to trigger Crone even if they have no standing Dothraki character. If you think that part should be automated, just let me know.

Per my comments in Discord, the bigger problem is that the onCardDiscarded event was only being fired when you dragged a card to the discard pile. Really it should be fired any time a discard happens.
Rather than introduce a specific event for having discarded from draw, I think it may be more reasonable to add an original location parameter to the event and check that. Otherwise we need 3 separate events - discarded from hand, discarded from draw, discarded from play. If you pull in this commit it should get rid of the need for the onCardDiscardedFromDraw event: https://github.com/ystros/throneteki/commit/b1610c3d687f9fd555048e4e7ee47a5095017398
(example usage w/ LoCR Cersei here: https://github.com/ystros/throneteki/commit/ebb6992860e10a48680c1e0ebfe17fb572c54aff)
Regarding automation, kneeling a Dothraki character is part of the cost for the reaction and generally we've been checking that the cost can be paid before prompting the user. We haven't been perfect about it, but it would probably be good to check if they have a standing Dothraki.

Oops. I went a bit too far on the previous commit, broke some tests. I edited the commits in the previous message, check https://github.com/ystros/throneteki/commit/536c48c2f4e9be12e336c191f5556a0e3a5137b5 instead.

@ystros: that generalization of onCardDiscarded is just perfect! It's indeed what I wanted to have, but didn't dare implementing it myself for fear or unexpected consequences :)
I've now cherry picked your commit in this pull request, reworked the base card implementation to rely on it, and also made the user prompt for using it conditional on the availability of standing Dothraki characters.


Redirect users to new jsonp location

@afeld we see a fair amount of Tweets to @nodejitsu (e.g. https://twitter.com/jmayer881/status/577898590175133698) whenever something changes to jsonp.nodejitsu.com. I would suggest having the existing URL return something about redirecting to the new Heroku-based deployment

For sure. Will do as part of https://github.com/afeld/jsonp/issues/48. Thanks!

P.S. Sorry that you get the flak!


Tooltip zoomed along with map

Hi,
I am working on a world map with zoom and pan. I draw circles on certain cities and the radius of the circle is determined by the data. When mouse over these circle then a tooltip will show up displaying the data.
The structure of the code is
<div>
   <svg>
          <g> // Zoom behavior is called on this selection   - lets call this parentGroup
              <rect>
                         // To capture all mouse and touch events
              </rect>
              <g>   // Call this childGroup
                   <path land>
                   <path boundary>
                   <circles>
                   <g>
                          // Tooltip group hidden - will show/hide on mouseover
                          // Call this toolTipGroup
                   </g>
              </g>
         </g>
  </svg>
</div>

The problem here is

If the toolTipGgroup is attached to parentGroup and lives as a sibling to the childGroup then when the map is zoomed the tip position is messed up. I tried getting the (x,y) from the projection and applied a translate(x,y) on the tooltip. The tooltipGroup is translated but its irrelavant since zoom applied.

If the toolTipGroup is attached to the childGroup, when the map is zoomed the toolTipGroup position is intact but its zoomed along with the childGroup.

@mbostock

Please use Stack Overflow tag d3.js or the d3-js Google group for help. These issues are for feature requests and bug reports only.


automerge: tolerate _ in symbol schema

Do we really want this? Might cause compatibility issues with wallets assuming the original Uniswap schema


RunProcess arguments should be pre-processed using AbsoluteFileName

RunProcess's argument should be pre-processed with AbsoluteFileName.
Do this in the runProcess function.
User complaint: / separators don't work on Windows.  ~ also does not work on Mac.

I decided not to fix this:

In recent versions (11.2+?) RunProcess handles / as a path separator just fine on Windows
/ is not correct path separator on Windows anyway, and users can fix this on their end very easily (use the correct path separator)
In some older versions of Mathematica, RunProcess misbehaves on non-English versions of Windows when paths contain non-ASCII characters.  The typical workaround is to set an explicit working directory which may have a short 8.3 path name.  AbsoluteFileName would change the short path name to a long one, bringing back the problems.

The best compromise is to leave things as they are.
Eventually all these problems will go away as people stop using old Mathematica versions.


Add test for EAP7-1984

Hi, this PR adding test coverage for EAP7-1984. It's cover added provisioning which was added in HAL-1827.
The added test coverage should be working only with EAP. When working with WildFly none of these pages should be visible.
Homepage test
HAL-1827 removing the update server by patch command and adding updating by installer command. This PR updating the homepage patch test to homepage update-manager test. This test will run only with EAP as with WildFly this should not be visible.
Update-manager
Adding test coverage for installer functions. That is online and offline update from channel, update by custom patch and add/remove/update channel. These test should be run only with EAP server provisioned by installer. With WildFly these function should not be visible and not working.

@jedla97 Can you update the summary of the PR and and the second commit to be more descriptive please? Something like "HAL-1827 Adding tests for the new server update mechanism" could work.

Please also add update-manager into the modules that are executed via GH actions scheduled-run-all-tests-workflow.yaml and https://github.com/hal/berg/blob/main/.github/workflows/manual-test-matrix-workflow.yaml

PR description updated, commit description updated. Added small change to homepage test because of JBEAP-24978.
@spriadka I added it to GH actions, but it's need to be excluded as this should be only EAP feature and should not work with WildFly.

@jedla97 Okay, rebase please and I'll merge it. We'll adjust the testsuite for EAP specific stuff later


⚠ Bofrost.be has degraded performance

In c5bb999, Bofrost.be (https://www.bofrost.be) experienced degraded performance:

HTTP code: 200
Response time: 1521 ms

Resolved: Bofrost.be performance has improved in 1e7299b.


Glitch Chooser: Apply button not working

Hello!
For the past 2 years I've noticed that Glitch Cruiser works with all the glitch methods, but Glitch Chooser doesn't apply changes to the image, so it's broken. Additionally, when no change has been made to the picture, and the "Original" method is applied, the picture will move to the right of the browser and a small rectangle.
Thanks!

This is a core problem in the File API -- browsers have decided that any time a file is loaded from a person's computer to a browser it's a "Cross-Origin" maneuver, and therefore any manipulation of the image could be a security breach -- I've been working off and on on a way to solve this, but it looks like I'd need to be able to upload the image to a server before allowing it to be manipulated, and this code specifically works by avoiding doing that. Unfortunately, time marches on and browsers have made decisions far outside of my control. (Another thought I had was making this a downloadable tool/app - but I'm not sure if that would solve the problem, I haven't experimented much with Electron.)


Remove build resource

Open this issue according to the Contributing page
When I went to the project, I found that the build/ folder was pushed, too. Best practice is to add all build related filed to .gitignore and avoid pushing them.
What should be done:

remove useless folder ./Facial-Recognition/build
add .gitignore file to make sure, that next time it won't be pushed.

Best regards,
Roman.

Also, I found Netbeans files, which is not good, either.
I should be added to .gitginore, too.
Best regards,
Roman.

Oh, thanks!! Did you make the changes? You can contribute with the project!

Ok, I'll do it

@king-aspx, added PR.


Handle auto-close when system clock is after auto-close-time and no d…

…ata is being received.
WIP because of all the comments and logging, will clean it up.
This introduces a new boolean dataStopped that once true and no data is being received stops the autoCloseTimer from being reset. This means the cli will wait auto-close-duration then close when the system clock is after auto-close-time and no data is being received. Previously this case would close at the time data stopped being received + system latency + auto-close-delay.
I also moved the dataStarted logic to the top layer of the if statements in an attempt to solve the timer reset logic.

It's hard to unpack all of the logic and analyze it statically, but given that your tests were good, I think this is good to merge. Maybe try with no data at all in one of the tests to cover that case?

@rockets3600 thanks for taking a look. I ran a test with no data whatsoever and it exited at the specified auto-close-time + auto-close-delay.


Request to support urllib >2.1.0

Hi there,
Requirements are set to urllib3>=1.25.3,<2.1.0 - do you plan to support versions above 2.1.0?
Many thanks

Hi there @stefanruijsenaars ,
Thank you for your question.
Currently, there are no plans to update the urllib3 dependency beyond version 2.1.0. This library is generated using OpenAPI Generator, which, at present, does not support urllib3 versions above 2.1.0. We will continue to monitor updates to OpenAPI Generator, and if support for newer urllib3 versions is added in the future, we can consider updating the dependency accordingly.
Thank you for your understanding.
Best regards,
Tamás Juhász


Custom Storage Adapter delete not called when deleting the image

Issue Summary
When using custom storage I can see save is called when uploading the image but delete method is not called when deleting the image.
Steps to Reproduce

Upload any image and check for save method called from custom storage adapter
Delete image and check for delete method called from custom storage adapter

Ghost Version
5.28.0
Node.js Version
v16.19.0
How did you install Ghost?
ghost-cli
Database type
SQLite3
Browser & OS version
chrome and macos ventura
Relevant log / error output
No response
Code of Conduct

[X] I agree to be friendly and polite to people in this repository

Ghost doesn't have any tooling for deleting an image, so I'm not sure what you mean when you say "delete the image"?
Do you mean removing it from a post? This deliberately does not delete the image, as it may be used elsewhere and we have no way to know.
I suspect this is the expected behaviour, but want to double check before closing.

When using custom storage adapters (https://ghost.org/docs/config/#creating-a-custom-storage-adapter), we extend base adapter which tells to implement following methods -

exists()
save()
serve()
delete()
read()

out of all these delete() method is not called from ghost side. Which results in functionalities like save, server etc working fine but not delete().
In my case I have written a custom firebase adapter and implemented all above methods but the call for delete method is not happening.

gentle reminder !!


Add fixed iteration count mode

Add a fixed iteration count mode which does exactly what it says on the tin.
This allows moving the statistical checks to an external tool like ministat. This might or might not help getting more  consistent and statistically valid numbers.
Also helps profilers like toplev which can run the same workload multiple times while measuring different performance counters but require the workload to be deterministic.
Since different tests require vastly different iteration counts it only works when a single test is specified. Picking a good count is up to the user.

Missing an addition to the --help text, but otherwise LGTM.

Added it to help. -duration is not there either but that is not my issue.


Handle updates in a separate command

Whether or not to update a masternode to a particular dashd binary is an important decision with implications for Dash consensus. The update command should be implemented to make updating an explicit action, and can also be used to update configs if it detects systemConfigs have been updated (via git).
We should also implement a method that detects (in status?) if a new version of mn-bootstrap has been released.
Expected Behavior

Check for and (possibly automatically) pull minor version updates
Determine source of truth - systemConfigs or check online?
Clearly show update diff applied when config versions are updated using this command
Explicitly pull images
Check and notify for mn-bootstrap updates

Current Behavior
Very simple update through mn start -u but config must be updated manually.
Possible Solution
Work on this incrementally, starting with simply checking for and pulling minor version updates only.
Alternatives Considered
A number of possible options for implementation need to be considered here before implementation starts. TBD.
Additional Context

Mostly resolved in #327 and status command also does basic checks to inform the user about more recent versions.


Fix bogus rspec script 'meal_spec.rb' failure report

ken@UbuntuOnKendell:~/mess$ bundle exec rspec
.........................F.............................................................................................................................................................................................................
Failures:

Meal reservation interlock on update on time change should update reservation
Failure/Error: expect(meal.reservations(true).first.starts_at).to eq meal.served_at - 30.minutes
expected: 2016-08-27 15:26:54.466715269 -0400
got: 2016-08-27 15:26:54.466715000 -0400
(compared using ==)
Diff:
./spec/models/meal_spec.rb:93:in `block (5 levels) in <top (required)>'

Finished in 7.57 seconds (files took 4.67 seconds to load)
231 examples, 1 failure
Failed examples:
rspec ./spec/models/meal_spec.rb:89 # Meal reservation interlock on update on time change should update reservation
Originally created by Ken Winter at 2016-08-26 20:07, last assigned to Tom Smyth, migrated from redmine-#5027

Status changed from New to Resolved

Assignee changed from Ken Winter to Tom Smyth

By Ken Winter at 2016-08-27 03:00

Status changed from Resolved to In Progress

Resetting ticket to 'in progress', in order to do the procedure for a "more
substantial" bug fix.
By Ken Winter at 2016-09-01 23:26

Version set to 2.4

By Tom Smyth at 2016-10-23 03:15

Status changed from In Progress to Closed

By Tom Smyth at 2016-10-23 03:15


Resuming protocol in set_write_buffer_limits

While working on uvloop I stumbled upon transports._FlowControlMixin.set_write_buffer_limits() method:
def set_write_buffer_limits(self, high=None, low=None):
    self._set_write_buffer_limits(high=high, low=low)
    self._maybe_pause_protocol()

Shouldn't we also add a call to _maybe_resume_protocol() here?

It does look as if it would add symmetry, which is often a good thing.
Though it likely won't affect any real-world code...?

Though it likely won't affect any real-world code...?

Not sure :(  I guess some convoluted code, theoretically, can expect that a call to set_write_buffer_limits with a higher limit will resume the protocol.
I can draft a patch if you think we should fix this.

Honestly since nobody's asked about it I'd say let's leave well enough
alone.

OK


assigner in DV_IDENTIFIER not selected in aql

Configuration information
develop
Steps to reproduce
save a composition with composer
´´
"composer":  {
"_type" : "PARTY_IDENTIFIED",
"identifiers" : [ {
"_type" : "DV_IDENTIFIER",
"assigner" : "urn:oid:1.2.2<IP_ADDRESS>.1.319.8.10003",
"id" : "a73c6d12-74aa-4ab9-82ed-5809e7713e44"
}, {
"_type" : "DV_IDENTIFIER",
"id" : "LANR_identifier_2"
} ]
}
´´
select Composer via aql.
Actual result
{
                "_type": "PARTY_IDENTIFIED",
                "identifiers": [
                    {
                        "id": "a73c6d12-74aa-4ab9-82ed-5809e7713e44",
                        "_type": "DV_IDENTIFIER"
                    },
                    {
                        "id": "LANR_identifier_2",
                        "_type": "DV_IDENTIFIER"
                    }
                ],
                "external_ref": {
                    "_type": "PARTY_REF"
                }
            }

Expected result (Acceptance Criteria)
assigner is contained in the returned json.
Definition of Done

[ ] The defect is checked by an unit or an integration test (Robot)
[ ] Merge Request approved
[ ] Unit tests passed
[ ] Build without errors
[ ] Release notes prepared
[ ] No additional runtime warnings

@chevalleyc I assume the problem is  ehr.json_party_identified


Invalid Syntax Error line 523

I'm getting an error when I try to run the script on my server:
cgreid@bacula:~$ python3 baculabackupreport.py -e<EMAIL_ADDRESS>File "baculabackupreport.py", line 523
message = f"""Content-Type: text/html\nMIME-Version: 1.0\nTo: {email}\nFrom: {fromemail}\nSubject: {subject}\n\n{msg}"""
^
SyntaxError: invalid syntax

Hello Chris,
Yeah, I see. I am using f-strings to generate that message variable. f-strings were introduced in Python 3.6. I am guessing yours is somewhat less than this.
If you just replace that line 523 with the following (olde school) method, it should work:
message = "Content-Type: text/html\nMIME-Version: 1.0\nTo: %s\nFrom: %s\nSubject: %s\n\n%s" % (email, fromemail, subject, msg)
Please let me know. I will be pushing a new version later today with this fix until I can find some better way.

Thanks. I upgraded to python 3.6 (couldn't get docopt installed for 3.9).
Bill, this is beautiful and should be implemented into Bacula.  Thank you for this!

Thanks!
Glad you like it. Keep an eye on it, I keep adding features and finding bugs or things I don't like. :)
Added SQLite support today, will be pushing that soon.


Feature/update version

Codecov Report

Merging #14 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master      #14   +/-   ##
=======================================
  Coverage   81.44%   81.44%
=======================================
  Files           7        7
  Lines         512      512
  Branches       20       20
=======================================
  Hits          417      417
  Misses         95       95

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c88ced8...f6dcf23. Read the comment docs.


HttpMethodOverrideMiddleware is missing HEAD on GET requests.

As of right now, the HttpMethodOverrideMiddleware only support overriding methods for POST requests, and when the method is overridable by a HEAD method the body is still returned.
Currently kestrel prevents body writing to HEAD requests but since method overriding happens later in a middleware, Kestrel has no chance to prevent the output.
Unfortunately there are some clients that doesn't support HEAD verb and there are 2 issues with the current HttpMethodOverrideMiddleware

Only support override for POST verbs while HEAD should be allowed on ANY type of request.
It doesn't prevent body writing on HEAD.

To solve both issue I propose the following change to HttpMethodOverrideMiddleware Invoke method:
public async Task Invoke(HttpContext context)
{
    var xHttpMethodOverrideValue = context.Request.Headers[xHttpMethodOverride];
    // New path that checks explicitly for HEAD verb.
    if (string.Equals(xHttpMethodOverrideValue, HttpMethods.Head, StringComparison.OrdinalIgnoreCase))
    {
        context.Request.Method = HttpMethods.Head;
        // Prevents body to include data, this also sets Content-Length to 0.
        context.Response.Body = Stream.Null;
    }
    // Previous behavior.
    else if (string.Equals(context.Request.Method, "POST", StringComparison.OrdinalIgnoreCase))
    {
        // ... current code
    }
    await _next(context);
}

If there's interest in updating the current middleware I can submit a PR

It's not going to be that simple. The server has expectations based on the method and overriding the method is likely to cause the app to violate those expectations.
Content-Length Example:
Request:
GET [URL]
x-Http-Method-Override: HEAD
Response:
200 OK
Content-Length: 200
At this point the server is expecting the app to provide 200 bytes or else it's an error and it will abort the connection. The client is also expecting 200 bytes, or else it's ambiguous when the next response starts.
These scenarios might work:

If the app ignores the method override and sends the body (with or without content-length). This is pretty common behavior, that's why kestrel suppresses the response body.
If the app doesn't specify the Content-Length and doesn't write any data. The server will default to Content-Length 0. This would work but is misleading for a HEAD request because the response headers are supposed to match a GET request.

If the app doesn't specify the Content-Length and doesn't write any data. The server will default to Content-Length 0. This would work but is misleading for a HEAD request because the response headers are supposed to match a GET request.

I think that's a fair trade off


Add replace_trigger to the _slurm_instance

Usage: https://github.com/GoogleCloudPlatform/hpc-toolkit/pull/2413
NOTE: can't use var.replace_trigger directly in the lifecycle.replace_triggered_by as only resource attributes are
accepted. Wrap it into null_resource

Did you consider simply accepting the controller self_link as an input variable? It feels a bit weird having an arbitrary string input variable.

I think this is unnecessary leaking of the details of controller-login relationship that shouldn't be a concern of _slurm_instance module.

It seems to me that the login node probably ought to be able to find the controller when it reboots or is replaced via DNS. But an NFS client might be to dumb to retry DNS resolution.

I think this question goes beyond the scope of this PR. I agree that if we could solve this problem , it would render this PR obsolete, but I don't see us solving immediately.

Is the IP address of the controller changing in these scenarios?

Yes, in tested scenarios controller IP go changed.

it's OK to stay on Terraform 1.3, but we are ready to adopt Terraform 1.5 in Toolkit so I think we can here too.

Could you please clarify? Do you suggest to bump TF versions in this PR? Does TF 1.5 brings some changes that would affect this logic ?

Did you consider simply accepting the controller self_link as an input variable? It feels a bit weird having an arbitrary string input variable.

I think this is unnecessary leaking of the details of controller-login relationship that shouldn't be a concern of _slurm_instance module.

I see the point. Maybe in a future iteration this would get abstracted differently, but at this level it should be more generic, I agree.

It seems to me that the login node probably ought to be able to find the controller when it reboots or is replaced via DNS. But an NFS client might be to dumb to retry DNS resolution.

I think this question goes beyond the scope of this PR. I agree that if we could solve this problem , it would render this PR obsolete, but I don't see us solving immediately.

Is the IP address of the controller changing in these scenarios?

Yes, in tested scenarios controller IP go changed.

I agree it's out of scope of the solution, but I wanted to understand the real world problem this PR is solving for future design considerations. This particular issue is solved with MIGs and stateful IPs in the HTCondor Central Manager module of the Toolkit:
https://github.com/GoogleCloudPlatform/hpc-toolkit/blob/b830db486170db6ec9ec836e461df09542d87b0c/community/modules/scheduler/htcondor-central-manager/main.tf#L190-L194

it's OK to stay on Terraform 1.3, but we are ready to adopt Terraform 1.5 in Toolkit so I think we can here too.

Could you please clarify? Do you suggest to bump TF versions in this PR? Does TF 1.5 brings some changes that would affect this logic ?

I should have stated that nit or "next time" level.


Add Github action for labeling new issues orange

Assigning back to @danielsotirhos for rebase if needed and merge. We should follow same history methodology as Azul (strictly linear, but with merge commits).


Interpret [DataType(DataType.Date)] attribute for entity properties

When I use the System.DateTime type for an propery with the attribute [DataType(DataType.Date)], the framework automatically creates an datetime2 type when using SQL Server.
But actually, this is not necessary, because the date type in SQL Server would be enough, since we defined already with the DateTypeAttribute that we only are interested in the date part of DateTime.
Currently I always have to use the attribute [Column(TypeName = "date")] to tell the framework that I don't want to use the full date-time type, but just the simple date type.

Suggestion:
When I use the DateTypeAttribute with the option DateType.Date, the framework should automatically choose the SQL data type date (when using SQL Server) so I don't need to use the ColumnAttribute.

@ice1e0 This attribute is designed primarily for validation of string-based members that have different formatting restrictions in the UI. Coercing this into something that is also used to determine a database column type involves a significant mismatch. These types of mismatch are a common source of confusion (consider empty strings and the Required attribute) so this isn't something we plan to support.


Cleaned up old comments and alerts

Removed a bunch of outdated ALERT comments, NOTE, CB, etc. now that there is documentation.  ALERTS should in future be handled as open GitHub issues with full descriptions. Some items are marked PARAM2_DEPRECATION indicating functionality or API that could and ideally should be removed in param 2.0.
A few of the comments were too cryptic for me to decipher:

CBENHANCEMENT: Add an 'epsilon' slot. See email 'Re: simulation-time-controlled Dynamic parameters' Dec 22, 2007 CB->JAB: I found no such email. I can imagine why an epsilon might be useful for time-dependent parameters, but only in a vague way.
CEBALERT: we break some aspects of slot handling for Parameter and Parameterized. The __new__ methods in the metaclasses for those two classes omit to handle the case where __dict__ is passed in __slots__ (and they possibly omit other things too). ParameterizedMetaclass doesn't even have a __new__ method, and I can't see any reason for special handling in ParameterMetaclass.
Additionally, various bits of code in the Parameterized class assumes that all Parameterized instances have a __dict__, but I'm not sure that's guaranteed to be true (although it's true at the moment).: I can't see why a Parameterized wouldn't have a __dict__
CEBALERT: I think I've noted elsewhere the fact that we sometimes have a method on Parameter that requires passing the owning Parameterized instance or class, and other times we have the method on Parameterized itself.  In case I haven't written that down elsewhere, here it is again.  We should clean that up (at least we should be consistent).: agreed, but I couldn't find any examples of this on Parameter.
cebalert: it's really time to stop and clean up this bothmethod stuff and repeated code in methods using it.: I have no idea what could be cleaned up about it.

Now that there is a proper user manual, we should consider whether to shorten some of the very-detailed docstrings in these two files, since they may now drift out of sync with the official docs. They do have a bit more "reference manual" feel to them in some cases, so I'm not necessarily ready to delete them immediately.

Codecov Report

Merging #553 (8490999) into master (8ef0e38) will decrease coverage by 0.04%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master     #553      +/-   ##
==========================================
- Coverage   82.01%   81.96%   -0.05%
==========================================
  Files           4        4
  Lines        2958     2956       -2
==========================================
- Hits         2426     2423       -3
- Misses        532      533       +1

Impacted Files
Coverage Δ

param/parameterized.py
82.34% <100.00%> (-0.08%)
:arrow_down:

numbergen/__init__.py
79.87% <0.00%> (-0.03%)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8ef0e38...8490999. Read the comment docs.


Add a new dependency to bitflags

As per commit https://github.com/rust-lang/rust/commit/34fa70fba5425cbbb96bce783e9fd5c23dd9b471 , the bitfalgs macro has been moved to its own crate.

Thanks for the PR. This has been covered by #50 already.


Move LoopScopes into ExprContext

This simplifies the code, and makes it to use ExprContext for other purposes (for example variable scoping).

Merging for #1560


[BUG] Trailing comma in profile

Description
There's a trailing/extra comma in Siddhesh Agarwal's recently added profile.
This should be fixed immediately to prevent CI and deployment issues.
Steps to contribute

Fork the repository here.
Create a new branch named fix_comma.
Open the profiles/Siddesh-Agarwal.json file.
In line 5, in the username field, remove the comma at the end of it.
Commit and push your changes.
Create a pull request in the repository.
You're done now! 🎉 You just have to wait until the maintainers check your PR.

If you need any help, let us know about it and we'll gladly help.
Additional information
This is a good first issue. Please leave it open to first-time contributors and beginners. 🙂

@Panquesito7 I will fix it.

https://github.com/EddieHubCommunity/awesome-github-profiles/pull/1644


Cannot POST /api/query/.

I am using POSTMAN to access the api on localhost:8338/api/query/.
I have given the request body like this:
{
	"sql": "select * from foo;",
	"database": "foo"
}

and have set the Content-Type as application/json.
I intend to receive the response of the sql statement but instead I receive a Cannot POST /api/query/ - HTTP 404 Not Found error!.

Does it work without the trailing /? Otherwise, try to use the web client and replicate the requests it makes...

That's so silly of me. Removing the trailing / worked. Thanks!