lua5_3_compat, lua5_4_compat: set LUA_COMPAT_5_x as LUA_COMPAT_ALL was removed

Fixes https://github.com/NixOS/nixpkgs/issues/218227
Before:
Lua 5.3.6  Copyright (C) 1994-2020 Lua.org, PUC-Rio
> math.frexp
nil

After:
Lua 5.3.6  Copyright (C) 1994-2020 Lua.org, PUC-Rio
> math.frexp
function: 0x423ae0

Description of changes
Sets LUA_COMPAT_5_x flags as the LUA_COMPAT_ALL flag was removed. This fixes the lua_5_*_compat packages not actually having any compat features.
Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
23.05 Release Notes (or backporting 22.11 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[x] Fits CONTRIBUTING.md.

Result of nixpkgs-review pr 218229 run on x86_64-linux 1

5 packages marked as broken and skipped:

libquvi
obs-studio-plugins.obs-hyperion
python310Packages.pyres
python311Packages.pyres
quvi

9 packages failed to build:

cie-middleware-linux
icesl
obs-studio-plugins.obs-ndi
python310Packages.ray
python311Packages.django-q
python311Packages.django-redis
python311Packages.python-redis-lock
spring
springLobby

218 packages built:

_90secondportraits
adl
alephone
alephone-durandal
alephone-eternal
alephone-evil
alephone-infinity
alephone-marathon
alephone-pathways-into-darkness
alephone-pheonix
alephone-red
alephone-rubicon-x
almanah
ani-cli
anime-downloader
anki
ankisyncd
ansifilter
arcanPackages.all-wrapped
arcanPackages.arcan
arcanPackages.arcan-wrapped
arcanPackages.cat9-wrapped
arcanPackages.durden-wrapped
arcanPackages.pipeworld-wrapped
arcanPackages.prio-wrapped
arcanPackages.xarcan
asciidoc-full
asciidoc-full-with-plugins
asterisk (asterisk-stable ,asterisk_19)
asterisk_18 (asterisk-lts)
asterisk-module-sccp
asterisk_16
asterisk_20
astroid
awesome
baserow
bozohttpd
btanks
calibre
celestia
celluloid
clevis
collectd
compactor
conky
cplay-ng
credslayer
crystfel
crystfel-headless
curseradio
d-seams
dbmonster
deepin.deepin-voice-note
desmume
devilspie2
discourse
discourseAllPlugins
disorderfs
dit
dmlive
dnsdist
duckmarines
eaglemode
eiskaltdcpp
evolution
evolution-ews
evolutionWithPlugins
ff2mpv
fityk
fnlfmt
freeswitch
fsuae
fsuae-launcher
gImageReader
gonic
gpick
grafx2
gravit
haka
haruna
hexchat
hfinger
highlight
horizon-eda
hydrus
hypnotix
ibus-engines.libpinyin
ikiwiki
ikiwiki-full
imapfilter
instead
instead-launcher
jellyfin-media-player
jellyfin-mpv-shim
jftui
kaffeine
kakounePlugins.rep
kphotoalbum
krename
libmodsecurity
libresprite
libsForQt5.elisa
libsForQt5.phonon-backend-vlc
libsForQt5.plasmatube
libvlc
lsyncd
lua
lua5_3_compat
lua5_4_compat
luksmeta
lutris
lutris-free
lxi-tools
lxi-tools-gui
mailman-web
megaglest
minitube
mnemosyne
monotone
mpc-qt
mpv
mpv-unwrapped
mpvScripts.inhibit-gnome
mpvScripts.mpris
mpvpaper
mrrescue
netbox
notion
obs-studio
obs-studio-plugins.droidcam-obs
obs-studio-plugins.input-overlay
obs-studio-plugins.looking-glass-obs
obs-studio-plugins.obs-gstreamer
obs-studio-plugins.obs-livesplit-one
obs-studio-plugins.obs-move-transition
obs-studio-plugins.obs-multi-rtmp
obs-studio-plugins.obs-nvfbc
obs-studio-plugins.obs-pipewire-audio-capture
obs-studio-plugins.obs-source-record
obs-studio-plugins.obs-vaapi
obs-studio-plugins.obs-vkcapture
obs-studio-plugins.wlrobs
offrss
opensmtpd-extras
orthorobot
osm2pgsql
osmscout-server
osrm-backend
ostinato
pdfmixtool
pdns
pdns-recursor
pinsel
plex-media-player
plex-mpv-shim
podofo
prosody
public-inbox
pympress
python310Packages.django-q
python310Packages.django-redis
python310Packages.logutils
python310Packages.mpv
python310Packages.pecan
python310Packages.pyshark
python310Packages.pyslurm
python310Packages.python-redis-lock
python310Packages.python-vlc
python311Packages.logutils
python311Packages.mpv
python311Packages.pecan
python311Packages.pyshark
python311Packages.pyslurm
python311Packages.python-vlc
qimgv
qosmic
radioboat
ranger
reaper
redis
roccat-tools
samba4Full
scribus
slade
sladeUnstable
slurm
slurm-spank-stunnel
slurm-spank-x11
somafm-cli
spacevim
strawberry
stremio
sublime-music
subtitleedit
suricata
swiften
tang
telegram-cli
tengine
termshark
texworks
tilemaker
tshark
ultrastardx
unvanquished
urn
vim-full
vimacs
vis
vlc
weechat
weechat-unwrapped
widelands
wifite2
wireshark
wtwitch
xmoto
ytfzf

Reduced rebuilds by changing compat flags based on version instead of always setting them all.

Result of nixpkgs-review pr 218229 run on x86_64-linux 1

3 packages built:

conky
lua5_3_compat
lua5_4_compat


ENYO-875: moon.VideoPlayer remoteKey 'stop' is not stop playing

Issue:
moon.VideoPlayer has a remoteKeyHandler which is calling this.jumpToStart() when 'stop' button is pressed.
But, jumpToStart is calling play when it is called while it is playing. So, it's play again after change current time to 0 and paused.
Fix:

Set this._isPlaying as false before calling  this.jumpToStart() to block calling play.
Call this.sendFeedback('Stop'); after calling this.jumpToStart() to change feedback text from 'paused' to 'stop'.

DCO-1.1-Signed-Off-By: Kunmyon Choi<EMAIL_ADDRESS>

Hi @KunmyonChoi, can you fix the Travis error? Thanks!


Update for 1.16?

When is the update for 1.16 coming? At the moment it will not run with Forge 1.16.

When it is done.


.xls buffer management bug

There appears to be a bug in the buffer management code that can crop up with large files. It manifests as an InvalidDataException that is thrown for valid files when the buffer state gets corrupted, and the invalid state is processed.

Fixed with #43.


logout #13

Make sure you've reviewed the checklist. (DO NOT REMOVE)
🚨Please review the guidelines for contributing to this repository.

[✓] Make sure you are requesting to pull a topic/feature/bugfix branch (right side). Don't request your master!
[✓] Make sure you are making a pull request against the dev branch. Also you should start your branch off dev branch.
[✓] Check you have included issue number in your pr (e.g #23).
[✓] Check you have added tests that prove your fix is effective or that your feature works.
[✓] Check your code additions will fail neither code linting checks nor unit test.
[✓] Check you added any notable changes to the CHANGELOG.md file.

Description
Please describe your pull request.
💔Thank you!

work should be done on dev branch, please start your branch from dev branch and also open pr against dev branch otherwise pr can't be accepted


preflight problem

when testing your code ( i replaced localhost by my laptop lan ip. I created a db called test and set admin password as admin )

i get this error

having this in couchdb

Can you point where the problem is ?
thank you

It looks like you're missing some of the CORS header settings. You can correct that by using: https://github.com/pouchdb/add-cors-to-couchdb


Get markers with updated ranges

monaco-editor version: 0.20.0
Browser: Chrome 8x
OS: macOS 10.14

Set a marker in a particular range
Make an edit somewhere before that marker, causing it to be moved
Retrieve the marker
The reported range for the marker will be the original  one, even though the marker as it's displayed to the user is in a different range
Setting back that same marker would then move it to another range, the original one
Essentially it's not easily possible to add or remove markers with the given set of APIs

I'd really like getModelMarkers to return markers with up-to-date positions, I'm not sure what the usefulness is of retrieving markers with their original positions.
Also if moving the markers in done asynchronously there should be an event triggered that tells you when the move has happened, if one is scheduled to happen.

This is not exposed as public editor API, but can be fetched with a lot of private access from the IMarkerDecorationsService
const ed = monaco.editor.create(document.getElementById("container"), {
    value: "function hello() {\n\talert('Hello world!);\n}",
    language: "typescript"
});
function getService(id) {
    for (const entry of ed._instantiationService._parent._services._entries) {
        if (entry[0].toString() === id) {
            return entry[1];
        }
    }
}
const markerDecorationsService = getService('markerDecorationsService');
function getLiveMarkers(model) {
    const markerDecorations = markerDecorationsService._markerDecorations.get(model.uri.toString());
    if (!markerDecorations) {
        return [];
    }
    const markersData = markerDecorations._markersData;
    let result = [];
    for (const entry of markersData) {
        const decorationid = entry[0];
        const data = entry[1];
        result.push({
            range: model.getDecorationRange(decorationid),
            data
        });
    }
    return result;
}

setInterval(function() {
    console.log(getLiveMarkers(ed.getModel()));
}, 3000);

Awesome, thank you for the quick answer.
Is it possible that this way I will get "old" ranges that haven't been moved yet?
I really think a higher level public way to get updated markers, or even just those decoration ids, would be a great addition.

You can always add decorations on your own, so if you own the markers, you can just add decorations for the markers and then set the markers to the editor. Then, when you want to update a marker you can read back the ranges of the other markers from the text model.

Closing due to inactivity.
If this bug still applies, please create a new issue. Make sure to select the form for bugs and include a minimal reproducible example. Thanks!


Twitter embeds cut off

I use NetNewWire almost exclusively to follow finance Twitter account (I use a secondary app to generate RSS feeds for the people that I follow). A week ago disaster struck - the bottom is chopped off the content right hand reader view. See example below.
Any tips on how to avoid this?

Duplicate of #2166


Cloud feedbacks: updates to code backend

several lines in lib/cal_CloudRadKernel_xr.py were updated to be compatible with the latest version of xCDAT

Progress note: code is ready for merge after the final test -- check for any changes in the metrics due to change of landmask generation. It used to use the global_land_mask that is installable via only pip, now switched to PMP's create_land_sea_mask function.

Output JSON checked, no noticeable difference was found.


Implement odo catalog list components for devfile v2

/kind user-story
User Story
As a user i want to list components based on devfile v2.
Acceptance Criteria

[ ] odo catalog list components, should list components from devfile v2 registry
https://github.com/elsony/devfile2-registry

Links

Feature Request:
Related issue:

/kind user-story

for V1 we are parsing devfile from each registry to this struct https://github.com/openshift/odo/blob/master/pkg/catalog/types.go#L45
and validating for supported component here
https://github.com/openshift/odo/blob/master/pkg/catalog/types.go#L45
IIUC We are parsing and validating each devfile from each registry before listing, We are parsing the devfile for two things

Name
Supported

is parsing each devfile really required?
We can get name from index.json of a devfile registry.
We can decide supported on the basis of devfile registry
odo specific registry : Ideally if a devfile has been added to an odo specific registry it is supported, no need to validate with each call of odo catalog list components. The devfile should be validated and tested before adding it to the registry. So for odo specific registries(registry by odo team) we could default them to true.
other registries : other registries could be added by user, or some other open registries.
devfiles in those are not tested by odo, so we should not list them as supported and hence they can be defaulted to false
cc @kadel @elsony

is parsing each devfile really required?

We should avoid parsing each devfile from the registry. It is not a good long term solution and it will definitely create problems for even moderately large devfile registries.

The odo specific registry is a point-in-time thing.  Our eventual goal is share the same devfile registry as Che (and other dev tools).  In that case, we don't have a registry that we know for sure we support all devfiles in there.  That leave us a couple of options:

Continue to scan for all devfiles in a repo: as @kadel  mentioned, it may causes performance problem on large registry.
Not scanning any at all and just assume all devfiles are supported. We just error out during the execution if someone tries to run do odo push on some devfiles that we cannot support, e.g. without any run command: I don't think this will provide a good user experience since it discover quite late on the cycle.
Inject some info into the index.json, e.g. an executable or dev tag, that indicates those devfiles contain the minimum that we can support.  We basically move the scanning from real time on all devfiles to one time on building the index.json. Once we have that, we can easily filter out just based on info within the index.json.

I think #3 is a good trade off to inject a build step on the repo for which we already have scripts to generate the index.json in our repo.

I think #3 is a good trade-off to inject a build step on the repo for which we already have scripts to generate the index.json in our repo.

Agreed that index.json would be a good place for this.
I'm not sure if we currently have a clear definition of what should be the registry API (including index.json structure)
Before we create a clear definition of how what should be the registry interface I would go with showing all devfile v2s and add filtering later once we define it properly

@kadel @elsony what display name should we use for odo? if we start listing from index.json
https://github.com/elsony/devfile-registry/blob/master/devfiles/index.json#L3,
long names would not fit for odo create.

@kadel @elsony what display name should we use for odo? if we start listing from index.json
https://github.com/elsony/devfile-registry/blob/master/devfiles/index.json#L3
long names would not fit for odo create.

We will have to add the devfile name into the index.json for now.
Currently, there is no definition of how the proper devfile v2 registry interface should look like.
The current index.json is just a temporary solutoin.

@adisky I've forked @elsony repository to https://github.com/odo-devfiles/registry and updated index.json to include name field for each devfile.
@elsony I've removed the version hierarchy that you had there. Once we have a good idea of how we will handle versions and we have support for it on odo side we can update the hierarchy again to include versions.

@adisky check this issue https://github.com/openshift/odo/issues/3298 it is related to this

This issue is already covered by #2938 and implemented by PR #https://github.com/openshift/odo/pull/3291

@kadel @elsony @adisky so did we reach to any conclusion on this topic? Scanning the other discussion, it looks like we want to stop parsing individual devfiles for names and to check if they're supported..
index.json can have the name, but for the matter of checking if they're supported, have we reached an agreement? PR #3291 currently already does parsing for v2 like v1 at this point

I think one way is to move the logic for checking if devfile is supported, from odo repo to https://github.com/odo-devfiles/registry repo and store that information in index.yaml.
Then we can just read index.yaml for name and to check if its supported or not..

@maysunfaisal I think we are agreed on not parsing the devfile and using name from index.json,
for supported i am also not sure, If you have implemented odo catalog list components for devfile V2 upto V1 level, should rename this issue to Do not parse each devfile from registry? if you wish this improvement can be handled separately.
And also as said above  index.json is temporary solution, I think it is fine to have  supported: true in index.json  for now.

Can I get some reviewers on the v1 and v2 registry PRs for the discussion above?
v1: https://github.com/elsony/devfile-registry/pull/16
v2: https://github.com/odo-devfiles/registry/pull/3
this is implemented in odo WIP PR https://github.com/openshift/odo/pull/3291

@maysunfaisal  is it possible to extract out name from displayName e.g
displayName; NodeJS React Web Application name would be nodejs-react
I know it might be weird for some cases and not a viable solution, just shared the thought.

We had a discussion  on this topic in the odo contributors call:

We are going to show all the stacks from a registry ie; no more supported column (in the future if we determine, Che devfiles need to filtered; we can reintroduce a supported field
Remove Che and odo v1 registry from default selection  on odo catalog list components

Do we want to remove the SUPPORTED column for the s2i components?
This is how it looks between s2i and devfiles(notice that I removed the devfile SUPPORTED column).
Also planning on removing the -a flag since it was only used to list the Che v1 devfiles and had no difference between supported and unsupported.. And since we're removing the default Che v1 devfile registry; the -a flag does nothing.
$ odo catalog list components
Odo OpenShift Components:
NAME              PROJECT       TAGS                        SUPPORTED
java              openshift     11,8,latest                 YES
nodejs            openshift     10-SCL,8,8-RHOAR,latest     YES
dotnet            openshift     2.1,2.2,3.0,latest          NO
golang            openshift     1.11.5,latest               NO
httpd
Odo Devfile Components:
NAME            DESCRIPTION                            REGISTRY
maven           Upstream Maven and OpenJDK 11          DefaultDevfileRegistry
nodejs          Stack with NodeJS 10                   DefaultDevfileRegistry
openLiberty     Open Liberty microservice in Java      DefaultDevfileRegistry
quarkus         Upstream Quarkus with Java+GraalVM     DefaultDevfileRegistry
springBoot      Spring Boot® using Java                DefaultDevfileRegistry

Copying what I mentioned on slack:

Do we want to remove the SUPPORTED column for the s2i components?
Keep it for s2i components as it's still needed / useful

Do we want to remove the -a flag since it was only used to filter the Che v1 devfiles (and had no difference between filtering supported and unsupported)? And since we're removing the default Che v1 devfile registry; the -a flag does nothing.

Since -a is only for the Che devfiles really, we can take it out.

@adisky there was a related discussion in https://github.com/openshift/odo/issues/3249#issuecomment-641350713

can be closed, fixed by https://github.com/openshift/odo/pull/3291

/close


How to debug the Compose Multiplatform

Following the instruction in Compose-Multiplatform-Core/MULTIPLATFORM.md, I successfully built a KMP project with the locally published Compose. But when I made some changes in Compose Multiplatform core source code, I didn't find a way to debug it. I may be missing something obvious, could you give me some tutorials on how to debug? Thank you!

Use IDEA/Android Studio to debug desktop/web and AppCode on macOS for running iOS (it is obsolete, but Android Studio currently has issues in the current configuration).

Running Android target in compose-multiplatform-core isn't supported at the moment, as CMP doesn't build/maintain it, it reuses Jetpack Compose artifacts. Read the Google manual how to open/build it.

Thanks!

Please check the following ticket on YouTrack for follow-ups to this issue. GitHub issues will be closed in the coming weeks.


Update administrative-units.md

The following should be clearly stated for clarity:
"Note that if you assign a role to a user that is not a member of an administrative unit, the scope of the role is the entire tenant."

@rolyon
IMPORTANT: When the changes are ready for publication, add a #sign-off comment to signal that the PR is ready for the review team to merge.
#label:"aq-pr-triaged"
@MicrosoftDocs/public-repo-pr-review-team

Hi @azarboon
Thanks for your contribution. We'll work on getting this updated added to the docs.
thanks

#sign-off


ISSUE-80: Add patch support for psycopg2

Issue 80
Add patch support for psycopg2 using existing dbapi2 tracing classes. For now, add host, database, user, and database_type to sql metadata.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@haotianw465, I updated the metadata and confirmed via system test that it shows up in the AWS XRay Console. Please let me know if there is anything else I should do for this PR.

Thank you for your contribution. I have merged your PR and will roll it out in our next release.


feat: export AckOnSuccess as server.SubscriberOption

In order to enhance MQ's reliability, it is sometimes necessary to disable auto acknowledgment.
If this option can be utilized alongside with rabbitmq.ServerAckOnSuccess(), then there will be no need for the user to manually acknowledge the message.
...

micro.RegisterSubscriber(
  topic,
  microServer,
  eventHandler,
  server.SubscriberQueue(name),
  server.DisableAutoAck(), // disable auto ack
  rabbitmq.ServerAckOnSuccess(), // only ack in case handling without err
)
...

@jochumdev could you pls review and merge this pr ? thanks


Can't change an (expired) STS token inside an OSS client

There is a problem with STS tokens we encounter. Our use case is similar to the one documented here https://www.alibabacloud.com/help/doc-detail/54579.htm?spm=a2c63.p38356.a3.2.173c3461fmtaEf  but with Golang instead of Python.
The issue is with accessing the OSS API from Golang code with STS tokens, this is certainly possible, but the STS tokens are expiring, and there is no way to change the tokens inside an existing OSS client, although in the https://github.com/aliyun/alibaba-cloud-sdk-go the tokens are refreshed on-demand.
Are there any plans to change this behavior our this is not the correct way to use the API? Currently, we have to throw away the OSS client every time the token expires, and users of the API have to implement the same pattern at every use case.
I open this issue here but been advised to move it here.

The code is in signer_ecs_ram_role.go - it would be great if the OSS Go SDK would have the capability to install those signers as well, because right now if we create an OSS client with:
	client, err := oss.New(endpoint, accessKeyID, accessKeySecret, oss.SecurityToken("...."))
	if err != nil {
		return nil, err
	}

That client will hold the tokens and secrets forever, and we will have to throw it away once the token expires. But instead of passing in the credentials statically, there would be a signer inside the client like here: https://github.com/aliyun/alibaba-cloud-sdk-go/blob/master/sdk/client.go#L73

thank your issue！
We will solve this problem in a subsequent version

那么问题来了，解决还是不解决呢


Deprecation Warnings in observer.moon_rise_time()

The Astroplan functions observer.moon_rise_time() and observer.moon_set_time() apparently call the Astroplan function get_moon(), which is now deprecated in favor of get_body("moon"). As a result, every call to the Astroplan functions now generates a deprecation warning in the output. Are there plans to fix this, or is there some other way to easily calculate moon rise and set times in Astroplan?

Hi @dalerye, there's a fix in https://github.com/astropy/astroplan/pull/558. I'll merge that as soon as the tests pass. Thanks for the heads up!


"User" Parameter section is duplicated

The parameter titled "user" has two identical sections.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: fb509e0a-2371-d5b8-6462-c0f29e6c8152
Version Independent ID: b8fdd337-395d-0c42-4ff1-9a0969a9d578
Content: Add-MailboxPermission (exchange)
Content Source: exchange/exchange-ps/exchange/mailboxes/Add-MailboxPermission.md
Service: exchange-powershell
GitHub Login: @chrisda
Microsoft Alias: chrisda

@jeffreymcclain, this is a topic rendering issue with docs.microsoft.com. You'll notice that the underlying GitHub source topic doesn't have duplicate User parameter sections. This definitely has something to do with the multiple YAML blocks in the parameter (required when a parameter is required in some parameter sets, but optional in others). I'm actively seeking a solution.
Thanks for the feedback


There is no use to click "show yaml editor" at "Edit Pipeline" page

Describe the Bug
click "show yaml editor"

got

Versions Used
KubeSphere: nightly-20210422
Kubernetes: v1.18.14
/kind bug
/area console
/area devops

Issue fixed in v3.2.0


NfcV

Thanks in advance for reading this!
I am running an experiment and these are some of my observations:

I am trying to scan a medical device attached to the body that detects blood glucose levels for diabetics.

You should find a lot of relevant info that might be useful here: https://www.reddit.com/r/diabetes/comments/2ld5t5/freestyle_libre_used_nfc_sensor_hack/

I got your example up and running and scanned the sensor, and this is what i got, i am trying to make sense of what i could do further. I was expecting an array of tags in the data. Am i missing something. Or is the data being read off the tag not parseable. If it's not, can i get access to the raw data stream and play with the hex/binary stream to try to decode it? If so what's the best way to start?

Any pointers will be appreciated!

Hi, sorry for the late response.
It seems that the tag doesn't contain any NdefMessages. This library by default will only read the NdefMessage from tag, so there won't be any data shown.
Android does support direct comm with NfcV tag (primarily through a transceive API), as can be seen here:

https://developer.android.com/reference/android/nfc/tech/NfcV

Currently this library doesn't bridge this API yet, I will try to implement this when available.
Thanks

Thanks, i think i can try and implement that.
Can you point me to the relevant part in your code that i can start looking at. Appreciate the help!

Hi, @krokhale , we just release v1.0.0 which supports NfcV transceive, please take a look!


create the daemon from the binary itself

we could just create the daemon from the binary itself, it would be way easier

done in #3


mention compatibility for old Julia versions

[skip ci]
For old Julia versions without artifacts, adding ImageMagick as a hard dependency can be a little bit tricky and unstable. Thus in the "best" practice in that time is to avoid the build process as possible as we can, and requesting users to install them manually.

From https://juliaimages.org/stable/install/#sec_imageio

If this is your first time working with images in julia, it's likely that you'll need to install some image IO backends to load the images.

ImageIO requires at least Julia 1.3.

Thanks for the clear description!


Cannot scroll up and down the page using the up/down arrow keys

Instead it moves to the previous/next page

You also can't select text using the left/right arrow keys for similar reasons

Marc - this is probably a code lab infra issue.

I believe this is fixed now.


Make out_of_memory_recovery test trigger OOM faster.

Fixes #1183. This test is taking up the majority of the test
runtime on CPU backends, slowing eating away at RAM/swap for
two minutes while the rest of the system gets evicted from RAM
and stops responding.
Replaced the allocation loop with a single large allocation,
now the test runs in ~1ms and doesn't actually allocate
significant resources.

CL 28522192.

A full multiconfig test cycle is now 45 minutes shorter 🎉 🎉 🎉


Missing CSSStyleRule which extends CSSRule

Initially I thought CSSRule declaration should have style property, but no actually we miss an entire class CSSStyleRule which inherits from CSSRule and implements style property.
https://github.com/facebook/flow/blob/master/lib/cssom.js#L42

Oh, it also lacks CSSStyleRuleList, now I don't know if I should create separate issues for each missing declaration.

Looks like there is no CSSStyleRuleList, there is CSSRuleList which is currently wrong, because it should have item(index: number): ?CSSStyleRule not CSSRule, at least in chrome.

Experiencing the same issue, currently on flow-bin v0.81.0, but even after upgrade to v0.87.0 the error was occurring.


Connection properties do not work as described in README.md

Description
Connection properties do not work as described in README.md
Expected behaviour
"log-client-msgs" is a bool, but described as string in README
"log-server-msgs" is a bool, but described as string in README
"channel-package-queue-size=110" returns: error parsing DSN: no field for key "channel-package-queue-size"
Both cgo-ase and go-ase should support the same set of connection properties, even if some properties result in no-op for a driver. This would allow developers to switch drivers without changing code. Both drivers register as 'ase', and should behave the same (expect performance differences) at the API level.
Current behaviour
A clear and concise description of what currently happens.
Steps to Reproduce
Steps to reproduce the behavior:

Go to '...'
Click on '....'
Scroll down to '....'
See error

Environment
Client:
OS:
go version: 1.16.3
cgo-ase version / commit hash: v0.0.0-20210312084010-d645a8f3e9d9
go-dblib version / commit hash: v0.0.0-20210315102028-46975ce12d39
Server:
OS:
ASE version:  16.0_SP03PL02_EBF28306.el7
Screenshots
If applicable, add screenshots to help explain your problem.
Additional context
Add any other context about the problem here.

Would like to see "appname", "no-query-cursor", etc. in go-ase driver to work in cgo-ase.
In reverse, "log-client-msgs" and "log-server-msgs" in cgo-ase are extremely useful for trouble shooting, and they should in be in go-ase as well

Thank you, the documentation and the AppName property has been added.
Regarding the other points see my response here: https://github.com/SAP/go-ase/issues/194#issuecomment-831233661


Code maintenance

Describe the issue (if no issue has been made)
Code maintenance of things Cherno did start but not finish or mensioned before but did not do in the code maintenance video.
PR impact (Make sure to add closing keywords)
List of related issues/PRs this will solve:

Impact
Issue/PR

Issues this solves
Part 1 of #140

Other PRs this solves
None

Proposed fix (Make sure you've read on how to contribute to Hazel)
A more detailed list can be found in https://github.com/TheCherno/Hazel/issues/140#issue-499535992

Convert the remaining smart pointers to Hazel wrappers

std::shared_ptr -> Hazel::Ref and std::make_shared -> Hazel::CreateRef
std::unique_ptr -> Hazel::Scope and std::make_unique -> Hazel::CreateScope

Removing all DLL traces
Removed all HAZEL_API macros
Fixing include statements

All includes relative to Hazel/src
All external includes use <> instead of ""

Use default (de)constructor instead of an empty one
Removed the dedicated (duplicate) BIND_EVENT_FN in application
Now uses the generic HZ_BIND_EVENT_FN instead
Removed obsolete logging messages in glfw
Removed obsolete YAML keys in PR template

Additional context
Tested in debug and release, the rest of the code maintenace can be found in https://github.com/TheCherno/Hazel/issues/140#issue-499535992.

When will this be merged?

When will this be merged?

Still debating if I should rename Core.h to Base.h or not... Otherwise I think tomorrow, or after cherno's next vid/upload to github

Should LovelySanta/Hazel#47 be merged into this?

I don't think it should be merged into this.

I don't think it should be merged into this.

The reason I did it lije this, only Window.cpp includes the WindowsWindow, so in that file we can add/remove the obsolete classes when they are not required. This could even work for the different renderAPI's, for example exclude DirectX in macOS...
Any particular reason why you're against it @CleverSource ? I can see how it might require a seperate PR instead...

It's a good PR, but it doesn't feel very maintenance like and seeing as this PR is meant for maintenance I don't see why a PR unrelated should be merged with this.

Removed LovelySanta#47 from the TODO list.

Will this be merged now?

Will this be merged now?

There are still some things to do, see #140, such as removing the OpenGL casting in the 3D renderer...

Will this be merged now?

Now everything is implemented. I want to have anther look in the weekend and I plan on merging it on monday if everything looks alright.

One other thing that I can think of that we might want to include, seeing as we have the platform detection now, is the include guards for the API-specific files depending on platform. The Windows* files would only be on Windows and the OpenGL* files can probably work on both Windows and Linux. Do you think we should do that? And, if so, should it be part of this PR?

That is exactly what I asked some days ago: https://github.com/TheCherno/Hazel/pull/165#issuecomment-547148507.
The only place Windows* files are included are within the Window and Input class for the WindowsWindow and WindowsInput respectively. By adding a create function to them (as done in LovelySanta/Hazel#47), we can use the include guards to include the headers (if needed) and use them to return the correct implementation.
I agree with the reply from CleverSource https://github.com/TheCherno/Hazel/pull/165#issuecomment-548185614 on the matter: It is a good PR, but not really maintenance, it should have its own PR into Hazel instead.
So I think this is indeed a nice suggestion, but also outside the scope of this PR?

It most likely is outside the scope of this PR to be quite honest.

I know this is an old PR that was merged over a year ago, but Cherno mentioned in the Smart pointer episode (20 minutes in) that the spdlog::loggers should remain in std::shared_ptrs instead of Hazel Refs since spdlog::loggers aren't Hazel assets?

I do remember that yes, but as long as it is just a wrapper around shared ptrs, this is equivalent. When we implement our own ref system, it has to change indeed.


failed to compile foreman v1.0.3, intermediate artifacts can be found at

I can't install foreman because cargo keeps giving this error

Support for compiling binaries is generally not given. The error message actually states the problem here in a very polite tone:

please ensure that VS 2013, VS 2015, VS 2017 or VS 2019 was installed with the Visual C++ option

If you are just trying to install foreman, it is recommended you use the prebuilt binaries from the release (which would be foreman-1.0.3-win64.zip if your case)

Thank you @OverHash, it is in fact simpler to use a prebuilt binary 🙂

Thanks you so much!


Provide an opt-in in aws-smithy-types-convert to enable Stream trait

Context: https://github.com/awslabs/smithy-rs/pull/2978#discussion_r1327600700
With PaginationStream no longer implementing the Stream trait, we can add a new-type for PaginationStream to the aws-smithy-types-convert crate to enable the Stream trait for that new-type.
This is an opt-in feature and improves the API ergonomics. Furthermore, when the Stream trait goes to 1.0, we can add a new supporting new-type in a backward compatible way.

How am I supposed to use aws-smithy-types-convert from my code to display RFC 3339 and ISO 8601 without directly depending on aws-smithy-types-convert?
The SDK is hiding so many things that makes work so much easier and every time I have to depend on aws-types or something else that is marked as
This crate is part of the [AWS SDK for Rust](https://awslabs.github.io/aws-sdk-rust/) and the [smithy-rs](https://github.com/awslabs/smithy-rs) code generator. In most cases, it should not be used directly.

because it is not reexported.
Then it becomes real pain to update any of the packages in workspace with multiple crates using workspace_hack.

The vast majority of things you need should be re-exported, and it's a bug if they're not (please file something to let us know which type you needed). However, aws-smithy-types-convert is the exception to that general rule currently. Each release of the SDK lists crate versions for that release in an expandable section to identify which versions you should use. For example, see the "Click to expand to view crate versions..." in: https://github.com/awslabs/aws-sdk-rust/releases/tag/release-2023-10-26

and it's a bug if they're not (please file something to let us know which type you need
Thanks for the response, I will move more of my questions into discussions so I do not hijack this issue.

There are a lot of crates, some of them have grouped versioning, but I saw somewhere that you are trying to line it up. ❤
I am rooting for more examples, because standard docs.rs are not great for discovery.
Especially around the aws_sdk_config because coming from boto3 I've had a hard time creating a different config other than load_from_env for a local version of dynamoDB.
Also, fewer Option<T>s would be great.

Off topic
  Coming up with this config for a client of the local version of dynamo db took me quite some time.
I use this client during integration tests and just wanted to set the values.
As a newcomer to Rust I find it rather confusing, how the configuration of the SDK works (but I am comparing this to Boto3 and JS v3). Then 2 similar crates aws-sdk-config and aws-config just add to the pile of confusing information.
I am hoping, you can iron it out before v1.0 🤞 .
My app depends on and probably a lot has changed since then but I was not in a position to update due to some changes that broke the other parts of the app that required aws-types - but it looks like it is probably resolved in later versions.
aws-sdk-dynamodb = "0.28.0"
aws-sdk-ssm = "0.28.0"
aws-sdk-sqs = "0.28.0"
aws-config = "0.55.3"
aws-types = "0.55.3"

aws_lambda_events = "0.10.0"
serde_dynamo = { version = "4.2.3", features = ["aws-sdk-dynamodb+0_28"] }
aws-credential-types = { version = "0.55.3", features = ["hardcoded-credentials"] }

here's the example what I did with the config
pub fn dev_credentials() -> SdkConfig {
   use aws_credential_types::provider::SharedCredentialsProvider;
   use aws_credential_types::Credentials;
   let c = Credentials::new("x", "x", None, None, "my_provider_name");

   aws_config::SdkConfig::builder()
       .credentials_provider(SharedCredentialsProvider::new(c))
       .region(Region::new("local-env"))
       .endpoint_url("http://localhost:5001")
       .build()
}

I'd welcome more options for serialisation as mentioned in my previous comment.
serde_dynamo is IMO a must-have and I would not dare to use dynamo SDK without it because it is incredibly wordy.
// here it would be great if I could serialize it right away but for now I just printed the result or will make a dedicated struct for the output.

//
    println!("AWS_ACCESS_KEY_ID={}",credentials.access_key_id.ok_or_else(|| eyre!("new error message"))?);
    println!("AWS_SECRET_ACCESS_KEY={}",credentials.secret_access_key.ok_or_else(|| eyre!("new error message"))?);
    println!("AWS_SESSION_TOKEN={}",credentials.session_token.ok_or_else(|| eyre!("new error message"))?);
        let expiration: aws_sdk_ecr::primitives::DateTime = credentials.expiration.ok_or_else(|| eyre!("new error message"))?;
    let expiration = expiration.to_chrono_utc()?;
    println!("AWS_CREDENTIAL_EXPIRATION={}",expiration.with_timezone(&Local).to_rfc3339_opts(chrono::SecondsFormat::Millis, true));

Lastly error handling improvements. Our codebase uses eyre::Report (anyhow) and I had problems with surfacing the actual service error up. Instead of some generic string saying "Service error".

I will try to update to the latest version as soon as possible, to see the improvements.

Thanks for the detailed feedback!

Especially around the aws_sdk_config because coming from boto3 I've had a hard time creating a different config other than load_from_env for a local version of dynamoDB.

I think what you're looking for is ConfigLoader. Example usage:
let config = aws_config::from_env()
    .endpoint_url("http://localhost:5001")
    .load()
    .await;

Then 2 similar crates aws-sdk-config and aws-config just add to the pile of confusing information.

Yeah, it's not ideal. Most people will never want aws-sdk-config unless they're using https://aws.amazon.com/config/
Not a lot we can do about this unfortunately.

Lastly error handling improvements. Our codebase uses eyre::Report (anyhow) and I had problems with surfacing the actual service error up. Instead of some generic string saying "Service error".

Take a look at DisplayErrorContext for extracting better error information. Hopefully the nightly-only methods on std::error::Error will become stable some day so that this can be improved.

Would this be a reasonable way to implement the Stream trait?

struct StreamPaginationStream<I> {
    inner: PaginationStream<I>,
}

impl<I> StreamPaginationStream<I> {
    fn new(inner: PaginationStream<I>) -> Self {
        Self { inner }
    }
}

impl<I> Stream for StreamPaginationStream<I>
where
    Self: Unpin,
{
    type Item = I;

    fn poll_next(
        mut self: Pin<&mut Self>,
        cx: &mut std::task::Context<'_>,
    ) -> std::task::Poll<Option<Self::Item>> {
        let fut = self.inner.next();
        let fut = pin!(fut);
        fut.poll(cx)
    }
}

(plus an extension trait to create a StreamPaginationStream when doing ...into_paginator().send().into_stream())

I don't think that will quite work since if your poll_next function returns Poll::Pending, it will actually grab a new next future the next time it is called (after the waker wakes). Therefore, it would skip an item in that case, and it could even cascade if the next item isn't immediately ready.
Unfortunately, you would need to create a finite state machine to make it work.

That makes sense in the general case.  I think that given the implementation of PaginationStream::next(), which calls FnStream::next(), which calls FnStream::poll_next(), the future here doesn't save any state, so it will happen to work with the current implementation, but it could break if this implementation changes.  I think to make it work in the general case, I need to save the Future returned by PaginationStream::next(), and keep polling the same Future until it returns Ready, at which point I can call next() again to get a different Future.

I couldn't easily figure out how to save the Future, but I was able to use the genawaiter crate which I assume does this internally:
[dependencies]
genawaiter = { version = "0.99.1", features = ["futures03"] }

use genawaiter::sync::gen;
use genawaiter::yield_;
...
        let mut stream = ...into_paginator().send();
        let stream = gen!({
            while let Some(output) = stream.next().await {
                yield_!(output);
            }
        });
        // stream now implements Stream

Switched to the more-used async-stream crate:
use async_stream::stream;
...
       let mut stream = ...into_paginator().send();
       let stream = stream!({
            while let Some(output) = stream.next().await {
                yield output;
            }
        });
        // stream now implements Stream

Implemented in https://github.com/smithy-lang/smithy-rs/pull/3299


Find a smart way to link the drills and training

I am looking for idea to link a series of exercises or trainings. This "series" will be made by experience coachs which will have to create coherent and thoughtful sequences adapted to a defined level.
Here is the list of my idea :

At the end of the Training description or drills we could have a link to the next practice. I like this idea because being able to link drills together it's something difficult as a beginner coach
We could add a fourth buttom on the homepage to add "Your next frisbee or fitness drill"

Implemented with programs


Coredump restore application isolate with board_crashdump

Summary
pervious coredump is depend on board_crashdump enabled,
but for some use case, we need to not open crashdump and open coredump restore.
for example AMP case.
also we already finished the blkout stream seek support, should make coredump infomation seek only depend on seek API.
Impact
the coredump infomation position has changed, we now able to put more data in coredump section.
we now able to close board_crash dump and open crash dump restore.
Testing
CI test, local arm-v8m board.

[Experimental Bot, please feedback here]
This PR does not fully meet the NuttX requirements as documented.  While it provides some information, it lacks crucial details and formatting. Here's a breakdown:
Missing/Insufficient Information:

Summary:  While the rationale is explained, the how is missing.  What code was changed and how does it decouple coredump from board_crashdump? How does it leverage the blkout seek support? Be specific.
Impact:

User Impact:  While it mentions a change in the coredump information position, it doesn't explain what this means for the user. Will existing tools need to be updated?  How will users access the extra data?
Build Impact:  Not addressed.  Did adding this functionality change any build flags, dependencies, or configurations?
Hardware Impact:  Not specifically addressed. While an ARM-v8m board is mentioned in testing,  does this change affect all architectures, or only specific ones?  Are there any hardware limitations?
Documentation Impact: Not addressed. Does this require updates to the NuttX documentation?  If so, were these updates provided in the PR?
Security Impact: Not addressed.  Changing how core dumps are handled could have security implications. This needs to be considered and explicitly stated (even if the impact is "NONE").
Compatibility Impact: Not addressed. Does this break any existing functionality or tools that rely on the old coredump behavior?

Testing:

Build Host(s): Insufficient.  OS and compiler versions are missing.  Example: "Linux, Ubuntu 20.04, GCC 9.4.0"
Target(s): Insufficient. Be more specific than "arm-v8m board." Provide the exact board name and configuration. Example: "STM32F429I-DISC1, default configuration"
Logs: Completely missing.  "CI test" is not sufficient.  Provide actual log output demonstrating the functionality before and after the change, specifically showing how the core dump is handled in both scenarios (with and without board_crashdump).

How to Improve the PR:

Elaborate on the "How" in the Summary: Explain the code changes. Did you introduce a new API?  Modify an existing one?  Provide a brief, technical overview of the implementation.
Address all Impact points: Even if the answer is "NO," explicitly state it and briefly explain why.  If "YES," provide detailed explanations.
Provide Specific Testing Information:  Include OS, compiler versions for the build host. Specify the exact target board and configuration.
Include Actual Test Logs:  Show the output before and after the change, focusing on the core dump behavior.  This is crucial for reviewers to verify the functionality.
Consider Documentation: If changes are needed, include them in the PR or create a separate issue/PR for documentation updates.

By addressing these points, the PR will be much clearer, easier to review, and more likely to be accepted.


Renaming sections

If these sections get renamed; will this break things?
| 04-yes-this-is-bad.md | OK
  | 05-this-is-not-normal-flu.md | OK
  | 06-keep-the-main-thing-the-main-thing.md | OK
  | 07-it-is-here.md | OK
  | 08-the-us-healthcare-system.md | No one is prepared
  | 09-relative-to-other-countries.md | Policies that help pandemic control
  | 10-there-is-hope.md | ok

Possible duplicate of #294 ?

It seems to me that Lokalise derives translation keys from filenames so changing filenames will result in "loss of translated strings" for each of these files. That said I'm currently investigating whether we could somehow group the duplicates in Lokalise and prevent this loss.

I have not found a good way to reconcile change of keys. For the recent act_and_prepare we have just decided to let it be translated and ported to the new keys. This was mainly because we did both content change and rename at the same time.
If we can ensure that translations of those keys are up to date, we might port the existing translations to the new keys in an automated fashion rather than have humans do that.


Sso sessions

Reverted to original CAS L&F, styling for SSO Reporting only

@rallportct Seems like you might need to merge with upstream once.

I see the following error
"This branch has conflicts that must be resolved
Only those with write access to this repository can merge pull requests."
Am I trying to issue the request to the wrong level?

No it's the right branch. What you want to do is, switch to the Unicon tracking branch locally. Pull from there. Then switch to your own local branch that is tracking Unicon, and merge with that. Resolve conflicts, then push again.


Sleep Data Screen

@nirvanafan205 has reported that the front-end of the screen is done except for the graph.

Prototype

Thinking of trying to add an area path to indicate color better.


Visualisation of time series

Time estimates: M and M.
Part of sprint #18

The actual 2D platting is easy matplotlib -  gathering the data from the saved trees with log-likelihood (and perhaps calculating the distances) is the larger part.
It might be better to do the #20 first.

The actual 2D platting is easy matplotlib - gathering the data from the saved trees with log-likelihood (and perhaps calculating the distances) is the larger part.
It might be better to do the #20 first.

Good point, I have similar intuition :slightly_smiling_face:
(And it also depends on #22 , which I'll probably do on Friday)

[ ] The plot with X axis being iteration number, Y axis being the loglikelihood of the sampled tree.
[ ] The number of iterations needed to sample the true tree.
[ ] Plot of the distance to the true tree on the Y axis for several chains and the iteration number on X axis.

Objectives:
Planned to happen in 3 smaller PRs.

[]

First PR to implement Objective 2,3 submitted for review. #38

On cold until #48  is resolved.

Current Early State:

Still missing:

[ ] has true tree been reached
[ ] plot the most likely and starting / true tree


conflict with exported CMake target for HDF5 with ITK_USE_SYSTEM_HDF5=OFF

Description
When using ITK_USE_SYSTEM_HDF5=OFF, ITK exports hdf5_cpp-shared and hdf5-shared  (or the non-shared) targets but this is incorrect for 2 reasons:

they point to the ITK HDF5 libraries which are not compatible with not normal HDF5 libraries
they cause conflicts when using find_package(HDF5) after find_package(ITK)

In my opinion, those targets should be renamed to itkhdf*.
Steps to Reproduce
The following CMakeLists.txt illustrates both problems
make_minimum_required(VERSION 3.9.0)
PROJECT(TEST)
include(CMakePrintHelpers)
find_package(ITK)
cmake_print_properties(
    TARGETS hdf5_cpp-shared hdf5-shared
    PROPERTIES IMPORTED_LOCATION_RELEASE IMPORTED_LOCATION_RELWITHDEBINFO IMPORTED_LOCATION_DEBUG
          IMPORTED_LOCATION
    )
find_package(HDF5 COMPONENTS C REQUIRED)

Expected behavior
This should just find an "external" HDF5
Actual behavior
After building/installing ITK master and HDF5 1.13.1, CMake outputs
Properties for TARGET hdf5_cpp-shared:
   hdf5_cpp-shared.IMPORTED_LOCATION_RELEASE = <NOTFOUND>
   hdf5_cpp-shared.IMPORTED_LOCATION_RELWITHDEBINFO = "C:/Users/krisf/INSTALL/bin/itkhdf5_cpp-shared-5.2.dll"
   hdf5_cpp-shared.IMPORTED_LOCATION_DEBUG = <NOTFOUND>
   hdf5_cpp-shared.IMPORTED_LOCATION = <NOTFOUND>

 Properties for TARGET hdf5-shared:
   hdf5-shared.IMPORTED_LOCATION_RELEASE = <NOTFOUND>
   hdf5-shared.IMPORTED_LOCATION_RELWITHDEBINFO = "C:/Users/krisf/Documents/INSTALL/bin/itkhdf5-shared-5.2.dll"
   hdf5-shared.IMPORTED_LOCATION_DEBUG = <NOTFOUND>
   hdf5-shared.IMPORTED_LOCATION = <NOTFOUND>

CMake Error at C:/Users/krisf/Documents/INSTALL/cmake/hdf5-targets.cmake:37 (message):
  Some (but not all) targets in this export set were already defined.

  Targets Defined: hdf5-shared;hdf5_cpp-shared

  Targets not yet defined:
  hdf5-static;mirror_server;mirror_server_stop;hdf5_cpp-static

Reproducibility
all the time.
Versions
Tested with ITK 5.2.1 and current master
Environment
Tested on Windows 10 with VC 2019, CMake 3.22.3, but this will happen everywhere.

Probably root-cause of https://github.com/microsoft/vcpkg/issues/15502

@hjmjohnson @seanm do you agree with "those targets should be renamed to itkhdf*"?
@KrisThielemans PRs are welcome.

I'm not qualified to say, I know very little about cmake.
But I do observe that literally everything else in the lib folder when I install itk is prefixed with libitk, at least with the build options I use.

Since HDF5 has a rich CMake support, I think we try to just compile it. I think we do that because we think it can be used as a normal HDF5 build. I guess Kris feels differently?
Maybe find_package needs to be modified? @bradking do you have an opinion?
Or maybe it is just needed to have find_package(HDF5) before find_package(ITK), if the application developer intends to use another HDF5 build?

We already do that for HDF5. I think the problem here are CMake target names.

Yes, that's why I mentioned the CMakeLists.txt files for our imported HDF5 code may need to be updated to add the itk prefix to target names.

@bradking , I cannot find where you wrote this.
Would this need some sed magic in https://github.com/InsightSoftwareConsortium/ITK/blob/master/Modules/ThirdParty/HDF5/UpdateFromUpstream.sh?
After changing the tags, presumably we'd also need to change https://github.com/InsightSoftwareConsortium/ITK/blob/9de2b57048f9f0022bdf068186f07937f26dc102/Modules/ThirdParty/HDF5/CMakeLists.txt#L80-L84

I cannot find where you wrote this.

In https://github.com/InsightSoftwareConsortium/ITK/issues/3315#issuecomment-1074089102:

we also patch the CMakeLists.txt files to add the itk prefix to the target names.  That's probably needed for HDF5 too.

Anyway, the UpdateFromUpstream.sh script probably won't be able to reliably find the right places to update.  It currently prints out a reminder to manually update the mangling.  We'd probably have to manually edit the CMakeLists.txt files from HDF5 to add the target name prefix too.

manually edit the CMakeLists.txt files from HDF5 to add the target name prefix

We do occasionally manually edit HDF5's source code, 1be1b170e6eb994ba18a9baa3c664098370ffce7 is a recent example. Changing CMake target names should not be hard. That would prevent people from using bundled HDF5 as a normal HDF5 build. But I guess there aren't many who do that, so it wouldn't be a big loss.
Kris, do you mind making a PR?


Mention UsernameWithEmailJavaScriptRegEx property in Email as Username doc

When using email as a username we need to mention in the doc [1] that we need to add the UsernameWithEmailJavaScriptRegEx property to the UserStore config. This is only mentioned at [2]
[1] - https://docs.wso2.com/display/IS570/Using+Email+Address+as+the+Username
[2] - https://docs.wso2.com/display/ADMIN44x/Working+with+Properties+of+User+Stores

Duplicate of https://github.com/wso2/product-is/issues/13079


Updated PasswordModel

TO-DO
Table of Contents

[x] Identify the component the PR relates to in brackets in the title.
PasswordModel
[x] It solves an issue
[x] Link to GitHub issues it solves.
closes #6
[x] Sign the CLA bot. You can do this once the pull request is opened.

Contributing
has more information and tips for a great pull request.

@zeobot set lc to pass


Added new tasks to Magento Recipes and support Enterprise Edition

Q
A

Bug fix?
No

New feature?
Yes

BC breaks?
No

Deprecations?
No

Fixed tickets
N/A

CI fail.

Solved CI


Installer rework

I added basic support for JDK9/JDK10 by extending the archive push code. Then I decoupled string constants from the program code.
I haven't tested it, there will be bugs.

Starting the Code Review

Hi @JakubVanek, can you send the pull request to Develop Branch please?
This repo follow Gitflow:
https://www.atlassian.com/git/tutorials/comparing-workflows/gitflow-workflow
Master is the final branch, but Develop branch is for stable Development.  I need to execute tests in the Brick with latest changes. If you observe, Master branch doesn´t have latest commits. The latest commits is from Develop.
From Develop I will test all cases on the Brick.
Juan Antonio

Wel, you should be able to create the PR as well, or to perform a local merge.


Add support for Jaeger tracing

This PR adds support for Jaeger tracing and updates Go to v1.13. A user can configure the Envoy sidecar with Jaeger using the following command args:

-enable-jaeger-tracing=true (defaults to false)
-jaeger-address=appmesh-jaeger.appmesh-system
-jaeger-port=9411

Tested on EKS 1.13 with Jaeger 1.14

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

In order to test this:

create the appmesh-system namespace and apply the CRDs

kubectl create ns appmesh-system
kubectl apply -f https://raw.githubusercontent.com/aws/eks-charts/master/stable/appmesh-controller/crds/crds.yaml

install the App Mesh controller

helm repo add eks https://aws.github.io/eks-charts
helm upgrade -i appmesh-controller eks/appmesh-controller \
--wait --namespace appmesh-system

install Jaeger and App Mesh Inject from my repo

git clone https://github.com/stefanprodan/eks-charts/
cd eks-charts
git checkout jaeger

# Install Jaeger
helm upgrade -i appmesh-jaeger ./stable/appmesh-jaeger \
--wait --namespace appmesh-system

# Install App Mesh inject
helm upgrade -i appmesh-inject ./stable/appmesh-inject \
--wait --namespace appmesh-system \
--set image.repository=stefanprodan/aws-app-mesh-inject \
--set image.tag=jaeger.9 \
--set tracing.jaeger.enabled=true \
--set tracing.jaeger.address=appmesh-jaeger.appmesh-system \
--set tracing.jaeger.port= 9411

setup the App Mesh demo app
open Jaeger UI and check the traces

kubectl -n appmesh-system port-forward svc/appmesh-jaeger 16686:16686


FSMControl for entities

Usage: new FSMControl(RunningState.class, JumpingState.class, DuckingState.class). The key difference is that an entity can be controlled by only 1 state at a time:
entity.getControlUnsafe(FSMControl.class).setState(RunningState.class);

Each state could have:
onEnter();
onExit();
onUpdate();

and access to the controlled entity.

see gdx AI

Completed in com.almasb.fxgl.extra.entity.state.StateComponent


Allow to disable points validation and/or XWS import

Is your feature request related to a problem? Please describe.
My biggest problem with FlyCasual is when I go to try out a list, the points for ships and upgrades are not up to date, resulting in not being able to even build the list. Now that we have multiple point systems between AMG and XWA (not to mention Legacy 2.0), the problem is compounded.
Describe the solution you'd like
Rather than attempt to implement all the different point systems and try keeping them up to date, a "simple" and flexible option would be to allow points restrictions to be turned off so that you can build any list regardless of whether it exceeds what is currently considered the "correct" points.
That's Phase 1, just a checkbox in the UI for unrestricted building mode, and let the user add whatever they want.
Of course there can be other limitations besides points changes. Individual ships can have slots added and removed as part of a points change. So Phase 2 could be a preference toggle for "developer mode" which would allow you to add any upgrade slot to any ship.
Phase 3 would be extending "developer mode" to modify ship stats and action bar.
But really Phase 1 would go a long way.
Describe alternatives you've considered
There's another alternative method I've considered that would address this issue, and that would be a list building mode based on pasting XWS formatted text.
All the list builders currently in use are able to export lists in XWS format. So let the list builders handle the logic for points and list building restrictions and allow users to paste in their exported XWS.
You could then use the XWS description of the list, the pilots and their upgrades and skip any validation (except perhaps unknown pilots).
You could maybe make lists imported by XWS read-only and unable to be edited if you want to skip the whole UI and validation stuff and if a user wants to make changes, they update their list in their app of choice and re-import the list.

Sorry, I'm not sure how to add the "Enhancement" tag.

Removing point limits is already available under Options > Extras > No Squad Builder Limits. Regarding XWS loading, there is an import function (after selecting faction, go to Squad and Import) but allowing a free-for-all loading wouldn't work due to the behind the scenes functionality of the pilots--it's not as easy as saying "Has Han Solo's Pilot Ability." Fly Casual was never really intended for Home Brew like you're suggesting for Phase 2 however.
Also, if you see any ships that aren't correct as far as posted points go, please let me know. The reason I took over the repo is because Sandrem is involved in the Ukraine war and points weren't up-to-date. My intention is that points will be up within two weeks of posting and I've only missed that target once (excepting the first point update which was published before I took over the repo). I am currently working on a plan for allowing different a selection of points (XWA, AMG, old point lists, etc) but it's still in-progress.
I'm closing this issue as I believe that the requests are already in-place or out-of-scope for the project but if you feel that the options currently available don't meet your needs, let me know.


Sidebar arrow pointing the wrong way

Describe the bug
When you have Resize type set to Keep window size, the arrow to open/close the sidebar points the wrong way.
Screenshots

Environment (please complete the following information):

OS: Windows 10
RuneLite version: 1.5.13-SNAPSHOT
Launcher version: Unknown

We are surely not going to flip the icon just based on that configuration property, I will rather keep it point same direction all the time (its also how it works without custom chrome). Main thing is that the icon is different based on sidebar state, so, its fine :d


[SPIRV] Support unorm and snorm modifier in Texture element type.

We should use this to derive image format.

Fixed in #3655.


Support at least one open source community discussion platform

Is your feature request related to a problem? Please describe.
Currently the README says

Join us using discord at: https://discord.gg/hdt7t7jpvn

As a privacy-conscious individual, I do not wish to join any more closed-source, private platforms than strictly necessary. https://drewdevault.com/2021/12/28/Dont-use-Discord-for-FOSS.html
Describe the solution you'd like
I would expect an officially sanctioned IRC room on Libera.Chat or public space on some Matrix instance (like Matrix.org) or part of the Functional Programming Zulip.
Describe alternatives you've considered
There is no alternative. Discord will collect data on users and will not talk through an open protocol like IRC, XMPP, Matrix, etc. All users most agree to Discord ToS (which they can change at any time) to participate which is not a welcoming experience. Discord is even hostile towards all open source client alternatives demanding cease and desists.
Additional context
A Git mirror not on Microsoft's GitHub may be a bridge too far...

While I agree with your feeling related to privacy I have to say that we are growing and managing the community much better since we migrated it from the FP slack to Discord. I don't believe it to be an advantage to fracture the community in multiple places and we have not found any better platform from the perspective of community building than Discord.
A thing should be said, Effect is indeed an open source project and individuals can, and if they care should, take independent actions. That is if you, or anyone else, wants to support a different community chat they should do so (I won't guarantee that I'll join it if not in a platform that I already have and that is easily accessible but I support the idea of individual actions and difference of thought).
From my perspective I should also share why I started Effect in the first place and what are my beliefs regarding open source, I personally believe the only way to make successful open source projects (valid to be used in a commercial setting) is to have commercial initiative and justify the time spent in open source, without that there isn't any cash to be spent and we enter in the whole "open source funding problem" that many have tried and failed to solve, in this case the initial heavy lifting was sponsored by CreditSCRIPT where I am CTO and that uses Effect internally since before it was public (it started as an app module to build backend systems in node.js more safely) and by MATECHS where I am CEO and that took the project from "an internal app module" to what it is today, both companies profit in some sense from Effect.
Note that with the above I don't intend to minimize in any way the importance of community contributions, in fact they are of core essence and have been growing insanely to the point where at the moment I am no longer the most active contributor of Effect and I cannot say how proud I am about that :)
This just to provide context to safely say (hopefully without misunderstanding) that while Effect is OSS our involvement with it is very much Commercial and the current Discord community is incubated by MATECHS GARAGE LTD that actively manages it, I don't envision this for the very long term because MATECHS GARAGE LTD is supposed to be an early-stage incubator but until the point where Effect is big enough to justify forming its own foundation this setup ensures that there is enough push to grow and that there is a properly managed community that can be a safe space for everyone.

Well, I mean, isn't Slack also rather proprietary? I mean I don't know if the garden has as many walls as Discord's garden but "one proprietary discussion platform is working better for us than another such platform did" hardly seems like a convincing argument to always use a proprietary discussion platform, though I get where you're coming from saying you lack the moderation bandwidth to handle two discussion platforms, which makes it a bit tricky to try things out ...

Would you consider enabling the "Discussions" tab for the repo? I'm not particularly opposed to Discord, except for FAQs getting swallowed into chat history rather than being more discoverable.

Closing due to inactivity, for context we are currently evaluating Discourse as a replacement of Discord.


Resume.html

It will generate a simple templet of Resume/Cv. Taking some input to individual details, can upload profile picture and also can print CV.

@PriyankV25 please read the following Contributor License Agreement(CLA). If you agree with the CLA, please reply with the following information.
@microsoft-github-policy-service agree [company="{your company}"]

Options:

(default - no company specified) I have sole ownership of intellectual property rights to my Submissions and I am not making Submissions in the course of work for my employer.
(when company given) I am making Submissions in the course of work for my employer (or my employer has intellectual property rights in my Submissions by contract or applicable law). I have permission from my employer to make Submissions and enter into this Agreement on behalf of my employer. By signing below, the defined term “You” includes me and my employer.

Contributor License Agreement
Contribution License Agreement
This Contribution License Agreement (“Agreement”) is agreed to by the party signing below (“You”), and conveys certain license rights to Microsoft Corporation and its affiliates (“Microsoft”) for Your contributions to Microsoft open source projects. This Agreement is effective as of the latest signature date below.

Definitions.
“Code” means the computer software code, whether in human-readable or machine-executable form,
that is delivered by You to Microsoft under this Agreement.
“Project” means any of the projects owned or managed by Microsoft and offered under a license
approved by the Open Source Initiative (www.opensource.org).
“Submit” is the act of uploading, submitting, transmitting, or distributing code or other content to any
Project, including but not limited to communication on electronic mailing lists, source code control
systems, and issue tracking systems that are managed by, or on behalf of, the Project for the purpose of
discussing and improving that Project, but excluding communication that is conspicuously marked or
otherwise designated in writing by You as “Not a Submission.”
“Submission” means the Code and any other copyrightable material Submitted by You, including any
associated comments and documentation.
Your Submission. You must agree to the terms of this Agreement before making a Submission to any
Project. This Agreement covers any and all Submissions that You, now or in the future (except as
described in Section 4 below), Submit to any Project.
Originality of Work. You represent that each of Your Submissions is entirely Your original work.
Should You wish to Submit materials that are not Your original work, You may Submit them separately
to the Project if You (a) retain all copyright and license information that was in the materials as You
received them, (b) in the description accompanying Your Submission, include the phrase “Submission
containing materials of a third party:” followed by the names of the third party and any licenses or other
restrictions of which You are aware, and (c) follow any other instructions in the Project’s written
guidelines concerning Submissions.
Your Employer. References to “employer” in this Agreement include Your employer or anyone else
for whom You are acting in making Your Submission, e.g. as a contractor, vendor, or agent. If Your
Submission is made in the course of Your work for an employer or Your employer has intellectual
property rights in Your Submission by contract or applicable law, You must secure permission from Your
employer to make the Submission before signing this Agreement. In that case, the term “You” in this
Agreement will refer to You and the employer collectively. If You change employers in the future and
desire to Submit additional Submissions for the new employer, then You agree to sign a new Agreement
and secure permission from the new employer before Submitting those Submissions.
Licenses.

Copyright License. You grant Microsoft, and those who receive the Submission directly or
indirectly from Microsoft, a perpetual, worldwide, non-exclusive, royalty-free, irrevocable license in the
Submission to reproduce, prepare derivative works of, publicly display, publicly perform, and distribute
the Submission and such derivative works, and to sublicense any or all of the foregoing rights to third
parties.
Patent License. You grant Microsoft, and those who receive the Submission directly or
indirectly from Microsoft, a perpetual, worldwide, non-exclusive, royalty-free, irrevocable license under
Your patent claims that are necessarily infringed by the Submission or the combination of the
Submission with the Project to which it was Submitted to make, have made, use, offer to sell, sell and
import or otherwise dispose of the Submission alone or with the Project.
Other Rights Reserved. Each party reserves all rights not expressly granted in this Agreement.
No additional licenses or rights whatsoever (including, without limitation, any implied licenses) are
granted by implication, exhaustion, estoppel or otherwise.

Representations and Warranties. You represent that You are legally entitled to grant the above
licenses. You represent that each of Your Submissions is entirely Your original work (except as You may
have disclosed under Section 3). You represent that You have secured permission from Your employer to
make the Submission in cases where Your Submission is made in the course of Your work for Your
employer or Your employer has intellectual property rights in Your Submission by contract or applicable
law. If You are signing this Agreement on behalf of Your employer, You represent and warrant that You
have the necessary authority to bind the listed employer to the obligations contained in this Agreement.
You are not expected to provide support for Your Submission, unless You choose to do so. UNLESS
REQUIRED BY APPLICABLE LAW OR AGREED TO IN WRITING, AND EXCEPT FOR THE WARRANTIES
EXPRESSLY STATED IN SECTIONS 3, 4, AND 6, THE SUBMISSION PROVIDED UNDER THIS AGREEMENT IS
PROVIDED WITHOUT WARRANTY OF ANY KIND, INCLUDING, BUT NOT LIMITED TO, ANY WARRANTY OF
NONINFRINGEMENT, MERCHANTABILITY, OR FITNESS FOR A PARTICULAR PURPOSE.
Notice to Microsoft. You agree to notify Microsoft in writing of any facts or circumstances of which
You later become aware that would make Your representations in this Agreement inaccurate in any
respect.
Information about Submissions. You agree that contributions to Projects and information about
contributions may be maintained indefinitely and disclosed publicly, including Your name and other
information that You submit with Your Submission.
Governing Law/Jurisdiction. This Agreement is governed by the laws of the State of Washington, and
the parties consent to exclusive jurisdiction and venue in the federal courts sitting in King County,
Washington, unless no federal subject matter jurisdiction exists, in which case the parties consent to
exclusive jurisdiction and venue in the Superior Court of King County, Washington. The parties waive all
defenses of lack of personal jurisdiction and forum non-conveniens.
Entire Agreement/Assignment. This Agreement is the entire agreement between the parties, and
supersedes any and all prior agreements, understandings or communications, written or oral, between
the parties relating to the subject matter hereof. This Agreement may be assigned by Microsoft.

I	have	sole	ownership	of	intellectual	property	rights	to	my	Submissions	and	I	am	not	making
Submissions	in	the	course	of	work	for	my	employer.
Name(YOU): Priyank Saxena
Signature: Priyank Saxena
Date: 11/10/2022
Github Login: https://github.com/PriyankV25
Email<EMAIL_ADDRESS>Address: A/30 Guru Nanak Nagar, Mathura, U.P., India

I have sole ownership of intellectual property rights to my Submissions and I am not making
Submissions in the course of work for my employer.
Name(YOU): Priyank Saxena
Signature: Priyank Saxena
Date: 11/10/2022
Github Login: https://github.com/PriyankV25
Email<EMAIL_ADDRESS>Address: A/30 Guru Nanak Nagar, Mathura, U.P., India

I am a beginner, first time contributing into HacktoberFest. Plz guide and accept pull request to merge in the main branch if find no issues.

Thanks @PriyankV25 for your suggestion. For now, as this doesn't directly connect to any of the current lessons, the best place to share your creation would be in https://github.com/microsoft/Web-Dev-For-Beginners/discussions/categories/show-and-tell.
Closing this PR so you can share sample project within Discussions. When we build out the ability to onboard additional projects to our repo for extra practice and exercises, we will announce to the community.
In the meantime, please check out our Build a Resume Website project to review for potential improvements.
Thank you!


.typeText() action fail

Describe the bug

Few weeks ago, I've let my detox branch on WIP. It worked well when I left it, today I had to upgrade kotlin version from 1.3.10 to 1.4.20 due to a build fail. And now build work, I could run my test but the '.typeText()' action won't work now.. I tried on release and debug build, same issue.
Steps To Reproduce

[x] I have tested this issue on the latest Detox release and it still reproduces

Add for example : await element(by.id('loginBox-email-input')).typeText("MyEmail");

Expected behavior

Having text on my input, actually it just open the keyboard and crash (See the video).
Detox Trace-Logs

https://pastebin.com/C01KQiV6
Device logs (adb logcat)

detox-json-log : https://pastebin.com/VhTaUSm4
detox-log : https://pastebin.com/4W7eZtBx
startup-log : https://pastebin.com/n4UuY7kJ
Screenshots

https://user-images.githubusercontent.com/18298759/108889635-e6df2180-760c-11eb-81b2-4f8aa966de3f.mp4
Environment (please complete the following information):

Detox: 18.6.2
React Native: 0.62.0
Node: 10.20.1
Device: Android
OS: WSL 1
Test-runner (select one): jest-circus

Ok.. It worked with another simulator, weird case


Added GeneratedCodeAttribute [#107]

Had some spare time so did the work, this reduces the number of warnings in our build as suspected!

Thanks - will review as soon as I have a minute!

Oh my this is old, not going to merge the PR directly but copy/paste things. (see issue #107)

Thank you for including the changes! And better late then never 👍


Cow: Watch getmed24.com

Cow requests the watch of the watch_keyword getmed24\.com. See the MS search here and the Stack Exchange search in text, in URLs, and in code.

getmed24\.com has been seen in 1 true positive, 0 false positives, and 0 NAAs.

Approved by Jeff Schaller in Charcoal HQ


Consider using ES6 (EMCA6) feature using Babel

This is a low priority item but we should plan on doing this in next 2-3 months. At that time it would be good to discuss class design in GeoJS.

Now that it's 3 years later, I think this has become more important -- using modern language features can drastically improve the development experience. At least, I would vote to prioritize this, especially since it's so easy to support this from where geojs is right now.

I hacked this into a development environment, and the only issue I saw was with jQuery global usage (so addressing #862 would make this trivial).


Added Way Cooler to README

Wasn't sure where to put it, since it doesn't really fit in under the categories. Made a new category "Window Managers" since I could foresee others going here as well.
Please tell me if there is a better place to put it.

That's a good question. I merge as it is for the time being.
Thank you.


Make telemetry support available for debug adapters

Today debug adapters can only specify that failures from a request are sent to telemetry. It is not (easily) possible to send telemetry for things other than errors.
In this feature we will extend the OutputEvent with a new category 'telemetry' and add support for sending structured objects (in addition to the existing string).
CC @gregg-miskelly @isidorn

@isidorn I've introduced a new OutputEvent category telemetry and added an optional attribute data.  Please send output events with category telemetry to telemetry. The name of the telemetry event is expected in the output attribute and properties for the event live in the data object.


Expose mutation metrics to prometheus

This leverages system.mutations table to expose mutations metrics to prometheus.
For ref : https://clickhouse.yandex/docs/en/operations/system_tables/#system_tables-mutations

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.Arun Sori seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.You have signed the CLA already but the status is still pending? Let us recheck it.

close as outdated, sorry for late response


Using pump fails silently

I'm not sure if this or gulp-pump is the right place for this issue, if this is not, I'm sorry.
Using uglify with pump fails silently. Had a bunch of js files and one of them had ES6 arrow functions. Instead of throwing error, it just ignores it. Without pump the error is thrown.

Can you show your gulpfile? Did you make sure to pass the callback function into pump? An error is pretty-printed here.

No, I had not passed the callback function. With callback the error get's printed. Thanks!


"Frătăuții Vechi" is listed in the drop-down menu

Description:
"Frătăuții Vechi" is listed in the drop-down menu alongside its corresponding county according to the law
Precondition:
The website is up an running.

Step 1
Type "Frătăuții Vechi" in the search bar.

Expected results
The location is listed in the drop-down menu as "Comuna Frătăuții Vechi, SUCEAVA".


Add HEAD shortcut route

Fixes #2033

Coverage decreased (-0.06%) to 97.139% when pulling 57ae56068db8a8844a3afef4a6eded7e3063ece6 on chadicus:fea/head-shortcut into 2f29cc2e3042bfa8c6a9078486ea174acb6a69e8 on slimphp:3.x.

Coverage increased (+0.002%) to 97.2% when pulling 6b9c82fbf25ea63197b0b29b17e83d64465bbba3 on chadicus:fea/head-shortcut into 2f29cc2e3042bfa8c6a9078486ea174acb6a69e8 on slimphp:3.x.

Is there a reason you want to define routes that respond ONLY to head requests? You should already be able to issue HEAD requests  against any GET route, you just won't  get back the response body, just the header.

See https://github.com/nikic/FastRoute#a-note-on-head-requests (which Slim uses under the hood)

@codeguy I just saw the issue discussion and thought I'd lend a hand by adding the method. I have no use case for HEAD requests. Feel free to reject the PR.

Coverage increased (+0.002%) to 97.2% when pulling cae06a714e1c40ccca29d3008eba445ad2aad8b2 on chadicus:fea/head-shortcut into 2f29cc2e3042bfa8c6a9078486ea174acb6a69e8 on slimphp:3.x.

From FastRoute

Finally, note that applications MAY always specify their own HEAD method route for a given resource to bypass this behavior entirely.

👍 for me.

Not needed as no one has a use case for responding to HEAD differently to GET.

@akrabat https://github.com/slimphp/Slim/issues/2033#issuecomment-278341137


negative balance on some wallets

Check why after creating the blockchain some wallets have a negative balance

Fixed in sprint-9-transaction-fix. Main issue was with not adding coinbase transactions to wallets


Make docs and developer guidelines

i.e. resources for contributors and users

consider using https://github.com/mkdocs/mkdocs


4.1.0

Disregard the name of the branch :P
4.1.0
After I merge this PR I'll release v4.1.0 with the main following changes:
Feel free to leave any suggestions, comments, nitpicks, etc.!

Introduces fixes and changes made by @ruicanas and @chphmh
Reduced the requirements for the library as a whole to Android SDK 7 and Java 8 (@Doomsdayrs)
A small change to the Android example to make it easier to detect any visual issues. Added a light background color to the QRCode View screen:

Once again, I have no words to how grateful I am to you all for using and contributing to the library ^^
Happy holidays, Merry Christmas, Happy New Year everyone!

Hello @g0dkar, thank you for introducing a fix for the problem I mentioned in #107!
I'm not sure if I understand it completely though: As far as I got it, in renderShaded() if the QR code has a margin > 0, one big square should be drawn with marginColor that covers the whole QR code's background including the margin around the actual code cells? (https://github.com/g0dkar/qrcode-kotlin/blame/dc4e32f20d6199b46a65fca5c9635f6bd2b1a8ee/src/commonMain/kotlin/qrcode/raw/QRCodeProcessor.kt#L284)
Now with the new change in render() in line https://github.com/g0dkar/qrcode-kotlin/blame/dc4e32f20d6199b46a65fca5c9635f6bd2b1a8ee/src/commonMain/kotlin/qrcode/raw/QRCodeProcessor.kt#L231 the margin rectangle that is drawn has the size margin,margin. Shouldn't it be the size of the whole QR code instead (the number that computeImageSize() calculates with sizecellSize+margin2, or am I misunderstanding something here?


Review new Recruiting Pipeline channel

Pipeline sheet

[ ] Review Test Channel (Slack Workspace) in Row 2
[ ] Set Display value (column L) to TRUE or FALSE

Zapier test completed. Pipeline doc now live.


Ability to search multiple repos for possible issues

We currently have a simple search of a single repo to look for Possible Issues from a link in the Action column.  In real use cases, there are multiple repos that would need to be searched in order to determine if this issue exists and has been reported somewhere.
Possible issues logic should be updated to be able to search multiple repos, and list all possible related issues in a listing, with links to the individual repos or issues.

FYI @LongyuZhang

This feature is implemented. Close this issue.


Add action to deploy typedocs

Coverage increased (+0.8%) to 82.737% when pulling b864eb3d778b012ccc5dc00161917e256eea614e on typedoc-action into ec4dc9faf595c0b68881d37592e28cf7dcac3c0d on master.


Can not run project

Hello, after cloning the repo and installing the packages with npm install I tried to run the app just like you did in your video
When I tried to run npm run start, the development engine crashes and I got the following message:
Starting the development server...
Error: error:0308010C:digital envelope routines::unsupported
    at new Hash (node:internal/crypto/hash:80:19)
    at Object.createHash (node:crypto:139:10)
    at module.exports (/Users/yarivshamash/Projects/firestore-react-crud/node_modules/webpack/lib/util/createHash.js:135:53)
    at NormalModule._initBuildHash (/Users/yarivshamash/Projects/firestore-react-crud/node_modules/webpack/lib/NormalModule.js:417:16)
    at handleParseError (/Users/yarivshamash/Projects/firestore-react-crud/node_modules/webpack/lib/NormalModule.js:471:10)
    at /Users/yarivshamash/Projects/firestore-react-crud/node_modules/webpack/lib/NormalModule.js:503:5
    at /Users/yarivshamash/Projects/firestore-react-crud/node_modules/webpack/lib/NormalModule.js:358:12
    at /Users/yarivshamash/Projects/firestore-react-crud/node_modules/loader-runner/lib/LoaderRunner.js:373:3
    at iterateNormalLoaders (/Users/yarivshamash/Projects/firestore-react-crud/node_modules/loader-runner/lib/LoaderRunner.js:214:10)
    at iterateNormalLoaders (/Users/yarivshamash/Projects/firestore-react-crud/node_modules/loader-runner/lib/LoaderRunner.js:221:10)
/Users/yarivshamash/Projects/firestore-react-crud/node_modules/react-scripts/scripts/start.js:19
  throw err;
  ^

Error: error:0308010C:digital envelope routines::unsupported
    at new Hash (node:internal/crypto/hash:80:19)
    at Object.createHash (node:crypto:139:10)
    at module.exports (/Users/yarivshamash/Projects/firestore-react-crud/node_modules/webpack/lib/util/createHash.js:135:53)
    at NormalModule._initBuildHash (/Users/yarivshamash/Projects/firestore-react-crud/node_modules/webpack/lib/NormalModule.js:417:16)
    at /Users/yarivshamash/Projects/firestore-react-crud/node_modules/webpack/lib/NormalModule.js:452:10
    at /Users/yarivshamash/Projects/firestore-react-crud/node_modules/webpack/lib/NormalModule.js:323:13
    at /Users/yarivshamash/Projects/firestore-react-crud/node_modules/loader-runner/lib/LoaderRunner.js:367:11
    at /Users/yarivshamash/Projects/firestore-react-crud/node_modules/loader-runner/lib/LoaderRunner.js:233:18
    at context.callback (/Users/yarivshamash/Projects/firestore-react-crud/node_modules/loader-runner/lib/LoaderRunner.js:111:13)
    at /Users/yarivshamash/Projects/firestore-react-crud/node_modules/babel-loader/lib/index.js:59:103 {
  opensslErrorStack: [
    'error:03000086:digital envelope routines::initialization error',
    'error:0308010C:digital envelope routines::unsupported'
  ],
  library: 'digital envelope routines',
  reason: 'unsupported',
  code: 'ERR_OSSL_EVP_UNSUPPORTED'
}

Node.js v20.12.2

I tried running it on Node.js v16.20.2 but it's not suitable with the peer dependency @types/node.
Did you encounter similar problems?
Do you have any recommendation of how to solve this issue?

Option 1: Set the OpenSSL legacy provider (Quickest solution):
On Mac/Linux:
export NODE_OPTIONS=--openssl-legacy-provider
npm start
On Windows:
set NODE_OPTIONS=--openssl-legacy-provider
npm start
Option 2: Downgrade Node.js (More permanent solution)


Lefthook doesn't block commits when using a --fix or --write option.

:wrench: Summary
When adding linting checks for pre-commit (e.g. prettier, eslint, markdownlint) using the --fix option, the commit still goes through and fixes the file afterwards.
Lefthook version
Using lefthook version 1.3.2
Steps to reproduce
Commit file with fixable linting error, when having a linting check in pre-commit with the --fix option.
Expected results
If a file is automatically fixed by resolving the linting issues, I would want my commit to still be blocked, but fix the file.
Only way to circumvent this for the moment: do 2 separate checks: one purely for verifying, and one for fixing. However, this decreases the speed of the pre-commit checking a lot.
Actual results
Commit with linting mistakes still goes through, while file is fixed.
Possible Solution
Either on the side of the specific packages: add error code when fixes are executed
For lefthook: keep track when fix has happened and give the option to block commits in these types of cases.
(Specifically for prettier: there is a package pretty-quick that gives the option to --bail when a fix happens and still block the commit, but such a solution is not available for each linter.)

Hey @ava-mc! It's a good idea but I have concerns about the solution. The reason lefthook doesn't block commits is - the linter's return code is 0, so it finishes successfully. Many people want lefthook to behave smoothly and add changes for fixed files automatically.
I can recommend you the following configuration to get what you want:
pre-commit:
  commands:
    lint:
      # it looks like a hack but it makes sense that commands should fail (return non-0) to fail the hook
      run: npm run lint || (npm run lint --fix && exit 1)

Or if you want to automatically add fixed files to the commit, use the following:
pre-commit:
  commands:
    lint:
      run: npm run lint {staged_files} --fix && git add {staged_files}

I am going to add an auto-add changes files option, but still can't decide on naming. Anyway, please write if this works for you.

@mrexox great that you're going to add an "auto-add changed files" option.
I would suggest that as long as #64 has not been implemented/merged the documentation is updated with your recommendations.

@mrexox I guess this issue can be closed since #64 is completed, allowing changed files to be added with https://github.com/evilmartians/lefthook/blob/master/docs/configuration.md#stage_fixed


Change the selected row state

Hi there,
Thanks for your prompt response.
I'm going to show users a selected state for children rows. but Library each time user open parent row, insert new row and change the position! then when user scroll the list, may have see multiple row is selected!!
I'm using SparseBooleanArray to map integer to Boolean for this goal. but when position had change this solution is worthless!
How you handle it?

Yes, when the parent is expanded/collapsed the children are inserted and removed dynamically.  So, you would need to enhance the library to maintain selected state as those views are regenerated. It shouldn't be too difficult.

But I stuck here! :(
Is it possible for you to provide an example?

I understand. Unfortunately you are asking for a feature that does not exist, so there's no example to be made yet.

Hi there, I've finally solved the issue tonight :D
I'm using this library to populate my app categories and their subs. sub categories have id.
I defined two SparseBooleanArray to keep SelectedPosition and mSelectedPositionCatID
in OnBindViewHolder and in child type:
			View	view	= holder.itemView;

			int	currentPositionCatId		= visibleItems.get(position).ROW_ID;

			if(mSelectedPositionCatID.size() > 0){

				if(currentPosotionCatId == mSelectedPositionCatID.keyAt(0)){
					view.setBackgroundColor(mContext.getResources().getColor(R.color.wisgoon_Likers_activity_background));
				}else{
					view.setBackgroundColor(mContext.getResources().getColor(android.R.color.transparent));
				}

			}

			view.setOnClickListener(new OnClickListener() {

				@Override
				public void onClick(View v) {

					mSelectedTitle	= visibleItems.get(position).ROW_TITLE;
					mSelectedId		= visibleItems.get(position).ROW_ID;

					if(mSelectedPositionCatID.size() > 0){

						for (int i = 0; i < mSelectedPositionCatID.size(); i++) {

							int catId	= mSelectedPositionCatID.keyAt(i);

							for (int j = 0; j < mSelectedPosition.size(); j++) {
								int pos	= mSelectedPosition.keyAt(j);
								if(catId == Integer.parseInt(visibleItems.get(pos).ROW_ID)){

									mSelectedPosition.delete(pos);
									mSelectedPositionCatID.delete(pos);
									notifyItemChanged(pos);
								}
							}

						}

					}

					mSelectedPosition.clear();
					mSelectedPositionCatID.clear();
					mSelectedPositionCatID.put(Integer.parseInt(visibleItems.get(position).ROW_ID), true);
					mSelectedPosition.put(position, true);
					notifyItemChanged(position);
				}
			});

It works for me as well as i want :dart:

Awesome! Glad you got it working


Inactive users are not marked as such

Environment Information

Mattermost App Version: 1.11.0
Mattermost Server Version: 5.2.0

Steps to reproduce
Press + to start a private message
Expected behavior
See all users, inactive (disabled) ones should be marked with a name-inactive
Observed behavior
All user names look the same, unless you know who is inactive (disabled).

Hi @licaon-kter! Thank you for reporting this.
What device and OS version are you using?

Happens on any device.

Thanks! I'll test this out today and report back if I can reproduce.

@licaon-kter Apologies for the delay - I created a ticket for this here: https://mattermost.atlassian.net/browse/MM-11942.

Hi @licaon-kter, the Jira ticket has been resolved and tested internally and the fix will be available in v1.12 release.

What device and OS version are you using?

I keep forgetting that this repo builds both iOS and Android, indeed my report was on Android. :)


FlagLLMReranker Multiple GPUs doesn't work

Hi, I always get cuda out of memory errors even I have set CUDA_VISIBLE_DEVICES="3,4,5". It seems the model is always using cuda0 to load the model. Could you please help?
Thanks

Where do you set CUDA_VISIBLE_DEVICES="3,4,5", you should set it outside the document or at the very beginning of the code.

Yes, that's what I did.
I executed CUDA_VISIBLE_DEVICES=4,5,6 python3 get_embedding.py
and got the error:

After inspecting the code, it seems the FlagLLMReranker (shown below) has different implementation with such as BGEM3FlagModel
if device and isinstance(device, str):
            self.device = torch.device(device)
        else:
            device = 0 if device is None else device
            if torch.cuda.is_available():
                torch.cuda.set_device(device)
                self.device = torch.device("cuda")
            elif torch.backends.mps.is_available():
                self.device = torch.device("mps")
            elif is_torch_npu_available():
                self.device = torch.device("npu")
            else:
                self.device = torch.device("cpu")
                use_fp16 = False

        if use_fp16 and use_bf16 is False:
            self.model.half()

        self.model = self.model.to(self.device)

        self.model.eval()

I'm not sure where did you parallelize the model and whether data parallelism is supported for FlagLLMReranker or not.
Please let me know if I made something wrong.
Thanks

Due to the large memory consumption of LLM-based rerankers when using DP multi-card inference, we do not provide multi-card parallelism for LLM-based rerankers; manual parallelism using multiple processes is required.
The OOM error mentioned above is likely not due to CUDA 0 running out of memory, but rather from CUDA 3. You can try reducing the batch size for inference.

Due to the large memory consumption of LLM-based rerankers when using DP multi-card inference, we do not provide multi-card parallelism for LLM-based rerankers; manual parallelism using multiple processes is required.
The OOM error mentioned above is likely not due to CUDA 0 running out of memory, but rather from CUDA 3. You can try reducing the batch size for inference.

Great man. You inspired me, I successfully load the model into 1 gpu using bf16. Thanks a lot


github_packages: fix source for Linuxbrew bottles.

Addresses https://github.com/Homebrew/brew/pull/11056#issuecomment-815261503

Review period skipped due to critical label.

Thanks, Mike!


Refactor code

I want to have the code refactored before release.

Code has been refactored + some bug fixes


Basic counter changed in getter not updated after upgrading to vue 3.4.29

Reproduction
Create a basic vue app with a simple store, then call useIdStore().nextId multiple times. it's expected to return incremented ids/counter.
Steps to reproduce the bug
Here is the basic store:
import { defineStore } from 'pinia';

export const useIdStore = defineStore('idStore', {
  state: () => ({
    nextElementIdCounter: 0,
  }),
  getters: {
    // Example getter
    nextId: (state) => {
      state.nextElementIdCounter += 1;
      return state.nextElementIdCounter;
    },
  },
  actions: {
    // Example action
    incrementCounter() {
      this.nextElementIdCounter++;
    },
  },
});

When calling useIdStore().nextId, it's expected to increment for each call. This works as expected in Vue 3.4.27, but is broken in vue 3.4.29
See this example with Vue 3.4.27, that works fine:
https://stackblitz.com/edit/vitejs-vite-h2rymf?file=src%2FApp.vue
Example with Vue 3.4.29 that is broken:
https://stackblitz.com/edit/vitejs-vite-nctroe?file=src%2FApp.vue
Expected behavior
I expected the counter to still increment
Actual behavior
The counter does not increment
Additional information
I know it's not best practice to change the state in a getter, but I found the use case when requesting a new id or next id, better to change the state in a getter, rather than calling the action, then the getter in sequence.

Works fin in Vue 3.4.28 as well:
https://stackblitz.com/edit/vitejs-vite-swtzu1?file=src%2Fstores%2FidStore.ts

Having a getter like that is equivalent to writing this:
computed(() => {
      nextElementIdCounter.value++
      return nextElementIdCounter.value
})

As you can imagine this simply doesn't make sense as it creates a recursive dep. Fortunately, Vue doesn't seem to crash but such definition is not valid in Vue.