Can't preview

Hi,
In the PC installed SpineOMatic, I've been trying to preview/print, but it's giving me this error screen (message copied below).  What did I do wrong?  Could you please advise how I can preview/print?  Many thanks.
Katie
This is my print setup.

This is the error message when preview/print

See the end of this message for details on invoking
just-in-time (JIT) debugging instead of this dialog box.
************** Exception Text **************
System.ArgumentException: Value of '0' is not valid for 'emSize'. 'emSize' should be greater than 0 and less than or equal to System.Single.MaxValue.
Parameter name: emSize
at System.Drawing.Font.Initialize(FontFamily family, Single emSize, FontStyle style, GraphicsUnit unit, Byte gdiCharSet, Boolean gdiVerticalFont)
at System.Drawing.Font..ctor(String familyName, Single emSize, FontStyle style)
at SpineLabeler.Form1.PrintDocument2_PrintPage(Object sender, PrintPageEventArgs e)
at System.Drawing.Printing.PrintDocument.OnPrintPage(PrintPageEventArgs e)
at System.Drawing.Printing.PrintController.PrintLoop(PrintDocument document)
at System.Drawing.Printing.PrintController.Print(PrintDocument document)
at System.Drawing.Printing.PrintDocument.Print()
at System.Windows.Forms.PrintPreviewDialog.OnprintToolStripButtonClick(Object sender, EventArgs e)
at System.Windows.Forms.ToolStripItem.RaiseEvent(Object key, EventArgs e)
at System.Windows.Forms.ToolStripButton.OnClick(EventArgs e)
at System.Windows.Forms.ToolStripItem.HandleClick(EventArgs e)
at System.Windows.Forms.ToolStripItem.HandleMouseUp(MouseEventArgs e)
at System.Windows.Forms.ToolStrip.OnMouseUp(MouseEventArgs mea)
at System.Windows.Forms.Control.WmMouseUp(Message& m, MouseButtons button, Int32 clicks)
at System.Windows.Forms.Control.WndProc(Message& m)
at System.Windows.Forms.ToolStrip.WndProc(Message& m)
at System.Windows.Forms.NativeWindow.Callback(IntPtr hWnd, Int32 msg, IntPtr wparam, IntPtr lparam)
************** Loaded Assemblies **************
mscorlib
Assembly Version: <IP_ADDRESS>
Win32 Version: 4.8.4510.0 built by: NET48REL1LAST_B
CodeBase: file:///C:/Windows/Microsoft.NET/Framework64/v4.0.30319/mscorlib.dll
SpineLabeler
Assembly Version: <IP_ADDRESS>
Win32 Version: <IP_ADDRESS>
CodeBase: file:///C:/Users/laik/Downloads/SpineLabeler.exe
Microsoft.VisualBasic
Assembly Version: <IP_ADDRESS>
Win32 Version: 14.8.4084.0 built by: NET48REL1
CodeBase: file:///C:/WINDOWS/Microsoft.Net/assembly/GAC_MSIL/Microsoft.VisualBasic/v4.0_<IP_ADDRESS>__b03f5f7f11d50a3a/Microsoft.VisualBasic.dll
System
Assembly Version: <IP_ADDRESS>
Win32 Version: 4.8.4488.0 built by: NET48REL1LAST_C
CodeBase: file:///C:/WINDOWS/Microsoft.Net/assembly/GAC_MSIL/System/v4.0_<IP_ADDRESS>__b77a5c561934e089/System.dll
System.Core
Assembly Version: <IP_ADDRESS>
Win32 Version: 4.8.4470.0 built by: NET48REL1LAST_C
CodeBase: file:///C:/WINDOWS/Microsoft.Net/assembly/GAC_MSIL/System.Core/v4.0_<IP_ADDRESS>__b77a5c561934e089/System.Core.dll
System.Windows.Forms
Assembly Version: <IP_ADDRESS>
Win32 Version: 4.8.4488.0 built by: NET48REL1LAST_C
CodeBase: file:///C:/WINDOWS/Microsoft.Net/assembly/GAC_MSIL/System.Windows.Forms/v4.0_<IP_ADDRESS>__b77a5c561934e089/System.Windows.Forms.dll
System.Drawing
Assembly Version: <IP_ADDRESS>
Win32 Version: 4.8.4390.0 built by: NET48REL1LAST_C
CodeBase: file:///C:/WINDOWS/Microsoft.Net/assembly/GAC_MSIL/System.Drawing/v4.0_<IP_ADDRESS>__b03f5f7f11d50a3a/System.Drawing.dll
System.Configuration
Assembly Version: <IP_ADDRESS>
Win32 Version: 4.8.4190.0 built by: NET48REL1LAST_B
CodeBase: file:///C:/WINDOWS/Microsoft.Net/assembly/GAC_MSIL/System.Configuration/v4.0_<IP_ADDRESS>__b03f5f7f11d50a3a/System.Configuration.dll
System.Xml
Assembly Version: <IP_ADDRESS>
Win32 Version: 4.8.4084.0 built by: NET48REL1
CodeBase: file:///C:/WINDOWS/Microsoft.Net/assembly/GAC_MSIL/System.Xml/v4.0_<IP_ADDRESS>__b77a5c561934e089/System.Xml.dll
System.Runtime.Remoting
Assembly Version: <IP_ADDRESS>
Win32 Version: 4.8.4084.0 built by: NET48REL1
CodeBase: file:///C:/WINDOWS/Microsoft.Net/assembly/GAC_MSIL/System.Runtime.Remoting/v4.0_<IP_ADDRESS>__b77a5c561934e089/System.Runtime.Remoting.dll
Accessibility
Assembly Version: <IP_ADDRESS>
Win32 Version: 4.8.4084.0 built by: NET48REL1
CodeBase: file:///C:/WINDOWS/Microsoft.Net/assembly/GAC_MSIL/Accessibility/v4.0_<IP_ADDRESS>__b03f5f7f11d50a3a/Accessibility.dll
************** JIT Debugging **************
To enable just-in-time (JIT) debugging, the .config file for this
application or computer (machine.config) must have the
jitDebugging value set in the system.windows.forms section.
The application must also be compiled with debugging
enabled.
For example:

When JIT debugging is enabled, any unhandled exception
will be sent to the JIT debugger registered on the computer
rather than be handled by this dialog box.

Good morning!  Just wanted to say that when I tried SpineOMatic again this morning, everything works and I can print/preview.
But now I have another question -- Is there a way for me to specify the size of the cell padding so that the call number text is not printing right against the edge of each label?
Many thanks as always for your advice.
Katie

@KatieLai, did you experiment with the "Left margin" setting on the "Print Setup" tab?

Yes I did.  But somehow one morning, everything worked and I was able to print/preview!
By the way, is there an area to indicate the left padding size?  Since I don't see any (maybe I've just overlooked), I manually added 0.5cm left padding in my calculation of the left margin (resulting a left margin of 1.5 cm), but the call number text then shifted too much to the right...  Still need to fiddle around with it for a while.  Thanks for your help!

@KatieLai, yes, I think the left margin is the way to go...but apparently it doesn't give you the results you need. I think we added padding in the Cloud App version; I'll have to check.

Yes, left padding is in the Cloud App, but not in the downloaded SpineOMatic software.


Add Basque as translatable language

Currently it's not in the web for translating the app

Basque have been added as the available languages. Stay tune for the "localization". We are currently setting up POEditor.

Hi @Porrumentzio, you can now translate Osm Go! to basque. Follow the instructions here: https://github.com/DoFabien/OsmGo/blob/develop/CONTRIBUTING.md#translate


Reolink RLC-810A

Hi,
I set up one RLC-810A and would like to receive not just motion but the AI detection events.
cameras:
  reolink_carport:
    host: <ip>
    username: <username>
    password: <password>
    modules:
      onvif:
        port: 8000
        monitor_events: true
        prefer_webhook_subscription: false
      reolink:
        # port: 443 # optional. 443/HTTPS by default
        # username: bob # optional. Alternative username for Reolink API
        # password: bobpass # optional. Alternative password for Reolink API
        # ssl: false # optional. Use ssl/HTTPS
        ai_detection_mode: continous # one of [off, on_motion, continuous]. on_motion requires onvif module to detect motion
        sync_datetime: false
        # audio: false # allow to control audio alarm volume (can't be autodetected)
        # alarm: false # allow to control alarm siren (can't be autodetected)
        # spotlight: false # allow to control spotlight (can't be autodetected)

Is this config correct?
In the log it says
[INFO ] 2023-01-14 13:04:32,359 akka://cam2mqtt/user/cameraman/cam_reolink_carport/mod_onvif - ONVIF Capabilities for camera reolink_carport:
Events: true
Pull-Point subscription: true
[INFO ] 2023-01-14 13:04:36,196 akka://cam2mqtt/user/cameraman/cam_reolink_carport/mod_reolink - Reolink Capabilities for camera reolink_carport:

From the README I am not sure if this configuration is the best for RLC-XXXA cameras. My firmware is v<IP_ADDRESS>6_22041503, hardware IPC_523128M8MP.
Thanks for some feedback on this.

Hi, the config looks correct, but there seems to be a problem with the Reolink capabilities detection.
Also, there is a typo on your config continous should be continuous.
      onvif:
        port: 8000
        monitor_events: true
        prefer_webhook_subscription: false
      reolink:
        port: 443 # optional. 443/HTTPS by default
        ssl: true # optional. Use ssl/HTTPS
        ai_detection_mode: continuous # one of [off, on_motion, continuous]. on_motion requires onvif module to detect motion
        sync_datetime: false

Also, ensure that the camera can be accessed through port 443 (HTTPS) and that the provided user is an admin instead of a simple user. Only admins can change config using the HTTP API.


A binary RBM example

Description
An example of binary restricted Boltzmann machine learning MNIST.
Checklist
Essentials
Please feel free to remove inapplicable items for your PR.

[ ] The PR title starts with [MXNET-$JIRA_ID], where $JIRA_ID refers to the relevant JIRA issue created (except PRs with tiny changes)
[x] Changes are complete (i.e. I finished coding on this PR)
[ ] All changes have test coverage:
Unit tests are added for small changes to verify correctness (e.g. adding a new operator)
Nightly tests are added for complicated/long-running ones (e.g. changing distributed kvstore)
Build tests will be added for build configuration changes (e.g. adding a new build option with NCCL)
[x] Code is well-documented:
For user-facing API changes, API doc string has been updated.
For new C++ functions in header files, their functionalities and arguments are documented.
For new examples, README.md is added to explain the what the example does, the source of the dataset, expected performance on test set and reference to the original paper if applicable
Check the API doc at http://mxnet-ci-doc.s3-accelerate.dualstack.amazonaws.com/PR-$PR_ID/$BUILD_ID/index.html
[x] To the my best knowledge, examples are either not affected by this change, or have been fixed to be compatible with this change

Very cool implementation! Helped me refresh on the RBM literature. Both test scripts make sense to me.
A few comments:

It would be awesome to include some basic mathematical descriptions in the README. I got my intuitions from http://deeplearning.net/tutorial/rbm.html . However, you have a clearer backward function that is not explicit in the tutorial (even though I believe in your intuitions.)

An alternative idea on the sampler function. I would not compute prob_0 after getting prob_1; instead, to sample from Bernoulli distributions:
mx.nd.random.uniform(shape=shape_of_prob_1) < prob_1

Would it be possible to track the training process by reporting CD-loss after each epoch? In a similar vein, an additional feature to consider is to include aux in the forward loop for persistent-CD.

Minor styling ideas: Naming interaction_weight instead of interaction can receive the extra benefit of default initialization. Also, since the spirit of the commit is a CustomOperator, it may be simpler to use gluon SymbolBlock instead of HybridBlock?

To simplify the comments, I would love to see
*documentation, e.g., the link I provided in the previous comment.
*sampler rewrite for 2x speed up.
*training loss tracked at the end of each epoch.
The other ideas are only suggestions and may be out of scope in this request.

@yifeim Thanks for the suggestions!

The gradient in this example is the standard one from the straightforward calculation of the gradient of the log likelihood, to be used in the stochastic gradient descent (SGD). The expressions in the tutorial you linked replace the average over the Gibbs samples of hidden units with the probability of a hidden unit to be one. They are interchangeable in practice, while strictly speaking the latter is not exact for SGD.
There are lots of literature on RBM and each of them has its own presentation of the math. No one may directly match with the code in this PR. Github does not support math rendering with the markdown so explaining the math of RBM in the README is difficult and I think that is also out of scope of this PR. If someone wants to understand the example code (not merely using), then they should understand the math and I think that the differences in the literature may not be hard to be adjusted.
Yes, the Bernoulli sampling method you provide is the standard idiom! I forgot to restore it after some tests with multinomial ( #10970). Thanks.
interaction_weight sounds good. I'll use the name.
Monitoring the progress of the RBM learning is not trivial because the calculation of the loss (objective function) is practically impossible. There is no golden standard for the monitoring as far as I know. So I left it empty. But anyway adding one to this example would not be bad. My personal preference is using the annealed importance sampling and some people recommend it (e.g. a guide by Hinton). I'll add it.

I'll update the code soon.

Thanks for the explanations.
I did not mean to expect a full paper in README.md -- that would indeed be redundant; instead I  just wanted some reference links to your favorite papers. Also a good idea is to highlight the results. For example, your current demo samples new images from raw images -- I was wondering if both images could be included in README.
I see that RBM is the case where computing the gradient is easier than computing the actual likelihood. For AIS, the algo box and (15)-(17) in http://homepages.inf.ed.ac.uk/imurray2/pub/08dbn_ais/dbn_ais.pdf may be a good starting point. If you decide to implement AIS, please highlight the expected AIS values as well.

@asitstands thanks for updating the PR. @yifeim would you mind taking another pass at this PR?

Now the log-likelihoods of the test and training data are reported at the completion of each epoch. They are estimated using AIS. README shows some samples generated from the RBM.

Hi @asitstands ,
Thanks for the update! Sorry I did not notice the code changes until was reminded. If you don't mind, I would like to do a full run through on Monday. I feel this is an awesome contribution in general and it will set high standards for other people to understand custom operators and RBMs.
Thanks,
Yifei

@yifeim It was my fault that the update was late. I forgot to push the update and went on a vacation :grin:. I pushed the ais implementation and some tweaks yesterday.
I found that the gluon implementation is much slower than the module implementation. nvidia-smi reports about 60% of GPU utilization for the module implementation but only 35% for the gluon implementation. If I replace gluon's DataLoader with NDArrayIter, the gluon implementation's performance becomes comparable to the module implementation. I'm not sure that this performace issue is unavoidable with DataLoader or I have made some mistakes. Would you please check this performance issue?

I set num_workers=4 for the DataLoader used in the gluon implementation. This improves the performance but it is still slower than the module implementation (about 35% longer running time).

Just an update that I ran the symbol codes a couple days back and the presentation seemed much clearer than the original submission. The simulated images also improved in the sense that more sampling steps were taken.
I had a little issue that the gluon codes did not run on my windows machine. Could be a platform related issue and would love to check on a linux platform.

The comparison at the end of 130 epochs. I think it looks very nice!

I updated the code. Now it shows the initial real images also. The sample image included in the README is the one provided by yifeim. Thanks @yifeim.


github-toc.user.js toc includes side panel headings

Such as on https://github.com/mixxxdj/mixxx/wiki/midi scripting#turning-a-2-deck-controller-into-a-4-deck-controller

Hi @mxmilkiib!
Thanks for reporting this problem! I'll get it fixed soon.


wallhack function - need to be updated

I have installed the trainer with version <IP_ADDRESS>46 SPT AKI 3.0 .
since there are USEC rogue invasion  scenario, I suggest add more faction slot to wallhack, since I found that USEC PMC and Rouge currently use the same slot.
trainer.txt

I have a different problem with the wallhack. The different USEC PMCs have the same bone/box colors as the bosses.

Fixed here:
https://github.com/sailro/EscapeFromTarkov-Trainer/pull/474


Clean up ES startup object table

In reviewing #159 it was determined that a better approach to changing the type of the "StackPtr" field would be to do some more general cleanup here and remove the unused field.

Imported from trac issue 139.  Created by jphickey on 2016-03-01T11:12:34, last modified: 2019-03-05T14:57:55

Trac comment by jphickey on 2016-03-01 11:20:10:
Commit [changeset:05afcd28] addresses this, branch trac-139-cleanup-objtable
In doing this change I reviewed the other existing fields and determined that the ObjectPtr, ObjectId, StackPtr, TcbPtr fields are also unreferenced.  These were also removed.
The only thing not entirely clear is with respect to the ObjectId vs. ObjectKey fields.  The existing code had been writing the OSAL-assigned ID back into the ObjectKey field, not ObjectId as the description/comment would suggest.
It is possible we want to rename ObjectKey to ObjectId to better match the comment.

Trac comment by sduran on 2016-03-14 17:00:24:
Seems reasonable to remove these unused fields, but they were put there at some point for a reason - definitely double check this change with Alan Cudmore.

Trac comment by stashakk on 2016-03-15 08:19:09:
Nice clean up makes the file more explicit and clear

Trac comment by jphickey on 2016-03-22 17:41:00:
Follow-on change in [changeset:aef7917] which removes "ObjectKey"
I investigated the possibility of qualifying this structure as const since no software is writing to the structure any more.  However, I discovered that the unit test, specifically es_UT.c starting on line 496, test case titled "Bad function pointer", is overwriting a field in this table.
To avoid growing this change therefore this does not modify the const-ness of the structure, this will have to be done as a separate ticket.
The startup procedure is being re-evaluated in #173 and this would be the logical place to also address the read-only status of this table.

Trac comment by acudmore on 2016-03-15 13:31:58:
I think it is OK to remove these fields.
Many of these fields were carried over from heritage FSW, and they were probably included at the start of cFE development.
They have not been needed for any of our current operating systems or platforms and they will probably not be needed in the future.
Also, since this code is in generic cFE code, it is not supposed to be changed or customized for each OS or mission.
My original thought for including the table at all was to allow for patching in flight to add a task or startup function call if needed. ( this is still possible, the unused fields don't really matter in this case )

Trac comment by jphickey on 2016-03-22 18:14:14:
This has added into the ic-2016-03-22 merge

Trac comment by glimes on 2016-03-30 15:10:01:
development now includes ic-2016-03-22 merge.

Trac comment by jhageman on 2019-03-05 14:57:55:
Milestone renamed


I will reconstruct lua.js very soon.

Target:

Build with CommonJS, compatible with node.js/webpack/react native
Solve upvalue-in-repeat issue. This breaks many people to use lua.js
Performance improve because my JS level was up.
Support missing grammar,  hex integer etc..
Unit Test, Travis-CI, blah blah..

glad to here that, would it be a new project?

No, all will be in this repo.


Rework externals for perf

It turns out one of the expensive parts of the build was this function (easy to see by just commenting out the externals and comparing build speeds).
This reimplements the same logic using some custom optimizations.
The other thing implemented here is to move the .ts and .tsx checks in the resolver to the end. This does mean that test.js will take precedence over test.ts, but the benefit is that the Webpack resolver doesn't have to stat every single that is ever required in the tree as its .ts variation first (which it was doing for EVERYTHING in node_modules...)
Combined these shave about 5 seconds off a 40 second build for me.

Codecov Report

Merging #176 into master will increase coverage by 0.73%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master     #176      +/-   ##
==========================================
+ Coverage   77.29%   78.03%   +0.73%
==========================================
  Files          11       11
  Lines         511      519       +8
==========================================
+ Hits          395      405      +10
+ Misses        116      114       -2

Impacted Files
Coverage Δ

src/index.js
95.95% <100%> (+2.48%)
:arrow_up:

src/utils/get-package-base.js
100% <100%> (ø)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6aa2c4c...3373fa7. Read the comment docs.


Does networkmgr depend on UDisks2?

Getting
FreeBSD% ./networkmgr
invoking IsSupported() failed for remote volume monitor with dbus name org.gtk.vfs.UDisks2VolumeMonitor:: GDBus.Error:org.freedesktop.DBus.Error.ServiceUnknown: The name org.gtk.vfs.UDisks2VolumeMonitor was not provided by any .service files (g-dbus-error-quark, 2)

on helloSystem where we don't have UDisks2.

That is a weird error networkmgr shouldn't return that an error related udisks, Udisks is not even part of of GHostBSD default installation.


ES docs should have nested structure; not flat

It’s important that the ES documents for Assays include the full Sample and Donor information, and not just an ID. (and Samples should have Donor information, etc.) We want to be able to facet Assays by characteristics of the Donor.
What should the ES documents look like? I’d suggest a structure like this:
{
  "uuid": "....",
  ... # Small number of fields pulled to top.
  "donor": {
    ...
  },
  "sample": {
    ...
  },
  "assay": {
    ...
  }
}

Example of something similar from ES docs: https://www.elastic.co/guide/en/elasticsearch/reference/current/object.html
In the ES instance I have right now, it’s pretty flat, and I hope that can change.

The nested structure preserves information up the provenance chain, without having to rename fields to avoid name collisions.
The nested structure will be much more tractable to validate with a JSON schema. (Trying to add properties at the same level to emulate a type-sub-type hierarchy won’t work.)

@mccalluc Let's discuss this after a standup.  I'm not seeing it- the example you're showing looks pretty flat to me.  The existing structure with ancestors and children being stored in arrays under the entity, I think, provide more flexibility in querying.

Ok, here's an example: Imagine I'm browsing assays, and want to filter by assay type. Taking one document the relevant parts look like:
{
  "ancestors": [
    {
      "entitytype": "Dataset",
      "provenance_create_timestamp":<PHONE_NUMBER>845,
    },
    {
      "entitytype": "Sample",
      "provenance_create_timestamp":<PHONE_NUMBER>996,
      "specimen_type_display_name": "PFA Fixed frozen OCT block",
    },
    {
      "entitytype": "Sample",
      "provenance_create_timestamp":<PHONE_NUMBER>868,
      "specimen_type_display_name": "Organ Piece",
    },
    {
      "entitytype": "Sample",
      "provenance_create_timestamp":<PHONE_NUMBER>213,
      "specimen_type_display_name": "organ",
    },
    {
      "entitytype": "Donor",
      "provenance_create_timestamp":<PHONE_NUMBER>762,
    }
  ],
  "name": "W105 spleen, anterior seqFISH processed data",
  "uuid": "b9824e6d57a2e861fb990b7a27ba7008"
}

With a data structure like this, how would I:
- Facet datasets by the specimen type they are immediately derived from? I want a list of terms like "PFA Fixed frozen OCT block", but those are going to be dominated by "Organ Piece" and "organ"
- Filter datasets by some inequality on the timestamp of the specimen they were derived from?

I'm not sure these stories are absolutely impossible, but at the least it's going to take some work to make the queries, and I may need to get specific indexes applied.

(Bill and I talked: He understands the usecase... I'm going to try to use the existing structure, and if that doesn't work, I'll loop back.)

@shirey : I don't believe anything but dot-path-based access is possible...
Arrays

Arrays of objects do not work as you would expect: you cannot query each object independently of the other objects in the array.

dot notation

Inner fields can be referred to in queries, aggregations, etc., using dot notation

How arrays of objects are flattened

Arrays of inner object fields do not work the way you may expect. Lucene has no concept of inner objects, so Elasticsearch flattens object hierarchies into a simple list of field names and values.

I've looked at nested fields, but I don't think that would help here, either.
Here's what I'd propose as the document structure:

All of this is under the new metadata element, which will separate your machine generated fields from those which originate in a TSV (for assays).
I would propose that there be no scalar fields at the top level of metadata: The children should all be objects.
For Donors:

{"metadata": {
  "donor": { ... } }

for Samples:

{"metadata": {
  "donor": { ... },
  "origin_sample": { ... },
  "sample": { ... } }

where sample is the metadata for the object itself, and origin_sample is the metadata for the first sample in the provenance chain, typically an organ. If this is the first sample in the provenance chain, origin_sample and sample will be equal.

for Datasets:

{"metadata": {
  "donor": { ... },
  "origin_sample": { ... },
  "sample": { ... },
  "dataset": { ... } }

The complete provenance chain will not be in the ES document: When we need the provenance, we will use the provenance API. I'll loop in people on our side to confirm this plan.

@mccalluc This makes sense.  Why not put these new fields at the top level of the object rather than under the "metadata" field, though?  They won't clash with anything we have now.

Final decision based on a call with the entire team is this structure:
DONOR-
{
....
"metadata": {....}
}
SAMPLE-
{
....
"portal_metadata_files":
"metadata": {....},
"donor": {
....
"metadata": {....}
},
"origin_sample": {
   ....
   "metadata": {....}

}
}
DATASET-
{
.....
"metadata": {....},
"donor": {
"metadata": {....}
},
"origin_sample": {
"metadata": {....}
}
"source_sample":[ {
"metadata": {....}}, {...}, .. ]
}
}

This has been implemented, and we're using it.


[ISSUE] Zeebe Gateway REST API healthcheck endpoint on 9600 doesn't respond to contextPath changing

Describe the issue:
Issue found in this PR,
https://github.com/camunda/camunda-platform-helm/pull/1278
which we decided was not worth investigating as part of that PR.
If zeebe-gateway.contextPath is set to anything other than /, the readinessProbes will fail.
We could either:

Figure out what env var to change to make the contextPath work. (Note:  the SERVER_SERVLET_CONTEXT_PATH and SPRING_WEBFLUX_BASE_PATH variables have no effect on the webserver that listens on 9600, however,  the webflux variable does affect the zeebe gateway rest api.
Remove the contextPath from the readiness probes (and startup and liveness)

Actual behavior:
readiness probes fail if contextPath is changed.

Expected behavior:
readinessProbes should succeed if contextPath is changed.

How to reproduce:
deploy with contextPath set to zeebe in the gateway, then start a port-forward to 9600 on the zeebe gateway and curl
curl -vvvv "http://localhost:9600/zeebe/actuator/health/readiness"

Logs:

Environment:
Please note: Without the following info, it's hard to resolve the issue and probably it will be closed.

Platform:
Helm CLI version:
Chart version:
Values file:

@npepinpe Does the Zeebe team plan to support the actuator context path?

It's built into Spring, so it's just a configuration property. Is this something other teams support? If so, we can just align with whatever value they currently support.

To change the management context path you use MANAGEMENT_SERVER_BASEPATH=/zeebe :)
Why is it not aligned with the other var? Trying to figure out why Spring does things the Spring way is sure way to pull your own hair :smile:

I will work on this today.


Black page screen on production.

The problem is when I change url by using
window.location.href = "/#/some-url"
My app will show a blank page on production (build to .exe or AppImage), but working fine on npm run dev
environment.

Node version: 8.9
NPM version: 5.6
Operating System: ubuntu18.04, window10

Sorry, for my English.

There is something called vue-router it was made for that purpose

the same

the same

This issue getting when you try to locate new link directly by using window.location.href.
To avoid this issue just using vue-router libary instead


Issue691 calibration

Fixes #691 and also included a revision of the detection of bouts by g.getbout. As you noticed: "The bout length is not correct when ws3 < 31 and boutcriter < 1. Here, the bout length is always 1 epoch longer than what we expect". Now the start and end of the bouts is redefined to match the prefined time.

Checklist before merging:

[x] Existing tests still work (check by running the test suite, e.g. from RStudio).
[x] Added tests (if you added functionality) or fixed existing test (if you fixed a bug).
[x] Updated or expanded the documentation.
[x] Updated release notes in inst/NEWS.Rd with a user-readable summary. Please, include references to relevant issues or PR discussions.
[ ] Added your name to the contributors lists in the DESCRIPTION and CITATION.cff files.

Codecov Report

Merging #709 (bfd0c78) into master (c8aa544) will decrease coverage by 0.31%.
The diff coverage is 71.42%.

@@            Coverage Diff             @@
##           master     #709      +/-   ##
==========================================
- Coverage   73.23%   72.91%   -0.32%
==========================================
  Files          87       87
  Lines       10756    10862     +106
==========================================
+ Hits         7877     7920      +43
- Misses       2879     2942      +63

Impacted Files
Coverage Δ

R/check_params.R
70.81% <14.28%> (-2.23%)
:arrow_down:

R/g.analyse.perday.R
61.77% <50.00%> (-4.89%)
:arrow_down:

R/g.impute.R
75.30% <50.00%> (-0.78%)
:arrow_down:

R/g.analyse.R
76.92% <66.66%> (-2.75%)
:arrow_down:

R/g.getbout.R
98.10% <97.10%> (-0.42%)
:arrow_down:

R/g.analyse.avday.R
88.97% <100.00%> (-2.37%)
:arrow_down:

R/g.calibrate.R
66.75% <100.00%> (ø)

R/g.getM5L5.R
89.23% <100.00%> (ø)

R/g.part2.R
57.80% <100.00%> (+0.74%)
:arrow_up:

R/g.part5.R
74.26% <100.00%> (ø)

... and 5 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

To do in this branch:

[ ] Make identify_levels compatible with qwindows in part 2
[ ] Make identify_levels compatible with >1 threshold for lig, mod, and vig in part 2
[ ] Indicate metric, threshold, and qwindow in ds_names from identify_levels

Hi @jhmigueles, it would be good to wrap this work up in the upcoming month or so as it is a lot of work and will be harder to revise if we leave it for several months. To me it seems the following work is needed:

With this PR we will have a lot of input arguments in relation to handling daytime-only study protocols: ignorenonwear, relyonguider, WornDuringSleep, part2ImpWithZero, and part2ExcludeNonwear. Could you please add a vignette paragraph dedicated to explaining how all of these are used when working with such study protocols? For example, as a new sub-paragraph of section 2.3 in the main vignette titled "Tailoring GGIR to study protocol", where eventually we may discuss several study protocol but for now we could highlight the two extremes: 24/7 protocols with a brief references to arguments such as strategy and day-time only study protocols.
Next, refer to that vignette paragraph in the parameter documentation.
See my comment here. I think it is best to omit the change in percentile calculation as this does not seem to relate to the rest of this PR and I think it is incorrect.
Could you please update PR name as this is not an update to the calibration procedure but to study protocol handling.
Could you please update the PR text now bout detection is no longer part of the PR.

Renamed branch and PR as you suggested. Find all your suggested changes here


Updated CHANGELOG and README

Se actualizan los .md a la versión 3.4.3.

Codecov Report

Merging #654 into master will not change coverage.
The diff coverage is n/a.

@@          Coverage Diff           @@
##           master    #654   +/-   ##
======================================
  Coverage    27.5%   27.5%
======================================
  Files         231     231
  Lines       16954   16954
  Branches     1479    1479
======================================
  Hits         4663    4663
  Misses      11793   11793
  Partials      498     498

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4191207...86c1866. Read the comment docs.


Disable sil_verify_all_triggers_verifier_without_asserts.sil (89986815)

Replace this paragraph with a description of your changes and rationale. Provide links to external references/discussions if appropriate.

Resolves SR-NNNN.

@swift-ci test

@swift-ci test


sendInput should be previewable

See #9818, 60f63b09cc59f1a46d142952f49dbf7599bc4cf8, #3121. I literally have this prototyped, just need to check it in. It's important for future issues...

More cleanly pulled to its own branch: https://github.com/microsoft/terminal/pull/new/dev/migrie/f/12861-preview-input

Curious how this will handle sendInputd escape sequences!

Punting out of 1.19. This was wacky as-is. We may want to come back to re-try this with more runway.


cli unable to connect to HANA on node v12.18.1 on macOS - Error Abort trap: 6

Any commands which require a connect to HANA are failing (Error Abort trap: 6) with node v12.18.1 on macOS 10.15.5, Example: When try to connect to HANA System (here SystemDB on HXE on docker) with connect command:
hana-developer-cli-tool-example $ node bin/cli.js connect
Input: Connection String  <host>[:<port>]:  hxehost:39017
Input: User:  SYSTEM
Input: Password:  ***********

Input: Encrypt connections (required for HANA As A Service or HANA Cloud):  false
Input: Optional: HDB User Store Key - Overrides all other Connection Parameters:
Input: SSL Trust Store:
⠙
Abort trap: 6

Environment is: node v.12.18.1 (using nvm) on macOS 10.15.5. When I switch to v12.14.1 of node everything is working fine. I have not tested other node releases
Debugging leads that the error happens in line 23 in client-factory.js of hdbext (v6.2.2 with hana-client 2.4.196) when client.connect(cb) is executed:
var hdb = require('@sap/hana-client');
........

function createConnection(options, callback) {
  options = normalizeOptions(options);

  var client = hdb.createClient(options);

........

  async.series([
    function (cb) {
// Line 23
      client.connect(cb);
    },

BR HP

I don't have a Mac, but I just tried on exactly node 12.18.1 on both Windows and Linux and it worked just fine.  It does seem that even in your case you are getting a problem actually from the underlying hdbext/hana-client not necessarily with hana-cli itself.  I'm also using the exact same version of hdbext and hana-client as you.

I assume your usage of port 39017 is intentional.  Did you manually create another tenant which you are using here.
I've never really known hdbext/hana-client not to return pretty detailed errors.  This Abort trap 6 must be something rather low level then.  On the other hand abort trap 6 seems to be a very generic error that doesn't tell you much about the actual error condition.
I'm afraid my ability to help you out here is going to be rather limited. I don't see any indication that this issue is actually with content from this project but instead coming from the underlying modules. The fact I can't reproduce the error isn't helping much either.  But let me try to ask around internally and see if there is some known issue with Mac and this particular version of the hana-client.

The issue feels weird to me, too. But as I could reproduce it also after de/reinstallation of node v12.18.1 I thought this is perhaps useful for others. I'm setting up a new macbook, so this a quit untouched system and rare condition.
You definetly right that this is not a direct issue of hana-cli but of the the used packages, but it does affects this great tool.
Port 39017 is the standard port of the SystemDB of the HANA Express on Docker. For what ever reason, SAP used a different port on docker for SystemDB in contrast to binary, vm types.

The issue is still reproducable with latest version of nodeJS (v12.18.2) and latest version of hana-cli (v1.202006.1) with contains @sap/hana-client: v2.5.86 on my local macbook

I'm not sure how to move forward here as we've been unable to reproduce this error using the exact same versions on the Mac and Windows machines here. Although I've updated hana-cli and pulled in the updated version of hana-client via direct dependency; many of the DB operations still pass through hdbext module instead (which has not yet been updated to use the SPS 05 version of the hana-client yet). Perhaps if you are willing I could send you some simple node.js tests that use the hana client module directly without hdbext so its easier to test between its versions.

If it is working on your side with macOS 10.15.x and nodeJS v12.18.1, then it seems not a general issue.
if the error occurs unfortunately only with me, then I close this issue. Thx

Actually not saying we have to close it. I'd like to do a bit more troubleshooting if you are game. But it comes back on you to do some testing for us since we can't recreate on our Macs here at SAP.  I did create a small test here: https://github.com/jung-thomas/simple-hana-client-test
You should be able to just clone and run npm install.  It tests four different ways - with @sap/hana-client, with @sap/hdbext, with hdb, and with sap-hdbext-promisfied.  There are some subtle differences here that might help us narrow down the problem. We can also more easily test specific versions.  For example you might play with different @sap/hana-client versions directly to see what happens. It will also be interesting to see if there is a difference between the hdb and @sap/hana-client variants since they are implemented quite differently.
You can maintain your connection parameters directly in the default-env.json file in the root. I left my parameters in there on purpose to help guide you. Just change you host, port, password, etc.  And yes I left my password for simplicity - its a well known one that I use only for public workshops.

I did some test runs with simple-hana-client-test, quite interesting results:

First test "source as is" (hdbext is called first => Abort trap: 6):

macbook04:simple-hana-client-test $ node -v
v12.18.2
macbook04:simple-hana-client-test $ npm start

><EMAIL_ADDRESS>start /Users/xxxx/git/simple-hana-client-test
> node index

simple-hana-client-test: 1.0.0
@sap/hana-client: 2.5.86
@sap/hdbext: 6.2.2
@sap/e2e-trace: 2.1.0
@sap/xsenv: 3.0.0
hdb: 0.18.0
sap-hdbext-promisfied: 2.202006.1

Abort trap: 6

Second test "without hdbext" (comment out testHdbext(), -> other options work fine):

version()
// testHdbext()
testHanaClient()
testHdbextPromise()
testHdb()

result:
simple-hana-client-test: 1.0.0
@sap/hana-client: 2.5.86
@sap/hdbext: 6.2.2
@sap/e2e-trace: 2.1.0
@sap/xsenv: 3.0.0
hdb: 0.18.0
sap-hdbext-promisfied: 2.202006.1

Test @sap/hana-client
┌─────────┬──────────────┬────────────────┐
│ (index) │ SESSION_USER │ CURRENT_SCHEMA │
├─────────┼──────────────┼────────────────┤
│    0    │   'SYSTEM'   │    'SYSTEM'    │
└─────────┴──────────────┴────────────────┘
Test hdb
┌─────────┬──────────────┬────────────────┐
│ (index) │ SESSION_USER │ CURRENT_SCHEMA │
├─────────┼──────────────┼────────────────┤
│    0    │   'SYSTEM'   │    'SYSTEM'    │
└─────────┴──────────────┴────────────────┘
Test sap-hdbext-promisfied
┌─────────┬──────────────┬────────────────┐
│ (index) │ SESSION_USER │ CURRENT_SCHEMA │
├─────────┼──────────────┼────────────────┤
│    0    │   'SYSTEM'   │    'SYSTEM'    │
└─────────┴──────────────┴────────────────┘

hdbext is executed last (->all work)

source:
version()
testHanaClient()
testHdbextPromise()
testHdb()
testHdbext()

result:
simple-hana-client-test: 1.0.0
@sap/hana-client: 2.5.86
@sap/hdbext: 6.2.2
@sap/e2e-trace: 2.1.0
@sap/xsenv: 3.0.0
hdb: 0.18.0
sap-hdbext-promisfied: 2.202006.1

Test @sap/hana-client
┌─────────┬──────────────┬────────────────┐
│ (index) │ SESSION_USER │ CURRENT_SCHEMA │
├─────────┼──────────────┼────────────────┤
│    0    │   'SYSTEM'   │    'SYSTEM'    │
└─────────┴──────────────┴────────────────┘
Test sap-hdbext-promisfied
┌─────────┬──────────────┬────────────────┐
│ (index) │ SESSION_USER │ CURRENT_SCHEMA │
├─────────┼──────────────┼────────────────┤
│    0    │   'SYSTEM'   │    'SYSTEM'    │
└─────────┴──────────────┴────────────────┘
Test hdb
┌─────────┬──────────────┬────────────────┐
│ (index) │ SESSION_USER │ CURRENT_SCHEMA │
├─────────┼──────────────┼────────────────┤
│    0    │   'SYSTEM'   │    'SYSTEM'    │
└─────────┴──────────────┴────────────────┘
Test @sap/hdbext
┌─────────┬──────────────┬────────────────┐
│ (index) │ SESSION_USER │ CURRENT_SCHEMA │
├─────────┼──────────────┼────────────────┤
│    0    │   'SYSTEM'   │    'SYSTEM'    │
└─────────┴──────────────┴────────────────┘

Noteable:

saw in the package-lock.json that hdbext 6.2.2 is depending on "old" hana-client 2.4.196
if i switch back to node 12.14.1 (i use nvm) then all tests run successfully
switching to hana-client 2.4.196 instead of 2.5.96 (change in package.json and do again npm install) all tests except  hdb do not work

btw HANA Client software is not installed on this macbook yet,
like from https://tools.hana.ondemand.com/#hanatools

Thank you for the testing.  That is actually very helpful.  Its interesting that just adjusting the order of the test cases causes the problem to go away. So it would seem like some sort of async, initialization or race condition. That would also lend itself to why we've been unable to recreate the problem internally. There could well be other factor at play like overall CPU Utilization. By any chance did you put the order back and perform the test multiple times?  Does it always fail with the original order of the tests?  I'm also quite relieved because this proves to me at least that its nothing specific that I'm doing in the hana-cli that's causing the situation.
I'm going to keep this issue open for now (although isn't actually with this project) so we can continue to communicate on it. I will share the results of your testing with the HANA Client development team to see what they can find.  If you do have additional results or findings feel free to share them here. I also hope that soon we will have an hdbext version that directly uses the SPS05 HANA client as well. Simply by the virtue that there was a lot of internal development in the SPS05 of the Node.js HANA client; it may well solve the issue.

FYI - I am seeing the same behaviour on my Mac. Node v12.14.1 works fine. Let me know if I can do anything to help diagnose this.

@jung-thomas I did test it multiple times and the error was reproducible, e.g. when i turn back to order again.
For me it looks like as the origin is in the "binary" part of hana-client 2.4.196 in context of node v12.18.x under macOS.
It seems that I'm not the only one anymore having this issue, as today also Graham Robinson reported on this.

Thanks for updating - both of you.  I've forwarded to the HANA client team.

BTW @6of5 thanks for creating this issue - I would have been stumbling around in the dark for ages if I hadn't found it.
🙇♂

Just heard from development that we should be a couple of days away from a fixed version of hdbext being released. So hopefully we are close now.

I am also facing the same issue but getting different error "Process exited with code null" on line 23 in client-factory.js of hdbext (v6.2.2 with hana-client 2.4.196).
I am on macOS 10.15.6 and am facing same issue with both node versions 12.14.1 and 12.18.1.

The issue is solved with the updated version of the package @sap/hdbext v7.0.0 and latest @sap/hana-client v2.5.105
`
simple-hana-client-test: 1.0.0
@sap/hana-client: 2.5.105
@sap/hdbext: 7.0.0
@sap/e2e-trace: 2.1.0
@sap/xsenv: 3.0.0
hdb: 0.18.0
sap-hdbext-promisfied: 2.202006.1
Test hdb
┌─────────┬──────────────┬────────────────┐
│ (index) │ SESSION_USER │ CURRENT_SCHEMA │
├─────────┼──────────────┼────────────────┤
│    0    │   'SYSTEM'   │    'SYSTEM'    │
└─────────┴──────────────┴────────────────┘
Test @sap/hana-client
┌─────────┬──────────────┬────────────────┐
│ (index) │ SESSION_USER │ CURRENT_SCHEMA │
├─────────┼──────────────┼────────────────┤
│    0    │   'SYSTEM'   │    'SYSTEM'    │
└─────────┴──────────────┴────────────────┘
Test sap-hdbext-promisfied
┌─────────┬──────────────┬────────────────┐
│ (index) │ SESSION_USER │ CURRENT_SCHEMA │
├─────────┼──────────────┼────────────────┤
│    0    │   'SYSTEM'   │    'SYSTEM'    │
└─────────┴──────────────┴────────────────┘
Test @sap/hdbext
┌─────────┬──────────────┬────────────────┐
│ (index) │ SESSION_USER │ CURRENT_SCHEMA │
├─────────┼──────────────┼────────────────┤
│    0    │   'SYSTEM'   │    'SYSTEM'    │
└─────────┴──────────────┴────────────────┘`

Sorry that it took so long to get the @sap/hdbext updates published. I've been waiting on them myself and check npm each day.  You must have been right on top of the update as I see it was just done a few hours ago.  I'll do a battery of tests with the HANA Cli and the new version of the hdbext module yet today and hopefully get a new version pushed out with the updated dependency yet today as well.

New version of hana-cli with the updated version of hdbext is now published.

Thanks, it works now. I just changed the @sap/hdbext to v7.0.0 and it worked with @sap/hana-client v2.5.86 also.


Added House standing full committee assignments

This is based off this Clerk document plus several subsequent House resolutions naming members. It does not include Marjorie Taylor Greene, who was removed from two committees, or Ron Wright, who died in early February. It also is currently missing the House select committees (Intel, Climate and Modernization) and House assignments to joint committees.
If folks want to wait until we get those to merge, that's ok with me.

I ran lint.py to hopefully get it to pass tests. It should only have re-ordered the committees into sorted key order, I think. Look ok? If tests pass now I'm fine to merge.

@JoshData looks good to me.

Great. And thanks!!


Environment Step: float or int?

Hi,
I'm trying to create my own agent, following the example here: https://github.com/aunum/gold/tree/master/pkg/v1/agent/reinforce It's an example for CartPole-v0, while I'm playing around with LunarLander-v2.
I've come now to implementing the "step" function. And I realized that Env.Step() function takes int as an argument. Maybe that's what is needed for the CartPole-v0, but LunarLander-v2's step is float: https://github.com/openai/gym/blob/master/gym/envs/box2d/lunar_lander.py#L111
# Action is two floats [main engine, left-right engines].
# Main engine: -1..0 off, 0..+1 throttle from 50% to 100% power. Engine can't work with less than 50% power.
# Left-right:  -1.0..-0.5 fire left engine, +0.5..+1.0 fire right engine, -0.5..0.5 off

Pretty much everywhere in the gold library where I meet anything action-related - it's int.
How should it be mapped to the continuous environments? Or is it not possible at the moment? If so, would it be difficult to implement it?

Hm, my bad. I've just re-read the action definition here: it's given as intervals, e.g. -1..0 off, which means that integers can also be used in this case. I still wonder though if there are other environments where the action actually has to be a real value... 🤔

Hey @dtitov, yeah I believe actions are currently only discreet, and I had planned on supporting continuous in the future. If you're up for it, feel free to add, although I think some of this would be simpler once generics are available.

I think some of this would be simpler once generics are available.

Very likely :) Let's wait for it then, thanks.

Hm, I now stumbled across a different issue: arity of the action/step. In the current implementation, action is one number (doesn't matter whether it's int or float). But for the lunar lander, action is a vector of two numbers. How is that supposed to be handled? 🤔

Ah yeah I had only tried out a couple environments with the agents so far and hadn't progressed to lunar lander yet, the action out of the agent probably needs to be a tensor. That would need a change, but I'm pretty swamped with the day job and a toddler right now 🙂

Right, I see. Thanks anyway.


Please add Fiori design

https://experience.sap.com/fiori-design/

Thanks for the suggestion, have just merged this in!


A bug about the "Show Code Actions" from clangd

Type: Bug
A blue lightbulb appears when clangd detects an issue and a preferred quick fix is available. But the blue bulb won't go away after the issue is fixed. And a contributor of Clangd said "
I can't reproduce this, but based on the symptoms it seems more likely to be an issue with the editor (vscode) itself rather than the vscode-clangd plugin.
".
System information
Clangd version : 17.0.3
clangd extension version: 0.1.28
Operating system: Linux Mint 21.3
VS Code: March 2024 (version 1.88)
VS Code version: Code 1.88.0 (5c3e652f63e798a5ac2f31ffd0d863669328dc4c, 2024-04-03T13:25:57.039Z)
OS version: Linux x64 5.15.0-91-generic
Modes:

System Info

Item
Value

CPUs
Intel(R) Core(TM) i7-14700HX (28 x 2300)

GPU Status
2d_canvas: enabledcanvas_oop_rasterization: disabled_offdirect_rendering_display_compositor: disabled_off_okgpu_compositing: enabledmultiple_raster_threads: enabled_onopengl: enabled_onrasterization: enabledraw_draw: disabled_off_okskia_graphite: disabled_offvideo_decode: enabledvideo_encode: disabled_softwarevulkan: disabled_offwebgl: enabledwebgl2: enabledwebgpu: disabled_off

Load (avg)
1, 1, 0

Memory (System)
15.39GB (12.21GB free)

Process Argv
.

Screen Reader
no

VM
0%

DESKTOP_SESSION
cinnamon

XDG_CURRENT_DESKTOP
X-Cinnamon

XDG_SESSION_DESKTOP
cinnamon

XDG_SESSION_TYPE
x11

Extensions (32)

Extension
Author (truncated)
Version

easy-highlight
Bra
1.2.0

doxdocgen
csc
1.4.0

vscode-markdownlint
Dav
0.54.0

githistory
don
0.6.20

gitlens
eam
14.9.0

LogFileHighlighter
emi
2.18.0

auto-rename-tag
for
0.1.10

shell-format
fox
7.2.5

latex-workshop
Jam
9.19.2

vsc-python-indent
Kev
1.18.0

vscode-leetcode
Lee
0.18.1

vscode-clangd
llv
0.1.28

git-graph
mhu
1.30.0

vscode-docker
ms-
1.29.0

black-formatter
ms-
2024.2.0

debugpy
ms-
2024.4.0

python
ms-
2024.4.0

vscode-pylance
ms-
2024.4.1

remote-containers
ms-
0.354.0

remote-ssh
ms-
0.110.1

remote-ssh-edit
ms-
0.86.0

remote-explorer
ms-
0.4.3

copy-file-name
nem
1.2.0

ltex
neo
13.1.1

autodocstring
njp
0.6.1

vscode-yaml
red
1.14.0

shellman
Rem
5.7.0

shellcheck
tim
0.37.0

cmake
twx
0.0.17

errorlens
use
3.16.0

markdown-all-in-one
yzh
3.6.2

vscode-proto3
zxh
0.5.5

@BrikeX when clicking on that blue lightbulb after performing the remove code action, does an additional menu come up?

@BrikeX when clicking on that blue lightbulb after performing the remove code action, does an additional menu come up?

Yes and it looks like it can keep deleting lines.

https://github.com/clangd/vscode-clangd/issues/614#issuecomment-2085416482, @justschen It looks like someone else has encountered the same problem.


Added setSpeed to set wad speed during playback

This simply adds to the set____ functions, and is similar to the setPanning() function, however it will allow for setting the speed during playback!
This was tested using Flyxer (see here: https://github.com/julianpoy/Flyxer), and was working. It should allow for any wad's playback speed to be changed during playback. Any additional testing is much appreciated.
Thank You!

The code looks good, but Github is telling me there are conflicts. Maybe there's something small you can clean up on your end?

Of course, I'll get on that, probably due to the last branch being pulled :)

This is fixed and ready to go!
thank you @rserota !

Looks good. Thanks for contributing!

@rserota You are welcome! Thank you for letting me be a part of this! Wad is super cool!


Updated vundle repo

As the actual development of Vundle has been moved to https://github.com/VundleVim/Vundle.vim, updated the reference in the config file.

 Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.

Invalid


VS CODE, MinGW, CodeBlocks Setup

We appreciate you trying to make a PR @dev-69. Unfortunately we have decided to not approve your PR cause the blog isn't well formatted. Kindly make the appropriate changes and make another PR

Also we do not appreciate the fact that the blog pertains to Windows users only.


Fix client-ids in OpenInit and OpenTry for connection

Closes: #103
Description
Small bug in client_id attributes for OpenInit and OpenTry connection events.

For contributor use:

[ ] Unit tests written
[ ] Added test to CI if applicable
[ ] Updated CHANGELOG_PENDING.md
[ ] Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
[ ] Updated relevant documentation (docs/) and code comments
[ ] Re-reviewed Files changed in the Github PR explorer

Codecov Report

Merging #104 into master will decrease coverage by 3.3%.
The diff coverage is 0.1%.

@@           Coverage Diff            @@
##           master    #104     +/-   ##
========================================
- Coverage    14.5%   11.1%   -3.4%
========================================
  Files          58      67      +9
  Lines        2219    2814    +595
  Branches      761     999    +238
========================================
- Hits          322     315      -7
- Misses       1598    2200    +602
  Partials      299     299

Impacted Files
Coverage Δ

modules/src/error.rs
0.0% <0.0%> (ø)

modules/src/events.rs
0.0% <0.0%> (ø)

modules/src/ics02_client/client_type.rs
47.6% <0.0%> (ø)

modules/src/ics02_client/events.rs
0.0% <0.0%> (ø)

modules/src/ics03_connection/events.rs
0.0% <0.0%> (ø)

modules/src/ics03_connection/msgs.rs
20.2% <ø> (-0.9%)
:arrow_down:

modules/src/ics04_channel/events.rs
0.0% <0.0%> (ø)

modules/src/ics04_channel/msgs.rs
21.6% <ø> (-0.7%)
:arrow_down:

modules/src/ics07_tendermint/msgs/create_client.rs
0.0% <0.0%> (ø)

modules/src/ics07_tendermint/msgs/update_client.rs
0.0% <0.0%> (ø)

... and 39 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 147e44a...19df78c. Read the comment docs.


Implementation of WalletConnect

Description
Implementation of WalletConnect on Staking Dashboard
Context
We've noticed that on Harmony's staking platform there are only Ledger Nano, Math, and Harmony wallets currently available - given WalletConnect being a popular protocol, we wonder if it's possible to implement WalletConnect as one of the supported methods to sign the delegation.
The WalletConnect is a protocol that can be used to sign transactions using mobile wallets that support walletconnect protocol.
Reference
https://docs.walletconnect.org/v/2.0/
Acceptance Criteria

[ ] add support of wallet connect to the current staking dashboard without breaking existing functions
[ ] PRs submit to harmony staking dashboard repo and work with Harmony team to merge the PRs
[ ] recorded video to demonstrate the function of a working walletconnect support on all actions of staking dashboard
[ ] test with a few mobile wallets with walletconnect support such as TrustWallet

Reward
USD $10,000 equivalent of ONE token

hey @developerfred . how s it going. is there any update?

@jhd2best I managed to come up with a solution that would be to make transactions in Hex and only display address One on the frontend, but all transactions and interactions with walletConnect will be done in hex

hey @developerfred . how s it going. is there any update?

Hey @jhd2best  I will send the new updates

Hello @jhd2best, are you still into this issue? I have done some work on it but can't properly test it because I can't set a proper local backend environment. Can you help me out?
The npm run dev does not work, because it is not setted up in the package.json, but even if I run with tsc -w & NODE_ENV=local nodemon -q -w ./dist ./dist/server.js, I can't bootstrap it because of the gcp serviceAccount key that is needed for the database service. How do you usually setup the local environment?
Thanks !!

@jpldcarvalho I fixed these issues, I had sent the pull request before. I just need to send an update.

any body working on this? is it still available?

@ferasawadi I am working on!

@developerfred any update? been too long, other people may work on it if you have no time to finish it.

@LeoHChen wow, I will update this pr.
sorry about late

@LeoHChen  Ready now, sorry for the delay.

@LeoHChen https://github.com/harmony-one/staking-dashboard/pull/580

@LeoHChen This bounty was a "Contest Permissionless" type at GitCoin. I don't think it's fair for @developerfred to be locking this bounty for months just because it sent an early (incomplete) PR.
I have been waiting for months for a review...
If it was a "Traditional" or "Approval Required" bounty I could agree that it was "locked" to another developer

@jpldcarvalho as you noticed my pull request is not incomplete

@developerfred the one 5 months ago was


NSDistributedNotificationCenter does not have an addMockObserver method

OCMock adds addMockObserver to NSNotificationCenter but it doesn't to NSDistributedNotificationCenter.

Can you confirm that creating a category on NSDistributedNotificationCenter that contains the following code would work in the way you expect it? https://github.com/erikdoe/ocmock/blob/master/Source/OCMock/NSNotificationCenter%2BOCMAdditions.m#L23-27

I think it would.


A cheat to use available cheats

Hi,
I have installed cheat, but I do not find a simple to note - a cheat - on how to install and use the community-sourced cheatsheets available.
I think it would be a good starting point.
Thank you

Hi @chrisallenlane
a good improvement may be to automatically create the folders ~/cheat/cheatsheets/community/ (if not given) and copy the community cheatsheets in the configured folder.
This way a user simply can run cheat without having to touch the config (if he does not want to).
This also would be benefitial for the snap version, as I do not have an easy way of auto generating this folders/files from within the snap when cheat is started first after a fresh installation.
What do you think?

Hi, guys
@aborruso, thanks for the input. I'm still getting the impression from users that cheat is too difficult to configure initially.
@bernermic, yeah, something like that would probably be the way to go. I've been reluctant to avoid creating "official" cheatpaths for a while now, because such a thing isn't strictly necessary. That said, this seems to be causing confusion for a significant number of users, so perhaps the approach I've taken so far has caused more harm than good.
I'll think about this for a bit, and will open a feature-request ticket when I have a proposed detailed solution. I'll tag both of you on it so you can review before I begin the implementation.

Hi @chrisallenlane and firt of all thank you.
I think that to avoid creating "official" cheatpaths is a good idea.
My request is to add a sort of cheat, in the readme of the project:
# How to add community-sourced cheats

To add the community-sourced cheats these are the simple steps:

- git clone ...
- then ...

Best regards

Hey @aborruso & @chrisallenlane,
I would rater follow a different approach and give users who don't want to take care of a setup to make it a no brainer.
I would argue that many users only want to use cheat right out of the box and will be rather confused when they have to clone something after they installed cheat.
Maybe a dialogue at the beginning if cheat should do the setup for the user or something along this lines could also work?
Thanks for taking care of this @chrisallenlane I am looking forward to check in next time :)
Greetings
Michael

@aborruso, @bernermic
Hi, guys. Sorry for the slow progress on this ticket. Work has been keeping me busy.

I'll think about this for a bit, and will open a feature-request ticket when I have a proposed detailed solution. I'll tag both of you on it so you can review before I begin the implementation.

Minor change in plans here.
Writing code is more fun than writing RFCs, so I just took a stab at implementing this. When you have a moment, please take a look at this draft PR opened from my personal fork:
https://github.com/cheat/cheat/pull/542
If you have the time, please build that on your machines, temporarily rename your cheat config file, and then attempt to view a cheatsheet. cheat should recognize that you don't have a config file, and will then prompt you with an "installer" that asks if you'd like to create a config file and (automatically) clone the community cheatsheets.
Also, I simplified this somewhat from my original vision. Initially, I was thinking that we'd have to prompt the user for desired config paths, cheatsheet paths, etc. I realized, though, that this code path is for users that don't care about those details (and want cheat to "just work"), so I chose some defaults that I figured would be sensible.
This is still a bit rough, but you get the idea. (I still need to consolidate some file paths, write some unit-tests, and address some probably cross-platform issues.)
What do you guys think of that approach?

And, yeah, @bernermic

I would argue that many users only want to use cheat right out of the box and will be rather confused when they have to clone something after they installed cheat.

I think that's the key point here. That's why I eschewed the more nuanced config wizard and just hard-coded some sensible defaults. This will probably work better for the users that don't care about these details.

Oh, note to self: don't forget to update the README also.

@aborruso, @bernermic
Hi, guys. Sorry for the slow progress on this ticket. Work has been keeping me busy.

I'll think about this for a bit, and will open a feature-request ticket when I have a proposed detailed solution. I'll tag both of you on it so you can review before I begin the implementation.

Minor change in plans here.
Writing code is more fun than writing RFCs, so I just took a stab at implementing this. When you have a moment, please take a look at this draft PR opened from my personal fork:
#542
If you have the time, please build that on your machines, temporarily rename your cheat config file, and then attempt to view a cheatsheet. cheat should recognize that you don't have a config file, and will then prompt you with an "installer" that asks if you'd like to create a config file and (automatically) clone the community cheatsheets.
Also, I simplified this somewhat from my original vision. Initially, I was thinking that we'd have to prompt the user for desired config paths, cheatsheet paths, etc. I realized, though, that this code path is for users that don't care about those details (and want cheat to "just work"), so I chose some defaults that I figured would be sensible.
This is still a bit rough, but you get the idea. (I still need to consolidate some file paths, write some unit-tests, and address some probably cross-platform issues.)
What do you guys think of that approach?

@chrisallenlane many thanks for your work 😀
I will try it asap and give you feedback.
But this will most likely not be this week, as I am busy right now.
Greetings

@aborruso, @bernermic
Hi, guys. I implemented an "installer" that should make it very painless for first-time users to install and configure cheat. It's included in the 3.7.0 release:
https://github.com/cheat/cheat/releases/tag/3.7.0
To try this out, momentarily rename your config file (so cheat thinks you don't have a config file). An installer should launch (on the CLI) that offers to create both a default config file and download the community cheatsheets.
Please try it out and let me know what you think!
I'm going to close this ticket as "resolved", but feel free to re-open it (either of you) if necessary.
Thanks!

Hi @chrisallenlane you are very kind: it works and it's great!
Thank you very much

Glad to hear it, @aborruso. Thanks! :tada:


Add support for SEEM: Segment Everything Everywhere All at Once

SEEM is an alternative to SAM. It would be great to add SEEM support for segmenting satellite imagery.
https://github.com/UX-Decoder/Segment-Everything-Everywhere-All-At-Once

More relevant projects:

https://github.com/fudan-zvg/Semantic-Segment-Anything
https://github.com/IDEA-Research/Grounded-Segment-Anything

Is there any way to add support for SEEM now?

I don't have time to implement this yet. Contributions are always welcome.


Is it possible to create custom/non-standard device type? (CON-446)

Espressif's SDK for Matter guide describes how to create custom endpoints, clusters, attributes, and commands that are not defined in the Matter specification but nothing said about custom device types.

@Gonta01 There is no separate API for creation of a custom device type. Device type, as per the Matter specification, is the highest semantic element of the Matter data model that conforms to a set of one or more endpoints.
So, basically, you can create custom endpoint(s) and cluster(s) to create a sort of custom device type. Note that, any custom entity requires the other end (commissioner) to understandthe same.

Closing this as the question is answered


Debug logging

How do you log request / response for debugging purposes with Frisbee?

@tonyxiao nothing is built in right now, if you're on Node we could add debug package so you could run with DEBUG=frisbee environment flag, otherwise if on browser we'd have to put console logs or something, hmm...  Any ideas?  Pull request would be really welcomed!

In v3.0.0 of Frisbee you can do DEBUG=frisbee node app.js as we have debug integrated

Soon to be released

v3.0.0 is released with the ability to do DEBUG=frisbee node app.js to output debug statements.

:tada: v3.0.1 is released with support for a custom logRequest and logResponse option :tada:
Here's a quick example, but you can see the Logging and Debugging section of the README for more insight.
const cabin = require('cabin');
const frisbee = require('frisbee');
const pino = require('pino')({
  customLevels: {
    log: 30
  }
});

const logger = new Cabin({
  // (optional: your free API key from https://cabinjs.com)
  // key: 'YOUR-CABIN-API-KEY',
  axe: { logger: pino }
});

const api = new Frisbee({
  logRequest: (path, opts) => {
    logger.info('fetch request', { path, opts });
  },
  logResponse: res => {
    logger.info('fetch response', { res });
  }
});

Try it out and let me know if it works or if you need anything further:
npm install frisbee@latest

Just an update - v3.0.2 now supports logResponse having three arguments, path, opts, and response.  It looks now like this:
const api = new Frisbee({
  logRequest: (path, opts) => {
    logger.info('fetch request', { path, opts });
  },
  logResponse: (path, opts, res) => {
    logger.info('fetch response', { path, opts, res });
  }
});


Rails 5.1.4 and cancancan Unpermitted parameters on update

Steps to reproduce
I've got a has_many through relation for Reservation and AdditionalService models:
class Reservation < ApplicationRecord
  has_one :stretch, dependent: :destroy

  has_many :reservation_additional_services, dependent: :destroy
  has_many :additional_services, through: :reservation_additional_services

  belongs_to :user

  enum status: [:submitted, :cancelled, :confirmed, :on_going, :altered, :finished]

  accepts_nested_attributes_for :stretch
  validates :additional_service_ids, presence: true, unless: ->(reservation) { reservation.is_a?(Reservation::Stay) }

  def cancel!
    self.cancelled!
  end

  def costs
    additional_costs + additional_services.map(&:price).inject(0){|sum, x| sum + x}
  end
end

class AdditionalService < ApplicationRecord
  has_many :reservation_additional_services
  has_many :reservations, through: :reservation_additional_services
end

I've got my ReservationsController defined like this:
class ReservationsController < ApplicationController
  load_and_authorize_resource except: [:index, :create]

  def index
    @reservations = current_user.reservations
  end

  def new
    @reservation.build_stretch
  end

  def create
    @reservation = Reservation.new(reservation_prams)
    @reservation.user = current_user

    @reservation.build_stretch unless @reservation.stretch.present?

    if @reservation.save
      redirect_to reservations_url
    else
      render :new, status: :not_acceptable
    end
  end

  def edit
  end

  def update
    puts "**************************"
    p update_params
    p params
    if @reservation.update_attributes(update_params)
      redirect_to reservations_url
    else
      render :edit, status: :not_acceptable
    end
  end

  def destroy
    @reservation.cancel!
    redirect_to reservations_url
  end

  private
    def reservation_prams
      params.require(:reservation).permit(
        stretch_attributes: [:start_date, :end_date],
        additional_service_ids: []
      )
    end

    def update_params
      params.require(:reservation).permit(
        additional_service_ids: []
      )
    end
end

I use a regular kind of form and when I try to change additional service in select and submit, nothing changes and in the server I get this output:
**************************
Unpermitted parameters: :stretch_attributes, :additional_service_ids
<ActionController::Parameters {} permitted: true>
<ActionController::Parameters {"utf8"=>"✓", "_method"=>"patch", "authenticity_token"=>"RFTlG91gWUVOLTTEn/319D1v1d+bmTc+sjhnXFlFUSdHwxZXCjpCRM+1fsYYLhHqyhk7w5dtYXZZrN3X0WqHeA==", "reservation"=><ActionController::Parameters {"stretch_attributes"=>{"start_date"=>"2017-01-12 00:00:00 UTC", "end_date"=>"2017-01-14 00:00:00 UTC", "id"=>"1"}, "additional_service_ids"=>"3"} permitted: false>, "commit"=>"Zarezerwuj", "controller"=>"reservations", "action"=>"update", "id"=>"1"} permitted: false>

I don't know what's wrong because everything does work for the other model that inherits from Reservation - Reservation::Stay here is controller for that:
class StaysController < ApplicationController
  load_and_authorize_resource :reservation, parent: false, class: Reservation::Stay, except: [:create]

  def new
    @reservation.build_stretch
    render '/reservations/new'
  end

  def create
    @reservation = Reservation::Stay.new(stay_params)
    @reservation.user = current_user

    @reservation.build_stretch unless @reservation.stretch.present?

    if @reservation.save
      redirect_to reservations_url
    else
      render '/reservations/new', status: :not_acceptable
    end
  end

  def update
    if @reservation.update_attributes(update_params)
      @reservation.altered!
      redirect_to reservations_url
    else
      render '/reservations/edit', status: :not_acceptable
    end
  end

  private
    def stay_params
      params.require(:reservation_stay).permit(
        stretch_attributes: [:start_date, :end_date],
        additional_service_ids: [],
        room_ids: []
      )
    end

    def update_params
      params.require(:reservation_stay).permit(
        additional_service_ids: []
      )
    end
end

There is my form:
= simple_form_for(@reservation,
  defaults: { label: false }) do |f|
  .row
    = f.simple_fields_for :stretch do |sf|
      = sf.input :start_date, as: :string, label: t('.labels.start_date'), input_html: { class: 'datepicker'  }
      = sf.input :end_date, as: :string, label: t('.labels.end_date'), input_html: { class: 'datepicker' }
    - if @reservation.is_a?(Reservation::Stay)
      = f.input :additional_service_ids,
        as: :select, input_html: { multiple: true }, label: t('.labels.additional_service'),
        collection: AdditionalService.all.collect {|as| ["#{as.name} - #{as.price}", as.id] }
      = f.input :room_ids,
        as: :select,
        input_html: { multiple: true },
        label: t('.label.rooms'),
        collection: Room.all.collect{ |room| ["#{room.number}", room.id]}
    - else
      = f.input :additional_service_ids,
          as: :select,
          collection: AdditionalService.all.collect {|as| ["#{as.name} - #{as.price}", as.id] }

  .row
    = f.submit t('.labels.book')

javascript:
  Reservations.initForm();

Expected behavior
The record should update but it doesn't
Actual behavior
I get unpermitted parameters in server output
System configuration
Rails version: 5.1.4
Ruby version: 2.4.1
CanCanCan version 2.0.0

@greggzst I had a similar problem with has_many through and validation and switch back to cancancan 1.x. The problem seems to come from the use of ActiveSupport.on_load (https://github.com/CanCanCommunity/cancancan/blob/develop/lib/cancan/model_adapters/active_record_adapter.rb#L147). I tried cancancan 2.x with the old class_eval and it worked as expected.
ActiveRecord::Base.class_eval do
  include CanCan::ModelAdditions
end

Any news on this issue?

Yeah, I had an typo - reservation_prams after I had fixed it everything started working fine.  This issue can be closed.

Please refer to Stackoverflow for questions. Thanks.

It looks like without nested attributes you would be able to omit
# create action
@reservation = Reservation::Stay.new(stay_params)

and load_and_authorize_resource would do that for you. But with nested attributes it's not working, so you have to add that line again.


Update scalatest to 3.2.10

Updates org.scalatest:scalatest from 3.0.9 to 3.2.10.
GitHub Release Notes - Version Diff
I'll automatically update this PR to resolve conflicts as long as you don't change it yourself.
If you'd like to skip this version, you can just close this PR. If you have any feedback, just mention me in the comments below.
Configure Scala Steward for your repository with a .scala-steward.conf file.
Have a fantastic day writing Scala!

Applied Migrations

https://raw.githubusercontent.com/scalatest/autofix/e4de53fa40fac423bd64d165ff36bde38ce52388/3.1.x/rules/src/main/scala/org/scalatest/autofix/v3_1_x/RewriteDeprecatedNames.scala

Documentation:

https://github.com/scalatest/autofix/blob/master/3.1.x/README.md

Ignore future updates
Add this to your .scala-steward.conf file to ignore future updates of this dependency:
updates.ignore = [ { groupId = "org.scalatest", artifactId = "scalatest" } ]

labels: library-update, early-semver-minor, semver-spec-minor, scalafix-migrations

Coverage decreased (-0.3%) to 33.621% when pulling 0cafe30e37e645fb59c583d4d5ea2cce33f3d307 on scala-steward:update/scalatest-3.2.10 into d082b04ae38161e522ab7991a62ceff130832f4e on evolution-gaming:master.

Superseded by #82.


⚠ Bofrost.be has degraded performance

In 9fee1ea, Bofrost.be (https://www.bofrost.be) experienced degraded performance:

HTTP code: 200
Response time: 886 ms

Resolved: Bofrost.be performance has improved in 1a099ef.


Add access instructions to the cluster

Add access instructions to the cluster

thanks for responding @rtrinque - happy for this to go once you add the link to the basic gov.uk dev setup as per comment


ShouldFire-ify some inventory events

This PR checks some ShouldFire flags in some inventory packet listeners. This should greatly improve performance in the case where there are little to no plugins listening for inventory events.

Code looks fine (have not tested)


Rethink how logging is handled

The design is poor and the logging settings in config.json are very confusing. This area can be improved upon greatly.

I think the best approach here is:

remove logging from the config file, do not allow any permanent verbosity modifications in this way
expand the --verbose flag - it should be possible to automatically output the traceback and/or call trace on failed transactions, especially when running tests (include a note that this will come at a time expense because of debug_traceTransaction)


VAR FiscalCalendarFirstMonth = 1

I've downloaded the 1.0.2 version, opened the PBIX file, and changed "VAR FiscalCalendarFirstMonth = 9" to "VAR FiscalCalendarFirstMonth = 1" instead.
After that change, the "Fiscal Year" is showing "F 2009" for a "Date" value of "1/1/2008 12:00:00 AM"
Shouldn't the "Fiscal Year" be "F 2008"?

You're right - I'll work on this and other bugs very soon.


Main page overhaul and enhancements

This PR include multiple changes for the website.
Site-wide Changes:

Changing metadata for the website
Changing old background SVG to a new SVG image

Repo Changes:

New screenshot to showcase on Github Repo
Updated Nextjs version from 13 to 14 on README.md

Home Page:

Adjust positioning of the animated Skills Icon on the home page
Changing grid layout from 2 columns to 1 columns
Added an additional link for Projects
Absolute animations for the buttons
Adjust sizing of the Controller SVG component
Text content change

Project Page:

Adjust layout of individual project slugs (2 column grid will be visible upon "md" viewport instead of "sm" viewport)
Increased image size of project slug pages on mobile viewports
Adjust spacing and changed various styles based on new layout (ie. "sm" -> "md" styling)
Add aria labels to ProjectCard's external links (GitHub and Site)

Framer:

Added two variants: one parent container variant and one variant for its children - this is to create a staggering animation effect

Changes needed to be done for improved a11y - performance can be better


[SPARK-9193] Avoid assigning tasks to "lost" executor(s)

Now, when some executors are killed by dynamic-allocation, it leads to some mis-assignment onto lost executors sometimes. Such kind of mis-assignment causes task failure(s) or even job failure if it repeats that errors for 4 times.
The root cause is that killExecutors doesn't remove those executors under killing ASAP. It depends on the OnDisassociated event to refresh the active working list later. The delay time really depends on your cluster status (from several milliseconds to sub-minute). When new tasks to be scheduled during that period of time, it will be assigned to those "active" but "under killing" executors. Then the tasks will be failed due to "executor lost". The better way is to exclude those executors under killing in the makeOffers(). Then all those tasks won't be allocated onto those executors "to be lost" any more.

Merged build triggered.

Merged build started.

Test build #37814 has started for   PR 7528 at commit b5546ce.

Test build #37814 has finished for   PR 7528 at commit b5546ce.

This patch passes all tests.
This patch merges cleanly.
This patch adds the following public classes (experimental):
class IllegalArgumentException(Exception):
case class DayOfYear(child: Expression) extends UnaryExpression with ImplicitCastInputTypes
case class DayOfMonth(child: Expression) extends UnaryExpression with ImplicitCastInputTypes
case class ConcatWs(children: Seq[Expression])

Merged build finished. Test PASSed.

Hi @GraceH thanks for finding this bug and posting the PR.  The changes look completely reasonable, but would it be possible to add a unit test?  I know this is a big ask, since it doesn't look like there are any tests right now on that test anything like this for CoarseGrainedSchedulerBackend, so it will probably take some work to do.
I believe this changes are correct, so the test isn't so much about verifying this fix as it is to prevent future regressions.  It would also really help in the future for following along the code -- eg., it took me a while to figure out how anything was ever removed from executorsPendingToRemove.

@squito Thanks for the confirmation. If you do think it is necessary to add unit test for CoarseGrainedSchedulerBackend, one more JIRA can be filed for that. Because it seems that should cover more than what this PR does.  What do you think?

Hi @GraceH this looks great. I left a few minor wording suggestions to improve readability.
As for unit tests, I do agree that we should have them, but it seems outside the scope of this fix since properly testing all of this logic would require a non-trivial refactor. In this case, I am more inclined to merge in this fix than to delay it indefinitely.

Thanks @andrewor14 . That makes sense. Will have a revised version with more readable lines.

Merged build triggered.

Merged build started.

Test build #37953 has started for   PR 7528 at commit 6e2ed96.

Test build #37953 has finished for   PR 7528 at commit 6e2ed96.

This patch fails Scala style tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Merged build triggered.

Merged build started.

Test build #37954 has started for   PR 7528 at commit ecc1da6.

yeah, I don't love the idea of adding things w/out tests, but in this case I suppose its best left for the future.  lgtm pending the tests passing

Thanks @squito.

Test build #37954 has finished for   PR 7528 at commit ecc1da6.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.


Help Me menu items show multiple chat cards

Describe the bug
When any of the Help Me menu items are selected, the appropriate chat card appears many times.
Steps to reproduce

select a token
Click on 'Help Me' > 'Aim'
Count the new 'Aim' chat cards in the chat sidebar

Versions:

Token Action HUD Core: 1.5.2
Token Action HUD SWADE: 1.0.1
Swade System: 3.3.11
Foundry VTT: 11.315
Browser: Firefox

Additional context
This happened when testing as a GM and as a player in a game.

It should be fixed in version 1.0.2

Confirmed fixed. Thank you.


addSimpleImage JavaScript removes existing images first - is this as per design?

From the name of the JavaScript method and the documentation, it seems like addSimpleImage is supposed to append new images in "sequenceMode" to the viewer.  Instead, it is removing all previous images and then opening the new one.  I have played around with "replace" and "index", but they don't seem to change the functionality.
I am opening the viewer using:
	window.onload = function() {
		viewer = OpenSeadragon({
			id: "openseadragon",
			prefixUrl: "images/",
			tileSources: [],
			sequenceMode: true,
			showReferenceStrip: true
		});

		var anno = OpenSeadragon.Annotorious(viewer, {
			locale: 'auto', allowEmpty: true
		});

		var toolToggle = document.getElementById('current-tool');
		toolToggle.addEventListener('click', function() {
			if (toolToggle.innerHTML == 'TOOL: RECTANGLE') {
				toolToggle.innerHTML = 'TOOL: POLYGON';
				anno.setDrawingTool('polygon');
			} else {
				toolToggle.innerHTML = 'TOOL: RECTANGLE';
				anno.setDrawingTool('rect');
			}
		});

		var modeBtn = document.getElementById('mode');
		modeBtn.addEventListener('click', function() {
			if (modeBtn.innerHTML == 'MODE: VIEW') {
				modeBtn.innerHTML = 'MODE: ANNOTATE';
				anno.setDrawingEnabled(true);
			} else {
				modeBtn.innerHTML = 'MODE: VIEW';
				anno.setDrawingEnabled(false);
			}
		});

		anno.on('createSelection', function(selection) {
			console.log('selection', selection);
		});

		anno.on('selectAnnotation', function(annotation) {
			console.log('selected', annotation);
		});

		anno.on('cancelSelected', function(a) {
			console.log('cancelSelected', a);
		});

		anno.on('mouseEnterAnnotation', function(annotation) {
			// console.log('mouseEnter', annotation);
		});

		anno.on('mouseLeaveAnnotation', function(annotation) {
			// console.log('mouseLeave', annotation);
		});
	}

Then at some later point, I call to add a new image:
	viewer.addSimpleImage({type: "image", url: filesToLoadAsArray[counter]}

The work around I am using right now is that I am sending all existing images plus the new one to the open method as an array.  This sort of works, but I am worried it is reloading all the previous images.  Is the addSimpleImage supposed to add a new image to the viewer removing all previous ones or is it supposed to just add the new image?

Good point... I can see how that's a little confusing! There's no facility for modifying the sequence after you've opened it. If you want a different sequence entirely, you can call viewer.open with the new sequence, and it'll remove the old sequence and replace it with the new one.
In your case, I think just including all of the images you want on the initial open is fine... that's the way sequence mode is designed to work. Behind the scenes it's actually only opening one image at a time, so it's not inefficient.


Practitioner Details endpoint not working (High Priority)

Describe the bug
The Practitioner Details endpoint does not return the Keycloak user details.
To Reproduce
Steps to reproduce the behavior:

Go to postman
Perform this GET request with a valid token : https://fhir-stage.smartregister.org/fhir/practitioner-details?keycloak-uuid=some-uuid-on-keycloak
See the error(Screenshot below)

Expected behavior
User details should be returned from the endpoint as described here #499
Screenshots
The request below gives the following response:
https://fhir-stage.smartregister.org/fhir/practitioner-details?keycloak-uuid=<some-uuid-on-keycloak>
 {
    "resourceType": "Bundle",
    "id": "c98de53b-bcf9-4a31-a340-d3063343c0b3",
    "meta": {
        "lastUpdated": "2023-02-18T17:42:11.664+00:00"
    },
    "type": "searchset",
    "total": 1,
    "link": [
        {
            "relation": "self",
            "url": "http://fhir-stage.smartregister.org/fhir/practitioner-details?keycloak-uuid=some-uuid-on-keycloak"
        }
    ],
    "entry": [
        {
            "fullUrl": "http://fhir-stage.smartregister.org/fhir/practitioner-details/Keycloak User Not Found",
            "resource": {
                "resourceType": "practitioner-details",
                "id": "Keycloak User Not Found",
                "meta": {
                    "profile": [
                        "http://hl7.org/fhir/profiles/custom-resource"
                    ]
                }
            }
        }
    ]
}

Device

Tested on Postman

Additional context
Might be because :

Keycloak was updated to a newer version
Something to do with the KC user configuration.

Hi @ndegwamartin ,
I see the following request returns a valid response along with the Keycloak User Details.
Can you please brief me the use-case of when Practitioner Details endpoint is failing with the Proxy instance?
cc: @dubdabasoduba

@rehammuzzamil did you hit the endpoint via the proxy or did you hit the server directly?

@dubdabasoduba  I have tested out by hitting the Patient Resource via the Proxy Server.
I have shared screenshots on slack earlier.

@rehammuzzamil we need to test the Practitioner Details endpoint to make sure it works well. It's one of the endpoints the app will be hitting

@dubdabasoduba  I have tested out the end-point separately as well, it returns valid response on my local server.
Would you mind sharing me the API endpoint along with the params and logs from the app?

@rehammuzzamil Please try hit this endpoint with the FHIR stage server oauth credentials https://fhir-stage.smartregister.org/fhir/practitioner-details?keycloak-uuid=9ed39e30-3350-4625-8943-47e611fb1dcf

@rehammuzzamil Please try hit this endpoint with the FHIR stage server oauth credentials https://fhir-stage.smartregister.org/fhir/practitioner-details?keycloak-uuid=9ed39e30-3350-4625-8943-47e611fb1dcf

Sure.

@rehammuzzamil any feedback on your results after you tried hitting the endpoint above?

Yes @ndegwamartin , There seem to be two issues:

SecurityContextHolder.getContext().getAuthentication()  is always returning false, need to debug it that why it is failing now. Earlier, it was working perfectly.
There seems to be a bug in introducing an additional searchParam isAuthProvided logic.

Apart from this, there is an area under RnD, where we can get the KeycloakUserDetails data directly from the userInfo API of the Keycloak, if that is the case, we will be removing it from the PractitionerDetails Response Payload.
cc: @dubdabasoduba


Problem with Environment Configuration: [RUN get_start.py with errors]

My configuration
System: Ubuntu 20.04
The python version is 3.8.10. I have successfully installed Wine using the instructions in install_deps.sh. I have also installed all packages from the requirements.txt file, except for torch==1.11.0, as I have already installed version 2.0.1 using pip.
Then, I modified line 20 in get_start.py as follows:
    config = {
        'id': 1,
        'env_setting': 'linux',
        'client_path': 'path-to-game-client',
        'rl_server_ip': '<IP_ADDRESS>',
        'rl_server_port': 42636,
        'game_server_ip': 'according to the email sent to me',
        'game_server_port': according to the email sent to me,
        'machine_server_ip': '',
        'machine_server_port': 0,
        'episode_horizon': 100000,
        'user_name': 'according to the email sent to me'
    }

Errors
When I run python get_start.py, the output is as follows:
0024:fixme:ntdll:create_logical_proc_info Improve CPU info reporting: system supports 48 logical cores, but only 32 supported!
0024:fixme:ntdll:create_logical_proc_info skipping logical processor 33
0024:fixme:ntdll:create_logical_proc_info skipping logical processor 34
0024:fixme:ntdll:create_logical_proc_info skipping logical processor 35
0024:fixme:ntdll:create_logical_proc_info skipping logical processor 36
0024:fixme:ntdll:create_logical_proc_info skipping logical processor 37
0024:fixme:ntdll:create_logical_proc_info skipping logical processor 38
0024:fixme:ntdll:create_logical_proc_info skipping logical processor 39
0024:fixme:ntdll:create_logical_proc_info skipping logical processor 40
0024:fixme:ntdll:create_logical_proc_info skipping logical processor 41
0024:fixme:ntdll:create_logical_proc_info skipping logical processor 42
0024:fixme:ntdll:create_logical_proc_info skipping logical processor 43
0024:fixme:ntdll:create_logical_proc_info skipping logical processor 44
0024:fixme:ntdll:create_logical_proc_info skipping logical processor 45
0024:fixme:ntdll:create_logical_proc_info skipping logical processor 46
0024:fixme:ntdll:create_logical_proc_info skipping logical processor 47
0084:fixme:hid:handle_IRP_MN_QUERY_ID Unhandled type 00000005
0084:fixme:hid:handle_IRP_MN_QUERY_ID Unhandled type 00000005
0084:fixme:hid:handle_IRP_MN_QUERY_ID Unhandled type 00000005
0084:fixme:hid:handle_IRP_MN_QUERY_ID Unhandled type 00000005
wine: failed to open "path-to-game-client/Lx33.exe": c0000135

When I press Ctrl + C, the output is as follows:
Traceback (most recent call last):
  File "get_start.py", line 74, in <module>
    main()
  File "get_start.py", line 65, in main
    states, infos = env.reset()
  File "/workspace/DunkCity/DunkCityDynasty-main/DunkCityDynasty/env/gym_env.py", line 21, in reset
    raw_states = self.external_env.reset()
  File "/workspace/DunkCity/DunkCityDynasty-main/DunkCityDynasty/env/base.py", line 74, in reset
    states = self._wait_for_state(min_player=3)
  File "/workspace/DunkCity/DunkCityDynasty-main/DunkCityDynasty/env/base.py", line 259, in _wait_for_state
    sleep(0.001)
  File "/workspace/DunkCity/DunkCityDynasty-main/DunkCityDynasty/utils/util_fn.py", line 16, in sleep
    pass
KeyboardInterrupt

Then I press Ctrl + C again to stop the process, the output is as follows:
Exception ignored in: <module 'threading' from '/usr/lib/python3.8/threading.py'>
Traceback (most recent call last):
  File "/usr/lib/python3.8/threading.py", line 1388, in _shutdown
    lock.acquire()
KeyboardInterrupt:

After that, the process has been stopped.
In order to provide a complete overview of my actions, I've divided the errors into three parts as shown above. I've combined the entire error sequence (which is actually the amalgamation of the three parts above) below to present the complete errors.
0024:fixme:ntdll:create_logical_proc_info Improve CPU info reporting: system supports 48 logical cores, but only 32 supported!
0024:fixme:ntdll:create_logical_proc_info skipping logical processor 33
0024:fixme:ntdll:create_logical_proc_info skipping logical processor 34
0024:fixme:ntdll:create_logical_proc_info skipping logical processor 35
0024:fixme:ntdll:create_logical_proc_info skipping logical processor 36
0024:fixme:ntdll:create_logical_proc_info skipping logical processor 37
0024:fixme:ntdll:create_logical_proc_info skipping logical processor 38
0024:fixme:ntdll:create_logical_proc_info skipping logical processor 39
0024:fixme:ntdll:create_logical_proc_info skipping logical processor 40
0024:fixme:ntdll:create_logical_proc_info skipping logical processor 41
0024:fixme:ntdll:create_logical_proc_info skipping logical processor 42
0024:fixme:ntdll:create_logical_proc_info skipping logical processor 43
0024:fixme:ntdll:create_logical_proc_info skipping logical processor 44
0024:fixme:ntdll:create_logical_proc_info skipping logical processor 45
0024:fixme:ntdll:create_logical_proc_info skipping logical processor 46
0024:fixme:ntdll:create_logical_proc_info skipping logical processor 47
0084:fixme:hid:handle_IRP_MN_QUERY_ID Unhandled type 00000005
0084:fixme:hid:handle_IRP_MN_QUERY_ID Unhandled type 00000005
0084:fixme:hid:handle_IRP_MN_QUERY_ID Unhandled type 00000005
0084:fixme:hid:handle_IRP_MN_QUERY_ID Unhandled type 00000005
wine: failed to open "path-to-game-client/Lx33.exe": c0000135
^CTraceback (most recent call last):
  File "get_start.py", line 74, in <module>
    main()
  File "get_start.py", line 65, in main
    states, infos = env.reset()
  File "/workspace/DunkCity/DunkCityDynasty-main/DunkCityDynasty/env/gym_env.py", line 21, in reset
    raw_states = self.external_env.reset()
  File "/workspace/DunkCity/DunkCityDynasty-main/DunkCityDynasty/env/base.py", line 74, in reset
    states = self._wait_for_state(min_player=3)
  File "/workspace/DunkCity/DunkCityDynasty-main/DunkCityDynasty/env/base.py", line 259, in _wait_for_state
    sleep(0.001)
  File "/workspace/DunkCity/DunkCityDynasty-main/DunkCityDynasty/utils/util_fn.py", line 16, in sleep
    pass
KeyboardInterrupt
^CException ignored in: <module 'threading' from '/usr/lib/python3.8/threading.py'>
Traceback (most recent call last):
  File "/usr/lib/python3.8/threading.py", line 1388, in _shutdown
    lock.acquire()
KeyboardInterrupt:

I appreciate your time and attention in reviewing this issue. Please let me know if you need any further information from my side. I'm looking forward to your assistance and insights. Thank you!

my computer also is ubuntu 20.04, but when i run './install_deps.sh' , I got some errors: 'The following signatures couldn’t be verified because the public key is not available' and the download speed is very low. I want to know that have you ever see these errors?

client_path

client_path shoulg be right

@sxzhuang
Hi, I see your client_path in your config is still the default valule.
It should be changed to the path of the client in your computer.
config = {
    'id': 1,
    'env_setting': 'linux',
    'client_path': 'path-to-game-client' -> your client path,

......
}
Thank you.

@accuracy-maker

my computer also is ubuntu 20.04, but when i run './install_deps.sh' , I got some errors: 'The following signatures couldn’t be verified because the public key is not available' and the download speed is very low. I want to know that have you ever see these errors?

Hi, for solving installing errors on Ubuntu, you can change the downloading source of your system, for example, using Tsinghua source or Alibaba source.
For the problem of slow download speed, there are some ways you can try:

Use a VPN (e.g., Shadowsocks、V2ray) to accelerate.
Access mirror site of huggingface, for example, https://mirrors.tuna.tsinghua.edu.cn/hugging-face-datasets/
When accessing the mirror site, you need to replace the domain name "huggingface.co" with the address of the mirror site in the data download link.
Connect your computer to a high-speed network, such as a 5G network. I have just tried this and it really worked (without a VPN).

@sxzhuang Hi, I see your client_path in your config is still the default valule. It should be changed to the path of the client in your computer.
config = {
    'id': 1,
    'env_setting': 'linux',
    'client_path': 'path-to-game-client' -> your client path,

...... }
Thank you.

I changed the path, and the error has been solved. Thanks a lot!!


selected_db is undefined

if the redis url provided to create the redis client does not contains the db part, say, redis://localhost instead of redis://localhost/0, then the redis will connect to db 0 but the client.selected_db and client.options.db is undefined.

selected_db is a internal value that should not be used and the options is something the user provides to the client.
The behavior itself is correct though as the client will not fire a select query to Redis.
As the default for new clients is always to connect to db 0 it would be fine though to set selected_db to 0 as a default and check for "!== 0" while reconnecting instead of "!== undefined".
@zhaoyao91 I would be open for a PR

if selected_db is not intended to be used by user, then how could I get the current connected db of this client? You know when subscribe the keyspace notifications the db index is an important part.

This information is part of the server_info property that is set as soon as the client is connected.
And as @jdegger said: it's safe to assume that the client connects to db0 by default.