AddSignalXYConst display glitch with DateTimeFormat = true

First: thanks for the amazing work so far! :-)
Since I use the project for the first time I do not exclude that I use it possibly wrong. I have noticed visual differences between AddSignalXY and AddSignalXYConst. After a temporal gap, the values before the gap are displayed resulting in a short spike. I use DateTimeFormat = true for the XAxis. Here are some pictures to see the visual better:

Here are in more Detail:

Sometimes disappears when zoomed in:

Data looks like this:
2021-02-09T09:12:43.12+01:00;105.44;105.02;
2021-02-09T09:12:58.08+01:00;105.0;104.82;
2021-02-09T09:12:58.09+01:00;104.98;104.84;
2021-02-09T09:13:00.75+01:00;105.0;104.84;
(Blue line is the second value)
Using: ScottPlot 4.1.6-beta
formsPlot.Plot.AddSignalXYConst(xDate.ToArray(), ci.Xetra.Select(x => (double)x.BestBidPrice).ToArray(), label: "Bid");
formsPlot.Plot.AddSignalXYConst(xDate.ToArray(), ci.Xetra.Select(x => (double)x.BestAskPrice).ToArray(), label: "Ask");
formsPlot.Plot.XAxis.DateTimeFormat(true);
formsPlot.Plot.Title($"Test");
formsPlot.Render();

Thanks!

Hi @AlgoExecutor,
Thanks for reporting. Can you provide test data to reproduce this bug?
I think ~10 points close to Detail area would be enouth.

@AlgoExecutor thank you very much.
You managed to find a very persistent bug that has existed for over a year.
I fix it in #788.

Wow, thank you very much for the fast fix! :)

Thanks @AlgoExecutor and @StendProg! I'm uploading the NuGet package now and it should be live in a few minutes 👍


Pushing same route to history

Hi,
How can I stop a route (url) from being pushed to the browser's history if it is the same as the current route. So that clicking twice on  won't add "/test" to the browser's history twice.
Thanks

Check location.pathname before pushing.

@taion You recommend to rewrite <Link/> component?

Where should I check for location.pathname ?


Lammps reader

This PR does two things:
a) throw an error when votca tries to construct a bond between atoms from different molecules.
b) at the moment unnamed molecules are named by their chemical composition, this can be problematic if we have isomers in the topology in that case an index is added at the end of the molecule.

@votca-bot format

@votca-bot changelog: reworked lammps molecule naming

This is more @JoshuaSBrown's cup of tea.

It is fully backwards compatible it just detects more errors than before.

Yes I will next week.

@votca-bot format


SDK-669 - environment file

I really hate this approach as I couldn't get the env file variable declaration to be simpler, and trying to load the file all at once in the constructor seemed to fail for some reason.
I'm raising this draft PR to see if anyone has any ideas about how this could be improved whilst still giving us an easy way to have env files for multiple backend environments. However, if we can think of a better way to approach it then I guess we should leave it as it currently is and scrap this PR.
With this approach, an env.local.json file can be added to the Resources folder, and then GITIGNORED (although I haven't added it to the GITIGNORE yet) and it will use those values instead of the default ones.

Closing this PR as I think we've decided to go with a simpler solution and leaving it open here is causing confusion - a new PR will one day come with the simpler solution 👍


[FIX] clarify example 3  in common principles (inheritance)

closes #190
@pvdemael I hope this clarifies what you wanted to address.

Thx, sorry for not being very responsive.


Higher accuracy than reported in the paper

Hi, thanks for the great work!
I was running the code for both supervised only diva (paper_experiments/rotated_mnist/supervised/experiment_only_sup_diva.py)
and supervised only vae "paper_experiments/rotated_mnist/supervised/experiment_only_sup_vae.py", and I set the test_domain to "0".  I noticed that the validation accuracy for both domain and y rose to 1.0 after several epochs. This is much higher than the test accuracy reported in the paper (~93%). Is there a reason for such a huge difference between the validation accuracy and the test accuracy? Thanks!

I realized that I misunderstood the validation accuracy. After taking a closer look the validation accuracies are on the same domain with the training set but the test set is on a new domain.


EditItem Method

Can I pass a row number into the EditItem Method?
Thanks.

Could you bring more details about what you would like to do and for what purpose?

I was hoping to enable using the arrow keys to switch the selected item. I was thinking I could get the current row I'd and add 1 when the down arrow is pressed or minus when when the up button is pressed.

I see the following solution:

add some special class to each row with rowClass (e.g. .grid-row)
add keyboard handlers as in the following answer: http://stackoverflow.com/questions/11088674/shift-focus-with-arrow-keys-in-javascript
on enter key press call editItem with document.activeElement

You can also add some styling for focused row: .grid-row:focus { background: skyblue; }


update(plugin): make with_last_error() lazy

Only get the error message from the framework if there was an actual error

What type of PR is this?

Uncomment one (or more) /kind <> lines:

/kind bug

/kind cleanup

/kind design

/kind documentation

/kind failing-test

/kind feature

Any specific area of the project related to this PR?

Uncomment one (or more) /area <> lines:

/area build

/area ci

/area event

/area event_derive

/area plugin

/area plugin_api

/area plugin_derive

/area plugin_tests

What this PR does / why we need it:
Don't call get_owner_last_error unless there's an actual failure.
Which issue(s) this PR fixes:

Fixes #
Special notes for your reviewer:
Does this PR introduce a user-facing change?:

NONE

LGTM label has been added.  Git tree hash: 3625cf767458898ffa8a12d8995d3b3b3ed51c63

[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: gnosek, mrgian
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

OWNERS [gnosek,mrgian]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment


chore: rename assert to test for markdown syntax

Summary:
Renames assert blocks to test blocks in snapshot test markdown.
Issue Reference(s):
Fixes #1399
Build & Testing:

[x] I ran cargo test successfully.
[x] I have run ./lint.sh --mode=fix to fix all linting issues raised by ./lint.sh --mode=check.

Checklist:

[] I have added relevant unit & integration tests.
[x] I have updated the documentation accordingly.
[x] I have performed a self-review of my code.
[x] PR follows the naming convention of <type>(<optional scope>): <title>

Need to fix the build. Some tests are failing, I think that's because there are some residual assert statements.

@timburrows Moving it to draft. Please mark it as ready to review once the build passes.

Thanks. Changes from upstream introduced more assert blocks. Workflows report that it requires approval before builds will trigger

This change would invalidate documentation found here https://github.com/tailcallhq/tailcallhq.github.io/blob/develop/docs/contributors/tests.mdx. Should another issue be raised for this?

@timburrows Documentation should be part of this fix.

@tusharmath see this PR for the aforementioned changes https://github.com/tailcallhq/tailcallhq.github.io/pull/208

@timburrows  Thanks for your great contribution to Tailcall! 🌟 Your expertise is invaluable. 🙌 We'd love to see you engage more with our community and continue to drive innovation. 👍


ci: add github superlinter workflow

add superlinter as default workflow following the documentation here: https://github.com/github/super-linter#how-to-use
run ci with default value for VALIDATE_ALL_CODEBASE (true), since already existing code has not been linted so far

Signed-off-by: Jan Klare<EMAIL_ADDRESS>

example output for a full pipeline with the current code can be found here: https://github.com/jklare/p4-upf/actions/runs/3417731852/jobs/5689203903


ro crate and bagit

This pull request adds the ro-crate metadata as well as bagit files.
Currently a metadata file is written for a file only if that file has metadata attached.
I think that the bagit stuff is implemented right, but could use some feedback on the ro-crate stuff.

I fixed one bug during testing with empty datasets - if you dont have any files, it would skip creating one of the manifest files and fail. After that, it all looked good.


Fix use of Kst matrix

This PR resolve issue #1022

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (be78025) 85.34% compared to head (f34b84d) 85.35%.

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.
Additional details and impacted files

@@           Coverage Diff           @@
##             main    #1028   +/-   ##
=======================================
  Coverage   85.34%   85.35%
=======================================
  Files          35       35
  Lines        7610     7614    +4
=======================================
+ Hits         6495     6499    +4
  Misses       1115     1115

Files
Coverage Δ

ross/disk_element.py
99.22% <100.00%> (+0.02%)
:arrow_up:

ross/rotor_assembly.py
93.25% <ø> (ø)

ross/shaft_element.py
89.20% <ø> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update be78025...f34b84d. Read the comment docs.

The Kdt matrix was also created for the disk element. However, this matrix is applied in time-dependent analyzes when there is speed variation. As the Kst matrix, it must be multiplied by the angular acceleration.


⚠ Samsung has degraded performance

In c991eed, Samsung (https://samsung.com) experienced degraded performance:

HTTP code: 200
Response time: 2440 ms

Resolved: Samsung performance has improved in 4e8de2d.


CUDA enabled version installation problem

error 5.txt
When I tried to do CMAKE_PREFIX_PATH=$CONDA_PREFIX make build_cuda flags="-DRPU_CUDA_ARCHITECTURES='86'", I got the error message in the error5.txt
Pytorch version: 2.0.1 torchvision 0.15.2
Package version: aihwkit 0.7.1
OS: Ubuntu 22.04.2 LTS (GNU/Linux <IP_ADDRESS>-microsoft-standard-WSL2 x86_64)
Python version: 3.8.17
NVIDIA GeForce RTX 3060 Laptop
Cuda compilation tools, release 11.5, V11.5.119

It looks like that it cannot find a properly installed torch. Can you try to open python and try 'import torch'?

(venv) (base) yuz422@LAPTOP-U0NG45HI:~/aihwkit$ python
Python 3.8.17 (default, Jun  6 2023, 20:10:50)
[GCC 11.3.0] on linux
Type "help", "copyright", "credits" or "license" for more information.

import torch
Traceback (most recent call last):
File "", line 1, in
ModuleNotFoundError: No module named 'torch'

It does not work. This is strange because I had already installed pytorch using conda install -c pytorch in miniconda. Could you please give me more suggestions?

You have venv and base activated. Not sure what you are doing there. Typically you have either venv or miniconda installed. You are apparently activating the venv where your python is stored but if you do conda install then it will store it under conda. You could use python -m pip install torch then it would install it under your current environment.   But it is not a good idea to have two pythons installed at the same time.


A way to switch LUA/LUAJIT from busted cli

Hey,
I'm new to LUAJIT and I found that busted cli have #!usr/bin/env lua so it will not use LUAJIT or a way to switch. Right now I'm doing the symbolic link lua->luajit but I feel it is wrong and not sure that's the right way to do it.
I think it will be nice if we can do something like this:
LUA=luajit busted spec.lua

So.... this is complicated.
Certain modules that are installable from luarocks and that are compiled for lua 5.1/2 do not work in luajit. You get these fun core dump errors when you try to load them. Errors around memory allocations and tracking.
This is compounded by system level differences with shell/bash scripts that caused us to remove this feature in the first place.
...In other words, you need to set up a separate luarocks environment that uses luajit instead of lua to get this to work properly. This can be accomplished in an automated way by using https://github.com/torch/torch7 which has a modified version of luarocks.

If you want more information, there is plenty in some of our other closed issues here.

It looks like the torch luarocks repo has moved. I think it's now at:
https://github.com/torch/luajit-rocks

BTW, there is a bug in luajit-rocks:
At generated site_config.lua site_config.LUAROCKS_EXTERNAL_DEPS_SUBDIRS and site_config.LUAROCKS_RUNTIME_EXTERNAL_DEPS_SUBDIRS are missing: (see https://github.com/daurnimator/lua-http/issues/39#issuecomment-248057342)

luajit /usr/bin/buster spec/*.lua ?


#342 Further additions to helm charts for egeria, ranger & other vdc …

…components
Signed-off-by: Nigel Jones<EMAIL_ADDRESS>

@planetf1 I notice it says : "This branch is out-of-date with the base branch". It looks like the branch is out of date

Yes the 'out of date' happens if a PR is here for any length of time and other changes happen in master (which may touch the same files). Clicking 'update branch' will work if can be automatically merged. Will try that now

@davidradl if you are happy with my comments and the updated branch, could you do a review-approval. Thanks


Changes to add ability to control recording, half-time starting scores, pass in team names etc. for tournament run

Also contains stuff @mrshu merged into the docker-tournament-run branch from (I think) master.

Fixes #74 and in combination with the rcj-soccer-sim-tournament-run repo also fixes #17

Before reviewing, I'll squash the commits and rebase on top of master so the diff shows the changes correctly.

@dbscoach FYI, I did some small changes to the python files.

@dbscoach FYI, I did some small changes to the python files.

Thank you very much. I guess I'll go break more things then ;)

@mrshu @Adman I have updated to now record optionally record mp4 or x3d formats, controlled via environment variable REC_FORMAT and this apparently immediately shows up in this PR, but I didn't want to create a branch of a branch.

@mrshu I made some changes to create video assistants based on the format provided. Could you please check my changes?
@dbscoach If you find some time, could you please test if it's working?
Thanks!

@Adman It is working, only thing it was complaining about is suffixes having to start with a period (so I changed them to .html and .mp4 from html and mp4).

@aquahika Since we have been touching Video recorder assistant, would you have a time to check it please?

Now that we have published should we merge this branch into master so that teams trying to run our simulator get code that will run by default?

@dbscoach Yeah, let's merge it.


Not connecting to Pretendo

When connecting to Pretendo (IP <IP_ADDRESS>, port 60003), it gives this error during login:
RuntimeError: RMC connection is closed

Could you post the access key and NEX version of that server? I would need a bit more information to debug this.

I don't know it, how would I find that out?  I didn't see it in the packet dumps...

The Pretendo server sends a DISCONNECT packet after NintendoClients sends the log in request:
DEBUG:nintendo.nex.rmc:Connecting RMC client to <IP_ADDRESS>:60003:1
DEBUG:nintendo.nex.prudp:Connecting PRUDP transport to <IP_ADDRESS>:60003
DEBUG:anynet.udp:Connecting UDP client to <IP_ADDRESS>:60003
DEBUG:nintendo.nex.prudp:[CLI] Sending packet: <PRUDPPacket type=TYPE_SYN flags=NEED_ACK seq=0 frag=0>
DEBUG:nintendo.nex.prudp:[CLI] Received packet: <PRUDPPacket type=TYPE_SYN flags=ACK,HAS_SIZE seq=0 frag=0>
DEBUG:nintendo.nex.prudp:[CLI] Sending packet: <PRUDPPacket type=TYPE_CONNECT flags=NEED_ACK,RELIABLE,HAS_SIZE seq=1 frag=0>
DEBUG:nintendo.nex.prudp:[CLI] Received packet: <PRUDPPacket type=TYPE_CONNECT flags=ACK,HAS_SIZE seq=1 frag=0>
INFO:nintendo.nex.authentication:AuthenticationClient.login()
DEBUG:nintendo.nex.prudp:[CLI] Sending packet: <PRUDPPacket type=TYPE_DATA flags=NEED_ACK,RELIABLE,HAS_SIZE seq=2 frag=0>
DEBUG:nintendo.nex.prudp:[CLI] Received packet: <PRUDPPacket type=TYPE_DATA flags=MULTI_ACK,HAS_SIZE seq=0 frag=0>
DEBUG:nintendo.nex.prudp:[CLI] Received packet: <PRUDPPacket type=TYPE_DISCONNECT flags= seq=0 frag=0>

Maybe @jonbarrow knows why this happens.

The Pretendo server sends a DISCONNECT packet after NintendoClients sends the log in request:
DEBUG:nintendo.nex.rmc:Connecting RMC client to <IP_ADDRESS>:60003:1
DEBUG:nintendo.nex.prudp:Connecting PRUDP transport to <IP_ADDRESS>:60003
DEBUG:anynet.udp:Connecting UDP client to <IP_ADDRESS>:60003
DEBUG:nintendo.nex.prudp:[CLI] Sending packet: <PRUDPPacket type=TYPE_SYN flags=NEED_ACK seq=0 frag=0>
DEBUG:nintendo.nex.prudp:[CLI] Received packet: <PRUDPPacket type=TYPE_SYN flags=ACK,HAS_SIZE seq=0 frag=0>
DEBUG:nintendo.nex.prudp:[CLI] Sending packet: <PRUDPPacket type=TYPE_CONNECT flags=NEED_ACK,RELIABLE,HAS_SIZE seq=1 frag=0>
DEBUG:nintendo.nex.prudp:[CLI] Received packet: <PRUDPPacket type=TYPE_CONNECT flags=ACK,HAS_SIZE seq=1 frag=0>
INFO:nintendo.nex.authentication:AuthenticationClient.login()
DEBUG:nintendo.nex.prudp:[CLI] Sending packet: <PRUDPPacket type=TYPE_DATA flags=NEED_ACK,RELIABLE,HAS_SIZE seq=2 frag=0>
DEBUG:nintendo.nex.prudp:[CLI] Received packet: <PRUDPPacket type=TYPE_DATA flags=MULTI_ACK,HAS_SIZE seq=0 frag=0>
DEBUG:nintendo.nex.prudp:[CLI] Received packet: <PRUDPPacket type=TYPE_DISCONNECT flags= seq=0 frag=0>

Maybe @jonbarrow knows why this happens.

I'll have to take a deeper look into this. We just recently did a large overhaul of our libraries, which may have introduced this regression, but just taking a quick glance the only time we send a DISCONNECT packet is as an ACK to the one the client sends?
The Super Mario Maker server is running on an older version of the libraries, however, so I'll see what I can dig up in some older commits

I'm gonna CC @DaniElectra as well on this as he was the one doing the overhaul with me

This is interesting:
https://github.com/PabloMK7/nex-go/blob/9d6e91cbde41c1eba5411cc208534971dd1b2603/server.go#L206-216
		// * PID should always be 0 when a fresh connection is made
		if client.PID() != 0 {
			// * Was connected before on the same device, using a different account
			server.Emit("Disconnect", packet) // * Disconnect the old connection
		}
		err := client.Reset()
		if err != nil {
			// TODO - Should this return the error too?
			logger.Error(err.Error())
			return nil
		}

This is interesting<EMAIL_ADDRESS>		// * PID should always be 0 when a fresh connection is made
		if client.PID() != 0 {
			// * Was connected before on the same device, using a different account
			server.Emit("Disconnect", packet) // * Disconnect the old connection
		}
		err := client.Reset()
		if err != nil {
			// TODO - Should this return the error too?
			logger.Error(err.Error())
			return nil
		}

The repository you're looking at is a fork of ours. It may not be representative of what our upstream repository looks like. These specific lines do exist in older commits, but you shouldn't use forks as a reference for how our production servers would operate. You should be looking upstream. https://github.com/PretendoNetwork/nex-go
Also this fork is extremely outdated
On top of that, these lines are irrelevant to the actual issue at hand. The Emit function simply sends out an event to any listeners of the event type. It doesn't do anything beyond sending that signal. How the event is handled is an implementation detail of the listener

The repository you're looking at is a fork of ours. It may not be representative of what our upstream repository looks like. These specific lines do exist in older commits, but you shouldn't use forks as a reference for how our production servers would operate. You should be looking upstream.

Got it, I'm not sure why I was looking at that fork

It looks like the server is timing out the connection, since the the DISCONNECT pacekt doesn't have FLAG_RELIABLE set. Not sure why it would be happening on a first glance though
BTW probably unrelated to the original issue, but we enforce the usage of LoginEx on the auth servers, with the only exception being the friends server for now

I tested it with Login before, but the same thing happens if I use LoginEx:
DEBUG:nintendo.nex.rmc:Connecting RMC client to <IP_ADDRESS>:60003:1
DEBUG:nintendo.nex.prudp:Connecting PRUDP transport to <IP_ADDRESS>:60003
DEBUG:anynet.udp:Connecting UDP client to <IP_ADDRESS>:60003
DEBUG:nintendo.nex.prudp:[CLI] Sending packet: <PRUDPPacket type=TYPE_SYN flags=NEED_ACK seq=0 frag=0>
DEBUG:nintendo.nex.prudp:[CLI] Received packet: <PRUDPPacket type=TYPE_SYN flags=ACK,HAS_SIZE seq=0 frag=0>
DEBUG:nintendo.nex.prudp:[CLI] Sending packet: <PRUDPPacket type=TYPE_CONNECT flags=NEED_ACK,RELIABLE,HAS_SIZE seq=1 frag=0>
DEBUG:nintendo.nex.prudp:[CLI] Received packet: <PRUDPPacket type=TYPE_CONNECT flags=ACK,HAS_SIZE seq=1 frag=0>
INFO:nintendo.nex.authentication:AuthenticationClient.login_ex()
DEBUG:nintendo.nex.prudp:[CLI] Sending packet: <PRUDPPacket type=TYPE_DATA flags=NEED_ACK,RELIABLE,HAS_SIZE seq=2 frag=0>
DEBUG:nintendo.nex.prudp:[CLI] Received packet: <PRUDPPacket type=TYPE_DATA flags=MULTI_ACK,HAS_SIZE seq=0 frag=0>
DEBUG:nintendo.nex.prudp:[CLI] Received packet: <PRUDPPacket type=TYPE_DISCONNECT flags= seq=0 frag=0>

Here is the script that generates these logs with LoginEx:
from nintendo.nex import backend, settings, authentication
import anyio

import logging
logging.basicConfig(level=logging.DEBUG)

async def main():
    s = settings.default()
    s.configure("9f2b4678", 30803)
    auth_info = authentication.AuthenticationInfo()
    auth_info.token = "test"
    async with backend.connect(s, "<IP_ADDRESS>", 60003) as be:
        async with be.login("test", "test", auth_info):
            print(be)

anyio.run(main)

Is this a bug with Super Mario Maker or the other games as well?

I did some tests on my side and I have found the issue. You were trying to connect to the secure server directly, not the authentication server. The auth server is located on port 60002, not 60003. After changing that, everything works on my side

@DaniElectra Thank you so much, it finally seems to be working!  But I'm not sure how to dump my Pretendo NEX credentials on a 3DS - the server rejects the normal credentials obtained via get_3ds_pid_password, so I assume it's dumping from prod, not test

That's probably pretty likely tbh. @DaniElectra maybe Nimbus could be updated to dump this?

I was able to manually extract partitionA.bin from nandctr:/data/<id0>/sysdata/00010032/00000000, then at offset 0x10000 I found an account struct that had the test NASC environment.
After manually extracting it and decoding as UTF-16, I got the same password as get_3ds_pid_password, but with an extra character.  The username was completely different, and it turns out the script was reading from the prod account, and wasn't reading the HMAC.  So that means that for some reason, FRD_GetMyFriendKey was reading from prod, but FRD_GetMyPassword was correctly redirected to test.  Also, it wasn't reading from the HMAC, but from PrincipalID itself.
So I entered these credentials into the SMM archival script, but it still fails to authenticate (Authentication::ValidationFailed (0x80680007)).  I have no idea why.  I tried every combination of entering my username as the PrincipalID and its HMAC, the password with and without the extra character, encoding the HMAC as decimal, but nothing works.
What is going on here?  Why won't the Pretendo server accept my credentials?

Actually, the PID from my packet captures is also from prod.  It seems that the Pretendo sysmodule patches use the prod PID (aka the NNID), which I assume is a bug

From my experience, get_3ds_pid_password seems to work fine for getting both nintendo, and pretendo keys

@Preloading That's weird.  It seems to be getting the right credentials, but the server just keeps sending Authentication::ValidationFailed (0x80680007)

Are you passing the AuthenticationInfo to the login function? As I have said, our servers require LoginEx on all servers (except for the friends server, since the console uses Login instead)

@DaniElectra This seems to be working!  I'm getting another error, but I can't tell if that's because I passed an invalid token, as the value doesn't seem to matter.  What's the correct value for it?  The docs just name it...

As the error says, that RMC method is not implemented on the server
Unlike Nintendo's servers ours only implement what the games are known to use for simplicity

What did you implement?  How does SMM search?

Okay, this is strange, I'm sending custom_search_object (0x2f), and it's still returning nintendo.nex.common.RMCError: Core::NotImplemented (0x80010002) regardless of this being defined in the source code.  What's going on?

I found PretendoNetwork/nex-viewer/src/protocols/patches/datastore_smm.js, and this seems to contain the information I need

No, it doesn't. This is a viewer, as indicated both in the repository name (nex-viewer) and in the README of the repository:

Utility for parsing and (eventually) viewing NEX connections from PCAP(NG) network dumps

This has nothing to do with what is and isn't implemented on our servers, and a lot of what is implemented in the viewer was made with codegen

Can there just be some way to download an archive of the Pretendo SMM courses?

As stated you can only use the methods available on a per-server basis. Methods only get implemented in game servers if they're seen in use in the game, in order to simplify game server setups. Currently the methods you're trying to use are not implemented. So, no. At the moment there isn't

I'm trying to allow searching and downloading with only the 3DS version of SMM, and the only method I can think of is to scrape them like this

You're making 3DS game patches that can use Python scripts? It sounds like it would be easier to just patch the game itself than do this

Also, does the token actually matter?

Not all of our servers validate the token atm because we are changing how we handle token generation fairly quickly

Okay, this is strange, I'm sending custom_search_object (0x2f), and it's still returning nintendo.nex.common.RMCError: Core::NotImplemented (0x80010002) regardless of this being defined in the source code. What's going on?

No, it's not strange. Again. Only RMC methods fully implemented on our servers can be used. If you're getting Core::NotImplemented it means the server just simply doesn't support that method. That's the only time it ever returns that error
Please actually check what is and isn't implemented, you can find our Super Mario Maker specific methods in the Super Mario Maker server, and for common DataStore methods those are implemented in our common implementations library. Be aware that just because a method is implemented in the common library does not mean a game server uses it. If the game server is not configured to use those methods (by not providing the fields/helpers the method needs) then it is considered not implemented. In the case of DataStore::SearchObject that method relies on the GetObjectInfosByDataStoreSearchParam helper, which our Super Mario Maker server does not currently provide

This has nothing to do with what is and isn't implemented on our servers, and a lot of what is implemented in the viewer was made with codegen

Got it, I misunderstood that file then.  Which method is used by the Wii U when it just normally searches for files?  If you don't know, how can I figure this out myself without a Wii U?

As stated you can only use the methods available on a per-server basis. Methods only get implemented in game servers if they're seen in use in the game, in order to simplify game server setups. Currently the methods you're trying to use are not implemented. So, no. At the moment there isn't

Could you consider just putting a .zip with the uploaded Pretendo courses somewhere?  Although there's probably some reason I'm not thinking of that means it wouldn't be that easy...

You're making 3DS game patches that can use Python scripts? It sounds like it would be easier to just patch the game itself than do this

I'm making a Python script that can search and download from Pretendo's servers, then edit the ExtData to inject those courses.  It can currently convert a local Wii U save file, so I'm hoping I can just download something similar from Pretendo.  But since I don't own a Wii U, just a 3DS, it's been extremely difficult

Which method is used by the Wii U when it just normally searches for files?

This depends on the game and it's implementation. It's not a Wii U vs 3DS thing. I don't remember off the top of my head which method Super Mario Maker uses specifically, there's several of them and that game even implements custom search methods

Could you consider just allowing you to download a .zip with the uploaded Pretendo courses somewhere (maybe an HTTP endpoint)? Although there's probably some reason I'm not thinking of that would make this difficult...

That's not something we're likely going to be interested in any time soon. The server doesn't have the concept of a "course". It only knows about "objects", and sometimes those don't even have real files associated with them. Games just upload and download objects from the server, and handles them however they need to. As far as the server is concerned they're all pretty much the same thing, stored exactly the same way regardless of object type (more than just courses are objects here)
It's not as simple as just "put the courses in a zip". The server would need to process the data of every object in the database, determine if it is or isn't a course (which is not always so clear), collect it's metadata, pack it into something usable, and then add both the metadata and object data to the zip. This will take a good amount of time, not to mention likely provide you with a fairly large download. Our archive of Nintendo's data was over 500GB. While we aren't anywhere near that right now, it's not like this would be tiny. A rough estimate based on our current data would be ~200MB of just object data, which while not massive is large enough for us to think about sending over the network. And that doesn't include any of the object metadata. This will only keep growing larger and larger as time goes on


Provider namecheap/namecheap

Provider Repository
namecheap/terraform-provider-namecheap
DCO

[X] I sign this project's DCO

Well, looks it came back eventually, but:
Initializing the backend...

Initializing provider plugins...
- Finding namecheap/namecheap versions matching "2.1.2"...
╷
│ Error: Failed to install provider
│
│ Error while installing namecheap/namecheap v2.1.2: could not query provider
│ registry for registry.opentofu.org/namecheap/namecheap: the request failed
│ after 2 attempts, please try again later: Get
│ "https://registry.opentofu.org/v1/providers/namecheap/namecheap/2.1.2/download/darwin/arm64":
│ net/http: request canceled (Client.Timeout exceeded while awaiting headers)
╵

INFO[0084] Encountered an error eligible for retrying. Sleeping 5s before retrying.  prefix=[/Users/lukecarrier/Code/LukeCarrier/infrastructure/terragrunt/registrar-family-carrier]
ERRO[0089] 1 error occurred:
        * Exhausted retries (3) for command tofu init

ERRO[0089] Unable to determine underlying exit code, so Terragrunt will exit with error code 1

Didn't manage to get a TF_LOG=debug run before it recovered :(

Yep, it seems so! Thanks for taking a look 🙂


fixed argument configureOpts to return git credentials to gitFactory

Signed-off-by: Kiran Satya Raj<EMAIL_ADDRESS>fixes jenkins-x/jx#8421

/assign @ankitm123

/ok-to-test

@msvticket there are a few test cases failing when I ran make lint
Error:
-//nolint +// nolint  func (p *inliner) processTaskSpec(ts *v1beta1.TaskSpec, path, name string) (bool, error) {  	templateImage := ""  	if ts.StepTemplate != nil { make: *** [Makefile:170: lint] Error 1

This is the output of the linter:
cmd/docs/main.go:7: File is not `gofmt`-ed with `-s` (gofmt)
//     http://www.apache.org/licenses/LICENSE-2.0
cmd/docs/md_docs.go:7: File is not `gofmt`-ed with `-s` (gofmt)
//     http://www.apache.org/licenses/LICENSE-2.0
pkg/cmd/effective/effective.go:4:2: SA1019: "io/ioutil" has been deprecated since Go 1.16: As of Go 1.16, the same functionality is now provided by package io or package os, and those implementations should be preferred in new code. See the specific function documentation for details. (staticcheck)
	"io/ioutil"
	^

hey @msvticket, make lint gave me an output to install golangci-lint v1.46.2 just that, I currently have v1.50.1, so should it be update then

hey @msvticket can we discuss this if you're available?

hey @msvticket, make lint gave me an output to install golangci-lint v1.46.2 just that, I currently have v1.50.1, so should it be update then

I suspect that if you have a newer lint you will find more problems. But what you have to fix are the issues that the lint pipeline finds

hey @msvticket, make lint gave me an output to install golangci-lint v1.46.2 just that, I currently have v1.50.1, so should it be update then

I suspect that if you have a newer lint you will find more problems. But what you have to fix are the issues that the lint pipeline finds

I've installed the 1.46.2 version of golangci-lint(current version for jx-pipilne), I got a few warns on bodyclose, rowserrcheck, structcheck, unparam are disabled because of go1.18 and an error
pkg/cmd/effective/effective.go:4:2: SA1019: package io/ioutil is deprecated: As of Go 1.16, the same functionality is now provided by package io or package os, and those implementations should be preferred in new code. See the specific function documentation for details. (staticcheck) 	"io/ioutil"
so all the functions from io/ioutil should be replaced by equivalent functions from io or os packages, right?

@KiranSatyaRaj Why don't you just fix the lint issues in https://github.com/jenkins-x-plugins/jx-pipeline/pull/509#issuecomment-1339730987 ?

hey @msvticket, can you please let me know the command you used to perform lint because I get an output different from #509 (comment)  when I execute make lint


Support zod nativeEnum field (or allow free text entry)

Hi great library!
Would be great if it supported the zod nativeEnum field alongside the currently supported the enum field. Alternativly as a work around it could put a plain text field to allow for manual data entry. The current implementation just hides the field and makes the mutation unsubmitable through trpc-panel.
Example:
enum Fruits {
  Apple,
  Banana,
}

....publicProcedure.input(z.object({id: z.string.uuid(), fruit: z.nativeEnum(Fruits)}).mutation(.......

will show the id field but hide the fruit field.

same issue here

Anyway to get this fixed? It’s causing a lot of trouble:(

Would love this to be fixed


Restructure for Jenkins CI; add missing validation

test this please

test this please

test this please

test this please

/lgtm


Sending additional parameters to Facebook

My application requires that the user allows email permission so I would like to show an error and a button to rerequest permissions through Facebook which is usually achievable using auth_type=rerequest however I am unable to find the proper way to add this parameter with Ally.
I found that this code adds the parameter to the url but Facebook just throws an error as soon as I add it so it can't be the right way to do it.
const driver = request.ally.driver('facebook')

driver._driverInstance._redirectUriOptions.auth_type = 'rerequest'

yield driver.redirect()

{
   "error": {
      "message": "",
      "type": "OAuthException",
      "code": 100,
      "fbtrace_id": "CpcKgSUPq8L"
   }
}

Any help is much appreciated!

There Is a method called getRedirectUrl, can you share the output of it

@thetutlage getRedirectUrl returns https://graph.facebook.com/v2.1/oauth/authorize?redirect_uri=RETURN_URL&scope=email&response_type=code&client_id=CLIENT_ID
If I add in the line to add the auth_type parameter it gives me https://graph.facebook.com/v2.1/oauth/authorize?redirect_uri=RETURN_URL&scope=email&response_type=code&auth_type=rerequest&client_id=CLIENT_ID

@thetutlage Have you been able to take a look into this?


[Youtube] cannot read "Releases" tab

DO NOT REMOVE OR SKIP THE ISSUE TEMPLATE

[X] I understand that I will be blocked if I intentionally remove or skip any mandatory* field

Checklist

[X] I'm reporting that a supported site is broken
[X] I've verified that I'm running yt-dlp version 2023.03.04 (update instructions) or later (specify commit)
[X] I've checked that all provided URLs are playable in a browser with the same IP and same login details
[X] I've checked that all URLs and arguments with special characters are properly quoted or escaped
[X] I've searched known issues and the bugtracker for similar issues including closed ones. DO NOT post duplicates
[X] I've read the guidelines for opening an issue
[ ] I've read about sharing account credentials and I'm willing to share it if required

Region
United Kingdom
Provide a description that is worded well enough to be understood
Issue:
yt-dlp cannot read the (possibly new to Youtube) Releases tab for music artists.
Example: https://www.youtube.com/@daftpunk/releases has a page with a few dozen playlists, but nothing is downloaded when providing that URL to yt-dlp.
I have tried investigating by modifying the python code and found the following cause and solution:
Cause:

Adding a breakpoint() to YoutubeTabBaseInfoExtractor's _extract_entries() shows that each of the contents of the Releases tab is a richItemRenderer containing some amount of playlists.
This causes us to run _rich_entries() on that renderer, which specifically looks for videos and only videos, missing the playlists.

Proposed solution:
Update YoutubeTabBaseInfoExtractor._rich_entries() to attempt to extract playlists (using the playlist code from YoutubeTabBaseInfoExtractor._grid_entries()).
I tried making this change locally, and it seemed to work. This is the new function:
    def _rich_entries(self, rich_grid_renderer):
        # video
        renderer = traverse_obj(rich_grid_renderer, ('content', ('videoRenderer', 'reelItemRenderer')), get_all=False) or {}
        video_id = renderer.get('videoId')
        if video_id:
            yield self._extract_video(renderer)
        # playlist
        renderer = traverse_obj(rich_grid_renderer, ('content', ('playlistRenderer')), get_all=False) or {}
        title = self._get_text(renderer, 'title')
        playlist_id = renderer.get('playlistId')
        if playlist_id:
            yield self.url_result(
                'https://www.youtube.com/playlist?list=%s' % playlist_id,
                ie=YoutubeTabIE.ie_key(), video_id=playlist_id,
                video_title=title)

This is the output from before the change:
(venv) PS G:\Documents\Projects\_own\yt-dlq> python -c "import yt_dlp; yt_dlp.YoutubeDL({'extract_flat': True}).extract_info('https://www.youtube.com/@daftpunk/releases')"
[youtube:tab] Extracting URL: https://www.youtube.com/@daftpunk/releases
[youtube:tab] @daftpunk/releases: Downloading webpage
[download] Downloading playlist: Daft Punk - Releases
[youtube:tab] UC_kRDKYrUlrbtrSiyu5Tflg page 1: Downloading API JSON
[youtube:tab] Playlist Daft Punk - Releases: Downloading 0 items of 0
[download] Finished downloading playlist: Daft Punk - Releases

And this is the output from after:
(venv) PS G:\Documents\Projects\_own\yt-dlq> python -c "import yt_dlp; yt_dlp.YoutubeDL({'extract_flat': True}).extract_info('https://www.youtube.com/@daftpunk/releases')"
[youtube:tab] Extracting URL: https://www.youtube.com/@daftpunk/releases
[youtube:tab] @daftpunk/releases: Downloading webpage
[download] Downloading playlist: Daft Punk - Releases
[youtube:tab] UC_kRDKYrUlrbtrSiyu5Tflg page 1: Downloading API JSON
[youtube:tab] Playlist Daft Punk - Releases: Downloading 36 items of 36
[download] Downloading item 1 of 36
[download] Downloading item 2 of 36
<this repeats for items 3 through 35>
[download] Downloading item 36 of 36
[download] Finished downloading playlist: Daft Punk - Releases

Provide verbose output that clearly demonstrates the problem

[X] Run your yt-dlp command with -vU flag added (yt-dlp -vU <your command line>)
[ ] If using API, add 'verbose': True to YoutubeDL params instead
[X] Copy the WHOLE output (starting with [debug] Command-line config) and insert it below

Complete Verbose Output
(venv) PS G:\Documents\Projects\_own\yt-dlq> yt-dlp https://www.youtube.com/@daftpunk/releases -vU
[debug] Command-line config: ['https://www.youtube.com/@daftpunk/releases', '-vU']
[debug] Encodings: locale cp1252, fs utf-8, pref cp1252, out utf-8, error utf-8, screen utf-8
[debug] yt-dlp version<EMAIL_ADDRESS>[392389b7d] (pip)
[debug] Python 3.10.5 (CPython AMD64 64bit) - Windows-10-10.0.19044-SP0 (OpenSSL 1.1.1n  15 Mar 2022)
[debug] exe versions: none
[debug] Optional libraries: Cryptodome-3.17, brotli-1.0.9, certifi-2022.12.07, mutagen-1.46.0, sqlite3-2.6.0, websockets-11.0.2
[debug] Proxy map: {}
[debug] Loaded 1786 extractors
[debug] Fetching release info: https://api.github.com/repos/yt-dlp/yt-dlp/releases/latest
Available version<EMAIL_ADDRESS>Current version<EMAIL_ADDRESS>yt-dlp is up to date<EMAIL_ADDRESS>
[youtube:tab] Extracting URL: https://www.youtube.com/@daftpunk/releases
[youtube:tab] @daftpunk/releases: Downloading webpage
[debug] [youtube:tab] Selected tab: 'releases' (releases), Requested tab: 'releases'
[download] Downloading playlist: Daft Punk - Releases
[youtube:tab] UC_kRDKYrUlrbtrSiyu5Tflg page 1: Downloading API JSON
[youtube:tab] Playlist Daft Punk - Releases: Downloading 0 items of 0
[download] Finished downloading playlist: Daft Punk - Releases

Similar code, in the YoutubeTabIE._rich_grid_entries() method, to that proposed here gets the Daft releases playlist in yt-dl.


Add 30M gas limit to sudo helper

Closes: #7526
What is the purpose of the change
This PR adds a 30M gas limit to sudo calls that use our helper. This can be tightened in the future by requiring callers to specify a gas limit, but in the meantime should serve as an upperbound to minimize the attack surface from unbounded CW contract calls.
Testing and Verifying
Existing tests related to sudo calls pass, and the implementation uses the same gas limit as Cosmwasm has for queries.
No direct tests for this, as it seems all our CW helpers are not directly tested and setting this up will be a meaningful lift. Happy to table this PR until we complete this if people are concerned. Documented this here: #7528
Documentation and Release Note

[ ] Does this pull request introduce a new feature or user-facing behavior changes?
[ ] Changelog entry added to Unreleased section of CHANGELOG.md?

Where is the change documented?

[ ] Specification (x/{module}/README.md)
[ ] Osmosis documentation site
[ ] Code comments?
[ ] N/A

I don't think this is complete. If the child thing out of gas's, you get a panic, no? This definitely needs tests to ensure we got the flow right

I think the panic gets caught by the top level defer: https://github.com/osmosis-labs/cosmos-sdk/blob/osmo/v0.47.5/baseapp/baseapp.go#L639-L647

Thats not true for beginblock/endblock code!
And more importantly, CW contracts may appear in things that assume a contract they won't panic. (In swaps, we do catch all panics though)

ahh, I keep forgetting we're calling this in beginblock/endblock. Yeah, prob good to have the same defer here


Water Sensors: OZT

This WI site went down completely 07/19/2022. There was fairly poor satellite signal recorded the last transmissions. Can we find out if this site is printing from Ashley? Does she need to reset it?
Note: This is one of the sites that had issues early in the season with sending data to the dashboard.

This site went back down 07/27/2022. Do we know why this is recourring?

Status update?


mypy: Check types of more packages

Description

Upgrade granulate-utils to a commit containing https://github.com/Granulate/granulate-utils/pull/19, which now makes it typed.
Fix type errors stemming from this ^^
Enable type checking on multiple other packages, and add a comment on all packages left that are still ignored.

How Has This Been Tested?
CI

Many failures like:
E       AssertionError: unexpected 'grep' exit code: 127, stdout b'' stderr b"Inconsistency detected by ld.so: dl-open.c: 560: dl_open_worker: Assertion `_dl_debug_initialize (0, args->nsid)->r_state == RT_CONSISTENT' failed!\n"

wtf.
 I deem it is unrelated.

CI failures are unrelated. (same code passed at 17171ca)


Correct variable used in pickle dump in mind_utils.ipynb

Description

Fixed a minor mistake where the incorrect variable word_dict was being dumped to word_dict_all.pkl instead of word_dict_all in the mind_utils.ipynb notebook.
Related Issues

References

Checklist:

[x] I have followed the contribution guidelines and code style for this project.

Thanks @ubergonmx I have moved the PR to staging instead of main.


toggleSeries + tooltip

Hi!
If I have multiple series I see tooltip and points on lines for each one.

If I toggle one of them, than each line is treated separately in tooltip. Is it normal? Can I change this?

The tooltip will display only 1 series when any of the series in series array has a different x-axis than the rest.
If you look at this example - https://apexcharts.com/javascript-chart-demos/area-charts/stacked/ the tooltip displays correctly even after toggling through legend.
If your x-axis is the same for all series, I would suggest you create a codepen demo so I can take a look.

Did you mean y-axis? I have different ones. Thank you for your response.

Hi again!
Because I'm creating my chart in Vue projects I thought that would be better to describe it in vue-appexcharts repository: https://github.com/apexcharts/vue-apexcharts/issues/91
There is a CodePen demo too.


MDA Custom Plugins

Two plugins that use the CloudAppEvents table to provide insights about user activity and files detected by ATP.

@alfonso-greenbrook provide sample prompts to use with this Custom plugin showcasing the different skills

@KwachSean Have added example prompts to both readme.md and .yaml files.


⚠ Samsung has degraded performance

In 6ee6ac4, Samsung (https://samsung.com) experienced degraded performance:

HTTP code: 200
Response time: 2000 ms

Resolved: Samsung performance has improved in 85923d1.


Message not consumed from command line when produced from Sarama Client

Hi,
When I produce messages from Go code and consume it from Go code aswell, it works fine.
But when I try to consume the message from command line:
bin/kafka-console-consumer.sh --bootstrap-server localhost:9092 --topic testTopic --from-beginning
Nothing received ! Noting that when I try this, I disable first consuming from Go code.
Message is produced using this code:

producer := createProducer()
stringtest := "test"

producer.Input() <- &sarama.ProducerMessage{
	Topic: "testTopic",
	Value: sarama.StringEncoder(stringtest),
}

func createProducer() sarama.AsyncProducer {
	config := sarama.NewConfig()
	config.Producer.Return.Successes = false
	config.Producer.Return.Errors = true
	config.Producer.RequiredAcks = sarama.WaitForAll
	producer, err := sarama.NewAsyncProducer([]string{"<IP_ADDRESS>:9092"}, config)
	if err != nil {
		log.Fatal("Unable to connect producer to kafka server")
	}
	return producer
}

What is the problem please ? What I did wrong ?
Thank you in advance.

You have created an asynProducer.
The application is closing before the producer has time to produce the message.
Call producer.Close() just before the application end will solve this problem.

@FrancoisPoinsot Thank you for your answer.
The application is not closing at all since I am using loop to consume messages and in the same time depend on the command received, I produce the messages.
I can't see where I can put producer.Close() since I am using LOOP to listen to a new messages ?
Is there a way to flush messages without closing the producer ? Since it is actively used ?

Ha, I assumed the upper part of the code was the main func.
I don't think there is a way to flush an async producer without closing it.
But also there should not be a need for that.
The asyncProducer should flush regularly. The default behavior is "flush as-fast-as-possible".
Without more detail on your code or your setup, I cannot help.
Meanwhile here is what I ran locally. It did succesfully produced and read messages, so maybe you will be able to spot a difference.
in console
docker run -d -p 2181:2181 -p 3030:3030 -p 8081-8083:8081-8083 \
           -p 9581-9585:9581-9585 -p 9092:9092 -e ADV_HOST=localhost \
           -e RUNNING_SAMPLEDATA=0 landoop/fast-data-dev

the code
package main

import (
	"github.com/Shopify/sarama"
	"log"
	"time"
)

func main() {
	for {
		producer := createProducer()
		stringtest := "test"

		producer.Input() <- &sarama.ProducerMessage{
			Topic: "testTopic",
			Value: sarama.StringEncoder(stringtest),
		}
		time.Sleep(1 * time.Second)
	}
}

func createProducer() sarama.AsyncProducer {
	config := sarama.NewConfig()
	config.Producer.Return.Successes = false
	config.Producer.Return.Errors = true
	config.Producer.RequiredAcks = sarama.WaitForAll
	producer, err := sarama.NewAsyncProducer([]string{"<IP_ADDRESS>:9092"}, config)
	if err != nil {
		log.Fatal("Unable to connect producer to kafka server")
	}
	return producer
}

the consumer
kafka-console-consumer --bootstrap-server <IP_ADDRESS>:9092 --topic testTopic --from-beginning

This is not working on my case ... I used to switch to rdkafka.
Thanks for your help sir :)


Error in seg_liver.py

I'm getting errors in your work in this file  seg_liver.py, line 552      print ("Model saved in file: %s") % save_path
TypeError: unsupported operand type(s) for %: 'NonType' and 'str'
I'm using Python 3.6  It was working fine but at the time of saving path it shows this error. How to recover it?

I checked online, and if you do the following change it will work.
Regards,
Míriam


Improve ContextTask documentation

More details in class description
Fixes #208

Can you confirm this? That these remarks for ContextTask's BlockReadSize might more aptly belong to StartAcquisition's ReadSize (which already has a decent description actually).
https://github.com/open-ephys/onix-bonsai-onix1/blob/6c67f9b0072721a8d0c66384432416fe155149bf/OpenEphys.Onix1/ContextTask.cs#L409-L416

I decided to keep reading on the ContextTask page.  For instance, it might be worth mentioning that BlockReadSize and BlockWriteSize are set by ReadSize and WriteSize properties in StartAcqusition.

Can you confirm this? That these remarks for ContextTask's BlockReadSize might more aptly belong to StartAcquisition's ReadSize (which already has a decent description actually).
https://github.com/open-ephys/onix-bonsai-onix1/blob/6c67f9b0072721a8d0c66384432416fe155149bf/OpenEphys.Onix1/ContextTask.cs#L409-L416

Good find. It turns out that if we do the following:
/// <summary>
/// Gets the number of bytes read per cycle of the <see cref="ContextTask"/>'s acquisition
/// thread.
/// </summary>
/// <inheritdoc cref = "StartAcquisition.ReadSize"/>
public int BlockReadSize => ctx.BlockReadSize;

then we override the summary (since this property only has a getter) but we import the remarks from StartAcquisition.ReadSize. Very useful.


 Can you help me see what's going on?

Here's my configuration.
return {
  "willothy/nvim-cokeline",
  dependencies = {
    "nvim-lua/plenary.nvim",
    "kyazdani42/nvim-web-devicons",
  },
  config = true
}

Thanks for reporting! I'll look into this today.

What version of Neovim are you using?

NVIM v0.9.2
Build type: Release
LuaJIT 2.1.0-beta3

   system vimrc file: "$VIM/sysinit.vim"
  fall-back for $VIM: "
/home/linuxbrew/.linuxbrew/Cellar/neovim/0.9.2/share/nvim"

Run :checkhealth for more info

Thanks!

Just pushed 13dd53b which updated the default config to use the updated highlight group functions - I haven't been able to reproduce, but can you let me know if that fixes it once you update?

Updated to 9d2ec14 Same error, I think I need to provide more info but I don't know which ones I need

What colorscheme are you using / do you have termguicolors enabled? Could help narrow things down, it's possible that there are some edge cases with older color schemes.

I am using the theme vscdoe, echo &termguicolors output is 1

I have not been able to reproduce this. Could you try to create a minimal init config that can reproduce the issue? Thanks

I've created a Minimized Configuration Repository, can you take a look at it for me?

Sure, I'll try that out. Has that repo been confirmed to reproduce the issue with the default cokeline config? It looks like you're using the get_hex function in there, which is deprecated, so not sure if that could be related.
Also, as a sidenote, generally you should provide a single file that can be copy-pasted as a minimal init. The idea is that it can be tested with nvim --clean -u minimal.lua to make reproducing quicker, without having to download an entire nvim config. For this one it's alright tho, I'll look at the repo if that can reproduce the issue.

Enabling cache in lazy.nvim fixed the issue for me. Not sure why this would be the case, I'll keep looking into it, but let me know if that fixes it for you.

Actually, using require("cokeline.hlgroups").get_hl_attr instead of get_hex fixes it for me as well. You should use that function instead of get_hex as is suggested in the readme, because it uses the Lua/C API instead of vimscript and caches results to avoid repeated lookups. I'm closing this as I've concluded this to be the issue, but if that fix doesn't help then feel free to reopen.

I reproduced the problem using the following configuration, and it looks like it is indeed caused by get_hex
local lazypath = vim.fn.stdpath("data") .. "/lazy/lazy.nvim"
if not vim.loop.fs_stat(lazypath) then
    vim.fn.system({ "git", "clone", "--filter=blob:none", "https://github.com/folke/lazy.nvim.git", "--branch=stable",
        lazypath })
end

vim.opt.rtp:prepend(lazypath)

local cokeline_config = function()
    local get_hex = require('cokeline.utils').get_hex
    -- require('cokeline').setup()                  -- 1
    require('cokeline').setup({                     -- 2
        default_hl = {
            fg = function(buffer)
                return
                    buffer.is_focused
                    and get_hex('Normal', 'fg')
                    or get_hex('Comment', 'fg')
            end,
            bg = 'NONE',
        },
    })
end

require("lazy").setup({
    {
        "willothy/nvim-cokeline",
        dependencies = {
            "nvim-lua/plenary.nvim",
        },
        config = cokeline_config,
    },
    'Mofiqul/dracula.nvim',
    'Mofiqul/vscode.nvim'
})

Notice the two comments in the code, when I use the code in the first place there is no error. When I use the code in the second place, there is an error

Yeah, get_hex should not be used. It was deprecated because it has many issues due to relying on VimScript calls. I'll likely remove it entirely soon. The new highlight APIs are in cokeline.hlgroups, and should not cause any issues.

Yes, problem solved, thank you very much. Nice plugin

Thanks! Glad I could help, sorry it took so long.


Properly support BlockHeader <-> HF.Point conversions

Context
We can no longer (correctly) convert SlotNo to SlotId using the genesis epoch length when
the hard fork arrives. Shelley may use a different epoch length.
To interact with the node we need to provide points which are (slotNo, headerHash).
Rollbacks to EBBs are not a concern as they have already ceased to be produced.

Decision

Replace SlotId with SlotNo in DB
Concider using a special value for genesis (like NULL)

Acceptance Criteria

Wallet must not break when the hard fork arrives
The DB/persisted slots should be easy to reason about for developers (i.e. not just work by accident)
Don't break cardano-wallet-jormungandr

Development
QA

Existing tests pass

Wallet must not break when the hard fork arrives

Bad AC, but we don't need to convert between SlotNo and SlotId anymore to talk to the node.

Here are the new golden tests for sync progress calculation: https://github.com/input-output-hk/cardano-wallet/blob/master/lib/core/test/unit/Cardano/Wallet/Primitive/SyncProgressSpec.hs#L125-L135

I think it would be neat to even use the very same SlotNo definition as other projects https://github.com/input-output-hk/cardano-base/blob/5c6db42be8ed83463f89e6257d8eb94ca4df8ca9/slotting/src/Cardano/Slotting/Slot.hs#L31-L35

lgtm


Move offline downloads off of the main thread

We currently make use of a Android service to download a region but this is running on the main thread. It'd be more performant to move this over to a separate thread.

Currently blocked by https://github.com/mapbox/mapbox-gl-native/issues/11728.

After internal discussion, offline improvements downstream will make moving the offline downloads on a separate thread little to no performance improvements in our offline plugin.


Scroll view

This PR closes #7407.
This is still work in progress, but it's working.

There are some things to fix to work better:

[x] Right now, the component fills the remain height, and works for now. But we need to make some changes in the css in order to work with flexbox. It will allow to react to other views like the warnings or errors.
[x] Because the reason above, we need to remove the resize binding, and fixed height logic.

Also, the approach taken here is to extend the base Backbone.View, in order to avoid bringing too much functionality. I'm not sure about it, because cdb.core.View has done a lot of work behind the scenes to ensure they'll just work. So, I'm wondering if a mixin approach would be better:
// scroll.js
module.exports = {
  applyScroll: function () {},
  destroyScroll: function () {},
  otherStuff: function () {}
}

// any view composing scroll
var Scroll = require('../mixins/scroll');

module.exports = cdb.core.View.extend(
  _.extend({}, Scroll, {
    ...
    // (Methods and attributes here)
    ...
  })
);

Thoughts?
cc @viddo @javierarce @xavijam

I'd wait to review the whole thing until we have the flexbox thing working properly.

@xavijam working with flexbox /cc @piensaenpixel

It looks pretty promising, what do you think @viddo?
BTW, it would be great @nobuti if you can apply the scroll thing to all working panes.
Widgets list and form, style form, etc, pretty please.

On it.

Done.

👍

👍  Looks good to me too.

🚀


add intellisense

see https://codemirror.net/demo/complete.html
also take a look at https://github.com/BayardRock/WebIntellisense

another thing to take a look at: https://github.com/davidhalter/jedi

Jedi seems like the best python intellisense availible.  Unfortunately it would be rather difficult to integrate.  I'd have to do something like below:
python jedi -> pyshell -> JS jedi interface -> codemirror integration
There is no generic JS interface for jedi, altough there are some (undocumented) examples of it's use with vscode & atom
https://github.com/DonJayamanne/pythonVSCode/blob/master/src/client/jedi
https://github.com/brennv/autocomplete-python-jedi

I've also thought about doing "live" intellisense by using python's dir() and inspectdoc but that would be problematic when side-effects come to play.  If someone was doing autocompletion on subtractFooByOne().fo .... then I would have to store the result of the method call in a temporary variable to avoid evaluating it twice.  That could get really complicated.

I tried out "live" intellisense in #44:
When the user does control-enter I wrap the line in a print(dir()).
If the line assigns to a variable then I do print(dir(var)) instead on the next line.
But there are tons of cases where this won't work - for example, wrapping if(var.) would result in a syntax error.  What I really need is a parser to extract the variable.  Or maybe I could use codemirror's inbuilt python parsing?  Last time I checked it didn't tokenize everything though.


Resolve Kaggle issue

What does this PR do?
This PR resolves #7
Related Links

Issue : #7

LGTM. Thank you for your contribution.


fix virtual machine name maximum length problem

Fixes #14
This issue is also discussed here:
https://github.com/hashicorp/vagrant/issues/9524
The above fix is  mentioned there - still do not know why changing audio settings fixes the length of VM names.

Thanks for bringing the problem up and providing the fix @Govinda-Fichtner
I merged the pull request manually and took the liberty of updating the commit message to include the error message.


added check to reconcile controller revision

IMPORTANT: Please do not create a Pull Request without creating an issue first.
Problem:

Solution:

Related Issue:
Test plan:

@mergifyio backport v1.2


Include kinesis permissions to allow suscribing to a stream

Description
Adds kinesis permission to lambda execution policy managed by zappa. This is required to allow zappa to subscribe for a kinesis stream.
Without it following message is printed to console on schedule:

ClientError: An error occurred (InvalidParameterValueException) when calling the CreateEventSourceMapping operation: Cannot access stream arn:aws:kinesis:ap-southeast-2:032345039960:stream/d-facebook-bot-notifications. Please ensure the role can perform the GetRecords, GetShardIterator, DescribeStream, and ListStreams Actions on your stream in IAM.

Sample event definition:
"events": [
         {
            "function": "app.events.run",
            "event_source": {
              "arn": "arn:aws:kinesis:ap-southeast-2:032345039960:stream/d-incoming-notifications",
              "starting_position": "TRIM_HORIZON",
              "batch  size": 1,
              "enabled": true
            }
         }
       ]

Good and necessary PR, please re-record with Placebo if you can.

What is your use case for Kinsesis and Zappa? I've been wanting to use that combination for something but I don't know enough about using Kinesis in the field.

Coverage remained the same at 78.024% when pulling f82a8a8acc03200159217c5403ff83e9b5f47878 on DomainGroupOSS:feature/kinesis-permissions into 3453e5c98324d06ebd709ef289bb2f3a225aa105 on Miserlou:master.

@Miserlou updated tests.
We use kinesis as event bus at the moment to process notification from various sources. While an SNS topic subscription would've done the same, kinesis offers replay functionality and data retention, so we decided to try that out first.

Excellent! And an interesting use case, would love to know more once it's been battle tested.


RTSP Source API Reference - constructor section is missing the drop_frame_interval

Merged into the v0.30.alpha dev branch


chore(main): release 1.1.16

:robot: I have created a release beep boop
1.1.16 (2023-05-27)
Features

add getProjectById query function to fetch a single project by ID (ea6844c)
add icons to project edit page tabs to improve UX and make it easier to identify each tab (ea6844c)
add support for sending test exceptions to Airbrake JS and Airbrake Node (ea6844c)
bookmarks: replace OccurrencesTable with BookmarksTable component to display bookmarks and improve search functionality (26a6c0a)
NoData.tsx: add optional showHeader prop to conditionally render header in NoData component (2f73cc6)
occurrence page: replace prisma query with getOccurrenceById function in occurrence page and related components to improve code semantics and readability (2fba1fa)
occurrenceBookmarks: add function to fetch occurrence bookmarks based on provided search parameters (26a6c0a)
occurrences.ts: add cached function to fetch a single occurrence by ID (ea6844c)
occurrences.ts: add function to fetch occurrences based on provided search parameters (ea6844c)
Overview.tsx: add Test Zone section to Overview component and use NoData component to display message when no exceptions are recorded (2f73cc6)
public: add demo gif to be used in the README file (e2fc24c)
queries/projects.ts: add getProjects function to fetch projects from the database based on optional search term, refs https://github.com/icoretech/airbroke/issues/41 (6a2660d)
queries/projects.ts: add getProjectsGroupedByOrganization function to fetch projects grouped by organization from the database (6a2660d)

Bug Fixes

add type import for SortAttribute and SortDirection in project page component to avoid type errors (ea6844c)
bookmarks: change revalidate time to 0 to always fetch latest bookmarks (26a6c0a)
change error message in Airbrake JS test exception to match convention (ea6844c)
remove unused import in airbrakeActions (ea6844c)

This PR was generated with Release Please. See documentation.

:robot: Release is at https://github.com/icoretech/airbroke/releases/tag/v1.1.16 :sunflower:


Feature Request: Drag and drop from a pdf opened in the browser

Feature Requested
Hey!
I love the fact than you can drag and drop text directly from a webpage into a canvas or a note with your plugin.
I wish I could do the same with a pdf opened into the browser, is this something that is feasible?
Thanks
Relevant Screenshot
No response
Checklist

[X] The feature would be useful to more users than just me.

It is impossible now for this plugin, surfing doesnt handle pdf files.


Fix index construction statistics

Fixed several issues in the index statistics

Since get_count(size_t position) counts the seed abundance starting from the argument position, get_count is now used with the first occurrence position
Fixed median seed length
Clarified statistics text

Hi Ivan,
Thanks - and great that you found this bug!
I approve the PR, but I will let Marcel make the final call.
@marcel, note that auto count = get_count(find(get_hash(it))); is a bit of a redundant call, since it involves two searches. A faster way to do it would be skipping over all seeds with the same hash and increment the counters differently:
            tot_seed_count += count;
            tot_seed_count_sq += count^2;

However, this part of the code is only for printing index statistics, therefore it is not crucial for it to be optimised.
Hence I approve.

I’ll merge this so that it can be part of the next release. To be honest, I’ve never used print_diagnostics, so it being inefficient doesn’t affect me that much, and I guess it’s rarely used in practice anyway.


Create documentation for building on a local machine

Hey, I am on a windows machine on my laptop, and would like to contribute, I have been surveying the source code for dependencies and I think i will be able to publish a list of requirements.This will include the contents of pip freeze, and perhaps a vagrant install script? This way there can be reproducible deploys, which would be super easy for local testing.
Ideas?

@sinistersnare have you had any progress on this?
I've only just started looking at this repo, but I don't think cross platform functionality has been considered yet.
Check this diff, it's not really PR worthy material but might help indicate where we can start?
Problems I see are

the dash scripts for calling rust.. I've made mine bash, you would need a batch equivalent? Perhaps we can just make them python as well to make it properly cross platform?
playpen dependency seems to require a whole lot of work to get going locally, perhaps we can deactivate it if this is not running on a "production" environment.. though how would we know when we're on production?

I've made a diff of what I tried to do to make it work on my BSD based system..
https://github.com/svanellewee/rust-playpen/compare/f886864dc754b52c0284c537b4aef6e499b59ab6...svanellewee:master

Ive actually completely forgotten about this :) School was really busy right after I wrote this issue.
If you want to take the reigns on this please do, I think having clear cut dependencies and venv setup would be amazing.
Thanks so much for your work! Sorry that I am so lazy :p

@sinistersnare, @svanellewee  Welcome! It's great to start getting other contributors to the infrastructure involved, and I'm sure you'll find all kinds of previously-unnoticed bugs (especially missing documentation) by building a copy of it yorself!
The possibly bad news is that it's not possible to build rust-playpen on any platform other than Linux with systemd right now, because of the underlying [Playpen][https://github.com/thestinger/playpen] sandboxing tool's requirements. It actually only builds on Arch at the moment, due to some assumptions in init.sh about the availability of Arch-specific scripts, but I'm working on making it run on Ubuntu in order to get the special Arch snowflake out of Rust's production infrastructure. I'll also document the dependencies as I go along -- the end result will be an Ansible playbook that you can point at an Ubuntu box, run, and end up with a working rust-playpen installation.
@sinistersnare, I think the best bet for making progress on this right now would be to spin up an Arch VM by following instructions like [these][http://www.cs.columbia.edu/~jae/4118/arch-setup-2015-1.html].

Yeah I figured it would only run on Arch, thats what the creator uses. I made the issue so that we can be aware that we should document things like that.
I tihnk we need a couple things so we can have reproducible builds:

Vagrant usage
requirements.txt
a useful section in the README.

I am fine with only being able to run on Arch, but the fact that it was not documented is a problem.

Documented the IRC bot setup in #132. Haven't documented webserver or init.sh stuff yet.


Remove clusterimageset metadata from definition when it is deleted

Removes resourceVersion and creationTimestamp from clusterimageset when the object is successfully deleted. Needed to re-use initial clusterimageset builder struct

/lgtm


Added Maximum Sum Answer

Added solution to Maximum  Sum question
Fixes #242

[x] Bug fix (non-breaking change which fixes an issue)
[x] New feature (non-breaking change which adds functionality)
[x] This change requires a documentation update

Checklist:

[x] My code follows the style guidelines(Clean Code) of this project
[x] I have performed a self-review of my own code
[x] I have commented my code, particularly in hard-to-understand areas
[x] I have created a helpful and easy to understand README.md
[x] I have made corresponding changes to the documentation
[x] My changes generate no new warnings

@Aiswarika place ur code in appropriate folder


Importing a VariableGroup fails when it has variables

Hello!

Vote on this issue by adding a 👍 reaction
To contribute a fix for this issue, leave a comment (and link to your pull request, if you've opened one already)

Issue details

I am trying to import an existing VariableGroup using pulumi import. It fails with:
    error: azuredevops:index/variableGroup:VariableGroup resource 'some-variable-group' has a problem: "variable.0.content_type": this field cannot be set
    error: azuredevops:index/variableGroup:VariableGroup resource 'some-variable-group' has a problem: "variable.0.enabled": this field cannot be set
    error: azuredevops:index/variableGroup:VariableGroup resource 'some-variable-group' has a problem: "variable.0.expires": this field cannot be set
    error: azuredevops:index/variableGroup:VariableGroup resource 'some-variable-group' has a problem: "variable.1.content_type": this field cannot be set
    error: azuredevops:index/variableGroup:VariableGroup resource 'some-variable-group' has a problem: "variable.1.enabled": this field cannot be set
    error: azuredevops:index/variableGroup:VariableGroup resource 'some-variable-group' has a problem: "variable.1.expires": this field cannot be set
    error: azuredevops:index/variableGroup:VariableGroup resource 'some-variable-group' has a problem: "variable.2.content_type": this field cannot be set
    error: azuredevops:index/variableGroup:VariableGroup resource 'some-variable-group' has a problem: "variable.2.enabled": this field cannot be set
    error: azuredevops:index/variableGroup:VariableGroup resource 'some-variable-group' has a problem: "variable.2.expires": this field cannot be set

Steps to reproduce

Have an Azure DevOps variable group that already has some variables defined
Try to import this variable group using pulumi import

Expected: The VariableGroup and its defined variables are imported successfully. Pulumi does not complain avout ContentType, Expires or Enabled
Actual: Pulumi complains that it cannot set either of ContentType, Expires or Enabled when in fact these properties shouldn't even be set during import.

As a workaround, are you able to import programmatically via the import resource option?

Sorry, I must've missed the notification for your original reply.
If I'm understanding your flow correctly, I think the following could work?

pulumi stack export from the local self-managed backed
pulumi stack import into the newly provisioned Blob Container-based backend
pulumi stack change-secrets-provider after the import to swap from passphrase to using the Key Vault.
pulumi up for any additional changes you want to make.

This way, you've imported the state file itself and you're not relying on trying to import the resources via reads. At that point, you should be able to operate against the imported stack.

That’s an excelent idea, clearly simplifies my workflow and eliminates the need for manual imports. Will definitely try it. Thank you very much!


Add workflows show command

Connects to #675
Adds a terminus workflows show command that displays 2 different tables (in normal output) and as a json object (in json output):

It works great, but it's pretty slow for large sites. I used this site to test, which has 1051 workflows when listing them out and took 49s to render a list much too long to be navigable. In fact, with my terminal set to only save the last 1000 lines, it's not possible to see the first 53 in the list.
https://dashboard.pantheon.io/sites/672ae238-dede-44f4-9243-89a591c2cc46
While I'm not sure what should be done to make the list more usable for our larger clients, it may do to have the datetime at which the workflow was run (can we get that info?) in the listing.

The created_at attribute will give you the time. It would be useful in order to narrow down which workflow we're after in the list.

@TeslaDethray I pushed a change to include the created_at in the workflow menu. I also added a non-paged fetch to the menu so it shouldn't present every...single...workflow.

+1. You don't suppose anybody's going to want those really old workflows, do you?

@TeslaDethray 100 recent workflows is enough for anyone!
/s


Integrating new create finished page

@jparkrr We have some new alternative designs for the create finished page & weren't sure the best way to integrate them due to the create petition action redirecting to 'create_finished.html'

The new page will be mostly similar to create finished, but will have an additional element above & below  plus a couple of changes to the thanks copy. Is it best for us to create another container & have some condition in the create petition action?

I think it would be fine if you created a new /src/components/theme-giraffe/create-petition/finished.js based on the existing thanks.js,  and have a conditional to include it in /src/containers/thanks.js, maybe checking this.props.isCreator && Config.THEME === giraffe.


What is the context window?

So 4096 tokens..

Any experience in using it for more than 4096 tokens? any idea when checkpoints trained on more than 1 trillion tokens will be ready?

Any experience in using it for more than 4096 tokens? any idea when checkpoints trained on more than 1 trillion tokens will be ready?

If you have a conversation with it and lets say the 'story' exceeds 4096 tokens then the agent will start forgetting the story in the beggining. Think of the context length as a window which represents the models memory, as you keep having a discussion with the bot the window slides down, and it won't have the first messages in the input anymore and then it will slide down more etc.


Adop 38 idam integration

Adop 38 idam integration

Closing this PR due to error in pipeline
11:40:52  org.jenkinsci.plugins.workflow.cps.CpsCompilationErrorsException: startup failed:
11:40:52  file:/var/jenkins_home/jobs/HMCTS_Adoption/jobs/adoption-web/branches/PR-26/builds/8/libs/Infrastructure/src/uk/gov/hmcts/contino/Environment.groovy: 37: The current scope already contains a variable of the name cleanedEnvironment
11:40:52   @ line 37, column 12.
11:40:52         String cleanedEnvironment = environment.replace("packer-", "")


move pool_default_pg_num to ceph-common

The var pool_default_pg_num is being used in both the ceph-client and ceph-mon roles, so move it to ceph-common where they both can access it.
This resolves https://bugzilla.redhat.com/show_bug.cgi?id=1414213 and https://github.com/ceph/ceph-ansible/issues/1145
This also adds client nodes to our centos7_cluster and xenial_cluster testing scenarios.

This is handled by this PR already, I was still fighting with this one, resuming soon: https://github.com/ceph/ceph-ansible/pull/1146

jenkins test ansible2.2-docker_cluster

Closing in favor of https://github.com/ceph/ceph-ansible/pull/1146


Complete last modified date

Hello,
I've a small cent to enhance this already functional package.
What about having a hotkey to press to insert the last day the file has been modified, with both DD/MM/YYYY and MM/DD/YYYY formats?
I'd like to get something like:
//
//  Filename.extension
//
//  Created by John Doe on 21/12/15.
//  Copyright © 2015 John Doe. All rights reserved.
//

With many thanks
gf

I apologize, but we're no longer developing this package. You may be interested in the FileHeader package instead which does support multiple date formats.


Add fluids to ingredient combinator

I don't actually know what I wanted to do here anymore ...

Hmm right, I'm not sure why I excluded fluids from this in the first place, there's probably a reason? Can you think of any reasons for excluding fluids from the combinators?

I'm not super familiar with Lua nor modding Factorio, but from the user (player) perspective fluids work the same as other items - you can just set a signal that is a fluid.
So the question might be: is the function used in many places or only to generate constant combinators? Like, I don't know... calculating needed belts or something?
Do fluids need to be handled differently when creating a signal? Like, for example, when you add an icon to station names or blueprints you have to use [item=iron-plate], but [fluid=water].

My bad, it was a reflex 😂


Ignore Cargo.lock

Hey John, I just learned today that Cargo.lock shouldn't be committed and published with library crates.
See https://doc.rust-lang.org/cargo/faq.html#why-do-binaries-have-cargolock-in-version-control-but-not-libraries

Good catch! I learned something. Merging


Can't build 0.15 Core

Affected Version
The current Source Release 0.15.0-incubating
Description
As there is no binary release this time, I have to build it myself, which fails at the Druid-Core while running tests.
I tried jdk 11 and jdk 8 (both oracle's 212 and openjdk), but I run into the same errors.
org.apache.druid.java.util.http.client.JankyServersTest-output.txt
org.apache.druid.java.util.http.client.JankyServersTest.txt
These are the logs, which Maven links me to and I don't get, why a test loses connection to anything it wants to connect to.

As there is no binary release this time, I have to build it myself

I should open my eyes on the druid.io website


Don't use pointer compression where the ecma_value can store pointer …

…value directly.
This changes affects those internal properties where the property value type is an ecma_object_t ptr.
JerryScript-DCO-1.0-Signed-off-by: Robert Sipka<EMAIL_ADDRESS>

LGTM

Thanks, I've updated the patch based on your comment.

I've rebase with master.

LGTM

LGTM


Merge pull request #1 from Neo945/master

All the files are updated

@googlebot I fixed it.

@googlebot I fixed it.

@googlebot I fixed it.


fix set version to work with blacked file

sed broke because black has reformatted the __init__ file. my bad.
That's a clear indication that the pipeline is too fragile; will try to fix asap.

👍


Custom CSS

Are there any plans for a custom CSS system? (loading external stylesheet for overrides, etc...)
This would allow more advanced customization of elements (note colors, service colors, etc.)

Thanks !

I am a beginner learning the JSON structure, and I would like to ask about the code to separate 'services' on a single page, for example, the titles 'IT-Tools and their websites' and 'HR-Tools and their websites.
Example:

My final question, is there a way to add the website logo at the top of the page?
Thank you very much!

I made a PR https://github.com/r7wx/easy-gate/pull/35 let see if gets approved

The PR is approved and merged into dev branch, the feature will be available in the next release! Thank you!

Feature available on release 2.0.1


test(blocksync): increase capacity of errorsCh

similar to how we set capacity to 1000 in production to avoid locking.
const capacity = 1000                      // must be bigger than peers count
errorsCh := make(chan peerError, capacity) // so we don't block in #Receive#pool.AddBlock

https://github.com/cometbft/cometbft/blob/main/internal/blocksync/reactor.go#L99C1-L100C91

--- FAIL: TestBlockPoolMaliciousNode (11.60s)
    pool_test.go:360: error with peer bad: requested block #20 from [], not bad
    pool_test.go:71:
        	Error Trace:	/home/runner/work/cometbft/cometbft/internal/blocksync/pool_test.go:71
        	            				/home/runner/work/cometbft/cometbft/internal/blocksync/pool_test.go:45
        	            				/opt/hostedtoolcache/go/1.23.1/x64/src/runtime/asm_amd64.s:[17](https://github.com/cometbft/cometbft/actions/runs/10954972836/job/30417932742#step:6:18)00
        	Error:      	Received unexpected error:
        	            	requested block #20 from [], not bad
        	Test:       	TestBlockPoolMaliciousNode
    pool_test.go:370: Pool caught up, malicious peer was banned at least once, start consensus.


Add active/paused toggle

Asana task: Pause/Active toggle
Description
This PR adds a toggle to the PA Messages table that allows a user to pause or unpause a PA Message. The toggle updates the pause tag in the DB.
Additionally, if a PA Message is updated in a way where it is going to be either in or out of the active period of said PA Message, we will set the paused state to unpaused.
When a PA Message is set to paused, it should not trigger readouts. Note that this PR doesn't update the query that returns active PA Messages, which is also used by RTS when querying for active messages. I have the opinion that it would be simpler to do the filtering on the RTS client-side since if we filter out paused messages on the server, they won't be returned to Screenplay and therefore we won't show them in the PA Messages table anymore. We'd have to split it out into a different endpoint or add a parameter for including paused messages or something. I'm open to other thoughts though.

Note that this PR doesn't update the query that returns active PA Messages, which is also used by RTS when querying for active messages.

I'd lean slightly in the other direction, given the concept of a message being "paused" is specific to Screenplay. I don't think RTS should have to also understand that — it should just get a list of messages it should play. If it also has to filter out paused messages, the "footprint" of this feature becomes larger and it could be harder to maintain.

We'd have to split it out into a different endpoint

I didn't realize the endpoint used by the Screenplay frontend and the endpoint used by RTS were actually the same. I think this is the solution I'd favor. We probably want to be able to do whatever we like with our "internal API" to the frontend, without affecting our external "contract" with RTS.

@digitalcora Actually I was sort of mistaken - they do use different endpoints, but they share the same query. If we just add a new query or some filtering that accounts for the paused state, that should be easy enough.


Enable/Disable Openpilot from controls

Suggest a toggle, such as "Press Cruise Cancel x3 within a second" and that will toggle Openpilot between Dashcam mode and being enabled.

This sounds like a nice feature for a fork, but this isn't something we're interested in implementing.

Shame. That means while driving, I can't use ACC by itself without turning off the car and disabling Openpilot.


Support more sites

I'd like Seshat to support more sites (e.g. some people have asked for LinkedIn), but they don't have a straightforward way of grabbing the link to the user profile just from the HTML element containing the name. The selector code should be refactored to produce a list of pairs of user name elements and user profile URLs.

This repo may help with supporting GitHub better!


Question:  SchwarzIT/terraform-provider-stackit or stackitcloud/terraform-provider-stackit

Hello,
when searching for a STACKIT terraform provider I found that there is this provider and the SchwarzIT/terraform-provider-stackit. They seem similar but still have different versioning and development. Is this the official one or should I use the SchwarzIT one? Which one is better maintained?

Hi,
This one (stackitcloud/stackit) is the official STACKIT Terraform provider.
The SchwarzIT/stackit is a community maintained provider that was created before the official one.

Hello @PeterStolz, this is the official STACKIT Terraform Provider and we will extend it with all of the existing and future STACKIT services, so you should use this one.
The other provider that you mentioned is developed and maintained by the STACKIT community within Schwarz IT and it was created before the official one existed. It is still being maintained as long as internal teams are using it, per their README


Open a cordova plugin

Hi,
When opening a cordova plugin for example barcode scanner,it doesn't open in kiosk mode.
It opens in normal mode.
Any idea how to fix that?
Thx,

This is not possible - you have to keep user in protected activities - you have to solve scanning without new activity or to create kiosked scanning app.


Optionally implement TryFrom in libc_enum!

This saves code in several separate places that need to do this
separately.  At the same time, remove a few uses of mem::transmute that
were implementing TryFrom or similar functionality.
Issue #373

Sorry @asomers, but I'm not going to be able to review this. I've been out of the coding game for quite a while now, even giving up maintenance of serialport-rs in favor of other life pursuits. Hopefully some of the other maintainers can assist. I'm going to remove myself from the nix-maintainers team as well as I think that's appropriate at this stage. I have stayed on as I thought I might return, but at this point I don't think that's going to happen.

Out of the coding game entirely, as in even professionally?

I write very little code at work since about 4y now, only coding was for personal stuff. And I've realized I want to prioritize some other things. Appreciate working with you on this project and it was a great experience helping to build and maintain nix!


Update build-and-push-to-ecr-step-settings.md

Please check the Execution Link of the Pipeline for the Website Draft URL. This is located in the Preview Step behind the Harness VPN and also is available in #hdh_alerts. E.g Website Draft URL: https://unique-id--harness-developer.netlify.app. Current Draft URL is: https://6583414c7e948f5226d03320--harness-developer.netlify.app


syscall: add DLLError.Unwrap() method

These older structs embed a wrapped error. But because they're old, they haven't defined an Unwrap() method. We should do this, so that users can check for issues such as if errors.Is(err, windows.ERROR_PROC_NOT_FOUND) { ... }, which is becoming more important as Microsoft keeps adding APIs.

cc @alexbrainman

Changing the title, as things are now handled with x/sys/windows.

@zx2c4 thank you for creating this issue.
I adjusted your issue title so it looks like proposal
https://github.com/golang/proposal#the-proposal-process
I also fiddled with the labels. Hopefully I did correct thing.
Now we wait for proposal decision. Even if this proposal is accepted, I doubt we will be able to implement this until Go 1.16 is released.
Alex

This seems OK and it would be better to be consistent with x/sys.
It is also consistent with our adding Unwrap to every error implementation that wraps another error.
I'm not sure how we missed this one to start with.
Looking in the API files, I see these remaining without Unwrap methods:
go1.txt:230:pkg compress/flate, type ReadError struct, Err error
go1.txt:236:pkg compress/flate, type WriteError struct, Err error
And those are marked "Deprecated, no longer returned".
So somehow we missed only DLLError (and maybe x509.SystemRootsError, which was recently fixed).
Let's fix it.

Because it is trivial and consistent with everything else, we can just approve this. Accepted.

Great. I'll submit https://go-review.googlesource.com/c/go/+/269761/ whenever you want to +2 it.

@rsc @andybons @dmitshur
There is https://go-review.googlesource.com/c/go/+/269761/ that implements this change. The CL was submitted after Go 1.16 freeze started. I propose we submit the CL now for Go 1.16.
The change is trivial.
And according to @rsc https://github.com/golang/go/issues/42584#issuecomment-729873855 the change was somehow missed. Let's fix this problem in Go 1.16 rather than delaying it for Go 1.17.
What do you think?
Alex

@alexbrainman Thanks for making this freeze exception request and providing a rationale.
I am approving this for Go 1.16. The change is trivial and should not add significant delay or increase risk for the release. (It's also easy to revert if we learn of serious problems that cannot be resolved in time.)


Invalid response from server, try again Response: Unable to connect, check connection information is correct

Hi there, I have this error in my WebUI when I access my MySQL DB from another host.
Example:
I install the Web UI on domain1.com/bans, and the database is hosted on domain2.com (port 3306). I create a database, bmbans, and I let the plugin fill the DB up. I then assigned user user1 to the DB bmbans. Then, I access domain1.com/bans/index.php?action=admin and login. I tried to add the MySQL host domain2.com with the username user1 and password (user password). It returned this response: Invalid response from server, try again
Response: Unable to connect, check connection information is correct
I have Remote MySQL allowed for the host domain1.com

Can you make sure the user is added as "user1@domain1" in the MySQL server on domain2?

@xiurobert Any updates on this?


Compilation errors when disabling default features in datafusion-common

Describe the bug
When depending on datafusion-common with default-features = false, there are compilation errors related to parquet functionality.
To Reproduce
In the datafusion-expr crate, add default-features = false to the datafusion-common dependency. Then try to build the datafusion-expr crate.
There are compilation errors such as:
error[E0433]: failed to resolve: use of undeclared crate or module `parquet`
  --> datafusion/common/src/file_options/parse_utils.rs:20:5
   |
20 | use parquet::{
   |     ^^^^^^^ use of undeclared crate or module `parquet`

error[E0433]: failed to resolve: use of undeclared crate or module `parquet`
  --> datafusion/common/src/file_options/parquet_writer.rs:20:5
   |
20 | use parquet::file::properties::{WriterProperties, WriterPropertiesBuilder};
   |     ^^^^^^^ use of undeclared crate or module `parquet`

error[E0433]: failed to resolve: use of undeclared crate or module `parquet`
  --> datafusion/common/src/file_options/parse_utils.rs:43:13
   |
43 | ) -> Result<parquet::basic::Encoding> {
   |             ^^^^^^^ use of undeclared crate or module `parquet`

error[E0433]: failed to resolve: use of undeclared crate or module `parquet`
  --> datafusion/common/src/file_options/parse_utils.rs:46:23
   |
46 |         "plain" => Ok(parquet::basic::Encoding::PLAIN),
   |                       ^^^^^^^ use of undeclared crate or module `parquet`
   |
...

Expected behavior
It would be possible to compile datafusion-common with the default parquet feature disabled.
Additional context
In VegaFusion I compile datafusion-common into WASM, and the parquet crate is not (easily?) compatible with WASM due to some non-rust compression dependencies.
I'll have a PR with suggested fix up shortly

In VegaFusion I compile datafusion-common into WASM, and the parquet crate is not (easily?) compatible with WASM due to some non-rust compression dependencies.

@jonmmease  in order to avoid such errors in the future, perhaps we can encode the usecase into a CI test
Can you share the command / commands you use to compile for wasm (specifically what target)? Here is what we use for sqlparser-rs
https://github.com/sqlparser-rs/sqlparser-rs/blob/7723ea56c5119c7d1a15233c18eb2aaf48b60dc0/.github/workflows/rust.yml#L48-L56
But I

That's a good idea. I made a PR in https://github.com/apache/arrow-datafusion/pull/7633 that adds a minimal wasm library crate that depends on the various DataFusion crates that are currently wasm compatible.


Warning message regarding unsupported architecture

Affected Puppet, Ruby, OS and module versions/distributions

Puppet: 5.4.0-2ubuntu3
Ruby: 1:2.5.1
Distribution: Ubuntu 18.04.1
Module version: 2.2.1

How to reproduce (e.g Puppet code you use)
class { '::virtualbox':
manage_kernel  => false,
manage_package => false,
}
What are you seeing

sudo apt update
N: Skipping acquire of configured file 'contrib/binary-i386/Packages' as repository 'http://download.virtualbox.org/virtualbox/debian bionic InRelease' doesn't support architecture 'i386'

What behaviour did you expect instead
No warning message regarding VirtualBox repository
Output log
Any additional information you'd like to impart
I was thinking maybe adding the node architecture to the apt::source to remove the message about i386 arch not supported.
== Class: virtualbox::install
    apt::source { 'virtualbox':
      architecture => $::virtualbox::params::architecture,
      location     => 'http://download.virtualbox.org/virtualbox/debian',
      release      => $::lsbdistcodename,
      repos        => $apt_repos,
      require      => Apt::Key[ $apt_key_thumb ],
    }

== Class virtualbox::params
$architecture    = $facts['architecture']
==>
/etc/apt/sources.list.d/virtualbox.list
deb [arch=amd64]  http://download.virtualbox.org/virtualbox/debian bionic contrib
Cheers,
Franck

Hi @Dan33l,
No I am using an x86_64 node (Ubuntu 18.04.1)

It's maybe the opportunity to add support of Ubuntu 18.04 ;)

You are welcome if you want to provide a PR.
But we are with an issue about acceptance tests in this module.
https://github.com/voxpupuli/puppet-virtualbox/pull/71#issuecomment-412841288
And our acceptance tests use docker but for this module it is not possible due to load of kernel modules.

Hi @Dan33l,
It's the first time I am creating a pull request :)
You are asking for a failing test but I am not fixing something failing but just adding the architecture to the repository definition.
So :
Fork it --> DONE
Create a feature branch --> DONE (https://github.com/meskaya/puppet-virtualbox/tree/architecture)
Write a failing test --> it's not failing it's just the repo definition that needs architecture on Ubuntu 18.04
Write the code to make that test pass --> code is part of the new branch
Refactor the code --> DONE
Submit a pull request --> will do it as soon as you tell me it's ok or if I have to do something first

Hi @meskaya a travel start with a first step. Let's move forward together
You can find guidance about contributing here in CONTRIBUTING.md
If you wish, you can also join Voxpupuli members on channel #voxpupuli by IRC or Slack. It should be more interactive than here.
It is difficult to find what is changed from our master branch without pull request. So, please submit the pull request and we will be able to talk about modifications.


Options export in Firefox hangs

When attempting to export settings from the Saka Key preferences page (from the Add-ons Manager page in Firefox, not the popup in the hamburger menu), the tab doesn't finish loading.
If I try to export settings from the popup (which the extension urges that it not be used), it works fine. The preferences page also works on Chrome, so this is a Firefox-specific issue.
I'm on Firefox 55, Saka Key 1.21.3.

Thanks for the bug report again! Will work on a fix.

Rather, I should be thanking you for creating this fantastic extension.


Deprecate support for detached SCTs

We do not plan to continue to support detached SCTs for Fulcio, and most clients don't have support for detached SCT verification and the bundle format does not include them.
Context: https://github.com/sigstore/fulcio/issues/1499

Summary

Release Note

Documentation

Had to do a make clean to fix the mismatch for compilation of the Python code


Main.storyboard is reporting several autolayout/constraint issues

I'm happy to tackle these, but I don't want to cause a merge conflict with the PR for circular progress.

That would be great - will review the progress circles tomorrow so we can get it merged in.

I haven't forgotten about this. It's just more complicated than it seems. IB really, really, really hates the tableHeader on MyImpactViewController, and the quick fixes I tried didn't work.

Thanks @fingersakimbo! Appreciate the devotion to this issue