In SPA mode, adding @aspida/axios causes build errors

Reproduction

Initialize SPA Remix App with npx create-remix@latest --template remix-run/remix/templates/spa
Install https://github.com/aspida/aspida with $ npm install aspida @aspida/axios axios
import aspida from "@aspida/axios"; and refer aspida in somewhere

Then, npm run build fails with SyntaxError: Cannot use import statement outside a module
Build Log
❯ npm run build

> build
> remix vite:build

vite v5.1.4 building for production...
✓ 127 modules transformed.
build/client/.vite/manifest.json                0.90 kB │ gzip:  0.26 kB
build/client/assets/root-Bk8PTQwa.js            1.51 kB │ gzip:  0.87 kB
build/client/assets/jsx-runtime-BlSqMCxk.js     8.09 kB │ gzip:  3.04 kB
build/client/assets/entry.client-BJ12z_Rq.js   14.04 kB │ gzip:  5.00 kB
build/client/assets/_index-BUOPZt3W.js         32.01 kB │ gzip: 12.82 kB
build/client/assets/components-t0vHlsCC.js    212.81 kB │ gzip: 68.85 kB
✓ built in 474ms
vite v5.1.4 building SSR bundle for production...
✓ 5 modules transformed.
build/server/.vite/manifest.json  0.13 kB
build/server/index.js             4.43 kB
(node:6057) Warning: To load an ES module, set "type": "module" in the package.json or use the .mjs extension.
(Use `node --trace-warnings ...` to show where the warning was created)
x Build failed in 31ms
/Users/kokuyouwind/tmp/remix-esm-test/node_modules/@aspida/axios/dist/esm/index.js:1
import { dataToURLString, optionToRequest, } from 'aspida';
^^^^^^

SyntaxError: Cannot use import statement outside a module
    at internalCompileFunction (node:internal/vm:77:18)
    at wrapSafe (node:internal/modules/cjs/loader:1290:20)
    at Module._compile (node:internal/modules/cjs/loader:1342:27)
    at Module._extensions..js (node:internal/modules/cjs/loader:1437:10)
    at Module.load (node:internal/modules/cjs/loader:1212:32)
    at Module._load (node:internal/modules/cjs/loader:1028:12)
    at cjsLoader (node:internal/modules/esm/translators:359:17)
    at ModuleWrap.<anonymous> (node:internal/modules/esm/translators:308:7)
    at ModuleJob.run (node:internal/modules/esm/module_job:218:25)
    at async ModuleLoader.import (node:internal/modules/esm/loader:323:24) {
  code: 'PLUGIN_ERROR',
  plugin: 'remix',
  hook: 'writeBundle'

Note that if SSR is enabled with remix({ ssr: true }, the build will complete without problems.
Build Log
❯ npm run build

> build
> remix vite:build

vite v5.1.4 building for production...
✓ 127 modules transformed.
build/client/.vite/manifest.json                0.90 kB │ gzip:  0.26 kB
build/client/assets/root-Bk8PTQwa.js            1.51 kB │ gzip:  0.87 kB
build/client/assets/jsx-runtime-BlSqMCxk.js     8.09 kB │ gzip:  3.04 kB
build/client/assets/entry.client-BJ12z_Rq.js   14.04 kB │ gzip:  5.00 kB
build/client/assets/_index-BUOPZt3W.js         32.01 kB │ gzip: 12.82 kB
build/client/assets/components-t0vHlsCC.js    212.81 kB │ gzip: 68.85 kB
✓ built in 483ms
vite v5.1.4 building SSR bundle for production...
✓ 5 modules transformed.
build/server/.vite/manifest.json  0.13 kB
build/server/index.js             4.43 kB
✓ built in 11ms

The complete reproduction code can be found at https://github.com/kokuyouwind/remix-spa-aspida.
System Info
System:
    OS: macOS 14.2.1
    CPU: (12) arm64 Apple M2 Pro
    Memory: 226.38 MB / 32.00 GB
    Shell: 5.9 - /bin/zsh
  Binaries:
    Node: 21.6.2 - ~/.asdf/installs/nodejs/21.6.2/bin/node
    Yarn: 1.22.19 - ~/.asdf/shims/yarn
    npm: 10.2.4 - ~/.asdf/plugins/nodejs/shims/npm
    bun: 1.0.3 - ~/.asdf/shims/bun
  Browsers:
    Chrome: 122.0.6261.69
    Safari: 17.2.1
  npmPackages:
    @remix-run/dev: ^2.8.0 => 2.8.0
    @remix-run/node: ^2.8.0 => 2.8.0
    @remix-run/react: ^2.8.0 => 2.8.0
    vite: ^5.1.0 => 5.1.4

Used Package Manager
npm
Expected Behavior
Build complete successfully.
Actual Behavior
Build failed.

I thought ESM Modules might be the cause, but @sindresorhus/slugify, which only provides ESM packages, does not seem to have the problem.
Also, specifying ["@aspida/axios"] or "all" in serverDependenciesToBundle did not solve the problem.

In @aspida/axios, instead of specifying the file path directly in exports in package.json, an object with the file path is set for each import and require.
Perhaps this is related to the problem.
❯ cat<EMAIL_ADDRESS>{
  "name": "@aspida/axios",
  "version": "1.14.0",
  "description": "axios client for aspida",
  "author": "Solufa<EMAIL_ADDRESS>  "license": "MIT",
  "main": "./dist/cjs/index.js",
  "module": "./dist/esm/index.js",
  "exports": {
    ".": {
      "require": "./dist/cjs/index.js",
      "import": "./dist/esm/index.js",
      "types": "./dist/esm/index.d.ts"
    },
    "./package.json": "./package.json"
  },
  // ...

For reference, @sindresorhus/slugify specifies the file path directly.
❯ cat<EMAIL_ADDRESS>{
	"name": "@sindresorhus/slugify",
	"version": "2.2.1",
	"description": "Slugify a string",
	"license": "MIT",
	"repository": "sindresorhus/slugify",
	"funding": "https://github.com/sponsors/sindresorhus",
	"author": {
		"name": "Sindre Sorhus",
		"email"<EMAIL_ADDRESS>		"url": "https://sindresorhus.com"
	},
	"type": "module",
	"exports": "./index.js",
        // ...

With vite, serverDependenciesToBundle is no longer used since vite has it's own ssr.noExternal config that you can use.  We're updating this to be enabled for all server deps out of the box in the template in https://github.com/remix-run/remix/pull/8928 but you can also take a more streamlined approach:
export default defineConfig({
  ssr: {
    noExternal: ["aspida", "@aspida/axios"],
  },
  plugins: [remix({ ssr: false }), tsconfigPaths()],
});

@brophdawg11
Thanks for the response!
I had not found the noExternal option. I did the suggested noExternal: ["aspida", "@aspida/axios"] and the build was successful.

On the other hand, noExternal: true seems to cause other problems.
When I run npx create-remix@latest --template remix-run/remix/templates/spa with the current code and then npm run build, I get the following error.
Build Log
❯ npm run build

> build
> remix vite:build

vite v5.1.4 building for production...
✓ 80 modules transformed.
build/client/.vite/manifest.json                0.90 kB │ gzip:  0.26 kB
build/client/assets/_index-sQQQDCbE.js          0.62 kB │ gzip:  0.36 kB
build/client/assets/root-Bk8PTQwa.js            1.51 kB │ gzip:  0.87 kB
build/client/assets/jsx-runtime-BlSqMCxk.js     8.09 kB │ gzip:  3.04 kB
build/client/assets/entry.client-BJ12z_Rq.js   14.04 kB │ gzip:  5.00 kB
build/client/assets/components-t0vHlsCC.js    212.81 kB │ gzip: 68.85 kB
✓ built in 431ms
vite v5.1.4 building SSR bundle for production...
✓ 6 modules transformed.
x Build failed in 20ms
Error [RollupError]: [commonjs--resolver] Cannot bundle Node.js built-in "stream" imported from "node_modules/react-dom/cjs/react-dom-server-legacy.node.production.min.js". Consider disabling ssr.noExternal or remove the built-in dependency.
file: /Users/kokuyou/tmp/remix-spa-test-2/node_modules/react-dom/server.node.js
    at getRollupEror (file:///Users/kokuyou/tmp/remix-spa-test-2/node_modules/rollup/dist/es/shared/parseAst.js:375:41)
    at error (file:///Users/kokuyou/tmp/remix-spa-test-2/node_modules/rollup/dist/es/shared/parseAst.js:372:42)
    at Object.error (file:///Users/kokuyou/tmp/remix-spa-test-2/node_modules/rollup/dist/es/shared/node-entry.js:19394:20)
    at Object.resolveId (file:///Users/kokuyou/tmp/remix-spa-test-2/node_modules/vite/dist/node/chunks/dep-jDlpJiMN.js:47584:34)
    at Object.handler (file:///Users/kokuyou/tmp/remix-spa-test-2/node_modules/vite/dist/node/chunks/dep-jDlpJiMN.js:67142:19)
    at file:///Users/kokuyou/tmp/remix-spa-test-2/node_modules/rollup/dist/es/shared/node-entry.js:19579:40
    at async PluginDriver.hookFirstAndGetPlugin (file:///Users/kokuyou/tmp/remix-spa-test-2/node_modules/rollup/dist/es/shared/node-entry.js:19479:28)
    at async resolveId (file:///Users/kokuyou/tmp/remix-spa-test-2/node_modules/rollup/dist/es/shared/node-entry.js:18149:26)
    at async ModuleLoader.resolveId (file:///Users/kokuyou/tmp/remix-spa-test-2/node_modules/rollup/dist/es/shared/node-entry.js:18563:15)
    at async file:///Users/kokuyou/tmp/remix-spa-test-2/node_modules/vite/dist/node/chunks/dep-jDlpJiMN.js:8368:16 {
  code: 'PLUGIN_ERROR',
  plugin: 'commonjs--resolver',
  hook: 'resolveId',
  id: '/Users/kokuyou/tmp/remix-spa-test-2/node_modules/react-dom/server.node.js',
  watchFiles: [
    '/Users/kokuyou/tmp/remix-spa-test-2/app/routes/_index.tsx',
    '/Users/kokuyou/tmp/remix-spa-test-2/app/root.tsx',
    '/Users/kokuyou/tmp/remix-spa-test-2/app/entry.server.tsx',
    '/Users/kokuyou/tmp/remix-spa-test-2/node_modules/react/jsx-runtime.js',
<EMAIL_ADDRESS>    '/Users/kokuyou/tmp/remix-spa-test-2/node_modules/react-dom/server.node.js',
    '/Users/kokuyou/tmp/remix-spa-test-2/node_modules/react/cjs/react-jsx-runtime.production.min.js',
    '/Users/kokuyou/tmp/remix-spa-test-2/node_modules/react/cjs/react-jsx-runtime.development.js',
    '/Users/kokuyou/tmp/remix-spa-test-2/node_modules/react-dom/cjs/react-dom-server-legacy.node.production.min.js'
  ]
}

I think it would be a good idea to set the default value in the template to noExternal: [] and add a comment to make it easier to add packages when needed.

Yeah we found that true was a bit too much and reverted that in https://github.com/remix-run/remix/pull/8952.  We'll probably just look to update the docs a bit to point to those options and let users decide how they want to configure their vite setup 👍


Error when running with babel-node

I prefer using babel for ES6. When I run the examples I see this
Uncaught SyntaxError: Unexpected token <

in my browser's console.

Ehm... strange... works now... closing ...


Korean Language Output

I am a South Korean user. The application I use has Korean output.
In asciinema, it is displayed normally as follows.

However, when converting this to gif using, it is not output normally as shown below.

Is there anyone who can solve it?

From what I see all the symbols are rendered correctly but they're overlapping, there's not enough room between them. This is due to lack of support for double-width text characters. In the web player this is handled by web browser's rendering engine, while here we'd need to implement detection of such double-width chars and adjust their placement accordingly.

You may want to use the unicode-width crate to get fine rendering result.
While you don't want to analyze the designated fonts directly, I think this way is the best.
https://crates.io/crates/unicode-width

I just upgraded avt version used by agg, which uses unicode-width. This will enable implementation of proper (better) rendering of double-width chars. Will try to get it into the upcoming agg release.

Not fixed even in main.
cargo run -- --font-family "UDEV Gothic NF"  $HOME/agg-test.txt $HOME/agg-test.gif

git log --oneline -1
e6e9602 (HEAD -> main, origin/main) Add docker image publish GH workflow

agg-test.txt
UDEV Gothic: https://github.com/yuru7/udev-gothic/releases

Any plans to fix this? I also need support for I can consider switching from vhs.

This has been fixed in 1.5.0 - https://github.com/asciinema/agg/releases/tag/v1.5.0

I updated the main and ran the same command.
Glad it's been fixed!

Great, thanks for the confirmation :+1:


fix: Timezone Form Styles

Description 📝

The timezone form on /profile/display had some unintended styling 🎨
Caused by https://github.com/linode/manager/pull/9341

Major Changes 🔄

Removes red background 🔴
Fixes incorrect marginTop 🔝

Preview 📷

Before
After

How to test 🧪

Test the timezone form on /profile/display

Is anyone else seeing this as well?
Screen.Recording.2023-08-21.at.2.52.38.PM.mov

That's really interesting... for me the popup with all the timezones has been appearing above the Timezone select, not below:

Theres also a weird gap for me as well @hana-linode


upcoming: [M3-7716] - Add session expiry confirmation dialog for proxy users

Description 📝
When a proxy user wants to switch back to their parent account, the parent account's authentication token must still be valid in order for them to switch back to the parent's account or log into any other proxy accounts displayed in the drawer.
If the parent token is not valid, a proxy user should be given adequate notice that they must re-log in to the parent account. We also will disabled the "Switch Account" buttons if this is the case.
Changes  🔄

Updated the useDialogContext.ts hook API. The original API was kind of rigid, whereas now we can have dynamic state that we can extend if we need to. The original references to open and closed and API still work, but I will clean that up after this PR.

useDialogContext({
    continueSession: false,
    isOpen: false,
});

Added SwitchAccountSessionDialog.tsx for when parent session expires
Added useParentTokenManagement.tsx for checking expiration and showing dialog. We still may need to poll the expiry or at least check every time the user menu opens or a user lands on the account page.
Improved isRestrictedGlobalGrantType to take into consideration account_access which can be null | 'read_only' | 'read_write'

Preview 📷

Screenshots

How to test 🧪
Should NOT show session expired dialog
Prerequisites

Turn on MSW and Parent/Child feature flag
By default you should be a parent user, if not, update: serverHandlers

Reproduction steps

Open user menu
Click Switch Account button
Select a child company

Verification steps

Observe parent/proxy tokens are created in local storage
Set user_type to proxy in serverHandlers
Observe no dialog appears since we have an active parent token

Should show session expired dialog
Prerequisites

Clear application cookies
Turn on MSW and Parent/Child feature flag
Set user_type to proxy in serverHandlers

Reproduction steps

Since there is no parent token defined, it's invalid and you should see the dialog

Verification steps

Close the dialog and observe that it should not appear again
Observe that both "Switch Account" buttons in user menu and account page are disabled

As an Author I have considered 🤔
Check all that apply

[x] 👀 Doing a self review
[x] ❔ Our contribution guidelines
[x] 🤏 Splitting feature into small PRs
[x] ➕ Adding a changeset
[x] 🧪 Providing/Improving test coverage
[x] 🔐 Removing all sensitive information from the code and PR description
[x] 🚩 Using a feature flag to protect the release
[x] 👣 Providing comprehensive reproduction steps
[x] 📑 Providing or updating our documentation
[ ] 🕛 Scheduling a pair reviewing session
[ ] 📱 Providing mobile support
[x] ♿  Providing accessibility support

If a user is able to continue working on an account with an expired parent token, I think it would make more sense to only display this dialog when they try to switch accounts?

The goal was to prevent users from attempting to switch accounts once the token expired - so the Switch Account button would be disabled at expiry. I'll spend some more time thinking about the UX, but that was the intention.

@jaalah What if we don't disable the Switch Account button at expiry but just have it open the session expiry confirmation dialog instead? That way the dialog doesn't display when the user isn't trying to switch accounts but still prevents users from switching accounts

@hana-linode 🙌
https://github.com/linode/manager/assets/125309814/89b8e234-67a5-4721-9a9a-abab533e02e7

I'm keeping things in context because we're most likely going to implement a way to refresh parent tokens as expiry nears an end, so I'll swap the dialog and save me some work.

Liking this flow a lot better. I was thinking we can keep the Switch Account buttons enabled even after the user hits close
https://github.com/linode/manager/assets/115299789/78ce7a91-e089-48b1-926f-ac0e33f1c833

@hana-linode @mjac0bs ✅ thanks for feedback!


Use scope name instead of scope tensor in output collections

Start from version r0.11, because of the change in variable_scope function, it breaks the collect_named_output function. Instead of using scope tensor, use scope.orignal_name_scope.

Can one of the admins verify this patch?


Fix a couple unsplay icon renderings

Seattle and Warsaw are supposed to have unsplay not junk icons. I checked the DB and the correct icon is there so this is a SCSS issue.

Oh this is actually just an issue with the image file!


image ls to return familiar names

This allows ImageList AP to return familiar image names (without docker.io/library registry/repository prefix)
While docker CLI do familiarize reference, Docker Desktop UI doesn't

While docker CLI do familiarize reference, Docker Desktop UI doesn't

FWIW, I think we should consider to make Docker Desktop UI also normalise; I know Docker always stripped the docker.io/[library/] prefixes, and we should continue to allow using the short names for users, but it would be nice if we make this more of a "presentation" thing, where the API would return the canonical / fully-qualified name, allowing clients to decide how to present them.
That's a separate discussion though; this PR is doing the right thing by keeping the existing behaviour 👍

@thaJeztah Agree. I was surprised this is managed by engine, and not just by clients

@ndeloof yeah; this was for historic reasons (ubuntu:latest was the "canonical" example of how easy it was to use docker; originally no docker.io/.. existed, so part of that was to keep the API backward compatible I think, and the other part was to keep ubuntu:latest ubuntu:latest without "polluting" it with the registry prefix.


Android - Compose-Paste multiline message, cursor behavior inconsistent in mweb & android when scroll

If you haven’t already, check out our contributing guidelines for onboarding and email<EMAIL_ADDRESS>to request to join our Slack channel!

Action Performed:

Go to https://staging.new.expensify.com/

Tap on a report

Paste on compose box -
~d, bhgfh, hugfg ghjgkkhhjj
g
h
h~

|•||•••

√√√√

√√√√√√√√√
4.Scroll up and down and note cursor stays at end point
5.Launch app
6.Tap on a report
7. Paste on compose box -
~d, bhgfh, hugfg ghjgkkhhjj
g
h
h~

|•||•••

√√√√

√√√√√√√√√
8.Scroll up and down
Expected Result:
When user scrolls up and down, cursor behaviour must be consistent in both mweb and android
Actual Result:
When we paste multiline message, cursor behavior is inconsistent in mweb and android, when we scroll up and down
Workaround:
Unknown
Platforms:

Which of our officially supported platforms is this issue occurring on?

[ ] Android / native
[ ] Android / Chrome
[ ] iOS / native
[ ] iOS / Safari
[ ] MacOS / Chrome / Safari
[ ] MacOS / Desktop

Version Number: 1.3.78-0
Reproducible in staging?: Yes
Reproducible in production?: Yes
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation
https://github.com/Expensify/App/assets/78819774/5a116c7f-5b3b-4a7e-b724-3e30d170f540
Expensify/Expensify Issue URL:
Issue reported by: Applause - Internal Team
Slack conversation:
View all open jobs on GitHub

Are you saying this isn't a bug @bernhardoj ?


Enable/Disable plugin with firejail enabled fails

Bug Short Description:
Enabling a plugin while firejail is active crashes the program.
Operating System:
Choose 1 or more. Mark the checkbox it with an X.

[X] GNU/Linux.
[ ] Apple Os X.
[ ] Microsoft Windows.
[ ] Other or Unknown or Unsupported.

Bug Severity:
Choose only 1. Mark the checkbox it with an X.

[ ] Low, Minor, Aesthetic, Small, Detail, Trivial.
[ ] Medium, Normal, Standard.
[X] High, Important, Major.
[ ] Critical, Catastrophic, Epic Fail.
[ ] Other or Unknown.

Version
Semantic Version of this software the Bug Reproduces into. Type in the Version Number
    5.0.0

Workarounds:
Any Workarounds you have tried. Choose none or one or more. Mark the checkbox it with an X.

[ ] Uninstalling and Reinstalling, Reloading, Rebooting, Restarting, etc.
[ ] Run as Administrator, Run as root, Run as different user, etc.
[ ] Run on another computer, Run on a Virtual Machine, Run on another OS, etc.

/home/user/.nimble/pkgs/firejail-0.5.0/firejail.nim
Comment out fea = and let firejailFeatures =

   #fea = "{" & v.normalize.split("compile time support:")[1].multiReplace(
   #  ("disabled", "false,"), ("enabled", "true,"),
   #  (" support is ", "\": " ), ("- ", " \"" ), ("-", "_" )) & "}"
   enUsUtf8 = "--env=LC_" & [
    "CTYPE='$1'", "NUMERIC='$1'", "TIME='$1'", "COLLATE='$1'", "MONETARY='$1'",
    "MESSAGES='$1'", "PAPER='$1'", "NAME='$1'", "ADDRESS='$1'", "TELEPHONE='$1'",
    "MEASUREMENT='$1'", "IDENTIFICATION='$1'", "ALL='$1'",
    ].join(" --env=LC_").format("en_US.UTF-8") & " --env=LANG='en_US.UTF-8'"

let firejailFeatures* = ""#parseJson(fea)  ## Features available on the Firejails.

Comment out firejail feature info in serverinfo.tmpl and firejail.tmpl

Steps to reproduce:

Download a plugin

Go to plugin page and enable

program recompiles

Crash

Actual Output:
Hint: firejail [Processing]
stack trace: (most recent call last)
../../../../.nimble/pkgs/firejail-0.5.0/firejail.nim(14)
/home/user/.nimble/pkgs/firejail-0.5.0/firejail.nim(14, 57) Error: index out of bounds
E, [2019-03-02T15:40:49] -- nimwc_main: nimwc_main.nim(582)      nimwc_main
jester.nim(476)          serve
httpbeast.nim(414)       run
httpbeast.nim(287)       eventLoop
httpbeast.nim(219)       processEvents
jester.nim(475)          :anonymous
jester.nim(380)          handleRequest
asyncmacro.nim(313)      dispatch
asyncmacro.nim(36)       dispatch_continue
jester.nim(281)          dispatchIter
asyncmacro.nim(313)      match
asyncmacro.nim(36)       match_continue
macros.nim(570)          matchIter
nimwc_main.nim(264)      recompile
os.nim(692)              moveFile
os.nim(685)              tryMoveFSObject
oserr.nim(66)            raiseOSError
[[reraised from:
nimwc_main.nim(582)      nimwc_main
jester.nim(476)          serve
httpbeast.nim(414)       run
httpbeast.nim(287)       eventLoop
httpbeast.nim(219)       processEvents
jester.nim(475)          :anonymous
jester.nim(380)          handleRequest
asyncmacro.nim(313)      dispatch
asyncmacro.nim(39)       dispatch_continue
jester.nim(281)          dispatchIter
asyncfutures.nim(302)    read
]]
[[reraised from:
nimwc_main.nim(582)      nimwc_main
jester.nim(476)          serve
httpbeast.nim(414)       run
httpbeast.nim(287)       eventLoop
httpbeast.nim(219)       processEvents
jester.nim(475)          :anonymous
jester.nim(380)          handleRequest
asyncmacro.nim(313)      handleRequestSlow
asyncmacro.nim(39)       handleRequestSlow_continue
jester.nim(330)          handleRequestSlowIter
asyncfutures.nim(302)    read
]]
No such file or directory; Additional info: "No such file or directory"
Async traceback:
  nimwc_main.nim(582)   nimwc_main
  jester.nim(476)       serve
  httpbeast.nim(414)    run
  httpbeast.nim(287)    eventLoop
  httpbeast.nim(219)    processEvents
  jester.nim(475)       :anonymous
  jester.nim(380)       handleRequest
  asyncmacro.nim(313)   dispatch
  asyncmacro.nim(36)    dispatch_continue
    ## Resumes an async procedure
  jester.nim(281)       dispatchIter
  asyncmacro.nim(313)   match
  asyncmacro.nim(36)    match_continue
    ## Resumes an async procedure
  macros.nim(570)       matchIter
  nimwc_main.nim(264)   recompile
  os.nim(692)           moveFile
  os.nim(685)           tryMoveFSObject
  oserr.nim(66)         raiseOSError
  #[
    nimwc_main.nim(582)   nimwc_main
    jester.nim(476)       serve
    httpbeast.nim(414)    run
    httpbeast.nim(287)    eventLoop
    httpbeast.nim(219)    processEvents
    jester.nim(475)       :anonymous
    jester.nim(380)       handleRequest
    asyncmacro.nim(313)   dispatch
    asyncmacro.nim(39)    dispatch_continue
      ## Resumes an async procedure
    jester.nim(281)       dispatchIter
    asyncfutures.nim(302) read
  ]#
Exception message: No such file or directory; Additional info: "No such file or directory"
Exception type:
D, [2019-03-02T15:40:49] -- nimwc_main:   502 Bad Gateway {"content-type": @["text/html;charset=utf-8"]}

Expected Output:
NimWC starts again

"No such file or directory" are the folder tree of the plugins getting created properly?.
Thats weird, but can be fixed with an inline try except on the variable.

The plugin is downloaded correct. It is during the recompiling with recompile*(). I can easily compile it myself with using -d:rc on the nimwc.nim instead.
https://github.com/ThomasTJdev/nim_websitecreator/blob/master/nimwcpkg/nimwc_main.nim#L261-L265

This should be Fixed now.
:slightly_smiling_face:

https://github.com/juancarlospaco/nim-firejail/pull/4


Godex does not compile with float=64

It's a new master branch feature.
error given:
godex\modules\bullet_physics\overlap_check.cpp(27): error C2664: 'void btConvexShape::project(const btTransform &,const btVector3 &,btScalar &,btScalar &,btVector3 &,btVector3 &) const': cannot convert argument 3 from 'real_t' to 'btScalar &'
godot\thirdparty\bullet\BulletCollision\CollisionShapes\btConvexShape.h(53): note: see declaration of 'btConvexShape::project'
godex\modules\bullet_physics\overlap_check.cpp(758): error C2259: 'overlap_check_polyhedron_polyhedron::NoRes': cannot instantiate abstract class
godex\modules\bullet_physics\overlap_check.cpp(754): note: see declaration of 'overlap_check_polyhedron_polyhedron::NoRes'
godex\modules\bullet_physics\overlap_check.cpp(758): note: due to following members:
godex\modules\bullet_physics\overlap_check.cpp(758): note: 'void btDiscreteCollisionDetectorInterface::Result::addContactPoint(const btVector3 &,const btVector3 &,btScalar)': is abstract
godot\thirdparty\bullet\BulletCollision\NarrowPhaseCollision\btDiscreteCollisionDetectorInterface.h(36): note: see declaration of 'btDiscreteCollisionDetectorInterface::Result::addContactPoint'
systems_base.cpp

maybe btScalar should react to the same flag instead of a custom one?

Yes, bullet should be compiled using double. This should fix the issue.

This should be easily fixable, by adding the proper macro on the bullet module SCsub, in godex. Right now I don't remember the macro name though. I'll check it later.

Yes, I think we just need to append this: https://github.com/godotengine/godot/blob/master/modules/bullet/SCsub#L15-L16

Still having problems after adding those two lines in godex scons:
[Initial build] godex\modules\bullet_physics\overlap_check.cpp(27): error C2664: 'void btConvexShape::project(const btTransform &,const btVector3 &,btScalar &,btScalar &,btVector3 &,btVector3 &) const': cannot convert argument 3 from 'real_t' to 'btScalar &'
[Initial build] godot\thirdparty\bullet\BulletCollision\CollisionShapes\btConvexShape.h(53): note: see declaration of 'btConvexShape::project'Compiling ==> godex\modules\bullet_physics\systems_walk.cpp

systems_base.cpp
godex\modules\bullet_physics\overlap_check.cpp(758): error C2259: 'overlap_check_polyhedron_polyhedron::NoRes': cannot instantiate abstract class
godex\modules\bullet_physics\overlap_check.cpp(754): note: see declaration of 'overlap_check_polyhedron_polyhedron::NoRes'systems_walk.cpp

godex\modules\bullet_physics\overlap_check.cpp(758): note: due to following members:
godex\modules\bullet_physics\overlap_check.cpp(758): note: 'void btDiscreteCollisionDetectorInterface::Result::addContactPoint(const btVector3 &,const btVector3 &,btScalar)': is abstract
godot\thirdparty\bullet\BulletCollision\NarrowPhaseCollision\btDiscreteCollisionDetectorInterface.h(36): note: see declaration of 'btDiscreteCollisionDetectorInterface::Result::addContactPoint'

It is still not solved.

@RicardRC I've updated godot_godex, and noticed that your PR got merged: https://github.com/GodotECS/godot/commits/godex_version
Please let me know if this is now fixed.

Yep! Together with the pull request that I just opened, it now compiles.


Put restarted tasks in READY state

We used to put restarted tasks in READY state. This makes sense because
then they can go ahead and pull an image while we wait for the restart
delay to elapse. However, #715 changed the restart supervisor to put
restarted tasks into ACCEPTED to work around a tight restart loop when
an image doesn't exist. The problem was that the task would fail
immediately, leading the orchestrator to request a new restart, which
would cancel the ongoing restart delay.
As a better fix for this, put tasks in READY, but when a restart is
requested and there is already one in progress for the old task, we wait
for that restart to complete before starting the new one.
cc @aluzzardi @dongluochen

[Current coverage][cc-pull] is 54.81%

Merging [#1199][cc-pull] into [master][cc-base-branch] will decrease coverage by 0.20%

@@             master      #1199   diff @@
==========================================
  Files            77         77
  Lines         12190      12211    +21
  Methods           0          0
  Messages          0          0
  Branches          0          0
==========================================
- Hits           6708       6694    -14
- Misses         4564       4591    +27
- Partials        918        926     +8

[][cc-pull]

Powered by Codecov. Last updated by [beb9c87...f6fc2ed][cc-compare]
[cc-base-branch]: https://codecov.io/gh/docker/swarmkit/branch/master?src=pr
[cc-compare]: https://codecov.io/gh/docker/swarmkit/compare/beb9c87298dd212c410f7999c3247851858b9a55...f6fc2ed7358da304afc08cc407be29a5f6cb467d?src=pr
[cc-pull]: https://codecov.io/gh/docker/swarmkit/pull/1199?src=pr

LGTM
I'm sure you already did, but this PR needs a bunch of manual testing since it's in the middle of the critical path so close to GA and it's a very subtle code base.

Agreed. Here's the manual testing I did before submitting it:

Created a replicated service which references a nonexistent image. Observed that it respects the restart delay instead of restarting the replicas in a tight loop.
Created a replicated service that runs successfully, then did a few rolling updates with good and bad images and commands. The restart delay was always respected.

I just repeated the tests with a global service, and things look good in that case as well.

LGTM when @dongluochen comment gets addressed

Added protection against multiple goroutines being launched for the same task.
PTAL

LGTM


Fix using existing secret, set api_key only over secrets

This pull request fixes #17.  It removes checks for whether secrets set in values, since those can come from existingSecret.
We can't automatically fill secrets with random values (since redis_address will be simply invalid in this case, or redis_password will always be used while auth not configured in Redis). To deal with this we use optional flag of secretKeyRef section. Environment variables will be set but will contain empty values. Empty values in environment variables not handled by Centrifugo thus configuration won't be corrupted if values are set in .Values.config. Ideally would be awesome to not include env vars to pod at all if secret is empty – but don't know a way to do this (maybe with lookup func?).
I also made api_key to be generated automatically to random value. This makes api_key to be defined only over secrets since env vars have higher priority in configuration resolution than .Values.config. While this seems a good thing in general (as api_key is really a secret thing) this can break existing installs that use plain api_key in .Values.config. Thus chart version got a major version update – v8.0.0.

Stepped back with autogenerating api_key as helm will change it on every update. Looks like this can lead to hard to investigate problems in Centrifugo integration.


Don't skip py3k, change run reqs

Hi! This is the friendly automated conda-forge-linting service.
I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.


Create BaseCommandResponse trait

@pcross616 @stotten @ladinu @malibuworkcrew @davis20 @mjwallin1
Change Commands to return instances of a trait instead of a case class.

So the only bummer about this is that it will break all our services that are currently using commands as they will need to change their execute methods and maybe even the content of said methods. So it was definitely necessary to change to this trait?

Specifically common-collection and the whole sift stack, as it will even break services that are using the commands but not wookiee-spray

@malibuworkcrew The command logic uses the new BaseCommandResponse trait but individual commands can still use the CommandResponse since it now implements that trait. No required code changes was one of the major considerations in going this route.
Unfortunately, there will be the need to spin a new build of all the components that use discoverable commands since the class serialization version changes, but the code should be fully backward compatible.

Aha, I see. Cool, well as long as everything using commands still works then in that case I am cool with this.

@Kraagen I'm building new release, should be done in a couple minutes, it is 1.1.3, will likely have to bump in wookiee-spray


Update .nvmrc

The Node.js team has announced that a high severity remote Denial of Service (DoS) Constant Hashtable Seeds vulnerability in Node.js versions 4.x through 8.x has been patched in the following versions:
4.8.4
6.11.1
7.10.1
8.1.4
Updating to 6.11.1.
Thanks for contributing to Terra.
@cerner/terra

Found another place this needs updating, the package.json file.


feat: adding security context to e2e test pods

For security reasons we should specify at least the following options:

allowPrivilegeEscalation
secCompProfile
runAsNonRoot

All of these in the SecurityContext section of the pods
Closes #796
Signed-off-by: Jonathan Gonzalez V<EMAIL_ADDRESS>

/test


Sample: AutoGen and Vertex AI

After research, decided not to bother. It doesn't seem like a good framework.


Create common Result class

Create unified response object, which could be used in any service, can contain errors and any data.

Published first edition.
Have to check necessary of TASK in Result.cs


Go Version of Restore-DbaBackup work

Fixes #
Changes proposed in this pull request:
Implements the following abilities for Restore-DbaBackup:
PointInTime restore
Obtain files from directory, Ola style directory, user generated file objects and xp_DirTree
Rename Logical Files (copes with filegroups and any number of files)
Variable CaPiTilisation should be correct now
How to test this code:

[ ]
[ ]

Has been tested on minimum requirements:

[ ]  Powershell 3
[ ]  Windows 7
[ ]  SQL Server 2000

Has been tested on maximum requirements:

[ ]  SQL Server vNext
[ ]  Windows 10
[ ]  Azure Database

Tests for tester:

[ ] Working/useful help content, including link to command on dbatools web site
[ ] All examples work as advertised
[ ] Does not contain template content
[ ] Does not contain excessive/unnecessary amounts of comments
[ ] Works remotely
[ ] Works locally
[ ] Works on lower versions or throws error specifying version not supported
[ ] Works with named instances
[ ] Works with clustered instances
[ ] Handles offline/read only databases
[ ] Supports multiple servers (at the command line or piped from Get-SqlRegisteredServerName)
[ ] No un-handled errors which stop the command working with multiple servers

Appveyor is complaining about some Pester tests I added to the Tests folder.
They happily pass locally, so guessing they'll need fixing for Appveyor.
Want me to remove them for the PR?

I'm currently in the middle of a huge overhaul. It will complain for the next few days, unfortunately. It's likely not your own commands.
There were a couple issues with the PR, however -- each of your PRs have been directly to master, and so I edit them to point to development. They should be PRd into development, always.
Also, the number of files is very high. It will take a lot longer for whoever is testing to change them. We prefer them in smaller batches, though I understand sometimes that isn't possible -- I'm about to modify about 50 commands myself.

:(  Sorry about that, trying to do PRs while packing for a trip.
Want me to split them as seperate PRs and resubmit? Problem is they all hang together eventually. But could submit all the 'hidden' stuff, and then the public one last so if something doesn't make it, end users won't notice?

No problem! I appreciate your work. It looks like there were a few unrelated changes somehow. I believe this may have been caused by not syncing the branch prior to the PR? Looks like it would be best to close PR and redo with only the required changes.
I fear that a really large PR will hold up the process for you to go forward. i would divide into workable chunks if that's possible.
Thanks for your patience while we work all of this out!

closing to resubmit smaller requests.


Sign Editing feature is calling a client only method on server

@Morpheus1101 reported this in comment thread of different issue
Morpheus1101 commented 2 days ago
On a different note but still server console spam on the MMD-Dev server i noticed this:
https://puu.sh/t2bSE/a0a6111d75.txt

:D

Fixed in 1.9.9 https://minecraft.curseforge.com/projects/cyclic/files/2361605


Update to transparent favicon

Summary
Use same favicon as is used on Sphinx site (closes #29)
Impact
Website favicon
Testing
CI

As I mentioned in the issue favicons are heavily cached so it may take a while before people see a change.

No problem, not really critical. I just tested force reloading on Firefox (CTRL+SHIFT+R) and it shows the new icon.


Video Tutorial for iOS Install and Setup

Hey Everybody,
For someone with rudimentary programming knowledge, figuring out how to install this module, recompile it for iOS, and configure the Xcode project was tough, so I made this video tutorial on getting it installed!
https://www.youtube.com/watch?v=s5sNrOM3Oeo
I figured I wasn't the only person in that boat, so I hope this helps some people! The video goes through how to install the module and recompile Godot to use it. It also goes through configuring the Xcode project file and an example using the module in code.
Please leave the video a like and leave a comment if you can!

Can I put this on readme? Very cool

@gustavottc Absolutely!


[metrics sdk]: verify and enforce attribute limits

At this time, metric attributes are expected to use the same limits as the common attributes (trace):

sdk attribute limits spec: https://github.com/open-telemetry/opentelemetry-specification/blob/main/specification/metrics/sdk.md#attribute-limits
attribute limits spec: https://github.com/open-telemetry/opentelemetry-specification/blob/main/specification/common/common.md#attribute-limits

At this time, the linked spec document mentions that metric attributes are exempt from the common rules of attribute limits. So I guess this is not needed right now.


Init Flows on new files in function of folder

[x] Asign init flow in function of folder
[x] Default flow in case you want to enable it

Its all working.
We need autoupdate for canvas config names in case of move or delete folders and this feature will be published


Ship.io

API: https://app.ship.io/api
Sample badge:

Thanks for the suggestion!
Dealing with authentication will be inconvenient. The user's authentication token is meant to be private.

Here's a direct link to the image:
https://app.ship.io/jobs/7oIHDz28rgdvceSO/build_status.png

Unfortunately, they don't leak information in the HTTP headers, either.

They are closing down, so I guess the point is moot.
https://ship.io/ship-io-is-shutting-down/


[Snyk] Upgrade firebase from 9.19.1 to 9.21.0

This PR was automatically created by Snyk using the credentials of a real user.Snyk has created this PR to upgrade firebase from 9.19.1 to 9.21.0.
:information_source: Keep your dependencies up-to-date. This makes it easier to fix existing vulnerabilities and to more quickly identify and fix newly disclosed vulnerabilities when they affect your project.

The recommended version is 43 versions ahead of your current version.
The recommended version was released a month ago, on 2023-04-27.

Note: You are seeing this because you or someone else with access to this repository has authorized Snyk to open upgrade PRs.
For more information:
🧐 View latest project report
🛠 Adjust upgrade PR settings
🔕 Ignore this dependency or unsubscribe from future upgrade PRs

Codecov Report
Patch and project coverage have no change.

Comparison is base (c100c17) 79.40% compared to head (b61f61e) 79.40%.

:exclamation: Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.
Additional details and impacted files
@@           Coverage Diff           @@
##             main     #629   +/-   ##
=======================================
  Coverage   79.40%   79.40%
=======================================
  Files          31       31
  Lines         369      369
  Branches       60       60
=======================================
  Hits          293      293
  Misses         70       70
  Partials        6        6

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.


Package.json main entry missing.

Subject of the issue
It appears that the packack.json main entry should be updated. It looks like the structure existed in a previous release: 15.1, but not currently.
Your environment
Any.
Steps to reproduce
Expected behaviour
The main entry points to the main file that should be loaded, when the package is required/imported.
Actual behaviour
Any require/import fails, when using package name.

the dist folder is created in the release-process and is not part of the actual repository. we generate it automatically with our build script.
what the underlying problem you are trying to solve?
Will close for now. Feel free to ask further questions regarding this topic here. We can re-open if required.

If I did the following I would have a problem, because the main key/value doesn't exist until it is built:
npm i jquery-validation --save
and then in a main.js, for instance, I would
import "jquery-validation"; or require('jquery-validation');
Is this node package now intended for someone that plans on contributing, because I was able to do this with a previous version?
Maybe I am missing something.
Also... If I wanted to use a relative path, would this be the file that I point to: https://github.com/jzaefferer/jquery-validation/blob/master/src/core.js
Thanks.


Error TitleBar

Hello \ o /!
Good afternoon!
I'm using this component and when I create multiple Popups, all Popups use the same "titlebar" declared in the last "PopupboxContainer."
Can you help me?
Obs: I like this component very much xD.

Hi!
First of all, thank you for giving Popupbox a try!
For the usage, there should be only one instance of PopupboxContainer in an app.
Once the PopupboxContainer has been initialized, there are a few methods in PopupboxManager that can override the default title and content via providing specific configs.
If there is a need to have different title text each time, please provide the config.titleBar props when every time calling
the PopupboxManager.open().
For example:
    openPopupbox() {       const content = <img url="static/demo.jpg" />       PopupboxManager.open({         content,         config: {           titleBar: {             enable: true,             text: 'Meow!'           },           fadeIn: true,           fadeInSpeed: 500         }       })     }
Please feel free to let me know if there is any other issue. :)


Support browsing and installing plugin presets

Relates to: https://github.com/studiorack/studiorack-site/issues/5

This feature has been built into the replacement registry at https://github.com/open-audio-stack/open-audio-stack-registry


How can we get notified when a Kafka Consumer is rebalanced?

The title says it all.

Hmm... SingleSourceStageLogic as well as some other stage base classes have virtual AddToPartitionAssignmentHandler method which allows to customize handling of rebalance events.
So in theory, someone could override this logic with own implementation to override this method, and then override required stage (i.e. PlainSourceStage) to use this new logic implementation, and create another method like KafkaConsumer.MyPlainSource to be able to pass additional handling parameters...
But that would require SingleSourceStageLogic to be public, since it is internal now.
@ayoung Does this make sense for you? I mean, probably we could make that class public so that everyone could extent it like I described above to be able to handle rebalance events. If this is clear enough to go.
But I doubt that there is another handy way to allow what you need.

I'm not real familiar with the internals of this library so: does it make sense to me? No. 😉 But yes, some extensibility points would be helpful here. We are using this library to stream events from IoT devices and we create shadow actors to keep track of the state of these devices as events are streamed in from the source. If the consumers get rebalanced, we would like to about this so that we can remove all the shadow actors and start empty.

I'm looking at the source a little closer. Even if we inherit from SingleSourceStageLogic, how do we change the stage classes (i.e. SourceWithOffsetContextStage) to use the super class? These classes are hard coded to use SingleSourceStageLogic.

I think we will need to make SourceWithOffsetContextStage and other stages public classes, so that you could inherit from it and override AddToPartitionAssignmentHandler there.

@IgorFedchenko I tried what you suggested. Made the SourceWithOffsetContextStage public along with their friends. It also required me to make CommittableSourceStage public. While, I do think that this would work, it makes the API for extending functionality just not that great. First I would have to inherit from SourceWithOffsetContextStage, then also inherit from CommittableSourceStage to override the Logic() function. Not only that but I would have to know about how to instantiate my CustomSourceWithOffsetContextStage and know the consequences of not implementing the GetMessageBuilder() correctly. Of course, I could just copy/paste the code to my superclass but MEH! People doing this would need to know too much of the internals to extend the functionality which is why I think you made these classes internal in the first place.
My opinion here is that SingleSourceStageLogic should provide an option to wait for the stream to drain when partitions get revoked and optionally accept some kind of callback/notification when this happens. It is quite a common thing in Kafka consuming applications to need to purge state when consumers get rebalanced -- I'm surprised that this functionality isn't just built in.
If you agree, I can try to go that direction.

Any feedback on this?

@IgorFedchenko should be getting back to you soon @ayoung

@ayoung Sorry for a big delay here.
So you are right, and this feature is something that should be built it - and that's what original Alpakka Kafka project have added in version 2.0.0 after this port was actually finished.
I have added separate issue for this: https://github.com/akkadotnet/Akka.Streams.Kafka/issues/149 Once it is resolved, you should be able to handle assign/revoke events with your IPartitionEventHandler implementation (this interface is internal now, so going to make it public).

So I am going to add support for this in next few days.

Thank you. Looking forward to this.

@IgorFedchenko I don't believe we have nightly build support for Akka.Streams.Kafka but it should be easy to add it

Thank you @IgorFedchenko. See comment/question in the PR.

@IgorFedchenko @ayoung is this resolved? added it to the current sprint beginning tomorrow.

I think we have very detailed discussion in assigned PR (https://github.com/akkadotnet/Akka.Streams.Kafka/pull/154), and this issue is resolved - there is a way to get notified when consumer is rebalanced.


TST: test_arnoldi prone to 32-bit Windows failures

test_arnoldi is prone to failure on 32-bit Windows / Python 3.6 as noted. I've observed this in my own work on other branches too.
  Under the hood, choice ends up constructing a dense array of the same size explicitly, in np.random.permutation. That takes 0.8 GB for int64. That then goes on to np.random.shuffle, which creates some extra buffers. The MemoryError seems to be simply because we're pushing the 2 GB limit on 32-bit Python. I'll adjust the test.

I'm reopening this because the patch was only applied to one of the two tests prone to failure -- it may be as simple as applying the same fix to the second of the tests above.
Specifically, TestLGMRES.test_arnoldi is still prone to failure as recently observed in a PR that includes Ralf's fix.
If the tests are this similar it may make sense to abstract the shared logic at some point, but probably out of scope for a likely simple fix needed for the second case for now.

Hmm, identical test in two different files, didn't spot that. Next fix in gh-9617.


non-physical radical counts being preserved

Describe the bug
Sanitization is leaving radicals on molecules where they don't make sense.
To Reproduce
In [8]: Chem.MolFromSmiles('[NH4+] |^1:0|').Debug()
Atoms:
	0 7 N chg: 1  deg: 0 exp: 4 imp: 0 hyb: 4 arom?: 0 chi: 0 rad: 1
Bonds:

In [9]: Chem.MolFromSmiles('[CH4] |^1:0|').Debug()
Atoms:
	0 6 C chg: 0  deg: 0 exp: 4 imp: 0 hyb: 4 arom?: 0 chi: 0 rad: 1
Bonds:

Neither of those should have a radical on it.
Configuration (please complete the following information):

RDKit version: all
OS: all

I'd like to take a crack at this issue if no one else is currently working on it.

@MarioAndWario I'm very sorry for how long it took for me to review this.


Test for invalid angle before converting

Currently, if you specify an angle > 20 it will error as the angle is converted before it's tested for validity.

Thanks, sorry it took so long to merge.


New version: XMediaRecode.XMediaRecode version <IP_ADDRESS>

Created by 🥟 Dumplings.
Microsoft Reviewers: Open in CodeFlow

https://github.com/microsoft/winget-pkgs/issues/142854


Automator: update istio/client-go@master dependency in istio/istio@master

Generated by Automator - 2021-11-01T18:59:46+00:00

@istio-testing: PR needs rebase.

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.


Build(deps-dev): Bump typescript from 4.7.4 to 4.8.2 (#3952)

Pull request opened by the merge tool on behalf of #3952

Merged in ec3af9b1ec087529ff75fe5bd634499efb608cef


Internal Server Error if Referer is missing in request to /get-link

I think that the use of the Referer header in the backend code should be removed completely.
curl www.jsonstore.io/get-link
<!DOCTYPE html>

<meta charset="utf-8">
<title>Error</title>

Internal Server Error

The backend should not depend on the client to send a valid Referer header:
curl -H 'Referer: http://bogus.url' www.jsonstore.io/get-link
{"link":"http://bogus.url/fbbee72d1ac49a589480c578963aa13f71d53416510bdfd87974f300aa886282/"}

Thanks for reporting, will have a look soon.

It might be preferable to use the Host header to construct the link, instead of Referer. Host is mandatory in HTTP/1.1.
Also, it think it would be useful to have an optional prefix to all the URLs,  so someone can host jsonstore at a different endpoint other than the base, like http://www.example.com/jsonstore/get-link

I don't think that any header should be used. Instead the base URL should be loaded from an environment variable. https://12factor.net/config

That logic can be moved to the client, which is aware of the endpoint at which the API exists.

Using an environment variables seems like a good idea. We can bootstrap that variable (base url) into the client while building for different environments.

@bluzi thinking about using a .env, moving firebase config into it as well.

@akshendra solved this by changing /get-link to /get-token. It's already deployed.


[WIP] src/v2/guide/reactivity.md

First translation

Close this one in favor of adapting v3 doc repo .


Static camera + Moving Object?

Hi,
Impressive work. We were wondering if the method also works with a static/non-moving camera with a moving object instead? Like to have the turn table rotate the object, and get the point cloud from a static camera meanwhile. Can we use this approach to model objects for instance?
P.S: Assuming a working TF tree between the camera-world-turn-table.

We assume the mapped area is static, however this use case could probably be supported just by setting the world frame to the objects pose, as from the objects perspective you still have a static object and moving camera.


Exclude deprecated SPACING constant from story

This excludes the deprecated SPACING constant from the story to avoid confusion.
I also filtered out the base property from SPACER since we should be only be using medium. I've seen some confusion over that.
I haven't looked if SPACING or base are still in use in the other repos (is/was base ever used?), this was just a quick patch so folks aren't using the wrong ones. Might be time to just pull them out completely.

@daigof I think I'm actually just gonna close this PR and go ahead and remove the constants. Seems silly to patch/hide it instead of just getting rid of them 😅.
I'll do another check on everything so we're sure they're not used anywhere.

AWESOME yeah that sounds good, I dont remeber why I left SPACING as
deprecated, I was new and afraid I think. but I support the idea of getting
rid of it now I dont see any reason why not now
On Tue, May 12, 2020, 17:11 Nate Harris<EMAIL_ADDRESS>wrote:

@daigof https://github.com/daigof I think I'm actually just gonna close
this PR and go ahead and remove the constants. Seems silly to patch/hide it
instead of just getting rid of them 😅.
I'll do another check on everything so we're sure they're not used
anywhere.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/curology/radiance-ui/pull/239#issuecomment-627567693,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/ACVNEWKYMQCBKTQZ7L3KKITRRGUQFANCNFSM4M7DQVOA
.

closing in favor of #241


Producer cannot connect after Unloading bundle

Describe the bug
I have 2 pulsar clusters in Beijing and Guangzhou, each with 2 physics machine deployed broker nodes.
1、There are 5 producers in this Topic. After multiple shed loads it was found that some of the producers were unable to connect to the pulsar, and the producers that were unable to connect at the same time when the broker of the ownership was different. For example, broker numbers A and B, producers 1,2 and 3 can't connect when the townership of that topic is A; 3, 4, and 5 can't connect when the ownership is B.
checking the broker log revealed that there was an exception that kept outputting Producer with id persistent://xxx/xxx/xxx is already present on the connection.
I looked at the broker logs and found that when Unloading bundle occurs, a producer node will output a log of a [ForkJoinPool.commonPool-worker-24] INFO  org.apache.pulsar.broker.service.ServerCnx - [/<IP_ADDRESS>:15070][xxxx] Creating producer. producerId=0 immediately after Disconnecting producer:, and this Creating producer has no subsequent results (either created successfully or failed). Then when the Unloading bundle occurs again and the downtownership of the topic returns to the broker, the producer node keeps having an exception that is Producer with id [xxx] already present on the connection.
https://github.com/apache/pulsar/blob/f2afad353795f70c00910b6dcce5df8c62b94a67/pulsar-broker/src/main/java/org/apache/pulsar/broker/service/ServerCnx.java#L900
https://github.com/apache/pulsar/blob/f2afad353795f70c00910b6dcce5df8c62b94a67/pulsar-broker/src/main/java/org/apache/pulsar/broker/service/Producer.java#L516
https://github.com/apache/pulsar/blob/f2afad353795f70c00910b6dcce5df8c62b94a67/pulsar-broker/src/main/java/org/apache/pulsar/broker/service/ServerCnx.java#L892
I think that for some reason the process of ServerCnx#handleProducer was interrupted, and then the CompleteFuture corresponding to the producerId in that ServerCnx couldn't complete or exception, causing the producer using that connection to fail to connect.
2、geo-replication of an exception Producer with name 'pulsar.repl.bj-xxx-product' is already connected to topic
To Reproduce
Unfortunately, I cannot reproduce the problem in a local environement.But now in the production environment has emerged.
Expected behavior
The producer can connect properly.
Screenshots

geo-replication

Desktop (please complete the following information):
pulsar 2.5.0
Additional context
Attached is the log of one of the unloading bundles.
UnloadingBundle.log

@zyllt Looks the problem is related to https://github.com/apache/pulsar/issues/6416 and
@addisonj pushed a PR https://github.com/apache/pulsar/pull/6489 for fixing this problem and released it in version 2.5.1. You can try out 2.5.1 and If you have any news about this issue, we can discuss it here.

@codelipenghui  thx,i also think the reason is dangling ProducerFuture.I rechecked the log by #6416 and found that the thread outputting Creating producer at
https://github.com/apache/pulsar/blob/f2afad353795f70c00910b6dcce5df8c62b94a67/pulsar-broker/src/main/java/org/apache/pulsar/broker/service/ServerCnx.java#L900
is not the same as the thread for Namespace bundle for topic at
https://github.com/apache/pulsar/blob/f2afad353795f70c00910b6dcce5df8c62b94a67/pulsar-broker/src/main/java/org/apache/pulsar/broker/service/BrokerService.java#L1210
which makes me confused.

@codelipenghui at
https://github.com/apache/pulsar/blob/f2afad353795f70c00910b6dcce5df8c62b94a67/pulsar-broker/src/main/java/org/apache/pulsar/broker/service/BrokerService.java#L639
Only thenApply method was called, if topicFuture is exception here it should stay stuck,then
https://github.com/apache/pulsar/blob/f2afad353795f70c00910b6dcce5df8c62b94a67/pulsar-broker/src/main/java/org/apache/pulsar/broker/service/ServerCnx.java#L902
There's no way to get it done here.
I was hoping to get confirmation from the log, but all I could find this log at
https://github.com/apache/pulsar/blob/f2afad353795f70c00910b6dcce5df8c62b94a67/pulsar-broker/src/main/java/org/apache/pulsar/broker/service/BrokerService.java#L1208
but at
https://github.com/apache/pulsar/blob/f2afad353795f70c00910b6dcce5df8c62b94a67/pulsar-broker/src/main/java/org/apache/pulsar/broker/service/BrokerService.java#L665
the log is has no output.

@codelipenghui @zyllt I should update those issues, but will put some context here as well.
I am still experiencing this same issue with 2.5.1.  I am currently knee deep in trying to track it down. I still see producerFutures that are "stuck" and not being cleaned up. From what I can tell, this only occurs if unloads happen in somewhat quick succession, where the producerFuture is not completed before another unload happens OR we are seeing issues with ownership, with multiple brokers have ownership of a bundle (still trying to dig through logs to determine which).
Regardless, I think this is exacerbated by certain patterns that cause creation of producers to be delayed or where the number of producers/subscriptions places heavy load on metadata. In my case, I am writing a pulsar source which writes to hundred of different topics but at a somewhat low rate.

Okay, I have logs that I think show what is exactly going on here, this is a sample from a single broker for a single topic that illustrates the problem:
[persistent://canvas-cdc/prod-iad/cluster96-canvas.cluster44_shard_14377.assessment_question_banks-partition-0] Unloading topic
Disconnecting producer: Producer{topic=PersistentTopic{topic=persistent://canvas-cdc/prod-iad/cluster96-canvas.cluster44_shard_14377.assessment_question_banks-partition-0}, client=/<IP_ADDRESS>:53504, producerName=pulsar-prod-iad-418-15948, producerId=69}
[/<IP_ADDRESS>:53504][persistent://canvas-cdc/prod-iad/cluster96-canvas.cluster44_shard_14377.assessment_question_banks-partition-0] Creating producer. producerId=69
[persistent://canvas-cdc/prod-iad/cluster96-canvas.cluster44_shard_14377.assessment_question_banks-partition-0] Topic closed
[/<IP_ADDRESS>:53504] persistent://canvas-cdc/prod-iad/cluster96-canvas.cluster44_shard_14377.assessment_question_banks-partition-0 configured with schema false
Namespace bundle for topic (persistent://canvas-cdc/prod-iad/cluster96-canvas.cluster44_shard_14377.assessment_question_banks-partition-0) not served by this instance. Please redo the lookup. Request is denied: namespace=canvas-cdc/prod-iad

The most interesting bit here is that a producer is re-created after the topic starts unloading and is able to proceed down to where it tries to load a schema (which indicates it was able to load the topic)
On the client, we see the following:
[persistent://canvas-cdc/prod-iad/cluster96-canvas.cluster44_shard_14377.assessment_question_banks-partition-0] [pulsar-prod-iad-418-15948] Creating producer on cnx [id: 0xfe4078a0, L:/<IP_ADDRESS>:53504 - R:pulsar-prod-broker-4.pulsar-prod-broker.pulsar.svc.cluster.local/<IP_ADDRESS>:6651]
[persistent://canvas-cdc/prod-iad/cluster96-canvas.cluster44_shard_14377.assessment_question_banks-partition-0] [pulsar-prod-iad-418-15948] Failed to create producer: 164795 lookup request timedout after ms 30000

After the lookup timeout, the client retries, which now properly gets routed to the new broker, and succeeds.
However, some hours later, after the topic is getting reloaded back onto the same broker, the very first message we see, even before a ledger is opened is the following:
[/<IP_ADDRESS>:53504][69] Producer with id persistent://canvas-cdc/prod-iad/cluster96-canvas.cluster44_shard_14377.assessment_question_banks-partition-0 is already present on the connection

From these logs and the code we can assuming the following:

the topic starts unloading
during unload, the producer quickly tries to reconnect. It does so and is NOT rejected, and is able to get through all this chunk of code:
https://github.com/apache/pulsar/blob/f2afad353795f70c00910b6dcce5df8c62b94a67/pulsar-broker/src/main/java/org/apache/pulsar/broker/service/ServerCnx.java#L902-L945
It calls into topics.addProducer which rechecks the namespace ownership. This throws a RuntimeException (at https://github.com/apache/pulsar/blob/f2afad353795f70c00910b6dcce5df8c62b94a67/pulsar-broker/src/main/java/org/apache/pulsar/broker/service/BrokerService.java#L1211) , however in https://github.com/apache/pulsar/blob/f2afad353795f70c00910b6dcce5df8c62b94a67/pulsar-broker/src/main/java/org/apache/pulsar/broker/service/ServerCnx.java#L971 we ONLY catch a BrokerServiceException, since the exception is un-handled, it also doesn't hit the final chunk to remove the producer
the client times out as it never gets a response and the producer just stays in the cache

Now that I see the real problem here I think i can get a patch in real quick

when PersistentTopic#close(),Can brokerService.removeTopicFromCache(topic) be called before disconnect?


images with unrecognized MIME type work wrong

Hello!
I use this image link format like
![](https://cubox.pro/c/filters:no_upscale()?valid=false&imageUrl=https%3A%2F%2Fpicx.zhimg.com%2F50%2Fv2-53de590b6bb3f42d1a06d28c806c698d_720w.jpg%3Fsource%3D1940ef5c)

so  i use the code
python markdown_articles_tool/markdown_tool.py 1.md -E

The program recognized some different image links as identical and replaced the links with
root@pdf:/home/guang# python markdown_articles_tool/markdown_tool.py 1.md -E
Markdown tool version 0.1.3 started...
02.08.2023 05:10:39 File "1.md" will be processed...
02.08.2023 05:10:39 Image public path:
02.08.2023 05:10:39 Images links count = 17
02.08.2023 05:10:39 Downloading image 1 of 17 from "https://cubox.pro/c/filters:no_upscale()?valid=false&imageUrl=https%3A%2F%2Fpicx.zhimg.com%2F50%2Fv2-53de590b6bb3f42d1a06d28c806c698d_720w.jpg%3Fsource%3D1940ef5c"...
02.08.2023 05:10:40 Image will be written to the file "/home/guang/images/1.png"...
02.08.2023 05:10:40 Downloading image 2 of 17 from "https://cubox.pro/c/filters:no_upscale()?valid=false&imageUrl=https%3A%2F%2Fpica.zhimg.com%2F50%2Fv2-872d10f75dfa52172835fe6fbf22c5fe_720w.jpg%3Fsource%3D1940ef5c"...
02.08.2023 05:10:40 Image will be written to the file "/home/guang/images/1.jpg"...
02.08.2023 05:10:40 Downloading image 3 of 17 from "https://cubox.pro/c/filters:no_upscale()?valid=false&imageUrl=https%3A%2F%2Fpic1.zhimg.com%2F50%2Fv2-c4b89a30d2a3fe1897cfe24388ec935e_720w.jpg%3Fsource%3D1940ef5c"...
02.08.2023 05:10:40 Image "/home/guang/images/1.jpg" already exists and will not be written...
02.08.2023 05:10:40 Downloading image 4 of 17 from "https://cubox.pro/c/filters:no_upscale()?valid=false&imageUrl=https%3A%2F%2Fpic1.zhimg.com%2F50%2Fv2-2a53a9691dd1823bf8e268bccd5ddc33_720w.jpg%3Fsource%3D1940ef5c"...
02.08.2023 05:10:41 Image "/home/guang/images/1.png" already exists and will not be written...
02.08.2023 05:10:41 Downloading image 5 of 17 from "https://cubox.pro/c/filters:no_upscale()?valid=false&imageUrl=https%3A%2F%2Fpic1.zhimg.com%2F50%2Fv2-0efb5de65201ba08c47863d88b61669f_720w.jpg%3Fsource%3D1940ef5c"...

Hope you can help me to solve this problem, thanks

Fixed.


Split assembly in separate packages for DOCX / XLSX / PPTX

Per https://github.com/dotnet/Open-XML-SDK/issues/387

Consider breaking up library into smaller ones for Word/Powerpoint/Excel.

As well as my comment: https://github.com/dotnet/Open-XML-SDK/issues/387#issuecomment-1140978211

Yes, please. Having these separated (along with a base / core module, I assume) would improve clarity, make for a smaller base package (currently ~5.8 MB) and allow more code splitting between dependent assemblies. For reference our product does not currently use Powerpoint at all.

I know this topic is in the backlog, but considering its structural impact I think it it worth it to have a dedicated issue, at least to improve its visibility and prevent it from getting buried.
(I have searched for similar issues but if I could not find any; if this is indeed explicitly tracked elsewhere please close / delete this issue).

@m-gallesio this has been a long time in the making. I've currently separated out the core SDK infrastructure and enabled the typed classes to be in a separate assembly from all of that. I'm currently working on stabilizing it, but as that occurs, this becomes possible.
@tomjebo This is something we should start looking at from the schema perspective. Can we update the generator to keep these isolated? I know there are a few types that are explicitly shared between the types for some reason (I think similar names) that we would need to separate out.

@m-gallesio @czemacleod If there's interest here, the code generator has been moved to this repo. It may be able to isolate the types required for each doc type using some sort of tree-walking. Happy to take any pull requests or have a discussion of how to start tackling this if anyone is interested in contributing!

@twsouthwick I'm not sure I really have time to delve that far into this project unfortunately.
My reasoning is that we use this to build Excel files for reports and 'datagrids' in our web applications (as an export to Excel feature). We also use it in a couple of applications to do data import from Excel.
The point is that I have no need to any other types (other than common/base types) outside that scope and if we could reduce the memory footprint of the application all the better.
Not for ourselves especially, but this would also make a lot of sense in a microservices scenario for e.g. generating word documents from templates, or excel spreadsheets or something similar.

I've added this to the v3.0 milestone so it can be tracked there - otherwise, it will probably be until v4.0 (whenever that ends up happening)

I have tried to follow the generation pipeline without much success (is there some kind of guide / reference?), but it seems the input for the generator is the data directory.
Files in data/schemas are already split by XML namespace.
Files in data/parts seem to work differently, but have ContentType and RelationshipType fields which seem interesting for this purpose.
Naïvely, a valid idea seems to be having somewhere, somehow a mapping between namespaces (either original XML or generated C#) and assemblies; e.g. "all files in the Wordprocessing namespace should be in the Wordprocessing assembly".

Thanks @m-gallesio for taking a look.

Naïvely, a valid idea seems to be having somewhere, somehow a mapping between namespaces (either original XML or generated C#) and assemblies; e.g. "all files in the Wordprocessing namespace should be in the Wordprocessing assembly".

That's what I'm thinking as well. However, There may be some shared types/namespaces (i.e. DrawingML) that may have to be an additional library. If you can come up with a list of those, that would be a great starting point :)

I looked into this and identified a few things that would be necessary:

[ ] A single generated file is used for all the root part generation - this would need to be separated out to be per-document type
[ ] TypedOpenXmlPartReader was introduced in 2.19 as a type that provides the typed factories for use of OpenXmlPartReader with just a stream. This would need to be replaced with a doc specific one

Looking even more into this, I don't know if we want to necessarily touch DocumentFormat.OpenXml, instead, we can start generating a second set of types that are structured a bit better to allow this. That way, we won't break anything in the original usage.
This would also allow #1278 to rationalize the namespace hierarchy of the generated types, as well as automating to the new layout with either analyzer/codefixers or Upgrade Assistant.
Also, by doing this, we can do it at any point in the 3.x timeline and won't be a breaking change

Glad to see this is moving forward even if I am not able to follow the internals.
If I may deliver a small rant, another point I have stumbled into today which would be helped by this split is the existence of several homonymous classes across different namespaces. Accidentally (or automatically via IDE) importing Paragraph from DocumentFormat.OpenXml.Spreadsheet while dealing mainly with Wordprocessing can be quite annoying.

Yeah, long term, I hope to make the source generators we're using public and then allow you to customize the names how you'd like. Something akin to how CsWin32 allows you to specify what you care about and it will just add what you need. We're a ways off from that, though.
However, there are names that are reused in different namespaces by the schema definitions, so this just is an artifact of that.

I'm removing this from v3.0 as we can tackle it after, but once v3.0 is stabalized, it'll probably be the next thing I focus on


Updated Mozilla Observatory parser to parse findings without 'name' element

Older versions of the Mozilla Observatory result file had the element 'name' within each finding. In the current version (seems to have been this way for some time) the 'name' element is no longer included. The updated parser simply uses the 'key' of the finding, which is/was identical to the 'name' used previously by the parser.
Thus, this version is able to parse Mozilla Observatory result files with and without name, by using the finding's key.
I also updated two of the unittest input scanfiles with freshly created scans and adapted the test cases/asserts accordingly.

@damiencarol I have added a new scan output file and unittest in addition to the existing tests. Waiting for @Maffooch 's feedback above, otherwise I don't expect any further changes.

Argl, I managed to avoid adding those file for so long just to slip up on the last commit :D Should be removed now.


Error validating routes

Output of helm version:
version.BuildInfo{Version:"v3.0.0", GitCommit:"e29ce2a54e96cd02ccfce88bee4f58bb6e2a28b6", GitTreeState:"clean", GoVersion:"go1.13.4"}
Output of kubectl version:
Client Version: version.Info{Major:"1", Minor:"11+", GitVersion:"v1.11.0+d4cacc0", GitCommit:"d4cacc0", GitTreeState:"clean", BuildDate:"2018-10-10T16:38:01Z", GoVersion:"go1.10.3", Compiler:"gc", Platform:"linux/amd64"}
Server Version: version.Info{Major:"1", Minor:"11+", GitVersion:"v1.11.0+d4cacc0", GitCommit:"d4cacc0", GitTreeState:"clean", BuildDate:"2019-02-22T07:05:30Z", GoVersion:"go1.10.8", Compiler:"gc", Platform:"linux/amd64"}
Cloud Provider/Platform (AKS, GKE, Minikube etc.):
Openshift on prem
When I try to run helm upgrade I am getting this error
Error: UPGRADE FAILED: error validating "": error validating data: ValidationError(Route): missing required field "status" in com.github.openshift.api.route.v1.Route
With the beta version it works.

got the same here :
version is :
version.BuildInfo{Version:"v3.0.0", GitCommit:"e29ce2a54e96cd02ccfce88bee4f58bb6e2a28b6", GitTreeState:"clean", GoVersion:"go1.13.4"}
Validation failed on weight and status :
Error: unable to build kubernetes objects from release manifest: error validating "": error validating data: [ValidationError(Route.spec.to): missing required field "weight" in com.github.openshift.api.route.v1.RouteTargetReference, ValidationError(Route): missing required field "status" in com.github.openshift.api.route.v1.Route]
helm.go:76: [debug] error validating "": error validating data: [ValidationError(Route.spec.to): missing required field "weight" in com.github.openshift.api.route.v1.RouteTargetReference, ValidationError(Route): missing required field "status" in com.github.openshift.api.route.v1.Route]
helm.sh/helm/v3/pkg/kube.scrubValidationError
	/home/circleci/helm.sh/helm/pkg/kube/client.go:520
helm.sh/helm/v3/pkg/kube.(*Client).Build
	/home/circleci/helm.sh/helm/pkg/kube/client.go:135
helm.sh/helm/v3/pkg/action.(*Install).Run
	/home/circleci/helm.sh/helm/pkg/action/install.go:229
main.runInstall
	/home/circleci/helm.sh/helm/cmd/helm/install.go:209
main.newUpgradeCmd.func1
	/home/circleci/helm.sh/helm/cmd/helm/upgrade.go:111
github.com/spf13/cobra.(*Command).execute
	/go/pkg/mod/github.com/spf13/cobra@v0.0.5/command.go:826
github.com/spf13/cobra.(*Command).ExecuteC
	/go/pkg/mod/github.com/spf13/cobra@v0.0.5/command.go:914
github.com/spf13/cobra.(*Command).Execute
	/go/pkg/mod/github.com/spf13/cobra@v0.0.5/command.go:864
main.main
	/home/circleci/helm.sh/helm/cmd/helm/helm.go:75
runtime.main
	/usr/local/go/src/runtime/proc.go:203
runtime.goexit
	/usr/local/go/src/runtime/asm_amd64.s:1357
unable to build kubernetes objects from release manifest
helm.sh/helm/v3/pkg/action.(*Install).Run
	/home/circleci/helm.sh/helm/pkg/action/install.go:231
main.runInstall
	/home/circleci/helm.sh/helm/cmd/helm/install.go:209
main.newUpgradeCmd.func1
	/home/circleci/helm.sh/helm/cmd/helm/upgrade.go:111
github.com/spf13/cobra.(*Command).execute
	/go/pkg/mod/github.com/spf13/cobra@v0.0.5/command.go:826
github.com/spf13/cobra.(*Command).ExecuteC
	/go/pkg/mod/github.com/spf13/cobra@v0.0.5/command.go:914
github.com/spf13/cobra.(*Command).Execute
	/go/pkg/mod/github.com/spf13/cobra@v0.0.5/command.go:864
main.main
	/home/circleci/helm.sh/helm/cmd/helm/helm.go:75
runtime.main
	/usr/local/go/src/runtime/proc.go:203
runtime.goexit
	/usr/local/go/src/runtime/asm_amd64.s:1357

It looks like those fields are required as per openshift's OpenAPI specification. I'd open an issue over with OpenShift, asking whether these fields are required for manifests to provide.

reference documentation for a v1.Route can be found here: https://docs.openshift.com/container-platform/3.5/rest_api/openshift_v1.html#v1-route

Thanks @bacongobbler , actually an issue for this has already been opened on openshift's side https://github.com/openshift/origin/issues/24060

thanks! Closing as a duplicate of https://github.com/helm/helm/issues/6830.


[Android] How to Create a Custom Accordion Layout in Android Using Constraint Layout and Kotlin

Topic Suggestion
[Android] How to Create a Custom Accordion Layout in Android Using Constraint Layout and Kotlin
Proposed title of the article
How to Create a Custom Accordion Layout in Android
Proposed article introduction
Accordion View is a view that consists of a series of titles, and when you click on a specific title, the detailed description will be expanded. What makes it special is that the expanded view will close itself once another view is expanded.
Key takeaways

What is an Accordion View.
How to create an Accordion View in Android.
Advantages of using an Accordion view.

Article quality
This article is going to help the reader understand some hidden features of ConstraintLayout like ConstraintSet. It will be beginner-friendly and have Kotlin full implementation. The article will as well define the use cases of an Accordion layout.
References

Responsive UI with ConstraintLayout .

Hi @omondi-alex
Thanks for submitting your topic suggestion. However, your entire introduction has been copied verbatim from this article which questions the originality of the article. Due to this we cannot move forward with your topic suggestion.
Feel free to explore other topics.


Render emojis from text. Closes #69

:heart: thank you so much @junedomingo :raised_hands:
And thanks for reviewing @alejandronanez :+1:


After deleting a project, you can not create an item with the same name as the deleted one

In GitLab by @guyingyan on Nov 7, 2017, 10:13
error info as below:

./dashboard_test.go:4: imported and not used: "git/inspursoft/board/src/apiserver/controller"
./dashboard_test.go:5: imported and not used: "testing"

git/inspursoft/board/src/collector/cmd/app/appflag_test.go
info:
2017/11/07 09:37:14 DbPort non
2017/11/07 09:37:14 KubeIp non
2017/11/07 09:37:14 KubePort non
2017/11/07 09:37:14 DbPass non
2017/11/07 09:37:14 DbType non
2017/11/07 09:37:14 DbIp non
url is  http://:/version
panic: runtime error: invalid memory address or nil pointer dereference
[signal SIGSEGV: segmentation violation code=0x1 addr=0x40 pc=0xf1020a]

goroutine 1 [running]:
git/inspursoft/board/src/collector/service/collect.pingK8sApiLink()
/home/boardTest/wangkun_lc/src/git/inspursoft/board/src/collector/service/collect/TableMain.go:44 +0x2aa
git/inspursoft/board/src/collector/service/collect.SetInitVar(0x0, 0x0, 0x0, 0x0)
/home/boardTest/wangkun_lc/src/git/inspursoft/board/src/collector/service/collect/TableMain.go:33 +0x19a
git/inspursoft/board/src/collector/cmd/app.init.1()
/home/boardTest/wangkun_lc/src/git/inspursoft/board/src/collector/cmd/app/appflag.go:100 +0x56
git/inspursoft/board/src/collector/cmd/app.init()
/home/boardTest/wangkun_lc/src/git/inspursoft/board/src/collector/cmd/app/appflag_test.go:16 +0x6c
main.init()
git/inspursoft/board/src/collector/cmd/app/_test/_testmain.go:46 +0x53

In GitLab by @yhua123 on Nov 8, 2019, 07:40
by design now, will use project_id as key value in the future

In GitLab by @sokril on Nov 8, 2019, 08:13
closed

In GitLab by @sokril on Nov 8, 2019, 08:13
assigned to @luotian-github


Check GraalVM build with Java17 migration

Purpose

$Subject

Examples
N/A
Checklist

[ ] ~Linked to an issue~
[ ] ~Updated the specification~
[ ] ~Updated the changelog~
[ ] ~Added tests~
[ ] Checked native-image compatibility

Closing this PR since we can now use the timestamped version for the driver


Propagate callable's return type annotation for Depends/Security

I was struck by the following paragraph in tutorial for Depends:
https://github.com/tiangolo/fastapi/blob/51e920e2fcf3e2a715081f28e3187549f2bf531a/docs/en/docs/tutorial/dependencies/classes-as-dependencies.md#L138-L150
I though that's easily solvable with typing.TypeVar, and this PR serves as a untested proof-of-concept, further corroborated only by the fact that the following short snippet passes mypy checks:
from typing import Callable, TypeVar

T = TypeVar('T')

class C:
    ...

def foo(x: Callable[..., T]) ->  T:
    return bar()

def bar():
    return ...

c: C = foo(C)   # <-- no error here

This alleviates the need for repeating the dependency (e.g. CommonQueryParams) in the annotation. :crossed_fingers:

While an obvious example of laziness and poor judgement, with tests still passing, the proof-of-concept seems to work. :sweat_smile:

Finally took time to make the tests pass. Please have a look. :grin:

I'd love to see this change land. Let me know if I can help.

I think this can be closed now as we can use Annotated:
@app.get("/items/")
async def read_items(commons: Annotated[dict, Depends(common_parameters)]):
    return commons

Thanks all! :rocket:
Yep, we can probably achieve these ideas with Annotated now :sunglasses:
I'll close this one now. Thanks! :coffee:

:warning: Please install the  to ensure uploads and comments are reliably processed by Codecov.
Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:
:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.

Files
Coverage Δ

fastapi/param_functions.py
100.00% <100.00%> (ø)


Data Flow: identify the device that met the rule

In a flow whose input is a device template, there is no way to identify in the output the device that satisfied the rule.

In the current version, you can choose the device that triggered the flow.


Consider Adding Topic: Razor Syntax Standards

See #265

I vote we close this topic as outside the current focus of the guide.

I agree!

I agree as well.


Flowchart of how this works

Hi,
Could you provide in the readme a graph or flowchart illustrating how this works, or generate one using LLM to help me understand the code better? I'm particularly curious about whether multiple passes are made to enhance the final code. I tried with ChatGPT but I don't have the Plus, and it just failed to generate one...

If it's the  former, I'd love to refactor the code to make it easier to approach!
On pseudocode level humanify works about like this:
const ast = parse(code)
for (const varName of ast.identifiers) {
  const newName = aiModel.askToRename(varName, surroundingCode(varName, ast))
  ast.rename(varName, newName)
}

So at least one request to ChatGPT is made per variable. The actual rename is made without ChatGPT. Does this answer your question?

No, my mistake for not being clear enough in my message, I wanted mainly to see how this works internally via a graph that explain the steps your tool do to deliver the finally result... a visual representation.
eg.
Input > unminification > code parsing > looking for patterns via (something) > beautification > ESLint > LLM variable replacement > Loop x times > Output
If this still doesn't make sense, forget about this, I don't want to take up your development time.

If it's the former, I'd love to refactor the code to make it easier to approach!
On pseudocode level humanify works about like this:
const ast = parse(minifiedCode)
for (const varName of ast.identifiers) {
  const newName = aiModel.askToRename(varName, surroundingCode(varName, ast))
  ast.rename(varName, newName)
}
save(ast.toString())

So at least one request to ChatGPT is made per variable. The actual rename is made without ChatGPT. Does this answer your question?

Yes that would be enough for the moment, I will have to examine the source-code, if I still have questions then I will comeback (I just wanted ChatGPT to generate the graph but I don't have the Plus and tried several times then told me that I reached the limit, I will try again today. As this can give anyone a clear idea of the workflow.

I wanted mainly to see how this works internally via a graph that explain the steps your tool do to deliver the finally result... a visual representation.

I will have to examine the source-code

@neoOpus I sort of looked at this myself the other day to understand things better; I found it easiest to start at the CLI command, which call unminify and provides a pipeline of plugins to apply to it (babel, openaiRename, prettier):
https://github.com/jehna/humanify/blob/a51847171add85a65f29ef4cdc4b403812601bc1/src/commands/openai.ts#L20-L30
You can see the definition for unminify here:
https://github.com/jehna/humanify/blob/a51847171add85a65f29ef4cdc4b403812601bc1/src/unminify.ts#L6-L27
You can see the openaiRename plugin code here:
https://github.com/jehna/humanify/blob/a51847171add85a65f29ef4cdc4b403812601bc1/src/plugins/openai/openai-rename.ts#L6-L38
You can similarly follow the code flows for the local and gemini based CLI options.

Thank you so much Glenn for your help! I really appreciate!
I have a clearer idea now, but I still have some reading to do, I am thinking about feeding the source-code to an LLM to make the flowchart from it, but I still didn't find that solution yet!
BTW, I've been reading your profile and I really liked it, we have a similar approach about learning and doing things!


Add and test sign language video in the container page

Describe your changes
This testing PR is to support #3044
Will see and discuss about the layout from the preview.
Related issue number or link (ex: resolves #issue-number)

#3044

Checklist before opening this PR (put x in the checkboxes)

[x] This PR does not contain plagiarism

don’t copy other people’s work unless you are quoting and contributing it to them.

[x] I have signed off on all commits

signing off (ex: git commit -s) is to affirm that commits comply DCO. If you are working locally, you could add an alias to your gitconfig by running git config --global alias.ci "commit -s".

hold

this PR is WIP. :)

Note: {{< youtube YOUTUBE-VIDEO-LINK-ID >}} is HUGO built-in feature. :)

## Further Reading may not be a necessary header, but I added it to separate the In sign language section from the content above.

I agree. If we're going to roll out a new template with ## Further Reading as a header, I feel like we should specify what it's for. Otherwise, it may become a bit of a junk drawer, which would undermine the effort we're making to highlight the sign language section.
Let us consider dropping "Further reading" in favour of @chalin's suggestion of a "Sign language" section (how ever we want to render that).

LGTM 😄

Hello @chalin @nate-double-u,
Thank you for sharing your thoughts. The reason I did not use <summary> or another style in the initial proposal was that I hoped the sign language videos would become visible to people more quickly. (It was also the initial layout proposal from the glossary-sign-language and deaf-and-hard-of-hearing WG)
For now, I've uploaded a version that incorporates both of your feedback for testing on this page.
It would be great if we could all review it together and align our thoughts.
https://deploy-preview-3194--cncfglossary.netlify.app/container/

Using <summary> to hide/open the video content:

Pros: Emphasizes the main content of the glossary.
Cons: Requires an additional click to access the sign language video. (It might not be immediately apparent on the page that the glossary has started supporting sign language)

Providing it at the end under an H2 or H3 header:

Pros: The opposite of the above method.
Cons: The opposite of the above method.

I would also appreciate the opinions of others like @CathPag @jtjackson.

I prefer the second option. What do we need to proceed here? @seokho-son @nate-double-u @CathPag

I would like to be notified as well for the next steps.

Thank you for sharing the DHHWG meeting results, @bashtheshell.
The voting results from the last maintainer meeting (CC: @iamNoah1, @jihoon-seo, @nate-double-u, @seokho-son) also favored the "bottom with the H2 header" style for better visibility. Let’s finalize it this way. (Of course, the style itself can evolve through future contributions.)
To bring the sign language feature live quickly, I suggest utilizing this PR. Once the 5 video links are organized, please share them in a comment. I’ll update the PR accordingly.


Investigate server-side apply to allow cooperating controllers

Refs:
https://kubernetes.io/docs/reference/using-api/server-side-apply/
https://github.com/knative-sandbox/net-contour/issues/347#issuecomment-838613107
This would allow customization of the resources we create
/assign @dprotaso

/lifecycle frozen

FYI there's a server-side apply bug upstream that's worth keeping tabs on - https://github.com/kubernetes/kubernetes/issues/111937
I don't believe if blocks this issue


feat: add basedpyright

Respective nvim-lspconfig PR: https://github.com/neovim/nvim-lspconfig/pull/3078

I've already submitted this very same PR (https://github.com/mason-org/mason-registry/pull/4996) as soon as my other PR in nvim-lspconfig got approved (https://github.com/neovim/nvim-lspconfig/pull/3078).
This one, instead, is lacking one of the package's binaries and schema information.

Oh, I see, yeah then your PR is preferable.