[Snyk] Upgrade moment from 2.29.4 to 2.30.0

This PR was automatically created by Snyk using the credentials of a real user.Snyk has created this PR to upgrade moment from 2.29.4 to 2.30.0.
:information_source: Keep your dependencies up-to-date. This makes it easier to fix existing vulnerabilities and to more quickly identify and fix newly disclosed vulnerabilities when they affect your project.

The recommended version is 1 version ahead of your current version.
The recommended version was released 21 days ago, on 2023-12-26.

Release notes

Package name: moment

2.30.0 - 2023-12-262.30.0

2.29.4 - 2022-07-062.29.4

    from moment GitHub release notes

Note: You are seeing this because you or someone else with access to this repository has authorized Snyk to open upgrade PRs.
For more information:
🧐 View latest project report
🛠 Adjust upgrade PR settings
🔕 Ignore this dependency or unsubscribe from future upgrade PRs

Will be resolved by https://github.com/polarityio/securonix-siem/pull/11


(Issue #18) Implement parser function to list available classes

This is an implementation of the design suggested by @smbambling in issue #18.
I'm not convinced that the node manager module is the best place for this function, but I believe it could enable some compelling design patterns. What do you think @WhatsARanjit? Better suited for another module? Stdlib?
If we end up keeping the function in this module, I'll add an appropriate stanza to the README.

This looks to just list all classes in an environment. Would one then be expected to parse out the desired classes or dire the function suppor this or should it ?

Yeah, I see the filtering of returned classes as being outside the responsibility of this function.

Would there be a better method then using the API to get a list of environments on a Puppetserver (master) to loop over.  This is so that one can create both environment groups and classification groups based on a match like
$classes = environment_classes()
$matched = grep($classes, 'role::')

@smbambling @jolshevski The main idea behind this function is to pull a list of classes per environment.  That isn't necessarily tied to management of node_groups.  It might be better suited to put this in stdlib.  If there are use cases for this function outside of node_group management, a user shouldn't have to install this module to get that.

I agree.
I'm not certain this will be a common design pattern, so rather than propose an addition to stdlib, I created a module here: https://github.com/jolshevski/puppet-env_utils. We may want to look into merging this into stdlib at some point, but I think this makes sense for now.
Side note for @smbambling - I implemented a function to list all available environments in the new module also. Feel free to contribute feedback, ideas, code, etc, and I'll release to the forge once we're happy with it.


requires-python without * caused missing wheels in uv.lock

uv: 0.4.20
platform: Apple M3 Max
cmd: uv lock

With config:
[project]
name = "demo"
version = "0.1.0"
readme = "README.md"

dependencies = [
    "pymongo==4.10.0",
]

requires-python = "==3.12"

Output:

If use requires-python = "==3.12.*", problem fixed.
Seems this came from https://github.com/astral-sh/uv/pull/7904

Please see https://github.com/astral-sh/uv/issues/7426

Please see #7426

It's same root reason that uv hasn't define how a version without patch field is processed.
But caused unexpected behavior for wheel locking scenes. Maybe add bug label would be more appropriate.

It's same root reason that uv hasn't define how a version without patch field is processed.

This behavior is not defined by us, it's a part of the Python standards and specifications — which we are following here.

It's same root reason that uv hasn't define how a version without patch field is processed.

This behavior is not defined by us, it's a part of the Python standards and specifications — which we are following here.

Thanks, looks like uv followed the PEP 440 for this.

Yep! We're adding a warning for people who run into this.


'lengthWithoutTildes' appears to be a reimplementation of 'cstrlen'

Hi Brian,
I happened to be taking a glimpse at your code earlier today and ran across this function:
https://github.com/electroly/tmbasic/blob/0bf923ae9610189973551f16afa0d13c27dbb962/src/tmbasic/tvutil.cpp#L5-L13
I see this function is used to measure text widths in several places. Turbo Vision has its own function for this purpose:
/*------------------------------------------------------------------------*/
/*                                                                        */
/*  cstrlen                                                               */
/*                                                                        */
/*  argument:                                                             */
/*                                                                        */
/*      text    - input string                                            */
/*                                                                        */
/*  returns                                                               */
/*                                                                        */
/*      length of string, ignoring '~' characters.                        */
/*                                                                        */
/*  Comments:                                                             */
/*                                                                        */
/*      Used in determining the displayed length of command strings,      */
/*      which use '~' to toggle between display attributes                */
/*                                                                        */
/*------------------------------------------------------------------------*/

int cstrlen( TStringView text )

There is also this function which does not treat ~ in any special way:
/*------------------------------------------------------------------------*/
/*                                                                        */
/*  strwidth                                                              */
/*                                                                        */
/*  argument:                                                             */
/*                                                                        */
/*      text    - input string                                            */
/*                                                                        */
/*  returns                                                               */
/*                                                                        */
/*      displayed length of string.                                       */
/*                                                                        */
/*------------------------------------------------------------------------*/

int strwidth( TStringView text )

Both functions are always available after including <tvision/tv.h>.
Using these functions should be preferred because they take double-width and zero-width characters into account, but if you are avoiding them because they don't work properly for you, please let me know.
Cheers!

Hey, nice! Thanks for the tip! I didn't know that function existed. I'll make the switch.

Hey, nice! Thanks for the tip! I didn't know that function existed. I'll make the switch.


release-builder local builds on Mac fail on release-1.13 and master branches

Bug Description
I believe the docker build v2 work is causing some issues while trying to do release-builder builds locally.
Trying the command in the README works on the release-1.12 branch but fails on newer branches.
2022-01-28T14:39:07.101176Z	info	Running command: docker buildx bake -f /tmp/istio-release/work/src/istio.io/istio/out/linux_amd64/dockerx_build/docker-bake.json all
[+] Building 0.0s (0/0)
error: Docker exporter feature is currently not supported for docker driver. Please switch to a different driver (eg. "docker buildx create --use")
Error: exit status 1
make[1]: *** [tools/istio-docker.mk:379: dockerx.save] Error 255
make[1]: Leaving directory '/tmp/istio-release/work/src/istio.io/istio'
Error: failed to build: failed to build Docker: failed to create istio docker archives: exit status 2
exit status 1

Version
master and release-1.13 branches

Additional Information
No response

Note that make docker.save (command used in release-builder) fails in the istio/istio repo as well.

Need to create a docker builder. It's probably not specific to Mac? We have code somewhere to do it but it's probably not triggered as a dependency for docker.save - likely a simple fix

I believe the docker builder is created, I may be that the Mac version doesn't support tar file generation. make docker works in istio/istio to generate images. make docker.save fails.Possibly the builder create can be tweaked.

I think that's just how docker works? Even on linux
On Wed, Feb 2, 2022 at 12:54 PM Eric Van Norman @.***>
wrote:

On a Mac, the default docker builds instance uses the docker driver:
docker buildx ls
NAME/NODE       DRIVER/ENDPOINT             STATUS  PLATFORMS
desktop-linux   docker
desktop-linux desktop-linux               running linux/amd64, linux/arm64, linux/riscv64, linux/ppc64le, linux/s390x, linux/386, linux/arm/v7, linux/arm/v6
default         docker
default       default                     running linux/amd64, linux/arm64, linux/riscv64, linux/ppc64le, linux/s390x, linux/386, linux/arm/v7, linux/arm/v6
This instance works for creating images, but not exporting.
If one creates a new instance with the default docker-container driver and
set's it as the default, docker buildx create --use, shown as:
docker buildx ls
NAME/NODE       DRIVER/ENDPOINT             STATUS  PLATFORMS
modest_dirac *  docker-container
modest_dirac0 unix:///var/run/docker.sock running linux/amd64, linux/arm64, linux/riscv64, linux/ppc64le, linux/s390x, linux/386, linux/mips64le, linux/mips64, linux/arm/v7, linux/arm/v6
...
And then runs the command, the new builder is used and things work.
Some slight additional testing, and I will add a comment to the release
builder page as well as the the Using a Mac for Dev wiki page.
—
Reply to this email directly, view it on GitHub
https://github.com/istio/istio/issues/37069#issuecomment-1028348941, or
unsubscribe
https://github.com/notifications/unsubscribe-auth/AAEYGXIESP2XO2EE753WMRTUZGKYHANCNFSM5NBCNNCQ
.
Triage notifications on the go with GitHub Mobile for iOS
https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675
or Android
https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.
You are receiving this because you commented.Message ID:
@.***>

Good to know Linux also seems to have a default builder that's using the non-default driver.

I might look at checking if the current builder driver is docker-container in the case of a .save and dump a message to create a builder..

createBuildxBuilderIfNeeded in docker-builder/main.go is supposed to do it.
Does it not work?
On Wed, Feb 2, 2022 at 1:25 PM Eric Van Norman @.***>
wrote:

I might look at checking if the current builder driver is docker-container
in the case of a .save and dump a message to create a builder..
—
Reply to this email directly, view it on GitHub
https://github.com/istio/istio/issues/37069#issuecomment-1028371997, or
unsubscribe
https://github.com/notifications/unsubscribe-auth/AAEYGXIJPF3KALY27CQ55ADUZGOMFANCNFSM5NBCNNCQ
.
Triage notifications on the go with GitHub Mobile for iOS
https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675
or Android
https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.
You are receiving this because you commented.Message ID:
@.***>

We don't create a build instance if CI is not set: https://github.com/istio/istio/blob/master/tools/docker-builder/main.go#L122
This change would be more of a check if the current builder is OK. Maybe something like: docker buildx ls | grep "*" | grep docker-container although I'm not sure if * would be somewhere else besides the current builder.

Also noted, that the .save isn't used very much. The thing that raised the issue here is release-builder uses it, so running that locally would cause an issue.

Ah. Maybe if CI, create (like today). Else, just warn and tell them how to create..?

I met this problem when compiling

the solution is very easy
$ docker buildx create --driver-opt network=host,image=gcr.io/istio-testing/buildkit:v0.11.0 --name container-builder --driver docker-container --buildkitd-flags="--debug" --use

This hint is too implicit.


Chia 1.1.6 fresh Windows installation: Plotter folder does not exist?

`PS C:\Windows\system32> Start-PlotoSpawns
PlotoManager @ 2-6-2021 19:04:09 : Ploto Manager started.
PlotoManager @ 2-6-2021 19:04:09 : Loading config from  C:\Users\Gebruiker.chia\mainnet\config\PlotoSpawnerConfig.json...
PlotoManager @ 2-6-2021 19:04:09 : InputAmountToSpawn: 100
PlotoManager @ 2-6-2021 19:04:09 : Intervall to wait: 5
PlotoManager @ 2-6-2021 19:04:09 : PlotoFy is set to startup. Checking for active PlotoFy jobs...
PlotoManager @ 2-6-2021 19:04:09 : We have found active PlotoFy jobs. Stopping it and starting fresh...
Id     Name            PSJobTypeName   State         HasMoreData     Location             Command

3      PlotoFy         BackgroundJob   Running       True            localhost            ...
PlotoManager @ 2-6-2021 19:04:09 : Started PlotoFy successfully. Check your Discord
Get-ChildItem : Cannot find path 'C:\Users\Gebruiker\.chia\mainnet\plotter\' because it does not exist.
At C:\Users\Gebruiker\Downloads\Ploto\Ploto.psm1:1145 char:9

$logs = Get-ChildItem $PlotterBaseLogPath | Where-Object {$_.Name -no ...

    ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

CategoryInfo          : ObjectNotFound: (C:\Users\Gebrui...ainnet\plotter:String) [Get-ChildItem], ItemNotFoundException
FullyQualifiedErrorId : PathNotFound,Microsoft.PowerShell.Commands.GetChildItemCommand

Invoke-PlotoJob : Cannot bind argument to parameter 'OutDriveDenom' because it is null.
At C:\Users\Gebruiker\Downloads\Ploto\Ploto.psm1:1106 char:104

... ize $BufferSize -Thread $Thread -OutDriveDenom $OutDriveDenom -TempDr ...

                                               ~~~~~~~~~~~~~~

CategoryInfo          : InvalidData: (:) [Invoke-PlotoJob], ParameterBindingValidationExcept
ion
FullyQualifiedErrorId : ParameterArgumentValidationErrorNullNotAllowed,Invoke-PlotoJob`

I installed chia 1.1.6 today on a fresh desktop. There indeed is no folder "plotter" on my machine. The official wallet is started and syncing. User error? Or bug? :)

there's also a "" missing in the first path statement:
C:\Users\Gebruiker.chia\mainnet instead of C:\Users\Gebruiker.chia\mainnet
That looks like a user error? :) BUT... C:\Users\Gebruiker.chia\mainnet\plotter isn't a directory either. I did an explorer search on "plotter" and it found 0 results.

Missing the \ after gebruiker and before .chia ??

C:\Users\Gebruiker.chia\mainnet instead of C:\Users\Gebruiker.chia\mainnet
That looks like a user error? :) BUT...
C:\Users\Gebruiker.chia\mainnet\plotter isn't a directory either. I did an
explorer search on "plotter"

yeah that was github - should be corrected now: it removed the \ in view. But good catch :)
I really don't have the plotter folder on my fresh PC with fresh 1.1.6 (Windows). Where is it? :(
:)

I believe it is generated by Chia.exe (GUI) or chia.exe (CLI) upon plotting
for first time but it should be exactly where it's pointed at so just
create the folder manually and you should be good to go

I was just testing a plot with the GUI :) And if that doesn't work I'll create a plotter folder. Thank you! I'll update & close once confirmed.
Appreciated

Did you setup the config file and drop it in .chia\mainnet\config

Confirmed: after starting a plot with the GUI a plotter folder was created and it contains a log file, no software. All good! My bad apparently :)

Did you setup the config file and drop it in .chia\mainnet\config

Yep did that too. I think it's solved and I'll close it for now. If I learn differently, I'll start bugging ya'all again ;-)


Use studio to install a pincab from scratch

The user story is the following:
when installing / reinstalling a pincab, which is my case today, I'd like to install studio first, then use the system manager to install one after the other the components of the pincab.
This excludes so far the frontend as, except pinballY, pinballX and Popper are not available in github

Detection that visual pinball is not installed, then not relevant button are greyed out or invisible

Added a 'Select Target Folder' to optionally change the installation path. Propose by default the default path of the tool

Press install, the tool is unzip, then screen turns back to normal

Visual pinball is installed

Then move to VpinMAME tab :

Then backglass

=> register backglass has to be run as it needs elevated priviledges. Also B2S_ScreenResIdentifier.exe has to be called manually

continue till end and tada

so basically replacing Baller Installer?

committed in 3.12


Crystal Geng: EuropeAviation

Name of the app: EuropeAviation
Link to the repo: https://github.com/THF-d8/EuropeAviation
Link to the app: https://europeaviation.onrender.com/
Link to the proposal.md file: https://github.com/THF-d8/EuropeAviation/blob/main/proposal.md

The app looks really cool! Having worked in the airline sector previously, I can see this dashbaord coming in handy for potential users. There are some aspects to the app that I believe could enhance the app:

Perhaps you can add the actual month name instead of the month number.
The legend in the bar plot could be removed as the information is already there in the plot itself.

The app looks amazing! After going through the project proposal it is clear that the app achieves its purpose, great work! There are a few things I think may help to improve the user experience:

I would consider using a different color palette. The contrast may be a little too high, an example of this is the color used for the drop-down, which probably is not too friendly for the eye.
I concur with Manvir's comment on the month number.
Make sure the rotation is consistent for all legends.


Inconsistent accuracy and loss in label predictor

Hi @yyf17 @ChanganVR  thanks for the discussion, hope you are doing good! I'm new to this repo and had some trouble training this label predictor with the given parameter settings and hope to get some suggestions. I'm in the same situation here with accuracy, it starts at a high value and decreases as the training loss decreases, trained from scratch. @yyf17 could you provide some tips about what the problem is?

Also about runtime, I'm wondering why the first epoch is so slow with 20% CPU util and 0% GPU util. In other epochs, CPU util stays around 100% but GPU util keeps jumping between 0 to 100%. I'm training via Slurm with 1 node, 1024 batch size, and 8 workers. I guess it has something to do with the CPU IO bottleneck in the data loader? Do you have any workaround advice? I really appreciate any help you can provide.
Originally posted by @sivannavis in https://github.com/facebookresearch/sound-spaces/issues/55#issuecomment-1212628997

@sivannavis I think I pretrained the classifier and freezed it during navigation. The decrease of accuracy over time might have something to do with the non-stationary distribution of agent sampling actions and thus the distribution of classes. In another word, the accuracy measured in both training and validation stage might not be representative of all classes and thus it could be biased towards the high end initally. To verify this hypothesis, you could take the classifier trained after one epoch and evaluate it on the complete classification test set.

@ChanganVR Thank you for the reply! This is not in the navigation process yet, same as #55, only using spectrograms to predict categories, I don't think actions are involved in calculating the accuracy here. While I also find the torch.abs() in the audiogoal_trainer.py hard to understand: https://github.com/facebookresearch/sound-spaces/blob/fb68e410a4a1388e2d63279e6b92b6f082371fec/ss_baselines/savi/pretraining/audiogoal_trainer.py#L148
I'm not sure but it seems to make more sense to use predicts directly because the abs() gives the most/least possible answer without softmax.
Meanwhile, could you tell me if training savi with run.py is already using the pretrained label predictor, or do I need to specify it anywhere?

Oh, I think I found the answer to my second question in this issue https://github.com/facebookresearch/sound-spaces/issues/46#issuecomment-898688576.
I hope to confirm the following things:

I used python ss_baselines/savi/pretraining/audiogoal_trainer.py --run-type train --model-dir /scratch/sd5397/soundspaces/data/models/savi3 --predict-label to train the label predictor, which I assume is not using any pretrained predictor, and yet my accuracy starts at a very high point 95%, compared to the results from this issue.
As for the first step of training savi, the code uses the pretrained label predictor weights here: state_dict = torch.load('data/pretrained_weights/semantic_audionav/savi/label_predictor.pth') in belief_predictor. If I want to use my trained label predictor, I need to update this path with my previous best model in the output folder. Then in this process, the label predictor is fixed, and location predictor is trained.
As for the second step of training savi, I need to check the output folder from the first step and update this line with the best model https://github.com/facebookresearch/sound-spaces/blob/fb68e410a4a1388e2d63279e6b92b6f082371fec/ss_baselines/savi/config/semantic_audionav/savi.yaml#L60 . Then in this process, the entire goal descriptor is fixed and all other networks are trained.

Could you help me clarify if my understanding is right? Thank you a lot!

@sivannavis please see my responses to you below:

Yes. Apparently, the classification task is pretty easy and that's why the lable prediction has a very high accuracy after just one epoch of training.
Yes.
Yes, the pretrained weights in the first step goes here.


HDFS doesn't come back up cleanly after cluster restart

HDFS doesn't seem to come up cleanly anymore after a cluster restart:
...
File ".../flintrock/services.py", line 194, in health_check
    urllib.request.urlopen(hdfs_master_ui).read().decode('utf-8'))
  File "/usr/local/Cellar/python3/3.5.2_3/Frameworks/Python.framework/Versions/3.5/lib/python3.5/urllib/request.py", line 163, in urlopen
    return opener.open(url, data, timeout)
  File "/usr/local/Cellar/python3/3.5.2_3/Frameworks/Python.framework/Versions/3.5/lib/python3.5/urllib/request.py", line 466, in open
    response = self._open(req, data)
  File "/usr/local/Cellar/python3/3.5.2_3/Frameworks/Python.framework/Versions/3.5/lib/python3.5/urllib/request.py", line 484, in _open
    '_open', req)
  File "/usr/local/Cellar/python3/3.5.2_3/Frameworks/Python.framework/Versions/3.5/lib/python3.5/urllib/request.py", line 444, in _call_chain
    result = func(*args)
  File "/usr/local/Cellar/python3/3.5.2_3/Frameworks/Python.framework/Versions/3.5/lib/python3.5/urllib/request.py", line 1282, in http_open
    return self.do_open(http.client.HTTPConnection, req)
  File "/usr/local/Cellar/python3/3.5.2_3/Frameworks/Python.framework/Versions/3.5/lib/python3.5/urllib/request.py", line 1256, in do_open
    raise URLError(err)
urllib.error.URLError: <urlopen error [Errno 61] Connection refused>

Is anyone else seeing this?
Anyway, I will investigate.

Though this happens frequently after a reboot, it doesn't happen consistently.
Looking at the logs under ./hadoop/logs when it does happen:
2016-10-20 01:52:06,644 ERROR org.apache.hadoop.hdfs.server.namenode.SecondaryNameNode:
  Exception in doCheckpoint java.net.ConnectException:
  Call From ip-172-31-2-50.ec2.internal/<IP_ADDRESS>
  to ec2-54-157-138-65.compute-1.amazonaws.com:9000 failed on connection exception:
  java.net.ConnectException: Connection refused;
  For more details see:  http://wiki.apache.org/hadoop/ConnectionRefused
[snipped]
2016-10-20 01:53:26,657 WARN org.apache.hadoop.ipc.Client: Address change detected.
  Old: ec2-54-157-138-65.compute-1.amazonaws.com/<IP_ADDRESS>:9000
  New: ec2-54-157-138-65.compute-1.amazonaws.com/<IP_ADDRESS>:9000

java.net.ConnectException: Call From ip-172-31-2-50.ec2.internal/<IP_ADDRESS>
  to ec2-54-157-138-65.compute-1.amazonaws.com:9000 failed on connection exception:
  java.net.ConnectException: Connection refused;
  For more details see:  http://wiki.apache.org/hadoop/ConnectionRefused

this smells like it may be a similar problem to the one reported with Spark in #129.
I'll experiment with some of the *.address configs in hdfs-default.xml and see if I can understand what might be going on here.

So whenever this happens, I can just login to the cluster and call ./hadoop/sbin/start-dfs.sh and everything starts up fine.
Just like with #129, this seems to be an issue caused by some network resource taking a long time to startup. What's strange is that SSH is available by this time, and we're already logged in. So SSH is up and yet we have issues binding ports or connecting via the node's own public or private network address.
If we could hone in on a specific thing to test for, we could wait until precisely when this part of the network stack is working correctly before trying to start up HDFS or Spark.


Ported rtAudio to portaudio for evaluation.

This is a first attempt at porting rtAudio to portaudio for evaluation.

Hi @ggarra13, very interesting PR, thanks! I was looking at the PortAudio information and like the license and CMake support. If PortAudio also supports audio conversion/resampling then I think it could be a good change.
I was looking over the code changes and noticed there are a number of places where it looks like the code has been reformatted without any functional changes (e.g., TimelinePlayer::setExternalTime()). Would you mind undoing those changes so it is easier to see the actual changes? Thanks!

I'lll try to fix the reformatting.  What are your setting for formatting c++ in vim/emacs/Astyle/VS or whatever you use?  That may help me in not messing up your code (I work with emacs, btw).
I found out portaudio does not seem to do resampling per se but lets the audio card do it for you.  There's a:
Pa_IsFormatSupported( NULL, &outputParameters, sampleRate )
that can be used to verify he sampleRate and other outputParameters are valid, but in my experience it always returns paNoError.

I don't have any settings for formatting though I tend to follow the VS style since it's the IDE I use most often. Four spaces for indentation, including function calls that need to be broken up over multiple lines, and I generally try to keep line lengths to 80 chars though that's not a strict rule. The most important thing is not to reformat code that doesn't have any functional changes, if code needs formatting fixes that is best done separately.
That's unfortunate PortAudio does not support resampling, it would have been a compelling reason to replace the existing RtAudio support.

Hi @ggarra13, sorry for the delay! Support for resampling would have been a compelling reason to switch to PortAudio, but without it I'm not sure this is a good change. Especially given the amount of testing the RtAudio support has already gone through. You had mentioned some troubles you initially had with RtAudio but I think you were able to resolve them?

I don't understand it.  I searched the net about portaudio resampling and it said it didn't do it.  However, in mrViewer I resample with it just fine on Linux and macOS (I did not try Windows, perhaps that's where it fails).  The issue with RtAudio was indeed resolved with changing the cache backwards to 0.5 or higher.  Maybe it is worth testing it with a simple sine wave program.

Ideally, I would like to help you out trying to get scrubbing with audio, but my first attempts at it resulted in core dumps :(.   I am waiting to see RV, xStudio and itview source code to see whether I should join some of those projects instead.  Or maybe do a new rewrite of mrViewer (which I need to do to clean up all the spaguetti code and bad design decisions which don't allow me to incorporate OpenTimelineIO easily).
I was also looking at mlt and the shotcut editing tool which has a perfect playback system in place with multiple tracks, effects and dissolves.  The only thing missing is OCIO and flipbooks.  That's another possibility for a new mrViewer.

If you are interested in pursuing audio scrubbing it might make sense to create a proof of concept first and then we could see how it fits into the main code. The current tlRender audio code works OK but is not very extensible. Adding audio scrubbing might need some architectural changes that would be easier to try out separately first.
Maybe another idea is to use tlRender as the playback engine for mrViewer? That way you could focus on the features that make mrViewer unique, maybe tailoring it to TDs and Compositors? I would imagine there are a lot of interesting use cases that could be developed by someone with VFX pipeline experience.

I can see adding audio scrubbing by doing one of three things:

Reading an otio::RationalTime of audio and storing a 1/24 (or whatever) of audio.  Then pray the audio engine is fast enough to play each audio segment fast enough to not perceive the audio gaps.  I think this would work but it demands too much of the audio engine and if you add resampling with libswresample we may loose the speed.  This is how mrViewer works.
Reading an otio::TimeRange of audio for 1 second as it is now.  However when playback is stopped we would play 1/24 of audio by copying the audio to a temporary buffer.  My guess is that that is how RV does it.  The trick is knowing where in the TimeRange of 1 second we are at any point in time for shortening it to a RationalTime or a very short TimeRange equivalent to 1/24 of a second.
Reading an otio::TimeRange of audio for several seconds as store it in the audio cache.  When stopped, play from the cache, with the same issue of knowing where in the cache we are for the current frame.

I played with the idea of replacing the playback engine of mrViewer with tlRender and it is something I might revisit.  The main issue is that I don't know how do the Qt event loop and the FLTK event loop would work for tlRender.  This clashes also with my lack of familiarity with C++11/14 features such as std::future/std::promise.  In FLTK I would require to add a timeout of 0.001 or so to keep polling for updates to the video.

Interesting, so in mrViewer what do you do when the video rate is not a multiple of the audio rate? Like if you have 29.97FPS video and 44kHz audio?
The core of tlRender doesn't depend on Qt, it just needs some kind of event loop to tick various objects and an OpenGL window to render into. The "play-glfw" example does this using GLFW, it should also be possible to integrate with FLTK.
If you do continue with mrViewer and C++ I highly recommend learning the new features. Smart pointers (std::shared_ptr, std::unique_ptr), built-in threading (std::future, std::promise), lambdas, and some other syntax changes have made things so much easier I can't imagine not having them. There is no way I could have written tlRender and the new version of DJV without them.

El 14 ago. 2022, a las 22:56, Darby Johnston @.***> escribió:
Interesting, so in mrViewer what do you do when the video rate is not a multiple of the audio rate? Like if you have 29.97FPS video and 44kHz audio?

I store the default playback speed for the video ( say 29.97 ) and the audio ( 44 kHZ  ).  For each video I have three threads (the decode thread which just stores packets, the video thread which decodes such packets and audio thread which decodes audio packets.   I also have a subtitle thread for subtitles but that’s hardly ever used.  Stopping and starting these threads is handled by a barrier.
With FLTK, I call a timeout at the play FPS to see if the video image has been updated and if so I call the draw of the view window.  The audio is opened in a separate thread at the default frequency and the packets of the audio are decompressed into frame chunks ( of say 8192 bytes for a stereo stream) and played continuously.  With audio APIs that rely on callbacks like rtAudio or portaudio there’s always the chance of audio underrun, but I spent a lot of time streamlining the code for avoid that.
When the user changes the frame rate (to play faster or slower) I calculate a new fps and a speed factor by dividing it with the default fps of the video.  When the current audio frequency does not match the previous frequency I reopen the audio with the new frequency (ie. Multiplied by the speed factor) and keep playing it at that speed in the audio thread as before.
When I stop the playback and go step by step or do scrubbing I play the audio frame chunk for that frame which was stored in the cache.  I also keep updating the audio packets so that once the cache does not have the audio frame chunk anymore I will call the audio decompress routine once again.
The problem with my design of decompressing the packets into different threads is that it breaks when OpenTimelineIO enters the picture, as the barrier syncing all threads now does not work (the audio can stop at any time, not only at the end of the video).  That’s where your design is superior.

If you do continue with mrViewer and C++ I highly recommend learning the new features. Smart pointers (std::shared_ptr, std::unique_ptr), built-in threading (std::future, std::promise), lambdas, and some other syntax changes have made things so much easier I can't imagine not having them. There is no way I could have written tlRender and the new version of DJV without them.

I am not sure yet what I’ll do with mrViewer.  I recently bought Scott Meyer's Effective Modern C++ and I am reading it at night to catch up.
OH!  So you are writing a new version of DJV?  I thought tlplay was it.
—
Gonzalo Garramuno
@.***

Just to follow up on this, maybe we should close this PR since you created a new issue for audio scrubbing:
https://github.com/darbyjohnston/tlRender/issues/44

So you are writing a new version of DJV?  I thought tlplay was it.

Sorry, I meant the current 2.x versions of DJV as opposed to the previous 1.x versions.
I think of tlplay as the reference application for the tlRender libraries. It demonstrates and exercises all of the functionality in tlRender but not necessarily in the most user friendly way.


CalDAV integration?

Hi,
This plugin is a fantastic work! Many thanks to its initiators and contributors!
Still, I have only a limited use of this plugin because it does not intergrate / sync with GNOME Calendar or any CalDAV standards. Is there any prospect to change this in the near future?
Best, AL

Hi,
that would be really nice, for example CALDAV support would allow to integrate with Nextcloud Calendar.

Hi,
I can use Nextcloud Calendar. You can take the Abonementlink from the Calendar.
If it doesn't fetch, disabled the plugin and enable it again.


General users cannot create resources and view dependency graph.

Describe the bug

Steps to reproduce

Log in as a general user.
Create a project and a environment.
Click on the environment name and create a service.

Result

No Services/Resources and Dependency Graph tabs

Expected behavior

General users can create resources and view dependency graph.

Environment

Walrus version: main 9e14c25ece772fbb582b0be93a0fdb5e486fd53e
UI version: dev-e15ef2e

Additional context
Add any other context about the problem here.

Environment

Walrus version: main a3e5c0343d3e831ca30e4fd76a160212bc5bba7f
UI version: dev-20df538

Test Result: pass


NotAuthorizedException

I'm getting

UploadTask: Failed to upload: 11 due to Unauthenticated access is not supported for this identity pool. (Service: AmazonCognitoIdentity; Status Code: 400; Error Code: NotAuthorizedException;

error in logcat.
setupWithCognito return true. What am I missing?
I'm new to AWS so I am not sure where to look.

Hey @damathryx , I see you closed this issue with no solution. How did you handle this please?

@Blapi if my memory serves me right I was missing this on AndroidManifest
<service   android:name="com.amazonaws.mobileconnectors.s3.transferutility.TransferService"   android:enabled="true" />


Add HEP for PCI Device Plugins [CI SKIP]

Problem:
To enable devices to be added to the cluster and have them correctly accounted for, without editing the KubeVirt CR. And further to enable specific PCI addresses to be bound to a VM.
Solution:
https://github.com/tlehman/harvester/blob/hep-dp/enhancements/20221028-pci-deviceplugin.md
Related Issue:
https://github.com/harvester/harvester/issues/3146
https://github.com/harvester/harvester/issues/2991
https://github.com/harvester/pcidevices/issues/19
https://github.com/harvester/pcidevices/issues/29
https://github.com/harvester/pcidevices/pull/27
Test plan:
CI Disabled for this PR, since it's just static markdown documents.

WIP commit for DP work https://github.com/tlehman/pcidevices/commit/7ad5ac1d50ad6e325a2699f81ebe460231c21484


Pagination active is misleading

Hi @satyawikananda
Nice to meet you, I'm really excited to contribute to this repo and I'm very happy if i'm able to fix this issue and create new PR.
In my point of view, the active pagination looks like give me an information that i'm currently in second page. But, actually we are in first page.
I think we need to switch the active color or just flip it, from gray to white. How do you think?
Looking forward to working closely with you
Thank you

Okay, I agree, you can create a PR to fix this issue :)

I'm working on it

fixed in #7


Information disclousure, password plaintext storage

On request below application returns sensitive user information like password.
It means also that passwords of users are stored in databese in plain text. It should be stored only as a hash of user password.
References:
https://www.owasp.org/index.php/Information_Leak_(information_disclosure)
https://www.owasp.org/index.php/Password_Storage_Cheat_Sheet
Request:
POST /mythaistar/services/rest/bookingmanagement/v1/booking/search HTTP/1.1
Host: xxxx
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Firefox/52.0
Accept: application/json, text/plain, */*
Accept-Language: en-US,en;q=0.5
Accept-Encoding: gzip, deflate
Authorization: Bearer eyJhbGciOiJIUzUxMiJ9.eyJzdWIiOiJ3YWl0ZXIiLCJzY29wZSI6W3siYXV0aG9yaXR5IjoiUk9MRV9XYWl0ZXIifV0sImlzcyI6Ik15VGhhaVN0YXJBcHAiLCJleHAiOjE1MTA4MzczNzksImlhdCI6MTUxMDgzMzc3OX0.gjZsyVCmuCuxVr9dEDDyr9mXJ_yC04yx3dOG03dR76zvoEVBZTqZa5FlRKQ3s_USGfuaNL0CW0OiRu5cceYu1A
Content-Type: application/json
Referer: xxxx/reservations
Content-Length: 87
Origin: xxxxx
Connection: close
{"email":null,"bookingToken":null,"pagination":{"size":8,"page":1,"total":1},"sort":[]}

Response:
HTTP/1.1 200
X-Content-Type-Options: nosniff
X-XSS-Protection: 1; mode=block
Cache-Control: no-cache, no-store, max-age=0, must-revalidate
Pragma: no-cache
Expires: 0
X-Frame-Options: DENY
Access-Control-Allow-Origin: xxxx
Vary: Origin
Access-Control-Allow-Credentials: true
X-Application-Context: xxxx
Date: Thu, 16 Nov 2017 12:20:23 GMT
Content-Type: application/json
Connection: close
Content-Length: 7300

{"pagination":{"size":8,"page":1,"total":36},"result":[{"booking":{"id":0,"modificationCounter":1,"revision":null,"name":"user0","bookingToken":"CB_20170509_123502555Z","comment":"Booking Type CSR","bookingDate":1510590903057,"expirationDate":1510587303057,"creationDate":1510158903057,"email":"user0@mail.com","canceled":false,"bookingType":"COMMON","tableId":0,"orderId":0,"assistants":3,"userId":0},"table":{"id":0,"modificationCounter":1,"revision":null,"seatsNumber":4},"invitedGuests":[],"order":{"id":0,"modificationCounter":1,"revision":null,"bookingId":0,"invitedGuestId":null,"bookingToken":null,"hostId":0},"orders":[{"id":0,"modificationCounter":1,"revision":null,"bookingId":0,"invitedGuestId":null,"bookingToken":null,"hostId":0}],"user":{"id":0,"modificationCounter":1,"revision":null,"username":"user0","password":"password","email":"user0@mail.com","userRoleId":0}},{"booking":{"id":1,"modificationCounter":1,"revision":null,"name":"user1","bookingToken":"CB_20170510_123502575Z","comment":"Booking Type
[...]

@opermajki thanks for the finding and this issue.
The devonfw initiative is IMHO a very great initiative with lots of highlights but to be very honest, this issue on the other hand shows that there are also low-lights. It is a pitty that such an issue exists in devonfw that claims to reduce risks and be a great solution for IT security. If the detailed guides that we have online would have been read and honored, this security and data-privacy desaster would of course not have happened. The actual pain-story however is that we have not been able to make any progress and more or less ignored this issue for 1+ year!
I marked this sisue as bug and blocker and will put priority on this so we will get this fixed.  Lets try to make the best for the future, keep on going to continuously improve devonfw and my-thai-star and make things like this become history to forget one fine day :)

For the record. The result contains information about different users of the my-thai-star application like this:
"user": {
      "id":0,
      "modificationCounter":1,
      "revision":null,
      "username":"user0",
      "password":"password",
<EMAIL_ADDRESS>      "userRoleId":0
    }

We should never ever store and never never ever allow to retrieve passwords of users. This is completely inacceptable. If we would do so in an application for our customer even if there is no demand/requirement about this it would be a bug and we could easily get sued for such mistakes as IT security (at least for such obvious cases) is an implicit MUST requirement.
Also regarding GDPR (EU data privacy rights) we should be careful about personal data such as email addresses. It may be acceptable for an admin to retrieve a list of users with their email addresses, names, etc. but if regular users of the system (especially guests) may retrieve such personal data of other persons this is also a severe bug that could result in suing us and getting a expensive fine.


Revert "Revert "Support passing props to tab routes""

Reverts aksonov/react-native-router-flux#1129

Unit test fails, I thought because of this PR, but it is not the reason... I will merge it again.

Would love a new versioning for this, @aksonov. It's not optimal to pull it from Github 😄 Thanks in advance!


5 new validators & improvements to how macros work

Added validators:

not_contain
not_contain_any
contains_only
alphanumeric
alphanumeric_dashes

Moved imports to inside the rules macro so users don't have unused import warnings.

@tcmal I don't have time right now to update the crate at the moment because of holidays, but if you would like, I could grant you rights to the repo and add you as a crate owner so you could do it yourself. Are you interested in that?

Sure.

@tcmal I have sent you invites on github and crates. Holla if you need me!


Added -i/--include to mafia quick and mafia watch

/cc @charleso @nhibberd

Seems legit :+1:

:trophy:


rect elements are forced to a square

Using the plugin Better Status Indicators and looking at mobile status indicators, one can notice that mobile status indicators look off.

Upon further inspection, it seems that the height and y attributes of the rect element inside the foreignObject are set to the same value as the width and x attributes' values.

This only occurs when running under pc-compat.

Try the dev branch for me.

I've replicated this on the dev branch

Fixed in 2ca19a59fc31f199572068bc66e5c3e5ec9ffbad


Can't run JavaScript

`
Unable to run
babel-node
Did you start Atom from the command line?
atom .
Is it in your PATH?
PATH: /usr/local/bin:/usr/bin:/bin:/usr/sbin:/sbin`
I installed latest Node.js already. I saved the file as .js, I've tried running atom with Terminal.

@jmangz This has now been addressed in fc84ded7dad08466923071e6d6e4370aa6a36789, and should 'just work' by using the preconfigured Babel setup in this package instead of having to set it up locally every time or worse, globally.

@danielbayley Thanks so much.


fix: clean up example button widgets

I noticed when experimenting with the overlay example, that the camera switching button had no color defined (and was invisible when I tried it in my app initially), and that the flash-unavailable icon did not take as much space as the flash icon button (and was a different size).  This attempts to fix those issues.
Before:
https://github.com/user-attachments/assets/090825e0-337a-4029-80b2-d3a0d14bd5f1
After:
https://github.com/user-attachments/assets/414fdff9-95e9-4968-a354-d7294533e689

Hopefully one of many! If you find the bug for the scanner overlay, fell free to send another fix in my direction.

Whoops, I took your suggestion without testing it, and now I see that it centers on the wrong axis.

Oh, I think it's because I didn't specify a height for the SizedBox, I'll push a fix.

If I can ask,  @navaronbracke, what is the purpose of wrapping the icon in Center?  It seems to have no effect, and SizedBox appears to center the child anyway, and in fact I see suggestions to use it as a way to apply padding around a widget, which is essentially what I'm doing.

So in this case, since there was an size specified on the icon, it overrides the height/width that the SizedBox is imparting, so there's no visual difference?  I need to find a good way to visualize layouts in flutter.  With CSS I'd just start giving various elements a background color (or more likely, use the inspect tool to see their bounding boxes).  Wonder if there's anything like that for this…

I need to find a good way to visualize layouts in flutter.

I do suggest you start using the Flutter DevTools, which includes a layout explorer.


AFGO implementation

Including both VCs and Presentations in both json-ld and jwt formats.
It supports all the keys mentioned in the README.
Signed-off-by: Mykhailo Sizov<EMAIL_ADDRESS>Signed-off-by: Baha Shaaban<EMAIL_ADDRESS>closes #4

closes https://github.com/hyperledger/aries-framework-go/issues/3288

@OR13 can you review

This is awesome!

@Baha-sk when all test cases passing can you post screenshot.

@OR13 baha will post screenshot when all test cases are passing

@OR13 when I run the VC verification commands for afgo as per the README doc, eg:
% IMPLEMENTATION=afgo
INPUT=/data/implementations/$IMPLEMENTATION/credential-0--key-0-ed25519.vc.json
OUTPUT=/data/implementations/$IMPLEMENTATION/credential-0--key-0-ed25519.vc.verification.json

docker-compose run $IMPLEMENTATION \
credential verify \
--input $INPUT \
--output $OUTPUT

or jwt :
% IMPLEMENTATION=afgo
INPUT=/data/implementations/$IMPLEMENTATION/credential-0--key-0-ed25519.vc-jwt.json
OUTPUT=/data/implementations/$IMPLEMENTATION/credential-0--key-0-ed25519.vc-jwt.verification.json

docker-compose run $IMPLEMENTATION \
credential verify \
--input $INPUT \
--output $OUTPUT

the output file content is as expected:
{
    "verified": true
}

but when running the verify command (npm run report:evaluate), all vc and presentation results of afgo results fail in index.html, while the jwt ones are all successful (except maybe for one rsa key that also fails in jwt format).
I tried to run the doker-compose command using transmute with afgo credential files like so:
% IMPLEMENTATION=transmute
INPUT=/data/implementations/afgo/credential-0--key-0-ed25519.vc.json
OUTPUT=/data/implementations/afgo/credential-0--key-0-ed25519.vc.verification.json

docker-compose run $IMPLEMENTATION \
credential verify \
--input $INPUT \
--output $OUTPUT

but I get this output error:
Creating jws-test-suite_transmute_run ... done
✨ credential [action]

Verify a verifiable credential

Options:
      --version  Show version number                                   [boolean]
  -h, --help     Show help                                             [boolean]
  -i, --input    Path to input document                               [required]
  -o, --output   Path to output document                              [required]
  -k, --key      Path to key
  -f, --format   Input format                                    [default: "vc"]

RangeError: Maximum call stack size exceeded
    at JSON.stringify (<anonymous>)
    at Error.value (/home/node/node_modules/@transmute/linked-data-proof/dist/linked-data-proof.cjs.development.js:626:23)
    at JSON.stringify (<anonymous>)
    at Error.value (/home/node/node_modules/@transmute/linked-data-proof/dist/linked-data-proof.cjs.development.js:626:23)
    at JSON.stringify (<anonymous>)
    at Error.value (/home/node/node_modules/@transmute/linked-data-proof/dist/linked-data-proof.cjs.development.js:626:23)
    at JSON.stringify (<anonymous>)
    at Error.value (/home/node/node_modules/@transmute/linked-data-proof/dist/linked-data-proof.cjs.development.js:626:23)
    at JSON.stringify (<anonymous>)
    at Error.value (/home/node/node_modules/@transmute/linked-data-proof/dist/linked-data-proof.cjs.development.js:626:23)
ERROR: 1

any idea how to troubleshoot this? not sure how JSON.stringify() spits the error about this instance, but it's probably too large?

@OR13 @Baha-sk I found the issue. Will push fix soon

Currently, all tests are passing except for credential 2 as per @fqutishat's question to @OR13  above. Investigating next step to resolve the issue.

IMO, implementations should not be mutating payload arguments, but obviously the spec isn't clear enough on this.
When in doubt, do not mutate a function parameter... ever.

all checks are passing now

@OR13 can merge all AFGO test is passing

great thank you @OR13, when will https://identity.foundation/JWS-Test-Suite/#implementations be updated with afgo?

it should happen automatically... if things were registered properly.

The reason i'm asking is that I don't see Microsoft in index.json, while it does show in the link above. I thought it would take some manual update somewhere to get afgo in there as well.

it seems to show now.. thanks!


julia-dev broke function documentation

Current master seems to have broken the way DataFrames annotates its functions
Versioninfo:
julia> versioninfo()
Julia Version 0.4.0-dev+6693
Commit c61cd8b (2015-08-13 00:28 UTC)
Platform Info:
  System: Linux (x86_64-unknown-linux-gnu)
  CPU: Intel(R) Core(TM) i5-4210U CPU @ 1.70GHz
  WORD_SIZE: 64
  BLAS: libblas
  LAPACK: liblapack
  LIBM: libm
  LLVM: libLLVM-3.6.2

Error message:
ERROR: LoadError: LoadError: Invalid doc expression [:rename!,:rename]
while loading /home/wallnuss/.julia/v0.4/DataFrames/src/abstractdataframe/abstractdataframe.jl, in expression starting on line 167
while loading /home/wallnuss/.julia/v0.4/DataFrames/src/DataFrames.jl, in expression starting on line 79

Seems to be JuliaLang/julia@61f85adb3177791a78f00d2cfd07fbdbf9d85923

Thanks for reporting!
It's not obvious for me what is the proper way to document multiple functions at once.
Could you please also report the issue upstream, so that the devs are aware that this change is breaking packages?

It might be easier to just ping @one-more-minute

It's actually a good thing this came up, since before you were just documenting the array [:rename!,:rename] in 0.4 (I think that syntax is supported by Docile, which is probably why you were using it).
Feel free to open an issue about this and we can discuss syntax for documenting multiple things at once.

Until a decision is made in https://github.com/JuliaLang/julia/issues/12615 you can disable the docstring in 0.4 by appending a ; to the end of it, ie.
"...";
[a, b]

It'll still work fine in 0.3 with Docile.

julia-dev now provides syntax for documenting multiple function definitions [1]. Altough I don't know whether that is backwards compatible to 0.3
https://github.com/JuliaLang/julia/commit/a7cd5904118a14bc2840d79a1ad2bbbdb5f82e4c

The syntax is also supported in Docile as of 0.5.16, tagged yesterday.
Quoted symbols such as [:rename!, :rename] will need to be changed to [rename!, rename] and moved to after their definitions. Otherwise the following kind of thing happens:
julia> "..."
       :foo, :bar
  ...

julia> Main.__META__
ObjectIdDict with 3 entries:
  :foo                     => Base.Markdown.MD(Any[Base.Markdown.Paragra…
  :bar                     => Base.Markdown.MD(Any[Base.Markdown.Paragra…
  #= circular reference =# => Base.Markdown.MD(Any[Base.Markdown.Paragra…

The quoted form can only be supported in Docile because it looks for docstrings after the module has be loaded rather than during macro expansion like @doc does.

I cloned the package from github hoping to get around this to allow me to continue testing/working with 0.4-dev - but I'm still seeing the problem..
et-imac-retina:julia sjbespa$ ./julia
_
_       _ ()_     |  A fresh approach to technical computing
()     | () ()    |  Documentation: http://docs.julialang.org
_ _   | |  __ _   |  Type "help()" for help.
| | | | | | |/ ` |  |
| | || | | | (| |  |  Version 0.4.0-dev+6787 (2015-08-17 18:41 UTC)
/ |_'|||_'_|  |  Commit 72431c5 (0 days old master)
|__/                   |  x86_64-apple-darwin14.5.0
julia> using DataFrames
INFO: Recompiling stale cache file /Users/sjbespa/.julia/lib/v0.4/Compat.ji for module Compat.
INFO: Recompiling stale cache file /Users/sjbespa/.julia/lib/v0.4/Docile.ji for module Docile.
ERROR: LoadError: LoadError: Invalid doc expression [:rename!,:rename]
in include at ./boot.jl:259
in include_from_node1 at ./loading.jl:266
in anonymous at no file:110
in include at ./boot.jl:259
in include_from_node1 at ./loading.jl:266
in require at ./loading.jl:205
while loading /Users/sjbespa/.julia/v0.4/DataFrames/src/abstractdataframe/abstractdataframe.jl, in expression starting on line 167
while loading /Users/sjbespa/.julia/v0.4/DataFrames/src/DataFrames.jl, in expression starting on line 79
Can I do anything to either properly download the latest DataFrames.jl or help you figure out what's up?
Stephen

@protogeezer The head of the master branch has a fix for a few days already. Pkg.checkout("DataFrames") would switch your copy to that revision.
Actually, the new version of the package should be tagged very soon, so you don't need to bother with the "master" at all, just make sure you have the recent build of julia 0.4dev.

Thanks! I totally missed the difference between clone and checkout...


struct LossLess: Make Rav1dFrameHeader_segmentation::lossless a bit array

Part of #1180.

I'm working on trying to fix #1180; this is one of a bunch of steps.

If I'm understanding this correctly, it seems like the main optimization here is using a bitmask operations (LossLess::get) over an array index operation. It's not clear to me that this would necessarily be more efficient though. Have you profiled this and observed a clear performance improvement?

No, I didn't profile this one individually yet.  It does remove the bounds checks, though I guess that's also solved by SegmentId and InRange later on.  It does also use less memory, which I think is useful as well.

It does remove the bounds checks, though I guess that's also solved by SegmentId and InRange later on. It does also use less memory, which I think is useful as well.

Given that you have other changes that target bounds checks for the lossless array, the only real advantage here is the memory reduction. That may still be a nice optimization to have, depending on how many of these are expected to be in memory at once, i.e. how many frame headers there are at a given time. I'm assuming not many, so this doesn't really seem like a worthwhile change to me, but I could be wrong about that. @fbossen might be the best person to weigh in on if this is a reasonable optimization.

Given that you have other changes that target bounds checks for the lossless array, the only real advantage here is the memory reduction. That may still be a nice optimization to have, depending on how many of these are expected to be in memory at once, i.e. how many frame headers there are at a given time. I'm assuming not many, so this doesn't really seem like a worthwhile change to me, but I could be wrong about that. @fbossen might be the best person to weigh in on if this is a reasonable optimization.

It's not just about less overall memory, for which memory reductions would be quite small, but about what could be cached.
@fbossen, what do you think?

 The potential memory saving here is too small to have a positive impact.


this.oAuthService.hasValidAccessToken() always returns false in IE and Egde

I am using angular-oauth2-oidc library to authenticate my web add in across Identity Server 4 along with Office Dialog API.
In Microsoft Edge and Internet Explorer when I check this.oAuthService.hasValidAccessToken() [even this.oAuthService.hasValidIdToken()] It always returns false.
Whereas In Chrome It is working fine without interruption.
Here is the code I am using app.component.ts:
    this.oAuthService.configure(authConfig);
    this.oAuthService.tokenValidationHandler = new JwksValidationHandler();
    this.oAuthService.setupAutomaticSilentRefresh();

    this.oAuthService.loadDiscoveryDocumentAndTryLogin().then(() => {
      if (this.oAuthService.hasValidAccessToken()) {
        // Load UserProfile to get the additional claims
        this.oAuthService.loadUserProfile();
      }
    });

Can anyone help with this issue ?

I presume this is now no longer an issue in Edge, since it uses Chromium now?
Either way, I think either this community needs (lots of) help to get a minimal reproducible scenario going, or you need to turn to the Office Dialog API community...

Just tried on the new Chromium version of Edge and it seems to be working now.

facing the same problem, this.oAuthService.hasValidAccessToken() always returns false in IE(11.778) and Edge(v44.18). It is working fine in Chrome though. Edge is our target browser and cant really push for a enterprise-wide upgrade of Edge because of this issue. Please suggest a workaround to make angular-oauth2-oidc work with Edge v44


Added zoom again

fixes #453

@shantanuchhabra I agree, we should have human-readable names for all magic numbers like that.


Direct Fedora users to use the Flatpak instead of old RPM versions

Description
https://github.com/ungoogled-software/ungoogled-chromium-fedora/issues suggests that this particular project is not updated
Who's implementing?

[ ] I'm willing to implement this feature myself

The problem
https://github.com/ungoogled-software/ungoogled-chromium-fedora/issues and https://build.opensuse.org/project/show/home:ungoogled_chromium suggest that the Fedora packages have not being updated
Possible solutions
Change https://github.com/ungoogled-software/ungoogled-chromium/blob/master/README.md to suggest that Fedora users use the Flatpak
Alternatives
No response
Additional context
No response

to suggest that Fedora users use the Flatpak

There is already such a suggestion present: https://github.com/ungoogled-software/ungoogled-chromium/blob/fe594685bf3983ea9cf698e347c62e33d0665622/README.md?plain=1#L110

@PF4Public I think he'd like this part of the README removed:
Fedora: Available in OBS, by following [instructions](https://github.com/ungoogled-software/ungoogled-chromium-fedora) in the downloads section. Also available in [RPM Fusion](https://rpmfusion.org/Configuration) as chromium-browser-privacy (outdated).

@PF4Public I think he'd like this part of the README removed:

I personally see no reason in removing and then restoring that line later if maintenance status changes. It's just obvious that if repository has no activity, it is not maintained and therefore one is either invited to contribute or search for alternatives, like Flatpak. Removing it sounds more like bike-shedding to be honest.
Although I must admit it might be a good idea to mention the maintenance status (of all repos actually) right there to spare user wandering time.

user wandering time

This is why I raised this issue - thanks for phrasing it better than I did

Is this a problem anymore? I just typed sudo dnf install ungoogled-chromium without setting up any COPRS and I have version 123.0.6312.58 installed, which is only a week old and one version behind, and I assume it'll be updated soon for the latest version pretty soon.

Is this a problem anymore? All I typed was sudo dnf install ungoogled-chromium without setting up any COPRS and I have version 123.0.6312.58 installed, which is only a week old and one version behind, and I assume it'll be updated soon for the latest version pretty soon.

Interesting. Could you show us who's the vendor of your package by posting here the result of rpm -qi ungoogled-chromium | grep Vendor?

Is this a problem anymore? All I typed was sudo dnf install ungoogled-chromium without setting up any COPRS and I have version 123.0.6312.58 installed, which is only a week old and one version behind, and I assume it'll be updated soon for the latest version pretty soon.

Interesting. Could you show us who's the vendor of your package by posting here the result of rpm -qi ungoogled-chromium | grep Vendor?

Sorry, I wrote that comment really late at night, so it's completely wrong lol. I actually did did add a COPR for it:
Vendor      : Fedora Copr - user wojnilowicz
Here is the COPR. Seems maintained for now. Thought it does say:

Please be aware that this repo might be discontinued at any time, so monitor for updated versions of this package and if they are not coming then it might be safer to switch to another source of web browser.

Depending on how long this COPR is maintained for, perhaps Fedora instructions could link to this instead?

Anyone up for a PR? :D

Anyone up for a PR? :D

As discussed in https://github.com/ungoogled-software/ungoogled-chromium-fedora/issues/28 (sorry because I didn't notice this issue before and caused some confusions there), the plan now is that I will create a PR to add a link to the COPR, and I'm working on bring back the RPM Fusion package.


Added solution for 0745 - Prefix and Suffix Search

File(s) Modified:  0745-prefix-and-suffix-search.py
Language(s) Used: Python
Submission URL: https://leetcode.com/problems/prefix-and-suffix-search/submissions/1409758540/

Important
Please make sure the file name is lowercase and a duplicate file does not already exist before merging.

@jelonmusk Thanks for your contribution 👍


Allow start/end when reading from the API in CountReads, improve script documentation.

Coverage decreased (-0.07%) to 23.49% when pulling 213acd003736b1d4e13fd3eba3564f5cc134ad22 on iliat:dev-broad into 70bc9f7dddca53a623a7bb66436fe43ac411f33c on googlegenomics:master.

Nice update Ilia!

Thanks for the quick fix Ilia :)


Verify metrics name in influxdb

Check if this has changed in the underlying DB.

I'm not sure what should be done in this issue. @fgrzadkowski @mwielgus any ideas?

The names have changed. We should document this. Closing in favor of https://github.com/kubernetes/heapster/issues/1009#issuecomment-190739123


pg_repack 1.5.2: Allow to run pg_repack by non-superuser

What kind of change does this PR introduce?

upgrade pg_repack from 1.5.0 to 1.5.2.

Additional context
New version will allow to run pg_repack by a non-superuser. Conversation on slack:
https://supabase.slack.com/archives/C02FHG9QQAF/p1730124043199329
PR on pg_repack repo:
https://github.com/reorg/pg_repack/pull/431
1.5.2 doesn't have release or tag yet, therefore instead of the tag commit id is used (85b64c6d4f599b2988343c4e7121acab505c9006).
Action Items

[x] New extension releases were Checked for any breaking changes
[x] Extensions compatibility Checked

Proceed to extensions compatibility testing, mark as done after everything is completed

[ ] Backup and Restore Checked

Proceed to backup testing while extensions are enabled

After every restore, re-run the tests specified at point 3.1

Extensions compatibility testing

Enable every extension

Check Postgres’ log output for any error messages while doing so

This might unearth incompatibilities due to unsupported internal functions, missing libraries, or missing permissions

Disable every extension

Check Postgres’ log output for any cleanup-related error messages

Re-enable each extension

Run basic tests against the features they offer, e.g.:

pg_net - execute HTTP requests
pg_graphql - execute queries and mutations
…to be filled in

Backup Testing
Follow the testing steps steps for all the following cases:

Pause on new Postgres version, restore on new Postgres version
Pause on older Postgres version, restore on new Postgres version
Run a single-file backup backup, restore the backup

Testing steps

Generate dummy data

the ‘Countries’ or ‘Slack clone’ SQL editor snippets are decent datasets to work with, albeit limited

Save a db stats snapshot file

Do this by running supa db-stats gather -p <project_ref>

Backup the database, through pausing the project, or otherwise
Restore the backup, through unpausing the project or cli
Check the data has been recovered successfully

Visual checks/navigating through the tables works
Run supa db-stats verify against the project and the previously saved file

Would it be possible to add a test for ensuring this works?
There are some example tests on https://github.com/supabase/postgres/tree/develop/nix/tests/sql


Add Pierre Beitz (pierrebtz) to the cloudbees-jenkins-advisor plugin

Description
Add Pierre Beitz (pierrebtz) to the cloudbees-jenkins-advisor plugin (https://github.com/jenkinsci/cloudbees-jenkins-advisor-plugin). CC @aheritier
Request in the Jenkins mailing list: https://groups.google.com/g/jenkinsci-dev/c/5LMUo5qOoFo/m/q8_Jew9GDAAJ

Submitter checklist for adding or changing permissions

Always

[x] Add link to plugin/component Git repository in description above

For a newly hosted plugin only

[ ] Add link to resolved HOSTING issue in description above

For a new permissions file only

[ ] Make sure the file is created in permissions/ directory
[ ] artifactId (pom.xml) is used for name (permissions YAML file).
[ ] groupId / artifactId (pom.xml) are correctly represented in path (permissions YAML file)
[ ] Check that the file is named plugin-${artifactId}.yml for plugins

When adding new uploaders (this includes newly created permissions files)

[x] Make sure to @mention an existing maintainer to confirm the permissions request, if applicable
[x] Use the Jenkins community (LDAP) account name in the YAML file, not the GitHub account name
[x] Make sure to @mention the users being added so their GitHub account names are known if they require GitHub merge access (see below).
[x] All newly added users have logged in to Artifactory at least once

Reviewer checklist (not for requesters!)

[ ] Check this if newly added person also needs to be given merge permission to the GitHub repo (please @ the people/person with their GitHub username in this issue as well). If needed, it can be done using an IRC Bot command
[ ] Check that the $pluginId Developers team has Admin permissions while granting the access.
[ ] In the case of plugin adoption, ensure that the Jenkins Jira default assignee is either removed or changed to the new maintainer.
[ ] If security contacts are changed (this includes add/remove), ping the security officer (currently @daniel-beck) in this pull request. If an email contact is changed, wait for approval from the security officer.

There are IRC Bot commands for it

👍 from me.


Y Axis

adding basic support for Y-Axis #118 (and part of #97 and #33)

Would you mind merging latest dev back into your branch and handling the conflicts, and re-pushing the merge?


Logos and logout button

Logos and logout button need to be aligned properly in 4k resolution

Issue got Resolved


upup doesnt play nice with other service workers

in my observation, upup doesn't play nice with other service workers. I am primarily talking about google analytics sw which is registered before upup, but only upup seems to register. When removing upup, analytics sw is registered.
Expected Behavior
registering multiple service workers should show them listed in chrome dev tools under 'Application'
Current Behavior
Only upup is listed as registered service worker
Your Environment

Version used: upup0.3
Browser Name and version: Chromium 56.0.2924.76
Operating System and version (desktop or mobile): Linux

Only a single service worker may be active on the page at one time.
To allow UpUp to work together with other service workers, it will need to be modified so that it is loaded completely different, and imported into another service worker.
The philosophy behind UpUp is to solve a simple use case, without forcing the user to undergo a complex integration as would be required for the approach described above.


[swift-nio] Drop 4.2 configuration and un-XFAIL 5.0 since perf issue …

…has been addressed
5.0 configuration is currently UPASS'ing in the suite and 4.2 is no longer supported per https://github.com/apple/swift-nio/issues/2241.

@swift-ci please test


Create Toast Hook

Overview
Create a hook to support use of Toasts throughout our app. We may want to leverage a similar OverlayContext pattern used throughout v2.
Deliverables

[ ] A useToast hook added to support our Toast components
[ ] (optional) OverlayContext pattern (or at least testing to see if our implementation would support this approach) -- defer to you on this one @jordanlesich!

Details

Should we look to refactor/reuse patterns such as the in the OverlayContext in v2? (https://github.com/HausDAO/daohaus-app/blob/develop/src/contexts/OverlayContext.jsx)

This version leverages the useToast hook from Chakra, so we may be able to look to this for inspiration for this hook

Related Issues

#237

Resources

Chakra UI useToast Code

@jordanlesich -- i added some additional notes here, but i know you also have more context for this than i do!

@jonathanprozzi Notes are good. Going to jam this in HausThemeContext I think.


Test cases

Test cases implemented -
API GATEWAY

Server test (Heartbeat)

AUTH SERVICE

Server test (Heartbeat)

PROFILE SERVICE

Server test (Heartbeat)

The same test suite is used in the Jenkins pipeline.

RADAR SERVICE

Server test (Heartbeat)


add a dummy test

add a dummy test so I can bootstrap the integration tests in konflux. See  https://gitlab.cee.redhat.com/releng/konflux-release-data/-/merge_requests/1306

interesting I commented "/lgtm" and it assigned the PR to me :)

Please delete dummy-test as nothing links to it


Source codes are missing on PyPi

Hi,
I noticed the latest versions of azure-mgmt-nspkg and azure-nspkg has only binary wheels but not source codes uploaded to PyPi. This blocks our dependency update workflow, could you upload the source codes to PyPi asap? Much appreciated!

Hi @jangsutsr
It's on purpose, this package is only necessary for whl installation (note that no setup.py has it, this dependency is added automatically when our custom bdist_wheel command is called). More details of this process here.
But please, describe me your workflow so I can understand if I miss something :)

@lmazuel It's mainly a policy constraint, because we are using Red Hat's build system and it disallows using Python dependencies without source distribution included. Before we were using azure-.*nspkg 1.0 and those includes source distributions even if it's unnecessary to.

@lmazuel I'm packaging the SDK for openSUSE and SUSE Linux Enterprise and I'm running into the same problem.

@lmazuel Also, is there a reason why pip install --pre azure does not install all packages from the SDK? It would be nice if it did because then we could pull all packages with a single command line:
pip download --pre --no-binary :all: azure

Hi @glaubitz , @jangsutsr
About the source files, we currently apply some logic into the bdist_wheel step in our packages that I didn't replicate yet in azure-nspkg (because this package is only interesting as a wheel). Publishing the sources, means that using setuptools you will install azure-nspkg 2.0.0 (currently with the lack of sources, it's 1.0.0), and will break setuptools users. If you need the source right now, you can take it on Github. From PyPI, I will need to apply the same bdist_wheel step to be sure setuptools users on PyPI are safe. On my roadmap.
About the question "why not all packages", it's because some of them are first preview version with lack of tests and review. We want to make clear by manual install, that they might break in a close future. azurebundle contains packages correctly tested at the SDK and/or at the CLI level. Goal is of course to have everything in azure eventually.

@lmazuel Wouldn't tagging those packages as "preview" help here?

@glaubitz that's an excellent question. I guess it's now possible, but back in time the entire ARM eco-system was in preview (I released 2.0.0 last week, but before that it was 2.0.0rc6 and latest stable was 1.0.0 from August 2015).
So currently, all X.Y.Z versioned packages are in "azure" (X != 0), some 0.Y.Z are in "azure", but have not yet be confirmed as stable by the team (reading semantic versioning, it's acceptable that 0.Y.Z might introduce breaking changes), and several 0.Y.Z are not in "azure" because they are not tested enough, or not stable enough.
In an ideal world, all packages in "azure" should be X.Y.Z packages, and not stable should be X.Y.ZrcX.
I will consolidate the packages versioning in the next release to make it more simple to use.
Thanks for the feedback :)

I'm closing this one, since I just released on PyPI the source for all nspkg packages. Sorry for the delay, I had to make sure no side effect will come.


Allow sky providers for ondemand clusters

#692  👈
main

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @carolineechen and the rest of your teammates on  Graphite


Update dependencies to latest versions

The ExtensibleLoadManagerTest is flaky, I will investigate

GCC 4.8 is incompatible with Boost 1.84 so I reverted the Boost version upgrade. In future, we can use RockyLinux as the RedHat-based image to build RPM packages.


allure-notifications doesn't works with Maven project

So I used a maven project,  repeated all steps which was provided in the documentation and put allure-notifications-3.1.2.jar in the root of project.
Also add additional dependency:

eu.nuvolar.frontendtestframework
allure-notifications
3.1.2
system
${project.basedir}/allure-notifications-3.1.2.jar

and
repository>
qa.quru
allure-notifications
file:${project.basedir}

On Post action plugin i filled following args:
java
"-Dchat.id=#qa-jenkins-jobs-bot"
"-Dbot.token=xoxb-2940401251-2863611473591-j***"
"-DprojectName=${PROJECT_NAME}"
"-Dproject.name=${JOB_BASE_NAME}" \
"-Dbuild.launch.name=Some release 2.0"
"-Dbuild.env=https://prod.your.site"
"-Dbuild.report.link=${BUILD_URL}" \
"-Dlang=en"
"-Denable.chart=true"
"-Dallure.report.folder=./allure-report/"
-jar allure-notifications-3.1.2.jar
In the Build Output log i see:
Error: Could not find or load main class
Caused by: java.lang.ClassNotFoundException:
POST BUILD TASK : FAILURE

It's related with wrong arguments, could you please update documentation for Slack integration and e.t.c, because in docs i saw:
java
"-Dchat.id=#allure_notifications_channel"
"-Dbot.token=xoxb-1687076169986-..."
"-Dproject.name=${JOB_BASE_NAME}" \             <- jenkins environment var
"-Dbuild.launch.name=Some release 2.0"
"-Dbuild.env=https://prod.your.site"
"-Dbuild.report.link=${BUILD_URL}" \            <- jenkins environment var
"-Dlang=en"
"-Denable.chart=true"
"-Dallure.report.folder=./allure-report/"
-jar allure-notifications-2.2.1.jar
But Actual is:
"-Dapp.bot.token=xoxb-2940401251-2863611473591..."
"-Dapp.bot.chat=#qa-..."


'type' not found inside unmountComponent

Version
3.2.23
Reproduction link
https://github.com/
Steps to reproduce
I couldn't reproduce the error in a new repo, but I know what triggers it.
Error Message:
Uncaught (in promise) TypeError: Cannot read properties of null (reading 'type')
    at unmountComponent (runtime-core.esm-bundler.js:4781)
    at unmount (runtime-core.esm-bundler.js:4697)
    at Object.remove (runtime-core.esm-bundler.js:5166)
    at unmount (runtime-core.esm-bundler.js:4708)
    at unmountChildren (runtime-core.esm-bundler.js:4825)
    at unmount (runtime-core.esm-bundler.js:4715)
    at unmountComponent (runtime-core.esm-bundler.js:4796)
    at unmount (runtime-core.esm-bundler.js:4697)
    at unmountChildren (runtime-core.esm-bundler.js:4825)
    at unmount (runtime-core.esm-bundler.js:4715)

I traced back  to this line of code:
In development:
const unmountComponent = (instance, parentSuspense, doRemove) => {
                                                       // here VVVV
        if ((process.env.NODE_ENV !== 'production') && instance.type.__hmrId) {
            unregisterHMR(instance);
        }
        const { bum, scope, update, subTree, um } = instance;
        // beforeUnmount hook
        if (bum) {
            invokeArrayFns(bum);
        }
        // stop effects in component scope
        scope.stop();

In production:
TypeError: Cannot destructure property 'bum' of 'E' as it is null.

What is expected?
To find type in the instance
What is actually happening?
not finding type in the instance

This error triggers inside a parent component with slot.
When I remove the template tag that injects the slot, the error stops

Hello, make sure to always provide a reproduction that follows the instructions at https://new-issue.vuejs.org/?repo=vuejs/vue-next#why-repro.
Open a new issue with a reproduction that follows those instructions if you manage to create a boiled down reproduction.


TVIParticipantDelegate methods are not being called when call is initiated second time

Hi,
Scenario:

Alice calls Bob
Alice and Bob connect and start a video call
Alice disconnects call
Alice calls Bob
Alice cannot see Bob's video but can only hear, While Bob can hear and see Alice

Since I have implemented signalling for Alice & Bob to communicate each others state before handshake. I am having this issue where Alice cannot see Bob's video.
I found that TVIParticipantDelegate methods in Alice are not being called when Alice calls Bob second time (step 4) (preceding which Alice had disconnected call the first time).
@ptankTwilio, Could you please give me some pointers as how I could possibly fix the issue ? or what I should be looking for ?
The issue doesn't appear if Bob had disconnected the call previously.
Using TwilioVideo 1.0.0
iOS: 10.3.3
Device: iPhone 5
Thanks
Pravishanth

@pravishanth Are you able to reproduce the problem on QuickStart? On your app, I will make sure -

All objects associated with the first call is cleaned up properly.
For second call, make sure the TVIRoomDelegate is set properly and TVIRoomDelegate events are received on both sides.
For second call, make sure the TVIParticipantDelegate is set properly and TVIParticipantDelegate events are received on both sides.

Also, TwilioVideo's 2.0 preview release is available. You can try it out. Here are the changelogs- https://www.twilio.com/docs/api/video/changelog-twilio-video-ios-version-2x#200-preview7-november-9-2017
Let me know if you have any questions.

Hi @pravishanth,

Using TwilioVideo 1.0.0

If you're set on using our 1.x releases that's okay but please use 1.3.8. Otherwise Piyush linked to 2.0 above.
1.3.8 - https://www.twilio.com/docs/api/video/changelog-twilio-video-ios-version-1x#138-november-6-2017
Best,
Chris

Hey @pravishanth,

@ceaglest, I've updated to TwilioVideo to 1.3.8.
I was assuming I might have to change methods and rewire the app if I switch to TwilioVideo 2.0, would you recommend to update to 2.0 in production environment ?

Overall, our 2.0-preview releases are much more stable than our original 1.0-betas were and offer quite a few useful features. You can find a summary on our getting started page:
https://www.twilio.com/docs/api/video/ios#preview-releases
That being said we are still planning a few API changes before we hit 2.0.0-beta1.

Track subscription errors.
AVAudioSession management (TVIAudioController, and CallKit APIs).
Codec preferences tweaks.

It may take some small effort to keep up with the changes, so if you don't have time for that right now I would recommend staying on 1.x. Once we hit beta1 we would like to confine our API changes to be additive only.
Regards,
Chris


Info updated instantly, rather than when played (Serato)

Using Serato Pro 2.5.5 on Windows, both 2.x and 3.x change the track name as soon as it's loaded, when using the "newest" option; I could amend the delay, but the current track could be quite long, and I may know what I want to play next, so a delay will still show the incorrect track on screen for a while.
I use a 4 deck controller, and often keep scratch samples loaded into decks 3 and 4, so using the "oldest" option keeps showing the filename for this instead.
Version 1.4.0 only updates the track name when the song is actually playing. If I load two tracks and set them both playing at the same time, but the volume fader is down on deck 2, the track will not update until it's faded in and actually playing out.

Thank you for the bug report! Great use case!
I'll see what I can do to fix the issue.  I was debating adding the ability to actually mark decks as 'ignorable' so that they don't even participate in the calculation. (e.g, in your case, if you wanted to swap out your scratch samples, that would also disrupt things too). This bug might just make me do that since that might be the fastest way to fix it.  The fact that 1.4.0 works is sort of interesting, given I was seeing other issues with how that version was parsing the session file.
Just to give a bit of a warning, it might take me a bit to get real fix in place since I'm going to be out of town for most of the next month.

Ignored deck(s) would be useful, I pretty much use 3 and 4 for samples only.
The way 1.4 works would probably be my 'expected' behaviour for update timing, given it only updates once the track is actually playing out. Before now I've loaded in 4 or 5 tracks before settling on which one is actually going to play next. Though, ignored decks combined with the 'older' setting could be a workaround for now.
I rarely use the Live Playlists feature in Serato, but I've just tried it and it works in a similar manner, no updates until the volume (or crossfader) is moved onto the new track, not sure if that's any use for the local mode at all, just an interesting observation.
Absolutely no worries about timing, the changes thus far - both implemented and planned - are fantastic!

PS, haven't forgotten. Waiting for the arrival of a 4-deck controller that I bought off of eBay (but that is having issues. probably getting scammed).

No problem, hopefully it's not a scam, or at the very least eBay can sort things out swiftly.
If there's any logs/data/information I can provide in the meantime, let me know, and I'll see what I can do.

eBay refunded me. Sooo... in order to make some progress on this, I'm going to implement the ability to ignore decks 1-4.


Coding guidelines

Pull Request Test Coverage Report for Build 399456910

74 of 157 (47.13%)  changed or added relevant lines in 68 files are covered.
9 unchanged lines in 9 files lost coverage.
Overall coverage decreased (-0.06%) to 68.805%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

packages/Babylonian-Compiler.package/BPCompiler.class/instance/backgroundCompileInstrumentedVersionOf.basedOn..st
0
1
0.0%

packages/Babylonian-Compiler.package/BPSourceMapNode.class/instance/allParents.st
0
1
0.0%

packages/Babylonian-Compiler.package/BPSourceMapping.class/instance/createSourceMapFor..st
0
1
0.0%

packages/Babylonian-Compiler.package/BPSourceMapping.class/instance/defaultExpression..st
0
1
0.0%

packages/Babylonian-Core.package/BPActiveExamples.class/instance/update..st
0
1
0.0%

packages/Babylonian-Core.package/BPAnnotation.class/instance/canBeAnnotatedTo.st
0
1
0.0%

packages/Babylonian-Core.package/BPExampleAnnotation.class/instance/canBeAnnotatedTo.st
0
1
0.0%

packages/Babylonian-Core.package/BPExamplesAnnotation.class/instance/canBeAnnotatedTo.st
0
1
0.0%

packages/Babylonian-Core.package/BPMethodExample.class/instance/canBeUsedForDoIts.st
0
1
0.0%

packages/Babylonian-Core.package/BPSlider.class/instance/canBeAnnotatedTo.st
0
1
0.0%

Files with Coverage Reduction
New Missed Lines
%

packages/Babylonian-Core.package/BPActiveExamples.class/instance/update..st
1
0%

packages/Babylonian-Core.package/BPAnnotation.class/instance/canBeAnnotatedTo.st
1
0%

packages/Babylonian-Core.package/BPExampleAnnotation.class/instance/canBeAnnotatedTo.st
1
0%

packages/Babylonian-Core.package/BPExamplesAnnotation.class/instance/canBeAnnotatedTo.st
1
0%

packages/Babylonian-Core.package/BPMethodExample.class/instance/canBeUsedForDoIts.st
1
0%

packages/Babylonian-Core.package/BPSlider.class/instance/canBeAnnotatedTo.st
1
0%

packages/Babylonian-Tests.package/BPAnnotationMorphsTest.class/instance/methodWithBlockAndProbe.st
1
0%

packages/Babylonian-UI.package/BPBrowser.class/instance/aboutToStyle.requestor..st
1
0%

packages/Babylonian-UI.package/BPBrowser.class/instance/aboutToStyle..st
1
0%

Totals

Change from base Build 393913967:
-0.06%

Covered Lines:
3721

Relevant Lines:
5408

💛  - Coveralls

I like most of the changes :) Two things I do differently:

No dot only after a return statement. The last statement is terminated by a dot.
For single keyword messages, that get a block and are very wide, the body of the block starts on a new line.

@codeZeilen base updated to develop


Checkout page requires auth

What area is the issue related to?
Checkout Sheet Kit
What version of the package are you using?
3.0.4
Reproducible sample code
We are using this library to open shopify checkout page, buyer identity is attached to the cart. However checkout page is requiring authorization. How to open checkout page without auth?
Steps to Reproduce

Add product to cart
Open checkout url

Expected Behavior
The checkout page should not require auth. Because, buyer identity is attached to cart.
Actual Behavior
The checkout page is requiring auth
Screenshots/Videos/Log output
No response
Storefront domain
https://a9dc00-93.myshopify.com

Hey @nAkhmedov, how are you authenticating the user? Are you attaching a customerAccessToken in the buyerIdentity object of the CartInput?
https://shopify.dev/docs/api/storefront/2024-04/input-objects/CartBuyerIdentityInput

Unfortunately, attaching a customerAccessToken to the cart doesn't currently fully authenticate the customer. There's an ongoing project that is looking to change that, with a couple of security related limitations.
Until then, if you're a plus merchant, you could look into using multipass to fully authenticate customers, but it might be worth holding on for the above change.

Hey @nAkhmedov, how are you authenticating the user? Are you attaching a customerAccessToken in the buyerIdentity object of the CartInput?
https://shopify.dev/docs/api/storefront/2024-04/input-objects/CartBuyerIdentityInput

yes

Unfortunately, attaching a customerAccessToken to the cart doesn't currently fully authenticate the customer. There's an ongoing project that is looking to change that, with a couple of security related limitations.
Until then, if you're a plus merchant, you could look into using multipass to fully authenticate customers, but it might be worth holding on for the above change.

looking for the solution asap

Issue is not stale, work on the related project is continuing


Fix TestIncludesCompileCUDA for HEAD tests

/test full

/test full

Thanks! CUDA 11.2 seems also failing when compiling for Tegra CCs on non-Tegra.
I think it's better to do set(_get_cuda_archs()) - set(cupy.cuda.compiler._tegra_archs) for CUDA 10.2~11.2.

/test full

/test full

/test full

/test full

Thanks!!


[Install] Use helm to deploy Consul

Enhancement Description
The Consul deployment process uses Kubernetes manifests currently.
Related Challenges
Helm is a more robust way of deploying Consul and will offer easier ways to allow the user to configure their Consul deployment. Not all, but some other Meshery adapters benefit from use of helm deployments (shared code here may be useful).
Resources

https://learn.hashicorp.com/consul/kubernetes/kubernetes-deployment-guide

Suggest that this is done after #98

We already have the chart for meshery-consul, we can close the issue https://artifacthub.io/packages/helm/meshery/meshery

@Aisuko could you please elaborate? Consul is not deployed using Helm. I planned to work on that as soon as Helm functionality was available in meshery-adapter-library.

@Aisuko are you referring to a chart to deploy the meshery-consul adapter? This issue is about deploying Consul.

@mgfeller You are right. We should reopen the issue. But for my personal experiences, maybe better to choose a more native way,  for example, like Linkerd2 and OSM service-mesh application use helm.sh/v3 to generate the manifest inside the pkg package. But those function I said above were private, that means can not import by other projects.  Related https://github.com/linkerd/linkerd2/discussions/4467

@Aisuko I was referring to https://github.com/layer5io/meshkit/pull/23 regarding Helm support. Did you see that?

@mgfeller For my personal, I'd like to import the service-mesh applications source code pkg to render the multiple version manifest of the service-mesh application rather than download the chart, because we need stability, but we do not know if the upstream release new charts with some breaking change like istio v1.6 can not directly upgrade to v1.7(maybe v1.7 -> v1.8). I'd like to maintain the stable charts repo for all the service-mesh application(like the system-chart repo under rancher org) under layer5, but it was not achieved for some reasons. But, it's good to see we have this feature.

@Aisuko not quite sure I understand completely, but I agree we need stability. Also, different meshes package and deploy differently, meaning that it is difficult to generalize. Breaking changes and backward compatibility are also handled differently wrt versioning, as you mention, so we have to consider that for each mesh individually.
The Consul Helm charts do not follow the Consul versioning, and there is not a distinct Helm chart version for each minor Consul release. Different values-files for specific Helm chart versions and distinct configurations is what I had in mind here. Not all configurations can be applied using Helm upgrade, some require a fresh install.
You raise a point I wondered about: does Meshery intend to provide upgrades and upgradeable configurations? How do we check the prerequisites for configuration changes?
Should we always just provide the latest version or all supported versions, or what? It will not work for all meshes to just download binaries or Helm charts (with default values) from the vendor.
A plan, requirements, intentions or similar in the design doc would be nice - don't remember having seen that...

We would like to handle at least 3 stable versions of the service-mesh applications and the latest version of edge, it's our original plan but it not came true(We can maintain the repo like https://github.com/rancher/system -charts/tree/dev-v2.5/charts/rancher-istio). If I remember right I wrote the documentation but not sure where it saved on. @leecalcote Any detail or need to correct please comment us.
@mgfeller You let me think the things, Should we provide upgrades and upgradeable for the service-mesh applications?

@mgfeller You let me think the things, Should we provide upgrades and upgradeable for the service-mesh applications?

@Aisuko not sure, let's ponder this for a bit. It also means a commitment to maintain that in the future, meaning that we think we have time and contributors to support that.

We would like to handle at least 3 stable versions of the service-mesh applications and the latest version of edge, it's our original plan but it not came true(We can maintain the repo like https://github.com/rancher/system -charts/tree/dev-v2.5/charts/rancher-istio). If I remember right I wrote the documentation but not sure where it saved on. @leecalcote Any detail or need to correct please comment us.

This would be quite a commitment.

Using this issue to implement installation of Consul 1.9.1 using Helm, changing title of this issue to reflect that.

@kumarabd @utkarsh-pro
Using the Helm new functionality in meshkit, I apply the Helm chart with custom values file to deploy Consul 1.9.1. Works fine when I run the adapter in-process.
However, when I run it using mesheryctl, i.e. as container, it fails with:
meshery-consul_1  | {"app":"consul-adapter","caller":"level.go:63","code":"1008","level":"error","long-description":"Error applying operation.Error applying helm chart: Error applying helm chart: Kubernetes cluster unreachable: Get \"https://<IP_ADDRESS>:8443/version?timeout=32s\": x509: certificate signed by unknown authority","probable-cause":"None","severity":1,"short-description":"None","suggested-remediation":"None","ts":"2020-12-29T20:54:32.270253693+01:00"}

Deploying a manifest works just fine.
Would be nice if you could shed some light on this, I'm at a loss (after some hours trying to understand and fix this...).

@kumarabd @utkarsh-pro
Using the Helm new functionality in meshkit, I apply the Helm chart with custom values file to deploy Consul 1.9.1. Works fine when I run the adapter in-process.
However, when I run it using mesheryctl, i.e. as container, it fails with:
meshery-consul_1  | {"app":"consul-adapter","caller":"level.go:63","code":"1008","level":"error","long-description":"Error applying operation.Error applying helm chart: Error applying helm chart: Kubernetes cluster unreachable: Get \"https://<IP_ADDRESS>:8443/version?timeout=32s\": x509: certificate signed by unknown authority","probable-cause":"None","severity":1,"short-description":"None","suggested-remediation":"None","ts":"2020-12-29T20:54:32.270253693+01:00"}

Deploying a manifest works just fine.
Would be nice if you could shed some light on this, I'm at a loss (after some hours trying to understand and fix this...).

Hi @mgfeller, the fix would be adding the following in the main.go
err = os.Setenv("KUBECONFIG", path.Join(
		config.KubeConfigDefaults[configprovider.FilePath],
		fmt.Sprintf("%s.%s", config.KubeConfigDefaults[configprovider.FileName], config.KubeConfigDefaults[configprovider.FileType])),
)

We set the env variable here so that it can be dynamic and doesn't have to be hardcoded in the Dockerfile. Fewer things to maintain 🙂.
The reason for the issue: Helm library internally expects this env variable to be available so that it can use kube config internally to communicate with the kubernetes server. In the consul adapter this variable was not set.
This issue didn't show up in other adapters because we set this env variable in adapters like istio (because istioctl expects it), osm (because osmctl expects it, probably because they also internally use helm libraries) and traefik (because traefik uses exact same function).
I hope this fixes the issue. I tried running it on my system after adding the variable and it worked fine. My configuration:
 ///////////////////////////////
Kubernetes Cluster: KinD
///////////////////////////////
NAME="Manjaro Linux"
ID=manjaro
ID_LIKE=arch
BUILD_ID=rolling
PRETTY_NAME="Manjaro Linux"
ANSI_COLOR="32;1;24;144;200"
HOME_URL="https://manjaro.org/"
DOCUMENTATION_URL="https://wiki.manjaro.org/"
SUPPORT_URL="https://manjaro.org/"
BUG_REPORT_URL="https://bugs.manjaro.org/"
LOGO=manjarolinux

On another thought, I think we should either document that applyHelmChart needs kubeconfig env variable to be set or we should make it explicit by making kubeconfig path as a parameter to this function. Any suggestions @mgfeller @kumarabd?

@utkarsh-pro possible to set this by default in the library?

Hi @mgfeller, the fix would be adding the following in the main.go

Hi @utkarsh-pro, thanks for the fine and detailed feedback. It sounds familiar, I think I read about this when I looked into using Helm the first time a couple of months ago. Obviously and unfortunately, I didn't remember that. What confused me (subconsciously :wink: ) is probably that it looks like Helm picked up some information, and all of kubeconfig looks to be passed to Helm...

@utkarsh-pro @kumarabd I think it should be documented :+1: regardless of how it is implemented. One sentence or two would be enough (and could have saved a few hours' work). This particular env var is used / required by many tools, so I'm not quite sure making the path an explicit parameter and then defining the env var in the function is the optimal solution.
Setting it in the library might be confusing, as kubeconfig can be set by any adapter (KubeconfigHandler), then what?
What about an init/preflight-check function that would verify that the env var is declared, and other things? Like checking for required directories, and possibly create them if they do not exist. This would make the prerequisites explicit.

Another point to consider is what to do if the environment variable already exists. What I did now was to append the new path if the variable already exists, otherwise, test will fail.


Some links not working as expected

CADCloud installation: JM's demonstrator
Browser used: Firefox 81.0 on Kubuntu 20.04; domain whitelisted on adblock
Problem
Some links on Home are not working for me:

The cursor may or may not change when hovering over (different issue), but nothing happens on click. Other functions to click are not visible to me.

thanks for the report. I was aware about a few of these issues that need to be addressed !


rediscrashcourse container doesn't start

Hi, I'm on m1 mac and using docker-compose v2.18.1.
my problem is that the container just doesn't start. It spends entire minutes in the starting process without progress.
I am also reading that

The final Compose v1 release (v1.29.2) was May 10, 2021
from here

What is the problem ? Am I using the wrong compose version? I just took care I was using docker-compose and not "docker compose" as mentioned in the readme
thanks for the help.

I just needed to free ports 6379 on my machine. It's all good now


Collection Edit: Support Name Update

Add functionality to the collection edit modal allowing users to update the collection name. Ensure that the updated name is reflected on-chain.

I'm not working on any of those issues, so no overlap from my side. I will assign the issue to myself if I do so.
I only closed the ones I was sure are completed, others are just linked


Re-enable django API requests

For book keeping, rolls back some of the changes in #505

@dchiquit  and @AlmightyYakob - this PR resulted in issue #509. i'd like to revert this or fix this.