Proposal: Modern WinUI version of the TaskDialog

Proposal: Modern WinUI version of the TaskDialog

Following WinForms adding support for the Win32 Task Dialog, a twitter thread was started by @sonnemaf and contributions from myself and @niels9001 discussing a need for this kind of UI in WPF and for modern WinUI apps.
It could bring a consistent design to numerous shell and inbox app UX which at present, can appear inconsistent and at times, messy.
Summary

A task dialog is a dialog box that can be used to display information and receive simple input from the user. Like a message box, it is formatted by the operating system according to parameters you set. However, a task dialog has many more features than a message box.

Win32 Documentation
A modal dialog that presents Xaml controls, supports paging through steps, is similar to a wizard UI #2030 , has the ability to capture user input, and has various strings formatted in a consistent way.
I hope this Issue can be edited later to encompass more detail from the community, I am just making the initial proposal.
Rationale

WinUI and Windows 10/10X does not have a consistent way of presenting this kind of UI at present.
Presently various parts of Windows 10 present this kind of UI, but it is inconsistent,
This kind of control could answer a few wants from the community.

Scope

Capability
Priority

Present a consistent UI with minor customisation
Must

Ensure controls hosted in the dialog
Must

Shell and Inbox app teams should adopt this control to demonstrate best practice
Must

It should be possible to create the UI without manually styling controls, placing controls, or adjusting margins and padding
Should

It could be possible to add custom Xaml, but a focus should be on the typical controls supported by the TaskDialog UI
Could

Important Notes
Below are some examples of common Windows UI that could be made more consistent by using this new control.

Winforms - Windows Task Dialog
Open Questions
Please make your voices heard about what you would need from this control, how you would see it being used, and why you would like to include it into your applications and user experiences.
Anything that was learned when the WinForms team built their wrapper around the Win32 version of this control, could be helpful, especially any aspects of the control that could be important but easily overlooked.
The design of the control should reflect WinUI and Fluent Design principles, and not slavishly match the Windows Vista/7 design.  So how some of the elements get translated would be a design conversation, with approval from the Windows Design team.

There is also a discussion on Twitter from @NullRefExc and @michael-hawker whether the TaskDialog would be a ContentDialog (or subclass).
I think this is a big issues. If it is a ContentDialog the size can not really exceed 500x500 pixels. This is the size I usually set for an UWP app. A ContentDialog is always displayed inside the app and will therefor have the same size limitation. We then should use scrollbars to allow bigger content.
If it is a (modal) Window we can have "any" size. The TaskDialog would allow a content which is bigger than the app.
I still like the idea of a ContentDialog solution. It would allow to have any content in it. It is also risky because it will probably inconsistent implementations. Maybe it should be a combo.

There is also a discussion on Twitter from @NullRefExc and @michael-hawker whether the TaskDialog would be a ContentDialog (or subclass).
I think this is a big issues. If it is a ContentDialog the size can not really exceed 500x500 pixels. This is the size I usually set for an UWP app. A ContentDialog is always displayed inside the app and will therefor have the same size limitation. We then should use scrollbars to allow bigger content.
If it is a (modal) Window we can have "any" size. The TaskDialog would allow a content which is bigger than the app.
I still like the idea of a ContentDialog solution. It would allow to have any content in it. It is also risky because it will probably inconsistent implementations. Maybe it should be a combo.

I think it would need to generate an app window/sub window, rather than be an overlay - to be useful for both UWP and WinUI Desktop

I agree with @mdtauk

I agree with @mdtauk. Not being able to set the Size of a Window is an issue. Maybe this should be placed in a separate issue.

I believe this is what the future Windowing APIs are planning to deal with.  WinUI Desktop's Window object will support setting a size.

I believe this is what the future Windowing APIs are planning to deal with. WinUI Desktop's Window object will support setting a size.

Will there be a UWP and a different Desktop version of WinUI? I hope not.

I believe this is what the future Windowing APIs are planning to deal with. WinUI Desktop's Window object will support setting a size.

Will there be a UWP and a different Desktop version of WinUI? I hope not.

WinUI is used for both, but some APIs and elements will behave differently.  WinUI will have a Window element, but in UWP this is wrapping around the CoreWindow, but with WinUI Desktop, it wraps around a HWND window.
Threading behaves differently with each, and so this causes some issues with parity between both lifecycles of WinUI

I think these should show in full screen when in a Tablet UI environment.

I think these should show in full screen when in a Tablet UI environment.

What is your reasoning for this?  I think centred on the tablet screen makes sense, but not sure why the window should be larger than it needs to be.

The UI would not stretch well;
Body text blocks would have longer lines than is ideal for readability;
You lose the visual indication that this is a modal UI;

This TaskDialog would need to be either followed through with, or dismissed, before you go back to the app which summoned it.

ContentDialog is for showing information or content of the developer's choosing.
MessageBox is for displaying a text message.
TaskDialog would be for completing a task more complicated than tapping a ToggleSwitch, Button, CheckBox etc, or requires multiple steps or inputs from the user.

@mdtauk Thanks for the write-up. Excellent examples. I would really welcome a more standardized and easy to use dialog control for OOBE/connection related tasks!

What is your reasoning for this? I think centred on the tablet screen makes sense, but not sure why the window should be larger than it needs to be.

Bad experience with open & dialogue boxes. The ones in Tablet Mode where great in Windows 8.1 for usability and then in Windows 10, they took away them away. Because of that, any type of dialog like above bother me. They are never designed to scale for tablets. I have all of this screen real estate and the boxes are 500x500.
Why?

@shaheedmalik that sounds like a DPI issue?
Though that's the point of having a consistent control/paradigm in place here for modern applications. Then if there is something that can be addressed when in Tablet mode, then all the apps using this new Dialog can behave the same way and receive the same fixes/benefits of developing a solution for your issue on top of this control/platform.

What is your reasoning for this? I think centred on the tablet screen makes sense, but not sure why the window should be larger than it needs to be.

Bad experience with open & dialogue boxes. The ones in Tablet Mode where great in Windows 8.1 for usability and then in Windows 10, they took away them away. Because of that, any type of dialog like above bother me. They are never designed to scale for tablets. I have all of this screen real estate and the boxes are 500x500.
Why?

Task Dialogs appear to stack the controls vertically, so the width encompasses the controls required, but the height adjusts to contain what is in them.
On Tablets, there will probably need to be support for vertical scrolling if the developer has put too much in a single screen - and has chosen not to paginate the task into steps.
So if the width is say as wide as a textbox with icon beside it, like in the examples I posted, that would look a little silly centred in the full screen window.  If you want to do things like columns, then that would make more sense as a Form Control, as proposed here #82, and could be placed in a ContentDialog or custom control ( with or without pagination #60 )

So if the width is say as wide as a textbox with icon beside it, like in the examples I posted, that would look a little silly centred in the full screen window. If you want to do things like columns, then that would make more sense as a Form Control, as proposed here #82, and could be placed in a ContentDialog or custom control ( with or without pagination #60 )

I'm asking for it to scale to the device it is on. What you are suggesting is what happened to the open file dialog going from Windows 8 -> Windows 10. On Windows 8 they scaled to the device, on Windows 10 they no longer did that.

@shaheedmalik  by default, this task dialog would be in Xaml, so would support the same touch target sizing, and DPI scaling as other Xaml controls.
If you mean scaling as in making CheckBoxes, Buttons and TextBoxes larger than usual, and using massive Font sizes - why should these UI elements be scaled differently to others?
This would not be like a win32 UI, which refuses to be moved about the screen, or feels out of place in a modern UI and touch screen device

Windows Hello also uses a TaskDialog interface.

Windows Hello also uses a TaskDialog interface.

The difference for this is, it takes over the whole screen.

@shaheedmalik by default, this task dialog would be in Xaml, so would support the same touch target sizing, and DPI scaling as other Xaml controls.
If you mean scaling as in making CheckBoxes, Buttons and TextBoxes larger than usual, and using massive Font sizes - why should these UI elements be scaled differently to others?
This would not be like a win32 UI, which refuses to be moved about the screen, or feels out of place in a modern UI and touch screen device

I'm talking about avoiding stuff like this:

This type of thing is annoying as hell to me. If I for watch ever reason miss pressing it, it will take me to the Start Screen.

We could catch that by drawing a backdrop, similiar to the default content dialog? Having a dialog full screen looks pretty bad, this would resolve both issues 👍.

My 2¢ on this issue: The main reason I still use the Vista-era TaskDialog is because it conforms to Vista-era design principles; namely, minimizing wasted white space. Just because WinUI 3 is designed as a "touch-first" toolkit, it doesn't mean that supporting touch as a first-class design feature is a good idea for every project. The example in the OP, while fine from a touchscreen perspective, has stupid large text and lots of pointless white space when viewed from the perspective of a user (or developer) used to Windows 7-style apps intended to be used with keyboard and mouse. The bulk of the apps I write fall into this category.
What I would recommend doing for this issue is ensuring there is a way (even if it involves re-templating the control, I'm not afraid of having to do that) to make the WinUI task dialog laid out roughly like the Win32 equivalent, using 9-point Segoe UI text and margins of only a few pixels at 100% DPI. Other than that, all the rest of the UI (fonts, background colors, Dark Mode support, button chrome, etc.) would look exactly like it does in the OP's mockup.
Also, the idea about making a touch-opaque backdrop when showing a small window in Tablet Mode is something the OS should do automatically for every app IMHO. Being catapulted out of the app and back to the Start screen on a missed tap would become extremely aggravating the 642nd time it happens. Hope this helps!

My 2¢ on this issue: The main reason I still use the Vista-era TaskDialog is because it conforms to Vista-era design principles; namely, minimizing wasted white space. Just because WinUI 3 is designed as a "touch-first" toolkit, it doesn't mean that supporting touch as a first-class design feature is a good idea for every project. The example in the OP, while fine from a touchscreen perspective, has stupid large text and lots of pointless white space when viewed from the perspective of a user (or developer) used to Windows 7-style apps intended to be used with keyboard and mouse. The bulk of the apps I write fall into this category.
What I would recommend doing for this issue is ensuring there is a way (even if it involves re-templating the control, I'm not afraid of having to do that) to make the WinUI task dialog laid out roughly like the Win32 equivalent, using 9-point Segoe UI text and margins of only a few pixels at 100% DPI. Other than that, all the rest of the UI (fonts, background colors, Dark Mode support, button chrome, etc.) would look exactly like it does in the OP's mockup.
Also, the idea about making a touch-opaque backdrop when showing a small window in Tablet Mode is something the OS should do automatically for every app IMHO. Being catapulted out of the app and back to the Start screen on a missed tap would become extremely aggravating the 642nd time it happens. Hope this helps!

Winforms has added a wrapper for the Windows 7/8/10 style control - so this doesn't totally replace it.
This proposal is about providing a similar UI for Windows 10 native looking apps, which can be called from WinUI apps, without looking vastly different from the new modern design.
If you do not want to support touch screens, and do not want to make your app look like a modern Windows 10 app - why would you be using WinUI at all?

@mdtauk: Because I want the app to look like a modern Windows 10 app. That does not necessarily imply first-class touchscreen support as far as I am concerned. I'm sorry if I didn't make this more clear.

We could catch that by drawing a backdrop, similiar to the default content dialog? Having a dialog full screen looks pretty bad, this would resolve both issues 👍.

There was discussion about this kind of thing in another issue #2122 and how you may introduce a visual style to suit modal dialogs and content dialogs.  Any "smoke" layer should be consistent with other modal UIs, but whether this is on the whole screen, or just for the window that summoned the TaskDialog - is possibly a discussion to be had.

@mdtauk: Because I want the app to look like a modern Windows 10 app. That does not necessarily imply first-class touchscreen support as far as I am concerned. I'm sorry if I didn't make this more clear.

Text Size for Windows 10 UI is 14pt for most body text with 12 for captions.  It is for modern accessibility, the WinUI anti-aliasing, that this is as it is.
Touch targets for buttons are a minimum of 32 px for touch targets, so to deviate from these standards, would make the UI not fit the new Shell design that Microsoft are moving towards.
I would suggest that if you wish to make Legacy looking TaskDialogs, doing them as WinForms would probably be the better idea moving forwards.

I don't understand why people say a big control is wasting space. It's a dialog box. You can't do anything past it. It if is small like the Win32 example I posted, you can't do anything with that "saved" space.
I'm posting this message on my phone and I can't read what it even says from here.

There's also the notion of the Compact Styling option, so that should be the option available for this (like any other WinUI control) for targeting desktop only scenarios compared to touch-friendly defaults.


MTSRE-347 | Add: validator for validating addon metadata's icon to be base64 encoded

Signed-off-by: Yashvardhan Kukreja<EMAIL_ADDRESS>

please merge #38 before merging this PR

@yashvardhan-kukreja please rebase

Can we add a wiki page please: https://github.com/mt-sre/addon-metadata-operator/wiki/AM0004

Done @sugarraysam

Create a new pr template for future validators -> .github/pull_request_template.md

Sure, I'll proceed with creating a separate PR for that.

awesome, one last thing, please make sure to test this against prod addons in managed-tenants. https://gitlab.cee.redhat.com/service/managed-tenants-sops/-/blob/main/MT-SRE/sops/AMO-validators.md

Sure thing!

awesome, one last thing, please make sure to test this against prod addons in managed-tenants. https://gitlab.cee.redhat.com/service/managed-tenants-sops/-/blob/main/MT-SRE/sops/AMO-validators.md

Just checked. This validator works well with all of our addons belonging to integration, stage and prod envs.

Sure, I'll proceed with creating a separate PR for that.

That was a type. I wanted to tell you that I have created the template .github/pull_request_template.md

so, @sugarraysam are we good with this PR or is there anything else which can be done here? :)


Buggy 2.0.7

Dear Developers,
There seems to be a problem with the newer versions of AltAnalyze in my case.
I'm sure if it's working for other people then it's something in that can be
solved. But here's a short description:
I have a table of Illumina expression values that I can feed successfully into
version 2.0.3 for example and get an ExpressionOutput folder with my results.
It doesn't provide me with any annotation data though, but that is secondary.
When I use the same file in 2.0.6 or 2.0.7 it gives me an error that looks like
this, regardless of the data I pass on to it:

"Beginning to Process the Mm 3'array dataset
Adding additional gene, GO and WikiPathways annotations
* * * * * * * * * * * * * * * * * * * ArrayID annotations imported in 15 seconds
45599 Array IDs with annotations from Illumina annotation files imported.
Processing the expression file:
R:/Data/Transcriptomics/Illumina/TiKC_den+PC_GA+TA/20120803_ExpressionValues_Raw
_DM.txt
25697 IDs imported...beginning to calculate statistics for all group comparisons
Traceback (most recent call last):
  File "AltAnalyze.pyc", line 4916, in AltAnalyzeSetup
  File "AltAnalyze.pyc", line 4374, in __init__
  File "AltAnalyze.pyc", line 5207, in AltAnalyzeMain
  File "ExpressionBuilder.pyc", line 1360, in remoteExpressionBuilder
  File "ExpressionBuilder.pyc", line 145, in calculate_expression_measures
  File "reorder_arrays.pyc", line 124, in reorder
  File "statistics.pyc", line 492, in log_fold_conversion
OverflowError: math range error

...exiting AltAnalyze due to unexpected error"

Since the issue doesn't change with the type of data set I'm feeding into it,
I'm finding it hard to figure out what the problem is. I also checked the files
for NAs or non-numeric entries, but there are none.
Any idea what the problem might be?

Thanks a bunch!

PS: I'm operating on a 64-bit windows 7 system.

Original issue reported on code.google.com by<EMAIL_ADDRESS>on 14 Aug 2012 at 8:59
Attachments:

AltAnalyze_report-20120814-092153.log

Should be resolved in later versions.


⚠ TorrentLeech has degraded performance

In 5e7b6af, TorrentLeech ($TL) experienced degraded performance:

HTTP code: 200
Response time: 1514 ms

Resolved: TorrentLeech performance has improved in 9415bf6 after 6 minutes.


revert mavlink and logger stack increases

These were increased due to erroneous stack usage reporting in the NuttX upgrade. https://github.com/PX4/Firmware/issues/15839

Stack usage looking sane again after https://github.com/PX4/Firmware/pull/15948.


[Discuss]Should we support iOS?

Feature Request
Should we support iOS?
Why it is needed
The checkbox is a quite basic component that is commonly used in Application.
React-Native could be more universal by supporting iOS and Android both
Problem
As we know, there is no native implementation of Checkbox in iOS, how would it be like in iOS?
(However, there is a style Guideline about checkboxes in MacOS)
https://developer.apple.com/design/human-interface-guidelines/macos/buttons/checkboxes/
UPDATE
Thanks for your discussion, We decide to implement the IOS version from now:
https://github.com/react-native-community/react-native-checkbox/pull/46
I think it is a good idea to reference the awesome implementation of IOS checkbox:
https://github.com/Boris-Em/BEMCheckBox

The CheckBox is a common component. I think there should be support for iOS.

I agree with @mostasim

It should be for both android and iOS.

I am currently using some icons with a custom toggle state because switch doesn't make sense for some places.
For eg I have a list of days I want people to choose, and for space reason, I placed this days in a single line. Using switches will make this horrible. Checkbox on the other hand are ok.
I am working on a calendar companion & the first thing that came to my mind was this part of iOS calendar app where you can select the calendar you want to see

Another official place (Settings > Screen Time > now try to add a limit)

Also supporting the web should be easy as there is a thing already :D

Actually, The Switch component doesn't make sense for some places
And just like @MoOx mentioned, we could use the official place as a reference
We will implement it as soon as possible

This maybe a good reference of checkbox made with iOS (with animation!)
https://github.com/Boris-Em/BEMCheckBox

I would like to help, how can I do this?

It should support iOS

It should support iOS

Yes, some fields need a checkbox even on ios.

I don't want to argue with designer about using the switch instead of the checkbox 😄

https://github.com/react-native-community/react-native-checkbox/pull/46
IOS version is on the way

Great! Waiting for it.

Any update about the launch date of a version with iOS support? Thank you!

Would love to know too!-- Основатель ДвижРома Маяк+7 (977) 337-47-33https://vk.com/roma_mayak Движ - "Цени время жизни: люди и развитие"12.05.2020, 6:55 PM, "Javier Laguna"<EMAIL_ADDRESS>Any update about the launch date of a version with iOS support? Thank you!
—You are receiving this because you commented.Reply to this email directly, view it on GitHub, or unsubscribe.

Hi, guys
Thanks for your waiting. I am pleased to announce the version 0.4.0 was just released! We are support IOS now. Please try it! 🎉🎉🎉🎉🎉
If there is any trouble with usage. Please feel free to let us know, and we would like to help with that as soon as possible

I have the following error
_Metro Bundler has encountered an error: While trying to resolve module @react-native-community/checkbox, the package<EMAIL_ADDRESS>was successfully found. However, this package itself specifies a main module field that could not be resolved (/XXXXXXXX/node_modules/@react-native-community/checkbox/dist/CheckBox. Indeed, none of these files exist:

/XXXXXXXX/node_modules/@react-native-community/checkbox/dist/CheckBox(.native|.ios.js|.native.js|.js|.ios.json|.native.json|.json|.ios.ts|.native.ts|.ts|.ios.tsx|.native.tsx|.tsx)
/XXXXXXXX/node_modules/@react-native-community/checkbox/dist/CheckBox/index(.native|.ios.js|.native.js|.js|.ios.json|.native.json|.json|.ios.ts|.native.ts|.ts|.ios.tsx|.native.tsx|.tsx)_

@JavierLaguna
Have you ever try to use npx pod-install to install dependency

Thank you, now I have this error
/XXXXXX/node_modules/@react-native-community/checkbox/ios/RNCCheckboxManager.m:7:9: fatal error: 'BEMCheckBox.h' file not found
#import "BEMCheckBox.h"

Add pod 'BEMCheckBox' in your /ios/Podfile file
anyone who suffering "'BEMCheckBox.h' file not found" error on build.
It seems to be not installed correctly even though run pod install

It works but BEMCheckBox  dependency should be on RNCCheckbox.podspec, right ?

I think so too. but iOS support has started just 8 hours ago.

Sorry for the trouble, I was just release 0.4.1 to fix this

Dont worry! Thank you so much! Any way for change the square dimension of check in iOS ?

It is great to see it working on iOS as well. As many changes are being implemented, I would agree with @JavierLaguna to add a prop to change the dimension of whole checkbox.

It is nice to see a checkbox working on iOS as well, but it is a bit sad it is not a native one, the one Apple uses in their apps. 🙃

@JavierLaguna @vonovak
You could change the size of the checkbox square with the style props just like other normal React components. (If the 'square dimension' means the size of the checkbox)
<CheckBox style={.....}>

It is nice to see a checkbox working on iOS as well, but it is a bit sad it is not a native one, the one Apple uses in their apps. 🙃

We also would like to use the native component of iOS if it exists. Please let us know when Apple offers it to public

You could change the size of the checkbox square with the style props just like other normal React components. (If the 'square dimension' means the size of the checkbox)
<CheckBox style={{ width: 100, height: 100}}>

I'd like to mention that if you're using live reload, the component that has the checkbox needs to be re-mounted (eg. open the screen again).

Thank you! worked for me!!

Looks awesome!

I have this error:
Invariant Violation: requireNativeComponent: "RNCCheckbox" was not found in the UIManager

I add pod 'BEMCheckBox' in my /ios/Podfile file and run pod install, I run also npx pod-install

Is it possible to use in an Expo app which is built with the managed work-flow?

Hi on IOS. I have checkboxes displayed on an array map.
The first action on the checkbox triggers. But after that it dosen't unless i click on a different checkbox on the same map. Any idea?
video attached. https://youtu.be/I4oEa95ehWI
Code is quite simple
  {tagsToShow.map((tag,index) =>
                                    <View
                                     style={{
                                       width: "90%",
                                       flexDirection: "row",
                                       paddingVertical: 14
                                     }}
                                   >

                                    <Text
                                     style={{
                                       width: "50%",
                                       flexDirection: "row",
                                       fontSize: wp('4%'),
                                       marginLeft:wp('5%'),
                                       color:  "#1CAD9E",
                                       fontFamily: 'Gilroy-Regular',
                                       //padding: 14
                                     }}
                                   >
                                      {tag}
                                      </Text>

                                      <View
                                     style={{ flex: 1, alignItems: "center" }}
                                   >
                                       <CheckBox
                                         disabled={false}
                                         value={true}
                                         onValueChange={() => setSelectedTag(tag)}
                                       />
                                      </View>

                                    </View>

                                  )}

I am having issue with this on IOS. Specifically on projects with expo. Is it support on expo with IOS?

I just tried to add this checkbox today and for iOS in Expo, and I also get: Invariant Violation: requireNativeComponent: "RNCCheckbox" was not found in the UIManager. This error is located at:
in RNCCheckbox (created by CheckBox)

@LawrenceNorman  @vitolipari
Have tried to update the react-native-checkbox to the newest version? and Could you please give me more detailed info about your App? For example, the version of your RN and Checkbox

@ivgraai @sam17896
Never tested in Expo, But we would try to test and let it works on Expo in the future

@nicholaslee119 that would be great, for now i am forced to use checkbox from UI library like Native base or something.

@LawrenceNorman Try restarting Metro Bundler. This resolved that issue for me.

I have the same issue as @LawrenceNorman using Expo ("expo": "~37.0.9") and iOS. It returns Invariant Violation: requireNativeComponent: "RNCCheckbox" was not found in the UIManager.. Currently, no issues on Android.

I'm also having the same issue, 'Invariant Violation: requireNativeComponent: "RNCCheckbox" was not found in the UIManager', with expo 37.0.9 on IOS. No problem on Android.

I have the same problem, but I have solved through only run pod install.

The pod install solution is not really an option if I'm building using expo and the expo client. Does anyone have a solution that doesn't include ejecting from expo and installing cocoa pods?

The pod install solution is not really an option if I'm building using expo and the expo client. Does anyone have a solution that doesn't include ejecting from expo and installing cocoa pods?

I guess it is currently not supported!

same issue, using expo
Invariant Violation: requireNativeComponent: "RNCCheckbox" was not found in the UIManager.

Same issue of Invariant Violation: requireNativeComponent: "RNCCheckbox" was not found in the UIManager. I did pod install and cleared everything. I am using emulator to test.

same issue, using expo
Invariant Violation: requireNativeComponent: "RNCCheckbox" was not found in the UIManager.

did you solve it? I'm having the same problem :/

    "expo": "~38.0.8",
    "react-native": "~0.62.2",
    "@react-native-community/checkbox": "^0.5.3",

I am not sure if this information could be of any help. I have encountered the same issue on iOS just like all the other React Native devs using expo framework.

To stop the error "Invariant Violation: requireNativeComponent: "RNCCheckbox" was not found in the UIManager", you need to close down the simulator and Terminal runner, and run npx pod install to install the package correctly. This shouldn't happen because of auto linking I think, but doing this has worked for me.

Is there a solution using yarn? My team is using yarn and I've run into issues in the past when mixing package managers.

It works fine without Expo react-native run-ios. Once it is run with Expo "Invariant Violation: requireNativeComponent: "RNCCheckbox"
did all posible variations of pod install, reinstalls, etc. It just doesn't work.

@alzuma  I have an issue is like you, but when i close all server terminal window and run react-native run-ios again, it's work fine! For newest version.

@NguyenPhatBG I gave up and create a custom component with TouchableHighlight and state, if checked show icon ios-checkmark otherwise empty View 30x30 with border.
imho too much hustle over a simple component.

We are also having issues with using this checkbox component on an expo project. "requirenativecomponent: rnccheckbox was not found in the uimanager" Please fix this since react native recommends using this component now.

It works fine without Expo react-native run-ios. Once it is run with Expo "Invariant Violation: requireNativeComponent: "RNCCheckbox"
did all possible variations of pod install, reinstalls, etc. It just doesn't work.

Same issue here. I will create my own component too, since this is not working :/

I am having the same error. But when I run pod-install  I get the error:

[!] CocoaPods could not find compatible versions for pod "RNCCheckbox":
In Podfile:
RNCCheckbox (from ../node_modules/@react-native-community/checkbox)

I am having the same error. But when I run pod-install  I get the error:

[!] CocoaPods could not find compatible versions for pod "RNCCheckbox":
In Podfile:
RNCCheckbox (from ../node_modules/@react-native-community/checkbox)

Having the same RNC Checkbox issue as the past several commenters

Having the same RNC Checkbox issue as the past several commenters

in ios/Podfile
pod 'RNCCheckbox', :path =><EMAIL_ADDRESS>and then
cd ios && pod install

in ios/Podfile
pod 'RNCCheckbox', :path =><EMAIL_ADDRESS>and then
cd ios && pod install

in the newer version react natively, if I put this it gives duplication of call since now they created a bundle with all the standard items to make it easier not to obstruct the PodFile

Has there been a fix to the RNCCheckbox issue? Still persists(with Expo).

Issue: requireNativeComponent: "RNCCheckbox" was not found in the UIManager.
Solution: rebuild your current app whether it is android or ios.
if IOS then also
cd ios && pod install

Hi guys,
My Rn version : 0.68.5
Chip :M1 Apple Silicon
Trying to use checkbox for android and ios. it works on android perfect but on ios when i use pod install and try to build it gives this error:
4 duplicate symbols for architecture x86_64
I think it makes manuel linking without i do it. or something i am missing. Can you guys help me thanks.


looks like there is tokenizer bug?

probably we need to figure out before release new version.

oops. wrong number of quote issue :)


Can I use this template without Docker

Can I use this template without Docker?
many thanks

just remove docker-compose in the solution


HBASE-22939 SpaceQuotas- Bulkload from different hdfs failed when space quotas are turned on.

Bulkload from different hdfs failed when space quotas are turned on.

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Comment

0
reexec
92
Docker mode activated.

_ Prechecks _

+1
dupname
0
No case conflicting files found.

+1
hbaseanti
0
Patch does not have any anti-patterns.

+1
@author
0
The patch does not contain any @author tags.

-0
test4tests
0
The patch doesn't appear to include any new or modified tests.  Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.

_ master Compile Tests _

+1
mvninstall
446
master passed

+1
compile
69
master passed

+1
checkstyle
98
master passed

+1
shadedjars
348
branch has no errors when building our shaded downstream artifacts.

+1
javadoc
38
master passed

0
spotbugs
241
Used deprecated FindBugs config; considering switching to SpotBugs.

+1
findbugs
239
master passed

_ Patch Compile Tests _

+1
mvninstall
363
the patch passed

+1
compile
71
the patch passed

+1
javac
71
the patch passed

+1
checkstyle
93
the patch passed

+1
whitespace
0
The patch has no whitespace issues.

+1
shadedjars
312
patch has no errors when building our shaded downstream artifacts.

+1
hadoopcheck
1034
Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2.

+1
javadoc
42
the patch passed

+1
findbugs
294
the patch passed

_ Other Tests _

+1
unit
10092
hbase-server in the patch passed.

+1
asflicense
32
The patch does not generate ASF License warnings.

14154

Subsystem
Report/Notes

Docker
Client=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-553/1/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/553

Optional Tests
dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile

uname
Linux c355376da5c0 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 GNU/Linux

Build tool
maven

Personality
/home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-553/out/precommit/personality/provided.sh

git revision
master / 56980fb097

Default Java
1.8.0_181

Test Results
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-553/1/testReport/

Max. process+thread count
4803 (vs. ulimit of 10000)

modules
C: hbase-server U: hbase-server

Console output
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-553/1/console

versions
git=2.11.0 maven=2018-06-17T18:33:14Z) findbugs=3.1.11

Powered by
Apache Yetus 0.10.0 http://yetus.apache.org

This message was automatically generated.

Also, may I ask what kind of testing did you perform with the patch? Thanks.

The following scenario is ok.
case1:  Bulkload from different hdfs.
case2:  Bulkoad from same hdfs.
case3:  Bulkload replication to slave cluster
The test code : https://github.com/Yiran-wu/bulkload-3.0

TestReplicationSyncUpToolWithBulkLoadedData already include this UT

Thanks for review  @jatsakthi
I think we need to add a unit test to cover this scenario, I am doing this.

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Comment

0
reexec
37
Docker mode activated.

_ Prechecks _

+1
dupname
0
No case conflicting files found.

+1
hbaseanti
0
Patch does not have any anti-patterns.

+1
@author
0
The patch does not contain any @author tags.

-0
test4tests
0
The patch doesn't appear to include any new or modified tests.  Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.

_ master Compile Tests _

+1
mvninstall
396
master passed

+1
compile
58
master passed

+1
checkstyle
103
master passed

+1
shadedjars
351
branch has no errors when building our shaded downstream artifacts.

+1
javadoc
44
master passed

0
spotbugs
281
Used deprecated FindBugs config; considering switching to SpotBugs.

+1
findbugs
278
master passed

_ Patch Compile Tests _

+1
mvninstall
387
the patch passed

+1
compile
68
the patch passed

+1
javac
68
the patch passed

+1
checkstyle
100
the patch passed

+1
whitespace
0
The patch has no whitespace issues.

+1
shadedjars
333
patch has no errors when building our shaded downstream artifacts.

+1
hadoopcheck
1161
Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2.

+1
javadoc
41
the patch passed

+1
findbugs
277
the patch passed

_ Other Tests _

+1
unit
9551
hbase-server in the patch passed.

+1
asflicense
28
The patch does not generate ASF License warnings.

13658

Subsystem
Report/Notes

Docker
Client=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-553/2/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/553

Optional Tests
dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile

uname
Linux 636e6e3759b7 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 GNU/Linux

Build tool
maven

Personality
/home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-553/out/precommit/personality/provided.sh

git revision
master / 83e77940c5

Default Java
1.8.0_181

Test Results
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-553/2/testReport/

Max. process+thread count
4405 (vs. ulimit of 10000)

modules
C: hbase-server U: hbase-server

Console output
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-553/2/console

versions
git=2.11.0 maven=2018-06-17T18:33:14Z) findbugs=3.1.11

Powered by
Apache Yetus 0.10.0 http://yetus.apache.org

This message was automatically generated.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Comment

0
reexec
164
Docker mode activated.

_ Prechecks _

+1
dupname
0
No case conflicting files found.

+1
hbaseanti
0
Patch does not have any anti-patterns.

+1
@author
0
The patch does not contain any @author tags.

-0
test4tests
0
The patch doesn't appear to include any new or modified tests.  Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.

_ master Compile Tests _

+1
mvninstall
476
master passed

+1
compile
75
master passed

+1
checkstyle
94
master passed

+1
shadedjars
345
branch has no errors when building our shaded downstream artifacts.

+1
javadoc
47
master passed

0
spotbugs
297
Used deprecated FindBugs config; considering switching to SpotBugs.

+1
findbugs
295
master passed

_ Patch Compile Tests _

+1
mvninstall
437
the patch passed

+1
compile
75
the patch passed

+1
javac
75
the patch passed

+1
checkstyle
97
the patch passed

+1
whitespace
0
The patch has no whitespace issues.

+1
shadedjars
364
patch has no errors when building our shaded downstream artifacts.

+1
hadoopcheck
1312
Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2.

+1
javadoc
47
the patch passed

+1
findbugs
292
the patch passed

_ Other Tests _

-1
unit
16053
hbase-server in the patch failed.

+1
asflicense
25
The patch does not generate ASF License warnings.

20703

Reason
Tests

Failed junit tests
hadoop.hbase.TestSplitMerge

hadoop.hbase.regionserver.wal.TestAsyncLogRolling

hadoop.hbase.regionserver.TestNewVersionBehaviorFromClientSide

hadoop.hbase.regionserver.TestRegionServerMetrics

Subsystem
Report/Notes

Docker
Client=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-553/3/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/553

Optional Tests
dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile

uname
Linux 4368a0e7fadf 4.15.0-48-generic #51-Ubuntu SMP Wed Apr 3 08:28:49 UTC 2019 x86_64 GNU/Linux

Build tool
maven

Personality
/home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-553/out/precommit/personality/provided.sh

git revision
master / 090c55f3ff

Default Java
1.8.0_181

unit
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-553/3/artifact/out/patch-unit-hbase-server.txt

Test Results
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-553/3/testReport/

Max. process+thread count
4606 (vs. ulimit of 10000)

modules
C: hbase-server U: hbase-server

Console output
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-553/3/console

versions
git=2.11.0 maven=2018-06-17T18:33:14Z) findbugs=3.1.11

Powered by
Apache Yetus 0.10.0 http://yetus.apache.org

This message was automatically generated.

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Comment

0
reexec
41
Docker mode activated.

_ Prechecks _

+1
dupname
1
No case conflicting files found.

+1
hbaseanti
0
Patch does not have any anti-patterns.

+1
@author
0
The patch does not contain any @author tags.

+1
test4tests
0
The patch appears to include 1 new or modified test files.

_ master Compile Tests _

+1
mvninstall
393
master passed

+1
compile
66
master passed

+1
checkstyle
108
master passed

+1
shadedjars
348
branch has no errors when building our shaded downstream artifacts.

+1
javadoc
46
master passed

0
spotbugs
320
Used deprecated FindBugs config; considering switching to SpotBugs.

+1
findbugs
317
master passed

_ Patch Compile Tests _

+1
mvninstall
381
the patch passed

+1
compile
74
the patch passed

+1
javac
74
the patch passed

+1
checkstyle
116
the patch passed

+1
whitespace
0
The patch has no whitespace issues.

+1
shadedjars
350
patch has no errors when building our shaded downstream artifacts.

+1
hadoopcheck
1257
Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2.

+1
javadoc
39
the patch passed

+1
findbugs
323
the patch passed

_ Other Tests _

+1
unit
10250
hbase-server in the patch passed.

+1
asflicense
28
The patch does not generate ASF License warnings.

14614

Subsystem
Report/Notes

Docker
Client=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-553/5/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/553

Optional Tests
dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile

uname
Linux dffbab1873b7 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 GNU/Linux

Build tool
maven

Personality
/home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-553/out/precommit/personality/provided.sh

git revision
master / 090c55f3ff

Default Java
1.8.0_181

Test Results
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-553/5/testReport/

Max. process+thread count
4448 (vs. ulimit of 10000)

modules
C: hbase-server U: hbase-server

Console output
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-553/5/console

versions
git=2.11.0 maven=2018-06-17T18:33:14Z) findbugs=3.1.11

Powered by
Apache Yetus 0.10.0 http://yetus.apache.org

This message was automatically generated.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Comment

0
reexec
142
Docker mode activated.

_ Prechecks _

+1
dupname
0
No case conflicting files found.

+1
hbaseanti
0
Patch does not have any anti-patterns.

+1
@author
0
The patch does not contain any @author tags.

+1
test4tests
0
The patch appears to include 1 new or modified test files.

_ master Compile Tests _

+1
mvninstall
490
master passed

+1
compile
79
master passed

+1
checkstyle
125
master passed

+1
shadedjars
375
branch has no errors when building our shaded downstream artifacts.

+1
javadoc
47
master passed

0
spotbugs
313
Used deprecated FindBugs config; considering switching to SpotBugs.

+1
findbugs
310
master passed

_ Patch Compile Tests _

+1
mvninstall
351
the patch passed

+1
compile
62
the patch passed

+1
javac
63
the patch passed

+1
checkstyle
91
the patch passed

+1
whitespace
0
The patch has no whitespace issues.

+1
shadedjars
301
patch has no errors when building our shaded downstream artifacts.

+1
hadoopcheck
1065
Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2.

+1
javadoc
35
the patch passed

+1
findbugs
287
the patch passed

_ Other Tests _

-1
unit
14689
hbase-server in the patch failed.

+1
asflicense
33
The patch does not generate ASF License warnings.

18912

Subsystem
Report/Notes

Docker
Client=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-553/6/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/553

Optional Tests
dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile

uname
Linux 6fb208272da4 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 GNU/Linux

Build tool
maven

Personality
/home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-553/out/precommit/personality/provided.sh

git revision
master / ee5cf0d209

Default Java
1.8.0_181

unit
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-553/6/artifact/out/patch-unit-hbase-server.txt

Test Results
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-553/6/testReport/

Max. process+thread count
5283 (vs. ulimit of 10000)

modules
C: hbase-server U: hbase-server

Console output
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-553/6/console

versions
git=2.11.0 maven=2018-06-17T18:33:14Z) findbugs=3.1.11

Powered by
Apache Yetus 0.10.0 http://yetus.apache.org

This message was automatically generated.

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Comment

0
reexec
38
Docker mode activated.

_ Prechecks _

+1
dupname
0
No case conflicting files found.

+1
hbaseanti
0
Patch does not have any anti-patterns.

+1
@author
0
The patch does not contain any @author tags.

+1
test4tests
0
The patch appears to include 1 new or modified test files.

_ master Compile Tests _

+1
mvninstall
320
master passed

+1
compile
56
master passed

+1
checkstyle
78
master passed

+1
shadedjars
273
branch has no errors when building our shaded downstream artifacts.

+1
javadoc
40
master passed

0
spotbugs
255
Used deprecated FindBugs config; considering switching to SpotBugs.

+1
findbugs
253
master passed

_ Patch Compile Tests _

+1
mvninstall
306
the patch passed

+1
compile
57
the patch passed

+1
javac
57
the patch passed

+1
checkstyle
81
the patch passed

+1
whitespace
0
The patch has no whitespace issues.

+1
shadedjars
284
patch has no errors when building our shaded downstream artifacts.

+1
hadoopcheck
958
Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2.

+1
javadoc
37
the patch passed

+1
findbugs
256
the patch passed

_ Other Tests _

+1
unit
9920
hbase-server in the patch passed.

+1
asflicense
35
The patch does not generate ASF License warnings.

13383

Subsystem
Report/Notes

Docker
Client=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-553/7/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/553

Optional Tests
dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile

uname
Linux c4e0703251b5 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 GNU/Linux

Build tool
maven

Personality
/home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-553/out/precommit/personality/provided.sh

git revision
master / b642ee0418

Default Java
1.8.0_181

Test Results
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-553/7/testReport/

Max. process+thread count
4200 (vs. ulimit of 10000)

modules
C: hbase-server U: hbase-server

Console output
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-553/7/console

versions
git=2.11.0 maven=2018-06-17T18:33:14Z) findbugs=3.1.11

Powered by
Apache Yetus 0.10.0 http://yetus.apache.org

This message was automatically generated.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Comment

0
reexec
85
Docker mode activated.

_ Prechecks _

+1
dupname
0
No case conflicting files found.

+1
hbaseanti
0
Patch does not have any anti-patterns.

+1
@author
0
The patch does not contain any @author tags.

+1
test4tests
0
The patch appears to include 1 new or modified test files.

_ master Compile Tests _

+1
mvninstall
374
master passed

+1
compile
61
master passed

+1
checkstyle
96
master passed

+1
shadedjars
310
branch has no errors when building our shaded downstream artifacts.

+1
javadoc
37
master passed

0
spotbugs
269
Used deprecated FindBugs config; considering switching to SpotBugs.

+1
findbugs
265
master passed

_ Patch Compile Tests _

+1
mvninstall
335
the patch passed

+1
compile
58
the patch passed

+1
javac
58
the patch passed

+1
checkstyle
91
the patch passed

+1
whitespace
1
The patch has no whitespace issues.

+1
shadedjars
315
patch has no errors when building our shaded downstream artifacts.

+1
hadoopcheck
1069
Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2.

+1
javadoc
37
the patch passed

+1
findbugs
296
the patch passed

_ Other Tests _

-1
unit
13804
hbase-server in the patch failed.

+1
asflicense
34
The patch does not generate ASF License warnings.

17694

Subsystem
Report/Notes

Docker
Client=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-553/8/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/553

Optional Tests
dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile

uname
Linux 433bc4af3a12 4.15.0-54-generic #58-Ubuntu SMP Mon Jun 24 10:55:24 UTC 2019 x86_64 GNU/Linux

Build tool
maven

Personality
/home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-553/out/precommit/personality/provided.sh

git revision
master / 97fbaa658e

Default Java
1.8.0_181

unit
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-553/8/artifact/out/patch-unit-hbase-server.txt

Test Results
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-553/8/testReport/

Max. process+thread count
4598 (vs. ulimit of 10000)

modules
C: hbase-server U: hbase-server

Console output
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-553/8/console

versions
git=2.11.0 maven=2018-06-17T18:33:14Z) findbugs=3.1.11

Powered by
Apache Yetus 0.10.0 http://yetus.apache.org

This message was automatically generated.

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Comment

0
reexec
44
Docker mode activated.

_ Prechecks _

+1
dupname
0
No case conflicting files found.

+1
hbaseanti
0
Patch does not have any anti-patterns.

+1
@author
0
The patch does not contain any @author tags.

+1
test4tests
0
The patch appears to include 1 new or modified test files.

_ master Compile Tests _

+1
mvninstall
330
master passed

+1
compile
55
master passed

+1
checkstyle
76
master passed

+1
shadedjars
275
branch has no errors when building our shaded downstream artifacts.

+1
javadoc
38
master passed

0
spotbugs
259
Used deprecated FindBugs config; considering switching to SpotBugs.

+1
findbugs
257
master passed

_ Patch Compile Tests _

+1
mvninstall
309
the patch passed

+1
compile
56
the patch passed

+1
javac
56
the patch passed

+1
checkstyle
76
the patch passed

+1
whitespace
0
The patch has no whitespace issues.

+1
shadedjars
279
patch has no errors when building our shaded downstream artifacts.

+1
hadoopcheck
926
Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2.

+1
javadoc
36
the patch passed

+1
findbugs
249
the patch passed

_ Other Tests _

+1
unit
10004
hbase-server in the patch passed.

+1
asflicense
31
The patch does not generate ASF License warnings.

13417

Subsystem
Report/Notes

Docker
Client=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-553/9/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/553

Optional Tests
dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile

uname
Linux d708715fb8d8 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 GNU/Linux

Build tool
maven

Personality
/home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-553/out/precommit/personality/provided.sh

git revision
master / a5ef6b287c

Default Java
1.8.0_181

Test Results
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-553/9/testReport/

Max. process+thread count
4365 (vs. ulimit of 10000)

modules
C: hbase-server U: hbase-server

Console output
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-553/9/console

versions
git=2.11.0 maven=2018-06-17T18:33:14Z) findbugs=3.1.11

Powered by
Apache Yetus 0.10.0 http://yetus.apache.org

This message was automatically generated.

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Comment

0
reexec
46
Docker mode activated.

_ Prechecks _

+1
dupname
0
No case conflicting files found.

+1
hbaseanti
0
Patch does not have any anti-patterns.

+1
@author
0
The patch does not contain any @author tags.

+1
test4tests
0
The patch appears to include 1 new or modified test files.

_ master Compile Tests _

+1
mvninstall
411
master passed

+1
compile
67
master passed

+1
checkstyle
102
master passed

+1
shadedjars
351
branch has no errors when building our shaded downstream artifacts.

+1
javadoc
43
master passed

0
spotbugs
293
Used deprecated FindBugs config; considering switching to SpotBugs.

+1
findbugs
291
master passed

_ Patch Compile Tests _

+1
mvninstall
386
the patch passed

+1
compile
70
the patch passed

+1
javac
70
the patch passed

+1
checkstyle
96
the patch passed

+1
whitespace
0
The patch has no whitespace issues.

+1
shadedjars
355
patch has no errors when building our shaded downstream artifacts.

+1
hadoopcheck
1128
Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2.

+1
javadoc
38
the patch passed

+1
findbugs
265
the patch passed

_ Other Tests _

+1
unit
9453
hbase-server in the patch passed.

+1
asflicense
34
The patch does not generate ASF License warnings.

13559

Subsystem
Report/Notes

Docker
Client=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-553/10/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/553

Optional Tests
dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile

uname
Linux 54f4a0c59601 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 GNU/Linux

Build tool
maven

Personality
/home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-553/out/precommit/personality/provided.sh

git revision
master / a5ef6b287c

Default Java
1.8.0_181

Test Results
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-553/10/testReport/

Max. process+thread count
4327 (vs. ulimit of 10000)

modules
C: hbase-server U: hbase-server

Console output
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-553/10/console

versions
git=2.11.0 maven=2018-06-17T18:33:14Z) findbugs=3.1.11

Powered by
Apache Yetus 0.10.0 http://yetus.apache.org

This message was automatically generated.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Comment

0
reexec
43
Docker mode activated.

_ Prechecks _

+1
dupname
0
No case conflicting files found.

+1
hbaseanti
0
Patch does not have any anti-patterns.

+1
@author
0
The patch does not contain any @author tags.

+1
test4tests
0
The patch appears to include 1 new or modified test files.

_ master Compile Tests _

+1
mvninstall
403
master passed

+1
compile
68
master passed

+1
checkstyle
104
master passed

+1
shadedjars
320
branch has no errors when building our shaded downstream artifacts.

+1
javadoc
37
master passed

0
spotbugs
280
Used deprecated FindBugs config; considering switching to SpotBugs.

+1
findbugs
276
master passed

_ Patch Compile Tests _

+1
mvninstall
378
the patch passed

+1
compile
64
the patch passed

+1
javac
64
the patch passed

+1
checkstyle
93
the patch passed

+1
whitespace
0
The patch has no whitespace issues.

+1
shadedjars
341
patch has no errors when building our shaded downstream artifacts.

+1
hadoopcheck
1208
Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2.

+1
javadoc
41
the patch passed

+1
findbugs
255
the patch passed

_ Other Tests _

-1
unit
9919
hbase-server in the patch failed.

+1
asflicense
31
The patch does not generate ASF License warnings.

13992

Reason
Tests

Failed junit tests
hadoop.hbase.regionserver.TestHRegionWithInMemoryFlush

Subsystem
Report/Notes

Docker
Client=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-553/11/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/553

Optional Tests
dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile

uname
Linux 7b5c0382e929 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 GNU/Linux

Build tool
maven

Personality
/home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-553/out/precommit/personality/provided.sh

git revision
master / 8e8bd8b254

Default Java
1.8.0_181

unit
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-553/11/artifact/out/patch-unit-hbase-server.txt

Test Results
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-553/11/testReport/

Max. process+thread count
4845 (vs. ulimit of 10000)

modules
C: hbase-server U: hbase-server

Console output
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-553/11/console

versions
git=2.11.0 maven=2018-06-17T18:33:14Z) findbugs=3.1.11

Powered by
Apache Yetus 0.10.0 http://yetus.apache.org

This message was automatically generated.


KAFKA-9131 remove dead code responsible for handling timeout exceptio…

…ns in catch clause and move it to the callback
More detailed description of your change,
if necessary. The PR title and PR message become
the squashed commit message, so use a separate
comment to ping reviewers.
Summary of testing strategy (including rationale)
for the feature or bug fix. Unit and/or integration
tests are expected for any behaviour change and
system tests should be considered for larger changes.
Committer Checklist (excluded from commit message)

[ ] Verify design and implementation
[ ] Verify test coverage and CI build status
[ ] Verify documentation (including upgrade notes)

@guozhangwang @hachikuji -- would appreciate a review of this PR (for details look into https://issues.apache.org/jira/browse/KAFKA-9131 -- seems we change some producer code with regard to handling exceptions? Would be good if you could verify that this PR makes sense).

@mjsax I looked at the code and it seems that producer.send indeed no longer throwing TimeoutException any more (hence we should update KafkaProducer.send javadoc as well to remove the possible thrown exception).
About the proposal on the streams side, it looks good to me. Thanks @gleb-kom !!

@vvcephei could you also take a look at this PR as well?

@guozhangwang . Roger that. I'll take a look.

@guozhangwang @vvcephei
Thank you for the review. I removed @throws in Javadoc from send and added it to waitOnMetada.

Some nit about code style. Overall LGMT. Can merge after addressed.

@mjsax
Thanks for the review. I addressed your comments.

Java 11 / 2.12 passed. Java 11 / 2.13 and Java8 failed (test results are not available any longer).
Retest this please. \cc @vvcephei for merging.

@gleb-kom I tried to merge the PR but found it needs some rebasing, could you do that?

@guozhangwang done


Adding a model overlay to edit or update the post

here only user can update or edit his/her post by selecting edit function and when he clicks the edit button an model overlay saying want to edit

Resolved.


Simple process Health checker introduced

Hi!
Thank you for your contribution. 👍
At first glance, looks fine for me. I test it as soon as possible.

I noticed there is a HEALTHCHECK instruction for Dockerfiles. Is it better to use them instead?

Totally, works for me..
There can only be one HEALTHCHECK instruction in a Dockerfile. If you list more than one then only the last HEALTHCHECK will take effect.

Well, this health check might be the only one for now which means maybe it’s better idea to implement in the Dockerfiles instead of docker-compose.yml. Then you don’t have to add health check explicitly. In Dockerfile, it comes out of the box.
Unless adding it only to docker-compose.yml is better – in the case when we add multiple health checks?

First approach would be fine by me, I am totally OK with whatever approach you may decide to go ahead with.. :)
Thanks

I moved the healthcheck script into a bin/ folder and added it to the Dockerfile. Might move run.sh later on.
I merge this one. Thank you for your contribution. :)


Local shibboleth setup

Is your feature request related to a problem? Please describe.
For testing currently we have to forcefully add an additional header utorid before running the client. The idea here is to explore ways to automate this.
Describe the solution you'd like

Consider using a env variable that decides whether or not to add the additional header
OR
A more preferred fix would be to mimic the exact production setup i.e. run the application behind shibboleth. Explore whether we can setup shibboleth locally in docker for development and testing

Additional context
A guide to setup shibboleth locally - https://isea.utoronto.ca/services/weblogin/sso-howto-weblogin/

Hi, please assign me to this issue. :slightly_smiling_face:

Shibboleth is turning out to be extremely finicky to work with. Do we actually need Shibboleth, or can I just configure an Apache server to add a "utorid" header to all requests it proxies?

Well like we saw in #50 shibboleth can have an impact on how things are working. So it would be nice to mimic this in a dev environment. If it is too unstable, then we can consider using either Apache or maybe a simple node env variable for example:
const headers = process.env.NODE_ENV === "production" ? {utorid: "exampl_utorid"} : {}

Also let us know what you have tried to setup shibboleth. Maybe we can help you debug.
There is a docker image for shibboleth - https://github.com/Unicon/shibboleth-idp-dockerized
Configuration info - https://shibboleth.atlassian.net/wiki/spaces/SP3/pages/2063695920/Configuration
There is some info on uoft related shibboleth setup  (although we can't request it since it is just for their staff but maybe we can mimic whatever info is available publicly) - http://sites.utoronto.ca/security/projects/EASI-dev.htm

Interesting; I'll see if I can get the docker image to behave. That was basically what I was trying to create from scratch earlier. Thanks.

Which half of Shibboleth do we care about replicating? The IdP or SP portion? It's a bit unclear to me what the difference is.

You would need both I believe.
Here is good read - https://shibboleth.atlassian.net/wiki/spaces/CONCEPT/overview
This example might help set things up - https://github.com/UniconLabs/dockerized-idp-testbed


How do I use the utility function in Angular

Hi there,
I'm finding myself to add transform: none to elements have been animated so my elements that position: fixed aren't messed up. However to be able to use element.css('transform', 'none') I have to use it in a $timeout function so wait for the DOM to fully render, like so:
function create(element) {
      element
      .velocity('transition.expandIn', {duration : 450, display: 'block', delay: 350})
      .velocity('callout.flash');
      $timeout(function() {
        element.css('transform', 'none');
      }, 1000);
    }

I would rather run element.css('transform', 'none') using a promise. However to use promises with Velocity I have to run the utility function, as per your docs. But when I do that I get an error that says $ is undefined, so how do I use the utility function in an Angular service so that I run element.css('transform', 'none') after the animation is complete using a promise rather than the janky $timeout?

Have you tried $.Velocity.hook(element, "transform", "none");?

@ydaniv Thanks for this.
In my previous comment I mentioned: I get an error that says $ is undefined, so your suggestion would also give me the same error.


feat: add evmos support

Motivation
add evmos network support

Solution

PR Checklist

[ ] Added Tests
[ ] Added Documentation
[ ] Updated the changelog

@gakonst pls merge


mousedown event not working

Hi,
I am facing an issue with mousedown event.
Here is the code sandbox link to reproduce the issue: https://codesandbox.io/s/react-shadow-mosedown-e31k3?file=/src/index.js.
Basically, i have created an mousedown event on document. I expect the event.target to be element's container when event triggers but the target always reference to the shadow dom root.
Any suggestion would really help.

That's due to event retargeting which hides the implementation details of the nodes encapsulated in the shadow root.

Any way to fix it ?

Tough, but you can try e.composedPath()[0] instead of event.target. Although with using composedPath you'll have to begin implementing custom logic to get the relevant node.


Add book detail pages

We want to have detail pages for each book.

title
release date
blurb
ISBNs
release links (amazon, d2d, BnN, etc.)
excerpt (hidden, until shown?)

Closing as a duplicate.


When building from dockerfile unable to load web interface

What is the question?
I have built vulnman from the dockerfile but any request to web interface just returns Bad Request 400 errors.

Here are my config files:
docker-compose.yml
version: '3'

services:
  vulnman-web:
    image: ghcr.io/vulnman/vulnman:latest
    volumes:
      - './local_settings.py:/app/local_settings.py'
      - '/tmp/volumes/vulnman/static:/app/static_files'
    environment:
      DJANGO_SUPERUSER_PASSWORD: dontusethispassword
      DJANGO_SUPERUSER_USERNAME: vulnmanadmin
      DJANGO_SUPERUSER_EMAIL<EMAIL_ADDRESS>    depends_on:
      - db
      - celery

  celery:
    image: ghcr.io/vulnman/vulnman:latest
    entrypoint: celery -A vulnman worker -l INFO
    volumes:
      - './local_settings.py:/app/local_settings.py'
      - '/tmp/volumes/vulnman/static:/app/static_files'
    depends_on:
      - redis

  db:
    image: postgres:14.2-alpine
    volumes:
      - '/tmp/volumes/vulnman/db:/var/lib/postgresql/data'
    environment:
      POSTGRES_PASSWORD: dontusethispassword
      POSTGRES_USER: vulnman_db_user
      POSTGRES_DB: vulnman

  redis:
    image: "redis:alpine"

  nginx:
    image: lscr.io/linuxserver/nginx
    container_name: nginx
    environment:
      - PUID=1000
      - PGID=1000
      - TZ=Europe/London
    volumes:
      - '/tmp/volumes/nginx/config:/config'
      - './docker/nginx.conf:/config/nginx/site-confs/default'
      - '/tmp/volumes/vulnman/static:/config/www/static'
    ports:
      - '80:80'
      - '443:443'
    depends_on:
      - vulnman-web

local_settings.py
# This is an example settings file for vulnman

# Enable debug mode. DONT USE IN PRODUCTION ENVIRONMENT!
# DEBUG = True

# Allowed Hosts
# set this to the hostnames of allowed to be used in the Host HTTP header
ALLOWED_HOSTS = ["vulman-web","localhost"]

# Required Setting:
CSRF_TRUSTED_ORIGINS = ['http://localhost','http://<IP_ADDRESS>']

# CSS theme
# VULNMAN_CSS_THEME = "flatly"

# #################
# Database Settings
# #################
# uncomment the postgres section, if you are using the docker image
#
# Postgres Example:
#
DATABASES = {
 'default': {
   'ENGINE': 'django.db.backends.postgresql',
   'HOST': 'db',
   'NAME': 'vulnman',
   'USER': 'vulnman_db_user',
   'PASSWORD': 'dontusethispassword',
 }
}

# #########
# Reporting
# #########

# Report Templates
REPORT_TEMPLATES = {
   "default": {
       "CSS": ["report.css", "fontawesome.min.css"]
   }
}

# Add information about your company that is displayed in the report
REPORT_COMPANY_INFORMATION = {
    "name": "Vulnman",
    "street": "No Street 54",
    "zip": "123456 Berlin, Germany",
    "homepage": "https://vulnman.github.io/vulnman",
    "contact"<EMAIL_ADDRESS>}

# ########
# Security
# For further harding checks see https://docs.djangoproject.com/en/3.2/howto/deployment/checklist/
# Note: the SECRET_KEY value is uniquely auto generated by default for vulnman installations
# ########

# Set this to True to avoid transmitting the CSRF cookie over HTTP accidentally.
# Default: True
CSRF_COOKIE_SECURE = True

# Set this to True to avoid transmitting the session cookie over HTTP accidentally.
# Default: True
SESSION_COOKIE_SECURE = True

######################
# Celery Worker
######################
# Required for Docker!
CELERY_BROKER_URL = "redis://redis:6379"

Additional Information
No response

Fixed it. I had an issue in one of my other configs.

Hey @b34rd-tek ,
happy that you got it work on your side with such less of documentation at the moment.
if you think your configuration error came from missing documentation, I'd appreciate it if you could tell me what the error was.
I would update the (almost non-existent) doc accordingly.

Ironically it was white space issues. I just reformatted the files with the correct white space and everything worked as designed.


[BEAM-4858] Clean up division in batch size estimator.

R: @tvalentyn

Follow this checklist to help us incorporate your contribution quickly and easily:

[ ] Format the pull request title like [BEAM-XXX] Fixes bug in ApproximateQuantiles, where you replace BEAM-XXX with the appropriate JIRA issue, if applicable. This will automatically link the pull request to the issue.
[ ] If this contribution is large, please file an Apache Individual Contributor License Agreement.

It will help us expedite review of your Pull Request if you tag someone (e.g. @username) to look at it.
Post-Commit Tests Status (on master branch)

Lang
SDK
Apex
Dataflow
Flink
Gearpump
Samza
Spark

Go

---
---
---
---
---
---

Java

Python

---

---
---
---
---

retest this please

retest this please

Looks like the Precommit failure is specific to this PR.

Tests passing, PTAL.

Thanks. The code LGTM, PTAL at test failures and please do a performance check using updated code before merging.

You're right, the a and b were switched in computing the error term when I copied this to the PR. This meant that significantly more points were considered outliers (but enough retained to typically give a reasonable regression). Unfortunately this fix means that it's still pretty sensitive to multiple outliers...
I'm trying a simpler approach: just assume the top quantile is outliers. We have enough data to make this pretty robust. Running experiments now.
(As for computing h, I used sagemath.)

Thanks. Is this ready for review?

Yes, this is ready for another round of review. I also cleaned up the commit history (with an exanded and updated commit comment.)


Support for Encrypted ClientHello (ECH)

Hi, I need ECH when connecting to a quic server.
I know it is a draft but is there any plan for implementing it?
If I want to implement it myself where should I start? (I'm pretty noob in go).

I'm surprised you're saying that you need it. I'm not aware of any ECH deployments on QUIC at this point. Which server are you trying to connect to?
I agree that this would be valuable to have. This will require a TLS stack that supports ECH. As we're switching to crypto/tls with the Go 1.21 release, ECH would need to be implemented by the standard library. This will most likely (at the very least) require the draft to be published as an RFC, so realistically speaking, we won't be able to support ECH for a year or so.

Unfortunately, no open-source server currently supports it in their stable versions but there are some ECH implementations here: defo.ie.
I plan on using Cloudflare which currently supports it.
Sounds like I would need to implement it in your fork of crypto/tls, I don't know how but I'm going to try.

Please don’t. This fork is going to be removed within a couple of weeks. quic-go will only rely on crypto/tls, no more forks necessary.

Thanks for your warning, assuming go 1.21 realases, can I fork crypto/tls from there and implement ECH on that?

I've made a tested fork of quic-go that supports ECH. ECH support is extracted from crypto/tls in cloudflare/go.
Source: https://github.com/SagerNet/quic-go/commits/dev
Usage: https://github.com/SagerNet/sing-box/commit/638c209ac91b18f206aa3ea3aece83d183114acf

There seems to be some progress on the standard library side, albeit only on the client side: https://github.com/golang/go/issues/63369#issuecomment-1985020100

I'm going to close this issue, since this is now purely a crypto/tls issue. With https://github.com/golang/go/issues/63369, crypto/tls would gain client-side ECH support. No changes to quic-go will be needed for that.
Similarly, if / when the standard library decides to add server-side ECH support, it is expected that no changes to quic-go will be needed either. Therefore, this issue is not actionable (in quic-go).


Zoom issues at higher resolutions

Terraria version: <IP_ADDRESS>
TerraAngel version: https://github.com/CEO-Chair/TerraAngel/commit/3319f8c7201ec85da6c79a2a4e91583b1a747a73

Initial zoom levels (100%) here differ from vanilla.
Vanilla, 2880x1800 (16:10), borderless window, zoom: 100%, UI scale: 100%:

TerraAngel, 2880x1800 (16:10), borderless window, zoom: 100%, UI scale: 100%:

TerraAngel, 2880x1800 (16:10), windowed, main menu (not cropped)

There are also some misaligned texts under Settings Menu > Video:

Alright, I'll look into this tomorrow.

Alright, I'll look into this tomorrow.

I am unable to reproduce the zoom issue on 3440x1440

I am similarly unable to reproduce this bug on 1600x1000

Same goes for fullscreen and borderless windowed

I messed around with my Windows display resolutions and found that it seems to be affected by the scaling.

I normally use 200% scaling but at 100% it works fine, with the caveat that TerraAngel's UI and everything else outside the game becomes tiny.

I think I found a fix: by overriding the scaling to be performed by the application.

Results

TerraAngel's UI still very small, however, albeit still usable.

This may be an issue with the backend for windowing in TerraAngel being different than the normal game


Return 404 if no header is sent, but header based version is used

When no header is sent, but :using => :header is used, a 404 should be
returned, because this would mean no version is being selected

Hmm...I'm on the fence on this one. Should it 404 or should it use the latest version? The latter is friendlier but more likely to lead to client apps breaking when the version changes. On the other hand, versions are usually months if not years apart so it's not likely to cause problems immediately.

What about adding a versioning option like :strict => [true | false]  ?

I'm on the fence about this one.  If we follow the semantics of the Accept
header (http://www.w3.org/Protocols/rfc2616/rfc2616-sec14.html), then not
setting an Accept header means the client can handle any representation the
server decides to respond with.  In this case, grape should return the
first endpoint that doesn't return 404.
On the other hand, there's a good chance the client developer meant to
include an Accept header, but forgot to.  I think a good way to solve both
is to include a :whiny option when declaring versions:
class API < Grape::API
  # if whiny is set, and no accept header exists, return 404
  version :v1, :using => :headers, :whiny => true
end

Thoughts?
On Wed, Nov 23, 2011 at 9:55 AM, jwkoelewijn <
<EMAIL_ADDRESS>
wrote:

When no header is sent, but :using => :header is used, a 404 should be
returned, because this would mean no version is being selected
You can merge this Pull Request by running:
git pull https://github.com/jwkoelewijn/grape no_header_set_404
Or you can view, comment on it, or merge it online at:
https://github.com/intridea/grape/pull/79
-- Commit Summary --

Return 404 if no header is sent, but header based version is used

-- File Changes --
M lib/grape/middleware/versioner/header.rb (8)
M spec/grape/middleware/versioner/header_spec.rb (14)
-- Patch Links --
https://github.com/intridea/grape/pull/79.patch
https://github.com/intridea/grape/pull/79.diff

Reply to this email directly or view it on GitHub:
https://github.com/intridea/grape/pull/79

--
P.S. I've been working on a car blog (http://rockyroadblog.com). If you or
any friends are into cars, I'd love to hear what you guys think.

@jch Then we both agree :) Not sure about the whiny option name though ;)

+1 on the :strict => boolean
@mbleigh "the latest" version is currently determined by the order that the versions are declared in. Since grape uses Rack::Mount, the first endpoint that doesn't 404 will respond.  I think that should be reflected in the docs rather than be a code change.

@jwkoelewjin sorry for the double post, the updated messages didn't make it into my inbox and I used email reply :P Funny to me that I ended up saying exactly what both you and @mbleigh said though

All righty then. @jwkoelewijn if you update this to make the 404-ing optional and based on declaring :strict => true I'll accept this patch. You get bonus points if you update the README to reflect that one should declare the "default version" first in their API, just like in Rails routes: whoever matches first wins.

Updated it :)


value.getTime() not a function

<el-form-item required prop="end_time">
 <el-date-picker
      v-model="event.end_time"
       type="datetime"
       style="width: 100%;"
       placeholder="Select end time">
   </el-date-picker>
</el-form-item>

 import {
        DatePicker,
        TimePicker,
    } from 'element-ui'

    export default{

        components: {
            'el-date-picker': DatePicker,
            'el-time-picker': TimePicker,
        },

 data () {
            return {
                rules: {

                    start_time: [
                        { required: true, type:'date', message: 'Please pick a time', trigger: 'change' },
                    ],
                    end_time: [
                        { required: true, type:'date', message: 'Please pick a time', trigger: 'change' },
                    ],
                }
            }

Vuejs 2.2.1
Element UI : 1.2.3
I've got this error when validating my form.
value.getTime() not a function
Here is the bugged line in the Chome console :
if (value) {
        _rule2["default"].range(rule, value.getTime(), source, errors, options);
      }

My value = "2017-03-23 23:00:00"
What can I do ? Thank you

because the data of time is a string ，not a object Date or js timestamp

https://jsfiddle.net/1tqrt0p6/
Both String and Date type are supported.

我也遇见了这样的问题，于是我选择了自定义校验，规避了这个

All U need to do is change the type in the rules to "string". That's it!

make sure that you have validation for the field on your server side

value needs to be a Date object, like new Date()


Add documentation on how to use Google Scripts to convert API to Google Sheet

Pain point :
Many of our the analysts are not familiar with using the API for analysis.
Solution:
A google script can easily fetch the data from the API and store it in their personal Google Sheet every 30 minutes or so.
If we can create the script and write a simple document on how to do this, it would be a great help!

I have used this code in Google Sheets, to Import the JSON files from api.covid19india.org and it works fine.
/**

Retrieves all the rows in the active spreadsheet that contain data and logs the
values for each row.
For more information on using the Spreadsheet API, see
https://developers.google.com/apps-script/service_spreadsheet
*/
function readRows() {
var sheet = SpreadsheetApp.getActiveSheet();
var rows = sheet.getDataRange();
var numRows = rows.getNumRows();
var values = rows.getValues();

for (var i = 0; i <= numRows - 1; i++) {
var row = values[i];
Logger.log(row);
}
};
/**

Adds a custom menu to the active spreadsheet, containing a single menu item
for invoking the readRows() function specified above.
The onOpen() function, when defined, is automatically invoked whenever the
spreadsheet is opened.
For more information on using the Spreadsheet API, see
https://developers.google.com/apps-script/service_spreadsheet
*/
function onOpen() {
var sheet = SpreadsheetApp.getActiveSpreadsheet();
var entries = [{
name : "Read Data",
functionName : "readRows"
}];
sheet.addMenu("Script Center Menu", entries);
};

/====================================================================================================================================
ImportJSON by Trevor Lohrbeer (@FastFedora)
Version:      1.1
Project Page: http://blog.fastfedora.com/projects/import-json
Copyright:    (c) 2012 by Trevor Lohrbeer
License:      GNU General Public License, version 3 (GPL-3.0)
http://www.opensource.org/licenses/gpl-3.0.html
A library for importing JSON feeds into Google spreadsheets. Functions include:
 ImportJSON            For use by end users to import a JSON feed from a URL
 ImportJSONAdvanced    For use by script developers to easily extend the functionality of this library

Future enhancements may include:

Support for a real XPath like syntax similar to ImportXML for the query parameter
Support for OAuth authenticated APIs

Or feel free to write these and add on to the library yourself!
Changelog:
1.1    Added support for the noHeaders option
1.0    Initial release
====================================================================================================================================/
/**

Imports a JSON feed and returns the results to be inserted into a Google Spreadsheet. The JSON feed is flattened to create
a two-dimensional array. The first row contains the headers, with each column header indicating the path to that data in
the JSON feed. The remaining rows contain the data.

By default, data gets transformed so it looks more like a normal data import. Specifically:

Data from parent JSON elements gets inherited to their child elements, so rows representing child elements contain the values

 of the rows representing their parent elements.

Values longer than 256 characters get truncated.

Headers have slashes converted to spaces, common prefixes removed and the resulting text converted to title case.

To change this behavior, pass in one of these values in the options parameter:

noInherit:     Don't inherit values from parent elements
noTruncate:    Don't truncate values
rawHeaders:    Don't prettify headers
noHeaders:     Don't include headers, only the data
debugLocation: Prepend each value with the row & column it belongs in

For example:

=ImportJSON("http://gdata.youtube.com/feeds/api/standardfeeds/most_popular?v=2&alt=json", "/feed/entry/title,/feed/entry/content",

          "noInherit,noTruncate,rawHeaders")

@param {url} the URL to a public JSON feed
@param {query} a comma-separated lists of paths to import. Any path starting with one of these paths gets imported.
@param {options} a comma-separated list of options that alter processing of the data

@return a two-dimensional array containing the data, with the first row containing headers
@customfunction
**/
function ImportJSON(url, query, options) {
return ImportJSONAdvanced(url, query, options, includeXPath_, defaultTransform_);
}

/**

An advanced version of ImportJSON designed to be easily extended by a script. This version cannot be called from within a
spreadsheet.

Imports a JSON feed and returns the results to be inserted into a Google Spreadsheet. The JSON feed is flattened to create
a two-dimensional array. The first row contains the headers, with each column header indicating the path to that data in
the JSON feed. The remaining rows contain the data.

Use the include and transformation functions to determine what to include in the import and how to transform the data after it is
imported.

For example:

=ImportJSON("http://gdata.youtube.com/feeds/api/standardfeeds/most_popular?v=2&alt=json",

          "/feed/entry",

           function (query, path) { return path.indexOf(query) == 0; },

           function (data, row, column) { data[row][column] = data[row][column].toString().substr(0, 100); } )

In this example, the import function checks to see if the path to the data being imported starts with the query. The transform
function takes the data and truncates it. For more robust versions of these functions, see the internal code of this library.

@param {url}           the URL to a public JSON feed
@param {query}         the query passed to the include function
@param {options}       a comma-separated list of options that may alter processing of the data
@param {includeFunc}   a function with the signature func(query, path, options) that returns true if the data element at the given path

                   should be included or false otherwise.

@param {transformFunc} a function with the signature func(data, row, column, options) where data is a 2-dimensional array of the data

                   and row & column are the current row and column being processed. Any return value is ignored. Note that row 0

                   contains the headers for the data, so test for row==0 to process headers only.

@return a two-dimensional array containing the data, with the first row containing headers
**/
function ImportJSONAdvanced(url, query, options, includeFunc, transformFunc) {
var jsondata = UrlFetchApp.fetch(url);
var object   = JSON.parse(jsondata.getContentText());

return parseJSONObject_(object, query, options, includeFunc, transformFunc);
}
/**

Encodes the given value to use within a URL.

@param {value} the value to be encoded

@return the value encoded using URL percent-encoding
*/
function URLEncode(value) {
return encodeURIComponent(value.toString());
}

/**

Parses a JSON object and returns a two-dimensional array containing the data of that object.
*/
function parseJSONObject_(object, query, options, includeFunc, transformFunc) {
var headers = new Array();
var data    = new Array();

if (query && !Array.isArray(query) && query.toString().indexOf(",") != -1) {
query = query.toString().split(",");
}
if (options) {
options = options.toString().split(",");
}
parseData_(headers, data, "", 1, object, query, options, includeFunc);
parseHeaders_(headers, data);
transformData_(data, options, transformFunc);
return hasOption_(options, "noHeaders") ? (data.length > 1 ? data.slice(1) : new Array()) : data;
}
/**

Parses the data contained within the given value and inserts it into the data two-dimensional array starting at the rowIndex.
If the data is to be inserted into a new column, a new header is added to the headers array. The value can be an object,
array or scalar value.

If the value is an object, it's properties are iterated through and passed back into this function with the name of each
property extending the path. For instance, if the object contains the property "entry" and the path passed in was "/feed",
this function is called with the value of the entry property and the path "/feed/entry".

If the value is an array containing other arrays or objects, each element in the array is passed into this function with
the rowIndex incremeneted for each element.

If the value is an array containing only scalar values, those values are joined together and inserted into the data array as
a single value.

If the value is a scalar, the value is inserted directly into the data array.
*/
function parseData_(headers, data, path, rowIndex, value, query, options, includeFunc) {
var dataInserted = false;

if (isObject_(value)) {
for (key in value) {
if (parseData_(headers, data, path + "/" + key, rowIndex, value[key], query, options, includeFunc)) {
dataInserted = true;
}
}
} else if (Array.isArray(value) && isObjectArray_(value)) {
for (var i = 0; i < value.length; i++) {
if (parseData_(headers, data, path, rowIndex, value[i], query, options, includeFunc)) {
dataInserted = true;
rowIndex++;
}
}
} else if (!includeFunc || includeFunc(query, path, options)) {
// Handle arrays containing only scalar values
if (Array.isArray(value)) {
value = value.join();
}
// Insert new row if one doesn't already exist
if (!data[rowIndex]) {
  data[rowIndex] = new Array();
}

// Add a new header if one doesn't exist
if (!headers[path] && headers[path] != 0) {
  headers[path] = Object.keys(headers).length;
}

// Insert the data
data[rowIndex][headers[path]] = value;
dataInserted = true;

}
return dataInserted;
}
/**

Parses the headers array and inserts it into the first row of the data array.
*/
function parseHeaders_(headers, data) {
data[0] = new Array();

for (key in headers) {
data[0][headers[key]] = key;
}
}
/**

Applies the transform function for each element in the data array, going through each column of each row.
*/
function transformData_(data, options, transformFunc) {
for (var i = 0; i < data.length; i++) {
for (var j = 0; j < data[i].length; j++) {
transformFunc(data, i, j, options);
}
}
}

/**

Returns true if the given test value is an object; false otherwise.
*/
function isObject_(test) {
return Object.prototype.toString.call(test) === '[object Object]';
}

/**

Returns true if the given test value is an array containing at least one object; false otherwise.
*/
function isObjectArray_(test) {
for (var i = 0; i < test.length; i++) {
if (isObject_(test[i])) {
return true;
}
}

return false;
}
/**

Returns true if the given query applies to the given path.
*/
function includeXPath_(query, path, options) {
if (!query) {
return true;
} else if (Array.isArray(query)) {
for (var i = 0; i < query.length; i++) {
if (applyXPathRule_(query[i], path, options)) {
return true;
}
}
} else {
return applyXPathRule_(query, path, options);
}

return false;
};
/**

Returns true if the rule applies to the given path.
*/
function applyXPathRule_(rule, path, options) {
return path.indexOf(rule) == 0;
}

/**

By default, this function transforms the value at the given row & column so it looks more like a normal data import. Specifically:

Data from parent JSON elements gets inherited to their child elements, so rows representing child elements contain the values

of the rows representing their parent elements.

Values longer than 256 characters get truncated.

Values in row 0 (headers) have slashes converted to spaces, common prefixes removed and the resulting text converted to title

 case.

To change this behavior, pass in one of these values in the options parameter:

noInherit:     Don't inherit values from parent elements
noTruncate:    Don't truncate values
rawHeaders:    Don't prettify headers
debugLocation: Prepend each value with the row & column it belongs in
*/
function defaultTransform_(data, row, column, options) {
if (!data[row][column]) {
if (row < 2 || hasOption_(options, "noInherit")) {
data[row][column] = "";
} else {
data[row][column] = data[row-1][column];
}
}

if (!hasOption_(options, "rawHeaders") && row == 0) {
if (column == 0 && data[row].length > 1) {
removeCommonPrefixes_(data, row);
}
data[row][column] = toTitleCase_(data[row][column].toString().replace(/[\/\_]/g, " "));

}
if (!hasOption_(options, "noTruncate") && data[row][column]) {
data[row][column] = data[row][column].toString().substr(0, 256);
}
if (hasOption_(options, "debugLocation")) {
data[row][column] = "[" + row + "," + column + "]" + data[row][column];
}
}
/**

If all the values in the given row share the same prefix, remove that prefix.
*/
function removeCommonPrefixes_(data, row) {
var matchIndex = data[row][0].length;

for (var i = 1; i < data[row].length; i++) {
matchIndex = findEqualityEndpoint_(data[row][i-1], data[row][i], matchIndex);
if (matchIndex == 0) {
  return;
}

}
for (var i = 0; i < data[row].length; i++) {
data[row][i] = data[row][i].substring(matchIndex, data[row][i].length);
}
}
/**

Locates the index where the two strings values stop being equal, stopping automatically at the stopAt index.
*/
function findEqualityEndpoint_(string1, string2, stopAt) {
if (!string1 || !string2) {
return -1;
}

var maxEndpoint = Math.min(stopAt, string1.length, string2.length);
for (var i = 0; i < maxEndpoint; i++) {
if (string1.charAt(i) != string2.charAt(i)) {
return i;
}
}
return maxEndpoint;
}
/**

Converts the text to title case.
*/
function toTitleCase_(text) {
if (text == null) {
return null;
}

return text.replace(/\w\S*/g, function(word) { return word.charAt(0).toUpperCase() + word.substr(1).toLowerCase(); });
}
/**

Returns true if the given set of options contains the given option.
*/
function hasOption_(options, option) {
return options && options.indexOf(option) >= 0;
}

Not sure about how Google scripting works, but maybe this might be of help:
Google Apps Script to read JSON and write to sheet

Can you elaborate what specifically is to be done and can I work on this issue. Please correct me if wrong, here we have to write a script that could collect all the data from API's and store it in the end users own google sheets.

Yes. And this just got super-easy, now that https://api.covid19india.org/csv/ is live.
We just need to prepare a quick Google Script to fetch this csv and fill it in a Google Sheet.
And then later add this to documentation

Google script has parseCSV function to import data, which parses CSV data to an array of arrays. It is also possible to read parse JSON directly and write it to a sheets file.
Here is a script that will fetch data from the raw_data.json endpoint and write it to a google script. It can also be extended to use other endpoints. The function onOpen will create a menu item in the sheet, which can trigger the getData function.
To install paste the script in the script editor and assign the onOpen trigger to the onOpen function. Google will ask for authorization to execute the script.
There is a cleaner way to install this script as an addon. However, it's a fairly time-consuming task and unfortunately, I am unable to do it at the moment. Perhaps someone else can take it from here.
function getData(endpoint) {
  // Fetches data from api
  const response = UrlFetchApp.fetch("https://api.covid19india.org/"+endpoint+".json");
  const data = JSON.parse(response.getContentText())[endpoint];

  const sheet = SpreadsheetApp.getActive().getActiveSheet();

  // Prepare data for writing to spreadsheet
  const headerRow = Object.keys(data[0]);
  const rows = data.map(i => Object.keys(i).map(x => i[x]));

  // Writes data to active sheet
  sheet.getRange(1, 1,1,headerRow.length).setValues([headerRow])
  sheet.getRange(2,1, rows.length, rows[0].length).setValues(rows);
}

// TODO: add functions for all other endpoints
function getRawData() {
  getData("raw_data");
}

function onOpen(e) {
  SpreadsheetApp.getUi()
      .createMenu('COVID19INDIA')
  // TODO: add menu items for all other endpoints.
      .addItem('Raw Data', 'getRawData')
      .addToUi();
}

Oh this is nice. I will add this to docs.
By the way, realized earlier today that =IMPORTDATA(url) also works :|

Closing as irrelevant!


Typos

Is there an existing issue?

[X] I have searched the existing issues

Experiencing problems? Have you tried our Stack Exchange first?

[X] This is not a support question.

What browsers are you seeing the problem on?
Firefox
Bug report for the website

Typos at https://docs.substrate.io/tutorials/get-started/simulate-network/
Steps to reproduce the problem
No response

@cxphong why not file a PR to change this file? The linknis at the top right of every page btw


Problems with enableStrictParsing option

Hi, the YII team.
I've tried to implement simple restful api. The rest tutorial describe how need to setup url manager, this is my config:
'urlManager' => [
    'enablePrettyUrl' => true,
    'showScriptName' => false,
    'enableStrictParsing' => true,
    'rules' => [
        ['class' => 'yii\rest\UrlRule', 'controller' => 'user', 'extraPatterns' => [
            'GET test' => 'test'
        ]]
    ]
],

In this case api works fine. But when I try to open page like this yii2.basic/site/contact - I get 404 error (but action already exists). If disable in config 'enableStrictParsing' => false - the api and web controllers actions works fine.
This is a bug or maybe I missed something?

What is the main motive to set enableStrictParsing for UrlManager into true?
For what user cases?


when shutting down envelope, it says: POSTAGE IS SHUTTING DOWN

methinks it should say ENVELOPE IS SHUTTING DOWN.

@justintocci, sorry, I was not aware there was the "reserved-for-first-time-contributors" label on this issue.
I did not receive an email stating that the label was added, I did get an email saying you assigned me.


Add basic UI

Adding two files:

Main: A simple way to run the app.
App: The interface and mastermind of all operations.

It wasn't easy, there were a lot of errors to fix, but it is now done, thanks :handshake:

Thanks for letting me know about the license and the approval! :tada:


Don't pull the server unless we are on error mode

We now detect the error mode using the Websocket connection closing instead of pulling the server regularly.
(Didn’t write the corresponding line in the Changelog to avoid merge conflict with #12).

Makes sense! Thanks again!

Released 1.5.0 with this.


Cannot export the variance report for the fiscal year March 2024- April 2025

Scenario:

Navigate to the A&R on TEST environment: https://d3ahrzu0mpndj3.cloudfront.net/export-reports
Navigate to the export report page and then select the tab to export the Variance report.
Try to export the report for the fiscal year March 2024-April 2025 to check the variances for the current month August 2024.

Expected:

users can export a variance report for past years and current fiscal year (even if we are only part way through current fiscal year)
users cannot export a variance report for fiscal years that have not yet started

Issue:

The Variance export doesn't give the option to pick the current fiscal year to export the report.

@manuji this is ready for review!

Testing blocked as the exported report does not show for the Variance tab @davidclaveau

@manuji this fix is in DEV now!

Tested on TEST: Passed

Verified that this issue has been fixed.
Moving to Done