Minor: initial value is not selected when binding radio buttons to objects

[x] bug
[ ] feature request
[ ] enhancement

Expected behavior
Dynamically generated radio groups that are bound to an object with [(ngModel)] should show an initial selection is the object is a valid selection.
Actual behavior
No initial selection is shown, but otherwise everything else works -- clicking a radio button selects a option and correctly changes the object.
Reproduction of behavior
I was unable to recreate this in the new plunker (attempt here) due to what I think is an unrelated issue with the plunker, but a example can be seen here (code here).
Environment details

Angular version: 2.1.0

Clarity version: 0.7.0, also tested on 0.7.2

OS and version: Win 8.1 x64

Browser: all

@youdz could you provide your input here?

This is the expected behavior in Angular 2: ngModel on radios uses reference equality to test if a radio button is currently selected.
You can see this easily in your example by replacing:
private activeTurtle = Object.assign({}, this.data.Turtles[0]);

by
private activeTurtle = this.data.Turtles[0];

at line 26. The radio is correctly initially selected.
As a side note, setting this field to private is an error if you're using it in the template. Templates are different objects from the controller, so they need to only access public properties of said controller. This should be instantly visible if your try to AOT-compile this, it'll raise a Typescript error.

Thanks for the clarification @youdz!


Added fingerprint for 2020 Nissan Leaf SV Plus

Added fingerprint for 2020 Nissan Leaf SV Plus

Can you merge it into the existing fingerprint?

It's not clear what you're asking.

There are now two dictionaries with fingerprints for the LEAF. Can you merge them into one dictionary that contains the values of both of them?

That's not the convention I see in other files.  I am going to keep them separate for clarity.

Not all cars do this properly, but merging them creates a fingerprint that is compatible with more different cars. Please combine the two fingerprints and I'll merge the PR.

Can you also add the 2020 leaf to the readme?

Did all requested changes in https://github.com/commaai/openpilot/pull/2311. Closing this pull request.


Timestamp is not available for interrupts

Linux kernel provides timestamps for each GPIO event but it is not available in RPPAL API. It is stored in the gpio::ioctl::Event struct but is discarded and not returned in the InputPin API.
Measuring these timestamps manually using std::time introduces imprecision because of context switches.

Thanks for pointing this out! While the timestamp provided by the GPIO driver also isn't accurate, it will still be more precise than measuring timestamps yourself, so I agree it's a good idea to return both the logic level and timestamp. I'll add it to the to-do list.

I've looked a bit into the situation, and things do not look straightforward yet.
I've noticed that the ioctrl::v1::Event (as well as unused yet ioctl::v2::Event) structures does store events' timestamps, but wrap them in std::time::Duration type. This looks almost ready.
However, passing a Duration to the callbacks would create a weird, IMO incorrect API. At least as far as Rust'y time handling style goes:

using Instant type to represent moments in time,

using Duration for representing time intervals.

Ideally, the callback signature should be FnMut(Level, std::time:Instant).

But using std::time::Instant would be only a valid here, if:
a) there is a hard guarantee that the nanosecond count reported by the Linux Kernel for each interrupt event always comes and always will come from the very same clock source that the Unix variant of std::time::Instant happens to use.
If not (now or at any point in the future), a potential comparisons of Instant from interrupt callback with ones obtained using other means, would create incorrect intervals ans super hard to find bugs. I think the assumption a) cannot be safely taken for granted.
Also, the std:time::Instant struct is super opaque and I've found no way to simply construct it from a custom time value of offset from the UNIX epoch etc.
A possible workaround for the two issues above could be to provide own (that is implemented here) rppal::time::Instant type. It would internally store the low-level interrupt event timestamps as u64-typed number of nanoseconds, and could supports similar convenience methods from std::time::Instant, like elapsed, duration_since as well as arithmetic traits (Add, Sub etc) involving Instant and Duration types.
A custom Instant type is something Tokio library did. For different reasons, but just pointing this out here. In my view, the idea of a new type where timestamping info is prevented from being confused of incorrectly mixed with others, may require few lines of code more, but is not as crazy IMO as it may first sound.

Timestamps are available as part of the upcoming 0.19.0 release.


parse markdown in contenteditable

Often in contentediable based editors the controls offered are too limited or are annoying to use, so a method to type in them using markdown would be very useful. If the text typed in Atom was run through a  markdown to html converter before being sent to a contentediable that would be very convenient. Is this possible as a setting?
Thanks,
Daniel

Hi, thank you for the suggestion.
The feature has already beek asked in #4.
It is possible, but not as trivial as it seems:
because as the text is synchonized, we need
to have something that converts both ways without loosing information (as much as markdown allows us to).
I started a bit the work in https://github.com/tuvistavie/meditable, but did not really have the time to work on it recently, so help is very welcome.
As This issue is basically the same as #4, I will close here.
Thank you!


Cupertino route back gesture width

Use case
Cupernito back gesture width is hardcoded in cupertino/route.dart file in _kBackGestureWidth constant.
Proposal
It would be nice to have a possibility to override the back gesture width value.

Closing as duplicate of https://github.com/flutter/flutter/issues/46598. Please upvote it and follow-up in it for further updates.


Tomcat 7 & openSUSE

The cookbook does not use correct package names (and directories, etc.) for the openSUSE platform.

closed by #166


Message Sequence Non-conformance Issue

Description

Type: Non-conformance Bug
Priority: Minor

Non-conformance Bug
mbed TLS build:
Version: MbedTLS 2.22.0
Expected behavior
The DTLS RFC specifies the following requirement regarding the message sequence number:

The first message each side transmits in each handshake always has message_seq = 0.  Whenever each new message is generated, the message_seq value is incremented by one.

Actual behavior
However, Our tests show that the mentioned version does not comply with the RFC and you can complete a handshake with the following values for the message_sequence:
CH0.message_seq: 1
HVR.message_seq: 1
CH2.message_seq: 2
SH.message_seq: 2
SHD.message_seq: 3
CKE.message_seq: 3
Clearly, in both cases of the client and the server, the message sequence has not started with 0. I have attached a handshake trace (PCAP) that shows the mentioned non-conformance issue.
mbedtls_invalid_mseq.zip

Could you clarify whether the problem is that Mbed TLS is accepting manifestly incorrect sequence numbers in incoming messages, or that Mbed TLS is sending incorrect sequence numbers? Is Mbed TLS the client, the server or both?

Could you share steps to reproduce? I ran a sample DTLS handshake with Mbed TLS client and server and see the sequence number starting at 0.
As for the server replying with sequence number 1 in the HVR to a ClientHello with sequence number 1, this is standards-compliant. Quoting Section 4.2.1 of the DTLS RFC:

When responding to a HelloVerifyRequest, the client MUST use the same
parameter values (version, random, session_id, cipher_suites,
compression_method) as it did in the original ClientHello.  The
server SHOULD use those values to generate its cookie and verify that
they are correct upon cookie receipt.  The server MUST use the same
version number in the HelloVerifyRequest that it would use when
sending a ServerHello.  Upon receipt of the ServerHello, the client
MUST verify that the server version values match.  In order to avoid
sequence number duplication in case of multiple HelloVerifyRequests,
the server MUST use the record sequence number in the ClientHello as
the record sequence number in the HelloVerifyRequest.

Could you clarify whether the problem is that Mbed TLS is accepting manifestly incorrect sequence numbers in incoming messages, or that Mbed TLS is sending incorrect sequence numbers? Is Mbed TLS the client, the server or both?

The problem is that the MbedTLS Server accepts a client_hello whose message_sequence is not 0 and it is a violation of the mentioned requirement. I will provide a reproduce script shortly.

Could you share steps to reproduce? I ran a sample DTLS handshake with Mbed TLS client and server and see the sequence number starting at 0.
As for the server replying with sequence number 1 in the HVR to a ClientHello with sequence number 1, this is standards-compliant. Quoting Section 4.2.1 of the DTLS RFC:

When responding to a HelloVerifyRequest, the client MUST use the same
parameter values (version, random, session_id, cipher_suites,
compression_method) as it did in the original ClientHello.  The
server SHOULD use those values to generate its cookie and verify that
they are correct upon cookie receipt.  The server MUST use the same
version number in the HelloVerifyRequest that it would use when
sending a ServerHello.  Upon receipt of the ServerHello, the client
MUST verify that the server version values match.  In order to avoid
sequence number duplication in case of multiple HelloVerifyRequests,
the server MUST use the record sequence number in the ClientHello as
the record sequence number in the HelloVerifyRequest.

The mentioned requirement in Section 4.2.1 is about the record_sequence_number. The mentioned non-conformance issue is affecting the message_sequence.

MbedTLS allows a ClientHello with invalid message sequence numbers to restart the handshake in the middle of a current one.

This would raise the severity from non-conformance to a potential denial-of-service from an adversary that can inject but not suppress packets, right?

The scenarios I have given are ones where the restarting ClientHello contains the cookie the server generates via HelloVerifyRequest. An attacker that somehow manages to sniff this cookie/predict it, can indeed cause denial of service, unless the cookie also authenticates the IP address. However, based on the below quote, the RFC only appears to only use the cookie exchange as DoS prevention mechanism for when getting the cookie is not possible.

This mechanism forces the attacker/client to be able
to receive the cookie, which makes DoS attacks with spoofed IP
addresses difficult.  This mechanism does not provide any defense
against DoS attacks mounted from valid IP addresses.

I opened a similar issue for Scandium, which exhibited similar behavior. From the discussions I had there, it appears the DTLS 1.2 RFC may provide some ground for accepting ClientHello messages with increased message sequence numbers based on the quote:

If a server receives a ClientHello with an invalid cookie, it SHOULD
treat it the same as a ClientHello with no cookie. This avoids
race/deadlock conditions if the client somehow gets a bad cookie
(e.g., because the server changes its cookie signing key).

Note to implementors: This may result in clients receiving multiple
HelloVerifyRequest messages with different cookies. Clients SHOULD
handle this by sending a new ClientHello with a cookie in response to
the new HelloVerifyRequest.

The above paragraphs make it possible for the server to receive ClientHello messages with increased message_seq even in conforming cases. This happens in the (albeit unlikely) event that the server, having recently updated its secret, receives a ClientHello with an old cookie, to which it responds by a HelloVerifyRequest with a new cookie. The client will then produce a new ClientHello which carries this new cookie, but has an incremented message_seq relative to the old ClientHello. The server should be able to accept this new ClientHello.
Based on these paragraphs, as long as the behavior is intended, I think the issue can be closed.
A funny thing is  that @hanno-arm  is actually correct though not based on the quote he gives, but the errata fix to that quote which replaces record sequence numbers by message sequence numbers. The server setting the message_seq of HelloVerifyRequest to that of ClientHello is essential for the corner case described earlier (if it did not replay the message_seq, and only generated HelloVerifyRequest with message_seq 0, the client would discard subsequent HelloVerifyRequest messages which may contain updated cookies).


Clarify polyfill dependency

I was initially confused by the existing language, thinking I needed the polyfill any time I used babel-register. This attempts to clarify things, based on my rudimentary understanding.

Thanks :+1:


Fix safety bugs

This fixes a couple of safety bugs:

Set proper mutability for various methods
Add lifetime to Extractor, otherwise Net can be dropped while Extractor is still in use
Consume Extractor within extract method as Extractor can only be used once

Thanks to your contributions !


npm task & Azure DevOps Artifacts - Issues with npm ci

Required Information
Entering this information will route you directly to the right team and expedite traction.
Question, Bug, or Feature?
Type: Bug
Enter Task Name: NpmV1
Environment
Azure DevOps, hosted Agent
Account Name: balluffsmartreorderingsystem
Team Project: SRS
Build Definition: srs-frontend (BuildID 459 / "#srs-frontend_merge_20210210.2 Minor visual bugfixes")
Issue Description
I'm currently experiencing a lot of issues while running npm ci during a build. I use Azure DevOps Artifacts with https://registry.npmjs.org/ as an upstream source as my package feed.
 Extracting by manifest.
11505 verbose teardown shutting down workers.
11506 info teardown Done in 0s
11507 verbose stack SyntaxError: Unexpected end of JSON input while parsing near '...-eslint/eslint-plugin'
11507 verbose stack     at JSON.parse (<anonymous>)
11507 verbose stack     at parseJson (/opt/hostedtoolcache/node/12.20.1/x64/lib/node_modules/npm/node_modules/json-parse-better-errors/index.js:7:17)
11507 verbose stack     at /opt/hostedtoolcache/node/12.20.1/x64/lib/node_modules/npm/node_modules/node-fetch-npm/src/body.js:96:50
11507 verbose stack     at runMicrotasks (<anonymous>)
11507 verbose stack     at processTicksAndRejections (internal/process/task_queues.js:97:5)
11508 verbose cwd /home/vsts/work/1/s
11509 verbose Linux 5.4.0-1039-azure
11510 verbose argv "/opt/hostedtoolcache/node/12.20.1/x64/bin/node" "/opt/hostedtoolcache/node/12.20.1/x64/bin/npm" "ci"
11511 verbose node v12.20.1
11512 verbose npm  v6.14.10
11513 error Unexpected end of JSON input while parsing near '...-eslint/eslint-plugin'
11514 verbose exit [ 1, true ]

I've also attached the complete log of the npm ci command.
npm-ci-log-complete.txt

We are also finding that the Azure Artifacts registry for NPM whether for our own packages published from Azure Pipelines or mirrored public ones are completely missing the sha-512 hashes, only the "shasum" field is present. It looks like the
"integrity":"sha512-WD53jhgDQmtx/z1hbr2WB+i1f9oAgi9gXeerC6xwRynAP1Xh8W2KM8JCyZ3PslGX3zc9/w3Ic/m+hp1myBJ0jQ==",
which should be before it Is being stripped completely.
https://developercommunity.visualstudio.com/content/problem/957522/npm-packages-from-azure-artifact-defaulting-to-sha.html

Same here,
what we setup npm task to:
- task<EMAIL_ADDRESS>inputs:
command: 'install'
customRegistry: 'useFeed'
customFeed: 'XXXXXXXXXXXXXXXXXX'

Same here...

Hello,
I'm with the same problem, randomly that error appears.
Any suggestion to solve it?

Hi Microsoft
When this issue will be fixed

Not currently using Azure DevOps Artifacts but this still seems to be an issue

Chiming in that this is still an issue

It's still an issue. The thread I previously mentioned still hasn't had any useful response. Quite unbelievable.
If you're intentionally saving compute time by not having sha512 in azure artifact feeds for npm, just say so.


Add a capacity to the room details modal

Add a capacity to the room details modal

Completed by @a-drew in #570


Linux Releases for Python: Update build process to use manylinux_2_28 instead of manylinux2014

The docker image quay.io/pypa/manylinux2014_x86_64 has reached EOL on June 30th, 2024 [See pypa/manylinux].
Further, I expect that the new image manylinux_2_28 will fix the currently broken build process due to the outdated glibc on manylinux2014.
Background info on Github Actions and "manylinux":

Github Actions, such as actions/checkout have requirements on the target system, such as a recent glibc and libstdc++ (actions/checkout and other actions apparently use a dynamically linked Node LTS version)
The docker image manylinux2014_x86_64, which is currently used to build the static Linux releases, has an outdated glibc (on purpose -- The idea is to target a version that works on many Linux distributions, because glibc is downwards compatible) and other outdated system libraries, such as libstdc++.
Hext's Linux releases for python are built with current versions of Github Actions, which now fails.

This is fixed. Hext for Python now requires Glibc version ≥2.28 which was released in August of 2018.


Palette not pallette

In Example 2, the variable $themepallette (two L's) is used which doesn't match the $themepalette used further up, and is an incorrect spelling of the word palette.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: a99ae6ea-f1ca-1d6f-bdda-abc8cf4082ae
Version Independent ID: 066c87bc-6767-ae13-7f31-d9591f7e0536
Content: schema: 2.0.0
Content Source: sharepoint/sharepoint-ps/sharepoint-online/Add-SPOTheme.md
Service: sharepoint-powershell
GitHub Login: @Techwriter40
Microsoft Alias: kirks

Fixed with #1375.


Add Jekyll Build Github Actions Check and Remove Old DCO Checks

Hi,
The old dco check for the PR is not needed any more as it is replace by the DCO app.

We can also add proper jekyll testing.
At start we can just add a jekyll build run to ensure at least everything can be built before failing the staging pipeline.
I will send a PR on this soon.
Thanks.

PR:

https://github.com/opensearch-project/project-website/pull/1095


ClientIP in TCP route does not seem to work

Welcome!

[X] Yes, I've searched similar issues on GitHub and didn't find any.
[X] Yes, I've searched similar issues on the Traefik community forum and didn't find any.

What did you do?
Declared a route like this
apiVersion: traefik.containo.us/v1alpha1
kind: IngressRouteTCP
metadata:
  name: mariadb
spec:
  entryPoints:
    - mariadb
  routes:
    - match: ClientIP(`<IP_ADDRESS>/0`)
      services:
        - name: mariadb
          port: mariadb

So it appears green in traefik dashboard. Then curl it
What did you see instead?
My understanding is that TCP route should forward request to mariadb but instead it falls back to http like it did not find a match. MariaDB does not support SNI, so I need plain TCP
What version of Traefik are you using?
2.8.8
What is your environment & configuration?
      "--entrypoints.mariadb",
      "--entrypoints.mariadb.address=:3306"

If applicable, please paste the log output in DEBUG level
No response

Hello @vladimirtiukhtin ,
Could you please enable logging at the DEBUG level, and share the resulting logs?
Also, have you tried with a more specific address instead of <IP_ADDRESS>/0 , and do you observe the same behaviour in that case?


Check port forwarding during onboarding

@veaceslavdoina Could you please provide me with some quick guidelines on this ?

I would refer to the existing discussion - https://github.com/codex-storage/codex-testnet-starter/issues/25, and we already considered to implement that on AWS Lambda(+CloudFront/API Gateway) or Cloudflare Workers.
We can probably do a quick check how echoip is working.

I added a check for the persistence during the onboarding :


QuizzEngine - Refactor data model to remove right answer

In the current model, there are four answer and there is a number to identify the right answer.
This cause the data model to be tight to the expected use of the question (a trivial question).
The new proposal is to get rid of the right answer number and the first answer will be always the right one. When the answer are going to be shown in the client it would be better shuffle.

Done.
Commit: https://github.com/ProfesorDiegoRosado/quizzies/commit/39dd52861b4165be28ebf5afaba19456498d06bd


Database design and resources for gathering data.

Hello Everyone,
I think first of all we shall decide our requirements i.e which data we are going to need and later how we want to access the stored data in Greennav. How we are going to frame REST framework for providing access to database service from Routing Service. I think our priority should be designing a data model first later we can discuss REST framework part. :smile:
Resources for gathering data:

http://openweathermap.org/current

https://developers.google.com/maps/documentation/elevation/intro

https://www.doi.gov/developer

http://www.programmableweb.com/news/top-10-mapping-apis-google-maps-microsoft-bing-maps-and-mapquest/analysis/2015/02/23

https://wiki.earthdata.nasa.gov/display/GIBS/GIBS+API+for+Developers

http://code.tutsplus.com/tutorials/an-introduction-to-the-geolocation-api--cms-20071

https://developers.google.com/maps/documentation/directions/

https://developers.google.com/maps/documentation/distance-matrix/

https://developers.google.com/places/web-service/

https://developers.google.com/maps/documentation/timezone/intro

https://developers.google.com/maps/documentation/geolocation/intro

https://developers.google.com/maps/documentation/geocoding/intro

https://search.earthdata.nasa.gov/

OSM integration POC works


don't use numbered history expansion for fzf-history-widget

fzf already returns the command itself, deleting it and using history expansion seems silly. this is much simpler.

Thanks, but please see #142, #214


Plot starts at zero on left side

When I create a graph there is a straight line drawn from the left most visible data point to a point at zero right outside the bounds of the view. The right side is fine with no issues. Anyone else seing this issue too? See screenshots for three examples.

yes. it actually starts with zero for any sequence of values. sorry, i don't actually remember how i resolved it, but u should look at leftMostPointPadding and other offsets

It's because of the fill. Try it with plot.shouldFill = false - you will lose the color under your graph, but it will fix that particular issue. I just figured this out myself a few minutes ago.

As @jeffreality has stated, this is occurring because of the fill underneath the line. This was made as a design decision as for what I needed it looked slightly better.
We would need to change the way the path is generated depending on some property. For example, instead of extending the path down to "zero" at the start, we would want to draw the path straight down. See the image as an example:

The current workaround is to not fill the graph.


Auto Scaling Queries

I have couple of queries in AWS Auto Scaling.

While we create launch configuration, minimum instances I have selected is 2 (lets suppose). Now after all creation, 2 instances are created. I have applied auto scaling rules as well (CPU > 60% increase, CPU <10% decrease by 1. I have 3 questions on this.

(a) Suppose I deleted or terminated one instance, the minimum instances defined in Launch Configuration is 2, hence automatically a new instance should be created since the minimum instances is 2. But when I tried, it does not create a new instance.
(b) Due to auto scaling conditions (CPU > 60%) a new instance was created this week and suppose next week the instance gets terminated due to scale down condition (CPU < 10) met. So, now while termination of instance automatically, what happens to data??
(c) I have created a Launch Configuration, and applied Auto scaling with min 2 instances. I haven't installed any app or service. So the CPU remains less than 5% always. But the instances does not gets decremented or terminated even though it meets Scale Down condition (CPU < 10%). So, my question in any case, the minimum instances (2 in this case) will not be disturbed or destroyed. Is that true?

As sanjay suggested it should show the history. As it would create the machine when the instance is out of service & health checks have failed. It depends on the health check timings


Refactor Document list test file to new format

What is the context of this PR?
46
Refactored the document list macro.spec file as per the new format.
How to review this PR
Ask yourself....

Do we need any additional tests?
Are the tests descriptions clear?
Does the order of the test document make sense?
Is it internally consistent?
Is it consistent with the guidelines for test refactoring?

run this test command to view the test results:
yarn test --testNamePattern="FOR: Macro: Document list"
Checklist
This needs to be completed by the person raising the PR.

[x] I have selected the correct Assignee
[x] I have linked the correct Issue

Can you just have a double check that all params that can be set have a test that tests their functionality. You can use the _macro-options.md file for a list

Can you just have a double check that all params that can be set have a test that tests their functionality. You can use the _macro-options.md file for a list

Have gone through the documentation and added few tests. I think all params are being covered now.

Can you just have a double check that all params that can be set have a test that tests their functionality. You can use the _macro-options.md file for a list

Have gone through the documentation and added few tests. I think all params are being covered now.

There are still some tests missing, I started going through them and noticed attributes isn't covered and classes is covered at the top level but not at the document level. I haven't investigated any further so can you have another look through them and make sure there aren't others that have been missed


Use SortShuffleManager instance in ColumnarShuffleManager

What changes were proposed in this pull request?
This PR makes a change to introduce an object of SortShuffleManager in ColumnarShuffleManager to reduce code overlap.
How was this patch tested?
SortShuffleManagerSuite has already been enabled against ColumnarShuffleManager.

/Benchmark Velox

===== Performance report for TPCH SF2000 with Velox backend, for reference only ====

query
log/native_6022_time.csv
log/native_master_06_07_2024_85e8619f12_time.csv
difference
percentage

q1
34.16
34.74
0.584
101.71%

q2
24.59
23.82
-0.776
96.84%

q3
36.75
37.27
0.519
101.41%

q4
33.86
30.13
-3.731
88.98%

q5
69.01
70.45
1.446
102.10%

q6
7.55
7.45
-0.101
98.66%

q7
81.89
83.57
1.676
102.05%

q8
87.32
86.74
-0.576
99.34%

q9
121.00
121.95
0.949
100.78%

q10
45.90
45.15
-0.754
98.36%

q11
23.86
19.51
-4.357
81.74%

q12
26.61
26.76
0.152
100.57%

q13
37.99
39.39
1.408
103.71%

q14
21.04
20.54
-0.499
97.63%

q15
31.63
31.52
-0.105
99.67%

q16
12.95
13.65
0.703
105.43%

q17
104.35
103.56
-0.797
99.24%

q18
144.05
145.21
1.157
100.80%

q19
14.83
14.70
-0.137
99.08%

q20
26.64
28.92
2.279
108.56%

q21
257.09
262.04
4.950
101.93%

q22
13.05
14.56
1.506
111.54%

total
1256.13
1261.63
5.497
100.44%

@marin-ma can you please review this? Thank you!

@rui-mo can you too please review this? Thanks!

@ulysses-you can you please review again? Thank you!

shall we call unregisterShuffle and stop if it is delegated to sort shuffle manager ?

shall we call unregisterShuffle and stop if it is delegated to sort shuffle manager ? e.g.,
if (taskIdMapsForShuffle.contains(shuffleId)) {
  this.stop
} else {
  delegated.stop
}

Updated unregisterShuffle and stop to this pattern.

Thank you @ulysses-you for the comments! Updated the PR.

@ulysses-you Thanks for review!
@acvictor Could you help to add a UT to test the fallback behavior for columnar shuffle? Perhaps, add one test case in FallbackSuite.scala and set spark.gluten.sql.columnar.shuffle=false force the Exchange operator to fall back

@marin-ma added a test.

===== Performance report for TPCH SF2000 with Velox backend, for reference only ====

query
log/native_6022_time.csv
log/native_master_06_12_2024_7445f02c9_time.csv
difference
percentage

q1
35.67
33.87
-1.796
94.96%

q2
23.60
26.51
2.905
112.31%

q3
36.84
36.94
0.106
100.29%

q4
32.41
34.65
2.244
106.93%

q5
70.83
69.47
-1.358
98.08%

q6
7.61
5.84
-1.772
76.72%

q7
84.08
82.18
-1.901
97.74%

q8
83.77
85.19
1.414
101.69%

q9
118.64
120.19
1.543
101.30%

q10
44.72
43.54
-1.180
97.36%

q11
22.67
20.47
-2.197
90.31%

q12
26.37
24.09
-2.280
91.35%

q13
37.56
37.22
-0.342
99.09%

q14
19.24
23.00
3.754
119.51%

q15
30.13
30.20
0.073
100.24%

q16
13.74
13.79
0.047
100.34%

q17
103.62
102.85
-0.770
99.26%

q18
143.92
145.02
1.098
100.76%

q19
13.62
16.14
2.518
118.49%

q20
29.19
27.34
-1.848
93.67%

q21
262.53
263.30
0.765
100.29%

q22
12.33
12.08
-0.247
98.00%

total
1253.09
1253.86
0.775
100.06%


Chest's and bed's texture issue

When you try to break chest or bed, the purple-black paricles appear

I’d assume this is an issue with Enhanced Block Entities. Are you on Fabric or Quilt, and what Minecraft version are you running?
Can you try disabling Enhanced Block Entities and see if the issue persists?

Its on quilt, version is 1.20.1, i disabled this mod and now everthing is fine

Looks like this is an open issue at https://github.com/FoundationGames/EnhancedBlockEntities/issues/158.


Extra & being added to XML files

Please help to fix a problem introduced since the original brut version of apktool: http://code.google.com/p/android-apktool/issues/detail?id=101
In addition to the "& a m p;" being decoded as "& a m p ; a m p ;"  problem, " & l t;" also being decoded as "& a m p ; l t". (sorry for the addtional white spaces)
Please take care of it. Thank you.

fixed at some point in v2.0 development.


OmniSharp not Autofilling for Unity Scripts

Issue Description
Intellisense isn't working. Visual Studio Code gives an error saying OmniSharp server is not running
Steps to Reproduce
Expected Behavior
Actual Behavior
Logs
OmniSharp log

C# log

Environment information
VSCode version: 1.59.0
C# Extension: 1.23.14
Dotnet Information
.NET SDK (reflecting any global.json):
 Version:   5.0.400
 Commit:    d61950f9bf
Runtime Environment:
OS Name:     Windows
OS Version:  10.0.19043
OS Platform: Windows
RID:         win10-x64
Base Path:   C:\Program Files\dotnet\sdk\5.0.400\
Host (useful for support):
Version: 5.0.9
Commit:  208e377a53
.NET SDKs installed:
5.0.400 [C:\Program Files\dotnet\sdk]
.NET runtimes installed:
Microsoft.AspNetCore.App 3.1.10 [C:\Program Files\dotnet\shared\Microsoft.AspNetCore.App]
Microsoft.AspNetCore.App 5.0.9 [C:\Program Files\dotnet\shared\Microsoft.AspNetCore.App]
Microsoft.NETCore.App 3.1.10 [C:\Program Files\dotnet\shared\Microsoft.NETCore.App]
Microsoft.NETCore.App 5.0.9 [C:\Program Files\dotnet\shared\Microsoft.NETCore.App]
Microsoft.WindowsDesktop.App 5.0.9 [C:\Program Files\dotnet\shared\Microsoft.WindowsDesktop.App]
To install additional .NET runtimes or SDKs:
https://aka.ms/dotnet-download

Visual Studio Code Extensions

Extension
Author
Version

csharp
ms-dotnettools
1.23.14

It doesn't look like you posted any logs. Please make sure to collect them and include them in the bug, otherwise we can't offer any help.

Closing due to lack of response. It is now recommended to use the Unity extension for VS Code.


envelope not working correctly in chrome

attack is instant every time

adsrStart is called twice in Heartbeat GM

probably curr not set in adsrStart

weird chrome bug in hb.makeGain. Probably fixed now.


custom converter priority

I think custom converter should be applied priority.
What do you think?

Can you please explain your intention and also attach a test that would fail before your suggested PR?

This has actually been fixed as part of https://github.com/spring-cloud/spring-cloud-stream/issues/1851


Baseline validation

Add baseline Validation for ARCs in case no specific validation package is referenced

@kMutagene Check this out please! I am happy do change anything you say needs a rework.

Hey @kMutagene,
please review the changes made and let me know if they are ok.
I noticed that the way I referenced a file in the tests seem to fail in linux but seems to work in the windows tests. If you let me know what I need to change to fix this I will do it asap.

@LibraChris please double check that path that fails in ci. Something like that failing on linux but passing on windows often means that there is a lowercase/uppercase mistake in the path.

@LibraChris please double check that path that fails in ci. Something like that failing on linux but passing on windows often means that there is a lowercase/uppercase mistake in the path.

You aer 100% correct. But strange that it worked on Mac.

Hey @kMutagene , I addressed the changes you requested. Let me know if it looks good.

@kMutagene How about now?


feat: devops stats support

Support of:

Jenkins
CircleCI
GitLab CI
Github Workflow Actions
TravisCI
Kubernetes
Docker
Drone CI

Please, ping me in related PR in libraries repo.

@anatolystansler this one


Serializing empty lists

Thanks again for this great tool!
I noticed that the serializer treats empty lists the same as unassigned ones (containing null). In both cases, null is written to the property at desirialization.
Is this an intended behavior?
Is it possible to change this behavior by adjusting the configuration?

This fix has been deployed to NuGet:
https://www.nuget.org/packages/ExtendedXmlSerializer/
If you encounter any further issues please open a new issue and we'll take it from there.  Closing this for now.

I've only just managed to test your changes. But they work perfectly as expected! Thanks again!

Woohoo... glad to hear @imperiobadgo.  Thank you for the confirmation. 👍


Locking problem

I've been encountering a problem with our (reverse proxy) nginx servers that they have been crashing. They stop responding to requests completely, and don't seem to come out of this state by themselves. These servers deal with a highish volume of requests (>5million a day).
For the past few days I've been at a bit of a loss, and restarting the Docker instance manually whenever I was alerted to this by monitoring, but I decided to put a helper cron script in place that would check if nginx was still responding and restart it via supervisord if there was an issue.
Due to the fact initially I was restarting the Docker container, I wasn't really getting any form of debugging information -- the logging would just stop. However after changing this to instead restart nginx inside the container I have the following in the logs:
2017/02/01 01:14:16 [alert] 489#0: worker process 501 exited on signal 9
2017/02/01 01:14:16 [alert] 489#0: shared memory zone "auto_ssl" was locked by 501
2017/02/01 01:14:16 [alert] 489#0: worker process 502 exited on signal 9

I had around on Google and the only reference I can find is https://github.com/18F/api.data.gov/issues/325 -- however it looks like expirations were put into place, this doesn't seem to be working on our setup, as we (due to bad monitoring) ended up with about a 7 hour downtime recently.
I should mention I cannot recreate this bug at all locally, even using the same Docker container.
I'm at a bit of a loss, our automatic restart script has sorted out the issues for now but it would be nice to see if anyone has ideas. I'd be happy to turn on extra logging and attempting the debug log (I've been a bit scared to turn it on in our production servers).

Owch, sorry to hear this led to an outage!
I unfortunately haven't seen anything like this in our installation that gets a decent amount of traffic (since the incident from last March you referred to). However, there was another somewhat similar issue like this reported in #29, where we fixed an issue that might have been related, but it may not have totally explained the issue. But that issue may also not be related (it was specific to when registrations occurred).
Thanks for the offer to help debug this, though, it would definitely be good to get to the bottom of. I have a few initial questions:

What version of lua-resty-auto-ssl are you running?
Are you running OpenResty or nginx with the lua module manually installed?
What versions of OpenResty or nginx+lua are you running?
What storage mechanism are you using with lua-resty-auto-ssl (Redis, filesystem, something else)?
How frequently do things hang? Does it seem to only happen when new certs are being registered or renewals are taking place, or is it seemingly random?
Are you reloading nginx at all (sending a SIGHUP to the master process and spawning new workers instead of fully restarting the master process)?
How many nginx workers do you have running (worker_processes setting in nginx config)?
Do you have any other nginx plugins installed (beyond the ones that come with OpenResty by default if you're on OpenResty)?

lua-resty-auto-ssl is 0.10.3-1 from luarocks
We're using OpenResty <IP_ADDRESS>.
nginx version: openresty/<IP_ADDRESS>
built by gcc 4.8.5 20150623 (Red Hat 4.8.5-11) (GCC)
built with OpenSSL 1.0.2h  3 May 2016
TLS SNI support enabled
configure arguments: --prefix=/usr/local/openresty/nginx --with-cc-opt=-O2 --add-module=../ngx_devel_kit-0.3.0 --add-module=../echo-nginx-module-0.60 --add-module=../xss-nginx-module-0.05 --add-module=../ngx_coolkit-0.2rc3 --add-module=../set-misc-nginx-module-0.31 --add-module=../form-input-nginx-module-0.12 --add-module=../encrypted-session-nginx-module-0.06 --add-module=../srcache-nginx-module-0.31 --add-module=../ngx_lua-0.10.7 --add-module=../ngx_lua_upstream-0.06 --add-module=../headers-more-nginx-module-0.32 --add-module=../array-var-nginx-module-0.05 --add-module=../memc-nginx-module-0.17 --add-module=../redis2-nginx-module-0.13 --add-module=../redis-nginx-module-0.3.7 --add-module=../rds-json-nginx-module-0.14 --add-module=../rds-csv-nginx-module-0.07 --with-ld-opt=-Wl,-rpath,/usr/local/openresty/luajit/lib --with-http_ssl_module --with-http_perl_module --with-http_v2_module --with-http_secure_link_module --add-module=/nginx-build/openresty-<IP_ADDRESS>/../testcookie-nginx-module --add-module=/nginx-build/openresty-<IP_ADDRESS>/../lua-upstream-cache-nginx-module --add-module=/nginx-build/openresty-<IP_ADDRESS>/../nginx-module-vts --with-openssl=/openssl

File system for now, as the subdomains each server deals with are separate.
Seems to be completely random when a crash occurs, anything from 3 hours to a good 3 days.
Not reloading nginx atm, just doing a restart, but I'll try this and see if this works too.
Initially I was using 1 worker, but I tried increasing this to 2 when the problems occurred to see if it would make any difference.
Using the following non-OpenResty modules:

nginx-module-vts https://github.com/vozlt/nginx-module-vts
lua-upstream-cache-nginx-module https://github.com/cloudflare/lua-upstream-cache-nginx-module
testcookie-nginx-module https://github.com/kyprizel/testcookie-nginx-module
and --with-http_v2_module --with-http_secure_link_module

I'm not using any other Lua in the configuration code yet other than this project.

Sorry for the delayed followup! After searching around some more, I have some theories on what might be happening:

The fact that you're seeing "exited on signal 9" errors, might indicate you're hitting out-of-memory errors, and the system is aggressively killing off processes: http://raspberrypi.stackexchange.com/questions/40883/nginx-out-of-memory-kill-process
When a process crashes or gets forcibly killed like this, then it may lead to nginx thinking the shared memory is still locked by the dead worker process. For example, in your initial example, it looks like worker process 501 gets killed first, but then it still thinks the memory is locked by pid 501, leading to this deadlock.

It does seem like nginx is supposed to unlock shared memory on crashes, so I'm not entirely sure why that might not be happening. But if workers are getting killed off with SIGKILL (9), then all bets might be off (since sigkill usually means forcibly kill the process and there's no chance to clean up).

So do you see anything in your system-level logs about out of memory or oom-killer? Do you have any other monitoring on these servers that might indicate memory growth or a memory leak in nginx? I don't think we've seen any memory leaks in any of our lua-resty-auto-ssl installations, so I'm wondering if some of the other nginx modules might also be playing a role (there is this mention of a memory leak in lua-upstream-cache-nginx-module).

Any updates here?
We are experiencing the same issue once in a week and getting outage.

Sorry - I meant to clarify back to @GUI that the killed on signal 9 isn't connected to the bug, but us deliberately killing the nginx process to counter the issue. There is no issue with the memory on these servers, they have around 2GB of memory, with a tiny amount actually being used and the rest mostly cache. No OOM kills on dmesg.
I have a few more error lines that may be helpful, I'll try and get them from the servers shortly.

@ajmgh: I'm not entirely certain if it's related, but I think I tracked down some potential problems that could lead to strange errors if the configured lua_shared_dict memory size was too low: https://github.com/GUI/lua-resty-auto-ssl/issues/48#issuecomment-294397379
So do you know roughly how many certificates are in your system, and how big lua_shared_dict auto_ssl is configured to be in your nginx configuration? You might also try upgrading to v0.10.6, if possible, since there have been a few updates since 0.10.3 that might fix this (if we're lucky), or at least provide better error handling and messages.

I'm facing exactly the same error.
I just update lua-resty-auto-ssl to version 0.10.6-1 and increase lua_shared_dict auto_ssl_settings to 1000m (before it was set to 64k).
lua_shared_dict auto_ssl keeps the same: 1000m
Just waiting to see if these changes will fix this issue :/
@ajmgh did you solve your problem?

@aiev auto_ssl_settings currently only stores a short string as well as one boolean, so changing it won't make any difference. The certificates are stored in auto_ssl. So please try increasing that instead.

No, latest update doesn't fix our issue. I've upped the auto_ssl size to 8M, which is overkill since we use only around 10 certificates and didn't see any change.
# Log entries after my script detects nginx is unresponsive and force kills it
2017/05/24 13:29:15 [alert] 462#0: worker process 474 exited on signal 9
2017/05/24 13:29:15 [alert] 462#0: worker process 475 exited on signal 9
2017/05/24 13:29:15 [alert] 462#0: shared memory zone "auto_ssl" was locked by 475

I have experienced the same issue a few times.
I'm using OpenResty <IP_ADDRESS>/4 and lua-resty-auto-ssl 0.11.0-1 from luarocks.
When this issue appears,  more than 100 tcp connections are stuck at CLOSE_WAIT state.

We have experienced the same issue many times as well.
nginx version: openresty/<IP_ADDRESS>
lua-resty-auto-ssl   0.11.0-1
There're many CLOSE_WAIT state, and nginx cannot response anymore. Either we need to kill CLOSE_WAIT connection, or restart the docker to solve this issue.

@ajmgh have you solved your issue? We are experiencing the same issue in our openresty containers. We got ~1200 connection in CLOSE_WAIT state and lots of dehydrated files in /tmp in our servers that run only openresty with lua-resty-auto-ssl.
Here is our system configuration

What version of lua-resty-auto-ssl are you running?
0.11.0-1
Are you running OpenResty or nginx with the lua module manually installed?
openresty
What versions of OpenResty or nginx+lua are you running?
openresty <IP_ADDRESS>
What storage mechanism are you using with lua-resty-auto-ssl (Redis, filesystem, something else)?
redis
How frequently do things hang? Does it seem to only happen when new certs are being registered or renewals are taking place, or is it seemingly random?
It looks very random. It just happened yesterday and led to a 30min downtime in our system. The previous time it happened was 2 month ago.
Are you reloading nginx at all (sending a SIGHUP to the master process and spawning new workers instead of fully restarting the master process)?
we just replaced all docker containers
How many nginx workers do you have running (worker_processes setting in nginx config)?
2
Do you have any other nginx plugins installed (beyond the ones that come with OpenResty by default if you're on OpenResty)?
nope lua-resty-auto-ssl is the only plugin we have install

@ronail No, however we added extra servers on our roundrobin as well as have an automated restart script when this issue happens so we've heavily mitigated it.
Is everyone else using Docker who experiences this bug? Maybe it's something really weird going on with a mix of Lua/OpenResty and Docker.

I'm not using docker and i'm facing the same problem.
I guess that this is an issue when dehydrated tries to issue the certificate.

We've been hit with the same issue yesterday, and found these reports (#43, #136) which contained no pointers as to what might be the root cause. We were unable to reproduce the issue on our test system, so we were forced to debug on the production one. 'Fortunately', the hangs were frequent enough, so we could quickly iterate through our debugging methods. First, it was only a strace -fp $pid on all nginx processes, and this revealed that all of them were waiting on a futex() - consistent with the fact that one of the pids always held a lock on a shdict. Next, I added a dump of the gdb backtrace of each process, and after adding debug symbols to the image, it became clear, that the issue is on the following code path:
#3  0x00007f8f4ea50219 in ngx_shmtx_lock (mtx=0x7f8f31a0c068) at src/core/ngx_shmtx.c:111
#4  0x00007f8f4eb7afbe in ngx_http_lua_shdict_set_helper (L=0x418257a0, flags=0) at ../ngx_lua-0.10.13/src/ngx_http_lua_shdict.c:1016
#5  0x00007f8f4eb7a4a4 in ngx_http_lua_shdict_delete (L=0x418257a0) at ../ngx_lua-0.10.13/src/ngx_http_lua_shdict.c:632
#6  0x00007f8f4debd2f3 in lj_BC_FUNCC () from /usr/local/openresty/luajit/lib/libluajit-5.1.so.2
#7  0x00007f8f4dec0b9f in gc_call_finalizer (g=0x418063b8, L=0x418257a0, mo=0x7ffc7592da00, o=0x40e11948) at lj_gc.c:475
#8  0x00007f8f4dec0e2b in gc_finalize (L=0x418257a0) at lj_gc.c:509
#9  0x00007f8f4dec15d9 in gc_onestep (L=0x418257a0) at lj_gc.c:659
#10 0x00007f8f4dec16ef in lj_gc_step (L=0x418257a0) at lj_gc.c:689
#11 0x00007f8f4ded8c3d in lua_pushlstring (L=0x418257a0, str=0x7f8f330a6066 "0\202\002\v\n\001", len=527) at lj_api.c:639
#12 0x00007f8f4eb7a225 in ngx_http_lua_shdict_get_helper (L=0x418257a0, get_stale=0) at ../ngx_lua-0.10.13/src/ngx_http_lua_shdict.c:538
#13 0x00007f8f4eb79eb6 in ngx_http_lua_shdict_get (L=0x418257a0) at ../ngx_lua-0.10.13/src/ngx_http_lua_shdict.c:419
After a quick glance of ngx_http_lua_shdict_get_helper()  the root cause of the problem becomes clear: the shdict gets locked, and lua_pushlstring sometimes calls the garbage collector, which might want to remove items from the same shdict, causing the deadlock.
My quick and dirty solution was this (it's so ugly I'm not going to publish a patch);
case SHDICT_TSTRING:
{
int len = value.len;
char *tmp = malloc(len);
if(!tmp) {
ngx_log_error(NGX_LOG_ERR, ctx->log, 0, "dict get: malloc: out of memory");
return luaL_error(L, "out of memory");
}
ngx_memcpy(tmp, value.data, value.len);
ngx_shmtx_unlock(&ctx->shpool->mutex);
lua_pushlstring(L, tmp, len);
free(tmp);
}
break;
So far this runs flawlessy - someone with more insight to the inner workings of the system might want to produce a better fix.

Interestingly, it's a known fact !
https://github.com/openresty/lua-nginx-module/issues/1207#issuecomment-350745592

that's interesting indeed. as per the issue you mentioned, using lua-resty-core would fix the problem, and according to its documentation, it's automatically loaded since openresty <IP_ADDRESS>, so this bug was silently fixed in that version. we'll upgrade our proxy and report back.

looks like it's working perfectly - assuming the condition that caused it to hang before still persist, I'd say the bug has been fixed.

Just ran into this, after 3+ years of running smooth.

Also ran into this issue in production – thanks @koszik and al. Just to confirm, to resolve this issue:
Update OpenResty to ><IP_ADDRESS>
This seems so pernicious it might be worth releasing f66bb61f11a654f66d35dd793ceaf0293d9c0f46 soon, or at least updating the documentation to requirement, rather than a recommendation.


Right way to make a remove node button on every node

Hi,
I really enjoy d3-org-chart :) Thanks for making an awesome tool!
Recently, I tried to add a hide button that displays a remove button on every node. I was able to achieve this, but I'm having difficulty making the button work repeatedly on multiple components without having to click the remove button again.
I'm wondering what the best approach would be to create such a button? It seems like I need to add an event listener every time the chart is updated, but I'm struggling with "calling a function from HTML string javascript."
Could anyone provide some guidance on the best practices and methodologies for implementing this feature?

Great thanks, it works! 👍
The removed node somehow still appear when expanding the chart if I make show/hide button for the remove button. I think it a state issue outside org-chart though..

Can you share a recording of the screen?  And if you are using any libraries

Additional thoughts - yes, it's most probably a state issue, and the same/previous data (with removed node) is getting passed probably


Langchain::Evals::CosineSimilarity to calculate simple similarity between actual and expected outputs

@bborn Okay, I re-packaged it a bit to a small, simple PR. I'm thinking of adding instructions to the README, something like:
# Execute the Assistant.

assistant.add_message_and_run! content: "What is 2+2?"
actual_output = assistant.messages.last.content

# Compare it's output to the expected output
Langchain::Evals::CosineSimilarity(actual_output: actual_output, expected_output: "4").score


BLE-MESH sensor example issues (IDFGH-3209)

Environment

Development Kit:      [ESP32-DevKitC]
Kit version (for WroverKit/PicoKit/DevKitC): [v4]
Module or chip used:  [ESP32-WROOM-32D]
IDF version (run git describe --tags to find it):
// v3.2-dev-1148-g96cd3b75c
Build System:         [idf.py]
Compiler version (run xtensa-esp32-elf-gcc --version to find it):
// 1.22.0-80-g6c4433a
Operating System:     [macOS]
(Windows only) environment type: [MSYS2 mingw32|ESP Command Prompt|Plain Command Prompt|PowerShell].
Using an IDE?: [No|Yes (please give details)]
Power Supply:         [USB|external 5V|external 3.3V|Battery]

Problem Description
When I compile the sensor server program and monitor it on the terminal, the following errors produced
E (1018) BLE_MESH: check_sensor_server_init, Invalid Sensor Setting state
E (1028) BLE_MESH: sensor_server_init, Invalid Sensor Server init value
E (1028) BLE_MESH: check_sensor_server_init, Invalid Sensor Setting state
E (1038) BLE_MESH: sensor_server_init, Invalid Sensor Setup Server init value

Also, for the client example, the include files for
#include "esp_ble_mesh_networking_api.h"
#include "esp_ble_mesh_config_model_api.h"
#include "esp_ble_mesh_sensor_model_api.h"

are not working, so many include errors have been produced.
I saw the definition for some functions in the header files are in inactive status, should I make some special configurations for the newly added examples?

fixed issues by updating esp-idf


Publish process not publishing global distribution file(s)

Recently, we added support for non-modular front-end applications to utilize our AndcultureCode.Javascript.Core project via a global distribution. As it turns out, while a dist-global folder is generated as part of the npm run build command, the npm publish command is not utilizing this folder during the publish process.

Should be published v0.3.5 - let me know if you're still having issues and we can open this back up 👍


DIVINITY ON TOP | invite.latae.xyz

Have you ever wanted to run a raw Lua script in an internal serverside but cant seem to figure out auto conversion? Well, i have just the thing for you!:
Divinity Serverside
Divinity is a server-sided execution system that runs FilteringDisabled (Non-FE/FD) scripts in real-time, without having to convert or use modules. In fact, not even we use modules. Our code and system is ran on a completely external backend API that we use exclusively. We don't like the methods that other serversides use to backdoor games, as they're unreliable, not secure, and inefficient. We run using a very secure client system through normal Roblox scripts, and we also have a script you can use with your desired script utility that makes our client system completely undetectable to games, no matter how good their detections are.
To add on, we don't log anything you do or execute. In-fact, the client doesn't even send the code you use to the server. We compile the Lua bytecode on the client, then send it to the server to just decode and convert your code as simply as possible. That way it is more optimized, and speedier for our users. This is also much more secure for our server end, as we don't have to rely on the very vulnerable InvokeClient function to get data from the client  We send and receive data from the server, instead. This has taken longer to make as the client obviously doesn't automatically replicate these things as opposed to the server, but we try to go the extra mile for stability, optimization, and security.
Discord Server: https://discord.gg/nqtjPG8nBa

buy divinity when it comes out
please


IrodsDataRequest update/delete REST API views do not create timeline events

I noticed the following issues in IrodsDataRequestUpdateAPIView and IrodsDataRequestDestroyAPIView:

Creating a timeline event is not functional due to not passing a timeline backend API object
The aforementioned functionality is not tested in the API view tests
The update view does not support PATCH correctly as the aforementioned functionality is only present in put(), instead of perform_update() which is the correct way to do this

I will do this as a part of #1706, but it's a serious enough problem to warrant a separate ticket.

Fixed.


"picks" attribute is null list in _sources_as_epochs/evoked

"picks" attribute is null list in _sources_as_epochs/evoked in the case when add_channels is None. This breaks functionality when, for example, you want to pick individual components out of the resulting epochs/evoked object with .pick_channels, as this function require a "picks" array.

can you share a code snippet to expose / replicate the pb?

In the else case below picks is an empty list.
def _sources_as_epochs(self, epochs, add_channels, concatenate):
"""Aux method."""
out = epochs.copy()
sources = self._transform_epochs(epochs, concatenate)
if add_channels is not None:
picks = [epochs.ch_names.index(k) for k in add_channels]
else:
picks = []
out._data = np.concatenate([sources, epochs.get_data()[:, picks]],
axis=1) if len(picks) > 0 else sources

I am sorry I don't get the issue. This function is executed by a test and
it's fine
to do things like this:

epochs.get_data()[:, []]
array([], shape=(1, 0, 241), dtype=float64)

Yes, but it will fail if one calls e.g. .pick_channels on it, because that function expects an array to be in self.picks. One can hack around it by doing something like
epochs.picks = np.array(range(len(epochs.ch_names)))

please share a full gist to replicate a crash so I don't have to reverse
engineer what you have in mind.
ideally paste it at: https://gist.github.com/
thanks

I can no longer replicate the bug, and don't really have an explanation for it. Yesterday, the code required the hack I mentioned above in order to run, and today, it doesn't. Really sorry to waste your time...


release-v0.4.18

[chore] update golang to 1.23 #598
[chore] code.gitea.io/sdk/gitea v0.17.1 => v0.19.0 #598
[chore] upgraded github.com/argoproj/argo-cd/v2 v2.10.0 => v2.13.1 #598
[chore] upgraded github.com/briandowns/spinner v1.23.0 => v1.23.1 #598
[chore] upgraded github.com/go-git/go-git/v5 v5.11.0 => v5.12.0 #598
[chore] upgraded github.com/ktrysmt/go-bitbucket v0.9.75 => v0.9.81 #598
[chore] upgraded github.com/spf13/cobra v1.8.0 => v1.8.1 #598
[chore] upgraded github.com/spf13/viper v1.18.2 => v1.19.0 #598
[chore] upgraded github.com/stretchr/testify v1.8.4 => v1.10.0 #598
[chore] upgraded github.com/xanzy/go-gitlab v0.97.0 => v0.114.0 #598
[chore] upgraded k8s.io/api v0.26.11 => v0.31.0 #598
[chore] upgraded k8s.io/apimachinery v0.26.11 => v0.31.0 #598
[chore] upgraded k8s.io/cli-runtime v0.26.11 => v0.31.0 #598
[chore] upgraded k8s.io/client-go v0.26.11 => v0.31.0 #598
[chore] upgraded k8s.io/kubectl v0.26.11 => v0.31.2 #598
[chore] upgraded sigs.k8s.io/kustomize/api v0.12.1 => v0.17.2 #598
[chore] upgraded sigs.k8s.io/kustomize/kyaml v0.13.9 => v0.17.1 #598
[chore] replaced github.com/ghodss/yaml v1.0.0 with sigs.k8s.io/yaml v1.4.0 #598
[chore] Bump go.opentelemetry.io/contrib/instrumentation/google.golang.org/grpc/otelgrpc #525
[chore] Bump github.com/go-jose/go-jose/v3 from 3.0.0 to 3.0.1 #528
[chore] Bump golang.org/x/crypto from 0.16.0 to 0.17.1 #542 #544
[chore] Bump github.com/cloudflare/circl from 1.3.3 to 1.3.7 #546

Codecov Report
Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (55eb562) 40.73% compared to head (5554fa7) 40.73%.

Files
Patch %
Lines

cmd/commands/project.go
0.00%
1 Missing :warning:

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #556   +/-   ##
=======================================
  Coverage   40.73%   40.73%
=======================================
  Files          41       41
  Lines        6721     6721
=======================================
  Hits         2738     2738
  Misses       3869     3869
  Partials      114      114

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

/ci

/ci

/release

/release


Added weekly review 018

Feel free to edit it. Thanks.

Thanks @kianmeng
https://perlweeklychallenge.org/blog/review-challenge-018/


CVE-2020-0353 - Inconsistent PURL

For CVE-2020-0353, there are two different invalid PURLs:
1- The statement file on FS<EMAIL_ADDRESS>2- In Postgres, it is<EMAIL_ADDRESS>By looking at the CVE on the NVD website, it is related to Google's Android.
https://nvd.nist.gov/vuln/detail/CVE-2020-0353

With "-i none" the incorrect mapping for this CVE disappears, I tested this locally.


[WIP] Spanish translation

Hi, awesome project! I'll be translating the rest of files during this week :)
Translated files

[x] context.cson
[ ] menu_darwin.cson
[ ] menu_linux.cson
[ ] menu_win32.cson
[ ] settings.cson

@stsewd Thank you so much for contributing :100:
Really looking forward to Atom in Spanish

@liuderchi Hi, I just finish the Spanish translation, feel free to merge the pull request, if there is something wrong, please let me know, I will try to fix it the more sooner possible.
Notes for future Spanish translators/Nota para futuros traductores: He dejado algunas palabras en inglés, dado que no tienen mucho sentido si son traducidas, y no encontré una traducción más "natural". Sugerencias son bienvenidas.

LGTM and ready to be merged.
Please keep updating Atom and watching for new UI changes.
If found new Item require translation, please send issues.
Thanks so much @stsewd for your contribution :100:


CVE-2022-32221 on 2.0.1 docker image

can curl be removed from the img?

curl is needed for the docker service health check. This CVE was fixed with curl 7.86.0 and the fix got backported to debian bullseye Dec 27 2022.
To fix this (and similar issues in the future), the Superset committers could rebuild and push the docker image from 2.0.1 tag. Another solution would be to release a new 2.0.2 tag based on the 2.0.1 tag which would rebuild the docker images and thus updating curl and other OS packages.

I'm not sure if this is still an issue in current versions of Superset (3.x). If it is, we can re-open this, or feel free to open a new issue with updated context and a reproducible case using example data. We're no longer supporting Superset 2.x or prior, and it's been a while since this thread saw any activity, so I'm closing this as stale.


Adding the file with names, while I figure out Jekyll

Summary
A blog for wrap up is added. We needed to remove 4 mentees and 1 mentor who were not involved.
I am not entirely sure where to change the file info, which is what I will do now.
What should the reviewer focus on?

language, grammar, everything looks ok

Thanks for PRing this, @malvikasharan !

@malvikasharan what do you think about having the last section looking like this?

If you like it, I can push the changes

I was thinking: what about creating a Twitter moment with all tweets related to OLS-1? We could put it at the end of the post.

@bebatut all suggestions look great. We can definitely create all the ols-1 moments, but maybe add that in a next post? We have quite a few fun things to extract from our notes that we can put together in a different post with tweet?

Sounds like a good idea for the Tweeter moment 😄

Ready on my side!


Address 'unknown publisher' warning when running on Windows

Requires purchasing a code signing certificate. Deferring until iteration 3.

Purchased certificate. Began paperwork. Will complete iteration 4.


Default config initialization shouldn't trigger debug warnings

What?
When debug mode is on, the gem logs wrong configuration warnings, but values that were defined as default shouldn't trigger warnings.
How?
This PR checks if the wrong value configuration came from a default definition before triggering warnings.

This is awesome!  Thanks for the contribution!

@dccunha have any interest in becoming a maintainer?  I no longer (as of November 2018) use the suite of three gems in my daily work due to rolling off the project that used Resque, and it would be good to have someone involved who is using them in a real environment.

@pboling Yes, I would be glad to help. :)

@dccunha I've invited you to all three projects, thanks for your help!


Ability to turn off logs

Expected Behavior
The ability to silence/turn off the log
Current Behavior
MongoDB connection not set. Skipping Mongo-Throttle
Possible Solution
Send in options that allows you to select if you want to log at all

We can just use debug instead of directly logging it.

Rendered irrelevant by https://github.com/andjosh/mongo-throttle/commit/5148602b2b1b6cbbfbf9b3defd844977f6600dbe


Numerical errors in backward

Were you able to find out the reason for the small numerical errors in backward pass with ring flash attention?
I found the errors increase as you increase the world size, so it does seem to be related to the fact that flash attention returns 16-bit tensors, and even though we accumulate in a 32-bit buffer it seems it is not enough.
Maybe it is an easy PR in flash attention to have them return raw fp32, or do the accumulation upstream?

tbh, not really... as far as I can tell, it won't be a simple PR with few changes to flash attention.

With Llama 405B there are many layers, and with ring sizes of 4 or 8 the numerical errors become catastrophic in backward. The errors actually originate in the forward pass in out & lse, but the backward grads can blow up, and it is deceptive because the forward loss value can look quite reasonable.
A quick workaround is to use the context parallel (llama3) implementation in this repo for the forward pass alone. It is much more numerically stable, and if you have NVLink is quite communication efficient (if you don't, there's a penalty, but you could try overlapping compute & comm over the head strides).
The downsides in this repo's implementation is that it doesn't support zigzag and doesn't have an explicit non-varlen implementation, but those are actually easy to address.
The memory overhead is not that bad: you no longer need the 32-bit buffers used in the ring forward, and you could try to minimize the overhead with head stride = 1.
Backward pass can remain the usual zigzag ring implementation. This combination allowed me to scale the ring size even with very large models without huge numerical errors.
An alternative solution would be to replace the forward pass with this Triton version which supports rings and basically does what this issue wants done (no external sigmoid accumulation): https://github.com/lucidrains/ring-attention-pytorch/blob/main/ring_attention_pytorch/triton_flash_attn.py
But some modifications would be needed, and this version only supports striped attention (which is a bit worse than this repo's zigzag implementation), and I am not sure it actually takes advantage of GQA (just replicates KV heads in VRAM).

Thank you for this suggestion, I'll try to implement the llama3 implementation with zigzag when I have a moment :).


remove async_trait from ExchangeSource

https://github.com/singularity-data/risingwave/blob/main/rust/rpc_client/src/compute_client.rs#L128-L132
/// Each ExchangeSource maps to one task, it takes the execution result from task chunk by chunk.
#[async_trait::async_trait]
pub trait ExchangeSource: Send {
    async fn take_data(&mut self) -> Result<Option<DataChunk>>;
}

take_data gets frequently called and is on the critical path. We may need to remove the overhead of async_trait.
Same as what #1132 did.

Hi @lmatz! May I try to resolve this issue? The intuition behind it seems similar to this tutorial: https://www.skyzh.dev/posts/articles/2022-01-31-gat-async-trait/

Hi @lmatz! May I try to resolve this issue? The intuition behind it seems similar to this tutorial: https://www.skyzh.dev/posts/articles/2022-01-31-gat-async-trait/

Sure!

A PR has been created to solve this issue. PTAL #3586


[Suggest]I would like to suggest code that I have implemented.

There is a custom layer that will benefit people. It is the method proposed by 'Deep Complex Network' and I have already implemented it. What should I do to propose to TFA?

Hi @DevKiHyun! Welcome. Do you mind linking to the paper and your implementation?

Closing for now. Please feel free to re-open and change the title once you have more information


feat(printer) Print UnaryExpression

Current dependencies on/for this PR:

main

PR #1272

PR #1273   👈

PR #1274

PR #1275

This stack of pull requests is managed by Graphite.


Password Hidden Error

The password and remember_token still reflected in the data of Auth::user()->password

try :
dd($user->toArray()); // or ->toJson();

Sometimes you may wish to limit the attributes that are included in your model's array or JSON form, such as passwords. To do so, add a hidden property definition to your model

"your model's array or JSON"
http://laravel.com/docs/5.0/eloquent

ok. protected $hidden = ['password'] and still the error still allows reading the password when it should be hidden from


tab-content not showing

Hi,
i'm not sure if my issue is in fact a vue-strap issue, but i think you can tell me.
i have a quite simple setup using tabs in this gist.
Everything works perfect, except: the content of the active tab is not showing.
the the active div[role=tabpanel] has .tab-pane.fadein-transition
the inactive has .tab-pane.fadein-transition.hide,
but there is a style:
.tab-content > .tab-pane{ display:none; }
i can easily just delete or overwrite this rule, but that seems strange to me.
even your demo-page has this bug :)
is that some quirk in boot-strap or is this a vue-strap bug?
Thanks, Schorsch

Fixed

i suggest add the to here

http://yuche.github.io/vue-strap/#tabs

because you have change the field tabs to tabset


Increase the CNV classification speed

Hi everyone,
I'm using BNN-PYNQ on Pynq v2.4 for real time object detection ( frame by frame from video ), but time for BNN is not fast enough to get high performance. I tried to use
       start_timet = time.time()          result = classifier.classify_cifars_details(fp.name)           end_timet = time.time()
to check  time consume (using terminal) then
result_time = end_timet - start_timet = 0.022214889526367188 per image
Maybe data transmission time between PS and PL on Pynq is high  . I would like to increase speed of  BNN classification and I saw an old issue :

I dont know how to change values of SIMD and PE counts

Can you help me with this?
Regards,
Hung

Hi,
according to your measured time, you should be able to run at 45 frames per second. Do you have a video source providing data at higher frame rate? Which board are you using?


Reduce defaultDecisionTaskTimeout to 10

Original 20 sec is a little be too conservative and not necessary, change to 10s

Coverage decreased (-0.03%) to 68.817% when pulling 464bd6925f1d9e38b38453b2fd298a30b52b7ab1 on ditimeout into f32a653d30bd17bfb06b268b5120d4b1504c4b67 on master.


Make MassTransit.Grpc work with old .NET Framework

Existing Code throws a Runtime Exception on .NET Framework 4.8
"gRPC requires extra configuration on .NET implementations that don't support gRPC over HTTP/2. An HTTP provider must be specified using GrpcChannelOptions.HttpHandler.The configured HTTP provider must either support HTTP/2 or be configured to use gRPC-Web. See https://aka.ms/aspnet/grpc/netstandard for details."
The proposed changed solves that error

Oh, this was merged.


mlterm: 3.8.4 -> 3.8.6

Semi-automatic update generated by https://github.com/ryantm/nixpkgs-update tools.
This update was made based on information from https://repology.org/metapackage/mlterm/versions.
These checks were done:

built on NixOS
Warning: no invocation of /nix/store/y5kq18q0af30rvbhl25jpxrrf7czp5b8-mlterm-3.8.6/bin/mlterm had a zero exit code or showed the expected version
Warning: no invocation of /nix/store/y5kq18q0af30rvbhl25jpxrrf7czp5b8-mlterm-3.8.6/bin/mlfc had a zero exit code or showed the expected version
/nix/store/y5kq18q0af30rvbhl25jpxrrf7czp5b8-mlterm-3.8.6/bin/mlcc passed the binary check.
/nix/store/y5kq18q0af30rvbhl25jpxrrf7czp5b8-mlterm-3.8.6/bin/mlclient passed the binary check.
/nix/store/y5kq18q0af30rvbhl25jpxrrf7czp5b8-mlterm-3.8.6/bin/mlclientx passed the binary check.
Warning: no invocation of /nix/store/y5kq18q0af30rvbhl25jpxrrf7czp5b8-mlterm-3.8.6/bin/mlterm-fb had a zero exit code or showed the expected version
3 of 6 passed binary check by having a zero exit code.
0 of 6 passed binary check by having the new version present in output.
found 3.8.6 with grep in /nix/store/y5kq18q0af30rvbhl25jpxrrf7czp5b8-mlterm-3.8.6
directory tree listing: https://gist.github.com/917b0ce2af6e7d2a9baa6c66857143a5
du listing: https://gist.github.com/7b0c64048e0913af1cabbed5885116b2

meta.description for mlterm is: '""'.
cc @vrthra @ramkromberg for testing.
Experimental: this build is cached with Cachix. To use the cache follow these experimental instructions:
One time setup in nixpkgs Git checkout:
cachix use r-ryantm
git remote add r-ryantm https://github.com/r-ryantm/nixpkgs.git

Test this build:
git fetch r-ryantm && git checkout 31d247d747584bfbd6ce3b4a29ea2b55233f79cd && nix-shell --pure -I nixpkgs=. -p mlterm

No attempt on x86_64-darwin (full log)
The following builds were skipped because they don't evaluate on x86_64-darwin: mlterm
Partial log (click to expand)

a) For `nixos-rebuild` you can set
  { nixpkgs.config.allowUnsupportedSystem = true; }
in configuration.nix to override this.

b) For `nix-env`, `nix-build`, `nix-shell` or any other Nix command you can add
  { allowUnsupportedSystem = true; }
to ~/.config/nixpkgs/config.nix.

Success on x86_64-linux (full log)
Attempted: mlterm
Partial log (click to expand)
shrinking /nix/store/y5kq18q0af30rvbhl25jpxrrf7czp5b8-mlterm-3.8.6/lib/mef/libmef_kokr.so
shrinking /nix/store/y5kq18q0af30rvbhl25jpxrrf7czp5b8-mlterm-3.8.6/lib/mef/libmef_8bits.so
shrinking /nix/store/y5kq18q0af30rvbhl25jpxrrf7czp5b8-mlterm-3.8.6/lib/mef/libmef_jajp.so
shrinking /nix/store/y5kq18q0af30rvbhl25jpxrrf7czp5b8-mlterm-3.8.6/lib/libmef.so.2.0.0
gzipping man pages under /nix/store/y5kq18q0af30rvbhl25jpxrrf7czp5b8-mlterm-3.8.6/share/man/
strip is /nix/store/21ymadblbmsbb2bk4q7gl4kjasp8zmgd-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/y5kq18q0af30rvbhl25jpxrrf7czp5b8-mlterm-3.8.6/lib  /nix/store/y5kq18q0af30rvbhl25jpxrrf7czp5b8-mlterm-3.8.6/libexec  /nix/store/y5kq18q0af30rvbhl25jpxrrf7czp5b8-mlterm-3.8.6/bin
patching script interpreter paths in /nix/store/y5kq18q0af30rvbhl25jpxrrf7czp5b8-mlterm-3.8.6
checking for references to /build in /nix/store/y5kq18q0af30rvbhl25jpxrrf7czp5b8-mlterm-3.8.6...
/nix/store/y5kq18q0af30rvbhl25jpxrrf7czp5b8-mlterm-3.8.6

Success on aarch64-linux (full log)
Attempted: mlterm
Partial log (click to expand)
shrinking /nix/store/cnd6g02yhgk057jqccc3hm2smsb42vzw-mlterm-3.8.6/lib/mef/libmef_kokr.so
shrinking /nix/store/cnd6g02yhgk057jqccc3hm2smsb42vzw-mlterm-3.8.6/lib/mef/libmef_jajp.so
shrinking /nix/store/cnd6g02yhgk057jqccc3hm2smsb42vzw-mlterm-3.8.6/lib/libmef.so.2.0.0
shrinking /nix/store/cnd6g02yhgk057jqccc3hm2smsb42vzw-mlterm-3.8.6/lib/libpobl.so.1.0.0
gzipping man pages under /nix/store/cnd6g02yhgk057jqccc3hm2smsb42vzw-mlterm-3.8.6/share/man/
strip is /nix/store/qg2agrqkf240s656d207zqhipl0bc2id-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/cnd6g02yhgk057jqccc3hm2smsb42vzw-mlterm-3.8.6/lib  /nix/store/cnd6g02yhgk057jqccc3hm2smsb42vzw-mlterm-3.8.6/libexec  /nix/store/cnd6g02yhgk057jqccc3hm2smsb42vzw-mlterm-3.8.6/bin
patching script interpreter paths in /nix/store/cnd6g02yhgk057jqccc3hm2smsb42vzw-mlterm-3.8.6
checking for references to /build in /nix/store/cnd6g02yhgk057jqccc3hm2smsb42vzw-mlterm-3.8.6...
/nix/store/cnd6g02yhgk057jqccc3hm2smsb42vzw-mlterm-3.8.6


Fix finalization problem when broker has incorrect topic config

Signed-off-by: Matthias Wessendorf<EMAIL_ADDRESS>Fixes #2815

Proposed Changes

If an invalid topic config is present for a broker we do not block finalization

Release Note

If an invalid topic config is present for a broker we do not block finalization

Docs

/test reconciler-tests-namespaced-broker

/assign @aliok

/test reconciler-tests-namespaced-broker

    broker.go:140: admission webhook "validation.webhook.kafka.eventing.knative.dev" denied the request: validation failed: invalid value: knative-eventing: spec.config.namespace
        Expected ConfigMap in same namespace with broker resource
    --- FAIL: TestBrokerWithBogusConfig/delete_broker_with_non_existing_Secret/Setup/install_broker (0.13s)

This, is an interesting issue w/ the "namespaced" broker /cc @aliok

This, is an interesting issue w/ the "namespaced" broker /cc @aliok

The webhook allows the admission for the namespaced broker:

Config namespace is empty (assumed same as the broker namespace)
Config namespace is same as broker namespace

See https://github.com/knative-sandbox/eventing-kafka-broker/blob/c42f668edd46227a848eb49f777d1fa087300592/control-plane/pkg/apis/eventing/v1/broker_validation.go#L85
To fix the issue in the test:

Remove the configNamespace("knative-eventing") call.
Create the configmap in broker's namespace advance
Pass the configmap's name: broker.WithConfig(configName),

So, something like:
f.Setup("create broker config", brokerconfigmap.Install(
		configName,
		brokerconfigmap.WithBootstrapServer(testpkg.BootstrapServersPlaintext),
		//... rest of the incorrect topic config,
	))

f.Setup("install broker", broker.Install(
		brokerName,
		append(
			broker.WithEnvConfig(),
			broker.WithConfig(configName),
			broker.WithAnnotations(
				map[string]interface{}{
					kafkabroker.ExternalTopicAnnotation: "my-topic",
				}))...))

Or, if you want to test the case that the configmap doesn't exist, then:
f.Setup("install broker", broker.Install(
		brokerName,
		append(
			broker.WithEnvConfig(),
			broker.WithConfig("inexistent-configmap"),
			broker.WithAnnotations(
				map[string]interface{}{
					kafkabroker.ExternalTopicAnnotation: "my-topic",
				}))...))

It is really not about "non existing" bits. it's about bogus config, when finalizing.
I added a new test: https://github.com/knative-sandbox/eventing-kafka-broker/pull/2853/commits/5959d757813afb7baa16655d6a28ecc2254fabc6
Also, there is no secret, no finalizer on the CM

There could be still a secret, with the bogus/invalid config, and we than need to tear that down as well.
So: I will add more test for this - but in 2023
/hold

/test channel-reconciler-tests-ssl

/lgtm
/approve

/unhold

/test channel-reconciler-tests-sasl-plain

/test channel-integration-tests-sasl-plain

/retest


Firebase migration 104 105

fixed issue with properly casting type from firestore to graphql/ts.
implmeneted resolvers

wrong merge branch


Is nsenter for mac user?

Seems I can't run it on my mac
$ /tmp/nsenter
-bash: /tmp/nsenter: cannot execute binary file

Seems i have the answer already, but will it supports toolbox?
My boot2docker environment is broken after install the latest docker toolbox.

This tool is really useful. Thanks a lot
A new pull request has been raised to add toolbox usage for mac and windows users.
https://github.com/jpetazzo/nsenter/pull/73

pull request has been merged, then this ticket can be closed.


misleading "abstract state" exception under certain conditions

When transitioning from a top-level state to its parent via ^, this exception is thrown:
Error: Cannot transition to abstract state '^'

Of course, there is no parent state, so this is an error.  The exception messaging is misleading; should probably check for existence of a parent state, and if it doesn't exist, note that instead of calling it "abstract".

The implicit root state is abstract. Perhaps it could be given a meaningful name so the error would make more sense.

https://gist.github.com/eddiemonge/f6a58169c2846731a1eb


Configuration Manager Preview - software center connection bug

I hope this is the correct place to post this.
We started to use admin center so we can control SCCM Remotely. This works great for sending updates ( Actions ).
However if we klik on software center - options applications we can remotly install programs that need to be manuelly installed.
For most computers this never works. It keeps loading but no data will show. The wierd thing is that the option Installation status will give us data but here we are unable to send installation instructions.
Extra info
This is for multiple source and destination computers, windows 10 fully updated and rebooted multiple times on diffrent days.

Thanks for reporting! I've passed this bug to the owning team :)

Closing this out as it is not owned by WAC :)


Enforcement of new Poggit rule against SQL injection

Dear plugin developer,
We have updated the Poggit plugin rules, and your plugin Prisons appears to be affected.
The new rule is as follows:

B8: SQL parameters must be escaped
Data must NEVER be interpolated into SQL strings using interpolation, unless they are explicitly escaped using the mysqli::escape_string/SQLite3::escapeString function. No exceptions even if you are sure they are integers, player names or validated otherwise. Using libasynql or using bind_param()/bindValue() would be even better.

We detected the following line of code (and probably others) from your plugin that seems to breach the rule:
$query = $this->db->query("SELECT * FROM players WHERE username ='{$player}';");

You are required to update the code to conform to the rules in 14 days. Otherwise, your plugin may be removed from Poggit and a security advisory will be issued to recommend users to remove your plugin.
A simple fix is to use SQLite3::escapeString or mysqli::real_escape_string to escape your data, but we recommend that you use SQLite3::prepare() and bindValue or mysqli::prepare() and bind_param instead. Even better, we recommend that you migrate to libasynql, although this is not a strict requirement. (But async database access may become a strict requirement in the future).
Shall you have any enquiries, please post your question on the #poggit channel on the PMMP Community Discord.
Best regards,
SOFe
Poggit Team

Will switch to libasynql when I have the time, thank you.


Unable to get a binary file

I am trying to download (get) a file (size of 16MB) from sftp server using ssh2-sftp-client, the program does not terminate and hangs even after the events end, close is triggered on the ReadableStream and the events finish and close are triggered on the WriteableStream. Below is the program and it's output. There are no errors as well, how do I debug?

const Promise = require("bluebird");
const fs = require("fs");
const Client = require("ssh2-sftp-client");
const util = require("util");

const sftp = new Client();
const path = require("path");
const openpgp = require("openpgp"); // use as CommonJS, AMD, ES6 module or via window.openpgp

openpgp.initWorker({
    path: "openpgp.worker.js"
}); // set the relative web worker path

const config = {
    host: 'xxxx',
    port: '1111',
    username: 'xxxx',
    password: 'xxxx'
};

function getFileFromSFTP() {
    console.log("Program Execution started");
    /* get files from SFTP */
    const remotePath = "remoteFile";
    const localPath = "localFile"
    sftp.connect(config).then(() => {
        sftp.get(remotePath, true, null).then((data) => {
            data.on('error', (e) => {
                console.log(e);
            });
            data.on('end', () => {
                console.log("rs end");
            });
            data.on('close', () => {
                console.log("rs closed");
            });
            data.pipe(fs.createWriteStream(localPath).on('error', (e) => {
                console.log(e);
            }).on('finish', () => {
                console.log("ws finish");
            }).on('close', () => {
                console.log("ws close");
            }));
        });
    });
}

function init() {
    getFileFromSFTP();
}

init();

output

node index.js

Program Execution started
rs end
ws finish
ws close
rs closed
program doesn't exit after this, it hangs

I came here because downloading doesn't work for me at all.
The example above simply shows "Program Execution started", then the script hangs. Actually it connects, because console.log inside .then is shown. But the stream isn't read.
data.isPaused() stays true.

Likely duplicate of #106
Seems there is an incompatibility with Node 10.x and stream handling. I think this is fixed in my fork at https://github.com/theophilusx/ssh2-sftp-client. I will do a PR once I'm happy with the changes. Note that the changes are breaking changes which alter the API.

This issue is resolved with the new version and therefore can be closed.


fix method return value is the error log issue

Checklist

[ x] I've run bundle exec rspec from the root directory to see all new and existing tests pass
[ x] I've followed the fastlane code style and run bundle exec rubocop -a to ensure the code style is valid
[ x] I've read the Contribution Guidelines
[x] I've updated the documentation if necessary.

Motivation and Context
bug
Description
when not set apple versioning system following https://developer.apple.com/library/content/qa/qa1827/_index.html and user passed "build_number" argument, the shell command would return 0 instead of 6. but the command to get build_number would return the error log string with "There does not seem to be a CURRENT_PROJECT_VERSION key set for this project.  Add this key to your target's expert build settings."

I signed it

Hey @truebit, thanks for the PR! I am hesitant to merge this because in order to use the increment_build_number action, we do require that the user is using Apple Generic Versioning.
Could you explain a bit more about why this is helpful for you and what the use case is?

agvtool new-version -all <your_specific_version> would NOT throw exception (exit code would be 0) even if you did not enable Apple Generic Versioning.  And this command would also set all plist version number.
But when executing agvtool what-version, it would exit with code 6 instead of 0. and the build_number would be set to the stderr string.
You could try this out in any Xcode project which did not enable Apple Generic Versioning:
build_num = increment_build_number(build_number: Time.now.strftime("%Y%m%d") +'.'+ number_of_commits.to_s)
puts build_num

build_num would be There does not seem to be a CURRENT_PROJECT_VERSION key set for this project.  Add this key to your target's expert build settings. instead of expected 20170614.123

Hey @truebit, I was just able to reproduce this on my machine, and what you pointed out is happening for me too, but I think the proper approach here would be to make sure that Apple Generic Versioning is enabled and that the CURRENT_PROJECT_VERSION key is present before allowing this action to continue. If you want to set your build number to something specific and you are not using AGV, I think a better approach would be to use the set_plist_value action to set the CFBundleVersion key to the value you want. I just submitted https://github.com/fastlane/fastlane/pull/9474 to make sure that this action exits early if AGV is not enabled.
I am going to close this issue for now, but please feel free to leave comments here and continue discussion! 🚀

The action set_info_plist_value needs to specify plist file path, that would be troublesome when two or even more targets exists (e.g. widget and watchos targets besides the main target).
But agvtool would set all of them automatically

@truebit, that makes sense for sure, but it I believe it is really just unexpected behavior that the build number gets set. With the incrementing version actions we really want to support projects that do use Apple Generic Versioning.

This is the intended behavior as per man agvtool:

new-version [-all version]
Sets the version numbers of all targets to the given version.
       The CURRENT_PROJECT_VERSION and the DYLIB_CURRENT_VERSION will be updated.  **The -all option will also update the CFBundleVersion Info.plist key.**

       If CVS support is enabled, the modified project file will be committed.

This assumes that the project is using Apple Generic Versioning no?


Update User guide and Joeie PPP

Codecov Report

Merging #74 (8d1de3f) into master (c13764f) will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##             master      #74   +/-   ##
=========================================
  Coverage     72.15%   72.15%
  Complexity      399      399
=========================================
  Files            70       70
  Lines          1232     1232
  Branches        125      125
=========================================
  Hits            889      889
  Misses          311      311
  Partials         32       32

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c13764f...8d1de3f. Read the comment docs.


Create a new team interface not intuitive

The interface for creating a new team should be more intuitive.
When I was creating a new team
Suggested recommendations:

Make a clearer separation between My Teams and Create a the Create a New Team section
Make "Create a New Team" the header for the section
Remove the "Create a new team" prompt
Move the Notice: After you create... below the "Team Name" input field
Make the Cancel and Save Changes buttons visible on page load; gray out Save Changes button until a name is entered.

Agreed. there was an interim workflow for this that was more intuitive, but sometime in the last week it was pulled into a different flow without Marks direction. We need to either revert to the simpler workflow or have Mark address this process.
@tolmark12 thoughts?

Also, just to be clear. This feedback is related to the team create in the user settings, not the funnel.

@jedgalbraith was good enough to implement this without a design, we'll come back and add a design that takes these things into consideration


#1498 QA - DEX - favorite pair card

What would you like to be added:
Why is this needed:
Links to #1498

Acceptance Criteria: User able to "star" their preferred pair.
Android:

[ ] DEX > star icon present
[ ] DEX > select star > poolPair appears at top of screen

iOS:

[ ] DEX > star icon present
[ ] DEX > select star > poolPair appears at top of screen