[WIP] Use user supplied S3 instance

This changes the functionality to use a user supplied s3 instance (aws.S3) instead of creating our own. That way you are free to authenticate in any way you like, plus set any additional options you may want.
Fixes #9
The tests probably could use some love, the good thing is that we no longer need to mock a server, but instead just the s3 instance. Take a look at the test code to see this in action.
I want to test all available options of all options and also try it with some different files. Another thing I noticed is that I reuse much of the code from multers test set, we should probably move all that to a separate package on npm and require from both parts.

I made a PR at #26 with some small fixes

Thanks man!! Sorry I dropped the ball on this one

Hey no problem at all - you see like a busy guy ;)


Update overwrite_merge to be two Booleans

Overwrite_merge should be converted into two Booleans:

New collection (versus existing)
Overwrite objects

already done


dotnet watch stops to work when having a resource (resx) file in the project

Functional impact
Can't use dotnet watch, instead have to manual dotnet run on change
Minimal repro steps

File => New Project => .NET Core => ASP.Net Core Web Application (.NET Core) => Web Application
Add folder "Resources"
Create new resource file in the create folder (e.g. Strings.resx)
Add dotnet watch (1.0.0-preview2-final) to tools in project.json
Run dotnet restore
Run dotnet watch run

Expected result
dotnet watch working when having 1 or multiple resource files in the project.
Actual result
[DotNetWatcher] info: Running dotnet with the following arguments: run
[DotNetWatcher] info: dotnet process id: 1992
Unhandled Exception: System.AggregateException: One or more errors occurred. (One or more errors occurred. (Object reference not set to an instance of an object.)) ---> System.AggregateException: One or more errors occurred. (Object reference not set to an instance of an object.) ---> System.NullReferenceException: Object reference not set to an instance of an object.
   at Microsoft.DotNet.Watcher.Core.Internal.FileWatcher.<>c__DisplayClass7_0.<AddDirectoryWatcher>b__0(KeyValuePair`2 d)
   at System.Linq.Enumerable.WhereEnumerableIterator`1.MoveNext()
   at System.Linq.Enumerable.Any[TSource](IEnumerable`1 source)
   at Microsoft.DotNet.Watcher.Core.Internal.FileWatcher.AddDirectoryWatcher(String directory)
   at Microsoft.DotNet.Watcher.Core.Internal.ProjectWatcher.<WaitForChangeAsync>d__6.MoveNext()
--- End of stack trace from previous location where exception was thrown ---
   at System.Runtime.CompilerServices.TaskAwaiter.ThrowForNonSuccess(Task task)
   at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)
   at Microsoft.DotNet.Watcher.Core.DotNetWatcher.<WaitForProjectFileToChangeAsync>d__7.MoveNext()
   --- End of inner exception stack trace ---
   at System.Threading.Tasks.Task.WaitAll(Task[] tasks, Int32 millisecondsTimeout, CancellationToken cancellationToken)
   at Microsoft.DotNet.Watcher.Core.DotNetWatcher.<WatchAsync>d__6.MoveNext()
   --- End of inner exception stack trace ---
   at System.Threading.Tasks.Task.ThrowIfExceptional(Boolean includeTaskCanceledExceptions)
   at System.Threading.Tasks.Task.Wait(Int32 millisecondsTimeout, CancellationToken cancellationToken)
   at Microsoft.DotNet.Watcher.Tools.Program.<>c__DisplayClass3_0.<MainInternal>b__0()
   at Microsoft.Extensions.CommandLineUtils.CommandLineApplication.Execute(String[] args)
   at Microsoft.DotNet.Watcher.Tools.Program.MainInternal(String[] args, CancellationToken cancellationToken)
   at Microsoft.DotNet.Watcher.Tools.Program.Main(String[] args)

Further technical details

VS2015 Community Update 3
.NET Core 1.0.0 VS 2015 Tooling Preview 2
Windows 10 home x64

Thanks for reporting this. I can reproduce it.
Expect a fix soon.

Still having this problem.
  "tools": {
    "Microsoft.DotNet.Watcher.Tools": "1.0.0-*"
  },

Any ideas?

The fix is in 1.1.0. Unfortunately, 1.0.0 will always have that problem.

cc @natemcmaster

Thanks! I suggest updating the readme. ;)

This isn't yet available on NuGet, right?

It's on the nightly feed (myget/aspnetvnext)

I am really sorry but I can't find the right feed. Could you please post the feed URL on where I can find dotnet watch 1.1.0.

The latest versions are 1.0.0-preview3-*, not 1.1.0-*. The feeds are explained in https://github.com/aspnet/Home/wiki/NuGet-feeds.

Microsoft.DotNet.Watcher.Tools.1.0.0-preview3-22398 depends on Microsoft.NETCore.App.1.1.0-preview1-001100-00.  It seems to install it into packages dir, but then when running dotnet watch run, I get:

The specified framework 'Microsoft.NETCore.App', version '1.1.0-preview1-001100-00' was not found.

Check application dependencies and target a framework version installed at:
Alternatively, install the framework version '1.1.0-preview1-001100-00'.

How can I obtain this newer versions of SDK? I tried to use install script from https://github.com/dotnet/cli/tree/rel/1.0.0/scripts/obtain, but it cannot find this specific version.

@qbikez prerelease builds require a prerelease installation of the shared framework, which goes in %DOTNET_HOME/shared/Microsoft.NETCore.App directory. Installation of the nupkg isn't enough. Yes, this is confusing, and yes it is hard to get the 1.1.0 runtime preview right now. Slightly intentional as there are some big changes pending. To get the 1.1.0 shared fx, use the args: dotnet-install.ps1 -Channel release/1.1.0 -SharedRuntime -Version 1.1.0-preview1-001100-00. cref https://github.com/aspnet/KoreBuild/blob/142539693e5d9eb944e3be4a2b47921feb9b326b/build/KoreBuild.ps1#L58

@natemcmaster thanks, that's what I was looking for.


Error thrown before the start_time causes delta for end_time to fail

Error
1) test register user should fail when email address already taken and return error (Conduit.UsersTest)
     test/conduit/users/users_test.exs:69
     ** (FunctionClauseError) no function clause matching in Commanded.Middleware.Auditing.delta/1

     The following arguments were given to Commanded.Middleware.Auditing.delta/1:

%Commanded.Middleware.Pipeline{assigns: %{error: :validation_failure, error_reason: %{email: ["has already been taken"]}},
...

To Reproduce
Add commanded-audit-middleware to Conduit, and then run mix test.
Suggested Solution
Pattern Matching for delta
for when a delta does not yet have a start_time and error is already thrown.

The auditing middleware needs to be the first middleware defined in your router to ensure it gets executed before any other middleware can halt command dispatch.
Probably worth doing either or both of the following:

adding a note to the README;
add a check to the success/1 and failure/1 fuctions to ensure the audit middleware has been initialised (and log an error to warn users to define auditing middleware first)

Happy to accept a PR to help fix the issue.


INIT timer in the order of  30 or 60 seconds not taken into account,

Setting the INIT timer to a value such as a minute or half a minute does not seem to be taken into account.  From the code it seems like its capped to the netRTO.  Is this normal, lksctp does allow higher values.

Can you share the code you are using to configure the parameters? What is the netRTO?

I will double check this on my side, its possible that i am mistaken. Thank you.


Search: Internal Server Error

https://nuget-prod-1-v2searchwebsite.azurewebsites.net/search/query?q=&skip=0&take=100&sortBy=relevance&supportedFramework=net45|net45|net45|portable-net45%2Bwin|net45|portable-net45%2Bsl50%2Bwin%2Bwp80&feed=microsoftdotnet&luceneQuery=false&countOnly=true

@johnataylor Slightly related, but should we return an empty list of packages for an invalid query, or an "Invalid Request" status code?

Closing this one, as #2544 is closed too.


Fixed the behaviour of validate_user function

Closes: #1
Updated validations.py python script.
Fixed the behavior of validate_user function in validations.py.
Fixes #<issue_number_goes_here>

It's a good idea to open an issue first for discussion.

[ ] Tests pass
[ ] Appropriate changes to README are included in PR

@googlebot I signed it!


Tracebacks

Traceback (most recent call last):
  File "C:\Users\\Downloads\Compressed\chat-replay-downloader-1.0.2\tester.py", line 641, in <module>
    chat_messages = chat_downloader.get_chat_replay(
  File "C:\Users\\Downloads\Compressed\chat-replay-downloader-1.0.2\tester.py", line 565, in get_chat_replay
    return self.get_youtube_messages(match.group(1), start_time, end_time, message_type, chat_type, callback)
  File "C:\Users\\Downloads\Compressed\chat-replay-downloader-1.0.2\tester.py", line 408, in get_youtube_messages
    info = self.__get_live_info(continuation)
  File "C:\Users\r\Downloads\Compressed\chat-replay-downloader-1.0.2\tester.py", line 303, in __get_live_info
    return(self.__get_continuation_info(url))
  File "C:\Usersr\Downloads\Compressed\chat-replay-downloader-1.0.2\tester.py", line 307, in __get_continuation_info
    info = self.__session_get_json(url)
  File "C:\Users\Downloads\Compressed\chat-replay-downloader-1.0.2\tester.py", line 145, in __session_get_json
    return self.__session_get(url).json()
  File "C:\Users\\AppData\Local\Programs\Python\Python39\lib\site-packages\requests\models.py", line 900, in json
    return complexjson.loads(self.text, **kwargs)
  File "C:\Users\\AppData\Local\Programs\Python\Python39\lib\json\__init__.py", line 346, in loads
    return _default_decoder.decode(s)
  File "C:\Users\AppData\Local\Programs\Python\Python39\lib\json\decoder.py", line 337, in decode
    obj, end = self.raw_decode(s, idx=_w(s, 0).end())
  File "C:\Users\\AppData\Local\Programs\Python\Python39\lib\json\decoder.py", line 355, in raw_decode
    raise JSONDecodeError("Expecting value", s, err.value) from None
json.decoder.JSONDecodeError: Expecting value: line 1 column 1 (char 0)

C:\Users\\Downloads\Compressed\chat-replay-downloader-1.0.2>python tester.py -message_type all https://www.youtube.com/watch?v=jJ8EkajpnAo -output jJ8EkajpnAo3.txt
Traceback (most recent call last):
  File "C:\Users\\Downloads\Compressed\chat-replay-downloader-1.0.2\tester.py", line 641, in <module>
    chat_messages = chat_downloader.get_chat_replay(
  File "C:\Users\\Downloads\Compressed\chat-replay-downloader-1.0.2\tester.py", line 565, in get_chat_replay
    return self.get_youtube_messages(match.group(1), start_time, end_time, message_type, chat_type, callback)
  File "C:\Users\\Downloads\Compressed\chat-replay-downloader-1.0.2\tester.py", line 408, in get_youtube_messages
    info = self.__get_live_info(continuation)
  File "C:\UsersDownloads\Compressed\chat-replay-downloader-1.0.2\tester.py", line 303, in __get_live_info
    return(self.__get_continuation_info(url))
  File "C:\Users\Downloads\Compressed\chat-replay-downloader-1.0.2\tester.py", line 307, in __get_continuation_info
    info = self.__session_get_json(url)
  File "C:\Users\\Downloads\Compressed\chat-replay-downloader-1.0.2\tester.py", line 145, in __session_get_json
    return self.__session_get(url).json()
  File "C:\Users\\AppData\Local\Programs\Python\Python39\lib\site-packages\requests\models.py", line 900, in json
    return complexjson.loads(self.text, **kwargs)
  File "C:\Users\\AppData\Local\Programs\Python\Python39\lib\json\__init__.py", line 346, in loads
    return _default_decoder.decode(s)
  File "C:\Users\\AppData\Local\Programs\Python\Python39\lib\json\decoder.py", line 337, in decode
    obj, end = self.raw_decode(s, idx=_w(s, 0).end())
  File "C:\Users\\AppData\Local\Programs\Python\Python39\lib\json\decoder.py", line 355, in raw_decode
    raise JSONDecodeError("Expecting value", s, err.value) from None
json.decoder.JSONDecodeError: Expecting value: line 1 column 1 (char 0)

Try this version: https://pastebin.com/mZp2bJGE

Try this version: https://pastebin.com/mZp2bJGE

Hi there, please see this comment:.

Why does the script seem to be always connected / updated that its problem shifts from time to time?

As I have said before, the code does not automatically update on your end. You have to actually install it/update it manually (unless you have explicitly set a tool to synchronise with the repo)

The fact that Im getting the exact same error after reinstalling just shows that the older releases are connected to the newer ones. Why does this happen? Im genuinely confused and so tired of this. Using older releases just don't work anymore.

Yes I am aware of this now as seen in #48 . I am looking to get a fix out as soon as possible.

Hi there, please see this comment:.

Why does the script seem to be always connected / updated that its problem shifts from time to time?

As I have said before, the code does not automatically update on your end. You have to actually install it/update it manually (unless you have explicitly set a tool to synchronise with the repo)

The fact that Im getting the exact same error after reinstalling just shows that the older releases are connected to the newer ones. Why does this happen? Im genuinely confused and so tired of this. Using older releases just don't work anymore.

Yes I am aware of this now as seen in #48 . I am looking to get a fix out as soon as possible.

An update to those waiting:
I have found the problem and I will fix it as soon as possible.
In short, YouTube removed support for an endpoint which this tool (and many others) used to get chat. They removed https://www.youtube.com/live_chat_replay/get_live_chat_replay and are now using https://www.youtube.com/youtubei/v1/live_chat/get_live_chat_replay and https://www.youtube.com/youtubei/v1/live_chat/get_live_chat.

An update to those waiting:
I have found the problem and I will fix it as soon as possible.
In short, YouTube removed support for an endpoint which this tool (and many others) used to get chat. They removed https://www.youtube.com/live_chat_replay/get_live_chat_replay and are now using https://www.youtube.com/youtubei/v1/live_chat/get_live_chat_replay and https://www.youtube.com/youtubei/v1/live_chat/get_live_chat.

Try this version: https://pastebin.com/mZp2bJGE
Looks like it can't parse video data or either it's a problem on my connection.

An update to those waiting:

Alright, I'll settle with OBS for now. Thanks for responding.

Try this version: https://pastebin.com/mZp2bJGE
Looks like it can't parse video data or either it's a problem on my connection.

An update to those waiting:

Alright, I'll settle with OBS for now. Thanks for responding.

An update to those waiting:
I have found the problem and I will fix it as soon as possible.
In short, YouTube removed support for an endpoint which this tool (and many others) used to get chat. They removed https://www.youtube.com/live_chat_replay/get_live_chat_replay and are now using https://www.youtube.com/youtubei/v1/live_chat/get_live_chat_replay and https://www.youtube.com/youtubei/v1/live_chat/get_live_chat.

Thanks. Replacement on line 300:
format ('live_chat_replay', 'get_live_chat_replay')
on
format ('live_chat', 'get_live_chat_replay')
Solved my problem.

An update to those waiting:
I have found the problem and I will fix it as soon as possible.
In short, YouTube removed support for an endpoint which this tool (and many others) used to get chat. They removed https://www.youtube.com/live_chat_replay/get_live_chat_replay and are now using https://www.youtube.com/youtubei/v1/live_chat/get_live_chat_replay and https://www.youtube.com/youtubei/v1/live_chat/get_live_chat.

Thanks. Replacement on line 300:
format ('live_chat_replay', 'get_live_chat_replay')
on
format ('live_chat', 'get_live_chat_replay')
Solved my problem.

Alright - I've been working a lot recently to get an updated/fixed version out for you all to use and test... and I think the package branch is ready for use. I still need to add a lot of documentation, but this will be much more useful than the current version in master (which doesn't work currently due to YouTube API endpoint changes).
This version is much more advanced than the original version. Some of the options are slightly different from version 1, but the help command (chat_replay_downloader -h) should assist you in the meantime while I write better documentation.
You can install it using pip install chat-replay-downloader (see https://pypi.org/project/chat-replay-downloader/ for more info).
Please let me know your thoughts and feel free to give suggestions! You can always post an issue or even create a pull request.

Alright - I've been working a lot recently to get an updated/fixed version out for you all to use and test... and I think the package branch is ready for use. I still need to add a lot of documentation, but this will be much more useful than the current version in master (which doesn't work currently due to YouTube API endpoint changes).
This version is much more advanced than the original version. Some of the options are slightly different from version 1, but the help command (chat_replay_downloader -h) should assist you in the meantime while I write better documentation.
You can install it using pip install chat-replay-downloader (see https://pypi.org/project/chat-replay-downloader/ for more info).
Please let me know your thoughts and feel free to give suggestions! You can always post an issue or even create a pull request.

ModuleNotFoundError: No module named 'docstring_parser'

ModuleNotFoundError: No module named 'docstring_parser'

  File "C:\Users\x\Downloads\chat-replay-downloader-master\chat_replay_downloader\tester.py", line 8, in <module>
    from .sites.common import SiteDefault
ImportError: attempted relative import with no known parent package

Similar error here.

  File "C:\Users\x\Downloads\chat-replay-downloader-master\chat_replay_downloader\tester.py", line 8, in <module>
    from .sites.common import SiteDefault
ImportError: attempted relative import with no known parent package

Similar error here.

ModuleNotFoundError: No module named 'docstring_parser'
FWIW-- if I run chat-replay-dwnloader -h I get
ImportError: attempted relative import with no known parent package

  File "C:\Users\x\Downloads\chat-replay-downloader-master\chat_replay_downloader\tester.py", line 8, in <module>
    from .sites.common import SiteDefault
ImportError: attempted relative import with no known parent package

Similar error here.

Did you run it in the correct way?
The project now uses python packaging. This means there are a number of ways to use it:

pip install chat-replay-downloader will download it from the python packaging index. You can then use it as chat_replay_downloader from any location on your computer.
If you downloaded the repository (i.e. if you want to see the source code), you can do make install inside the project's root folder. You can then use it as above.
If you have installed all the dependencies (i.e. using pip install <x>), you can even run it as python -m chat_replay_downloader inside the root folder)

ModuleNotFoundError: No module named 'docstring_parser'
FWIW-- if I run chat-replay-dwnloader -h I get
ImportError: attempted relative import with no known parent package

  File "C:\Users\x\Downloads\chat-replay-downloader-master\chat_replay_downloader\tester.py", line 8, in <module>
    from .sites.common import SiteDefault
ImportError: attempted relative import with no known parent package

Similar error here.

Did you run it in the correct way?
The project now uses python packaging. This means there are a number of ways to use it:

pip install chat-replay-downloader will download it from the python packaging index. You can then use it as chat_replay_downloader from any location on your computer.
If you downloaded the repository (i.e. if you want to see the source code), you can do make install inside the project's root folder. You can then use it as above.
If you have installed all the dependencies (i.e. using pip install <x>), you can even run it as python -m chat_replay_downloader inside the root folder)

Alright, it works. I should've followed that pip install instead of running it for requirements only. Thanks a lot for the fix!

Alright, it works. I should've followed that pip install instead of running it for requirements only. Thanks a lot for the fix!

Alright, it works. I should've followed that pip install instead of running it for requirements only. Thanks a lot for the fix!

No problem! Glad to finally get this updated version out.

Alright, it works. I should've followed that pip install instead of running it for requirements only. Thanks a lot for the fix!

No problem! Glad to finally get this updated version out.

Thanks! I've got it working now, I was missing a dependency. Really like this version!

Thanks! I've got it working now, I was missing a dependency. Really like this version!

Thanks! I've got it working now, I was missing a dependency. Really like this version!

Awesome! Really glad to hear that! I am also writing better documentation as we speak.

Thanks! I've got it working now, I was missing a dependency. Really like this version!

Awesome! Really glad to hear that! I am also writing better documentation as we speak.


Endpoint inconsistency

Hi,
thanks for the great work!
I found an inconsistency regarding endpoint configuration: In the descriptor the EPs are configured as BULK, in USBD_MIDI_Init however they are opened as Type Interrupt.
Kind regards,
Moe

I see. This could be the reason of that Double Buffering issue...
Could you please confirm that replacing USBD_EP_TYPE_INTR with USBD_EP_TYPE_BULK in USBD_MIDI_Init -> USBD_LL_OpenEP calls does not brake anything?

Anyway. Have checked it on the device and seems no issues so far. Did the commit


ICCID length wrong in ME310_AT_Test?

Hello,
Working with the example ME310_AT_Test it appears the display of the ICCID is truncated by one character.
https://github.com/telit/arduino-me310-library/blob/main/examples/ME310_AT_Test/ME310_AT_Test.ino#L130
On this line only the first 19 characters are being displayed, but the ICCIDs are 20 characters.

Hello,
as a matter of fact, ICCIDs can be also 19 characters, but the demo should be able to manage both. We will change this in a future release to cut the real length.


Add option to disable day headers completely.

I have the widget configured to only display my agenda for the day, and I found the date headers only take up additional space without really adding any new information. So, I added an option to remove them. This is primarily something I made for myself, but figured other people might be interested too

Hello @SimenCodes , thank you for the contribution.
I see these problems though that need to be fixed:

Please rename in your changes all names/references etc. of "day entries" to "day headers" to avoid confusion.
Tests are broken now. Please fix them.  (To launch tests locally in "Android Studio" right-click on the app\calendar-widget\src\androidTest\java folder and select "Run All tests" menu item...)

Hi @yvolk, thanks for the feedback. Have updated all references to "day headers" now, and added the missing JSON value to make the tests run again.

@SimenCodes Please look how your feature works with the new "Single line layout" https://github.com/plusonelabs/calendar-widget/issues/42#issuecomment-289261236


Track AHB buffers with userfaultfd

Although original page guard memory tracking method (mprotect) is tracking imported AHB buffers, the initial userfaultfd commit did not add support for them.
With this commit imported AHB buffer are now tracked with the userfaultfd method too.
However there is a caveat:
Userfaultfd requires that both base address and length of registered memory regions to be paged aligned. Since in the case of imported buffers we cannot back the regions with a shadow memory (we cannot intercept their allocation and return a shadow pointer instead of the original one), when registering the buffer to uffd we need to page align both base address and length. This can effectively extend the tracking to memory that is not inside the actual buffer and can lead to undefined behavior. A warning message is printed if such a case is detected.

CI gfxreconstruct build queued with queue ID 162529.

CI gfxreconstruct build # 3964 running.

CI gfxreconstruct build # 3965 running.

CI gfxreconstruct build # 3965 passed.

CI gfxreconstruct build queued with queue ID 162887.

CI gfxreconstruct build # 3970 running.

CI gfxreconstruct build # 3970 passed.


Failed to compute path to baseline file during test run spec construction"

Originally posted by @Blackjacx in https://github.com/fastlane/fastlane/issues/18748#issuecomment-913053871
Experiencing this today.

Thanks for the information, I will try to figure it out for more. Keep sharing such informative post keep suggesting such post.


Adding University of Jamestown (uj.edu)

This request is to add edu/uj.txt to domains. The school is the University of Jamestown, which is located in Jamestown, North Dakota. Students will initially use WebStorm for this course: https://uj.smartcatalogiq.com/en/2024-2025/2024-2025-undergraduate-catalog/courses/tech-technology/400/tech-441/. The uj.edu domain is used by the university for all student email accounts. Thanks!

@tsnjcg Thank you for your patience while waiting for a review and processing your request. Pull request merged. Please start applying for JetBrains educational subscription at https://www.jetbrains.com/shop/eform/students in an hour, to allow the changes to propagate through JetBrains systems.


Add jupyterlab-git

https://github.com/jupyterlab/jupyterlab-git is a nice
complement to gh-scoped-creds
See also https://github.com/2i2c-org/infrastructure/issues/1329#issuecomment-1140123852

/cc @fperez

/condalock
this command was failing earlier b/c of some pytorch environment solving issues that hopefully were fixed by #340

/condalock
trying again...


feat(metadata): cache label sets

1 cache per profiler (key: pid, value: labelSet)
lazy caching happens when profiler requests labels
no caching happens when request comes from UI as:

this does not happen often
this would require convention from label.Labels to model.LabelSet
UI requests labels for all processes on the system, they are not all profiled if idled, which would unnecessarily inflate the cache

all caches are invalidated on config reload
cache keys for individual PIDs are invalidated on updates from service discovery (via a hook function)
otherwise, cache keys expire if not accessed for more than 10 minutes

Closes #890

Hi! Thanks for the PR! Will take a look later today

I have been checking why actually the PR is failing, but I don't have any reasonable explanations. We haven't changed anything concerning secrets. Yet the container action fails.

@kakkoyun please #934 for the CI, we'll ignore that until fixed
@javierhonduco do you still want to add a review?
Something came to my mind, I need to add a read lock when calling the hooks

@maxbrunet Thanks for the context. I was about to go nuts 😅
I'm happy to merge this if others are okay as well.

LGTM! Will let it bake for 1 day in the demo environment

Have you deployed it? Or shall we merge and deploy a version?

@kakkoyun Meant to do this once we merge it :)

One small comment about something we need to revisit in the Agent as a whole is that caching PIDs can be problematic due to them being reused.
We don't have to tackle this in this PR but it's something that we should be aware of

One small comment about something we need to revisit in the Agent as a whole is that caching PIDs can be problematic due to them being reused.

We should be able to add the starttime field of /proc/[pid]/stat to the cache key: awk '{print $23}' "/proc/${pid}/stat"

One small comment about something we need to revisit in the Agent as a whole is that caching PIDs can be problematic due to them being reused.

We should be able to add the starttime field of /proc/[pid]/stat to the cache key: awk '{print $23}' "/proc/${pid}/stat"
https://pkg.go.dev/github.com/prometheus/procfs#ProcStat.StartTime

It's a good idea!


Lab 2 Ex 1 Task 6 - Missing Step or Incorrect Screenshot

Module: 3
Lab: 2
Exercise 1: Load Data, Task 6: Configure the Region query
Step 5: In the status bar, verify that the query has four columns and 10 rows.
Description of issue
There are 11 rows in the Region query. There should be (or once was) a step to filter Corporate HQ from the Group column. That step is gone. Step 5 indicates that there should be four columns and 10 rows but since that row is not filtered out, there are four columns and 11 rows.
Proposed fix
Add a step to exclude Corporate HQ from the Group column. The solution file for Lab 2 is correct - a step to Keep Rows where SalesTerritoryAlternateKey does not equal 0 Is in present in PQ, which makes the number of rows 10, as per the screenshot.
Workaround
Have students filter to exclude Corporate HQ from the Group column to make the number of rows 10, as per the screenshot.

Thanks @jamarx2 , echoeing the issue

Thank you for this catch. We will apply bug fixes by end of next week.

This has been updated in the latest PR.


You can't click the text field on  in the editor...and there's other bugs aswell.

Challenge Create a Form Element has an issue.
User Agent is: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:52.0) Gecko/20100101 Firefox/52.0.
Please describe how to reproduce this issue, and include links to screenshots if possible.
My code:

<link href="https://fonts.googleapis.com/css?family=Lobster" rel="stylesheet" type="text/css">

CatPhotoApp

Click here for cat photos.

Things cats love:

cat nip

laser pointers

lasagna

Top 3 things cats hate:

flea treatment

thunder

other cats

<form action=" /submit-cat-photo"> <input type="text" placeholder="cat photo URL"> </form>

@gbzaid I tried your code on Firefox version 52.0.2 and I was able to click and write text into the input text field. Maybe you meant something else?
Also, there is an issue with your code by the way. There is a space character here:
<form action=" /submit-cat-photo"> <input type="text" placeholder="cat photo URL"> </form>

And because of that, the second test is failing. If your remove that space and write something like this:
<form action="/submit-cat-photo"> <input type="text" placeholder="cat photo URL"> </form>

The test passes.

CatPhotoApp
Click here for cat photos.

Things cats love:

cat nip
laser pointers
lasagna

Top 3 things cats hate:

flea treatment
thunder
other cats

This is the working code.

thanks for the report, and we confirm that this is a known issue, check #13727
Closing as a duplicate.


CTFE regression 7197 enum string doesn't work with CTFE

7197 enum string doesn't work with CTFE
This wasn't actually a bug in CTFE at all, it was caused by some erroneous code in the const folding for comma expressions. The new asserts and error checking in CTFE have detected it, but it's been incorrect for a long time.
I originally introduced that CommaExp code while fixing bug 3535, it was a workaround for another problem which has since been fixed.

Reminder: please make sure the string "fix issue 7197" is in the commit message! (It makes my life a little easier.) Thanks!

The commit messages included "Fixes bug 7197". The regexp Brad sent
around implied that should work too. Did it not work?
On 27 January 2012 09:54, Walter Bright
<EMAIL_ADDRESS>wrote:

Reminder: please make sure the string "fix issue 7197" is in the commit message! (It makes my life a little easier.) Thanks!

Reply to this email directly or view it on GitHub:
https://github.com/D-Programming-Language/dmd/pull/643#issuecomment-3683792

It did work, my mistake.
On 1/27/2012 12:56 AM, Don Clugston wrote:

The commit messages included "Fixes bug 7197". The regexp Brad sent
around implied that should work too. Did it not work?
On 27 January 2012 09:54, Walter Bright
<EMAIL_ADDRESS>wrote:

Reminder: please make sure the string "fix issue 7197" is in the commit message! (It makes my life a little easier.) Thanks!


remove the 'default tz optimization' from JodaDateTimeSerializer

My attempt to close https://github.com/magro/kryo-serializers/issues/30

removed the DateTimeZone.getDefault() check from write()
removed the tz == null check from write because JodaDateTimes are defined as always having a zone (DateTimeZone.getDefault() if none is set explicitly)
left a special case for "" in read() to support older clients

HTH :)

relevant snippets from org.joda.time.DateTime:
   ...
    /**
     * Constructs an instance set to the current system millisecond time
     * using ISOChronology in the default time zone.
     */
    public DateTime() {
        super();
    }
   ...
    /**
     * Constructs an instance set to the current system millisecond time
     * using the specified chronology.
     *

     * If the chronology is null, ISOChronology
     * in the default time zone is used.
     *
     * @param chronology  the chronology, null means ISOChronology in default zone
     */
    public DateTime(Chronology chronology) {
        super(chronology);
    }
   ...
    /**
     * Gets the time zone of the instant from the chronology.
     *
     * @return the DateTimeZone that the instant is using, *never null*
     */
    public DateTimeZone getZone() {
        return getChronology().getZone();
    }

Great, thanks for the PR! Do you need this to be released soon?

no pressure, we're doing the same locally already, would just be nicer to tell our callers to use your lib instead of telling them to copy&paste our Serializer :)

Ok, released as 0.36 :-)

wow, thanks :)


Add allergies exercise

Using parseAllergen here is probably not as performant as directly capitalizing the lower-case string to convert to an Allergen, but it does make allergicTo more declarative while keeping the parsing logic flexible. Open to any other ideas.

@Nezteb, since there was already an ongoing review, I'm pinging you for a look-over.
Here are some comments to help you.
Per https://exercism.org/docs/building/tracks/practice-exercises#h-file-tests, all tests except the first should be skipped. In mfoda's earlier commits, they weren't skipping the first test in each describe after the first describe. My edit contradicts David's earlier suggestion but it's more in line with the guidance at least nowadays.
I also removed the class setup since it's not necessary here. That gives students more flexibility in how they want to solve exercises and can allow for more interesting angles for Haxe mentors.  mfoda already resolved David's earlier concerns with a class constructor so this part falls outside that review.
As for mfoda's performance concern, the example file for a practice exercise s only used for CI purposes and won't be public-facing. I didn't check how slow it ran, but unless it's a clear performance issue, I'm not too concerned. With how many exercises we have, the CI speed won't be blazing fast.

I'll need to fix the difficulty on this exercise as well before we merge it in.


uninstall fails

==> Removing Homebrew installation...
/usr/bin/find: unknown predicate `-E'
Warning: Failed during: /usr/bin/find -E /home/bob/.linuxbrew/bin /home/bob/.linuxbrew/etc /home/bob/.linuxbrew/share -regex .*/info/([^.][^/]*.info|dir) -exec /bin/bash -c /usr/bin/install-info\ --delete\ --quiet\ {}\ "$(dirname\ {})/dir" ;
==> Removing empty directories...
rmdir: failed to remove '/home/bob/.linuxbrew': Directory not empty
Warning: Homebrew partially uninstalled (but there were steps that failed)!
To finish uninstalling rerun this script with `sudo`.
The following possible Homebrew files were not deleted:
/home/bob/.linuxbrew/docker.test.yml
rmdir: failed to remove '/home/bob/.linuxbrew'/home/bob/.linuxbrew/lib64 -> /home/bob/.linuxbrew/lib
: Directory not empty/home/bob/.linuxbrew/Dockerfile
You may consider to remove them by yourself.

This might be invalid (i.e. my fault), but reporting it here just in case.

It's a bug. uninstall has not ever been fixed up to work on Linuxbrew.

     -E      Interpret regular expressions followed by -regex and -iregex pri-
             maries as extended (modern) regular expressions rather than basic
             regular expressions (BRE's).  The re_format(7) manual page fully
             describes both formats.

@sjackman, did you fix this issue with https://github.com/Linuxbrew/install/commit/44a44a83c9218c73e1f0a401c508e7f42e16e2c0 ?

Yep!


Use a filter for escaping HTML

It's cumbersome to do this manually: https://github.com/angular/angular.io/blob/master/public/docs/js/latest/guide/displaying-data.jade#L149-L155
Jade docs: http://jade-lang.com/reference/filters/

Yes, please.

+1 we'll have to create our own custom filter. Haven't found a good one for this yet.

https://angular.io/docs/styleguide.html
Added to code examples now in styleguide :)


Documentation on how to use OpenDSE

Hi,
I've not been able to get anything to really run from the documentation here https://sdarg.github.io/opendse/documentation/SNAPSHOT-20210324/tutorial.xhtml
Is there anywhere else where using the tool is documented at all. The tutorial code makes sense reading it but how does one actually run it?
Cheers

Dear Alex,
I think what you are looking for is this part of the tutorial where you launch an actual optimization using OpenDSE and Opt4J:  https://sdarg.github.io/opendse/documentation/SNAPSHOT-20210324/part6.xhtml
I've spotted two current problems with the tutorial which I'm gonna mark as bugs in the tracker:

Please use: ./gradlew run within the top folder instead of just gradle to ensure you get the correct gradle wrapper and make sure to use a suitable Java RE (currently Java 11 is recommended)
The link to an example configuration to be loaded as shown in Part 6 is currently broken. I attached a respective file for you that you can load into the Opt4J GUI and run.

Best, Michael

Hi Michael,
thanks for your reply. This helped a lot getting a demo with the GUI running! I was able to get the other Tutorial code running by adding
 import org.apache.tools.ant.filters.*
 import java.util.regex.*

+apply plugin: 'application'
+
 dependencies {
        compile project(':opendse-optimization')
        compile project(':opendse-realtime')
@@ -61,4 +63,6 @@ task copyWebsite(type: Copy, dependsOn: [filterSources, filterXML]) {
                exclude '**/*properties'
        }
        into 'build/website/documentation/'+version
-}
\ No newline at end of file
+}
+
+mainClassName = 'net.sf.opendse.tutorial.Part1'

This is what I was more interested in, was just a bit tricky as I've had zero exposure to Gradle until now :D


Support i386 architecture

Problem/Motivation
I'm running Home Assistant on my old netbook lying around with an atom processor. Looking at the specs it would be 3 times as powerful as a Raspberry Pi 3. I have a container for running ffmpeg RTSP to HLS to get audio feeds from security camera to Google Home Minis but it keeps stopping for some unknown reason so would be good to diagnose or restart it. I've heard about portainer on the Hass.io podcast which looks brilliant. What are the issues in supporting i386 architecture? If you're using the latest Docker CE, then that would be why since docker dropped support for i386 (boo!) In the end I used the legacy docker-io package on ubuntu which seems to be working.
Expected behavior
Install on my i386 netbook
Actual behavior
Can't install on the i386 netbook
Steps to reproduce

Install docker-io on a i386 machine
Install Hass.io on it
Try to install add on

Proposed changes
Perhaps define a different docker version/package/implementation so I could point it to use docker-io? If it's not possible don't worry.

Hmm, so the problem is the core portainer itself doesn't support i386 because of docker CE dropping support. See related https://github.com/portainer/portainer/issues/618


xbanish: 1.6 -> 1.7

Semi-automatic update generated by nixpkgs-update tools. This update was made based on information from https://repology.org/metapackage/xbanish/versions.
meta.description for xbanish is: "Hides mouse pointer while not in use"
meta.homepage for xbanish is: ""
Updates performed

Version update

To inspect upstream changes

Compare changes on GitHub

Impact

Checks done (click to expand)

built on NixOS

The tests defined in passthru.tests, if any, passed

0 of 0 passed binary check by having a zero exit code.

0 of 0 passed binary check by having the new version present in output.

found 1.7 with grep in /nix/store/g6l6q8j25mhxzca02p5xwk8vzvqhyz8z-xbanish-1.7

directory tree listing: https://gist.github.com/ea8b2d4c17e090f99461a72628719f97

du listing: https://gist.github.com/833882e5643775acd61b927ef88726d9

Rebuild report (if merged into master) (click to expand)

3 total rebuild path(s)

1 package rebuild(s)

1 x86_64-linux rebuild(s)
1 i686-linux rebuild(s)
0 x86_64-darwin rebuild(s)
1 aarch64-linux rebuild(s)

First fifty rebuilds by attrpath
xbanish

Instructions to test this update (click to expand)

Either download from Cachix:
nix-store -r /nix/store/g6l6q8j25mhxzca02p5xwk8vzvqhyz8z-xbanish-1.7 \
  --option binary-caches 'https://cache.nixos.org/ https://r-ryantm.cachix.org/' \
  --option trusted-public-keys '
  r-ryantm.cachix.org-1:gkUbLkouDAyvBdpBX0JOdIiD2/DP1ldF3Z3Y6Gqcc4c=
  cache.nixos.org-1:6NCHdD59X431o0gWypbMrAURkbJ16ZPMQFGspcDShjY=
  '

(r-ryantm's Cachix cache is only trusted for this store-path realization.)
For the Cachix download to work, your user must be in the trusted-users list or you can use sudo since root is effectively trusted.
Or, build yourself:
nix-build -A xbanish https://github.com/r-ryantm/nixpkgs/archive/57eb45f19e00bdd46c595056407776e1f6676ef5.tar.gz

After you've downloaded or built it, look at the files and if there are any, run the binaries:
ls -la /nix/store/g6l6q8j25mhxzca02p5xwk8vzvqhyz8z-xbanish-1.7
ls -la /nix/store/g6l6q8j25mhxzca02p5xwk8vzvqhyz8z-xbanish-1.7/bin

Pre-merge build results
We have automatically built all packages that will get rebuilt due to
this change.
This gives evidence on whether the upgrade will break dependent packages.
Note sometimes packages show up as failed to build independent of the
change, simply because they are already broken on the target branch.
Result of nixpkgs-review 1

1 package built:
- xbanish

Maintainer pings
cc @choochootrain for testing.

i don't have a nixos setup at the moment, care to test @bricewge? 😄


[management] convert ed25519 to x25519 keys using pub -> pub and pri -> pri

the dream!

@bors-libra r=joshlind

:pushpin: Commit 20abf24 has been approved by joshlind

:hourglass: Testing commit 20abf242126494a0cb77c4e1240c4370f0fa2817 with merge 92d181dba4179c2418605fdf908718edd0350560...

:sunny: Test successful - checks-actions_land_blocking_test, checks-circle_commit_workflow
Approved by: joshlind
Pushing 92d181dba4179c2418605fdf908718edd0350560 to master...


Get Fails With No Delay Before

Why does this fail (with not await before)
Response response = await dio.get("$baseRoute/clients");
var list = response.data;
for (var item in list) {
clients.add(ClientModel.fromJson(item));
}
And this Works (has an async function before)
// Delay
await SomeCodeAsync();
Response response = await dio.get("$baseRoute/clients");
var list = response.data;
for (var item in list) {
clients.add(ClientModel.fromJson(item));
}

await must be used  inside async  function . could you paste the full code?
:octocat: From gitme Android

I am no longer using this package as it is has more issues than using the httpClient in Dart directly. Requests that work fine using the httpClient fails with Dio.


Cryptic VTL error message

I'm getting the following error in AppSync Query response:
{
  "data": {
    "account": null
  },
  "errors": [
    {
      "path": [
        "account"
      ],
      "data": null,
      "errorType": "MappingTemplate",
      "errorInfo": null,
      "locations": [
        {
          "line": 2,
          "column": 3,
          "sourceName": null
        }
      ],
      "message": "Encountered \"in\" at velocity[line 7, column 30]\nWas expecting one of:\n    <RPAREN> ...\n    \"-\" ...\n    \"+\" ...\n    \"*\" ...\n    \"/\" ...\n    \"%\" ...\n    <LOGICAL_AND> ...\n    <LOGICAL_OR> ...\n    <LOGICAL_LT> ...\n    <LOGICAL_LE> ...\n    <LOGICAL_GT> ...\n    <LOGICAL_GE> ...\n    <LOGICAL_EQUALS> ...\n    <LOGICAL_NOT_EQUALS> ...\n    "
    }
  ]
}

Here is the resolver I hooked up to this:
const resolver = new AppsyncResolver(($context) => {
      const identity = $context.identity;
      let accountId = 'barfoo';
      let apiKey = 'foobar';
      if (identity && 'resolverContext' in identity) {
        accountId = identity.resolverContext.accountId;
        apiKey = identity.resolverContext.apiKey;
      }

      console.log('USER: accountId: ', accountId);
      console.log('USER: apiKey: ', apiKey);

      if (!accountId && !apiKey)
        $util.error('AccountId and ApiKey must be non-empty');

      return table.getItem({
        key: {
          PK: { S: accountId },
          SK: { S: apiKey },
        },
      });
    });

And this is the CloudWatch log entry:
{
    "logType": "RequestMapping",
    "path": [
        "account"
    ],
    "fieldName": "account",
    "resolverArn": "arn:aws:appsync:us-east-1:435193165691:apis/wc5qtkxi6bhndnb6fqhb3kah3m/types/Query/resolvers/account",
    "functionName": "Table_getItem",
    "requestId": "3450dde7-3cb7-4aeb-bfa9-a4e2ba7b5cb8",
    "context": {
        "arguments": {},
        "prev": {
            "result": {}
        },
        "stash": {},
        "outErrors": []
    },
    "fieldInError": true,
    "errors": [
        "Unable to transform the request mapping template."
    ],
    "parentType": "Query",
    "graphQLAPIId": "wc5qtkxi6bhndnb6fqhb3kah3m",
    "functionArn": "arn:aws:appsync:us-east-1:435193165691:apis/wc5qtkxi6bhndnb6fqhb3kah3m/functions/llq46pckvngsndzdhq5xyeqrre"
}

I removed the call to table.getItem(). It's roughly the same error, but with a different line number.
{
    "logType": "ResponseMapping",
    "path": [
        "account"
    ],
    "fieldName": "account",
    "resolverArn": "arn:aws:appsync:us-east-1:435193165691:apis/wc5qtkxi6bhndnb6fqhb3kah3m/types/Query/resolvers/account",
    "requestId": "7cea8886-c713-46f3-95db-5bc2cefb8772",
    "context": {
        "arguments": {},
        "stash": {},
        "outErrors": []
    },
    "fieldInError": true,
    "errors": [
        "Encountered \"in\" at velocity[line 4, column 30]\nWas expecting one of:\n    <RPAREN> ...\n    \"-\" ...\n    \"+\" ...\n    \"*\" ...\n    \"/\" ...\n    \"%\" ...\n    <LOGICAL_AND> ...\n    <LOGICAL_OR> ...\n    <LOGICAL_LT> ...\n    <LOGICAL_LE> ...\n    <LOGICAL_GT> ...\n    <LOGICAL_GE> ...\n    <LOGICAL_EQUALS> ...\n    <LOGICAL_NOT_EQUALS> ...\n    "
    ],
    "parentType": "Query",
    "graphQLAPIId": "wc5qtkxi6bhndnb6fqhb3kah3m"
}

#set($v1 = 'resolverContext' in $context.stash.identity)

https://github.com/thantos/functionless/blob/main/src/vtl.ts#L363
https://velocity.apache.org/engine/1.7/user-guide.html#foreach-loop
Looks like the 'resovlerContext' in is being miss-interpreted as a for loop.

Ah, ok. AppSync doesn't use tagged unions for $context.identity, so that's the only way to get that type. I'll try to cast it to any, instead.

Similar error... now complains about the equal sign.
{
  "data": {
    "account": null
  },
  "errors": [
    {
      "path": [
        "account"
      ],
      "data": null,
      "errorType": "MappingTemplate",
      "errorInfo": null,
      "locations": [
        {
          "line": 2,
          "column": 3,
          "sourceName": null
        }
      ],
      "message": "Encountered \"=\" at velocity[line 5, column 37]\nWas expecting one of:\n    <RPAREN> ...\n    \"-\" ...\n    \"+\" ...\n    \"*\" ...\n    \"/\" ...\n    \"%\" ...\n    <LOGICAL_AND> ...\n    <LOGICAL_OR> ...\n    <LOGICAL_LT> ...\n    <LOGICAL_LE> ...\n    <LOGICAL_GT> ...\n    <LOGICAL_GE> ...\n    <LOGICAL_EQUALS> ...\n    <LOGICAL_NOT_EQUALS> ...\n    "
    }
  ]
}

As an aside, can we include $util.log.info(Object) to the $util API?

Yeah, totally. I think log was released a few weeks ago. thanks for the PR, added some comments.

Can you share the code with =?
Looks like BinaryExpr simply prints left op right right now (thus the in issue, which isn't valid velocity).
I've tried a few samples that seem to work
test("binary expr == in if statement", () => {
  appsyncTestCase(
    reflect<ResolverFunction<{ key: string }, { out: string }, any>>(
      ($context) => {
        if ($context.arguments.key == "hello") {
          return { out: "ohh hi" };
        }
        return { out: "wot" };
      }
    ),
    {
      executeTemplates: [
        {
          index: 1,
          context: { arguments: { key: "hello" }, source: {} },
          match: { out: "ohh hi" },
        },
        {
          index: 1,
          context: { arguments: { key: "giddyup" }, source: {} },
          match: { out: "wot" },
        },
      ],
    }
  );
});

Found that obj.key = x doesn't work.

or +=

The code was something like this:
const identity = $context.identity as any;
const ctx = identity.resolverContext;
let accountId = 'barfoo';
let apiKey = 'foobar';
accountId = ctx.accountId;
apiKey = ctx.apiKey;

OK, that should be fixed here: https://github.com/functionless/functionless/pull/233

One of the tests is skipped.
On Sunday, June 12, 2022, Sam Sussman @.***> wrote:

OK, that should be fixed here: #233
https://github.com/functionless/functionless/pull/233
—
Reply to this email directly, view it on GitHub
https://github.com/functionless/functionless/issues/230#issuecomment-1153240368,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AABFAMAN7BEIP542LWJFZGLVOYMXJANCNFSM5YRWJPHA
.
You are receiving this because you authored the thread.Message ID:
@.***>


feat: run initial test using jest findRelatedTests

Resolves #1655

@nicojs done

Thx, I'll take a look next Monday

Took me a full week longer, but here it is 😅
This will be released with the next minor release, hopefully in a few days.


Relation does not exist in Deno Deploy sometimes

Steps to reproduce
Sometimes after fresh deployment to Deno Deploy my API is stucked with error relation "..." does not exist
I do nothing and after some time without any changes in code and configs it starts working again perfectly...
How it possible?.. I think the problem in the Deno Deploy and how they are sharing resources between lambdas, but their support doesn't help me :(
Maybe somebody has same problem?
Expected result
It should works fine
Actual result
It works bad sometimes
Environment
Deno Deploy
@neondatabase/serverless v0.9.3 from npm
Logs, links
error: error: relation "users" does not exist
    at sn.parseErrorMessage (file:///node_modules/.deno/@neondatabase+serverless@0.9.3/node_modules/@neondatabase/serverless/index.mjs:1182:6)
    at sn.handlePacket (file:///node_modules/.deno/@neondatabase+serverless@0.9.3/node_modules/@neondatabase/serverless/index.mjs:1143:13)
    at sn.parse (file:///node_modules/.deno/@neondatabase+serverless@0.9.3/node_modules/@neondatabase/serverless/index.mjs:1127:36)
    at E.<anonymous> (file:///node_modules/.deno/@neondatabase+serverless@0.9.3/node_modules/@neondatabase/serverless/index.mjs:1190:16)
    at E.emit (file:///node_modules/.deno/@neondatabase+serverless@0.9.3/node_modules/@neondatabase/serverless/index.mjs:397:12)
    at WebSocket.<anonymous> (file:///node_modules/.deno/@neondatabase+serverless@0.9.3/node_modules/@neondatabase/serverless/index.mjs:988:80)
    at innerInvokeEventListeners (ext:deno_web/02_event.js:754:7)
    at invokeEventListeners (ext:deno_web/02_event.js:801:5)
    at dispatch (ext:deno_web/02_event.js:658:9)
    at WebSocket.[[[eventLoop]]] (ext:deno_websocket/01_websocket.js:456:11)
Caused by error: relation "users" does not exist
    at sn.parseErrorMessage (file:///node_modules/.deno/@neondatabase+serverless@0.9.3/node_modules/@neondatabase/serverless/index.mjs:1182:6)
    at sn.handlePacket (file:///node_modules/.deno/@neondatabase+serverless@0.9.3/node_modules/@neondatabase/serverless/index.mjs:1143:13)
    at sn.parse (file:///node_modules/.deno/@neondatabase+serverless@0.9.3/node_modules/@neondatabase/serverless/index.mjs:1127:36)
    at E.<anonymous> (file:///node_modules/.deno/@neondatabase+serverless@0.9.3/node_modules/@neondatabase/serverless/index.mjs:1190:16)
    at E.emit (file:///node_modules/.deno/@neondatabase+serverless@0.9.3/node_modules/@neondatabase/serverless/index.mjs:397:12)
    at WebSocket.<anonymous> (file:///node_modules/.deno/@neondatabase+serverless@0.9.3/node_modules/@neondatabase/serverless/index.mjs:988:80)
    at innerInvokeEventListeners (ext:deno_web/0

Hmm, that's a surprising error to get only intermittently.
How are you making/reusing connections? On platforms such as Cloudflare Workers, it's important to connect, query and disconnect within your response function, since connections are not held open outside of one.
If you're not using interactive transactions and don't need node-postgres compatibility, you could also try switching to the driver's http transport (import { neon } from '@neondatabase/serverless) — check the README or docs.

Thanks for advice @jawj! I'm using Pool from @neondatabase/serverless because I need node-postgres compatibility. But maybe I'll try to rewrite my database driver for kysely beacuse my app don't use transactions at all...

What's the status of this now?


Run the test with MockitoJUnitRunner.

Codecov Report

Merging #456 into master will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##             master     #456   +/-   ##
=========================================
  Coverage     90.26%   90.26%
  Complexity      586      586
=========================================
  Files           104      104
  Lines          2127     2127
  Branches        206      206
=========================================
  Hits           1920     1920
  Misses          156      156
  Partials         51       51

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 36680d2...cc557d1. Read the comment docs.


upgrade to tilelive-s3 v3.3.0 to fix issue #47 node-pre-gyp errors

reference issue #47

Closing this. We are now at tilelive-s3 6.x series and things are working fine. Please re-open new PR if you hit any new problems.


Added Sample9 scenario related code

This pull request consists of code related to the sample scenario 9 - API Governance

Please send this to 2.x branch.


GH-41119: [Archery][Packaging][CI] Avoid using ARCHERY_DEBUG=1 on Windows wheels as --progress flag is not supported on Docker on Windows

Rationale for this change
Windows wheels are currently failing due to the change on ARCHERY_DEBUG=1 by default.
What changes are included in this PR?
Do not use ARCHERY_DEBUG=1 on the Windows builds.
Are these changes tested?
Yes on CI via archery.
Are there any user-facing changes?
No

GitHub Issue: #41119

@github-actions crossbow submit wheel-windows-*

@kou are you ok with this? This is needed for 16.0.0

Or can we remove --progress on Windows?

@github-actions crossbow submit wheel-windows-*

Or can we remove --progress on Windows?

@kou I've updated the PR to do that.

@github-actions crossbow submit wheel-windows-*


Uptake fast-foundation fixes and remove workaround

Pull Request
🤨 Rationale
Fixes #1661
👩💻 Implementation

Updated fast-foundation to 2.49.5
Removed bug workaround from anchor menu item

🧪 Testing
Verified issues fixed in Storybook.
✅ Checklist

[x] I have updated the project documentation to reflect my changes or determined no changes are needed.

The PR is still failing builds and looks like it was prematurely set to owners review, moving back to draft


migrate to new ci server

Oof, I should have read the fine print. Free tier doesn't cover mac

https://circleci.com/pricing/


HDX-10139 Adding a returnees endpoint

This PR adds a new endpoint for the returnees data.
Also included is a script, tools/endpoint_code_generator.py which generates the required code using supplied metadata. This is designed to ease the process of adding new endpoints. The generated code requires checking and currently the tests and yaml documentation files are not included.
Currently the pipeline for this data is not deployed so the endpoint returns no data.

@turnerm @alexandru-m-g this PR has been updated to use the 0.8.17 schema and is ready to merge.


Startup issues with ijavascript

Description:
If I want to use IJavascript in Hydrogen almost everytime the kernel won't properly start and only display the spinner. After restarting the IJavascript kernel everything works as expected.
This may be related to #584 and #88 but for me it only happens with IJavascript.
I guess this could be caused by a race condition where the sockets are not ready to receive the execute request.
If I change our startup script to
launchSpec(kernelSpec, spawnOptions)
    .then(({ config, connectionFile, spawn }) => {
      const kernel = new ZMQKernel(
        kernelSpec, grammar,
        config, connectionFile,
        spawn,
      );

      setTimeout(() => {
        this.setRunningKernelFor(grammar, kernel);

        this._executeStartupCode(kernel);

        if (onStarted) onStarted(kernel);
      }, 1000);
    });

the issue disappears.
Is it necessary to wait for the sockets to be connected?
@n-riesco @rgbkrk Any idea what else could cause this issue?
Steps to Reproduce:

Start fresh Atom instance
Run javascript file with IJavascript -> only see the spinner
Restart IJavascript kernel via statusbar -> everything works fine

Logs and Versions:
A failed kernel startup:

A successful kernel startup:

Versions:
macOS 10.12.2
$ atom --version
Atom    : 1.14.0-beta2
Electron: 1.3.13
Chrome  : 52.0.2743.82
Node    : 6.5.0

Whoa, seems like we should definitely handle the callback for when it's really connected - especially before we try to send any initial messages.

OMG! It looks like #88 is back (I really was hoping it'd go away with prebuilt zeromq).
Unfortunately, #88 is very hard to reproduce. I've just tried and I can't reproduce in a machine with:
$ apm --version
apm  1.12.9
npm  3.10.5
node 4.4.5
python 2.7.12
git 2.7.4

$ ijs --version
5.0.17

$ apm list | grep Hydrogen
├──<EMAIL_ADDRESS>
If I remember correctly from my experiments with #88, when #88 happens, the connect event never gets sent on the IO socket.
@lgeiger Does your fix work when you replace setTimeout with nextTick? If it doesn't, what's the minimum wait that works?

@lgeiger I missed the log messages in your first post. There is an unexpected stderr message in the IJavascript launcher.
Since I can't reproduce this issue. Please, could check whether replacing log("startupCallback:", this.startupCallback); here with log("startupCallback:", arguments.callee); fixes the issue for you?

Thanks for taking a look at this

Unfortunately, #88 is very hard to reproduce.

It happens for me approx. 80% of the time. A simple kernel restart fixes it but it's still annoying 😆

If I remember correctly from my experiments with #88, when #88 happens, the connect event never gets sent on the IO socket.

Based on the logs, the IO socket is connected (or at least emits a connected event)

Does your fix work when you replace setTimeout with nextTick? If it doesn't, what's the minimum wait that works?

Unfortunately not. Estimating the wait is also a bit tricky since the issue doesn't reproduce all the time. But 1s is definitely overkill.

replacing log("startupCallback:", this.startupCallback); here with log("startupCallback:", arguments.callee); fixes the issue for you?

Unfortunately this doesn't help either.

replacing log("startupCallback:", this.startupCallback); here with log("startupCallback:", arguments.callee); fixes the issue for you?

Unfortunately this doesn't help either.

Does it remove the stderr massage from the log?

Does it remove the stderr message from the log?

No, I get the same message from IJavascript.
Note that I only see the logs from IJavascript because I enabled them via process.env.DEBUG='*' and IJavascript logs them to stderr.

I get the same startup issue w/ IJavascript. I've noticed the issue does not occur when starting a kernel using the command palette 'hydrogen:select-kernel' ( before running any code ).
If I try to run/runAll and automatically start the kernel the issue occurs probably 2/3 of the time

@BenRussert Do you get any error message? If so, could you post here.
Also could you post the IJavascript version and the kernel spec you're using?
To list the kernel specs, run jupyter kernelspec list --json.

Here is a screenshare of the issue at the end I show the hydrogen:select-kernel command which allows everything to work as expected.
Below is my kernelspec:
{
  "kernelspecs": {
    "python3": {
      "resource_dir": "/home/ben/anaconda3/envs/benr/lib/python3.5/site-packages/ipykernel/resources",
      "spec": {
        "display_name": "Python 3",
        "env": {},
        "language": "python",
        "argv": [
          "/home/ben/anaconda3/envs/benr/bin/python",
          "-m",
          "ipykernel",
          "-f",
          "{connection_file}"
        ]
      }
    },
    "javascript": {
      "resource_dir": "/home/ben/.local/share/jupyter/kernels/javascript",
      "spec": {
        "display_name": "Javascript (Node.js)",
        "env": {},
        "language": "javascript",
        "argv": [
          "ijskernel",
          "{connection_file}",
          "--protocol=5.0"
        ]
      }
    },
    "julia-0.5": {
      "resource_dir": "/home/ben/.local/share/jupyter/kernels/julia-0.5",
      "spec": {
        "display_name": "Julia 0.5.0",
        "env": {},
        "language": "julia",
        "argv": [
          "/opt/julia5/bin/julia",
          "-i",
          "--startup-file=yes",
          "--color=yes",
          "/home/ben/.julia/v0.5/IJulia/src/kernel.jl",
          "{connection_file}"
        ]
      }
    },
    "python2": {
      "resource_dir": "/home/ben/.local/share/jupyter/kernels/python2",
      "spec": {
        "display_name": "Python 2",
        "env": {},
        "language": "python",
        "argv": [
          "/home/ben/anaconda3/envs/ipykernel_py2/bin/python",
          "-m",
          "ipykernel",
          "-f",
          "{connection_file}"
        ]
      }
    }
  }
}

@BenRussert Thanks for the log, it is really useful. The kernel spec is OK, but the atom log shows something unusual.
@lgeiger Have a look at Ben's video (at 1:00). The unusual thing I refer above is that:

Hydrogen invokes Kernel.execute before the shellSocket is logged as connected, which should be OK (that's what we use zmq is for), but it seems it isn't.
Hydrogen gets IO messages before the ioSocket is logged as connected (weird, but possible depending on the order of things being scheduled in the event loop).

At the time I was debugging #88, I tried to send kernel_info_request and wait for a reply before invoking Kernel.execute. This didn't fully resolve the problem (I could still see the occasional failure).
setTimeout (as you discuss above) could also work, but I'm afraid it'd be unreliable and fail sometimes.
The way I currently understand the Jupyter messing protocol is that:

synchronisation with the IOSocket is guaranteed by waiting for a execution_state: 'starting' (unfortunately, many kernels don't implement this message; e.g. IRKernel).
synchronisation with the ShellSocket could be achieved by sending kernel_info_request (but again, not every kernel implements it; e.g. IJulia).

I like the idea of waiting until zeromq reports that the sockets are connected. BTW, since zeromq uses zmq v4, I don't think we need a try block here any longer.

@BenRussert Thanks for the video. I can reproduce the same behavior.
@n-riesco Thanks for taking a closer look!

Hydrogen invokes Kernel.execute before the shellSocket is logged as connected, which should be OK (that's what we use zmq is for), but it seems it isn't.

Indeed that should be OK, a successful kernel start shows the same behavior. See the logs of a succesful start from above.

Hydrogen gets IO messages before the ioSocket is logged as connected (weird, but possible depending on the order of things being scheduled in the event loop).

I would agree with "weird but possible" 😄

setTimeout (as you discuss above) could also work, but I'm afraid it'd be unreliable and fail sometimes.

Yeah, I don't like this solution either since it seams to only happen for IJavascript (at least on my machine).

I like the idea of waiting until zeromq reports that the sockets are connected.

Definitely a thing we could try.

BTW, since zeromq uses zmq v4, I don't think we need a try block here any longer.

Thanks for pointing this out.

@BenRussert @lgeiger Just an idea:

does the problem disappear if you install the IJavascript kernel with ijs --ijs-spec-path=full?
does the kernel spec point to the same file you get when you run require("child_process").execSync("which ijskernel").toString(); in atom?

Thanks for the suggestions!

does the problem disappear if you install the IJavascript kernel with ijs --ijs-spec-path=full?

Unfortunately not 😕

does the kernel spec point to the same file you get when you run require("child_process").execSync("which ijskernel").toString(); in atom?

The kernelspec points to:
"javascript": {
  "resource_dir": "/Users/lukasgeiger/Library/Jupyter/kernels/javascript",
  "spec": {
    "language": "javascript",
    "display_name": "Javascript (Node.js)",
    "env": {},
    "argv": [
      "/usr/local/Cellar/node/7.7.3/bin/node",
      "/usr/local/lib/node_modules/ijavascript/lib/kernel.js",
      "{connection_file}",
      "--protocol=5.0"
   ]
}

which ijskernel returns /usr/local/bin/ijskernel which is a symlink to the file mentioned in the kernelspec.

@lgeiger It was a long shot, anyway. Thanks for testing.
What surprises me the most in this case is that unlike #88, IJavascript is able to send back some messages on the IOSocket, but not the result...
Does it happen regardless of the piece of code you execute?
Could you run the IJavascript tests (npm t) on that machine?

@n-riesco I've had similar results with a number of code samples. If you want me to run a particular snippet fire away and I'll try it out. I will run npm t after work in a few hours.
Just a shot in the dark: I notice @lgeiger is running node v7.x and I am on v6.x, in one of your comments above you mention v4.x, any potential issues here?

Could you run the IJavascript tests (npm t) on that machine?

Thanks for the hint! The tests totally fail on my machine. I don't know why I didn't tried this earlier 😄
Just realized that IJavascript doesn't use Travis, I try to reproduce it there and make a PR.

The test output on my machine is either https://travis-ci.org/lgeiger/ijavascript/jobs/213530248
or https://travis-ci.org/lgeiger/ijavascript/jobs/213530249.
The first output probably shows the problem described in this issue.

I get similar results as @lgeiger above when testing.

Fixed in #678 🚀


Move RPLidar library into its own process

The library isn't really compatible with our async code, we discussed putting it in a separate process and reading its data through a socket, which also allows us to use our socket interfaces made for isotpservers.

add a message for Lidar to protobuf (not in the oneof BusMessage)


Picking precision issue

Run the simple-style example
Zoom out so that all of the pins are lumped together.  Try and pick the top of the billboard, it fails to select.
If you continue to zoom in a little at a time, eventually you get close enough that the selection works.

You can always select the base of the image, it's only when selecting the top that there is a problem.

@bagnell perhaps this is a culling issue with the billboard's bounding sphere that becomes evident because of the pick frustum.

@mramato was this fixed when we fixed the billboard bounding sphere?  It seems to work okay for me now.

Yes, and what a glorious day it was!


bucket UI does not show all labels.

And we have more than this (:
cc @squat @kakkoyun @metalmatze

This is because compactor for internal use, uses block.NewReplicaLabelRemover(logger, dedupReplicaLabels),
I guess we need separate fetcher for this (:

Fixing


ft. reports the problem from within the ft util

We have a bunch of test assertions that, when they fail, only report the failure inside of the test function instead of the actual place things broke. Makes it almost useless for developer testing purposes. We need to do a better job reporting where the actual problem arose.

I use the message string of the assertion to make it easier to debug. It's not perfect but it makes it really easy to see which line failed in the test.
        ft.AssertEqual(t, adminuser.Username, "admin", "username does not match")
        ft.AssertEqual(t, adminuser.Password, "admin", "password does not match")
        ft.AssertTrue(t, fusa.ValidateUser("admin", "admin"), "validation failed")
        ft.AssertFalse(t, fusa.ValidateUser("notme", "admin"), "validation passed, expected failure")
        ft.AssertNotNil(t, err, "expected an error")
        ft.AssertTrue(t, strings.Contains(err.Error(), "directory is empty,"))
        ft.AssertNotNil(t, err, "should have gotten an error")
        ft.AssertTrue(t, strings.Contains(err.Error(), "no such file or directory"), "mismatch error message")
        ft.AssertEqual(t, user.GetType(), "user", "type doesn't match user")
        ft.AssertEqual(t, user.GetName(), user.Username, "get name and username do not match")
        ft.AssertTrue(t, handlerCalled, "handler not called")
        ft.AssertEqual(t, w.Code, http.StatusOK)
        ft.AssertFalse(t, handlerCalled, "handler called")
        ft.AssertEqual(t, w.Code, http.StatusUnauthorized)

https://play.golang.org/p/WZE3lItf8h
So it's possible to get where the call came from. We could probably figure it out.


remove attributes + sig

This PR removes the attributes and signature fields so default templates show all providers. This aims to increase decentralization of providers used and the stability of the provider set.

@boz will close this PR and reopen fresh one to alter files to anyof


Forbidden Error when i use docs/mse/index.html and main.js

Thanks for Andrey Semochkin(deepch) , it was solved in

you are cool.


don't re-deploy on domains:add. allow multple domains on command line. closes #1142

No test for multiple domains? For shame.

:)

Haha!


Failed to post to Medium

Returned error message below
"JSONDecodeError: Expecting value: line 1 column 1 (char 0)
Traceback (most recent call last):
File "C:\Users\mountboy\anaconda3\lib\site-packages\jupyter_to_medium\_bundler.py", line 37, in upload
data = publish(**kwargs)
File "C:\Users\mountboy\anaconda3\lib\site-packages\jupyter_to_medium\_publish_to_medium.py", line 300, in publish
p.main()
File "C:\Users\mountboy\anaconda3\lib\site-packages\jupyter_to_medium\_publish_to_medium.py", line 216, in main
self.author_id = self.get_author_id()
File "C:\Users\mountboy\anaconda3\lib\site-packages\jupyter_to_medium\_publish_to_medium.py", line 96, in get_author_id
return r.json()['data']['id']
File "C:\Users\mountboy\anaconda3\lib\site-packages\requests\models.py", line 900, in json
return complexjson.loads(self.text, **kwargs)
File "C:\Users\mountboy\anaconda3\lib\json\init.py", line 357, in loads
return _default_decoder.decode(s)
File "C:\Users\mountboy\anaconda3\lib\json\decoder.py", line 337, in decode
obj, end = self.raw_decode(s, idx=_w(s, 0).end())
File "C:\Users\mountboy\anaconda3\lib\json\decoder.py", line 355, in raw_decode
raise JSONDecodeError("Expecting value", s, err.value) from None
json.decoder.JSONDecodeError: Expecting value: line 1 column 1 (char 0)

Hi,
Yes I'm getting the same issue - I'm going to email Medium and see what the issue is. It seems like authentication is failing when trying to pull the author ID from the Medium API.
Will keep you updated,
Mark

Hi Mark,
Yes Its looks medium issue. I try to contact medium but there is another signing issue. Hope it will solve soon.  If you get any update please share it. Thank you!
Best regards,
Noro

It seems to be working now for me - how is it for you?
If working then pls close the issue otherwise I'll dig into it.
Thanks,
Mark

Yes, Its working.
best regards,
Noro

Hi there,
I get a similar error:
Failed to post to Medium

Returned error message below

"JSONDecodeError: Expecting value: line 1 column 1 (char 0)

Traceback (most recent call last):
File \"/home/apierre/Dev/tuto-frozenlake/.direnv/python-3.10.4/lib/python3.10/site-packages/requests/models.py\", line 971, in json
return complexjson.loads(self.text, **kwargs)
File \"/home/apierre/.pyenv/versions/3.10.4/lib/python3.10/json/__init__.py\", line 346, in loads
return _default_decoder.decode(s)
File \"/home/apierre/.pyenv/versions/3.10.4/lib/python3.10/json/decoder.py\", line 337, in decode
obj, end = self.raw_decode(s, idx=_w(s, 0).end())
File \"/home/apierre/.pyenv/versions/3.10.4/lib/python3.10/json/decoder.py\", line 355, in raw_decode
raise JSONDecodeError(\"Expecting value\", s, err.value) from None
json.decoder.JSONDecodeError: Expecting value: line 1 column 1 (char 0)

During handling of the above exception, another exception occurred:

Traceback (most recent call last):
File \"/home/apierre/Dev/tuto-frozenlake/.direnv/python-3.10.4/lib/python3.10/site-packages/jupyter_to_medium/_bundler.py\", line 71, in upload
data = publish(**kwargs)
File \"/home/apierre/Dev/tuto-frozenlake/.direnv/python-3.10.4/lib/python3.10/site-packages/jupyter_to_medium/_publish_to_medium.py\", line 449, in publish
p.main()
File \"/home/apierre/Dev/tuto-frozenlake/.direnv/python-3.10.4/lib/python3.10/site-packages/jupyter_to_medium/_publish_to_medium.py\", line 306, in main
self.author_id = self.get_author_id()
File \"/home/apierre/Dev/tuto-frozenlake/.direnv/python-3.10.4/lib/python3.10/site-packages/jupyter_to_medium/_publish_to_medium.py\", line 134, in get_author_id
return r.json()[\"data\"][\"id\"]
File \"/home/apierre/Dev/tuto-frozenlake/.direnv/python-3.10.4/lib/python3.10/site-packages/requests/models.py\", line 975, in json
raise RequestsJSONDecodeError(e.msg, e.doc, e.pos)
requests.exceptions.JSONDecodeError: Expecting value: line 1 column 1 (char 0)
"

Any idea what's happening?


Optional mail alerts with docker

These changes let users option to create or not smtp infrastructure based on msmtp by new USE_MAIL_ALERTS environment variable.
For me it also helps to avoid #133 issue.

Hey @lmaxyz, thanks for the PR!
I would like to merge the pull request. Only comment I have, is that USE_MAIL_ALERTS is not in the same style as the other variables in the env file. Could you update this to something like useMailAlerts? Your styling might be better, but since thousands of installations already use the other styling we can't just change that now.
Thanks!

Hi, @ssl . Thanks for your answer.
I understand your position.
Updates already pushed.

Thanks! I will merge now.


How to disable cache: "no-store" after 9.0.5 update

Hi,
In Cloudflare Workers I'm receiving the error: The 'cache' field on 'RequestInitializerDict' is not implemented. This is due to the latest 9.0.5 update. 9.0.4 works fine.
Is there a way to remove this for 9.0.5 and any future updates?
Thanks,
Tom.

Hey @tdwells90 for immediate resolution can you try using the workaround described in https://github.com/stytchauth/stytch-node/issues/262#issuecomment-1764910451 to manually edit the fetchConfig?
something like
function monkeyPatchStytchClientSettings(client: ...) {
  /* eslint-disable */
  const cl = <any>client;
  /* eslint-enable */
  cl.fetchConfig.cache = undefined;
}

should hopefully do the trick since the explicit undefined should override the key.
> { foo: 1, ...{foo: undefined}}
{ foo: undefined }

We'll see if we can detect the CF worker runtime and avoid setting that key as an immediate fix.
Would also be great for us to add automated tests that deploy to Cloudflare and verify that we don't break things. Right now that process is manual and we're not running it on every commit.

@tdwells90 is this solution- https://github.com/cloudflare/workerd/issues/698#issuecomment-1737605504 - a viable workaround? It looks like cloudflare themselves plan on fixing this issue in some near future 🤞

Going into /node_modules/stytch/dist/shared/index.js and commenting out the line that says cache: "no-store" (currently line 19) worked for me

any updates on this?


Easy way to compose ORed validators

Is there an existing issue that is already proposing this?

[X] I have searched the existing issues

Is your feature request related to a problem? Please describe it
I am validating that a string is either a MongoId or a UUID. I had to implement my own validator for this:
import {
  ValidatorConstraint,
  ValidatorConstraintInterface,
  ValidationOptions,
  registerDecorator,
  isUUID,
  isMongoId,
} from 'class-validator';

@ValidatorConstraint()
export class IsUUIDOrMongoIdConstraint implements ValidatorConstraintInterface {
  validate(text: string): boolean {
    return isUUID(text) || isMongoId(text);
  }

  defaultMessage(): string {
    return 'Text ($value) must be a UUID or a MongoId';
  }
}

export function IsUUIDOrMongoId(validationOptions?: ValidationOptions) {
  return function (object: Object, propertyName: string) {
    registerDecorator({
      target: object.constructor,
      propertyName: propertyName,
      options: validationOptions,
      constraints: [],
      validator: IsUUIDOrMongoIdConstraint,
    });
  };
}

A workaround is obviously also a somewhat complex RegExp, but that doesn't work in all cases where you want to compose different validators.
Describe the solution you'd like
Dream scenario would be to to be able to compose different validators, similar to how applyDecorators(...) works. I am thinking of something like this:
import ...

export class MyOwnDto {
  @ValidateOr(
    IsUUID(),
    IsMongoId(),
  )
  readonly myProperty: string;
}

Or something like this:
import { applyValidators } from '@nestjs/common';

export function IsUUIDOrMongoId() {
  return applyValidators(
    IsUUID(),
    IsMongoId(),
  );
}

Teachability, documentation, adoption, migration strategy
See the described proposed solution(s) above.
What is the motivation / use case for changing the behavior?
To make it easier to use composition when describing different cases that should be composed using OR (||) to a new validator.

This issue came out of https://github.com/nestjs/nest/issues/13483.


please heeeelp! where can I find exercises and practices web site in problem solving???(but i need best of them and free)

try Hackerrank, Hackerearth, exorcism... these are great ones

This is a great question to ask on our Discord!
As described in OSSU:CS readme, our github issues are meant for "[i]f there is a problem with a course, or a change needs to be made to the curriculum..."

Code forces and chefcode.


Delete Cell Diff View is empty

Testing #208266
While Testing ^, I tried the steps to delete a cell and then view this action from the timeline view. Clicking on the Delete entry in the timeline view produced an empty diff editor:

Duplicate of https://github.com/microsoft/vscode/issues/208564

Clicking on the Delete entry in the timeline view produced an empty diff editor:

This is how timeline entry works, you need to click the item before.
Peng and I also made the same assumption, however thats how how its designed to work (i.e. plain text files work this way, hence the statement by design)


Multiple polymorphic relations of same type in one model

I've been trying to solve this issue for the past few days, but I can't seem to find a way around it, and I don't know if there is a way. Any help is appreciated.
I have my class Like:
class Like
  include Mongoid::Document
  belongs_to :likable, polymorphic: true
  belongs_to :user
end

class Submission
  include Mongoid::Document

  belongs_to :creator, class_name: 'User', inverse_of: :submissions
  has_many :likes, :as => :likable, :dependent => :destroy
end

Then the class that causes the problem:
class User
  include Mongoid::Document
  has_many :submissions, :dependent => :destroy

  has_many :liked_submissions, :as => :likable, :dependent => :destroy, class_name: 'Like'
  has_many :liked_comments, :as => :likable, :dependent => :destroy, class_name: 'Like'
end

Now, the problem is that I can't figure out how to properly have both 'liked_comments' and 'liked_comments' in the user class. When I have it as I do above I get the error: Ambiguous relations :liked_submissions, :liked_comments defined on User. when trying to create a like for a submission.
Is this possible, and if not, any suggestions to getting around it? I would like to use likes in a BlogPost model as well, but if this doesn't work, I'll have to find another way.
Thanks in advance.

I'd say it is a design issue.
The `like` of a submission or a comment is an attribute of the submission / comment. I don't know what your design is exactly but you could either:

class LikableRelation
     belongs_to :user
     belongs_to :relation, :polymorphic => true
     field :liked, :type => :boolean
end

and you use that as a has_many :through relation bridging users with comments / submissions. You could even leverage mongoid relation extensions to have :liked_submissions and liked_comments get you what you want easily.

@muichkine Does MongoID even support a :through relationship?

Had tough times after discovering this issue but got cool solution that works
Add to your Gemfile

gem 'mongoid-multiple-polymorphic'

And this works like a charm:
  class Resource

  has_one :icon, as: :assetable, class_name: 'Asset', dependent: :destroy, autosave: true
  has_one :preview, as: :assetable, class_name: 'Asset', dependent: :destroy, autosave: true

  end


testing code in branch configuration

ignore me.....

/cib

Hmm, think this isn't working because the code in branch config is tied to develop?  Will have to look into it...

closing


Split test.js

The number of validator is growing, it became quite complicated handle the test.js file with many lines of code, I think we need to split the test.js file for each validator.
example uconnectedhighways.test.js
cc @geohacker @maning

ready here!


Update time displayed in GUI to be more human readable (2nd PR)

This has the same purpose as #223. #223 was created with an error.
Closes #221 #215
Example

Codecov Report

Merging #224 into master will decrease coverage by 0.01%.
The diff coverage is 60.71%.

@@             Coverage Diff              @@
##             master     #224      +/-   ##
============================================
- Coverage     61.18%   61.17%   -0.02%
- Complexity      864      868       +4
============================================
  Files           138      138
  Lines          3187     3209      +22
  Branches        370      375       +5
============================================
+ Hits           1950     1963      +13
- Misses         1072     1076       +4
- Partials        165      170       +5

Impacted Files
Coverage Δ
Complexity Δ

src/main/java/seedu/address/ui/EventCard.java
0.00% <0.00%> (ø)
0.00 <0.00> (ø)

src/main/java/seedu/address/model/event/Time.java
54.76% <61.53%> (+4.76%)
11.00 <7.00> (+4.00)

src/main/java/seedu/address/model/event/Event.java
57.14% <100.00%> (ø)
10.00 <0.00> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d4b6914...2fda600. Read the comment docs.

Codecov appears to be bugged atm


Suggestion: patchAndFetch (related to issue #34)

Simple suggestion here:
Model.query().patchAndFetchById(id, partial);

should have a counterpart:
instance.$query().patchAndFetch(partial);

Thoughts?

Good idea. I'll add this at some point.


Account change detection does not work

I'm listening to the accountsChanged event but the change detection doesn't work (Web3 - browser).
This event works with Metamask for example.

It's gone as of 2.0. Address should not change, it's fixed per connection. To obtain address, please use EIP1102. Thank you!

👍👍👍👍

Ho


Support for IsAbstract in Method

Thanks for adding $IsAbstract to Class ... it would be extremely useful to have it in Method as well.
My use case is that I'm generating translations for service classes, and the services inherit from a base class. The base class has been abstract alI along, but I just ran across a need to add an abstract method there and implement in the derived services. Generating the TS, I'm getting two implementations in each service, and I can't see a way of filtering out the abstract declaration in the base class to solve the problem.
Of course, if this gets implemented, might as well add it to Property while you're there :-)
If too time consuming, I can dig into it and create a pull request when I get it solved, but no guarantees on schedule.
Thanks.

Hi @msawczyn,
I've added this in Typewriter 1.14.0.


Release 6.0 with download-manifest --layout changes

#297 adds --layout to download-manifest which default to none.  This creates only the .hca file store and a rewritten manifest in the current working directory. Orange thinks that this should be the default behavior. The previous behavior is accessible as --layout bundle`. Because this breaks backwards compatibility, we should bump the major version.

Ping @briandoconnor when this is done so he can test it.

@briandoconnor this has been released as 6.0.1 and is ready for you to test.

Demo-ed on 5/13/2019


Spacing and style issues in footer

'Top 5 Templates' area only displays 3 templates. There should be 5 and not a numbered list. If possible it would be good to shift this info to the left slightly so it doesn't run so close to the edge of the window. And that way the 'More' link can appear to the lower right rather than directly below the list.
The footer spacing for items below this area needs some tightening (use current dmptool prod footer as a guide). Reduce white space above About, Terms of Use, etc.
The blue line weight should be heavier
'RSS feed' in the news banner should be justified right as in the current prod version
Twitter and RSS icons are weirdly tiny; make them larger

Current dmptool prod w/correct line weights, spacing

dmptool-stg

looking much better. i have a few more nitpicky requests:

move the Twitter icon to the right to reduce space between it and the RSS icon
remove the numbers next to the Top Templates
add some whitespace between the Top Templates underline and the template names so they're more aligned with the icons on the left; this should also push that 'More' link down to be more aligned with the More links on the left

footer issues all addressed. closing.


docs: test runners clarification

Description
Replaces test-runner property notice from YAML templates and Markdown docs with an up-to-date information:

Jest test runner is the default and it is implied.
Instead of undocumented test-runner syntax, we now suggest the correct and documented testRunner property as a source of truth.

Last but not least, testRunner property still remains supported by Detox for custom commands (e.g. nyc jest) and (possibly) other runners.

Oh man

@d4vidi refresh.


feat(dashboard): add time-point annotation functionality

Overview
Added time-point annotation functionality to the dashboard. Time-point annotations can be created, edited, and deleted, filtered by visibility, and have label/color specified for each widget on the dashboard.
NOTE: Opening this PR as a continuation of the original PR for time-point annotations (https://github.com/awslabs/iot-app-kit/pull/152), which was automatically merged by Github (a '0 commits merged') after a force-push to the PR's branch. Comments from this original PR have been addressed and added to the code.
Tests
[Include a link to the passing GitHub action running the test suite here.]
Legal
This project is available under the Apache 2.0 License.

not going to review this until the checks are passing

can you add a screenshot of what this looks like?

This requires some major architectural  changes - changes, we should almost never alter a prop passed into a component. Changes to the dashboard need to be done thru the reducer - there is an UPDATE action you will emit, which will then update the dashboard configuration which flows back down

Please recreate this pull request off the new head, a history rewrite was pushed. Closing.


Help wanted

Hello, I'm very interested in your project, but it's a bit difficult for me to understand. Do you have any documentation that provides a detailed explanation?

Hey Chen Please wait. I am adding the documentation this month itself.


Added KHR_materials_common materials/techniques/shaders to addDefaults

@JoshuaStorm and I wrote this to have defaultMaterials try to match the existing gltf material values to one of the KHR_materials_common materials, apply the appropriate extension, and then pass the gltf to modelMaterialsCommon at the end of addDefaults.
Also added some tests to addDefaultsSpec.
See https://github.com/AnalyticalGraphicsInc/gltf-pipeline/issues/1

Coverage increased (+1.0%) to 93.274% when pulling 502e3e310a61aa959869adff6dec84b50e5192b5 on materialsStageKHR into 3db33068aa04e5b0b60b3324b8140156f4150f13 on master.

@lilleyse can you please do an initial review here?

Coverage decreased (-5.6%) to 86.717% when pulling 1e68c45b6b81d3535aec36e800d060fc2c9942c9 on materialsStageKHR into 3db33068aa04e5b0b60b3324b8140156f4150f13 on master.

Updated. When testing assimp exported gltf (gltf without techniques) we ran into a problem where cesium's modelMaterialsCommon would produce shaders with empty string uris. We got around it with a customized modelMaterialsCommon in the lib folder, similar to what's in OBJ2GLTF.
Unfortunately assimp exported gltfs still don't seem to work, but the test case we've been using is also weird. It has buffer views for indices, positions, normals, and uvs but they all point at the same buffer and all have offset 0. Very strange. See attached.
assimp.zip

For assimp, have you tried just the box COLLADA model, https://github.com/KhronosGroup/glTF/tree/master/sampleModels/Box/collada

I gave it a try, but it seems to have the same problem with the bufferViews. It actually runs into the same error in the pipeline and when I try to view it in the online COLLADA to glTF convertor.

What about using a simple OBJ file with assimp, perhaps from https://github.com/SaschaWillems/Vulkan/tree/master/models
Just trying to understand if it is the assimp importer or assimp glTF exporter.

I tried it with a basic cube and with hammardillo, but it seems to be the same problem, bufferViews that all start at 0.

I'm pretty sure it's in the assimp gltf exporter. I'm going to try and take a look at their code.

If you figure it out in a reasonable amount of time, open a pull request; otherwise, some an issue to the assimp repo and include sample data and simple instructions to reproduce it.

Ok. Updated!

Nice, looks good!

Coverage decreased (-5.0%) to 87.336% when pulling ddba5929f4f05b5cdc8466d0175c891149736dae on materialsStageKHR into 3db33068aa04e5b0b60b3324b8140156f4150f13 on master.

@pjcozzi this is ready whenever you want to look

Looks like test coverage could be improve a good bit: https://coveralls.io/github/AnalyticalGraphicsInc/gltf-pipeline?branch=materialsStageKHR

Coverage increased (+1.5%) to 93.815% when pulling 9d7cf7c61f1b1e5821ae9cd3079f539f2e484947 on materialsStageKHR into 3db33068aa04e5b0b60b3324b8140156f4150f13 on master.

Updated! Apparently I misunderstood extensions versus extensionsUsed, so fixing that and adding some more to the tests I had helped increase the coverage.

@lilleyse please merge when ready.

Looks ready to me.

Ah forgot, thanks!


Patch 5 - update disablePkce config

DefaultDelegatedClientFactory has to configure this new feature

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.8 out of 10 committers have signed the CLA.:white_check_mark: antoine777:white_check_mark: lgwozniak:white_check_mark: leadpony:white_check_mark: fmartelli:white_check_mark: mmoayyed:white_check_mark: julienhuon:white_check_mark: ilgrosso:white_check_mark: 0xDCSun:x: dfish3r:x: le-zellYou have signed the CLA already but the status is still pending? Let us recheck it.


Added a check to see if the keycode is the backspace keycode

i have a non-standard keyboard layout and this fixes the issue i am having.

Thanks for the contribution! :)


feat: improve event history

:tada: This PR is included in version 1.39.0 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket: