[Feature request] make the editing widgets positionable

Platforms
Android, iOS, Web
Description
A new feature allows developers to freely position and arrange widgets anywhere on the screen using custom (x, y) coordinates. It provides full control over the layout of UI elements, without being constrained by standard layouts (Column, Row, etc.). Widgets can be moved, resized, or dynamically adjusted as needed.
Why
This function could help to make a better interface finally to the taste of the application

It is possible to add your own widgets at fixed or custom positions by using customWidgets in the configuration settings. Below is an example of how to do this.
configs: ProImageEditorConfigs(
    customWidgets: ImageEditorCustomWidgets(
      mainEditor: CustomWidgetsMainEditor(
        bodyItems: (editor, rebuildStream) {
          return [
            ReactiveCustomWidget(
              stream: rebuildStream,
              builder: (_) =>
                  editor.selectedLayerIndex >= 0 || editor.isSubEditorOpen
                      ? const SizedBox.shrink()
                      : Positioned(
                          bottom: 20,
                          left: 0,
                          child: Container(
                            decoration: BoxDecoration(
                              color: Colors.lightBlue.shade200,
                              borderRadius: const BorderRadius.only(
                                topRight: Radius.circular(100),
                                bottomRight: Radius.circular(100),
                              ),
                            ),
                            child: IconButton(
                              onPressed: () {
                               /// Some Interaction
                              },
                              icon: const Icon(
                                Icons.reorder,
                                color: Colors.white,
                              ),
                            ),
                          ),
                        ),
            ),
          ];
        },
      ),
    ),
  ),

Oh, sorry, I now understand a bit better how your package is structured.

You can also check out the examples, which might be helpful. These examples are the same ones used in the web demo.


Cannot dynamically import css in a static build

Describe the bug
When importing css or scss files (doesn't matter which format) in a vite application (framework does not matter here) you can import successfully in multiple different ways:
import './style.css'
import('./scss/sass.css');
const dyn = "dynamic"
import('./scss/' + dyn + '.css');

In the sample application, these three files all add styles to a single element. If all of these load, the element is blue. If only the first import loads, it is red.
When run locally with npm run dev you get a blue background. When you run npm run build and start a server in the dist folder you get the red background

The issue appears to be that, these files are compiled as pure .css files, but the application is looking for .js files for each of these hashes.
I've not found a suitable rollup plugin to correct this behaviour, and this is something that worked just fine with the Vue CLI and webpack, so I think it's a bug.
Reproduction
https://github.com/steveworkman/vite-scss-dynamic-test
System Info
npx: installed 1 in 1.481s

  System:
    OS: macOS 11.4
    CPU: (12) x64 Intel(R) Core(TM) i7-8850H CPU @ 2.60GHz
    Memory: 62.95 MB / 16.00 GB
    Shell: 5.8 - /bin/zsh
  Binaries:
    Node: 12.21.0 - ~/.nvm/versions/node/v12.21.0/bin/node
    npm: 6.14.11 - ~/.nvm/versions/node/v12.21.0/bin/npm
    Watchman: 2<IP_ADDRESS> - /usr/local/bin/watchman
  Browsers:
    Chrome: 91.0.4472.114
    Chrome Canary: 93.0.4574.0
    Firefox Developer Edition: 90.0
    Safari: 14.1.1
    Safari Technology Preview: 15.0
  npmPackages:
    vite: ^2.4.2 => 2.4.2

### Used Package Manager

npm

### Logs

```shell
> @0.0.0 build /Users/steveworkman/code/vite-scss-dynamic-test
> vite build --debug

  vite:config bundled config file loaded in 64ms +0ms
  vite:config using resolved config: {
  vite:config   plugins: [
  vite:config     'alias',
  vite:config     'vite:dynamic-import-polyfill',
  vite:config     'vite:resolve',
  vite:config     'vite:html',
  vite:config     'vite:css',
  vite:config     'vite:esbuild',
  vite:config     'vite:json',
  vite:config     'vite:wasm',
  vite:config     'vite:worker',
  vite:config     'vite:asset',
  vite:config     'vite:define',
  vite:config     'vite:css-post',
  vite:config     'vite:build-html',
  vite:config     'commonjs',
  vite:config     'vite:data-uri',
  vite:config     'rollup-plugin-dynamic-import-variables',
  vite:config     'asset-import-meta-url',
  vite:config     'vite:import-analysis',
  vite:config     'vite:esbuild-transpile',
  vite:config     'vite:reporter'
  vite:config   ],
  vite:config   build: {
  vite:config     target: [ 'es2019', 'edge88', 'firefox78', 'chrome87', 'safari13.1' ],
  vite:config     polyfillDynamicImport: true,
  vite:config     outDir: 'dist',
  vite:config     assetsDir: 'assets',
  vite:config     assetsInlineLimit: 4096,
  vite:config     cssCodeSplit: true,
  vite:config     sourcemap: false,
  vite:config     rollupOptions: {},
  vite:config     commonjsOptions: { include: [Array], extensions: [Array] },
  vite:config     dynamicImportVarsOptions: { warnOnError: true, exclude: [Array] },
  vite:config     minify: false,
  vite:config     terserOptions: {},
  vite:config     cleanCssOptions: {},
  vite:config     write: true,
  vite:config     emptyOutDir: null,
  vite:config     manifest: false,
  vite:config     lib: false,
  vite:config     ssr: false,
  vite:config     ssrManifest: false,
  vite:config     brotliSize: true,
  vite:config     chunkSizeWarningLimit: 500,
  vite:config     watch: null
  vite:config   },
  vite:config   configFile: '/Users/steveworkman/code/vite-scss-dynamic-test/vite.config.js',
  vite:config   configFileDependencies: [ 'vite.config.js' ],
  vite:config   inlineConfig: {
  vite:config     root: undefined,
  vite:config     base: undefined,
  vite:config     mode: undefined,
  vite:config     configFile: undefined,
  vite:config     logLevel: undefined,
  vite:config     clearScreen: undefined,
  vite:config     build: {}
  vite:config   },
  vite:config   root: '/Users/steveworkman/code/vite-scss-dynamic-test',
  vite:config   base: '/',
  vite:config   resolve: { dedupe: undefined, alias: [ [Object] ] },
  vite:config   publicDir: '/Users/steveworkman/code/vite-scss-dynamic-test/public',
  vite:config   cacheDir: '/Users/steveworkman/code/vite-scss-dynamic-test/node_modules/.vite',
  vite:config   command: 'build',
  vite:config   mode: 'production',
  vite:config   isProduction: true,
  vite:config   server: { fs: { strict: undefined, allow: [Array] } },
  vite:config   env: { BASE_URL: '/', MODE: 'production', DEV: false, PROD: true },
  vite:config   assetsInclude: [Function: assetsInclude],
  vite:config   logger: {
  vite:config     hasWarned: false,
  vite:config     info: [Function: info],
  vite:config     warn: [Function: warn],
  vite:config     warnOnce: [Function: warnOnce],
  vite:config     error: [Function: error],
  vite:config     clearScreen: [Function: clearScreen]
  vite:config   },
  vite:config   createResolver: [Function: createResolver],
  vite:config   optimizeDeps: { esbuildOptions: { keepNames: undefined } }
  vite:config } +4ms
vite v2.4.2 building for production...
✓ 7 modules transformed.
dist/assets/favicon.17e50649.svg   1.49kb
dist/index.html                    0.45kb
dist/assets/sass.1c43ea22.css      0.05kb / brotli: 0.03kb
dist/assets/dynamic.d49ca673.css   0.05kb / brotli: 0.04kb
dist/assets/index.344921c7.css     0.28kb / brotli: 0.15kb
dist/assets/index.5309a613.js      3.34kb / brotli: 1.12kb

### Validations

- [X] Follow our [Code of Conduct](https://github.com/vitejs/vite/blob/main/CODE_OF_CONDUCT.md)
- [X] Read the [Contributing Guidelines](https://github.com/vitejs/vite/blob/main/.github/contributing.md).
- [X] Read the [docs](https://vitejs.dev/guide).
- [X] Check that there isn't already an issue that reports the same bug to avoid creating a duplicate.
- [X] Make sure this is a Vite issue and not a framework-specific issue. For example, if it's a Vue SFC related bug, it should likely be reported to https://github.com/vuejs/vue-next instead.
- [X] Check that this is a concrete bug. For Q&A open a [GitHub Discussion](https://github.com/vitejs/vite/discussions) or join our [Discord Chat Server](https://chat.vitejs.dev/).

Some more investigation - if these dynamically loaded css files are CSS Modules (with the filename of dynamic.module.css and sass.module.sass then they are imported correctly - though with the module hash as expected

I am experiencing the same (or very similar) issue when migrating a Vue-app to Vite.
I'm using a conditional import to set the theme of my application:
    if (light) {
        import('../styles/light/app.scss');
    } else {
        import('../styles/dark/app.scss');
    }

This work fine in dev, but in a production build I can see that the .css-files are generated but the application attempts to load a non-exsisting .js-file. Thus the styles are not loaded.

This now works without the module workaround for me as of vite 2.5.10
(Looks like it was fixed in 2.51: https://github.com/vitejs/vite/blob/main/packages/vite/CHANGELOG.md#251-2021-08-24 )

Agreed - fixed by #3333


Missing Launch file

Hi, I believe you forgot to add the launch file for the mid360 and put instead another copy of LidarFeatureExtractor.h in the launch folder

Solved by latest commit


Likely a dumb question

How do I make it start with the system, and run without having the terminal tab open

Installation via Homebrew does this for you, please see here: https://github.com/ohueter/autokbisw#installation
Without using Homebrew, you could add autokbisw as a Launch Daemon for your user. You can find an example .plist file here: https://github.com/ohueter/autokbisw/issues/27#issuecomment-1768167959
and documentation by searching the web for "macos plist service" or official docs by Apple here: https://developer.apple.com/library/archive/documentation/MacOSX/Conceptual/BPSystemStartup/Chapters/CreatingLaunchdJobs.html
However, I can't help you with that.


remove recursive alias in test case

This is an accepts-invalid bug, isn't it?

Does it make an alias to itself or an alias to the function?

It creates an alias to the function and later adds itself as overload to the same function.


disable arangosearch analyzers in agency

Please note that for legal reasons we require you to sign the
Contributor Agreement
before we can accept your pull requests.

http://jenkins01.arangodb.biz:8080/view/PR/job/arangodb-matrix-pr/4448/

I confirm that agency no longer crashes / SEGFAULTs.


Backend API for leaderboard to retrieve top 10 ELO players

This pull request adds the backend functionality for the leaderboard webpage, including:

A GET endpoint to retrieve the top 10 ELO players via the LeaderboardController.
Models for PlayerProfile and LeaderboardPlayerProfile.
Service layer to fetch top players.
Slightly edited the SecurityConfig file because Nibras and I were struggling to get past the authentication
Added the database to application.properties

 Added individual position checker for each user tracked by username
 Able to view top 10 leaderboard positions


hideTryIt is greedy - Is it possible to hide the Try It panel, but keep the Examples panel?

When setting the hideTryIt configuration in the element-api section like hideTryIt = "true", the inverted panel (with the dark background) is removed, but so too is the examples panel. Is it possible to just remove the panel with the Send API Request button in it but keep the examples? The  'response example' panel remains visible in both cases.
I've just discovered this project and it is great for my needs - thank you!

Version used<EMAIL_ADDRESS>

I have similar needs, for the time being, one way to hide it is adding the following CSS to the HTML page:
<style> .SendButtonHolder {   display: none;   visibility: hidden; } </style>

This would be greatly appreciated, the CSS above also no longer seems to apply.

Try this code in your javascript
`const windowLoad = () => {
setTimeout(() => {
removeTestButton();
}, 10);
};
const removeTestButton = () => {
const button = document.querySelector(".SendButtonHolder").children[0];
button.remove();
};
window.addEventListener("load", windowLoad);
window.addEventListener("hashchange", removeTestButton);
`

Try this code in your javascript:
const windowLoad = () => {
    setTimeout(() => {
        removeTestButton();
    }, 10);
};

const removeTestButton = () => {
    const button = document.querySelector(".SendButtonHolder").children[0];
    button.remove();
};

window.addEventListener("load", windowLoad);
window.addEventListener("hashchange", removeTestButton);

I solved this like this:

        /* hide the tryit without hiding code examples and example responses */
        .TryItPanel {
            display: none;
        }

However a prop to do this would probably be better.


adding a space before casting into a different type

Hello @tractorcow ,
can you review this one as well? Thanks :)
Cheers,
Spek

Why is this the best convention? Which coding standard are you following?

Hello @tractorcow ,
I always thought it was in the SS coding conventions. But I couldn't find it. I must have kept this as a habit from former work. It improves the readability IMHO. What do you think?
Spek

I can merge this, but I don't think anyone will follow this convention. :)


NoVNC is fully unuseful with live resizing of desktop (spice)

Author Name: kvaps kvaps (kvaps kvaps)
Original Redmine Issue: 5232, https://dev.opennebula.org/issues/5232
Original Date: 2017-07-12

Step for reproduce:

Setup VM using spice
Install SPICE guest agent inside
Open Console

You will see that desktop resolution will endlessly change, and you can not do anything via console.
This is because the spice tries to adjust the resolution to the client window but this is have no fixed size.

Original Redmine Comment
Author Name: EOLE Team (EOLE Team)
Original Date: 2017-08-21T10:18:41Z

Hello,
It may be related to #5025 which seems to be a better spice web client:

Full QXL Support of the entire spice protocol, including clipping, masking, scaling etc (accelerated mode)

Regards.

In OpenNebula 5.10.1 integrated Spice client is still unusable with desktops that support Spice dynamic resolution, such as Gnome Shell and KDE. Tested on (K)Ubuntu 19.10.

OpenNebula 5.14 will bring support for Guacamole. SPICE through noVNC will be maintained for backwards compatiblity, but not new developments will be perfomed


Added sfx (Fix, hopefully)

👉 Checklist

Please make sure to check off the following before submitting:

[x] I have reviewed my submission thoroughly.
[x] I have tested my code (if submission is related to coding) and run the game before pushing (to make sure the project compile).
[ ] I have run the JUnit tests (if submission is related to coding).
[x] I have read the Code of Conduct and Contribution Guidelines.

✍ Description of the Pull Request

Please concisely describe the changes you have made.

Added sfx for the game using sfxr to make them.
Explosion sound when dinosaur is killed
Player shoot sound
Ship engine 'drone' noise
Enemy shooting sound
Player Damage sound
🔗 Issue link

Issue reference number and link goes here e.g. 'Fixes/Closes #40 '.

[x] This Pull Request fixes the issue : 'Closes #40 '
[ ] This Pull Request does not fix an issue.

Thanks for taking the time to fill out this Pull Request! ❤ Thanks for contributing to this project 🦖

Can you let me know if this works now?

Alright thanks, I found the issue : a contributor deleted a .iml file which made all of my errors on my IDE (IntelliJ). I'll upload it after.
Thanks for the contribution !


Only top level pages with permission level set to Registered Users correctly redirect to login page

To reproduce:

Fresh install of C5 8.1.0
Visit  e.g. /index.php/dashboard/system/express/entities as guest
Site renders 404 page instead of the more appropriate redirect to login screen

Comments:
It seems as soon as the requested URL doesn't resolve to a top-level page but to a controller method, then this behavior crops up. Contrast with just visiting:
/index.php/dashboard
Expected behavior:
All disallowed pages, no matter how deep in the hirearchy the URL points to should redirect users to Login screen. Confusion arises when users have an open page deep in the hirearchy and their session expires, and they then get a 404 Page Not Found

This is fixed in the develop branch. GitHub is only for bugs confirmed to
exist on the latest development branch. For all other issues use the bug
tracker on concrete5.org.
On Tue, Apr 25, 2017, 7:38 AM Kramerican<EMAIL_ADDRESS>wrote:

To reproduce:

Fresh install of C5 8.1.0
Visit e.g. /index.php/dashboard/system/express/entities as guest
Site renders 404 page instead of the more appropriate redirect to
login screen

Comments:
It seems as soon as the requested URL doesn't resolve to a top-level page
but to a controller method, then this behavior crops up. Contrast with just
visiting:
/index.php/dashboard
Expected behavior:
All disallowed pages, no matter how deep in the hirearchy the URL points
to should redirect users to Login screen. Confusion arises when users have
an open page deep in the hirearchy and their session expires, and they then
get a 404 Page Not Found
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/concrete5/concrete5/issues/5390, or mute the thread
https://github.com/notifications/unsubscribe-auth/AAM-qepFcz2Zxu47CioO6Cn0JS0QMfKMks5rzdtDgaJpZM4NHW3f
.

My apologies
I tried searching for this bug to make sure I wasnt reporting a duplicate. I'll try to be more aware next time.
Thank you for the response, and good to hear it has been fixed :)

Has this been fixed? After upgrade from 8.0.0b2 to 8.1.0 the issue appears?


Can't control logging from Swift

NMSSH works fine for me from Swift, but I was unable to control logging by calling the static property NMSSHLogger.logger. I believe this is because Swift doesn't support them. It would be great to provide a static accessor method for this as well.
I was able to get around this, and access the shared logging config from Swift by just adding the following to NMSSHLogger.m (and the corresponding declaration to NMSSHLogger.h)

(instancetype)sharedInstance {
return NMSSHLogger.logger;
}

I have this issue too. I will try this workaround.
Seems static/class vars are not exported to Swift.

Can you paste the exact code needed in the NMSSHLogger.h and NMSSHLogger.m files please?
Tried + (NMSSHLogger *)sharedInstance { return NMSSHLogger.logger; }
and + (NMSSHLogger *)sharedInstance;
but I get that 'NSInvalidArgumentException', reason: '+[NMSSHLogger sharedInstance]: unrecognized selector sent to class 0x10ef95f48'
I'm so bad with obj-c!

Hi,
That's still a static method and Swift won't see it, you need this(like cwilper said above):
-(instancetype) sharedInstance { return NMSSHLogger.logger; }

The trick is to have an instance method that accesses internally the static method.

Ok. Now how do I call that sharedInstance? I tried several things and that just doesn't work..
NMSSHLogger().sharedInstance().logLevel = NMSSHLogLevel.Info
seems all right but it makes my app crash:
Terminating app due to uncaught exception 'NSInvalidArgumentException', reason: '-[NMSSHLogger sharedInstance]: unrecognized selector sent to instance
Thanks again for your help.

I am sorry, I think I misled you, turns out it was a static method after all!
I had this in my .h:
+(instancetype)sharedInstance;

And this in my .m:
+(instancetype)sharedInstance
{
    return NMSSHLogger.logger;
}

I access mine like this, in Swift:
NMSSHLogger.sharedInstance().enabled = false;

Would it be easier if I just pushed a merge request?.

See my pull request: https://github.com/Lejdborg/NMSSH/pull/123

I modified the files to fit your pull request and now call with NMSSHLogger.sharedLogger().enabled = false but I still got my app crashing every time!
+[NMSSHLogger sharedLogger]: unrecognized selector sent to class 0x10b47cf48
What could cause that?

In the pull request the method is currently called +sharedInstance so NMSSHLogger.sharedInstance().enabled = false should work for you.

unrecognized selector sent to class means you tried to call a static method that does not exist on the class.

sharedLogger does not exist in my pull request...

I made a new pull request, renaming logger to sharedLogger, as per @Lejdborg instructions: https://github.com/Lejdborg/NMSSH/pull/125

@cwilper does the proposed fix work for you?

@crazyquark i'm not in a position to test on my swift project at the moment, but I took a look at the PR and it looked good. Thanks!


Any more information on the delete button URL?

I have everything working and using S3 along with Laravel for my app. I have a routes set up for deleting images, but cant see how to link the delete button url to the selected image?
The docs just show 'delete.php' as the URL, before I start hacking my way through is there already some way of passing in an image attr or similiar to the delete url? Or how have others done it?

File name is sent along with the request: https://github.com/orthes/medium-editor-insert-plugin/blob/master/src/js/images.js#L577
If you need more, you can use fileDeleteOptions to extend/override default AJAX configuration.


⚠ Samsung has degraded performance

In 1254931, Samsung (https://samsung.com) experienced degraded performance:

HTTP code: 200
Response time: 2228 ms

Resolved: Samsung performance has improved in e664fa5.


Allow query transmutation with immutable query references

Consider the following example:
#[derive(Component)]
struct A { }
#[derive(Component)]
struct B { }

fn system1(
    my_query: Query<(&A, &B)>
) {
    fn immutable_helper(subquery: &Query<(&A)>) {
        for x in subquery.iter() {
            // bla bla
        }
    }
    let lens_a = my_query.transmute_lens::<(&A)>();
    immutable_helper(&lens_a.query())
}

Why does using transmute_lens() and query() require me to have mutable reference to the query if the query itself is not mutating anything? This prevents me from using transmute lens if the destination of the transmute result accepts only immutable query references. Is there a way around this without forcing the user to perform painful refactorings for all helper functions to accept mutable references of the query, assuming that is even always possible?
Going down the path of definitions from transmute_lens, it would also seem that final transmute function call takes immutable reference anyway, so maybe this feature could be implemented without much hassle?

So I added immutable variations of transmute_lens and transmute_lens_filtered without any more changes to the bevy source code and it seems it works as this kind of test passes:
    /// ```rust
    /// # use bevy_ecs::prelude::*;
    /// # use bevy_ecs::system::QueryLens;
    /// #
    /// # #[derive(Component)]
    /// # struct A(usize);
    /// #
    /// # #[derive(Component)]
    /// # struct B(usize);
    /// #
    /// # let mut world = World::new();
    /// #
    /// # world.spawn((A(10), B(5)));
    /// #
    /// fn reusable_function(q: &Query<&A>) {
    ///     assert_eq!(q.single().0, 10);
    /// }
    ///
    /// fn system1(query: Query<(&A, &B)>) {
    ///     let mut lens = query.transmute_lens_i::<&A>();
    ///     reusable_function(&lens.query());
    /// }
    ///
    /// # let mut schedule = Schedule::default();
    /// # schedule.add_systems((system1));
    /// # schedule.run(&mut world);
    /// ```
    pub fn transmute_lens_i<NewD: QueryData>(&self) -> QueryLens<'_, NewD> {
        self.transmute_lens_filtered_i::<NewD, ()>()
    }

Therefore it seems to me that it is just a matter of adding immutable and mutable variations of the transmute_lens  and transmute_lens_filtered functions to solve this issue? Should I make a PR for it?

It's unsound to use immutable references. If you do that you can get 2 query lens out of one query and get two mutable references to the same value. If you run the ecs compile fail tests there should be a test checking for this.
It might be valid to allow using &self for read only queries, but it's late here and I haven't thought it through all the way.

So the problem essentially is that the user can get access to two mutable queries that contain mutable references to same component data? I created a test case here. It compiles and does not crash, but I don't know if this is something that could cause issues otherwise. If this is unwanted behavior, could it be possible to create a compile time mechanism to prevent this kind of access and yet still allow the usage of transmuting read only queries?
I created a fork and started using this feature on my project for now regardless and it works, no issues so far. The changes are here in the last two commits.

Your immutable helper in that code doesn't actually alias the data. It'd be more like:
fn immutable_helper(subquery: &mut Query<(&mut A)>, subquery2: &mut Query<(&mut A)>) {
    let a1 = subquery.iter_mut().next();
    let a2 = subquery.iter_mut().next();
    // oops we violated rusts safety rules since we have 2 &mut references to the same data. This is UB.
    assert_eq!(a1 as *const A, a2 as *const B);
}

Note that just because something doesn't crash that it doesn't mean that it doesn't have undefined behavior.

This is an advanced case of #3774.


add coverall in travis

 Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.


GuideToPharm importer producing invalid xrefs

Specifically, iuphar.ligand:388 is combining two CHEBI references, which then breaks the normalization routine. Should be an easy fix.

closed in https://github.com/cancervariants/therapy-normalization/pull/416


Git PR status waits for Azure Devops Pipeline to return status code on jobs that wont trigger the pipeline.

When editing files such as README's or .md which are excluded in the azure-pipeline.yml git pull request will remain unapproved due to the Build check never being validated.

@jmspring @andrebriggs Issue referenced here - https://github.com/MicrosoftDocs/vsts-docs/issues/2363

In order to properly exclude builds from running when .md files are updated, we will need to specify the path to the .md files explicitly in the exclude path of the azure-pipelines.yaml.
This seems inefficient, but azdo does not have a way to "wild card" file path filters. See this post for more details: https://stackoverflow.com/questions/55731861/exclude-file-types-in-ci-triggers-on-azure-devops-pipelines-builds

@yradsmikham @NathanielRose can we close this issue?

@andrebriggs yes, I think we can. We have a separate issue that already mentions an issue regarding excluding markdown files in pipeline validation.

@yradsmikham Could you please post a link to that separate issue.

@pjivers-bom It's been a while since we've revisited this issue, and after some digging around, I was not able to find it. If you are having a similar issue, I recommend creating a new ticket. Thanks!


Update hp-rpc to 1.16.0

https://github.com/ioBroker/ioBroker.hm-rpc/issues/1121

1.16.0 created 25.12.2023
1400 user
OK


Increase in compilation timeouts

We're currently investigating an increase in compilation timeouts:
Error: Unable to compile project: Compilation timed out

This is affecting development and scheduled runs.

We believe we've found the issue, and haven't seen any timeouts since we rolled it out. We will continue to monitor this over the next week!


fix .nav-list .active item not retaining @linkColor on :hover

Fixes #1473 by making .nav-list .active keep its usual background color on hover.

I agree.

Already resolved this one. Thanks!


Chainloop Tools container image

Build the chainloop tools container image during the release process. We will use this image in various automations/integrations.
The image will include the latest version of Chainloop CLI and:

jq
syft
cosign
oras

We might don't need to make it part of our release process, but a parallel process instead.
That way we do not need to wait for chainloop to be released if we want to add/update a tool. re: the CLI we can always download it from the github releases.
WDYT?


apparmor: 2.10 -> 2.12.0

Motivation for this change
New apparmor release
Things done

[x] Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
Built on platform(s)

[x] NixOS
[ ] macOS
[ ] other Linux distributions

[x] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests) (dnscrypt-proxy.nix is using apparmor and passes)
[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
[ ] Tested execution of all binary files (usually in ./result/bin/)
[x] Fits CONTRIBUTING.md.

cc maintainers @thoughtpolice @joachifm @Phreedom

@GrahamcOfBorg eval

LGTM, but needs to go via staging ofc

Yes of course. I have rebased on top of staging.


Very vague documentation not much helpful

Should give with an example.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 955d694a-7285-45b6-56b9-3a86ddbb0820
Version Independent ID: 0d226e23-1ddd-f6de-abf7-5b112533ec78
Content: Build, test, and deploy Android apps - Azure Pipelines
Content Source: docs/pipelines/languages/android.md
Product: devops
Technology: devops-cicd
GitHub Login: @thomps23
Microsoft Alias: dastahel

@gautamkrisna If you can provide more context around what made this content difficult to understand we'll be able to properly triage your feedback.
Thank you!

Can you please give me the document link again, it will refresh my memory
as to why I was unsatisfied, I have read multiple documents recently and
donot remember this is w.r.t to which one exactly.
Regards,
Gautam.
On Tue, Apr 30, 2019 at 12:29 AM thomps23<EMAIL_ADDRESS>wrote:

@gautamkrisna https://github.com/gautamkrisna If you can provide more
context around what made this content difficult to understand we'll be able
to properly triage your feedback.
Thank you!
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/MicrosoftDocs/vsts-docs/issues/4081#issuecomment-487702065,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AH66PTMMMFRHR3PSV4DAWKLPS5APTANCNFSM4HI3AVUA
.

--
Regards,
Gautam.

@gautamkrisna Here is the link to article for which you provided the feedback "Should give with an example". Thank you.
https://docs.microsoft.com/en-us/azure/devops/pipelines/languages/android?view=azure-devops#feedback

Closing this issue, but please re-open if there is any specific direction for improvement.

Thomps,
When I posted this comment, I was looking to entail all my automated
android tests to be run immediately after a succesfull CICD build. I could
not find any documentations on how to get that going. I had to post in your
community and took me days to get it working after trial and errors.
I work for Citrix, we are automation team who deal with multiple Android
and iOS apps, we are doing an evaluation of AppCenter checking feasibility
for our automation requirement. We are interested to automate applications
like Citrix SecureMail, Citrix WorkSpace & Citrix Files apps. This would
involve automating SecureMail email client, Citrix WorkSpace app where we
need to have a coordinated automated test execution on Android/iOS Devices
and Windows servers one after the other. We are unable to continues this
explorations because of extremely low availability of documentations and
megre support with trial. The only way we see we will be able to proceed
with this feasibility is continuous and quick turnaround help from
Microsoft or an on-call engineer hand hold us during this POC.
Regards,
Gautam.
On Tue, Apr 30, 2019 at 12:29 AM thomps23<EMAIL_ADDRESS>wrote:

@gautamkrisna https://github.com/gautamkrisna If you can provide more
context around what made this content difficult to understand we'll be able
to properly triage your feedback.
Thank you!
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/MicrosoftDocs/vsts-docs/issues/4081#issuecomment-487702065,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AH66PTMMMFRHR3PSV4DAWKLPS5APTANCNFSM4HI3AVUA
.

--
Regards,
Gautam.


Multiple Youtube warnings and Error - nop download

DO NOT REMOVE OR SKIP THE ISSUE TEMPLATE

[X] I understand that I will be blocked if I intentionally remove or skip any mandatory* field

Checklist

[X] I'm reporting that yt-dlp is broken on a supported site
[X] I've verified that I have updated yt-dlp to nightly or master (update instructions)
[X] I've checked that all provided URLs are playable in a browser with the same IP and same login details
[X] I've checked that all URLs and arguments with special characters are properly quoted or escaped
[X] I've searched known issues and the bugtracker for similar issues including closed ones. DO NOT post duplicates
[X] I've read the guidelines for opening an issue
[X] I've read about sharing account credentials and I'm willing to share it if required

Region
USA
Provide a description that is worded well enough to be understood
Multiple warnings and one error while attempting a download from Youtube
Provide verbose output that clearly demonstrates the problem

[X] Run your yt-dlp command with -vU flag added (yt-dlp -vU <your command line>)
[ ] If using API, add 'verbose': True to YoutubeDL params instead
[X] Copy the WHOLE output (starting with [debug] Command-line config) and insert it below

Complete Verbose Output
C:\Windows\SysWOW64>yt-dlp -vU https://youtu.be/On9c2ITtHek?t=815
[debug] Command-line config: ['-vU', 'https://youtu.be/On9c2ITtHek?t=815']
[debug] Encodings: locale cp1252, fs utf-8, pref cp1252, out utf-8, error utf-8, screen utf-8
[debug] yt-dlp version<EMAIL_ADDRESS>from yt-dlp/yt-dlp [197d0b03b] (win_exe)
[debug] Python 3.10.11 (CPython AMD64 64bit) - Windows-10-10.0.26120-SP0 (OpenSSL 1.1.1t  7 Feb 2023)
[debug] exe versions: ffmpeg n5.1.6-9-gdcdfd7fb62-20241114 (setts)
[debug] Optional libraries: Cryptodome-3.21.0, brotli-1.1.0, certifi-2024.08.30, curl_cffi-0.5.10, mutagen-1.47.0, requests-2.32.3, sqlite3-3.40.1, urllib3-2.2.3, websockets-13.1
[debug] Proxy map: {}
[debug] Request Handlers: urllib, requests, websockets, curl_cffi
[debug] Loaded 1838 extractors
[debug] Fetching release info: https://api.github.com/repos/yt-dlp/yt-dlp/releases/latest
ERROR: Unable to obtain version info (<urllib3.connection.HTTPSConnection object at 0x00000154571A48E0>: Failed to establish a new connection: [WinError 10013] An attempt was made to access a socket in a way forbidden by its access permissions); Please try again later or visit  https://github.com/yt-dlp/yt-dlp/releases/latest
[youtube] Extracting URL: https://youtu.be/On9c2ITtHek?t=815
[youtube] On9c2ITtHek: Downloading webpage
WARNING: [youtube] Unable to download webpage: <urllib3.connection.HTTPSConnection object at 0x000001545744F250>: Failed to establish a new connection: [WinError 10013] An attempt was made to access a socket in a way forbidden by its access permissions
[youtube] On9c2ITtHek: Downloading ios player API JSON
WARNING: [youtube] <urllib3.connection.HTTPSConnection object at 0x0000015457469E40>: Failed to establish a new connection: [WinError 10013] An attempt was made to access a socket in a way forbidden by its access permissions. Retrying (1/3)...
[youtube] On9c2ITtHek: Downloading ios player API JSON
WARNING: [youtube] <urllib3.connection.HTTPSConnection object at 0x000001545746A470>: Failed to establish a new connection: [WinError 10013] An attempt was made to access a socket in a way forbidden by its access permissions. Retrying (2/3)...
[youtube] On9c2ITtHek: Downloading ios player API JSON
WARNING: [youtube] <urllib3.connection.HTTPSConnection object at 0x00000154571A75E0>: Failed to establish a new connection: [WinError 10013] An attempt was made to access a socket in a way forbidden by its access permissions. Retrying (3/3)...
[youtube] On9c2ITtHek: Downloading ios player API JSON
WARNING: [youtube] Unable to download API page: <urllib3.connection.HTTPSConnection object at 0x0000015457468070>: Failed to establish a new connection: [WinError 10013] An attempt was made to access a socket in a way forbidden by its access permissions (caused by TransportError('<urllib3.connection.HTTPSConnection object at 0x0000015457468070>: Failed to establish a new connection: [WinError 10013] An attempt was made to access a socket in a way forbidden by its access permissions'))
[youtube] On9c2ITtHek: Downloading iframe API JS
WARNING: [youtube] Unable to download webpage: <urllib3.connection.HTTPSConnection object at 0x000001545746B550>: Failed to establish a new connection: [WinError 10013] An attempt was made to access a socket in a way forbidden by its access permissions
[youtube] On9c2ITtHek: Downloading mweb player API JSON
WARNING: [youtube] <urllib3.connection.HTTPSConnection object at 0x000001545746BF10>: Failed to establish a new connection: [WinError 10013] An attempt was made to access a socket in a way forbidden by its access permissions. Retrying (1/3)...
[youtube] On9c2ITtHek: Downloading mweb player API JSON
WARNING: [youtube] <urllib3.connection.HTTPSConnection object at 0x00000154574692D0>: Failed to establish a new connection: [WinError 10013] An attempt was made to access a socket in a way forbidden by its access permissions. Retrying (2/3)...
[youtube] On9c2ITtHek: Downloading mweb player API JSON
WARNING: [youtube] <urllib3.connection.HTTPSConnection object at 0x000001545744E440>: Failed to establish a new connection: [WinError 10013] An attempt was made to access a socket in a way forbidden by its access permissions. Retrying (3/3)...
[youtube] On9c2ITtHek: Downloading mweb player API JSON
WARNING: [youtube] Unable to download API page: <urllib3.connection.HTTPSConnection object at 0x00000154574694E0>: Failed to establish a new connection: [WinError 10013] An attempt was made to access a socket in a way forbidden by its access permissions (caused by TransportError('<urllib3.connection.HTTPSConnection object at 0x00000154574694E0>: Failed to establish a new connection: [WinError 10013] An attempt was made to access a socket in a way forbidden by its access permissions'))
ERROR: [youtube] On9c2ITtHek: Failed to extract any player response; please report this issue on  https://github.com/yt-dlp/yt-dlp/issues?q= , filling out the appropriate issue template. Confirm you are on the latest version using  yt-dlp -U
  File "yt_dlp\extractor\common.py", line 742, in extract
  File "yt_dlp\extractor\youtube.py", line 4569, in _real_extract
  File "yt_dlp\extractor\youtube.py", line 4533, in _download_player_responses
  File "yt_dlp\extractor\youtube.py", line 4192, in _extract_player_responses

C:\Windows\SysWOW64>

It looks like yt-dlp is not permitted to make any network requests.

Do not run yt-dlp from C:\Windows\SysWOW64, and do not keep yt-dlp.exe in C:\Windows\SysWOW64

Double check that there isn't some firewall or antivirus software preventing yt-dlp from accessing the internet

Fixed and this can be closed.
"Firewall App Blocker" asked for internet permission which I granted, but it didn't take so I now added it manually.
I also read to start it in c:\yt-dlp directory, but didn't. before and did now.
Thanks bashonly!


Main README cleanup

Description

Related Issue

Motivation and Context

How Has This Been Tested?

Screenshots (if appropriate):
Types of changes

[ ] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

[ ] I have signed the Adobe Open Source CLA.
[ ] My code follows the code style of this project.
[ ] My change requires a change to the documentation.
[ ] I have updated the documentation accordingly.
[ ] I have read the CONTRIBUTING document.
[ ] I have added tests to cover my changes.
[ ] All new and existing tests passed.

@cacheung  I think we don't need to provide the file names for the sample code as SDK users' mobile projects may have different setup with different file/class names.


"gopass recipients remove" deletes recipients based on email not key id

Summary
I got a new computer and I thought this is also a good moment to rotate my GPG key.
So I just created a new key.
I asked a colleague to trust my new public key.
After that I was able to decrypt the secrets.
After that I removed my old key form the project.
gopass recipients remove
I selected the entry with the old gpg key and the process to reencrypting the secrets started.
After checking the recipients with..
gopass recipients
.. I noticed that not just my old key was removed but also my new one 🫤
The only thing both keys had in common was my email.
I have used the same email again.
It is just a new computer, not a new identity.
Therefore I guess the removal logic is using the email and not the key-id as it should be in my POV.
Steps To Reproduce
had no time to make further tests
Expected behavior
my new key should stay in the list of recipients and I am still able to decrypt the secrets
Environment

OS: Apple M1 Pro
OS version: Ventura 13
gopass Version: gopass 1.14.10 go1.19.3 darwin arm64
Installation method: brew

Additional context
zsh shell

Sounds like a possible bug in the key selection. Sorry. We should indeed use the key ID, if available.

Tried to reproduce this. Without success so far. We're going to need your debug log output.
Please try to reproduce with GOPASS_DEBUG_LOG=/tmp/gopass.log set and provide the (sanitize) log output.

Actually I was able to reproduce a very similar case. This will need some more investigation.
But I guess in the end the recipients handling just tries to be "too clever".


Add support for math functions and constants

This PR adds a math function block. My criteria for which functions were included was mostly about which ones I have ever used in my life, and the list I came up with was:

Math.sin(0)
Math.cos(1)
Math.tan(2)
Math.sqrt(3)
Math.ceil(4)
Math.floor(5)
Math.atan2(6, 7)

And here are the ones that were cut:

Math.asin(0)
Math.acos(1)
Math.atan(2)
Math.log(3)
Math.exp(4)
Math.trunc(5)
Math.round(6)
Math.imul(7, 8)
Math.idiv(9, 10)

In addition to functions, I have also added support for constants on namespaces. It works exactly like enum blocks work; you add a dummy shim function (with the comment attribute constantsShim) and then annotate the constants you want in the dropdown with blockIdentity="qName". I don't do any type checking.
@ganicke I filled in some placeholders for the tooltip text so take a look!

It looks like this (except I removed a few functions from the list, see above).

Why not add them all?

From: Richard Knoll<EMAIL_ADDRESS>Sent: Wednesday, February 21, 2018 2:42:48 PM
To: Microsoft/pxt
Cc: Peli de Halleux; Review requested
Subject: Re: [Microsoft/pxt] Add support for math functions and constants (#3903)
It looks like this (except I removed a few functions from the list, see above).
[math_functions]https://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fuser-images.githubusercontent.com%2F13754588%2F36509699-6729a2ac-1715-11e8-95e8-f7cfc8e07a6c.gif&data=04|01|jhalleux%40microsoft.com|be9cea20257247098d5e08d5797c6fe3|72f988bf86f141af91ab2d7cd011db47|1|0|636548497722314549|Unknown|TWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwifQ%3D%3D|-1&sdata=Swzufdh25lf2Rp4MqXJlnVbJW7uDPpc5NDf4XFFKW3k%3D&reserved=0
—
You are receiving this because your review was requested.
Reply to this email directly, view it on GitHubhttps://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2FMicrosoft%2Fpxt%2Fpull%2F3903%23issuecomment-367502594&data=04|01|jhalleux%40microsoft.com|be9cea20257247098d5e08d5797c6fe3|72f988bf86f141af91ab2d7cd011db47|1|0|636548497722314549|Unknown|TWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwifQ%3D%3D|-1&sdata=CErNVLPbfAz1goCWBBKUR2nV2o1Y6qdquyHa76LRUb4%3D&reserved=0, or mute the threadhttps://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FAD-4KRzfaUsUrJgEfgb2AH9x2VS2jYRZks5tXJvmgaJpZM4SOc2B&data=04|01|jhalleux%40microsoft.com|be9cea20257247098d5e08d5797c6fe3|72f988bf86f141af91ab2d7cd011db47|1|0|636548497722314549|Unknown|TWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwifQ%3D%3D|-1&sdata=A7clxDNdGGXocSqMb6mqfbMOm7wRovxsWHFMrDhlt2s%3D&reserved=0.

@pelikhan take a look at the GIF, the dropdown is so long that it scrolls.

Can we simply use a grid? All good here names are rather short.

From: Richard Knoll<EMAIL_ADDRESS>Sent: Wednesday, February 21, 2018 3:28:21 PM
To: Microsoft/pxt
Cc: Peli de Halleux; Mention
Subject: Re: [Microsoft/pxt] Add support for math functions and constants (#3903)
@pelikhanhttps://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fpelikhan&data=04|01|jhalleux%40microsoft.com|bafe9fb688e844f1cb0908d57982ccfd|72f988bf86f141af91ab2d7cd011db47|1|0|636548525054750179|Unknown|TWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwifQ%3D%3D|-1&sdata=%2FdYSYTmbKAWpBcXMQjHanJHt0kAG1dczi8aXAZU4zUY%3D&reserved=0 take a look at the GIF, the dropdown is so long that it scrolls.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHubhttps://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2FMicrosoft%2Fpxt%2Fpull%2F3903%23issuecomment-367513895&data=04|01|jhalleux%40microsoft.com|bafe9fb688e844f1cb0908d57982ccfd|72f988bf86f141af91ab2d7cd011db47|1|0|636548525054750179|Unknown|TWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwifQ%3D%3D|-1&sdata=GcER10uIUHITTm%2By2JNoU%2FuNCl9n0A%2FvVT0n%2FTh7oXY%3D&reserved=0, or mute the threadhttps://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FAD-4KacnsHMzjhC2n-sx89ETtUd-iwdYks5tXKaTgaJpZM4SOc2B&data=04|01|jhalleux%40microsoft.com|bafe9fb688e844f1cb0908d57982ccfd|72f988bf86f141af91ab2d7cd011db47|1|0|636548525054750179|Unknown|TWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwifQ%3D%3D|-1&sdata=PqItXBO9hg%2Fn2Je1kDUWxs1phVU9YAv7gqxryuIfvXM%3D&reserved=0.

Let ‘s try to be 1-to-1 with JS.

From: Peli de Halleux
Sent: Wednesday, February 21, 2018 3:29:23 PM
To: Microsoft/pxt
Subject: Re: [Microsoft/pxt] Add support for math functions and constants (#3903)
Can we simply use a grid? All good here names are rather short.

From: Richard Knoll<EMAIL_ADDRESS>Sent: Wednesday, February 21, 2018 3:28:21 PM
To: Microsoft/pxt
Cc: Peli de Halleux; Mention
Subject: Re: [Microsoft/pxt] Add support for math functions and constants (#3903)
@pelikhanhttps://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fpelikhan&data=04|01|jhalleux%40microsoft.com|bafe9fb688e844f1cb0908d57982ccfd|72f988bf86f141af91ab2d7cd011db47|1|0|636548525054750179|Unknown|TWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwifQ%3D%3D|-1&sdata=%2FdYSYTmbKAWpBcXMQjHanJHt0kAG1dczi8aXAZU4zUY%3D&reserved=0 take a look at the GIF, the dropdown is so long that it scrolls.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHubhttps://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2FMicrosoft%2Fpxt%2Fpull%2F3903%23issuecomment-367513895&data=04|01|jhalleux%40microsoft.com|bafe9fb688e844f1cb0908d57982ccfd|72f988bf86f141af91ab2d7cd011db47|1|0|636548525054750179|Unknown|TWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwifQ%3D%3D|-1&sdata=GcER10uIUHITTm%2By2JNoU%2FuNCl9n0A%2FvVT0n%2FTh7oXY%3D&reserved=0, or mute the threadhttps://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FAD-4KacnsHMzjhC2n-sx89ETtUd-iwdYks5tXKaTgaJpZM4SOc2B&data=04|01|jhalleux%40microsoft.com|bafe9fb688e844f1cb0908d57982ccfd|72f988bf86f141af91ab2d7cd011db47|1|0|636548525054750179|Unknown|TWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwifQ%3D%3D|-1&sdata=PqItXBO9hg%2Fn2Je1kDUWxs1phVU9YAv7gqxryuIfvXM%3D&reserved=0.

We aren't 1-1 with JS. The functions we support are a subset of the math functions anyway, we are missing a lot of them

Can I get log/exp? Does not make sense to expose E Without those.

From: Richard Knoll<EMAIL_ADDRESS>Sent: Wednesday, February 21, 2018 5:02:44 PM
To: Microsoft/pxt
Cc: Peli de Halleux; Mention
Subject: Re: [Microsoft/pxt] Add support for math functions and constants (#3903)
We aren't 1-1 with JS. The functions we support are a subset of the math functions anyway, we are missing a lot of them
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHubhttps://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2FMicrosoft%2Fpxt%2Fpull%2F3903%23issuecomment-367532077&data=04|01|jhalleux%40microsoft.com|c740a5c38b80448b7f4208d5798ffc5c|72f988bf86f141af91ab2d7cd011db47|1|0|636548581679071552|Unknown|TWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwifQ%3D%3D|-1&sdata=ovOeOAhd%2FkjDfzgfAa0rkkydiYACtz6vWl4gyZk47RM%3D&reserved=0, or mute the threadhttps://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FAD-4KSapwrfKenntR47mIp2sqgPrOU13ks5tXLy0gaJpZM4SOc2B&data=04|01|jhalleux%40microsoft.com|c740a5c38b80448b7f4208d5798ffc5c|72f988bf86f141af91ab2d7cd011db47|1|0|636548581679071552|Unknown|TWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwifQ%3D%3D|-1&sdata=TfCgergz8zTWbPG63iFjIWb12jtAHizuzRL6Lc1Mnpc%3D&reserved=0.

I don't care strongly about what we include, I just want it to look nice and have the useful functions at the top. Never been a fan of grid pickers with text. @samelhusseini any ideas?

Most math functions have symbols so a grid of images might work well here

Works for me. If we wanted, we could split up the "math-y" ones from the JS ones. That is, move ceil, floor, round, and trunc to a different block since they do not have symbols.

It is just going to be a long list I am afraid.

From: Richard Knoll<EMAIL_ADDRESS>Sent: Wednesday, February 21, 2018 6:25:57 PM
To: Microsoft/pxt
Cc: Peli de Halleux; Mention
Subject: Re: [Microsoft/pxt] Add support for math functions and constants (#3903)
Works for me. If we wanted, we could split up the "math-y" ones from the JS ones. That is, move ceil, floor, round, and trunc to a different block since they do not have symbols.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHubhttps://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2FMicrosoft%2Fpxt%2Fpull%2F3903%23issuecomment-367546256&data=04|01|jhalleux%40microsoft.com|0c37aaa5ffaa434190f808d5799b9be1|72f988bf86f141af91ab2d7cd011db47|1|0|636548631604448038|Unknown|TWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwifQ%3D%3D|-1&sdata=osQKb6eSXr%2F%2BepKNBm7%2FbO%2F3jaft0CUJH2HsG9ZrKr0%3D&reserved=0, or mute the threadhttps://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FAD-4KeheUVYAQZLPKV0IUhxziqjySxBcks5tXNA0gaJpZM4SOc2B&data=04|01|jhalleux%40microsoft.com|0c37aaa5ffaa434190f808d5799b9be1|72f988bf86f141af91ab2d7cd011db47|1|0|636548631604448038|Unknown|TWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwifQ%3D%3D|-1&sdata=6UsGuRnm2TqQiJPwAiCuHqLuP1EnyRHTSxQdvD3g1Gc%3D&reserved=0.

We could split the number manipulation from the scientific operands (trig / exp / log etc..)

Let's get those in and add more later.


A call to a deprecated method FPaths::GameDir(). FPaths::ProjectDir() is the replacement.

https://github.com/carla-simulator/carla/blob/fe3cb6863a604f5c0cf8b692fe2b6300b45b5999/Unreal/CarlaUE4/Plugins/Carla/Source/Carla/Commandlet/PrepareAssetsForCookingCommandlet.cpp#L382

Please see https://docs.unrealengine.com/4.26/en-US/API/Runtime/Core/Misc/FPaths/


Time Format

Kind of an issue, but I also seem to have the solution. I have a time stored in my source database, and the users would like this to be displayed in time format h:mm AMPM
This option is available in the drop down in Tabular editor, and seems to work all ok.
If I connect to my tabular model in Excel, this displays as I would expect, but Power BI doesn't seem to like this time format.
HH:mm seems to be fine or H:mm, but any option with an AMPM suffix deosn't seem to agree with Power BI.
I fixed this myself by using a custom format of h:mmAM/PM
Both Excel and PBI now display this as expected. I wondered if it would be useful to replace the current drop down options in Tabular Editor with this version instead to save people the same pain I had trying to figure out what the issue was.
Thanks

Sure - I'll replace the drop down option with your suggestion! Thanks for reporting.

Fixed in 2.9.3


Make mem::uninitialized() and mem::zeroed() const fn

Rendered

I’m inclined to not do anything like this before we get const fn implemented proper, not hacked onto the ye olde const_eval.

Actually I think there is a better way of doing this by using unions:
union MyUnion<T> {
    data: T,
    no_data: (),
}

static X: MyUnion<T> = MyUnion { no_data: () };

So maybe this RFC isn't needed after all...

@nagisa I'll agree based on how close miri is :).
@Amanieu I rather only use unions for FFI. They add zero safety here over the original RFC.

The advantage of using unions is that it will cleanly handle Some(uninitialized) since the no_data in the union inhibits enum layout optimizations.

Hmm? Aren't we getting rid of the option for the proposed usecase? What layout optimizations are there without a tag? I am really confused by that comment.

@Ericson2314 My understanding is that with this RFC as proposed, it would be possible to do something like this:
static X: Option<&T> = unsafe { Some(std::mem::zeroed()) };

Because of the enum layout optimization, the final value of X at runtime would be None. The compiler would have to deal with this during compile-time constant evaluation.
Without this RFC, but with unions, one would instead write
static X: Option<MyUnion<&T>> = Some(MyUnion { no_data: () });

The union would inhibit the layout optimization, so the Option would have a tag, avoiding the corner case.
(Note that I don't think anyone would write either of these in actual code. The point is to demonstrate that the former introduces a compile-time corner case that the latter does not.)

Thanks for the RFC @Amanieu! The libs team discussed this today and the conclusion was that this likely doesn't need an RFC, just a compiler implementation. That is, from the libs perspective, we're fine doing this any time. In light of that I'm going to close, but PRs are of course always welcome!


Study inconsistencies between Flow and MOVE

What Happened
A couple folks at Traffic Signal Ops reported that certain traffic count reports are available in MOVE, but not Flow, and vice versa.
What Should Happen
Reports should be consistently available between MOVE and Flow.
To Reproduce
Steps to reproduce the bug:

Go to Flow
Search for TCS 1346
Click on the intersection
See that no studies are available ("No data for the selected node(s)")
Go to MOVE
Look for the same location (Yorkdale Rd / Allen N Yorkdale Rd Ramp / Yorkdale 401 Allen N Ramp)
See that there are 7 TMCs available

Screenshots
TCS 1346

TCS 1476

Additional Notes
The TSO folks found two cases:

TCS 1346, data in MOVE, not in Flow.
TCS 1476, data in Flow, not in MOVE. In MOVE, the blue marker is allocated for the entire midblock, but there's a traffic signal where the parking lot meets the side road which is not marked as an intersection.

Unsure if these two cases are caused by the same underlying problem or something different.

Haven't looked into it yet, but some quick thoughts.
One very likely culprit is our conflate_artery_centreline process in Airflow.  Each FLOW study is attached to an "arterycode", which describes the location / direction of the study.  To power the centreline-focused interactions in MOVE, we attempt to tie each such arterycode to an intersection or midblock in the centreline.  This process isn't 100% accurate, however; an error there would mean that the arterycode is tied to the wrong centreline location, which would result in the behaviour described here.
We do have a set of manual overrides borrowed from previous work by @aharpalaniTO and others, but that's not likely to be exhaustive either.
Other than that, I'm not sure what else would cause this; when I get back to this (probably after more of the multi-location stuff), I'll check to see if it's a conflate_artery_centreline issue first.  If it is, I'll probably add it to our manual overrides set for now.  If not, I'll have to dig deeper.
I also don't know how we would assess consistency across FLOW and MOVE more systemically: other than one-off bug tickets, I don't have a good way right now to determine the whole set of reports available in FLOW, let alone compare that (or port it over) to MOVE.  Definitely welcome any thoughts from @aharpalaniTO @radumas @jwrcoleman and others who have worked with these datasets / applications longer than I have!

Adrian Hetherington reported another intersection where the data is in Flow, but is missing from MOVE. Intersection is Wilmington Ave and Finch Ave West.
I can't reproduce it though -- I'm seeing studies from the same date in both Flow and MOVE. What I am seeing is different count totals.

@mkewins - the Wilmington and Finch count total mismatch might have been solved by #666 , which fixed a general bug with TMC reports at T-intersections.
The other parts of this look like a potential conflation issue with intersections.  There's quite a large number of "psuedo-intersections" around Yorkdale Rd, mostly where the road meets various expressway ramps:
select count(*), elevatio9, elevatio10 from gis.centreline_intersection where intersec5 like '%Yorkdale Rd%' group by elevatio9, elevatio10;
 count | elevatio9 | elevatio10
-------+-----------+------------
     9 |    501100 | Expressway
     7 |    501300 | Minor
     1 |    504000 | Pedatraian
     1 |    509100 | Cul de sac
    36 |    509200 | Pseudo

We exclude all intersections where elevatio9 > 501700 from both centreline vector tiles and location search, mostly to limit visual / search clutter from trailheads and railway crossings and such.
However, we do include all non-trail intersections when conflating counts against the centreline.  Even with that, though, we still fail to conflate ~300 intersections:
select count(*) from "TRAFFIC"."ARTERYDATA" ad join counts.arteries_intersection ai on ad."ARTERYCODE" = ai.arterycode wh
ere ai.int_id is null;
 count
-------
   287
(1 row)

This unfortunately includes PX 1476:
select * from "TRAFFIC"."ARTERYDATA" ad join counts.arteries_intersection ai on ad."ARTERYCODE" = ai.arterycode where ai.
int_id is null and ad."LOCATION" like '%YORKDALE RD%';
 ARTERYCODE | GEOMCODE | STREET1  | STREET1TYPE | STREET1DIR |        STREET2         | STREET2TYPE | STREET2DIR |            STREET3             | STREET3TYPE | STREET3DIR | STAT_CODE  | COUNT_TYPE |                             LOCATION                              | APPRDIR | SIDEOFINT |  LINKID  | SEQ_ORDER | GEO_ID | arterycode | match_on_case | int_id | geom
------------+----------+----------+-------------+------------+------------------------+-------------+------------+--------------------------------+-------------+------------+------------+------------+-------------------------------------------------------------------+---------+-----------+----------+-----------+--------+------------+---------------+--------+------
       4960 |        0 | YORKDALE | RD          |            | YORKDALE N PARKING LOT |             |            | PX 1476  335M E OF DUFFERIN ST |             |            |<PHONE_NUMBER> | R          | YORKDALE RD AT YORKDALE N PRKG LOT & 335M E OF DUFFERIN (PX 1476) |         |           | 15000025 |           |        |       4960 |             3 |        |
(1 row)

This is a complicated one: from the point of view of the centreline, it's on a midblock, because there's no City road to intersect with.  From the counts / studies point of view, it's at an intersection where one of the roads happens to be a private parking lot entrance.
Part of the complexity here lies in how location is represented in FLOW data:

counts have an arterycode, which include link IDs...
that may or may line up with nodes...
that provide location in (X, Y) coordinates using an old NAD projection that doesn't line up completely with modern projections.

This isn't great, and we should very much try to move away from it when we tackle data pipelines.  (For instance: if these counts were tagged directly with centreline IDs plus lat-long location, that would be great!  Even reliable lat-long location alone would help a great deal.)

Going to suggest the following course of action:

[ ] create metrics around conflation completeness (how many were matched?);
[ ] continue to track / triage incoming bugs around data mismatches, and look for:

[ ] ways to hardcode manual exceptions to the conflation process;
[ ] common patterns / cases in mismatches, for improving the data pipelines;

[ ] find a way to conflate intersection arterycodes against midblocks as a last resort, to help catch cases like this.

Not sure what the priority on any of this should be, though - might make more sense to dive in during data pipeline phases of the project?

One thought would just be to make sure that all signalized intersections are included in the conflation, otherwise defer to data pipeline phase (with suitable warnings applied etc.). I think you've hit on what will be a common problem, where not all traffic signals are at centreline_intersection locations, specifically signals at private driveways or parking lots. See below (white circles are intersections, red circles are traffic signals):

Looking at the traffic_signal layer, there are 206 records where midblock_route is not Null (our traffic_signal layer has not been updated since October 2019 so this might miss a couple new ones)

Another case reported from longitudinal study feedback:

From the bug report and a bit of digging, these studies should have centreline_id = 30026352, but are instead conflated to centreline_id = 13465353.
Looking deeper, this is the result of conflation for arterycode 11309:
flashcrow=> select * from counts.arteries_intersection where arterycode=11309;
 arterycode | match_on_case |  int_id  |                        geom
------------+---------------+----------+----------------------------------------------------
      11309 |             2 | 13465353 |<PHONE_NUMBER>E610000057E12CAB04D753C0E8D43A1640D44540

However, further exploration reveals a conflicting picture: centreline_id = 13465353 is a better spatial match for this arterycode, but centreline_id = 30026352 matches up better with the FILE_NAME that describes this as being at Sumach and Shuter!  (Welcome to the fun, fun world of legacy data.)
Because of this, it's unclear how to proceed.  Do we do nothing?  Do we enter a manual override, which also risks mislabelling this arterycode?  How do we make decisions like this in general, and how do we explain those decisions to our users?
Further Exploration
We first query to get at the arterycode:
flashcrow=> select * from "TRAFFIC"."COUNTINFOMICS" where "COUNT_INFO_ID" in (select count_group_id from counts.studies where centreline_id = 13465353);

 COUNT_INFO_ID | ARTERYCODE | COUNT_TYPE |     COUNT_DATE      | DAY_NO | COMMENT_ |               FILE_NAME                | SOURCE1 | SOURCE2 |      LOAD_DATE      | TRANSFER_REC | CATEGORY_ID
---------------+------------+------------+---------------------+--------+----------+----------------------------------------+---------+---------+---------------------+--------------+-------------
         32659 |      11309 | R          | 2015-06-22 00:00:00 |      2 |          | Crunch..EF06.23 & EF06.23 & EF07.07.15 |         |         |                     |              |           5
         36777 |      11309 | R          | 2018-02-27 00:00:00 |      3 |          | 88186_SUMACH_ST_and_SHUTER_ST_BIKE.hex |         |         |                     |              |           5
          8463 |      11309 | R          | 2000-05-30 00:00:00 |      2 |          | YY05.06                                |         |         | 2000-07-12 08:40:53 |           -1 |           5
          6496 |      11309 | R          | 1997-12-01 07:45:00 |      1 |          |                                        |         |         |                     |            0 |           5

match_on_case = 2 here means this is matching using counts.arteries_intersection_int_id, which in turn uses "TRAFFIC"."NODE":
flashcrow=> select * from counts.nodes_intersection where link_id = (select "LINKID"::bigint from "TRAFFIC"."ARTERYDATA" where "ARTER
YCODE" = 11309);
 link_id  | match_on_case |  int_id  |                        geom
----------+---------------+----------+----------------------------------------------------
 13465353 |             1 | 13465353 |<PHONE_NUMBER>E610000057E12CAB04D753C0E8D43A1640D44540

match_on_case = 1 here means it's matched the link_id directly to an intersection ID (which makes sense, they're the same value.)
However, even if we did perform a spatial match instead of matching link_id against the centreline, results here suggest that int_id = 13465353 is in fact a much better match:
SELECT nc.link_id, 2 AS match_on_case, ci.int_id, ci.geom, ci.geom_dist
  FROM counts.nodes_corrected nc
  JOIN LATERAL (
    SELECT
      int_id,
      geom,
      ST_Distance(ST_Transform(nc.geom, 2952), ST_Transform(geom, 2952)) AS geom_dist
    FROM counts.centreline_intersection
    WHERE ST_DWithin(ST_Transform(nc.geom, 2952), ST_Transform(geom, 2952), 30)
    ORDER BY geom_dist ASC
  ) ci ON true
  WHERE nc.link_id = 13465353;

 link_id  | match_on_case |  int_id  |                        geom                        |     geom_dist
----------+---------------+----------+----------------------------------------------------+-------------------
 13465353 |             2 | 13465353 |<PHONE_NUMBER>E610000057E12CAB04D753C0E8D43A1640D44540 | 0.120069462801905
 13465353 |             2 | 30026352 |<PHONE_NUMBER>E61000006F07342202D753C0B1AD253843D44540 |  16.5067114852413

Another "we need midblock TMCs" report, near Morningside and Beath:

Could not find TMC at Morningside and West Hill Collegiate Access, but available on Flow

Centreline-wise this is a midblock, but in reality there's an intersection there with a private driveway to West Hill Collegiate Institute.

Another "we need midblock TMCs" report, near Bayview and Blythwood:

I just noticed that the attached tmc at the driveway to 1929 Bayview is in Flow but not in Move.

A report of a TMC that was conflated to the wrong intersection:

A turning movement count (TMC) for ""VAUGHAN RD AT MOIR AVE AND WINONA DR (PX 802)"" shows up in FLOW, the date is 2018-02-15.
The TMC report doesn't show up for that location in MOVE. In fact, by looking at the studies for the surrounding midblocks / intersections, it appears that the TMC has been assigned to the intersection directly to the Northwest:
https://move.intra.qa-toronto.ca/view/location/s1:AMQsmB/POINTS/reports/TMC

Searching for px:802 jumps to the expected location, where (as mentioned) there are no TMCs.  This looks like a mis-conflation of the underlying arterycode:
flashcrow=> select * from "TRAFFIC"."COUNTINFOMICS" where "COUNT_INFO_ID" = 36723;
 COUNT_INFO_ID | ARTERYCODE | COUNT_TYPE |     COUNT_DATE      | DAY_NO |                                                                                COMMENT_                                                                                |                FILE_NAME                | SOURCE1 | SOURCE2 | LOAD_DATE | TRANSFER_REC | CATEGORY_ID
---------------+------------+------------+---------------------+--------+-------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------+-----------------------------------------+---------+---------+-----------+--------------+-------------
         36723 |       5865 | R          | 2018-02-15 00:00:00 |      5 | NBL: Moir Ave to WB Vaughan Rd, NBT: Moir Ave to EB Vaughan Rd, NBR: Moir Ave to SB Winina Dr, SOTH: Moir Ave to NB Winona Dr, EOTH: WB Vaughan Rd to Moir Ave, WOTH: EB Vaughan Rd to Moir Ave | 88205_VAUGHAN_RD_and_WINONA_DR_BIKE.hex |         |         |           |              |           5
(1 row)

flashcrow=> select * from "TRAFFIC"."ARTERYDATA" where "ARTERYCODE" = 5865;
 ARTERYCODE | GEOMCODE | STREET1 | STREET1TYPE | STREET1DIR | STREET2 | STREET2TYPE | STREET2DIR | STREET3 | STREET3TYPE | STREET3DIR | STAT_CODE  | COUNT_TYPE |                   LOCATION                    | APPRDIR | SIDEOFINT |  LINKID  | SEQ_ORDER | GEO_ID
------------+----------+---------+-------------+------------+---------+-------------+------------+---------+-------------+------------+------------+------------+-----------------------------------------------+---------+-----------+----------+-----------+--------
       5865 |        0 | VAUGHAN | RD          |            | WINONA  | DR          |            | PX 802  |             |            |<PHONE_NUMBER> | R          | VAUGHAN RD AT MOIR AVE AND WINONA DR (PX 802) |         |           | 13460056 |           |
(1 row)

flashcrow=> select * from counts.arteries_centreline where arterycode = 5865;
 arterycode | centreline_type | centreline_id | direction |                        geom
------------+-----------------+---------------+-----------+----------------------------------------------------
       5865 |               2 |      13459974 |           |<PHONE_NUMBER>E6100000B34523B6F3DB53C04C9994B55FD84540
(1 row)

flashcrow=> select * from gis.centreline_intersection where int_id = 13459974;
   gid   |  int_id  | elev_id |        intersec5         | classifi6 |     classifi7      | num_elev | elevatio9 | elevatio10 | elev_level | elevation | elevatio13 | height_r14 | height_r15 |     x     |      y      |   longitude   |   latitude   | objectid |                        geom
---------+----------+---------+--------------------------+-----------+--------------------+----------+-----------+------------+------------+-----------+------------+------------+------------+-----------+-------------+---------------+--------------+----------+----------------------------------------------------
 2380937 | 13459974 |    2400 | Vaughan Rd / Jesmond Ave | MNRSL     | Minor-Single Level |        1 |    501300 | Minor      |          0 |         0 |            |          0 |            | 309883.05 | 4838721.236 | -79.436749968 | 43.690420816 |    17452 |<PHONE_NUMBER>E6100000B34523B6F3DB53C04C9994B55FD84540
(1 row)

This conflation has match_on_case = 1, corresponding to the counts.arteries_intersection_manual_corr view.  Looking deeper into the view query results, the correct conflation is in fact a possible value:
 arterycode |  int_id  | ranking
------------+----------+----------
       5865 | 13459974 | 13459974
       5865 | 13460056 | 13460056

However, ranking is just using int_id, which results in a preference for the incorrect conflation here.

The above push seems to address the cases mentioned here - closing for now, and we can re-open one-off tasks as needed.

The above push seems to address the cases mentioned here - closing for now, and we can re-open one-off tasks as needed.


Metrics getters

This adds some methods to Rate and Histogram to make it easier to retrieve values as they're being collected.  In particular  they should help make it easier in tests to verify that metrics are properly being collected with the right values.
Also did a little refactoring in Histogram to get rid of the obsolete Snapshot.

[Current coverage][cc-pull] is 84.62% (diff: 85.10%)

Merging [#436][cc-pull] into [master][cc-base-branch] will decrease coverage by 0.06%

@@             master       #436   diff @@
==========================================
  Files            75         75
  Lines          3807       3818    +11
  Methods        3569       3579    +10
  Messages          0          0
  Branches        238        239     +1
==========================================
+ Hits           3224       3231     +7
- Misses          583        587     +4
  Partials          0          0

Powered by Codecov. Last update [20edefe...1d8d3ad][cc-compare]
[cc-base-branch]: https://codecov.io/gh/tumblr/colossus/branch/master?src=pr
[cc-compare]: https://codecov.io/gh/tumblr/colossus/compare/20edefe580b3f66bc28770a6f9d5095d5f8dee6f...1d8d3ad5df4641fb1b3610402ce7304cce41eaa0?src=pr
[cc-pull]: https://codecov.io/gh/tumblr/colossus/pull/436?src=pr

Also adding a fix for #437

👍


Use Junit annotations properly in CheckFieldInitNegativeCases.T6

The test case is only testing that we recognize those annotations,
but on a proper Junit test, @BeforeClass must be a static method
and initialize static fields, so lets use it that way.

Doing a PR for bookkeeping, but will just merge as soon as C.I. goes green, this is just a test case change.

Merging now, but the static initializer test case needs a corresponding positive test case as soon as we have support for checking initialization of static fields.


[WebConsoleV2] Workflow & Jobs execution details

Workflow execution details
Refactor project list, table view turn  to use  Antd Table
Flow chart: Introduce Execution type Job node
Introduce workflow/project hooks

LGTM

LGTM


Move Launchpad references to my temp GitHub for now

In the future, we'll hopefully get busybox converted over to oci-import so that this will no longer be necessary and we can delete this whole file instead (in favor of a busybox file instead).
Fixes https://github.com/docker-library/meta-scripts/issues/25

Unfortunately, this does mean that we're no longer verifying that our oci-import jobs do not accidentally hit our "missing .git suffix" error, but I don't think that tiny benefit is worth keeping this actively up-to-date with the latest Ubuntu releases.
https://github.com/docker-library/meta-scripts/blob/b446700b3ec0b10ef89204ab585ceb862f131da5/meta.jq#L75


svelte-kit sync fails without ./src/routes directory

Describe the bug
When svelte-kit sync runs during the prepare hook you're met with this ugly error if you don't have a routes directory in src
> ENOENT: no such file or directory, scandir '/path/to/my/project/src/routes'

If your project primarily uses svelte-kit package then you don't need a routes directory. Since git doesn't clone empty directories the issue is a bit more serious than it seems.
Reproduction
npm init svelte my-app
cd my-app
rm -rf src/routes
npm install

Logs
No response
System Info
N/A
Severity
annoyance
Additional Information
No response

@Rich-Harris I've been wanting to dig into sync. Want me to take a look?

that would be super helpful, thanks! i'd wager we just need to wrap https://github.com/sveltejs/kit/blob/01d9d30c1a7f71524e3fcc552bcb1f7de109f6db/packages/kit/src/core/sync/create_manifest_data/index.js#L87 in an if block, but i haven't tested that hypothesis

@Rich-Harris
Your hunch was correct! #5008. Looks like there's an issue with the Vercel deployments and it was attacked by the "renders error page for missing page" test monster, but everything tests successfully when run locally on Ubuntu and Windows.


Update Pendragon-french.css

Removed missing image, causing display issues on the sheet

Submission Checklist
Required

[ ] The pull request title clearly contains the name of the sheet I am editing.
[ ] The pull request title clearly states the type of change I am submitting (New Sheet/New Feature/Bugfix/etc.).
[ ] The pull request makes changes to files in only one sub-folder.
[ ] The pull request does not contain changes to any json files in the translations folder (translation.json is permitted)

New Sheet Details

The name of this game is: <   >  (i.e. Dungeons & Dragons 5th Edition, The Dresden Files RPG)

The publisher of this game is: <   > (i.e. Wizards of the Coast, Evil Hat)

The name of this game system/family is: <   > (i.e. Dungeons & Dragons, FATE)

[ ] I have followed the Character Sheets Standards when building this sheet.

[ ] This sheet has been made on behalf of, or by, the game's publisher.
[ ] This game is not a traditionally published game, but a copy of the game rules can be purchased/downloaded/found at: <   >
[ ] This sheet is for an unofficial fan game, modification to an existing game, or a homebrew system.

Changes / Description

Character Sheet Info Roll20 Internal Use only.

Hello,
Thank you - how long before the merge is actually compiled? I see no change in the character sheet yet


Fixed #28048 -- Allowed generic date views to use related fields as date_field.

This PR tries to resolve a small issue on the date generic views. On the date generic views right now you cannot specify as a date_field a related field (you get FieldDoesNotExist).

Hi @timgraham,
Could you have a look on this. I've updated the PR.
Thanks,
Lefteris Nikoltsios

After you update a PR, uncheck "Patch needs improvement" on the ticket so that it returns to the review queue.

About your comment:
Some helper or something is needed because the current code is quite difficult to read and understand.

I created a helper function under db/models/utils.py.

Closing due to inactivity.


Unable to Add QR image iOS

Unable to link QR image shared to someone in IoS.
User gets just gift text not the QR image linked to it.

duplicate


No permission to access microphone

Seems the app has no permission to access the microphone and I can find no way to give it access to the microphone because of the wrapper. Any solutions?

I'm pretty sure there's an option you can click in the settings that gives it to you. I would check but the site seems to be down right now as I'm getting a cloudflare page when I try to open the app. I'll check back later.

@jacobmischka yeah it's down at the moment (I can't chat with my friends! meh) anyway there's no setting I can find in the Discord Website itself, and I'm sure it's talking about telling the browser to give permission, but in this case since the browser interface is hidden I am unable to do so.

Yeah, just click the "access to your microphone" link and it should automatically give you permissions.

Case of user error I didn't know it was clickable thanks!


Selection of internal node using keyboard

On leaf nodes, pressing space selects the node. On internal nodes, the same action toggles the collapsed state of the node, making it impossible to select it like you can using the mouse. Would it be possible to either change the behavior of space to also select internal nodes, or at least provide a boolean switch where we can toggle between the two behaviors?
The following lines of code shows the default behavior of the space keydown event:
https://github.com/brimdata/react-arborist/blob/main/packages/react-arborist/src/components/default-container.tsx#L175-L180

You make a good point. There is no way to select an internal node. Since the left and right arrows open and close nodes, it would make sense that the space key could select it.
When I set up these keyboard interactions I was guided by https://developer.mozilla.org/en-US/docs/Web/Accessibility/ARIA/Roles/tree_role, and by looking at other Trees.
For example, this is the behavior for VSCode's tree view. The space key opens and closes folders, it does not select them.
https://github.com/brimdata/react-arborist/assets/3460638/9efd6d4a-b42f-45be-9f32-fe05a7137e4b
I will address this problem though by making the keyboard interaction mapping customizable. Then you could easily assign the space key to do whatever you'd like.
I'm going to close this in favor of #57
Thank you for your feedback!


Issues in todo_app_sqlite

I located a couple of issues when running the example https://github.com/leptos-rs/leptos/tree/main/examples/todo_app_sqlite with cargo leptos serve:
When you add an item:
error deserializing server function results Semantic(None, "invalid type: string, expected map")
When you delete an item looks fine.
When I check the requests in the network tab I can see:

There's a reference to wasm that doesn't exist in the server: http://localhost:3000/pkg/todo_app_sqlite_bg.wasm
I would love to fix them, but I'm still learning how the system works...

@gbj is right, in the most recent cargo-leptos release paired with the latest leptos on git, we changed the variable name from OUTPUT_NAME to LEPTOS_OUTPUT_NAME. cargo-leptos should set this env var, and if it doesn't it assumes you are using wasm-pack. You should be able to fix this by using a git dependency for leptos, and I'll see if we can get a new release to bring things back into sync.

With latest git version and updated cargo leptos(I had 0.1.0, but after upgrading to 0.1.2) this issue is no longer reproduced.
So my bad, I was using an outdated cargo leptos :|

Okay, awesome!


Update all 2.0 samples to use M.A.App, aka Microsoft.AspNetCore.App

This is the master issue.

Recommendation: Use https://github.com/aspnet/Docs/issues/5495 because it has all of the samples listed (e.g., project.json samples slipped through the cracks on prior update attempts) and authors won't trip over each other trying to get all of the samples updated. I marked the ones that I'd like to handle, if that's ok. I built most of the ones that I self-assigned.


Add support for textDecorationLine to Android

Attached PR adds support for the none, underline, line-through, and 'underline line-through' textDecorationLine style elements to Android, and, updates the UIExplorer to display these options.
Note that textDecorationColor and textDecorationStyle have not been added as well because there is no straight-forward way to support these options in Android.

Maybe close this PR inf avor of #3819. Discussion is happening there.

Yeah. As the other PR mentions, this one can be closed.


Create world configuration structure.

[x] Create a World Config loader, like the User Config loader
[x] Create world configuration files

This blocks #5

All done now.


Upgrade to Nativescript 7

The code in this project is not up to date with current Nativescript practices (e.g. there are imports that use tns-core-modules).  Are there any plans to update this in the near future?  (For the record, this plugin currently does appear to work in NS 7.)

The plugin does work fine with NS7, the demo app has not been updated yet as it is a fairly low priority, but at some point will be.

Thanks.  Sorry to bother about it.  I just wanted to be sure it was future-proof.  It is a very good plugin, and I rely on it quite a bit.


Proposal for opaque bearer token auth #1043

Proposal for issue https://github.com/kubernetes-incubator/service-catalog/issues/1043
Note that it relies on the assumption that https://github.com/kubernetes-incubator/service-catalog/pull/1037 is implemented in accordance with its current design proposal.

/cc @liggitt, @arschles, @bmelville, @rifung

@nilebox lgtm, should work for us. 👍

why is this a PR instead of just an issue?


docs: fix title and add link for building guide

Problem
What is being fixed?  Examples:

Documentation

Change overview
Documentation has slightly incorrect reference to another section. On the first read, I didn't understand that it was referring to the previous section of the docs. Added an intradocument link to make it easier on the user.
Testing

Tested by pushing to my fork and verifying that it looks good and the link works.

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

@presto8 Needs restyled updates.


mark nomination-pool funds as deactivated

    As a follow-up, all funds locked in nomination pools also have to be marked as deactivated now.

The migration will be O(pool_count). Each pool would look at its bonded account ledger.total and mark that as deactivated.
Originally posted by @kianenigma in https://github.com/paritytech/substrate/issues/12813#issuecomment-1336405691

I took a stab at this, but given the low TVL of pools, if we manage to make pool funds usable for governance soon, it is not worth it.
diff --git a/frame/nomination-pools/src/lib.rs b/frame/nomination-pools/src/lib.rs
index 3cb8abedda..54891f22ee 100644
--- a/frame/nomination-pools/src/lib.rs
+++ b/frame/nomination-pools/src/lib.rs
@@ -900,9 +900,8 @@ impl<T: Config> BondedPool<T> {

 	/// Bond exactly `amount` from `who`'s funds into this pool.
 	///
-	/// If the bond type is `Create`, `Staking::bond` is called, and `who`
-	/// is allowed to be killed. Otherwise, `Staking::bond_extra` is called and `who`
-	/// cannot be killed.
+	/// If the bond type is `Create`, `Staking::bond` is called, and `who` is allowed to be killed.
+	/// Otherwise, `Staking::bond_extra` is called and `who` cannot be killed.
 	///
 	/// Returns `Ok(points_issues)`, `Err` otherwise.
 	fn try_bond_funds(
@@ -934,6 +933,9 @@ impl<T: Config> BondedPool<T> {
 			BondType::Later => T::Staking::bond_extra(&bonded_account, amount)?,
 		}

+		// the funds in nomination pools are not usable for governance, ergo marked as deactive
+		T::Currency::deactivate(amount);
+
 		Ok(points_issued)
 	}

@@ -1835,6 +1837,9 @@ pub mod pallet {
 			)
 			.defensive()?;

+			// re-activate the funds.
+			T::Currency::reactivate(balance_to_unbond);
+
 			Self::deposit_event(Event::<T>::Withdrawn {
 				member: member_account.clone(),
 				pool_id: member.pool_id,
@@ -2586,6 +2591,7 @@ impl<T: Config> OnStakerSlash<T::AccountId, BalanceOf<T>> for Pallet<T> {
 		// anything here.
 		slashed_bonded: BalanceOf<T>,
 		slashed_unlocking: &BTreeMap<EraIndex, BalanceOf<T>>,
+		total_slashed: BalanceOf<T>,
 	) {
 		if let Some(pool_id) = ReversePoolIdLookup::<T>::get(pool_account) {
 			let mut sub_pools = match SubPoolsStorage::<T>::get(pool_id).defensive() {
@@ -2606,5 +2612,9 @@ impl<T: Config> OnStakerSlash<T::AccountId, BalanceOf<T>> for Pallet<T> {
 			Self::deposit_event(Event::<T>::PoolSlashed { pool_id, balance: slashed_bonded });
 			SubPoolsStorage::<T>::insert(pool_id, sub_pools);
 		}
+
+		// this will simply subtract the amount that was slashed from `ActiveIssuance`, so that when
+		// we calculate `total_issuance - active_issuance`, it remains accurate.
+		T::Currency::reactivate(total_slashed);
 	}
 }
diff --git a/frame/nomination-pools/src/tests.rs b/frame/nomination-pools/src/tests.rs
index 7d5d418bbf..a347451396 100644
--- a/frame/nomination-pools/src/tests.rs
+++ b/frame/nomination-pools/src/tests.rs
@@ -48,6 +48,10 @@ fn test_setup_works() {
 		assert_eq!(PoolMembers::<Runtime>::count(), 1);
 		assert_eq!(StakingMock::bonding_duration(), 3);
 		assert!(Metadata::<T>::contains_key(1));
+		// all initial balances.
+		assert_eq!(Balances::total_issuance(), 50);
+		// the 10 units in pool.
+		assert_eq!(Balances::inactive_issuance(), 10);

 		let last_pool = LastPoolId::<Runtime>::get();
 		assert_eq!(
diff --git a/frame/root-offences/src/mock.rs b/frame/root-offences/src/mock.rs
index 273fbf6141..e0b2eb7480 100644
--- a/frame/root-offences/src/mock.rs
+++ b/frame/root-offences/src/mock.rs
@@ -145,17 +145,6 @@ impl onchain::Config for OnChainSeqPhragmen {
 	type TargetsBound = ConstU32<{ u32::MAX }>;
 }

-pub struct OnStakerSlashMock<T: Config>(core::marker::PhantomData<T>);
-impl<T: Config> sp_staking::OnStakerSlash<AccountId, Balance> for OnStakerSlashMock<T> {
-	fn on_slash(
-		_pool_account: &AccountId,
-		slashed_bonded: Balance,
-		slashed_chunks: &BTreeMap<EraIndex, Balance>,
-	) {
-		LedgerSlashPerEra::set((slashed_bonded, slashed_chunks.clone()));
-	}
-}
-
 parameter_types! {
 	pub const RewardCurve: &'static PiecewiseLinear<'static> = &REWARD_CURVE;
 	pub static Offset: BlockNumber = 0;
@@ -163,7 +152,6 @@ parameter_types! {
 	pub static SessionsPerEra: SessionIndex = 3;
 	pub static SlashDeferDuration: EraIndex = 0;
 	pub const BondingDuration: EraIndex = 3;
-	pub static LedgerSlashPerEra: (BalanceOf<Test>, BTreeMap<EraIndex, BalanceOf<Test>>) = (Zero::zero(), BTreeMap::new());
 	pub const OffendingValidatorsThreshold: Perbill = Perbill::from_percent(75);
 }

@@ -192,7 +180,7 @@ impl pallet_staking::Config for Test {
 	type MaxUnlockingChunks = ConstU32<32>;
 	type HistoryDepth = ConstU32<84>;
 	type VoterList = pallet_staking::UseNominatorsAndValidatorsMap<Self>;
-	type OnStakerSlash = OnStakerSlashMock<Test>;
+	type OnStakerSlash = ();
 	type BenchmarkingConfig = pallet_staking::TestBenchmarkingConfig;
 	type WeightInfo = ();
 }
diff --git a/frame/staking/src/lib.rs b/frame/staking/src/lib.rs
index<PHONE_NUMBER>..dfc97ad4a3 100644
--- a/frame/staking/src/lib.rs
+++ b/frame/staking/src/lib.rs
@@ -678,8 +678,9 @@ impl<T: Config> StakingLedger<T> {
 		// clean unlocking chunks that are set to zero.
 		self.unlocking.retain(|c| !c.value.is_zero());

-		T::OnStakerSlash::on_slash(&self.stash, self.active, &slashed_unlocking);
-		pre_slash_total.saturating_sub(self.total)
+		let total_slashed = pre_slash_total.saturating_sub(self.total);
+		T::OnStakerSlash::on_slash(&self.stash, self.active, &slashed_unlocking, total_slashed);
+		total_slashed
 	}
 }

diff --git a/primitives/staking/src/lib.rs b/primitives/staking/src/lib.rs
index 9eb4a4890c..ba36cf3cd7 100644
--- a/primitives/staking/src/lib.rs
+++ b/primitives/staking/src/lib.rs
@@ -42,15 +42,17 @@ pub trait OnStakerSlash<AccountId, Balance> {
 	/// * `slashed_active` - The new bonded balance of the staker after the slash was applied.
 	/// * `slashed_unlocking` - A map of slashed eras, and the balance of that unlocking chunk after
 	///   the slash is applied. Any era not present in the map is not affected at all.
+	/// * `total_slashed` - The total amount that was slashed.
 	fn on_slash(
 		stash: &AccountId,
 		slashed_active: Balance,
 		slashed_unlocking: &BTreeMap<EraIndex, Balance>,
+		total_slashed: Balance,
 	);
 }

 impl<AccountId, Balance> OnStakerSlash<AccountId, Balance> for () {
-	fn on_slash(_: &AccountId, _: Balance, _: &BTreeMap<EraIndex, Balance>) {
+	fn on_slash(_: &AccountId, _: Balance, _: &BTreeMap<EraIndex, Balance>, _: Balance) {
 		// Nothing to do here
 	}
 }

I want to still pursue this as a PR to track TVL of Pools.


ion-android-more-horizontal and ion-android-more-vertical not availble

Hey there, I've updated my CLI, created a blank project, but the ion-android-more-horizontal and ion-android-more-vertical icons are not available even though they appear on ionicons. I would HEART these icons to be available :)

Hey Sean. They are available in the newest version of Ionicons 2.0 (which Ionic currently is not using, but will with RC0). Just make sure you download and update to the latest version and you should be good to go.


bash: fix parsing of command substitution

This addresses bad corrections like the following (note the position of the -p flag):
thefuck 'git log $(git ls-files thefuck | grep python_command) -p'
git log $(git ls-files thefuck | grep -p python_command) [enter/↑/↓/ctrl+c]

After the changes in this PR, the above command looks like this instead:
thefuck 'git log $(git ls-files thefuck | grep python_command) -p'
git log -p $(git ls-files thefuck | grep python_command) [enter/↑/↓/ctrl+c]

This is done by using bashlex to parse bash, rather than shlex. bashlex does have a few limitations, so shlex is still used as a fallback in case bashlex fails.

Coverage decreased (-2.8%) to 90.446% when pulling 4ae32cf4ee8cc69d73930f4565c55097cb1f5ce2 on josephfrazier:bash-command-substitution into e0b5d47fa5a716879d44bf3ddfef72a8d36905a3 on nvbn:master.

Hmm, it looks like AppVeyor had some brief bugginess earlier. Here's a successful rebuild of the same commit: https://ci.appveyor.com/project/josephfrazier/thefuck/build/1.0.14

Thanks!


adding hack to add git hashing to report

In the Storage WG meeting I made a suggestion for having the benchmark check the code.  This is an example of how that could work.  It will add a 'git' section to the .json report with a git hash and if relevant a diff showing what has been changed.

recheck


flake8 tweaks

Thank you @scop, this looks good! However, in order to avoid regressions, it would be nice if things like this were caught automatically. We're already running pep8 as part of our test suite, so it probably just needs some configuration changes (http://pep8.readthedocs.io/en/release-1.7.x/intro.html#configuration). Would you like to give it a shot?

pep8 is obsoleted by pycodestyle, and flake8 takes care of pycodestyle and pyflakes. So I've combined the test envs into one in these new commits, plus added flake8-import-order to check the order of imports.

Looks great, thank you!


Debug SQL Connection Issue

check if sql manager doesn't close ever?
last resort would be to increase connection max
another option is to close the connection in sql manager
something else is maybe try initializing the sql connection inside the lambda
not sure about this one but if sql connection is made, layer is replaced, RDS won't know it was updated and we need to close it. an option is to prevent SQL manager to be updated this frequently and see how it affects the issue

@jieunkxx @yunmiju please add to this if you have any other guesses


Update gc.pp

Please check if the fact exists, because it is not deployed by default.

Hello:
Same error as in #108. If you add that to the gemfile in 108 and rebase, it will work.

@jyaworski Done. I am afraid I will never learn how to perform a rebase properly. :(

Thanks. Can you rebase and squash?
https://www.git-scm.com/book/en/v2/Git-Branching-Rebasing
git fetch upstream master
git rebase -i upstream/master

@jyaworski Done

Thanks @dhoppe for the contribution!


Update SdFatConfig.h

Make SDFAT_FILE_TYPE and USE_UTF8_LONG_NAMES configurable without code changes (e.g. using build_flags)

Thanks, @TheNitek .  This looks fine.  But, I'm not sure that anything other than the current settings will work w/SDFS.  Have you tried other types of SDFat::File types?

I changed the config to 3 and migrated my project to FsFiles. Seems to work great with a ExFat formated SD card.


DRILL-5226: Managed external sort fixes

Memory leak in managed sort if OOM during sv2 allocation
"Record batch sizer" does not include overhead for variable-sized
vectors
Paranoid double-checking of merge batch sizes to prevent OOM when the
sizes differ from expectations
Revised logging

+1


Update chroma integration to support 1.5.0

1.5.0 has a breaking change that swaps to named inputs from positional.
Can you assign this issue to me?

Hey @jeffchuber, this PR should be merged and released with a fix tomorrow: https://github.com/hwchase17/langchainjs/pull/1348

@jacoblee93 incredible! 🚀


Example's behavior is not correct

Describe the bug
In the simplest example, if I drag "Box" into "Dustbin", the alert message keeps printing "The glass is dropped into glass" instead of "into dustbin".
After some debugging, I found that the example code is wrong(Might attribute to the API interface change recently, I guess?)
The code
end: (dropResult?: { name: string }) => {
      if (dropResult) {
        alert(`You dropped ${name} into ${dropResult.name}!`)
      }
    },

should be turned into
end: (item: { name: string }, monitor: DragSourceMonitor) => {
    const dropResult = monitor.getDropResult();
      if (dropResult) {
        alert(`You dropped ${name} into ${dropResult.name}!`)
      }
    },

In addition, I found several discrepancies between the newest version and the document, which is quite unfriendly to the new users.
I hope that someone would come and update the docs, thanks
Reproduction
Live Reproduction
Steps to reproduce the behavior:

Just open the first example
https://react-dnd.github.io/react-dnd/examples/dustbin/single-target

Screenshots
If applicable, add screenshots to help explain your problem.
Desktop (please complete the following information):

OS: MacOs Mojava
Browser chrome
Version 75.0.3770.142

Thanks for the report! I've corrected the example you pointed out. I'll try to take a pass through the docs later in the month - if you could help us by identifying which pieces of documentation you found particularly confusing or wrong, that will help.


Vagrantfile: Support additional mounts.

Add support for an arbitrary number of folder mounts in addition to the cilium repo itself.
Environment variable USER_MOUNTS can be set to a comma-separated list of mount specifications. Each mount specification can be simply a directory name relative to the home directory, or include a '=' character separating the destination mount point from the host directory.
Examples:

USER_MOUNTS=foo
Mounts ~/foo as /home/vagrant/foo.

USER_MOUNTS=foo,/tmp/bar=/tmp/bar
Mounts host directory ~/foo as /home/vagrant/foo in the VM, and host
directory /tmp/bar as /tmp/bar in the VM.

Signed-off-by: Jarno Rajahalme<EMAIL_ADDRESS>

test-me-please

Awesome!


Issue evaluating models and support for Falcon2 VLM

Hi, I could see there is a recent push on the reproducing the benchmarks results for Molmo series. I am trying to evaluate the model on various benchmarks. I am using the following command
python run.py --data MME --model molmo-7B-O-0924 --verbose
The command downloads the dataset to my local but for some reason it is not running the evaluation. I double checked the outputs folder but I don't see any csv being generated containing the results. Here are the few things I tried.

Tried with a different model and dataset and it didn't get evaluation results for any of them.
Added the LMU path as part of the .env file and part of environment variable - No luck.
Even tried with the torch run command and no luck.

Could you please direct me on getting the evaluation results?
Also I would like to get the evaluation reproduced for Falcon2-VLM-11B model. Can you add the support for that model as part of the vlm class and config.py?
Thanks

Resolved

Hi, @Venkatesh-Balavadani ,
We have added it to our todo list and are working on it.

Added in #556