vim fails to compile on RHEL 9 with clang: file format not recognized

Steps to reproduce
Here are the steps that I am using to build vim.  They worked recently on RHEL 7.9 and RHEL 8.4.  However on RHEL 9.2 make -j8 fails with objects/option.o: file not recognized: file format not recognized.
sudo mkdir /opt/vim
sudo chown $USER /opt/vim
cd /opt/vim
wget https://github.com/vim/vim/archive/master.zip
unzip master.zip
rm master.zip
cd ./vim-master/src

CC=clang CXX=clang++ CFLAGS= LD=clang LDFLAGS=-rdynamic \
   ./configure --enable-cscope \
               --enable-fail-if-missing \
               --enable-perlinterp=yes \
               --enable-python3interp=yes \
               --enable-terminal \
               --with-python3-command=python3.8

make -j8 # This is the step that fails
sudo make install

Expected behaviour
make completes successfully
Version of Vim
9.1.285 (BCD=0x11d; DATE_ONLY="2024 Jan 02")
Environment
Operating System: Red Hat Enterprise Linux 9.2 (Plow)
Terminal: XTerm(366) via PuTTY
$TERM: xterm
shell:  ksh
$KSH_VERSION:  Version AJM 93u+m/1.0.0-beta.1 2021-05-10

Logs and stack traces
I believe that these are the most relevant portions of the output from `make`:

clang -c -I.  -D_REENTRANT -D_GNU_SOURCE -O2 -flto=auto -ffat-lto-objects -fexceptions -g -grecord-gcc-switches     -specs=/usr/lib/rpm/redhat/redhat-hardened-cc1 -fstack-protector-strong -specs=/usr/lib/rpm/redhat/redhat-annobin-cc1 -m64 -march=x86-64-v2 -mtune=generic -fasynchronous-unwind-tables -fstack-clash-protection -fcf-protection -fwrapv  -I/usr/local/include -D_LARGEFILE_SOURCE -D_FILE_OFFSET_BITS=64  -I/usr/lib64/perl5/CORE   -I/home/ztoth/.pyenv/versions/3.8.18/include/python3.8 -pthread -fPIE   -Iproto -DHAVE_CONFIG_H -DFEAT_GUI_MOTIF     -g -O2 -D_REENTRANT -U_FORTIFY_SOURCE -D_FORTIFY_SOURCE=1              -o objects/option.o option.c

...

  clang   -Wl,--enable-new-dtags -Wl,-z,relro -Wl,--as-needed -Wl,-z,now -specs=/usr/lib/rpm/redhat/redhat-hardened-ld -specs=/usr/lib/rpm/redhat/redhat-annobin-cc1   -rdynamic -L/usr/local/lib       -o vim objects/alloc.o objects/arabic.o objects/arglist.o objects/autocmd.o objects/beval.o objects/buffer.o objects/change.o objects/blob.o objects/blowfish.o objects/cindent.o objects/clientserver.o objects/clipboard.o objects/cmdexpand.o objects/cmdhist.o objects/crypt.o objects/crypt_zip.o objects/debugger.o objects/dict.o objects/diff.o objects/digraph.o objects/drawline.o objects/drawscreen.o objects/edit.o objects/eval.o objects/evalbuffer.o objects/evalfunc.o objects/evalvars.o objects/evalwindow.o objects/ex_cmds.o objects/ex_cmds2.o objects/ex_docmd.o objects/ex_eval.o objects/ex_getln.o objects/fileio.o objects/filepath.o objects/findfile.o objects/float.o objects/fold.o objects/getchar.o objects/gui_xim.o objects/hardcopy.o objects/hashtab.o objects/help.o objects/highlight.o objects/if_cscope.o objects/if_xcmdsrv.o objects/indent.o objects/insexpand.o objects/list.o objects/locale.o objects/logfile.o objects/map.o objects/mark.o objects/match.o objects/mbyte.o objects/memline.o objects/menu.o objects/misc1.o objects/misc2.o objects/mouse.o objects/move.o objects/normal.o objects/ops.o objects/option.o objects/optionstr.o objects/os_unix.o objects/pathdef.o objects/popupmenu.o objects/popupwin.o objects/profiler.o objects/pty.o objects/quickfix.o objects/regexp.o objects/register.o objects/screen.o objects/scriptfile.o objects/search.o objects/session.o objects/sha256.o objects/sign.o objects/sound.o objects/spell.o objects/spellfile.o objects/spellsuggest.o objects/strings.o objects/syntax.o objects/tag.o objects/term.o objects/terminal.o objects/testing.o objects/textformat.o objects/textobject.o objects/textprop.o objects/time.o objects/typval.o objects/ui.o objects/undo.o objects/usercmd.o objects/userfunc.o objects/version.o objects/vim9class.o objects/vim9cmds.o objects/vim9compile.o objects/vim9execute.o objects/vim9expr.o objects/vim9instr.o objects/vim9script.o objects/vim9type.o objects/viminfo.o objects/window.o objects/bufwrite.o objects/gui.o objects/gui_motif.o objects/gui_x11.o objects/gui_beval.o objects/gui_xmdlg.o objects/gui_xmebw.o objects/vterm_encoding.o objects/vterm_keyboard.o objects/vterm_mouse.o objects/vterm_parser.o objects/vterm_pen.o objects/vterm_screen.o objects/vterm_state.o objects/vterm_unicode.o objects/vterm_vterm.o   objects/if_perl.o objects/if_perlsfio.o  objects/if_python3.o    objects/netbeans.o objects/job.o objects/channel.o objects/xdiffi.o objects/xemit.o objects/xprepare.o objects/xutils.o objects/xhistogram.o objects/xpatience.o  objects/charset.o objects/json.o objects/main.o objects/memfile.o objects/message.o  -lXp -lXmu -lXext -lXm -lXt -lSM -lICE -lXt -lX11 -lSM -lICE -ldl  -lm -ltinfo -lelf  -lselinux    -Wl,--enable-new-dtags -Wl,-z,relro -Wl,--as-needed -Wl,-z,now -specs=/usr/lib/rpm/redhat/redhat-hardened-ld -specs=/usr/lib/rpm/redhat/redhat-annobin-cc1  -Wl,-z,relro -Wl,--as-needed -Wl,-z,now -specs=/usr/lib/rpm/redhat/redhat-hardened-ld -specs=/usr/lib/rpm/redhat/redhat-annobin-cc1  -fstack-protector-strong -L/usr/local/lib  -L/usr/lib64/perl5/CORE -lperl -lpthread -lresolv -ldl -lm -lcrypt -lutil -lc  -L/home/ztoth/.pyenv/versions/3.8.18/lib/python3.8/config-3.8-x86_64-linux-gnu -lpython3.8 -lcrypt -ldl -L/home/ztoth/.pyenv/versions/3.8.18/lib -Wl,-rpath,/home/ztoth/.pyenv/versions/3.8.18/lib -lm -lm

clang-16: warning: argument unused during compilation: '-specs=/usr/lib/rpm/redhat/redhat-hardened-ld' [-Wunused-command-line-argument]
clang-16: warning: argument unused during compilation: '-specs=/usr/lib/rpm/redhat/redhat-annobin-cc1' [-Wunused-command-line-argument]
clang-16: warning: argument unused during compilation: '-specs=/usr/lib/rpm/redhat/redhat-hardened-ld' [-Wunused-command-line-argument]
clang-16: warning: argument unused during compilation: '-specs=/usr/lib/rpm/redhat/redhat-annobin-cc1' [-Wunused-command-line-argument]
clang-16: warning: argument unused during compilation: '-specs=/usr/lib/rpm/redhat/redhat-hardened-ld' [-Wunused-command-line-argument]
clang-16: warning: argument unused during compilation: '-specs=/usr/lib/rpm/redhat/redhat-annobin-cc1' [-Wunused-command-line-argument]
objects/option.o: file not recognized: file format not recognized

clang-16: error: linker command failed with exit code 1 (use -v to see invocation)
link.sh: Linking failed
make: *** [Makefile:2058: vim] Error 1

that error is strange. Have you tried running make clean && make and see if this reproduces? I am also wondering about those warnings. Where does the -specs=/usr/lib/rpm/redhat/redhat-annobin-cc1 -specs=/usr/lib/rpm/redhat/redhat-hardened-ld come from?

Thanks for taking a look.

that error is strange. Have you tried running make clean && make and see if this reproduces?

I have tried it now, and yes it reproduces.

I am also wondering about those warnings. Where does the -specs=/usr/lib/rpm/redhat/redhat-annobin-cc1 -specs=/usr/lib/rpm/redhat/redhat-hardened-ld come from?

I'm not sure.  The CFLAGS and LDFLAGS I used are shown in the configure command.  When I call make -j8, my CFLAGS and LDFLAGS environment variables are unset.  I checked env | grep redhat and I don't see any references to it in any environment variable.
The first reference to them comes early in the output of make -j8:
/bin/sh install-sh -c -d objects
CC="clang -Iproto -DHAVE_CONFIG_H -DFEAT_GUI_MOTIF       " srcdir=. sh ./osdef.sh
creating auto/pathdef.c
/usr/bin/perl -e 'unless ( $] >= 5.005 ) { for (qw(na defgv errgv)) { print "#define PL_$_ $_\n" }}' > auto/if_perl.c
cd xxd; CC="clang" CFLAGS=" -O2   -Wall -Wno-deprecated-declarations -D_REENTRANT -U_FORTIFY_SOURCE -D_FORTIFY_SOURCE=1" LDFLAGS="-Wl,--enable-new-dtags -Wl,-z,relro -Wl,--as-needed -Wl,-z,now -specs=/usr/lib/rpm/redhat/redhat-hardened-ld -specs=/usr/lib/rpm/redhat/redhat-annobin-cc1   -rdynamic -L/usr/local/lib" \
        make -f Makefile

Can you please share the complete log? Another question: Does this only happen with clang? Have you tried gcc? Or a different clang?

Can you please share the complete log?

I assume by the log you mean the standard output and standard error from the configure and make commands.  I've attached them to this comment.
configure.out.txt
make.out.txt

Does this only happen with clang? Have you tried gcc? Or a different clang?

Using gcc, the configure command fails with errors that I am not sure how to easily resolve.  And I don't know how to install a different version of clang on RHEL.  I apologize for my ineptitude.

I see this behaviour, when using -lto together with clang-17. So please try to disable link-time-optimization. Not sure where this comes from, but it should be possible to set CFLAGS with some sane defaults (or set them directly in the Makefile).
Also it may be a good idea to compile sequentially (no -j ) when seeing such strange errors, just in case some dependency is slightly wrong.

I wasn't sure how to disable link-time-optimization, as I wasn't setting them in the first place.  I don't see a -flto=no option.
Passing CFLAGS=-emit-llvm to configure results in configure failing with:
checking for gcc... clang
checking whether the C compiler works... no
configure: error: in `/opt/vim/vim-master/src':
configure: error: C compiler cannot create executables
See `config.log' for more details

Where config.log shows:
configure:3454: checking whether the C compiler works
configure:3476: clang -emit-llvm  -rdynamic conftest.c  >&5
clang-16: error: -emit-llvm cannot be used when linking

I then tried passing CFLAGS="-O2 -Wall -Wno-deprecated-declarations -D_REENTRANT -U_FORTIFY_SOURCE -D_FORTIFY_SOURCE=1" to configure and I'm back to seeing -flto=auto getting set.
The next thing I tried finally worked.

Here is what worked around the problem for me:
I tried just running configure, then checking which files have flto in them, in the hope of replacing them.  I found these:
/opt/vim/vim-master/src/auto/config.log
/opt/vim/vim-master/src/auto/config.mk
/opt/vim/vim-master/src/auto/config.status

config.mk had a line:
PERL_CFLAGS     =  -D_REENTRANT -D_GNU_SOURCE -O2 -flto=auto -ffat-lto-objects -fexceptions -g -grecord-gcc-switches     -specs=/usr/lib/rpm/redhat/redhat-hardened-cc1 -fstack-protector-strong -specs=/usr/lib/rpm/redhat/redhat-annobin-cc1 -m64 -march=x86-64-v2 -mtune=generic -fasynchronous-unwind-tables -fstack-clash-protection -fcf-protection -fwrapv  -I/usr/local/include -D_LARGEFILE_SOURCE -D_FILE_OFFSET_BITS=64  -I/usr/lib64/perl5/CORE

I removed -flto=auto and then run make -j8 and sudo make install.  This did the trick.
Thanks for your help @chrisbra .  It is much appreciated.

Thanks, I guess this comes from:
perl -Mlib=$srcdir -MExtUtils::Embed -e 'ccflags;perl_inc;print"\n"'

Not sure if we should filter out -flto=auto or not

I wasn't sure how to disable link-time-optimization, as I wasn't setting them in the first place

@chrisbra I only glanced at the change, thought it looked to affects only perl. I ask because I played around with link time optimization and saw on average around 10% performance improvement in some micro-benchmarking: https://github.com/vim/vim/discussions/13565#discussioncomment-7663365

Ah yes I remember. However the problem here seems to be, that because of enabling the Perl Interface the PERL_CFLAGS which includes the -lto argument, leaks into compilation for the option.c and optionstr.c files. Which then apparently are no longer detected as valid object files when linking it to the Vim binary. So apparently you cannot have part of the object files compiled with -lto and other parts without it, so I filter it now out in the configure script (which is what patch 2f9aef4 above does).
On a related note, I tested the -lto when compiling, but I have an old development laptop. The linking step takes forever then, so I found it more annoying than actually helpful.

On a related note, I tested the -lto when compiling, but I have an old development laptop. The linking step takes forever then, so I found it more annoying than actually helpful.

The first time I tried it, "forever" is a good description. I just looked at the referenced comment, and in the notes there's

Using -flto=auto makes a huge difference in link time.
Did not use -fwhole-program or a linker plugin (AFAICT).

Excerpt from the gcc docs https://gcc.gnu.org/onlinedocs/gcc/Optimize-Options.html
Use -flto=auto to use GNU make’s job server, if available, or otherwise fall back
to autodetection of the number of CPU threads present in your system.

There's a lengthy section about -flto[=n].
Never tried clang.
There's an interesting comment in the gcc docs
If LTO encounters objects with C linkage declared with incompatible types in
separate translation units to be linked together (undefined behavior according
to ISO C99 6.2.7), a non-fatal diagnostic may be issued.

No idea if this has anything to do with this issue and/or how clang may handle these things.

(undefined behavior according to ISO C99 6.2.7), a non-fatal diagnostic may be issued.

That is funny, it shall be non-fatal, even so it is undefined behaviour 🤷

(undefined behavior according to ISO C99 6.2.7), a non-fatal diagnostic may be issued.

That is funny, it shall be non-fatal, even so it is undefined behaviour 🤷

Yep. Guessing that gcc decided to define it, maybe clang doesn't?

So apparently you cannot have part of the object files compiled with -lto and other parts without it, so I filter it now out in the configure script (which is what patch 2f9aef4 above does).

If you compile even some objects with LTO compiler flags, it is advisable to link with the same flags as well. Normally, that's the job of people injecting -flto into their $CFLAGS and $LDFLAGS environment variables before running configure. Perl is leaky -- its Extutils will print various junk based on what perl was configured with rather than just printing what you want, which is the required interface flags for compiling against the perl headers and linking to the perl library.
Compilers may choose to detect that an object was built with LTO, and activate linking with LTO even when you didn't tell it to.

Yep. Guessing that gcc decided to define it, maybe clang doesn't?

Absolutely not, GCC has not defined anything.
The C programming language doesn't require you to warn or error when Undefined Behavior exists, but compilers may choose to do so in order to be helpful. That is not defining the behavior to do a specific thing, that is telling you that the trigger condition exists for your code to behave in unpredictable ways.
Incompatible types is a trigger condition. It is "illegal code". You can detect illegal code. The undefined behavior is what machine code it results in -- GCC makes zero definition about what (incorrect) machine code will be produced.


docs: add notice for customizing the panda css setup

Closes #
📝 Description
It wasn't very clear how many options you have to customize your Panda CSS setup.
I feel like adding this on a few places in the docs, this would help the users discover this option.
⛳ Current behavior (updates)
/
🚀 New behavior
Added notice of the option to opt-out of features and concepts of Panda CSS to customize the setup.
💣 Is this a breaking change (Yes/No):
No
📝 Additional Information
Feel free to be more creative and change the content.

Closing this in favor of a new upcoming PR to make the default set up minimal.
That would make this doc obsolete.


Multiple Tables last table sets sSwfPath for all Tables

If you have multiple Tables on one Page - the last Page sets sSwfPath for all Tables !
wich normaly shouldnt be a problem but my last table had no Export Button and hence it did'nt set the sSwfPath for it wich lead to the default path beeing set - and me searching for a reason why it didnt work ;)
did not test if this happens to ohter properties...

Thanks for pointing that out. I'm going to be started work on a replacement for TableTools soon. I'll either fix this in TableTools current if it is a trivial fix or in the replacement if not.

posted details on this on stackoverflow about 8 hours ago here http://stackoverflow.com/questions/17158483/how-to-set-the-swf-path-of-tabletools-when-using-it-with-greasemonkey/28691508#28691508
Still trying to make the buttons work , they work for just one table at them moment though sswfPath for all tables is correct.


Apply-PnPTenantTemplate -Path starterkit.pnp Tenant app catalog doesn't exist. ALM step will be skipped!

Thank you for reporting an issue or suggesting an enhancement. We appreciate your feedback - to help the team to understand your needs, please complete the below template to ensure we have the necessary details to assist you.
(DELETE THIS PARAGRAPH AFTER READING)

Category

[x] Question
[x] Bug
[ ] Enhancement

For the above list, an empty checkbox is [ ] as in [SPACE]. A checked checkbox is [x] with no space between the brackets. Use the PREVIEW tab at the top right to preview the rendering before submitting your issue.
(DELETE THIS PARAGRAPH AFTER READING)

Expected or Desired Behavior

If you are reporting a bug, please describe the expected behavior. If you are suggesting an enhancement please describe thoroughly the enhancement, how it can be achieved, and expected benefit.
(DELETE THIS PARAGRAPH AFTER READING)

Observed Behavior

If you are reporting a bug, please describe the behavior you expected to occur when performing the action. If you are making a suggestion, you can delete this section.
(DELETE THIS PARAGRAPH AFTER READING)

Steps to Reproduce

If you are reporting a bug please describe the steps to reproduce the bug in sufficient detail to allow testing. Only way to fix things properly, is to have sufficient details to reproduce it. If you are making a suggestion, you can delete this section.
(DELETE THIS PARAGRAPH AFTER READING)

Submission Guidelines

All suggestions or bugs are welcome, please let us know what's on your mind.
If you are reporting an issue on generic SharePoint topic or dev documentation, please use the (sp-dev-docs Issue list)[http://aka.ms/spdev-issues]
If you have technical questions about the framework, we’ll be monitoring #spfx, #spfx-webparts, and > #spfx-tooling on (SharePoint StackExchange)[http://sharepoint.stackexchange.com/]. You can also > alternatively submit your question to (SharePoint Developer group)> [https://network.office.com/t5/SharePoint-Developer/bd-p/SharePointDev] at Office Network.
Remember to include sufficient details and context.
If you have multiple suggestions or bugs please submit them in separate bugs so we can track resolution.

(DELETE THIS PARAGRAPH AFTER READING)

Thanks for your contribution! Sharing is caring.

Based on comments, this issue has been answered, so closing it for now.


Problem with gnome-keyring after fingerprint auth

After an upgrade I have problems with some gnome apps which I assume is connected with gnome-keyring.
Examples:

Evolution can't connect to mailboxes, cli output:

:/ evolution
(WebKitWebProcess:2): dbind-WARNING **: 12:12:00.148: Couldn't connect to accessibility bus: Failed to connect to socket /tmp/dbus-0sNmZnFJLB: No such file or directory
(WebKitWebProcess:2): Gtk-WARNING **: 12:12:00.153: Theme parsing error: gtk.css:2:125: Failed to import: Error opening file<EMAIL_ADDRESS>No such file or directory

NetworkManager can't connect to vpn servers, /var/log/messages:
2021-08-30T12:13:11.046547+03:00 gnome-keyring-daemon[1912]: gkd_secret_service_get_objects: assertion 'GKD_SECRET_IS_SERVICE (self)' failed
2021-08-30T12:13:11.046680+03:00 gnome-keyring-daemon[1912]: gkd_secret_objects_lookup_collection: assertion 'GKD_SECRET_IS_OBJECTS (self)' failed

nix-env (Nix) 2.3.15
nix-channel --list
home-manager https://github.com/nix-community/home-manager/archive/release-20.09.tar.gz
nixos https://nixos.org/channels/nixos-21.05
nixos-hardware https://github.com/NixOS/nixos-hardware/archive/master.tar.gz
nixos-unstable https://nixos.org/channels/nixos-unstable

GDM does not currently support unlocking keyring when fingerprint auth is used: https://gitlab.gnome.org/GNOME/gdm/-/issues/613
Though I would expect evolution to prompt for the keyring password when the keyring is not unlocked.

GDM does not currently support unlocking keyring when fingerprint auth is used: https://gitlab.gnome.org/GNOME/gdm/-/issues/613
Though I would expect evolution to prompt for the keyring password when the keyring is not unlocked.

It does not, only after manually restarting gnome-keyring-daemon

This sucks, I somehow remember ubuntu was able to package it well.

@hellwolf  Just to check, do you have services.gnome.gnome-keyring.enable = true; in your NixOS configuration? Do you use GNOME Shell or something custom? Do you also use fprintd as the reporter?
I do not have access to any fingerprinting hardware so cannot really make sure it works.

I did not explicitly, but looks like it is true:
$ nixos-option services.gnome.gnome-keyring.enable
Value:
true

Default:
false

Type:
"boolean"

Description:
{
  text = ''
    Whether to enable GNOME Keyring daemon, a service designed to
    take care of the user's security credentials,
    such as user names and passwords.
  '';
}

Declared by:
[ "/nix/var/nix/profiles/per-user/root/channels/nixos/nixos/modules/services/desktops/gnome/gnome-keyring.nix" ]

Defined by:
[
  "/nix/var/nix/profiles/per-user/root/channels/nixos/nixos/modules/services/x11/desktop-managers/gnome.nix"
  "/nix/var/nix/profiles/per-user/root/channels/nixos/nixos/modules/programs/geary.nix"
]


Updates Bundler #trivial

I was seeing the following error in Emission when running bundle install:
➜  bin/emission/Example git:(fix-release-script-and-querymap) bundle install
Traceback (most recent call last):
    4: from /Users/ashfurrow/.rvm/gems/ruby-2.5.3/bin/ruby_executable_hooks:24:in `<main>'
    3: from /Users/ashfurrow/.rvm/gems/ruby-2.5.3/bin/ruby_executable_hooks:24:in `eval'
    2: from /Users/ashfurrow/.rvm/gems/ruby-2.5.3/bin/bundle:23:in `<main>'
    1: from /Users/ashfurrow/.rvm/rubies/ruby-2.5.3/lib/ruby/site_ruby/2.5.0/rubygems.rb:308:in `activate_bin_path'
/Users/ashfurrow/.rvm/rubies/ruby-2.5.3/lib/ruby/site_ruby/2.5.0/rubygems.rb:289:in `find_spec_for_exe': can't find gem bundler (>= 0.a) with executable bundle (Gem::GemNotFoundException)

This might be related to their release snafu earlier this year.

Should this also be updated in the CI config where we install bundler?

@alloy oh yeah, good catch.


Hotfix: add default price label when creating issue

Resolves #482
QA example: https://github.com/wannacfuture/Battleship/issues/29

Holding off the PR until the exploit issue resolved

Holding off the PR until the exploit issue fully resolved

Can you link back an open pull request working on resolving the exploit? It seems like this pull request was forgotten about and its difficult for me to audit the progress.

Holding off the PR until the exploit issue fully resolved

Can you link back an open pull request working on resolving the exploit? It seems like this pull request was forgotten about and its difficult for me to audit the progress.

https://github.com/ubiquity/ubiquibot/commit/f4e5c65259d3bc9d7d6a1fc3468ca2b19733a624

Can we merge this @0xcodercrane?

Can we merge this @0xcodercrane? The merge conflict is getting complicated.

Yes. let me handle it


MediaRecorder op is unable to find canvas when preview is popped out

I use the version on cables.gl to reproduce.
When using the "Popout canvas" feature for the preview, MediaRecorder is unable to record a video.
Error message:
Error: canvas not found
Error: could not create mediarecorder, try setting all parameters

MediaRecorder op:
{"ops":[{"opId":"ff12e50f-e2bd-4554-9aec-dab9de4cba8b","id":"ivq0yphca","uiAttribs":{"subPatch":0,"translate":{"x":93.5645429495388,"y":280.1329736646772},"history":{"lastInteractionAt":1729862682549,"lastInteractionBy":{"name":"nr4"}}},"portsIn":[{"name":"Recording","value":1},{"name":"Filename","value":"cables"},{"name":"Download Video","value":1},{"name":"Mimetype index","value":1},{"name":"Mimetype","value":"video/mp4"},{"name":"MBit","value":5},{"name":"Max FPS","value":30},{"name":"Force FPS","value":0},{"name":"Media index","value":0},{"name":"Media","value":"Video"},{"name":"Video Canvas Id","value":"glcanvas"}],"portsOut":[{"name":"State","value":""},{"name":"Error","value":""},{"name":"Final Mimetype","value":""},{"name":"Duration","value":5389.699999988079},{"name":"Video DataUrl","value":"blob:https://sandbox.cables.gl/df9a1d2d-21b3-415b-83fb-c701240c4dda"}]}]}

dupe: cables-gl/cables_docs/issues/873

whoops. sorry.

works on dev.cables.gl will be in the next release


cors: add ability to enable and shadow via runtime

Description: Add runtime integration into the CORS filter. Additionally, add runtime flags for shadow and live reads.
In order to allow for virtual host runtime configuration vs. per-route runtime configurations, a new key (runtime_key) has been added to the cors policy.
Shadow reads (via cors.<runtime_key>.shadow_enabled) will evaluate an origin's validity and emit a metric but will not enforce any policies.
Live reads (via cors.<runtime_key>.filter_enabled) will enable the filter at the percentage specified in runtime. The runtime value will take priority over the value of the enabled key.
Risk Level: Medium
Testing: Added unit tests & manually verified with sandbox.
Docs Changes: Added documentation for the new runtime flags and inline docstring for the route protobuf.
Release Notes: Included.

@venilnoronha thanks for the fast review! I updated based on your feedback.

When you get a chance, mind doing a master merge and moving the release notes to 1.10? :-)

👍 got pulled into some other things last week but taking another pass at this now

@mattklein123 I updated everything except the tests. Can you take a look at the source files and let me know if this approach looks reasonable? If if does I'll proceed with updating the unit tests :)


Tab key doesn't work

Hi,
I'm using //cdnjs.cloudflare.com/ajax/libs/vue/1.0.25/vue.js, and I have problem with calling tab key event with keyup.
It works with other keys such as up or down
@keyup.up = "functionName"

but not with the tab key. The code below doesn't call the event handler.
@keyup.tab = "functionName"

Please take a look at this one.
Thanks,

try @keydown.tab and prevent default cause on keyup tab default event already took place

Thank @sleewoo . Your method works!!!
I have another relevant question. How about when user don't press the tab button, and they use the mouse to select some things else instead? How I can catch that event together with the tab key?

Your question should be in some QA site like StackOverflow or the Vue forum, not as an issue. For what you are asking, I think that the @focus event is what you need

@YerkoPalma you're right. It also works. Thanks for your help.


bugfix: fatal error: concurrent map writes

What type of PR is this?

What this PR does / why we need it:
Which issue(s) this PR fixes:

Fixes #3985

/retest

/retest

we need a test to guratee this

we need a test to guratee this

can you add a test @qicz ?


Add an importNameRule option to ignore npm modules

I've used "tslint-config-airbnb" and it uses this library. I think ImportNameRule can be useful when It checks users code, not npm installed module's code.
I recently tested with my new project setting and
import styled from "styled-components" and got tslint warning "Misnamed import. Import should be named 'styledComponents' but found styled"
I made this rule to be false, and it is all find. Just curious about this result

I might be way wrong here, but can't you just do, import styledComponents from "styled-components"? I thought it's just a default export, and normally in TypeScript I've mostly used something like import * as styled from "styled-components"`, maybe that's a way?

I tried it import * as styled from "styled-components" because that what is usually done for react or other modules.  Then I get this error message when trying to use

styled.h1` some styled-components css here `

[ts]Property 'h1' does not exist on type 'typeof import("c:/Users/roniel/Documents/LearningByExamples2/test-project-setting/node_modules/@types/styled-components/index")

`

Hey @lonyele, thanks for posting this! Agreed that it would be nice to have an option for the rule to ignore npm modules.
The import-name already allows passing an object to describe a whitelist of npm modules and their imported names:
// tslint.json
{
    "rules": {
        "import-name": [true, {
            "styled-components": "styled"
        }]
    }
}

You can try that kind of configuration until the option is added. Since the rule already takes in a general object as that mapping, maybe it should also be able to take a string "ignore-modules"? Example:
// tslint.json
{
    "rules": {
        "import-name": [true, "ignore-modules"]
    }
}

As for your error message, that looks like a TypeScript complaint, not TSLint. Maybe it's this? https://stackoverflow.com/questions/32236163/when-to-use-import-as-foo-versus-import-foo

@JoshuaKGoldberg It sounds nice. I have other things to do right now so I can't make a PR(Actually, I already saw the codebase, but I couldn't really understand all of it to make a useful PR)
Yeah, definitely It is in my learning list and hopefully I make a PR


fixing test migrated from master to 2.0 version of parser refs #643 also

Migrating test from master version

missing tests: RelativeReferenceTest.testIssue213


translator: send skip_nvs and nvs_thresh from args to ctor

[3.1.21]
Fixed

Send skip_nvs and nvs_thresh args to Translator constructor in sockeye-translate instead of ignoring them.

[3.1.22]
Added

log beam search avg output vocab size

Pull Request Checklist

[x] Changes are complete (if posting work-in-progress code, prefix your pull request title with '[WIP]'
until you can check this box.
[x] Unit tests pass (pytest)
[ ] Were system tests modified? If so did you run these at least 5 times to account for the variation across runs?
[x] System tests pass (pytest test/system)
[x] Passed code style checking (./style-check.sh)
[x] You have considered writing a test
[x] Updated major/minor version in sockeye/init.py. Major version bump if this is a backwards incompatible change.
[x] Updated CHANGELOG.md

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Hi Jonathan,
Thanks for your interest in contributing to Sockeye!
It looks like you're working on a few different changes in your branch. When you're ready to share any of them, you can create a new branch for the specific change and open a pull request, which will bring up a template to describe the contribution.
Best,
Michael

The topic is Neural Vocabulary Selection. First commit fixes a bug: documented option to turn off NVS (or change threshold) doesn't do anything. The second commit just logs the average vocabulary size.
Are you suggesting a separate branch+pull request for each? If so, no problem.
Is there interest in both parts or just the bugfix?

I saw a checklist template and complied. Are you saying that you want me to keep the template and put [ x ] in the [ ]?

Hi Johnathan,
Leaving everything in 1 PR is fine but please leave in the checklist and the statement that you release your changes under Apache 2.0 license.
Thanks!

Thanks, Felix. See new desc above.


Duplication problem on SS 3.1.20 / Fluent 3.2.3

I'm on SS 3.1.20 and Fluent 3.2.3.
When doing a duplication of an article in my default language (de_DE) everything works fine. But when I try to duplicate in another language (en_US), i only get german texts in both, german and english.
Maybe related to #116

@wernerkrauss This sounds like a new and different way into similar problems the module is having. What we need, in order to figure out what the  heck is going on, is reproduction steps.
What we need:

Your current(custom) fluent.yml
Step by step instructions (including simple "Save & Publish" as individual steps)
At each step, ensure you state what the LHS locale switcher says and more importantly what rlocale is stored in the CMS' locale cookie

I think I need to write a custom fluent hook for onAfterDuplicate to ensure the right locales are being copied across.

Hi, I updated my project to SS3.6.3 and Fluent 3.8.1; I found out, that my Page class also had "FluentExtension" applied; after I removed it from my translated Page everything seems to work fine.
Maybe a check in "FluentSiteTree" that throws an error, when both, FluentExtension and FluentSiteTree are applied to a Page might be a feature?

Yes that's a common problem. :D


[BUG]

Environment
Please provide as many details as you can:

Hosting type

[x] Form.io
[x] Local deployment

Version:

Formio.js version:
Frontend framework:
Browser:
Browser version:

Steps to Reproduce

When we tried to make any columns/table custom component, we extend the class from NestedComponent.
After that if we changed the type to our custom component such as "columnsCustomComp", then it works fine, but when we drag and drop any component in that columns component, it shows "undefined component"

Expected behavior
Observed behavior
Example
If possible, please provide a screenshot, live example (via JSFiddle or similar), and/or example code to help demonstrate the issue.
For code or form JSON, please enclose in a code block:
// your code here

Hello @kapilgoyal6,
Can you provide a video of the issue taking place?

Hello @kapilgoyal6,
Can you provide a video of the issue taking place?

I am closing the issue as it was created too long ago and there is no new comments here. If the issue is not resolved, please reopen it. Thanks!


build.rs fails to compile -> ethers-rs has made ethers::solc a feature rather than default

This pr for ethers-rs has made ethers-solc an optional feature:
https://github.com/gakonst/ethers-rs/pull/1463
build.rs depends on ethers::solc
[build-dependencies]
ethers = { git = "https://github.com/gakonst/ethers-rs" , features = ["ethers-solc"]}

After making the change, build.rs still fails to compile. I'm not familiar with the logic in that file, otherwise I would've made the fix a PR. Hope this helps.
error[E0061]: this function takes 2 arguments but 1 argument was supplied
   --> /home/plotchy/.cargo/git/checkouts/erigon-db-d1f243f9aeca17a7/d88f5bf/build.rs:29:31
    |
29  |         let contract = output.find(name).ok_or_else(|| {
    |                               ^^^^------ an argument is missing
    |
note: associated function defined here
   --> /home/plotchy/.cargo/git/checkouts/ethers-rs-c3a7c0a0ae0fe6be/8db1899/ethers-solc/src/compile/output/mod.rs:246:12
    |
246 |     pub fn find(&self, path: impl AsRef<str>, contract: impl AsRef<str>) -> Option<&T::Artifact> {
    |            ^^^^
help: provide the argument
    |
29  |         let contract = output.find(name, {_}).ok_or_else(|| {
    |                               ~~~~~~~~~~~~~~~

Sorry, this repo could use some love. It's stuck in between experimental and usable.
#4 should solve your problem.


Use fqcn calling the edpm roles

edpm playbooks should now be called with their FQCN
Depends-On: https://github.com/openstack-k8s-operators/install_yamls/pull/181
Depends-On: https://github.com/openstack-k8s-operators/edpm-ansible/pull/86

@slagle both Depends-On patches have been merged, care to approve this one so it can be merged? Thanks!


can't install cargo target manually

Problem
Hello,
I have a company computer in witch i cannot install rustup. However, Rustc and cargo are installed.
I need a linux target to build an executable, compatible with GLIBC 2.17 as said Stack Over Flow : https://stackoverflow.com/questions/63724484/build-and-bind-against-older-libc-version
Steps

I downloaded the x86_64-unknown-linux-musl target with this link : https://download.eclipse.org/justj/?file=zenoh/zenoh/0.5.0-beta.9/x86_64-unknown-linux-gnu

I changed my project's cargo.toml  :

[target.x86_64-unknown-linux-gnu]
runner = "C:\xxxxx\x86_64-unknown-linux-gnu" as said in Rust Cookbook

cargo build --target x86_64-unknown-linux-gnu

4. the x86_64-unknown-linux-gnu target may not be installed
Possible Solution(s)
No response
Notes
Where are installed "rustup target add ****" outputs and how to use it ??
Thank you in advance !
Sincerly yours
Version
cargo 1.58.0 (f01b232bc 2022-01-19)
release: 1.58.0
host: x86_64-pc-windows-msvc

The general steps to add a target without rustup installation is like the followings (untested, use at your own risk):

Download the specific target tarball from official static assets, e.g. https://static.rust-lang.org/dist/rust-std-1.58.0-x86_64-unknown-linux-musl.tar.gz
Unpack the tarball and there should be a rustlib/<target> folder.
Determine where current rustc installed via the command rustc --print sysroot. A rustlib folder should be there.
Move and merge the rustlib/<target> folder we download to the rustlib installation location.

 There might be much more work than that. I'd suggest you to ask usage questions on Rust user forum. People there generally more helpful for these kind of topics. I am going to close this issue as it is not Cargo specific. Feel free to comment below if you have different thoughts.


Problems when trying to replace the mscoco model with the model trained with my own dataset

Thank you so much for your excellent work! However, I recently encountered a problem when trying to generate my own adversarial patch:
I want to try to use the faster-rcnn-inception model trained on my own dataset to generate specific adversarial patches, but I found that even under the same config file (I am sure it is the same), the generated faster-rcnn-inception model(by tensorflow object detection API) is still somewhat different from the mscoco model in the tensorflow model zoo(which used in the jupyter notebook)  ,and i found the differences are usually in the naming and structure of the parameters, which leads to an error in the method : '.graph.get_tensor_by_name' in the jupyter notebook. I spent several days and still don't know how to train a model with the same structure as the model in model zoo.
Therefore, I use Netron to match related variables in the two models, hoping to replace the original variable names with some of the same features (such as similar naming, the same shape, size, etc.).
E.g:
in class ModelContainer(), i replaced this code:
with tf.gfile.GFile(PATH_TO_CKPT, 'rb') as fid:
                serialized_graph = fid.read()
                detection_graph_def.ParseFromString(serialized_graph)
                tf.import_graph_def(detection_graph_def, name='detection',
                                    input_map={
                                               'Preprocessor/map/TensorArrayStack/TensorArrayGatherV3:0':self.patched_input_,
                                               '**Reshape_7:0**':self.rpn_nms_bboxes_placeholder_,
                                               '**Reshape_8:0**':self.rpn_nms_indices_placeholder_,
                                              })

            # Recreate tensors we just replaced in the input_map
            self.rpn_nms_bboxes_ = tf.reshape(self.graph.get_tensor_by_name('**detection/Reshape_6:0**'), self.graph.get_tensor_by_name('**detection/stack_3:0**'), name='detection/Reshape_7')
            self.rpn_nms_indices_ = tf.reshape(self.graph.get_tensor_by_name('**detection/mul_1:0**'), self.graph.get_tensor_by_name('**detection/Reshape_8/shape:0**'), name='detection/Reshape_8')

with:
with tf.gfile.GFile(PATH_TO_CKPT, 'rb') as fid:
                serialized_graph = fid.read()
                detection_graph_def.ParseFromString(serialized_graph)
                tf.import_graph_def(detection_graph_def, name='detection',
                                    input_map={
                                               'Preprocessor/map/TensorArrayStack/TensorArrayGatherV3:0':self.patched_input_,
                                               'Reshape:0':self.rpn_nms_bboxes_placeholder_,
                                               'Reshape_1:0':self.rpn_nms_indices_placeholder_,
                                              })

            # Recreate tensors we just replaced in the input_map
            self.rpn_nms_bboxes_ = tf.reshape(self.graph.get_tensor_by_name('detection/Reshape_3:0'), self.graph.get_tensor_by_name('detection/stack_3:0'), name='detection/Reshape')
            self.rpn_nms_indices_ = tf.reshape(self.graph.get_tensor_by_name('detection/ExpandDims_1:0'), self.graph.get_tensor_by_name('detection/Reshape_1/shape:0'), name='detection/Reshape_1')

It can be seen that the part with'** **' has been replaced.
However, since I don't know the principle by which these variables are selected, many problems have been encountered after this modify.
So hope to know: Based on what principles did you select these variables with '** **'? What principles can be used to find these ‘important’ variables?
In addition, I attached a picture, which is a screenshot of the work when using Netron to match parameter names.

Reshape_7 and Reshape_8 are the tensors in the graph that are the non-max suppressed outputs from the region proposal network. As you noticed, the name of these tensors will change depending upon the version of TF's Object Detection API you use and the particular choice of model. I suggest you install the version in the Pipfile (fe748d4a4a1576b57c279014ac0ceb47344399c4). If I had to hazard a guess in the code which Tensors these correspond to, I would guess one of these:
https://github.com/tensorflow/models/blob/fe748d4a4a1576b57c279014ac0ceb47344399c4/research/object_detection/meta_architectures/faster_rcnn_meta_arch.py#L1625

Thank you for your detailed reply!  I finally solved this problem by matching the inference graph, and here I attached my code for it might help others facing the same issue.
with tf.gfile.GFile(PATH_TO_CKPT, 'rb') as fid:
                serialized_graph = fid.read()
                detection_graph_def.ParseFromString(serialized_graph)
                tf.import_graph_def(detection_graph_def, name='detection',
                                    input_map={
                                               'Preprocessor/map/TensorArrayStack/TensorArrayGatherV3:0':self.patched_input_,
                                               'CropAndResize/Reshape:0':self.rpn_nms_bboxes_placeholder_,
                                               'CropAndResize/Reshape_1:0':self.rpn_nms_indices_placeholder_,
                                              })

            # Recreate tensors we just replaced in the input_map
            self.rpn_nms_bboxes_ = tf.reshape(self.graph.get_tensor_by_name('detection/map/TensorArrayStack/TensorArrayGatherV3:0'), self.graph.get_tensor_by_name('detection/CropAndResize/Reshape/shape:0'), name='detection/Reshape')
            self.rpn_nms_indices_ = tf.reshape(self.graph.get_tensor_by_name('detection/CropAndResize/mul:0'), self.graph.get_tensor_by_name('detection/CropAndResize/Reshape_1/shape:0'), name='detection/Reshape_1')


Mixer Report failed with: UNAVAILABLE:upstream request timeout

Describe the bug
We are seeing the below message in our logs... its happening very frequently.. almost every second..
[libprotobuf ERROR src/istio/mixerclient/report_batch.cc:83] Mixer Report failed with: UNAVAILABLE:upstream request timeout
[libprotobuf ERROR src/istio/mixerclient/report_batch.cc:83] Mixer Report failed with: UNAVAILABLE:upstream request timeout
Expected behavior
No such entry should be in the logs..
Steps to reproduce the bug
No known steps to reproduce. The error started appearing all of a sudden. Not able to correlated with any changes to the environment.
Version
Client Version: version.Info{Major:"1", Minor:"10", GitVersion:"v1.10.7", GitCommit:"0c38c362511b20a098d7cd855f1314dad92c2780", GitTreeState:"clean", BuildDate:"2018-08-20T10:09:03Z", GoVersion:"go1.9.3", Compiler:"gc", Platform:"linux/amd64"}
Server Version: version.Info{Major:"1", Minor:"10+", GitVersion:"v1.10.11-gke.1", GitCommit:"5c4fddf874319c9825581cc9ab1d0f0cf51e1dc9", GitTreeState:"clean", BuildDate:"2018-11-30T16:18:58Z", GoVersion:"go1.9.3b4", Compiler:"gc", Platform:"linux/amd64"}
Version: 1.0.0
GitRevision: 3a136c90ec5e308f236e0d7ebb5c4c5e405217f4
User: root@71a9470ea93c
Hub: gcr.io/istio-release
GolangVersion: go1.10.1
BuildStatus: Clean
Installation
{{ Please describe how Istio was installed }}
Environment
GCP

Thus far, we’ve observed a relationship of this error and DestinationRules...this has yet to be confirmed technically...but observed

I have observed this error when I enabled Mutual TLS manually. I had to update controlPlaneAuthPolicy after I updated TLS.Mode in DestinationRule.

that will make rate-limit not work?

@liguobao this is about mixer REPORT, which is strictly for telemetry collection (not policy enforcement).

With 1.0 support ending, and a lack of next steps in hunting down this issue, I think that the only action left, unfortunately, is to close this issue. Please re-open if you feel that there is more that should be done here.

Any news on this issue?
I had same error with 1.0, now I've just upgraded to 1,1 and still facing this issue.


Allow for changing the storage backend source of folders

Maybe I'm missing something but the latest version from F-Droid will only consider the "standard" folders from internal storage. Some applications (notably the camera app) can be configured to use external storage e.g. SD-card. An option to add both sources would be great; so either list the standard folders two times or put two buttons for each folder: one for "internal" and another for "SDcard".
At least the option to chose between the two before initiating back-up would be useful. Of course the ability to merge the content(s) of the standard folders (e.g. DCIM/camera) into one back-up would be ideal.

Hi,
the expected behavior is:

all files appearing in your gallery should be synced, wether they are on external SD card or internal phone storage.
In the advanced parameters, when you select folders to be included, there is indeed no indication if it is on a sd card or internal storage. Maybe there is room for improvement here...
If you have a DCIM/camera on both sd card and internal storage, thay will be merged on the dav server

Do you experience a different behavior? If yes, can you give more details, and provide your android version and phone brand?

Thanks for the details. What's your android version?


SyntaxError: future feature annotations is not defined

Hello! when I import the package I get the following error:
`Traceback (most recent call last):
File "/usr/local/lib/python3.6/dist-packages/IPython/core/interactiveshell.py", line 3319, in run_code
exec(code_obj, self.user_global_ns, self.user_ns)
File "", line 1, in
import EasyGA
File "/usr/local/lib/python3.6/dist-packages/EasyGA/init.py", line 2, in
from .EasyGA import GA
File "/usr/local/lib/python3.6/dist-packages/EasyGA/EasyGA.py", line 1
from future import annotations
^
SyntaxError: future feature annotations is not defined`
any suggestions?

Hey @raulazo-m,
EasyGA doesn't support python 3.6 because of it's backend features. I recommend downloading python 3.9.7 or greater.


PageContract does not exist in homepage

Hi Duy,
Please check demo site http://webed.botble.com.
Thanks!

File does not exist at path /home/botble/public_html/webed.botble.com/composer.json
I use composer to reload dependencies. Please add it to your project!


Implement global and per instance shader uniforms.

Adds two keywords to shader language for uniforms:
-'global'
-'instance'
This allows them to reference values outside the material.
Bugsquad edit: closes https://github.com/godotengine/godot-proposals/issues/257, closes #18848, closes #30375

Per instance uniforms sound like instance parameters for MultiMeshInstances:  https://docs.godotengine.org/en/3.2/tutorials/3d/using_multi_mesh_instance.html
I guess this is not what they are meant for, or can they be used there as well?

Oh just as a side note, per instance uniforms are not working for 2D (CanvasItems) because I could not find a way to implement them. I am planning to eventually rewrite the 2D rendering code to make it more efficient before 4.0 is out, now that I am more proficient with Vulkan so I will properly implement those there.

Thanks!


[WIP] feat: Add pretty printing of expressions

Unsure how much I will do on this but I think I will at least fix the fact that the expression after = or -> does not appear on the next line (I believe this is a limitation of pretty atm).

I'm thinking it would be safer to use prefix notation for operators, seeing as we don't know fixities and such...
Eg.
| Bin key value l r -> (++) (to_list l) (Cons { key, value } to_list r)

vs
| Bin key value l r -> to_list l ++ Cons { key, value } to_list r

Since the ast itself is printed that shouldn't be an issue as long as parentheses are preserved. May be good to have a mode which prints with precis and parentheses though for debugging precedence bugs.

Might be a case for quickcheck! :D

Generating ASTs and checking that parse(pretty_print(expr)) == expr?

Update on this PR.
Made some nice progress on and got three of the std/* files formatted according to the pretty printer. Currently stuck trying to represent unindentation.
Consider
let map f m : (a -> b) -> State s a -> State s b =
    \state ->
        let { value, state } = m state
        { value = f value, state = state }

Between the outer and inner let there are two levels of indentation which is fine and necessary but if we instead write the lambdas arguments on the line above I currently get this pretty printing
let map f m : (a -> b) -> State s a -> State s b = \state ->
        let { value, state } = m state
        { value = f value, state = state }

That is, the inner let is still indented twice. A nicer formatting would be to "unindent" after the lambda.
let map f m : (a -> b) -> State s a -> State s b = \state ->
    let { value, state } = m state
    { value = f value, state = state }


Rebalance of Melee Weapons

About the PR

Rebalances spears, shivs, and the captain's sabre.

[X] I have added screenshots/videos to this PR showcasing its changes ingame, or this PR does not require an ingame showcase

Changelog
:cl: Cody ~ Aexxie

tweak: Rebalanced crude melee weapons and the Captain's Sabre.

balance changes must have a reason to make, and you say nothing why you changed anything and what changed exactly

The weapon changes don't really address the issues that we talked about in vc. I thought the solution was going to be adding strong pierce resistance to most structures, or is this unrelated to that?

Miscommunication, but explained in dms.

I think this balance patch is unnecessary and just makes more balancing problems.
Looking at the spear, 12 pierce damage if wielded with 1 attack speed and a weight value of 95 and having the cool feature of using spears as a throwing weapon thrown into the gutter with 8 pierce damage on throw, slightly better than throwing a steel tile for reference measure.
Combat knifes being nearly as good as the Captain's sabre does not make any sense, only 2 slash damage worse with everything else being the same stats while not being an overly rare item.
The survival knife having more weight is weird, what was wrong with it having 10 weight value?
On the topic of that, why does replacing a glass shard with a uranium glass shard in your spear suddenly make it's weight value go down by 70 (from 95 to 25)
If anything, I'm already against nerfing weapons with piercing damage, we have way too much pierce resistances on way too much gear, so having spears deal less damage is ehh.
If you argue that spears can have chem injection and use it as a point to nerf the base damage value of the spears, just nerf the chem injection instead, there is no reason for a melee weapon to be balanced around a niche feature and not vice-versa.

I think this balance patch is unnecessary and just makes more balancing problems. Looking at the spear, 12 pierce damage if wielded with 1 attack speed and a weight value of 95 and having the cool feature of using spears as a throwing weapon thrown into the gutter with 8 pierce damage on throw, slightly better than throwing a steel tile for reference measure.
Combat knifes being nearly as good as the Captain's sabre does not make any sense, only 2 slash damage worse with everything else being the same stats while not being an overly rare item.
The survival knife having more weight is weird, what was wrong with it having 10 weight value? On the topic of that, why does replacing a glass shard with a uranium glass shard in your spear suddenly make it's weight value go down by 70 (from 95 to 25)
If anything, I'm already against nerfing weapons with piercing damage, we have way too much pierce resistances on way too much gear, so having spears deal less damage is ehh.
If you argue that spears can have chem injection and use it as a point to nerf the base damage value of the spears, just nerf the chem injection instead, there is no reason for a melee weapon to be balanced around a niche feature and not vice-versa.

I will probably look over it again if need be, but as it is the crude spears are just as powerful as the sabre.

I will probably look over it again if need be, but as it is the crude spears are just as powerful as the sabre.

Not really? You're comparing pierce damage - being one of the worse damage types due to resistances - with 1 attack speed that is also a wieldable to a rare item with 1.5 attack speed and slash damage, being the best damage type in the game.
If anything I'm fine with spears being slightly worse at melee attacks, but make them a good option for throwing, possibly also decreasing the minimum size, so the item is less of a straight melee weapon and more of a hybrid between melee and throwable ranged.

I wasn't intending to nerf throwing, and for the record changing spear weight was not my change. It was someone else's pr (iirc it was emogarbage).

Why not have reinforced windows spawn ordinary glass shards, eliminate reinforced shards/shivs/spears and rebalance the damage of the remaining weapons?
I originally wanted to get rid of reinforced shards but I didn't know how and didn't wanted to mess the code.


Branch naming conventions

Proposal
Would propose we come up with some branch naming conventions. Maybe something like name/issue#/description. Food for though what do you guys think?
Rationale
This would better organize and identify branches in the repo.
ref: https://stackoverflow.com/questions/273695/what-are-some-examples-of-commonly-used-practices-for-naming-git-branches

I don't see the value in adding names.  Github keeps track of commits.  It blurs if if one person helps another person out in the PR.  I don't have qualms with issue#/description, however is the plan still to delete branches once they are merged?  That is what I have been doing it.

Couple value statement for this, right now its really only the three of us contributing to the repo, but as the number of contributors grows using authors names allows us to better differentiate branches and more easily speak with someone who authored a specific branch.
Lets say there is an issue and two contributors have differing viewpoints on how to solve that issue. Using author name would allow two different users to address the same issue in their own ways. Then the decision to merge will be based on the review/merits of either branch/approach. I think using the author name would make the branches look much cleaner, ie user/issue#1/some-approach and user2/issue#2/alternate-approach
Personally, I believe there is value in the author of a branch/PR to be the "owner" of those code changes. For me it easier to explain and justify my own code changes. When other users start putting commits into branches I think this actually muddies the waters more. For me I would rather see a PR comment or request for changes that I would then implement and explain as the author of the branch. If its something I cant figure then I would ask for additional assistance. This is just my personal preference tho.
Food for thought

Okay.  I have no qualms against it, just didn't see value.  I think we should capture this in the Code Contribution guidelines.  This is available in Insight > Community.


Handle TS exceptions in no-string-based-x rules

PR checklist

[X] Addresses an existing issue: fixes #859 (mitigates)
[X] ~New feature,~ bugfix, ~or enhancement~

[ ] Includes tests

[ ] Documentation update

Overview of change:
This PR does two things:

Defers type check to the moment when potential violation found.
Wraps all calls to typeChecker.getTypeAtLocation in try..catch and restores same behavir when type checker is not available.

This PR doesn't fix root cause of #859 but at least rules won't throw an exception.
Is there anything you'd like reviewers to focus on?
No unit tests for specific case because issue is noticeable in only in Vue. Should I add tests to handle this exceptional case?

Thanks for review!

Thank you :)


LoadError react in production mode

Whe I run my app in production mode (either on localhost with -e production or on a real server) I get an error:
shared/bundle/ruby/2.3.0/gems/activesupport-<IP_ADDRESS>/lib/active_support/dependencies.rb:274:in `require': No such file to load -- react (LoadError)

If I remove require 'react' from app/react/components.rb than I get another error:
app/react/models.rb:2:in `<top (required)>': undefined method `require_tree' for main:Object (NoMethodError)

And so forth. So, obviously something is going wrong here.
With config.eager_load = false in production.rb this error disappear, but this is not a solution.
In development everything is fine.

https://github.com/olegantonyan/test_reactive_record - this is a fresh rails4 app with this issue.
Run it in production:
SECRET_KEY_BASE='bf4381777807529317115a8d854a48bc08d3029a82ac5cfd432c19384f8cd628350e00c24b81001dfad852741dc3995bc7b972946571918567bb2f0b21cfefc7' bundle exec rails server -e production

Any ideas will be very helpful. I cannot solve this by myself

Hey,
I solved the issue with @olegantonyan on the gitter.
The problem comes from the config generated by the generator. In production all files are preloaded so the ruby manifests raise errors when interpreted as normal ruby files.
Adding to those file will solve the problem :
if RUBY_ENGINE == 'opal'
  ...
end

I will update the generator to take that into account shortly.
Important to note, the first rake command in production takes a long time to solve... I'm not sure why, but that does not seem to be blocking for the moment.

This issue was moved to reactrb/reactrb#123


Beautified the text, and changed a line.

This won't be a legitimate pull request, changing the cases of letter cannot be considered a valuable contribution.


Scala 2.12.2 -> 2.12.4

please merge this.

ping

ping

ping

double ping ^^

ping @analytically


🐛 [firebase_app_check] SafetyNet discontinuation

I'm being warned that SafetyNet will be discontinued and that I should migrate to Play Integrity API before June 2023.
Will this plugin make the migration?

Thanks for the report @dpedrinha.
This issue should probably report at native firebase sdk repo, ie, here: https://github.com/firebase/firebase-android-sdk/issues, because the changes probably need to be done at native sdk level that flutterfire can leverage.
There's similar issue open for your reference: https://github.com/firebase/firebase-android-sdk/issues/3890
Closing from here.


cfg: added cargo/config; add +nightly

@chemicstry
Added +nightly to cargo build

separate config for flags

I was thinking of using .cargo/config.toml like this, but then decided not to, because you can't specify build-std just for one target. All targets are forced to recompile std this way.
It would work if it was just for wasm_thread examples, but build_wasm.sh is more of an example how to build other projects using this library. I don't think there is a workaround for this until wasm atomics are stabilized in rust https://github.com/rust-lang/rust/issues/77839

@chemicstry Ok, seems to make sense;

still I have updated branch to add +nigthly on build script, so it can ran on other default toolchain


Update FieldValue For Porting Mutations to C++

This is part of the #1135 to make PR smaller.

Thanks for splitting the PR! I think you also need the change to CMakeLists.txt which adds dependency on absl::optional.


scrape metrics from one's own prometheus being benchmarked

AFAIR We had removed these scraping targets earlier, assuming we didn't need them and to reduce unnecessary scraping.
Turns out we need them for prometheus-query metrics.
For prom-pr, the first target will be down & for prom-release, the 2nd target will be down.
sample query graphs
Signed-off-by: sipian<EMAIL_ADDRESS>

There are gaps in these graphs because in the query
rate(prometheus_engine_query_duration_seconds_sum{job=\"prometheus\",slice=\"inner_eval\",namespace=\"prombench-[[pr-number]]\",prometheus=~\"(test+).*\"}[1m]) / rate(prometheus_engine_query_duration_seconds_count{job=\"prometheus\",slice=\"inner_eval\",namespace=\"prombench-[[pr-number]]\",prometheus=~\"(test+).*\"}[1m])
sometimes the denominator becomes 0, making the result NaN.
Currently the graphs show, average time to serve 1 query.
If the gaps are a problem, I can change the query to find average time to server all queries.

shouldn't the meta Prometheus instance scrape these directly?

These are the metrics exposed by the querier.
These are the query metrics scraped by a prom being benchmarked. Since the graphs are almost straight lines in the second link, rate([1m]) becomes 0 almost all the times, making the result NaN.
Maybe instead of fixed interval of sleeping, we can add some random intervals sleeping in the querier.

The querier logs seem to be showing 404, checking it.

Because of #165, the query URL for the prometheus servers being benchmarked changed to web-external-url.
I had forgotten to update the URL then.
Ready for review now.

Now query timings are being graphed properly.
http://prombench.prometheus.io/grafana/d/7gmLoNDmz/prombench?orgId=1&var-RuleGroup=All&var-pr-number=4964

@krasi-georgiev
I think this is ready for a final review.
I have tested this script on a deployment too.

I just had  another idea to simplify the querier
why not just hard fail after lets say 30  - 404 errors
or any other number that makes sense depending on how long it sleeps between requests.
this way we would need the hacky initcontainers and will still hard fail when there is a major problem.


Tree widget

Hello, there.
I've created a tree widget for my project. I believe this can be useful for anyone else :)
Let me know, please, what you think about that.
Thanks for the termui project!

/cc @cjbassi

screenshot of the example:

Thanks for the pr! I'd like to merge this but I'll need some time to look over it and possibly suggest any changes.

@cjbassi

How should the cursor be positioned after collapsing a node? Currently it seems like SelectedRow stays the same, but sometimes that leaves no currently visible node selected. Although that might be fine. Just wanted to get some thoughts.

I did it intentionally. IMHO, cursor position relate to the line in block area, not to the content is rendered to this area. May be I wrong.

Expand and the other functions that operate on self.rows would potentially operate on an incorrect node if a node is added and Expand is called before the tree is rerendered, since self.rows is only updated in Draw. What if we made self.Nodes private and added a SetNodes method that calls prepareNodes? That would also eliminate calling prepareNodes every draw too.

It like the idea to add public method SetNodes and make property rows private. But we can't rid of the prepareNodes calling before render after that because self.rows contains only visible rows (in our case expanded). Hence, I have moved calling of the prepareNodes to every place where self.rows is changing. Please, let me know what you think about that.

gentle ping @cjbassi

Apologies for the delay, but I haven't forgotten about this! Currently finishing up the school quarter and I should be able to get to this soon.

No problem) Good luck in the school!
On Sat, 8 Jun 2019 at 01:29, Caleb Bassi<EMAIL_ADDRESS>wrote:

Apologies for the delay, but I haven't forgotten about this! Currently
finishing up the school quarter and I should be able to get to this soon.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/gizak/termui/pull/237?email_source=notifications&email_token=AAC7VQCTB4GANFAKG4F5NKTPZLOLHA5CNFSM4HG547Q2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODXHEVUA#issuecomment-500058832,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAC7VQCKD4BKOMW3UL4RWRDPZLOLHANCNFSM4HG547QQ
.

Sorry for the delay again! Been out of commission a bit due to an injury. I've looked it over again and it LGTM. Changing the widget so that nodes are set with SetNodes looks good. I had to rebase to fix some conflicts but I just merged this and now I'm going to release 3.1. Thanks!

I accidentally merged before force pushing the PR which is why it says the PR was closed just btw.


让重叠的话放到不同的轨道上 Allow overlapping cues to be placed on different tracks.

In addition to merging or separating overlapping captions, there should be an option to move one to a separate "track" in the editor, in which captions are, say, aligned to the top of the viewbox (in VTT, these would have line:1 as a cue setting). This would support people talking over each other for durations longer than comfortably handled with just dashes and line breaks. An example would be a person whispering to another (with captions at the bottom) while there is an announcement going on simultaneously (with captions at the top).

I understand what you mean, but it is recommended to use professional subtitle software for complex subtitles. The online version of the subtitle editor on the web is difficult to achieve too many functions.


Genaicommons embeddings, knowledgebase & image generation

Contains changes in

GenAI Commons
PgVector Knowledge Base
OpenAI Connector

@tinaengel There are a few Thumbs.db files here, I assume they should be deleted, can you confirm?


Nested Sequence Error - "E3002 Expecting an object..."

cfn-lint version: 0.14.0
Description of issue.
The following structure throws: "E3002 Expecting an object at Resources/CodeBuildProject/Properties/Triggers/FilterGroups/0"
CodeBuildProject:
    Type: AWS::CodeBuild::Project
    Properties:
      Triggers:
        Webhook: true
        FilterGroups:
        - - Type: EVENT
            Pattern: PULL_REQUEST_CREATED,PULL_REQUEST_UPDATED,PULL_REQUEST_REOPENED
          - Type: BASE_REF
            Pattern: ^refs/heads/master$
            ExcludeMatchedPattern: false

I have trimmed the unnecessary properties.
Details about the structure can be seen here: https://docs.aws.amazon.com/codebuild/latest/userguide/sample-github-pull-request.html#sample-github-pull-request-filter-webhook-events (scroll to the bottom)

Looks like the CloudFormation spec is a little off here.  Looking a little deeper.

Fixed with #658.  Waiting on the next release.  Looks like they created a simple type in the CloudFormation spec.  We hadn't built around this as it didn't exist before this use case.  We have a fix now and should have something released shortly.

not 100% the same example, but I'm getting a similar error for a block like this:
  # Create a LoadBalancerListener and attach the TargetGroup and LoadBalancer
  LoadBalancerListener:
    Type: AWS::ElasticLoadBalancingV2::Listener
    Properties:
      DefaultActions:
        - TargetGroupArn: !Ref TargetGroup
          Type: forward
      LoadBalancerArn: !Ref LoadBalancer
      Protocol: HTTPS
      Port: 443
      Certificates:
        - "{{resolve:secretsmanager:common:SecretString:SSL_ARN}}"

± cfn-lint infra/backend.yaml
E3002 Expecting an object at Resources/LoadBalancerListener/Properties/Certificates/0
infra/backend.yaml:414:11


[Remote Translog] Remove PRRL creation & modify assertions for remote translog enabled Indexes

Is your feature request related to a problem? Please describe.
Following up from https://github.com/opensearch-project/OpenSearch/pull/8484#issuecomment-1643659725, we are seeing that the PRRLs do get created for remote enabled indexes, and in the #8484, we came across cases where the assertions were failing as the RemoteStoreRecoverySource expects empty retention leases. However, there are still retention leases present in memory.
Describe the solution you'd like
We will need to remove the creation of retention leases for remote translog enabled indexes.
One of the places where the retention leases are getting created.
https://github.com/opensearch-project/OpenSearch/blob/83a4b6e9effc0e73ecba67e5dd9246e06b2c3df5/server/src/main/java/org/opensearch/index/seqno/ReplicationTracker.java#L1304-L1344
Sync retention leases needs to be disabled for remote translog enabled indexes.
https://github.com/opensearch-project/OpenSearch/blob/83a4b6e9effc0e73ecba67e5dd9246e06b2c3df5/server/src/main/java/org/opensearch/index/IndexService.java#L1032-L1061
There might be more areas where the retention leases are getting created and this needs to be investigated.
Describe alternatives you've considered
A clear and concise description of any alternative solutions or features you've considered.
Additional context
Add any other context or screenshots about the feature request here.

Storage Triage : Attendees 1 2 3 4 5 6
Are we seeing test failures due to same now @ashking94  ? Is this issue still relevant ?


Basic filtering not working with array

I'm not sure if it's the structure of my JSON or what but out-of-the-box the filtering / searching isn't working with v2.0
var FJS = FilterJS(JSON.parse( lw_post_data), '#resultsList', {
    template: '#media__view',
    search: {ele: '#filterSearch'}
  });

  FJS.addCriteria({
    field: 'taxonomy_business_location.slug',
    ele: '.js__filter-location',
    selector: 'select'
  });

  FJS.addCriteria({
    field: 'taxonomy_business_type.slug',
    ele: '.js__filter-type',
    selector: 'select'
  });

Here is a fiddle: http://jsfiddle.net/craigmdennis/ntmqtmod/
What happened to the custom filter types? I used to have:
filter_types: {
    any: function( current_value, option ){
      if ( current_value === '') { return true; }
      else { return current_value === option; }
    }
}

but I'm not sure if this still works in v2.

Is the custom filter (former filter_types) already available in version 2?
Thanks, Fausto


NoSuchMethodError: The getter 'headers' was called on null

I am trying to mocking Dio . So this is my test to test exception according your example:
void main() {
  group("Splash init", () {
    DioAdapterMockito dioAdapterMockito;
    Dio dio;
    const path = 'https://example/mobileFlutter/1.0/';

    setUpAll(() {
      registerServices();
      dioAdapterMockito = DioAdapterMockito();
      dio = Dio()..httpClientAdapter = dioAdapterMockito;
    });

    tearDownAll(() {
      print("Called teardown");
    });

    test(
        "call getMainConfigs -> getMainConfig web service called 404 exception",
        () async {
      final dioError = DioError(
        error: {'message': 'Some beautiful error!'},
        request: RequestOptions(path: path),
        response: Response(
          statusCode: 500,
          request: RequestOptions(path: path),
        ),
        type: DioErrorType.RESPONSE,
      );

      dioAdapterMockito.onGet(
        path,
        (request) => request.throws(500, dioError),
      );
      expect(() async => await dio.get(path), throwsA(isA<AdapterError>()));
      expect(() async => await dio.get(path), throwsA(isA<DioError>()));
      expect(
        () async => await dio.get(path),
        throwsA(
          predicate(
            (DioError error) =>
                error is DioError &&
                error is AdapterError &&
                error.message == dioError.error.toString(),
          ),
        ),
      );
    });
  });

But I got this error:
Expected: throws satisfies function
  Actual: <Closure: () => Future<Response<dynamic>>>
   Which: threw DioError:<DioError [DioErrorType.DEFAULT]: NoSuchMethodError: The getter 'headers' was called on null.
                Receiver: null
                Tried calling: headers
#0      Object.noSuchMethod (dart:core-patch/object_patch.dart:54:5)
#1      DioMixin._dispatchRequest
package:dio/src/dio.dart:927
                <asynchronous suspension>
#2      StackZoneSpecification._registerUnaryCallback.<anonymous closure> (package:stack_trace/src/stack_zone_specification.dart)
package:stack_trace/src/stack_zone_specification.dart:1
                <asynchronous suspension>
                >
stack package:dio/src/dio.dart 966:7                     DioMixin._dispatchRequest
package:dio/src/dio.dart:966....

I am using dio: ^3.0.9 and this is doctor:
Doctor summary (to see all details, run flutter doctor -v):
[✓] Flutter (Channel stable, 2.0.5, on Linux, locale en_US.UTF-8)
[✓] Android toolchain - develop for Android devices (Android SDK version 30.0.3)
[✓] Chrome - develop for the web
[!] Android Studio (not installed)
[✓] VS Code (version 1.55.2)
[✓] Connected device (1 available)

! Doctor found issues in 1 category.

Did you solve this? If yes, can you share it us the solution?

@tazik561 ^^^

This is my trick to solve that:
  group("Dio Exception", () {
    DioAdapterMockito dioAdapterMockito;
    Dio dio;
    DioError dioError;
    const path = 'https://.....';
    setUpAll(() {
      dioAdapterMockito = DioAdapterMockito();
      dio = Dio()..httpClientAdapter = dioAdapterMockito;

      dioError = DioError(
        error: {'message': 'Some beautiful error!'},
        request: RequestOptions(
          path: path,
        ),
        response: Response(
          statusCode: 500,
          request: RequestOptions(path: path),
        ),
        type: DioErrorType.RESPONSE,
      );
    });
    test("Dio 500 exception", () async {
      dioAdapterMockito.onPost(
        path,
        (request) => request.throws(500, dioError),
        headers: {'Content-Type': 'application/json; charset=utf-8'},
      );

      expect(() async => await dio.post(path), throwsA(isA<DioError>()));
    });
  });


"An internal error occurred while attempting to perform this command" /ce add/remove

I'm having this problem when I fight with mobs at some time players, mobs and drops just freezes in my screen but other players can see them moving and can play the game. The problem disappears when I rejoin the server but it will come back when I fight whit mobs again. So I tried to fix this by removing some enchantments from my sword that could cause this problem but when I try to perform this command /ce remove "enchantment" I just get this "An internal error occurred while attempting to perform this command". Please can someone help me! Thank you! :)

Go read your logs and see if there are error messages. This doesn't help anything.

Well It's pretty long... but here it is
[23:05:35] [Server thread/ERROR]: **** THIS IS NOT AN ISSUE TO DO WITH PER WORLD PLUGINS ****
Could not pass event PlayerMoveEvent to CrazyEnchantments v1.6.5
org.bukkit.event.EventException
at me.incomprehendable.dev.pwp.transparentlisteners.PerWorldPluginLoader$1.execute(PerWorldPluginLoader.java:118) ~[?:?]
at org.bukkit.plugin.RegisteredListener.callEvent(RegisteredListener.java:62) ~[craftbukkit.jar:git-Spigot-6016ac7-10c10b3]
at me.incomprehendable.dev.pwp.transparentlisteners.PWPRegisteredListener.callEvent(PWPRegisteredListener.java:28) [PerWorldPlugins.jar:?]
at org.bukkit.plugin.SimplePluginManager.fireEvent(SimplePluginManager.java:502) [craftbukkit.jar:git-Spigot-6016ac7-10c10b3]
at org.bukkit.plugin.SimplePluginManager.callEvent(SimplePluginManager.java:487) [craftbukkit.jar:git-Spigot-6016ac7-10c10b3]
at net.minecraft.server.v1_10_R1.PlayerConnection.a(PlayerConnection.java:607) [craftbukkit.jar:git-Spigot-6016ac7-10c10b3]
at net.minecraft.server.v1_10_R1.PacketPlayInFlying.a(SourceFile:126) [craftbukkit.jar:git-Spigot-6016ac7-10c10b3]
at net.minecraft.server.v1_10_R1.PacketPlayInFlying$PacketPlayInPosition.a(SourceFile:57) [craftbukkit.jar:git-Spigot-6016ac7-10c10b3]
at net.minecraft.server.v1_10_R1.PlayerConnectionUtils$1.run(SourceFile:13) [craftbukkit.jar:git-Spigot-6016ac7-10c10b3]
at java.util.concurrent.Executors$RunnableAdapter.call(Unknown Source) [?:1.8.0_91]
at java.util.concurrent.FutureTask.run(Unknown Source) [?:1.8.0_91]
at net.minecraft.server.v1_10_R1.SystemUtils.a(SourceFile:45) [craftbukkit.jar:git-Spigot-6016ac7-10c10b3]
at net.minecraft.server.v1_10_R1.MinecraftServer.D(MinecraftServer.java:733) [craftbukkit.jar:git-Spigot-6016ac7-10c10b3]
at net.minecraft.server.v1_10_R1.DedicatedServer.D(DedicatedServer.java:399) [craftbukkit.jar:git-Spigot-6016ac7-10c10b3]
at net.minecraft.server.v1_10_R1.MinecraftServer.C(MinecraftServer.java:672) [craftbukkit.jar:git-Spigot-6016ac7-10c10b3]
at net.minecraft.server.v1_10_R1.MinecraftServer.run(MinecraftServer.java:571) [craftbukkit.jar:git-Spigot-6016ac7-10c10b3]
at java.lang.Thread.run(Unknown Source) [?:1.8.0_91]
Caused by: java.lang.NullPointerException

There is a NullPointerException, you must have left something empty in one of the configs. Go check through them, cos this error log doesn't say anything about what's erroring in CE.

I was going to make an issue (still might, so its easier to find) but I could put it here (to the freezing issue, not the command problem).
If it was like me (relating to one of the sword enchantments causing things to "freeze") then it is the paralyze enchantment. I have found it by process of elimination on the enchants I had on my sword (I had many, lol).
What happens is when I use it, lightning strikes and then exp orbs no longer collect, and mob AI appears to be broken; even though in reality this is not the case.
This also was without the stormcaller enchantment on any armor. And it appears that lightning summoned through that enchant has no problem.
However, unlike the OP, I do not have problems with the commands.

If still having a problem in the next update please make a new issue.


Fix heading on guide index

What is the purpose of this pull request?

[ ] New Icon
[ ] Bug fix
[ ] New Feature
[x] Documentation update
[ ] Other:

Description

Fixes the heading level of a section on the index page of the guide.
Before Submitting

[ ] I've read the Contribution Guidelines.
[x] I've checked if there was an existing PR that solves the same issue.

Tnx!


Exited with code 1

I use gulp to (among others) compile typescript using the browserify package. If there is a compile error gulp-control just displays "exited with code 1" wheras if I use gulp from the terminal, it displays the location of the error in my source file.
My System: Windows 8, atom 1.9.9, latest version of gulp-control
I did a bit of debugging, seems it has something to do with line-endings and the additional split by '\r' in writeOutput. If I remove that, it works for me (but i don't know how this impacts other systems)

I get the same 'exited with code 1' error right after opening gulp-control.
Full message:
Using C:\Users\Mateusz\Desktop\my_project/gulpfile.js
Retrieving list of gulp tasks
Exited with code 1
My system: Windows 10 64bit , Atom 1.12.4, gulp-control 0.5.0
I am a gulp beginner so I mostly use if for autoprefixer and browser-sync. Nothing sophisticated.
Using gulp from the terminal works for me and it runs my tasks perfectly. Unfortunately, I am not as advanced coder as @wiggisser to perform some debugging, so I just flag this issue.
I'd certainly appreciate any help.

I'm also encountering this issue.


Add asm extersions api

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.yuzeng.zyx seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.You have signed the CLA already but the status is still pending? Let us recheck it.


Can't debug remote JS

Is this a bug report?
Yes

Have you read the Contributing Guidelines?
Yes
Environment
Environment:
  OS: macOS High Sierra 10.13.3
  Node: 8.2.1
  Yarn: 1.3.2
  npm: 5.6.0
  Watchman: 4.7.0
  Xcode: Xcode 9.2 Build version 9C40b
  Android Studio: 2.3 AI-162.4069837

Packages: (wanted => installed)
  react: 16.2.0 => 16.2.0
  react-native: 0.52.0 => 0.52.0

  Target Platform: iOS (11.2)

Steps to Reproduce

yarn start
input "i"
Click Debug Remote JS

Expected Behavior

use chrome debug JS
Actual Behavior

Google Chrome exited with error: Error: Exited with code 1
11:00:02:     at ChildProcess.<anonymous> (/Users/fourfish/Desktop/react-native/UdaciFitness/node_modules/opn/index.js:86:8)
11:00:02:     at Object.onceWrapper (events.js:318:30)
11:00:02:     at emitTwo (events.js:125:13)
11:00:02:     at ChildProcess.emit (events.js:213:7)
11:00:02:     at maybeClose (internal/child_process.js:921:16)
11:00:02:     at Socket.stream.socket.on (internal/child_process.js:348:11)
11:00:02:     at emitOne (events.js:115:13)
11:00:02:     at Socket.emit (events.js:210:7)
11:00:02:     at Pipe._handle.close [as _onclose] (net.js:549:12)

My Way
I tried everything from #6682, such as  restart chrome,  use "REACT_NATIVE_PACKAGER_HOSTNAME='<IP_ADDRESS>' npm start" and others.  But I still can't use  "Debug  Remote JS".

I closed vscode and reinstall chrome. I think it's a conflict between vscode and chrome.


chore: Refactor catalyst-gateway default error responses

Description
Refactored default error responses as BadRequest, InternalServerError and ServiceUnavailable.

Provide a separate struct for each of these error types as BadRequest, InternalServerError and ServiceUnavailable, which improves flexibility and eliminates potential bugs with just replacing schema definitions of duplicating responses.
Previous approach with just filtering duplicated responses by their status code, could lead to return a response (which is still accessible and part of the return response type) which is not described in the OpenAPI spec.
Fixed error handling and proper return of ServiceUnavailable for some endpoints

Closing PR due to conflicts with main.  Can re-open once they are resolved and its been merged with current main branch.


Migrate to null safety

Refer to the migration guide: https://dart.dev/null-safety/migration-guide
Note: null safety is supported in dart SDK > 2.12

Is there any progress about this issue?

Hello @heshanka - we definitely feel that migration to null safety will bring benefits to developers using this plugin so this issue is definitely towards the top of our backlog, however we can't currently promise when it'll be delivered as there are still a few fundamental features which we're working on ahead of this.


Collapsing a block doesn't collapse content with lower indenting

VSCode Version: Code 1.17.0 (be377c0faf7574a59f84940f593a6849f12e4de7, 2017-10-04T23:45:46.804Z)
OS Version: Windows_NT x64 10.0.15063
Extensions:

Extension
Author (truncated)
Version

Bookmarks
ale
0.16.0

npm-intellisense
chr
1.3.0

vscode-eslint
dba
1.3.2

python
don
0.7.0

tslint
eg2
1.0.9

vscode-npm-script
eg2
0.2.1

auto-rename-tag
for
0.0.14

latex-workshop
Jam
3.5.5

expand-region
let
0.1.1

HTMLHint
mka
0.4.0

cpptools
ms-
0.13.1

debugger-for-chrome
msj
3.3.1

code-settings-sync
Sha
2.8.3

code-spell-checker
str
1.4.6

python
tht
0.2.3

vscode-todo-highlight
way
0.5.11

html-css-class-completion
Zig
1.10.0

Steps to Reproduce:

Create a block of code where a line has no indenting (or just lower than the block itself)
Try to collapse it
Observe it collapsing everything but that line

Reproduces without extensions: Yes

This behavior makes sense when dealing with lines that simply have less indenting, as there's no difference in how the code would function and the author can just increase the indenting if necessary. But when the lines contain for example (javascript) template strings where indenting is very important, increasing indenting is not possible (or you'll have to change the code to string[] joining).
This can be quite a pain when dealing with large sections of template strings that aren't collapsed (such as in the image below).
A possible solution except for of course collapsing everything inside a collapsed block, would be to make it possible to collapse a multi-line template string by itself.

you must indent the code 118 and 119 line to work

I know but seeing as the lines are inside of the collapsed block and the block shows it being collapsed, it would make sense if they're collapsed as well. Additionally indenting those lines could possibly break the code. For example in the following code, indenting the code would put a tab in front of the message the user sees, and the amount of tabs in front of the line the user sees would increase even more when this function would be indented even more.
function showMessage() {
    const message = `
hi user,
some message`;
    messageBox.innerText = message;
}

The current folding strategy is based on indentation only.
What you are looking for is language aware folding: #3422


Add FollowRedirects and AllowInsecure property to LoadBalancerMonitor

Although the documentation at https://api.cloudflare.com/#organization-load-balancer-monitors-list-monitors doesn't show the follow_redirects and allow_insecure properties yet I do see them in the response and I can use them when creating organization load balancer monitors.

Hey @JorritSalverda: you’ll need to update the tests too.
https://travis-ci.org/cloudflare/cloudflare-go/jobs/301889006

Yep, working on the tests now. This probably shouldn't be merged directly to master, right? Not sure how to change that though.

@elithrar is the go vet $(go list ./... | grep -v /vendor/) error in the Go:tip job a flaky error?
My local golang 1.9.2 doesn't error on this command.

master should be the target branch: that’s where the changes will end up
after review. So no problems there.
The tip build is flaky but the latest Travis config will ignore build
failures on tip for now. I believe it’s related to a change in go vet w.r.t
ignoring vendor dirs.
On Tue, Nov 14, 2017 at 8:57 AM Jorrit Salverda<EMAIL_ADDRESS>wrote:

@elithrar https://github.com/elithrar is the go vet $(go list ./... |
grep -v /vendor/) error in the Go:tip
https://travis-ci.org/cloudflare/cloudflare-go/jobs/301943957#L624 job
a flaky error?
My local golang 1.9.2 doesn't error on this command.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/cloudflare/cloudflare-go/pull/155#issuecomment-344266624,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AABIcN6shhxa8orinEY12FE7QUCi0Yxaks5s2ZxQgaJpZM4QdLDv
.

Hey @JorritSalverda, it just happened that someone else has created a PR for the same issue in #218 and I've merged it. So, despite the fact this PR won't get merged, I'd like to thank for an effort and sorry about delayed response.


Convert imports to nested where possible and stylistically ok

We should convert things like
use core::ops::{Deref, DerefMut};
use core::convert::From;

to
use core::{ops::{Deref, DerefMut}, convert::From};

in cases where the resulting line is not too long or ugly.

I'd prefer it if we used a single standard across all imports. As you say, nested imports can definitely become ugly. I also find those imports quite hard to read, as it may be mistaken that convert::From is the fully qualified name.

I disagree. In some cases, you have things like this:
use core::ops::Add;
use core::convert::Try;
use core::slice::SliceExt;

which you could nicely condense to
use core::{ops::Add, convert::Try, slice::SliceExt};

However, in some situations, you might have something like this:
use core::ops::{Add, Mul};
use core::convert::{From, TryFrom, Into, TryInto};
use core::ptr::Unique;

Which shouldn't IMO be converted to
use core::{ops::{Add, Mul}, convert::{From, TryFrom, Into, TryInto}, ptr::Unique};

as then it gets very long.


FLOPS to DLOPS for int8 igemm

report performance foe int8 igemm in DLOPS in place of FLOPS
DLOPS is for Deep Learning OperationS
1 DLOP is the same one call to v_dot4_i32_i8

Isn't it better to report OPS instead of DLOPS? Reporting OPS would be consistent with how we report packed math and DOT2 perf.

Change to use OPS in place of DLOPS


🐛 Bug Report: workflowInputs of github:actions:dispatch are empty

📜 Description
Hi all, I'm trying to use github:actions:dispatch like this:
steps:
  - id: workflow
    name: Run Github Action
    action: github:actions:dispatch
    input:
      repoUrl: github.com?repo=***&owner=***
      workflowId: 'create-plugin.yml'
      branchOrTagName: main
      token: ***
      worfklowInputs:
        branch_name: "${{ parameters.branch_name }}"
        plugin_name: "${{ parameters.plugin_name }}"
        plugin_type: "${{ parameters.plugin_type }}"

but it turns out I'm getting this error
2023-06-30T12:08:51.251Z HttpError: Required input 'branch_name' not provided
But I have the parameter branch_name and I filled in this field in the UI. Not sure what is happening.

@guimilleo I think we need to see the rest of the template to see how branch_name is defined in the parameters block.


Refactor API

Refactor API so that it's more better pls

Yeah I think this is pretty much done with v0.3.0, but more improvements are likely to come over time


What is fly.dev?

https://github.com/mtenenholtz/chat-twitter/blob/f889b688aa35d38a9823e0dde5c0cff94a6ae1fc/app/page.js#L22

That's the API endpoint that hosts my backend code.


Optimize function

Closes: #XXX
What is the purpose of the change

Add a description of the overall background and high level changes that this PR introduces

GetSortedKeys: Initialized the slice with make([]K, 0, len(m)) to avoid slice resizing.
LinearInterpolation: Simplified the interval search in linear interpolation using sort.Search, reducing the number of iterations.

Testing and Verifying
(Please pick one of the following options)
This change is a trivial rework / code cleanup without any test coverage.
(or)
This change is already covered by existing tests, such as (please describe tests).
(or)
This change added tests and can be verified as follows:
(example:)

Added unit test that validates ...
Added integration tests for end-to-end deployment with ...
Extended integration test for ...
Manually verified the change by ...

Documentation and Release Note

[ ] Does this pull request introduce a new feature or user-facing behavior changes?

Where is the change documented?

[ ] Specification (x/{module}/README.md)
[ ] Allora documentation site docs.allora.network source code at: https://github.com/allora-network/docs
[ ] Code comments?
[ ] N/A

Thank you for the contribution!


Index templates lost after updating/recreating pods

Hi Paulo!
First of all, I want to say thank you for this amazing project.
I'm at the end of building a production grade ES cluster using pretty much all the components you put out here. After updating all the pods with a plugin (recreating every pod), the index templates seem to be deleted. Those templates are stored in ES through the API using a PUT request. Initially, I thought all data is stored only in the data nodes (pods with data role) but it seems like master nodes also need PV to store that kind of data.
Referencing this discussion: https://discuss.elastic.co/t/index-template-lost-after-recreate-es-cluster-in-kubernetes-environment/83791
Does it make sense to deploy master pods as StatefulSet as well?

Why not? Open to review a PR ;)

Hehe great! There it is, #211 :)


Edit and expand command docs

This one is just the top-level commands. Will do separate PR for subcommands (generation schematics).

Please provide an example using the run command with the universal target.

@hansl I have addressed your requested changes - please check and remove blocker.
@alan-agius4
Do either of you know why it's failing continuous-integration?

Moved these commits to docs-preview branch - PR Docs preview #12837


Protecting a public IP resource attached to a Public Load Balancer is not supported for DDoS IP Protection SKU?

What does this mean exactly:
"Protecting a public IP resource attached to a Public Load Balancer is not supported for DDoS IP Protection SKU."
When I go to the preview Azure Portal and select a public IP which is used for AKS (service -> standard loadbalancer) I have the option to select DDOS IP protection.
So I assume the above statement is wrong, right?

Document Details
⚠ Do not edit this section. It is required for learn.microsoft.com ➟ GitHub issue linking.

ID: 668d8ec7-efd0-6648-7743-4dd8bc0e4c92
Version Independent ID: 1c2efe6a-a24f-1f56-168a-f174caaafcff
Content: About Azure DDoS Protection SKU Comparison
Content Source: articles/ddos-protection/ddos-protection-sku-comparison.md
Service: ddos-protection
GitHub Login: @AbdullahBell
Microsoft Alias: Abell

I actually tried to enable (in the Preview Portal) IP Protection for my Public IP used by AKS, and it seems to have worked (shows IP Protection in properties) ... but not sure ...

@deyanp
I've delegated this to content author @AbdullahBell, who will review it and offer their insightful opinions.

Hello @deyanp, this limitation is no longer valid and is now removed from the documentation. Thank you!

Great, thanks, @AbdullahBell !


Feat/RRF-58 reload left panel

SUMMARY

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

TESTING INSTRUCTIONS

ADDITIONAL INFORMATION

[ ] Has associated issue:
[ ] Required feature flags:
[ ] Changes UI
[ ] Includes DB Migration (follow approval process in SIP-59)

[ ] Migration is atomic, supports rollback & is backwards-compatible
[ ] Confirm DB migration upgrade and downgrade tested
[ ] Runtime estimates and downtime expectations provided

[ ] Introduces new feature or API
[ ] Removes existing feature or API

please fix linting and test errors


Cleanup old Docker images

Using scheduled GitHub Actions workflows:
Cleanup images at https://github.com/FerretDB/FerretDB/pkgs/container/ferretdb-dev that are older than 3 months
We should use our own Go version to detect versions we should delete (using our own logic), but we can delegate actual deletion to some other action, such as https://github.com/bots-house/ghcr-delete-image-action or https://github.com/snok/container-retention-policy.
Some related previous work:

https://github.com/percona-platform/get-stale-packages-action

I'd like to try this

Per the github doc, container is not included in graphQl any more, and can only be queried using Restful API. So I will use Restful API for this task.

@wqhhust thanks for the update 🤗 it seems using Rest API is the recommendation.

refer: https://github.com/orgs/community/discussions/53854#discussioncomment-5744364

I think we should move and package that code in https://github.com/FerretDB/github-actions as a separate composite action, with organization and package names being passed via parameters. See extract-docker-tag for an up-to-date and good example.

@wqhhust would you like to work on that?

@AlekSi  Currently I don't have much time to work on it. When I have time, I will go back to it. You could reassign it to other if somebody can work on it.  Or I will recheck it in my free time.

Thank you, no worries!


Hosting a Web API 2.0 inside Windows Server Core 2019 results in ManagedPipelineHandler error

I'm trying to host a Web API 2.0 (.NET Framework 4.7.2) inside a Windows Server Core 2019 container. Here is my Dockerfile:
FROM mcr.microsoft.com/dotnet/framework/aspnet:4.7.2-windowsservercore-ltsc2019
WORKDIR /inetpub/wwwroot
COPY . .

Upon submitting a request to the container hosted API I'm receiving a HTTP 500 status. I went ahead and enabled Failed Request Routing and can see below entry in the log file:
 <EventData>
  <Data Name="ContextId">{80000002-0000-FF00-B63F-84710C7967BB}</Data>
  <Data Name="ModuleName">ManagedPipelineHandler</Data>
  <Data Name="Notification">128</Data>
  <Data Name="HttpStatus">500</Data>
  <Data Name="HttpReason">Internal Server Error</Data>
  <Data Name="HttpSubStatus">0</Data>
  <Data Name="ErrorCode">0</Data>
  <Data Name="ConfigExceptionInfo"></Data>
 </EventData>

Performing the command: dism /online /enable-feature /featurename:IIS-ASPNET45 /all does not help.
I have uploaded the failing image to Docker Hub: docker run -d -p 16670:80 ershadnozari/xbrlvalidator2:latest. HTTP POST sample request here:
XbrlRequest.txt
I don't have any issue hosting the Api locally, on Windows 10 1809 (version 17763.292).
Any help I can get with this issue is much appreciated.

@ershadnozari, is this still an issue for you?

Hey Stephen, we did move to .NET Core & Linux containers, therefore passed the problem. However, we never managed to get to the root cause and solve the issue I’ve here. It can be closed if you wish. Thanks


Add versioned check for GetApiContractReferences

Correct paths for reference assemblies for systemManagementContract, part of the IOT extension SDK, are not resolved with insider preview SDK, 15003 and 15021. The files are in here:
C:\Program Files (x86)\Windows Kits\10\References<VERSION>\Windows.System.SystemManagementContract\<IP_ADDRESS>\Windows.System.SystemManagementContract.winmd.
The reason is when we call GetApiContractReferences we didn't check the Versioned property of the sdk. So it returned the path without

Your branch is pretty out of sync.  Probably not worth it now since the PR is already open.

Shouldn't the target here be vs15.1 instead of `xplat?

Create new PR based on vs15.1 branch.