Add option to choose between track or album normalisation gain

Add option to choose between track or album normalisation gain, set default normalisation gain type to album. If there's something I've missed here, let me know.

Relevant to the conversation in #162 and closes #572

Relevant to the conversation in #162 and closes #572

@philippe44 if you wouldn't mind testing this, using the --enable-volume normalisation --normalisation-gain-type track and --enable-volume normalisation --normalisation-gain-type album options, that would be great, since I'm not going to be able to hear the difference through earpods to verify that it works as expected.

@philippe44 if you wouldn't mind testing this, using the --enable-volume normalisation --normalisation-gain-type track and --enable-volume normalisation --normalisation-gain-type album options, that would be great, since I'm not going to be able to hear the difference through earpods to verify that it works as expected.

I'm happy to help, but are you sure this message is for me? My PR does not touch/impact volume&gain normalization as it's a passthrough

I'm happy to help, but are you sure this message is for me? My PR does not touch/impact volume&gain normalization as it's a passthrough

Oops, pinged the wrong person. @slartibartfast3 see above.

Oops, pinged the wrong person. @slartibartfast3 see above.

Oops, pinged the wrong person. @slartibartfast3 see above.

I can definitely test of you tell me what I need to do. I am using Michael Herger's plugin for Squeezebox. You will easily hear the difference if you listen to the last track on Pink Floyd "The Wall". It is meant to be very low volume so using track gain is obviously far louder.

Oops, pinged the wrong person. @slartibartfast3 see above.

I can definitely test of you tell me what I need to do. I am using Michael Herger's plugin for Squeezebox. You will easily hear the difference if you listen to the last track on Pink Floyd "The Wall". It is meant to be very low volume so using track gain is obviously far louder.

Oops, pinged the wrong person. @slartibartfast3 see above.

Sorry it took so long but I finally managed to install everything and I can confirm it works. I used the transition between the final two tracks on "The Wall" to test it and with track gain there is a massive jump in volume whereas with album gain the tracks flow together perfectly.

Oops, pinged the wrong person. @slartibartfast3 see above.

Sorry it took so long but I finally managed to install everything and I can confirm it works. I used the transition between the final two tracks on "The Wall" to test it and with track gain there is a massive jump in volume whereas with album gain the tracks flow together perfectly.

Unless there are any objections, I'll add the documentation to the wiki and merge this in a few days.

Unless there are any objections, I'll add the documentation to the wiki and merge this in a few days.

Yes you're right. I amended the default at the last minute and forgot to update the doc, will change that later

Yes you're right. I amended the default at the last minute and forgot to update the doc, will change that later

Is the label "breaking change" as serious as it sounds?

Is the label "breaking change" as serious as it sounds?

Is the label "breaking change" as serious as it sounds?

It depends ;-)

https://xkcd.com/1172/

Is the label "breaking change" as serious as it sounds?

It depends ;-)

https://xkcd.com/1172/

I labelled as breaking mainly so that I have an easy reference point as to what needs to be updated in the wiki, and what needs to go into the changelog for next release.

I labelled as breaking mainly so that I have an easy reference point as to what needs to be updated in the wiki, and what needs to go into the changelog for next release.


Memory leak

Which component is your bug related to?
Forge
Foundry Version
0.5.0
What operating system are you using?
Linux
What system architecture are you using?
x86
What happened
The memory usage is too high.
To reproduce, you can play snforge  on satoru and track memory usage of snforge process.
In my case it reaches 9.4 Go.
Trace
The computer just freeze and I have to hard boot it.
Probably related to: https://github.com/software-mansion/scarb/issues/624
Is there an existing issue for this?

[ ] I have searched the existing issues and verified no issue exits for this problem.

@Bal7hazar copying the message I sent on Satoru's telegram to not lose it:
"Hi guys, we (Starknet Foundry team) investigated the speed and memory issues when running snforge for Satoru.
Basically the temporary solution is to keep tests in the module tree of your package. Tried it on my laptop and those were the results:

time: 441 s -> 150 s
peak RAM usage: 9.4 GB -> around 1.5 GB

The main bottleneck for us is compilation and it is the best way to reduce its time for now (until compiler team does not introduce incremental compilation, but it is not their main focus atm)."
LMK if this solution helped!

Proposed improvement: #647

Closing the issue, if the solution did not help feel free to reopen!


Freespace 2

Project link: https://icculus.org/~ravage/freespace2/
Project license: Unknown
Does it work on 64-bit only Linux: MAYBE
Is source code available?: NO
Is source code stored in Git?: NO
List of Steam AppIds of supported games:

https://steamdb.info/app/273620/

This one is already supported. Please see https://luxtorpeda-dev.github.io/packages.html

My bad.


Phaser.Text's wordwrap doesn't work with Chinese words

There are no spaces between Chinese words,but Phaser splits words by space,so the wordWrap and wordWrapWidth property have no effect on Chinese.

Yes sorry about this, I'm not sure of the best way to address it though. How should it wrap words without spaces? I can't pick a number of characters, because that could chop a word entirely in two - what should be done?

I saw this thread while browsing, and I realized I didn't know the answer either. I found this interesting resource though, and i'd like to share : https://msdn.microsoft.com/en-us/goglobal/bb688158.aspx

Closing as it's a duplicate of #1403


Else If statements

Squiggle currently doesn't support else if or switch statements. Else if is probably a good starting point.
Description of suggestion or shortcoming:
if param == "life" then {
  animal_saved_life_value(animal)
} else if  param == "qaly"{
....
}

Closing, after some Slack discussion


Always prefer the PDF.js JPEG decoder for very large images, in order to reduced peak memory usage (issue 11694)

When JPEG images are decoded by the browser, on the main-thread, there's a handful of short-lived copies of the image data; see https://github.com/mozilla/pdf.js/blob/c3f4690bde8137d80c74203b1ad91476fc2ca160/src/display/api.js#L2364-L2408
That code thus becomes quite problematic for very big JPEG images, since it increases peak memory usage a lot during decoding. In the referenced issue there's a couple of JPEG images whose dimensions are 10006 x 7088 (i.e. ~68 mega-pixels), which causes the peak memory usage to increase by close to 1 GB (i.e. one giga-byte) in my testing.
By letting the PDF.js JPEG decoder, rather than the browser, handle very large images the peak memory usage is considerably reduced and the allocated memory also seem to be reclaimed faster.
Please note: This will lead to movement in some existing eq tests. Refer to https://github.com/mozilla/pdf.js/pull/11523#issuecomment-578740441 for an explanation of the different test "failures".
Fixes #11694 (to the extent that doing so is possible, given the size of the JPEG images).

/botio test

/botio-linux preview

I can confirm that the tab doesn't crash anymore. In general I also think that this is a better approach for large images. Thanks!


Set Up for Moving More Enhancement to Preprocessing

The attached splits the enhancing of comment data into its own function, and adopts it for linkback_fix, while adding a wrapper function to enhance new comments. It does not yet enable this.
It also adopts the comment_meta array inside comment_data to mirror the wp_new_comment functionality so it will be automatically added on preprocess_comment.
If this split works, then the next step is to improve on linkback_fix to turn into a function that focuses on the logic for updates.

This needs some cleanup and changes now that 4.7 is out. Will resubmit.


Output 1: merge mspacy and mstanza output

merged the vrt file writing for spacy and stanza to more general routine in base

Still left to do:

[ ] mspacy take output file name from main dict and not spacy dict
[ ] does token enumeration start from 0 or 1? (0 - spacy, 1 - stanza)
[ ] check that chunker still works for mspacy and refactor to reduce complexity
[ ] check that senter only still works for mspacy
[ ] clean up comments/ remove commented-out code
[ ] clarify role of out_object: self/classmethod/staticmethod


Backups/Restore functionality

Is your feature request related to a problem? Please describe.
I have just started using nginxmanager quite a lot now with some production services too.
I did the easy setup with no external databases so I am wondering how to export/import?
Describe the solution you'd like
Export / Backup
Import / Restore
Describe alternatives you've considered
Don't know.. go into the docker container and hack into the sqllite db??
Additional context
Good for distater recovery too if we could just export data into a well known format and have it backup up away from the backup

Usually you can do this with copying the data and letsencrypt directory of the compose folder, aka the whole npm docker compose folder.

I would LOVE to see this natively from within the user interface ---> hence that's the reason at all I like this product

I'm wondering: is atomicity always guaranteed on the sqlite file? In other words: can we be sure that the database on disk is never in an inconsistent state due to ongoing transactions?
If above can't be guaranteed, we need to always stop proxy-manager for a while to be able to pull a safe copy, which can be undesired. In that case, a function to have proxy-manager export a copy (on some kind of trigger which can be automated) would be very helpful. Home Assistant for example has a builtin service for this which can be hooked up to any automation.

I'm also not familiar with the codebase at all. I just found your issue because I'm missing this kind of function myself too.
As can be read here atomicity is taken care of, but SQlite uses file locks from the OS for that. If we just read the SQLite file on our own (while proxy manager is also running) we can't be sure that blocks of the file are actually being written because we bypass SQLite's locking protocol. I've noticed that even without changing settings on my instance, the database file gets frequent updates, so I think it's too big of a risk to just read it while proxy manager is running.
Hence I think your feature request is very useful. Why a CSV and not just a copy of the SQLite file?
Regarding the certificates, I think just re-requesting them and not including them in a backup would indeed be the easiest way to solve this.

Usually you can do this with copying the data and letsencrypt directory of the compose folder, aka the whole npm docker compose folder.

I would, but copying or tarring gives me permissions errors I don't know for sure are relevant for a successful export.
https://i.imgur.com/tKfJ3BV.png
Using the jc21/nginx-proxy-manager:latest docker image

@danielschenk you are absolutely correct that copying the SQLite database file while the database is online is not safe from corruption. SQLite does have several built-in ways to backup a running database:

The clone command, but this is slow and locks the entire database for writes while it's running (you can still read).
The dump command, which dumps the schema and data as SQL to a text file. This is typically faster than clone, but still not "fast", and it also locks the database for writes.
You can use vacuum into to defragment the database into another file. This is faster than the first two, but still not very fast and also locks the database for writes.
The backup command, which is faster than all the others, and doesn't lock the whole database (it does perform locks, but it releases them and yields to other connections).
There's also an API for performing backups (see https://sqlite.org/c3ref/backup_finish.html), but I don't know if it's supported in the sqlite3 package being used here (but you might be able to simply call the backup command by using exec() and passing .backup).

Dream on...


Adjust Role Titles to Use Admin and Editor

Closes #98
Mainly just a change in terminology. This is to avoid the former confusion where a user with a PFE role of "researcher" was not given the "researcher" role in ALICE.

I think I need to optimize it a bit to close #84. If you are associated with more than 50 projects, it might be that your role for one of the text editor projects isn't being retrieved.
I'm going to try to get a collection of project roles based on projects in the text editor instead of all projects associated with a user.

Closes #84. Alright, give this another go. I think this should fix the issue, but let me know if not. Either way, this closes another issue linked.

Good eye on the review. This should be good to go.


Let as_mpl_selector forward **kwargs to *Selector

The docstring for the as_mpl_selector methods states that any additional **kwargs can be passed to the respective matplotlib selector instances, but currently they are in fact discarded. This PR passes them through.
In addition I have added the option to override the default rectprops by kwarg – which otherwise might conflict with the argument specified by the user, although it's perhaps to be discussed whether these should always be set by region.visual.
And I think there is a point to have some parameters still set to different defaults from mpl, if not explicitly set by the user, e.g. {'edgecolor': 'black', 'facecolor': 'none'} is certainly the more reasonable default here.
Also todo tests (?); should any/which additional parameters, like drag_from_anywhere, be specifically mentioned in the docstring?

Yes, let's mention drag_from_anywhere explicitly in the docstring.

Marking this as ready for review now, although there could be one or two tests for passing other kwargs added, + the docstring for drag_from_anywhere.
This seems to solve one part of #415; but matplotlib versions < 3.3 that do not have on_select need to be taken care of – either adding our own replacement for the convenience function, or simply skipping those 3 tests.

I should note that the second part of test_mpl_selector_drag is supposed to show that move does not work outside the centre anchor; however it behaves exactly the same with drag_from_anywhere=False as (it is supposed to) with drag_from_anywhere=True. Interactively this works as expected; no idea if then on_select or MouseEvent still behave in some way differently from clicking the real mouse button.
Also not sure if the version check is worth importing packaging.version; it could still relatively easily be done on _mpl_version.split('.'), but it would be nice to have a somewhat more centralised mpl_version control.
Related to this, the new kwargs tests would also need version conditionals, since some of the parameters have been renamed as well in 3.4 or 3.5.

I've pulled the Matplotlib checks up one level into shapes/utils.py to make an integer MPL_VERSION ([major][minor]) available. Might be useful even at the top level, but I haven't found a good place to put it, and outside shapes there is not much reference to HAS_MATPLOTLIB and I think none to its version.
I've also included a fix to the Mpl intersphinx setup for testing: it seems the base URL has been moved around 3.5 from https://matplotlib.org/ to https://matplotlib.org/stable/ ; if you compare the link to matplotlib.widgets.EllipseSelector in
https://astropy-regions.readthedocs.io/en/stable/api/regions.EllipsePixelRegion.html
to
https://astropy-regions--392.org.readthedocs.build/en/392/api/regions.EllipsePixelRegion.html
the former is pointing to the old URL, being redirected, but losing the section reference in the process.
Seems to work with the changed URL, so this should probably be repaired upstream in astropy docs/conf.py, but we could keep it here as a temporary fix.

Changed to AttributeError (have to remember to sync this in the Polygon selector PR as well).
I've reverted the intersphinx path fix, since it is now in Astropy 5.0.1.

Is this ready for a final review?

Yes, should now - there was a call from the mpl_selector docs that only worked with mpl dev.

Tests are now failing after the updated matplotlib version check.

@dhomeier There are merge conflicts.  Can you please rebase?

Doh, was caught right in between by 62eb153 (from the test I thought visual was supposed to not be copied over)!

Thanks!


STASH unit plugin

So basically what I'm suggesting is a plugin that is called "stash unit". Where it'll you if you already constructed the stash unit and have items inside it or not. (Enum?)
So, how to use the plugin is, when doing a clue scroll.. You'll always have under the info box on the left
"Stash Unit: Yes" //If you built the unit and have items inside it
"Stash Unit: Empty" //If you built the unit and have no items inside it
or
"Stash Unit: No" //Didn't build one
It'll update every time you're in the area/region.. And once you click on it?
I was grinding like 50 medium clues today.. I was questioning myself if I have stash unit built or not.. so yea.

Duplicate of #1742 and #1662


State not valid (expected: null, received: .....)

Issue and Steps to Reproduce
After updating to the latest version i got the following error:
Error: State not valid (expected: null, received: QfoT4KWMKBO2kqG2)
When i reload the app, it words as intended.
Versions
7.22.32
Screenshots

Installed packages:

Hi @bernhard-braeu , do you have a sample of your configuration and how do you trigger the login? Do you have also the full url of your authentication page? State should be here as query string.

Hello there!
I am facing the same issue, so I didn't see necessary to open a new issue.
IdentityServer Configuration.
  new ()
  {
      ClientId = "coolapp-webui",
      ClientName = "coolapp UI",
      AllowedGrantTypes = {GrantType.AuthorizationCode, GrantType.ResourceOwnerPassword},
      AllowedScopes = { "openid", "profile","coolapp"},
      ClientUri="https://coolapp.domain.net",
      RedirectUris={ "https://coolapp.domain.net/authentication/callback","https://anothercoolapp.domain.net/authentication/callback" },
      PostLogoutRedirectUris={ "https://coolapp.domain.net/signout-callback-oidc","https://anothercoolapp.domain.net/signout-callback-oidc" },
      AllowedCorsOrigins={"https://coolapp.domain.net","https://anothercoolapp.domain.net"  },
      LogoUri="https://img.server.net:5022/img/products/logo-coooolapp.png",
      RequirePkce=false,
      RequireClientSecret=false,
      AccessTokenLifetime=2678400,
      UserSsoLifetime=2678400,
      ClientSecrets ={new Secret("gazoz".Sha256()) },
      AllowOfflineAccess=true,
      Description="coolapp",
      Properties=PropertiesService.GetEttaProperties()
  },

const prod = {
    client_id: 'coolapp-webui',
    redirect_uri: 'https://coolapp.domain.net/authentication/callback',
    silent_redirect_uri: 'https://coolapp.domain.net/authentication/silent-callback',
    // silent_login_uri: window.location.origin + '/authentication/silent-login',
    scope: 'openid profile etta',
    authority: 'https://authority.servissoft.net:5022',
    // authority_time_cache_wellknowurl_in_second: 60* 60,
    refresh_time_before_tokens_expiration_in_second: 40,
    service_worker_relative_url: '/OidcServiceWorker.js',
    service_worker_only: false,
    // storage: localStorage,
    // silent_login_timeout: 3333000
    // monitor_session: true,
    token_renew_mode: TokenRenewMode.access_token_invalid,
    demonstrating_proof_of_possession: false
};

//

My OidcConfiguration:
export const configurationIdentityServer: OidcConfiguration = {
    client_id: import.meta.env.VITE_APP_OIDC_CLIENT_ID!,
    redirect_uri: `${window.location.origin}/authentication/callback`,
    silent_redirect_uri: `${window.location.origin}/authentication/silent-callback`, // Optional activate silent-signin that use cookies between OIDC server and client javascript to restore the session
    authority_time_cache_wellknowurl_in_second: 60 * 60,
    refresh_time_before_tokens_expiration_in_second: 40,
    scope: 'openid profile email',
    authority: import.meta.env.VITE_APP_OIDC_AUTHORITY,
    service_worker_relative_url: '/OidcServiceWorker.js',
    service_worker_only: true,
    token_renew_mode: TokenRenewMode.access_token_or_id_token_invalid
};

I'm using withOidcSecure to secure my routes:
export const AppRoutes = () => {
    return (
        <Routes>
            <Route Component={withOidcSecure(Frame)} path="/">
                <Route element={<Navigate to="home" />} path={''} />
                <Route Component={withOidcSecure(Home)} path="home" />
                <Route Component={withOidcSecure(Permissions)} path="permissions" />
            </Route>
        </Routes>
    );
};

Hi @bernhard-braeu , withOidcSecure(Frame)
Create react component dynamicaly. You need to do it outside ot a react component else it is a new component created for each render and it can xreate some bug in you application.

We are using it the same way as you show it in the documentation:
https://github.com/AxaFrance/oidc-client/tree/main/packages/react-oidc#how-to-secure-a-component-hoc-method
It worked quite well until the last few updates.
Do you think this is related to the "State not valid" problem?

@guillaume-chervet Do you have any update regarding this issue? Do you think the way we are using withOidcSecure is the problem?


bigInt(long hexstring) throws an "Invalid integer error"

Bug reproduction
$ node
> bigInt = require('big-integer')
> bigInt('0xaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa')
Thrown:
Error: Invalid integer: 0xaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa
    at parseStringValue (~/node_modules/big-integer/BigInteger.js:1382:29)
    at parseValue (~/node_modules/big-integer/BigInteger.js:1413:20)
    at Integer (~/node_modules/big-integer/BigInteger.js:15:16)

Current node version is v12.16.2

bigInt doesn't use the 0x prefix for hex numbers. You can pass 16 as a second argument to specify that the input is hex:
bigInt('aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa', 16)

Thank you it helped. FYI, it also worked for a short length '0x' prefixed hex like bigInt('0xaaaa') thou I was confused.

Tested again, but it still has a problem. I'm using node v10.
Here's the log.
> bigInt('aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa')
Thrown:
Error: Invalid integer: aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa
    at parseStringValue (/home/wanseob/Projects/wanseob/zkopru/node_modules/big-integer/BigInteger.js:1382:29)
    at parseValue (/home/wanseob/Projects/wanseob/zkopru/node_modules/big-integer/BigInteger.js:1413:20)
    at Integer (/home/wanseob/Projects/wanseob/zkopru/node_modules/big-integer/BigInteger.js:15:16)

Did you forget the second argument? You didn't pass in 16

Oo yes you're right, apologize my silly mistake

the problem is that it seems to work in the V8 implementation so you might want to reconsider supporting the '0xfffff' syntax. this lib can't act as polyfill because of this.
(left is node, right is this library)

or maybe don't state in the Readme it is a polyfill.

There was no intention to the exact API of native BigInt. This library was created before native BigInt was proposed, and contains features that native BigInt does not have, so doing so would introduce breaking changes.
What the readme means is that this library will work as expected whether or not the environment it runs on supports native BigInt. If there is no support, it will use an array-of-numbers implementation. If BigInt is supported, then this library will take advantage of it.


#3816 user custom dim color

Description

You can specify color for dimension values for Bar, Scatter, Pie, and WordCloud.
Related Issue : #3816

How Has This Been Tested?

Create Bar, Scatter, Pie, and WordCloud.
Change the color settings for the chart to the color settings for dimension values.
Check if you can specify a separate color for each dimension value.

Need additional checks?
Types of changes

[ ] Bug fix (non-breaking change which fixes an issue)
[X] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

[ ] I have read the CONTRIBUTING document.
[ ] My code follows the code style of this project.
[ ] My change requires a change to the documentation.
[ ] I have added tests to cover my changes.

Additional Context

deploy to 2


WEBSITE IS NOT FINDING ANY WEATHER

@chubin ANY location I type into wttr.in comes out as a 404! PLEASE HELP!

same for me, every city returns a 404 error

same for me, every city returns a 404 error

I hope he finds a fix. (It's probably the weather server he is using is down.)

same for me, every city returns a 404 error

I hope he finds a fix. (It's probably the weather server he is using is down.)

most probably, yeah

Please test it now

Please test it now

It still doesn't work

Please test it now

yup, now it works, atleast for me

nvm it works now, thank you

@chubin It works now, thanks!


.ToDictionary causes build error on .Net 8

Expected Behavior
Lean should compile successfully on .Net 8
Actual Behavior
Lean does not compile successfully on .Net 8
Potential Solution
Replace any references to LinqExtensions.ToDictionary to the explicit call such as LinqExtensions.ToDictionary(object) instead of object.ToDictionary()
Reproducing the Problem
Download Visual Studio 2022
Download .NET 8.0.7
Open Lean from visual studio
build
System Information
Windows 10
.Net 8.0.7
Lean Latest
Checklist

[x] I have completely filled out this template
[x] I have confirmed that this issue exists on the current master branch
[x] I have confirmed that this is not a duplicate issue by searching issues
[x] I have provided detailed steps to reproduce the issue

Hi @superichmann,
https://github.com/QuantConnect/Lean/issues/7612 will address this issue.

Thanks @AlexCatarino


BooleanInput not being colored in red when trying to save without it being checked

I have <BooleanInput source="check_me_or" validate={[required]} />
ie. i want to save the form only if user checks the checkbox.
But the checkbox is not colored red as error on clicking form submit.
This looks like error, as user has no indication that he should check the box.
(this is somewhat same as issue #439, trough for different reasons)
It does not even work if i set some error trough
const checkForm = (values) => { const errors = {};if (!values.check_me) {errors.check_me = ['Check me!'];  } return errors; };
<SimpleForm validate={checkForm}>
<BooleanInput source="check_me" />
</SipleForm>
(no error is shown when clicking on submit and form is not submitted)

You can use a SelectInput to have error message.
I doubt BooleanInput will support this as its dependent component Toggle does not.

Use <NullableBooleanInput> instead. A normal <BooleanInput> cannot distinguish between null and false.

@fzaninotto i don't need to distinguish between null and false i just want the user see error on checkbox when i set it.
@wesley6j the Toggle supports styling though so it can be at least colored red
I just make it colored red by myself, i just though to report this as the Checkbox is inconsistent with other inputs and it can suprise users that it doesn't work the same way.

There can't be an error on a non-nullable boolean input, because it can only have two values true and false. It turns out that the default value from aor (undefined) and the default value from your restClient (usually undefined) all equal to false, and therefore are valid values.

i already handled it by wrapping the BooleanInput.
Posting the custom solution here, in case someone needs something similar
import React from 'react';
import PropTypes from 'prop-types';
import { BooleanInput } from 'admin-on-rest';

const getStyles = ({ elStyle, meta: { touched, invalid } }, { muiTheme }) => {
  const errColor = muiTheme.textField.errorColor;

  let borderBottom;
  if (touched && invalid) {
    borderBottom = `2px solid ${errColor}`;
  }

  return ({
    ...elStyle,
    margin: '1rem 0',
    maxWidth: 250,
    borderBottom,
  });
};

export const RequiredBooleanInput = (props, context) => {
  const style = getStyles(props, context);
  return <BooleanInput elStyle={style} {...props} />;
};

RequiredBooleanInput.propTypes = BooleanInput.propTypes;
RequiredBooleanInput.defaultProps = BooleanInput.defaultProps;
RequiredBooleanInput.contextTypes = {
  ...BooleanInput.contextTypes,
  muiTheme: PropTypes.object.isRequired,
};

export default RequiredBooleanInput;

(can be even used for RadioButtonGroupInput, just replace BooleanInput for RadioButtonGroupInput)

Again, this is a bad solution. If you want to validate the presence of a user entry in a Boolean input, you must use NullableBooleanInput with the required validator.

NullableBooleanInput is not checkbox but select though....


Refactor run loop

The error I get is
error[E0502]: cannot borrow `*self` as mutable because it is also borrowed as immutable
   --> src/lib.rs:478:27
    |
470 |         let mut stream = self.consumer.stream();
    |                          ------------- immutable borrow occurs here
...
478 |                     match self.process_message(&mut state, &m).await {
    |                           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ mutable borrow occurs here
...
502 |     }
    |     - immutable borrow might be used here, when `stream` is dropped and runs the `Drop` code for type `MessageStream`


feat(graphql-relational-transformer): add gsi creation for ddb references queries

Description of changes

Adds the updateTableForReferencesConnection method, which will be invoked in generateResolvers in the incoming HasManyDirectiveDDBReferencesTransformer (subsequent PR).

Makes an initial pass at consolidating common parts of updateTableForConnection (fields) and updateTableForReferencesConnection.

There are few TODOs included with this change that will be resolved in later PRs.
Once we have a commit in feat/ddb-references, I'll open a draft PR against main and start tracking these as open items in feature branch PR description.
CDK / CloudFormation Parameters Changed

Issue #, if available

Description of how you validated changes
Checklist

[x] PR description included
[x] yarn test passes
[ ] ~Tests are changed or added~
[ ] ~Relevant documentation is changed or added (and PR referenced)~
[ ] ~New AWS SDK calls or CloudFormation actions have been added to relevant test and service IAM policies~
[ ] ~Any CDK or CloudFormation parameter changes are called out explicitly~

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Please add unit tests or mark them as TODOs to be finished in separate PRs

Tracking as an open item in the feature branch PR.


Adding nmap readme + minor bug fix

Enriching README and fixing minor bug happening when reading the XML …
Fixing minor bug happening when reading the XML output of Nmap.


Cleartext password in config-file

Is there any way to call a command to put my password into an encrypted file?
For example in mbsync (a fast replacement for the slow and memory-hungry offlineimap) I can use instead of the password the following: gpg -q --for-your-eyes-only --no-tty -d /home/nik/.passwd/account.passwd.gpg

---
Want to back this issue? **[Post a bounty on it!](https://www.bountysource.com/issues/23725698-cleartext-password-in-config-file?utm_campaign=plugin&utm_content=tracker%2F574345&utm_medium=issues&utm_source=github)** We accept bounties via [Bountysource](https://www.bountysource.com/?utm_campaign=plugin&utm_content=tracker%2F574345&utm_medium=issues&utm_source=github).

Yes, see https://vdirsyncer.readthedocs.org/en/stable/keyring.html


Unify decision variable and problem size info handling

This is probably the largest weakness in the backbone, and is messy.
Objectives
Unify problem size info
there are various places that one could get the size of the problem:
# from ocp.model
ocp.model.num_states
# ocp directly
ocp.num_dec
# and from ocp.dec_var_operator
ocp.dec_var_operator.num_dec

[ ] unify problem size info construction and retrieval #12

Unify stagevar and global var handling syntax
Stage and Global Variable handling very different, so requiring if/else a lot

for getting decision variable indices
for BoundConfig and ScaleConfig
[x] unify stagevar and global var handling #11

cleanup indexing methods
It makes sense to have unified methods for indexing the decision variables, eg "get me that decision variable (at a specific stage or not) from the decision variable array"

mostly in DecVarOperator
also some similar methods in Model
[x] clean up indexing methods #11

DecVarOperator uses a lot of jnp operations, can we replace them with normal np or lnp?

[x] clean up jnp ops in DecVarOperator #11

#Unify Sizing info
Methods in Model
    @property
    def num_inputs(self):
        return self.get_num_vars(group="inputs")

    @property
    def num_outputs(self):
        return self.get_num_vars(group="outputs")

    @property
    def num_residuals(self):
        return self.get_num_vars(group="residuals")

    @property
    def num_con_outputs(self):
        return self.get_num_vars(group="con_outputs")

    @property
    def num_implicit_res(self):
        return self.num_states + self.num_con_outputs + self.num_residuals

    @property
    def num_implicit_var(self):
        return sum([self.get_num_vars(g) for g in self._implicit_inputs])

    @property
    def num_states(self):
        return self.get_num_vars(group="states")

Methods in DecVarOperator
    @property
    def num_var_stage(self):
        return sum(self.get_stage_var_size(g) for g in self._stage_var_groups)

    @property
    def num_var_interval(self):
        return self.num_var_stage * self.num_stages_per_interval

    @property
    def num_stages(self):
        return self.num_intervals * (self.num_stages_per_interval - 1) + 1

    @property
    def num_all_stage_var(self):
        return self.num_stages * self.num_var_stage

    @property
    def num_global_var(self):
        return len(self._global_var_names)

    @property
    def num_dec(self):
        return self.num_all_stage_var + self.num_global_var

Methods in OCP
Most are piping directly attributes from either DecVarOperator or Model
    @property
    def num_stages(self):
        return self.dec_var_operator.num_stages

    @property
    def num_var_stage(self):
        return self.dec_var_operator.num_var_stage

    @property
    def num_var_interval(self):
        return self.dec_var_operator.num_var_interval

    @property
    def num_dec(self):
        return self.dec_var_operator.num_dec

    @property
    def num_con_stage(self):
        return self.model.num_implicit_res

    @property
    def num_con_interval(self):
        return self.model.num_states * self.transcription.num_constraints_per_interval

    @property
    def num_total_con_interval(self):
        return self.num_con_interval * self.num_intervals

    @property
    def num_total_con_stage(self):
        return self.num_con_stage * self.num_stages

Closing this issue for now; relatively happy with the unification of indexing methods; mildly acceptable for the unifying size info part, but don't have better ideas now and have other higher priority items to work on


✨ Add support for RequiresLastPushReview in Branch Protection for GitHub

closes https://github.com/ossf/scorecard/issues/2475
GitHub introduced a new branch protection setting called "Require approval of the most recent push". It seems to be retrievable only via an admin token.
Add support for RequiresLastPushReview in Branch Protection for GitHub repos

friendly ping for review.

@spencerschrock we're hitting rate limiting on e2e with the GITHUB_TOKEN. Has this been happening recently? I added scorecard run on PR a few days ago, and I wonder if this is the root cause of the problem.

@spencerschrock we're hitting rate limiting on e2e with the GITHUB_TOKEN. Has this been happening recently? I added scorecard run on PR a few days ago, and I wonder if this is the root cause of the problem.

Following up offline for more details. Likely an issue with which tokens we're using for our e2e tests and for criticality score @calebbrown fyi

#2478,  #2442, and possibly #2407, all increase token usage

Anyone has cycles to review this PR?

rate limiting hit :/


How to have server: done in vite setup of vinxi

I want to move this vite config to vinxi:
import { resolve } from "node:path"
import { defineConfig } from "vite"
import tsconfigPaths from "vite-tsconfig-paths"
import basicSsl from "@vitejs/plugin-basic-ssl"
import { readFileSync } from "node:fs"
import react from "@vitejs/plugin-react"
import { nodePolyfills } from "vite-plugin-node-polyfills"

const local = process.env.LOCAL === "true"

// https://vitejs.dev/config/
export default defineConfig({
	plugins: [
		// https://github.com/vitejs/vite/discussions/2785 (buffer needed to make ton apis work https://t.me/tonapitech/5193)
		nodePolyfills({
			include: ["path", "stream", "util"],
			exclude: ["http"],
			globals: {
				Buffer: true,
				global: true,
				process: true,
			},
			overrides: {
				fs: "memfs",
			},
			protocolImports: true,
		}),
		// Allows using React dev server along with building a React application with Vite.
		// https://npmjs.com/package/@vitejs/plugin-react-swc
		react(),
		// Allows using the compilerOptions.paths property in tsconfig.json.
		// https://www.npmjs.com/package/vite-tsconfig-paths
		tsconfigPaths(),
		// Allows using self-signed certificates to run the dev server using HTTPS.
		// In case, you have a trusted SSL certificate with a key, you could use the server.https
		// option not to proceed to the untrusted SSL certificate warning.
		// https://www.npmjs.com/package/@vitejs/plugin-basic-ssl
		// basicSsl({
		// 	certDir: resolve("certificates"),
		// 	domains: ["tma.internal"],
		// }),
		...(local !== true
			? [
					basicSsl({
						certDir: resolve("certificates"),
						domains: ["tma.internal"],
					}),
			  ]
			: []),
	],
	server: {
		host: "tma.internal",
		// Uncomment the next lines in case, you would like to run Vite dev server using HTTPS and in
		// case, you have trusted key and certificate. You retrieve your certificate and key
		// using mkcert.
		// Learn more: https://docs.telegram-mini-apps.com/platform/getting-app-link#mkcert
		// https: {
		// 	cert: readFileSync(resolve("certificates/tma.internal.pem")),
		// 	key: readFileSync(resolve("certificates/tma.internal-key.pem")),
		// },
		https:
			local === true
				? {
						cert: readFileSync(resolve("certificates/tma.internal.pem")),
						key: readFileSync(resolve("certificates/tma.internal-key.pem")),
				  }
				: undefined,
	},
	publicDir: "./public",
})

I thought below would work in vinxi:
import { defineConfig } from "@tanstack/start/config"
import tsConfigPaths from "vite-tsconfig-paths"
import { resolve } from "node:path"
import basicSsl from "@vitejs/plugin-basic-ssl"
import { readFileSync } from "node:fs"
import react from "@vitejs/plugin-react"
import { nodePolyfills } from "vite-plugin-node-polyfills"

const local = process.env.LOCAL === "true"

export default defineConfig({
  vite: {
    plugins: () => [
      nodePolyfills({
        include: ["path", "stream", "util"],
        exclude: ["http"],
        globals: {
          Buffer: true,
          global: true,
          process: true,
        },
        overrides: {
          fs: "memfs",
        },
        protocolImports: true,
      }),
      react(),
      tsConfigPaths({
        projects: ["./tsconfig.json"],
      }),
      ...(local !== true
        ? [
            basicSsl({
              certDir: resolve("certificates"),
              domains: ["tma.internal"],
            }),
          ]
        : []),
    ],
    server: {
      host: "tma.internal",
      https:
        local === true
          ? {
              cert: readFileSync(resolve("certificates/tma.internal.pem")),
              key: readFileSync(resolve("certificates/tma.internal-key.pem")),
            }
          : undefined,
    },
    publicDir: "./public",
  },
})

but it's complaining about:

not sure what I can do.

Someone on Discord said to do this:
import { defineConfig } from "@tanstack/start/config"
import tsConfigPaths from "vite-tsconfig-paths"
import { resolve } from "node:path"
import basicSsl from "@vitejs/plugin-basic-ssl"
import { readFileSync } from "node:fs"
import react from "@vitejs/plugin-react"
import { nodePolyfills } from "vite-plugin-node-polyfills"

const local = process.env.LOCAL === "true"

export default defineConfig({
  vite: {
    plugins: () => [
      nodePolyfills({
        include: ["path", "stream", "util"],
        exclude: ["http"],
        globals: {
          Buffer: true,
          global: true,
          process: true,
        },
        overrides: {
          fs: "memfs",
        },
        protocolImports: true,
      }),
      react(),
      tsConfigPaths({
        projects: ["./tsconfig.json"],
      }),
      ...(local !== true
        ? [
            basicSsl({
              certDir: resolve("certificates"),
              domains: ["tma.internal"],
            }),
          ]
        : []),
    ],
  },
  server: {
    host: "tma.internal",
    https:
      local === true
        ? {
            cert: readFileSync(resolve("certificates/tma.internal.pem")),
            key: readFileSync(resolve("certificates/tma.internal-key.pem")),
          }
        : undefined,
  },
  publicDir: "./public",
})

and that works but now I get a different error:


[APINotes] Remove VersionedInfoRole

When API notes were first added, they would defer to the header when something was explicitly specified---for example, if the API notes had one set of nullability annotations from before the header was audited. This behavior didn't make sense for versioned API notes, however, where annotations needed for Swift 3 compatibility were intended to override the unversioned information in both the API notes and the header itself.
Now that the versioning of API notes is well-established, simplify things by having the API notes always "win"; that is, an annotation in API notes will always override what's in the headers.
While here, remove the obsolete FactoryAsInit key from the API notes dictionary. This never had a good implementation with versioned API notes anyway.
Getting this into a release branch or 'stable' depends on apple/swift#6901 and apple/swift#6907.

Fixed!


Feature request--Why blade structural translational velocity (STVx) is always positive?

Dear all,
I have conducted aeroelastic simulation of NREL 5MW (fixed bottom) with aerodyn+beamdyn, and I am confused with why the x-component structural translational velocity (STVx) of the blade tip is always positive during a rotation:

As we know effected by the gravity, the blade will experience reciprocating motion, so the x-velocity of the blade tip should varies between negative and positive values.
Best regards,

Dear @ZL6462,
Presumably you are referring to the AeroDyn output BαNβSTVx.  You haven't stated which output node you are plotting, but I'm guessing this has to do with the orientation of the local blade coordinate system with which this output is reported in.  For example, if the x axis of the local blade coordinate system is directed toward the shaft by a small amount, the rotation of the rotor will result in continuously positive x velocity.  See the following figures in the online AeroDyn documentation for more information:
https://openfast.readthedocs.io/en/main/_images/aerodyn_blade_geom.png
https://openfast.readthedocs.io/en/main/source/user/aerodyn/appendix.html#ad-blade-local-cs
Best regards,


Make network manager global

Made game global attached network manger to game and made a getter method for it


add custom doc structure to allow for more lax semantics

This fixes #16 along with:

Writer panics when adding a document that should be a date / fast field.
Date fields being un-addable due to unsupported deserialization.

This also adds:

lax semantics, e.g. you can have a date field and add a document directly as either a u64 timestamp or via an rfc3339 formatted string.

I'm not sure how easy you want to make this - but if you are going to have your own parser, it might also help to east the restriction on document values being array. For example, if I have a schema of JSON documents I just want to index (ex. from a struct or another document database like mongo), currently I would have to reformat all my data to ensure the values are arrays (what I'm doing is making every field [T; 1]). The api could be made cleaner by allowing both arrays and bare values (that the document deserializer will convert to a Vec for tantivity).

I'm not sure how easy you want to make this - but if you are going to have your own parser, it might also help to east the restriction on document values being array. For example, if I have a schema of JSON documents I just want to index (ex. from a struct or another document database like mongo), currently I would have to reformat all my data to ensure the values are arrays (what I'm doing is making every field [T; 1]). The api could be made cleaner by allowing both arrays and bare values (that the document deserializer will convert to a Vec for tantivity).

True, since we're adding a new structure we might as well support multi and single value inserts to be a bit more user friendly.


Java code sample for custom synchronization

Can we get the equivalent Java code for the code samples on this page as well?

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 5feaa520-6f8a-6b30-7cd1-3a85593f758f
Version Independent ID: 2a121426-b973-fa0b-6a09-299193809723
Content: How to implement custom synchronization to optimize for higher availability and performance in Azure Cosmos DB
Content Source: articles/cosmos-db/how-to-custom-synchronization.md
Service: cosmos-db
GitHub Login: @rimman
Microsoft Alias: rimman

@fahdsiddiqui Thank you very much for request. We are currently investigating and will make an enhancement to the document as suggested.

Ack.  We will try to add this. thanks.

@fahdsiddiqui Thank you for making a document enhancement suggestion. This request has been created as a work item in DevOps. Furthermore, you are able to contribute to the documentation should you find a solution to this or other tutorials and samples that you would like to contribute. Please see: Microsoft Docs contributor guide overview (Link).
We will now proceed to close this thread. If there are further questions regarding this matter, please comment and we will gladly continue the discussion.


Add this school please

http://www.iv-lo.tarnow.pl/liceum2/

http://www.iv-lo.tarnow.pl/liceum2/

@LawyerN Please provide us with a proof, which shows that the school recognizes the domain you are submitting as an official email domain for the students.
You can provide us with any of the following:

A copy of instruction (a hard-copy or electronic one) given to you by the school that tells you to use an email address in this email domain
An URL of a page at the official school website that says that students use this email domain
A reference to a recognized journal where an article was published by someone from the school, with explicit affiliation to the school, and e-mail address from the email domain
A WHOIS data that link the email domain to the school somehow
A copy of official letter from the school representative saying that the school provides e-mail addresses in this domain to the students
Anything else that can prove this fact in similar way, i.e. can be verified independently.

@LawyerN You might miss my previous comment. Please react.

@LawyerN You might miss my previous comment. Please react.

Oh sorry, for now I am not able to provide any evidence or something because of the summer brake but when the school begins I will get necessary papers and I will write a request again

@LawyerN Thank you for letting me know. Thud, I have to close the request for now. Please reopen it or create a new one as soon as you have the update on the matter. Thank you!


Fix 'humanize' is not a registered tag library

Issue:
'humanize' is not a registered tag library. Must be one of:
Steps to reproduce:

Go to forum
Create a forum topic

We removed the forum.


Replace pkg_resources with importlib-metadata

Instead of using pkg_resources, please consider to use importlib-metadata

This error breaks my pre-commit hook.


add vikashkhairwal's file

add vikashkhairwal's file to master

approved chnages

add vikashkhairwal's file to master

approved the new changes


DOC: special: improving documentation on shifted Jacobi polynomials

Reference issue
Closes gh-18988
What does this implement/fix?
Instead of entering into a discussion of naming conventions which do not seem to be universal in this case, this PR proposes the following steps to clarify the documentation:

The explicit definition of $G^{(p,q)}_n$, which was already present for roots_sh_jacobi and sh_jacobi, is added to eval_sh_jacobi. In this way, it should be more obvious to the reader that here more is being done than just shifting Jacobi polynomials.
Information on constraints for p and q added for eval_sh_jacobi. This should draw the user's attention to the change in parameters. In this way, the documentation is also consistent with roots_sh_jacobi and sh_jacobi.
For roots_sh_jacobi, eval_sh_jacobi , and sh_jacobi, a remark is added to point out that there is a difference between shifted Jacobi polynomials and shifted Legendre and Chebyshev polynomials.

Thanks for the hint. I thought that I had added the reference but clearly the commits prove me wrong.


add build tag option to extract and add Args to interp.Options

This PR includes 2 small features I am working on:

Add a tag option in the extract program to optionally give an opportunity to tailor some packages in for example the stdlib, for people who is interested in keeping the final binary size as smaller as possible.

Below go generate
//go:generate ../cmd/extract/extract -name stdlib -tag stdmime mime mime/multipart mime/quotedprintable

produces a header to stdlib/mime-multipart.go
// Code generated by 'yaegi extract mime/multipart'. DO NOT EDIT.

// +build go1.16,!go1.17,stdmime

In some cases, we use many yaegi instances in one process, each interpreter will expect its own os.Args. This is done in interp.go as an option in interp.Options besides Stdin Stdout and Stderr.

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

closed in favour of #1277 and #1278


Adding actionability for "jump" action in vehicles

Describe your changes
This PR adds the option to enable "jump" action on vehicles ( sittable apps )
"jumpable" component can be added to the .metaversefile of vehicle apps
{
  "key" : "jumpable",
  "value" : true
},

The default value of this component is false
if you don't add this component/set it to false you can not jump when you're sitting on a vehicle, if you set "jumpable" to "true" : you should be able to jump when you're sitting on a vehicle and that automatically drops the vehicle
What are the steps for a QA tester to test this pull request?
Add the component that is mentioned above to a vehicle's metaversfile and set it to true/false and test to see if the gameplay matches.
Issue ticket number and link
Related : https://github.com/webaverse/app/pull/3524
Checklist before requesting a review

[x] I have performed a self-review of my code
[x] I am not adding any irrelevant code or assets
[x] I am only including the changes needed to implement the change
[x] I have playtested and intentionally tried to find error cases but couldn't

If these components are mutually exclusive, shouldn't it actually be one component like jumpBehavior?

Works fine. Also we should add this to the vehicles(mount, dragon) repos readme, in order to document it.

Its working fine on the jump action. Since we are not catering the fly action here, pressing 'f' drops the vehicle

Passing to @memelotsqui to review as part of actionsManager feature

This PR is waiting for @aryasalehi and @memelotsqui's review as part of actionsManager feature


ionic start not finishing build command when choosing sidemenu template

I just ran 3 test..by ionic start 3 different apps I determined that my issue only seems to pertain when I build with the sidemenu template.
for example when I run this..
ionic start myApp sidemenu --v2 --ts
The process never finishes...
Creating Ionic app in folder /Users/ahernandez/code/MOBILE_DEV/myApp based on sidemenu project
Downloading: https://github.com/driftyco/ionic2-app-base/archive/typescript.zip
[=============================]  100%  0.0s
Downloading: https://github.com/driftyco/ionic2-starter-sidemenu/archive/typescript.zip
[=============================]  100%  0.0s

I eventually Ctrl C out of the process and open up the app in my text editor but folders and dependencies are missing and I get such errors when I try to either...
ionic genera page and or ionic serve

WARN: ionic.config.js has been deprecated, you can remove it.
WARN: No node_modules directory found, do you need to run npm install?
WARN: ionic.config.js has been deprecated, you can remove it.

No ionic-angular package found, do you have Ionic installed? (CLI v2.0.0-beta.24)

Your system information:

Cordova CLI: 6.1.1
Ionic CLI Version: 2.0.0-beta.24
Ionic App Lib Version: 2.0.0-beta.14
ios-deploy version: 1.8.5
ios-sim version: 5.0.8
OS: Mac OS X El Capitan
Node Version: v5.10.1
Xcode version: Xcode 7.3 Build version 7D175

$ ionic serve
WARN: ionic.config.js has been deprecated, you can remove it.
WARN: No node_modules directory found, do you need to run npm install?
WARN: ionic.config.js has been deprecated, you can remove it.

Multiple addresses available.
Please select which address to use by entering its number from the list below:
 1) <IP_ADDRESS> (en1)
 2) localhost
Address Selection:  1
Selected address: <IP_ADDRESS>
"www" directory cannot be found. Please make sure the working directory is an Ionic project.
There was an error serving your Ionic application: "www" directory cannot be found. Please make sure the working directory is an Ionic project.

**Any ideas why sidemenu is not well liked? :D **
Thank you All

same for me

I have the same exact problem !!!
Additional noticed issues:
1:  The "app" folder is not created.
2:  In the temporary folder app/pages/list  --> it is missing the list.ts file.

@shotbyabel Try calling it with sudo... ionic start uses npminstall internally and when in Mac OS X you need it to be called by sudo. Worked for me but it has side effects: the project folder is created root owned, so you'll have to sudo others commands like ionic serve, etc.

Hey thanks for the issue, this should be fixed in beta.25, it was caused by an empty Sass file in sidemenu, which the unzip library we were using didn't like.


[BUG] Flashcard review order "random card from random deck" - make info in modal title useful

Describe the bug
From comment by @4Source https://github.com/st3v3nmw/obsidian-spaced-repetition/issues/814#issuecomment-1902236712.
The title information for the flashcard review modal has the format:
${deckName}: ${cardCount}
With:
${deckName} - The name of the deck of the currently shown card
${cardCount} - The count of cards remaining to be reviewed in this deck.
This is useful info for all review order modes, except for "random card from random deck".
Expected behavior
In this mode it is more useful to display:
deckName - the name of the deck chosen by the user (doesn't change as cards from different subdecks are shown)
descendantDeckCount - count of descendant decks under the deck chosen by the user. This being the remaining count, i.e. the count of descendant decks that have 1 or more remaining cards for review
totalCardCount - total number of cards remaining for review across the chosen deck and all descendant decks (I.e. not the count of cards remaining in the current randomly chosen deck).

What do you think about a Format
Title: ${deckName}: ${cardCount}
Subtitle: Subdecks: ${subdeckCount} | ${subdeckName}: ${subdeckCardCount}
deckName - the name of the deck chosen by the user (doesn't change as cards from different subdecks are shown)
cardCount - the total number of all cards in subdecks chosen by the user
subdeckCount - the number of all subdecks with remaining cards to review
subdeckName - the name of the subdeck from which the current reviewed card is
subdeckCardCount - the number of remaining cards of the subdeck from which the current reviewed card is

Something like that

When the lowest level of a deck is the selected one subdeckName and deckName would be the same that maybe a downside


Allow Shared Namespace Ownership for Projects

Checklist

[x] I've searched the issue queue to verify this is not a duplicate feature request.
[x] I've pasted the output of kargo version, if applicable.
[x] I've pasted logs, if applicable.

Proposed Feature
Allow the Project resource to share ownership of a Namespace by appending to the OwnerReferences instead of giving up.
Motivation
As a platform owner, I've already got a managed mechanism for creation of Namespaces.  This directly conflicts with the Project implementation in Kargo because Kargo will only adopt a namespace if the OwnerReferences field has no items in it.
Suggested Implementation
Add additional control flow to https://github.com/akuity/kargo/blob/33247fec02010a9fc28d392952f379cbf0f41397/internal/controller/management/projects/projects.go#L240-L254 to append to the OwnerReferences list if it's present.  This could potentially be gated by a boolean field on the Project resource, or a CLI flag for whichever Kargo controller implements this behavior, but the gate doesn't seem strictly necessary.
Additional Notes
I'm willing to toss a contribution for this if it'd be accepted.  I'll openly admit, I haven't tried Kargo yet, hoping to do so yet this week, but the current behavior is a potential blocker for my organization because we manage namespaces via an in-house controller that maintains ownership.

@isugimpy thanks for the suggestion. I can see how this is a problem for you.
The reason for the current behavior is that it is meant to prevent "hijacking" an existing namespace.
I'd love if we could do what you're suggesting, but I'm not sure yet how we could mitigate that risk.
Happy to hear your thoughts.

The concern is totally valid!  That's actually why I suggested a gate on the CR saying that Project is allowed to share ownership of the namespace, so that it isn't the default, but rather an opt-in behavior.  I could also be fine with a label or annotation on the namespace that is a cue to Kargo to accept that shared ownership model.  That may actually be safer, because then it's preventing an unprivileged user from doing something like creating a Project that could assume ownership of kube-system or something like that.

That's actually why I suggested a gate on the CR saying that Project is allowed to share ownership of the namespace, so that it isn't the default, but rather an opt-in behavior.

My concern there was that it only prevents an accidental hijacking and not an intentional one.

I could also be fine with a label or annotation on the namespace that is a cue to Kargo to accept that shared ownership model. That may actually be safer, because then it's preventing an unprivileged user from doing something like creating a Project that could assume ownership of kube-system or something like that.

I quite like this idea. It's actually what we do for Argo CD Applications as well. An annotation on an Application indicates consent for Kargo to interact with it, provided by someone who obviously had sufficient permission to add that annotation.

I'm willing to toss a contribution for this if it'd be accepted.

Given the revised approach -- we'd absolutely love to have you contribute that! Thank you!

Opened #1667 with the proposed solution!


OAK-11063:  introduced inference service

Experimental support has been added for an external inference service designed to enrich ES indexes with dense vectors. The ElasticIndexDefinition now includes an optional Inference configuration, which consists of one or more properties and queries. The properties define how the external service should enrich the index, while queries specify when and how those queries should be executed. Additionally, the Inference configuration is stored within the Index Metadata, acting as a "contract" between OAK and the external service. Importantly, the service does not require direct access to OAK; instead, it simply reads the index metadata to determine how to enrich the index.

Just a thought -
The time interval post which index would be scanned/updated by the external service is not being controlled by oak here - right ?
Could we do that ? Maybe even as part of the AsyncIndexerService - if it finds any diff to be indexed - it simply also pings the external service to add the vector enrichments ?
But if that would be too much frequent - maybe a separate service.

@nit0906 currently, the dependency between oak and the inference service happens at query time only.
Pinging the external service in the async indexer would create a dependency at index time too, that I would like to avoid.
The inference service support is marked as experimental for now. Let's see how it proceeds. If we realise something like is necessary, we can add it in the future.


Implement E2E key backup

Part of https://github.com/vector-im/riot-meta/issues/222

[x] Read the proposal doc for context
[x] Maybe read the associated Google doc if the proposal doc leaves anything unexplained
[x] Port everything from @dbkr's E2E backups js sdk branch
[ ] Port the placeholder UI from @dbkrs E2E backups react sdk branch
[x] Update iOS olm wrapper (https://github.com/vector-im/riot-ios/issues/1930)

Server branch: https://github.com/matrix-org/synapse/pull/4019 (merged now)

Part of https://github.com/vector-im/riot-meta/issues/222

[ ] Read the proposal doc for context
[ ] Maybe read the associated Google doc if the proposal doc leaves anything unexplained
[ ] Port everything from @dbkr's E2E backups js sdk branch
[ ] Port the placeholder UI from @dbkrs E2E backups react sdk branch

@nadonomy is working on the proper UX in parallel, so check whether he's produced any final E2E UX designs before getting started on the UI.

Closed because UI will be part of another issue.


Add a framework endpoint to upgrade SSTables node-by-node

This is a great feature, thanks for the submission!  Would you mind hiding this behind an opt-in feature flag?  As a somewhat advanced option, it's probably best left off by default.

@triclambert Gated the upgrade SSTable endpoint behind a configuration flag enable_upgrade_sstable_endpoint which is turned off by default.


Replicator: add support for non-frozen maps in inserts/updates

Fixes #20
Description:
Added support for the simplest collection type - maps in INSERT/UPDATE/DELETE statement.
Thank to great work done by @procrastinationfighter, the only thing needed was to write tests.

I think that the short description of the issue misguided you. Yes, adding, deleting or replacing the whole map works, but the whole point of non-frozen collections is that they can have their content modified (for example, look at the get_deleted_elements function in the CDCRow structure).
More info about non-frozen maps: https://docs.scylladb.com/using-scylla/cdc/cdc-advanced-types/#maps


chore: replace targetRef with targetRefs in doc

What type of PR is this?

What this PR does / why we need it:
Which issue(s) this PR fixes:

Fixes #

thanks @shawnh2 !
can you also update docs/ and v1.1/ :)

thanks @shawnh2 ! can you also update docs/ and v1.1/ :)

you should just update v1.1 and run make gen-check

updated


Serialize FixedSizeBinary as HEX with JSON Writer

Is your feature request related to a problem or challenge? Please describe what you are trying to do.

I would like to have FixedSizeBinary columns be serialized by the JSON writer as HEX, as they are for the CSV writer.
Describe the solution you'd like

Columns that are FixedSizeBinary be serialized as HEX strings. The CSV writer defaults to the default arrow-array formatter, which does this: https://github.com/apache/arrow-rs/blob/master/arrow-cast/src/display.rs#L746-L754
Describe alternatives you've considered

Alternatively, I could change my queries to potentially cast the column I am querying for, so this isn't a deal breaker for me, but I feel as though since the CSV and default formatters do this for me, the JSON should as well.
Additional context

The error returned originates from here: https://github.com/apache/arrow-rs/blob/master/arrow-json/src/writer/encoder.rs#L128

label_issue.py automatically added labels {'arrow'} from #5622


BLEU during evaluation in training phase different from inference

Hello!
I'm trying to calculate BLEU in two ways:

During evaluation in training, by passing dev set.
Using bin.infer with checkpoint (also in dev set).

I expect equal results, because checkpoint and dev sets are identical in 1. and 2..
But for some reason I've got very different results: 3.03 (train eval) vs 2.26 (inference).

I tried to dump hypothesis and reference files. I see that BLEU in train is right.
I'm thinking that there may be some issue with model initialization in infer mode, because model output  in train eval and model output in infer is different.

I am also facing a similar issue. While training BLEU and sample predictions are much better as compared to inference.

Looks like those are from training data so expected them to be better. https://github.com/google/seq2seq/blob/93c600a708a3fdd0473c3b3ce64122f3150bc4ef/seq2seq/training/hooks.py#L141

Evaluation during training are going in dev set. It is done by passing  --input_pipeline_dev.
Also evaluation is not going in training/hooks.py. It is going here: https://github.com/google/seq2seq/blob/master/seq2seq/metrics/metric_specs.py#L173
So there is no evaluation in training data.
  --input_pipeline_dev "
    class: ParallelTextInputPipeline
    params:
       source_files:
        - $DEV_SOURCES
       target_files:
        - $DEV_TARGETS" \

Isn't the evaluation done the same way as training, i.e. feeding all the target tokens to the decoder and comparing the prediction with the target?
Whereas inference is done by feeding the previous predicted token to the decoder in order to predict the next token.
If I am right, the difference between evaluation and inference makes sense.

@pooyadavoodi  I have also found this problem,  evaluation is actually doing: feeding all the target tokens to the decoder and comparing the prediction with the target.
I thinks this way of evaluation is like cheating, because when you do testing,  you are feeding the previous predicted token to the decoder.
So the evaluation score can not be used as the indicator of how well model is training. Why evaluation is implemented like this?

You are right. The seq2seq algorithm with encoder-decoder is a little different from typical classification algorithms. For both training and validation, prediction is done based on a given target (besides using the target to compute the loss), whereas in typical classification models, target is only used to compute the loss.
A true evaluation of a trained model can be done by inference and a BLEU score (not validation). In fact, I have seen models with very good validation perplexity which obtain bad BLEU score.

@pooyadavoodi
Evaluation and Inference  all use GreedyEmbeddingHelper, when decoding GreedyEmbeddingHelper sample for decoder's next_inputs (not ground truth)，the results should be same.

I am not familiar with this code, but doesn't this use the target sequences (ground truth) as an input to the decoder: https://github.com/google/seq2seq/blob/master/seq2seq/models/basic_seq2seq.py#L82-L83

It's _decode_train code.

Hello,
I'm trying to actually have an evaluation (during training) without the ground truth like does traininghelper but by sampling like greedyembeddinghelper.
Though doing so
   if self.mode == tf.contrib.learn.ModeKeys.INFER or self.mode == tf.contrib.learn.ModeKeys.EVAL:       return self._decode_infer(decoder, bridge, encoder_output, features,                                 labels)     else:       return self._decode_train(decoder, bridge, encoder_output, features,                                 labels)
return an InvalidArgumentError
tensorflow.python.framework.errors_impl.InvalidArgumentError: logits and labels must have the same first dimension, got logits shape [672,7063] and labels shape [1152]
Hard to know why it does that. Has anybody an idea ?


BUG only shows 1 Remote

Since last update (13 Jul 22׳) It shows only 1 remote (I had a few configed - and it worked great).
I re-confied everything and forced restart all hb services and clean all cache - it didn't fix.
Also added manually all remote IDs.
Please help me. Thank you

Can you please send logs to debug? Also please ensure you have v1.0.2. Version v1.0.1 had a bug that I just fixed

How can i send you logs without showing my device ID ?

Can confirm. The same error - only one AC remote added.
 [7/13/2022, 8:38:32 PM] [TuyaIR] {"result":{"access_token":"1****","expire_time":2793,"refresh_token":"****","uid":"****"},"success":true,"t":****,"tid":"****"} [7/13/2022, 8:38:32 PM] [TuyaIR] Login successful. [7/13/2022, 8:38:32 PM] [TuyaIR] Fetching configured remotes... [7/13/2022, 8:38:32 PM] [TuyaIR] Auto discovery of remotes enabled. Fetching with API... [7/13/2022, 8:38:32 PM] [homebridge-weather-plus] This plugin generated a warning from the characteristic 'Air Pressure': Characteristic not in required or optional characteristic section for service TemperatureSensor. Adding anyway.. See https://homebridge.io/w/JtMGR for more info. [7/13/2022, 8:38:32 PM] [TuyaIR] API returned 1 remotes... [7/13/2022, 8:38:32 PM] [TuyaIR] https://openapi.tuyaeu.com/v1.0/devices/bfb40d1f5ebcae38d0a1qm [7/13/2022, 8:38:32 PM] [TuyaIR] Adding new accessory: Air Conditioning AZ [7/13/2022, 8:38:32 PM] [TuyaIR] Removing 1 accessories as they are no longer configured... [7/13/2022, 8:38:32 PM] [TuyaIR] Trying to login... [7/13/2022, 8:38:32 PM] [TuyaIR] Logging in to the the server https://openapi.tuyaeu.com... [7/13/2022, 8:38:32 PM] [TuyaIR] {"url":"https://openapi.tuyaeu.com/v1.0/token?grant_type=1","headers":{"client_id":"***","sign":"*****","t":*****,"sign_method":"HMAC-SHA256","nonce":""}} [7/13/2022, 8:38:32 PM] [TuyaIR] {"result":{"access_token":"*****","expire_time":2792,"refresh_token":"*****","uid":"*****"},"success":true,"t":****,"tid":"*****"} [7/13/2022, 8:38:32 PM] [TuyaIR] Login successful. [7/13/2022, 8:38:32 PM] [TuyaIR] Fetching configured remotes... [7/13/2022, 8:38:32 PM] [TuyaIR] Auto discovery of remotes enabled. Fetching with API... [7/13/2022, 8:38:33 PM] [TuyaIR] API returned 1 remotes... [7/13/2022, 8:38:33 PM] [TuyaIR] https://openapi.tuyaeu.com/v1.0/devices/bf4cac522270fcf42d8u4q [7/13/2022, 8:38:33 PM] [TuyaIR] Restoring existing accessory from cache: Air Conditioning Space [7/13/2022, 8:38:33 PM] [TuyaIR] Removing 0 accessories as they are no longer configured...
So basically I have 2 remotes - the first returns Air Conditioning AZ and then clears it

restoring to 1.0.1 doesn't work

Changing the plugin mode to child bridge solves the problem

Are you using multiple Smart IR devices?

When restarting - it adds sometimes the ACs but only one is shown on homekit and it is not working with access denied error. After second restart al деру devices ale deleted. New restart again adds them all but still only one is visible in Apple Home and it doesn't react (works only on the side of homebridge)

The ACs appear in homebridge after several restarts, but they are not appearing AppleHomekit (only one of ACs is visible but with no answer error)

I found the bug. Fixing it. Should be release in an hour.

Fixed in release v1.0.4. Please give it a go.

Fixed in release v1.0.4. Please give it a go.

Accessories are now shown but controlling them does nothing...

Fixed in release v1.0.4. Please give it a go.

Accessories are now shown but controlling them does nothing...

Well, after restarting several times it works.... hope it will stay like this

There are fixes for DIY in v1.0.5 which should stablize problems. Please test and let me know.


As a CIF user, I want to see the differences on budgets calculated fields since the last revision, so that I can focus on what did change

Description:
Calculated fields are handled by computed columns, which our current diff logic can't display. For example, diff for calculated gross, net and holdback amounts for a milestone isn't shown on the summary page (page with red/black strikeout). This is likely because the calculated values are not actually part of the schema.
This card is about implementing diffs for the budgets form. The calculated values on the budgets form are:

Proponent's Share Percentage
Anticipated Funding Amount Per Fiscal Year
Total Project Value
Total Net Payment Amount to Date
Total Gross Payment Amount to Date
Total Holdback Amount to Date
Total Eligible Expenses to Date
Total Payment Amount to Date (IA)

Note: this Issue is about showing the difference between the values a user has just typed into a form and the values in the previous form change. Pulling in the third diff of latest committed revision is a separate card.
Acceptance Criteria:
Given I have added enough values to complete the calculation for the first time
When I view the summary page
Then the diff displays the newly calculated value
Given I have changed values that affect the calculated value
When I view the summary page
Then the diff displays changed values properly for calculated values
Given I have removed enough values to prevent the calculation
When I view the summary page
Then the diff displays removed calculated values properly
Development Checklist:

[ ] Any front-end calculated values are refactored into computed_columns:

[ ] calculatedProponentsSharePercentage

[ ] Refactor calculations that are on project_revision to be on form_change instead (this will also make the calculation dynamic)

[ ] project_revision_anticipated_funding_amount_per_fiscal_year

[ ] project_revision_gross_payment_amount

[ ] project_revision_net_payment_amount

[ ] project_revision_total_project_value

[ ] Query the previously calculated values under formChangeByPreviousFormChangeId
[ ] Pass the previously calculated value to CustomDiffFields via formContext.oldData
[ ] Pass the current calculated value to CustomDiffFields. Multiple ways to do this: synthetically update the value on the summary page before passing, in CustomDiffFields grab the values out of formContext, etc.
[ ] Meets the DOD

Definition of Ready (Note: If any of these points are not applicable, mark N/A)

[x] User story is included
[x] User role and type are identified
[x] Acceptance criteria are included
[na] Wireframes are included (if required)
[ ] Design / Solution is accepted by Product Owner
[x] Dependencies are identified (technical, business, regulatory/policy)
[ ] Story has been estimated (under 13 pts)

·Definition of Done (Note: If any of these points are not applicable, mark N/A)

[ ] Acceptance criteria are tested by the CI pipeline
[ ] UI meets accessibility requirements
[ ] Configuration changes are documented, documentation and designs are updated
[ ] Passes code peer-review
[ ] Passes QA of Acceptance Criteria with verification in Dev and Test
[ ] Ticket is ready to be merged to main branch
[ ] Can be demoed in Sprint Review
[ ] Bugs or future work cards are identified and created
[ ] Reviewed and approved by Product Owner

Notes:

Hey team! Please add your planning poker estimate with Zenhub @dleard @gurjmatharu @JoshLarouche @mikevespi @pbastia @sam-warren @Sepehr-Sobhani @tmastrom

Backlog refinement Apr 25: This one should be estimated considering that #1231 should already be completed.

project_revision_gross_payment_amount is actually on milestones, not budgets, so will be handled here instead: https://app.zenhub.com/workspaces/climate-action-secretariat-60ca4121764d710011481ca2/issues/gh/bcgov/cas-cif/1616

Anticipated Funding by Fiscal Year is a "string" field type but is actually an array (we made it string rather than array to accommodate the design). We'll need a case to address array diffs in CustomDiffFields.tsx's StringDiff.

The easiest way to show the diffs for anticipated funding per fiscal year was to change them to an array field so they work the same as additional funding sources. Everything looks the same on the editable pages, but for view/read-only, I used the generic ReadOnlyArrayField template so these anticipated funding per fiscal year looks slightly different than before. I can make a custom readonly array field template for anticipated funding per fiscal year if desired.

I can see all the diffs! Thank you @BCerki !


Feature Request: Authentication in SwaggerUI

Hi yuka1984,
is it possible to integrate authentication into the SwaggerUI?
See Swagger documentation here:
https://swagger.io/docs/specification/authentication/
Kind regards

@stephanruhland
#43 should address this for you, feel free to checkout my fork. The link you have provided is for openapi 3.0 which is not supported by the current swashbuckle version (4.x) used in this repo, it should work fine with openapi 2.0 standard.


Fix 3rd NAFTA Slide so that whitespace is not present in graph.

Fixed issue, each slide has a legend and should render in a better format.


Docked Composer: Add component

Component Spec: https://lightningdesignsystem.com/components/docked-composer/

@garygong Are you all using the SLDS Docked Composer or are you all needing a generic "docked assistant"/"docked utility modal"
I have a team interested in a generic lower right of the screen, minimize-able modal, but the content is not anything like the Docked Composer and I wanted to check to see if we wanted to "gut the contents" and just use an onRender prop in the examples for the composer aspect of it.
@pulkonet What do you think?

In the concrete, this would be something like renaming to DockedPopover and composer could be a variant if needed. I haven't got that far into the details.

Yes, I agree.  After looking at the spec again, it looks like the component is already described in terms of a shell, with the consumer providing the contents.

@interactivellama I was following the specs from SLDS and found it to be a shell just as Gary mentioned above. I have raised a draft PR and I am adding the props proposal in a while.


Document internal structure of the Stores App

Document needs to include:

Which repositories are involved
Relevant flows
Service offered (API, locale view, completion)


Feature: add drag functionality like figma

Let me start by saying this project is amazing, thanks a lot for doing this!!
Figma and other design tools provide drag functionality when holding space. People who are familiar with Figma would likely expect such functionality, so I tried to add a similar experience to this component.

the highlight in the clicks is only an effect in the recording, to show when the click action happened.

Thanks!


[ENG-866] feat: Add Calendly connector

Checklist

[x] Ran Linter
[x] Catalog tests passing
[x] Created PR from non-main branch

Catalog variables
None
Notes
Testing
GET
URL: http://localhost:4444/user/me
Describes the requester user

URL: http://localhost:4444/organizations/
Describes organization

POST
URL: http://localhost:4444/organizations//invitations
Invite user to organisation with email.

DELETE
URL: http://localhost:4444/organization_memberships/
Remove member from org. No content response

Pagination
GET
URL: http://localhost:4444/organizations//invitations
Lists user invitations to the org. Empty response

URL: http://localhost:4444/organization_memberships/?organisation=
Lists all users that belong to org. No pagination limit.

First page
Lists all users that belong to org. Page limit 1.

Next page
Lists all users that belong to org.

@RajatPawar please take a look


Reference name generation based on filename including uppercase characters

Hi there,
1st of all, thank you for providing this plugin!
I found following behavior: Given a filename "Materialicons-regular.ttf" results in a reference name "_aterialicons_regular_ttf".
This happens in .replace(/[^a-z0-9_]+/g, '_') which should support A-Z as well or include the "i" flag. Afterwards, the filename should be changed to lower case:
const fileBasename = match[3]
                    .split('/')
                    .pop()
                    .split('.')
                    .shift()
                    .replace(/[^a-z0-9_]+/gi, '_')
                    .toLowerCase();

Regards, Sven

Hi Sven - and first of all thanks for contributing and sorry for the delay!
Just to understand you right:
Materialicons-regular.ttf should be turned into materialicons_regular_ttf, right?
So wouldn't it make sense to convert to lowercase first, and then do the regex? (Just asking so I don't have it wrong in my mind).

Hi Peter,
no problem! :)
Yes, you are correct. Doing the .toLowerCase() first would solve the problem as well.
Regards, Sven

Ah, perfect - so I was on the right track.
Looks great, I'd say it's your honor to increase the package version to 1.0.5 then ;)


Update the documentation

Please Update the documentation regarding these:

There is no documentation about excluded_clients that I came across when i tried to delete cookie & sent the GET request again, it didn't mark it as another valid user rather put it in excluded clients.
Please explain this.

Is there an interactive dashboard. Is the experiments.json the only way to see all the info about the clients.
Note: I'm using php version of sixpack

Regarding the dashboard, https://github.com/seatgeek/sixpack#dashboard

@josegonzalez Dashboard working.. looks like I had a permission issue..
What about the excluded_client ?

Can i change the traffic fraction on the fly with dashboard?looks like we can just make it winner i.e 100%... If i want to chamge the fraction, do i have to make another build & puah it to prod with the changed fraction ??

@josegonzalez  What is the tracking_fraction order ? if i send alternatives as ['new','old'] is it the traffic fraction of new ?

traffic_fraction Is for whether or not the traffic is allowed to select an alternative or whether it must be in the control. For instance, you may only want to send a percentage of traffic through the ab test, and that is what that option is for. We do not implement weighted alternatives at this time.


Where to report the filename and line number in JUnit?

The JUnit spec doesn't mention file name and line number where an error occurred (eg. as attributes of failure).
Since this action seems to display annotations inline with the PR files changed (i.e. the diff), how can one provide the file name and line number where an error was detected (for example by a linter program).

You are right, file name and line number is not part of any of the unofficial specs.
However, some test tools use file and line in <testcase> for this (e.g. pytest):
https://github.com/EnricoMi/publish-unit-test-result-action/blob/43acb3d1372c257f97cc780bee85a17cbaf9d46e/python/test/files/junit-xml/pytest/junit.fail.xml#L5-L6
Note: this is not the line where an error (test failure) occurred but where the failing test is defined.

@EnricoMi thanks very much for the reply. Unfortunately, as you mention, this is defined in the testcase element and not in the failure one, which makes it hard to implement the usecase I have, which is to have a single test case with multiple failures, sort of like this:
<?xml version="1.0" encoding="utf-8"?>
<testsuites tests="1" failures="5" errors="0" skipped="0" time="0.0">
        <testsuite name="Compliance" tests="1" errors="0" failures="5" skipped="0" time="0">
                <testcase name="Checkpatch" classname="Guidelines">
                        <failure message="subsys/bluetooth/host/hci_core.c:269  do not use C99 // comments" type="error">
C99_COMMENTS: do not use C99 // comments
File:subsys/bluetooth/host/hci_core.c
Line:269</failure>
                        <failure message="subsys/bluetooth/host/hci_core.c:270  that open brace { should be on the previous line" type="error">
OPEN_BRACE: that open brace { should be on the previous line
File:subsys/bluetooth/host/hci_core.c
Line:270</failure>
                        <failure message="subsys/bluetooth/host/hci_core.c:275  space prohibited between function name and open parenthesis '('" type="warning">
SPACING: space prohibited between function name and open parenthesis '('
File:subsys/bluetooth/host/hci_core.c
Line:275</failure>
                </testcase>
        </testsuite>
</testsuites>

This is a usecase that seems to be supported by the JUnit/xunit spec.
See https://github.com/pytest-dev/pytest/issues/5891
which then links to:
https://github.com/jenkinsci/xunit-plugin/blob/ce58c5eb1db91d0d181935889a20cc42d2697b03/src/main/resources/org/jenkinsci/plugins/xunit/types/model/xsd/junit-10.xsd#L85-L105
or
https://github.com/pytest-dev/pytest/blob/f54ec30a6d7969eba6a2003b4409d33828cd406d/testing/example_scripts/junit-10.xsd#L88-L98
Which seems to allow multiple failures in a single testcase.

I think multiple failures should work with the action. When the messages are different, it should show multiple failures for the same testcase.
Have you tried above file with the action?

I think multiple failures should work with the action. When the messages are different, it should show multiple failures for the same testcase.

That's excellent to hear, but the problem is the filename/line number in each failure (hence the original question in this thread). I would need a way to convey to your action that the failure includes this "metadata" so it can place the GitHub annotations correctly as per GitHub's format. Each failure would match to an error/warning. I am currently doing this sort of manually in the action that handles this today:
I store the failures in a "special" class that derives from junitparser.Failure:
https://github.com/zephyrproject-rtos/zephyr/blob/main/scripts/ci/check_compliance.py#L161-L169
and then print those as GitHub annotations:
https://github.com/zephyrproject-rtos/zephyr/blob/main/scripts/ci/check_compliance.py#L1114-L1121

Have you tried above file with the action?

No, I haven't yet, but it's great to know it should work, thanks!

Nothing stops you from adding attributes to the <failure> tags:
<testcase name="Checkpatch" classname="Guidelines">
  <failure file="subsys/bluetooth/host/hci_core.c" line="269" message="do not use C99 // comments" type="error">
C99_COMMENTS: do not use C99 // comments
File:subsys/bluetooth/host/hci_core.c
Line:269</failure>
</testcase>

And then extend this section of junit.py:
https://github.com/EnricoMi/publish-unit-test-result-action/blob/71ca27c4a9d74fa7ec2898304ee75909e4a57124/python/publish/junit.py#L219-L240
It looks like this action "supports" multiple failures per testcase by picking the most severe, and from those the first only. So your use case (multiple results per test case) is not fully supported.
What you want here is to create one UnitTestCase per result in case.result. Then, get_result, get_message, and get_content are not needed anymore:
        result=get_result(results),
        message=get_message(results),
        content=get_content(results),

Finally,
        test_file=case._elem.get('file'),
        line=int_opt(case._elem.get('line')),

has to use the file and line from result if it exists, and fall back to case if not.
Except for the last step, this looks required to fully support the spec.
But I am hesitating to do the last bit as that is a bespoke JUnit XML spec.

@carlescufi have you continued to work on this?


'spawn UNKNOWN' Error Executing TestCafe With Custom Test Runner Class in Windows

Are you requesting a feature or reporting a bug?
Bug
What is your Test Scenario?
Using a custom test runner via 'createRunner()' written in TypeScript and executing the test scenarios on a Windows 10 and Windows 7 machine, run any tests against Chrome or Firefox.
What is the Current behavior?
When the runner starts, and either 'chrome' or 'firefox' are passed into the runner's 'browsers()' function, an error appears and I am unable to run the tests.

What is the Expected behavior?
The browser should open up at the tests should begin to execute. We are able to execute TestCafe tests on Windows using the CLI for Chrome and Firefox without issue, and this issue with the custom test runner does not occur at all on our Macs.
How would you reproduce the current behavior (if this is a bug)?
Simply execute the NPM script 'test' with npm run test or yarn run test, while having Chrome or Firefox installed. See Git repo link below along with README.
Provide the test code and the tested page URL (if applicable)
https://github.com/calisven/TestCafeWindowsBug

Your Environment details:

testcafe version: 1.1.4
node.js version: 10.16.3
command-line arguments:  yarn run test or npm run test
browser name and version: Chrome 76.0.3809.132
platform and version: Windows 10
other: Please see the Git repo's README. We are able to reproduce this issue with Firefox as well, but the Test Runner class works fine with IE or Edge. Please see 'runner.ts' for implementation details.

Thank you for the detailed example. I have reproduced this behavior.

We will research it and provide a solution.

Pulled your alpha build and confirmed that the changes fixed the issue - thank you!


Add more unit test cases for sharding-core-preprocessor module

sharding-core-preprocessor module is decouple with Sharding & encrypt. The codes has already stable.
Should Add more unit test cases for this module.

I will try to do this.

The test coverage it enough, thank you.


Error after closing main window

Describe the bug
If I open container desktop and then close the window immediately, I get a popup window with "A JavaScript error occurred in the main process":
Uncaught Exception:
TypeError: Object has been destroyed
at Timeout._onTimeout (/Applications/container-desktop.app/Contents/Resources/app.asar/packages/main/dist/index.cjs:1:1973)
at listOnTimeout (node:internal/timers:557:17)
at processTimers (node:internal/timers:500:7)

To Reproduce
Steps to reproduce the behavior:

Launch container-desktop.
Click on the red X to close the window.
Wait 3-4s and notice the popup.

Desktop (please complete the following information):

OS: MacOS
Browser: Safari
Version: 12.2.1

@deboer-tim it might be fixed now that we're hiding the Window (implementation of https://github.com/containers/desktop/issues/24)
It you could check with a recent build. Thanks.


How to increase size of touch area of each dot?

How to increase size of touch area of each dot?
Because i can't able to touch properly.
Please suggest me some solution.

Hi @jasmit34 ,
Usually, page control is used to display the current state of the scroll. Dots have too small tap area.
You can check the way how tap gestures over page control are used in iOS (Home screen).  When you tap anywhere on the right side from active page dot, then you scroll to the next page, otherwise, scroll to the previous.


Added slightly modified bundled wire textures with 'proper' wire management

This is my programmer art take on the bundled wire textures, with slight shading and 'proper' wire management in all cases it was possible. I am undecided if I like this look better than the cool looking squares at every intersection. shrug
I don't know if you have a CLA, but either way since these are merely small modifications to the current textures: You have rights to use my modified textures in whatever way you see fit regarding this project. This includes but is not limited to, using them, not using them, and changing them.

In-game screenshots:

Closing because the new textures / new rendering look better.

(Somewhat inspired by yours. Thanks!)
2015-12-09 18:35 GMT+01:00 adudney<EMAIL_ADDRESS>
Closed #13 https://github.com/asiekierka/CharsetMC/pull/13.
—
Reply to this email directly or view it on GitHub
https://github.com/asiekierka/CharsetMC/pull/13#event-487203546.


What software are you using for the UML diagrams?

What software are you using for the UML diagrams?
Thank you for this resource! It's awesome!!!!

The UML diagrams are generated by PHPStorm and exported to SVG and PNG.
You are welcome, glad you like it :)

Thanks! :)


Add doc build status badge

https://docs.readthedocs.io/en/stable/badges.html

Thank you for doing this!


First step in plumbing BigCollections through to the PEC.

Initiating a streamed read creates a Cursor object on the host side that is mirrored inside the PEC, but the API calls for reading the stream are mediated via the BigCollection/Handle pair and the Cursor itself is
tracked by the BigCollection instance. This is to avoid using the API channel "Thing" tracking, which never releases objects once mapped.

Though, would we be better just to implement cleanup for thing tracking? That's going to be required anyway as you pointed out the other day.

Swoit, merge away!


RAM versions of MySQL - reopened

We are also in need of a RAM equivalent. Tried running our pipeline without and does not function.
Existing closed issue: https://github.com/CircleCI-Public/cimg-mysql/issues/7

RAM variants of database images aren't supported and there is currently no plan to do so right now.


JCGM 100:2008 (EN): Generating subclause titles (continues #112)

In case of annexes and Terms and Definitions clause, subclause titles are written below their corresponding numbers in the original document.
Original:

Generated:

First issue: inherit ISO formatting for term headers in HTML.
Second issue: Appendix 2 also contains terms. This is not expected in ISO or BIPM, and the terms are not being recognised as such.

Made Appendixes 2 and 3 terms sections be recognised as terms sections, by inserting [heading=terms] markup.
Standoc is constrained to recognise terms sections only at top level, and only once. Relaxing that in BIPM.


Decompiled strings.xml is invalid

Using apktool 2.0.3, decompile com.google.android.apps.docs.editors.slides (version 60521040).
In the output directory, res/values/strings.xml contains the following in line 808:
<string name="document_info_panel_path">On <g example="My device (Nexus 4) > foo > bar\" id=\"document_info_panel_path\">%1$s</g></string>
This is invalid XML and the expected result is either:
<string name="document_info_panel_path">On <g example=\"My device (Nexus 4) > foo > bar\" id=\"document_info_panel_path\">%1$s</g<</string>
or:
<string name="document_info_panel_path">On <g example="My device (Nexus 4) > foo > bar" id="document_info_panel_path">%1$s</g></string>
Now, this may be similar to Issue 859, but this APK is coming from Google themselves, which makes me doubtful that it's an issue of non-standard coding and mentioned in that issue.
Note that this issue exists throughout the file and is inconsistent:

Line 914: <string name="empty_doclist_for_pinned_view_details_can_edit">"Tap \"Available offline\" in a file's menu so you can keep working on it offline."</string> (escaped quotes vs. unescaped quotes)
Line 1369: <string name="navigation_search_results">Search: \"<g example="Cruise" id="searchTerm">%s</g>\"</string> (no escaping except around xml element)
Line 2420: <string name="template_list_brand_link">" by <a href=\""<g example="http://billnye.com/" id="brand_name">%2$s</g>\"><g example="Bill Nye, The Science Guy" id="brand_name">%1$s</g>"</a> "</string> (wat)

It's all very strange and I'd love to hear what you think.
Thanks for taking the time and for the great tool! :+1:

I'll have to build some unit-tests using these values, because I'm not sure why values weren't escaped or converted at all.

Thanks! The APK upload expires in a week, so if you need me to re-upload it at any point, please let me know.

I've got the apk already, just a little hard to effectively debug a file as large as google applications. Once I create the unit-tests that replicate the behavior, it'll be a lot easier to investigate.

I've got several apks where apktool 2.3.0 produces strings.xml files without well-formed xml.
There are basically unbalanced html-tags as content of a string tag interspersed with quoted strings.
  <string name="welcome">" ...
..."hallo"...
..."</string>


When using the SDN only can one to one to inject the entities to the MVC  container?

When  I using the SDN's Java-config to configure the "org.neo4j.ogm.session.SessionFactory" to scan the doman packages and expect to inject the  entities to the mvc container,then come out a big error "Caused by: java.lang.ClassNotFoundException: org.neo4j.ogm.drivers.embedded.driver.EmbeddedDriver"!This is why?Thanks!

Thanks,I knowed it and got it! I just using the external ogm driver on produce enviroment ,the embedded ogm driver in the test scope.If I choose the embedded ogm driver , I have to give up the spring boot's auto configuration and  need to config it by myself.
Actually in the meantime , I also try to using the JAVA general type to define a relationship entity which means not specific to appoint the start node entity or the end node entity, only when using it to specify the actually the start node entity and the end entity!
In the near future,Can we the NEO4J to support this character?
Thanks a lot! Looking forward to your answer!

Hi.
You don't loose any auto configuration by using the embedded driver.
Find attached project:
gh550.zip
Core take aways
In pom.xml, add
<dependency>
    <groupId>org.neo4j</groupId>
    <artifactId>neo4j-ogm-embedded-driver</artifactId>
</dependency>

You don't need a version, this is managed by Spring Boot.
Also add
<dependency>
	<groupId>org.neo4j</groupId>
	<artifactId>neo4j</artifactId>
	<version>3.5.0</version>
	<scope>runtime</scope>
</dependency>

This is the database itself. This is not managed by Spring Boot because of the different licenses.
Than a simple domain in package com.example.gh550.domain to show you the usage of everything.
Works out of the box, you don't need to configure anything else.