[Spark functions] sort_array throws an exception only in simplified path

Description
sort_array throws an exception only in simplified path for the following sql:
element_at(sort_array(array_intersect("c0",array_sort("c1")),isnotnull(0.12167786876671016)),"c2")
my initial guess was that the expression "isnotnull(0.12167786876671016)" is being folded in common path and converted to a constant but not in simplified which turned out to be true. #3983 should fix this, however the error string was a bit unusual, so I dug a bit more and learnt that there was a check in its implementation where if enforced a condition that the input should be a constant bool vector. This resulted in the aforementioned expression not being considered as a constant without folding which resulted in the error.
We should consider whether a pre-condition like this should be allowed in the expression framework. If yes, then we need a proper mechanism to enforce this rather than adding a check in the implementation.
https://github.com/facebookincubator/velox/blob/11aa902ba03258762b35b9a8b6d586b6d482b35f/velox/functions/sparksql/ArraySort.cpp#L271
Error Reproduction
run spark fuzzer with : --velox_fuzzer_enable_complex_types --enable_variadic_signatures --only="sort_array,array_intersect,array_sort,isnotnull"
Relevant logs
libc++abi: terminating with uncaught exception of type facebook::velox::VeloxUserError: Exception: VeloxUserError
Error Source: USER
Error Code: INVALID_ARGUMENT
Reason: sort_array requires a constant bool as the second argument.
Retriable: False
Function: makeSortArray
File: /Users/bikramjeet/dev/velox/velox/functions/sparksql/ArraySort.cpp
Line: 273
Stack trace:
Stack trace has been disabled.Use --velox_exception_user_stacktrace=true to enable it.

How can we handle this? Spark will throw exception for this case.
spark-sql> SELECT sort_array(array('b', 'd', null, 'c', 'a'), true);
[null,"a","b","c","d"]
Time taken: 3.499 seconds, Fetched 1 row(s)
spark-sql> SELECT sort_array(array('b', 'd', null, 'c', 'a'), isnull(111));
Error in query: cannot resolve 'sort_array(array('b', 'd', CAST(NULL AS STRING), 'c', 'a'), (111 IS NULL))' due to data type mismatch: Sort order in second argument requires a boolean literal.; line 1 pos 7;
'Project [unresolvedalias(sort_array(array(b, d, cast(null as string), c, a), isnull(111)), None)]
+- OneRowRelation

spark-sql> select isnull(1);
false
Time taken: 0.967 seconds, Fetched 1 row(s)

Can we use more accurate function signature to support function argument constant bool, not just bool?
Then we will not generate this case in fuzzer test.

Do you have some suggestions? @mbasmanova

It looks like we do need to provide a way to mark an argument as constant in the function signature and use this information when generating expressions in the Fuzzer. @jinchengchenghh Would you like to help design this enhancement?

My partner @duanmeng https://github.com/facebookincubator/velox/pulls?q=is%3Apr+author%3Aduanmeng is willing to design and implement this enhancement. Would you like him to participate?

@duanmeng Moving a discussion from https://github.com/facebookincubator/velox/issues/4140#issuecomment-1449399353 to avoid mixing multiple things together.

PS: I reproduced the bug mentioned in https://github.com/facebookincubator/velox/issues/3993 , which is caused by no constant folding in the simplified eval, and it can be fixed by https://github.com/facebookincubator/velox/pull/3983. I patched the diff in https://github.com/facebookincubator/velox/pull/3983 and the test succeeded.

I think this is a bit more complicated. At a high level, constant folding is an optimization that may affect performance, but shouldn't affect the results. Hence, it is preferable to keep constant folding disabled in the simplified path.
That said constant folding sometimes allows to short circuit evaluation which could mask errors that would happen if constant folding didn't occur. Consider expression f(g(a), h(b), c), where h(b) is constant foldable and folds to null. If 'f' has default null behavior, then evaluation of f can be skipped entirely and we can return all nulls. If constant folding didn't happen we would proceed to evaluate f's argument and call g(a) which may throw an exception. If we hold on to that exception and proceed to evaluate h(b) we may discover that h(b) evaluates to null on all rows where g(a) throws an error. In this case we could ignore g(a) errors and return a null. In other words order of evaluation of function arguments matters and constant folding may introduce different order (e.g. some of the last arguments may get "evaluated" to null before earlier arguments).
Similar case applies to an optimization that checks if any inputs to default-null-behavior function are null and short-circuits evaluation by returning a null. Let's consider f(g(a), h(b), c) expression again. If 'b' is null and f and h have default-null-behavior, we can skip evaluation entirely and return a null. However, if 'b' is not null, we proceed to evaluate g(a) which may throw. If we hold on to the exception and continue to evaluating h(b) we may discover that h(b) evaluates to null on all rows where g(a) throws an error. In this case we could ignore g(a) errors and return a null. If for example, f(g(a), h(b), c) expression was decomposed into 2 expressions: h(b) -> h followed by f(g(a), h, c) we would then notice that 'h' is null before evaluating g(a) and return null without any evaluation.
It is confusing to users when result of an expression depends on whether a particular execution optimization is enabled or not. Hence, we need to make sure that results are the same no matter which optimizations (if any) are enabled.
To achieve this we need to make sure that function evaluation result does not depend on the order in which its arguments are evaluated. This is already the case for AND / OR special forms. ConjunctExpr::evalSpecialForm evaluates all conjuncts and holds on to errors to see if these can be masked by subsequent conjuncts. We need to implement similar logic for regular function evaluation. Hold on to errors to see if subsequent argument evaluates to null for the failing row.
There is a prototype of this functionality in #3189
CC: @bikramSingh91 @kagamiori

Can we close this issue? It should have been fixed by constant signature support. @bikramSingh91


Unable to load camera's snapshot

Try to make the card show a static image of the camera's snapshot, but got this error:
The image could not be loaded. [Check troubleshooting](https://github.com/dermotduffy/frigate-hass-card#troubleshooting).
{
  "mode": "url",
  "url": "https://admin:XXXX@i192.168.XX.XX/cgi-bin/snapshot.cgi?1",
  "refresh_seconds": 1
}

What I intend to do is make the card show a static image of the camera's snapshot before the live view is ready to view (usually takes a longer time to load under low internet speed). It seems that the card is unable to accept the url without the file type, even though I have checked it with multiple browsers and it works.
Checklist:

[x] I updated to the latest version available
[X] I cleared the cache of my browser

It seems that the card is unable to accept the url without the file type, even though I have checked it with multiple browsers and it works.

This error is shown if the browser fails to load the provided URL. Are you sure the URL works exactly as written in the card config, in another browser window?

It seems that the card is unable to accept the url without the file type

Can you clarify what you mean by file type here?

What I intend to do is make the card show a static image of the camera's snapshot before the live view is ready to view

This is actually a native feature offered by the card, try the show_image_during_load option. No need to set the URL yourself, the card will try to get it from HA as long as you are setting a camera entity. If you are using the visual editor, it's the option near the bottom under Live:

Are you sure the URL works exactly as written in the card config, in another browser window?
Yes, It works on multiple works using the same exact url that is in the config.

Can you clarify what you mean by file type here?
By file type, I mean the url has to end with .jpg etc.

This is actually a native feature offered by the card, try the show_image_during_load option. No need to set the URL yourself, the card will try to get it from HA as long as you are setting a camera entity. If you are using the visual editor, it's the option near the bottom under Live:

Yeap, I am aware of this feature, but as I am unsure if the static image is working, I have temporarily put it to show the static image only just for testing.

Have you managed to test it with url similar to the one I have above, that doesn't end with .jpg, .png etc.

Yes, It works on multiple works using the same exact url that is in the config.

Ah. I think I know what's happening. Your browser is rejecting the image URL for security reasons, as this is cross-origin image request and it will not allow you to pass credentials when it is sourced from a script. If you take that same URL, and put it into a Home Assistant Picture Glance card -- I bet you will see exactly the same behavior.
There is no way around this [unless you own and can configure the webserver, which you ~cannot do when it's a camera].
I think the right thing is for me to add a README entry explaining this limitation.

Yeap, I am aware of this feature, but as I am unsure if the static image is working, I have temporarily put it to show the static image only just for testing.

Does it load instantly? It's working :-) You could also use developer tools to inspect the element and verify it's a <img> tag.

I've updated the README, and I don't think there's anything left to do here (as this is effectively a browser restriction). Please re-open if you see otherwise. Thank you!


⚠ Thumbnails API Endpoint has degraded performance

In 881738a, Thumbnails API Endpoint (https://thumbnails.roblox.com/v1/assets?assetIds=82738847&format=Png&isCircular=false&size=30x30) experienced degraded performance:

HTTP code: 200
Response time: 1089 ms

Resolved: Thumbnails API Endpoint performance has improved in e39fd04 after 9 minutes.


My version is Dart 2.x ready, uses reflectable and is strong_mode compliant

Hi Greg, I forked your version a couple of hours ago and made it D2.x ready, strong_mode compliant. My version uses reflectable 2.x - so no mirrors!
All tests are on green
pub run build_runner test
pub run build_runner test -- -p chrome

Browser-sample works - webdev serve
I trie to make a PR but somehow it fails...
Here is my version: https://github.com/MikeMitterer/mustache
Maybe you can clone it to an extra branch on your side, check it out, and... :-))), if everything is OK on your side, release it to pub

Thanks for the input. I don't have a lot of time to work on this - so this
isn't a promise. What I was thinking about doing is having two entry points
for the library. The existing one will support mirrors as it does now -
this works well for VM apps. The new entry point will be
mustache_no_mirrors.dart, and allow the user to pass a "value resolver"
function i.e. "dynamic valueResolver(dynamic object, String name)". The end
user can then plug in whichever approach they like - for example
reflectable.
On Fri, 8 Jun 2018 at 05:50, Mike Mitterer<EMAIL_ADDRESS>wrote:

Hi Greg, I forked your version a couple of hours ago and made it D2.x
ready, strong_mode compliant. My version uses reflectable 2.x - so no
mirrors!
All tests are on green
pub run build_runner test
pub run build_runner test -- -p chrome
Browser-sample works - webdev serve
I trie to make a PR but somehow it fails...
Here is my version: https://github.com/MikeMitterer/mustache
Maybe you can clone it to an extra branch on your side, check it out,
and... :-))), if everything is OK on your side, release it to pub
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/xxgreg/mustache/issues/39, or mute the thread
https://github.com/notifications/unsubscribe-auth/AAACwCpzZnbPV5iWD5F9MU0K24Qa2yYpks5t6WfcgaJpZM4Ue2LE
.

Why do you think this is necessary? I mean two entry points? All your VM examples work fine e.g.
dart lambdas.dart Have you tried my version?

@xxgreg I'm happy to create the two entry points as you suggested. How does that sound? We need this in the Flutter tool see https://github.com/flutter/flutter/issues/31803

Sounds good to me.

Any word on this? Id like to convert my project to aot but cant currently because of mustache

If you're just using maps and don't need reflection, it's a pretty minimal change to remove the mirrors support. See: Rendered._getNamedProperty()
Apologies I can't be of more help.


sporadic error

⚠ Support requests in an issue-format will be closed immediately. For support, go to Swarm's Discord.
Context
ubuntu/bee light node
Summary
sporadically seeing this error in amoungst  successful batch service retrievals
Feb 11 10:33:32 sig-bee-main-02 bee[8670]: time="2022-02-11T10:33:32Z" level=debug msg="batch service: updated block height to 20582410"
Feb 11 10:33:57 sig-bee-main-02 bee[8670]: time="2022-02-11T10:33:57Z" level=debug msg="batch service: updated block height to 20582415"
Feb 11 10:34:22 sig-bee-main-02 bee[8670]: time="2022-02-11T10:34:22Z" level=debug msg="batch service: updated block height to 20582420"
Feb 11 10:34:47 sig-bee-main-02 bee[8670]: time="2022-02-11T10:34:47Z" level=debug msg="batch service: updated block height to 20582425"
Feb 11 10:35:12 sig-bee-main-02 bee[8670]: time="2022-02-11T10:35:12Z" level=debug msg="batch service: updated block height to 20582430"
Feb 11 10:35:37 sig-bee-main-02 bee[8670]: time="2022-02-11T10:35:37Z" level=warning msg="listener: could not get block number: 500 Internal Server Error: \r\n<title>500 Internal Server Error</title>\r\n\r\n
500 Internal Server Error
\r\n
nginx/1.21.3\r\n\r\n\r\n"
Feb 11 10:35:43 sig-bee-main-02 bee[8670]: time="2022-02-11T10:35:43Z" level=debug msg="batch service: updated block height to 20582435"
Feb 11 10:36:03 sig-bee-main-02 bee[8670]: time="2022-02-11T10:36:03Z" level=debug msg="batch service: updated block height to 20582440"
Feb 11 10:36:28 sig-bee-main-02 bee[8670]: time="2022-02-11T10:36:28Z" level=debug msg="batch service: updated block height to 20582445"

Expected behavior

Actual behavior

Steps to reproduce

Possible solution

This error is coming from the blockchain provider node, not bee, and as you can see, the bee recovers and does not shut down. If there's no problem symptom here I'd suggest to close this issue.

I would be curious what this node is using for the swap-endpoint...


Template out infrastructure to match with TERMINATIONS

Description
Copy of https://github.com/cloud-bulldozer/e2e-benchmarking/pull/363 but now exporting the TERMINATIONS env var

/rerun all router-perf-v2:./ingress-performance.sh


drivers: modem: add support for gemalto ehs6

This driver supports TCP/UDP client on ehs6 module, which supports IPV4
internet connection with AT commands. This driver has been tested on a
frdm_k64f board.
Signed-off-by: Song Qiang<EMAIL_ADDRESS>

Codecov Report

Merging #15049 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master   #15049   +/-   ##
=======================================
  Coverage   52.93%   52.93%
=======================================
  Files         309      309
  Lines       45268    45268
  Branches    10451    10451
=======================================
  Hits        23961    23961
  Misses      16542    16542
  Partials     4765     4765

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c6249ac...91f9adf. Read the comment docs.

@cybertale Thank you for your submission.   As it is the weekend and I have a holiday on Monday, I would ask for your patience as I get time to do a review.

@cybertale Thank you for your submission. As it is the weekend and I have a holiday on Monday, I would ask for your patience as I get time to do a review.

Sure, and here is the AT command manual of this module.
https://m2m.dk/wp-content/uploads/2014/05/EHS6-AT-Command-Set-V03.001-19.02.2015-1.pdf

@cybertale I realize now looking at the PR again, that this does not support DTS at the moment.  Did you plan to update that in this PR or add it as a second PR later?

@mike-scott DTS support is not a big problem. What I'm worried about is that I have about nearly about 500 lines of code copied from your driver, which mainly is about pulling data from the uart (ehs6_rx() I mean). We should make this generic but I don't know many modems and don't know if all modems use UART and AT commands. What do you think we should do with this?

@mike-scott DTS support is not a big problem. What I'm worried about is that I have about nearly about 500 lines of code copied from your driver, which mainly is about pulling data from the uart (ehs6_rx() I mean). We should make this generic but I don't know many modems and don't know if all modems use UART and AT commands. What do you think we should do with this?

@cybertale Yes, I'm researching the best way to implement a UART/AT command (3GPP?) API for modems to use so that we don't copy that code.

@mike-scott This is good, how long do you think would it take? My PR can wait for that change while I keep fixing problems about it in the same time. Or merge this then make that change?

@cybertale The earliest this PR could be merged would be in the 1.15 window.  I've been very busy with work so I haven't had the time to see what other RTOS are doing in this area, etc.

FYI, I also have another modem driver waiting in this PR: https://github.com/zephyrproject-rtos/zephyr/pull/14057  And I would try and solve all 3 modems with the new UART/AT command API.

@mike-scott Hi, sorry for the late, I added DTS support and fixed copy/paste issues. Give it a look when you got some time.

@cybertale Sorry for the delay.  I had a rather large modem PR which was just merged, so I can now consider a new PR which separates generic handling of the UART into common code.
We have the 2 modem drivers in mainline Zephyr, plus this PR and another driver which is not public.  They all have different requirements and it will take me some time to come up with a suitable solution to present.
But at least it's now in-progress.

@mike-scott Sure, take your time.

@cybertale @mike-scott  is it ok to move this to 2.1 release?

Any updates on this?


functions to macros

Substituting inline functions with Macros may not be the best optimization as the compiler would try to inline the functions when possible while maintaining type safety and code clarity. This will be rejected.


The understanding of W

Hello author, thank you very much for your work. What does this W refer to? Is it W0 or Wb? I don't understand. Look forward to your reply, thank you!

Hi, thank you for your question.
The section you are looking at discusses the update rule for a hidden state which is a K-layer MLP. Therefore, k here refers to the k-th layer in this MLP, and W^{k} means the weight matrix of that layer.

Thanks for your reply. The weight of matrix W is updated during forward: from W0，W1，W2…… to Wb. So what does the W refer to in this formula？W0？W1？Wb？Look forward to your reply. Thanks!

Say \theta^0 refers to the entire parameters of a hidden state (a neural network in our case). Therefore, \theta^1, ... ,\theta^b are the updated entire parameters after each TTT mini-batch, which I think is what you are referring to.
On the other hand, W_k means the weight of the k-th layer inside this hidden state (a neural network), so \theta^t = {W^t_0, ..., W^t_K}.

Thanks for your reply.
So when we calculate output Z，what W we use（W in the red box）？W0？W1？Wb？

Say at time step b (the b-th TTT mini-batch), the hidden state value is \theta_b = {W_b^1, ..., W_b^K}.
The final output Z_b at time step b is calculated by forwarding through the K layer in \theta_b sequentially, e.g., computing Z_b^1 to Z_b^K.
Your confusion may come from in the formula, it's not specific to a time step, since it applies to any time step.

it's not specific to a time step, since it applies to any time step.

Thanks for your reply ! The sentence "it's not specific to a time step, since it applies to any time step." make me understand.
Thanks for your patience.

You are very welcome!

But another question：why the W refers to W0？Is it specific to a time step？Look forward to your reply. Thanks!

Here W_0 stands for the initial value of hidden states for an arbitrary time step. Here 1, ..., b refer to the 1st to b-th tokens in side an arbitrary TTT mini-batch. W_1, ..., W_b stand for the updated hidden state values for each token in that TTT mini-batch.
Therefore, it's not specific to a time step.

Thank you for your reply. May I ask when we calculate，why we should change the gradient of loss to W0 to the Z?

Sorry I didn't get your question, could you point me to the specific formula you are referring to?

Sorry I didn't get your question, could you point me to the specific formula you are referring to?

When calculating the updated W, we use the gradient of the loss with respect to W₀, but why is the gradient of the loss with respect to Z used in the subsequent formulas? Why is such a conversion necessary？

$\nabla_{Z^k}l$ comes from the first factor of $\nabla_{W^k_0}l=\nabla_{Z^k}l \cdot \left(\hat{X}^k\right)^T$. The point of dual form is by applying the associative rule of matrix multiplication, we can direct calculate the output of the second forward pass $\bar{Z}$ without explicitly materializing $\nabla_{W^k_0}l$.
Please refer to Appendix A.3 for more details.


Refactor grade command

Resolves #195 , #196
I will probably abstract out GradeCommand::getSuccessMessage in #197

Codecov Report
Base: 63.32% // Head: 63.15% // Decreases project coverage by -0.16% :warning:

Coverage data is based on head (11e9334) compared to base (73b39c7).
Patch coverage: 0.00% of modified lines in pull request are covered.

Additional details and impacted files
@@             Coverage Diff              @@
##             master     #198      +/-   ##
============================================
- Coverage     63.32%   63.15%   -0.17%
  Complexity      536      536
============================================
  Files           102      102
  Lines          1865     1870       +5
  Branches        206      207       +1
============================================
  Hits           1181     1181
- Misses          622      627       +5
  Partials         62       62

Impacted Files
Coverage Δ

...va/seedu/taassist/logic/commands/GradeCommand.java
0.00% <0.00%> (ø)

...eedu/taassist/logic/parser/GradeCommandParser.java
0.00% <0.00%> (ø)

...n/java/seedu/taassist/logic/parser/ParserUtil.java
51.56% <0.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.


Refactored table_measure in the patients controller

Made it less complex, and DRYed it up a little.

rebased and merged


Add requirements.txt with all packages needed to be installed to get …

…the notebooks working. The requirements can be used with pip install.

Looks good, thanks!


Deregistering Services from Consul in a dockerised environement

Is there any way to de-register a service as soon as its health check fails in consul? I found DeregisterCriticalServiceAfter (string: "")  in this link https://www.consul.io/api/agent/check.html.
But the minimum time that can be set using the above property is 1 minute. But I need it to be less than 30 seconds or as soon as health check fails at that time it should deregister itself from consul.

You'll have to take that up with consul itself. We support DeregisterCriticalServiceAfter but if the minimum is 1 min, there's nothing we can do.


missing ros packages when launching the gazebo_world.launch

I can make build under native noetic after modifiying the catkin build command in Makefile by adding cmake-args:
-DPYTHON_EXECUTABLE=/usr/bin/python3.
However even the build was successful there were missing ros packages when launching the gazebo_world.launch

world_handler
groundtruth_odom_publisher
joy_controller
vel_driver

@wing-kit
Thank you for actually using my repository, and for sharing the troubles you encountered :smiley:
I also thought that the Makefile would source the ROS project for us, but I learned that it doesn't actually affect the shell we are manually operating. Anyway we need to type source devel/setup.bash after make build, in order to roslaunch the project.
Another convenient way is to add a launching command in the Makefile. For example, following works in the updated Makefile without typing source command by yourself.
make build
make gazebo_world

@wing-kit
I would be very pleased if you could use my algorithm on a real machine :)
If any issues arise during its application, please do not hesitate to share them with me.
Currently, the basic MPPI algorithm (MPPI-3D) is already on the repository. MPPI-4D and MPPI-H will be coming soon!


[libSyntax] Fix function parameter parsing issue

In libSyntax, isolated and _const are modelled as optional identifiers in the FunctionParameter, same as firstName and secondName. If the function parameter doesn't contain isolated or _const, the syntax context tries to form the isolated token from the first name.
For example, func foo(myName: Int) gets parsed as having a parameter
Attributes: <null>
IsolatedToken: `myName`
ConstToken: <null>
FirstName: <null>
SecondName: <null>
Colon: `:`
Type: `Int`
Ellipsis: <null>
DefaultArgument: <null>
TrailingComma: <null>

To disambiguate, explicitly record null nodes for the attribute list, isolated and _const token. All of this is a little hacky but because the C++ libSyntax parser will be gone at some point anyway, it shouldn't be too bad.

@swift-ci Please smoke test

I'm not sure this is right. Can  isolated and _const be used at the same time?
func foo(isolated _const _ arg: SomeTy) { }

The current parser emits an error error: 'isolated' may only be used on parameters, but I don't think this is a correct error message.
If we can use both, should they be ordered? As far as I can see in the C++ parser code, they are not ordered (_const isolated is allowed). If so, this portion should be modeled as a list, like ModifierList.
If we can only use a modifier on a type, this part should be modeled as like:
             Child('Specifier', kind='ContextualKeywordToken',
                   is_optional=True),

Either way, we should remap this to tok::contextual_keyword.

Considering the possibility of new modifiers being introduced in the future, I'd suggest modeling it as a ModifierList which is consistent with other value decls.
    Node('FunctionParameter', name_for_diagnostics='function parameter', kind='Syntax',
         traits=['WithTrailingComma'],
         children=[
             Child('Attributes', kind='AttributeList', name_for_diagnostics='attributes',
                   collection_element_name='Attribute', is_optional=True),
             Child('Modifiers', kind='ModifierList', name_for_diagnostics='modifiers',
                   collection_element_name='Modifier', is_optional=True),
             Child('FirstName', kind='Token', name_for_diagnostics='name',
                   ...

https://github.com/apple/swift-syntax/pull/861
@swift-ci Please smoke test

https://github.com/apple/swift-syntax/pull/861
https://github.com/apple/swift-stress-tester/pull/193
@swift-ci Please smoke test

https://github.com/apple/swift-syntax/pull/861
https://github.com/apple/swift-stress-tester/pull/193
@swift-ci Please smoke test Linux

https://github.com/apple/swift-syntax/pull/861
https://github.com/apple/swift-stress-tester/pull/193
@swift-ci Please smoke test Linux


Commenting out the confimation modal to test something in staging.

CC @tgolen
Details
We are removing the confirmation modal to see if we can figuring out why https://github.com/Expensify/App/issues/8791 is happening
Fixed Issues
Does not really fix anything but will probably allows us to fix
Tests
N/A
QA Steps

Go to Workspace and verify that nothing funky is happening
(me @sketchydroide, os someother MobileDeployer will test this)

Screenshots
N/A

Merging with the linter failing because this is just going to be reverted shortly after we test it on staging.


store/store_lib.c: Add the checks for the EVP_MD_CTX_get_size()

Add the checks for the return value of EVP_MD_CTX_get_size() before explicitly cast them to size_t to avoid the integer overflow.
Fixes: fac8673b8a ("STORE: Add the possibility to search for specific information")

Checklist

[ ] documentation is added or updated
[ ] tests are added or updated

This pull request is ready to merge

merged, thank you for your contribution


Proximity Segmentation in Isaac Gym (the Omniverse version)

Hello,
Is there any support to be able to use the Proximity Segmentation capabilities from Isaac ROS Proximity Segmentation in parallel environments in Omniverse Sim/Gym? The ROS2 layer would have to be stripped away as it's not appropriate for the parallel Gym environments used during the RL training. Is this possible?

Possible, yes, but it would take some work to strip away the ROS 2 layer and integrate the same underlying libraries with Isaac Gym. Alternatively, you can integrate Isaac Gym and Isaac ROS through your own ROS 2 application.

ROS is inappropriate when I have over 10k parallel environments running in
Isaac Gym. The power of Isaac Gym is only fully realized when all code runs
on the GPU. Having ROS in the middle removes the primary performance
benefits of Isaac Gym.
On Mon, Mar 6, 2023 at 1:59 PM Hemal Shah @.***> wrote:

Possible, yes, but it would take some work to strip away the ROS 2 layer
and integrate the same underlying libraries with Isaac Gym. Alternatively,
you can integrate Isaac Gym and Isaac ROS through your own ROS 2
application.
—
Reply to this email directly, view it on GitHub
https://github.com/NVIDIA-ISAAC-ROS/isaac_ros_proximity_segmentation/issues/9#issuecomment-1456773588,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/ABAYEB4O2RAB4C4GNWBPS5DW2YXXHANCNFSM6AAAAAAVPCEYJM
.
You are receiving this because you authored the thread.Message ID:
<NVIDIA-ISAAC-ROS/isaac_ros_proximity_segmentation/issues/9/1456773588@
github.com>

Isaac ROS Proximity Segmentation functions using the underlying Bi3D model, which is independently available on NGC here. The model is distributed as a set of .onnx files, which can be loaded by any standard inference engine (Triton, TensorRT, Pytorch, etc.).
You should be able to write your own wrapper function in Python, etc. that loads the model into your inference engine of choice encodes input images, runs inference, and decodes the output images.


Browsing by dragging photo

[low prio] [enhancement]
Another way of browsing photos. It's "smartphone'ish" way of browsing. It will be easier for me to explain by these points:

LMB (left mouse button) down
User moves mouse within some cage e.g.  more than 35% horizontally and less than 10% vertically move
LMB up
Check if cage conditions are met. If they are, prevent default action and change photo to next (left movement) or prev (right movement). If not, allow default browser action.

I have to admit I don't use smartphones and I don't know if that way is obvious, needed by users etc. I thought about that, because Lychee have very modern look and usage, so maybe users of Lychee are used to browsing photos like that on smartphones.

Thanks for the suggestion! Swiping in Lychee is possible on touch-screen devices, but it's not planned to support dragging via cursor.


Add column info for external tables to catalog

Description
When building the docs catalog, it's missing column information for external tables. This PR aims to add that column info by querying svv_external_columns redshift table
Opened this PR after some slack discussions here:
https://getdbt.slack.com/archives/C50NEBJGG/p1661977048805169
https://getdbt.slack.com/archives/CJARVS0RY/p1661961577013479
Checklist

[x] I have signed the CLA
[x] I have run this code in development and it appears to resolve the stated issue
[ ] This PR includes tests, or tests are not required/relevant for this PR
[ ] I have run changie new to create a changelog entry

Hey @gcsabbagh, this is still in draft status. Were you planning to give it more time, or should we try to cary it over the finish line from here?

Hey @Fleid sorry I had forgotten about this PR. Could just use some help adding some tests in for this enhancement if possible!


#875 Context menu remains displayed while dragging

Fixes: #875
Developer's Certificate of Origin 1.1
   By making a contribution to this project, I certify that:

   (a) The contribution was created in whole or in part by me and I
       have the right to submit it under the Apache License 2.0; or

   (b) The contribution is based upon previous work that, to the best
       of my knowledge, is covered under an appropriate open source
       license and I have the right under that license to submit that
       work with modifications, whether created in whole or in part
       by me, under the same open source license (unless I am
       permitted to submit under a different license), as indicated
       in the file; or

   (c) The contribution was provided directly to me by some other
       person who certified (a), (b) or (c) and I have not modified
       it.

   (d) I understand and agree that this project and the contribution
       are public and that a record of the contribution (including all
       personal information I submit with it, including my sign-off) is
       maintained indefinitely and may be redistributed consistent with
       this project or the open source license(s) involved.

Oh OK. Good catch! That's actually a third scenario since you can drag a new link line regardless of the link selection type (detachable) so I'll fix that one too, as part of this PR.


⚠ Bofrost.lu has degraded performance

In c92636f, Bofrost.lu (https://www.bofrost.lu) experienced degraded performance:

HTTP code: 200
Response time: 1078 ms

Resolved: Bofrost.lu performance has improved in ba6b3c9 after 12 minutes.


How to automatically save the model during training and add Early Stop by callbacks?

Hi, all. I am a green hand of mxnet coming from Keras community. Multiple GPUs and distributed fashion are the two main reasons for me to turn to mxnet. I find out that the documents of mxnet are not perfect, at least not as good as Keras or Lasagne. I have two questions.
Suppose that I am training for an image classification problem:
    train_dataiter = mx.io.ImageRecordIter(
        path_imgrec        = "./train.rec",
        rand_crop          = True,
        rand_mirror        = True,
        shuffle            = True,
        data_shape         = (3,224,224),
        batch_size         = batch_size,
        preprocess_threads = 4,
        prefetch_buffer    = 4,
        )
    test_dataiter = mx.io.ImageRecordIter(
        path_imgrec        = "./val.rec",
        rand_crop          = False,
        rand_mirror        = False,
        data_shape         = (3,224,224),
        batch_size         = batch_size,
        preprocess_threads = 4,
        prefetch_buffer    = 4,
        )

    model = mx.model.FeedForward(ctx=mx.gpu(0), symbol=softmax, num_epoch=10, learning_rate=0.1,     momentum=0.9, wd=0.0001,initializer=mx.init.Uniform(0.07))
    model.fit(X=train_dataiter, eval_data=test_dataiter, batch_end_callback=mx.callback.Speedometer(8))

How to make the code to enable it to automatically save the model as well as the parameters during training process (the highest validation classification accuracy)? Besides, how to add the early stopping by epoch_callbacks?
Thank you for your time. Happy New Year!

I am also interested in hearing the suggested solution for early stopping + saving model.
If you only intend to use a single callback-function argument, it appears one (hacky) way to go about it would be adding functionality to model.py:_train_multi_device() to use of the return value of 'call()' @ model.py:289.
A better way may be adding a completely separate argument in _train_multi_device() specifically for the purpose of early stopping, then use heldout metric get() value to determine whether to break.

@alirezabagheri Great! I would appreciate if you can contribute and share you code for Early Stropping and Saving Model.

What exactly do you want early stopping to do? You can checkpoint the model and exit the program in epoch_end callbacks.

@piiswrong I just wanna early stopping to exit if the loss does not consistently drop down for 20 epochs. And meantime, the program always saves the model and its parameters to disk with current lowest loss. If you know how to implement this, could you please show me some example codes, please?

@piiswrong one cannot directly use epoch_end callbacks because (1) you need to know the current metric on eval set and (2) need to maintain state variables for what was the best heldout so far and how many epochs have past since this best. You can get around this by storing state in 'aux_params' however.
@paipai880429 assuming you are still interested in a solution, here's one way to go about it:

In python/mxnet/model.py:fit(...) add argument for early-stopping (perhaps with a default value, e.g. something like 'early_stopping_epochs = 10').
Within "fit()" function, pass this early-stopping variable to sub-function '_train_multi_device' and update the header for '_train_multi_device' to accept it (like step 1).
Within '_train_multi_device', search for 'eval_metric.get()' used on the evaluation set. Use this value and the early-stopping value to implement the logic to figure out when to stop. Call mxnet.model.save_checkpoint() to save model, and return to terminate.

@alirezabagheri There is an easier way of doing it. locals() is already added to batchparam. It captures all the local variables from _train_multi_device. You can add it to epoch_end_callback call and access everything from there.

@piiswrong Thanks for the quick response. Okay, I see the code has already changed a lot since my pull.
Even with the latest code, not sure if your suggestion would exactly be easier. If the framework supported an **eval_**epoch_end_callback with argument for locals(); then that would be the best in the sense that everything could be done in the supplied callback function.

@paipai880429 Don't know if you ever got your early stopping work complete.  But I've done something similar based on the xGBoost early stopping rounds parameter as well as the evaluation logger example in the mxnet team's documents:
mx.callback.early.stop <- function (period, nrounds, logger = NULL, maximize=TRUE, verbose=FALSE)
{
    function(iteration, nbatch, env) {
        if (nbatch%%period == 0 && !is.null(env$metric)) {
            result <- env$metric$get(env$train.metric)
            if (nbatch != 0)
                cat(paste0("Batch [", nbatch, "] Train-", result$name,
                  "=", result$value, "\n"))
            if (!is.null(logger)) {
                if (class(logger) != "mx.metric.logger") {
                  stop("Invalid mx.metric.logger.")
                }
                logger$train <- c(logger$train, result$value)
                if (!is.null(env$eval.metric)) {
                  result <- env$metric$get(env$eval.metric)
                  if (nbatch != 0)
                    cat(paste0("Batch [", nbatch, "] Validation-",
                      result$name, "=", result$value, "\n"))
                  logger$eval <- c(logger$eval, result$value)
					  if (iteration > nrounds) {
						if(maximize) {
							if(sum(result$value > tail(logger$eval,nrounds)) == 0 ) {
								bst.round <- which.max(logger$eval)
								if (verbose) {
									print(paste0("Best round: ", bst.round, "; Best metric: ", max(logger$eval)))
									print(paste0("This round: ", result$value))
								}
								return(FALSE)
							}
						} else if(sum(result$value < tail(logger$eval,nrounds)) == 0 ) {
								bst.round <- which.min(logger$eval)
								if (verbose) {
									print(paste0("Best round: ", bst.round, "; Best metric: ", min(logger$eval)))
									print(paste0("This round: ", result$value))
								}
								return(FALSE)
						}
					}
				}
			}
        return(TRUE)
		}
	}
}

You can call it like so:
model <- mx.model.FeedForward.create(lenet, X=train.array, y=train.y,
    num.round=500, array.batch.size=bs,
    learning.rate=lr, momentum=0.9, wd=0.00001,
    eval.metric=mx.metric.logloss,
    epoch.end.callback= mx.callback.early.stop(5,10,logger, maximize=FALSE, verbose=TRUE),
    eval.data=list(data=val.array, label=val.y))


Fix missing features

Closes #1032
I just saw #1032 and thought I can fix this real quick. :laughing:
Types of changes

[x] Bugfix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Improvement (general improvements like code refactoring that doesn't explicitly fix a bug or add any new functionality)
[ ] Documentation Update (if none of the other choices apply)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist

[X] I have read the CONTRIBUTING doc
[x] I have signed the CLA (in all commits with git commit -s)
[ ] I ran cargo fmt as mentioned in CODING_GUIDELINES
[ ] I used cargo clippy as mentioned in CODING_GUIDELINES
[ ] I have added tests that prove my fix is effective or that my feature works
[ ] I have added necessary documentation (if appropriate)

The second patch needs discussion, I guess. Not sure whether this is the way to go...

The second patch needs discussion, I guess. Not sure whether this is the way to go...

Oh I missed this comment. Maybe add @makr11st to the reviewer to discuss?

I'm just curious how the build from the repo root was working even without these dependencies. I only see the log-request-plugin that previously had an explicit dependency defined on rt-multi-thread. But that crate was not a dependency of this tedge-mapper crate. So, where else was it "inheriting" this dependency from?

The second patch needs discussion, I guess. Not sure whether this is the way to go...

Why do you think it needs a discussion? Is there some overhead that you're expecting?

I think it has to do with how cargo resolves dependencies. When building the whole worktree, it finds all dependencies and includes them. The process feature of tokio is included somewhere, so it is included when building this particular crate. When building only the crate, the feature is not included and the build thus fails.

Why do you think it needs a discussion? Is there some overhead that you're expecting?

After giving it a second thought: No! :laughing: The default tokio runtime is multithreaded, but the feature was missing in the dependency specification. I guess the same as with the process feature applies: Somewhere, multithreaded runtime was enabled and so this was not a problem, but when building only the one crate, the feature was missing and thus the build failed.
So I think these changes are exactly what is necessary so everything works as expected. :laughing:

@matthiasbeyer Thanks for that explanation. Feel free to squash and merge this PR.


NO-ISSUE: Update screenshot for failing test.

The test started to fail probably because of an update in Chrome that changed the behavior of the CSS since there was no PR with a failing test was merged.
Also, the others tests (Chromium and Webkit) didn't have any change.

@danielzhe It seems there's another screenshot to fix in Test Scenario Editor

@danielzhe It seems there's another screenshot to fix in Test Scenario Editor

Updated! It's weird how they were not failing before. I expect that maybe more can fail.
Btw, I checked each one of the failing tests just to be sure that there was nothing broken and it are just small details in the render.


[suggestion] Make it possible to save trip on server

Hello,
I suggest making it possible to save a trip onto the server so that users can share it by simply copy/pasting the URL à la Cycle.travel or… Googe Maps.
http://cycle.travel/map
https://www.google.com/maps/dir/
Cheers,

Well, my guess is, GDPR makes imho implementation less likely.
Similar request to store and share user profiles, more privacy friendly than routes, is already waiting for some years.


Allow markdown code blocks to show new-lines

Fix for #539

There is an alternative fix already applied.


⚠ Maple - Request Service has degraded performance

In 59d7118, Maple - Request Service (https://request.zyradyl.moe) experienced degraded performance:

HTTP code: 200
Response time: 17715 ms

Resolved: Maple - Request Service performance has improved in 3186084 after 38 minutes.


Allow Neur to run tasks autonomously and send emails

Allow Neur to autonomously fetch latest launches and trending tokens, filter out memecoins, then email the token information to specified address in a concise and legible format every few hours

@0xSpotly Do you envision automations being handled entirely within this repo or will there another service that is working in the background?
I can see event driven automations based on time (cron) and on chain data (new raydium/pf pool, transaction involving some address for copy trade, etc.)


Support a Max Queue Size for Buffered Messages

Adds a variable maxEnqueuedMessages that handles setting a limit
on the maximum number of messages to queue up when a connection
is down.
Defaults to Infinity, and can be used to disable queueing by setting
the value to 0.
Added a small test around the new feature, and fixed an oddity in an
existing test.

Coverage increased (+0.09%) to 94.415% when pulling f7d7bacd7909e49b0f0eb79237a567b058ce3d69 on Flyclops:master into c64d32fbeaf70199e7b82817476f4d9f3e35ef39 on pladaria:master.

Hi! There's anything preventing this one to be merged? Thanks!

Hi! There's anything preventing this one to be merged? Thanks!

Thank you!


Rearrange docs

Many thanks for submitting your Pull Request :heart:!
Fixes #672
Please make sure that your PR meets the following requirements:

[ ] You have read the contributors guide
[ ] Your code is properly formatted according to our code style
[ ] Pull Request title contains the target branch if not targeting main: [0.9.x] Subject
[ ] Pull Request contains link to the issue
[ ] Pull Request contains link to any dependent or related Pull Request
[ ] Pull Request contains description of the issue
[ ] Pull Request does not include fixes for issues other than the main ticket

How to backport a pull request to a different branch?

In order to automatically create a backporting pull request please add one or more labels having the following format backport-<branch-name>, where <branch-name> is the name of the branch where the pull request must be backported to (e.g., backport-quarkus2 to backport the original PR to the quarkus2 branch).

NOTE: backporting is an action aiming to move a change (usually a commit) from a branch (usually the main one) to another one, which is generally referring to a still maintained release branch. Keeping it simple: it is about to move a specific change or a set of them from one branch to another.

Once the original pull request is successfully merged, the automated action will create one backporting pull request per each label (with the previous format) that has been added.
If something goes wrong, the author will be notified and at this point a manual backporting is needed.

NOTE: this automated backporting is triggered whenever a pull request on main branch is labeled or closed, but both conditions must be satisfied to get the new PR created.

Great work @mcruzdev! I just left a few suggestions to fix the OpenAPI case, that probably already existed before this PR.

Thank you @hbelmiro, I will squash soon!

@mcruzdev We squash when we merge. Can I merge it?

Yes! Thank you for reviewing it!


test_decode_csv fails when running locally

When running the tests locally I encounter a failure:
>       assert decoded_data == {"inputs": ["I love you", "I like you"]}
E       AssertionError: assert {'inputs': [{'context': 'My name is Philipp and I live in Nuremberg',\n             'question': 'where do i live?'},\n            {'context': 'Berlin is the capital of Germany',\n             'question': 'where is Berlin?'}]} == {'inputs': ['I love you', 'I like you']}
E         Differing items:
E         {'inputs': [{'context': 'My name is Philipp and I live in Nuremberg', 'question': 'where do i live?'}, {'context': 'Berlin is the capital of Germany', 'question': 'where is Berlin?'}]} != {'inputs': ['I love you', 'I like you']}
E         Full diff:
E           {
E         -  'inputs': ['I love you',
E         -             'I like you'],
E         +  'inputs': [{'context': 'My name is Philipp and I live in Nuremberg',
E         +              'question': 'where do i live?'},
E         +             {'context': 'Berlin is the capital of Germany',
E         +              'question': 'where is Berlin?'}],
E           }

...

[gw0] FAILED tests/unit/test_decoder_encoder.py

This appears to be caused by a typo entering the wrong input data for the second assertion in the test.  I have proposed a PR to fix here - https://github.com/aws/sagemaker-huggingface-inference-toolkit/pull/38.

Solved in #38 and #42

Thanks @philschmid !


Display warnings and errors by default, not suggestions

Describe the bug
Usability issue: I believe the current configuration of .vale.ini has MinAlertLevel = suggestion.
Unfortunately:

Running vale on a typical file generates an overwhelming number of suggestions.
The suggestions are too repetitive.
Some of the suggestions are misguided.

I believe this experience demotivates users from trusting and using vale.
I believe the solution is to increase the default value of MinAlertLevel = warning in .vale.ini and to ensure that the warnings and errors are not misguided.
Examples:
With MinAlertLevel = suggestion, you get:
rdlugyhe@rdlugyhe openshift-docs (RHDEVDOCS-3570 *<) $ vale --minAlertLevel=suggestion  modules/images-other-jenkins-config-kubernetes.adoc

 modules/images-other-jenkins-config-kubernetes.adoc
 6:3      suggestion  'Configuring the Jenkins        RedHat.Headings
                      Kubernetes plug-in' should use
                      sentence-style capitalization.
 8:209    warning     Consider using 'many' instead   RedHat.ComplexWords
                      of 'multiple'
 10:90    suggestion  Do not use 'as' to mean         RedHat.As
                      'because' or 'while'.
 12:1     suggestion  Try to keep sentences less      RedHat.SentenceLength
                      than 25 words.
 12:1     suggestion  Verify your use of 'Both' with  RedHat.Usage
                      the word usage guidelines.
 12:70    suggestion  Do not use 'as' to mean         RedHat.As
                      'because' or 'while'.
 12:187   suggestion  Try to keep sentences less      RedHat.SentenceLength
                      than 25 words.
 12:254   suggestion  'be applied' is passive voice.  RedHat.PassiveVoice
                      Consider rewording in active
                      voice. You can use the passive
                      voice in prerequisites
 12:337   suggestion  'be run' is passive voice.      RedHat.PassiveVoice
                      Consider rewording in active
                      voice. You can use the passive
                      voice in prerequisites
 12:366   suggestion  'is applied' is passive voice.  RedHat.PassiveVoice
                      Consider rewording in active
                      voice. You can use the passive
                      voice in prerequisites
 12:428   suggestion  Verify your use of              RedHat.Usage
                      'respective' with the word
                      usage guidelines.
 16:1     suggestion  Try to keep sentences less      RedHat.SentenceLength
                      than 25 words.
 22:1     suggestion  Try to keep sentences less      RedHat.SentenceLength
                      than 25 words.
 22:176   suggestion  Verify your use of 'so' with    RedHat.Usage
                      the word usage guidelines.
 22:263   suggestion  'is provided' is passive        RedHat.PassiveVoice
                      voice. Consider rewording in
                      active voice. You can use the
                      passive voice in prerequisites
 24:1     suggestion  Try to keep sentences less      RedHat.SentenceLength
                      than 25 words.
 24:71    suggestion  'are mapped' is passive voice.  RedHat.PassiveVoice
                      Consider rewording in active
                      voice. You can use the passive
                      voice in prerequisites
 24:151   suggestion  Try to keep sentences less      RedHat.SentenceLength
                      than 25 words.
 24:342   suggestion  'is used' is passive voice.     RedHat.PassiveVoice
                      Consider rewording in active
                      voice. You can use the passive
                      voice in prerequisites
 24:350   suggestion  Do not use 'as' to mean         RedHat.As
                      'because' or 'while'.
 28:42    warning     Consider using 'change'         RedHat.ComplexWords
                      instead of 'modify'
 28:91    suggestion  Verify your use of 'so' with    RedHat.Usage
                      the word usage guidelines.
 28:117   suggestion  'is created' is passive voice.  RedHat.PassiveVoice
                      Consider rewording in active
                      voice. You can use the passive
                      voice in prerequisites
 28:347   suggestion  Verify your use of 'new' with   RedHat.Usage
                      the word usage guidelines.
 33:1     suggestion  Try to keep sentences less      RedHat.SentenceLength
                      than 25 words.
 33:131   warning     Consider using 'has' instead    RedHat.ComplexWords
                      of 'contains'
 33:276   suggestion  Try to keep sentences less      RedHat.SentenceLength
                      than 25 words.
 33:329   error       Consider using 'rather than'    RedHat.Terms
                      rather than 'instead of'
 142:120  suggestion  'is created' is passive voice.  RedHat.PassiveVoice
                      Consider rewording in active
                      voice. You can use the passive
                      voice in prerequisites
 142:305  suggestion  Verify your use of 'new' with   RedHat.Usage
                      the word usage guidelines.
 144:42   warning     Consider using 'change'         RedHat.ComplexWords
                      instead of 'modify'
 144:81   suggestion  Try to keep sentences less      RedHat.SentenceLength
                      than 25 words.
 144:91   suggestion  Verify your use of 'so' with    RedHat.Usage
                      the word usage guidelines.
 144:117  suggestion  'is created' is passive voice.  RedHat.PassiveVoice
                      Consider rewording in active
                      voice. You can use the passive
                      voice in prerequisites
 144:347  suggestion  Verify your use of 'new' with   RedHat.Usage
                      the word usage guidelines.
 149:1    suggestion  Try to keep sentences less      RedHat.SentenceLength
                      than 25 words.
 149:10   suggestion  'is installed' is passive       RedHat.PassiveVoice
                      voice. Consider rewording in
                      active voice. You can use the
                      passive voice in prerequisites
 154:20   suggestion  'are removed' is passive        RedHat.PassiveVoice
                      voice. Consider rewording in
                      active voice. You can use the
                      passive voice in prerequisites
 154:65   suggestion  'is removed' is passive voice.  RedHat.PassiveVoice
                      Consider rewording in active
                      voice. You can use the passive
                      voice in prerequisites
 155:3    suggestion  Verify your use of 'Either'     RedHat.Usage
                      with the word usage
                      guidelines.
 156:222  suggestion  'were made' is passive voice.   RedHat.PassiveVoice
                      Consider rewording in active
                      voice. You can use the passive
                      voice in prerequisites
 156:276  suggestion  Do not use 'between' to show    RedHat.Between
                      a range of numbers; it is not
                      clear whether the two numbers
                      are the boundaries of the
                      range or are included in the
                      range.
 158:26   suggestion  Do not use 'as' to mean         RedHat.As
                      'because' or 'while'.
 158:75   suggestion  Do not use 'as' to mean         RedHat.As
                      'because' or 'while'.
 158:110  suggestion  Do not use 'about' to mean      RedHat.About
                      'approximately'.
 158:122  suggestion  Verify your use of 'refer       RedHat.Usage
                      to' with the word usage
                      guidelines.
 158:122  error       Use 'see' rather than 'refer    RedHat.see
                      to'.

✖ 2 errors, 4 warnings and 41 suggestions in 1 file.
rdlugyhe@rdlugyhe openshift-docs (RHDEVDOCS-3570 *<) $ vale modules/images-other-jenkins-config-kubernetes.adoc

With MinAlertLevel = warning, you get:
 modules/images-other-jenkins-config-kubernetes.adoc
 8:209    warning  Consider using 'many' instead   RedHat.ComplexWords
                   of 'multiple'
 28:42    warning  Consider using 'change'         RedHat.ComplexWords
                   instead of 'modify'
 33:131   warning  Consider using 'has' instead    RedHat.ComplexWords
                   of 'contains'
 33:329   error    Consider using 'rather than'    RedHat.Terms
                   rather than 'instead of'
 144:42   warning  Consider using 'change'         RedHat.ComplexWords
                   instead of 'modify'
 158:122  error    Use 'see' rather than 'refer    RedHat.see
                   to'.

To Reproduce
Steps to reproduce the behavior:
Expected behavior
A clear and concise description of what you expected to happen.
Additional context
Add any other context here.

I don't agree to set it as a default.


Prepare Release fil_actor_interface v5.1.0

Summary of changes
Changes introduced in this pull request:

fil_actor_interface version updated to v5.1.0

Reference issue to close (if applicable)

Closes #141
Other information and links

Codecov Report
Patch and project coverage have no change.

Comparison is base (ef2e4f7) 10.66% compared to head (9f3cd07) 10.66%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #142   +/-   ##
=======================================
  Coverage   10.66%   10.66%
=======================================
  Files         318      318
  Lines       29034    29034
=======================================
  Hits         3097     3097
  Misses      25937    25937

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.


WhiteBalance operation doesn't work

I see we can't use White balance correction like in GPUImage 1
Now code of this operation is commented
Can you enable this code again?
I think we should change only two things to fix this operation

({temperature = 1.0})()
({tint = 0.0})()

constant half3x3 RGBtoYIQ = half3x3({0.299, 0.587, 0.114}, {0.596, -0.274, -0.322}, {0.212, -0.523, 0.311});
constant half3x3 YIQtoRGB = half3x3({1.0, 0.956, 0.621}, {1.0, -0.272, -0.647}, {1.0, -1.105, 1.702});

This has been fixed as of #94


The logged in user name text that comes after loging in overlapws with the left hand navigation menu when the size of the screen is decreased vertically, by pressing f12

Submit an Issue

Hi,
Thanks for helping us improve the Predix UI platform by submitting an issue.
Before you begin, please check the list of existing issues to avoid submitting a duplicate issue.
To help us solve this issue as fast as possible, please fill out the following sections:
Expected behavior and actual behavior: Expected behavior is the user name should not get overlapped over the navigation menu, whereas actually it is getting overlapped
Steps to reproduce the problem: After logging in, press f12 and decrease the vertical screen size by dragging it above
Environment (component version number, Browser (including version), operating system, hardware, etc): Chrome browser
Screenshots (optional, but very helpful): Already attached
Code examples help us better understand the issue - follow the CodePen or jsfiddle, templates, which both use polygit, to help explain the issue.

I believe this was mitigated by the v1 refactoring that Greg completed.


Google+ Provider does not honor IdentityServerOptions.PublicOrigin

When Identity Server is deployed behind a load balancer with SSL termination at the load balancer, one can use the IdentityServerOptions.PublicOrigin to control the URLs that are generated by Identity Server and make sure they look like the load balancer's endpoint.
Say the load balancer endpoint is https://my-public-id-srv and the nodes listen on http://node1:8080 and http://node2:8080. Notice that load balancer requires SSL while the nodes do not.
For this setup one sets a couple of properties in the IdentityServerOptions object:
IdentityServerOptions.PublicOrigin = "https://my-public-id-srv"
IdentityServerOptions.RequireSsl = False
There is an issue with the Google+ AuthProvider. In this setup, Identity Server is generating a request to Google with redirecturi = http://my-public-id-srv. Notice that it does not use SSL as specified in the PublicOrigin property.
It seems this behavior comes from line 66 in GooglePlusAuthenticationHandler (https://github.com/owin-middleware/OwinOAuthProviders/blob/master/Owin.Security.Providers/GooglePlus/GooglePlusAuthenticationHandler.cs) where the schema to use is assumed to be the one in the request. However, the request to Identity Server was http because SSL terminated at the load balancer. Instead, this handler should generate a redirecturi that uses PublicOrigin property.
Did some research in the Identity Server Core and found how the Public Origin is used in the WS-Federation metadata, which I imagine is something similar to what is needed here:
Context.Environment.GetIdentityServerBaseUrl()
Where Context is the IOwinContext. The line above returns "https://my-public-id-srv/sts/"
There are other extension methods like:
Context.Environment.GetIdentityServerHost() that returns "https://my-public-id-srv"
Context.Environment.GetIdentityServerBasePath() that returns "/sts/"
Regards,
-Santiago

Do you mind fixing and submitting a pull request please?
Alternatively look into using the Google OAuth provider which comes as part of ASP.NET Identity...

Managed to make some changes on a local version and it is working now as expected. Will submit a pull request in a few days when I get some time.
-S


Code the About Page

Turn the Figma design into code
https://github.com/jSunpayco/opensac.org/tree/about-page

Created a PR https://github.com/code4sac/opensac.org/pull/31


Why don't we check for Enum.IsDefined on action parameters of enum type

    [HttpGet("test/{value}")]
    public IActionResult Test(MyEnum value)
    {
        if (!ModelState.IsValid)
            return BadRequest(ModelState);
    }

Currently, if you send a request to test/999, ModelState.IsValid will be true regardless of whether Enum.IsDefined(typeof(MyEnum), 999) is true or not. However, if you send a request to test/abc and there is no abc member defined in MyEnum, ModelState.IsValid will be false. I think that's probably because strings are bound to enum parameters via Enum.Parse, while numerical values are directly set (and thus any value valid for the underlying enum type will be accepted).
Wouldn't it be more consistent if validation was made on both? If this would be a breaking change, then can we have a new constraint or attribute that does this validation? Or maybe a [easy, simple, obvious] way to tell ASP.NET to not try to deserialize the paramater to an int (so that the client would be forced to use the string representation of the enum)?

This isn't a bad idea at all.
For background, we don't implement any special type handling from enums, we just use the built-in type converter, but this isn't a bad idea at all.

If this would be a breaking change, then can we have a new constraint or attribute that does this validation?

If we added this by default we could also have a knob to turn it off globally or per-model

While this isn't implemented, is there a way to add some sort of custom validator to do that?

Yes, I was start by implementing IModelValidatorProvider. Your validator provider should create a custom validator each time it's called with an appropriate type.
https://github.com/aspnet/Mvc/blob/dev/src/Microsoft.AspNetCore.Mvc.Abstractions/ModelBinding/Validation/IModelValidatorProvider.cs
https://github.com/aspnet/Mvc/blob/dev/src/Microsoft.AspNetCore.Mvc.Abstractions/ModelBinding/Validation/IModelValidator.cs

Thanks!

The issue here with this is that the type converter for enum supports using integers, and will allow integral values that don't match the enum values. I'd suggest that rather than a validator this should be done in the model binder.
/cc @Eilon we should look at fixing this since users have a reasonable expectation that we validate this.

Ok, moving to 2.1. I agree that we should implement validation for this in a way that a developer would reasonably expect to work.

On discussing with @dougbu , came to know that there is an EnumDataTypeAttribute from DataAnnotations which can be used to validate an Enum type. I have tried it and it works. However I see that the scenario (or repro) in the original post shows using the Enum as a parameter directly, in which case this does not work as validation of data annotation attributes on parameters is not supported (right?).
@rynowak we needn't do anything here anymore?

We do plan to support data annotations on parameters and other "top level" bindings.
However, that doesn't change the fact that a user's expectations are left completely unsatisfied with the current behavior of enums. That's what we want to fix. It's good to know that there's a "workaround," but we decided that having to use a workaround isn't good enough.


Relax gen_state_machine dep to allow v3.0.0

This updates the dependency so that both ~2.0 and ~3.0 versions are
allowed. The v3.0.0 version is not as backwards incompatible as it may
sound. It sets new minimum supported OTP and Elixir versions as can be
seen in the release notes:
https://github.com/ericentin/gen_state_machine/releases/tag/v3.0.0

Pull Request Test Coverage Report for Build 1

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 87.888%

Totals

Change from base Build 51:
0.0%

Covered Lines:
566

Relevant Lines:
644

💛  - Coveralls

As a Nerves user, I would be very happy to see that change happen. It currently forces a downgrade to 2.1.0 in my Nerves project.


Missing some types for sys.external_data_sources

In the docs for the system view sys.external_data_sources, type and type_desc only list the following types -
0 - HADOOP
1 - RDBMS
2 - SHARD_MAP_MANAGER
3 - RemoteDataArchiveTypeExtDataSource
I've already discovered that there are the following undocumented values
5 - BLOB_STORAGE
6 - NONE
I couldn't work out what type 4 was but that is also missing, whether it is simply reserved for future use or not. Could this be updated with all the supported types?
Thanks

@RobClenshaw -- Rob, thank you for your well-researched feedback.
@stevestein -- Steve, please look into this issue.

@RobClenshaw - I created an internal work item (1829248) to investigate and update with any additional values.
Thanks for pointing this out.

Closing per internal tracking of this feedback. @WilliamDAssafMSFT William, please take a look at this issue and the associated work item to see if this influences the work you're doing in related areas of the documentation external data sources. Thank you! #please-close

#reassign:williamdassafmsft

@RobClenshaw Thanks again for submitting this issue. Your suggestions help improve our documentation. A document update is in flight to complete the possible values for this field and should be published later today.

Thanks for the update :)


Sync doc template with code

@Ovnuniarchos you might want to have a look at the diff to see what the "doctool" discards when updating the template.

@StraToN I updated the description of Vector2.angle() in 0c8dda8 if you want to check.


[Windows] PlugUpdate seems to have become really slow

I have 53 plugins. vim-plug used to update plugins decently quickly on windows (30s) earlier. on my linux desktop, this is closer to 10s. However, of late, it's started taking a really long time (~120s) and the update looks to be happening serially.
If I open task manager though - I see multiple copies of git.exe being spawned - so that doesn't look to be the issue.
This happens both under vim8 and neovim on windows.
For neovim, I have *jobstart, ruby and python3.
For vim8, python3 and ruby are available.
I'm not quite sure what else to check - so is there anything else to get some diagnostics into where PlugUpdate is slowing down?

NVIM v0.2.1-939-gdb999821d
Build type: RelWithDebInfo
Compilation: C:/msys64/mingw64/bin/gcc.exe -Wconversion -DNVIM_MSGPACK_HAS_FLOAT32 -DNVIM_UNIBI_HAS_VAR_FROM -Og -g -Wall -Wextra -pedantic -Wno-unused-parameter -Wstrict-prototypes -std=gnu99 -D__USE_MINGW_ANSI_STDIO -D_WIN32_WINNT=0x0600 -Wvla -fdiagnostics-color=auto -DINCLUDE_GENERATED_DECLARATIONS -IC:/projects/neovim/build/config -IC:/projects/neovim/src -IC:/projects/neovim/.deps/usr/include -IC:/projects/neovim/.deps/usr/include -IC:/msys64/mingw64/include -IC:/projects/neovim/.deps/usr/include -IC:/projects/neovim/.deps/usr/include -IC:/projects/neovim/.deps/usr/include -IC:/msys64/mingw64/include -IC:/msys64/mingw64/include -IC:/projects/neovim/build/src/nvim/auto -IC:/projects/neovim/build/include
Compiled by appveyor@APPVYR-WIN

Type:

[x] Bug
[ ] Enhancement
[ ] Feature Request
[x] Question

OS:

[ ] All/Other
[ ] Linux
[ ] OS X
[x] Windows

Vim:

[ ] Terminal Vim
[x] GVim
[x] Neovim

neovim :CheckHealth returns
## Python 2 provider (optional)
  - INFO: Disabled. g:loaded_python_provider=1

## Python 3 provider (optional)
  - INFO: Using: g:python3_host_prog = "d:/sdks/python36/python.exe"
  - INFO: Executable: d:/sdks/python36/python.exe
  - INFO: Python3 version: 3.6.1
  - INFO: python.exe-neovim version: 0.1.13
  - SUCCESS: Latest python.exe-neovim is installed: 0.1.13

## Ruby provider (optional)
  - INFO: Ruby: ruby 2.4.1p111 (2017-03-22 revision 58053) [x64-mingw32]
  - INFO: Host: C:/tools/ruby24/bin/ruby.EXE
  - SUCCESS: Latest "neovim" gem is installed: ruby 2.4.1p111 (2017-03-22 revision 58053) [x64-mingw32]

https://github.com/junegunn/vim-plug/pull/676 and https://github.com/junegunn/vim-plug/pull/681 are merged so vim-plug runs most shell commands by writing it to a temporary batchfile and then executing it. This is for properly escaping some arguments and working around implementation differences between Vim and Neovim. fzf's Vim plugin and fzf.vim use the same strategy for Windows support but more robustly because the user can pass a list type, similar to jobstart.
The implementation can be improved but Vim and Neovim will be handled separately.

I'm on macOS and it seems my setup is getting slow out of nowhere also.

I am experiencing this too, plug update become really slow on Windows. Ubuntu is still rather fast.

FYI, vim 8 has job_start, similar to neovim's jobstart, so vim-plug uses native job API instead of python/ruby. The bottleneck is on Vim writing to a temporary batchfile for every :!, system(), job_start() (vim 8) or jobstart() (nvim). Removing the temporary batchfile risks breaking valid commands because of Vim's implementation for :! and system(). Neovim doesn't have this limitation anymore in the nightly release so it can be optimized.
I don't regularly upgrade my plugins so this is a low priority for me. Feel free to open a PR to tweak it for Neovim (nightly) if you're familiar with cmd.exe quirks.

I assume you were using python/ruby before because this slowness is specific to GVim on Windows because cmd.exe needs a console and Windows will force one. This slowness is not as noticeable in terminal Vim because the batchfiles run in the same console. You can try set guioptions+=! to use :terminal for :! but that's outside vim-plug's scope and system will still force a new console. Perhaps vim-plug can batch the creation/deletion of temporary batchfiles but I don't know how to do it.

https://github.com/junegunn/vim-plug/pull/860 is merged which should speed up parallel install/update if using Vim 8 or Neovim regardless of the user's shell. If it's not fast enough, s:system can be enhanced to bypass the shell on Neovim.

So gvim 8.1 - 302s
neovim 4.0 unstable 200s
Since I first ran gvim, it actually had to pull in updates to plugins. When neovim ran, everything was up to date
Also, I'm now at only 44 plugins (compared to 53 of the initial report)

I assume it increased because the temporary batchfiles increased in size to support utf-8 (same code from fzf Vim plugin, WIP) and the new shellescape code. Shellescape can be optimized similar to how vim-fugitive  does it in https://github.com/tpope/vim-fugitive/blob/c63fd1b71be037d4fd583649303875ad0fd17b57/autoload/fugitive.vim#L51. I don't know how else to improve the performance with the Windows shell.
@raghur Do you change your &shell before running PlugInstall?

@raghur Do you change your &shell before running PlugInstall?

No I didn't. Should I?
I did try set guioptions+=! - but that didn't seem to help much.

@raghur Do you change your &shell before running PlugInstall?

No I didn't. Should I?
I did try set guioptions+=! - but that didn't seem to help much.

It's fine. Default case (cmd.exe) hasn't improved :disappointed: .

Is the performance better now?

Unfortunately, no. I ran PlugUprade and then restarted and ran PlugUpdate
45 Plugins - updated in 161s
Win10 x64, Neovim nightly

Here goes with plug.vim from the PR. Btw, my config's reduced to 39 plugins now. I'm a little puzzled why I'm not seeing an improvement.
Updated. Elapsed time: 338.211278 sec.
[=======================================]

- Finishing ... Done!
- Post-update hook for fzf ... OK
- Post-update hook for coc.nvim ... OK
- Latest tag for * -> v0.0.78 (coc.nvim)
- vim-polyglot:  create mode 100644 syntax/unison.vim
- vim-choosewin: Already up to date.
- ale:  create mode 100644 test/test_hover_parsing.vader
- vim-textobj-line: Already up to date.
- vim-textobj-user: Already up to date.
- fzf.vim: Aborting
- vim-snippets:  create mode 100644 snippets/gitcommit.snippets
- MatchTag: Already up to date.
- vim-textobj-function: Already up to date.
- vim-helpnav: Already up to date.
- vim-hug-neovim-rpc:  1 file changed, 4 insertions(+)
- clever-f.vim: Already up to date.
- vim-go:  15 files changed, 477 insertions(+), 122 deletions(-)
- vim-repeat: Already up to date.
- vim-commentary: Already up to date.
- coc.nvim:    c5f78fdc..806ce475  release    -> origin/release
- NeoFormat:  create mode 100644 autoload/neoformat/formatters/typescriptreact.vim
- eregex.vim: Already up to date.
- vim-textobj-function-javascript: Already up to date.
- ultisnips: Already up to date.
- vim-ghost: Already up to date.
- matchit.zip: Already up to date.
- vim-bookmarks: Already up to date.
- vim-misc: Already up to date.
- vim-airline-themes:  2 files changed, 10 insertions(+), 9 deletions(-)
- vim-surround: Already up to date.
- vim-colorschemes: Already up to date.
- auto-pairs: Already up to date.
- targets.vim: Already up to date.
- vim-closetag: Already up to date.
- sparkup: Already up to date.
- fzf:  16 files changed, 462 insertions(+), 112 deletions(-)
- vim-ragtag: Already up to date.
- vim-airline:  create mode 100644 autoload/airline/formatter/short_path.vim
- undotree: Already up to date.
- nvim-yarp: Already up to date.
- vim-gnupg: Already up to date.
- vim-session: Already up to date.
- vim-rooter:  4 files changed, 389 insertions(+), 288 deletions(-)

@mattn Ping.

@raghur Can you profile the vim-plug code?
:help :profile

@raghur Generally, Windows external command execution is very slow. vim-plug runs a lot of git commands.  And fetch. My patch only makes some of these things faster. By the way, I'm using 38 plugins and PlugUpdate finishes in about 40 seconds.

Yeah - I understand the why. I think my numbers might be something to do outside of Vim - likely antivirus/real time scanning etc. that I cannot disable (work m/c)

Yeah - I know.. but when the slowdown was first noticed, even then the same antivirus/endpoint protection crap was active - so I reasoned that it wasn't a factor. Today as I was digging into this, I noticed that some processes of the antivirus suite are going up to 30% CPU :( - so maybe it is a factor.
BTW, I tried profiling - :profile start filename, :PlugUpdate, :profile stop - but it just writes a 0byte file.

:profile func
is needed.
You need to research func name pattern.

here you go
FUNCTION  <SNR>14_update_finish()
    Defined: ~\AppData\Local\nvim\autoload\plug.vim:1280
Called 1 time
Total time: 132.359899
 Self time:   0.243230

count  total (s)   self (s)
    1              0.000002   if exists('s:git_terminal_prompt')
                                let $GIT_TERMINAL_PROMPT = s:git_terminal_prompt
    1              0.000000   endif
    1   0.000037   0.000007   if s:switch_in()
    1              0.000008     call append(3, '- Updating ...') | 4
   40              0.000474     for [name, spec] in items(filter(copy(s:update.all), 'index(s:update.errors, v:key) < 0 && (s:update.force || s:update.pull || has_key(s:update.new, v:key))'))
   39   0.016823   0.000988       let [pos, _] = s:logpos(name)
   39              0.000051       if !pos
                                    continue
   39              0.000025       endif
   39              0.000140       if has_key(spec, 'commit')
                                    call s:log4(name, 'Checking out '.spec.commit)
                                    let out = s:checkout(spec)
   39              0.000117       elseif has_key(spec, 'tag')
    1              0.000004         let tag = spec.tag
    1              0.000008         if tag =~ '\*'
    1   1.969490   0.000073           let tags = s:lines(s:system('git tag --list '.plug#shellescape(tag).' --sort -version:refname 2>&1', spec.dir))
    1              0.000007           if !v:shell_error && !empty(tags)
    1              0.000005             let tag = tags[0]
    1   0.005765   0.000034             call s:log4(name, printf('Latest tag for %s -> %s', spec.tag, tag))
    1              0.000016             call append(3, '')
    1              0.000002           endif
    1              0.000000         endif
    1   0.003681   0.000020         call s:log4(name, 'Checking out '.tag)
    1   2.025852   0.000082         let out = s:system('git checkout -q '.plug#shellescape(tag).' -- 2>&1', spec.dir)
   38              0.000025       else
   38              0.000149         let branch = get(spec, 'branch', 'master')
   38   0.191398   0.000977         call s:log4(name, 'Merging origin/'.s:esc(branch))
   38 121.514751   0.002422         let out = s:system('git checkout -q '.plug#shellescape(branch).' -- 2>&1'. (has_key(s:update.new, name) ? '' : ('&& git merge --ff-only '.plug#shellescape('origin/'.branch).' 2>&1')), spec.dir)
   39              0.000055       endif
   39              0.110829       if !v:shell_error && filereadable(spec.dir.'/.gitmodules') && (s:update.force || has_key(s:update.new, name) || s:is_updated(spec.dir))
                                    call s:log4(name, 'Updating submodules.  Elapsed time: ' . split(reltimestr(reltime(s:update.start)))[0] . ' sec.')
    1   0.000108   0.000008     call s:switch_out('normal! gg')
    1              0.000000   endif

FUNCTION  <SNR>14_update_vim()
    Defined: ~\AppData\Local\nvim\autoload\plug.vim:1516
Called 1 time
Total time:   1.785626
 Self time:   0.000018

count  total (s)   self (s)
    1              0.000002   let s:jobs = {}

    1   0.000137   0.000006   call s:bar()
    1   1.785485   0.000009   call s:tick()

FUNCTION  <SNR>14_update()
    Defined: ~\AppData\Local\nvim\autoload\plug.vim:797
Called 1 time
Total time:   2.204861
 Self time:   0.000020

count  total (s)   self (s)
    1   2.204858   0.000017   call s:update_impl(1, a:force, a:names)

FUNCTION  <SNR>14_update_impl()
    Defined: ~\AppData\Local\nvim\autoload\plug.vim:1152
Called 1 time
Total time:   2.204841
 Self time:   0.047145

count  total (s)   self (s)
    1              0.000024   let sync = index(a:args, '--sync') >= 0 || has('vim_starting')
    1              0.000006   let args = filter(copy(a:args), 'v:val != "--sync"')
    1              0.000007   let threads = (len(args) > 0 && args[-1] =~ '^[1-9][0-9]*$') ? remove(args, -1) : get(g:, 'plug_threads', 16)

    1   0.000385   0.000265   let managed = filter(copy(g:plugs), 's:is_managed(v:key)')
    1              0.000079   let todo = empty(args) ? filter(managed, '!v:val.frozen || !isdirectory(v:val.dir)') : filter(managed, 'index(args, v:key) >= 0')

    1              0.000002   if empty(todo)
                                return s:warn('echo', 'No plugin to '. (a:pull ? 'update' : 'install'))
    1              0.000001   endif

    1              0.000003   if !s:is_win && s:git_version_requirement(2, 3)
                                let s:git_terminal_prompt = exists('$GIT_TERMINAL_PROMPT') ? $GIT_TERMINAL_PROMPT : ''
                                let $GIT_TERMINAL_PROMPT = 0
                                for plug in values(todo)
                                  let plug.uri = substitute(plug.uri<EMAIL_ADDRESS>'https://github.com', '')
                                endfor
    1              0.000001   endif

    1              0.001817   if !isdirectory(g:plug_home)
                                try
                                  call mkdir(g:plug_home, 'p')
                                catch
                                  return s:err(printf('Invalid plug directory: %s. '.

Closing an old issue. Please leave a comment if this still matters to you.


Allow compilation for STM32F4 target.

Allow Compilation of mbedtls  for STM32F4.
Hardware entropy is not implemented (a compilation warning is shown
about that.)

Build finished. No test results found.

Thanks for your contribution, However, at this point our priority is to get the correct framework in place for later supporting RNG on many platforms. The current situation, which can be described as a hack, is temporary, so we will not include more platforms in this hack.
Stay tuned for upcoming improvements :)


Add missing DELETE method support

Codecov Report

Merging #309 into develop will increase coverage by 0.1%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           develop     #309     +/-   ##
==========================================
+ Coverage    92.86%   92.96%   +0.1%
==========================================
  Files           64       63      -1
  Lines         2440     2475     +35
  Branches       216      218      +2
==========================================
+ Hits          2266     2301     +35
  Misses         146      146
  Partials        28       28

Impacted Files
Coverage Δ

datahub/investment/urls.py
100% <ø> (ø)
:arrow_up:

datahub/core/utils.py
82.97% <100%> (+1.58%)
:arrow_up:

datahub/investment/views.py
94.39% <100%> (+1.89%)
:arrow_up:

datahub/metadata/views.py
100% <0%> (ø)
:arrow_up:

datahub/investment/signals.py

datahub/investment/serializers.py
99.09% <0%> (ø)
:arrow_up:

datahub/search/views.py
98.57% <0%> (+0.13%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f1c9c73...be0e3b3. Read the comment docs.


moveit_task_constructor: 0.1.0-2 in 'noetic/distribution.yaml' [bloom]

Increasing version of package(s) in repository moveit_task_constructor to 0.1.0-2:

upstream repository: https://github.com/ros-planning/moveit_task_constructor.git
release repository: https://github.com/ros-gbp/moveit_task_constructor-release.git
distro file: noetic/distribution.yaml
bloom version: 0.11.2
previous version for package: 0.1.0-1

moveit_task_constructor_capabilities
* Initial release
* Contributors: Michael Görner, Robert Haschke

moveit_task_constructor_core
* Initial release
* Contributors: Michael Görner, Robert Haschke, Captain Yoshi, Christian Petersmeier, Henning Kayser, Jafar Abdi, Tyler Weaver

moveit_task_constructor_demo
* Initial release
* Contributors: Michael Görner, Robert Haschke

moveit_task_constructor_msgs
* Initial release
* Contributors: Michael Görner, Robert Haschke

moveit_task_constructor_visualization
* Initial release
* Contributors: Robert Haschke, Michael Görner

rviz_marker_tools
* Initial release
* Contributors: Robert Haschke, Michael Görner

There seems to be still an error... Closing for now.


await audioService.InitializeAsync(mp) always returns error

I am using the code exactly as described in the readme.
private readonly INativeAudioService audioService;
await audioService.InitializeAsync(url);
this line always gives me the same exception: "Object reference not set to an instance of an object."
I confirmed that the url plays the mp3 just fine in the web browser so it is there and available
what am I doing wrong

do you have init the audioService?

Maybe you can refer to this：
`
public class PlayerService
{
private readonly INativeAudioService audioService;
public PlayerService(INativeAudioService audioService, WifiOptionsService wifiOptionsService)
{
    this.audioService = audioService;
}
async Task PlayAsync(MediaPlay episode, bool isPlaying, double position = 0){
   ......
        await audioService.InitializeAsync(episode);
   ......
}
...

}
`

This suggest does not work on Android. Neither does MauiAudio.Sample.

Hello, I review the code in sample, and fix the bug, and also rewrite the readme. Maybe you can try again. ( But maybe still play slowly, maybe need to wait few seconds, I think there still some bugs to fix.)

I had this exact problem on Android, then realised I hadn't added the initialization code in MainActivity. By the way, the ReadMe for Android says "MainApplication.cs" for this initialisation code, when I 'm pretty sure it means "MainActivity.cs".

ok, thank you @iascience. I have change the ReadMe.


Not working in web workers

After discussing with @vsavkin, it was determined that our utility for getting a reference to the root or global scope was not properly handling scenarios where RxJS Next was being run in a Web Worker.
In a web worker, the global scope is self and not global or window.

@blesh @vsavkin we should probably remove the global stuff anyway (in favor of some flavor of DI).

but I can DI anything sideways in JavaScript! :P look at me:
window.setTimeout = function(cb) {
  console.log('haha! no timeout for you!');
  cb();
  return 'LOLZ';
};

@blesh that's exactly why we should move to "functor modules" like @steveorsomethin uses.

Yeah, I like that idea. I'm concerned about the consumption by "the masses" a little. Just default usage seems like it would be really strange for people.
Rx().Observable ... people would be like "why is the namespace a function?". I think i most cases, many developers would end up calling Rx() over and over again, rather than caching the result, when 99.999999% of the time they just want one instance and configuration of Rx.
As it currently stands, given the modular nature of the library, experts would be welcome to do that on their own, of course.

@blesh my proposal:

import Rx from '@ReactiveX/RxJS' would give you Rx like normal
import ObservableFactory from '@ReactiveX/RxJS/Observable' would give you back the Observable's "functor module" which accepts all its dependencies as parameters (including the classes it would normally import).

Then people can instrument versions of Rx with overridden globals, etc. as would have been the solution here.

That might mesh well with Angular's DI, actually. @vsavkin? @jeffbcross?

@blesh this also fixes the wacky TVJS (appleTV) bug i discovered the other day :+1:
I don't believe we're dependency-injecting Observables anywhere in NG2 (yet) but I'm all for @trxcllnt's proposal.


Cannot run the material-start project

Npm install loop on :
fetchMetadata → resolveWi ▐ ╢██████████░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░╟
I cannot go further in the process.
Is there something to fix first in package.json ?

@LouisJS - please provide more information:

which branch are you using on material-start ?
which version of Node, NPM, and gulp ?

@ThomasBurleson
I'm using the basic branche (Master)
Version :

Npm  :  3.8.3
Node : v5.10.0

I don't have gulp.

cd <project_root>;
npm update; npm install -g live-server
live-server;

Browse to http://<IP_ADDRESS>:8080/app/.

This works fine in master.


RaisedButton and FlatButton are deprecated and should be replaced .

In the codebase FlatButton and Raisedbutton is used in many places.The original classes will be deprecated soon, please migrate code that uses them.

If you are not working on this, can @Erarshad please assign this to me?

If you are not working on this, can @Erarshad please assign this to me?

I am working on this ,but maintainer is not responding

sorry i was busy with semester exam prep, i am allotting this task to you

alloted to you

I am new to this project and I don't have a Deluge username and password to try this app. Can anyone guide me on how to get the login credentials ?

Hi if this issue is not assigned to anyone can I pick this up?

Hi if this issue is not assigned to anyone can I pick this up?

allotted to you

Hi if this issue is not assigned to anyone can I pick this up?
allotted to you, but you have to submit proof of concept means, it should get compiled and running well (it could be a screenshots or screenrec vdo) then i will merge

Thanks, will do


Live Demo

Hi @ethnhe,
thanks again for your awesome work.
Do you have any code snippets or working code for a live demo (i.e. with a kinect). Would it even be possible?
Could you give me some hints?
Sorry if that's not an actual issue with the project.
Thank you very much.

We didn't write live demo scripts. But with the provided *demo.py and *dataset.py scripts, it's not hard to integrate them for a live demo. You only need to get the input RGBD images from a sensor, preprocess them with code in *dataset.py, and then feed it into the model to get the result using code in *demo.py.

Thank you.

Hi @jako-dev,
Did you manage to do a live demo ? do you have any code snippets or working code ?
Thank you very much for your time and consideration.


current keybase cli cannot login on old accounts!

I have had to wipe my linux machine and have reimported my keys in gpg from a backup.
gpg is happy :
ranyardm@osxreally-af58 ~/Downloads $ gpg --list-keys
/home/ranyardm/.gnupg/pubring.gpg
---------------------------------
pub   2048R/CFAEF3F4 2014-01-10
uid                  Martyn Ranyard (2014 onwards<EMAIL_ADDRESS>uid                  keybase.io/imartyn<EMAIL_ADDRESS>sub   2048R/5DC2D226 2014-01-10
but keybase refuses to login :
ranyardm@osxreally-af58 ~ $ keybase login
Your keybase username or email address: iMartyn
▶ ERROR Sorry, your account is already established with a PGP public key, but this
utility cannot find the corresponding private key on this machine.
This is the fingerprint of the PGP key in your account:

   4C31 0155 7BA5 83F4 7FF7 9776 AB4A 6048 CFAE F3F4

You need to prove you're you. We suggest one of the following:

   - put one of the PGP private keys listed above on this machine and try again
   - reset your account and start fresh: https://keybase.io/#account-reset
Please don't make me revoke my pgp key and all my proofs :(

Run gpg -K?

ranyardm@osxreally-af58 ~/src/grafana_ng (BPE-49) $ gpg -K
/home/ranyardm/.gnupg/secring.gpg
---------------------------------
sec   2048R/CFAEF3F4 2014-01-10
uid                  Martyn Ranyard (2014 onwards<EMAIL_ADDRESS>uid                  keybase.io/imartyn<EMAIL_ADDRESS>ssb   2048R/5DC2D226 2014-01-10

Can you please run a keybase log send?

Log id 5acb5891d19f932462283a1c

▶ WARNING error opening log "/home/ranyardm/.cache/keybase/keybase.kbfs.log": open /home/ranyardm/.cache/keybase/keybase.kbfs.log: no such file or directory
▶ WARNING error opening log "/home/ranyardm/.cache/keybase/Keybase.app.log": open /home/ranyardm/.cache/keybase/Keybase.app.log: no such file or directory
▶ WARNING error opening log "/home/ranyardm/.cache/keybase/keybase.updater.log": open /home/ranyardm/.cache/keybase/keybase.updater.log: no such file or directory
▶ WARNING error opening log "/home/ranyardm/.cache/keybase/keybase.start.log": open /home/ranyardm/.cache/keybase/keybase.start.log: no such file or directory
whilst running that btw.

Also fwiw, rm -rf ~/.config/keybase ~/.cache/keybase makes no difference either :(

Also, debian wheezy ships with gpg1 as gpg, and gpg2 as gpg2, both see my keys correctly, and swapping them over makes no difference (/usr/bin/gpg as a symlink to /usr/bin/gpg2)

Those WARNING messages are fine.
I'm looking at your log right now.  I see the output of gpg -K above, but could you also run
gpg -K --with-colons --fingerprint

I'm guessing we have a bug parsing the output of that as we can't seem to find CFAEF3F4.

there's interesting... that returns no output!

how about
gpg2 -K --with-colons --fingerprint

oh, gpg2 doesn't. gpgp1 gives
sec::2048:1:AB4A6048CFAEF3F4:2014-01-10::::Martyn Ranyard (2014 onwards) <martyn@ranyard.info>:::
fpr:::::::::4C3101557BA583F47FF79776AB4A6048CFAEF3F4:
uid:::::::2391910FD2F9028AF3A6311C1DF800381ABDF214::keybase.io/imartyn<EMAIL_ADDRESS>ssb::2048:1:CBDE4D4D5DC2D226:2014-01-10:::::::

Ok, so keybase is preferring to use gpg2 if it finds it.  Perhaps the private key is only in the gpg1 keyring?

@iMartyn  which version of gpg2 do you have?

I didn't have gpg2 installed originally.
gpg (GnuPG) 2.1.11

wait... what.... ugh debian packaging is horrid.  gpgv2 is not gpg2

Okay, I can't seem to transfer the keys to gpg2 correctly.  I don't think it likes them not having a passphrase locally.  I guess this can be closed for now, with the slight issue that the error doesn't point out that the machine has gpg1 and gpg2 installed, which I'd consider a usability bug.

You can do keybase config set gpg gpg to disable defaulting to gpg2

Were you able to provision your linux machine successfully?

Yep, by doing the suggested command from @maxtaco, I'm doing that now and have got further.


update README.md for imodeljs-samples

Update the README.md file so it does not indicate the user to :
Configure your app using the value you obtained from the registration process. In the specific sample subfolder, edit src/config.json to refer to the project.
It should refer to the combined configs (configuration.ts + config.json) under the .env.local in the app root directory.

Nevermind,  I saw that is was updated,


How do I support multiple GPU in the laptop or choose GPU 1 if the system have 2 ?

There is a laptop with Intel GPU as GPU 0 and Nvidia T600 as GPU 1,
Is it possible for us to tweak the settings to point to a faster Nvidia T600 GPU?
is the configuration done via Chrome or the WEBLLM?

I found something with google like that:
https://pureinfotech.com/set-gpu-app-windows-10/
you can set the GPU to an APP for example chrome app should use a specific gpu

webgpu only support single gpu for now,and likely will choose the best default i think

on windows it choose the GPU wich you have assigned to the app "chrome"
see => https://pureinfotech.com/set-gpu-app-windows-10/